From xen-devel-bounces@lists.xenproject.org Wed Dec 01 05:43:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 05:43:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235583.408661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msIOg-0006dY-5k; Wed, 01 Dec 2021 05:43:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235583.408661; Wed, 01 Dec 2021 05:43:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msIOf-0006dQ-Vt; Wed, 01 Dec 2021 05:43:13 +0000
Received: by outflank-mailman (input) for mailman id 235583;
 Wed, 01 Dec 2021 05:43:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msIOe-0006dG-90; Wed, 01 Dec 2021 05:43:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msIOd-0004JD-UQ; Wed, 01 Dec 2021 05:43:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msIOd-0005QV-EF; Wed, 01 Dec 2021 05:43:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msIOd-0000eT-Dl; Wed, 01 Dec 2021 05:43:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MhpBlc87We8Mgt+16f4SL6mWcqyO9RRaHKWR31pRn/4=; b=Do1TjDxIQ0wcOGlwQtl3ng2azb
	yd1I4X+FFfetr8D13b/Ziu8t8kGLa1Bh0pYK202XUFNu4+nPvyY7C2QVsAwVqmqaInxVxgM3jiE6h
	G089BBCAk7SVn1G3rzIMEh1m9jyOtUK/RigZUPh1WhUdtCNIpAm2J5YluF5ymrZweJiY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166960-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 166960: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start.2:fail:regression
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=0e6c87b93e1d35fedf9cebd65395c2f79b4af11a
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 05:43:11 +0000

flight 166960 xen-unstable real [real]
flight 166964 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/166960/
http://logs.test-lab.xenproject.org/osstest/logs/166964/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 21 guest-start.2 fail REGR. vs. 166912
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166941

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166964 pass in 166960
 test-amd64-i386-xl     22 guest-start/debian.repeat fail pass in 166964-retest
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166964-retest
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166964-retest
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail pass in 166964-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166941

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166941
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  0e6c87b93e1d35fedf9cebd65395c2f79b4af11a
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    3 days
Testing same since   166960  2021-11-30 12:35:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 0e6c87b93e1d35fedf9cebd65395c2f79b4af11a
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Wed Nov 24 19:06:02 2021 +0000

    Revert "x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents"
    
    OSSTest has identified a 3rd regression caused by this change.  Migration
    between Xen 4.15 and 4.16 on the nocera pair of machines (AMD Opteron 4133)
    fails with:
    
      xc: error: Failed to set CPUID policy: leaf 00000000, subleaf ffffffff, msr ffffffff (22 = Invalid argument): Internal error
      xc: error: Restore failed (22 = Invalid argument): Internal error
    
    which is a safety check to prevent resuming the guest when the CPUID data has
    been truncated.  The problem is caused by shrinking of the max policies, which
    is an ABI that needs handling compatibly between different versions of Xen.
    
    Furthermore, shrinking of the default policies also breaks things in some
    cases, because certain cpuid= settings in a VM config file which used to work
    will now be refused.  Also external toolstacks that attempt to set the CPUID
    policy from a featureset might now see some filled leaves not reachable due to
    the shrinking done to the default domain policy before applying the
    featureset.
    
    This reverts commit 540d911c2813c3d8f4cdbb3f5672119e5e768a3d, as well as the
    partial fix attempt in 81da2b544cbb003a5447c9b14d275746ad22ab37 (which added
    one new case where cpuid= settings might not apply correctly) and restores the
    same behaviour as Xen 4.15.
    
    Fixes: 540d911c2813 ("x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents")
    Fixes: 81da2b544cbb ("x86/cpuid: prevent shrinking migrated policies max leaves")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Roger Pau Monné <roger.pau@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 07:14:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 07:14:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235593.408677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJok-0007hP-3O; Wed, 01 Dec 2021 07:14:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235593.408677; Wed, 01 Dec 2021 07:14:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJok-0007hI-0L; Wed, 01 Dec 2021 07:14:14 +0000
Received: by outflank-mailman (input) for mailman id 235593;
 Wed, 01 Dec 2021 07:14:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P4my=QS=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1msJoi-0007hC-5a
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 07:14:12 +0000
Received: from 5.mo552.mail-out.ovh.net (5.mo552.mail-out.ovh.net
 [188.165.45.220]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 473f19d5-5276-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 08:14:10 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.108.1.125])
 by mo552.mail-out.ovh.net (Postfix) with ESMTPS id B6B2D217F7;
 Wed,  1 Dec 2021 07:14:07 +0000 (UTC)
Received: from kaod.org (37.59.142.105) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 1 Dec
 2021 08:14:05 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 473f19d5-5276-11ec-b941-1df2895da90e
Authentication-Results: garm.ovh; auth=pass (GARM-105G00686e3cafe-0521-4f42-aedc-fcaeb2775d24,
                    A214034E9EDAB49BEA2160BF49F8C38F118F2259) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 90.11.56.15
Message-ID: <39556bdc-f48c-68b2-6bec-5975b92e02e2@kaod.org>
Date: Wed, 1 Dec 2021 08:14:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch 05/22] genirq/msi: Fixup includes
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: <linux-hyperv@vger.kernel.org>, Paul Mackerras <paulus@samba.org>,
	<sparclinux@vger.kernel.org>, Wei Liu <wei.liu@kernel.org>, Ashok Raj
	<ashok.raj@intel.com>, Marc Zygnier <maz@kernel.org>, <x86@kernel.org>,
	Christian Borntraeger <borntraeger@de.ibm.com>, Bjorn Helgaas
	<helgaas@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
	<linux-pci@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
	<ath11k@lists.infradead.org>, Kevin Tian <kevin.tian@intel.com>, Heiko
 Carstens <hca@linux.ibm.com>, Alex Williamson <alex.williamson@redhat.com>,
	Megha Dey <megha.dey@intel.com>, Juergen Gross <jgross@suse.com>, Thomas
 Bogendoerfer <tsbogend@alpha.franken.de>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, <linux-mips@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>
References: <20211126222700.862407977@linutronix.de>
 <20211126223824.382273262@linutronix.de>
 <b1a6d267-c7b4-c4b9-ab0e-f5cc32bfe9bf@kaod.org> <87tufud4m3.ffs@tglx>
 <524d9b84-caa8-dd6f-bb5e-9fc906d279c0@kaod.org> <87czmhb8gq.ffs@tglx>
 <875ys9b71j.ffs@tglx>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <875ys9b71j.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [37.59.142.105]
X-ClientProxiedBy: DAG1EX2.mxp5.local (172.16.2.2) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: e52f034b-6a74-4e80-b1cd-9a54c9a992a9
X-Ovh-Tracer-Id: 2359604732828158876
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddriedvgddutdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepjeekvdfgudevkeefkeeltdejteekvdegffegudetgeettdffjeefheekfeelffdtnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehlihhnuhigphhptgdquggvvheslhhishhtshdrohiilhgrsghsrdhorhhg

On 11/30/21 23:41, Thomas Gleixner wrote:
> On Tue, Nov 30 2021 at 23:10, Thomas Gleixner wrote:
> 
>> On Tue, Nov 30 2021 at 22:48, Cédric Le Goater wrote:
>>> On 11/29/21 22:38, Thomas Gleixner wrote:
>>>> On Mon, Nov 29 2021 at 08:33, Cédric Le Goater wrote:
>>>> thanks for having a look. I fixed up this and other fallout and pushed out an
>>>> updated series (all 4 parts) to:
>>>>
>>>>           git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi
>>>
>>> pSeries fails to allocate MSIs starting with this patch :
>>>
>>>    [PATCH 049/101] powerpc/pseries/msi: Let core code check for contiguous ...
>>>
>>> I will dig in later on.
>>
>> Let me stare at the core function..
> 
> It's not the core function. It's the patch above and I'm a moron.

All good now. Ship it !

Thanks,

C.






From xen-devel-bounces@lists.xenproject.org Wed Dec 01 07:14:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 07:14:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235594.408688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJot-00080B-Gv; Wed, 01 Dec 2021 07:14:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235594.408688; Wed, 01 Dec 2021 07:14:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJot-000804-Dl; Wed, 01 Dec 2021 07:14:23 +0000
Received: by outflank-mailman (input) for mailman id 235594;
 Wed, 01 Dec 2021 07:14:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msJos-0007ze-Jb
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 07:14:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4de3dad3-5276-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 08:14:21 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-xLLOAa6tNVytj8IaPAOMgQ-1; Wed, 01 Dec 2021 08:14:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 07:14:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 07:14:16 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:206:1::46) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 07:14:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4de3dad3-5276-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638342860;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kIRH1aImBK6j98HLmRlw4xmYhA7G69JSk+OJxmaJkbU=;
	b=LSQqrD3riuWDWNEZQO/53WsbtQfmM+LZZiEx2n+pMmb28b9m5ZXLw8dP2B8j6MednQvh4e
	rgej7yi/uGzIeC4FSITsPFjBkvtRK/x/UkZ1T3XnglFN0JOuxFO8KRuKoa+yI5KCOHqaSC
	PwPAWu/9HZuq+sLvJ9olKci0rMuxJfk=
X-MC-Unique: xLLOAa6tNVytj8IaPAOMgQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dDpg0oItFKPGi7PT0+AW+8UeEYuUCToPjpnUe4S0si1oAoiqjtAlNHvU9oFUgc5IhGOuRrTcyKG/aYOpGLsv/kjBMiFWXAocZ1UbbM4+xu+cnkppIKWtkedafX4lRlNAYieX2pMowSr3WrqTeCYkFmIwE/1HHqA4Fb86uAMO9vNoXz+mYdmvtw4jG9zVbz9TnwyfaTAFYlJ1RiYXEGLUHnTU7K0eBlZUtQYMuHaiaJiXM9qwVj7tXgt9utg0DhtzHqhcGzPWWTMmDRfESvBLe/KZ+TBVBGP/o+JkXWwR0jy6afP/ECqYDlgMVAtmMOuBG5z1KIjaAvADZRK7eLqa+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kIRH1aImBK6j98HLmRlw4xmYhA7G69JSk+OJxmaJkbU=;
 b=RWBhiGvi2f0fmiYXuRs6UNDcnwuA9zbDvAfUTUikiEYWPPXpGtQ3/IxQ9IIvtES0sIlBeC4jdvZfmFPgfGLImIa51akqmYIBED2xn0fSts+1pE7rgLI8K56aXyLFAtCDPsug2QClQ71icLmnm0ADmBUd6ROuEtLwpdAgyDF+8dKB5sMa9uYE5hC3HDxu475Fea3nZkCzxQrxxQqvxUvhOWhr18l4nA2d7fD49HGx3y0I0B+Xz+EHPmRttmdnYbCIs2A4nI0t8M0GAB7i4r5w5nFkuGEPlAeLlmnAWWsVb8V5tbwbeh6bZyqIIiIYbpt+fcDyM3vXIswncprT6cERKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c9a28b6c-2d60-e1d9-6e7b-21a2f1921ec6@suse.com>
Date: Wed, 1 Dec 2021 08:14:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Content-Language: en-US
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 andre.przywara@arm.com, xen-devel@lists.xenproject.org
References: <20211129191638.19877-1-ayankuma@xilinx.com>
 <7224343c-0af9-6610-a58b-291778183a53@suse.com>
 <cb6d5e10-c37f-58a6-e1be-7dd326e2d826@xilinx.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <cb6d5e10-c37f-58a6-e1be-7dd326e2d826@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0033.eurprd04.prod.outlook.com
 (2603:10a6:206:1::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 12840557-5a5b-4bc9-3837-08d9b49a2f97
X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4349C3B1FF53F28E10DA3D22B3689@VI1PR04MB4349.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Zv/tTx26zKqWlSZZKUbkYZLWkh8f3aC2A4LDqi7fo446ftxki/OPEXdld0mG1ID78QDIb7SXJd46urkPYOlrr9JBGWAvgf2xu5pyP4KPM5obdACZWyqUSaXNgPXqr/8OgrFlsfo1n43Kj5JJjtMuUAhXfEz0ZbgbjetpHk1wdhok6EYb5rhwQoIOfQJQ1Xy8y70Xycxi1fAygf13jJOoXK4drn+tJUEAU+YzJeLgeJK7MZaohB0mRoyYeW4D0hBTdMsbwJO5Zib7hsqvSwUswoCnO2LbGXfXZeAXpOs39ajhg7kj4F3/UsG2OMd3eDAZx+LewIEylIH/BIFef02OnnQukNV2luHOvpcFBOvLvoyUnYDYtMEZDU0U1qkKLwoqP08O4/RrXkOY/o8G22d3be2g/HpriDsQ0LlTdrTRaIQU/Jj6LHiXSZ1vobT/5He4GvEX5oXVK61vF3pyQJvKw7+EP8tuVq60BHOBL0y7R3i1nVkIFBUqBNh0N25qGi96jFWQ2qZBAMS2GOXNao5SMjXi07cdPNNPG1LE9MBHBCnaHXgAnyMMczdJWEatD10UXjNES4AiueKR7xbybrRYWYS/Hai9XF6848DsQrjo777OtrdfV6nlzkh5etYQlU2F7MKfO/qvou+mEEM9glJ2/leIMtYDNA+nipHNozIOFpiSHXXAOYKpiSzQdsy1p6FplZgHUGqnJzYw4gHMhRpFHlODVOa98/QrORkiHe23gledoKmkEXD9a/GgCZrSaej1oXVR/7470+K6o0B5cQUup9cLqcRedrcHm4YlPkTFXoCC8aMKXP/u3SvkAVz4IG0u
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(6916009)(86362001)(508600001)(8936002)(966005)(31696002)(26005)(38100700002)(36756003)(6486002)(4326008)(956004)(53546011)(2616005)(66556008)(66476007)(16576012)(66946007)(316002)(8676002)(186003)(31686004)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NmY2UWJDUW8xZnE2S1dVN0s4QlhoN2FjSklmOWU5VDFZdnZJdnhlU1VlUndj?=
 =?utf-8?B?KzBQY3VweGVPSGcrdG1zWFNNQVpmdUlIQWdlYll5VU4wUm1uUnlZTHVjclhX?=
 =?utf-8?B?QWVSaWw3SExSUERMVDNldStlV2wvNXArUjRmZkRZLzRCa1Y0WFc0VXVTV0dk?=
 =?utf-8?B?dnZyeTdRaFk5Yk9oOGVSRytTQzE5S09QWjZSRFVQQ1dtL1pLbTEyQXBWNEND?=
 =?utf-8?B?UHFHZ2ppRTFGU0F4NUZKQklwMUQ4bnRCOGl4aS9KMDlkWElnUm51dTBzZHlz?=
 =?utf-8?B?eGJXYjQ1WjJmRzBadUJoMzNxY3p1Y0p0dVdwUXBLMVhvS1BISHRLR2gxTFhh?=
 =?utf-8?B?SHBGampTRjl3MUt3MWZNZTliTHc3WnZ4bXg0MDh3YnM4WEtMaDZWc0xKUzk0?=
 =?utf-8?B?RWkvNHd5VkN0cVlTNnpQZFlwM2NObk5WNGZJVnZiVG1XUFUwYStHeDJkdG5K?=
 =?utf-8?B?dllmMk1td3lxVGJwVGR0UUJKSGx3UU5US201czQxeXl4ZEszR0kzWlVGSWlx?=
 =?utf-8?B?WTRSQjl3TXpJSjZ5T3IwcTRlNlc0Uzh5cEdkWTVCUGh6SkR4ZW1Bd2x1U2Ez?=
 =?utf-8?B?MURYK00zVEUyRnJIek1xWllmZXhOOEF1K2RXZzJCNVBuWU85NGV0aXRYVmV4?=
 =?utf-8?B?VUEwd0Q0Y1hmRitBeW1KVkhzTVRnanArazRyVk4zWFkvVzdpNTIrWUFDYkhE?=
 =?utf-8?B?MjhrWitSTDljSSs1SURYMTRRQlBBbmlsNEMrYmFiVmo4TlF4aXFNT3pyWGtX?=
 =?utf-8?B?SXNldldnWHcyMmxBNW5iY2M1R3F6QkNqWDE5YjhHRGo1djRjZ1EvK2gxZFZV?=
 =?utf-8?B?MklOQVptMXduZDA3V3dFMkFsOThQc2d1d3owOVo0UHF6b0o5ODNTZ2FYTFAr?=
 =?utf-8?B?TXdXWjZiYUd1NTBndzdGeGZHTytsTFFDVVp5YjBqdlkzR2h5VkpGMUZkT1Bs?=
 =?utf-8?B?Uk9FaG8xZ09iazhURVlKcTlPUVNZaUxQQmZiSVovMjk2VXhDUjFSN0YrVEgz?=
 =?utf-8?B?VXRNZi9IbmpHa2x1UHdTcUY2TTRISmhtYXp4TC9BcWp2S0hCZ3VLZnl6Nnds?=
 =?utf-8?B?M2dFRXBGUlN5QzdTL0tEUUIxUzd4OFZXRUNxdUloaEdwUXdHd3JxYmtNeU05?=
 =?utf-8?B?b0Z0S1o5YlUxUXlqSzlnc0dDaUNpTk8vYm5LZG4vTU4ydXBweXlEMThPczRD?=
 =?utf-8?B?bEdINUlFZWxFaTdSQ1VlaEkzejloK3hOY3R3NG8zOGtEeW9iT2FjSFU3L040?=
 =?utf-8?B?eW5LaHNhWGIrdjlzaEdaNWU3b2JwTk9BMUpER0NRcjFHL1I4VkVxOEdWZmUv?=
 =?utf-8?B?cVZYaitFTlNkaXg2L3pRdHJBMno1enlDMGdCempWZ0tYeFFlbG1USXR0MlEr?=
 =?utf-8?B?RzduRmIvSFZtRG1pVkV0clpFRktnYWpDRkZzblU1SW53enB1aVN4VytTamJK?=
 =?utf-8?B?eVhvNitZaDVkTysrbm9tKzBxeXBrMDliQlI4SlpXRnhkd0xsSS9UcGU5SGhn?=
 =?utf-8?B?WjdBcFBTNEJJekhmeHRudUgxTHBJdkJxQk96MXRjU3E2UmJsUE5GY00xR0hZ?=
 =?utf-8?B?dmR4cllBQlRFQ3dCMi9pSE1kV0tMMjRIa25NUkt6NmswdWhzQmxMek1qSEtT?=
 =?utf-8?B?MUh1N2ZrbXNSbnlncEZFenZFRkpxbGMvZk5admpLOFlxaURPTHExZldDWlRU?=
 =?utf-8?B?cUdtZitBUTA4YXY4K0JDdFdLZFU5VEIranVyUmNvMk9xamdPaTF4UkoyNnpt?=
 =?utf-8?B?M3BESENOa0ZaQmNGMGNkd2hMOVYzbHpRUVpkZkEyNW5hREorakZJNWZTRlgw?=
 =?utf-8?B?VHFnUnYzR2hndnR2RVlBSTNybVFKZUVtTzFuN0dVbUFsQkcwYWhjZmVRREVJ?=
 =?utf-8?B?TUR6UTcvNVZ1UjVhUDhQRjhnOE55RVl4TU83N1hUWS84Mmh5cnNJRGxpNWV5?=
 =?utf-8?B?bUF1c2p4R0ZnYTdMcS8xNmVmWlNWbmh3VVV6YTV3cktSVXNzSlJuVy9iZXlq?=
 =?utf-8?B?RmF6Z1YxL3ErcTQ1NG94S25pejRYVC9FYUhFZUhWMUNIOElPeFZwaVZNeUEw?=
 =?utf-8?B?MFJaRmREVkgrR1RwUGtQOHBJejF0TW4wSWxJWWRKTWlxUkFvVnE2L2o2L09m?=
 =?utf-8?B?T2c2emFpY2JBdjNiZzVEbEdkWENaOU1NcitDQUJZVlB1K0h1Z1I2OHZMVUM3?=
 =?utf-8?Q?2Yd49YV/zDQ2m8lf5JFx/BI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12840557-5a5b-4bc9-3837-08d9b49a2f97
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:14:16.7587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: awFhI47oEuKP4Pj1cZbrMgSpdaMMPk5vwdOQh+vmXWuVxFAJoYvjqu/3+Zq/YvGvAcL0LXmnNE0BNEYkbvMWTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349

On 30.11.2021 19:35, Ayan Kumar Halder wrote:
> On 30/11/2021 07:57, Jan Beulich wrote:
>> On 29.11.2021 20:16, Ayan Kumar Halder wrote:
>>> +{
>>> +    struct cpu_user_regs *regs = guest_cpu_user_regs();
>>> +    unsigned int val;
>>> +
>>> +    val = get_user_reg(regs, instr->code.rn);
>>> +    val += instr->code.imm9;
>>> +    set_user_reg(regs, instr->code.rn, val);
>>
>> I don't think this handles the SP case correctly, and I also don't see
>> that case getting rejected elsewhere.
> 
> Sorry, I did not understand you. Can you explain a bit more ?
> 
> Following 
> https://www.keil.com/support/man/docs/armasm/armasm_dom1361289873425.htm 
> , Are you saying that we need to handle this restriction
> "You can use SP for Rt in non-word instructions in ARM code but this is 
> deprecated in ARMv6T2 and above"

Are you looking at the correct (part of the) doc? It feels like this is
Arm32 wording (plus it's Rn I'm talking about, not Rt) ... DDI0487G-b
has nothing like this on the "LDR (immediate)" insn page. And even if
it had, "deprecated" doesn't mean "impossible", so you'd still need to
deal with the situation in a way that's not silently doing the wrong
thing (IOW you may be fine not actually emulating the case, but then
you need to clearly fail emulation rather than using XZR).

I have to admit I don't recall what the behavior is when Rt == 31. But
what you may further want to deal with independent of that is Rt == Rn.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 07:22:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 07:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235608.408699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJwL-0001RL-Be; Wed, 01 Dec 2021 07:22:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235608.408699; Wed, 01 Dec 2021 07:22:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msJwL-0001RE-8X; Wed, 01 Dec 2021 07:22:05 +0000
Received: by outflank-mailman (input) for mailman id 235608;
 Wed, 01 Dec 2021 07:22:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msJwJ-0001R8-SS
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 07:22:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60bf0606-5277-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 08:22:03 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-sG1sJa-hNEGROp0zS53M1Q-1; Wed, 01 Dec 2021 08:22:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 07:21:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 07:21:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0072.eurprd06.prod.outlook.com (2603:10a6:20b:464::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Wed, 1 Dec 2021 07:21:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60bf0606-5277-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638343321;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=B5pKpvjPhhnL07N0colGIr/vOt7cJNpx8x4n866goQU=;
	b=PUrUkKtpnj+UQW72vDjN3Kbj7PIdSZU8P8MyOpseU2RqxKlr8Pv1tqAoPQfbzEGiSDxjyE
	/xoU6b5noM8dYkxvMZi+XmCq++FNobE571wfPllGtUbbbgbdbdO4kUnJhA9oY9SySYsMyw
	cWpNLMsyNcwsugut9dSDnNy7l5kUJTM=
X-MC-Unique: sG1sJa-hNEGROp0zS53M1Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b4eaDVJNRRr/7IcweCO3yuCdCOuR9WgjdSmIs4Uda553aypdA5r37OYcz8y8wWW1X/MX1bNm4NqbYUSXy7a78upcoEGmBP1MjtJruPArDvToc5mdc8BbbUjcP2mjooE1hNWMwfW31qy0cgflvchhwUe08nVEOxXT/ZBROKK1AVqK9q4AOV3ybrzR5g1tYg+Kt7IypygkCKhmpMXj8R9/ep/qn306rQ3R1tFB0HM0kqAh5jlSMzH3Ye6HE2+VODD0oFMTP7EOk+/1Ujmf4I1RuZ8pFQ/GY5q0q3QjMgYsoEmLn+SzrCTlfGGjYs1XHhSrj0ku+mozOCD+7eT2eaxVtg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=B5pKpvjPhhnL07N0colGIr/vOt7cJNpx8x4n866goQU=;
 b=L7EVPB9dYC4jSwjmrSBTeTaQviYIwXgRc5U+0dSjeM9rFoo2HNMbhKyhL0qNSXXAVFHtibLc+oR0xryOc7m+z7b/th4nE/E6GoydfqkfhnQJOIAouLThRxf5oa8qOHQhdAceeM/2eUoVEZVjPezXiXELHVXP0k7fvF/sME4yRLDdGFaexsIkq4aI0suYb1qvxJD6LI23FqfsXrNhtY8vzkwMsG2uY6VGawrUe3oSp1j002FcS6Bd9C983InNCy4QuHrx+rFi5PwICESuXJNGZijqdu6mGYGdXi6NIbOZnM3AJ3D45T0sGkirswtm3DDmk3RuN2/iB9LGYG7hA63MSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <41a683e8-9659-76b0-1a87-bb8bbbdc47ff@suse.com>
Date: Wed, 1 Dec 2021 08:21:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
Content-Language: en-US
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, julien@xen.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 Ayan Kumar Halder <ayankuma@xilinx.com>, andre.przywara@arm.com,
 xen-devel@lists.xenproject.org
References: <20211130181238.5501-1-ayankuma@xilinx.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130181238.5501-1-ayankuma@xilinx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0072.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49434173-f9f5-42d1-11a1-08d9b49b42fb
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4190037DAB211028B6149DE7B3689@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BoTUudKiRDWU5thbweOr4mEsToO/4z5nPl62Avby/czbpw5f7xhBLNXHdnLBiBpnOQSWOfeUh+wYPdavJPlQzatk4Z4576895qnupieFkvZ/aUzb6+rNutsAlqIoXY61tdekxEhXMe/1N0tp+eotftCL/IgAmgYYg0DZGKOgtFDs+qQP4cK0PaNY8HH+NK9ycfWKVTtrnAyCFXpe52v2tSzeckN+Qu+CC/ynj0c0hO94Qd4ArbYZ6qrjQsxtgJOBp2+gzFXrRGxkyfMmhwxzJq5ILxo7SRniJqT52PCEGn9GrjsKgokToPAbBJSIi6bpGXQNFYvnrQ8hq3jcW/kj87ThSwJE75qwV3dQAmo09adGThZFGS8TRLEu3pEmDOO7MQJgUaLEAV0pFoqo0W6UWi/NJ7GP1zt+ONvRHJQy+DPny47BS+J3xq96WP5pgk0wuxcpwSV5ZJg6Hc3+Xw9DwnJQfS5Qcm5VeA+Zv32a6CX6c+4HQiNLmLTZH/X5N/HncZi4U6KiVIsiNrQpMhPuVVC6S5yryyjANO63wUWEVLnLJWfURGOdO3TbTLQl3kguDGQlMulbNzNAbrOJnjxfKdZsAg/9p1AQzKm2TFvODRrJtNhwrXS2fpTpXFMhapOuU3DXKFe52Hg5PY269aeCOGQwDcxypLOAggt9IgavDSNKb4FD9UXAR1OZvQz7CmCJ697upd4YnayKddksfNMNXTgsae9vvgURU66y0Pq8L44=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(16576012)(316002)(66476007)(31686004)(956004)(66946007)(8936002)(38100700002)(31696002)(5660300002)(508600001)(2616005)(26005)(6486002)(186003)(86362001)(53546011)(4326008)(6916009)(558084003)(66556008)(8676002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M1kvM3Z6S1N0YjJTWXB6anlMSHVCTGpOYy9TbHpnYlNmTmxEYjg0cHd1YW9Z?=
 =?utf-8?B?ejkxbTFmWHhFMFFxNnJnOGtkVDRIWHB4ejdCVnd0UEFTZ3Y2MkJJZ0lNZTNZ?=
 =?utf-8?B?TGhXSXM4Y0pFOGY2aDNNYUhTdGh0N2xMbytISmxWbGdtZFNsbnJzcnR6VE9u?=
 =?utf-8?B?eEEvZmI4WG5iODIxOFpvUk4xeDhQdmlFK1ZqNmF0clBQZHZFd29KV0pUOU13?=
 =?utf-8?B?SGlXRWdpNkZXY3BjYmJtSTk1VUdvWHBlQnBuZWp4aS92UlU4NmF0YzM4TXdB?=
 =?utf-8?B?bnJwOFZJTC9oYnpob2dJdTBCeGdtV3pzR05FbVBIdzMybWJnOWhqeFZDV0E4?=
 =?utf-8?B?NFlYZGJCMjBzWFdwMzJibVBkQWdKSGlwV2dHQXd1UUlWU0ZYUEp2Sm5wMlFk?=
 =?utf-8?B?VDRKdW15aXRJVzdoTmtGWEJvbTFiWDF0KytEakQwZzJXRHN4NWQwazI0dlY4?=
 =?utf-8?B?SGNIWng1bnpDcWEyMXdRMTQwc0cvdjRtYnVlVzNtNGhDbnU2NUF1eTlkdUhT?=
 =?utf-8?B?bGd5YU9DZ0gxT0docGZZVUNLWGhmRldxVXR2Zjk0UXVFMEhEUFVCMkV6S1l4?=
 =?utf-8?B?em1lUEoyWXN5aGZVbGY4UjlDa2RWQVJtcllLdHVZQmJqK2FCaEVEUmFNYVE0?=
 =?utf-8?B?ajVua0JhT1ZSNTUzTDQyM1I5OWxSVnc0SC9saXhVR2VudjZDM01IS2pUZ0Y0?=
 =?utf-8?B?OUQ5c1BnQTArUUxXdDhyUlFUVGdOTmF2NEdUM0pVWWNmTG5qeGJZSlNFakc0?=
 =?utf-8?B?cXFVVlhDUThBUEd3VFlZOFNoQUVSS1pkUWlYenEvQ3R6S1ljSkJ6Mjd5WTVs?=
 =?utf-8?B?Qmo3Y0FlWGxpb1NiVGtIbzF6UDRXc3Z0dDVrRjFEVld2VlZkaklmOFczdEVY?=
 =?utf-8?B?N3FlYzZ3T29sRncyazAwbDgxdjBOMUJ1MkRsWjJiNFBzaFVlWDI3TFErNExL?=
 =?utf-8?B?bk1qSkhHYjMxM3IzUjU3S21GS1JDR0l1WWVacHhrYmRFcVhubG5EL2MyYUpI?=
 =?utf-8?B?d2VPMVB0SlFCYWVHdE90MVBrV2lEem5QOXpkZFVPMFdRMGJzM3JTRlQ2VHBh?=
 =?utf-8?B?alpYbmVuL0ZqeFRhaGNOamlpWWIrWUpRaWJQOVhTU1VQWFlVUjl2a1lwYldy?=
 =?utf-8?B?RWlJWFd2Q2dMN2JwTXlBZG8weFp5MUpwU1ZHWDJUOXgvNFFTYUVvTWNIV1FJ?=
 =?utf-8?B?Um82andrOFNJb3kveWUzZHBaYkpQaW1kM1Y0UElXcFNVckIzQk1hdDNOZkxJ?=
 =?utf-8?B?bWtwSXBmQjlnL1EwSStSVUZHU0pNMVNKaFB5SkFzckpoL2luNHkzNXNLN3hK?=
 =?utf-8?B?eUc3Y1pabHE2QTluOFpUZ2ZmN1dSSDl6S2lWZWlHU2tLYmhYOUVKS0xscW1s?=
 =?utf-8?B?dU4weWo2VWxHaTdLY2RnRmplRzZSTmxINytUbnVwa0ZHVmVpVkFUYVhHZWFt?=
 =?utf-8?B?R3FuQW9iL29GUlUwbUJMZFpIakV5RVo2dmNDRGxUbDk5U25BaThrWWhTdGNN?=
 =?utf-8?B?VkJuZHNTM3k1d1d0MDBWZEhzZVY0RHc5QWRrSHZNRUkvSFJMWlg2YWZad1NT?=
 =?utf-8?B?SWZSdFZhQUNmWFVwT3VCT29SMUpnMTZrdWhUZWF0b3FhTzVLYjdTKzNZWkRS?=
 =?utf-8?B?SXZwOTM5WGpwNkJwaEx0YzQ0UE9Za25wNnVYZzhEZzJRN1Y1Q2pTT1A3ekRk?=
 =?utf-8?B?SHVkUTdWeWxUL2kxUlJneHd2VjQ3cmttbDVkNnlwVXh1R1hBRzdEMVpxMFZJ?=
 =?utf-8?B?aWxuZG1XcnJmRzdNZE9MeVZzNlZob240d2duWXVaR1JENjRZVXhPTzA4cHBx?=
 =?utf-8?B?OEVZYW9zLzZnUTd3dW1tZU95V1hFZS9tN1AwOU8xY2EwbmVxaHBBcHFwOUdv?=
 =?utf-8?B?UzZBSXRLTU13enZhMHUzMTlUandDZ1R0MmFPSUtCa094VlBhM2ExeDI3d2RY?=
 =?utf-8?B?RHpDWllHMnoxK29DSllaRTdzMjlreDNjQTN5SUhER3B0VDQ0UkVDTEpIWXdH?=
 =?utf-8?B?V0tpcjEvY1RIYjR3aG1BRXkyMDV3dnVYTWVMbDlkUExvVm13b3lYRlc5M0pV?=
 =?utf-8?B?bnNyQTF4ZFlsY0JSdStja1Q1WnQrR0V0NUhPNVlLQkFEN1hOaGU1andHY09j?=
 =?utf-8?B?RktQcHowYzVWcm1aK2NnMmdjTDlQNjF5cUE2aUk0VXd6YVduc0tMenJ2VzJO?=
 =?utf-8?Q?rtFRUeoxKLT1ARfoXvRjsIE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49434173-f9f5-42d1-11a1-08d9b49b42fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:21:58.8295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FB7xAHq4hDzTqN7h1sMUYPjaVITpyHgt68gp3lU7xbJvIVjit1XozIOCcX3Z8msyvfak9j53bVulZcPhKr7l8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 30.11.2021 19:12, Ayan Kumar Halder wrote:
> GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
> in bitops.h.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 07:33:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 07:33:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235614.408710 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msK6j-0002zl-CJ; Wed, 01 Dec 2021 07:32:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235614.408710; Wed, 01 Dec 2021 07:32:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msK6j-0002ze-8w; Wed, 01 Dec 2021 07:32:49 +0000
Received: by outflank-mailman (input) for mailman id 235614;
 Wed, 01 Dec 2021 07:32:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msK6i-0002zY-24
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 07:32:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e08db8d4-5278-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 08:32:47 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-zJYj0U7fOZu4Xaxg0jVo3w-1; Wed, 01 Dec 2021 08:32:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5597.eurprd04.prod.outlook.com (2603:10a6:803:dd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 07:32:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 07:32:42 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:20b:462::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 07:32:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e08db8d4-5278-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638343965;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wejFNDN6wuh0qusnpNLQnyepAmpAz94amjDDXwCWwbU=;
	b=L25AZWF+xSxlxQ10ZMl6kxlVuicJC7QsSw91v2LxSL2q9VUUFMkSOo8d27thG6X7mP7vns
	5TRBuOJsFzz+b3bsem0/6nIZd7/fj+x92CVYMaoqOi5+xK/qpS55hDF3Q1ioqrN70vJqco
	6vfv1IuVxjK4kR6U2blxYv+W+Vu8hIc=
X-MC-Unique: zJYj0U7fOZu4Xaxg0jVo3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SbHaYFRqQZJy+UxtdYUx/jWFald2SaQyZAwLNHHNTurd5JhAYsgsmvKLb/VVIEbE+kDUa7e0bsf8kgaxmaMk30Vmhz2SGXNjoVdlZ63nY+rtwlYjXDQBzA2E5aRivtV1VMq1tne0LjqiTfSDwAuWG/6ODkAw9bRGkJtIDKd5PArdaWmiHGVERzrKwvcXm5jDXzqaHLbOnzlXuw9Xxy6cMRpERrDYugPssARhHSvymBYfvYYdRX18HvtGIHwu6QTegWAhQ97QiAN/XR0gohSfsVaG2YNaRx2J8tAm/Y6oorGYtmrWre4QV1jp+Esp8M2SwvQdxGOcYzIqo+C4fzxsIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+fO/+E6zcJdufR+r2Lb6bLprlrGmHwIxNFjibVMxTh8=;
 b=GWCOIOpI7JsW84IuybZK0dc0gCd5qssin07GnQMG2Mm1/SrBQJeb8NJB0VRvUER1y36KsNBnugk1EZ1L2zIeiF3g/hRjaHHMgPE0PvvIfrgKn8DTiGRa8b7+Yc6B26Y4ZQ0rx23V5FPwpEL19mfROAF6LUWxuW13cjgdtwr+HUdHBLdbPLQIaebq5ahx2F0SVblwW1R6H3pVeB7zqDRI+GczfMCW1saEkQuh/MySRLPsI4PRtksCPh5r/htEvR+vgtqJxRM4mFH+dXk+R5LfURIce9sEKTI8PHLcEG5DQ2VY/VyoC9jjuN5OEDIOA008QKq+Z2Q9a95UyrkuJ3akDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b40d95d9-6bf5-e2cc-396c-12c3be6c48eb@suse.com>
Date: Wed, 1 Dec 2021 08:32:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] x86/vPMU: convert vendor hook invocations to altcall
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <aa19f4cf-6f62-3bf8-7057-7dae1cf28162@suse.com>
 <17bb5295-6207-0bf4-6432-426729a3a288@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <17bb5295-6207-0bf4-6432-426729a3a288@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0002.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4a1d17b6-eb22-4d56-cde3-08d9b49cc2e7
X-MS-TrafficTypeDiagnostic: VI1PR04MB5597:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55979F18833C94C6B099F530B3689@VI1PR04MB5597.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ke5YasYvJKzJqYt1OtfHbLiGeeDcVUyuFBsmfe4MG6VvHeN2mbQI/6vitrD+hsl2rc2Xu+8ajO4MsGQHoV0z2eIapujS9LhPsDA9nC8osoJ0pT1lKck0Sen27q7YFB+ytWn/7QcJsNFaoS8JLGXXnb0iuZWbCOStIi282bT6DEZEq1lvDCCSXpuOIT1jaaJzDoOlzOWrwZuXvWUVOVdhpkLcUDPKxRET2pYBYiFkWuXdNhsewCt9I9YhgVF5hGv0zv0LSnc0rrWrpFD41XyhYUqTIOais0SjmytLSHE0/3uiaxIxZ9z8OdBbJfj1LVnFh82ziTX9ATIPDyBTxg1HpoAMhbVQiUC+s39SGrj39zk24o2U92KHF624ILSF2pY/1lnKohXSzPFxG2PiuE5FQWkGNkoFozAM1GlybD5ktc02g5VTzGspaLaja0AtZxBSFa0ItlXsjqRrcF0EX2mP4enUvKGYu8gWX7C5/bmNCJnQDhOaHMLmWDh6XPQh5BEBFdSM7J0+zzqoOn+JvOm5Q7N+tOI0aGbNT2n1FVxZYgfYekqbO/SMfXtV2kYvlXXyPTKJc7IYJNMTEbJ0QWuXO9M1M6eJR3eSw5nRXpE9FlKnghciHZI/HtEBUTjQlokAm+XUU1iapnZlwCeET88sN820TJnUhLRkxL4PDZwRkyUaL9kJaFlffK5bgJORe6FNvf9qjpVCJC8Rd8VZHOUUFI2KeXpkh6b5BBTMzjdBr4Qmt5fXNxJtyOAXshRJha9W
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(66946007)(38100700002)(54906003)(316002)(5660300002)(6486002)(16576012)(2906002)(4326008)(83380400001)(8936002)(86362001)(36756003)(186003)(26005)(8676002)(508600001)(31696002)(53546011)(31686004)(956004)(2616005)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rCCa76lECDrQGK+kpo9n0jSrGWoRRfbrktbBTAGYRXFbeeVH51wasZcJXBX3?=
 =?us-ascii?Q?j83CnUlR9Ah9aTfVnRYL2rHti2K/D4D380p3oYtVn9TWFArYOsgC4D2AJnO7?=
 =?us-ascii?Q?zXhbcwmfPnSpJXUZqx/leWbopabwtM5fME8CJZbVI0wyFBBQtao4zw2z+TvS?=
 =?us-ascii?Q?11ZkWdzHTCzpk/oT9MGE0AmlB6lk7X6ai7L3wwHkW7AWv/fBNv7T6w0FC7V0?=
 =?us-ascii?Q?EOQC4LmqUyATUiV9qeSKgKA8314nektILIkkaC+mnHeeoFWq/+aCcU4fnVcm?=
 =?us-ascii?Q?U0yFTgYk0Pno8Any9aBoNoqX63iuzqAQFJYIaezh7so60XqWKiAmNs3QfBrA?=
 =?us-ascii?Q?FBLMZrstqYY62wasgBqCdcpmqNw7qTofMmyQYg8UL/n1VScY6QUDRgIg6JcY?=
 =?us-ascii?Q?63sc62ZGQI3VxYJ3TfDBhPCRgQ00QDfpyKy2/I8RNRhOHYJ2chLRlRkvwWRJ?=
 =?us-ascii?Q?rfJf8nrF20TKlyDSspNxcM4t4wlqjaweXA+c44IW0QauVixzO9SUQuBJWGLu?=
 =?us-ascii?Q?Aenlj7qFdzkWXaSvFx4oqpmTTGcPcEerI0gRNKihnTnOf94r5JKVUxnXQuXM?=
 =?us-ascii?Q?kox8GOMlHzoq6FGxdZQI2Uxb+QFC8FdQDmngKXut6Wub3jzZWGH6sTputMyC?=
 =?us-ascii?Q?dsWNhEb3S3qoXkok1TOwrWbbTKwTafzoKhS0ziyWhER9+PqQGdNgoanoabNA?=
 =?us-ascii?Q?VLN4jnc6N32LXRyd33FbTyCrZ+FPFQLsk1+K6toqqPNF9UGqC6O9WUkS3oPx?=
 =?us-ascii?Q?sYM/GzT439HJpz8bCTYFcnREIQ17fdXIT0y2I6aNJqFgB2d2vvHVDSqhIPKS?=
 =?us-ascii?Q?VHWzq8MQqSVktnYVbHhv4d8TtrzgeKOMWb0vHyRhNbTkaOG2OYClrz+5EZ4C?=
 =?us-ascii?Q?4sFY7T16zbzl1ial8Ae2bBmhm7F8w9y6gIZ15oe6hFCSoA+RZvHy0/+I3Gxh?=
 =?us-ascii?Q?4NOWUrjtyeMdhPkwHTKbVTLfEkyRCx3P/p1LzplmVg/Ndp59GLUubL2lKgMQ?=
 =?us-ascii?Q?e2OasFpT6PmgKSpD+ojPfeIRUhLd9dPB1ASPbgduG+VOs5WaQu02JzcV0SoV?=
 =?us-ascii?Q?PzxFKbfMkc5iplBRG6LhdUm68kXMxanU9zcLqJWML0L9f5P/J5/lUzLoeOoD?=
 =?us-ascii?Q?AMDyv6c2dqvOt/ETEXcCMMb3m8BIj35sMZdE3LF84MCiutM6d5UAWsA3oH5T?=
 =?us-ascii?Q?5AutQISWgiIgwXWit5jByoTExBx81BnlDmNF2ISJK8nCypZUjcv86L4bScD2?=
 =?us-ascii?Q?XD76MWbRtJZmYulrmEMqYsOlFb060tHQoU7XppGdc3AvNeVKhd8aiFDujFa8?=
 =?us-ascii?Q?tnp1CImVrfElrTNQb4eJNS9/LTUxOBBKU2R02bp2t8NsW48ABmv7UsQ4o5bC?=
 =?us-ascii?Q?p0T95vXXLxl5dZ7p2PUx7lCPFNMXogGv6zC8oFBfMuYwTFAJys1HZVxR+yo/?=
 =?us-ascii?Q?B1d2J1EXvBadQhONdvLIk2KY5bNFTwJ9HOricU5kcfxAe890WFMx6IespHOr?=
 =?us-ascii?Q?MLi9SEn05rTWHfkqSGCwE12hHAljLNOpDIYiayiNdEOQ5eQuTtEI0EF0uo35?=
 =?us-ascii?Q?5O5Hyj1LjQu1ypZx5afLLvf+eiOupsMA7COdnQWNJQTINZ7oGTWKwknvTCB0?=
 =?us-ascii?Q?WTgs+tmgulQvjq9WG/Lk43A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a1d17b6-eb22-4d56-cde3-08d9b49cc2e7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:32:42.8854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hBUtfzQOI0r7xPdV4+Fu2pUtDUH921qJ57B+we+dGyRCdOYLjy6ceU2GnrdTD7txvsR0DImkmSZ05ifnuoat4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5597

On 30.11.2021 21:56, Andrew Cooper wrote:
> On 29/11/2021 09:10, Jan Beulich wrote:
>> @@ -133,14 +133,13 @@ int vpmu_do_msr(unsigned int msr, uint64
>>           goto nop;
>> =20
>>      vpmu =3D vcpu_vpmu(curr);
>> -    ops =3D vpmu->arch_vpmu_ops;
>> -    if ( !ops )
>> +    if ( !vpmu_is_set(vpmu, VPMU_INITIALIZED) )
>>          goto nop;
>> =20
>> -    if ( is_write && ops->do_wrmsr )
>> -        ret =3D ops->do_wrmsr(msr, *msr_content, supported);
>> -    else if ( !is_write && ops->do_rdmsr )
>> -        ret =3D ops->do_rdmsr(msr, msr_content);
>> +    if ( is_write && vpmu_ops.do_wrmsr )
>> +        ret =3D alternative_call(vpmu_ops.do_wrmsr, msr, *msr_content, =
supported);
>> +    else if ( !is_write && vpmu_ops.do_rdmsr )
>> +        ret =3D alternative_call(vpmu_ops.do_rdmsr, msr, msr_content);
>=20
> Elsewhere, you've dropped the function pointer NULL checks.=C2=A0 Why not=
 here?

No, I'm not dropping any function pointer checks here; all I drop is
checks of the ops pointer being NULL. These checks all get dropped in
patch 3.

>> --- a/xen/include/asm-x86/vpmu.h
>> +++ b/xen/include/asm-x86/vpmu.h
>> @@ -61,25 +61,25 @@ struct vpmu_struct {
>>      u32 hw_lapic_lvtpc;
>>      void *context;      /* May be shared with PV guest */
>>      void *priv_context; /* hypervisor-only */
>> -    const struct arch_vpmu_ops *arch_vpmu_ops;
>>      struct xen_pmu_data *xenpmu_data;
>>      spinlock_t vpmu_lock;
>>  };
>> =20
>>  /* VPMU states */
>> -#define VPMU_CONTEXT_ALLOCATED              0x1
>> -#define VPMU_CONTEXT_LOADED                 0x2
>> -#define VPMU_RUNNING                        0x4
>> -#define VPMU_CONTEXT_SAVE                   0x8   /* Force context save=
 */
>> -#define VPMU_FROZEN                         0x10  /* Stop counters whil=
e VCPU is not running */
>> -#define VPMU_PASSIVE_DOMAIN_ALLOCATED       0x20
>> +#define VPMU_INITIALIZED                    0x1
>> +#define VPMU_CONTEXT_ALLOCATED              0x2
>> +#define VPMU_CONTEXT_LOADED                 0x4
>> +#define VPMU_RUNNING                        0x8
>> +#define VPMU_CONTEXT_SAVE                   0x10  /* Force context save=
 */
>> +#define VPMU_FROZEN                         0x20  /* Stop counters whil=
e VCPU is not running */
>> +#define VPMU_PASSIVE_DOMAIN_ALLOCATED       0x40
>>  /* PV(H) guests: VPMU registers are accessed by guest from shared page =
*/
>> -#define VPMU_CACHED                         0x40
>> -#define VPMU_AVAILABLE                      0x80
>> +#define VPMU_CACHED                         0x80
>> +#define VPMU_AVAILABLE                      0x100
>> =20
>>  /* Intel-specific VPMU features */
>> -#define VPMU_CPU_HAS_DS                     0x100 /* Has Debug Store */
>> -#define VPMU_CPU_HAS_BTS                    0x200 /* Has Branch Trace S=
tore */
>> +#define VPMU_CPU_HAS_DS                     0x1000 /* Has Debug Store *=
/
>> +#define VPMU_CPU_HAS_BTS                    0x2000 /* Has Branch Trace =
Store */
>=20
> Seeing as you're shuffling each of these, how about adding some leading
> 0's for alignment?

Fine with me; I did consider it at the time of writing the patch,
but decided that such a change of non-mandatory style may not be
justified here (or even in general), as there are also downsides
to such padding: Once adding a constant with more significant
digits, all pre-existing ones need touching to insert yet another
zero.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 07:49:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 07:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235622.408721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKMz-0004pv-Si; Wed, 01 Dec 2021 07:49:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235622.408721; Wed, 01 Dec 2021 07:49:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKMz-0004pm-PZ; Wed, 01 Dec 2021 07:49:37 +0000
Received: by outflank-mailman (input) for mailman id 235622;
 Wed, 01 Dec 2021 07:49:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKMx-0004pg-Nl
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 07:49:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3954ee2c-527b-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 08:49:34 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-DuzYAJR0N7yvO_rUleGaFg-1; Wed, 01 Dec 2021 08:49:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 07:49:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 07:49:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0016.eurprd07.prod.outlook.com (2603:10a6:20b:451::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.8 via Frontend
 Transport; Wed, 1 Dec 2021 07:49:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3954ee2c-527b-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638344973;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BGV630vfh15j/xw/z97nBvOgJpDlhqb4jOpQ3HGHa6M=;
	b=SFOF36sqS1A/+tXkJWLfKMQzHBZnE7IFFfjQFOYefx9ik9SqKv2SAf8TSIdN7sNO6JO5FG
	7jCLvPm/u0vZ8412uEtQ5oLrK8WlNSKQWXu3iFHSmURHPUwOtGUY6ijQ6kiQ/gLggExY7U
	9glQasTGV7+hpRJ5/4n2wxQHwTV/FEw=
X-MC-Unique: DuzYAJR0N7yvO_rUleGaFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VN5Ed2M+u5AZEE/kBhCaSzNGYGSwn0NkrsDqlk6vJnTvzJzPgpf2g4s7Cds+NIMgy17lHOhcP+LWi2XoyazVffidiJf528zUYpyjwk8GDflLcTxyaKaZ/LxYl7FREEsVGHsnyC9iTPFyVjpX8DjOSIxFtDqDMk45vu4CAkIVyaTOyt40PTtu+BX4M+F2StY97/ZFu1199uj0914XJX96iwWBX8Q3Yxx+Ihlybpe6Slbyt2E6BQ93p5p+2U3Ay+8QJbyMaA1xjwMesijeMngasVHtwcl8lOJUxEMqmI4mwSy0JJpLX0TIb4Kx7oAVq+bO2C6+r/alIKGEBtnxVzccTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BGV630vfh15j/xw/z97nBvOgJpDlhqb4jOpQ3HGHa6M=;
 b=nRCM6u/7nFmGisU4KNM9aeh50WyadGqZS1+x/LggtjRNLD/z6pYrpkjW4XkZwktB4fLlzeZNvT8wXLLy7stbIqLi+l2yzYw+Zc4FNJoZsG8JmaQRQMFuVfbf2y12kJTbYg0hUFL9ulF62ZOZj/yWPMu78HYsm25GMVtnRyv/cWntxUW1Pq9+4a6n2iKhScqdJ+QEPIpNp/9/msoii9DzDSzwCLkJou3NR9hR+iI30ja+0CaxFph20hr4BgpNRvJJ8a6XpBgb/afbwP0XKX9b03cbUrFB+An2uTvgHP8pPz9od7bhQy5GHJWDimjdIskcuxJcVc8P/QJwj9lCask+Lg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d55a2ecf-5c11-1e6a-cfce-5a51a6ba4988@suse.com>
Date: Wed, 1 Dec 2021 08:49:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 4/3] x86/vPMU: Drop supported parameter from the wrmsr
 path
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <20211130220111.23815-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130220111.23815-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0016.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa9bee8f-4a33-4ee4-5df6-08d9b49f1bac
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB48485676E8400682E371A134B3689@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jq7W/URy0euqEEdHzzAdc15QIxr+S1W7/eFG+RVV7K5KODxRqAdvxJBCA/LuGWOxtqbhJr0OmbQlp9vsKPGqK29S7+W1870jnDrKKZLmpIV0UHktYbE1XP5GNYN0vvIi45A+9vCNzTlMm5YSIzNfzZkQYRVn4t3Di5wqN/+zZ2j0j6Z9iwBp25zoxs3byIp91IAVReJaFEfzJ7XFhRpRXBm9zZDWLNx0J0b/iQhrGFv1vRVTOQ5xxW4OGsQ8rNUG1k4Wuyydq6Go6gNSNIYYJhDJ1++WB3P0Hn2JRwbr9MEp0mLCxQy7TUIVpvHKqCVFvoP2nGEIZSFZAv+LU1dkkuwpCyPKwzkBR/qEY2E8WHOQkMWcLD/jxGnXoGfwpKZKPNpIpJcjandvnYGFAaX5s1B4jXqWgj30pD8jO+dl1FXWLfhfOU/QCz+UjklnGf9iE/Iq7RTc7tFEZ+tidC9xlJDUZC7/b8WfbNanjoQ0MX1lVKzwuvIub9XTn1HwvK28r6EX1Fs6zdZUjCJOjj0fFIDXHWW0lQvMInHAuLpc2slsQp+JoWK0nzpOVGo2OCfB3p3JG9iEXaK7AJSYDQPyzZ2KsO+S/NhDUI8G6CfMCQVKrRPJSUwQJ6NJ6DN7qNb8yaocmH7n5fB06QuIziuXCEvbmG+ErUbzsw8SC+sQ1KSQ4S1DEOzDnp2BBs6Q5swbkSVvOJaseNbD8i+D3mDHfOBN89vpTdjGEcNVsttk35E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(38100700002)(53546011)(66946007)(2906002)(66556008)(36756003)(66476007)(86362001)(8936002)(5660300002)(26005)(31696002)(31686004)(508600001)(4326008)(16576012)(6486002)(54906003)(316002)(956004)(2616005)(8676002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHhjZGZ2cklOWitVZ1N0Y3U0NDdPK3ZDQ0lBaFdDMFNUUm5tUDQrSDdIR2hO?=
 =?utf-8?B?MWdYMDVka2JSUjFSWENNbHVlNE9lK1VNM1dZWFVMajkwd3Z4OTVKb29pZjdp?=
 =?utf-8?B?aytSVXFLRTRQR0lyUE5VcmZUK21weGFpRTV4SDRQYytKMzJVWDVwSzZUTU9u?=
 =?utf-8?B?bXpmZ3hCZG1qSVY5dEhwSE9ucE14NVlmUjV2UWJFYjVTZ1RMdkF5R0ZybjVk?=
 =?utf-8?B?ejVXOGhnYXlRRDUyb3ZNN3IxZFZSSU1DamRMZVkxOXhYYVUzWGZpQWQyb1Jl?=
 =?utf-8?B?dDZLU1Vvdnd1MTQveEpkc2Zoc3pWS0J5Q3JvUldPUjNvVjNEb3pyR2hsaTBq?=
 =?utf-8?B?cldBVDh3OXVTOWJHT1ZOY1pxTm5sbzZESkpDUjQzbFlySTBGTHRsMjdaRGZt?=
 =?utf-8?B?OVEvU09VR0ZFNWo2KytpWktpb2QrcW8wQjkvZXNYTnkySUw0b054a1c2anVM?=
 =?utf-8?B?UkcvNmRnVE5WKzU1Q0lpbFpSWmE2aVJxQk1zdThTZEVWRk42YjRLZEpPMXFl?=
 =?utf-8?B?M1BLWkk1SU13L05ocDBleDVmSTJFU0t3Y2daUzZIQzhyQVNuakJBM2ZlTlI2?=
 =?utf-8?B?ZkhJSi90WkVKUm9jdFhndnFtWUF6VVJKWng1cFRoTVQwcm9tRmY2YVYzWmFU?=
 =?utf-8?B?TmMvbTdBMDVQbm9EaXJoRDFBcmcySzdKQ3JNdW9QL1F1QVhWdXBLbG8rWkVN?=
 =?utf-8?B?L2FCd3ZaYzFWekRMNnFqYllxOW5pbzJ0TXlpV2E2ZGVwQkxGNWhTdEpiMDNO?=
 =?utf-8?B?YWliMldqbndCMk5uZU4raWN3YW1jT0ltamhJK2h4QUFJY2x0aisxSjJQbUtW?=
 =?utf-8?B?TGVBOFd5WVR5OXh5NDIvS3JyeWJnWjlOZU85ZHNkYld3THNnRFFsa08yMDNI?=
 =?utf-8?B?VzlQSlFVRWtLMDZvd1hodFN2QU9vQlM0ZkpzaXlSbHQxZlZSbUMxR3B4cEV5?=
 =?utf-8?B?MWNJNWUzeHFpWC9QM1lTdU5XRndGdXorQ21TZTcxZ3BUY3IvM2s4N1pHMSt5?=
 =?utf-8?B?aW9URTV5SWoyNTNIV3VEY3Z6K2FueXBJQWpqaWEvNk1OZyt5Z0MyYi9WM1JK?=
 =?utf-8?B?VENPN2ozNG1iSVhhQmU4NXV2RDc0R1EzMGw4NWxiYTlNUk1FenR6elFEUWth?=
 =?utf-8?B?Q2FwUUVEWkNiOWViYkwxRFdWd0I0TUJTOHB2clJ4cGd6THdNS2MvcVNvelFt?=
 =?utf-8?B?ckNUWWRLemVrTm5pNEdLaWxrYUZ2NGZtK2w1QTZVSk0vUFgwbUhlc2x4YVNE?=
 =?utf-8?B?YXFSZytqLzRaeERHSG1LRnI4YkIyU1pSQTJuTlYxVFZHQmt3MTRQRmFDR3Fz?=
 =?utf-8?B?eisxdkl2UG1sZmNaTTZ4ZG1tR0ZPQnZnQ0pQNUkwQkZ3QlRhYWY2SldZSnFh?=
 =?utf-8?B?djZlQjczN1U1SjV2VTBOckRwdWJtdDRzV3FBRG1zdG9wRmkvT1NLZ2VDMWpl?=
 =?utf-8?B?a0lxOVpMNVY5S0x2Wml5OFM3c0xCdkRpSnMrZTN4V09ySjFTTVd3bXZBQ05I?=
 =?utf-8?B?ZGpJeHVFb0ZvN3dNUVluUFlQUS94ZmdKOUd1WHRHK3hDWkFFMSt1Rnh2Nkhr?=
 =?utf-8?B?WmxCdEVxbzdTRDJ4Qi9sYjZnTGU5UmNva0kwTjF6UXpUZnZSblpnMllVdG5x?=
 =?utf-8?B?cHkrS29Ga1JQd2FNOGxRWWp1SVhZREVnSlNGMnVEUWxnMFM5WnNwMUtKeEg5?=
 =?utf-8?B?TzFjNTBreVlibjFjS3FET0dYREVQSUFWeHlxdUkvMFZ2OC82K2tlKzRlYXhO?=
 =?utf-8?B?TnJJNlQrWXRDK2JYcjlPZVRZbFRSNGU1QzBHOFpEaUhXVXlKMktLMW9Hc211?=
 =?utf-8?B?Nnlza0VXZ3QwYXdwcElLdlYvWlBmVlVLYmszRVQvbCs5OVdOS2ZnMDdnRVR2?=
 =?utf-8?B?dERYWFBKVDRqTktPSjI3QmVyZ2tqYnNOdHNhdFQ5MjV4SlJxSkIrbk80ckM0?=
 =?utf-8?B?eFphZ3dNUkxCRlZvTWhLWTlTV0FYYWV4Q1NCVEdMSnFHS2taOEUxcTBDUXhm?=
 =?utf-8?B?MU5GOWlLZjlTMExkVzhydHlYRFNJaEdKcWxDZlF3MURkNllpMzNVcVFmYVdH?=
 =?utf-8?B?NXlXcGNPNGVGMGladkdjN2tYTkE3OU1DbW5iVHBDcE95R294c2lFU3daNm5L?=
 =?utf-8?B?blMxWkYwZGJhMG42MU1uUmJFeWJtd1ZpUDAxenZoVjFMM0xBK0JDQzhFeVJN?=
 =?utf-8?Q?E0tNQgpqGITt6aoKzuPyPN0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa9bee8f-4a33-4ee4-5df6-08d9b49f1bac
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 07:49:30.8145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TORWFPxzkV/fts1j1o90qEAuFjfxSYg1aoV1RUcqcwjlTeIw9G+DRKa8mZczNakw2+lbEFD0u3SiJw+YGydVEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 30.11.2021 23:01, Andrew Cooper wrote:
> The supported parameter was added in 2d9b91f1aeaa ("VMX/vPMU: fix DebugCtl MSR
> handling"), it laid the groundwork for XSA-269, and in the meantime
> 2a8a8e99feb9 ("x86/vtx: Fix the checking for unknown/invalid MSR_DEBUGCTL
> bits") totally rewrote MSR_DEBUGCTL handling.
> 
> Strip out the parameter again.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
albeit please with ...

> @@ -113,14 +111,13 @@ void vpmu_save(struct vcpu *v);
>  int vpmu_load(struct vcpu *v, bool_t from_guest);
>  void vpmu_dump(struct vcpu *v);
>  
> -static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content,
> -                                uint64_t supported)
> +static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
>  {
> -    return vpmu_do_msr(msr, &msr_content, supported, 1);
> +    return vpmu_do_msr(msr, &msr_content, 1);

... "true" and ...

>  }
>  static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
>  {
> -    return vpmu_do_msr(msr, msr_content, 0, 0);
> +    return vpmu_do_msr(msr, msr_content, 0);

... "false" used respectively, as you're touching this anyway.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:06:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:06:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235632.408733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKd8-0007kq-K1; Wed, 01 Dec 2021 08:06:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235632.408733; Wed, 01 Dec 2021 08:06:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKd8-0007kj-Gb; Wed, 01 Dec 2021 08:06:18 +0000
Received: by outflank-mailman (input) for mailman id 235632;
 Wed, 01 Dec 2021 08:06:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKd7-0007kd-RS
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:06:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f072afd-527d-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 09:06:16 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-Q-TlA08mMyyZ42LO6U3wqA-1; Wed, 01 Dec 2021 09:06:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3935.eurprd04.prod.outlook.com (2603:10a6:803:1f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 08:06:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:06:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0196.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 08:06:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f072afd-527d-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638345976;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vVie5wls5q4W79m2RL9G501fduxg5o1eY5f0Lef2o1U=;
	b=H6N3QRqoLN9Vqb1+5tKBd/7xmszLmF2V+U6/Y6WDKqWJ7CFmAIJSX5YSoqgNBKg2KWH9JB
	/ZHfYQkJ5dceXYP30TBVyQrnBvI7MNk6FVCwCvrhJRHZ9OEFwEX76b4OKMzI+EiedelMJ0
	Gdb0TKkdgUK7rpwIAxLc9tD/eGhcQz8=
X-MC-Unique: Q-TlA08mMyyZ42LO6U3wqA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jcCacMS5EUKiWPSmw6o+fF+2WrSwNR5angMydp0ju18K0PrGNCCpmD1RL9nHEhx0iqznPCNlNooXFa7J95ll9HW2WY+ex2mNdJvYUhKDmRf5FEBSBRY5p4ufEHqIkoky/p1aPUAHFPtA5JVOO0932kyNiUZSzFKfWJ1trnbmBUs/IGJJBbd7BjeZFD6pvlhd4OsVTHSZtXz2bogOXJD+xFM+EfgcwbCK82IK5e2Vt9ZTwaqen+GU7K+aqlAavbolk7//DV+z9+JzHYI5aIdAlIaUrAmIFhVkEgZnEv8ESRHnDaQwgN34blmh5J7HEg1CqaUC1ZmBCHd4gl6EjFGLHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vVie5wls5q4W79m2RL9G501fduxg5o1eY5f0Lef2o1U=;
 b=QxMnsp62woBimHu06UjQ1e7SZLNvV3gzhTi5qAcV98NTx9gNLEPfFJ0op8CTpnFSi71ZnzyUseKOsYxm/9a9roLLy6OTE6nWszymVdsAjdfFG+EYtQVSmaBvFaLZCbOfXvh8Vp4k4k63jawAVTcvwFkB+NOjmtBkEugpdh2sUdSUVFk+ahNjQFx3Be6sm30NjJ1vzywpZa5bjrQE8IYxMN/DTqHLrrzB38oa8FOSq3vBHFlZxxsHwQ7RTc+U2l85GqAUokj3l+UOG19zYpWcLQeNqHWb/xY4zxi5z9/uonygBQUnqXVbvh+pIaejkzyO8oXntt+dBXdFOOVgtCAGtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <336d5f9d-04ea-294e-489e-208316456c58@suse.com>
Date: Wed, 1 Dec 2021 09:06:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 5/3] x86/vPMU: Harden indirect branches
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <20211130220502.27624-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130220502.27624-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0196.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2da86bad-1f2e-4da0-a6e0-08d9b4a1715c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3935:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39351E91905E515F817D13E8B3689@VI1PR0402MB3935.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nZGHdHxJ8k6kP1JopHeO8edcLkSwakd6eRnyYtnNr6ovQAzneMhDppO9ae8pT85PxzX3iMK93RLdoILlZUKEO0byF2+RDCRb1A3h55dJEQVGVFJuQ7JVvdDnUjYFgl2aTgQcoynC0v9V1qCZd37A4XEq7oHfQsQLYIHqpq3A2/TW8J58wrQaoZqu/zzZsVqRflokPQuZZATrA9rEouZLL4lkMHnIL+tmt/9TAWGT3MFVNmxZOm1SHks5CGMpZnpc7NPxFLKK7qi6imYYhn592UWWMjcFU8XRlKIXYUTpcRHCHP6vIUQGRCPYyN74eW9h2xmo9bTqw0amOPp1oCIN4PrXCJym8U2WKHtm7DrdhJ9X/pKk5uMOOtwTV8MiHa0wWQouEMd0VcH7ed/ibQ5TNsISg+h1cAFHc15vFFMHim1oOR1RFtiWuc75PcwYhkgZkZOUDAV3PA3A15kd5b+IAXCkdeBHEze59FLaRXJqKJrvfBc+yQjEu17YwlkjQD22JdYcmY5vbQIyg58H3oEpO+c+cwP6pdcom/jA1+T3XytQ7s3LaQNN/P/ZZXsAkUgzdu2bsDb7VbSH60e3GPrR3FXiMBPOZiXbEJZkZkc6g7OSoAi3agJ4sgvlrurPFAEwgUMBXnq5op0m2QQ8jCvXkXR4tF7u+r+hUug0dFxmnB26t3VDtmxTLKRKxLkwElG1qiOypurBLJpVMMbwKGKcmmMdk98wxqRiQirIeyGZCak=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(8936002)(316002)(16576012)(86362001)(5660300002)(66476007)(4326008)(54906003)(53546011)(31696002)(31686004)(38100700002)(186003)(2906002)(6486002)(83380400001)(508600001)(66556008)(6916009)(2616005)(36756003)(956004)(66946007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RnU5WVp4dC9rRzQ2dmI3ZDJaRitldnlIVy9aYTZoeTZJSFhIMVVOK0RMbTZV?=
 =?utf-8?B?TWNPTHF3bzcwZFprR2ZZdU9vL0s2cWZmTHZpSmsvcVI2MXZISjQrNDMwR1Ja?=
 =?utf-8?B?dzFWdnN2MzZKODVnSWFJTGhvZlZqbHh6aTdoT0xYM3l6RHlEbDdTUXROcThF?=
 =?utf-8?B?ZnBvNnA4N1d3MW1yeUlPYi9rUHUyaStUVS93ZEZJMlJWUVlFbHlqREZOSFcw?=
 =?utf-8?B?dk41ZGhST3dMTDczQ1ZwNXMvMEQzblBMRWdOUEZKUEdEV1grQlhFMkFIY2hQ?=
 =?utf-8?B?VFRyMVI0cXVLUTFVeHdONUh5ZFd5cHpRZ2kwNXlRR2g4TkYvQXBkZmpRNXhy?=
 =?utf-8?B?ek05QklXaXhmSGRiZW9hYzI0ZUJVRU1rZXo2QjRDZ0J6V3dsMHdBUko2SWxD?=
 =?utf-8?B?OHdxM0JaYXFWMU1vZmYreTk0cTZnSnF6QS9sMi9IaXhnQ3ZwMUkwMDN5MzNR?=
 =?utf-8?B?UVh5V1dMWFU2STcvMXpzOWxQblFCSEk5WkFGVi9ZY2wreFZYZ1hEY3NHbjBY?=
 =?utf-8?B?ZGhOVUUzV2c2bGRBOEdyMm1ONnA5MjZldkFRTStsd29XbXNDWEJGMTd0MC8v?=
 =?utf-8?B?ZlJ2TTVWbXozakZCRGRKc1JrVjFkWjM1YWx3c3pkdk9mSlVla3BZWWVpcWxI?=
 =?utf-8?B?YTFiVlpiNVFuVnEwczJyWUdIV0dxMm5ZTW1OSVpNMTdsVGtaZmczTmVyckVm?=
 =?utf-8?B?T01ibGpuM3N0bkhENW9rR1lMandxcGZlWm9Yb3NrNzZJcXJreG9wRzFGb2ZQ?=
 =?utf-8?B?LzluaS81L3NIdWVaeC9ydlg0RWk5eCtXTDVZOW1tazhlc1NreFFxcjl3Y21r?=
 =?utf-8?B?Ti9lQ01Nb3BRNnd0VnpNdVFYQXRQSGo4dUNvQjZpS3ppK0dOZ0oybzNQN3h3?=
 =?utf-8?B?S1VhSnlZbHpRYWJWVnk3amgwUFlGSUxHMS9sTmNnSDFsSE5KcXBvcUdrVTgw?=
 =?utf-8?B?SFpCTHp4aTdRSENVa0Y3MldwZ0ZrbFgvM2JVOXdlTDUvWnpSRjlmNW9zMUk1?=
 =?utf-8?B?cDlORkxaR0wyNlRWbmJmRW1aTERENVhNVjRES2hObGJidWJ6dGlXbWxEeGdM?=
 =?utf-8?B?d21DbnBGazVVVmwrLzFtY0xMRDVGdk11Rlo2N0VzaHJLc1U1MmQwbVdSNGlZ?=
 =?utf-8?B?OHJCaHN4WWlNWEY2NnJvcno3YU8rdVVLT2cydjJMWDJwcGFVZ3d6SDNNNnhD?=
 =?utf-8?B?NDk2YWJEdjJUMUROdnZzZmtSbHRwYVhsc1NVbkE0Q2xqM3RoQTBjT1dtZkhZ?=
 =?utf-8?B?NUFUVSt5bHdKYml1SS9yKzBaNGlMSWE4S1Y3MGNQR0VDVWVJc0RzdEJxZjJ5?=
 =?utf-8?B?T2E5MUV1dEt0VlFoSERiZXRRTm9pb2dRNWdkQjhDcENlN0tnMUpxSGMxSE5T?=
 =?utf-8?B?TXZpOHc4em9vOTRmUTluY0VlSkR2RUxOVGZEckxpWWt4d24yTEtnUHNGNk42?=
 =?utf-8?B?ZGYzTjZzeVA3aUFHSnFhajJma21OcGwxTkF1M3BQYzVKbU1hVzgzU05zcUVo?=
 =?utf-8?B?NU9nYk5mclJqeDRRczhoaUVEUUtDTTlqOGRuSldYZzY4R0ZqS0I4aHI4a0tX?=
 =?utf-8?B?eFJrNElOOXltZEw2SjdYdnBJYVBjbVR2bmtOVGRvdzFBNFM2dWxCdTNaWkZU?=
 =?utf-8?B?UGRoemorZmpiempETTRZUFpOOHdseStYWFJObGYrNks1TXpoZUVPYk1YQ3Vk?=
 =?utf-8?B?OVFrYUlaR3Y3elFtWHdLZS9tWVE5T3NXWDBXenZXdGF4aUZVK0JJSncwQWJy?=
 =?utf-8?B?ajZYSVdzTCtGWUthN1FRVXMrc2JKUlk4KytNcnpFcFlhN3dhaDBhYXZ2d0tO?=
 =?utf-8?B?cVhycGdHbEVpWGRwWnl3dyt5VitYanB6dTZZV3dBY3ppWmMzTVV3V0x5L29j?=
 =?utf-8?B?c3lMZ0JNSHVzMU5UU2d1VmxWYjVTMGxZZzJBV0p2cnJ4ci9oVDJzcDYwdTlM?=
 =?utf-8?B?WHZrUUp0WXNaU3ppRnRlZ1VjclhLUGIxTzBMVWRSRisvc0lzWXFsZjFuTk15?=
 =?utf-8?B?Nk80RlVxN05zZWx1SVBJM2wvbUdMUTl5SWxzWHBnSU5rSFoyVGwxT21ReE1J?=
 =?utf-8?B?UTJRbVRQQkhUYUdFb29BSXN6RXh6cjk2VEZyQUdJNUxOMlpyNU9yK0tUSHNQ?=
 =?utf-8?B?aE5xTGRjVWR6Z01DOHdSKzVTaWFvZXgxQTFMU1lkN2VoQ1lGV0h6ak5KUVJV?=
 =?utf-8?Q?0/Y32O+jNiuZDcgdZpcy82o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2da86bad-1f2e-4da0-a6e0-08d9b4a1715c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:06:13.5516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tLJIUM0K5QCgxztOmJanHKO2asJdS0DXH07HK1pXsmvIl89vtKrXansv6aGPHAq3Ibl3XB1Om3f0laYGQRdeTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3935

On 30.11.2021 23:05, Andrew Cooper wrote:
> --- a/xen/arch/x86/cpu/vpmu_amd.c
> +++ b/xen/arch/x86/cpu/vpmu_amd.c
> @@ -518,7 +518,7 @@ static int svm_vpmu_initialise(struct vcpu *v)
>      return 0;
>  }
>  
> -static const struct arch_vpmu_ops __initconstrel amd_vpmu_ops = {
> +static struct arch_vpmu_ops __initdata_cf_clobber amd_vpmu_ops = {

This depends on an uncommitted patch (introducing the annotation)
and hence is a little difficult to review without a pointer to that
patch (which doesn't look to have "cf_" in its subject, and I didn't
recall anything else to search for in my mailbox). The main question
I see here is whether it's warranted to drop the const: I'd like to
retain it if at all possible, just to document that the structure
doesn't get modified at runtime (read: initialization time).

Later... I've spotted it in my to-be-reviewed folder; it's
"x86/altcall: Optimise away endbr64 instruction where possible".
There's no discussion there either about const. Iirc the reason we
need __initconstrel alongside __initconst is for older tool chains
complaining about section conflicts. If that's right, for CET-IBT
we need relatively new tool chains anyway. Hence the mixing of
const and non-const within a section may not be an issue. IOW with
newer tool chains all could go in a single section; we'd need two
separate annotations only for older tool chains (falling back to
__initdata or __initconstrel). Of course at that point it might be
easier to have both .init.data.cf_clobber and
.init.rodata.cf_clobber in the first place, grouped together by
the linker script.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:10:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:10:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235638.408743 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKhH-0000oO-4c; Wed, 01 Dec 2021 08:10:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235638.408743; Wed, 01 Dec 2021 08:10:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKhH-0000oH-1h; Wed, 01 Dec 2021 08:10:35 +0000
Received: by outflank-mailman (input) for mailman id 235638;
 Wed, 01 Dec 2021 08:10:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKhG-0000oB-1Z
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:10:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 279e5ba9-527e-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 09:10:32 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-M4IfLnmOMtu9f1FbiNipow-1; Wed, 01 Dec 2021 09:10:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 08:10:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:10:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0063.eurprd02.prod.outlook.com (2603:10a6:20b:3a::40) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 08:10:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 279e5ba9-527e-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638346232;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eH/WZPnoCVjz/Y0ISwhQODDksANkbevXxED+MVLmilc=;
	b=mXyzHgHhDE54LppmS7e3w7FW+LtNmYtsijGjdis2mo0xMEdBbe+wU3Ovng0JRHhIaaDOf9
	eo4K97s8p07CgdvJaufLhEwkqHxNHl9BgjPSR8qjy8N9ImG9KCQo1DrVAariqrSK6NWJHq
	2iTX6pxLtz9k9+y/ZKsqaOPn6YPxhYA=
X-MC-Unique: M4IfLnmOMtu9f1FbiNipow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q1OQatTMRxjrJId4RtKwT7QQYXv0p91ypJauCbdYUlu+h2aiX7xpIu8rUPXRoLv4mKVIfYsTdyHn0Ryvs4l2sFQ+kXn2qci8olCUcX9tFvdML+NPyPuB/05a/tkuBTDap0P4HcY3nwjE0Vak2bBLy0veMjzLQ/sC296jhxJ0LKwKBX+oeniwJIwvcPBFcadJ9OJf7riHPlyQVSKftTq8RWOFF15LdasxXvDmcFpILo6adKaR+bu9BdmSCrN6ub4pacY2/RIzq3H+KPCgTEs8wTy5XOyARMIF9eGIybgoTlijTrX4fLzVGKnaxU4/xaIfYVObVrSpsFGb2bmTpBHG4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eH/WZPnoCVjz/Y0ISwhQODDksANkbevXxED+MVLmilc=;
 b=oOO93rmjFlszZTkfQMNnFfjANvcPMVbBvCIpBpjYo0YK6QJkVkfiLUEFbruKlrLKSXkXTs+tHlGEScFNoCpwLolLn4BVEnrzF8IlpZzpSp+d7O72w3wNCRblstMmanwyRHZtuHFB3LrY2AXhkItISmnXEJZ+osVm8hDy5BH/1RKbVVsu2jrP4OMeABJg+aA1DGFTsWboFpNP4Hqp95uFNDH15OrFFNjyINJRooDwYX5pdmw6wLk2WKWW1KlITFC6h/T/3BBasUIjOQJ94ZgXCXsWjzSEKQFyjun9/tHvUCi2QhwEabtiiv3O5kkCcpm71nXlY4NqAMdh7jiymPeTDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e3bee553-9443-2f3c-095b-4d6151a07c5d@suse.com>
Date: Wed, 1 Dec 2021 09:10:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/4] x86/altcall: Check and optimise altcall targets
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126212258.7550-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0063.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd3c17e2-cc7a-4269-2115-08d9b4a209a3
X-MS-TrafficTypeDiagnostic: VI1PR04MB4382:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4382FCF6B0DED070154125E4B3689@VI1PR04MB4382.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pCt4ncXK9zE2BXDfYKBJPd47sTEfA2CuNHuZmjrhbU9HNYaJxbNvJzBjsE3X5sxeY6B7E3Q/+XQZMN3AIfcAy6nsd4gBCL33H7XOUzefR+XXfPV97RvwBnvpdPUvQW7oSZByPC3HRPVxTd7ne9HR56M+dj6a0ZzF2ROENhO7n9FzuEm9CIPKCiXOnJvVP9VVcWAyk1k+/37I1dQHgN61act5XyFLIr+ZG9pfAV/njwt+r+A9KtIg8Jz1ldaUOb2M2ejq7BfPoVlEC7hgAkfpgBJ/7135akxMlYJk6XbwlW6S3Kor57DNXWZBDBNVgFbIwwaV5X+MnMZCN1EHrxIxAXPr7esNQUDTZEK10xguSb6cyjymeWWsYbHEek6vJgbm3vJj0FtsuSebwMK8MuOWDKKYMQZqGwLariZRi/DKb66CZD5QIJs49wjjMO4JjwPuyXqL7L3FSIs6D1fk96cEFPVgPA8n+1I6RvaUFg+0uJgO5txHGnD7AVTvdxjjG+LfaNtGpzE6Bnaf93Cp8Lb56TNd12h5l8eCxT/sm+C8T2aQkew4sA9H0/if9oz2z8ANlgM0vef5P9nVgPFTf2LzgQ+faLUP0736XuyTRaNZV1M5UNh/Bgty7Lwn27sJxeiND9jdPZ3aFZehOWjEdDZLhZA8t3b/0/Y3PObXpj1MtSss6bvOUbxPG6SJkmU5NM6wb2JY7AQRN80eGz7wPz9VrpsU+zXX2J/4ZuYglFrZrQh3VGw1IgZrcglsxiITD8AS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(16576012)(6486002)(66556008)(316002)(66946007)(53546011)(66476007)(8676002)(5660300002)(4326008)(26005)(4744005)(186003)(2616005)(83380400001)(508600001)(2906002)(8936002)(31696002)(54906003)(956004)(6916009)(31686004)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TnY4ckJ1enhzWEx3c0JONEFicEwzVGpnZUl4MFMzbmFWcTBXOXIvSDNRM2ll?=
 =?utf-8?B?ZFB2aHdxcjdBQ2R3K05xbmZsSG9KaGJmTFMxZVNXYzBESTI2NllFQ0JMOTNY?=
 =?utf-8?B?Zmp1RFYxVTc4VHk3NDBtdTBOLzNoSUdJVXQ4Q1FmR2JFSXpZMUZLcUxFYi9j?=
 =?utf-8?B?SnpjQjVsano1cXMwMXhBMlhuQnJmb0poTW1EN3l2Z3BkenZnN2w2aGhwZHly?=
 =?utf-8?B?VEU1RzExNDFEVlNGVHExQThuK1dsMFRvQU1WWXhrUkt2ekUzN1IwTXl5ZkRz?=
 =?utf-8?B?dUhLQkswNmFjaE54YjhVWVdZWjgvSUY2WWNodGlJY1YzWXhZdEJMNElBcUFo?=
 =?utf-8?B?R1Y4WVBYaU5uUkp3dk5HaExtTjZmcDZzVXBsVnpvL0hQdCtCeS9IWHl6Njhi?=
 =?utf-8?B?UDVoMVk2V2wvV3NPSHNLRk42WE4vNk95ckJJb1ZVNm9FRkZzdjc5OVZvQ3E5?=
 =?utf-8?B?K2RWdU9pTVpuZXNhR1FJWUZiSjhUeVRqUGhLWm5hT2NJSmcrN0NZbncxam5G?=
 =?utf-8?B?SXdCOXNOTVFtZFhCUHlIL2RLbktxNThVRnZtU0RwcTBMUGI5eW5lUkRyYnhv?=
 =?utf-8?B?QmE2WC95Y25yVkRQOGlJVmV6M1pJYy9SclFoektLaThaYVd2MWFSejhtbGF1?=
 =?utf-8?B?bWNPN3pRZzI0T2VhV2hyaXBSdVVBclcydUVJZzBvcUI1QmNPUEpzTTJhTll5?=
 =?utf-8?B?VFhMbTlSaXlOelRvS3JMMFViblYzMmlsQlJOVHAyZnZBNDdSRmtXdUNnRWVT?=
 =?utf-8?B?Q0ZLNXhCdVhuTGZMZUxzUDI5OTBYZGc2SGhsUWRiNUdSMHN3bUR0cVpKZHZY?=
 =?utf-8?B?UTBJT29ySGxSYXhFN3pDdzBIby9WTVQ3NGFuYUgxaFVZdEpSa1BvRjl6dHZY?=
 =?utf-8?B?UXkzWFd3Q0dRcnNvZHhIUndDNmtVbm9idENlZlZaQ1g1aTQvZUtqN09yMDAx?=
 =?utf-8?B?ZFdVd1JtVGd0WkdFMHpZV0ZvQVRiUDdTaEJEdWpycXduZWg5RTJzcTc3RjRL?=
 =?utf-8?B?Y04rQnVKWTBrVG9ZSDd2NnB0MUFSZnBiTjBCenlGVjFaenZ5RWZDUHJlYm1Z?=
 =?utf-8?B?R2ZEV1d3cVkveDM4TExJaFczcG9aWkQrQk5XMTEwTnpCd0V4c2tnempob3pz?=
 =?utf-8?B?SEY3eU12djVSR2UremE1YzZ3U2ZHSjQ4aXVhSStaeCtmcW81cGNqTUhjQWtR?=
 =?utf-8?B?MVdUeFRlalBySnQ5SFczQm9hTFFzK3NvVE5NeDdMYWdlcU1UR1lsejZqZldN?=
 =?utf-8?B?UXBYT0xDbDZwUlllSjFFMjZ1cmhENjdsTEc0Tkd6bEZvcTlEYjVmN2Z3RDlr?=
 =?utf-8?B?bWlMRWlGdWd1UjUyUEZnaFFDc0FVZkUvcEx1UGdTVVFiVkF0ajhlUnI3R0t2?=
 =?utf-8?B?SjRGM1NDcVh3SnhST1hhQk1CVjlsVzUrVjhBTm5LbDFhcXlRWTd0SDM0K1Nn?=
 =?utf-8?B?dmV6K0d0RzIxL0twMmZoSUgxUDRzdGNwRHRPNVdYb1E3N2swQUZGMkdqUWFK?=
 =?utf-8?B?bHBiUkZRMnc0Q1R1YTk0RjdvTlI1dkcrVytVVnNrRTY4MUZLVE0rNGJ0VFJC?=
 =?utf-8?B?aUx0L1h2QWpBdGFIUkNNVHZFT3E4UXluR3NnMzlWaFJCd1FzOSsrWVRsNUwx?=
 =?utf-8?B?MTlWSm9ERGJKVUZqT1cyVm1IZWJNYUtTbEYxMWZFZVB3ZjB6UzlpL3JMMWlM?=
 =?utf-8?B?OEh2OEN5bXNnL09OSGxPZjBEc0NOcENVdHV5WVFtMUhVK2RFanovdEx4TGdR?=
 =?utf-8?B?ancxSTR6algwV01ycVRuc3Z1UjRMYmE1OUtrU1ZQUHBwaGVOS2lGVlpNNVZh?=
 =?utf-8?B?eGIvNjV6cHkyQUVqcjBtWDJveDhkTEZBWmx1eGlXOHRVQVJ4NFgxMHdUekNM?=
 =?utf-8?B?dDRaN2hVTEdkYTF5OHhFNTdEVEtwVWNuRisxK2xMUUVqSG9HQ1NjZk1lS25w?=
 =?utf-8?B?dU0rdCtjVTlZYmtKNG93bFRhMmF6OGhES2k5Qk0yZlZhYXRURUM2R2ZwZk05?=
 =?utf-8?B?Y2JpV2ozckNxc1hwVFg3aWovNG1BZ2cxTmQ5NExwM1FnUU8xc0tYWXd6QW5Q?=
 =?utf-8?B?QzFndE0rMy9sRVlicWE2MWN3VDBnazdhMmY3dzRHZlZwSVZqYUNURUpEWHlG?=
 =?utf-8?B?c2NSZWlyL1QzUU9IZUFRVndGT3dhN3BFK1JPTlpXZnJCOG41ZVJUL1ZITHBV?=
 =?utf-8?Q?HrUYkfBFgJtpng4PpwQTJe4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd3c17e2-cc7a-4269-2115-08d9b4a209a3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:10:29.0642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4kLkwclmlSchDr4pOa4LNMjTCULJBwpUBoB7PQl24rv4ix+yU69K4424qgurtmUyOReXT1QnL56ILgr/eK3Jnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382

On 26.11.2021 22:22, Andrew Cooper wrote:
> @@ -279,6 +280,27 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>  
>                  if ( dest )
>                  {
> +                    /*
> +                     * When building for CET-IBT, all function pointer targets
> +                     * should have an endbr64 instruction.
> +                     *
> +                     * If this is not the case, leave a warning because
> +                     * something is wrong with the build.
> +                     *
> +                     * Otherwise, skip the endbr64 instruction.  This is a
> +                     * marginal perf improvement which saves on instruction
> +                     * decode bandwidth.
> +                     */
> +                    if ( IS_ENABLED(CONFIG_HAS_CC_CET_IBT) )
> +                    {
> +                        if ( is_endbr64(dest) )

I would have given my R-b, but I don't see where is_endbr64() is coming
from, and you don't list any prereqs here or in the cover letter. I'm
afraid I don't fancy going hunt for it in the many other pending patches.
Hence only on the assumption that the helper has got introduced before:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:20:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:20:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235646.408755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKqm-0002QS-6U; Wed, 01 Dec 2021 08:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235646.408755; Wed, 01 Dec 2021 08:20:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKqm-0002QL-3D; Wed, 01 Dec 2021 08:20:24 +0000
Received: by outflank-mailman (input) for mailman id 235646;
 Wed, 01 Dec 2021 08:20:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKqk-0002QF-Iz
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:20:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8626caf5-527f-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 09:20:21 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-WdHZ0cu4OnymedHa8VfZkg-1; Wed, 01 Dec 2021 09:20:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 08:20:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:20:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 08:20:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8626caf5-527f-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638346820;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=H317x/T4Cc0g5g3uVWK8laNIQpUCohRc7S+MiQ6t0H0=;
	b=JiAs5Gy/XI52a3hcohpwjU1BdALTf8pCRHikKer/pcrSeOdDMwvrL0qTOG+fgGc9EtGyDO
	YWFATPVGTHN3azNV2nRaNqpWL9WHoiMkQdn5YpCGVfQV8KX4u1vjWx84jZat/1GXNARTXL
	Aiwzpw2GlWtdV2aoZQdso9OmX2yUwUY=
X-MC-Unique: WdHZ0cu4OnymedHa8VfZkg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XkFKdRV+b5t0e/+wtbvX1jnlysqSOtGtR9qIiaQlfkKTy3xCXw+9yfuEulEWhOo/MS+KsYHLA1IF3iFkLL3z9II7lYLJsDTEEIgfQ5tSKNdkwa2rxTcIaXzu8bKtrEItO9MTj8aXQcUrI0sMl+MkluXWGAh61Z4MI4bDSMTgqmnY360lEqICHDcHI80vYtKmG7EnSWmWJ2jaA8cCR0NbpTtzFsy/f9PiXE+ISytiHg3Re+I2F5UEU4uyesPhaBY9/DvmTWEcU5VkOy5Pc43Sd0GvkReDf+FiSy0KNLlYisC/7pVdOmWrbaurQlfMNxZkSwO3ONo+6D97vrKCo1qwQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H317x/T4Cc0g5g3uVWK8laNIQpUCohRc7S+MiQ6t0H0=;
 b=NHYjnUUoD1WsTMxAGNzI70D0yOkDb+KnzusZQmcmqnNoh0sn3PXOR9h2ky3HYbe565/gZbmbGaajUcsJfXyu3QAqngxziqTXMe76A9i4xe67Z541NlqhWoOZldPSiX6XV1p4zldOo9IRpyZ9NcZCDeM30G7kXyfx6kihOxRpxpowx+hawOXzdW33NVWBCjZnl01UTc9oA8NOp976oNGojF4FEYupysJD42TtP6Uq6nPDatIkP7nV5BcxiqJxgO/rhRcj02UmV1d2IalTaTV4kfsFJba6YvnRKdhEExZgLLFmpc4sX1clHFx1qvzvn/NWebMVw2zDfsFu6qHtN+kSaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3ca82514-2adf-2445-04d1-0020dde16019@suse.com>
Date: Wed, 1 Dec 2021 09:20:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/4] x86/altcall: Optimise away endbr64 instruction where
 possible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126212258.7550-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0008.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5502ca59-693e-44a5-c6f8-08d9b4a368cf
X-MS-TrafficTypeDiagnostic: VI1PR04MB6302:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63023F979067FE93457A420DB3689@VI1PR04MB6302.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pTSXvS9GJvdpWxHT4o1bVUcWWmLeJMuRNWHtDp0nOqrGrlgDtR+Bh1a2CKn5S031zuByuIoZjhPtPycyUfiDp5cUVg1bgWI0+Tu6QPWOW07y3g9ydYsAIeZ5xGzqscICgbzSrDBHdeTBLZ4OX46raF+IQOHIuvAhJqFqT77s+4vQo0Z/G0QQz2uBiCxHRqQpMzIbqJBMXRw8O8bO7BYlIIpkaAVtGInWvDRBxWuzbuqT3PEk5aHNjICwBh60k/6uSGGA4VibRBAIBgk8YlS3CD/Pk9tNigyJ/drY3RLwM5Gmx4ovRRf9ahRaqZxK6YiW5/PIN05U6aDlSnE+iD4fj8OAWmZqI3OKNAmHcX4mOskyb6uxN4CSjcTU09q4veEl4aJUp60a6SNkKCoydberU7P+r3j9P1fkrclMAUvZOv5oYz2ggO8SLqIEsL/4LAMGJIHhi4gQs9uYRPYqY1U0Zao3LZc41Bj4+Ls7DvNKec1dp0AC97QFXtznhqabRPvw1tcuGA9Xy/Umaya6eKgmcBDJdLuM5FvP1ZL+VqXc0azimCRX+lEKDf7dCIs7z7aJTj9m3HyCta5uh6aJ9G9JkrMy29wV1HiEmvTov/xQuHl5czUzh5v0lV6kYL1EWmaDwlzoeyYdJvbS4KBjSQSKCSbQ3WuKXA4JbS+1vKu+iBbX8qH0GF4Kf5O77gRN/8K27AWOjC7rmK1j6zJiSGCDkBT6x9T6ivyuSIT8LRle33c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(54906003)(6486002)(66476007)(186003)(6916009)(83380400001)(31696002)(8676002)(2616005)(956004)(2906002)(8936002)(5660300002)(16576012)(31686004)(38100700002)(26005)(86362001)(316002)(508600001)(53546011)(66556008)(4326008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SmViSTlYTVZ5L3I1aW9waFhKTnFpY1A4cDlSTkI4VkU2ODloQkk1dFVOWkZC?=
 =?utf-8?B?U2kvUGNLLzJSbmNBYmNwUzRoUXpnRWFJSFlLOEt6OEF5V1lLUVNuTEdXR3Iv?=
 =?utf-8?B?d3J3OE5SOTF0M29xamx6bUVLOFdYbzRRVFBPOXFCZVZQTEZLNStqZlFDUWln?=
 =?utf-8?B?NVRwZ0NRZG9TbE9CQ1RUVkZmT3JZczJrVmlUZmtSVEh0eUMwZ2JDeW1NOHpZ?=
 =?utf-8?B?S2dSbFczM3RpMkV6VDgzUjNwSHJHVFBnRTJNR3FBNEoxcXRtWW1kbkRMcmlZ?=
 =?utf-8?B?SVM3ZTNRSHRHbjFiS3RXMUJTYUxVNWk1VC95TzN5VHRSd3NWZFUyZG44eURr?=
 =?utf-8?B?Z1liMXhqeXpjQnlQQnFMK0FmU1d5Y1U5SWZBLysxNlRjT1ROR0E4cld4T2xi?=
 =?utf-8?B?T2hvaTUvM3VsV3d6T3pkVlpEZjRGUWFDVVdxVERzMFpLN2NEbFBod0hHOWp4?=
 =?utf-8?B?OXd0cVdFSjFxcjdKekJZSG1EeXNvbFhVMjg1VlJEUURPMTdWS1EycTZ0S1hq?=
 =?utf-8?B?cGFkTmVMVjJydWlyZTBaSjZ2QWh1ZjVZS2xWeFNxVTZDSWI1M2lmR1o2a2Z2?=
 =?utf-8?B?NXRlZy9IUmdXbjl5MDR2ZkJ5eGUzY0xJRllpQ3Y5cVZaSG5qSzZDb0N3KzJw?=
 =?utf-8?B?WDFwQndhcS9CRE9vazF2ck5IWFdIL0Z3clJheHVSOWZVb3JjMXA5RzVVU1hQ?=
 =?utf-8?B?OTFUdEwyWW04N1BwT1I4THRZcWs1Q2Z4RHJwZUN2SXFyK3IzL295dkI4OGx1?=
 =?utf-8?B?YlIyQnVkOHNFZUlZbDhnQkRuSjU4djYvenpvRml0OGNoek5ibU5BRUhQaEZO?=
 =?utf-8?B?cWtoZWlHaW5OZzZnUC9vZk02bk1ITzBPdWp5ZTZieTBtL04zSFhFdnBIMFFl?=
 =?utf-8?B?RUNXUzRORkNJcXVUb0hxY0JYSXpaYnlidXFham9xSUs5Ujd3bG9CSlpGUHpT?=
 =?utf-8?B?RW9JWTBiU0FGaHdmNFVsQXFvTXc1bGRLZ1NQZ1N0em11ekpPU2IrZnNxZ2Jt?=
 =?utf-8?B?NTFUeU1QZEx2R2NJaElORTZOUjFiVnp6aVRoR1hWU3g1OUVzWTloZEpJMDN4?=
 =?utf-8?B?dy9HQnE4WVloTVZYTWYwOENETjJHUWpTU0k1VVhGcGVnTFBxNHBrZklyTzc5?=
 =?utf-8?B?ZXk5cm54c3R6YjNqeHZVN1hSMGd0cFdkbXhoYnI5cVpCQlJvU0xMTkVBVjZ3?=
 =?utf-8?B?R0hkRGVkZXV6VDZGTXJlNzVBUnNoUDY1ZmRQYjd1dk96WGtZZ3BEUW9JcFVo?=
 =?utf-8?B?RWlKRldqQmJ5U2dDMnlMNjFxdXNmNWl3UyttNzM2ZVFOcnZqRXdodEdFeU9M?=
 =?utf-8?B?b1FmaXM3NTZkT0VBNTJFTmcvTUdjZk43QW4wUEtsdXB5MlJQWjU3V3lyL3h0?=
 =?utf-8?B?eHZZSUYzR0RLakFwRGlnT3VDTUNLbTEvUFdKVjM4eFg4c3hrYU45WlgyMUhV?=
 =?utf-8?B?dUsrKzRyY2ZGb21KeUxQQjZ2SzFzT3dNWlBFUDJKRXdSLzBZRDhVVU5Vc1kv?=
 =?utf-8?B?MVphMWJFSVAxSTIxNC9QdUdSS3A2M2lLdnMyY3lXRjVJZ2JqZnd4aTZyVkIr?=
 =?utf-8?B?bzV6OEg1TkMyWVhyVU1ITEZDdHd2NHNUcDRHUFZFYm8wYkFiYWF4SndlRzF0?=
 =?utf-8?B?ZDVMbysvNzNxOTF5K1B1Z2VQYXBnaDRvbWxhZHI2Skl1S1AxVU9ZTlJTd3FD?=
 =?utf-8?B?aE1vUTVHY0FjVzJWUk55MzVna013YjZTWkVoM0RSSFZtbTdqRlBMWUFxaUlm?=
 =?utf-8?B?S2ZVU0JodW9EaGdqazlCbU43SnRLTVFCdTBtL1piNUFKUnRlSU1rbGZSczAz?=
 =?utf-8?B?NDZnY1RDd0sreEJKT3Y4Y0YxZGhUTmppNjdSVzlqVkpaaG0yTlF3QW4wY1Zz?=
 =?utf-8?B?MzJaK2prMUFpS25BZGlnZUFMbDVWMU5YSTNCb0FuTmlUTVJUTWhYTmZHRE45?=
 =?utf-8?B?T3JzUEZpM0VrQzRXTnZ2dHZuc0s1eFdBU0hYQjA2YUU1eUVKU3JzVUJ4Zzdq?=
 =?utf-8?B?QXYwYWl6NVozVXdqWGVSZEN1QWRMWWJ5eWlIeExpL3JKSmpLZHJZK1NVM1My?=
 =?utf-8?B?MUxlNnh0bCsrd1NIRk82V0xzUFVuYSs0NEw0c0M3dXJhVFhzTTByV1p0Vk9z?=
 =?utf-8?B?bVg5eFBIVHI4bklHYjNvTTZQelBBT244Y0F4MnJjNzhXcHBBK2hSaENIT0tR?=
 =?utf-8?Q?4ToSRM/OFpM1i7mkdVsBR0Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5502ca59-693e-44a5-c6f8-08d9b4a368cf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:20:18.2021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZJWjYHl1ufKg/kCc53I6AdFCVhlPHg/eGYSChLGCMaUy3aCAs54nELgN1ttf+whURmlAD+AjtQSZyfml45/5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302

On 26.11.2021 22:22, Andrew Cooper wrote:
> With altcall, we convert indirect branches into direct ones.  With that
> complete, none of the potential targets need an endbr64 instruction.

Assuming that no other hooks remain which re-use the same function. I
think this constraint wants at least mentioning explicitly.

> Furthermore, removing the endbr64 instructions is a security defence-in-depth
> improvement, because it limits the options available to an attacker who has
> managed to hijack a function pointer.
> 
> Introduce a new .init.data.cf_clobber section.  Have _apply_alternatives()
> walk over the entire section, looking for any pointers into .text, and clobber
> an endbr64 instruction if found.  This is some minor structure (ab)use but it
> works alarmingly well.

Iirc you've said more than once that non-function-pointer data in
those structures is fine; I'm not convinced. What if a sequence of
sub-pointer-size fields has a value looking like a pointer into
.text? This may not be very likely, but would result in corruption
that may be hard to associate with anything. Of course, with the
is_endbr64() check and with a build time check of there not being
any stray ENDBR64 patterns in .text, that issue would disappear.
But we aren't quite there yet.

> --- a/xen/arch/x86/alternative.c
> +++ b/xen/arch/x86/alternative.c
> @@ -173,6 +173,9 @@ text_poke(void *addr, const void *opcode, size_t len)
>      return memcpy(addr, opcode, len);
>  }
>  
> +extern unsigned long __initdata_cf_clobber_start[];
> +extern unsigned long __initdata_cf_clobber_end[];

const please. I also would find it quite a bit better if these
were suitably typed such that ...

> @@ -329,6 +332,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>          text_poke(orig, buf, total_len);
>      }
> +
> +    /*
> +     * Clobber endbr64 instructions now that altcall has finished optimised
> +     * all indirect branches to direct ones.
> +     */
> +    if ( force && cpu_has_xen_ibt )
> +    {
> +        unsigned long *val;
> +        unsigned int clobbered = 0;
> +
> +        /*
> +         * This is some minor structure (ab)use.  We walk the entire contents
> +         * of .init.data.cf_clobber as if it were an array of pointers.
> +         *
> +         * If the pointer points into .text, and has an endbr64 instruction,
> +         * nop out the endbr64.  This causes the pointer to no longer be a
> +         * legal indirect branch target under CET-IBT.  This is a
> +         * defence-in-depth measure, to reduce the options available to an
> +         * adversary who has managed to hijack a function pointer.
> +         */
> +        for ( val = __initdata_cf_clobber_start;
> +              val < __initdata_cf_clobber_end;
> +              val++ )
> +        {
> +            void *ptr = (void *)*val;

... no cast was needed here.

> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -214,6 +214,11 @@ SECTIONS
>         *(.initcall1.init)
>         __initcall_end = .;
>  
> +       . = ALIGN(POINTER_ALIGN);
> +        __initdata_cf_clobber_start = .;
> +	*(.init.data.cf_clobber)

Nit: hard tab slipped in here.

> --- a/xen/include/xen/init.h
> +++ b/xen/include/xen/init.h
> @@ -18,6 +18,8 @@
>  #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
>  #define __exit_call       __used_section(".exitcall.exit")
>  
> +#define __initdata_cf_clobber __section(".init.data.cf_clobber")

Just to repeat what I've said elsewhere: I think we want a const
version of this as well.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:21:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:21:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235649.408765 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKrj-0002xZ-Gj; Wed, 01 Dec 2021 08:21:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235649.408765; Wed, 01 Dec 2021 08:21:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKrj-0002xS-Dg; Wed, 01 Dec 2021 08:21:23 +0000
Received: by outflank-mailman (input) for mailman id 235649;
 Wed, 01 Dec 2021 08:21:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKri-0002xK-Lb
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:21:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa50c9f0-527f-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 09:21:21 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-13smKxOYPtSj-lnCq3JbqQ-1; Wed, 01 Dec 2021 09:21:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6175.eurprd04.prod.outlook.com (2603:10a6:803:fb::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 08:21:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:21:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.21 via Frontend Transport; Wed, 1 Dec 2021 08:21:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa50c9f0-527f-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638346881;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=RZu4PDmecZX7QRKHNDxESsRak5rcbyRea+cbNBa2B6U=;
	b=Q27AedOnDcLa2PMojZkEOYIeGyXkaLyBOo85CQ0x1LTWqmp6YVHKm6uQ9RMHDa0nYA9BYJ
	FyWogrRZT329WtucZlyu6RISvgqiTYFavk8/r+BXaLA2tiMbHGFlGbHlE9MtE+kHvmAsiL
	VcdUk107A4AIyraI9d3TZK3T2i81trQ=
X-MC-Unique: 13smKxOYPtSj-lnCq3JbqQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dKc67BxGlCfrpAV7IHkP3KPExaNDp1loCn92AdVLYDuuu7hxIk+BRcjTZJrCYFP1e+RQah+9JWZJbvOrKMSBKXhlESPHsuU6oHPrAuobxKpbo8skwvAkiUS/ExNLvYV1uZek/ch+rKd3h0UTsnjBqYT8pcmbvWdrM5pKP6MgBT/xgC+V4KAgfROscM3IGrNkJ5OhlZiGW2IaeiBMsVrDqI0VTw0r2hofV8M8TgLCaXXPlCsZFhziO24/ZlnheOtLn9VoDGqm2tAIJlU1d9jfMJ8YhLu0G82XlF7cISvbSH2g1wiE2qmD5GYcfzB+hdOdYjWa32piC8smkncXQx003A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RZu4PDmecZX7QRKHNDxESsRak5rcbyRea+cbNBa2B6U=;
 b=dL/gU8wVRgTq0rc/1BVeucqsIzRFL9wOYvNNDvmuOGeGbrmCTzvID3TCE8ok849eqN7a6EK3HLfBsAF4UND8u3lXQxatNky7G9NXbI4qQKVhNuy2ukU+6E/Xe/NUn/7UWTFUeltNH+MmMg9tOCSIhFx+sdkIZ4RibaMFn1I6yoE9wqRA9lNTDPGd2Y/c5RAv+7SjEsYZz/WZ2iD2CqZnRsXf8kK4i/RPem23NXvNwCIbQpzvBO7xFkN8PjyWiDNfPVbEW/riZXRGE/fSNgnQaI1cLzcpXg40YYmj0Gluh1pCYn/yZ3nR7Q5Sl3pYssHiczic/m1geCguQPpjT7gpOQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0738cd0b-0914-b94d-f07d-68cf7bcbc8bf@suse.com>
Date: Wed, 1 Dec 2021 09:21:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 3/4] xen/xsm: Use __init_data_cf_clobber for xsm_ops
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126212258.7550-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0002.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2d7c191-a2c0-4f4e-2e19-08d9b4a38c51
X-MS-TrafficTypeDiagnostic: VI1PR04MB6175:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61754A69ACD12C8A86351204B3689@VI1PR04MB6175.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1468;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WyTDMuyaHq2L6RtNwc7Y3+Pcznz01jphDVkRQvRXsXWHZVWr/Zdo9alDYD7Efo2j9OzVsGyj8JCMD83CVv8yAUFsRanPxNmMz86xE2+yT9f7cc9BTEoB5xWeSPB9yh2SykgrMHsx92dWzaaPlDQKM5X9GajBfsg9xb4Plc5qIrsqV+KP8waq4ROuY8zfXM5U/M77TxTr19fo6jd/zeKzQwt/F4phKovZsMj4L6GiZ4MyqVb4h09f46NfXQ50QLXO8YWBHJdwin52HpYluw+dOlC3LJNzSRB6dlRiNO3t523zKU1M6JmwxV0YGDdqBeVxHhDb9oWHCLPEFSZVgMP/ePV1+YckP2b19i6S9OPjOGxUcHinuZ4Bg+ydgZqamZc9RvbzouEgJeVaCsresox1xY+C75QstivY/8lNHWtlD9zkiSKJaRXaSO+2Y6UM3S8pOQonNjX0a8Nxd6utL3j+VGvlDekD/04xcp6ztu8p51cdKOn43vcjDWdSwTiKfa44iRoNULdlHdmbTiEuJLRIGJLKGiOrH4ofTFTm2YYc0//jppEiHuUc6ISQJZRZJ+miWmxTjf0BkvYVLMw68pwbih/4LkmLvGHDMg/qt29x0XAcgbxIxnvqrp3/AaR9TA4cTn8ewaNgLmjgP7r3yA0kgn5CDGUbB6PBSRiPIEy1Jlx5kUDK3AxegKWWDKMQoHbnpoUDeR4t+5dJLBXAGy0Y1BwF2fhj3mZ8UOEhByhpjYzsGT7MeTvTwbHW7tfdOGd3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(316002)(16576012)(31686004)(66476007)(66946007)(38100700002)(31696002)(8936002)(8676002)(2616005)(54906003)(956004)(26005)(186003)(6486002)(86362001)(5660300002)(53546011)(6916009)(36756003)(66556008)(508600001)(4744005)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K0t4TUY3clVzdEcxVGhlNjJCcmtpWlpVcHlaMmxkTFFGb0twMTJhYmhyeWR3?=
 =?utf-8?B?cnUxMnVFd2crZ1Vab1ZHSkZpMDdFSUNvVWlDVWNmemY2WENIeHBmRTkrcHMx?=
 =?utf-8?B?MHo5Y3FhWEFaSHZEcUZsM3ZPQ0pwRERseXM2S2RhZmMvYzNsUjdleURFYVhs?=
 =?utf-8?B?WTdPZ3p2T083V3YwRG00UklIRFJRRjJBMDV2dStXSzNHVHp1Z0RjQjVrZStZ?=
 =?utf-8?B?ckI1NmpKY3N4ZjArVkh1bGVIUEV5WXBWZEJ2dzBQN2RnQjhhTDdycmwvWTVN?=
 =?utf-8?B?eFZYK2l5VXkwazZ2Qitwa0E4MEdxOGZSN3Bqa3ZMdXJRbHdEaDRkTS90d0xR?=
 =?utf-8?B?ejNEU0M4Y3QwQVZMVWR2VUpuWGRmNk15QWR1b0ViYmpRS1NqTEVzZ2F6QzZm?=
 =?utf-8?B?VU9aK0RQSHllZ3p1cE9RTjdUMEkyRjFzY2k4dTlJT0dpYWhsd1RTU3pDdXk4?=
 =?utf-8?B?ak1LSUE1RlZwRW41L0FHNHpUZGw0Zm15WkVZaVZZUUMyekJYUnFUMFdlUzhQ?=
 =?utf-8?B?WVZKaWQ5R3MwWEZrLyt6eStSYXhGa29OMWhGTWpGR2hOU0h0V3Mxb2tLcE1D?=
 =?utf-8?B?MXBoTndyRjVEMDYvQ2J6aFl5NExnMmFuVnBoamVZNllhd1N0OXZJbHBDU3ZO?=
 =?utf-8?B?enVQL3huc0FxK0pxQjFVajJBZ3dSeWRRajhXOXNUU2NvelBQTTdZZHRsRE5y?=
 =?utf-8?B?S3hHd0dSbSs3N1l2VEZXNW1QYXRpVXNYTVRSbGo3Y0Y2ZmJMVGFQZmsxK25S?=
 =?utf-8?B?ejNzRHYveHVoc05MUFV4MUJQZWR1bUlFRXdyVUNnZ3ZMY1owN1VXOWNvMitE?=
 =?utf-8?B?bjFJcDliS0hGbjVSNlJkeGdFaFNJWWZBSUYveWNLdEJOR0JEZS9nZFRhTDFp?=
 =?utf-8?B?OW40Vkd2V29WYW9xQmdPQnIzSXJCbkZ6VUhVZlRjSUZKZ1FJRTZXZGZWOHhw?=
 =?utf-8?B?cG1weW9TYjRhU1d1QzVEbTJ5WlFxb3Z6Y3h1QzRtRzBPY1YxY0hzcXJndDZ6?=
 =?utf-8?B?MnRJUStROU9FZ0VtZHhwSktiVUZQdzYwTXFzMkpnQk1sS1FmQW5mRDBidW1C?=
 =?utf-8?B?SEZnc1ZOK3dNOWZqTjBzZTA4b1cvVGtpWVJ6TVkzbGxWczJ4bi9GZFlVUEhk?=
 =?utf-8?B?Vi92RSt4MnozbGx2R01oRmlIZ2VrRk5Xb1JJZUJucXdsOHFZT3lzYXl1MEtI?=
 =?utf-8?B?Z2VwVjNXeGUwdEcycjg1RjdRMWNBQnYwUFU3QnBzYytzYktSQVA4dEpwUUdq?=
 =?utf-8?B?cTBlaHZQNUlQaU93WWJvQmNOZnpxUnNQV2Nqa2xUZEdpall5TDNJOHA0K1Er?=
 =?utf-8?B?eWJmazZiQVFoUzY2b2lNa1o2bVp0aVAyQnlNWk1zNnVFcDN6cS9wbnpHWWE5?=
 =?utf-8?B?Tmk1MytveEFtY2d1SzdNYzhmdW9pUXE5S3NZYVRHOE1mV0tGR2l3dHlLaFlm?=
 =?utf-8?B?QWNQNFhQSk5VbHYxempIMzRESCs1VlFMMytHemFHeDFMakt6YnlTMWZ2SlU2?=
 =?utf-8?B?dnNKSzY0b04rZWVnVkdiNjEwanhHTm8yNEhHWWk5V2x5V2RtczB1NlZoTFFm?=
 =?utf-8?B?cXNwR2NwWEE5eFFVTjJpUEpIYkJUdWRFRmlkVzBRYWFDdVpUeHlwTGNVbjFL?=
 =?utf-8?B?NHdSRXZXb00zT2NoS29ValdGa0ZZdmJmc2lJRUxkbzY0TW9naWxDVnpHZG1a?=
 =?utf-8?B?em1MYldEbjRLNkkwK3NiU2lScjVTcmVvd2x0OGpQbUFRWDFPR0wwNE5odlBn?=
 =?utf-8?B?c2EvenI0Q3c2QnRpU0Q2c1dpd001R2VTVHV6RTg3ZTY1WkRqa2Ztb3k1dGVm?=
 =?utf-8?B?NFRuRXNhcENCV2xtaG81Z3FwUjNmQ1VPZ0JjMHFNdXdDMERoRkxFUy9obWN3?=
 =?utf-8?B?OW9XVERIeVFXU2duY1R0bnRSN2tZOVAxb3BhZ1labVhLVkh2c3pXUFFpTitL?=
 =?utf-8?B?NTZTaVVzajJNTFVEOHZUYXNuTml2eU8wVjU3RHpaOWU0RlNBbzhRZU1NVFE3?=
 =?utf-8?B?UjZIZnpUNnJYcGpmYjR0NWJ5N215eEE2blQwait2cXlNZ0I2bXN6NnRVN0lt?=
 =?utf-8?B?aG01Q1VEQW5iZ1RwejcrUlZma2tOblJiVFEwVERMSlhZV09mUW96eVViUDdV?=
 =?utf-8?B?SFl4ZDM1ME9VaWZhR0xBSlozWDFYYmtKb3lPL3JOamZZMjNNdHdXeVNZejFm?=
 =?utf-8?Q?N9fJik8oDGpvvvpkYKwbO1k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2d7c191-a2c0-4f4e-2e19-08d9b4a38c51
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:21:17.8204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bHULCZMYrv7x/H8HhYMdqf3leioAxjqhw/t5IGQtJ6PTqV6TEB+WHvFqmoFnBDXx7o51KU4HY1ppyAHK51MrfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6175

On 26.11.2021 22:22, Andrew Cooper wrote:
> All calls through xsm_ops are fully altcall'd.  Harden all fnptr targets.
> 
> This yields:
> 
>   (XEN) altcall: Optimised away 197 endbr64 instructions
> 
> of 1655 on an everything-enabled build of Xen, which is ~12%.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Subject to the resolution of the const aspect
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:23:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:23:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235656.408777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKtj-0003dO-TO; Wed, 01 Dec 2021 08:23:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235656.408777; Wed, 01 Dec 2021 08:23:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msKtj-0003dH-Q6; Wed, 01 Dec 2021 08:23:27 +0000
Received: by outflank-mailman (input) for mailman id 235656;
 Wed, 01 Dec 2021 08:23:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msKtj-0003dB-0m
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:23:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f47d3d30-527f-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 09:23:26 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-caIcR8-4MpeZv2Diak0fJw-1; Wed, 01 Dec 2021 09:23:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3390.eurprd04.prod.outlook.com (2603:10a6:803:9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 08:23:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:23:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0074.eurprd04.prod.outlook.com (2603:10a6:20b:48b::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 08:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f47d3d30-527f-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638347005;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=r8WoZLuvw6Be1Wvo2zfIpdJ59RRLJlaWGE7mfQefSdU=;
	b=bGzDX8FdocHYb0x4NSdE04fXwbmXXHvnZHcEzcC633Qc7NWu/4iX7RBOoyt7mKOx59h6Iu
	/Jr2cObSuGvZUamKzskANA6Qh5yO/5+U7qZWeiHuc/92mvXYKRY3WSOwHe+UIxqAgVbvn9
	M1fEuZjIOqy1SIpr+62g7XWq1mLyzy0=
X-MC-Unique: caIcR8-4MpeZv2Diak0fJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FiEsWaSLxqwcgDx79wP+621u3jlXCGyMo3hTbVlGSzG4JbEfo1LkWG4G5XOYiEbAZqsx8i41nOX2q0OxS+ZD7hB77N3uI7pYQEh/glZQRMS1qbdAVdvOVKFQUBHe0P6o9D43ojIDIkSg6YCeG0xzkw7rlT9h3phI3+3BYNHMxDycTAGZi+ydguE9a9JqmoDEo+1D3Ll9Ok8A7LM/dLvE7e+uVvIVGwSvPkonhv2r/aw6oippERolRfYxX0+g1051Im/PqMlFmTXJRmzzFr68/A+nZtEOHL92z3T4CQUebw8j6j0hia7Ul+ZBmwaFZ0xC+z5Ge982dNko8Ah3KCJz/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r8WoZLuvw6Be1Wvo2zfIpdJ59RRLJlaWGE7mfQefSdU=;
 b=TPt89Fp2Y8cEx5SYA7PzN2vAMDUx6YHGBgWnpd6F+NwOexob0M42ktvpjn/p0rTBWe2HPi1Kli3kUrqWymhPUWJjYavFiSVoXMiY7ghlmQthg5RV7VH7kloz9iAjvzj1WP3kIOm20p+ST8sF2tCT/PmVYZtnNdlUGy6RLsDBiRiX8kyG8g0seOpaUnEAzTxutc1h7LgO62nFjIZltgDO4p8POTXiXHH0C4s6N+kiBf39ZBF3GqKmFs6O55FdAFHGD+z0QLOiLYtIK/PeaIz2bKrCD80UUkwuzN/TyAMAwKVa0DAlhMUsUuusH5htEng/xbgF6ypJmX6mch1K7TF81A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8943376d-b6cc-6c04-c4aa-c8d30800dfca@suse.com>
Date: Wed, 1 Dec 2021 09:23:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 4/4] x86/ucode: Use altcall, and __initdata_cf_clobber
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126212258.7550-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0074.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6a2b6d76-fa33-41a0-7907-08d9b4a3d722
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3390:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33909C6DDA994E65D2470D26B3689@VI1PR0402MB3390.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	q/7Inb0MsGwvbD2RWsA0Krse9WiFFE3INspXvtAC7CPFn42hFf5RHklZu3HDOnXkJOUhhrI43QXv1pG/wF8HreXeCuAEJLlHR/MFb+LcojAv+o3UBnNMPRSMl0ZMpB/yRSOxP15CeZmREA1DPNajSviwCltDuEwRIBn9Qymfk2Z8ulbHklCJ6OJCG+1A+fnUZtyes4wIO/zewz4SGtTxoVdxUd9DuvYS+76YeRYJxMSuJtNZ11zCGoY8ROgssBusMfQ7Ys7No60URp6k2rbIVZ+I0f+vpgl+N/ied89O9SVZ8CzCm4eo4SnZHjYTUJChg5/hSaCj0Y8oUQp4jqRldro0NynrBMDN5rGL0aEr4rSfHD/KWnQf4Mg/7nbBwDptrOq5oV0tZgn+Th0ny7T3Z7AyjnIS/bOwcqNf24Rsh5fvUzJVfMGAcDEAJh7/6fc5UnygkmL9HD9Ykvva8AI3JkuNtqbJY98UpM+y6kCZTmu3jVsZODj5xeJDqjlhUdMgYzu6sWdKW1xRS4q//f4rCXbzal6GtXA54KepsTjGWRXc+ErjUO5FGMsQ1sinKVTuRHWHlGOZERva5uEf+a/BhpCSBKXA38JW+Xnlh9njKYMyYmYmevz0NXxqCtiCegMzNPIQnmDODmFQHrVBhg3pdSHDuWgFLRfV85ArMto4Te1GBpNKxohIVScxvjp2xmUx5M9GlOm8Sehv4Al+/EqKbY+LQB7XP2d0qMGA8Uf9KEA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(8676002)(26005)(31686004)(186003)(53546011)(86362001)(5660300002)(4744005)(2616005)(956004)(2906002)(31696002)(4326008)(66556008)(66946007)(38100700002)(36756003)(66476007)(508600001)(6486002)(83380400001)(316002)(16576012)(54906003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RXZpLzFIV1RoUnMxTWM0dTJORFFONFZZeEFTRG1JTFQzajNvVEZRVnVnZDNp?=
 =?utf-8?B?azVjNkJpYjRMV2RwdXNnOHpnZ2JRK3dBdUZIOE9EdUdRZWNMK0UyUXpMaFE3?=
 =?utf-8?B?dXZTL29JUDVWbGpjOWoyUGN0dUZWZ3JMemtWUUJpNTlyMzMxL1VINDVXOUk5?=
 =?utf-8?B?SCtnVFJCY1JNaFhNWHNjL3JyVGRRVTdXTDZjRGEvU1pGV3lVY2NsR042cTlI?=
 =?utf-8?B?ZVZHV0RPU1BTK2I1RVdvcmowV0RkQXVBV2RnMFRHc1I5N3hnSk54VTZWN3ZP?=
 =?utf-8?B?SzZLMURpc05qNldETGF6T2tWSnU5d0d2cW5Wby91MXlNUkNndjdnMnZTWmIr?=
 =?utf-8?B?S0JNTDdRaVJVV2Y2MUJ3QlRyWEtZbzh4M0pZc1Y4SktEbEdJRVNNanBIYnpn?=
 =?utf-8?B?Z3lvekZkVSt2b2k1bDNDckNoeWd4aTlYbThuVk05VlJrZDlrcG9OMGh0Ukgw?=
 =?utf-8?B?cmpyZDJHcXFJUHpRdXRaUE96NHU0M2J0V2ZkU3owYVBpUFhLSGtnelJhQXJ5?=
 =?utf-8?B?eVhjWXBjdktHTXhpd1Y5ZUF6Vmx4Y20xOUp0bmN4blBqTzhEaFRrTzVZYmlV?=
 =?utf-8?B?bnhHdmtNUHBYMGM5Wjd2c0x3dFdBaTc2eU5TS1I1YkMyOW5TREp2cU5WQUdC?=
 =?utf-8?B?VVE0emM4OEE1KzhERFh4bWY1T2NpNzlWdndrYWxxdDlseTNxR0VsMXFPUVpx?=
 =?utf-8?B?c3gyNGQyZGwvdTFJMlFkdm1RYzhrdjBqQXJPUHFhQzRtU2JpbWhlUTkzdUJL?=
 =?utf-8?B?MTluZk5ORUoza0tRQ3dlbXhxUGY5RFNaT3FDTmN2ZmgrRWdzYUFaWXlTdlEy?=
 =?utf-8?B?VTdRTzU1VkZxN01FWmJ2T2czdEhDZ1NROU14cnIyVDl0TVZMY0JZVERsaFJB?=
 =?utf-8?B?c0RZT25ibjFtZC9oZHd0ekRTYk55Wi90Q2kyV3JNUlAvZ295MTFGeGhDc3hN?=
 =?utf-8?B?eVdPeWxVRTVBd1ZUWGNuZ2RpUGJ3Z0lGRU5xMDVQcVk1YlNlT2x6WFJIc05H?=
 =?utf-8?B?V281SWZiYkx0dU0xRW9IN0tnZUZDWWw2UWs3TjdIbTJvQmtaOEc1RytRcUEy?=
 =?utf-8?B?aHpFcTZGd04xVlhOYnJyRktkOXV4UnhTSmw2dlJ0STZDNkYxczRSVnlDbEJE?=
 =?utf-8?B?NUJQS0ZSR3hTcloyYkw5NUx2WnJEYTltVzI4S0RZcUM4SEtlZDBLQ2lKeXo5?=
 =?utf-8?B?V0Z6d3lMeFc2dHd0KzFJbFVENzBOME5PdUozTytiamM4Z2dyckFjZzAvRkZI?=
 =?utf-8?B?MlY3NmlTMEVzZVAyajlxUVptdGFwcnQxUmFUdEQ2RHcyd1NoMkNiSjk3d3JS?=
 =?utf-8?B?SkpMZ0o2SElPU09iZVRZM3ZUZzlJcEMwWnkwNnVOcGRLTWZDb0g4Ui9ZWlZQ?=
 =?utf-8?B?NzRVaFQyVmdVYnpyN25LQW1uWnBnV3ZhcEVaTU1Jd3Urb2JLZlRJKzgyYnZD?=
 =?utf-8?B?MnA5c2lmeE5MRXB0UThJY25NOE1wOU1FaUtYVitObzEyMDVGZ1VjTnVVY3NT?=
 =?utf-8?B?V1gwUDFWNWNUU01XcU0xb3N3cjNITnlKaVBFSHh0bFE5OUF4THpaajdXN2hs?=
 =?utf-8?B?RTRKdmJYc3BvRmRxbzVSWEJtZHVjbUF0Tm1kNE1zR012c2dTam9ZdVV3bjZ5?=
 =?utf-8?B?b25CaHBSZERPZmdsUmVlRXZvaFlteWlqUlc4NUNRS0JpYkZGa2xIUHJNeGEx?=
 =?utf-8?B?ZXFEZXZDSlh3RUtpeUUrY1gyNUY5OTVQZERXVGsvVmdjL2o3RnhJbXA3Qmdk?=
 =?utf-8?B?UTRka0RMbk9NS2Juc1lnKzk2V2tHL3NjY1BKTS93MVRXNXgvR1dlSk9wSCts?=
 =?utf-8?B?U1JmKzVLMTBpQUZTdFZRUnhPOUpZVkFNZWREWER2Y0RJLzJmY2VKckVPUFBY?=
 =?utf-8?B?VVRIMHBGSk1hYVUvY2NTdEt3WURhU3pHeitKWFpsNG1qbzN0RjNZT0JnaGIv?=
 =?utf-8?B?MTUrdnd0cWk3RnBuNDhFaC9wUGpGL3l0em0xYTJGVUlod3NmdjhEa28vY3Rl?=
 =?utf-8?B?dG41L2VQOEFOUy9qYnFzQWdUNHpDMGZqWm1CS2ZYcHFLSE53KytkbFRBMDN2?=
 =?utf-8?B?aHRVTzZ3bG1HWFR2eW43ejBCLzhlSXhDM3B4Q01oNTk5NE1hWmZ1c2ViRjBJ?=
 =?utf-8?B?b296TlZLUFJVeHF1QnViQXJjV05VSVBWWnpybzdvdDdGczVmNlVXQmwzeG5G?=
 =?utf-8?Q?VHx0+8ICPW1aA01j0ewS6bY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a2b6d76-fa33-41a0-7907-08d9b4a3d722
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:23:23.3354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IsxczpBU/wO6mFH5W/59l+vyl3foVd38qYI9Xq06CZ1Cwdx4hpNTH99ePWisYsVanYuHjXhiuPguQenCN+ujug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3390

On 26.11.2021 22:22, Andrew Cooper wrote:
> Microcode loading is not a fastpath, but there are control flow security
> benefits from using altcall()'s hardening side effect.
> 
> Convert the existing microcode_ops pointer into a __read_mostly structure, and
> move {amd,intel}_ucode_ops into __initdata_cf_clobber.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Again subject to the resolution of the const aspect and perhaps
with __read_mostly converted to __ro_after_init (assuming its
introduction goes in first)
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:30:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:30:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235663.408787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msL01-0004Ta-MB; Wed, 01 Dec 2021 08:29:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235663.408787; Wed, 01 Dec 2021 08:29:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msL01-0004TT-JF; Wed, 01 Dec 2021 08:29:57 +0000
Received: by outflank-mailman (input) for mailman id 235663;
 Wed, 01 Dec 2021 08:29:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msL00-0004TJ-Lc; Wed, 01 Dec 2021 08:29:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msL00-0007dG-CX; Wed, 01 Dec 2021 08:29:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msL00-0005LP-2Y; Wed, 01 Dec 2021 08:29:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msL00-0001on-1z; Wed, 01 Dec 2021 08:29:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xjzMo4u2cXPBDU9ezLfysIPyNcXJFLP0/wdPxXk5sjA=; b=Mowvwgj1BWC0hOTQqkLf2Ewnla
	jQHeX5itGAx7vtBrjU+FrHN8d/vyKe8OXIntaqFDcSuHWUbOGKWJXA1vKUqWXl6zzskh4KxrSiNj4
	fm3aAG3uIs1dQhgmPuaVrrFt9UHgx3GdpLXm9rXVNkriZ+THC66k+Am78yVdS6MDK4/k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166963-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 166963: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:regression
    linux-linus:test-amd64-amd64-pygrub:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    linux-linus:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f080815fdb3e3cff5a004ca83b3815ac17ef71b1
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 08:29:56 +0000

flight 166963 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166963/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail REGR. vs. 166942
 test-amd64-amd64-pygrub     21 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 166942

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd    17 guest-start/debian.repeat fail blocked in 166942
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                f080815fdb3e3cff5a004ca83b3815ac17ef71b1
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    3 days
Testing same since   166963  2021-11-30 20:54:02 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alex Williamson <alex.williamson@redhat.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Bean Huo <beanhuo@micron.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Darrick J. Wong <djwong@kernel.org>
  David Howells <dhowells@redhat.com>
  David Woodhouse <dwmw@amazon.co.uk>
  Douglas Gilbert <dgilbert@interlog.com>
  Fuad Tabba <tabba@google.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Joerg Roedel <jroedel@suse.de>
  Juergen Gross <jgross@suse.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lu Baolu <baolu.lu@linux.intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Piggin <npiggin@gmail.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Qian Cai <quic_qiancai@quicinc.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sean Christopherson <seanjc@google.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      fail    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3172 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:31:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:31:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235669.408802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msL1A-0005mu-3i; Wed, 01 Dec 2021 08:31:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235669.408802; Wed, 01 Dec 2021 08:31:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msL19-0005mn-VU; Wed, 01 Dec 2021 08:31:07 +0000
Received: by outflank-mailman (input) for mailman id 235669;
 Wed, 01 Dec 2021 08:31:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msL18-0005mb-67
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:31:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0633c628-5281-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 09:31:05 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2055.outbound.protection.outlook.com [104.47.9.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-VIb3C_EIPiSsYwvBa4_jCQ-1; Wed, 01 Dec 2021 09:31:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 08:31:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:31:02 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0018.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.21 via Frontend Transport; Wed, 1 Dec 2021 08:31:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0633c628-5281-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638347464;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6HmHY5dE76DUzj/x5lhUEGUhmeyoavbxIoxMRJL3dts=;
	b=eH9kKqw7jJKf1+iJvCCuuLFRKBhd/pisQ9SSndsntkz0DNbVNYJxYUGHkpLUbMll2k2vwM
	0QVlP5oY2xmgslWuZUrpvAPt0cjxzqkUR6wDw/ywggmiQpK+yfLKBW96TD5dSmX2/ZxPE8
	SaDvcBn4acvLFwiMeTtMH+Zl2cF+hoc=
X-MC-Unique: VIb3C_EIPiSsYwvBa4_jCQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XRpUowk1/BoJ3bqdx/w083Mv8CCg84VRfRXsTXkQfhUQehuqk9ZQiVjbXot7hLBoiM5ywir9d73qBYvUf8Ig+04WZ6ApFRBmqJCnTVpPke6mVwcHWPrUf3fvP0gOnuBVhyo3vtngFUOSVrGOPLRCejzv9QjytTdqS8DrJ3nH6FFNg8EJhX+WEztJvKZxEmh77NpzKx9OuOoKlmDgj1EVGK4qFmy5zfAjOfr5NZieys80PXczi6Rtk0MxlQBmftFjYFd50QSwiw+1GMkYhqFTaixwH/jOsLs8+4vwhoHOFvy+//ZbA6InOcFq2wpH7FoT5YKz39FNky+aHmsrG+zkTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NdjsxFx9RDSocv7m53yughdCPL2k95NBFvazzjrlZUc=;
 b=GaApeQOU1UHXDfUCSKzBGNZfmObhGxwymYzPw3cRVtZEM+QQuQ9gZxvXID3KyBIHrhM67ukcvFtafu+IljaHqkXJb6jSR8eoSxPj2Iskdl8DAz3gr750vyOSX47iQPjwCPb27yQsdWpbYmerTnVVCG4lkruj0F772L2havlJiirUtLNDenqQowwwuu31OGSsZSHw4QrSeipeO/kfIIw6PFlUDQ+p8Yn9ERKJwBV8GOOd6eqdnVSeJ+PWePrug4iEbJYlAN/K0s7Aumewhu688j1QloqwzKFUimFG+9tjq97PZXdSC0MHfA0D4fdglspf2/rcvxxLoPnNcNOMXgZf4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ded8ef9f-9435-1b5e-32a0-1b7e93b15a52@suse.com>
Date: Wed, 1 Dec 2021 09:31:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] x86/vPMU: invoke <vendor>_vpmu_initialise() through a
 hook as well
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <66e64fc5-34f1-7877-42b1-3533136f56ab@suse.com>
 <35e2dab8-e274-839c-23a8-25f4c121cd08@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <35e2dab8-e274-839c-23a8-25f4c121cd08@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0018.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3678e741-a3f6-430c-1b35-08d9b4a4e8ea
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039AC69F81487CCC9E02115B3689@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aucNVPeubcg1DxtrUBDZ4O3TRbpy/ebRGQWtKYyN3DEwFoKixVjhS6B3KPHaCJZvKKndqj21KN1lCtTRB8LahECcGk96eRoBBiiGn6JtPw8ITokJbdi4IllK8cDeblHhlYKXhu8lLqApBUD4HmVqkvGceiDleAfJk3t6hQxQTc9mRIKMjtKd0DT5yc+mXE6fVt4A/k/yXbg+ytXDNWJ64joEOvpjAojD9+vvQXRG9A3TMRK+fYTAWEc/eB4UwKoF0s/PSNvHkG3pqlW/+ZnL2OIyLbkZHlcLfjjyuAt3Pm6krz2531G2LsNtM3eHlhIXK1avRsc+hWuC0vUovKcc2SNduX6eOdgXC4b3g5rbBPcVNbQW6K7F0dgBJorS8q8ucFip9+JJvCjQl8XFoPugnhCajKP3+bXOxw4THNFlw5R8YcWDCPix+ShvZJM5p2UQgE0KW3JQp4Gd7wNS9kUi10y0M3I6+6Lx1f179Yn/CxtKXnShEZgH0vJfZoUdOROGqvcQSGqhfI6+ao8yAuK5S9ONL1B8LHJPNzPI4uFXopTusiPyjOieUpsuBtKpvKyzk5KQoELgmM65qi5jUm5/nphpPC3ZxQx5W6wdl0NJdZ3vhbyiAr5hmA+HR8WG8w+jrrhNwT6zGZau4g8UgQDSYDrH/Jyg5TQp33wffG/Rz89zEiTe03eSEpYbJcKz3b2asWZ7fUV/seLQEbedcikt4eSp9QrB+sjaqCUU4B+NnXdcRTT4FN4RnjbR0mgGfKVh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(6916009)(83380400001)(66476007)(5660300002)(956004)(4326008)(8676002)(36756003)(66556008)(6486002)(16576012)(86362001)(26005)(508600001)(31686004)(38100700002)(316002)(54906003)(66946007)(186003)(2906002)(2616005)(8936002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3pkxj37sTwhtWhg/KCqxtn/R3Clt8O7G+sN8f+IP63vAqLCw7CM+KLmjMv7f?=
 =?us-ascii?Q?TbqKuWsKDg0U+zjxuomrlPPZ4RpRolIA4f7GJtFRrYynpQmaM+YcB/NNqgnw?=
 =?us-ascii?Q?8ip/fYkAZ1ZuttvG6ljWCIzoB8EXqLVudrcrMHJrY4nn1j2u2yoXyUBxoSat?=
 =?us-ascii?Q?i1lHWPlm3oHA5POdtpYprh8ZlFtELsuC/ucTsYghnJ/OYQQFsG+D8QTlAEqe?=
 =?us-ascii?Q?2HnbpmaCv+HH6yzkmCTLeCRj+UMedW9JJn3/BpsksrGtcEd3GaQs97VcoNbr?=
 =?us-ascii?Q?3pZQgmQNC+nsQ0QxI+7iIIfXjoMPv7/9fxEQHHmXagKAaypPDkV5d1eehIIc?=
 =?us-ascii?Q?Qjh1CX3//mXxAzhXluqS1HvWZHGuikEXlxjani5xnwJ8KAckpPQ5sYWOacPu?=
 =?us-ascii?Q?JWdpjSQGalThfATvWRsSaVrvG+UnnX5GkTWWE2p4/4xfkKNhwiCnX4SfBHgT?=
 =?us-ascii?Q?9qBFGvoteRkw7kCe9ESiaQwfmdLQyxc66cQ1CfeNbL9J8MJPTeOnQ2OsdNtc?=
 =?us-ascii?Q?jujGCoodHg4MCfQTQ+4PoRQOregcCfTOdFk+iMQL4xpQ4EOGer7tsovVY0yX?=
 =?us-ascii?Q?3TS+cwHxgB+fm++cW2BG6k+v2OINv+VZKbKBnUJc220mtqvqJKhIIx/JdUDo?=
 =?us-ascii?Q?L+hJqSvc4HfHDeQhAUcIziRblCv1jq+6Y89+L2DADC8rANDQxAhWIz2HExYD?=
 =?us-ascii?Q?7CaCg4F/VnguYXjAgl5QvY9Im0SIHflAGl7aOP6MxFzrRzkOxWinmgNtE398?=
 =?us-ascii?Q?MGxtbJ++L0ZBH5hMhn2YU9BY53fpAQ94nXo03EzdguH1K7hDM7/WD00vZnzY?=
 =?us-ascii?Q?nWjJaL/FdGPlMnn2lesVRpxGV2HgdsCXTReoZ7BYoxQS0RtgLNoFgV4kThta?=
 =?us-ascii?Q?UXPdFK6btQsS0gb6V8+WJhN4xb14GphHetPDQS1uxZbPnRA9kJH6FFG9sYyi?=
 =?us-ascii?Q?HqkK8HPXIpvWcc/4ix7qjtv0/O9DjXXLJ4G9G+VK5OLpiL5KAeEGAWrerv1I?=
 =?us-ascii?Q?Z+aXahrUeRIDmKBmFORRrlK+V5NQxaSBkSQrkiVvPjiF3xl2yUR9SjpnGN5a?=
 =?us-ascii?Q?moSc58EiRLmjPVAqOKUod+p+AqBspXvXZK0cDOs26g3IE0Oz5q+qdZ2jpeVZ?=
 =?us-ascii?Q?lB2+MWsCLh78HX5K1CJvmRufvvxFZ37TDewvCGgdCv4gZqAVRgorqgk2M2Tu?=
 =?us-ascii?Q?AQYWfHUVmqcEncfcVSWjaJLNtWK4T2z9R6MyMYxaHylragOQfF/zB5mVDh1x?=
 =?us-ascii?Q?xNfv7QIOXYvYy4vqAD0ebn04aA3Y1ser2rgNn+G6JA/MU4f7t//MqmWBzMDg?=
 =?us-ascii?Q?xGQ2x7jEmUSHq57q+I8IjyI+GevjVowhSEEz+y5iLuEp7pVO+j/lXcXkaln4?=
 =?us-ascii?Q?mjzLs4nAvVjXCy8B4QU6IBNZcIzKKmkaBUBTND03iVRquniM69be1pREhPBh?=
 =?us-ascii?Q?uc23VsifFaLLZlAVtuY1VtDQMU4bJu/nHcqDmcEPof6QpP9AlRG7lwdD9pmS?=
 =?us-ascii?Q?It+KQpYTimCXmetKxVBUH1ViTu0viM87nI8SIl01HKGGl1zjWX1ZI5NGo3V9?=
 =?us-ascii?Q?PFBQAa4hIVNYczS7cDCrRdrY4wIKldWqkwOzQ+Dy5mL7jXzTtTpFJROJVSSw?=
 =?us-ascii?Q?yaIWlryAUhkewaWX8rUrO3I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3678e741-a3f6-430c-1b35-08d9b4a4e8ea
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:31:02.6707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w1oNDttBNK1dTRkO62Ku6h/BXqd4qMsy9c10gQlrvvlm1xF0C3KPDTuQrls7WrluQ4HUgkCSsPxFdnbUCQqWgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 30.11.2021 22:18, Andrew Cooper wrote:
> On 29/11/2021 09:10, Jan Beulich wrote:
>> --- a/xen/arch/x86/cpu/vpmu.c
>> +++ b/xen/arch/x86/cpu/vpmu.c
>> @@ -480,12 +470,17 @@ static int vpmu_arch_initialise(struct v
>>          return -EINVAL;
>>      }
>> =20
>> -    vpmu->hw_lapic_lvtpc =3D PMU_APIC_VECTOR | APIC_LVT_MASKED;
>> -
>> +    ret =3D alternative_call(vpmu_ops.initialise, v);
>>      if ( ret )
>> +    {
>>          printk(XENLOG_G_WARNING "VPMU: Initialization failed for %pv\n"=
, v);
>> +        return ret;
>> +    }
>> +
>> +    vpmu->hw_lapic_lvtpc =3D PMU_APIC_VECTOR | APIC_LVT_MASKED;
>> +    vpmu_set(vpmu, VPMU_INITIALIZED);
>=20
> It occurs to me that if, in previous patch, you do:
>=20
> =C2=A0=C2=A0=C2=A0 if ( ret )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printk(XENLOG_G_WARNING "VPMU:=
 Initialization failed for %pv\n", v);
> +=C2=A0=C2=A0=C2=A0 else
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vpmu_set(vpmu, VPMU_INITIALIZ=
ED);
>=20
> then you don't need to undo the adjustments in
> {svm,vmx}_vpmu_initialise() in this patch.

I actually had it that way first, until noticing it was wrong. It can
be done only here because it if only here where the XENPMU_MODE_OFF
checks move from the vendor functions into here.

> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, although
> preferably with the VPMU_INITIALIZED adjustment.

Thanks; as said, that adjustment can't be done in patch 1 just yet.
But I did add the missing trailing commas.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:40:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:40:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235677.408813 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLAB-0007RD-3j; Wed, 01 Dec 2021 08:40:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235677.408813; Wed, 01 Dec 2021 08:40:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLAA-0007R6-Vv; Wed, 01 Dec 2021 08:40:26 +0000
Received: by outflank-mailman (input) for mailman id 235677;
 Wed, 01 Dec 2021 08:40:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0lDA=QS=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1msLAA-0007R0-8u
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:40:26 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20603.outbound.protection.outlook.com
 [2a01:111:f400:7d00::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 53601f4f-5282-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 09:40:24 +0100 (CET)
Received: from DB6PR07CA0172.eurprd07.prod.outlook.com (2603:10a6:6:43::26) by
 VI1PR08MB4509.eurprd08.prod.outlook.com (2603:10a6:803:f2::11) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23; Wed, 1 Dec 2021 08:40:21 +0000
Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:43:cafe::1) by DB6PR07CA0172.outlook.office365.com
 (2603:10a6:6:43::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.9 via Frontend
 Transport; Wed, 1 Dec 2021 08:40:21 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Wed, 1 Dec 2021 08:40:21 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Wed, 01 Dec 2021 08:40:21 +0000
Received: from c9e023cf4a0a.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 66F62572-C50E-4554-BE19-21DF20A8B925.1; 
 Wed, 01 Dec 2021 08:40:09 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c9e023cf4a0a.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 01 Dec 2021 08:40:09 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3271.eurprd08.prod.outlook.com (2603:10a6:209:47::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 1 Dec
 2021 08:40:07 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:40:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53601f4f-5282-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wX4hGHg4Q/HE943kglFck1XuUUR0YZyCHmfbkFLWcms=;
 b=PSfVNfMuzRflZVWOg3FeVhCl1GWRMD4UVBiLnSxyVw8VC8aBYfX/EXh73o1PW4Ts9uojqkNvPskzMQTqqXqxevyEWT0XkPFhPExmLzc+2Or4NAOCq0suRs13O56C6tjrdmC7jta600XmsEbHQDoJPABMAaqNbXzho+syvDNwqwM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a1ced442fe261afc
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Yr0vUNpoPLgbl3PE6ZvyboDoCoZD1d6JrTwt/K2fTWMZmM8lXPf3h1qaNzEM9tVF68afpkfAtRM4jI60BvGspzbD1B1mLmth6oW9abyFzcU8YnxtkqOZv2S3vE9xgpuuTp0Cg+Au/0+M/6PCGA6Divg8mRcJyzf/mDtx6D/BGtsBXvn//XlsCb3vtR478B6CLHVUxXg7qPMOR5l8YX2suMW+RAP8m4TFAh4kCVWbwqODt9cJwfB0MVt9awxTghO1UDgZfDcn4JGJ+5SLZpOXo8Y61DR30v/Bbwa57a0NeYP5TVQkua8XY/oxR/IEN9VGOOhTO6siGvg/OJYfhy/vKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wX4hGHg4Q/HE943kglFck1XuUUR0YZyCHmfbkFLWcms=;
 b=oFQNGwr/OKHt9XKbRVsaeU91NKGgqRPEbTEsL8FSkU5x4Wjno53zhDUUb29ilZNWPFVolvByLTFF/R4OG4TFPDX5RIZRyChO1etMvW8sEj7bb/6wy+FmA8BECPysEODCQDPULRE8tu+cYe68mCEjLSHyVMgp6v6uH7R1qO6CMqkKJLk2nY8yZzIz9YhKcBWFtVtRZLqVm+SHifJRSPJPMWWR+WilzP079rWeViyQaRps4CAYKmhUUH4ByKYC1sM2ADvOWijyJ50zoOAtrNrxty9N4JoMuZpUOnqkweeTPL44nLaVVhvUBmbBWhhgsOexWAskjSHdssM+6s1mkm9wTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wX4hGHg4Q/HE943kglFck1XuUUR0YZyCHmfbkFLWcms=;
 b=PSfVNfMuzRflZVWOg3FeVhCl1GWRMD4UVBiLnSxyVw8VC8aBYfX/EXh73o1PW4Ts9uojqkNvPskzMQTqqXqxevyEWT0XkPFhPExmLzc+2Or4NAOCq0suRs13O56C6tjrdmC7jta600XmsEbHQDoJPABMAaqNbXzho+syvDNwqwM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "jbeulich@suse.com" <jbeulich@suse.com>, Ayan
 Kumar Halder <ayankuma@xilinx.com>, Andre Przywara <Andre.Przywara@arm.com>
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
Thread-Topic: [PATCH v2] bitops: Fix incorrect value in comment
Thread-Index: AQHX5hXspsh6iwLz8EufEuavNpo0T6wdUegA
Date: Wed, 1 Dec 2021 08:40:07 +0000
Message-ID: <03B8C4BA-A11A-4CC3-BE61-A0CEE9F5B302@arm.com>
References: <20211130181238.5501-1-ayankuma@xilinx.com>
In-Reply-To: <20211130181238.5501-1-ayankuma@xilinx.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: f5452b4d-c3ce-4069-2a21-08d9b4a635ef
x-ms-traffictypediagnostic: AM6PR08MB3271:|VI1PR08MB4509:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB4509D94A29393D6C3C9B462F9D689@VI1PR08MB4509.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:1002;OLM:1002;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 mG9LT4TgnbUZoGnHIRCBcrUmGHPPBfwhd3v4MzNo1p9TfAzrtkRElXUg4NLhR7ZrsEFqdTLMnO0JA7H/NDdfAvmn0rw5aRw+rf1Vt6+sckd4ZXo6fuQFwMR5IwW0LunD7P3GUoNiK8Z92pSwjkOxQELgZpCvNc1kKhSIxCXzWt35Cj/oGUFrSHYsvqXYiUwnwjzxxMbsOoC6PiCyeAHITYDejtVVn9P6l6M9QEggrR8P/oqh6T5wN/9vPKVet7SWOvoTEDSi55Ey4fE6LK/w9DdaLMvlH5gcaHip+rFIqmDEotlkIfg4hn+qV82t2hIUySx8GyCAmo/6rtL6xZi7OZyYTsvAPiE5NtMHCgMym4AgA9bEna1nR5+MTlK3VnP4ymHmBIpL1r4yQQCj7HI1hMp5GTOjvduyeW/Kgq0jS/X1KfYr+YzanPXSayT79E/fzNgkR3040rdy/G9rxOJVh1cSDKbY6PJ/+KqOAYYm33P/2I+BMTHMkLGDOj4uHdtjgr51nK0pxfijUQlxX9PQlN3clxi+PxWp1RBGk9ozuGgRcN+wnA3NOenrxy9s7wl/GMW77l91e7eBlMrnUgHSlUTijqXm7SeXuWayfrGydsHNvf/3frM/KrIkSsVfRQX7qHlZcfRcu8Sa0QXT1250F68O6d+qKU5qorcdbsk1VYnbihHNmQhh90nbhppKbBd/BMqPpgik8U8L2rIhtj22xVWjiYM0jtBq0+Qu7Dy4WjQ=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(76116006)(33656002)(64756008)(6916009)(2616005)(38100700002)(38070700005)(316002)(66476007)(66946007)(66446008)(83380400001)(6486002)(4326008)(6512007)(122000001)(508600001)(91956017)(2906002)(71200400001)(8936002)(54906003)(186003)(86362001)(53546011)(8676002)(36756003)(5660300002)(6506007)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C3E1EFEA95C6204197843255430E41D7@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3271
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f30894eb-71e2-4da9-14ca-08d9b4a62db6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NJLLz100L4LGr4Hk4IMzvO5lSxkPx4Y+0coNQTh2SOY5AYxRkH+zEpttXfgNCiVRxJrLu5VAmEcGwZyHnOzwpsFWX6PTYS0v0EazZaYUPeNGSxiAWul1LlSV4S0W0+7S9PUdcO+9ZWGLsEBoz9GByOwKesc5mj0V91wtgblBqCY6qg6NsVducB2K6Lbh49ZwQeLr2QU8XJR8gOaA4b3enxVmUgmA+uOE4xv7kb0yuKCymXpuxKgT+U9LF38p4tpt1Hp42zXpIMvsnZoGDT3224Qt/ki0WgGrmLZAgnoO4xkNnNfAsmM90zV9PBdaShTJvWIh2rSU5tq7bwA1TbVw9PGPdEFRnfUehei8MyHfeH5fY1yVWFOCsZpUu5viW6AuQ9nmhN0Tjhjl7zLLcYNeaN7YN1UYuOgpESdCag+QfDTGHXdOuM4vbhhZ4BFlSb9pCl8GTW0fSBmDe08HRTQiQ4sIaYf12Y4bRUh3jiCqXddW5REmp9yzezSkc+3IN3LBU5l9ZxkgRdU5zF0l/UakocMIuW/uk6hav9AeBgJKG1jUTtW0joBpQ5R0egJKlowtLQ0zEKisdqDASdRYQmQexiQA4jrwsSWaO3zBuKrXOh4gruPCMQTk5+4w5tvXVW8AxRQjX2xLA3mZBHDaY03iTs7j2qznJN+Khh+mfJb0SFoeO+I6UFyNPXrLG8dheLIblzXW6MGw6kIuSVoKmoX/Sw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8676002)(81166007)(26005)(6512007)(508600001)(82310400004)(2906002)(8936002)(2616005)(5660300002)(36756003)(54906003)(316002)(36860700001)(33656002)(6506007)(86362001)(53546011)(70586007)(4326008)(6862004)(6486002)(186003)(83380400001)(336012)(356005)(47076005)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:40:21.1988
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f5452b4d-c3ce-4069-2a21-08d9b4a635ef
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4509

Hi Ayan,

> On 30 Nov 2021, at 18:12, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com=
> wrote:
>=20
> GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
> in bitops.h.
>=20
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changelog :-
> v2 :- 1. Replaced the word "vector" with "value" in comment.
> 2. Changed 0x07fe00000 to 0x7fe00000.
> 3. Updated the commit message to make it meaningful.
> (All suggested by Jan Beulich)
>=20
> xen/include/xen/bitops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
> index a64595f68e..dad4b5aa1e 100644
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -5,7 +5,7 @@
> /*
>  * Create a contiguous bitmask starting at bit position @l and ending at
>  * position @h. For example
> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
>  */
> #define GENMASK(h, l) \
>     (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
> --=20
> 2.17.1
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 08:41:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 08:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235681.408823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLBH-0007zY-D1; Wed, 01 Dec 2021 08:41:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235681.408823; Wed, 01 Dec 2021 08:41:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLBH-0007zR-9z; Wed, 01 Dec 2021 08:41:35 +0000
Received: by outflank-mailman (input) for mailman id 235681;
 Wed, 01 Dec 2021 08:41:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0lDA=QS=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1msLBF-0007zJ-V1
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 08:41:34 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061c.outbound.protection.outlook.com
 [2a01:111:f400:7d00::61c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c31f953-5282-11ec-b941-1df2895da90e;
 Wed, 01 Dec 2021 09:41:33 +0100 (CET)
Received: from AM6P195CA0053.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::30)
 by AM0PR08MB4401.eurprd08.prod.outlook.com (2603:10a6:208:13a::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19; Wed, 1 Dec
 2021 08:41:23 +0000
Received: from AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:87:cafe::9b) by AM6P195CA0053.outlook.office365.com
 (2603:10a6:209:87::30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 08:41:23 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT042.mail.protection.outlook.com (10.152.17.168) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Wed, 1 Dec 2021 08:41:22 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Wed, 01 Dec 2021 08:41:22 +0000
Received: from e1e4cf4f09ac.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 4151F1C1-39F7-4FC9-8EFC-9B939B157397.1; 
 Wed, 01 Dec 2021 08:41:16 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e1e4cf4f09ac.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 01 Dec 2021 08:41:16 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3271.eurprd08.prod.outlook.com (2603:10a6:209:47::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 1 Dec
 2021 08:41:14 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 08:41:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c31f953-5282-11ec-b941-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WzL2NvUt9k+JDC65EJAEODL82IaW3NT02Qi3+5V7GN4=;
 b=y9VfREJmetMTTD+uro4kW8Bn9Qb+mqAc0BWrBmcWuL6VI+uLhK7CUoCfe/fjMhweQwyh6owDKEXvQugxlEUuWBmgblamSW9zeQEGZwUKvKxy4gpc8jR2BabCYzmWlvbT0KOOYUKSKFJDbZ+r50vqdtGWgHlxI0dJDoh9QjYB7SM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 5a0b28dc3bd97743
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CUQzSC54cO6zYCitOnPFcQdXdl5gpZjhxGKacK0EgzoMJou9KtEYBY4w3HSiTk6bO1IV+tCswyd7HmJU1yw+GvfTGnSlYbfOFhhIveTlMZMVIax9q+k21QeydjpsGjCy8wq5ntlaOXjnxk5ZGzcSLeheKIDIbQgKT5T60gRgTH8j/KddK0eN9eDQUcB7U6vahhspBsJRpSepeh+uUVptZqKZOYRvqgMzjb8/I54JlAbCq6ncjM5pVhpy78LkaDrc+ZCkcafxDOQNVRqTcstvZhihvSkgBMd20PZwd8OWxmrHpS7VLFByuwr00cSIZ/EM11OQrx9gsXtQYlEeyAsk8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WzL2NvUt9k+JDC65EJAEODL82IaW3NT02Qi3+5V7GN4=;
 b=LXe9JiihsF3uEODS83/nngAfLf9SX/qEnbgGBgEtq2WLpfAILEoYcD62jgCQFXmXsVKhQyL3vCrJnszC1HZ+UvfZ5mFLh7G2HFOUhJaxLY7kDUkqMxg53wZ6cMN4w/HupEMl+Q3zgN5JkjH67SUwPg31JUwkTuhKvQrSQERuEZjUeBpSizm9IXTMu/66mqnBid2AUAPxhvVxLWPlK0aL8gqTsmKK4eueCJ7LJSEtRjWIkPAdWSiTjIuXyyDqPlO41uNpzCR6pjy4pDD4IJT8Dxkg+RqLxVAG27viDJiLeZVArpVDYOx5VG3adiENzjSLJjslE8N0uadCABly6M+gMA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WzL2NvUt9k+JDC65EJAEODL82IaW3NT02Qi3+5V7GN4=;
 b=y9VfREJmetMTTD+uro4kW8Bn9Qb+mqAc0BWrBmcWuL6VI+uLhK7CUoCfe/fjMhweQwyh6owDKEXvQugxlEUuWBmgblamSW9zeQEGZwUKvKxy4gpc8jR2BabCYzmWlvbT0KOOYUKSKFJDbZ+r50vqdtGWgHlxI0dJDoh9QjYB7SM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: Andre Przywara <Andre.Przywara@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
	"julien@xen.org" <julien@xen.org>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Thread-Topic: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Thread-Index: AQHX5VWsSCHTVSwSL0mlImNjOX5laawb1JAAgACdioCAAOGfgA==
Date: Wed, 1 Dec 2021 08:41:13 +0000
Message-ID: <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
 <20211130094950.1bf368d6@donnerap.cambridge.arm.com>
 <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
In-Reply-To: <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: df44b550-71b9-42f0-547a-08d9b4a65abb
x-ms-traffictypediagnostic: AM6PR08MB3271:|AM0PR08MB4401:
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB4401416E574FEE8E5C29D44E9D689@AM0PR08MB4401.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 6HI/gyMEpTUKSdcCwO5mFEKos53VLHfV0Uz00UOUHSgEIIwExbD17cKJYpuSSTjt+BHjqQ40XytBE2QxZflk4wXqX1JkVTalMjKYGQILgwSRdcWFe7Zay5lwOYGOA3yzYQDZNZtazInOA6csnzssxcieuyHEX69//628o3OmLrUkQNZc5Rf1hHRubVnJRqSOEBNy7GIvSZkO0XzgupBx1WdCfDBRjhTEzMcJ/AwhDAebZuvSo8DTiQCaqtlvj+2osWdGtiQUbWkV+v7Rhnn3NXHQZc30P7gpSUCkTbJlc7oO1cMzRWRP7U3bG84fg9biP+UWnTX0GIkghHbYlyt7Wp9gfJuItLzbdl/LhIRjVkUY+hyJy7UrQwebDzjPAp2Nu2I81JbFIxvKevODtX9JL8T5L3E/GS9BSL3cuPP55XwOJvvc33CyDYJ6X3JYfu1u7ThFIxICAJIHQ+f4KGDLg+5EugCp/RsTXlD1Ex2kIOg2HAf96fPTVh5EQBzuXMApGSiD3J908zcsP3ZHxbshkRjzR8qJQ8Dg2EIfpRNNcxrC0nqEulPvxu2MPghcFsEgAhQXSPrz1YbTCeY7M7vDuXmWZjCtcreOySwZDFG5QMZmsPB0Oj6gdLMyPfWf94GHYgLZlaUuimChF0cmUAE5jkdfe8SfF5Gj3uvzppAMiF39859+4nUKcHtUL/JINbzcewIkHEqAK39lqgB6VSBM+NzU1Tmlp3ge3qNSQaUB0gkg0zZgC4N7gXBPnwkoHDHV
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(76116006)(33656002)(64756008)(6916009)(2616005)(38100700002)(38070700005)(316002)(66476007)(66946007)(66446008)(83380400001)(6486002)(30864003)(4326008)(6512007)(122000001)(508600001)(91956017)(2906002)(71200400001)(8936002)(54906003)(186003)(86362001)(53546011)(8676002)(36756003)(5660300002)(6506007)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <84C9A906B641DA48B0C1BFF54EFA1ACA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3271
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	60644531-23f2-434b-2a9a-08d9b4a65575
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KXHtcxxhZwHXkTsoZbkfzZBYtkd2ZRpwvyl59y9jMbWkNmS1Z+aYoOO0A9weTbik8zYyTT5HuIlC0DNNKgkBTjiAH7lqe/JK3cjyNkHafocewXwU+JG1i4N3yuILyFV1ij9ZDBzqLB1aFHheoX8Nx49wFeir7DR4pe8ToiIgkpFk+ah6LqSEMnFCeBxfR+O3FEKbmuTZffKFqqV18/nt7zwuoY3cNga1ujLKM3q21B8F0LC1YCsuVNNZHiv466n+cy9wM6qWx/J8lOsiOA0YyK5L7uFOowMWQkjux+RC++3rjbLcfhMqCc4y7Ee8aE7lxxsC5DPHUrNklLOW1ko1UOypj4/OAgqWjIX3OfL4F/sCgUeN3JlA8pBaX9Qpn6HmmA6LtJBkK78ryobe3S2v7mI04i6L9gZefVMRSDPte+6fO4Sc5VrG2GSKKbMv6U+dsqh77BNwJ3h6HN8hFJm1ZbMCqLcc+WVGlX5bzcIl94VTRdqmgnHufeTzQqPOKRgeNShV8jO/3CkQwS0sJYiNqDsuz0oKHYgxwntNfSJX3O8lvGKak/B3aPCI9XEI4XUV1L8tbBQHV+LZubPApZ3ADxAkUHcr6upOiFZpxVZm/6FW4qmUy42sgYlVWwxBopI9uloBK3LYO1JGCwrClZEnSVnrcx2EZ+PZ1uEUONbyUc/qccHY5B7Y0UKSgP2MUcH47VDypbsDSvbxsV9l1ffWIA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(4326008)(2616005)(6506007)(30864003)(356005)(26005)(6862004)(107886003)(36860700001)(47076005)(53546011)(186003)(81166007)(83380400001)(6512007)(2906002)(82310400004)(5660300002)(54906003)(33656002)(36756003)(8676002)(70586007)(8936002)(70206006)(508600001)(6486002)(316002)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 08:41:22.8651
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: df44b550-71b9-42f0-547a-08d9b4a65abb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4401

SGkgQXlhbiwNCg0KPiBPbiAzMCBOb3YgMjAyMSwgYXQgMTk6MTMsIEF5YW4gS3VtYXIgSGFsZGVy
IDxheWFuLmt1bWFyLmhhbGRlckB4aWxpbnguY29tPiB3cm90ZToNCj4gDQo+IEhpIEFuZHJlLA0K
PiANCj4gVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzLiBUaGV5IGFyZSB1c2VmdWwuDQo+IA0KPiBP
biAzMC8xMS8yMDIxIDA5OjQ5LCBBbmRyZSBQcnp5d2FyYSB3cm90ZToNCj4+IE9uIE1vbiwgMjkg
Tm92IDIwMjEgMTk6MTY6MzggKzAwMDANCj4+IEF5YW4gS3VtYXIgSGFsZGVyIDxheWFuLmt1bWFy
LmhhbGRlckB4aWxpbnguY29tPiB3cm90ZToNCj4+IEhpLA0KPj4+IEF0IHRoZSBtb21lbnQsIFhl
biBpcyBvbmx5IGhhbmRsaW5nIGRhdGEgYWJvcnQgd2l0aCB2YWxpZCBzeW5kcm9tZSAoaS5lLg0K
Pj4+IElTVj0wKS4gVW5mb3J0dW5hdGVseSwgdGhpcyBkb2Vzbid0IGNvdmVyIGFsbCB0aGUgaW5z
dHJ1Y3Rpb25zIGEgZG9tYWluDQo+Pj4gY291bGQgdXNlIHRvIGFjY2VzcyBNTUlPIHJlZ2lvbnMu
DQo+Pj4gDQo+Pj4gRm9yIGluc3RhbmNlLCBYaWxpbnggYmFyZW1ldGFsIE9TIHdpbGwgdXNlOg0K
Pj4+IA0KPj4+ICAgICAgICAgdm9sYXRpbGUgdTMyICpMb2NhbEFkZHIgPSAodm9sYXRpbGUgdTMy
ICopQWRkcjsNCj4+PiAgICAgICAgICpMb2NhbEFkZHIgPSBWYWx1ZTsNCj4+PiANCj4+PiBUaGlz
IGxlYXZlIHRoZSBjb21waWxlciB0byBkZWNpZGUgd2hpY2ggc3RvcmUgaW5zdHJ1Y3Rpb25zIHRv
IHVzZS4NCj4+IEFzIG1lbnRpb25lZCBpbiB0aGUgb3RoZXIgZW1haWwsIHRoaXMgaXMgd3Jvbmcs
IGlmIHRoaXMgcG9pbnRzIHRvIE1NSU86DQo+PiBkb24ndCBsZXQgdGhlIGNvbXBpbGVyIGRvIE1N
SU8gYWNjZXNzZXMuIElmIGEgc3RhZ2UgMiBmYXVsdCBpc24ndCBpbg0KPj4gYW4gTU1JTyBhcmVh
LCB5b3Ugc2hvdWxkIG5vdCBzZWUgdHJhcHMgdGhhdCB5b3UgY2Fubm90IGhhbmRsZSBhbHJlYWR5
Lg0KPj4gU28gSSBkb24ndCB0aGluayBpdCdzIGEgZ29vZCBpZGVhIHRvIHVzZSB0aGF0IGFzIGFu
IGV4YW1wbGUuIEFuZCBzaW5jZQ0KPj4gdGhpcyBwYXRjaCBvbmx5IHNlZW1zIHRvIGFkZHJlc3Mg
dGhpcyB1c2UgY2FzZSwgSSB3b3VsZCBkb3VidCBpdHMNCj4+IHVzZWZ1bG5lc3MgaW4gZ2VuZXJh
bC4NCj4gWWVzLCBJIHNob3VsZCBoYXZlIGZpeGVkIHRoZSBjb21tZW50Lg0KPiANCj4gQ3VycmVu
dGx5LCBJIGFtIHRlc3Rpbmcgd2l0aCBiYXJlbWV0YWwgYXBwIHdoaWNoIHVzZXMgaW5saW5lIGFz
c2VtYmx5IGNvZGUgd2l0aCBwb3N0IGluZGV4aW5nIGluc3RydWN0aW9ucywgdG8gYWNjZXNzIHRo
ZSBNTUlPLg0KPiANCj4gQVRNLCBJIGFtIHRlc3Rpbmcgd2l0aCAzMiBiaXQgTU1JTyBvbmx5Lg0K
PiANCj4gT24gdGhlIHVzZWZ1bG5lc3MsIEkgYW0ga2luZCBvZiB0b3JuIGFzIGl0IGlzIGxlZ2l0
aW1hdGUgZm9yIHBvc3QgaW5kZXhpbmcgaW5zdHJ1Y3Rpb25zIHRvIGJlIHVzZWQgaW4gYW4gaW5s
aW5lLWFzc2VtYmx5IGNvZGUgZm9yIGFjY2Vzc2luZyBNTUlPLiBIb3dldmVyLCB0aGF0IG1heSBu
b3QgYmUgc29tZXRoaW5nIGNvbW1vbmx5IHNlZW4uDQo+IA0KPiBAU3RlZmFuby9CZXJ0cmFuZC9K
dWxpZW4vVm9sb2R5bXlyIDotIEFzIHlvdSBhcmUgdGhlIEFybSBtYW50YWluZXJzLCBjYW4geW91
IGNvbW1lbnQgaWYgd2Ugc2hvdWxkIGhhdmUgZGVjb2RpbmcgbG9naWMgb3Igbm90ID8NCg0KQW5k
cmUgZ2F2ZSB5b3UgdGhlIG9mZmljaWFsIHN0YXRlbWVudCBmcm9tIEFybSBhbmQgdGhlcmUgaXMg
bm90aGluZyBtb3JlIEkgY2FuIHNheS4NCkkgd2lsbCBsZWF2ZSB0aGlzIGRlY2lzaW9uIHRvIFN0
ZWZhbm8gYW5kIEp1bGllbi4NCg0KUmVnYXJkcw0KQmVydHJhbmQNCg0KPiANCj4+PiBUaGlzDQo+
Pj4gbWF5IGJlIGEgcG9zdC1pbmRleCBzdG9yZSBpbnN0cnVjdGlvbiB3aGVyZSB0aGUgSFcgd2ls
bCBub3QgcHJvdmlkZSBhDQo+Pj4gdmFsaWQgc3luZHJvbWUuDQo+Pj4gDQo+Pj4gSW4gb3JkZXIg
dG8gaGFuZGxlIHBvc3QtaW5kZXhpbmcgc3RvcmUvbG9hZCBpbnN0cnVjdGlvbnMsIFhlbiB3aWxs
IG5lZWQNCj4+PiB0byBmZXRjaCBhbmQgZGVjb2RlIHRoZSBpbnN0cnVjdGlvbi4NCj4+PiANCj4+
PiBUaGlzIHBhdGNoIG9ubHkgY292ZXIgcG9zdC1pbmRleCBzdG9yZS9sb2FkIGluc3RydWN0aW9u
cyBmcm9tIEFBcmNoNjQNCj4+PiBtb2RlLiBGb3Igbm93LCB0aGlzIGlzIGxlZnQgdW5pbXBsZW1l
bnRlZCBmb3IgdHJhcCBmcm9tIEFBcmNoMzIgbW9kZS4NCj4+PiANCj4+PiBTaWduZWQtb2ZmLWJ5
OiBBeWFuIEt1bWFyIEhhbGRlciA8YXlhbmt1bWFAeGlsaW54LmNvbT4NCj4+PiAtLS0NCj4+PiAN
Cj4+PiBDaGFuZ2Vsb2cgOi0NCj4+PiANCj4+PiB2MiA6LSAxLiBVcGRhdGVkIHRoZSBybiByZWdp
c3RlciBhZnRlciByZWFkaW5nIGZyb20gaXQuIChQb2ludGVkIGJ5DQo+Pj4gSnVsaWVuLCBTdGVm
YW5vKQ0KPj4+IDIuIFVzZWQgYSB1bmlvbiB0byByZXByZXNlbnQgdGhlIGluc3RydWN0aW9uIG9w
Y29kZSAoU3VnZ2VzdGQgYnkNCj4+PiBCZXJ0cmFuZCkgMy4gRml4ZWQgY29kaW5nIHN0eWxlIGlz
c3VlcyAoUG9pbnRlZCBieSBKdWxpZW4pDQo+Pj4gNC4gSW4gdGhlIHByZXZpb3VzIHBhdGNoLCBJ
IHdhcyB1cGRhdGluZyBkYWJ0LT5zaWduIGJhc2VkIG9uIHRoZQ0KPj4+IHNpZ25lZG5lc3Mgb2Yg
aW1tOS4gVGhpcyB3YXMgaW5jb3JyZWN0LiBBcyBtZW50aW9uZWQgaW4gQVJNdjggQVJNICBEREkN
Cj4+PiAwNDg3Ry5iLCBQYWdlIDMyMjEsIFNTRSBpbmRpY2F0ZXMgdGhlIHNpZ25lZG5lc3Mgb2Yg
dGhlIGRhdGEgaXRlbQ0KPj4+IGxvYWRlZC4gSW4gb3VyIGNhc2UsIHRoZSBkYXRhIGl0ZW0gbG9h
ZGVkIGlzIGFsd2F5cyB1bnNpZ25lZC4NCj4+PiANCj4+PiBUaGlzIGhhcyBiZWVuIHRlc3RlZCBm
b3IgdGhlIGZvbGxvd2luZyBjYXNlcyA6LQ0KPj4+IGxkciB4MiwgW3gxXSwgIzQNCj4+IEFzIEph
biBhbHJlYWR5IG1lbnRpb25lZDogdGhpcyBpcyBhIGJhZCBleGFtcGxlLiBGaXJzdCwgdGhpcyBp
cyBhIDY0LWJpdA0KPj4gYWNjZXNzLCB3aGljaCB5b3UgZG9uJ3QgZW11bGF0ZSBiZWxvdy4gQW5k
IHNlY29uZCwgeW91IHdhbnQgdG8ga2VlcCB0aGUNCj4+IHBvaW50ZXIgYWxpZ25lZC4gVW5hbGln
bmVkIGFjY2Vzc2VzIHRvIGRldmljZSBtZW1vcnkgYWx3YXlzIHRyYXAsIGFzIHBlcg0KPj4gdGhl
IGFyY2hpdGVjdHVyZSwgZXZlbiBvbiBiYXJlIG1ldGFsLg0KPj4+IA0KPj4+IGxkciB3MiwgW3gx
XSwgIy00DQo+Pj4gDQo+Pj4gc3RyIHgyLCBbeDFdLCAjNA0KPj4gU2FtZSBhcyBhYm92ZS4NCj4+
PiBzdHIgdzIsIFt4MV0sICMtNA0KPj4+IA0KPj4+IFRoZSByZWFzb24gYmVpbmcgIEkgYW0gdGVz
dGluZyBvbiAzMmJpdCBNTUlPIHJlZ2lzdGVycyBvbmx5LiBJIGRvbid0IHNlZQ0KPj4+IGEgOGJp
dCBvciAxNmJpdCBNTUlPIHJlZ2lzdGVyLg0KPj4gV2hlcmUgZGlkIHlvdSBsb29rPyBUaGVyZSBh
cmUgcGxlbnR5IG9mIGV4YW1wbGVzIG91dCB0aGVyZSwgZXZlbiB0aGUgR0lDDQo+PiBhbGxvd3Mg
OC1iaXQgYWNjZXNzZXMgdG8gY2VydGFpbiByZWdpc3RlcnMgKGdyZXAgZm9yICJWR0lDX0FDQ0VT
U18iKSwgYW5kDQo+PiB0aGUgTGludXggR0lDIGRyaXZlciBpcyB1c2luZyB0aGVtIChidXQgd2l0
aCBwcm9wZXIgYWNjZXNzb3JzLCBvZiBjb3Vyc2UpLg0KPj4gQWxzbyBHSUN2MyBzdXBwb3J0cyA2
NC1iaXQgYWNjZXNzZXMgdG8gc29tZSByZWdpc3RlcnMuIFNvbWUgUEwwMTEgVUFSVHMgdXNlDQo+
PiAxNi1iaXQgTU1JTyBhY2Nlc3Nlcy4NCj4gWWVzLCBzb3JyeSBJIHNlZSB0aGVtIG5vdy4gR0lD
RF9JUFJJT1JJVFlSIGNhbiBiZSBhY2Nlc3NlZCB3aXRoIDggYml0cy4NCj4gVW5mb3J0dW5hdGVs
eSwgSSBoYXZlIEdJQy12MiBvbiBteSBoYXJkd2FyZSBzeXN0ZW0uIFNvLCBwcm9iYWJseSBJIGNh
bid0IHRlc3QgNjQgYml0IGFjY2Vzcy4NCj4gDQo+Pj4gIHhlbi9hcmNoL2FybS9kZWNvZGUuYyAg
ICAgfCA2OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4+PiAgeGVu
L2FyY2gvYXJtL2RlY29kZS5oICAgICB8ICAzICstDQo+Pj4gIHhlbi9hcmNoL2FybS9pby5jICAg
ICAgICAgfCA0MCArKysrKysrKysrKysrKysrKysrLS0tLQ0KPj4+ICB4ZW4vaW5jbHVkZS9hc20t
YXJtL2hzci5oIHwgMjYgKysrKysrKysrKysrKysrDQo+Pj4gIDQgZmlsZXMgY2hhbmdlZCwgMTI5
IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+Pj4gDQo+Pj4gZGlmZiAtLWdpdCBhL3hl
bi9hcmNoL2FybS9kZWNvZGUuYyBiL3hlbi9hcmNoL2FybS9kZWNvZGUuYw0KPj4+IGluZGV4IDc5
MmMyZTkyYTcuLjBiM2U4ZmNiYzYgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL2RlY29k
ZS5jDQo+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RlY29kZS5jDQo+Pj4gQEAgLTg0LDYgKzg0LDY2
IEBAIGJhZF90aHVtYjI6DQo+Pj4gICAgICByZXR1cm4gMTsNCj4+PiAgfQ0KPj4+ICArc3RhdGlj
IGludCBkZWNvZGVfMzJiaXRfbG9hZHN0b3JlX3Bvc3RpbmRleGluZyhyZWdpc3Rlcl90IHBjLA0K
Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVj
dCBoc3JfZGFidCAqZGFidCwNCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB1bmlvbiBsZHJfc3RyX2luc3RyX2NsYXNzICppbnN0cikNCj4+PiArew0K
Pj4+ICsgICAgaWYgKCByYXdfY29weV9mcm9tX2d1ZXN0KCZpbnN0ci0+dmFsdWUsICh2b2lkICog
X191c2VyKXBjLCBzaXplb2YgKGluc3RyKSkgKQ0KPj4+ICsgICAgICAgIHJldHVybiAtRUZBVUxU
Ow0KPj4+ICsNCj4+PiArICAgIC8qIEZpcnN0LCBsZXQncyBjaGVjayBmb3IgdGhlIGZpeGVkIHZh
bHVlcyAqLw0KPj4+ICsgICAgaWYgKCAhKChpbnN0ci0+Y29kZS5maXhlZDEgPT0gMSkgJiYgKGlu
c3RyLT5jb2RlLmZpeGVkMiA9PSAwKSAmJg0KPj4+ICsgICAgICAgICAoaW5zdHItPmNvZGUuZml4
ZWQzID09IDApICYmIChpbnN0ci0+Y29kZS5maXhlZDQgPT0gNykpICkNCj4+PiArICAgIHsNCj4+
PiArICAgICAgICBncHJpbnRrKFhFTkxPR19FUlIsICJEZWNvZGluZyBub3Qgc3VwcG9ydGVkIGZv
ciBpbnN0cnVjdGlvbnMgb3RoZXIgdGhhbiINCj4+PiArICAgICAgICAgICAgIiBsZHIvc3RyIHBv
c3QgaW5kZXhpbmdcbiIpOw0KPj4+ICsgICAgICAgIGdvdG8gYmFkXzMyYml0X2xvYWRzdG9yZTsN
Cj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBpZiAoIGluc3RyLT5jb2RlLnNpemUgIT0gMiAp
DQo+PiBJIGRvbid0IHNlZSBhIGdvb2QgcmVhc29uIGZvciB0aGlzIGxpbWl0YXRpb24uIElmIHlv
dSBhcmUgZ29pbmcgdG8gZGlzc2VjdA0KPj4gdGhlIGluc3RydWN0aW9uLCB3aHkgbm90IGp1c3Qg
c3VwcG9ydCBhdCBsZWFzdCBhbGwgYWNjZXNzIHdpZHRocywgc28NCj4+IDY0LWJpdHMsIGJ1dCBh
bHNvIHtsZHIsc3RyfXtiLHd9PyBJIHRoaW5rIHRoZSBmcmFtZXdvcmsgZG9lcyB0aGUgaGVhdnkN
Cj4+IGxpZnRpbmcgZm9yIHlvdSBhbHJlYWR5Pw0KPiANCj4gSSBzZWUgeW91ciBwb2ludC4gTXkg
aW50ZW50aW9uIHdhcyB0byB0ZXN0IGZpcnN0IHdpdGggdGhlIHJlc3RyaWN0ZWQgaW5zdHJ1Y3Rp
b24gc2V0IChpZSBsZHIvc3RyIC0gMzIgYml0IGFjY2VzcyB3aXRoIHBvc3QgaW5kZXhpbmcgb25s
eSkgYW5kIGdldCBhbiBvcGluaW9uIGZyb20gdGhlIGNvbW11bml0eS4gSWYgdGhlIHBhdGNoIGxv
b2tzIHNhbmUsIHRoZW4gdGhpcyBjYW4gYmUgZXh0ZW5kZWQgd2l0aCBvdGhlciB2YXJpYW50cyBh
cyB3ZWxsLg0KPiANCj4+IFNhbWUgZm9yIHRoZSByZXN0cmljdGlvbiB0byBwb3N0LWluZGV4IGFi
b3ZlLCBzdXBwb3J0aW5nIHByZS1pbmRleCBhcyB3ZWxsDQo+PiBzaG91bGQgYmUgZWFzeS4NCj4g
Rm9yIFByZS1pbmRleGluZyBpbnN0cnVjdGlvbiwgdGhlIElTUyBpcyB2YWxpZC4gU28gSSBhbSBu
b3Qgc3VyZSB3aGF0IGlzIHRvIGJlIGRvbmUgaGVyZT8NCj4gDQo+IEFGQUlVLCBpZiB0aGUgSVNT
IGlzIHZhbGlkLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV4cGxpY2l0bHkgZGVjb2RlIHRoZSBpbnN0
cnVjdGlvbnMuDQo+PiBUbyBtZSB0aGlzIGhhcyB0aGUgYml0dGVyIHRhc3RlIGZvciBiZWluZyBh
IG9uZSB0cmljayBwb255IHRvIHdvcmsgYXJvdW5kDQo+PiB5b3VyIHBhcnRpY3VsYXIgKGJyb2tl
biEpIHVzZSBjYXNlLg0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIGdwcmludGsoWEVOTE9HX0VS
UiwNCj4+PiArICAgICAgICAgICAgImxkci9zdHIgcG9zdCBpbmRleGluZyBpcyBzdXBwb3J0ZWQg
Zm9yIDMyIGJpdCB2YXJpYW50IG9ubHlcbiIpOw0KPj4+ICsgICAgICAgIGdvdG8gYmFkXzMyYml0
X2xvYWRzdG9yZTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICBpZiAoIGluc3RyLT5jb2Rl
LnYgIT0gMCApDQo+Pj4gKyAgICB7DQo+Pj4gKyAgICAgICAgZ3ByaW50ayhYRU5MT0dfRVJSLA0K
Pj4+ICsgICAgICAgICAgICAibGRyL3N0ciBwb3N0IGluZGV4aW5nIGZvciB2ZWN0b3IgdHlwZXMg
YXJlIG5vdCBzdXBwb3J0ZWRcbiIpOw0KPj4+ICsgICAgICAgIGdvdG8gYmFkXzMyYml0X2xvYWRz
dG9yZTsNCj4+PiArICAgIH0NCj4+PiArDQo+Pj4gKyAgICAvKiBDaGVjayBmb3IgU1RSIChpbW1l
ZGlhdGUpIC0gMzIgYml0IHZhcmlhbnQgKi8NCj4+PiArICAgIGlmICggaW5zdHItPmNvZGUub3Bj
ID09IDAgKQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIGRhYnQtPndyaXRlID0gMTsNCj4+PiAr
ICAgIH0NCj4+PiArICAgIC8qIENoZWNrIGZvciBMRFIgKGltbWVkaWF0ZSkgLSAzMiBiaXQgdmFy
aWFudCAqLw0KPj4+ICsgICAgZWxzZSBpZiAoIGluc3RyLT5jb2RlLm9wYyA9PSAxICkNCj4+PiAr
ICAgIHsNCj4+PiArICAgICAgICBkYWJ0LT53cml0ZSA9IDA7DQo+Pj4gKyAgICB9DQo+Pj4gKyAg
ICBlbHNlDQo+Pj4gKyAgICB7DQo+Pj4gKyAgICAgICAgZ3ByaW50ayhYRU5MT0dfRVJSLA0KPj4+
ICsgICAgICAgICAgICAiRGVjb2RpbmcgbGRyL3N0ciBwb3N0IGluZGV4aW5nIGlzIG5vdCBzdXBw
b3J0ZWQgZm9yIHRoaXMgdmFyaWFudFxuIik7DQo+Pj4gKyAgICAgICAgZ290byBiYWRfMzJiaXRf
bG9hZHN0b3JlOw0KPj4+ICsgICAgfQ0KPj4+ICsNCj4+PiArICAgIGdwcmludGsoWEVOTE9HX0lO
Rk8sDQo+Pj4gKyAgICAgICAgImluc3RyLT5jb2RlLnJ0ID0gMHgleCwgaW5zdHItPmNvZGUuc2l6
ZSA9IDB4JXgsIGluc3RyLT5jb2RlLmltbTkgPSAlZFxuIiwNCj4+PiArICAgICAgICBpbnN0ci0+
Y29kZS5ydCwgaW5zdHItPmNvZGUuc2l6ZSwgaW5zdHItPmNvZGUuaW1tOSk7DQo+Pj4gKw0KPj4+
ICsgICAgdXBkYXRlX2RhYnQoZGFidCwgaW5zdHItPmNvZGUucnQsIGluc3RyLT5jb2RlLnNpemUs
IGZhbHNlKTsNCj4+PiArICAgIGRhYnQtPnZhbGlkID0gMTsNCj4+PiArDQo+Pj4gKyAgICByZXR1
cm4gMDsNCj4+PiArYmFkXzMyYml0X2xvYWRzdG9yZToNCj4+PiArICAgIGdwcmludGsoWEVOTE9H
X0VSUiwgInVuaGFuZGxlZCAzMmJpdCBBcm0gaW5zdHJ1Y3Rpb24gMHgleFxuIiwgaW5zdHItPnZh
bHVlKTsNCj4+PiArICAgIHJldHVybiAxOw0KPj4+ICt9DQo+Pj4gKw0KPj4+ICBzdGF0aWMgaW50
IGRlY29kZV90aHVtYihyZWdpc3Rlcl90IHBjLCBzdHJ1Y3QgaHNyX2RhYnQgKmRhYnQpDQo+Pj4g
IHsNCj4+PiAgICAgIHVpbnQxNl90IGluc3RyOw0KPj4+IEBAIC0xNTAsMTEgKzIxMCwxNyBAQCBi
YWRfdGh1bWI6DQo+Pj4gICAgICByZXR1cm4gMTsNCj4+PiAgfQ0KPj4+ICAtaW50IGRlY29kZV9p
bnN0cnVjdGlvbihjb25zdCBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncywgc3RydWN0IGhzcl9k
YWJ0ICpkYWJ0KQ0KPj4+ICtpbnQgZGVjb2RlX2luc3RydWN0aW9uKGNvbnN0IHN0cnVjdCBjcHVf
dXNlcl9yZWdzICpyZWdzLCBzdHJ1Y3QgaHNyX2RhYnQgKmRhYnQsDQo+Pj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgdW5pb24gbGRyX3N0cl9pbnN0cl9jbGFzcyAqaW5zdHIpDQo+Pj4gIHsNCj4+
PiAgICAgIGlmICggaXNfMzJiaXRfZG9tYWluKGN1cnJlbnQtPmRvbWFpbikgJiYgcmVncy0+Y3Bz
ciAmIFBTUl9USFVNQiApDQo+Pj4gICAgICAgICAgcmV0dXJuIGRlY29kZV90aHVtYihyZWdzLT5w
YywgZGFidCk7DQo+Pj4gICsgICAgaWYgKCAoaXNfNjRiaXRfZG9tYWluKGN1cnJlbnQtPmRvbWFp
bikgJiYgIXBzcl9tb2RlX2lzXzMyYml0KHJlZ3MpKSApDQo+Pj4gKyAgICB7DQo+Pj4gKyAgICAg
ICAgcmV0dXJuIGRlY29kZV8zMmJpdF9sb2Fkc3RvcmVfcG9zdGluZGV4aW5nKHJlZ3MtPnBjLCBk
YWJ0LCBpbnN0cik7DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICAgICAgLyogVE9ETzogSGFuZGxl
IEFSTSBpbnN0cnVjdGlvbiAqLw0KPj4+ICAgICAgZ3ByaW50ayhYRU5MT0dfRVJSLCAidW5oYW5k
bGVkIEFSTSBpbnN0cnVjdGlvblxuIik7DQo+Pj4gIGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v
ZGVjb2RlLmggYi94ZW4vYXJjaC9hcm0vZGVjb2RlLmgNCj4+PiBpbmRleCA0NjEzNzYzYmRiLi5k
ODJmYzRhMGY2IDEwMDY0NA0KPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kZWNvZGUuaA0KPj4+ICsr
KyBiL3hlbi9hcmNoL2FybS9kZWNvZGUuaA0KPj4+IEBAIC0zNSw3ICszNSw4IEBADQo+Pj4gICAq
Lw0KPj4+ICAgIGludCBkZWNvZGVfaW5zdHJ1Y3Rpb24oY29uc3Qgc3RydWN0IGNwdV91c2VyX3Jl
Z3MgKnJlZ3MsDQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGhzcl9kYWJ0ICpk
YWJ0KTsNCj4+PiArICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgaHNyX2RhYnQgKmRhYnQs
DQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgdW5pb24gbGRyX3N0cl9pbnN0cl9jbGFzcyAq
aW5zdHIpOw0KPj4+ICAgICNlbmRpZiAvKiBfX0FSQ0hfQVJNX0RFQ09ERV9IXyAqLw0KPj4+ICBk
aWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2lvLmMgYi94ZW4vYXJjaC9hcm0vaW8uYw0KPj4+IGlu
ZGV4IDcyOTI4N2UzN2MuLjBkNjA3NTRiYzQgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJt
L2lvLmMNCj4+PiArKysgYi94ZW4vYXJjaC9hcm0vaW8uYw0KPj4+IEBAIC02NSw2ICs2NSwxNiBA
QCBzdGF0aWMgZW51bSBpb19zdGF0ZSBoYW5kbGVfd3JpdGUoY29uc3Qgc3RydWN0DQo+Pj4gbW1p
b19oYW5kbGVyICpoYW5kbGVyLCByZXR1cm4gcmV0ID8gSU9fSEFORExFRCA6IElPX0FCT1JUOw0K
Pj4+ICB9DQo+Pj4gICtzdGF0aWMgdm9pZCBwb3N0X2luY3JlbWVuZXRfcmVnaXN0ZXIodW5pb24g
bGRyX3N0cl9pbnN0cl9jbGFzcyAqaW5zdHIpDQo+Pj4gK3sNCj4+PiArICAgIHN0cnVjdCBjcHVf
dXNlcl9yZWdzICpyZWdzID0gZ3Vlc3RfY3B1X3VzZXJfcmVncygpOw0KPj4+ICsgICAgdW5zaWdu
ZWQgaW50IHZhbDsNCj4+PiArDQo+Pj4gKyAgICB2YWwgPSBnZXRfdXNlcl9yZWcocmVncywgaW5z
dHItPmNvZGUucm4pOw0KPj4+ICsgICAgdmFsICs9IGluc3RyLT5jb2RlLmltbTk7DQo+Pj4gKyAg
ICBzZXRfdXNlcl9yZWcocmVncywgaW5zdHItPmNvZGUucm4sIHZhbCk7DQo+Pj4gK30NCj4+PiAr
DQo+Pj4gIC8qIFRoaXMgZnVuY3Rpb24gYXNzdW1lcyB0aGF0IG1taW8gcmVnaW9ucyBhcmUgbm90
IG92ZXJsYXBwZWQgKi8NCj4+PiAgc3RhdGljIGludCBjbXBfbW1pb19oYW5kbGVyKGNvbnN0IHZv
aWQgKmtleSwgY29uc3Qgdm9pZCAqZWxlbSkNCj4+PiAgew0KPj4+IEBAIC0xMDYsMTQgKzExNiwy
NiBAQCBlbnVtIGlvX3N0YXRlIHRyeV9oYW5kbGVfbW1pbyhzdHJ1Y3QgY3B1X3VzZXJfcmVncw0K
Pj4+ICpyZWdzLCAuZ3BhID0gZ3BhLA0KPj4+ICAgICAgICAgIC5kYWJ0ID0gZGFidA0KPj4+ICAg
ICAgfTsNCj4+PiArICAgIGludCByYzsNCj4+PiArICAgIHVuaW9uIGxkcl9zdHJfaW5zdHJfY2xh
c3MgaW5zdHIgPSB7MH07DQo+Pj4gICAgICAgIEFTU0VSVChoc3IuZWMgPT0gSFNSX0VDX0RBVEFf
QUJPUlRfTE9XRVJfRUwpOw0KPj4+ICArICAgIC8qDQo+Pj4gKyAgICAgKiBBcm12OCBwcm9jZXNz
b3IgZG9lcyBub3QgcHJvdmlkZSBhIHZhbGlkIHN5bmRyb21lIGZvciBwb3N0LWluZGV4aW5nDQo+
Pj4gKyAgICAgKiBsZHIvc3RyIGluc3RydWN0aW9ucy4gU28gaW4gb3JkZXIgdG8gcHJvY2VzcyB0
aGVzZSBpbnN0cnVjdGlvbnMsDQo+Pj4gKyAgICAgKiBYZW4gbXVzdCBkZWNvZGUgdGhlbS4NCj4+
PiArICAgICAqLw0KPj4+ICsgICAgaWYgKCAhaW5mby5kYWJ0LnZhbGlkICkNCj4+PiArICAgIHsN
Cj4+PiArICAgICAgICByYyA9IGRlY29kZV9pbnN0cnVjdGlvbihyZWdzLCAmaW5mby5kYWJ0LCAm
aW5zdHIpOw0KPj4+ICsgICAgICAgIGlmICggcmMgKQ0KPj4+ICsgICAgICAgICAgICByZXR1cm4g
SU9fQUJPUlQ7DQo+Pj4gKyAgICB9DQo+Pj4gKw0KPj4+ICAgICAgaGFuZGxlciA9IGZpbmRfbW1p
b19oYW5kbGVyKHYtPmRvbWFpbiwgaW5mby5ncGEpOw0KPj4+ICAgICAgaWYgKCAhaGFuZGxlciAp
DQo+Pj4gICAgICB7DQo+Pj4gLSAgICAgICAgaW50IHJjOw0KPj4+IC0NCj4+PiAgICAgICAgICBy
YyA9IHRyeV9md2RfaW9zZXJ2KHJlZ3MsIHYsICZpbmZvKTsNCj4+PiAgICAgICAgICBpZiAoIHJj
ID09IElPX0hBTkRMRUQgKQ0KPj4+ICAgICAgICAgICAgICByZXR1cm4gaGFuZGxlX2lvc2Vydihy
ZWdzLCB2KTsNCj4+PiBAQCAtMTIyLDcgKzE0NCw3IEBAIGVudW0gaW9fc3RhdGUgdHJ5X2hhbmRs
ZV9tbWlvKHN0cnVjdCBjcHVfdXNlcl9yZWdzDQo+Pj4gKnJlZ3MsIH0NCj4+PiAgICAgICAgLyog
QWxsIHRoZSBpbnN0cnVjdGlvbnMgdXNlZCBvbiBlbXVsYXRlZCBNTUlPIHJlZ2lvbiBzaG91bGQg
YmUNCj4+PiB2YWxpZCAqLw0KPj4+IC0gICAgaWYgKCAhZGFidC52YWxpZCApDQo+Pj4gKyAgICBp
ZiAoICFpbmZvLmRhYnQudmFsaWQgKQ0KPj4+ICAgICAgICAgIHJldHVybiBJT19BQk9SVDsNCj4+
PiAgICAgICAgLyoNCj4+PiBAQCAtMTM0LDcgKzE1Niw3IEBAIGVudW0gaW9fc3RhdGUgdHJ5X2hh
bmRsZV9tbWlvKHN0cnVjdCBjcHVfdXNlcl9yZWdzDQo+Pj4gKnJlZ3MsIHsNCj4+PiAgICAgICAg
ICBpbnQgcmM7DQo+Pj4gIC0gICAgICAgIHJjID0gZGVjb2RlX2luc3RydWN0aW9uKHJlZ3MsICZp
bmZvLmRhYnQpOw0KPj4+ICsgICAgICAgIHJjID0gZGVjb2RlX2luc3RydWN0aW9uKHJlZ3MsICZp
bmZvLmRhYnQsIE5VTEwpOw0KPj4+ICAgICAgICAgIGlmICggcmMgKQ0KPj4+ICAgICAgICAgIHsN
Cj4+PiAgICAgICAgICAgICAgZ3ByaW50ayhYRU5MT0dfREVCVUcsICJVbmFibGUgdG8gZGVjb2Rl
IGluc3RydWN0aW9uXG4iKTsNCj4+PiBAQCAtMTQzLDkgKzE2NSwxNSBAQCBlbnVtIGlvX3N0YXRl
IHRyeV9oYW5kbGVfbW1pbyhzdHJ1Y3QgY3B1X3VzZXJfcmVncw0KPj4+ICpyZWdzLCB9DQo+Pj4g
ICAgICAgIGlmICggaW5mby5kYWJ0LndyaXRlICkNCj4+PiAtICAgICAgICByZXR1cm4gaGFuZGxl
X3dyaXRlKGhhbmRsZXIsIHYsICZpbmZvKTsNCj4+PiArICAgICAgICByYyA9IGhhbmRsZV93cml0
ZShoYW5kbGVyLCB2LCAmaW5mbyk7DQo+Pj4gICAgICBlbHNlDQo+Pj4gLSAgICAgICAgcmV0dXJu
IGhhbmRsZV9yZWFkKGhhbmRsZXIsIHYsICZpbmZvKTsNCj4+PiArICAgICAgICByYyA9IGhhbmRs
ZV9yZWFkKGhhbmRsZXIsIHYsICZpbmZvKTsNCj4+PiArDQo+Pj4gKyAgICBpZiAoIGluc3RyLnZh
bHVlICE9IDAgKQ0KPj4+ICsgICAgew0KPj4+ICsgICAgICAgIHBvc3RfaW5jcmVtZW5ldF9yZWdp
c3RlcigmaW5zdHIpOw0KPj4+ICsgICAgfQ0KPj4+ICsgICAgcmV0dXJuIHJjOw0KPj4+ICB9DQo+
Pj4gICAgdm9pZCByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoc3RydWN0IGRvbWFpbiAqZCwNCj4+PiBk
aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9oc3IuaCBiL3hlbi9pbmNsdWRlL2FzbS1h
cm0vaHNyLmgNCj4+PiBpbmRleCA5YjkxYjI4YzQ4Li43MmQ2N2QyODAxIDEwMDY0NA0KPj4+IC0t
LSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vaHNyLmgNCj4+PiArKysgYi94ZW4vaW5jbHVkZS9hc20t
YXJtL2hzci5oDQo+Pj4gQEAgLTE1LDYgKzE1LDMyIEBAIGVudW0gZGFidF9zaXplIHsNCj4+PiAg
ICAgIERBQlRfRE9VQkxFX1dPUkQgPSAzLA0KPj4+ICB9Ow0KPj4+ICArLyoNCj4+PiArICogUmVm
ZXIgdG8gdGhlIEFSTXY4IEFSTSAoRERJIDA0ODdHLmIpLCBTZWN0aW9uIEM0LjEuNCBMb2FkcyBh
bmQgU3RvcmVzDQo+Pj4gKyAqIFBhZ2UgMzE4IHNwZWNpZmllcyB0aGUgZm9sbG93aW5nIGJpdCBw
YXR0ZXJuIGZvcg0KPj4+ICsgKiAibG9hZC9zdG9yZSByZWdpc3RlciAoaW1tZWRpYXRlIHBvc3Qt
aW5kZXhlZCkiLg0KPj4+ICsgKg0KPj4+ICsgKiAzMSAzMCAyOSAgMjcgMjYgMjUgIDIzICAgMjEg
MjAgICAgICAgICAgICAgIDExICAgOSAgICAgICAgIDQgICAgICAgMA0KPj4+ICsgKiBfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fDQo+Pj4gKyAqIHxzaXplfDEgMSAxIHxWIHwwIDAgfG9wYyB8MCB8ICAgICAgaW1tOSAgICAg
fDAgMSB8ICBSbiAgICAgfCAgUnQgICB8DQo+Pj4gKyAqIHxfX19ffF9fX19fX3xfX3xfX19ffF9f
X198X198X19fX19fX19fX19fX19ffF9fX198X19fX19fX19ffF9fX19fX198DQo+Pj4gKyAqLw0K
Pj4+ICt1bmlvbiBsZHJfc3RyX2luc3RyX2NsYXNzIHsNCj4+PiArICAgIHVpbnQzMl90IHZhbHVl
Ow0KPj4+ICsgICAgc3RydWN0IGxkcl9zdHIgew0KPj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBy
dDo1OyAgICAgLyogUnQgcmVnaXN0ZXIgKi8NCj4+IEkgZG9uJ3QgdGhpbmsgaXQncyBhIHBhcnRp
Y3VsYXIgZ29vZCBpZGVhIHRvIHVzZSBhIGJpdC1maWVsZCBoZXJlLCBpZiB0aGF0DQo+PiBpcyBl
eHBlY3RlZCB0byBtaW1pYyBhIGNlcnRhaW4gaGFyZHdhcmUgcHJvdmlkZWQgYml0IHBhdHRlcm4u
DQo+PiBJdCB3b3JrcyBpbiBwcmFjdGlzZSAoVE0pLCBidXQgdGhlIEMgc3RhbmRhcmQgZG9lcyBu
b3QgZ3VhcmFudGVlIHRoZSBvcmRlcg0KPj4gdGhlIGJpdHMgYXJlIGFsbG9jYXRlZCAoSVNPL0lF
QyA5ODk5OjIwMXggwqc2LjcuMi4xLCBzdGFuemEgMTEpLg0KPj4gU2luY2UgeW91IGFyZSAqcmVh
ZGluZyogb25seSBmcm9tIHRoZSBpbnN0cnVjdGlvbiB3b3JkLCB5b3Ugc2hvdWxkIGdldCBhd2F5
DQo+PiB3aXRoIGFjY2Vzc29yIG1hY3JvcyB0byBleHRyYWN0IHRoZSBiaXRzIHlvdSBuZWVkLiBG
b3IgaW5zdGFuY2UgZm9yDQo+PiBmaWx0ZXJpbmcgdGhlIG9wY29kZSwgeW91IGNvdWxkIHVzZTog
KChpbnNuICYgMHgzZmUwMGMwMCkgPT0gMHgzODQwMDQwMCkNCj4gDQo+IFllcywgdGhpcyBpcyBh
IHZlcnkgZ29vZCBwb2ludC4gSSB3aWxsIHVzZSBiaXRtYXNrcyB0byBhY2Nlc3MgdGhlIGJpdHMg
ZnJvbSB0aGUgcmVnaXN0ZXIuDQo+IA0KPiBJIHNhdyB0aGUgc2FtZSBsb2dpYyAoaWUgdXNpbmcg
Yml0ZmllbGRzKSBpcyB1c2VkIGZvciBzb21lIG90aGVyIHJlZ2lzdGVycyBhcyB3ZWxsLiBGb3Ig
ZWcgaHNyX2RhYnQsIGhzcl9pYWJ0IGluIHhlbi9pbmNsdWRlL2FzbS1hcm0vaHNyLmguIE1heSBi
ZSB0aGF0IG5lZWRzIGZpeGluZyBhcyB3ZWxsIGZvciBzb21lIG90aGVyIHRpbWUuIDopDQo+IA0K
PiAtIEF5YW4NCj4+IENoZWVycywNCj4+IEFuZHJlDQo+Pj4gKyAgICAgICAgdW5zaWduZWQgaW50
IHJuOjU7ICAgICAvKiBSbiByZWdpc3RlciAqLw0KPj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBm
aXhlZDE6MjsgLyogdmFsdWUgPT0gMDFiICovDQo+Pj4gKyAgICAgICAgaW50IGltbTk6OTsgICAg
ICAgICAgICAvKiBpbW05ICovDQo+Pj4gKyAgICAgICAgdW5zaWduZWQgaW50IGZpeGVkMjoxOyAv
KiB2YWx1ZSA9PSAwYiAqLw0KPj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBvcGM6MjsgICAgLyog
b3BjICovDQo+Pj4gKyAgICAgICAgdW5zaWduZWQgaW50IGZpeGVkMzoyOyAvKiB2YWx1ZSA9PSAw
MGIgKi8NCj4+PiArICAgICAgICB1bnNpZ25lZCBpbnQgdjoxOyAgICAgIC8qIHZlY3RvciAqLw0K
Pj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBmaXhlZDQ6MzsgLyogdmFsdWUgPT0gMTExYiAqLw0K
Pj4+ICsgICAgICAgIHVuc2lnbmVkIGludCBzaXplOjI7ICAgLyogc2l6ZSAqLw0KPj4+ICsgICAg
fSBjb2RlOw0KPj4+ICt9Ow0KPj4+ICsNCj4+PiAgdW5pb24gaHNyIHsNCj4+PiAgICAgIHJlZ2lz
dGVyX3QgYml0czsNCj4+PiAgICAgIHN0cnVjdCB7DQoNCg==


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:07:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:07:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235695.408838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLZx-0002NF-L3; Wed, 01 Dec 2021 09:07:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235695.408838; Wed, 01 Dec 2021 09:07:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLZx-0002N8-Hc; Wed, 01 Dec 2021 09:07:05 +0000
Received: by outflank-mailman (input) for mailman id 235695;
 Wed, 01 Dec 2021 09:07:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msLZv-0002N2-Tm
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:07:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f08ccfc4-5285-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:06:43 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-2R6LeN07PM2j4GPiFr6NBg-1; Wed, 01 Dec 2021 10:06:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6863.eurprd04.prod.outlook.com (2603:10a6:803:12f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 09:06:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:06:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P189CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::10) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 09:06:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f08ccfc4-5285-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638349576;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JzykYq9yBJpib5T7M8qY600NqYi+0y6+g9wtRI87EyU=;
	b=QUzvG+qwbf0C8tEOZtJxJTXL243idDlRHnvefkIYq5odUSI/AW9zQdJtseEABk6wXWmjjz
	iOG0lAVTUNcMrR6QiKK0u25WXkPf7kfWzr5EB3sgZwkymKycEPHMMbtnV2G3S45tqPyNJe
	zI0n5lHZcNBAS21DTDh6vXy1NqdN8O4=
X-MC-Unique: 2R6LeN07PM2j4GPiFr6NBg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JLQQ1wdfhLEe/49ecejm4Uao8az4Ngfg4BzN6Szg8squE3DurmWlKn+t9PaoHqPwftS807NG4JB/jUU7nPHZUHOaTasmrKR5qbWXZbdYoTBEOb8oonRDznWOsmokZXzbRL640li0XS31M543HbA6itDnWRg7KZnAUcaE+pu+GHFq15+jRW98TPIHZfDKXjwzfOmUfhoE1BfcAS0xMyzyhF1ZYcb5gJLOxrcuCDuRcjhKBFOLXD1zIIdh1ESC3deMflnkCEPqkqwaQY56kifNcuyey8kSlCIKbU7+4rO+KXRAH07xVv3SKA/m/UlC6Wpwff1XhC5u+RZrpkwuojaNYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JzykYq9yBJpib5T7M8qY600NqYi+0y6+g9wtRI87EyU=;
 b=K6Zu3WFcm0Cab/P61rth1b2XEITVSgg6cXe0iG5QxVWZPonEboBNbaZ3UULODX2J7DWPC/vaF380pHyJHirDVEFUyrbtuv0QR2iI2HwGflReHR39CUJkBl5wGlGflfBdQV7KzSdcsPggBW9dEoyzxsFN2UKjH064F618L6F2iYwc1roQt3T20K5EzZzinR58SGAf/OyhZgnkC+QB2fDtf5aLV0KX3zGaG9HPimtslE7PN/R65vu/16tsDN57w+N3uUDXr7kaZSke4xKFiaCyt2O6AoB35tEBlsMm3Op0nyQKFyJuHVnXvQUpb7rMfAZstUsOgBGNmYWcAKlDORT40Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0f27ddcc-5486-fd2f-ac58-98ca713d4fd6@suse.com>
Date: Wed, 1 Dec 2021 10:06:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] x86/hvm: Simplify hvm_enable_msr_interception()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130181139.14398-1-andrew.cooper3@citrix.com>
 <20211130181139.14398-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130181139.14398-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0001.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c88a9ea-10b5-4653-fd67-08d9b4a9d2e3
X-MS-TrafficTypeDiagnostic: VI1PR04MB6863:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68639F52264A1C339E8DFCCFB3689@VI1PR04MB6863.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1247;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ottn17bDeXSu9L6q+Cpd28a8aENBhYGHucAb44uunAmk6Pq0IDC2dNLKFavn6S0UF7B1vjHAxZAJHojUZGxrL+tB1cC3X5XFr2h81wDFeEga9s+G3Jtbuqpc+UtuRa5k1Ws7AWVMp4+3os6Liig0C1FgHlkM/mPjA3NHzyl1V//XrqEEfZCUxBnOqhrbZ/6ZbjeXj32R9O3ublgMXgiJx7A4RAhwOMfIGVDfctY0FiWgClQ5dJpi13h/bndzzw5eABtvpfqDU7eTkkFdfR+W9bYgahchryp35xm8CXO6YnjkTBNoPj8il49ry1iCqASy+TB1JcfyYT1FIJR2d+Ur7fmd6NbBr5xF/RM/cbDvwb+jW8dr7IE3n/8Bn7Xe0C/B/Zg3XjRkAd5Chg6AjdNX5Nsw2ljX8NQjh+ck77z65fG3PQ0qQCJQ+aX5bVIhX/NtIBev1+he0RDHkf+A6pQaBrwdkuqzIQbAbyt2O1LQqpx1iUIaH/MoqTxDzB28O5R0NWHxoVNvc4EDRvT2sqG3VyJh5ifZs2Zs89Y9Es84jr694k8fn84AxoxxIAy3SCXcdXoAPAjIzL/2SRo9fKRGYwCMb8SMzk544o0+xdU1NM2GIDxyAwazeW+S1K+WbL6RGQDC5MbJO9I56MmOHImfcwYkYx/F/1ghISmkY0A7E8/nMkNCGUj4ot8jjYSK1WT4RwtXwkdeUkjxK2Du3nNHKzG3kNzb00Aodzn9hGl419fZGwxCP0y2KZf6NSJd6TPc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(6486002)(2906002)(8676002)(36756003)(38100700002)(956004)(508600001)(26005)(8936002)(2616005)(558084003)(54906003)(66556008)(5660300002)(6916009)(316002)(31696002)(66476007)(31686004)(4326008)(66946007)(16576012)(186003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0pLTkc2US9hUGswUGFTK2QvenhRbFRXU1p1Z3h2MlhJRVk2RHhPSUUvNXQr?=
 =?utf-8?B?ZDI0TzU1cmg0NFdXNjNWNDRXRCtzc1N0a0lESFhVV0VZWS9ucUhVWTZSRmdE?=
 =?utf-8?B?QWJjT3o1bkZrZUJTZ1c4cW9KSXdoSUVza3pxcHFNT1FnWWZXVVVPRnRHS0Vx?=
 =?utf-8?B?NmRYMERkYzA0NHJzSWJQZmFOUk8xeVd2MzF0YXJZdEp5Ymxpdm9SV2w2RStI?=
 =?utf-8?B?dUQ5dkJZZVRJMTU4bENqS3N1U2hOQUVob21VRDhZbDhsYXhKR2ZCZzIvQXJL?=
 =?utf-8?B?YnVqeGl1bjNxdGJMYkV2UmxyR1FubnpVUWVnM1FWTnp6L0NrN3NxcCtKZklL?=
 =?utf-8?B?Lzh3YlJqaCtnY0xVcUZHeVFETmZ0dUFzajU1R2tRNWF1TThsUW8rOW1veGNz?=
 =?utf-8?B?c3QrM3lFQnhXUXc0SnRqYVFVdE1ibTJMZUZncmZnYU9FS0RZVEZraC9tMHNI?=
 =?utf-8?B?OEJMaG00N2t6NVUzeUFuN0FrZnBVcVBsdWpCY0Ztak1aajA1US9oNERobC8v?=
 =?utf-8?B?bFdRekhidS9QVjFiM3lOcS9FTmRQS2R0aVd4eE9BN2dkR244K2xRcE5adFZh?=
 =?utf-8?B?Q2VIeTExN2wzdnczU3JicStpdG5kMkRTakhlaWt5UkJrVXhYM2xYUHRLWTZR?=
 =?utf-8?B?RlVGRjVkazZTNFNEMXpZemhZUUNXQ1VlRnNlcjlTOTd6QmhaWUJpd3UvYTY4?=
 =?utf-8?B?ZFFmb3hLL1hlTFAwYldFTGVNUDhoMG95QVR4VktGeUE5Mk1uWTR4ZEk5SWIw?=
 =?utf-8?B?UWwwUU5wQkNwa3VSRFdYbXZSbzJNOEdIYU1MdGZ0bFF1eWlTUFRZb2o4OGZD?=
 =?utf-8?B?d0Y1QUg3QTF6U3F3TUxyQ0ZOK3E1VFVqSTM1NzRHKzZCQkNkMjJQdkJUSUF2?=
 =?utf-8?B?T2s1VUZ1UlcvRzJvYVdWQkxMUVc3c1FBSVJIU1FVdG81d0pYUW1rZjdrdlpi?=
 =?utf-8?B?eXJXVS9uWWFNWDl0SFhtczU2UENYMzBIdTlGeWhMQ0ZPTm1aVENDd2JXUEFC?=
 =?utf-8?B?ZmtoK2ZTVHQvQmpMTmtBN0RSbWpwWGx6UXNTNFFHcUdTeXZkbU1pY3VOYy94?=
 =?utf-8?B?Mzc3K0htRFJXZC9XZHhhRDR2VDRPUWFHVXZZa0R4VThCN2Q4VEFIUUF5NkEr?=
 =?utf-8?B?c0dscGN6ZUZid0E0ek1ZdVlzTk93Z1hHc2dTSFNOVU0rMjBDMFdxYWlZWE5t?=
 =?utf-8?B?a3ZBQXpLcFdIWnlVTGMxREV0QmltMXZva3NuZWJ2WG5EUlZOQ0xiVm0zOHll?=
 =?utf-8?B?UlpnVVJXRFB0d1VZNVRyQmU2L29HOGFmdDljR2JZM0xyWG9ac1FCWXA4WEFU?=
 =?utf-8?B?RzJVMERuUFJYUFRlQ2dmdWRPL2lWUktzV3RwWDZ2eTZxeDRVZzJOajh1Nnhq?=
 =?utf-8?B?N0dCTm4rS1N1aE8rMVJRaXh3WjlxV2dTTUFDWFpNTHhrQVpkWHY0Zys5YTEy?=
 =?utf-8?B?Ym1sb0hQc0RIa3F6MUc1NUNIM0V4MTFRdnlxUVU2NFExWnRFQlh3S0tZd0dt?=
 =?utf-8?B?Z08wSGd6V2oxbUZsK0dFZGdDQ1JpMlBvenhGYVVETG80VThUd2NVNHlPYWNB?=
 =?utf-8?B?d1lLbysyQTVGTFRYeWRzQ0xlYUJ5YW1ybFgvNUpVSTJNamtNMDRMRnlTUUNx?=
 =?utf-8?B?ajU1NzErYXB1cGluRjV4c0ZFSmZlTTUrMm95U2Z2djJQcytmZVFjZk8yMnRs?=
 =?utf-8?B?R3pjbHhHV0FGYUsyUGt1d20wQVdsUFhJNTJRWndIcTc4cTJnT1c3cmZ1Z2VH?=
 =?utf-8?B?QVRLZmJHbjdkbnNvWTA3dWZLdHE0cldRZWZWMHIwS05zZkNlVlNOSzYrVmd0?=
 =?utf-8?B?MysvOXNDSTdKWk9IUDF1QWlWRU5IMzNRbzlHeE4xR294MGJzRys4ZjJUUjR4?=
 =?utf-8?B?dUJ0dVhudHhNbWZHcm01K2VVa1lMdkVWM3J4aCtmZEQyUHY0cThUNnpmODFa?=
 =?utf-8?B?Q210OUxsbCt1aHJuajZBeGhVZCsyMFFBVjIxRFZCc3gvRmI2Z3lZZENMbkRE?=
 =?utf-8?B?ZHdjWTdwYXhsTXM2YkhXNW5CRUI5MDBFbHpkTG5rcWpuWEJzY3JpdGEwWXFp?=
 =?utf-8?B?WXFndlBhanBUVkRYU0RKR3hBNGlya1VraU5kK3lsaVB4Z2s5cEZEZlhnWlda?=
 =?utf-8?B?dFJTQjlzWUluQVFFWVlNRjNoSzdmODdxZlcxQkVxUWZyemd5a1loamlHaXVr?=
 =?utf-8?Q?5RItt6iauhjO3Xm1W58tOc8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c88a9ea-10b5-4653-fd67-08d9b4a9d2e3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:06:13.2534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FVJkbMzf89VKHFi0LbW2QogaagND40ovwnmZ/oF3e2l2LgMpc1LzST8Ru27EnGJ3nJBtMIH2bgGkSE9BMraiyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6863

On 30.11.2021 19:11, Andrew Cooper wrote:
> The sole caller doesn't check the return value, and both vendors implement the
> hook.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:10:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:10:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235700.408848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLcu-0003i5-4D; Wed, 01 Dec 2021 09:10:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235700.408848; Wed, 01 Dec 2021 09:10:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLcu-0003hy-0s; Wed, 01 Dec 2021 09:10:08 +0000
Received: by outflank-mailman (input) for mailman id 235700;
 Wed, 01 Dec 2021 09:10:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qVdy=QS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msLcs-0003d2-RJ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:10:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d21762ac-5285-11ec-b944-1df2895da90e;
 Wed, 01 Dec 2021 10:05:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d21762ac-5285-11ec-b944-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638349782;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=N2dgs7dYT2cOgcBe2yWO6YyWzLCIKGSwRM9v33GX36o=;
  b=DRB9DNJ8jyM44kfnZl2tV29PYTriRyN4ZLH+4hFO3ptASyfOULXl3yd/
   b5H05Qcoc8YTjPSAjZcP/+9bvHnRfXQfnenVel9dG6C+X8eDGSCGHoMzN
   66bU8ZeUwa3NtSzITjQLOAVUWoTy/eqaML7pSBOAl70W3Qq8Nm2OWdkCh
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 588czbPMfHeXUR3aFb+A+VnhrxgQqwG+51DONnXkCu4dRV1PHs8cNDzq15KtfVHqH7twcLlk1A
 FuVOQURbS/oW21jenj1bITInSnQinHrRtSmsWc3zFupYUfh8wTeD9jhLJhrLbJCEyU+pFPvmbl
 TsbyK0bTHKbWT2UA71ZMFJKoK7Ode+8Qwfu5bW9Ug4/YAA/xDAhQa5154HzKunUi3srJP3fL06
 xVB+qj/i9NQxIfsbkn8t9AVomVDbxSFRk/JcyriLokrr4DMX5iihsAsErbHLuWXyYT823e8wZ3
 w29pmOdasPDYouB91BEm6Ejs
X-SBRS: 5.1
X-MesageID: 58503837
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1mpa86jwduLIa8Fxod7CPM5nX161uRcKZh0ujC45NGQN5FlHY01je
 htvUTqDa/aJYGT9fIt+aY6/o09U78eBzN5iGlZu/CEyRCsb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1fhYe1FSI1NZT9p8UwcTBdKgdgZqd/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t1p0WRqaFO
 KL1bxJQPDnwfhBuMG0HUpI3pteJpyLlSzNH/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0SepLFrEf9Aq0+5X1ziSwA1EiUGVLUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9zABbvzt68owGOlor+p5
 yNsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ldB04bZ5UJGO0P
 Sc/XD+9ArcIZxNGioctPuqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WaQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:1hJlwqlFxGI1gKJT1gWCfnL3W1PpDfIS3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5N0tQ++xoVJPhfZq+z/9ICOsqTNGftWDd0QPDQe1fBOPZskTd8kbFh4tgPM
 lbAstD4fTLfCBHZZmQ2mKF+qwbruVvWprY/ts2tE0DcT1X
X-IronPort-AV: E=Sophos;i="5.87,278,1631592000"; 
   d="scan'208";a="58503837"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bkxvWXbMlRyvQjaOdjQj7ZM4XpWX6e5J89WKTXuhKnMdNKsH8zSBw5yQ7Yge+z42b/NH2QE0cJTDDA7KQDPPqqhZWC3o8/kMWHHjJJQEntJmKPSiEO2Q9XDbcWR5eK33jtXsT9+veDVZZP6+ZhuhtupN+/IDzqEqVO1Y3P8jITZxgssKrkOIqc2AEvSJAQ4r2igvV6yNMP9onmuiAum/2gZwqx9nSAyHmU4JMqYOg8twBVYCimc9wCb20Q/53XmRZ8ZIhIBO1YfpEIkXqIV9H/wk5zXhFN+jsqkRvjkEEJmZ3qrDS1ts7t4h9a4KTL8vMWtNY6c2YWikJfrcto2BOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uOfMdYOKQ0M8msuLutMG3uTpzbbxjTYNjnsruJDXtaw=;
 b=jRJJVMBkH1QGL2U6j84YkrVfGl3BoxxmLymEOQswMAjx/qMkuucDreLLhrVnfdnqVLnPVq99Y8oh4DDvCi9m7xwDYskCEEtLdMnImTuxT7RNIw5Gni687p5k3BUGi8BNwOfy/4RoQ8SYeOdv10ObttkjSj9sxrV4vywyqN1V38DqUDDj2WY74dcKd+95D+x7wmw+F2mFddzqZKJjGMa3jqV8TVhM5ULekSNwoW+kSR/h4qWZpUzV4+1mlLCcBpyEIFbgPRGcwai1Au3y9krfLu9pW0N5U9+V0Mg0WKRmOAKVFZNLorEKCtR7GzPYrCWYHqEl9ifL6H4pkZRR3OnpGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uOfMdYOKQ0M8msuLutMG3uTpzbbxjTYNjnsruJDXtaw=;
 b=tOUHmGF2Fo1J/GIvj++Qcq1WgWGRymLK+WWTgiQXuKpBBCwabR4gIcpadSnDjTYzMFqurs6pK9GZ9ijJThq0hyXYBA3N1r1JXCjpPwUdkRtiZvtUDGwn/lOaeL6S5kGbEM/AKJ0dixjw2q7jkz1ts5bQufw/xdDfJMtklY7dZWo=
Date: Wed, 1 Dec 2021 10:09:12 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Message-ID: <Yac7uLaQ1+YdCqtW@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
X-ClientProxiedBy: MR2P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::19)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3014f5cc-1ccf-4ee0-b981-08d9b4aa4077
X-MS-TrafficTypeDiagnostic: DM4PR03MB6047:
X-Microsoft-Antispam-PRVS: <DM4PR03MB6047F4A209507D98C9ED22408F689@DM4PR03MB6047.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: r2yXDEWta6MgXfyz0el0aLk/o+dPI8DKPz5VmFGKDwhJZ1zI7MBKeo/5HrwLtH0MRTTM3k1/Uxwy4lLCZpSrgPbY6ytq74pu+e2bMZMKzVlqUCeJ2xsJpnTacW5NzVHABNrPqTm8CvqK7EtDu4qUrKY5qeJKBvYsphZX58eqeSB1y9hLYn1IthDM8qUtVedVYxUb5mgYJBVASLhc7qMqsDe45WYq6wNIsyNUmi4INsnF8sBVcLgsrlguD0c8cUnCGMiDVJUjKQZRk/GKfdaQE7/iu2L59H9jrqzqSAomJ6NBEvrT7oo30xAmhSwgwK9B1v8tiKHynv7vS3iEQOO9Y0UHf1J6rPJ6YNnp7hzeElPoghi3jbH8J1fVWBP9k3Sw4l/hC++XewcAXxVK209sqtLTyd9Tg2uNgvGADH1owLTv1ixJQkSjNVOs/aa1+yca33c+Buly6wUUBf8gftsaQI/uUx09aPeZDVeuYnvpnXkzsxBaPK9DkvpjS54cw7644StGxyHradCW9IS15Kvcpd7aD2goYUtWXvCnfT5DQeOtzfWgb4hFA//hl2UznT72VhAYD7g/3hXDwUoPE5mNfklODhXfbE9UwPb0otuy/UsWDhxy6ngIfnUrw3BLAqOnxaRAefqxYuGfdFMQJ/kOdjG3380PfiNzhOZT/RzWyUxlWZjmM+w9JUPSvogWRiXFgl+pJNpKwn3mucaYlsjD9w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(2906002)(508600001)(82960400001)(66476007)(8936002)(66556008)(85182001)(86362001)(66946007)(26005)(83380400001)(38100700002)(316002)(6916009)(6496006)(8676002)(33716001)(6666004)(956004)(186003)(9686003)(6486002)(54906003)(5660300002)(4326008)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVF5MXVmOFArMWpMaFBVTGJOZGFtN1IvdGphelJrMW1QSjNoaDFEUUFzY0Qv?=
 =?utf-8?B?eXQ5RXFTYUhTblpocW0wMTZmQi8zdkM3dm1xMWU1OXRhVXVPamxIMGhDNTdS?=
 =?utf-8?B?OFo3OXFlV1VLd3ZaMHE4aVluZ0ZUY2wvdFo0QjBsb213QndQUkFTSEUxcVNj?=
 =?utf-8?B?YmMwc3EwUm5UNXJacnNYbXc4NmExb0VHSlovSkJhQkdOODRvWW5xTEhMTEl1?=
 =?utf-8?B?MFBOdG9YMzc1ZWlFc20vVitycGlvT3loTDNnam44ekhBb2FRYlFiVmF4Z2Yx?=
 =?utf-8?B?b3U4M3NVbFBXayt1ZVdnbmNXcHZKQWo0QnJHaXhJMEpvL2dmaFpPcmFhT2ZJ?=
 =?utf-8?B?YUpYV2x1bFBQSlBuaFVyRk1mNFVkS2tyUk1VdklzT0RNVU1IcGIwQVNiL242?=
 =?utf-8?B?cnQycEFobmpkRHI3K3ZLaDBIM3pPNlZNODBsaHY1UlB2VWZVSXRhajBGR2V3?=
 =?utf-8?B?ZjRVZ25LSTY3Q3M3ZHZ4TyttYm4wajJRb2pnY1JKU0d5a1pZUTFNWXJCK0lm?=
 =?utf-8?B?dERhZDdENjdVZ3d3dDk3dllBVFJPc2ZTcWFjOVpmQWpCdG9GWms2WlRCclRn?=
 =?utf-8?B?SGtCeUR5bzd3aURrdFRWZUNIeXNrY3hmNU1LWUhmaS9Ja1BGc0dFOXdTMW14?=
 =?utf-8?B?TDRjVWdMQWdaN2ZvOHBRdG5wY3NuaXhtUWpIWG5yQ29ENkZpa0NqWHI0ZmhM?=
 =?utf-8?B?VHVSc0dSeGc4QkRXQk1aTmd0Szh0WEZMdzFKREo2eFdGUFkrTUlVSjF0cGhM?=
 =?utf-8?B?RWxqdVovWTRnL2svdUl2VjZXenFPaWdhVUZxVlJpbWIrb2EyS0VUZGRJYmhK?=
 =?utf-8?B?akw0VUVneElkeGV0Yk9lM09GOVU4Yy9XRnlnZkhJVUkxZm5FQlhtOUhnY3BF?=
 =?utf-8?B?L1pzdmNrVGRFdy91VEt3RXdQY3UrejYvMDlzMGxVS1BMaWl5dDlOZWlRdnNy?=
 =?utf-8?B?emNWRWQyUUVYQWs5OUlLWjZKSlJzenk2SEIwcWtaK1UxWjEvdXU1MzFiMVA5?=
 =?utf-8?B?ZVlheXlqMDI0My8xczV5UjZrOGRsYnR1WElDTE1OcVVYWFZzeVhLWEN4QnJN?=
 =?utf-8?B?amZTNyttRHpTdnF1eGluazlBa0o0ZTZvdm4rcm5lc2RoSFFRZVF2YlR3Z0RU?=
 =?utf-8?B?OTYxZk9lZXVIaFp6VTFjVjFRNWNtSGkwejcvRmlKeU1QWDEwNmQvK0djL0Y0?=
 =?utf-8?B?eTl5YnRPWmc0Z056TWJ0WnUvMVlvK2h5TDlnTFRIYXR4RVc5UWdoRVFpVmZh?=
 =?utf-8?B?ZFNFMXdESkl6T25KczlEWmJ1R2R1TW5oSm41UHdQZE5INE9pc09lSldwMG5v?=
 =?utf-8?B?Ly8vbGNIc1lucytpVGFBN3lJcGg5WWRmSVJDK1lSM1puMjA2aU9zVzhTb0Rs?=
 =?utf-8?B?czF0WHAxcHl6QTZQZDdYUVNBNXEvOXEvd1RKN0FGSkZLMU13aUtCYlVhY3Jh?=
 =?utf-8?B?TjVzV25Tc2xpQ05iMDgyYTh2dEprK3o5OWc3bHVVUnlVN2ZtYkVCTXFsWHhU?=
 =?utf-8?B?M0xScTY5NEI1QVFXTzk1b2JvVzhteUtaUklaRHpEZ1Y1Lzl3QjJCN3FxNjF0?=
 =?utf-8?B?c0RxRmNLWHo1RXNFekhhOEJQdGt1TFBQcy9uUFlkejhqN09GeG1weHkxNHM5?=
 =?utf-8?B?KzNJdWdsdUI2eHJMTDhhWXppRHIxNUJVYzV1L0xLOVVlY3RnUHh5QXpzeUdS?=
 =?utf-8?B?MHdaRWErT0M0dnhIdDA4eFJ0YVdPMzVRaW9UMWxveXNxMkFnTkdadHIxQitZ?=
 =?utf-8?B?Qld5OFhnVk95MmFMc1FmaGRtSVkrcVlROHhZSnQwMTBWaGQ5bUl1OGZLY2NT?=
 =?utf-8?B?YWxzN1Y2cTcrbGYwMytENStYbWpXa2k0RS9TZm9YSi9oclQzSmwwdDIrRkZC?=
 =?utf-8?B?aFZSZGtvb1o3NWxQTnJQYVlvOVN6T01xdVpKZmRnNXhTTHM4OVo3TkkrTUFG?=
 =?utf-8?B?SjBQVEpsOUZTK2VKeXZhVjlXVkUwbEJYRzdkOU03aFRucEZ0alRNQllrd3dL?=
 =?utf-8?B?b1J1VWFOYWRmT213TmxLNGlYUUxteUQweUh6VW9YeEM2aytrVmViNmluZFRQ?=
 =?utf-8?B?WlYvMVRwU2hzYjVzWXYrT0lKZFduUVZWMEhPOWYxcTFwY3JqVXAwTVZJSlpS?=
 =?utf-8?B?UmNpRnllSWZjaG81MlBZUGs4Ukx4Q0hHLzQyb29IRTVYc0dic2U3dy83aUtk?=
 =?utf-8?Q?m4h+UgeoB84HaU694tylvBQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3014f5cc-1ccf-4ee0-b981-08d9b4aa4077
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:09:17.0067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T6r2uilTdxxUuIhC6C+tYt2+blw13fci75mLAEB2oEymABaBVQYjYw0VMaFCW3sS8zIre+6f2keE0Ybir9dWCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6047
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
> While already the case for PVH, there's no reason to treat PV
> differently here, though of course the addresses get taken from another
> source in this case. Except that, to match CPU side mappings, by default
> we permit r/o ones. This then also means we now deal consistently with
> IO-APICs whose MMIO is or is not covered by E820 reserved regions.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> [integrated] v1: Integrate into series.
> [standalone] v2: Keep IOMMU mappings in sync with CPU ones.
> 
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -253,12 +253,12 @@ void iommu_identity_map_teardown(struct
>      }
>  }
>  
> -static bool __hwdom_init hwdom_iommu_map(const struct domain *d,
> -                                         unsigned long pfn,
> -                                         unsigned long max_pfn)
> +static unsigned int __hwdom_init hwdom_iommu_map(const struct domain *d,
> +                                                 unsigned long pfn,
> +                                                 unsigned long max_pfn)
>  {
>      mfn_t mfn = _mfn(pfn);
> -    unsigned int i, type;
> +    unsigned int i, type, perms = IOMMUF_readable | IOMMUF_writable;
>  
>      /*
>       * Set up 1:1 mapping for dom0. Default to include only conventional RAM
> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>       * that fall in unusable ranges for PV Dom0.
>       */
>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
> -        return false;
> +        return 0;
>  
>      switch ( type = page_get_ram_type(mfn) )
>      {
>      case RAM_TYPE_UNUSABLE:
> -        return false;
> +        return 0;
>  
>      case RAM_TYPE_CONVENTIONAL:
>          if ( iommu_hwdom_strict )
> -            return false;
> +            return 0;
>          break;
>  
>      default:
>          if ( type & RAM_TYPE_RESERVED )
>          {
>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
> -                return false;
> +                perms = 0;
>          }
> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn )
> -            return false;
> +        else if ( is_hvm_domain(d) )
> +            return 0;
> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
> +            perms = 0;

I'm confused about the reason to set perms = 0 instead of just
returning here. AFAICT perms won't be set to any other value below,
so you might as well just return 0.

>      }
>  
>      /* Check that it doesn't overlap with the Interrupt Address Range. */
>      if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
> -        return false;
> +        return 0;
>      /* ... or the IO-APIC */
> -    for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
> -        if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> -            return false;
> +    if ( has_vioapic(d) )
> +    {
> +        for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ )
> +            if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> +                return 0;
> +    }
> +    else if ( is_pv_domain(d) )
> +    {
> +        /*
> +         * Be consistent with CPU mappings: Dom0 is permitted to establish r/o
> +         * ones there, so it should also have such established for IOMMUs.
> +         */
> +        for ( i = 0; i < nr_ioapics; i++ )
> +            if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
> +                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
> +                       ? IOMMUF_readable : 0;
> +    }

Note that the emulated vIO-APICs are mapped over the real ones (ie:
using the same base addresses), and hence both loops will end up using
the same regions. I would rather keep them separated anyway, just in
case we decide to somehow change the position of the emulated ones in
the future.

>      /*
>       * ... or the PCIe MCFG regions.
>       * TODO: runtime added MMCFG regions are not checked to make sure they
>       * don't overlap with already mapped regions, thus preventing trapping.
>       */
>      if ( has_vpci(d) && vpci_is_mmcfg_address(d, pfn_to_paddr(pfn)) )
> -        return false;
> +        return 0;
>  
> -    return true;
> +    return perms;
>  }
>  
>  void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
>      for ( ; i < top; i++ )
>      {
>          unsigned long pfn = pdx_to_pfn(i);
> +        unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
>          int rc;
>  
> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
> +        if ( !perms )
>              rc = 0;
>          else if ( paging_mode_translate(d) )
> -            rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
> +            rc = set_identity_p2m_entry(d, pfn,
> +                                        perms & IOMMUF_writable ? p2m_access_rw
> +                                                                : p2m_access_r,
> +                                        0);
>          else
>              rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> -                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> +                           perms, &flush_flags);

You could just call set_identity_p2m_entry uniformly here. It will
DTRT for non-translated guests also, and then hwdom_iommu_map could
perhaps return a p2m_access_t?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:15:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:15:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235706.408860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLhg-0004Qf-Ny; Wed, 01 Dec 2021 09:15:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235706.408860; Wed, 01 Dec 2021 09:15:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLhg-0004QY-KO; Wed, 01 Dec 2021 09:15:04 +0000
Received: by outflank-mailman (input) for mailman id 235706;
 Wed, 01 Dec 2021 09:15:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msLhg-0004QS-15
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:15:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 58456d99-5286-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 10:09:34 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-_kTKD8e8Nu2Q0lJbJTTCHQ-1; Wed, 01 Dec 2021 10:14:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5328.eurprd04.prod.outlook.com (2603:10a6:803:59::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 09:14:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:14:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0051.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Wed, 1 Dec 2021 09:14:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58456d99-5286-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638350047;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Pl1uorcJhBIB+n9XqJQwSjGHIIgVWj825OedBrXJNGI=;
	b=YkhmPmBqTQnaXFjLxbHZ0nJpO0kkBAPFprleUQRC8IrlvbjLOkud7DOpsW3D5DWgZ7vWiL
	G7RNAcOi/6ssd9zPBhSqwAEKpiZZwL0vi3hd/ykR+37t3yX3cqcF1Sptd2/EfkrhLzt3ZU
	064r21ScQIY8LoP1hUWePO7b0nXcYm8=
X-MC-Unique: _kTKD8e8Nu2Q0lJbJTTCHQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b1YoReuJgpFBdB/sA0dVmvec9Mb9sCoPn8ToIFO8wQY+B2TrBpmwumZ7Ve1LoJVOAzux/D2aZI4Lm/LkMH9OcloMg9n3fGqDE3XpUJvlACZrO6sGJezMInrJfNONwlL2GgPg29MZxcF9zp3jr0T5jVKiStypgV8BqJ0jlncnhth8obNxto+lyrIDwxMdYWgXWunztbh1UIX3bA7JIA3DeIntJ14QYMuRtO1JHOuTgW6y60UziTeqTjAJwM3PjYYqrZ03Ro4sxuw1TLjyV79oQVhhPzJsjmZzMLylwqZ6gUwgmpzLJE75A/C53X00tpbegjmIsifbdEvi50DVD0oJew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=92nX0NpUIZgB14Meh7c6HXGtrdKnqZBaQ6cnYmWqbJ0=;
 b=HejIxc4gXm0AzpdEFJbj7Ox6n5zWD7KiZ1SZm9oO7/px9gCojLSH2xByEEMBTAk1UM74b9q/4qsZx9yrlu1qaZAQN8mY2kjueIq8qTbG7T6JZGiXtxRvI977YMUXGQyE/LUCvgwj5RT9WmeMgADPAnfLY3TKapJA/5dFAUeGKIqiki6+lyACILNjX+tSMqqq4/dUwhf7CMG3gaYXqZIuO+izQxJ+emDZDiaiYhEBvXDEkW1+BeCp92elKKJB0Zkvm5Zftky+6oYglR89Ii6aIn3Roe6m7IwrN4Eo4/4HDypXtfQH2LFXYrVOojxWYap3i6N6QK5lRMiLmvxD9B51tA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <037802f4-d28b-62bc-e830-78149f1cc2ff@suse.com>
Date: Wed, 1 Dec 2021 10:14:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/2] x86/hvm: Rework nested hap functions to reduce
 parameters
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130181139.14398-1-andrew.cooper3@citrix.com>
 <20211130181139.14398-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130181139.14398-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0051.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d305efb8-1885-4395-691a-08d9b4aaebc0
X-MS-TrafficTypeDiagnostic: VI1PR04MB5328:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53287ADC1AF6CC536CBA1226B3689@VI1PR04MB5328.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Tdm/8V8rpJhqrGv68seuAVtTbegnqtCJ7Th25jYR2A5rfkTZfTPTkivUAqoftvXcuuKSy1uAOfBZj1t1PKPZFTmatfxB7X/OPPmXhflkTnjfXYzzuYCTJ7yOU5BFT2vWE2FJy0sZvTGWPZ/XVqJLLHI8+/dyzR0xAgiY1QIW1VeJbveT9KiJWVsFTpzkfcGY46GDiwMSwotC7cYVvKtWtHUdnWg4CceI6zGDkuBdmx6+wooKHNAreqT/PnjlME44RZzgIQ6FVTGQJQJj83aIUXN5I75rC63By0H4GmrxdU8G1Bl3Yfew5X0RBJi0hJNDbCrip66OcgLDv9v2zprrp8pumPEojWAial6lzQ9YV6K9S2saIdxykA0oss4hOT2TKcqWVzUnqggOAPDCbhN8bIqdGeaYPOx3ZBDSjuqJKMWw4Jo8aqeThB4UqQvYKKyfdx0PTlr7lIFWbzBaS3sQsZlVJOND3o79K+KhaP1yPEfSDHoYd14RvwKnrxy/IlnGoP2Wv7pdVVs3CDaGv5zmWMGB5LvX9Ab12aSeu0nysbrJdgjFNtS08ZukZiXrcnEqAdOTnGHpCn1NOLhHXbChtHB7V0PQJtTNjF+TGBPzJysdfy1TIIeIqyN7oQ/HbmdNsKZVsC7oeSZN/zl/TuRO6MXHmJ7UYMejGFOad5Ty+sPoQO6qBAOzaUJgdMYvGAzegVQcnFNDDfpIFZx0wwWJd7ndGeMTvQ8EZFUxGsPZTMM5T6dOBDJWeHSy2aPqsmwu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(36756003)(5660300002)(316002)(31696002)(2616005)(66476007)(26005)(6486002)(186003)(4326008)(956004)(86362001)(38100700002)(8676002)(2906002)(83380400001)(16576012)(66946007)(8936002)(6916009)(66556008)(508600001)(53546011)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RTLwbwHh9HF7+stya1GUDlacvp5ZcDe0oSf8sfd3zVMxs4nk752hocPaV5Uz?=
 =?us-ascii?Q?XsD9Th5kb3AFOcVmNScHRhPzmLA34KJ+XPn2gyKkE2sZSa1VNh7Ty0v3WyFR?=
 =?us-ascii?Q?y5CQtMgbHU+U7ioobtVM3GIwyF+hX4r/AOmwJq7JYcqXTJj/dp/ANTzOPJD4?=
 =?us-ascii?Q?JFL9Bc5gSa/x2z99WKPId/1n4kieq03LT27YAtsR+jf8k66HSBDhRlcGRvlR?=
 =?us-ascii?Q?7M2y0yMM/yHkbF9NXwbf3qFhJJ7jg7hKmpiIP1yObQnLQ39Ut7fKkfVPeIUb?=
 =?us-ascii?Q?BFkIh65TnUaVyFy+lUMgqjgnnsCxtTLhtoW5TeSXoZQWEnYhK2n2xziT/drD?=
 =?us-ascii?Q?k7lS0AB/8c49jCw+/0oowTocer4I/y8dxHWKOrK5uM+QoQWTAFurBM5XLZde?=
 =?us-ascii?Q?A+RsdS0zfoEz6APo1bGagWXpzVtNTEtK15EiJ6YxFFexQsbUH7/89zpByIun?=
 =?us-ascii?Q?pNLwf+5XZ5nLof9L+9j6AR0ccbOK8HhU81tK9vGa/cHG9TFX1gfsTHytxP1O?=
 =?us-ascii?Q?nGhRktxNs1cpZETVibwRZ5GqXWVq4TT7r7ThuR120cIZLFEu4/Di5a+QcuNl?=
 =?us-ascii?Q?/3Lnyv3+/y9CIesGNqAea9/o42lqmTHWWUOXsOzgs4fYueaEPZU72z7WddKD?=
 =?us-ascii?Q?gzP/dv+SGrRsSjazzZ0w/VDX7BmVf+SsMHdz4L6yWkykfd+TDn9j61SuyJq9?=
 =?us-ascii?Q?QFEXRwBrZcluae3ForNonTQxj5cdk2JFglZeAR5RLnWahfLIXKjeK0vhL/RQ?=
 =?us-ascii?Q?NSjlGtRxaR/TqUtaYfuBXK/1w2AI4JZaVhj+PB1LiOeRQWhUB1+cl3FHOlzf?=
 =?us-ascii?Q?Yntd/g1XU/aXz2ikA5kXeC1gQgOt4xbajtnlXDXryV3kBYQq9RIJcP2ktyP5?=
 =?us-ascii?Q?oSYD4LQnZFCSBPnirrSIRcRiREhFuxp07YIgRwZkJ2AOZoNq5byPYcD1KXow?=
 =?us-ascii?Q?zWljEBB5WjnuLfYVgrcK8/LsArplIUL/8LYs47bTNTJ1Qah2ogNfj80rT2KS?=
 =?us-ascii?Q?mcyTuEEXCpon7tSRiROMEBNNfGV6l7kay2yc2TyV5J2M3xJ2lMZD3uIuEBy5?=
 =?us-ascii?Q?2H9qEN+82nDv78Z1WsPP/OHZbzamTtearYNsfBGpghTd30SraFeMasNpsys0?=
 =?us-ascii?Q?ZUnLjEWuGU0jwor8i+oVBBhVDObfBdA/SoTbKSUqPs9pLVG68SYG9zELjdEb?=
 =?us-ascii?Q?0oW7Es2rFjvv3lwOB+dA3aH74tuU8UPdN99A5gHddZpz6mQz1kvNu2YN52FU?=
 =?us-ascii?Q?Sa6ZRd2VjgKV9+MSY/xTuNT+rQebUfINmk+0xsz9gp47FmVjWVIsjX0XNLYd?=
 =?us-ascii?Q?0c4JPu+cepX3rShLGSpLpVfxA9KPX0slbBexCyHpMY8JX0y7FiIyhGr0wvdu?=
 =?us-ascii?Q?lXH+NsYKNMFRjMcwvUB5ai6YaHDfQSOZNmdoqSnuQUOnKY30ggJxlWBK/mHz?=
 =?us-ascii?Q?peqeAckvv8vlp+HuhXK68uUEsj38Ep6M2mMd2viYAD+51q8VxO31YNVg5T5j?=
 =?us-ascii?Q?Bj+Bc5JSs4GvykomDwe47ce8d/g9GzqQC7cLz7LxsHVhze5npHlJ3UmuAbsp?=
 =?us-ascii?Q?zw1D2cq+7FGg5qyHrjiT7aZqa0NnJL55htwlIJ277FtBF46Qb3xkus1+wm2P?=
 =?us-ascii?Q?5+zbpZkic0ONxoaX1DEAHyw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d305efb8-1885-4395-691a-08d9b4aaebc0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:14:04.4610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t7enNhALdVZoPbAm2GSvdAr2EsmuMAu+QqdxeWjoBAp1mQ7FNqmZny0+61uEEY9EpwNdGowstOh+KVrBHKUVww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5328

On 30.11.2021 19:11, Andrew Cooper wrote:
> Most functions in this call chain have 8 parameters, meaning that the fin=
al
> two booleans are spilled to the stack for for calls.
>=20
> First, delete nestedhap_walk_L1_p2m and introduce nhvm_hap_walk_L1_p2m() =
as a
> thin wrapper around hvm_funcs just like all the other nhvm_*() hooks.  Th=
is
> involves including xen/mm.h as the forward declaration of struct npfec is=
 no
> longer enough.
>=20
> Next, replace the triple of booleans with struct npfec, which contains th=
e
> same information in the bottom 3 bits.
>=20
> No functional change.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Tamas K Lengyel <tamas@tklengyel.com>
> CC: Alexandru Isaila <aisaila@bitdefender.com>
> CC: Petre Pircalabu <ppircalabu@bitdefender.com>
>=20
> I don't much like this, but I think it's the least bad option in the shor=
t
> term.  npfec is horribly mis-named/mis-used (at best, it should be consid=
ered
> npf_info, and probably inherits from the same API/ABI mistakes our regula=
r
> pagewalk functions have) and is going to have to be untangled to make nes=
ted
> virt a maintainable option.

So why use struct npfec here then in the first place? It could as well
be "unsigned int" with constants defined for X, R, and W, couldn't it?

> --- a/xen/include/asm-x86/hvm/hvm.h
> +++ b/xen/include/asm-x86/hvm/hvm.h
> @@ -25,6 +25,7 @@
>  #include <asm/current.h>
>  #include <asm/x86_emulate.h>
>  #include <asm/hvm/asid.h>
> +#include <xen/mm.h>

Nit: Typically we have xen/ includes ahead of asm/ ones.

> @@ -631,6 +630,14 @@ static inline enum hvm_intblk nhvm_interrupt_blocked=
(struct vcpu *v)
>      return hvm_funcs.nhvm_intr_blocked(v);
>  }
> =20
> +static inline int nhvm_hap_walk_L1_p2m(
> +    struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_=
order,
> +    uint8_t *p2m_acc, struct npfec npfec)
> +{
> +    return hvm_funcs.nhvm_hap_walk_L1_p2m(
> +        v, L2_gpa, L1_gpa, page_order, p2m_acc, npfec);
> +}

Is there a specific reason you don't switch to altcall right in
this patch, making a follow-on change unnecessary?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:27:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:27:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235713.408871 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLth-0006D2-0r; Wed, 01 Dec 2021 09:27:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235713.408871; Wed, 01 Dec 2021 09:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLtg-0006Cv-TW; Wed, 01 Dec 2021 09:27:28 +0000
Received: by outflank-mailman (input) for mailman id 235713;
 Wed, 01 Dec 2021 09:27:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msLtf-0006Cp-9F
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:27:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5164719-5288-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:27:25 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-vQB58STVPACvU7lcHbMWmw-1; Wed, 01 Dec 2021 10:27:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 09:27:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:27:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0326.eurprd06.prod.outlook.com (2603:10a6:20b:45b::34) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Wed, 1 Dec 2021 09:27:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5164719-5288-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638350845;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+cT5dYmJg4BpgiUZ7H2qn7Pe5rkWz1gQwZJoYb2pKGA=;
	b=Ee3Jd0C0CW0loPIHL5uzvWZjS2sqi8q2TNCSySQ0mfgdIvWubWsQMCvsfzllMh0gOgobox
	cC77sn5XSLyrVtlolooWQOIWGasPWj7C0TVwn/m5icZ1EhQhDzYaMtZYipvkj2mL4c5d6y
	gPmHouBD5VIB0Aohsf9jK2w4v74+L+8=
X-MC-Unique: vQB58STVPACvU7lcHbMWmw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fyuvMNuchfejCTJb1Io9CJly7lc3BsbiIAo+MbQpYgM9gJ+QounE+Ni2ZuhX6TlHFMCFkCl1iY43+YDYDkdY9GADzfLwSPF0qdpZdDl9Kew8OyNva8x8I9bcwoDK1K5a+0kTF3XU3q+ARbYVo/D0PHvuZh/bSkqa0/b2Co4pnNZJh00s69+3n0O9Ot8tvKSt9yt9f9YDxMczjnqbsfRcFDqwZPExdd8qX8im8tjJQWbppUdmJ6def3M14q3iYtyJFLSC9xTmwQqJLlTfrqsyOoYLiOc5/YaDGICBH/0nZktFt3uGcCf/2siabjNlshcx5MqLHHg6lY3CebkCvA7Nng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QkYb3HDaBJPuwzu7h5/sWyxPwJvQ/HUMoV5E7AoR/6U=;
 b=Oa1cFtovIWPEaASdyy3YgVkX8ln5Ujphb2xuh76Ux6HctiCPX9Hwf5EISK1t6LwsSC6ZN2dCg+ABQYWfzV0P6cDK5ucHcGF+cD5yZTcNDJCgw/TIAqedXhl8ipHhGqYGbOYwrQYcvgaEXHPEKdXWn7BOa+7lO7vnvgT05HTiAysBjhHqPdVW8BVwHcQDcml4t6gAYX5bvkLNfL4sHgVfuDnEJ7k52XbSU845v9X+im726t/GTTnDd1LJd3sEFsuP6w/Ltu06U6Q56wj1I8we2ilnuybUoXsaKncsoL2Q9rC5PI21Z8KHbycq2vOuj+GB7v0Xf3y5dyTyCDF5fiaizA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
Date: Wed, 1 Dec 2021 10:27:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Yac7uLaQ1+YdCqtW@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0326.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 057eb263-e626-45f3-718a-08d9b4acc7e0
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2957F3B7B265D0AB925384C1B3689@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PqXm9mbfdz620/w1tYsS8MUt8WtqB7WLShoFzteLZGj1Ubrz66BaQbHHKlyrRXLyW1Zd6OAWTq1G0t3lf5tNgeOAi5JAbm1HwuBo07kUBiRMFmj8/8vDk+jRcgRSjMsRj9IRGZHcpLoiHvZhjqnYBrPsDfyISBd408royVhhvB7YMifGfCc2eYDUjE1mcwZso+6JMkJZpbS1nW1JBfdyyCNfIQJ4ze/WRV3tz6+msJO01yATXcRZgM6nVpD3T2B8OplOM3CU41JmFPWQ5DzPt2wtNRoYCkJtqYjF/JMk2Jipqpx6dLTg/iu4uGpuX7XXIMXtUrfgszh5kNdoxwbvPHcdRC8q5jJWiS57Q5rG3rUkDgJqivlfFv/ikjSe2HM7Xb/g8iq0a6YKZ/8IuSTuImAL+Lb8kJNZX3zGerD7rc1XIFpAzJdiUTUkMgh4Vs3hC3Z2458sV3i483W7gG2wqR0AERFivw9uqxn1qXYv5sBp4d1mqnmo/GfDI0rCcMXCvqdc37zDGCzAbfk+3vZlZ2s4x9UvVSQbDGGr7wB+NKenVwMo+yNL6iQQcDxFnGgUozOzAkI+Ht73l+lPVwy3UZwsPjdgNi3tGwuZvF1Hh7XKO0KB2JA6z6zXtYLSxiUmAVmP9H7p/AbUrAReFX6Ka2kWCVimkioV+LG1X3wBqwDHhpxu+X2e00jPqhwA0NQ0MnBXBF7VYBeJXOOc8zOvdJHqeBHyF+pnDUfM1vEIpU0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(6916009)(66556008)(956004)(2906002)(66946007)(38100700002)(31696002)(54906003)(36756003)(186003)(2616005)(16576012)(66476007)(508600001)(31686004)(316002)(6486002)(53546011)(83380400001)(8676002)(26005)(5660300002)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cEEICkkauFbNrzYBbrpgWKSduhKeKnMonGi54O6jUuiwpdxQhcaLjLUEAUx4?=
 =?us-ascii?Q?WQ77f44o+oy4Mko/lz3Vchc6ZXNI4nNNnJ48VWPWiVcJIKuej+Kk3+o/jHz3?=
 =?us-ascii?Q?bVno+H8auVD2JVL/M1Ble/5Iq+NGYoCEs3OsGT9AfDs3rjxmk/F0GXl1Hhfy?=
 =?us-ascii?Q?cT7ly23y+zk5WdUIgcvFyT1HYHV7dmd7s39ZZKaoNBNu0TbgNxoeBmTgXD6q?=
 =?us-ascii?Q?Fsh8sZXo5iVQNODIkaaJZqwwIb3du8+SPXRi5yMozPWwx9RqGQFC9KhIwajQ?=
 =?us-ascii?Q?jWVKMHzW8mKBdO8xgwIsOa+sId+LCPnZ6N1ajD0rFH8AiVGiszB/lkIUsvb2?=
 =?us-ascii?Q?xbnezAJx3knwA/AAdSR8r+ZV0Ku5rXX55mAPygnQN/j/UsEG6EINWhH74/li?=
 =?us-ascii?Q?RL3yxQ7QyMKL90EVpNoNYUc6nljh+pEUSQ8tSThDNsN5TMOsRdo2ZVcTuhNj?=
 =?us-ascii?Q?l9wyxuU4HNLHpd73+OdMB0+VDrAf2DtU4ilhAabc1uJ4ttZlSpsMceR++7r3?=
 =?us-ascii?Q?9CI+K3g9Dl3kwrIicSqDU7UliKJZts6YUASH4qRvZTTZiYcfl5vWH5LhODkZ?=
 =?us-ascii?Q?IROVP9T5xq6Pah0e1XNlV6mQ1HClrmXPagOknXIcUgp/OctV2m526p21mFb/?=
 =?us-ascii?Q?qyD0Js4PpQDVt7aoyP0Pt05nPqS7YcFy5yDod7WRvdkPV3X/0HiT2HSvmLDy?=
 =?us-ascii?Q?TogR4R6kQiAtUBA3f++in87R3Zky53m1Lvt3+KabbjBGIjWe1VAVOIzfKfXo?=
 =?us-ascii?Q?1iYJS+/UIt87NPjccRUuuwQBUMMcqnUHi0vPOv6pgxTChLcDMT17cnozEG87?=
 =?us-ascii?Q?eExUcGlN6x3fORFrBvWPr1GNHT/L9jltnEDse9CBZp8iXv+h3N6tAAzYwgq6?=
 =?us-ascii?Q?rmSsPGi49e+Pz6N0hSLoOmEpwL62nhu9RDP+sJAgyAEUBnXCdloXdJzaQSgY?=
 =?us-ascii?Q?VrGaew423/BQPfOHXpgwwUSxqNi44n3TUe++iknAMBkyz3YeZmt/Kr0yhNnm?=
 =?us-ascii?Q?8PDDnHEBik/uDkJrQWqVol4ObrvzVlsmUC8SRGDwXzLn+TytIz2v4pd+DEr7?=
 =?us-ascii?Q?CPeBoQO4X/pYZltxV+QvuSeRGw1NDF0kl8loZ1TRKAoUd4/2NT8nBzzGzIPm?=
 =?us-ascii?Q?uJ3xpxuR0Qj02lZ3qdOgDhpOU7tYnfXFuZVfToV4NE73S0OtHzMv54y6yzOP?=
 =?us-ascii?Q?oUSPWJoX8CdXqcs3s1H/TGTUfhgtFGxYVkygYoL/MVFDK46PCbQMncdqtdbp?=
 =?us-ascii?Q?PriAvpWH5uwEQ0yIfUtD3yz2hVOr3LItgf64wT/ArhIda4llSQ+sQVXi1Hsq?=
 =?us-ascii?Q?Crd0rU6wmqaOWgmVVeHLafFuGTS4RrYDm0TBQnfU9ldNkFy+Um5l+MZblx6V?=
 =?us-ascii?Q?WV4wtDc+oDxH+8xT0PL48XpgMCK7qVv+Pr6KzfcpW0Hg1g+/27T9M36zfGxx?=
 =?us-ascii?Q?BLEF5+jyXsLevAUssoOf4UC4GOzQrNSoPbRh4XmxS0XzUc59RGfQXtuCx9EV?=
 =?us-ascii?Q?JDI4O8R5qHJr8Jo7HtNLUHXGy6bI8UA7dQ/biPmpCNUlSH36TPlTSw34fFiV?=
 =?us-ascii?Q?DpmAWyAaCQp5VWjbLu2U8uiLrEMdr+B8Nqv5NB07gO+vt/UgsEFMINTq86Pj?=
 =?us-ascii?Q?ppfsavZl2OWL3/GGEe98AzY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 057eb263-e626-45f3-718a-08d9b4acc7e0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:27:23.2064
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iMy9FdyPzwg+8J8VNY+Xak5Yid/so95xan7fTdIUbu1S6X/MSv7IeJUG2i34TLVqK8h8a4fu+IfpvwlHUx6vYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

On 01.12.2021 10:09, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>>       * that fall in unusable ranges for PV Dom0.
>>       */
>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
>> -        return false;
>> +        return 0;
>> =20
>>      switch ( type =3D page_get_ram_type(mfn) )
>>      {
>>      case RAM_TYPE_UNUSABLE:
>> -        return false;
>> +        return 0;
>> =20
>>      case RAM_TYPE_CONVENTIONAL:
>>          if ( iommu_hwdom_strict )
>> -            return false;
>> +            return 0;
>>          break;
>> =20
>>      default:
>>          if ( type & RAM_TYPE_RESERVED )
>>          {
>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
>> -                return false;
>> +                perms =3D 0;
>>          }
>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > m=
ax_pfn )
>> -            return false;
>> +        else if ( is_hvm_domain(d) )
>> +            return 0;
>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
>> +            perms =3D 0;
>=20
> I'm confused about the reason to set perms =3D 0 instead of just
> returning here. AFAICT perms won't be set to any other value below,
> so you might as well just return 0.

This is so that ...

>>      }
>> =20
>>      /* Check that it doesn't overlap with the Interrupt Address Range. =
*/
>>      if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff )
>> -        return false;
>> +        return 0;
>>      /* ... or the IO-APIC */
>> -    for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
>> -        if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address) )
>> -            return false;
>> +    if ( has_vioapic(d) )
>> +    {
>> +        for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ )
>> +            if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address=
) )
>> +                return 0;
>> +    }
>> +    else if ( is_pv_domain(d) )
>> +    {
>> +        /*
>> +         * Be consistent with CPU mappings: Dom0 is permitted to establ=
ish r/o
>> +         * ones there, so it should also have such established for IOMM=
Us.
>> +         */
>> +        for ( i =3D 0; i < nr_ioapics; i++ )
>> +            if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
>> +                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
>> +                       ? IOMMUF_readable : 0;
>> +    }

... this return, as per the comment, takes precedence over returning
zero.

> Note that the emulated vIO-APICs are mapped over the real ones (ie:
> using the same base addresses), and hence both loops will end up using
> the same regions. I would rather keep them separated anyway, just in
> case we decide to somehow change the position of the emulated ones in
> the future.

Yes - I don't think we should bake any such assumption into the code
here.

>> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
>>      for ( ; i < top; i++ )
>>      {
>>          unsigned long pfn =3D pdx_to_pfn(i);
>> +        unsigned int perms =3D hwdom_iommu_map(d, pfn, max_pfn);
>>          int rc;
>> =20
>> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
>> +        if ( !perms )
>>              rc =3D 0;
>>          else if ( paging_mode_translate(d) )
>> -            rc =3D set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
>> +            rc =3D set_identity_p2m_entry(d, pfn,
>> +                                        perms & IOMMUF_writable ? p2m_a=
ccess_rw
>> +                                                                : p2m_a=
ccess_r,
>> +                                        0);
>>          else
>>              rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER=
_4K,
>> -                           IOMMUF_readable | IOMMUF_writable, &flush_fl=
ags);
>> +                           perms, &flush_flags);
>=20
> You could just call set_identity_p2m_entry uniformly here. It will
> DTRT for non-translated guests also, and then hwdom_iommu_map could
> perhaps return a p2m_access_t?

That's an orthogonal change imo, i.e. could be done as a prereq change,
but I'd prefer to leave it as is for now. Furthermore see "x86/mm: split
set_identity_p2m_entry() into PV and HVM parts": In v2 I'm now also
adjusting the code here (and vpci_make_msix_hole()) to call the
translated-only function.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:33:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:33:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235717.408881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLzG-0007bp-Kb; Wed, 01 Dec 2021 09:33:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235717.408881; Wed, 01 Dec 2021 09:33:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msLzG-0007bi-HT; Wed, 01 Dec 2021 09:33:14 +0000
Received: by outflank-mailman (input) for mailman id 235717;
 Wed, 01 Dec 2021 09:33:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msLzF-0007bc-Bx
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:33:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msLzE-0000JS-Mn; Wed, 01 Dec 2021 09:33:12 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msLzE-00053B-G0; Wed, 01 Dec 2021 09:33:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=nQbPJnriUaqVckOX1PDcAnacCp6QfkBl1JOSRJsYzwY=; b=mnErIKAZ8tvIwLdIAlrGtWNjrb
	JmxGIAN7HLywYDXLGJN3OMGMK0p987SVv+lWRLB1xxyajQKogry4DOYGz+/ll7NgtwA+P3Rx3moMQ
	0dST7XBkhQJ6MXz5bWnafOn4M4/x711gmNUD3Pc/77wWYnTpJbz8kg1v0eQkdNK+Dk9o=;
Message-ID: <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
Date: Wed, 1 Dec 2021 09:33:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, jbeulich@suse.com,
 Ayan Kumar Halder <ayankuma@xilinx.com>, andre.przywara@arm.com
References: <20211130181238.5501-1-ayankuma@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211130181238.5501-1-ayankuma@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 30/11/2021 18:12, Ayan Kumar Halder wrote:
> GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
> in bitops.h.

I am afraid this commit message is incomplete. You say you just 
corrected the bitmask returned but...

> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> ---
> Changelog :-
> v2 :- 1. Replaced the word "vector" with "value" in comment.
> 2. Changed 0x07fe00000 to 0x7fe00000.
> 3. Updated the commit message to make it meaningful.
> (All suggested by Jan Beulich)
> 
>   xen/include/xen/bitops.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h
> index a64595f68e..dad4b5aa1e 100644
> --- a/xen/include/xen/bitops.h
> +++ b/xen/include/xen/bitops.h
> @@ -5,7 +5,7 @@
>   /*
>    * Create a contiguous bitmask starting at bit position @l and ending at
>    * position @h. For example
> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.

... there are two extra changes here:
   1) The bitmask is now described with 8-characters (rather than 9)
   2) 'vector' is replaced with 'value'

The former makes sense to me, but it is not clear to me why the latter 
should be changed.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:35:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:35:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235723.408893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM1a-0008D8-2E; Wed, 01 Dec 2021 09:35:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235723.408893; Wed, 01 Dec 2021 09:35:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM1Z-0008D1-Tx; Wed, 01 Dec 2021 09:35:37 +0000
Received: by outflank-mailman (input) for mailman id 235723;
 Wed, 01 Dec 2021 09:35:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM1Y-0008Cv-D2
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:35:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0917f212-528a-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:35:35 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-ae7S1H3COaqcTECFmoXO0A-1; Wed, 01 Dec 2021 10:35:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 09:35:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:35:32 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0205.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.21 via Frontend
 Transport; Wed, 1 Dec 2021 09:35:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0917f212-528a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351335;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=/y6RLca+1pUE+izwcBKQFC3EIrdH3gGzNiT0llCVhvk=;
	b=UvDJsM8KXxxDKnwyQmz8RUgjPdsbfTY3k8ZpR9yWal3gI/Y8dhHZtYUioILG64za87Ac9a
	ofCeSis0Huh0zjjBDydNVoFL025P3aFk9HFLlH08KzSwv7fWAo3pDAxJ3uo2+sq5qPoPLk
	ILfKZ6Yp3MRv9gTXwQoe6of9l6Mb4p4=
X-MC-Unique: ae7S1H3COaqcTECFmoXO0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RBgZjC4gRr7dN4RWLS8coPxSobfqxXkoblr3i0Hoka7W+gYY1bwS9tikgH5DPFrOH2XndG0OQtwEGHuw1xydZuZIhrCae61Zb5QuhNVqJBiZ3MvFXCQiMxwDAbQbpqZVTMud5c9X4Y/vQGxEckUoMPvqGNBZUsC5bU5B/ewnCWNGEvwd/CQD4EGTdvDYojAjfiOv0N8BzA10KQZyFkqGnXW6Sn41Bk1pLXxKIvuHZv0z3XS5LYiDGoxb44v839u3ENjuRlO7WNRw/GftJNlVyJyu79VQE5JwxHri+C5PWhJ04oB+XKRpHRFlIBcpqaVDk8eet+stUFrBVCqBXaEz2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/y6RLca+1pUE+izwcBKQFC3EIrdH3gGzNiT0llCVhvk=;
 b=jaCtiXfZqwr3pqqCMjgniHE8DFGw9lccdJXfo6epX/bo4Pj4RnwvX5LXiPWcNz7W8TiHe0hFPDnmddVIvgL5di9wEtFLveUWv4n5Sv+z0bscNpQfKA8JtR0UyvUtN4jZZCzxQTEx/2b/kUqdY6F+8TM5VUYggK6zguOsSXLJlzqJWR+lQOLUy+kXbmFIThHsj/Av9H4OSKAs9d0snmOE5Hq4Q4deQ7zOuZ6itHK+PYF4ruOwVb8A44od4leCk+MDZWkB3Vb8/G+hE/8VLlVdJlTm+SpT/Pjybf7IpXa7Je715C/wIxcZg2hndOs2xcwQzlXmfgPTwN8gf3J/C0CxYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
Date: Wed, 1 Dec 2021 10:35:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/4] (mainly) IOMMU hook adjustments
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0205.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de0d821f-d90a-4f6b-7c7e-08d9b4adeb3b
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB43848CA953707D4FF676EFC6B3689@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aXbU16S/pWK6fyZg3JnzL+sDP8dR6QYh2EfVFvOpmUyPM/aFBsROWg0oYnpNU9tnFGVEQXgF6naHEWPans/sJhaCYZDv0m0+VsubL8Vc6VgibYEGCbXp/yxQOBGoy7JbqngRlRSW3o5kD61mTZTchsi9NzUjwv/+g436DV6L704pTpeqFjuxFHDwDvAbdyIZuwE4vReC0zC12DcFZygtazAaDhNWwYZOq2E6iUMj4eFezN4gIQKsArxiIaIsw08XcL647j/Z+8VFNMzLCfHQ7nij2ilj+ywVEwQAS7p/V9Ifx4Rxk9f6Pa/XjJpMNdyLmfOsrM2JBKS3PlQtE6j6Dj41x01tU20duiZHU/ehXxPPxRjFstQGK8ODFMdg0xvy8eYvQHTiVvESSKRiLBznxCumEvYhjcvTASlDMGf23LLr77nDKYLGEH6x7CqmMQTP3awj6QsgwzUJzLHcEaV3FVDOwsxi1csRtmG2RbFVemXf77lTkJPHsx/Asr4fgTyKV1vBwlc0ClbhQFKVjwPRjefogxwifPwxaOK0r+bCfjBxWWS8yoFpJHEXQQzEd6APSDv20z1yajQicBNJK9Hgai+dvAaia+ugC5dAXyaReAEDstGVMR2AlxIp5f0qCBfCBy+X5FU4fZ4JXwejRtyC4nkudfJ8cjkNZgPazI7m6p/gsE9hRBcrVgtuC8GzxWFtF1CGyXse7QVrbRf/hcZc+VUDqlDRPKx7kRFVs6AUBlM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(5660300002)(2906002)(956004)(6486002)(2616005)(4326008)(36756003)(8676002)(186003)(8936002)(316002)(26005)(16576012)(31686004)(66556008)(508600001)(4744005)(66476007)(66946007)(6916009)(54906003)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZWM4eVBocjJqUE9yYkFWSEh1bWd5eURUUTlaUEZmWGxXVGVqY2dOWTAyRGg1?=
 =?utf-8?B?dmxWSUhKK1l6RFBkSlZOMmZVS0o4Zmk3SlRkU1ZpaDhvRURoSU9ReWpxUE1V?=
 =?utf-8?B?aUlrMmpUSnIydC9POFA1R3VwWjBxV0J0ZmFYUGY0WVdiN1k0c2RJNVIrN3Z3?=
 =?utf-8?B?TWtkTGZBNERubjAxVld4Q0Q3TFNaNS91eTZwL2ZRYmVhU2hKeUl4SnhFUTQ0?=
 =?utf-8?B?MzRDa1MzS3Z3QUQ3SVVYT21GM2NaNDFQM0pyKzU1UzRORlk3NjlwRmt0Kzlw?=
 =?utf-8?B?RWtub2FFbE5CSW1ROXBBaDdaeitXb0pTMzFHRkdvdlFPaXdic2FNZkRJZWZN?=
 =?utf-8?B?ekFlKzJIVlh1S01GSXQ3dUt6RjJyNUxueVdkcDUxemx2ZDRTaUlKckpPL3hT?=
 =?utf-8?B?bVhHZ1lQZXFzVDNNOXlkTWNkL3JTekJBSlJZYTF5Ym40Mlg2UnNrVERlU0dN?=
 =?utf-8?B?Y2xpL2tIN3kzdWxpKzVVQk8yZXRuQmE3ZTRsL1ZENTRjOVV3MDhrM0QvUHpY?=
 =?utf-8?B?ZGJZZzhyL1ZNemdSM3ZtNVY4Y3VPWnJqWWFoM2R5REIrQVdMNG8rNkhGV0I3?=
 =?utf-8?B?WnJTVHhzSnBINEJTeHI5TnU0bVRKSnlwdnEyOFBDZ3l2ajI1YXNPU0FjYytz?=
 =?utf-8?B?dGdzQVZFR1BzZzVCcHJtYWJsQUpuV2tLZVhsOUJjamRnbXVmTUFoTzh4M2xR?=
 =?utf-8?B?YXJkWGY2bmY0aTdEZ04yYUtYUHpCb1pXVURHd1R6ZDZmN2ZPa0hPUDEydVFF?=
 =?utf-8?B?QjJZcmFhR09INnF5UjNINlVGSmdCRUlyYVN3S0MvQWpwSEd3VkJ3NEY3NXBr?=
 =?utf-8?B?K0d3Nk1xL0VsOExiTW80TDY4OElMbUdBL1E4Rk9kUXdlY29VdTJLNDlIa0ln?=
 =?utf-8?B?enRRTzVkSUcxNFhkZTB1SzlHQ2IyN3ZLc2Q5VXlRMkFyV3hYS1NzcktzK3Z0?=
 =?utf-8?B?TXQzM28vaU5IeE50UmpDdXNFYzNGa0lqVUZ2NHRsWk1ZazhRUGUwdjJERDJO?=
 =?utf-8?B?RklZV01WWHZZV1JpMTA4ZzlDUklPclZGRENiR0U2MlNFNlNmS2VyYS9XMk5z?=
 =?utf-8?B?UWlDNnZ1TDJmTWJWQVJFM2FQWGYrUDVVc09WSHVDMysrajVRMkgyZDk0Wktx?=
 =?utf-8?B?YXB0RTRoQjB3MVM1UGNBNXg0cFJDTkxtMWVyRFNQbDRiVW5pQUM1UURTUHdD?=
 =?utf-8?B?Qi8yMkZBbEIvTk9wd1FBNkZtbUlRNjdING5IbkZJejU2eXhJcWFLaGZNL2Na?=
 =?utf-8?B?WlJEK094c3hSRGNiQkNwbXAwWmJHT2VkSmRFZWh6aWYyeDh0NUpBQmxmRWJX?=
 =?utf-8?B?WndoQUIxZFJ3N296TE1kaGZWWlI5OUhrMXZNc3MvMDhmbk9XQUlueitJcGNr?=
 =?utf-8?B?elU0UW9wM29wVGtxR1M4SkRRQXdDYkhHWTc1NEhzK0NzbTIrYXZQc2FtRE9p?=
 =?utf-8?B?b1lrcHVrbFBHS3BMb3J2NkdPMlpqNmQ4TzBWNWxDbE1QRlhvNVFocjdCSS9G?=
 =?utf-8?B?Mld2L0FRcWd5ZXVkeVljSE1oT0MrWElUTTBpSEdkbzhic3d4eGsveWlnUzNh?=
 =?utf-8?B?TnVHenpsSFlocnJ6RkhpUXRLTEF3NU5TVWlKWUJFTWJCUC9zS3hpVW1NaWxz?=
 =?utf-8?B?UGxpY0FRWXlSUFpjWmRKREZQNWlsZlljSW5iMHhXK0dJS3pBNzRuNnFmSUc2?=
 =?utf-8?B?Q3JFMzRkRXAvd3g4bGIwWWlrQ1ZIV3JkRmhVb0lVei9ZUlc5UVI2QW1DUWZG?=
 =?utf-8?B?ellydStOYWt0RXljVGluNW5pb3FvMUMvQzRQUWZQVWFNZUdWRVNhTkNsd0Fn?=
 =?utf-8?B?d2plMDU0ZlZIWEJGUSt0TUE3aWlQSHB1ZHRLYmR0eklhdHEvTy9VcEJRckhz?=
 =?utf-8?B?REZ6M1VJc3JlbUtNT3lvY1M3WkNGTnQyMEpuTndLbWVsMEtwR3MyeGRRRmc5?=
 =?utf-8?B?RUx3R0ZQa0xSS0YxWHlZSGN0bXp4ZVlTa3haWkQ4VjdUbTNRZkhlajJhbFFa?=
 =?utf-8?B?cmRIdjRNem90ZVhtUkM2WmVubUNQVTFDbGdqQUNOMmtZSkx0NDV4SXlyRUti?=
 =?utf-8?B?bngrRkJMZlg1aENMZ1pYZHcrQi9nQkJqRThnSDFhRmNwR3pXdDZCTW55Y0hB?=
 =?utf-8?B?L3VTODI4anJDcWtOejlBSXRTRE8ybFdYWHJtaHJ0dGRWcE93Z1M4WDU4UjNy?=
 =?utf-8?Q?RKqQkTkNMzoCYSQbmfxbDk4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de0d821f-d90a-4f6b-7c7e-08d9b4adeb3b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:35:32.0201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y7O7TZDzASJ88sL3WxzqIlhcTr0AAhl4gtqoKUPoYORy4rQKO+ZA0o8w8E4aslQkqTkTMFeOI/LBN0N8VDuSYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

Besides the altcall conversion, some further adjustments appeared desirable
to do while touching that area.

1: IOMMU/x86: switch to alternatives-call patching in further instances
2: VT-d / x86: re-arrange cache syncing
3: VT-d: replace flush_all_cache()
4: libxc: correct bounce direction in xc_get_device_group()

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:39:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:39:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235729.408904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM5P-0000Xl-I1; Wed, 01 Dec 2021 09:39:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235729.408904; Wed, 01 Dec 2021 09:39:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM5P-0000Xe-Eu; Wed, 01 Dec 2021 09:39:35 +0000
Received: by outflank-mailman (input) for mailman id 235729;
 Wed, 01 Dec 2021 09:39:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM5O-0000XY-JF
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:39:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 170d4911-5289-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 10:29:17 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-7O7W-PZXMeWOS9AHgo4S4A-1; Wed, 01 Dec 2021 10:38:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 09:38:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:38:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR01CA0058.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::35) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend
 Transport; Wed, 1 Dec 2021 09:38:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 170d4911-5289-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351516;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PRjudJYaDJBTDEpmDQGWloSQtoD3kcm4WrMbo4YMq/4=;
	b=mRJ6L2GC6ctkl8U1bxqjom9Be4U515CG6zjYEAbKrSK0+NN1Uw3jFV9hAr++8z+KkFvXkz
	nYLzDkwiSUSLxyY1XHnLn8JpUQ9mF2qrm2K9vUlvB3gVujrCgi5LBBaR0B0mRxSuNjLy1z
	xHYAOWVzzMhc+RMU93UeK70CYXrHWGo=
X-MC-Unique: 7O7W-PZXMeWOS9AHgo4S4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mpQXvQo9hGLQi4ufHTvYiOO6iHVN+sRKvoMcReaSNEKMdK4hDFHvACKD/fNveiCwW8eUbVsBnx9T6d5PA7CpQhhE60YMdirnfGHbSob8PSTOpICo8zE95MEoB+KjNTsweOIHyucCzc5xCk15vIR4Eje4+zKZuitiGwnFHwas9O/WhyL8Q/PchHqEHXwPqGIN7ciBWpbSaHyc7mRIRRWBesLmjNsasXgWbLN4lVestFdl57G9M5WqFKtP3BGMXxwQ9U9B8jAC+P2NkCOlAl4ApQm+zV+N+D9ReHDcE+5FK+adr8O+pQ7kxZLidB9D52S/Dgxcixs4leWvrECKvP5P8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PRjudJYaDJBTDEpmDQGWloSQtoD3kcm4WrMbo4YMq/4=;
 b=ZaeMJcl/AiMgaqvZc/MJSaWxK17szQOn/tY9vwTw1uKYWowa5oe3pF1ZdpAzLJUiQhJPXKZJa7LuOqaLvB14cKb+oGBvGCPOMlWOk6swE4dtENy84igCTxZ0hDSg7zEwqjxv/JIZaUb/3qmhDKbZvN2yei+GhP0L1dWPju006yWY2WG1bxbwXA3gSlPzgDt0comGc8diT9hZ/XcxxPd3VsaShMSU4aIFF8WjWjgrvo/zj1ZLyzS2nhcdwsNIwQCnRKlkdgsSqKXVmNovU3aV805e2SRFFe56z+RTRr/B1C9EbKXR5GqWEuEB2brx4ahDvSWqfEDHLFYrT8WQgdS7rg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3caf216e-95dd-97e1-b380-a31f5388dc86@suse.com>
Date: Wed, 1 Dec 2021 10:38:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>,
 andre.przywara@arm.com, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
References: <20211130181238.5501-1-ayankuma@xilinx.com>
 <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0058.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a315ca66-986e-4c04-83e3-08d9b4ae5777
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3934CAD9344BB5405775AB9FB3689@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OQMgoa0cvT8cipMsfIANgMGncJzcZobOrfAwbuEZwWj6oXJ9+rBCCFkGJxmbz2LDvP5xf/trv9RimdiNPhZSq7OhCoxihFXspyA0UxVcGm5S587g3wxI9Y9j8haVKaGn66TFu8ypJVyPGQGl17a5qs1k1sCHH7zPRLrUk7dkmrv4eKEFaE+/PpNzuJZwVdknDa/L5BUpcKXtLGr+lmX5wR89sTJC/COsC7ni2ruZ9hwu39sEr+IvWgUm2CchS++w6L0aqJvrWTN6Zqds85ZHeEvYWq5n9uzNXBi0R812k7E6TE/VjQR6d0PyTblFNoifnEEVw+8Mdy+okuQOAk4HJoC94Qo15gVU5QyatLQeC/az+lG0Aofd+fXts+7l/6FfhkT8iNgHvskyLLL02RFXpwTerpFagytxBcTLxzpOOfaqnCGrb1iMFSWXx3fwcBIupO98kFfHu5bWY72VIJlN2+ZXtp9gNr2l1w8l+9n81dyhxezvyT29NsPpoGfXRWKC6rTEjf86U7X1rjm1+5aZHfawHWu0Ntd7xx9uCOAVaamAb++0hzOfPeG2u8VC8HmEp5T7a427jUMWHrdbFh8qjQvATZsLUtKUYn8WZWfHtNpYs/ENzZ4Vb29xbZwMhM4RqmHdM8nCGhuk1dnV/UXElu8rKa3tdRtKv/dxipfYsUQoLYD+0T+sjHERzzDKWVsmm8FJzP7ESZrh4+t6KDSIzw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(86362001)(31696002)(53546011)(956004)(2616005)(2906002)(186003)(38100700002)(26005)(31686004)(83380400001)(6916009)(4326008)(8936002)(6486002)(508600001)(5660300002)(66476007)(54906003)(66556008)(4744005)(66946007)(8676002)(16576012)(316002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2x6NUE5Q0FIM01iOWEwNlhGVFQ3T2tMSFJndmovKzZJN2RkdU5TN2dxTklR?=
 =?utf-8?B?UWxvYXJmU2NpbWErT040KzRYZmNXdUdnT09vOE9ZOTdGY01HbzF2TkRlTzdF?=
 =?utf-8?B?SHNxSkJrQkZBZ3dDUlN2SE1RZXVQUVpwYzJlVmg0bGdZbFdSaTBOTVZCZkZG?=
 =?utf-8?B?TXZPbGtmYjl1a3k0YWlyWklTZGFuSytRVHNuOWh1cVNxSS83ZWtiOHl1WjVN?=
 =?utf-8?B?eFBWL283K2cyRkhwcXdQaFA4TG1SWU84UjdIdDcwWXJXUVcrSjhvNkhZZUE4?=
 =?utf-8?B?cnNxZWlYbUszSk10R3diYXZLRS9ld2dFOFdTa2tISVhaN3dYYlJHTDFPbStH?=
 =?utf-8?B?SERiTXYwZzRIb1pRVWVIYzZ3bXdVaDViMVd3WTZJUWFwYmt1VlVybFRxUjRC?=
 =?utf-8?B?T2dEejRST1RBNlUrU1hZclZQK1FaMHRIOFhuSnRmTngrL3VRbUxyZkdrS2NI?=
 =?utf-8?B?cUxYeTFxNWxIMCthd05VcTgxNGt4NTQ4S3ZwcTltc2VjblFnRFVxdnFhcTlv?=
 =?utf-8?B?aTNHQTcwQkRQUjlwaVo0bzNGSzNUaVRpRmgwMFRCWitkZVh1dzE0LytoMTdq?=
 =?utf-8?B?Yk9EVjhTNlNTYUc5N2FvdFR0ZDVCc2lZd1crM2ZlTUliTWpWK0ZXVEY0QXMw?=
 =?utf-8?B?K1NvUkdTcVVmUjdWTkZJWHFBQnJ2ZDh6a04yZGU1eTU1UXp0cDFtZnhTSkM2?=
 =?utf-8?B?YkpCK0xMYTZzc0w4cERRKzBIc3JHaGVPZlluTlhnRHpCQ2oydEFNRFRWb0hC?=
 =?utf-8?B?U3o2ZldBdXJ1dkVlVklhT2svbE9NK3JjWVdlVmg0UEZDTk8zbHMxL1ZaUjh4?=
 =?utf-8?B?N2tMYVo5REEveHh4UEdPd1AxZHk0WWkyMDM1K3B3K1hjaVErL3ZIaU1odzBJ?=
 =?utf-8?B?NjRDZzNzSWJYQmJQaGNyb0hTWXhqcDhHcVlRQWJEam9aUGtBLzN2M0tjWmda?=
 =?utf-8?B?Y2dIc09QUEQyY2IrR2xQZ2VESTdvRTRwZVJDc3p5VEx5cmcrendmSFpYK1Bj?=
 =?utf-8?B?QVdKYWZWbmpJRVdJT2RVSFBKQVdJMzdqekhtVG5aMEMwUzBnT1hwMTQ4RGxa?=
 =?utf-8?B?M0dMQ0ZzNkpxQ2dBcG9TV1ZZVDk1UGpicW5LM3ZGcFRsYTZrSjBwNWMxOGly?=
 =?utf-8?B?eWx4aGNBUjlaNW1XbTg0QXNucDQzcFFpUmJWSy9GeDVXZWRHN3lYVHhZdjMv?=
 =?utf-8?B?RzdHaHdyVzJ6Y24zcnp3R1ljWUhHNmE4M2N3c0QwUmxYeFd3YVB0VEhjQUVn?=
 =?utf-8?B?Y3BXL2xCR01QTHoyb3lKTVlmTWduYjBXbi9RcTBFU0pUR2tUZURtZG5nRzVT?=
 =?utf-8?B?Mk1WZU52VUNBZjFhcFAwWkFFdE1seEZNSzV4U1Z4NWJtR2NBMWZQcTY3eWRo?=
 =?utf-8?B?MjlzZWtac3F4MW13cHluQzNJS1pwUzZhWDVUU1JrVndkNlhJZDVXUWF1REox?=
 =?utf-8?B?OEJiTC95RG4xZ3lTakQ1S0IxZE9rcG5nRTlEU1FZVEZqWkg4ckNrNGdmZmxH?=
 =?utf-8?B?MzJIVnVpb2d1LzZhN21aWGtDQTNaZUtQV20xWm55WDcvSUJ5QWxtY04rTEtE?=
 =?utf-8?B?SGljd0pGYXZFREZ5UkNpdmVFeE5MMHlVUGphSHdxQVZ0aTFXcDdZN3hvbkp6?=
 =?utf-8?B?aHkxZVE0ajYrUEpPSDNXbks4U052SjNiMlJhTzhldC9nakVpcFFLYjJXQTRI?=
 =?utf-8?B?WmhXRUUwbHpzakFRZCtVK3ovMzQ4UW5KRlZKbkpsTE4wWjUvYXdrZG1zRjJD?=
 =?utf-8?B?a0Q0cklIaWJjdytsS08vMGdmSVlQcUVIakVINkFMRWpoZ3o4WnNWRnc4c2ZN?=
 =?utf-8?B?MnJHY0p0WHIySkQ3THZjSW1BN1NrYm5UUUhGSjNPNjNTMUxWdDdBTnRJeko0?=
 =?utf-8?B?SUxNYThWMm5kMEFoRnIrc3YxNFZxc2J6c1NFVEtHbWZaK25ERlIyWDdjQUU1?=
 =?utf-8?B?QmJsL2RCS2R5cUMzSUZ5TWc5TjhwQVV3WWxzRjRuaXNSeUpCanpQT1EzTmtZ?=
 =?utf-8?B?eXpYb1drcW44K0QwS2dCbkRxR0pzZmZxUzhsN2hzOW9tU04vQWFDY09HUVY4?=
 =?utf-8?B?UWZBWCt1VDZ3dVFRN1Y3bmFuc242VjlWQk15bkVmWDBVSGVtcXloS0NNUUor?=
 =?utf-8?B?U3YyMVZwWUFwV2Q4YklueGJ4UXdva3RhVFFPWWFPNklTYjZSUmw4dGdNaUhL?=
 =?utf-8?Q?ORMCA6o18bADmOzwrr9I+UE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a315ca66-986e-4c04-83e3-08d9b4ae5777
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:38:33.5894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 05znvFGuJli+Et0z5ZukRvZ4a4ypq7H6gwpGCn8IAnqVNzk8icsnWm+e8ib9+Q5RZYYKxAAyCrjSbxyYMbidXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

On 01.12.2021 10:33, Julien Grall wrote:
> On 30/11/2021 18:12, Ayan Kumar Halder wrote:
>> --- a/xen/include/xen/bitops.h
>> +++ b/xen/include/xen/bitops.h
>> @@ -5,7 +5,7 @@
>>   /*
>>    * Create a contiguous bitmask starting at bit position @l and ending at
>>    * position @h. For example
>> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
>> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
> 
> ... there are two extra changes here:
>    1) The bitmask is now described with 8-characters (rather than 9)
>    2) 'vector' is replaced with 'value'
> 
> The former makes sense to me, but it is not clear to me why the latter 
> should be changed.

Would you mind explaining to me in which way you see "vector" accurately
describe the entity talked about?

I also think the commit message is quite fine as is.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:39:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:39:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235730.408915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM5V-0000pt-VA; Wed, 01 Dec 2021 09:39:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235730.408915; Wed, 01 Dec 2021 09:39:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM5V-0000pk-Qv; Wed, 01 Dec 2021 09:39:41 +0000
Received: by outflank-mailman (input) for mailman id 235730;
 Wed, 01 Dec 2021 09:39:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM5U-0000op-Qy
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:39:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9aa8efd3-528a-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:39:39 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-uXMnin7MPoyxtPgGsd-MBA-1; Wed, 01 Dec 2021 10:39:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5471.eurprd04.prod.outlook.com (2603:10a6:803:d0::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 09:39:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:39:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.9 via Frontend Transport; Wed, 1 Dec 2021 09:39:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9aa8efd3-528a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351579;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IWiLXoypwdsEAY6kyd1+aV8MaMHsKsQSdAXMXWcxPL4=;
	b=jX3XFIAMotZgGXPljnI3EYJbK2FEdpActgapowoaK/Q+bvR5QlSMKZYFCwjqfkLVjcJ+ea
	etfBYh90748paoDIEeU4mQ/iPrSk3A3S35QyNBie3762/ix1TsjRAd11S3vJqyQwgdtXG3
	/zsNW5KfYWiGi70aJjzLPebJXzBLbrc=
X-MC-Unique: uXMnin7MPoyxtPgGsd-MBA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zg1p22ww2Mj8PuxNEd6kVkeC6CIraUD2K+mRcgpoECbqODXaSvtfdPjQm9j82D2btGHDlWdQawNrQgtrDdNOQanFXtbwfSQPzrbSPinN0WAKlfAWHmJeQLxLQ+LXXuL0jioEqPnxDfTvyTR0PFkfb9kP8MqgPrfxUh5VFU0HyG5imqpNJJwLH38pXhsreqFW0bJWP22PSAMRbeY31c0A+on2RUfpopM8oCt3suzG5uK2Mai9JJ7zcjyS0AGbfnRSgnB6N+fcX+1dsPmHW78BbdAVlbjA0JXKS1chYUzkf3rhlblfV6hlzDOKDJHpp1p+Q/zQ/4FC0fzm7f4lLVT1MA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IWiLXoypwdsEAY6kyd1+aV8MaMHsKsQSdAXMXWcxPL4=;
 b=a/VzMlj6WLNbnX7nVqs67SWZgi8drO7Tt2nYQdEDt+ZIn++pnzohHIqMclp0t4supNqPeqBJNExTaYMqokJFxSjtMx1NPwqpJfzm142rHvH/RWjgor0V3V9voQXmhuq3/pRr5bXP1wj/NmOOjOu5XWdm7JhoQgcMeIhaLa/z0qe9eJnUQpQR8IMVnGHEiDLC5+Mspu+UG78PVuBqRK0llAC1zkiCjHCzGd84OBqftLAwNy46wHHjoKz0qzHHtVHNP2R7JOrL58hGLPWFSbm1XNhI0Yd258jBTV6H3GpQjFFIgqgXEcjHvjQFbmcz5MyQOFb7h5R1LN/kXCn+/EB9Kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f7a7ce32-f921-ced7-4699-26f907392eb4@suse.com>
Date: Wed, 1 Dec 2021 10:39:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/4] IOMMU/x86: switch to alternatives-call patching in
 further instances
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
In-Reply-To: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9caa85a3-1e9f-4c7f-fb3d-08d9b4ae7d4b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5471:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB54719C067BD76C4BC167108BB3689@VI1PR04MB5471.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vrXTh9NIooEEuC4eaWqEdhTcoVz9Kh0HZipCq1Cpr5R3Z6Bg7TzYsMqyePa0gIkoDpGzVB12kq60aHCjSzc5O+PAzD1Mpe75hfqm8M+O8OLcs5aGBS3EGoONIkWNCswOt/17KepgGip7FwzeIjNaV8ZPdafFrkR12RqUTVIqRR8GSEmBLLMxhU6WhU5BhN1M8oPhi3NHUZKEcxTEh6m0Jf7CulAvB41KeITAc3p/IAM8ZuyhD7tHUeDPSIx1uNIQHHTbKlWDVaOltj30dnA2JYrINIPxCvz+JoYVKVZz0c7gsfhWRGCVw0Hra1/tzaZowomR/oSZr/f7AM7n8WLfO8wEDiRkTxeKvDkvllBOMc47YLQKmsAdLQLn2+WpnhpLMc7pAPnECimmoEXAdeC1ItNdxGqsNriXDlt7ohUvry+pDy0b9iTjPeY9bAVTfuaBYVaVvPTNtmBb5o6cci5Ex2xIAtHgC3lrE+bN7IeeeUSXRbULqxfPv8l0d4h4+OKwmW+wJtRfK3N5NgyxncwkGuvG/4AwrEF1fv4sV/QkUqZLrcLG5OW3RoNNmWFjs20hSzyO6nBrPGNQYfF0wnjbSi6bpHzwmbGea8mkYD8A27bUpJnzxqXkO6F4xn0S2p77UhXXyx/3vWbowfjVb1qXDwtCpAR5zf4vFlp7lFqse6hSIGZsnMKFRnU3Edk2xGo9uphsQCzCqsRm5KnCVzeNzJ5lJjRE0Z5Y8E+UoGtK7vThScI27ewxO63VN+aWyxtG
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(16576012)(6916009)(66946007)(4326008)(66476007)(5660300002)(508600001)(26005)(66556008)(186003)(54906003)(2616005)(316002)(956004)(38100700002)(83380400001)(8936002)(86362001)(6486002)(36756003)(31686004)(31696002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MkpYeFA2T3FHRjRQL0ZwT0F5Uy8xZ1pIYWhuTStoaWRSR2hMaXU1ZHgyTkdj?=
 =?utf-8?B?Z1ZKVmNGQmh0bzJOR3lnaEIyWEJLeEdoMmJQcmozTGhwb2RTZStBeFE4TTU3?=
 =?utf-8?B?QXdueG04YlVPUGxLaWxncGc2MkZOd2dEbmRrQTlhcm81SmV4RXlDS2pyazFl?=
 =?utf-8?B?cnNGYklDcXBkblNURkdpS2NFbzN4U1JUS3RuTVB5ZFZDTDFlYkVYdHdGSGo0?=
 =?utf-8?B?NlRmeFJOejZIV3dwWThWTUY5ZWMvN0UvcGpqZ1Z5azF0MmlTbE8xYVVTTXJF?=
 =?utf-8?B?YVh6U1orb3ZaYnBNdWNKZytOdlk5TGNtbm1kQnpMQ1pLZmZ2M0pydU94cnNB?=
 =?utf-8?B?cThkQmlXMjV3RTV5M3VwN3lVak52YVVIOVovc3pPaVk5SFVNMlVacFU0MXhs?=
 =?utf-8?B?YW96ZU5ERGJHRUlMQitGbFBwcmo2RVN3LytrWmpZYmxUYWM2YjgvTVB5RWc1?=
 =?utf-8?B?NVJXMkdURTc0dWozNUpOU3EvWGJtb3NrUHpUOWtSNFNhdHhGTW9ldmdjbmg1?=
 =?utf-8?B?NVZ1VXJFZ29wS3JMaGlhMkc4cXpCNzAxM1AzZzNBQjBnK1VxaFY5eldEMStO?=
 =?utf-8?B?Z1RnbXJaK05sWUVyOE05MDd5TzJ6RjFZS0tQOUhZblZtK0xTamVIckNtTFov?=
 =?utf-8?B?MzBrckhHdzFHQ3lMQWlXTEdMdGx1SGZTbHJ4YlUrcmZkYlliT2lRTzhjc3Y3?=
 =?utf-8?B?RktTOEV6VityU0lpU1AzMUkwbDNxd0V2dXNJUVNwNVZZbndMT29ta1dYT2I3?=
 =?utf-8?B?ODYreWt1Vml5dkJJV3B2YkRZMVd5QzdnQ2pPMndibkxJZUtSb3RIdnFNYk01?=
 =?utf-8?B?cGpJRW4rNmZDY3krdGhldDZQay9wUFR1Z1pTSzFiQkJOZjdlcjVBeWdrSnF1?=
 =?utf-8?B?OEZFOHpZeU9rbDhmVFpZUnVicUQvbmh0Z0lHbFl0MkVJanY2dVBlSzB2RWYy?=
 =?utf-8?B?NlRPeEdTbFprZEFDU1VtQnJEUU1RRC8zS3ZOdCtOOTZZRzQvWWgwbzlCNEVO?=
 =?utf-8?B?a0RhMFVhZ3FITi94cktKZXpmNUoyR2RsRlcxbDVxUG05Y0Z3LzBTMUE1d1Yz?=
 =?utf-8?B?UC82NUNlYjlTS250WS9Pb3ZMYkp5dzN4anI0N0w1WHJZZHE3KzBnQnNmSDZx?=
 =?utf-8?B?YzFrZjRwYUpkWVh1QmZtOGdwb3ZzbkNOQjA2YjdzbXQ2aE9FdWZ0TUxZU0li?=
 =?utf-8?B?T1VQM0NLYysxazdiMFJBbzZWdFFEY1ZtOE9sVU0xREtsR2k5STZHVGJFbTBl?=
 =?utf-8?B?dEdtL3VZaDdJMml2MU1pdXhDdFlud01pc2pDM2Z6a0wvSmo3QjcxQWU2R3Na?=
 =?utf-8?B?T0d0ZEsyd1NIZFRoRCticTNMSDk0a051NmZ4MlNOSWFoaFU3aXlmZzhTTktV?=
 =?utf-8?B?NEIwbjJoeWdNZURwWmdQRjNpY3ZPMnE4b0lsd0p6TkQ5NElSTHBuQy9vcXM5?=
 =?utf-8?B?V2tSWWdKeitGQXZLTFBGUzVkM3BlVmdsSkt2VlpkMFVxa2xKT05qTzNjajB0?=
 =?utf-8?B?Y1lUbzFZYk1PNG1RYld4WHNSdzVtYm5CRE8wdys5dWluNjdQY1MzWDBpTmJL?=
 =?utf-8?B?WDg5b0ZTN2tCY2dnRkpqckZSUFJqNXBOeWJ2S3J6dTJLWElvZTFITjZzeGtK?=
 =?utf-8?B?UjFGK21sREZKVVBIMUw3M0RZNEFsNkZ4RmpvSjh1TTBQQ0piOHp1encxb0ZS?=
 =?utf-8?B?T3U5K3I0YnVwMVpueXdub2dLR2twV0FrcXBUb1lYNDY5ZE9peUg2Ni9BZFQr?=
 =?utf-8?B?S3Zydm96Um53K3BuSjNMWm5hMm1KVjVjTzgremdxQWVFNDE0aXNEMW4vZmFu?=
 =?utf-8?B?cm9ab1h5WWFHc3JnWG96OHZya0JaUkQrN2xBQ0VPWDdwdWRXRU5uR0pBNmxB?=
 =?utf-8?B?ZTY4S3JEMHRlRE1JT3o0QU5COUY4VFFkYVg0c0pNUHkyUXo3cVVaOEtCeW11?=
 =?utf-8?B?SlNXNmhFcGtYSXBwOUh5MEFTbTRRK3lWQmZnekUvVWUvRVFnSi9hMVpTMTZ5?=
 =?utf-8?B?clNCamlwNmg0NVBZS2RuVCthSDJIb3VaVE5kNDlmbTVpQ1VWUW1qODNpMHN6?=
 =?utf-8?B?NGZQSTZGa1IrelZNZFFiRVBmZVVSdjY3bGVZVldtcUo4cDNBWVZMZlU2bmlh?=
 =?utf-8?B?RjB1dHlsbjdQSEdxbjUrTW0xMEdJU050MnF5VXBuZkJwV3dQRThaRlU2NEVx?=
 =?utf-8?Q?jeL/Fxeawi5g7ydOQlAH6vU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9caa85a3-1e9f-4c7f-fb3d-08d9b4ae7d4b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:39:37.0415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cA5etbvuCg52XXzDe7gtqaaLdff4JtzyuoC79iWrzq5XE6b4HV7K1/QfHfIFV4iBXJeYSCUP87SBDdD0k6QvrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5471

This is, once again, to limit the number of indirect calls as much as
possible. The only hook invocation which isn't sensible to convert is
setup(). And of course Arm-only use sites are left alone as well.

Note regarding the introduction / use of local variables in pci.c:
struct pci_dev's involved fields are const. This const propagates, via
typeof(), to the local helper variables in the altcall macros. These
helper variables are, however, used as outputs (and hence can't be
const). In iommu_get_device_group() make use of the new local variables
to also simplify some adjacent code.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -198,7 +198,7 @@ int iommu_domain_init(struct domain *d,
         return ret;
 
     hd->platform_ops = iommu_get_ops();
-    ret = hd->platform_ops->init(d);
+    ret = iommu_call(hd->platform_ops, init, d);
     if ( ret || is_system_domain(d) )
         return ret;
 
@@ -233,7 +233,7 @@ void __hwdom_init iommu_hwdom_init(struc
 
     register_keyhandler('o', &iommu_dump_page_tables, "dump iommu page tables", 0);
 
-    hd->platform_ops->hwdom_init(d);
+    iommu_vcall(hd->platform_ops, hwdom_init, d);
 }
 
 static void iommu_teardown(struct domain *d)
@@ -576,7 +576,7 @@ int iommu_get_reserved_device_memory(iom
     if ( !ops->get_reserved_device_memory )
         return 0;
 
-    return ops->get_reserved_device_memory(func, ctxt);
+    return iommu_call(ops, get_reserved_device_memory, func, ctxt);
 }
 
 bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature)
@@ -603,7 +603,7 @@ static void iommu_dump_page_tables(unsig
             continue;
         }
 
-        dom_iommu(d)->platform_ops->dump_page_tables(d);
+        iommu_vcall(dom_iommu(d)->platform_ops, dump_page_tables, d);
     }
 
     rcu_read_unlock(&domlist_read_lock);
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -861,15 +861,15 @@ static int deassign_device(struct domain
         devfn += pdev->phantom_stride;
         if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) )
             break;
-        ret = hd->platform_ops->reassign_device(d, target, devfn,
-                                                pci_to_dev(pdev));
+        ret = iommu_call(hd->platform_ops, reassign_device, d, target, devfn,
+                         pci_to_dev(pdev));
         if ( ret )
             goto out;
     }
 
     devfn = pdev->devfn;
-    ret = hd->platform_ops->reassign_device(d, target, devfn,
-                                            pci_to_dev(pdev));
+    ret = iommu_call(hd->platform_ops, reassign_device, d, target, devfn,
+                     pci_to_dev(pdev));
     if ( ret )
         goto out;
 
@@ -1300,7 +1300,7 @@ static int iommu_add_device(struct pci_d
 {
     const struct domain_iommu *hd;
     int rc;
-    u8 devfn;
+    unsigned int devfn = pdev->devfn;
 
     if ( !pdev->domain )
         return -EINVAL;
@@ -1311,16 +1311,16 @@ static int iommu_add_device(struct pci_d
     if ( !is_iommu_enabled(pdev->domain) )
         return 0;
 
-    rc = hd->platform_ops->add_device(pdev->devfn, pci_to_dev(pdev));
+    rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev));
     if ( rc || !pdev->phantom_stride )
         return rc;
 
-    for ( devfn = pdev->devfn ; ; )
+    for ( ; ; )
     {
         devfn += pdev->phantom_stride;
         if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) )
             return 0;
-        rc = hd->platform_ops->add_device(devfn, pci_to_dev(pdev));
+        rc = iommu_call(hd->platform_ops, add_device, devfn, pci_to_dev(pdev));
         if ( rc )
             printk(XENLOG_WARNING "IOMMU: add %pp failed (%d)\n",
                    &pdev->sbdf, rc);
@@ -1341,7 +1341,7 @@ static int iommu_enable_device(struct pc
          !hd->platform_ops->enable_device )
         return 0;
 
-    return hd->platform_ops->enable_device(pci_to_dev(pdev));
+    return iommu_call(hd->platform_ops, enable_device, pci_to_dev(pdev));
 }
 
 static int iommu_remove_device(struct pci_dev *pdev)
@@ -1363,7 +1363,8 @@ static int iommu_remove_device(struct pc
         devfn += pdev->phantom_stride;
         if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) )
             break;
-        rc = hd->platform_ops->remove_device(devfn, pci_to_dev(pdev));
+        rc = iommu_call(hd->platform_ops, remove_device, devfn,
+                        pci_to_dev(pdev));
         if ( !rc )
             continue;
 
@@ -1371,7 +1372,9 @@ static int iommu_remove_device(struct pc
         return rc;
     }
 
-    return hd->platform_ops->remove_device(pdev->devfn, pci_to_dev(pdev));
+    devfn = pdev->devfn;
+
+    return iommu_call(hd->platform_ops, remove_device, devfn, pci_to_dev(pdev));
 }
 
 static int device_assigned(u16 seg, u8 bus, u8 devfn)
@@ -1421,7 +1424,8 @@ static int assign_device(struct domain *
 
     pdev->fault.count = 0;
 
-    if ( (rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag)) )
+    if ( (rc = iommu_call(hd->platform_ops, assign_device, d, devfn,
+                          pci_to_dev(pdev), flag)) )
         goto done;
 
     for ( ; pdev->phantom_stride; rc = 0 )
@@ -1429,7 +1433,8 @@ static int assign_device(struct domain *
         devfn += pdev->phantom_stride;
         if ( PCI_SLOT(devfn) != PCI_SLOT(pdev->devfn) )
             break;
-        rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag);
+        rc = iommu_call(hd->platform_ops, assign_device, d, devfn,
+                        pci_to_dev(pdev), flag);
     }
 
  done:
@@ -1457,24 +1462,24 @@ static int iommu_get_device_group(
     if ( !is_iommu_enabled(d) || !ops->get_device_group_id )
         return 0;
 
-    group_id = ops->get_device_group_id(seg, bus, devfn);
+    group_id = iommu_call(ops, get_device_group_id, seg, bus, devfn);
 
     pcidevs_lock();
     for_each_pdev( d, pdev )
     {
-        if ( (pdev->seg != seg) ||
-             ((pdev->bus == bus) && (pdev->devfn == devfn)) )
+        unsigned int b = pdev->bus;
+        unsigned int df = pdev->devfn;
+
+        if ( (pdev->seg != seg) || ((b == bus) && (df == devfn)) )
             continue;
 
-        if ( xsm_get_device_group(XSM_HOOK, (seg << 16) | (pdev->bus << 8) | pdev->devfn) )
+        if ( xsm_get_device_group(XSM_HOOK, (seg << 16) | (b << 8) | df) )
             continue;
 
-        sdev_id = ops->get_device_group_id(seg, pdev->bus, pdev->devfn);
+        sdev_id = iommu_call(ops, get_device_group_id, seg, b, df);
         if ( (sdev_id == group_id) && (i < max_sdevs) )
         {
-            bdf = 0;
-            bdf |= (pdev->bus & 0xff) << 16;
-            bdf |= (pdev->devfn & 0xff) << 8;
+            bdf = (b << 16) | (df << 8);
 
             if ( unlikely(copy_to_guest_offset(buf, i, &bdf, 1)) )
             {
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -142,7 +142,7 @@ unsigned int iommu_read_apic_from_ire(un
 int __init iommu_setup_hpet_msi(struct msi_desc *msi)
 {
     const struct iommu_ops *ops = iommu_get_ops();
-    return ops->setup_hpet_msi ? ops->setup_hpet_msi(msi) : -ENODEV;
+    return ops->setup_hpet_msi ? iommu_call(ops, setup_hpet_msi, msi) : -ENODEV;
 }
 
 void __hwdom_init arch_iommu_check_autotranslated_hwdom(struct domain *d)
@@ -403,7 +403,7 @@ int iommu_free_pgtables(struct domain *d
      * Pages will be moved to the free list below. So we want to
      * clear the root page-table to avoid any potential use after-free.
      */
-    hd->platform_ops->clear_root_pgtable(d);
+    iommu_vcall(hd->platform_ops, clear_root_pgtable, d);
 
     while ( (pg = page_list_remove_head(&hd->arch.pgtables.list)) )
     {



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:41:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235742.408937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM79-0002m6-Iy; Wed, 01 Dec 2021 09:41:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235742.408937; Wed, 01 Dec 2021 09:41:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM79-0002lv-Fb; Wed, 01 Dec 2021 09:41:23 +0000
Received: by outflank-mailman (input) for mailman id 235742;
 Wed, 01 Dec 2021 09:41:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM77-0002Rt-5a
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:41:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f5e5d8b-5289-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 10:30:45 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-NBdHqzgHMJyJxrDlCcu5cQ-1; Wed, 01 Dec 2021 10:40:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3293.eurprd04.prod.outlook.com (2603:10a6:802:11::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20; Wed, 1 Dec
 2021 09:40:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:40:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0020.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.9 via Frontend Transport; Wed, 1 Dec 2021 09:40:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f5e5d8b-5289-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351635;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0t8LMyxHaP2kl7/Dbfr610HjSp+BcW6EUg2e2egGqsk=;
	b=R8fOljW83adIBWl0iRe2bxkfwXBsng2Vs2rNIDxwsQbvBS6AOddf1kEPYh5RpCsLwZXLi7
	YxX6CRCdR4lAxNvs5dbxA5Ok5QFuv0iGB4H4fNTrZb9Xpg4VXSvyOVVVzNO2dCvCorm6xH
	ZWveT+NZ9KLDVEyxzeebudaaL0RE4qI=
X-MC-Unique: NBdHqzgHMJyJxrDlCcu5cQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iwHbbjokC0TDYaIwOwb3ZDo0MhQpPxZcg/1TEo2bJ8qCjMuqJCxgYaJpmfgHS4kqiC/jClZRLP5FL7+Hj7xWbE+q4L34C9O9T5exY01Yw0FJEY+cKYl2aDzLVTM7QLcNgKuRjXlo2kfwkgg7iS7Fq1bm6+mnF5MqSckkritbJBbfaEJzODta8QluOEFxgVvRrAmlPkdp+o2p2ExBHmqHuxL2RsimntDNAIt3glh3fXJHeTS01kMOzEHCu28cBGa7y5aJ+xw/xt5E8uYRhi2e7vJLer3ExMF2SXdJBDkLHRYWSzywNdRhLEYo0wGoLZCaWBMRnDOZDQ1wXI4y7IgCng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0t8LMyxHaP2kl7/Dbfr610HjSp+BcW6EUg2e2egGqsk=;
 b=R4n2TTwGvpE08/kvyoNGT1gvUTq7NDs4o3YiO2UGoLLuBmXrZjOq4F45ciFGLrKeSdxwAdEKQ3SBNmQe75XmEChV3izH82Xe/Uy5RBC2ItV7T7ABnaADKmdXr0trp+SatF4BXLRYxEsmVR4nhjjxRlk38EP+5KFeRq1UnqZhvKgzVGrSN//Uq8TwU+bEe1Lz/fa39md/lkL2+WUJYY8qZl1FUDvXpVun5A9F42Q9kOSWseYhEwd6zIrYONeA8Hek+p3Ofq/T+V713hGFjD2G8QpPQhYgiJr3WVlcqz5G8UpSDLFu30VFlkfjBovMgQHdMH9Ye+FfTXPBGd3qUPlm/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e0819175-83b4-9489-8e4b-7be4940f1d54@suse.com>
Date: Wed, 1 Dec 2021 10:40:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/4] VT-d / x86: re-arrange cache syncing
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Kevin Tian <kevin.tian@intel.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
In-Reply-To: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0020.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1b9d5ddd-7e77-4c67-b398-08d9b4ae9ab2
X-MS-TrafficTypeDiagnostic: VI1PR04MB3293:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB32931BACA3F42F3E418BF56AB3689@VI1PR04MB3293.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vbcnGYpe9bLgLDUKvSGZ2hOcp/dEj/qbF95TeMb364lbYxvcz3G7A60zawJ4Bqc14Z3P3N+QGwRTM6woZie41/uzfVwlKmKOIBEKmwOhpKv9gp+FC2MTPiJ1OrkBgGmbDqKNBSpz0HaFbGZHRwZ0gl0VxVkiNa3GGayJ9dOz1Zb4KNcsr0n/g0pKsM8mmeIBo3Gk5U/zBvbrGoD+jrvw09285v7NDkLYamLCSSdr5BtvSLW2ZJgk8/xoJcUJfhei0Y/lL+MxH0KLzkF3HfAbaQleB/2nkMcY+JVgs3MIdyYPT3yx93tzWFidCIMka7B5xByWGRt8iVanpqMwNrIcPnuuZPYtWeddPYpv/bY5kDzf+JpZFqMuD5WLS3lmRHOEx2XVoA+NB7zEtFtyWJSGhK47EI4qUvuYElocdeMfsHP9EsSVEfELoFMWflIliI30PQG6bc2TLjGZtEUgg67W68+0sQ5RmZmPjvzJxSjqiQqI3xTgCHm9VC6/GxspP+2CybP5J03+qwE37ITTRgAAHuoWIqHDVjS648H8YZovovqXQBj9bW7f+YfzBkWhhw4MU61/P90PpcP74BaDnhZuWAQ09Aoy3Ji6mvLn/cZI3CGZpSFbMYUnR24S0qrP7aiR0WUP/QHK3Q5mkPdwFsx4l2LcueAeMzB+EFsr6Wq4g4KeLErvN0IcgClrr2GJO9603QcYhTMC8DiyWJNOV5l8dwrh1k4YJGhGCV0Bu4bMCiqvb+dcApfyPcEbqYErOct9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(2906002)(26005)(66946007)(4326008)(2616005)(66476007)(956004)(38100700002)(8676002)(86362001)(186003)(8936002)(5660300002)(31696002)(31686004)(16576012)(66556008)(6916009)(316002)(6486002)(36756003)(54906003)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?elVoZ3V3dlZ2UlFkZ2xMZFIyOGNUekR4cGV1OUVrVlFGU2crQkp0bHJ2V2NT?=
 =?utf-8?B?azJxcVdYNUpvUjIrWjE4T0IrYVQ2SExRWWQ0Qm1ILzZRSTNvQjV2bXN6ME5j?=
 =?utf-8?B?Zkl5aHNHQy9oT0drWnFHZnF1UENyL2dDRlQ0ODR3ODk3M1haRE9pQ3JpaGtn?=
 =?utf-8?B?VmdlTzRWd1Nhb0twQ0l3RUN2YXVkMjluWDZLMlZKTm1Gb0MreUl5ZnVydi9L?=
 =?utf-8?B?SDNPbDhSYjVXc3BhNy9Cem1EYmllUnZCUDBQUWUzWnRQOVFwUStGOVdaTHhV?=
 =?utf-8?B?Rm84bWZwNGlyWUNaWTVjTHJzMnlOVEVIRld0VEYwZlRFN05BV2VCZ0ZkaEFl?=
 =?utf-8?B?YUtCWHc2WWV4UW1vOWc4Y1NNaC9SNmZvMnhYY3NIR1NaVFBQL2FhOTBkTFJ1?=
 =?utf-8?B?QUZmWXRaRGN6bVI4Y1lWTC9LQVc4a0xLcWJBTzRId2NtS010R0FleWMvK3dx?=
 =?utf-8?B?RDV2aUlIdFhyMnRIa2M2ZE5PSjN5Qk94ZzBNcytyV2RxdVdkM2RNQ09UTkxp?=
 =?utf-8?B?MjhTSy9JcER2d0hnYWJnNlU0ZHcyOFVnVlBpZ3RMY3VIQU01NnVzUW9LWlll?=
 =?utf-8?B?RDU4bGdpbkNRL285b2NPK0NmVzlwVDZ5VitpY1BxOXRhcGs4dWwveDZHWEV2?=
 =?utf-8?B?dE9qbCtkaHJENFNOcjZ2Wm5WYXY4L1NwVHI2TWp3VCs2OUttY012dFNia3RG?=
 =?utf-8?B?dEtjY2MwMWZjOEtvMG9oSlJYSDVYejRuSjhUTDZ3TDF3TWJHYmJ0TEh2cGt4?=
 =?utf-8?B?NEhwa2VXbVRCYk5zUmpwS1JqWTJUZGs3VUViaGVkUjVVVzFJOTZOLzBOT2Ns?=
 =?utf-8?B?Tmd0eDQzalRTeUp4L2dMNnhycmVIVUtzVVFOaW9WRGxaRUVMdzNHMElnVUZl?=
 =?utf-8?B?TytGdmQ3QzlmTWtOajFkczVTV0JVK3JHdGEwVkxRUDM2cVdmcFppYkR4NFJS?=
 =?utf-8?B?WHJxdXBHVFpxUFV1bjBVdnY1ZVA3VFhRMnp5WXdtcFRBd1J5bXVFNCsvV0VB?=
 =?utf-8?B?U3oyd1pBR0w0d3E0UFJNZ0lFSGhHZmYxMVR4RUpBMmxoZFlkZDgrWVV1Yk96?=
 =?utf-8?B?TkRKbEE2b01Yb3dHN0lNNXljSXcwQWhpWVhZYlN1ZHpaMmVmNm1ndmYzSE1u?=
 =?utf-8?B?UVVnTjZrRlk4R1Nrem9pd1FObVc4L2MvYVJIbkl6bDNYOTJ2NDJ5UVh5SzFF?=
 =?utf-8?B?YnpCMW5MY21YNzBrR3g3MXptMjNkalZkYVlLRnAvaWptYjcwbjBka3VrQkE5?=
 =?utf-8?B?Nk0wYVlwaU5OajM0TFlRZUpqVWpYR1JyTVdtLzJHMUpJU25JRGREQnNPMlRC?=
 =?utf-8?B?WlFlQUtaV1hBZk5NeXR2SkJpUGlFeXFOdmh1TWFIV2Q3M1YrZEUxMFZYVThO?=
 =?utf-8?B?REtJUjJPQTVmMlY1Y3dGVHdtMkpadjFpaysxS2JYYytVUFBxRGJmZVdWNTBY?=
 =?utf-8?B?RzdvMUZCbXRJMURDdU1sdC95VzN6V0JVVW1QSS8yazA0SXNocWZpSklTSHEv?=
 =?utf-8?B?dFBpQlkvWU41VEY0STl4SUJ1bVZjSVEwK05kNTNFMUJOQ1F2NTBSdjFDUXRQ?=
 =?utf-8?B?cFg2aUZmcWdIWGNhTG5sT0x1Ykl3YU1Wcmplbzg4NGtXL0dHR3V3V3dFbVNz?=
 =?utf-8?B?c1BBNUVtTmlERlFZUXN5citXWDFMM3pmNVVySVJLNkR5WUNuVnVSQWFDUHRt?=
 =?utf-8?B?Z3pkeWpmSDF6V1MwdGNTN0E5S05wRzd1UkxJbTE5Mzg1OWs3TnpycUNIVXBz?=
 =?utf-8?B?R0lOckRCRERvak1qcjZXV2QyNHk4aml0ZWp1UmVlZVpudHcyZzIvNjVmSHh0?=
 =?utf-8?B?aGd6U2hJc2tyRnlvdDlEY0dpUDNiaDJSZGxQWDZjNU5keWFhV3RXVG5YeFpu?=
 =?utf-8?B?N1dWcHlVM1FRNkhoc205ZlRBTlFNOU5wbk1CS2ZaQ0xwSmJmYllLVk9iVkRh?=
 =?utf-8?B?dE03OHBjMU54OU5RUUkza1Jva1doaVJkVDJ1WW5Oc1hQcXExL3F3ZGRDbHZq?=
 =?utf-8?B?U3hJZ3hmNVUxMmV4VDFtYUNpekIwMXpGdzV4Q0ZqelpERWpXZytlUEdBcER3?=
 =?utf-8?B?NmhMcktoL3lrK3A3bVVQcjVBS3hxWWJpcFNQelVENi9SNUZqUytQVWxRYkto?=
 =?utf-8?B?bEtKNXhhK0xwbFUxY25pcnVnY0JNNy9hT0tubEVWVVcyWWRyL0x1MG1wd1U0?=
 =?utf-8?Q?TAwEg4mRA1rdnAy6TQ7FeT8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b9d5ddd-7e77-4c67-b398-08d9b4ae9ab2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:40:26.3696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Wz+LTp+1WdQ0+SraFh5OHLf18oPjNnt9Vaor7etwSnEJuGV0wXLXc/wAXkC1yrmCEBhEjobtlrO1CpzLCqMJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3293

The actual function should always have lived in core x86 code; move it
there, replacing get_cache_line_size() by readily available (except very
early during boot; see the code comment) data.

Drop the respective IOMMU hook, (re)introducing a respective boolean
instead. Replace a true and an almost open-coding instance of
iommu_sync_cache().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Placing the function next to flush_area_local() exposes a curious
asymmetry between the SFENCE placements: sync_cache() has it after the
flush, while flush_area_local() has it before it. I think the latter one
is misplaced.

--- a/xen/arch/x86/flushtlb.c
+++ b/xen/arch/x86/flushtlb.c
@@ -11,6 +11,7 @@
 #include <xen/sched.h>
 #include <xen/smp.h>
 #include <xen/softirq.h>
+#include <asm/cache.h>
 #include <asm/flushtlb.h>
 #include <asm/invpcid.h>
 #include <asm/nops.h>
@@ -265,6 +266,57 @@ unsigned int flush_area_local(const void
     return flags;
 }
 
+void sync_cache(const void *addr, unsigned int size)
+{
+    /*
+     * This function may be called before current_cpu_data is established.
+     * Hence a fallback is needed to prevent the loop below becoming infinite.
+     */
+    unsigned int clflush_size = current_cpu_data.x86_clflush_size ?: 16;
+    const void *end = addr + size;
+
+    addr -= (unsigned long)addr & (clflush_size - 1);
+    for ( ; addr < end; addr += clflush_size )
+    {
+/*
+ * The arguments to a macro must not include preprocessor directives. Doing so
+ * results in undefined behavior, so we have to create some defines here in
+ * order to avoid it.
+ */
+#if defined(HAVE_AS_CLWB)
+# define CLWB_ENCODING "clwb %[p]"
+#elif defined(HAVE_AS_XSAVEOPT)
+# define CLWB_ENCODING "data16 xsaveopt %[p]" /* clwb */
+#else
+# define CLWB_ENCODING ".byte 0x66, 0x0f, 0xae, 0x30" /* clwb (%%rax) */
+#endif
+
+#define BASE_INPUT(addr) [p] "m" (*(const char *)(addr))
+#if defined(HAVE_AS_CLWB) || defined(HAVE_AS_XSAVEOPT)
+# define INPUT BASE_INPUT
+#else
+# define INPUT(addr) "a" (addr), BASE_INPUT(addr)
+#endif
+        /*
+         * Note regarding the use of NOP_DS_PREFIX: it's faster to do a clflush
+         * + prefix than a clflush + nop, and hence the prefix is added instead
+         * of letting the alternative framework fill the gap by appending nops.
+         */
+        alternative_io_2(".byte " __stringify(NOP_DS_PREFIX) "; clflush %[p]",
+                         "data16 clflush %[p]", /* clflushopt */
+                         X86_FEATURE_CLFLUSHOPT,
+                         CLWB_ENCODING,
+                         X86_FEATURE_CLWB, /* no outputs */,
+                         INPUT(addr));
+#undef INPUT
+#undef BASE_INPUT
+#undef CLWB_ENCODING
+    }
+
+    alternative_2("", "sfence", X86_FEATURE_CLFLUSHOPT,
+                      "sfence", X86_FEATURE_CLWB);
+}
+
 unsigned int guest_flush_tlb_flags(const struct domain *d)
 {
     bool shadow = paging_mode_shadow(d);
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -202,54 +202,6 @@ static void check_cleanup_domid_map(stru
     }
 }
 
-static void sync_cache(const void *addr, unsigned int size)
-{
-    static unsigned long clflush_size = 0;
-    const void *end = addr + size;
-
-    if ( clflush_size == 0 )
-        clflush_size = get_cache_line_size();
-
-    addr -= (unsigned long)addr & (clflush_size - 1);
-    for ( ; addr < end; addr += clflush_size )
-/*
- * The arguments to a macro must not include preprocessor directives. Doing so
- * results in undefined behavior, so we have to create some defines here in
- * order to avoid it.
- */
-#if defined(HAVE_AS_CLWB)
-# define CLWB_ENCODING "clwb %[p]"
-#elif defined(HAVE_AS_XSAVEOPT)
-# define CLWB_ENCODING "data16 xsaveopt %[p]" /* clwb */
-#else
-# define CLWB_ENCODING ".byte 0x66, 0x0f, 0xae, 0x30" /* clwb (%%rax) */
-#endif
-
-#define BASE_INPUT(addr) [p] "m" (*(const char *)(addr))
-#if defined(HAVE_AS_CLWB) || defined(HAVE_AS_XSAVEOPT)
-# define INPUT BASE_INPUT
-#else
-# define INPUT(addr) "a" (addr), BASE_INPUT(addr)
-#endif
-        /*
-         * Note regarding the use of NOP_DS_PREFIX: it's faster to do a clflush
-         * + prefix than a clflush + nop, and hence the prefix is added instead
-         * of letting the alternative framework fill the gap by appending nops.
-         */
-        alternative_io_2(".byte " __stringify(NOP_DS_PREFIX) "; clflush %[p]",
-                         "data16 clflush %[p]", /* clflushopt */
-                         X86_FEATURE_CLFLUSHOPT,
-                         CLWB_ENCODING,
-                         X86_FEATURE_CLWB, /* no outputs */,
-                         INPUT(addr));
-#undef INPUT
-#undef BASE_INPUT
-#undef CLWB_ENCODING
-
-    alternative_2("", "sfence", X86_FEATURE_CLFLUSHOPT,
-                      "sfence", X86_FEATURE_CLWB);
-}
-
 /* Allocate page table, return its machine address */
 uint64_t alloc_pgtable_maddr(unsigned long npages, nodeid_t node)
 {
@@ -268,8 +220,7 @@ uint64_t alloc_pgtable_maddr(unsigned lo
 
         clear_page(vaddr);
 
-        if ( (iommu_ops.init ? &iommu_ops : &vtd_ops)->sync_cache )
-            sync_cache(vaddr, PAGE_SIZE);
+        iommu_sync_cache(vaddr, PAGE_SIZE);
         unmap_domain_page(vaddr);
         cur_pg++;
     }
@@ -1295,7 +1246,7 @@ int __init iommu_alloc(struct acpi_drhd_
     iommu->nr_pt_levels = agaw_to_level(agaw);
 
     if ( !ecap_coherent(iommu->ecap) )
-        vtd_ops.sync_cache = sync_cache;
+        iommu_non_coherent = true;
 
     /* allocate domain id bitmap */
     nr_dom = cap_ndoms(iommu->cap);
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -28,6 +28,7 @@
 
 const struct iommu_init_ops *__initdata iommu_init_ops;
 struct iommu_ops __read_mostly iommu_ops;
+bool __read_mostly iommu_non_coherent;
 
 enum iommu_intremap __read_mostly iommu_intremap = iommu_intremap_full;
 
@@ -435,8 +436,7 @@ struct page_info *iommu_alloc_pgtable(st
     p = __map_domain_page(pg);
     clear_page(p);
 
-    if ( hd->platform_ops->sync_cache )
-        iommu_vcall(hd->platform_ops, sync_cache, p, PAGE_SIZE);
+    iommu_sync_cache(p, PAGE_SIZE);
 
     unmap_domain_page(p);
 
--- a/xen/include/asm-x86/cache.h
+++ b/xen/include/asm-x86/cache.h
@@ -11,4 +11,10 @@
 
 #define __read_mostly __section(".data.read_mostly")
 
+#ifndef __ASSEMBLY__
+
+void sync_cache(const void *addr, unsigned int size);
+
+#endif
+
 #endif
--- a/xen/include/asm-x86/iommu.h
+++ b/xen/include/asm-x86/iommu.h
@@ -19,6 +19,7 @@
 #include <xen/mem_access.h>
 #include <xen/spinlock.h>
 #include <asm/apicdef.h>
+#include <asm/cache.h>
 #include <asm/processor.h>
 #include <asm/hvm/vmx/vmcs.h>
 
@@ -134,12 +135,13 @@ extern bool untrusted_msi;
 int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq,
                    const uint8_t gvec);
 
-#define iommu_sync_cache(addr, size) ({                 \
-    const struct iommu_ops *ops = iommu_get_ops();      \
-                                                        \
-    if ( ops->sync_cache )                              \
-        iommu_vcall(ops, sync_cache, addr, size);       \
-})
+extern bool iommu_non_coherent;
+
+static inline void iommu_sync_cache(const void *addr, unsigned int size)
+{
+    if ( iommu_non_coherent )
+        sync_cache(addr, size);
+}
 
 int __must_check iommu_free_pgtables(struct domain *d);
 struct page_info *__must_check iommu_alloc_pgtable(struct domain *d);
--- a/xen/include/xen/iommu.h
+++ b/xen/include/xen/iommu.h
@@ -268,7 +268,6 @@ struct iommu_ops {
     int (*setup_hpet_msi)(struct msi_desc *);
 
     int (*adjust_irq_affinities)(void);
-    void (*sync_cache)(const void *addr, unsigned int size);
     void (*clear_root_pgtable)(struct domain *d);
     int (*update_ire_from_msi)(struct msi_desc *msi_desc, struct msi_msg *msg);
 #endif /* CONFIG_X86 */
--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -76,7 +76,6 @@ int __must_check qinval_device_iotlb_syn
                                           struct pci_dev *pdev,
                                           u16 did, u16 size, u64 addr);
 
-unsigned int get_cache_line_size(void);
 void flush_all_cache(void);
 
 uint64_t alloc_pgtable_maddr(unsigned long npages, nodeid_t node);
--- a/xen/drivers/passthrough/vtd/x86/vtd.c
+++ b/xen/drivers/passthrough/vtd/x86/vtd.c
@@ -47,11 +47,6 @@ void unmap_vtd_domain_page(const void *v
     unmap_domain_page(va);
 }
 
-unsigned int get_cache_line_size(void)
-{
-    return ((cpuid_ebx(1) >> 8) & 0xff) * 8;
-}
-
 void flush_all_cache()
 {
     wbinvd();



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:41:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235740.408926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM75-0002Ua-AJ; Wed, 01 Dec 2021 09:41:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235740.408926; Wed, 01 Dec 2021 09:41:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM75-0002UT-73; Wed, 01 Dec 2021 09:41:19 +0000
Received: by outflank-mailman (input) for mailman id 235740;
 Wed, 01 Dec 2021 09:41:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM74-0002Tk-1m
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:41:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4e1dd3d-528a-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:41:17 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-9ZBsNzQUM6efcr40Flw50g-2; Wed, 01 Dec 2021 10:41:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3293.eurprd04.prod.outlook.com (2603:10a6:802:11::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20; Wed, 1 Dec
 2021 09:41:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:41:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0085.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::26) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.20 via Frontend Transport; Wed, 1 Dec 2021 09:41:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4e1dd3d-528a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351677;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YQb8+AjKpTlqHxQEbPICVBl2jBxSIOPQK4afq3ep8dk=;
	b=gBL7HPi+uQKtp9dggUR45iAuVuYQvjhOSVm9apdaopdjRqfpJC5P342wKduU5vWwaSgX6A
	bLbNLbjOTygxNOQa/LSjLGweTeaYiSPE1Q/rd2HM6Vc7d/cG62Un7B5ITgCF6FLtdH+8eY
	6KgOjOV97CYNveFsD+vdCD4TOfpKkSw=
X-MC-Unique: 9ZBsNzQUM6efcr40Flw50g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lfoVbzO/ko4dBRljbNZGMp63s2JkDVV+D3nzcuABMVdpmMbCiXb5Ol1VqiDOSRGni2Kn5ShQ2tsxwEmq+EK6DQab6MP/dl8fGLBznyRO/peGaT2HjlZ4txcU9g5Q3v+X2N0JLCBi7qCkug5zxybfXXCoOINLgLuXBVFuoMsYtC1O6ogVPJ46gXdX4x8kKHXMx4bJGOsAgF+17bCEH+z50p/KpdExqzkEdIJqb2b8G/ftW/qdcH3kbvDNB88DV8ee1PlAfv1PtP2+i3aHaiHCne3QSkhm+yeKtz9+H8EFnhgLTO9jG4gYHrAJvAQ1q7ZqTOwiTedgzk4eBd1EeZhPwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YQb8+AjKpTlqHxQEbPICVBl2jBxSIOPQK4afq3ep8dk=;
 b=gynYJcla0lZVDrhK7UGm7GJYTZ+pRvk0SzVH6tvyjPHVS7+tBKORaZc53gQnGBY0gD+oBPXz22APCfKt1V+rLeZmiKmDsk/MKE47xKiTmkFLiN99eYNThK8fPZgqLvmYf3f5JRvsuHIeHagDFLajDkYeNOM6Kov+b1bjPQxHqAIaKh0F7NIR1yTLI5DrcbYDPCbUGM91Uearx/tOHwrAkKb/XDsoHsTqoxWt+83COGM5M5q5J+LEw8EhsYF05n3kaug1BMQB5WZPkWWdslbEfo5TjQfA/mR7g0bJ3iEQJbDyuGAutpcC2UiDP0TCF2V/tnchAkkiijCz6qjPvXYE8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8a8dd03a-5447-bc45-1554-50fb5b6c075c@suse.com>
Date: Wed, 1 Dec 2021 10:41:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/4] VT-d: replace flush_all_cache()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Kevin Tian <kevin.tian@intel.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
In-Reply-To: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0085.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d9fb6998-eae4-4113-c0bb-08d9b4aeb7b6
X-MS-TrafficTypeDiagnostic: VI1PR04MB3293:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB329311F6C534DB6E4E8BE4F2B3689@VI1PR04MB3293.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1468;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LZ10LFIP6hF7O5c13TaJATFutts0Ts5fEnannys3tvE19r5VaeVYtz35XOSvdkQFL4JG8QlMesHrggWvr1QFzywSNnn55Js6CJXyQQzSJw40yosuT8DlBSJzvokRf7QBTbT2C9UYt8SlmGI24OpB7y9SV6puroLmdHNJA64w2icuwna9gJkPlzkF5oc2QB3Hkg/cr/V7i8eRJR871uAfyS5oeFSrC4G9Tp1/PDhF3S0CI4nr8wR1633ZoE5T2bd8EkGRhxEwe+GsugcEMiFaXEpGfzvI/h0edOiug6m4hw38LVA7CbrYP9bQE+F7SF6ptULhLlySU0tEqR6VOwGR3/7KzaoymAwyO9ZCDC/+dwaDYF0nznv2j48TmwCL9Uryh5IduDl+vpx3EHQ2GCb2ru6Ps1wgTe5OTXjAHA78LLHF2vTjiaoLK7sYEvhuh6TMYudyZf0a9Es8uZCc0eriPNi5ORt4edON54y3oiDfxlhPwmrb84XROIb4KBEhuceOWCpqDiJ37TzZpIg2tH/MnUo6iMTaQzZHJ5ExkEFEMO/YeSAZkctuqzyigC6Vha7HW0ntS3uM5a/20xV227iz6D+OohOOQjL6IuX921T4rgj8flMFC6yV7/Az6dT1xLjWf/tWfQ9OfDiBC/P667baBD2BTDhL4fUm/KRwh3Ykh2aKy5FSiEHsy9wrzse1dEjoRui91wn3iYXNgQXAh66txyo/gRM/h8Ik9YpIKaGkpu10A84PoW/mvOAiOBTJbpjM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(26005)(66946007)(4326008)(2616005)(66476007)(956004)(38100700002)(8676002)(86362001)(186003)(8936002)(5660300002)(31696002)(31686004)(16576012)(66556008)(6916009)(316002)(6486002)(36756003)(54906003)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cXl2czd0S1N0eUEvWlMvZ0ZwNlJNNjJhQkpXZ003eGRUbTRsRENkZmltb3cx?=
 =?utf-8?B?Y2U1MEpaTmZ0VldYOU5FVGMyT2VpbHowd2hKZmxnclBQNUNZYmhHY0xxVkhN?=
 =?utf-8?B?V2lOeXAreXVaZG5QVXkxSUFBcy9GR0hnN2ZkN2pGNHpkNmlibkdCdythYjU4?=
 =?utf-8?B?NjhobEowYzhac0l2aWZPREVNWktHRWs1ZXpYQkcvT0dmQkFjb1dndHFXZ3FC?=
 =?utf-8?B?bmRSazIxS2pxUXpBejN5dnE0djdGL0xLMVpldDRTTTAwMlY5NnhwWkdzcVYr?=
 =?utf-8?B?ZTdCRXdDKzdWWjFvTGNkZjR5eXVLdlN0QlVzSFQ0RXIrYXpHZm82S3VqTzNr?=
 =?utf-8?B?Q1ZjdWkvYy9kcVBwQ1J1Zm1vcldsUkhjL0JROHgwem1BdjIrVXZuSEs5NzNo?=
 =?utf-8?B?WEZTTW9jMHpWQndwMkZ4MmVkL2hJRUVFWTJqOVNHOTZuZ3hianlENWI5MndM?=
 =?utf-8?B?dzJHeDFVelNjZ0dBaXRJSkJPUmo5QTBzWllna0ROa0JONkZIMU56UllPZmp4?=
 =?utf-8?B?b2JpQnU5Vk1uR1c3VUQ1aXNJM3RudndnNkxhNFJqUXRDYXRrMHFCT0lCRnk4?=
 =?utf-8?B?Q1RUVE5GanBVMWxOY1lVb3RNM2c1aXBvNUhwa21iSE4yM0hmWkFXSUE4eWNS?=
 =?utf-8?B?U05yWkdmNGpiNnpYcXJYM2loMWFIZ2N4eDVtV0FNcHdZVytTZXBrYzFDVDhN?=
 =?utf-8?B?NTBPNVc2SjJlVXA3Q1VqQkpTMVZ5UVp4dmg2V210emRNQ3JqWGRWRFhidUhs?=
 =?utf-8?B?ak1qTExlUUE2RWdvTThSVHdGd1RINCtJMnVyM2MvZzQyby8wWVArQlFFdDV0?=
 =?utf-8?B?Zk9JVDZBYmE4K1pOT1NOaEJROEFIYTBnaFhrZ2RyNHIxek8wNHI1YmlkT0Zu?=
 =?utf-8?B?N0wxMWRneTk0MW4va0xDVStIQzhaaHZqRVpqT2MrOXVWKzRCOUo0WVF3VlFS?=
 =?utf-8?B?Qmt4Rm9qcHNndk9NTm5XTXFSaE94V0dNS1FPanZJclhZVGtHOXdwQlM4UzRD?=
 =?utf-8?B?UWxLUGZUUVFtdklZM2J5aURYbWdocjBPMXhUY0F6VkNkV1k4ZXdhNlk2Vk1H?=
 =?utf-8?B?RHhxdlE5ajRTbVRZMUwwT0MzWll5cHpmVk1keVNweWtaaFl0L2lVeHFhb2Z1?=
 =?utf-8?B?NmlhbkJZTHdDR3JOVTV3NnlWV1k2OTFOTG5mdU5EUXk5TjlFb1pHLyt0Ny9V?=
 =?utf-8?B?ek9FcitjaENGQWUvZUYxbmFJTnhIYUMwS0tkalJ5K1czOVJrUkJ0R3h1Vytr?=
 =?utf-8?B?Q0lDdGlGSzVCdjZpYUZrTGdUTXFhc0xVbllSQXF6WGZDbUhGbGpkUlIxbGxa?=
 =?utf-8?B?MmRIbGxDL3VVSVUybVAyZTVQNnFGdlJaaXdHVmw0M2Z2Ykg4SENNbFNPS0x3?=
 =?utf-8?B?VXorVFNmUFl5NHJsZEVCZFRlcUkzUU5zNVNjZTN2ZmlRSmlRVEM4VlB1akVZ?=
 =?utf-8?B?UkZBSnh3aE1ZS25OSVp2amd3SmJnWWlGK3NISUVBaUxXREdQd215MjdZRTcv?=
 =?utf-8?B?eURYdlFYMDljZnJJaXFjeTNscTF3ZjVJZTdMNHBQWHNNWTRESkdaMHJvbVJs?=
 =?utf-8?B?V2pXZjJJRGFFZGJyNHBpdm5BYkFRL0RudENhaXVlKzIxcU1FaE53eE1Sc2RE?=
 =?utf-8?B?cGx5Sm1UM0dCOGN4U2ZreUFrYXROZC9YV1J2RUZrZ2xMS3dnU2VBOFZLZTM2?=
 =?utf-8?B?WXZVZ2ZyUHRNUFloYkFyUVh6TFl3UzVqT1JZeG16YjJoOXhiREw4RURBeGpu?=
 =?utf-8?B?VVhSTEFiNlFodkhFYnpTRW9ReExZY2dDb1k2czZoZ1NqMWdYNUF6RXNlKzdu?=
 =?utf-8?B?Q1hNWjhsa2ljb0pXb2VCbnZTVnFmdk5JQ0xHOUp3c29wL3V1RkhRdDdiSlRC?=
 =?utf-8?B?ZG1GN3BtdEtMWWlDNUJyVzBvelZOeWpnZ2R1bVp6Y3hENGxqSDR6TUljT0sy?=
 =?utf-8?B?WGFTQWx0TkhDVzFPdVprZm9IQ1JsVXBMTC9zT2toUG1ZRFpVOU5pMDMyWDlD?=
 =?utf-8?B?Sm1TMUoxZ3ZTdllKODhaVDh6dHFEeG1mRmM1M1Q2RFFta1Y3QlZ4d1NsRzkv?=
 =?utf-8?B?RUxGNHVoWXl6ZHNFcW8zb0Znc1pvOW1LdklqR3g3OGVVc2xrOGtEajZkejdj?=
 =?utf-8?B?b1lndm9MaW5pVWJaV3ZMZTdmSGpBR1ZnTDlqYTFTNXg0TUwvc2N6ZldrQWVI?=
 =?utf-8?Q?n6FJBQ4n/0ad3MkNF9Bd3tQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9fb6998-eae4-4113-c0bb-08d9b4aeb7b6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:41:15.0561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jkV+1HSBmRRzcgFT1KMfSEMMKF2qrKtlOw7kQBLNxSEkFtv99O8lN7EKS6IeqxWO8QztloK4UazqXbSycM74SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3293

Let's use infrastructure we have available instead of an open-coded
wbinvd() invocation.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/extern.h
+++ b/xen/drivers/passthrough/vtd/extern.h
@@ -76,8 +76,6 @@ int __must_check qinval_device_iotlb_syn
                                           struct pci_dev *pdev,
                                           u16 did, u16 size, u64 addr);
 
-void flush_all_cache(void);
-
 uint64_t alloc_pgtable_maddr(unsigned long npages, nodeid_t node);
 void free_pgtable_maddr(u64 maddr);
 void *map_vtd_domain_page(u64 maddr);
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -591,7 +591,8 @@ static int __must_check iommu_flush_all(
     bool_t flush_dev_iotlb;
     int rc = 0;
 
-    flush_all_cache();
+    flush_local(FLUSH_CACHE);
+
     for_each_drhd_unit ( drhd )
     {
         int context_rc, iotlb_rc;
--- a/xen/drivers/passthrough/vtd/x86/vtd.c
+++ b/xen/drivers/passthrough/vtd/x86/vtd.c
@@ -46,8 +46,3 @@ void unmap_vtd_domain_page(const void *v
 {
     unmap_domain_page(va);
 }
-
-void flush_all_cache()
-{
-    wbinvd();
-}



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:42:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:42:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235751.408948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM8R-0003jP-42; Wed, 01 Dec 2021 09:42:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235751.408948; Wed, 01 Dec 2021 09:42:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msM8R-0003jI-0f; Wed, 01 Dec 2021 09:42:43 +0000
Received: by outflank-mailman (input) for mailman id 235751;
 Wed, 01 Dec 2021 09:42:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msM8P-0003j4-KW
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:42:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0686af80-528b-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 10:42:40 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-t941qyhqN5yhiYhLe5q79Q-1; Wed, 01 Dec 2021 10:42:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 09:42:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 09:42:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0180.eurprd06.prod.outlook.com (2603:10a6:20b:45c::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 09:42:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0686af80-528b-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638351760;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yCxKdOv38xfLsrtBhC68T2KY7VJQHeYtb/l3qTS1wqQ=;
	b=AFswq5f2MApeqBz8RKrPYv8wqIFThtqZQStl0hXrup1+ULwuNgnPaR+wO2QEgG9bOzPvYO
	iIvmiP77Ldl5rXJORz6/KVLJ0S8q7BhwWNjlgr0f9ezOI90Ebufgdyivl2BhHnXy+N2S7i
	pIdjyQxy0Jcpitp0nLM5ICQpNfm2ssI=
X-MC-Unique: t941qyhqN5yhiYhLe5q79Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=A1vCqNXhxuJy11f+B+U5t1B/YsF3LFMrnvY1mCw3ESIDUzJSYlbmylwqxICqZ0tsKzeqeZCGZ4Z9+ot/nNEqo7xrxG6MavhNSEF7fUAifiBEcwMRXeM+mKm2DwFGl6B9Tg/3YGoztdSq2nCdH5BtmH799rvCqbzFSEXfJm1Y14O9Vwqsl2rDkpy/muaVfh3eiXr5aBrTXXAXWSBviHN/ql7m2CbFP9rasXUHMsYJ+SGAzFb1+NgtxtT37dBrtH3Gn/YNVufKHDaLh5Eg90uLrzDrryzKz73Mu4wcjRg9H6+AqOnYjgTJShX7GA4XIfdOJFQNoF33VkJmpvdbXCr8RA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yCxKdOv38xfLsrtBhC68T2KY7VJQHeYtb/l3qTS1wqQ=;
 b=fOC+V8VD3lwTebnBrLtgPkNWRDMoywZJFKwty34wmbeXI9wZAA1NkjVqZ+yp5M/i9sMySYkJ+vqAYMhbCLig3ny2SWvtHcE84RY42EwG4lrdxOwxOU+FlCDVBWM0scJZPvgz167iyG8w2RldFgZCn5KfY2X6asDXf1boQA4Rjqw4gyLPCQMEOtvgV1bCaaUbH/faELEc6GOgiJTyEZhwJtWNt46pzWe/a+uviTvQwTETeSlt7hqPYtABPIrwFv3mQzQZLVLSU7ery0dv55WZnMTa2pHjY6z1kOGJbsoeHB02g08wumPc67gfYll3BGiVX1vSoqm0PV//GvjsYNGE5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
Date: Wed, 1 Dec 2021 10:42:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 4/4] libxc: correct bounce direction in xc_get_device_group()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Ian Jackson <ian.jackson@citrix.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
In-Reply-To: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0180.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fd771e5-7128-4bb5-294f-08d9b4aee90e
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55986C46D3AF809E43C12FA3B3689@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JOKdXrSKNWj89xesVVK+HwIBQC1AR5KXsCBIODEjcjcH8L5Xu/rKG7+aPSBr+QVXH1JZQGus8nqlp7L0ywd3V/vlnnzCw3yMwKeTPLoSuN8QXa5uWhWIMtXTfO9z4el7CgVigrY6Sg8dB9SxLsHZirio6KJ7pOqOudz4+rZZaTnAhT/Ei1kADK6X0xBDBW9tnEN5g2glawh92hkblfHxATQ+AjWdRfaUBPwYgNMWtGWqsMBYhkbyUMTf14Z5etzZxbWMggoNLLeVp8tCEBSjC0qL92N8+pNek52QhA+ZqMl3+udZiXVN7kw0ipObigsr3kED3dylq6y8iE7L+RuJSwhqkGQo0907Rd/+hCHar8Rl1MwCtr2Tzr2/ek53wqrSzQxau0FEmggiy0UUFpnnX6D6DphiFydfNyoqkSHCXOjVGToWzN10Pk/CDXU4xUjyJQuCeUJjbClrKnvDCll52PYi+a4DB27cK5M86Xp+4bgwRvG1x1c4NPJzwgpmH9jxi2DGe3NqqjrroKOlT3Cvz36AEhcpB0kn8dSpdaji33GlRlL+Cn3mDOPTEG2vvFgItYL/PVy8lGNLOor4DLOf2hDgfxU+bq/+amUkZhHFkrVfXbkTL/UrV6DdPbRY6U7c7BeoL6E6yPdAHq7Ral2gsBGv1KVLI3i5c2bVjg+DTMyM/L3vTgVAdJM6mDfKsAHVHmm1gnU6dSCl7eBnNa2h417Kri7qqYOX/VTBvZ4JiMo/wdITI+P3+oD+FMge4oPP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(6916009)(86362001)(31696002)(4744005)(6486002)(38100700002)(54906003)(508600001)(956004)(4326008)(5660300002)(26005)(107886003)(8936002)(66556008)(66946007)(8676002)(31686004)(36756003)(186003)(16576012)(66476007)(2906002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q1luSkYvaHJ1Q0NzSThzWWlCSG5nUUg1TUVlOWVRTlQrRy9HenVVWFoydVVW?=
 =?utf-8?B?VUtoSVd0RFNuVWRqUk84Qnp3eFBzVll2M3dMVHNzY2ozbDN3SEF0WWN2akVW?=
 =?utf-8?B?S3BVajVtS0NDT3BSanBycjBodTdaTlByNk9LNytabU9hNFlkUmxpYkZxVXgr?=
 =?utf-8?B?dDZmVDFMbzRMZzRjaDBPZXhZMHBFT3BMWlpVaWF5WkVXZ1gxRnNhb29JY1JI?=
 =?utf-8?B?eVpnTGNSc3VMVndXRTdrNjZrMlE1Snk0bFExRHc3Q0IyWG5JNjNnWG5OZlpj?=
 =?utf-8?B?ZTI3UzFISWlkUHk4ZGUzU3R6Q1lUT0dXSllUMnpKdnNhNjl4WFV1cEpmSzlX?=
 =?utf-8?B?aUV0QkVwMmwzODN0TzR1WXl1RzFWU1p1bERORTAvb05CMXVmTGdtY3BrTFhh?=
 =?utf-8?B?YUpxTFFXQW5uWlN2VUVHWldwSzBCQk1SS211V21LZmd4UDNtbmJwOTA3M21n?=
 =?utf-8?B?TTc2VDZqamU3MzJkc3VJc1dIb3ROSGo5Y3FoZTBNZVpYUklyVDF1alRwbm1Z?=
 =?utf-8?B?UWh2OVZEdVpoeUwvQUEyWW1zOTNJRnVFOFRxSVpIcWZqNFk0TStFbXR1d3ZQ?=
 =?utf-8?B?RjJsa3Z0Um5VTjVCakM2ODhGbTRLUFJGc3ZRRU9NRXFYRzVnUnBrUHZWWFpY?=
 =?utf-8?B?Rlo1eDczRnlWVXl6RjBaYUc4Z3NBWVpobHMreWRnVWIxQzh3N0M0YTgwdmpo?=
 =?utf-8?B?aXFuSXNlTW1ISXpjTmJianVJelQzSkdEcmp4WDhBNnRaV3VPc1M5dHIzTEha?=
 =?utf-8?B?TkRqSHA1YmpPRDR4OTdLOXZ6Zndxa1orbmgySjlNQUNuTndoY2RBQmxOSnRa?=
 =?utf-8?B?WEROY1lnaUtUaTdpV2lyVDlNcjlxd1FoL0czT2x0WW9CWE5VN1hGRnhhaXVV?=
 =?utf-8?B?cjVMT2txVVdDS0ZkREZ2cXJmY1dJUGNBbldvaitVQW9LNmFuSU5ON3FWMThq?=
 =?utf-8?B?RjMvdFEvTVR1QUY4OGVmTGwxMk5YVXEwaEpwYjZOUit6U1NQMjd2NVM2Q1ZO?=
 =?utf-8?B?VGhRWWZWb3FUM1hkNzVTUElwdWw0djRyc3BkNXp6UkJCR09LOEplbXovUktk?=
 =?utf-8?B?TE5VSGN2L0NnRmIwUkRLVFFkdEY4ODM4YlBJSHBQUHdYeFN3V3AzTVJveTFH?=
 =?utf-8?B?eGxtc1pQTGNwV3Q1ZHZ4aFpYTmxWMnY3bmRRTWc2MGtvVktKc3NnSkwvS1BK?=
 =?utf-8?B?dzErSFd2Z09yTmJTV0xNbUtMWXZXb0Rta1hpTmxLaW1UeGpOeUdsSENvZTFv?=
 =?utf-8?B?RW5GMW5rcnphTDYzNW1ZZEM1MkJNSUJaVjdVV08rdzhiRjMyajBNYkZESmM2?=
 =?utf-8?B?eTlIZ2d4RjNPdHJFWndCd2k2RU85VmsydHl0YzJkYTNWYU5WY0lsQnZDRU9w?=
 =?utf-8?B?d3g2NkU1ekdUdXhaTEhOWWJxQWFXK042aUxMbFArbkRta3U4RE4wSHZCMTVh?=
 =?utf-8?B?K0JwaktlZG1jVjdrekxEWnJVMXFwell0QVo4dmVReklRa2tnR2I4Qk84d3BB?=
 =?utf-8?B?cWhaRDJoTXN3QkU0b1czR1JZUGo0eTBmdXhORHh1aUIrQnBDYUJsQ1FCUHhl?=
 =?utf-8?B?a005UGQrVnE5dkw4RVdLQVFuZGJxR3gvWWEvUkZtbzZxNm9KY2V6bzFPRDU4?=
 =?utf-8?B?YVBGQ3NadDVmMkk2U0xvTG1DaVNqdkpnWVJyM2dYSE9ReDdPVk9BUUhjODN6?=
 =?utf-8?B?NC9vQWdON2xvV2JiUlZTMGtGeW43VmVTWkllVXFCUHBqZGxpN0tiRTR2MVFJ?=
 =?utf-8?B?TTB0Zm9oV3BYOUdFYi8rSEtHU2EwamEvb3dHZURLbmlzVHNHeXp6S0tGOERX?=
 =?utf-8?B?ZDJTWTlyY05nVGxXVEJUSm56STc0SWdTenZzV05WZDlqd1JGUHp3ZFlISWww?=
 =?utf-8?B?SmhQakZsVEZBVXhLdHRWczlIMnU5cGZYdU5Tb2hzT3ZIeXphUTNIVExvN054?=
 =?utf-8?B?eG5iNmEwNytrNlVmV3loNmRCNmpUSUxYNVl1YnZnMXU5UXNoSEtFRmNoTXpk?=
 =?utf-8?B?OGRJQlJZMlVQSENzUVNML1QwSjA2RXAzZ3ZlN0liQzUvMlV3d01jdEpvWmJG?=
 =?utf-8?B?VnJpa3dETFcyN1R1TW5DNUI4ZHZWZ0tBRHFwRmwxL2oxdEFDcHUxKzJTYWpl?=
 =?utf-8?B?REorUmZGSm1GVnRDanVtMnBIRnRBTW1xaFA0V09uKzhLWDBQZWNoc29xbHBz?=
 =?utf-8?Q?nqYeh8iz6FnrSG6suB4eL84=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd771e5-7128-4bb5-294f-08d9b4aee90e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 09:42:37.8383
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IGRmUrEbscc16rKpbJKVNAKJmKOOeYvoadll8FfiVuepf/OxNTuD8NreqB7JXp+qKwqq/o4dlPtPmRm2TdEdrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

The array of IDs is an output.

Fixes: 79647c5bc9c6 ("libxc: convert domctl interfaces over to hypercall buffers")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Clearly the function, including its Python wrapper, cannot have been
used by anything for many years. I wonder whether that isn't good enough
a reason to sanitize the layout of the array elements: Right now they
have BDF in bits 8...23, when conventionally this would be bits 0...15.

--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1546,7 +1546,8 @@ int xc_get_device_group(
 {
     int rc;
     DECLARE_DOMCTL;
-    DECLARE_HYPERCALL_BOUNCE(sdev_array, max_sdevs * sizeof(*sdev_array), XC_HYPERCALL_BUFFER_BOUNCE_IN);
+    DECLARE_HYPERCALL_BOUNCE(sdev_array, max_sdevs * sizeof(*sdev_array),
+                             XC_HYPERCALL_BUFFER_BOUNCE_OUT);
 
     if ( xc_hypercall_bounce_pre(xch, sdev_array) )
     {



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 09:57:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 09:57:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235761.408958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMMK-0005Wb-DI; Wed, 01 Dec 2021 09:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235761.408958; Wed, 01 Dec 2021 09:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMMK-0005WU-A4; Wed, 01 Dec 2021 09:57:04 +0000
Received: by outflank-mailman (input) for mailman id 235761;
 Wed, 01 Dec 2021 09:57:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msMMI-0005WO-Dm
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 09:57:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msMME-0000hY-Di; Wed, 01 Dec 2021 09:56:58 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msMME-0006ZU-7e; Wed, 01 Dec 2021 09:56:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Lz9iJr8Sjd51677hTafpiEnTaUg0E6yjSBhBIiWHg3g=; b=i3xG7jDbODkgnFt6/64ykFOv8e
	vsewmqvOh1chUYRJ8zb3D5GO86+x5gTCmsBHy6RClx7nicw7A560LWYyQwnCRIXjWbwt2sYDRWW91
	l/Lu6kmWTPpyr51jP+RV8aa+nc7qnOedfwLafhDEV0Uqf22l7vya7O+521Wqjn90k8mk=;
Message-ID: <959d50ef-2a4c-8850-4a89-7eff0b649a13@xen.org>
Date: Wed, 1 Dec 2021 09:56:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
To: Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>,
 andre.przywara@arm.com, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
References: <20211130181238.5501-1-ayankuma@xilinx.com>
 <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
 <3caf216e-95dd-97e1-b380-a31f5388dc86@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3caf216e-95dd-97e1-b380-a31f5388dc86@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 01/12/2021 09:38, Jan Beulich wrote:
> On 01.12.2021 10:33, Julien Grall wrote:
>> On 30/11/2021 18:12, Ayan Kumar Halder wrote:
>>> --- a/xen/include/xen/bitops.h
>>> +++ b/xen/include/xen/bitops.h
>>> @@ -5,7 +5,7 @@
>>>    /*
>>>     * Create a contiguous bitmask starting at bit position @l and ending at
>>>     * position @h. For example
>>> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
>>> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
>>
>> ... there are two extra changes here:
>>     1) The bitmask is now described with 8-characters (rather than 9)
>>     2) 'vector' is replaced with 'value'
>>
>> The former makes sense to me, but it is not clear to me why the latter
>> should be changed.
> 
> Would you mind explaining to me in which way you see "vector" accurately
> describe the entity talked about?

This can be seen as a vector of bit. I can see why people may think 
otherwise. However... if you think it doesn't describe it accurately, 
then I think this ought to be changed in Linux first (where the code and 
comment comes from).

> 
> I also think the commit message is quite fine as is.
IMHO, this is similar to when one do coding style change in a patch. 
They are unrelated but would be acceptable so long they are explained in 
the commit message.

What I request is something like:

"GENMASK(30, 21) should be 0x7fe00000 and only use 8-characters (it is a 
32-bit comment). Fixed this in the comment.

Take the opportunity to replace 'vector' with 'value' because..."

This is simple enough and clarify what is the intent of the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:17:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:17:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235795.408988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMgO-0000mY-Gu; Wed, 01 Dec 2021 10:17:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235795.408988; Wed, 01 Dec 2021 10:17:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMgO-0000mR-Dt; Wed, 01 Dec 2021 10:17:48 +0000
Received: by outflank-mailman (input) for mailman id 235795;
 Wed, 01 Dec 2021 10:17:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msMgN-0000mH-PE; Wed, 01 Dec 2021 10:17:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msMgN-0001Af-Ia; Wed, 01 Dec 2021 10:17:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msMgN-00011o-B9; Wed, 01 Dec 2021 10:17:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msMgN-0008VV-AQ; Wed, 01 Dec 2021 10:17:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0WbY4PIPl7fIY/dry9ND7L5dt841BwVJGVqbNJH8RsE=; b=bGTmcGIvme/OPWVhdnMTlxswP0
	I4SDUyNSb3vcr1s3kCnQMhxeQIj4Vhs/6bBvdnXzmpieaWmRf5TE0L6H1mmdqEdOYw4V0h34Pz0xp
	jWJdl3TiJgah74UKfNo+Tw9Q3OmF6OUorKSSGLBxJNORcEbBcUVpeZl8GuHaed4N5ix4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166971-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 166971: all pass - PUSHED
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 10:17:47 +0000

flight 166971 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166971/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166945  2021-11-28 09:19:32 Z    3 days
Testing same since   166971  2021-12-01 09:19:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   5449ba84e9..e7f147bf4a  e7f147bf4ac725492962a501da72f5ab6be682db -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:20:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:20:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235802.409002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMif-000296-Vf; Wed, 01 Dec 2021 10:20:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235802.409002; Wed, 01 Dec 2021 10:20:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMif-00028z-Sf; Wed, 01 Dec 2021 10:20:09 +0000
Received: by outflank-mailman (input) for mailman id 235802;
 Wed, 01 Dec 2021 10:20:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msMif-0001OS-04
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:20:09 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4170fbbd-5290-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:20:07 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50558)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msMic-000QlC-hn (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 10:20:06 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6BF2A1FC17;
 Wed,  1 Dec 2021 10:20:06 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4170fbbd-5290-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <f1a7edd8-c46a-b857-fe5d-b4eaf962808f@srcf.net>
Date: Wed, 1 Dec 2021 10:20:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/4] x86/altcall: Check and optimise altcall targets
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-2-andrew.cooper3@citrix.com>
 <e3bee553-9443-2f3c-095b-4d6151a07c5d@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <e3bee553-9443-2f3c-095b-4d6151a07c5d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 08:10, Jan Beulich wrote:
> On 26.11.2021 22:22, Andrew Cooper wrote:
>> @@ -279,6 +280,27 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>>  
>>                  if ( dest )
>>                  {
>> +                    /*
>> +                     * When building for CET-IBT, all function pointer targets
>> +                     * should have an endbr64 instruction.
>> +                     *
>> +                     * If this is not the case, leave a warning because
>> +                     * something is wrong with the build.
>> +                     *
>> +                     * Otherwise, skip the endbr64 instruction.  This is a
>> +                     * marginal perf improvement which saves on instruction
>> +                     * decode bandwidth.
>> +                     */
>> +                    if ( IS_ENABLED(CONFIG_HAS_CC_CET_IBT) )
>> +                    {
>> +                        if ( is_endbr64(dest) )
> I would have given my R-b, but I don't see where is_endbr64() is coming
> from, and you don't list any prereqs here or in the cover letter. I'm
> afraid I don't fancy going hunt for it in the many other pending patches.
> Hence only on the assumption that the helper has got introduced before:
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Oh sorry - this series is based on the CET-IBT series, which adds
CONFIG_HAS_CC_CET_IBT and is_endbr64().

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:33:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:33:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235811.409019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMv3-0003nt-5x; Wed, 01 Dec 2021 10:32:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235811.409019; Wed, 01 Dec 2021 10:32:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMv3-0003nm-2j; Wed, 01 Dec 2021 10:32:57 +0000
Received: by outflank-mailman (input) for mailman id 235811;
 Wed, 01 Dec 2021 10:32:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qVdy=QS=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msMv1-0003m9-LV
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:32:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08b72f5c-5292-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:32:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08b72f5c-5292-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638354772;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=4/KJDmkV7/fknd8EAfcOPQEXTcR+f4cCCYsBq8ueu/s=;
  b=YmoSyFEUc5+tTsDAbX7JE/Yuxj9nbhh+bhmL8aLRu9EL2ZgX5aOGOz/W
   sgP+b77nLdC9pR8zqE71amaTMD02oNtaRBQHtjlb77mMmxnHXt324swSv
   hxorRtKA0PidgSN32rLpbR3YjO6XBCYA/1NFXzDh5D3XY7+uMlOBu087F
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qVi957F5v/caiGRWMtUnGv1OZt6z9xVthj/Xt0108R/D8+UyGxfKOvfvh52nd56bx+H4d2Lt+x
 TsgYYNZznR6xNGQfJoCAJHYI2YgjLwhSPvg3NqSAhpvakGJbYfzyD4d9BbjSlI5C3IcHko83ZJ
 ozLcJIRw7cmJPgj9BWXQeSDzODlc6nx/d5CtwHxk9px8h1QQW1/y5OUhzCaj042zqI48O0+pel
 pMkxq3CR2ARN8fmq26NIrJ2tJ4hQNECHOu2dfnnwS3qq+wqOZsE18L1/oL47x6tXBiBtXtnCMz
 WyuYNCreV1bWjiSZIxJ7YQ+C
X-SBRS: 5.1
X-MesageID: 58951113
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/BnclKDAEY5QVxVW//Hkw5YqxClBgxIJ4kV8jS/XYbTApGh30DQCy
 WsfXmmAM/iMY2v8L95wb9mwpx8Dv8fdzIIxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Us7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/pS6mhul00
 Np37qeUEgcmL7XIoNZCekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvWbuIYBhWxYasZmJ/TMV
 so1OBVVRxGdYQ0MOX4wOIg1g7L97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibdVYmAOUq
 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdzOjj2e9uwYTYYFrN7Y65xCVzpLmvC/MUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalq1kqXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj71hu+aTNT8D2BN1bQ9xa0bRGp+ZgPc1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zoC75LN8IsGwieRoB3iM4ldnBO
 xS7VeR5vsI7AZdXRfUvP9LZ5zoCk8AM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3a5HXlk4BCbKmOUE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVBhQwJIPXiSKVJAOURGpkbb+zD59zoWhiZX4nPEqy2mhlaoGqtf9Ne5wydLgh1epi0f8rE
 KVVJ5TeWqxCGmbd5jAQTZjht4g+Jh6lsh2DYni+az8lcp8+GwGQoo34fhHi/TUlBzassZdsu
 KWp0w7WGMJRRwlrAMvMRuioyle94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrtZsotfThK2Co4O4KMdEHxJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbiquMIzglgG3mXPV2nBqk5fyuD1MhL8KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+OvVWEpfCBCAlShBIeYnK4gi2
 +og5JYb5gHXZsDG6TpaYvS4L1ixE0E=
IronPort-HdrOrdr: A9a23:wPVCE6saMnthwlu5ZQQkf9bZ7skC7IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.87,278,1631592000"; 
   d="scan'208";a="58951113"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kb1//H2aUxvZ/DZcy4m+XChgUZqyZoTUw+NUPOo9dcO2nZ9kE9C+hBRUJDgCvih/lLOPdaunFWCevXRiTSoGDOkAuS0h4nzce6d/BBzxZEzA+EZVjiYQ8MX1oyHFaWW/oh70XtMQNNuCpzTFD4IfXsW1gkKS9N5Vk4RYeohmYND2PzYZEqDoF/sd3ul+ucbU9ZTAlEi38wiL5B1ajS5XjSeqklnL1ftTDNXxeI8kTwQn1OQToq6c5JhCQqEpjbXPBE0PGsoXJkhSSnb7Na5gPHjVMqyEnsewNbYAXztVVLR9Tzvb1R72/oY49auvP/D5c9IyMTX6b1mf/ggWSQ1BlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=37PyeKgYhvIFssSMT8nrzg8OD9x4odjXUVAFtI4FtTE=;
 b=OKJgCI0xae7NOBLgnMKHmwMNsgWuuOHGI/McJNtmir0Wnq46z747K1l5pDYli06r43zsa4Lb+o/Rq4qG3init+9BZ9NIVVHA/d2w178Vt7Mn6ILWXHIC6+/h3HuPSfGH3N0goFlTE62mzlW4NQfQaijpmXIIt+wCHvn2HHP0ENI/6n+KbRzkEx6M7XGmNtGCONxLI3q5GHkhvLAaTOyaFifg1CKMejhQaWUXVFH5JS5EQj9VvQWGBhEa+M8aWRVQ1BvBRQtlZnagK/BPplT8TOpsHbUpWaCyYAWCzb6j8EkxQcp3O95+06nIPM9uy2ZvIA5i/1XLTgvETQk/OQUS8g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=37PyeKgYhvIFssSMT8nrzg8OD9x4odjXUVAFtI4FtTE=;
 b=mnSSeQIusOo3OyCjP7HksyDJgUJsVmzAvC7aJTcezxtb6rSBzQWaTCbXNBtHhvWPIpJSKOS5fSP0uXX3/Kz8kvTynAWHKnTheRPcpLE+5XEwTPK6xKlUwnTWrw1cRD9dyblKm2ogta7ijX59/L6lpDWwENbqtUDGzESzZ3nhtco=
Date: Wed, 1 Dec 2021 11:32:13 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Message-ID: <YadPLZqfN2pu5SeG@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
X-ClientProxiedBy: PR3P191CA0034.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:102:55::9) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b1a08e7-604c-42f8-dfb2-08d9b4b5d9bc
X-MS-TrafficTypeDiagnostic: DM6PR03MB4681:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4681EDCBA80E76F663051CAE8F689@DM6PR03MB4681.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5spc7a47FFsSGLKJgjEqBCBxYQ1MgIFKQ2GqHpDbfJu8cojaO5Zk5tSZDRsd8HJHbkenB1m3t0qph+WKYvyq2tTeAq7R447yoS1E+zC5XJQqXsvsuf0fjL3ViXQRZBPGoxm3603YZT5O/C7S+H3neqrc8S39O/qmCfMjZbSdyZE/CfceF+Fua0ca7U81asigZx1DKrKB0QO9sGsCQusKHiQNqhkLpjNIPhkcvFXXeSq8P1bbpRHfvudsC/xRaMueclVl0w8FsN638dh/lp1pgch7Lt4LROuThyfJd+5+G7/xL15UaxQtHXRCAOqpJDES8IAwKTaehMu1Nm94bhM/BZaUsLwjlzOmxFi9drunuxqE0odFMc4emtdvIzeBNlFtkm7HpeeJoSKLvD4uAtF+HLsY1rlricfy6vvcauK7Bqhf/2a3a7ToakVxXS7dGJkAAqPEyi82i1R4KP3cFU7qEZlTWbA/gt9PXoVbf7GdK4RLUAI3vlGb1S0sH8SH5hZbbn5L5pJamjzWpGC1OCt8qumjI959zpTohlORjLhbEIezu4UKCuNPyT6+QUE41hQnjcPcoFiLLAkl4Qe6UNQFaeZIevbhsWE68HT0MR2QHAKUYPHcB6DwKzp6sVxFfcP7/oJ0GN8BE7UzJQX9s09Y3A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6666004)(6916009)(26005)(9686003)(508600001)(38100700002)(8936002)(66946007)(2906002)(4326008)(66556008)(66476007)(82960400001)(33716001)(53546011)(186003)(8676002)(6496006)(6486002)(86362001)(5660300002)(316002)(85182001)(54906003)(83380400001)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGFwaDc1WW9Rb2J5cGhuT1h1aXUrM0k2L3d2S2ppRGtsVTRDSzBVN3hiVkNH?=
 =?utf-8?B?SlFKZUoyQjBNMlNOUXlKTVFSRmp0Z1BLcEttanJvalFBeGxKbldBMlo1ODIy?=
 =?utf-8?B?WDVCTDc4ZEwrV0dDTUdIS29QZEZtcEVnaWtHMEkwRmZxVGE1bmdGQXo1QXpD?=
 =?utf-8?B?US91VGo5amJTUHZCVzlENEttWnBXblQrMnI5VnhvQ2U1YVZaSHYySEhRTzh4?=
 =?utf-8?B?NnN6cEVGNERpaERKZGtTTW5IcFBXT3drV25hZ3NpM0xPY0k2aCs3ZTZ3NWZt?=
 =?utf-8?B?RFM3ZGlNU2RCYUF6VTZrc2k5b2pMUy9VcTZnRURDN2tNcm5xUWVXL2Q0b3dI?=
 =?utf-8?B?dDhqNzRzS3I2LzVmSy9QR2VMRXJqRjR0ZVEyTUpIY3EvYmE3UkRhT1ZRaWxL?=
 =?utf-8?B?eVNnUWltRkp1MzVHWGxLSmc3amwveXArczhwTFQrYmc1WmVzc1p5Mi9BZXVm?=
 =?utf-8?B?RDN3M1RMWG80cG10VWhsZ0pIRmM5V2N0NTJUSGpkTkRuYnVnbUxHZ2dJK2cw?=
 =?utf-8?B?UkhxQy8wNzZJMU9COTBXU216K2lhWllkeWRGTXhqUm4yb2FlSWpaaGhTUDFa?=
 =?utf-8?B?TTFHVWdhd2diZC95TDZHN1psRVRLczJSLzJYV0c2M2lBd0hsQlBpWFVYN0tp?=
 =?utf-8?B?ZWZ6K0NGZ0dUMC9wbmtCMVEvRSttZEFlQjVJNnJKRWxERVd0N2g1UGxvZkZq?=
 =?utf-8?B?UEIyc1VMbGZzMkVrQWFjVlMwM1J5d2diNDFFeHpTTzBPRGY4K0JhdEZXaHU2?=
 =?utf-8?B?QWR0NFZhajJRVmwxTzBYS2x0b2RTSHN6b3RFNXRidzNML1FXZ1A5bmRqcG1W?=
 =?utf-8?B?bnBTYXdGNDZ4Qi9KQVJmeU0vM2QxbTdZVkVjOUI3YW5yUUJ4MTVDekFidGw4?=
 =?utf-8?B?WjhiY2svVmJZcll6b016TkloMkZCaWJIakJlcFRzTjlSUU5WV1BIUXFlN0Ey?=
 =?utf-8?B?M0JxZEpURHY5eGJ2NmR1YW5yQWJPZmxRK0xpVUR3U3lSdGUwZWpXMTJJUVZN?=
 =?utf-8?B?S1V3R1hVQXRsbVhOL09uY0pWMnlNeGpDMXFkUXd3eEFyOVRZVGN6bTB3VE9P?=
 =?utf-8?B?YkR3am5LWG1KSTQ5cy9EWDVFaE9MT0M5VjZQTEJQQ1JjcCtwTGZuRFk1ZWww?=
 =?utf-8?B?eDhkK3dOc2I3aDVtZ0FrOFVvSW5LWnM4OHFLd3l4VHFOVENPbVVSR2ZQeDZU?=
 =?utf-8?B?bGVNb0luVk5ETzZWNmdubk9SUEFYTU1WUFBIU3owSTRvMlV6TDQ0aVE1YzQv?=
 =?utf-8?B?eTZwQzR0Q3Q3MTlxdGo0MlBsRjNzcjZMSWJZam9NWjJoQTUrK0ZqR1hheUh6?=
 =?utf-8?B?dE5NV08ydG5Ha1NYZDJ5aXRYMXMvTHIyUml2MUZXc2NQVFlTTlYveDl2VHQ3?=
 =?utf-8?B?ZldoK0x1d1N6bWpsSFdTMzByN1pSTkRDSjNLazVSK1V0cDJDd1RrbWgzc29F?=
 =?utf-8?B?K1YyaUJiVTJudFdVQ2cxYlpVVzZ3Z2Z5Z1VxY2FqV09MTGRldENPdFlvbWYv?=
 =?utf-8?B?RVRZbVVJMnN6YzUrRDA1SWFkc3FpMGZyOU1jTUZ4aS9YRXE4WU8wNWYzaVlp?=
 =?utf-8?B?ZWZNQ1BYN0hEZ3p0SENGcDdna29jZFRiS3k3LzJtZEFnZThacVNYL2hXOTky?=
 =?utf-8?B?YzJ2bnQzQUxwRWZiYW52TzkwK2dVTHRsbjZrMlpqZmVKeTlRL25jVFBORkFr?=
 =?utf-8?B?YThERVlwU1pKRU5Zcyt2Y3hpb0s4T0dNUkNVdjl2QXhMYW1BVDcrY0RBbEFN?=
 =?utf-8?B?dHBub0EwVnRDVTVTZDFTb1RtQXJ0TVZ2ZU90c1l1b1FpTE52a29vWkZWdHN5?=
 =?utf-8?B?UTN0QXVOcDVjR0prOXFhK21MVHRyWE03U3BzQmYvZkJ5ZFlOZlpyRGFUZkZU?=
 =?utf-8?B?UG9hc0FjS1ZWTHcwSm1KRElGUThHUGJQTGZaYm93TEdZV3JDSEpLSHhULzV6?=
 =?utf-8?B?M3BGOHl0YjBRMFQvMXllWEMzOTJPTUYzekdocVBUZkpYbDdJTVZndVk2Skh3?=
 =?utf-8?B?dDZRODRBMXkwUXIwaDh4Y01LWHRsNnl5NEo4Z0MxUTlBNEVmOEdFa041MkhO?=
 =?utf-8?B?RFYyLzNNR2RGYzVnT1RaM0V0Rys2RGg2K01sV2VRVElGRWk4WjY4K1dZZkpL?=
 =?utf-8?B?ZGJwcU1NZlFmVEtFcXU5OWttYXpjUWdnWkp6aFk0elZwS0R3czY5elhmZzhi?=
 =?utf-8?Q?U8pFoSZ6Dd3rNLs3SB0+bWc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1a08e7-604c-42f8-dfb2-08d9b4b5d9bc
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:32:18.6273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LkXHPrtADqNwRXLxE/KdkhyeBO6xeBvflA9gmXBGjj84i1kDv+tMv8qOHJcevHNRHxnvUfrgl4zxE3nRNnuU/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4681
X-OriginatorOrg: citrix.com

On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
> On 01.12.2021 10:09, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
> >> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
> >>       * that fall in unusable ranges for PV Dom0.
> >>       */
> >>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
> >> -        return false;
> >> +        return 0;
> >>  
> >>      switch ( type = page_get_ram_type(mfn) )
> >>      {
> >>      case RAM_TYPE_UNUSABLE:
> >> -        return false;
> >> +        return 0;
> >>  
> >>      case RAM_TYPE_CONVENTIONAL:
> >>          if ( iommu_hwdom_strict )
> >> -            return false;
> >> +            return 0;
> >>          break;
> >>  
> >>      default:
> >>          if ( type & RAM_TYPE_RESERVED )
> >>          {
> >>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
> >> -                return false;
> >> +                perms = 0;
> >>          }
> >> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn )
> >> -            return false;
> >> +        else if ( is_hvm_domain(d) )
> >> +            return 0;
> >> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
> >> +            perms = 0;
> > 
> > I'm confused about the reason to set perms = 0 instead of just
> > returning here. AFAICT perms won't be set to any other value below,
> > so you might as well just return 0.
> 
> This is so that ...
> 
> >>      }
> >>  
> >>      /* Check that it doesn't overlap with the Interrupt Address Range. */
> >>      if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
> >> -        return false;
> >> +        return 0;
> >>      /* ... or the IO-APIC */
> >> -    for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
> >> -        if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> >> -            return false;
> >> +    if ( has_vioapic(d) )
> >> +    {
> >> +        for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ )
> >> +            if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> >> +                return 0;
> >> +    }
> >> +    else if ( is_pv_domain(d) )
> >> +    {
> >> +        /*
> >> +         * Be consistent with CPU mappings: Dom0 is permitted to establish r/o
> >> +         * ones there, so it should also have such established for IOMMUs.
> >> +         */
> >> +        for ( i = 0; i < nr_ioapics; i++ )
> >> +            if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
> >> +                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
> >> +                       ? IOMMUF_readable : 0;
> >> +    }
> 
> ... this return, as per the comment, takes precedence over returning
> zero.

I see. This is because you want to map those in the IOMMU page tables
even if the IO-APIC ranges are outside of a reserved region.

I have to admit this is kind of weird, because the purpose of this
function is to add mappings for all memory below 4G, and/or for all
reserved regions.

I also wonder whether we should kind of generalize the handling of RO
regions in the IOMMU for PV dom0 by using mmio_ro_ranges instead? Ie:
we could loop around the RO ranges in PV dom0 build and map them.

FWIW MSI-X tables are also RO, but adding and removing those to the
IOMMU might be quite complex as we have to track the memory decoding
and MSI-X enable bits.

And we are likely missing a check for iomem_access_permitted in
hwdom_iommu_map?

> >> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
> >>      for ( ; i < top; i++ )
> >>      {
> >>          unsigned long pfn = pdx_to_pfn(i);
> >> +        unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
> >>          int rc;
> >>  
> >> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
> >> +        if ( !perms )
> >>              rc = 0;
> >>          else if ( paging_mode_translate(d) )
> >> -            rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
> >> +            rc = set_identity_p2m_entry(d, pfn,
> >> +                                        perms & IOMMUF_writable ? p2m_access_rw
> >> +                                                                : p2m_access_r,
> >> +                                        0);
> >>          else
> >>              rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> >> -                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> >> +                           perms, &flush_flags);
> > 
> > You could just call set_identity_p2m_entry uniformly here. It will
> > DTRT for non-translated guests also, and then hwdom_iommu_map could
> > perhaps return a p2m_access_t?
> 
> That's an orthogonal change imo, i.e. could be done as a prereq change,
> but I'd prefer to leave it as is for now. Furthermore see "x86/mm: split
> set_identity_p2m_entry() into PV and HVM parts": In v2 I'm now also
> adjusting the code here 

I would rather adjust the code here to just call
set_identity_p2m_entry instead of differentiating between PV and
HVM.

> (and vpci_make_msix_hole()) to call the
> translated-only function.

This one does make sense, as vpci is strictly HVM only.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:34:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:34:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235817.409029 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMwU-0004Qc-Ll; Wed, 01 Dec 2021 10:34:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235817.409029; Wed, 01 Dec 2021 10:34:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMwU-0004QV-IY; Wed, 01 Dec 2021 10:34:26 +0000
Received: by outflank-mailman (input) for mailman id 235817;
 Wed, 01 Dec 2021 10:34:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msMwT-0004QL-So
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:34:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b49490bf-5290-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:23:20 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-7NTm5iTiOT2Ra5UOVdUCfw-1; Wed, 01 Dec 2021 11:34:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:34:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:34:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0208.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 10:34:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b49490bf-5290-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638354864;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=1hBoJ+vcM00ig3TnGPRAkYpQNAf20p1/o9B6CdQj1RI=;
	b=I1xQ4XiCVWwXzyP2jzIa+Kg/dY4oreyLo+yhcVVRP1cl8kmbP4OwlAc2iqDqcnV7N9K44H
	008QlsbyUTMavsam6q8RtMLv6aa5+uNa/n4rJB2k6fn4/j9o1N4AUsCl1Me1S3LIX8gd2C
	ZeMN4DFsmEcjkeXo/hJ6oOQ2i/4kU0w=
X-MC-Unique: 7NTm5iTiOT2Ra5UOVdUCfw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Twx7s1XEWY8PEM4lGdVWNLFyAnReg8XdmI2Z0036eoMU0VFGdDwa37uCCcBVO9oiWdmzIUxw/2Rp+pVPnpnI+Eaqez647xwkfyvhKf0v77tBXxcipIXgvpG8UwjNm1zGU2rRTMwBE5GcmZRc60YYUB8UXzZMXYGwI7LeAo3YnZcHKpV9YKi1YOp3dNI12B4bkFty2CM0+WFeQjhqKVPcpRHMmJj3qyiZPxtSF1y07PDmpHji3ttxpmSL1AR+yANBcYv8lstzFYjKQMVhZGpSyJIeg97XMSx8Z8rioKah7X95nvz/HxNG+WzLoocftfgueFCB3vhu266nrKkWRJA7eQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1hBoJ+vcM00ig3TnGPRAkYpQNAf20p1/o9B6CdQj1RI=;
 b=ZtGGvndG/ak6WX9O5Xgs2xz4xcIlMBaA4AHc1YBjHyWFGkAqL+4gSuI0PhrOFt2QkdIAsDL+dpDBNPgncmznTA9oKAxtAODzuze3u1XVdr3AFxcmcYHcsvU1blAtucUgOgXHH3Pq0mNxJQMUqQX8dTjraDSTrkxx7E4ZxXL7bpc3OLPgNxO2iftvoZ/P24jJYfELkHa7jwTYlgzqyCcBjQ9AASrP2FC2lb+2Mh+GIyl3S3vonftm8fmICjothFbEn89tYBCJU4W7jgAeKRPBafi2513yVCcFkgEagc/8rA2fXKmJMWLa08qjHUtCqoTMAvQYEdd2qG5wvAJHrI4bKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
Date: Wed, 1 Dec 2021 11:34:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86/mm: address observation made while working on XSA-387
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0208.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b0fd7c3f-8fe1-451e-f20c-08d9b4b623b4
X-MS-TrafficTypeDiagnostic: VI1PR04MB4381:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4381497B03AF1355C32A1743B3689@VI1PR04MB4381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:126;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KMQ69jLHJXDaeQkZ03f2Cc55hiOsLK7hSeCnLbmt8MEcTQtrhiZmSTlBB49OeMkd+MmooX29zaYUDDZxDeC21r5p/IBEHiVMRZfQKIwsUm0E8ksgL48unZqPhmjSmXf3dt4LKjZNKyR9tw9H+E05NwTZfCWDkPYxILNpaIGyP9sRWSG1VXyOaiyPPEILYcUK0UVYkyliLYxWV5u7zEq9i6xUuXB6qMFgVkWb6Kpp/0OO6Mgi8U3XM1b5xUu70s6FpY5pGfuE7QidYuKgYAPARZDbBzpq92kYSgI60Gb+OY/FRRWlUQylL8n/XhHN+wYyA1ng3hX5QbtuIM72wLziKWvcTWW6hb5fdeg9j4pVBb08abyuKsgPVcC36ylkn/OzO4Jfv8Fd97ykT08wzCyf9F/mKPeRjqZhYgvpLIzhmlHEDWPZms7LUAgiDGqPBgi8OTD+T9RTGuOzHlTIHpobro+mUMaqom5c9cnnzAcpgwnlWjA0aRojYRqot4M8bLzWhc28DHWXnr+3GFgcDGFhQK6ylqFkX8DnlFgUbLW7TneLiQTv6PgJgQA2wuhLhR7cTsl7y8M38sZBoo1H5zyNFFwXU1KkZi1sGXsFpX68l3jOl5a9bDWUOQwTPkpFn+yeU07aF7CiOK3p9TIJQMXTZS/Y5sjSSyLe8YtOFBNfJhTQm4bhDEgiCg+GHNNgkyPnNV6kOtOuJUUaOfcVCIQIUopCHvOG++TiMXWt2LH0gxo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(36756003)(66946007)(66476007)(66556008)(956004)(186003)(6486002)(508600001)(31686004)(8936002)(54906003)(86362001)(31696002)(316002)(16576012)(5660300002)(6916009)(2906002)(4326008)(558084003)(38100700002)(2616005)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eGZWNlFPQW9jTGZWa3JqQzZUZ3M5L3hyY3FHSGVubzZIY1pMMDQwT09TTXhv?=
 =?utf-8?B?c24rWWJ6cVo0eWtuWEVxdUw4RzdwaFpGWmg1S3ZGaSt4QjhBS0NyY0NramRL?=
 =?utf-8?B?ZzBneWVadnA0UEk2Nk9ZS3dhWVQrOGJ5c2pOekRYOCsvbVM1a1NuQmlUUHpC?=
 =?utf-8?B?emI2NU05Sm5zRE1CRkgvQld3NzlhY2RwcUZZV2IzWU9qU0ZoY24xVXBxQWk3?=
 =?utf-8?B?SlBBZ2JhUENudkJiam5aRUszOU10MzZpUWI5N2Z3dTQ2VmhIQ2RLdERQWXB4?=
 =?utf-8?B?U29JamN2VjFXRk1zL0hIZERPdHByRXgyaml1MTJHLzlxMU15Z3dLZ0dtanB1?=
 =?utf-8?B?Uk5vZnppbEtscjZpOXFPQ2srSThObFNxOVAwNG9HL1dGMFI3eXE0dTFZY0tV?=
 =?utf-8?B?eUpoTk8zeG1ET25uVzMzU001Wm5sRmdNcW15OWl1b1hGYnljTW1tWGhFbEdr?=
 =?utf-8?B?R1dxWWMwUEcveURMKzQwTXc4YWpWUElPUkZBc2V2L1h6UjltTFpXMHI1OUMz?=
 =?utf-8?B?dUw5MU5wY2lqZnpBaUliWTNDbGJZRlp2OXZOTDAyaWx0REdUdjhwayt0ZmV1?=
 =?utf-8?B?QWh0K3RZUG5RWVlmeFJKV25VS3ZzeStjQXp3QzhIdSs5K05wWm9NenM2ZUt1?=
 =?utf-8?B?YksxQTJ0ZzhLUUtyT29EL1A0SjlDNkpyZHo3U1BBaE42MU1CZkVQUXE2RkF2?=
 =?utf-8?B?M0lSWkJ1M0JlTW1Bc2hmNGJmUU41ZzFZcU9xZW9NU3lzay9FZWg0dG93NmhV?=
 =?utf-8?B?QnlmaElocnQxSUYveWtGTXZzdGxTVGwxZXpaV2ZSRk1NN01VZ2o4MUNoS0hy?=
 =?utf-8?B?NEQ0NFVNdER5bjZieFhvRkdxWGwyOG9OWEpVUkV5WWxKNHRsTnRxcUV0dnNv?=
 =?utf-8?B?N0FjY1psVzVqRmRYdTdJSWlYMXlJRUxWL3FJRlNSTkIrT242WElVREpFOUw2?=
 =?utf-8?B?M1h5WGV1UlN4VWZaU0FvS0w3ajQ4Tmt2aVpwNDgvdnNtVW1XdzZuSUk2R04y?=
 =?utf-8?B?MHFDM1QrNkpoTE40MUdZSEhGaGhZVW5rZE1SdUVGdVJFbHZhVGRuLzJlYlQx?=
 =?utf-8?B?czBzYjVwQkQ2MVYyS1VzMk9XSTFVSjhYTHVCYjVlamYweXhnWWgyT3lBUmlz?=
 =?utf-8?B?dHdkbmJMbW82d0JpOHVoNXhwazA2Tkhxd3ppM3RROFd1Wk1meFRpK3Znd0Jn?=
 =?utf-8?B?a1hqMzBHZDN2RHBOVUhGQVpleUpLMHRTMmZsd0duRXlaUEo4Mmk5OGVjVzdE?=
 =?utf-8?B?emxvY1lGekxNanNNQUlJdGRwZlZCSGxtOEJ4RTVXSDRYRzhqTWQ1TnFCVU9V?=
 =?utf-8?B?RWFwdFVXTGdhRERLODdFUmxoTFRHMDZqSWFLd2ZvR0dTTlVoeG15dDljdDRu?=
 =?utf-8?B?dm1NMkc0cmpSd1MycS9Sc2c1TXBFMVJJUlo4dkN3SkxrYWZzZEE4bzRVZkJC?=
 =?utf-8?B?NHpCL3hwMnU5TmIxYTJpYW5EckJuUXR4QmZZbXM5OFdRQWg5akJMSjQ1bkZh?=
 =?utf-8?B?SktTSlUzVFBhNmRzb2d2R0RnVU1kV1o0eGdyb1l5ZDd4YVJlZDJuK2N0eE1t?=
 =?utf-8?B?L0Q1d21yVVZNQkxMUyt5alErVEtDYWtCM3NWczlpdHIwbEw3blArQ3ovRVBz?=
 =?utf-8?B?ZzAzcGNFaG1tbm12eDgxSFRBOEcwQzRuWmw2UFdOcFk0Mk91ejQ3d1dIcjZV?=
 =?utf-8?B?ZVhLM0ZPdERldDRyYnFjK3lWVm14eW1RSWVPU1dXQ2ZyZUE2dFZ3bXFOWUVG?=
 =?utf-8?B?VVVqN2U5YmtXM2RvYmxob3RLbURFLzg3MW1CUVE3UUMrTDdTbjZQOTI3MWVJ?=
 =?utf-8?B?aVBLZGNkZy83R2QzNXYzT3ZpSWtnTE5OSmgzM1dkbHdaWUFhRm04a1dCSktI?=
 =?utf-8?B?ZkFOTE5OTjRONXdkZlBqbjBWcE5GeG1Wb0FPOVZncVBtQmFJaUlJdGtXcnox?=
 =?utf-8?B?QVB6SkZMaW0zQ3RLaWcyU3FxMzNwb0RDMlFPV2xTZnNhTnRrWkV5NzI2TUxn?=
 =?utf-8?B?eWhpNGRmTmlzbExsY1hOTkk1eG1uaEFIK2RhTXkzY2pQVTlzUWMvQjJKZzhC?=
 =?utf-8?B?ZGM2Y3VwcjNGYW5OUVIvUnZKckRoTytOd2ovQXdnRzIwRVRSY0h5MzZmYmZw?=
 =?utf-8?B?SEpYNVpudnI3TFcvcDdLR0h5TG1ZSUFOVnJnb0tCb2wrR0xVKzFmSTBTcUhQ?=
 =?utf-8?Q?e7+QkbktjZUuLZ7JGewYc6o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0fd7c3f-8fe1-451e-f20c-08d9b4b623b4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:34:22.7613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ny295bYyWUERl/P1CJ+KK5R0rQK0dEge9kBaYlMIajoRE7FiiSfEc9HAw1ilrTFDNAnzvKYxpZHbeEpt1jFOzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381

1: shadow: defer/avoid paging_mfn_is_dirty() invocation
2: paging: tidy paging_mfn_is_dirty()

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:35:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:35:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235823.409041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMxP-00051C-0T; Wed, 01 Dec 2021 10:35:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235823.409041; Wed, 01 Dec 2021 10:35:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMxO-000515-TJ; Wed, 01 Dec 2021 10:35:22 +0000
Received: by outflank-mailman (input) for mailman id 235823;
 Wed, 01 Dec 2021 10:35:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msMxN-0004wm-Ao
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:35:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 61fa0950-5292-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:35:20 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-z4X1OmauPkigwr8uNN8wvg-1; Wed, 01 Dec 2021 11:35:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6175.eurprd04.prod.outlook.com (2603:10a6:803:fb::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:35:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:35:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0198.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 10:35:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61fa0950-5292-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638354920;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zWiZkdcG1+Y6rmdkCu8SSuxZST9U/BC4xB8A111L5Vc=;
	b=OyCbWRicmrv5T1IiZEpqLHOQT5SMER/GYRsrzLq6Kxc0qTX1aXtoS+4k7Ow95U6WlJj3Pw
	xArLYBVLcYo48p67yBK1HR3a2vRm5kX1UQbRQRLItA4c8o/sk7V61oqnOWz/QzLyGJ9F3d
	bkurU/yfVoec3Vb2KlB05kVC70epoFc=
X-MC-Unique: z4X1OmauPkigwr8uNN8wvg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aWZejNfdecTejKrdOEXvfRj58P9ULZiuBi/nqZMBPnh4owj8UK9juPdcca5crKQbb0OlmCPex7aQZA8MJnNEd+g6GmjVBGcAl8DZhobj4EUxmTSsWkoKQBJysA/VCMIJLzn120wwnst85WhNtljBTS+EQDJxMjfLPUMp5J7vC91XJ/Niu42MwNQLDToYzLoVfzPM/8TOwtVVSH1Y2OPsdU6UBZQMG5XEoZu1x1BLHzeaSRuI9kGFVT8YrtMtjF8mgQx90B8FsPDzXZej/zNvqtPHXRAYIb3R8TRubexQSLGsq9+2EBDNUby5GII8QX+xs3dMpzAyTpfQho6gipER2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zWiZkdcG1+Y6rmdkCu8SSuxZST9U/BC4xB8A111L5Vc=;
 b=fkvmoIiV3DBA58hC7d5JhsHTdKbZHySRUoiTgo5jWI5IH02sTZd8CiEki0tYmPj2Zmy0qiOAIrr700viOPn+odqm5ewWnlJRk4ehvzz/BDhTNh/faPyZ5Inj694c4FkPGL9CGm5YC2m6SYCAoFBJt4mNod86VEkKRHjHCNuBQva51E2Lr2hmYybAYJ3JIqhlNoD5WTWIjZnRh4wXu13f2H9jrUN916UL6jbMOR/t5NBDNs+ZFXomtsIjQM1qwtjL8m2WagoxHHTKRgw6IvLy9WG0LJJtZKLWD1696nEL5yJO8/gK/uFLwEvXz7RaW+3+HE1Y0iU1s5pngGffMhcVpg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
Date: Wed, 1 Dec 2021 11:35:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty() invocation
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
In-Reply-To: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0198.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 842f7db3-5124-4375-db99-08d9b4b643fc
X-MS-TrafficTypeDiagnostic: VI1PR04MB6175:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB617560D8F44B4F6CE13A3099B3689@VI1PR04MB6175.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DpGWalZMph4UvWpQvFg8dNImAFBgVi5vdTWJWbfgylxEPZ8Vcn7wAVXkUlFWxM2gkGIyB0NeL5hlYRLx8n4PLawETQmVZcbGSt4N0j+Ge2ZQxhKCfgNeuNuHfCQPQAMR8alaxV3MBZKuzlIW4ls9wFLXPI+RA9Eo812tGSgZ8dnt+VSx/yV5H6v34VDdyhOZDzkkk5JyVorVFs2hfC5b/rHGI6P51JbMrAiY/v2OTbVYLPJt0o8n3qSR4sIWjM3ZDxopx2In5l8ZozOs9hU0LugFDvSsKxj3sTLRfbJoajIR9O0FnFV/IhRCnr+gVNlPUfQMC7+OEcFOBcymT6c2HR+7MynVGxbEcGdYlpXcxB0ynoPUrxoNAljOK8HZLyIfqzFPeUiPYp9pKcI6UNDp5P3Hr8xudNstEfN5qbjmZn05ntjmUQsofwxiBgSXGizB2fh/tYnLJiho7TsYfU/GIM4qaHZcHhXDI4wQh23Fn7ZwFdLHAE5rnjdtPA76VOE8gV0VPIjPutokM3iOFW2Zgzz1x/hxIixaEIyZYRSqhd0B+dYSH+GdsR7tVr3Ue2Hz6bRCd2lmD9vSKb6m9SC9kO3rMjA5S1HHXmytO7Ip3aiDOpDLgBr0v5qkB3zE8Q6xz84mfshU8BX88zYSMWcDJiy2xwyXAssxUiK0DTQoQzUDdr4XIAlx3Tf1EpQDXhJkZhyeY5L4w9wBZxJhTY3Bb0Qw3JfPtuyPphFV4Kq3QN2kx57hUKiYvkS1Bbdpb3yudbt5itOIBmCJmj4DAy60PA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(6486002)(26005)(5660300002)(86362001)(2616005)(8676002)(956004)(54906003)(508600001)(36756003)(66556008)(6916009)(4326008)(31686004)(2906002)(16576012)(316002)(83380400001)(8936002)(31696002)(66946007)(66476007)(38100700002)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SDZiNWE0U01hOVEwNlNNNENLTE9VeERQcHFUMG5Hc0FxMlVlRHMvWlA4STda?=
 =?utf-8?B?V2lwZXZEeWxhLzVpQ3pVdzVxNE5MaHJSbmJ2dkxZaFM2MHhXbk0rei9zcnV5?=
 =?utf-8?B?dkJ0b29wQy90Rk5tV0ZldURnYjFSQ3BTVmxqeUx0Qm5jMzczRkNMU0ljdGlW?=
 =?utf-8?B?L3V3TmF3WmRndVRodzRwK21JcTM3N3MzR0RhR1RwSmk4MTRuNThkZFptYUxY?=
 =?utf-8?B?c3FDaGFjeVVjY2owMFJTaHlWY04zZ1oxQ3RVTTZTcllxbjRKL0dRa2hmSStQ?=
 =?utf-8?B?QkRTa0xzcHFwWitGSUltc0x6MU1USUE0b0ZvVTBqc3kxdEFubmlrV0x5ODlj?=
 =?utf-8?B?dVJNM213MU5aRWk0RG05QmtyNnEwWHVuWHN6OURyKzZ0bE95NVROdWVtZUEy?=
 =?utf-8?B?cVU0emxMV1ZlaUNmd1c5dUlFOGF5QWhEVjVzd2ViOHFtQlRQbWJjTm9kM2Rw?=
 =?utf-8?B?NDVUUm9wMVlBY1N3MHBOeW4xZ0tYN05MYXFkaHQyemdjTmpvSExWdUZyUDhj?=
 =?utf-8?B?akdaQlQzSzJTYW0xU1U1WkxFMk9FM3p1S0tDZTd4RjcxNjRTb0M0MmYrSjI0?=
 =?utf-8?B?OWVtN2gyQ2VzcWtIajlwckpTcHhhUFVMZjlBZHI5WnJVelgwS3p2MER5VWZk?=
 =?utf-8?B?c1h3b1FlVnI5WnZqTVZwTG5IdkFDaGtZamdWNnd0ckU5QjNtLzlxRHgrTGl0?=
 =?utf-8?B?Rmk1M3hocDI2OWt3dk9mNmNkdGRBcFhSS2hCN0JyaGs5bHk5NW5ZRCt3TzY0?=
 =?utf-8?B?dXM3QU1XRm5QZWJNUDNIR1hZa0RZbkdlaWFZcTVrZFZRTlhXeXpDYWxuZ0dy?=
 =?utf-8?B?eklVNHluTEJNOUNPYnZNSHBFdjBYY3RRbXFzNjg2VVU0WUxSRFkzZGlCMUFC?=
 =?utf-8?B?Wkg5NGxPM1VkUzNqWGdJUUxzdysydmRkS2ZHTDhxZjRVeUk0R3JBelVKUjU0?=
 =?utf-8?B?a0lzNEhPVXNobFRHUmtsZFRkMTJBSkpjM1ZMeW5QU1h1aEdpbkwyMWJseGd4?=
 =?utf-8?B?ZCtMelc0TDM4WnQrb3RPdmRvNmlrVkV0dWwzTmgyQXZZUlJvVDQxU3p4ektK?=
 =?utf-8?B?Nnk4cnZZd3FZKzUzc21WK0ptTXRzcGRXaXJiRnltOW9ZVEN5c3Q3QjhWbjhs?=
 =?utf-8?B?aU11SWZ2U0FiTHBrcVNObTZSVWZ1N0xRNmdJOXVXRWk1UXRaSURmUkdteGxy?=
 =?utf-8?B?TUVWTUhDdnBVVjZjWlZteDdtbkNNalJ3QWF4elNqcStaS3kwYktnd3lyN0lx?=
 =?utf-8?B?SGVZdW5LZHJjc244Ukh2a3htKzd3b1hlbUl2VGJFTEQ5VE4wblBPZ3VhVHQw?=
 =?utf-8?B?YnFybUM4dlJTZExDVG1xTVV3TFVjQW9JWXBlRDV0VStoaWIzSkRnbnRtSUg1?=
 =?utf-8?B?UEJ3YjIwemdYODN2bmFnZks4Ykw3SUhoOGh5K0RkREpwdE5KOXVCWHY5SlJn?=
 =?utf-8?B?OFJJNGJMZEFoTktraE9QdE9XSWJuajlsV25QUUR5Z29NMWRSYVBBdnVzMTh3?=
 =?utf-8?B?d3I2NHd4RXMzRTBvb2Rwc0tncmdjWUQ5dk5lcGVFSE1wZ1N5c1BXdi9nOGZF?=
 =?utf-8?B?a205eitCUU41R2tZSGNyQld3amZBb0Z4R3RackVKc1lMOVcxQlNjRDdJVWNQ?=
 =?utf-8?B?UTd3c0pGU0U4WnBLdHBiYVNTWE51WGlMRzY1eTkrUkkvaHJzUnFKNmM2U2hq?=
 =?utf-8?B?Q1JVRFJiSlJ0VUlHT3J5OWdDMUIwQm9hNHhrMmh3aUMwTGhvbjNwTFgwbURp?=
 =?utf-8?B?bTFqdkJBb1FCNkJVRTNuSnN5bUgyanZiUWF1TTd4U05HcHZ5bnV5U2VlM1Ba?=
 =?utf-8?B?bmVKZXFCMnRVc3RpM3ZaNjc0N1UwU3BwcFh4YVVUOEV1bEx5enQzZGNnTDZV?=
 =?utf-8?B?a0NxOVNCV3BhS1BMOVhrbkVSbzluc0syd0dXcUIvdVJGUS9WT2VVMCtldWpF?=
 =?utf-8?B?TkhZLzRWWEFtbE5sSDRrWDNLZytKNHBrcml0WlVIcW9TZUV0VGp1d0ttOTYy?=
 =?utf-8?B?UE1IOUFoSURISm56aXEzcEFHdFhBRjBtbXFxWnppQUZSYTZXSndFQktyZVdw?=
 =?utf-8?B?ZWV0Z2E5allnN1pCdjJqRUVpRS9sSWNrVkZiNXZxUGdXaFpDWTVxOFhoSHFR?=
 =?utf-8?B?T0VzenU2SVQ0UHVSWkxhMHpZVlVhcXF3VS9UbTBkSERCNXhWS28wY2JwUDVv?=
 =?utf-8?Q?Hl3F7L4Qxj7b/SXDCcdXIAM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 842f7db3-5124-4375-db99-08d9b4b643fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:35:16.8597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y3T1qsgzS3Oz6h7mxv4Xi6lQU/TEQmYtuG508I8eIRzstYdqS43c2Gx9kJ/h5s/oLfs1uEyzug9duXuBBToL3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6175

paging_mfn_is_dirty() is moderately expensive, so avoid its use unless
its result might actually change anything. This means moving the
surrounding if() down below all other checks that can result in clearing
_PAGE_RW from sflags, in order to then check whether _PAGE_RW is
actually still set there before calling the function.

While moving the block of code, fold two if()s and make a few style
adjustments.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
TBD: Perhaps the dirty-VRAM piece also wants moving down a little, such
     that all three "level == 1" conditionals can be folded?

--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -604,23 +604,6 @@ _sh_propagate(struct vcpu *v,
                   && !(gflags & _PAGE_DIRTY)) )
         sflags &= ~_PAGE_RW;
 
-    // shadow_mode_log_dirty support
-    //
-    // Only allow the guest write access to a page a) on a demand fault,
-    // or b) if the page is already marked as dirty.
-    //
-    // (We handle log-dirty entirely inside the shadow code, without using the
-    // p2m_ram_logdirty p2m type: only HAP uses that.)
-    if ( unlikely((level == 1) && shadow_mode_log_dirty(d)) )
-    {
-        if ( mfn_valid(target_mfn) ) {
-            if ( ft & FETCH_TYPE_WRITE )
-                paging_mark_dirty(d, target_mfn);
-            else if ( !paging_mfn_is_dirty(d, target_mfn) )
-                sflags &= ~_PAGE_RW;
-        }
-    }
-
 #ifdef CONFIG_HVM
     if ( unlikely(level == 1) && is_hvm_domain(d) )
     {
@@ -661,6 +644,25 @@ _sh_propagate(struct vcpu *v,
                   ) )
         sflags &= ~_PAGE_RW;
 
+    /*
+     * shadow_mode_log_dirty support
+     *
+     * Only allow the guest write access to a page a) on a demand fault,
+     * or b) if the page is already marked as dirty.
+     *
+     * (We handle log-dirty entirely inside the shadow code, without using the
+     * p2m_ram_logdirty p2m type: only HAP uses that.)
+     */
+    if ( level == 1 && unlikely(shadow_mode_log_dirty(d)) &&
+         mfn_valid(target_mfn) )
+    {
+        if ( ft & FETCH_TYPE_WRITE )
+            paging_mark_dirty(d, target_mfn);
+        else if ( (sflags & _PAGE_RW) &&
+                  !paging_mfn_is_dirty(d, target_mfn) )
+            sflags &= ~_PAGE_RW;
+    }
+
     // PV guests in 64-bit mode use two different page tables for user vs
     // supervisor permissions, making the guest's _PAGE_USER bit irrelevant.
     // It is always shadowed as present...



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:36:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:36:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235827.409052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMxw-0005a6-Au; Wed, 01 Dec 2021 10:35:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235827.409052; Wed, 01 Dec 2021 10:35:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msMxw-0005Zz-6P; Wed, 01 Dec 2021 10:35:56 +0000
Received: by outflank-mailman (input) for mailman id 235827;
 Wed, 01 Dec 2021 10:35:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msMxu-0005X7-Lt
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:35:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9a7d901-5290-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:24:49 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-mkJGIjbpMD-sFYYK3mHWcw-1; Wed, 01 Dec 2021 11:35:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4381.eurprd04.prod.outlook.com (2603:10a6:803:6d::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:35:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:35:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0070.eurprd04.prod.outlook.com (2603:10a6:20b:313::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 10:35:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9a7d901-5290-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638354953;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lk+/9fya1n2KyjR1glsL0wj+Ac+2/Uh8SxxK2MJO7+4=;
	b=TiN8ZcuMbhBOr6meY1a31W81qmCLESPFAAC1I//VeTJeOJS1ARgODXMhIplZQWnfIgIP/F
	kLDkVn2Yxp+CsETNL/UxWyzoby4WHK7U1RvYbD01WzcSuAxHycvSIrzIHCHpYIgf0mJGb1
	CMBIDDRNCb4c+qQfZGMx/4jpx0YYWO4=
X-MC-Unique: mkJGIjbpMD-sFYYK3mHWcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bK5FQEU88RmTl0NQnZxRvlZAo6TZgOlskGJtXykRu9mYgbQ2NrqXcjaYS74vGC8wPfCI3HeeM5/XumbTTNmvKo3g6j7hhgrUL+sVJqgUwqd3lnirSnJvY2PozjLXZRasmIiseJkDB3GhiilwyNCTc97cnaOaf0yoMo/mUBqHnP8EzDRBdS02ahR3veidEtukna+u0ch4BsUTDqgJfzmKm3roeguuCfBRv3ptuiy0rCrehuWeG61TDDyl6Wb32WaQD9igMET0sPuuxSR8Fi32krqSuLkr1+XOR63MKRUMLeFT3CcF4f4OSe9u9+W7pdeih8orGq0OyeMCUgBtoBIaAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lk+/9fya1n2KyjR1glsL0wj+Ac+2/Uh8SxxK2MJO7+4=;
 b=Se8QePMsIA3QrRhyTw9mUk9hsm7/GHlCOaQCs4PU0wFZVmlMp0BPaPy/rT62M8QInOT1VwH768yylkJ3Y1vZRf2jJxcgeL+9T5gKTOOsoCSShdoCLr7ybUq56EzfOCHdwzMq1OC0a09AZutXz5QlA6bLM+1sNCpLk06HoMH6Wj9ygMk9rkFfJrv/1e3FsCht4xq1iWRcO6v9Hk+6nFCMrS2u9tPVgtdvr0Wr7uycyyKN/7rnhFnaJJGFKg+uXGlzwP98t57/6Petc8kvXsNpmUq9tJyEYRI6vVPnxO0HZLqiMi8Uv1yFMCzsib+sTajMUO2OF9bgY5AwRmpr1WgIAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e5070cbe-949a-4913-1f99-7b7a4e6c5536@suse.com>
Date: Wed, 1 Dec 2021 11:35:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/2] x86/paging: tidy paging_mfn_is_dirty()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
In-Reply-To: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0070.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0bf2e2f1-9180-4260-7c21-08d9b4b658ce
X-MS-TrafficTypeDiagnostic: VI1PR04MB4381:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB43815C2FA69BCD8C3F7A62D9B3689@VI1PR04MB4381.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1002;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1ToGUhcd5K0UZG3hOUr755e8QE0bIu8UkvWBrAbgxNTPECfTQKnEkXjB8AkUXc2JtE0nFMgqs7CASwixgKTPQ7bDzN69PiJe0b/Y+J6NPTaHwe4HGACq5lWmvy9wDB5YEujECpriJbJLWmWPjeFTlTELy61rmUZmy85jqR1TZ9nwq/N0QYvEWyz4DF+ahPHpFonzDkk/PkJLzyXcA6VksNlNd+y7JyEzXNUofPn1TYsspeYtFbpeAuWozzRKru04WFaHqXkpD1PYkdWSSnjUu8bDSsG8Tr5CvuVEaqXYuIMZbpaalPI4ztZRcoYDRFZRdNIb7KzHU9dwdEQdVbSbUta2xZhmHhqHNK2eTZ1nE46GstuBJdCiP55Jl8oJZJZXrDi1B9g+2P66NS95IazOijDeCVyhQ12mtGzx1NloQdqPeM4gBcfk5QwdIz1R79ZbOBsgb1JiSQ2wRa57c4GSzsRLMqZaGO7VbWmSn6wUHJFYrtGoC3WFjbih9KFyOLqyIHJ3n16WfTXG/TipN/1qnELZs7qf8gZaHrLeF1aK8GN6NhPE2oUmMkjl3+1fDQjsZC44zrQhp2BUadQt4/Nm6iM7IstFgvVJKVRUtTjre7IsmX4TUczluXn3MRf4lF9edb/i6IVdAQKCQ1JAdc69NRAu8R80XJVpY+gYG4XgJbVMXCUdqirJuNHaF8C440GNcwqw3/fG59d764N+q6kHnjg8QriDe2DAjeurvRadzCB7XeOOUAY1FgPtInHxWFBS
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(36756003)(66946007)(66476007)(66556008)(956004)(186003)(6486002)(508600001)(31686004)(8936002)(54906003)(86362001)(31696002)(316002)(16576012)(5660300002)(6916009)(83380400001)(2906002)(4326008)(38100700002)(2616005)(8676002)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MWk4c1lkLzBYbXRYSWQweTZuSUVzU2V4OW9jMVhtOFhWOHl5bmNPaDFZWGYr?=
 =?utf-8?B?SFVGOGFLSGFUd1BFSEZabExuR2ZDb05qSU53YjF1ZG5lMzJQZ3ZTWi9DYVVq?=
 =?utf-8?B?VUt1V3dYRUhKSVFtUXNXVjRXMnFXWUZnYytjTFhuRmErVU9tclVTK05YODFD?=
 =?utf-8?B?WXBIS1ozb3ZnRS9qL3BsN0c3ZXgyZ2Y3NDE1aFIzaU5EelZlTVd1cXFacFU2?=
 =?utf-8?B?Yzh6aG1IUkNLOCsyR1BiQVJzcVQzVTVUWjFRTmp4eEwyYmRTS3VzeE5uWFdL?=
 =?utf-8?B?czBJOG0yNWZNMUs2SGVMZ1RycXNMNVNzc0w1L1JVVDRma2lQQzZkZ2RlbktN?=
 =?utf-8?B?N1BmR1lMbUJ2MXhZTHpkcEx5OXZ0OWZ3NjBOcXd5YTNrdTZEU2Q5TEQ0cEw4?=
 =?utf-8?B?eDBpS3BqTnRaNENSVnNZSGtBVmhOUGlqbENJTDVkMTlidm1rdW0rSFRuK3RM?=
 =?utf-8?B?N2xRcG4xS05iQk5Ra3ZJYUUyVmg0ZXFQb0NFL2tXSmZVa1ZUNm9WYzJFcHoy?=
 =?utf-8?B?alE2bTJUM04vK1hpU0N2OGVYbDVDR2dlOU9wMEFxVUYwVlQwYUR0SExzUFor?=
 =?utf-8?B?dmxjbjNQdGpSa0F5VXJpZXEwTHhtc25OODRqOHU1RWdjL3lsM2FtZTNudC9M?=
 =?utf-8?B?V2QrY1ZhQzNVVXYvVFVCZUZQZGRwSkt6VVNnaGNndzZNSzhtbVAzTVQ4Zm8z?=
 =?utf-8?B?UGVmcVpYOUtEOHkzK0RHSCtrRC85WnhScFdGSGtvazRaS2NXSHhEakZQM0pJ?=
 =?utf-8?B?cG12QTJ3WHZVOTk4M3ErZWgxMFBnM3k5QnVjRjdXVXhMcTJZN3BoazVxeFQw?=
 =?utf-8?B?LzVGa1RJa3VVd1huU3hrT0VQYlMyTy80ajE1NGV0ZTJYbkdzTXp0M2FQaXRS?=
 =?utf-8?B?aHJQd0hDbXI0Q001UW9wVXdablNyWkNZT3B1OE5tQk9XWFZGYU84YlBYclkx?=
 =?utf-8?B?eDJJUlFBRkQ4eitMOWVXKzMwUk16Y0k4bGdRNG1GYlJ1MWdxVzV3U2ZYWC9S?=
 =?utf-8?B?U2pNQkVoQklMWktWZCtUVkoxRmN6NFgwdXBOVjluekFKdkNtWXBrczZtMUV0?=
 =?utf-8?B?NXpWOE5JOHJSTDNlL0UzMm5XY1ZaUDRURjhWREhPRjZSak9Qb1JPbHhXckVB?=
 =?utf-8?B?YzBOOEtNZ0VKTWlCODg2MHJLa1hGbEF5ZlFWb0JRV1Z0V2ZLa3JycUl5RVU1?=
 =?utf-8?B?bzYvOEp6dWVPT3VoYzBQMFFqWUlMSnI3MStlNmJRY2orUFcvbGdhMnplUG9E?=
 =?utf-8?B?YnRQenZZekN5RFZFVjlEOFhGVE44cis4OXV3Q2FVRkVJTm5OZEZsVTlmM3ZD?=
 =?utf-8?B?dXBXQWhQSnhLelhxWmNITE9WZXNQa3lxS2hXeGRvbnVFVkRnS0N2TXYwSmpr?=
 =?utf-8?B?NFhFKzh5ZTRXSURDNEtFbVNqVTZJc0JyRGNGZVE3Skw0dmJsU1A5QTlqazVB?=
 =?utf-8?B?c0wzakNJZ2lFbmhwUWwwTWlNV2xzTm5XTTloaGY5U3U1b0FGN01YeVVMWVBN?=
 =?utf-8?B?VWVYUUtQcW9BUTJHYUJVOGtVQ3BQM05ucVBEcGFHQTRvUEY3eXVoS2xZZm1X?=
 =?utf-8?B?UnlwRkdRbHorU3l3enFpVjcrVHB5a3E1Z1Q4a0FSSFkrYjRqeE5KNkkvSlNv?=
 =?utf-8?B?aXlTdTZJMXZiVTdHd0d2cTAyeHV4Ry9JajNPelhCWjg2T0ZoaXRNekVwWjhO?=
 =?utf-8?B?eElwSHZ6Wkc0b2czVnlhTnlDem9CblJNdkUxTG14aGZCd2hxUUI0N2dGdWpR?=
 =?utf-8?B?S1Zvc1B4VVpQTk5Ma1J2TGJESGNJNXhZVUl1dUdHUVdFM0tLVE1MUXVSR2x4?=
 =?utf-8?B?cEJhcW1Ub0xoRmRNTlVlUVJkbHdUL1VZQXhYSDkydURlWTdiN29KTDBSaUlh?=
 =?utf-8?B?aWExSlhzR0U4UzJIVnBuSUNmVEwwSE9DZG91aGN3MFVHWGc4UEN6TlF4L0Yr?=
 =?utf-8?B?c0ppZGhCeWlBV2pqUW9zVlFJUXFsK0xMZ0djdVJvMGhSL3pySjdsUzd0eE5l?=
 =?utf-8?B?VmVIRFY0QUhMUk5hVDBnckNyc29GMmc2cEZqUDJBUStrMnRqaXBpOFFZR0R3?=
 =?utf-8?B?K0hqdXNIQ3dsRHVYQ2RrNjdSVllaZGlhZnJ5YlA0RWdHbEpPeVhjb3VROUFl?=
 =?utf-8?B?dk10MUNHZk5BM3NKWTM0TzJSZ3ZINS9OZzA2eHd1ZEEzQXB0ejhtdStTanQ2?=
 =?utf-8?Q?nwE55+fyXx73SsMh8nv040k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bf2e2f1-9180-4260-7c21-08d9b4b658ce
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:35:51.8159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /IXVz/ZKscc6BTFgV34g5lLg4Npb2CBpdGn8RCYv4kI0ed/02Aql3oz8oFkmgdUB3ttEqTImXplr7403eQwnlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4381

The function returning a boolean indicator, make it return bool. Also
constify its struct domain parameter, albeit requiring to also adjust
mm_locked_by_me(). Furthermore the function is used by shadow code only.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/mm-locks.h
+++ b/xen/arch/x86/mm/mm-locks.h
@@ -40,7 +40,7 @@ static inline void mm_lock_init(mm_lock_
     l->unlock_level = 0;
 }
 
-static inline int mm_locked_by_me(mm_lock_t *l)
+static inline int mm_locked_by_me(const mm_lock_t *l)
 {
     return (l->lock.recurse_cpu == current->processor);
 }
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -351,14 +351,14 @@ void paging_mark_dirty(struct domain *d,
     paging_mark_pfn_dirty(d, pfn);
 }
 
-
+#ifdef CONFIG_SHADOW_PAGING
 /* Is this guest page dirty? */
-int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn)
+bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn)
 {
     pfn_t pfn;
     mfn_t mfn, *l4, *l3, *l2;
     unsigned long *l1;
-    int rv;
+    bool dirty;
 
     ASSERT(paging_locked_by_me(d));
     ASSERT(paging_mode_log_dirty(d));
@@ -367,36 +367,37 @@ int paging_mfn_is_dirty(struct domain *d
     pfn = _pfn(get_gpfn_from_mfn(mfn_x(gmfn)));
     /* Invalid pages can't be dirty. */
     if ( unlikely(!VALID_M2P(pfn_x(pfn))) )
-        return 0;
+        return false;
 
     mfn = d->arch.paging.log_dirty.top;
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l4 = map_domain_page(mfn);
     mfn = l4[L4_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l4);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l3 = map_domain_page(mfn);
     mfn = l3[L3_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l3);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l2 = map_domain_page(mfn);
     mfn = l2[L2_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l2);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l1 = map_domain_page(mfn);
-    rv = test_bit(L1_LOGDIRTY_IDX(pfn), l1);
+    dirty = test_bit(L1_LOGDIRTY_IDX(pfn), l1);
     unmap_domain_page(l1);
-    return rv;
-}
 
+    return dirty;
+}
+#endif
 
 /* Read a domain's log-dirty bitmap and stats.  If the operation is a CLEAN,
  * clear the bitmap and stats as well. */
--- a/xen/include/asm-x86/paging.h
+++ b/xen/include/asm-x86/paging.h
@@ -173,7 +173,7 @@ void paging_mark_pfn_dirty(struct domain
 
 /* is this guest page dirty? 
  * This is called from inside paging code, with the paging lock held. */
-int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn);
+bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn);
 
 /*
  * Log-dirty radix tree indexing:



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:48:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:48:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235838.409063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msN9y-0007Tp-KQ; Wed, 01 Dec 2021 10:48:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235838.409063; Wed, 01 Dec 2021 10:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msN9y-0007Ti-HP; Wed, 01 Dec 2021 10:48:22 +0000
Received: by outflank-mailman (input) for mailman id 235838;
 Wed, 01 Dec 2021 10:48:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7zg6=QS=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1msN9x-0007Ta-2G
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:48:21 +0000
Received: from galois.linutronix.de (unknown [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 320917fe-5294-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:48:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 320917fe-5294-11ec-976b-d102b41d0961
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638355698;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fKVDaayb9Z/Ddig0Fl/GaJFR9P6OWvMrHeuR0/MtGo0=;
	b=2ZakPGx22bgcebPzdNcjjRS3Y+6bDCb8UqLyR772WTqZ3Dp4UaYXmOk/PEQcTyOQ7C281b
	bPOyziVy1+KZVMw3CGvc+ExOnUo3TGdnz0i00ne5c5xhE9SdM/59qPZ0xTYuY8kFfCRJHa
	wcobwbC4oDqjpMDdFFfLEhfZrKdXImuDjnGTDbe68FOs6Usz9scL95/c6U40dk3gLSwp4H
	hFcMKRQNY/TUSQIPtN1M6bsI7K7UFwZ9DBl1XIRPJr+91AHdW2Vxfy1MGQffna5JvbHjBr
	uAxbtarLA9tARJPPzvIH6mf2U5yQzqI1DPvadU9/jGsPDm2ZYxczJgvoUPA9sw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638355698;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fKVDaayb9Z/Ddig0Fl/GaJFR9P6OWvMrHeuR0/MtGo0=;
	b=qy6yHYx5gu2MckULeM58AC46b3/lxjDG+QCdq/u8tP1cQaKsq7O2NcCTYCu267QpY8omHJ
	23N9eC+QYS1K/KDg==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, LKML
 <linux-kernel@vger.kernel.org>
Cc: linux-hyperv@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
 sparclinux@vger.kernel.org, Wei Liu <wei.liu@kernel.org>, Ashok Raj
 <ashok.raj@intel.com>, Marc Zygnier <maz@kernel.org>, x86@kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>, Bjorn Helgaas
 <helgaas@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
 linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org, Kevin Tian <kevin.tian@intel.com>, Heiko
 Carstens <hca@linux.ibm.com>, Alex Williamson <alex.williamson@redhat.com>,
 Megha Dey <megha.dey@intel.com>, Juergen Gross <jgross@suse.com>, Thomas
 Bogendoerfer <tsbogend@alpha.franken.de>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, linux-mips@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org
Subject: Re: [patch 05/22] genirq/msi: Fixup includes
In-Reply-To: <39556bdc-f48c-68b2-6bec-5975b92e02e2@kaod.org>
References: <20211126222700.862407977@linutronix.de>
 <20211126223824.382273262@linutronix.de>
 <b1a6d267-c7b4-c4b9-ab0e-f5cc32bfe9bf@kaod.org> <87tufud4m3.ffs@tglx>
 <524d9b84-caa8-dd6f-bb5e-9fc906d279c0@kaod.org> <87czmhb8gq.ffs@tglx>
 <875ys9b71j.ffs@tglx> <39556bdc-f48c-68b2-6bec-5975b92e02e2@kaod.org>
Date: Wed, 01 Dec 2021 11:48:17 +0100
Message-ID: <875ys8a9e6.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Cedric,

On Wed, Dec 01 2021 at 08:14, C=C3=A9dric Le Goater wrote:
> On 11/30/21 23:41, Thomas Gleixner wrote:
>> It's not the core function. It's the patch above and I'm a moron.
>
> All good now. Ship it !

thanks a lot for testing this and dealing with the fallout. Much
appreciated!

        tglx


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:52:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:52:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235844.409074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNDX-0000On-46; Wed, 01 Dec 2021 10:52:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235844.409074; Wed, 01 Dec 2021 10:52:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNDX-0000Og-0p; Wed, 01 Dec 2021 10:52:03 +0000
Received: by outflank-mailman (input) for mailman id 235844;
 Wed, 01 Dec 2021 10:52:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNDW-0000Oa-2H
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:52:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b61a9747-5294-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:52:01 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-quA_WWHXM-efxKwWBjNEsw-1; Wed, 01 Dec 2021 11:51:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:51:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:51:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0030.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::43) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 10:51:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b61a9747-5294-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638355920;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=FRIcTDqJo18dQVBKsA8aCIXEn1TmFyexAhKNAsbcwak=;
	b=Slzl0bqYb+xkvUndD2G5zjwG2rvZ/YXC8dJOvxnoDpTgBAOoTKf+jGqdGGC54i0DMWIQgH
	IfVH3leThAQ4ZUOAhjiuEs2DUKJ2vQYyxRZCOjLO+HCdc8P3iXxxLHVafeocjnPuvUShuD
	THJOnGYqpazx0JOT1hcXspZ6QapUv0I=
X-MC-Unique: quA_WWHXM-efxKwWBjNEsw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Kbk+TDhAwYv21be0jdrUxwcDSu797KinzykaabOFg66sfvxrR76mXDzQZ6nilgg1l7UWV6BZzDY7Xl7GHHXss+WvB3sHMO6WwlfrfeV0g7/PNc1tXJjA3IZa7ZSslyLX5E2sh1aIDCqDTENhv3g7CMhw5esdZjA7h+p5wH6dCxE5UHbtyIXzJ7mnMAEc9UFeg4kis+lF6JjyZ6PTf0mZkEBB7kKNSbs/hA/pAfGrUdUWgG5lob36z087GWqp3eEJ10No83HAsCpc3ZL/jZotgYk37yUSf3cuDExOZpC7Y1vWa/rAuwX8Khdnov5iEOo3kHfRpH6SJLyJDEdkHTzEdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FRIcTDqJo18dQVBKsA8aCIXEn1TmFyexAhKNAsbcwak=;
 b=V4jBTjqmGxHZCq87mN0kLfjoGOlhFH2U/iGfyMkoq99r/DlcO59z0iXA++wI0IzGq1Cnu681JAEACktP1VQaa7uQOedL91dViKrt9jpugV7ikIck5I2IlKFrOkH6vxd9CyJUBtYE9ZM7vbQdKF6SmVvIdeDwR0u97LSSoZiZpRK2ZRxMXhr12zHg5kpHuPvY7l5qwBcVikBOQv45pZUT7rsxOaSrLsRrYGc81Hyxt5+of+Vdy/4soMUJdNC2NRTNUOPJZM2i8/HBXnj9I274wyuAvyoAPT+IzKVz/+zwFsZlbI0L+3LSkwUXPhM995ggtx1cATZJ/LIb4EEHgUWbwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
Date: Wed, 1 Dec 2021 11:51:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/4] x86/mm: address observations made while working on
 XSA-388
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0030.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::43) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c51c22dc-7302-4f80-cf49-08d9b4b89864
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5741160C737783E6F0F85A2DB3689@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BylqDAnlF+c24U2SPMqPD+yZvHrk0fhLE3kdwRSi5L7BhLghIMjZOhSxJfXf9Yf5uAgTzDRV0BHAuES6AkiHlT9x/1M97Zzbkv34lxw8ObMBNk/zrCG9DprTXoVXCtpfgW7Mp/1eivYvupv0IlkE9J9qUATEvwx6YzKGsdIQHPWfTptl9w9ewTJDyaGgAcoztTTg0bX5rJysY/oItF+jUn2e9V+VGQ5w42NYpjoU+eCpAw6H1TzwVu1Hg/MnqlvwRbxcrXX2DiHcDFR21kOGgxT2WGFyH7RCM4wlGeulJuwTUZoG6YaU2I1CKxLq7zGavA236VRK16Wm2f56wcM+iTVrcmVzIYsRwx4BsGhCT9obWTxGreXRdeKYyoxlkPzu94h5zqcF2mJs+Sa8m1uaEgZ6o5FXOQSyHMNFwvRBO41s6wLzJHraMCjFWYrM89vybGPAuuwDK8g6m2Irxg/T5gwONV9vMW2UU3adUndx5ZLeAyvo2Q3bONb6bo/V0QB7tADVOuTfdxTwqVHxa+Ht1qT/MQP0/uBAXGxw0z/DRq4CHMhg1Ssaf9FT9QrqF11KoczxsrefPZXg/eI0R/OZUSdhrl7ePxteO1CQ+9fxnhACxgnPgew0wrNzfpoyTr8Ed9ouT17vqwrMV0Z0R4FQdAyUyDgyx/W7V8bPisVYV2ma1nbB4k9cdvbmsn7rEqMdu+s3xJ1UDqsPOInVlmczb3gCFTwaQZG+kA3uR+8J3jQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(508600001)(66476007)(54906003)(2906002)(6486002)(5660300002)(66556008)(66946007)(8936002)(38100700002)(36756003)(2616005)(31686004)(26005)(316002)(31696002)(4326008)(86362001)(83380400001)(956004)(6916009)(16576012)(8676002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q1d3TmdGUmpIZFlpaDc2WG5KM3BUbFJ3YWJOQ2dVN1phcEw0VTIvekNFZno4?=
 =?utf-8?B?ZEpnWm94ZGF2eng3TTBiMjc5Y2FTU3hRMzVyK3RNU2RNTnljeTVLendpTC9v?=
 =?utf-8?B?UE53RXlxUXJYWFNWNitqUTJaMnNxK3FNanRadHFFd1U4U21TRmZna00vU1R5?=
 =?utf-8?B?cVZBZ1g1VURYMUdlbS9RSWJXVnc2SWpYdTlBNktwNC9JZi9KRzJwSTNJT0J2?=
 =?utf-8?B?NFZaNE01N2QrOG1HdGQwOW5ZQklyVzlwUEhhYkFiVSt0OGZIeWlENUduTUlB?=
 =?utf-8?B?WU9ZQkNRZ2s1VCswZDdVTTV6YVZxQjdxZnFHeUpTL0p3RDZ0SEFaTWY1d3Rp?=
 =?utf-8?B?NS9ZWkUyZ3czQXJJNnhSTW9mVTZXWEtBL2hFVEFDS3J3Qm1rbk44RTBQeWN5?=
 =?utf-8?B?c0JIU1hJZko0NzFoL01BVnZNSEhSemYwclVkWXhlUy9lVDFCMnFyZnoyYm9W?=
 =?utf-8?B?OVlPUzJyV2Y4cjhpeSs1RXpFa1FnWGhHdnNjMWw4eDI0T2xxSlQ0ZVZDRk1M?=
 =?utf-8?B?WklJRFRBQk4xVVNDRjBRK280aDMzbk9haExFenZyWnY1dFdmWkpSM0NaYVZj?=
 =?utf-8?B?VXZicjh1OWttSXdzQ1FrNkRXRlFLbmVuQTVtRGxwbTJKVmNPTHZrNXhjTUVM?=
 =?utf-8?B?NW9mM0UvWGQ2NDhxL2pDRlplSG4xUFIyVzN3Q1prN2ZWY1BkSU5sYVY4THM1?=
 =?utf-8?B?Ynd1Znl3ZmFqMTRHVkNuSWFvaVJ5WDdRRjNZdmNiMGRFdjBDdEZiYmlmK3ly?=
 =?utf-8?B?QjhQTWdObFpiNXQ3RHAxdmRrSDhzc2s2NXU4NjcvV0M2dVA0bHRXdmI5YWJk?=
 =?utf-8?B?VzJCcmVXa1NlL2E1d29zaWVPZjZiTFYyc2xjcTlMZitzeHQ5djlEYmVNQ0hQ?=
 =?utf-8?B?Nm9KUE5zUm1CU0lkMlpGU1h6eWUwRzJWMjd5ZWh3RXdlUm5QRjdibHBqQW9W?=
 =?utf-8?B?eWdxdzdFYW14VTJEaFpBZHlsR2QycFN4b2szL1U5MEIyTFdNcHo3Y3JBK2dK?=
 =?utf-8?B?M25tdlJ4SGIyL3V4OWtyRlpzZXYvME51clZjRW5pNXdXa0hwVkV1Vy8rOHk0?=
 =?utf-8?B?YXY4WityM1JEQ3Jadkw3MWJYYWJ0TkZnbnErTXorVENBVkhwek9pQ0o4cDcv?=
 =?utf-8?B?aFZpZk1tRzBxaEhXY0hyUWxYQUltdzkvQ2VIQnF0SkdkdW5pbUljSWUzY1JR?=
 =?utf-8?B?TEVESnd5cDAvekZrZG1LUmY2Z2J0dXI4VE56OEdBajRGYkxBZDExNjRvTW9a?=
 =?utf-8?B?MWplaXF5WWVOc3puQ1FKVlBoMDdFNnRXSld0d2dIUzRzNUdrclNBdHF4aGNL?=
 =?utf-8?B?NHJaTXJuc1ZUMWVWV0FZVGVrM1EvVFRzK1Qyemo1Wi9zclVZekdYZ3k2ZU12?=
 =?utf-8?B?cWtwOXFzYkFvSEdneHJiZ3BsNVNWUmlkZVFucm1qeXJrUW82bkxaeVUyei82?=
 =?utf-8?B?RU0wT3R1MndHakQzM2R5ZzV6VVIxa084UFVjMzd3SE1ZN0t2V0U2VE9jMkMy?=
 =?utf-8?B?WitOejdNVFhQbHlHUGZHWFQ2aDJEVkxJbTR1bXhVd2ZaTDJPeHgwWHpsYXhJ?=
 =?utf-8?B?dkNvenc4LzAxbndSTzVuSVVtMXhXY1hwaSttMlZtYzZlZitYU0NoOGVhSGNh?=
 =?utf-8?B?TFNHb1k3VStJaUt6VGE5d0FMcktXbCtGK3VBTm9VNzdoOWZkRlVIL0xWTGp3?=
 =?utf-8?B?L1p1dnd1dFhNSWNzYitjR280dTRxN2NWZ1RHRnBIMUMzWGI0SGgrSnBWTEll?=
 =?utf-8?B?REd2ekJlYlFSRG9Kd084cGNpUWNpNjk1RXJUTFBjblRwdm5kSytpcEQ3RFI4?=
 =?utf-8?B?UkN0akVMaGQvbGdmY1VtN21CU2w3cFZ3Unp1c1lkTllESTl4V3FneDlXdXd0?=
 =?utf-8?B?ZldFRGdmWFZjKzdqYUI4K09wZ052ZEZCYjd6ckVncCtsV1UzQ1FjVVEyUnlM?=
 =?utf-8?B?c3V5bHplQjNlU09oM2Vtd1BsRmhYZEppdStPVWJndGtHbEtqSXBlVitxK2VT?=
 =?utf-8?B?WlhjVCtqSy9CYUtzazVzWlNNODVpV1A1OEdzSEhOdGVDQTlzZUJDUThsWU5E?=
 =?utf-8?B?RWRtMWpRTTVFSEdjdTJOdHpCRVR4WnNRMXVpWDNINTY4c0FKclRyMEszZnA4?=
 =?utf-8?B?djhSbEVMNE1jZnRFRVZYNzFZejRucENnY0NkRHdIWTZ2b2ZqYjZiZTI0Q0w0?=
 =?utf-8?Q?nmlvmv06Xk7EDT7YXWBnDn0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c51c22dc-7302-4f80-cf49-08d9b4b89864
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:51:57.4690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXPem6IhOSPjDaJsgwxF05ACsVUjjiPJZ9IcQtWWzehFHkZ+uFj7m5LfDdWoeAEOhwPn94Z0eJ8oFb/+SjQCBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

1: PoD: simplify / improve p2m_pod_cache_add()
2: PoD: HVM guests can't pin their pages
3: altp2m: p2m_altp2m_get_or_propagate() should honor present page order
4: altp2m: p2m_altp2m_propagate_change() should honor present page order

The last one is RFC, as there is an aspect I can't make sense of.
See there.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:53:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:53:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235849.409085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNEe-0000zO-FP; Wed, 01 Dec 2021 10:53:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235849.409085; Wed, 01 Dec 2021 10:53:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNEe-0000zH-B8; Wed, 01 Dec 2021 10:53:12 +0000
Received: by outflank-mailman (input) for mailman id 235849;
 Wed, 01 Dec 2021 10:53:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNEd-0000Oa-1d
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:53:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id df86d3ef-5294-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:53:10 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-58fWeLOpOBeox4l2FTO6pg-1; Wed, 01 Dec 2021 11:53:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3534.eurprd04.prod.outlook.com (2603:10a6:803:8::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:53:07 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:53:07 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0105.eurprd06.prod.outlook.com (2603:10a6:20b:465::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 10:53:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df86d3ef-5294-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638355989;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2kRxZT307uKBK1UcuellO4ewXtOz3JX0bF445MqtSGI=;
	b=ivNMOY2nAc+tNy3+BV1yA8Eg0zoVicryiZ/K+t2mZFLUGJmqkcOmqUp0iuzzUThRAKsNJp
	oMNHZIt0ooAK3N0BUTRiDhGcVSeYRyNaizuIA8iqvUJ8xTfBFtH/06k+TWs/Uc+Os7f5aI
	qYWu57M7YXOyZi/17V9Zy0vtwN5gAUg=
X-MC-Unique: 58fWeLOpOBeox4l2FTO6pg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mK0slyE5Fpd+FEfeZnOu93036UbDylk0wsdKvXFXXEW4sS7kJ3/hClRNecSA2EZPAo96OCM3WqXeCmeguczysO/VsHgCIFm/W8DDTF/L2rvSgquZM0Bx2mtFEPzBjW6lCfv/3sGUWYsFluUPzSFWiEYLjxs3Ypc5eiLuLO9pHvFoKwaYzu9fklacqZIuSjvqcCSM5qXSR6LGGgyluhfQTp75OIuww1wkJIzTdvbUFZHan/r2Iu+RTkI40tOSmdHk33L6i5Hk7vqnWrxKXt00fnjuZw/Dy7w1Mz2m4pwSKQfbp8uVjLWgT3bx+AGbWWazyddEMFgHHMu92aDlmL2PgQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2kRxZT307uKBK1UcuellO4ewXtOz3JX0bF445MqtSGI=;
 b=ezvo8V75ITWCQpX+xt25eElDvGGwn893OCG4oayXeF0wwerQBXrdwah6gX1FlqWZK7U7Wl0anbmMVS/eUCtMjCSjTj3OsXiGcpb9tkaxvp1kDA82JWRwVuSUMAe90FAFahBu65hYemyR3HpZDHxs8cduxfLBB7xBHYoMziel19wjAfstORAauYwioHda2itKM9GW8pxEWvug1a1U220ADHIMQYYMKXs0p8CrmkjCNaup46zHeoMg9d+hS48VIs34g2862lxj3D6fCl58kEXvzaH6vt2bhicgnJZlkKKFKACPQvPW7fKMYIKzDZvavoMHjtkb1pL1QYlTDQs6opZHPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2525b63f-f666-2430-2c22-b1b7b0d5d7f0@suse.com>
Date: Wed, 1 Dec 2021 11:53:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/4] x86/PoD: simplify / improve p2m_pod_cache_add()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
In-Reply-To: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0105.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 667d2f9d-01b6-4853-d4a4-08d9b4b8c1cb
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3534:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB35349AC8C360CCE0E59AF57CB3689@VI1PR0402MB3534.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:569;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u6OsVc6HhwPpEvW1f1fXKfGR0G+R77edy/BK6n8lwslUMrqKKaZego89DhfGWjBpl7d7wr8ahT72OnkG87Pol1wvJMwQ9C9AKazeeeMFsLDYP7bT2nVus6PY8DLBCdnQTu3iBvXIWpd2g/KTeltTM83E2M8rXkAVfzWfCKbzHPTub1U+WXQusvb4C0Zmt+CWfsdYNDqsQgA8HXfIOqfuC67Qbb3waQ6nQGYH6Oc6nQXwnzUXYmfafI/5eF2cnaItmkp24opkgdh+3s86tx5dCl+4UtSMkhB3mSTbwbg24Vm4UpxJxG+ut8Mkxd2Y1I9DGbFOMGIEOcsGs51j1GNMNs9MICNFr2zDuTmicEcp6pEcY6WmNlW7pZbHIqHOh4BZSqGZBSATgOKptIhC7b+q7yJ43M7TyDKDEa2gZXEy/A8XSPECihg1PsYKQesxJwjyS06OQjYs9JuMhFldi3+mpNvgILdAe58V+YfxwTURTSc5crmp5QD3IOMg+Y204Tz5eZgkFio7zkH27gCNQt8JQTc/epESyGs+d4h8q3mSZ4NF/FZCbaS2FUWarVedGcpPcbP/2zE8FzEoaKdQmCRV/+NHDCpVI3Y4gqK/LLRA1rcEYh85Oa2mpuDBp8LtXR66GkHQtY39L+tNm/iIu3Og49xTmqAtjlN9H4rjUNwEbW71LizY8qznzG/3W/2LLCMuUPvK8piLpSgiz3PpwNclnbG7GsREoXL3cizONfi5AkFn3mhxxKp9YWXsT9EqrVnI
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(956004)(2616005)(36756003)(66476007)(26005)(6486002)(66556008)(54906003)(508600001)(66946007)(86362001)(8676002)(8936002)(316002)(5660300002)(2906002)(38100700002)(83380400001)(16576012)(6916009)(31686004)(31696002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K0p6TzJSSWx4b3hnKzlmMm5OaTdTaVNNdGxKQjFjODFpL3AyZU5KSms1Vy9R?=
 =?utf-8?B?K1dHdk5xUjVIZUoyOVFaakZNV3V5RVR6MU4zc3pndUwxd1A5U2tLRHNCaHl2?=
 =?utf-8?B?dEdkd01QeEpGTGhhaDlDR0N6clprSndpNzd3VjA4eXZqTGdKWTgwOWJ3ZE10?=
 =?utf-8?B?NkRJSUZqaS8wRU15ekhidWNHODloaHh0R0JQRDVHcUdXZC9laUsvZGlGQ3pt?=
 =?utf-8?B?eGN4QzVOOTlBSU52NmU1UWo4WTF1N1JtemJUZ21iZ09Qc3N6dWxRQzEzNTNs?=
 =?utf-8?B?ZU1VaE52NnpmNThHT1hmM0xSY2hsMTJoQUY3Z0N6T0lBaFZpcWNGNTlSL1Z4?=
 =?utf-8?B?Y2NXZTdUUC9mTTQrZ29CdmprZTRPTUwwaHUwNk1pRVI1UnN2TVNoUzZoeUlX?=
 =?utf-8?B?TzJFcHc2cTdpaXg5V0VUa1VsSUpDQmpreWNTVjI5UWNrY0IrNGUrcFd5S2xr?=
 =?utf-8?B?d1VTdy9xUWtJZW92K3F0c290NDNmQm5Za3dON0dIbEh6dWVBczMzRWc0TFFa?=
 =?utf-8?B?VjdOL0xOWWVFcTcvUmVvdktkNzRTeldxZ0RqbWZ1N01VUGptVTNJck9xQlJS?=
 =?utf-8?B?WEdaTmlLMG9TMHdXWjVTUE5DNUhDRldYaGdJaC80YXNVVG0yUVdsaTdBcVpG?=
 =?utf-8?B?RTdYcklOSTZMbEdpd29teHdubElDWDNJdmF4QW1oNkxSZ3NxU0h1VHBqQmtY?=
 =?utf-8?B?NUl5OUpod25ka0tYcEFLRFNDVTAvRTJVUWRhcWRtNC9EOGZPR1JKTlQvMVNF?=
 =?utf-8?B?SFdsUjJnUEtkSkNMTDhiaFRkNUhVTWZEVkFrNmgyWmdFMFE1b1RWZW14RWph?=
 =?utf-8?B?cVlnRGpCMkxNY2hOVDZPMGxnTTZjaXRtNWRacDkzamkwUVM4dkhNS1JlK3hj?=
 =?utf-8?B?UXhuWU5yRmJ0cTgwV2wwTmVIRHNMWDBGL2xndTdoYkM0VlN6UGVmZ28rcGxl?=
 =?utf-8?B?VmZrVWFobWoyTERwdE1VY2VncXowUWk2bFVLRHlGR3hDY0tQL1BZdjNUWW40?=
 =?utf-8?B?bk5BeFd3OXJoQlRIb2lDNlBvd1pDTTVoc1dmaDRiQTE3QWJkN3NVVG9kMXFa?=
 =?utf-8?B?Zm5pZlY0aTNvS0VCM1YxZ24xd3BiU1lhQXFHNGptUjUvaWZkUUp4QVk2dlcy?=
 =?utf-8?B?clBTWlhwZ2dhQ3JYQlI2WDBzeDZpcklBbjcwVUNiN1djVTlaMzdFejVrSXBQ?=
 =?utf-8?B?V0lNUDYzaGNhVlQxVmxZQStIVGZjTFNhcG1VVUh2dE1YSWdmRWJ4SDA3azI5?=
 =?utf-8?B?TU5UVGJFM0VvNmpjbWV5UXVlRFdJUjV1Nlp1Yk5KZGxQVjlrKytxWHl4ekVz?=
 =?utf-8?B?MStxTG9BOTc1eGs2NGIraTVYZTY5VU5jc09PcnBBOGlNdGVVVnZibzBsQjhS?=
 =?utf-8?B?Z0xleXNWMWJaV1ErVlJ4TURjSTBTbXk5dTY4NnVXb3Jhc1FkMGhYVFdvM0Mw?=
 =?utf-8?B?aFYwRHFTMXY0M3FWNXMxZjdrTzRVYUxFbEc1RWRsSzZWV2hPVFRWVjUxQVdu?=
 =?utf-8?B?YWFvaW9yYXV4N0ZDUU1vTzcyNkdTaFp1M0NVVUc3Zi8ySHE1VUM5UlZvTkh3?=
 =?utf-8?B?VUNDNmR2MkRyTlZrcXpDZlhlMlRaTjE4SkQ3d3p4SENpdEhWWi9iYWlDbzZp?=
 =?utf-8?B?UFZhbjJpaEFDZFpMa3pORTJkZmxwMldyUHdOUHRGZEJkNWgrYWlkSXhUeVkz?=
 =?utf-8?B?dFVrUW53R0d6b0tvbUNEaVJqL3VTL1JSR3JHSU5PR3JUR0IxSCtCc21ZTjdK?=
 =?utf-8?B?ZWJxbzRqYmZxWHJYU0t2clpxME1EaGU5SGlTOWxBTzJtT1NrdnEvMXhTdXNN?=
 =?utf-8?B?eG9xU2JYNHFSMjB2eWlhZENTaW1HRTRobHNIUXVTYS9DbGxKUTNtYnVYL1Bl?=
 =?utf-8?B?T1JGeUNxbEc4NkxnVDljWjQyR2hxTW1ZNDNrR0lGN1ArVXhOc0h5SFNlU1li?=
 =?utf-8?B?ZWRaTFR4djR5RGs3VEhWSGo1NGkybXl2UEhBOEhQaFovbTRUVjBwOTlXVFV1?=
 =?utf-8?B?N084ZG9ORzM1ZVpQT0hJNmtEeE55TkdyQ0V6RG9NWjhkRlUwNzFlWHBmOXpq?=
 =?utf-8?B?Z2wwMW9TSEpucjNBYnBVYXhqRUp3dUpBdWFUMWdSMUFKRks4c2dCL1QvVXd0?=
 =?utf-8?B?RVhaK3hmSTVKQjFydWVubFlvRm41UlQxaWhtcU1oNGhpYXBrUmREd1kwOFlB?=
 =?utf-8?Q?pZIytdpm1S71O0jmEGXY2ZY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 667d2f9d-01b6-4853-d4a4-08d9b4b8c1cb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:53:06.8968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rWVhRqI369Puhq9W04OtoL1rtS6WyGf2AvwMOX+LQTuH5077rcrLrbf43k3b4qOjxYwYphWTJ0Ik4uOFOZjhhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3534

Avoid recurring MFN -> page or page -> MFN translations. Drop the pretty
pointless local variable "p". Make sure the MFN logged in a debugging
error message is actually the offending one. Adjust style.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -58,14 +58,10 @@ p2m_pod_cache_add(struct p2m_domain *p2m
                   unsigned int order)
 {
     unsigned long i;
-    struct page_info *p;
     struct domain *d = p2m->domain;
+    mfn_t mfn = page_to_mfn(page);
 
 #ifndef NDEBUG
-    mfn_t mfn;
-
-    mfn = page_to_mfn(page);
-
     /* Check to make sure this is a contiguous region */
     if ( mfn_x(mfn) & ((1UL << order) - 1) )
     {
@@ -74,17 +70,14 @@ p2m_pod_cache_add(struct p2m_domain *p2m
         return -1;
     }
 
-    for ( i = 0; i < 1UL << order ; i++)
+    for ( i = 0; i < (1UL << order); i++)
     {
-        struct domain * od;
+        const struct domain *od = page_get_owner(page + i);
 
-        p = mfn_to_page(mfn_add(mfn, i));
-        od = page_get_owner(p);
         if ( od != d )
         {
-            printk("%s: mfn %lx expected owner d%d, got owner d%d!\n",
-                   __func__, mfn_x(mfn), d->domain_id,
-                   od ? od->domain_id : -1);
+            printk("%s: mfn %lx owner: expected %pd, got %pd!\n",
+                   __func__, mfn_x(mfn) + i, d, od);
             return -1;
         }
     }
@@ -98,16 +91,12 @@ p2m_pod_cache_add(struct p2m_domain *p2m
      * promise to provide zero pages. So we scrub pages before using.
      */
     for ( i = 0; i < (1UL << order); i++ )
-        clear_domain_page(mfn_add(page_to_mfn(page), i));
+        clear_domain_page(mfn_add(mfn, i));
 
     /* First, take all pages off the domain list */
     lock_page_alloc(p2m);
-    for ( i = 0; i < 1UL << order ; i++ )
-    {
-        p = page + i;
-        page_list_del(p, &d->page_list);
-    }
-
+    for ( i = 0; i < (1UL << order); i++ )
+        page_list_del(page + i, &d->page_list);
     unlock_page_alloc(p2m);
 
     /* Then add to the appropriate populate-on-demand list. */



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:53:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:53:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235852.409096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNF8-0001X6-Nd; Wed, 01 Dec 2021 10:53:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235852.409096; Wed, 01 Dec 2021 10:53:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNF8-0001Wz-Ka; Wed, 01 Dec 2021 10:53:42 +0000
Received: by outflank-mailman (input) for mailman id 235852;
 Wed, 01 Dec 2021 10:53:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNF6-0001JS-SG
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:53:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 652bfe92-5293-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:42:35 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-FgZvrVmPMySAsPVC5_PT4A-1; Wed, 01 Dec 2021 11:53:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:53:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:53:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0107.eurprd06.prod.outlook.com (2603:10a6:20b:465::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 10:53:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 652bfe92-5293-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356019;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0OKNfDnsUjtw+PEZVjp549hJsBhAjbhkyxNkaubCrTw=;
	b=ksPPHNcVgyP7OTl5f7QeT4eqRoyop5MQcbEspB+6ZldaTGQb32NTBsIajmFObzosBbdcpP
	w5XoZPw00SnSdtsNm/RSvjkc4EWP5nxSC+POc3QIyq0hYobu71H+i8QPfk9Q2VYYSUg4ZS
	Y1r/rEqPKJmbvNaoYQrrxqlzGWxHMGo=
X-MC-Unique: FgZvrVmPMySAsPVC5_PT4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SJBBbvD0w7X4v3pY/jwz8YMyceXAaw8Vq5k63hcV2BNRxC6V5BFPlLX/cg6NtTX0bFHphr/2Vs0lbTxaUdmYCeP9Hf5HE3s42Jt8V6HpKWz645lM9mDGDC8VBJIF+o4wFUpGZ0vrQfIhpyfz+J7bJ235IgWP7Su7i9mqDMg44e35PdoPZogX/uxHPmq76Aeblx0IX+ixIZb29vxU43RMNB5rIOPbkzBHMKLiqcBzc0N7r4oIpxobVR2l56tpNE6obEIbNouP6rRwmHVVCNgr19hQN8/XiHbCJt3IIupRgGHmNicvQj93aImxQ4mP2fO8V/Z5Um07GvcgkRDZerCHrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0OKNfDnsUjtw+PEZVjp549hJsBhAjbhkyxNkaubCrTw=;
 b=e/IEfBMBeEA03WImd7WmMt1dpA9nJkbjXdZRjLJR6RqqyO8iPSt3esURIz0W1Y0ErP6ApGd2vd6J9COc8ytYM0GNOjT2Sh3Odeh86fg1Ew+1ZdMgX98N3zO81JNRoNDSefPlEif8si6xL/EdN2sXw4kN3HiYusKQvDTTzKYW2GjggyT2zq/X+5cMQ9/v7o6sHJogzKWPreqY6Bj/oMRE6uvH+YvxA7lEYfOU/X380SJeey3FfqL8jmMNyxiHaDtq9f962sggCdQoXfdHWA4DGr7veeoYRBtwfOeccVC2/b59dkLOnsIynlduSVJ5uUPNDYqxVFd/EgTx5gzy8iFeRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0ec2eb9c-a4b9-65c3-3751-3a7fb9b760c1@suse.com>
Date: Wed, 1 Dec 2021 11:53:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/4] x86/PoD: HVM guests can't pin their pages
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
In-Reply-To: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0107.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf323e91-2674-4621-5917-08d9b4b8d447
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5741E63651C152EAD0B3A105B3689@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2043;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JcK5rrlheRLPTKBLj4VCCKqMgct6tlF0uhZO+eO1P/Vio8ZpAMUgos1dHCBZOWCfm6ok9mZKkHMoygiEYUhzcLoOslpR79F/6rjwWPlDpKdtpFkloMf2qKlwDPJzSKlswvYdC9DhGrdiTupTlOiqsH74GvqEIt+7Yz0QHHJ/4jh+IXuApKEFun7o0BgVM07ryJAh3D1oqhmF5gTonEGy7d/GZzpzZEvaZ2EUK8KaAPpxagjIRxn4cFOvCZqWld3dsTaUwb9cdbTTuoOqSyMSAJPXA1UQFfXRKOKIXxwXDTwhV6iBeCEDElHXddOfQ8riljekEsG73NBS6kCv46WpcAUtx0j6pOmiol9ojIHwixRSBlilJ0I5Hgryf6mUH3axRyONRgj36YuuWcFjUnepsRoJ898yZgFrE65KjHllXqxCKAOCBREq4RU3vslfBsKc49Nr8x6UXE0pMrc/UWrJGzBx0lriHiEkaiJ2WAD+K9LIOiu3jisLAzYPFtgePHlFOeh6oAHW2c6AUZccPYNpfXVz1sdRYO9h4ZyQTjsLAcXGKncmoleq2lolHlTL1s26jwEMxm5BsQ52pZ3BDNeDIpuKZncNNYUZei51TN125pc2VeXm00aVVdVDRnX06mnRvmJUCTO777Sowd48cqfciEEd488sQpUK/OHCfTB5DXyA7DMY0qNWNLq24EGpBajoHwixOqyEpiUmrUegmAjHZ2jL0Jpm/f4uOcXFsM4uir8erDmWcL6M4QbPNwpkiqE+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(508600001)(66476007)(54906003)(2906002)(6486002)(5660300002)(66556008)(66946007)(8936002)(38100700002)(36756003)(2616005)(31686004)(26005)(316002)(31696002)(4326008)(86362001)(956004)(6916009)(16576012)(8676002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Uk1NaktQK3NqVlVyaVFjTFdpZnlDRlRJaWFlK29PajB1NVdhdDBNYXRkbys5?=
 =?utf-8?B?dEN4SCtSb3VtYmNTSFBMd1dwSEdyazQ0ZFBtVHhkUXJ5elJlNlVUVU1wR240?=
 =?utf-8?B?d2hyaDZUTnk4UXZxYVplQXhWcWJCQjNzOVBjbWo1ZkFtN0lQZy9ibXJmSkU5?=
 =?utf-8?B?MG1ML0NpZXRmdGVpeHVMSHlTRWc1M1Fvb0pOZWwwMjJhSC9wRzR4QW5xYUtH?=
 =?utf-8?B?Szg3cnBmSlU5WFl2RFRtOVZsT2J1VGxtd05FZlZwZU4vQVdRUVlXeG81UTFL?=
 =?utf-8?B?RFdyVTJRODRqM2xUbGtrcGtoNStkaXZwYk1tRThqKzNZV0RiQk5yZkVCdmUv?=
 =?utf-8?B?aWxMSzVFTS9lVVp2OTkrekM1TkFScElidUYyWHN5MzdIMUI2NFdLaXJIV3pi?=
 =?utf-8?B?cy9NbVoyWkE0S1grbVo3YmFhSUtJUmE2KzBzdU00eUdLaTJOOTFWT3prMEdP?=
 =?utf-8?B?c2I2cy9LWWhLbXAySjc0dGQreTRkR3VtVStrUHRMOHpDSEh6RC9EN2pTSi9p?=
 =?utf-8?B?dUR6eFQxTDhlcWVVc1NIc1dZUDlYWEhYdHlsYWhsT0xZZ1JQMjNHSzZWUjJj?=
 =?utf-8?B?Q28rbWhzcVY0R3RnRGNhcWtIM1VNRGR1TDRrQWVjUVNHM1FCQlBmZnFqWFNB?=
 =?utf-8?B?RnoydkxkZTE3Z1ZOc2piRnNPRXVibjgxbUt1MHhYZ3RSaWYzM0NIUmNmNnp3?=
 =?utf-8?B?UUhMaGZvV3dSckVMb2hyUUtWSkV2Sjh4T0E0dWNDdzQzdHZZTFNRK1RZR3RJ?=
 =?utf-8?B?a3FWdGdGdWNNRzFwK3lJMitsNGVVS3NTUnNUWGpLckV6ZHZ0eVQ0TFhrRzQz?=
 =?utf-8?B?ZmN2OEdxTlBZRW1kb2RGZjZrVkRpL2xCU3IzUjEwRVpaMjBzaERpWXJzbEpo?=
 =?utf-8?B?SW5JTzhaL1EzUzF5VXJUbDVPdndkK3I0eERtSnMwNlJYT3BtMXd3UHh0QVlK?=
 =?utf-8?B?QjRBTWNvc3RPZmZ4blpzeHR1eVNYSEJEM2tCL3F5T2RhWjV5WGxzdEFCUEM5?=
 =?utf-8?B?dzVvME5VeE5RbFFuc0dKckJSUmJPc0wzWVNqemRQem9CbmFDQ1VnTUEvNXZ0?=
 =?utf-8?B?Z2RYUXlvZWtWdXczaUR6QTkzZGlMV0Npb2dOMEFPU0tsWnEzNkVpY0FXaDJx?=
 =?utf-8?B?UzlIc3EwVTdnRUxpREFVWUhnYzdQdE9QbFIvNDF4ZUwyYW5Tc3NWTHA1NVJv?=
 =?utf-8?B?ZXdDc3VkTVcxaUtNYVU1N0tJb2MwQjI1M2wwemIwdEtXdU01UTdRUlRGbmF4?=
 =?utf-8?B?d0dNbCttK3RNVERZSUFsWURwM2tNVXo5eHo4MmVLOVk2UytJYk1qOUtQd0RU?=
 =?utf-8?B?b2c5RFJnUmR0Mkg1M2RoeVdsRFQxeFJqdTdWanM0U0JSbnozdkdGaDJIVHRi?=
 =?utf-8?B?WmN0NlVBRGhBamFraFpYV1B6dTZsSXRwQWJESEVBczU5WWZUbWVpbUN5RW50?=
 =?utf-8?B?UTdYZzI3UXZha3ZpRS8wbVNpUUR4K0Q3OVlDc2x6QlVZQ2drcCs3ay9ycjNS?=
 =?utf-8?B?ZUhob1ZsZ0F2MnpBUG8yWi9vVXk1Uko3K1E2anQ2TnZiUzhsWlRBbWswbFNi?=
 =?utf-8?B?U1lBZzAzb0hZa1IyTzk0YVQ4L21HQ0JDNCtia3hlbG1VNHFyazU3Y2RFZGpN?=
 =?utf-8?B?S0M0VFB4MERBeUxWNk9kN1E0c1VhWVl4bUNvS1VlRFovWkhMSWJkV0dDdEdy?=
 =?utf-8?B?Nk5saURhczJVQldYd2t0TEFmQ3V3MW5YMk9ReW1GM2FKTW1rYXpqaTJ3SVlZ?=
 =?utf-8?B?eEFhNUVjbFBvSlRzUmljN0dYVlh0cy9Ba2RGRGZHbFVPUEVlc2VCUDF1MW9C?=
 =?utf-8?B?aUFCUCs1LytoSGxIQ2JoelZqUzJQRkFXZS96YnI2WE1MbElRelNhcTVQWFR1?=
 =?utf-8?B?aFl4b1grM0Y3RWY4bFNFYlB2Y2JOK1FicHJPNGwzV2lVeDdqTDJuUXh6ckpT?=
 =?utf-8?B?bUtwK3h4cGFOK0dzQ0dBdEh5VWpjUEN1UkNpQjgwNmpQTnpSUmxHV2dIRTRn?=
 =?utf-8?B?MTI5Y0lXa3BocTRVOFd3bDhoOC9BcFJpR0lyQlduaWF0SlRQbGkwODZlQVdx?=
 =?utf-8?B?YjJKcU4zVnhyZmttNkJwYXFNOElnU3g1Nzc5WGFkVjFaUkhKa3U4Uk5wc3hZ?=
 =?utf-8?B?WlhaSjNibUwzSUhkVGpPQTFRMjErclloYldjeldEaEVwNm9qT1hxL1hBQ3dx?=
 =?utf-8?Q?I4iKWdBf4ABELio7SMYgJTQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf323e91-2674-4621-5917-08d9b4b8d447
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:53:37.9252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DxCtCIvilLraJpxPKoTcFeAQn21s/cCQebirkaoCfNgzTbPwhzCFjchJSgudAWhJqMm/ZTg9jNqtCnRCSe6Thw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

Pinning is a PV concept, used there only for page table pages.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm actually inclined to hide _PGT_pinned in !HVM builds; the downside
of doing so is some new #ifdef-ary which would need adding.

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -260,9 +260,6 @@ p2m_pod_set_cache_target(struct p2m_doma
                 goto out;
             }
 
-            if ( test_and_clear_bit(_PGT_pinned, &(page+i)->u.inuse.type_info) )
-                put_page_and_type(page + i);
-
             put_page_alloc_ref(page + i);
             put_page(page + i);
 



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:54:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:54:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235861.409106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNGA-0002DR-5K; Wed, 01 Dec 2021 10:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235861.409106; Wed, 01 Dec 2021 10:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNGA-0002DK-2T; Wed, 01 Dec 2021 10:54:46 +0000
Received: by outflank-mailman (input) for mailman id 235861;
 Wed, 01 Dec 2021 10:54:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNG8-00029y-0n
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:54:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16f9d8f0-5295-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 11:54:43 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-9MX1PPkOPlSCw58qVc7xoA-1; Wed, 01 Dec 2021 11:54:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 10:54:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:54:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:20b:311::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 10:54:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16f9d8f0-5295-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356083;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=pYFz+VhG8wlpeeBq7xjjYCfhq2Lp5V/iDsZjW/ovDgI=;
	b=imIlm5pRNg84YDoRkPkwItqf8B3QRaqv1lk4kXv4NY2vI0Ku4Vd6LgNxlabALe0RaYoQMV
	05Qp2zHhfGtW3fcsc0La4p5vHhe20s7pVyl1YXW0Fm4goofEqYAnfOZ2jgpjTJSuqk95yb
	pE9m6bgg5hH/SleEnrzJBnSR8olIZQs=
X-MC-Unique: 9MX1PPkOPlSCw58qVc7xoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WBBTSpNdiwDZqxh01E8ciNhLj9VUVZqkBGQFcvwb8LSIGNJKSaYOagsI0Cpv4T8H/wSrAZO6fmCEgLfKueeIt52KjhaWWeN9fbGIgDp8/WNpaPalGXEPFGh25XjNwfIEKBC4V4F/CYHlybr8x3nfeEMzRUm2sy8U496u394EkVVzkkzRoO9redw9EuEZA9sRHNn9qxUZYk5V2UOZqh9GgAS53kIkb1KOhK+cU7FdoDrBd+e5kOMquvTZkAP5Zo7lkfSQ5NWRFuXXTyDpcOT6+d9PawPNS7F/0iIeqdJxUsZYipOeneEcPeXcxM5e0nZNiifG+to/6IjB76wh47EjmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pYFz+VhG8wlpeeBq7xjjYCfhq2Lp5V/iDsZjW/ovDgI=;
 b=ixA8H4aV6ECgiwPYpLv+hTtNNeyECSC2c6wU8FplOlOvbnqnFMPe/6A3LprPoDCQwhv71417lbpfglF9+YKwJzBcl+ObUUwvwmdCBq7JRZsh7ivbGfXbG7ZzJTiuthAVy/Rx0dcM+mS7DGrJHRIr1er8KpJb0RIFVb4XZRFjsR2fNG7R8gTC93q+oItGHHFLn3xWKXkJxUYUOF1GaNgfXOMQBV+ymhR8DMCF5e4MjQajRDiV+T7NdfQ9VxPBVC5edqSbtKNzIak7pLr/osJInorLelTUf/AjJ33kuEk0GW6zICaqNA3JRcvMpQ3+ueCjSzFES2z5S0cyxcF0OOU0Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <09aaf19a-b03e-7f41-208e-bfc6bb968049@suse.com>
Date: Wed, 1 Dec 2021 11:54:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/4] x86/altp2m: p2m_altp2m_get_or_propagate() should honor
 present page order
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
In-Reply-To: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0022.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cafaafff-ce6b-4d2a-dadd-08d9b4b8fa05
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB574126DA5E5FE05B07326268B3689@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ko+I2e9g9myVvqGVVesu5g4R5QATjtcMaRgskJ1+mStj8gApCytF7yhQElxKshdg4CVNUJH2ofcJir/Jw/PT/lo/W2g7yEZYKnzuQGpvrM9ZiAEEpa6O9woAAfcgnfZ6a01FZ+sFpAxg7CBICoEG+6Q1yYvjUr5M3TxyoqSYRsGVCymsyuZzlEvmJ/JQnxG4pkOImGn2vnEK2ogLSfccFqVxaKAENI3hnrQg0w98ceRUk3+0SXv6mfHdtDB58cNnre5/MEPHGj7KRSQWOuYg/co8E34IZeOKzAJXlPVHVjs69Q9AY+JvX7vHbA/WB5dcrNbBg6Uss4+0VKm3Lv3QqFllGEjSeHd8AwrXBV22bM6kxqd3sBm1CpvJMnTBmc9CL2SmrpK1pTkmt1Z1iSAb/S5KZEp34UcTsis2s5TiWzN+KICQxfxKXEAq8HBAk5Yi5PoQi7dUu5E9imLRHui/EVUq4TKLxpchuqUTOrYjFw09DY95A+WVm/EYQ9c9VQcbm2HpqM+oQ7zoVuszyZDf4+5C/DRWHIfa4z1qz9VQ2meG9snEQkgkxiUohl9uLak3EVEQgYjwUUjjaOr2RW0T+c+Ck+RyAMslVU9tTUHp9m86F4p6nZrjvkRfQ+LLqFQpH7AtzxdHqPZGtHkPBgEV5TToXHvGK9pj2N80aQFz06HY27RiPwZKsSwaXmkYKBI8e9lv/qpkUn/10EU+J0TtKePEFX81mf2d4KOrlaQPYeF4gjfXF4ycoD+UIP3HA3yr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(508600001)(66476007)(54906003)(2906002)(6486002)(5660300002)(66556008)(66946007)(8936002)(38100700002)(36756003)(2616005)(31686004)(26005)(316002)(31696002)(4326008)(86362001)(83380400001)(956004)(6916009)(16576012)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SjQydEg5T1dRWnF4RGkxaXhKVDRHNXcwMzEwci9qZFl2NFZHWVpXcDNGWjNq?=
 =?utf-8?B?bjJGTEZlekR0bXVnM2lpMFBoc1RPRHZuS3dObXRHSXRKVGpJemVrRUpVQjZ1?=
 =?utf-8?B?ZWtEZnR0S1FoZ1RIai9MYXcvQ0ZLak16Q3I5OEdEL01xdm13QjNOcGdFaUpD?=
 =?utf-8?B?R0l4b3haVFd1R3F0MElBTWRFbEZ5MzFuaU9JUnB1TVZFRlIzM3kwOWpWOUNK?=
 =?utf-8?B?MUFoQ0tOOWZKMUdmODM4bnpOQTJwRFZkclkvMnNwbjE5MjBpYUk2amlJTmhN?=
 =?utf-8?B?VGJ0TXZCa0IweTlGRzNRL2h0VFhWNnVpRCtoSXR2Qk5xakJXN21ubmQ2RW51?=
 =?utf-8?B?SCtDMU1DVFhOWXo4U1FLbjNJZk5JWk95Wi9KNjRPYUwrWTlGNWtTYnp2STNh?=
 =?utf-8?B?aGlYeU15UnMvUmJhMHBXb3JUcXVnWmxEMDFEOUlJWnhEeVJwTGZCMlEwM2hB?=
 =?utf-8?B?ck52NG00bTVxT1BPYklJL1A1Q3dhOEhtd0V4ekcrWkJYajZWdERCVVJwSFM3?=
 =?utf-8?B?UGRqQ0lzeHVoVkhtbEdLS09sWkRKWEVLOFU5azBjZTNUSmtNM3hWT0dJYnQ2?=
 =?utf-8?B?UGhvSWxmVkRXS2hXVnFnRGJhSlZ3ZzVCeVA1UFVwaFpJTFBaUUNjbjA2Z0xa?=
 =?utf-8?B?OU1PVG02blZ4ZmNEME5WS1ByTDZiSkdjaVBNcU5uamFiQTRqUU5XaGdiejhG?=
 =?utf-8?B?bkNFMnVmb1haVWJlakhnaDQwcUZGSFdJVzNTZlZ5K0xlV1RKanBrQlluQTFu?=
 =?utf-8?B?c2xiTlU3dWNMcmE5clM4VFpMT3g1Smg1VWIyNG5vWUJneE8wQ0plaFhVQ1Aw?=
 =?utf-8?B?cHNqajU5cHJ0YjdLaUZuckdZb2tQNjdYVjRFT1RQSjYrbGxTOENnRXprNmZw?=
 =?utf-8?B?M1ZaZUIvWlE4c2RKMEZhaTVNQnZRekxEZVZkVHduT21tNFpUWDZCZFU4ZDdE?=
 =?utf-8?B?V2sveTM3QWpubFJWYnYzL2VOb2Ixc05RTUdxc2ZhZUQrYytlR0tXL0hXdU4y?=
 =?utf-8?B?UllZNGpteWVuNk93VnNIWFhXMWxnY3pnYUIvZk14T09hbFlLakFzWU1wUnRP?=
 =?utf-8?B?aXdkWk83anZEd0EyUWU1U05SQmF4dFdVelZUM1EyRnVCbERDRzdVb1Qra2pN?=
 =?utf-8?B?OXNmNDNPNXRBWmdLOXJKY0o4V2lYd3UvN29iMU9qbEVXS2ZaRzNWNXV6NTZx?=
 =?utf-8?B?V2lWek5LVVdURmRBT2tyMHdNRUdVN05scWllTHhjRnB0Q0l5REF6QTRmYVor?=
 =?utf-8?B?SWx3UGI4bTJsekR5eGdlc0N5WGdmM3Fmd2psWU1RM09rM1d5bkplWVVFUkFB?=
 =?utf-8?B?L0dIK2FtZXNSdFVNMWZTLzRlbkd5ZEcwZi82UlVmbFZ1TmNLMXNHNER6ZlF6?=
 =?utf-8?B?dWIySHNYMTdpV1NwWEFVMUM2emZmR2JBM2I2UVJVc2FRTGZzTjI5S3lGNUtP?=
 =?utf-8?B?WHhQWnBpVDRlUmVOUUxEM01pb3R5OWxyZG5Ed2g3TjFHY1NHc1pzRGx4cEcw?=
 =?utf-8?B?QStuOXlHVlAwWGVzVG51YWpxS1JOR2tmRUxxREYxaUJOVlcwUWw4QUN3cU5i?=
 =?utf-8?B?K3FkMzVBbWdpUzNxT2hONy8ydVpDYysvQ3NhSWR6Q2UrOVN5SE0zalZDTWFK?=
 =?utf-8?B?M2NINmJVb01rUmZWRFBaZnQwMGY1cmY3cU1yN1B6TGFId3JZOFZUa0pLNkRI?=
 =?utf-8?B?SmxLREc5eGhJWmx5MjRqNlJnV0MrU1FUZTVZQ2cvSGRvakdLUlhwT3U0VnRh?=
 =?utf-8?B?TEFQd2ljRDVGd1V0VFFvZXdsaWFyTVZmczAzQmlPOEpCNG41SVVQVys3OG4r?=
 =?utf-8?B?eUFmOE80NGp4aG1Ic2ZtMTVsU21BUlg0eTlIcUZLQ3Y2UWUxZm5uZFh2YnVo?=
 =?utf-8?B?N3Rjdm54RlBjL1VveGhYUXhacFRCb1JDekd3NnBILzk3cnJEaU9OYTZpNXVh?=
 =?utf-8?B?eVhzdGluaHl0VEJBNDl1c3ZETUl0cVFTbU5hR2VOVC90eXpsUzNEeDVVcjFD?=
 =?utf-8?B?UmY5cUdYbzZUNzJGZW5IenJJdkxGTHN2bzJkWVlJRmUrcnhKVmZXWFRjdkRF?=
 =?utf-8?B?cnV1SFVRL0dJU1RtZ21IYUpNNUVvdjlROUV0WFNVYWJFRkJJK3U1NUpHZWhw?=
 =?utf-8?B?L2lvcXdHb3grdE1uaG5IWEU5emhyU2tTMmV1cU8wR0tCbmVWMEpLeTFabUMr?=
 =?utf-8?Q?OmmXtNF5c1wOjwu22Kf3JNc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cafaafff-ce6b-4d2a-dadd-08d9b4b8fa05
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:54:41.2405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LC2qngut7yEBEc52JlE65ip36VjwAk2iOaCZXA1779do7YI8JB+YKGqSAr2pLIVI2IqeWel7FQhQq4J5z8d/6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

Prior to XSA-304 the only caller merely happened to not use any further
the order value that it passes into the function. Already then this was
a latent issue: The function really should, in the "get" case, hand back
the order the underlying mapping actually uses (or actually the smaller
of the two), such that (going forward) there wouldn't be any action on
unrelated mappings (in particular ones which did already diverge from
the host P2M).

Similarly in the "propagate" case only the smaller of the two orders
should actually get used for creating the new entry, again to avoid
altering mappings which did already diverge from the host P2M.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1826,7 +1826,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
          * altp2m.
          */
         if ( p2m_altp2m_get_or_propagate(p2m, gfn, &mfn, &p2mt,
-                                         &p2ma, page_order) )
+                                         &p2ma, &page_order) )
         {
             /* Entry was copied from host -- retry fault */
             rc = 1;
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2198,10 +2198,11 @@ bool_t p2m_switch_vcpu_altp2m_by_id(stru
  */
 bool p2m_altp2m_get_or_propagate(struct p2m_domain *ap2m, unsigned long gfn_l,
                                  mfn_t *mfn, p2m_type_t *p2mt,
-                                 p2m_access_t *p2ma, unsigned int page_order)
+                                 p2m_access_t *p2ma, unsigned int *page_order)
 {
     p2m_type_t ap2mt;
     p2m_access_t ap2ma;
+    unsigned int cur_order;
     unsigned long mask;
     gfn_t gfn;
     mfn_t amfn;
@@ -2214,7 +2215,10 @@ bool p2m_altp2m_get_or_propagate(struct
      */
     p2m_lock(ap2m);
 
-    amfn = get_gfn_type_access(ap2m, gfn_l, &ap2mt, &ap2ma, 0, NULL);
+    amfn = get_gfn_type_access(ap2m, gfn_l, &ap2mt, &ap2ma, 0, &cur_order);
+
+    if ( cur_order > *page_order )
+        cur_order = *page_order;
 
     if ( !mfn_eq(amfn, INVALID_MFN) )
     {
@@ -2222,6 +2226,7 @@ bool p2m_altp2m_get_or_propagate(struct
         *mfn  = amfn;
         *p2mt = ap2mt;
         *p2ma = ap2ma;
+        *page_order = cur_order;
         return false;
     }
 
@@ -2229,6 +2234,7 @@ bool p2m_altp2m_get_or_propagate(struct
     if ( mfn_eq(*mfn, INVALID_MFN) )
     {
         p2m_unlock(ap2m);
+        *page_order = cur_order;
         return false;
     }
 
@@ -2237,11 +2243,11 @@ bool p2m_altp2m_get_or_propagate(struct
      * to the start of the superpage.  NB that we repupose `amfn`
      * here.
      */
-    mask = ~((1UL << page_order) - 1);
+    mask = ~((1UL << cur_order) - 1);
     amfn = _mfn(mfn_x(*mfn) & mask);
     gfn = _gfn(gfn_l & mask);
 
-    rc = p2m_set_entry(ap2m, gfn, amfn, page_order, *p2mt, *p2ma);
+    rc = p2m_set_entry(ap2m, gfn, amfn, cur_order, *p2mt, *p2ma);
     p2m_unlock(ap2m);
 
     if ( rc )
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -852,7 +852,7 @@ void p2m_flush_altp2m(struct domain *d);
 /* Alternate p2m paging */
 bool p2m_altp2m_get_or_propagate(struct p2m_domain *ap2m, unsigned long gfn_l,
                                  mfn_t *mfn, p2m_type_t *p2mt,
-                                 p2m_access_t *p2ma, unsigned int page_order);
+                                 p2m_access_t *p2ma, unsigned int *page_order);
 
 /* Make a specific alternate p2m valid */
 int p2m_init_altp2m_by_id(struct domain *d, unsigned int idx);



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 10:55:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 10:55:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235865.409117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNHF-0002p0-GM; Wed, 01 Dec 2021 10:55:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235865.409117; Wed, 01 Dec 2021 10:55:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNHF-0002ot-DW; Wed, 01 Dec 2021 10:55:53 +0000
Received: by outflank-mailman (input) for mailman id 235865;
 Wed, 01 Dec 2021 10:55:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNHE-0002ol-4e
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 10:55:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b33b6bf5-5293-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:44:46 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-VSVIWibIOeSt9CkaisyGAw-1; Wed, 01 Dec 2021 11:55:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4383.eurprd04.prod.outlook.com (2603:10a6:803:6b::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 10:55:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 10:55:46 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0051.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 10:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b33b6bf5-5293-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356150;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EubbiLSoJ7gBkAT814XkFnEd7VOT3g+5pVKJpSG0l1c=;
	b=iX9J4B76o6sp2RAgzhXzerJIYLRl2W2kHIKHw1LtwBy6NbC/5waOiSHhGUp3N44cwepuao
	RFTea1W4303fUUkiY8KGWjTYEIg1cBrHcPX8T4Ahbv65yyecl9AWlkQVHME+0d6gIZlG6d
	x8J+aGGu87RN9iWC2SRhQX/9G1Ov5Xo=
X-MC-Unique: VSVIWibIOeSt9CkaisyGAw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LpGOdPH53N8SypL5PcJCQLZg7FFjVb8YdgJjtqsyL4ByymsPcCz51drN3Ep0QRnTVtrWFcimIwbl7+aFOov26OBkR+44eQcu+8FgU9rlATRU5VXFSjSG7QrzVD7mAvZ7FtK8VGGjgRMRou/kLtSW8ClgUvvg4DzQZIz/NirAz+Jfpj/bEv66VeABhhzVPdaDdslSmI6ebl6yB8hjtkhjpTHe9fCdydlYrIiDfhCDqsnV9bdpuutpAiyYxxLiytsGVWdABtk8o9DcU4CXd3naErSQmvHfSH3qrk/xmAelzUDphztKoJErqF9wfjQF1VRz2PKMuRVBfjaaX0DUWDEBsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EubbiLSoJ7gBkAT814XkFnEd7VOT3g+5pVKJpSG0l1c=;
 b=gXCcAbERJqCRQuOg+CNEEQ1BCheq0y5yLlQJlfrAVQvRNag9LcRItK0swqggorQc4a/8XI1G++BczOXBmThpk65tBw/lAEaphyDhSs26snccEq45aXAWwhsWo/HEVh9wW9l6/C4pSeFSW0kOg2qrZRvKIUBdRDaHYFaswPOQWe2Xxz4BKpCVghPzZQVaCRDn++PxUd2ElOdud0x1rwA2i6gcfQbmKuHhYwhMBCOn/+YrbNtnalpVGP0XQ4VeVXicOI7zzNy/z56/eAaf6hd/vtNwl6/1NMCeJh7EJ/gdv9GtwZL847MSTTkfyivuUrHcRdHbtG5FD9UX9Nqend/cAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58a47cd2-1ba7-730e-efd4-7ade1f415924@suse.com>
Date: Wed, 1 Dec 2021 11:55:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH RFC 4/4] x86/altp2m: p2m_altp2m_propagate_change() should
 honor present page order
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
In-Reply-To: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0051.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 00b870af-3c49-4fd3-4d6f-08d9b4b920e2
X-MS-TrafficTypeDiagnostic: VI1PR04MB4383:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4383438B123ABBBFCB4015BAB3689@VI1PR04MB4383.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CrGgslRV3CdEcWuRxSFRDUheEqFLzrSTULfmiOit9lW1BV5+uYlv6uDi5IAClaAR7CkdvCM3tXYPG5Kiy0IxVrvSKxjIo21E8CFNqsZm11M4jLftiGYQuVDKn+MneVm33noRUGrrEHgWFK85VcfsRM+dYrHRN9mcwqeH7UlvI+/BPcwugSvqkDP/JQ2sW8HSBMMDRAwz6Tk41QhEuTavyHyHUeOqI/zJqrS4/TAFdiyN6/C8FBTU5riHGF4qLTgLE/KDpfuRvk95TTO6QwCU4VIoQwerPFLW5IXcdkOAho51fw2NQvijJNJeq2HD1O4Kd9XnU/vhyvpT9t4JA4gExYGfb7+Q3bONkRGYBhHJc+HTDN6nx/01N2otDMTop3ANQ0hBX+apEo4hXv4Om5WowK4kDaUj0pK+PRdavuqSORP0UbQtzknchfMnGBlxll9QiotqTpqtyAmJgc9xl7Oo84KLpAz9hnajVrnOxmGCt4JSptPq7MF7p20QBiY4iaTEHHeAgD09r0IZMFcAzhX7mkY0LwRYl9lygafTeS2GH62dYVgY3gzYFNS1G2dA9fU0MnJpfo8SUCObTcbu4nhFwuhlIh8SCB9yCROOWsFLA7eZFX71JVgLZFo6iNTl9SnQvO49CII/6W6B+h0Z6CKvaKpjNCyAZq0A9vSwxGnWfkhc7WG36aDHZQKOLkW45wwlPRYT++kEiQsEby4J3EWkjfDbSfvfQS+FVTvf1xbstIqMrgjeTOmHJPfX3swC4MdUeQgMuGjwgigcmxAKN5lUlQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(8676002)(83380400001)(2616005)(66946007)(31686004)(8936002)(186003)(86362001)(5660300002)(956004)(66476007)(6486002)(4326008)(54906003)(508600001)(6916009)(26005)(38100700002)(316002)(2906002)(16576012)(36756003)(66556008)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzU1M1ZITW5DMU1CaEZkQ2lvNUhFVkh2UW04RWp3UENSTTgvZmNZOUszSThT?=
 =?utf-8?B?NkVxSUF3blNNL0xMbGJ2WURHWlkyclA5SmkxUUdKVEhpSEx4eGxiYkRJWU5J?=
 =?utf-8?B?SmxkNHhGNWhMRGFLK0dkNllOMktXTWJCNit4TlNvc2FkOUlvUkozOVdMaHJz?=
 =?utf-8?B?KzEzdmV2cVhXckZIUSsvQ2M3MzdoTElBOTdxeExZSkM4UEFWQnE1YjRQdWNW?=
 =?utf-8?B?a0JEVUFid1RNWEx0Zktja3RLSnBCWEZQd2E4UlI4aENycng1VHBRVUJTK2o2?=
 =?utf-8?B?QVFja0NBKysyTFVMNDJ6MFdSUnNaVlJBd29MWVRMS3ByWnNsT0lIdVJTVzdE?=
 =?utf-8?B?MWhzNU1uNmpCS2xNbjFmUmgzVkZtaVdEUGxHN0pvU2NHWUdEUWZPQUt2VUxB?=
 =?utf-8?B?d2F6d1BOUWFTMG5VeGh6a2hlN3RjVVRVSUZRNEZFM2tZNTNLY1V0bXkwMnMx?=
 =?utf-8?B?Mk9EVEp0YllSOEJRa1BXdFloU250aVM2MlJ6YmwxUytYRkoyR3pBNmhpRUkv?=
 =?utf-8?B?T0l4QlVIT2VTRWxmZmdaTU9jQXpYV0pzUStiVXFveXFpTE9JUU5pWk1CTVNo?=
 =?utf-8?B?WmVLU21yY1NHZGpWSFovQ0l0TlVGMzRMTDhONEJMQnliTUhLQWhKV2xYd05i?=
 =?utf-8?B?TFJDTENSc3hqUURZL0FEcWF6OXJqckY4WjZNQ3JzbFkxUzdwMEdCWnZ0RDVV?=
 =?utf-8?B?NnNrbjhOcVF3aFQ4WDRJU1l1c1J4Q2tSTmdmOWlWSmZFR2M3M1VaeFN3WGhz?=
 =?utf-8?B?c1RwbjBieFdvSmNXN3pqT3FaUjM5bmhHSUwyMGVRNUJnMkxUVG4wT2cyZ3cx?=
 =?utf-8?B?NjlVVzVIc3NnVWdRZXlKMklZeURudmhxY2liV3hhQXExREo0VkNEZ2QwQmdr?=
 =?utf-8?B?U1ZJaXNxaC9nZ3lIcGkxSnlWWmZUWlRKRWlQeEM4VVdwMHBObjlIN2hoUXRM?=
 =?utf-8?B?a3Irb0h1NndqVGYyVmVkaUFCbTdPMlpJSXNxN2Fxa1BNTUR3dk9OT1dyakxt?=
 =?utf-8?B?RXh6ZTJkb3VyK3gvRDF5S3ZvcWtCRXJ3Z0tLM29WZFh2S0IwZGVrZXF2Z2NJ?=
 =?utf-8?B?dTFMTTF4Mjg1Q2xhQ2xyR3VZU2kvdk4zYUN4aGlIbWNUV2ZHZEMvaGw2bWtv?=
 =?utf-8?B?UmNFQ29lLzdFM0I2V0kyNjdGczZtcEJqRWJIa2RYcUhwOUdIbVI5NGpxZXBw?=
 =?utf-8?B?UlZnNEQ0YXFMU0lKUEkxcU0ySENkNGRyOUF0dmM2VDVPQ015U2h4REdia2NT?=
 =?utf-8?B?bVdBTVlFb2JmdVIreDYrQTA1Y1l0b3RSMmFCbW1ubkNCdTRJVHEyZGYxTVRV?=
 =?utf-8?B?c1NJVlNsSytEVWU5VTA4WjJXbWpTTDZIemwvZlpHTG5mNStZbHVGK3R5S0xH?=
 =?utf-8?B?OUQrWEdJVmNjZTZiUkovL0MvRlRSVWNKenJYS21QVjNIeEJERDFDSTh2czBo?=
 =?utf-8?B?eERud1JxV3BSN2Y5SlliaXoxTTNqR2RVTTNPVllCZk5KbDBCMytIMnY2dzVD?=
 =?utf-8?B?TmlIbEpmUm1JbGZZRGVtYUt6dUhaRjA1UHE3SWdwc05LbXZyazlTSVV1ZWFY?=
 =?utf-8?B?bjA5QUdYaThDUjh4cWhLV21RVkFRRHp1NEtIWnFEOTNOQ1Fobk1wZE1GTEJL?=
 =?utf-8?B?QU00YURibE5seitKVHN0TFVnVStxdGx5cHJNTTc4cmNoOHFOZXNFMFdpMVM2?=
 =?utf-8?B?SUppV1RqTXZya0FvMXMvSWNCT1ZKTVMyajhIWGcveDhrblRNUDduZnU5aHpE?=
 =?utf-8?B?aCtURzZrbWgwb255TjhDNmM2bS9BMzhXOVJVTmpKbVBrYVBnemI2M3FDNGFk?=
 =?utf-8?B?VHNrUng0OTJDU1BPZ1ROUVVYWkFVaEFYaGZJeTVGRW9jUDZ4cVNIRWJFZjJ3?=
 =?utf-8?B?bGFxemxiQ1hjbmVvdHI2eVhObEhKc3BuSHJKMUhhQ283dklwanR6RmdQN2V6?=
 =?utf-8?B?cjhxZEZUUU9ES0s5T0gxRmRrS2tBUEJuTjBoSW5RaTdNUmtFSE1Gc0lxcDdu?=
 =?utf-8?B?clNHRzFISGEyc3U5QXNaZ3BSL2JHcCt4NStHdko1bjUyaTlvTFBiaDMwZWtU?=
 =?utf-8?B?SStzekNKR2p6VVdqWWtZUHdpY2R3VlpiNmUxRzV1bmtEd0NhUFd2OUFsNWc5?=
 =?utf-8?B?SnpYblN3STBzdGdVa0xTbUw5dFVMSm43TzEyejRIY0luS2VleU5rSjNSc0JM?=
 =?utf-8?Q?x8FlhCIT/ZSK9o8STyABZ58=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00b870af-3c49-4fd3-4d6f-08d9b4b920e2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 10:55:46.4376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SyggMt3dIO6YL3yhqmaHi+DaZrO8aLIMf3GasfdYUVXVE/gvJnkjGWwsn6+rAc0MCHl8UUM1iQw06Ll+EwcTkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4383

For higher order mappings the comparison against p2m->min_remapped_gfn
needs to take the upper bound of the covered GFN range into account, not
just the base GFN.

Otherwise, i.e. when dropping a mapping and not overlapping the remapped
range, XXX.

Note that there's no need to call get_gfn_type_access() ahead of the
check against the remapped range boundaries: None of its outputs are
needed earlier. Local variables get moved into the more narrow scope to
demonstrate this.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I may be entirely wrong and hence that part of the change may also be
wrong, but I'm having trouble seeing why the original
"!mfn_eq(m, INVALID_MFN)" wasn't "mfn_eq(m, INVALID_MFN)". Isn't the
goal there to pre-fill entries that were previously invalid, instead of
undoing prior intentional divergence from the host P2M? (I have
intentionally not reflected this aspect in the description yet; I can't
really write a description of this without understanding what's going on
in case the original code was correct.)

When cur_order is below the passed in page_order, the p2m_set_entry() is
of course not covering the full range. This could be put in a loop, but
locking looks to be a little problematic: If a set of lower order pages
gets re-combined to a large one while already having progressed into the
range, we'd need to carefully back off. Alternatively the full incoming
GFN range could be held locked for the entire loop; this would likely
mean relying on gfn_lock() actually resolving to p2m_lock(). But perhaps
that's not a big problem, considering that core functions like
p2m_get_gfn_type_access() or __put_gfn() assume so, too (because of
not taking the order into account at all)?

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2532,9 +2532,6 @@ int p2m_altp2m_propagate_change(struct d
                                 p2m_type_t p2mt, p2m_access_t p2ma)
 {
     struct p2m_domain *p2m;
-    p2m_access_t a;
-    p2m_type_t t;
-    mfn_t m;
     unsigned int i;
     unsigned int reset_count = 0;
     unsigned int last_reset_idx = ~0;
@@ -2551,12 +2548,30 @@ int p2m_altp2m_propagate_change(struct d
             continue;
 
         p2m = d->arch.altp2m_p2m[i];
-        m = get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0, NULL);
 
+        if ( !mfn_eq(mfn, INVALID_MFN) )
+        {
+            p2m_access_t a;
+            p2m_type_t t;
+            unsigned int cur_order;
+
+            if ( mfn_eq(get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0,
+                                            &cur_order),
+                        INVALID_MFN) )
+            {
+                int rc = p2m_set_entry(p2m, gfn, mfn, min(cur_order, page_order),
+                                       p2mt, p2ma);
+
+                /* Best effort: Don't bail on error. */
+                if ( !ret )
+                    ret = rc;
+            }
+
+            __put_gfn(p2m, gfn_x(gfn));
+        }
         /* Check for a dropped page that may impact this altp2m */
-        if ( mfn_eq(mfn, INVALID_MFN) &&
-             gfn_x(gfn) >= p2m->min_remapped_gfn &&
-             gfn_x(gfn) <= p2m->max_remapped_gfn )
+        else if ( gfn_x(gfn) + (1UL << page_order) > p2m->min_remapped_gfn &&
+                  gfn_x(gfn) <= p2m->max_remapped_gfn )
         {
             if ( !reset_count++ )
             {
@@ -2566,8 +2581,6 @@ int p2m_altp2m_propagate_change(struct d
             else
             {
                 /* At least 2 altp2m's impacted, so reset everything */
-                __put_gfn(p2m, gfn_x(gfn));
-
                 for ( i = 0; i < MAX_ALTP2M; i++ )
                 {
                     if ( i == last_reset_idx ||
@@ -2581,16 +2594,6 @@ int p2m_altp2m_propagate_change(struct d
                 break;
             }
         }
-        else if ( !mfn_eq(m, INVALID_MFN) )
-        {
-            int rc = p2m_set_entry(p2m, gfn, mfn, page_order, p2mt, p2ma);
-
-            /* Best effort: Don't bail on error. */
-            if ( !ret )
-                ret = rc;
-        }
-
-        __put_gfn(p2m, gfn_x(gfn));
     }
 
     altp2m_list_unlock(d);



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:00:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:00:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235871.409129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNLS-0004OY-1X; Wed, 01 Dec 2021 11:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235871.409129; Wed, 01 Dec 2021 11:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNLR-0004OR-UR; Wed, 01 Dec 2021 11:00:13 +0000
Received: by outflank-mailman (input) for mailman id 235871;
 Wed, 01 Dec 2021 11:00:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNLQ-0004OL-Jz
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:00:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4e925466-5294-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:49:07 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-aNetI7jJOlKv47Am3j4Djw-1; Wed, 01 Dec 2021 12:00:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:00:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:00:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0006.eurprd06.prod.outlook.com (2603:10a6:20b:462::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 11:00:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e925466-5294-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356411;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Domd/tDjwr4GN/FZ5p50vnlB3Hho0A6+Sd4g1UWyLvU=;
	b=B1wNNhfsOxLstAwjUq07Z+8OJbskPAcdH/YMk2LaAZfT+40104YJ2WqCPfSWbd1zLjUFZt
	+OtKXQCr3B0wRq3ErYTs9RlEfj70IJ/ewkUavkYgs67uBBET0L3Y4qPQLGgKFKzw8x4GRZ
	htDsByCQp3HNtF5gssyuMUr/qBMfhPY=
X-MC-Unique: aNetI7jJOlKv47Am3j4Djw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R3oFWTqMzIwIB3hmCZJjNP1SiPNVIEs0eZx+PzI2teYIpOl8yOL9kT7+pcHAt/Gm432f0SkD+te7xSvf34iVoHiF/jL0NWvW4H8w6Aq5w0ktW2d6Ge7oUQnsQEiU1+HQVPtiDMX2nSt+6hiaYqn6DWbiS4Gfv4UV5ZyVff/WOqgxPEMsdnIf532jyzRQOUwtOf8WfbsTCZ6TPCzkpVUS6K3vMNl54Mo/KMGabC3Fh6E/tzC1vIY8oJ7JJ6HdWJKNSUHJDy8c1MNUtHriM/hqOxAViZd7d7uKRRSUQhLdjSRJLAaehF6FsvRHPEQoVs3ynQcDFhKdxn8PKlUh2Iallw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Domd/tDjwr4GN/FZ5p50vnlB3Hho0A6+Sd4g1UWyLvU=;
 b=SNMpbdgivM4XM3hJXVjFhquFUqyF5lm6oenv81H80N3U/80G82qPQLHjmeyxRRi/DR+CtJ+NuJoHl3XTXK9P3bbKp3spUMp7S1Wb7fHUpcwLql0iZgOpB3Q0v/aeSExJxBoBCQqLO09XEWqjhZv3Zism+Fs4fGT3EX7MHsTx4VIiMILhRIpt5tjoOLxMGKo5FiURu3SQlsCaEc56Ez6+XWAeBhytk6k29cz8HN7w0F94Edmbw/OYmL0064zmyyTfl6XiM8mhE4rkbuxYU6yQ5buh+2t8FRUMq+7nvjBiYs4FtyrYmXtp0paAHCvPh00hfX+E93bxekf2szQkj0uq6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
Date: Wed, 1 Dec 2021 12:00:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86/mm: XSA-389 follow-up
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0006.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c9e0ef3-a78c-48ad-01dd-08d9b4b9bd64
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5743DF1EC09105B3EB6E5AA9B3689@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1923;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3n5hdaYwKhvlC0SDxP6bZYOUX6uDvMYp5jBfOUP6ZIENupTu7NH1/jJ20AB3uVys7ECneUqiNpl5Vn26W/aHVDJ/EbHlyHA32kRFEwWpjaZLg1lzTpy0cu6bzCbEwzLk/jKveoV6xJpyfUGmEq+Ggp0QHlZmBRnpOAQkMcMlDdfMR82AaFc+Yy++az5jC2TS5XObNaiq0BYJqrYkVK9FqL+rwjnBAIeVvH5yKo9PSqQQSvzKR/rvhNkgcSXs8xApKRDrfBb/MhPa8OC+lvSZzapxbhNxbAvfYFPcMQeIZo0diR4jmZ8Q0c3k4zs7LFR2JErDMgn8f7cGPf2Ev6lLVLL1BAAUQyWDLM9aajf/vGr6KGBKdS4f8sZSHCui1TbPMpZNM+4PLOlt7x/7Z7n9HffUYs4Lb97PXze7oGBeLIoaU03079/QH81A3x9JgAfHlrWXkoaiVvlocMxfu2dKEM4j7Z6ERFUi21TmsB4RZOzEIKb7EmDjKeobbSX1Ahp1o3+Hlsw9TUgyx6JxBXcvAbeJ3o91331f5WFYj+9+BFkqX9Zs5GXAxNvIgL/trYUtiKrVlQIcFdyJYIDM4zHly4FcIo5iiDstmSng7pIBdOwiehya2o2lFY1GNMGqqUCzIziY+Ib1ezZ8xIVQbPWxV9gt2XDeDP2kajpAbBnhOxzEIVhYhd3ckrPsv4vFIycDDuhdPCX3pzDgS2MAEmlznxL9OsbUukR0H4hByWT3HJCwEJhyWNJMrWTU/7iiVbxx
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(8936002)(16576012)(316002)(36756003)(6916009)(31686004)(66476007)(66946007)(38100700002)(31696002)(5660300002)(2616005)(956004)(54906003)(6486002)(186003)(86362001)(26005)(508600001)(4326008)(8676002)(558084003)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWNPSnRPemk4SDlSVldCMUlzb3h4Rm9DcDhDckxEWG9MbTUwWXZPOUFvdGt3?=
 =?utf-8?B?aDNmeERGQ3M4eHBHUG1aR0ZPUWFZSUZCK3lHUWFVd0t5SHM4czNsWDlYOFRi?=
 =?utf-8?B?V0E4bWVoTjRNaFNBQW1zdDlZbEQwU2NmMk9vVEtoU3BiaHVMR3B6cUJpU1gy?=
 =?utf-8?B?UUgvdHplNmNoa1lINFRqUjk0Q2tTckJsZDZEQTB6YzVEQkdSd0NVOU5TTm9X?=
 =?utf-8?B?ZnFOajhYMlZXMGJLcEU3dExsREloZXlwUjlUSkt2WFptb1NKN3E2L2RHbjdy?=
 =?utf-8?B?WHk0MTFzQ3ZJY2lOM1RMZHBlaEV6ckpWYUppK3QydS9zVFpLYjhyaUZPdEJ5?=
 =?utf-8?B?ZXIxWXJQN0dxVWpyNnpKU2ordlFvaXlzYU1qNVFhWUNpcFZta29uaW5pK1Mr?=
 =?utf-8?B?TkwvTTNSaGs2OFc3bmd1cEl0T1EzTEEvNTV0R24yeU5WVFA3NnJ6elhJWlo4?=
 =?utf-8?B?ZlhvaTZIMFRtUXJDa0lma2ZYWWhMRmpBek83aG50Tkk1c3ZFOTRycEpXL0wr?=
 =?utf-8?B?ZWsrQkhreFJWOEg0NkJUL2VBaGF2NTZIWGJXOHNjb0dQUGg2SVRaeThZL3NE?=
 =?utf-8?B?Z1oxQXJILzJzeE41bC9ZeGVxYWxsZGI2RGt0MmJWTDFFVGZWSU9uSHY0OGpB?=
 =?utf-8?B?UlhTTGNmcmRDWmY0bzR4UTRjMkJXbzFJbTdFUXFZWGNlKzJJcFJPQkphU0pO?=
 =?utf-8?B?ZEJuWU02NzVjSmZOZWFUTVZkTFF0Qm43VDJlWkszMVh5a3VnRCtVaytUQnpt?=
 =?utf-8?B?S0o4MmFWK0VGSVdCRGNoWmM3QXdEQjN1Y2YwMXF6YjYyZHppYUVQcnhCZ1Fn?=
 =?utf-8?B?WnBsV1FJZWZlY0JZZGI2aXlvUjNua2pFK3BuZkhjelJmMmhQV21Md296eTBv?=
 =?utf-8?B?eHRENVZ1cG55czdic3NrWmpWNWVPOS9UcDdRZnFqRzRKQ1B3cXF2aWVmZmNQ?=
 =?utf-8?B?ZkhvZDM3VW5zbHJyeDZqSEVYNEVzWDZCTWxEZzRjeGdnMUtYVkxMTm0vaDFk?=
 =?utf-8?B?TDNOeXI4MlRFeTZtYlFzQ0VpZURIM3lGaWdoUUZ4UWZyUzFkWXdmc3pSOFNr?=
 =?utf-8?B?TkVkMk56d24wTmIya2pMbE1yNVBDNEgvWk5CeWdCeFdiZFJ1cWJzeWt3bGh5?=
 =?utf-8?B?L2tmREE5RGcwTlp5SmhIcVZsS0pTT2ZrOEZYaDVybzB3SFpEWUp0OEd0MU1u?=
 =?utf-8?B?alJaVVhYRUoreitSbi9FRHhLOEtqUDlOUEE2Y0dJSUtPb0dRTjJJODF3NDhT?=
 =?utf-8?B?Y3h1ekUwaEpHRnJ4MHhrUVl1YjVOQkRkSmdyRjFzeTIvczhpbUlqaHB0L2xF?=
 =?utf-8?B?VmlZYWxmMk5jUENta0Rjb0tmRDdlN0FjTGdORzc3Ylg4STVicW84QnNVcGtS?=
 =?utf-8?B?MXY1TGhFOTFJQkQrY1F3Y3BTYmo0V3NsNGQ2MkQwVWFsd01YR2Ryb01CTWlS?=
 =?utf-8?B?Z1UyZ0xlWEc0OGNLZ0p1VzA5U3EzOWhRVEdROVhoN0JDUHU3TjArZlZBSWtL?=
 =?utf-8?B?dDVHeFdab01zZ21MU1FKSVp5dllTbXFHYWsybHg5M3VEakJOd3E4Z2xjeExC?=
 =?utf-8?B?VEUzYUhvcHZDVnlCS0VhbmVSdll3TGM5U0tnZFFLcnUrd2NtbXNmMlM4WHU1?=
 =?utf-8?B?WjVTZHhOUjVHRUlVbnAwUlN3WWZFZGNiZkh3VENLclc1Y3k1cDBOT3Q4eVRq?=
 =?utf-8?B?OFJLV3R3SFphR1ladkRrcnY3SU1tQkRHTERZSVpVRGw2ZEFVQnNNZWp1bWFS?=
 =?utf-8?B?akdDVFZuRXRaSC8wR04zYXMweVZRK0Ryb1FyeWNYNFdzY3psWjNGRklRUmk0?=
 =?utf-8?B?T2lJTlN5ZzJMQThEaWkwbDVWd1V2MkFsTWdaNmpYd2pwNjBBV3loMlpKdU8z?=
 =?utf-8?B?WGNFTmdScFJWUkZpbWVDa2JWUzAyYVVIWUQ0aWluZGtBTUNLc1RjSEorTWIy?=
 =?utf-8?B?bWJ6d29ScDRURFM2U1BzRTFXemtDQzRFeDlJTVFPSURTTThrY2NNUzFEbzRK?=
 =?utf-8?B?YTN6NHZXQldDRHkwZ1JpMTR3cVdhVStGbE43SmIvais4ZmF0YnhaRnlZeGUv?=
 =?utf-8?B?c2tvVURSOWI2Tk5iL01jSGhrMk12NDlvUjd5cExUTXRZdFMrZGRqSFEvcVdO?=
 =?utf-8?B?aHVIVDErNElKU1crNXZacUlCbHBCV2Q0STNKWVJsNiswMTJrU0E4OXNLcnBN?=
 =?utf-8?Q?Pjw1Fn8a4X8jsKIfqUSIGjQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c9e0ef3-a78c-48ad-01dd-08d9b4b9bd64
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:00:09.1451
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DxV/bwJlr0IbkhUA9TQPjPA1quzKZ4+UfPqg8X3eEbdyhXl+1YFW0NzRUKN3WXDG+OugtI7GQ+d8tfRVXxVjOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

1: mm: don't open-code p2m_is_pod()
2: PoD: move increment of entry count

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:01:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:01:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235878.409140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNMg-00052O-Hf; Wed, 01 Dec 2021 11:01:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235878.409140; Wed, 01 Dec 2021 11:01:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNMg-00052H-EM; Wed, 01 Dec 2021 11:01:30 +0000
Received: by outflank-mailman (input) for mailman id 235878;
 Wed, 01 Dec 2021 11:01:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNMf-000520-FP
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:01:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 087a4eff-5296-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:01:28 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-jjKr47zZMxaB6a3ZKhyu7w-1; Wed, 01 Dec 2021 12:01:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:01:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:01:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0161.eurprd06.prod.outlook.com (2603:10a6:20b:45c::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 11:01:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 087a4eff-5296-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356488;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3SD4EFe90Lggs8cQz5yURwjH248lNbQoaGblSbtee8k=;
	b=b/xpd3n0DIpsq7kdTe9xgrVlb5sDA8DKIbdrN/BD4g2J4tXf9He/HyHqsKbu91EmU+ZnqO
	hYNhPBy40P2OoLALsNL1PeW0k+CGUW5kLepSDM/DEU1u/8u6ScqPFN0O9MWAP5sPICSbZ9
	Lta2f85g68rCmKXv59uv+Yme+sjURFw=
X-MC-Unique: jjKr47zZMxaB6a3ZKhyu7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=efPgwyBHy4QT1c/YMgeoASqJwVCwm2KWUILRJIma8NK2H4k+BoJWD5sKr1U5Y7sXvc7AQkKy0gjLL97C+Y6/bJWdEJpBzapg8ABNLRZQHdsRAGJew0YYBUyoeBVO4aGM3bZIZISkgN91IsbGKROy7B3MKyzlzpaK9bF6DjSLZBNb4YP2w3oGMSo3/XXn6apzMbnMOwWb5bJ4xxrLVPPK7BkgZYPm/pGqXltSOlc5JCqCTNXI4QLlzZ3n2BtCE/C+zJGcOjIwNpYaAjYalTIh+gFcXIvjeHhfP8/jYnx4buBv+pniUHsSFoD/QvW5B0eu+ObiUpiBu7N/YzUa1VBUpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3SD4EFe90Lggs8cQz5yURwjH248lNbQoaGblSbtee8k=;
 b=GJPGSH7l4a/D06JboL3XncY49JYhjUhC0g6xiVI89rIcKS2dhCsno4D2bfq2kfvNsBTJGTwUN+Ji8RuFMcZ1rFmRo9LOou2BRG5ELwmw8TsIQ4UF5btuYZlRdBn/chiYZ5qr1UJJMK9dTOYSFz/2erl0A06zXpfsyEum8RMtYSbUZB+Pjy1PkkmXnwrx5vT/9m0ZX+VXBRJIJFWoK4VwxZDTlGrCcvVbx8x5hvhayQ7PCxZOCxjgj2JjDNnI8aXS620HyuwS7czMci02p0qpx1xntLz0s7rN2QYO5KFTHUgeO/zITks8I6XPGNSsPi9SeTqIRQkXoCSqJmwo62WHWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a1110809-b4fb-c53e-5f46-dc7628165634@suse.com>
Date: Wed, 1 Dec 2021 12:01:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/2] x86/mm: don't open-code p2m_is_pod()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Kevin Tian <kevin.tian@intel.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
In-Reply-To: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0161.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63740cbd-078e-4d64-8644-08d9b4b9eb2c
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57438F3356DBA7AF891FCCD0B3689@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:626;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sctOP0GClj1bhtYr4E4vKPV5WjgylqRk46Kf8+tQfcW4EI13mtiyuXCC7HtmgZ0jdMg5oVubJKK4+z01Sho7IeIAoMDh6AOkVZy0KzbFvdEnLBZnRuTbJCRIyIbTgFZI85PAyQzhT7lEEeIt3dqWJfDLvpHQF9itRblsJnjH3WPwqsMiJGZct071I2dLmk2s0Esl+XRMHT9elQTh1A3LSfh9L9EXyfW6WckDfVIN/I9SAEI7ugjQ515iXulLc5uLCuR8ynbZ+Gw8ofra99tlegH2gkOFEaNvBMz1nsMk+TsGiwQwcbw4McHd4pwFhTFe7HCU+Bo4iv0JGksg6xu/MbUEXxX9dDneE5AZaWIE0NFMcKqbik1XHhbq0NxwNgGAk+J7TXgYrspBeThPkIpilolG7dhGG/euOLHlz89Xz/ajKkgnP7zG8/qxGp2npyZ9sQaYx4gD/Y1JmEYLszcqEqxlOzOGkJjhRyFOputcdNz7IgJBNfgjxgNj5WgJ1yzx/QVb1wYyhjjN6wqCzFfOTtpApTrB5KAoltCrZ4ZmH62j55ieCCBdorIbjhJ/UMT2BOECaDi6hkg0zzasb9m2dr96+eymn9a7W0cHugK9wlQqC7nj2Pzv1t56XlGsm72c5uKto982rqFv6AlDBeyJJWHECBcROCKWcwaUEKe2VTPuwDZ+e6gUI1Rr1nYhm2EfVyXBRs7J9bMTs3I/gD8PBvZV1MwvBlTDi3MvHKag5ikFdmv+fVz5ifISXLo2oFLJ6AR+q51/XXZaBbUjrEy+/j+11s5NXOeAa6SuPDhjqCU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(8936002)(16576012)(316002)(36756003)(6916009)(31686004)(66476007)(66946007)(83380400001)(38100700002)(31696002)(5660300002)(2616005)(956004)(54906003)(6486002)(186003)(86362001)(26005)(508600001)(4326008)(8676002)(66556008)(45980500001)(43740500002)(473944003)(414714003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ams2eURQejQ3Rk54bWxoNitOdjNCOHdCOE9xNExicXhRL3NKdTlBblA5d2xK?=
 =?utf-8?B?UDVvTENPeklYemgyUWNpdUdNVHhuMHJsYnR1REtpdE1SdEJqaXBFTWh1RXJP?=
 =?utf-8?B?WEozQzVCMFAwemxjOWZmRVArWVgycUZyNnEzZ0RYbXVpM0VJc1B5RjZrY0FS?=
 =?utf-8?B?cWxUVU5YQnI5NkVEOS9USjlhMVR4Uzl1WjhBUnlHdUk3eDcvNE82US9hQkpO?=
 =?utf-8?B?ZlYva1JXWmhhZEJLRzNTNUoyekRTWVRpemlRYzA1YnQrTEFFNmhyVVFMS1B0?=
 =?utf-8?B?WDgzV25LYTlWeFd0Q1ordXVaSldFSGo0aDl3aUlveW5uK2VGWlluWmFKeERQ?=
 =?utf-8?B?TWx2V3h6N2FJUDU1Q0x4U1YybjJ5QXk2NGZNT3VuUTBzVU8xSnd0NmRCZ2xq?=
 =?utf-8?B?dmorSHBwSGdSRURUNWxqaW55bW5hQllleUt6S3FzTmxUMTNYQmIvdFU4TFhi?=
 =?utf-8?B?UXFXS01URmx4LzNZQU56dFRaLzNqdkowV0pjdkVMQmVGRVZuVnlOOXQxek1i?=
 =?utf-8?B?bHBGM2VYalV4SlBscElMYlZaU3UycWtjSGJscUJtZVo2OTRlUTFpQW1QSjZl?=
 =?utf-8?B?STNRYVlZUWcyeUk3WWFtY1BUcGxRN2FRaDQ1TktUSDc3SmtlNVUvckRwbzF6?=
 =?utf-8?B?ckpMNVU2TVBtRm0rSGliU2tqVHN6U1cwM2JrYUlRekI5VmFma1NLUzNnVUZ5?=
 =?utf-8?B?RlJYQlJlSUw0UnZwM1ZzemtONmhMYUJnb2FSOVZiSzNVNGQ5cGR3U3FiaXpU?=
 =?utf-8?B?dmh2bnVMZWNsNmR2UzlNZGI1Mkt0cStrbWt5NDk2aEJ5a29MTG9nMzhDb3JK?=
 =?utf-8?B?c0lQUExBM1pTRE9pdUxhdTlFY3lKaU5kZkZKSUt5dVlwZWdyKzlHRFYzL2pl?=
 =?utf-8?B?NnVvUS9KV1V5WFpGVWpScVp1eHZxY05CTjRNTVcyRDg1cnUvcDgzRWg0OWNS?=
 =?utf-8?B?ZFMzeDkyRUNKRlgrL3FSSE1XS3Rid1ZtbzRodW9BM2lLTkNvUlRHZnBZcnoy?=
 =?utf-8?B?N01NVVQxNDVmeitoeTdleDlGbU83eXVuZUtkeEpEeFRJVjJzOVRLQS9FcCtG?=
 =?utf-8?B?QjFRb1VmdWlCYjZJUVBrUUhDNmVPdmZQU0lybmI2RjU5dVpSZm9icHFib0Z5?=
 =?utf-8?B?RlVVenlta3RlREM0dzUwRnhRNE9vR0gyUnEvcFFDdWNabXBaSFYxWmdqUUd3?=
 =?utf-8?B?eVZDNmxzQ2xuYmhIdVpFV2lScUNaUklkKzdqMUFZRGlOc2JBY2dvc3Q2WmFX?=
 =?utf-8?B?MXREOENzSWJSdHRqMUxWMkxlLzA2S3ljbHVEdGRsd1RBNmRUV3ZsVkVGV0Ry?=
 =?utf-8?B?c2RXVnRBS2FJOE9QdGpTcDh4L1d5U21uMTdnaWtnM3RuRXBLeG9BU3ZmNURX?=
 =?utf-8?B?UHNNNDNRcVM2UkFoK1lUYzZnclhuaVZualBZaW5WQ2pOTnZUUEdJNUpCRUNj?=
 =?utf-8?B?bkRvQVNPVmNUN2ZLZFBaaWpzeU85ckVDMTJkdWdydUdwc0krYUd1eUVaNkFn?=
 =?utf-8?B?SkE1M1UvM2FTTmhWeUc3dXNQQkJYSGd1QVVoaGVSNnUyRmhZdGVpMzE5TmRY?=
 =?utf-8?B?WFRhakU1RDRCM0pkbFVwZjByaEdSdXluNEpMRzBYZHduLzNERGZqSTYvdjND?=
 =?utf-8?B?T09MK1RRNFNYVUNXcXBxRXFRekFmU1BlUWZyZ3pPU1RTZTVteDNhSWdpVGhN?=
 =?utf-8?B?RWVMSHREdElFaUl6ZjE1RWxQVnU4ZFFBNG1YVFZ4ZVZwNU1JNVFQTld6ME5F?=
 =?utf-8?B?MEp3M3dmSlpNYXZMVThqUktPTzJmTStTTjlFTmJXcXZFUUpYUy8wemROanlQ?=
 =?utf-8?B?SXlJR295WCswTjUraUFKTm9scUVLSFpmbThmdmNGQU1jNEVtaWppbVFjYmJj?=
 =?utf-8?B?YkY0NU8veldHTTVjVFhFVUgyckpRRHhCeU1WaWhPbXRoUTJFSW1YdW1VN2wx?=
 =?utf-8?B?WWdlSHBBamUrVmc5MUZ3d0FpbWQ1bW1KTld3UlF3UWZZaHhiaThZVUNmcjFY?=
 =?utf-8?B?RHpGTVhVMkxZT0Jwbkszbm9sT1dmMmkxQytGVmNLNlgyYjJoSCtBcEdZYzdk?=
 =?utf-8?B?NzEreE9WWHd5Qkk4bG81YUNkc24vek5VcktZNjY3ZE9WdGtGOFhpdW1wN0Ux?=
 =?utf-8?B?SkI4S2FwYmlXSE94MnIzK3JYMk5aRVRWaUVsbFpIZEFadVVxMnpHRzlEODZZ?=
 =?utf-8?Q?NL07SubK8sCtFFmBDBuqWaw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63740cbd-078e-4d64-8644-08d9b4b9eb2c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:01:25.8308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vDnjOLDiHA/MRvDC2mvPHe1EiUmSVQ1Si7tqVLl68a9ce7wBDeaRn07C5OmPJ+W9k69h6g8ny33TevS99wQGTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

Replace all comparisons against p2m_populate_on_demand (outside of
switch() statements) with the designated predicate.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -344,7 +344,7 @@ static int ept_next_level(struct p2m_dom
     {
         int rc;
 
-        if ( e.sa_p2mt == p2m_populate_on_demand )
+        if ( p2m_is_pod(e.sa_p2mt) )
             return GUEST_TABLE_POD_PAGE;
 
         if ( read_only )
@@ -1071,7 +1071,7 @@ static mfn_t ept_get_entry(struct p2m_do
     index = gfn_remainder >> (i * EPT_TABLE_ORDER);
     ept_entry = table + index;
 
-    if ( ept_entry->sa_p2mt == p2m_populate_on_demand )
+    if ( p2m_is_pod(ept_entry->sa_p2mt) )
     {
         if ( !(q & P2M_ALLOC) )
         {
@@ -1478,7 +1478,7 @@ static void ept_dump_p2m_table(unsigned
             ept_entry = table + (gfn_remainder >> order);
             if ( ret != GUEST_TABLE_MAP_FAILED && is_epte_valid(ept_entry) )
             {
-                if ( ept_entry->sa_p2mt == p2m_populate_on_demand )
+                if ( p2m_is_pod(ept_entry->sa_p2mt) )
                     printk("gfn: %13lx order: %2d PoD\n", gfn, order);
                 else
                     printk("gfn: %13lx order: %2d mfn: %13lx %c%c%c %c%c%c\n",
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -543,7 +543,7 @@ decrease_reservation(struct domain *d, g
 
         p2m->get_entry(p2m, gfn_add(gfn, i), &t, &a, 0, &cur_order, NULL);
         n = 1UL << min(order, cur_order);
-        if ( t == p2m_populate_on_demand )
+        if ( p2m_is_pod(t) )
             pod += n;
         else if ( p2m_is_ram(t) )
             ram += n;
@@ -618,7 +618,7 @@ decrease_reservation(struct domain *d, g
         if ( order < cur_order )
             cur_order = order;
         n = 1UL << cur_order;
-        if ( t == p2m_populate_on_demand )
+        if ( p2m_is_pod(t) )
         {
             /* This shouldn't be able to fail */
             if ( p2m_set_entry(p2m, gfn_add(gfn, i), INVALID_MFN, cur_order,
@@ -1332,7 +1332,7 @@ mark_populate_on_demand(struct domain *d
 
         p2m->get_entry(p2m, gfn_add(gfn, i), &ot, &a, 0, &cur_order, NULL);
         n = 1UL << min(order, cur_order);
-        if ( ot == p2m_populate_on_demand )
+        if ( p2m_is_pod(ot) )
         {
             /* Count how many PoD entries we'll be replacing if successful */
             pod_count += n;
--- a/xen/arch/x86/mm/p2m-pt.c
+++ b/xen/arch/x86/mm/p2m-pt.c
@@ -841,7 +841,7 @@ pod_retry_l3:
         flags = l3e_get_flags(*l3e);
         if ( !(flags & _PAGE_PRESENT) )
         {
-            if ( p2m_flags_to_type(flags) == p2m_populate_on_demand )
+            if ( p2m_is_pod(p2m_flags_to_type(flags)) )
             {
                 if ( q & P2M_ALLOC )
                 {
@@ -884,7 +884,7 @@ pod_retry_l2:
     if ( !(flags & _PAGE_PRESENT) )
     {
         /* PoD: Try to populate a 2-meg chunk */
-        if ( p2m_flags_to_type(flags) == p2m_populate_on_demand )
+        if ( p2m_is_pod(p2m_flags_to_type(flags)) )
         {
             if ( q & P2M_ALLOC ) {
                 if ( p2m_pod_demand_populate(p2m, gfn_, PAGE_ORDER_2M) )
@@ -923,7 +923,7 @@ pod_retry_l1:
     if ( !(flags & _PAGE_PRESENT) && !p2m_is_paging(l1t) )
     {
         /* PoD: Try to populate */
-        if ( l1t == p2m_populate_on_demand )
+        if ( p2m_is_pod(l1t) )
         {
             if ( q & P2M_ALLOC ) {
                 if ( p2m_pod_demand_populate(p2m, gfn_, PAGE_ORDER_4K) )
@@ -1094,8 +1094,7 @@ static long p2m_pt_audit_p2m(struct p2m_
                     if ( !(l2e_get_flags(l2e[i2]) & _PAGE_PRESENT) )
                     {
                         if ( (l2e_get_flags(l2e[i2]) & _PAGE_PSE)
-                             && ( p2m_flags_to_type(l2e_get_flags(l2e[i2]))
-                                  == p2m_populate_on_demand ) )
+                             && p2m_is_pod(p2m_flags_to_type(l2e_get_flags(l2e[i2]))) )
                             entry_count+=SUPERPAGE_PAGES;
                         gfn += 1 << (L2_PAGETABLE_SHIFT - PAGE_SHIFT);
                         continue;
@@ -1132,7 +1131,7 @@ static long p2m_pt_audit_p2m(struct p2m_
                         type = p2m_flags_to_type(l1e_get_flags(l1e[i1]));
                         if ( !(l1e_get_flags(l1e[i1]) & _PAGE_PRESENT) )
                         {
-                            if ( type == p2m_populate_on_demand )
+                            if ( p2m_is_pod(type) )
                                 entry_count++;
                             continue;
                         }
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -992,7 +992,7 @@ guest_physmap_add_entry(struct domain *d
             ASSERT(mfn_valid(omfn));
             set_gpfn_from_mfn(mfn_x(omfn), INVALID_M2P_ENTRY);
         }
-        else if ( ot == p2m_populate_on_demand )
+        else if ( p2m_is_pod(ot) )
         {
             /* Count how man PoD entries we'll be replacing if successful */
             pod_count++;
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -1476,7 +1476,7 @@ static int validate_gl4e(struct vcpu *v,
         mfn_t gl3mfn = get_gfn_query_unlocked(d, gfn_x(gl3gfn), &p2mt);
         if ( p2m_is_ram(p2mt) )
             sl3mfn = get_shadow_status(d, gl3mfn, SH_type_l3_shadow);
-        else if ( p2mt != p2m_populate_on_demand )
+        else if ( !p2m_is_pod(p2mt) )
             result |= SHADOW_SET_ERROR;
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC )
@@ -1535,7 +1535,7 @@ static int validate_gl3e(struct vcpu *v,
         mfn_t gl2mfn = get_gfn_query_unlocked(d, gfn_x(gl2gfn), &p2mt);
         if ( p2m_is_ram(p2mt) )
             sl2mfn = get_shadow_status(d, gl2mfn, SH_type_l2_shadow);
-        else if ( p2mt != p2m_populate_on_demand )
+        else if ( !p2m_is_pod(p2mt) )
             result |= SHADOW_SET_ERROR;
 
 #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC )
@@ -1586,7 +1586,7 @@ static int validate_gl2e(struct vcpu *v,
             mfn_t gl1mfn = get_gfn_query_unlocked(d, gfn_x(gl1gfn), &p2mt);
             if ( p2m_is_ram(p2mt) )
                 sl1mfn = get_shadow_status(d, gl1mfn, SH_type_l1_shadow);
-            else if ( p2mt != p2m_populate_on_demand )
+            else if ( !p2m_is_pod(p2mt) )
                 result |= SHADOW_SET_ERROR;
         }
     }



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:02:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:02:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235882.409151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNNI-0005aT-SS; Wed, 01 Dec 2021 11:02:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235882.409151; Wed, 01 Dec 2021 11:02:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNNI-0005aK-OI; Wed, 01 Dec 2021 11:02:08 +0000
Received: by outflank-mailman (input) for mailman id 235882;
 Wed, 01 Dec 2021 11:02:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNNG-000517-RJ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:02:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 92bfb4eb-5294-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 11:51:01 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-UvxS7umGOc2QSbh9K0jT4A-1; Wed, 01 Dec 2021 12:02:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:02:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:02:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0176.eurprd06.prod.outlook.com (2603:10a6:20b:45c::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Wed, 1 Dec 2021 11:02:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92bfb4eb-5294-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638356525;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ivkhnbVo3ZCtO6SLZl0Vo9tL62ytjpIHAIb5DwwD2SU=;
	b=lqKO+gWfBDOP+FH+WfU8TKHNpTSlSdNcGhYOxHwtRVaw5xcc9uZIWz7Y3SJ1FEkWn5ga0g
	AQf78LCkwQDUdRlldQNv/1v0k+RuakNYWDcd43DChZMU0rZLXUUxiBHEmlgJG/WOv99Gm5
	fjLbXihFf+dUU8kGCZd/G5kUBfC4dKM=
X-MC-Unique: UvxS7umGOc2QSbh9K0jT4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cpqTe3gdzd7o0uiY5ZdnN56bEskD5gwkMKpHARtNPmGMzx6QgPv8qCJzS4h5I8yEsc4R8S9wNuOZ9XnWYjuqkxl6mFEUKTDeEUyBOfIPBE1hQBKrKzj2Zx+Ape6Ha3XsqK3R8bByd//U23mPJK8FUoS7ZjXNeGQwbMRZZvZgWQds8oUwG2SBRh9LZnF5c0ofFe6PZ4Wtspva9tJdozN1zOu3caJHqKldby8Ts7PTxPpddEz0a1Gxst+H0xHQPBfg+RD8OtlXPtTDjrtwu3w0IxrPRHJN3XJk5MVlIwfG/Zs36H/lKP8rsHZ+e19KsHJd4i0YT4LUvKejhxdBELomjQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ivkhnbVo3ZCtO6SLZl0Vo9tL62ytjpIHAIb5DwwD2SU=;
 b=Zuyc23ovwhDkp2BkGyoRLyrwsVdX7ypqsBBcqcWXadTsmV7LVqnADQ/p9NmV4T1V0F8mWZ/V6f9RJopgyWfZ3gF7PcUR1+jnwDK2ogxzFbXXfFuS+eBhH08Jg3pQsrFQMIVDNUDPQUoqCXISeS+MjkIXYjIymujELKV3hePA9lu5Rrg56/E+ixU6CSqCc4UoXbjBQAa+0TWGzGcKgot4XrlUbuMdDGfVyYqRiOyhui052Poa7PD7+hduWJB46EehtC6cbEr4YKtG4DtQuUl2sAA54JiLtTxrztGPB6RF9SGUCTX/Ry5et/G3N+vrpLyJ/2T4DspmhpfCoj8tfgTDfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d92ec1b7-6cde-7efc-2c6a-3dc3696b957f@suse.com>
Date: Wed, 1 Dec 2021 12:02:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/2] x86/PoD: move increment of entry count
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
In-Reply-To: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0176.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d86fb32f-bcdf-4551-b1b1-08d9b4ba0200
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57432FF503517F2FF6621940B3689@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yZFGFSP4dr64oFGenfI1p9dKJ6IrHd81hFtyNjLrR3+heI9NpNWqOPA2Moxg+X+hexOWoZ/M1UUpow+C6Ur52wxU0IIjkq4PCnoM6+TNn25fvH4d632o4c+qfxdVWSFowjHsqOXxQi8v0+EvYU4OmhI4OwQaJm2N6UeMrOr0TWMbsV979PMmIhRQvvqi6MI0y6x7cbYt1v5k+VkaAsw0Z6Q9rUmVtj6IR0KPoZrTaNq2Q5mrDDU9tssKhmk1JmUyFb60E2F9D8ygQCk39E0MYLxYvTSmrWZiCkpWeMRYM4D4xqFfCscg7sIXamdJ1sCyEtDo/gey3g2yquUKpx08808k1wMnYnABzoAuks8+SLfepnfdPKK9/xFDdUm+nii5CJSXRmhI5P+jKUNNSfBKTkLR4DYeC4JdJLoNzXGGmEH1GNltjy35O1MJADJJAAXUb8ezVz+ysHXaMHbRQVvu5KJudP2M1Kr4qFRtuTgudBy+qIcH8BmK7+7Iqt91LSnDYbvuOYpuO8cUX3n44Ezt15K/k4IQCugxtxCtDVv8TxSGn8mUMQoFSrMOtdWwQkC2dzJxXB86rxkzo1QWgN0fKkATC/MfsucwP5TqUYMSwx+xTSSVQKB1y0rimSYv1R0Pp8rH0AMSW0hzcKLWfIxOA/VoJsnunyikd/+ilLRg0yEIW/NLrk/DU4JvAXreNpChgmXmN/2Y4oKcAOp4J5lLgPRNLDPJuaS6Gj0xRDQFVRM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(8936002)(16576012)(316002)(36756003)(6916009)(31686004)(66476007)(66946007)(83380400001)(38100700002)(31696002)(5660300002)(2616005)(956004)(54906003)(6486002)(186003)(86362001)(26005)(508600001)(4326008)(8676002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGMxTmRCQTRtRExCcmNQbDVVand6YjJqaVpkM0MwZWpYT1JsSi90bXJxRURn?=
 =?utf-8?B?VkM0TVJiUHdDZ1BhVnlEWWhGendRZzNMeTMwbngrRHZ4K2E5SEgrUk9sTGFi?=
 =?utf-8?B?WXJ6RjBJZWM2bTVZenkxL0p6VXQ2SUJFSnlwTUUzUm5xdndwZktGeTFXYnBs?=
 =?utf-8?B?bW1XN3VuUUdTeEVISWJhbGVzMFJrVjRkN3F3ZG5XUm1QRXdVVFd2ZHZlNXcr?=
 =?utf-8?B?R3N4ci9tS01LNWh6N0R3VFRKNEdCbmE0YTFEcFNrZDNWQTEzd2NOMk0vemFa?=
 =?utf-8?B?ZEgvclQ1QTZNVXhxeGgyYVM1ZVlFaU1jdU5rRUhOUVpSbjdvOFVrL21yWWR6?=
 =?utf-8?B?K01CWUhRMUE1OWJMc2RKWmlZMVVQek5XaHpUYWdHWG9pOFhMK3U5UVF3bGJM?=
 =?utf-8?B?R1F0ajRnYklTTWFuL1JlOUJhL2sxeDBDVjk4dDZYSzFhZDJOeE9uNDhJRUIv?=
 =?utf-8?B?aEVUaklBWElpVUZRdHF3dGZnWG5uY0piYnRlTzJlbVJzYXVsSDV4bVZiOTJo?=
 =?utf-8?B?RzY2K3FacXFxUlhjNnhPblBkd0dwcUJVcUVsbWgwZVZlM2REcXF3dE9PbVJE?=
 =?utf-8?B?QlRwWkJncVZwc25EaEt1cE5OY1AwNTZ5d2drWVFCZTNvN0srSTdYMWhCUzZX?=
 =?utf-8?B?cUpGRkpPVGJzV0xaWC84Vm1LMkQ1Q0pQK2Q0WVg1YmlCTXN3MUx3S3hUR05N?=
 =?utf-8?B?NkJPNk44SnZhcENtdTR6QWtBVXVsTm0wcGc0VW1yWEUrWkRuTnJhNUZmeGh0?=
 =?utf-8?B?eWl5Y1lFSkhkTnMxcEZwdnVBVlJQVFJqd3NKRGNBRGJzbFEzT1dJam03QU52?=
 =?utf-8?B?SFJaNTJ5czZRUTNIMGFIZ3ovMGw1UVp0THUzekg4TkJKN3BWYmpoWW52VGda?=
 =?utf-8?B?eDNJaUpBSCtCNFhFR1ZuZ2lMZVg4NjQxUjhBeTJVYmE3YXlVckRKZmFCaFky?=
 =?utf-8?B?ZmpYcGkvMnBiT0RZYzhId3p3YzM2RGxNV1pmR1l4YjJmbG44VlpDSUhXV0hT?=
 =?utf-8?B?cmltVE9KeWFHY284aUZzZmFMS2tscjJVQTdMbTM1emtyYnRxTXhlLzFLbHU3?=
 =?utf-8?B?clpNR05nTWp3RHFsNk9PNWwxd3R0b2lBOXl2L05NQ3BNZXhMcVlQbUpBZVIv?=
 =?utf-8?B?bHcrOXFrRGl2cXAxRklqcnhNWGpWSjF1cmdzNXMwVWtNdmhKVWhPSU5vaFRr?=
 =?utf-8?B?ZWx2N1l1SmFBTzNWYU9WYlRJME9CWHBZUjVKQ2J5ZjVUOXVsNUFoRW5YR1Nm?=
 =?utf-8?B?ejRHTUM0c0FvRW12MytEbXpUakdwNytRb1pLOGpwMUdoZm1sMWhpNmM4WUJa?=
 =?utf-8?B?U1pxUnFCU0tzSzBJTXVBVmN2ZjMvdHY5RmtVSStGL3lCTWFnN094NThDTk9B?=
 =?utf-8?B?anNreThhZlBHTWpKSWN5blRXU2dVb3JJUmdLTFErMUIwaTZVZmlxQ1RDM0Nn?=
 =?utf-8?B?ZklpUDZJUnRMajQ2WkVZUGM2eDIyRGtPZk1FQ0NGdEN4WjFYOEhrZm04OC9z?=
 =?utf-8?B?UlcwNkRtRTRHZXBaOS93UkpDR05VTmUrckpkbzZZY3I2VWxnMHp3L3pudHpk?=
 =?utf-8?B?ejFYNUNvTVdQcFBleDMxRUFnS2w1NUk4WDNCUWN0UXhEcCtSU3JMeE5mL3k3?=
 =?utf-8?B?akNYaHptVHBELzc4anJJTDZmbVhhbU1BZEhFOVUrMVgySHRyV3lveWJxdFVn?=
 =?utf-8?B?ZklXeFBjRHFWRlk0V2hxWUdpeWVkR09XRFZQMzRjWlNlLzJCYitGaFVkM0dO?=
 =?utf-8?B?Qmo3T21hRkNQRWh1U1p1VE8wUWIrOW1LOHN3TVZkV3BwV1NsTVRiTzd3c1NU?=
 =?utf-8?B?WElmQ2hwelpoWVRsaTZyN2pSTVNVbDhzREpuclFkM0JOdW93T3ZEOU9wMVc3?=
 =?utf-8?B?RWIzbVBTMEwrSmNKTFMzZGNhYTlzZzdJWHJYT1Z4UjRLeFdQVWZ1M29qZVV5?=
 =?utf-8?B?SkRZcU13TW50V1Vva2dTOVBJc1p3MWdublFHaDdDSVRFNlVMSWpkTmkyRFYr?=
 =?utf-8?B?ZmdXdkNHcHM2Y256Zmx4Z0ZqcG01U3ptYWxkTGovWnJIblhNcnAyU0FqZVNq?=
 =?utf-8?B?clcwQXpjdElqZk5wZmRtMUJUKzJEN21xMjB5c3ZFVmtPVUgwZlo3RXNmdlZi?=
 =?utf-8?B?VGJaZDBCRlhoMHlkWTFsdlN4VGZYWDFtMUdqLzIzTENlRFdybFhPaWI4azh0?=
 =?utf-8?Q?jRE3K2/QY6Ep1UcufiJbDho=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d86fb32f-bcdf-4551-b1b1-08d9b4ba0200
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:02:04.1151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uGPST0ygLERJYiuaYAd9+uo4laZ0hLvPExHaGbF+DGp29d5mt9lHVdqbT+BOccHcRo6DMx3358yDrvrW0Ce5AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

When not holding the PoD lock across the entire region covering P2M
update and stats update, the entry count should indicate too large a
value in preference to a too small one, to avoid functions bailing early
when they find the count is zero. Hence increments should happen ahead
of P2M updates, while decrements should happen only after. Deal with the
one place where this hasn't been the case yet.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
         }
     }
 
+    pod_lock(p2m);
+    p2m->pod.entry_count += (1UL << order) - pod_count;
+    pod_unlock(p2m);
+
     /* Now, actually do the two-way mapping */
     rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
                        p2m_populate_on_demand, p2m->default_access);
     if ( rc == 0 )
-    {
-        pod_lock(p2m);
-        p2m->pod.entry_count += 1UL << order;
-        p2m->pod.entry_count -= pod_count;
-        BUG_ON(p2m->pod.entry_count < 0);
-        pod_unlock(p2m);
-
         ioreq_request_mapcache_invalidate(d);
-    }
     else if ( order )
     {
         /*
@@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
                d, gfn_l, order, rc);
         domain_crash(d);
     }
+    else if ( !pod_count )
+    {
+        pod_lock(p2m);
+        BUG_ON(!p2m->pod.entry_count);
+        --p2m->pod.entry_count;
+        pod_unlock(p2m);
+    }
 
 out:
     gfn_unlock(p2m, gfn, order);
When not holding the PoD lock across the entire region covering P2M
update and stats update, the entry count should indicate too large a
value in preference to a too small one, to avoid functions bailing early
when they find the count is zero. Hence increments should happen ahead
of P2M updates, while decrements should happen only after. Deal with the
one place where this hasn't been the case yet.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
         }
     }
 
+    pod_lock(p2m);
+    p2m->pod.entry_count += (1UL << order) - pod_count;
+    pod_unlock(p2m);
+
     /* Now, actually do the two-way mapping */
     rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
                        p2m_populate_on_demand, p2m->default_access);
     if ( rc == 0 )
-    {
-        pod_lock(p2m);
-        p2m->pod.entry_count += 1UL << order;
-        p2m->pod.entry_count -= pod_count;
-        BUG_ON(p2m->pod.entry_count < 0);
-        pod_unlock(p2m);
-
         ioreq_request_mapcache_invalidate(d);
-    }
     else if ( order )
     {
         /*
@@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
                d, gfn_l, order, rc);
         domain_crash(d);
     }
+    else if ( !pod_count )
+    {
+        pod_lock(p2m);
+        BUG_ON(!p2m->pod.entry_count);
+        --p2m->pod.entry_count;
+        pod_unlock(p2m);
+    }
 
 out:
     gfn_unlock(p2m, gfn, order);



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:12:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:12:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235891.409162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNWo-0007Et-P1; Wed, 01 Dec 2021 11:11:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235891.409162; Wed, 01 Dec 2021 11:11:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNWo-0007Em-Lu; Wed, 01 Dec 2021 11:11:58 +0000
Received: by outflank-mailman (input) for mailman id 235891;
 Wed, 01 Dec 2021 11:11:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ns=QS=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1msNWo-0007Eg-7R
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:11:58 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id f1d1849c-5295-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:00:50 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 811B011B3;
 Wed,  1 Dec 2021 03:11:54 -0800 (PST)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 653543F694;
 Wed,  1 Dec 2021 03:11:53 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1d1849c-5295-11ec-b945-1df2895da90e
Date: Wed, 1 Dec 2021 11:11:49 +0000
From: Andre Przywara <andre.przywara@arm.com>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>, "stefanos@xilinx.com"
 <stefanos@xilinx.com>, "julien@xen.org" <julien@xen.org>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Message-ID: <20211201111149.08c0ae90@donnerap.cambridge.arm.com>
In-Reply-To: <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
	<20211130094950.1bf368d6@donnerap.cambridge.arm.com>
	<a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
	<D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
Organization: ARM
X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 1 Dec 2021 08:41:13 +0000
Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:

Hi,

> > On 30 Nov 2021, at 19:13, Ayan Kumar Halder <ayan.kumar.halder@xilinx.c=
om> wrote:
> >
> > Hi Andre,
> >
> > Thanks for your comments. They are useful.
> >
> > On 30/11/2021 09:49, Andre Przywara wrote: =20
> >> On Mon, 29 Nov 2021 19:16:38 +0000
> >> Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> >> Hi, =20
> >>> At the moment, Xen is only handling data abort with valid syndrome (i=
.e.
> >>> ISV=3D0). Unfortunately, this doesn't cover all the instructions a do=
main
> >>> could use to access MMIO regions.
> >>>
> >>> For instance, Xilinx baremetal OS will use:
> >>>
> >>>         volatile u32 *LocalAddr =3D (volatile u32 *)Addr;
> >>>         *LocalAddr =3D Value;
> >>>
> >>> This leave the compiler to decide which store instructions to use. =20
> >> As mentioned in the other email, this is wrong, if this points to MMIO:
> >> don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
> >> an MMIO area, you should not see traps that you cannot handle already.
> >> So I don't think it's a good idea to use that as an example. And since
> >> this patch only seems to address this use case, I would doubt its
> >> usefulness in general. =20
> > Yes, I should have fixed the comment.
> >
> > Currently, I am testing with baremetal app which uses inline assembly c=
ode with post indexing instructions, to access the MMIO.
> >
> > ATM, I am testing with 32 bit MMIO only.
> >
> > On the usefulness, I am kind of torn as it is legitimate for post index=
ing instructions to be used in an inline-assembly code for accessing MMIO. =
However, that may not be something commonly seen.
> >
> > @Stefano/Bertrand/Julien/Volodymyr :- As you are the Arm mantainers, ca=
n you comment if we should have decoding logic or not ? =20
>=20
> Andre gave you the official statement from Arm and there is nothing more =
I can say.
> I will leave this decision to Stefano and Julien.

Well, I gave some statement about what the architecture says, and about
the problems for letting a compiler generate MMIO accesses.
That doesn't prevent anyone from emulating those instructions, but I
wonder if this is doing more harm than good (little tested code in
a sensitive code path of the HV), given the use cases. If this is
only to cover the (illegitimate) use case at hand, it's certainly not
worth it, IMHO.

Thanks,
Andre

>=20
> Regards
> Bertrand
>=20
> > =20
> >>> This
> >>> may be a post-index store instruction where the HW will not provide a
> >>> valid syndrome.
> >>>
> >>> In order to handle post-indexing store/load instructions, Xen will ne=
ed
> >>> to fetch and decode the instruction.
> >>>
> >>> This patch only cover post-index store/load instructions from AArch64
> >>> mode. For now, this is left unimplemented for trap from AArch32 mode.
> >>>
> >>> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> >>> ---
> >>>
> >>> Changelog :-
> >>>
> >>> v2 :- 1. Updated the rn register after reading from it. (Pointed by
> >>> Julien, Stefano)
> >>> 2. Used a union to represent the instruction opcode (Suggestd by
> >>> Bertrand) 3. Fixed coding style issues (Pointed by Julien)
> >>> 4. In the previous patch, I was updating dabt->sign based on the
> >>> signedness of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI
> >>> 0487G.b, Page 3221, SSE indicates the signedness of the data item
> >>> loaded. In our case, the data item loaded is always unsigned.
> >>>
> >>> This has been tested for the following cases :-
> >>> ldr x2, [x1], #4 =20
> >> As Jan already mentioned: this is a bad example. First, this is a 64-b=
it
> >> access, which you don't emulate below. And second, you want to keep the
> >> pointer aligned. Unaligned accesses to device memory always trap, as p=
er
> >> the architecture, even on bare metal. =20
> >>>
> >>> ldr w2, [x1], #-4
> >>>
> >>> str x2, [x1], #4 =20
> >> Same as above. =20
> >>> str w2, [x1], #-4
> >>>
> >>> The reason being  I am testing on 32bit MMIO registers only. I don't =
see
> >>> a 8bit or 16bit MMIO register. =20
> >> Where did you look? There are plenty of examples out there, even the G=
IC
> >> allows 8-bit accesses to certain registers (grep for "VGIC_ACCESS_"), =
and
> >> the Linux GIC driver is using them (but with proper accessors, of cour=
se).
> >> Also GICv3 supports 64-bit accesses to some registers. Some PL011 UART=
s use
> >> 16-bit MMIO accesses. =20
> > Yes, sorry I see them now. GICD_IPRIORITYR can be accessed with 8 bits.
> > Unfortunately, I have GIC-v2 on my hardware system. So, probably I can'=
t test 64 bit access.
> > =20
> >>>  xen/arch/arm/decode.c     | 68 +++++++++++++++++++++++++++++++++++++=
+-
> >>>  xen/arch/arm/decode.h     |  3 +-
> >>>  xen/arch/arm/io.c         | 40 +++++++++++++++++++----
> >>>  xen/include/asm-arm/hsr.h | 26 +++++++++++++++
> >>>  4 files changed, 129 insertions(+), 8 deletions(-)
> >>>
> >>> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> >>> index 792c2e92a7..0b3e8fcbc6 100644
> >>> --- a/xen/arch/arm/decode.c
> >>> +++ b/xen/arch/arm/decode.c
> >>> @@ -84,6 +84,66 @@ bad_thumb2:
> >>>      return 1;
> >>>  }
> >>>  +static int decode_32bit_loadstore_postindexing(register_t pc,
> >>> +                                               struct hsr_dabt *dabt,
> >>> +                                               union ldr_str_instr_c=
lass *instr)
> >>> +{
> >>> +    if ( raw_copy_from_guest(&instr->value, (void * __user)pc, sizeo=
f (instr)) )
> >>> +        return -EFAULT;
> >>> +
> >>> +    /* First, let's check for the fixed values */
> >>> +    if ( !((instr->code.fixed1 =3D=3D 1) && (instr->code.fixed2 =3D=
=3D 0) &&
> >>> +         (instr->code.fixed3 =3D=3D 0) && (instr->code.fixed4 =3D=3D=
 7)) )
> >>> +    {
> >>> +        gprintk(XENLOG_ERR, "Decoding not supported for instructions=
 other than"
> >>> +            " ldr/str post indexing\n");
> >>> +        goto bad_32bit_loadstore;
> >>> +    }
> >>> +
> >>> +    if ( instr->code.size !=3D 2 ) =20
> >> I don't see a good reason for this limitation. If you are going to dis=
sect
> >> the instruction, why not just support at least all access widths, so
> >> 64-bits, but also {ldr,str}{b,w}? I think the framework does the heavy
> >> lifting for you already? =20
> >
> > I see your point. My intention was to test first with the restricted in=
struction set (ie ldr/str - 32 bit access with post indexing only) and get =
an opinion from the community. If the patch looks sane, then this can be ex=
tended with other variants as well.
> > =20
> >> Same for the restriction to post-index above, supporting pre-index as =
well
> >> should be easy. =20
> > For Pre-indexing instruction, the ISS is valid. So I am not sure what i=
s to be done here?
> >
> > AFAIU, if the ISS is valid, there is no need to explicitly decode the i=
nstructions. =20
> >> To me this has the bitter taste for being a one trick pony to work aro=
und
> >> your particular (broken!) use case. =20
> >>> +    {
> >>> +        gprintk(XENLOG_ERR,
> >>> +            "ldr/str post indexing is supported for 32 bit variant o=
nly\n");
> >>> +        goto bad_32bit_loadstore;
> >>> +    }
> >>> +
> >>> +    if ( instr->code.v !=3D 0 )
> >>> +    {
> >>> +        gprintk(XENLOG_ERR,
> >>> +            "ldr/str post indexing for vector types are not supporte=
d\n");
> >>> +        goto bad_32bit_loadstore;
> >>> +    }
> >>> +
> >>> +    /* Check for STR (immediate) - 32 bit variant */
> >>> +    if ( instr->code.opc =3D=3D 0 )
> >>> +    {
> >>> +        dabt->write =3D 1;
> >>> +    }
> >>> +    /* Check for LDR (immediate) - 32 bit variant */
> >>> +    else if ( instr->code.opc =3D=3D 1 )
> >>> +    {
> >>> +        dabt->write =3D 0;
> >>> +    }
> >>> +    else
> >>> +    {
> >>> +        gprintk(XENLOG_ERR,
> >>> +            "Decoding ldr/str post indexing is not supported for thi=
s variant\n");
> >>> +        goto bad_32bit_loadstore;
> >>> +    }
> >>> +
> >>> +    gprintk(XENLOG_INFO,
> >>> +        "instr->code.rt =3D 0x%x, instr->code.size =3D 0x%x, instr->=
code.imm9 =3D %d\n",
> >>> +        instr->code.rt, instr->code.size, instr->code.imm9);
> >>> +
> >>> +    update_dabt(dabt, instr->code.rt, instr->code.size, false);
> >>> +    dabt->valid =3D 1;
> >>> +
> >>> +    return 0;
> >>> +bad_32bit_loadstore:
> >>> +    gprintk(XENLOG_ERR, "unhandled 32bit Arm instruction 0x%x\n", in=
str->value);
> >>> +    return 1;
> >>> +}
> >>> +
> >>>  static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
> >>>  {
> >>>      uint16_t instr;
> >>> @@ -150,11 +210,17 @@ bad_thumb:
> >>>      return 1;
> >>>  }
> >>>  -int decode_instruction(const struct cpu_user_regs *regs, struct hsr=
_dabt *dabt)
> >>> +int decode_instruction(const struct cpu_user_regs *regs, struct hsr_=
dabt *dabt,
> >>> +                       union ldr_str_instr_class *instr)
> >>>  {
> >>>      if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
> >>>          return decode_thumb(regs->pc, dabt);
> >>>  +    if ( (is_64bit_domain(current->domain) && !psr_mode_is_32bit(re=
gs)) )
> >>> +    {
> >>> +        return decode_32bit_loadstore_postindexing(regs->pc, dabt, i=
nstr);
> >>> +    }
> >>> +
> >>>      /* TODO: Handle ARM instruction */
> >>>      gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
> >>>  diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> >>> index 4613763bdb..d82fc4a0f6 100644
> >>> --- a/xen/arch/arm/decode.h
> >>> +++ b/xen/arch/arm/decode.h
> >>> @@ -35,7 +35,8 @@
> >>>   */
> >>>    int decode_instruction(const struct cpu_user_regs *regs,
> >>> -                       struct hsr_dabt *dabt);
> >>> +                       struct hsr_dabt *dabt,
> >>> +                       union ldr_str_instr_class *instr);
> >>>    #endif /* __ARCH_ARM_DECODE_H_ */
> >>>  diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> >>> index 729287e37c..0d60754bc4 100644
> >>> --- a/xen/arch/arm/io.c
> >>> +++ b/xen/arch/arm/io.c
> >>> @@ -65,6 +65,16 @@ static enum io_state handle_write(const struct
> >>> mmio_handler *handler, return ret ? IO_HANDLED : IO_ABORT;
> >>>  }
> >>>  +static void post_incremenet_register(union ldr_str_instr_class *ins=
tr)
> >>> +{
> >>> +    struct cpu_user_regs *regs =3D guest_cpu_user_regs();
> >>> +    unsigned int val;
> >>> +
> >>> +    val =3D get_user_reg(regs, instr->code.rn);
> >>> +    val +=3D instr->code.imm9;
> >>> +    set_user_reg(regs, instr->code.rn, val);
> >>> +}
> >>> +
> >>>  /* This function assumes that mmio regions are not overlapped */
> >>>  static int cmp_mmio_handler(const void *key, const void *elem)
> >>>  {
> >>> @@ -106,14 +116,26 @@ enum io_state try_handle_mmio(struct cpu_user_r=
egs
> >>> *regs, .gpa =3D gpa,
> >>>          .dabt =3D dabt
> >>>      };
> >>> +    int rc;
> >>> +    union ldr_str_instr_class instr =3D {0};
> >>>        ASSERT(hsr.ec =3D=3D HSR_EC_DATA_ABORT_LOWER_EL);
> >>>  +    /*
> >>> +     * Armv8 processor does not provide a valid syndrome for post-in=
dexing
> >>> +     * ldr/str instructions. So in order to process these instructio=
ns,
> >>> +     * Xen must decode them.
> >>> +     */
> >>> +    if ( !info.dabt.valid )
> >>> +    {
> >>> +        rc =3D decode_instruction(regs, &info.dabt, &instr);
> >>> +        if ( rc )
> >>> +            return IO_ABORT;
> >>> +    }
> >>> +
> >>>      handler =3D find_mmio_handler(v->domain, info.gpa);
> >>>      if ( !handler )
> >>>      {
> >>> -        int rc;
> >>> -
> >>>          rc =3D try_fwd_ioserv(regs, v, &info);
> >>>          if ( rc =3D=3D IO_HANDLED )
> >>>              return handle_ioserv(regs, v);
> >>> @@ -122,7 +144,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs
> >>> *regs, }
> >>>        /* All the instructions used on emulated MMIO region should be
> >>> valid */
> >>> -    if ( !dabt.valid )
> >>> +    if ( !info.dabt.valid )
> >>>          return IO_ABORT;
> >>>        /*
> >>> @@ -134,7 +156,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs
> >>> *regs, {
> >>>          int rc;
> >>>  -        rc =3D decode_instruction(regs, &info.dabt);
> >>> +        rc =3D decode_instruction(regs, &info.dabt, NULL);
> >>>          if ( rc )
> >>>          {
> >>>              gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> >>> @@ -143,9 +165,15 @@ enum io_state try_handle_mmio(struct cpu_user_re=
gs
> >>> *regs, }
> >>>        if ( info.dabt.write )
> >>> -        return handle_write(handler, v, &info);
> >>> +        rc =3D handle_write(handler, v, &info);
> >>>      else
> >>> -        return handle_read(handler, v, &info);
> >>> +        rc =3D handle_read(handler, v, &info);
> >>> +
> >>> +    if ( instr.value !=3D 0 )
> >>> +    {
> >>> +        post_incremenet_register(&instr);
> >>> +    }
> >>> +    return rc;
> >>>  }
> >>>    void register_mmio_handler(struct domain *d,
> >>> diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h
> >>> index 9b91b28c48..72d67d2801 100644
> >>> --- a/xen/include/asm-arm/hsr.h
> >>> +++ b/xen/include/asm-arm/hsr.h
> >>> @@ -15,6 +15,32 @@ enum dabt_size {
> >>>      DABT_DOUBLE_WORD =3D 3,
> >>>  };
> >>>  +/*
> >>> + * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and St=
ores
> >>> + * Page 318 specifies the following bit pattern for
> >>> + * "load/store register (immediate post-indexed)".
> >>> + *
> >>> + * 31 30 29  27 26 25  23   21 20              11   9         4     =
  0
> >>> + * _________________________________________________________________=
__
> >>> + * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt =
  |
> >>> + * |____|______|__|____|____|__|_______________|____|_________|_____=
__|
> >>> + */
> >>> +union ldr_str_instr_class {
> >>> +    uint32_t value;
> >>> +    struct ldr_str {
> >>> +        unsigned int rt:5;     /* Rt register */ =20
> >> I don't think it's a particular good idea to use a bit-field here, if =
that
> >> is expected to mimic a certain hardware provided bit pattern.
> >> It works in practise (TM), but the C standard does not guarantee the o=
rder
> >> the bits are allocated (ISO/IEC 9899:201x =C2=A76.7.2.1, stanza 11).
> >> Since you are *reading* only from the instruction word, you should get=
 away
> >> with accessor macros to extract the bits you need. For instance for
> >> filtering the opcode, you could use: ((insn & 0x3fe00c00) =3D=3D 0x384=
00400) =20
> >
> > Yes, this is a very good point. I will use bitmasks to access the bits =
from the register.
> >
> > I saw the same logic (ie using bitfields) is used for some other regist=
ers as well. For eg hsr_dabt, hsr_iabt in xen/include/asm-arm/hsr.h. May be=
 that needs fixing as well for some other time. :)

Well, there is no easy and clear answer as to whether to use bit-fields in
those occasions or not. From a practical point of view, it works (TM), and
has some advantages, like saving you from fiddling around with a 9-bit
sign extension, for instance.
But the Linux kernel discourages those works-for-me solutions, one killer
problem here is endianess, which is not a problem for Xen, IIRC.
I personally prefer robust code: but not relying on certain implementation
specifics (and be they very obvious or wide-spread), there will be less
surprises in the future.

So I'd leave this up to the maintainers to decide, IIUC the original
suggestion came from Bertrand?

Cheers,
Andre


> >
> > - Ayan =20
> >> Cheers,
> >> Andre =20
> >>> +        unsigned int rn:5;     /* Rn register */
> >>> +        unsigned int fixed1:2; /* value =3D=3D 01b */
> >>> +        int imm9:9;            /* imm9 */
> >>> +        unsigned int fixed2:1; /* value =3D=3D 0b */
> >>> +        unsigned int opc:2;    /* opc */
> >>> +        unsigned int fixed3:2; /* value =3D=3D 00b */
> >>> +        unsigned int v:1;      /* vector */
> >>> +        unsigned int fixed4:3; /* value =3D=3D 111b */
> >>> +        unsigned int size:2;   /* size */
> >>> +    } code;
> >>> +};
> >>> +
> >>>  union hsr {
> >>>      register_t bits;
> >>>      struct { =20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:16:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:16:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235898.409173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNas-0007wy-FJ; Wed, 01 Dec 2021 11:16:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235898.409173; Wed, 01 Dec 2021 11:16:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNas-0007wr-Al; Wed, 01 Dec 2021 11:16:10 +0000
Received: by outflank-mailman (input) for mailman id 235898;
 Wed, 01 Dec 2021 11:16:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kNZg=QS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1msNaq-0007wa-VF
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:16:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8705fe72-5296-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:05:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8705fe72-5296-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638357366;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=akoFfWVQuW3/lSJUhlj/Ed+4xcJeZB9+aYB4pPZ2o+Y=;
  b=QfIcWjARg3DLQgUPIJohBG6ExzaOojb34ZtvVx0eb7JHMhBqpU+Q9c5D
   WKo5z+xF17Nd5dd6IieITxLKBkDYozFwWUHZXqsN3MeHeXj7rVcUkMZCl
   XOgPSfE0gNI9ZqtFNfHR8FBvXli0A4XV2lxmHP+6NShUTrsVrVeMUGGxj
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Dq7kZ3HOilYplWNWU9JCLrz09ayTts7AZ3slSf4g6TPvKcHthI81diwOhxP7H5Fc8dZmov23eL
 VGI1G/wpKYbknKNAHPFWVdPwVt+XWcP4kOfsA7J523Itjlfmxor7E0BV5NlmSgpxWturzsDhpq
 R/h8nOxfHqqBrwdnaoctAuyZ8lzU1K26XGbZFTDeNMHae0jZUHmh+XkSS2Dwjg+aZrwEQXT2/N
 fEK1waaT2ZzNbuICEq1YjYPRQyp342kzIPgcsUQ8tIIfQ4hwVTC+TbwtE2znTTzvXcyWeBlTwO
 VjLV66I/wRuErXH0kt1PwmNc
X-SBRS: 5.1
X-MesageID: 58996273
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zYksZagoeEGk96n1SqXJMWwxX161uxcKZh0ujC45NGQN5FlHY01je
 htvDWzTaPfYZWf8Kdt+YYnj8k0FusfdyNJqSlZvryg9Qi8b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw2IDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1spITraBc0A5fKp/0wDiZJCjtPEPdvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauON
 ptHM2U0BPjGS0RvAQ4vC6sCpbeLpmvZdzFBkXynjrVitgA/yyQuieOwYbI5YOeiSd1Om0eEp
 krP52njHgwBL9ub1CaE9XS3wOTImEvTVI0eGbKi/9Z2kVaTwSoVExRQWlylydGph0j7V99BJ
 kg8/is1sbN05EGtVsP6XRCzvDiDpBF0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nO4nXWcLx
 kK0pdXWHBEyj6yMU0OwrJ7B+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hie22r0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJc3d/MBuaL9UdF1M2xpjGGaH6bKIN8N8nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpONLrWptynfW8SImNuhXogjxmOcMZmOivpnwGWKJt9zq1zBhEfV8XZ
 /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1ORDt8VqSPmOx5IOSIXc19z4/1w
 510YWcAoHKXuJENAVzihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:SepVDquJFl1eOpuJbpUz9KE67skDdNV00zEX/kB9WHVpmszxra
 6TdZUgpGbJYVkqOE3I9ertBEDEewK4yXcX2/h2AV7BZniEhILAFugLhuGO/9SjIVybygc079
 YGT0EUMrzN5DZB4voSmDPIceod/A==
X-IronPort-AV: E=Sophos;i="5.87,278,1631592000"; 
   d="scan'208";a="58996273"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH 1/2] xsm: Switch xsm_ops to __alt_call_maybe_initdata
Date: Wed, 1 Dec 2021 11:15:54 +0000
Message-ID: <20211201111555.16408-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
References: <20211201111555.16408-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

This should have been done at the point xsm_ops became fully altcall'd.  This
puts the xsm_ops structure in .init on architectures where it is no longer
referenced at runtime.

Fixes: d868feb95a8a ("xen/xsm: Complete altcall conversion of xsm interface")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: Daniel Smith <dpsmith@apertussolutions.com>
---
 xen/xsm/xsm_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c
index 21fffbcb41d3..14d98f1f725f 100644
--- a/xen/xsm/xsm_core.c
+++ b/xen/xsm/xsm_core.c
@@ -30,7 +30,7 @@
 
 #define XSM_FRAMEWORK_VERSION    "1.0.1"
 
-struct xsm_ops __read_mostly xsm_ops;
+struct xsm_ops __alt_call_maybe_initdata xsm_ops;
 
 enum xsm_ops_state {
     XSM_OPS_UNREGISTERED,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:16:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235899.409177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNas-00080T-Mv; Wed, 01 Dec 2021 11:16:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235899.409177; Wed, 01 Dec 2021 11:16:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNas-0007zF-I9; Wed, 01 Dec 2021 11:16:10 +0000
Received: by outflank-mailman (input) for mailman id 235899;
 Wed, 01 Dec 2021 11:16:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kNZg=QS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1msNar-0007wa-Nz
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:16:09 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86ba35b6-5296-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:05:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86ba35b6-5296-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638357366;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=3RCqUydL4JguIyYAIyTL4Uj9P2EGIVPmIXBDM4AOIhI=;
  b=hWgavtj9+EnJv+lymB7yCPkXEE59NOvofX+/p9930FeGLC9XRqkGzjsI
   obLJ9H7Ro2ZqYMaUiLMMIceBhMhCIubHyDsHL0QsqGz/mMtCFarjDZm6z
   fHQly8Ua9KSfWIbmAfi/KIrDogHJG1yvfc7CGUby8LGm8rqpu4h8a+/vH
   M=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: /iOujOQrYzOQvVZDdP1AztiG/29ayHSdM+M6iiKJip8IWqsLwR4ZduRw3k9qBacCqTH37oOw4l
 mhaXiyZsMk4dzNWVDn/4B6uxOl42jqMQ8LjxE0ZmDrjyzdz5jxz7/Z7dHqkViJBHdqb5gJZS7Y
 U6dtdzXclou84AomwRJCJumszN+mI0nmTm2E/yzXo0dGpvN4ilNQzlWWA1/Hz/i+qOR2D4ivxu
 cYjS1vSVERo2DDskG26MTAOyk+O/jNHa4diZyfPxCA8UWcBoLhTuQv80eaj74bYOc5Ey+EFd7/
 vj2XTT5jP1j3uigNnPbWUiAA
X-SBRS: 5.1
X-MesageID: 58511687
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MmornKB0tf8HlxVW//Lkw5YqxClBgxIJ4kV8jS/XYbTApDkk0DUHz
 2UfC2DUOv7bN2b9e9h0a9m29xxTvZeGx981QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Us7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/1BvZofVO0
 tN0upGQeAQLN4H3uOkjXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFjGpp354eQp4yY
 eIQayVGYjeYPiQMM0pHB4A4o/uonkTgJmgwRFW9+vNsvjm7IBZK+LT1K9/UZtyiTN1YhFqFv
 XnB+3nlAxYcL5qUzj/t2n6jiuLAhyrTRJMZFLr+8OVjxlKU2AQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEBbYG5/TeM8svY5SBwb1
 X2As+jJCAJg5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn
 mvU9HRWa6A71JZTj82GEUb7byVAT3QjZio8/U3pU22s9WuVj6b1NtXzuTA3ARutRbt1r2VtX
 lBYy6ByD8hUVPlhcRBhps1WR9lFAN7fbVXhbaZHRcVJythU0yfLkXpsyD9/Plx1Fc0PZCXkZ
 kTe0SsIusQDZir1Nf8qP9/sYyjP8UQGPY++PhwzRoATCqWdiSfdpH0+DaJu9z6FfLcQfVEXZ
 s7ALJfE4YcyAqV71jumL9rxIpdwrh3SMVj7HMihpzz+iOL2TCfMFd8tbQvfBshkvfjsiFiEr
 L5i2z6ilkw3vBvWOXKMr+b+7DkicBAGOHwBg5ANK7PYfFM5QDpJ5j246epJRrGJVp99zo/gl
 kxRkGcBoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:PMOlUa3P/ux+WCoHEbVAYAqjBKQkLtp133Aq2lEZdPRUGvb3qy
 nOpoV96faaslYssR0b9exoW5PwJU80l6QFgrX5VI3KNGKN1VdARLsSiLcKqAeAJ8SRzIFgPN
 9bAspDNOE=
X-IronPort-AV: E=Sophos;i="5.87,278,1631592000"; 
   d="scan'208";a="58511687"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH 0/2] xsm: Further fixes
Date: Wed, 1 Dec 2021 11:15:53 +0000
Message-ID: <20211201111555.16408-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Andrew Cooper (2):
  xsm: Switch xsm_ops to __alt_call_maybe_initdata
  xsm: Drop extern of non-existent variable

 xen/include/xsm/xsm.h | 2 --
 xen/xsm/xsm_core.c    | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:16:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:16:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235900.409195 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNau-0008Ty-VQ; Wed, 01 Dec 2021 11:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235900.409195; Wed, 01 Dec 2021 11:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNau-0008Tn-SM; Wed, 01 Dec 2021 11:16:12 +0000
Received: by outflank-mailman (input) for mailman id 235900;
 Wed, 01 Dec 2021 11:16:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kNZg=QS=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1msNas-0007wa-O9
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:16:10 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88f671dd-5296-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:05:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88f671dd-5296-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638357368;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version;
  bh=YkekjYG04jbiZH/kfWiElK2zEy91zRt0qThwJ4BT3/4=;
  b=LDRcKFp6HTq9GDeKER75zQZm3REMZ7JiLRZD8mbmry763Iqx6vZyJuo8
   p7W1eHornc1cbUlr+8J/xCtQt27fSrOK8tFJ0Z7VVM27xLDWfcxPM99//
   UndGreTdpJob4CQt6TgvXxJxOrQuQLfTnvUp7CehS4RjGEdOnjxGYmrn3
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: wI3yVvBLs5CHucLgP7kmdipbf3Bg7n908gjuMSJ3OitN9eVntiRfUan5P+wszZvYIQtiPOmVJB
 0lxl66dN3aVuWXOoLN17kBq2H81T0IshCRTw8M0BL6i4sqso+Mpr389AmA1dzpMxDquRSxLwaF
 /ZV23Ky34YAmunXGO2LWfnpJNCwBrbe+UMJWwzf0o4SEZHWYG+QLhTroxFU+hwWkN/nD5xvANS
 jcCEWTwB9HzUQIBYjPoq1aWtiA/WQwM1N9v2hwUrL1cUknRLHCb21679F8xJfOYVLOHh8c2iuH
 7tMLYdDPt/8ohOPBorVIAWVk
X-SBRS: 5.1
X-MesageID: 58996274
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:uXljoK3JDKtuppUu3PbD5Qh2kn2cJEfYwER7XKvMYLTBsI5bpzAEn
 GEdCDuBPKnZNmWjLtx1bou+8UIAvceAy4RkTVA5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es5w7dh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhvsFpk
 /RdqKGKTzgwE/Dzif0HYjQCOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t1pEfQ6yBO
 6L1bxJvYBSeOCB2JmwGM6oRpb7xl1jGKRth/Qf9Sa0fvDGIkV0ZPKLWGNbNYdmLWcV9l16Vv
 H7b5H/+BgwGNduZ0nyO9XfEruPAkS70Qos6CKyz9vkshkaagGMUFnU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZgecR9ld8reAYs6
 Uakwuz4HCZenee8HCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjv3jpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDCvIji7rnXzURhpdnh+pnyvJ5p1xWG3DZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYiD6N/4oO9LsV5l3pUQFKTgDfquPBjapSsIsHDJrAQk0PRLAt4wTuBZEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7BohIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrLZf1c9Rjh+U6S5LHFIU9UNopm5X9zgp
 hmVMnK0AnKm7ZEeAQnVOH1ldp31WpNz8SAyMSA2ZA760Hk/e4e/qqwYcsJvL7Ug8eViy99yT
 uUEJJrcUqgeFGyf9mRPd4T5oaxjaA+v2VCEMR26bWVtZJVnXQHIpIPpJ1O96CkUAyOrnsIiu
 Ln8hBjDSJ8OSl06XsbbYf6i1X2run0ZlL4gVkfEOIALKk7t7JJrO2r6ifpue5MALhDKxz270
 QeKAEhH+bmR8tFtqNSQ3PKKtYakFed6D3F2JWiD4ObkLzTe80qi3ZREDLSCcwfCWT6m466lf
 +hUka3xaaVVgFZQvoNgOL931qZitcD3rrpXwwk4TnXGa1OnVuFpLnWchJQds6RMwvlSuBesW
 1LJ8d5fYO3bNMTgGV8XBQwkcuXciq1ExmiMtaw4cBfg+St63LubSkEDbRCDhRtUIKZxLI54k
 /wqv9Qb6lDnhxcnWjpcYvu4K4hYwqQ8bpga
IronPort-HdrOrdr: A9a23:NlpJ0agrL/klote791TZpKzQfnBQXtgji2hC6mlwRA09TySZ//
 rBoB17726MtN9/YhEdcLy7VJVoBEmskKKdgrNhW4tKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QFJSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.87,278,1631592000"; 
   d="scan'208";a="58996274"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH 2/2] xsm: Drop extern of non-existent variable
Date: Wed, 1 Dec 2021 11:15:55 +0000
Message-ID: <20211201111555.16408-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
References: <20211201111555.16408-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain

dummy_xsm_ops was dropped as part of organising XSM to be altcall compatible,
but the extern was accidentally left around.

A later change reintroduced dummy_ops which is logically the same thing, but
is private to xsm/dummy.c

Fixes: 164a0b9653f4 ("xsm: refactor xsm_ops handling")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: Daniel Smith <dpsmith@apertussolutions.com>
---
 xen/include/xsm/xsm.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 5aa4dd588d17..3e2b7fe3dbb3 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -789,8 +789,6 @@ int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size);
 bool has_xsm_magic(paddr_t);
 #endif
 
-extern struct xsm_ops dummy_xsm_ops;
-
 void xsm_fixup_ops(struct xsm_ops *ops);
 
 #ifdef CONFIG_XSM_FLASK
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:19:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:19:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235913.409205 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNdu-0001Sj-GD; Wed, 01 Dec 2021 11:19:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235913.409205; Wed, 01 Dec 2021 11:19:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNdu-0001Sc-DB; Wed, 01 Dec 2021 11:19:18 +0000
Received: by outflank-mailman (input) for mailman id 235913;
 Wed, 01 Dec 2021 11:19:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNdt-0001SU-K4
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:19:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f8f2cb4c-5296-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:08:12 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-jtsYoZX9OlGWnqfnTOiT0A-1; Wed, 01 Dec 2021 12:19:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:19:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:19:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0023.eurprd06.prod.outlook.com (2603:10a6:20b:462::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 11:19:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8f2cb4c-5296-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638357556;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ON7hD8sHqeqLdbOjK5/eHp1WPkZVK6dUNLVok3+jMsU=;
	b=gieOwb2oV5XYwfRATR8fGY0+3nolpSSd2/qEiZhtzPYeKY1CSbUBQrcawrPK5HmVvhDLG6
	RRRElHJUo0Cl42xBXExU1iiRhg/udLOZLtRb33M3eeFSyI1jUeQFE73uPexwDmOaiuVvP6
	7/ufPl7RivsL6JIPwb3gonrqB6gI4Zw=
X-MC-Unique: jtsYoZX9OlGWnqfnTOiT0A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LbndUAh/fKP4Ne1jfBS+5I0sfutBK41rFsS2pAUG4H5PYBaxfAaUN9Xxi4kSyyKGykECNql9kGSg4e0zMYQ6Yb2c97EgelGyq/nZDug7KdCC26xHlwamFc5Tz+Xu2O8w4FDCYZzfWfafhKgvyFiGHGhYMYeV0YavfOSNl6w/nI48QPbl6WH9pQUz7zsVxzZ1F2+CcmM35yr2deGA0lpij2LBdKV/PXBvZ1M9ASRuoblg/sMSIJquafni2Dv90zRK1HDJ4qzBtUEzUV5zcPWFhc4Er2yYzjjwZo6SIonHZK2ONN2/y+6/G3LK3ThudNxKM2gDab79Im7vduX5EumIiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ON7hD8sHqeqLdbOjK5/eHp1WPkZVK6dUNLVok3+jMsU=;
 b=cAU6jqKvAchNwxfxxuwSWr7UCHR8ujJNURsCPHB+DIppl8zuklf8iunR2iWvf94zYhrCMO0rKyEfrllDavuTyS4lHtIILgejN2kp7JShqUV0ENVAAcTYW0MtwpG5t8YQeIet90oeqPbVG8oBPv7fMXk8BO4elm3llMSYLpBktpaNQowSIS/ItkUc/DWm5QeUvJQ6W+lAyg8mUTc2ldopp975eWBQjYI0MwhxpwZChcfAii+c7BtHZpZhAGTIiahsGNGsbAiLr3IvUoZ0p8mk2QnmqOxmyDXMEpEcSIIvI3P/S/so3bwT3hAN9/xDG+BSuQ50ONxynOu4bJAoMFjOSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
Date: Wed, 1 Dec 2021 12:19:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] x86/mm: get/set PoD target related adjustments
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0023.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ed31984-396e-4735-938c-08d9b4bc66f2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39365FE8BF0AD992BFAA3F5FB3689@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uvLLqd1fZasjR+MnTiJxJsqaH07X5NA86Qmm2VBDq90Nxr+JLbUfg/CNkyxuUTVYLRRcBp2tT5v7tHTdic79R4aZmcCGviSAt3dmfEkLBwYriNJyIUwwEsVIGqSFd2o/OT4UasX8FkJtFwOv8luvzpNYx1R2+n0OBQeI8lt6hPssClelXZ20IjOPiSyc0iGSrnynvMKz4SSiYguqAU16kgT1Wmyck6F/nUo2UoozKSFxjd78fTurHbW+q4NhSYzAx9sMTipn4QKcctzC2fZGhDsm59ea05FImO1eGD2+G07OcbQDv+w0BBnrlOvpya9dfljeUYFeDrd7xqYZogTr4lrjOXo10Bm7JVh0U6anKu81GmJsjWAVlwZBKZlalfKVUt641MXiWRYH5QmKDcY9uXhorOzjqpYLOXJIlXzoM3yNoYTbqUo9hOpRgrgKmT/Ut2NmdgTj9fB/TdgTYgxLIT9XT/BiSjNINbEjvSchP2VS4mlzbCtBrXh3kLls/J4ozIM2uEodk2Z623xEe2YI6LCisq2NqZ+4qzBfLqQ1KbR0D265p93i/krcQgNdJ5sPiSS0Xm0soOUPbQTETKHVuYDmr13Px8ai1KATWFwmUSUWc7XzlnWXfbjM9e1h06M98FLFr4cdG2BYdsvgFb+5oj6FtHXHsw6i1yR8GrJw0RtbReL3kfLt5FSnbMjpLX+S3tTADzOwOgoRJy2Z41uU35fj5keOHw5TBVUirCE/8uw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2616005)(36756003)(6486002)(4326008)(86362001)(5660300002)(6916009)(508600001)(16576012)(54906003)(66556008)(66476007)(31696002)(26005)(66946007)(31686004)(2906002)(558084003)(956004)(186003)(38100700002)(8676002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M0NFS2x6SUpnRVhNTTRaVmtud1B5WHRHMmNHdHZFeEVTQWdjYkpQdFFTQ21p?=
 =?utf-8?B?K1VuazNoekVLc0Q2MUFsRllyRDVmWEg2Qnh5Ny9hRXNkS2t3K0hQdkh1TUhl?=
 =?utf-8?B?QXJlS3JHMTlCbFgvekZKd1RvbE8xQm12VCtCL0Z2SElOWlZzcExBVHlCV2sx?=
 =?utf-8?B?VDFIejN1b3J0eVEzZDc1ZEdTMWk4SXpRaDFOcG9PR0hTdjR1SnNHc0JnUUdy?=
 =?utf-8?B?N0VGVXZ4ZDBua29TWVZZSWZwWk81YU0rcUg3SjVONGpyQTR4SnU2bHZvSXBs?=
 =?utf-8?B?NDdTVzJDSGxDeEFMM0o5WERpdzE0NUZhQU5yNG1hbE1YTkNqQzlFdnBqZWNk?=
 =?utf-8?B?QTVhejJIVVBHaXlIYWFsY2x5dVlhRWZSZWxLL09obmMzWlhreC80Ri9ITHJa?=
 =?utf-8?B?VjQ1TENXd3MveVBYb3dTNC96SUZoanQ2VGJ3MDVkKytqNFA0NmUyS3dQNGUy?=
 =?utf-8?B?MWtlVDhOVjl0VkZET0VENXpBVjdzbERlbkd4RTdlM0tWUVRuS2pOdE5FcWRq?=
 =?utf-8?B?aldLbi9nNUFORnBjdTdCck5aV3hFa25YYVJPTFl3WU5JSy9JanNBZUdxNXRN?=
 =?utf-8?B?Vng0WTNMOFJ1aE5nNjFqellzSDRjaWNMNnNiT1dYK2ZLMVFVcGxIeW5XdVZ1?=
 =?utf-8?B?eDY2WTFUZEluR3k4VXJ4SkRkK21LU0M3bWlxWE1qaGNhaTFiZTYvNzlabC9O?=
 =?utf-8?B?RUcwQVpSQktqZjZ0TGFjN0Q2b25RaFVhK0Vobk5XVitXRVZvcERSQ3JTZElD?=
 =?utf-8?B?a2RWMDNFenVSMGZwcTZ2ME5FS3g1enY2Q3NiRStFVTAyaUlObXpEcjhYWGV6?=
 =?utf-8?B?MnRwc3c4WXdUSEJHTnRzM25WdnVhZkl0eXRKRmlBVFdTUDQvN2NtdVEvSlBT?=
 =?utf-8?B?aTkwTmUyekJTTEZCaFg1ZlpkSnFJOC94aE5TWlVTYUdkV1lDQkZUVmJqNzlW?=
 =?utf-8?B?YkZ5czJGM1V2NS93YXVuTU4yOXVMVFhwZWQ0VDJsZnF1YVFvY21wNGFvVk1E?=
 =?utf-8?B?SXR2emNndmN1UEZsR0J4QVNtclFSQW56djhrWGdaYzc2TnJnazlaTzN4SzJ5?=
 =?utf-8?B?S1BDM1V4R2ROMGdDcWo1enZxWVVZbDVQVVA4TjZTZGk0QkoyUVhCb0Njdnh2?=
 =?utf-8?B?ejhyL1hDczhhWFlTY045MkNkejJBVDZ1aTFJVGtURDNVamZ6YlV4emliN3Zr?=
 =?utf-8?B?T2o4bEM3WmFCM1hEdExPOGJaY1JrWEpRc2RhUld6STJwOXVIZlEwVEhNV3pP?=
 =?utf-8?B?c3IzbGc2dHFBVXlNbGgyUkg0SEtVRkVLRTNjTVdqZVNhZmowUXdxYi9nc1Nv?=
 =?utf-8?B?bkcyR2IvK2JMZmZDdENZck1NWTU0MHhhby96bEtkNitJSVVQM1Z6RjNQbkZW?=
 =?utf-8?B?M0dCMVdRTzZrV1V2N01hUjQrOVRMQWZXcVdSL252RWk2bVZTRnFxLytSQ2xQ?=
 =?utf-8?B?dlZmdzdYV0t1dkEzNEtweHlvbnBBME9jbjBpdXJjQStBWk4vYm5WaWd0TytU?=
 =?utf-8?B?eFk5R1lNNTlNNGZwVGptZlg5bWNxV3c0ZUt2alUwbVJuRVhVZ0FUcUNWa25D?=
 =?utf-8?B?V08vU00wa3paVThRYkxUVTVMd1lLQTI0Z2dCYnJ4SCtKemJuVzBCUnRrYm5Y?=
 =?utf-8?B?STk2UmN2ZGY1UExYQjhtUUM3QkhRd01pcS9Ya1pRdFdMMDRJdFA2WjN4dVRr?=
 =?utf-8?B?M2RiR1k4bUhNc0FNUmNNSFFkU1RpMTE0YVc1RFVjLytHdkdLZkl1enh4MGdX?=
 =?utf-8?B?eHZYK21pUVRIVC8rSmZEU2RuNFZoTURRWVIrK3FSdjVGdjNnOURNdDVkaFBw?=
 =?utf-8?B?c2xMRUlxWWVEVmwvU080bFNLTXM2eE83bTVHcGZZLzNBS0xtNFY5bVBxU1g2?=
 =?utf-8?B?aFkzRTZaTG4wTXZLR1hSQjYzTHp5dXVESzcycll6VFZwWnFmSndsSUJlVGhU?=
 =?utf-8?B?SzdQa1RoT21jV0l3cU5XRXBDUTViZytCZ2c5OHJ2Z09KTDVZR0ZjRXFkUjQ4?=
 =?utf-8?B?RC9WQkFPRGt5NDNad2Z6Q1VHS1YrSTFOODVlRzhlUWQ3NUNKeEp2QjRoSGU4?=
 =?utf-8?B?a2JteHVvZkJ0YTJaN2tsbkJCZ1NIMFh4d21OVDhFTXhwc3E4Sng2WGljWUFa?=
 =?utf-8?B?b1Z3aDBKU3l4SUhHa1NsRG1nTjRWa0ZxWm1Eb3pKeFZ5WHR5K2ViTGF5RUZZ?=
 =?utf-8?Q?s/173EQKwiKgPFrQMzH800k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ed31984-396e-4735-938c-08d9b4bc66f2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:19:12.5179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: igJgycaQ+EfzJIBDZ1JbWbKH2s3sody60WmnnU4OQwoexow2lIQjs7TY8uT+TZBFQd6Ubuqc78JnTgt2Q9pQGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

New 1st patch, subsuming the original one.

1: IOMMU/x86: disallow device assignment to PoD guests
2: x86/mm: tidy XENMEM_{get,set}_pod_target handling

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:20:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:20:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235918.409217 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNf9-0002lb-Qt; Wed, 01 Dec 2021 11:20:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235918.409217; Wed, 01 Dec 2021 11:20:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNf9-0002lU-Nl; Wed, 01 Dec 2021 11:20:35 +0000
Received: by outflank-mailman (input) for mailman id 235918;
 Wed, 01 Dec 2021 11:20:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNf8-0002lJ-VB
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:20:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3294761-5298-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:20:33 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-noYV7RiEPEKp4BGql6JYqA-1; Wed, 01 Dec 2021 12:20:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:20:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:20:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:100::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Wed, 1 Dec 2021 11:20:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3294761-5298-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638357633;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uVzkRXmNhEFLnejBb+/P0JNRxNOczXHfjbrfmo5RiEM=;
	b=E2AZEDKGHYI/hYHOVgiz8hJmGESv+Yolo0MN8cfUiOz5kTPAPKxRfLPqMBobJV9swrmNcx
	XIZGE7e3PTQHxBWJ9YQFqbGvoPxZP1hY+WgIVRjEgr3V03nQ227i6WQltOYWXnxHDeUSS7
	GWV6lp3Bb0wTkgSLG48UuU7XRKJqAuc=
X-MC-Unique: noYV7RiEPEKp4BGql6JYqA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Bgte0DhyRDGnwNBt/cVkzSoKG2OJWsBnFmHS4zKCYfPu5jpcljMx+F4svgWONsfkJpL9fcStYhdOVRFR8XpPFBbEYFoPrvNIUA887Gna5yyItzE98ha4PwhrUiEkWEYmECShSufjZJO9RMkFUzDjB4Gh4QTO/7T18KryIKaF4D7GIpeISZ9OkQvkLpMDMJzfkVCbahOVOQ9Ab53g6CurY6YW1Q0v0/ICrEk7LNPLqD/cXinmbc5h0+zEND5qxmXPVAvJly18FqKOJcGZgLnE8DEBGrQGlR5QhTOKbOFueIBwRDDOj2vckGJhnRHi2oEb5A07Sd7atLAqufvYIB0rTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uVzkRXmNhEFLnejBb+/P0JNRxNOczXHfjbrfmo5RiEM=;
 b=N5HnvmbqDrUGJeXS3SrBm2tSzr5BGa4jT7e8EbI+C3GAV8K3ifLMpxnBDdyP5hgJnkxhOsvpmHbGFcUwzJ/1EMir+pbg1pirYb+6XwC54ETtcymzCCtEwVlLlYpLtlloXjhDse+5ryqkmf2cNtkzNYGD2CuN6apjp9DAbihpLeCMtjXmcUvI5BLp9weFyfXf9RC7KlaOmJwaqxMKhuv7LKT4oNGbhIdHXg5Fzl4v+OWXi2InICjm+xMpj2iHllACb/0wf6hOFReJpW5/RJY7TRXcfsJkPkx0r9viCmea9K9dfpkNf3LVT/a3/OwBdtjyaQQMxTga1d8Yx/YaEk71Wg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81a27b5a-99f7-d929-987a-1dcf2433144b@suse.com>
Date: Wed, 1 Dec 2021 12:20:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 1/2] IOMMU/x86: disallow device assignment to PoD guests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
In-Reply-To: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0010.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 15f64a15-07c7-43b9-6a27-08d9b4bc95fc
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39362C4220065DDAE4878E75B3689@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L+iW7oNWzbaCAtNL9/PU83c2pofWk3Geqm6xcjzpd+JxYwXa7sIsqxNEJE4G6hxZK5VRsGUXmkpve+nZujQzEl5/6qGH8S4aqHBElNzStdyNQV7MJh/eqcCG4fpeSjqP644pfKauc/v0JdVWil/ayjjXCl5DgNjiu3GOyukWGe35Q9i2TtTHW0lFMxMaeDklV9SoR7wxXw8sa4V8HZugRJxncFf6f3YkEv6yudDKJD50RFGxF3WRRhT+92om5nRGoPOzi5L0JONy3F1ct8rp0bQ02JPxydtqgE63iIsehzC69gEiGgrP5i1Vyt5E62UQ8we1M8hWQ94BUJ2keGsBwcE23EfrfU709P3TFkHmzhuuY3e9b0UUIfOAnkeFPRkjfNCKyBp2Lmp1i6x+9bxN+j0kkubov4nc/9bpYPjxI0c624T66nIES2nfgCvYBAb/eQ7PFqP6muu30b2qKbVUmP9LZhNeLfSJ77uyJqUWU6k0ah7aFUbZODucFMIpyi53nsWva3kCdPMG+Dxw8sJ8WIFIeidEOIWNtKRLJLPRxkkl5jd6Jd8+dNud8UnyF8my0ezwHqlualiv909HyMzbVg8qwR7J3KjDbS7QSSXSfGaSCsw0QOPsxN6VaUQowphTgdbcI1c1XIWTeOEk83yX4ZH+0nbRMoB4HrnY7zrOJjQveRqB47ngd9yQW88PCwuQgL2JiKxzDpHCwOzDet6WDuPsO/rBlSy2TlZc4GRD6Wc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2616005)(36756003)(6486002)(4326008)(86362001)(5660300002)(6916009)(508600001)(16576012)(54906003)(66556008)(66476007)(31696002)(83380400001)(26005)(66946007)(31686004)(2906002)(956004)(186003)(38100700002)(8676002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eUZQbzdpZEI3S3h1VW9BQ1ltU1NDOW1MYkx1UXg4Ujc5bWhDYStLQkkxZjJO?=
 =?utf-8?B?ekJqdUdyRlk4RnM5eEtHWGFKSHRLRU5nSVFHTXkybXl6dmpzTDJnbGFCT1lr?=
 =?utf-8?B?eCt5WnhPeFdpVC9iMWl5NFBDbUFQakpoelhLd21ZTVFqMWhka09zWkl5QTRt?=
 =?utf-8?B?cFdaTEtwaEdmekxUa2czUyt6SHE1Y2V6WVQxL01JQ0kxTUlpUno3UjQxVjJ0?=
 =?utf-8?B?OG5wMUQyZGRaVDZLQ0hXM0F0VThHRFN1cnA0dFB3a2NBSmliZEhBOTA5c3Iz?=
 =?utf-8?B?NFhGV2VtNjdhLytDR1dvbGZGTWMxRGJNcStTVkhxdUFUZG8xN3Q0bEdEYlhr?=
 =?utf-8?B?a3lIMVlwUll6U21vSzZneEZGUCtQbVZ3UmQ3eUZkbXk4RFA4OEUwWUFVMFc4?=
 =?utf-8?B?bDkzMnBXWVlEYXd3MFk5SytXSDE4bnYrV01laDA0cnAxbXltemEwSDdiWnc1?=
 =?utf-8?B?OVBrOGFIOGVWUklVUkYyRGJzT3d4clIvNGJMZE1peVlNNXQxTXNPQkdGZHZY?=
 =?utf-8?B?RTg2dUhUOUdmQWMvV1pNdENaYUxrMGhQK1VRc0l2a2VvN281bmZJNXZyeWly?=
 =?utf-8?B?MU1aVUhwZjhwM1BaaEJUaVB2L0tUdWV4bWs2Wkt4RllUUmVWdWRGbVVXY2JM?=
 =?utf-8?B?TTlwU3RiS1JhcytpMnNPdzdZWTlOV01Fb0YxODlnTGEyMWpMRWhVOXc0R1h5?=
 =?utf-8?B?MktVZ00xSVlQRWxBSTlTZlNDSDZkcFRpNk5zbm84WWFmM0dxb09QTzUvOXBV?=
 =?utf-8?B?Yjc5cmlPbHB2c2N3cGZhYVd1MHk2emZ6UHJLTDdzMUF0TzJXdzU4eUh1K2lw?=
 =?utf-8?B?dXQwSEJEVkpPdjU1bm14SlA4cHBQVDRyYWtLeXN2MjlleG5tcUhmK1M5TnJI?=
 =?utf-8?B?MGNUV0ZueFdLb054Z2QrRTFjOWkzZ0MyWGl5OHhVZlU3R3dDaVpidVpIRy94?=
 =?utf-8?B?a3l3STNudzZFcExBV0RsU2k5QlFNYlhNSHZqT1FRdUQrL2hDUlQ3b1o0TUZa?=
 =?utf-8?B?WE1Kb2tST0YwTE81anFWRXMzbkdoK1BCaWZjS3NnNGJsMng3dEZlcERMenpI?=
 =?utf-8?B?NzZxNmgrbUVQV0JYb3VPemRSSnRkalNJc0Zma1ZzdGNCTHpVMk9OekxaNnRU?=
 =?utf-8?B?R2xEVTFHTWRDYnZlSHcwdTdmclRSTG13Qkx3M3E4OW1BRTdESURSYng0MmRT?=
 =?utf-8?B?RWdVU0dFTHBNa0hxMkVVbGo5SGczU0EzQnNhV2sza0dvV1dxb0drMmJiRFpV?=
 =?utf-8?B?UU1IdWVlNXdRNld1c1lLR0VXSjBUWjdsUjJidk45RXAyck0weUZzUE9GT3FT?=
 =?utf-8?B?L3JvQkRNQnQ1QmMxZ2RKaU1scndTZTF0alhYWmgrazVRWEltV0dTd25oQkE1?=
 =?utf-8?B?SWt4bzlMTmI0bTZTRWFGZThFWXZPbnV5bTFrZlZCVlA2Z2RDYU1LWlJJUE1Z?=
 =?utf-8?B?SnJ5S3p4RndidlpyT1REaS9FaEZxeFZzU2UyWERsTDFYbXFLRDNiWmpvdWpV?=
 =?utf-8?B?YlBOTmE4SWgvNC9EOTZSUWN4dm40MFFKQUx6UFR6b0oybFBLUlE5WXlpN0ND?=
 =?utf-8?B?OGFXV1BjalEyMDkxb2RCUmc0MU5Hek1Sa0ZFTFJRS1AvMHpIcGN2dUxvbmtj?=
 =?utf-8?B?ZmFPQ2RvQmxGSkgxR0x6cUpZUEx0TXc4ekZzR1RyU3RjN3JLOGNFNi9VbEFL?=
 =?utf-8?B?YWo1NWhNZndmQmw0UW16VlU2alNqYWxCZHNqdEF6VWdjRVU2TTNBdE8vV1do?=
 =?utf-8?B?a1VpVjU1UExnUnl6YXNaNGpyZkhmY0kyNnQzaHFzYllvMzkwQUVHWUgvRnRN?=
 =?utf-8?B?aHFHc1FRL29Jd0EvR0FmMHFTaStWcmp6ZmtIS29SellYeHhBbTQyU0ROMnhT?=
 =?utf-8?B?MlZCWjF2QkFEK2tnVWZRRnVjRDVzcEtxUFZpdkN1eEJ0bGtrck5qaStWbEpS?=
 =?utf-8?B?T0owM2RKOGtnc1UxbXJFVVp0WGlEQThrdTVnYnN5czlJRFV6cGtiOTNIU2VJ?=
 =?utf-8?B?RU9WbnFvRm1CdDZ3ZkcwVVdRVld6Wjd2ZE9zUnljcXNHZEljU0RsVjNCRWJh?=
 =?utf-8?B?S0F5SVNKVWpjVHZxODV0WVBmT3ZZQWd1ZlMyV0FWRGFmY2tBcjM4RU9tUnlq?=
 =?utf-8?B?NzRzTVZDa2NuQ1YwQ3R2d0pZZUM2SHp2VzRxSFlTQ1VVbzFUc0k5eWpaVmk1?=
 =?utf-8?Q?fYhpZAi8SwVrG+BOn1YaVCo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15f64a15-07c7-43b9-6a27-08d9b4bc95fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:20:31.4403
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cxTrwQZgy3EEZs5z4bq6SKVRXpSGaWDxp3ZMmz4vOytLvUkO9ChykBP/Aht6HfelsToJsGHD2uCDHZQt7JnhbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

While it is okay for IOMMU page tables to get set up for guests starting
in PoD mode, actual device assignment may only occur once all PoD
entries have been removed from the P2M. So far this was enforced only
for boot-time assignment, and only in the tool stack.

Also use the new function to replace p2m_pod_entry_count(): Its unlocked
access to p2m->pod.entry_count wasn't really okay (irrespective of the
result being stale by the time the caller gets to see it).

To allow the tool stack to see a consistent snapshot of PoD state, move
the tail of XENMEM_{get,set}_pod_target handling into a function, adding
proper locking there. At the same time fail such requests for PV guests.

In libxl take the liberty to use the new local variable r also for a
pre-existing call into libxc.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
If p2m->pod.entry_count == p2m->pod.count it is in principle possible to
permit device assignment by actively resolving all remaining PoD entries.

Initially I thought this was introduced by f89f555827a6 ("remove late
(on-demand) construction of IOMMU page tables"), but without
arch_iommu_use_permitted() checking for PoD I think the issue has been
there before that.
---
v2: New.

--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -1619,8 +1619,13 @@ void libxl__device_pci_add(libxl__egc *e
     pas->callback = device_pci_add_stubdom_done;
 
     if (libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) {
-        rc = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci));
-        if (rc) {
+        int r;
+        uint64_t cache, ents;
+
+        rc = ERROR_FAIL;
+
+        r = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci));
+        if (r) {
             LOGD(ERROR, domid,
                  "PCI device %04x:%02x:%02x.%u %s?",
                  pci->domain, pci->bus, pci->dev, pci->func,
@@ -1628,6 +1633,22 @@ void libxl__device_pci_add(libxl__egc *e
                  : "already assigned to a different guest");
             goto out;
         }
+
+        r = xc_domain_get_pod_target(ctx->xch, domid, NULL, &cache, &ents);
+        if (r) {
+            LOGED(ERROR, domid, "Cannot determine PoD status");
+            goto out;
+        }
+        /*
+         * In principle it is sufficient for the domain to have ballooned down
+         * enough such that ents <= cache.  But any remaining entries would
+         * need resolving first.  Until such time when this gets effected,
+         * refuse assignment as long as any entries are left.
+         */
+        if (ents /* > cache */) {
+            LOGD(ERROR, domid, "Cannot assign device with PoD still active");
+            goto out;
+        }
     }
 
     rc = libxl__device_pci_setdefault(gc, domid, pci, !starting);
--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -20,6 +20,7 @@
  */
 
 #include <xen/event.h>
+#include <xen/iocap.h>
 #include <xen/ioreq.h>
 #include <xen/mm.h>
 #include <xen/sched.h>
@@ -333,6 +334,9 @@ p2m_pod_set_mem_target(struct domain *d,
     int ret = 0;
     unsigned long populated, pod_target;
 
+    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
+        return -ENOTEMPTY;
+
     pod_lock(p2m);
 
     /* P == B: Nothing to do (unless the guest is being created). */
@@ -370,6 +374,23 @@ out:
     return ret;
 }
 
+void p2m_pod_get_mem_target(const struct domain *d, xen_pod_target_t *target)
+{
+    struct p2m_domain *p2m = p2m_get_hostp2m(d);
+
+    ASSERT(is_hvm_domain(d));
+
+    pod_lock(p2m);
+    lock_page_alloc(p2m);
+
+    target->tot_pages       = domain_tot_pages(d);
+    target->pod_cache_pages = p2m->pod.count;
+    target->pod_entries     = p2m->pod.entry_count;
+
+    unlock_page_alloc(p2m);
+    pod_unlock(p2m);
+}
+
 int p2m_pod_empty_cache(struct domain *d)
 {
     struct p2m_domain *p2m = p2m_get_hostp2m(d);
@@ -1387,6 +1408,9 @@ guest_physmap_mark_populate_on_demand(st
     if ( !paging_mode_translate(d) )
         return -EINVAL;
 
+    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
+        return -ENOTEMPTY;
+
     do {
         rc = mark_populate_on_demand(d, gfn, chunk_order);
 
@@ -1408,3 +1432,20 @@ void p2m_pod_init(struct p2m_domain *p2m
     for ( i = 0; i < ARRAY_SIZE(p2m->pod.mrp.list); ++i )
         p2m->pod.mrp.list[i] = gfn_x(INVALID_GFN);
 }
+
+bool p2m_pod_active(const struct domain *d)
+{
+    struct p2m_domain *p2m;
+    bool res;
+
+    if ( !is_hvm_domain(d) )
+        return false;
+
+    p2m = p2m_get_hostp2m(d);
+
+    pod_lock(p2m);
+    res = p2m->pod.entry_count | p2m->pod.count;
+    pod_unlock(p2m);
+
+    return res;
+}
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4777,7 +4777,6 @@ long arch_memory_op(unsigned long cmd, X
     {
         xen_pod_target_t target;
         struct domain *d;
-        struct p2m_domain *p2m;
 
         if ( copy_from_guest(&target, arg, 1) )
             return -EFAULT;
@@ -4786,7 +4785,9 @@ long arch_memory_op(unsigned long cmd, X
         if ( d == NULL )
             return -ESRCH;
 
-        if ( cmd == XENMEM_set_pod_target )
+        if ( !is_hvm_domain(d) )
+            rc = -EINVAL;
+        else if ( cmd == XENMEM_set_pod_target )
             rc = xsm_set_pod_target(XSM_PRIV, d);
         else
             rc = xsm_get_pod_target(XSM_PRIV, d);
@@ -4812,10 +4813,7 @@ long arch_memory_op(unsigned long cmd, X
         }
         else if ( rc >= 0 )
         {
-            p2m = p2m_get_hostp2m(d);
-            target.tot_pages       = domain_tot_pages(d);
-            target.pod_cache_pages = p2m->pod.count;
-            target.pod_entries     = p2m->pod.entry_count;
+            p2m_pod_get_mem_target(d, &target);
 
             if ( __copy_to_guest(arg, &target, 1) )
             {
--- a/xen/common/vm_event.c
+++ b/xen/common/vm_event.c
@@ -639,7 +639,7 @@ int vm_event_domctl(struct domain *d, st
 
             rc = -EXDEV;
             /* Disallow paging in a PoD guest */
-            if ( p2m_pod_entry_count(p2m_get_hostp2m(d)) )
+            if ( p2m_pod_active(d) )
                 break;
 
             /* domain_pause() not required here, see XSA-99 */
--- a/xen/drivers/passthrough/x86/iommu.c
+++ b/xen/drivers/passthrough/x86/iommu.c
@@ -451,11 +451,12 @@ bool arch_iommu_use_permitted(const stru
 {
     /*
      * Prevent device assign if mem paging, mem sharing or log-dirty
-     * have been enabled for this domain.
+     * have been enabled for this domain, or if PoD is still in active use.
      */
     return d == dom_io ||
            (likely(!mem_sharing_enabled(d)) &&
             likely(!mem_paging_enabled(d)) &&
+            likely(!p2m_pod_active(d)) &&
             likely(!p2m_get_hostp2m(d)->global_logdirty));
 }
 
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -661,6 +661,12 @@ int p2m_pod_empty_cache(struct domain *d
  * domain matches target */
 int p2m_pod_set_mem_target(struct domain *d, unsigned long target);
 
+/* Obtain a consistent snapshot of PoD related domain state. */
+void p2m_pod_get_mem_target(const struct domain *d, xen_pod_target_t *target);
+
+/* Check whether PoD is (still) active in a domain. */
+bool p2m_pod_active(const struct domain *d);
+
 /* Scan pod cache when offline/broken page triggered */
 int
 p2m_pod_offline_or_broken_hit(struct page_info *p);
@@ -669,11 +675,6 @@ p2m_pod_offline_or_broken_hit(struct pag
 void
 p2m_pod_offline_or_broken_replace(struct page_info *p);
 
-static inline long p2m_pod_entry_count(const struct p2m_domain *p2m)
-{
-    return p2m->pod.entry_count;
-}
-
 void p2m_pod_init(struct p2m_domain *p2m);
 
 #else
@@ -689,6 +690,11 @@ static inline int p2m_pod_empty_cache(st
     return 0;
 }
 
+static inline bool p2m_pod_active(const struct domain *d)
+{
+    return false;
+}
+
 static inline int p2m_pod_offline_or_broken_hit(struct page_info *p)
 {
     return 0;
@@ -699,11 +705,6 @@ static inline void p2m_pod_offline_or_br
     ASSERT_UNREACHABLE();
 }
 
-static inline long p2m_pod_entry_count(const struct p2m_domain *p2m)
-{
-    return 0;
-}
-
 static inline void p2m_pod_init(struct p2m_domain *p2m) {}
 
 #endif



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:21:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:21:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235924.409227 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNfj-0003Nq-6e; Wed, 01 Dec 2021 11:21:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235924.409227; Wed, 01 Dec 2021 11:21:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNfj-0003Nj-3j; Wed, 01 Dec 2021 11:21:11 +0000
Received: by outflank-mailman (input) for mailman id 235924;
 Wed, 01 Dec 2021 11:21:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNfh-0002lJ-79
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:21:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c5d0028a-5298-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:21:05 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-uTpvIZzHMGSgBT8luWXX7g-1; Wed, 01 Dec 2021 12:21:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:21:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:21:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:100::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Wed, 1 Dec 2021 11:21:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5d0028a-5298-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638357664;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2biUIJpAqJ0eyN1ne/XaQldxN2vM6fcaq9kRJNDcVj8=;
	b=kmRqSOmosVJCu0w3PILVULsYzkUymgNDjkVHiXQx74/jAB6VZUzvxsCITb3kPqZyEL7iM5
	VMeGBU6/orXqwnBzcDDZfJHxliLtJIYJFn5G3TWyhBTiiLLonwckX1jQIWTHSOTm6R7iKc
	OJ1uqs95yvfOHO4oJCq1QiGXHfrv/II=
X-MC-Unique: uTpvIZzHMGSgBT8luWXX7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZgPRG/PTYx512xwVOnUvSJSr1jOQV9oFPtG0qyF3LcDp6+rhSEXmHSRSCxuELW+JBZIKu2NNJLbzKXDB31tklRpFErxJYbKrc5yqBP9smDQ5T8F+zIZskN7QPTDVhej35dYhDzpRVNJKVEbpyJjUnSg1TBe+mfKmqFiMt3TWiH1bMRmNe9UxHhKuaHJ74bkU+RI3qE6Jh/ZChpOr8zrh4hdDYnNUAAZHoPIVnzhljqg4aCGKuHDwR1tKBIDD76NYRRx7zxEhWLwCpPPxiVzrFw7PAxUHiAsQi0h8V42f2ZytpF/fIwjcy/LOzUCpSJe1EaP8WTz6SrWGlrh7q9xMCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2biUIJpAqJ0eyN1ne/XaQldxN2vM6fcaq9kRJNDcVj8=;
 b=S/fM81DCcv4tL6hY2UdVbXqxB4sWhiX/kn6fwUCypjJWF93Zix5iL05DECDZUXKTBYjUYqZu+pWZ6LXvvrUbBMc9HBy/3JzNy005EJN6Siv4GBvT/wjoEWNZDYqCRdPfyisO/Rp3tS3/Rk/DzaqbB/DNnqHrKyEeXJiyJRcrBbZY3x/KO0PNJlV6D9b0N1a3+dEu/3VPSDkvLEAi/5mHgXEQ1/mRhdL+3ezUVVEWfbXP1+VN+WzKuOVLB5pN0nnHS/rq7wRdjhc7JHPO8UGYIxTPCRZ7NeY/NJ9yLnh+1g+SugqQTAjHurDM4P7H60nguAadbHrOGCiObqz35pJooA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <33b3a7a2-3b1e-d24d-5359-c5fd3294d847@suse.com>
Date: Wed, 1 Dec 2021 12:21:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
In-Reply-To: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0023.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac7186f9-94fa-498e-6175-08d9b4bca8d9
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393675EBF88A2C1BA492D53CB3689@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:419;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+ayEi9LNnXfpkJFBOvfQSPsk7YXTgl+Ykfj3OI7aIG1RmYlTuiC96imhYoV/6/DnMc3rsifJmeTMDB0iDs/I4sdkBasE8nncUUMhVJr4EWTInBJniGXvzulxTgzRRwVsscx6TDfyPbB+y3PLTvMY0bi6Do9E5pSin0EVnTW1xnkYryfg2N9L27Cgx/MAfi4zA6qlHzPu3oXklGWOZNiJak//SgQelZthvwj31lNrFn/GPsxC05MW0GzXyeiZIyrirUlUT/GG01JSpkBaxI5AV85F8FfRlumSo5WisW0LguW3FucLk+90R0Ey9NtUN2GaD0/UhJKcHFLz9PwAxzi2sFxsXeebVf7jteD9itvl8HbxA+zuloPsWotQbQ/xQNmyTydXozn12yQmCBpdakWPQmMGKbmD6VDaeB05VtKk73JgSA08PdnGs3R7ZTNwIhTIOAkFA5roeYIs7wb+3MJ/SmgHO2cd7aHB3MUkN5GCpFY3RMdOoAy8U3rM9wXzeELIXV6dax+gEEtvY+cCSSrz2g3JbYTjowEflDcI/CiQmWbCBbL9NKygJNjlSUs/vP0eorh+sz6QnK59PNHYX2n+/u1h1qxMWH3R3NovU+wzfFR7LYMhG6p4876ugPGs33nD5nkgEfVytJEbXavJSBw1oQkUluHWGa7F7i6X7G0P58b+BU/FZXoT1ifYt+5qT0GG/+bQ7HBcz5zUkbBdF7lYwYTY7JD3PeQMQ5ahsh8cuuw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2616005)(36756003)(6486002)(4326008)(86362001)(5660300002)(6916009)(508600001)(16576012)(54906003)(66556008)(66476007)(31696002)(83380400001)(26005)(66946007)(31686004)(2906002)(956004)(186003)(38100700002)(8676002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bSszRENIVlVzMlBKMVFXM0oxM1BnK1Vsc2Y3WFdoVVg0NExhVStXdW1lQ3FH?=
 =?utf-8?B?ZDl0eEhCY1VIbk56RGVZbzVRYjVKczJ5M1ppdnNveURFdGthYlhCbXJHYjQ4?=
 =?utf-8?B?MFpVWkxRdEo0UXRBWjhUOWNHeTlwZGpBNGxWNUM0eTlmbXZqTGlvWXFVL25a?=
 =?utf-8?B?RXJrYUJZUktOT1ZYL1dUblEwZzBRZ3c5bllEb01OejQ2OVdTdzhwVkpqaUlp?=
 =?utf-8?B?TW55T1JKejBzSkszOVZjZXlKQ1NoQlc4cll1QWJFa1g4ZU1Ncm1WdGlFUXZR?=
 =?utf-8?B?QjVPSGxFNURUWjQvdG5uQlpuTzJHdWZOVlV6MGJtZDljSTE0bXJkY1N5TnRn?=
 =?utf-8?B?NXhaMm5TM1hWQXZ1T25jNUJqZE1VTkpJbi82T3YrS0NYN09aZGpUN3l5T2NE?=
 =?utf-8?B?azkzb2ZNeTVnSFc4cDd4SEJOelBISGdxVUN5cjd3dVk3ZHlMTEhoQjM0V1NU?=
 =?utf-8?B?eTlsUlhkaU9zMHd5Vkt3MSswbXZDSzZQWHVSN09BbnNRODJYU0M3RlV1cGV5?=
 =?utf-8?B?QmNyU3BvbDh2Ti9LU2V1OHd4S3dKM0owV0JwQWNFWkYrZVI2Yi9aM0VDY2w4?=
 =?utf-8?B?ZE9TVTNCMmVIODFYSk9IdmhIN2VibHU4SFJFNmVkSTQvd2FtOVBoKzE4VERu?=
 =?utf-8?B?d3d2RjFCREFMNjdOMlVaWVZZeFhwcVZMVW91USs0NWsxRlZsdFlFYUsydDFX?=
 =?utf-8?B?c2Y2OXhLT1pnTGZYOU9GYkRSRmFxNU9BWVoweFNuV3k1cU9RR0FiNDMvMFc5?=
 =?utf-8?B?bVBBbExsNS9PU1pLS01DUnB5VWdIS0NGQ1ZOVFROOWtQc1JHL2ZOdTBKYW95?=
 =?utf-8?B?K3NSOU95dVNLYjJpWnpKMGkvd3JPeXg4U1RmZGdCVUIyMk0wdlhYVCtyTDU3?=
 =?utf-8?B?QVk4czQxZ3llSW5jUXNvdS9GTGx3M0lZbVFlTjV5QThTc2xsQW9teE1KWGsr?=
 =?utf-8?B?TXUyT0pHWGxxd0pERTNHK3ovc0FTbzNxeGtlSFd0UkNhOUliWWh5SWVPSlFK?=
 =?utf-8?B?MFZWZndjNXlWa0tkdjY2N2NtVCsrd3BrN0VBa0V3RUpRb25Bdm1tR1VWOGxF?=
 =?utf-8?B?TUlPN2lzbUU0a2MxK09VdkhvMlBBbE9uWjVDTzdQMG1ZTnYrQ0RibjVGK3RT?=
 =?utf-8?B?aUJ0blBEN1ZWQ1dXYUMrNE5QdVgwUzRaaGxXZGU3UDVGWHA4NHg1Ni9sSUNs?=
 =?utf-8?B?K2Ftd3lyeG1HVXd6dUhzemVSbWJJVzZZeWJsVCs5bUx5Smo1akFLZ1JFdmhF?=
 =?utf-8?B?azdBaWpXdHFWV01PMEdoWksycXI3azFvTUlPNmFmSUVGMUJYZnZORXQ1R1do?=
 =?utf-8?B?bjl2V2FPWkluSDh3QVVyS0RFS0RmclVvNThvQkxQYk9YQ0RyU1VsVXhHVkkw?=
 =?utf-8?B?WUdiYjJ4V0swckNXS2l2M2poU0hHZ2FrUEp3ZkdWUmpLOXRNT0FhNFY2NmE2?=
 =?utf-8?B?WTNIOWVwMlpvM2M4R2MwZFV4dGRzSEx0cWtyTE9FOUU1SXRSZEdNT1FGUE9n?=
 =?utf-8?B?dFpUeWlQSUp2VTdmdjlwdURkMGNtTTJWNldvTzhaRm5SRUpnUndHVlZNQkZV?=
 =?utf-8?B?SG9wRzAzZzEzc3ppN24xNTZ3ZHFFdDRTVTZpS0RWZjJXeUFkM2tWRHR6bmo1?=
 =?utf-8?B?VjZibFFDSkpRYXNxdVEvYk1lWWRSOHhORGViZC9OWGRVcUpJNEVlakVsM0Zu?=
 =?utf-8?B?cy9Qb0QvSytFODZ6bGY2ZlgyaEZhZHAzNTBUZXZmWHArdXhWNndCZCtTMmZO?=
 =?utf-8?B?a2g4R1dLa2dqTi9BOWloeEZFdjZNRjVDRkJyTS9va3pPUTV1OVV2bkladFhr?=
 =?utf-8?B?bTZwRGlzYTliVmNTTnVDenZFU2xCQWIyblpTdUdBbElLN0tKeWZsNHdKVWRT?=
 =?utf-8?B?dWMzVzFlaFJQS0Rxa3B4cU1qazZJWjI0TzRSVFJFaGlpUEZYcVBwWU1YU3dO?=
 =?utf-8?B?a3FvTEVGaXpobHF0VFdCRW1EY0g4UHh2RFMyQnlnQmZIV2pML1VVRFh3aWdL?=
 =?utf-8?B?alZxRWhyd0srcmV5KzNOOFFvZURFTjVWNHAxWEF6akdKV0FLbWZ2ZW9BSUlZ?=
 =?utf-8?B?aS8zR3FLQzJXSmwzUHhKcTVDaU5SRzFvMWhkSHBIcURmVVNLb0N6YitqVjdO?=
 =?utf-8?B?ZXd5TGU4Y3k0VmxZaUpEODhRcW1OdHhmT1ZZODdIZHVVY2JwVFoxanBSV25Q?=
 =?utf-8?Q?hde0dpq1aurWDpLF4vrc/E8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac7186f9-94fa-498e-6175-08d9b4bca8d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:21:03.0285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OgavDlWeah3ipLxGls/UuPGkx1OXN95D01P6AT4ltpJXxIw+hG9NA3CsDEvlkRqnLPygcHM2JrbyoN4f2vfYcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

Do away with the "pod_target_out_unlock" label. In particular by folding
if()-s, the logic can be expressed with less code (and no goto-s) this
way.

Limit scope of "p2m", constifying it at the same time.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Re-base over new earlier patch.

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4788,23 +4788,17 @@ long arch_memory_op(unsigned long cmd, X
         if ( !is_hvm_domain(d) )
             rc = -EINVAL;
         else if ( cmd == XENMEM_set_pod_target )
-            rc = xsm_set_pod_target(XSM_PRIV, d);
-        else
-            rc = xsm_get_pod_target(XSM_PRIV, d);
-
-        if ( rc != 0 )
-            goto pod_target_out_unlock;
-
-        if ( cmd == XENMEM_set_pod_target )
         {
-            if ( target.target_pages > d->max_pages )
-            {
+            rc = xsm_set_pod_target(XSM_PRIV, d);
+            if ( rc )
+                ASSERT(rc < 0);
+            else if ( target.target_pages > d->max_pages )
                 rc = -EINVAL;
-                goto pod_target_out_unlock;
-            }
-
-            rc = p2m_pod_set_mem_target(d, target.target_pages);
+            else
+                rc = p2m_pod_set_mem_target(d, target.target_pages);
         }
+        else
+            rc = xsm_get_pod_target(XSM_PRIV, d);
 
         if ( rc == -ERESTART )
         {
@@ -4816,13 +4810,9 @@ long arch_memory_op(unsigned long cmd, X
             p2m_pod_get_mem_target(d, &target);
 
             if ( __copy_to_guest(arg, &target, 1) )
-            {
-                rc= -EFAULT;
-                goto pod_target_out_unlock;
-            }
+                rc = -EFAULT;
         }
 
-    pod_target_out_unlock:
         rcu_unlock_domain(d);
         return rc;
     }



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:22:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:22:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235931.409239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNhF-00041x-Hw; Wed, 01 Dec 2021 11:22:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235931.409239; Wed, 01 Dec 2021 11:22:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNhF-00041q-F2; Wed, 01 Dec 2021 11:22:45 +0000
Received: by outflank-mailman (input) for mailman id 235931;
 Wed, 01 Dec 2021 11:22:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msNhE-00041i-2p
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:22:44 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72f30715-5297-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:11:38 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34696)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msNh4-000mIK-8b (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 11:22:34 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 68ADB1FDDA;
 Wed,  1 Dec 2021 11:22:34 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72f30715-5297-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a69e518e-b2d8-5177-8b8b-359a1f903364@srcf.net>
Date: Wed, 1 Dec 2021 11:22:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] x86/mm: don't open-code p2m_is_pod()
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Kevin Tian <kevin.tian@intel.com>,
 Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <a1110809-b4fb-c53e-5f46-dc7628165634@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <a1110809-b4fb-c53e-5f46-dc7628165634@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 11:01, Jan Beulich wrote:
> Replace all comparisons against p2m_populate_on_demand (outside of
> switch() statements) with the designated predicate.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:23:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:23:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235935.409250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNiB-0004cq-SY; Wed, 01 Dec 2021 11:23:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235935.409250; Wed, 01 Dec 2021 11:23:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNiB-0004cj-O6; Wed, 01 Dec 2021 11:23:43 +0000
Received: by outflank-mailman (input) for mailman id 235935;
 Wed, 01 Dec 2021 11:23:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msNi9-0004ap-ML
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:23:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 22811267-5299-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:23:41 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-OKr8UtJ9Ov-iTLLRsZduhg-1; Wed, 01 Dec 2021 12:23:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Wed, 1 Dec
 2021 11:23:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:23:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:20b:488::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Wed, 1 Dec 2021 11:23:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22811267-5299-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638357820;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F2nhRI7VpQ04wiK8ysKm/PMNnbw1RJy4/s9ua0AMl50=;
	b=D/M3aiop/b4+C2SuLv/j9YtOwT5iGyrV1OXNNnyTf/e42g/uahcBr7aQJX9fA9xhLbIbl3
	sFFm89hPsi1bvqqZzezQxwaMKHMhm2zfOH0Riic58KYkwtCj3lM1R62PT1frOTvRx//G+k
	FMfFofWKiMPEjkUcERSqF43kU4k9EYA=
X-MC-Unique: OKr8UtJ9Ov-iTLLRsZduhg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cAjxSt3flwwMUzMEnXTmHJ5S1M7VFdjHYdQJxd8QlcuEjtHAUF4p3dlpWr37ODPiF26XYIiomKXAzA3UgKPhSGtO2lcNkP/+HJNK4LxR+7UcspUZw/7H3RJ95D0734CUHFNXNLU6Qh/Blrh+1yKa+ibpZApXGGBtnhHca9gdhK3sJOXgSrWAYNmnncvB6Vl9ajUqKI/pWIWmx8Y5wdp1BhkV0FBHJSlBnKStDoztAe4cJ2AuLioGXQMO8tt9nZmMprSJxPVrDdW235v7kQRAsUhLCxvCVqjcxArwQeWblh7d4xNnuC0CKBrLTj2I0qBPCFwyv2Mqu50+mwF9ArMcVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F2nhRI7VpQ04wiK8ysKm/PMNnbw1RJy4/s9ua0AMl50=;
 b=e4jEuG8AxeGQtwRgfHhPS7RVXbfnFDzhIiMHawRnhWZc9YyQHbSb0eIFvYqbvYIs63HDc9vZj/TyP7p+UGkjsijJ8qOpuc69e+bUzWGrSB3Z9k87lIoL9tEMCCq3ukMUdry2c1iLN/KY4g/oOXJjGkE9EJoD1bTv5X0GESinCS30xZFUVft9KGRWlNMnx50+4rZy31jlUcstoNkT6vC/bsrcH8plalvOeEuOLvyTEOoG+Vfsib5bqgKB/wwRgUixwwFXb64/J0sabkT4/6DoXeQiSz0ax2X8nlo0wA5oQZdm1CYsnkTLYCDUcqy4Zp2DGEVnkvKw+bxhZ5MeyuSPXg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <55db927d-b3a6-6d0c-00e6-8607cc2c178a@suse.com>
Date: Wed, 1 Dec 2021 12:23:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 0/2] xsm: Further fixes
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Daniel Smith <dpsmith@apertussolutions.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211201111555.16408-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0017.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 50346310-c1a3-4f49-d62a-08d9b4bd04f1
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29593142C67F4C582EFA6595B3689@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1360;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fqf7u03RY8bxMII+qlvVyULSJKR5OMrpdrGz/W8k/DpUj/Fw5E6+Ol9b2dcKK7QP9JrNBbUzMTNsWMqt8o5Pj9cl2S5JPTGLJURAiHcb7CMXa3fs5+nySCV3rrJ6sUl7bvy37Z3VrLs0fv7HZDN9SMX7JbSaddqvB5hNtu7xsvIJXm9vxdU461P5ANmH3EN5U5Cs6INxSWB64kUBGqSo9udNxB2jQJvLAGg6c7GNV7t52yCBMvqa8+IZiBGCFHjNC68aNBkhPfn4IuEAvPkBna9qoprKWyDaibcUf/i/9Z6vTuwXWZ34heBHATAE/roWpfofJQCfKwU5mEAHbaI3MzAcQvvD5w/LNZlRg0uRPRDohSL/FTi0UU9wnBTnzle1kYUyVemW5uS105FVWCf79k9LF0FtNu7x1T44vXuLvPgHbM4JsRBsJGkd00/rlEnppkBUMdVXb35/lUHOP9PUcl9jlLsH2iadSU7K+heaAUF8ADbYyXRrwhKT6afU+EvtVs2QQP6tpeIBwmYtSaGIWuTq/v+O69cDYmCzuut3G0hyDpb4f2/z7fj1X70JB54kyCFXcO6GFglRc0gfdApzAhDkRsPN3ekJ9Kg5zMAXR2N4/Nkr5yxMRBgsLwvIkIwP5wsHt4FF3YeDzhYXbMvSiUPEKsfd8pB/yznVfLhNCMXtRo9c/OKlWzo20tJFdQLSDewkgb3jF3/SF9dHyhAp5mI6AKj6mbuV1fS5UlZzA7I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4326008)(54906003)(508600001)(86362001)(8676002)(8936002)(558084003)(316002)(16576012)(36756003)(6486002)(53546011)(2906002)(6916009)(5660300002)(31696002)(26005)(186003)(31686004)(956004)(2616005)(66946007)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qzgvb1Vyenl1VmdxcHJJRTdadVNieXEvSjEwUStoM0s3RVJLSE1tNzNmNFJ6?=
 =?utf-8?B?TUxzeFh4S0cyQndQZ2pjNVdiQjFIeGdoaGdLVjZXbGIyU3d0M2Q5aWljQ09P?=
 =?utf-8?B?VWJQTFV2cjFNSzJ3NTN2TGVqQkY0dDYvREFjYmsxNEFHUU8rc3JLRmFvZlh5?=
 =?utf-8?B?WlZ5b0RzcnRocjlqc2xFREIvaUtFL3dQUnk0NXFtQkhyanM5cWpFTmc0aTNs?=
 =?utf-8?B?eTJ2cVpEcmJXTnFRU0Y0MTY3TDBnL3ZpTkxEdGhUdEJOU2NXbWp1Qnprcnla?=
 =?utf-8?B?dFpzNTNkSStTaFl6eHBWNjVnYndJYzJZMW5QbDVjYTRCOGJNUjFGS1E3RTRN?=
 =?utf-8?B?cmpDTDczWkhJYXpQcEhlS25VWDlJYW1TRXlmZHdkZDh4RGJIcnYvdy9aZGFS?=
 =?utf-8?B?S3lCc291MUg2K2I2WEQ0QlI4RWtDWHhLcDUydDFMM3E1dno1a1A5OVNoN29M?=
 =?utf-8?B?SWpVWTZDa3NHa0JDYk1UYXlVQ0lUVTF0TW5vUXlKTWFJbkhJQ0tkd1RjREZQ?=
 =?utf-8?B?NEZEZFJMVko2dmFncE9KRmQvSFZCbDI4QlM3RTh6Y2lHWUw4NHNxK3pqZ3NY?=
 =?utf-8?B?THY2YnF1dC8rU0V0TDZzdWQ0NGxYL3UyZGNHcEJCWC9BVFh5bmVoNS82K0M4?=
 =?utf-8?B?WWo5U00ra1dYdENWUnRVWU5tZFlRbEtleWM5dk13d010M0JlNUZvK1VEdlJs?=
 =?utf-8?B?d1dKdjkvVFVrSnpXWkNjeXhrbDJSTWRLK2lBVUNreDlqRjYweDNUUWc3bWNU?=
 =?utf-8?B?OE9WZnlpR0dEOCsyMXhQNEFIeWczVmZ0SHMrUDdFNkc4UTRlQy9HSDZCOVgx?=
 =?utf-8?B?SjIwZTYySWZQMHBwRzBoajNOeWVJaWpXYkg0WXpRNWc0bWlKTGhxZHZBcHRD?=
 =?utf-8?B?WHhlOW84Wkc4R2dvQnhHLy9CU1d2L21taGY2ZUFPYm5MdDEwMFhqckF2cGJ0?=
 =?utf-8?B?Q0UvUDhDUmlzQzltZUxUVUlwNUhSb3FhZW5xR1k3VDNBUzBITkJvTXlxMzd1?=
 =?utf-8?B?MWpvS3lkRVU3Zkt2MHlIUlk2UEVLNjhRam5sbHpYWXl3VmxZc3ZQendCVFM4?=
 =?utf-8?B?TGErL2tQNGpuemdWalpUVm9KUzVHdi9zQ2RQOVFPMlk2UjR0OFMrRElqVHV1?=
 =?utf-8?B?ckNCVGZqek0valdDUGdrSTFib01PZ1FyVXZZalc5VFk2UENwMmpzMXNFNkkr?=
 =?utf-8?B?SHpNRDdHaFVoVDByZ3FXdUFHb2xjOUc2dnNSNTgvdVExanhBTjduZjFxUG1w?=
 =?utf-8?B?L2Zwd250WVAzT3N4VzhlZ1cwVmZvbkVlNGlweUFtU2ZON0hQaFpPYmEyaXVZ?=
 =?utf-8?B?MVBUNjV0VnBjVlM3ZEdldWxEeW1DbzRZZTZZLzdQOUJtanc1blptLzg1SFMz?=
 =?utf-8?B?QU84c2FxV1BNaHozL2kva1BLRkpKa1dNQjlxemZRS2w3TGlLYWhtTFBTTWtI?=
 =?utf-8?B?bnROYkJvb3lBTElLNnVhNGV6RDNaVW1nL3ppTXUzYnNwb1FMdTlmWXozUVpV?=
 =?utf-8?B?SHVsNTFJNGlQUjJVRnFYdlMyNE9sbUplVyt3b2tGa2lGaDlQSUdaNG1HZ1Jx?=
 =?utf-8?B?MkFzazM5RHFCTFVqaVhzSXo5dndQZnpPOHdDQ01mNW9mdis4RHJ1ZkpoR2tu?=
 =?utf-8?B?VUQ0TjE1ejEzeWJ6cmpuejdqZzkyL1dFdDV1cktERWdFbC9wT2ZlRHhPejlO?=
 =?utf-8?B?a0RlVkt2S3M5SkkxN3pNc1VhNUI3QlZiS054ZzJsVVQybW8yUnU1NVkxRThY?=
 =?utf-8?B?Q0lMVjlBRXZoVEFpQUVGMmI5LzBKNmt3WnhJQlBEaDFXMzZtdXROa0FTWncv?=
 =?utf-8?B?QmUxM2M1WmVNREJnSUNxbU9WUWRmSUJjNU1Nd1dSanNxRUhjUXZTTWVsODZt?=
 =?utf-8?B?N2d3N3BabjVDdVVGM09qRzZLS2g3UFdtY0doa1IrcWdOSlhJMzEyZ3NXMlpK?=
 =?utf-8?B?QVF5MC9kemRlUzNiRkVCeXpaYWNDdE9iMHFtTlA2VXRNdU03WUdxUXhmSFdt?=
 =?utf-8?B?K3YvMzgvdy9kWFJNU3hsc1E4Y3JXR0VVbnFiWENUVHFoOWNieGxWa280RXEy?=
 =?utf-8?B?YmROQ1p5aUw5WEtVODdCT0dRelRUbFZyUjc3Tnc0WHZGdGo4am5DSUNQSzZG?=
 =?utf-8?B?eDZNY0hTQ1hJWlNNSnVmdEwwaFFiSktGUUN3QjkyK3VYM01zNU5xeE5xTjZ4?=
 =?utf-8?Q?8L/YKL1zaJBoN0GEmmnjYHk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50346310-c1a3-4f49-d62a-08d9b4bd04f1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:23:37.5881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Gygs1C2jZ8WdBBsY3KauvCMJ98xgNOvtRKLt3FEkVjwN+DSVNkCxxa+QVZ5TmnbIyNTd7/hSA9PAMOoQ2f9kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

On 01.12.2021 12:15, Andrew Cooper wrote:
> Andrew Cooper (2):
>   xsm: Switch xsm_ops to __alt_call_maybe_initdata
>   xsm: Drop extern of non-existent variable

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:27:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:27:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235941.409261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNln-0005R1-D3; Wed, 01 Dec 2021 11:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235941.409261; Wed, 01 Dec 2021 11:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msNln-0005Qu-9v; Wed, 01 Dec 2021 11:27:27 +0000
Received: by outflank-mailman (input) for mailman id 235941;
 Wed, 01 Dec 2021 11:27:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msNlm-0005Qo-9F
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:27:26 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1bee270e-5298-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 12:16:20 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40142)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msNlk-000sCi-nZ (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 11:27:24 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C29B51FAE9;
 Wed,  1 Dec 2021 11:27:23 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bee270e-5298-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5585cbf5-6248-ca6f-8b9e-764dbb08be43@srcf.net>
Date: Wed, 1 Dec 2021 11:27:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/2] x86/PoD: move increment of entry count
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <d92ec1b7-6cde-7efc-2c6a-3dc3696b957f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <d92ec1b7-6cde-7efc-2c6a-3dc3696b957f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 11:02, Jan Beulich wrote:
> When not holding the PoD lock across the entire region covering P2M
> update and stats update, the entry count should indicate too large a
> value in preference to a too small one, to avoid functions bailing early
> when they find the count is zero. Hence increments should happen ahead
> of P2M updates, while decrements should happen only after. Deal with the
> one place where this hasn't been the case yet.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
>          }
>      }
>  
> +    pod_lock(p2m);
> +    p2m->pod.entry_count += (1UL << order) - pod_count;
> +    pod_unlock(p2m);
> +
>      /* Now, actually do the two-way mapping */
>      rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
>                         p2m_populate_on_demand, p2m->default_access);
>      if ( rc == 0 )
> -    {
> -        pod_lock(p2m);
> -        p2m->pod.entry_count += 1UL << order;
> -        p2m->pod.entry_count -= pod_count;
> -        BUG_ON(p2m->pod.entry_count < 0);
> -        pod_unlock(p2m);
> -
>          ioreq_request_mapcache_invalidate(d);
> -    }
>      else if ( order )
>      {
>          /*
> @@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
>                 d, gfn_l, order, rc);
>          domain_crash(d);
>      }
> +    else if ( !pod_count )
> +    {
> +        pod_lock(p2m);
> +        BUG_ON(!p2m->pod.entry_count);
> +        --p2m->pod.entry_count;
> +        pod_unlock(p2m);
> +    }
>  
>  out:
>      gfn_unlock(p2m, gfn, order);

This email appears to contain the same patch twice, presumably split at
this point.

Which one should be reviewed?

~Andrew

> When not holding the PoD lock across the entire region covering P2M
> update and stats update, the entry count should indicate too large a
> value in preference to a too small one, to avoid functions bailing early
> when they find the count is zero. Hence increments should happen ahead
> of P2M updates, while decrements should happen only after. Deal with the
> one place where this hasn't been the case yet.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
>          }
>      }
>  
> +    pod_lock(p2m);
> +    p2m->pod.entry_count += (1UL << order) - pod_count;
> +    pod_unlock(p2m);
> +
>      /* Now, actually do the two-way mapping */
>      rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
>                         p2m_populate_on_demand, p2m->default_access);
>      if ( rc == 0 )
> -    {
> -        pod_lock(p2m);
> -        p2m->pod.entry_count += 1UL << order;
> -        p2m->pod.entry_count -= pod_count;
> -        BUG_ON(p2m->pod.entry_count < 0);
> -        pod_unlock(p2m);
> -
>          ioreq_request_mapcache_invalidate(d);
> -    }
>      else if ( order )
>      {
>          /*
> @@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
>                 d, gfn_l, order, rc);
>          domain_crash(d);
>      }
> +    else if ( !pod_count )
> +    {
> +        pod_lock(p2m);
> +        BUG_ON(!p2m->pod.entry_count);
> +        --p2m->pod.entry_count;
> +        pod_unlock(p2m);
> +    }
>  
>  out:
>      gfn_unlock(p2m, gfn, order);
>
>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:45:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:45:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235951.409271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO36-0007vN-Vg; Wed, 01 Dec 2021 11:45:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235951.409271; Wed, 01 Dec 2021 11:45:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO36-0007vG-Si; Wed, 01 Dec 2021 11:45:20 +0000
Received: by outflank-mailman (input) for mailman id 235951;
 Wed, 01 Dec 2021 11:45:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msO35-0007vA-MM
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:45:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 280c1f11-529c-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:45:18 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-mDQSilL8Oqm10oZk_3Bt5w-1; Wed, 01 Dec 2021 12:45:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 11:45:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:45:14 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P192CA0089.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 11:45:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 280c1f11-529c-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638359118;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LkIqO0RRzt/L79xxcX5H+p/ynLuWRbwBr/UR9tkB0jc=;
	b=l1RRu6oGF6z95ARfCPFR+x4TxSYbe07MAjBmY53WdXDJXygAEQLSZq9XFcdS4tGSAblwme
	zobXrYermxSpLBQv40nik7mbaVktRXvN+GFlA7TqN/p6/w9GwAXh+wxjWJhNPYnlbouq8f
	OhnS+bDW5A+7HCz0CtUpM9fy7dOnlzg=
X-MC-Unique: mDQSilL8Oqm10oZk_3Bt5w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HCkxJcOgo22WD8K9dSfifIEBuNMYDhiPh8wg7IOpNTknmXC5b6vttTx+B3hU7+wWfvMP8UUWJg8zWfN5ztc/jOG3OvprQbyaozXtm3WiMDdAG5Tn0Si48HT9hTsP6HppoXhHs/wm7v1K7hwfRHp1BD6mTRgsqGfg6yM86oVHjoRlHu25/VFF9OH2VOTZKyi/zhYxwkgPjedyTlmZLsYdlmBMdCbX0MU1PkmNiIAql7NyHF2K+teEyGwex1AvvxdgQVKOld1t9IbIYiqVezbKpD5NXNhx4Qk3zm8J7UQ06dplqQolkE8cOQl2I53YaKpYrLBYZafxrqrcfs5/2hTBOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j4IVWEtRk6K7m+zrtbeKk+dr4fXqtN0FFcTY7TgJ9+w=;
 b=bqwMwrez+nWoEEIOxeNhi1BuZZw7iyS7d53SJcfKEAA2TUi4kR9y89sn/1ncvcb5KXpUXCSFk6mIxp7KqyytUWrZEl+ABZJMxZFrOyoRCqq+WX2zJ9JlAxf9HKHy6OsAlZEH1hX/h4jC7Bo/WOH8bRGROhHZoDpkuDr33lQ6NFBw6mcWKxJEh0Ap3rvH0KFvUNAidgj7rmpGloVg/4pNlx1vek1PwfATkM3fdiJR4kZPB2LnEEpmVElITkYWfwqB5nEijl9BHptroJU32alwJoNey4hz2cmVyMOEFdjL+NBi6i90LPskiS/8yV//1Xev7lqB1WKVoeDJ4t40rLUerQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
Date: Wed, 1 Dec 2021 12:45:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
 <YadPLZqfN2pu5SeG@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YadPLZqfN2pu5SeG@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P192CA0089.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc227b77-7f21-4fe3-37a5-08d9b4c009ec
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6304963330C643D17E0985FDB3689@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DFBFJ2ed4iRGgb3wKWicMQKQ7DtcoI23pWMw2/K5ubdTZUqm5SOYC3mkB4pKpkbh0xL+oYQMJ+sM5iQu6QagjkUHVtZKTkz8mMV9n6p6m09JK9o2RjOWRqvYZg2Bw1y239YiM+a2Lt1VWiFEIY2UXxm+bB00nbJ95o6A9fXtwtWYW5Mxv0j39yJTn8Xc+ihsnBh9e86krbq1J6YfCA19wDpPi1ZWLTikRecedK/UpO5cazLodFYYHOmpOHR0uH4TdeJ1YxfQuDIsiLt3iSddwJVNLHlJvViLvcS6EBwQZ4Mfe+prJnmVRCQhu1qP5QTChrn0d2xIQcPMartLRtBQu6f3qH9GizzSAhr/No6VBDSFdL4wIRBg7zQpj/BiFNidVztIpBhJeMeunIRtOimgSSqRxYoNWRvxvAKCeJs8BdFSz7NRlspSfyMylVI+5oHDfuiIS8Eqam+Q7XPJTrFlbmZXXXiy++GQALa2kTw/Bq0Ey3DL1O0spWBA5wfavoRO4D/K837oxLZDXCsmdPReLp5f2EIrpdkpyclYdRDHDGXeXEXLMSlLT05Ke3f681GonwqMWZm31wc6tEdTrvvQ9SBo7DeUtsQyckW9tYSyzX+MmQt8NkgML7Abh+Yyw2t6KnDKZQ4rvrFAMV8LjqPM3hTHnOFuq3oV6ttaHLgeE8cVhZ+IBj9F0aSDhvggezTYCOdhd6g+IE1mue5g0JCK60cGKqmqg1BYR6XZh/QG2Is=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(36756003)(38100700002)(31696002)(186003)(26005)(8676002)(2906002)(5660300002)(66476007)(53546011)(83380400001)(54906003)(956004)(2616005)(31686004)(6916009)(66946007)(66556008)(316002)(86362001)(16576012)(6486002)(8936002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UVxjZN/3ikODAvF6R1NC0nj57ctyL9KWJ685aorQE2IIxT1U41ucbgK9kIib?=
 =?us-ascii?Q?u8S0eLENdjAV6wNoE+/p6HWWZPu2+/2Fj1SBw+D3fBrSckMTnrQ2i/u4hVhU?=
 =?us-ascii?Q?RecYFsGOS4ba8LuweybAMATkOHkXhhh50KnvOznOPkXx9hAn0/SSYZfsV8PL?=
 =?us-ascii?Q?qCUKzLaGGl0fA9CML7XYyJqOFhEyITOcOzYwjAXwltMArXqsWr2p56Y/Qt9z?=
 =?us-ascii?Q?ZdyZiR2KnartHWYsWTUNOl8oNcmIjhe9dJFMYtddUV+jpUPul0RqGyYqcF6+?=
 =?us-ascii?Q?BFZE/tK8E3i1FaOLpUpDL0iudL6YwuIbcGEaHZQTpZVcuGktPcAxZWMUVf54?=
 =?us-ascii?Q?Y/7LMMnoAwMSU7xWad+CwyLWcjY6H5RCwbRYYO9GRz2bNELzxAp8FZ+ojGzV?=
 =?us-ascii?Q?MqG5xbfAQG7gs8L1m9qWxp8SAvD5uUEyw1HTxdltXsLV2ekFfU99fjaHgif9?=
 =?us-ascii?Q?7EQLINyYmBWr4YCuvv8fVJg6IF8FZ1qW9Ivi/jaA24jwr7JdatPCI7sGWfDG?=
 =?us-ascii?Q?ObQgpHIZ30RQMV1qojZxY8W16WSMKuA5xCzyVGhCSeA9B1jkXSLBW4ibc/xY?=
 =?us-ascii?Q?cZJ/XKATaaIUmmrwlS5IlsyuFTY1r7DdkTrtuSooW2tLqnyJkuMAB/jZeMd8?=
 =?us-ascii?Q?yxpwKOkGYjtbU9ujhfomKEzdw+ltPMYCtmt/pgHmA7c4uKu8XB9LfsKxp5zv?=
 =?us-ascii?Q?giiorTSSt8/ERGigiXtS1p+2bKQfUL7ySEbGoQa7pvoBYTXknJZ+H5GWyq61?=
 =?us-ascii?Q?bl9jQvS4ZQOZ23515/E9eWzCcKC4Po4Sc+KPgEA/BLAAD98AG4wHry/F3w2A?=
 =?us-ascii?Q?otYz9qc6TMYlYJupLJ8Kkx5At3Mayrv7pAlSywegfWAExHMhQJUsoeNjbjQM?=
 =?us-ascii?Q?EpNfBVKetF8EMj9DM+q3lvB0RiCjNqzgk/ivY0swCblo4bIHWl6g09SxRZAO?=
 =?us-ascii?Q?5KiBeQwRr+2Pc5zKWm3Td4+Myk4SX5PveEDQMEuzrR6gne7v8gCQ8CaCfsK0?=
 =?us-ascii?Q?xK1tLOe609EIiJvuBu77sgRH3V4y5enIXO/Y+hSascmvJ4NrTJqJQRc16DOv?=
 =?us-ascii?Q?ldP+4wzAFXFABAKV+BIye4wz7mgLxx3ZaOn/zx2MckFODR+SXW545+vwAqBZ?=
 =?us-ascii?Q?Z8P/wxOmVmF7kyWr86gOW48Pc69Md6lIBrFjH6j6ihnRjSgY1hUfeTbEnPNd?=
 =?us-ascii?Q?OcFQs1zaZHJunNK9IvQGCf5UH0P0cWJOHVCS46LH5OTszeNP3Ooh4eSuWEaX?=
 =?us-ascii?Q?SN3BObdDS+zymURzR9iKCgZHM8xCcpoY/+fYX2IhgyqdCTKJ47Q4Dnea8nui?=
 =?us-ascii?Q?vgfEcUBQP8//O3vmwmj8rB0g5Px78D7UF4ssXlhGfqSgDSVRd6mLe5ISjIjK?=
 =?us-ascii?Q?mXV3nHYeB6291MfoynNOrHixZn6te0je8UxpsM+HNlps2DriNw662aPmwDqu?=
 =?us-ascii?Q?KOmlyIICMPUXAzLh2w3/58xSbMqshT5P3HPiVGtg4zEbdTp+DOrtHIHb38IY?=
 =?us-ascii?Q?lT5ptgMZ5eMurdMWOZJinT+O20xLz/EH03TWwIcLeSk0o13qa2dbbMqnH4xY?=
 =?us-ascii?Q?EgQasPLhPwc+guA0tvPCSiPPkdp5eBkEerVlnPoS3qiRVR/LTzYUiObZ2Qna?=
 =?us-ascii?Q?skEaazSN10VeJnrpo0HoCwg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc227b77-7f21-4fe3-37a5-08d9b4c009ec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:45:14.4021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o/CiM6ofI5fT9qlZu39LHZY4hjWzZUcLNULnh+tQiuS0bge4xSo4VXlFBw8St6fPfa1d3Z8PslY94cEo6FqkqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 01.12.2021 11:32, Roger Pau Monn=C3=A9 wrote:
> On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
>> On 01.12.2021 10:09, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
>>>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>>>>       * that fall in unusable ranges for PV Dom0.
>>>>       */
>>>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
>>>> -        return false;
>>>> +        return 0;
>>>> =20
>>>>      switch ( type =3D page_get_ram_type(mfn) )
>>>>      {
>>>>      case RAM_TYPE_UNUSABLE:
>>>> -        return false;
>>>> +        return 0;
>>>> =20
>>>>      case RAM_TYPE_CONVENTIONAL:
>>>>          if ( iommu_hwdom_strict )
>>>> -            return false;
>>>> +            return 0;
>>>>          break;
>>>> =20
>>>>      default:
>>>>          if ( type & RAM_TYPE_RESERVED )
>>>>          {
>>>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
>>>> -                return false;
>>>> +                perms =3D 0;
>>>>          }
>>>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn >=
 max_pfn )
>>>> -            return false;
>>>> +        else if ( is_hvm_domain(d) )
>>>> +            return 0;
>>>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
>>>> +            perms =3D 0;
>>>
>>> I'm confused about the reason to set perms =3D 0 instead of just
>>> returning here. AFAICT perms won't be set to any other value below,
>>> so you might as well just return 0.
>>
>> This is so that ...
>>
>>>>      }
>>>> =20
>>>>      /* Check that it doesn't overlap with the Interrupt Address Range=
. */
>>>>      if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff )
>>>> -        return false;
>>>> +        return 0;
>>>>      /* ... or the IO-APIC */
>>>> -    for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++=
 )
>>>> -        if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address) =
)
>>>> -            return false;
>>>> +    if ( has_vioapic(d) )
>>>> +    {
>>>> +        for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ )
>>>> +            if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_addre=
ss) )
>>>> +                return 0;
>>>> +    }
>>>> +    else if ( is_pv_domain(d) )
>>>> +    {
>>>> +        /*
>>>> +         * Be consistent with CPU mappings: Dom0 is permitted to esta=
blish r/o
>>>> +         * ones there, so it should also have such established for IO=
MMUs.
>>>> +         */
>>>> +        for ( i =3D 0; i < nr_ioapics; i++ )
>>>> +            if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
>>>> +                return rangeset_contains_singleton(mmio_ro_ranges, pf=
n)
>>>> +                       ? IOMMUF_readable : 0;
>>>> +    }
>>
>> ... this return, as per the comment, takes precedence over returning
>> zero.
>=20
> I see. This is because you want to map those in the IOMMU page tables
> even if the IO-APIC ranges are outside of a reserved region.
>=20
> I have to admit this is kind of weird, because the purpose of this
> function is to add mappings for all memory below 4G, and/or for all
> reserved regions.

Well, that was what it started out as. The purpose here is to be consistent
about IO-APICs: Either have them all mapped, or none of them. Since we map
them in the CPU page tables and since Andrew asked for the two mappings to
be consistent, this is the only way to satisfy the requests. Personally I'd
be okay with not mapping IO-APICs here (but then regardless of whether they
are covered by a reserved region).

> I also wonder whether we should kind of generalize the handling of RO
> regions in the IOMMU for PV dom0 by using mmio_ro_ranges instead? Ie:
> we could loop around the RO ranges in PV dom0 build and map them.

We shouldn't, for example because of ...

> FWIW MSI-X tables are also RO, but adding and removing those to the
> IOMMU might be quite complex as we have to track the memory decoding
> and MSI-X enable bits.

... these: Dom0 shouldn't have a need for mappings of these tables. It's
bad enough that we need to map them in the CPU page tables.

But yes, if the goal is to map stuff uniformly in CPU and IOMMU, then
what you suggest would look to be a reasonable approach.

> And we are likely missing a check for iomem_access_permitted in
> hwdom_iommu_map?

This would be a documentation-only check: The pages have permissions
removed when not in mmio_ro_ranges (see dom0_setup_permissions()).
IOW their presence there is an indication of permissions having been
granted.

>>>> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
>>>>      for ( ; i < top; i++ )
>>>>      {
>>>>          unsigned long pfn =3D pdx_to_pfn(i);
>>>> +        unsigned int perms =3D hwdom_iommu_map(d, pfn, max_pfn);
>>>>          int rc;
>>>> =20
>>>> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
>>>> +        if ( !perms )
>>>>              rc =3D 0;
>>>>          else if ( paging_mode_translate(d) )
>>>> -            rc =3D set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
>>>> +            rc =3D set_identity_p2m_entry(d, pfn,
>>>> +                                        perms & IOMMUF_writable ? p2m=
_access_rw
>>>> +                                                                : p2m=
_access_r,
>>>> +                                        0);
>>>>          else
>>>>              rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORD=
ER_4K,
>>>> -                           IOMMUF_readable | IOMMUF_writable, &flush_=
flags);
>>>> +                           perms, &flush_flags);
>>>
>>> You could just call set_identity_p2m_entry uniformly here. It will
>>> DTRT for non-translated guests also, and then hwdom_iommu_map could
>>> perhaps return a p2m_access_t?
>>
>> That's an orthogonal change imo, i.e. could be done as a prereq change,
>> but I'd prefer to leave it as is for now. Furthermore see "x86/mm: split
>> set_identity_p2m_entry() into PV and HVM parts": In v2 I'm now also
>> adjusting the code here=20
>=20
> I would rather adjust the code here to just call
> set_identity_p2m_entry instead of differentiating between PV and
> HVM.

I'm a little hesitant, in particular considering your suggestion to
then have hwdom_iommu_map() return p2m_access_t. Andrew has made quite
clear that the use of p2m_access_* here and in a number of other places
is actually an abuse.

Plus - forgot about this in my earlier reply - there would also be a
conflict with the next patch in this series, where larger orders will
get passed to iommu_map(), while set_identity_p2m_entry() has no
respective parameter yet (and imo it isn't urgent for it to gain one).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:51:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:51:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235957.409283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO8e-00011h-Js; Wed, 01 Dec 2021 11:51:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235957.409283; Wed, 01 Dec 2021 11:51:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO8e-00011a-Gn; Wed, 01 Dec 2021 11:51:04 +0000
Received: by outflank-mailman (input) for mailman id 235957;
 Wed, 01 Dec 2021 11:51:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msO8c-00011U-Vd
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:51:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f4b2ba24-529c-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:51:01 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-EwzJCuCaN-OlWIN_WC_w8A-1; Wed, 01 Dec 2021 12:51:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:50:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:50:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0105.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::46) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Wed, 1 Dec 2021 11:50:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4b2ba24-529c-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638359461;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QkhJX3VEPOr0AiKJxzj23PArjaWK3ctCfcJg/W8CWKI=;
	b=F9JnWy8orP6NsgVdw3IGl8U3sGKBwVhjGeuCRh+ttrFj9LtZa2OODV5NRKGjc8Dr9fefbs
	m0R3cUiYHIsKSft52GDC75X+aPInUBUz6w0qgaBfD2ZUNw12/G45XZiStt06Kpd3VVoT17
	tdGqZct/JAJrXk4+FMrmiOs1h1V60uo=
X-MC-Unique: EwzJCuCaN-OlWIN_WC_w8A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LiiRpSKFSwxPhVwegdCeGbZymH50J1RfBYlagLKVuErWtZ3APKvQfxSw5MKzEm9yvWfYDm0LOTK691wI7C9FNV5+nhMEou2mI6Sqnf1zrqQL2hMNAUCM6vJwDaNZ3VqVKFXTlqO7heGt+vlWko0yFJInBvIB8+msPe4+p3WtqKraX5qApJ71s7W3PSxHdOdgQVKf+z1fuFile4S0VaP3NI8g4+qg1FIwyEgWD6q6kst6yQRu9ad6JQqNUmdpw+aZHMqUbHTjAviaq6j2sdxCqY6YwJnHf79Gef+oaVemDQGOcMPxUtnqicmzeGqc3moJFXG6EAitp+qBJa5YXcMYqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QkhJX3VEPOr0AiKJxzj23PArjaWK3ctCfcJg/W8CWKI=;
 b=Gv0JeJ49C9UYj6cO6OdTb8czOh1LdnEKIKSLG2lMux3H6XN/Cv8vK5oWjYzoYHJPoBN/vpaT6SVoV1dzESqL5WR5fmugDqVVxzohqZ+DYip2fKZCzvHMfjZ8uAhI5ZY1kjmiZOchlQLnve+2Ip2kQ53pxhJW0Jqrm3eVqcD48VhedKKriVg5iJrhcIhRdiUfdSC3GA95D3vTZMlVLkV8YOOtuDfarWvKSKqkwhStLx6O9zAYHy0wpEkf9PFywa0GSl/nXd2Jeu97pY/JwZKX+ZEt16c3FBCL5C3cnnXek6MXBkglIwYbiG/XjPzKOes0J7TPeGm1UAw7j4zwmA4EwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1e97df2b-85be-013b-a19b-85bc4baa5c4a@suse.com>
Date: Wed, 1 Dec 2021 12:50:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/2] x86/PoD: move increment of entry count
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <d92ec1b7-6cde-7efc-2c6a-3dc3696b957f@suse.com>
 <5585cbf5-6248-ca6f-8b9e-764dbb08be43@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5585cbf5-6248-ca6f-8b9e-764dbb08be43@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0105.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e003628e-48ab-4917-d087-08d9b4c0d5f9
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5598D569F9F8B7759E2505BFB3689@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7FC0izv+pi2dVA/cPRlSiVAi8irF8+c67g8mMVbwE8a9g4nCxAp40WkRnX9HuB6GdPKayANlPoXxbtgGYFI9YzjiHeSh+Te0V+GrqXB2xBJaO51n8UMqpCICpZV3BqvisQSr0S+cnHrdFahFjSJB/nEiWvu1pBOZgZwMPP8F88QGclLNkr9M10xlwJNk3BP8+YkukLj3zHzNmAcoZtJPkvLTFbgmBEbWpRZjmcZD1KhnjziQPIw0duy+Qu4UfJiae57lJS029nymoeuPrE+907b39fktjrLqd45eYRAHEiUOnF6ivh8DsXV4Za4OJdJxIHQB/mRW/OMb+ArAjE2muRiH5gStK5CZSl/trzogxJs8iUXtL5mml0rMQDSIFc9TO/EAyRwozUCWNn2mc1VmPD+RpWO6e0Z+uKHG4kamWMq2pRUJXI7TfHdT/LetVYJWKpFoGKJcG5c3j/osYuNOv7yvhRW92Bozhftp9HlrHRNywj/C3mLhplcX5R8T5q6RrkqTH7kj8FHH3KBdbfdedHga2xlzIfITG+fnaKIs/B8W2waYmYHtHOgubrdaHbSZD7Ep6HAYwiuMWOAqoHB5djHQuFU7AY5Gnv07YKQfjrNs+z0sLJ+Jq2RFQkmkOMpHLsAZD9CxEYDXKqWL4u6W2O/ky08hmPdCMmtYSjRc+guWKeuFE70/8dv1jDua/Iex0f6El8AsMRrMyiv4LyGVw/AyieORA2VNhY4HuKJizgpY+6zOlOdkM5xO+YaXoSdI
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(8936002)(8676002)(66946007)(66556008)(31686004)(66476007)(316002)(2906002)(36756003)(53546011)(83380400001)(16576012)(186003)(2616005)(6916009)(86362001)(38100700002)(6486002)(31696002)(4326008)(956004)(5660300002)(508600001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGg0anR2U0JIQUJnY2N0cThuSFdxbmdRV0RiTXhIcmNobHN4cGZvV2RkM2NF?=
 =?utf-8?B?YTJFRzhkRkNqZWdCcWgzN29ndk0xUEJOUjVFMTlEVENrRWU3b2xjQkQwQ09G?=
 =?utf-8?B?cy9ablY4ZEM0M050ZGl3SDVuS3JEY3pBSzJ2Y3dLWU1pbzFvbUptTjhSaHFw?=
 =?utf-8?B?TGwzQVVxSk9kSGFzQVY5R2w0eG1uQ3RWUEVoUFJRaEptekFkc3MyWVEzN01S?=
 =?utf-8?B?Y0RRcytNbkdPVnh2VmhjQm52SDJUeSs2a1Mydi9IZjN3L2JlblhFb1NGcVpa?=
 =?utf-8?B?VmV0Y0VJVnZtSkhkT0dJdk9PKzg5VTlOSVN6bmYvck1iUi9qSnFzb1ZONnM2?=
 =?utf-8?B?VExpb2kwQ2lta2MvRG9LMVZqSkNGald0VmNxbkhtamJZeWVoSGNTaUp0UDg4?=
 =?utf-8?B?aHp6SjAxWDVjQzB0eWs4R2hkeHMyNmk3QXBNRTNMQ3R6YzRMK3hiTlZobU0y?=
 =?utf-8?B?UzB6NmhvbFd4OG1RWHZMdDNCU3VoekRTYVZSNzNqUUxTNFI3U0E0Q2dwQUJR?=
 =?utf-8?B?K1NMOG05M08xRUVoc2dRSWI4UTZQVWJzbFZMWmlnZVRMN0M0UUYrRHpyWWJt?=
 =?utf-8?B?QUo4bU1IbDBISllNREM0K3FyNWdvRWJaOGMvMXMvRVJ4em1DYXZtcy9mM255?=
 =?utf-8?B?RmovbklhaTQ1anJDb2NmRjhMdStBUGFCWVF0R3dOeDFNSVhRaUtrdmV0SldG?=
 =?utf-8?B?dXRySnRUU1A5blFZcUZYSXNLY2l4T242R0tXVkh2S0tocnRDb2pkeHJRNDcv?=
 =?utf-8?B?VDZ1aG9uL1FabnZXQ2VFVmVWeGx6UmhFM0JJNUN5TVp2L0ppajEyT1ZyTU5s?=
 =?utf-8?B?Wm5GU2dsTS9xTXNLK1hVbWFkOHdzZWtqSFFmYyt5VlFBVWNvZG51UVU2TjVs?=
 =?utf-8?B?eUFobUUvakp0UXY3MUY3ZjJqS1ZRUGpKcTc0dXB4SCtFRk1hT0RKYVh1VkQ5?=
 =?utf-8?B?YmZUM3RXZDZZakJFT1R6bCtNUTNrK3BZV3pacHA1Q2ROWjZrM2lWMGhPa3Az?=
 =?utf-8?B?NVVlWXkvTjlwbGliUUQ2M292bW1mZ29NdmhUVWJqL0cvcXZnWHYya3grYXVy?=
 =?utf-8?B?VGhhM3phWWs4VFRMYTRmYTh1YnlQbE1FUlVwdi8vZlNiMlhmeUNGa1ZWSXQ3?=
 =?utf-8?B?QzZGTkNPRDI0YzNSSTc3b2Y2OHJ4R3JYNW9VS1c2Y1JmbHNvczBIRTZPUUtj?=
 =?utf-8?B?Z3dUSENIMTR2N0VrVjZNazhCU0JhSm1qd3k1ZG1NZVByUlFtWSsrbkRCazdW?=
 =?utf-8?B?NXVXR3dVYXNDUWxYZ0lISHdxU3pVLzY2cFJzNC8yeUtFNUsrS2t0MW5wSjdQ?=
 =?utf-8?B?a244enhoSDZEUTdIRDNFWnczeTVaaFptZU1KZlhZMENOUytON3cybE5qMll2?=
 =?utf-8?B?L1lia2hZOVZBTFkxa3Jrcm9pNTBSY0xxUmZVbGpiRnVaZ3dRMkZZMGpFZnpj?=
 =?utf-8?B?WHp4RnZWWlFBWmhLUE04cnM4Z09jVG4zOWlBMm5uZlVyVG41aUpQOTJ0b0Ew?=
 =?utf-8?B?NkhOTU1XS2lDSCtQaUJYS1Eyb2JrRjNTb1c5U2xHanlxSzBienN1akcvdmZa?=
 =?utf-8?B?RE9PdTcvWE01Q1E3aE5yWnR3N01ncUdMR0JnK3VvK0hqSUtWRXo2KzVseGNa?=
 =?utf-8?B?U01LelpJTjlRN3lNdVdBcjYvYjdoUGJON0doWlIwR0NSbEpkSEdycC96L0Fo?=
 =?utf-8?B?akpXczNiVG1hdXFCSEs1QTZJanlSWTY0V2xkZlhDSitENXEvNks0ZWlIcFRT?=
 =?utf-8?B?UGRpVUZNUkdpOTBrRW5DaUh2YjkzbTkrRktha0RnZlNCTFhBZTlzb3BBS0Zn?=
 =?utf-8?B?eXU4VHJmSElUSzBVQVNhU0s3ZEtzdXNwR1dUOEs3QXBvdTF0R0RXUGUwdHpU?=
 =?utf-8?B?NlJJV1lXamQrZ1BoVE5ndHFwcysrTXZrVUZDWHZTMHZvNXNkWGw3WVUwSEtV?=
 =?utf-8?B?SW5uQ1lSUCtYZGNlT1Nqd0Q0YVkrTzFLMm5LSmdXeTB0QXRRS1hlbDZvRjRV?=
 =?utf-8?B?Yy9TN1N3OVl0aHpSLzVkaW9BWU5xS1ZiMklkM2hOaHNlMUI0TjRacDVKTjNM?=
 =?utf-8?B?ZFZiR09wOVd3V2MzZ3hXeHhoUWVaQ0liaFlnQnBBUTl1b0hrWmJ0anFnOGJF?=
 =?utf-8?B?KzlZQXp0SU5mZDUzbmRmdlh5Tm5JYnpiQTYvb3ZOY3F0eDZqNHB1azd4NHFX?=
 =?utf-8?Q?Q7JfabvQKGmUeOw5RpbKhzM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e003628e-48ab-4917-d087-08d9b4c0d5f9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:50:56.7334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PVaR3mas536udZGDkWnf/D5MrhiqDPsl+dcQ1P70iO/d3lntvH6c7UySZu/0r7NCaoH9IpHErqDXNB1MSsdSYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

On 01.12.2021 12:27, Andrew Cooper wrote:
> On 01/12/2021 11:02, Jan Beulich wrote:
>> When not holding the PoD lock across the entire region covering P2M
>> update and stats update, the entry count should indicate too large a
>> value in preference to a too small one, to avoid functions bailing early
>> when they find the count is zero. Hence increments should happen ahead
>> of P2M updates, while decrements should happen only after. Deal with the
>> one place where this hasn't been the case yet.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
>>          }
>>      }
>>  
>> +    pod_lock(p2m);
>> +    p2m->pod.entry_count += (1UL << order) - pod_count;
>> +    pod_unlock(p2m);
>> +
>>      /* Now, actually do the two-way mapping */
>>      rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
>>                         p2m_populate_on_demand, p2m->default_access);
>>      if ( rc == 0 )
>> -    {
>> -        pod_lock(p2m);
>> -        p2m->pod.entry_count += 1UL << order;
>> -        p2m->pod.entry_count -= pod_count;
>> -        BUG_ON(p2m->pod.entry_count < 0);
>> -        pod_unlock(p2m);
>> -
>>          ioreq_request_mapcache_invalidate(d);
>> -    }
>>      else if ( order )
>>      {
>>          /*
>> @@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
>>                 d, gfn_l, order, rc);
>>          domain_crash(d);
>>      }
>> +    else if ( !pod_count )
>> +    {
>> +        pod_lock(p2m);
>> +        BUG_ON(!p2m->pod.entry_count);
>> +        --p2m->pod.entry_count;
>> +        pod_unlock(p2m);
>> +    }
>>  
>>  out:
>>      gfn_unlock(p2m, gfn, order);
> 
> This email appears to contain the same patch twice, presumably split at
> this point.

Urgh - no idea how this has happened.

> Which one should be reviewed?

Just everything up from here. Or let me simply resend.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:52:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:52:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235962.409296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO9o-0001ao-0J; Wed, 01 Dec 2021 11:52:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235962.409296; Wed, 01 Dec 2021 11:52:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msO9n-0001ag-SE; Wed, 01 Dec 2021 11:52:15 +0000
Received: by outflank-mailman (input) for mailman id 235962;
 Wed, 01 Dec 2021 11:52:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msO9m-0001aD-LK
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:52:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1f99ea94-529d-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:52:13 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-8Sv8aH-JMdaPmLWtdMHVfg-1; Wed, 01 Dec 2021 12:52:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Wed, 1 Dec
 2021 11:52:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 11:52:11 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0058.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::35) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Wed, 1 Dec 2021 11:52:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f99ea94-529d-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638359533;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jFiFW1A5HX6NQdugw21gayywBYK+vQSEiTp/bOCwvUk=;
	b=Mvij0ji9DSMjxqrYNiCw6JzfAYaIWYg4lozKY5IymnLfuTSdCrnBFvS9lmjQyRn5+uIGOV
	XeCycDq3yMrbg5xiUfccp7uaamd9OLLOu+sdO6iddaXCCP0KFUvSoOLPNpnWvjGgNGXSQY
	1RdWeMbqwNDWizSnaNWZzrA4YFRYw8c=
X-MC-Unique: 8Sv8aH-JMdaPmLWtdMHVfg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g8+QdujFIaN3lpbRGY9kl0J35q/jeHmqhfiBUDkOpHJR4ztwbhfJs/LXIfXZoI+LeoAd4Oz0Daj0iLCx3Ub1RkTZjhskgo0QJej2IdCvlW2Rc8c6gkEUaDF8E6l7xmpSFLmY+EYQHz4FiqUdSRfvcdYx2Mur8q6J4CFMdsiyI8AuGQrFeN7sWveWCQweNTxRuEvJ2ihUNFpll03KC9sKmBeuedD+/TdjhfS65olDddystgrfr3Zv1sLJwtPOo/HD2WyN+OkX3xrcOKpfEqude/8NlKTBqsejBMVnzPa/BoT19c3+CEU4Y06axZ2RuIGQR/fbPlPHBbxTADP60UO0yA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jFiFW1A5HX6NQdugw21gayywBYK+vQSEiTp/bOCwvUk=;
 b=kzQHidR1fSJWaFpb08kVjAvMnorPNx54ervEN7SBfGf83KY21CtqU4oQ+2j24w+zufeC2RC5sjcTylVCaDksWt04domeoehGIJg4Mk92Aa6+lLEzkEj7zHnxgxZn7mmMaWijpop3OhNC5KVLHQr6RKORwZvPTZlNYa/9u5hh1D3kwCq0uUkrqwwyGSGDwxKtsrc13xrGPDaM44w4N/kHVSuLaAX/cCJJ8eWIuVrAd6c9k0z1UFrlLZ9qcobFfNeQ9092JB91Y6uGP9/bq17H4dOcHBNt4xiTgoac4sfs8Rd72of8ua9qwGvDnUgiy/7XZb+RbN+EjDZmcEIS+PNHrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e698a39a-f9fc-18d7-07cd-d0b9da9c0eae@suse.com>
Date: Wed, 1 Dec 2021 12:52:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 2/2] x86/PoD: move increment of entry count
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
Content-Language: en-US
In-Reply-To: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0058.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c27536ab-408f-4c8a-2af3-08d9b4c10229
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB559803D103399B3FC97F87F3B3689@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MSY9GOsxx4vAmZ7TZnoSztFFdyXAc9sUATNaauHB50L5kOc18ilYGvkUuw172ai9PMMsiO4Oea7PFP5AJVFbDcGeD5I9FX4wxxDgk+bFi8V41OWD5u5D/R8ncpYmbMMllBRyE8gpkclIHVICdxNIvea8jXChCx6vGWDTHxNX+A5wqt/+kdjIZqGeJjkAiYzY9oRNLmpVBHOnAPl7zo5Pp3ejboqujiZypAy6mdG0Qb7ysyk7qqWWYvmmgSQ80YxgTvSGvKSENmtppRD2VWXd1qXYHRJI+J35bkilgCpTRMxDE7i/PMumVIEcjSZ/3zQFY198aoGuVSpQD4k5X7ybyuv8zVLFbyMkJHqZDVnpJvmH4gtRuWHrsmlwy2CT7oJK9UhrldzbXRIACGaMfkDXvPlMsDdS2X5FyXmp0UCVeNZlV4C5H9xYsqeh5O3eGDGnERG1F2NmLuXm0yHUcuwSTlCEEcrIs8n1lVaX/JUE1EV8cfNm/ydNGEsyeTzEoaAF4714xfFuR255h98DFq7I8WvR7fpFBB82dN2AK+ogYKgwX/dQRhWpz6PFdeKTD3svGJCOONBmbOrO+GuyG+7sEEmdDW8bXdWPK+GVM6lhLfR2h+zSn2y80kjyxwIC3yHiYu4+TciDUkZutbXNi/p8phEcprbGizX9SbxgS+/m5otr49HXujkK9o2nr2C2NBxPPUHzALrlKg2jtF87hn353sgV5lB4b+J2oZ7xts8KuDdyHEtSlePdbZtkPFHAW186
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(8936002)(8676002)(66946007)(66556008)(31686004)(66476007)(316002)(2906002)(36756003)(83380400001)(16576012)(186003)(2616005)(6916009)(86362001)(38100700002)(6486002)(31696002)(4326008)(956004)(5660300002)(508600001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YVV6dWYyb0c5SVVwQWIyc2twS01ESSthYVd3Yk9WVnVuYnJjbzlGR1FublFE?=
 =?utf-8?B?M1UzQUJ6QWpDS1hzN2JhWXB5YjA3VEVTall1eVVRekNCMlNKTHcxUUFJSDA0?=
 =?utf-8?B?WTQydjZuNS9ydHRicmZNNlkxL3BpazNMbWgycHRmdlRQYzhzMzFicEdQR2xZ?=
 =?utf-8?B?elkvSDFHMHBrQkdtWTBvalN5SlUxb1FhTjNITnJ0QTlaU2ZwcHp2OWR0dk9M?=
 =?utf-8?B?emg4R1VTaC9WSTB6RVc5NTMzbXZuam5QZWhVM1pPUGRoRS9Cb2l1OGJPdXBG?=
 =?utf-8?B?STZEbmdnbkhLMlpHdGp0cTQ2Ri9yaks0cmFLclhjRTVUcTNpVnhhVGFQNjNO?=
 =?utf-8?B?YXczK2lrZTBjQnR5a05oUDJPaFAzWFUwVUgwd243dTdiU01rWm9YbHdidE1C?=
 =?utf-8?B?U3NWRWJKUTFUVlprNFFseG5vNGUyL0VWbzN5R3NkVmp0eEI1OEY4M1kwTmdw?=
 =?utf-8?B?NlNpeElrQTgyaUF0enBBWEd2MjFXVDRoYWlsQXp4TmJCTEorZ0R5RUZJeUlK?=
 =?utf-8?B?eEg1eHhWYmNzMDZRa3NSSGZBNnNTd1J1ZVNxbXVDSllIVGpjaFE1UkRhOGhO?=
 =?utf-8?B?M2pTUVdyTUJqenh4S0NnbW8yb3VMM1MwNjdNSEFyZUdLUFBldGNrQXU5R2V0?=
 =?utf-8?B?YkNwa2dtcFBXcXJoOHJkQzhPTkQ3djQrN1V5UktGNUg4NGQ1ZTFuZytsZTk3?=
 =?utf-8?B?VWlLbXhteUp5dE9qejl2Yk5TeTRmT3JsaHd5VXRtaHc0bWR6UlMwR1pGaHdl?=
 =?utf-8?B?OU9rK2FNRTVlRWFrQnVXODJ0UndON05Vc1ZYeXIvbDVvMnZ1c3ZCTXEyU1Fj?=
 =?utf-8?B?a2ZwNW1KNUFVOW1pWjRXdkZpZW8vTmt2K0xUY2IwRzRFdTFNZXBPS3E1ejdK?=
 =?utf-8?B?ZGg4NFpBQmxEQXpKK3duSGRNWHE1clhvamJ4cldqNkxlWi9TSi8zMTFnTlpG?=
 =?utf-8?B?MkJsbUR4Vk1nTk0xQTlCQjB5L1dnZ0FxcXBWaS9WSTdDM3ZTSkd6ZlBuVndm?=
 =?utf-8?B?Slg4d1pSS3N4R2Y3bE9jOWRxN09WYlJOU2NROXJTeHlqNGh6d3VKSG14aXR6?=
 =?utf-8?B?MWNEd3JuaGUzdktzR2VmeXp0OEhaMDZERXd5Qk4zdEdxQUJhRkV5cS9MWStW?=
 =?utf-8?B?b1FmVjJSc2haZ3lmRVN5ME00NUdxYlVGVFZQbjIwWGszeWNacFg3aXdHMVJi?=
 =?utf-8?B?QVcrMkhQbDBOMkc2WCtUdFJMQkNGeUkzbnYralptcHB6OWVOVnppMmZaeHlU?=
 =?utf-8?B?TTZleVV5QklpN3h1RnRNUXFHcCtkUnl6azltNGkxcE9OV2xxMkNFRE05Tmpp?=
 =?utf-8?B?c0FnWDVJWU9ocFNkSzIwTGJlUzhHOE5RRzFJTlJCckxYUFh1bjVENCsyT1dm?=
 =?utf-8?B?UXVxU2JNYVpJc3N2NGJxTkRoRVlFYi9nRjJpQVZFMjBsSEJCN1FYR3U1eGZh?=
 =?utf-8?B?MDFzNWQ1Yk9SSzh2aU4vSGJ5b2VMb0pFVDk1dVlTY0xDUkZDOTYzNitjS0dQ?=
 =?utf-8?B?aEgyM0pMdWZZUEZ6eTBxYjRaVFJaVXlFZ0dSWE94ZUk0RjRhMHVRdXdSeS9y?=
 =?utf-8?B?MERYc0Z0UFdTN2pwclpxdTYweDlmd0FWL2FkMWxQNUdVZUxDamFFRlltSHR3?=
 =?utf-8?B?TEQxSXJiMGtuTncvK2ZLeTJMNmxnSG5WRmtSTnBrTHZpcE5PTVAxYnBqZWVN?=
 =?utf-8?B?cVJ6TC9WTG4wQVhMQmJZSFd3OGk4d0hybGZ0UHd3eDhxSGU3TXZrQklJNlhX?=
 =?utf-8?B?cVVEM0RZeGtLdXVWcVV5WFMvSkhiOXJaMnFiYTZoTzJRcWx0RW1KYlgwN3VP?=
 =?utf-8?B?Rm5pdEl5ZGw5QTBGQyt1czNBNjlNSEZEaEdua1BmNTdwS1ZneTdNamxJMG1V?=
 =?utf-8?B?M0c2OWl5UWhjeVNxa0JIOVBVRVkwdHJrcUlNdytNU001eko2bWEydDZkaHBG?=
 =?utf-8?B?U2ZIVDB4RWtZdlNOWVg3eUV4SmJ4cmFxT2U5S2F6clVKc0dHMGxxQ2pma0pX?=
 =?utf-8?B?czVoSUxKVzV6RTZLc2Y3RXFRN2t4SXM4YkRVeU1Kb3dtTHZjeUpzWHFBdnZx?=
 =?utf-8?B?aVBVYnErSVArYWJoWGdQSTBXU2xBcUk2cmZmUEhiWEh0TGhkeVh1Z0VlM2lG?=
 =?utf-8?B?K1poTlB3YlRDWW1Ib1BjditTWHVWbjI5MENCRWxVOTRCeTloSW9yNy8za3lj?=
 =?utf-8?Q?tlfqtLmS6S8zLie3ui10kwk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c27536ab-408f-4c8a-2af3-08d9b4c10229
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 11:52:10.9005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q8LjKjPJCDMDZbSZcA01SaBqPeFtwvkHMRmKNoNvRwGe+CWrf5d6bDlXG/wK3XL05kBzLit4ncb1tNKQi7+1eQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

When not holding the PoD lock across the entire region covering P2M
update and stats update, the entry count should indicate too large a
value in preference to a too small one, to avoid functions bailing early
when they find the count is zero. Hence increments should happen ahead
of P2M updates, while decrements should happen only after. Deal with the
one place where this hasn't been the case yet.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Resending due to the original submission having had the same contents
twice.

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
         }
     }
 
+    pod_lock(p2m);
+    p2m->pod.entry_count += (1UL << order) - pod_count;
+    pod_unlock(p2m);
+
     /* Now, actually do the two-way mapping */
     rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
                        p2m_populate_on_demand, p2m->default_access);
     if ( rc == 0 )
-    {
-        pod_lock(p2m);
-        p2m->pod.entry_count += 1UL << order;
-        p2m->pod.entry_count -= pod_count;
-        BUG_ON(p2m->pod.entry_count < 0);
-        pod_unlock(p2m);
-
         ioreq_request_mapcache_invalidate(d);
-    }
     else if ( order )
     {
         /*
@@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
                d, gfn_l, order, rc);
         domain_crash(d);
     }
+    else if ( !pod_count )
+    {
+        pod_lock(p2m);
+        BUG_ON(!p2m->pod.entry_count);
+        --p2m->pod.entry_count;
+        pod_unlock(p2m);
+    }
 
 out:
     gfn_unlock(p2m, gfn, order);



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 11:59:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 11:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235970.409307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOGO-0002WV-RN; Wed, 01 Dec 2021 11:59:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235970.409307; Wed, 01 Dec 2021 11:59:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOGO-0002WO-OC; Wed, 01 Dec 2021 11:59:04 +0000
Received: by outflank-mailman (input) for mailman id 235970;
 Wed, 01 Dec 2021 11:59:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=46ns=QS=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1msOGN-0002WI-7z
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 11:59:03 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 1208e2a1-529e-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 12:59:00 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 201071477;
 Wed,  1 Dec 2021 03:59:00 -0800 (PST)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 036F43F694;
 Wed,  1 Dec 2021 03:58:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1208e2a1-529e-11ec-976b-d102b41d0961
Date: Wed, 1 Dec 2021 11:58:46 +0000
From: Andre Przywara <andre.przywara@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Cc: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
 <stefanos@xilinx.com>, <julien@xen.org>, <Volodymyr_Babchuk@epam.com>,
 <bertrand.marquis@arm.com>, <jbeulich@suse.com>
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Message-ID: <20211201115846.6f9b1d99@donnerap.cambridge.arm.com>
In-Reply-To: <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
	<20211130094950.1bf368d6@donnerap.cambridge.arm.com>
	<a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
Organization: ARM
X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 30 Nov 2021 19:13:41 +0000
Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:

Hi Ayan,

> Thanks for your comments. They are useful.
>=20
> On 30/11/2021 09:49, Andre Przywara wrote:
> > On Mon, 29 Nov 2021 19:16:38 +0000
> > Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> >=20
> > Hi,
> >  =20
> >> At the moment, Xen is only handling data abort with valid syndrome (i.=
e.
> >> ISV=3D0). Unfortunately, this doesn't cover all the instructions a dom=
ain
> >> could use to access MMIO regions.
> >>
> >> For instance, Xilinx baremetal OS will use:
> >>
> >>          volatile u32 *LocalAddr =3D (volatile u32 *)Addr;
> >>          *LocalAddr =3D Value;
> >>
> >> This leave the compiler to decide which store instructions to use. =20
> >=20
> > As mentioned in the other email, this is wrong, if this points to MMIO:
> > don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
> > an MMIO area, you should not see traps that you cannot handle already.
> >=20
> > So I don't think it's a good idea to use that as an example. And since
> > this patch only seems to address this use case, I would doubt its
> > usefulness in general. =20
> Yes, I should have fixed the comment.
>=20
> Currently, I am testing with baremetal app which uses inline assembly=20
> code with post indexing instructions, to access the MMIO.
>=20
> ATM, I am testing with 32 bit MMIO only.
>=20
> On the usefulness, I am kind of torn as it is legitimate for post=20
> indexing instructions to be used in an inline-assembly code for=20
> accessing MMIO. However, that may not be something commonly seen.

It is legitimate, but I question the usefulness: for a start it wouldn't
work under today's Xen (or KVM), and I doubt this would be backported. So
you would always require users to use the newest version of the hypervisor.
Also MMIO accesses are slow anyway, so while using post-indexing might be
convenient from an assembly writer's point of view, it doesn't give you
much performance-wise, probably. So if you are interested in running under
Xen (or other virtualisation solutions), just don't use them for MMIO.

And I am not sure that Xen aims to virtualise every piece of code on the
planet: certainly we have certain expectations about the platform, so you
would probably consider running under a hypervisor from the very beginning.

> @Stefano/Bertrand/Julien/Volodymyr :- As you are the Arm mantainers, can=
=20
> you comment if we should have decoding logic or not ?
>=20
> >  =20
> >> This
> >> may be a post-index store instruction where the HW will not provide a
> >> valid syndrome.
> >>
> >> In order to handle post-indexing store/load instructions, Xen will need
> >> to fetch and decode the instruction.
> >>
> >> This patch only cover post-index store/load instructions from AArch64
> >> mode. For now, this is left unimplemented for trap from AArch32 mode.
> >>
> >> Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
> >> ---
> >>
> >> Changelog :-
> >>
> >> v2 :- 1. Updated the rn register after reading from it. (Pointed by
> >> Julien, Stefano)
> >> 2. Used a union to represent the instruction opcode (Suggestd by
> >> Bertrand) 3. Fixed coding style issues (Pointed by Julien)
> >> 4. In the previous patch, I was updating dabt->sign based on the
> >> signedness of imm9. This was incorrect. As mentioned in ARMv8 ARM  DDI
> >> 0487G.b, Page 3221, SSE indicates the signedness of the data item
> >> loaded. In our case, the data item loaded is always unsigned.
> >>
> >> This has been tested for the following cases :-
> >> ldr x2, [x1], #4 =20
> >=20
> > As Jan already mentioned: this is a bad example. First, this is a 64-bit
> > access, which you don't emulate below. And second, you want to keep the
> > pointer aligned. Unaligned accesses to device memory always trap, as per
> > the architecture, even on bare metal.
> >  =20
> >>
> >> ldr w2, [x1], #-4
> >>
> >> str x2, [x1], #4 =20
> >=20
> > Same as above.
> >  =20
> >> str w2, [x1], #-4
> >>
> >> The reason being  I am testing on 32bit MMIO registers only. I don't s=
ee
> >> a 8bit or 16bit MMIO register. =20
> >=20
> > Where did you look? There are plenty of examples out there, even the GIC
> > allows 8-bit accesses to certain registers (grep for "VGIC_ACCESS_"), a=
nd
> > the Linux GIC driver is using them (but with proper accessors, of cours=
e).
> > Also GICv3 supports 64-bit accesses to some registers. Some PL011 UARTs=
 use
> > 16-bit MMIO accesses. =20
> Yes, sorry I see them now. GICD_IPRIORITYR can be accessed with 8 bits.
> Unfortunately, I have GIC-v2 on my hardware system. So, probably I can't=
=20
> test 64 bit access.
>=20
> >  =20
> >>   xen/arch/arm/decode.c     | 68 +++++++++++++++++++++++++++++++++++++=
+-
> >>   xen/arch/arm/decode.h     |  3 +-
> >>   xen/arch/arm/io.c         | 40 +++++++++++++++++++----
> >>   xen/include/asm-arm/hsr.h | 26 +++++++++++++++
> >>   4 files changed, 129 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> >> index 792c2e92a7..0b3e8fcbc6 100644
> >> --- a/xen/arch/arm/decode.c
> >> +++ b/xen/arch/arm/decode.c
> >> @@ -84,6 +84,66 @@ bad_thumb2:
> >>       return 1;
> >>   }
> >>  =20
> >> +static int decode_32bit_loadstore_postindexing(register_t pc,
> >> +                                               struct hsr_dabt *dabt,
> >> +                                               union ldr_str_instr_cl=
ass *instr)
> >> +{
> >> +    if ( raw_copy_from_guest(&instr->value, (void * __user)pc, sizeof=
 (instr)) )
> >> +        return -EFAULT;
> >> +
> >> +    /* First, let's check for the fixed values */
> >> +    if ( !((instr->code.fixed1 =3D=3D 1) && (instr->code.fixed2 =3D=
=3D 0) &&
> >> +         (instr->code.fixed3 =3D=3D 0) && (instr->code.fixed4 =3D=3D =
7)) )
> >> +    {
> >> +        gprintk(XENLOG_ERR, "Decoding not supported for instructions =
other than"
> >> +            " ldr/str post indexing\n");
> >> +        goto bad_32bit_loadstore;
> >> +    }
> >> +
> >> +    if ( instr->code.size !=3D 2 ) =20
> >=20
> > I don't see a good reason for this limitation. If you are going to diss=
ect
> > the instruction, why not just support at least all access widths, so
> > 64-bits, but also {ldr,str}{b,w}? I think the framework does the heavy
> > lifting for you already? =20
>=20
> I see your point. My intention was to test first with the restricted=20
> instruction set (ie ldr/str - 32 bit access with post indexing only) and=
=20
> get an opinion from the community. If the patch looks sane, then this=20
> can be extended with other variants as well.
>=20
> > Same for the restriction to post-index above, supporting pre-index as w=
ell
> > should be easy. =20
> For Pre-indexing instruction, the ISS is valid. So I am not sure what is=
=20
> to be done here?

Where did you find this? The ARM ARM says that ISV=3D0 when the instruction
is using writeback, which would include pre-index.
I tested "ldr w0, [x1, #4]!" and it failed on KVM, as expected.

> AFAIU, if the ISS is valid, there is no need to explicitly decode the=20
> instructions.
> >=20
> > To me this has the bitter taste for being a one trick pony to work arou=
nd
> > your particular (broken!) use case.
> >  =20
> >> +    {
> >> +        gprintk(XENLOG_ERR,
> >> +            "ldr/str post indexing is supported for 32 bit variant on=
ly\n");
> >> +        goto bad_32bit_loadstore;
> >> +    }
> >> +
> >> +    if ( instr->code.v !=3D 0 )
> >> +    {
> >> +        gprintk(XENLOG_ERR,
> >> +            "ldr/str post indexing for vector types are not supported=
\n");
> >> +        goto bad_32bit_loadstore;
> >> +    }
> >> +
> >> +    /* Check for STR (immediate) - 32 bit variant */
> >> +    if ( instr->code.opc =3D=3D 0 )
> >> +    {
> >> +        dabt->write =3D 1;
> >> +    }
> >> +    /* Check for LDR (immediate) - 32 bit variant */
> >> +    else if ( instr->code.opc =3D=3D 1 )
> >> +    {
> >> +        dabt->write =3D 0;
> >> +    }
> >> +    else
> >> +    {
> >> +        gprintk(XENLOG_ERR,
> >> +            "Decoding ldr/str post indexing is not supported for this=
 variant\n");
> >> +        goto bad_32bit_loadstore;
> >> +    }
> >> +
> >> +    gprintk(XENLOG_INFO,
> >> +        "instr->code.rt =3D 0x%x, instr->code.size =3D 0x%x, instr->c=
ode.imm9 =3D %d\n",
> >> +        instr->code.rt, instr->code.size, instr->code.imm9);
> >> +
> >> +    update_dabt(dabt, instr->code.rt, instr->code.size, false);
> >> +    dabt->valid =3D 1;
> >> +
> >> +    return 0;
> >> +bad_32bit_loadstore:
> >> +    gprintk(XENLOG_ERR, "unhandled 32bit Arm instruction 0x%x\n", ins=
tr->value);
> >> +    return 1;
> >> +}
> >> +
> >>   static int decode_thumb(register_t pc, struct hsr_dabt *dabt)
> >>   {
> >>       uint16_t instr;
> >> @@ -150,11 +210,17 @@ bad_thumb:
> >>       return 1;
> >>   }
> >>  =20
> >> -int decode_instruction(const struct cpu_user_regs *regs, struct hsr_d=
abt *dabt)
> >> +int decode_instruction(const struct cpu_user_regs *regs, struct hsr_d=
abt *dabt,
> >> +                       union ldr_str_instr_class *instr)
> >>   {
> >>       if ( is_32bit_domain(current->domain) && regs->cpsr & PSR_THUMB )
> >>           return decode_thumb(regs->pc, dabt);
> >>  =20
> >> +    if ( (is_64bit_domain(current->domain) && !psr_mode_is_32bit(regs=
)) )
> >> +    {
> >> +        return decode_32bit_loadstore_postindexing(regs->pc, dabt, in=
str);
> >> +    }
> >> +
> >>       /* TODO: Handle ARM instruction */
> >>       gprintk(XENLOG_ERR, "unhandled ARM instruction\n");
> >>  =20
> >> diff --git a/xen/arch/arm/decode.h b/xen/arch/arm/decode.h
> >> index 4613763bdb..d82fc4a0f6 100644
> >> --- a/xen/arch/arm/decode.h
> >> +++ b/xen/arch/arm/decode.h
> >> @@ -35,7 +35,8 @@
> >>    */
> >>  =20
> >>   int decode_instruction(const struct cpu_user_regs *regs,
> >> -                       struct hsr_dabt *dabt);
> >> +                       struct hsr_dabt *dabt,
> >> +                       union ldr_str_instr_class *instr);
> >>  =20
> >>   #endif /* __ARCH_ARM_DECODE_H_ */
> >>  =20
> >> diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
> >> index 729287e37c..0d60754bc4 100644
> >> --- a/xen/arch/arm/io.c
> >> +++ b/xen/arch/arm/io.c
> >> @@ -65,6 +65,16 @@ static enum io_state handle_write(const struct
> >> mmio_handler *handler, return ret ? IO_HANDLED : IO_ABORT;
> >>   }
> >>  =20
> >> +static void post_incremenet_register(union ldr_str_instr_class *instr)
> >> +{
> >> +    struct cpu_user_regs *regs =3D guest_cpu_user_regs();
> >> +    unsigned int val;
> >> +
> >> +    val =3D get_user_reg(regs, instr->code.rn);
> >> +    val +=3D instr->code.imm9;
> >> +    set_user_reg(regs, instr->code.rn, val);
> >> +}
> >> +
> >>   /* This function assumes that mmio regions are not overlapped */
> >>   static int cmp_mmio_handler(const void *key, const void *elem)
> >>   {
> >> @@ -106,14 +116,26 @@ enum io_state try_handle_mmio(struct cpu_user_re=
gs
> >> *regs, .gpa =3D gpa,
> >>           .dabt =3D dabt
> >>       };
> >> +    int rc;
> >> +    union ldr_str_instr_class instr =3D {0};
> >>  =20
> >>       ASSERT(hsr.ec =3D=3D HSR_EC_DATA_ABORT_LOWER_EL);
> >>  =20
> >> +    /*
> >> +     * Armv8 processor does not provide a valid syndrome for post-ind=
exing
> >> +     * ldr/str instructions. So in order to process these instruction=
s,
> >> +     * Xen must decode them.
> >> +     */
> >> +    if ( !info.dabt.valid )
> >> +    {
> >> +        rc =3D decode_instruction(regs, &info.dabt, &instr);
> >> +        if ( rc )
> >> +            return IO_ABORT;
> >> +    }
> >> +
> >>       handler =3D find_mmio_handler(v->domain, info.gpa);
> >>       if ( !handler )
> >>       {
> >> -        int rc;
> >> -
> >>           rc =3D try_fwd_ioserv(regs, v, &info);
> >>           if ( rc =3D=3D IO_HANDLED )
> >>               return handle_ioserv(regs, v);
> >> @@ -122,7 +144,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs
> >> *regs, }
> >>  =20
> >>       /* All the instructions used on emulated MMIO region should be
> >> valid */
> >> -    if ( !dabt.valid )
> >> +    if ( !info.dabt.valid )
> >>           return IO_ABORT;
> >>  =20
> >>       /*
> >> @@ -134,7 +156,7 @@ enum io_state try_handle_mmio(struct cpu_user_regs
> >> *regs, {
> >>           int rc;
> >>  =20
> >> -        rc =3D decode_instruction(regs, &info.dabt);
> >> +        rc =3D decode_instruction(regs, &info.dabt, NULL);
> >>           if ( rc )
> >>           {
> >>               gprintk(XENLOG_DEBUG, "Unable to decode instruction\n");
> >> @@ -143,9 +165,15 @@ enum io_state try_handle_mmio(struct cpu_user_regs
> >> *regs, }
> >>  =20
> >>       if ( info.dabt.write )
> >> -        return handle_write(handler, v, &info);
> >> +        rc =3D handle_write(handler, v, &info);
> >>       else
> >> -        return handle_read(handler, v, &info);
> >> +        rc =3D handle_read(handler, v, &info);
> >> +
> >> +    if ( instr.value !=3D 0 )
> >> +    {
> >> +        post_incremenet_register(&instr);
> >> +    }
> >> +    return rc;
> >>   }
> >>  =20
> >>   void register_mmio_handler(struct domain *d,
> >> diff --git a/xen/include/asm-arm/hsr.h b/xen/include/asm-arm/hsr.h
> >> index 9b91b28c48..72d67d2801 100644
> >> --- a/xen/include/asm-arm/hsr.h
> >> +++ b/xen/include/asm-arm/hsr.h
> >> @@ -15,6 +15,32 @@ enum dabt_size {
> >>       DABT_DOUBLE_WORD =3D 3,
> >>   };
> >>  =20
> >> +/*
> >> + * Refer to the ARMv8 ARM (DDI 0487G.b), Section C4.1.4 Loads and Sto=
res
> >> + * Page 318 specifies the following bit pattern for
> >> + * "load/store register (immediate post-indexed)".
> >> + *
> >> + * 31 30 29  27 26 25  23   21 20              11   9         4      =
 0
> >> + * ___________________________________________________________________
> >> + * |size|1 1 1 |V |0 0 |opc |0 |      imm9     |0 1 |  Rn     |  Rt  =
 |
> >> + * |____|______|__|____|____|__|_______________|____|_________|______=
_|
> >> + */
> >> +union ldr_str_instr_class {
> >> +    uint32_t value;
> >> +    struct ldr_str {
> >> +        unsigned int rt:5;     /* Rt register */ =20
> >=20
> > I don't think it's a particular good idea to use a bit-field here, if t=
hat
> > is expected to mimic a certain hardware provided bit pattern.
> > It works in practise (TM), but the C standard does not guarantee the or=
der
> > the bits are allocated (ISO/IEC 9899:201x =C2=A76.7.2.1, stanza 11).
> > Since you are *reading* only from the instruction word, you should get =
away
> > with accessor macros to extract the bits you need. For instance for
> > filtering the opcode, you could use: ((insn & 0x3fe00c00) =3D=3D 0x3840=
0400) =20
>=20
> Yes, this is a very good point. I will use bitmasks to access the bits=20
> from the register.
>=20
> I saw the same logic (ie using bitfields) is used for some other=20
> registers as well. For eg hsr_dabt, hsr_iabt in=20
> xen/include/asm-arm/hsr.h. May be that needs fixing as well for some=20
> other time. :)

(erroneously put that part already in the mail to Bertrand, for the
sake of completeness here it is again):

Well, there is no easy and clear answer as to whether to use bit-fields in
those occasions or not. From a practical point of view, it works (TM), and
has some advantages, like saving you from fiddling around with a 9-bit
sign extension, for instance.
But the Linux kernel discourages those works-for-me solutions, one killer
problem here is endianess, which is not a problem for Xen, IIRC.
I personally prefer robust code: by not relying on certain implementation
specifics (and be they very obvious or wide-spread), there will be less
surprises in the future.

So I'd leave this up to the maintainers to decide, IIUC the original
suggestion came from Bertrand?

Cheers,
Andre

> >> +        unsigned int rn:5;     /* Rn register */
> >> +        unsigned int fixed1:2; /* value =3D=3D 01b */
> >> +        int imm9:9;            /* imm9 */
> >> +        unsigned int fixed2:1; /* value =3D=3D 0b */
> >> +        unsigned int opc:2;    /* opc */
> >> +        unsigned int fixed3:2; /* value =3D=3D 00b */
> >> +        unsigned int v:1;      /* vector */
> >> +        unsigned int fixed4:3; /* value =3D=3D 111b */
> >> +        unsigned int size:2;   /* size */
> >> +    } code;
> >> +};
> >> +
> >>   union hsr {
> >>       register_t bits;
> >>       struct { =20
> >  =20



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:00:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:00:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235974.409319 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOHP-0003jd-JE; Wed, 01 Dec 2021 12:00:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235974.409319; Wed, 01 Dec 2021 12:00:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOHP-0003jW-G2; Wed, 01 Dec 2021 12:00:07 +0000
Received: by outflank-mailman (input) for mailman id 235974;
 Wed, 01 Dec 2021 12:00:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msOHO-0003Xe-6b; Wed, 01 Dec 2021 12:00:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msOHO-00034G-2H; Wed, 01 Dec 2021 12:00:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msOHN-0006TP-KP; Wed, 01 Dec 2021 12:00:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msOHN-0006qx-Jw; Wed, 01 Dec 2021 12:00:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=U3NP/xCRMjFw4QNrl35RU8ukqvHjG8QtVSorDse4BdQ=; b=ZF25TSaEYbBESWo3PnFcSrnbCC
	jkpVjFZa7l0mmS8LY8Ssol8gwL4Sqm7Ca4an+lUzCYGD1xyeV/F0ZceIQf8a6wtxwju3N2DIYLxAR
	8/8H+R4GLnZ1WIfWanmr6SNdOTDfRuC4G+3n6yroEei/mH5IQxVAzPn4+QJam/1011Z8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166965-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 166965: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4c8650ea987d269c27e5a7e7620cd2e45d6a2a52
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 12:00:05 +0000

flight 166965 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166965/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4c8650ea987d269c27e5a7e7620cd2e45d6a2a52
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  509 days
Failing since        151818  2020-07-11 04:18:52 Z  508 days  491 attempts
Testing same since   166965  2021-12-01 04:18:50 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 85318 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:01:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:01:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235986.409332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOIi-0004aO-V6; Wed, 01 Dec 2021 12:01:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235986.409332; Wed, 01 Dec 2021 12:01:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOIi-0004aH-SC; Wed, 01 Dec 2021 12:01:28 +0000
Received: by outflank-mailman (input) for mailman id 235986;
 Wed, 01 Dec 2021 12:01:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msOIi-0004a7-Eo
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 12:01:28 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 692b1b4c-529e-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 13:01:27 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34712)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msOIg-000rqh-8N (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 12:01:26 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 4DBFF1FDDA;
 Wed,  1 Dec 2021 12:01:26 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 692b1b4c-529e-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <66d9ffb0-a3c8-c8a8-18e6-9fc649ca2eff@srcf.net>
Date: Wed, 1 Dec 2021 12:01:26 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
 <2525b63f-f666-2430-2c22-b1b7b0d5d7f0@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/4] x86/PoD: simplify / improve p2m_pod_cache_add()
In-Reply-To: <2525b63f-f666-2430-2c22-b1b7b0d5d7f0@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 10:53, Jan Beulich wrote:
> Avoid recurring MFN -> page or page -> MFN translations. Drop the pretty
> pointless local variable "p". Make sure the MFN logged in a debugging
> error message is actually the offending one. Adjust style.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -58,14 +58,10 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>                    unsigned int order)
>  {
>      unsigned long i;
> -    struct page_info *p;
>      struct domain *d = p2m->domain;
> +    mfn_t mfn = page_to_mfn(page);
>  
>  #ifndef NDEBUG
> -    mfn_t mfn;
> -
> -    mfn = page_to_mfn(page);
> -
>      /* Check to make sure this is a contiguous region */
>      if ( mfn_x(mfn) & ((1UL << order) - 1) )
>      {
> @@ -74,17 +70,14 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>          return -1;
>      }
>  
> -    for ( i = 0; i < 1UL << order ; i++)
> +    for ( i = 0; i < (1UL << order); i++)
>      {
> -        struct domain * od;
> +        const struct domain *od = page_get_owner(page + i);
>  
> -        p = mfn_to_page(mfn_add(mfn, i));
> -        od = page_get_owner(p);
>          if ( od != d )
>          {
> -            printk("%s: mfn %lx expected owner d%d, got owner d%d!\n",
> -                   __func__, mfn_x(mfn), d->domain_id,
> -                   od ? od->domain_id : -1);
> +            printk("%s: mfn %lx owner: expected %pd, got %pd!\n",
> +                   __func__, mfn_x(mfn) + i, d, od);

Take the opportunity to drop the superfluous punctuation?


Looking through this code, no callers check for any errors, and the only
failure paths are in a debug region.  The function really ought to
become void, or at the very least, switch to -EINVAL to avoid aliasing
-EPERM.

Furthermore, in all(?) cases that it fails, we'll leak the domain
allocated page, which at the very best means the VM is going to hit
memory limit problems.  i.e. nothing good can come.

Both failures are internal memory handling errors in Xen, so the least
invasive option is probably to switch to ASSERT() (for the alignment
check), and ASSERT_UNREACHABLE() here.  That also addresses the issue
that these printk()'s aren't ratelimited, and used within several loops.

>              return -1;
>          }
>      }
> @@ -98,16 +91,12 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>       * promise to provide zero pages. So we scrub pages before using.
>       */
>      for ( i = 0; i < (1UL << order); i++ )
> -        clear_domain_page(mfn_add(page_to_mfn(page), i));
> +        clear_domain_page(mfn_add(mfn, i));

(For a future change,) this is double scrubbing in most cases.

~Andrew

>  
>      /* First, take all pages off the domain list */
>      lock_page_alloc(p2m);
> -    for ( i = 0; i < 1UL << order ; i++ )
> -    {
> -        p = page + i;
> -        page_list_del(p, &d->page_list);
> -    }
> -
> +    for ( i = 0; i < (1UL << order); i++ )
> +        page_list_del(page + i, &d->page_list);
>      unlock_page_alloc(p2m);
>  
>      /* Then add to the appropriate populate-on-demand list. */
>
>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:02:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:02:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.235993.409344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOJm-0005II-92; Wed, 01 Dec 2021 12:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 235993.409344; Wed, 01 Dec 2021 12:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOJm-0005IB-5T; Wed, 01 Dec 2021 12:02:34 +0000
Received: by outflank-mailman (input) for mailman id 235993;
 Wed, 01 Dec 2021 12:02:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gc09=QS=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msOJl-0005Hz-FO
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 12:02:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90131da2-529e-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 13:02:32 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-Ogo5UNmeNpaVxXOt9a57ZA-1; Wed, 01 Dec 2021 13:02:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7040.eurprd04.prod.outlook.com (2603:10a6:800:121::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Wed, 1 Dec
 2021 12:02:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Wed, 1 Dec 2021
 12:02:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0053.eurprd05.prod.outlook.com (2603:10a6:20b:489::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Wed, 1 Dec 2021 12:02:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90131da2-529e-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638360151;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+ZLyFXtU+qxq8Gam5maldnYSMZEm7r1hmDKd6T8okO8=;
	b=HuUby3UTIA2RKtD9ueEQl93e8k72v4YtdH0FDBI5F7a3v8Ufk0t7VAOCKonBDd2W3pWVl7
	m8qGRXOZ+E+4lr8s+QKwAyCx3n4X4aWHz8uGCBZ323CjPZC304cMx+l945yRujZUh+NeIY
	UZgCH2JOT7b4ijJJthymD4ymZ9bA/I8=
X-MC-Unique: Ogo5UNmeNpaVxXOt9a57ZA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TG29IB6FxAx7frFv8OgKgu2thOnNZrPvkNHRNb0cz2oxRQ+2JxefX2xlWJjsqzOoJscLiTGWHZ66/uAcwHxFe5BSN/zmxKJn2VFCF5KhAtuDgFuriNdXY/i6iORyyZeiT2fNbpwu3r2H+ZGkdnFOL20Nn5yHgqIx0Y2OTKGYOX6pWOZSlWi9+QnVXb7i/aPqMLU2qdFH26xFv8Adx34eqAyhaU+FADAKsjjZEl/EqsQ3poCEbyT6SsEuPttHD5EWQQypz5kif5H1BOwHkDeUCMagSxd4mGs5i9jOUy1zhc9u8op+Mk/2ctGBUJKCP0gVCr4ehbIyuK8LD5uBo/yF+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+ZLyFXtU+qxq8Gam5maldnYSMZEm7r1hmDKd6T8okO8=;
 b=PrJ7pBWUAOcMwvvgpRb3EfskxhSprhxYlfPw/Jd60CKZn2JgSeDAL4OAGlct5Oz5jCXJl66H00d3V83fgsOS0abDgXXlKl+vwkcO8lwGr8mMkJG1+LOdIXkAEfUugZwYM6ykBXnLr96IHQ/orbvFgGbQZldQ10JXlcvihC3xzPfETDbnH3v5Z9wcAzA5cwabUVZrSOoJ0vU6ncjTfwR/DLX+I3VG0d8hz9CY4VM7UeSSwLhLshAr5OwVP5JBkZFO+v+stVUXEWRC/dUSKIBnQ8Wkh1Qj0tXU5ka5Pmmrq80c129Xj1GIjcrxBzq7DfCz9bAJ2oh2cLfdJApVk8Xyeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7d85ed5b-a103-f953-5fca-f6b417cd2967@suse.com>
Date: Wed, 1 Dec 2021 13:02:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Content-Language: en-US
To: Andre Przywara <andre.przywara@arm.com>
Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org,
 stefanos@xilinx.com, julien@xen.org, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
 <20211130094950.1bf368d6@donnerap.cambridge.arm.com>
 <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
 <20211201115846.6f9b1d99@donnerap.cambridge.arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211201115846.6f9b1d99@donnerap.cambridge.arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0053.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: acf5e9d6-6462-4b76-ad9e-08d9b4c272ef
X-MS-TrafficTypeDiagnostic: VI1PR04MB7040:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7040E6C16C2641B7B0D59DE0B3689@VI1PR04MB7040.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZivaaIz+wsZrCDH5Gn1f4XEXZXeBzD9GCLzZ/88HkGfrF1B6Eh8qTiyxLDrlBr1GbI5xGuXNDL3CvJHmU2CvpKSs8PIg55lzHhPx9FUZQoIAlfpcjfCgLU3MfZDdBmUB2bWlFFDRQ6rFKfcCiRnc2PyO3yktTDnRPJPJz/JmiG0fyE4cqBzypqqskWOxZuDjsuB8eDVMJW/jFbhNN2AnHMDYy0iWTSHLcGoJ+Kl3ccP9YT/gWyjoQmpZT4WpW+y5c7qt3dl9IusFjjn6YkOKpbpRJtqpAanET/Q6KnLeBeBepaxa0uHsloKq93rUNv+Sb3xITTEjXF7W+j2JuaTrbcwiKnkK6Es4ad9+TqL3canjKsQrimZJeElqbAjeQcXbsanMks+6B5rGx6kDrsaSJ/sLyEXZIpNV7CT+rWu5xajuic4nXwaEDLgRXOWKckCdoblcLgd2F5Hd1UvDTxyuZmp1X9cvdR4xCdvM42Z6qiRNmxogQyZC9x43xUVag6S7MAo15qy/3U8qAJn3CDcvlo/vXKuE0JFoM3KIV7eTHJ8iAfXRqXAfOYmDDZcfFENTgNzfnUzSbgOnsXbNSysiflufn0FH4wBGtUVoHyXHMo3c2y4tlzm2sK7ARz+oOdaLJahe1/Kq9bV9YPesnE6ZtVP+KYVkNm82LmKo7dlQdFCD19URnh2SanKoP6xJqfjBOcFiF0nEJi+XCb+B7gU8PdzMhNODzQIiHYbS43Uerg0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66556008)(86362001)(956004)(8936002)(316002)(66476007)(8676002)(16576012)(6916009)(36756003)(83380400001)(2906002)(6486002)(38100700002)(31686004)(66946007)(5660300002)(53546011)(31696002)(186003)(4326008)(26005)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N05rQjNZZ1U0Wk9hMVU4OWxQZThIWU1XUlpGU3NIQkxvNXpLUndvbkV6c09R?=
 =?utf-8?B?Z0lzU05VNlhqcDZab2xMQVBLbzcyRVVqWTV2WEVqekIwc3paNE5jRlAweVNG?=
 =?utf-8?B?WGNPUFJzYU1BVmo4bEcwRWNLRmxxa0pVV0N0S01UZkhYbFNuVW1JQS85eWQv?=
 =?utf-8?B?TTRmd1BwaE1oWGVGWlVhUmJRWHFDekRzejJQWjZXSzc5dTYvRGxURWZWTEZu?=
 =?utf-8?B?dFVJYzdSWkROaDZoQXVzLzcxMndHam84SlNWekp6V3ozWlpPL1NwTzAzdG5J?=
 =?utf-8?B?RjAyYVVkcm4zZDVabzE0eVJyQ0xFS0s3SGRSTlNGRFVMT3NPa2ZrMDgyZ0NJ?=
 =?utf-8?B?c2ZGTTlpS2xWUUFIYlE1amIyWTA0SEd1N0FuTE8xYUVsTHhxbGIxd2U3Z0lM?=
 =?utf-8?B?ZnhQRklrdUlEV2NPNmhEaFIwb1BaOHdRbm11aDcxblJxandBTDdJbHI4YlMr?=
 =?utf-8?B?Q2cycmxIVjZKZFhOWGE0SzBZaTdkNzE2cFFkY1M4ZlJPa1dXVlF2ZUVHOFNO?=
 =?utf-8?B?azNLb0I0SGRyZ0Y0djI3b1MwRG5xNlpWYVNteEV5a1pUejcycDR2ZFY2REZx?=
 =?utf-8?B?VjQ2dTRaeEE1RlpwVS9qaUljNVhlTnlwVDNLclNCTE1oOVlMZVYreThUZVM4?=
 =?utf-8?B?eTMyUEdrNTVQZ3Npb3RkK0xhL3RKNVFYbmNWQmp2cnpGd1ZNQWJHdjNSVTdw?=
 =?utf-8?B?M0ovV05YQ29vWW9WdDBrcUNiTkxXTVZEMVZjZ0Rsa3pOclFaSEcxM25xM1pJ?=
 =?utf-8?B?UGY5S0F1VElZQ0FMYlRoNjdvTGszaVJ4emZvV2RWMCtMYTVIOEE0Sy85OTVF?=
 =?utf-8?B?L0crUU9ibE1HSWs3aEU5TFpNczFUQ05BbWVkclNtUzRaU3lNRTdqUTM0blpI?=
 =?utf-8?B?cW5INm56c245NDc1UHkvcXVndDlQMFdoMHE1eW14Sm1sSFF2WDVIN2duZVE0?=
 =?utf-8?B?U1BDanRPMmJlWWJGWFA4UHozZHRqbE5qQXZ4VDB4b3JwbXdrL1Y3UjRSakdC?=
 =?utf-8?B?bklhT2dtbjlObWFCMngyMnJudSsrK2cyT3dtWGdFdjhUbHU5Yk9ONmQ1bHIx?=
 =?utf-8?B?MEYvdVZQeExHdGFyYkRDOFJVK1JCdWU4Y0YwU2V1b3lscDJzcUNMbHNSUTdN?=
 =?utf-8?B?Rm02bXVaaUR6TzBGYmJ1SjFKNWpRZmhMMWtWMFJkU2pqQS81OUJiZm5uaWIv?=
 =?utf-8?B?YkZUS2l5OWo5SERtZlJOUU1BMVJEM3BRYXBiNVVXbTBkUHpVYlN4emZtOC9m?=
 =?utf-8?B?T3ovZGd3bnVyemhZQ0p2V2tRVk5JZmtXaUtwYk9SaWpNZDY0YU5kMm1lUTJl?=
 =?utf-8?B?OUtFNnRKQU5sNVR6N1pVbGtBSjB5RXVhTUVhMFNUWTAxUnR2bGloV3pKZ0J4?=
 =?utf-8?B?dzBoeGtqYnpvbzIvK3BYVVZRcEFOSXF0c1FjMHltdExvSFJQbldocVY3cW1h?=
 =?utf-8?B?eVZRSmpJUjUyNTBpd3FDbVI0ZFRVL0I5TTFuNFRNblJJenpMWTR6MDhwMlNi?=
 =?utf-8?B?eVBmRjg0RlJwM1ZXZjNaazhDWm1sVWNTcHdvV0cvaXU2THVIeVJmVkJPMWNB?=
 =?utf-8?B?SWduNVZRekkxL3JxSUV3WnM1cGtoUlEvdjV5aWM3UEhIWmpxcUt6L3VvaVRn?=
 =?utf-8?B?S0xtY3ZEYTBrMnpsV044Q21jM1laTlV3Ym9VRUNKam1XazJIekk3N2JsZXNO?=
 =?utf-8?B?ZllJczBCelBEU2k5QXpXaGRlSmtFU0VPOXVDU2xIUjM4cjgyc2E4Zi9RL3Bj?=
 =?utf-8?B?WE53MllCUzcwTE9XWjU4TzQwM3hQMXhXajdvdkVwdUx3WUk4dTEveVI0WEVX?=
 =?utf-8?B?UjdkVy8yT01iMDZyZ0d5NnIrZXFJQU9WYUR4WkQ4STFoa0R5NytNeWVhL3JJ?=
 =?utf-8?B?QWN3ODJhNUVxVmkzUy9KanpVbFI3T2phNkY5RTdwM3NZdEJ2OGZockQ2WmZm?=
 =?utf-8?B?d2dKY3NxVUlCWnlmcXpwU052NDJ4YUVFeUFvY3R4cy93L2tmc29aekpzQ21l?=
 =?utf-8?B?NHFOQ2REK2MzYmNwYmhodFphUXNrd2I4dzFNQXEvVVhlczB1MFBwNHlDZjZ1?=
 =?utf-8?B?QnowRXRacVZxbXl1SVdTYTR1RHFhYjRSb21kbFVlYk9RaWVoMHVzVFBCM0hr?=
 =?utf-8?B?OTVuQmpJdWZJWjczQVo0dzB6RkVUM3pjZ0hBdXd2SUNUTTBwd0FwTFErbEs2?=
 =?utf-8?Q?3A5gtvWd8U73hyqc4KHas4A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acf5e9d6-6462-4b76-ad9e-08d9b4c272ef
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2021 12:02:29.5860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l/47PrbAXsjfOohWLY0c4kXHuQKYXfvCuwQdBG9b2qDviC9x2rovBAtKbpb0wV5kwFmvscGiKaRrYMmyaE279Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7040

On 01.12.2021 12:58, Andre Przywara wrote:
> On Tue, 30 Nov 2021 19:13:41 +0000
> Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
>> On 30/11/2021 09:49, Andre Przywara wrote:
>>> On Mon, 29 Nov 2021 19:16:38 +0000
>>> Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
>>>> At the moment, Xen is only handling data abort with valid syndrome (i.e.
>>>> ISV=0). Unfortunately, this doesn't cover all the instructions a domain
>>>> could use to access MMIO regions.
>>>>
>>>> For instance, Xilinx baremetal OS will use:
>>>>
>>>>          volatile u32 *LocalAddr = (volatile u32 *)Addr;
>>>>          *LocalAddr = Value;
>>>>
>>>> This leave the compiler to decide which store instructions to use.  
>>>
>>> As mentioned in the other email, this is wrong, if this points to MMIO:
>>> don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
>>> an MMIO area, you should not see traps that you cannot handle already.
>>>
>>> So I don't think it's a good idea to use that as an example. And since
>>> this patch only seems to address this use case, I would doubt its
>>> usefulness in general.  
>> Yes, I should have fixed the comment.
>>
>> Currently, I am testing with baremetal app which uses inline assembly 
>> code with post indexing instructions, to access the MMIO.
>>
>> ATM, I am testing with 32 bit MMIO only.
>>
>> On the usefulness, I am kind of torn as it is legitimate for post 
>> indexing instructions to be used in an inline-assembly code for 
>> accessing MMIO. However, that may not be something commonly seen.
> 
> It is legitimate, but I question the usefulness: for a start it wouldn't
> work under today's Xen (or KVM), and I doubt this would be backported. So
> you would always require users to use the newest version of the hypervisor.
> Also MMIO accesses are slow anyway, so while using post-indexing might be
> convenient from an assembly writer's point of view, it doesn't give you
> much performance-wise, probably.

Just so it gets mentioned: Smaller code size may also be a consideration
here, beyond the more general one about performance.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:11:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:11:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236006.409358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOSW-000705-BT; Wed, 01 Dec 2021 12:11:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236006.409358; Wed, 01 Dec 2021 12:11:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOSW-0006zy-8B; Wed, 01 Dec 2021 12:11:36 +0000
Received: by outflank-mailman (input) for mailman id 236006;
 Wed, 01 Dec 2021 12:11:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3PTQ=QS=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1msOSU-0006zs-AZ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 12:11:34 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d29aa263-529f-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 13:11:33 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E8A001FD5B;
 Wed,  1 Dec 2021 12:11:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BF15313FFD;
 Wed,  1 Dec 2021 12:11:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1D7uLHRmp2G9GwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 01 Dec 2021 12:11:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d29aa263-529f-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638360692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1YUV5wxOjLIqUuxZrLNzd+eVOEZLmS/Z7hjQDREHtoo=;
	b=ETliDuntJOawegRckroXFIm8T40JDn2yfoz7cLwd6iIDbyjx6TXQ38OtWNEegBAOwA3FHJ
	TmOMm7o9s3aX5ymqGbVLj+CBGsyHUl4jyV2QY5T6ULtu9PCOT8XOhYt7d7PLY7dvKPEXQc
	20x4QjwYVUDES4wDQ1ZfhQoX8gErzFc=
Subject: Re: [PATCH 4/4] libxc: correct bounce direction in
 xc_get_device_group()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Ian Jackson <ian.jackson@citrix.com>,
 Wei Liu <wl@xen.org>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <16c6d0be-a779-b94a-4983-533fcecf0141@suse.com>
Date: Wed, 1 Dec 2021 13:11:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="CwA6JBvKjJqhFdMeiRQPdXyY3Xge5nhN3"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CwA6JBvKjJqhFdMeiRQPdXyY3Xge5nhN3
Content-Type: multipart/mixed; boundary="a6eMAiVrjl6qZhlewLa0sUqVGkrOvsU1U";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Ian Jackson <ian.jackson@citrix.com>,
 Wei Liu <wl@xen.org>
Message-ID: <16c6d0be-a779-b94a-4983-533fcecf0141@suse.com>
Subject: Re: [PATCH 4/4] libxc: correct bounce direction in
 xc_get_device_group()
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
In-Reply-To: <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>

--a6eMAiVrjl6qZhlewLa0sUqVGkrOvsU1U
Content-Type: multipart/mixed;
 boundary="------------3090B3EFE364F6875647B952"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------3090B3EFE364F6875647B952
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 01.12.21 10:42, Jan Beulich wrote:
> The array of IDs is an output.
>=20
> Fixes: 79647c5bc9c6 ("libxc: convert domctl interfaces over to hypercal=
l buffers")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------3090B3EFE364F6875647B952
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3090B3EFE364F6875647B952--

--a6eMAiVrjl6qZhlewLa0sUqVGkrOvsU1U--

--CwA6JBvKjJqhFdMeiRQPdXyY3Xge5nhN3
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGnZnQFAwAAAAAACgkQsN6d1ii/Ey+S
wQf/QtDBB/2r95cCAo+4APtvfh4wAqxyDbtzF6FcmhfRWB80acKf92PzdtoLmCf0W2qSDTgMPN8X
JBLPYMjbIX3hXYjj5tQSFMABrL2mkauMNrAtnbsB1kb6/qWYFN/iI9BJQr6qtDJ7ks+/KFyF8Fu4
SP4vDic1Vec3l7x3g0fZ+f+W9QWOL80BykaANGZLIn3azNiX/quc0VgqRNN4nD/4uWS7nAfKxwwl
Tvns74gYw9fX2jN62sVkThYQDxEHi5NCENgXbC/P85jg9UT58PfOpkX9iijzJwbwYwp0zHUwyayU
1eEXH/lFYjRzG37To3gpZpkXbCwEhrL5MuwxXaV2Gg==
=7rFl
-----END PGP SIGNATURE-----

--CwA6JBvKjJqhFdMeiRQPdXyY3Xge5nhN3--


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:22:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:22:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236011.409369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOcw-00009a-Cy; Wed, 01 Dec 2021 12:22:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236011.409369; Wed, 01 Dec 2021 12:22:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOcw-00009T-9B; Wed, 01 Dec 2021 12:22:22 +0000
Received: by outflank-mailman (input) for mailman id 236011;
 Wed, 01 Dec 2021 12:22:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msOcu-00009N-UF
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 12:22:20 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 54035f86-52a1-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 13:22:19 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34726)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msOct-000z1x-73 (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 12:22:19 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EC7771FDDA;
 Wed,  1 Dec 2021 12:22:18 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54035f86-52a1-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <bd4d66b3-a388-b3cf-2284-91c43bc3d99d@srcf.net>
Date: Wed, 1 Dec 2021 12:22:18 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/4] x86/PoD: HVM guests can't pin their pages
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
 <0ec2eb9c-a4b9-65c3-3751-3a7fb9b760c1@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <0ec2eb9c-a4b9-65c3-3751-3a7fb9b760c1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 10:53, Jan Beulich wrote:
> Pinning is a PV concept, used there only for page table pages.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Perhaps this is a leftover from autotranslate mode?  That was doing some
very HVM-like things for PV guests.

> ---
> I'm actually inclined to hide _PGT_pinned in !HVM builds; the downside
> of doing so is some new #ifdef-ary which would need adding.

Judging by the current users, I doubt it is worth it, although folding
this delta wouldn't go amiss.

diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
index cb9052749963..e5f63daa1a71 100644
--- a/xen/include/asm-x86/mm.h
+++ b/xen/include/asm-x86/mm.h
@@ -36,7 +36,7 @@
  /* Page is locked? */
 #define _PGT_locked       PG_shift(4)
 #define PGT_locked        PG_mask(1, 4)
- /* Owning guest has pinned this page to its current type? */
+ /* Owning guest has pinned this page to its current type? PV only */
 #define _PGT_pinned       PG_shift(5)
 #define PGT_pinned        PG_mask(1, 5)
  /* Has this page been validated for use as its current type? */

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 12:44:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 12:44:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236020.409380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOy8-0002n3-6s; Wed, 01 Dec 2021 12:44:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236020.409380; Wed, 01 Dec 2021 12:44:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msOy8-0002mw-3K; Wed, 01 Dec 2021 12:44:16 +0000
Received: by outflank-mailman (input) for mailman id 236020;
 Wed, 01 Dec 2021 12:44:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msOy7-0002mq-Hx
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 12:44:15 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62942c44-52a4-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 13:44:13 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40180)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msOy2-0011sW-oh (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 12:44:10 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id E949D1FDDA;
 Wed,  1 Dec 2021 12:44:09 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62942c44-52a4-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <420124f7-634d-8d9d-9cbe-34ed6a66d80f@srcf.net>
Date: Wed, 1 Dec 2021 12:44:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
 <09aaf19a-b03e-7f41-208e-bfc6bb968049@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/4] x86/altp2m: p2m_altp2m_get_or_propagate() should
 honor present page order
In-Reply-To: <09aaf19a-b03e-7f41-208e-bfc6bb968049@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 10:54, Jan Beulich wrote:
> @@ -2237,11 +2243,11 @@ bool p2m_altp2m_get_or_propagate(struct
>       * to the start of the superpage.  NB that we repupose `amfn`
>       * here.
>       */
> -    mask = ~((1UL << page_order) - 1);
> +    mask = ~((1UL << cur_order) - 1);
>      amfn = _mfn(mfn_x(*mfn) & mask);
>      gfn = _gfn(gfn_l & mask);
>  
> -    rc = p2m_set_entry(ap2m, gfn, amfn, page_order, *p2mt, *p2ma);
> +    rc = p2m_set_entry(ap2m, gfn, amfn, cur_order, *p2mt, *p2ma);
>      p2m_unlock(ap2m);

While I agree with the problem you've identified, this function has some
very broken return semantics.

Logically, it is taking some hostp2m properties for gfn, and replacing
them with ap2m properties for the same gfn.


It cannot be correct to only update the caller state on the error
paths.  At a minimum, the

    if ( paged )
        p2m_mem_paging_populate(currd, _gfn(gfn));

path in the success case is wrong when we've adjusted gfn down.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 13:02:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 13:02:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236028.409390 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msPFO-0005Ne-Ox; Wed, 01 Dec 2021 13:02:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236028.409390; Wed, 01 Dec 2021 13:02:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msPFO-0005NX-Lg; Wed, 01 Dec 2021 13:02:06 +0000
Received: by outflank-mailman (input) for mailman id 236028;
 Wed, 01 Dec 2021 13:02:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msPFN-0005NR-Jo
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 13:02:05 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e1b86530-52a6-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 14:02:04 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40184)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msPFL-000ywR-ob (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 13:02:03 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 14E3F1FDDA;
 Wed,  1 Dec 2021 13:02:03 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1b86530-52a6-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a6489b9f-6f93-94d9-549f-07fc761a4830@srcf.net>
Date: Wed, 1 Dec 2021 13:02:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Kevin Tian <kevin.tian@intel.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <8a8dd03a-5447-bc45-1554-50fb5b6c075c@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/4] VT-d: replace flush_all_cache()
In-Reply-To: <8a8dd03a-5447-bc45-1554-50fb5b6c075c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 09:41, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -591,7 +591,8 @@ static int __must_check iommu_flush_all(
>      bool_t flush_dev_iotlb;
>      int rc = 0;
>  
> -    flush_all_cache();
> +    flush_local(FLUSH_CACHE);

While I agree that the conversion is an improvement, the logic still
looks totally bogus.

I can believe that it might have been a stopgap to fix problems before
we identified the need for sync_cache() for non-coherent IOMMUs, but
there's no need I can spot for any WBINVDs on any of these paths.

I'm fairly sure this should just be dropped, and Xen will get faster as
a result.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 14:40:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 14:40:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236048.409408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msQlq-0006xS-1d; Wed, 01 Dec 2021 14:39:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236048.409408; Wed, 01 Dec 2021 14:39:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msQlp-0006xL-Td; Wed, 01 Dec 2021 14:39:41 +0000
Received: by outflank-mailman (input) for mailman id 236048;
 Wed, 01 Dec 2021 14:39:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msQlo-0006xF-RN
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 14:39:40 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 82efb41d-52b4-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 15:39:39 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43982)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msQlh-000cu0-1W (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 14:39:33 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 5416E1FC17;
 Wed,  1 Dec 2021 14:39:32 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 82efb41d-52b4-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <2a448375-6f57-578f-6ac3-ba818d0c2eb3@srcf.net>
Date: Wed, 1 Dec 2021 14:39:32 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Kevin Tian <kevin.tian@intel.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <e0819175-83b4-9489-8e4b-7be4940f1d54@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/4] VT-d / x86: re-arrange cache syncing
In-Reply-To: <e0819175-83b4-9489-8e4b-7be4940f1d54@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 09:40, Jan Beulich wrote:
> The actual function should always have lived in core x86 code; move it
> there, replacing get_cache_line_size() by readily available (except very
> early during boot; see the code comment) data.
>
> Drop the respective IOMMU hook, (re)introducing a respective boolean
> instead. Replace a true and an almost open-coding instance of
> iommu_sync_cache().

Coherency (or not) is a per-IOMMU property, not a global platform
property.  iGPU IOMMUs are very different to those the uncore, and
there's no reason to presume that IOMMUs in the PCH would have the same
properties as those in the uncore.

Given how expensive sync_cache() is, we cannot afford to be using it for
coherent IOMMUs in a mixed system.

This wants to be a boolean in arch_iommu.


> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Placing the function next to flush_area_local() exposes a curious
> asymmetry between the SFENCE placements: sync_cache() has it after the
> flush, while flush_area_local() has it before it. I think the latter one
> is misplaced.

Wow this is a mess.

First and foremost, AMD state that on pre-CLFLUSHOPT parts, CLFLUSH is
unordered with ~anything (including SFENCE), and need bounding with
MFENCE on both sides.  We definitely aren't doing this correctly right now.


AMD explicitly states that SFENCE drains the store and WC buffers (i.e.
make stuff instantaneously globally visible).  Intel does not, and
merely guarantees ordering.

A leading SFENCE would only make sense if there were WC concerns, but
both manuals say that the memory type doesn't matter, so I can't see a
justification for it.

What does matter, from the IOMMU's point of view, is that the line has
been written back (or evicted on pre-CLWB parts) before the IOTLB
invalidation occurs.  The invalidation will be a write to a different
address, which is why the trailing SFENCE is necessary, as CLFLUSHOPT
isn't ordered with respect to unaliasing writes.


On a more minor note, both Intel and AMD say that CLFLUSH* are permitted
to target an execute-only code segment, so we need a fix in
hvmemul_cache_op()'s use of hvmemul_virtual_to_linear(...,
hvm_access_read, ...) which will currently #GP in this case.

>
> --- a/xen/arch/x86/flushtlb.c
> +++ b/xen/arch/x86/flushtlb.c
> @@ -11,6 +11,7 @@
>  #include <xen/sched.h>
>  #include <xen/smp.h>
>  #include <xen/softirq.h>
> +#include <asm/cache.h>
>  #include <asm/flushtlb.h>
>  #include <asm/invpcid.h>
>  #include <asm/nops.h>
> @@ -265,6 +266,57 @@ unsigned int flush_area_local(const void
>      return flags;
>  }
>  
> +void sync_cache(const void *addr, unsigned int size)

Can we name this cache_writeback()?  sync is very generic, and it really
doesn't want confusing cache_flush().

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 15:12:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 15:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236056.409418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRGx-0002tC-Hq; Wed, 01 Dec 2021 15:11:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236056.409418; Wed, 01 Dec 2021 15:11:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRGx-0002t5-Eo; Wed, 01 Dec 2021 15:11:51 +0000
Received: by outflank-mailman (input) for mailman id 236056;
 Wed, 01 Dec 2021 15:11:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msRGw-0002sy-8z
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 15:11:50 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 00fa01d6-52b9-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 16:11:48 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50658)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msRGt-000gkq-iT (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 15:11:47 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 430F61FD7A;
 Wed,  1 Dec 2021 15:11:47 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00fa01d6-52b9-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <ae971612-71e2-2005-88cf-22006b7fc9b9@srcf.net>
Date: Wed, 1 Dec 2021 15:11:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Ian Jackson <ian.jackson@citrix.com>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 4/4] libxc: correct bounce direction in
 xc_get_device_group()
In-Reply-To: <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 09:42, Jan Beulich wrote:
> The array of IDs is an output.
>
> Fixes: 79647c5bc9c6 ("libxc: convert domctl interfaces over to hypercall buffers")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Clearly the function, including its Python wrapper, cannot have been
> used by anything for many years. I wonder whether that isn't good enough
> a reason to sanitize the layout of the array elements: Right now they
> have BDF in bits 8...23, when conventionally this would be bits 0...15.

There is a lot of WTF with this hypercall.  It's obviously an attempt to
do the thing that Linux calls IOMMU groups now, except that the correct
way to do this would be for the group ID to be the unit of
assignment/deassignment.  (We need to do this anyway for other reasons.)

The last user was deleted with Xend (2013), which suggests that it was
broken for 3 years due to the incorrect bounce direction (2010).

Furthermore, it will arbitrarily fail if targetting domains without an
IOMMU configured, but everything else seems to be invariant of the
passed domain.  This should clearly be sysctl, not a domctl.


I suggest ripping all of this infrastructure out.  It's clearly unused
(and broken in Xen too - see patch 1), and not something which should be
used in this form in the future.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 15:12:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 15:12:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236057.409429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRH2-00039t-QW; Wed, 01 Dec 2021 15:11:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236057.409429; Wed, 01 Dec 2021 15:11:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRH2-00039m-N3; Wed, 01 Dec 2021 15:11:56 +0000
Received: by outflank-mailman (input) for mailman id 236057;
 Wed, 01 Dec 2021 15:11:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msRH1-00039D-BG; Wed, 01 Dec 2021 15:11:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msRH1-0006IN-5C; Wed, 01 Dec 2021 15:11:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msRH0-0008MB-OV; Wed, 01 Dec 2021 15:11:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msRH0-0003er-Nw; Wed, 01 Dec 2021 15:11:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m6Ennh5mWKpC3LD8aGLGvRKuPnnLXt68kA/I3mhvN/A=; b=y1eVFxQ4yinsOefWDsJe0F0Xm7
	/W1sIHpu/Ak3ld4ZQCpqz6GF2Wqb0mUhDNnBBwdmXSpjYsJfiAmeik8D67atUAr/cjeOoWaJolmoq
	sdFnv0UExkGxHx022rIAAG/1vySOSlZhSHIxou408qRPd5n0GPBsow89WY5+V8Y5Ztfc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166966-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 166966: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start:fail:regression
    xen-unstable:test-amd64-i386-xl:guest-start:fail:regression
    xen-unstable:test-amd64-i386-pair:guest-start/debian:fail:regression
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:regression
    xen-unstable:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-stop.audited:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:regression
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 15:11:54 +0000

flight 166966 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166966/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-xsm      22 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl          14 guest-start              fail REGR. vs. 166941
 test-amd64-i386-xl           14 guest-start              fail REGR. vs. 166941
 test-amd64-i386-pair         25 guest-start/debian       fail REGR. vs. 166941
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install  fail REGR. vs. 166941
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 166941
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 23 guest-stop.audited fail REGR. vs. 166941
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-vhd     17 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-libvirt-raw 12 debian-di-install        fail REGR. vs. 166941
 test-armhf-armhf-xl-vhd     17 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166941

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166941

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds   22 guest-start/debian.repeat fail blocked in 166941
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    3 days
Failing since        166960  2021-11-30 12:35:41 Z    1 days    2 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         fail    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 396 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 15:14:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 15:14:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236070.409444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRJ0-00048z-GH; Wed, 01 Dec 2021 15:13:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236070.409444; Wed, 01 Dec 2021 15:13:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRJ0-00048s-Cg; Wed, 01 Dec 2021 15:13:58 +0000
Received: by outflank-mailman (input) for mailman id 236070;
 Wed, 01 Dec 2021 15:13:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msRIz-00048G-9x
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 15:13:57 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4d368db7-52b9-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 16:13:56 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40220)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msRIx-00058Y-oY (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 15:13:55 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6A4E81FD7A;
 Wed,  1 Dec 2021 15:13:55 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d368db7-52b9-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <3dbcb5ed-c776-84d8-92a7-b9d265ef7d7b@srcf.net>
Date: Wed, 1 Dec 2021 15:13:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <f7a7ce32-f921-ced7-4699-26f907392eb4@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/4] IOMMU/x86: switch to alternatives-call patching in
 further instances
In-Reply-To: <f7a7ce32-f921-ced7-4699-26f907392eb4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 09:39, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group(
>      if ( !is_iommu_enabled(d) || !ops->get_device_group_id )
>          return 0;
>  
> -    group_id = ops->get_device_group_id(seg, bus, devfn);
> +    group_id = iommu_call(ops, get_device_group_id, seg, bus, devfn);

So I was going to suggest adjusting this to use more pci_sbdf_t, but the
Intel implementation can fail and return -1.

However, given the observations in patch 4, I'd instead recommend
dropping all of this.

Everything unrelated to get_device_group() looks fine.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 15:41:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 15:41:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236078.409455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRih-0007ji-Ix; Wed, 01 Dec 2021 15:40:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236078.409455; Wed, 01 Dec 2021 15:40:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msRih-0007jb-Fg; Wed, 01 Dec 2021 15:40:31 +0000
Received: by outflank-mailman (input) for mailman id 236078;
 Wed, 01 Dec 2021 15:40:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msRig-0007jS-6M
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 15:40:30 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0258d2d4-52bd-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 16:40:28 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44000)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msRie-000Ia9-0b (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 15:40:28 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EFEDF1FDDA;
 Wed,  1 Dec 2021 15:40:27 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0258d2d4-52bd-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d2236719-7262-70e1-bbe8-c1a4cbc3b248@srcf.net>
Date: Wed, 1 Dec 2021 15:40:27 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <e698a39a-f9fc-18d7-07cd-d0b9da9c0eae@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/2] x86/PoD: move increment of entry count
In-Reply-To: <e698a39a-f9fc-18d7-07cd-d0b9da9c0eae@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 11:52, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/p2m-pod.c
> +++ b/xen/arch/x86/mm/p2m-pod.c
> @@ -1345,19 +1345,15 @@ mark_populate_on_demand(struct domain *d
>          }
>      }
>  
> +    pod_lock(p2m);
> +    p2m->pod.entry_count += (1UL << order) - pod_count;
> +    pod_unlock(p2m);
> +
>      /* Now, actually do the two-way mapping */
>      rc = p2m_set_entry(p2m, gfn, INVALID_MFN, order,
>                         p2m_populate_on_demand, p2m->default_access);
>      if ( rc == 0 )
> -    {
> -        pod_lock(p2m);
> -        p2m->pod.entry_count += 1UL << order;
> -        p2m->pod.entry_count -= pod_count;
> -        BUG_ON(p2m->pod.entry_count < 0);
> -        pod_unlock(p2m);
> -
>          ioreq_request_mapcache_invalidate(d);
> -    }
>      else if ( order )
>      {
>          /*
> @@ -1369,6 +1365,13 @@ mark_populate_on_demand(struct domain *d
>                 d, gfn_l, order, rc);
>          domain_crash(d);
>      }
> +    else if ( !pod_count )
> +    {
> +        pod_lock(p2m);
> +        BUG_ON(!p2m->pod.entry_count);
> +        --p2m->pod.entry_count;
> +        pod_unlock(p2m);
> +    }

This is very confusing logic to follow at the best of times.  Given that
the p2m is already locked, what's wrong with holding the pod_lock()
across p2m_set_entry()?

At the very least, this needs some comments helping to explain why these
two hunks are undo's of each other, given how differently they're written.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236086.409488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4e-0002zj-UT; Wed, 01 Dec 2021 16:03:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236086.409488; Wed, 01 Dec 2021 16:03:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4e-0002zW-R0; Wed, 01 Dec 2021 16:03:12 +0000
Received: by outflank-mailman (input) for mailman id 236086;
 Wed, 01 Dec 2021 16:03:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4d-0002Sl-6G
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:11 +0000
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
 [2607:f8b0:4864:20::1035])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2d256260-52c0-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 17:03:09 +0100 (CET)
Received: by mail-pj1-x1035.google.com with SMTP id
 gx15-20020a17090b124f00b001a695f3734aso2011642pjb.0
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:09 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d256260-52c0-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=i+xUpMEUxrmLaLZETYGitNsZhfrMVhJB1Bk6Yp08byU=;
        b=br/8rZr5MsJhI8n1irXI1gp9Qy4y2qB0ZN5gBXyv9j4Su5bhkV81nOXq9DGZu89aNd
         1yE59r1UZL97RAiD6x+SXTYEoUeu7G0jCsBQ1cuLrPvmNB9yCPuhglIAjJYi604mfSQh
         gyy1MrYjqf6FuZtwg+yZTOfgs9SEgL6VOT93jo6Lr0hZDIeKaRrkgfgJp35M71zw1HjF
         mCa+7WRc/5GxMq2fBfHGjWIosZhHgGj4pZbJ+Vjey1HAEvVpBkgPAoLT3LqFfLNjLY2o
         qMt8D2/BJNN7vwve4krmx/83c7M5pnGp6HV82Z4b4QIdszQpO2qvXOEgIjSwmrsLY0WX
         XfJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=i+xUpMEUxrmLaLZETYGitNsZhfrMVhJB1Bk6Yp08byU=;
        b=zR8eEruNpLtsIhFgjN+FOf7aLGPcqh/fUL7GMSV2KaQMDAJK8F3PG++KlQNEge6yMW
         ZLnu+FSd0wHhWmIVrxJw6DAprx6956QvOu3He8ENiGtUVjCccQL5WMq8Ndfaq85Co6nl
         1VxSSaKczV38VO3O1nFTTXswsw5JmULSw74WPHM40UBqf8TqXRi4yDfq28L6g1nxWrOs
         Vvu8j7xYrL1xWLWcnI/olXyy9JsItWR6DikZ+9lukZGkC3kFKVJVxW4k33ZWQOrjuqqV
         tl+7EMlTb1LxCbgh7fvoC/3hwAvM+Lh79ppK9P8SGOX/ygz+g5g602ecllhhYlVPswHh
         /gtg==
X-Gm-Message-State: AOAM5305aPlwQgvE8YGikVLBG9qyQ9PiW03YRVoiDkcQaEdUzB9lB6N1
	/85CLU7pe54674yZ2E6LSdE=
X-Google-Smtp-Source: ABdhPJzYMUML3tqpL7gDFerbs5Ms9xF8HxCcNqwI0mV93rIMF31+44VhoYZsU5gprIBYp9oOrgPvNQ==
X-Received: by 2002:a17:902:748c:b0:142:5f2f:1828 with SMTP id h12-20020a170902748c00b001425f2f1828mr8493620pll.4.1638374588262;
        Wed, 01 Dec 2021 08:03:08 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 2/5] x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has()
Date: Wed,  1 Dec 2021 11:02:53 -0500
Message-Id: <20211201160257.1003912-3-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211201160257.1003912-1-ltykernel@gmail.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

Hyper-V provides Isolation VM which has memory encrypt support. Add
hyperv_cc_platform_has() and return true for check of GUEST_MEM_ENCRYPT
attribute.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
 arch/x86/kernel/cc_platform.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/x86/kernel/cc_platform.c b/arch/x86/kernel/cc_platform.c
index 03bb2f343ddb..f3bb0431f5c5 100644
--- a/arch/x86/kernel/cc_platform.c
+++ b/arch/x86/kernel/cc_platform.c
@@ -11,6 +11,7 @@
 #include <linux/cc_platform.h>
 #include <linux/mem_encrypt.h>
 
+#include <asm/mshyperv.h>
 #include <asm/processor.h>
 
 static bool __maybe_unused intel_cc_platform_has(enum cc_attr attr)
@@ -58,9 +59,23 @@ static bool amd_cc_platform_has(enum cc_attr attr)
 #endif
 }
 
+static bool hyperv_cc_platform_has(enum cc_attr attr)
+{
+#ifdef CONFIG_HYPERV
+	if (attr == CC_ATTR_GUEST_MEM_ENCRYPT)
+		return true;
+	else
+		return false;
+#else
+	return false;
+#endif
+}
 
 bool cc_platform_has(enum cc_attr attr)
 {
+	if (hv_is_isolation_supported())
+		return hyperv_cc_platform_has(attr);
+
 	if (sme_me_mask)
 		return amd_cc_platform_has(attr);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236084.409466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4a-0002Sy-DJ; Wed, 01 Dec 2021 16:03:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236084.409466; Wed, 01 Dec 2021 16:03:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4a-0002Sr-AH; Wed, 01 Dec 2021 16:03:08 +0000
Received: by outflank-mailman (input) for mailman id 236084;
 Wed, 01 Dec 2021 16:03:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4Y-0002Sl-OX
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:06 +0000
Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com
 [2607:f8b0:4864:20::102d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ab4e199-52c0-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 17:03:05 +0100 (CET)
Received: by mail-pj1-x102d.google.com with SMTP id
 gx15-20020a17090b124f00b001a695f3734aso2011407pjb.0
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:05 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.03
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:03 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ab4e199-52c0-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=rlwCB8WctxDfzc6GjE9sqD8LeMvFTR6Cy4YHzp8XozM=;
        b=g65nlico0J7bcL2aCYAvGlzhTnCKVbRduh36LX8XvjEFFN6wHfS2L0u8BDmelEHEXY
         Wv2DKXAKifhTQ2TpjjT56A67ntJ/hLaAeFO4OjbN4Ti7m1iEE1qu9F65fiYof7/4PEPV
         ZCP/wMs4XoUk93Q/OO68b2EbvB6PER51u6kuhgNSK6ZzO9ZORgPO6UIUg5xjG8sFLdGd
         ls4FlMeHyYU9uABxxpZWR+w8CK7IGHVPGRX+JHnBOypkPhIhIwhSSMvJYvCaN/oA8IVr
         9XQqbYS4GRZB8sJJVE4lMBsN5HiN6zBTtQSYbnnf3R6OllAQ6RujK5AFIFhuwjrdXs5b
         YyRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=rlwCB8WctxDfzc6GjE9sqD8LeMvFTR6Cy4YHzp8XozM=;
        b=RU+hVMlK5Gu2Qi08LyUpmAc/HBjTYSp1ak2O+wI3ozHwI1anHNfvHmvKSEcI0lbA4l
         IG3uzZknLIeEz5qN7X6a7P3xU11wmRUCJxBn87VYQnVrvrdCu6gLVFPcA2OPGzidFHcW
         O+t+z2FU9ajkumA6k4/MWa8NWCIG67WcDaHzC7nJiYH0PwrCNTUHBJhQFMve6Lnsrd/c
         trgyk4Nxnf/ZzDffAn8xaLCy9umuwU/+Vklzs+13GTMl6nQarGzgLYq7sR+4WQjUWgkB
         sOsgoSxkEz81vzz6m+eLwGePvNu7zadA5UL1kWTLjABqBkfXFBZuoz4o5jCDeK/OeRzk
         zgEA==
X-Gm-Message-State: AOAM531ujNJfG2vwDpQRy+8yAeHqqmCUUegu8l/mP7C4VKUi+5mcjZvw
	vHWVsZPLtHqlkJIX7KOEQj4=
X-Google-Smtp-Source: ABdhPJzx8p2vypCygtN2v0ahrkMP7/JwVPIEscHdxdl4qbo3ST4qz0+r/UT4/nSDoAKM/Jt7Mpx/+Q==
X-Received: by 2002:a17:902:748c:b0:141:c45e:c612 with SMTP id h12-20020a170902748c00b00141c45ec612mr8329728pll.73.1638374584178;
        Wed, 01 Dec 2021 08:03:04 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 0/5] x86/Hyper-V: Add Hyper-V Isolation VM support(Second part)
Date: Wed,  1 Dec 2021 11:02:51 -0500
Message-Id: <20211201160257.1003912-1-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based
security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset
is to add support for these Isolation VM support in Linux.

The memory of these vms are encrypted and host can't access guest
memory directly. Hyper-V provides new host visibility hvcall and
the guest needs to call new hvcall to mark memory visible to host
before sharing memory with host. For security, all network/storage
stack memory should not be shared with host and so there is bounce
buffer requests.

Vmbus channel ring buffer already plays bounce buffer role because
all data from/to host needs to copy from/to between the ring buffer
and IO stack memory. So mark vmbus channel ring buffer visible.

For SNP isolation VM, guest needs to access the shared memory via
extra address space which is specified by Hyper-V CPUID HYPERV_CPUID_
ISOLATION_CONFIG. The access physical address of the shared memory
should be bounce buffer memory GPA plus with shared_gpa_boundary
reported by CPUID.

This patchset is to enable swiotlb bounce buffer for netvsc/storvsc
in Isolation VM.

This version follows Michael Kelley suggestion in the following link.
https://lkml.org/lkml/2021/11/24/2044

Change since v2:
     * Remove Hyper-V dma ops and dma_alloc/free_noncontiguous. Add
       hv_map/unmap_memory() to map/umap netvsc rx/tx ring into extra
       address space.
     * Leave mem->vaddr in swiotlb code with phys_to_virt(mem->start)
       when fail to remap swiotlb memory.

Change since v1:
     * Add Hyper-V Isolation support check in the cc_platform_has()
       and return true for guest memory encrypt attr.
     * Remove hv isolation check in the sev_setup_arch()

Tianyu Lan (5):
  Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM
  x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has()
  hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
  scsi: storvsc: Add Isolation VM support for storvsc driver
  hv_netvsc: Add Isolation VM support for netvsc driver

 arch/x86/hyperv/ivm.c             |  28 ++++++
 arch/x86/kernel/cc_platform.c     |  15 ++++
 arch/x86/xen/pci-swiotlb-xen.c    |   3 +-
 drivers/hv/hv_common.c            |  11 +++
 drivers/hv/vmbus_drv.c            |   4 +
 drivers/iommu/hyperv-iommu.c      |  56 ++++++++++++
 drivers/net/hyperv/hyperv_net.h   |   5 ++
 drivers/net/hyperv/netvsc.c       | 136 +++++++++++++++++++++++++++++-
 drivers/net/hyperv/netvsc_drv.c   |   1 +
 drivers/net/hyperv/rndis_filter.c |   2 +
 drivers/scsi/storvsc_drv.c        |  37 ++++----
 include/asm-generic/mshyperv.h    |   2 +
 include/linux/hyperv.h            |  14 +++
 include/linux/swiotlb.h           |   6 ++
 kernel/dma/swiotlb.c              |  47 +++++++++--
 15 files changed, 342 insertions(+), 25 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236087.409495 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4f-00036h-HY; Wed, 01 Dec 2021 16:03:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236087.409495; Wed, 01 Dec 2021 16:03:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4f-000357-AN; Wed, 01 Dec 2021 16:03:13 +0000
Received: by outflank-mailman (input) for mailman id 236087;
 Wed, 01 Dec 2021 16:03:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4e-0002Sl-6Y
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:12 +0000
Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com
 [2607:f8b0:4864:20::52a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2dff247e-52c0-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 17:03:11 +0100 (CET)
Received: by mail-pg1-x52a.google.com with SMTP id q16so24060421pgq.10
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:11 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2dff247e-52c0-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=wLAMPbpvKAZWRaOKURSZPZh3xKYj1Gt4MyClJOtgAw8=;
        b=QjTveNx4o5sgvmndH3bJITARz8VJfsr1N9XKDmWcLplouYsETdeAeVcMpTV5aL3RQc
         2Jbn1oE35+qrcZwO4MalG+vERTCir+RSo0cd6L5S6+ezjh9cOLpUmD94JFl3amTFgm5H
         GjCvjzVQEsrITTX50/38gC5ji5ccibs6LQnngjDJ7uJqC+GFq2dO66zseU8vSnFLFWhB
         492cwd2890tpGX8E2ksQAkURiM3+p+SmLfr/WT9HIYXSBPLSlIiguoogcrNSSOyiGvOv
         J+FjWE5u4IcpeznTj19LSiRN4ZQ4wkgR96nodqYpoXAGMncYd9kVEyh4dcZ+SRwE88Nr
         J/pA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=wLAMPbpvKAZWRaOKURSZPZh3xKYj1Gt4MyClJOtgAw8=;
        b=cBs9lToqUkvzmnel3MaZngW2kj+97yi5VXl+W55Ru65al01xmZrTpN3yGkQrfbIAuv
         Q5m1mANBRDI4Nl/wcnFquT7z1Ns6oVOb2Y/Z6hC4d1i/kA1EJ3eedCsaUJqM3KYUDiM+
         M2NvwmNhNII4uUx1ei3U8sFdDsOnUV/hUYfOOswWfZR2YxUaTTDYvOeru5AHFBTAWgVN
         GmU7GLSZ/aBITMM/QPpe1BguS9D5A4doNWUb7wy81QXbG9NFepPZB5/lZUUB9kJRGd0v
         HPwgssbDjkA2/2sMC9oZMhJHcygS7MZjVTOrH7McdeQk7xA2NdGM+Yrbq9ruLbD4P4xT
         Ch/A==
X-Gm-Message-State: AOAM531f/qcxII/UGPN+DRdvKCmRudnJZ/RHtCMjjuEgEyRADmBSZOuZ
	idEDdTh5bHwog3mfvq5Y7o4=
X-Google-Smtp-Source: ABdhPJwCOrEjcXULS6IsRuHQYw88ti0kK9hc/beS0BPepNxz/EDJIwT27gio08ZRg1Vj4i4WW4qECg==
X-Received: by 2002:a63:904a:: with SMTP id a71mr5401908pge.528.1638374589720;
        Wed, 01 Dec 2021 08:03:09 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
Date: Wed,  1 Dec 2021 11:02:54 -0500
Message-Id: <20211201160257.1003912-4-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211201160257.1003912-1-ltykernel@gmail.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

hyperv Isolation VM requires bounce buffer support to copy
data from/to encrypted memory and so enable swiotlb force
mode to use swiotlb bounce buffer for DMA transaction.

In Isolation VM with AMD SEV, the bounce buffer needs to be
accessed via extra address space which is above shared_gpa_boundary
(E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
The access physical address will be original physical address +
shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
spec is called virtual top of memory(vTOM). Memory addresses below
vTOM are automatically treated as private while memory above
vTOM is treated as shared.

Hyper-V initalizes swiotlb bounce buffer and default swiotlb
needs to be disabled. pci_swiotlb_detect_override() and
pci_swiotlb_detect_4gb() enable the default one. To override
the setting, hyperv_swiotlb_detect() needs to run before
these detect functions which depends on the pci_xen_swiotlb_
init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
_detect() to keep the order.

Swiotlb bounce buffer code calls set_memory_decrypted()
to mark bounce buffer visible to host and map it in extra
address space via memremap. Populate the shared_gpa_boundary
(vTOM) via swiotlb_unencrypted_base variable.

The map function memremap() can't work in the early place
hyperv_iommu_swiotlb_init() and so call swiotlb_update_mem_attributes()
in the hyperv_iommu_swiotlb_later_init().

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
 arch/x86/xen/pci-swiotlb-xen.c |  3 +-
 drivers/hv/vmbus_drv.c         |  3 ++
 drivers/iommu/hyperv-iommu.c   | 56 ++++++++++++++++++++++++++++++++++
 include/linux/hyperv.h         |  8 +++++
 4 files changed, 69 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
index 46df59aeaa06..30fd0600b008 100644
--- a/arch/x86/xen/pci-swiotlb-xen.c
+++ b/arch/x86/xen/pci-swiotlb-xen.c
@@ -4,6 +4,7 @@
 
 #include <linux/dma-map-ops.h>
 #include <linux/pci.h>
+#include <linux/hyperv.h>
 #include <xen/swiotlb-xen.h>
 
 #include <asm/xen/hypervisor.h>
@@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
 EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
 
 IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
-		  NULL,
+		  hyperv_swiotlb_detect,
 		  pci_xen_swiotlb_init,
 		  NULL);
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 392c1ac4f819..0a64ccfafb8b 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -33,6 +33,7 @@
 #include <linux/random.h>
 #include <linux/kernel.h>
 #include <linux/syscore_ops.h>
+#include <linux/dma-map-ops.h>
 #include <clocksource/hyperv_timer.h>
 #include "hyperv_vmbus.h"
 
@@ -2078,6 +2079,7 @@ struct hv_device *vmbus_device_create(const guid_t *type,
 	return child_device_obj;
 }
 
+static u64 vmbus_dma_mask = DMA_BIT_MASK(64);
 /*
  * vmbus_device_register - Register the child device
  */
@@ -2118,6 +2120,7 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 	}
 	hv_debug_add_dev_dir(child_device_obj);
 
+	child_device_obj->device.dma_mask = &vmbus_dma_mask;
 	return 0;
 
 err_kset_unregister:
diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
index e285a220c913..dd729d49a1eb 100644
--- a/drivers/iommu/hyperv-iommu.c
+++ b/drivers/iommu/hyperv-iommu.c
@@ -13,14 +13,20 @@
 #include <linux/irq.h>
 #include <linux/iommu.h>
 #include <linux/module.h>
+#include <linux/hyperv.h>
+#include <linux/io.h>
 
 #include <asm/apic.h>
 #include <asm/cpu.h>
 #include <asm/hw_irq.h>
 #include <asm/io_apic.h>
+#include <asm/iommu.h>
+#include <asm/iommu_table.h>
 #include <asm/irq_remapping.h>
 #include <asm/hypervisor.h>
 #include <asm/mshyperv.h>
+#include <asm/swiotlb.h>
+#include <linux/dma-direct.h>
 
 #include "irq_remapping.h"
 
@@ -337,4 +343,54 @@ static const struct irq_domain_ops hyperv_root_ir_domain_ops = {
 	.free = hyperv_root_irq_remapping_free,
 };
 
+static void __init hyperv_iommu_swiotlb_init(void)
+{
+	unsigned long hyperv_io_tlb_size;
+	void *hyperv_io_tlb_start;
+
+	/*
+	 * Allocate Hyper-V swiotlb bounce buffer at early place
+	 * to reserve large contiguous memory.
+	 */
+	hyperv_io_tlb_size = swiotlb_size_or_default();
+	hyperv_io_tlb_start = memblock_alloc(hyperv_io_tlb_size, PAGE_SIZE);
+
+	if (!hyperv_io_tlb_start)
+		pr_warn("Fail to allocate Hyper-V swiotlb buffer.\n");
+
+	swiotlb_init_with_tbl(hyperv_io_tlb_start,
+			      hyperv_io_tlb_size >> IO_TLB_SHIFT, true);
+}
+
+int __init hyperv_swiotlb_detect(void)
+{
+	if (!hypervisor_is_type(X86_HYPER_MS_HYPERV))
+		return 0;
+
+	if (!hv_is_isolation_supported())
+		return 0;
+
+	/*
+	 * Enable swiotlb force mode in Isolation VM to
+	 * use swiotlb bounce buffer for dma transaction.
+	 */
+	if (hv_isolation_type_snp())
+		swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
+	swiotlb_force = SWIOTLB_FORCE;
+	return 1;
+}
+
+static void __init hyperv_iommu_swiotlb_later_init(void)
+{
+	/*
+	 * Swiotlb bounce buffer needs to be mapped in extra address
+	 * space. Map function doesn't work in the early place and so
+	 * call swiotlb_update_mem_attributes() here.
+	 */
+	swiotlb_update_mem_attributes();
+}
+
+IOMMU_INIT_FINISH(hyperv_swiotlb_detect,
+		  NULL, hyperv_iommu_swiotlb_init,
+		  hyperv_iommu_swiotlb_later_init);
 #endif
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index b823311eac79..1f037e114dc8 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1726,6 +1726,14 @@ int hyperv_write_cfg_blk(struct pci_dev *dev, void *buf, unsigned int len,
 int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context,
 				void (*block_invalidate)(void *context,
 							 u64 block_mask));
+#if IS_ENABLED(CONFIG_HYPERV)
+int __init hyperv_swiotlb_detect(void);
+#else
+static inline int __init hyperv_swiotlb_detect(void)
+{
+	return 0;
+}
+#endif
 
 struct hyperv_pci_block_ops {
 	int (*read_block)(struct pci_dev *dev, void *buf, unsigned int buf_len,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236085.409477 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4d-0002j8-Lb; Wed, 01 Dec 2021 16:03:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236085.409477; Wed, 01 Dec 2021 16:03:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4d-0002iv-Hg; Wed, 01 Dec 2021 16:03:11 +0000
Received: by outflank-mailman (input) for mailman id 236085;
 Wed, 01 Dec 2021 16:03:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4c-0002Sl-6F
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:10 +0000
Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com
 [2607:f8b0:4864:20::102e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ceee8bd-52c0-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 17:03:09 +0100 (CET)
Received: by mail-pj1-x102e.google.com with SMTP id
 np6-20020a17090b4c4600b001a90b011e06so1985084pjb.5
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:09 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:05 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ceee8bd-52c0-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4faqUlJ+SZYnP9uFrNO41NoVrlsOh4d1PwMWVTDsii0=;
        b=EoEQhzYXyn/Uz+fYQL6+D8YgSqQQiHPwqGQJ6GM45qZKsFpcjhevIa8L/pl+sFAUkL
         6ilR5PMAfTa4GsQKH9BkVavcBWMKa3q095ZfyfDYU37jcqq/AZk4p28bXA3B30TG4Cep
         dbFjMch18yARC14F1a6g7hBovcdUv7sIZFsG7SgWxaROgr88xIIAt+ZoyIpLMF1rhMBD
         PTZFK0k8zcIn+A3NBF41yakdEyzg6WDCLGa3pEQwZyig4H4B9ik8x0c7UoU5nNLaGNYT
         FXj+LDj5JrE+2yeyXT9DMjB46S8nDNWguqmxDY7hZisVft7Wg4WHe66j7swhVwm+GYDc
         x0FA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4faqUlJ+SZYnP9uFrNO41NoVrlsOh4d1PwMWVTDsii0=;
        b=pBLOSncsOd4JwjM0PsC3EGlbbjJhY5VZ3Ig9mkZunCb+JHON95vEZuY6yCWscBFVO9
         SYLV+I5JhBYnrxCD6IOQoO9jauPXWnzgusWBom4z1X0iuKZCVr74aUkDDiLpBFjCkQDU
         OMKP+fAJMAxkcYkZzGy2zKyjGFefaeJEmGua2cIbHF75+cq1nk++BJ0xoqcKJ2suq6OG
         fGibbN/87oXzvBns/Hl6G8XbMlKu5Qcf4VfNUIUf6rB7n9HkvuNGCsM+c14WRjI9wH3/
         qg4e2Nqc7dmyLAUtXZ8eXGpE3oHHSvCvoH19F6t7CMM3mXuEM5UgqOQM54a5chbN8xWJ
         jwiQ==
X-Gm-Message-State: AOAM533eklnMaz2RTrr0gSIDqAJeMJpD0EEEGSh7gEMlxbqTvj/PMvkv
	KPfpei7a0pzWRxeoTneTce8=
X-Google-Smtp-Source: ABdhPJy1JxfjA/xzL4ufAFR3Zv/5zOIXPmdOHVJwpGxXD0b7sbTpoBxYwO/zTP0eS3+GqwpjJnNX9w==
X-Received: by 2002:a17:902:e5c9:b0:142:53c4:478d with SMTP id u9-20020a170902e5c900b0014253c4478dmr8110755plf.33.1638374585940;
        Wed, 01 Dec 2021 08:03:05 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM
Date: Wed,  1 Dec 2021 11:02:52 -0500
Message-Id: <20211201160257.1003912-2-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211201160257.1003912-1-ltykernel@gmail.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
extra address space which is above shared_gpa_boundary (E.G 39 bit
address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
physical address will be original physical address + shared_gpa_boundary.
The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
memory(vTOM). Memory addresses below vTOM are automatically treated as
private while memory above vTOM is treated as shared.

Expose swiotlb_unencrypted_base for platforms to set unencrypted
memory base offset and platform calls swiotlb_update_mem_attributes()
to remap swiotlb mem to unencrypted address space. memremap() can
not be called in the early stage and so put remapping code into
swiotlb_update_mem_attributes(). Store remap address and use it to copy
data from/to swiotlb bounce buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v2:
	* Leave mem->vaddr with phys_to_virt(mem->start) when fail
	  to remap swiotlb memory.

Change since v1:
	* Rework comment in the swiotlb_init_io_tlb_mem()
	* Make swiotlb_init_io_tlb_mem() back to return void.
---
 include/linux/swiotlb.h |  6 ++++++
 kernel/dma/swiotlb.c    | 47 ++++++++++++++++++++++++++++++++++++-----
 2 files changed, 48 insertions(+), 5 deletions(-)

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 569272871375..f6c3638255d5 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
  * @end:	The end address of the swiotlb memory pool. Used to do a quick
  *		range check to see if the memory was in fact allocated by this
  *		API.
+ * @vaddr:	The vaddr of the swiotlb memory pool. The swiotlb memory pool
+ *		may be remapped in the memory encrypted case and store virtual
+ *		address for bounce buffer operation.
  * @nslabs:	The number of IO TLB blocks (in groups of 64) between @start and
  *		@end. For default swiotlb, this is command line adjustable via
  *		setup_io_tlb_npages.
@@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
 struct io_tlb_mem {
 	phys_addr_t start;
 	phys_addr_t end;
+	void *vaddr;
 	unsigned long nslabs;
 	unsigned long used;
 	unsigned int index;
@@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct device *dev)
 }
 #endif /* CONFIG_DMA_RESTRICTED_POOL */
 
+extern phys_addr_t swiotlb_unencrypted_base;
+
 #endif /* __LINUX_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 8e840fbbed7c..adb9d06af5c8 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -50,6 +50,7 @@
 #include <asm/io.h>
 #include <asm/dma.h>
 
+#include <linux/io.h>
 #include <linux/init.h>
 #include <linux/memblock.h>
 #include <linux/iommu-helper.h>
@@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;
 
 struct io_tlb_mem io_tlb_default_mem;
 
+phys_addr_t swiotlb_unencrypted_base;
+
 /*
  * Max segment that we can provide which (if pages are contingous) will
  * not be bounced (unless SWIOTLB_FORCE is set).
@@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
 	return DIV_ROUND_UP(val, IO_TLB_SIZE);
 }
 
+/*
+ * Remap swioltb memory in the unencrypted physical address space
+ * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
+ * Isolation VMs).
+ */
+void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
+{
+	void *vaddr = NULL;
+
+	if (swiotlb_unencrypted_base) {
+		phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
+
+		vaddr = memremap(paddr, bytes, MEMREMAP_WB);
+		if (!vaddr)
+			pr_err("Failed to map the unencrypted memory %llx size %lx.\n",
+			       paddr, bytes);
+	}
+
+	return vaddr;
+}
+
 /*
  * Early SWIOTLB allocation may be too early to allow an architecture to
  * perform the desired operations.  This function allows the architecture to
@@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
 	vaddr = phys_to_virt(mem->start);
 	bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
 	set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
-	memset(vaddr, 0, bytes);
+
+	mem->vaddr = swiotlb_mem_remap(mem, bytes);
+	if (!mem->vaddr)
+		mem->vaddr = vaddr;
+
+	memset(mem->vaddr, 0, bytes);
 }
 
 static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
@@ -196,7 +225,18 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 		mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
 		mem->slots[i].alloc_size = 0;
 	}
+
+	/*
+	 * If swiotlb_unencrypted_base is set, the bounce buffer memory will
+	 * be remapped and cleared in swiotlb_update_mem_attributes.
+	 */
+	if (swiotlb_unencrypted_base)
+		return;
+
+	set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
 	memset(vaddr, 0, bytes);
+	mem->vaddr = vaddr;
+	return;
 }
 
 int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
@@ -318,7 +358,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
 	if (!mem->slots)
 		return -ENOMEM;
 
-	set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT);
 	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
 
 	swiotlb_print_info();
@@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
 	phys_addr_t orig_addr = mem->slots[index].orig_addr;
 	size_t alloc_size = mem->slots[index].alloc_size;
 	unsigned long pfn = PFN_DOWN(orig_addr);
-	unsigned char *vaddr = phys_to_virt(tlb_addr);
+	unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
 	unsigned int tlb_offset, orig_addr_offset;
 
 	if (orig_addr == INVALID_PHYS_ADDR)
@@ -806,8 +845,6 @@ static int rmem_swiotlb_device_init(struct reserved_mem *rmem,
 			return -ENOMEM;
 		}
 
-		set_memory_decrypted((unsigned long)phys_to_virt(rmem->base),
-				     rmem->size >> PAGE_SHIFT);
 		swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false);
 		mem->force_bounce = true;
 		mem->for_alloc = true;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236088.409509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4g-0003VH-QJ; Wed, 01 Dec 2021 16:03:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236088.409509; Wed, 01 Dec 2021 16:03:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4g-0003UB-LG; Wed, 01 Dec 2021 16:03:14 +0000
Received: by outflank-mailman (input) for mailman id 236088;
 Wed, 01 Dec 2021 16:03:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4f-00036S-Pf
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:13 +0000
Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com
 [2607:f8b0:4864:20::535])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ef5bb42-52c0-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 17:03:12 +0100 (CET)
Received: by mail-pg1-x535.google.com with SMTP id j11so14178272pgs.2
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:12 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ef5bb42-52c0-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=brPB+isubduGZ0dFkchshqyMjV+4uHMaO2+7Xc0wGRk=;
        b=ol7JPffN04vQ53Sc6PmIwt9AJnHuIprNjS1I1iRS8akXZTDcRlKSZFQEStI4fg7nPq
         PKhhLQN3DL34n4h2SPjnSHKXHLOFq2ooppEOuSJuwYkuJY1t8+I7NzrvyawNhu8eVdHr
         DIbRgN5vu3Eox4K1WBzR2RNEKez44cABxyfonHSZAPh5weJiyuxCoeDwAVyQfVfMXDTd
         UDXvY0+yrCz6xIODbtvqarLBiFpF6WbDyyYO2gGpNfyEoPU7sywPVUYfct/OMCv/nPbD
         YlXH9oUWuCi56KEjCSnvMxiQPy2eRyXksmh8Isp9ivEHstvRUhNFigiWI96VdPqvYP5Y
         zhyg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=brPB+isubduGZ0dFkchshqyMjV+4uHMaO2+7Xc0wGRk=;
        b=MdWSvHDe6MFcjPWW76utikLMpJGnnY7fk/26Epv/U074WV9syDvthG1TeDBDpAacAf
         NGyarXmz+qQkTq36Zjr8PCE5zU5LHq6u6xorgulgrlTyO3PCwoEDXrTyKN1nMSDU6Raq
         getSghEl9Y+bYvkjGq9x9eOxH5eI5aU80BUJtrp6ibSafAhP9V1lPkXRIAGLSM9m6K8U
         qsga3ZtdM2dLkVfs4JFUwy9w9RmIt7ahsDqDEe+5bSymOyk2Ul+DuB6Pp8Iw8wmqthcx
         m9lPyBW0F8mvbQDrUi1B47Lr9zeNjjVfvvUkNhx4YpgEVA0JE96QvyUozSM8jZ1eGIea
         xCyg==
X-Gm-Message-State: AOAM533SPzcDwkFg0gg1yawx7w7zXl8qzWBoL3HagqPPpvaNgZ8A5+1M
	+xehsTTFgicrMYYv8aKPYUM=
X-Google-Smtp-Source: ABdhPJy/Z0kfBd6gkK9iwSs8YNVwDZ0T1FdpARjeJ3PAZpPfADAvcKUirukf5mDtFZaBMsTJvFrCuw==
X-Received: by 2002:a63:57:: with SMTP id 84mr5195898pga.136.1638374591142;
        Wed, 01 Dec 2021 08:03:11 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 4/5] scsi: storvsc: Add Isolation VM support for storvsc driver
Date: Wed,  1 Dec 2021 11:02:55 -0500
Message-Id: <20211201160257.1003912-5-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211201160257.1003912-1-ltykernel@gmail.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM, all shared memory with host needs to mark visible
to host via hvcall. vmbus_establish_gpadl() has already done it for
storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_
mpb_desc() still needs to be handled. Use DMA API(scsi_dma_map/unmap)
to map these memory during sending/receiving packet and return swiotlb
bounce buffer dma address. In Isolation VM, swiotlb  bounce buffer is
marked to be visible to host and the swiotlb force mode is enabled.

Set device's dma min align mask to HV_HYP_PAGE_SIZE - 1 in order to
keep the original data offset in the bounce buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
 drivers/hv/vmbus_drv.c     |  1 +
 drivers/scsi/storvsc_drv.c | 37 +++++++++++++++++++++----------------
 include/linux/hyperv.h     |  1 +
 3 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 0a64ccfafb8b..ae6ec503399a 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -2121,6 +2121,7 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 	hv_debug_add_dev_dir(child_device_obj);
 
 	child_device_obj->device.dma_mask = &vmbus_dma_mask;
+	child_device_obj->device.dma_parms = &child_device_obj->dma_parms;
 	return 0;
 
 err_kset_unregister:
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 20595c0ba0ae..ae293600d799 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -21,6 +21,8 @@
 #include <linux/device.h>
 #include <linux/hyperv.h>
 #include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
+
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_host.h>
@@ -1336,6 +1338,7 @@ static void storvsc_on_channel_callback(void *context)
 					continue;
 				}
 				request = (struct storvsc_cmd_request *)scsi_cmd_priv(scmnd);
+				scsi_dma_unmap(scmnd);
 			}
 
 			storvsc_on_receive(stor_device, packet, request);
@@ -1749,7 +1752,6 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	struct hv_host_device *host_dev = shost_priv(host);
 	struct hv_device *dev = host_dev->dev;
 	struct storvsc_cmd_request *cmd_request = scsi_cmd_priv(scmnd);
-	int i;
 	struct scatterlist *sgl;
 	unsigned int sg_count;
 	struct vmscsi_request *vm_srb;
@@ -1831,10 +1833,11 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	payload_sz = sizeof(cmd_request->mpb);
 
 	if (sg_count) {
-		unsigned int hvpgoff, hvpfns_to_add;
 		unsigned long offset_in_hvpg = offset_in_hvpage(sgl->offset);
 		unsigned int hvpg_count = HVPFN_UP(offset_in_hvpg + length);
-		u64 hvpfn;
+		struct scatterlist *sg;
+		unsigned long hvpfn, hvpfns_to_add;
+		int j, i = 0;
 
 		if (hvpg_count > MAX_PAGE_BUFFER_COUNT) {
 
@@ -1848,21 +1851,22 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 		payload->range.len = length;
 		payload->range.offset = offset_in_hvpg;
 
+		sg_count = scsi_dma_map(scmnd);
+		if (sg_count < 0)
+			return SCSI_MLQUEUE_DEVICE_BUSY;
 
-		for (i = 0; sgl != NULL; sgl = sg_next(sgl)) {
+		for_each_sg(sgl, sg, sg_count, j) {
 			/*
-			 * Init values for the current sgl entry. hvpgoff
-			 * and hvpfns_to_add are in units of Hyper-V size
-			 * pages. Handling the PAGE_SIZE != HV_HYP_PAGE_SIZE
-			 * case also handles values of sgl->offset that are
-			 * larger than PAGE_SIZE. Such offsets are handled
-			 * even on other than the first sgl entry, provided
-			 * they are a multiple of PAGE_SIZE.
+			 * Init values for the current sgl entry. hvpfns_to_add
+			 * is in units of Hyper-V size pages. Handling the
+			 * PAGE_SIZE != HV_HYP_PAGE_SIZE case also handles
+			 * values of sgl->offset that are larger than PAGE_SIZE.
+			 * Such offsets are handled even on other than the first
+			 * sgl entry, provided they are a multiple of PAGE_SIZE.
 			 */
-			hvpgoff = HVPFN_DOWN(sgl->offset);
-			hvpfn = page_to_hvpfn(sg_page(sgl)) + hvpgoff;
-			hvpfns_to_add =	HVPFN_UP(sgl->offset + sgl->length) -
-						hvpgoff;
+			hvpfn = HVPFN_DOWN(sg_dma_address(sg));
+			hvpfns_to_add = HVPFN_UP(sg_dma_address(sg) +
+						 sg_dma_len(sg)) - hvpfn;
 
 			/*
 			 * Fill the next portion of the PFN array with
@@ -1872,7 +1876,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 			 * the PFN array is filled.
 			 */
 			while (hvpfns_to_add--)
-				payload->range.pfn_array[i++] =	hvpfn++;
+				payload->range.pfn_array[i++] = hvpfn++;
 		}
 	}
 
@@ -2016,6 +2020,7 @@ static int storvsc_probe(struct hv_device *device,
 	stor_device->vmscsi_size_delta = sizeof(struct vmscsi_win8_extension);
 	spin_lock_init(&stor_device->lock);
 	hv_set_drvdata(device, stor_device);
+	dma_set_min_align_mask(&device->device, HV_HYP_PAGE_SIZE - 1);
 
 	stor_device->port_number = host->host_no;
 	ret = storvsc_connect_to_vsp(device, storvsc_ringbuffer_size, is_fc);
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 1f037e114dc8..74f5e92f91a0 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1261,6 +1261,7 @@ struct hv_device {
 
 	struct vmbus_channel *channel;
 	struct kset	     *channels_kset;
+	struct device_dma_parameters dma_parms;
 
 	/* place holder to keep track of the dir for hv device in debugfs */
 	struct dentry *debug_dir;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:03:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236089.409521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4j-0003rB-5H; Wed, 01 Dec 2021 16:03:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236089.409521; Wed, 01 Dec 2021 16:03:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS4j-0003r0-0F; Wed, 01 Dec 2021 16:03:17 +0000
Received: by outflank-mailman (input) for mailman id 236089;
 Wed, 01 Dec 2021 16:03:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kkHa=QS=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1msS4h-00036S-FV
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:03:15 +0000
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com
 [2607:f8b0:4864:20::430])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2fe80ee4-52c0-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 17:03:14 +0100 (CET)
Received: by mail-pf1-x430.google.com with SMTP id g18so24957087pfk.5
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:03:14 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:f:7fe9:3f1e:749e:5d26])
 by smtp.gmail.com with ESMTPSA id i193sm260316pfe.87.2021.12.01.08.03.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 01 Dec 2021 08:03:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fe80ee4-52c0-11ec-b945-1df2895da90e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=P6jIP3T/88hcn+4uXsWHybVXUPopSAhJN5UnS1dO/gw=;
        b=YqhCgMqGGAoKeMbnI3JhHCwrCwNztDDwq0dloNgEJfqScbshgD99lN//qdQLoF5CWI
         DiPXmpGv8dU/Z5v003gLmrPGtN58HVvwBiD4yrNE9Gvcwz/FSTuC8I4h4MLMSBg9jEyG
         eHK/rKpJBB+8PDeMvLKL1ncl8KaL8HfwoXWhYeszYNzWCbj49prFTZn7yLPK0/ezUHQK
         JHoVvw0bvdf3BItAbYd7qEwM6bayMRNf9TBR9NyE3iZvAzI+ayVJeW+gBWWjueF+ndSS
         WClSs+QR5fpaYtbOYth6Xp159gD3qRU14EblzupnbexmzfiNLyGarogxPiTFUijueApY
         ZpIQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=P6jIP3T/88hcn+4uXsWHybVXUPopSAhJN5UnS1dO/gw=;
        b=TlSLIKWls6L+oAvgvbq1AJ1dgg0H3ncqnD8ZX+jiYDa06D+JaTODpNpe8jWMjxvvZ7
         0awinyJgCK4Sz9Pn9P0hVG1VOy0dSyunxPG5+M9S6kqTvIkNWEJ14Uo/idfYX1vHNtvN
         lioGDvy6uyd79wq+fbWT873OLw918PHHxG/hDuHL7GdvIWoGjt6aWS/o9KjHyfZzmpMN
         l0hSqPxqULSo6nRPMmjdLGCd3H0MtE784F6D+SUeMl6cAy8O5dj6eWRLwU6fIPY4BbbG
         e45EhddQ6aQYtUz1rtJUX/UruRWfwqc/ZGHQQqnuIoJbiMGsV5LgK61LWX5li6GrpmDb
         2akg==
X-Gm-Message-State: AOAM532Oer5/mK7qxu1r51Mzz5pTGXLGC0WAfas0Bh8MHpJ5iMiMc66d
	wFotE34dZsmALACHtkJLyxI=
X-Google-Smtp-Source: ABdhPJwC6+GxXgRAk+qDIq+YZnUASxcFMCjjXfGGpNikC86I7TygW1AcsqcU0QsuiH/J7Xyk7ymQUA==
X-Received: by 2002:a63:8541:: with SMTP id u62mr5146418pgd.433.1638374592680;
        Wed, 01 Dec 2021 08:03:12 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com,
	thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V3 5/5] hv_netvsc: Add Isolation VM support for netvsc driver
Date: Wed,  1 Dec 2021 11:02:56 -0500
Message-Id: <20211201160257.1003912-6-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211201160257.1003912-1-ltykernel@gmail.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM, all shared memory with host needs to mark visible
to host via hvcall. vmbus_establish_gpadl() has already done it for
netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_
pagebuffer() stills need to be handled. Use DMA API to map/umap
these memory during sending/receiving packet and Hyper-V swiotlb
bounce buffer dma adress will be returned. The swiotlb bounce buffer
has been masked to be visible to host during boot up.

rx/tx ring buffer is allocated via vzalloc() and they need to be
mapped into unencrypted address space(above vTOM) before sharing
with host and accessing. Add hv_map/unmap_memory() to map/umap rx
/tx ring buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v2:
       * Add hv_map/unmap_memory() to map/umap rx/tx ring buffer.
---
 arch/x86/hyperv/ivm.c             |  28 ++++++
 drivers/hv/hv_common.c            |  11 +++
 drivers/net/hyperv/hyperv_net.h   |   5 ++
 drivers/net/hyperv/netvsc.c       | 136 +++++++++++++++++++++++++++++-
 drivers/net/hyperv/netvsc_drv.c   |   1 +
 drivers/net/hyperv/rndis_filter.c |   2 +
 include/asm-generic/mshyperv.h    |   2 +
 include/linux/hyperv.h            |   5 ++
 8 files changed, 187 insertions(+), 3 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 69c7a57f3307..9f78d8f67ea3 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -287,3 +287,31 @@ int hv_set_mem_host_visibility(unsigned long kbuffer, int pagecount, bool visibl
 	kfree(pfn_array);
 	return ret;
 }
+
+/*
+ * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolation VM.
+ */
+void *hv_map_memory(void *addr, unsigned long size)
+{
+	unsigned long *pfns = kcalloc(size / HV_HYP_PAGE_SIZE,
+				      sizeof(unsigned long), GFP_KERNEL);
+	void *vaddr;
+	int i;
+
+	if (!pfns)
+		return NULL;
+
+	for (i = 0; i < size / PAGE_SIZE; i++)
+		pfns[i] = virt_to_hvpfn(addr + i * PAGE_SIZE) +
+			(ms_hyperv.shared_gpa_boundary >> PAGE_SHIFT);
+
+	vaddr = vmap_pfn(pfns, size / PAGE_SIZE, PAGE_KERNEL_IO);
+	kfree(pfns);
+
+	return vaddr;
+}
+
+void hv_unmap_memory(void *addr)
+{
+	vunmap(addr);
+}
diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index 7be173a99f27..3c5cb1f70319 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -295,3 +295,14 @@ u64 __weak hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_s
 	return HV_STATUS_INVALID_PARAMETER;
 }
 EXPORT_SYMBOL_GPL(hv_ghcb_hypercall);
+
+void __weak *hv_map_memory(void *addr, unsigned long size)
+{
+	return NULL;
+}
+EXPORT_SYMBOL_GPL(hv_map_memory);
+
+void __weak hv_unmap_memory(void *addr)
+{
+}
+EXPORT_SYMBOL_GPL(hv_unmap_memory);
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 315278a7cf88..cf69da0e296c 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -164,6 +164,7 @@ struct hv_netvsc_packet {
 	u32 total_bytes;
 	u32 send_buf_index;
 	u32 total_data_buflen;
+	struct hv_dma_range *dma_range;
 };
 
 #define NETVSC_HASH_KEYLEN 40
@@ -1074,6 +1075,7 @@ struct netvsc_device {
 
 	/* Receive buffer allocated by us but manages by NetVSP */
 	void *recv_buf;
+	void *recv_original_buf;
 	u32 recv_buf_size; /* allocated bytes */
 	struct vmbus_gpadl recv_buf_gpadl_handle;
 	u32 recv_section_cnt;
@@ -1082,6 +1084,7 @@ struct netvsc_device {
 
 	/* Send buffer allocated by us */
 	void *send_buf;
+	void *send_original_buf;
 	u32 send_buf_size;
 	struct vmbus_gpadl send_buf_gpadl_handle;
 	u32 send_section_cnt;
@@ -1731,4 +1734,6 @@ struct rndis_message {
 #define RETRY_US_HI	10000
 #define RETRY_MAX	2000	/* >10 sec */
 
+void netvsc_dma_unmap(struct hv_device *hv_dev,
+		      struct hv_netvsc_packet *packet);
 #endif /* _HYPERV_NET_H */
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 396bc1c204e6..b7ade735a806 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -153,8 +153,21 @@ static void free_netvsc_device(struct rcu_head *head)
 	int i;
 
 	kfree(nvdev->extension);
-	vfree(nvdev->recv_buf);
-	vfree(nvdev->send_buf);
+
+	if (nvdev->recv_original_buf) {
+		hv_unmap_memory(nvdev->recv_buf);
+		vfree(nvdev->recv_original_buf);
+	} else {
+		vfree(nvdev->recv_buf);
+	}
+
+	if (nvdev->send_original_buf) {
+		hv_unmap_memory(nvdev->send_buf);
+		vfree(nvdev->send_original_buf);
+	} else {
+		vfree(nvdev->send_buf);
+	}
+
 	kfree(nvdev->send_section_map);
 
 	for (i = 0; i < VRSS_CHANNEL_MAX; i++) {
@@ -338,6 +351,7 @@ static int netvsc_init_buf(struct hv_device *device,
 	unsigned int buf_size;
 	size_t map_words;
 	int i, ret = 0;
+	void *vaddr;
 
 	/* Get receive buffer area. */
 	buf_size = device_info->recv_sections * device_info->recv_section_size;
@@ -373,6 +387,17 @@ static int netvsc_init_buf(struct hv_device *device,
 		goto cleanup;
 	}
 
+	if (hv_isolation_type_snp()) {
+		vaddr = hv_map_memory(net_device->recv_buf, buf_size);
+		if (!vaddr) {
+			ret = -ENOMEM;
+			goto cleanup;
+		}
+
+		net_device->recv_original_buf = net_device->recv_buf;
+		net_device->recv_buf = vaddr;
+	}
+
 	/* Notify the NetVsp of the gpadl handle */
 	init_packet = &net_device->channel_init_pkt;
 	memset(init_packet, 0, sizeof(struct nvsp_message));
@@ -476,6 +501,17 @@ static int netvsc_init_buf(struct hv_device *device,
 		goto cleanup;
 	}
 
+	if (hv_isolation_type_snp()) {
+		vaddr = hv_map_memory(net_device->send_buf, buf_size);
+		if (!vaddr) {
+			ret = -ENOMEM;
+			goto cleanup;
+		}
+
+		net_device->send_original_buf = net_device->send_buf;
+		net_device->send_buf = vaddr;
+	}
+
 	/* Notify the NetVsp of the gpadl handle */
 	init_packet = &net_device->channel_init_pkt;
 	memset(init_packet, 0, sizeof(struct nvsp_message));
@@ -766,7 +802,7 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
 
 	/* Notify the layer above us */
 	if (likely(skb)) {
-		const struct hv_netvsc_packet *packet
+		struct hv_netvsc_packet *packet
 			= (struct hv_netvsc_packet *)skb->cb;
 		u32 send_index = packet->send_buf_index;
 		struct netvsc_stats *tx_stats;
@@ -782,6 +818,7 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
 		tx_stats->bytes += packet->total_bytes;
 		u64_stats_update_end(&tx_stats->syncp);
 
+		netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
 		napi_consume_skb(skb, budget);
 	}
 
@@ -946,6 +983,88 @@ static void netvsc_copy_to_send_buf(struct netvsc_device *net_device,
 		memset(dest, 0, padding);
 }
 
+void netvsc_dma_unmap(struct hv_device *hv_dev,
+		      struct hv_netvsc_packet *packet)
+{
+	u32 page_count = packet->cp_partial ?
+		packet->page_buf_cnt - packet->rmsg_pgcnt :
+		packet->page_buf_cnt;
+	int i;
+
+	if (!hv_is_isolation_supported())
+		return;
+
+	if (!packet->dma_range)
+		return;
+
+	for (i = 0; i < page_count; i++)
+		dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma,
+				 packet->dma_range[i].mapping_size,
+				 DMA_TO_DEVICE);
+
+	kfree(packet->dma_range);
+}
+
+/* netvsc_dma_map - Map swiotlb bounce buffer with data page of
+ * packet sent by vmbus_sendpacket_pagebuffer() in the Isolation
+ * VM.
+ *
+ * In isolation VM, netvsc send buffer has been marked visible to
+ * host and so the data copied to send buffer doesn't need to use
+ * bounce buffer. The data pages handled by vmbus_sendpacket_pagebuffer()
+ * may not be copied to send buffer and so these pages need to be
+ * mapped with swiotlb bounce buffer. netvsc_dma_map() is to do
+ * that. The pfns in the struct hv_page_buffer need to be converted
+ * to bounce buffer's pfn. The loop here is necessary because the
+ * entries in the page buffer array are not necessarily full
+ * pages of data.  Each entry in the array has a separate offset and
+ * len that may be non-zero, even for entries in the middle of the
+ * array.  And the entries are not physically contiguous.  So each
+ * entry must be individually mapped rather than as a contiguous unit.
+ * So not use dma_map_sg() here.
+ */
+int netvsc_dma_map(struct hv_device *hv_dev,
+		   struct hv_netvsc_packet *packet,
+		   struct hv_page_buffer *pb)
+{
+	u32 page_count =  packet->cp_partial ?
+		packet->page_buf_cnt - packet->rmsg_pgcnt :
+		packet->page_buf_cnt;
+	dma_addr_t dma;
+	int i;
+
+	if (!hv_is_isolation_supported())
+		return 0;
+
+	packet->dma_range = kcalloc(page_count,
+				    sizeof(*packet->dma_range),
+				    GFP_KERNEL);
+	if (!packet->dma_range)
+		return -ENOMEM;
+
+	for (i = 0; i < page_count; i++) {
+		char *src = phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT)
+					 + pb[i].offset);
+		u32 len = pb[i].len;
+
+		dma = dma_map_single(&hv_dev->device, src, len,
+				     DMA_TO_DEVICE);
+		if (dma_mapping_error(&hv_dev->device, dma)) {
+			kfree(packet->dma_range);
+			return -ENOMEM;
+		}
+
+		/* pb[].offset and pb[].len are not changed during dma mapping
+		 * and so not reassign.
+		 */
+		packet->dma_range[i].dma = dma;
+		packet->dma_range[i].mapping_size = len;
+		pb[i].pfn = dma >> HV_HYP_PAGE_SHIFT;
+	}
+
+	return 0;
+}
+
 static inline int netvsc_send_pkt(
 	struct hv_device *device,
 	struct hv_netvsc_packet *packet,
@@ -986,14 +1105,24 @@ static inline int netvsc_send_pkt(
 
 	trace_nvsp_send_pkt(ndev, out_channel, rpkt);
 
+	packet->dma_range = NULL;
 	if (packet->page_buf_cnt) {
 		if (packet->cp_partial)
 			pb += packet->rmsg_pgcnt;
 
+		ret = netvsc_dma_map(ndev_ctx->device_ctx, packet, pb);
+		if (ret) {
+			ret = -EAGAIN;
+			goto exit;
+		}
+
 		ret = vmbus_sendpacket_pagebuffer(out_channel,
 						  pb, packet->page_buf_cnt,
 						  &nvmsg, sizeof(nvmsg),
 						  req_id);
+
+		if (ret)
+			netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
 	} else {
 		ret = vmbus_sendpacket(out_channel,
 				       &nvmsg, sizeof(nvmsg),
@@ -1001,6 +1130,7 @@ static inline int netvsc_send_pkt(
 				       VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
 	}
 
+exit:
 	if (ret == 0) {
 		atomic_inc_return(&nvchan->queue_sends);
 
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 7e66ae1d2a59..17958533bf30 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -2512,6 +2512,7 @@ static int netvsc_probe(struct hv_device *dev,
 	net->netdev_ops = &device_ops;
 	net->ethtool_ops = &ethtool_ops;
 	SET_NETDEV_DEV(net, &dev->device);
+	dma_set_min_align_mask(&dev->device, HV_HYP_PAGE_SIZE - 1);
 
 	/* We always need headroom for rndis header */
 	net->needed_headroom = RNDIS_AND_PPI_SIZE;
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index f6c9c2a670f9..448fcc325ed7 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -361,6 +361,8 @@ static void rndis_filter_receive_response(struct net_device *ndev,
 			}
 		}
 
+		netvsc_dma_unmap(((struct net_device_context *)
+			netdev_priv(ndev))->device_ctx, &request->pkt);
 		complete(&request->wait_event);
 	} else {
 		netdev_err(ndev,
diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
index 3e2248ac328e..94e73ba129c5 100644
--- a/include/asm-generic/mshyperv.h
+++ b/include/asm-generic/mshyperv.h
@@ -269,6 +269,8 @@ bool hv_isolation_type_snp(void);
 u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_size);
 void hyperv_cleanup(void);
 bool hv_query_ext_cap(u64 cap_query);
+void *hv_map_memory(void *addr, unsigned long size);
+void hv_unmap_memory(void *addr);
 #else /* CONFIG_HYPERV */
 static inline bool hv_is_hyperv_initialized(void) { return false; }
 static inline bool hv_is_hibernation_supported(void) { return false; }
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 74f5e92f91a0..b53cfc4163af 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1584,6 +1584,11 @@ struct hyperv_service_callback {
 	void (*callback)(void *context);
 };
 
+struct hv_dma_range {
+	dma_addr_t dma;
+	u32 mapping_size;
+};
+
 #define MAX_SRV_VER	0x7ffffff
 extern bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp, u8 *buf, u32 buflen,
 				const int *fw_version, int fw_vercnt,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:06:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:06:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236111.409532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS7Z-00068b-Vb; Wed, 01 Dec 2021 16:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236111.409532; Wed, 01 Dec 2021 16:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msS7Z-00068U-Qv; Wed, 01 Dec 2021 16:06:13 +0000
Received: by outflank-mailman (input) for mailman id 236111;
 Wed, 01 Dec 2021 16:06:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msS7Y-00067q-AJ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:06:12 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9a1ec241-52c0-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 17:06:11 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44012)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msS7X-000wa5-1K (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 16:06:11 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 3F4751FF79;
 Wed,  1 Dec 2021 16:06:11 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a1ec241-52c0-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <39afb361-4047-68d1-acdd-e0838f52cb5f@srcf.net>
Date: Wed, 1 Dec 2021 16:06:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
 <e5070cbe-949a-4913-1f99-7b7a4e6c5536@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/2] x86/paging: tidy paging_mfn_is_dirty()
In-Reply-To: <e5070cbe-949a-4913-1f99-7b7a4e6c5536@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 10:35, Jan Beulich wrote:
> The function returning a boolean indicator, make it return bool. Also
> constify its struct domain parameter, albeit requiring to also adjust
> mm_locked_by_me(). Furthermore the function is used by shadow code only.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm/mm-locks.h
> +++ b/xen/arch/x86/mm/mm-locks.h
> @@ -40,7 +40,7 @@ static inline void mm_lock_init(mm_lock_
>      l->unlock_level = 0;
>  }
>  
> -static inline int mm_locked_by_me(mm_lock_t *l)
> +static inline int mm_locked_by_me(const mm_lock_t *l)

bool too?

>  {
>      return (l->lock.recurse_cpu == current->processor);
>  }
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -351,14 +351,14 @@ void paging_mark_dirty(struct domain *d,
>      paging_mark_pfn_dirty(d, pfn);
>  }
>  
> -
> +#ifdef CONFIG_SHADOW_PAGING
>  /* Is this guest page dirty? */
> -int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn)
> +bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn)
>  {
>      pfn_t pfn;
>      mfn_t mfn, *l4, *l3, *l2;
>      unsigned long *l1;
> -    int rv;
> +    bool dirty;
>  
>      ASSERT(paging_locked_by_me(d));
>      ASSERT(paging_mode_log_dirty(d));
> @@ -367,36 +367,37 @@ int paging_mfn_is_dirty(struct domain *d
>      pfn = _pfn(get_gpfn_from_mfn(mfn_x(gmfn)));

There's nothing inherently paging.c related about this function. 
Thoughts on moving the implementation across, rather than #ifdef-ing it?

If not, can we at least correct gmfn to mfn here and in the prototype?

Alternatively, do we want to start putting things like this in a real
library so we can have the toolchain figure this out automatically?

>      /* Invalid pages can't be dirty. */
>      if ( unlikely(!VALID_M2P(pfn_x(pfn))) )
> -        return 0;
> +        return false;
>  
>      mfn = d->arch.paging.log_dirty.top;
>      if ( !mfn_valid(mfn) )

These don't need to be mfn_valid().  They can be checks against
MFN_INVALID instead, because the logdirty bitmap is a Xen internal
structure.

In response to your comment in the previous patch, this would
substantially reduce the overhead of paging_mark_pfn_dirty() and
paging_mfn_is_dirty().

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:13:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:13:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236119.409542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSEp-0007kO-M6; Wed, 01 Dec 2021 16:13:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236119.409542; Wed, 01 Dec 2021 16:13:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSEp-0007kH-J8; Wed, 01 Dec 2021 16:13:43 +0000
Received: by outflank-mailman (input) for mailman id 236119;
 Wed, 01 Dec 2021 16:13:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msSEn-0007kB-Tw
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:13:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSEl-0007vO-HS; Wed, 01 Dec 2021 16:13:39 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSEl-0000Em-BD; Wed, 01 Dec 2021 16:13:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ODZ3wX3gUKpBXwSTHsywzaY+em5RuIrZN/pOW8HuGao=; b=G1u+pZTFttfMlOj6fyEFedN//i
	H4Gop9sWpSzfDjxJQrlD6OTp2txQM768qivF8qeSgRcMhRe/0UleIjX90nFUvBvfdAUvxV+Cg/6GU
	2pq9jBo4/YltaVv6n0iEUSchztzJ6iiXEf3MnVm4NpNmni6Uy8lHxubQf3+KhM7gxtRM=;
Message-ID: <1754aeef-f028-0901-edac-09565a1e4956@xen.org>
Date: Wed, 1 Dec 2021 16:13:37 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH RFC] SUPPORT.md: limit security support for hosts with
 very much memory
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <fff23663-b114-0726-e37f-06461b5ea63d@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <fff23663-b114-0726-e37f-06461b5ea63d@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 30/11/2021 16:14, Jan Beulich wrote:
> Sufficient and in particular regular testing on very large hosts cannot
> currently be guaranteed. Anyone wanting us to support larger hosts is
> free to propose so, but will need to supply not only test results, but
> also a test plan.
> 
> This is a follow-up to XSA-385.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> 
> --- unstable.orig/SUPPORT.md	2021-06-25 11:19:03.000000000 +0200
> +++ unstable/SUPPORT.md	2021-09-10 11:15:52.270364645 +0200
> @@ -48,6 +48,12 @@ For the Cortex A57 r0p0 - r1p1, see Erra
>   
>       Status, x86: Supported
>   
> +### Physical Memory
> +
> +    Status: Supported up to 8 TiB
> +
> +Hosts with more memory are supported, but not security supported.
> +
>   ### Physical Memory Hotplug
>   
>       Status, x86: Supported
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:22:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:22:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236123.409554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSN8-0000so-II; Wed, 01 Dec 2021 16:22:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236123.409554; Wed, 01 Dec 2021 16:22:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSN8-0000sh-EQ; Wed, 01 Dec 2021 16:22:18 +0000
Received: by outflank-mailman (input) for mailman id 236123;
 Wed, 01 Dec 2021 16:22:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msSN7-0000sb-3z
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:22:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSN5-00083m-LC; Wed, 01 Dec 2021 16:22:15 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSN5-0000lp-CL; Wed, 01 Dec 2021 16:22:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VFQVubdJcVarI3a8Jxa2tWhAoVXZdOKbQMmcgnIGP6Y=; b=HbQD5w7wbwQLa+L6A1cQobtx8x
	kusB9h952dE6O6mLNdn+pnMZHU2dkqSWBdLHZXgPX6KEQbxiMoydHT1aFFavIjGkE0K36aZrv1P3m
	ian8XfCKP09Syfc7XZp69SJAiaM4PnYIkx3i2sQNL1UopjBdIb8hosPrBzKwFZiSUPu8=;
Message-ID: <a5aa0a6a-3765-9395-026f-3bfd88bba354@xen.org>
Date: Wed, 1 Dec 2021 16:22:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on
 Arm
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com>
 <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
 <89f27a30-187c-6223-9dbb-1e3f52213868@gmail.com>
 <15a507c7-17e3-6e48-152d-32f54b362889@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <15a507c7-17e3-6e48-152d-32f54b362889@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 29/11/2021 15:58, Oleksandr wrote:
> 
> Hi Julien

Hi,

> 
> 
> [snip]
> 
> 
>>
>>>>
>>>> ! Please note, there is still unresolved locking question here for 
>>>> which
>>>> I failed to find a suitable solution. So, it is still an RFC !
>>>>
>>>> According to the internal conversation:
>>>> Now the GFN field in the struct page_info is accessed from
>>>> gnttab_set_frame_gfn() in the grant table code and from 
>>>> page_set_frame_gfn()
>>>> in the P2M code (the former uses the latter).
>>>>
>>>> We need to prevent the concurrent access to this field. But, we 
>>>> cannot grab
>>>> the grant lock from the P2M code because we will introduce a lock 
>>>> inversion.
>>>> The page_set_frame_gfn() will be called from the P2M code with the 
>>>> p2m lock held
>>>> and then acquire the grant table lock. The gnttab_map_frame() will 
>>>> do the inverse.
>>>
>>> This is a tricky one. I think, we will:
>>>
>>>   1) Need to use the P2M lock to protect the access to the GFN in the 
>>> struct page_info *.
>>>   2) Defer the call to page_set_frame_gfn() from gnttab_map_frame() 
>>> to xenmem_add_to_physmap_one()
>>>   3) In xenmem_add_to_physmap_one() hold the P2M lock while checking 
>>> the page was not already mapped (e.g. page_get_frame_gfn() == 
>>> INVALID_GFN) and do the mapping. Call page_set_frame_gfn() on success.
>>>
>>> This would still allow the guest to shot itself in the foot (e.g. 
>>> potentially removing the wrong mapping) if it tries concurrent 
>>> hypercall but I believe we would not introduce issue like XSA-380.
>>>
>>> At the end this would look quite similar to how x86 deal with the M2P 
>>> update.
>>
>> Thank you for the suggestion, I need to analyze the code to better 
>> understand your idea and technical possibility to implement it, I will 
>> come up with questions if any.
> 
> I experimented a bit... Could you please clarify, is the code snippet 
> below is close to what you meant?

It is close to what I had in my mind. A few comments below.

> 
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index b594db4..dba9258 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1488,8 +1488,27 @@ int xenmem_add_to_physmap_one(
>           return -ENOSYS;
>       }
> 
> -    /* Map at new location. */
> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    if ( space != XENMAPSPACE_grant_table )

I would consider to use this approach for any xenheap pages.

> +        /* Map at new location. */
> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    else
> +    {
> +#ifdef CONFIG_GRANT_TABLE
> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +
> +        p2m_write_lock(p2m);
> +        if ( gfn_eq(page_get_frame_gfn(page), INVALID_GFN) )

I think we want to return an error if page_get_frame_gfn() return a 
valid GFN.

> +        {
> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access);
> +            if ( !rc )
> +                page_set_frame_gfn(page, gfn);
> +        }
> +        p2m_write_unlock(p2m);
> +#else
> +        ASSERT_UNREACHABLE();
> +        rc = -EINVAL;
> +#endif
> +    }
> 
>       /*
>        * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, 
> we need
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index 59604b1..64e9e77 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -4167,10 +4167,8 @@ int gnttab_map_frame(struct domain *d, unsigned 
> long idx, gfn_t gfn, mfn_t *mfn)
>            * Make sure gnttab_unpopulate_status_frames() won't 
> (successfully)
>            * free the page until our caller has completed its operation.
>            */
> -        if ( get_page(mfn_to_page(*mfn), d) )
> -            gnttab_set_frame_gfn(gt, status, idx, gfn);
> -        else
> -            rc = -EBUSY;
> +        if ( !get_page(mfn_to_page(*mfn), d) )
> +           rc = -EBUSY;
>       }
> 
>       grant_write_unlock(gt);
> (END)
> 
> If yes *and* I correctly understand the code, then looks like 
> gnttab_set_frame_gfn becomes useless on Arm and can be dropped globally 
> (x86's variant is already dummy).

It will not be a dummy version soon see [1].

Cheers,

[1] 
https://lore.kernel.org/xen-devel/8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:32:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:32:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236129.409564 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSWc-0002U3-Gt; Wed, 01 Dec 2021 16:32:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236129.409564; Wed, 01 Dec 2021 16:32:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSWc-0002Tw-Dl; Wed, 01 Dec 2021 16:32:06 +0000
Received: by outflank-mailman (input) for mailman id 236129;
 Wed, 01 Dec 2021 16:32:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msSWb-0002Tq-Ro
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:32:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSWa-0008Ew-IF; Wed, 01 Dec 2021 16:32:04 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msSWa-0001AJ-BI; Wed, 01 Dec 2021 16:32:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=rukXyaclqelQPFJHpnYvXG9RfVg4W/YjdsyAKr3PS3Q=; b=tXYqg6XIMoGXKG2i0GDIkR8AIc
	LcLd5tnoDSU75hoIqpDahsPFMUZokCUGkHGsLNV5o7T35DePWp4efMyeDasA5qrFMxLJM8eMrOH7V
	EVG/jiw8rWvPq865iZ7W5mC4xLQhYUaVXTP/3oKkOpuFFn3aL2FqtOWqO1Lf+iRn8wtc=;
Message-ID: <d64d4bdc-a8bb-349c-b4b5-7c3a887e1621@xen.org>
Date: Wed, 1 Dec 2021 16:32:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on
 Arm
To: Oleksandr <olekstysh@gmail.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com>
 <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
 <89f27a30-187c-6223-9dbb-1e3f52213868@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <89f27a30-187c-6223-9dbb-1e3f52213868@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 26/11/2021 13:51, Oleksandr wrote:
> On 25.11.21 21:04, Julien Grall wrote:
>>>   {
>>> +    mfn_t mfn = lpae_get_mfn(pte);
>>> +
>>>       ASSERT(p2m_is_valid(pte));
>>>         /*
>>> @@ -731,11 +733,22 @@ static void p2m_put_l3_page(const lpae_t pte)
>>>        */
>>>       if ( p2m_is_foreign(pte.p2m.type) )
>>>       {
>>> -        mfn_t mfn = lpae_get_mfn(pte);
>>> -
>>>           ASSERT(mfn_valid(mfn));
>>>           put_page(mfn_to_page(mfn));
>>>       }
>>> +
>>> +#ifdef CONFIG_GRANT_TABLE
>>> +    /*
>>> +     * Check whether we deal with grant table page. As the grant 
>>> table page
>>> +     * is xen_heap page and its entry has known p2m type, detect it 
>>> and mark
>>> +     * the stored GFN as invalid. Although this check is not precise 
>>> and we
>>> +     * might end up updating this for other xen_heap pages, this 
>>> action is
>>> +     * harmless to these pages since only grant table pages have 
>>> this field
>>> +     * in use. So, at worst, unnecessary action might be performed.
>>> +     */
>>> +    if ( (pte.p2m.type == p2m_ram_rw) && is_xen_heap_mfn(mfn) )
>>
>> I would use p2m_is_ram() to cover read-only mapping. I think it would 
>> also be better to use an ``else if`` so it is clear that this doesn't 
>> cover foreign mapping (it is possible to map xenheap page from another 
>> domain).
> 
> ok, will use p2m_is_ram() and ``else if`` construct, however I don't 
> entirely understand why we also want/need to include read-only pages (as 
> type is set to p2m_ram_rw in xenmem_add_to_physmap_one() for case 
> XENMAPSPACE_grant_table)?

Most of this code is already ready to be used by other xenheap pages 
(see other part of the discussion). So I would like to use p2m_is_ram()
as it reduces the risk of us forgetting that read-only are not handled.
  [...]

>>> + page_get_frame_gfn(pg_); \
>>> +})
>>>     #define gnttab_need_iommu_mapping(d)                    \
>>>       (is_domain_direct_mapped(d) && is_iommu_enabled(d))
>>> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
>>> index 7b5e7b7..a00c5f5 100644
>>> --- a/xen/include/asm-arm/mm.h
>>> +++ b/xen/include/asm-arm/mm.h
>>> @@ -98,9 +98,17 @@ struct page_info
>>>   #define PGT_writable_page PG_mask(1, 1)  /* has writable 
>>> mappings?         */
>>>   #define PGT_type_mask     PG_mask(1, 1)  /* Bits 31 or 
>>> 63.                 */
>>>   - /* Count of uses of this frame as its current type. */
>>> -#define PGT_count_width   PG_shift(2)
>>> -#define PGT_count_mask    ((1UL<<PGT_count_width)-1)
>>> + /* 2-bit count of uses of this frame as its current type. */
>>> +#define PGT_count_mask    PG_mask(3, 3)
>>> +
>>> +/*
>>> + * Stored in bits [28:0] or [60:0] GFN if page is used for grant 
>>> table frame.
>>
>> I think this wording is conflicting with ...
>>
>>> + * This only valid for the xenheap pages.
>>
>> ... this becase xen heap pages are used in other situations. But I 
>> would prefer if the comment doesn't mention grant-table frame. This 
>> would allow use to repurpose the field for other xenheap if needed.
>>
>> Typo: This *is* only valid
> 
> 
> ok, so how about to simply mention it's purpose as xenheap GFN here and 
> down this header?
> 
> For example,
> Stored in bits [28:0] or [60:0] GFN if page is xenheap page.
> 
> BTW, shall I rename the access helpers page_set(get)_frame_gfn() as 
> well? For me the frame is associated with grant-table.
> Something to: page_set(get)_xenheap_gfn() or even page_set(get)_gfn().

Naming them to page_{set, get)_xenheap_gfn() sounds like a good idea.
It would be clearer what is the purpose of the two helpers.

>>> +#define arch_alloc_xenheap_page(p) page_set_frame_gfn(p, INVALID_GFN)
>>> +#define arch_free_xenheap_page(p) \
>>> +    BUG_ON(!gfn_eq(page_get_frame_gfn(p), INVALID_GFN))
>>
>> I believe this BUG_ON() could be triggered if gnttab_map_frame() 
>> succeeds but then we fail to insert the entry in the P2M. This means 
>> we would need to revert changes done in gnttab_map_frame() in case of 
>> failure.
>>
>> However, I am still a bit unease with the BUG_ON(). A domain will not 
>> necessarily remove the grant-table mapping from its P2M before 
>> shutting down. So you are relying on Xen to go through the P2M before 
>> we free the page.
>>
>> This is the case today, but I am not sure we would want to rely on it 
>> because it will be hard to remember this requirement if we decide to 
>> optimize p2m_relinquish().
>>
>> One possibility would be to add a comment in p2m_relinquish(). That's 
>> assuming there are no other places which could lead to false 
>> positively hit the BUG().
> 
> These make me think that it would be better (safer and simpler) to just 
> remove this BUG_ON() for now. Do you agree?
I would drop the BUG_ON() here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:46:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:46:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236139.409583 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSk1-0004Dk-Uh; Wed, 01 Dec 2021 16:45:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236139.409583; Wed, 01 Dec 2021 16:45:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSk1-0004Dd-RW; Wed, 01 Dec 2021 16:45:57 +0000
Received: by outflank-mailman (input) for mailman id 236139;
 Wed, 01 Dec 2021 16:45:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msSk0-0004DT-Gt; Wed, 01 Dec 2021 16:45:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msSk0-0008U9-AE; Wed, 01 Dec 2021 16:45:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msSjz-0005CH-WD; Wed, 01 Dec 2021 16:45:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msSjz-0001mC-Vk; Wed, 01 Dec 2021 16:45:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vTD75p5Zvas+HkHOIHc/F3LvNvHnc7Dl0zfy4C8PC6s=; b=Ppz3w5LSIky4U1qAt3b366sJYf
	O+gr0hOMH4T1sXMtJKidqxeQbfq6R1tMdn/BzuJv+b+6ltdCemCSYOIGaJlqALXMKbvZdEWhcGPzC
	rlMv/ll4zk15c1vTHiX90MYiKdG6jZspXREZQU+0EgAQlkUAjyhagO/5wvFCMsjkPzfQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166968-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 166968: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:regression
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    qemu-mainline:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-thunderx:guest-start:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-destroy:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl:guest-start:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-destroy:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=682aa69b1f4dd5f2905a94066fa4c853adc33251
X-Osstest-Versions-That:
    qemuu=50456a6794fbb8dc94a31eb9534e91c586da7add
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 16:45:55 +0000

flight 166968 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166968/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-libvirt-pair 25 guest-start/debian       fail REGR. vs. 166954
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166954
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-thunderx 14 guest-start              fail REGR. vs. 166954
 test-armhf-armhf-libvirt-raw  8 xen-boot                 fail REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt-xsm 22 guest-destroy            fail REGR. vs. 166954
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl          22 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl          14 guest-start              fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 22 guest-destroy fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-libvirt    18 guest-start/debian.repeat fail REGR. vs. 166954

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166954

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166954
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166954
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166954
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166954
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166954
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                682aa69b1f4dd5f2905a94066fa4c853adc33251
baseline version:
 qemuu                50456a6794fbb8dc94a31eb9534e91c586da7add

Last test of basis   166954  2021-11-30 08:39:11 Z    1 days
Testing same since   166968  2021-12-01 06:37:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eduardo Habkost <ehabkost@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 682aa69b1f4dd5f2905a94066fa4c853adc33251
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Wed Dec 1 07:20:06 2021 +0100

    Update version for v6.2.0-rc3 release
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit 24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac
Author: Eduardo Habkost <ehabkost@redhat.com>
Date:   Tue Nov 30 15:47:22 2021 -0500

    MAINTAINERS: Change my email address
    
    The ehabkost@redhat.com email address will stop working on
    2021-12-01, change it to my personal email address.
    
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211129163053.2506734-1-ehabkost@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211130204722.2732997-2-ehabkost@redhat.com>
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 16:49:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 16:49:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236146.409598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSnU-00056I-JE; Wed, 01 Dec 2021 16:49:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236146.409598; Wed, 01 Dec 2021 16:49:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msSnU-00056B-ES; Wed, 01 Dec 2021 16:49:32 +0000
Received: by outflank-mailman (input) for mailman id 236146;
 Wed, 01 Dec 2021 16:49:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eN/C=QS=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1msSnT-000565-97
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 16:49:31 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a70723b6-52c6-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 17:49:30 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id v15so49501305ljc.0
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 08:49:30 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id t4sm39766lfe.220.2021.12.01.08.49.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 01 Dec 2021 08:49:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a70723b6-52c6-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=8G18hI2ky4bxAF/KRCEZ36EC8LhS1rBUquGKdNmmToM=;
        b=nRtwxg045sSdYF71Kn0vqyU9YiLmoTsXa0Sc4qIX2WpzXVwbbYeUKpyz32FHd30Uto
         95wKzGzXzn1RvfW1Rk71JiWFZparIbrv6aZV47weZxWMMx65fkqAC3b3t5ItLa0TC1EV
         RNNcTKDMpV5urr/kPUk6k22+bQPX/g+z1kmLHUGohF2laJc5t6lP7hPRlqJZ39XUCXeC
         c3q5bev6p1JWd4CBMWaQVkbl33bnbRtp/BzGd/67yabQ/xFnq2H87SZb1+rMs2qNZsfA
         ZvIHXTTnNOtj9PMwmuSOkM42nkmJ044zHYrkLrw1bbavGDvbvHKoUTgakNPfGZUfTD3b
         Hyew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=8G18hI2ky4bxAF/KRCEZ36EC8LhS1rBUquGKdNmmToM=;
        b=Zs8XMPzEi4XQjgXbCRMfDFriML1E6djLfemoSBUAgxqUr0q+XDm7lpSz4YVX1coZ5L
         HcJg1VgHzSBpwZ7Up8qbLIxJDwpHYFCPKJVo6DwXVaGOyfeMJCGVdEC6sB+2i6vgBAFw
         RWnoLTRY+JeM/JiaFRqIlgNFL4gsKDOj2ENwMxB62nKKdliMnQ0fK0qAsJ+J/8jFk9Sp
         QrbueeZQ1UxN7kqWTP1Spn/mKMS38I8/If9h8iA0sFDZbh0UyJwtn2VgEA2sIACdI5e7
         GbRXmTi2vcN/NBnUmVtkjhE7m80w2XCQ/l4pJKPHACvMM7HmQ/kjXNRptr4KFUkQXtag
         pHZw==
X-Gm-Message-State: AOAM533qBahxbMMK/DnJDoX+Qid92waNI7TEAh1PosSIBeSheACQRJIq
	KHV2nzVnNBNMwbd3PmByClI=
X-Google-Smtp-Source: ABdhPJwWPFcYwJQZ3apo97MxlA0T1IqxmT72JdiZEfqZKSMTt3gISUwDb1lkVsJXB/s1zn3xpFqoiA==
X-Received: by 2002:a2e:390c:: with SMTP id g12mr6704212lja.118.1638377369701;
        Wed, 01 Dec 2021 08:49:29 -0800 (PST)
Subject: Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on
 Arm
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com>
 <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
 <89f27a30-187c-6223-9dbb-1e3f52213868@gmail.com>
 <d64d4bdc-a8bb-349c-b4b5-7c3a887e1621@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <ddbf632a-cf46-bdd8-d5c3-b19233fe56a3@gmail.com>
Date: Wed, 1 Dec 2021 18:49:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <d64d4bdc-a8bb-349c-b4b5-7c3a887e1621@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 01.12.21 18:32, Julien Grall wrote:
> Hi Oleksandr,


Hi Julien


>
> On 26/11/2021 13:51, Oleksandr wrote:
>> On 25.11.21 21:04, Julien Grall wrote:
>>>>   {
>>>> +    mfn_t mfn = lpae_get_mfn(pte);
>>>> +
>>>>       ASSERT(p2m_is_valid(pte));
>>>>         /*
>>>> @@ -731,11 +733,22 @@ static void p2m_put_l3_page(const lpae_t pte)
>>>>        */
>>>>       if ( p2m_is_foreign(pte.p2m.type) )
>>>>       {
>>>> -        mfn_t mfn = lpae_get_mfn(pte);
>>>> -
>>>>           ASSERT(mfn_valid(mfn));
>>>>           put_page(mfn_to_page(mfn));
>>>>       }
>>>> +
>>>> +#ifdef CONFIG_GRANT_TABLE
>>>> +    /*
>>>> +     * Check whether we deal with grant table page. As the grant 
>>>> table page
>>>> +     * is xen_heap page and its entry has known p2m type, detect 
>>>> it and mark
>>>> +     * the stored GFN as invalid. Although this check is not 
>>>> precise and we
>>>> +     * might end up updating this for other xen_heap pages, this 
>>>> action is
>>>> +     * harmless to these pages since only grant table pages have 
>>>> this field
>>>> +     * in use. So, at worst, unnecessary action might be performed.
>>>> +     */
>>>> +    if ( (pte.p2m.type == p2m_ram_rw) && is_xen_heap_mfn(mfn) )
>>>
>>> I would use p2m_is_ram() to cover read-only mapping. I think it 
>>> would also be better to use an ``else if`` so it is clear that this 
>>> doesn't cover foreign mapping (it is possible to map xenheap page 
>>> from another domain).
>>
>> ok, will use p2m_is_ram() and ``else if`` construct, however I don't 
>> entirely understand why we also want/need to include read-only pages 
>> (as type is set to p2m_ram_rw in xenmem_add_to_physmap_one() for case 
>> XENMAPSPACE_grant_table)?
>
> Most of this code is already ready to be used by other xenheap pages 
> (see other part of the discussion). So I would like to use p2m_is_ram()
> as it reduces the risk of us forgetting that read-only are not handled.

ok, got it, thank you for the explanation.


>
>  [...]
>
>>>> + page_get_frame_gfn(pg_); \
>>>> +})
>>>>     #define gnttab_need_iommu_mapping(d) \
>>>>       (is_domain_direct_mapped(d) && is_iommu_enabled(d))
>>>> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
>>>> index 7b5e7b7..a00c5f5 100644
>>>> --- a/xen/include/asm-arm/mm.h
>>>> +++ b/xen/include/asm-arm/mm.h
>>>> @@ -98,9 +98,17 @@ struct page_info
>>>>   #define PGT_writable_page PG_mask(1, 1)  /* has writable 
>>>> mappings?         */
>>>>   #define PGT_type_mask     PG_mask(1, 1)  /* Bits 31 or 
>>>> 63.                 */
>>>>   - /* Count of uses of this frame as its current type. */
>>>> -#define PGT_count_width   PG_shift(2)
>>>> -#define PGT_count_mask    ((1UL<<PGT_count_width)-1)
>>>> + /* 2-bit count of uses of this frame as its current type. */
>>>> +#define PGT_count_mask    PG_mask(3, 3)
>>>> +
>>>> +/*
>>>> + * Stored in bits [28:0] or [60:0] GFN if page is used for grant 
>>>> table frame.
>>>
>>> I think this wording is conflicting with ...
>>>
>>>> + * This only valid for the xenheap pages.
>>>
>>> ... this becase xen heap pages are used in other situations. But I 
>>> would prefer if the comment doesn't mention grant-table frame. This 
>>> would allow use to repurpose the field for other xenheap if needed.
>>>
>>> Typo: This *is* only valid
>>
>>
>> ok, so how about to simply mention it's purpose as xenheap GFN here 
>> and down this header?
>>
>> For example,
>> Stored in bits [28:0] or [60:0] GFN if page is xenheap page.
>>
>> BTW, shall I rename the access helpers page_set(get)_frame_gfn() as 
>> well? For me the frame is associated with grant-table.
>> Something to: page_set(get)_xenheap_gfn() or even page_set(get)_gfn().
>
> Naming them to page_{set, get)_xenheap_gfn() sounds like a good idea.
> It would be clearer what is the purpose of the two helpers.

agree, will rename


>
>
>>>> +#define arch_alloc_xenheap_page(p) page_set_frame_gfn(p, INVALID_GFN)
>>>> +#define arch_free_xenheap_page(p) \
>>>> +    BUG_ON(!gfn_eq(page_get_frame_gfn(p), INVALID_GFN))
>>>
>>> I believe this BUG_ON() could be triggered if gnttab_map_frame() 
>>> succeeds but then we fail to insert the entry in the P2M. This means 
>>> we would need to revert changes done in gnttab_map_frame() in case 
>>> of failure.
>>>
>>> However, I am still a bit unease with the BUG_ON(). A domain will 
>>> not necessarily remove the grant-table mapping from its P2M before 
>>> shutting down. So you are relying on Xen to go through the P2M 
>>> before we free the page.
>>>
>>> This is the case today, but I am not sure we would want to rely on 
>>> it because it will be hard to remember this requirement if we decide 
>>> to optimize p2m_relinquish().
>>>
>>> One possibility would be to add a comment in p2m_relinquish(). 
>>> That's assuming there are no other places which could lead to false 
>>> positively hit the BUG().
>>
>> These make me think that it would be better (safer and simpler) to 
>> just remove this BUG_ON() for now. Do you agree?
> I would drop the BUG_ON() here.

ok, will drop. So arch_free_xenheap_page will become dummy on both Arm 
and x86, the question is should we retain it with all call sites in 
free_xenheap_pages() variants?


>
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:01:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:01:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236159.409618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msTuI-0005GJ-Th; Wed, 01 Dec 2021 18:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236159.409618; Wed, 01 Dec 2021 18:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msTuI-0005GC-Pz; Wed, 01 Dec 2021 18:00:38 +0000
Received: by outflank-mailman (input) for mailman id 236159;
 Wed, 01 Dec 2021 18:00:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eN/C=QS=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1msTuH-0005G6-EK
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:00:37 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95afd662-52d0-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 19:00:36 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id d11so49789149ljg.8
 for <xen-devel@lists.xenproject.org>; Wed, 01 Dec 2021 10:00:36 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id z37sm56722lfu.79.2021.12.01.10.00.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 01 Dec 2021 10:00:35 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95afd662-52d0-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=smZlwKrD+zfYCO+VvIqhzp9zybnZOiwTsGLjKGUL0DI=;
        b=EfgVCGQp3K6+B1BiMRotM36ndTFpjmtPbNFra8DAV7MdkNB3CIWh0CAAqMmy6qGBf0
         59A+arQiXLW5LkvZ+7Et+qkosel0JHdXhXO0WOvk0M0q/+iFWexeKw92PsXDmHFwD6Ua
         FFxk0dk6SvanX9KfdpEZCmgDrp7PmaR/1RdgTtziZb4PRXXoKThi57UChfbp8vL4YldR
         AL1W26ZHBALQFUvEi9nCAWdhE+wPAMo3fRUmIMJoTJuUQOsQMAovtbOF6KkePFc33gLd
         fJ0D3/lSixCDNpL14Dl6nEoCLMxHd1mXJ5wENkIC5z2AFjI21Jw4r44eDZohqqSGwx7s
         qhvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=smZlwKrD+zfYCO+VvIqhzp9zybnZOiwTsGLjKGUL0DI=;
        b=kr4M5I4/54rBxh0N4EBpLcuLCHB0a6U3mSmMq2OpizDrSKCFto+W5Vx6H94JWYUYjE
         2w0HfE4e5ORSxnkniDCLVnLICGOLUOL4vuhcsOA93C4IqZztBp0H9MuGg26EqJJDtFOe
         /k9srtHN9+3duiSxATihhz3TmUr2WGQp80hKh2DNsvbJTQDAvaa/JvPvxV97pc+rcG/h
         6LqyVuHFbBBFkfgsqFj0HWUiCPFASykTJLi1srfDGnmhibaSm26gaWwH8JKPW0zNs04T
         XyAfg/tEr/lMw2stmd2/2EMl76QQxwfFgQdX493fX8xsgP623qWxYdInUxzZCunrpM++
         QX6Q==
X-Gm-Message-State: AOAM531BEAXkhGVFSnvRCcK0AKwrvJV1HjWuQC5ezSNY6P0PvbMY1vRq
	BxiS19NbDDnF6Kg2871bHwI=
X-Google-Smtp-Source: ABdhPJzMUpXfR9omgeAWkNPQ4xSbG2XcMsOZstdYKGFaAZnf9YrOucaMnX00e2TGaCSseqhM8bptNg==
X-Received: by 2002:a05:651c:308:: with SMTP id a8mr7275381ljp.149.1638381635634;
        Wed, 01 Dec 2021 10:00:35 -0800 (PST)
Subject: Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info on
 Arm
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com>
 <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
 <89f27a30-187c-6223-9dbb-1e3f52213868@gmail.com>
 <15a507c7-17e3-6e48-152d-32f54b362889@gmail.com>
 <a5aa0a6a-3765-9395-026f-3bfd88bba354@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <5caafe94-51d8-3d33-b42a-bef44a4470e6@gmail.com>
Date: Wed, 1 Dec 2021 20:00:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <a5aa0a6a-3765-9395-026f-3bfd88bba354@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 01.12.21 18:22, Julien Grall wrote:
>
>
> On 29/11/2021 15:58, Oleksandr wrote:
>>
>> Hi Julien
>
> Hi,


Hi Julien


>
>>
>>
>> [snip]
>>
>>
>>>
>>>>>
>>>>> ! Please note, there is still unresolved locking question here for 
>>>>> which
>>>>> I failed to find a suitable solution. So, it is still an RFC !
>>>>>
>>>>> According to the internal conversation:
>>>>> Now the GFN field in the struct page_info is accessed from
>>>>> gnttab_set_frame_gfn() in the grant table code and from 
>>>>> page_set_frame_gfn()
>>>>> in the P2M code (the former uses the latter).
>>>>>
>>>>> We need to prevent the concurrent access to this field. But, we 
>>>>> cannot grab
>>>>> the grant lock from the P2M code because we will introduce a lock 
>>>>> inversion.
>>>>> The page_set_frame_gfn() will be called from the P2M code with the 
>>>>> p2m lock held
>>>>> and then acquire the grant table lock. The gnttab_map_frame() will 
>>>>> do the inverse.
>>>>
>>>> This is a tricky one. I think, we will:
>>>>
>>>>   1) Need to use the P2M lock to protect the access to the GFN in 
>>>> the struct page_info *.
>>>>   2) Defer the call to page_set_frame_gfn() from gnttab_map_frame() 
>>>> to xenmem_add_to_physmap_one()
>>>>   3) In xenmem_add_to_physmap_one() hold the P2M lock while 
>>>> checking the page was not already mapped (e.g. page_get_frame_gfn() 
>>>> == INVALID_GFN) and do the mapping. Call page_set_frame_gfn() on 
>>>> success.
>>>>
>>>> This would still allow the guest to shot itself in the foot (e.g. 
>>>> potentially removing the wrong mapping) if it tries concurrent 
>>>> hypercall but I believe we would not introduce issue like XSA-380.
>>>>
>>>> At the end this would look quite similar to how x86 deal with the 
>>>> M2P update.
>>>
>>> Thank you for the suggestion, I need to analyze the code to better 
>>> understand your idea and technical possibility to implement it, I 
>>> will come up with questions if any.
>>
>> I experimented a bit... Could you please clarify, is the code snippet 
>> below is close to what you meant?
>
> It is close to what I had in my mind. 

Great, thank you for the clarifying.


> A few comments below.
>
>>
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index b594db4..dba9258 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -1488,8 +1488,27 @@ int xenmem_add_to_physmap_one(
>>           return -ENOSYS;
>>       }
>>
>> -    /* Map at new location. */
>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>> +    if ( space != XENMAPSPACE_grant_table )
>
> I would consider to use this approach for any xenheap pages.


Well, I think (from the first look) we need to:

1. Drop #ifdef CONFIG_GRANT_TABLE down this function and in 
p2m_put_l3_page()

2. Replace "space != XENMAPSPACE_grant_table" with 
"!is_xen_heap_mfn(mfn)" above.

Is my understanding correct?


>
>
>> +        /* Map at new location. */
>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>> +    else
>> +    {
>> +#ifdef CONFIG_GRANT_TABLE
>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> +
>> +        p2m_write_lock(p2m);
>> +        if ( gfn_eq(page_get_frame_gfn(page), INVALID_GFN) )
>
> I think we want to return an error if page_get_frame_gfn() return a 
> valid GFN.

ok, I assume -EBUSY would be appropriate


>
>
>> +        {
>> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, 
>> p2m->default_access);
>> +            if ( !rc )
>> +                page_set_frame_gfn(page, gfn);
>> +        }
>> +        p2m_write_unlock(p2m);
>> +#else
>> +        ASSERT_UNREACHABLE();
>> +        rc = -EINVAL;
>> +#endif
>> +    }
>>
>>       /*
>>        * For XENMAPSPACE_gmfn_foreign if we failed to add the 
>> mapping, we need
>> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
>> index 59604b1..64e9e77 100644
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -4167,10 +4167,8 @@ int gnttab_map_frame(struct domain *d, 
>> unsigned long idx, gfn_t gfn, mfn_t *mfn)
>>            * Make sure gnttab_unpopulate_status_frames() won't 
>> (successfully)
>>            * free the page until our caller has completed its operation.
>>            */
>> -        if ( get_page(mfn_to_page(*mfn), d) )
>> -            gnttab_set_frame_gfn(gt, status, idx, gfn);
>> -        else
>> -            rc = -EBUSY;
>> +        if ( !get_page(mfn_to_page(*mfn), d) )
>> +           rc = -EBUSY;
>>       }
>>
>>       grant_write_unlock(gt);
>> (END)
>>
>> If yes *and* I correctly understand the code, then looks like 
>> gnttab_set_frame_gfn becomes useless on Arm and can be dropped 
>> globally (x86's variant is already dummy).
>
> It will not be a dummy version soon see [1].

Indeed, I just remembered about this patch, ok.


>
> Cheers,
>
> [1] 
> https://lore.kernel.org/xen-devel/8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com/
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:11:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:11:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236165.409629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msU4B-0006ro-ST; Wed, 01 Dec 2021 18:10:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236165.409629; Wed, 01 Dec 2021 18:10:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msU4B-0006rh-Oz; Wed, 01 Dec 2021 18:10:51 +0000
Received: by outflank-mailman (input) for mailman id 236165;
 Wed, 01 Dec 2021 18:10:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msU4A-0006rb-20
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:10:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msU49-0001Ya-Vj
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:10:49 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msU49-0003wU-UZ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:10:49 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1msU48-0007ir-3N; Wed, 01 Dec 2021 18:10:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=3iXUvNUvexIGQzvOlHI3bA60yLfZhmNzLyIcSpjub0M=; b=hio7nBOYYgyYmaBnvC1pnDV71p
	++LWQphhfLHZoW2u7ArMO3e/Q5oLpFW77mbdAKKJmJQr9ZVm1DfKQSH9rAwJKd0sip76PX+PWRo6b
	F5EMPQORlvQ+QeYX51GzJ0R7bLsS/PDyiW0rwFkzXRNwc9g48AXqcGhNmgtzZ7ozsps4=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24999.47783.66521.232381@mariner.uk.xensource.com>
Date: Wed, 1 Dec 2021 18:10:47 +0000
To: xen-devel@lists.xenproject.org
CC: Community Manager <community.manager@xenproject.org>
Subject: [PATCH] CHANGELOG.md: Start new "unstable" section

I'm committing this now, along with the forward-ports mentioned.  I
think this is mechanical release technician stuff, so I don't feel the
need for an ack.

Ian.

>From 6c1c97e24f830a921a23e3b9694e20493c9986ee Mon Sep 17 00:00:00 2001
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Cc: Community Manager <community.manager@xenproject.org>
Date: Wed, 1 Dec 2021 18:07:40 +0000
Subject: [PATCH] CHANGELOG.md: Start new "unstable" section

I have just forward-ported the CHANGELOG.md updates from the
stable-4.16 branch.  But we need a new section for work in this
release cycle.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 731db3590e..6c0cd88cdf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
+## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
+
 ## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02
 
 ### Removed
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:19:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:19:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236174.409652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUCX-0007x5-RY; Wed, 01 Dec 2021 18:19:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236174.409652; Wed, 01 Dec 2021 18:19:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUCX-0007wy-OO; Wed, 01 Dec 2021 18:19:29 +0000
Received: by outflank-mailman (input) for mailman id 236174;
 Wed, 01 Dec 2021 18:19:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msUCV-0007ws-GZ
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:19:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msUCS-0001iL-H1; Wed, 01 Dec 2021 18:19:24 +0000
Received: from 54-240-197-235.amazon.com ([54.240.197.235]
 helo=[192.168.22.155]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msUCS-0004Xu-AP; Wed, 01 Dec 2021 18:19:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jIDgrpfhLiBYepKOW3385zBmGr3i7hktzvm0m0llYh4=; b=tr31nb5Fi7qSGWzc1xsyzQ3YOn
	5j1mfCWG2ZDLYVRNVpcZBfgK+tLJwpMxDkTCVfj6x3e37gwC7lKRRTUwNVHxu3J02NXzqjko7Qp4i
	bBsXVFBCMcGyFxVFd/PV2hO/nONIzRD3m6cwsiUjOwOVfhu4wWy/597tCZVLWK30OEY0=;
Message-ID: <cbe2a86c-0e2c-dbab-087b-f5c1188bd5aa@xen.org>
Date: Wed, 1 Dec 2021 18:19:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from
 gnttab_map_frame()
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
 <da172ad3-47b8-8e60-c70a-4275aeb9efd7@xen.org>
 <a01c4d48-0a87-65bb-0593-efa9826e0e4e@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <a01c4d48-0a87-65bb-0593-efa9826e0e4e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 26/11/2021 08:07, Jan Beulich wrote:
> On 25.11.2021 17:37, Julien Grall wrote:
>> On 13/09/2021 07:41, Jan Beulich wrote:
>>> Without holding appropriate locks, attempting to remove a prior mapping
>>> of the underlying page is pointless, as the same (or another) mapping
>>> could be re-established by a parallel request on another vCPU. Move the
>>> code to Arm's gnttab_set_frame_gfn(). Of course this new placement
>>> doesn't improve things in any way as far as the security of grant status
>>> frame mappings goes (see XSA-379). Proper locking would be needed here
>>> to allow status frames to be mapped securely.
>>>
>>> In turn this then requires replacing the other use in
>>> gnttab_unpopulate_status_frames(), which yet in turn requires adjusting
>>> x86's gnttab_set_frame_gfn(). Note that with proper locking inside
>>> guest_physmap_remove_page() combined with checking the GFN's mapping
>>> there against the passed in MFN, there then is no issue with the
>>> involved multiple gnttab_set_frame_gfn()-s potentially returning varying
>>
>> Do you mean gnttab_get_frame_gfn()?
> 
> No, I don't think so; I do mean gnttab_set_frame_gfn(). Its return value
> directs the caller to do (or not) certain things.

Hmmm ok. I misundertood that comment then. Thanks for the clarification!

> 
>>> --- a/xen/include/asm-arm/grant_table.h
>>> +++ b/xen/include/asm-arm/grant_table.h
>>> @@ -71,11 +71,17 @@ int replace_grant_host_mapping(unsigned
>>>            XFREE((gt)->arch.status_gfn);                                    \
>>>        } while ( 0 )
>>>    
>>> -#define gnttab_set_frame_gfn(gt, st, idx, gfn)                           \
>>> -    do {                                                                 \
>>> -        ((st) ? (gt)->arch.status_gfn : (gt)->arch.shared_gfn)[idx] =    \
>>> -            (gfn);                                                       \
>>> -    } while ( 0 )
>>> +#define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
>>> +    ({                                                                   \
>>> +        int rc_ = 0;                                                     \
>>> +        gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx);                  \
>>> +        if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) ||           \
>>> +             (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn,   \
>>> +                                              0)) == 0 )                 \
>>> +            ((st) ? (gt)->arch.status_gfn                                \
>>> +                  : (gt)->arch.shared_gfn)[idx] = (gfn);                 \
>>> +        rc_;                                                             \
>>> +    })
>>
>> I think using a function would make it a bit easier to understand what
>> it does.
> 
> I can convert it, but it's not very likely that it would be possible
> to make it an inline one. Not sure whether that's then still desirable.

So looking at Oleksandr series, I think we should be able to have the 
Arm helper matching the x86 one. At which point, I could deal with this 
version for now.

> 
>> However... The naming of the function is now quite confusing. The more
>> on x86...
>>
>>>    
>>>    #define gnttab_get_frame_gfn(gt, st, idx) ({                             \
>>>       (st) ? gnttab_status_gfn(NULL, gt, idx)                               \
>>> --- a/xen/include/asm-x86/grant_table.h
>>> +++ b/xen/include/asm-x86/grant_table.h
>>> @@ -37,7 +37,12 @@ static inline int replace_grant_host_map
>>>    
>>>    #define gnttab_init_arch(gt) 0
>>>    #define gnttab_destroy_arch(gt) do {} while ( 0 )
>>> -#define gnttab_set_frame_gfn(gt, st, idx, gfn) do {} while ( 0 )
>>> +#define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
>>> +    (gfn_eq(gfn, INVALID_GFN)                                            \
>>> +     ? guest_physmap_remove_page((gt)->domain,                           \
>>> +                                 gnttab_get_frame_gfn(gt, st, idx),      \
>>> +                                 mfn, 0)                                 \
>>> +     : 0 /* Handled in add_to_physmap_one(). */)
>>
>> ... it will end up to remove the mapping. I don't have a better name at
>> the moment. However I think this would deserve some documentation in the
>> code so one can understand how to implement it for another arch.
> 
> Hmm, perhaps. But wouldn't we better document the final behavior (i.e.
> once the remaining Arm issue got addressed)?

Fair point. I don't expect Oleksandr's series to be committed long after 
yours.

> That may then also lead
> to overall simpler code, ideally with more suitable names (if the
> present ones are deemed unsuitable, which I'm not convinced of).
I don't have a better name so far. However, without any documentation 
this is very difficult to figure out what it is meant to do (I am not 
only referring to someone implementing it for another arch here).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:34:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:34:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236182.409663 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUQV-0001y2-7b; Wed, 01 Dec 2021 18:33:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236182.409663; Wed, 01 Dec 2021 18:33:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUQV-0001xv-4V; Wed, 01 Dec 2021 18:33:55 +0000
Received: by outflank-mailman (input) for mailman id 236182;
 Wed, 01 Dec 2021 18:33:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msUQT-0001xp-N5
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:33:53 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b0eeecd-52d5-11ec-b945-1df2895da90e;
 Wed, 01 Dec 2021 19:33:52 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50694)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msUQQ-0011V0-gr (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 18:33:50 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 087E71FD7A;
 Wed,  1 Dec 2021 18:33:50 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b0eeecd-52d5-11ec-b945-1df2895da90e
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <639244eb-074a-ef90-3bbb-747ac65fa6b7@srcf.net>
Date: Wed, 1 Dec 2021 18:33:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
 <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty()
 invocation
In-Reply-To: <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 10:35, Jan Beulich wrote:
> paging_mfn_is_dirty() is moderately expensive, so avoid its use unless
> its result might actually change anything. This means moving the
> surrounding if() down below all other checks that can result in clearing
> _PAGE_RW from sflags, in order to then check whether _PAGE_RW is
> actually still set there before calling the function.
>
> While moving the block of code, fold two if()s and make a few style
> adjustments.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> TBD: Perhaps the dirty-VRAM piece also wants moving down a little, such
>      that all three "level == 1" conditionals can be folded?

TBH, lots of the layout looks dubious, but I'm not sure how worthwhile
micro-optimising it is.  This particular rearrangement is surely
unmeasurable.

Fixing the (mis)use of mfn_valid() in the logdirty infrastructure will
gain a far larger improvement, because that's dropping a fair number of
lfence's from multiple paths, but it's still the case that anything here
is rare-to-non-existent in production workloads, and vastly dominated by
the VMExit cost even when migrating shadow VMs.

>
> --- a/xen/arch/x86/mm/shadow/multi.c
> +++ b/xen/arch/x86/mm/shadow/multi.c
> @@ -604,23 +604,6 @@ _sh_propagate(struct vcpu *v,
>                    && !(gflags & _PAGE_DIRTY)) )
>          sflags &= ~_PAGE_RW;
>  
> -    // shadow_mode_log_dirty support
> -    //
> -    // Only allow the guest write access to a page a) on a demand fault,
> -    // or b) if the page is already marked as dirty.
> -    //
> -    // (We handle log-dirty entirely inside the shadow code, without using the
> -    // p2m_ram_logdirty p2m type: only HAP uses that.)
> -    if ( unlikely((level == 1) && shadow_mode_log_dirty(d)) )
> -    {
> -        if ( mfn_valid(target_mfn) ) {
> -            if ( ft & FETCH_TYPE_WRITE )
> -                paging_mark_dirty(d, target_mfn);
> -            else if ( !paging_mfn_is_dirty(d, target_mfn) )
> -                sflags &= ~_PAGE_RW;
> -        }
> -    }
> -
>  #ifdef CONFIG_HVM
>      if ( unlikely(level == 1) && is_hvm_domain(d) )
>      {
> @@ -661,6 +644,25 @@ _sh_propagate(struct vcpu *v,
>                    ) )
>          sflags &= ~_PAGE_RW;
>  
> +    /*
> +     * shadow_mode_log_dirty support
> +     *
> +     * Only allow the guest write access to a page a) on a demand fault,
> +     * or b) if the page is already marked as dirty.
> +     *
> +     * (We handle log-dirty entirely inside the shadow code, without using the
> +     * p2m_ram_logdirty p2m type: only HAP uses that.)
> +     */
> +    if ( level == 1 && unlikely(shadow_mode_log_dirty(d)) &&
> +         mfn_valid(target_mfn) )
> +    {
> +        if ( ft & FETCH_TYPE_WRITE )
> +            paging_mark_dirty(d, target_mfn);
> +        else if ( (sflags & _PAGE_RW) &&
> +                  !paging_mfn_is_dirty(d, target_mfn) )
> +            sflags &= ~_PAGE_RW;

This is almost crying out for a logdirty_test_and_maybe_set() helper,
because the decent of the logdirty trie is common between the two, but
as this would be the only user, probably not worth it.

However, the more I look at the logdirty logic, the more it is clear
that all the mfn_valid() tests should change to MFN_INVALID, and the
result will be far more efficient.

~Andrew

> +    }
> +
>      // PV guests in 64-bit mode use two different page tables for user vs
>      // supervisor permissions, making the guest's _PAGE_USER bit irrelevant.
>      // It is always shadowed as present...
>
>



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:42:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:42:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236188.409673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUYy-0003X7-2j; Wed, 01 Dec 2021 18:42:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236188.409673; Wed, 01 Dec 2021 18:42:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUYx-0003X0-W7; Wed, 01 Dec 2021 18:42:39 +0000
Received: by outflank-mailman (input) for mailman id 236188;
 Wed, 01 Dec 2021 18:42:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msUYw-0003Wq-PG; Wed, 01 Dec 2021 18:42:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msUYw-00026q-Ey; Wed, 01 Dec 2021 18:42:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msUYw-0002FJ-2t; Wed, 01 Dec 2021 18:42:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msUYw-0007g4-2O; Wed, 01 Dec 2021 18:42:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cE3CuXbSlL0EpGHJY/w/jar8tVaqiBNkTDNUSWAE29s=; b=lRQiO6xGYGUds8r3Cib5K0w7W1
	h6bnytwJQHj2LgYl4xXy58DqjQzg2AFvUDd7F6OsMU8KbbaDUcRYpo6csZW8pzWKZpisTIB/LYr6e
	4eSHrAsin1KuNxS96jUH9vzUt0p/NMT4pTlvPUrekLkS+OXucdkT/5RMzjLvVyHZteng=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166969-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 166969: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl:guest-start:fail:regression
    linux-linus:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 18:42:38 +0000

flight 166969 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166969/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl          14 guest-start              fail REGR. vs. 166942
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166942
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 166942
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 build-arm64-pvops             6 kernel-build             fail REGR. vs. 166942
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 166942

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166942

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-examine      1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl           1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)               blocked  n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    4 days
Failing since        166963  2021-11-30 20:54:02 Z    0 days    2 attempts
Testing same since   166969  2021-12-01 08:33:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alex Williamson <alex.williamson@redhat.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Bean Huo <beanhuo@micron.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Darrick J. Wong <djwong@kernel.org>
  David Howells <dhowells@redhat.com>
  David Woodhouse <dwmw@amazon.co.uk>
  Douglas Gilbert <dgilbert@interlog.com>
  Fuad Tabba <tabba@google.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Joerg Roedel <jroedel@suse.de>
  Juergen Gross <jgross@suse.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lu Baolu <baolu.lu@linux.intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Piggin <npiggin@gmail.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Qian Cai <quic_qiancai@quicinc.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sean Christopherson <seanjc@google.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            fail    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          blocked 
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      blocked 
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  blocked 
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  blocked 
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     blocked 
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 blocked 
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      blocked 
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3187 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 18:44:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 18:44:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236195.409688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUau-00049S-Hj; Wed, 01 Dec 2021 18:44:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236195.409688; Wed, 01 Dec 2021 18:44:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUau-00049L-Dw; Wed, 01 Dec 2021 18:44:40 +0000
Received: by outflank-mailman (input) for mailman id 236195;
 Wed, 01 Dec 2021 18:44:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msUas-00049B-Hv
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:44:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msUas-00028Y-HA
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:44:38 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msUas-0006Pt-GH
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 18:44:38 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1msUaq-0007p0-CJ; Wed, 01 Dec 2021 18:44:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=Tncl+L5L9W21/UcEddn+RWjWVah62Omz46wS+/cdsMk=; b=cJ6DD/DEypXcimGBcsSyolCMmr
	tckHIkQs6XS8161tlnS3ashkoIXaZRQ1OE1oMF89PZYH1SvSOQmB0nOjQYqkGxuvxIlvSo4I9N6IH
	ejwu8T2igKmVKEjUpjc8aZcFpweFMjyE3Snx4UJ0vFH8my62LS8X7dsBV5tMTcLwqCdU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <24999.49811.516694.793307@mariner.uk.xensource.com>
Date: Wed, 1 Dec 2021 18:44:35 +0000
To: xen-devel@lists.xenproject.org
CC: committers@xenproject.org,
    community.manager@xenproject.org
Subject: Xen 4.16 release party, Cambridge
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

We will shortly release Xen 4.16.0.  Some of us will be celebrating in
person in Cambridge: in the pub, next Thursday (9th December).

We'll be at the Haymakers [1], in the gazebo, from 17:00.
  https://www.individualpubs.co.uk/haymakers/
  https://www.openstreetmap.org/way/131306510

In addition, I am leaving Citrix after 12 years working on Xen.
I'll be inviting colleagues from Citrix to come and see me off.

Please join us.  Ideally, please RSVP to me at the address above.
I will book a table and an idea of numbers would be very helpful.
Please RSVP *by 1800 UTC* on Monday (6th December).

The gazebo is covered, but reasonably well ventilated, so we can stay
dry.  Please be vaccinated (subject to availability and medical
advice).  If you are unvaccinated by choice, please stay away this
time, and then I hope to see you at some other point in the future.

Ian.
(Relevantly, Xen 4.16 Release Manager and ian.jackson@citrix.com)

[1] Holding a Cambridge Xen party at the Haymakers is traditional, but
I need to disclose a financial interest: I own shares in Individual
Pubs Ltd, who own the Haymakers.


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 19:08:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 19:08:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236203.409698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUxP-000759-GM; Wed, 01 Dec 2021 19:07:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236203.409698; Wed, 01 Dec 2021 19:07:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msUxP-00074a-Cu; Wed, 01 Dec 2021 19:07:55 +0000
Received: by outflank-mailman (input) for mailman id 236203;
 Wed, 01 Dec 2021 19:07:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msUxO-00074U-Dz
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 19:07:54 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa3ec744-52d9-11ec-b1df-f38ee3fbfdf7;
 Wed, 01 Dec 2021 20:07:53 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40258)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msUxJ-000zDS-ot (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 19:07:49 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 694601FF79;
 Wed,  1 Dec 2021 19:07:49 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa3ec744-52d9-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4ee538d8-5063-1bf6-025a-62474be7ab0c@srcf.net>
Date: Wed, 1 Dec 2021 19:07:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-3-andrew.cooper3@citrix.com>
 <3ca82514-2adf-2445-04d1-0020dde16019@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/4] x86/altcall: Optimise away endbr64 instruction where
 possible
In-Reply-To: <3ca82514-2adf-2445-04d1-0020dde16019@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 08:20, Jan Beulich wrote:
> On 26.11.2021 22:22, Andrew Cooper wrote:
>> With altcall, we convert indirect branches into direct ones.  With that
>> complete, none of the potential targets need an endbr64 instruction.
> Assuming that no other hooks remain which re-use the same function. I
> think this constraint wants at least mentioning explicitly.

Fair point, but I think it is entirely reasonable to expect logic not to
mix and match altcall on the same hook.

>
>> Furthermore, removing the endbr64 instructions is a security defence-in-depth
>> improvement, because it limits the options available to an attacker who has
>> managed to hijack a function pointer.
>>
>> Introduce a new .init.data.cf_clobber section.  Have _apply_alternatives()
>> walk over the entire section, looking for any pointers into .text, and clobber
>> an endbr64 instruction if found.  This is some minor structure (ab)use but it
>> works alarmingly well.
> Iirc you've said more than once that non-function-pointer data in
> those structures is fine; I'm not convinced. What if a sequence of
> sub-pointer-size fields has a value looking like a pointer into
> .text? This may not be very likely, but would result in corruption
> that may be hard to associate with anything. Of course, with the
> is_endbr64() check and with a build time check of there not being
> any stray ENDBR64 patterns in .text, that issue would disappear.
> But we aren't quite there yet.

I disagree with "not very likely" and put it firmly in the "not
plausible" category.

To cause a problem, you need an aligned something which isn't actually a
function pointer with a bit pattern forming [0xffff82d040200000,
ffff82d04039e1ba) which hits an ENDBR64 pattern.  Removing the stray
ENDBR64's doesn't prevent such a bit pattern pointing at a real (wrong)
function.

These structures are almost exclusively compile time generated.

So yes - it's not impossible, but it's also not going to happen
accidentally.


>
>> --- a/xen/arch/x86/alternative.c
>> +++ b/xen/arch/x86/alternative.c
>> @@ -173,6 +173,9 @@ text_poke(void *addr, const void *opcode, size_t len)
>>      return memcpy(addr, opcode, len);
>>  }
>>  
>> +extern unsigned long __initdata_cf_clobber_start[];
>> +extern unsigned long __initdata_cf_clobber_end[];
> const please. I also would find it quite a bit better if these
> were suitably typed such that ...
>
>> @@ -329,6 +332,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>>          text_poke(orig, buf, total_len);
>>      }
>> +
>> +    /*
>> +     * Clobber endbr64 instructions now that altcall has finished optimised
>> +     * all indirect branches to direct ones.
>> +     */
>> +    if ( force && cpu_has_xen_ibt )
>> +    {
>> +        unsigned long *val;
>> +        unsigned int clobbered = 0;
>> +
>> +        /*
>> +         * This is some minor structure (ab)use.  We walk the entire contents
>> +         * of .init.data.cf_clobber as if it were an array of pointers.
>> +         *
>> +         * If the pointer points into .text, and has an endbr64 instruction,
>> +         * nop out the endbr64.  This causes the pointer to no longer be a
>> +         * legal indirect branch target under CET-IBT.  This is a
>> +         * defence-in-depth measure, to reduce the options available to an
>> +         * adversary who has managed to hijack a function pointer.
>> +         */
>> +        for ( val = __initdata_cf_clobber_start;
>> +              val < __initdata_cf_clobber_end;
>> +              val++ )
>> +        {
>> +            void *ptr = (void *)*val;
> ... no cast was needed here.

Unless you know what this type is, I already tried and am stuck. 
Everything else requires more horrible casts on val.

>
>> --- a/xen/arch/x86/xen.lds.S
>> +++ b/xen/arch/x86/xen.lds.S
>> @@ -214,6 +214,11 @@ SECTIONS
>>         *(.initcall1.init)
>>         __initcall_end = .;
>>  
>> +       . = ALIGN(POINTER_ALIGN);
>> +        __initdata_cf_clobber_start = .;
>> +	*(.init.data.cf_clobber)
> Nit: hard tab slipped in here.

Will fix.

>
>> --- a/xen/include/xen/init.h
>> +++ b/xen/include/xen/init.h
>> @@ -18,6 +18,8 @@
>>  #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
>>  #define __exit_call       __used_section(".exitcall.exit")
>>  
>> +#define __initdata_cf_clobber __section(".init.data.cf_clobber")
> Just to repeat what I've said elsewhere: I think we want a const
> version of this as well.

I can, but does it really matter?  initconst is merged into initdata and
not actually read-only to begin with.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 19:12:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 19:12:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236207.409709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msV22-0008Ru-2i; Wed, 01 Dec 2021 19:12:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236207.409709; Wed, 01 Dec 2021 19:12:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msV21-0008Rn-W4; Wed, 01 Dec 2021 19:12:41 +0000
Received: by outflank-mailman (input) for mailman id 236207;
 Wed, 01 Dec 2021 19:12:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msV20-0008Rh-Lp
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 19:12:40 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a6da67bc-52da-11ec-b1df-f38ee3fbfdf7;
 Wed, 01 Dec 2021 20:12:39 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50700)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msV1z-000SHc-he (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 19:12:39 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 437E41FD7A;
 Wed,  1 Dec 2021 19:12:39 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a6da67bc-52da-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <352d554d-dbea-e7b9-e499-91517ffc17c3@srcf.net>
Date: Wed, 1 Dec 2021 19:12:39 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 4/4] x86/ucode: Use altcall, and __initdata_cf_clobber
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-5-andrew.cooper3@citrix.com>
 <8943376d-b6cc-6c04-c4aa-c8d30800dfca@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <8943376d-b6cc-6c04-c4aa-c8d30800dfca@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 01/12/2021 08:23, Jan Beulich wrote:
> On 26.11.2021 22:22, Andrew Cooper wrote:
>> Microcode loading is not a fastpath, but there are control flow security
>> benefits from using altcall()'s hardening side effect.
>>
>> Convert the existing microcode_ops pointer into a __read_mostly structure, and
>> move {amd,intel}_ucode_ops into __initdata_cf_clobber.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Again subject to the resolution of the const aspect and perhaps
> with __read_mostly converted to __ro_after_init (assuming its
> introduction goes in first)
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

Given how simple __ro_after_init was, it would be preferable to get that
in first, than to go around patching these a second time.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 20:13:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 20:13:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236216.409727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msVyq-0006oz-7v; Wed, 01 Dec 2021 20:13:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236216.409727; Wed, 01 Dec 2021 20:13:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msVyq-0006os-4s; Wed, 01 Dec 2021 20:13:28 +0000
Received: by outflank-mailman (input) for mailman id 236216;
 Wed, 01 Dec 2021 20:13:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msVyo-0006om-PF
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 20:13:26 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 21d3f233-52e3-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 21:13:24 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34820)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msVyf-000BTf-8m (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 20:13:17 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 788291FD7A;
 Wed,  1 Dec 2021 20:13:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21d3f233-52e3-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5a1c0ba9-7583-39c0-87ce-dcb62ea4c7b9@srcf.net>
Date: Wed, 1 Dec 2021 20:13:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130181139.14398-1-andrew.cooper3@citrix.com>
 <20211130181139.14398-3-andrew.cooper3@citrix.com>
 <037802f4-d28b-62bc-e830-78149f1cc2ff@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/2] x86/hvm: Rework nested hap functions to reduce
 parameters
In-Reply-To: <037802f4-d28b-62bc-e830-78149f1cc2ff@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 09:14, Jan Beulich wrote:
> On 30.11.2021 19:11, Andrew Cooper wrote:
>> Most functions in this call chain have 8 parameters, meaning that the final
>> two booleans are spilled to the stack for for calls.
>>
>> First, delete nestedhap_walk_L1_p2m and introduce nhvm_hap_walk_L1_p2m() as a
>> thin wrapper around hvm_funcs just like all the other nhvm_*() hooks.  This
>> involves including xen/mm.h as the forward declaration of struct npfec is no
>> longer enough.
>>
>> Next, replace the triple of booleans with struct npfec, which contains the
>> same information in the bottom 3 bits.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Tamas K Lengyel <tamas@tklengyel.com>
>> CC: Alexandru Isaila <aisaila@bitdefender.com>
>> CC: Petre Pircalabu <ppircalabu@bitdefender.com>
>>
>> I don't much like this, but I think it's the least bad option in the short
>> term.  npfec is horribly mis-named/mis-used (at best, it should be considered
>> npf_info, and probably inherits from the same API/ABI mistakes our regular
>> pagewalk functions have) and is going to have to be untangled to make nested
>> virt a maintainable option.
> So why use struct npfec here then in the first place? It could as well
> be "unsigned int" with constants defined for X, R, and W, couldn't it?

I started prototyping that first, but substantially ups the work
required to support XU/XS down the line, and that's far more likely to
happen before getting around to cleaning up the API/ABI.

>> --- a/xen/include/asm-x86/hvm/hvm.h
>> +++ b/xen/include/asm-x86/hvm/hvm.h
>> @@ -25,6 +25,7 @@
>>  #include <asm/current.h>
>>  #include <asm/x86_emulate.h>
>>  #include <asm/hvm/asid.h>
>> +#include <xen/mm.h>
> Nit: Typically we have xen/ includes ahead of asm/ ones.

Fixed.

>
>> @@ -631,6 +630,14 @@ static inline enum hvm_intblk nhvm_interrupt_blocked(struct vcpu *v)
>>      return hvm_funcs.nhvm_intr_blocked(v);
>>  }
>>  
>> +static inline int nhvm_hap_walk_L1_p2m(
>> +    struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *page_order,
>> +    uint8_t *p2m_acc, struct npfec npfec)
>> +{
>> +    return hvm_funcs.nhvm_hap_walk_L1_p2m(
>> +        v, L2_gpa, L1_gpa, page_order, p2m_acc, npfec);
>> +}
> Is there a specific reason you don't switch to altcall right in
> this patch, making a follow-on change unnecessary?

I was still hoping to keep the altcall stuff in one patch.  I'm happy to
do the rebase.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 21:11:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 21:11:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236225.409747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msWsR-000559-M7; Wed, 01 Dec 2021 21:10:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236225.409747; Wed, 01 Dec 2021 21:10:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msWsR-000552-HK; Wed, 01 Dec 2021 21:10:55 +0000
Received: by outflank-mailman (input) for mailman id 236225;
 Wed, 01 Dec 2021 21:10:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Zo2s=QS=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1msWsP-00054v-U1
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 21:10:53 +0000
Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr
 [80.12.242.129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a23b1e5-52eb-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 22:10:52 +0100 (CET)
Received: from pop-os.home ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id sWsLmkjcv65jHsWsLmTQIX; Wed, 01 Dec 2021 22:10:51 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a23b1e5-52eb-11ec-976b-d102b41d0961
X-ME-Helo: pop-os.home
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Wed, 01 Dec 2021 22:10:51 +0100
X-ME-IP: 86.243.171.122
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH] xen-blkfront: Use the bitmap API when applicable
Date: Wed,  1 Dec 2021 22:10:48 +0100
Message-Id: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
open-coded arithmetic in allocator arguments.

Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.

Use 'bitmap_copy()' to avoid an explicit 'memcpy()'

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/block/xen-blkfront.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 700c765a759a..fe4d69cf9469 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int minor, unsigned int nr)
 	if (end > nr_minors) {
 		unsigned long *bitmap, *old;
 
-		bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
-				 GFP_KERNEL);
+		bitmap = bitmap_zalloc(end, GFP_KERNEL);
 		if (bitmap == NULL)
 			return -ENOMEM;
 
 		spin_lock(&minor_lock);
 		if (end > nr_minors) {
 			old = minors;
-			memcpy(bitmap, minors,
-			       BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
+			bitmap_copy(bitmap, minors, nr_minors);
 			minors = bitmap;
 			nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
 		} else
@@ -2610,7 +2608,7 @@ static void __exit xlblk_exit(void)
 
 	xenbus_unregister_driver(&blkfront_driver);
 	unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
-	kfree(minors);
+	bitmap_free(minors);
 }
 module_exit(xlblk_exit);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 01 21:39:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 21:39:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236231.409761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msXJd-0007yg-Ue; Wed, 01 Dec 2021 21:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236231.409761; Wed, 01 Dec 2021 21:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msXJd-0007yZ-R4; Wed, 01 Dec 2021 21:39:01 +0000
Received: by outflank-mailman (input) for mailman id 236231;
 Wed, 01 Dec 2021 21:39:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msXJc-0007yT-7f
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 21:39:00 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 15ffa05d-52ef-11ec-b1df-f38ee3fbfdf7;
 Wed, 01 Dec 2021 22:38:57 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40266)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msXJT-000rqI-pW (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 21:38:51 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 985851FA8E;
 Wed,  1 Dec 2021 21:38:51 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15ffa05d-52ef-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <77a6b9b4-8117-e818-e68e-af37eeec2dd7@srcf.net>
Date: Wed, 1 Dec 2021 21:38:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>,
 andre.przywara@arm.com, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org
References: <20211130181238.5501-1-ayankuma@xilinx.com>
 <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
 <3caf216e-95dd-97e1-b380-a31f5388dc86@suse.com>
 <959d50ef-2a4c-8850-4a89-7eff0b649a13@xen.org>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
In-Reply-To: <959d50ef-2a4c-8850-4a89-7eff0b649a13@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 09:56, Julien Grall wrote:
> Hi,
>
> On 01/12/2021 09:38, Jan Beulich wrote:
>> On 01.12.2021 10:33, Julien Grall wrote:
>>> On 30/11/2021 18:12, Ayan Kumar Halder wrote:
>>>> --- a/xen/include/xen/bitops.h
>>>> +++ b/xen/include/xen/bitops.h
>>>> @@ -5,7 +5,7 @@
>>>>    /*
>>>>     * Create a contiguous bitmask starting at bit position @l and
>>>> ending at
>>>>     * position @h. For example
>>>> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
>>>> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
>>>
>>> ... there are two extra changes here:
>>>     1) The bitmask is now described with 8-characters (rather than 9)
>>>     2) 'vector' is replaced with 'value'
>>>
>>> The former makes sense to me, but it is not clear to me why the latter
>>> should be changed.
>>
>> Would you mind explaining to me in which way you see "vector" accurately
>> describe the entity talked about?
>
> This can be seen as a vector of bit. I can see why people may think
> otherwise. However... if you think it doesn't describe it accurately,
> then I think this ought to be changed in Linux first (where the code
> and comment comes from).
>
>>
>> I also think the commit message is quite fine as is.
> IMHO, this is similar to when one do coding style change in a patch.
> They are unrelated but would be acceptable so long they are explained
> in the commit message.
>
> What I request is something like:
>
> "GENMASK(30, 21) should be 0x7fe00000 and only use 8-characters (it is
> a 32-bit comment). Fixed this in the comment.
>
> Take the opportunity to replace 'vector' with 'value' because..."
>
> This is simple enough and clarify what is the intent of the patch.

This is an unreasonable quantity of bikeshedding.  It's just a comment,
and a commit message of "fix the comment" is perfectly fine. 
Furthermore, the intent of the text is clear.

However, "32bit $WHATEVER" is also wrong because GENMASK() yields a
unsigned long constant.  Importantly, not 32 bits in an ARM64 build.


This trivial patch has lingered far too long.  I have committed it,
along with an adjustment.  Further bikeshedding will be redirected to
/dev/null.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 22:16:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 22:16:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236242.409779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msXtd-00044u-34; Wed, 01 Dec 2021 22:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236242.409779; Wed, 01 Dec 2021 22:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msXtc-00044n-WF; Wed, 01 Dec 2021 22:16:13 +0000
Received: by outflank-mailman (input) for mailman id 236242;
 Wed, 01 Dec 2021 22:16:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msXtc-00044d-8x; Wed, 01 Dec 2021 22:16:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msXtc-0005jV-1b; Wed, 01 Dec 2021 22:16:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msXtb-0004gO-M9; Wed, 01 Dec 2021 22:16:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msXtb-0000gX-Lf; Wed, 01 Dec 2021 22:16:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9YjKl2YF3QMBdDLyKnGPgs9oIJLbgMqAv9OEivpzufU=; b=YNM6cvy00qh6MCTT8XLkAstAWm
	rmj6aTrRy/1fPwD+0zZn5InLxuEjaf6htEs+YpTLnXGgIKss8aOVGqszZBT/dghA4fi94N79q804f
	1Az9O7CfKG+hvmmaOQ5Ne4ji9xGYGR1TJddPYhtGQMi8JmEkRZq4GeONYyPIwLEZJw3I=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166977-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 166977: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9012687f05adf96440316ce338514db574ebfde0
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 01 Dec 2021 22:16:11 +0000

flight 166977 xen-unstable-smoke real [real]
flight 166982 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/166977/
http://logs.test-lab.xenproject.org/osstest/logs/166982/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9012687f05adf96440316ce338514db574ebfde0
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    1 days
Testing same since   166977  2021-12-01 17:08:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Luca Fancellu <luca.fancellu@arm.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 22:25:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 22:25:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236250.409793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msY27-0005kh-3T; Wed, 01 Dec 2021 22:24:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236250.409793; Wed, 01 Dec 2021 22:24:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msY26-0005ka-W1; Wed, 01 Dec 2021 22:24:58 +0000
Received: by outflank-mailman (input) for mailman id 236250;
 Wed, 01 Dec 2021 22:24:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msY25-0005kU-Jn
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 22:24:57 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 827ab8b0-52f5-11ec-b1df-f38ee3fbfdf7;
 Wed, 01 Dec 2021 23:24:56 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50710)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msY1x-000oxz-ib (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 22:24:49 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 84DA91FDDA;
 Wed,  1 Dec 2021 22:24:49 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 827ab8b0-52f5-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <835c1244-4cd4-19f9-de7b-e3648d0230bd@srcf.net>
Date: Wed, 1 Dec 2021 22:24:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] x86/vPMU: invoke <vendor>_vpmu_initialise() through a
 hook as well
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <66e64fc5-34f1-7877-42b1-3533136f56ab@suse.com>
 <35e2dab8-e274-839c-23a8-25f4c121cd08@srcf.net>
 <ded8ef9f-9435-1b5e-32a0-1b7e93b15a52@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <ded8ef9f-9435-1b5e-32a0-1b7e93b15a52@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 08:31, Jan Beulich wrote:
> On 30.11.2021 22:18, Andrew Cooper wrote:
>> On 29/11/2021 09:10, Jan Beulich wrote:
>>> --- a/xen/arch/x86/cpu/vpmu.c
>>> +++ b/xen/arch/x86/cpu/vpmu.c
>>> @@ -480,12 +470,17 @@ static int vpmu_arch_initialise(struct v
>>>          return -EINVAL;
>>>      }
>>>  
>>> -    vpmu->hw_lapic_lvtpc = PMU_APIC_VECTOR | APIC_LVT_MASKED;
>>> -
>>> +    ret = alternative_call(vpmu_ops.initialise, v);
>>>      if ( ret )
>>> +    {
>>>          printk(XENLOG_G_WARNING "VPMU: Initialization failed for %pv\n", v);
>>> +        return ret;
>>> +    }
>>> +
>>> +    vpmu->hw_lapic_lvtpc = PMU_APIC_VECTOR | APIC_LVT_MASKED;
>>> +    vpmu_set(vpmu, VPMU_INITIALIZED);
>> It occurs to me that if, in previous patch, you do:
>>
>>     if ( ret )
>>         printk(XENLOG_G_WARNING "VPMU: Initialization failed for %pv\n", v);
>> +    else
>> +        vpmu_set(vpmu, VPMU_INITIALIZED);
>>
>> then you don't need to undo the adjustments in
>> {svm,vmx}_vpmu_initialise() in this patch.
> I actually had it that way first, until noticing it was wrong. It can
> be done only here because it if only here where the XENPMU_MODE_OFF
> checks move from the vendor functions into here.

Oh ok.  Never mind then.

>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>, although
>> preferably with the VPMU_INITIALIZED adjustment.
> Thanks; as said, that adjustment can't be done in patch 1 just yet.
> But I did add the missing trailing commas.

Thanks.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 01 22:42:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 01 Dec 2021 22:42:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236258.409809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msYID-0008Lw-JM; Wed, 01 Dec 2021 22:41:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236258.409809; Wed, 01 Dec 2021 22:41:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msYID-0008Lp-GP; Wed, 01 Dec 2021 22:41:37 +0000
Received: by outflank-mailman (input) for mailman id 236258;
 Wed, 01 Dec 2021 22:41:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=fqf2=QS=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msYIC-0008Lj-3l
 for xen-devel@lists.xenproject.org; Wed, 01 Dec 2021 22:41:36 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d54900b7-52f7-11ec-976b-d102b41d0961;
 Wed, 01 Dec 2021 23:41:33 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:34828)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msYI4-000qjh-7w (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 01 Dec 2021 22:41:28 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 31AB21FDDA;
 Wed,  1 Dec 2021 22:41:28 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d54900b7-52f7-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <9c5c489d-8941-9be9-5af3-734894e99a00@srcf.net>
Date: Wed, 1 Dec 2021 22:41:27 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <a0212d75-fc55-89c8-7ae2-c893c187ad82@suse.com>
 <aa19f4cf-6f62-3bf8-7057-7dae1cf28162@suse.com>
 <17bb5295-6207-0bf4-6432-426729a3a288@srcf.net>
 <b40d95d9-6bf5-e2cc-396c-12c3be6c48eb@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/3] x86/vPMU: convert vendor hook invocations to altcall
In-Reply-To: <b40d95d9-6bf5-e2cc-396c-12c3be6c48eb@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 01/12/2021 07:32, Jan Beulich wrote:
> On 30.11.2021 21:56, Andrew Cooper wrote:
>> On 29/11/2021 09:10, Jan Beulich wrote:
>>> @@ -133,14 +133,13 @@ int vpmu_do_msr(unsigned int msr, uint64
>>>           goto nop;
>>>  
>>>      vpmu = vcpu_vpmu(curr);
>>> -    ops = vpmu->arch_vpmu_ops;
>>> -    if ( !ops )
>>> +    if ( !vpmu_is_set(vpmu, VPMU_INITIALIZED) )
>>>          goto nop;
>>>  
>>> -    if ( is_write && ops->do_wrmsr )
>>> -        ret = ops->do_wrmsr(msr, *msr_content, supported);
>>> -    else if ( !is_write && ops->do_rdmsr )
>>> -        ret = ops->do_rdmsr(msr, msr_content);
>>> +    if ( is_write && vpmu_ops.do_wrmsr )
>>> +        ret = alternative_call(vpmu_ops.do_wrmsr, msr, *msr_content, supported);
>>> +    else if ( !is_write && vpmu_ops.do_rdmsr )
>>> +        ret = alternative_call(vpmu_ops.do_rdmsr, msr, msr_content);
>> Elsewhere, you've dropped the function pointer NULL checks.  Why not here?
> No, I'm not dropping any function pointer checks here; all I drop is
> checks of the ops pointer being NULL. These checks all get dropped in
> patch 3.

Oh ok.

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
>>> --- a/xen/include/asm-x86/vpmu.h
>>> +++ b/xen/include/asm-x86/vpmu.h
>>> @@ -61,25 +61,25 @@ struct vpmu_struct {
>>>      u32 hw_lapic_lvtpc;
>>>      void *context;      /* May be shared with PV guest */
>>>      void *priv_context; /* hypervisor-only */
>>> -    const struct arch_vpmu_ops *arch_vpmu_ops;
>>>      struct xen_pmu_data *xenpmu_data;
>>>      spinlock_t vpmu_lock;
>>>  };
>>>  
>>>  /* VPMU states */
>>> -#define VPMU_CONTEXT_ALLOCATED              0x1
>>> -#define VPMU_CONTEXT_LOADED                 0x2
>>> -#define VPMU_RUNNING                        0x4
>>> -#define VPMU_CONTEXT_SAVE                   0x8   /* Force context save */
>>> -#define VPMU_FROZEN                         0x10  /* Stop counters while VCPU is not running */
>>> -#define VPMU_PASSIVE_DOMAIN_ALLOCATED       0x20
>>> +#define VPMU_INITIALIZED                    0x1
>>> +#define VPMU_CONTEXT_ALLOCATED              0x2
>>> +#define VPMU_CONTEXT_LOADED                 0x4
>>> +#define VPMU_RUNNING                        0x8
>>> +#define VPMU_CONTEXT_SAVE                   0x10  /* Force context save */
>>> +#define VPMU_FROZEN                         0x20  /* Stop counters while VCPU is not running */
>>> +#define VPMU_PASSIVE_DOMAIN_ALLOCATED       0x40
>>>  /* PV(H) guests: VPMU registers are accessed by guest from shared page */
>>> -#define VPMU_CACHED                         0x40
>>> -#define VPMU_AVAILABLE                      0x80
>>> +#define VPMU_CACHED                         0x80
>>> +#define VPMU_AVAILABLE                      0x100
>>>  
>>>  /* Intel-specific VPMU features */
>>> -#define VPMU_CPU_HAS_DS                     0x100 /* Has Debug Store */
>>> -#define VPMU_CPU_HAS_BTS                    0x200 /* Has Branch Trace Store */
>>> +#define VPMU_CPU_HAS_DS                     0x1000 /* Has Debug Store */
>>> +#define VPMU_CPU_HAS_BTS                    0x2000 /* Has Branch Trace Store */
>> Seeing as you're shuffling each of these, how about adding some leading
>> 0's for alignment?
> Fine with me; I did consider it at the time of writing the patch,
> but decided that such a change of non-mandatory style may not be
> justified here (or even in general), as there are also downsides
> to such padding: Once adding a constant with more significant
> digits, all pre-existing ones need touching to insert yet another
> zero.

I don't mind specifically if it gets left as-is, but having a pile of
constants like this tabulated correct makes a massive improvement to
code clarity.


That said, this whole flags infrastructure is almost exclusively
obfuscation, and I've got a good mind to replace it all with a
bitfield.  I'll save taking some shears to this code for another time.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 00:17:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 00:17:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236266.409827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msZn6-00027i-0M; Thu, 02 Dec 2021 00:17:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236266.409827; Thu, 02 Dec 2021 00:17:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msZn5-00027b-Sg; Thu, 02 Dec 2021 00:17:35 +0000
Received: by outflank-mailman (input) for mailman id 236266;
 Thu, 02 Dec 2021 00:17:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msZn4-00027R-ES; Thu, 02 Dec 2021 00:17:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msZn4-0008Mx-13; Thu, 02 Dec 2021 00:17:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msZn3-0002GH-MZ; Thu, 02 Dec 2021 00:17:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msZn3-0000Gp-M2; Thu, 02 Dec 2021 00:17:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jjFM69zRGmngVzMLD/C+h0nCS/xmP0SgME0QIp5D3OU=; b=tRoXJ+T8GhC5Q3tF2g1V4Eh4mn
	/IARqEZisO+GZPzWqQMCI3szGd7LVausqUUcgPu3bx2scg9c0gbEeOaezu9NJPSFHLOoFUaVix9Hm
	ABwdnP9HFtNMdvqNFXAQhyMu+rWvZFpfa0u3xVUvWWrspj7oPR60MCILKX7aWgKx0yRE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166970-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 166970: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-libvirt:guest-start:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    linux-5.4:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
X-Osstest-Versions-That:
    linux=9334f48f567334f54101223012ec9d3b4628bed8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 00:17:33 +0000

flight 166970 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166970/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt     14 guest-start              fail REGR. vs. 166839
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 166839
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl          22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166839
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166839
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166839
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166839
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5
baseline version:
 linux                9334f48f567334f54101223012ec9d3b4628bed8

Last test of basis   166839  2021-11-26 10:11:13 Z    5 days
Testing same since   166970  2021-12-01 08:40:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Chuanqi Liu <legend050709@qq.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  Diana Wang <na.wang@corigine.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Grzegorz Jaszczyk <jaz@semihalf.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Huang Pei <huangpei@loongson.cn>
  Hulk Robot <hulkrobot@huawei.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gerecke <jason.gerecke@wacom.com>
  Jason Gerecke <killertofu@gmail.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol@gmail.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kumar Thangavel <kumarthangavel.hcl@gmail.com>
  Kumar Thangavel <thangavel.k@hcl.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Manfred Spraul <manfred@colorfullife.com>
  Marek Behún <kabel@kernel.org>
  Marek Behún <marek.behun@nic.cz>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Mingjie Zhang <superzmj@fibocom.com>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nitesh B Venkatesh <nitesh.b.venkatesh@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Ondrej Jirman <megous@megous.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Peng Fan <peng.fan@nxp.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Remi Pommarel <repk@triplefau.lt>
  Richard Cochran <richardcochran@gmail.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Mendoza-Jonas <sam@mendozajonas.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <horms@verge.net.au>
  Simon Horman <simon.horman@corigine.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
  Tobias Brunner <tobias@strongswan.org>
  Todd Kjos <tkjos@google.com>
  Tomasz Maciej Nowak <tmn505@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Weichao Guo <guoweichao@oppo.com>
  yangxingwu <xingwu.yang@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3389 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 01:08:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 01:08:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236281.409852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msaaA-0003pg-3C; Thu, 02 Dec 2021 01:08:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236281.409852; Thu, 02 Dec 2021 01:08:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msaaA-0003pZ-0O; Thu, 02 Dec 2021 01:08:18 +0000
Received: by outflank-mailman (input) for mailman id 236281;
 Thu, 02 Dec 2021 01:08:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ufdD=QT=intel.com=megha.dey@srs-se1.protection.inumbo.net>)
 id 1msaa8-0003pT-IW
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 01:08:16 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 51349ba5-530c-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 02:08:13 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 01 Dec 2021 17:08:10 -0800
Received: from meghadey-mobl1.amr.corp.intel.com (HELO [10.213.191.214])
 ([10.213.191.214])
 by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 01 Dec 2021 17:08:09 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51349ba5-530c-11ec-b1df-f38ee3fbfdf7
X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="216611002"
X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; 
   d="scan'208";a="216611002"
X-IronPort-AV: E=Sophos;i="5.87,280,1631602800"; 
   d="scan'208";a="602514884"
Message-ID: <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com>
Date: Wed, 1 Dec 2021 17:08:01 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
 Ashok Raj <ashok.raj@intel.com>, Michael Ellerman <mpe@ellerman.id.au>,
 Andrew Cooper <amc96@cam.ac.uk>, Juergen Gross <jgross@suse.com>,
 linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
From: "Dey, Megha" <megha.dey@intel.com>
In-Reply-To: <20211127000919.004572849@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Thomas,
On 11/26/2021 5:25 PM, Thomas Gleixner wrote:
> Provide a new interface which allows to expand the MSI-X vector space if
> the underlying irq domain implementation supports it.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>   drivers/pci/msi/msi.c |   41 +++++++++++++++++++++++++++++++++++++++++
>   include/linux/pci.h   |   13 +++++++++++++
>   2 files changed, 54 insertions(+)
>
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -1025,6 +1025,47 @@ int pci_alloc_irq_vectors_affinity(struc
>   EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
>   
>   /**
> + * pci_msix_expand_vectors_at - Expand MSI-X interrupts for a device
> + *
> + * @dev:	PCI device to operate on
> + * @at:		Allocate at MSI-X index. If @at == PCI_MSI_EXPAND_AUTO
> + *		the function expands automatically after the last
Not sure why some of these changes related to PCI_MSIX_EXPAND_AUTO and 
num_descs did not make it to the 'msi' branch.
Is this intentional?
> + *		active index.
> + * @nvec:	Number of vectors to allocate
> + *
> + * Expand the MSI-X vectors of a device after an initial enablement and
> + * allocation.
> + *
> + * Return: 0 if the allocation was successful, an error code otherwise.
> + */
> +int pci_msix_expand_vectors_at(struct pci_dev *dev, unsigned int at, unsigned int nvec)
> +{
> +	struct msi_device_data *md = dev->dev.msi.data;
> +	struct msi_range range = { .ndesc = nvec, };
> +	unsigned int max_vecs;
> +	int ret;
> +
> +	if (!pci_msi_enable || !dev || !dev->msix_enabled || !md)
> +		return -ENOTSUPP;
> +
> +	if (!pci_msi_domain_supports_expand(dev))
> +		return -ENOTSUPP;
> +
> +	max_vecs = pci_msix_vec_count(dev);
> +	if (!nvec || nvec > max_vecs)
> +		return -EINVAL;
> +
> +	range.first = at == PCI_MSIX_EXPAND_AUTO ? md->num_descs : at;
> +
> +	if (range.first >= max_vecs || nvec > max_vecs - range.first)
> +		return -ENOSPC;
> +
> +	ret = msix_setup_interrupts(dev, dev->msix_base, &range, NULL, NULL, true);
> +	return ret <= 0 ? ret : -ENOSPC;;
> +}
> +EXPORT_SYMBOL_GPL(pci_msix_expand_vectors_at);
> +
I am having trouble fully comprehending how this expansion scheme would 
work..

For instance, say:
1. Driver requests for 5 vectors:
pci_enable_msix_range(dev, NULL, 5, 5)
=>num_descs = 5

2. Driver frees vectors at index 1,2:
range = {1, 2, 2};
pci_msi_teardown_msi_irqs(dev, range)
=>num_descs = 3; Current active vectors are at index: 0, 3, 4

3. Driver requests for 3 more vectors using the new API:
pci_msix_expand_vectors(dev, 3)
=>range.first = 3 => It will try to allocate index 3-5, but we already 
have 3,4 active?
Ideally, we would want index 1,2 and 5 to be allocated for this request 
right?

Could you please let me know what I am missing?

With the 'range' approach, the issue is that we are trying to allocate 
contiguous indexes. Perhaps, we also need to check if all the indexes in 
the requested range are available,
if not, find a contiguous range large enough to accommodate the request. 
But there will be fragmentation issues if we choose to go with this way...

I had a version of the dynamic MSI-X patch series (which never got sent 
out). For the expansion, I had the following:
pci_add_msix_irq_vector(pdev): On each invocation, add 1 MSI-X vector to 
the device and return the msi-x index assigned by the kernel (using a 
bitmap)
Correspondingly, pci_free_msix_irq_vector(pdev, irq) frees all the 
allocated resources associated with MSI-X interrupt with Linux IRQ 
number 'irq'.
I had issues when trying to dynamically allocate more than 1 interrupt 
because I didn't have a clean way to communicate to the driver what 
indexes were assigned in the current allocation.

-Megha
>


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 03:20:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 03:20:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236296.409876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mscdg-0001kS-6m; Thu, 02 Dec 2021 03:20:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236296.409876; Thu, 02 Dec 2021 03:20:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mscdg-0001jY-0i; Thu, 02 Dec 2021 03:20:04 +0000
Received: by outflank-mailman (input) for mailman id 236296;
 Thu, 02 Dec 2021 03:20:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mscde-0001T7-EL; Thu, 02 Dec 2021 03:20:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mscde-000793-4f; Thu, 02 Dec 2021 03:20:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mscdd-0003EK-Qs; Thu, 02 Dec 2021 03:20:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mscdd-0004WC-QQ; Thu, 02 Dec 2021 03:20:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RMGoVwiCyRIhjC58CoxQm3aBB/yds8cQ95g+cXwPUdY=; b=BN2MPEaLCa+vlykXUaJ0FzQmCV
	E7ZZjnYqqEP761msWFhyvmyzkKemseLaToMgXfVv2ztodS0jrSeFmMX4jTteEyVdVeOh5vob5NZ2L
	KtSbugpc4t1ArmjID6XLB1r4zYckHkIJYmohzZ/u8X3BFMXW+bvopWYW0Tl51DZmv5gU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166988-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 166988: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb41074692094dff1413efb44fa4928a9140aa41
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 03:20:01 +0000

flight 166988 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166988/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166958
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb41074692094dff1413efb44fa4928a9140aa41
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    1 days
Failing since        166977  2021-12-01 17:08:21 Z    0 days    2 attempts
Testing same since   166988  2021-12-01 23:02:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 05:34:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 05:34:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236309.409905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msejQ-0007xF-2L; Thu, 02 Dec 2021 05:34:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236309.409905; Thu, 02 Dec 2021 05:34:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msejP-0007x8-VP; Thu, 02 Dec 2021 05:34:07 +0000
Received: by outflank-mailman (input) for mailman id 236309;
 Thu, 02 Dec 2021 05:34:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msejO-0007wy-Ju; Thu, 02 Dec 2021 05:34:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msejO-0001Rm-99; Thu, 02 Dec 2021 05:34:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msejN-0001E0-Vg; Thu, 02 Dec 2021 05:34:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msejN-00077k-V7; Thu, 02 Dec 2021 05:34:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UmENZADLTRsfuHfrE6VPM28SAAYs+QCnXCIwTfsrWrg=; b=CFZNRBOK5NiyQSElXCcZ8Ids4k
	g8bZW/krAykjBZCFxAZ1HtpBonzKZlVHsvgXyScqQfahp8lBSRC9IGsIquskqmgzaRFHxtmt7Jb0G
	yBDH3jQBAbfjLE14+9MFRo/U4RydBqtT/w7LSTAlU7fiNAl7ZJeJ/MClxegBOeqGZv/c=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166975-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 166975: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-destroy:fail:regression
    xen-unstable:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    xen-unstable:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl:guest-destroy:fail:regression
    xen-unstable:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:regression
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-stop.audited:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-pygrub:guest-start.2:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 05:34:05 +0000

flight 166975 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166975/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-libvirt-xsm  22 guest-destroy            fail REGR. vs. 166912
 test-amd64-i386-xl-xsm      22 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166941
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl           24 guest-destroy            fail REGR. vs. 166941
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-libvirt    18 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-vhd     17 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 166966 REGR. vs. 166912
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 166966 REGR. vs. 166941
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail in 166966 REGR. vs. 166941
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 23 guest-stop.audited fail in 166966 REGR. vs. 166941

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl          14 guest-start      fail in 166966 pass in 166975
 test-amd64-i386-xl           14 guest-start      fail in 166966 pass in 166975
 test-amd64-i386-pair       25 guest-start/debian fail in 166966 pass in 166975
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail in 166966 pass in 166975
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 166966 pass in 166975
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail in 166966 pass in 166975
 test-armhf-armhf-libvirt     14 guest-start      fail in 166966 pass in 166975
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166966 pass in 166975
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 166975
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 166966 pass in 166975
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 166966 pass in 166975
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 166966 pass in 166975
 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start           fail pass in 166966
 test-arm64-arm64-libvirt-xsm 14 guest-start                fail pass in 166966
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 166966
 test-amd64-amd64-xl-credit2  22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-xl-credit1  22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-i386-xl-shadow    22 guest-start/debian.repeat  fail pass in 166966
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166966
 test-arm64-arm64-xl          18 guest-start/debian.repeat  fail pass in 166966
 test-armhf-armhf-xl          14 guest-start                fail pass in 166966
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-pygrub      22 guest-start.2              fail pass in 166966
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166966

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166941

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail in 166966 blocked in 166941
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 166966 never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 166966 never pass
 test-armhf-armhf-xl         15 migrate-support-check fail in 166966 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 166966 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    4 days
Failing since        166960  2021-11-30 12:35:41 Z    1 days    3 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      fail    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 396 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 06:13:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 06:13:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236319.409928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msfKz-0004Lj-3d; Thu, 02 Dec 2021 06:12:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236319.409928; Thu, 02 Dec 2021 06:12:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msfKz-0004Lc-0S; Thu, 02 Dec 2021 06:12:57 +0000
Received: by outflank-mailman (input) for mailman id 236319;
 Thu, 02 Dec 2021 06:12:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uf4i=QT=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1msfKx-0004Jz-HI
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 06:12:55 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2a82486-5336-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 07:12:54 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5CB52212BE;
 Thu,  2 Dec 2021 06:12:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86CF813DFB;
 Thu,  2 Dec 2021 06:12:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id pWBwHuRjqGE4HwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 02 Dec 2021 06:12:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2a82486-5336-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638425573; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=PoHxH+44BVmQxV5StpyJtBKJQ6b18O343WAGNo7xpu4=;
	b=QxcuKPLlhBOYjqMoxMu9oUKMyvifbvVJlHyE3jKEW5UGA42eRXO48W3J25IBX3DFsdPI0x
	aoHstQUDTMO6jZeLSN7Or6gKVcZjU6fPwe6GjTKt+CaPeqsOr3Yssx3q1F3VsNQClvdoI0
	PnS5vd2zhFgWM1+oBblZyuz39IwZkS4=
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 boris.ostrovsky@oracle.com, sstabellini@kernel.org, roger.pau@citrix.com,
 axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
Date: Thu, 2 Dec 2021 07:12:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="AfdMuwUczXW0MKITwWVq4jy42wC20ICQg"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--AfdMuwUczXW0MKITwWVq4jy42wC20ICQg
Content-Type: multipart/mixed; boundary="pQIE5E6xcpkHUkTK3irWuIH6aIHhgRqRR";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 boris.ostrovsky@oracle.com, sstabellini@kernel.org, roger.pau@citrix.com,
 axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Message-ID: <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>

--pQIE5E6xcpkHUkTK3irWuIH6aIHhgRqRR
Content-Type: multipart/mixed;
 boundary="------------90B5D640AB7801A38E7FE002"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------90B5D640AB7801A38E7FE002
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 01.12.21 22:10, Christophe JAILLET wrote:
> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid =
some
> open-coded arithmetic in allocator arguments.
>=20
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.
>=20
> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>   drivers/block/xen-blkfront.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.=
c
> index 700c765a759a..fe4d69cf9469 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int minor=
, unsigned int nr)
>   	if (end > nr_minors) {
>   		unsigned long *bitmap, *old;
>  =20
> -		bitmap =3D kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> -				 GFP_KERNEL);
> +		bitmap =3D bitmap_zalloc(end, GFP_KERNEL);
>   		if (bitmap =3D=3D NULL)
>   			return -ENOMEM;
>  =20
>   		spin_lock(&minor_lock);
>   		if (end > nr_minors) {
>   			old =3D minors;
> -			memcpy(bitmap, minors,
> -			       BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
> +			bitmap_copy(bitmap, minors, nr_minors);
>   			minors =3D bitmap;
>   			nr_minors =3D BITS_TO_LONGS(end) * BITS_PER_LONG;
>   		} else

Shouldn't you use bitmap_free(old) some lines down?

> @@ -2610,7 +2608,7 @@ static void __exit xlblk_exit(void)
>  =20
>   	xenbus_unregister_driver(&blkfront_driver);
>   	unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
> -	kfree(minors);
> +	bitmap_free(minors);
>   }
>   module_exit(xlblk_exit);


Juergen


--------------90B5D640AB7801A38E7FE002
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------90B5D640AB7801A38E7FE002--

--pQIE5E6xcpkHUkTK3irWuIH6aIHhgRqRR--

--AfdMuwUczXW0MKITwWVq4jy42wC20ICQg
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGoY+MFAwAAAAAACgkQsN6d1ii/Ey9C
GQf7B6nQsjmwuu6nmhJBkobL+EuHIRbd8Q+Fp4t1UNVICF9LvicwjotgNHBHo0LRRxq0vWn6E8td
31rc+lkllzJ5oDo2gsFTbgZxPXc83NA0MTPygu+E1bKQNOUhJqKtgryvIoeWAl4/VAu4f4RhFVPI
0F/GLXISo/1UXVO9Yk/aokmFHIK5RR/vzuTc3XPhbsNiIjIydv3ba2Wa5UXqsp8bN5vi3+HQp0hu
Wxgsdluph/jEidWDVWFQHj2namNURRXFhqJA2ImwE5e0aHs4Yfd+RAAF437L+zSDtX549zo0HONd
HGVya/rFi+QEWNCaDpq4FoN6JafAsS+P56dgQq+x6Q==
=QD8J
-----END PGP SIGNATURE-----

--AfdMuwUczXW0MKITwWVq4jy42wC20ICQg--


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 07:17:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 07:17:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236328.409950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgKu-0002v3-35; Thu, 02 Dec 2021 07:16:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236328.409950; Thu, 02 Dec 2021 07:16:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgKu-0002uw-04; Thu, 02 Dec 2021 07:16:56 +0000
Received: by outflank-mailman (input) for mailman id 236328;
 Thu, 02 Dec 2021 07:16:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msgKt-0002um-AA; Thu, 02 Dec 2021 07:16:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msgKt-0003CR-5z; Thu, 02 Dec 2021 07:16:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msgKs-0005eV-U0; Thu, 02 Dec 2021 07:16:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msgKs-0001Te-TX; Thu, 02 Dec 2021 07:16:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nr/fjLzjs3fvsgJqC7983HClMZ6vRd3JJjZ2IHO386U=; b=ccZSSVmMfsz7y1lLcHn4MDUKel
	vLqhlzYpGXbo1c6EprZKDPE+HaRYWIlFLCSuzPEWyHPG21RsdPpNb7ZSVKo0gAY5ZJJxMux7MQbQO
	KcvTrDALVn04pzIxhCA/5pCcCd1eNHZvehEurdDGT/p1pU35TCd9edZNodzY5SG5jwYA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166995-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 166995: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start:fail:heisenbug
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb41074692094dff1413efb44fa4928a9140aa41
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 07:16:54 +0000

flight 166995 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166995/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166958
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail in 166988 REGR. vs. 166958

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt     14 guest-start                fail pass in 166988
 test-armhf-armhf-xl          18 guest-start/debian.repeat  fail pass in 166988

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt    15 migrate-support-check fail in 166988 never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb41074692094dff1413efb44fa4928a9140aa41
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    1 days
Failing since        166977  2021-12-01 17:08:21 Z    0 days    3 attempts
Testing same since   166988  2021-12-01 23:02:57 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 07:24:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 07:24:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236335.409965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgS5-0004L5-Ph; Thu, 02 Dec 2021 07:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236335.409965; Thu, 02 Dec 2021 07:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgS5-0004Ky-Me; Thu, 02 Dec 2021 07:24:21 +0000
Received: by outflank-mailman (input) for mailman id 236335;
 Thu, 02 Dec 2021 07:24:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msgS4-0004Ks-8q
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 07:24:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dcaacfc9-5340-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 08:24:19 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-mBKoVXJTPLufmJAA7_2L_Q-1; Thu, 02 Dec 2021 08:24:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 07:24:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 07:24:16 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0368.eurprd06.prod.outlook.com (2603:10a6:20b:460::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Thu, 2 Dec 2021 07:24:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dcaacfc9-5340-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638429858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fzxGWKaoW59Od2WpYxt5a7eai2jl7ItmwhCtKOxvhiI=;
	b=dDTQQHrqvKuuS0BJpGUdUt9Dt5tVZbIBa0/SndVBmHPRPspRKUlUkRRItrPLarE7PYAJXY
	6CLCTiIRPEhc+Ilqw/ughkGP6igIgonUN3uHMshU9BUB6Qi+riM9wwieH/uSYK2oP+To2N
	sI2YBZZ1pvY/Bv+DJyhhz5qrEshjsAE=
X-MC-Unique: mBKoVXJTPLufmJAA7_2L_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RCc9VQbwNLgYa1LnyZ0X62lqda6fM714DOuLTYCzPGgbs34nBt5RYA0KJ7sgaJc3VklG7laE8kuDJ0WT6xwaXQa5zmHXQ7W62WK4PuFgRd2JjHgidLl/lgOpoLh3ypVFOGmrpNZhKnZOa1Op3/4UQmFmsIV3TPfeTVesn4TNWzM1iAtmUTchCgjcSSYN7bbU4ivz15+OL0cqr1/Lg1t0gEEzhrEcNi8B/0tb0F8QtR2Sv2fmsD5YJoVIrJANCzdvTNbJLItZz0D1MxLro1ORg0USs61zHp8SIa+cBTBza6vUWdF8HMRQUZCYo/CesBDIAF5g4NUZAd6IZCbK5qs6cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fzxGWKaoW59Od2WpYxt5a7eai2jl7ItmwhCtKOxvhiI=;
 b=oVTmhfszWVafRY6zKJBoV/pNButWmk4VYIZkvRa3/kGGWlbwvH17o9T+8KOKH+UBc7cCVl8T2XnlY1yyT4LnFLt0t/tU7qYj5HEu1zbgewQisv6SxX97TYlQ3T2EKAyY2S+RJ1kaTSVnhSuvoJKOskLIywdEBHQHnVkHmh3/gLV3PSGsYe1veid8Fy2s2X22Jl0+hCGER6s/hKxlm4LtySRQun2SPtQtnOvVGVFuVdXcjRGIZ6u13e7Z4taORaEygC6/hXfACOuMcbpLNk/OTnAP3hbUAZ1ENrGQcGANJzC4caa8T2RNrJhSd0mmGkqTNjDLz+r72qndsRrr05OKXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f2b76ad4-6221-7e5b-b9d2-625f97167ba3@suse.com>
Date: Thu, 2 Dec 2021 08:24:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/4] IOMMU/x86: switch to alternatives-call patching in
 further instances
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <f7a7ce32-f921-ced7-4699-26f907392eb4@suse.com>
 <3dbcb5ed-c776-84d8-92a7-b9d265ef7d7b@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3dbcb5ed-c776-84d8-92a7-b9d265ef7d7b@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0368.eurprd06.prod.outlook.com
 (2603:10a6:20b:460::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: efb13d62-31bb-41c4-94d1-08d9b564bf97
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57429D0B41306203F9900FBFB3699@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X2nqWqrV4SUvI68NXW7WvifGsg3OhnLBDWZyfLQQPqHpFqGcXtiovhUUXPhdc67GfQdwq2WuTb0hgCSZxkmWuYFvLvrWJ+ukYlYYPmbb1duT+tzO0C8NqK9kfSQl1nSqgb4+uw+W85ZYNZaHS57BxDXoOZHhUKcpaC6HOYdh+4uytfms1YiDAbV0kpUeorb7v6YmvEfnChRtC1S4ufSIRXSSY/e195U7X/+BE5JYWLHpRIIdJUNc4s230JKYkx7a8NL8aAZ9Xdf46AVTPptz/oRp2ZLBbMa9NDmruy035pUoLTuM/XJ6NH175aQ0WQlIyXjVnwXyOnl5Fcgf+n/MaL6dmkZUh+ogg+U7YlGlpa5N5MCKwyIAbwM+aHiuJl6cV8woplNBFj3v6W6VUtqW0Yewmh2rLxYNvhZJbALaYT7SmxvLtNgMazVDRkFyVC69ZoSGenzcR/QOKWd7MB3eOBPk8x5cLBxMbE28bFWv21gnCnmiMj5uwOxoGt/5p+XP9iseld9yh5Qrfl4CapiWZiQwDrdg07TiWpcKAHzl3KA7y8tgAC0lWBe2LLCGJZnJYDlCejAGHa3HUuoFqUnSgdHzmpvKn47xOeenOSYYJqCHPcFiowz0W4RD+Dnjg1IuGrffaQN+jnBm4Xt+fN6gTX6QmJCEGvLB/zOTm3YdpafsQOkSK17hAj/Vv3/LA4J/YP3bCcy4Iy+PFeJbyOaFrfXrfdoSY3GoN5Bf1hK8ACk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(66476007)(66946007)(8936002)(6486002)(4326008)(31686004)(36756003)(66556008)(31696002)(4744005)(956004)(16576012)(38100700002)(2616005)(508600001)(2906002)(8676002)(316002)(86362001)(53546011)(54906003)(186003)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NDd3VWtwb1F4akhvT2pkVmFHTkpDV2hWdG1qcWlCT3R3a2dUbE1wd05hcHdP?=
 =?utf-8?B?ZGdsOEFmc2JmOFFRZFNET2NYUlg4aGM5OG1JSFZqTFdaM0xGL2NBYzgrVWFB?=
 =?utf-8?B?Q1JIbEt0eDFlM2ZrdDg1Vm03MEY4czJsMDZRRlVSNHdTUERYYzNMZGJIM2tM?=
 =?utf-8?B?ajVhYlQ3eHcxdy9CT3cyVSt5bkNsTEZOUTdiV3RkTUwzRkJRU28xd3dTQ2I5?=
 =?utf-8?B?ZzFxeGRoVERFekVGK040K2NPcXBEaXljMmF6VHBDeWh6d2p2Vy93TDB1Qitt?=
 =?utf-8?B?a0J0ZG9TL0NGOHg2RG91V1FETk9yazJsY0hkRkg3S1VNR0tGZWpwWklYM0hB?=
 =?utf-8?B?d1pkKzNLaVQ4aURvdXk1MEFhVUF3MWUrTlMyZkIySExsSGJOeGc3YmxhbTVu?=
 =?utf-8?B?M2pNL0laZjZHclhWMUpzanF2OGNJKzA0dGczNFZ3S0t3V0c2OGJoRWc3Y2Nx?=
 =?utf-8?B?QjJSZjdoOGhyVEJVdlZHczBNWmlQbzZrY2tzSzAzQitSenZJQytqZTRvZXVC?=
 =?utf-8?B?MDBOcEVtbXdrcHppQ3k0RW9DT1BwOVlucnF3QzRTTHlLcHY5U3BSb3pnRVdC?=
 =?utf-8?B?N256RW8rdDB6OHEwYTZveDYxTklxSm1IOEVrS0tnM2hEWkVKNm9Mc01RYjRj?=
 =?utf-8?B?N2tOalRBdVM5eXR4UmFrQUNYWGhYYXVUTENNcEtmV2Q5RUFiZEF1RWdaZkpw?=
 =?utf-8?B?bGxVekhpYjRYNFZHMXZNZkFxSTgrenlCQ1ZuRVMxOXhtQzkyRTBhZUo5T3hY?=
 =?utf-8?B?OURKVjRad3ZGVWtBWUUrcGd5ME5lTUk4bm9CQ0xTOTRlUlplVW91dnk4THor?=
 =?utf-8?B?V2lpMW0yUUhvWTkvdmlsSHlrSnFxbk9SSk9nUkdSdnp2UlRsTTdmbURzblU0?=
 =?utf-8?B?b09Fa2FzWGJrNlpFRmc2NUdJNG1ZSS9XRW9zU3ZGbEhDbFNLTlFYeGdyNGI4?=
 =?utf-8?B?SGlza3NmQUtPRXBkcUhYbklJWHpZSUF1NGtTVmljSDY1Mm1WczdUeGRtRWVv?=
 =?utf-8?B?cHN5c3RTemZLWGdjRHEyakovZ3Vhb3AvdEdGQXhKcFI2NWt5S2Y3UTlaUUQ0?=
 =?utf-8?B?WWVhRVNaYjhsU0VGL2dqa0pUcVdVd0k2TCthVitENnhoQXBhanE2Mm0wLzJz?=
 =?utf-8?B?TDB2VHBXZGVWR3JURTFCMDBiRlVHcEpPM0VPQW5nU2NscnJWeXRCZ1NqSFN0?=
 =?utf-8?B?dHVqSDRJQmRaRjdhSE5xTlRTaC9weENONXF6T25ZcnYyVExLWGZyZ0l1RjFP?=
 =?utf-8?B?VUtPUi8ybW5aNmFScWJPY3dJbXVNeHFtUlRIdnd6dEpZeEV4aDM4TkhISHBx?=
 =?utf-8?B?anRhM2lsSnpnL1JITHBzdC90MHNhUXZEK2tLUzZoZDVURmYydkJac0V6YWUx?=
 =?utf-8?B?ZmVUYm5UMmRHalEwNWJCRXY2Q093YkUrYUtJYWdqWUdjRnVKZGRPV1VwVlZK?=
 =?utf-8?B?YTlQYVcxVnNuMUgrbEtURU9EVS9TZ2oxMmRyQytEZ29vMFZFTGU0Q1ZNNWlq?=
 =?utf-8?B?M0JsVzJCbkgrTU1mb2lLZG1oanFseXpaTnpQR1pHSXpDM3R1YzJmWmZjZE04?=
 =?utf-8?B?cVFEZXJTMjc1UTRiSDBzSUV5NDh0SHRMR0ZvcDhYSkkvN0l5WU1PcUIzZzU2?=
 =?utf-8?B?UEU2RWpWcm9SQzQrYUtqUi82RDRTZHQ4eGNsR2ViYmV2Ny9lYVRkaU5SR3g0?=
 =?utf-8?B?Rkl4TWxPeXhQeE1LZ0FQY2NubmNxd000UjFTMzNvdERNcktlVS90c2hIUHFn?=
 =?utf-8?B?MUFFQ0hLSHJzT0srQUVYV1dZam15dlV3SjJvWnN1VXg4WEVHWHQxUkQ2UHJL?=
 =?utf-8?B?aVJmWFZZUTYzMHM4NXVEbjlva1pHdUczVjB5akpCa293dkRTVDE4d2Jxb3lZ?=
 =?utf-8?B?WkpmZy9KaWppejdaaExldlNFZ0F5bTI2QjJXY1IvZDVxYTY3RmxtUHk5enQ2?=
 =?utf-8?B?UkRtWnBnb1g0aWtLRkl4b1ozRHlXWHlwUDArM3ZLcGo2TGRNMGdUWkF0WU1R?=
 =?utf-8?B?Y21veVpvVFBYenZNUzQzZzFPa0VnajU5TVV1VkJ6azhoVVR6QUpRR3huSGoz?=
 =?utf-8?B?ckljamhtUGZNVzN0eElNTno2YktEUmZQUk5yVllzcExJUjBTdjlkVnlnWWZx?=
 =?utf-8?B?NzY3dnhmWk9pY09iRDR0c3pQV0JPN0R5QWpSeEk5cTkxR1U4Q0RCUmEycThG?=
 =?utf-8?Q?RNET2X3zPsmSk2wVb/JVwYI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efb13d62-31bb-41c4-94d1-08d9b564bf97
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 07:24:16.6804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P/eM319uPOA9Mi52qWUMgOvFqsKrPJP1Z/5xmOFzy75F1nSYixMO+BgL6q/LY2c8obrjNh7ilP0iKSIYXHykIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 01.12.2021 16:13, Andrew Cooper wrote:
> On 01/12/2021 09:39, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group(
>>      if ( !is_iommu_enabled(d) || !ops->get_device_group_id )
>>          return 0;
>>  
>> -    group_id = ops->get_device_group_id(seg, bus, devfn);
>> +    group_id = iommu_call(ops, get_device_group_id, seg, bus, devfn);
> 
> So I was going to suggest adjusting this to use more pci_sbdf_t, but the
> Intel implementation can fail and return -1.

How are the two aspects related? Wouldn't you mean the parameter of the
function to become pci_sbdf_t? If so, I'd view this as an orthogonal
change. I'll reply to the question of removal on the subthread of patch 4.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 07:30:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 07:30:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236342.409975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgYJ-0005xi-KD; Thu, 02 Dec 2021 07:30:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236342.409975; Thu, 02 Dec 2021 07:30:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msgYJ-0005xb-Gw; Thu, 02 Dec 2021 07:30:47 +0000
Received: by outflank-mailman (input) for mailman id 236342;
 Thu, 02 Dec 2021 07:30:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msgYI-0005xV-08
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 07:30:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c212a2e3-5341-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 08:30:45 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-Lr4XQ64lMVuIZUKIOfwxnw-1; Thu, 02 Dec 2021 08:30:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7040.eurprd04.prod.outlook.com (2603:10a6:800:121::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 07:30:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 07:30:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0088.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Thu, 2 Dec 2021 07:30:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c212a2e3-5341-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638430243;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dSIifU+P2EvTWsn/xzDMk5vCsMNBEysWPaExFM22GEQ=;
	b=hTcPgWRDIF7zkHDWW7jhUH6PW7wu+PTVr+PcGCPfoJ3gg+ZZML00859+INltsAQg2aYFDi
	Lqkt+X6fiSMzTCuxeYK6xt4ySM+9lHca1ODRC9/08JuGa84lN8u5Jrr6cN0XI+pduvqsaT
	+chKIh1oRNi07wvOFRF/3KG7SuYE6RQ=
X-MC-Unique: Lr4XQ64lMVuIZUKIOfwxnw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ii60zwkFTm71zxzguSwahRvjo8lKuMRPv9gkrVaGX88AridwDv2QGPPrR18vayZKClru5svRNURwMC7afaXZ3lcx0i26YbdCyJ8ZRAASZeOcen2Z0B4+x8PjbQX10F9pBApzR7CjWsy3w+G22j6AXDNZVc7yMrsoNWyU1NPxRQgqWoBzMTogPkTSsBc2b8GWeoAYrMf3LvebAJILetZ+oHQeplqRJaOZ+KHoDoCgPz5jErLH7lJx74oc8ApXRmGMYj92DZccc1D+xMzQo2OIhqXhXfZiaf20R96Jg7zPI25mC6NmngmBR5J2d+gSr5zjWEJHybeHwqSY+KiXmAvjwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oAqlqgzhEnJGOcrJ57AoOl+1KamxRZmtYbGPvq45KW4=;
 b=C+dEzY7FoD/0fBi1tG/3up41WK/2aX31MAoHZJ79xsdoGNgA3xi54CE5n89ZuyVc70EJbE1MJv5PbJKAU7SHRV8Zc1u2hHozGDYh243FeQkm1AaDqtNkoyYnOeA0z/GNMH7rXCYcaxAfRLQuORjLgvoABJLpULW7BOSugr0t8wlC7W3X3G3Oyey/LUmnu9TD65/i/Spy40TLDxLH6ajruMDjDMSEGw8w89Fw71+GLySzj8SDMEJxJxn4448PmoTw/WLT9j2TWxWCPs4QxKb/KtHpaJFP53X/o5wsgvM4UXuNLQRJYV4svnyK2QULIXhfV6WlufG76XKq/g1VOmPyeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <daebe6a9-7126-0f09-2c68-c13dbdd02f92@suse.com>
Date: Thu, 2 Dec 2021 08:30:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 4/4] libxc: correct bounce direction in
 xc_get_device_group()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Ian Jackson <ian.jackson@citrix.com>,
 Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Juergen Gross <jgross@suse.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <b53c7853-b53a-37a0-d3bb-81093b19f305@suse.com>
 <ae971612-71e2-2005-88cf-22006b7fc9b9@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ae971612-71e2-2005-88cf-22006b7fc9b9@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0088.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: de8906d4-4908-4b6e-704c-08d9b565a500
X-MS-TrafficTypeDiagnostic: VI1PR04MB7040:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70403CB682C53D4AF549EA6BB3699@VI1PR04MB7040.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:84;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gg0S7Tz2pAMGsyBxuShAdCkxNYvKCgCEVtfbE4Zw7dhiC7ubwbrO0dSZxqZ9MEKHBSLsT7mY016MYpRiN9a/MvqM8yFY4lBiQV3jrTX6sp4xJMwo4UU4j7Md84TqqEl949PID4dsNqhxIO+13VAqVWoiHXIEWn9a4aZFSYDMSzeYQwxVwkeZB7eMPS12zSQJw/CbWep9YZLubCQK4rwDXaO2Mohjb0D172uUvOimiHPX9sbP2lVpeIe2VAnRVPno3ZVq80Sa0JUlM8GpPVyimjBkeDtvFoYRsTmyalb0c1BNxeLAo4KRC94Nprz7d02OzNdu+ewQYIcwk/PWF4SYKtwqXLGft7kKbFo5xgtWeI92sJgCgH/h2dUUs+nZqAI5HIUKPpswvg5jMkGf51YHtDW9Rbj49TFg3uibPVs4RUyt3mqwD9lNqwLIwwBE+sM/NVL795W2aQByMKP2iZ8llLFD1njFzT1O+n31W2EDP8erdTyiSp2uNLPr5/IMp5w0dliHqaRqSlaa9NKBnb3XpnBYLz7+ZU94pQNAbqs9f348C4kjvR0Yz/uEhNFvUQSupMiXxl4Nc4fJnlVxF3ET7NMBMOqTI7xAni2d4ZmJpK8OiHapEwW4ZlvrzTbpJRx0UsjbKZj9amNdgEiXSYz9z8jqzEkOeeavdH1fY9D7mFM8+jmbboNBnmEPQLCL3knCJ1Xmh5IIZ4AlgqoDq+10CtNl+lZoqDCFCGedSix+sRFKpx0uNZGa+2qn0xCZy44U
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(110136005)(54906003)(16576012)(66476007)(66946007)(107886003)(4326008)(316002)(53546011)(66556008)(86362001)(31686004)(508600001)(83380400001)(2906002)(956004)(5660300002)(2616005)(186003)(8676002)(38100700002)(36756003)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VAhdJDMxA5iHzEsb0KhnBO15rH24eLI9UIntlBbuOI19AMXClFgocYWl9Xv0?=
 =?us-ascii?Q?Zs9Xl/+t7FK16Hxnky6xa0Oe/ATDB3+TZz1QnXkNbeAjZuUqqVv92SVRTs3M?=
 =?us-ascii?Q?a4d02N6mT/IOdwFiMNHkAO7AM/N8J1nxRir/IIwZya4bSwlhz/JibKiCaMEl?=
 =?us-ascii?Q?ClFKTrZX4JMdCQCJsYP2f86nNTAdK9yEDRSYdJRsE46SOVRe0vdsfvV/Xcda?=
 =?us-ascii?Q?B5CPV0sky7DfxfQmm15S4KlxFr7e9QWcCujYh7edm72hop0UWtkb2Fl1qEYy?=
 =?us-ascii?Q?sKbuxDJFneK1x3PFiR5ksEKyLw7BU7nmDh+rPuu0z7fnbCg2GpshFDkhMW+U?=
 =?us-ascii?Q?0wbi8LoaJtHpXlkGb2qz1+vT3vWJ5ri7rsdG0Jo7Z1zP3cc1lWm95rrj11RF?=
 =?us-ascii?Q?LT6lKyYIlaY3rRJgIhej32DbM1GlHQENH4fthGNFCntA+NdCvlrpDSnHsP53?=
 =?us-ascii?Q?FAOGcWcTrMrEgeTLcZrP7IF+A2XLJLX5bQr+soHF1sppnynzSI4Bzur7YCU8?=
 =?us-ascii?Q?gzUJUm7tDBC6OycbK5TacwAFbhvnIHm14CFiF0VdZiRyTKpedzoCV3I080LA?=
 =?us-ascii?Q?DzSsdZxE8MP4NQDT1aiWOvFuGKlQs4VVSA0A4JTMMaaQIzeE9HnsJzv2wY8Y?=
 =?us-ascii?Q?Y8G7Za/hvMRIBvlqWDxDv3mDrx3XnAHl7B1Hlmud8KNyjJ2ieJyyC/varxYB?=
 =?us-ascii?Q?ytuJx2nUfjIgvRqgvuifZ6yzfRk0M8W24j6S3V5owlneQHi8nRLksm+l+SO6?=
 =?us-ascii?Q?7TnIqs1Wfa2zY2yGIkhjA+DNdClc071CYHMVGqskMltJfiDgqw1+NK5EAtHc?=
 =?us-ascii?Q?U7flDJsCMOih2ZaxP4E/9KCeBSAcag4wblz85Ky3ySPkU6Qbf7FrxnnB7Mx4?=
 =?us-ascii?Q?2e8czL39a5qM/NkHr4S5BvgceMyLCrc4wi0OFVkGZpKK5wWfZvltF6h2fItj?=
 =?us-ascii?Q?jL9S5xLSpKrXNSY4FXjYByb/+WwNZRMaAa0Dh1+3o57e0fG1Upkg8btEfGbD?=
 =?us-ascii?Q?NZV9RLIY+l39pKYrmKm3YajVct3FxNw35K/3Qq+FdfLvEMi+QWhvVHfgXlyc?=
 =?us-ascii?Q?9MoBCXYxrRKXHUOnhtQNJwrM45X0YGwRdNbbw4awpyf77nqCJvqHulr2xl9B?=
 =?us-ascii?Q?fICE6DVYeYxTGSU/uVwjOQOILFyV2bMaHgXiL8BROkw0VG96rEtQykst0d+U?=
 =?us-ascii?Q?QB34P11akHVJ7ffIk+TshU9PqaYURht8y4SSRZfgO7zmYFFsIodQSovyqEWu?=
 =?us-ascii?Q?TmrhQ5d4ucFFX9RINw94l8KxPz3e23WZaM3T8uX5tj94EE5eYggBPpn2Gbt9?=
 =?us-ascii?Q?siKE6dRO3Crn0AMdR/WCjkoyUDuIsC61YTzfb8ClyyLypa7bAdqomcpvug5G?=
 =?us-ascii?Q?liZnyg4he0cUIheEDiZ10LotpDMzQvCLuRyFjMpxJ4YqKe8Gq9GjT/siwclr?=
 =?us-ascii?Q?aco9MRy1rVEvtxovML8mbpZaj2YXESLdWyMDRu64/W0JeJsiZ7kBll0ed8dg?=
 =?us-ascii?Q?qDTkZWFyjy3VNQvf05pTIx0BuSh6jMfrmcmW88b7qqT1q0VQad1BGPLYVx8a?=
 =?us-ascii?Q?7jf+usR5U4wR28NNhCrcTqpY7dDXQ9mnVZBQl0NFaox9EZMELh42lfSzVyJn?=
 =?us-ascii?Q?dtZkrkzbeXx7GCsb7levnUQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de8906d4-4908-4b6e-704c-08d9b565a500
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 07:30:41.5588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ndQrlRXXHgrjq2NXqV/nE+Ar401dSnf2udZzoQcd49mkupUO7Kukl2HHoGs7KwcWn+0bBetvaVnBm8yag+Phqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7040

On 01.12.2021 16:11, Andrew Cooper wrote:
> On 01/12/2021 09:42, Jan Beulich wrote:
>> The array of IDs is an output.
>>
>> Fixes: 79647c5bc9c6 ("libxc: convert domctl interfaces over to hypercall=
 buffers")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Clearly the function, including its Python wrapper, cannot have been
>> used by anything for many years. I wonder whether that isn't good enough
>> a reason to sanitize the layout of the array elements: Right now they
>> have BDF in bits 8...23, when conventionally this would be bits 0...15.
>=20
> There is a lot of WTF with this hypercall.=C2=A0 It's obviously an attemp=
t to
> do the thing that Linux calls IOMMU groups now, except that the correct
> way to do this would be for the group ID to be the unit of
> assignment/deassignment.=C2=A0 (We need to do this anyway for other reaso=
ns.)
>=20
> The last user was deleted with Xend (2013), which suggests that it was
> broken for 3 years due to the incorrect bounce direction (2010).
>=20
> Furthermore, it will arbitrarily fail if targetting domains without an
> IOMMU configured, but everything else seems to be invariant of the
> passed domain.=C2=A0 This should clearly be sysctl, not a domctl.
>=20
>=20
> I suggest ripping all of this infrastructure out.=C2=A0 It's clearly unus=
ed
> (and broken in Xen too - see patch 1),

I've not seen you point out any breakage in reply to patch 1, unless you
mean VT-d's returning of -1 (which you didn't point out as broken, but
which I can see would lead to misbehavior).

> and not something which should be used in this form in the future.

I didn't think the concept here was wrong. What's missing is the tool
stack actually making use of this plus a way to do assignment in groups.
Iirc the latter was something Paul had started work on before leaving
Citrix? (That's leaving aside the bug you mention plus potential further
ones.)

Paul, Ian, Wei - what are your thoughts towards Andrew's proposal?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 08:01:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 08:01:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236354.409993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msh1p-0001m2-BF; Thu, 02 Dec 2021 08:01:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236354.409993; Thu, 02 Dec 2021 08:01:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msh1p-0001lv-7u; Thu, 02 Dec 2021 08:01:17 +0000
Received: by outflank-mailman (input) for mailman id 236354;
 Thu, 02 Dec 2021 08:01:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msh1o-0001lp-4o
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 08:01:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 05481177-5346-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 09:01:14 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-JZsyXgqTMxCRZu00Lf26DQ-1; Thu, 02 Dec 2021 09:01:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6303.eurprd04.prod.outlook.com (2603:10a6:803:f2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 08:01:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 08:01:11 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0089.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Thu, 2 Dec 2021 08:01:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05481177-5346-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638432074;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HP3jcaKvbHL7Zxs5uAF+yfMGJmr7CJY35reZ6wqXHEI=;
	b=Zb7JVBi7SEVWD71eNQbDL+Aktc+PmQ2sopA2lGMHA2kec6osf4Cmu2+JUQMBB13F+JXYTw
	0nzR23Mw8h5+sl+UJhEBexYatc1SGuA60ChoU+zsrs634BTJ7E3P/aSpu6PWxn3KSBcldy
	1p+sv4YN6L3ATC+a0mJBXKZcjFpi6ao=
X-MC-Unique: JZsyXgqTMxCRZu00Lf26DQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DdtG+UeLXCmxJHlnafGht0FyrI/sUyrbCuWR5m6a4k07F+e9GikHip55klFyknm/aOMnaWpWgvj0cJyZyk02Bsqgx/Z+URnEXq+C35f77bBoudiYWAl0+YYVGNa/OTG5Oo0xrFMEQOq0xRbRev+lMvOwQxyi3vrNDrm5iJAdh7U9paVdcGYbhMlKwAq6t6MaWxJBglMDhdssEyK8Elce2RpWahzS1Nq93VfKspE0HXIuQbNSwLFwCC00R9+HLYvGRTE7JjKHz5DeTgx6vukyZY6FvNfD/KE8FjvXU5rtIEkueTRXKY0Rha0SGrNIbXhxll5fZrHYp8pxppWwssXBJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mNUmxyTqdS4N4Sv475DClV/JoGIohZGgSoqCoXGyot4=;
 b=YqKJeI3hq3bR8MOrJ1/qewDeQoF6y475PpMXJuJLcOGDk4s2N6FvOBF7hrKNQaflEp2bvQ5p5QWdp3XpC+j1tCATzOgiZKuK6PdbfXMckoMQFV35iVyiugI/1ncOSXhgjOFYi3D5ODB25dBy7LAbz3AwCHlsJkfiY0zoYnPZjjt3zmSeXUcZ7KGAZKqQM8P46nkv/hrmNnbhlN8CD92ym//v8hmxIMvOBcftQha6srsiSaTx9ttpLxa5jySpAPrI4z9dBuO6APRV3AG+yo6tdUA7zdaTQsH0uqZ0xsSOy07rCeMaaI8ll4VQEampknTw7EsSzbQ+Hr1rhBVYhh38kg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <33d466b3-338b-d2dc-f993-c5fac22072e0@suse.com>
Date: Thu, 2 Dec 2021 09:01:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/4] x86/altcall: Optimise away endbr64 instruction where
 possible
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-3-andrew.cooper3@citrix.com>
 <3ca82514-2adf-2445-04d1-0020dde16019@suse.com>
 <4ee538d8-5063-1bf6-025a-62474be7ab0c@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4ee538d8-5063-1bf6-025a-62474be7ab0c@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0089.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 46185755-4cf0-4764-0503-08d9b569e7c0
X-MS-TrafficTypeDiagnostic: VI1PR04MB6303:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630382046E90723F6CBD5543B3699@VI1PR04MB6303.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hRizbNrcaVW6JMftyoqpaQGxScG/cEnLE1wHOuQVN67e1G9wzDoEWIBhj3O1+ZpiNK2EaRAxJGiYrJ7Mr0lAnELcPaQtjN+hrd2gI6+Kc8y1txHmssmbdm/eexBCcM1O4BXBLsB1ntorHtMxvlXZ9cpQDFANjVKvbuJdzZN/di9OW4qtwPx9QlGIb0vJCIN33kopnIkdmHuQKymy8vwyIjnxZRcvD+EoAyhOKRiHY8erwZGja3gxv/EpIUh3gVSSuHFAJWRG9sEsiqajAlQaFreioYDgBJzBBsmz/leknKcfv2BOM+uQixOc3GKiswtv88VSRVAlmBqi2/IYnWNfhozASc6wHto0Ma9nD4FUNdtXLoxU5iilG/oqX9maqEKZH2Xuy5zL0Fjz3Y6N8krTnpDCmG0x7jROzmPEyGs/0a2mcoGsr+BizdYmHgKU6ohSlCjlrs9tWOH1RChMkZiiUmw4PFVN07hQBYS4iU0pI5UIGwUb+ycktAWY5p2hopA2clJ0wdx1k+LZR3TRPblWLqGlaCYgn27Tez6drshbTL0ihGAtsLtShbLlbJS+hug/LOqBI7X/kN4uex2zPh2ZERmDB4kZ30aOk523qapbtXHg+o8uFHnzXkVYKAUReYAN26i7ahBJbLS+g+4tZX+XqwK3c0wt1Zc/RbdfoJJa/GFRGaVpsbYinijCCQjDTWLAhE62/1ePcsl+Z9V3P1TH/Snnh9+hKN+Ad/IhjD0FPhI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(110136005)(956004)(66556008)(31696002)(2906002)(316002)(6486002)(5660300002)(54906003)(66476007)(16576012)(8936002)(186003)(66946007)(36756003)(2616005)(31686004)(4326008)(26005)(86362001)(38100700002)(508600001)(53546011)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tZIFsaeeTjx6LxL3aotwItz34+lJ5P1y6w8q+fOgYtRixipVoZBr614jSmiz?=
 =?us-ascii?Q?D+93kbHfhgiJiHzFMf1REgqmFnOT0ymt0u/BAlvES4uKpbAL573ONtaHpYis?=
 =?us-ascii?Q?cOHUhU5dbaEZer97/pU2YxCw3n6TwrC1kUFhgUgbMTK+eL+AhwUjK8ydSnj+?=
 =?us-ascii?Q?65DzwI9TqsDlhouiJxSqeEy6Jcr4hWNPX3Dda6ftcHzdB4egmtmRqLKA1yqL?=
 =?us-ascii?Q?Ig2ZVKST3/8vLUlh1pLndJDTaqs/l/+ydHnOzU28B2VT7RCjHMF0YlsFRAhG?=
 =?us-ascii?Q?LsHDfrgRA6qXmBPyAstONMG+GidzDIQrXyeYVo/wJuiXql3X23r2/Xtgl9Cu?=
 =?us-ascii?Q?rAzIYkmDDsG5uX06eMl1eoClpssR8wBxr0TTqr2Vlkh5EVwYRq99jbQ0eIQb?=
 =?us-ascii?Q?mXUQvmtD4luDwZ9IlGL4KlR3kO2h+0iJLKcdzbniElf5eOT/fMbSmvhJLQ65?=
 =?us-ascii?Q?+iOxMN3z5JNqVjb0reub6j5UdtsLTM49ImycsIi1DsDHAGk0wwwW297XD8po?=
 =?us-ascii?Q?roHQQh8PE2CvKsRqIelNiJpJkPRA/To4OR0VlSjHnhP3ADFa2M1RrkjQPMMo?=
 =?us-ascii?Q?3QHJy6RgCJ3zzyuQfOrArtKr3GuwmeIMKiXFk9gHtRF4QydVHmkJ7vzFkA/k?=
 =?us-ascii?Q?S1IFh8YxP1/TOBVR98BVjZ9sFHuf7u2jQNo0UabBsFDKoQ92LEX3N94tLpYR?=
 =?us-ascii?Q?fhbK0cUgTJG/q/5DpAlP+vbfelpo3sTASUcUcfqe2IycHecOyyAwwoigAp3q?=
 =?us-ascii?Q?4bjI4CkA6FxoFNtLUvfiN1qCIpttMSyLa4vRX2AUEsXF6uGfY5vBh+JmFtU6?=
 =?us-ascii?Q?7tFtZjJ3xZr/4Z09fGJCfC1X+FIAXBb16PfSoXs4fI/vUgP3wos4A3xgmLX1?=
 =?us-ascii?Q?MqeYD45qa178qw6OC47Ybq662AHsJsxWtRw063BeRaCL3gfU1PRA7RZEe4mF?=
 =?us-ascii?Q?0HtM6HxrL2IsTPFiWgbsnKK5F+INtmz9O50w6Fww4vdI3x9GMmzXobKTX3v9?=
 =?us-ascii?Q?uwJ9avC0IaXddqF+a9rtbvXWtFHXRAgN3YLj8h50aaoNIJCUHzYiFe0rQnNr?=
 =?us-ascii?Q?8SeS0HqoCjrDUi4iuG9iuc0+LzCc2ZJ2ey+X/thaU7HoKTpShS9G5qb3E1wb?=
 =?us-ascii?Q?w7+PLb8w8VxapLrNy0QI+xDeI+fulqoaz9cP7SFgDEeERyh867F96Vl4Av1D?=
 =?us-ascii?Q?bov8ezfCHxYKn/hxUddCR7YWKySSAybPXcW/rhkBo29vJqObkqdbuYiPHozg?=
 =?us-ascii?Q?qiTh7ol3Q5RHqIG9YWEtJdrqMJBS15ByAg8qtPufgnSNFCzb0TuYZFWWDD/y?=
 =?us-ascii?Q?bKBOSj3KHAat5wkBVAWCNC5hR4vRtEHphQez5G11IFkJfG/TvVrqhdu+SKGY?=
 =?us-ascii?Q?YaBzJ5AgHVZEn4VKLnWoFsJqLTohXA5e8CFI4Mguf80cZb83NAx2c7JslsEP?=
 =?us-ascii?Q?6FKMtMOqBS9p+DFdOs37DT63IwPhVOWAvJoCG5b88kwTgMDvRk0kl8DElYKq?=
 =?us-ascii?Q?mfeoQyrG8DzEO3Rq5kf7O8CD2gSuTHPSYUVQSGxVQymlbnzE3yJ9i7issm2/?=
 =?us-ascii?Q?2ISgvqGHkUYur83JrwfQq6ZscDpxMlrKTTFhxUfDJ7NS2giI1Z1lehpqX6uJ?=
 =?us-ascii?Q?1+8lf4Zg4olPMOGcekfA8VM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46185755-4cf0-4764-0503-08d9b569e7c0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 08:01:11.5039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WwrjBJQdIyiPSxpqyghHRfDlh89YVjxDdaKSqwpVSgBbBBN9MI4hKIWuGO7nZkY6Gb+D52B01NKT0OZMPURB3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6303

On 01.12.2021 20:07, Andrew Cooper wrote:
> On 01/12/2021 08:20, Jan Beulich wrote:
>> On 26.11.2021 22:22, Andrew Cooper wrote:
>>> With altcall, we convert indirect branches into direct ones.  With that
>>> complete, none of the potential targets need an endbr64 instruction.
>> Assuming that no other hooks remain which re-use the same function. I
>> think this constraint wants at least mentioning explicitly.
>=20
> Fair point, but I think it is entirely reasonable to expect logic not to
> mix and match altcall on the same hook.

Take XSM's silo_xsm_ops and dummy_ops as an example. With what
xsm_fixup_ops() does it should be entirely benign if silo_xsm_ops
set any or all of the hooks which are currently unset to what
dummy_ops has.

>>> Furthermore, removing the endbr64 instructions is a security defence-in=
-depth
>>> improvement, because it limits the options available to an attacker who=
 has
>>> managed to hijack a function pointer.
>>>
>>> Introduce a new .init.data.cf_clobber section.  Have _apply_alternative=
s()
>>> walk over the entire section, looking for any pointers into .text, and =
clobber
>>> an endbr64 instruction if found.  This is some minor structure (ab)use =
but it
>>> works alarmingly well.
>> Iirc you've said more than once that non-function-pointer data in
>> those structures is fine; I'm not convinced. What if a sequence of
>> sub-pointer-size fields has a value looking like a pointer into
>> .text? This may not be very likely, but would result in corruption
>> that may be hard to associate with anything. Of course, with the
>> is_endbr64() check and with a build time check of there not being
>> any stray ENDBR64 patterns in .text, that issue would disappear.
>> But we aren't quite there yet.
>=20
> I disagree with "not very likely" and put it firmly in the "not
> plausible" category.
>=20
> To cause a problem, you need an aligned something which isn't actually a
> function pointer with a bit pattern forming [0xffff82d040200000,
> ffff82d04039e1ba) which hits an ENDBR64 pattern.=C2=A0 Removing the stray
> ENDBR64's doesn't prevent such a bit pattern pointing at a real (wrong)
> function.

Why "aligned" in "aligned something"? And I also don't see what you're
trying to tell me with the last sentence. It's still .text corruption
that would result if such a pattern (crossing an insn boundary)
happened to be pointed at.

> These structures are almost exclusively compile time generated.
>=20
> So yes - it's not impossible, but it's also not going to happen
> accidentally.

I wonder how you mean to exclude such accidents. It occurs to me that
checking the linked binary for the pattern isn't going to be enough.
Such a patter could also form with alternatives patching. (It's all
quite unlikely, yes, but imo we need to fully exclude the possibility.)

>>> --- a/xen/arch/x86/alternative.c
>>> +++ b/xen/arch/x86/alternative.c
>>> @@ -173,6 +173,9 @@ text_poke(void *addr, const void *opcode, size_t le=
n)
>>>      return memcpy(addr, opcode, len);
>>>  }
>>> =20
>>> +extern unsigned long __initdata_cf_clobber_start[];
>>> +extern unsigned long __initdata_cf_clobber_end[];
>> const please. I also would find it quite a bit better if these
>> were suitably typed such that ...
>>
>>> @@ -329,6 +332,41 @@ static void init_or_livepatch _apply_alternatives(=
struct alt_instr *start,
>>>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>>>          text_poke(orig, buf, total_len);
>>>      }
>>> +
>>> +    /*
>>> +     * Clobber endbr64 instructions now that altcall has finished opti=
mised
>>> +     * all indirect branches to direct ones.
>>> +     */
>>> +    if ( force && cpu_has_xen_ibt )
>>> +    {
>>> +        unsigned long *val;
>>> +        unsigned int clobbered =3D 0;
>>> +
>>> +        /*
>>> +         * This is some minor structure (ab)use.  We walk the entire c=
ontents
>>> +         * of .init.data.cf_clobber as if it were an array of pointers=
.
>>> +         *
>>> +         * If the pointer points into .text, and has an endbr64 instru=
ction,
>>> +         * nop out the endbr64.  This causes the pointer to no longer =
be a
>>> +         * legal indirect branch target under CET-IBT.  This is a
>>> +         * defence-in-depth measure, to reduce the options available t=
o an
>>> +         * adversary who has managed to hijack a function pointer.
>>> +         */
>>> +        for ( val =3D __initdata_cf_clobber_start;
>>> +              val < __initdata_cf_clobber_end;
>>> +              val++ )
>>> +        {
>>> +            void *ptr =3D (void *)*val;
>> ... no cast was needed here.
>=20
> Unless you know what this type is, I already tried and am stuck.=C2=A0
> Everything else requires more horrible casts on val.

It's as simple as I thought is would be; proposed respective patch
at the end of the mail (the two //temp-marked #define-s were needed so
I could build-test this without needing to pull in further patches of
yours). No new casts at all, and the one gone that I wanted to see
eliminated.

>>> --- a/xen/include/xen/init.h
>>> +++ b/xen/include/xen/init.h
>>> @@ -18,6 +18,8 @@
>>>  #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
>>>  #define __exit_call       __used_section(".exitcall.exit")
>>> =20
>>> +#define __initdata_cf_clobber __section(".init.data.cf_clobber")
>> Just to repeat what I've said elsewhere: I think we want a const
>> version of this as well.
>=20
> I can, but does it really matter?=C2=A0 initconst is merged into initdata=
 and
> not actually read-only to begin with.

My remark wasn't about the actual mapping properties at all. What I'm
after is the compiler being able to spot modifications. If I see a
struct instance marked "const" and if I know the thing builds okay, I
know I don't need to go hunt for possible writes to this struct
instance. When it's non-const, to be sure there's no possible conflict
with the patching (yours or just the altcall part), I'd need to find
and verify all instances where the object gets written to.

Jan

**********************************************************************

--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -28,6 +28,9 @@
 #include <asm/nops.h>
 #include <xen/livepatch.h>
=20
+#define cpu_has_xen_ibt true//temp
+#define is_endbr64(p) false//temp
+
 #define MAX_PATCH_LEN (255-1)
=20
 extern struct alt_instr __alt_instructions[], __alt_instructions_end[];
@@ -174,6 +177,9 @@ text_poke(void *addr, const void *opcode
     cpuid_eax(0);
 }
=20
+extern void *const __initdata_cf_clobber_start[];
+extern void *const __initdata_cf_clobber_end[];
+
 /*
  * Replace instructions with better alternatives for this CPU type.
  * This runs before SMP is initialized to avoid SMP problems with
@@ -309,6 +315,41 @@ static void init_or_livepatch _apply_alt
         add_nops(buf + a->repl_len, total_len - a->repl_len);
         text_poke(orig, buf, total_len);
     }
+
+    /*
+     * Clobber endbr64 instructions now that altcall has finished optimise=
d
+     * all indirect branches to direct ones.
+     */
+    if ( force && cpu_has_xen_ibt )
+    {
+        void *const *val;
+        unsigned int clobbered =3D 0;
+
+        /*
+         * This is some minor structure (ab)use.  We walk the entire conte=
nts
+         * of .init.data.cf_clobber as if it were an array of pointers.
+         *
+         * If the pointer points into .text, and has an endbr64 instructio=
n,
+         * nop out the endbr64.  This causes the pointer to no longer be a
+         * legal indirect branch target under CET-IBT.  This is a
+         * defence-in-depth measure, to reduce the options available to an
+         * adversary who has managed to hijack a function pointer.
+         */
+        for ( val =3D __initdata_cf_clobber_start;
+              val < __initdata_cf_clobber_end;
+              val++ )
+        {
+            void *ptr =3D *val;
+
+            if ( !is_kernel_text(ptr) || !is_endbr64(ptr) )
+                continue;
+
+            add_nops(ptr, 4);
+            clobbered++;
+        }
+
+        printk("altcall: Optimised away %u endbr64 instructions\n", clobbe=
red);
+    }
 }
=20
 void init_or_livepatch apply_alternatives(struct alt_instr *start,
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -217,6 +217,11 @@ SECTIONS
        *(.initcall1.init)
        __initcall_end =3D .;
=20
+       . =3D ALIGN(POINTER_ALIGN);
+        __initdata_cf_clobber_start =3D .;
+       *(.init.data.cf_clobber)
+        __initdata_cf_clobber_end =3D .;
+
        *(.init.data)
        *(.init.data.rel)
        *(.init.data.rel.*)
--- a/xen/include/xen/init.h
+++ b/xen/include/xen/init.h
@@ -18,6 +18,8 @@
 #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
 #define __exit_call       __used_section(".exitcall.exit")
=20
+#define __initdata_cf_clobber __section(".init.data.cf_clobber")
+
 /* These macros are used to mark some functions or=20
  * initialized data (doesn't apply to uninitialized data)
  * as `initialization' functions. The kernel can take this



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 08:07:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 08:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236362.410004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msh7H-0002eh-5i; Thu, 02 Dec 2021 08:06:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236362.410004; Thu, 02 Dec 2021 08:06:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msh7H-0002ea-19; Thu, 02 Dec 2021 08:06:55 +0000
Received: by outflank-mailman (input) for mailman id 236362;
 Thu, 02 Dec 2021 08:06:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msh7F-0002To-C0
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 08:06:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce99ba35-5346-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 09:06:52 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-6zYgef_fMLyGRft9B71tzA-1; Thu, 02 Dec 2021 09:06:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7149.eurprd04.prod.outlook.com (2603:10a6:800:12e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 2 Dec
 2021 08:06:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 08:06:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0045.eurprd05.prod.outlook.com (2603:10a6:20b:56::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Thu, 2 Dec 2021 08:06:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce99ba35-5346-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638432412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=o5h/pZ+suWHtByPakmuZtoYKi4AvRHIyvzD7adZghw0=;
	b=K3lZQG7qbF0bmKgM1mEo5++wO8CrBs81plmts9ZYCTFbFY1Oc902Pq8LPjFtqAOJf6XXqq
	Agxm4TkysnA5ff76qn+xQL2aYMGKjSR6SB+b5gVv/yiarfUInjZWfbDDGJ6pomwrQC+oR4
	xKG92YUBBq4MMUcWTOC2yXdxVgqSRV8=
X-MC-Unique: 6zYgef_fMLyGRft9B71tzA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fk7jWQiE/jktbYd/5t39+JfXWw4aE0Al7o3iOpvWXVKWFAfv2aqrTXTtjVjxD+ityQTSBu9QLhY6O9OYxaDSz95tzo0EnHv+BIZeaYd0REJNRuIp/JUEW13Wee0FYv0BDb3jZ4dE3blWgprEXwdjngpkIaf20FClWbtRBZjDZfWihtGhPqjE5u6oezb4Mis8w/MNij1SMjhAUqKnGXdQcuFeB0XvyP1UEQPSlb/dDTy7I3+fKPkyUzdTlkiXXFDRLFhDYqmEFivKKGOTdMHFfNpME67OIGVUj3feMo2IK5KrQ89hP8XX7jB65bDJzg3wxgA1St7LKYnKBE4+quRNBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Jg/nohhn9niZ11G4oPwBwbPMDTh20ap9Lt0wxAEh1x4=;
 b=GycWv2Me/1HFSniPd7H+oiMFGkaLYErjjSduvMJGS2vnN7C9nDw0g/t28y9epnIeA/1tVOv6gcWLcr3eoIs4HlbFhhi/aNqxz9oLDZD+5XcjvSZd+MbGaQegnFuWh6NfQqL+a+OpawOgSlFTv5Be/IS71Y+HL7oGCxBgGjdhthptC9YbOn2alDI2CnTZ8jn3xl0ksZJTOgLayBfwTMhB+F8nYcpFGRU3y+O4dTyFfYF0s5fQUSZcyQhzyB3+iZdaxFoSaXtRE9LciFJpsiJsXR6dpbnppjJBf8MVknYHZ8nXfyb963IM7XFFeg4wodwRxdsdpbX7S6AA70A/FRw7IA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6c366dee-a3a0-040b-234c-0f877894ceb2@suse.com>
Date: Thu, 2 Dec 2021 09:06:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/2] x86/hvm: Rework nested hap functions to reduce
 parameters
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130181139.14398-1-andrew.cooper3@citrix.com>
 <20211130181139.14398-3-andrew.cooper3@citrix.com>
 <037802f4-d28b-62bc-e830-78149f1cc2ff@suse.com>
 <5a1c0ba9-7583-39c0-87ce-dcb62ea4c7b9@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5a1c0ba9-7583-39c0-87ce-dcb62ea4c7b9@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0502CA0045.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 473158ae-66b5-45e2-c7e3-08d9b56ab162
X-MS-TrafficTypeDiagnostic: VI1PR04MB7149:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7149C8005D6ED391D66169AEB3699@VI1PR04MB7149.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Kc2esXn/0fUyvmBBrzDME5yIMgwBe657N4FQzKC8iAI8vgv/bPpGqr79RLp3dzGFfkeJZCqxT8wPnUOsAwcOI9GuAfJvAws7g02EIjaJVgbXhl1W9nsSlEwizjZeUGfIXgjfw6H2hhkjQMTE+NLv3qxF8imRs6EIQHYnnb90si/R/J6+KVfQquuIyxRN3LMn4XC3H6KiI3HKtq1Gb/xTngr2Qp0fLbgr/LkNW+HeT39JMnYzxq24kQ/zK3SfE4M6+KqvdXf8NAQpQBW1uuf9+3jDHI717ALC1jEPAof0aMfmlYnL+W+AF6gd3myFKeaE0bsaiOeeuOA98XpSUY6Ujflz6ykiiWcFLZcF1xWRO+8qt0FAOFs9iQW+FkuF7cYrD8NTjLz3eQupHFqP2eIT6Z1Sxtx/VSZdtk6xatl/yuXkHMUe7IGgKD0sUY0d09Q59BdIwddhmcEkWp5SYad7GvKXq3JEiySNIKThSTC2pFJv0lJviSdXI+b7jK7fBkbAKUC5tylgUGf66HdNbh+Y5/bqWvHbLpCSDBUbi87b/vyl8zesoHSan6S73xmSqM6PCczmzVQ+QJLohbk83sNpEKnH9Mzv/QYjMYLOb6WcPWL69Fe9teGAOKdSa3xIGFG3F+dfm57TBfMlyHGJNVrMuAsi2YxbxObTC/n8/EGvsBYw3lZgK479l3Dz/SDMiMbkEkJL+5sFDSndEj2UsSX3N8LDarxMz3G56OXahO0c58OEDvtczrzm02JH4mV7U3xd
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(6486002)(2616005)(66556008)(956004)(186003)(86362001)(66476007)(110136005)(83380400001)(26005)(38100700002)(2906002)(8936002)(36756003)(16576012)(8676002)(508600001)(54906003)(316002)(31696002)(5660300002)(4326008)(31686004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7gqNivTwqgZS2zgxlaurfx39EeTkaDgl3IbN2VmUN1tR/pBazyNZ+Mz6pEr+?=
 =?us-ascii?Q?HhOjsbQpJrt6hrpLkY7y1cgtMn/OAmtFoZhE1b0uI5iLjZvXrfFiQ/4GGeRy?=
 =?us-ascii?Q?LvGHdAlyfURULvzRNCwTVuZHP6EOl0skouCPDsdzV2Fp3zZBKt7O4NUGoued?=
 =?us-ascii?Q?JtOVT/o5oFiUjNHNRcN+tA3IldJ/GC7chrb6b+SOvfzYixEwZqjZrN9EbpQ8?=
 =?us-ascii?Q?3ezFrRtCvqJGFtoJB8VJUnFRjmwAiEmv2hZGXqq15iIYBpAoaQkkLOpstGd8?=
 =?us-ascii?Q?ycYxLcsDFhInGY23OZIy7NlPRG/Ci8OetRd7DNrG5wcst+LgQkRfYDfTwC2m?=
 =?us-ascii?Q?N0hNYwuQflYgLLXb5b2lCuSpI2XODVbqBFmi4KRSNTzv+yiFg2b7reqdo3aa?=
 =?us-ascii?Q?Jh1gj/ae01ObIVc+qLiBcmFUAkwPo+VWtoqNtUeHEHUxP34IjDey4/ojcKl1?=
 =?us-ascii?Q?ZLEzMQB4f6p5lSO1VxoTiN8Q72aSiLk2Lc9Z2DPjYiQcihlINneyF+9SFGTa?=
 =?us-ascii?Q?UtOyvWVkh1MNKVoR2h70mtFCVjMfNkgZpUgv9wF5LXH0NUrGUb32CijGp9VD?=
 =?us-ascii?Q?VJVAoA9oDJOCq0tzHdux+1GvYnlNn/qlUchUZ7rKPA51wCwEZ3IOkiATPEcg?=
 =?us-ascii?Q?b0jzWPGSZOR2MKLySbYhsfs62+Z8eeAI+jrBXEx19cOoV83AM9c2tT2V2LGB?=
 =?us-ascii?Q?joP3VNASPEpJh5VKHsWs9Q8YwN4psG0GtAetkF6yc0qKH0snia2wKBD6zPcW?=
 =?us-ascii?Q?8hnKutxecJWaRJ1iw3T4QRbVseWJdvYYylQeCTeEXMy89aZxBk1Nyjt4VdzG?=
 =?us-ascii?Q?D0xTXCBMVKGy/0ghLWsrTXkbRMeH1MKIV3YZlpkN6ZdTkYDtAbHQIXi4gFjn?=
 =?us-ascii?Q?Id1ANzIxGNhZAAQmBBOYTwR669C7l1cSEyJLvKtwm1d5nscJx3tuhvp7O11Z?=
 =?us-ascii?Q?QdhOvfZXeN7P5F83qaaCTRQmFvC39xa5YxrpuK/EK0c0NhOzCtXWgA3s8xze?=
 =?us-ascii?Q?yAEL8Z/rZKKF9Y1wuOeqFFQTuDROijwhT/M2MOhi65tIrgXFejLEZbke6CWV?=
 =?us-ascii?Q?6M5nCXKKhJbhHWSiSBTd4UIPHGxOf6KOqqe5M/anM5mqLqL4e45trEPCc/ZG?=
 =?us-ascii?Q?Wb+wrZGpsuC3PKWlYUhmtKdKEQHMd/ewWAFanNeCbrRLlE+olDuTl9xv+/X3?=
 =?us-ascii?Q?vMClMFj9BoTeIq+IVUC7iE2HkhZiHRRF0CaTs6iKppwZNnfkiPaKX14aZGQn?=
 =?us-ascii?Q?58V5ENosTRHUAHmx3Ci/GnYi+vn3YOrvoqplEVyNR2IlP1fnixSxQ1y6R3ex?=
 =?us-ascii?Q?8IY5pK5mwBx8WxjFzmH+30k/2S3bS1j9C6ClX6pITS94pK3pp4Ruw9n7VUGq?=
 =?us-ascii?Q?++/S0iI4NOfbMBQhjcjFMhqnZv5mp67Gg1CaJIlhS/FmDYKuCmgfwlGOiSLJ?=
 =?us-ascii?Q?9UNzyNL73jqzrr1B/enuIZy8bybWu/NqX6aVmTZULCgL82euzmeF6uu90C7F?=
 =?us-ascii?Q?DCHt4oSR6+q6H1DthMJ35ZtTsnaOSH96r+CMksiHfzNJuaz3VBk+RnDt11oz?=
 =?us-ascii?Q?83nwe6J2PBWVSZKpY3xFyj+PmnmL58iOCFx0fs8tp2s6OYYz040T/RT8mOSn?=
 =?us-ascii?Q?OVF4UvfDQWYGWF4K4nBOqys=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 473158ae-66b5-45e2-c7e3-08d9b56ab162
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 08:06:49.8116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tIdTtAGrTCCywekcfoEl7nrow1DmWBQTN0kqdedTJWf4KSLNtJCfoxTExqAfFVc85F5NF3Lz6TDVed5PNrOlHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149

On 01.12.2021 21:13, Andrew Cooper wrote:
> On 01/12/2021 09:14, Jan Beulich wrote:
>> On 30.11.2021 19:11, Andrew Cooper wrote:
>>> Most functions in this call chain have 8 parameters, meaning that the f=
inal
>>> two booleans are spilled to the stack for for calls.
>>>
>>> First, delete nestedhap_walk_L1_p2m and introduce nhvm_hap_walk_L1_p2m(=
) as a
>>> thin wrapper around hvm_funcs just like all the other nhvm_*() hooks.  =
This
>>> involves including xen/mm.h as the forward declaration of struct npfec =
is no
>>> longer enough.
>>>
>>> Next, replace the triple of booleans with struct npfec, which contains =
the
>>> same information in the bottom 3 bits.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Jan Beulich <JBeulich@suse.com>
>>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>> CC: Wei Liu <wl@xen.org>
>>> CC: Tamas K Lengyel <tamas@tklengyel.com>
>>> CC: Alexandru Isaila <aisaila@bitdefender.com>
>>> CC: Petre Pircalabu <ppircalabu@bitdefender.com>
>>>
>>> I don't much like this, but I think it's the least bad option in the sh=
ort
>>> term.  npfec is horribly mis-named/mis-used (at best, it should be cons=
idered
>>> npf_info, and probably inherits from the same API/ABI mistakes our regu=
lar
>>> pagewalk functions have) and is going to have to be untangled to make n=
ested
>>> virt a maintainable option.
>> So why use struct npfec here then in the first place? It could as well
>> be "unsigned int" with constants defined for X, R, and W, couldn't it?
>=20
> I started prototyping that first, but substantially ups the work
> required to support XU/XS down the line, and that's far more likely to
> happen before getting around to cleaning up the API/ABI.

Well, okay then.

>>> --- a/xen/include/asm-x86/hvm/hvm.h
>>> +++ b/xen/include/asm-x86/hvm/hvm.h
>>> @@ -25,6 +25,7 @@
>>>  #include <asm/current.h>
>>>  #include <asm/x86_emulate.h>
>>>  #include <asm/hvm/asid.h>
>>> +#include <xen/mm.h>
>> Nit: Typically we have xen/ includes ahead of asm/ ones.
>=20
> Fixed.
>=20
>>
>>> @@ -631,6 +630,14 @@ static inline enum hvm_intblk nhvm_interrupt_block=
ed(struct vcpu *v)
>>>      return hvm_funcs.nhvm_intr_blocked(v);
>>>  }
>>> =20
>>> +static inline int nhvm_hap_walk_L1_p2m(
>>> +    struct vcpu *v, paddr_t L2_gpa, paddr_t *L1_gpa, unsigned int *pag=
e_order,
>>> +    uint8_t *p2m_acc, struct npfec npfec)
>>> +{
>>> +    return hvm_funcs.nhvm_hap_walk_L1_p2m(
>>> +        v, L2_gpa, L1_gpa, page_order, p2m_acc, npfec);
>>> +}
>> Is there a specific reason you don't switch to altcall right in
>> this patch, making a follow-on change unnecessary?
>=20
> I was still hoping to keep the altcall stuff in one patch.=C2=A0 I'm happ=
y to
> do the rebase.

I'm not worried about the (trivial) rebase. Yet both patches will be needed
anyway once we consider possible backporting of all of this work.

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 08:16:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 08:16:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236368.410015 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshG7-00044s-1e; Thu, 02 Dec 2021 08:16:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236368.410015; Thu, 02 Dec 2021 08:16:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshG6-00044l-Up; Thu, 02 Dec 2021 08:16:02 +0000
Received: by outflank-mailman (input) for mailman id 236368;
 Thu, 02 Dec 2021 08:16:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mshG4-00044f-Uq
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 08:16:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 14e195a6-5348-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 09:15:59 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-LmDa5amEMfyK8a81fjQB_g-1; Thu, 02 Dec 2021 09:15:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 08:15:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 08:15:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0224.eurprd06.prod.outlook.com (2603:10a6:20b:45e::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Thu, 2 Dec 2021 08:15:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14e195a6-5348-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638432959;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=o8hOPqvGzXeBIB4/ZRzUm823cW/N2aXg9vJXLPivKS0=;
	b=dqMPmuPFDNTS4uaeGqJ1dPUSTUGnwWZASzkv15hbX3Cl4dU1bUH8YEXssAAekQqBpV+EiV
	4JplhaVKZWkjyY28T0RM8WKnWStY5/BJQ21ObWXpt1LFlvmmyq7L03JSneIKTiR9Jr2UTA
	cWVxguCWqX/mqHFLQnGv9WOvrCDNzhw=
X-MC-Unique: LmDa5amEMfyK8a81fjQB_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lr3qhjiPMBFKkjxaJ2jiUTOXdVIyML7aIlbDCitcF0gwQbtkb91e7ZmmAI6lOdDZohWlm89uBuBFY6e+ibMjvZa5pPQgcUnNAxkmFz1hfd8CJS3GhuoS4wFLIgZxH9cUoHLaUaDCTaPFO353eok1hLrSV69qkHuaxCEFVY0Zkqr1rm6evIpxY+zfhCuKfSe2ZkUSleS/eAe1z/6uC18CJBWz6KfhXU7L3hhtFNIP1FIX1vblDcL0+07+5xJIiLbH1LWnZcchGpiAP89w3Tf1Dav6rnX1Fjms+684k1R3U2yowGOznMGCvNRpKvBScl0qES8kx0uRLDLgTNKatVg/mA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sqRU5mbCOaYExaC9tD0BuvMXBCE+HbW5KwP4sSJvw0I=;
 b=XdG6RGWBWNGZ6aTGFVPJgUcR9pqR8eXqHAt+jcwVpplQPyvLwNjatntnxtLWOZvbaqfe/EHR9fJDg+IHgBJ4mO7pHaZ9byDHzSiuIJlbLtGIz7u2VJ2ASAeRdE+0zjcptPnNN3Gmhp1R+yWGyDrgPKWrxjxIWOFhc+YYH/U46FQ/eITwYQH0weUQFcKdvc5KKPDeW5RSg9a1EIRJX9B74it5WUxa86KgqSkxkspuHddG/sL32abt+eSQ8zxRSXmvOOkmcaQQKxGMOlhGRoPpMW4wOCAoP33fxwJ3Nd76zcGAA+IDDcnXUDBVicnDmTDqYJ5lMljPlcHz3e+7Ak2OqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <51ca3725-f85f-0f53-5e90-7128b935b18f@suse.com>
Date: Thu, 2 Dec 2021 09:15:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty()
 invocation
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
 <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
 <639244eb-074a-ef90-3bbb-747ac65fa6b7@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <639244eb-074a-ef90-3bbb-747ac65fa6b7@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0224.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab8e4d2c-ffdd-4a35-c825-08d9b56bf781
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6301A7455EE47183C7BBDD5EB3699@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oC8C7sa+XF6kt1aZfasSDFyyI85OvnGmRSc8eTGZVNzRJB53ccfOf8h6JUFXv02Wf7HHjNSeIEV2tl96nplZerejOHZemD6nDvUgWPdkjfwhN7VgchlhrM0y3HRoWdHI1RGvWNbcBFjLNVNueo6O13NRE8BIqYTAq7Lrx9I9BcMsq37ZGO1QbpgU5ULoYGBvKsQ7EKpZskPEvu5Ge2SM+V2kZihH22cwh/S5ZfAcgkZvPRt2mbY4rD+ljwf+pIIE+H2cTQmx/rbLDgV2O+9sEIVW4CPfxD3/KwPHhCmdaAymMlzGtFzadVdjbRdkFUcwjHJeGIPjwql17qYbbrCkh70kDQkv3ytQELZE2X4ymTpgs9CkY9DMkDeZIDimUnvuQsha4b6Mq4nG2Kk/eFr9DZDNaVH+6l9f6cf7PkwFQwb/oYRAh0zP6GmU2edVnkof03IyxY665FN++ytSYNSJ3L99Q5Q1++hEmsPvMla3I0CZyQg5Do0Wos6m2u1buBy1GKFUY410lm1HljujkFweCyiKUZ4ty8Et62FkyC1Rbv51VLUaDni35oWz2wrzUZ4jSvOsypKhg8DDJZdh7HpcYwwWsQUQYbL+YAeyIM3bBz0HuO6txJR1VzQsXemRN4Z0xdc2pcFgXvi9sp8V0p6LWDtkxm5crYC1gkIawd2UbtiDThaGLW9+Vkpj7IKs6h7v5lp1eDDbGaL+HXm5/v+wSc6WXa+EXCJQ1mkXSOxvtqvwqYtSL6ZC66uDcCI7aELvb+VjhUV2O4dFXPsOMXOgrA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(6486002)(508600001)(186003)(8676002)(66556008)(54906003)(5660300002)(2616005)(4326008)(36756003)(6916009)(53546011)(8936002)(2906002)(316002)(16576012)(956004)(83380400001)(66946007)(31686004)(38100700002)(26005)(31696002)(66476007)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TdrRR00S9+w9kDJHVcGyIC9UBSVpIuIpdgnfk7A/YwQRP9Ky/aUpga4/lY/3?=
 =?us-ascii?Q?LN1GePfrHlRCTpmbU2M3LpkPmLzQ8lU9VL4y5JI5qUeHHJI0Xz+NMi2UJ+sz?=
 =?us-ascii?Q?3QfkrVQe97bnwNaT731j1WZEzWvNElt64g3IizBkvF7/xWBzfv7sC1Ae1JYF?=
 =?us-ascii?Q?nz4Gsbejk4mpJt18Zouv/+IF/T5pCWTkoPrWMGWah6Addb8JS4JNdlS1foIx?=
 =?us-ascii?Q?S1E23H1JG3jecq2ohXViPJNoUJaMzAcGqQbUd+u52QR/pUsZpv9mmFe1Uk4l?=
 =?us-ascii?Q?LpjlckofWbkR/PNVQmfp/JshOb2k61xVcK5RMKCHncPdbfkBNmX7zMVuhqaR?=
 =?us-ascii?Q?sE3G4zTb8gQ6LVB8rMC0lKp5WLiaOGklBfQmEnIKnCPzbnZAkB9EXfwViMju?=
 =?us-ascii?Q?+OCn+cHRpPy2S6evv+tAAb9KjROoHrKSacXZ6rEHj67D9Wr2+e59+o/7XPQ4?=
 =?us-ascii?Q?nkiOY+BI68EO3TCEh/eWiCcWuC+0dHxTnkoqDKLli7xWnJNao3v714GWKbAD?=
 =?us-ascii?Q?BmMB4LgfuVgAJZMptbinwF5m1X2Hn+UGpFPGoeaHxWPeuTAbSwCaf4/3rhH3?=
 =?us-ascii?Q?iE2YHaVd7cxdU+s7h9zbpf5dlZTuHIJhxi1x2ydIfkZi7HHDFy//HTzTSBYx?=
 =?us-ascii?Q?PB/R6TzI82goAsE7j3tpe0UjAqI8VWkTiq82/1RjZDRREWI40jZd7tbX/LR3?=
 =?us-ascii?Q?1P5kax2z55+4NHTk+kYE011Lpm2+uiV+W8kecOpf1RbvAg2hslYjAm24u+NP?=
 =?us-ascii?Q?szg1ZY6fdSGvBkYtm1rNp72af8DzZIRkBgAOzZhSmnzT50WZBJHAajiPwbU9?=
 =?us-ascii?Q?WOW29FYDd/LvQgGHpoMUyzmciD7bAtUq8dOj6hu+4RByinhfwBcr1xYWc/dq?=
 =?us-ascii?Q?kOz0+qDKPb30I0bNgea5w4IBeG1+NRbxA3ep7O5lK++5UxlUhVJKz0MQ5NZK?=
 =?us-ascii?Q?2cnw2+A2JK531jcGKkvEx7j3yjFc8GBXiYWuyM8WTMZ/GlIcO2vWi9S/NiMw?=
 =?us-ascii?Q?CT0C4hTYcbyz/vM2tEvGd8akZTX4z0cF6GXRtVszuMNfXLtNtgu+7/EbTR6Y?=
 =?us-ascii?Q?VKPCTq5GGzUhGKz6kmrezDU9RAqUBw76FL95HiWVzzV6cV36DwKsUccfpJlj?=
 =?us-ascii?Q?ncOihqIECPXg8zym56h29fYHFV8qHUpP2ZPUnrJV4YOLTdVtoy88pQdGHVLM?=
 =?us-ascii?Q?KdjceoDoTy+FzmPWLHf9YSIA14j9/RIAnY/IbwRsyeoz4DwIvvPXQDNJiY25?=
 =?us-ascii?Q?P/ETmHBEVxm0OkCtAvML3cOCJnzSX8ucDFIuBF6jbbNm8Pns06EbcwUSa/6k?=
 =?us-ascii?Q?2DCYu4oODxN02aOhIceNpZFxg+UcWz0obB9bKNW6CP21YkkFklKMcH9YpgvF?=
 =?us-ascii?Q?HN6DyJPUaiYbCqzRVG7oeYCZ1zfIt9VRCCIqD2AxP/cHR2usSVIfth9ywD8r?=
 =?us-ascii?Q?pY2IkGm8U6QIpwHso4Zt7YnLVd619ti2w4m9NDbevBy3oiXp1n4lRNtdjuwy?=
 =?us-ascii?Q?IrS3/MFrS7Y3lfJvVmK6Mv307BKD6ZrIv9pR5SUmfeaG+tuDdPpdjctOl+Sy?=
 =?us-ascii?Q?kNOkbunnty/JPs9J2fxe5jhBJTXAK3Mc13kC2TP4J4cc2nF6/YBBLv0+joHy?=
 =?us-ascii?Q?Le7vykYk+O2PUTDGKsgHLxM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab8e4d2c-ffdd-4a35-c825-08d9b56bf781
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 08:15:56.9311
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDhBHtyBS9ccHWu8hrxMAv60O7vpI7JXzPbOjNPIAQOq9B/Lg+5EMxdJjAGRqsNNSDyv99fs8ePO5KmBUkmkaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 01.12.2021 19:33, Andrew Cooper wrote:
> On 01/12/2021 10:35, Jan Beulich wrote:
>> paging_mfn_is_dirty() is moderately expensive, so avoid its use unless
>> its result might actually change anything. This means moving the
>> surrounding if() down below all other checks that can result in clearing
>> _PAGE_RW from sflags, in order to then check whether _PAGE_RW is
>> actually still set there before calling the function.
>>
>> While moving the block of code, fold two if()s and make a few style
>> adjustments.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> TBD: Perhaps the dirty-VRAM piece also wants moving down a little, such
>>      that all three "level =3D=3D 1" conditionals can be folded?
>=20
> TBH, lots of the layout looks dubious, but I'm not sure how worthwhile
> micro-optimising it is.=C2=A0 This particular rearrangement is surely
> unmeasurable.

The point of the rearrangement suggestion was source tidying far more
than micro-optimizing.

> Fixing the (mis)use of mfn_valid() in the logdirty infrastructure will
> gain a far larger improvement, because that's dropping a fair number of
> lfence's from multiple paths, but it's still the case that anything here
> is rare-to-non-existent in production workloads, and vastly dominated by
> the VMExit cost even when migrating shadow VMs.

Quite possible, but entirely orthogonal to this change.

>> @@ -661,6 +644,25 @@ _sh_propagate(struct vcpu *v,
>>                    ) )
>>          sflags &=3D ~_PAGE_RW;
>> =20
>> +    /*
>> +     * shadow_mode_log_dirty support
>> +     *
>> +     * Only allow the guest write access to a page a) on a demand fault=
,
>> +     * or b) if the page is already marked as dirty.
>> +     *
>> +     * (We handle log-dirty entirely inside the shadow code, without us=
ing the
>> +     * p2m_ram_logdirty p2m type: only HAP uses that.)
>> +     */
>> +    if ( level =3D=3D 1 && unlikely(shadow_mode_log_dirty(d)) &&
>> +         mfn_valid(target_mfn) )
>> +    {
>> +        if ( ft & FETCH_TYPE_WRITE )
>> +            paging_mark_dirty(d, target_mfn);
>> +        else if ( (sflags & _PAGE_RW) &&
>> +                  !paging_mfn_is_dirty(d, target_mfn) )
>> +            sflags &=3D ~_PAGE_RW;
>=20
> This is almost crying out for a logdirty_test_and_maybe_set() helper,
> because the decent of the logdirty trie is common between the two, but
> as this would be the only user, probably not worth it.

I'm struggling to see how this would improve the code construct without
altering the behavior. But then you say anyway that introducing one
probably isn't worth it as long as there's just one use site (and there
aren't ever two decents of the trie, so there's not really anything to
be saved performance wise).

> However, the more I look at the logdirty logic, the more it is clear
> that all the mfn_valid() tests should change to MFN_INVALID, and the
> result will be far more efficient.

As said - an orthogonal change; nothing to be folded into here imo.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 08:39:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 08:39:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236374.410026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshbx-0006vr-Tv; Thu, 02 Dec 2021 08:38:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236374.410026; Thu, 02 Dec 2021 08:38:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshbx-0006vk-Qk; Thu, 02 Dec 2021 08:38:37 +0000
Received: by outflank-mailman (input) for mailman id 236374;
 Thu, 02 Dec 2021 08:38:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mshbw-0006vW-Qq
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 08:38:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c149025-534b-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 09:38:34 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-lkeTBcpGPJeWzjZu-hT8Aw-1; Thu, 02 Dec 2021 09:38:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 08:38:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 08:38:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0110.eurprd04.prod.outlook.com (2603:10a6:20b:31e::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 08:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c149025-534b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638434313;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JDfG7QnuXIozd6Uo8+SLmF7kT7+FgiM2wu7/+Yt1e1g=;
	b=NhGLtFkckFYriZuiR7mREFn1hh1cpdoEodIAosXGQfFVwaFtItSV4na82IFuY2EY+7DzrV
	caUHPZWXAsEcXK50xzoutVGVSYS1EXlpaR57xHQeWfst0LMydtPvnKXLdi62A1KnCM5dS2
	KyAysDBC5ziA4OP9XhmxEbpix9N3sS4=
X-MC-Unique: lkeTBcpGPJeWzjZu-hT8Aw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VpDEiTgh05EYqW437imef3e4tVSdqCyDdybM/p8DT//a0o/ac8g+/H4a3GX4mzCLZv4K0SjG8+y6u1HikKRA07qxkb+Eb7OQGdGeoAMU4CtgDCY7wum+YprDLQ0rvaZs/u600pQcX3XIn9Z/7pv0aFGXy41sfLPmkdnUDaz3Wy5Vxu5atBXz48CVJ8uSyqvXxwEpaBFk/YnDvjdOac90VaYUKYrkYFAwU7KyaL8uiB2Fkxi33+KSnMnulVWEk/S/Qi/agSrdvqLGYAeDrKHhntTcWGIrOF54O4J+3ogRW9sg/oI+a/vBneCYguoTbBQ555Ec+EhJhkA4svCW+EDGDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cA0byD2VopeIeBF0nRYVB2hkxqPKiY6G5+0OQWwieOY=;
 b=JM52xS2P+jDsAB1cn09piXnyuHjSA/a3osqjWK60Ov520Nlb8ccXf5+JcDK8ZSF8IaEmEza1894S02DssTMkj4t76E37yLjJQygQdOISXPIl1A5lcNBEItJbNV2LrlnR9X1UILFY8HMKaOzvAf6dgcorcK86HSJwEhMZvEuaj/9elqWwjFPCI4/WNAuiMJx3+WOaJtMc3PBMCLFaT64ntQadB9nWd97gBtFMiwCaB0AOgqPKwkoq0gEevO73p8dOCpvn7xf9oO8bxLnv8GDSVvYhe73Sp4+BG33SwDFbAhM4/xZGkH2LRYo9zLuEg/ZV9ImuyAHG0H+IefCj2/Lg7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3fb1cfc4-39df-16d9-0af1-1b226f7413da@suse.com>
Date: Thu, 2 Dec 2021 09:38:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/2] x86/paging: tidy paging_mfn_is_dirty()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
 <e5070cbe-949a-4913-1f99-7b7a4e6c5536@suse.com>
 <39afb361-4047-68d1-acdd-e0838f52cb5f@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <39afb361-4047-68d1-acdd-e0838f52cb5f@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0110.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4b78d6dd-b4f3-4fe7-b550-08d9b56f1e75
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71509995F6A1D039C17D66C8B3699@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BSICfY1xcW0Dw9Q79eyBRO9HJf9rHV/h91SgPbGej6dzKp3wDv9oZJrHdIGvyOaaYif7sKbIvfjmCqh9ujeZ2pbyAKtCrC8vUkMbSRX/R2uyU4tdOiEPal+/QLD/PW9lF+t5254O6TpfXxnL5ddT7tSWL77+B0XnMx1Mc6PuIENznc3zuQ2ow0yMe1vIUH5QvzxwuKxFk15KSWdoi54t4GRmuJ+8cgCAzLJohixw+0JVQxBZLiGjj1FA4W/pvnlhK75TYiNgXK2ko+JWbWwA8xBzryY78EBKAu9DRmgHRu97jYWmyuBdxMCVMCQUHG7KcXh9R4Vod0Zck3c7cs3ctKYEhMmq2PwGf4hIfX+dZf/dqC7CR0v0Y3EvMWvQ0Aefhj3HzTFW/viCq1MgYkkzCxZxdqJDv6o8sHDLq6i5HSIXByxvRbC6zwSEAOYrwxxIId/4eDcRgr28fJmYEWYe60uT0gtF9qmupzyH+ZBM/e20UQTTPprkYyqI6eXfa6xE8NAMailQ/vUMOIhpFmnxLSUJraUXfwV1yF1sd9SG5QNHoJ4OBwwweBEnazD0lh0qIvLSjYAxYuv76TFYWzEgIj34S78A7iOseOQHOPJIzRGH+dmpFnjv0dRXslOjktND5KHll60JHcOy9OJvpNMMzT4cm3aeax9PG65npCJKCSeFlhRF7B+mL7j1Dl9qAmWRmQiq8unhRsjlLFThXwijVINirBC58Zm0ZhVNWTHdRNLNaYtCWaj9F88K7piHuxhP
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(2616005)(16576012)(66476007)(31686004)(8676002)(508600001)(956004)(6486002)(316002)(186003)(86362001)(66946007)(4326008)(5660300002)(83380400001)(38100700002)(2906002)(53546011)(54906003)(8936002)(26005)(36756003)(6916009)(31696002)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vMGxCWT5J8EoGwUSoFXr72JnS+FSYBcMs4VfLmciJKfRmhbWsxzOsMsxJyJ+?=
 =?us-ascii?Q?2GNg3kQc+rzDiw+S1i3HRlVVwdt1qXH47lY1gupvkGvr0Wg8k/7B59mIfWtJ?=
 =?us-ascii?Q?VGUj3tVBJn+eNfx7qL3LkNW29lWAnj8M+CNCiGxvfjfh5VHxa37DxSPsMqjG?=
 =?us-ascii?Q?YHSV3bq7i3x51z9YvnxzvyCp/YYlgBNWyRujHgsMhHpsp0yMRdSNc31gHKyE?=
 =?us-ascii?Q?nwdT8YdPbHLPeluXB9wUyprWIZTiyMdCtUUlATHEeSIPCKX9rXEk0GENgkZY?=
 =?us-ascii?Q?q+RIaAkGOdaCqlasvvGT04XrBh/QBWh/+ifKUpigizR6Cd7TQwF2eiMh943h?=
 =?us-ascii?Q?D2evFf5pE3P4hmUn/0wWStEs4Jat9khrUD/dyypEcQiIqMJo5pN+v8BEguYw?=
 =?us-ascii?Q?hiVuCAawLoFR0LwbpbMWDkLeuSie4uT5NWmaHYJ8xaVVkSIPmMjoBpH3hlP3?=
 =?us-ascii?Q?v3vpcZLEk4dB3TatTitg2U6npvcxjOlt11HnlzGZXP0wzVkEWAVMHFSOWzAN?=
 =?us-ascii?Q?qZVdklndxW0S3AC4eCmFOP36CyUK2bNsETi588Qlj57YUZwKzSU2wU4EtR6T?=
 =?us-ascii?Q?thHNqjWaaYF67z1dtw1u7Dh1Y+EWbZP4NMMJWYmf6RKJLJdmQgCaYEKTk2ui?=
 =?us-ascii?Q?3IuMqhzoX6uVeBJccHr7ISfAbXzDtlPw9TtzdTO3ePA+L7Op91bKGLen7kw7?=
 =?us-ascii?Q?2LbUS0EE9a+MAkHG/54anSZnzP7axPbwq7e7FjiHGwvYqf93rONd6+HYqT7m?=
 =?us-ascii?Q?T7ooFP28V96GwX9Y7aHgqL2quMAN2eo8PPlbYlvuZyJaw6zaXMMC9590lTOO?=
 =?us-ascii?Q?i0982HIGewbgwxfYo/agwhYKYpui3yHTKDf7QSdGv+LCzlXRORJqE049U/v7?=
 =?us-ascii?Q?q6TugrjYO9UeykWVpl2Bt46DwYBtWmsBzASyP32BwDN+SKbeJkFPp7pL9I3F?=
 =?us-ascii?Q?6EVPUSu9ebkF5OyaXfRDY2U/rzCSw94HZxYirBUZnOLY1jQld1GklUxs4LpN?=
 =?us-ascii?Q?YMCOC1szKEwgzSPUqLuRyG6QwNx1l9GEDVinIwCb0lZ26Zh/GxOdw/Pbv3YS?=
 =?us-ascii?Q?v5fYBenTHMW1PdBR6mRx64P/xfVjnd8uYyfbFdKopkxg4xLolpurp4ppEUa9?=
 =?us-ascii?Q?Vnu1sqIrLSXDlKCh5s2YwqYdtwgYxdGcAZ7t4yFuY08Dfw1516PmhgKn8DiT?=
 =?us-ascii?Q?fvTE+msLVk8/82jGKiq8cBkcRswc9H/Rrcl3M2vbI4KGDKsnfVdjIR0kcIVF?=
 =?us-ascii?Q?mBtapfOMBEfPpENOU/ckPTH73TAdaBGaxTNcO4iVxw4dQPuDZBrIAz2SBmh/?=
 =?us-ascii?Q?UbXxQA66mgtS/oYSEPGLKRMsV4aK4/aUum4t9fojs3UjV/wLu060KB/qMd77?=
 =?us-ascii?Q?OQ/CvAVUAok8VmbUPfg5n44SBXlOByqR8cO9/KEvB8hG1PIvqDJFrWXMY3m8?=
 =?us-ascii?Q?rcaWZnlNLN+2Vv3VBZHMxQYyPDp3Hey9EQSnqcDQzY1qL7fnsP7fAgOiEoV2?=
 =?us-ascii?Q?sm/xGQl3qLv7bTkFcOEGESBLpgOtzpfJsb/bfQ2+hnVT1lFiXLEKGdeJ7z15?=
 =?us-ascii?Q?LD1c6RAJ2CaIUik2gfXEFdYdvfwSRZIip5EhIOzwytyuPro+yd3RQFC+z5DF?=
 =?us-ascii?Q?AXwJx4EX7rNJ7RJbCuouCoM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b78d6dd-b4f3-4fe7-b550-08d9b56f1e75
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 08:38:30.7983
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pyySnokAm8pyyXAQMBo63KCcoQhtyGGS++d+XDQypzU+QYK2TwamaSMcNeeQbs3Y7X8c4kZE053Vlv5ToBRB/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 01.12.2021 17:06, Andrew Cooper wrote:
> On 01/12/2021 10:35, Jan Beulich wrote:
>> --- a/xen/arch/x86/mm/mm-locks.h
>> +++ b/xen/arch/x86/mm/mm-locks.h
>> @@ -40,7 +40,7 @@ static inline void mm_lock_init(mm_lock_
>>      l->unlock_level =3D 0;
>>  }
>> =20
>> -static inline int mm_locked_by_me(mm_lock_t *l)
>> +static inline int mm_locked_by_me(const mm_lock_t *l)
>=20
> bool too?

Oh, indeed. Will do.

>> --- a/xen/arch/x86/mm/paging.c
>> +++ b/xen/arch/x86/mm/paging.c
>> @@ -351,14 +351,14 @@ void paging_mark_dirty(struct domain *d,
>>      paging_mark_pfn_dirty(d, pfn);
>>  }
>> =20
>> -
>> +#ifdef CONFIG_SHADOW_PAGING
>>  /* Is this guest page dirty? */
>> -int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn)
>> +bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn)
>>  {
>>      pfn_t pfn;
>>      mfn_t mfn, *l4, *l3, *l2;
>>      unsigned long *l1;
>> -    int rv;
>> +    bool dirty;
>> =20
>>      ASSERT(paging_locked_by_me(d));
>>      ASSERT(paging_mode_log_dirty(d));
>> @@ -367,36 +367,37 @@ int paging_mfn_is_dirty(struct domain *d
>>      pfn =3D _pfn(get_gpfn_from_mfn(mfn_x(gmfn)));
>=20
> There's nothing inherently paging.c related about this function.=C2=A0
> Thoughts on moving the implementation across, rather than #ifdef-ing it?

I wouldn't strictly object to a move, but doing so would disconnect this
function from paging_mark_dirty() and other log-dirty code. Please
clarify whether you've explicitly considered this aspect when making the
suggestion (I did when deciding to use #ifdef-s).

Also, to make the changes reasonable to spot, that would be a separate
patch then.

> If not, can we at least correct gmfn to mfn here and in the prototype?

Hmm, that would incur further changes, which I'd prefer to avoid at this
point: The function already has a local variable named "mfn" (as can be
seen in context above).

I also don't see how this request is related to the question of moving
the function.

> Alternatively, do we want to start putting things like this in a real
> library so we can have the toolchain figure this out automatically?

I wouldn't want to go this far with a function like this one. To me it
doesn't feel like code which is actually=20

>>      /* Invalid pages can't be dirty. */
>>      if ( unlikely(!VALID_M2P(pfn_x(pfn))) )
>> -        return 0;
>> +        return false;
>> =20
>>      mfn =3D d->arch.paging.log_dirty.top;
>>      if ( !mfn_valid(mfn) )
>=20
> These don't need to be mfn_valid().=C2=A0 They can be checks against
> MFN_INVALID instead, because the logdirty bitmap is a Xen internal
> structure.
>=20
> In response to your comment in the previous patch, this would
> substantially reduce the overhead of paging_mark_pfn_dirty() and
> paging_mfn_is_dirty().

May I suggest that the conversion from mfn_valid() be a separate
topic and (set of) change(s)? I'd be happy to add a further patch
here to at least deal with its unnecessary uses on log_dirty.top
and alike. Of course such a change won't alter the "moderately
expensive" comment in the earlier patch - it'll be less expensive
then, but still not cheap. Even less so as soon as
map_domain_page() loses its shortcut in release builds (when the
direct map has disappeared).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 08:47:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 08:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236382.410036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshkg-00008O-Sy; Thu, 02 Dec 2021 08:47:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236382.410036; Thu, 02 Dec 2021 08:47:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mshkg-00008G-Ps; Thu, 02 Dec 2021 08:47:38 +0000
Received: by outflank-mailman (input) for mailman id 236382;
 Thu, 02 Dec 2021 08:47:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mshkg-00008A-2h
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 08:47:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7fd1ecc1-534c-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 09:47:37 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-FEQti1_fMK651T0CZmQpUQ-1; Thu, 02 Dec 2021 09:47:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7087.eurprd04.prod.outlook.com (2603:10a6:800:12a::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Thu, 2 Dec
 2021 08:47:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 08:47:34 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Thu, 2 Dec 2021 08:47:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fd1ecc1-534c-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638434856;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IX8V4+u3EsAJbStITWzswPVE23pfTomwmiRAJcDmu/g=;
	b=TUKsRLENwtT4ry95nh0gh4ZOL2k1rfL3xMGRr6OIWkm4RwWPQQC/NanZjgGyUqPxROUV8d
	sauDMaRl152TqoGxCAoRsq5SJfWXh6CNxLpGkLj3vyrIbuyJ6K/cgPY4p0Wm8nKJ/2tOYT
	a1UTh34np2if6D/UUdS26IuU5ApnLDw=
X-MC-Unique: FEQti1_fMK651T0CZmQpUQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QKe6F1fjLbJNFrLny9J5xQHZPyAXy6qLfxPKP1BNHQNFnYlvK4Ic8VfOu9BBXkjeFgz4RqvRxHwGVB9gWWm2j9TpxrfwQEXRIyfFWB5/4/MTvmBXug0A9Sye8AGxMd/xQ5OmEntIufOYezyYd6jUCKsF1o3uYoyUDcWPEDli3Zh46B4GGGDKYYlRuiMyFM1+p4PDaBBRhyCJw6CTa8Sq5n085tq/5V9Ubn/QnLSm0BgXnOcWhC3XMQ+weG5Y/1U68wXHR1KdQpHpQ9XpzqwVONh+6X+cE+3VCo2g39C5rAv3jI1fKnyIMHxY1fcXRLiXRsWfCY5lR7iavA589yarYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IX8V4+u3EsAJbStITWzswPVE23pfTomwmiRAJcDmu/g=;
 b=R5u7Ew9f8scikvOU2Ns59desO9rPiX2B8Y0iyu2muxw54WE/2aSZ2XZrOzG99Yt1lZbbHFviXg6Bw5BZHNnCSPRsO0i/VwYtE/itikFsF6hOnidw0WajMXdhv3oePhK4Luwo/V19/TN3JJ+i1NgdOLNjQ1n1dGE2edpEq7gowYovH+3c3q/SC0HfQUl7Q6N1Dd9qftP50+xLJETptaSQIsuTpu3MPMS2aJzm2tXWnpm6rxgw5SGpm3nVLuec+3s/hlxeLC5Dl7LOkBOSOWBJWIXouIVpBXBN+78xKvnhwFsbYepGP1xIJCjopUwfdWY2p4aXkb2N4TgFBZHzHU72dA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8a9bf3aa-5f91-a81a-813d-f50ad01ef3de@suse.com>
Date: Thu, 2 Dec 2021 09:47:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 3/4] VT-d: replace flush_all_cache()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Kevin Tian <kevin.tian@intel.com>
Cc: Paul Durrant <paul@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <8a8dd03a-5447-bc45-1554-50fb5b6c075c@suse.com>
 <a6489b9f-6f93-94d9-549f-07fc761a4830@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a6489b9f-6f93-94d9-549f-07fc761a4830@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0006.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc3c0d4c-7304-4295-ad99-08d9b57062b4
X-MS-TrafficTypeDiagnostic: VI1PR04MB7087:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70876A1603690B4B6FB15FD3B3699@VI1PR04MB7087.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Hwsn9FeOqvIrpaN4mOR2S7TsOzgywi2WH8rp/tyZLfbHHu0mao2eN2sO7SudkW1KJDo2RbqS0ygY71csbEZUd3WBGxiV3+++U1jgKyyWSyT9jF3u/dJ7gwWXWEtYGYBWtT9ac9NzUeYX9lK4/FmfPEx+nGtmOniggTWxMrNBVRbsmKr1Q5hVjOJ3CumaP9njDlJqJCHTKgSwp4oIYCS7DN2Yag5nibdRYAxPpRuBMWXdCnSBdjPM0A5n9qxcvreiTgv+QC+RVJsoZup5oUb3qQi8s2OZ3TqEpUKwjZ1PeoRHe36ZoBbW6+sN8B4cLaP51M1NQxnzT+iD8tiiXEx0ySyPW5JL29qCekHjJw7ptrHhwZOun1KPRynd2dB/Bav+V32e4dUMFHmcItDV/6hDfBhOHFjkSdRxAktTc0Uk2e2KhmXMbUlg5V+6HTgxgyATrrrbf6Dgsmq1aet5pEeNK/CRNcAiiMeu6F/jjbyOTrXSS54M1c9egOPXQMS90lbcUGsJMMiwF4vN2yIWr2YhqfAjPD2Ilcqo+CMQpwIn3ilKFf8pIs6GwZHFNaHoPHjMnLJ43FvoqPIw8+Mcq4KfufXfeWdBm4JKkl2AQkua8QsTLeEnaDVd3mq1TBeJ+sVYt4ev1YbcpMscDslD9ar2kHAcQ3YO4+FuXCwM04xCpcu8ix/VthXTR13J8I6iDq1f926L5Hz3UHXh5kL68ASJWic8qU1n765g2C4axF3u5L4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(16576012)(316002)(5660300002)(4326008)(53546011)(2906002)(36756003)(86362001)(38100700002)(4744005)(66946007)(66556008)(54906003)(31696002)(110136005)(31686004)(66476007)(26005)(956004)(2616005)(186003)(508600001)(6486002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dWtjTDNrYXdVVGFuYTVqbjJWdWxEUEdRVFNDa1E4OWRzVnM2NmxCSE50OUI5?=
 =?utf-8?B?ZWRGN1Z0YlZEdWJaRUxvTC9CcmoyWTE3MmZJV3JRY2Vob2Y2dnQzWW1WV29G?=
 =?utf-8?B?QkVUNHFmS09EYzMvV3dQZWRxdk5FWHBObUVaT1U5TTJwamtHNUVrd3pXWWYz?=
 =?utf-8?B?UDRyNjl0Snhud1B3eFNuYVJxcUFVdi9SZTQwSlpBTEVWbTBaVDJva1o3R1A5?=
 =?utf-8?B?RWQwZWFhV0pic1JVbDJqNHd3K3RnTUVtaDIwZ3pBZGFPTjBJeTdZMHhNb1ZG?=
 =?utf-8?B?U1J3MlFjVXp5dVBKbHAzRGhzcUVXZE5nVXRpV1dmRVlnTHZPaUxoS0xNR1pR?=
 =?utf-8?B?MXl1cjhnZktvSER2TVRlN0wvY3BPOTNLR0JtSzVoZkg3VXFoSlc5b0cwQUh5?=
 =?utf-8?B?MjlUTVgzZ2lqdGhlTFUvcnhuSmZDbVdDeGVTTU9LZG1Td0xPTUlMcjlveGQv?=
 =?utf-8?B?MlhlUWxweGJCb2tlcGxpNmpIUit1cFk5bEdjcXdvcFBuYUFnVE05b2w0aGJP?=
 =?utf-8?B?UkhlNDZNSzZrajdDNDBMMG5hWmlYYVlIaTdWa3NVNzN0ejlQVWJ1dzZDVDhR?=
 =?utf-8?B?bk9ud21mSnl1VXZHNnl1SWFDUmFOZnpPS1VtVzlFTW1qNnpiSUlrSStKclg4?=
 =?utf-8?B?UjJtd2kzekV0akdPTStEZkY4SXVEYU9WY2lZMEQyRkJKM1VsK0o1cittTnNF?=
 =?utf-8?B?dEhhMFdveUJPazFLK3A0TTA5Ymdad2k0S0VJc1JybVJwVW5kdlFPTXpnSzVI?=
 =?utf-8?B?RFVDYTdvQU53cHRUQi9HUWVFOWUzZ2xwdjl4ZWNzKzlGTUsvRmJTZ2p5SkFX?=
 =?utf-8?B?THZCSUE2RUp2QUNtUkd0SG50Q0V4UXpOQXhmSURFRy9aVW9tL1diS3kzSDI2?=
 =?utf-8?B?NkZoVTZ5T2NNRkIwMVAybVdYeVNibG03cjV6R3B2Y3U2NDNKUFN2RzE2SWhU?=
 =?utf-8?B?ZkJoeEw1RlgzMDlPNnp5RGU3a3BxQ1pBckZCS0ZJcXRFVlZNMEtWUmVETzhi?=
 =?utf-8?B?M0lGZ0E3K1JBL1IydHNuVkNKWi8xenFlRVFWajY3NUk5YkU5VVFxSmhkRmIy?=
 =?utf-8?B?aHNzSENxaW9QV3R4NGFYT29kRk1JSGlXbmRBOHhFQkZZWTV6NHBnYTB4U3Nk?=
 =?utf-8?B?dmZ1NkxzNEpET2JBOGliS0ZkNlphQ2xzWjVmcCtCQUp2MTRDcUdWZXZESllq?=
 =?utf-8?B?MGNLdnVSNHlJYmZiUGxyMG5uazU0bmVHWERTNUxPRjNId1RwbUZNNVRvZEdp?=
 =?utf-8?B?QUZleU5wOTgxRGpDTmZZV3lkMWtEdWVvQURBb25vamdoM2JhWHpXVWFNb0hB?=
 =?utf-8?B?WTNYd0NrQ2VVY3IxRUMxYjBTTWJqendSSGk5OVBraXduR1lDNzAxU0dyQmtU?=
 =?utf-8?B?ejMwSU1UNTFwZzdBVGs0UTYzMGhjcUs4ZG1tVDl2bUQ0allkTjk5N2tobFd0?=
 =?utf-8?B?UUNyUFZIa3ZGYXFwKzVtcTRiYitmN0VqUTFjN29Fb3k1RXpSM2xLbkh2cmRC?=
 =?utf-8?B?QnFDQTJuYlRpOWxWVWFPZjFWc3pzZU5zUWN0M0RzQk9QekQ1N3ppWEpTbWFY?=
 =?utf-8?B?dFp1WU90T0hqaTVOL09PQ3hBdTBMa2JDVFBqQWZJeVhTWVIvbWR4OXZpQUc3?=
 =?utf-8?B?QjYyVVpZMUs0ZUMyUGF3U0FOSEhucWtJT2diMDZ1elIxY1NKVlNpelN5cjdi?=
 =?utf-8?B?aEJIemNlblpxMW1MNXlTT1lKOXJkL0RhNVhVSmIrM2VGWmhBSFZBTXBsV3Vs?=
 =?utf-8?B?bnFibjFSemY1bWw3THZsVUVOQTg2cWlwTVJYLzVncXoxb01yOU1TQm84WEQ3?=
 =?utf-8?B?eUNmSGhsUkpTOTBSSHBkOVJCVEVZNnhlMGcxZVlhRXdEa2hqdmo4N21QRVgz?=
 =?utf-8?B?QXlaRW92UEk3NE8vellnWVQ2Q2MwQmcwa2VtdHVyV21OR1lQTHQ1YnA5TW80?=
 =?utf-8?B?YlNoZnlFWEtmSDlXQ3lucDdJSFNaSnpBbG4xdVVoZWg1VnZvZzMrRmVHcXFG?=
 =?utf-8?B?eldTYXhTVm9Vb0FQL2xWbDBTdUU5NXIydzhucXRGcGlxTmV1OTE3bjZUUi8r?=
 =?utf-8?B?SzBHWTZ4NWxYRWdkYmF5ODBXczcwRlRoNi94YjM3R1NrR3VFN2dFd3h1dkV4?=
 =?utf-8?B?aDd6ZUFxUjNXaU4ydmJkZXBBSW0vaUwvVGZZU1kwMjh3WFY1SitGNEVRckND?=
 =?utf-8?Q?Ana548OdrsZIVxzQLyXrvF4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc3c0d4c-7304-4295-ad99-08d9b57062b4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 08:47:34.7677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6BX/CTkbpNeien6eABGGLxst/zhWs1vs8sU0MxTV9+PyZF460hJjIi4amdRAyEHygMdRPUe2bem//mzhdbUjEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7087

On 01.12.2021 14:02, Andrew Cooper wrote:
> On 01/12/2021 09:41, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -591,7 +591,8 @@ static int __must_check iommu_flush_all(
>>      bool_t flush_dev_iotlb;
>>      int rc = 0;
>>  
>> -    flush_all_cache();
>> +    flush_local(FLUSH_CACHE);
> 
> While I agree that the conversion is an improvement, the logic still
> looks totally bogus.
> 
> I can believe that it might have been a stopgap to fix problems before
> we identified the need for sync_cache() for non-coherent IOMMUs, but
> there's no need I can spot for any WBINVDs on any of these paths.
> 
> I'm fairly sure this should just be dropped, and Xen will get faster as
> a result.

Kevin, thoughts? I have to admit I'm hesitant to remove such code, when
there's no clear indication why it's there. I'm also not sure how much
of a win the dropping would be, considering the places where this
function gets called from.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:06:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:06:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236392.410053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msi2a-0002eF-M9; Thu, 02 Dec 2021 09:06:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236392.410053; Thu, 02 Dec 2021 09:06:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msi2a-0002e8-IW; Thu, 02 Dec 2021 09:06:08 +0000
Received: by outflank-mailman (input) for mailman id 236392;
 Thu, 02 Dec 2021 09:06:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msi2Z-0002e0-Ao
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 09:06:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msi2T-0005YX-Nn; Thu, 02 Dec 2021 09:06:01 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msi2T-0005KT-HW; Thu, 02 Dec 2021 09:06:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=lDwEy1J6TG2cq2JQtW2mU4oOXVGl8ltMAdLmt8+meng=; b=JahmZwbw8Q6e499FYnDitG2adR
	0c4kAlMxBl5loPsAhjAI30+j9o4RnzmFRIUQfhUQhGviF7ym6QGLNsvUyQ2Ek10b76dJ3Q0PND5be
	OSG2enA/kJYwg9YgqoUGfwR4d8u/8eDOKrFurUmgqYZn/BxGircA14RSnn//AKxgVWm0=;
Message-ID: <acb3dd21-688e-4ad5-2e30-7e505a8e2945@xen.org>
Date: Thu, 2 Dec 2021 09:05:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v2] bitops: Fix incorrect value in comment
To: Andrew Cooper <amc96@srcf.net>, Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com,
 bertrand.marquis@arm.com, Ayan Kumar Halder <ayankuma@xilinx.com>,
 andre.przywara@arm.com, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>,
 xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>
References: <20211130181238.5501-1-ayankuma@xilinx.com>
 <c018e9dc-5221-a7e8-3da9-ebdb2c88311b@xen.org>
 <3caf216e-95dd-97e1-b380-a31f5388dc86@suse.com>
 <959d50ef-2a4c-8850-4a89-7eff0b649a13@xen.org>
 <77a6b9b4-8117-e818-e68e-af37eeec2dd7@srcf.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <77a6b9b4-8117-e818-e68e-af37eeec2dd7@srcf.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 01/12/2021 21:38, Andrew Cooper wrote:
> On 01/12/2021 09:56, Julien Grall wrote:
>> Hi,
>>
>> On 01/12/2021 09:38, Jan Beulich wrote:
>>> On 01.12.2021 10:33, Julien Grall wrote:
>>>> On 30/11/2021 18:12, Ayan Kumar Halder wrote:
>>>>> --- a/xen/include/xen/bitops.h
>>>>> +++ b/xen/include/xen/bitops.h
>>>>> @@ -5,7 +5,7 @@
>>>>>     /*
>>>>>      * Create a contiguous bitmask starting at bit position @l and
>>>>> ending at
>>>>>      * position @h. For example
>>>>> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
>>>>> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
>>>>
>>>> ... there are two extra changes here:
>>>>      1) The bitmask is now described with 8-characters (rather than 9)
>>>>      2) 'vector' is replaced with 'value'
>>>>
>>>> The former makes sense to me, but it is not clear to me why the latter
>>>> should be changed.
>>>
>>> Would you mind explaining to me in which way you see "vector" accurately
>>> describe the entity talked about?
>>
>> This can be seen as a vector of bit. I can see why people may think
>> otherwise. However... if you think it doesn't describe it accurately,
>> then I think this ought to be changed in Linux first (where the code
>> and comment comes from).
>>
>>>
>>> I also think the commit message is quite fine as is.
>> IMHO, this is similar to when one do coding style change in a patch.
>> They are unrelated but would be acceptable so long they are explained
>> in the commit message.
>>
>> What I request is something like:
>>
>> "GENMASK(30, 21) should be 0x7fe00000 and only use 8-characters (it is
>> a 32-bit comment). Fixed this in the comment.
>>
>> Take the opportunity to replace 'vector' with 'value' because..."
>>
>> This is simple enough and clarify what is the intent of the patch.
> 
> This is an unreasonable quantity of bikeshedding. 

I didn't realize that two emails were considered bikeshedding.
I actually provided and worked towards a solution rather than
unhelpfully saying just no.

> It's just a comment,
> and a commit message of "fix the comment" is perfectly fine.
> Furthermore, the intent of the text is clear.
> 
> However, "32bit $WHATEVER" is also wrong because GENMASK() yields a
> unsigned long constant.  Importantly, not 32 bits in an ARM64 build.
> 
> 
> This trivial patch has lingered far too long.  I have committed it,
> along with an adjustment.  Further bikeshedding will be redirected to
> /dev/null.

It is an interesting approach. I could have committed this patch
after updating the commit message like you did ;).

But, so far, I have refrained from blatantly ignoring comments and going
ahead with committing ([1] is an example where this could be used)
because I think we should try to have a consensus first.

Anyway, I am happy to accept that two maintainers have an opposite view 
from me and go with the tide. That said, there are probably better a way 
to express your view...

Cheers,

[1] 
https://lore.kernel.org/xen-devel/062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:10:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:10:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236398.410064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msi6K-0003Sf-5k; Thu, 02 Dec 2021 09:10:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236398.410064; Thu, 02 Dec 2021 09:10:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msi6K-0003SY-2P; Thu, 02 Dec 2021 09:10:00 +0000
Received: by outflank-mailman (input) for mailman id 236398;
 Thu, 02 Dec 2021 09:09:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msi6J-0003SS-7s
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 09:09:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msi6H-0005d5-Rn; Thu, 02 Dec 2021 09:09:57 +0000
Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.193])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msi6H-0005ZH-Mt; Thu, 02 Dec 2021 09:09:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=YJFDQgv6FpxtJFA/eDP5Uanuxwt/VhF7A3HMEYoZv5Q=; b=fyjqzgqHsiP/4kw3yn5XAykAFe
	9N+UWLWq499dPfIZrfETS5KEMXj41vj1aEN3qOXCfo7/yjhekrFWr9F++mXBS7/vx+hCm8URxweK3
	vzr8jjONUtRj8rKhbHa4WjfL7Fhy2Xm3ZqPMriwVg68rqiF+F8/G8ivjsJ5vTOTjEnq0=;
Message-ID: <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
Date: Thu, 2 Dec 2021 09:09:55 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from
 gnttab_map_frame()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 13/09/2021 07:41, Jan Beulich wrote:
> Without holding appropriate locks, attempting to remove a prior mapping
> of the underlying page is pointless, as the same (or another) mapping
> could be re-established by a parallel request on another vCPU. Move the
> code to Arm's gnttab_set_frame_gfn(). Of course this new placement
> doesn't improve things in any way as far as the security of grant status
> frame mappings goes (see XSA-379). Proper locking would be needed here
> to allow status frames to be mapped securely.
> 
> In turn this then requires replacing the other use in
> gnttab_unpopulate_status_frames(), which yet in turn requires adjusting
> x86's gnttab_set_frame_gfn(). Note that with proper locking inside
> guest_physmap_remove_page() combined with checking the GFN's mapping
> there against the passed in MFN, there then is no issue with the
> involved multiple gnttab_set_frame_gfn()-s potentially returning varying
> values (due to a racing XENMAPSPACE_grant_table request).
> 
> This, as a side effect, does away with gnttab_map_frame() having a local
> variable "gfn" which shadows a function parameter of the same name.
> 
> Together with XSA-379 this points out that XSA-255's addition to
> gnttab_map_frame() was really useless.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

As discussed in the thread, I expect the Arm part to be simplified after 
Oleksandr's series. So for the Arm part:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:19:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:19:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236404.410076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msiFG-00053r-3e; Thu, 02 Dec 2021 09:19:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236404.410076; Thu, 02 Dec 2021 09:19:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msiFF-00053k-V5; Thu, 02 Dec 2021 09:19:13 +0000
Received: by outflank-mailman (input) for mailman id 236404;
 Thu, 02 Dec 2021 09:19:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msiFE-00053e-TH
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 09:19:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8df9d63-5350-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 10:19:11 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-XS68MOMaPEutv5_HswM4Dg-1; Thu, 02 Dec 2021 10:19:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 09:19:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 09:19:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:f0::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Thu, 2 Dec 2021 09:19:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8df9d63-5350-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638436751;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OXIdnLQ2xYyiV4KvIQxRgP+JHsO90gS6brmMhFPFcoI=;
	b=hCBLgNONkCpgddGUaPgK9ftCXCoAFab6Zc6iXpcsLPxHWYi6XqYCXoEC15j5QeUo/m5JF7
	ta0SyEnOrB9hpQoGTfp72+1VUkn+zCGCRq0OKc0ra6OdV8rnVck6FbLFP7vrj3k/W4dhqU
	wyQmIQrzT7TuYIDWeOUaphY8tn3M1C0=
X-MC-Unique: XS68MOMaPEutv5_HswM4Dg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VFhdlEEwvlXldfCV7IuWc6aaufxfo59+S1Bwc5c3PGxeEP9BEwBrqEAvXKsXG0sbaoVUg3Zr2B2FKlHZKnGU1qQtBRS5y73Z+mkIguc1eISv8LA8GSCkVdFBrLyesNtjNstvVppvrBxWvu3LYkTpm9hoMZMrBSByIR3E+Y2DOfPxsNI26ywWr0jxUYvEMk5sHhz3FmSc5co9r6lqTSMWj7zQLzuboyqT/w+XeJPVPmBQ8aRj3a+7d3Mw8jsVcpxIEOabiTbTs1VhRgh53O9lygx7C3wUwxxmGK33s+74OOooymqT0ul3GvZVcMeHURTzorQYORh4c0euH6/b+5RE9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2n5PImIlT9tbs9yJ0pbbJF3BrhRvqpW0KMCJAPX0tWg=;
 b=lPN+4naCG54ZI9P5el9gyGy/ovB5eMsmg9i6OPOomfCPCmMHi3LGR8lvQq7nixafWczz0kabAEKtgqtZZezd2W/GOTaofmFZ1zsP6v/I9jSZduDB+IRvr69FJDY6yYOqU3PwSXI6NwCHt5Iso4JMc0l+DjDZpFTaPuTo8nMoC9wSSGslR315V03b+xlP0kTsDVcdS79j3/4CEh1D66YGAOWEgGff/IoM5k9dGgtfaMfjHDIt6WaAJ2JmsTMnYKbo9/6hsU6xomLKE0/uuBDVULbGfmUn9yN25LcvSAaOYC63LmdvOlzO0/H9VjKSt6ciQWxRvWaPzksOqwQNF+QUYA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b361ea84-2b4c-6f3f-5a25-11d1ad2bc5fc@suse.com>
Date: Thu, 2 Dec 2021 10:19:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/4] VT-d / x86: re-arrange cache syncing
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Kevin Tian <kevin.tian@intel.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <e0819175-83b4-9489-8e4b-7be4940f1d54@suse.com>
 <2a448375-6f57-578f-6ac3-ba818d0c2eb3@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <2a448375-6f57-578f-6ac3-ba818d0c2eb3@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0043.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 57a52971-f96f-4f5a-b8e5-08d9b574ca47
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6304C2C94E10A36921530572B3699@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mFpTd2GPq5TXT0r5nYp0cNwd2Kx0sqYtYonD10aC7v1KE07pT/d6J6BSyskCKCg45oy12xukL1c9Xz+W7ix5Dio8V7dcflkk5zIn+Xtfubf1uTeAvKfRAe3trXS9t3JZAFXRFxgLdaEx7hPnzOSEWfvvHlqDxkL+QrGAA8nyZO7jcdYmwZHQ3kvSViPors2PpqHgOmBIKrP/nq6XsdahuXJWhuPCAo4eqY4q7ooJEAdhwKjf514UPFd6grcHe8VSwTNvezSnDH2i4cJzLTqZTXUAnr/fkh1kM3ixW2oz57pXqhPv8v0m3H2XjoiP26PwZXq8vs5kIxsh9BRe8GskaUutE8sJzvv0mJ0c9V5LFoXznO9CHOARUBnpJdzu0F8pjeBSJVR3jLjeEXbw2jk1y2aK443JeFYzMiszkS64tVY09N25AhvAVt07l64tjyiIzdUp/jSZqfzBdlKoRwzTmz7xbDZIJroVYtYSYS5X+/EJ4NuN4bFouT4PTJ/wLtlVmUKh7wMlk93dF7hy+h7GMzcgmUq26628798D6UoxtdfmlQAQf7faqlJ++rH+g/uc5PByks6G+Jji0h4AgjAx5NiiAGVJNcLT7EAVv0rThcceogESvDXqwAFcJ4eSIlRWgo00b8ceSlng0xu6V9KV06gmR+NhYJk/mbpz1CJp94jnCJ1gdvT47cMgP1JsIv7tQ29oCoAg0XtsSTQ1anp4A4QVzt2dWYVNxGEBXZaIjiM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(53546011)(8676002)(186003)(956004)(66476007)(16576012)(66556008)(316002)(2616005)(66946007)(36756003)(54906003)(38100700002)(31696002)(26005)(31686004)(4326008)(6486002)(5660300002)(83380400001)(86362001)(6916009)(508600001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3CIkcig4/FebqSzKkFpTxRq//6ErFEYwrTXTXKAvePX7nDGIwisejvL2AMI1?=
 =?us-ascii?Q?UqSaU58zt85ns72x0/0i0quTJq8QNTmsmt89n0JpzXQ+EJ6ULWRmipkroEFx?=
 =?us-ascii?Q?VDgL51fc9YdxdcV/UM7f0fy4QoNn0bjyszkxzn7THvTPjZoFCTCpXm5wPeN8?=
 =?us-ascii?Q?uupEEOkE/8xIz72B7fX/j9adn2ZWBqxl9apiL008rCfPOkDNHDhcEeCOU79V?=
 =?us-ascii?Q?g0dQBvm1u/P37Z6v8RCc8ziWyoq9jaFeoe2f8iVPBvcyizFd45RyksCXkf4C?=
 =?us-ascii?Q?mzxKDuMX8Tz7t01trVZFqxQTpfv3AgaQm1aM2he7knppUAUmSKrEvItp2q22?=
 =?us-ascii?Q?4HLOKwNuNo4qtaG5AbkN/ClAjdA6QufROh89ATYVUTqmI90mIv65wg636juF?=
 =?us-ascii?Q?z3315/EaFzIZ9ybK/59tDel9xCmc7HRqiAMP/nt9pZWKWMS4ckKzM+eprMII?=
 =?us-ascii?Q?fLOiinNcogCcYYDM1xb90omQgo1GiQTnjyCxVmVTAaFhZtUo02Bjgd0ljVMT?=
 =?us-ascii?Q?DrSX72Hr/fk2Hel5twneFE585rxSDJPvK/8W1x863lOMYvoZ+ggqyjkp6Mew?=
 =?us-ascii?Q?RuojKdf0LvLpJJhGMoErEk7laOoNEFnPdoTEK/0N8CiptGHgL5Fxg+LpGCcM?=
 =?us-ascii?Q?zUd/l02TKum9/FncjBE/C8zaNkNS7bDdH6Jp0D4Ldhv5pTCAgCSur8d6qp/P?=
 =?us-ascii?Q?N+vsdEAxumPX0I5fAZ4M6Yh+QxyzF+io0l4AEfgDZXW0r0DPHrr0qoPv1/BM?=
 =?us-ascii?Q?YSH3pZHe3j9uC0TKk3EeZomXHJxX4NKwTjjy9JTKbSRGMh8KvfyROCtfsGQe?=
 =?us-ascii?Q?+33Yc/UwIWMuLLDF79y8k5wjHDmk+N7SimlvvdP/8Y6rhvTz4EHLY20EP0MO?=
 =?us-ascii?Q?pMl7qCq4MT9a8ftwW9OGnuT4dlHatylXWiFVgh5fdn3Js/TB+i+FrdtgetVY?=
 =?us-ascii?Q?GMlJvdSL6C85MkmtPkdbJufzcei7+anjNabzbkwpSykvHJ2WhKY/uWLcxMZo?=
 =?us-ascii?Q?cueZFLsHeGbKjXoPAHIEQNT6olyRlcGOav3gA0uDe4Dz86KAuyj8Xd1MErI6?=
 =?us-ascii?Q?TDWbnOCdTuXyJXlRzojQZr5dEiZr2YdWzNxob0dNA7tL8N+q4mMjy7pQm0E2?=
 =?us-ascii?Q?At7OiU1/IygdwFPg1f7dP0ZZLA7wWWuEcJUGMkRkTYeJs8UAB9YvWZ4YsJMt?=
 =?us-ascii?Q?z4WBKwlwLHAsp3IrYqBTfiNhpWbMhVqL/lMxTJLmfXK3GxXpuB+QNJwxw1gH?=
 =?us-ascii?Q?4VWHso/ATwr/y7Kx/1ffRRk3MHBTdAbFvBZLfFIWShYrSYEpfVDufLyFll/Q?=
 =?us-ascii?Q?yPHBJxXUFpl/44vtZ8ag45fpve3LbKcKgXKbv3dBGs7BMOJidEJGt7KyhJaP?=
 =?us-ascii?Q?dfN+qtZ2Dpa1PRTbZd40p84gXNiJS9PuiVzgePsKA5mqPd/4DG5XsjyxY9zo?=
 =?us-ascii?Q?gdTLm1pHisd6YDyo1kgNM7L5ZyxYxfVMwdfLBYa89N30WM2eYFMwxED4BDG7?=
 =?us-ascii?Q?O0yKBZAJyjtpVSMUo8j9cM3yxfnlpWxUlqZzVzrQJmwL61Pejy0xV3fyqs+u?=
 =?us-ascii?Q?3bSDC74IrW537CV1uzWLjaXEtGKRXiO85dyACgoeLRw35FOpgeWgSv/JBTDa?=
 =?us-ascii?Q?VWMqeFxClx8SW9+gSH2uQ1Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57a52971-f96f-4f5a-b8e5-08d9b574ca47
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 09:19:06.5486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ro9Xe79QDgP8IcoOaxwV5mklJk7Wyrpxw19edDDePmPFwbvgIhFDhCPqvjUD+S9Qmen/WI/jmq6SFhxdHrNWhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 01.12.2021 15:39, Andrew Cooper wrote:
> On 01/12/2021 09:40, Jan Beulich wrote:
>> The actual function should always have lived in core x86 code; move it
>> there, replacing get_cache_line_size() by readily available (except very
>> early during boot; see the code comment) data.
>>
>> Drop the respective IOMMU hook, (re)introducing a respective boolean
>> instead. Replace a true and an almost open-coding instance of
>> iommu_sync_cache().
>=20
> Coherency (or not) is a per-IOMMU property, not a global platform
> property.=C2=A0 iGPU IOMMUs are very different to those the uncore, and
> there's no reason to presume that IOMMUs in the PCH would have the same
> properties as those in the uncore.
>=20
> Given how expensive sync_cache() is, we cannot afford to be using it for
> coherent IOMMUs in a mixed system.
>=20
> This wants to be a boolean in arch_iommu.

That's a valid consideration, but may not be as easy as it may seem on
the surface. Certainly not something I could promise to find time for
soon. And definitely separate from the specific change here.

>> ---
>> Placing the function next to flush_area_local() exposes a curious
>> asymmetry between the SFENCE placements: sync_cache() has it after the
>> flush, while flush_area_local() has it before it. I think the latter one
>> is misplaced.
>=20
> Wow this is a mess.
>=20
> First and foremost, AMD state that on pre-CLFLUSHOPT parts, CLFLUSH is
> unordered with ~anything (including SFENCE), and need bounding with
> MFENCE on both sides.=C2=A0 We definitely aren't doing this correctly rig=
ht now.
>=20
>=20
> AMD explicitly states that SFENCE drains the store and WC buffers (i.e.
> make stuff instantaneously globally visible).=C2=A0 Intel does not, and
> merely guarantees ordering.
>=20
> A leading SFENCE would only make sense if there were WC concerns, but
> both manuals say that the memory type doesn't matter, so I can't see a
> justification for it.
>=20
> What does matter, from the IOMMU's point of view, is that the line has
> been written back (or evicted on pre-CLWB parts) before the IOTLB
> invalidation occurs.=C2=A0 The invalidation will be a write to a differen=
t
> address, which is why the trailing SFENCE is necessary, as CLFLUSHOPT
> isn't ordered with respect to unaliasing writes.

IOW for the purposes of this change all is correct, and everything else
will require taking care of separately.

> On a more minor note, both Intel and AMD say that CLFLUSH* are permitted
> to target an execute-only code segment, so we need a fix in
> hvmemul_cache_op()'s use of hvmemul_virtual_to_linear(...,
> hvm_access_read, ...) which will currently #GP in this case.

Hmm, this specific case would seem to require to simply use hvm_access_none
(like hvmemul_tlb_op() already does), except for CLWB.

But then hvm_vcpu_virtual_to_linear() also doesn't look to handle
hvm_access_insn_fetch correctly for data segments. Changing of which would
in turn require to first audit all use sites, to make sure we don't break
anything.

I'll see about doing both.

>> --- a/xen/arch/x86/flushtlb.c
>> +++ b/xen/arch/x86/flushtlb.c
>> @@ -11,6 +11,7 @@
>>  #include <xen/sched.h>
>>  #include <xen/smp.h>
>>  #include <xen/softirq.h>
>> +#include <asm/cache.h>
>>  #include <asm/flushtlb.h>
>>  #include <asm/invpcid.h>
>>  #include <asm/nops.h>
>> @@ -265,6 +266,57 @@ unsigned int flush_area_local(const void
>>      return flags;
>>  }
>> =20
>> +void sync_cache(const void *addr, unsigned int size)
>=20
> Can we name this cache_writeback()?=C2=A0 sync is very generic, and it re=
ally
> doesn't want confusing cache_flush().

Oh, sure, can do. As long as you don't insist on also changing
iommu_sync_cache(): While purely mechanical, this would bloat the
patch by quite a bit.

Bottom line: This last item is the only change to the actual patch;
everything else will require further work yielding separate patches.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:36:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:36:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236414.410093 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msiW3-0007ZR-NQ; Thu, 02 Dec 2021 09:36:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236414.410093; Thu, 02 Dec 2021 09:36:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msiW3-0007ZK-KG; Thu, 02 Dec 2021 09:36:35 +0000
Received: by outflank-mailman (input) for mailman id 236414;
 Thu, 02 Dec 2021 09:36:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msiW2-0007ZA-8p; Thu, 02 Dec 2021 09:36:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msiW2-00063S-0N; Thu, 02 Dec 2021 09:36:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msiW1-0003OX-Fw; Thu, 02 Dec 2021 09:36:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msiW1-0002Ss-FP; Thu, 02 Dec 2021 09:36:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ate0LAtCYTtp11jzcfmafeVN6pgEk7pl+m6jxKxmdPs=; b=ak0b+el5rlotJwj0XdWPxl7Zcp
	h6l+ZAd5zF186Tky6wQwbWcLJAPHk3uwcZTLQ7/1qmDoW28sjAf5aLBgqxnuGVVLir3CjGFETAG0q
	Gh0mdNnId6LKTVfH5u+IVMsQKXIV29BkHpbU9B++AeKr4n42i6c1ZDA52o1lB9fA7Dv8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166978-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 166978: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-thunderx:guest-start:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start.2:fail:regression
    qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-destroy:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:heisenbug
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-destroy:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=682aa69b1f4dd5f2905a94066fa4c853adc33251
X-Osstest-Versions-That:
    qemuu=50456a6794fbb8dc94a31eb9534e91c586da7add
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 09:36:33 +0000

flight 166978 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166978/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-thunderx 14 guest-start              fail REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl          22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-intel 23 guest-start.2       fail REGR. vs. 166954
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt-xsm 22 guest-destroy  fail in 166968 REGR. vs. 166954
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166968 REGR. vs. 166954
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 166968 REGR. vs. 166954

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 25 guest-start/debian fail in 166968 pass in 166978
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup fail in 166968 pass in 166978
 test-armhf-armhf-libvirt-raw  8 xen-boot         fail in 166968 pass in 166978
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 166968 pass in 166978
 test-armhf-armhf-xl          14 guest-start      fail in 166968 pass in 166978
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 166968 pass in 166978
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 22 guest-destroy fail in 166968 pass in 166978
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166968 pass in 166978
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166968 pass in 166978
 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail pass in 166968
 test-armhf-armhf-xl-credit2   8 xen-boot                   fail pass in 166968
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat  fail pass in 166968
 test-amd64-amd64-xl          22 guest-start/debian.repeat  fail pass in 166968
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat  fail pass in 166968
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 166968
 test-arm64-arm64-xl          18 guest-start/debian.repeat  fail pass in 166968
 test-amd64-i386-xl-xsm       22 guest-start/debian.repeat  fail pass in 166968
 test-armhf-armhf-xl-multivcpu 14 guest-start               fail pass in 166968
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166968
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166968
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat  fail pass in 166968
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 166968
 test-armhf-armhf-xl-vhd      17 guest-start/debian.repeat  fail pass in 166968

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 166968 REGR. vs. 166954

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 166968 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 166968 never pass
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 166968 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 166968 never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 166968 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 166968 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166954
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166954
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166954
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166954
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166954
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166954
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                682aa69b1f4dd5f2905a94066fa4c853adc33251
baseline version:
 qemuu                50456a6794fbb8dc94a31eb9534e91c586da7add

Last test of basis   166954  2021-11-30 08:39:11 Z    2 days
Testing same since   166968  2021-12-01 06:37:45 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eduardo Habkost <ehabkost@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 682aa69b1f4dd5f2905a94066fa4c853adc33251
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Wed Dec 1 07:20:06 2021 +0100

    Update version for v6.2.0-rc3 release
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit 24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac
Author: Eduardo Habkost <ehabkost@redhat.com>
Date:   Tue Nov 30 15:47:22 2021 -0500

    MAINTAINERS: Change my email address
    
    The ehabkost@redhat.com email address will stop working on
    2021-12-01, change it to my personal email address.
    
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211129163053.2506734-1-ehabkost@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211130204722.2732997-2-ehabkost@redhat.com>
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:42:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:42:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236421.410106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msibA-0000iV-Dk; Thu, 02 Dec 2021 09:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236421.410106; Thu, 02 Dec 2021 09:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msibA-0000iO-Ah; Thu, 02 Dec 2021 09:41:52 +0000
Received: by outflank-mailman (input) for mailman id 236421;
 Thu, 02 Dec 2021 09:41:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msib8-0000iH-RH
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 09:41:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12440cee-5354-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 10:41:49 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-2B1jmPrHP0-VaDE8M8acMA-1; Thu, 02 Dec 2021 10:41:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 09:41:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 09:41:46 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:206:1::47) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Thu, 2 Dec 2021 09:41:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12440cee-5354-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638438109;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F0GA+SE+/orjDIFzmL+tGdrHslcpuX3lZl1u8VjVjJQ=;
	b=LL4Rwaz010gLGuXmt23j0a36UbP0QoDwHAZJKB6yruDlTYqDoof6+2pCg2eB+R7oom/dOA
	CAnb4oYphjUWGLapmMWZ7JWCeLE6Vb9LQoaJXZo65mfw1rpnV6ajWj6d1O01t/KPVenZLG
	baTZr0Sl3d1ppWTHxg58GvonSDa18U4=
X-MC-Unique: 2B1jmPrHP0-VaDE8M8acMA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=g8wHwbO3Fs7+e9CDIEFMKNHfgX82dJC4T91TifT5ZuiOWfD/p334NWzMSy8NQJT/JDb4JgR8dg4WhAtIIyiLzOQ2sjYhH9xY3yGGaWowcIQCfSZT3UW/PHAuXykWxM8VL3JRE/MsFX7YxEawUSvMGkUmRjo7OL4Wc5MUrspfxGSiWQNtM/uKFwA6Yt1LWVdgfFVuMv+BIAunwaBYjx94gGm3O3QDB6wmQNzacndDyCB0meciMfiYkeYVoObR7cJXEpeHJDh+NGhhcY5qdHGfMEveMvwOuXuVvgUH3/+TLtPvMO2CwvgrtkejIeTPgOCqILwc3Jh40TILbrwxec0cDw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2R3sudreNdJ1CRCEM4LtYEAY0UF7HPfrH7cE3Ck778k=;
 b=i0Vj3m288y2pA73fy9/pmYcOtq/zVB8/7kiXqwxqY9WKVJllSZ824QLmK/xf09swC8zU7Kpwp15/KLlf3JNs64lF64dFeLhXPzYOgoEmIVyrbAGWX8KKbUQJRsukWFsSvDWS1EnxSN+J2j/s49tOIknM9FCUoDIgYkTJ9RVGtmXz8VvndLPU8f15zVeKfx2aDxzIMqetpdenifXToNpyEi/nCX/4a6uJp4Jg1+LEv98rqxkgQZNAf5Cdi8+m37tTPxVjytcprU+bm3o2Guq5cfds1VDE119jZDy84bleSou0UTwPi8MKJsh7M1M7HgYXsI5S+s7Y55QlB/gAq5bD+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cffba3b0-7efb-ac58-725a-8465a5a7d84f@suse.com>
Date: Thu, 2 Dec 2021 10:41:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/4] x86/PoD: simplify / improve p2m_pod_cache_add()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
 <2525b63f-f666-2430-2c22-b1b7b0d5d7f0@suse.com>
 <66d9ffb0-a3c8-c8a8-18e6-9fc649ca2eff@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <66d9ffb0-a3c8-c8a8-18e6-9fc649ca2eff@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR04CA0034.eurprd04.prod.outlook.com
 (2603:10a6:206:1::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49762aa7-3618-4512-8d8c-08d9b577f4b3
X-MS-TrafficTypeDiagnostic: VI1PR04MB5166:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5166BA0CEF871D3041398E1BB3699@VI1PR04MB5166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	baAndcZ7sGUDcTXIUrzf+U+NdJCAE64XPuvNqg6hCe4eNShCVi6gX4ZpAfrKPRJ+HUgMhZCUJfhWXx7l3wcCwkNVdLWD+rFqHH8VzwiA3Y69ETMLR39e69kNcOKBe7IR+Vr5hmqvd/giXAA6Su1gBIFSW6HtTb+/ng93NVZSJNNK7yppW8+SOWF0piuLTlOQegH7LSbrp7CL3xKIycUqrdbJjtL6YtN66kUQFRQc6nEiLmm04YPpB31t0xhx7hp2wVArj+pMaDtQ8MjX36pfnYlvrI//E8hMCel1SrhjrQMFIg1AzctMyOoEjk73vR79tLR8uPXq0rlOwMe/LZaRVS/4T4DzmUG3XzJBr/qi1pjpqFanXPOjMs+wyNnOoX9kBroH0IsOoj5Tb2pzd60yeN8emdLGg5wXn333nnLylo4KA4Bii1bXJq4kzqzVji2RTF8eBWpaeRpfDltYhAYz3M8vgnUdXUIKeBHXTW1a9t9Pl98FjElg9Z1C3SCRmAFe+3g5B7BnB2RGBd3LsCdQVXxn5UNpU93s3m6rJYg4Cjlt90Fb2CnKebwIl+DmvgFj0nvo8uLexsynZ64IGAzSnVoo/co30pPC52wvSPB9vvOh13efM+ji8zcnPIcelGiWAqDmYpmN8P81oeLaZF9aIYEj2AQWVQsVNI37ug/HZepyoWjKlJaId8oFGgdXRGLNSdA/nEhXB1J0bJ+sksLs3OzBWAPkcUzsUfw3qWkuwnA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(26005)(16576012)(54906003)(316002)(86362001)(38100700002)(31696002)(31686004)(4326008)(2616005)(36756003)(956004)(508600001)(8676002)(66476007)(6916009)(6486002)(2906002)(53546011)(8936002)(66556008)(5660300002)(66946007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8cwVZaeVQhJixyRJ9PIc+dKM3rPCfKcH90SQ7ujIUG76Yp78btAE6jts8R3Q?=
 =?us-ascii?Q?P85S6ndoyNWFGAYwcDkPSlpG02ut8VninC4r227wRTQ3FRJTvYn6dMvrirzV?=
 =?us-ascii?Q?pbvKfJ0sK4rmncuw8iDzyfXUyHR7RcyFQVbqwBMJF3Nnr8bXfA6HfaiOHjBQ?=
 =?us-ascii?Q?8KeGLYqbTBtrr1l3xF06eOQpgL7DkFkpxt1425WYZmADnp9EtwFbe9TUAZtE?=
 =?us-ascii?Q?gsErVpKZq3pcq6irvM9sH96um9mR7LUDtLtI2s9sLqiaBgArKMDGBXqpZMCR?=
 =?us-ascii?Q?oLckmkqHfltS0mp5iuhF8sF/T6ZaPeJd1Tw1biELcvm4g8lARF3XeDlTzFv7?=
 =?us-ascii?Q?2of8192WOj0Yu39WWXPNRp7sykK0yx3Z4zIMtObPBzQsYsNlSNE9MLFn2Hed?=
 =?us-ascii?Q?UifojVpZ1IVSjYX/eBW4H5IB2y27DJjzo20Hmdf0w6JeahsRWxZmJKEfV9ZD?=
 =?us-ascii?Q?vpwk7qUVS1TSvQY3w0p76jhVt4B41zY5bGn24F9/7tyFHI/Z/zSrr/BqSNV9?=
 =?us-ascii?Q?Czr3uQUfxGXqpmbhEgPRkuMtezN2kJmePRJR80B+kiwnKE6fz3adSTT12hcH?=
 =?us-ascii?Q?qiqemUMINQD2HIz4XFS/O1QwNgrGD4RqG3yiuWnM+YaiekAb2RuvpsZsukZa?=
 =?us-ascii?Q?AsVqa+FvYuS+uL5KXLHEgDMPeMksuYAbGIN1FGprx80cOqfibP6rsRf0H4Ww?=
 =?us-ascii?Q?OseaM+loqwqzbwU5Rv5ginarMMLGisNd1m9T5H0AolnCGrRCimcljyg2hTNz?=
 =?us-ascii?Q?Xw0Ccg0uSfufUJqgAwsasFQhiTQ+bare+xrYZ5n1j0Uhw4au+316mxbMY4X/?=
 =?us-ascii?Q?KpLBlVm+bR5uOgmZs94P50J3qUEKci6CQMFEN8kYiHQGVlrz36r5DCUdQcNB?=
 =?us-ascii?Q?RBAJkY32OBwHO1a5uv5hkL4yol50+vAzcptu8LMlPzsp5szp/0cAUb6FNvuo?=
 =?us-ascii?Q?2Y4BsREGo7OqFsjo+6t0O+ODwBJmm68sW3gtShTmWLsEw7tVA3T0Bn3hVxTx?=
 =?us-ascii?Q?K5UYeYKb9xMWBRcJkVSwXdxh0diR34d+H92cOXkR//I0Dq165Jpzzfydr7VG?=
 =?us-ascii?Q?8x1bWcZ7Sfk0xJfJXLqReq02P1+cdEqY+9g1hH8WCMJw6z7sXy/dM1WA3iCi?=
 =?us-ascii?Q?lDonNn/zBU3ZCT7fnLyAmCfWIGs9Z3w/HVuoXncJKhWxVW7S6BiESO2a0jbl?=
 =?us-ascii?Q?dAFd7Rxb/Fo6/Z8iKu9V2jmx7WxBRM9U6e1FkOhDHl62Xs08jP2ayiYYVJGk?=
 =?us-ascii?Q?M25lrXdT6yJCVanYe+BDQ5XTU3vVX2UMrbSKTW7RI9g9/TfqKqcd+CX4PBgA?=
 =?us-ascii?Q?InQpn9x4UiXTV7rw3TiALgykSLVJte0LZ3C7UTCqgBFyL7Zbbv3mQsMTK1u1?=
 =?us-ascii?Q?WE7/Y/nQzyuJ0qTylEXJ5uhuUN938f1pnnAelJQVz7H2xdK+cYjfx8WdsS2T?=
 =?us-ascii?Q?JahBdKBACi+hFuxx3xHfyQMi1J5CGYKxu4XZ4+1/rrq/VEKCzPaYMu5G2lIU?=
 =?us-ascii?Q?2+l1OEGmQlIdI6gkO13ZsC70vrPc9XL99PRiKN6bN1IT/mjBxtKfD7JG0ZeN?=
 =?us-ascii?Q?neqnb8m5D1AhtRLx8jxhcs2IT8pFdchScGaKGLZllfabbxd7ib2hYejYqRsr?=
 =?us-ascii?Q?MsD717S0sWrdyLyTreGoRIk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49762aa7-3618-4512-8d8c-08d9b577f4b3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 09:41:46.2018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i+h0i8nJc88+Kc6F4xpJlfGgUT9r+NZAsSKQ00tXpJBdhvP/GgAbEvy8Az/ws3BIOLItDn8Up9dc9B2/H12sFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166

On 01.12.2021 13:01, Andrew Cooper wrote:
> On 01/12/2021 10:53, Jan Beulich wrote:
>> --- a/xen/arch/x86/mm/p2m-pod.c
>> +++ b/xen/arch/x86/mm/p2m-pod.c
>> @@ -58,14 +58,10 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>>                    unsigned int order)
>>  {
>>      unsigned long i;
>> -    struct page_info *p;
>>      struct domain *d =3D p2m->domain;
>> +    mfn_t mfn =3D page_to_mfn(page);
>> =20
>>  #ifndef NDEBUG
>> -    mfn_t mfn;
>> -
>> -    mfn =3D page_to_mfn(page);
>> -
>>      /* Check to make sure this is a contiguous region */
>>      if ( mfn_x(mfn) & ((1UL << order) - 1) )
>>      {
>> @@ -74,17 +70,14 @@ p2m_pod_cache_add(struct p2m_domain *p2m
>>          return -1;
>>      }
>> =20
>> -    for ( i =3D 0; i < 1UL << order ; i++)
>> +    for ( i =3D 0; i < (1UL << order); i++)
>>      {
>> -        struct domain * od;
>> +        const struct domain *od =3D page_get_owner(page + i);
>> =20
>> -        p =3D mfn_to_page(mfn_add(mfn, i));
>> -        od =3D page_get_owner(p);
>>          if ( od !=3D d )
>>          {
>> -            printk("%s: mfn %lx expected owner d%d, got owner d%d!\n",
>> -                   __func__, mfn_x(mfn), d->domain_id,
>> -                   od ? od->domain_id : -1);
>> +            printk("%s: mfn %lx owner: expected %pd, got %pd!\n",
>> +                   __func__, mfn_x(mfn) + i, d, od);
>=20
> Take the opportunity to drop the superfluous punctuation?

Fine with me; means just the exclamation mark though, unless you tell
me what else you would see sensibly dropped. I'd certainly prefer to
keep both colons (the latter of which I'm actually adding here).

> Looking through this code, no callers check for any errors, and the only
> failure paths are in a debug region.=C2=A0 The function really ought to
> become void, or at the very least, switch to -EINVAL to avoid aliasing
> -EPERM.

I'd be okay making this change (I may prefer to avoid EINVAL if I can
find a better match), but I wouldn't want to switch the function to
void - callers would better care about the return value.

> Furthermore, in all(?) cases that it fails, we'll leak the domain
> allocated page, which at the very best means the VM is going to hit
> memory limit problems.=C2=A0 i.e. nothing good can come.
>=20
> Both failures are internal memory handling errors in Xen, so the least
> invasive option is probably to switch to ASSERT() (for the alignment
> check), and ASSERT_UNREACHABLE() here.=C2=A0 That also addresses the issu=
e
> that these printk()'s aren't ratelimited, and used within several loops.

Doing this right here, otoh, feels like going too far with a single
change. That's not the least because I would question the value of
doing these checks in debug builds only or tying them to NDEBUG
rather than CONFIG_DEBUG. After all the alignment check could have
triggered prior to the XSA-388 fixes.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 09:55:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 09:55:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236431.410123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msioI-0002SU-Lz; Thu, 02 Dec 2021 09:55:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236431.410123; Thu, 02 Dec 2021 09:55:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msioI-0002SN-J1; Thu, 02 Dec 2021 09:55:26 +0000
Received: by outflank-mailman (input) for mailman id 236431;
 Thu, 02 Dec 2021 09:55:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msioH-0002SH-7q
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 09:55:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f79b299f-5355-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 10:55:23 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-HI3eN7vsO8a_3i7p81hHHQ-1; Thu, 02 Dec 2021 10:55:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 09:55:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 09:55:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0042.eurprd04.prod.outlook.com (2603:10a6:20b:f0::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Thu, 2 Dec 2021 09:55:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f79b299f-5355-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638438923;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vHB8ehy+7ikkB/mv8cYbHNKybPgmR1yQA7IgGUjzJ+s=;
	b=ejHxBST9ELDTse0dVilGLEI8JwL59cct7fzI8SIeVd713NGeXsHvrC3jQWehkIOdw2PW0V
	uf0+W34zoyGyyu1FTvFRP+8Fc1xW5gV2fDWWlOdxQ3nLQF0CITamimNQRFQz1cBCqcKRE0
	QzzCUXZ7aZI2CXKEdC1bNSOhQvv1/7M=
X-MC-Unique: HI3eN7vsO8a_3i7p81hHHQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hTsCB0WPvki4EZhK564qstSSRFzsuvm4cgTHkHVzG1a1ole88iCPHR1O8rzSt71QKbO55Cy1RuqnUkKzBymkpBfmrH2qEjEynTHpPvnH4VIdRlwmLuh3UKEAqHgK6GQ1++WogOTseCWxogBS/fGT71DA88hLkGUVbClPm5KQvsTFQubc50MiiX0+DQ6jB9RZlGggzHteg4y1U/PWFq9qFtUx5L/jJq5CmfVbhok4PKMAx+Vaa+gruwtHSKRvyd8EjUYwHDLIdoeYnBMYMQKMdn1rWcxwoZxUBoF8Xv2jveyw5oZL09HO80hfMZ3sVLkmz9bkvl+Twdx/6c2YgG5lnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qS13c7112W8LQjv6N90bO86hzLmviVvmGeT7WYs0FmI=;
 b=MOEx4HIFd/TQOnKrfn7uGfwt0NUQaCjGJa4azVD3NF6TggiEBfE1lFTYNZzeCGfFGLbpP6xQvI7J6h/Q3pkq0t30/ONOKJC2pcmb62aKHAOeRwkDOPtckyyLtXbhj791tGv4RXfyVhJehKGDxHk+upjBSzGyoQHGBzg4wnws6QrQMw/o9fla6fxwI6aSCFsch5xCJOnQAOv9D4M8xdAWVrDE+9tPTS9BY/yvErpWRClrRcG23YurBboKclG8V7oymtZzGr3e7VSeZivhkBcmk99i4kE6QItfHErKQSdToUe5g5MaIIxMbSY0d3WyDXkNNgLwuuhnnSZppcV4TpWT5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <de69401c-309e-ed71-ed7b-69842e395adc@suse.com>
Date: Thu, 2 Dec 2021 10:55:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 3/4] x86/altp2m: p2m_altp2m_get_or_propagate() should
 honor present page order
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <21148e89-4750-3112-1096-36119be96c7e@suse.com>
 <09aaf19a-b03e-7f41-208e-bfc6bb968049@suse.com>
 <420124f7-634d-8d9d-9cbe-34ed6a66d80f@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <420124f7-634d-8d9d-9cbe-34ed6a66d80f@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0042.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 55b31d56-ca3c-43cd-7a1f-08d9b579d9f6
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB574314394005EA3AB5AFE186B3699@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+CvC2M1E5vUh2Z+YLC0shDmFRkrwj4lIowv0JlW/IiiGuYcXvu0JTBwTSS+nG7sBDySnOxXoUO8GHtyeRtp3mbayoS7YYEfn7WSc3Rhul7c7l4TO1dzMaWzaZPB7kXM/otoDHBhMHZ4iUZ6T7l7mizMpa99r3ioKFEcF3844wgQgCeAiCtdr9/4JPnm7ip1+vUp0lb/39vajqIlynpsKWeEdBFrOyhsiynSt0etxR3K6l8KoMh/79oOhjNVWULjveMYX7cujDch9YsFB3T518KpebFXNS6oZXjIq/cXMGMpn7Zdf/Y8aCrPrtjxp3rWmFsM46mUDNghYnAPbq83sLhTYxIz7lnVkivnV2Fpt/PkOk0CGrH0plFiNGLCxb3XkGvtNrdu6VqpKw74Fgox1CP1mlDWpmPDDFzKc22LtEG4/SdpsLjgnbpP3pzdnGoWCU46fuTwa1Kn6Q5G7A2orGso03IH2lFsPoVPckiRZt6oG68i8gGAdIM+8haH6nWts84GgfmNpBEhe28+GeLxzie/M6QDNeaxin/6jP2hV8V1V4kgNl0i/AV2qPiwfT7BDdqH7PmUiVodRbjx2+BRXz6dyUeI/1YFmYJmD8hSLS8nO/wlNBTxZJu3ocW49J5K6Xo0OwHuhlGFp/ZpM70b6ePjxv/bRbgUNVIyw5eo6XJzO0ZllASyF+eJWcW81hVLf7vzyfhe788xV+F347CEHSg09oyCQ+HfJNRstoND0o1o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(186003)(508600001)(8936002)(6916009)(66476007)(66556008)(31696002)(38100700002)(66946007)(53546011)(4326008)(6486002)(5660300002)(16576012)(316002)(83380400001)(54906003)(36756003)(8676002)(86362001)(2906002)(956004)(2616005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jMfMaWzyisp8ljISJGZHCcxHrdxCHV4G3sUsujzuily4eiOpeM8q2sjivF7x?=
 =?us-ascii?Q?iPf8oMTy0rjNP2j8CE2SFytxXOze4abG9N1sIBDhJEtFyzLKzk2ItMzYPfXX?=
 =?us-ascii?Q?8TEa2/yhV+6/3+bTDPMJa0eD+tOMYicHwpI23OOMwUw9L8ZAwQOsJnNTspdo?=
 =?us-ascii?Q?0cmzOvuvSoAFeS+r1HBZeS2It4/nlhFNdPlyq01Iy6xmPJ8zNUbvic95rbe8?=
 =?us-ascii?Q?QrGWDJskB7D4Q4Fp4udP0ImuOTFB6OfRtDZkBM8yeGfZdbxN10xA1sj219Zr?=
 =?us-ascii?Q?OA0Mmy/h08IbRSeA59ddx1utUBPTAMNn+O4RHczM9e8LSNljCmKkmI+FpQY2?=
 =?us-ascii?Q?Ehc3XDqiHSAHdCDIAy8bKHugmuUShpXciAO9bQEI3AQGPObrA4GGQkNr1vwJ?=
 =?us-ascii?Q?Lh+yc+xLXlPiFG/5Ses86MhsQhAsUHMbyvi2Isjs89GD91AwUN1avxEObAXw?=
 =?us-ascii?Q?B22KWDJU6bJNdyrpoMYFo9UE6l5lp8bkAr+7k0eq/UtjjajJFNsi1EU/LGFW?=
 =?us-ascii?Q?76ZNj1goXTWZ5XevxNhO6sHPxyvoB/4S7kKKlPx7MaU4u6rycS3HURfSFXXb?=
 =?us-ascii?Q?02Gavr9lNFDsn+176HW4TsWnrm0+vZTaZdOz+eKcdSsFYmmXuSWuDryuFtPG?=
 =?us-ascii?Q?K2AFYsWjilAj+jfi2M7WllLyjtRvBOG6FzjbheKGBQIsxI/Tm3eMYBvTXTEk?=
 =?us-ascii?Q?bQ9oUqjE/nfYGWjegqZhqFulfsGtT+fy/XdQdZyZZ0EawJfyOuLvGqkbcISY?=
 =?us-ascii?Q?+9XV2vevnAS53PA/jjkSctxTiErehEK1YF7UlR7nSGPKj4s+ElR+T5WQBoaL?=
 =?us-ascii?Q?xQODjV3L47XSecFIDLCgNe+lXVOydnlArg9bjW9GtwIUPYW4qt7zvF26VE29?=
 =?us-ascii?Q?h85xhDimkQf9Wifz7oJy+CHIyQUKU/Uc6CiKvbDiTkmX/PM9dfGweTCMJXMj?=
 =?us-ascii?Q?/pQfC88t6YO+fMIxqPIy0+M6WRtE0nWX8r0ByLiwp284nrdm2ZUmzQsiw6dN?=
 =?us-ascii?Q?AZoU+xkN9u+pMqxJF+mAeA6Sy6pIbvfs7s1SS/ijMvAWLATH4GqtE6V8VOyp?=
 =?us-ascii?Q?QCWWIF/++C/+ZDKOQ6cfLTnocHLsj8GvecbqTZYwjfBT3lkbmf7SW3zFWBLZ?=
 =?us-ascii?Q?1hVFQCUGZ63T5OaE7S41hQdTi02xUTldkU43qBG2oqqDefZlqI6grWcujE48?=
 =?us-ascii?Q?SIsIFEbUUnS7aazHGmpfsJ8RDt0/N0AM3auZ+Qf8r95GeUe/FQd7ejPs5MHe?=
 =?us-ascii?Q?PfUiS3nFHxllrop8q6kdrbB9JofezRMJWi/eSFQy0kmfM0qdY43LpM5U10ez?=
 =?us-ascii?Q?SVENN5JvO/daioM37hH5AEt96wmqjFsqmG0iruyNE8Mgv2IWQxv2wR5ptz4Z?=
 =?us-ascii?Q?Qf0NXrIh1tcimzwRJLzwe8zg38LRcr0EQdCI8DB8mcwKPJXhTIBI5Kg94Hrf?=
 =?us-ascii?Q?40ce46p5z4Zeh6P9vfbIdOBMxBZRXmaqU1opfnhh9prp4OK4Xk92g9SJFUa8?=
 =?us-ascii?Q?RICBt64oy//eK/cctN233wi7Ol6hZKV0FFCgIOLyJ4kDxAVdYt7RIthey9ji?=
 =?us-ascii?Q?lgZsIFILQFqtaKQTpMQsoso3io+PrjdXAhnyQNcUwHPEJZ9SpB3x/b/QcQPq?=
 =?us-ascii?Q?S906nNO9c/4iw3wdgFdFc88=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55b31d56-ca3c-43cd-7a1f-08d9b579d9f6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 09:55:20.4553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tUHV8qzfZchG7Daz3Q5Y7t01dXyf9IWUkUqVWbWTcPOwUZR7TAbPTyK9rIDVIlmBb+eL7l/jbAN8CDIWjN3K0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

On 01.12.2021 13:44, Andrew Cooper wrote:
> On 01/12/2021 10:54, Jan Beulich wrote:
>> @@ -2237,11 +2243,11 @@ bool p2m_altp2m_get_or_propagate(struct
>>       * to the start of the superpage.  NB that we repupose `amfn`
>>       * here.
>>       */
>> -    mask =3D ~((1UL << page_order) - 1);
>> +    mask =3D ~((1UL << cur_order) - 1);
>>      amfn =3D _mfn(mfn_x(*mfn) & mask);
>>      gfn =3D _gfn(gfn_l & mask);
>> =20
>> -    rc =3D p2m_set_entry(ap2m, gfn, amfn, page_order, *p2mt, *p2ma);
>> +    rc =3D p2m_set_entry(ap2m, gfn, amfn, cur_order, *p2mt, *p2ma);
>>      p2m_unlock(ap2m);
>=20
> While I agree with the problem you've identified, this function has some
> very broken return semantics.
>=20
> Logically, it is taking some hostp2m properties for gfn, and replacing
> them with ap2m properties for the same gfn.
>=20
>=20
> It cannot be correct to only update the caller state on the error
> paths.=C2=A0 At a minimum, the
>=20
> =C2=A0=C2=A0=C2=A0 if ( paged )
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p2m_mem_paging_populate(currd,=
 _gfn(gfn));
>=20
> path in the success case is wrong when we've adjusted gfn down.

I wonder which of the exit paths you consider to be "error" ones. The
first one returning "false" pretty clearly isn't, for example. And the
path returning "true" is after a p2m_set_entry(), which means (if that
one succeeded) that caller values are now in sync with the P2M and
hence doen't need updating afaics.

And anyway - how does what you say relate to the patch at hand? I don't
think you mean to request that I fix further problems elsewhere, right
here?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 10:13:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 10:13:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236439.410138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msj5M-0005AF-7u; Thu, 02 Dec 2021 10:13:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236439.410138; Thu, 02 Dec 2021 10:13:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msj5M-0005A8-4H; Thu, 02 Dec 2021 10:13:04 +0000
Received: by outflank-mailman (input) for mailman id 236439;
 Thu, 02 Dec 2021 10:13:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msj5K-0005A2-BD
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 10:13:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e117559-5358-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 11:13:01 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-u7kz9J7PP92-inCO1rwkmQ-1; Thu, 02 Dec 2021 11:12:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3935.eurprd04.prod.outlook.com (2603:10a6:803:1f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 10:12:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 10:12:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0045.eurprd02.prod.outlook.com (2603:10a6:20b:3a::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 10:12:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e117559-5358-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638439981;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hb6wXT7j+7j5WnsHGVg+Hd3o/WlwkCVs1TK7CN19H/4=;
	b=Lisn8zHbEgwLtGpVd1qYHi9/r+2ELlTfncwbZw1oaWX5m7h8wg/PPPg8bGoLlcNmKYFOdb
	Ydg2KhKdCmYw2MQClBFJi3oUI93xiZ/bPu3NMozYZh13qpzfbb/pk7xjlETVGpr9rK/GQr
	3QkNsNmPothPvT8ABiwgTu65ZQnMNuE=
X-MC-Unique: u7kz9J7PP92-inCO1rwkmQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PVct31ihfcaaiQr50VgN2WGFe1QTLBdhf9ZXuz9eT6pa2eVxvb18HM+680Px6czdJ3umF7Kk71XJk/hzX+5ol6tU1c7lpLSu1VB64L2ygZseRprBbTchwWpBGzSXoNhnsQsMNEXv8NOQmQ0YKWykr6coxH9QklC7dY22/Wg2/08vwCWcL3LANUGkZQvqFKDWETTH6uW6WH7wGclKsWMbnJZ7xRNIhVa/zrsyM+wze6/6NIv7xtsj/f6fhCaD2r5NqTW4T2cqvXI9IGNf/f0u7p7gqL31jR8o5pz3DblbcaC79R0OXufPiHnqbvuaQkIYRiognI/Erfo2cu6Kc+hGCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hb6wXT7j+7j5WnsHGVg+Hd3o/WlwkCVs1TK7CN19H/4=;
 b=iGZcbnBwUy+bnGIUHX7rIIrp09XouVVK6LBZB0f9wfMN1H0GFdNAL0n0Ryqv/MIR61pewSdF17tbdaHe09FlawnW5tu2oHbRicgmOoHpf3JyoWXG9NrthwCPzrMcBToUA/ZDPL4JqAJasIVZy/QLWQbjvcru8eHpbO+/f2K+WLKp0VogoB1fqJpfDg+MoZODgNNVPYCDk2zll+LxeulW/9fQuUMDbj04tdr9wMqzORYJZulTcSm6SJgpuRpyY4wNomOpguzXCc6kXxdC4XShlC9SwvGiQsXg2DT9EFjsnZayxwWMy40SJZLhWROTHhyRvfH36jXNlf9DrzmRhXFC2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <09847780-10b4-5b14-b15f-d82597fa8b3e@suse.com>
Date: Thu, 2 Dec 2021 11:12:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from
 gnttab_map_frame()
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
 <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0045.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 22a532ac-09bb-4b8d-979a-08d9b57c5046
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3935:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393588E6133A7DC183D87031B3699@VI1PR0402MB3935.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LP2spPJ83IgQFW5TSxd3rWVobmwDNWFz3BrMbnvl70qZpRyWGsbftQ4BZ6LTeZsUd5sWz+vm7152pxYOZVs1DqfRXQgMunUSYXMp+UfWjTq5cbAwMnaI0eIRlVTqwdArz/mVH2R05q2vIzSlHTLx6ZIrvNCPQrT35XwuhttjEuKmt/NeD2t+oPb4o43nL8ztzdp7Nr3kaqf1z2/zO4QGxwhMEEOhmic/JOwOw8kFeq2N/WKlF6Nc5lBoTz7rcF0VeshQli2+2gQR5xXiXrPOzqvPj53un2kRux7qFwHeHC7TFPM4usSTOKkH+zFEV+W3GPrXy3ktYkRHlwFaBRsuqmKle1kW5FnnwNGaL0jTi7eVFi3hi1ihaHyCQRvdUToYN1qFREDksdXQDW3jT9zmCu67JDF5faEXPLBkxA6tZx8wVmrpPOD4KTg39H9q0cMhNd3uJpoqP10L/C62XWuZT9mWMVwUKbsXBSKFswlm6RafR89i42WZbdi1HI2RrE5iSEnv25IZW2dlQXLVRwKljrHUwPuAoyfzTmSljn1IuZyYAMQdhmMGwrmMzi/CHjrfTKROFo6LawkCcMULbfC1Yhh2B9SW6FDI6CRaQbBLgNv6DpbiSRQayRBDTB33+joZkmqtccWOpxezPB3+PC2knIPW5Lu9TN+T2/V56kGEvwZ7VeNCcmZ8XNPg7gHK4zN+d8ch5gqpx1Tslu+epttPDTvjOUIpRFMEdf4JmKqXxto=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(36756003)(956004)(6916009)(26005)(31686004)(508600001)(66946007)(66556008)(4326008)(8676002)(8936002)(86362001)(53546011)(31696002)(2906002)(38100700002)(5660300002)(186003)(66476007)(54906003)(16576012)(316002)(83380400001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFpzbTRwd01hYWdZUG9wakpoRm55T3RlS2ZZYUdrQmVRNDFRU3dpK3hZak5J?=
 =?utf-8?B?elh3ek9NSlhCNzJoaXFrT3FaV0dHVlhLWmxNZjh4WDBoNlAyWll0S05IWjNu?=
 =?utf-8?B?NTR6MFhoQ3QrM3RpR3M4TWI0SUFNTkxFQzNsNFJLVnJPUExoem9LWnNuLzdP?=
 =?utf-8?B?eWFSY2RWdkZ4R3hUbkIweEZkbXV5T205UmpHbmhHZ1N3anJYSlEzbzJCVC9r?=
 =?utf-8?B?QnJxMDlUMUtKVGNHUTlRWlJvZkluUVhYNzdDMHA2eklDL1VLYkJBV0YvZEZB?=
 =?utf-8?B?RjBvRDFoTFNuVVF0ZUZEWTEzbXhVREpUOUpBMjdBdVlRTUEwcmk3cW5aNGhI?=
 =?utf-8?B?Ni9QYjFCWDFWVUN5RFdxazc5R2RFYndhN25Fa0piVVVKWHVCVHBHL2FBUGFh?=
 =?utf-8?B?cGk1dnNCMkZpQys2VTErU3M3cmgvSzAzTEhWVnM2allpeVFhK3hDNVlRUFor?=
 =?utf-8?B?SFZsRC93b1JLRU00b2R1a2d5NTBqQU5yQ0xka042UUdQVkJ5ZGdpZDFNM2lD?=
 =?utf-8?B?Y255VTlEcTc4QU9DbjJiM1ZKOGVNbEs3R0tOUGdYaDdudzQ4OXUvTWVNS2w3?=
 =?utf-8?B?RTI2Nmo0WUFJVTRrL2hvWE1sbGdLaWR3RUEzbjl1aHRFaUp6M0ZPQ3J3Rmts?=
 =?utf-8?B?YnBlNGRmbGkxZ0drTzg5aFRvelljUVAwc0FQeFJBdFhXR2FSSGxjVkJMVzA2?=
 =?utf-8?B?RTdUZEVIbzN1TDd2bitXT0ZncGc0eFJLZ0FLM2NlNEJhcW9uR3NacTQ3ajVz?=
 =?utf-8?B?TDBvc3c0Y3hVTGxlaUUvcVcrcW0zY1ZPbENBcWVkcUI4anVlRFVoK0IzQ1p3?=
 =?utf-8?B?dE50bmJOWC9SWXdlRmRrR1o0TE1VT3RXZzlzM0tmNGZld1RsOXgzemVxOEdQ?=
 =?utf-8?B?MzhVSmJyWStzY05OZ00zd2x3c0w3b2NIeUtaS3ZIOWZ1SXROWXBKMVNUeXhz?=
 =?utf-8?B?RWlHSXFRRjRmb0hYZ2ZqWUFIYThXWStrWXpCS3RxYldXMWhwNzlvZkowTjFk?=
 =?utf-8?B?ckFrY1VmTnlWaUtZc2lVeFBMRUpTR2VRKzZaaWp1WDNrTkZNMGFDVEozbGt1?=
 =?utf-8?B?VFZTZFkxZkR1bFcxWVJSZDN2Nll0R0pvd3E4dkdESjJLMHBZUEZURUgzQUF1?=
 =?utf-8?B?M1ExWDJTL251WDJ1cG1rUERjZ0pwQjI4eXlubUdpeFFmSWVQT2x1ZTV0cE43?=
 =?utf-8?B?QVhHTWFSdEFtTUIrb0F4YzZiWTY2ZzZUbFhQVGRQTkpEQWRHb3ZoVkJTVW40?=
 =?utf-8?B?UXFPenE0ZEZDUGpZQVRCcFRsWHQ3U1JXTitrNFB4OGkxYVFJTjMwcklPNTha?=
 =?utf-8?B?VFh4bnFvdTFrejlUbjJobUJkdHIwRHJJV1NBem1SNFM1b0tabGlFTVcxakNz?=
 =?utf-8?B?REVPa3pFZGpQY3JqaEVEYUpDQkZmeXAyL2FmeUZudlVaNit2Z05CVFJ3bVY5?=
 =?utf-8?B?Yk5qOFNvRkQ5SFJpNXN6RlhNZjBsTTRlSWZhZERaVUdvd1lCN2o5WThmc05O?=
 =?utf-8?B?U0FNVHJyUVZUT1p2Y1hHcHQ0ajFNVWN1WDdBdHlCWkw2WFRGUmlVT2NEc0xt?=
 =?utf-8?B?cXJ3OWNrOXl6Qk91ejV2UFZnVUpheWJiaG53ak9QNytIVEwvakpEa3RWM010?=
 =?utf-8?B?YXdGdDdkakVWQ0VGVUtINkNlb1o5OFhnTnJvTXhmeFpvcDIvUXN3OVhYWjEz?=
 =?utf-8?B?MkFnUVY3alR3alpaVUxTbFdEWncxbHdMSkJqR29MbzFZN3VLTFhzZllTOHBG?=
 =?utf-8?B?YjVZK0d6Y0FRdE5oT25FdjdVc1grVTNHRHFwMVR3c0RONHF6MWdCcks5cVMy?=
 =?utf-8?B?VnlHUU04VHZOd2NwNVJBQXd1R0IyWStjb0g2TW5zT3RIS1RETTErdDZpenZu?=
 =?utf-8?B?TTE2Q0d0UDh4UUdra1NVTTFXMGJycEJRazYra05ESm1xdlkvUlJ2Umt4T1d4?=
 =?utf-8?B?b2hIRnoxL0NmTzExK3hjMzJ6R2pQWmZhMTlRQlFtTXpyOGVSaHVXQnBJOUNM?=
 =?utf-8?B?VzZuN3lKOTdicGJTVWdYYXZkb1RMV0NBWFFlbWNWaSswc1Y3RExQTzlvdmlx?=
 =?utf-8?B?bm1RcEZoTVlvdW9yUlZocE00ZGpVYlA4OHRpUHlDOVE3NWtRS2JWdHM1U2pL?=
 =?utf-8?B?T0Q3aEFFOUVhWElJTE82YWZsRFl0Rk0weHVBeDEvR05hSi83NXgvWHFVRXVO?=
 =?utf-8?Q?i3GPvjd43aIMYZV/Bn4ecNg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22a532ac-09bb-4b8d-979a-08d9b57c5046
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 10:12:58.0559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IHdRf/0rI+k/PUOLMP/CjBf6EheaynGBvDqMqBq6k90SIFy8qMRIFuMs/dUN1rV4G5utgROq2uwNNJtWfT9Rhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3935

On 02.12.2021 10:09, Julien Grall wrote:
> Hi Jan,
> 
> On 13/09/2021 07:41, Jan Beulich wrote:
>> Without holding appropriate locks, attempting to remove a prior mapping
>> of the underlying page is pointless, as the same (or another) mapping
>> could be re-established by a parallel request on another vCPU. Move the
>> code to Arm's gnttab_set_frame_gfn(). Of course this new placement
>> doesn't improve things in any way as far as the security of grant status
>> frame mappings goes (see XSA-379). Proper locking would be needed here
>> to allow status frames to be mapped securely.
>>
>> In turn this then requires replacing the other use in
>> gnttab_unpopulate_status_frames(), which yet in turn requires adjusting
>> x86's gnttab_set_frame_gfn(). Note that with proper locking inside
>> guest_physmap_remove_page() combined with checking the GFN's mapping
>> there against the passed in MFN, there then is no issue with the
>> involved multiple gnttab_set_frame_gfn()-s potentially returning varying
>> values (due to a racing XENMAPSPACE_grant_table request).
>>
>> This, as a side effect, does away with gnttab_map_frame() having a local
>> variable "gfn" which shadows a function parameter of the same name.
>>
>> Together with XSA-379 this points out that XSA-255's addition to
>> gnttab_map_frame() was really useless.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> As discussed in the thread, I expect the Arm part to be simplified after 
> Oleksandr's series. So for the Arm part:
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

Thanks, but let me ask for a clarification: Explicitly just the Arm part,
or also the common code change? I ask because from the x86 side I already
have an ack by Roger, but strictly speaking that doesn't cover common
code.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 10:16:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 10:16:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236446.410152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msj8t-0005nH-PY; Thu, 02 Dec 2021 10:16:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236446.410152; Thu, 02 Dec 2021 10:16:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msj8t-0005nA-MK; Thu, 02 Dec 2021 10:16:43 +0000
Received: by outflank-mailman (input) for mailman id 236446;
 Thu, 02 Dec 2021 10:16:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JeoH=QT=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1msj8s-0005n4-Jq
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 10:16:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1146955-5358-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 11:16:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1146955-5358-11ec-b1df-f38ee3fbfdf7
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638440199;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RdevRfhjsHKeeCHTf9pHmrkF5+sLZu5HIYbbAd1ahA0=;
	b=CE0G0O5lmKxqkZC6BvlCruxb6hHn9pwsgNHT2CVOhNKska1IejpMxdl7YLMkS31AeiiP2P
	Te9ThMTsDiSJz3lfhgB3+yOnRaqm2z1iFM+gbLYtCcS1ULM58LD9cUw9r6HX8Qjm5+9u94
	/8Ea+50Mo6rWAgRVbrXNFAQMru8nmGk67ms7jqMhvLa0ssFSWJ+r3Xvq8/6l9WRP1oq/q1
	qmYyulR+iammXO7J2ukF1k3h6EC7jAr7afu4r5wKpliQqck8ti7wNpLdlgRJ9pIeewPxs7
	rS+AMHbbyQ2DgPwLknFCXgKQioSjvlDzvffI7rlb9lJkofsI5uUAJPbBQcFyRw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638440199;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RdevRfhjsHKeeCHTf9pHmrkF5+sLZu5HIYbbAd1ahA0=;
	b=2v0AYZhnbZ5OYxQiErXDK00fVJE5282NMNIpfLbx7OIHuFdbV0rSBUfPA1Gl76ETV2FIh1
	z+CYQVKoJ7EfZiDQ==
To: "Dey, Megha" <megha.dey@intel.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Ashok Raj
 <ashok.raj@intel.com>, Michael Ellerman <mpe@ellerman.id.au>, Andrew
 Cooper <amc96@cam.ac.uk>, Juergen Gross <jgross@suse.com>,
 linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
In-Reply-To: <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com>
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
 <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com>
Date: Thu, 02 Dec 2021 11:16:39 +0100
Message-ID: <871r2v71mg.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Megha,

On Wed, Dec 01 2021 at 17:08, Megha Dey wrote:
> On 11/26/2021 5:25 PM, Thomas Gleixner wrote:
>>   /**
>> + * pci_msix_expand_vectors_at - Expand MSI-X interrupts for a device
>> + *
>> + * @dev:	PCI device to operate on
>> + * @at:		Allocate at MSI-X index. If @at == PCI_MSI_EXPAND_AUTO
>> + *		the function expands automatically after the last
> Not sure why some of these changes related to PCI_MSIX_EXPAND_AUTO and 
> num_descs did not make it to the 'msi' branch.
> Is this intentional?

Yes, because I'm not happy about that magic.

>
> For instance, say:
> 1. Driver requests for 5 vectors:
> pci_enable_msix_range(dev, NULL, 5, 5)
> =>num_descs = 5

Driver should not use with pci_enable_msix_range() in the first
place. But yes, it got 5 vectors now.

> 2. Driver frees vectors at index 1,2:
> range = {1, 2, 2};
> pci_msi_teardown_msi_irqs(dev, range)

That function is not accessible by drivers for a reason.

> =>num_descs = 3; Current active vectors are at index: 0, 3, 4

> 3. Driver requests for 3 more vectors using the new API:
> pci_msix_expand_vectors(dev, 3)
> =>range.first = 3 => It will try to allocate index 3-5, but we already 
> have 3,4 active?
> Ideally, we would want index 1,2 and 5 to be allocated for this request 
> right?
>
> Could you please let me know what I am missing?

You're missing the real world use case. The above is fiction.

If a driver would release 1 and 2 then it should explicitely reallocate
1 and 2 and not let the core decide to magically allocate something.

If the driver wants three more after freeing 1, 2 then the core could
just allocate 5, 6, 7, and would still fulfil the callers request to
allocate three more, right?

And even if it just allocates one, then the caller still has to know the
index upfront. Why? Because it needs to know it in order to get the
Linux interrupt number via pci_irq_vector().

> Correspondingly, pci_free_msix_irq_vector(pdev, irq) frees all the 
> allocated resources associated with MSI-X interrupt with Linux IRQ 
> number 'irq'.
> I had issues when trying to dynamically allocate more than 1 interrupt 
> because I didn't have a clean way to communicate to the driver what 
> indexes were assigned in the current allocation.

If the driver is able to free a particular vector then it should exactly
know what it it doing and which index it is freeing. If it needs that
particular vector again, then it knows the index, right?

Let's look how MSI-X works in reality:

Each vector is associated to a particular function in the device. How
that association works is device dependent.

Some devices have hardwired associations, some allow the driver to
program the association in the device configuration and there is also a
combination of both.

So if the driver would free the vector for a particular functionality,
or not allocate it in the first place, then it exactly knows what it
freed and what it needs to allocate when it needs that functionality
(again).

What you are trying to create is a solution in search of a problem. You
cannot declare via a random allocation API how devices work. You neither
can fix the VFIO issue in a sensible way.

VFIO starts with vector #0 allocated. The guest then unmasks vector #50.

With your magic interface VFIO has to allocate 49 vectors and then free
48 of them again or just keep 48 around for nothing which defeats the
purpose of on demand allocation completely.

Thanks,

        tglx







From xen-devel-bounces@lists.xenproject.org Thu Dec 02 10:31:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 10:31:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236456.410171 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjN5-0008TM-5s; Thu, 02 Dec 2021 10:31:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236456.410171; Thu, 02 Dec 2021 10:31:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjN5-0008TF-2d; Thu, 02 Dec 2021 10:31:23 +0000
Received: by outflank-mailman (input) for mailman id 236456;
 Thu, 02 Dec 2021 10:31:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nb5W=QT=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1msjN4-0008T9-5g
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 10:31:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fd825880-535a-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 11:31:21 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-m5-jW8BqMl2VTj0_2my4ig-2; Thu, 02 Dec 2021 11:31:19 +0100
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com (2603:10a6:208:134::22)
 by AM0PR04MB4690.eurprd04.prod.outlook.com (2603:10a6:208:c8::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 10:31:17 +0000
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::fd58:46b6:86fc:8a94]) by AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::fd58:46b6:86fc:8a94%5]) with mapi id 15.20.4755.016; Thu, 2 Dec 2021
 10:31:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd825880-535a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638441080;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uXEUYPbe08YVktXCZLPg8pr1i3t4tt5IZDlbmRI3/BI=;
	b=UlLnWJvAMR4lpaQojL7q+sadACGg9YX2TskofWPSzDRSQnBSlyxq52TlAQn5M14Zd5N5w2
	1jYLpaA69nM/qqA7V0iJdf5yNbq/uRQsj1/c0wg0iGiatXh+rwdD7hH6OlZ2gtmTRSSHyS
	3PvZxG8Y4IidbWafvSxZz32ymxVMBbM=
X-MC-Unique: m5-jW8BqMl2VTj0_2my4ig-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hTWKWRTzDt2gn3BwmSD2nei9yngwuQF++jsgxZIxPm2cnRn4eWCkFA9XdC9C2Kzlp6WjWw1KHea7NSxMmjzD/T43opVsZbS2aeUCGm7UoqqyZ2obehkJLnTlwRKcWGreI3A1palYP7310BoZpCo2a0yQ//fk4XoJpcBCpqxieOez7pGkl017Loz6Qz1sX4CkhrW+/LF74oxzhVP2lgzOr0dZVPQgq6J4sDKp2ITUoPQsIxwUBSa4aVRsC21+Qe/Bhi8V1sz/RsxpoH6Qwqp7jgq74apv0m+wtmm+94NR4zkan4B5QELLdal2hW0wrGVTptgH44e0mcOUxzy3pQQRsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uXEUYPbe08YVktXCZLPg8pr1i3t4tt5IZDlbmRI3/BI=;
 b=T6b9LXAQcVZc1RPWq+NVHkLyxMl6JQ4q3snwALeziaFxdvycLXX6YR7nbzmsnyPRzM6CE2xxL+1JR57LWcchvNb00YytGX77/KzcMpzZLmb1Pn5iHMvpKQY1r0lh6pi5STj18aMon0lGxHJaTeiuEGzpODn0I3lahrfQhWHDB9hjaiOPFhfBFYhjcxMtuYwAEMVb8oE6xKJRHA11Ae+ZYJDAUZL8JwsLNJ9i4DTGHy4hlwKfxoMQIOaVvoThSP4qcuz0vPa7i++sOyKCfhQvLWqg6y0BFGWab0X0s6qYhNOKtPdch0HbKPy+YAeu71Oiq4Jaq1gDJzvXUy9R7diueg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>
CC: "julien@xen.org" <julien@xen.org>, Juergen Gross <JGross@suse.com>,
	"wl@xen.org" <wl@xen.org>, "roger.pau@citrix.com" <roger.pau@citrix.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"marmarek@invisiblethingslab.com" <marmarek@invisiblethingslab.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"dpsmith@apertussolutions.com" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 00/65] x86: Support for CET Indirect Branch Tracking
Thread-Topic: [PATCH 00/65] x86: Support for CET Indirect Branch Tracking
Thread-Index: AQHX52e8Wph6YOT4skyCNra+X/8gVg==
Date: Thu, 2 Dec 2021 10:31:15 +0000
Message-ID: <fb840a1359dbd2f6599146e65596ae378bd45426.camel@suse.com>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
	 <178aa1cd-b510-7e3a-2074-a2ae261d4975@suse.com>
In-Reply-To: <178aa1cd-b510-7e3a-2074-a2ae261d4975@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.42.1 (by Flathub.org) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 40119b02-6253-4e0d-ce2c-08d9b57edeed
x-ms-traffictypediagnostic: AM0PR04MB4690:
x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
x-microsoft-antispam-prvs:
 <AM0PR04MB4690F0F0E26EAB4EFCB89FBBC5699@AM0PR04MB4690.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 umo2S4gbxIT+w8QJcZJ9qysKQLqZxxir6XKW1+qqBKWWAFYcr81/7gOMWU7Vlf2Ff9kqSi3eBjQQLgz9uL2bRWiM+cRBdw3EwwmRRsFteKqO9jlWasCU0l5Sqz723+nWcmZ4hHJivev34jB13eNzTmWenvezwG3I0Fy1bvf8EhDNguKTiK2DJxU9ediDhpvj+P/o+WO5GARl5jgN8WwtzLO38OgkuaGOuq3k7QJJpOhrYEfIspDiTLm6WluGPNIJeX+QuUKA5qE5fsEfPK5FeGZWSxrtRq6EGOfqETYWscli3xdTL/yLUTPgBiIcxfe7AgBbmx4FALHdJU+jk4iaZIOqCW2dn1oxvz19Ul8Zm75Wrnvu5TZjSBf5wkdGBtw4VU7tVG/WWTDY2+scEeqPsxhxfN+2OKFYknwSSVAJ27tmj+rfbFpN9XuJfaYxufO8pwU9x/EHR3L4HlNw8kHWd06K/y84tKejCiJDWu2aD8J44qJll6LfKsrH1oILoTHMJRFIZLaGlxlmKdjhVee5rRnHsNndnLTSYUt6TsY4GSIp1OvEr1jty1uo8Nc2Vx9a6KAct76zciLnmWVmyqaeV9VK+6yQLgUQ1Gw/4jvaFhGDFf9j/2ZlNpnZFjP/HM4qP06KNzJiGamdxyKEH6S4Rcomu6cP3K2vWIWqlVjkWVTxW7V39iOMoQEl5/utFGXTfP5pgpLokvea/xTxFAcRYkKC7ZSOnDypR80PW9i2vEQVBej9yf3dCuEJPsfTi9YUxI81UDOVP1f/5VTe/Dtk55Yx8iWsV8EmeKWFEwlqrxGs+Skwv0ye5oiEV14loZ2fpuvr85I7GPEv+yHvmILtgg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5826.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(76116006)(83380400001)(110136005)(66556008)(2906002)(6486002)(5660300002)(54906003)(66446008)(66476007)(64756008)(6512007)(8936002)(186003)(91956017)(66946007)(316002)(71200400001)(4326008)(122000001)(36756003)(2616005)(6506007)(4001150100001)(26005)(86362001)(38100700002)(508600001)(966005)(99936003)(53546011)(8676002)(38070700005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?ZTZzMzhiR1EvdTBUUGkzQVI5clUxRWpUdHkvREw2UEdLcUNxb2dVeHhsQW5X?=
 =?utf-8?B?aldyOEQwbTA5V0F4NVZ5Q1h5WnkzRlVYRit5aStYV0crUFlmSUdIdTAwKzdP?=
 =?utf-8?B?dTljMG1KNDBUck14cmQvWHhxODJFS3VWbXRLbmlIbDgyaFF4Z1lZYmNWdHlN?=
 =?utf-8?B?T2pBVmxlSm1kTlBvNmI3WDErdzB5TVhkd29SeStUUnZvV2VmV09ZS0pyNzBp?=
 =?utf-8?B?SlkrbTZncVlZKzJYc0JoYkpOdW9yM3dzMHAzYkpOOWJ5WWxyK2FaSTVWdk1L?=
 =?utf-8?B?N0prSTJaK0JydUx4SVhFY1d1TFMwTjl4R0JFOExwL1dxTmVxQSt4bit3czJS?=
 =?utf-8?B?MS9zbG5DdVppSGZRWGZ6Z0NNb3pPdmtKUnZyWkltUTdFSHpYK0NYQS9aMDFB?=
 =?utf-8?B?OFdqQTg3ekRwU2FRK01jNHByYUpFUVFBVDRrMXBKN2t4bkVCd2thSUVVMHU0?=
 =?utf-8?B?ZXFaVmx5a3VsVnl1SG16NHJwcUFsOURYbXNmeEV3N3JGaFVUZCtQMzVJR25M?=
 =?utf-8?B?YlFqQmJMTXpINzdkQnFGMDQxQ1VBcGhnQXNLSENWQzdTVFZwQmRDNklxbmFI?=
 =?utf-8?B?V0VUejhWdktKc1RqQU81cGNPSzVNVHUxVFhkaW51UDNsV3YvRFpidDJFaUYv?=
 =?utf-8?B?aXBQWFB6M2tXVG10Ny95VElmODQ0eXpIM1cveWUzNmd5cWxUYzhpS2wrZGFW?=
 =?utf-8?B?VnQwdjFndkc0ZXExb0VDQ2tveE90M0dTR1hmR3RSNUtnVXp5VS9BWEdndEJp?=
 =?utf-8?B?cmM3Um5VY1RKNytPWkREUEVOcTRwM3ZuOEY5RjdxVFkzL0MzVFdGNjhVcHY3?=
 =?utf-8?B?dUljbzEwdy91RFBpN0hiWktDRC8yRlIya1pRYlMxYkI2V2tDMFMvaFZtMXNx?=
 =?utf-8?B?eFpnalVjMTQwTnF5V3NDWko0ZmZIMXNEZmtYZ1JZUGUwaEtGbW5HWHhPeDZ3?=
 =?utf-8?B?b1J1cE1IdVVINU0xU3krMTQraXZhWkhRdTE1WVdXRHVSWFhOcEZVU0ZubnlR?=
 =?utf-8?B?SlU4ZWRMTXNJdDduZjhNOHBmZER1bUZBMDV1dUhVMUtnSzBra3RUUVBrRFdU?=
 =?utf-8?B?VEJKdkN3bkZWSVhXMkRIaDlFRUNKUlFVS2xtSmpDdWlCSTFxWU5NR1pSNWNB?=
 =?utf-8?B?TXZqSkRWZzZ3VDRnek5jNEpNZ0x0WXFQTXhjbkx0czBnOVo1bTRacGpQM2lG?=
 =?utf-8?B?ZzNadkMwY0xOSTBlMGVtZEZDRVdKMEJoT01Odk5talR3Y1pTSnlDa05NRlVo?=
 =?utf-8?B?MjlNZE16MzJtaGh2V3dZNkQvSlF4OVlVbUVSQ2x1SXRMdUVVSlZBd3k2eXRU?=
 =?utf-8?B?dU5iaGVacnZZM2V1Y2xoQ3NzclQzZXZjdks5aVdzR3NqaXNBSVMvR2xiS0g1?=
 =?utf-8?B?VTN3cjNMOFY0VWZWTVQxOGRpdlpHOWk1NU0zT0lZUnRIenBJQWppRWdDME5r?=
 =?utf-8?B?clZQSEtsbXJ3TE5VQUthRWJ4NHNuOC9uNm8zSDVWNnNYVDdxVUZ2QW93QVl3?=
 =?utf-8?B?YUU1RkQ3VEJXYTUwMzhqemxURmExdms0NkVRVjNKTk53UkNqUW9YV2c5MW11?=
 =?utf-8?B?Qks5NVpmOEQ2dmdZWVlnb2g4ODl3ZFlBOTFFR2JYeVh6YnhBSnRaTlgwWm1C?=
 =?utf-8?B?bTI1dEt0amdXU3ovcUZtWGZNZDdpOGQ5VW9LeDd2R3l5S2dDTHZzSkRaMXNY?=
 =?utf-8?B?clUxMlV2ZjI3TEF0MW1xaXlxYzVIS2VJMGQ5SGhrbUJKSVovMXQ5Q0VNakwy?=
 =?utf-8?B?UUM5M3FPUDhKaHoyakt2aUNUR3QwVC85YXY3MkltL2Z5Ym1KUHJTbEVYSWRl?=
 =?utf-8?B?eVdkQ014bkh0dU5tNHgzTmVFT2lNSDVmOXE0bW1Ka01MeGhSd3RuZEVSaWlJ?=
 =?utf-8?B?TVBDd3NaMGZlWUZXbUViVm1EaFVGTmRWYUlKZ1prSmFzYmxlQWQ5alVSV3dj?=
 =?utf-8?B?ZkVWdVg4U1JSWVpZT1ladFo5U2FUSG5PWTZSNVFtMVFzWUF1R0JKenB0dEhv?=
 =?utf-8?B?NlB5TVFDSGM4ZU03N2hsUVpkWlJEZ0FOSDhhM3BVMXYwaTdmWFVsQTBMQ2hV?=
 =?utf-8?B?R2VHUjhKcldmbEduVHRIbE5jeDI4R08zbVkwMDhad04yVEVwKzErNExJbzNF?=
 =?utf-8?B?OUNSMHNJb0hoQjl5Nys3MDRkcnE1RmxETzc1eTVEYzU0VVI1UGNsOEpiQmFY?=
 =?utf-8?Q?OmH/W7kg5FZIeX+Hlc6hKT0=3D?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-FeNE+79BmD66IoQK6+q1"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5826.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40119b02-6253-4e0d-ce2c-08d9b57edeed
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 10:31:15.9149
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SRmgnTOZwPsq1aXl0UHBbSFRLBgrVj7cyHpe/5xwhevBjdpdA0t9atHACPqaWzqqxE6WyxCWaLX242pVV72SUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4690

--=-FeNE+79BmD66IoQK6+q1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2021-11-29 at 15:44 +0100, Jan Beulich wrote:
> On 26.11.2021 13:33, Andrew Cooper wrote:
> >=20
> > Andrew Cooper (63):
> > =C2=A0 x86: Introduce support for CET-IBT
> > =C2=A0 x86/hypercall: Annotate fnptr targets
> > =C2=A0 xen: Annotate fnptr targets from custom_param()
> > =C2=A0 xen: Annotate fnptr targets from __initcall()
> > =C2=A0 xen: Annotate fnptr targets from notifier callbacks
> > =C2=A0 xen: Annotate fnptr targets from acpi_table_parse()
> > =C2=A0 xen: Annotate fnptr targets from continue_hypercall_on_cpu()
> > =C2=A0 xen: Annotate fnptr targets from init_timer()
> > =C2=A0 xen: Annotate fnptr targets from call_rcu()
> > =C2=A0 xen: Annotate fnptr targets from IPIs
> > =C2=A0 xen: Annotate fnptr targets from open_softirq()
> > =C2=A0 xsm/flask:=C2=A0 Annotate fnptr targets in the security server
> > =C2=A0 xsm: Annotate fnptr targets
> > =C2=A0 xen/sched: Annotate fnptr targets
> > =C2=A0 xen/evtchn: Annotate fnptr targets
> > =C2=A0 xen/hypfs: Annotate fnptr targets
> > =C2=A0 xen/tasklet: Annotate fnptr targets
> > =C2=A0 xen/keyhandler: Annotate fnptr targets
> > =C2=A0 xen/vpci: Annotate fnptr targets
> > =C2=A0 xen/decompress: Annotate fnptr targets
> > =C2=A0 xen/iommu: Annotate fnptr targets
> > =C2=A0 xen/video: Annotate fnptr targets
> > =C2=A0 xen/console: Annotate fnptr targets
> > =C2=A0 xen/misc: Annotate fnptr targets
> > =C2=A0 x86: Annotate fnptr targets from request_irq()
> > =C2=A0 x86/hvm: Annotate fnptr targets from hvm_funcs
> > =C2=A0 x86/hvm: Annotate fnptr targets from device emulation
> > =C2=A0 x86/emul: Annotate fnptr targets
> > =C2=A0 x86/ucode: Annotate fnptr targets
> > =C2=A0 x86/power: Annotate fnptr targets
> > =C2=A0 x86/apic: Annotate fnptr targets
> > =C2=A0 x86/nmi: Annotate fnptr targets
> > =C2=A0 x86/mtrr: Annotate fnptr targets
> > =C2=A0 x86/idle: Annotate fnptr targets
> > =C2=A0 x86/quirks: Annotate fnptr targets
> > =C2=A0 x86/hvmsave: Annotate fnptr targets
> > =C2=A0 x86/mce: Annotate fnptr targets
> > =C2=A0 x86/pmu: Annotate fnptr targets
> > =C2=A0 x86/cpu: Annotate fnptr targets
> > =C2=A0 x86/guest: Annotate fnptr targets
> > =C2=A0 x86/logdirty: Annotate fnptr targets
> > =C2=A0 x86/shadow: Annotate fnptr targets
> > =C2=A0 x86/hap: Annotate fnptr targets
> > =C2=A0 x86/p2m: Annotate fnptr targets
> > =C2=A0 x86/irq: Annotate fnptr targets
> > =C2=A0 x86/aepi: Annotate fnptr targets
> > =C2=A0 x86/psr: Annotate fnptr targets
> > =C2=A0 x86/dpci: Annotate fnptr targets
> > =C2=A0 x86/pt: Annotate fnptr targets
> > =C2=A0 x86/time: Annotate fnptr targets
> > =C2=A0 x86/misc: Annotate fnptr targets
> > =C2=A0 x86/stack: Annotate fnptr targets
> > =C2=A0 x86/bugframe: Annotate fnptr targets
>=20
> Patches 4-55 as applicable
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
Patch 16, xen/sched: Annotate fnptr targets:

Acked-by: Dario Faggioli <dfaggioli@suse.com>

> preferably with the subjects disambiguated and the minor remarks on
> individual patches taken care of one way or another.=C2=A0
>
Yes, FWIW, I agree with Jan here that even just a quick hint at the
purpose of the annotation is desirable.

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-FeNE+79BmD66IoQK6+q1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmGooHIACgkQFkJ4iaW4
c+5GDxAAwVWtk3UK3d2iqDOSkHe+OWab+U8fZ5aAP/KJqSTfPNeowZEInyhOhIMZ
UMOR2Jpa7bHLzGQoAQI9KJms11h9H1tajDxOjzpoiQXTLo+oVy6zb4TrebV8L2Ji
DOu9yhf6iTILQaEgzeVPud5+vvkG9PrWpymcKiAh3o9060vVYHP114AXl8sRdx2Z
yH7qkwFGHV13v/7gLWzu4Q/x65jNEN0CT9ugEcGuX8NEldQtQJeR6o77sATqv72v
AducSNbDjJSx56aupf1PoJ2BzlsrJCdBLpQM5qPic1I54mAlbhog6oVgm0sdaeQB
ijp+44ol3eNP1ljwkN+BD/VKvbWM9AyyV7tDuYW1cPEPX9qQH7LiN8SIjxTNFGwA
EI0KjXGH8WshZVFV7eydhLj8rNmu9PF1VrFpr6u3YgAAC1GIBLXAjYXaPd+JXHOB
uCchG6D7d2R1hzwDqTMhxAoV/G8jwyPdLx0R48J75UMTQ6aD2GeoGOb9a7zjDKX4
eALDUogVXVD3CTcCzy0VUTLwTzP5nJGsbNVnlteex/AsquZPTu5onXGWLbJY6xyF
36Gz2KnYMi6VzDLL9ulyBz+K0F+kW7wpP3l5pGUZnPeZJqsd9+Lo9UysZqCFD5Jc
DBbg/iWtb4bKsbRZRsRHRF4lJHRrDSkfjw1YDY6+4YTawCG+FDY=
=R/Rv
-----END PGP SIGNATURE-----

--=-FeNE+79BmD66IoQK6+q1--



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 10:40:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 10:40:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236463.410186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjVX-0001ee-4L; Thu, 02 Dec 2021 10:40:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236463.410186; Thu, 02 Dec 2021 10:40:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjVX-0001eX-1H; Thu, 02 Dec 2021 10:40:07 +0000
Received: by outflank-mailman (input) for mailman id 236463;
 Thu, 02 Dec 2021 10:40:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cBvN=QT=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1msjVV-0001bX-TT
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 10:40:06 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 35437018-535c-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 11:40:04 +0100 (CET)
Received: from FRYP281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::15) by
 VI1PR08MB3888.eurprd08.prod.outlook.com (2603:10a6:803:b8::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23; Thu, 2 Dec 2021 10:39:55 +0000
Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:d10:0:cafe::70) by FRYP281CA0005.outlook.office365.com
 (2603:10a6:d10::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.9 via Frontend
 Transport; Thu, 2 Dec 2021 10:39:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Thu, 2 Dec 2021 10:39:54 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Thu, 02 Dec 2021 10:39:54 +0000
Received: from 90981674843d.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 573632C0-527C-40F0-93D1-188FC0DFB732.1; 
 Thu, 02 Dec 2021 10:39:47 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 90981674843d.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 02 Dec 2021 10:39:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6549.eurprd08.prod.outlook.com (2603:10a6:20b:33d::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 2 Dec
 2021 10:39:45 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.028; Thu, 2 Dec 2021
 10:39:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35437018-535c-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NsUQIDAe0CbTwEUnhPlTtYPfkoUGm12GPg7RZaThfCg=;
 b=NwsZsGS6eHdPiEQXqVy3ksQYv28SWeHGQ1lQluqal8I0i9b+/nbjPwkeRtnrPzU4z0jQw7YGrCI5qmWRQVeWb0Sd4mR7n3UBsmuP7iNbJhhLA1Yk0xF3yTBBbaFBJysH3xvh1sB3htZJdNPGk9lFo2IG6wwACQKb3XWpJEp59wU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ce4a97108863e540
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MOkP0kxpD2cztXh9QtPZiyVdGG/lflVG6CS1JUNbsyTcEhRvphydbyjcMywc3tmrHHLig99pUO56i8iCRp9tw/Rex5viIOoYNOivHFCtjt73KMcfTGucXEBOKIcf52exe2XFqAYvMO5aYRHjczaarHV0WCLjXnuPEx7T/f+J4pCkWLnovebR3UBF+I2IVWy6ZXR6S7FhETg0YKFYr1TNvw1qzI9SBUtoevR+g/QM+x6eZ8sDNKMhllNk2ecr5yOHvs5eSNKUfWjXqbswd1mizeHszh1rp1YRmpsnuBp8N5vpLXZgeMVZM28EMo8PHGFirj77ZAYImOAEe2azl2aTHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NsUQIDAe0CbTwEUnhPlTtYPfkoUGm12GPg7RZaThfCg=;
 b=D6RP3TkQ7rEb1xI5vpW0bTb6Kl1w3sc24C7iMdofcUTtFWszCIMZaFcxCAb1FpzjIKpaR6io2ZiQQ0IVyAEJv/bTKZLafK1Okq6V5NR+rNmTzLzCZCaAn3WLWQ3m8iTCrzoKcj/RwvJkJMzPzVXr3Q8p7g4J8AXTrJJDVD5u2gHRAtvPSgl8sYfFptIIFFRqKBXibpjN3zdTSaRGPrZuN1ohLkDUe9Zz6qHP2TuLEHX3J0nbNPorJEng3Lo7B80WhlENSYaJRXSYVle4yfRPX+ipRL5t3o8P6KMizz/LGusWlp1vuIM8Q7afyHpclrUPHucHB/Bhd7En1jw42guH5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NsUQIDAe0CbTwEUnhPlTtYPfkoUGm12GPg7RZaThfCg=;
 b=NwsZsGS6eHdPiEQXqVy3ksQYv28SWeHGQ1lQluqal8I0i9b+/nbjPwkeRtnrPzU4z0jQw7YGrCI5qmWRQVeWb0Sd4mR7n3UBsmuP7iNbJhhLA1Yk0xF3yTBBbaFBJysH3xvh1sB3htZJdNPGk9lFo2IG6wwACQKb3XWpJEp59wU=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Daniel Smith <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 0/2] xsm: Further fixes
Thread-Topic: [PATCH 0/2] xsm: Further fixes
Thread-Index: AQHX5qTgcr9QGJZxvkaRDr/n3UQDXKwfBIwA
Date: Thu, 2 Dec 2021 10:39:44 +0000
Message-ID: <5B401EB8-A0D7-42A0-83D3-B60998795D81@arm.com>
References: <20211201111555.16408-1-andrew.cooper3@citrix.com>
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 751b211a-75d2-40dc-f10e-08d9b5801418
x-ms-traffictypediagnostic: AS8PR08MB6549:|VI1PR08MB3888:
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB3888190B50992F945B36893E9D699@VI1PR08MB3888.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:2582;OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ENQAM9IObRcu60xtoXBwHlpDVUGULaSmEw+eX5/i0ls+VztdM3YZvQ9Yhd2/KQsF+0qA38oTebbg4S5jnE1dkWpmsIAVZ8R6QypALoXKUHzEMmiDhzKyW0yM9YaB2BW2XI/KnCs6jzqcVdkct3LyIXB5xUB6HiMt34d5Czy6uLKd3LiB3qFSvGOb1kyX7WJzK4zQ2umgSsDELtrZ3fjt2COkPMwDKsf8WfhgekCsqil/jJNxYyeTHsMO7UtQLqBRLiALU/lcIYwtOEO+zSOVJU0/GWp4sE//V/GG5HGyZO46IxUoHVDzCi/VDwzuywBiHo3itCBrkNMa8AqtW/dAOER/THf5fePZCXXcS1FPQ5Cdzz46PPJJxOTuBKVArSKnnwZmB/NkRpjALL3QZHB+WVkeRqEvtAuM/mHSCwATBRHHFLaugk83/mojpJLFtTmjTVB5A2JE3WD0vHPQqiqiZxrQd5fzeLyjt4CyaWS4n+BbOYX6OAKn752X8JYnHcv4vFgWquJ3hVYOapEC7WYmeoGH+k79uqjlhIrxa7D0oq+DnJ7Lfuw/voT9GsJCaXTLUAhYm1jNNxjKV2cluBgYpH9yuFYl6SA8ty/onWc83TfP893DwBdVj3z5gBrnA+4F4N3ng7f1oDrKznAfaEABHGeIG+uxoezTUPxoBf1KVQ9AxKTaEhregqB4b4csLkkqLxpt8EctSoih7y6zCP4MJI9aojJGJ3bHsE/qCfD9lghyOFUeOPwS0vZLnD7QQMuS
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(558084003)(66446008)(6506007)(508600001)(91956017)(8936002)(6486002)(36756003)(33656002)(66556008)(6916009)(26005)(2616005)(71200400001)(8676002)(38070700005)(76116006)(38100700002)(86362001)(5660300002)(66476007)(4326008)(186003)(66946007)(53546011)(316002)(122000001)(2906002)(54906003)(64756008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <867939B1ED86914794BDB881C201D56A@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6549
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	aae64653-3e2a-4c44-5662-08d9b5800e44
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zKDvXfoe0RhwQo7MkmXyJ4/sd4oD7Pm1wjL9+ZpmFrxXP0eChpX6vuLD6QIbj4HnvAU6HEzjK2cPt7HCIjO0qwGgc9lSyvZYUNrhpgsVxU4Ub6UuwixrDC3GDw1TuHBtDI2fpGw/YHwDIHlZOF3DFRJwb28tz9+bushJR+bOhU7xsWEYWycphDbFWoSPNdeaK7Nk12eqQLIHi2Oz6t10I+A7xzKLHpD2MrJ1Vspj0UoZJnrF2sw801ewD1Cd1ME4C5g1VR7qxDF+weZCkRXZYUSlQiQvWo3mvY1OXpEu5ClnN7nthmYvqS85rwnxg5R2asgx6TqPwhTz5ubonwgTZCalaRsdYcmaowosQw6I2t/bx/tpvcYHTxfc13gjaIVSWuXBOATeIbT/0dOMZ61DJU6YSchUTJ7hmmqvZxYc/jE1T9rxHbDQPUolrinfCCP+w1VAI/5NKJtBdGZx9X3/q9x5XuBuKCnnZjEvMdoSWrLnBzoKE+6H/x2NQTsLysq1FfuS6VAtnQQU87fD2nj5lzkWKK/gbdRNAH05RpYCFwVO4p41ZE7pE9YhpTqk07VSDZS/pdjT/SBXufKKoX+sMpfruT+sAuO320LjSw9SMZY8lOsLYfvgqneSjrRN6KMXKpwlz9qSfE9EOp1Qd9siOHEYu6nzkLoAf5LlIFBPadqWIDpdqImWDyEoJ05cWfJr/Ar4U+XFHKiLEPLAOFVQRQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(558084003)(186003)(6862004)(36756003)(81166007)(5660300002)(86362001)(47076005)(8936002)(36860700001)(316002)(356005)(53546011)(8676002)(508600001)(2616005)(6486002)(2906002)(336012)(82310400004)(4326008)(107886003)(70206006)(70586007)(26005)(6506007)(6512007)(33656002)(54906003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 10:39:54.6162
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 751b211a-75d2-40dc-f10e-08d9b5801418
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3888



> On 1 Dec 2021, at 11:15, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>=20
> Andrew Cooper (2):
>  xsm: Switch xsm_ops to __alt_call_maybe_initdata
>  xsm: Drop extern of non-existent variable

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 10:44:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 10:44:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236470.410199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjZq-0002JG-Ny; Thu, 02 Dec 2021 10:44:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236470.410199; Thu, 02 Dec 2021 10:44:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjZq-0002J9-Ky; Thu, 02 Dec 2021 10:44:34 +0000
Received: by outflank-mailman (input) for mailman id 236470;
 Thu, 02 Dec 2021 10:44:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nb5W=QT=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1msjZp-0002J3-7U
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 10:44:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4618bfb-535c-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 11:44:31 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-M6UKHFy9NySXxD3c9OR7og-1; Thu, 02 Dec 2021 11:44:29 +0100
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com (2603:10a6:208:134::22)
 by AM8PR04MB7778.eurprd04.prod.outlook.com (2603:10a6:20b:24a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 2 Dec
 2021 10:44:28 +0000
Received: from AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::fd58:46b6:86fc:8a94]) by AM0PR04MB5826.eurprd04.prod.outlook.com
 ([fe80::fd58:46b6:86fc:8a94%5]) with mapi id 15.20.4755.016; Thu, 2 Dec 2021
 10:44:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4618bfb-535c-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638441870;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=36ifU27pnG6qpA2pqL/qjSPu/dqrbRmcJXHUWpIz6Tw=;
	b=P18a9L9xVxNy86xb3zjZSqsmN592o+LBhPdknIDPE1tVZEenFMr+8KrmGWGPqjXTWHhzj0
	H4dfHSbLINwEq/5M57rbtH1MJUpvQZ8SCY3xynygy72gJI9p+NpTdMKZTDXPjQpQQWqaHl
	ASDSBkyY8OMJ2fNsN62RwZfxyvu4JlE=
X-MC-Unique: M6UKHFy9NySXxD3c9OR7og-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZZn4tsaoz9cCaEjfxgPaNx+YvTsu60QP3ZO0AahvDfqtcvSt4km4sZ0lxkzA6K5n8KesRHpY4x9tOPcPYKAlCA6sHI4k2i0hSOupyK1/a/eNe6od0x+9J8V/JZ/DQBAeM9ME/c6qqA5Uiiw11KBCBsiPKlG9Eq0Rhogq6SYQhbVx9t2hbO2ezU6cWiXiXlwER65/JF9QaUZUQz9pOs/WEwDTHTyOWCfQRu2Wg+yFDWM800NxRw4Vq7X1S2HoSFy/UQSu02C5U/XlPlAybDf3b9+gMh/zjLSQG3eEWlvdktLZEU4J1Qejyawyx0DTR0qPUtr2nlpSw8bdUICQ2s6Mrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=36ifU27pnG6qpA2pqL/qjSPu/dqrbRmcJXHUWpIz6Tw=;
 b=Vrdjofd2NLzPhYKDCljARnpFt+PXM6FDFpkHJSfSzl+wjZ8/P6t7NNxIIZrjdNj//pAfu71jzL/gFw2oV8hdlt44SDy3K4/zSp2AhADNHaMGYybweLZvSERjl3AiVvp1qwcXFo9ir71fKLJ4r71+jsoGrQuFtlR5Jm3TYratKSTtVXSQNiNk08hb0E6Q1Z5B40c1GEhRL+SCLiTKcpBJQYELOVhNNkMgRaLrP5ZakEAXZd9zJ5u3Gaq7KwxURz5SE0FM6+K7IMx3053Fp2Mt4Po1IWHh+0zRFAWmxdLcZlJ46jhLjD6WOowcfrNdqA0FoDA1gbIXhS9ea3B9/bAiqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
From: Dario Faggioli <dfaggioli@suse.com>
To: "osstest-admin@xenproject.org" <osstest-admin@xenproject.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [xen-unstable test] 166960: regressions - FAIL
Thread-Topic: [xen-unstable test] 166960: regressions - FAIL
Thread-Index: AQHX52mUfBd5D6xxFU2byl2OP4I40g==
Date: Thu, 2 Dec 2021 10:44:28 +0000
Message-ID: <ec11daf7a998ae63c9a34578ec4224bf900232e3.camel@suse.com>
References: <osstest-166960-mainreport@xen.org>
In-Reply-To: <osstest-166960-mainreport@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Evolution 3.42.1 (by Flathub.org) 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 82c180b1-c9ad-4df6-03c2-08d9b580b721
x-ms-traffictypediagnostic: AM8PR04MB7778:
x-microsoft-antispam-prvs:
 <AM8PR04MB7778253C9642DFFD8CB30D72C5699@AM8PR04MB7778.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2733;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 pxJmifdcYkgP+Oado0UGj3TVwRjvyIj6MHlxD8ur8+UswO09xWYEZp5EhjORWj8Ftk9RziMspZ0URe95dwEHK6zP023WMpovvBe0AvFbdzaU9b7tdBJH6SjFfuPU5DTwp7n703H+584PZrvagWPWiBhKwF/Tw423nEXUa7k472yPxgMi+6kKc7iyoxtQZ2UwY4LshtAFpSADhHdZ7Kw45Yd3ZaQ0CCZ03+n85gG5XJCbrHnvbxugoIqi4gzdLEVzt5a6uXPtCZnaa1upxtlv9hoKrac/rNcsoOviCcFDqF+bS2hgFJKd7x/kEXB4sV6B8Epb3F63LBHpC4VwE1yoIIN7dYAeCq6k/99Zq22aSPeUm6ngXFWS823Z4rHli+rkkHJPTLqh8h/xMVsSvvr/fLbZHi3d5gzCwDvqYl1+1djXCD5lV1iSUrEenAa+URkFdkfyV750yHJqu3uTtzsZ/93SAVcGXv/SJYlaBdbT+soDNr55CNYUCS3v3xDsK4CMqQ/HhzYQdcBkd637ZU2L5qgYm8ZbTcY1lyAJewMtfsxB5B8boqOi5z0xlW3xU4TW7egXHyMjoLBFUeCGLbEnprOUn7rHEosVlmIam2C4fPX6bQ35bAe8soSDxOUGMH4biZlpPPWrPA/QY/LvFo30PJwIEEFodQGyqi1rzaTCS2oj7mF5+Qd53O5PCD+36bfP9yrKDqfjMFYvroRq+m662Y5mKbmuXxtqRJzKVw8G8xvcxBRk1jd480UmA2UlY41tsx1+mFskUshs3LDGjKrN1nfOkVDM3E8yid9OZl13ym775nFHf1BGw8vu1aHy6yM/Y6gBHhbpoa77gQA2FBZzxw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5826.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(508600001)(66476007)(2906002)(26005)(38070700005)(6506007)(186003)(8676002)(71200400001)(122000001)(966005)(5660300002)(86362001)(83380400001)(110136005)(66446008)(66556008)(66946007)(99936003)(64756008)(6512007)(91956017)(76116006)(6486002)(8936002)(38100700002)(36756003)(2616005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?R2g4Y2Y0V2tOQi9pWlBnZnUwZVlKUXdRU3A1Y2dYT0E0b2NrZVI0WlpYc0w1?=
 =?utf-8?B?YU91OVVaQjJjeFBBVytaNWFVclkxcGhRekdXZFJSWGdwbFNTVTdMeHppOTJr?=
 =?utf-8?B?NnFQbms0V0N5UUZtcVpWZ2VUOGgwU2J4c1dZbEI1cUNvK0wybFJxQURWYVN1?=
 =?utf-8?B?UElzOXczZWIzMWVjTXdwa2pENW5haHcvS3lrY3FsZzVVQUpiYUFaSlN3WXBt?=
 =?utf-8?B?SWh5Z2NqQ29FZFI2SUpVSXVhbVd0eGV1MFI4d0ZNZFRPRnM1TUtJamtWOCtR?=
 =?utf-8?B?WjIyOFgzTzBYZnJlZGYxKzI4N1czN2tVUk9jZ0luSzlkSWhEN0FCQWNKV1dZ?=
 =?utf-8?B?MDFRSDhwZERsRE05MC90V0ZsMWd4dmJ1UkQwYXVBdElpN2ZRekpybXJPYXk4?=
 =?utf-8?B?elR3Qk0vY1NEVWh1OTFiOHdHSENVL1pGbUFOZmRiL050anhJbTEwcUJNQTRM?=
 =?utf-8?B?YWp2L21tOW9WUW5kbzVUUllCZEJzRkFkOWtiWmtzRGo3QkR2bGVWVmVEM0sy?=
 =?utf-8?B?aTZVQ1VVY1ExTnA3dXNNa3A5dWE5WDI3amRQM1o3bU9sS3JDOGs4dXQ1MFcx?=
 =?utf-8?B?SnhnMzJwcC9lQ3V0SVphMU5XSVVVOUdaSGVld2FGZFJNV1NLaW1PUXVaVXds?=
 =?utf-8?B?TGpGWCtnb1Y2ZzB6Y0ZHdjNWTHNVZE9tNGVRRnZiRUM5bzhYT0RjdWxzV0NM?=
 =?utf-8?B?dEF4QmVGQlUwUTMwNWh3R1RKR21MTjVMNmNuZ1RocGZhQnBqRTh3TTBCa3lo?=
 =?utf-8?B?QjdqdWVpNDRKQWF2YndDQWRRS1hCMU82UXlWbjRTY0F4aXVMN296SDVKem10?=
 =?utf-8?B?ZVVXWWw0TVRNaFcyb2s1bmdOZDg0S0o2Y3VGZzNwOUhqYVNrempzWUlrdmsx?=
 =?utf-8?B?RndIR1hWa3dlZmZZT2ZZRXA5R1FOaXBSdzgxMGNXNnFoSTNEZXJVRHlPaFdN?=
 =?utf-8?B?Z3dlZlpndmxTaWFHUWswTTRkYXNWcWJ0L0ttZmY1Y2xlSkVKS3BaZTB6VU9D?=
 =?utf-8?B?MXVZOEdXSzdOVWpYMk8yMG55MFVjSjcvWTBVV3VhQUdzSW80UjlUOTVLTWV2?=
 =?utf-8?B?dVBhMjBXTTNpY00rSzNpQjdJUGU0NjNFNnY4WVBtUjBvTHdzSnNvMlR2a1I4?=
 =?utf-8?B?ZDRGbHNKMzJaSitiR21EZEQ0SUFNUk11VTA2Q09xVlFPSHFlNGVMU095SHl6?=
 =?utf-8?B?a0ZkSE9sSFk5ZFBBYk9HRHN2eHJzd3Y5cE1rVkZlL3RyTklsT0xGd3hJZ2Qy?=
 =?utf-8?B?ODdZWDZmMGJTQmZiajRvdG0vcGdVdFFyM0lLVElnQXIyeElmaldzZjVoc2Jl?=
 =?utf-8?B?bXVzOGdmSk02aE84ZXhKKzlHT1g2YVJDRmt1WCs3SlNhUTFPeU95T2xLNTRZ?=
 =?utf-8?B?UXdKRWlLL1g1V01iMzNrOW9QOThBZDRtK2orczJ3UWlES25VczVYSVZLQWxl?=
 =?utf-8?B?TEpUQUNjTkhNSE40SlVZb2xiczRmaEJ1dDVFbXExUlM4QkZETTdEVFlRRFBl?=
 =?utf-8?B?LzVWTXY5U0Qrb3h1R2M0UHVwSEVXcHc3NnErMEE3OWZrNUNmdWl5QWpFNENO?=
 =?utf-8?B?bDlOblQ4L212VDd1NzlyVE5lRjhiOXZtSXk4SlhUODFBZk5FSkR3V1l2Wkhn?=
 =?utf-8?B?c2pKU3ZCVyt3SkRLTnlYSHFYRTlTTVpMUDg3aWRoM1ZlVUVVQTVlWXBjYy8y?=
 =?utf-8?B?dWdUSDV1ZXA4c05kUjEwYlVLSTdyUi8vTUwvNjB4NzA5VXp6Y1RUL3lwTHdy?=
 =?utf-8?B?TUVjbWxtV2lIVTdiRE9rMUlIRXVxbTRBd3BCWnlMS2RtS01kTXgxQndEQkhF?=
 =?utf-8?B?SUgyUlpLSTVWSDFSdDBIbnkrV1VOdDV5S05mVHRNVDFyS2J3M2hpWjlhcUN1?=
 =?utf-8?B?V3JHNjZrdWk0Q0dNY1NIaVoyMkdsRG1Qd0NYYThJUGJaWTZTNEx6K25QeFZz?=
 =?utf-8?B?a2NvSmdtZ05ja0lzSTFiYUdudXBzNU05SXVZL1FJblpzYmlQbFkxM0tqa3VT?=
 =?utf-8?B?KzluRWVYbTJ0VW81OUJpT3RwK2N3cDZCdGRIT25tSVhHMVZicFBKbHI3aGZX?=
 =?utf-8?B?cWtkYkI1ZEhjWEZMWllScjdjNkU0aUJsd2dqT3ZQcUxlZ2djM2c2NHpqdUNS?=
 =?utf-8?B?UXZROHdRWDJyNWFsbTFoRjdrdktQNXNXSG9YQkxRQVEwN2xOR0pYa0Q0b01B?=
 =?utf-8?Q?jM89L8qmqxqovfxRwxHd8jk=3D?=
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-FYXkzCRXQcUKn0O8fuKJ"
MIME-Version: 1.0
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5826.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c180b1-c9ad-4df6-03c2-08d9b580b721
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2021 10:44:28.1691
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rmUx5HW1caEawcuv5cl93nG8jh0DoOWvTEgcIvL9CGy5UjSUw2iiqY2uvGCtD7C0oTK0EwFxDVXYbQ/J4gUuBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7778

--=-FYXkzCRXQcUKn0O8fuKJ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey! So, I noticed this osstests report and got curious about one
thing, which looks weird to me... If I am missing something obvious,
sorry for the noise.

On Wed, 2021-12-01 at 05:43 +0000, osstest service owner wrote:
> =C2=A0test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REG=
R.
> vs. 166941
> =C2=A0test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR.
> vs. 166941
>
It's about these tests above.

In fact, from, e.g., [1], I see that we have 2 pCPUs:

nr_cpus                : 2
...
cpu_topology           :
cpu:    core    socket     node
  0:       0        0        0
  1:       0        0        0

At the same time, in [2] and [3], I see that we're trying to run a
guest with 4 vCPUs. E.g.:

Name                                        ID   Mem VCPUs	State	Time(s)
Domain-0                                     0   512     2     r-----     4=
68.5
debian.guest.osstest                         3   511     4     -b----      =
21.1

Isn't it the case that a guest that has more vCPUs than the host has
pCPUs is conceptually wrong and, even if it sometimes works, prone to
(heisen)bugs?

[1] http://logs.test-lab.xenproject.org/osstest/logs/166964/test-armhf-armh=
f-xl-credit2/arndale-lakeside-output-xl_info_-n
[2] http://logs.test-lab.xenproject.org/osstest/logs/166964/test-armhf-armh=
f-xl-credit2/arndale-lakeside-output-xl_list
[3] http://logs.test-lab.xenproject.org/osstest/logs/166964/test-armhf-armh=
f-xl-credit2/arndale-lakeside-output-xl_vcpu-list
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-FYXkzCRXQcUKn0O8fuKJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmGoo4oACgkQFkJ4iaW4
c+6vNg/9G5glysrF8qo4TNGWVYvs3QtRu8ob/rwm6XjX68ByXPHnwGgrSCbtivvF
RgzUQv3RsgcyNMTYBQhwDA31fOELR023YBPMoX8ijS8ADmy+wnwmgCjn43Z4HQz6
x/DSsD6aBTcGAsDQXCyHGD0LG4mo9cFYgXis7RZqV7jiE/jIj3iPGOjsKc4NzSl5
3l+TYkoa+BPO4Wk3qQLWl/CilnK7Cz7UQbUhB8YDbvvePFJS1hKw7NagWF2nPa9J
vYweqGGTPbrK+022B1FXnIrcBKjnD/CBXZKgJ3CHGlpR6yjHE6hKk+p19jHISoqc
XyT09FuP0iqVbdUsE8UYfzOE/yY194M+2I6HYfgFhPSMrICXQFIkNhM45J30B6b8
CpkKApcSS1ncQmOg5DOlBL/w65sq0x+aHjBUGcozSdoQXdoJoO+bfNxct2kYrq7A
uTH6bFIH4twce2GJBvq7hzCP3ikC53pR25xq5JEr5bWxhH6maAFA8/7cujkboekw
9VCHYzfWiWZr1l8vY2ZnHOATHG9ExnxXQXAZ6hzIioIpbYjxqTMtgTX4+cUfzoDa
oQrezJAsDjaMwlk+b27WLSi6FB2B4RBJ0whWRYQBT0U1HNHKdNzR4otQrC+GkpAI
vxPHEQDHX4Rzc81Tm5n5A8QyQK4bSPJP5BsJOBA9zsu+dAIhr6w=
=o/aX
-----END PGP SIGNATURE-----

--=-FYXkzCRXQcUKn0O8fuKJ--



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:06:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:06:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236477.410214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjuM-00053x-JD; Thu, 02 Dec 2021 11:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236477.410214; Thu, 02 Dec 2021 11:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msjuM-00053q-G6; Thu, 02 Dec 2021 11:05:46 +0000
Received: by outflank-mailman (input) for mailman id 236477;
 Thu, 02 Dec 2021 11:05:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1msjuK-00053k-Ps
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:05:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msjuE-0007db-W3; Thu, 02 Dec 2021 11:05:38 +0000
Received: from [54.239.6.189] (helo=[10.7.236.17])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1msjuE-0004T8-Pk; Thu, 02 Dec 2021 11:05:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=s7sTD8TxLfHKHlZjLn8Pk2IGql0axUbDITPRbB1SkeA=; b=kLp7ylgHZmusa2B5VuH72Awb3b
	gF0FzOKQ9VoTghs22YPXEWs4x1F7d3Ohdm3XN5LIunWGYZ3yOLHZFpfnxarI5YKWKw5Rs8WSPUOKM
	jJs83Er/w3YnVvj8qHKghJy2tHCLan8TKPTtMyMS2Pk/vu984jONDpS5hZ0C9Rs+CRrA=;
Message-ID: <0a99add9-da28-a116-e859-5a713a7c7f43@xen.org>
Date: Thu, 2 Dec 2021 11:05:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from
 gnttab_map_frame()
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
 <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
 <09847780-10b4-5b14-b15f-d82597fa8b3e@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <09847780-10b4-5b14-b15f-d82597fa8b3e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 02/12/2021 10:12, Jan Beulich wrote:
> On 02.12.2021 10:09, Julien Grall wrote:
>> Hi Jan,
>>
>> On 13/09/2021 07:41, Jan Beulich wrote:
>>> Without holding appropriate locks, attempting to remove a prior mapping
>>> of the underlying page is pointless, as the same (or another) mapping
>>> could be re-established by a parallel request on another vCPU. Move the
>>> code to Arm's gnttab_set_frame_gfn(). Of course this new placement
>>> doesn't improve things in any way as far as the security of grant status
>>> frame mappings goes (see XSA-379). Proper locking would be needed here
>>> to allow status frames to be mapped securely.
>>>
>>> In turn this then requires replacing the other use in
>>> gnttab_unpopulate_status_frames(), which yet in turn requires adjusting
>>> x86's gnttab_set_frame_gfn(). Note that with proper locking inside
>>> guest_physmap_remove_page() combined with checking the GFN's mapping
>>> there against the passed in MFN, there then is no issue with the
>>> involved multiple gnttab_set_frame_gfn()-s potentially returning varying
>>> values (due to a racing XENMAPSPACE_grant_table request).
>>>
>>> This, as a side effect, does away with gnttab_map_frame() having a local
>>> variable "gfn" which shadows a function parameter of the same name.
>>>
>>> Together with XSA-379 this points out that XSA-255's addition to
>>> gnttab_map_frame() was really useless.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> As discussed in the thread, I expect the Arm part to be simplified after
>> Oleksandr's series. So for the Arm part:
>>
>> Acked-by: Julien Grall <jgrall@amazon.com>
> 
> Thanks, but let me ask for a clarification: Explicitly just the Arm part,
> or also the common code change? I ask because from the x86 side I already
> have an ack by Roger, but strictly speaking that doesn't cover common
> code.

Ah, I thought Roger gave a reviewed-by and therefore from the check-in 
policy be sufficient. The common parts look also fine to me. So feel 
free to extend my acked-by to include the common code.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:29:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:29:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236486.410231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskGf-0007wR-G8; Thu, 02 Dec 2021 11:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236486.410231; Thu, 02 Dec 2021 11:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskGf-0007wK-Bs; Thu, 02 Dec 2021 11:28:49 +0000
Received: by outflank-mailman (input) for mailman id 236486;
 Thu, 02 Dec 2021 11:28:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mskGe-0007wE-1V
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:28:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0363f8e6-5363-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 12:28:46 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-dZFyUQVxOn6enhfELvDVYQ-1; Thu, 02 Dec 2021 12:28:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6384.eurprd04.prod.outlook.com (2603:10a6:803:126::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Thu, 2 Dec
 2021 11:28:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 11:28:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0139.eurprd06.prod.outlook.com (2603:10a6:20b:467::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Thu, 2 Dec 2021 11:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0363f8e6-5363-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638444526;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=As8Rc21Rac+oaa+5Ny4M3duxYQkygiwB4vmSvtH+e1w=;
	b=J+94XsNgFoIeFXrxvb4I0Ul9mScIUQooeh6XYHD2dUvjUIxICskllR0GNdDXR5WeyDCa3F
	ilKaubv1VF4OUSeM2ma2gfsZi4Xp3n5ce+UShsNE4nrRy/lxXjx5VWay76o53u8yhDgVTY
	YAqtX6FrqaWScqCbAbqyNA0DZD6BrxQ=
X-MC-Unique: dZFyUQVxOn6enhfELvDVYQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gh9sQ1RvvQ4U+PwEE9IeXuZUyV+JIbg/KhIb7Sbw1R7WCj+ZF6qAgX1MKAnB0E0Uw32lxygxSvPW0qAN1U7NCR6vIvXGtOICdjTJtSFvy4aUpg7ll9Mu7gkjIcNsbSZAOzfKoeNY7QUfZPN1SgKKGTK3e/nGZ+KEKZVF2ctlp7V8YBfGnsmLC5/LnagyW3yD1xllYODGis3GCYR9/R7kmuGE4DNmha5O8z1HsPpV2CLwpZeHzFusB9qwJnIB9Ln3YFcN0y5NVivISFIUKgRuScbckvkSNZIIzouSwOhQDuofigTNmJxcdZnWKcWk//LN3EAYJ904QB0MrRfPuVVjxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PfMUgWkwhuc1Awis3HnVZ7TrZivKWDi3kMQnxfLnlS0=;
 b=JTjXyR91w8GWrJWEGr40rawhZ3pw+eSq7rmLHCYC2IZajfc+A1D3Ar39nYxf52T0PVPoNw1ukttM3F/ojxO8SmMk77OktHRiHPEgTsbM8Ox3XhJtCMlkc5J3cuWZnBEG/HQu2NypHxDmh6lEBappJ2FgVm4ac5LWUP+MrXt770auxBD8Tr1Jnfn1EunF1qeKQPdfqr/3xxqXMXnx/IABtoN/k1g0+5OUgCbRgVIl4wc+Rbw1S9u2KSmW2qzXKlkEgn6hllmtdVtG2JR5cXHrUowHKjZcXsZ/+Df4Y94s4PIOZEvpLhvrZCEleqRhI2q4EgLemnoZI1CYMBbKngFM9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d90a40d9-eeb1-5c76-3beb-31577e37fc4e@suse.com>
Date: Thu, 2 Dec 2021 12:28:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [xen-unstable test] 166960: regressions - FAIL
Content-Language: en-US
To: Dario Faggioli <dfaggioli@suse.com>,
 "osstest-admin@xenproject.org" <osstest-admin@xenproject.org>
References: <osstest-166960-mainreport@xen.org>
 <ec11daf7a998ae63c9a34578ec4224bf900232e3.camel@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ec11daf7a998ae63c9a34578ec4224bf900232e3.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0139.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3a9d68a-33f7-428b-9b12-08d9b586e43f
X-MS-TrafficTypeDiagnostic: VE1PR04MB6384:
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB63843A76601DB466067D6FECB3699@VE1PR04MB6384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ClwiioAVVL3SGVdRChLmfgyNxRiD/kUQbRGNsLXouG0yJoFnnNEPW3ZhRpSDa7jXqShQ58sVH8KTh4dG2BOeXhEvsIWd0M6vBWuUEUWMyEdK5FLnpJRA+xmNQerpfqaSeF6SLOUP1VhKUcYvCsaJYZALH7ovU8GlTZnqUU6cJASMFgrF/DqTGSS4x+Nfh8kvX3ArPFZriXXj4aOIBo8xh84SKlCTM8cKKXNR2XgHA58vBMpKIlsBVq/P+VJd17mD/aRegDN0zK2QOP4kN9tAwJ61wTE/h0GFku+WSQSYVVC2uMD9dic3ar4g97r+cvSATCc9VQsBTbr2D91HIRCspXo2CddLpozw34cafaFF2ObyY5QofWHko/TzP57pIDYm4PLmPJCagbnZ4BlwiaN9w3rdAQtQrxT77A3x3bHxJTdYbZaCZkJjRCgvvPJUxvv2H4p127vaHTBAV3M/ih9Rb6J85FJU6ojNACDrXihW7qE1F8eVesO0mdn/nsCSrApUizT7tVYUrObGEA4rpn7A8DZOywYJppUa8zjVa7GPrmSzcMBOoIgY7Z9OLzdHUv9R8kNYzuO1sGg4zm/Xtv3oY/Ju+yb35U0DWBnYHfTjLFlM01qbFt7GiTzP3DH/2PO6uNar8EmaH3LUkchMQ3Np18LgKJwxbu68GVB6ez1BgIMV6FODAKircU2byQ5TtmzfDoYr18yL8Mw6eiqJjykBTI4V8sjpw2Sqzp+aCYQbJg0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(83380400001)(4326008)(31696002)(5660300002)(31686004)(2906002)(956004)(2616005)(86362001)(38100700002)(110136005)(36756003)(186003)(6486002)(66946007)(316002)(16576012)(26005)(66476007)(53546011)(66556008)(8676002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gEcSVB2e/0FDGHw+g2SpI1de3ukTrEK6MjacbqkSwOLX8slAzCnXLcHbBpYZ?=
 =?us-ascii?Q?K/Ote/i1f1qjtCgkC7zbN9+wvCd2UrWRZb4g1ekhc51hwXxOW0j+Op1Wi66W?=
 =?us-ascii?Q?ksp8Liphy8GPqv/L12nTgo4rvqPw/z6hwKlzdMnGTMaEW+ivXMPVlOkP6jeo?=
 =?us-ascii?Q?u2J/fSgIEiXn88yq0O/sSRvq0vtZP4sy0+HQSyNWdQ1shK442OUOSihT6qU5?=
 =?us-ascii?Q?HJmRlEdSju45AkYYcmHEODpuL/PM5C+ncPG3BmsbbEAXcJrmLztGSoXXEeHY?=
 =?us-ascii?Q?n1Vb0BjukIF2U3CLlAO5FdXCjzC7zuiColkmsqbPgMLO/Jz9fEzw0wbhFLC0?=
 =?us-ascii?Q?SC6a3s2CFUNIJLVTvusMoAzGDIOngH0brdb6Fqi8g8wOBI+rWNKoejzZ0Suu?=
 =?us-ascii?Q?R6espdDrUgx3mrlAjWtBwDUsbvzGa+h07fujJjWU1j/Jgic+4zKbAOb+sXri?=
 =?us-ascii?Q?p4CFd+x+15UmPvsLinaXFFuj1GO6l98mRfFHeRw48AFK9L7n5puHXoNbtcYU?=
 =?us-ascii?Q?VEI8n3oTH5dRs+jETp1gZNWY7/QFHHF7H02NjjyYc7JntQwigWXo2hCDILfS?=
 =?us-ascii?Q?Bc44r2rHp8QE8HGIX/9EprBOT/dRTSdpNB4AFNR1eDgMMG9mT2a4rMp4uVnM?=
 =?us-ascii?Q?Uz2DjJLQzuujjM6kWs+RgPU9N8CmMgW64vme1IqAI/12CLhJSJ02wGTQvsq/?=
 =?us-ascii?Q?+ZLug44jS2aKiN0eTv8uIKDBJ/TmjVIt4/O637Kf8ZK7BEdwED4knijasa/+?=
 =?us-ascii?Q?T3MqAXi5C7FWmZ6QN+EmG9DTffUWYuG8RasJj0TTfHrLa1U+DRvR92xNZYHe?=
 =?us-ascii?Q?nU9mxqWw/RB/P8xtJMPp0kiC4aILelNzSCsnKILgpjxz9CACpjewVu8n9QwC?=
 =?us-ascii?Q?ezaltNd2PGHXIXujUB4/GU4Wj8GPKXegHXqUGp0mwFBlcMu54DjHPJ+yHy/G?=
 =?us-ascii?Q?Swv14OXmDk9PpFUNAiAljgR4fgWxt8Acd4C/OIP08kHQYD9J+ZvgNlSJdg50?=
 =?us-ascii?Q?1oQjbz1qm5rvxsc9fw/oJ0ZenpXSGu34heXJsEq1TXm/n61lj3qHHNhFP9PW?=
 =?us-ascii?Q?DIuySwTg9spt3u0y0q3VzaMqh9zmP/UwWOoouuCKqKQQfoa44pxSq+W2FV/r?=
 =?us-ascii?Q?/choGFLU0tKGk2c5fLi8FVz25NmF4kHWYm/n7To/t0YTUOgH0MshI1p4yw2v?=
 =?us-ascii?Q?+9VGCtT4UjtaeuaZIygSbjYO80FflU9FV/sSV8KJAFK7uQrJok/ginanQAyd?=
 =?us-ascii?Q?mtL/ZTmrMxBYwHFv85/YHNiXGvA+ioEmukAGmfTUr2x81n1wcQyBPoiegSuz?=
 =?us-ascii?Q?aKs2anTkM9rT3PJFxam9uSAAFELtRZMCQQmMc19+XSaZdZig54sSkWOZajRy?=
 =?us-ascii?Q?zvcvm0sYw4uk8u3067PMB5AkpkPsLTUtoVKwGWTe0LTSQgEtNhXG6TOm7mcz?=
 =?us-ascii?Q?pU3NuHR9wefNeD5/QED/NkIaAwSat05pTXe4Nl7xwrLMWopK39A1/TZYADOp?=
 =?us-ascii?Q?t5twfs1yT+R96jfM7/fGDZGKwpIfTpxrdeUfckNh7yhFzefv7qphuc7Zt4iU?=
 =?us-ascii?Q?JoiKEr7s/40ulo5ly9JM9h0Cjitdms0A6WsriqxugSI5GxaEbekmz89xCwea?=
 =?us-ascii?Q?+10ZjSewBBFKAG+iAwVrbDM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3a9d68a-33f7-428b-9b12-08d9b586e43f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 11:28:41.1123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: buqNYEXtzu5mz9N/fXnngjZeOeRpPx+MgeKhSAG1oNg2fmBXpgqMYOOYqCIeO0uNepbfMyK8JQhJgqkLS65rnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384

On 02.12.2021 11:44, Dario Faggioli wrote:
> Hey! So, I noticed this osstests report and got curious about one
> thing, which looks weird to me... If I am missing something obvious,
> sorry for the noise.
>=20
> On Wed, 2021-12-01 at 05:43 +0000, osstest service owner wrote:
>> =C2=A0test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail RE=
GR.
>> vs. 166941
>> =C2=A0test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR=
.
>> vs. 166941
>>
> It's about these tests above.
>=20
> In fact, from, e.g., [1], I see that we have 2 pCPUs:
>=20
> nr_cpus                : 2
> ...
> cpu_topology           :
> cpu:    core    socket     node
>   0:       0        0        0
>   1:       0        0        0
>=20
> At the same time, in [2] and [3], I see that we're trying to run a
> guest with 4 vCPUs. E.g.:
>=20
> Name                                        ID   Mem VCPUs	State	Time(s)
> Domain-0                                     0   512     2     r-----    =
 468.5
> debian.guest.osstest                         3   511     4     -b----    =
  21.1
>=20
> Isn't it the case that a guest that has more vCPUs than the host has
> pCPUs is conceptually wrong and, even if it sometimes works, prone to
> (heisen)bugs?

Imo this should conceptually work, as long as you don't go too far
and as long as the workload isn't overly timing sensitive.

The debian.repeat step has first started failing on the full staging
test, but this now has extended to smoke flights as well. I haven't
been able to spot anything in the logs ...

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:35:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:35:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236491.410241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskMp-0000u1-4u; Thu, 02 Dec 2021 11:35:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236491.410241; Thu, 02 Dec 2021 11:35:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskMp-0000tu-22; Thu, 02 Dec 2021 11:35:11 +0000
Received: by outflank-mailman (input) for mailman id 236491;
 Thu, 02 Dec 2021 11:35:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Uf4i=QT=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mskMn-0000to-T1
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:35:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e70be536-5363-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 12:35:08 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3E501212CC;
 Thu,  2 Dec 2021 11:35:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E102D13D73;
 Thu,  2 Dec 2021 11:35:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id BORrNWuvqGHZBAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 02 Dec 2021 11:35:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e70be536-5363-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638444908; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Q9lW/nN7TCGwUiXTqSQd3toQz9Va9mjMsSb3SOsS+oo=;
	b=X8+p8km7HhD2c5M27zW7ABYsUIj5v15Lm6tv/2wWmiswGhgtn6PN/g7w1ShIfjurJt41UE
	pLtfV0Qi2HulNHjUvsZugOwqAn2VXFcvC2K5hLwJAFLIZLF1iXlT4L2NNg+zWUDYwqN1+a
	DgDm4NRkKC0EAqPJILyAhZtddqigMWg=
Subject: Re: [PATCH 18/65] xen/hypfs: Annotate fnptr targets
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-19-andrew.cooper3@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <7d6d0124-6fb9-f081-76be-0d9ef6a651a3@suse.com>
Date: Thu, 2 Dec 2021 12:35:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211126123446.32324-19-andrew.cooper3@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="baYT6Htybanyi0pmp5wEgo1tjTYd8Ihqr"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--baYT6Htybanyi0pmp5wEgo1tjTYd8Ihqr
Content-Type: multipart/mixed; boundary="rLxmBCQZDkNKNEPmEtEMOVZL4kFQUkeAy";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Message-ID: <7d6d0124-6fb9-f081-76be-0d9ef6a651a3@suse.com>
Subject: Re: [PATCH 18/65] xen/hypfs: Annotate fnptr targets
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-19-andrew.cooper3@citrix.com>
In-Reply-To: <20211126123446.32324-19-andrew.cooper3@citrix.com>

--rLxmBCQZDkNKNEPmEtEMOVZL4kFQUkeAy
Content-Type: multipart/mixed;
 boundary="------------634FFAB81432C4DB24CD2962"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------634FFAB81432C4DB24CD2962
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 26.11.21 13:33, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Juergen Gross <jgross@suse.com>


Juergen

--------------634FFAB81432C4DB24CD2962
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------634FFAB81432C4DB24CD2962--

--rLxmBCQZDkNKNEPmEtEMOVZL4kFQUkeAy--

--baYT6Htybanyi0pmp5wEgo1tjTYd8Ihqr
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGor2sFAwAAAAAACgkQsN6d1ii/Ey8I
dQf/Yqw/muwEbbmSNH2Ymmxah5VSOyh3JpVOrQiiEwupmcL0VHmyHWS0kIZ5Pi537+58P55F2eqe
eV6Taoz1CTFd7oaWvFeRMAAHisLMeX63Id+4PLbKLdR3dAWSlPEtWCQoBnBoDvJtMDizZfgw06Qe
tHovk2KxusU26fT0BkHWNXASyUtJw/v768SsKjZcOaUBv9gmxajl0+ek3ReP9KnSoZfFUSdUrFEP
P92PuZFTNV6MZUSzot/FnVR36qlcpu4q93VKx8Lg888C9jIEIe76fEAvUBrtSse1B3QKp/pHa4NY
aoeRkflIa29vJULm/zQfkUa/9roJsoU7V7diSsW2xQ==
=K1DV
-----END PGP SIGNATURE-----

--baYT6Htybanyi0pmp5wEgo1tjTYd8Ihqr--


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:43:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:43:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236499.410258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskUz-0002WR-0o; Thu, 02 Dec 2021 11:43:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236499.410258; Thu, 02 Dec 2021 11:43:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskUy-0002WK-U8; Thu, 02 Dec 2021 11:43:36 +0000
Received: by outflank-mailman (input) for mailman id 236499;
 Thu, 02 Dec 2021 11:43:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mskUx-0002W8-G4
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:43:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 146e225b-5365-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 12:43:34 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-PeT8LZw3MBuyC1QssxjhOg-1; Thu, 02 Dec 2021 12:43:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 11:43:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 11:43:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0008.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Thu, 2 Dec 2021 11:43:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 146e225b-5365-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638445414;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x3+bPm8UyslSnyMghfZbGu7oXLBj5fRK/MtlKXWaq48=;
	b=b9o9NxNuMnhMP6C3w4VfWCjR75COS0ooQkaBfIoO40ZzCcmBCJ9iyYBVhwaeY4N3g/RXW6
	vUq5h1nBKwbGQDVMFSZq6JLaXI4Rh3u6yg+HdZayWTC0SHX6+inbgTuqHZTPj6H4I3uxsw
	VViGWtYVegC53aqWRWpO9/KoQiyzM50=
X-MC-Unique: PeT8LZw3MBuyC1QssxjhOg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rs8/RxGicsD0ZynwrjqRW1cJl3i2hT40MCge3u2smhsMeewR50acMk/2UwIhiLtgbPdJEPFrXGdF9sF/YljUmedjm7YXSOq2MC3ZZjAgJ1LyLtGU7riXz0q1p4J5en4UDvyzKBkEJpTcTYRYpl7LG7++hsgv9km9MR+lH8aLxUbLRHc6Y96kUXYLHU1TFFInnmyhJ8ipWzhBTmo0AKNYhRX9IOkPXyfR1OW+p8KwaDcHRfnyZoVY86dnGcMe9zgrWf0cbm0EnP+8jySZh0u3tCqxekn1F9yp/ClWc3HuahCnhKB5h68xbjjZJO+pxC3rm45yG2xq3bevjYoCpUcrow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x3+bPm8UyslSnyMghfZbGu7oXLBj5fRK/MtlKXWaq48=;
 b=lbndC3gd+eXSU+Ojlcver051U/sW/0cPuBGxb9yNxWpJNmGaCFDrE8A4+pCCYHx7m4FHkjQ7ooixqRJ/kYzWAhzkDf19hg/GbsQ4kPoUDRgP6Ate1rri0t/CxmJWOx5rGMMPMkgxRF5TNJOpHfRlUbqwm/tyuTnixavYRgjoeCFhwr+iU6S+V4jbqk7Pzou4lO0ngQ8iH5tpbc9tnw7+i8zimwtoGbBAYtGTR08QiaxwprI9BJcT6lTA5/1CZeWtGgWsYGVpIOGRcqmss4agEz+U0NDbhZxrxS//ydg9l7cGtsnFTBzzxHTtIn4KhfOTwS4opqzAEqZk610Wiz95lA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cf2cd306-0dbd-0324-c85f-43f8f7f2ae81@suse.com>
Date: Thu, 2 Dec 2021 12:43:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/8] x86/boot: Better describe the pagetable relocation
 loops
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0008.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 80926bf1-06bc-4eaf-fefe-08d9b588f6c8
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2335D0ACA3333BC8BC3EFEE7B3699@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PivIr/xZ8i/NhPdGT9PjpRSlFs4L7nIcsOEwlzAiSkD0dEYUIdlTtIfEXMvFuMOEtZ40kJHMCnG4Mj9EMK97vn9AGMJLNYhvDwrOQ033oonmgroaqeXQL5t+S//kl8n6b9TiHUvVTpYhvKU42lAWISDwRkqaJrE99IVXSmNm6of1gAHhsUcAdy4r+J/n/NkO576g9DYqTYkPVtW5+qgz9VGbJh4yV00Ddu/JDzab+LUSIP5Y/G+obz/ptb7IuJbtTbflk9DlUNSrpEWZ84QzPGdV3ZQxVI9im33X8m7Z6UefnCPqS6dNR63KLu46x98tF5WLv241dh+BzCFgBv8jOfcGmd1irRLN0SC4sUhWYs2V6Xv0HrtafKd1syMZOFdp0sEQ+NeqHxfOLQAKd4p402zVXbR+QX7+b0YdbIYSadD9VmSvLltDTd2r14A/3EUdYdIkvDos0uMq9yUaMA26V9Sitc9e+Afb39l8GW2pIZt5/sCqxw88t2zLQnZ0N6qFOnBRQiyziBNbL74ucJIqtxAGaEOGt8c5fJiomRw1EKqHSehbd49aqakbV+7feaIi3oveFbkcXbKF2+ABNjwzBdAVJMjAVjtjcjJB0qaGPi8LfoRLwAId97mVbbposCOcPDYZ1ebxjNah3t4LW0cz0M1LDIN8iZja6bAIlRyF3OQusdI4ZJT0LzeuhwvJ33MXMhaMlSyqinR/i9EcHy2Esn/kZva1ulWKt3MmKYyT/+09XsN7Z20RZocn3CBwf0Gv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(316002)(16576012)(36756003)(8676002)(66556008)(6916009)(54906003)(83380400001)(38100700002)(31686004)(186003)(66476007)(31696002)(956004)(2616005)(5660300002)(66946007)(86362001)(4744005)(4326008)(26005)(2906002)(53546011)(508600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXg2b1VXVm9PSjZ0RXpMNG13OU95OG5SZkVONjV6aGV2dXVHNEsvcFMzVWl2?=
 =?utf-8?B?bkhHdGdCQnU4S3BxZFpINVprNTU0Y25LVzdNWFhOMmxDTzVHV1JxL0lNMU9F?=
 =?utf-8?B?RU0rVVQzRlh3YkZJbi9QVTVnYnlsdHQ2WUVHazJDajF6UnBVVDBEb0ZZM3VW?=
 =?utf-8?B?dUJJSEJUQ2ZGeU1nRUEwd2lPYjR2UEY1TC9ONFhkUStiYWRaQkc3cmZLdkdq?=
 =?utf-8?B?cGUvY08zamdzVmx6TXEwLzc3dG5EL3RCUU5zTXphTlNCdFlKc2ltbzA2NVN4?=
 =?utf-8?B?TXIxNjJRTlgzZ2VIRzd0SDlEN1R3T3pOMldEUmdvNkFyS0crVC9jR2xjYmhM?=
 =?utf-8?B?SXBtUlUvQjFmSFNsVlYvNStXTnVpUUhIMVFLK1k3bnFRNHMyTXM1YkU0azZl?=
 =?utf-8?B?cTJpakloa0gveUxLNHlZKzVFbUdRSUwwbThWZW9MR2RWMXIzVnFiSDJiRHhr?=
 =?utf-8?B?SW0zdWhWK2NDNDlYUzFiWjV1UXNRelVNbmlRRWJFUm93dlhiQityUlUra0tF?=
 =?utf-8?B?bUxuNEZ0bjJyb2l2VTYwSzJhaTVHVkNQbFZrdlhGN3hJdnNuNTI5UTdZallp?=
 =?utf-8?B?T21XQUJlMENnWHNkTGkvRkptdFd4b0NwVTFrUnF6a0JRdE44cEVNMWJnN3RZ?=
 =?utf-8?B?UURYRVZkd1NxL2pUNW9Xd1B2c3U3b25xbU5maUhLTXBJNHdvNjJOR0szRHcz?=
 =?utf-8?B?UDJJUWdlSjRaNG92b3JpN0hhSDZuMkVqTk1MV2s3RHQ0b1VaN0xkalVJUU93?=
 =?utf-8?B?WFRHVk8yVXlNOStpVmdiWnkyL1dSUmdTU0VvT1V3OU1Lc3NseEQrVWNIZkNt?=
 =?utf-8?B?d05QeTc5RHJxVXR2S3k5L1IyLzdFbVdubUNxUjRDaVV4UUx6R3pkQ2QxdUJU?=
 =?utf-8?B?MjZrTWRsY04reklkU0V2aHJjOVpHMWNMYVNDVWY0bVJLYk81U3ZYR3RMajZG?=
 =?utf-8?B?WU8zZUp6a3ZGM0VCVEhNUWZXUGZEem5nYi8wOEJNM1BJTkF1d0JGb3pRdWxQ?=
 =?utf-8?B?bWptUy8wS0VJd1BmMXN1K0RjYW43NGw1aFFyTm1sSnEra05ITEZ3VU5OK0wv?=
 =?utf-8?B?bldBR0thTjRLVXg5Qlc1bi90RXNqUnNxQnBXdnpsTWg1NTU3cURqcTF0a0Ja?=
 =?utf-8?B?OU9tZisyYUREWmhjb2pkSmVaaDcvWXNnZ3pzU01GdTB6ZEc3SkR6QmN0TmpU?=
 =?utf-8?B?bWlKZzZLYlhjL1J5ZlI2UWxTeWRocWRlUGpvdGdmY0xlU3RvdERDbXU2VmMv?=
 =?utf-8?B?VGIybkw4MGNhOFRFN2NxT0xUWFR1S3hUQUlEUkZPOVdtSi9JeEh4em1NLzJi?=
 =?utf-8?B?czZqVXBQcUF4RmtZdkpmY0w3WitQOENMcFNmOGZPTmpIREgzZVRNWWw2emdQ?=
 =?utf-8?B?QXZHTkJUa2VoK1RNQUZ5Qy9HdVhMWEdNcnVxOW1jbDRwbmo0cEJxL2w1eE10?=
 =?utf-8?B?ckdMQW1HckhYMW9qcXpSbW9SZXZ2Misyd3NNWEozTmE1U1ljRHF1MStjQ0xE?=
 =?utf-8?B?ck1hNGsvUHhmb3k5V2xNUkNUNEdOa0N5dnMyQ3FJUkJUUFJaZk5hV1JaejQ2?=
 =?utf-8?B?ZTNDajBZYmI3ZE5RY1JwWm1yR1ZtRCt6M1BhZW5NUksyMlF4SHlHQm1xaTh0?=
 =?utf-8?B?WGwvckc2b2t3RmlDRGtsWTJrSmlCRjdUcXErc1BVOXpRd2J2Z0FHanFuWHNz?=
 =?utf-8?B?TVlrUEJtZ0FSZkJYQzFlWVFzVWNnei9NcnhBUmdmVFNmOG9VMmZSUkRseEVT?=
 =?utf-8?B?OHJ1bkJURThodjMyamc4WGRLdmNES3Q5K01XRVZlYVhNa1E1MVM4dG1oWGlw?=
 =?utf-8?B?U1loMmR3eXJ3ZktKZkFPWUdOZ2E4ejROY0x3c2p3U3Qxbzd1SXdidmZYb2ht?=
 =?utf-8?B?czR3Y0F4WlQrUURvRU12NmNBMG1zQ0FhSFNDZFl6YUdUa0s5c3BHcE9vY2xk?=
 =?utf-8?B?SXZCWHlJOG5ETmwzaTRENjhDd2xQZGRmWGNHdSt6OFU5QmoyNktnaytVSEoz?=
 =?utf-8?B?UHA5RnZJdGw4ZUZLdnY3RDhVeDBYNkt6TUg1bklIYTF2dllnczJmRlVtTzR3?=
 =?utf-8?B?cVQ0dGtCZHltTmViM1FxamtXcTNXRlFNOVk3UWpjQWhCQjBvR2NXNGM1MXFF?=
 =?utf-8?B?MWorYkk3RkM3cU5IUVNybWNiNjh3djc5U3V1VDhhV1JaSlhvSXBlZDJTejJB?=
 =?utf-8?Q?mDNGT3ADv+2y9Gzzhv4hP1U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80926bf1-06bc-4eaf-fefe-08d9b588f6c8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 11:43:31.3131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DHHiRJIQhnW8fRA0xLkUhFEWeCX9Tgsgu8ZefjdHe70o3fTdFaWToKeVcMEm61aaoz1ZOXaqgn6/DK3e53zs2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 30.11.2021 11:04, Andrew Cooper wrote:
> The first loop relocates all reachable non-leaf entries in idle_pg_table[],
> which includes l2_xenmap[511]'s reference to l1_fixmap_x[].
> 
> The second loop relocates only leaf mappings in l2_xenmap[], so update the
> skip condition to be opposite to the first loop.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:49:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:49:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236506.410270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskaP-0003PQ-MS; Thu, 02 Dec 2021 11:49:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236506.410270; Thu, 02 Dec 2021 11:49:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskaP-0003PJ-JL; Thu, 02 Dec 2021 11:49:13 +0000
Received: by outflank-mailman (input) for mailman id 236506;
 Thu, 02 Dec 2021 11:49:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mskaN-0003PD-TH
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:49:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dbd57d4b-5365-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 12:49:08 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-5NJi43zbNBy6gg37VQ3Icw-1; Thu, 02 Dec 2021 12:49:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 11:49:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 11:49:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0056.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Thu, 2 Dec 2021 11:49:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dbd57d4b-5365-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638445748;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Vqa1QaGYbNFu5AzPmjdvaUHMTfQl02z8cX6ZFDKPAVM=;
	b=B9gpDumhxlJLpiifUTWiG92u8wqhu1jmQv9jzpZmFRyOmYGPY7llRipThOyXwXCzomYttu
	2r3hFmPjjt9pQe98xl2f5m8UceiA1xBkkP9X8DoouVUg/N3Zyz4oxIQsWjrX3YlqGkF96w
	KoZ7jBG89nX3mGROUbnsnhburHDh/38=
X-MC-Unique: 5NJi43zbNBy6gg37VQ3Icw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nbTcz2nUeqy6TUvPt7xFEI5mJLrwE8ii1iOzMvMnKsq0jHQ8tZ4yMiVymzxz0VzfWglO7sz8JXvzQAr3fxXYL5U7olersyGA8UB/FR7XZOhIOSyn2MSuPjcn2EnuLp/jZkOPRXQdg1Nzm21AHmvdI/kDhE541HhWHnJwq//OYJI6WA+ccGoFTODK8uEWwpb2OUj2Pw7gCYzOAd3Rb0Pq72rnPfCIwFGsHLriwV1BGPc8y5ZSgNzIp6R9EfulZUTyQ/DEbNbPGejW7RwieeAIqmOfnGFzMTEF/pk6sk6rhVm+nFJ6Xvw5f5YTaHR5x4qA4S4XK66CSIHEHJ3XWAWUGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vqa1QaGYbNFu5AzPmjdvaUHMTfQl02z8cX6ZFDKPAVM=;
 b=dEheIqelaCm3cEE/V1f6QhbODGMvls0vU3DelRaMwZckhG/5t8IXCk05nusyteufJWFhOcROHwbOAGO9CS87glRmsopXzdhgT75pqLr02MX2UqW2ieIaTqa+5wzseYdDthXJotDY5BGQ1eKyZBpW7wy1MkGqsvdCwNHKCH88AAh1PK/MQh5iEP1YPoT1LFghC1mtOgUdQkCwskn0dAGaaFf++zV81Uj867JSq6e++OyU/wpQQKQAJ9XNro2nmkNx1CLxSwYOaDZP9Vjt2lkHMJUKiTH6KjCskdxwHHSHQ1RNxflr2zimiec4o30dHxn2SXI+rEd89o99OLJGOGv3Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4615dde8-fe24-020d-0432-6935e9c0c9fa@suse.com>
Date: Thu, 2 Dec 2021 12:49:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 3/8] x86/boot: Fix data placement around __high_start()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0056.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97782daa-f5bf-4b8c-296f-08d9b589be19
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174C9A29897736720D4FF55B3699@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lGDU3PdDu9H2IG4Bk4HpeHgKffI+k4mqbhiC6JL/JE1XLuvNgyI+fyZo3K7fxgKLOwqOzAXBKiUclcohHNCtGl9czE4YaG2MK3XOiHJrFeNP29Zol0UZ+2hJLLEUvl5ERSn5ROvoFUlCXrtzr3L9GiwaqWaBFltf8wVewWk4nAoqTUCldTogDzXuD5fTkRIPN2PABG7a5astT8LUJyQDWDqb0wtpd8dvp6bI8nFgvm/yxukpjTUE7nADE8WgNn/GkrGBE6OdE1YmsglrBkgWYZ6f9MWx/weV6ozDJ5S2eSSyLi5pbM61o7jnzhk4o2+MkiDkz5MPnrzSbaH4mbeCpJ/Es0dT0ecE9c7Oo7sUt6t67hJLVc+Shbk1gjh2XAofIoxdbjKEtgDczkji2hwqX9DIWp83lXCMoytHFf9e7wjalKPxZ46Yp+u2IXaIMb3O8YCVewPPbcw/B1xKYlOH2hfuJpc912zK4NYl0g1N8a9lfF1yR3TomDCPI+uQ+1/ApjdWw33/HwBp9r6ZkXXlRGnJiVyIf6JV/zIG046VDaI13aGBQbcN6c3tIb5NhUlYWLbiV6NaWiuzTw0nAI7gD4es3CeEHvREIfmM2r8y11MM9gYE8B9PvfkdZhcHycbKASytNsshOByi0XHGZjDhL+wiIys5NT56qb+9kYDsmrf143L08TdgK3LUKG6xG8u8l83gyjpFUXGDlQPriPvsdpM80U4wKdlw9Keeg/EVGQenjkIutY3lVJdBX/TPJK+/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(4326008)(2906002)(31696002)(36756003)(66556008)(8676002)(508600001)(2616005)(5660300002)(66476007)(53546011)(86362001)(956004)(38100700002)(54906003)(186003)(66946007)(6666004)(6916009)(316002)(26005)(16576012)(6486002)(4744005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWFNZXc0bldQYTdHbnliR3lvYkVQdXk0VjZxUnJmN1QzRUpPZEdWZ0xZVURq?=
 =?utf-8?B?WWVYYkhTN1FuWnFpWlZXSTU5bElGY1pGdGNPTk9IRmtyWmJDTWVkcTFTQncz?=
 =?utf-8?B?MVAxbVE3d3JyeVp1QVhXejhQNTgyRHNpTVp1Q2lXT2Q3WEVscTBJT0VlTjNv?=
 =?utf-8?B?TGQ3TW41Zzl4WmpMUUlBODc1eWJQTllPcCtEcCs1SzEwVlo2eGlpQ2JUODZy?=
 =?utf-8?B?QkVBT2hRQ3pEOFJleEhqOHJTU2l0RGJGKzhCbXZDR0EzWWdEQmhZS3dLWS9i?=
 =?utf-8?B?L1Z1Wm02cWJ2SWtIT0VvTC9lbUxIMkhGUlRyMDRWa2dadmdjNzFDOTNWcURM?=
 =?utf-8?B?WUltRXpuU2pUb1VWU3BQbTJONFJ3TXhFVUZQQ3BENEU0M0g0dDdzbTlzWFNO?=
 =?utf-8?B?RzFBd1MwbUxwczJ4Sll3YXgrbmtmck9FYWYwN0xkQVNqWFhFZzdLTUI4N3Mv?=
 =?utf-8?B?T2pSdnpPdmMxck11L1piM2ZFSWJyaDd1SEdLM1RSZ0poSTd0TU1MelArUi8x?=
 =?utf-8?B?cjBWVmxtRkRnTk10eHRRbVdZWllLdHNvL1NZRWpGS05MTjVEcHNhc2MwWXNl?=
 =?utf-8?B?VTZXV0FySnd3eUFSQTdmaVdOL2ZGZ1FUczR6MkFIcjdUM2J0djRtOE1sMlNE?=
 =?utf-8?B?N3UvVkk2M0NlcGFCY3RnVGIyZ0RQR2IxNWJEV24xZVZoMmhDblhVeTlIZFVo?=
 =?utf-8?B?amZSR1lEUklzOHUzSXhQRStheGJubmVqRGxiSW1odWVKcWpLeTcrVU5pak9U?=
 =?utf-8?B?K0s4VVhwbXBVOWRpaEN4VDlQR1dWUEdwR1pCaXN0YTl3Q09SemVQcFl5SU5y?=
 =?utf-8?B?VzJ0bWNJeUswSEJHdHBmT2JaZXg2bVp3RU43YzJ4L3RGN1VWaVkzMXU1c1ps?=
 =?utf-8?B?cHVIczNVL3N2bHhTSDB5elhLSU9zU3hlazJra0tVb1JXTERxNTRrd3kvRXNp?=
 =?utf-8?B?bklSRDJ5UXhzR2ZGUEdHd1c1NnduU29ZYVVYbG0rQm5STjJ4UENvK2dvUGl0?=
 =?utf-8?B?VnZCSlBjbDZ0a2M1RUJ3anFJVHIvYXNjR0hEUnFYbFBhaVp3WEtkb3BSY3dJ?=
 =?utf-8?B?ZWIvMDZhR3hoaEFpWHBJb3JUWDJHaVhsZjVrVW1GT0MvT3BCdS81RTltRk4z?=
 =?utf-8?B?T2NJSlJiTUN4Ym5MajM3dUhHYk5na3pFd1BqaTdkVHNyTWoyOXF6UFFYRXE4?=
 =?utf-8?B?Sm5VbUFEYzZwMUlmNTk1T2JCU2g5ZDNOZmVQNmpzYm5rWkZBd0xXZ2dMRnpy?=
 =?utf-8?B?VFZnWnlNNDZVcXpOM2R3K0VuYkY4RTAxYUVUZGpDcXkzdEluRU54eWE2a1hq?=
 =?utf-8?B?YllMd3BQck1XekI5Nk41ZGhUZ2VyQ3gxQlg5NE9IQzlyL0hkZS91L0RDOXg2?=
 =?utf-8?B?MzhrMlYzZlZpWHR0MElKWVhGSG9OMXNMWU5SWGIxWTlYZXR3UTZhSUIxdFNr?=
 =?utf-8?B?OWNJc2lXZkVNS2liYzFFVGc4Z1E5UW1GeGtYa1FTOVRqeW1ac0pIZXNWaGVN?=
 =?utf-8?B?WnQxSmNPYWl5KzEzTVVOcjN1Y2dicnprY3h5WGxLVGFvaU0yYlYybVZwb0tI?=
 =?utf-8?B?em9ZNWJVR05UQUZ1eTBHeWd3NTRqNkpPMzM0NVR2aWlKZmxnY1hqeDUvY3cw?=
 =?utf-8?B?Y1B3bHlRU1dEYzZSdUJobHdsRWFTNmt0VktIWmdyK2JUTGd4Wmpla2RidVNj?=
 =?utf-8?B?ZjFmWUpWWHMxaFdkY1B1eGp2a2dtNCtrOGV6TXdOQ043K2JtSUNpSS9zRHdP?=
 =?utf-8?B?UHhZL0N4dUZnelZUa040WTl4ZGJWbGZ0WHAzcnhCRk9CY0JBdW80WXlLeng4?=
 =?utf-8?B?YTZnb3ExUnl2Si8vODNYU2hob0VROTlrOGNTazRxN012eUEvNEFLRmFyTlZZ?=
 =?utf-8?B?bGxyNWV5LzdVRmUvQmlSRXdlV0hZdGMyYmRQSmxMOWFmT3NMeVluYmVUNGZi?=
 =?utf-8?B?bWR2SWM4RzcxamM1YXl3RytGMWFKNTB5YktNbHR3SURYRHBTcWs0VlBkd3RD?=
 =?utf-8?B?cVpQbEU1RXVVRTZZZVFjWVQ4OUt0N2w5c1N1MG83dThJSzhPdWJxYnNRcmJV?=
 =?utf-8?B?TjA5OWlSck1HUlZOSWRIcjBPc090ai9OUG1MMlArS2dML0JXOHU3R3l1aGxY?=
 =?utf-8?B?ZGQ1MmtkRU1HN3BFd1UrK3dUTkJkTmhOaExjakZ4Y1RUbzlZWC9iU0d6djg3?=
 =?utf-8?Q?1G1R99suWtBbpgSv7++o2Do=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97782daa-f5bf-4b8c-296f-08d9b589be19
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 11:49:05.5252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NOVHSGNX45CItcg/aim+DaTde0R8rku8KT9YbWQH9dkHoSq5yhxO68JKvxQAEtH5jWFag2p8EbRlXozNIiIoQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 30.11.2021 11:04, Andrew Cooper wrote:
> multiboot_ptr should be in __initdata - it is only used on the BSP path.
> Furthermore, the .align 8 then .long means that stack_start is misaligned.
> 
> Move both into setup.c, which lets the compiler handle the details correctly,
> as well as providling proper debug information for them.
> 
> Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Nevertheless I'd like to state that defining a variable in C when all
its uses are in assembly seems a little odd to me.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 11:56:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 11:56:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236512.410281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskhH-0004qE-Eg; Thu, 02 Dec 2021 11:56:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236512.410281; Thu, 02 Dec 2021 11:56:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskhH-0004q7-B6; Thu, 02 Dec 2021 11:56:19 +0000
Received: by outflank-mailman (input) for mailman id 236512;
 Thu, 02 Dec 2021 11:56:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mskhG-0004q1-2S
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 11:56:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db10fc38-5366-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 12:56:17 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-qkAkGOU9PB64rEWRvpSWtg-1; Thu, 02 Dec 2021 12:56:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 11:56:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 11:56:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0142.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::47) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Thu, 2 Dec 2021 11:56:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db10fc38-5366-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638446176;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Fip1oEKgQDVzbRYQv8yGd4jqLPdCUUi+hGnXJ1ew0gI=;
	b=B6rH7zJ80E34dPFyLFuoIeNxQZCg2DIKNzdZduwY663WakeCg7iXiYoNKrPNDVSQwgp29W
	OUl14T8k7Yfmea5Otwv2/rB+UBYIpEfG7LUHBsv5RbDDXjCM9JofLR3GiMg+w4lyk/ByOp
	Jo38Wk63G/gDgUcPjhtJP6bdGFCbgnU=
X-MC-Unique: qkAkGOU9PB64rEWRvpSWtg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H8vYNntMpxc5fYnzoZG6J7Yc+NVeKPnoxYNg0+xyqtq2lsYOFsVP+tQSQjZul80jDLSMPBU6U56Gx8qb1uWghMJyqBBqC0xggDDvGsWI8DeE0IpgPN7ATacFsD9Otx9QWQVsfZs/+ZE/QRRv36x4iVydEBMVAfMgQQsFmUn1MqZPXH4d67soc16TyxyifGRnW6Gf0VhNs3laS3uSsColR2pNNXDkwy070aIQvqc8fnW/wkRuXQ96ZXXfbrSkzAQH2f6s6DdHDQS2SRid146ZdByLThRzTZ1zLhbI1xEahQTN0fv2fqwEThP+VjchxbAMlNP/qaq0YbqUcx1csX8T8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Fip1oEKgQDVzbRYQv8yGd4jqLPdCUUi+hGnXJ1ew0gI=;
 b=WjrNru5aaf55dbIzGLkgdx3vK7/xuokVpzX97ray3JjVSy+TG3DsGLciKMqGy44OHQQImHOo9/zhLzJeFhN1LAjUGUOXSH5jl+VD6tlztP0VzIL9hauTAI33tr+Q8sQ8lGGoxYMcp3Z8dTSqX5x0yRcxXNqw5ls7uWVR1sNjqkNvEtD3psMGCr24IP8lWH1lyJ+Latpkh/v3ZTN7xtAN0wcqE0iDhK7QuIJubqT3Wkw2OdRIUaeOCXeHaIKR2qcG3c2oHjNezFyOaALkI2Xhacz6zPgPf2vkdUSWJZCUkIN9ch1aX5aqNGMc39DgRGIhjPegEp5tTMLIjRM4SIvtsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <852a6903-02d3-c167-6cef-3079a6b1c64f@suse.com>
Date: Thu, 2 Dec 2021 12:56:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 5/8] x86/boot: Drop xen_virt_end
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-6-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-6-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0142.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 353b6809-4e6c-4cc6-2c5e-08d9b58abd34
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB260602502EC07CB5B7517301B3699@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	37MXOCDvaP7/IiA2uHI4y9Fmhwl4iM3xSXEN9A2a+CNBPcGpmVgILOOaYYSCLz+TbLuMz/2TqeLye+PSdj/dZ6L0mfa6aDpz4M4ot41Bv98CzH2jgRlLXhCjrOa7Sc9GSCpr/N4Yx3jvfWafPQHKFAKocn8YmlMnKvJ1Pw7RjwQhaUgMDd0D5ExJY15Gmiq5s/IiPnnNbQsYE86THvkvNzHnIygRiWYYYhXJpvCtr+z05BNjSTKqLsF8XGguI/B18CbYx7dtWJAsYv4QOGKsQ8YpsF0fNe68adVT5ES82jcsNLpP0Owof78SBhXYSyMbgEd8mOxgz1KnyMiuCuJ9p1CZ2r+i9q/4VAZhUNL9VqPkosfhTqVM9yvQnjb/uCW/K/FTCHyaFCVeDjiC5OIMmW6pg/6zWgyfzsiF4POOPqYbQKTys3AXwPd7G4HOZJ5Tm+6rpWlGoD4k44NstgiQVG4xCe28Fpa5+rv7yBR5+/Vq5MGUp00g9gMVDO3YVIA1Y1Bv86PgZpPrQLywQ4n2bFvTScWt6ykhWnC5CafvXrgCj3uh8F2miJtTI6m04dQ+AnD+6C+wHZMNRUD2U5rgKjWo6u0Ybze4TLTS6Iiul8Uy6N0sCSRumh0/w04JXKktYEhW8IUizHYmNjPmz9phY7G9y4jsE8xT1YAUTrsQ4XT3dZDUckQtECx1hZ7Ba1gD3h5PFADQGzai3NuzsWVX3TBwgY/ayTvKO4ScNkS6zxFugWYmEU8FBsCVWWymjiSq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(38100700002)(66556008)(6916009)(26005)(31696002)(508600001)(16576012)(316002)(4744005)(2906002)(36756003)(53546011)(54906003)(83380400001)(66476007)(5660300002)(186003)(86362001)(31686004)(8936002)(66946007)(6486002)(2616005)(4326008)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RTBZYmZkZG5FQkVZZ2hjUFk1aTVkQ2dzYjFPUU4xSmdrRHJHYkp0SjVNOE1y?=
 =?utf-8?B?cDF3ZEQyQkJUZnZwNEVGc3huUUE4QTBDaDJCbWYwZzFuVWlBaHh1djZVWFlP?=
 =?utf-8?B?YlBBbkpGV1VhenpGRDRMRXZ6MWsxczAwRE95NmxZNU1JQytFWWU1UlRlNFNZ?=
 =?utf-8?B?ZWNLS0hzZjhZU1ZiUXJZc0Mxa0NPeDhLUFRLWGN1dFNRc0loblBGcUVsY1ox?=
 =?utf-8?B?b0s0Z0Q3Ujl1NkIyaExjS1NrQ3BBREVSYjRWb09jU3J1TlM4YlBDTFFPWFNM?=
 =?utf-8?B?QTR4YzZ3VVdmb0xDTWtlb3VtbW52SVFLVUMvVHJwTkZPS3lYaHIxRWFoRWo4?=
 =?utf-8?B?N0tBUjFoN1ZIWDNSY1lvNkhpSFNrR2E4WkJZZGp0TmpNUG1vUWpUREVRS3Bz?=
 =?utf-8?B?QVdiejNFWHYvZ0UxSHZsbzdYNW9Qem5xTE5iR3ozYk4xcFZWb2pwKy9NczRr?=
 =?utf-8?B?MHFNaFpIWWRRbExxRDg1OGxMaDNXY3J5ai9tR2tkNEwvVDZKV2daWG1NaEV4?=
 =?utf-8?B?V1FRdW4rNEpXOCtYT3llWmYvamtTbGhoTGltYVdXaWJsKzBUd2p3ZEZKQ3VV?=
 =?utf-8?B?VzhqVTlRZDYrOVVMUXR0T25kTzN1ZHFVUzJGK1BWdEFDdHg4UlF2ZllGVVdq?=
 =?utf-8?B?Mkk2SjlFYTc0NXdObmVrUDI5YnBUSDl4aSttbmhxKzVjVGtOb0lPc2xDTVpE?=
 =?utf-8?B?bUZLL1dROU42K0hyTExvVitwT0xoOVo0YmFaQStqaTZwdHZlTVppcDdlVWJ5?=
 =?utf-8?B?RGRzYkZvUWdGaVdzNk9ib3o4TzkwVEpxTytiSmc3UW11Tng1VWpMbFlTRjNk?=
 =?utf-8?B?Vyt4UTEydDM5L3pnbzVtZ05hYlUxdmxaS1FiYTN2am8ySGh6RGVoS0RSa1RX?=
 =?utf-8?B?R3lhY2QrUHFvNVdHeUFNWFZjVHB0aWw3ZGsxK3k3NDEyUmxjR055dWNNTU5q?=
 =?utf-8?B?Zm93ZVlKdjZSYmFsVmd0V0dqSWJsSGp2QUtOTkRuZWlpZFhQaTkyb2V3QWs1?=
 =?utf-8?B?dGU0RHBtUUdycWJ5ZXVSWEFSNmhKL3J4dmJjdFE3Szg4bVc5T0FFdzRYQklT?=
 =?utf-8?B?ZXJ5SEJ2em5pd3A4bjRkd1NqenIycjBudW1DRkRMNnhwQmlBRUhXTkdTVEFk?=
 =?utf-8?B?TzkxWG1wKytxQ0J6TDQ4RGN5L3JKK2poajcwdkpwNFUrbDlPeXJGN3h4RnlC?=
 =?utf-8?B?ODRib3JEZG1sRHdpQmdFeDBFWmloR1N0d3FURzZnTnVscklpK0hDdE0wajhR?=
 =?utf-8?B?ZnBzYUw3S3l0K0Jib0tIMTdFc2htT3o2SnhleW55S2hJUVlYQThnOUUxdXI4?=
 =?utf-8?B?cUhmM0hDQnd6cXplZlJYUm1hNDBEdmROZUl0RDVteWxzZ2I3bUYwbFp2YlNz?=
 =?utf-8?B?SEZwaGdhZUpUbE1yZWdvQmlXNHpLMGdyNWpNL1Z4WC90SUNCWVpFUHBQOWda?=
 =?utf-8?B?eXlLelVuRjdYQU93NnhvVDBrdWpGdHpTcFB3V0EvclBvd2hiZFJzWXU0NEt6?=
 =?utf-8?B?M0FMM3pVZjV6bll1cjRHNlB3SnhKWnJuVkZ6YW55U0x0amttZHk4YVpJbTJ6?=
 =?utf-8?B?cU1MOEpScjVFYUphYUxPZVdrQUdlak1hbHN4TGlOajNVVHZZdnE1eFVqM2FH?=
 =?utf-8?B?SkpvRlZUcUxBVG1EMGdlbEFFaDUrVGlqbDRVZ3JyTnpVVFBRR1dnOHdlWFUz?=
 =?utf-8?B?L2ZUQ3UzSGNlUy9UVUxmeDVhWjNEdyt0OVgrYjdsUytSYVc2NWY4M08vc3BV?=
 =?utf-8?B?TmVtOVFIdHJCTFlJTm1TMTJmTlhOU1BOdEN4cEdyYVN3ZU03WEx6d0hiUDRP?=
 =?utf-8?B?RlRUa3VyQTFUL2pydXpZaENzbDV6c1pRVE0xOXViZVFqbmhZTnpFK25uYkF4?=
 =?utf-8?B?MDVFak8yYmNab1hMWW0xVDZaWURuRnhXdG5WZ0M2UitZdzlnNVpOeDB0ZHNK?=
 =?utf-8?B?a1BuVjNqUG9yTjZxbm5Mam53bXc0OWdYVW91L2x5c1l1Tmd4WFRma21CWjY0?=
 =?utf-8?B?bjdkME1Sd3MvVy81S2IvN3NianhlVGd3b0ZxcHdkRWtKT3Q2aCt2TWlDdHlv?=
 =?utf-8?B?eW1ZdWEzSUZmNjUwck12TmsvSUgybzRpbEZPZ2ovbW1ERUZoUWxlK3BvZ2J4?=
 =?utf-8?B?QkpLSWo1ajJCSmQ0Y0M4K2owZHdSaE9lRDhKSWJPSW1QcFlUODhNYkVmVGpx?=
 =?utf-8?Q?jb2C+2OkGbflc/jyBvPTnZ4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 353b6809-4e6c-4cc6-2c5e-08d9b58abd34
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 11:56:13.5292
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IxsXmTJjFxny33nelvz17EJr65EcIK1eRJurjKOysDHAsvKjd1dwTw5AaGDhIaZMlPXGUS8FdEaXKFzUsox1Jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

On 30.11.2021 11:04, Andrew Cooper wrote:
> The calculation in __start_xen() for xen_virt_end is an opencoding of
> ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
> 
> This corrects the bound calculations in arch_livepatch_init() and
> update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
> with CONFIG_XEN_ALIGN_2M
> 
> Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
> dynamically"), there have not been extraneous mappings to delete, meaning that
> the call to destroy_xen_mappings() has been a no-op.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

While there's a contextual conflict with patch 4, my understanding is
that this one is independent of that. On that basis
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 12:15:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 12:15:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236522.410297 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskzU-0007b1-8M; Thu, 02 Dec 2021 12:15:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236522.410297; Thu, 02 Dec 2021 12:15:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mskzU-0007au-4q; Thu, 02 Dec 2021 12:15:08 +0000
Received: by outflank-mailman (input) for mailman id 236522;
 Thu, 02 Dec 2021 12:15:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mskzS-0007al-HQ
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 12:15:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7b7ac3a3-5369-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 13:15:05 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-z-PyQip9M4aerapB6xIA1A-1; Thu, 02 Dec 2021 13:15:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 12:15:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 12:15:02 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0324.eurprd06.prod.outlook.com (2603:10a6:20b:45b::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 12:15:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b7ac3a3-5369-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638447304;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oVtE6UF9HP/6aSuHtY3p01RV6M7y4FaPNq6PT45yM4c=;
	b=DJlG77t0t6FJDAVflfVhADG2hslPJ0TdybiwRf5LEbEux15ETxSGgc7vr8vux3mQP0QINP
	TqZnf7xIJlQ2e8ehhcoFXc2efu5Ot0+8dAKcgrS8wHMceYnjUXrN8SRTYd/byJQdarOZr6
	5VFh7xua3thNpodXCZAu48UQX0L38ss=
X-MC-Unique: z-PyQip9M4aerapB6xIA1A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LEDWWyoHr32Shu3wLHMmgNJtJbB7n+KSu3CMysbrYbxFC0WB/7YTheUZFdW8ATaEE9Z+LtVRVmchviIg6tk45TnU8ePJTAG3WE1KtxskxiT/q0P8izMJS/ia70ZyN09TIpbWuB5yix06aargTv6l873PBrh74gwp0WasyZidKi0a9ulbIX7gvbCE6wc9/j8SEPC0m2Q7gyMrShYQpFS/3BvJduY7NIkPVDduppHcs4tA6NkW1IlH2atpBx6vuiUOqMwLXl1pMw8lnJYqQC/UmTAwz6zZLCWRgljjq9HRUpcv2W/Le2e6gLVHa/8jw4fyYgGcYBj+v67ypwLr9E5Kuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oVtE6UF9HP/6aSuHtY3p01RV6M7y4FaPNq6PT45yM4c=;
 b=FwWhKH2sDanJrOW2zQIqrEbDoN9SMmkfXux/WR6efgwvuECJWwsQTiaeIvXk9bZjJcW+4RkfpWTifz/SRgoMErFW0d9vUbtpaz15TxydSDVTmSKeTIamHRNDsAgTXqYtIHda/DAj74te229TXoqD4aJ3yVDZAQYPyIXZDA4aWIhvwiyofZNreKgpH/8bZQDb4P1Jx4SuBN6d7078xnZAgfHyL4zd7/m6AWERxsOcjkslI5t73F6TFtMsmp2LCo8HRb4z6bYQAEoreehD8+zi8SfoCg+smtegWq2QlskyzBxd2UR+gdGD6H3zTpMtOGlBb1Yapb5FVTPinglfe6Sb1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cb5bede2-365f-2c7d-196f-b624621ff4ae@suse.com>
Date: Thu, 2 Dec 2021 13:15:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 6/8] x86/boot: Adjust .text/.rodata/etc permissions in one
 place
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-7-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-7-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0324.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5764cd7d-8a3d-45c0-a8ac-08d9b58d5dc8
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23361799547003FA9CBBD14EB3699@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T41w5flmCc9Ybvtd5aOlXDNn+dvyjBVD6egdnI1lQDuJmfoVLlqKr6aGOQf1ralkjiX19HtM0FdwotiXGhu2ur0lgnYud9Sa7ITSLmSj23cC4ZdcFiKj/bi8rpelqgqChp27rWEOnsHFmm3DpHhqVXl/qYlSKSo62x6qubtTJg5IFnq76yn0OcRR/SjAIbCNiGoxJeIRrgtyV1mE5bQ7gJx1N9+uv33noaQeXR7LV0EoQzaOam89AyuhA38tXpbUrCl8tcVaT6lsXobeNwXNhcyuVGcNIzcrhlVeiycconk7kaVXL+0OHZRBSyqbXs2qYtcB8XntnDhH6UOQTS+VLzME+y5NyRF6czwfM3VAAOQKq4cSEBO9hQUu747RT9Hh6XkPvgX7Apgim1ykqmkQPZR2cRVf80MV8HYutX/QpbKfHwTmZy8T/6syUElvx/N9nWiflF+QZ5gXaIUHy1SQ2z54fwijapElOQ1FQGt9hyo6cHh+HBEkDeIU2EByYVDW5/NdTXjXzlUsDS1e1tNv9WPSpVMOUE8ZmjSxJeiAOwqX9CT+K+SsWJYqq/G/hF3siztGSxNwvRssmttCJyM3mkuBWNox6kG+T1aUgoBk5HAuB1QxOiK3OuLASLsOooZ7i2TovcHno6PrqgW9BA9PBeH0rgsoWPK+KiR/8v7+C+8CtGfKyA52FBadNQ0G2pj05gqFcN82ymi0vx4Adnsbz4ivpMvIjJyfYxvKDEy8QSS6pcAV/3wAl8QDJxZZRlkqgeFBhYw3A+vztKAbCxwZuA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(66476007)(6916009)(38100700002)(5660300002)(31686004)(16576012)(66556008)(66946007)(2906002)(8676002)(53546011)(86362001)(54906003)(4744005)(6486002)(956004)(316002)(4326008)(8936002)(36756003)(508600001)(186003)(2616005)(26005)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?am04NE9IT1FvTnVxeGNWS3BaUFJ4RGcvTEVkbzBYTmt2cW9DeTBlTTFWMnB5?=
 =?utf-8?B?eUhpTHJIeDBkNGhQOGR5dVB3dnhETmsxOElrMmFvcWxsMTNjWUUzelBuRzJC?=
 =?utf-8?B?Rnl1ajI4RHhCam1QaGFhVm5WS3djTFQ0eXl3WkdGSDlhYmZFcVRURFUxWG1z?=
 =?utf-8?B?NnVqcUdLbnhzQmpyanQ4OVZiVTZqcmhiZTNkMGhnK2RXc0NMakZRcDFBM1FP?=
 =?utf-8?B?SjRpNjg4aTFLNHVPakRUSnFOb1hvd3U1SVg2S2ZGZERjUko2N1dNeWFqWGxh?=
 =?utf-8?B?WWQ0cnczNkN4V29VenFoMEo2d1ZHRTJLZnBwdTJLTzViSkdUZStPWFZEZDJv?=
 =?utf-8?B?YlJyUDlOZ2VZcFpJbGdrenRIemxzclFHajUwM3JBMDkvSDhkSG9BdVN5Yys2?=
 =?utf-8?B?Z3pzU0xXVXF2OG04bjM2elJ3RGZLYzlBZmNyV3NKdGJsQWVWanNoU080dDd5?=
 =?utf-8?B?aXRCbThEdmkzT2lOL0g1RW5DRHMxREx5THVwa2NzYXJGSWxRUGdRb01HSTlm?=
 =?utf-8?B?VVBCRUZSOXN6OEtSV1pGRmRYT1J1bmFEUDRVcUc2NUtVc2ZwMnFQWExxTnBD?=
 =?utf-8?B?TjlmZkJ4R2NMbmd3eUtqMGRibmY1WG1zdlpITUIrb0cwZ2hlUVhNSjBNakl0?=
 =?utf-8?B?VkpKL3RLMkZKbFEzTDNpVU9jbEl5WDlrNG4xd3cyc1hiMWJOQ2J2TFBaTUR6?=
 =?utf-8?B?RFZSMVcyQ3l6clpaT3g4T2VRbElnVmluaHg1OUxEN2xaVjJLbzdFYkVLelIr?=
 =?utf-8?B?WHN1eXJGb3dHL0F0dTFXcUI0S3VQaXRLYVNuSXlNOFVjRUozMXNnQU4zazIy?=
 =?utf-8?B?M0FTaStmU3ZYZDkvZlNlaVBqTm4vZnBTTXVaeWhSb2pvSGw4M2lqL2hUM29T?=
 =?utf-8?B?Q0tkWUx6M1JNL3FndkZFT2VxY09vM0dJUmNtNmhXbjFFS2ZSbithMHdFd242?=
 =?utf-8?B?eXZXby9maTZwVHI0N0llSnJYMlBDQ3VzTGVoNkVONVovOVNVY3V3Tkxrb0NY?=
 =?utf-8?B?TkpZdXU4V3VqM0ZCK1hpdlhoa0RSV2E1aFdFOGpGOXJ5ZVVDVmdWU1Y5OGox?=
 =?utf-8?B?UWtnbjdrc2tleDMvaTlXbHlFRVZtTjNZRHVuZGczZ21zLzVITlM1KzExemV5?=
 =?utf-8?B?NjJnSW9FVUxhWVlOcTJuTkdQdkJhdlViSVpzS0tEM0lWWllrZlluS2FBbEtE?=
 =?utf-8?B?WS9ZQ01JLzRuWUFRSS9sQVNtYm5HMmtEcTVGMXpzZ042VG14eElYeHJGNEhP?=
 =?utf-8?B?NEx1ZSs2VVdQSUphNEFqZHNaODVSbm9QS0Z0VFBGcTFaQlY2UnFrV0NpU1ow?=
 =?utf-8?B?M2UrZzdxaSt6RmErZGJNRUtqdWNFTnpaU0I4NGw4TlltelF4RCtieXF4T3BL?=
 =?utf-8?B?Lzgrbmpuc3hJdW5wUk9iVEYyeWRxRWpGQ25MSVJHYVpIdjBJMS9ZWkhXZ2Vi?=
 =?utf-8?B?c0IyU0NpUThrUVZUcjRneXZGVWJHSDZnSmhlRzNJOE9DeDVSVGJOeHBJTHJU?=
 =?utf-8?B?Uk01eVI0S29HMkZUMmExWmNRYjY4elVHa3pzVW5Yd2l0VEozZE5qNUlSNFEx?=
 =?utf-8?B?QVZad05LRDRmc3krTU1wWDkzNlFDUWs1d3lxYjBrZFBWUTlDcUZocWg5aUFs?=
 =?utf-8?B?SHBwZ3J5aFFyV0FTbHVSaEpiWE1NV3BQQUhSaFBsVFp0RjJDa2pUYzBXNkRV?=
 =?utf-8?B?OHpxa00zSzBMOFRyV3ExUEgwajhlTUpQcTlYN1R5ZzdnRXlMSWFPUGhnclpT?=
 =?utf-8?B?VTAyWTI4Nm51VjY4S0QwYTMxblJoZlNhcmFKNWxjbVNzY0dHd2dwS1paV1Zv?=
 =?utf-8?B?YnNpVEZYc1kvYXNRMFJDNlZGRVJDM0VnZ2MwbkNwM2l6Q3pkaGVzMG5jV1hv?=
 =?utf-8?B?TW5VRnE1ayt5RStic1ppcEN6U3NLNm1RSTFsU1Q5Qnk0U3l3MGtBeTBOL1g4?=
 =?utf-8?B?QUNzekpOUGxBTzVzblRnVUQ0bWxBeTNFaUZQNkszdWFxcEtxcytlY00rMUIx?=
 =?utf-8?B?MnFyYXVjRERjb2RsMjZ1SGZVQXdCdVYySUpWZWExQVBoZ3pkeHJJWUtrb0tu?=
 =?utf-8?B?Y1lNN2R5RVI4UlQzMi9JSDBqV3BoUGx6TUM0bStNUndWUnliTVI5ako5VHls?=
 =?utf-8?B?L1N0ZjI5ZjhaL1hjOGRFNDBkNzE2SFVzNHdjQmpuWGJFMkhvZnlDcU1SMXpt?=
 =?utf-8?Q?c0al78nWdDkes96co1UlaNM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5764cd7d-8a3d-45c0-a8ac-08d9b58d5dc8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 12:15:01.9482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gUoHPl4uGyjLyAvwp54jV2hnv+NRDyYjZIyTzKa4YkyCdRjJsMsL+UMx6EfLERl2fZzWBQnHCY+9KjXHmUPjiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 30.11.2021 11:04, Andrew Cooper wrote:
> At the moment, we have two locations selecting restricted permissions, not
> very far apart on boot, dependent on opposite answers from using_2M_mapping().
> The later location however can shatter superpages if needed, while the former
> cannot.
> 
> Collect together all the permission adjustments at the slightly later point in
> boot, as we're may need to shatter a superpage to support __ro_after_init.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Again with the understanding that this doesn't really depend on patch 4:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 12:20:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 12:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236528.410309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msl4q-0000ju-S5; Thu, 02 Dec 2021 12:20:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236528.410309; Thu, 02 Dec 2021 12:20:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msl4q-0000jn-Oq; Thu, 02 Dec 2021 12:20:40 +0000
Received: by outflank-mailman (input) for mailman id 236528;
 Thu, 02 Dec 2021 12:20:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msl4p-0000jd-Ol; Thu, 02 Dec 2021 12:20:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msl4p-0000Sx-KS; Thu, 02 Dec 2021 12:20:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msl4p-0003z0-8t; Thu, 02 Dec 2021 12:20:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msl4p-0006aE-8O; Thu, 02 Dec 2021 12:20:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m4sSFHH82KY8YJODtOgqUr+hsScmy0AropUzl82hQYo=; b=mLkDC9i8/K3r/pHB4GDYaDrQdh
	/fEj3t0MzAu70OgV+os/nzmn/lAcH34svsSOGDWyHu6z4NigmKkNt2YQl6Rv0YA4Qb66TXZeMlNgX
	GKthEJ3+W0Ecz8zhBE0KMYi/p2ziY2TF+B5sxwESKkjKg09hIp6yEeV4aTmz3zUWcHCM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167004-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167004: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb41074692094dff1413efb44fa4928a9140aa41
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 12:20:39 +0000

flight 167004 xen-unstable-smoke real [real]
flight 167015 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167004/
http://logs.test-lab.xenproject.org/osstest/logs/167015/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166958

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt     14 guest-start      fail in 166995 pass in 167004
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166995 pass in 167004
 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 166995 pass in 167004
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166995

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb41074692094dff1413efb44fa4928a9140aa41
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    2 days
Failing since        166977  2021-12-01 17:08:21 Z    0 days    4 attempts
Testing same since   166988  2021-12-01 23:02:57 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 12:58:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 12:58:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236537.410329 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mslf1-0004hw-Qe; Thu, 02 Dec 2021 12:58:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236537.410329; Thu, 02 Dec 2021 12:58:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mslf1-0004hp-MI; Thu, 02 Dec 2021 12:58:03 +0000
Received: by outflank-mailman (input) for mailman id 236537;
 Thu, 02 Dec 2021 12:58:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mslf1-0004hg-Dd; Thu, 02 Dec 2021 12:58:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mslf1-00014T-6y; Thu, 02 Dec 2021 12:58:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mslf0-0005pc-RA; Thu, 02 Dec 2021 12:58:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mslf0-0001Ls-Qh; Thu, 02 Dec 2021 12:58:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=J2SeBRJptFZYYSOyF7wsO7BYe8TD/BNo/8yupobuyFE=; b=e2+TOsSUnVqmkZ4qPB7B3NxJjT
	buZql+vK07+ufBryGLr94VAn8x0KDXZgWwhhwo1GONcLxHqtiYeeBip7eD+jXu0v1P7Hn7f0qfCn7
	PUUXr15tMC+hfHncMRlHn2TO9SqK5PKq7p+D2FlhyAf9PfrM9xyEFPlUy6Yc+FUWcORQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166980-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 166980: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl:guest-start:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:guest-start.2:fail:regression
    linux-linus:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 12:58:02 +0000

flight 166980 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166980/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166942
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl          14 guest-start              fail REGR. vs. 166942
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit2  19 guest-start.2            fail REGR. vs. 166942
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit1  14 guest-start              fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 166969 REGR. vs. 166942
 build-arm64-pvops             6 kernel-build   fail in 166969 REGR. vs. 166942

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl          14 guest-start      fail in 166969 pass in 166980
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail in 166969 pass in 166980
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail in 166969 pass in 166980
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 166969 pass in 166980
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166969 pass in 166980
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166969 pass in 166980
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 166969 pass in 166980
 test-armhf-armhf-xl           8 xen-boot                   fail pass in 166969
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 166969
 test-armhf-armhf-libvirt     14 guest-start                fail pass in 166969
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166969
 test-amd64-amd64-xl-vhd      21 guest-start/debian.repeat  fail pass in 166969
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166969
 test-amd64-amd64-libvirt-raw 19 guest-start/debian.repeat  fail pass in 166969
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166969
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat  fail pass in 166969

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-examine      1 build-check(1)           blocked in 166969 n/a
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 166969 like 166942
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 166969 never pass
 test-armhf-armhf-xl         15 migrate-support-check fail in 166969 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 166969 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    4 days
Failing since        166963  2021-11-30 20:54:02 Z    1 days    3 attempts
Testing same since   166969  2021-12-01 08:33:40 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alex Williamson <alex.williamson@redhat.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Bean Huo <beanhuo@micron.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Darrick J. Wong <djwong@kernel.org>
  David Howells <dhowells@redhat.com>
  David Woodhouse <dwmw@amazon.co.uk>
  Douglas Gilbert <dgilbert@interlog.com>
  Fuad Tabba <tabba@google.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Joerg Roedel <jroedel@suse.de>
  Juergen Gross <jgross@suse.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lu Baolu <baolu.lu@linux.intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Piggin <npiggin@gmail.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Qian Cai <quic_qiancai@quicinc.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sean Christopherson <seanjc@google.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3187 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:10:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:10:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236546.410342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mslrJ-0007B4-3R; Thu, 02 Dec 2021 13:10:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236546.410342; Thu, 02 Dec 2021 13:10:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mslrJ-0007Ax-0U; Thu, 02 Dec 2021 13:10:45 +0000
Received: by outflank-mailman (input) for mailman id 236546;
 Thu, 02 Dec 2021 13:10:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mslrI-0007Ar-3m
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 13:10:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 41170df9-5371-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 14:10:43 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-_XF84dWZNBOSgQbHuFHC8w-1; Thu, 02 Dec 2021 14:10:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 13:10:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 13:10:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0048.eurprd08.prod.outlook.com (2603:10a6:20b:c0::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.22 via Frontend Transport; Thu, 2 Dec 2021 13:10:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41170df9-5371-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638450642;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UQYj5oYY6VsL0JHEj4lCg5XtGqCxDMxbgQGAgqeDzdc=;
	b=D2EKi8upQ/IsyoGeEtK26jWbFBkY1XYDGbTzDV3mJuk8Vy/iTRLclI/f58bzUOG54LUpx3
	rmZ8ydydrhwg2wQQqqA/+1EGkpDvRYdFBdA4rZR/dxMWrf8K0x9lAdmxIm659TuYgXhBU1
	BlCT0Y0/OKqTrbCN4+nXVwV2TtztCLQ=
X-MC-Unique: _XF84dWZNBOSgQbHuFHC8w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X2V0q3MdGG7JjfS5gL7I5ewEyqNwIpSxxdtBgBkttblI+TPHNUCQSTVe6bz4vXghucJTZx2bY/S5XMLk/VstV7vYBzcnLnSCA94lHlYpNwrC2CRoS+LgQ1rOIVrTZkMWZufU7/Zt+ritb7IgNZsnRIDSRYFF6snwVCqW15KoKjc7bi+CpGUJUnGrhSWUCN6RXQjjjkmxbqIWN3Zqe6dKDN86Yf/0irU2H4oIL7cVJjVy7ag/DR0uyQ61iaZBL+tVrEbPq/mUUZ/BBFQ6LCts/3ZVcmDpo39dK2arxSRWK4fPd4AnkzqfYTNSP0O7nCypsJMMW8Ed5vw7L5pR0z86PQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UQYj5oYY6VsL0JHEj4lCg5XtGqCxDMxbgQGAgqeDzdc=;
 b=WvXLeoO8zmX6AnSpAg5qHiKLyMxl5P5v7KbVnubXsqzthIU3EJAnFp2EfH4X9d5RC0JdGm+GysO/uNrLIrUgrK0IVArUl4KwA/nla0TrqsxNSNahw2Z2t+ZarAEUZRyZ+KeW3YrVaqW7SZ0H21+e7jBAlOvqvVC0AT86SeCMAlJjTT/i9s72M7ZMtoYs8Yu/7vzqbs77oOHgOCzKnwTcQVRa1MY2T6I2n1Su4Yu0LtaOu0ZGLupJMvou1qatEhSz1iZ9D+xOAWU5myP1zlm4mVIIC9iVoUP8sedqO2tcj6NRC+ERBclr/Ua9RcKgTJQfsThO0bUJ7RVzKPRKKlKFtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1628edef-ca52-31ec-6e46-6865694aa834@suse.com>
Date: Thu, 2 Dec 2021 14:10:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 7/8] x86/boot: Support __ro_after_init
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-8-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-8-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0048.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f7c6d909-4ba5-45b1-e2f5-08d9b595236b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57417C90F1F887FF3AFF6176B3699@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c/s9zn1kMSJiojF/8KMV2iKKRVhYQQTu0Dd8E5Dg5pUCJplFxXSg4xDJ9YneIVcONgM1qZEBvN8krMUdTaH9kEszMDO5PbjMU9LHL6sDbqELS+39pPt8fRISTUlHm+q912O2irdZDwNG03dOHGVdk6drrP++zeU2qgXF9hb1xFO59rMNaVH0gUKiwYujXEJNRGSyf7y8I+M+cmLsxAqPKAE27BSigCEev/IHfreD0fxHHdnWLmUUOwnGDbYN/R1PAd/3vd+Eh+Qca57TVcAifzabR4RAiD5ex8/6MFrQaRPWlkogH0R7Y4LfsH+6R3iujaTCbwzGlRXgpDAlnyJ0FcjOnfRkDGXWbhmQ1v8LQfSMOQZZ9EA2FiEZhTZ1VxAuKFaySWFStnJJjmxExua8bQlbyGS2Zt37IVnqfd8jNrggGshiYPNDrTz7XXfpzrd3d967nVZe+9IeTmpdTG9SQ3N+N423u5ur7aFksnQArWcHjhs6bh0zoZnWCS6Ueh/rrO+kiYLCfT9BeO/aT5Wox9LZzej85plAz2QwYC6DT+6tkdey9Nmi9OBds3roat/wPMVgwnRTag5B/KKN0yKNMkEkL+TfzB80WEOpDPAai/NrwAXihiN7rHiKpgfYXx585N57pENmax6t81MGFOerNOIPlF73/GZlFHSL+o6Hp4qL713kmoCkG30u5nsa2BJIdACF0ot7wiwEOz7qS7br+r4gFXj4tN8jtdr0QVaaQ5s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(31696002)(26005)(86362001)(36756003)(2616005)(31686004)(83380400001)(4744005)(66556008)(38100700002)(6916009)(16576012)(4326008)(956004)(8676002)(6486002)(2906002)(186003)(508600001)(54906003)(66476007)(8936002)(53546011)(5660300002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TEM5d1VGak1HZUJFTHp3dm9JYkVRaEhCNy95c2JqekUrcmdjODB1TlduczNZ?=
 =?utf-8?B?NWtYUnNFY1dNOEVDRlBGRnFnV3Jnb2xwTUQ5c2lrM2xhRnNiTy9hRUR5U0FI?=
 =?utf-8?B?TUxIV2dGL3RoQUlOcTgySTU5QWt6dlAxaFZxaWFhYlNHY1NBVTY0S2MzTDhG?=
 =?utf-8?B?WHNCVklEYzJhcFZZZUZiaCsxbE8rWlZyNitoZmNFaWFyVFhWdDRlSkRPVS9k?=
 =?utf-8?B?Tzc5V1ZHZFhrYXFXY0NkL1IwSHNFdEIrOXdSYzJkNE1FcXpRc2tlMDk1QnVK?=
 =?utf-8?B?UTlNOGxNZHBWdWVMRndDZFhjV0dTNlFEYVZvQW5NNm96djRQTGhvcWJ1T0VM?=
 =?utf-8?B?cHhZSXhHMlJnQXB0NFZPWkFtYkp2a2VLTktpVnVMUHpkNmVOT2NHUVRYcTJT?=
 =?utf-8?B?TVAwak5jd2U4R09wdXU0eEI5OHBHQmdDcEwweFlZLzNqdUg5bUp3SkdBS3RI?=
 =?utf-8?B?VjV1bnI1SC9JL2lSdUNOeG5NdjZyZ2o5Q0JzaWUrKzhyTk9JQ3B3d1hRcFVR?=
 =?utf-8?B?VGpDamhyeGRjSit3cy90enc2Z3ZlS2RqMWVyNUZiV0E2ems3MytXdDF6YWEx?=
 =?utf-8?B?NzV5aVkxcU9qK0tZaVhSMGNPa20yUEtUNmdtOE5HQlE0UGNOR09SY0ZYUmtL?=
 =?utf-8?B?VW4rc1ZVMFNtdGs2ZDB2OXUrYWNhZ1ZubFE1aGF1VzA1K292aDZjT1JyYS9F?=
 =?utf-8?B?TEhxOFlzekt0bzZvT0N2eDhhU2ZNTTZmNnBnVEdibTNhWHpRa25pYlprL1NB?=
 =?utf-8?B?UjBMZTFoNUJQT3hIeTNnSlZPMXZ3OXZiTGNSbkpvVmU1OUxudmR5SXU0UTNW?=
 =?utf-8?B?WEZRVmZob21LSTJZVGdvcC9MNUNXVWk4RUZHcDdOeGZrNnZNeUZaY1ZRTkF2?=
 =?utf-8?B?ME1pSGNGUlFFOFIyTmt6OEZmREpXb0FxQmIzQ20rQ2ZnL08wWkd5bGhEY3F6?=
 =?utf-8?B?NFVCL2swQXJidmt6YyszaFZuMmU0L0JycTN5R1F1YXV4VEl3K1BqVzVteG43?=
 =?utf-8?B?T1V3UGU0QnBLbUVwM0dKUWc3Z1d6VnpIeFZyY1F0YjlPUzU4RUkzaXB4bFgx?=
 =?utf-8?B?a2hHcGR2aGtsdGNYSXJkdWhvc3ZZQm56NVU0Mm9rTndzc3M1QW1CZDU4T3Er?=
 =?utf-8?B?SUZYejZRT3ZEWDJYUGxIYUlEV1ZlR25FMnBqNk9KL2kxc1hzaFF4Qys2Vmcy?=
 =?utf-8?B?bGRxNkh4eE1YOTd6RXBkY0ZCWHNMZkc2d3NCOFROaGYycElyTjUwNW9kRXdD?=
 =?utf-8?B?dUhkM0xwNTYxOVBCYTlpeWs5bnFHN2t1RURkNkxPQ3p1b1NlTmhiS3d4Yko3?=
 =?utf-8?B?L29wS0VDdStTQWc4cFc5c3M3bzdkc0FXMHBtaDVZM1cwL3FRVkdWcnhhdXRN?=
 =?utf-8?B?SlhVeExsK1dnRU1NV2xvNVhQU1R2WDFGQ0wwZVRNTlI5by9YVGttRHk0QUpi?=
 =?utf-8?B?bFNmZkdtR1JaNFJTRURwamtSR2FLS1h4SnluK1JXZVV5eUovQ0VJNElyYVFE?=
 =?utf-8?B?dDZPeDBSL1hHZUxKS0RKMDY5Um53eEw4T0lkL1FqQWpHWUFUNmd2R0Nramd6?=
 =?utf-8?B?b2dyNjd5N3c2SWJhR0dBbEFTR05ZdldlTG1zaFd5Zy84STUrayt0R01OMXVN?=
 =?utf-8?B?NWFPS2d4SDdrWjVvcHVZd0ZtQUlWdXRkbVA4YVdJQ2pPT3Jra0ZNQUFEY0g4?=
 =?utf-8?B?N0VxczFlYlliNVZUTyszTHJFUkVCOE1MdG5IWVdyb25pQ0NuWUxzeVBKYWdW?=
 =?utf-8?B?SDc5REFxSy9wNkxrRE1FaVFzUjRlazMrdk1LMkIzQ0h6ZHpZaURpNlFuTWhW?=
 =?utf-8?B?Vm1HNUJvcG1qME44cER4eEZsSW0zN0E1c2svOFpLTStWamxaN082STgxUlEr?=
 =?utf-8?B?bXhhbExIZ1d3UTNEK0pkZlI4NTZsWmNiYXU1d3FZL0RuMzZCTi8zZ1BXdmFq?=
 =?utf-8?B?NFRaNS9qbVROZnZSdFNtU0NKc0Z3RnRTR3c3SUxoZW1CY1BxL1lTZnRaSnh5?=
 =?utf-8?B?Tjg0c2Q2SWVMQXNKbXNxdDFMYTd1aE1GTU91eXBRVEpiV0pqeG16UnQvcHdm?=
 =?utf-8?B?cis2VVNlNnQ0Z1daMkYxbVBjZ1Z6R1NaOU9mS21RWS9LaWx0L2pOYWRNMmN5?=
 =?utf-8?B?U0Jpd0dFMVVvS1ZLSVZVdFRwbVlnU0VkeFIrN0tVMFVzbWlHTkk3VUJTUERD?=
 =?utf-8?Q?v5Q1PhCFZfoNcocWfKk45qA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7c6d909-4ba5-45b1-e2f5-08d9b595236b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 13:10:39.9862
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mzve9xiAqaovGaqYVjQrjUO/innRzO4b9T1qPQAiviF1IUwoXVafyut8utOMB+Kb9PDj83Wd11PyuvAIuHlCxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

On 30.11.2021 11:04, Andrew Cooper wrote:
> For security hardening reasons, it advantageous to make setup-once data
> immutable after boot.  Borrow __ro_after_init from Linux.
> 
> On x86, place .data.ro_after_init at the start of .rodata, excluding it from
> the early permission restrictions.  Re-apply RO restrictions to the whole of
> .rodata in init_done(), attempting to reform the superpage if possible.
> 
> For architectures which don't implement __ro_after_init explicitly, variables
> merges into .data.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:33:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:33:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236556.410366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmDK-0001U6-24; Thu, 02 Dec 2021 13:33:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236556.410366; Thu, 02 Dec 2021 13:33:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmDJ-0001Tz-VE; Thu, 02 Dec 2021 13:33:29 +0000
Received: by outflank-mailman (input) for mailman id 236556;
 Thu, 02 Dec 2021 13:33:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msmDI-0001Tt-Lc
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 13:33:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6e071af4-5374-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 14:33:27 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2051.outbound.protection.outlook.com [104.47.10.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-8aXpN1xKNT6mOKRFS7S8nA-1; Thu, 02 Dec 2021 14:33:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5469.eurprd04.prod.outlook.com (2603:10a6:803:cf::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20; Thu, 2 Dec
 2021 13:33:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 13:33:23 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0320.eurprd06.prod.outlook.com (2603:10a6:20b:45b::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 13:33:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6e071af4-5374-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638452006;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4pXtbJai5ps01/v4a+G8xathrB0fFKM+HskABABO80I=;
	b=EMtl/v19UNB+ZS1B7+PsxvF3hYIMANqNBMxz2VUWTDmvAgM0FyDbwEDV+yi2mQO2vlLXn7
	wr0zbE0tpjPEReZZ7w1+M3+X7kT8OM6ybk5THjFJIqIFARLzc4XmZ4MESaTL3jE8ww4hsX
	z27mPg6cxwH8f/olGiu5yte5PC5UKyI=
X-MC-Unique: 8aXpN1xKNT6mOKRFS7S8nA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CfTt3yElQ5ybwh9f6PVzr4rr32S9u4ruWs04RRXldliNrfbRwa3HDh6WiHmoV3bpfiFV+gaJ8AIcWYGfP9DbPjhdic/RwLXUkK7doHKO4nn7Bbdr5y9zUm06Sko5t2GAd0pOx+OZBOuOE77kqeq3PONVRNCDqfQaIMIirdc1Q3AQ3CB2PDRm5BcLrznvbzQY1F9EDZa2XBT2jdLAGyiwfdXcjKqzWn0qlc+6vrmjVcum6BcPTcdHujmIWQGYgysJ1n/Wb7DTHk3Q/lEIkodPuMsKW3ue69OXg7XvoP2UQaq0ARB6KXK60FWEhb7a0mNHyyU79WTRxX8PlPthhgj3xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2G0UFx7dbUrZfUZc/ptz5HPJR/23wF74hdc9vJm6BKk=;
 b=nj7VUanQjKBBfUhwic5TwoqDMCDh9vnh5DSSI0gRVX34t8W0ny8CwoSNZbU2zrydQcn9V8k4ANPzEGEkla/gd4980FAz5+x9iERWPiV8ETOrQLRiEhbNrcqApk02l2pdZ8d9X26/gIREZkA2pe8RuGY7gydJH5+rp2sP7hxd4QlTY2MtMt3Ywj1O6ELSy/q+hKWE6YkL3IkErhsQo6VRdRpHnU0ARBrL/FVT7ENdoYT7yAgcADds/otnciMT4pwlDwyeigSYeBwHk1nhiESxFtOnUOhpmBxGUMJOiQP11Lm58/ZyZb8iqsfno9MvX/oeysAq+Qj7zy9imRxqtPO9xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <282f884c-834e-caf7-4e09-6c7a662c666e@suse.com>
Date: Thu, 2 Dec 2021 14:33:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH RFC 8/8] x86/boot: Check that permission restrictions have
 taken effect
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-9-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211130100445.31156-9-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0320.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 19887899-1860-4553-a661-08d9b5985021
X-MS-TrafficTypeDiagnostic: VI1PR04MB5469:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB546942C443B76203C8577DB0B3699@VI1PR04MB5469.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iX+lKF2r3GipsEswFrk1nRgZnkEwBxEyYnXXDuhh5TpmVxUW6B/lBCUl/j93lMdxsY5T1zEqEBv3LS4JBcZkyKVY0U4ubeT5tvyxyF+Z8EgWKxdX9nhem8y5B4/22sepiYwCEjKcNB/cxSARULgJgc+HkfeCIJvnJqJTgKqj9Fx8JN5AGui95svyeIVQRgIbyZrePhj93r0wNLzAVRDqXsIKiQrES69+LczTJ4XHKDlO8jY28LWF9xsGYzKYpfbl+bEyUbwnTM39UVMLOd1JannongReWqePOE53ldqG82llzBmozWrbE0N/u2Wj9G7Nv0aEBXjmAV8Fn1HL6Dlfz9bWQH6TIxaGMR2QJCknl3BZYdjPUVRlb9YaJlcxCEC0i4UgjGg8rq58klzDw+mcEZzEv6YJtioXNFdCstG06jpB4xyvxJ33nYfwyARhNIg8nm37LJpWrzAH4I+HLiIHgENPAdbdcnSesBLrlivgNyMbvAq7tQo7nLp7/Kbpr6qchwHN//u4LOUjCbQJgfBzot2PpJR4ov13xtYYm0KUGmPgiYftrbem7+kDExTsZoc+9uWWyhWeAPmNTajGi7MC0Vl2RYQTX8I5zT9kQDuy49dXyn+7LoZhk8IRZQ0DvLnTGZp/Fib4ghlBAwiSmCcJk6oWA40OYRXgvncJJgQCiojkL0fCiRU/vqEdRsHB/LHPnQhigO37zYq6qUxZ+XfrPrMzmz9ABwZGjRIngWKhvwM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(83380400001)(53546011)(16576012)(86362001)(38100700002)(66476007)(508600001)(66556008)(31686004)(8936002)(316002)(36756003)(2616005)(54906003)(8676002)(956004)(31696002)(5660300002)(26005)(186003)(6486002)(2906002)(66946007)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+VbgIlaE0E2C9eJyItf8zf+HipQ1ZKR+CgmuGR+WUBcTG1NDnDlIX/NEr7hE?=
 =?us-ascii?Q?wSYP7VLObhoEU3TOMG+1K6U80FCpeeMLjCLrr6kKU/EFj1wZbbkrClCQ7bvQ?=
 =?us-ascii?Q?ptQ/Yf1foL2pY5icva/ckBzsq+lkEFEZYpBEdM9lkmHj8GMj+fI0WfBmV1nP?=
 =?us-ascii?Q?8+IlKnwprNq0pXoOtkAL7fkOiS8LVVjYO31l9hCYvl2l0LkNqORoy8438ymd?=
 =?us-ascii?Q?LURzqO8EuVyXKDmMZrUgO8VAb3RqZ0g+81HRHiqEV6BuhRYzQi1TL+iBw7/V?=
 =?us-ascii?Q?sTpA/x1FV5KpeJ0l2DkeuZwW/ko/qi3gslIIER4kUY3N81aYFTFxkRfPduaZ?=
 =?us-ascii?Q?O42b1kY6/KFs6VZFMG4TJAvHqnrBUwv7xJcwRUqCcYrsuR4a+UjbPXVqwV8J?=
 =?us-ascii?Q?APt0ijehOfnrugUst7koNlAJmdcIyKFogoBLkevY5ya6UaWudPAru01mNTjU?=
 =?us-ascii?Q?bgjrMhMXmND8vttQO4keL8zkTQPji62iaR/dUREGTYHnAbhlkRo7eFbn0DDu?=
 =?us-ascii?Q?w/Hv94BXk4NB8F90cs/cnXWmrLnMApRwznbj0QjqVGZF5BC604HBUZ1NYLC4?=
 =?us-ascii?Q?zRrrSawV1b5zwfr1HCi/7exYIrIx5hlbqa8fXraDzHiEAMtiXhA25oZj23lz?=
 =?us-ascii?Q?rqPebkJULOw+7x/4BnGiAeEBMPxSOvRbbHfeToViMKP97ufF45s4Z2hQrWl2?=
 =?us-ascii?Q?kfUm3Wg3kCKt+gE7RtllUnXECRU20x6HDpi4Ftp3wgpk1WQGlEsdNd1LliSj?=
 =?us-ascii?Q?rmUCzOaQwe1MMqUVAoUfW1V5Babtj7uP28eU1DN7Fb3hqLrOrF9MK2TyIs7P?=
 =?us-ascii?Q?BmTqj9u0kCUpiOdYj31TFEUEY//fHEvhd0ySvoulSAJxABJNfGGQEVeLufH5?=
 =?us-ascii?Q?DftekA7q77AL4wHw2ZVl6eSev3qnALRsbdiY3LRfGubFVlvNo3rk4KHHZjEj?=
 =?us-ascii?Q?JpmStVp1XvTjYjQr+8+8BKMc2HqC5izinvPwiPktZV330m+FNfLDYddPC1Wh?=
 =?us-ascii?Q?X0MNxk6vKxUH8xKcP6LLjP/Ue55EUccY8/XGNCqJ8hiA1cAOnkNhkBXbE8na?=
 =?us-ascii?Q?M8w33ZKrA2KGCWmea4g4aY4u4eaTdKYh7dXdLCSLzqSPjYmQU8nK5Z21bSu7?=
 =?us-ascii?Q?Hg4SH1zAYMEgeJEw9JYkit2NWXP9GdqDpc/0fFLEvU5G7L90elzWyKIAl7Ep?=
 =?us-ascii?Q?rpSj+CQTrkPQjFBurS64i6vRLGZQMjnGSQlY6EkhKf3dUBMGlPRqpYAOrDLm?=
 =?us-ascii?Q?24fdXrwumpqfFB9wPygfu032z5f2xg1K4ek63oxm1yN5sCm/JwHjbslHTrUc?=
 =?us-ascii?Q?/t6mQnRjwhK88YG0LAWPYaWCJjWYLJfEYemcLVA2QX5QSSLoIv8eRe2Mw1OT?=
 =?us-ascii?Q?E34hoVxWX6lsKd7mpOKrX8zVURWfe445Zr4aRbo4sVANnqW40VETlf1m4WIz?=
 =?us-ascii?Q?FPI0mmZZePn9WBNJQyB9tM0gCn0jJRr552Q5CljJhQLBpdVfaZRFG9wyEkYD?=
 =?us-ascii?Q?HHrlcoz1CikEm7bceKDOJnQVmFpqwz6Zm2HBxRrsUNecZxZ/6FqAk5v5D4WK?=
 =?us-ascii?Q?6Qg9skeQ6JenzU8JtMhpwy4WDN4Iqfy/MViWotKTdJgOHzZlt6Dmm3GMTEU+?=
 =?us-ascii?Q?KxNSRFd3yhq81+pcjOv/Gxs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19887899-1860-4553-a661-08d9b5985021
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 13:33:23.4794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mpVc6D/KvphPJfZ7nRTfvjbokhp2gZpWsEdOt/SNHmm8uen/BevAJxzKsG5fZjxgmaiM+38RUm2O0PbYIsUhKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5469

On 30.11.2021 11:04, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
>=20
> RFC.  I don't know if this is something we'd want to keep or not.
>=20
> Getting extable handling working for test_nx_data is proving tricky, and =
while
> I can't spot anything that should stop the extable from working with NX
> faults, from a security hardening perspective, there really ought to
> be.
>=20
> (Spurious faults aside), there are no circumstances where an NX fault is
> legitimate, and restricting extable's ability to interfere with the fatal=
ity
> of an NX fault provides a better security posture.

Gating the extable_fixup() invocation accordingly should be possible.
A respective check could live even earlier, but the window between
the !guest_mode() check and the function's invocation isn't very large
anyway.

Since we can't have both testability and such faults being uniformly
fatal, but since otoh we use pre_extable quite sparingly, how about
forcing the fixup to take that path by disabling interrupts around
the test?

In any event this touches the insufficient selectiveness of the fixup
machinery again: Any kind of fault will be recovered from whenever a
fixup record is attached to an insn.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:45:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:45:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236562.410377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmOy-000373-5T; Thu, 02 Dec 2021 13:45:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236562.410377; Thu, 02 Dec 2021 13:45:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmOy-00036w-0x; Thu, 02 Dec 2021 13:45:32 +0000
Received: by outflank-mailman (input) for mailman id 236562;
 Thu, 02 Dec 2021 13:45:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msmOw-00036n-GY
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 13:45:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1beb457d-5376-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 14:45:28 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2055.outbound.protection.outlook.com [104.47.10.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-UGhlhmb6MqKe1aLCGkFQDA-1; Thu, 02 Dec 2021 14:45:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 13:45:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 13:45:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0602CA0019.eurprd06.prod.outlook.com (2603:10a6:203:a3::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24 via Frontend
 Transport; Thu, 2 Dec 2021 13:45:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1beb457d-5376-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638452728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eBqjxjzAKNWmMoaVdx0+u0F+oZJWaI43KvGtrAVKrb8=;
	b=isXHcx8ph+7yy8hBKs6DLTTLcJqms1gKGxuw6R/leoQrO5njTjTQwb0t4+lZ3JQWOEmu7z
	21Q77/9c1Ui2bVVIUUNNwk9pAAqyWjiYI2P0+jmrDcLdmOQHDF/O2Hmy9rANFFR3L+f4G6
	mo1mBy7ZraLrt7+5brLs21YQv9gT7XE=
X-MC-Unique: UGhlhmb6MqKe1aLCGkFQDA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ps/BS6POLQkkPrNsO1GZrkP0CYqt481w8GhwW4TbU2V4vKM8Y4ryT32vTziX+stxveTbfgKdprVrnXYUBoLJXTvsa3E/N/y5FBKoUj8KozLynMVwnv7l3v7trEOFZ0qNPs3obbSil7qkpqkUABKf2JyclJyhRC66u8vxHe8yEpCWVfR3VYlxgPf82pHuBa6pbcR4aSCetc1IyNX00WmjzDcNbd0P1NqwynRb7UP2EnWQGm2I2UpLN0Wkoq9pq0eHP/7bBLlu485JDcY8LL2DqZpgJO58zbcZWJ2Sv0rCROjR5FjNoqtIJ+CI9bEzTNGCIq/YAFUgAuBIR9+efc2QKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eBqjxjzAKNWmMoaVdx0+u0F+oZJWaI43KvGtrAVKrb8=;
 b=lLK63aKS1kqN4iZzuhC+2L5GOwRgc0hQ2VhdYkjJYfBUyZv1u5loka3NK121Pyw7WLq915CblngZB+g6CyX+tZtvjBRVZ3UUcvxo4iXS/MDsV312YZ2GhKomqDLC3qCubX033QHBqoFvb8+bsgEc2xuuUZArCz8pWt+YdHpvjPSrnNyqOWguOI6XXWevmgGaMUPSZVi1nZsiC/0DRvieoYyFzYjLcdwv3AR5EyefmX6groQsZj3TmnEKkdeLA+cRhWdEaJEnA46lQbeTE+CZczg9U611JOnKMEUhh4TD6Jss/qVcNq98Phl8neJBNGO44Es21N2CAcYrepYXrdMFyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6ce78d1b-a223-531e-fb06-47d78c5f3c7b@suse.com>
Date: Thu, 2 Dec 2021 14:45:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH 1/1] Add suport for SMBIOS tables 7,8,9,26,27,28 to
 improve virtual machine stealth from malware.
Content-Language: en-US
To: Anton Belousov <blsv.anton@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Ian Jackson <iwj@xenproject.org>,
 xen-devel@lists.xenproject.org
References: <cover.1638190663.git.blsv.anton@gmail.com>
 <3ad07dc366117e43a46004a03cdb963581b16fd7.1638190663.git.blsv.anton@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3ad07dc366117e43a46004a03cdb963581b16fd7.1638190663.git.blsv.anton@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0019.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5f51e92b-08a7-46e7-82f0-08d9b599fe87
X-MS-TrafficTypeDiagnostic: VE1PR04MB6480:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6480838D42ED19544E55FA19B3699@VE1PR04MB6480.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:883;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iTlUwAbvvzxo9y4afJ9xZxQPyt0Krx+RYtOwVcFW6t+/xCPxTT87jIaKD0RqGow2zyGzP8OaIndMEEIqwa+vwt25CKB8zq1Rycaw9oKAbKX2xTYh+zax7pA4AEoZrXr74QmxmAcwxUElBXbPJV3ukoln6KLvVwhVuj2u7w22Wt6PCxy6W+ZFCgkXmxRjxqGOqBbiPaRV1KhWfht8gR3yprp598NXrVl0joNQtqcDvfMrGV4NOH4kZFEG8dctWFRIK1zj7fX8UjIWvgkAVXFBESa/Bl7rKsjYesfWKVzpQ1yKBGZdo0XAABGMzeRXQRh8meeOk9SJrnv5PgJcqb8MHsyHchHLfh0UoAI5z7RRcNBU9cWhrXAIDoUX6262VHNLDNc9G6mTnSqt3EoQC2/5ZyGnnqJaZD+P8T8bk18lpaZYJJq1HrcODG3gIu+DiVrr2lf/4O8gSwRIownPbJnx2Xdq1NMhJ8lMKGS4MdYEHvSGr0arLcG2kac6iCokfKx8a7fp5r4qOrneKaZJc3owtu8JiHX7p2wn3Opi7PZCFwWLZNIaKsfjjUGpP8jcSObTb/jen7m2uy4DCnqE3W50REJMAsbDc+d+YUsSRDeAUPgOK94SIClwX9frM+AFsNGYttzxv8F3ZKSEoCVvqHLJ8dMEsA9vKPHmLiqiHdS3EaoMe4zeaA1eaEEXxvTU1yn2eia0QIv2ecpkq5P+T7fF75RRQPD8JDocXA92G4nG8DkHTAAn854XNjNZL8j/1kfa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(2616005)(4744005)(66556008)(4326008)(6916009)(66476007)(36756003)(956004)(186003)(86362001)(53546011)(26005)(66946007)(8936002)(508600001)(8676002)(31696002)(6486002)(38100700002)(31686004)(54906003)(2906002)(316002)(16576012)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGpOcjk2TXY3a0wwMm5XSGVyRS9ndDViRG1mUGZPL0tuYUJUWkNQMnFSRGdI?=
 =?utf-8?B?RTNpT0xxZkM1TkRRL2d1UkY1TUhjTFo3c3pvNlRDL09rbjR3QkhpRXo3NlVa?=
 =?utf-8?B?VUllbis2NzZPV1pkVGxkVXNTWkIyTnRnSkcxQ1VnZWtRNEhIdkJuVFFqVWJ1?=
 =?utf-8?B?WjBMWDF5MGlwb3kyNGl6eXMzZE5PNVQzTEJqd01lKzFVVXZMRTlwM2hYWmE5?=
 =?utf-8?B?cUwvYkFtV0JJMHVtMTBnQ09nYW4zWWlWTlRYaEw4QThwY0pwY0RMVExrQWpo?=
 =?utf-8?B?cjZOcllqUzM1d054c2hIZDNKbmRmbitLVmFEaDA0M0pWZE5DUFBCVTNtNW5P?=
 =?utf-8?B?WXVPbjAvTHp1VGY1WVJCR1ZoZGN5RXBrWHJtREFqNjY3bldFdnpFTHlhQUUv?=
 =?utf-8?B?VmpVaG5xZ1ppdUlGQTIxdmtPVE1FUVYyYWJBWmRYcWNCOWM3aCtIcERUeGRM?=
 =?utf-8?B?dWt3bHNtKzc1Q0ZqcXFYM1NUVkZHWmdqM1NsYis3T2Z1WWxLVVVOV3VaVHpD?=
 =?utf-8?B?UktSb0w1K0NiSk9JVERRY0FVaDhFOSt5ZjlueVZzL1hXMTRRU0NnNHZjMUtl?=
 =?utf-8?B?amEySHBqcjJzWGw3WGY5aGJjYzFicVo0R3owdmtJNk9ubEUrd2VhWkxEcjB2?=
 =?utf-8?B?NkJPbmRzQStzSHY1NTk5eWcrenZFRFZKckVQU1RYbCtEVDF5Z25EQ2IvcHRu?=
 =?utf-8?B?SkVxQjFUb1NuQUkwcEc0aFhOcUxIVnhUMWowTmhkM2NsQmJlVzRKQ0lNYVBa?=
 =?utf-8?B?RWFRNmI2TWNCZEt1c1JhaTZ0b3kyamEwNkprMHVRa1dIMVNYWjNTYm85dEJr?=
 =?utf-8?B?eFpTdHhVYjVXQitwUVZOZ3pCNXVRMXlRSTBrazREcENzUStXL0pySGpFck5N?=
 =?utf-8?B?dTg0cFJJUUF3SFR0SXZ5Y01PdGkzb3JRRHliUDVRdXEwcllRQk9GY1kvQThl?=
 =?utf-8?B?UlJkRXNyeXJHZUtOaFJuNUNSSklnL25oS2lTTkE0TFlJaTZUZTFuQWhIZksy?=
 =?utf-8?B?Q2FNOWNkdGRuNjhyandYUjdNZFQ4NitoR2thM2hSa1BOODhsczkwK3J0MFJi?=
 =?utf-8?B?VmxGb0ZmNUxkSmd2STZpektyWDQ1ZEZiQUV2SCtGcDdrWHhTeWo5b2tTVllp?=
 =?utf-8?B?Ym82K0RKbXRwRGdqUDdxYXRMOTMwV2xwMjh2cmI5NnhPTWpGelB0NFRjbTV3?=
 =?utf-8?B?K3NtSVBzb3pMWEVzMWxXeitvNEtMQ3A2bFNYcHRIdWNaMURoZUpKNXYwYmhr?=
 =?utf-8?B?TDJmN3AxRU1TaXJ5ZzZPQi9QeHE0N2wwZW9kY2JvYzFzVTBtR3VRQ0JRTnk1?=
 =?utf-8?B?dERMOElsMFNya0lGQXBVdlFsejJpZzdXalI5UUpleExwY3ZKcGkra3E4RnUx?=
 =?utf-8?B?Q09iV0hKaFJXUm9odnZtMFBhRWRPcWZQY2NNZHRVQUZwTmFtZk8vb0x6dHFi?=
 =?utf-8?B?OEdOYnd1ek16aHN3bXlNeW9uL0FRZkcrSXNaUVYyZmIrZFJvN08wN1RncUEx?=
 =?utf-8?B?a0JDMFBtU3BOMG5BTWx2QnFPek5laHV4eVFPdE9rZ2diK3kwbEd6MWM3RUph?=
 =?utf-8?B?MytOTWM0eTRPaU5ROFhjRE1USFI4R21SQU1jY3BOajFLczljS3RMc3FzclBK?=
 =?utf-8?B?eCtjUlVIUWp3ZU9iSVIzVEZmZlRrRnpPdnpiSXRTQjlDMXAzYVB4c2RrSDdJ?=
 =?utf-8?B?SFVmTEd4dEM3UitsQWk0a2xjMG8ybzJHeFhqME5Dbm9GNHhYRzNVdDNnK3Rj?=
 =?utf-8?B?ZmVDYkx4aVNZMjRqbExZRG15NmhJL1FUaXIwMFdMNitOUjdEVEVJb2xaVEtQ?=
 =?utf-8?B?SkF3d1RNU0xUd2d3UWZ0N0NxSG92Vmdyck8zSzZaY2dzdURsSURhT0pFdHM3?=
 =?utf-8?B?K1pwVTBZTCtYOHVHQzdNcEViNmYvcnJCcHY3eWYyRlJzQ1FBV0k4VmVYcUY4?=
 =?utf-8?B?S3pJQTVrSC9WeVV3K1R4ZE9KajQrWFRKWER3eDlHNzQ2Q0hQSTBwWlJxeTFH?=
 =?utf-8?B?K0NGYXlhWGpkN0xxUTkwcXRrRWI0WkRvK2tBcEtHekNUNkNZVGhSNklrZU1E?=
 =?utf-8?B?YjdrVE9ueFBUUGFMNC9jakR3KzM4Vkh2a2dnTmE3QjU4NUxEWWtsQ2FwQm92?=
 =?utf-8?B?WE9jdW15dTR0anJLV1d2SW96bVRlUnM2Wm0xT0JvMzdlSXU3ZHphaTQveW9V?=
 =?utf-8?Q?CEJt1hc7EgWfeLtriY9A7qc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f51e92b-08a7-46e7-82f0-08d9b599fe87
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 13:45:25.5652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: usHEWw5CxDUFax29psBtFSRwwoJuld+B9jDH8VV0s32pcwMh6BRmyVGl3P38GauobvKREIJEziwL1AbLVAnpaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480

On 29.11.2021 13:59, Anton Belousov wrote:
> ---
>  tools/firmware/hvmloader/smbios.c       | 146 ++++++++++++++++++++++++
>  tools/firmware/hvmloader/smbios_types.h |  76 ++++++++++++
>  2 files changed, 222 insertions(+)

In addition to what Roger said: Without a commit message it's also unclear
whether it was considered that the extra information might misguide a guest
(kernel).

Also, even if I expect you simply cloned existing functions: Please try to
avoid cloning style violations; see ./CODING_STYLE. The most noticable to
me issue was missing blanks around &&.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:55:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:55:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236570.410387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmY5-0004my-4u; Thu, 02 Dec 2021 13:54:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236570.410387; Thu, 02 Dec 2021 13:54:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmY5-0004mr-1q; Thu, 02 Dec 2021 13:54:57 +0000
Received: by outflank-mailman (input) for mailman id 236570;
 Thu, 02 Dec 2021 13:54:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msmY3-0004ml-QV
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 13:54:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d8b6aae-5377-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 14:54:54 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-N0jVKau7PCWUeU1FF3Li_Q-1; Thu, 02 Dec 2021 14:54:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6863.eurprd04.prod.outlook.com (2603:10a6:803:12f::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 13:54:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 13:54:50 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0088.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Thu, 2 Dec 2021 13:54:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d8b6aae-5377-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638453294;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=POpEsygG2alrlZnWyeaqmNsFbyVVrgq4r+tyAfk+r4w=;
	b=PUXm/O5R6PbzWeQQ7gRx9fzTuttlcotU8RGb3iUYSs+Q6osGB4XKH4yDv3mZ0soIr7Uf5S
	Z9O3DFz2JrnHz0RWEW6rWFuiKm6lkgD0bM793S8nnw4CzHla0eZMGJtq5Ep669g6FHTAst
	aHRgGqEpWQsLx63CEgOOr5nqG218ddU=
X-MC-Unique: N0jVKau7PCWUeU1FF3Li_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WnU9aBnhqK151HD9a1DfRaj6DSx/bGb1O1XymY8Le50VryqpVlCUmmkm/NVrN71R1jK3fMW6ofbwf6gX0ksa+2Jz9PvnC6CMZ01dG8Bqhg4E9nhsKLHqNQdcTAlaoIzqELhFZg/j/+Bkq6xCwGcc3341jtOAbDG43q7W3iTpy9eQrIyzHxoNnIS8Hs6dIfemOGf+IajzwXuWfU0D4ZSed4d3XmJUF7d2/gQLDMpZ9ruAc+V7lIxJ9F1I8yEumubVFwwY5xqIw/GqXfzqg7TAXe8tl3+g0mfVoPzwZ1cIwGlXD5ZhWqlzCg1rhdJHyO42NIGWTMerFAmO44LNWaiWaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=POpEsygG2alrlZnWyeaqmNsFbyVVrgq4r+tyAfk+r4w=;
 b=eNcjV3tiIIs3MaR961dO/g1+MWraInSFGNNCY+W4pUmRfNs+1pllDTa7b9a8MM1xud/wO6Vfp46mHXZHrv4DtvLeDsonaE/MfUzamnxAswoMvCeX6Xy15s7ghAbOo2xOT4peATVuJS4fK3qO7flnsSbhhgvdPo37+j8LYV2teEclbaTxAKs2A5jeDllLBhTRgh2wSNtgmZHkTNwt3DNSSQ4cFt3gvdHE5ZNR1X3GjfvnBq0G/inPHJ1lSWTfQGagfge65empIkSJlzIYG9F0L048StaLYw4hJ7LUFNyqe6D3155luJfBwF2mW03UJVMeSClbIkw9klEoIa9Yf8jUJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <66bfe096-9b9d-2289-93ff-17eea95ed7a0@suse.com>
Date: Thu, 2 Dec 2021 14:54:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 02/47] xen: move include/asm-* to
 arch/*/include/asm
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-3-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-3-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0088.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad98835f-2359-46e8-c8e6-08d9b59b4ee1
X-MS-TrafficTypeDiagnostic: VI1PR04MB6863:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6863F284A5E64A60E5195EA2B3699@VI1PR04MB6863.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1QNKs1suLHHKw9ySC0ZurT2Jh/yx+pOP0GI48IpqYGfbdrorfLYp9Ok8bIbLKsCQdYObFS1lGRWzh14f9CTxch4NOZiNuUBp/Hni7H9vW69t1DIIn7gpmMDQAnB1pMosqixyD/bZcueiBSsJooswJnCHR80VaekVcP2yV+GT5WnIMMnXgZGxp3HdK4uC83BcRwwMjzXBw+7Exlp2TSsWmzVTTEQt029M56ykGoiSNfYznrh+pBngTZH/OZ/vhr52pDhC6h2BIOf2v07540Kpz10XncA/TWUsGdhUHuisOu7y9rmuHqh6Q8wwNl+rICVDJ5Z2Q6Z91bz6IgUob7CDEmPso1uYgVOL2UyNl90m1ZmUh56lUHtxzl3qXKObEbm/zF8fQjLddIzWLbzfTNdkOLBCLjH4Wd3UC6FYx6+Do5IrpdEteFKYu24OwpLYD91yb3W/EXumejUbqAjWNEbDrL/4sjxPMNL8pL17rIFe3F/8ZlJzr9l9fhvGWcgPllaSv05Y8Yj/zCao5Lhsp2FpV3KFRvKEmTQDN1WBMg1GOkboM5yV9+H1t0ZXL42+UgCckH3NSLl95HCGU7WEQIgPBr331UGaf+9SYaeN2EMZuBm4wDORnphaoKLe3UgE/v56UDRTmArT4bRNw+VVfrJe755yosyhEt8ok3gWALyr1W7SsKcJr4QtvUYcRajR4USg6cbed3qKdopQiVGzPNSmmUqAyUnFViXec0PO0IhCHNoEi78NdC7UIg9dljn2S4m4
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(31686004)(7416002)(66476007)(66946007)(66556008)(54906003)(16576012)(6916009)(53546011)(31696002)(316002)(4326008)(186003)(2906002)(8936002)(86362001)(956004)(4744005)(2616005)(6486002)(26005)(38100700002)(508600001)(36756003)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZHVzSzkyWEJYUlFJa1dhUldSYm03UGRSM3piSTFmUXVzaDJaMlZRNHB4UFMr?=
 =?utf-8?B?dlFvaW0rbmNTV2pTeVhodjdDR3I5OGpvVWJOSTQybnUyUXhUVk1IRHVHa0dQ?=
 =?utf-8?B?Vk9ZZ3RCbEVVRmlJRExBTk5FRU1naG9qUFpPa0VqcjhxNDlEempSYm5md3cy?=
 =?utf-8?B?L1lRQ1dFTUVNLzR1SGVhMDRqZlZWcFgwdEFZeWZWY2NhRWkxZjVDbkRYWitB?=
 =?utf-8?B?RGVxNW5VMlNYMkF5KzVVakJQV25DMlE5T0FPVm1uNHdvdHJQRjdjUDIvTXlV?=
 =?utf-8?B?YmxBL1ZpTGJvY3FuM3FxRW91SUR0QlM4RGhvdE9wN2JabURFcUZHTFB6R3ly?=
 =?utf-8?B?VWttR0hlOUczNDZxM0h1Q0VBaDRkT1Q5NXlIWExFMTZNbHFjSGw1bDZTRzhI?=
 =?utf-8?B?STBGa1ZZNmxkN2lTNkRGNmVkRGZMNGFyNWNYUUtiQzU0Q2s1OUxpc2JIY0w4?=
 =?utf-8?B?VkZiVG93eUVUeVBPa25LQmVQS3VXNC9waitaUWhybUJ1cXBHbC9Udk5NeUtQ?=
 =?utf-8?B?dk0rcDMwd1NCVUExd1dLSFdJK1hxZjVxZDkxdWZVbUxOZFFGckxSSlZYQTFM?=
 =?utf-8?B?MFdsZFdCeEZnMFpicy90cm45RlhhWWJMVDZVVHVtNUFBaTR3ckxyUzdQZkhj?=
 =?utf-8?B?YVFsUU80aGZUazNjRGtwdjdxRkM4QVJJMHNtZ2YzSU1vb0FVdTFkQXZpcE1Z?=
 =?utf-8?B?WW1GNXYrd2I2TEplS2cxV3lzS0FTT0FXWC91RS9reElwY2Y5NU5KT0E1cVhZ?=
 =?utf-8?B?Q29vTlVSbVYwd2syZTkzTUp5d29TZjdjeUUzTjdrYVUzMUR1K2FkS2dQMUdH?=
 =?utf-8?B?RXVwbGZsWjQ1a2FVbGdLMUN0MU1pa3F4UWxQTUFwVGsyVllwZm1sdDRsemhM?=
 =?utf-8?B?YVd0bVlIdkpkWkhlME1mMG1OTXF0SVRkNkJTS3A5S2ZOem91SnN3b3JoUEpK?=
 =?utf-8?B?QUtNRzhZVEh5T0trWDFnZFowTXhPVmo0amc1ZGZzbXZOWGpsZTd6Mm5ENTZE?=
 =?utf-8?B?OXB6cXJiM2RjMFlOcGRINW1STDdURlkxWmt5TUVJMm02OW5CcWJQQnQ3M2k2?=
 =?utf-8?B?clhlZTRZV0FSTUU1M0UweDg1TUJ0UFFNQ1YyMFV1YjY4VU1udW9BOVVMMzRO?=
 =?utf-8?B?bjFid3lSZ3JnUDIyV0JweGJTTDRxNTJIMUtRa1h1RE9aRVJqc1hZeExGZ01t?=
 =?utf-8?B?WWIwOHBVbUJwQnZxUnhGUUZtMW90NlZ3Z0hjUFpaNno1NWVzb0hZdy9yS2ZP?=
 =?utf-8?B?N1ZHd2NJYS9sZHIwQm82QlN4K2R1ZEJscTBuWmlrdW9hZ0dha25aMTNiQ0oz?=
 =?utf-8?B?ZDd1VlB4eXltR1RodkU4MnVyUTFLU2RKd2t0VnR2S3BXRmZReVdCV2oxOG1R?=
 =?utf-8?B?RzU5NjdhU0VDdi9iblVxYWdIZW5iQnI0eERVdGJDR1pWRlhIM0kzSFp3am02?=
 =?utf-8?B?Y0lKWkJoZXdYK2hwVEhsWWR4VTZzd1RGakU4QjlGZVZncTlhaW1ycmxaRVJr?=
 =?utf-8?B?WFpidXR4bksvY2hSREtiMm9QY09LeVJzb2NtaHVOWXpUZmtIZDF0eHFVVGpH?=
 =?utf-8?B?aWpveTFyVDc5ODBPMEhrTG41VjMyOWJUbk9DOTJGT1FhVFFWWWZxbEZ4WUtS?=
 =?utf-8?B?T29BVXhDcWhXZ0FqUjduYUs4c1hLUCsrYzVVbU5ESE4rSFY4YXY4R0dBVjVv?=
 =?utf-8?B?MlZ6ZGN5U0syQUk2c09pS1JocFNCbG9RMEV6UVFlOStnQytDdVJTZUsrL3VG?=
 =?utf-8?B?d1ZwbFNnaElLcUZML242Tm9LZ0tPSFlydVZlVjVUaEFaejlSaURxeHBjRmtJ?=
 =?utf-8?B?U2VlaWVmT3VtSWVDUjBEQ0N3dlNKRzBLakdxQVNOQzBCTDkxVjJFYlRneS81?=
 =?utf-8?B?TzAwRTNqMThxV2MzOVBKU2ZVTmYwN2w5U2ovdWhMaE1GUWFmc1RPbE9zQVl2?=
 =?utf-8?B?NjNPOXVDV0hJSmQ4WWRQSm1FQXFZMnpXYWhtZmFTVmFzWCtnN01oclB2WThr?=
 =?utf-8?B?aHM2VlpsR1oyT05HVFRPTENwZHMxaHVoWW5JbDZuMlh2TTNXMHlTWVpaK0lN?=
 =?utf-8?B?dDBmcHFFQk9iOW56UFVJK29ZWCtjZ0N6TTcxWnRNaTBSNlJSVGczaFpNdEd1?=
 =?utf-8?B?N01USGczRm9lV0d5RUE4NEduL0VxWFc0aEE1UVlydStZZkp4cG05dmc4ZytR?=
 =?utf-8?Q?OUP7k7OgJvvEHms9lONzlQ4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad98835f-2359-46e8-c8e6-08d9b59b4ee1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 13:54:49.9662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0E+683MZifDpIMMaBaCGIHeyk4qAxwI79b97e8Dwt8DVC0FnuZaSIIIWYY4VHskF0rqokofjLFXuH5gfagETCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6863

On 25.11.2021 14:39, Anthony PERARD wrote:
> This avoid the need to create the symbolic link "include/asm".
> 
> Whenever a comment refer to an "asm" headers, this patch avoid
> spelling the arch when not needed to avoid some code churn.
> 
> One unrelated change is to sort entries in MAINTAINERS for "INTEL(R)
> VT FOR X86 (VT-X)"
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Paul Durrant <paul@xen.org>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:57:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236576.410399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msma1-0005ZI-Hp; Thu, 02 Dec 2021 13:56:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236576.410399; Thu, 02 Dec 2021 13:56:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msma1-0005ZB-Du; Thu, 02 Dec 2021 13:56:57 +0000
Received: by outflank-mailman (input) for mailman id 236576;
 Thu, 02 Dec 2021 13:56:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msma0-0005Yz-DU; Thu, 02 Dec 2021 13:56:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msma0-00021w-3K; Thu, 02 Dec 2021 13:56:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msmZz-0008LG-NR; Thu, 02 Dec 2021 13:56:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msmZz-0002OT-My; Thu, 02 Dec 2021 13:56:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DQqpFY06EM19sPKjAEbjNlcm/3ZDwaoSpf2M24gp/Ig=; b=2+C+7d5dAlJ+oxFvkw5HjoN7IJ
	KJQLkzKaWURuw/oeD91bRXxho0EAexhOxtWKj98CjrI4+HJTga25pcemzIhWnvnYlnGxF2Jp/MdeZ
	3bptBjUnknFeQVL67I4Rb8s7/daASCXKldnN7Jkm07SgBY0nTQcLQ+WRj/q7XjS4afwA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166990-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 166990: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-destroy:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start.2:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
X-Osstest-Versions-That:
    linux=9334f48f567334f54101223012ec9d3b4628bed8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 13:56:55 +0000

flight 166990 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166990/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 20 guest-destroy fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail in 166970 REGR. vs. 166839
 test-amd64-i386-xl 22 guest-start/debian.repeat fail in 166970 REGR. vs. 166839

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt     14 guest-start      fail in 166970 pass in 166990
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166970 pass in 166990
 test-arm64-arm64-xl-credit1  14 guest-start      fail in 166970 pass in 166990
 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 166970 pass in 166990
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 166970 pass in 166990
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail in 166970 pass in 166990
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 166970 pass in 166990
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 166970 pass in 166990
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 166970 pass in 166990
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166970 pass in 166990
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166970 pass in 166990
 test-amd64-i386-xl           14 guest-start                fail pass in 166970
 test-arm64-arm64-xl-seattle  14 guest-start                fail pass in 166970
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 166970
 test-amd64-amd64-dom0pvh-xl-amd 23 guest-start.2           fail pass in 166970
 test-amd64-amd64-xl          22 guest-start/debian.repeat  fail pass in 166970
 test-arm64-arm64-xl-credit2  18 guest-start/debian.repeat  fail pass in 166970
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 166970
 test-armhf-armhf-libvirt     14 guest-start                fail pass in 166970
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166970
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166970
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 166970

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 166970 like 166839
 test-arm64-arm64-xl-seattle 15 migrate-support-check fail in 166970 never pass
 test-arm64-arm64-xl-seattle 16 saverestore-support-check fail in 166970 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 166970 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166839
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166839
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5
baseline version:
 linux                9334f48f567334f54101223012ec9d3b4628bed8

Last test of basis   166839  2021-11-26 10:11:13 Z    6 days
Testing same since   166970  2021-12-01 08:40:40 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Chuanqi Liu <legend050709@qq.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  Diana Wang <na.wang@corigine.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Grzegorz Jaszczyk <jaz@semihalf.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Huang Pei <huangpei@loongson.cn>
  Hulk Robot <hulkrobot@huawei.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gerecke <jason.gerecke@wacom.com>
  Jason Gerecke <killertofu@gmail.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol@gmail.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kumar Thangavel <kumarthangavel.hcl@gmail.com>
  Kumar Thangavel <thangavel.k@hcl.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Manfred Spraul <manfred@colorfullife.com>
  Marek Behún <kabel@kernel.org>
  Marek Behún <marek.behun@nic.cz>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Mingjie Zhang <superzmj@fibocom.com>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nitesh B Venkatesh <nitesh.b.venkatesh@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Ondrej Jirman <megous@megous.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Peng Fan <peng.fan@nxp.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Remi Pommarel <repk@triplefau.lt>
  Richard Cochran <richardcochran@gmail.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Mendoza-Jonas <sam@mendozajonas.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <horms@verge.net.au>
  Simon Horman <simon.horman@corigine.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
  Tobias Brunner <tobias@strongswan.org>
  Todd Kjos <tkjos@google.com>
  Tomasz Maciej Nowak <tmn505@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Weichao Guo <guoweichao@oppo.com>
  yangxingwu <xingwu.yang@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3389 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 13:57:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 13:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236578.410412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmaC-0005uf-UQ; Thu, 02 Dec 2021 13:57:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236578.410412; Thu, 02 Dec 2021 13:57:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmaC-0005uY-RV; Thu, 02 Dec 2021 13:57:08 +0000
Received: by outflank-mailman (input) for mailman id 236578;
 Thu, 02 Dec 2021 13:57:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msmaB-0005tL-0D
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 13:57:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbc1739d-5377-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 14:57:06 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2052.outbound.protection.outlook.com [104.47.4.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-3Z6XbEwHPf6x_zzjmazF4A-1; Thu, 02 Dec 2021 14:57:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 13:57:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 13:57:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0012.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::25) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Thu, 2 Dec 2021 13:57:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbc1739d-5377-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638453425;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NrjjjK5socyGIKooQkWMu2YjUAmg20YydmX44WVv24g=;
	b=f+Fg19njZsVAi7XBHAx5bp8Hcfrm5Vss/KBGlwFk46feBa2lkWuBSM2L/xg35euWDQaV/h
	l2D9cI8yMXESnwRyj2V34qwrUhL3sYrkWsNVdlwQTlgrV8qA+j14dhqAFRYCu8Bl/SbF9n
	t+kus23IWWToUsaMARGp0U0AqcKshX8=
X-MC-Unique: 3Z6XbEwHPf6x_zzjmazF4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mIWcWogKJzpzXq2STZtVriYDtFJWRBK2NBAUMRUOWtW1ZCrKmAJs452NKAUDNYgCnG4eR12pVGjvGIsvu65vAHrrqla0vrlkZqTkstpO9vIHGHwl8zmsciAlNKfKSGBxhQdOMWr7m4ju7cWcIte7p/3a1LN8qXStcT7YcIhaIjDFzdqjs2rvvWAbqPQw7CARozGjQUXwTRnphi+KftJf90TVwAGCn7woMYXO1/FNZirXyfdbjLYUDMHgvkyxViFvJDDyFmJO2k0ZxI7hpUUXx45L8/pOLetGXTU2cFrhA8b3nC8KZgz2rJMDOgCscmZZJYodirtDSOqUy1ELvhlDhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NrjjjK5socyGIKooQkWMu2YjUAmg20YydmX44WVv24g=;
 b=B8bK2AgfV4NpYG8i2/t2fNmxpKPR8lGz/fejJcqkIv4wNFHWQ2M4UtFc+JH/cyC3YBkZepurc4zdL54BUO6Md6XedyekT4jknYt4Ev7rfSIR5KK8Wj4wbZNKB/qRLa+zaPstk9P7wau6drgSVaA6M2QCca0UleM0eK91E+zGADjlUttaOEfEJtkN9EC08S+nq9K23g/zqAoAhnzP4F1gqPJZeIcD7M1+lSCPj5dx7LG6f5ha1HVFjy1xRVAQroGWjD89UxdxnK811kX+0wMjndEth13uc7u/mAtKAosX9ebOtlpl9vrIvfQOs8GbKl/e1CQJIsuwCYBXDGqiCXgj7Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2cfb2d33-eacc-9286-58d2-d56b88dbe054@suse.com>
Date: Thu, 2 Dec 2021 14:57:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 03/47] build: generate "include/xen/compile.h" with
 if_changed
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-4-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-4-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0012.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ce71ffc1-cfb0-4e01-3c17-08d9b59b9e8b
X-MS-TrafficTypeDiagnostic: VI1PR04MB7152:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71520454203E4E30E649053EB3699@VI1PR04MB7152.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	P8ZHQ5tuoJEeKHThkHOUDy0HuyIXB5wrUh6Ts9qzdrPxqXvEwUhT4aiSbnbSeT524XrHJfa4A1QLSK6lySB512z4AE6cZKJPgk8FkNStPwOHQF7RTJQC9LQb3fNSVlabBSFI4g2c6JTpZ1K+Zf8pKpoA3J97PQqtKJKZg3GiduX5nvKt4KcujmhJR4NcBytJqWeuOFWhqFlCL9VuIdzvBBF/jYLcnmF3c/lirOfkF/VovG/lPFXmGGlf8oxLdE2ZPPpQJlQMO9gz8mQq+nddiodzWQsAV1E0utkQ828YekY8L9+R9H3QNUOXrmGm0pkSrk2JSdpFYEL5dTs7dRYG1jDSkxK9IIKEN3g6oDRbPdXoUAmY0hv+Ggez7cL2VuA9SStSYScqZtrhtaw30qapuQMexR9PSLb4KLsjtIBuwbOdL9Y9tGDHYPc9nCti8tIIjSkpGP7OqOet+vkJCUxehiII2av0cxQweHa1XlTc0Yg+ZqrUKKtLSWnyAuTZE4R5KJ5r/fyd9NnWtOhxlUBX6Oltph8mo1AdWLwoEBBF4UmTUqQhNXtt2e9Tm0rlEDBLqtSBU0OGb6qNHknyj0wyjyQ9jFdCwfg+d93j7Zy0yr5HWHBrrsbFiRv8H0iQfQHkpshyg8udpGDzKQF3f4Xk+L/ZaNhSY2pQvZaCl3UBuTEbXvRyeGBsp/RAgvQT80+3pbQSl6ccSzr6QZz7pNBbjXO7RmdjLprpZiSK7ra23kdq/A2D02Pp879apk/b78iB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(66946007)(66556008)(66476007)(956004)(316002)(508600001)(5660300002)(54906003)(86362001)(38100700002)(6486002)(16576012)(186003)(4326008)(8676002)(8936002)(2616005)(53546011)(36756003)(2906002)(31686004)(26005)(4744005)(31696002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OGE5cFdnNENYU3V4WmFBZnhPejFyb0JTMnhrS01IRzdNWk43NC95MU5ueExY?=
 =?utf-8?B?K29INUtFUEs1QmpkOG9PTzlKT3ZBc3ZZVEFiRW82cFhHYUcrTzlSMXVSY3d1?=
 =?utf-8?B?bDZIeGhnMmVjbk1tRzJRQWFyNkpPZGpxZ0h2YU1jOFZzejRxVURSUEJlbTFx?=
 =?utf-8?B?UUI1SlpwZi9BTjdjWnBjS3ZxTDdVOUJNUy9wMy80TWorZ0RoUkI2ODJ6Q0sv?=
 =?utf-8?B?VVVmRjJ1eU14ai96VzBYWTdMMm14NGJCelFEb2ZJaE1TWG1LQWlRaTRqTDFi?=
 =?utf-8?B?VnRoK1UxcGI0M3V6cDlSbDZIbEFqVVRNcHVNN0dBdU01Q0FQN3l1dEFOcHc1?=
 =?utf-8?B?MUhUaXd3K0R1bnFadmRKOVc3TmVLaWpBS01CZG5QdWcxS1E5OUFmcVhqN1Rx?=
 =?utf-8?B?SjdaZDR0VkNUMkl0L2diYkVraEhRRzUwYU00V1Z1QllUUzN4YkczMDhkS04x?=
 =?utf-8?B?cXRXa2tOamt5MXdra3d4Zi9XYUNaVTB5M1lvTS9HMFhXTmxDSEN3UmJrMCs3?=
 =?utf-8?B?ZVlXVHpkcmcyNld0SFRjbmpTYjlQQmJNM0N2Y2cwMGg5NXBIY0F1aE1QbVFG?=
 =?utf-8?B?VDVGUkVobzJPd2FhNWhpNmlZZXk0VXdRbTZacjRscEQxTDdhaFhUUm5WVzNZ?=
 =?utf-8?B?Vit1bUFMcHdadlJWbzdEa0J3RUZ0elE5dFRHRHBXNWhFVlU0RFNtVzRIanBp?=
 =?utf-8?B?SkxnKzJ0VC9tTVRGRTkvYU9mUlY5TFRFeWJpNVFYM0l2aE5qZ0EzZ3Z6OS9K?=
 =?utf-8?B?SDI5VUVkWmlDVCt1bkliQWppY0JMUnA1VzNsRDJsTERUUVhwN0dFbjFjZXBx?=
 =?utf-8?B?bjQrajVlY0cwSzRGZno3Umtabythekt1SWgvSVlOSWRMNFlNVFVuOXd4Ky9M?=
 =?utf-8?B?dm9tSmdJdTBJaHNkT3g5SzVSTDhJRWlWZUF0Z0M1NTY2VnlYSjhSYktMNHIw?=
 =?utf-8?B?aXVhVUo0WHRYSkJoSTZqL3MzUnRyei9TUTFPMUpVSnlhbzhaZW1JZEtFMDZJ?=
 =?utf-8?B?eHVHMWVwajNIdHdHdm41bVVrZUZIY1pzQVIvQ2MzTUxYZi90eTBrNGJ1MWFY?=
 =?utf-8?B?OTRBclRLMDdXckpScEVTNjA1WlJRUmpBTjJIZE5tUFh3SHFoNkJlVjlCcVN6?=
 =?utf-8?B?NXlieXVzd2E4NkVCdUZST2FURWRZamYybGQ1bEppMUY3VkVXKzJVb0JXTG9X?=
 =?utf-8?B?eW8xLzV1ZW9LQ3lZam5paGlGWjh6aDdQRlBCQVRWOUJiR1VBRWJzT20wWmVr?=
 =?utf-8?B?T3hKdTN1bjlIVDVDK2tYd1loS25OQWMrcGtaUDZvTDB1bVA1QVc5Y1AraUFD?=
 =?utf-8?B?ZFh1b1Z5QmdRajA5UVM5UkxGQzEzVk5nWi9RbVdrajB3dklhdHJHQWxpMnFY?=
 =?utf-8?B?ays0NXBRUzBnVmUxS0g4NThTaEExQlh0VnNoQlBoTThBT3lOeTlqS3RNOVE5?=
 =?utf-8?B?Y2NHaW02UWdBTzdjSkVRZElMeHV0ODJvWTcxaXZtQUp2V2NFbHNxOVpRaVA5?=
 =?utf-8?B?dWpOcWFMcTArUEY1aExKSlQ1d2tSc3lrMjMwelA4TWlSdERDeUE4c3pQdGJj?=
 =?utf-8?B?RFl4NlZaSTlXVGZaOHVvY2xMRUh4L0U1cFllNExuVFhteUcrWkdWQkR6cTQv?=
 =?utf-8?B?c2pMR1dLbFJ3UGM4NnYyeDBYc1hUTVNxMko3RGtKc0ZSOUZJLzllbDFETFk5?=
 =?utf-8?B?VGU4Slk1Y0J2V2w2MnNFUGpxc0RERFRZcUZjQlpWb3hkVG11dllJMHg1TWdS?=
 =?utf-8?B?L1dWSE85aTRtOW5pYzhtbmk0a3N0YnlvU1JPeEVPNmJLUjhBUkNQT3MvK29a?=
 =?utf-8?B?eEJjZ09nUUVnL3FhaktnWEpXNUdmMTcwcTBBZU1KNC9naHUvemo2cTFVeXcy?=
 =?utf-8?B?T0d6WlY3OHdwcUxQRUNRWU5qUDZNRnozT2t0WlpRdUt6eDhJSy9Md2grQ3Js?=
 =?utf-8?B?YmQwSVpiV3hpbE9pSk1pVUdhTXFzQlAyNkVmUUw4QXlHZnhGcFZvMzdOTmZh?=
 =?utf-8?B?SHNhQnlSOVFOZ2Q5aXNrS3dlT1lFM1FnbGFjcWpQbFpCdnduMXJ6a044S2Qr?=
 =?utf-8?B?ejc0TXlhOFZydzk1TDRIZExvRTlMN2lxMU9JSEp3dDNLMHFwT3RwMHk4WjlB?=
 =?utf-8?B?U3QyaG1xYUxUZ1BPME9OLzZkNmpBYUV0MkF0SWcxSXBXK0J4VVF3M1VPSGs4?=
 =?utf-8?Q?RNk9SouObDQhuOrk1Z4tocM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce71ffc1-cfb0-4e01-3c17-08d9b59b9e8b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 13:57:03.5118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sWTvWTUS7CQbPumiRvq/nXC7mkk939SdW2006kcuAP8GTgtOrzJx9J7U9lCMJ439EU3YlL1jeJT7C7neRJd2Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On 25.11.2021 14:39, Anthony PERARD wrote:
> This will avoid regenerating "compile.h" if the content hasn't changed.
> 
> As it's currently the case, the file isn't regenerated during `sudo
> make install` if it exist and does belong to a different user, thus we
> can remove the target "delete-unfresh-files". Target "$(TARGET)" still
> need a phony dependency, so add "FORCE".
> 
> Use "$(dot-target).tmp" as temporary file as this is already cover by
> ".*.tmp" partern in ".gitconfig".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:07:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236591.410428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmjm-0007nX-7l; Thu, 02 Dec 2021 14:07:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236591.410428; Thu, 02 Dec 2021 14:07:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmjm-0007me-1b; Thu, 02 Dec 2021 14:07:02 +0000
Received: by outflank-mailman (input) for mailman id 236591;
 Thu, 02 Dec 2021 14:07:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msmjk-0007ka-SN
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:07:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d76894f-5379-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 15:06:59 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-5PeQi1vRO62b713-GbafiQ-1; Thu, 02 Dec 2021 15:06:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 14:06:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 14:06:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.9 via Frontend Transport; Thu, 2 Dec 2021 14:06:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d76894f-5379-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638454019;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nGnkOGvYO08FfNFCjHhmmEEdazHHlQ1MTnjO4bmB+wk=;
	b=TNzLXLKAmK6zeQJDK9a0DBWprs9wQ1zHsOjxYUOwfEt7go/wRFO6/Groshy1UUOiyz9aUF
	0sNVIChqvS/yJoIbyrcq8uXzVzn+zRjDc8UvfhhnQrlyy3L3O4+PCEYY83Uxo5hDItBVr+
	W/hBVSi94kufKfX5tW0EvA3IaDvkOm0=
X-MC-Unique: 5PeQi1vRO62b713-GbafiQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EeUGkpKM2MnR6a4CorqIBPHM0TuPrAKyJzO1VtYZdxOa6bQOWqx+B/Zn8SN5zl/r2lSjyZiqAUZ6NutfSZX2gL3CR6+zdxe9fqCqel0ozw43P1OrwU2yeKViUQZB3eOhXSBnFDanS3lAdnfcUhJn85l7uxML42syuhm6UZptqXgLuP6VFJhg0RbDm/o5G0IqBgFwlSp4sAKlm3Pr+2EVe4hRP1EVlhH6xw/b3Sw7SSvBuJ4sXN/mweZo0GjCDm3yPczHgxSpsSQmtN7A0jR0B2cs29KPDvuQP8VVZS6kDGB+4w4oT+77ogGtqpT2c5M8HSRzyC8DOyQmrCby10FI4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nGnkOGvYO08FfNFCjHhmmEEdazHHlQ1MTnjO4bmB+wk=;
 b=VdhI8Zsf+FcS7+sASLmu0bfMZEnn0fDK39d7YmCzCmtlYRj3clnW6JOaEV4WigVhGlIOb+dlLZT+UhQLmnHcG2d+yjRWJbcH9zPoloxR/YxtzsBgF1BVThvNChm5FyopBzhedEGX01KkQpSF5lzIEtdchXQjj8Jv7/u2WZZGYr7D2ZMsMH4bilf5DpOZchlljhWRzgcIpSzGKIabvKZBYJzFK3M9ZfNrdQJGw1KETEyKL3nnXrDrd8GCPER052YXSDnao11ScbYLzYS7pK7a76yyRPcNYEur8N2SBKIb0BMmhMqr+H93X+9YfzRIPOYzQXtFeWVi7gpY3ycAan/k/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2bffd73c-ce1b-40cf-73b7-f988e69c4f07@suse.com>
Date: Thu, 2 Dec 2021 15:06:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 04/47] build: set XEN_BUILD_EFI earlier
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-5-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-5-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17)
 To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2469220d-5424-4530-1449-08d9b59cffc0
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB48486F55030B9D478A727712B3699@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	If4MB/SGGkUltHEJQAhWR/EedRQ/+sFhPOAHJIU5cgJqMHkNyaJdCrMlQxGa63VA06B6xo/lq5kAvDh0JEsOB6xnckk3eUGXQPDmtTgkMxekX8ZTN8gd5UBzHXdLSyfjzaVpTSq6fFrrM/lkSt+9lKQbMJRzlonQAskqDXPoRiESWpDfUnavHWRCzsodZfmoMTb8WnhIB05Udlm7dk0gUZsrb+HbY5LDOceoqGMcC9zSowH0HixBaoezN/Cgw9WRA9eKkKhmxvaDGMMpGakobSUTe+1pLBTkllHJtyTH29DSxdTltihgkvXZPTmx7c7TxnJg3ZRDBxbXQPe7aeJPsUob6kwVV15uzKN+CQTL29AZOcb66o2wy5oK45hivQDn9ktEgca4MT3INMZBlj/VFqxcYTMQliPTMEAUoN5XbjWG1L0BCbIPlZFN4D42EumP+g7GsUqE9kVnvDviQdk/342yIE1N/QD0BeoAUejfSysYf3KCsbUar1syWB24ZMi9X464829wH5UVic3gTgAaxgJFygDTg4HFAeHq+YN7GlWIh1LadpKIoiqgtB8mqV0mjOD5GI17fhyBriABlQcxq+BycSznjlICj//3gh2CoSVgzYgwnP6TE0dqw8NAV6Fq2ks8BkjE26aHKljVRjsdRKkulXaT2hXP2+dCSK07812YDgpg8zsmaNrAeHhM+sKIcDsTbkhJls6J6G91LH4L/FZokkMYy9nLpaMpMCG7pvHKQx3+kHexWTarUV7ks6DU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(956004)(16576012)(31686004)(54906003)(6486002)(316002)(2616005)(86362001)(8676002)(508600001)(4326008)(83380400001)(66476007)(6916009)(186003)(38100700002)(53546011)(2906002)(26005)(5660300002)(8936002)(31696002)(36756003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXJLcGx0RVZQU21XcE42ZXRXZUhhV1Nwd0JOcHdLTWRYb25Ib295Zk55bmNw?=
 =?utf-8?B?bTd5YkhpY1YzeVhKUVgwTFVlWjNPZmZQVWxQNEFQa1hPSjh3N1ozcHRFWWdq?=
 =?utf-8?B?WTdyN0dQNzZFODRmbGk1RGppTkI4L1pQVWNwWGRuRDl4TjBSTzVGSmpVNmJ0?=
 =?utf-8?B?S21lb3FWaUh1Rld5YldpOWRHc3ZYa0I4d1JPRk14bW15UHJVa0hZWDdGVW5q?=
 =?utf-8?B?ZXBlaHpqT3dPZVk4ZjBJMHNQRzVZWnl2TnZmZmVidTVKbGhoWHlXVm1sUVpx?=
 =?utf-8?B?UTBFQ3hvZk9sWTE1dVdEN2lBd0sybGhWZ3REWmVQbkhxWVlNR0Y4amszL0JZ?=
 =?utf-8?B?YnVpTHlteHNZK1VyeC83aTRheGFmS3FqWTViYXc1RzJxSmtpaURjaTQybWpL?=
 =?utf-8?B?RTM0cGtLY0laSDByY0QzbStrSHllVGs5M3RnMzhFRWhLRjlhYVNqY0lJUGlh?=
 =?utf-8?B?bXBPdUo0b1JzRG9PSVBhN3loNWNjM2FzaWNiVytYWWo5dmNINzhMaUhqWlRj?=
 =?utf-8?B?OW5ZUExFRXQ0d3BvaXlpVUF3Ym95MDhURFp2dWNxNlQ4NWJsM28vd0dyaTBT?=
 =?utf-8?B?TWtXVlNmQzVIVCtGRG1wVmZXOG9BdFA2bnlqMWdYY2RoVW5NZ1JsN1hFVGZ2?=
 =?utf-8?B?TGhFaTFBUkRNQURhSGg1YnhVdkUrMGdOM2E1SGV0YUhlMDZtRHArZjBrWk4z?=
 =?utf-8?B?TDR1QVI3LzhiUjNvQVlYMzJZZjY0QXJWeUlVTGloZnMyR0RDc2V3NjFXT2Fh?=
 =?utf-8?B?NFVuZGZ4dUN2UW8ySGRKaWF1OWFISXBXNlAxYXpjT05DMGd2VWZFcThJVTRE?=
 =?utf-8?B?YitjL3VEcWlrOXl0a0hpS3hFY3Y3bmxicEZpMkozRW1CclNJcHpVWnJqc3dW?=
 =?utf-8?B?M29WSGJHK0FhTjBOT1AxeGtwN2R6bCtDZkRpOENRb0RtWUtZNXZKYkFLZE9n?=
 =?utf-8?B?Q0p1Ym80VFlyTmwvQVJFS05GY1NNODgwWW83bVRhdStwZnVyYVNINEJWQzUr?=
 =?utf-8?B?NU8wOEVVVExuMlMyNVdrcTRsZnh0My91YTFhdlp0MWF6REFLZFBJNi9BZTd6?=
 =?utf-8?B?ZlVoc2xDOWxpaFRzS1B6bVBDOEdhU1FNbU1yWUtXQ3BkSEVSQnlyejhhMjhL?=
 =?utf-8?B?MHVuWkhCeUhIR2ppR3o2NzBCZ0I1Y01iUVdIWDRKRTVJbnoydk5VaXYxdHZH?=
 =?utf-8?B?Z2ZUeUxMRXlsay9qZ0xmUXlZb0ZSZENXUDFYdVJoMTVlRHkwdTEvOGNnNnlG?=
 =?utf-8?B?QW1BR2RONVZVNDNZVFZhT0hCSW5SQ2E2QVdnVXZkc3NQYWpaeExJeXVlWnVG?=
 =?utf-8?B?cGpMemkzV2YvMkxLc3EyQVJERTVzSGFaYWltYks1RGhHQkg5SVZtZlU1bmZ4?=
 =?utf-8?B?MGl2VmFCV2cxeGNPMjB3WWtPNGZQSE5qS3BMTlJYenpJRkpSNG1KRzRJZnE0?=
 =?utf-8?B?ZjliQ2xNMzFqbmlMZy9HZktoSGIvUkQ4S1RwWC9FbnJhRzlMVUFnQUE4N25G?=
 =?utf-8?B?ajM1TkF6WWJrWE5iZmlGYzJLRHBFZGVvOUl3YTk4NDl5M1NjSW5RcktQa3ls?=
 =?utf-8?B?ejNxc3gzUHR1L2c4MUd0ZEx4eWo4SmM2dE1ZcE1RVFZDVzdOWGJQQ2tyVEov?=
 =?utf-8?B?OTRiRjJqc3BDNEsrc0ZQdnkzUHU1WUJCMVF4WE1lbW1LeXNramNRY0Ftdi9Z?=
 =?utf-8?B?ZjZtVG5Ib0t5Z0dYNTcydCtjenp3NmtidzBIeGc4VGNVL21QT1M2VTlBZU9w?=
 =?utf-8?B?TnF4NXYzdWVPNUhpZm95VDd5OE5ZL1lyNmdMQmVNYW80MW1wcEJnTm5NVVd4?=
 =?utf-8?B?MGwvbTRXVlNqb3hlejZoYmJOMGlnTFI0di96OWhiNEVoNW5aODhLOUtBVXEw?=
 =?utf-8?B?YUl1OFZZOFFSdFhlbWVVZGJxdlh5dGJ5LytlL2NMMUZkUllWSXgyeE1PUXFm?=
 =?utf-8?B?bDY4MWM3WGxwaEVqTzBuM2duR3BYSEsrSVJncFJBUlExb1pxOWN3MkJmV1Nz?=
 =?utf-8?B?Znd3bXdTWWkrN0JMbWg0OTRzL05PMytYY0lEQXVCQVlhNWZES0JxdC9pNllT?=
 =?utf-8?B?VGllbm5TSGtIWnNQTHpVT2xqK251YzR3OVI1SCtnaWs1c3EvaEx2cGxKTlhm?=
 =?utf-8?B?RDVaZDJGSHIzRGVIN1lOZGo0MlBZamFLV1RIQ2dIa0ZpQ3I4WjZoVUoxREt4?=
 =?utf-8?Q?V5WfHc0ucOSZPGrEhbtOpDg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2469220d-5424-4530-1449-08d9b59cffc0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 14:06:56.1308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7174HsgIDXD5EJ5iluFafXrpxPzmFPPYRbRyYx25anl3QsEuCoglpdtdMSA0b4Ow/fuiAMUpdI9yjLI2kSbiTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 25.11.2021 14:39, Anthony PERARD wrote:
> We are going to need the variable XEN_BUILD_EFI earlier.
> 
> But a side effect of calculating the value of $(XEN_BUILD_EFI) is to
> also to generate "efi/check.o" which is used for further checks.
> Thus the whole chain that check for EFI support is moved to
> "arch.mk".
> 
> Some other changes are made to avoid too much duplication:
>     - $(efi-check-o): Used to avoid repeating "efi/check.*". We don't
>       set it to the path to the source as it would be wrong as soon
>       as we support out-of-tree build.
>     - $(LD_PE_check_cmd): As it is called twice, with an updated
>       $(EFI_LDFLAGS).
> 
> $(nr-fixups) is renamed to $(efi-nr-fixups) as the former might be
> a bit too generic.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Technically
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Nevertheless a suggestion and a remark:

> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -60,5 +60,47 @@ ifeq ($(CONFIG_UBSAN),y)
>  $(call cc-option-add,CFLAGS_UBSAN,CC,-fno-sanitize=alignment)
>  endif
>  
> +ifneq ($(CONFIG_PV_SHIM_EXCLUSIVE),y)
> +
> +efi-check-o := arch/x86/efi/check.o

How about making this

efi-check := arch/x86/efi/check

That way you wouldn't need to replace the extension in a number of places,
but simply append the respective one in every place using this.

> +# Check if the compiler supports the MS ABI.
> +XEN_BUILD_EFI := $(call if-success,$(CC) $(CFLAGS) -c $(efi-check-o:.o=.c) -o $(efi-check-o),y)
> +
> +# Check if the linker supports PE.
> +EFI_LDFLAGS := $(patsubst -m%,-mi386pep,$(LDFLAGS)) --subsystem=10
> +LD_PE_check_cmd = $(call ld-option,$(EFI_LDFLAGS) --image-base=0x100000000 -o $(efi-check-o:.o=.efi) $(efi-check-o))
> +XEN_BUILD_PE := $(LD_PE_check_cmd)
> +
> +# If the above failed, it may be merely because of the linker not dealing well
> +# with debug info. Try again with stripping it.
> +ifeq ($(CONFIG_DEBUG_INFO)-$(XEN_BUILD_PE),y-n)
> +EFI_LDFLAGS += --strip-debug
> +XEN_BUILD_PE := $(LD_PE_check_cmd)
> +endif
> +
> +ifeq ($(XEN_BUILD_PE),y)
> +
> +# Check if the linker produces fixups in PE by default
> +efi-nr-fixups := $(shell $(OBJDUMP) -p $(efi-check-o:.o=.efi) | grep '^[[:blank:]]*reloc[[:blank:]]*[0-9][[:blank:]].*DIR64$$' | wc -l)
> +
> +ifeq ($(efi-nr-fixups),2)
> +MKRELOC := :
> +else
> +MKRELOC := efi/mkreloc
> +# If the linker produced fixups but not precisely two of them, we need to
> +# disable it doing so.  But if it didn't produce any fixups, it also wouldn't
> +# recognize the option.
> +ifneq ($(efi-nr-fixups),0)
> +EFI_LDFLAGS += --disable-reloc-section
> +endif
> +endif
> +
> +endif # $(XEN_BUILD_PE)
> +
> +export XEN_BUILD_EFI XEN_BUILD_PE MKRELOC
> +export EFI_LDFLAGS
> +endif

Exporting MKRELOC in particular isn't very nice. I wonder whether there
wouldn't be a way to keep it local to xen/Makefile.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:07:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236590.410424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmjl-0007ks-U5; Thu, 02 Dec 2021 14:07:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236590.410424; Thu, 02 Dec 2021 14:07:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmjl-0007kl-Qd; Thu, 02 Dec 2021 14:07:01 +0000
Received: by outflank-mailman (input) for mailman id 236590;
 Thu, 02 Dec 2021 14:07:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vx2B=QT=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msmjk-0007ka-Ep
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:07:00 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c4bbfba-5379-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 15:06:58 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40386)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msmjg-000Hog-pZ (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 02 Dec 2021 14:06:57 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id C13841FF79;
 Thu,  2 Dec 2021 14:06:56 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c4bbfba-5379-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <923d2203-e832-3fe3-a670-530622a39ab3@srcf.net>
Date: Thu, 2 Dec 2021 14:06:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-4-andrew.cooper3@citrix.com>
 <4615dde8-fe24-020d-0432-6935e9c0c9fa@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/8] x86/boot: Fix data placement around __high_start()
In-Reply-To: <4615dde8-fe24-020d-0432-6935e9c0c9fa@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 02/12/2021 11:49, Jan Beulich wrote:
> On 30.11.2021 11:04, Andrew Cooper wrote:
>> multiboot_ptr should be in __initdata - it is only used on the BSP path.
>> Furthermore, the .align 8 then .long means that stack_start is misaligned.
>>
>> Move both into setup.c, which lets the compiler handle the details correctly,
>> as well as providling proper debug information for them.
>>
>> Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

> Nevertheless I'd like to state that defining a variable in C when all
> its uses are in assembly seems a little odd to me.

I don't see it as odd, although I admit that I did try to see if I could
remove multiboot_ptr entirely first.  Xen is after all a single
freestanding binary.

Having the debug information (well - at a minimum, ELF size info) is
important for livepatch binary diffing, and nothing in asm by default
gets any of that.

Letting the compiler do this all for us is physically shorter, and less
prone to errors.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:08:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:08:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236598.410445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmkk-0000R4-Gq; Thu, 02 Dec 2021 14:08:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236598.410445; Thu, 02 Dec 2021 14:08:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmkk-0000Qx-CT; Thu, 02 Dec 2021 14:08:02 +0000
Received: by outflank-mailman (input) for mailman id 236598;
 Thu, 02 Dec 2021 14:08:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vx2B=QT=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msmki-0000DJ-Uk
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:08:00 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 414c4d56-5379-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 15:08:00 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44160)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msmkh-000vSf-0U (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 02 Dec 2021 14:07:59 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EE7B01FF79;
 Thu,  2 Dec 2021 14:07:58 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 414c4d56-5379-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5445b896-23fe-8231-bb8c-3c4ab005511d@srcf.net>
Date: Thu, 2 Dec 2021 14:07:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 5/8] x86/boot: Drop xen_virt_end
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-6-andrew.cooper3@citrix.com>
 <852a6903-02d3-c167-6cef-3079a6b1c64f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <852a6903-02d3-c167-6cef-3079a6b1c64f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 02/12/2021 11:56, Jan Beulich wrote:
> On 30.11.2021 11:04, Andrew Cooper wrote:
>> The calculation in __start_xen() for xen_virt_end is an opencoding of
>> ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
>>
>> This corrects the bound calculations in arch_livepatch_init() and
>> update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
>> with CONFIG_XEN_ALIGN_2M
>>
>> Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
>> dynamically"), there have not been extraneous mappings to delete, meaning that
>> the call to destroy_xen_mappings() has been a no-op.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> While there's a contextual conflict with patch 4, my understanding is
> that this one is independent of that.

Correct.  I was in the middle of writing this patch when I discovered
the disaster which is the logic in patch 4.

>  On that basis
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:10:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:10:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236608.410457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmn3-0001wD-1S; Thu, 02 Dec 2021 14:10:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236608.410457; Thu, 02 Dec 2021 14:10:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msmn2-0001w6-U2; Thu, 02 Dec 2021 14:10:24 +0000
Received: by outflank-mailman (input) for mailman id 236608;
 Thu, 02 Dec 2021 14:10:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tajg=QT=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msmn0-0001w0-NZ
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:10:23 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9432bced-5379-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 15:10:20 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9432bced-5379-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638454220;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5m7riEBINI153SiZ7lnLcBUlTyzs912rG9Gmv2i1tZs=;
  b=hMGDQz7TbQQ9Rkuc/qwPs6K2Fg5R+woQ+x7xgEd11EQyPuH6WQawTIiM
   oq2rTWstYrDLx2qRW2DSOd4lpZv7KtjBzPPx7igCwM1H0FJLO2LgUAH67
   k27WQ4mRxNggihCi01TYjr6wHF212NuHbRNuTeVmhMIIBvYb8Qqjb7xwM
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: D6C1QonRY46sQIO9HGl6DpNfDW3k6HuVD5LtQac2YrvUmU7K57IyCGDExwxOBe8m6mEq6elvR+
 q8pF+WF/fqzWohzRNZUeRx92x0QcVIkaQcld4NkrRno92k4IuP9CyPmc1c/iYRM3DZqEeplnbD
 +T43XieGyZTtseSVcOMqvsxfy/DnJJMmeIkkZ/ZJDW1qhu5n7IsdxTTUyC4bFDFmwuh5q8DYEc
 a0QIeSGVTjTcNKspr3Vf5ODzS9iIXl78KOdoj6I3+JeelRhWXLPyqTlJvIQY0AluFI2s4bAcnE
 2gWq/EbJ7M6t9excVXH6Aea/
X-SBRS: 5.1
X-MesageID: 58626458
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+zj44KIBNB978ExQFE+RPJIlxSXFcZb7ZxGr2PjKsXjdYENShmMEm
 mVOWGmPbv+IMTb3KN90bN7loElQuZCHztNrSwNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7wbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22vu5Tx
 OUVsqe5CgwxAPLmgrUsbCRhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XtYECgmtt1qiiG97QT
 ewyMWpLcS7rIBgRBHAXCZQkoKSB0yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19gUKwt
 m/AuWPjDXkyNtaS1D6E+XKEnfLUkGXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS1yCz6KbkuwGiDysPVgAeQsZ3hfALfGl/v
 rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWiom
 2jikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsaYowGWxFADpU
 J04dy62t7tm4XalznLlfQn1NOv1j8tpyRWF6bKVI7Ev9i6251modp1K7Td1KS9Ba5hfKWS5O
 xOM41oKufe/2UdGi4csOOpd7Oxwk8Dd+SnNDKiIPrKinLAuHON4wM2eTRHJhD28+KTduao+J
 Y2aYa6R4YUyUsxaIM6Nb75Fi9cDn3lmrUuKHMyT50n3gNK2OS/OIZ9YYQTmUwzMxP7dyOkj2
 40EbJXiJtQ2eLCWXxQ7BqZPdw1XdiZiWsitwyGVH8baSjdb9KgaI6a56ZsqepB/nrQTkeHN/
 3qnXVRfxka5jnrCQThmoFg5AF82dZog/389IwI2OlOkhyoqbYq1tf9NfJorZ7g3sudkyKcsH
 fUCfsyBBNVJSyjGpGtBPcWs8tQ6eUT5nx+KMgqkfCM7I8xqSTvW94K2ZQDo7iQPUHa67JNsv
 7262wrHapMfXAA+Xt3OYfeiwgrp73gQke5/RWXSJdxXdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YnRxhUBWjW67qyJBL2xGv7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB748cHmL2c5D6v9EyrND4FbkX
 0uO/p9ROKmTOdOjG1kUfVJ3YuOG3PASuz/T8fVqfxmquH4ppOKKARdIIh2BqC1BN78kYooqz
 NAotNMS9wHi2AEhNcyLj3wM+mmBRpDav37Lan3O7FfXtzcW
IronPort-HdrOrdr: A9a23:SYHS2K2fyhBer19R2U+rSgqjBVRyeYIsimQD101hICG9Lfb3qy
 n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YdT0EcMqyAMbEZt7eD3ODQKb9Jq7PrgcPY55av854ud3AQV0gJ1XYGNu/xKDwOeOApP+tfKH
 LKjfA32AZINE5nJPiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvV
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpWoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DLeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NpuTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQv003MwmMm9yUkqp/FWGmLeXLzEO91a9Mwc/U/WuonhrdCsT9Tpd+CQd9k1wgq7VBaM0oN
 gsCZ4Y5o2mePVmGp6VNN1xMvdfNVa9NC4kEFjiaWgPR5t3cE4klfbMkcEIDaeRCdo18Kc=
X-IronPort-AV: E=Sophos;i="5.87,282,1631592000"; 
   d="scan'208";a="58626458"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L0JzENMQXYXmrDvcafsfbDtxASTYG7aFzsYtkWLQPJ5oxbB0Cb3VZvcofXYWuiHs72c6W3gCOrYSn+Mr91DI7tx1rZrgZtr/zRhNhbqPtsez2r5bTyHkkM9UD3tTH424yJpGrHh+IQ1TX064sa/ITMT/wBSNav4AI9Nd/l7yN4Yvn13xR5SeB++TesIT1QqxUa8SlWb5dQuwqySD306rB+sY0cAnchfRdHsU1EuP/3MPZ5n2REEl8wC5PmOcxZ0EAD76h/+fNYH+bjo2vsUwLjMo4uf1EZ5+C212JbNloaAL/tQ+J1Sm+Rp7JpEgv5Qs92YvnSbfWZxmn989+PDgZA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A+FpX2gHjqb7gQ02q2MTEGl7YjvPNyg3I58FUTOwgcE=;
 b=McM0YArOruaNQ4dEArvHQ9zGyk5giJyI+Yi0WistfCx4JTF1Bripc3J766hO323E8LjTRm4bQxAygOEwryL/i1lVGHHqIuJt6jSYlC07eJVijqbvPNwJb/f2dVBQnU3y9DB0nwUF6DIn98fbIGWxrOl9oZH3RPsAmf4OvpMQp+Nq3B4mJsM6i64HYMOJ+VvulFvG+nC9sTS8aiMlhyoA8o+NuDjmQeK/cYQVzZcxPWPp83jCdnUexS0+J5zYRDGsAikpNtP1woamUyRBvfPY5Fq7FwNuDsi0ZukGu4Djziuj2/wcJ0NlAsR6/FUVd0QI1o3La+PIjP4HxA3mUGN4xw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A+FpX2gHjqb7gQ02q2MTEGl7YjvPNyg3I58FUTOwgcE=;
 b=DSi8Ng1De9aSsx+i8ETbARrqFy9/GeHch8mRBwD7GPYjCuJ86DpcX1BVGcvwa4Uk61dJ9ggkSNIzJxwt7TiQrgBXWIqwPj/PbwxAqu2+bQv0J6SLhtLBSVDvK8cf6AJGIiBPqqDVI19dR5hPtw1aeF5KdaaDQtunQusaQf1jCTQ=
Date: Thu, 2 Dec 2021 15:10:06 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches
Message-ID: <YajTvrZz0xGOR3vT@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
X-ClientProxiedBy: MR1P264CA0033.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2f::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d119bfa5-bab0-4d6b-63a1-08d9b59d73c6
X-MS-TrafficTypeDiagnostic: DM6PR03MB4138:
X-Microsoft-Antispam-PRVS: <DM6PR03MB41387065220E1D66EAD199758F699@DM6PR03MB4138.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:422;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EhH9Bas/EjMzUrOYRbqutaEiWVAzHd4bgJ1wtZ/Kcs/WHRInWMdYDOeH/3qFiILu8+MQ8eoOVJAOFkZEEiLTz9tPJvzkM/qUvLM31XkBS4w7QAjfLjImPj6Cb+Psq5izjxBguILfWQ90I1sXRpEnnlDZdSVe9vFOAeVoj6oOTqeiIMKVgGTJvimfzsKs0EpKLoeNcqKDj9UnsSUcIe46+QAW9kyG+BSmR67poluWB5dSsbfWueQwKiMf4JJp6HbQ4qiaFzVjK9/k0iTrowF4ygpCz0L4ok0804BulehhNa78vBuF1NVoHQpok0p51SNAWeBGEH+kl30xCZbD8OC151FhiHYQzlpK3j7fwttDLpjJ6imFy30X4WhwB0+G2IBsT/upkgjXOOzS/hrbJ1d6Ev5BoGfn1dKBoyXUldd0UOCHZ6NZa44BIeEbBDVaAhrUebHYmRXuZnGxiWzNsnvQCHHTbgOTMKzcnfKHW0caP5CnyFVdiRMIJzfBWubGxh4xHHIBRa4ABJgOA+bwaXs+UGbiP9Fp4iuoB5YK+RF7xUQAHkHv+qV/ADnT12i82BBCz276B+zBvFm5etjJ0frXo/6m3Bs1ncQtYrEyX91cPC0E/SyhDei1PSI67Ydm2+8S3V9FOLZzVOOCi/GCt59rsg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(5660300002)(54906003)(6916009)(86362001)(2906002)(26005)(83380400001)(8676002)(316002)(85182001)(82960400001)(9686003)(6486002)(30864003)(6496006)(33716001)(8936002)(66476007)(956004)(38100700002)(508600001)(66946007)(66556008)(4326008)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUQrK2QvRjVxdDV6VWdXL3FDZ241N0JkSG5MRXlOc0FaQU1LemZXRkREU1Vw?=
 =?utf-8?B?eXJKblYrQlR6WkwrdnV2ME43TzErczJSbDE2WStJUUdya3E0eVRzK0pNSURs?=
 =?utf-8?B?MlZRWFA0alNPbGlrRCtKeCt0YUJvVnBaQldGcnkxaEdwZnVGc0wxV083T3dL?=
 =?utf-8?B?VFhlR0tTSEhVSWZoNUJlNU4rbzRuWWxjOWNTREMyUmVweDJKNFdTdytXdm9j?=
 =?utf-8?B?aTVtVG16ZDQzQlFsMy9HbXI5OVBxN1lxd1lUYWJXbjdnK2h0dDRnb2VQRHF4?=
 =?utf-8?B?dHpYVDBMUUYrbTYvVlRCVFZvTWoyYWV4eFlPZlFoK0RWTXJrUG5DUFhYWEly?=
 =?utf-8?B?MnNhaDJucnlDa200N0t3bGR5a0oxUEpMTnN3MC9hT1RHN2IyM20xZDJTZnlG?=
 =?utf-8?B?NFczZ3F3L1h4MFFTYW1hTlZmbTB1N3JXMG80WUJMa0xIcnRaWU8rWWE4ajU3?=
 =?utf-8?B?UkFFM2xpSnUrTkJHbVVhSEdNczh6RTJZM1hsa0x0Ri9kOU10USthWTF1bktP?=
 =?utf-8?B?d2d6dHUxSWxPMWc3dG1PNHpWbGpYd2o4UDl6OUs4cTVsNWcxVzRvRmtyU1cz?=
 =?utf-8?B?OFBYN1JTZm5FeHFWMXI2QitLSnpFUXJ4WEN0bGJ2SGN0OGFkRmVyb1JGVGVU?=
 =?utf-8?B?Ti9FeThOckhSalNVY1B0NmJKMG00Mk1rRXU2bi81NWhxVUNVUStCaHB2MTc1?=
 =?utf-8?B?OXBoMTNURmhqZUNJMnBzeUpXUERwZUlZclY0RHc3UVpQdmpYd2hZM01ISnFG?=
 =?utf-8?B?cnR4d2JLYlpCV2ZibWg3MjRxQnR0alZOakJobUQwcHByQ2k5Q29nVHNzaFQ2?=
 =?utf-8?B?VnpZbVJDM0gxYTdHWlBUZE5ScmdoU1BZUUZwYkJTU01JdVN3dW1CV1hrdVJZ?=
 =?utf-8?B?ZnN2RDBNL3VSTTFJL1VOOXZrbzdJeEhDcnpTajJHSWRyQ0lVQU5tV2VGVE44?=
 =?utf-8?B?d0JZdXFzZzROYXdvZS8ycjJTOGIzWkxDODVJNW1SYjFSOWpOQnhmcTVoUC9Z?=
 =?utf-8?B?WGxIV1c0d0R5M09GcUNEM0FBVVYwSmYrbDQ4dDJKSnNiSGltWWVyN0FLaWM4?=
 =?utf-8?B?SVRJN3JqKzQyV2NveVFQY0dyVmVYRDBFOVNPdy8vZDV3Njk5SEw1QTg2L1Zx?=
 =?utf-8?B?MndnU0c5bkFmTENOcXBQQjU4ZkwrOVQwb2IrcExvNVpOL0syeWVwaFhlYU9Y?=
 =?utf-8?B?SC9VYU5kT2tqWC82SlFwSnVUUjQ5NDcrM1lRaE5BQ2JQZkMxZDh5SkxwejBS?=
 =?utf-8?B?NjRUbjQ0dWZwNEVzZG1YSkRpYUx0VmF0T0NOS3dudHU4MFBodEQzSFl3MmVH?=
 =?utf-8?B?aUFPbWxKZWI1M0QzOFNsaUI3THVONXlIUnFZK0pRakhWSzVYR2x3cUZhS1dH?=
 =?utf-8?B?YStGNStKWFd3ekQ2bjNzWUZyQk83c292bm1MOTN4MWF4MVNYcDBMS05ZMVlW?=
 =?utf-8?B?Ui9OWDNlQjR1YzV3UDBOYjVLVldabjlYQTQ2aGl1dFo4eFcwN3Bqc3Y0Smdp?=
 =?utf-8?B?ajdORk5iSnJGUFc2MnpBKzFmcTdpR3g5MXFaM2Z2enBCUVQ3U0xRYTZmMisr?=
 =?utf-8?B?NENULzMzWXFsWSt3QVd5ZXJmMHFmVXRPZkllWXplNGJuOWtZM0V1b29yS0Fk?=
 =?utf-8?B?Z09ma3FabFZSWnB2VjhqY0dzRFM3NnRPdUFRQ0F4VitVV3cvdnl2NjFKaTRw?=
 =?utf-8?B?WGhhWDJEaFUyUFlVMW5wN0FMdXZ1bUQ3bmlLNGhrdFpZTnp3VjhVVk1ERmpq?=
 =?utf-8?B?TW01czJVUVlQMjl2TWJQT3ZSUlowZWJ1V3h1S1B5NUM5bkJpb0w2TXJSdFZK?=
 =?utf-8?B?S0F2b3NoVmpRMjNBSnVqZVV6MHlCR0xpTUEyZGQ5UHVlRENSQ3o0V3gyZnFy?=
 =?utf-8?B?dTQ2cVNmTDk0azh0eFlTcHN4LzJDT0xXV3JYNThqK2NYczc4SmE0YndnS2xK?=
 =?utf-8?B?b0xaN1YyYkNYVS9qcUhPM2ZMMlNzeTc3RE9FTFhKWjhoMmxUNTJ2ZkxRditI?=
 =?utf-8?B?R3VQVmFoYlRsOXNFanlURFpGOXFrRVB3ZThLOUNmQTNnczd2MjFWZWtPV0Rq?=
 =?utf-8?B?WGJ0VmcwNGZPTlp4bmo4bk4vbEtwRTFmNWI2VEZOT2ZUMFAxMEgyMDV2WFFN?=
 =?utf-8?B?T2tQUnRabFdCem5WSHdyMEF0L0VkY2FGL2Vtd0djS2VRdklOY3VpOEFDS1RU?=
 =?utf-8?Q?nQSgagrPX3KYFzea8rJPHgs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d119bfa5-bab0-4d6b-63a1-08d9b59d73c6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 14:10:11.0293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1jbhnhDA6NEBn0SuGFhYH98b64p9KfVTWtD9KSWwltZMFWukvJ3ik8M7YBRa0/2DjHkL8L++myR7P2Ls/XnZhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4138
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote:
> For large page mappings to be easily usable (i.e. in particular without
> un-shattering of smaller page mappings) and for mapping operations to
> then also be more efficient, pass batches of Dom0 memory to iommu_map().
> In dom0_construct_pv() and its helpers (covering strict mode) this
> additionally requires establishing the type of those pages (albeit with
> zero type references).
> 
> The earlier establishing of PGT_writable_page | PGT_validated requires
> the existing places where this gets done (through get_page_and_type())
> to be updated: For pages which actually have a mapping, the type
> refcount needs to be 1.
> 
> There is actually a related bug that gets fixed here as a side effect:
> Typically the last L1 table would get marked as such only after
> get_page_and_type(..., PGT_writable_page). While this is fine as far as
> refcounting goes, the page did remain mapped in the IOMMU in this case
> (when "iommu=dom0-strict").
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Subsequently p2m_add_identity_entry() may want to also gain an order
> parameter, for arch_iommu_hwdom_init() to use. While this only affects
> non-RAM regions, systems typically have 2-16Mb of reserved space
> immediately below 4Gb, which hence could be mapped more efficiently.
> 
> The installing of zero-ref writable types has in fact shown (observed
> while putting together the change) that despite the intention by the
> XSA-288 changes (affecting DomU-s only) for Dom0 a number of
> sufficiently ordinary pages (at the very least initrd and P2M ones as
> well as pages that are part of the initial allocation but not part of
> the initial mapping) still have been starting out as PGT_none, meaning
> that they would have gained IOMMU mappings only the first time these
> pages would get mapped writably.
> 
> I didn't think I need to address the bug mentioned in the description in
> a separate (prereq) patch, but if others disagree I could certainly
> break out that part (needing to first use iommu_legacy_unmap() then).
> 
> Note that 4k P2M pages don't get (pre-)mapped in setup_pv_physmap():
> They'll end up mapped via the later get_page_and_type().
> 
> As to the way these refs get installed: I've chosen to avoid the more
> expensive {get,put}_page_and_type(), putting in place the intended type
> directly. I guess I could be convinced to avoid this bypassing of the
> actual logic; I merely think it's unnecessarily expensive.
> 
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -106,11 +106,26 @@ static __init void mark_pv_pt_pages_rdon
>      unmap_domain_page(pl3e);
>  }
>  
> +/*
> + * For IOMMU mappings done while building Dom0 the type of the pages needs to
> + * match (for _get_page_type() to unmap upon type change). Set the pages to
> + * writable with no type ref. NB: This is benign when !need_iommu_pt_sync(d).
> + */
> +static void __init make_pages_writable(struct page_info *page, unsigned long nr)
> +{
> +    for ( ; nr--; ++page )
> +    {
> +        ASSERT(!page->u.inuse.type_info);
> +        page->u.inuse.type_info = PGT_writable_page | PGT_validated;
> +    }
> +}
> +
>  static __init void setup_pv_physmap(struct domain *d, unsigned long pgtbl_pfn,
>                                      unsigned long v_start, unsigned long v_end,
>                                      unsigned long vphysmap_start,
>                                      unsigned long vphysmap_end,
> -                                    unsigned long nr_pages)
> +                                    unsigned long nr_pages,
> +                                    unsigned int *flush_flags)
>  {
>      struct page_info *page = NULL;
>      l4_pgentry_t *pl4e, *l4start = map_domain_page(_mfn(pgtbl_pfn));
> @@ -123,6 +138,8 @@ static __init void setup_pv_physmap(stru
>  
>      while ( vphysmap_start < vphysmap_end )
>      {
> +        int rc = 0;
> +
>          if ( domain_tot_pages(d) +
>               ((round_pgup(vphysmap_end) - vphysmap_start) >> PAGE_SHIFT) +
>               3 > nr_pages )
> @@ -176,7 +193,22 @@ static __init void setup_pv_physmap(stru
>                                               L3_PAGETABLE_SHIFT - PAGE_SHIFT,
>                                               MEMF_no_scrub)) != NULL )
>              {
> -                *pl3e = l3e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
> +                mfn_t mfn = page_to_mfn(page);
> +
> +                if ( need_iommu_pt_sync(d) )
> +                    rc = iommu_map(d, _dfn(mfn_x(mfn)), mfn,
> +                                   SUPERPAGE_PAGES * SUPERPAGE_PAGES,
> +                                   IOMMUF_readable | IOMMUF_writable,
> +                                   flush_flags);
> +                if ( !rc )
> +                    make_pages_writable(page,
> +                                        SUPERPAGE_PAGES * SUPERPAGE_PAGES);
> +                else
> +                    printk(XENLOG_ERR
> +                           "pre-mapping P2M 1G-MFN %lx into IOMMU failed: %d\n",
> +                           mfn_x(mfn), rc);
> +
> +                *pl3e = l3e_from_mfn(mfn, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
>                  vphysmap_start += 1UL << L3_PAGETABLE_SHIFT;
>                  continue;
>              }
> @@ -202,7 +234,20 @@ static __init void setup_pv_physmap(stru
>                                               L2_PAGETABLE_SHIFT - PAGE_SHIFT,
>                                               MEMF_no_scrub)) != NULL )
>              {
> -                *pl2e = l2e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
> +                mfn_t mfn = page_to_mfn(page);
> +
> +                if ( need_iommu_pt_sync(d) )
> +                    rc = iommu_map(d, _dfn(mfn_x(mfn)), mfn, SUPERPAGE_PAGES,
> +                                   IOMMUF_readable | IOMMUF_writable,
> +                                   flush_flags);
> +                if ( !rc )
> +                    make_pages_writable(page, SUPERPAGE_PAGES);
> +                else
> +                    printk(XENLOG_ERR
> +                           "pre-mapping P2M 2M-MFN %lx into IOMMU failed: %d\n",
> +                           mfn_x(mfn), rc);
> +
> +                *pl2e = l2e_from_mfn(mfn, L1_PROT|_PAGE_DIRTY|_PAGE_PSE);
>                  vphysmap_start += 1UL << L2_PAGETABLE_SHIFT;
>                  continue;
>              }
> @@ -310,6 +355,7 @@ int __init dom0_construct_pv(struct doma
>      unsigned long initrd_pfn = -1, initrd_mfn = 0;
>      unsigned long count;
>      struct page_info *page = NULL;
> +    unsigned int flush_flags = 0;
>      start_info_t *si;
>      struct vcpu *v = d->vcpu[0];
>      void *image_base = bootstrap_map(image);
> @@ -572,6 +618,18 @@ int __init dom0_construct_pv(struct doma
>                      BUG();
>          }
>          initrd->mod_end = 0;
> +
> +        count = PFN_UP(initrd_len);
> +
> +        if ( need_iommu_pt_sync(d) )
> +            rc = iommu_map(d, _dfn(initrd_mfn), _mfn(initrd_mfn), count,
> +                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> +        if ( !rc )
> +            make_pages_writable(mfn_to_page(_mfn(initrd_mfn)), count);
> +        else
> +            printk(XENLOG_ERR
> +                   "pre-mapping initrd (MFN %lx) into IOMMU failed: %d\n",
> +                   initrd_mfn, rc);
>      }
>  
>      printk("PHYSICAL MEMORY ARRANGEMENT:\n"
> @@ -605,6 +663,22 @@ int __init dom0_construct_pv(struct doma
>  
>      process_pending_softirqs();
>  
> +    /*
> +     * We map the full range here and then punch a hole for page tables via
> +     * iommu_unmap() further down, once they have got marked as such.
> +     */
> +    if ( need_iommu_pt_sync(d) )
> +        rc = iommu_map(d, _dfn(alloc_spfn), _mfn(alloc_spfn),
> +                       alloc_epfn - alloc_spfn,
> +                       IOMMUF_readable | IOMMUF_writable, &flush_flags);
> +    if ( !rc )
> +        make_pages_writable(mfn_to_page(_mfn(alloc_spfn)),
> +                            alloc_epfn - alloc_spfn);
> +    else
> +        printk(XENLOG_ERR
> +               "pre-mapping MFNs [%lx,%lx) into IOMMU failed: %d\n",
> +               alloc_spfn, alloc_epfn, rc);
> +
>      mpt_alloc = (vpt_start - v_start) + pfn_to_paddr(alloc_spfn);
>      if ( vinitrd_start )
>          mpt_alloc -= PAGE_ALIGN(initrd_len);
> @@ -689,7 +763,8 @@ int __init dom0_construct_pv(struct doma
>          l1tab++;
>  
>          page = mfn_to_page(_mfn(mfn));
> -        if ( !page->u.inuse.type_info &&
> +        if ( (!page->u.inuse.type_info ||
> +              page->u.inuse.type_info == (PGT_writable_page | PGT_validated)) &&

Would it be clearer to get page for all pages that have a 0 count:
!(type_info & PGT_count_mask). Or would that interact badly with page
table pages?

>               !get_page_and_type(page, d, PGT_writable_page) )
>              BUG();
>      }
> @@ -720,6 +795,17 @@ int __init dom0_construct_pv(struct doma
>      /* Pages that are part of page tables must be read only. */
>      mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
>  
> +    /*
> +     * This needs to come after all potentially excess
> +     * get_page_and_type(..., PGT_writable_page) invocations; see the loop a
> +     * few lines further up, where the effect of calling that function in an
> +     * earlier loop iteration may get overwritten by a later one.
> +     */
> +    if ( need_iommu_pt_sync(d) &&
> +         iommu_unmap(d, _dfn(PFN_DOWN(mpt_alloc) - nr_pt_pages), nr_pt_pages,
> +                     &flush_flags) )
> +        BUG();

Wouldn't such unmap better happen as part of changing the types of the
pages that become part of the guest page tables?

>      /* Mask all upcalls... */
>      for ( i = 0; i < XEN_LEGACY_MAX_VCPUS; i++ )
>          shared_info(d, vcpu_info[i].evtchn_upcall_mask) = 1;
> @@ -793,7 +879,7 @@ int __init dom0_construct_pv(struct doma
>      {
>          pfn = pagetable_get_pfn(v->arch.guest_table);
>          setup_pv_physmap(d, pfn, v_start, v_end, vphysmap_start, vphysmap_end,
> -                         nr_pages);
> +                         nr_pages, &flush_flags);
>      }
>  
>      /* Write the phys->machine and machine->phys table entries. */
> @@ -824,7 +910,9 @@ int __init dom0_construct_pv(struct doma
>          if ( get_gpfn_from_mfn(mfn) >= count )
>          {
>              BUG_ON(compat);
> -            if ( !page->u.inuse.type_info &&
> +            if ( (!page->u.inuse.type_info ||
> +                  page->u.inuse.type_info == (PGT_writable_page |
> +                                              PGT_validated)) &&
>                   !get_page_and_type(page, d, PGT_writable_page) )
>                  BUG();
>  
> @@ -840,22 +928,41 @@ int __init dom0_construct_pv(struct doma
>  #endif
>      while ( pfn < nr_pages )
>      {
> -        if ( (page = alloc_chunk(d, nr_pages - domain_tot_pages(d))) == NULL )
> +        count = domain_tot_pages(d);
> +        if ( (page = alloc_chunk(d, nr_pages - count)) == NULL )
>              panic("Not enough RAM for DOM0 reservation\n");
> +        mfn = mfn_x(page_to_mfn(page));
> +
> +        if ( need_iommu_pt_sync(d) )
> +        {
> +            rc = iommu_map(d, _dfn(mfn), _mfn(mfn), domain_tot_pages(d) - count,
> +                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> +            if ( rc )
> +                printk(XENLOG_ERR
> +                       "pre-mapping MFN %lx (PFN %lx) into IOMMU failed: %d\n",
> +                       mfn, pfn, rc);
> +        }
> +
>          while ( pfn < domain_tot_pages(d) )
>          {
> -            mfn = mfn_x(page_to_mfn(page));
> +            if ( !rc )
> +                make_pages_writable(page, 1);

There's quite a lot of repetition of the pattern: allocate, iommu_map,
set as writable. Would it be possible to abstract this into some
kind of helper?

I've realized some of the allocations use alloc_chunk while others use
alloc_domheap_pages, so it might require some work.

> +
>  #ifndef NDEBUG
>  #define pfn (nr_pages - 1 - (pfn - (alloc_epfn - alloc_spfn)))
>  #endif
>              dom0_update_physmap(compat, pfn, mfn, vphysmap_start);
>  #undef pfn
> -            page++; pfn++;
> +            page++; mfn++; pfn++;
>              if ( !(pfn & 0xfffff) )
>                  process_pending_softirqs();
>          }
>      }
>  
> +    /* Use while() to avoid compiler warning. */
> +    while ( iommu_iotlb_flush_all(d, flush_flags) )
> +        break;

Might be worth to print a message here in case of error?

> +
>      if ( initrd_len != 0 )
>      {
>          si->mod_start = vinitrd_start ?: initrd_pfn;
> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -325,8 +325,8 @@ static unsigned int __hwdom_init hwdom_i
>  
>  void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
>  {
> -    unsigned long i, top, max_pfn;
> -    unsigned int flush_flags = 0;
> +    unsigned long i, top, max_pfn, start, count;
> +    unsigned int flush_flags = 0, start_perms = 0;
>  
>      BUG_ON(!is_hardware_domain(d));
>  
> @@ -357,9 +357,9 @@ void __hwdom_init arch_iommu_hwdom_init(
>       * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid
>       * setting up potentially conflicting mappings here.
>       */
> -    i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0;
> +    start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0;
>  
> -    for ( ; i < top; i++ )
> +    for ( i = start, count = 0; i < top; )
>      {
>          unsigned long pfn = pdx_to_pfn(i);
>          unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
> @@ -372,16 +372,30 @@ void __hwdom_init arch_iommu_hwdom_init(
>                                          perms & IOMMUF_writable ? p2m_access_rw
>                                                                  : p2m_access_r,
>                                          0);
> +        else if ( pfn != start + count || perms != start_perms )
> +        {
> +        commit:
> +            rc = iommu_map(d, _dfn(start), _mfn(start), count,
> +                           start_perms, &flush_flags);
> +            SWAP(start, pfn);
> +            start_perms = perms;
> +            count = 1;
> +        }
>          else
> -            rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> -                           perms, &flush_flags);
> +        {
> +            ++count;
> +            rc = 0;
> +        }
>  
>          if ( rc )
>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
>                     d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);

Would be nice to print the count (or end pfn) in case it's a range.

While not something that you have to fix here, the logic here is
becoming overly complicated IMO. It might be easier to just put all
the ram and reserved regions (or everything < 4G) into a rangeset and
then punch holes on it for non guest mappable regions, and finally use
rangeset_consume_ranges to iterate and map those. That's likely faster
than having to iterate over all pfns on the system, and easier to
understand from a logic PoV.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:36:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:36:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236617.410474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnCM-0004rG-3A; Thu, 02 Dec 2021 14:36:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236617.410474; Thu, 02 Dec 2021 14:36:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnCL-0004r9-Vj; Thu, 02 Dec 2021 14:36:33 +0000
Received: by outflank-mailman (input) for mailman id 236617;
 Thu, 02 Dec 2021 14:36:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w6ez=QT=gmail.com=wei.liu.linux@srs-se1.protection.inumbo.net>)
 id 1msnCK-0004r3-PA
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:36:32 +0000
Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com
 [209.85.221.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3d94f568-537d-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 15:36:31 +0100 (CET)
Received: by mail-wr1-f49.google.com with SMTP id q3so37232873wru.5
 for <xen-devel@lists.xenproject.org>; Thu, 02 Dec 2021 06:36:31 -0800 (PST)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id q4sm2636132wrs.56.2021.12.02.06.36.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Dec 2021 06:36:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3d94f568-537d-11ec-976b-d102b41d0961
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=Xh3pKbxTnj8e62DOcRXknPoUROM+BODLvzmQyRbbH8s=;
        b=B46/7L5LrNffEQXoNNpI9oHUBKtMyLXSyOy+PIte9zuDnJ6gmiXZoKWnCaGn+1GrD4
         uP/hneAarwcsryuo/4ZUVGVwxUyh2Q/MFOSxhy5kJiO9DJzqfKRG84qaLu6sbGv5UbR1
         4T6HnVftaguOQfOrDBdNI4PsIkZyPirlNn64g1LGswJCwHZGPBjVJeuqQKOB5Cli9n/K
         PKP0dtEa2t8jSgEIwu4B2BvCVg39AZOhTioozJIi0oOeUqut8fgkIwaV9hvBeym2NFs7
         t7A2AuLUYD1xeSwYHmZOZpW+LVz0xopwaNYF0qER2rOq0SI92Zd1yq9DdFpCD8Nu+w3H
         zxIQ==
X-Gm-Message-State: AOAM531/QsT1tggWPz6+YVUmW6o+8V+apgVRdwNbzWQf9M/+VmQil/Jm
	4RWvykQz3jaRglSlDeD2kQk=
X-Google-Smtp-Source: ABdhPJwNpcGjwNKyiVWqPz1WBsz/Qi/GLv2M+5yPM20JS1pf2ye6xEbrzai84zM0oO2HmmRa7dC8TQ==
X-Received: by 2002:adf:fb0c:: with SMTP id c12mr15988721wrr.614.1638455790749;
        Thu, 02 Dec 2021 06:36:30 -0800 (PST)
Date: Thu, 2 Dec 2021 14:36:28 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	Wei Liu <wei.liu@kernel.org>, x86@kernel.org,
	linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org,
	ath11k@lists.infradead.org, Juergen Gross <jgross@suse.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch 11/22] x86/hyperv: Refactor hv_msi_domain_free_irqs()
Message-ID: <20211202143628.dgiikgujigylogoz@liuwe-devbox-debian-v2>
References: <20211126222700.862407977@linutronix.de>
 <20211126223824.737214551@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211126223824.737214551@linutronix.de>

On Sat, Nov 27, 2021 at 02:18:51AM +0100, Thomas Gleixner wrote:
> No point in looking up things over and over. Just look up the associated
> irq data and work from there.
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Wei Liu <wei.liu@kernel.org>


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:39:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:39:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236628.410487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnFW-0005f3-N7; Thu, 02 Dec 2021 14:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236628.410487; Thu, 02 Dec 2021 14:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnFW-0005ew-KB; Thu, 02 Dec 2021 14:39:50 +0000
Received: by outflank-mailman (input) for mailman id 236628;
 Thu, 02 Dec 2021 14:39:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w6ez=QT=gmail.com=wei.liu.linux@srs-se1.protection.inumbo.net>)
 id 1msnFV-0005ep-Io
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:39:49 +0000
Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com
 [209.85.221.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b33f68c9-537d-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 15:39:48 +0100 (CET)
Received: by mail-wr1-f49.google.com with SMTP id c4so60109840wrd.9
 for <xen-devel@lists.xenproject.org>; Thu, 02 Dec 2021 06:39:48 -0800 (PST)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id z5sm2876037wmp.26.2021.12.02.06.39.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Dec 2021 06:39:47 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b33f68c9-537d-11ec-b1df-f38ee3fbfdf7
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=72a6A507OnldVCWrhDSc/GY7lKjxc4B5WRBxEFXAJ3U=;
        b=j29VSA2nzfxWr/3i4tutxcCgbxCipuNnqH5nzUF0LNptmlDTLmthQmiMXIfAXKUASa
         1KajBlgOHnA2mSB4dcJNmOZad8n3FwZ/PXB+aXITs2jzCgFemWvOI+pJqRdoFP7yX/r5
         JQTibtGVMJYkLhbQRihY7RqMHvnxkFqJHdvHSFxWT+e9aM0Y0GCmrg+61UNRokJECdez
         tMEndJwszy+oyWCHdE7IYeNp9V3m8oTFAPra/JUl5t536OJf0BHOHkvq3Z2Pag98/m44
         JfhZLmQBtlO8iP8zFO0ttAzsE0DioWxzjDmkfTJFOKlvrVjBEIs6ctIovKso+bfcOOk1
         +wdQ==
X-Gm-Message-State: AOAM532HiH76ptzhSg4deWWZRsOjnX2tKfsHlR6ZSfarcwYi8f8REP2+
	TpZWwRvP1ucNO66pDtJjkcY=
X-Google-Smtp-Source: ABdhPJxPzdtd3RdqIbFdq4J+qJfyoes2s3XiUvAs4cyVDgX4hcthvPCvHGkt6Ry5P/1NlIy3ec+13w==
X-Received: by 2002:adf:d4c2:: with SMTP id w2mr14815368wrk.225.1638455988303;
        Thu, 02 Dec 2021 06:39:48 -0800 (PST)
Date: Thu, 2 Dec 2021 14:39:46 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
	wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, jgross@suse.com,
	sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
	will@kernel.org, davem@davemloft.net, kuba@kernel.org,
	jejb@linux.ibm.com, martin.petersen@oracle.com, arnd@arndb.de,
	hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com, thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, brijesh.singh@amd.com, konrad.wilk@oracle.com,
	hch@lst.de, parri.andrea@gmail.com, dave.hansen@intel.com
Subject: Re: [PATCH V3 2/5] x86/hyper-v: Add hyperv Isolation VM check in the
 cc_platform_has()
Message-ID: <20211202143946.7o7ncwcjq3t6xcrq@liuwe-devbox-debian-v2>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-3-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211201160257.1003912-3-ltykernel@gmail.com>

On Wed, Dec 01, 2021 at 11:02:53AM -0500, Tianyu Lan wrote:
> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
> 
> Hyper-V provides Isolation VM which has memory encrypt support. Add
> hyperv_cc_platform_has() and return true for check of GUEST_MEM_ENCRYPT
> attribute.
> 
> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
> ---
>  arch/x86/kernel/cc_platform.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/x86/kernel/cc_platform.c b/arch/x86/kernel/cc_platform.c
> index 03bb2f343ddb..f3bb0431f5c5 100644
> --- a/arch/x86/kernel/cc_platform.c
> +++ b/arch/x86/kernel/cc_platform.c
> @@ -11,6 +11,7 @@
>  #include <linux/cc_platform.h>
>  #include <linux/mem_encrypt.h>
>  
> +#include <asm/mshyperv.h>
>  #include <asm/processor.h>
>  
>  static bool __maybe_unused intel_cc_platform_has(enum cc_attr attr)
> @@ -58,9 +59,23 @@ static bool amd_cc_platform_has(enum cc_attr attr)
>  #endif
>  }
>  
> +static bool hyperv_cc_platform_has(enum cc_attr attr)
> +{
> +#ifdef CONFIG_HYPERV
> +	if (attr == CC_ATTR_GUEST_MEM_ENCRYPT)
> +		return true;
> +	else
> +		return false;

This can be simplified as

	return attr == CC_ATTR_GUEST_MEM_ENCRYPT;


Wei.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:41:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:41:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236633.410512 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnGo-0007Ij-Ag; Thu, 02 Dec 2021 14:41:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236633.410512; Thu, 02 Dec 2021 14:41:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnGo-0007Ic-7g; Thu, 02 Dec 2021 14:41:10 +0000
Received: by outflank-mailman (input) for mailman id 236633;
 Thu, 02 Dec 2021 14:41:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnGn-00072F-8v
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:41:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnGn-0002sp-84
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:41:09 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnGn-0004iZ-7D
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:41:09 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1msnGg-0001cG-CA; Thu, 02 Dec 2021 14:41:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=IdKijzTVza9VWjHs/w1KY38fWn3s9Wj3zBBWmEmfja0=; b=LAVEUZyFpxd1q1hrejfirCsl6f
	5+5XU7/LrXsB+ZHVsJqqncU9J2T3QZHvlIItNNJVSLDrwt3dJC9F7S4fGSEjH65RuMhhnkL5+A+W6
	LOxd5bMj0zHNQJ5VPQIhBCD1Dew+iVmeDVN639lgq27bTaR3LyQoVqXEn08RneTqEpuU=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Message-ID: <25000.56055.611856.335342@mariner.uk.xensource.com>
Date: Thu, 2 Dec 2021 14:40:55 +0000
To: xen-announce@lists.xenproject.org
CC: xen-devel@lists.xenproject.org,
    xen-users@lists.xenproject.org
Subject: Xen 4.16 is released

Xen 4.16, the product of 9 months' work by the Xen Project community,
is now released.

You can find it here:
  git clone -b RELEASE-4.16.0 https://xenbits.xen.org/git-http/xen.git
  https://downloads.xenproject.org/release/xen/4.16.0/
For more information see the release notes:
  https://wiki.xenproject.org/wiki/Xen_Project_4.16_Release_Notes
There is also the press release:
  https://xenproject.org/2021/04/08/xen-project-hypervisor-4-15/

Xen 4.16 has a number of improvements, ranging from cleanups to
significant new features in a number of areas:
  https://wiki.xenproject.org/wiki/Xen_Project_4.16_Feature_List
(reproduced below).

Thanks and congratulations are due to all the people and organisations
who have contributed.  Well done, everyone!

Ian.
(Xen 4.16 Release Manager)


Notable Features
================

This release has seen the increase in hardware support for both x86 and Arm,
together with the addition of other improvements and features:

  • Miscellaneous fixes to the TPM manager software in preparation for TPM 2.0
    support.
  • Increased reliance on the PV shim as 32-bit PV guests will only be
    supported in shim mode going forward. This change reduces the attack
    surface in the hypervisor.
  • Increased hardware support by allowing Xen to boot on Intel devices that
    lack a Programmable Interval Timer.
  • Cleanup of legacy components by no longer building QEMU Traditional or
    PV-Grub by default. Note both projects have upstream Xen support merged
    now, so it is no longer recommended to use the Xen specific forks.
  • Initial support for guest virtualized Performance Monitor Counters on Arm.
  • Improved support for dom0less mode by allowing the usage on Arm 64bit
    hardware with EFI firmware.
  • Improved support for Arm 64-bit heterogeneous systems by leveling the CPU
    features across all to improve big.LITTLE support.

Features and improvements
=========================

CI loop (gitlab CI)

  • 32-bit Arm builds.
  • Full system tests for x86.

Ongoing activities
==================

The Xen community has several interesting initiatives, where work is ongoing
and is expected to bear fruit in forthcoming releases. Some of the highlights:

Functional Safety
-----------------

In collaboration with the Zephyr project and the MISRA consortium, the Xen
FuSaSpecial Interest Group analyzed MISRA C rules in depth and defined a subset
of rules that apply to Xen and will be tackled with the community. The SIG
evaluated several static code analyzers to scan the Xen code base for MISRA
Cviolations. The team started enhancing the Xen build system with the ability
to run open source MISRA C checkers as part of the Xen build, so that for
future releases Xen, contributors will be able to easily improve the quality of
their patches.

RISC-V Port
-----------

RISC-V, an open standard instruction set architecture (ISA) based on
established reduced instruction set computer (RISC) principles, is a free and
open ISA enabling hardware designers to design simpler chips with a
royalty-free ISA. The Xen community, led by sub-project XCP.ng, is working on a
RISC-V Port for Xen. During this release cycle significant work has been
ongoing internally in order to get dom0 booting on RISC-V hardware, focusing on
introducing the functionality to allow interrupt management, together with
other interfaces required for early boot code.

VirtIO
------

The development of VirtIO support for Arm continued making progress, currently
focusing on introducing a mechanism to ease the mapping of memory from remote
domains by reporting memory regions of the domain currently unused. Further
work has also been done in order to improve the toolstack support to handle
VirtIO block devices.

Zephyr RTOS
-----------

As a result of collaboration between the Zephyr and Xen projects, starting
version 2.7.0, Zephyr RTOS supports some basic Xen specific features allowing
it to run on Xen. With further Xen enhancements on review and development:
grant tables, XenBus and starting Zephyr as Domain-0, Xen is getting closer to
a full implementation of a RTOS-based "thin dom0" targeting Embedded and Safety
use cases.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:43:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:43:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236668.410542 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnJF-0000v6-4O; Thu, 02 Dec 2021 14:43:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236668.410542; Thu, 02 Dec 2021 14:43:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnJF-0000ux-1P; Thu, 02 Dec 2021 14:43:41 +0000
Received: by outflank-mailman (input) for mailman id 236668;
 Thu, 02 Dec 2021 14:43:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w6ez=QT=gmail.com=wei.liu.linux@srs-se1.protection.inumbo.net>)
 id 1msnJE-0000t3-Dd
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:43:40 +0000
Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com
 [209.85.128.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3cce049c-537e-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 15:43:39 +0100 (CET)
Received: by mail-wm1-f49.google.com with SMTP id
 az34-20020a05600c602200b0033bf8662572so3775418wmb.0
 for <xen-devel@lists.xenproject.org>; Thu, 02 Dec 2021 06:43:39 -0800 (PST)
Received: from liuwe-devbox-debian-v2 ([51.145.34.42])
 by smtp.gmail.com with ESMTPSA id b15sm3831942wri.62.2021.12.02.06.43.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 02 Dec 2021 06:43:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cce049c-537e-11ec-b1df-f38ee3fbfdf7
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=ngfxfU8cMx05IJ2GEXLujweygC6BKjS+/TEJnexPuyU=;
        b=wn3pWrpHgyaKMDcCD1+lUt5MhetWnEo7gl6WsjkzOuiL/YxUvV2hu7ff/Uixgt/N8k
         xer8Jy+FmVUDA12MO/NiHDEO+5sHOMntiDnVfCUgW7D4B3h6SakVfJh8mMq+LJJ2Y7mb
         udjT5QwnO98CXBMJRComHn7RNksXWI2Fj1MalWEcBlBEYAurQgosqEUCULBWh2nWyuG+
         PGAQcZateUgvjWRpAEMF8SfOSJIqhXMVTeL9DO7bMMhyJQCKrBFZWBDxbVvHtSvbu3WV
         1UJ0TIjAAtl6lf1r+/dWDSBEbpQ/nzqveowAjlFvVnpHjsA4tY4LNhyMSM5uWIelFH4v
         UiPQ==
X-Gm-Message-State: AOAM532ov/ixCe7DXTqcCO2cOfF5+NCHcN4KgvcPdsUwJns6V3Fq3v9U
	URF11tX1bxRoH/ZQhcs1dHs=
X-Google-Smtp-Source: ABdhPJzcC/sLI+YXsme26UERQHG8ONsijhz0w3mw0YtYq520oHvctN0qsFmSNBM5FNo5EKfA2KQfgA==
X-Received: by 2002:a1c:ed18:: with SMTP id l24mr7167526wmh.99.1638456219030;
        Thu, 02 Dec 2021 06:43:39 -0800 (PST)
Date: Thu, 2 Dec 2021 14:43:36 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
	wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, jgross@suse.com,
	sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
	will@kernel.org, davem@davemloft.net, kuba@kernel.org,
	jejb@linux.ibm.com, martin.petersen@oracle.com, arnd@arndb.de,
	hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
	Tianyu.Lan@microsoft.com, thomas.lendacky@amd.com,
	xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, brijesh.singh@amd.com, konrad.wilk@oracle.com,
	hch@lst.de, parri.andrea@gmail.com, dave.hansen@intel.com
Subject: Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Message-ID: <20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-4-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211201160257.1003912-4-ltykernel@gmail.com>

On Wed, Dec 01, 2021 at 11:02:54AM -0500, Tianyu Lan wrote:
[...]
> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
> index 46df59aeaa06..30fd0600b008 100644
> --- a/arch/x86/xen/pci-swiotlb-xen.c
> +++ b/arch/x86/xen/pci-swiotlb-xen.c
> @@ -4,6 +4,7 @@
>  
>  #include <linux/dma-map-ops.h>
>  #include <linux/pci.h>
> +#include <linux/hyperv.h>
>  #include <xen/swiotlb-xen.h>
>  
>  #include <asm/xen/hypervisor.h>
> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
>  EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
>  
>  IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> -		  NULL,
> +		  hyperv_swiotlb_detect,

It is not immediately obvious why this is needed just by reading the
code. Please consider copying some of the text in the commit message to
a comment here.

Thanks,
Wei.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 14:47:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 14:47:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236688.410553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnMt-0001uf-N4; Thu, 02 Dec 2021 14:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236688.410553; Thu, 02 Dec 2021 14:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnMt-0001uY-K2; Thu, 02 Dec 2021 14:47:27 +0000
Received: by outflank-mailman (input) for mailman id 236688;
 Thu, 02 Dec 2021 14:47:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tItF=QT=amd.com=Thomas.Lendacky@srs-se1.protection.inumbo.net>)
 id 1msnIV-0006xK-Q7
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 14:42:56 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2060f.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::60f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 209a8291-537e-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 15:42:53 +0100 (CET)
Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12)
 by DM8PR12MB5414.namprd12.prod.outlook.com (2603:10b6:8:3e::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.21; Thu, 2 Dec
 2021 14:42:50 +0000
Received: from DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a]) by DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a%3]) with mapi id 15.20.4734.020; Thu, 2 Dec 2021
 14:42:50 +0000
Received: from [10.236.30.241] (165.204.77.1) by
 BL0PR05CA0018.namprd05.prod.outlook.com (2603:10b6:208:91::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.9 via Frontend Transport; Thu, 2 Dec 2021 14:42:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 209a8291-537e-11ec-976b-d102b41d0961
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rbm5Tla++bGXbxll262BN/XAd22z/RmfqGgGZfvaQTgYRZe26CtVQFuQZA28U1X4fafNPSSW4MvLlBTN2yCBgvLcPzwQe8IpRHrKUMadGdmvzft12zy4FdXF5wEV/QcgM2JvPruIjUK6GQ+xlzGTjmNQAZkLe0GlfxkxK+PjLfs7lTcaNsZtn4NqFqGJMUwEa0m0LuDxue7UwkjJ1aY4LeIH+1ObkGzsvrzueKFTOoeEEeTpcdDHcO3v0JYhPhk709Xq81yafhFFEDDaSib/9qjqddnDniMb7ZocjYZHFqMQY4z28jlpmAiKS4Tzhgw1qGtZ5+3PhLkhkRxduSsrvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3X5kwCUFYFBft7dEmRdcY8+rUQnT155lmn/gv9noPls=;
 b=OCe2SZiwIn+3d/AGOTqHXJQzWinwQIiZ5c1Fv3dKKyxps5ZmW7v4J168Oj/xWe27qT+GAyn+UfrFAuAoQTsBCp7DYBiGNN9zQ1uQ8lrc1FXyw2r1Gf5STYnza9S88yu48Gy5ZvGhGwqeeFbLR3HGLOeh3XxACsQEDV7IgKtgubdToLlT70VDNMx5y/bXo8v79ngTXqDClZtfkaMcnyT7wDHVkfFxmTRIoucE54rHr3EGjpPz1hT0fEBqLsjoJdpMZtDkWd8r/gzTvzCFqqEisjs1KQE9Zc3aT96AcffHRZvA9PkeZXerLZacnE7AY1RL6qoTHHI7PYXWorYGsI27MA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3X5kwCUFYFBft7dEmRdcY8+rUQnT155lmn/gv9noPls=;
 b=m6uo3w4KiLfGmj85LYSvUoiVH+8pO2aXJyflfqbwvSmgF3vcAlF1Y3nGG9EiFDHKnsFbylZdmGqq31oI67e3zosNYNU3COqCuSvXYnjd5fmKiZNeKAZAALpbQkyE6i2jkh8AsuYmoIbN3g0gtoDJVSSKLJkGh/Tbxft6Q1pxcdU=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Subject: Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-2-ltykernel@gmail.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
Date: Thu, 2 Dec 2021 08:42:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211201160257.1003912-2-ltykernel@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: BL0PR05CA0018.namprd05.prod.outlook.com
 (2603:10b6:208:91::28) To DM4PR12MB5229.namprd12.prod.outlook.com
 (2603:10b6:5:398::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 406c7820-3a6d-471b-64c7-08d9b5a20358
X-MS-TrafficTypeDiagnostic: DM8PR12MB5414:
X-Microsoft-Antispam-PRVS:
	<DM8PR12MB5414492EA765B93F4A92E1E5EC699@DM8PR12MB5414.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	anJcp1NohdjpXt2U8fABO+x73isA3f0plr5211ilOJZ4nO/ad6E7N+M3BlMWcZtwrxgBtwfT7LFubkMSE3Igvs7eR3jk7LoTmj5N8NWAyd8rOYTnBBof/HJwz7PSRkTDAG5PnmDPH4gvJoHXK3h8X+HGYssaj2U+FQhgGEjD1Q22ZHBb8ieIL3xXyc2hKdPT2I2LVabj/+a/6mppAAiWmOje9WvDNyMbryC2uRyyK7W6BkIS0RyyUntEHQvkzig6aQm+QsJMlKDVbFoGheoE1wwPtvpYKlhrIeiuCY9c9ss2wEBxsduolV8ylRwaWSOFulzraTR50JAmazaTjPP5XkDvwzvG4BqzHyL0Er0AmHcBKOr6vKgl1sThdIQpQJY2fMV63illxJCQ35xRxoDMgwHaTiur0x2+SphUoYNi1s7yOFtNaJdIrlF+7/Dhb/2KW2n/jsdYqujxq0cMX/zk/0OCvopuqjZjq4pJJ7bkPNWsKwNF5xdahcEnz1XTl07LrcIiMzXuRNE1Cd4Hz6TOTbtjQCFSAejP6Y5hMl270qAgczM6sUiszlHfirBohwv9iuCvNjL0JWAHDxUpgfKWTKyQbLS6hdkAREQBO2yFB5cemrNllvyaEEBU88ssfG31Uuffk6OLLgowKoe8cE6vux/kX9JFabh0AfFmB3VQ2NwIPoeZN4HjfwbEDmALB1VetcqMN4EHZaKieir1n7bESbkWMOECpL4wuIsLLHnJOLikuMcCFWdoZGUnquQVxiIo
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(83380400001)(956004)(36756003)(8676002)(5660300002)(4326008)(53546011)(6486002)(66946007)(508600001)(86362001)(45080400002)(26005)(31696002)(316002)(7406005)(921005)(66476007)(38100700002)(2616005)(2906002)(16576012)(186003)(66556008)(8936002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aFVoOVNXb1VHQnl1VXdTR2VQbW5jVXpNSTY2WkNBMlJ3VWNJcWNXNFRaUTNK?=
 =?utf-8?B?S0hteXVaRDFGd01haExObWZKeEZucmo4UFVZeWMvbHNqQmZCVysyanludXQ2?=
 =?utf-8?B?eFBWa1pyNXQ0QzVFWGlmdGM4blhucld3MW0ydThXSjNVYmVhR1BrZ1ppczVK?=
 =?utf-8?B?R2VyNWxKL1hKSkx5UUtpNHdET29heTdlVmxQQndxRm01ZFQ3RmphQXhVRmhU?=
 =?utf-8?B?MmFqSGd0b0FIT0hlNG15TWVzSTFZTlpaZHJjelpPYXNHM0JpRm1oZGZTcEs3?=
 =?utf-8?B?NWlQSXNONGFUbkRYVTRqd2JXTXZGL3FUeDFVWUNzMisrVzgzenlRNm9sR0dh?=
 =?utf-8?B?ODV5dk5OekFDOUl6ZENGcnRPeWlORE92TjhCS09sbWgvdVNVRENmQ2JPYmJs?=
 =?utf-8?B?Q21oaWw2RENmaXZHVzh4d0xMTGV6MURNY3JwZ1I3NXY1T09yN1NXOXlxMm1V?=
 =?utf-8?B?SHI4N3BvYUhwUk9FTS9pS2VwWjQ5d3pzVlVsZlkyM0FwcVdVQ0lNTUJFazly?=
 =?utf-8?B?MUE2MnRHS21YeEVycnNJb0lFVVMxWnUyNVh3ODFuZFpIb1prZ0RFaVlZR3RC?=
 =?utf-8?B?RDJRSUpYMm0vT3lhSS9aeHBTOEJZOVkxOUdHcE5ZMFAxazlhZFNuZXh3bjZt?=
 =?utf-8?B?WVNaeTFTdlpkSVJjWmZQUUo0dU90eUUwbVZBT0V5Z0tXaXRET0dMRlZZL2x5?=
 =?utf-8?B?cU5uc1Q2SWMzZ2MvNUdKTXJINjVLTjA2ckdlNDdkNWNHQVIzOVZKdTVGOUZP?=
 =?utf-8?B?V0lPMDdNL2MzWklPWmdIQkFiU0ltblkxaE1yOUNWU09MY3Z2K2s4bVA4NUw3?=
 =?utf-8?B?MmVpRmdiQ3l3SnRuRXo1bUp4dEx0TGlUUkJXWjEzVlJsWkFaL3p4cmtBL1o2?=
 =?utf-8?B?bjlBVVB3bEJyNUJBcnVQRU13QUJIc2kxTU94NWF3U04zcm9KOWEvTnFLWS9w?=
 =?utf-8?B?VkhSWS9TQ3E4QXdjVVNlaXpxbGQ1bCt4SGNRNXhvbm1PcHJ2L3h5YkNoM0py?=
 =?utf-8?B?MFdEYXExS3hmZ2VZQVRhVU9PYlFVVzBWNnc1MWlNVDB4cXl0amRkVSs2dGFZ?=
 =?utf-8?B?blVJSDVSTS9WNDdZQnYvMjRYcGpsYytqSXVJSXBpc3JPaHBpTnlVR2JSaEVp?=
 =?utf-8?B?YXlwVzZzS1QrVkluamZDY2w1TnJYME5IK1JQT1YybkN3cTNQZWFDSWZ0MGVh?=
 =?utf-8?B?aDREeE1yMlg4UzNDZlBwdVdlbmNNTCt1MHFSZ2ZqMmhLTUUvdktYSVBoR1dW?=
 =?utf-8?B?cVRaVHhTa29pWnRrTGpxY3A5d2NTNWcvWXFxM2pUMXZkejJRbVZDVWRJRUdw?=
 =?utf-8?B?UlR0bXIweWFZTEpNbDVpbEJoUGtZSkZDWnN5REpzMzFORDZLc0ZwOHJlT2tz?=
 =?utf-8?B?bEdFdmpGbnRaY21EQ0lZZW9JQkx0MTBYNkNuVDlwOVpRdWJyemNDTm9wM3Zn?=
 =?utf-8?B?ZDBhNmN4OVhOVzZRc1M4dGZvWUZ2UENBZ3B4NGdnWmx1T0k5Ty9YcERHZlBj?=
 =?utf-8?B?ZEF2bWxML01CRkVCNFFuUVIvNzFIT29jNE44MzhhdEFBRWlvMWw2cWMrMmFG?=
 =?utf-8?B?RnBuZnhNK3Y1anJhU0dWOTF0ZFlkcFk5cWo4eGh5aVlVTU9TRzNUWmwxeE0r?=
 =?utf-8?B?VEdEUTlLT0NORlVkcmRnKytJOFlYQW9INUREenZXT01Oa0pBVHp6SncwaHJi?=
 =?utf-8?B?Mkw3NTdSQzYyWmJWNFBYWHpCYXNnUXBnWGRtWERFQTY2b2VYWmFYamxlbmU2?=
 =?utf-8?B?R2RXaHJYT00veXBpOHVGaVFrWWJKelRxZHgyVXNtdWE5QlE4M2ZCd0xKV090?=
 =?utf-8?B?NG5naTV0UEdXam9PR2hUUVpVOXZKZy9oQkZobWVCbWlUN09wOU1tUWYzamd0?=
 =?utf-8?B?dXczUzE1L2dhaC9qOVYreFdBZlRPN3JTVTJ5VUxpNFhYTHBPNmM5OUQ1dWVl?=
 =?utf-8?B?bFFRbDYrL3VaN2VOODNwTjMvZ3orU0E5WkU0M0JFbWRTUHYrRFFwY09iUFZz?=
 =?utf-8?B?eW9pbHkxWjE2UWJKU3lhTmVHWnY4Uy8wZmx1aURtbW04TW12MDFiY0J2NFdW?=
 =?utf-8?B?dUwvQVdJakdQSC9nT2xrVkhITHdjcHNjME96VlEwYkZBbGVsSDRNdGhaNGxr?=
 =?utf-8?B?eHFRdzR0Smx4TktwT05CczcvM213QnJXWHJwMDBsTmZpL2RqNUIxeVhrdVcv?=
 =?utf-8?Q?QrTbpkvt1Cy8jg+uAEVBT9c=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 406c7820-3a6d-471b-64c7-08d9b5a20358
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 14:42:49.8395
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ddpU5OU8lbhY56Jgh/i3+IHYuvJ5Q5N5FNrH4xEfKnLY4LkrpYTCig0kYJWel2Gdvp2EV2NZUmHf1yOw2w7hhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5414

On 12/1/21 10:02 AM, Tianyu Lan wrote:
> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
> 
> In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
> extra address space which is above shared_gpa_boundary (E.G 39 bit
> address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
> physical address will be original physical address + shared_gpa_boundary.
> The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
> memory(vTOM). Memory addresses below vTOM are automatically treated as
> private while memory above vTOM is treated as shared.
> 
> Expose swiotlb_unencrypted_base for platforms to set unencrypted
> memory base offset and platform calls swiotlb_update_mem_attributes()
> to remap swiotlb mem to unencrypted address space. memremap() can
> not be called in the early stage and so put remapping code into
> swiotlb_update_mem_attributes(). Store remap address and use it to copy
> data from/to swiotlb bounce buffer.
> 
> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>

This patch results in the following stack trace during a bare-metal boot
on my EPYC system with SME active (e.g. mem_encrypt=on):

[    0.123932] BUG: Bad page state in process swapper  pfn:108001
[    0.123942] page:(____ptrval____) refcount:0 mapcount:-128 mapping:0000000000000000 index:0x0 pfn:0x108001
[    0.123946] flags: 0x17ffffc0000000(node=0|zone=2|lastcpupid=0x1fffff)
[    0.123952] raw: 0017ffffc0000000 ffff88904f2d5e80 ffff88904f2d5e80 0000000000000000
[    0.123954] raw: 0000000000000000 0000000000000000 00000000ffffff7f 0000000000000000
[    0.123955] page dumped because: nonzero mapcount
[    0.123957] Modules linked in:
[    0.123961] CPU: 0 PID: 0 Comm: swapper Not tainted 5.16.0-rc3-sos-custom #2
[    0.123964] Hardware name: AMD Corporation
[    0.123967] Call Trace:
[    0.123971]  <TASK>
[    0.123975]  dump_stack_lvl+0x48/0x5e
[    0.123985]  bad_page.cold+0x65/0x96
[    0.123990]  __free_pages_ok+0x3a8/0x410
[    0.123996]  memblock_free_all+0x171/0x1dc
[    0.124005]  mem_init+0x1f/0x14b
[    0.124011]  start_kernel+0x3b5/0x6a1
[    0.124016]  secondary_startup_64_no_verify+0xb0/0xbb
[    0.124022]  </TASK>

I see ~40 of these traces, each for different pfns.

Thanks,
Tom

> ---
> Change since v2:
> 	* Leave mem->vaddr with phys_to_virt(mem->start) when fail
> 	  to remap swiotlb memory.
> 
> Change since v1:
> 	* Rework comment in the swiotlb_init_io_tlb_mem()
> 	* Make swiotlb_init_io_tlb_mem() back to return void.
> ---
>   include/linux/swiotlb.h |  6 ++++++
>   kernel/dma/swiotlb.c    | 47 ++++++++++++++++++++++++++++++++++++-----
>   2 files changed, 48 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index 569272871375..f6c3638255d5 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
>    * @end:	The end address of the swiotlb memory pool. Used to do a quick
>    *		range check to see if the memory was in fact allocated by this
>    *		API.
> + * @vaddr:	The vaddr of the swiotlb memory pool. The swiotlb memory pool
> + *		may be remapped in the memory encrypted case and store virtual
> + *		address for bounce buffer operation.
>    * @nslabs:	The number of IO TLB blocks (in groups of 64) between @start and
>    *		@end. For default swiotlb, this is command line adjustable via
>    *		setup_io_tlb_npages.
> @@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
>   struct io_tlb_mem {
>   	phys_addr_t start;
>   	phys_addr_t end;
> +	void *vaddr;
>   	unsigned long nslabs;
>   	unsigned long used;
>   	unsigned int index;
> @@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct device *dev)
>   }
>   #endif /* CONFIG_DMA_RESTRICTED_POOL */
>   
> +extern phys_addr_t swiotlb_unencrypted_base;
> +
>   #endif /* __LINUX_SWIOTLB_H */
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 8e840fbbed7c..adb9d06af5c8 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -50,6 +50,7 @@
>   #include <asm/io.h>
>   #include <asm/dma.h>
>   
> +#include <linux/io.h>
>   #include <linux/init.h>
>   #include <linux/memblock.h>
>   #include <linux/iommu-helper.h>
> @@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;
>   
>   struct io_tlb_mem io_tlb_default_mem;
>   
> +phys_addr_t swiotlb_unencrypted_base;
> +
>   /*
>    * Max segment that we can provide which (if pages are contingous) will
>    * not be bounced (unless SWIOTLB_FORCE is set).
> @@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
>   	return DIV_ROUND_UP(val, IO_TLB_SIZE);
>   }
>   
> +/*
> + * Remap swioltb memory in the unencrypted physical address space
> + * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
> + * Isolation VMs).
> + */
> +void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
> +{
> +	void *vaddr = NULL;
> +
> +	if (swiotlb_unencrypted_base) {
> +		phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
> +
> +		vaddr = memremap(paddr, bytes, MEMREMAP_WB);
> +		if (!vaddr)
> +			pr_err("Failed to map the unencrypted memory %llx size %lx.\n",
> +			       paddr, bytes);
> +	}
> +
> +	return vaddr;
> +}
> +
>   /*
>    * Early SWIOTLB allocation may be too early to allow an architecture to
>    * perform the desired operations.  This function allows the architecture to
> @@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
>   	vaddr = phys_to_virt(mem->start);
>   	bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
>   	set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
> -	memset(vaddr, 0, bytes);
> +
> +	mem->vaddr = swiotlb_mem_remap(mem, bytes);
> +	if (!mem->vaddr)
> +		mem->vaddr = vaddr;
> +
> +	memset(mem->vaddr, 0, bytes);
>   }
>   
>   static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
> @@ -196,7 +225,18 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
>   		mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
>   		mem->slots[i].alloc_size = 0;
>   	}
> +
> +	/*
> +	 * If swiotlb_unencrypted_base is set, the bounce buffer memory will
> +	 * be remapped and cleared in swiotlb_update_mem_attributes.
> +	 */
> +	if (swiotlb_unencrypted_base)
> +		return;
> +
> +	set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
>   	memset(vaddr, 0, bytes);
> +	mem->vaddr = vaddr;
> +	return;
>   }
>   
>   int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
> @@ -318,7 +358,6 @@ swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs)
>   	if (!mem->slots)
>   		return -ENOMEM;
>   
> -	set_memory_decrypted((unsigned long)tlb, bytes >> PAGE_SHIFT);
>   	swiotlb_init_io_tlb_mem(mem, virt_to_phys(tlb), nslabs, true);
>   
>   	swiotlb_print_info();
> @@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
>   	phys_addr_t orig_addr = mem->slots[index].orig_addr;
>   	size_t alloc_size = mem->slots[index].alloc_size;
>   	unsigned long pfn = PFN_DOWN(orig_addr);
> -	unsigned char *vaddr = phys_to_virt(tlb_addr);
> +	unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
>   	unsigned int tlb_offset, orig_addr_offset;
>   
>   	if (orig_addr == INVALID_PHYS_ADDR)
> @@ -806,8 +845,6 @@ static int rmem_swiotlb_device_init(struct reserved_mem *rmem,
>   			return -ENOMEM;
>   		}
>   
> -		set_memory_decrypted((unsigned long)phys_to_virt(rmem->base),
> -				     rmem->size >> PAGE_SHIFT);
>   		swiotlb_init_io_tlb_mem(mem, rmem->base, nslabs, false);
>   		mem->force_bounce = true;
>   		mem->for_alloc = true;
> 


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:05:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:05:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236700.410573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msneN-0004cX-Fp; Thu, 02 Dec 2021 15:05:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236700.410573; Thu, 02 Dec 2021 15:05:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msneN-0004cQ-Ca; Thu, 02 Dec 2021 15:05:31 +0000
Received: by outflank-mailman (input) for mailman id 236700;
 Thu, 02 Dec 2021 15:05:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zjRX=QT=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1msneM-0004cH-Bz
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:05:30 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 48bde4e8-5381-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 16:05:28 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90442142F;
 Thu,  2 Dec 2021 07:05:27 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3FDF33F73B;
 Thu,  2 Dec 2021 07:05:26 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48bde4e8-5381-11ec-976b-d102b41d0961
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] docs/efi: Fix wrong compatible in dts example
Date: Thu,  2 Dec 2021 15:05:17 +0000
Message-Id: <20211202150517.53029-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

The example in section "UEFI boot and dom0less on ARM" has
a wrong compatible for the DTB passthrough, it is "ramdisk"
instead of "device-tree".
This patch fixes the example.

Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI boot")
Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
Question: Does it makes sense to backport it to 4.16?
---
 docs/misc/efi.pandoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index 4abbb5bb82..abafb34527 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -222,7 +222,7 @@ domU1 {
 		xen,uefi-binary = "initrd-3.0.31-0.4-xen";
 	};
 	module@3 {
-		compatible = "multiboot,ramdisk", "multiboot,module";
+		compatible = "multiboot,device-tree", "multiboot,module";
 		xen,uefi-binary = "passthrough.dtb";
 	};
 };
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:12:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:12:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236709.410584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnkx-0006Dc-5G; Thu, 02 Dec 2021 15:12:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236709.410584; Thu, 02 Dec 2021 15:12:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnkx-0006DV-27; Thu, 02 Dec 2021 15:12:19 +0000
Received: by outflank-mailman (input) for mailman id 236709;
 Thu, 02 Dec 2021 15:12:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tajg=QT=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msnkv-0006D9-Ek
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:12:17 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3adcd354-5382-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:12:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3adcd354-5382-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638457935;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=FfPhDdg0qiK+r9jFOYXWn9Bvt/kqYwiqoUoUOQJaym4=;
  b=RcLkf4ZxZsFzChofkx5TSsf1ovoRCQJ3u++rrO2gtKcyGEqOk4gKHvO9
   TU1WEOW+0DBM8Xy86zGGKXgK4qCps6PlLd8SRAKJoUy2qPC3nu7HeqQqM
   2eml5mqjoUtue7SLTPs5YT30dgMADGasNkae0tljFbybQjZfhgXaotrWT
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TERmFwh/AZttJMMXTVf971msz11ogxUq14znQztCE/GeG70a3Opg/MMAqFI/bHKoszlCu4vPpJ
 gP5jtDJpdedcHlWtgZbiY4zA2zb/B9rSd7LaRxseDfTHV4VqKjJfsT/qmgCYATsg51e6jmt94F
 KXEb07L0uSDBkS3dmbyGLF0Su8B26uabL3bd/TUUgVl6OMLqApVgEfB1YX6bPVQqR5D2sOpAVv
 JWUAB5SUwbG7PNJk2s0qmQh9qmdUtuIb0RSz6kESXWDPlrYNXX6l8C/TtH+pGy9QGZXfrqhxC9
 QvfHlGvnAdR7jq/Lc82lt1Wk
X-SBRS: 5.1
X-MesageID: 61156758
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:D5FAIaMItiAJ3KnvrR18kMFynXyQoLVcMsEvi/4bfWQNrUoghWAGn
 DAfWG3XOvuNYGqkft0jbovioRwH6sfXn4dnSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En5400o5w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2iUn4hr1
 4lXjpGLYykYMbfyhf5DeBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uTvIIGg2pg7ixINfqHY
 5YjRghEVg7JSUdWKhAcC9UswOj90xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTXlvX7cpAFAQeFdKMcU2Q6X9LfOvS2WUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb10qXFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr5vmuVh6b/PuREDGQ3C94bd+51qXHb4
 hA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSXzJtALvG4kfRw0WirhRdMPS
 BSI0e+2zMUNVEZGkIctO97hYyjU5feI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5fQlkgEDrShOnK/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chYwJIPXiSKVJAOURGpkbb+zD59zoWhiZX4nPEqy2mhlaoGqtf9Ne5wydLgh1epi0f8rE
 KVVJ5TeWqxCGmbd5jAQTZjht4g+Jh6lsh2DYni+az8lcp8+GwGQoo34fhHi/TUlBzassZdsu
 KWp0w7WGMJRRwlrAMvMRuioyle94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrtZsotfThK2Co4O4KMdEHxJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbiquMIzglgG3mXPV2nBqk5fyuD1MhL8KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+OvVWEpfCBCAlShBIeYnK4gi2
 +og5JYb5gHXZsDG6TpaYvS4L1ixE0E=
IronPort-HdrOrdr: A9a23:vXw2u6zzt259xY7OQy7dKrPxsOskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WB3B8bfYOCGghrTEGgG1+rfKlLbakjDH4JmpM
 Ndmu1FeaLN5DtB/LbHCWuDYq4dKbC8mcjC74qurAYOPHJXguNbnnxE426gYzxLrWJ9dOME/f
 Snl616T23KQwVoUi33PAhJY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX232oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iBnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDA4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWArqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocWTbqjVQGagoBT+q3oYpxqdS32BnTq+/blnQS+pUoJjHfxn6ck7zA9HJFUcegM2w
 2LCNUvqFh0dL5iUUtKPpZ2fSKGMB2+ffvyChPnHb3GLtBNB5ufke+83F0KjNvaD6DgiqFCwa
 j8bA==
X-IronPort-AV: E=Sophos;i="5.87,282,1631592000"; 
   d="scan'208";a="61156758"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KF1HlQfFYrmBJWtdhzgDhJ4J61JI8EU3KB1lQbuJF2sjNDIcqU5v6xJZblSuLaBxBlWT1t4RAUVC/80PB93Pg0hBVxnPrDAc/CakgZ31syuO96fxM/m/61qw0DBkO7nWSqYuvy2EOV+CsKjTmknr/+r0olR4WQJmvlcoQ9ALRIq7RrI6oIVO4l1YF1CUf79m++yhNBehK2LFJMy6BmEy8uwuK9WCWi+yQuiJdMmLUj0JhzW00ykEMDn0AHhlfum6D0/clp5rpCsC5UZXNdNOf6wXULTj2Ydw1mTaFaHKJoe7E+c7WeQeP6Szeu/McbKnAoJT8jcmahIolCvjUy3Xsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jTQFAG6wpkOKgjfyVnQ76+u2NHrJ9pA1hz7kcG7xu6Q=;
 b=EPza+GnOD+os3ZSIV9HGopIMnxr9Q9KMBW2wH54MxAbZIywJ4Z70w6s5r6rs4T99Q1TsTMexifOpDgF4nYmVxlQcQwb29hIOz3b6uoolGTpEWVtQmJhPumx/bpw9fn4Zf+UKS00MbZCp8L8bAzmiP6P2NdFWWGY36mZotei8btMtIh3mc5D6u6gkVr1xx5fXQ+HpD+7gWJoKWgy2g+le2sU6R+46JjuBafiZP8RCtYb9yCp1ZbcG3yiUY/UscOX+67znOiB/iqStld5lLxIFD03+KvSZsP6CIpbp1zyQgSI0CG9/ynz+YPApi/x1U4hcUhUADgbnYbAF+iL9byPHpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jTQFAG6wpkOKgjfyVnQ76+u2NHrJ9pA1hz7kcG7xu6Q=;
 b=EYn8oJEb6l0bO9NtoULqJL70fiE8Je1MMiM6u6uwPkEhih99JxexJyRdIWEVp4bDHpfmAsoh6NxgEzux3/1ft8qhg0SVl1bf3Xv0CsTcK7BvxMTrP34wX7bfKldQXZ9GX5x9Ng7UTmy3dsIY04872qdXthzPGQCWGgS8TEJOgDM=
Date: Thu, 2 Dec 2021 16:12:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Message-ID: <YajiQeaPx7KcL0Tw@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
 <YadPLZqfN2pu5SeG@Air-de-Roger>
 <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
X-ClientProxiedBy: MR2P264CA0160.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bb563910-dcd2-4d36-5a71-08d9b5a619f6
X-MS-TrafficTypeDiagnostic: DM6PR03MB4683:
X-Microsoft-Antispam-PRVS: <DM6PR03MB46835A8BAD98D6722F3015AA8F699@DM6PR03MB4683.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: pyqpHUbsdbzsMeHRSCxQQKNkF5Rqe35/3ME+hrXAM/byeAiBmyt5T7F/xK/vBK/dv4NvaGeCwbrgv+84Gphf2J9J8DKGk4zr6KVAkLNzwj7ddnK6mrfJaejZil15GakyfT1atxZtNVqUAca3f082gKLRtQwcchw1COAF64BI6ekVVMlaPKckbtwhjwCVvh9NRKbnMucpXAQbHlYX4X8/ytqEeXuDvrdPEyoeVb0kOuPdokstDLfdh5ByF8D8gnWdkJLQba7FDPFztGyxfuEy2RtiLLq1Sf6qYzSq3Ak4BU/vAvUBuPS9rwAmZaI0A7bSvZOQe+MffIg0TgouSKe2wqPJv/MwtJRQg6iKYwDcrH5IrLYJo9TE6SWdwzdWlyj5DuywmgxM23Rs9ZG7SIk3366gTWdE0TW3CQFQkZTdXNxRGI/lIUiz6De2FzSm3jli1yA1NfnyW2/ei1xCt2d5uO4VfLC7Lu25S+mBY4R9YEftOBDLsOx5u++JA3178V5nXsRaftnSJCg3ioDOmIHe9OWst0+BbwDb5Dhz1W0EmByXOKVlCD1spjOZ8m1xBppeaIjpNUJMrrX07lH/KKWW+VMfU710cDWNhP+NZCLstdQpl7mRew5PgaEbATOElbkE1WwjfZU377x+bnIgANY50A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(5660300002)(33716001)(53546011)(2906002)(186003)(38100700002)(83380400001)(82960400001)(6496006)(6916009)(54906003)(66476007)(316002)(26005)(8936002)(9686003)(86362001)(508600001)(66946007)(8676002)(6666004)(85182001)(6486002)(956004)(4326008)(66556008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3lsODVhRURRRmxCdU4xL2dtYjBHSUhXWUNjZkZBbitjY1hTM0RCWUxycGxF?=
 =?utf-8?B?SDR2bFUwd2dqY2FQdTFmckUrRjFHaFQ1OTJEclpkOVJZMUpvS1FVNGJPeVJT?=
 =?utf-8?B?endoaC9jak56OWVmRXRrbWVWZ0p4c2ZsVTFZaWovZjUvT3hCMEVnRHlVK29V?=
 =?utf-8?B?TVBmaEhLUVdjSllLZEYyYjNIdm05ZmY5ZVdNd0gyd1RCbjh6VEVoUHpsaVA1?=
 =?utf-8?B?c25JRDQwT3IycDBKUG1PWnNPR0hnUUJHcDhjZUdSS2lmNWZhVWg1MzUreVhI?=
 =?utf-8?B?VnhXUXpJRDJLUTFGSXhRZFozVlhUQmN0OWZDanNkelp4MkIydmpLL0lwN3Zm?=
 =?utf-8?B?S1Q3bVdQNDBlRVM4UExXOFByaHRkU0lFVWR1Y04wZlZEeEhSa1BjTVdib1Zh?=
 =?utf-8?B?MzlJcm1RRThBbnRRWGhGMHppUVVPT3hXeTdqRkNjMWcrK1pJaHBPMEFsMHo0?=
 =?utf-8?B?WDg2SDRiSHNMUDFGUGloRVBJREJheGlDZy8zZWlieFZiaXJkeWpscTRsUTdI?=
 =?utf-8?B?Yk9ydVFsZkY2eWtYVk1zQnRoZ1BrU2xnUmtEa012NXlhMk1yZ1BubGNXdDE1?=
 =?utf-8?B?M2svY0JYN0YyOERMMk9NWTNwbDlhZm85ZXBQYUFsRVdrZjdybnpLek8yeGFK?=
 =?utf-8?B?djNPejFFQi9LM2JvYkt5REJ5Vi9mWDRRNzVrakNkd09MRVFJZHdlKzlGNUxW?=
 =?utf-8?B?MXVyeHJIb1c5Ym83RWoveHBDd29FRjNEN3JNYlJoYmlKYnkrQ0JzSzlnSFJo?=
 =?utf-8?B?K0xMMkp6MUVuWC9lWTJWODVVbEFvL2F0YW95RU93aTY5dlNqc0o4MGdQU0xI?=
 =?utf-8?B?WTlQSkZZa0hRUFd1ZjN3b0pPM1dtbG91c0gxUXdHUUhCS1BQRldLU3lRa05k?=
 =?utf-8?B?djJTV0s1aTVjTWpVRkxGcjVvbDZsSmFTNGMwbldFaGozWjloR3RxNUZUUlNu?=
 =?utf-8?B?WGtmVjEyVk4vMkZoYWlleEswakcyWWc5YUhjcUJmUUZiVVgvaEo3TXFXcFZm?=
 =?utf-8?B?YjJnbWhjL0JPM0RqSE1XbWl3WEhRU2k4WG5XVGkvU2EyOEJwNGhieUEwTHdh?=
 =?utf-8?B?aGxyNEptZ0IyMW1Nb3NqN3pycDhpZzQrdHNkUElrQmwzcjNzaDUyeHRQUGVi?=
 =?utf-8?B?OTRscVJZSHZkYW1mbmJhalZnZUNuZVpHVWVLRXp5OEdhTURkZFBrbFJ2N3lr?=
 =?utf-8?B?aWVodlVVL1R2T1lncVhONWU4QllRWDVocjh1bFhZbjlaYUxCV05VQUFHRFJu?=
 =?utf-8?B?TG53dXBhM0FyNCtvLzkrc045NnV1RktXTC8va2N5WTV6WmVSYTRXNW1QYkJq?=
 =?utf-8?B?VzBwZEtoU0U1UTBXODFwaGQzZHZWMHl4MXcxdHNadmU0bndLWTFnTEY3TzdU?=
 =?utf-8?B?UU1wRjh1TWRjMDNwVjIrVUV2cWJRU2FvajdsV3VoZk0vbTg2YllzQ3hxUDZx?=
 =?utf-8?B?aWpiOUcvZEVhQ0dLUDZlSkRDa0lKeW5WWkdzajFrN3F2SWxjOHJCeGNMUndG?=
 =?utf-8?B?aVBBTVRPUTA0bndKd05EdlZJcmY2enNNdHlJWXFLdjFVanAvdVdKSlRaSEpQ?=
 =?utf-8?B?dmpxd25Lc3pZZ0I2SlBCcytpRlhVZG5BVmFpem9GMzNZTFM2TXFxa0lNclg2?=
 =?utf-8?B?WDF5U1ZUTkJSUDlzSWp2QkVuQzdVMmJtTXQvNTQxcGRIYnBIemRDN0JJNWJl?=
 =?utf-8?B?bDlLOE41SkdqakowdEFBN1VQdGp2MENqR1I3Rkc1RXh6WEphMWdNcUlYYkZG?=
 =?utf-8?B?c1ZRSDdIVkdVcklGQzh3eVduQ1NOdUFkcTRWcXY3dGFBNWJabGFKRm8vd3VR?=
 =?utf-8?B?a1hIMEJPdEpZYllwRHVjSTRQeGZVT3dpKzN3WXhXWHVFb2FERHlSc2hIMXEw?=
 =?utf-8?B?RXhWaldIREVLSnduN1dUSEU4UWlzVGVqenBGajdIL2tIR1dZTHZ1WVlrQ0lJ?=
 =?utf-8?B?dlJFNWpuc0V6Y09scDRqdURWcHV5djF1cWxsVkxWMndMMFVvakNjMnVYUXQx?=
 =?utf-8?B?SWdVS29lVjdhY3kvR1UwcXg2RzZKSjhQajFpMGlLWU5VSDEvMjdXeVJZZnU5?=
 =?utf-8?B?QS9TYWo0aWJwbHpzUmcvTllncUdpd3FNb3gybWhQcWFvQUFyRjhicFN0RnpM?=
 =?utf-8?B?UmNVUzlzcmowSUk4a1FzNkU0RzNLR3lvMFFWd2lFUC9IWHZtNDVucjdnUlQ4?=
 =?utf-8?Q?w070DPUNQWjMvLH9VCLW4XM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bb563910-dcd2-4d36-5a71-08d9b5a619f6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 15:12:05.5773
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sH8ybKpXkt/FHxrOTTxZhcp6aTYfECa/ASkKutT2Pd9sR7LT4qljjPHZwD/YNHDGVoPUc0ZI6ZD5L/wmnmfZnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4683
X-OriginatorOrg: citrix.com

On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote:
> On 01.12.2021 11:32, Roger Pau Monné wrote:
> > On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
> >> On 01.12.2021 10:09, Roger Pau Monné wrote:
> >>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
> >>>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
> >>>>       * that fall in unusable ranges for PV Dom0.
> >>>>       */
> >>>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
> >>>> -        return false;
> >>>> +        return 0;
> >>>>  
> >>>>      switch ( type = page_get_ram_type(mfn) )
> >>>>      {
> >>>>      case RAM_TYPE_UNUSABLE:
> >>>> -        return false;
> >>>> +        return 0;
> >>>>  
> >>>>      case RAM_TYPE_CONVENTIONAL:
> >>>>          if ( iommu_hwdom_strict )
> >>>> -            return false;
> >>>> +            return 0;
> >>>>          break;
> >>>>  
> >>>>      default:
> >>>>          if ( type & RAM_TYPE_RESERVED )
> >>>>          {
> >>>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
> >>>> -                return false;
> >>>> +                perms = 0;
> >>>>          }
> >>>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn )
> >>>> -            return false;
> >>>> +        else if ( is_hvm_domain(d) )
> >>>> +            return 0;
> >>>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
> >>>> +            perms = 0;
> >>>
> >>> I'm confused about the reason to set perms = 0 instead of just
> >>> returning here. AFAICT perms won't be set to any other value below,
> >>> so you might as well just return 0.
> >>
> >> This is so that ...
> >>
> >>>>      }
> >>>>  
> >>>>      /* Check that it doesn't overlap with the Interrupt Address Range. */
> >>>>      if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
> >>>> -        return false;
> >>>> +        return 0;
> >>>>      /* ... or the IO-APIC */
> >>>> -    for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
> >>>> -        if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> >>>> -            return false;
> >>>> +    if ( has_vioapic(d) )
> >>>> +    {
> >>>> +        for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ )
> >>>> +            if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
> >>>> +                return 0;
> >>>> +    }
> >>>> +    else if ( is_pv_domain(d) )
> >>>> +    {
> >>>> +        /*
> >>>> +         * Be consistent with CPU mappings: Dom0 is permitted to establish r/o
> >>>> +         * ones there, so it should also have such established for IOMMUs.
> >>>> +         */
> >>>> +        for ( i = 0; i < nr_ioapics; i++ )
> >>>> +            if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
> >>>> +                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
> >>>> +                       ? IOMMUF_readable : 0;
> >>>> +    }
> >>
> >> ... this return, as per the comment, takes precedence over returning
> >> zero.
> > 
> > I see. This is because you want to map those in the IOMMU page tables
> > even if the IO-APIC ranges are outside of a reserved region.
> > 
> > I have to admit this is kind of weird, because the purpose of this
> > function is to add mappings for all memory below 4G, and/or for all
> > reserved regions.
> 
> Well, that was what it started out as. The purpose here is to be consistent
> about IO-APICs: Either have them all mapped, or none of them. Since we map
> them in the CPU page tables and since Andrew asked for the two mappings to
> be consistent, this is the only way to satisfy the requests. Personally I'd
> be okay with not mapping IO-APICs here (but then regardless of whether they
> are covered by a reserved region).

I'm unsure of the best way to deal with this, it seems like both
the CPU and the IOMMU page tables would never be equal for PV dom0,
because we have no intention to map the MSI-X tables in RO mode in the
IOMMU page tables.

I'm not really opposed to having the IO-APIC mapped RO in the IOMMU
page tables, but I also don't see much benefit of doing it unless we
have a user-case for it. The IO-APIC handling in PV is already
different from native, so I would be fine if we add a comment noting
that while the IO-APIC is mappable to the CPU page tables as RO it's
not present in the IOMMU page tables (and then adjust hwdom_iommu_map
to prevent it's mapping).

I think we should also prevent mapping of the LAPIC, the HPET and the
HyperTransport range in case they fall into a reserved region?

TBH looks like we should be using iomem_access_permitted in
arch_iommu_hwdom_init? (not just for the IO-APIC, but for other device
ranges)

> >>>> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
> >>>>      for ( ; i < top; i++ )
> >>>>      {
> >>>>          unsigned long pfn = pdx_to_pfn(i);
> >>>> +        unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn);
> >>>>          int rc;
> >>>>  
> >>>> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
> >>>> +        if ( !perms )
> >>>>              rc = 0;
> >>>>          else if ( paging_mode_translate(d) )
> >>>> -            rc = set_identity_p2m_entry(d, pfn, p2m_access_rw, 0);
> >>>> +            rc = set_identity_p2m_entry(d, pfn,
> >>>> +                                        perms & IOMMUF_writable ? p2m_access_rw
> >>>> +                                                                : p2m_access_r,
> >>>> +                                        0);
> >>>>          else
> >>>>              rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> >>>> -                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> >>>> +                           perms, &flush_flags);
> >>>
> >>> You could just call set_identity_p2m_entry uniformly here. It will
> >>> DTRT for non-translated guests also, and then hwdom_iommu_map could
> >>> perhaps return a p2m_access_t?
> >>
> >> That's an orthogonal change imo, i.e. could be done as a prereq change,
> >> but I'd prefer to leave it as is for now. Furthermore see "x86/mm: split
> >> set_identity_p2m_entry() into PV and HVM parts": In v2 I'm now also
> >> adjusting the code here 
> > 
> > I would rather adjust the code here to just call
> > set_identity_p2m_entry instead of differentiating between PV and
> > HVM.
> 
> I'm a little hesitant, in particular considering your suggestion to
> then have hwdom_iommu_map() return p2m_access_t. Andrew has made quite
> clear that the use of p2m_access_* here and in a number of other places
> is actually an abuse.
> 
> Plus - forgot about this in my earlier reply - there would also be a
> conflict with the next patch in this series, where larger orders will
> get passed to iommu_map(), while set_identity_p2m_entry() has no
> respective parameter yet (and imo it isn't urgent for it to gain one).

I've seen now as the iommu_map path is modified to handle ranges
instead of single pages. Long term we also want to expand this range
handling to the HVM branch.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:20:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:20:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236716.410608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnsj-0008B1-7w; Thu, 02 Dec 2021 15:20:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236716.410608; Thu, 02 Dec 2021 15:20:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnsj-0008Au-4r; Thu, 02 Dec 2021 15:20:21 +0000
Received: by outflank-mailman (input) for mailman id 236716;
 Thu, 02 Dec 2021 15:20:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnsh-0007qX-TG
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:20:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnsh-0003Ze-SN
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:20:19 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1msnsh-0008Ib-RZ
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:20:19 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1msnsL-0001jd-4x; Thu, 02 Dec 2021 15:19:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=O6b2fLLa0NvKYldrbNUtChOHahKwWxiz8PzvcVfhC5Y=; b=p/hFAHHaORXgDZnu/hXDsoJNPR
	aGu2w2FakKjZhOfX6DfQsnzcCyDlQr03i02ImOfvZJUm9CRJkFpswufu7IosHv+GxLhdBb4bNbr4L
	ja0hDZkgYl8NJ2kAb+LuitThQrS8SAr+sQLtKVEQf376U0vasluXhk1ZxfApr0vkmyvE=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25000.58384.67916.802992@mariner.uk.xensource.com>
Date: Thu, 2 Dec 2021 15:19:44 +0000
To: xen-announce@lists.xenproject.org
Cc: xen-devel@lists.xenproject.org,
    xen-users@lists.xenproject.org
Subject: Re: Xen 4.16 is released
In-Reply-To: <25000.56055.611856.335342@mariner.uk.xensource.com>
References: <25000.56055.611856.335342@mariner.uk.xensource.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Correction:

I wrote:
> Xen 4.16, the product of 9 months' work by the Xen Project community,
> is now released.
> 
> You can find it here:
>   git clone -b RELEASE-4.16.0 https://xenbits.xen.org/git-http/xen.git
>   https://downloads.xenproject.org/release/xen/4.16.0/
> For more information see the release notes:
>   https://wiki.xenproject.org/wiki/Xen_Project_4.16_Release_Notes
> There is also the press release:

This should have instead linked to the blog post:
  https://xenproject.org/2021/12/02/xen-project-ships-version-4-16-with-focus-on-improved-performance-security-and-hardware-support/

> Xen 4.16 has a number of improvements, ranging from cleanups to
> significant new features in a number of areas:
>   https://wiki.xenproject.org/wiki/Xen_Project_4.16_Feature_List
> (reproduced below).
> 
> Thanks and congratulations are due to all the people and organisations
> who have contributed.  Well done, everyone!

Ian.
(Xen 4.16 Release Manager)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:25:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:25:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236763.410638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnxF-0001yS-6E; Thu, 02 Dec 2021 15:25:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236763.410638; Thu, 02 Dec 2021 15:25:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msnxF-0001yL-2c; Thu, 02 Dec 2021 15:25:01 +0000
Received: by outflank-mailman (input) for mailman id 236763;
 Thu, 02 Dec 2021 15:25:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cBvN=QT=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1msnxE-0001yF-Cu
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:25:00 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0629.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::629])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 031a241e-5384-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:24:59 +0100 (CET)
Received: from DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::23)
 by AS8PR08MB7354.eurprd08.prod.outlook.com (2603:10a6:20b:445::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 2 Dec
 2021 15:24:58 +0000
Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:55:cafe::bb) by DB6PR1001CA0037.outlook.office365.com
 (2603:10a6:4:55::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 15:24:58 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Thu, 2 Dec 2021 15:24:57 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Thu, 02 Dec 2021 15:24:57 +0000
Received: from d07d045da3f0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2558DBB0-AC96-4651-8AAD-F0841A115CB4.1; 
 Thu, 02 Dec 2021 15:24:44 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d07d045da3f0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 02 Dec 2021 15:24:44 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3990.eurprd08.prod.outlook.com (2603:10a6:20b:a3::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 15:24:40 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.028; Thu, 2 Dec 2021
 15:24:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 031a241e-5384-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pMut5AUiKFNEZm+rPzI75XxpolMLFaHvrDxTGjbU9Ps=;
 b=ghsOOW+C6w9zuRmsQsgcSpRx9qv6l3AyCsJMtFihDefwSsw7nx/UaoEWLZBeMA0tT/duN/biM7t3krhH/ks3aFVn4Ww49NLPs4pVHWC30EnbkWJYqGqSWu5kOaR8ijgP5vu7Z7+n0KdI1IDGtVjir7xt/o9DNvx12hkX4rsL+Tk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 52b9efb9995c3028
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j6WGvaaqlmVMQbjVT6eZfztFCbW6RZwIGdmjA/IQ9gXFkeAMRK2AOGyzzPn0av/Sy7y+dIZg5YPiK5hTzJMbLNxV9fLty5NW4D0NfyUNj7VREov+dc3MYgc1zqGWN+zC00gR6XAO8F+Lwf3+IXcHQNCVebqKUo3m9Yz/qKAPWT17JS9myxQLbitphq/vpH7P1u5bn+phARJZR9NkwCixK+fOXsqkx70oitgGeZ5mlX773Mfb76/FK1lrnIq+dYVk478ESxyguMrRuUK4UNtFRtCzm0FA1bhjOW/Lu/xUX0etybBmdNtcST2LhJi6Q+rVDkgMaYQPRrz6pPyzt4C7BQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pMut5AUiKFNEZm+rPzI75XxpolMLFaHvrDxTGjbU9Ps=;
 b=UbXHsWqFMMrOCtmDmYGeXetEsHwUMJplInvvJRSIwqS1FOx9muJ2M8KJ8yqQZzzKVwnwuYtjglsMBTUlA1KQFDKg45jzznWiU0kuBBufcDm0xmwfR+NRblEivFHQRUVgOdcTv+G9Kt5WcXqtogsJpPsq31URS/rmTGp0FbCA6O5SAT4jhbNrTK7nysM+eDUoLRNk7R+innNHwh0msnIdSBtUDseZIG0O5T5K1RCMD99gHnKmB+je+qf+wE8TP3Clq0ORO5iH74AnBwVQdvZ74wYd93yum8l61x9/FjPjNp6ZEQCkA43n8C7ineHM/XRWWd4Y2bQbTcinyBHXu+5Utg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pMut5AUiKFNEZm+rPzI75XxpolMLFaHvrDxTGjbU9Ps=;
 b=ghsOOW+C6w9zuRmsQsgcSpRx9qv6l3AyCsJMtFihDefwSsw7nx/UaoEWLZBeMA0tT/duN/biM7t3krhH/ks3aFVn4Ww49NLPs4pVHWC30EnbkWJYqGqSWu5kOaR8ijgP5vu7Z7+n0KdI1IDGtVjir7xt/o9DNvx12hkX4rsL+Tk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <Wei.Chen@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Jan Beulich
	<jbeulich@suse.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] docs/efi: Fix wrong compatible in dts example
Thread-Topic: [PATCH] docs/efi: Fix wrong compatible in dts example
Thread-Index: AQHX544UfhMBQb0bWUyJNXlX8DEMHawfUlYA
Date: Thu, 2 Dec 2021 15:24:40 +0000
Message-ID: <86AF2C3E-77D9-4394-8FF6-84900B56D1B4@arm.com>
References: <20211202150517.53029-1-luca.fancellu@arm.com>
In-Reply-To: <20211202150517.53029-1-luca.fancellu@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: a3c68b9d-5032-4427-0486-08d9b5a7e66a
x-ms-traffictypediagnostic: AM6PR08MB3990:|AS8PR08MB7354:
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB7354AEE0867BE2E17364BD149D699@AS8PR08MB7354.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Pe8FB2qeq2Es/5B+UtsopdVJ+iDcsamz73GVP8bfhqGSnYaeAwlC6RZKdf21DPExTOKAClJ9DrBsEuXspMw9m0am8KHEHYs43Rq+5A5nNAmsMEj7/M+VSfiyNjhhkLIOOHnHvwOrQKhibg+96QnjmbGg4EANmBXriwYVL6g0wjPPhvEX8Lkz8ETnrO72mOkLySAq7+nMOf3vqj3nIjQ4RtKkDYqmlPYkfzHhJUmUWcympGZefqxjazZXp/BSGBjpjm3qgdAJuSrd2WTv3iNrVpe4YhOciLIkWdfOA4uOtNoF4+OZ27jVwTiDi9cG5rdfGTQuaaycvgkre2PG4Mt9o+HHkuuoLfi5Z+VdFRcIGOZsNGfABxAcwarN9PsaG4ubdxYe1lOfAhrqgNyRyJdKxYTw6w8nqtfvhm/kS59NpEXnidrdCEL8Cc33gJu91mKfqChKpYWZE3hui1kolwzz4NG2lV+TS/tsd3juzyki8j0G/VfgAW7mIXFW2jqk9rMTidX/mA6fJJc7ZcCCA1ht5mqqcm14pl7S5XAH1C8zJPzWyb2DRmzem8fPvJGrauznwEFCVhAVVYm8IxQ2N27XJxDerwbpTCl46LX+t7QS+Z0Qt++Xv6x9uPINJqAOxdiaiIfuh/F/pSfz2/xtZJhywwnwKtTUCMiCRvaIYaV8mGxOnb9dooI5f4hEjSr7gj2tZAYTLZO55SmvsqWAVI7cLM69vZA0Xzksr7LDsJPG1SgHU3J+uK5ymcgtDqeGPw08
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(76116006)(83380400001)(66556008)(2906002)(33656002)(6486002)(5660300002)(66476007)(316002)(66446008)(54906003)(37006003)(8936002)(186003)(6512007)(64756008)(66946007)(71200400001)(91956017)(6862004)(4326008)(122000001)(36756003)(2616005)(38070700005)(6506007)(26005)(86362001)(38100700002)(508600001)(6636002)(53546011)(8676002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CD29B5479BF72C4FA988D381B1110880@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3990
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d06b15bc-1945-4704-eb21-08d9b5a7dc0e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XKtXysxgiZpDseVBRHMAnEEKZyKFOpmDXeweUxcPB9x2e7uZcoDrWY+3AfKQjwHfbA9lFAFWubAmyusaGaOkeixY+ISBfv62a17iLpCTRa+m+4nHaw5zfyjTGTt7NTC8m/sU9rQ3lqB6gIXumZntOiXkOGTy4i4xlCc2RbpPyTJmQH+XWMAWG3yENEYvKLK548RXBpkfJ3tlgdauTg/ZK1gMvkX/x46+tjzusUsvRUgYLiRHu5sSpl94WzcHA9Sqo/388rKTRV6nXrrSR0/o3jrgzfbdTFBmTIWXIeTbiSJq6hk8eh15mbiYVP+ySGzPAPpOA44PW5Qj0YJi9avVWU5y1BqJBR197jqutrB4EzvlNJhHxcZ2kCZd8ijniUihu/noum6q10Sh9V6gQxvZPYrNT/3WDCjXvUfJf3vsiVnBGjBkdaUFBX7m3PJeAQxjhZQsvdf1W1CoYD/iwrWweaIAjphMDu1enulyzyzU5I9vZQeBlo4Y4itTyraflG0ToPx3j3gnCza5iKnewWVj0r9GT5ToHmZLept9RtP8Tc8segpcuDpMhy+dwgmz3Zmq+KjhNLgYkUUpN/P05xz7naN+EryvtKj0BBUpryiBgkTjMIR2X6DGIijodaF9Ko2qdTZSdhYOSKWQV7LnxJjFnkcLp9Q7WqIk8kFn2feiZ2ZIAG5fcCE3ZQ/7KcE+8acN5USVL4hWDW21p+EIq2ZWHA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(186003)(82310400004)(6512007)(508600001)(6636002)(47076005)(70206006)(6862004)(356005)(36756003)(83380400001)(54906003)(2616005)(37006003)(81166007)(316002)(4326008)(336012)(86362001)(8676002)(2906002)(36860700001)(26005)(6506007)(53546011)(8936002)(6486002)(33656002)(5660300002)(70586007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 15:24:57.9509
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a3c68b9d-5032-4427-0486-08d9b5a7e66a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7354

Hi Luca,

> On 2 Dec 2021, at 15:05, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>=20
> The example in section "UEFI boot and dom0less on ARM" has
> a wrong compatible for the DTB passthrough, it is "ramdisk"
> instead of "device-tree".
> This patch fixes the example.
>=20
> Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI bo=
ot")
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> ---
> Question: Does it makes sense to backport it to 4.16?

I would vote for that yes.

Regards
Bertrand

> ---
> docs/misc/efi.pandoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index 4abbb5bb82..abafb34527 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -222,7 +222,7 @@ domU1 {
> 		xen,uefi-binary =3D "initrd-3.0.31-0.4-xen";
> 	};
> 	module@3 {
> -		compatible =3D "multiboot,ramdisk", "multiboot,module";
> +		compatible =3D "multiboot,device-tree", "multiboot,module";
> 		xen,uefi-binary =3D "passthrough.dtb";
> 	};
> };
> --=20
> 2.17.1
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:29:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236778.410649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso13-0002tY-SH; Thu, 02 Dec 2021 15:28:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236778.410649; Thu, 02 Dec 2021 15:28:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso13-0002tR-OU; Thu, 02 Dec 2021 15:28:57 +0000
Received: by outflank-mailman (input) for mailman id 236778;
 Thu, 02 Dec 2021 15:28:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mso12-0002tL-Qo
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:28:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8f953b53-5384-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:28:55 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-p98n0vVfP0S3jMuLLFm__g-2; Thu, 02 Dec 2021 16:28:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 15:28:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 15:28:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0087.eurprd04.prod.outlook.com (2603:10a6:20b:313::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Thu, 2 Dec 2021 15:28:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f953b53-5384-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638458935;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Q88K8pn8Nw8IHl5j2+PVH1iFSZi2GkXijGSgEyeOOPE=;
	b=GsBARSWMvnAlrtbkkk7qcTw+JVVRqUXu9ZwuAcYhx0pjKBXOewkIgColN2SxEV65b3sCaD
	Fg38iq/fmndX8E01Ml8cBncGtW2+lG/LgeVLpxRP0YbpetMDFRkyxg21ziFsWKKcXPDaGu
	PvBay5gAYgf/UZemiHp608eniSq5zRs=
X-MC-Unique: p98n0vVfP0S3jMuLLFm__g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Afhz33SX5zvT4d6Uwi35vkZ2tc8PcdSzwYBgeMgkKFfnEk5NtTZCdRaoUKmYnFo4IVz6w240MTL4pdcU0K9/X5IQrLZYjpOI6BzXW/GEzC7oxwF0q+7SREBJG/c4VtPA/OkoNwSve44/LQX4UwH5YRy1auktl4akd4URSbeuPrspFnrjxAYugMq6aNVC1ksvB3CEcmOSkfK3oAN8uSJJYUJOTaeD8hb+rWENb89zHkiznEG4cY0SFRgSdGFfocpPqA2xu4QoC/pgB5oTsUSxRqECkFteisEZyMWWys8a+9uSo4IgRxwA3IW5JMqn9t2MqLeaF97myN4eKBKvHlN8xg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tb0t2KfkfAMzetSGxn1iGQUoLKqADfeLjajK4h8gn64=;
 b=c7ifWTaTC3PFqtc3Cm7JOowAIa9o2daIP5h+e1TKMaubJGFyFBX7stlnwU4gotiAdOFoimcnWJTgE9fZAmXEvcpX3C6GgbZWLwzrmnpJH24tsmQMP5ig4OfYR01cttk955txsgSCSQDDPyCohZl7optrNOj+BKq/hgdUqX2dmR4z+yj/Mm+hxxfs3hQKpJUNO7JjNFaZ5f/wc015lTM5I+pRM6Ig4jaTTR9+zqkjZqeLXT1gGefa5XMRyitOqD101oDgj7a5ficVKmCukWIcDvWd/iSCwAXZ6BIwyLCrveIVEbzwCb1/RGpRnwFQUbBJ1fmCL6XcKk1B1nKe8EIxHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <49991d39-f976-af50-b203-152564fa458e@suse.com>
Date: Thu, 2 Dec 2021 16:28:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
 <YadPLZqfN2pu5SeG@Air-de-Roger>
 <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
 <YajiQeaPx7KcL0Tw@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YajiQeaPx7KcL0Tw@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0087.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b141b17-090a-4272-2c8b-08d9b5a8719c
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63016120AD5B36FF74D6E055B3699@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8xBXqIRbW9xdikWUBmfH/7OFQEIYZB+q452Qz96y5i1ZhVuILqaNmUFPeClrwALubvVZiut8t6qlrpPxO56Eyk6EKyI9v7fBedBRUsNGMMT/5cEdA4NVWdgsRFY6PgTweVtWjXxI9jDc8EJMPjNHc0EDDPmFQcgAYNQsPtFMwq3a4O6bBi2SXW7EiUvSmvthFCRSq+xd+U6zya3IEXas8zFKfFTRIJVkicoioxi6w2EF08JrtdPjHoVgYWIMtorSlAa3K7FmRSuFIM9dKaVCFlPx/0sWoZVOHojqTFkSMJHKXcS5VPCIXfAFS0XtO2sdM0iIuLcxEVS19IniPXrHE6Rfm+8HPdtVQbEnLH6WloI+PjzJi8NKGlBzMm33o4EZ2XQDctDJy0KYY8hzZfDKLcqzj5cdNLzNqhjf78WmsqLVta/R2qzM0ylTc2pNOOON030CnE3U9zc2U+yespEmHzmjDCmXcytXF1R0kCvfs8RUMWpDuWhimDujH7gV7ePVvUDPeVyNxm76z/bEaw8hELt5cGqEhQNBr/YEUinAcjg+oW19zDUgvwsXLsimBUXQGEb8156hoeEeqpY+winIuDMFTkG5LTFmim3fUZYWNO6ZnmRCDkHpY7QSutrahzkSEwcS8c9CGEAwXxBEXYkeE7FeJc9LJcH2bwoi7DUYTSv0liQF8lsvhhSna4azWMjX60ZAYGu/ow6mS4tooHUlkw/EILMqflzAcILSuf+/vEs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(110136005)(316002)(38100700002)(16576012)(956004)(66476007)(8936002)(31696002)(26005)(83380400001)(66946007)(31686004)(508600001)(8676002)(86362001)(186003)(6486002)(54906003)(36756003)(53546011)(4326008)(66556008)(5660300002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UKkHk0kAEKImCDCBFPG14pL7bUgxuQqQA2atlgpcRmYryBzDcSOWIg4i443K?=
 =?us-ascii?Q?x/VorbHKHB1QMRPaEqpk06sb/JQmqxS5kqsoLGTz4CpG1hpp2iPoLs72TPul?=
 =?us-ascii?Q?NQkfuN2an88hnYKHovXgN0+TDCtCvSNl31aHe+vQaQxobWqXwAxtsC8LhZHs?=
 =?us-ascii?Q?lHWTPjo4UR1cLWBm095ACQWbtUMpXa7KVXq90tE8V67v0auZ8d8GgQpk6Cu3?=
 =?us-ascii?Q?/OSIEDc6PyiYS805OtgnAUrFgJ8KO75PyYTq4veGkIy/dDBnKH377/ldbfly?=
 =?us-ascii?Q?lfTYkI8/h+8R3HjUTbvi38EBVYmmHFW9errDXvJfZNHG8zuMsKdk6wPOphrR?=
 =?us-ascii?Q?otpx/sGIWaVbJB/6RXlrFBi3ofCcHhgrmDY2Doh3aXNkHLmDhNM0MoZlxb7C?=
 =?us-ascii?Q?AnW+UL2LzQjJoh8eLYMbnPcvzxEiqSqos/USm2MM7G+AKJdzgOxurbF4aSpb?=
 =?us-ascii?Q?ZxlPDXL0Hw0/B32qUFwssLESoWAsCnaJ5oQIy6DMpnmTbZW4cTaX+OWNLKjh?=
 =?us-ascii?Q?gB4aBa871T8B2IBWEaMaxKLNBY+ieGBg8wpDqNIAYpys57zQNlcqc2ZcLcAS?=
 =?us-ascii?Q?hV6xDAa7aCQeQ7yCfzPZCI0/UsiyVqh85zEfZWQ1Mo1CQJRvH/h/P5XwC5ST?=
 =?us-ascii?Q?1nkD7yNobigoqZX5FoG7mAZNxeaQ6hRKyzkVQBNxIyECGfNshHQAqkllNlSP?=
 =?us-ascii?Q?Irete9ozpl7TJWW1sTlWZGxDW1lWlXcuY4ONUNQI/luP3ONuB4t2VbRNMxrS?=
 =?us-ascii?Q?knhwWWSsFrdDucCsYep5fTa0VL2pQQtO3Phpy/M1RT+RgfJ9Q01HLBWYERal?=
 =?us-ascii?Q?PPeSHM+LLIHpqGGIkfcFD35jUF6kyF6wskKpocY6fYM+fQ4qA7FSJ+ut7DVK?=
 =?us-ascii?Q?Y4vY+lfVRxXjv7pOmR/fdoMlp/S6WOa3e95aHhnN0SBV7FdK6NGp0k6las6K?=
 =?us-ascii?Q?v6o2EDoAWSQDbPAg0tuHHD1xhYTS76IuRnpdeILjjACBwmEjPGlQUrHV64UM?=
 =?us-ascii?Q?ofT67h+IE0f4nWwj2iNZiRxh2A3sd0Cj2mC0u8mfPkrra6bGGkyg7wQxPmzN?=
 =?us-ascii?Q?GxDyFHidoyWYphXa4Fx0Pl+D46hA3uhJT0C2682Wa/w5f0HKntEdwfwpWl6Y?=
 =?us-ascii?Q?wb/PoxWP8fZArBjfHWWUb9cQ2wQDjIyr2hY3mEbt5CjgzS7Io4vrMhaiIExL?=
 =?us-ascii?Q?yMpbHnD3rtPVcvnSPgzKVt5M881kl3taSNL2jAMFfNWvyAyvaciqK+7WAvhR?=
 =?us-ascii?Q?Zd7KdjxTiIHWU5/Yq6mpSVHr0M3Y8pyv7aLOJDcT32UQxth77Ug9vEr49tiR?=
 =?us-ascii?Q?bfSgTSBistJi0l6F90QvS36pmBLXlry9oIquYg3W36AEbinqfcr5GrwqHHLP?=
 =?us-ascii?Q?BgOoHrtxNG/hYbTmSQojjFbIi7+ttOYA8Y8btqggy+DGx38JvGulPgVC1/BA?=
 =?us-ascii?Q?UROkP/LRJCSAR6UcqkEwpW8zDK/6ct6KBCXR6AnDNgxBNYqoMsnpEnp3B3HM?=
 =?us-ascii?Q?L9W/g9jR+KNKy+SjrBM6+bQmSkqPv5L1SkoCJ7VgKnpRrOiywIVjQMWtlOcD?=
 =?us-ascii?Q?an4iya+clZpQlGA1bKoMn4ITrUONK89/Us95cElUAYuubyCRfprgBSsjJFyz?=
 =?us-ascii?Q?Ly6QOUBIMuS6BOwvtBPyxvM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b141b17-090a-4272-2c8b-08d9b5a8719c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 15:28:51.7188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a4ToyLg7Sml4jnC5XN/fTpQNkRaEgQNfwY5GaRAtbehBW9nSjVLFgBpm7NEj/PbPgUbFjWImVpcAwGgcgpUOcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 02.12.2021 16:12, Roger Pau Monn=C3=A9 wrote:
> On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote:
>> On 01.12.2021 11:32, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
>>>> On 01.12.2021 10:09, Roger Pau Monn=C3=A9 wrote:
>>>>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
>>>>>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>>>>>>       * that fall in unusable ranges for PV Dom0.
>>>>>>       */
>>>>>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
>>>>>> -        return false;
>>>>>> +        return 0;
>>>>>> =20
>>>>>>      switch ( type =3D page_get_ram_type(mfn) )
>>>>>>      {
>>>>>>      case RAM_TYPE_UNUSABLE:
>>>>>> -        return false;
>>>>>> +        return 0;
>>>>>> =20
>>>>>>      case RAM_TYPE_CONVENTIONAL:
>>>>>>          if ( iommu_hwdom_strict )
>>>>>> -            return false;
>>>>>> +            return 0;
>>>>>>          break;
>>>>>> =20
>>>>>>      default:
>>>>>>          if ( type & RAM_TYPE_RESERVED )
>>>>>>          {
>>>>>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
>>>>>> -                return false;
>>>>>> +                perms =3D 0;
>>>>>>          }
>>>>>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn=
 > max_pfn )
>>>>>> -            return false;
>>>>>> +        else if ( is_hvm_domain(d) )
>>>>>> +            return 0;
>>>>>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
>>>>>> +            perms =3D 0;
>>>>>
>>>>> I'm confused about the reason to set perms =3D 0 instead of just
>>>>> returning here. AFAICT perms won't be set to any other value below,
>>>>> so you might as well just return 0.
>>>>
>>>> This is so that ...
>>>>
>>>>>>      }
>>>>>> =20
>>>>>>      /* Check that it doesn't overlap with the Interrupt Address Ran=
ge. */
>>>>>>      if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff )
>>>>>> -        return false;
>>>>>> +        return 0;
>>>>>>      /* ... or the IO-APIC */
>>>>>> -    for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i=
++ )
>>>>>> -        if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_address=
) )
>>>>>> -            return false;
>>>>>> +    if ( has_vioapic(d) )
>>>>>> +    {
>>>>>> +        for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ )
>>>>>> +            if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_add=
ress) )
>>>>>> +                return 0;
>>>>>> +    }
>>>>>> +    else if ( is_pv_domain(d) )
>>>>>> +    {
>>>>>> +        /*
>>>>>> +         * Be consistent with CPU mappings: Dom0 is permitted to es=
tablish r/o
>>>>>> +         * ones there, so it should also have such established for =
IOMMUs.
>>>>>> +         */
>>>>>> +        for ( i =3D 0; i < nr_ioapics; i++ )
>>>>>> +            if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
>>>>>> +                return rangeset_contains_singleton(mmio_ro_ranges, =
pfn)
>>>>>> +                       ? IOMMUF_readable : 0;
>>>>>> +    }
>>>>
>>>> ... this return, as per the comment, takes precedence over returning
>>>> zero.
>>>
>>> I see. This is because you want to map those in the IOMMU page tables
>>> even if the IO-APIC ranges are outside of a reserved region.
>>>
>>> I have to admit this is kind of weird, because the purpose of this
>>> function is to add mappings for all memory below 4G, and/or for all
>>> reserved regions.
>>
>> Well, that was what it started out as. The purpose here is to be consist=
ent
>> about IO-APICs: Either have them all mapped, or none of them. Since we m=
ap
>> them in the CPU page tables and since Andrew asked for the two mappings =
to
>> be consistent, this is the only way to satisfy the requests. Personally =
I'd
>> be okay with not mapping IO-APICs here (but then regardless of whether t=
hey
>> are covered by a reserved region).
>=20
> I'm unsure of the best way to deal with this, it seems like both
> the CPU and the IOMMU page tables would never be equal for PV dom0,
> because we have no intention to map the MSI-X tables in RO mode in the
> IOMMU page tables.
>=20
> I'm not really opposed to having the IO-APIC mapped RO in the IOMMU
> page tables, but I also don't see much benefit of doing it unless we
> have a user-case for it. The IO-APIC handling in PV is already
> different from native, so I would be fine if we add a comment noting
> that while the IO-APIC is mappable to the CPU page tables as RO it's
> not present in the IOMMU page tables (and then adjust hwdom_iommu_map
> to prevent it's mapping).

Andrew, you did request both mappings to get in sync - thoughts?

> I think we should also prevent mapping of the LAPIC, the HPET and the
> HyperTransport range in case they fall into a reserved region?

Probably.

> TBH looks like we should be using iomem_access_permitted in
> arch_iommu_hwdom_init? (not just for the IO-APIC, but for other device
> ranges)

In general - perhaps. Not sure though whether to switch to doing so
right here.

>>>>>> @@ -346,15 +362,19 @@ void __hwdom_init arch_iommu_hwdom_init(
>>>>>>      for ( ; i < top; i++ )
>>>>>>      {
>>>>>>          unsigned long pfn =3D pdx_to_pfn(i);
>>>>>> +        unsigned int perms =3D hwdom_iommu_map(d, pfn, max_pfn);
>>>>>>          int rc;
>>>>>> =20
>>>>>> -        if ( !hwdom_iommu_map(d, pfn, max_pfn) )
>>>>>> +        if ( !perms )
>>>>>>              rc =3D 0;
>>>>>>          else if ( paging_mode_translate(d) )
>>>>>> -            rc =3D set_identity_p2m_entry(d, pfn, p2m_access_rw, 0)=
;
>>>>>> +            rc =3D set_identity_p2m_entry(d, pfn,
>>>>>> +                                        perms & IOMMUF_writable ? p=
2m_access_rw
>>>>>> +                                                                : p=
2m_access_r,
>>>>>> +                                        0);
>>>>>>          else
>>>>>>              rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_O=
RDER_4K,
>>>>>> -                           IOMMUF_readable | IOMMUF_writable, &flus=
h_flags);
>>>>>> +                           perms, &flush_flags);
>>>>>
>>>>> You could just call set_identity_p2m_entry uniformly here. It will
>>>>> DTRT for non-translated guests also, and then hwdom_iommu_map could
>>>>> perhaps return a p2m_access_t?
>>>>
>>>> That's an orthogonal change imo, i.e. could be done as a prereq change=
,
>>>> but I'd prefer to leave it as is for now. Furthermore see "x86/mm: spl=
it
>>>> set_identity_p2m_entry() into PV and HVM parts": In v2 I'm now also
>>>> adjusting the code here=20
>>>
>>> I would rather adjust the code here to just call
>>> set_identity_p2m_entry instead of differentiating between PV and
>>> HVM.
>>
>> I'm a little hesitant, in particular considering your suggestion to
>> then have hwdom_iommu_map() return p2m_access_t. Andrew has made quite
>> clear that the use of p2m_access_* here and in a number of other places
>> is actually an abuse.
>>
>> Plus - forgot about this in my earlier reply - there would also be a
>> conflict with the next patch in this series, where larger orders will
>> get passed to iommu_map(), while set_identity_p2m_entry() has no
>> respective parameter yet (and imo it isn't urgent for it to gain one).
>=20
> I've seen now as the iommu_map path is modified to handle ranges
> instead of single pages. Long term we also want to expand this range
> handling to the HVM branch.

Long (or maybe better mid) term, yes.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:35:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:35:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236784.410660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso6x-0004Gr-J6; Thu, 02 Dec 2021 15:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236784.410660; Thu, 02 Dec 2021 15:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso6x-0004Gk-FR; Thu, 02 Dec 2021 15:35:03 +0000
Received: by outflank-mailman (input) for mailman id 236784;
 Thu, 02 Dec 2021 15:35:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1mso6v-0004Ge-Pi
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:35:01 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68e0e18e-5385-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:35:00 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-302-kk7Y1t1INsiyPM8LKA2YiQ-1; Thu, 02 Dec 2021 10:34:55 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7FF271023F4E;
 Thu,  2 Dec 2021 15:34:53 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 2AFE419D9F;
 Thu,  2 Dec 2021 15:34:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68e0e18e-5385-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459299;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=2kPW/C5/FL+h8BxSzNJZWzt3equt7yVQ9UPJp6j/x58=;
	b=Wwak2csQW5q2elDf7AG25mDMH3hG/pB74aXnHKxS4Ud/FW3DCb3m11Wxf/IKwNWjoTnZ1f
	fhcVdMB2ZdxAxijfzVcD5OqSeUX/ALG3Jk/rkQVW5eZ9Y7GSKBd/ES+QxnLN7aBJq1XcRJ
	5m61EvyNd+2cqKLU0PTnMHhfeJhJr8A=
X-MC-Unique: kk7Y1t1INsiyPM8LKA2YiQ-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 0/6] aio-posix: split poll check from ready handler
Date: Thu,  2 Dec 2021 15:33:56 +0000
Message-Id: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

v2:=0D
- Cleaned up unused return values in nvme and virtio-blk [Stefano]=0D
- Documented try_poll_mode() ready_list argument [Stefano]=0D
- Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [S=
tefano]=0D
=0D
The first patch improves AioContext's adaptive polling execution time=0D
measurement. This can result in better performance because the algorithm ma=
kes=0D
better decisions about when to poll versus when to fall back to file descri=
ptor=0D
monitoring.=0D
=0D
The remaining patches unify the virtio-blk and virtio-scsi dataplane and=0D
non-dataplane virtqueue handlers. This became possible because the dataplan=
e=0D
handler function now has the same function signature as the non-dataplane=
=0D
handler function. Stefano Garzarella prompted me to make this refactoring.=
=0D
=0D
Stefan Hajnoczi (6):=0D
  aio-posix: split poll check from ready handler=0D
  virtio: get rid of VirtIOHandleAIOOutput=0D
  virtio-blk: drop unused virtio_blk_handle_vq() return value=0D
  virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane=0D
  virtio: use ->handle_output() instead of ->handle_aio_output()=0D
  virtio: unify dataplane and non-dataplane ->handle_output()=0D
=0D
 include/block/aio.h             |  4 +-=0D
 include/hw/virtio/virtio-blk.h  |  2 +-=0D
 include/hw/virtio/virtio.h      |  5 +-=0D
 util/aio-posix.h                |  1 +=0D
 block/curl.c                    | 11 ++--=0D
 block/io_uring.c                | 19 ++++---=0D
 block/iscsi.c                   |  4 +-=0D
 block/linux-aio.c               | 16 +++---=0D
 block/nfs.c                     |  6 +--=0D
 block/nvme.c                    | 51 ++++++++++++-------=0D
 block/ssh.c                     |  4 +-=0D
 block/win32-aio.c               |  4 +-=0D
 hw/block/dataplane/virtio-blk.c | 16 +-----=0D
 hw/block/virtio-blk.c           | 14 ++----=0D
 hw/scsi/virtio-scsi-dataplane.c | 60 +++-------------------=0D
 hw/scsi/virtio-scsi.c           |  2 +-=0D
 hw/virtio/virtio.c              | 73 +++++++++------------------=0D
 hw/xen/xen-bus.c                |  6 +--=0D
 io/channel-command.c            |  6 ++-=0D
 io/channel-file.c               |  3 +-=0D
 io/channel-socket.c             |  3 +-=0D
 migration/rdma.c                |  8 +--=0D
 tests/unit/test-aio.c           |  4 +-=0D
 util/aio-posix.c                | 89 +++++++++++++++++++++++++--------=0D
 util/aio-win32.c                |  4 +-=0D
 util/async.c                    | 10 +++-=0D
 util/main-loop.c                |  4 +-=0D
 util/qemu-coroutine-io.c        |  5 +-=0D
 util/vhost-user-server.c        | 11 ++--=0D
 29 files changed, 217 insertions(+), 228 deletions(-)=0D
=0D
--=20=0D
2.33.1=0D
=0D



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:35:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:35:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236788.410671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso7j-0004oz-Sl; Thu, 02 Dec 2021 15:35:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236788.410671; Thu, 02 Dec 2021 15:35:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso7j-0004os-Ox; Thu, 02 Dec 2021 15:35:51 +0000
Received: by outflank-mailman (input) for mailman id 236788;
 Thu, 02 Dec 2021 15:35:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1mso7h-0004Ge-65
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:35:49 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8482e87a-5385-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:35:47 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-542-IXimCBTPPAKqC5P9n3he2A-1; Thu, 02 Dec 2021 10:35:40 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 25F9A1023F4D;
 Thu,  2 Dec 2021 15:35:38 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A767E8462A;
 Thu,  2 Dec 2021 15:34:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8482e87a-5385-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459345;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A3qPGwJ6O4iLysnlNhOCRflQ0LsRsMaEYnpmqs432pU=;
	b=c67aryG/ZTOXggch31YSIVcJUyWfT/1Nrf2M0kBu9xpiMTdgk+WK7EkKg3GZOCY94QEsH4
	wzlQ+RFwm22ng1jyeufxwhsKP4X2SdjGcQDPjRM5F2w/7pbRiss+6vDmBcMB3LNp33laN9
	LzxlYYdHgAJJm26Zl0kd/K1h73fDKdA=
X-MC-Unique: IXimCBTPPAKqC5P9n3he2A-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 1/6] aio-posix: split poll check from ready handler
Date: Thu,  2 Dec 2021 15:33:57 +0000
Message-Id: <20211202153402.604951-2-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when in fact the event handler was running for a long time.

For example, on Linux the io_submit(2) syscall invoked when a virtio-blk
device's virtqueue becomes ready can take 10s of microseconds. This
can exceed the default polling interval (32 microseconds) and cause
adaptive polling to stop polling.

By excluding the handler's execution time from the polling check we make
the adaptive polling calculation more accurate. As a result, the event
loop now stays in polling mode where previously it would have fallen
back to file descriptor monitoring.

The following data was collected with virtio-blk num-queues=2
event_idx=off using an IOThread. Before:

168k IOPS, IOThread syscalls:

  9837.115 ( 0.020 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 16, iocbpp: 0x7fcb9f937db0)    = 16
  9837.158 ( 0.002 ms): IO iothread1/620155 write(fd: 103, buf: 0x556a2ef71b88, count: 8)                         = 8
  9837.161 ( 0.001 ms): IO iothread1/620155 write(fd: 104, buf: 0x556a2ef71b88, count: 8)                         = 8
  9837.163 ( 0.001 ms): IO iothread1/620155 ppoll(ufds: 0x7fcb90002800, nfds: 4, tsp: 0x7fcb9f1342d0, sigsetsize: 8) = 3
  9837.164 ( 0.001 ms): IO iothread1/620155 read(fd: 107, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.174 ( 0.001 ms): IO iothread1/620155 read(fd: 105, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.176 ( 0.001 ms): IO iothread1/620155 read(fd: 106, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.209 ( 0.035 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 32, iocbpp: 0x7fca7d0cebe0)    = 32

174k IOPS (+3.6%), IOThread syscalls:

  9809.566 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0cdd62be0)    = 32
  9809.625 ( 0.001 ms): IO iothread1/623061 write(fd: 103, buf: 0x5647cfba5f58, count: 8)                         = 8
  9809.627 ( 0.002 ms): IO iothread1/623061 write(fd: 104, buf: 0x5647cfba5f58, count: 8)                         = 8
  9809.663 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0d0388b50)    = 32

Notice that ppoll(2) and eventfd read(2) syscalls are eliminated because
the IOThread stays in polling mode instead of falling back to file
descriptor monitoring.

As usual, polling is not implemented on Windows so this patch ignores
the new io_poll_read() callback in aio-win32.c.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/block/aio.h      |  4 +-
 util/aio-posix.h         |  1 +
 block/curl.c             | 11 ++---
 block/io_uring.c         | 19 +++++----
 block/iscsi.c            |  4 +-
 block/linux-aio.c        | 16 +++++---
 block/nfs.c              |  6 +--
 block/nvme.c             | 51 +++++++++++++++--------
 block/ssh.c              |  4 +-
 block/win32-aio.c        |  4 +-
 hw/virtio/virtio.c       | 16 +++++---
 hw/xen/xen-bus.c         |  6 +--
 io/channel-command.c     |  6 ++-
 io/channel-file.c        |  3 +-
 io/channel-socket.c      |  3 +-
 migration/rdma.c         |  8 ++--
 tests/unit/test-aio.c    |  4 +-
 util/aio-posix.c         | 89 ++++++++++++++++++++++++++++++----------
 util/aio-win32.c         |  4 +-
 util/async.c             | 10 ++++-
 util/main-loop.c         |  4 +-
 util/qemu-coroutine-io.c |  5 ++-
 util/vhost-user-server.c | 11 ++---
 23 files changed, 189 insertions(+), 100 deletions(-)

diff --git a/include/block/aio.h b/include/block/aio.h
index 47fbe9d81f..5634173b12 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -469,6 +469,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque);
 
 /* Set polling begin/end callbacks for a file descriptor that has already been
@@ -490,7 +491,8 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *notifier,
                             bool is_external,
                             EventNotifierHandler *io_read,
-                            AioPollFn *io_poll);
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready);
 
 /* Set polling begin/end callbacks for an event notifier that has already been
  * registered with aio_set_event_notifier.  Do nothing if the event notifier is
diff --git a/util/aio-posix.h b/util/aio-posix.h
index c80c04506a..7f2c37a684 100644
--- a/util/aio-posix.h
+++ b/util/aio-posix.h
@@ -24,6 +24,7 @@ struct AioHandler {
     IOHandler *io_read;
     IOHandler *io_write;
     AioPollFn *io_poll;
+    IOHandler *io_poll_ready;
     IOHandler *io_poll_begin;
     IOHandler *io_poll_end;
     void *opaque;
diff --git a/block/curl.c b/block/curl.c
index 4a8ae2b269..6a6cd72975 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -125,7 +125,7 @@ static gboolean curl_drop_socket(void *key, void *value, void *opaque)
     BDRVCURLState *s = socket->s;
 
     aio_set_fd_handler(s->aio_context, socket->fd, false,
-                       NULL, NULL, NULL, NULL);
+                       NULL, NULL, NULL, NULL, NULL);
     return true;
 }
 
@@ -173,19 +173,20 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
     switch (action) {
         case CURL_POLL_IN:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               curl_multi_do, NULL, NULL, socket);
+                               curl_multi_do, NULL, NULL, NULL, socket);
             break;
         case CURL_POLL_OUT:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               NULL, curl_multi_do, NULL, socket);
+                               NULL, curl_multi_do, NULL, NULL, socket);
             break;
         case CURL_POLL_INOUT:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               curl_multi_do, curl_multi_do, NULL, socket);
+                               curl_multi_do, curl_multi_do,
+                               NULL, NULL, socket);
             break;
         case CURL_POLL_REMOVE:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               NULL, NULL, NULL, NULL);
+                               NULL, NULL, NULL, NULL, NULL);
             break;
     }
 
diff --git a/block/io_uring.c b/block/io_uring.c
index dfa475cc87..782afdb433 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -292,12 +292,14 @@ static bool qemu_luring_poll_cb(void *opaque)
 {
     LuringState *s = opaque;
 
-    if (io_uring_cq_ready(&s->ring)) {
-        luring_process_completions_and_submit(s);
-        return true;
-    }
+    return io_uring_cq_ready(&s->ring);
+}
 
-    return false;
+static void qemu_luring_poll_ready(void *opaque)
+{
+    LuringState *s = opaque;
+
+    luring_process_completions_and_submit(s);
 }
 
 static void ioq_init(LuringQueue *io_q)
@@ -402,8 +404,8 @@ int coroutine_fn luring_co_submit(BlockDriverState *bs, LuringState *s, int fd,
 
 void luring_detach_aio_context(LuringState *s, AioContext *old_context)
 {
-    aio_set_fd_handler(old_context, s->ring.ring_fd, false, NULL, NULL, NULL,
-                       s);
+    aio_set_fd_handler(old_context, s->ring.ring_fd, false,
+                       NULL, NULL, NULL, NULL, s);
     qemu_bh_delete(s->completion_bh);
     s->aio_context = NULL;
 }
@@ -413,7 +415,8 @@ void luring_attach_aio_context(LuringState *s, AioContext *new_context)
     s->aio_context = new_context;
     s->completion_bh = aio_bh_new(new_context, qemu_luring_completion_bh, s);
     aio_set_fd_handler(s->aio_context, s->ring.ring_fd, false,
-                       qemu_luring_completion_cb, NULL, qemu_luring_poll_cb, s);
+                       qemu_luring_completion_cb, NULL,
+                       qemu_luring_poll_cb, qemu_luring_poll_ready, s);
 }
 
 LuringState *luring_init(Error **errp)
diff --git a/block/iscsi.c b/block/iscsi.c
index 57aa07a40d..51f2a5eeaa 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -363,7 +363,7 @@ iscsi_set_events(IscsiLun *iscsilun)
                            false,
                            (ev & POLLIN) ? iscsi_process_read : NULL,
                            (ev & POLLOUT) ? iscsi_process_write : NULL,
-                           NULL,
+                           NULL, NULL,
                            iscsilun);
         iscsilun->events = ev;
     }
@@ -1534,7 +1534,7 @@ static void iscsi_detach_aio_context(BlockDriverState *bs)
     IscsiLun *iscsilun = bs->opaque;
 
     aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsilun->iscsi),
-                       false, NULL, NULL, NULL, NULL);
+                       false, NULL, NULL, NULL, NULL, NULL);
     iscsilun->events = 0;
 
     if (iscsilun->nop_timer) {
diff --git a/block/linux-aio.c b/block/linux-aio.c
index f53ae72e21..4c423fcccf 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -263,12 +263,15 @@ static bool qemu_laio_poll_cb(void *opaque)
     LinuxAioState *s = container_of(e, LinuxAioState, e);
     struct io_event *events;
 
-    if (!io_getevents_peek(s->ctx, &events)) {
-        return false;
-    }
+    return io_getevents_peek(s->ctx, &events);
+}
+
+static void qemu_laio_poll_ready(EventNotifier *opaque)
+{
+    EventNotifier *e = opaque;
+    LinuxAioState *s = container_of(e, LinuxAioState, e);
 
     qemu_laio_process_completions_and_submit(s);
-    return true;
 }
 
 static void ioq_init(LaioQueue *io_q)
@@ -427,7 +430,7 @@ int coroutine_fn laio_co_submit(BlockDriverState *bs, LinuxAioState *s, int fd,
 
 void laio_detach_aio_context(LinuxAioState *s, AioContext *old_context)
 {
-    aio_set_event_notifier(old_context, &s->e, false, NULL, NULL);
+    aio_set_event_notifier(old_context, &s->e, false, NULL, NULL, NULL);
     qemu_bh_delete(s->completion_bh);
     s->aio_context = NULL;
 }
@@ -438,7 +441,8 @@ void laio_attach_aio_context(LinuxAioState *s, AioContext *new_context)
     s->completion_bh = aio_bh_new(new_context, qemu_laio_completion_bh, s);
     aio_set_event_notifier(new_context, &s->e, false,
                            qemu_laio_completion_cb,
-                           qemu_laio_poll_cb);
+                           qemu_laio_poll_cb,
+                           qemu_laio_poll_ready);
 }
 
 LinuxAioState *laio_init(Error **errp)
diff --git a/block/nfs.c b/block/nfs.c
index 577aea1d22..444c40b458 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -197,7 +197,7 @@ static void nfs_set_events(NFSClient *client)
                            false,
                            (ev & POLLIN) ? nfs_process_read : NULL,
                            (ev & POLLOUT) ? nfs_process_write : NULL,
-                           NULL, client);
+                           NULL, NULL, client);
 
     }
     client->events = ev;
@@ -372,7 +372,7 @@ static void nfs_detach_aio_context(BlockDriverState *bs)
     NFSClient *client = bs->opaque;
 
     aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context),
-                       false, NULL, NULL, NULL, NULL);
+                       false, NULL, NULL, NULL, NULL, NULL);
     client->events = 0;
 }
 
@@ -390,7 +390,7 @@ static void nfs_client_close(NFSClient *client)
     if (client->context) {
         qemu_mutex_lock(&client->mutex);
         aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context),
-                           false, NULL, NULL, NULL, NULL);
+                           false, NULL, NULL, NULL, NULL, NULL);
         qemu_mutex_unlock(&client->mutex);
         if (client->fh) {
             nfs_close(client->context, client->fh);
diff --git a/block/nvme.c b/block/nvme.c
index e4f336d79c..e3b82e345c 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -604,10 +604,8 @@ out:
     return ret;
 }
 
-static bool nvme_poll_queue(NVMeQueuePair *q)
+static void nvme_poll_queue(NVMeQueuePair *q)
 {
-    bool progress = false;
-
     const size_t cqe_offset = q->cq.head * NVME_CQ_ENTRY_BYTES;
     NvmeCqe *cqe = (NvmeCqe *)&q->cq.queue[cqe_offset];
 
@@ -618,30 +616,23 @@ static bool nvme_poll_queue(NVMeQueuePair *q)
      * cannot race with itself.
      */
     if ((le16_to_cpu(cqe->status) & 0x1) == q->cq_phase) {
-        return false;
+        return;
     }
 
     qemu_mutex_lock(&q->lock);
     while (nvme_process_completion(q)) {
         /* Keep polling */
-        progress = true;
     }
     qemu_mutex_unlock(&q->lock);
-
-    return progress;
 }
 
-static bool nvme_poll_queues(BDRVNVMeState *s)
+static void nvme_poll_queues(BDRVNVMeState *s)
 {
-    bool progress = false;
     int i;
 
     for (i = 0; i < s->queue_count; i++) {
-        if (nvme_poll_queue(s->queues[i])) {
-            progress = true;
-        }
+        nvme_poll_queue(s->queues[i]);
     }
-    return progress;
 }
 
 static void nvme_handle_event(EventNotifier *n)
@@ -702,8 +693,30 @@ static bool nvme_poll_cb(void *opaque)
     EventNotifier *e = opaque;
     BDRVNVMeState *s = container_of(e, BDRVNVMeState,
                                     irq_notifier[MSIX_SHARED_IRQ_IDX]);
+    int i;
 
-    return nvme_poll_queues(s);
+    for (i = 0; i < s->queue_count; i++) {
+        NVMeQueuePair *q = s->queues[i];
+        const size_t cqe_offset = q->cq.head * NVME_CQ_ENTRY_BYTES;
+        NvmeCqe *cqe = (NvmeCqe *)&q->cq.queue[cqe_offset];
+
+        /*
+         * q->lock isn't needed because nvme_process_completion() only runs in
+         * the event loop thread and cannot race with itself.
+         */
+        if ((le16_to_cpu(cqe->status) & 0x1) != q->cq_phase) {
+            return true;
+        }
+    }
+    return false;
+}
+
+static void nvme_poll_ready(EventNotifier *e)
+{
+    BDRVNVMeState *s = container_of(e, BDRVNVMeState,
+                                    irq_notifier[MSIX_SHARED_IRQ_IDX]);
+
+    nvme_poll_queues(s);
 }
 
 static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
@@ -838,7 +851,8 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
     }
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, nvme_handle_event, nvme_poll_cb);
+                           false, nvme_handle_event, nvme_poll_cb,
+                           nvme_poll_ready);
 
     if (!nvme_identify(bs, namespace, errp)) {
         ret = -EIO;
@@ -923,7 +937,7 @@ static void nvme_close(BlockDriverState *bs)
     g_free(s->queues);
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, NULL, NULL);
+                           false, NULL, NULL, NULL);
     event_notifier_cleanup(&s->irq_notifier[MSIX_SHARED_IRQ_IDX]);
     qemu_vfio_pci_unmap_bar(s->vfio, 0, s->bar0_wo_map,
                             0, sizeof(NvmeBar) + NVME_DOORBELL_SIZE);
@@ -1519,7 +1533,7 @@ static void nvme_detach_aio_context(BlockDriverState *bs)
 
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, NULL, NULL);
+                           false, NULL, NULL, NULL);
 }
 
 static void nvme_attach_aio_context(BlockDriverState *bs,
@@ -1529,7 +1543,8 @@ static void nvme_attach_aio_context(BlockDriverState *bs,
 
     s->aio_context = new_context;
     aio_set_event_notifier(new_context, &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, nvme_handle_event, nvme_poll_cb);
+                           false, nvme_handle_event, nvme_poll_cb,
+                           nvme_poll_ready);
 
     for (unsigned i = 0; i < s->queue_count; i++) {
         NVMeQueuePair *q = s->queues[i];
diff --git a/block/ssh.c b/block/ssh.c
index e0fbb4934b..3b5bf34031 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -990,7 +990,7 @@ static void restart_coroutine(void *opaque)
     AioContext *ctx = bdrv_get_aio_context(bs);
 
     trace_ssh_restart_coroutine(restart->co);
-    aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL, NULL);
 
     aio_co_wake(restart->co);
 }
@@ -1020,7 +1020,7 @@ static coroutine_fn void co_yield(BDRVSSHState *s, BlockDriverState *bs)
     trace_ssh_co_yield(s->sock, rd_handler, wr_handler);
 
     aio_set_fd_handler(bdrv_get_aio_context(bs), s->sock,
-                       false, rd_handler, wr_handler, NULL, &restart);
+                       false, rd_handler, wr_handler, NULL, NULL, &restart);
     qemu_coroutine_yield();
     trace_ssh_co_yield_back(s->sock);
 }
diff --git a/block/win32-aio.c b/block/win32-aio.c
index b7221a272f..c57e10c997 100644
--- a/block/win32-aio.c
+++ b/block/win32-aio.c
@@ -172,7 +172,7 @@ int win32_aio_attach(QEMUWin32AIOState *aio, HANDLE hfile)
 void win32_aio_detach_aio_context(QEMUWin32AIOState *aio,
                                   AioContext *old_context)
 {
-    aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL);
+    aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL, NULL);
     aio->aio_ctx = NULL;
 }
 
@@ -181,7 +181,7 @@ void win32_aio_attach_aio_context(QEMUWin32AIOState *aio,
 {
     aio->aio_ctx = new_context;
     aio_set_event_notifier(new_context, &aio->e, false,
-                           win32_aio_completion_cb, NULL);
+                           win32_aio_completion_cb, NULL, NULL);
 }
 
 QEMUWin32AIOState *win32_aio_init(void)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index ea7c079fb0..0039e1c74c 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3533,11 +3533,14 @@ static bool virtio_queue_host_notifier_aio_poll(void *opaque)
     EventNotifier *n = opaque;
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
 
-    if (!vq->vring.desc || virtio_queue_empty(vq)) {
-        return false;
-    }
+    return vq->vring.desc && !virtio_queue_empty(vq);
+}
 
-    return virtio_queue_notify_aio_vq(vq);
+static void virtio_queue_host_notifier_aio_poll_ready(EventNotifier *n)
+{
+    VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
+
+    virtio_queue_notify_aio_vq(vq);
 }
 
 static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
@@ -3555,12 +3558,13 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         vq->handle_aio_output = handle_output;
         aio_set_event_notifier(ctx, &vq->host_notifier, true,
                                virtio_queue_host_notifier_aio_read,
-                               virtio_queue_host_notifier_aio_poll);
+                               virtio_queue_host_notifier_aio_poll,
+                               virtio_queue_host_notifier_aio_poll_ready);
         aio_set_event_notifier_poll(ctx, &vq->host_notifier,
                                     virtio_queue_host_notifier_aio_poll_begin,
                                     virtio_queue_host_notifier_aio_poll_end);
     } else {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL);
+        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
         /* Test and clear notifier before after disabling event,
          * in case poll callback didn't have time to run. */
         virtio_queue_host_notifier_aio_read(&vq->host_notifier);
diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 416583f130..645a29a5a0 100644
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -1115,11 +1115,11 @@ void xen_device_set_event_channel_context(XenDevice *xendev,
 
     if (channel->ctx)
         aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                           NULL, NULL, NULL, NULL);
+                           NULL, NULL, NULL, NULL, NULL);
 
     channel->ctx = ctx;
     aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                       xen_device_event, NULL, xen_device_poll, channel);
+                       xen_device_event, NULL, xen_device_poll, NULL, channel);
 }
 
 XenEventChannel *xen_device_bind_event_channel(XenDevice *xendev,
@@ -1193,7 +1193,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev,
     QLIST_REMOVE(channel, list);
 
     aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                       NULL, NULL, NULL, NULL);
+                       NULL, NULL, NULL, NULL, NULL);
 
     if (xenevtchn_unbind(channel->xeh, channel->local_port) < 0) {
         error_setg_errno(errp, errno, "xenevtchn_unbind failed");
diff --git a/io/channel-command.c b/io/channel-command.c
index b2a9e27138..338da73ade 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -346,8 +346,10 @@ static void qio_channel_command_set_aio_fd_handler(QIOChannel *ioc,
                                                    void *opaque)
 {
     QIOChannelCommand *cioc = QIO_CHANNEL_COMMAND(ioc);
-    aio_set_fd_handler(ctx, cioc->readfd, false, io_read, NULL, NULL, opaque);
-    aio_set_fd_handler(ctx, cioc->writefd, false, NULL, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, cioc->readfd, false,
+                       io_read, NULL, NULL, NULL, opaque);
+    aio_set_fd_handler(ctx, cioc->writefd, false,
+                       NULL, io_write, NULL, NULL, opaque);
 }
 
 
diff --git a/io/channel-file.c b/io/channel-file.c
index c4bf799a80..d7cf6d278f 100644
--- a/io/channel-file.c
+++ b/io/channel-file.c
@@ -191,7 +191,8 @@ static void qio_channel_file_set_aio_fd_handler(QIOChannel *ioc,
                                                 void *opaque)
 {
     QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc);
-    aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write,
+                       NULL, NULL, opaque);
 }
 
 static GSource *qio_channel_file_create_watch(QIOChannel *ioc,
diff --git a/io/channel-socket.c b/io/channel-socket.c
index 606ec97cf7..459922c874 100644
--- a/io/channel-socket.c
+++ b/io/channel-socket.c
@@ -761,7 +761,8 @@ static void qio_channel_socket_set_aio_fd_handler(QIOChannel *ioc,
                                                   void *opaque)
 {
     QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(ioc);
-    aio_set_fd_handler(ctx, sioc->fd, false, io_read, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, sioc->fd, false,
+                       io_read, io_write, NULL, NULL, opaque);
 }
 
 static GSource *qio_channel_socket_create_watch(QIOChannel *ioc,
diff --git a/migration/rdma.c b/migration/rdma.c
index f5d3bbe7e9..c7c7a38487 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3161,14 +3161,14 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc,
     QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc);
     if (io_read) {
         aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
         aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
     } else {
         aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
         aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
     }
 }
 
diff --git a/tests/unit/test-aio.c b/tests/unit/test-aio.c
index 6feeb9a4a9..178048d2f2 100644
--- a/tests/unit/test-aio.c
+++ b/tests/unit/test-aio.c
@@ -130,7 +130,7 @@ static void *test_acquire_thread(void *opaque)
 static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
                                EventNotifierHandler *handler)
 {
-    aio_set_event_notifier(ctx, notifier, false, handler, NULL);
+    aio_set_event_notifier(ctx, notifier, false, handler, NULL, NULL);
 }
 
 static void dummy_notifier_read(EventNotifier *n)
@@ -390,7 +390,7 @@ static void test_aio_external_client(void)
     for (i = 1; i < 3; i++) {
         EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true };
         event_notifier_init(&data.e, false);
-        aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL);
+        aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL, NULL);
         event_notifier_set(&data.e);
         for (j = 0; j < i; j++) {
             aio_disable_external(ctx);
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 2b86777e91..7b9f629218 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -23,6 +23,15 @@
 #include "trace.h"
 #include "aio-posix.h"
 
+/*
+ * G_IO_IN and G_IO_OUT are not appropriate revents values for polling, since
+ * the handler may not need to access the file descriptor. For example, the
+ * handler doesn't need to read from an EventNotifier if it polled a memory
+ * location and a read syscall would be slow. Define our own unique revents
+ * value to indicate that polling determined this AioHandler is ready.
+ */
+#define REVENTS_POLL_READY 0
+
 /* Stop userspace polling on a handler if it isn't active for some time */
 #define POLL_IDLE_INTERVAL_NS (7 * NANOSECONDS_PER_SECOND)
 
@@ -93,6 +102,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque)
 {
     AioHandler *node;
@@ -101,6 +111,10 @@ void aio_set_fd_handler(AioContext *ctx,
     bool deleted = false;
     int poll_disable_change;
 
+    if (io_poll && !io_poll_ready) {
+        io_poll = NULL; /* polling only makes sense if there is a handler */
+    }
+
     qemu_lockcnt_lock(&ctx->list_lock);
 
     node = find_aio_handler(ctx, fd);
@@ -127,6 +141,7 @@ void aio_set_fd_handler(AioContext *ctx,
         new_node->io_read = io_read;
         new_node->io_write = io_write;
         new_node->io_poll = io_poll;
+        new_node->io_poll_ready = io_poll_ready;
         new_node->opaque = opaque;
         new_node->is_external = is_external;
 
@@ -182,10 +197,12 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *notifier,
                             bool is_external,
                             EventNotifierHandler *io_read,
-                            AioPollFn *io_poll)
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready)
 {
     aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), is_external,
-                       (IOHandler *)io_read, NULL, io_poll, notifier);
+                       (IOHandler *)io_read, NULL, io_poll,
+                       (IOHandler *)io_poll_ready, notifier);
 }
 
 void aio_set_event_notifier_poll(AioContext *ctx,
@@ -198,7 +215,8 @@ void aio_set_event_notifier_poll(AioContext *ctx,
                     (IOHandler *)io_poll_end);
 }
 
-static bool poll_set_started(AioContext *ctx, bool started)
+static bool poll_set_started(AioContext *ctx, AioHandlerList *ready_list,
+                             bool started)
 {
     AioHandler *node;
     bool progress = false;
@@ -228,8 +246,9 @@ static bool poll_set_started(AioContext *ctx, bool started)
         }
 
         /* Poll one last time in case ->io_poll_end() raced with the event */
-        if (!started) {
-            progress = node->io_poll(node->opaque) || progress;
+        if (!started && node->io_poll(node->opaque)) {
+            aio_add_ready_handler(ready_list, node, REVENTS_POLL_READY);
+            progress = true;
         }
     }
     qemu_lockcnt_dec(&ctx->list_lock);
@@ -240,8 +259,11 @@ static bool poll_set_started(AioContext *ctx, bool started)
 
 bool aio_prepare(AioContext *ctx)
 {
+    AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list);
+
     /* Poll mode cannot be used with glib's event loop, disable it. */
-    poll_set_started(ctx, false);
+    poll_set_started(ctx, &ready_list, false);
+    /* TODO what to do with this list? */
 
     return false;
 }
@@ -321,6 +343,18 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node)
         }
         QLIST_INSERT_HEAD(&ctx->poll_aio_handlers, node, node_poll);
     }
+    if (!QLIST_IS_INSERTED(node, node_deleted) &&
+        revents == 0 &&
+        aio_node_check(ctx, node->is_external) &&
+        node->io_poll_ready) {
+        node->io_poll_ready(node->opaque);
+
+        /*
+         * Return early since revents was zero. aio_notify() does not count as
+         * progress.
+         */
+        return node->opaque != &ctx->notifier;
+    }
 
     if (!QLIST_IS_INSERTED(node, node_deleted) &&
         (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) &&
@@ -387,6 +421,7 @@ void aio_dispatch(AioContext *ctx)
 }
 
 static bool run_poll_handlers_once(AioContext *ctx,
+                                   AioHandlerList *ready_list,
                                    int64_t now,
                                    int64_t *timeout)
 {
@@ -397,6 +432,8 @@ static bool run_poll_handlers_once(AioContext *ctx,
     QLIST_FOREACH_SAFE(node, &ctx->poll_aio_handlers, node_poll, tmp) {
         if (aio_node_check(ctx, node->is_external) &&
             node->io_poll(node->opaque)) {
+            aio_add_ready_handler(ready_list, node, REVENTS_POLL_READY);
+
             node->poll_idle_timeout = now + POLL_IDLE_INTERVAL_NS;
 
             /*
@@ -420,7 +457,9 @@ static bool fdmon_supports_polling(AioContext *ctx)
     return ctx->fdmon_ops->need_wait != aio_poll_disabled;
 }
 
-static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
+static bool remove_idle_poll_handlers(AioContext *ctx,
+                                      AioHandlerList *ready_list,
+                                      int64_t now)
 {
     AioHandler *node;
     AioHandler *tmp;
@@ -451,7 +490,11 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
                  * Nevermind about re-adding the handler in the rare case where
                  * this causes progress.
                  */
-                progress = node->io_poll(node->opaque) || progress;
+                if (node->io_poll(node->opaque)) {
+                    aio_add_ready_handler(ready_list, node,
+                                          REVENTS_POLL_READY);
+                    progress = true;
+                }
             }
         }
     }
@@ -461,6 +504,7 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
 
 /* run_poll_handlers:
  * @ctx: the AioContext
+ * @ready_list: the list to place ready handlers on
  * @max_ns: maximum time to poll for, in nanoseconds
  *
  * Polls for a given time.
@@ -469,7 +513,8 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
  *
  * Returns: true if progress was made, false otherwise
  */
-static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
+static bool run_poll_handlers(AioContext *ctx, AioHandlerList *ready_list,
+                              int64_t max_ns, int64_t *timeout)
 {
     bool progress;
     int64_t start_time, elapsed_time;
@@ -490,13 +535,15 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
 
     start_time = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
     do {
-        progress = run_poll_handlers_once(ctx, start_time, timeout);
+        progress = run_poll_handlers_once(ctx, ready_list,
+                                          start_time, timeout);
         elapsed_time = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - start_time;
         max_ns = qemu_soonest_timeout(*timeout, max_ns);
         assert(!(max_ns && progress));
     } while (elapsed_time < max_ns && !ctx->fdmon_ops->need_wait(ctx));
 
-    if (remove_idle_poll_handlers(ctx, start_time + elapsed_time)) {
+    if (remove_idle_poll_handlers(ctx, ready_list,
+                                  start_time + elapsed_time)) {
         *timeout = 0;
         progress = true;
     }
@@ -514,6 +561,7 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
 
 /* try_poll_mode:
  * @ctx: the AioContext
+ * @ready_list: list to add handlers that need to be run
  * @timeout: timeout for blocking wait, computed by the caller and updated if
  *    polling succeeds.
  *
@@ -521,7 +569,8 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
  *
  * Returns: true if progress was made, false otherwise
  */
-static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
+static bool try_poll_mode(AioContext *ctx, AioHandlerList *ready_list,
+                          int64_t *timeout)
 {
     int64_t max_ns;
 
@@ -531,14 +580,14 @@ static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
 
     max_ns = qemu_soonest_timeout(*timeout, ctx->poll_ns);
     if (max_ns && !ctx->fdmon_ops->need_wait(ctx)) {
-        poll_set_started(ctx, true);
+        poll_set_started(ctx, ready_list, true);
 
-        if (run_poll_handlers(ctx, max_ns, timeout)) {
+        if (run_poll_handlers(ctx, ready_list, max_ns, timeout)) {
             return true;
         }
     }
 
-    if (poll_set_started(ctx, false)) {
+    if (poll_set_started(ctx, ready_list, false)) {
         *timeout = 0;
         return true;
     }
@@ -549,7 +598,6 @@ static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
 bool aio_poll(AioContext *ctx, bool blocking)
 {
     AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list);
-    int ret = 0;
     bool progress;
     bool use_notify_me;
     int64_t timeout;
@@ -574,7 +622,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
     }
 
     timeout = blocking ? aio_compute_timeout(ctx) : 0;
-    progress = try_poll_mode(ctx, &timeout);
+    progress = try_poll_mode(ctx, &ready_list, &timeout);
     assert(!(timeout && progress));
 
     /*
@@ -604,7 +652,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
      * system call---a single round of run_poll_handlers_once suffices.
      */
     if (timeout || ctx->fdmon_ops->need_wait(ctx)) {
-        ret = ctx->fdmon_ops->wait(ctx, &ready_list, timeout);
+        ctx->fdmon_ops->wait(ctx, &ready_list, timeout);
     }
 
     if (use_notify_me) {
@@ -657,10 +705,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
     }
 
     progress |= aio_bh_poll(ctx);
-
-    if (ret > 0) {
-        progress |= aio_dispatch_ready_handlers(ctx, &ready_list);
-    }
+    progress |= aio_dispatch_ready_handlers(ctx, &ready_list);
 
     aio_free_deleted_handlers(ctx);
 
diff --git a/util/aio-win32.c b/util/aio-win32.c
index d5b09a1193..7aac89df3a 100644
--- a/util/aio-win32.c
+++ b/util/aio-win32.c
@@ -68,6 +68,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque)
 {
     /* fd is a SOCKET in our case */
@@ -136,7 +137,8 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *e,
                             bool is_external,
                             EventNotifierHandler *io_notify,
-                            AioPollFn *io_poll)
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready)
 {
     AioHandler *node;
 
diff --git a/util/async.c b/util/async.c
index 6f6717a34b..08d25feef5 100644
--- a/util/async.c
+++ b/util/async.c
@@ -362,7 +362,7 @@ aio_ctx_finalize(GSource     *source)
         g_free(bh);
     }
 
-    aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL);
+    aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL, NULL);
     event_notifier_cleanup(&ctx->notifier);
     qemu_rec_mutex_destroy(&ctx->lock);
     qemu_lockcnt_destroy(&ctx->list_lock);
@@ -485,6 +485,11 @@ static bool aio_context_notifier_poll(void *opaque)
     return qatomic_read(&ctx->notified);
 }
 
+static void aio_context_notifier_poll_ready(EventNotifier *e)
+{
+    /* Do nothing, we just wanted to kick the event loop */
+}
+
 static void co_schedule_bh_cb(void *opaque)
 {
     AioContext *ctx = opaque;
@@ -536,7 +541,8 @@ AioContext *aio_context_new(Error **errp)
     aio_set_event_notifier(ctx, &ctx->notifier,
                            false,
                            aio_context_notifier_cb,
-                           aio_context_notifier_poll);
+                           aio_context_notifier_poll,
+                           aio_context_notifier_poll_ready);
 #ifdef CONFIG_LINUX_AIO
     ctx->linux_aio = NULL;
 #endif
diff --git a/util/main-loop.c b/util/main-loop.c
index 06b18b195c..4d5a5b9943 100644
--- a/util/main-loop.c
+++ b/util/main-loop.c
@@ -582,7 +582,7 @@ void qemu_set_fd_handler(int fd,
 {
     iohandler_init();
     aio_set_fd_handler(iohandler_ctx, fd, false,
-                       fd_read, fd_write, NULL, opaque);
+                       fd_read, fd_write, NULL, NULL, opaque);
 }
 
 void event_notifier_set_handler(EventNotifier *e,
@@ -590,5 +590,5 @@ void event_notifier_set_handler(EventNotifier *e,
 {
     iohandler_init();
     aio_set_event_notifier(iohandler_ctx, e, false,
-                           handler, NULL);
+                           handler, NULL, NULL);
 }
diff --git a/util/qemu-coroutine-io.c b/util/qemu-coroutine-io.c
index 5b80bb416f..7f5839cb76 100644
--- a/util/qemu-coroutine-io.c
+++ b/util/qemu-coroutine-io.c
@@ -75,7 +75,8 @@ typedef struct {
 static void fd_coroutine_enter(void *opaque)
 {
     FDYieldUntilData *data = opaque;
-    aio_set_fd_handler(data->ctx, data->fd, false, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(data->ctx, data->fd, false,
+                       NULL, NULL, NULL, NULL, NULL);
     qemu_coroutine_enter(data->co);
 }
 
@@ -88,6 +89,6 @@ void coroutine_fn yield_until_fd_readable(int fd)
     data.co = qemu_coroutine_self();
     data.fd = fd;
     aio_set_fd_handler(
-        data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, &data);
+        data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, NULL, &data);
     qemu_coroutine_yield();
 }
diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
index 783d847a6d..f68287e811 100644
--- a/util/vhost-user-server.c
+++ b/util/vhost-user-server.c
@@ -250,7 +250,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt,
         vu_fd_watch->cb = cb;
         qemu_set_nonblock(fd);
         aio_set_fd_handler(server->ioc->ctx, fd, true, kick_handler,
-                           NULL, NULL, vu_fd_watch);
+                           NULL, NULL, NULL, vu_fd_watch);
         vu_fd_watch->vu_dev = vu_dev;
         vu_fd_watch->pvt = pvt;
     }
@@ -270,7 +270,8 @@ static void remove_watch(VuDev *vu_dev, int fd)
     if (!vu_fd_watch) {
         return;
     }
-    aio_set_fd_handler(server->ioc->ctx, fd, true, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(server->ioc->ctx, fd, true,
+                       NULL, NULL, NULL, NULL, NULL);
 
     QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next);
     g_free(vu_fd_watch);
@@ -334,7 +335,7 @@ void vhost_user_server_stop(VuServer *server)
 
         QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
             aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true,
-                               NULL, NULL, NULL, vu_fd_watch);
+                               NULL, NULL, NULL, NULL, vu_fd_watch);
         }
 
         qio_channel_shutdown(server->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
@@ -377,7 +378,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx)
 
     QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
         aio_set_fd_handler(ctx, vu_fd_watch->fd, true, kick_handler, NULL,
-                           NULL, vu_fd_watch);
+                           NULL, NULL, vu_fd_watch);
     }
 
     aio_co_schedule(ctx, server->co_trip);
@@ -391,7 +392,7 @@ void vhost_user_server_detach_aio_context(VuServer *server)
 
         QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
             aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true,
-                               NULL, NULL, NULL, vu_fd_watch);
+                               NULL, NULL, NULL, NULL, vu_fd_watch);
         }
 
         qio_channel_detach_aio_context(server->ioc);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:36:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:36:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236796.410682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso8J-0005Rp-A0; Thu, 02 Dec 2021 15:36:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236796.410682; Thu, 02 Dec 2021 15:36:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso8J-0005Ri-6L; Thu, 02 Dec 2021 15:36:27 +0000
Received: by outflank-mailman (input) for mailman id 236796;
 Thu, 02 Dec 2021 15:36:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1mso8H-0004Ge-WD
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:36:26 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9b466184-5385-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:36:25 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-528-jeYLELmgM4mFvkTo_4946Q-1; Thu, 02 Dec 2021 10:36:23 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F68A1023F51;
 Thu,  2 Dec 2021 15:36:21 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 76D1A4ABA2;
 Thu,  2 Dec 2021 15:35:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b466184-5385-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459384;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WlTOxFvQ0Tou/htw9qCIl6rN+d5BTtmQf2AISykV2Lk=;
	b=VBdwfJ0soFcMFyk9XhwadMKmo5PGNYPMxl2B9SLtXXLU9zH3g80vgunv4lHNZdcGttDfay
	4x3/xJpkq66YRrBU9njG+TvLBgTKVT+Wfm1xFNlIDfkXRsR2XgCzBk4YGFkfsQM47dPBi2
	JHSNpV1x+XVZ1ITLh9V3ctcX2QZqAf8=
X-MC-Unique: jeYLELmgM4mFvkTo_4946Q-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 2/6] virtio: get rid of VirtIOHandleAIOOutput
Date: Thu,  2 Dec 2021 15:33:58 +0000
Message-Id: <20211202153402.604951-3-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The virtqueue host notifier API
virtio_queue_aio_set_host_notifier_handler() polls the virtqueue for new
buffers. AioContext previously required a bool progress return value
indicating whether an event was handled or not. This is no longer
necessary because the AioContext polling API has been split into a poll
check function and an event handler function. The event handler is only
run when we know there is work to do, so it doesn't return bool.

The VirtIOHandleAIOOutput function signature is now the same as
VirtIOHandleOutput. Get rid of the bool return value.

Further simplifications will be made for virtio-blk and virtio-scsi in
the next patch.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio.h      |  3 +--
 hw/block/dataplane/virtio-blk.c |  4 ++--
 hw/scsi/virtio-scsi-dataplane.c | 18 ++++++------------
 hw/virtio/virtio.c              | 12 ++++--------
 4 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 8bab9cfb75..b90095628f 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -175,7 +175,6 @@ void virtio_error(VirtIODevice *vdev, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
 void virtio_device_set_child_bus_name(VirtIODevice *vdev, char *bus_name);
 
 typedef void (*VirtIOHandleOutput)(VirtIODevice *, VirtQueue *);
-typedef bool (*VirtIOHandleAIOOutput)(VirtIODevice *, VirtQueue *);
 
 VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
                             VirtIOHandleOutput handle_output);
@@ -318,7 +317,7 @@ EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq);
 void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled);
 void virtio_queue_host_notifier_read(EventNotifier *n);
 void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-                                                VirtIOHandleAIOOutput handle_output);
+        VirtIOHandleOutput handle_output);
 VirtQueue *virtio_vector_first_queue(VirtIODevice *vdev, uint16_t vector);
 VirtQueue *virtio_vector_next_queue(VirtQueue *vq);
 
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 252c3a7a23..1b50ccd38b 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -154,7 +154,7 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
     g_free(s);
 }
 
-static bool virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
+static void virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
                                                 VirtQueue *vq)
 {
     VirtIOBlock *s = (VirtIOBlock *)vdev;
@@ -162,7 +162,7 @@ static bool virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
     assert(s->dataplane);
     assert(s->dataplane_started);
 
-    return virtio_blk_handle_vq(s, vq);
+    virtio_blk_handle_vq(s, vq);
 }
 
 /* Context: QEMU global mutex held */
diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
index 18eb824c97..76137de67f 100644
--- a/hw/scsi/virtio-scsi-dataplane.c
+++ b/hw/scsi/virtio-scsi-dataplane.c
@@ -49,49 +49,43 @@ void virtio_scsi_dataplane_setup(VirtIOSCSI *s, Error **errp)
     }
 }
 
-static bool virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
                                               VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_cmd_vq(s, vq);
+        virtio_scsi_handle_cmd_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
-static bool virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
                                                VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_ctrl_vq(s, vq);
+        virtio_scsi_handle_ctrl_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
-static bool virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
                                                 VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_event_vq(s, vq);
+        virtio_scsi_handle_event_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
 static int virtio_scsi_set_host_notifier(VirtIOSCSI *s, VirtQueue *vq, int n)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 0039e1c74c..c042be3935 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -125,7 +125,7 @@ struct VirtQueue
 
     uint16_t vector;
     VirtIOHandleOutput handle_output;
-    VirtIOHandleAIOOutput handle_aio_output;
+    VirtIOHandleOutput handle_aio_output;
     VirtIODevice *vdev;
     EventNotifier guest_notifier;
     EventNotifier host_notifier;
@@ -2300,22 +2300,18 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int align)
     }
 }
 
-static bool virtio_queue_notify_aio_vq(VirtQueue *vq)
+static void virtio_queue_notify_aio_vq(VirtQueue *vq)
 {
-    bool ret = false;
-
     if (vq->vring.desc && vq->handle_aio_output) {
         VirtIODevice *vdev = vq->vdev;
 
         trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
-        ret = vq->handle_aio_output(vdev, vq);
+        vq->handle_aio_output(vdev, vq);
 
         if (unlikely(vdev->start_on_kick)) {
             virtio_set_started(vdev, true);
         }
     }
-
-    return ret;
 }
 
 static void virtio_queue_notify_vq(VirtQueue *vq)
@@ -3552,7 +3548,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
 }
 
 void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-                                                VirtIOHandleAIOOutput handle_output)
+        VirtIOHandleOutput handle_output)
 {
     if (handle_output) {
         vq->handle_aio_output = handle_output;
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:37:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:37:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236802.410693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso9Z-00068M-KH; Thu, 02 Dec 2021 15:37:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236802.410693; Thu, 02 Dec 2021 15:37:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mso9Z-00068F-HE; Thu, 02 Dec 2021 15:37:45 +0000
Received: by outflank-mailman (input) for mailman id 236802;
 Thu, 02 Dec 2021 15:37:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1mso9Y-000685-Lm
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:37:44 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c9aaf6ea-5385-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 16:37:43 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-104-tuIF1GbzP5eXzS-jg1-eyg-1; Thu, 02 Dec 2021 10:37:38 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8AF5B83DD2C;
 Thu,  2 Dec 2021 15:37:36 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A08401836B;
 Thu,  2 Dec 2021 15:36:22 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9aaf6ea-5385-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459461;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tv6ZgPeF9JqTqvfrT/Nt5ske7VQh6DKKAYcNLfnUvF0=;
	b=Rpk75dmH4cc2+Fgmq31cuSXp9tTrveS7f9St0m7h0dw/r4uKOujfnFckpuDD3zPXt/qZwZ
	/2s5APSNTODPBH8ns0Ol7Pl9Keqf1vJlTylYIS+5KwZodBJ161veMMEq4S/Kd3Zeqie4Rw
	MljLKUgy7WCCtKYKWF4okuHAETUUg8o=
X-MC-Unique: tuIF1GbzP5eXzS-jg1-eyg-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 3/6] virtio-blk: drop unused virtio_blk_handle_vq() return value
Date: Thu,  2 Dec 2021 15:33:59 +0000
Message-Id: <20211202153402.604951-4-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The return value of virtio_blk_handle_vq() is no longer used. Get rid of
it. This is a step towards unifying the dataplane and non-dataplane
virtqueue handler functions.

Prepare virtio_blk_handle_output() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd more
specific. This way it won't trigger when dataplane has already been
started.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio-blk.h |  2 +-
 hw/block/virtio-blk.c          | 14 +++-----------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 29655a406d..d311c57cca 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -90,7 +90,7 @@ typedef struct MultiReqBuffer {
     bool is_write;
 } MultiReqBuffer;
 
-bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);
+void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);
 void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh);
 
 #endif
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index f139cd7cc9..82676cdd01 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -767,12 +767,11 @@ static int virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
     return 0;
 }
 
-bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
+void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
 {
     VirtIOBlockReq *req;
     MultiReqBuffer mrb = {};
     bool suppress_notifications = virtio_queue_get_notification(vq);
-    bool progress = false;
 
     aio_context_acquire(blk_get_aio_context(s->blk));
     blk_io_plug(s->blk);
@@ -783,7 +782,6 @@ bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
         }
 
         while ((req = virtio_blk_get_request(s, vq))) {
-            progress = true;
             if (virtio_blk_handle_request(req, &mrb)) {
                 virtqueue_detach_element(req->vq, &req->elem, 0);
                 virtio_blk_free_request(req);
@@ -802,19 +800,13 @@ bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
 
     blk_io_unplug(s->blk);
     aio_context_release(blk_get_aio_context(s->blk));
-    return progress;
-}
-
-static void virtio_blk_handle_output_do(VirtIOBlock *s, VirtQueue *vq)
-{
-    virtio_blk_handle_vq(s, vq);
 }
 
 static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
 {
     VirtIOBlock *s = (VirtIOBlock *)vdev;
 
-    if (s->dataplane) {
+    if (s->dataplane && !s->dataplane_started) {
         /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
          * dataplane here instead of waiting for .set_status().
          */
@@ -823,7 +815,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
             return;
         }
     }
-    virtio_blk_handle_output_do(s, vq);
+    virtio_blk_handle_vq(s, vq);
 }
 
 void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:38:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:38:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236807.410704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAT-0006vJ-VE; Thu, 02 Dec 2021 15:38:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236807.410704; Thu, 02 Dec 2021 15:38:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAT-0006vC-SD; Thu, 02 Dec 2021 15:38:41 +0000
Received: by outflank-mailman (input) for mailman id 236807;
 Thu, 02 Dec 2021 15:38:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1msoAS-000685-Pj
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:38:40 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ebb6b4e1-5385-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 16:38:40 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-340-v-fp4XIFPvO3LGCSu00CSQ-1; Thu, 02 Dec 2021 10:38:35 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D88BF93925;
 Thu,  2 Dec 2021 15:38:33 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id D38A979455;
 Thu,  2 Dec 2021 15:37:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebb6b4e1-5385-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459519;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/qrMGrCx4V1veFpfg1+YpXhPcgKpzBIeI/WEMjnuXFg=;
	b=FDwyxBtPlrOt4YJ56QWFm+M9E4AprTCL8eBxoe7PehqkeHwbKaTLYtdUZiPGbmU0vQ75rs
	NiBbKYNTWUCzc8gMilQtJKxh4qFMjX+Bfp9M5AC/YslSo3QSP99n7XRMeEHKdlQhAnMcUK
	RRanPjeCdwzdFGYgBmRc6l1zsllNno4=
X-MC-Unique: v-fp4XIFPvO3LGCSu00CSQ-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 4/6] virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane
Date: Thu,  2 Dec 2021 15:34:00 +0000
Message-Id: <20211202153402.604951-5-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Prepare virtio_scsi_handle_cmd() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd more
specific. This way it won't trigger when dataplane has already been
started.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/scsi/virtio-scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 51fd09522a..34a968ecfb 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -720,7 +720,7 @@ static void virtio_scsi_handle_cmd(VirtIODevice *vdev, VirtQueue *vq)
     /* use non-QOM casts in the data path */
     VirtIOSCSI *s = (VirtIOSCSI *)vdev;
 
-    if (s->ctx) {
+    if (s->ctx && !s->dataplane_started) {
         virtio_device_start_ioeventfd(vdev);
         if (!s->dataplane_fenced) {
             return;
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:38:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:38:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236808.410715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAX-0007Ck-8S; Thu, 02 Dec 2021 15:38:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236808.410715; Thu, 02 Dec 2021 15:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAX-0007Cd-4O; Thu, 02 Dec 2021 15:38:45 +0000
Received: by outflank-mailman (input) for mailman id 236808;
 Thu, 02 Dec 2021 15:38:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1msoAV-0007B9-Cy
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:38:43 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ecdb3dc9-5385-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:38:42 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-269-wooF7_1ZMPSX3vsKUgOc-A-1; Thu, 02 Dec 2021 10:38:39 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4CE51017968;
 Thu,  2 Dec 2021 15:38:37 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 1E41C19729;
 Thu,  2 Dec 2021 15:38:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ecdb3dc9-5385-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459520;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nlInce6IWTRh/rB2Z2ehw0FDNveTv4bBVY9vPQnOQcs=;
	b=DlNbAvxgBIOXcCZWl+Zk1qnrMXKyoOGDjJIsDRhQ/HlByMMJFWAfnskI7r12tw0GMx8rb+
	G4tQ8ybPk8Gi19Vi16mN0+kkJKU0MMXbul9F/YaMnoSUJksnTd72NK80nm5+ZW20SEVeUu
	7HSOAN7aNNMXM95QVIafuh2IDkLyWm4=
X-MC-Unique: wooF7_1ZMPSX3vsKUgOc-A-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 5/6] virtio: use ->handle_output() instead of ->handle_aio_output()
Date: Thu,  2 Dec 2021 15:34:01 +0000
Message-Id: <20211202153402.604951-6-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The difference between ->handle_output() and ->handle_aio_output() was
that ->handle_aio_output() returned a bool return value indicating
progress. This was needed by the old polling API but now that the bool
return value is gone, the two functions can be unified.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/virtio/virtio.c | 33 +++------------------------------
 1 file changed, 3 insertions(+), 30 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index c042be3935..a97a406d3c 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -125,7 +125,6 @@ struct VirtQueue
 
     uint16_t vector;
     VirtIOHandleOutput handle_output;
-    VirtIOHandleOutput handle_aio_output;
     VirtIODevice *vdev;
     EventNotifier guest_notifier;
     EventNotifier host_notifier;
@@ -2300,20 +2299,6 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int align)
     }
 }
 
-static void virtio_queue_notify_aio_vq(VirtQueue *vq)
-{
-    if (vq->vring.desc && vq->handle_aio_output) {
-        VirtIODevice *vdev = vq->vdev;
-
-        trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
-        vq->handle_aio_output(vdev, vq);
-
-        if (unlikely(vdev->start_on_kick)) {
-            virtio_set_started(vdev, true);
-        }
-    }
-}
-
 static void virtio_queue_notify_vq(VirtQueue *vq)
 {
     if (vq->vring.desc && vq->handle_output) {
@@ -2392,7 +2377,6 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
     vdev->vq[i].vring.num_default = queue_size;
     vdev->vq[i].vring.align = VIRTIO_PCI_VRING_ALIGN;
     vdev->vq[i].handle_output = handle_output;
-    vdev->vq[i].handle_aio_output = NULL;
     vdev->vq[i].used_elems = g_malloc0(sizeof(VirtQueueElement) *
                                        queue_size);
 
@@ -2404,7 +2388,6 @@ void virtio_delete_queue(VirtQueue *vq)
     vq->vring.num = 0;
     vq->vring.num_default = 0;
     vq->handle_output = NULL;
-    vq->handle_aio_output = NULL;
     g_free(vq->used_elems);
     vq->used_elems = NULL;
     virtio_virtqueue_reset_region_cache(vq);
@@ -3509,14 +3492,6 @@ EventNotifier *virtio_queue_get_guest_notifier(VirtQueue *vq)
     return &vq->guest_notifier;
 }
 
-static void virtio_queue_host_notifier_aio_read(EventNotifier *n)
-{
-    VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
-    if (event_notifier_test_and_clear(n)) {
-        virtio_queue_notify_aio_vq(vq);
-    }
-}
-
 static void virtio_queue_host_notifier_aio_poll_begin(EventNotifier *n)
 {
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
@@ -3536,7 +3511,7 @@ static void virtio_queue_host_notifier_aio_poll_ready(EventNotifier *n)
 {
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
 
-    virtio_queue_notify_aio_vq(vq);
+    virtio_queue_notify_vq(vq);
 }
 
 static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
@@ -3551,9 +3526,8 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         VirtIOHandleOutput handle_output)
 {
     if (handle_output) {
-        vq->handle_aio_output = handle_output;
         aio_set_event_notifier(ctx, &vq->host_notifier, true,
-                               virtio_queue_host_notifier_aio_read,
+                               virtio_queue_host_notifier_read,
                                virtio_queue_host_notifier_aio_poll,
                                virtio_queue_host_notifier_aio_poll_ready);
         aio_set_event_notifier_poll(ctx, &vq->host_notifier,
@@ -3563,8 +3537,7 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
         /* Test and clear notifier before after disabling event,
          * in case poll callback didn't have time to run. */
-        virtio_queue_host_notifier_aio_read(&vq->host_notifier);
-        vq->handle_aio_output = NULL;
+        virtio_queue_host_notifier_read(&vq->host_notifier);
     }
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:38:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:38:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236809.410726 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAY-0007UT-M6; Thu, 02 Dec 2021 15:38:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236809.410726; Thu, 02 Dec 2021 15:38:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoAY-0007UI-He; Thu, 02 Dec 2021 15:38:46 +0000
Received: by outflank-mailman (input) for mailman id 236809;
 Thu, 02 Dec 2021 15:38:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1msoAX-0007B9-Kg
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:38:45 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee8858d9-5385-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:38:44 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-588-6dZiHXC6PU2fCrw_itfNlw-1; Thu, 02 Dec 2021 10:38:40 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 266F51017965;
 Thu,  2 Dec 2021 15:38:39 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id B6E4F17D61;
 Thu,  2 Dec 2021 15:38:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee8858d9-5385-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638459523;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GODRO8VwL654MSY/Ejdch+2nt9+ibQMEAAK5LSSE3hM=;
	b=VRJKdhFz4LrF5gMquQ190veOy/PgPLD6aPWPIS8PxbMLmJPd4bBzl3YFQ+ktkrnf+lkMCn
	RjbbHIzZujRGZkt9etFhJN7+jbFRFsDura0ITU6yJqyKNhldT0CDwzu9QkNkF5WgFmC+9U
	V5bswnLexOQ1MjqbGUQN/ttAPs7lIM4=
X-MC-Unique: 6dZiHXC6PU2fCrw_itfNlw-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>,
	=?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org,
	Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v2 6/6] virtio: unify dataplane and non-dataplane ->handle_output()
Date: Thu,  2 Dec 2021 15:34:02 +0000
Message-Id: <20211202153402.604951-7-stefanha@redhat.com>
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Now that virtio-blk and virtio-scsi are ready, get rid of
the handle_aio_output() callback. It's no longer needed.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio.h      |  4 +--
 hw/block/dataplane/virtio-blk.c | 16 ++--------
 hw/scsi/virtio-scsi-dataplane.c | 54 ++++-----------------------------
 hw/virtio/virtio.c              | 32 +++++++++----------
 4 files changed, 26 insertions(+), 80 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index b90095628f..f095637058 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -316,8 +316,8 @@ bool virtio_device_ioeventfd_enabled(VirtIODevice *vdev);
 EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq);
 void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled);
 void virtio_queue_host_notifier_read(EventNotifier *n);
-void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-        VirtIOHandleOutput handle_output);
+void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx);
+void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx);
 VirtQueue *virtio_vector_first_queue(VirtIODevice *vdev, uint16_t vector);
 VirtQueue *virtio_vector_next_queue(VirtQueue *vq);
 
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 1b50ccd38b..f88f08ef59 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -154,17 +154,6 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
     g_free(s);
 }
 
-static void virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
-                                                VirtQueue *vq)
-{
-    VirtIOBlock *s = (VirtIOBlock *)vdev;
-
-    assert(s->dataplane);
-    assert(s->dataplane_started);
-
-    virtio_blk_handle_vq(s, vq);
-}
-
 /* Context: QEMU global mutex held */
 int virtio_blk_data_plane_start(VirtIODevice *vdev)
 {
@@ -258,8 +247,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
     for (i = 0; i < nvqs; i++) {
         VirtQueue *vq = virtio_get_queue(s->vdev, i);
 
-        virtio_queue_aio_set_host_notifier_handler(vq, s->ctx,
-                virtio_blk_data_plane_handle_output);
+        virtio_queue_aio_attach_host_notifier(vq, s->ctx);
     }
     aio_context_release(s->ctx);
     return 0;
@@ -302,7 +290,7 @@ static void virtio_blk_data_plane_stop_bh(void *opaque)
     for (i = 0; i < s->conf->num_queues; i++) {
         VirtQueue *vq = virtio_get_queue(s->vdev, i);
 
-        virtio_queue_aio_set_host_notifier_handler(vq, s->ctx, NULL);
+        virtio_queue_aio_detach_host_notifier(vq, s->ctx);
     }
 }
 
diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
index 76137de67f..29575cbaf6 100644
--- a/hw/scsi/virtio-scsi-dataplane.c
+++ b/hw/scsi/virtio-scsi-dataplane.c
@@ -49,45 +49,6 @@ void virtio_scsi_dataplane_setup(VirtIOSCSI *s, Error **errp)
     }
 }
 
-static void virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
-                                              VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_cmd_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
-static void virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
-                                               VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_ctrl_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
-static void virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
-                                                VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_event_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
 static int virtio_scsi_set_host_notifier(VirtIOSCSI *s, VirtQueue *vq, int n)
 {
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s)));
@@ -112,10 +73,10 @@ static void virtio_scsi_dataplane_stop_bh(void *opaque)
     VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
     int i;
 
-    virtio_queue_aio_set_host_notifier_handler(vs->ctrl_vq, s->ctx, NULL);
-    virtio_queue_aio_set_host_notifier_handler(vs->event_vq, s->ctx, NULL);
+    virtio_queue_aio_detach_host_notifier(vs->ctrl_vq, s->ctx);
+    virtio_queue_aio_detach_host_notifier(vs->event_vq, s->ctx);
     for (i = 0; i < vs->conf.num_queues; i++) {
-        virtio_queue_aio_set_host_notifier_handler(vs->cmd_vqs[i], s->ctx, NULL);
+        virtio_queue_aio_detach_host_notifier(vs->cmd_vqs[i], s->ctx);
     }
 }
 
@@ -176,14 +137,11 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev)
     memory_region_transaction_commit();
 
     aio_context_acquire(s->ctx);
-    virtio_queue_aio_set_host_notifier_handler(vs->ctrl_vq, s->ctx,
-                                            virtio_scsi_data_plane_handle_ctrl);
-    virtio_queue_aio_set_host_notifier_handler(vs->event_vq, s->ctx,
-                                           virtio_scsi_data_plane_handle_event);
+    virtio_queue_aio_attach_host_notifier(vs->ctrl_vq, s->ctx);
+    virtio_queue_aio_attach_host_notifier(vs->event_vq, s->ctx);
 
     for (i = 0; i < vs->conf.num_queues; i++) {
-        virtio_queue_aio_set_host_notifier_handler(vs->cmd_vqs[i], s->ctx,
-                                             virtio_scsi_data_plane_handle_cmd);
+        virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], s->ctx);
     }
 
     s->dataplane_starting = false;
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index a97a406d3c..ce182a4e57 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3522,23 +3522,23 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
     virtio_queue_set_notification(vq, 1);
 }
 
-void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-        VirtIOHandleOutput handle_output)
+void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx)
 {
-    if (handle_output) {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true,
-                               virtio_queue_host_notifier_read,
-                               virtio_queue_host_notifier_aio_poll,
-                               virtio_queue_host_notifier_aio_poll_ready);
-        aio_set_event_notifier_poll(ctx, &vq->host_notifier,
-                                    virtio_queue_host_notifier_aio_poll_begin,
-                                    virtio_queue_host_notifier_aio_poll_end);
-    } else {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
-        /* Test and clear notifier before after disabling event,
-         * in case poll callback didn't have time to run. */
-        virtio_queue_host_notifier_read(&vq->host_notifier);
-    }
+    aio_set_event_notifier(ctx, &vq->host_notifier, true,
+                           virtio_queue_host_notifier_read,
+                           virtio_queue_host_notifier_aio_poll,
+                           virtio_queue_host_notifier_aio_poll_ready);
+    aio_set_event_notifier_poll(ctx, &vq->host_notifier,
+                                virtio_queue_host_notifier_aio_poll_begin,
+                                virtio_queue_host_notifier_aio_poll_end);
+}
+
+void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx)
+{
+    aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
+    /* Test and clear notifier before after disabling event,
+     * in case poll callback didn't have time to run. */
+    virtio_queue_host_notifier_read(&vq->host_notifier);
 }
 
 void virtio_queue_host_notifier_read(EventNotifier *n)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:50:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:50:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236822.410736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoLb-0001wZ-NE; Thu, 02 Dec 2021 15:50:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236822.410736; Thu, 02 Dec 2021 15:50:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoLb-0001wS-KG; Thu, 02 Dec 2021 15:50:11 +0000
Received: by outflank-mailman (input) for mailman id 236822;
 Thu, 02 Dec 2021 15:50:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=JBuH=QT=redhat.com=rjones@srs-se1.protection.inumbo.net>)
 id 1msoLa-0001wM-2L
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:50:10 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 860cafc0-5387-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 16:50:08 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-165-z5f4yFOxNSqRU_ESNFcjuA-1; Thu, 02 Dec 2021 10:50:05 -0500
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
 [10.5.11.23])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 191351023F52;
 Thu,  2 Dec 2021 15:50:03 +0000 (UTC)
Received: from localhost (unknown [10.39.193.22])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 29842196FC;
 Thu,  2 Dec 2021 15:49:09 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 860cafc0-5387-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638460207;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DwDFL780Dv/zY+dUlAUznVuZNLTsUT/0J7f+xwGcORw=;
	b=FDbx5rj6uDOtPwxmXcKTY0qAFGFVh9bRpxleWUfKmI0bNOs6DKV1zaWcR8pqacBDv1QhqK
	V2c9scPSZKXJP7sKLNr8A04A4cyD2JCB0eYam6cFq+ZSi1D+zxevOw+tIP3r4dxa3zWndR
	LyUIGMJubIUqk+ShW33nY5hQyrQIlIk=
X-MC-Unique: z5f4yFOxNSqRU_ESNFcjuA-1
Date: Thu, 2 Dec 2021 15:49:08 +0000
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= <berrange@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>, Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org, Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: Re: [PATCH v2 0/6] aio-posix: split poll check from ready handler
Message-ID: <20211202154908.GW1127@redhat.com>
References: <20211202153402.604951-1-stefanha@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20211202153402.604951-1-stefanha@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rjones@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


Not sure if this is related, but builds are failing with:

FAILED: libblockdev.fa.p/block_export_fuse.c.o=20
cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader =
-I/usr/include/fuse3 -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/us=
r/lib64/glib-2.0/include -I/usr/include/sysprof-4 -fdiagnostics-color=3Daut=
o -Wall -Winvalid-pch -std=3Dgnu11 -O2 -g -isystem /home/rjones/d/qemu/linu=
x-headers -isystem linux-headers -iquote . -iquote /home/rjones/d/qemu -iqu=
ote /home/rjones/d/qemu/include -iquote /home/rjones/d/qemu/disas/libvixl -=
iquote /home/rjones/d/qemu/tcg/i386 -pthread -DSTAP_SDT_V2 -U_FORTIFY_SOURC=
E -D_FORTIFY_SOURCE=3D2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE=
_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmis=
sing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declar=
ation -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -=
Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-label=
s -Wexpansion-to-defined -Wimplicit-fallthrough=3D2 -Wno-missing-include-di=
rs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE -MD =
-MQ libblockdev.fa.p/block_export_fuse.c.o -MF libblockdev.fa.p/block_expor=
t_fuse.c.o.d -o libblockdev.fa.p/block_export_fuse.c.o -c ../block/export/f=
use.c
../block/export/fuse.c: In function =E2=80=98setup_fuse_export=E2=80=99:
../block/export/fuse.c:226:59: warning: passing argument 7 of =E2=80=98aio_=
set_fd_handler=E2=80=99 from incompatible pointer type [-Wincompatible-poin=
ter-types]
  226 |                        read_from_fuse_export, NULL, NULL, exp);
      |                                                           ^~~
      |                                                           |
      |                                                           FuseExpor=
t *
In file included from ../block/export/fuse.c:22:
/home/rjones/d/qemu/include/block/aio.h:472:36: note: expected =E2=80=98voi=
d (*)(void *)=E2=80=99 but argument is of type =E2=80=98FuseExport *=E2=80=
=99
  472 |                         IOHandler *io_poll_ready,
      |                         ~~~~~~~~~~~^~~~~~~~~~~~~
../block/export/fuse.c:224:5: error: too few arguments to function =E2=80=
=98aio_set_fd_handler=E2=80=99
  224 |     aio_set_fd_handler(exp->common.ctx,
      |     ^~~~~~~~~~~~~~~~~~
In file included from ../block/export/fuse.c:22:
/home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
  466 | void aio_set_fd_handler(AioContext *ctx,
      |      ^~~~~~~~~~~~~~~~~~
../block/export/fuse.c: In function =E2=80=98fuse_export_shutdown=E2=80=99:
../block/export/fuse.c:268:13: error: too few arguments to function =E2=80=
=98aio_set_fd_handler=E2=80=99
  268 |             aio_set_fd_handler(exp->common.ctx,
      |             ^~~~~~~~~~~~~~~~~~
In file included from ../block/export/fuse.c:22:
/home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
  466 | void aio_set_fd_handler(AioContext *ctx,
      |      ^~~~~~~~~~~~~~~~~~

Rich.

--=20
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjon=
es
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:56:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:56:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236831.410747 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoRL-0002o8-Bo; Thu, 02 Dec 2021 15:56:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236831.410747; Thu, 02 Dec 2021 15:56:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoRL-0002o1-8p; Thu, 02 Dec 2021 15:56:07 +0000
Received: by outflank-mailman (input) for mailman id 236831;
 Thu, 02 Dec 2021 15:56:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4zFf=QT=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1msoRJ-0002nv-Lp
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:56:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 58f43b87-5388-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 16:56:02 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-143-5ye8EyOSNHGK2TwQJ_F6aQ-1; Thu, 02 Dec 2021 10:55:58 -0500
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C39A2190D340;
 Thu,  2 Dec 2021 15:55:55 +0000 (UTC)
Received: from localhost (unknown [10.39.193.31])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 5423E10023B8;
 Thu,  2 Dec 2021 15:55:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58f43b87-5388-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638460561;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TAQHhiGj0Hm+ap6kk3Z+FJrUCF740xv8Es/itHFsW3o=;
	b=QJAnN3yKV+iHSViHjE+Mq/0ae7nGwBQXBXCshlwh8w72jOqVXuctM+c398a+9FMFIfx3d0
	zZ/9p0lo+RDKhpvg0fzikN9XMIH1+F/2e1I9oG0M5Y//ljSg7Xp+k6rz0qNfVpKPEKv915
	ATdL/sw7tHXk3xO3Hbjrx21Ghf0CuIs=
X-MC-Unique: 5ye8EyOSNHGK2TwQJ_F6aQ-1
Date: Thu, 2 Dec 2021 15:55:54 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
	Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= <berrange@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>, Coiby Xu <Coiby.Xu@gmail.com>,
	qemu-block@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xen-devel@lists.xenproject.org, Stefan Weil <sw@weilnetz.de>,
	Fam Zheng <fam@euphon.net>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Peter Lieven <pl@kamp.de>
Subject: Re: [PATCH v2 0/6] aio-posix: split poll check from ready handler
Message-ID: <YajsimpUt5FNUSlx@stefanha-x1.localdomain>
References: <20211202153402.604951-1-stefanha@redhat.com>
 <20211202154908.GW1127@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20211202154908.GW1127@redhat.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="KOuTwbKWisAWfM5Q"
Content-Disposition: inline

--KOuTwbKWisAWfM5Q
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 02, 2021 at 03:49:08PM +0000, Richard W.M. Jones wrote:
>=20
> Not sure if this is related, but builds are failing with:
>=20
> FAILED: libblockdev.fa.p/block_export_fuse.c.o=20
> cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shade=
r -I/usr/include/fuse3 -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/=
usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -fdiagnostics-color=3Da=
uto -Wall -Winvalid-pch -std=3Dgnu11 -O2 -g -isystem /home/rjones/d/qemu/li=
nux-headers -isystem linux-headers -iquote . -iquote /home/rjones/d/qemu -i=
quote /home/rjones/d/qemu/include -iquote /home/rjones/d/qemu/disas/libvixl=
 -iquote /home/rjones/d/qemu/tcg/i386 -pthread -DSTAP_SDT_V2 -U_FORTIFY_SOU=
RCE -D_FORTIFY_SOURCE=3D2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFI=
LE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wm=
issing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-decl=
aration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k=
 -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-lab=
els -Wexpansion-to-defined -Wimplicit-fallthrough=3D2 -Wno-missing-include-=
dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE -M=
D -MQ libblockdev.fa.p/block_export_fuse.c.o -MF libblockdev.fa.p/block_exp=
ort_fuse.c.o.d -o libblockdev.fa.p/block_export_fuse.c.o -c ../block/export=
/fuse.c
> ../block/export/fuse.c: In function =E2=80=98setup_fuse_export=E2=80=99:
> ../block/export/fuse.c:226:59: warning: passing argument 7 of =E2=80=98ai=
o_set_fd_handler=E2=80=99 from incompatible pointer type [-Wincompatible-po=
inter-types]
>   226 |                        read_from_fuse_export, NULL, NULL, exp);
>       |                                                           ^~~
>       |                                                           |
>       |                                                           FuseExp=
ort *
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:472:36: note: expected =E2=80=98v=
oid (*)(void *)=E2=80=99 but argument is of type =E2=80=98FuseExport *=E2=
=80=99
>   472 |                         IOHandler *io_poll_ready,
>       |                         ~~~~~~~~~~~^~~~~~~~~~~~~
> ../block/export/fuse.c:224:5: error: too few arguments to function =E2=80=
=98aio_set_fd_handler=E2=80=99
>   224 |     aio_set_fd_handler(exp->common.ctx,
>       |     ^~~~~~~~~~~~~~~~~~
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
>   466 | void aio_set_fd_handler(AioContext *ctx,
>       |      ^~~~~~~~~~~~~~~~~~
> ../block/export/fuse.c: In function =E2=80=98fuse_export_shutdown=E2=80=
=99:
> ../block/export/fuse.c:268:13: error: too few arguments to function =E2=
=80=98aio_set_fd_handler=E2=80=99
>   268 |             aio_set_fd_handler(exp->common.ctx,
>       |             ^~~~~~~~~~~~~~~~~~
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
>   466 | void aio_set_fd_handler(AioContext *ctx,
>       |      ^~~~~~~~~~~~~~~~~~

Yes, thanks!

Stefan

--KOuTwbKWisAWfM5Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmGo7IoACgkQnKSrs4Gr
c8hhnwgAsylfZZ3Az6JIYycSiNK75rEOP3cIy34Pz1M55Y99XAiKnZWFAfgU+5Mw
Fh+lFqoDroRS7gA5iTUbBozi5FsT70aFs+/OVExNfSeqnObRXcDJEPGZZ+JZDi16
ub6W/hMxnvD8sf5TL1GvuuG26gV+baEbU4DHpzeDe6/QX1fdh7ZuSKh3YmesUEB9
INBBSj180damsjMCVRJsUW0tSUaayWoHcp/rMEGQhw7auLV97kNgHKyk406fbIBi
XdSS9uAma/KjAFSflsfdhLNfMuc6++Xcgh6x4YGQNHwcKGuU4TZEPE2W1IFyt5r0
dcEdqxoXgaXGLfTATFmQ16+gyNI8DA==
=8Hst
-----END PGP SIGNATURE-----

--KOuTwbKWisAWfM5Q--



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 15:59:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 15:59:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236837.410759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoUp-0003em-RH; Thu, 02 Dec 2021 15:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236837.410759; Thu, 02 Dec 2021 15:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoUp-0003ef-O5; Thu, 02 Dec 2021 15:59:43 +0000
Received: by outflank-mailman (input) for mailman id 236837;
 Thu, 02 Dec 2021 15:59:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msoUn-0003eZ-W7
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 15:59:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db8a1d54-5388-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 16:59:40 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-uaUlfKsvNoyJGtSp_xZvLw-1; Thu, 02 Dec 2021 16:59:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec
 2021 15:59:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 15:59:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0023.eurprd04.prod.outlook.com (2603:10a6:20b:310::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Thu, 2 Dec 2021 15:59:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db8a1d54-5388-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638460780;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=F12yfpTN5XyPdyXcxW7s/UW+pE4Jqt2nMyrbyRPMU4s=;
	b=KpVDGKE5Jq/bI5t9R4J7p/kJz80i4GBgUsWJwu+RUZGDM441Cf9HvnoRXLoq1quY5qWDkh
	F4hyarPuYr8xM2ajZYBmZnglU+3w2n+tTH4FzrwlXsRAZRIYgklKs7wutB0v7xzFYiDcA8
	9R39SUeC5zRX60XqCRoBIpmvHvwaytM=
X-MC-Unique: uaUlfKsvNoyJGtSp_xZvLw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Keo5mhAo5zx7kPjz3EJNJ6jtQlADdpDfWNaV9UQ9855zSvKyqEA2QYlXPd+B0M5nbyNwbWeEfjgWIuTCcdgl4s4iM0qToI0PgOPXsTHITTYA9MV99/uEz5P+vLTWWW74nixpwxXDyFHAxekL3XaTjnD//u6mRkaimR/8lQ2wgBm4Wl0mS2Sgeb+/TD96spqzAj7joa0z/AmVDh6d9mv0rOH4nkR5HxJgk5ZxGIRWXIpoBmwM4bLv5hXdy5ukW6yj8mmjRzVPwMhbLQnMiLIknWPJQTRjytRf6HbabkRcV2AK99SsPWbFMafOUNEI4AotGjLj0HiYo7scJ4nx5n7Qjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q4gXzBgNyOmjr0o1kPGL4Qi8t5k/TrlIA/QIcQvPeQI=;
 b=WZAsMcnivzk+tyP01msUTSKahP3l5OxyQB1+VnC8kD8s5EpZ3JaWYmkladf1CE/y44q7781gLrbmh1QujDCZ9WYvr6akQ/Es8zihRw/vIi5H1J2Lj9snXl7GRpOv5IGzkpAjhT616wqJzg4YX5b5JZVcjXjy8TfqxPbfxfx++epNXEO2fOEud/C1DFAXxaJ7dtsYLNVAlxkujb3pBkd9DYMMPy2WjAoWmg5SBCO3r7zi18WKXezrDFuVQSMQT9u/pVlCIxCP0MgNzWg8KwyhsJ7qYT/PqBcCS380kl+KFDmG2Fca+08zPlrhKvE/gsIVP2d1gWLL0YmREakbpbE7cQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ea607a3a-55ca-7ad0-7a02-902516ac8528@suse.com>
Date: Thu, 2 Dec 2021 16:59:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 05/18] IOMMU: have iommu_{,un}map() split requests into
 largest possible chunks
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <134785fb-8ac1-50f0-de75-e0d6fe22f711@suse.com>
 <YaZCOHoTua8al3fU@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YaZCOHoTua8al3fU@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0023.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b78778e-a665-4da4-9d2c-08d9b5acbe08
X-MS-TrafficTypeDiagnostic: VI1PR04MB4349:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4349C3461DEFADDF163CC71DB3699@VI1PR04MB4349.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CK+wEO9bIlsXE2Gf/pyneIOk9/BgGtMnXnP0qSDGSKlwifOGs5jrb1qaaS48UGNQiygSoCS6P2gei0WgRF7iKvjHtDDL/nlvb7Oge4Q8M8UZ2y9xgYSd8nR35YIB8CtWOINXfv8NYCP6bq15lZvGK7PbXyRoJT2NXwMqeDWrMM4A5lqdR6zT1BF9RT1/38R8Fo+l8tW95bHLqr0rbckvKS/EC1TH7uKYuDHADwfxKwpXC3oext44vV7V9Nc1/TvuN7ZlaclB1WHEM0iJgmP8wXtm9grH+PW9xwCatlrNIvPO+zcsI8E9w+j/o+dGIE5n51w1/3ceKnEgHCLGxnh9zvU5ONz/H9sb9JppebeLuydpGAFJnK1zGhv2x2nAi7Kp53SidFui449NMTWXFgBQOC6UgvYWbuZu7aIxCsrNG0EEMGXciCw27lw4+wlFun48RiwlF6bCIigIjDs/8zyi92LLWDoSPPDQEtrPfXh/neSZiKNqwG8n+uQJ/fI/Dv0Gy3H1j4ZTMl+XqC6/bsTZM88r3jNiimQ6BwMT7lRZEoGf/JutzhxuQBgoGF1yXBsGV1hJjvIfKC00kfXaiZgRtot/s02CDBJg5RAGXGfX4kVm1w8h7HJGRNBhPjn5QQataNmW5vr32NggyNoDP5Jpj6eqyGy+wwm7//MwEwuIRlrv1Uw2815ErMBNoYzJnrI+6DxIOFDUa/IDCekmBXvL4nOJVJWpZVQg9/YZ/d1HIrQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(66556008)(16576012)(2616005)(66476007)(6486002)(4326008)(956004)(66946007)(31686004)(186003)(316002)(54906003)(8676002)(2906002)(86362001)(5660300002)(83380400001)(38100700002)(31696002)(26005)(508600001)(6916009)(8936002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?z80RRc4Dm2LzTw/mT2/nDClmXv0V5Ky/fAqpOgE/e7Qv/2x3eRjFrprt4XGA?=
 =?us-ascii?Q?pzCo0/+v33GRScei8zLSbf7fm2Rrnxf0eKPEKK5COS5KfhuUJX5ODKlC9Nah?=
 =?us-ascii?Q?YWP7u7IPtIbCtH2HAR95Pl2XHOK7cgDVR5O80QRjurrl3zmo7XxQY3ThDmnz?=
 =?us-ascii?Q?U5dNVaJOvXNGYdondZx1ssnf8+3Cq5AyTCk2IQtzsoCU++k7Caue4OI64zSd?=
 =?us-ascii?Q?a+YsXZ70WII2uSgU+PMht7Q46hhWf0TASIz9XWT7EUNMzzEFVo4mPyF9e7iV?=
 =?us-ascii?Q?+t++lpblt++v9uEYI2N+O+/1ZK/p4M5Vay35bMWo9VObKWx8mnv5waSRdyQq?=
 =?us-ascii?Q?9b049DLfB310Txy/suBV62PTA1Oh0oyUQtRmyiBPDgAhJSgc8Hz/NTB4XFmy?=
 =?us-ascii?Q?68c32QgWH50jpg6nYoWZbM/tAL6DsN+K5GphqTJ7JZSn5VyC6nhCfR4/0iQl?=
 =?us-ascii?Q?5wr9X48y1myT+2MShfDovHr5J/adK/oWMQcZpCv0ZpojIp1RfS41XD53r3YW?=
 =?us-ascii?Q?deFgNhSg/DgLSXMXO/XSKjJFjPp/sJxx4w43T+Hg0Z9eddW7n4stqkj95UmC?=
 =?us-ascii?Q?+f8LNNO+QIzzEVTcXir8CbfJazuyfHfvjexQGkmjUnFkvCdvUe9jshjqG3lN?=
 =?us-ascii?Q?se+4SIzpGAlmGB+fp7oR93nlCpl3DCrQj4HCaC8OGZuppgwSkCp/qptCgZUg?=
 =?us-ascii?Q?s1NERJH84rdi7ng+b3cnamyPd16AonAeC6RAkiPlDTXVr88JsrQxJKuqwByj?=
 =?us-ascii?Q?z6h4Tpe8gN0iYsXgLIZ3MaAzw5jwmF7shDDLylcRzK1Ld142OlgAKBHEHmWX?=
 =?us-ascii?Q?MG/Yy2/+Z5qPgb97yBRrZPndpa340g8h1F3jDoSjxKKLlqya/h/Kwt3Ta8Le?=
 =?us-ascii?Q?5sl2tS5otYxdOBxXQO/nUbiC1P/FG8LgyEAiuNlxz6PlkorGQ9EKBe/+aEKA?=
 =?us-ascii?Q?P8ru3W0T3AHoktaaXsmEP5bLc7nLY8u4QouljPHDmlV6XnlXG3is63xZMj2q?=
 =?us-ascii?Q?IQKvM8ta+VxLjMEDxAWHah4KsPwg95SMpdEfb1Wpu44Dqwlf1n8IBID6mPqt?=
 =?us-ascii?Q?eV4wfO5NGO77ynO7gtf7BN0CjVM181wwjaU8zypyj3UGZlRxqrzwnMtEKSxE?=
 =?us-ascii?Q?X0sfdiLRSkaS4y8QOiWxtaR09MtM0fethEih4hrsO7NpXffqG6A6r5H89Rcm?=
 =?us-ascii?Q?bDMPq6Bh5ma9k67+mYUDrr18EyBE4ZtEcOImW070wCWLBV1EC2HZYizzCSgg?=
 =?us-ascii?Q?w5F2V9wgYSVNkvXz/rXI9GgVqv0F+bHZ5elhhiC7BBcyc/5bI2OTU3FwDfhU?=
 =?us-ascii?Q?xu5CRM0TNI7K3YmyzBTKPtpmN+NaCQZe3uUW919uEU0CfNlakIafOsfl0QXk?=
 =?us-ascii?Q?jY5Rhq5NKwksDgBBW6b5FhbZA0AFJScAJY4wu6nKanXMhAM/xD5szEvVfzWH?=
 =?us-ascii?Q?lnpjn62IxKXzTTb3n595wIWO/K2driLieEizYAgojUNowCRbtHaqYe6C6x1u?=
 =?us-ascii?Q?Te2r2odoyKXmDDhA3f3mGM9VC/N9EqtMgS9XwfbDC8i18PaIQbWa3h2bd/Ch?=
 =?us-ascii?Q?tJg5G3S/Oct+sgC0HORrQye+vRW/TK5r6lh8UWl3rSeVh43W55ErUqkF7kJy?=
 =?us-ascii?Q?ao2tlP1vgDpy5GQe1wcz8ZQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b78778e-a665-4da4-9d2c-08d9b5acbe08
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 15:59:37.8772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zFr3TDDDVkgK7Yd2og6J32IO/0If1W+K7emQTNaAaK98/rVgxZ8yil2d4zEx+PphsLx2NUP9AqWwFxpFr22vqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349

On 30.11.2021 16:24, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:45:57AM +0200, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/iommu.c
>> +++ b/xen/drivers/passthrough/iommu.c
>> @@ -260,12 +260,38 @@ void iommu_domain_destroy(struct domain
>>      arch_iommu_domain_destroy(d);
>>  }
>> =20
>> -int iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
>> +static unsigned int mapping_order(const struct domain_iommu *hd,
>> +                                  dfn_t dfn, mfn_t mfn, unsigned long n=
r)
>> +{
>> +    unsigned long res =3D dfn_x(dfn) | mfn_x(mfn);
>> +    unsigned long sizes =3D hd->platform_ops->page_sizes;
>> +    unsigned int bit =3D find_first_set_bit(sizes), order =3D 0;
>> +
>> +    ASSERT(bit =3D=3D PAGE_SHIFT);
>> +
>> +    while ( (sizes =3D (sizes >> bit) & ~1) )
>> +    {
>> +        unsigned long mask;
>> +
>> +        bit =3D find_first_set_bit(sizes);
>> +        mask =3D (1UL << bit) - 1;
>> +        if ( nr <=3D mask || (res & mask) )
>> +            break;
>> +        order +=3D bit;
>> +        nr >>=3D bit;
>> +        res >>=3D bit;
>> +    }
>> +
>> +    return order;
>> +}
>=20
> This looks like it could be used in other places, I would at least
> consider using it in pvh_populate_memory_range where we also need to
> figure out the maximum order given an address and a number of pages.
>=20
> Do you think you could place it in a more generic file and also use
> more generic parameters (ie: unsigned long gfn and mfn)?

The function as is surely isn't reusable, for its use of IOMMU
specific data. If and when a 2nd user appears, it'll be far clearer
whether and if so how much of it is worth generalizing. (Among other
things I'd like to retain the typesafe parameter types here.)

>> @@ -284,14 +316,18 @@ int iommu_map(struct domain *d, dfn_t df
>>          if ( !d->is_shutting_down && printk_ratelimit() )
>>              printk(XENLOG_ERR
>>                     "d%d: IOMMU mapping dfn %"PRI_dfn" to mfn %"PRI_mfn"=
 failed: %d\n",
>> -                   d->domain_id, dfn_x(dfn_add(dfn, i)),
>> -                   mfn_x(mfn_add(mfn, i)), rc);
>> +                   d->domain_id, dfn_x(dfn), mfn_x(mfn), rc);
>> +
>> +        for ( j =3D 0; j < i; j +=3D 1UL << order )
>> +        {
>> +            dfn =3D dfn_add(dfn0, j);
>> +            order =3D mapping_order(hd, dfn, _mfn(0), i - j);
>> =20
>> -        while ( i-- )
>>              /* if statement to satisfy __must_check */
>> -            if ( iommu_call(hd->platform_ops, unmap_page, d, dfn_add(df=
n, i),
>> -                            0, flush_flags) )
>> +            if ( iommu_call(hd->platform_ops, unmap_page, d, dfn, order=
,
>> +                            flush_flags) )
>>                  continue;
>> +        }
>=20
> Why you need this unmap loop here, can't you just use iommu_unmap?

Good question - I merely converted the loop that was already there.
Looks like that could have been changed to a simple call already
before. I'll change it here, on the assumption that splitting this
out isn't going to be a worthwhile exercise.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 16:04:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 16:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236844.410769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoZE-0005ZG-Hx; Thu, 02 Dec 2021 16:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236844.410769; Thu, 02 Dec 2021 16:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msoZE-0005Z9-Es; Thu, 02 Dec 2021 16:04:16 +0000
Received: by outflank-mailman (input) for mailman id 236844;
 Thu, 02 Dec 2021 16:04:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tajg=QT=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msoZC-0005Yu-LA
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 16:04:15 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7cf9582c-5389-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 17:04:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7cf9582c-5389-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638461053;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=hth0/2PAAOOA44hPfWHgtHlrA5qqYJv97X/Y+J4K0Gs=;
  b=cvDVICf98P8kVKDJx2JM4xA4g3eKI3RKT/Y4xQ+/1FVD1ntdxUCW+j0T
   F1pX9pC6Q2A+YIO/ixBC+nIK8dSiDOG/7aNfNAb+RHxn99N7gCLg3fV0F
   Di89oM4gMXVB6UUHTABK5xgyp2iZ/99GuGKbA5ClGKS9Mcep7kMZX3XgS
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 3746URqyojUjmfs7YxvaEaobORD0RJSrMHFN5nViKj67OT+E3Ld0ldCYNPNWaFLQiZ1FdDqoet
 j0v6WjVZvrljGNWEmGDJ2+scoeZ7aXLdnT0JUrhhTfshcAj72WYCsxbTPoDzCZ+xtP7bm6rexN
 z2mep8qH2cou5pY7ebDDbvdkXBXTUnvEva0mKFE87njQxYFjnYvIDn6K1gaeFSM9oq20lVtln0
 oRUmSwWPME78B7+W1JKlSTc+Amw8L0DqDxmP2IYB95JKpnjkoPCExTF4W/wGkhpY7e59zzd93/
 pRp4j1M5Qz/Y13/8hGpsfRA3
X-SBRS: 5.1
X-MesageID: 59519128
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9RWAPKhl/p0PlWL668a9lz4SX161jRcKZh0ujC45NGQN5FlHY01je
 htvWG7XPP7cYWT0KNAkYYy19B8O7J/Uzt8xTgJs+yoxEC4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw24Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1/i66bTz8xb5Tcv98DThZdAhlsEpZJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t150XTK+EN
 6L1bxI/QE/wQRtCIW0sCaljrdyHtCageBxH/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru4GDREhwcctuFxlKt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT80TirLW48Vm94ePsdqtI5QC0Sx
 HCykIa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+99q0E+WJjp3OOvs14CuR2msq
 9yfhHFm3+17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGSxEgnpU
 JsswZH2AAUy4Xelz3flrAIlRu/B2hp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO
 RGI6VgBv8MMZiLxMMebhr5d7exxlsAM8vy/CJjpgidmOMAtJGdrAgkxDaJv44wduBd1yvxuU
 XtqWc2tEWwbGcxaIMmeHI8gPUsQ7nlmnwv7HMmjpzz+iOb2TCPFGN8tbQrVBshkvfzsnekg2
 4sGXyd8404EC7OWj+i+2dN7EG3m2lBnX82r8JIOKbbYSuekcUl4Y8LsLXoaU9UNt4xel/vS/
 2H7XUldyVHlgmbAJxnMYXdmAI4Dl74ixZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:mEIP8agc/3hLjQHCrbVOAd4MQXBQXtQji2hC6mlwRA09TyX4ra
 yTdZEgviMc5wx/ZJhNo7690cu7IU80hKQV3WB5B97LNmTbUQCTXeJfBOXZsljdMhy72ulB1b
 pxN4hSYeeAaWSSVPyKgjWFLw==
X-IronPort-AV: E=Sophos;i="5.87,282,1631592000"; 
   d="scan'208";a="59519128"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i3RxzlBFY/e8fvTVxyVf2mFJwSr6sReynhDmOe1wS7Jj5lbxHHHXDsWmkB5aCQydng79BIlWmrHzPiyhG6newSby0DCJAwB71EDY9bjP++h0QCsyJE6+3XOSF7SA+4AEwiyaDv/ZJRllDzANhrZOHwMvGq/KZnMJhpfA+w0x/SofObWke42GNvvQEsjuNGvdxsVNBpk9Vsn/4l9ykK4Vk1mJbV7Z3IdkqBVlOh8H+U7/LSWLAu/Elbi656Snz+JRmYKAwRfD55bePA+iMrUj8LttYgJe20934B4Z2O0ZUgaSpRFbyO22JctGU/NZWJOQWmNmz3AmkmdZeiVh7fiBXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=huTq0B8c+9emGBJtc4hecPo/BN72dZ43ec+/AEbYe2A=;
 b=A1dl3jh3oexz2u02kUBql3fUccVdtqOzCsWDVHejK09JHbflRWIbmVfT4rQrjJKwdLlIlsu3BM+NsxgttwWpJhCKP9jrZcANWsjOLNqe/pIkOIO5pKrJoJ6N4hHsZx99VbrjjqTDDhh2dvsiI7lQyuqEnedbhaIP+vUJ1HpsF01BuVyLIbY6ejrnOhf4PrO6tDeZagk7UyHIixPBp/QQt4YXZFEV+vZcSV2iXk3JeyWLGeZuR0LGmncW/hlzf7tI1Q19l7TxD4yyyLQfIjA2QiIuxNLW4R5ZCR/WG/toaCueKSBGt/Z3ynCnzzM2/b3fD8SjIrQPYaSfbDMDa3FyIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=huTq0B8c+9emGBJtc4hecPo/BN72dZ43ec+/AEbYe2A=;
 b=nAf9vtz8gfWpug2eMxeABFf9WNs66DPRtGtlQm4W/cktTQOJ5HBeazSgQ8XK8XfkDpB8Z1FvwCMmZDEQDEHCC+GrYsMFtb6cKMiino/E11KQ7GxdBWar2Aq+k1vR+O+CnzBB9/cmowYxfpaOeioKZ0GQruKyeBjdPdQPqLILhrA=
Date: Thu, 2 Dec 2021 17:03:56 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Message-ID: <YajubFeUclKtpqV2@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
X-ClientProxiedBy: PR3P195CA0009.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:102:b6::14) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 541d0817-d18c-41b6-58d6-08d9b5ad5b2e
X-MS-TrafficTypeDiagnostic: DM6PR03MB3945:
X-Microsoft-Antispam-PRVS: <DM6PR03MB39451551C232784A078C82728F699@DM6PR03MB3945.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UXSjmzVZ7/MllNMGNijXZNOnGA+dHMZb9nr43fq04UIrb3tlElHCLSENH0Im2kE4q5W/KOibUnTHi9eofngvjN4Xh1DGSbhC8FL5w1CnNkmUwFWostorRTYOqPlj/guIfR/HFFmAAUhhNsw6hbg/jBdWfevXwSpALH6SYWNW1/iKg6PRitwjveEgK5rr3nf1VsJmNfLlhVCN3mEaJtO9tHBouBBWHuzyW+1Vvy9S4nTAiAkrwsQHK6YSbgM9FCRhg39mtr1xMCLIoNHFhM4Mx4IQYHWqDaBfPz79RujUtLyUTQOwZbxc2MjZ6b9X3KYdxKWZS8833Kdu0X71FN8ceIDW5GTP3yTnP/zViTYyQylL0fY2SgLHUUSKu/z9h3PgwAymww/ICnWrenKkfvqmK7UIGV6h5FNP18mb8pG4OoB/x7hpYOJSTHoc+fva9lpFpk/t4kle/xPb7FRftozZERQe1XGz0wSOuBp1HAGT7jfvs+y985nwwT44xeokrDAGCN0LQ4P0t6k3HdtFn1JOB/g4kj98KtcR5tl+F9qzxY6SwZOSns1MT0fo3CjzTKsSyXBG7W4jVAK2c9ZTfFPeelOZ/7PLvVop06Oj1kHF02W5mNN3WgT1DSBK+CiDXFWUmOyxFBzFd5Q0hNvVxgzQyA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66556008)(85182001)(86362001)(6486002)(316002)(4326008)(38100700002)(66476007)(508600001)(186003)(54906003)(8936002)(33716001)(9686003)(82960400001)(66946007)(5660300002)(6496006)(83380400001)(2906002)(8676002)(6666004)(26005)(956004)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGVnY2Z1WVFSVXBrMThqb0w1bnd3RDRSc3lFU2NtNDZXRlc0MHpmTjZKM3h4?=
 =?utf-8?B?T2o4a1owSG5CKzlXdXhVNlpJNXNtSDBPNDRvNVBPbU43L1R4VnhMRGdaQkMx?=
 =?utf-8?B?eHE3MGtzTFdnNFJsZHVUS1hhVWtPMzZvdmduOW1NZWlPU3JEUzJrMFJCTHhI?=
 =?utf-8?B?WFZUdVJWQURVNjM0SlBrZ0N3cHZQTXBBd0N6WjQ5M2MweE5wQ2RabDk0c3VT?=
 =?utf-8?B?ODJBOVplMVF0Q2xURFZocnpNQ1lwbll1MmN0c3NqU2dYdEZTeDZESC9SeHFk?=
 =?utf-8?B?SGJKeUlPckRPZ3FyWGkxR09zWkxDeHp2VXdBcHp1eW1Pa2s0N0ViYndha001?=
 =?utf-8?B?Nkx1VThYak53UTI5NzBoL1E0L09pWXJ4N0RLS2N1S1NtOXR0M2hkaE45UmdK?=
 =?utf-8?B?SGF6WFJMOVJFQ3FpdjF3cWVNWk9kdStFUWJma1BBeFFHMVl4Y2JrYzdXWXU3?=
 =?utf-8?B?MldUb1Y4ajFGdlIva3V6NFFmcWdaRmJJQWphZlRpZkRweW92RURZTnc5cWpa?=
 =?utf-8?B?Vm9uYlJaY1lYYmNCQit5LzhpaEM1ZTMweDl4QzBQTDFEdG9OaFlTUCt4Vm1k?=
 =?utf-8?B?emhKTUhEVjdhVHlIYUV4RFpuNXhpdkNHbmxpQjNGQ0dEMnlIZEljSDFyVCtM?=
 =?utf-8?B?aHZpVzRpV1QzV1JMZGhsWU1seWtuVXhYdVVMSW9Pck91NDZlYnk5Q2FoSVJv?=
 =?utf-8?B?VHhtU2hqdWhuNFhZcld1R2hTRlRKRlB3UGl2Q1VOS25CTmpzRWh0azIzWVNS?=
 =?utf-8?B?amgvUThVVHdJZkcyK0NXMXpyS0JZaVRpZHNNUTA3SDNSWHFXZXVlQVlUUWpT?=
 =?utf-8?B?QVJyUEdDdzluWW5ZWHNLVnBYZXFLcCt0TDM4N3dreFJIQzZ4UTdQZjZzZ3d0?=
 =?utf-8?B?UlFtSTZJSHNyTjkvY1JaaUFZZEVMZmluMk5jVWJ0TGF6Z25JaG43QlQ4dXFX?=
 =?utf-8?B?TXZOV1FTczViRS9jbUZaOG95akdQUVRPZHY5TExnUDdFWXRNRWZtZm9qUHIx?=
 =?utf-8?B?ME80Tmt2eUhWODdxK0t3WUxEUEVLNXBvMU9QcnhyMXJSOGdZRzFveW0wTDZx?=
 =?utf-8?B?TUxzR1hOWWJRT3pWdTdsY05YaUVJNFhSQXJGZXBFeW93ZzhJUVBpaFNkZnk5?=
 =?utf-8?B?UUN5TWJFR25yTm9nalVlZWdHYTJhaXRHQmhxRnh3UU9QbDhMTUpYQ3VWZnAx?=
 =?utf-8?B?NUo3TG9SbnZ1NTFNY25HRWE4SXQ4Rm5xUkc1ZER1T1hvV2pycVpnSG9OMERh?=
 =?utf-8?B?VkFrQjRNQ3lpcHhod1FNRTJGMmNtaDdtdHVvb0hwK2p2R1ZmaTczUTQ0Ynhh?=
 =?utf-8?B?Rkp3bEMxZysrS1B3eXVXRmZZelUreEE3MlZDV1ZDWXBLV0c2ZUo0RnpqdWRk?=
 =?utf-8?B?QmJtdktLU09VWmMvc3VWZHozVnZKN1BibnpYMW9JQ083NHhlZEI5QVUySG9x?=
 =?utf-8?B?U0ZHUkdRRnk5WkZYakRCQjczTHhVbVBUUXNjYkl3WVZlYlV5MzN6T3NkUFFX?=
 =?utf-8?B?TjlYUkRIcWtZVEhUMWdyNStLRWFIQVFvbWRTeHFUNUlYT1dPck4wMHdxaWl5?=
 =?utf-8?B?SmNkSmxMeHlyL2FaTGQyK0l6NzROZzJVaU4yZWh5Q1lua0czVG8zUzhTblNO?=
 =?utf-8?B?b0QwN2ZQb0srSWcrMkUzTUFqRWRQMFNyT2ZHWnVYMWhOWGk1VFZEcGtSK015?=
 =?utf-8?B?ZGlRaEFoM3lvajBPN2pkZDIxcEo2dE1leHFwNU0xM1UzKzMwU1pnSktIZitF?=
 =?utf-8?B?NDFRZ1ZJcUpFYjNCWWlnQm9zNkNyZ0NzeE9jTEhTbW9TaktMZ1FGSjlPTkwy?=
 =?utf-8?B?WCszcGVEOHJTaml6Tlh2UktVL094Njh6MUJjR0RETVRsTEpuZFV4V1VIUXJQ?=
 =?utf-8?B?QTJUdUxUb1UvNG5teFFyNlBrTXhMR2hBTm9JRUQ2a2diRWZZclFEdFJPbzNK?=
 =?utf-8?B?SlR0b3RpcjgzRm9vU1NycXZjZFV5YzZ5cVlwZllKZnJvRXRZeHJhQmUybVdU?=
 =?utf-8?B?VFROZk51MnQyVE1kV2JPaVNlazBEUjEzMVI1MU9Oc2FCYkN4MGdCc0wwa1E0?=
 =?utf-8?B?cmEzZHl4Z0gxUlpORlp3OThBMlJMTC9rRzBFaTBsbk9UOFlITnUrR085OFJN?=
 =?utf-8?B?UHlHNUp6M2RNMjJMVU14dzFMUEVLT1ZpQTdQVjJnTU1yTTVubkFPUGZ0TzJ1?=
 =?utf-8?Q?0SKkSz1QHNV4yE+aNerwyHU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 541d0817-d18c-41b6-58d6-08d9b5ad5b2e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 16:04:01.5788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PmgHBMcEdn4gzOVvEpZIJjZYNwf2q8qWOHF0MuzUxshtbjX3iZnXS/uaZw4XCEuIAJJfxaGriEyOeN30YkUdeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3945
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
> For vendor specific code to support superpages we need to be able to
> deal with a superpage mapping replacing an intermediate page table (or
> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
> needed to free individual page tables while a domain is still alive.
> Since the freeing needs to be deferred until after a suitable IOTLB
> flush was performed, released page tables get queued for processing by a
> tasklet.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I was considering whether to use a softirq-taklet instead. This would
> have the benefit of avoiding extra scheduling operations, but come with
> the risk of the freeing happening prematurely because of a
> process_pending_softirqs() somewhere.

Another approach that comes to mind (maybe you already thought of it
and discarded) would be to perform the freeing after the flush in
iommu_iotlb_flush{_all} while keeping the per pPCU lists.

That would IMO seem better from a safety PoV, as we know that the
flush has been performed when the pages are freed, and would avoid the
switch to the idle domain in order to do the freeing.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 16:11:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 16:11:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236852.410784 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msofX-0007BY-Al; Thu, 02 Dec 2021 16:10:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236852.410784; Thu, 02 Dec 2021 16:10:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msofX-0007BR-7f; Thu, 02 Dec 2021 16:10:47 +0000
Received: by outflank-mailman (input) for mailman id 236852;
 Thu, 02 Dec 2021 16:10:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9SUj=QT=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1msofV-0007BL-Rz
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 16:10:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 666490bc-538a-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 17:10:43 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-tC3BLQFKO06QhcnL5BYcXQ-1; Thu, 02 Dec 2021 17:10:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Thu, 2 Dec
 2021 16:10:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021
 16:10:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Thu, 2 Dec 2021 16:10:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 666490bc-538a-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638461442;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8c5YhVWrZJkhqgJjPBvxyRaWM5FRo1K32n4gXLEIiWw=;
	b=Gk3IdzXSb0S6WvQBM5nAkXzC/JAw6BytAzHLJV0ioTNr4rrLEVUuPoghB+wbq7O9dh0g34
	S4SzYKuQumwbVdixIipN/WgPKaZ6mZf1TmVGnWtDlp08/b0HbdD8dSl7zVOLlwg3XwYZOR
	Ip5deqgype10xqmLMKl0WwYXeq3X1Q8=
X-MC-Unique: tC3BLQFKO06QhcnL5BYcXQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cugkEtFzLIsS2xlQ3u2mxuQbBa1SVkO3tk9nIfEC1kHvFRGr5AwwfAMS1Nb2sZRBzuW0wyVuaNrwOaLM4DuJkvcQ/VOsEMf0+vuDETft2tiHxglaxdAsrjTCLUM9FqsdYYUiljCGxq+wfzyqQGB1HYWBO6caRffYQsV81+v+J8YljMdZDienTsuGbsWeNYAa9o6BfVP8K2fuDHUO83NCn8mTq+4vGK990n168Dy5m13KC8Mk1QmAWg9Mh/NAXfU7XzZYhQLWRH0Tt5OEutQIvN342bFr5MMcZIk7+gzgt0L0dZYVOvfczeoIYMIbE1TawE1MmSvRYKnM42m2QCIv8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CBbOQsBJIUhlgJqrZ8zkLK4TCyNi7tLVk7+u/4X6KrM=;
 b=VLEPphuAOIrp+otMxTmQw1DGO2ZYYDIpstyXJ/s/negFEJQL1aOZ2F6MfzZe+XRWJOJkCu21vYPFFE1UuQXRhsC/jBDngL1mhc312DK9c5Npp1IYUkrkTpQNUYrJhQ4+QB2EvhSuigjFeurS+C/M6D4ytE4GToq9xpud85GMLCE8iwmUkvs00mjrU3zZJxXmmp+QuQkGxzvm2lICD876ChfnmbI6c/CbvfNQnqF4sQ/ALHYuqfSfAI3fmmtb/6rRrk1c8b08mn8xqOc2VYpGfyVJWvqB6xxiWJ3mKlfV2Fi2UNQuByhO6iaZjVraRKKqRdMTeHs5u8qn44sIzGMm9w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <03dbb062-002a-3770-61c4-4f93de73c0a0@suse.com>
Date: Thu, 2 Dec 2021 17:10:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
 <YajubFeUclKtpqV2@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YajubFeUclKtpqV2@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0021.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 79c65085-8199-428e-c63f-08d9b5ae4939
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630475BCE45AD3B3CC8C7AA3B3699@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cgGSTUGwSkQZy6jk18unwUynxZcm/NQgoOtyWS0ySFBu/8sSWrCibG7QSxEV5UfqLRF4ct/qpo347HJ2GofidBd2PgCwKtyJKG5lga9fyB4d3LsHzvs8ll+u1MmhRAJkLW8Ol/cV19x0ateMG9u9jnlr/UxDH0SMOSnXaa6I8JVEETJ2jiDUTK3lWmxSbKWKBLnT/8nmT56zlND4u8RzOL8w97I2xNQfD6aY/+YkDDBsiK7kHOgXloiho9+h4l+ngFs9bVByOn6ln8YNForGJxr5cikD/7W17wArmW9wHGhOWc+vYLRfKFbIJgkcTEEPw6g+LEedD3tJB2zAIFaeqrHxfcd0PTacd4MJVnAHHMdJJpKKj7zmryrZeYeVnuWZ9j28F7SDmkDDE17F6vFdCKNXuvz0Otn5bb8T6JcLUE8OAOAzr+mtVzC95DAryf7PcKbgIPqXvq+0jqmpUN8szR3fQF+qoFzr7TwsQyYxW7Lz6MvbGrVBOoYVhzTVzKMwnGxnxf5SINlorFQULRCwuxeM//8c2I7kX1giRNRyE3GaAt0PRo2wxqsVJgL2bLVPmhRa6XotB5azoKQYazoUhtcK68BckuL4uZNO3UHsCmEfr9pOFe8xDhXacMnVxoQHmJgpwM8Itjelgh+Schcs2r/zvJvV50DccTXd/P67R/GfzDsiK6XFY3TGzpEUSoxO7bSwV9gOpKEDUyr5Cnidm+o4t8tMkB4Y+BkMeXg2hw7rWdiqdhieJBKD7SwQBYWa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(5660300002)(31686004)(86362001)(83380400001)(4326008)(6916009)(508600001)(2906002)(53546011)(956004)(66476007)(66556008)(26005)(316002)(16576012)(8936002)(186003)(8676002)(66946007)(2616005)(38100700002)(54906003)(36756003)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ly9sFiqFX1ohySeNqtnwCMKnZY4Scts8snfJEtgrOjLPJHQXXmWg2WCIt+ub?=
 =?us-ascii?Q?Td8JzcM4ODVPzctxi+CGBg1229yTqa+Dl4mGmqlfBa6FxsncuLcGhoMq0pJg?=
 =?us-ascii?Q?KqAJbGSt4XP4/1lBDo9Acp4e64wNSmdqLuS7imoTBHUay7z2U11/FqkStFPs?=
 =?us-ascii?Q?lLKfrD5w4lvi+vCX4Isk1lBeC8qG7AKGdFzzLiXEUApUr9UvLStv29Wczd5k?=
 =?us-ascii?Q?EsFjwtXfeAxNfTxKJuALkyAY8brSkZLVdl6GIR2DMzlRIxU0jwcdRju3HwKy?=
 =?us-ascii?Q?ZgxDwfM++BlP8mHZu6PSGj2HJbV40csW21Y7dW4nYB2McjCxAd6nlaObIDwy?=
 =?us-ascii?Q?bZq3Du/maI4IokUuSfBA8TmiB8bNPcq0AYD96G06EIgmxOrvnFELd1wbjMq7?=
 =?us-ascii?Q?N6ytauy80F+keovnKMgG+8uVGhuR6C4aefWbniJSY8/0DIqhOvUac2+OfzZA?=
 =?us-ascii?Q?UDK+Ou3sA/NAno+HBxudHFIdph7P5FynzlJkmXLk8M1ooUuZqSkmlTr+onR5?=
 =?us-ascii?Q?QuYDuGwZGCF8aw/bskmc9W9jkcOoefTyt8v9hF9mUABrs81E1gdoN4lBV7Qv?=
 =?us-ascii?Q?zlzutq1EwmsmZZvoQ5ufbvb7bYatWeidWy26Bip1ZdZ35nfQllM65rNtw9c6?=
 =?us-ascii?Q?aNFfGEn4ragicZzw6rx/GZDKWgrMEdBpbnXo9GnL03mu1IDzfK4Pj/t0TdbC?=
 =?us-ascii?Q?ybVDVin4Hnc6Mr2JKmrO6lUeF1o+MfkaOkGrENZT9OjliYmQu9It3P3YasME?=
 =?us-ascii?Q?gkzHhhPgg0BpvQMqWKut4nmlpJo67r0ImQJU19S/duj7nqEk2CbbK9kTsMfd?=
 =?us-ascii?Q?40LVCjKlE9rEdcThUWJFcy1LW0tUf9gZ3YtbAuRyjlPpBDAO9gnytJqWxR+i?=
 =?us-ascii?Q?AgF6f6xMRRadyFVsys2HziWYu81hq8dAE0Jsl4npDi4n0oyCjxMZaBBHdeUg?=
 =?us-ascii?Q?zLNnL6KOCtmunikkQ+TEBCssB51Kk4dPNxrbNpSAIXEV7QIhDQVT8jf7CCOc?=
 =?us-ascii?Q?4wrqgxGMFjDLWbiEHv9P0VaPTnAiTrvrBK3T+ztGpCYAHSESzDYFM3AfOnHU?=
 =?us-ascii?Q?XHCD83FzM0M6U+9Ak2J9vI6vW6CmYacpIF3Why2modOp6lRI0PB/JkPNJkVD?=
 =?us-ascii?Q?g6Pm7rJEoEs6JUmJSGMewsiO3xrIXLLKQw8gkjTQoTkniQjxYrZixouf9t0K?=
 =?us-ascii?Q?Guhtn2go8FFPeGqre+hr0mZf3nUdZN6OTpupyxRwMe5fxcYnN7BvdiDXf15t?=
 =?us-ascii?Q?eNon5UGlScf8rx/I5u3raWk0iCljW5YWTx5cMxo0oZWIQtzTP2ZmZtlc9zmG?=
 =?us-ascii?Q?xmHEa2sirZE/l+zu0EHvaX9DPgBv02ed44tvENfXBSETwFDXAc/8CSiNbzZ3?=
 =?us-ascii?Q?bpkSXROkxvv4V3ZABxGX4oZkP0CLGqDUpxBm8VvUni7958UgdLlPbBQd8qvb?=
 =?us-ascii?Q?SacD2iDOFD/LWbgt1eWD0+ZACLzp2I+QjcHLWr9neCbzu+StNX96ZXuqIb9L?=
 =?us-ascii?Q?DNfxpQhL86FUFWWO22zj0feMTwsusTlabMZtA+pLrRmtwniXdut9BtvJnE93?=
 =?us-ascii?Q?o+zZHxQMsosNMu1Tg3aC0ir6E+Gq3ebLTJLBMkK3hBm2pKlzE/ThAaLmOBP5?=
 =?us-ascii?Q?f/STR7IlEEW3WtEsOeWa9SQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79c65085-8199-428e-c63f-08d9b5ae4939
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 16:10:40.8415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hq6wsku1oAvnYAYp/THiwLgf8Q0rQdBEeT6VTWTJSu/4R15JzzjCcQjT0dkZRC0pEBIf6vKKSdt9xUxBnDeE1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 02.12.2021 17:03, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
>> For vendor specific code to support superpages we need to be able to
>> deal with a superpage mapping replacing an intermediate page table (or
>> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
>> needed to free individual page tables while a domain is still alive.
>> Since the freeing needs to be deferred until after a suitable IOTLB
>> flush was performed, released page tables get queued for processing by a
>> tasklet.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I was considering whether to use a softirq-taklet instead. This would
>> have the benefit of avoiding extra scheduling operations, but come with
>> the risk of the freeing happening prematurely because of a
>> process_pending_softirqs() somewhere.
>=20
> Another approach that comes to mind (maybe you already thought of it
> and discarded) would be to perform the freeing after the flush in
> iommu_iotlb_flush{_all} while keeping the per pPCU lists.

This was my initial plan, but I couldn't convince myself that the first
flush to happen would be _the_ one associated with the to-be-freed
page tables. ISTR (vaguely though) actually having found an example to
the contrary.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 16:12:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 16:12:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236857.410794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msogv-0007l6-Lb; Thu, 02 Dec 2021 16:12:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236857.410794; Thu, 02 Dec 2021 16:12:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msogv-0007kz-I7; Thu, 02 Dec 2021 16:12:13 +0000
Received: by outflank-mailman (input) for mailman id 236857;
 Thu, 02 Dec 2021 16:12:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6Yg1=QT=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1msogt-0007k4-Vo
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 16:12:12 +0000
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com
 [2a00:1450:4864:20::52e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9af0fe3e-538a-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 17:12:11 +0100 (CET)
Received: by mail-ed1-x52e.google.com with SMTP id x15so240299edv.1
 for <xen-devel@lists.xenproject.org>; Thu, 02 Dec 2021 08:12:11 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id gb18sm153885ejc.95.2021.12.02.08.12.10
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 02 Dec 2021 08:12:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9af0fe3e-538a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=3MyZGX7qoTD+ENznO6UCo37cfrjvGh13dEVD2WZQHDs=;
        b=E7CyYRNZNPApU9xsepRNYJuS6EWKRJniDpZBHXQZtkFPHPHUdSjbSn7SaOuJw5kvgQ
         I7vpQ06V/cJ6VjSw2p7jPklqGKybLyPbo3NVMsROuLszH1dxbufvamgU7TD2rIPAU74o
         vJK35LFQiQzKHEIEmBw9AaN18BrZsVUhh+tPkeelg8PQ78Z3bOjvBLiS7iRz+3niX6LZ
         GeL5MY8CjUoBpLrYZucOhHozY9/juNx/9VX05UCg1DxFFZQv/dZP3w2hh3BBo4j29OAw
         fFOxI+2poVPgVQBURwyR44gQJQAO2jVYnsJNwnKWzfCjvgpaQ64zML99vcrUmDl4+Jbp
         F3Qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=3MyZGX7qoTD+ENznO6UCo37cfrjvGh13dEVD2WZQHDs=;
        b=zdpjYptnH5YMfbQ/2FdeTBnAiUJGIeKP1cbj9tZVKVhnF5/eNVb28auIfi50vPS4xX
         QkJEMMrDT45Upmdr1NRK8MtJm2xGKzzyq1qt/MkGhDWURgFE9xfB8mgVK2smVLNWJWfw
         jpvK46WJe0VuIOrFIXZjMmxVvv6pGoUu1yrAMgAQ5BtNmGo/t4Hl0aaoeZI81KRjs+/9
         sbAxy75PLCqQHrk3K7ZfhE36JOYzwCGBJZ8GZuOQqhLEizWYMv69HwsNvna1b01vordS
         g60OI1G5/nqvsve72I3q8Vf4NR62ZE9gHeYOGa/0jEkFS/B31kERGblqqM/u9KP6CRYJ
         xsSw==
X-Gm-Message-State: AOAM531h3SI90nK7riKW8hZ0CmzTCXmcxUCNfdTLBL3G9fqRCq1jaZxk
	QTboR8NqpdeL6Go6kdeup0c=
X-Google-Smtp-Source: ABdhPJzviC0vDr+1s5alzwkGx7hTKfRUWbJOBuQ6X5+WTtImCm37LXmt2372Q11vHdlghBfUWMxbUA==
X-Received: by 2002:a05:6402:d09:: with SMTP id eb9mr18491767edb.216.1638461530873;
        Thu, 02 Dec 2021 08:12:10 -0800 (PST)
Subject: Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from
 gnttab_map_frame()
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4f54456b-e8da-f67f-b6a0-b5ce2cf12cae@suse.com>
 <8b73ff7c-4dd6-ff2e-14b9-088fdce0beb9@suse.com>
 <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <ac66cfd1-264f-9a29-4b58-4add78daa1e9@gmail.com>
Date: Thu, 2 Dec 2021 18:12:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <b6eeab97-90ed-85f8-79ea-ac86e912dc43@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 02.12.21 11:09, Julien Grall wrote:

Hi Julien, Jan

> Hi Jan,
>
> On 13/09/2021 07:41, Jan Beulich wrote:
>> Without holding appropriate locks, attempting to remove a prior mapping
>> of the underlying page is pointless, as the same (or another) mapping
>> could be re-established by a parallel request on another vCPU. Move the
>> code to Arm's gnttab_set_frame_gfn(). Of course this new placement
>> doesn't improve things in any way as far as the security of grant status
>> frame mappings goes (see XSA-379). Proper locking would be needed here
>> to allow status frames to be mapped securely.
>>
>> In turn this then requires replacing the other use in
>> gnttab_unpopulate_status_frames(), which yet in turn requires adjusting
>> x86's gnttab_set_frame_gfn(). Note that with proper locking inside
>> guest_physmap_remove_page() combined with checking the GFN's mapping
>> there against the passed in MFN, there then is no issue with the
>> involved multiple gnttab_set_frame_gfn()-s potentially returning varying
>> values (due to a racing XENMAPSPACE_grant_table request).
>>
>> This, as a side effect, does away with gnttab_map_frame() having a local
>> variable "gfn" which shadows a function parameter of the same name.
>>
>> Together with XSA-379 this points out that XSA-255's addition to
>> gnttab_map_frame() was really useless.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> As discussed in the thread, I expect the Arm part to be simplified 
> after Oleksandr's series.


I assume, current patch is going to be committed soon(?), so I am in the 
process of preparing a rebased version of my patch as both touch Arm's 
gnttab_set_frame_gfn at least (I did a rebase sometime, but I lost these 
changes somehow).

Anyway, according to the recent suggestion how to eliminate the possible 
lock inversion introduced by my patch and taking into the account 
changes in current patch, the Arm's gnttab_set_frame_gfn, I think, needs 
to be updated to the following form:



#define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
({ \
         gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx);                  \
         (!gfn_eq(ogfn, INVALID_GFN) && !gfn_eq(ogfn, gfn))               \
          ? guest_physmap_remove_page((gt)->domain, ogfn, mfn, 0)         \
          : 0;                                                            \
     })


> So for the Arm part:
>
> Acked-by: Julien Grall <jgrall@amazon.com>
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 16:17:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 16:17:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236864.410805 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msolT-00007J-Cs; Thu, 02 Dec 2021 16:16:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236864.410805; Thu, 02 Dec 2021 16:16:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msolT-000079-9p; Thu, 02 Dec 2021 16:16:55 +0000
Received: by outflank-mailman (input) for mailman id 236864;
 Thu, 02 Dec 2021 16:16:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Tajg=QT=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1msolS-0008UP-8Z
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 16:16:54 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41329cad-538b-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 17:16:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41329cad-538b-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638461812;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Lfkq1/1xusSfUSpwfYXB4nguFCBn6M1AnFXzXSk5ps0=;
  b=UQQHp2MY1aRaOWhfqLrl2bTvOCefpMJM9ToFzQmBwXJuJsNM+8ic0Z9/
   TTKnh8xsiuqqIZNguKQ/ZAWIKLILwqp2Ow4iioCVOu4KloNeJqhj5ofzx
   9ZePupq+FZ2XPRLTxm7Dt0ffwEldNhGLk/oPcGAR07Uc/cb8o63mHqdgy
   o=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qcifXjHaluhFcdt884WUWdLGLkfzbnXhTTJWnVihUX5nAWtot68Ba89YSXsd6+YUNqi8IDgQWS
 BRrhrJxviiQ6DUvTcO6bVstXN0npW6v+Ga/qQKnRo8O1MbOxcytrIXJf3eSLgoOU5911MSTPQq
 jy6B9+FPGobDaa8d1ZupTPQif/xvVKIYNNTAfRfF6e9EEfEm3Iw/addVbvbD8pYpR3gVtncWdV
 FRFewyQa+I9HB8sNUGhvOxjnM7zaAPcPQ0RuyRfzO9DVjuK/fo5cTAWZCgHggt2S9t6zBZXZpp
 tzrDov3rrBhf+Wasu004jPDg
X-SBRS: 5.1
X-MesageID: 59125790
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1bYdparm1zLOwBlpi/2+V5k64HBeBmLBYhIvgKrLsJaIsI4StFCzt
 garIBmAPfnbZGDwf99ybYq+8U5S6pPXzNY1QAZopCozFCgV8puZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx24DjW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnb2BTz40L73NpL0QejdpLHFVHoxA84aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0fRKyDO
 JtBAdZpRDvvUhAIBlEFMo43nNX5j2PuWSBBpWvA8MLb5ECMlVcsgdABKuH9YtWXQe1Fk0Deo
 XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJxIusD9RCdy5aN7i+3N1dUZR1gbtcf4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud14WtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT0uTA3Dt4ade51q2VtW
 lBfwKByC8hUU/mweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehw5aZZfJWCzO
 RSO0e+02HO1FCDxBUOQS9jvY/nGMIC6TYi1PhwqRoUmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU
 ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or
 b6y9qKiln1ibQEJSnWNrNNIcwlVdSNT6FKfg5U/S9Nv6zFOQQkJI/TQ3akga8pimaFUnf3P5
 XazRglTz1+XuJENAV/ihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:OeOe3q0+q6ft2rWNuiHqGQqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.87,282,1631592000"; 
   d="scan'208";a="59125790"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jP3ao/d++cjipUc7GcpciZgGXDPhe9VHX2ceNdB221fbfVzkWj3FkXlf4+F/kJCihp1lT3U1xLmnuyx1zhaR5+y9RIWpuwTfaDtOvpAuZoUtBvZeniyGxqrmD7jKyeNnxazm9WpFSykTWEHiYEaHsLa0pBhwFQzUF1vAz5i3pCrEXv53Ac7tbOjsWspiIjn/2PKZSNoa2Ts06x0wvtgFQRf0CkO4NJPMrQbOPiReLPb+qtiyNgr/ctpnE/UX8xvr0vpIKwW8yqR20YVS3ICPz0xDbBzO2YsvsxSHWNI9EEoh3GTc1SaWoO7kcab1Xp+CT9YGyl6g1aWEa8LWP73YuA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=D9jAKJ34GuKPCwaNFSiIkIyFg3lHK6naQxXD7z+ohLg=;
 b=bBR/euSZXfa/ykYnzIco/H6vi+LW7hcI4QQPn8sDUDgbInBxs9nyEX+hAHeOjrWu3xyJgG2ZwbUZ9WKWW1bktDrUjX+vhixlxt06kx4/EJ7QPILVsTd70Ur2CfnvJtnQ9IAuFC+X1+PMzcMMkP3G0vuSUjLWXT26qPMRcZ5C3VVEpemLb0N2C1ijSpX8RgnOrvbEcInXg9Zrg4R+Grl+Uy0iEVG+pPiDiW5euZB9sgFvvKulRis/QiF+Cv/XD6gVv8mcL0FZtIAGwS/nKXCwDyQOo7VSJo3W64Hlc4MzMV/9k0k9T2m0Sbe/ttT9RkpfuFqpvBanPYTGwHf6QYvMyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=D9jAKJ34GuKPCwaNFSiIkIyFg3lHK6naQxXD7z+ohLg=;
 b=PXg62nlf+5rsXsmYLis467BPWTf7yBF6tsxvoDleANRHyQjlt7BrsUvXVQxYVhhoUagoCQHrv4L2lOpEAjh0zliPpXAUitrzwbJJHlRMZNzf/WpvFiWU21+Fbl0c1yWxgDruI+pR18LdkBK0AItCyOUwEd1QNqxAZ8Gq6qJZeMA=
Date: Thu, 2 Dec 2021 17:16:42 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 09/18] AMD/IOMMU: drop stray TLB flush
Message-ID: <Yajxapaf4lDovZap@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <6d825fc7-d600-6759-5bc2-ab8b17e4033b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6d825fc7-d600-6759-5bc2-ab8b17e4033b@suse.com>
X-ClientProxiedBy: MR2P264CA0051.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85a5bfc8-9488-4970-9f49-08d9b5af22d9
X-MS-TrafficTypeDiagnostic: DM5PR03MB3371:
X-Microsoft-Antispam-PRVS: <DM5PR03MB3371D9865F186AB1999A6E828F699@DM5PR03MB3371.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1728;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: s7UATECTRCJ2urlYcYAOrAQ0t/h4Tlxqa3RrWJ6g85uyJ+5B5eY83OlmX3IGT+3JT/zpMPJUBcq7ODmL9sgG2XXIrwnMrtrClWbmceZ+cg1bdwSplOTiLtiaovqy5LYB9mKzTiahCN2ItwrTd3hQ+IEUuBKcG1P9jmMYyZujo75I+/poFkyX7ZIpzvHImRavb4BrKH/5lQlVduG1Ssk282fPHGPOEFbK6sPSvMG63cq+Nfli79xhqZV7hU1JC2PIF7H2fTt7o1zQuGz6RmA1RYAy1qoiQBb6Lm6g5r99ydszy287K9ZozfZ8Ja0gu32lyEmaSvTK38zYWfT3r0ICvD2woPsTHoqul32VujwB2IvLxbpMGnYQOdaXr+meDtnXsRlDycTOPFApIyNJjbgcf/p0UNnPzmLPwgivL8jTkS1LlXtOmzvBiyUJmHH8yTiSHFEuEplQIfUnAzezygia8Z5yp1sBmkqQZtzQ2c/UEsLM0M624YmrMs3wU4uJTb77noAKvLDM0xheR4dK6QGKXVE43umHNDFAKagn4MVqolZq+iRSnZ/Zg7v6kYF5OhqyRxzUtQLF6U2+pTrxJZEUIHw6Rjr9ZBqJOH/rZqcGb34hgJq2JWdD3t6iqNTWBEh0hyhmo/iwMXzNFiHA7w1icw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6496006)(956004)(82960400001)(508600001)(316002)(33716001)(9686003)(66556008)(38100700002)(5660300002)(2906002)(54906003)(186003)(4744005)(85182001)(6666004)(26005)(6486002)(8936002)(66476007)(6916009)(66946007)(8676002)(4326008)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2p4clpHUjVMbzRheVBMUkQ3YVY3T0R4dXNJVHZNUU9NOW45cnFPOFlJVnB1?=
 =?utf-8?B?eE84VTZhcGpUNDNhTE56c2dETUExRkpJRTViQy9KZjZ1MGczV3ZiSm1sNHg0?=
 =?utf-8?B?RDZqbkNVTGkzdXNkYTBuZWc1U0JaVWtrQlNCdXVCbHZrVTJPdXlJOE4wTzhk?=
 =?utf-8?B?S01Rc1kyU3ZySnNQQU9BVnR3aU54d3VHSVlYd3BKTXVFMDh4VmM0c2ZzVkQz?=
 =?utf-8?B?K1QxdTlEZnRYbHRmaDBRWlpvOHh2aGtucVhHa2FCdkJWbG4wRnZFUDJLOFRG?=
 =?utf-8?B?YmV2cWY4QlVZNms0N1VidTRNT1J0NU9QUDBhV1ZlTVhhbDdzbEk2Yi84Rnhz?=
 =?utf-8?B?THJPM2RVemJjcmFsYUxpRWZQNktZY2RLU28xeHBMR0c3MWZYa082MjNJM2Ir?=
 =?utf-8?B?SzNiNmRrZjhTb1dqNVNZUTg1NGlteVNXdWFZNlEwZGF5UitzUDVjcnd0eTdV?=
 =?utf-8?B?NTl5SDJCY00xZVVGRG00c002dWl0WTJOODUvN2pFMmlKdW5TQkJZVy9vVmlT?=
 =?utf-8?B?UklCSWhteUNoZVRocTFZaTI4ZXdwRnF6bG5GNVF5ZHpxNnE1RzlXdE85eng1?=
 =?utf-8?B?VEJ4MktMNVA5cUY4T0lmMWxCY0Q3dzhjMEtwOTN2MzRjd1NaT3BocTFMNm02?=
 =?utf-8?B?eWVkb2NNOUg1cFVhNDJGVktiR2pEV2dOUWdOVDJuaDNIMCtVdndibUNjZmJh?=
 =?utf-8?B?M09hd3ByRGFmUHk3ZTIzbTN0YlVRVGRDc3B1Mjk3RklPSEFqWmtZem5BWGFw?=
 =?utf-8?B?bmNmazFTb2FFRWpEUkZINVVJQmpJU0RZQXM2NWJxL3UvM2tIN2hEZFhhaisy?=
 =?utf-8?B?VXlRaVpOVmpCU0xkajNnK3hsK2pHSjBTQXFHazdtK2wvRjFyVzkydnhxMWFm?=
 =?utf-8?B?YUR5OE03OElXeTcwdkd2WHJkUkhrYXpEWVNCM0xIZlloT2pFVVFZNmdaMlRI?=
 =?utf-8?B?ZzAxMDdyMTMvVlFEemkzcE0wTFQzOGoySU9Pc0lobmhHeFlqUHlkQUQvV2ps?=
 =?utf-8?B?Z3ZKQk5NRjNrYWRYejMwbi9GQ291OUFSQW1HTU1MOUFGVWdPL2Y4a1NWcHlm?=
 =?utf-8?B?Ukl0S0grMzJiZkFUb0hzRjc2am0zZUVWT2Jna2xmTkMzT0ZHT3RhSjM2TkxG?=
 =?utf-8?B?SUdvY3JnZ2hmaDZ6YjR5NUwwRFo2YmVSU01VNWpvWXlhNE9qcCtUUlB3N3R4?=
 =?utf-8?B?THVDTlBVUHdyblJPcW5GLzhXTWlMaktyZEZTcnI4MEc4anJKOXJ3eHZDTXlP?=
 =?utf-8?B?d0d4cUtvYXFVajB2cmJqazU1cFNyVHBWejlrNTVPTWtiQzFEOTgrMGpRd2ht?=
 =?utf-8?B?eEczUjNWaEdUdnVUaVhBVUpCQXc3RHllZ0ZjWUlkcXYyQ3VYYmpQLzdSYUhQ?=
 =?utf-8?B?OUpDYkJaZjZ6eW1LaG1mK1pVMGszenBack9qaE5yRkFYU3Y0dkRxVVdXNys5?=
 =?utf-8?B?bytHaGtaVVIwQndybXpSTmk2TmlXNGhCZ28wS0lML3FCbktqZFlRZE1pem5Y?=
 =?utf-8?B?UkZpWVd4aHpZZXQyMDVNc1lvd01wNjBaTTcrazNka2w5RGtDR05leEowOXFR?=
 =?utf-8?B?RW14RTU1dnRFd3ZheHhlWkRUWUs0SThaN2pzWFZuYjhLK0FuWklZUm9PSjly?=
 =?utf-8?B?eVdXYWczb1NaTEpzRmoxUFlvcW5MQVNkQ1RYVGF4b21sc2FpUlBSUXVOZ1gz?=
 =?utf-8?B?TnBqeEpIdDlKNUNQZTF3QWZWL3pLeHkzOFJnalBlSkt3WkZ3cUZwUks0YUFs?=
 =?utf-8?B?TEhjeE9XSytXNjhUUnBnTDF3eGl5YzY3cUd4NFBrZkdNU3htRjhjd1F5bHpX?=
 =?utf-8?B?dHpIWGhSa0kzOERHbFhRTGZ2bzQrdHlMS3o4VjZ5djNyaUV5YnQ3Ukt4d1dO?=
 =?utf-8?B?cndpUHlyQzFDOWFRa1gyLzlnRnZZRS9aU3ZSemVzMjNraGRtMzBQNVBrK0hw?=
 =?utf-8?B?RWZoU3NHZWhCOGRGSjZwejNzWDVzTlgvQmhRRXgzVmhjSmZ0L2xxMldlZEZH?=
 =?utf-8?B?Z1RCQVZRdFNqcjYvb3dVVWl6TC8vYXpvREdpUWc5R3RSRUVITnhwWkZJWVhR?=
 =?utf-8?B?TldteC9COTIxYzFzWkYzVUI2Z0ZFd1pURmc1anp5WXZQOU1rdjEydzZzcWlI?=
 =?utf-8?B?bkRQUzI3aGpKR09NVG12N3RqSE9QSU5PbGVUSnMwYm9tMUlpTDNGZWVUakta?=
 =?utf-8?Q?+CL6zMo/EBt/lp7mkRvfMDw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85a5bfc8-9488-4970-9f49-08d9b5af22d9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 16:16:45.9491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QFs7nnNHbt3OwaxoaQO42EeZbkWklTIeEXSG7Zd5Y53nx+FYpB4JiEUKdyBigqDzyF4LvDUY4V0vzWOyDNBSkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3371
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:48:57AM +0200, Jan Beulich wrote:
> I think this flush was overlooked when flushing was moved out of the
> core (un)mapping functions. The flush the caller is required to invoke
> anyway will satisfy the needs resulting from the splitting of a
> superpage.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 16:45:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 16:45:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236876.410826 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mspCs-0003rB-Po; Thu, 02 Dec 2021 16:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236876.410826; Thu, 02 Dec 2021 16:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mspCs-0003r4-MT; Thu, 02 Dec 2021 16:45:14 +0000
Received: by outflank-mailman (input) for mailman id 236876;
 Thu, 02 Dec 2021 16:45:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mspCr-0003qu-Cx; Thu, 02 Dec 2021 16:45:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mspCr-0005Zg-5P; Thu, 02 Dec 2021 16:45:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mspCq-0007ks-QS; Thu, 02 Dec 2021 16:45:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mspCq-0005pI-Pz; Thu, 02 Dec 2021 16:45:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=rlrh8dMt+ktu73hNz4tAQAp9rk4VE+cN+xuywhDBxZE=; b=XgODj4zauJG0BtlzUApfsZfa2S
	Iz9GQURXC4wH60SmwgIWOn28WvPh/PKPWVum66BZeAqjqhIl25vV0leHcErJ+5RE5/KCVYVidS7Cg
	Bn7vyJKW1qG0v/8LujFbjRXpREYrYmpmjNB/ZKc1lY7J7PIoBY2f3c5M9orY2Fs25K4w=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166997-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 166997: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=b21b4b56f9313eabe63d598016ee8ba90d7734b6
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 16:45:12 +0000

flight 166997 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166997/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              b21b4b56f9313eabe63d598016ee8ba90d7734b6
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  510 days
Failing since        151818  2020-07-11 04:18:52 Z  509 days  492 attempts
Testing same since   166997  2021-12-02 04:25:31 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 86173 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 18:12:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 18:12:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236899.410852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msqZ0-0005iN-2X; Thu, 02 Dec 2021 18:12:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236899.410852; Thu, 02 Dec 2021 18:12:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msqYz-0005iG-VA; Thu, 02 Dec 2021 18:12:09 +0000
Received: by outflank-mailman (input) for mailman id 236899;
 Thu, 02 Dec 2021 18:12:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wP8P=QT=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1msqYy-0005iA-7V
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 18:12:08 +0000
Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr
 [80.12.242.130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5bc97fa6-539b-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 19:12:07 +0100 (CET)
Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id sqYum8DwlHQrlsqYumWmIy; Thu, 02 Dec 2021 19:12:06 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5bc97fa6-539b-11ec-976b-d102b41d0961
X-ME-Helo: [192.168.1.18]
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Thu, 02 Dec 2021 19:12:06 +0100
X-ME-IP: 86.243.171.122
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
To: Juergen Gross <jgross@suse.com>, boris.ostrovsky@oracle.com,
 sstabellini@kernel.org, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
Date: Thu, 2 Dec 2021 19:12:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit

Le 02/12/2021 à 07:12, Juergen Gross a écrit :
> On 01.12.21 22:10, Christophe JAILLET wrote:
>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid 
>> some
>> open-coded arithmetic in allocator arguments.
>>
>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>> consistency.
>>
>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>>   drivers/block/xen-blkfront.c | 8 +++-----
>>   1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index 700c765a759a..fe4d69cf9469 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int 
>> minor, unsigned int nr)
>>       if (end > nr_minors) {
>>           unsigned long *bitmap, *old;
>> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
>> -                 GFP_KERNEL);
>> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>>           if (bitmap == NULL)
>>               return -ENOMEM;
>>           spin_lock(&minor_lock);
>>           if (end > nr_minors) {
>>               old = minors;
>> -            memcpy(bitmap, minors,
>> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
>> +            bitmap_copy(bitmap, minors, nr_minors);
>>               minors = bitmap;
>>               nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
>>           } else
> 
> Shouldn't you use bitmap_free(old) some lines down?

Obvious.
I'll send a V2, Thx for the review.

CJ

> 
>> @@ -2610,7 +2608,7 @@ static void __exit xlblk_exit(void)
>>       xenbus_unregister_driver(&blkfront_driver);
>>       unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
>> -    kfree(minors);
>> +    bitmap_free(minors);
>>   }
>>   module_exit(xlblk_exit);
> 
> 
> Juergen
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 18:16:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 18:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236906.410862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msqdC-0006Qd-NS; Thu, 02 Dec 2021 18:16:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236906.410862; Thu, 02 Dec 2021 18:16:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msqdC-0006QW-KI; Thu, 02 Dec 2021 18:16:30 +0000
Received: by outflank-mailman (input) for mailman id 236906;
 Thu, 02 Dec 2021 18:16:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XjF0=QT=perches.com=joe@srs-se1.protection.inumbo.net>)
 id 1msqdC-0006QQ-7b
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 18:16:30 +0000
Received: from smtprelay.hostedemail.com (smtprelay0236.hostedemail.com
 [216.40.44.236]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6e69d4f-539b-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 19:16:28 +0100 (CET)
Received: from omf05.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
 by smtprelay07.hostedemail.com (Postfix) with ESMTP id 4E9A918484CB8;
 Thu,  2 Dec 2021 18:16:26 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by
 omf05.hostedemail.com (Postfix) with ESMTPA id A265920016; 
 Thu,  2 Dec 2021 18:16:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6e69d4f-539b-11ec-976b-d102b41d0961
Message-ID: <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Juergen Gross
	 <jgross@suse.com>, boris.ostrovsky@oracle.com, sstabellini@kernel.org, 
	roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Date: Thu, 02 Dec 2021 10:16:23 -0800
In-Reply-To: <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
References: 
	<1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
	 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
	 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.77
X-Stat-Signature: 561o3yrhzhgof883pt4t3mmwux5dja7y
X-Rspamd-Server: rspamout03
X-Rspamd-Queue-Id: A265920016
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX18JTU2ijvwIy/Ds0rg5WhKwO4BPDfU4ABw=
X-HE-Tag: 1638468984-745583

On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
> Le 02/12/2021 � 07:12, Juergen Gross a �crit�:
> > On 01.12.21 22:10, Christophe JAILLET wrote:
> > > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid 
> > > some open-coded arithmetic in allocator arguments.
> > > 
> > > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > > consistency.
> > > 
> > > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
[]
> > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
[]
> > > @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int 
> > > minor, unsigned int nr)
> > > ����� if (end > nr_minors) {
> > > ��������� unsigned long *bitmap, *old;
> > > -������� bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> > > -���������������� GFP_KERNEL);
> > > +������� bitmap = bitmap_zalloc(end, GFP_KERNEL);
> > > ��������� if (bitmap == NULL)
> > > ������������� return -ENOMEM;
> > > ��������� spin_lock(&minor_lock);
> > > ��������� if (end > nr_minors) {
> > > ������������� old = minors;
> > > -����������� memcpy(bitmap, minors,
> > > -������������������ BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
> > > +����������� bitmap_copy(bitmap, minors, nr_minors);
> > > ������������� minors = bitmap;
> > > ������������� nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;

		nr_minors = end;
?




From xen-devel-bounces@lists.xenproject.org Thu Dec 02 18:50:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 18:50:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236916.410880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msr9n-0002pa-FT; Thu, 02 Dec 2021 18:50:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236916.410880; Thu, 02 Dec 2021 18:50:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msr9n-0002pT-Be; Thu, 02 Dec 2021 18:50:11 +0000
Received: by outflank-mailman (input) for mailman id 236916;
 Thu, 02 Dec 2021 18:50:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msr9m-0002pJ-7U; Thu, 02 Dec 2021 18:50:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msr9l-0007iJ-VI; Thu, 02 Dec 2021 18:50:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msr9l-0007ae-Jl; Thu, 02 Dec 2021 18:50:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msr9l-0007BG-JD; Thu, 02 Dec 2021 18:50:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ziYHyk/fOY4uVk6AEkiQ8mU5RDe3wFerqFAAWQjHki0=; b=lgVdQapeT+lYQQhxHJaezngVJo
	KLBWe+24ESXZ8sIfkJLStv7p1dGpxzrosrvVzF9Q+4abgPh3eNPi0hbivE6Ng/T/uve2ghP7lYhcN
	sUJM4783yIutGYOENXQmzw6SvbG5lzNrfirHacGTO4Qzjvr42qyJCEH+J58Isp3twqoQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167020-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167020: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb41074692094dff1413efb44fa4928a9140aa41
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 18:50:09 +0000

flight 167020 xen-unstable-smoke real [real]
flight 167031 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167020/
http://logs.test-lab.xenproject.org/osstest/logs/167031/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb41074692094dff1413efb44fa4928a9140aa41
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    2 days
Failing since        166977  2021-12-01 17:08:21 Z    1 days    5 attempts
Testing same since   166988  2021-12-01 23:02:57 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 19:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 19:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236924.410896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrQR-0004qg-08; Thu, 02 Dec 2021 19:07:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236924.410896; Thu, 02 Dec 2021 19:07:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrQQ-0004qZ-TS; Thu, 02 Dec 2021 19:07:22 +0000
Received: by outflank-mailman (input) for mailman id 236924;
 Thu, 02 Dec 2021 19:07:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wP8P=QT=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1msrQP-0004qA-Ms
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 19:07:21 +0000
Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr
 [80.12.242.130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12ab2c43-53a3-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 20:07:20 +0100 (CET)
Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id srQMm8a6iHQrlsrQMmWszZ; Thu, 02 Dec 2021 20:07:19 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12ab2c43-53a3-11ec-976b-d102b41d0961
X-ME-Helo: [192.168.1.18]
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Thu, 02 Dec 2021 20:07:19 +0100
X-ME-IP: 86.243.171.122
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
To: Joe Perches <joe@perches.com>, Juergen Gross <jgross@suse.com>,
 boris.ostrovsky@oracle.com, sstabellini@kernel.org, roger.pau@citrix.com,
 axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
Date: Thu, 2 Dec 2021 20:07:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Le 02/12/2021 à 19:16, Joe Perches a écrit :
> On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
>> Le 02/12/2021 à 07:12, Juergen Gross a écrit :
>>> On 01.12.21 22:10, Christophe JAILLET wrote:
>>>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
>>>> some open-coded arithmetic in allocator arguments.
>>>>
>>>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>>>> consistency.
>>>>
>>>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> []
>>>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> []
>>>> @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int
>>>> minor, unsigned int nr)
>>>>        if (end > nr_minors) {
>>>>            unsigned long *bitmap, *old;
>>>> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
>>>> -                 GFP_KERNEL);
>>>> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>>>>            if (bitmap == NULL)
>>>>                return -ENOMEM;
>>>>            spin_lock(&minor_lock);
>>>>            if (end > nr_minors) {
>>>>                old = minors;
>>>> -            memcpy(bitmap, minors,
>>>> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
>>>> +            bitmap_copy(bitmap, minors, nr_minors);
>>>>                minors = bitmap;
>>>>                nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
> 
> 		nr_minors = end;
> ?
> 

No,
My understanding of the code is that if we lack space (end > nr_minors), 
we need to allocate more. In such a case, we want to keep track of what 
we have allocated, not what we needed.
The "padding" bits in the "long align" allocation, can be used later.

first call
----------
end = 65
nr_minors = 63

--> we need some space
--> we allocate 2 longs = 128 bits
--> we now use 65 bits of these 128 bits

new call
--------
end = 68
nr_minors = 128 (from previous call)
--> no need to reallocate

CJ


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 19:10:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 19:10:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236930.410908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrT0-0005az-Fn; Thu, 02 Dec 2021 19:10:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236930.410908; Thu, 02 Dec 2021 19:10:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrT0-0005aS-Ah; Thu, 02 Dec 2021 19:10:02 +0000
Received: by outflank-mailman (input) for mailman id 236930;
 Thu, 02 Dec 2021 19:10:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TWG+=QT=xen.org=tim@srs-se1.protection.inumbo.net>)
 id 1msrSy-0005Su-Go
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 19:10:00 +0000
Received: from deinos.phlegethon.org (deinos.phlegethon.org
 [2001:41d0:8:b1d7::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 700baff8-53a3-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 20:09:59 +0100 (CET)
Received: from tjd by deinos.phlegethon.org with local (Exim 4.94.2 (FreeBSD))
 (envelope-from <tim@xen.org>)
 id 1msrSt-000BWE-5V; Thu, 02 Dec 2021 19:09:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 700baff8-53a3-11ec-b1df-f38ee3fbfdf7
Date: Thu, 2 Dec 2021 19:09:55 +0000
From: Tim Deegan <tim@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty()
 invocation
Message-ID: <YakaA1A2ndfb3LtN@deinos.phlegethon.org>
References: <69b75eb5-82fe-e075-146a-28a9758da433@suse.com>
 <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <3bb2018b-8e28-6469-6b6c-c6de935bf669@suse.com>
X-SA-Known-Good: Yes
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tim@xen.org
X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false

At 11:35 +0100 on 01 Dec (1638358515), Jan Beulich wrote:
> paging_mfn_is_dirty() is moderately expensive, so avoid its use unless
> its result might actually change anything. This means moving the
> surrounding if() down below all other checks that can result in clearing
> _PAGE_RW from sflags, in order to then check whether _PAGE_RW is
> actually still set there before calling the function.
> 
> While moving the block of code, fold two if()s and make a few style
> adjustments.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Tim Deegan <tim@xen.org>

> ---
> TBD: Perhaps the dirty-VRAM piece also wants moving down a little, such
>      that all three "level == 1" conditionals can be folded?

I have no strong feelings on that either way.

Cheers,

Tim.


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 19:10:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 19:10:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236934.410922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrTQ-0006ks-P8; Thu, 02 Dec 2021 19:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236934.410922; Thu, 02 Dec 2021 19:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrTQ-0006kl-Lf; Thu, 02 Dec 2021 19:10:28 +0000
Received: by outflank-mailman (input) for mailman id 236934;
 Thu, 02 Dec 2021 19:10:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=TWG+=QT=xen.org=tim@srs-se1.protection.inumbo.net>)
 id 1msrTP-0005Su-R5
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 19:10:27 +0000
Received: from deinos.phlegethon.org (deinos.phlegethon.org
 [2001:41d0:8:b1d7::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8232273a-53a3-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 20:10:27 +0100 (CET)
Received: from tjd by deinos.phlegethon.org with local (Exim 4.94.2 (FreeBSD))
 (envelope-from <tim@xen.org>)
 id 1msrTM-000BWi-OW; Thu, 02 Dec 2021 19:10:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8232273a-53a3-11ec-b1df-f38ee3fbfdf7
Date: Thu, 2 Dec 2021 19:10:24 +0000
From: Tim Deegan <tim@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH 1/2] x86/mm: don't open-code p2m_is_pod()
Message-ID: <YakaIHomlrAsPXNG@deinos.phlegethon.org>
References: <ac46f25b-e669-f309-b36e-c4760e10479e@suse.com>
 <a1110809-b4fb-c53e-5f46-dc7628165634@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <a1110809-b4fb-c53e-5f46-dc7628165634@suse.com>
X-SA-Known-Good: Yes
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: tim@xen.org
X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false

At 12:01 +0100 on 01 Dec (1638360084), Jan Beulich wrote:
> Replace all comparisons against p2m_populate_on_demand (outside of
> switch() statements) with the designated predicate.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Tim Deegan <tim@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 19:17:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 19:17:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236943.410932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrZh-0007WM-FB; Thu, 02 Dec 2021 19:16:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236943.410932; Thu, 02 Dec 2021 19:16:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msrZh-0007WF-Bx; Thu, 02 Dec 2021 19:16:57 +0000
Received: by outflank-mailman (input) for mailman id 236943;
 Thu, 02 Dec 2021 19:16:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=vx2B=QT=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1msrZg-0007W9-7e
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 19:16:56 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 68c888ec-53a4-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 20:16:54 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35002)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1msrZd-000IdJ-8e (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 02 Dec 2021 19:16:53 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 77F811FC68;
 Thu,  2 Dec 2021 19:16:53 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68c888ec-53a4-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <09a1961b-2647-f25e-f028-9e398fa2c83e@srcf.net>
Date: Thu, 2 Dec 2021 19:16:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
 <YadPLZqfN2pu5SeG@Air-de-Roger>
 <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
 <YajiQeaPx7KcL0Tw@Air-de-Roger>
 <49991d39-f976-af50-b203-152564fa458e@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
In-Reply-To: <49991d39-f976-af50-b203-152564fa458e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 02/12/2021 15:28, Jan Beulich wrote:
> On 02.12.2021 16:12, Roger Pau Monné wrote:
>> On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote:
>>> On 01.12.2021 11:32, Roger Pau Monné wrote:
>>>> On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
>>>>> On 01.12.2021 10:09, Roger Pau Monné wrote:
>>>>>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
>>>>>>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>>>>>>>       * that fall in unusable ranges for PV Dom0.
>>>>>>>       */
>>>>>>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) )
>>>>>>> -        return false;
>>>>>>> +        return 0;
>>>>>>>  
>>>>>>>      switch ( type = page_get_ram_type(mfn) )
>>>>>>>      {
>>>>>>>      case RAM_TYPE_UNUSABLE:
>>>>>>> -        return false;
>>>>>>> +        return 0;
>>>>>>>  
>>>>>>>      case RAM_TYPE_CONVENTIONAL:
>>>>>>>          if ( iommu_hwdom_strict )
>>>>>>> -            return false;
>>>>>>> +            return 0;
>>>>>>>          break;
>>>>>>>  
>>>>>>>      default:
>>>>>>>          if ( type & RAM_TYPE_RESERVED )
>>>>>>>          {
>>>>>>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved )
>>>>>>> -                return false;
>>>>>>> +                perms = 0;
>>>>>>>          }
>>>>>>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || pfn > max_pfn )
>>>>>>> -            return false;
>>>>>>> +        else if ( is_hvm_domain(d) )
>>>>>>> +            return 0;
>>>>>>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
>>>>>>> +            perms = 0;
>>>>>> I'm confused about the reason to set perms = 0 instead of just
>>>>>> returning here. AFAICT perms won't be set to any other value below,
>>>>>> so you might as well just return 0.
>>>>> This is so that ...
>>>>>
>>>>>>>      }
>>>>>>>  
>>>>>>>      /* Check that it doesn't overlap with the Interrupt Address Range. */
>>>>>>>      if ( pfn >= 0xfee00 && pfn <= 0xfeeff )
>>>>>>> -        return false;
>>>>>>> +        return 0;
>>>>>>>      /* ... or the IO-APIC */
>>>>>>> -    for ( i = 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics; i++ )
>>>>>>> -        if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
>>>>>>> -            return false;
>>>>>>> +    if ( has_vioapic(d) )
>>>>>>> +    {
>>>>>>> +        for ( i = 0; i < d->arch.hvm.nr_vioapics; i++ )
>>>>>>> +            if ( pfn == PFN_DOWN(domain_vioapic(d, i)->base_address) )
>>>>>>> +                return 0;
>>>>>>> +    }
>>>>>>> +    else if ( is_pv_domain(d) )
>>>>>>> +    {
>>>>>>> +        /*
>>>>>>> +         * Be consistent with CPU mappings: Dom0 is permitted to establish r/o
>>>>>>> +         * ones there, so it should also have such established for IOMMUs.
>>>>>>> +         */
>>>>>>> +        for ( i = 0; i < nr_ioapics; i++ )
>>>>>>> +            if ( pfn == PFN_DOWN(mp_ioapics[i].mpc_apicaddr) )
>>>>>>> +                return rangeset_contains_singleton(mmio_ro_ranges, pfn)
>>>>>>> +                       ? IOMMUF_readable : 0;
>>>>>>> +    }
>>>>> ... this return, as per the comment, takes precedence over returning
>>>>> zero.
>>>> I see. This is because you want to map those in the IOMMU page tables
>>>> even if the IO-APIC ranges are outside of a reserved region.
>>>>
>>>> I have to admit this is kind of weird, because the purpose of this
>>>> function is to add mappings for all memory below 4G, and/or for all
>>>> reserved regions.
>>> Well, that was what it started out as. The purpose here is to be consistent
>>> about IO-APICs: Either have them all mapped, or none of them. Since we map
>>> them in the CPU page tables and since Andrew asked for the two mappings to
>>> be consistent, this is the only way to satisfy the requests. Personally I'd
>>> be okay with not mapping IO-APICs here (but then regardless of whether they
>>> are covered by a reserved region).
>> I'm unsure of the best way to deal with this, it seems like both
>> the CPU and the IOMMU page tables would never be equal for PV dom0,
>> because we have no intention to map the MSI-X tables in RO mode in the
>> IOMMU page tables.
>>
>> I'm not really opposed to having the IO-APIC mapped RO in the IOMMU
>> page tables, but I also don't see much benefit of doing it unless we
>> have a user-case for it. The IO-APIC handling in PV is already
>> different from native, so I would be fine if we add a comment noting
>> that while the IO-APIC is mappable to the CPU page tables as RO it's
>> not present in the IOMMU page tables (and then adjust hwdom_iommu_map
>> to prevent it's mapping).
> Andrew, you did request both mappings to get in sync - thoughts?

Lets step back to first principles.

On real hardware, there is no such thing as read-only-ness of the
physical address space.  Anything like that is a device which accepts
and discards writes.

It's not clear what a real hardware platform would do in this scenario,
but from reading some of the platform docs, I suspect the System Address
Decoder would provide a symmetric view of the hardware address space,
but this doesn't mean that UBOX would tolerate memory accesses uniformly
from all sources.  Also, there's nothing to say that all platforms
behave the same.


For HVM with shared-pt, the CPU and IOMMU mappings really are
identical.  The IOMMU really will get a read-only mapping of real MMCFG,
and holes for fully-emulated devices, which would suffer a IOMMU fault
if targetted.

For HVM without shared-pt, the translations are mostly kept in sync, but
the permissions in the CPU mappings may be reduced for e.g. logdirty
reasons.

For PV guests, things are mostly like the HVM shared-pt case, except
we've got the real IO-APICs mapped read-only, and no fully-emulated devices.


Putting the real IO-APICs in the IOMMU is about as short sighted as
letting the PV guest see them to begin with, but there is nothing
fundamentally wrong with letting a PV guest do a DMA read of the
IO-APIC, seeing as we let it do a CPU read.  (And whether the platform
will even allow it, is a different matter.)


However, it is really important for there to not be a load of special
casing (all undocumented, naturally) keeping the CPU and IOMMU views
different.  It is an error that the views were ever different
(translation wise), and the only legitimate permission difference I can
think of is to support logdirty mode for migration.  (Introspection
protection for device-enabled VMs will be left as an exercise to
whomever first wants to use it.)

Making the guest physical address space view consistent between the CPU
and device is a "because its obviously the correct thing to do" issue. 
Deciding "well it makes no sense for you to have an IO mapping of $FOO"
is a matter of policy that Xen has no legitimate right to be enforcing.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 19:26:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 19:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236953.410950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msriX-0000mC-JH; Thu, 02 Dec 2021 19:26:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236953.410950; Thu, 02 Dec 2021 19:26:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msriX-0000m5-Fe; Thu, 02 Dec 2021 19:26:05 +0000
Received: by outflank-mailman (input) for mailman id 236953;
 Thu, 02 Dec 2021 19:26:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Wgxe=QT=intel.com=ashok.raj@srs-se1.protection.inumbo.net>)
 id 1msriV-0000lz-HO
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 19:26:03 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ad256d1f-53a5-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 20:26:00 +0100 (CET)
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Dec 2021 11:25:57 -0800
Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.123])
 by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Dec 2021 11:25:56 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad256d1f-53a5-11ec-b1df-f38ee3fbfdf7
X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="216805916"
X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; 
   d="scan'208";a="216805916"
X-IronPort-AV: E=Sophos;i="5.87,282,1631602800"; 
   d="scan'208";a="512998017"
Date: Thu, 2 Dec 2021 11:21:39 -0800
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Dey, Megha" <megha.dey@intel.com>, LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Andrew Cooper <amc96@cam.ac.uk>, Juergen Gross <jgross@suse.com>,
	linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org,
	Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
Message-ID: <20211202192139.GE364748@otc-nc-03>
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
 <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com>
 <871r2v71mg.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871r2v71mg.ffs@tglx>

Hi Thomas,

On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote:
> Megha,
> 
> On Wed, Dec 01 2021 at 17:08, Megha Dey wrote:
> > On 11/26/2021 5:25 PM, Thomas Gleixner wrote:
> >>   /**
> >> + * pci_msix_expand_vectors_at - Expand MSI-X interrupts for a device
> >> + *
> >> + * @dev:	PCI device to operate on
> >> + * @at:		Allocate at MSI-X index. If @at == PCI_MSI_EXPAND_AUTO
> >> + *		the function expands automatically after the last
> > Not sure why some of these changes related to PCI_MSIX_EXPAND_AUTO and 
> > num_descs did not make it to the 'msi' branch.
> > Is this intentional?
> 
> Yes, because I'm not happy about that magic.
> 
> >
> > For instance, say:
> > 1. Driver requests for 5 vectors:
> > pci_enable_msix_range(dev, NULL, 5, 5)
> > =>num_descs = 5
> 
> Driver should not use with pci_enable_msix_range() in the first
> place. But yes, it got 5 vectors now.

Bad start with a deprecated interface :-). 

> 
> > 2. Driver frees vectors at index 1,2:
> > range = {1, 2, 2};
> > pci_msi_teardown_msi_irqs(dev, range)
> 
> That function is not accessible by drivers for a reason.
> 
> > =>num_descs = 3; Current active vectors are at index: 0, 3, 4
> 
> > 3. Driver requests for 3 more vectors using the new API:
> > pci_msix_expand_vectors(dev, 3)
> > =>range.first = 3 => It will try to allocate index 3-5, but we already 
> > have 3,4 active?
> > Ideally, we would want index 1,2 and 5 to be allocated for this request 
> > right?
> >
> > Could you please let me know what I am missing?
> 
> You're missing the real world use case. The above is fiction.

I don't think there is a valid use case for freeing specific vectors. Its
true some are special, IDXD has vector#0 like that. But I expect drivers to
acquire these special vectors  once and never free them until driver 
tear down time.

But there is a need to free on demand, for a subdevice constructed for idxd
pass-through, when the guest is torn down, host would need to free them.
Only growing on demand seems to only catch one part of the dynamic part.

IDXD also allocates interrupt only when the WQ is enabled, and frees when its
disabled. 

> 
> If a driver would release 1 and 2 then it should explicitely reallocate
> 1 and 2 and not let the core decide to magically allocate something.
> 
> If the driver wants three more after freeing 1, 2 then the core could
> just allocate 5, 6, 7, and would still fulfil the callers request to
> allocate three more, right?

Since the core is already managing what's allocated and free, requiring
drivers to manage each allocated entries seem hard, while the core can
easily manage it. For IDXD cases, we don't really care which ones of the
IMS is being allocated and freed. It just wants one of the available IMS
entries. The assumption is since the driver would have acquired any special
ones upfront with the alloc_irqs().


> 
> And even if it just allocates one, then the caller still has to know the
> index upfront. Why? Because it needs to know it in order to get the
> Linux interrupt number via pci_irq_vector().

If we were to allocate one, the new API can simply return the index
directly to the caller, and they call pci_irq_vector() to get the IRQ
number.

> 
> > Correspondingly, pci_free_msix_irq_vector(pdev, irq) frees all the 
> > allocated resources associated with MSI-X interrupt with Linux IRQ 
> > number 'irq'.
> > I had issues when trying to dynamically allocate more than 1 interrupt 
> > because I didn't have a clean way to communicate to the driver what 
> > indexes were assigned in the current allocation.
> 
> If the driver is able to free a particular vector then it should exactly
> know what it it doing and which index it is freeing. If it needs that
> particular vector again, then it knows the index, right?
> 
> Let's look how MSI-X works in reality:
> 
> Each vector is associated to a particular function in the device. How
> that association works is device dependent.
> 
> Some devices have hardwired associations, some allow the driver to
> program the association in the device configuration and there is also a
> combination of both.
> 
> So if the driver would free the vector for a particular functionality,
> or not allocate it in the first place, then it exactly knows what it
> freed and what it needs to allocate when it needs that functionality
> (again).

It doesn't *have* to be that all vectors are special. Some of them are
special that they acquired all during driver load time. These are allocated
once and never freed. The rest are for say completion interrupts or such and 
such that go with work queues. These can dynamically be allocated and
freed.

The driver doesn't really care which index it wants or what the next index
should be. But it has to remember the allocated ones so it can pass down
for the free. Maybe the one we did a while back

https://lore.kernel.org/lkml/1561162778-12669-1-git-send-email-megha.dey@linux.intel.com/

This has a group handle, and kept adding things to it.

> 
> What you are trying to create is a solution in search of a problem. You
> cannot declare via a random allocation API how devices work. You neither
> can fix the VFIO issue in a sensible way.
> 
> VFIO starts with vector #0 allocated. The guest then unmasks vector #50.
> 
> With your magic interface VFIO has to allocate 49 vectors and then free
> 48 of them again or just keep 48 around for nothing which defeats the
> purpose of on demand allocation completely.

This use case is broken already, the VFIO case sort of assumes things are
growing in sequence. Today it doesn't have a hint on which entry is being
unmasked I suppose. So VFIO simply releases everything, adds N more than
currently allocated. 

If there is a real world need for allocating a
specific vector#50, maybe we should add a alloc_exact() type and core can
check if #50 is still available.

Maybe for MSIx we don't have a need to shrink based on current usage. IMS
requires both grow and shrink. But it might be odd to have 2 domains behave
quite differently.

Cheers,
Ashok


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 20:16:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 20:16:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236968.410972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mssV3-0006rw-It; Thu, 02 Dec 2021 20:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236968.410972; Thu, 02 Dec 2021 20:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mssV3-0006rp-Fg; Thu, 02 Dec 2021 20:16:13 +0000
Received: by outflank-mailman (input) for mailman id 236968;
 Thu, 02 Dec 2021 20:16:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wP8P=QT=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1mssV2-0006rj-OG
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 20:16:12 +0000
Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr
 [80.12.242.130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aebe5a35-53ac-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 21:16:08 +0100 (CET)
Received: from pop-os.home ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id ssUvmqRgBozlissUvmqm80; Thu, 02 Dec 2021 21:16:07 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aebe5a35-53ac-11ec-b1df-f38ee3fbfdf7
X-ME-Helo: pop-os.home
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Thu, 02 Dec 2021 21:16:07 +0100
X-ME-IP: 86.243.171.122
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	roger.pau@citrix.com,
	axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org,
	linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: [PATCH v2] xen-blkfront: Use the bitmap API when applicable
Date: Thu,  2 Dec 2021 21:16:04 +0100
Message-Id: <d6f31db1d2542e1b4ba66d4cea80d3891678aa5a.1638476031.git.christophe.jaillet@wanadoo.fr>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
open-coded arithmetic in allocator arguments.

Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
consistency.

Use 'bitmap_copy()' to avoid an explicit 'memcpy()'

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v1 --> v2: change another kfree into bitmap_free
---
 drivers/block/xen-blkfront.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 700c765a759a..69cf13608ce0 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -442,22 +442,20 @@ static int xlbd_reserve_minors(unsigned int minor, unsigned int nr)
 	if (end > nr_minors) {
 		unsigned long *bitmap, *old;
 
-		bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
-				 GFP_KERNEL);
+		bitmap = bitmap_zalloc(end, GFP_KERNEL);
 		if (bitmap == NULL)
 			return -ENOMEM;
 
 		spin_lock(&minor_lock);
 		if (end > nr_minors) {
 			old = minors;
-			memcpy(bitmap, minors,
-			       BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
+			bitmap_copy(bitmap, minors, nr_minors);
 			minors = bitmap;
 			nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
 		} else
 			old = bitmap;
 		spin_unlock(&minor_lock);
-		kfree(old);
+		bitmap_free(old);
 	}
 
 	spin_lock(&minor_lock);
@@ -2610,7 +2608,7 @@ static void __exit xlblk_exit(void)
 
 	xenbus_unregister_driver(&blkfront_driver);
 	unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
-	kfree(minors);
+	bitmap_free(minors);
 }
 module_exit(xlblk_exit);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 02 20:25:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 20:25:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236973.410983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mssdZ-00007H-Dc; Thu, 02 Dec 2021 20:25:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236973.410983; Thu, 02 Dec 2021 20:25:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mssdZ-000077-AM; Thu, 02 Dec 2021 20:25:01 +0000
Received: by outflank-mailman (input) for mailman id 236973;
 Thu, 02 Dec 2021 20:24:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TPEC=QT=linuxfoundation.org=aweltz@srs-se1.protection.inumbo.net>)
 id 1mssdX-00006z-MW
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 20:24:59 +0000
Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com
 [2607:f8b0:4864:20::12c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ea8e32e2-53ad-11ec-976b-d102b41d0961;
 Thu, 02 Dec 2021 21:24:57 +0100 (CET)
Received: by mail-il1-x12c.google.com with SMTP id s11so630682ilv.3
 for <xen-devel@lists.xenproject.org>; Thu, 02 Dec 2021 12:24:57 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea8e32e2-53ad-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linuxfoundation.org; s=google;
        h=mime-version:from:date:message-id:subject:to;
        bh=fvwxTg2PflpBR0KQyxD4vSg7TSVp15o2bx+r/DBfZ8w=;
        b=XCZi5KATZGhRIM+eBVe9TjC33zUiJh35tFW+XiZEE6P9AczIKZUxuShAKpvGK9dpB1
         i1Pwnp3j8eZLdPGP5PntHm8lh5TV35pFZs51ps0WK6QRIUsNxtINIA24ME5n7bARuVdw
         fpmlTbqh42A2GZD1q1OiwcKj1PtWgOUBmA4PM=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=fvwxTg2PflpBR0KQyxD4vSg7TSVp15o2bx+r/DBfZ8w=;
        b=AEDIACyBfNRnYxZ7GjT+mk7qi7lvAulLgflXIp3DVCi02IYzqgC2oKkaNJzVEOYBI1
         RYoQVOUkV8+VHVe8RRzdeqNWGjOkyQULfSVT3qXLpv0QTZJxR7rmR/zyo9Wm9VRV0JI9
         hNB1iCAJiJywLyHAJZB15fzx55ySk08CRbCdcFm3Ycn2HZVIk1kR8kvu3kzI56yx7Zry
         u6JXm1tXjng0YC/Tk7nhZGxetHjPmz7fAAbA4VAmlA5sH5h+sYZ0NaBIeANtcsv9KXi6
         BRRTRWrZxMWMJorX8fg0uMl3kyTFtBNpVudfkVXE04cI61k5ww0ujysYlpIDwHhOHmJl
         kF4A==
X-Gm-Message-State: AOAM530Bzj/btOkM+BMYkY8rIOt0G/Mt6ENQGfTLUDND0yeMZXtRYxIM
	NAk8oX79OORosViV7OaUw8rzOSrzTG1tpmjzg+ZLcNfF0ES5Sfvw
X-Google-Smtp-Source: ABdhPJwuqAxmteZnb/S16CqYQBe6giTPLfnaufcB3kM/GXYb24ScivZVykO/tSy8aA0EfgOerb5Z/3TFioSKm9egYGU=
X-Received: by 2002:a05:6e02:1583:: with SMTP id m3mr16920993ilu.294.1638476696588;
 Thu, 02 Dec 2021 12:24:56 -0800 (PST)
MIME-Version: 1.0
From: Ashley Weltz <aweltz@linuxfoundation.org>
Date: Thu, 2 Dec 2021 15:24:41 -0500
Message-ID: <CADT4066W=fGoiyCTATSM3fZozrS1NYh3aFNtw7BM044ui_RL8Q@mail.gmail.com>
Subject: Call for agenda items for December 7th Community Call @ 1500 UTC
To: xen-devel@lists.xenproject.org, amit@infradead.org, 
	andrew.cooper3@citrix.com, Artem_Mygaiev@epam.com, ash.j.wilding@gmail.com, 
	ben@exotanium.io, bobby.eshleman@gmail.com, brendank310@gmail.com, 
	brian.woods@xilinx.com, cardoe@cardoe.com, christopher.w.clark@gmail.com, 
	Corey Minyard <cminyard@mvista.com>, daniel.kiper@oracle.com, deepthi.m@ltts.com, 
	dpsmith@apertussolutions.com, dwmw@amazon.co.uk, edgar.iglesias@xilinx.com, 
	Ian.Jackson@citrix.com, insurgo@riseup.net, intel-xen@intel.com, 
	Jarvis.Roach@dornerworks.com, Jeff.Kubascik@dornerworks.com, jgross@suse.com, 
	john.ji@intel.com, julien@xen.org, kevin.pearson@ortmanconsulting.com, 
	Matt.Spencer@arm.com, =?UTF-8?Q?Mirela_Simonovi=C4=87?= <mirela.simonovic@aggios.com>, 
	oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, 
	olivier.lambert@vates.fr, pdurrant@amazon.com, persaur@gmail.com, 
	piotr.krol@3mdeb.com, Rahul.Singh@arm.com, rianquinn@gmail.com, 
	rob.townley@gmail.com, robin.randhawa@arm.com, roger.pau@citrix.com, 
	scottwd@gmail.com, sergey.dyasli@citrix.com, sstabellini@kernel.org, 
	Stewart.Hildebrand@dornerworks.com, tamas.k.lengyel@gmail.com, 
	varadgautam@gmail.com, volodymyr_babchuk@epam.com, wl@xen.org
Content-Type: multipart/alternative; boundary="00000000000079296405d22f95f9"

--00000000000079296405d22f95f9
Content-Type: text/plain; charset="UTF-8"

Hi everyone,

Our next meeting is on Tuesday, December 7th at 1500 UTC.

The proposed agenda is in
https://cryptpad.fr/pad/#/2/pad/edit/0uM9VB27hQfkyZ+A8libTu4E/ Please add
or edit any items to this agenda. Alternatively, please feel free to email
me directly with agenda items.

Please put your name beside any items if you edit the document.

We will plan to start the meeting 5 minutes past the hour.

* If you want to be CC'ed please add or remove yourself from the
sign-up-sheet at
https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Again, please let me know if you have any questions. See you on Tuesday!

Cheers,
Ashley

-- 
Ashley Weltz, Project Coordinator
The Linux Foundation
aweltz@linuxfoundation.org

--00000000000079296405d22f95f9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi everyone,<div><br></div><div><div>Our next meeting is o=
n Tuesday, December 7th at 1500 UTC.=C2=A0</div><div><br></div><div>The pro=
posed agenda is in=C2=A0<a href=3D"https://cryptpad.fr/pad/#/2/pad/edit/0uM=
9VB27hQfkyZ+A8libTu4E/">https://cryptpad.fr/pad/#/2/pad/edit/0uM9VB27hQfkyZ=
+A8libTu4E/</a>=C2=A0Please add or edit any items to this agenda. Alternati=
vely, please feel free to email me directly with agenda items.=C2=A0</div><=
div><br>Please put your name beside any items if you edit the document.<br>=
<br>We will plan to start the meeting 5 minutes past the hour.=C2=A0<br><br=
>* If you want to be CC&#39;ed please add or remove yourself from the sign-=
up-sheet at=C2=A0<a href=3D"https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxx=
AOe6RFPz0sRCf+/" rel=3D"noreferrer" target=3D"_blank">https://cryptpad.fr/p=
ad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/</a></div><div><br></div><div>Agai=
n, please let me know if you have any questions. See you on Tuesday!</div><=
div><br></div><div>Cheers,</div><div>Ashley</div></div><div><br></div>-- <b=
r><div dir=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signat=
ure"><div dir=3D"ltr">Ashley Weltz, Project Coordinator=C2=A0<div>The Linux=
 Foundation</div><div><a href=3D"mailto:aweltz@linuxfoundation.org" target=
=3D"_blank">aweltz@linuxfoundation.org</a></div></div></div></div>

--00000000000079296405d22f95f9--


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 20:40:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 20:40:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.236997.411003 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msssH-0002qP-RX; Thu, 02 Dec 2021 20:40:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 236997.411003; Thu, 02 Dec 2021 20:40:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msssH-0002qI-OD; Thu, 02 Dec 2021 20:40:13 +0000
Received: by outflank-mailman (input) for mailman id 236997;
 Thu, 02 Dec 2021 20:40:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JeoH=QT=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1msssF-0002qC-Ns
 for xen-devel@lists.xenproject.org; Thu, 02 Dec 2021 20:40:12 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a8fdada-53b0-11ec-b1df-f38ee3fbfdf7;
 Thu, 02 Dec 2021 21:40:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a8fdada-53b0-11ec-b1df-f38ee3fbfdf7
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638477609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=55ngEOg/vl85x4iqjs7xFGP7JVdJD8eA7lFIRRDhniM=;
	b=VaCFhl2F3RpnndXOk0eJfp+MZfNLGIhC7Xfr1C7roo+cjM22fAvOsAl/A7cAWmCtLymHjc
	50oJP/iIdrv76mJN7IlbdBUnQILQHEsI5wbW14XFFreH1tubQHAMoTLBITYBnHQesOWFtu
	QOb2vt/UiTD+Kk2KSOfI1hIews75sAmq3DNgcd0MCb37ECsh8KRN62cCHOUUrmBQdsSRJP
	9M6W/eqPQeqiyMYubKpNxx/+M8rc722I5/LdtlYs1M/goMGZpsYGC0HfA0BzjM/eGc9oOA
	u3GF1U4PdSzz7YKu6nhHhA/QLBdfDpWwfNEiSzYYNjAaSXXGwTx9gU2roATg2w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638477609;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=55ngEOg/vl85x4iqjs7xFGP7JVdJD8eA7lFIRRDhniM=;
	b=giWY26evQ6Gj3SdmIKnHGHwKedfVnbxBq1EnNDwhpVHvOUA3RWS/r8MBniS7ea4c6DREvi
	z3y0Ip64M87e4xCw==
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: "Dey, Megha" <megha.dey@intel.com>, LKML <linux-kernel@vger.kernel.org>,
 Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Michael Ellerman
 <mpe@ellerman.id.au>, Andrew Cooper <amc96@cam.ac.uk>, Juergen Gross
 <jgross@suse.com>, linux-pci@vger.kernel.org,
 xen-devel@lists.xenproject.org, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
In-Reply-To: <20211202192139.GE364748@otc-nc-03>
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
 <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com> <871r2v71mg.ffs@tglx>
 <20211202192139.GE364748@otc-nc-03>
Date: Thu, 02 Dec 2021 21:40:08 +0100
Message-ID: <87r1au68rb.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Ashok,

On Thu, Dec 02 2021 at 11:21, Ashok Raj wrote:
> On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote:
>> On Wed, Dec 01 2021 at 17:08, Megha Dey wrote:
>> You're missing the real world use case. The above is fiction.
>
> I don't think there is a valid use case for freeing specific vectors. Its
> true some are special, IDXD has vector#0 like that. But I expect drivers to
> acquire these special vectors  once and never free them until driver 
> tear down time.
>
> But there is a need to free on demand, for a subdevice constructed for idxd
> pass-through, when the guest is torn down, host would need to free them.
> Only growing on demand seems to only catch one part of the dynamic part.
>
> IDXD also allocates interrupt only when the WQ is enabled, and frees when its
> disabled.

You're talking about IMS not MSI-X here, right? IMS cannot be allocated
via the PCI/MSI interfaces as we established long ago.

And if you are talking about the 8 MSI-X interrupts for IDXD then I
really do not see the point of ever releasing it.

>> If a driver would release 1 and 2 then it should explicitely reallocate
>> 1 and 2 and not let the core decide to magically allocate something.
>> 
>> If the driver wants three more after freeing 1, 2 then the core could
>> just allocate 5, 6, 7, and would still fulfil the callers request to
>> allocate three more, right?
>
> Since the core is already managing what's allocated and free, requiring
> drivers to manage each allocated entries seem hard, while the core can
> easily manage it. For IDXD cases, we don't really care which ones of the
> IMS is being allocated and freed. It just wants one of the available IMS
> entries. The assumption is since the driver would have acquired any special
> ones upfront with the alloc_irqs().

For MSI-X the free vector use case does not exist today and even if it
would exist the driver has to know about the index.

If the index -> function accociation is hard wired, it needs to know it
obviously.

If it's not hardwired then it still needs to know the resulting index,
because it has to program that index into a device function register so
that the device knows which entry to use.

IMS is not any different. You need to know the index in order to
associate it to the queue, no? And you need the index in order to figure
out the Linux irq number.

But again, that's not a problem of this very API because this API is
about PCI/MSI and not about IMS.

>> And even if it just allocates one, then the caller still has to know the
>> index upfront. Why? Because it needs to know it in order to get the
>> Linux interrupt number via pci_irq_vector().
>
> If we were to allocate one, the new API can simply return the index
> directly to the caller, and they call pci_irq_vector() to get the IRQ
> number.

That can work, but then we need both variants:

     pci_msix_alloc_vector_at() and pci_msix_alloc_vector_any()

Why?

Because pci_msix_alloc_vector_any() cannot solve the VFIO on demand
allocation problem and it cannot be used to replace the sparse
allocations which are done via pci_enable_msix_exact() today.

If there is an MSI-X use case to allocate any vector then we can
implement that. If there is none, then we don't need it, right?

>> So if the driver would free the vector for a particular functionality,
>> or not allocate it in the first place, then it exactly knows what it
>> freed and what it needs to allocate when it needs that functionality
>> (again).
>
> It doesn't *have* to be that all vectors are special. Some of them are
> special that they acquired all during driver load time. These are allocated
> once and never freed. The rest are for say completion interrupts or such and 
> such that go with work queues. These can dynamically be allocated and
> freed.
>
> The driver doesn't really care which index it wants or what the next index
> should be. But it has to remember the allocated ones so it can pass down
> for the free. Maybe the one we did a while back
>
> https://lore.kernel.org/lkml/1561162778-12669-1-git-send-email-megha.dey@linux.intel.com/
>
> This has a group handle, and kept adding things to it.

Was it really necessary to bring those memories back?

If we want groups, then surely not with these kind of hacks. I still
need to see the usecase for the groups. The discussion back then just
provided handwaving about internal request which never materialized.

But talking about groups. That's very similar to the other discussion
vs. storing the IMS entries for these sliced devices, queues or
whatever. That's at least a use case.

>> What you are trying to create is a solution in search of a problem. You
>> cannot declare via a random allocation API how devices work. You neither
>> can fix the VFIO issue in a sensible way.
>> 
>> VFIO starts with vector #0 allocated. The guest then unmasks vector #50.
>> 
>> With your magic interface VFIO has to allocate 49 vectors and then free
>> 48 of them again or just keep 48 around for nothing which defeats the
>> purpose of on demand allocation completely.
>
> This use case is broken already, the VFIO case sort of assumes things are
> growing in sequence. Today it doesn't have a hint on which entry is being
> unmasked I suppose. So VFIO simply releases everything, adds N more than
> currently allocated.

VFIO exactly knows which entry is unmasked simply because the write into
the MSI-X table in the device config space is trapped so it knows
exactly which entry is unmasked, no? Guess how VFIO knows about $N more?

> Maybe for MSIx we don't have a need to shrink based on current usage. IMS
> requires both grow and shrink. But it might be odd to have 2 domains behave
> quite differently.

We are not implementing the full MSI[X] zoo for IMS either. So the
interfaces are different in the first place.

Making them artificially uniform is a horrible idea.

They are two different things, really. The only thing they have in common
is that at the end of the day the device sends a message over the bus
and they happen to share the underlying MSI code infrastructure.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 21:07:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 21:07:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237009.411023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mstIk-0005tS-3E; Thu, 02 Dec 2021 21:07:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237009.411023; Thu, 02 Dec 2021 21:07:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mstIk-0005tL-04; Thu, 02 Dec 2021 21:07:34 +0000
Received: by outflank-mailman (input) for mailman id 237009;
 Thu, 02 Dec 2021 21:07:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mstIi-0005tA-6m; Thu, 02 Dec 2021 21:07:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mstIh-0001gd-VO; Thu, 02 Dec 2021 21:07:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mstIh-00052t-Kc; Thu, 02 Dec 2021 21:07:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mstIh-0002ry-K3; Thu, 02 Dec 2021 21:07:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hgZXMbp8O98bm1YQkxJ398tBYwPUOXMNaz5iPYMf3UI=; b=BNeRTROMhgx32v4n1nHtOLQHHS
	MBERf0UZ3jrqTrBMefEzKf2NqNku77RLSBaoewLT4oGpCEpdeMxnY22cKU2AaWVE/tUBAu5JyrKox
	LXiS9yunFHNC+nB/97GJ0ic+7Amxj6PAdiV+4nvfblnkxsRqm5mcuVogiTjvcSrZlQgs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-166999-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 166999: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    xen-unstable:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:regression
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-stop.audited:fail:regression
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-destroy:fail:regression
    xen-unstable:test-amd64-i386-xl:guest-destroy:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-pygrub:guest-start.2:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:heisenbug
    xen-unstable:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-cubietruck:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 21:07:31 +0000

flight 166999 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/166999/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-xsm      22 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166941
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 166966 REGR. vs. 166912
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 166966 REGR. vs. 166941
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 23 guest-stop.audited fail in 166966 REGR. vs. 166941
 test-amd64-i386-libvirt-xsm  22 guest-destroy  fail in 166975 REGR. vs. 166912
 test-amd64-i386-xl           24 guest-destroy  fail in 166975 REGR. vs. 166941

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl          14 guest-start      fail in 166966 pass in 166999
 test-amd64-i386-xl           14 guest-start      fail in 166966 pass in 166999
 test-amd64-i386-pair       25 guest-start/debian fail in 166966 pass in 166999
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail in 166966 pass in 166999
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166966 pass in 166999
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 166966 pass in 166999
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 166966 pass in 166999
 test-armhf-armhf-libvirt     14 guest-start      fail in 166966 pass in 166999
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 166999
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 166966 pass in 166999
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 166966 pass in 166999
 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 166999
 test-arm64-arm64-libvirt-xsm 14 guest-start      fail in 166975 pass in 166999
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail in 166975 pass in 166999
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 166975 pass in 166999
 test-arm64-arm64-xl 18 guest-start/debian.repeat fail in 166975 pass in 166999
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 166975 pass in 166999
 test-amd64-amd64-pygrub      22 guest-start.2    fail in 166975 pass in 166999
 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 166975 pass in 166999
 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start           fail pass in 166966
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-xl-credit2  22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166966
 test-amd64-i386-xl-shadow    22 guest-start/debian.repeat  fail pass in 166966
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166966
 test-armhf-armhf-xl          14 guest-start                fail pass in 166966
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 166975
 test-amd64-i386-xl           22 guest-start/debian.repeat  fail pass in 166975
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail pass in 166975
 test-amd64-i386-libvirt      20 guest-start/debian.repeat  fail pass in 166975
 test-arm64-arm64-xl-credit2  18 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166975
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail pass in 166975
 test-amd64-i386-xl-vhd       21 guest-start/debian.repeat  fail pass in 166975
 test-armhf-armhf-xl-arndale  18 guest-start/debian.repeat  fail pass in 166975
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat  fail pass in 166975
 test-armhf-armhf-xl-cubietruck 18 guest-start/debian.repeat fail pass in 166975

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds   22 guest-start/debian.repeat fail blocked in 166941
 test-armhf-armhf-xl         15 migrate-support-check fail in 166966 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 166966 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    5 days
Failing since        166960  2021-11-30 12:35:41 Z    2 days    4 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 396 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 02 23:27:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 02 Dec 2021 23:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237047.411097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msvTg-0004tN-9x; Thu, 02 Dec 2021 23:27:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237047.411097; Thu, 02 Dec 2021 23:27:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msvTg-0004tG-70; Thu, 02 Dec 2021 23:27:00 +0000
Received: by outflank-mailman (input) for mailman id 237047;
 Thu, 02 Dec 2021 23:26:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msvTf-0004t6-Et; Thu, 02 Dec 2021 23:26:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msvTf-0003zb-9A; Thu, 02 Dec 2021 23:26:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msvTf-0002Q1-1S; Thu, 02 Dec 2021 23:26:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msvTf-0000uF-0w; Thu, 02 Dec 2021 23:26:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cCG6zM75SM5pJBuNEN+kFrzt9V/i/Zz9ybb63Mg/e0E=; b=4kJzF4WLvR3Ee5r87CpLeKpz2M
	eYh9z3sqx2BQH0WMK1vlzPVtX3K8UU5M+d8shCu75I3XqzxmZQVPAe9aTEHwic7rhVnVQl6kdmSqV
	BVY/pxzqNVe4tNXluiFBt0YV1oI3TiPk+K6n0emS/Sr/6RGCos6wtSzW2Fgkr1hjnaTc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167033-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167033: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start.2:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=eb41074692094dff1413efb44fa4928a9140aa41
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 02 Dec 2021 23:26:59 +0000

flight 167033 xen-unstable-smoke real [real]
flight 167046 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167033/
http://logs.test-lab.xenproject.org/osstest/logs/167046/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt     21 guest-start.2            fail REGR. vs. 166958

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail in 167020 pass in 167033
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 167020
 test-armhf-armhf-xl          18 guest-start/debian.repeat  fail pass in 167020

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 167020 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 167020 never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  eb41074692094dff1413efb44fa4928a9140aa41
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    2 days
Failing since        166977  2021-12-01 17:08:21 Z    1 days    6 attempts
Testing same since   166988  2021-12-01 23:02:57 Z    1 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 00:50:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 00:50:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237069.411138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mswmK-00070n-5d; Fri, 03 Dec 2021 00:50:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237069.411138; Fri, 03 Dec 2021 00:50:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mswmK-00070g-2a; Fri, 03 Dec 2021 00:50:20 +0000
Received: by outflank-mailman (input) for mailman id 237069;
 Fri, 03 Dec 2021 00:50:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FxXt=QU=intel.com=ashok.raj@srs-se1.protection.inumbo.net>)
 id 1mswmI-00070a-UC
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 00:50:18 +0000
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f947ab06-53d2-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 01:50:15 +0100 (CET)
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Dec 2021 16:50:03 -0800
Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.123])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Dec 2021 16:50:02 -0800
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f947ab06-53d2-11ec-976b-d102b41d0961
X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="237107303"
X-IronPort-AV: E=Sophos;i="5.87,283,1631602800"; 
   d="scan'208";a="237107303"
X-IronPort-AV: E=Sophos;i="5.87,283,1631602800"; 
   d="scan'208";a="513457950"
Date: Thu, 2 Dec 2021 16:45:45 -0800
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Dey, Megha" <megha.dey@intel.com>, LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Andrew Cooper <amc96@cam.ac.uk>, Juergen Gross <jgross@suse.com>,
	linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org,
	Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
Message-ID: <20211203004545.GF364748@otc-nc-03>
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
 <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com>
 <871r2v71mg.ffs@tglx>
 <20211202192139.GE364748@otc-nc-03>
 <87r1au68rb.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87r1au68rb.ffs@tglx>

Hi Thomas

On Thu, Dec 02, 2021 at 09:40:08PM +0100, Thomas Gleixner wrote:
> Ashok,
> 
> On Thu, Dec 02 2021 at 11:21, Ashok Raj wrote:
> > On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote:
> >> On Wed, Dec 01 2021 at 17:08, Megha Dey wrote:
> >> You're missing the real world use case. The above is fiction.
> >
> > I don't think there is a valid use case for freeing specific vectors. Its
> > true some are special, IDXD has vector#0 like that. But I expect drivers to
> > acquire these special vectors  once and never free them until driver 
> > tear down time.
> >
> > But there is a need to free on demand, for a subdevice constructed for idxd
> > pass-through, when the guest is torn down, host would need to free them.
> > Only growing on demand seems to only catch one part of the dynamic part.
> >
> > IDXD also allocates interrupt only when the WQ is enabled, and frees when its
> > disabled.
> 
> You're talking about IMS not MSI-X here, right? IMS cannot be allocated
> via the PCI/MSI interfaces as we established long ago.
> 
> And if you are talking about the 8 MSI-X interrupts for IDXD then I
> really do not see the point of ever releasing it.

Not worried about MSI-x for IDXD :), I assumed the purpose of this exercise
was about 2 things.

- Fix the VFIO mask/unmask weirdness ending up disable, reenable with more
  interrupts. 
  - We are only fixing the case by not calling the disable_msi, but just
    growing on demand.

- Use this as a case to build IMS. but if we treat MSIx and IMS
  differently, IMS would be bit different in how the dynamic parts work.

Although there is no real need for MSIx being dynamic except to avoid host
vector exhausion, do you think we could still allocate specific entries.
Since unmask is per-vector, is there benefit to doing just that vs
allocating current+N?

> 
> >> If a driver would release 1 and 2 then it should explicitely reallocate
> >> 1 and 2 and not let the core decide to magically allocate something.
> >> 
> >> If the driver wants three more after freeing 1, 2 then the core could
> >> just allocate 5, 6, 7, and would still fulfil the callers request to
> >> allocate three more, right?
> >
> > Since the core is already managing what's allocated and free, requiring
> > drivers to manage each allocated entries seem hard, while the core can
> > easily manage it. For IDXD cases, we don't really care which ones of the
> > IMS is being allocated and freed. It just wants one of the available IMS
> > entries. The assumption is since the driver would have acquired any special
> > ones upfront with the alloc_irqs().
> 
> For MSI-X the free vector use case does not exist today and even if it
> would exist the driver has to know about the index.
> 
> If the index -> function accociation is hard wired, it needs to know it
> obviously.
> 
> If it's not hardwired then it still needs to know the resulting index,
> because it has to program that index into a device function register so
> that the device knows which entry to use.
> 
> IMS is not any different. You need to know the index in order to
> associate it to the queue, no? And you need the index in order to figure
> out the Linux irq number.
> 
> But again, that's not a problem of this very API because this API is
> about PCI/MSI and not about IMS.

fair enough..the thought was even though MSIx doesn't require that, but the
implementations can be consistent if we aren't breaking MSIx. 

but as you said they don't have to be the same and can differ in how they
are implemented.


> 
> >> And even if it just allocates one, then the caller still has to know the
> >> index upfront. Why? Because it needs to know it in order to get the
> >> Linux interrupt number via pci_irq_vector().
> >
> > If we were to allocate one, the new API can simply return the index
> > directly to the caller, and they call pci_irq_vector() to get the IRQ
> > number.
> 
> That can work, but then we need both variants:
> 
>      pci_msix_alloc_vector_at() and pci_msix_alloc_vector_any()
> 
> Why?
> 
> Because pci_msix_alloc_vector_any() cannot solve the VFIO on demand
> allocation problem and it cannot be used to replace the sparse
> allocations which are done via pci_enable_msix_exact() today.
> 
> If there is an MSI-X use case to allocate any vector then we can
> implement that. If there is none, then we don't need it, right?

agreed.

> 
> >> So if the driver would free the vector for a particular functionality,
> >> or not allocate it in the first place, then it exactly knows what it
> >> freed and what it needs to allocate when it needs that functionality
> >> (again).
> >
> > It doesn't *have* to be that all vectors are special. Some of them are
> > special that they acquired all during driver load time. These are allocated
> > once and never freed. The rest are for say completion interrupts or such and 
> > such that go with work queues. These can dynamically be allocated and
> > freed.
> >
> > The driver doesn't really care which index it wants or what the next index
> > should be. But it has to remember the allocated ones so it can pass down
> > for the free. Maybe the one we did a while back
> >
> > https://lore.kernel.org/lkml/1561162778-12669-1-git-send-email-megha.dey@linux.intel.com/
> >
> > This has a group handle, and kept adding things to it.
> 
> Was it really necessary to bring those memories back?

:-)

> 
> If we want groups, then surely not with these kind of hacks. I still
> need to see the usecase for the groups. The discussion back then just
> provided handwaving about internal request which never materialized.

true, we didn't hear back from the groups that asked for them.
> 
> But talking about groups. That's very similar to the other discussion
> vs. storing the IMS entries for these sliced devices, queues or
> whatever. That's at least a use case.

Correct.

> 
> >> What you are trying to create is a solution in search of a problem. You
> >> cannot declare via a random allocation API how devices work. You neither
> >> can fix the VFIO issue in a sensible way.
> >> 
> >> VFIO starts with vector #0 allocated. The guest then unmasks vector #50.
> >> 
> >> With your magic interface VFIO has to allocate 49 vectors and then free
> >> 48 of them again or just keep 48 around for nothing which defeats the
> >> purpose of on demand allocation completely.
> >
> > This use case is broken already, the VFIO case sort of assumes things are
> > growing in sequence. Today it doesn't have a hint on which entry is being
> > unmasked I suppose. So VFIO simply releases everything, adds N more than
> > currently allocated.
> 
> VFIO exactly knows which entry is unmasked simply because the write into
> the MSI-X table in the device config space is trapped so it knows
> exactly which entry is unmasked, no? Guess how VFIO knows about $N more?

bah.. i missed that little fact.

When VFIO knows exactly which entry is being unmasked, is it enough to just
allocate exact one, or do we need to all all N? I didn't see why we need to
grown by N additional vectors instead of only allocating 1 for the entry
being unmasked?

> 
> > Maybe for MSIx we don't have a need to shrink based on current usage. IMS
> > requires both grow and shrink. But it might be odd to have 2 domains behave
> > quite differently.
> 
> We are not implementing the full MSI[X] zoo for IMS either. So the
> interfaces are different in the first place.

The ones that actually differ between the MSIx and IMS are:

- Discovery on where to find that unlike the PCIe standard mechanism.
  (Although in initial implementation we have forced a common way to manage
  this, but I think people already hinted this isn't going to work
  for different vendors or even between gen1/gen2 devices.
- Managing the location of the add/data write, mask/unmask etc.
- Might have other attributes such as PASID etc for the IDXD case exposed
  to guest/user space.


Are there other differences between them?

> 
> Making them artificially uniform is a horrible idea.

Totally!

> 
> They are two different things, really. The only thing they have in common
> is that at the end of the day the device sends a message over the bus
> and they happen to share the underlying MSI code infrastructure.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 01:08:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 01:08:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237080.411150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msx3H-0002X8-MM; Fri, 03 Dec 2021 01:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237080.411150; Fri, 03 Dec 2021 01:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msx3H-0002X1-Hz; Fri, 03 Dec 2021 01:07:51 +0000
Received: by outflank-mailman (input) for mailman id 237080;
 Fri, 03 Dec 2021 01:07:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msx3G-0002Wr-G0; Fri, 03 Dec 2021 01:07:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msx3G-0007rC-8m; Fri, 03 Dec 2021 01:07:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msx3F-00072C-Tf; Fri, 03 Dec 2021 01:07:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msx3F-0007Ex-T6; Fri, 03 Dec 2021 01:07:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EC5rD5YZsQ2obG7LSUIhh5wwRK9JMN+0N1a0eQxsYWY=; b=m4o/KH9GU8Z2YnE2jZ7AOYgpOe
	8ZIx9kQac++jJjO/zZ+SS3SkZBItNVsq6XwZ7VTcfBmb0GgL5TdFqSxKGLgnOQFPEdtLkeb4WUNah
	uqdlixpNnzSjOXcqctG4xUpsc+9O190sTpIsv6AzACDy6jg8PITCi18A2QmuAGtKVBjM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167019-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167019: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:guest-start.2:fail:regression
    linux-linus:build-arm64-pvops:kernel-build:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:guest-start.2:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-saverestore:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl:guest-start:fail:heisenbug
    linux-linus:test-armhf-armhf-xl:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-credit1:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-xl:guest-start:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 01:07:49 +0000

flight 167019 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167019/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166942
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl         18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit1  19 guest-start.2            fail REGR. vs. 166942
 build-arm64-pvops             6 kernel-build   fail in 166969 REGR. vs. 166942
 test-amd64-amd64-xl 22 guest-start/debian.repeat fail in 166980 REGR. vs. 166942
 test-arm64-arm64-xl-credit2  19 guest-start.2  fail in 166980 REGR. vs. 166942
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166980 REGR. vs. 166942

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 166969 pass in 166980
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail in 166969 pass in 167019
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 15 guest-saverestore fail in 166969 pass in 167019
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 166969 pass in 167019
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 166969 pass in 167019
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 166969 pass in 167019
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail in 166980 pass in 167019
 test-arm64-arm64-xl          14 guest-start      fail in 166980 pass in 167019
 test-armhf-armhf-xl           8 xen-boot         fail in 166980 pass in 167019
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166980 pass in 167019
 test-armhf-armhf-libvirt     14 guest-start      fail in 166980 pass in 167019
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 166980 pass in 167019
 test-amd64-amd64-xl-vhd 21 guest-start/debian.repeat fail in 166980 pass in 167019
 test-amd64-amd64-libvirt-raw 19 guest-start/debian.repeat fail in 166980 pass in 167019
 test-arm64-arm64-xl-credit1  14 guest-start      fail in 166980 pass in 167019
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 166980 pass in 167019
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 166980 pass in 167019
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 166969
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166969
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166969
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166969
 test-armhf-armhf-libvirt     18 guest-start/debian.repeat  fail pass in 166969
 test-amd64-amd64-xl-credit1  14 guest-start                fail pass in 166980
 test-amd64-amd64-xl          14 guest-start                fail pass in 166980
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat  fail pass in 166980
 test-amd64-amd64-xl-shadow   22 guest-start/debian.repeat  fail pass in 166980
 test-amd64-amd64-xl-rtds     22 guest-start/debian.repeat  fail pass in 166980
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166980
 test-arm64-arm64-xl-credit2  18 guest-start/debian.repeat  fail pass in 166980
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166980
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 166980
 test-amd64-amd64-examine      4 memdisk-try-append         fail pass in 166980
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166980
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat  fail pass in 166980
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 166980

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-credit1   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-xsm       1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-seattle   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-vhd       1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-examine      1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-thunderx  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-credit2   1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl           1 build-check(1)           blocked in 166969 n/a
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 166980 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 166980 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    5 days
Failing since        166963  2021-11-30 20:54:02 Z    2 days    4 attempts
Testing same since   166969  2021-12-01 08:33:40 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alex Williamson <alex.williamson@redhat.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Bean Huo <beanhuo@micron.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Darrick J. Wong <djwong@kernel.org>
  David Howells <dhowells@redhat.com>
  David Woodhouse <dwmw@amazon.co.uk>
  Douglas Gilbert <dgilbert@interlog.com>
  Fuad Tabba <tabba@google.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Joerg Roedel <jroedel@suse.de>
  Juergen Gross <jgross@suse.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lu Baolu <baolu.lu@linux.intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Muchun Song <songmuchun@bytedance.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Piggin <npiggin@gmail.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Qian Cai <quic_qiancai@quicinc.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sean Christopherson <seanjc@google.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Waiman Long <longman@redhat.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3187 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 01:52:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 01:52:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237093.411175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msxkX-0008Cl-CH; Fri, 03 Dec 2021 01:52:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237093.411175; Fri, 03 Dec 2021 01:52:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msxkX-0008Ce-8J; Fri, 03 Dec 2021 01:52:33 +0000
Received: by outflank-mailman (input) for mailman id 237093;
 Fri, 03 Dec 2021 01:52:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msxkW-0008CU-0g; Fri, 03 Dec 2021 01:52:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msxkV-00008I-QK; Fri, 03 Dec 2021 01:52:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1msxkV-0008Ox-FD; Fri, 03 Dec 2021 01:52:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1msxkV-0002n4-Eh; Fri, 03 Dec 2021 01:52:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tzKQwwjBmD5haKCCDgxjyaEMMpoiOrnCOJkrz9PK+h4=; b=zAqLt60INhr0G+R7Kpl3A9js96
	ZVS7Z0CwWnRXy1xI1cLnCJFPPDifAbFNqubQLRW+hNAoWuHHTPESl35/ND3BHJWQ4iulm4yRWuaNU
	XOw6/bojd2DjDiBpBZzIh+9Fk3nF5r3+kD8X2mSDaQeuyW2G7ZhtwHkMyAUObRcMj8mQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167007-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167007: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-destroy:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-destroy:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start.2:fail:regression
    qemu-mainline:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-destroy:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-thunderx:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-coresched-i386-xl:guest-start.2:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-start/debian:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-arndale:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-i386-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-cubietruck:guest-start.2:fail:heisenbug
    qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-libvirt-raw:guest-start.2:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=682aa69b1f4dd5f2905a94066fa4c853adc33251
X-Osstest-Versions-That:
    qemuu=50456a6794fbb8dc94a31eb9534e91c586da7add
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 01:52:31 +0000

flight 167007 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167007/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt-xsm  22 guest-destroy            fail REGR. vs. 166954
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl          22 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt-xsm 22 guest-destroy  fail in 166968 REGR. vs. 166954
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166968 REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-intel 23 guest-start.2 fail in 166978 REGR. vs. 166954
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 166978 REGR. vs. 166954

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166968 pass in 166978
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166968 pass in 166978
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup fail in 166968 pass in 167007
 test-armhf-armhf-libvirt-raw  8 xen-boot         fail in 166968 pass in 167007
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166968 pass in 167007
 test-armhf-armhf-xl          14 guest-start      fail in 166968 pass in 167007
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 166968 pass in 167007
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 22 guest-destroy fail in 166968 pass in 167007
 test-arm64-arm64-xl-thunderx 14 guest-start      fail in 166978 pass in 167007
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-arm64-arm64-xl 18 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-i386-xl-xsm 22 guest-start/debian.repeat fail in 166978 pass in 167007
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 166978 pass in 167007
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 166978 pass in 167007
 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 166978 pass in 167007
 test-armhf-armhf-xl-credit2   8 xen-boot         fail in 166978 pass in 167007
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail in 166978 pass in 167007
 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 166978 pass in 167007
 test-amd64-coresched-i386-xl 23 guest-start.2              fail pass in 166968
 test-amd64-amd64-xl          22 guest-start/debian.repeat  fail pass in 166968
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat  fail pass in 166968
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166968
 test-armhf-armhf-xl-credit2  14 guest-start                fail pass in 166968
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 166968
 test-amd64-amd64-xl-pvhv2-intel 14 guest-start             fail pass in 166978
 test-amd64-i386-libvirt-pair 25 guest-start/debian         fail pass in 166978
 test-armhf-armhf-xl-arndale  14 guest-start                fail pass in 166978
 test-amd64-amd64-xl-credit1  22 guest-start/debian.repeat  fail pass in 166978
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail pass in 166978
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 166978
 test-amd64-i386-libvirt-raw  19 guest-start/debian.repeat  fail pass in 166978
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 166978
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 166978
 test-armhf-armhf-xl-cubietruck 19 guest-start.2            fail pass in 166978
 test-amd64-i386-xl-vhd       21 guest-start/debian.repeat  fail pass in 166978
 test-armhf-armhf-libvirt     18 guest-start/debian.repeat  fail pass in 166978
 test-armhf-armhf-libvirt-raw 18 guest-start.2              fail pass in 166978

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 166968 REGR. vs. 166954

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 166968 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 166968 never pass
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 166968 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 166968 never pass
 test-armhf-armhf-xl-arndale 15 migrate-support-check fail in 166978 never pass
 test-armhf-armhf-xl-arndale 16 saverestore-support-check fail in 166978 never pass
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 166978 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 166978 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166954
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166954
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166954
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166954
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166954
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166954
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                682aa69b1f4dd5f2905a94066fa4c853adc33251
baseline version:
 qemuu                50456a6794fbb8dc94a31eb9534e91c586da7add

Last test of basis   166954  2021-11-30 08:39:11 Z    2 days
Testing same since   166968  2021-12-01 06:37:45 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eduardo Habkost <ehabkost@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 682aa69b1f4dd5f2905a94066fa4c853adc33251
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Wed Dec 1 07:20:06 2021 +0100

    Update version for v6.2.0-rc3 release
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit 24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac
Author: Eduardo Habkost <ehabkost@redhat.com>
Date:   Tue Nov 30 15:47:22 2021 -0500

    MAINTAINERS: Change my email address
    
    The ehabkost@redhat.com email address will stop working on
    2021-12-01, change it to my personal email address.
    
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211129163053.2506734-1-ehabkost@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211130204722.2732997-2-ehabkost@redhat.com>
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 03:04:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 03:04:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237105.411202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msyrO-0008KK-6l; Fri, 03 Dec 2021 03:03:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237105.411202; Fri, 03 Dec 2021 03:03:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1msyrO-0008KD-31; Fri, 03 Dec 2021 03:03:42 +0000
Received: by outflank-mailman (input) for mailman id 237105;
 Fri, 03 Dec 2021 03:03:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/Fj5=QU=perches.com=joe@srs-se1.protection.inumbo.net>)
 id 1msyrN-0008K7-6g
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 03:03:41 +0000
Received: from smtprelay.hostedemail.com (smtprelay0044.hostedemail.com
 [216.40.44.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b1432fb-53e5-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 04:03:37 +0100 (CET)
Received: from omf06.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
 by smtprelay01.hostedemail.com (Postfix) with ESMTP id 140B9101369A0;
 Fri,  3 Dec 2021 03:03:35 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by
 omf06.hostedemail.com (Postfix) with ESMTPA id 6DDA420015; 
 Fri,  3 Dec 2021 03:03:32 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b1432fb-53e5-11ec-976b-d102b41d0961
Message-ID: <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Juergen Gross
	 <jgross@suse.com>, boris.ostrovsky@oracle.com, sstabellini@kernel.org, 
	roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Date: Thu, 02 Dec 2021 19:03:32 -0800
In-Reply-To: <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
References: 
	<1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
	 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
	 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
	 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
	 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Stat-Signature: dsgan1p8pchxr8wbecis6grq8tsez18d
X-Rspamd-Server: rspamout01
X-Rspamd-Queue-Id: 6DDA420015
X-Spam-Status: No, score=-4.90
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX1/U5Pxt1pAwSKl1eR87urKf9gGDN2xSyaw=
X-HE-Tag: 1638500612-192617

On Thu, 2021-12-02 at 20:07 +0100, Christophe JAILLET wrote:
> Le 02/12/2021 � 19:16, Joe Perches a �crit�:
> > On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
> > > Le 02/12/2021 � 07:12, Juergen Gross a �crit�:
> > > > On 01.12.21 22:10, Christophe JAILLET wrote:
> > > > > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
> > > > > some open-coded arithmetic in allocator arguments.
> > > > > 
> > > > > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > > > > consistency.
> > > > > 
> > > > > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> > []
> > > > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> > []
> > > > > @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int
> > > > > minor, unsigned int nr)
> > > > >  ����� if (end > nr_minors) {
> > > > >  ��������� unsigned long *bitmap, *old;
> > > > > -������� bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> > > > > -���������������� GFP_KERNEL);
> > > > > +������� bitmap = bitmap_zalloc(end, GFP_KERNEL);
> > > > >  ��������� if (bitmap == NULL)
> > > > >  ������������� return -ENOMEM;
> > > > >  ��������� spin_lock(&minor_lock);
> > > > >  ��������� if (end > nr_minors) {
> > > > >  ������������� old = minors;
> > > > > -����������� memcpy(bitmap, minors,
> > > > > -������������������ BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
> > > > > +����������� bitmap_copy(bitmap, minors, nr_minors);
> > > > >  ������������� minors = bitmap;
> > > > >  ������������� nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
> > 
> > 		nr_minors = end;
> > ?
> > 
> 
> No,
> My understanding of the code is that if we lack space (end > nr_minors), 
> we need to allocate more. In such a case, we want to keep track of what 
> we have allocated, not what we needed.
> The "padding" bits in the "long align" allocation, can be used later.

> 
> first call
> ----------
> end = 65
> nr_minors = 63
> 
> --> we need some space
> --> we allocate 2 longs = 128 bits
> --> we now use 65 bits of these 128 bits

or 96, 32 or 64 bit longs remember.

> 
> new call
> --------
> end = 68
> nr_minors = 128 (from previous call)

The initial allocation is now bitmap_zalloc which
specifies only bits and the nr_minors is then in
BITS_TO_LONGS(bits) * BITS_PER_LONG

Perhaps that assumes too much about the internal
implementation of bitmap_alloc





From xen-devel-bounces@lists.xenproject.org Fri Dec 03 03:32:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 03:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237111.411213 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mszIi-0003az-Fy; Fri, 03 Dec 2021 03:31:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237111.411213; Fri, 03 Dec 2021 03:31:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mszIi-0003as-CT; Fri, 03 Dec 2021 03:31:56 +0000
Received: by outflank-mailman (input) for mailman id 237111;
 Fri, 03 Dec 2021 03:31:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mszIh-0003ai-K0; Fri, 03 Dec 2021 03:31:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mszIh-0002Hd-D3; Fri, 03 Dec 2021 03:31:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mszIh-0005O0-4c; Fri, 03 Dec 2021 03:31:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mszIh-0004Y4-46; Fri, 03 Dec 2021 03:31:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5QOtDZcdHGwtfNTXvM5kEKL5pfCXfVF21dbAXJ+nHds=; b=xtHz8OFb5OKXiaKzyJt6QhA7To
	7G3AY7bWlSdk4BUTQq2oiVthSw9vOWvxPDMuKVW5FxC6QikjFG1RfhN8tr+WzkVCkYoFkzmkTNVUi
	bdXvHETuxV3X2quunNrRn57XK/Do7OLlMcHUXWYyEIVxJGg1xBRm3M/CiCbRRiMhMw1k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167051-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167051: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=05657c6d1821dfc4e9a618767a942b3555406046
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 03:31:55 +0000

flight 167051 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167051/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166958
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  05657c6d1821dfc4e9a618767a942b3555406046
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    2 days
Failing since        166977  2021-12-01 17:08:21 Z    1 days    7 attempts
Testing same since   167051  2021-12-03 00:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 05657c6d1821dfc4e9a618767a942b3555406046
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:11:01 2021 +0000

    x86/boot: Support __ro_after_init
    
    For security hardening reasons, it advantageous to make setup-once data
    immutable after boot.  Borrow __ro_after_init from Linux.
    
    On x86, place .data.ro_after_init at the start of .rodata, excluding it from
    the early permission restrictions.  Re-apply RO restrictions to the whole of
    .rodata in init_done(), attempting to reform the superpage if possible.
    
    For architectures which don't implement __ro_after_init explicitly, variables
    merges into .data.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 8de86b5cd4353bf2cc415e4563f973f071b4e8a3
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:04:11 2021 +0000

    x86/boot: Adjust .text/.rodata/etc permissions in one place
    
    At the moment, we have two locations selecting restricted permissions, not
    very far apart on boot, dependent on opposite answers from using_2M_mapping().
    The later location however can shatter superpages if needed, while the former
    cannot.
    
    Collect together all the permission adjustments at the slightly later point in
    boot, as we likely need to shatter a superpage to support __ro_after_init.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c182e89d0b341d2efc930c2e1211d3e866c0effb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:01:50 2021 +0000

    x86/boot: Drop xen_virt_end
    
    The calculation in __start_xen() for xen_virt_end is an opencoding of
    ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
    
    This corrects the bound calculations in arch_livepatch_init() and
    update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
    with CONFIG_XEN_ALIGN_2M.
    
    Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
    dynamically"), there have not been extraneous mappings to delete, meaning that
    the call to destroy_xen_mappings() has been a no-op.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit ffa5d037c78fe175f31373deec0759ff8cc8d66c
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:52:05 2021 +0000

    x86/boot: Fix data placement around __high_start()
    
    multiboot_ptr should be in __initdata - it is only used on the BSP path.
    Furthermore, the .align 8 then .long means that stack_start is misaligned.
    
    Move both into setup.c, which lets the compiler handle the details correctly,
    as well as providing proper debug information for them.
    
    Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 3099ff3ce15481b4f1536470cb87ac0ebf82b7bb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:19:43 2021 +0000

    x86/boot: Better describe the pagetable relocation loops
    
    The first loop relocates all reachable non-leaf entries in idle_pg_table[],
    which includes l2_xenmap[511]'s reference to l1_fixmap_x[].
    
    The second loop relocates only leaf mappings in l2_xenmap[], so update the
    skip condition to be opposite to the first loop.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>

commit a15b143a5f1c20dc6893bc3e50873e308ef61d87
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 16:09:08 2021 +0000

    x86/boot: Drop incorrect mapping at l2_xenmap[0]
    
    It has been 4 years since the default load address changed from 1M to 2M, and
    _stext ceased residing in l2_xenmap[0].  We should not be inserting an unused
    mapping.
    
    To ensure we don't create mappings accidentally, loop from 0 and obey
    _PAGE_PRESENT on all entries.
    
    Fixes: 7ed93f3a0dff ("x86: change default load address from 1 MiB to 2 MiB")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 06:16:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 06:16:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237127.411254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt1rO-0004wV-KQ; Fri, 03 Dec 2021 06:15:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237127.411254; Fri, 03 Dec 2021 06:15:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt1rO-0004wN-Gl; Fri, 03 Dec 2021 06:15:54 +0000
Received: by outflank-mailman (input) for mailman id 237127;
 Fri, 03 Dec 2021 06:15:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt1rO-0004wE-5R; Fri, 03 Dec 2021 06:15:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt1rN-0005WA-O1; Fri, 03 Dec 2021 06:15:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt1rN-0004gP-G6; Fri, 03 Dec 2021 06:15:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt1rN-0002jC-FZ; Fri, 03 Dec 2021 06:15:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=4fOkLk4v2v0Rt379muq++IKm+UzqnEYqg2CMp+CHssE=; b=H9byeUudR2Jj4Dr629xYWDW1TS
	rGP0y5JsS3PMhQGOf3TMMCqlCoQv5rzOwoxBbnDHeCR+PYZhMhwx65X8Bh1ShFW/XuQx4kEZIXY1t
	WsvHp1zl/QNaNou4B+mYYsTeDgRG89Q29KMflBCPLAh15vQenglWIDOeCD/8eTjgqVDk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167023-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167023: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start.2:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-destroy:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start.2:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-destroy:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
X-Osstest-Versions-That:
    linux=9334f48f567334f54101223012ec9d3b4628bed8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 06:15:53 +0000

flight 167023 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167023/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166990 REGR. vs. 166839

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 166970 pass in 166990
 test-amd64-amd64-libvirt     14 guest-start      fail in 166970 pass in 167023
 test-arm64-arm64-xl-credit1  14 guest-start      fail in 166970 pass in 167023
 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 166970 pass in 167023
 test-amd64-i386-xl  22 guest-start/debian.repeat fail in 166970 pass in 167023
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 166970 pass in 167023
 test-amd64-i386-xl           14 guest-start      fail in 166990 pass in 167023
 test-arm64-arm64-xl-seattle  14 guest-start      fail in 166990 pass in 167023
 test-amd64-amd64-dom0pvh-xl-amd 23 guest-start.2 fail in 166990 pass in 167023
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 166990 pass in 167023
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail in 166990 pass in 167023
 test-armhf-armhf-libvirt     14 guest-start      fail in 166990 pass in 167023
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 20 guest-destroy fail in 166990 pass in 167023
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166990 pass in 167023
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 166990 pass in 167023
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 166990 pass in 167023
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 166990 pass in 167023
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 166970
 test-amd64-amd64-xl          22 guest-start/debian.repeat  fail pass in 166970
 test-arm64-arm64-xl-credit2  19 guest-start.2              fail pass in 166970
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 166970
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166970
 test-armhf-armhf-libvirt     20 guest-destroy              fail pass in 166970
 test-amd64-amd64-xl-pvshim   14 guest-start                fail pass in 166990
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 166990
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166990
 test-amd64-amd64-xl-rtds     22 guest-start/debian.repeat  fail pass in 166990
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 166990
 test-amd64-i386-xl-xsm       22 guest-start/debian.repeat  fail pass in 166990
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166990
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166990
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 166990
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail pass in 166990
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166990
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166990
 test-amd64-i386-xl-vhd       21 guest-start/debian.repeat  fail pass in 166990
 test-armhf-armhf-xl-arndale  18 guest-start/debian.repeat  fail pass in 166990

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 166990 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 166990 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166839
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166839
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166839
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166839
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5
baseline version:
 linux                9334f48f567334f54101223012ec9d3b4628bed8

Last test of basis   166839  2021-11-26 10:11:13 Z    6 days
Testing same since   166970  2021-12-01 08:40:40 Z    1 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Chuanqi Liu <legend050709@qq.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  Diana Wang <na.wang@corigine.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Grzegorz Jaszczyk <jaz@semihalf.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Huang Pei <huangpei@loongson.cn>
  Hulk Robot <hulkrobot@huawei.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gerecke <jason.gerecke@wacom.com>
  Jason Gerecke <killertofu@gmail.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol@gmail.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kumar Thangavel <kumarthangavel.hcl@gmail.com>
  Kumar Thangavel <thangavel.k@hcl.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Manfred Spraul <manfred@colorfullife.com>
  Marek Behún <kabel@kernel.org>
  Marek Behún <marek.behun@nic.cz>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Mingjie Zhang <superzmj@fibocom.com>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nitesh B Venkatesh <nitesh.b.venkatesh@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Ondrej Jirman <megous@megous.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Peng Fan <peng.fan@nxp.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Remi Pommarel <repk@triplefau.lt>
  Richard Cochran <richardcochran@gmail.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Mendoza-Jonas <sam@mendozajonas.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <horms@verge.net.au>
  Simon Horman <simon.horman@corigine.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
  Tobias Brunner <tobias@strongswan.org>
  Todd Kjos <tkjos@google.com>
  Tomasz Maciej Nowak <tmn505@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Weichao Guo <guoweichao@oppo.com>
  yangxingwu <xingwu.yang@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3389 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 06:42:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 06:42:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237142.411289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt2GW-0000Ld-4Q; Fri, 03 Dec 2021 06:41:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237142.411289; Fri, 03 Dec 2021 06:41:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt2GW-0000LW-0S; Fri, 03 Dec 2021 06:41:52 +0000
Received: by outflank-mailman (input) for mailman id 237142;
 Fri, 03 Dec 2021 06:41:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt2GU-0000LP-9V
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 06:41:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16f8e077-5404-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 07:41:48 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-GfOO8NatOfqKnJUZVhENoA-1; Fri, 03 Dec 2021 07:41:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6669.eurprd04.prod.outlook.com (2603:10a6:803:125::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 06:41:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 06:41:44 +0000
Received: from [IPV6:2003:ca:b71a:8998:d194:2575:a6a8:6413]
 (2003:ca:b71a:8998:d194:2575:a6a8:6413) by
 AM6P194CA0096.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::37) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 06:41:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16f8e077-5404-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638513708;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Bgd2EIlSJpwXYbDVd+GAtaOdlLwkOLlaCmopKLRT11E=;
	b=ZWU64Ta+art83810+Qnq7qw4roz5+D+G9Ox/bD0edDf0Eio9SHJ04Yodkds7UlkPBgR96+
	rXgsUDkct+yQ5cmV5FGpB23xPxXY/XZvx4Sy9LVeLBccxXYkpWhALfDM0c7XDBXapLi2wG
	NOKLABxin1oB+EEcr1BLeLPINmUgshQ=
X-MC-Unique: GfOO8NatOfqKnJUZVhENoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T1mQHwNNG/SS6ugzI5Xda1cx+7tfMwQltxnMCN8QHRi/TvrA/p8hl2Mu166BY/rnMoKcvpVowSxOc6wYRoTNRmvNL62Fep5sp6zE8FXXJ1rlPsLYGm5HqfemnDxYQneNOFoW1zCv/vRryjbKLeyI4DvIsUlsOtcIkrN+qmCQmtlYzB/UNnYP62HhaM5sBNOblzDELAKsbhkkD1BjkqxgBeC9PseeJtT4XTghx165e6TrhUnd2Yv02Y+grWjhhCkgBMJHhESp19WF5qPnu6Rencc/HG9nP2O08U/B+Wbzq8nZGPA4+p5e4U3fbNz93ROSNwdIA9Z6WLfFFbPeCNOSHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YEC8C36ucthq1KVn9e+D1mZNV5qqS3WzoDe4M8yJiC4=;
 b=MoPaawlA5ne696cd1eMVvMDaRGWiyL35jhcVNPeDv0fZ+IO8ONf+2PNghcrBilxyMda5umtGTucPLWg5whTarabv1/+2tCGJBbtKdew5d6lUwajDJot6G8AU6AATMyz+oiQqHdfLyHX3FzBMSeCFiEzcHnbee4JyHXcTWs6VQ5ntVq8T1J8zjGhFT55eMh9kLNVUFs4JnoC7OETgz24RxXdUMZXitzbhYicJWiNkzQIyHNJ+WMpzS+yxJXjpzzNdvGl7D9sS4UnkSdczR16wjihP0CjD4913fWUS6Syw92ROQuTU0oI0bIKgubBy0eH65/pwdgW/tvdNYC2J+tjwWA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <259bb05d-b227-03e1-1342-a50241c51088@suse.com>
Date: Fri, 3 Dec 2021 07:41:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <f66b6403-13dd-cb05-7411-20efd7364b08@suse.com>
 <Yac7uLaQ1+YdCqtW@Air-de-Roger>
 <fd5ff1e0-88f0-3fba-4573-b007afdbb3a5@suse.com>
 <YadPLZqfN2pu5SeG@Air-de-Roger>
 <8b2c09f5-1f64-9754-17a4-936f1e496a82@suse.com>
 <YajiQeaPx7KcL0Tw@Air-de-Roger>
 <49991d39-f976-af50-b203-152564fa458e@suse.com>
 <09a1961b-2647-f25e-f028-9e398fa2c83e@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <09a1961b-2647-f25e-f028-9e398fa2c83e@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0096.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71255f5e-2f44-4375-e336-08d9b627f879
X-MS-TrafficTypeDiagnostic: VE1PR04MB6669:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6669088CA1011643BA1A571DB36A9@VE1PR04MB6669.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	u65JvZEgPJVt2q2ch+FtVRCaA2ujEzuzVdfFpstqKRMnBj3vQkXH1R1+EpSAXKd5x/fClT8wkpXKRSoojRYdkvxVQbwjGWO9EE4bFxho3FK1oEHgvfvn8qKy3GSxiaV9Pd+Q8cx2eoO6pInyZ2o0mgAYCJzlpvm4+wEKf6B3qyNFT9LxsfAPNJpaOlRcD2Ls5LVYaRn68p8ga4NbIYIEJdW3/TroQID0TL5OKheJRiEiVDkHYZO8Iyi9UeAPnpmMxxLtFcFIkq9w2tI2rrcObiluXSOy+x85C8ENf98IB7nMz32hKSSQsejp7AQ4EXyWNC5VeKDfDZtzpw++2wZx6nW77Jpjiw1qBc9UOzqukLcdLFtMvy22EpbzZsm9gAOjpONZQaMXeNBU4B+aIwgwi5UDNj0pDqRcRsOzOogsXfro/SykvmngdXodEh8GzEEZR/pCVnFSW/BONeGPBvrG/4wPBrlsEVrew4u3HaN/UIq1JHHxpic2YdX393T4UDzBS6poAf+GFXjGagFz9VKUR0HUaxm54hw1/zosf0wQu0xygue/GkTHyB5H1z/dPUtOTOnrxf51NGavUC+TUgxqvITx+wpWNF9g2lworRxkNr2pad0sXwfBYh2bvRqhKslkbonxB0ScMoyw8UypCN+UjE03kb03jroQWl87VFUBQMGcQAggWAJ0voJQpKbIuQ9TXa3U44sBHDe9WcsH4OrlKpegv+Ic7h5MNYtbEBtaUfQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(38100700002)(66946007)(8676002)(31696002)(86362001)(6486002)(53546011)(110136005)(66556008)(66476007)(2906002)(54906003)(83380400001)(36756003)(4326008)(316002)(31686004)(186003)(2616005)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UYOeB22lrl1+QennLpUKgVujXqjX7IwMrN681fDhziKWUy4NBfD8LHyQuBMT?=
 =?us-ascii?Q?tFwzXDi1snVrlOn5CctxA/3GLb+V2fscTfuTU7SM4Y/9jX3f2tMkKSse/zRo?=
 =?us-ascii?Q?Bsf52PTb32TIh4fHlxwHrMhOAWThNfdfGNXHByvQKmyxRkYLXoenQd0WfIz0?=
 =?us-ascii?Q?WP3h661neHBTPFkWhui7cJLLdDS0xheumvCdI/QfyJ5g0cs1qHVpJzLPqJYf?=
 =?us-ascii?Q?8ztHdABYXexWyLlak6BVvQVyScjfN/ufFdRo8JH7BoSwiZuRAQSvC19KXAy6?=
 =?us-ascii?Q?Y7xv52W+SLxkAqWK3GntZ1I2YwX5gH59qW1OklfirtLxzAKvPCw+FzwNPOJ3?=
 =?us-ascii?Q?WWZFa1/tiQAFraj4TclYn1xn/p/UJEJ6sY7Aje2DeefePpX9XBHxv9fT0YCB?=
 =?us-ascii?Q?sKeGR6iPALdLWNrt+5uVcTfK2KzWy+DAoZx7A1S0950lBhUFTWjLvOCu/4O8?=
 =?us-ascii?Q?Qx7qUOQW6giMolRJN961Zq3GDNBFfphexKTICWUI6RErI+QlYgxZqBhzvLlr?=
 =?us-ascii?Q?js7CWNOaw7dONqHykxwVAFM0Tzi164CTSi5MU8Hsi5u4zYbUllV9NzBhSu0R?=
 =?us-ascii?Q?truBWAs21W2Y9yBOghesdrSfOi5NbabAQiUON9eeECkHgGTgtK3HI7gdb7Md?=
 =?us-ascii?Q?spaoUZGSsbzdboip3k6PsXBuiIS0kTzptAvCsfZlYCYoPsjpXo6r18XL4Y2k?=
 =?us-ascii?Q?UnGuxzboqgprNZJA+AK5mkcSiakUm2FLiaIWwn2MJ9hBSFodmlazA40D1nmL?=
 =?us-ascii?Q?lMYZM2jOihZD2YMZgLGKVSRKck02huhgfhmVlxHhOVJD3CEMpcOGX598YmEm?=
 =?us-ascii?Q?w0mKtBhcDHEWy4E+4RgfoMEiCD0anSW7gCnv8d39cdbyL9EL8DZuteTuogXD?=
 =?us-ascii?Q?DuCjBLAZ11OtBl+C4mrRKimXj33POU2XEN/59sAaXLHmLVl1BEVHxdBlOctm?=
 =?us-ascii?Q?BwdFReHA87a6Vfwy6a/vbMiDzHM7HBkuj6LqbqG0xTM3wRfN/xHm6u/vp7cg?=
 =?us-ascii?Q?j6H68FbGntLm4ZVnR6UoSi/M0/02mTytzwWXv9eb8f4jPqiQ7AphAkYBWy8u?=
 =?us-ascii?Q?gEmBUV6ah4vvsCsSYcsE0ICerEtgPWkfapN2dsyOpk7mmumCb5rBDWQxvBf7?=
 =?us-ascii?Q?YvDWhMrqz+hk8BF+rQnx+kymEtUDfTq2Bdj+ASb7C83+5DF75xU/y9yETX8U?=
 =?us-ascii?Q?6q5VWqtNfkjsjPcBxhFglbPGsCTklIxzOgP7ER12Yl0o2ayEHAsXO8JJwKDL?=
 =?us-ascii?Q?GlVFWpn8p7RAuRTEMVBblf+Jscks+WkzNw90D1l9UfDLrUdaizIAGNo3vs50?=
 =?us-ascii?Q?B/eHkAFdeayxsKibS+C0nw3qROptKIo2uGeKCNtE8Y51+HlKNcNUAHCNb/km?=
 =?us-ascii?Q?qHeNnmP7IiT5x67tfVRDc+K1tXhNEBaFL4hVokspLqtEycP99FJ8l2439rwz?=
 =?us-ascii?Q?mrn1WoaU7jp3pEGvLNz7TeAae2xNcb4Agbmfu1oEZn5X6esphfaviFtUvvQV?=
 =?us-ascii?Q?pVJcA4P1wpH5d8I+waEkaqSeMfs59RvepZOrqs85ETYiw/5AFNFtPRl2aA9R?=
 =?us-ascii?Q?rS74xDhSt1B6cBD423BfCZxWCZmnMDUm7ds2mXZBTdErcDVyMB2r/gXv2g8q?=
 =?us-ascii?Q?ihWqSTjZKKCd9EmPpLxnMfQ+fa1IxYAcfRfolMPGAFyaQWi9v7+KMcUyDVez?=
 =?us-ascii?Q?fp6hi+4XDR4TMIj9Nf915isi+sY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71255f5e-2f44-4375-e336-08d9b627f879
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 06:41:44.2580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: URYljO/yPN85FlC16y6bMtJBAJ/BBZ/2XT64RPWG+Ypro8eUj7Yv4FvGuPdiEWmvEhm9DXL5TApH3Q7t271RIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669

On 02.12.2021 20:16, Andrew Cooper wrote:
> On 02/12/2021 15:28, Jan Beulich wrote:
>> On 02.12.2021 16:12, Roger Pau Monn=C3=A9 wrote:
>>> On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote:
>>>> On 01.12.2021 11:32, Roger Pau Monn=C3=A9 wrote:
>>>>> On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote:
>>>>>> On 01.12.2021 10:09, Roger Pau Monn=C3=A9 wrote:
>>>>>>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote:
>>>>>>>> @@ -267,44 +267,60 @@ static bool __hwdom_init hwdom_iommu_map
>>>>>>>>       * that fall in unusable ranges for PV Dom0.
>>>>>>>>       */
>>>>>>>>      if ( (pfn > max_pfn && !mfn_valid(mfn)) || xen_in_range(pfn) =
)
>>>>>>>> -        return false;
>>>>>>>> +        return 0;
>>>>>>>> =20
>>>>>>>>      switch ( type =3D page_get_ram_type(mfn) )
>>>>>>>>      {
>>>>>>>>      case RAM_TYPE_UNUSABLE:
>>>>>>>> -        return false;
>>>>>>>> +        return 0;
>>>>>>>> =20
>>>>>>>>      case RAM_TYPE_CONVENTIONAL:
>>>>>>>>          if ( iommu_hwdom_strict )
>>>>>>>> -            return false;
>>>>>>>> +            return 0;
>>>>>>>>          break;
>>>>>>>> =20
>>>>>>>>      default:
>>>>>>>>          if ( type & RAM_TYPE_RESERVED )
>>>>>>>>          {
>>>>>>>>              if ( !iommu_hwdom_inclusive && !iommu_hwdom_reserved =
)
>>>>>>>> -                return false;
>>>>>>>> +                perms =3D 0;
>>>>>>>>          }
>>>>>>>> -        else if ( is_hvm_domain(d) || !iommu_hwdom_inclusive || p=
fn > max_pfn )
>>>>>>>> -            return false;
>>>>>>>> +        else if ( is_hvm_domain(d) )
>>>>>>>> +            return 0;
>>>>>>>> +        else if ( !iommu_hwdom_inclusive || pfn > max_pfn )
>>>>>>>> +            perms =3D 0;
>>>>>>> I'm confused about the reason to set perms =3D 0 instead of just
>>>>>>> returning here. AFAICT perms won't be set to any other value below,
>>>>>>> so you might as well just return 0.
>>>>>> This is so that ...
>>>>>>
>>>>>>>>      }
>>>>>>>> =20
>>>>>>>>      /* Check that it doesn't overlap with the Interrupt Address R=
ange. */
>>>>>>>>      if ( pfn >=3D 0xfee00 && pfn <=3D 0xfeeff )
>>>>>>>> -        return false;
>>>>>>>> +        return 0;
>>>>>>>>      /* ... or the IO-APIC */
>>>>>>>> -    for ( i =3D 0; has_vioapic(d) && i < d->arch.hvm.nr_vioapics;=
 i++ )
>>>>>>>> -        if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_addre=
ss) )
>>>>>>>> -            return false;
>>>>>>>> +    if ( has_vioapic(d) )
>>>>>>>> +    {
>>>>>>>> +        for ( i =3D 0; i < d->arch.hvm.nr_vioapics; i++ )
>>>>>>>> +            if ( pfn =3D=3D PFN_DOWN(domain_vioapic(d, i)->base_a=
ddress) )
>>>>>>>> +                return 0;
>>>>>>>> +    }
>>>>>>>> +    else if ( is_pv_domain(d) )
>>>>>>>> +    {
>>>>>>>> +        /*
>>>>>>>> +         * Be consistent with CPU mappings: Dom0 is permitted to =
establish r/o
>>>>>>>> +         * ones there, so it should also have such established fo=
r IOMMUs.
>>>>>>>> +         */
>>>>>>>> +        for ( i =3D 0; i < nr_ioapics; i++ )
>>>>>>>> +            if ( pfn =3D=3D PFN_DOWN(mp_ioapics[i].mpc_apicaddr) =
)
>>>>>>>> +                return rangeset_contains_singleton(mmio_ro_ranges=
, pfn)
>>>>>>>> +                       ? IOMMUF_readable : 0;
>>>>>>>> +    }
>>>>>> ... this return, as per the comment, takes precedence over returning
>>>>>> zero.
>>>>> I see. This is because you want to map those in the IOMMU page tables
>>>>> even if the IO-APIC ranges are outside of a reserved region.
>>>>>
>>>>> I have to admit this is kind of weird, because the purpose of this
>>>>> function is to add mappings for all memory below 4G, and/or for all
>>>>> reserved regions.
>>>> Well, that was what it started out as. The purpose here is to be consi=
stent
>>>> about IO-APICs: Either have them all mapped, or none of them. Since we=
 map
>>>> them in the CPU page tables and since Andrew asked for the two mapping=
s to
>>>> be consistent, this is the only way to satisfy the requests. Personall=
y I'd
>>>> be okay with not mapping IO-APICs here (but then regardless of whether=
 they
>>>> are covered by a reserved region).
>>> I'm unsure of the best way to deal with this, it seems like both
>>> the CPU and the IOMMU page tables would never be equal for PV dom0,
>>> because we have no intention to map the MSI-X tables in RO mode in the
>>> IOMMU page tables.
>>>
>>> I'm not really opposed to having the IO-APIC mapped RO in the IOMMU
>>> page tables, but I also don't see much benefit of doing it unless we
>>> have a user-case for it. The IO-APIC handling in PV is already
>>> different from native, so I would be fine if we add a comment noting
>>> that while the IO-APIC is mappable to the CPU page tables as RO it's
>>> not present in the IOMMU page tables (and then adjust hwdom_iommu_map
>>> to prevent it's mapping).
>> Andrew, you did request both mappings to get in sync - thoughts?
>=20
> Lets step back to first principles.
>=20
> On real hardware, there is no such thing as read-only-ness of the
> physical address space.=C2=A0 Anything like that is a device which accept=
s
> and discards writes.
>=20
> It's not clear what a real hardware platform would do in this scenario,
> but from reading some of the platform docs, I suspect the System Address
> Decoder would provide a symmetric view of the hardware address space,
> but this doesn't mean that UBOX would tolerate memory accesses uniformly
> from all sources.=C2=A0 Also, there's nothing to say that all platforms
> behave the same.
>=20
>=20
> For HVM with shared-pt, the CPU and IOMMU mappings really are
> identical.=C2=A0 The IOMMU really will get a read-only mapping of real MM=
CFG,
> and holes for fully-emulated devices, which would suffer a IOMMU fault
> if targetted.
>=20
> For HVM without shared-pt, the translations are mostly kept in sync, but
> the permissions in the CPU mappings may be reduced for e.g. logdirty
> reasons.
>=20
> For PV guests, things are mostly like the HVM shared-pt case, except
> we've got the real IO-APICs mapped read-only, and no fully-emulated devic=
es.
>=20
>=20
> Putting the real IO-APICs in the IOMMU is about as short sighted as
> letting the PV guest see them to begin with, but there is nothing
> fundamentally wrong with letting a PV guest do a DMA read of the
> IO-APIC, seeing as we let it do a CPU read.=C2=A0 (And whether the platfo=
rm
> will even allow it, is a different matter.)
>=20
>=20
> However, it is really important for there to not be a load of special
> casing (all undocumented, naturally) keeping the CPU and IOMMU views
> different.=C2=A0 It is an error that the views were ever different
> (translation wise), and the only legitimate permission difference I can
> think of is to support logdirty mode for migration.=C2=A0 (Introspection
> protection for device-enabled VMs will be left as an exercise to
> whomever first wants to use it.)
>=20
> Making the guest physical address space view consistent between the CPU
> and device is a "because its obviously the correct thing to do" issue.=C2=
=A0
> Deciding "well it makes no sense for you to have an IO mapping of $FOO"
> is a matter of policy that Xen has no legitimate right to be enforcing.

To summarize: You continue to think it's better to map the IO-APICs r/o
also in the IOMMU, despite there not being any practical need for these
mappings (the CPU ones get permitted as a workaround only, after all).
Please correct me if that's a wrong understanding of your reply. And I
take it that you're aware that CPU mappings get inserted only upon Dom0's
request, whereas IOMMU mappings get created once during boot (the
inconsistent form of which had been present prior to this patch).

Any decision here would then imo also want to apply to e.g. the HPET
region, which we have a mode for where Dom0 can map it r/o. And the
MSI-X tables and PBAs (which get dynamically entered into mmio_ro_ranges).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 07:04:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 07:04:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237148.411300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt2cD-00038Y-Ub; Fri, 03 Dec 2021 07:04:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237148.411300; Fri, 03 Dec 2021 07:04:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt2cD-00038R-R8; Fri, 03 Dec 2021 07:04:17 +0000
Received: by outflank-mailman (input) for mailman id 237148;
 Fri, 03 Dec 2021 07:04:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt2cC-00038G-BI; Fri, 03 Dec 2021 07:04:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt2cC-0006Lj-1l; Fri, 03 Dec 2021 07:04:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt2cB-0007su-QD; Fri, 03 Dec 2021 07:04:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt2cB-0008Pq-Pe; Fri, 03 Dec 2021 07:04:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EOoRUVhsi8VDfBPD2QX1jzOEp0YjmlyfnuX/bJonkAE=; b=AeMld+SGEhe+LwbTu85XLD00af
	QDjSzYGEWvnDDR00AUJTbsQ+es+a/d4Mw7REt0KlJ4p4mLr/jFlgH6CXZLwWBQHEHT5cJY5/pObOG
	x6NZeaUHmF2RAQYkVUb2b6biUALo5ZVQz/dp0XRNa7gdFw/MXzFS0nPR6smMhiZ6+Nzs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167064-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167064: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable-smoke:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=05657c6d1821dfc4e9a618767a942b3555406046
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 07:04:15 +0000

flight 167064 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167064/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166958
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166958

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-xsm      18 guest-start/debian.repeat  fail pass in 167051

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  05657c6d1821dfc4e9a618767a942b3555406046
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    2 days
Failing since        166977  2021-12-01 17:08:21 Z    1 days    8 attempts
Testing same since   167051  2021-12-03 00:00:28 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 05657c6d1821dfc4e9a618767a942b3555406046
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:11:01 2021 +0000

    x86/boot: Support __ro_after_init
    
    For security hardening reasons, it advantageous to make setup-once data
    immutable after boot.  Borrow __ro_after_init from Linux.
    
    On x86, place .data.ro_after_init at the start of .rodata, excluding it from
    the early permission restrictions.  Re-apply RO restrictions to the whole of
    .rodata in init_done(), attempting to reform the superpage if possible.
    
    For architectures which don't implement __ro_after_init explicitly, variables
    merges into .data.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 8de86b5cd4353bf2cc415e4563f973f071b4e8a3
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:04:11 2021 +0000

    x86/boot: Adjust .text/.rodata/etc permissions in one place
    
    At the moment, we have two locations selecting restricted permissions, not
    very far apart on boot, dependent on opposite answers from using_2M_mapping().
    The later location however can shatter superpages if needed, while the former
    cannot.
    
    Collect together all the permission adjustments at the slightly later point in
    boot, as we likely need to shatter a superpage to support __ro_after_init.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c182e89d0b341d2efc930c2e1211d3e866c0effb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:01:50 2021 +0000

    x86/boot: Drop xen_virt_end
    
    The calculation in __start_xen() for xen_virt_end is an opencoding of
    ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
    
    This corrects the bound calculations in arch_livepatch_init() and
    update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
    with CONFIG_XEN_ALIGN_2M.
    
    Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
    dynamically"), there have not been extraneous mappings to delete, meaning that
    the call to destroy_xen_mappings() has been a no-op.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit ffa5d037c78fe175f31373deec0759ff8cc8d66c
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:52:05 2021 +0000

    x86/boot: Fix data placement around __high_start()
    
    multiboot_ptr should be in __initdata - it is only used on the BSP path.
    Furthermore, the .align 8 then .long means that stack_start is misaligned.
    
    Move both into setup.c, which lets the compiler handle the details correctly,
    as well as providing proper debug information for them.
    
    Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 3099ff3ce15481b4f1536470cb87ac0ebf82b7bb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:19:43 2021 +0000

    x86/boot: Better describe the pagetable relocation loops
    
    The first loop relocates all reachable non-leaf entries in idle_pg_table[],
    which includes l2_xenmap[511]'s reference to l1_fixmap_x[].
    
    The second loop relocates only leaf mappings in l2_xenmap[], so update the
    skip condition to be opposite to the first loop.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>

commit a15b143a5f1c20dc6893bc3e50873e308ef61d87
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 16:09:08 2021 +0000

    x86/boot: Drop incorrect mapping at l2_xenmap[0]
    
    It has been 4 years since the default load address changed from 1M to 2M, and
    _stext ceased residing in l2_xenmap[0].  We should not be inserting an unused
    mapping.
    
    To ensure we don't create mappings accidentally, loop from 0 and obey
    _PAGE_PRESENT on all entries.
    
    Fixes: 7ed93f3a0dff ("x86: change default load address from 1 MiB to 2 MiB")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 07:31:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 07:31:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237158.411314 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt32G-0006tY-A5; Fri, 03 Dec 2021 07:31:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237158.411314; Fri, 03 Dec 2021 07:31:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt32G-0006tR-6i; Fri, 03 Dec 2021 07:31:12 +0000
Received: by outflank-mailman (input) for mailman id 237158;
 Fri, 03 Dec 2021 07:31:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A+hS=QU=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mt32F-0006tL-Hm
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 07:31:11 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f715c195-540a-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 08:31:02 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 211431FD52;
 Fri,  3 Dec 2021 07:31:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EBE4C13C41;
 Fri,  3 Dec 2021 07:31:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id NH9YOLTHqWH7QwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 03 Dec 2021 07:31:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f715c195-540a-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638516661; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=bbebW9VqbAGjIhzBcVOgvBCL7jkvCGnbU+/r3lXqYe4=;
	b=vRjIUNVugAcBEU01a9cJv81fqoX5NmYO/yH+y8YrJLXsIKdTWdZ1kQOci6X5Pbf7B/Ku1m
	PA+voetAHQOs2+d0JrpoQBTwacRbStzUiPmbEh6Q4lbV7Bsmmyi4morB8pi1+fdTeeObA4
	XCCU0OOdJodoR9hd8dG6tc4qHs+CIp4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] tools/libs/light: set video_mem for PVH guests
Date: Fri,  3 Dec 2021 08:30:58 +0100
Message-Id: <20211203073058.10980-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The size of the video memory of PVH guests should be set to 0 in case
no value has been specified.

Doing not so will leave it to be -1, resulting in an additional 1 kB
of RAM being advertised in the memory map (here the output of a PVH
Mini-OS boot with 16 MB of RAM assigned):

Memory map:
000000000000-0000010003ff: RAM
0000feff8000-0000feffffff: Reserved
0000fc008000-0000fc00803f: ACPI
0000fc000000-0000fc000fff: ACPI
0000fc001000-0000fc007fff: ACPI

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/light/libxl_create.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index dcd09d32ba..d7a40d7550 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -427,6 +427,8 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
         break;
     case LIBXL_DOMAIN_TYPE_PVH:
         libxl_defbool_setdefault(&b_info->u.pvh.pvshim, false);
+        if (b_info->video_memkb == LIBXL_MEMKB_DEFAULT)
+            b_info->video_memkb = 0;
         if (libxl_defbool_val(b_info->u.pvh.pvshim)) {
             if (!b_info->u.pvh.pvshim_path)
                 b_info->u.pvh.pvshim_path =
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 08:14:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 08:14:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237174.411331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt3i3-0003sc-Om; Fri, 03 Dec 2021 08:14:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237174.411331; Fri, 03 Dec 2021 08:14:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt3i3-0003sV-La; Fri, 03 Dec 2021 08:14:23 +0000
Received: by outflank-mailman (input) for mailman id 237174;
 Fri, 03 Dec 2021 08:14:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wRzA=QU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mt3i2-0003sP-0B
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 08:14:22 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 029d6530-5411-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 09:14:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 029d6530-5411-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638519259;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=i87QEeii1EC1o3fP9Q5IGxKdrf13vNqO1UEfiItPbBc=;
  b=b4k344ymzck36Ap+YoBuu95wZmiNDNGoxTVLF55jTwzqIZhh+YivNVvz
   gwYBUFFY4PG0/3UdP7FmMki0Qi3G3hbrTuZfpJl68r/omjaQTFcdn/YRz
   Uaew0WVDxt+J4RUrN/Rac/QRb53uZiBlRrUxNMl7/5ELWiKnqtygle/nD
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: HneBJjHl/i6TCiZoOrqWPwkvFZk7xy8jxdLGR1WAUay1c2JuhjTfpDXNTnFR/agfE+ZBqmJcnP
 GIUmrf0fGlGnyWP/OdUulkie2Q6YRJo/fU+COzlS7tHjihM7tKLC8oj0UH5Z5bdZl29j4d9ltj
 epw66V4FO6TdnneZHXkK8Y2zkJu90Fu10+HXvdTIhX0KkdvvHmuQ+4q20Y07bEkSy8a8mOBGpu
 Lg+vxyhRY9NoHNHzDQouXpEb0eLo2tSGsvUjSrI5yPgiuunsbnptDvOineAOmH9/R4iRM/0Fml
 vYfZ+5rDuiLaQVgQRAw+1fjB
X-SBRS: 5.1
X-MesageID: 59577209
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EQBE7q4sMmKUNC8Tgeu5HgxRtNHAchMFZxGqfqrLsTDasY5as4F+v
 jYZCGvXPqnca2v2f9wiOdvl9EpQvpLUyYVhTAs+/nw0Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tQw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0
 cd9q56/RAQSMO7SlcsgTQN+DSx8FPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWZt2Z8URae2i
 8wxex5hTgb5OgZ1GA1QC7tmtreFtF3TWmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKg4eHMySz3yC6H3Eru3AhyTgQ6oJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S6AFFgaTDFMa+co99E7agE0z
 HmXktHAUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0EuRE48L/Lqdy4SsRGqum
 2ziQD0W3u1L1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHd7
 BDoeODEtYji6K1hcgTWG43h+5nzuJ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gBuMALYyP0Nv4tC25UNyjM5fO7fTgCfqqLBuein7ArLFPXlM2QTRD4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcys9pEMKLfcelEO9aNII6a5/I7NsrdNxsx9vuzJ4
 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hStT0fUEMQn61n49T5yo6atDJZI7caN+rL5ozOJuT
 ulDcMKFW6wdRjPC8jUbTJ/8sI09K0j72VPQZ3KoMGolYpptZw3V4du4LAHhwzYDU3isvswkr
 rz+ig6CGcgfRx5vBdr9Ye60yw/jpmAUne9/BhOaItRadEj23pJtLij90q0+L80WcE2RzTqGz
 QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4O/vZyfA/2elzYtRa8qyfGjQBDHu5aGvR
 eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRCu/EfxrJdvgfqC
 EuD9sMDZOeMMcLhVlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw
 Ps6vJ9E4gOyvRMmL9Kag30G7G+LNHEBD/0qu5xy7FUHUeb3JoWuuaDhNxI=
IronPort-HdrOrdr: A9a23:fqP7QqsGQoiUm4eeaChiLgX77skC7IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.87,283,1631592000"; 
   d="scan'208";a="59577209"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GveR0qKhUPRTwyVWeyVwHCakhmwepgtuYKCbjsUw2JBkJihGtJPb3rfmJ8X9+1LswFTq2PQD8eawhaMd1JaxSwJxO7g/OZ3xSSc9vtUHDgW+emthoxyDgcOaBexvpQfTRzHmBNGX4f+LQEH6gRmLACME/f5nE/NzQKbKFuaWrIanb6JbIzpInv5Rl0wq69ggcqJTH1ZLN0LV+NXr2AE/5HxazxsenGcO8QiFgmCitZHulLA4bY3L+XB0zxqNp/U+IJwxGlfDOmYWXo1LuxO5YUrClUbkuUalMx+JP3/aKt4BbFHdyyHjhTRJ3EYBG0amC1TexvoDBUkMKuj3Rq//rQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RMx1qjqyfji4cOHVe+tNycAJ87f9IqhiUbG6UWhSPvI=;
 b=BVGXtnhTnOp/8T0yf9X8FqyC62ZfjbWly5nSie3KOQlyn0pZ65nAh3RqRMPLdv6ZSDgC/llr3MWHGDTbCH2CK5quuhvDjVG7IVKtSElSr7sS1tyX0a1uJvYqhcFMeIZPkjywedOl6lonCCjGU1FVK1krzVlPv2euyLWV34KMh2d8DKcWglI40HC4304CQC2mlDeEU6m4d+9Xb0VXOdtKzXxU6nLmJdU5oRuSz8VSW/mdM7lzexvjYHIp5BakFQWDnFQb0hbJ+yjmO1AWPk1f56xa2e4CGQ9TYzGd6CM4E1awjV7xqDbIdJkNgkeOrzKpEXswPAYtIHsNzvBsMgWw7A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RMx1qjqyfji4cOHVe+tNycAJ87f9IqhiUbG6UWhSPvI=;
 b=RLXwYmCL2C+LNFp/lsnfB9qKhy8UzEEpsMqj3woa9ju0YFPCKtuvwBsO1iGcwaY9wKBvbnNLurEpkKIOex6q7QF2/4Kxu45R/53ALaaxyZcujq+E4+de9cTIWR8Kd5JQJCJiAVvZC6KMUB5bNm8XPoukOo0O/8jDNTeFEAHmY80=
Date: Fri, 3 Dec 2021 09:14:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, Wei
 Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH] tools/libs/light: set video_mem for PVH guests
Message-ID: <YanR0IkNarIyoDA1@Air-de-Roger>
References: <20211203073058.10980-1-jgross@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211203073058.10980-1-jgross@suse.com>
X-ClientProxiedBy: MR1P264CA0117.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:50::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 256a51e8-1e7c-479f-cf4a-08d9b634e429
X-MS-TrafficTypeDiagnostic: DM5PR03MB2777:
X-Microsoft-Antispam-PRVS: <DM5PR03MB27770E4AB8A8D77B1C70CA2C8F6A9@DM5PR03MB2777.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CEol8k9tlkZw95o7l8AnFg1xtn6e+vxisoa1ODk8NROFKYFLpr7r29hQ8sMWlSDgWbSXV+RznV2MXg+4irUPyDhfhR9o7VI4zZz3xXPlMO1I7rLEIA5vhMvU2CanA6pPPL9hHDTaYU3uKGppIg3uBUV5CyZj8rhh6XoOpFZnEd1c2vzjXy6UJlwpjTtk2aOjS4wLGGSoBbCp+GZLnZdaO2AgY7RisHtQTRMGgFy0n1pJ4wKJ2ZPwE/4ieLMc6MC9psFLMd9MTFFPrQhMLIzGKmP4EMXhggGDTecuf1NRynYq7eRLB0ElxLRUTc9l3aDiLgHKn5Hmf233SJwYIRL8r7kv257i+cnSuodR5vbRqyt+W7IJJTyGgsnKqsi38SIdGffDQ7tvdWld/LOn3chab/opMXGjvbfhJWRQhKTChM7w27NPntF4OwotQd7gTDx5/lowCGVf3jXnp43QORTRwLVb0qsFzELreBQfL2U7e6W3mE3qOrQfmD6oxy0Tfw/o/sIEOYCk874gyoSJE/xb44mJzn8i11Cjcfab0ANHywdYnNl66BSIIucQCXO8kv9Ve7vQD4lBro4egHjdo4oOY+QjUEjy3/nzNt56hCYUQWQycELhTjgCxx99YNBa3JopyfU7ikIddZugQZX8twklkw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6916009)(4744005)(54906003)(26005)(186003)(6496006)(4326008)(508600001)(5660300002)(8936002)(316002)(2906002)(956004)(82960400001)(6486002)(66476007)(85182001)(9686003)(8676002)(66946007)(86362001)(6666004)(38100700002)(107886003)(66556008)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjU0RjNYS3doK1lDMXExbXlpdisxbEhDY3pUWENFVkNlQlJyVkwxc1dtb0Vm?=
 =?utf-8?B?N3FCc080YmxvVjNIU0NHTDVMNzhETHZMQjAzS1RQUThaN1VGVmozeFNyTVBt?=
 =?utf-8?B?NThBQlJHM0l1amJBVzBhUWpPUTU1QmM0djNVVFJPN3d1VmgyUjc2QVNWYlgv?=
 =?utf-8?B?eENlekhQblpKM1lGbWxiTTVnWTBXS0xhMllPZ3NYdU1qYWsyVlhLWElKREdq?=
 =?utf-8?B?ZzVQQWZJRDJwNHVmUkxOaHNZdXZURHBwd2dPaFoyS3VYY002cUR2c3BPVWVz?=
 =?utf-8?B?dXFWMlFrZUlvYTcwSjArRU05TUNoU0orV2RBZDJaU1pTY3lHbTJNeS9FR0tU?=
 =?utf-8?B?SXd6MkswYU5oK05EbCsrZkdDVHRmbEpEbkpOcHVENDA3VVlHcHBmYkx3d21y?=
 =?utf-8?B?S2hoZ1pMdVhmOGJHTU5aT2xaTzIyK2VTdDVSb1Ywa3BzT1BaWlp2empTTFhy?=
 =?utf-8?B?YkJDOUdBUDRrd3dad0tWYU5JQ2dlN1QxdG9Fd0ppNWpnb1pjRGpLeUN6c2JO?=
 =?utf-8?B?dllnZGJPcjVwclloZEt3dkxNUStpNUpydjEyVXNWQnBZM3U3d3J5L2JQdit5?=
 =?utf-8?B?UThCam5oRWI1dFl4cHZsWU5JcVlSWWpuUkcweVRBWG9vQm1Jb1FsdDg3UldG?=
 =?utf-8?B?R3pGdUdjdk1FWk1KMHYrMVNJaGJ4Q1JiMm1YQ3R0Mit5SFU3WnI0TGh4cm1V?=
 =?utf-8?B?bFcvYkVDbGQ1NlZxV24zQ2VMT0lWZDQzTnhNck5kUmxpTlpNRHplY3JQY2dn?=
 =?utf-8?B?VUdUMVlScUVqWksxVUkzbXc5aHZySW94QXhSZzk5U0hEaFdMYWRTK3VTRU9x?=
 =?utf-8?B?VW5DRk95aHlnWTBrVnNUNStUdVNoSzJIU0dDbVMzQkQ0NVcvYVhVT2g4NjBy?=
 =?utf-8?B?NXpLK1M5dDlmU1FhY21wOGVlaHgxQytianZxckZTaGZXTjJySVNQRUQ5cFRB?=
 =?utf-8?B?bXpLN3R0d2ljeXpnVktxYVE1S1AxUzN4VWFpN3dFeHpVR0JCUDIvZmplNXBy?=
 =?utf-8?B?UC9YVGFWUU5PeWZSekNnOGJFT0xQYkhOS3Exd0lJSEk3eUF5YUhmL3M0elJo?=
 =?utf-8?B?YkhWMjQ0SnFPK2l6Z2RpNW41TWdkZldnajdOaUMxbi9RS0VGclFvV1gxZmtY?=
 =?utf-8?B?cTM3MFFTNnNiNEx3d0NlYUpHVEdienhiWERuck4ycFpRa0oyUnVuc0FabzRF?=
 =?utf-8?B?eHhUUktzSGJFMC90aDB5R051V0lnNk0vak1nL2FTeldGUGhmUVliT1h5VHdv?=
 =?utf-8?B?WXRjVEZ1RlVRanB6NjFNM0ZVT0JlWjltblprZ3lvSllrZDJtYjhZV0hpOGsz?=
 =?utf-8?B?UzU2MG5GQlZoT1hyTHZiWjU0UnpKcE9rd2NTZVVTV0t4UnZOdTFYcUxFQm1V?=
 =?utf-8?B?eWFXUzJHaXBZQlBTbVpmU0c4MjlHSlF4cEZTVVpSM1c3cTBURDYxLzlFSGp0?=
 =?utf-8?B?M2lZdjlqK2JkNHBYNkY5R041ZG9MenlwYklia1MxK2Jxek55RmhvTHR5OWh6?=
 =?utf-8?B?MlQrY2xYNmVYbzAxVVlrRjZKNGNIb25zVFVjeWtuQjlHNXFtUTdZU2g4d3Z2?=
 =?utf-8?B?VElFaUpNVWwyNmhaNVh1Q3Y4OTVFNjU2ZTRyRGZLOFVheUttOXlYbnJFaGhr?=
 =?utf-8?B?clN5bEVVNTBtWmRxY0h2S1BTOHREN1NxMUpQQzVtVkUrQVdmTW9ERWxMcFdB?=
 =?utf-8?B?TmRBOG1iT1cwNEwyeDczc21iaCtUd3QzZ1dnMmt4V0p0QkxvdkNoaUxPOTls?=
 =?utf-8?B?SDJkVEM4VTFhRWNJV0xCKzlkRjFwdDgvazhxYWxmTjc3dlc3R3JTTjhqc1NW?=
 =?utf-8?B?M002ajVNOTNJWUZOUkh4TTJZSWdOaHJuZnYyQ2tIS1FxMWFGcnJPR0NqbUhU?=
 =?utf-8?B?QWp5a3VSS3lUSFB0K0JxTWtQNGROSEpYWGIzbDE4WmQzcUQzWkROZzhuT0ZC?=
 =?utf-8?B?SGpDOGlPOFcxVy91ODhETnQ2Z3hYU0QwY1lIYlpuZTUwVU5ZNW0waS9MNnpP?=
 =?utf-8?B?eFF2ZC9ISUo2T1Z6UjBabnlmamw0VjExQW16WDlMR3JXYWFNc0h4SzNwVnl2?=
 =?utf-8?B?MDIxc0twS09qSDNwWFlOeUEvU1hRTVcvM3pnWFcyV0oxNGJ4RGlJbjVUWTVx?=
 =?utf-8?B?NWNZVXladE14R1dIMVJ5d3hUa3Jqam5EYnFwWEU0alZKRm9RdFBvMlNndnc5?=
 =?utf-8?Q?9kHE9Qyy5o5voSrkIE9ALeE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 256a51e8-1e7c-479f-cf4a-08d9b634e429
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 08:14:13.3479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /t+n7IgPjW4QsEup6xoSUUgcMzt88RtWaQO8HnJOLd3KueTHDJX1QaDMmGKIZ7hU8pUIc1FsB7cKQ4gbu38yMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 08:30:58AM +0100, Juergen Gross wrote:
> The size of the video memory of PVH guests should be set to 0 in case
> no value has been specified.
> 
> Doing not so will leave it to be -1, resulting in an additional 1 kB
> of RAM being advertised in the memory map (here the output of a PVH
> Mini-OS boot with 16 MB of RAM assigned):
> 
> Memory map:
> 000000000000-0000010003ff: RAM
> 0000feff8000-0000feffffff: Reserved
> 0000fc008000-0000fc00803f: ACPI
> 0000fc000000-0000fc000fff: ACPI
> 0000fc001000-0000fc007fff: ACPI
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 08:30:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 08:30:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237184.411353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt3xM-0006Yh-9o; Fri, 03 Dec 2021 08:30:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237184.411353; Fri, 03 Dec 2021 08:30:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt3xM-0006Ya-6A; Fri, 03 Dec 2021 08:30:12 +0000
Received: by outflank-mailman (input) for mailman id 237184;
 Fri, 03 Dec 2021 08:30:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wRzA=QU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mt3xK-0006YU-Ll
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 08:30:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38905f1c-5413-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 09:30:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38905f1c-5413-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638520209;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=SUQqD9FnClH0FVHKazvAcSxaS1OZN3i/43vDKb95iE8=;
  b=MvQqfIwSX7S9NrhSNQ3eshM7tXqh+NTityQJE1cawA8QVDN3+thV61oo
   DciEoMDHPG0KtknDCbE130VFtziD+lH2peXqHstk7yVQyQkvSHYAzs7uj
   GnaqwGQtPlyUVOQbK2fuQgBKSePGed5qDbbYrL/jtG/OMrAfygrwlJC9U
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: bFpl2axIIu1/eTEsOhM3Exb3q75MdhaxvuKV9H1DvK99Z9uLGmsoZ2TUb7O8W3dKNyhaGIh4Ik
 6h7MGUY0ORq9gM9VjrVoLCb9MDxS9IyiymxovqXVKGlpwfPLprHOcTp0r5IqqeUwyP8zwkUTGw
 5nvbottfDw0Ep3ZepSleXFZTbl67B52nOmfVlMAAylaqFfzJErKoHsOxigzc4hQyOtvkT4pYMn
 T3v1QCzHZZiKL4+/mBQpyiUQ6OxaM7yGxuJVqMny9ephnSqnB+5VrsEzc0gogS6j5K99EVzf9+
 mYpoSaggPS8w9VSJBqPiqbWD
X-SBRS: 5.1
X-MesageID: 59204273
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UciwZ6B3YP4HuBVW/8Tkw5YqxClBgxIJ4kV8jS/XYbTApGwi0DJRx
 zdOXGCEPPvbN2akLdsgOt/lpBsEuJXcmINmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Ug7wIbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/hQSptNNXy
 8l0nKepRCkYZYTMnOofakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvSQvYMCg2xYasZmGKbnQ
 ck+SDZUPRn4ZUJdKHkeGosPpbL97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibdpRtlaVo
 CTB5WuRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO+MLyCqO7KnI2i+iH2Uqf2VoaNgotvZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WsQWmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQSLhRqjBNzAJrVkg
 JTis5PFhAzpJcvS/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43aZZYJme2O
 BGI6Fk5CHpv0J2CNvQfj2WZUZtC8EQdPY69CqC8giRmPPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/rdROcAtUdCdjXvgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:/TTNf6yO8MA8vYrfXe6gKrPxtuskLtp133Aq2lEZdPULSKOlfp
 GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM
 Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurAYccegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13zDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa3e
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0IXEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4Fi1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusqsq+SWnqLEwxg1MfguBFBh8Ib1K7qwk5y4OoOgFt7TBEJxBy/r1aop8CnKhNPaWsqd
 60dZiAr4s+PPP+W5gNc9vpcfHHeVAlfii8RV56AW6XXJ3vaEi94KIe3t0OlZWXkdozvd0PpK
 g=
X-IronPort-AV: E=Sophos;i="5.87,283,1631592000"; 
   d="scan'208";a="59204273"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=esnWvM3lzlAJ3ulfW3jx7j308nDG2JF8vTCQjXTB9yuY+EJLjReSJ7j5cjdXwwmChto0mEfC/Z2KWQ449zdxie8AujgMG2B+z6Bg5bnqvrJOZ5ummV4kzpdr0JV45Q/9SofeoV9iD17pHjIkOfeYekSj+8qjqhTcHsCXgENPzcM8VAmEeaoIyf+PHt2OLHVvKEX91V3HZrlacLP83ZUionE3VrQz9coTB1NtU0ESqOYTOvn7zAvEOyF7snI76x18PnXrjWWHFMyFGxSihaSE7Zl5QeElG/vj7KDB0r5Bg5TXf50BBVLQlnb8Y8gsdTXEX0+iRaz411NFmTDQu/PQ2g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gg5PdOez0qlAzTY/Sk1COVEe1ZdvJYcu+JsmreuD4lA=;
 b=jKVuFu5/+0tlDHu4DtHWHJKiJN4NlIKW9ewCRcsuQMVjP+Hts+4WuSX845uDbTcuAAnJiofBP/hEgcYXgf9wZx3cLXuHjetu3xNfmSGZ24Jz1sGxCfeA1wIeFVtlNbgUxVXPanBNtnkGSpW0VjgW1l3rij0feBdpIEZql7Xj7XdOTqFSgtbykMytVuGbSBNL+lcSaMAvlA6czaDuokJf8s5oL7EyAXgxrFg6NlVeDP5RcQCQpq6UMGuyyUrnJrkw3ojwZD1I/LJOdKNhSLneJzZEm8v8oyV5x2HOqmwWWHQSnqh6PBwItldi6+JxpjBrey8rcHitut16cyBFQuq+5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gg5PdOez0qlAzTY/Sk1COVEe1ZdvJYcu+JsmreuD4lA=;
 b=O9IMywkolPhGeAkys8NL5xwWhAifomuroAsHXgCvVSnsS1cqmg2qx+7ujPkzHmWLxv7aEKAq5as0R4PJ40dd2A9yHYuuqh5VLbzSUMto4jc3epRras1RrDIpKw4cQGavKjsTKlz7OQGuuW6jubJwep/UtR0Yq4KHzfmjr2XMuI0=
Date: Fri, 3 Dec 2021 09:30:00 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Message-ID: <YanViGSnE+uMwA9S@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
 <YajubFeUclKtpqV2@Air-de-Roger>
 <03dbb062-002a-3770-61c4-4f93de73c0a0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <03dbb062-002a-3770-61c4-4f93de73c0a0@suse.com>
X-ClientProxiedBy: MR2P264CA0067.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::31) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2cac0a1-cb87-47b8-7e1a-08d9b6371b17
X-MS-TrafficTypeDiagnostic: DM6PR03MB4060:
X-Microsoft-Antispam-PRVS: <DM6PR03MB4060D400926CBDD605DD3D908F6A9@DM6PR03MB4060.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1I1kqNlOcd5poolKiozgDuJPuru6ZeC86WK/UujRi7zcbKch9GnwLaWlbLFSvjDH+mcNB4h5gLzeJeC47PBuV07xxrW1T7D77EbZALsr+amqdgR/F7IOTbp4n8GCnFUQrZT31Gr35ER7nYH3Q3NjqDNBXvYUrIVILgu1cY4s0nCCsdJMuzsZeho55evM9DS/EUKiadZ4t0/9Ks7BMwZNE6J4RBxGGeJ0rlR1EgscgOSj4SqKWPJ5FbRBmYo8znT2dxTHnq7CtrghXquFoosTDCvNHBbdZus4mvHkUQ01PbB3Uyc1El7dFYLE880HKU7xXthLTgKq5o5K8c21s81sNBOxSHTCg5f8oQ9WaIQhFjZEZg3Kt5jSXp1H1F9VQUWdYjxHhHQCOPsFG5lkMfV60keyMBgZScSHdpnD9wvRPjtJhXSs9Tnp38XIi4iOgS5rU8Gs9+LjLKZsL6lEKAq0uQt7rrgBQENpgn9opbWXpNG1SQ3Ld7MlK8X7UKol8pAXnlx/ZOcOOUgC/xXnWV2aMlgvGroqBtVTOSWVYzzKlcoHwRgfvuSCr49wmoijVWWLamzQBQOfBr7Mtxi9IfYpc3RUOcBIoqmNBSIRuxF2FGNuq1r7P8k3GssOzocFfSn3/DAFq7MoFi3HEuIVASJ5fHLzrFafKzM4f2ztgRsue5Q27daLeUkR04fuN8RFtG3g3rvmvphNxlpRQ0b82BfxyA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(86362001)(9686003)(4326008)(5660300002)(956004)(83380400001)(66556008)(66476007)(66946007)(82960400001)(38100700002)(54906003)(316002)(508600001)(2906002)(33716001)(26005)(6916009)(85182001)(8676002)(6486002)(6496006)(186003)(53546011)(8936002)(6666004)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uzl2and2SWFVUmtDR3FHTDkwNzNiR3JFdWNlOUJ5RjM2WG5JTXU0TGFLNTA2?=
 =?utf-8?B?cUFKNHdmdHdpUHFoRlF1aGxadGJLc1hBWUUybS9RRisvR3pOZUdGRTN4WFN6?=
 =?utf-8?B?d0puZ3ZaNXA1V0FPT1BDN1d5bG5KMzRISmJ0Y1FvK2l4SCs4QXh6aGJUNVp1?=
 =?utf-8?B?MFo3TDErSGpMenJRRW5Nb0FWYkRhdmpNYXZPeisvcm5sQmg2eG5rU0xKSEZv?=
 =?utf-8?B?d1BNVVpVUkRtMnVHWVFiSnE4RWxIcFBFL3pGQ2lrNHIreDRaZ2JoZVpHT2h0?=
 =?utf-8?B?MU92VTdHUU1LUGMxU0h1UEI1UVRtK25jTHhlTGI3WmtXcjMwMXRtSXZqbE9H?=
 =?utf-8?B?MDc5Ylo5NGE0czBmcUhUV1F3b3E0Rzh1eWNmRkY0bFplUUMzRGZ3alNyNnJp?=
 =?utf-8?B?YmF3L1hFeVRLM21KbU5RdEIrVXJ4NERwQngxanpGQUJvUDgvbVRHVnNuRE94?=
 =?utf-8?B?Y3o5M2Y1aVlWQnJJbnE1Rm5IaTB2NGtPTG5MSm9ZSVdrYW5RVm1HMFY5ckRI?=
 =?utf-8?B?eU9CbmxEVUZRWTJBcFlLWlQwQkMxQ2U4bTNrSkdHa3RYSVk3TW5VYjM3anN4?=
 =?utf-8?B?aXdHc1AwbkhKdFV5SXI3eVRWZnYweGFZWWJtbW5KaStFMm9QdVdtT1ZBU09l?=
 =?utf-8?B?MUIzVDJDWFA5RXJUcG9lQ0JMb3huRm0vQWh3UjMrTFQ3Vm82bk5UUGJDSGlK?=
 =?utf-8?B?Y1NaeHpRcGN6Qi9ibVJXdnVZbDN2S2JqWlVId3QxYW1zWExJY2hQUzlIM0s4?=
 =?utf-8?B?ZHZRRWFwYlNmb2ttYy9tUjd4ZXhuTGRQTHVORFNrL2hqNzVCQnVqYjBOUHM3?=
 =?utf-8?B?U1RqUmtBeC9RV3dmTlhwZXhNSURaTVJQODFwRzBsWWhiQUh5TjhwMzdYb1I2?=
 =?utf-8?B?WnF1cTg2Mi9IMmpSOFBueVB3dTFTYTVxcWZCTDM1bWlhVGM1dFN5VmNXWWpW?=
 =?utf-8?B?cE9pVUxWTTE0L25Lb3cwdWhZZlhxWk5PZHZlWE9TSFkvdGhwcTFXa29DajNO?=
 =?utf-8?B?ZkdoTk02MnZBL3libi91aTdaWVhlTUMxV3UreUU5UXJQOWF2b3hjY0NQYTdP?=
 =?utf-8?B?V296U1JYSFdudm9ocmV2b3hEU2VpMDBoUXA2OG83NytOTlhIR2Z3YndKMjU4?=
 =?utf-8?B?SVNmSDVjdzViQ2tBQXVLWStXMWlyYTRWTWJmaWlOR1JjWXVHaXZuLzBoeXg4?=
 =?utf-8?B?Ti9yOFc3SnpNOEtBNU1NcWR0NGw3MTVFMDdPbzFKcUYvaU00LytjVHN5VE9R?=
 =?utf-8?B?Q0lyK29lQU1DZzRTUzFrdFZiczUwSDB1MFpxY25EdnhEaTQxYzEzYzlqWC9S?=
 =?utf-8?B?Y0FOWkVZRnZKUjgwa0x5MUNZNGVBVkYvV3h5OThvdmFieEd0Z1dTWWFMWXZT?=
 =?utf-8?B?SXFySGo2Z2d1SUl0UFVjZ3g3ckxpaFdhU0hVbDVSTHhXcXBMRzBDZUJiTVor?=
 =?utf-8?B?NVRxeEhxclVTanFQK0xZbE8zaWI3ekIyejJtK2JlYW0rNTBYcG4zSGJDbUV3?=
 =?utf-8?B?RWp3Ym5aeGhvYTNzY0lSSHpVbU5zSjVTVS9ZbENaSHJmSnZyMDA0TENXZ0lK?=
 =?utf-8?B?ZTZDa2Q3WnMvdXZhMnpLTDFVNFRhR3lpaUR4VlRKalRzZG9OeDgya1FFZmRv?=
 =?utf-8?B?a2hJelUxVUpsRldWaDlMZXc5T3RuaHJiMkVySkNJVnFlMEFSSW8zSGFKdmhB?=
 =?utf-8?B?cjg2VjllQkQ4UkYzei8xbmNiNy9lMDRINFo1TjYrWWFieHUzVnNTOXVhS21a?=
 =?utf-8?B?N1NxcUtMNVFIbHA0c3VseEdjQk9GQTI1MXo4MVNXWHZKMUh2aFpLbkpHV0lE?=
 =?utf-8?B?ZEttZzQzSGdrUG9pemJDOWNoWmM1YWp5M3NPdVc2S0JRZmhsZThqVFpmam5j?=
 =?utf-8?B?NGJJK0FaVzJMOXM0eFNqdFA5empvZ3cweWpCa1FNSG9ROEhiaDd5WGRwSVhQ?=
 =?utf-8?B?eW1EV1F2akdXTmVPVDJLV3NOVzdzV0g0VHMyWWlIUmQwK3I4eEl6MnNyN1pl?=
 =?utf-8?B?a0pVdVJUNEpHUnBHU0hGRWRNM1NoVHFLZTRrcjJMQUpXMUpqalU5S0ppdVBo?=
 =?utf-8?B?QllGMW5EYS9iQm11VVc5Qm51cGdUZXgwQm9wYWpVaUdTL1NaRDNyWEtJR0g5?=
 =?utf-8?B?b3ozd3N5NTBzVmo0UnBRMHY3MDl2YUJ1N0Z3cDFZQk13SmFKWCtjZnk3THNh?=
 =?utf-8?Q?MWpjuf5Vx8LZ1gzefu1ecH0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2cac0a1-cb87-47b8-7e1a-08d9b6371b17
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 08:30:04.5817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yPpIcdb5b6Fog2kQ23P1rl+vPe41E9pKP5SwUeqON5XI/C2ZvqzniUsoAiCz4uk9152RVSx0ni2sz+CF5qTW3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4060
X-OriginatorOrg: citrix.com

On Thu, Dec 02, 2021 at 05:10:38PM +0100, Jan Beulich wrote:
> On 02.12.2021 17:03, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
> >> For vendor specific code to support superpages we need to be able to
> >> deal with a superpage mapping replacing an intermediate page table (or
> >> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
> >> needed to free individual page tables while a domain is still alive.
> >> Since the freeing needs to be deferred until after a suitable IOTLB
> >> flush was performed, released page tables get queued for processing by a
> >> tasklet.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> I was considering whether to use a softirq-taklet instead. This would
> >> have the benefit of avoiding extra scheduling operations, but come with
> >> the risk of the freeing happening prematurely because of a
> >> process_pending_softirqs() somewhere.
> > 
> > Another approach that comes to mind (maybe you already thought of it
> > and discarded) would be to perform the freeing after the flush in
> > iommu_iotlb_flush{_all} while keeping the per pPCU lists.
> 
> This was my initial plan, but I couldn't convince myself that the first
> flush to happen would be _the_ one associated with the to-be-freed
> page tables. ISTR (vaguely though) actually having found an example to
> the contrary.

I see. If we keep the list per pCPU I'm not sure we could have an
IOMMU  flush not related to the to-be-freed pages, as we cannot have
interleaved IOMMU operations on the same pCPU.

Also, if we strictly add the pages to the freeing list once unhooked
from the IOMMU page tables it should be safe to flush and then free
them, as they would be no references remaining anymore.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:04:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237196.411371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt4UH-00022R-38; Fri, 03 Dec 2021 09:04:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237196.411371; Fri, 03 Dec 2021 09:04:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt4UG-00022K-WA; Fri, 03 Dec 2021 09:04:12 +0000
Received: by outflank-mailman (input) for mailman id 237196;
 Fri, 03 Dec 2021 09:04:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wRzA=QU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mt4UG-00022E-4j
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:04:12 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f991dd57-5417-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 10:04:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f991dd57-5417-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638522250;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=sokpsrmaO7ZRE31tarz6A6PGCSHdtg0H1RxpW3WijVw=;
  b=eW3NexdwsXjGV9Cod418b5MA5O1KI+28iJrPmnmYyolSoZWbRw3CzUgo
   6NLahsnL5qv2vGanzAVZSHk4ndq/M5b58rAhdb/Bf39XN9m3HRoSkY1yt
   oYew/q1jCblrSrHMo7zcu8PR2EfIjJvZXZY8Jz+okzEx6OZGACZqwIABS
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qqRnkPFvuRsHRAXyYFZ5dwLfOjRXbbYOympJQt9/7LfsKqbcEXZrrN+mF29qNeefkb+eunaf12
 GZbEQxAj/7T54dJnlfABdnMU+ko5gP+Mc6AMIwcAAZ/8qZQPhcZ+5n+CTcYrze6uO6tNSykMwV
 ujQXHl4lS02xVk7lGUlFdTholW7lWeI7OqMBh5+NskI1/5eMbokOeruB0HIpY2RACxTS1rMifz
 1mmFwfevU7rrR43wGtVuksDBudZb4vDocVyr1sagM7CBxQjuV+Hs8RdFO6Imn2vXooFrvmph4A
 DseDg9OZISf9nJZO0FslP9eK
X-SBRS: 5.1
X-MesageID: 59205949
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Kcmemqh91P3ruSlxgyuBWWYFX161uBcKZh0ujC45NGQN5FlHY01je
 htvCGDVPKyMajDzfYp/bYmxoBkFu57SyNFlHQQ+rnxnHigb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw24Dia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0XvJacag4mEZHulfkCAyRpTS9/YJBJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t15oWQKeCN
 qL1bxJFdwyQYC9uJ2wYGbwwpMbxmmP/KR9X/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0AdNaP84z5y6x6KfJ/FakNzYKT2N8Z4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9zABbvzt68owGOlor+p5
 yNsdy+2tr9mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ldBs2aplcJ2S4O
 ic/XD+9ArcIZxNGioctPOqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WeeG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:uDkBw6NzwDH2uMBcTyX155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrVQseVvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4F6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1ojegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKve/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdZ11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtRqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW3HAbgcYa
 lT5fznlbVrmQvwVQGagoAv+q3hYp0LJGbGfqBY0fbllgS/nxhCvjwlLYIk7zM9HakGOup5Dt
 L/Q9BVfYF1P78rhJ1GdZU8qOuMeyXwqEH3QSqvyWqOLtBzB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.87,283,1631592000"; 
   d="scan'208";a="59205949"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J9TdPtrTwL++mRb4i4Y7AYj+tFdw85fhLjcf0cA6CGXxCHMVhu7IPAnJSUMVf6jv0aqZ3DcFbPtLQxBz/3iJNgzPQznpabtqEt6E1sa10oIIYk9XWm/Y2yRKXKZFGsNXe6riRR04NIQV8Gumlq0xnVi/BFetOL8z9IMop6E+TbnCiUBSP68t01Y2JmxQISpDAkyjpVbKKuHjeASwFL/T3oJplNXRPa6kGJWbRWBA/YzGmkKX8+/IvhcCHWNSM8RWRRrgoN0v5I8V+s7XGIo5cOvgzFjJ+9yVLAy83Ug/0fp8dFSKTQ7iqtzDyjddfkS5yZnAOUL7M15wu+GcnR0iqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WI9aRrIp3kYZU1ve/fDRSPtNCQR2u1WhLMi3rVoaJtw=;
 b=gCnu5ahXcY2Ub8O3R8nop5Yl+pICi2PVKuR3DAshqy1A2tUmf6e3vk6TQdkHG7xhzo59fjEk0B5nlD5hzBVFP0f9QJ2ABMYEHOYv/a8u3MNaUyVsNCtL1+h/D7lMo48nJ6o+xelsCtxpAarqNnND8nM1sciCEqK2XB8JrGsJDeiLnt3mfMD/rpwZIZLxtOX4lFGN7DzmsONW/wypYeuVRGcXSnsfcMkhzNMQH9mq/wboksX4DVv09rQg8zTda/tv5j5pkUO1WXPBW9nRdOA2yYe6MFLvhFdbIFgDh445o4UAn4nc7llpPbl+ZlNBCQaMvwjzSzdmOtbnEM/dTYYU/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WI9aRrIp3kYZU1ve/fDRSPtNCQR2u1WhLMi3rVoaJtw=;
 b=ukLVsQbigpT7/LiEqU+n8TXqAQGIQUC/+hbVubMP67wLmiv/3s6sd2sOCknrYPRS8JB16FiKDjClUwWbzA9WiKiQObqZ2fFuEsyzAdeBtdyHPlF6jXTXfCtT5+RjXfZ12ARpjZp/w46m+f5G08iykVUX53ZE5UeZYEqubOCzvHY=
Date: Fri, 3 Dec 2021 10:03:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 10/18] AMD/IOMMU: walk trees upon page fault
Message-ID: <YandfTCG9nkWoyrz@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
X-ClientProxiedBy: MR1P264CA0065.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9fff2895-6c2f-4f48-c01b-08d9b63bd94b
X-MS-TrafficTypeDiagnostic: DM6PR03MB5340:
X-Microsoft-Antispam-PRVS: <DM6PR03MB53405849773BC497B713A1008F6A9@DM6PR03MB5340.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:820;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mcrE6OCNrd/BHomZYfFfsMaUfL/fv1IuPpfiaIGAKz4mlmjq9t8uWspjtQa181kcmOtmTJF5Lj0kNF1ZvtAKGH7mZ7t+LIJEePqVuK5XYCjpYStMnVIUX3m6HzzInReOPIbkWLccMhOUCi1MDrasfI4TZveWP+JQGTbYlf7cs4hlfmChfZe2ll9ERjtv1f2eY38JNjfeJCkgORYHMBYPoLgfuIDmSAT+w2B9wb5Kdb6xBFXgxJ2SRjJBM1AN62DFRJqLiCA4gts6R5sI5NVcc+4GS75rZxCWwM+zEiT9yoWusXVhjFej0aFRQxHvLjPn/6sRQXJ9vO5Z8pc8ua5sh2pTxc0PQVFHJnOwOdz7v9o2zgU8XQJXBmXZnzQKA49NRbZzIZcnUtPMmsLZ8q0Yv0/GUpMPektRXo6pvPXKwF4luUv0Uw/Lg3n/RJkQcoQC+xWxjZlKuXB9n3f+1lOl7OgY03JmAIejCzK/EU1ney4vtMDz+dobfJnFVRdwr3INtNFBgCVW3fT/4gfhPJffJhCkSUeCxN8TJfribbkJ7Z7TuxsfXORHGg50ziYxhwl4V8io7S5w17Wa6lsSI+TAVs8uaCoULYFLIagFXNbWBrc2X7EDfgfysglPICe/95QwqElFqKeelYkA/HfLS+rzVg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66946007)(66476007)(66556008)(4326008)(2906002)(8676002)(6496006)(9686003)(33716001)(316002)(8936002)(956004)(82960400001)(83380400001)(6916009)(6666004)(26005)(6486002)(54906003)(186003)(38100700002)(86362001)(508600001)(5660300002)(85182001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkI5bjVYN1RvV2gvbTQ2VUlwNnUrV3JqUTNjZmh2bGNtR3VUOHg1WlFPOTMz?=
 =?utf-8?B?NDV2Mi9hS2F2VEVDbnN2RzRuTWZDZEdtOUVJSUdURFA4OGlzMDJmd1pRSFVK?=
 =?utf-8?B?NUowZDNBcC9jT2VtWnZycWpYc2R3QTZIZnpmVHYvaTRTZXhxMFhrbk9ya295?=
 =?utf-8?B?S3I4VnBrbW5EcTZQcGVFZGdUZitVRmhtUVhETDJ0QnNNMzN2VW54Rk1lTmMr?=
 =?utf-8?B?ZWJZNUtUcWRVSjBOb1JxTk53bXh3T0pqZFBtUHdJa1Frazl1WlBLTit1Z0tP?=
 =?utf-8?B?c3RWUnJXankwSEpUNi9KVnFPYytUdnM0SEx1d1o4elF1MktFTVNVSHZLbHIz?=
 =?utf-8?B?dGFPSzVKelBjN2JGNjVkcHhjVFg5M1lvNHRtQ3NCK3BLR0UycmVNY2NpNDQw?=
 =?utf-8?B?Ym1ZUTJqRmZldElwSU03UndZcnZmQmZYTmVlTjdUZmpkTmNDVWxmcjIrbEZH?=
 =?utf-8?B?VnZrbm5iZkVQVnZqc0xsbGQxaGtMUHd5WWRkQWNZQklOMWQxZ2t6MWVhdjZw?=
 =?utf-8?B?OXh5R0hCOGpxZkpEZDVRaDU3cC9FV2lrNk1zWU92aHRHd2JEWmY2QldmdUpL?=
 =?utf-8?B?TjZ6Rmp6ZHRZTkIrb0MwS3VRcUhkdnZxYzBxbHhWaisxWjdJT2U0elljRFlQ?=
 =?utf-8?B?aGlxak0xekRsek13L2VQQ3pNckR6YWtzL3piQUlkTnJOTVhQZy9NTlN4cUFS?=
 =?utf-8?B?OG1zQ3FOU3VGdnZlSUlGR3FQRW1UREpxZXZoZ3dlVUZEdXBEMlk3RU1HSjBX?=
 =?utf-8?B?bHc5Uk9GNFAzMGtRYVE4Z2ZkUC9MRllqY1FCWEtmMFNPRTZ4RHBTTVlYclhF?=
 =?utf-8?B?R0hsQlJEMXRYa2t3cnVTSmk1azlQQTJxa2tHcUV4SHhnandodjdmdER0N1hC?=
 =?utf-8?B?dW52azROMFhQUlVMRnVkNzE5UXh2bWhFNVZuemtneXR5a1RDRnM2eXBnNDlD?=
 =?utf-8?B?UmJ2d3YweTVabjk2VHN6N28vNENJd0IwZ0RUdm9QM2tPZTNjUFE3TWcyL25N?=
 =?utf-8?B?R1NkUTh6c3ZVQWt6cDMrN2NPTE15UlJHaysyY0NVKzZlcDhMczIxdklYaUl3?=
 =?utf-8?B?RVVIejdTcjhzN2NqTmRrdmJ1aWF0a0N1cXBjODZBdW1nbHNuZVEwS0RTOVVu?=
 =?utf-8?B?cjgrZWQvcG5RL0pMampFMzZ2SmhrdDBLVWU0RzFES2VEZFhpK0kwcHBhZWpx?=
 =?utf-8?B?SGNRZVMxWm1Zc0J3OUg5OWM4c2lMRXdNYzBrakFDWVV6YUpFSlJNZ2VoSm0r?=
 =?utf-8?B?Q3l3TXR2ekppS3dpNmQ0bEYyWkQwSFhZTnE0QzRrQWdhNVFEb0k1ZTVSdUhX?=
 =?utf-8?B?SDBLOUhiWjQ5THoxUnBDNGRUMjZwVCt4elF2TlQ5R0xYRVNWMU0rdFduWUJO?=
 =?utf-8?B?Z3dGQXRVRFRQcVdkTGNoMlozcmtCVmF1ak1KRHp0RHBvNno0aHRrMkZ5UXQr?=
 =?utf-8?B?OVM0YzBjTjA2U0xaOXpEa3hoeEppU1ZsQWhMbTBVOG5FWUZZYmRUc2FLZ0pB?=
 =?utf-8?B?ejNhSlZaMWVjR1RTc053OG1NMjNtT1NmU1NyN0U0czB1T0QreUs5WW8xdlJE?=
 =?utf-8?B?b3ZLcWVOTDkrN0dSNHlqRDFnZXFhSFF3YzdzNFFTZGN3S2JDSTM1RGoyUHQ1?=
 =?utf-8?B?MDRkclk3S3B2MlE0RXFGVGc3eWl1RlhLMGNYKysxaDJ2dDRqT3BxUUFzMnl5?=
 =?utf-8?B?Z1pJb1lMTHNZR0VQVFRHSUNpMEN4bEs3R3J0bEJPTC9ReG01eGk1TitLVVp3?=
 =?utf-8?B?WjVJTkQ3S1orVS9LcVNYR0NUdkoxbytXaCs5NkJhSnh2SGNNUnZ3VWdiTVlK?=
 =?utf-8?B?dkp6T3RZdGd1YzhVejhYUExmVVdCYUdheVRjQ0I4ZjZsejdpbGF1NHpqWGJW?=
 =?utf-8?B?QzJZMHB0UnhSa0l0bEFPYXVwQTM0UDJ6TUJqeDdCanB6RmtIdGo1T1RRWHA2?=
 =?utf-8?B?ekpNdWpFZU42SU52STV2d29rSExIT0tDRElLcUM4cTh0VjlMdHQ3OWxKc2hR?=
 =?utf-8?B?NEpWZW9FY1RTZzlsWEsxKzFySUxFQ2Vxc1RHSU44UzBlZzZxS0IzR1h6UG5V?=
 =?utf-8?B?NGMzUjgzSktlRWJ0RXdsTWMzRmd6bjB4clFwRm9lb0ovNndkWGhqRTNqNDd5?=
 =?utf-8?B?R1g1QnEzcm9JN2lpdE9aVlk0dUp6N1VnMVlKUjByT1dsU3lYVGg4N1JndGll?=
 =?utf-8?Q?3K0vBoYM5Ds5kRD8uGHJ/LA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fff2895-6c2f-4f48-c01b-08d9b63bd94b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:04:01.6204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bnr2KHWD05lFM08+KrhlyryhbhTb9AVHXxpcOO1R/tdLvjEaOKDeFy0KMqFgQvDDzocVNn6GeUUqK+2hKRocdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5340
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:51:15AM +0200, Jan Beulich wrote:
> This is to aid diagnosing issues and largely matches VT-d's behavior.
> Since I'm adding permissions output here as well, take the opportunity
> and also add their displaying to amd_dump_page_table_level().
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/drivers/passthrough/amd/iommu.h
> +++ b/xen/drivers/passthrough/amd/iommu.h
> @@ -243,6 +243,8 @@ int __must_check amd_iommu_flush_iotlb_p
>                                               unsigned long page_count,
>                                               unsigned int flush_flags);
>  int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
> +                             dfn_t dfn);
>  
>  /* device table functions */
>  int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -573,6 +573,9 @@ static void parse_event_log_entry(struct
>                 (flags & 0x002) ? " NX" : "",
>                 (flags & 0x001) ? " GN" : "");
>  
> +        if ( iommu_verbose )
> +            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(addr));
> +
>          for ( bdf = 0; bdf < ivrs_bdf_entries; bdf++ )
>              if ( get_dma_requestor_id(iommu->seg, bdf) == device_id )
>                  pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -363,6 +363,50 @@ int amd_iommu_unmap_page(struct domain *
>      return 0;
>  }
>  
> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
> +                             dfn_t dfn)
> +{
> +    mfn_t pt_mfn;
> +    unsigned int level;
> +    const struct amd_iommu_dte *dt = iommu->dev_table.buffer;
> +
> +    if ( !dt[dev_id].tv )
> +    {
> +        printk("%pp: no root\n", &PCI_SBDF2(iommu->seg, dev_id));
> +        return;
> +    }
> +
> +    pt_mfn = _mfn(dt[dev_id].pt_root);
> +    level = dt[dev_id].paging_mode;
> +    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=%"PRI_dfn"\n",
> +           &PCI_SBDF2(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x(dfn));
> +
> +    while ( level )
> +    {
> +        const union amd_iommu_pte *pt = map_domain_page(pt_mfn);
> +        unsigned int idx = pfn_to_pde_idx(dfn_x(dfn), level);
> +        union amd_iommu_pte pte = pt[idx];

Don't you need to take a lock here (mapping_lock maybe?) in order to
prevent changes to the IOMMU page tables while walking them?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:39:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:39:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237214.411387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt52D-00065X-Qe; Fri, 03 Dec 2021 09:39:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237214.411387; Fri, 03 Dec 2021 09:39:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt52D-00065Q-Nk; Fri, 03 Dec 2021 09:39:17 +0000
Received: by outflank-mailman (input) for mailman id 237214;
 Fri, 03 Dec 2021 09:39:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wRzA=QU=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mt52C-00065G-6V
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:39:16 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id defd6222-541c-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 10:39:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: defd6222-541c-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638524353;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=2yYJtmb5fIZLYeLXP4GPlhnLFpMAAP+Aw4Cc/FQkjU0=;
  b=WSKXwF+NJceKDzQGb4Qr8Ca3eTHicwLEo8tiqqfecjgM96wt+Gx7mOlo
   cYErDauVnDp63Yep/GJDamjaM5yPFE83jeIgJzXaSb8ttzAqtk8PJkTAU
   2Op9peJRAinS/2AECTRahLnU4IpZJ6qpqfSgmSLo9IABzqPaYr0LyTjBA
   M=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: LQu59hm8dc4Syty5TuTLB+HGMn8aK0deJDzAE+2itFVTR8GX9wv0i2MNbzqubARhT3CL98JXb5
 tzIMz5wFBJzkDmIVChdyyMwx3FmUo/Kw3fWimfpbo7/klyQGGyZR5IA4AIGseG289Bix8QFFTY
 ICgUL98k1ZAzmN1ZznN1D1mIbhExXV5Ov6q/9G785gPR/UPup++dCIifs6hGPDXgdikojN94T2
 UbBr7xV9BDLpaojEOsc8e8iHfkl6TPj3212Y4E2VnbWFq7AvHOfzAkFdjPRt1mEJqwm8ZtOTrT
 8LNjuNQb1PbeyyOfacyoXhYk
X-SBRS: 5.1
X-MesageID: 59207896
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FHTVBaqADlvp2Xfz8t4taPWiMkteBmL1YhIvgKrLsJaIsI4StFCzt
 garIBmAbKyINGWnf4hzOYjj9EwG6p6By9RjTgduqSg0RCND+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx24DjW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYK2bRwsJo3OpPUiUQRdOQwmbZJ9x5aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp0fR66BN
 5tHAdZpRDXhZRR/HGYZM4o7krupjFP/aiQHjU3A8MLb5ECMlVcsgdABKuH9YtWXQe1Fk0Deo
 XjJl0zmBjkKOdrZziCKmlqujOLSmSLwWKoJCaa1sPVthTW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJuQRRDXh/iTC5ERFHYMNTatqs2lh15Y4/S6HAEwfSyZhauA3i80rQBYHj
 g+2pOzAUGkHXKKudVqR8bKdrDWXMCcTLHMfaSJscTbp8+UPs6lo0EuRE48L/Lqdy4SsRGqum
 2ziQD0W3u1L1aY2O7OHEUcrat5GjrzAVUYL6wreRQpJBSspNdf+N+REBbU2hMuszbp1rHHd7
 BDoeODEtYji6K1hcgTWG43h+5nzuJ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gBuMALYyP0Nv4tC25UNyjM5fO7fTgCfqqLBuein7ArLFPXlM2QTRD4M5/RfLgEzvhkZ
 MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH
 yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcys9pEMKLfcelEO9aNII6a5/I7NsrdNxsx9vuzJ4
 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hS9T0fUEMQn61n49T5yo6atDJZI7caN+rL5ozOJuT
 ulDcMKFW6wdRjPC8jUbTJ/8sI09K0j72VPQZ3KoMGolYpptZw3V4du4LAHhwzYDU3isvswkr
 rz+ig6CGcgfRx5vBdr9Ye60yw/jpmAUne9/BhOaItRadEj23pJtLij90q0+L80WcE2RzTqGz
 QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4O/vZyfA/2elzYtRa8qyfGjQBDHu5aGvR
 eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRCu/EfxrJdvgfqC
 EuD9sMDZOeMMcLhVlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw
 Ps6vJ9E4gOyvRMmL9Kag30G7G+LNHEBD/0qu5xy7FUHUeb3JoWuuaDhNxI=
IronPort-HdrOrdr: A9a23:aNRfyKOYMkWuEsBcT13155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY55as854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nI/iTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Svl
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfpGoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DPeiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6Np+TgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeTf003MwmM29yUkqp+1WGmLeXLzAO91a9MwY/U/WuontrdCsT9Tpe+CQd9k1wva7VBaM0od
 gsCZ4Y4Y2mePVmG56VNN1xM/dfNVa9NS4kEFjiamgPR5t3cU4klfbMkcIIDaeRCcU18Kc=
X-IronPort-AV: E=Sophos;i="5.87,283,1631592000"; 
   d="scan'208";a="59207896"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CvnbX1atvOPhKVwTQ+kiH8pxcjHfar+ImpD5d7bnV5+ZkseA9i7KDQxk0T0/G+azqZZE+2DRL9y9/kOXAuDdgUi2QQUZ7o8OIlkaLh0tWEV07NIdGBHwGYW8mKQHZ/rnKl3plQGWuU4WWS/B9wl5ipxujKmTumdATBhdo0LHnsFk5so1dj56vEwoLUyzsmj55PSKavzOQlcFjshBbD/+acTov6SBcRMmy7SbQWtVuyU96RsrxSWmNslC/WBuY6vnuZxOuGtEgMtDi1FMfctwsG+1Jha6gnGES27eHdKEzf/zG8pARdjbt42MWAHTGHaEMmj+V/BMGv8E9sXRQ8IoMg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=pkBAKchbWbpbkskL+7dSQZsjum5Q2M8NmmaKhbouStU=;
 b=GYrDyty0WF3EJajxx5xuXlwzLRuGlF3V6e3UpWp1a6o1I7ubKVZSnz/0EsfU/eZBQdP3YDn72PclmotBhUXbeXO9KTfioABgCAMrNFC2HZSceyb1wYSKxqBRe49gtjCuclPoQtruQEPSsKsRqdrXjYHb9q+Fsbf+00XeQ69+y4kgKeBdoThPRIwQBGTH0pw87ymzc5421+VU2Jqmh317RcAF7+0RLUcw4aRW9PInqLWxJdeb0vyN8g7ms9vl6H9C0oYsEp5SGBBP9KNfOHsoMaLX70jQxvqR4T7D18QPsLLuuC4bwvxCx/L/BQ0LPygWcq1bKWeN6JjXm2PYnFDuvA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=pkBAKchbWbpbkskL+7dSQZsjum5Q2M8NmmaKhbouStU=;
 b=ZUsoqtj4GN8b3qfeWV2wjBVYr6YipH/BSMi6PJNyjsWIhHM/3XaCPTpFDIDUWH39v3CZOVgdYTxutmMxkahGu9wmWKZcYCpjMxkv8fg35dwOtApRi/qBBYYwrHyG7Q/tA+r/LuwDFbk3juWfVeIrxuh41FpePyYbiW139x2eU6c=
Date: Fri, 3 Dec 2021 10:38:54 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Message-ID: <YanlrrHQjLDWh5fY@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
 <YajubFeUclKtpqV2@Air-de-Roger>
 <03dbb062-002a-3770-61c4-4f93de73c0a0@suse.com>
 <YanViGSnE+uMwA9S@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YanViGSnE+uMwA9S@Air-de-Roger>
X-ClientProxiedBy: MR2P264CA0156.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 140934da-041d-4715-42eb-08d9b640baf4
X-MS-TrafficTypeDiagnostic: DM6PR03MB3580:
X-Microsoft-Antispam-PRVS: <DM6PR03MB3580F3158DEA160AE0BAEB448F6A9@DM6PR03MB3580.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YTFQcDu+aUYp4/b/eiALVgqToQKduc2eJ3Ay2EEvpACRITCYps3upmHjEFzJkIObC0GwVh3jwzoc04qCGHGlE92q1wKpcC7DAo/IFx6RlggF+gjailAdrQdx9oU02YYLaDbLaKzuy51Xabupxve8JYqMwb0gEtlivnMuUuN/KaI26V5iEIwr3UAPwvEfUKyQxPpzBYStHlqLoSuchMfUu0Y2fdbDPsFBq/vuWRmN70HhD6s/GUCeCoPShYP1lmRyE0lgevwaaqrnQgIgTy4RhTkbR4iWesRAJngd7xOih6Wo0mW8fpZkuCt8vHisU3844h6oJwX5R5dyP3EteU3v7MRphHszpsYxOWLD+Sa/nxLhtHb0iISD6d3pq/cMnPlA8vconuvq+qbZvKhAbcM+nnKdxpuiZ8IGwPHwqWEOi+Kmr9trbd7n0413roKDG+0QtFjHl7pGp9z5CGPdy39FHwHT6wYsN72Jg59epflukrgxLIZik946oZeL+TwlvBSX249mRPa6XxahRfGEq+ymlLMdpxoLc+15nXHFbKG8UsQFJa8EOxJxuAsvjoLwL72KnrhcZmFsLHyz/S7BcH2C5112T/M7Qi6LJ82Rknuduj/c0plPh0l+HqZ649aiUHlsiWpB38uiAWcLGGeAJzwfVA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(8936002)(4326008)(6916009)(2906002)(6496006)(6486002)(8676002)(33716001)(956004)(26005)(186003)(5660300002)(53546011)(85182001)(508600001)(66556008)(82960400001)(86362001)(316002)(38100700002)(54906003)(66946007)(6666004)(66476007)(9686003)(83380400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dksvSEozR2p0UVhkZ3lMYWx2RmQ2dzVIQVlDMWI0K25QQXovZVVnWjg2aEhu?=
 =?utf-8?B?TkhlSWYxTzlHZDl2Y0dPZU82R2ZtYmVFUEgzOXdFbGRRekhJQ2hldXVmOTEx?=
 =?utf-8?B?R3NSbkhCSmJXUHMxY3JmbTRNT2YyU3Jzc0lVS0lFc1R2WHllTllGKzNxbURZ?=
 =?utf-8?B?QkpvSFByU3AvbEtVZ0VYOTJvU1ZHSkRYeGZVU3ZVeldzY1VmZEFweEE2QkhZ?=
 =?utf-8?B?ajIrUEU2L3V1SG5iSUhXbWNsdTFsa05TbWVOdkpqODMwV0xwL1FYT2JmaXVY?=
 =?utf-8?B?anI3MFZXbzdBNUlJNjV5SmNFaXB6L3RHZVpJOE1tL29JNnpWL2FaK2xmbEM4?=
 =?utf-8?B?ZmhvWHE5WDhoYlY0SUI3U2ptSnZhakNxUjJBY01KUE9RMndMYlEzK01UWEI4?=
 =?utf-8?B?aVRzSkdiT24xc0RIM2NCTll2bm5SYzg4ZmVla1ZFVlB3d3FDMWxIeTVYWmRR?=
 =?utf-8?B?S0lWeUo5K1NOZ203UThPUEZnU0tScGZ0K2lhTzIzdjFpRXgyV2k2ZEJESSth?=
 =?utf-8?B?d0h6c043ekZZWUJ1UW9jMURFWjlBRzZDY1hoRSsyS29RR1p3UnQwRG4zYk8z?=
 =?utf-8?B?TlJPWG5mTmNZcjdSMS9hYzhTcGplaVdBcFVKTnFRYzdsRVJocUJWVnkwZXNz?=
 =?utf-8?B?bWN4eWNoaW5aV3FnK3BLM0c5MUtpYklxVVMvYlhoMVVlcUthc2lYSzdiKzN5?=
 =?utf-8?B?dE94bnlFdzRobjRTR1lkdHE0eGsyYVpUOGZZUjVaaEc1SGM4eXV4YXp1TnF5?=
 =?utf-8?B?VHZEbjhCcEhhbGp6bkR5K3haSGhQOGNHTk40dmZzcWZjK3cyRXk3S2tCUWlZ?=
 =?utf-8?B?MEtVdmwvWnV5aVU3d0dYcnRzSWppSVZBcnBiQWFoTXRXU2syNHpNRExmUUd2?=
 =?utf-8?B?VE5ZVlMyUUVoNFlrekFVbnpCZ2djVFRLMFBHcUtxTWNQb2FTM1BtN2E2S1hy?=
 =?utf-8?B?dGc4MHBwc3BjRFRzQi81UG5wYnA1NmduQzZxT1B0R1kwTFNvMUJsK0F1UFRa?=
 =?utf-8?B?Y1BCOWJPWFRuUk1OZmdQQVEyUUZKTEsxT2l2T2lPQXE1MHl1LzFxeEplR3F1?=
 =?utf-8?B?eEgwWHFXWmdEaGlVZmxMckhOd1ZVOEg1UEFtb3BtQ2dEQndqdW96VFJiRzJY?=
 =?utf-8?B?QmZ3blZYeDVSU2wzSUZNV3VyY01FZFBrTzg1cjdMeWhWQ2t3Wk4rekdlMEFI?=
 =?utf-8?B?bFhUSThQVUxGWXhXMlIwSU1nWXJpamFVWTh0VXBqQ0xnMmZoNDdzQW1iR0dy?=
 =?utf-8?B?aTNxSStiOVlYTHZleUp3VFdhKytmUjFGVktJaVNzaUh6aGhNeGxsTnFMN2Yx?=
 =?utf-8?B?WWNFdHlRSTlTeldGRTh2OGM5R3U0YkRxbGZmVEVVQXBucnRqTmxPSitYQnI5?=
 =?utf-8?B?NDVJRmg3NmpNcXhWQXVxcGU1R2pSbCthaDd4RGFtQ0txK1ovNm05aVZMTFYr?=
 =?utf-8?B?ckk1N2N4VDRudkxVamd6R1BPbmhiZVZFMm5MK2tCQXhxRkZVdTU0RU5vRjBm?=
 =?utf-8?B?U3dTb0Q3citmMnlaZUJnMitPZEZ2S20rT2MwUW5pZm01RHA5V3RWNEZ4ck8v?=
 =?utf-8?B?OE1rVDM0WTBKK0UwRlQ5eVA1YmZOcVNkYmR0bkxaSVJRNEEzVE1hdEdkK2dn?=
 =?utf-8?B?YncwQXJMR1VXTWtBRkpmMFpVeTlzRUc5UGhHOW41TzF4RUxRWWtTam5LMENs?=
 =?utf-8?B?aHlJTCtFWWs4Tnh5Y2RIdkpnRzZTbHR5R014U2VXYkdRbEw2ajZUTGN0Y1FE?=
 =?utf-8?B?enhPY1k2THV3WWYrcGNRd2w4TDRHRzcxekJPS2V6Y2hzY25Pb3UrZXlSWG9w?=
 =?utf-8?B?cW1HVEtYWENFcytXaHVpTjFOaUVvdFdHTXVwczNrYnEySXcrWjg1elIrZUdx?=
 =?utf-8?B?ZmNSS2ZxQnYzRjlzK0VZYVQ2U3l0Y1c4QlczQUVSYVNHcVFZMEVJN3JNTS81?=
 =?utf-8?B?aDM0Wmc4NUtFOUI3QXdGQ0psZ21oWUhubThpdHY5YUpCU1BTNEtENElHYUNU?=
 =?utf-8?B?RVVpK0FsYWxJNUZ4QzRoajYxdXhMdFdQdTMwaU16amFsdVRwZ0hQSitJaVBF?=
 =?utf-8?B?Z212Mlh5VnovNFRhTzlXTGFWR2t4b2lpK25pL3hIeWM0L213MXJHZFVVb0Ny?=
 =?utf-8?B?WVh4RGs0TDk5TVlwM0RIdytnTzdkQi96dHppQkJmb0l2ZUhoNlBXNXI3Mmkr?=
 =?utf-8?Q?jo6LHz2Jy1g88lnovgkGm08=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 140934da-041d-4715-42eb-08d9b640baf4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:38:58.2518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2gIeIDfxjwnYbIp4/Lv1t+ms6e8AGFCyb0W+bY34rQ2VkZ57BnTiB3JYg9b5qrGOe6M8PpRMEaPzvx5jWf7c/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3580
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 09:30:00AM +0100, Roger Pau Monné wrote:
> On Thu, Dec 02, 2021 at 05:10:38PM +0100, Jan Beulich wrote:
> > On 02.12.2021 17:03, Roger Pau Monné wrote:
> > > On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
> > >> For vendor specific code to support superpages we need to be able to
> > >> deal with a superpage mapping replacing an intermediate page table (or
> > >> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
> > >> needed to free individual page tables while a domain is still alive.
> > >> Since the freeing needs to be deferred until after a suitable IOTLB
> > >> flush was performed, released page tables get queued for processing by a
> > >> tasklet.
> > >>
> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > >> ---
> > >> I was considering whether to use a softirq-taklet instead. This would
> > >> have the benefit of avoiding extra scheduling operations, but come with
> > >> the risk of the freeing happening prematurely because of a
> > >> process_pending_softirqs() somewhere.
> > > 
> > > Another approach that comes to mind (maybe you already thought of it
> > > and discarded) would be to perform the freeing after the flush in
> > > iommu_iotlb_flush{_all} while keeping the per pPCU lists.
> > 
> > This was my initial plan, but I couldn't convince myself that the first
> > flush to happen would be _the_ one associated with the to-be-freed
> > page tables. ISTR (vaguely though) actually having found an example to
> > the contrary.
> 
> I see. If we keep the list per pCPU I'm not sure we could have an
> IOMMU  flush not related to the to-be-freed pages, as we cannot have
> interleaved IOMMU operations on the same pCPU.
> 
> Also, if we strictly add the pages to the freeing list once unhooked
> from the IOMMU page tables it should be safe to flush and then free
> them, as they would be no references remaining anymore.

Replying to my last paragraph: there are different types of flushes,
and they have different scopes, so just adding the pages to be freed
to a random list and expecting any flush to remove them from the IOMMU
cache is not correct.

I still think the first paragraph is accurate, as we shouldn't have
interleaving IOMMU operations on the same pCPU, so a flush on a pCPU
should always clear the entries that have been freed as a result of
the ongoing operation on that pCPU, and those operations should be
sequential.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:40:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:40:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237217.411399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt53G-0007Ln-4O; Fri, 03 Dec 2021 09:40:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237217.411399; Fri, 03 Dec 2021 09:40:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt53G-0007Lg-1K; Fri, 03 Dec 2021 09:40:22 +0000
Received: by outflank-mailman (input) for mailman id 237217;
 Fri, 03 Dec 2021 09:40:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt53E-0007LY-6a
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:40:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06cba19b-541d-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 10:40:19 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-Vbj38aBXNQ65pkIZ9oRAzg-1; Fri, 03 Dec 2021 10:40:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 09:40:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 09:40:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0015.eurprd08.prod.outlook.com (2603:10a6:20b:b2::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 09:40:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06cba19b-541d-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638524418;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DHYTgHg+7FRCQIwgYGV1e1aqFMZDIrWd/lDhD5N20uo=;
	b=m5kff9gjcreurLpfi2Mlfke8dSl1lE3a1OpjfJzA71rvDqA1M2LcX8I7txFTU6/OwyWgg2
	Z7zc1afUUPM/ayoNr8kUcznITMwCMhcd0Z7MuGsOHV7aSGX+wYh7h41UzSSbrisMsQ11fz
	q6u/vItn0lTtFDIKeiuKkGJ6OwBnhP4=
X-MC-Unique: Vbj38aBXNQ65pkIZ9oRAzg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DABokXJOuvl825rr1k2H69stl5v/u76z3IPx+hqMAjVvaNYa6jRpXXu7LpIogQVh129v3f7EvL1L3hNevElqaoJssYFBq6vclhZqh2/jifg1B6pyw/hhDy2LsngCl3O/JWDQC78j9kAGA4oDhBbc3iNpj3gtnuYvsr97Vs0MlnpLDYlxFUp+yuY2Ub+h/Kf9bHDOvDJLCIPbN5qrtlzwK4EwCQZ6SIQKRDPF+aLjVzlsjEPT41ZsN+i8Ye8XHbePLDN0yp8BlPaLpFZRp600x4FWuW4wXj3uNcJTQ3cUgW9kupY+yL8k92o0AE9yKpJwjx50YuNXz07wp3PGuFPP/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eAPjWv0K3HkQmcfj9Fy2c3NWQar6a91TvCjAvL+3p5Q=;
 b=bPjp9U4DCHKCF8aL4Yc20S6haKIQfRg6w07louhZSTbXPFDN7LEKBzUjbqRiS9irZ97BvqVAVgsp+1J2hAAMIcgGbsJ1/dOciek9wPtdqnsQ2j28V40TEvlIdnSYDxnA0j6+bH7lqWMZ5QEUifh3TvitaDt1bvqOWPXcik4ICtUZ2yK63K8uSmak5wXqNnNZXaPCUj5lmk7Phl15qdlOWqFPYV5+rCLqWd1XsVCufAoKoq1jDl5vX51IU8aFEkfZULWzslNS3USJu3urWBWcOsOZo4hrt6nuna18aClEMpJlAFhF+ApDgOf9DKQ7zNdVxhbGSPs5P0qFWC+JetZwiw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7439f41d-bc61-fd88-6b07-a3e35c8720d7@suse.com>
Date: Fri, 3 Dec 2021 10:40:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
 <YajubFeUclKtpqV2@Air-de-Roger>
 <03dbb062-002a-3770-61c4-4f93de73c0a0@suse.com>
 <YanViGSnE+uMwA9S@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YanViGSnE+uMwA9S@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0015.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a702e2f8-1d9d-4717-7e88-08d9b640e94a
X-MS-TrafficTypeDiagnostic: VI1PR04MB4189:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41891202B2A95DA1217EAE5CB36A9@VI1PR04MB4189.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TR68fPNDPshxLqGZ4XcgPihB9Xe7WcXr93bp9xZmJX0VE6v20Lu556U5jVzzhmuENPdtBaAPYL+BTsq9jZPModo+yQ4In241P7/Gt6T5h/Gh/+Vnxiofd6KS1Fu1lstpdf5mHaxOYS5HVVZVi8Ag23ZoGMmvv9QBlT71VJ2DCFyZe3LoO2RCmBwns3nZJqalq04JhbWbs1edhOkhkKupwc6D9P43JAlMx22kCwOcgXlblN7YK4otMyUaqM1SM88ctZzd0VHlEo1pCyj39QIkseiCIiFpbKdZRmq/QTrfxs5riGj+1UQw1ndhAz7ociBIAMfeK72w0ro/2nX3t+/R7IB06tE1WQsau1JZj+kz2jraf/OCxJHTDgu324WftKeicNgyqs9tx+5SU39+cJAKhLJc1mUhqq4inTx0SD7MYN9pIsNLEy4qZ4drHHzZNErV3cM3Vfmcdza85TNQ/OrXUsOVFU9dSrZGABaxc59RAUWy45w3s/mI2GcLWGX73xYHxhb4f+K9w2bvUPnqVorkdcyLgxIcscpv4TZLtDEiI1CjXfhwihsmUXOLeswUeon4AbQEHo5t88wWL2D/Xv+rKJjpKFon+Vs/1+R+7bG98+TszoSbm7XX4Y7dRwf+u03aNXm2YgnLNz1//buSa0ZINM6VFksc1Dn5nMt8IXPcxhsQwoNJuF0zKtW4iNg6mAmtBH0dLQk2UCz/kwnnr8w2pLIGvjOYITMhQd9M0V7HxnE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(83380400001)(2616005)(508600001)(53546011)(956004)(26005)(186003)(66556008)(66476007)(2906002)(8936002)(38100700002)(31696002)(4326008)(31686004)(6916009)(8676002)(86362001)(16576012)(5660300002)(316002)(54906003)(36756003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0jp3JQpPFjkgA+OX+2TfdmiS5uFQZeAxaCevPsNlGTFefqRBhgPC79cDpkqe?=
 =?us-ascii?Q?NmF7u3pqY/VJSMr1CKwuilGpj5gQitnOPXhGMLs00t0uZW/2f5vrzkH8jLuT?=
 =?us-ascii?Q?ycGX7LRZPyFletnLRNYCT3RxLvKO95mPUwBs2PJyr8F3eUkyOqvHxY+Ntxmj?=
 =?us-ascii?Q?tMTlzhDngtzFSSvNXMGan5avbqASvPwbWJJh3qhIYeeZ9D4G5IDxp7hQ6J6P?=
 =?us-ascii?Q?u7PYyDSNa7KT24V0RTYIPPNjl+xkGotoCnrxdv7dwE0LDjhM93be5LbP3xxn?=
 =?us-ascii?Q?rABX+MIf1Myn0K4YmG3oRaPHXtW0LasYqXZ9geShMaRPYmplJquQ0wWd5GM4?=
 =?us-ascii?Q?IWg0SZT2T6M+8Gz6nVKXJEHEBt+0/SpM5Iuf93qjFzQ2S2S2hB5S4O3932TV?=
 =?us-ascii?Q?b2AXnIZHALLY2RhR6Gfaf2iih2OzN085x6s1M1Om9p/HCY4rOFG//Nska28A?=
 =?us-ascii?Q?Mz6U4zqLJ5OAkVP1Rp7sQtKcviFBV8RtzB1neJQIuidFtUQvV4LkDmGNb7A7?=
 =?us-ascii?Q?izWnIqHH0vU7leFV4/v4pm181IOMmygy+CYD5F7Czd7dhEL9uTp5evyd8GGe?=
 =?us-ascii?Q?VMyKWyb00/MTCLk74++22BmDwOVHh9zsstQWAovMkePWify5NnKqVmadFoY1?=
 =?us-ascii?Q?oTj1I0/SP03dSN5X39Nnccr8VNNi/rKdDDHPtpJNlbuLz4DzqwNisCee6BFN?=
 =?us-ascii?Q?oF2HJD4bEk1Oo3o2W5xyzNgCXwugHBqk7vqBoGBkzckraw//E7hM22d4d5kw?=
 =?us-ascii?Q?kqC8pXGEHA/RPedekEP8HKLNm96ym0LQuiFttR1ghAtA68bq45DlMKM0Os4r?=
 =?us-ascii?Q?gzmbYD26ejvgxcfRaSpy8rJXnd7Y/o46WaRaFeLMxSzrU2DgoDY3nb3ULNnk?=
 =?us-ascii?Q?w8IzEYs5k2KEoHmykvGVrN6QopnES094IoNDobSz9t8UgApGeLOantMvbTGg?=
 =?us-ascii?Q?78HC9UukXx6d4g/yIvBdPpHWdnChfGTu3MzP7Qucd8yu2WvznGhBzShx6cuF?=
 =?us-ascii?Q?f1iNtKwvtYl+NGXCiVIW8Wqw4vNcPymdBfQe9kKwi/HmFCocjwaraKuMc7BA?=
 =?us-ascii?Q?bH0wUkY4BnEgzsddMQPfdrevoF5awX4um/zy+DRjGvs92WQFw11dLyDQENVi?=
 =?us-ascii?Q?6lsCj9xAexUSNBxzoxQIw9z/J9mgvHxkIT8EpwRqhmxuGG2jmMgdadMDTyLe?=
 =?us-ascii?Q?QqN3DzSXlLZ8U3cVcWW3zCSEhzBzS+BYyfvDKXc18dPPhZtgr+hwuWBQvlpB?=
 =?us-ascii?Q?/eGWpr00yRjaqMtTSXiRGd4hpeadYl4VpjfH1Ggyhxr/RoIxTBiILdtGH8Vc?=
 =?us-ascii?Q?cnyfDaFXa0Jt+SdrpP5n8Af7pb8k+Y8UMutXLZNx6jpTfOkrFATmw3Jve9/k?=
 =?us-ascii?Q?5WpxSKU8nKosUibozg9WjqkMV7ZhhaUdvKzQOzxnsEU7sop0ArOKq7JYUKj0?=
 =?us-ascii?Q?+AvvFmSkaOVKGsNlPTfnTKPSBijfyPgnDPtjzXs+hEUch92qV7L31YdWAYDv?=
 =?us-ascii?Q?xthKvD+CLjB7iTEDuHUZpiF0DBQlclShaOUYM0tjJQq5ySumAid3+WbgKZ/t?=
 =?us-ascii?Q?3Lexn8HbgcqAMyp7bjLd5gUyGP4njNpfDzNr5vIlqktnreRsDPnOTH5MVaaf?=
 =?us-ascii?Q?XzMo+w0R3/IXqik84nosx78=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a702e2f8-1d9d-4717-7e88-08d9b640e94a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:40:15.9090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TjYnzD4LIFoxBEJ5DD3SgZIIC25/8D6+4s0p1Qv17cn140FL8NNwosuZQcbENn9NB9g9C+T8dOKvw/hfxXZYMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189

On 03.12.2021 09:30, Roger Pau Monn=C3=A9 wrote:
> On Thu, Dec 02, 2021 at 05:10:38PM +0100, Jan Beulich wrote:
>> On 02.12.2021 17:03, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
>>>> For vendor specific code to support superpages we need to be able to
>>>> deal with a superpage mapping replacing an intermediate page table (or
>>>> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart =
is
>>>> needed to free individual page tables while a domain is still alive.
>>>> Since the freeing needs to be deferred until after a suitable IOTLB
>>>> flush was performed, released page tables get queued for processing by=
 a
>>>> tasklet.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> I was considering whether to use a softirq-taklet instead. This would
>>>> have the benefit of avoiding extra scheduling operations, but come wit=
h
>>>> the risk of the freeing happening prematurely because of a
>>>> process_pending_softirqs() somewhere.
>>>
>>> Another approach that comes to mind (maybe you already thought of it
>>> and discarded) would be to perform the freeing after the flush in
>>> iommu_iotlb_flush{_all} while keeping the per pPCU lists.
>>
>> This was my initial plan, but I couldn't convince myself that the first
>> flush to happen would be _the_ one associated with the to-be-freed
>> page tables. ISTR (vaguely though) actually having found an example to
>> the contrary.
>=20
> I see. If we keep the list per pCPU I'm not sure we could have an
> IOMMU  flush not related to the to-be-freed pages, as we cannot have
> interleaved IOMMU operations on the same pCPU.

"interleaved" is perhaps the wrong word. But can you easily exclude e.g.
a put_page() in the middle of some other operation? That could in turn
invoke one of the legacy map/unmap functions (see cleanup_page_mappings()
for an example), where the flushing happens immediately after the
map/unmap.

> Also, if we strictly add the pages to the freeing list once unhooked
> from the IOMMU page tables it should be safe to flush and then free
> them, as they would be no references remaining anymore.

Only if the flush is a full-address-space one.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:50:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:50:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237232.411418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5CS-0008PP-9Q; Fri, 03 Dec 2021 09:49:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237232.411418; Fri, 03 Dec 2021 09:49:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5CS-0008PI-5t; Fri, 03 Dec 2021 09:49:52 +0000
Received: by outflank-mailman (input) for mailman id 237232;
 Fri, 03 Dec 2021 09:49:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt5CR-0008PC-3x
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:49:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b49a720-541e-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 10:49:50 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-a1VoRgelPK23GsCUwZxcfQ-1; Fri, 03 Dec 2021 10:49:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 09:49:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 09:49:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0015.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Fri, 3 Dec 2021 09:49:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b49a720-541e-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638524989;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eqSXSstyLMTUQNI+LzHk8CyY/WovHMKTvBKvYKOjefM=;
	b=bdiTFYSgMmAZwXvjzdXsd014qBw79MgMQDRcqAuGmxCvPgdCmBFnd9FForvocA7IvqilNi
	Krk/pLCEVLMxwfLCUiyvNbHSuFPU6xvSe57Lg7yK9hmwBX2aL+6tU5715T2paEugqfadoC
	lMohxYTd9YBfNvSd7WAeOvKMnvFP6uo=
X-MC-Unique: a1VoRgelPK23GsCUwZxcfQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ac7I2tu+SKBfJEbFYD5aUo6xWrRj+QMwRlrrCGv4hkPtz2rG3xAUP8/BczqjFh5CNwATs2ECs24sHsDZA4l7bx6elM+KejZG2gGRhaCdSDqa+TMPj2MfZFGlz2c3WYSCLHfcv6X8G7roQuFLJ1oQEoBkTZPLJK+JW6yo5qiRQPIkxSRoILSTDg9yIkdAdh84KJCPuRq8ppLjNEso7exYLusQClR320j2PiilPeJBZ0tsSG+q/9OhF5KmtTC8CeUbMmlr2Qyu+QYtMg0h5UNeUBr2AmusLjHryrV3LyerMJM4aRUqWfsXcVP4IeoTTREf+p8wMVMI6sV/y1g5r8OnNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Q48zdZyWDlR1289W+uk0J3K8xDTO3BiLFkx+IdDW/Rw=;
 b=mYkaBAxWBZO5/fB51YWCQ3mAKz2R+D05Dr2N9kveQshtXGDOBx6J2CRJpIdF4vfjgNQUpASWMK8+32bBdFj9DlchUTXE9E2b475kd6WI9bLYV4mnESN5lvVnVTboU0P+CXt6IqzljL+sHNTSFzR0DwvkmwD07qAhEgRY4uWCf0uPsGKJWXnqz/qfhQIoDdWwpQmqI5O5igS7EwHKlRa/NFLY8iYQtbpo9hf5zYmz2YSqdO0nssmSYMF6VP9py5OlF9I5d81epddh/ncHqXRQahyaWA25LX59zZsiDnHDIYD57W/G8XiiIW3xZf7V7iFmfWCaC98bx3KYsnGfA6g71w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <66539595-ded3-b60f-8892-dfb391621a1c@suse.com>
Date: Fri, 3 Dec 2021 10:49:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 10/18] AMD/IOMMU: walk trees upon page fault
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
 <YandfTCG9nkWoyrz@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YandfTCG9nkWoyrz@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0015.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1c64839-c6c3-4d3d-b7db-08d9b6423dae
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4384D6099EE04F894A416504B36A9@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nPmPQpSUdAvhH6dUJhglJbSo3sRGf9igTjIXnGslipG0lYOQAtH38OGSQscN1gqVzQK9jqwCy1bDiVTBqib8Eo/SluRC5qnDCKIxx0ujQuqdxSdxcK5C0PcxXX3qk3HuZMCWChqqjO55PT2QK2W4COnd2oJnWNE1cPq3aJKJ25Vh53EZaUZXE4vnVVoVpLLAX8tlMRKkRRDJ+Gk67ok+kp9HyXDRiehmZJiiMyJcr6VoQlhMOE1OarTjnEex6okCMgRVvFR2tbuSGj/qfD3M+mKyfrgvTiANEbo2ELmbvXZcdCzAtCbzbSpgatnrlYso9/dhuH4Z5V1UelSeam2Lqmk2YqXuKov3eTzdC+OxCrNh6yeX2YQ3nFSHRNKgg4amt7Fl2kLfwQMvAHdh2SwCflKL/fiqKwIRbdCRlzyjJaFjwI3VtK6CqNRrURW7JU5RQCtasYV7jsZQuW3yMdKMBxRpGGs0KNcuzSh+sHYsq8n1u2c9pIDc8QTb2yRqwLsUqnN19ltHBPWILcwJzzwlPENEjS6cozbCMqNnnz6sYkncm5ZMLXLSpDZYn0Bv2Vw64Th50gSIPW5q0VFlOxy79y4GvgNbHUyttDpwrAdRXGsilHnvbrYpx1pJWhyQluEmYGfF6Pw0tS1nDI4i2OcDAaOsaNGTQrVW18fkSFjuz0GxhS+sAzji24e+hlcgo+UEJnZo+9acTSZtsBG3/aYaa0OB+SyvS6HBm8QDJ7126Ds=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(4326008)(508600001)(6486002)(86362001)(53546011)(16576012)(2906002)(2616005)(54906003)(956004)(26005)(8936002)(8676002)(83380400001)(316002)(66946007)(36756003)(186003)(38100700002)(5660300002)(66476007)(66556008)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?oq/XtXXmJ5Q2r3pgokeyYoKbOOmDbaOI4yiOv8xLFGPIEUxNmlkpQ6SPwfhW?=
 =?us-ascii?Q?e71q7oDJb3DgTZEHkjfRtOFMHGn618Fcv2o3EMzp+MKyqQEB/p1cb78aAjFb?=
 =?us-ascii?Q?S4e+1RZX1Q6yWNdmT+HP9qIYYe7CJBUso6Ygqqpak2N+CyQT99YwNixOPSI7?=
 =?us-ascii?Q?B3HEIr/kQFFUG/lhSbt5k051+RveZ/kjNZmmfOm2tCYpXuMDmgLKM5QLtyGl?=
 =?us-ascii?Q?H2oqSSl80UALMXHz4zjVR9I49PCq2qy6keLpd59+2rm+VhcN4T8HPbiauYx6?=
 =?us-ascii?Q?+ssg2om+sCU8ppjKnBlRWtt38eonp1+0fvuHaUQ1Z9WkgV6ePu1eu2bzBPmo?=
 =?us-ascii?Q?Q5DK5/oN9YBLnsn7MGJECdwmSjazO4UzPiCEab60Sp6Jg68b2stZoW9HBOgr?=
 =?us-ascii?Q?lIKcpUoLBCPHydxe3Pi2Rf+knweNhQpGRAWjdGk2SNH4s907v5tvFNJZNTde?=
 =?us-ascii?Q?iNZMiLX/mw+uB9WZK0slPyKjBq6RI+8/dgpGuOSozHrqjy8jJkntL9g3Qwro?=
 =?us-ascii?Q?XyHCJfQnx2nXBfZM8W11zeCdTiAGjndua9OigafVeAN9/K/Moponrbp+fec/?=
 =?us-ascii?Q?+/VTGzd3LyWO7MYi9raMSlIeNjcu+2Bi1i1bw4DAh3PFEvoc9GuYOkjiL2u7?=
 =?us-ascii?Q?W21b5jjHWrBoSdW5vCbIZt06v7cRVWtePXm8kq69UvUznEq3j8mtpNTO2yDi?=
 =?us-ascii?Q?519mgbTTU0NEIdIjl//redqCKNMAeJoky2S6ihGKvObGYEDQZsgIIxxTywul?=
 =?us-ascii?Q?YVQSe0uaN7fNAfNdRdNAML5OZ7CVbYkrrlqG8QwfFBCB/HNjmnz1xfy86Ap9?=
 =?us-ascii?Q?n266Yr2ah/pfg73Qmezgte/JrgaB9cuUw/fiqn80DKbH9nVNIcsOkOA5MaZJ?=
 =?us-ascii?Q?d2IGJ1hrj+TcuHZIwUl+ASm7+yMTSN0bxdXmmZUsAEihlljP/+L9+ymeW7HP?=
 =?us-ascii?Q?qpgolF4WKJa2ukLi4F41jqNGEOPIQ5BSJ09zeM/b598VuEdarQnTRrFUTu8c?=
 =?us-ascii?Q?cTwM4DV20j2lTraPKDKVcbjIKuGtr5kLMUIZeVTnVJrO5tUSRz0ExizCSxw6?=
 =?us-ascii?Q?Q1TgYbDX7UwlOaSpewL3EMqm7gHXL57ybxwW8ZzDkIM+2H90Gx+/QE7WXlaA?=
 =?us-ascii?Q?8cvHclEgnKceV4M130aBn347q240NRK3BFyQ149Iyqj/Y8nXAAgpeJYKyumk?=
 =?us-ascii?Q?9wEZvqUXkxnpXChETyhvB9JfWGp/YyKx5/21mljhoMV57G5bYb33ESXWQhmh?=
 =?us-ascii?Q?yg6/qPqukLPMIz/xKvOZKla5+PCgf3lR/dpUQ1YRsPgNbghX8oRyDoAOy7jx?=
 =?us-ascii?Q?v8MrsCCLihkLxvUUXZIKpQmJSbpYdg6J4WpUYcQ+R1RHxlUyKq5tbdkiMvqD?=
 =?us-ascii?Q?REOpYWfi5RR4Fd1qEbgfUYAImZU6YqwFy/V/hwFuwx8quNwJJQkX5PacWbxR?=
 =?us-ascii?Q?Oz6q2t/8SlfCwzNeP47e6BYhlBTf9KjBgIt+zmWAsEXBlU0fDGovQQhEQ3pD?=
 =?us-ascii?Q?2MsI403jlhw9xeUkUmRVCdm7we+/i+B7j/rW1sLZ/uVf4QMmcOvIbQeiGivi?=
 =?us-ascii?Q?WPB0ksVUK436194b/7Mo3F/1gvETJc0zBBnMAbvMJieGXV+6wITjt/HNTw18?=
 =?us-ascii?Q?1xWVXH90RoXYcJh2bHyg/n8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1c64839-c6c3-4d3d-b7db-08d9b6423dae
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:49:46.9732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8jOgDwXKEtclrchB4PrmjdIKvb162K8lNtDF5cZ9xOs2XHvV6cWHx9DY7DJICEZX/bzUQ+3ouNAaySiCfEH8dg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 03.12.2021 10:03, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:51:15AM +0200, Jan Beulich wrote:
>> This is to aid diagnosing issues and largely matches VT-d's behavior.
>> Since I'm adding permissions output here as well, take the opportunity
>> and also add their displaying to amd_dump_page_table_level().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/drivers/passthrough/amd/iommu.h
>> +++ b/xen/drivers/passthrough/amd/iommu.h
>> @@ -243,6 +243,8 @@ int __must_check amd_iommu_flush_iotlb_p
>>                                               unsigned long page_count,
>>                                               unsigned int flush_flags);
>>  int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned in=
t dev_id,
>> +                             dfn_t dfn);
>> =20
>>  /* device table functions */
>>  int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
>> --- a/xen/drivers/passthrough/amd/iommu_init.c
>> +++ b/xen/drivers/passthrough/amd/iommu_init.c
>> @@ -573,6 +573,9 @@ static void parse_event_log_entry(struct
>>                 (flags & 0x002) ? " NX" : "",
>>                 (flags & 0x001) ? " GN" : "");
>> =20
>> +        if ( iommu_verbose )
>> +            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(addr=
));
>> +
>>          for ( bdf =3D 0; bdf < ivrs_bdf_entries; bdf++ )
>>              if ( get_dma_requestor_id(iommu->seg, bdf) =3D=3D device_id=
 )
>>                  pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -363,6 +363,50 @@ int amd_iommu_unmap_page(struct domain *
>>      return 0;
>>  }
>> =20
>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned in=
t dev_id,
>> +                             dfn_t dfn)
>> +{
>> +    mfn_t pt_mfn;
>> +    unsigned int level;
>> +    const struct amd_iommu_dte *dt =3D iommu->dev_table.buffer;
>> +
>> +    if ( !dt[dev_id].tv )
>> +    {
>> +        printk("%pp: no root\n", &PCI_SBDF2(iommu->seg, dev_id));
>> +        return;
>> +    }
>> +
>> +    pt_mfn =3D _mfn(dt[dev_id].pt_root);
>> +    level =3D dt[dev_id].paging_mode;
>> +    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=3D%"PRI_dfn"\n",
>> +           &PCI_SBDF2(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x(=
dfn));
>> +
>> +    while ( level )
>> +    {
>> +        const union amd_iommu_pte *pt =3D map_domain_page(pt_mfn);
>> +        unsigned int idx =3D pfn_to_pde_idx(dfn_x(dfn), level);
>> +        union amd_iommu_pte pte =3D pt[idx];
>=20
> Don't you need to take a lock here (mapping_lock maybe?) in order to
> prevent changes to the IOMMU page tables while walking them?

Generally speaking - yes. But see the description saying "largely
matches VT-d's behavior". On VT-d both the IOMMU lock and the mapping
lock would need acquiring to be safe (the former could perhaps be
dropped early). Likewise here. If I wanted to do so here, I ought to
add a prereq patch adjusting the VT-d function. The main "excuse" not
to do so is/was probably the size of the series.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:56:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:56:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237237.411429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5IP-0001N0-Vq; Fri, 03 Dec 2021 09:56:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237237.411429; Fri, 03 Dec 2021 09:56:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5IP-0001Mt-Se; Fri, 03 Dec 2021 09:56:01 +0000
Received: by outflank-mailman (input) for mailman id 237237;
 Fri, 03 Dec 2021 09:56:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt5IO-0001Mn-HC
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:56:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 376532da-541f-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 10:55:59 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-XJ5R0sDqNpy33WKy95PwOA-1; Fri, 03 Dec 2021 10:55:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 09:55:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 09:55:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0104.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::45) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 09:55:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 376532da-541f-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638525359;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XQLXNstpDZItO/z6896aK9fDJ8ZxkEeDypZSaiy9s7U=;
	b=mRWPFBAMudeCKBWY8IBLrLRStCHsbNXhTXM/4cTRxuYMFifIyXx3q0Sh++OdFDBLjRXlcP
	NmJedobY+ctIsneQt/0TLxZG88iq8hZl7mtygArHVo728KyCPJIxW+V61Ok3/1c5rwfQTr
	MSi+8zpCucyf4LfYcWSRt0+BeV1sdX4=
X-MC-Unique: XJ5R0sDqNpy33WKy95PwOA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SsryuQBjpqpSArOvOJdeK+LqGad5Iv57oy82yB5fZBc3I7TInpY7qsrJfo0o/4mvrT/fvFyKxzBXZHbb8OWJ/Y8maBvbp2jp7uE6Roj79TQ5rFgHY6TuxNWP66+bwxJJwGX2jIL4l5DSlvX0811PL7i2nYLwpRyJrFhouV7S8Ph2t+2XRNF19ZDc77Qlnrn6CQKeYIP5zzDZOb/Yo9/eOC3bw05gPoKw8200YeV9mhbWeFw/dniLH0quckQaNtnQHTaweRFsLmLvquiaSGF/SX4OyFHGrv9MvGKKMaP83ujKkWvUD5kaieyD1aq1un/R8UW0LVVsj6Rxcs59jkqvEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Al3bQW6tWKcg9dUEjlH6lASPwe9aXC2RzR4lbGptWvc=;
 b=S9cy82X8k714V91gcNMi36viVDOSt6pGzvFETcRH1EPuB3/tMPOXd3fHtb+dVKfFBWYjNH6yXIft6pDCgKkz3jcr7HCS6ENAoSdTWUAcTt1ZhdPY3a5+D2tecbYGqWVKQ/3GulEH3JiuqPHX9MHXp+pPxOJKb0XdJIROb5TfmCLXQu0CS7AjmRse9oP0KeGZPZEvdTCNzEJEuJD4jQMOndGL2i+NeHCRIW5IXsizMtJxqy3fShskmcn0XS/og9DSN7PGv0uVpWw5batLbjQz9TuigcHWOzvEnCULOrvBiw6woLIYWLfx3pVOKgXOPA71/9PYn2z39xYGaFGe1oZHMg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b429c9f9-83f4-57e1-010e-59181ec93ce8@suse.com>
Date: Fri, 3 Dec 2021 10:55:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 10/18] AMD/IOMMU: walk trees upon page fault
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
 <YandfTCG9nkWoyrz@Air-de-Roger>
 <66539595-ded3-b60f-8892-dfb391621a1c@suse.com>
In-Reply-To: <66539595-ded3-b60f-8892-dfb391621a1c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0104.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 062c77b2-703c-4553-219b-08d9b64319e1
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3775661CA788FE2898636005B36A9@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x9FHp0bTLMDI/a5IZBVqoeWlGjDm+fHx8fdTanWs/ZRFgHnYi/3UqLM7GRxY1HPVbb0b8EGGICBQfPAYibP4CwE+6ZeN6D/WBpmz8vJNKD1pu+d5Q4eCiqpaXO2XADhkHOFo1YqMZ6rsKTega9CaBKr4n2kvlcFoqOqvXAedYsMEDY0BNoB1bFkZ1o22tbsZnzRR6/GBw9rrpcNFde08wmWi6rBQfmd2ygxal98JQxdzBZRPNiS4gxWeVke8DM517dPaubwDurnXA6cNxQ1C+fJuPcfsx8To2lk8d2B71YoGwFENLbaBCLdkNNPh1Y2IogXLqF8EkWg8+Echqlcu48Ch4hbdAWAf/cskhAIwJHhNewDbU70r0X3PaELOowpj80DRsvNTSscmMx9ce4z/HTDYbbESWHeubpk79LrnYoyrLvR37BQNYT1A7iz0jAs5rmTCh+9Ttm4ITgN0ffLvebvbj+eVRmaPPC3h7ozLx8pHQ6G2xpfOIxqlY6YQofy24SWO1D54GuVZHktVF6ULp9Q8hsKvW78MwLTyKUle0L/pB8TKc5qhk6RwNpdtYnJ5DWt3y5cp70m5SDhkRGkd4cMBum3RIFZtnhJ3l4WXPPCKKBv6OXAkXxr0Ro7UmsK9AzGVOJkk86GYrV/vI5WW3Ii+rJowNDjdEoe47NQ7479zkSbzTlHod79sLPkWbKvvOwxo/f6XrtdhqFrvXXrrIcUwDEKJgNR/Qrj7BA3fd/E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(83380400001)(38100700002)(66946007)(53546011)(186003)(2906002)(316002)(956004)(31686004)(54906003)(4326008)(36756003)(16576012)(6486002)(66476007)(2616005)(8936002)(31696002)(508600001)(5660300002)(66556008)(6916009)(86362001)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?baxELy77Y/7eV+jQILd8CXmFABpTcYUwQfqlS8WbYuXSU7ARodukMlx6siyR?=
 =?us-ascii?Q?ieu8k2zCTNit26cdDeSs9KYomDzdaS74whm4SRUeRl3Vyfqt9HlM14QpbpH4?=
 =?us-ascii?Q?vrLuOtCsg0CP1zpF6d1Okfa0W0oQI9Ln/dQw9FwlodDhi3e9W8X+g27uivH3?=
 =?us-ascii?Q?/HPSEHZ1vvib6UsUDmYHRy8YDipyFXr8Y5CCUhDZh4co9Gym46fp5yoNVrya?=
 =?us-ascii?Q?oTTDE8zPfeuzqk+zABt1esVafrRs8KhYL9DC8GMCoI9l0j7DP39QFdFek/Dv?=
 =?us-ascii?Q?QCBJJyVxZAAyl5BtE8KmiQ49UcCexbXtW0LjtQrQMohZUqT9ASaYdIQlQi9b?=
 =?us-ascii?Q?xHABR5K3BqtrQCivgoXUy+z16r/BCUCNTjt5wycB9gAMSWk3OwKnwM4hLEzn?=
 =?us-ascii?Q?afaevIpusSI1/7ltYCpGIn5//0C6BlBNgSIfvU0CrmacltGBRvMlRTiOQr1k?=
 =?us-ascii?Q?Vato9FDqifwUpAnIPb03f5/xzLiBx6olY51/jQDiBSn+2veGZ0fvCkL8yV13?=
 =?us-ascii?Q?PWOiWSG1ey7helVkzAKx74OdNpxC+6i5SaGecrbBd/FsNCup00wg5sq/b0X5?=
 =?us-ascii?Q?18PWjfARqH51q4rsuuYQ3h5V48f94Jt40LsWAO7HGjxfMN8HFee849WmNcpS?=
 =?us-ascii?Q?9itSy88Gj6Gs3KmHefyYESGH90MNPKKGXFa1cQTJ1w7U6GXVJsqiVKZg7M2r?=
 =?us-ascii?Q?k8//9KnDfD0M9/CpB2cssHXz7rePWZhym4Sa2DkV2sTy5UYRgMc7nJbJaXZD?=
 =?us-ascii?Q?a1ex+xIX8tsqTWp3Unr0R4YKsCrs7AWyakKkqXdR19AR+dLh8NP7nIG4C0vI?=
 =?us-ascii?Q?G51Tn8qfLgEeYZ/g3i9GMFtGo5R8hB8Kfiq0+Ao+tPC4N/OlpRGXLg0K68vY?=
 =?us-ascii?Q?i4XI29yFslGCGMPc5xG42INW9tWwO1FDOVyt50L8WGvexitXoSobb017tEKc?=
 =?us-ascii?Q?gCwuC4XQCJUhs1eX9uF87Jd2m2bb3+pZcRHa9v4NKTL2C2Qr1wK1z6AveUYN?=
 =?us-ascii?Q?hlJYgR/azNEp/6fjky3d1nChs+txR9XqUTmNX4pCB2Jv49w+6bAsXW9FUQLC?=
 =?us-ascii?Q?3biwOJpTCzuw/QWSUcVbFU5vMSDulK25QJA5PAYotUOVhCKlg4HD1AktYqZj?=
 =?us-ascii?Q?i83FfKbDe6lc04wMOa6Voq9lqMyHyy3D8iOKO/LzuBQ+JCLQiTk1/23Y1fDy?=
 =?us-ascii?Q?flJ9FEmeEwiB79egoE1oH9jCfHLJ9/786xnUuaq21f979DMKJQBHPTUp3vh3?=
 =?us-ascii?Q?DJo4FJAjHNOuiilE3w4lL+m3k+V8RwMpfBqM+uzv+2qxIo5MlCki2PE/3M4c?=
 =?us-ascii?Q?+KGocUAheC04Vxxh14vbXIVjzjzosbxF3QTmCI8d+Z2ehXEZZfptMgBRYAmx?=
 =?us-ascii?Q?o7gmNeEiRXuhiE7kc995lW1zidAU2ppLRytM1HRX5B6uRcnGon9q1UaGw/RO?=
 =?us-ascii?Q?Q9s3XxEENdQeszgWAZNnW3FKEoRXO7K8ZyhkRO5vzxB7Dj837ekmAMjJqwsz?=
 =?us-ascii?Q?LI7qnlJhaI2Q64WFTLcEIqiAzQCDEH/3YQuWP1NXmkEBYrJVP9oIPubLYf9W?=
 =?us-ascii?Q?863aBM6ZZDuoxZoDA7teu85xvbQl4EHwwWlnOQACuAzQNrK2AKs+2umccV7H?=
 =?us-ascii?Q?sm5GR3o+RAYSb/RyXY7o6VE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 062c77b2-703c-4553-219b-08d9b64319e1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:55:56.4413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NB9kXCULz8KiAauPKILVa3eTtUoXAzDF1fOvMG3177ALQEcOcm6ElvftKWkLdVxceH8SwNvldX4hvkiESlWEUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

On 03.12.2021 10:49, Jan Beulich wrote:
> On 03.12.2021 10:03, Roger Pau Monn=C3=A9 wrote:
>> On Fri, Sep 24, 2021 at 11:51:15AM +0200, Jan Beulich wrote:
>>> This is to aid diagnosing issues and largely matches VT-d's behavior.
>>> Since I'm adding permissions output here as well, take the opportunity
>>> and also add their displaying to amd_dump_page_table_level().
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/xen/drivers/passthrough/amd/iommu.h
>>> +++ b/xen/drivers/passthrough/amd/iommu.h
>>> @@ -243,6 +243,8 @@ int __must_check amd_iommu_flush_iotlb_p
>>>                                               unsigned long page_count,
>>>                                               unsigned int flush_flags)=
;
>>>  int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
>>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned i=
nt dev_id,
>>> +                             dfn_t dfn);
>>> =20
>>>  /* device table functions */
>>>  int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
>>> --- a/xen/drivers/passthrough/amd/iommu_init.c
>>> +++ b/xen/drivers/passthrough/amd/iommu_init.c
>>> @@ -573,6 +573,9 @@ static void parse_event_log_entry(struct
>>>                 (flags & 0x002) ? " NX" : "",
>>>                 (flags & 0x001) ? " GN" : "");
>>> =20
>>> +        if ( iommu_verbose )
>>> +            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(add=
r));
>>> +
>>>          for ( bdf =3D 0; bdf < ivrs_bdf_entries; bdf++ )
>>>              if ( get_dma_requestor_id(iommu->seg, bdf) =3D=3D device_i=
d )
>>>                  pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
>>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>>> @@ -363,6 +363,50 @@ int amd_iommu_unmap_page(struct domain *
>>>      return 0;
>>>  }
>>> =20
>>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned i=
nt dev_id,
>>> +                             dfn_t dfn)
>>> +{
>>> +    mfn_t pt_mfn;
>>> +    unsigned int level;
>>> +    const struct amd_iommu_dte *dt =3D iommu->dev_table.buffer;
>>> +
>>> +    if ( !dt[dev_id].tv )
>>> +    {
>>> +        printk("%pp: no root\n", &PCI_SBDF2(iommu->seg, dev_id));
>>> +        return;
>>> +    }
>>> +
>>> +    pt_mfn =3D _mfn(dt[dev_id].pt_root);
>>> +    level =3D dt[dev_id].paging_mode;
>>> +    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=3D%"PRI_dfn"\n",
>>> +           &PCI_SBDF2(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x=
(dfn));
>>> +
>>> +    while ( level )
>>> +    {
>>> +        const union amd_iommu_pte *pt =3D map_domain_page(pt_mfn);
>>> +        unsigned int idx =3D pfn_to_pde_idx(dfn_x(dfn), level);
>>> +        union amd_iommu_pte pte =3D pt[idx];
>>
>> Don't you need to take a lock here (mapping_lock maybe?) in order to
>> prevent changes to the IOMMU page tables while walking them?
>=20
> Generally speaking - yes. But see the description saying "largely
> matches VT-d's behavior". On VT-d both the IOMMU lock and the mapping
> lock would need acquiring to be safe (the former could perhaps be
> dropped early). Likewise here. If I wanted to do so here, I ought to
> add a prereq patch adjusting the VT-d function. The main "excuse" not
> to do so is/was probably the size of the series.

Which in turn would call for {amd,vtd}_dump_page_tables() to gain proper
locking. Not sure where this would end; these further items are more and
more unrelated to the actual purpose of this series (whereas I needed the
patch here anyway for debugging purposes) ...

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:58:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:58:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237244.411441 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5L5-0002CK-FO; Fri, 03 Dec 2021 09:58:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237244.411441; Fri, 03 Dec 2021 09:58:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5L5-0002CD-Al; Fri, 03 Dec 2021 09:58:47 +0000
Received: by outflank-mailman (input) for mailman id 237244;
 Fri, 03 Dec 2021 09:58:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ek4d=QU=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mt5L4-0002C7-7E
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:58:46 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 99496710-541f-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 10:58:44 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AFC931435;
 Fri,  3 Dec 2021 01:58:43 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.0.138])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9ABEA3F5A1;
 Fri,  3 Dec 2021 01:58:42 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99496710-541f-11ec-b1df-f38ee3fbfdf7
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] arm/vgic: Fix reference to a non-existing function
Date: Fri,  3 Dec 2021 10:58:37 +0100
Message-Id: <20211203095837.20394-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
(xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
forgot to modify a comment about lr_pending list,
referring to a function that has been renamed.
Fix that.

Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/include/asm-arm/vgic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index e69a59063a..ade427a808 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -195,7 +195,7 @@ struct vgic_cpu {
      * corresponding LR it is also removed from this list. */
     struct list_head inflight_irqs;
     /* lr_pending is used to queue IRQs (struct pending_irq) that the
-     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
+     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
      * no LRs were available at the time.
      * As soon as an LR is freed we remove the first IRQ from this
      * list and write it to the LR register.
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 09:59:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 09:59:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237248.411452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5Lh-0002im-Nz; Fri, 03 Dec 2021 09:59:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237248.411452; Fri, 03 Dec 2021 09:59:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5Lh-0002if-K5; Fri, 03 Dec 2021 09:59:25 +0000
Received: by outflank-mailman (input) for mailman id 237248;
 Fri, 03 Dec 2021 09:59:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt5Lg-0002C7-70
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 09:59:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b084e227-541f-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 10:59:22 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-S7LYzUvYNg6BYry-1T4A1w-1; Fri, 03 Dec 2021 10:59:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 09:59:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 09:59:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:20b:462::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 09:59:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b084e227-541f-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638525563;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wCMK48uKgAuqLl9dq2R1ke66y/Wm4yaI7xna1jQNkXw=;
	b=nTlPkScOJ4AZ+C2azyYjiRLRvBpL43eJwBw7kBcCE0F6dOk0uu0SOvszBDdwofi56lyvJl
	QbPIJjNDjkugmUp5ubxFgzubrX8St0HrpneqNfZKZsyZ5KoXz3bxFeKLyFnSOEp0C9Q39m
	UkDikjQmXhiF2rWY0CB8H7tyPJC+yTY=
X-MC-Unique: S7LYzUvYNg6BYry-1T4A1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XlZXeVwBQqWJbFzz04rJ+egjA/I8sxbhB3rwBayOUhEbVxjmqRiHAltm8CQxP/7HAIxkEYzHaIJnUj//baTf0xUTMpQdmQj/SBR3WrkqZx36aeDG3G2BQDVA5V8MEF5cds7AJip0xHOPoPi9JBP4/omBwcJlHdN06mR7wS5u8fscnjXc/kZs3TxreP7PlfsaJUG2KQs9ThFExBfDZzrkfHuJp5KmXxtfpu9N6Mnu3+znRRAb4x0yofTVJqEn3YQvuxmmD8DFmFlrvsv534OHW7140Yz7KSsnl70SzWAaQhRutV8twr1fl7iLuGW4cIFeGIS5buzTBIqu+4QdElAcaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7pJYkEFfoVelKKBPMScwRw0db81zBvMrRG7Nva4I1B8=;
 b=etKp+rW1rJGwbthkHn+9CKMHO5VESXCTTAL9vwIrBWGrsVF9AydOiN3Z2pw8qBN64Rqq1TJAjUHSOH12WXJRGB6DHzDjesm+R6nsy/yQCfT/TL0/aFt4D+zFyCFZ5vrfRGpV2jMCTTGFsEEOGrMwJrCsNXNVXp9Z8+RRjOfrgMzXK+bWc/kFWwD+c+3t3uSpeCWtieJAHeoY17TYYgWTK9sxY4kSqhYA/tBI+KA8B61WbaD0JCUIiEL9F7gW2+yxanQQrykiUxcH5021piR4Piyi/dw2oqEa5JQ52/LA1LMYq1jkk9Fh8dfubc7ZgZ615HaRaqHQc9OrfL23aYRfFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <066ff819-de46-4c0a-d32b-bd9fb97c12d5@suse.com>
Date: Fri, 3 Dec 2021 10:59:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 10/18] AMD/IOMMU: walk trees upon page fault
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
 <YandfTCG9nkWoyrz@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YandfTCG9nkWoyrz@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0002.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dec698a7-1b94-4d90-6221-08d9b64393b7
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352902119DA20050896875FB36A9@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ok9bQfmI0HLLWvfhtZZkSnMnBo95/UMLqdtDxRLQJTUNnS54TqBJ8BrcUYwS/RxwmVoUL9ZZt4DyNkddyTaS4EJVva3LMMteANIiIc9GJdYEwGOdsMtBRpPJJBQxtNMNVW23flXiZ7CS2xNCSdPEFmWeGU+ArOsQUGZwRCvyuuis0mOVsFITBc2+63aMQ4i/uq235kaJnN+xPHmlJSlHl17tJ8ujS1oA/t3ZDlWG0dW5usJK6QfxIoVY+Db9vlmdAIyJ62IKYx1nShMTfulhQ9Nx0heN3WVURB+vUal+Ti33W/IfBciBTmRUEL0XNqJPh02hdaAgHehu0BUjTFWlTbmm96nSrXONG4WSOyZxJTeDi4wNYKV8DodaLze3ENSK8Lyh678TGeIH8etCYD3+cJzuUgjurpdlXDMPVOaNtKo2Wgdb2CGhoTSBS0A/JlrZEL7iXZsVCyel2rA2vJZnrFwvO8xcmIFpxGJKvyuJn7dMv0uGkZT6j8/PwlPatl3rPide05c8s7cFXe7FGTk5h9OTvXP/B9ZwDqjPu74uTsEJC4Nhc+i0BUcPlXrLOSqkzOdlF4kgSDcIfn3CRniIsjNc4OgCP4n8rEK6DJ0+eSA+ALV5YbULgWSd/w6w7eE/POuoMTE6j2GfrACSwTpaCOg+joxXChdWq6swFxc8gf06Ushri7+KsHmIoPy6e/Gm87tXcG1nnK5isXISRqJPp0EBvpyog4oXJHTo5AL9QqI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(2906002)(31696002)(31686004)(956004)(8936002)(508600001)(36756003)(54906003)(86362001)(16576012)(53546011)(316002)(26005)(186003)(83380400001)(38100700002)(66556008)(66946007)(5660300002)(66476007)(8676002)(6916009)(6486002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MbDbgyIFDDZrFtRrxWm9pFAQZLAkJjqccUQg360GXjfr0g9BAqE23e9oYZ9Y?=
 =?us-ascii?Q?DE+1MWIgt5+NT2ehs6Xc2c7n/fiUZjEHLWakBuhgxnykCY/tuleCBvxRZPh3?=
 =?us-ascii?Q?6cK32JOfAVqJaLCB92Ob0LzBW6XsMzDzHkP8uEbumIVQH4nz7fcPOh11p9cF?=
 =?us-ascii?Q?ICpen7eybQ5zt/O67ryn1gh2dEy/t3PN9fJLV+NnySzLn/R4DR9CNGf2Zink?=
 =?us-ascii?Q?+/BRtyxg+N+tW7kuUaKXcLT43AzlUYuNziYKrDbEFciU9XF1HRbkX2pUR4uL?=
 =?us-ascii?Q?90g7ra07S6x/pbD6yks6Gp3LWqihhgNIyL7jqKpBSSKqwky/A4LBe7mbXPN9?=
 =?us-ascii?Q?Mn9HVbpJBnUy4vZSfZTsITJIPCtJHxGcQRI0NupOICrUL70l3ELc9laycbcz?=
 =?us-ascii?Q?ANuIJnk7N6EXKsTRWd1+rIw8f409qbFY48FiCOt28hcZ4NjkUWhZsGKE++0b?=
 =?us-ascii?Q?NG90OKC15FTTEuRF5xeM4szXG98veQAhPGP/QqMzjTHquAuNCyuFVZVeG0dS?=
 =?us-ascii?Q?VT659htPbAw/miTeWOkf65+k5/trQCefmqt8IGVr8nVsORB6j7FPA9XFKmKS?=
 =?us-ascii?Q?uhMr0KmPCwBWvle7lHmm7joo5e8Jz1YW21ppbblA0AmAM9xSKxmM5bZ247WY?=
 =?us-ascii?Q?1uJvkiK3lX3U+o2r8aj05PKuEqHQJfld0wAjij29+M3fNs2uwEEjikhkorhH?=
 =?us-ascii?Q?UCR8WcIWvs56H1oozmySFVOFHFdh2v+dEa5xZ/wzV5fskzgVK+QHwUaqx/p0?=
 =?us-ascii?Q?TDaJ3Tssz3SyvjG/BkOJXAlE7e5fXSjFnRFYjSktNM6s7iBJefoKKAOUfXGK?=
 =?us-ascii?Q?G6XNarUQCbmSm9Eh0btA1tV46t/Bbm2t26lbmARUAEVWgt+Msa2IsQW0b+2I?=
 =?us-ascii?Q?8g667tc6oMxUn5KMz8VlrgVkSWCjSvCCjF23XJw2J8Lo9Yyz9MBKfE+a2D7+?=
 =?us-ascii?Q?i2GDlPD48AX2FHMtlCj2vkYv9tc29/t7ez+ZgzYwEAbCJ5jB1ZnPTXn2ZV1s?=
 =?us-ascii?Q?3RkXtXmao7YxEs9z1udPx6mHcFgQN+BBApR9zhMzyiNmVRfRMPBv4vW6+g8+?=
 =?us-ascii?Q?/Q5Kj+VqpKQrI1voPVjDuIQagCHU5ko+Jn21p/aukgO8LsnfNDuCx8rlab6I?=
 =?us-ascii?Q?Z5SRaFzc8ume+1jr1GmtQG4gedkliEfygsl4V60C1ljSBP6UG5cJw3zfKq+a?=
 =?us-ascii?Q?3k9VXFfBn/y05LzbQiYIiFfM2DVCMJaNNlraLg7y3OtWUU+IbA7H/GRXpToK?=
 =?us-ascii?Q?6NF24XXol1Rjlx9jNxYUqdMQT6GwjNlc4bNfGU7rJrT2DB0Q96jMhkbueOdq?=
 =?us-ascii?Q?j7S+S+PyU8ZvCrpmF3IyqOWJhY1WOBKQ0JM/07YFV4oJaw2LQPD0omENsdf5?=
 =?us-ascii?Q?VT1dMI+7aRXWRpNE30J9K26RdywZdbZZApDviqCawyCjPjepxvVSl7Vb2yME?=
 =?us-ascii?Q?M/+fHpTFdu00WRPMGG+uC5D6s5L0RGJ4lQZw+eKbV6yh65jYSghiLVNOo4gD?=
 =?us-ascii?Q?FtD3LxtvvY7LgFnoBuwkFcbfBAlMgDErOH3iSRbEGYcED/jWJfVQfQoys9tY?=
 =?us-ascii?Q?v3RFDTQp2owb9Ts+4NOefASnmqy7NJCOIiFaUGbPWsz/X6HhNDLhNeq/ZWCy?=
 =?us-ascii?Q?ifhudvNO0rZf2CPhTJr6Kk4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dec698a7-1b94-4d90-6221-08d9b64393b7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 09:59:20.8068
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MEHp0layjt3eHxENso9uA1odvoH17YoJrNOLWJXV3Nm60hidoCVKIiYkq/yEYeK4gaqWsAqAPcC8OZgNp0zubQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 03.12.2021 10:03, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:51:15AM +0200, Jan Beulich wrote:
>> This is to aid diagnosing issues and largely matches VT-d's behavior.
>> Since I'm adding permissions output here as well, take the opportunity
>> and also add their displaying to amd_dump_page_table_level().
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/xen/drivers/passthrough/amd/iommu.h
>> +++ b/xen/drivers/passthrough/amd/iommu.h
>> @@ -243,6 +243,8 @@ int __must_check amd_iommu_flush_iotlb_p
>>                                               unsigned long page_count,
>>                                               unsigned int flush_flags);
>>  int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned in=
t dev_id,
>> +                             dfn_t dfn);
>> =20
>>  /* device table functions */
>>  int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
>> --- a/xen/drivers/passthrough/amd/iommu_init.c
>> +++ b/xen/drivers/passthrough/amd/iommu_init.c
>> @@ -573,6 +573,9 @@ static void parse_event_log_entry(struct
>>                 (flags & 0x002) ? " NX" : "",
>>                 (flags & 0x001) ? " GN" : "");
>> =20
>> +        if ( iommu_verbose )
>> +            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(addr=
));
>> +
>>          for ( bdf =3D 0; bdf < ivrs_bdf_entries; bdf++ )
>>              if ( get_dma_requestor_id(iommu->seg, bdf) =3D=3D device_id=
 )
>>                  pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -363,6 +363,50 @@ int amd_iommu_unmap_page(struct domain *
>>      return 0;
>>  }
>> =20
>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned in=
t dev_id,
>> +                             dfn_t dfn)
>> +{
>> +    mfn_t pt_mfn;
>> +    unsigned int level;
>> +    const struct amd_iommu_dte *dt =3D iommu->dev_table.buffer;
>> +
>> +    if ( !dt[dev_id].tv )
>> +    {
>> +        printk("%pp: no root\n", &PCI_SBDF2(iommu->seg, dev_id));
>> +        return;
>> +    }
>> +
>> +    pt_mfn =3D _mfn(dt[dev_id].pt_root);
>> +    level =3D dt[dev_id].paging_mode;
>> +    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=3D%"PRI_dfn"\n",
>> +           &PCI_SBDF2(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x(=
dfn));
>> +
>> +    while ( level )
>> +    {
>> +        const union amd_iommu_pte *pt =3D map_domain_page(pt_mfn);
>> +        unsigned int idx =3D pfn_to_pde_idx(dfn_x(dfn), level);
>> +        union amd_iommu_pte pte =3D pt[idx];
>=20
> Don't you need to take a lock here (mapping_lock maybe?) in order to
> prevent changes to the IOMMU page tables while walking them?

Further to my earlier reply, taking the mapping lock here isn't
straightforward, as that would mean determining the correct domain.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:19:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:19:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237261.411469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5fA-0005eW-Ha; Fri, 03 Dec 2021 10:19:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237261.411469; Fri, 03 Dec 2021 10:19:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5fA-0005eP-Ec; Fri, 03 Dec 2021 10:19:32 +0000
Received: by outflank-mailman (input) for mailman id 237261;
 Fri, 03 Dec 2021 10:19:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aSTI=QU=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1mt5f9-0005e0-FZ
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:19:31 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::602])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80177962-5422-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:19:30 +0100 (CET)
Received: from DU2PR04CA0261.eurprd04.prod.outlook.com (2603:10a6:10:28e::26)
 by PR3PR08MB5642.eurprd08.prod.outlook.com (2603:10a6:102:8b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:19:28 +0000
Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:28e:cafe::a7) by DU2PR04CA0261.outlook.office365.com
 (2603:10a6:10:28e::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 10:19:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 10:19:27 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Fri, 03 Dec 2021 10:19:27 +0000
Received: from dbd1ffe578a3.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E1528ECF-E8CE-4B34-97BA-762E6A5571DA.1; 
 Fri, 03 Dec 2021 10:19:21 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbd1ffe578a3.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 10:19:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6469.eurprd08.prod.outlook.com (2603:10a6:20b:33c::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Fri, 3 Dec
 2021 10:19:20 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:19:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80177962-5422-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yg2MfwRaiITANGB5KvOSAQ1TcjDjGwifxAg8X1H07L0=;
 b=pZH6TwEb5iMcwyfU5yJj3jjFH38UACxwqgsG55QVP1DIpmSroT1gWC/FkyZ5ijQ8drTd/vjIadQc/jIPWbOuP5T6qoFqdYisOY9qp9gzv0Q3RKMpfNYVo0xOsAaCQ6Lvtz+61/Yh3jKlJLi7eHBBFVbfPSWPCuWApd66Us4M5R8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c89b3d562d2e8ab1
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JhET4dgClnO1loAkV+hE1BL/IRRNgVx7vHcnxBGMGq5VCWdgdZeHhtahSk7PAP3EV79iY6WCFvmqaV358m2yQE/CvjJHjGaleEcDq8JlogSZabSKhGZ6tvw8Fe0GBrgSDIudJCx7RMcNUUM7b1iD3BZbfhrExZPOx3y/hzbAhnX2IjP1I+0t0oaMuef8e63GfBLpkeyiCbfLB+dq5W+2ZYgEylNdc6t5bHGtFwewobKczDBqD+XMj5BUkg1cCTssdE2uluSwKQw2GI0D681/d1ovSwoIp/GFjvcdwtDIFPg54sgP3E+tiMBhMWdpPpT53TCwsDix02CiH5N9UNesiQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yg2MfwRaiITANGB5KvOSAQ1TcjDjGwifxAg8X1H07L0=;
 b=ZT73GQVPC9h4L7JOOs+hmBZFrm8ZRMFTd3KLOn1GBM+Xz4QL7NmM9dsKJvXWn3ljqT378/ERwOD9ggSyw2IiFcG9qt1rDeiSiSxKwVvLmLgr0J6N9faZsD1e94M8g75HpZceLVPIvtJtUDl8adj6raz+QvNKVEQbpa1S74mpjhOSiB0pzqaL+2JmuQZrR42c/QxsuEEWd1eqSHS+hpaCeseGS9VEBpC8jGvUbOmWBOp8oQ53A2dhPBqL+vaYfIE+/Njs9FhWMh0W15W/shQFHMnPJpXBBPvQWlE/GDSFaX7JBMLL1tyf50i0AgAm7uBBimvfEVXvEnCBNCcYm/m+bA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yg2MfwRaiITANGB5KvOSAQ1TcjDjGwifxAg8X1H07L0=;
 b=pZH6TwEb5iMcwyfU5yJj3jjFH38UACxwqgsG55QVP1DIpmSroT1gWC/FkyZ5ijQ8drTd/vjIadQc/jIPWbOuP5T6qoFqdYisOY9qp9gzv0Q3RKMpfNYVo0xOsAaCQ6Lvtz+61/Yh3jKlJLi7eHBBFVbfPSWPCuWApd66Us4M5R8=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
Thread-Topic: [PATCH] arm/vgic: Fix reference to a non-existing function
Thread-Index: AQHX6CxjOPaugM9lo0aVspePzsZYTqwgjh6A
Date: Fri, 3 Dec 2021 10:19:20 +0000
Message-ID: <B3D7A1CC-6CEB-45C9-914C-6BF5540EA1BE@arm.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
In-Reply-To: <20211203095837.20394-1-michal.orzel@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: 52ce8533-271c-4b46-96b7-08d9b6466327
x-ms-traffictypediagnostic: AS8PR08MB6469:|PR3PR08MB5642:
X-Microsoft-Antispam-PRVS:
	<PR3PR08MB5642700B0EA51E1710BA1AED9D6A9@PR3PR08MB5642.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 eQJ9SaA1rGA7kZ7orCBiE6D7tA1XNVxM5LXgRb8FkrrsBBpcWebTm63ufhTjF7FA1UHRxJjl8cL10eTN/6ETpbmunlr0pmV/GRqGjGnNbaPemkv/fmKEAHi4sFxqwvou1vlU+nSN91F/pKn1LyENhSx6aNLCwT4Ey83S5wFEt+usRrq1753iXhipfZe6hiklztJ7WWK0nMH5a6gyDLxzb0HFOu9p8l/iyVe+GbUT5IPJRh6NmJqsEIt46D4b02+CwGrneuoR7hMmGdQc9d0CNfl0sGwhNepmKtVRMIQ0A3Ggj1jY0n/AqTGdBDqUZBTUWgI917u0v7UChZS0DZw0FLDLcVuR4IllV8+waU35x/Awb7y4IUVDK05uzQnNLqglU8JgkYSoC/ji0l5Yzo6fECUTTkNWLzssZT85doBfkSI3JlLlrggap04JAEExYrB0m2XGVjKKdTs3B0z5lk6wDyKBTyKYPqdrY5/aNzDYPRbRsIt85lH/PePmcZEitK8o5c4A0DEo8BVd30WG5kHzpKrpG4/GqAfKBgktzH2NnHnDnOe1mKh4mhqEs2qGRDSHizj/MHkRjJTOQYUkUbYXxSA+mIvb4VNRWU7fgl9QQXwDl3oEsLned5/jCDUw25fKwIzwkqwgJ1XsyXxG4mGBHdGPMAvPpKGU+zOBJ0w0vHuWhX61wHx6XrIFl8MhHreeTWooRbmH8tZNVwiQjqEpixKnYMsWDL2ePLououikwVKhOQqQs+A0R9sb+peBXayk
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(36756003)(2616005)(26005)(38100700002)(6862004)(64756008)(186003)(38070700005)(2906002)(37006003)(8936002)(508600001)(33656002)(76116006)(53546011)(71200400001)(86362001)(4326008)(6486002)(8676002)(66556008)(122000001)(316002)(66446008)(54906003)(5660300002)(66946007)(91956017)(83380400001)(66476007)(6636002)(6506007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13E2B0937144BD4F881638B62B88C2FB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6469
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	36dfc9a7-c59b-4fd5-c10f-08d9b6465ed3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dDJKcU9TifBxf1rhjBZCjABMrWaHWyW7yrjsl0uBx3yWUMRECHyHvxMEVGrUBwaU3OpSAsOsQqnA6AAJO16UO8nTWc5hm8qZgghNilJElspuncF0AY7X1buqsFeb5foUVCGnSMICHnEUcC3xFNjwDe6Nh18AMEsqlaYgYVPuPy1P+2Sw0jMIdF6zqgeSC76yLilxYhLUk0w+6wz0JYr7nXMj58QiOu/0dEZqghBRg16EDBhKJ+Q4xp38Twnb5kErlHvrsTaxX+H7UKUJ5BGV2gMA25RjCOP2s87X1oTCpaJKPx7g67My64hp0QQk6oL1cXqeNYqtEa9avSk5Z8wQqwl3rOAsoZbw8ESSWmwUwQTNbsJqmYMhQRD8B6Kp50q/NkpSy042RZqL4ebsALd6pEM8f06UBD/4V/lnS8npQ9WLjAVXvoq2JOyDlBDXWwHbwfGhuDLd8P88eb50Z04+w+mGh3hQelSpcJGub5BPSudeuVVTjCOJew61RTMlJ3D1LHb509Pz1UsswyEksUnTYn1e90aR9mlLfua7GhHWgctRVNd8YKH2c5VkN2hQrM+trW9+N9aBn+azKZ5nmtUpo216Q3Bsi3d+UYK8OxSUFi/cadPB9MkEDbBi7Pakw8mqWAu9fIb4bqvBkH0ERBGteohvE467mdLrnsjPhqOQrHzNKcRN318OxuD81gYRQ+kXtH2wEw84mWUd1aujTkR1ow==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(8676002)(83380400001)(36860700001)(37006003)(82310400004)(54906003)(508600001)(47076005)(316002)(2616005)(81166007)(8936002)(26005)(86362001)(36756003)(33656002)(4326008)(6486002)(336012)(6862004)(107886003)(53546011)(6506007)(356005)(6512007)(70586007)(5660300002)(186003)(70206006)(6636002)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:19:27.7070
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ce8533-271c-4b46-96b7-08d9b6466327
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5642

Hi Michal,

> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
>=20
> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
> forgot to modify a comment about lr_pending list,
> referring to a function that has been renamed.
> Fix that.
>=20
> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Thanks for that

Cheers
Bertrand

> ---
> xen/include/asm-arm/vgic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index e69a59063a..ade427a808 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -195,7 +195,7 @@ struct vgic_cpu {
>      * corresponding LR it is also removed from this list. */
>     struct list_head inflight_irqs;
>     /* lr_pending is used to queue IRQs (struct pending_irq) that the
> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) b=
ut
>      * no LRs were available at the time.
>      * As soon as an LR is freed we remove the first IRQ from this
>      * list and write it to the LR register.
> --=20
> 2.29.0
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:27:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237270.411494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5mt-0007Y4-MW; Fri, 03 Dec 2021 10:27:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237270.411494; Fri, 03 Dec 2021 10:27:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5mt-0007Xt-IM; Fri, 03 Dec 2021 10:27:31 +0000
Received: by outflank-mailman (input) for mailman id 237270;
 Fri, 03 Dec 2021 10:27:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt5mr-0007XE-TZ; Fri, 03 Dec 2021 10:27:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt5mr-0001sn-O8; Fri, 03 Dec 2021 10:27:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt5mr-0007p7-FZ; Fri, 03 Dec 2021 10:27:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt5mr-00017W-F3; Fri, 03 Dec 2021 10:27:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=d8QtGk8p9kbg1W36QpdTY2uHLdls1PdZzAVjgomGxgw=; b=u/sP/JOQ2R5ZPrKxXoCQZ4b+ah
	aHIzr/KPTXc4pE5+e6jz4eqtHDv3K3Dg9Dkxcu41fA7QtltJEpYnQcbb+qQWWBVmvCmeGVBcCqF70
	G0DBXa/3XpbVm1VYB91IE+dek9xRZLcf24VRFHXcuqTPoAP1/u/8rEsnIPGnHy7eYV4Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167042-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167042: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-stop.audited:fail:regression
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-destroy:fail:regression
    xen-unstable:test-amd64-i386-xl:guest-destroy:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-pygrub:guest-start.2:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-cubietruck:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 10:27:29 +0000

flight 167042 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167042/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-xsm      22 guest-start/debian.repeat fail REGR. vs. 166912
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166941
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 166966 REGR. vs. 166912
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 23 guest-stop.audited fail in 166966 REGR. vs. 166941
 test-amd64-i386-libvirt-xsm  22 guest-destroy  fail in 166975 REGR. vs. 166912
 test-amd64-i386-xl           24 guest-destroy  fail in 166975 REGR. vs. 166941
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166999 REGR. vs. 166941

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl          14 guest-start      fail in 166966 pass in 167042
 test-amd64-i386-xl           14 guest-start      fail in 166966 pass in 167042
 test-amd64-i386-pair       25 guest-start/debian fail in 166966 pass in 167042
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail in 166966 pass in 167042
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 166966 pass in 167042
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 166966 pass in 167042
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 167042
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 166966 pass in 167042
 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 167042
 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 166975 pass in 166999
 test-arm64-arm64-libvirt-xsm 14 guest-start      fail in 166975 pass in 167042
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail in 166975 pass in 167042
 test-amd64-amd64-pygrub      22 guest-start.2    fail in 166975 pass in 167042
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 166999 pass in 166975
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 166999 pass in 166975
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 166999 pass in 166975
 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail in 166999 pass in 167042
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail in 166999 pass in 167042
 test-amd64-i386-xl-shadow 22 guest-start/debian.repeat fail in 166999 pass in 167042
 test-armhf-armhf-xl          14 guest-start      fail in 166999 pass in 167042
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166999 pass in 167042
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 166999 pass in 167042
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 166999 pass in 167042
 test-armhf-armhf-xl-cubietruck 18 guest-start/debian.repeat fail in 166999 pass in 167042
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-xl-credit2  22 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166966
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166966
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166966
 test-armhf-armhf-xl          18 guest-start/debian.repeat  fail pass in 166966
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-xsm      22 guest-start/debian.repeat  fail pass in 166975
 test-amd64-i386-xl           22 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail pass in 166975
 test-amd64-i386-libvirt      20 guest-start/debian.repeat  fail pass in 166975
 test-arm64-arm64-xl-credit2  18 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166975
 test-armhf-armhf-xl-arndale  18 guest-start/debian.repeat  fail pass in 166975
 test-amd64-i386-libvirt-xsm  14 guest-start                fail pass in 166999
 test-amd64-amd64-libvirt-xsm 14 guest-start                fail pass in 166999
 test-amd64-amd64-pair        25 guest-start/debian         fail pass in 166999
 test-amd64-i386-libvirt-pair 25 guest-start/debian         fail pass in 166999
 test-amd64-amd64-xl-pvshim   22 guest-start/debian.repeat  fail pass in 166999
 test-amd64-amd64-xl-credit1  22 guest-start/debian.repeat  fail pass in 166999
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 166999
 test-arm64-arm64-xl          18 guest-start/debian.repeat  fail pass in 166999
 test-armhf-armhf-xl-credit2  14 guest-start                fail pass in 166999
 test-armhf-armhf-xl-multivcpu 14 guest-start               fail pass in 166999
 test-armhf-armhf-libvirt     14 guest-start                fail pass in 166999
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166999
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 166999

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail in 166999 blocked in 166941
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 166999 like 166941
 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 166999 never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail in 166999 never pass
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 166999 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 166999 never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 166999 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 166999 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 166999 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    5 days
Failing since        166960  2021-11-30 12:35:41 Z    2 days    5 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    2 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        fail    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 396 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:27:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:27:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237269.411483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5mq-0007HX-DO; Fri, 03 Dec 2021 10:27:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237269.411483; Fri, 03 Dec 2021 10:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5mq-0007HQ-9w; Fri, 03 Dec 2021 10:27:28 +0000
Received: by outflank-mailman (input) for mailman id 237269;
 Fri, 03 Dec 2021 10:27:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt5mo-0007HK-Va
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:27:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ba845a4-5423-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:27:25 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-JRSZj1emOoa2WVAMWPpPlg-1; Fri, 03 Dec 2021 11:27:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:27:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:27:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:20b:110::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 10:27:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ba845a4-5423-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638527245;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=qd/TigLIzjUj24lc/Dw5lF5QbUtrPKoswGl6ERzbPRs=;
	b=UrvHToatpmM+p4sLHqTU8mrKSA0HOcXRfNbuPjdVo0l2V3wTnjJyRu3MsPxNH91IeX1TJX
	I5TYg/WAHvrlsmgP/3sTdjOb4g0gvy01uvtOHVheIPX51AsQdLaVvuGf3FJsis9Y2pJlz9
	u1IzLRTsjNp0M5VsKl+GHajug80ozHk=
X-MC-Unique: JRSZj1emOoa2WVAMWPpPlg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Me9qDNkpOm+Z6qAOZZIXFkxSH3Sw3iI7yWCzcp7APS9afkd+7H7EZXMBmYeUoCWYrKipoZWbfzcdHJxmYNk/aKSgawqKnqCuiilFWNnqlnocNqMARS3ETnUvdo8+sh+YegtUYpRGq9+bANgBmQhH4J7ggOJXPmrmTRAa1YGpWuCfKZ4Z6s5xJaXM8fkpRIRxWmLSyHN/nMXVzZb18n1nIB6WdL7bV4RS9zXrt9JY1ABU3DVO1vapxgUioald6+D8XEU850dUlrHF7LRuC/ZQXCyp74ndUd66RXDH/P5DL0dywjx6AWZ0dnDRUJ7Iqix/xnea7yLeYp/rIhJXTPQxcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qd/TigLIzjUj24lc/Dw5lF5QbUtrPKoswGl6ERzbPRs=;
 b=HbIEi2/UoJgSMaVAXy/Swj0w39Ogk0889fSdbxcp0SzBiyuCZCLw+NcF911EwWzYwMa4oM1pSNZalX2Cqd5Ey4OVdk/0pHo0CRbbHCqP/0CVyT6oz66oB5b3E0B64yuzgPaf9iCCVlm4fcx7hCn5e5btosF9ZCwDhcucRxjmiVPjbsKbmDJjaaut7Dk7T8UxlabrnqKsrPwZ+bdTdGEhUKsg+NRDIeKnIetvI396OsR2UrA6aYIHt4Z6in3zB92cCoqciCfxbQgJc1C5X8Fi0JIuhMD/4BONYMPzFhwCTmOn3Vh+mlNPW1AZ788LsYwztuCnUcy7xEYeI6mT2aWNvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5d675c6c-8cb1-f218-75d7-cb13f8b2e669@suse.com>
Date: Fri, 3 Dec 2021 11:27:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v5] x86/PVH: improve Dom0 memory size calculation
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR04CA0004.eurprd04.prod.outlook.com
 (2603:10a6:20b:110::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 11b10955-8600-4235-efc4-08d9b6477ddd
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352E591C86796834D550CABB36A9@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	H968a875WSSATk4y6pGNmAODxk17gjzR3Qxk2prr/nU4FIstP12GCy3wndP454BRwQLfk6Oel4cw5GTySqXBN0VKk0RKRbNeJW7E2Z9IuMZWLmMWTkV8JH7vjM58ffJTOKFPeSoeNhpwalFPu8ovSy4/Z2Y13TV9np6gHoaC5PKXGuOfsA5uHaLbp6ouGK+a4Ll4kP+dw7B5NQZAuDk1myMrx1oCxU/dJlEY15z7GtuhbBqfkYd5CzFcFHKXDZ5njsZeJdeuNYhsx5nVazjBwp5s478mwV498LIwPvWmY9RpbxGxNn+rOQdMFiq9Hrzs9UOOG6NxmP/U4ueHlrW1H5Y5LQHTVaRysg2HHm6nIiJJ3/ecaLw4YVWk2GdHzx0WiGdj//e7N9rbQO8vp8XVJQ64UdnrDCOUIQT+6iUDARg6IbhkqTBM/yNrK4dn6yIlvnNaXb5BltK0eYF6pWtsPzvVf9IN3ezZMPca+7FLFXEHVd0wstcaiIpWy4U3344UkYcv/7fNNXUzXkK/pfBguoGLTpIEW0tdFtMF1iJX9G3sHx/nXplOTqXlvP336d6brr1ZkxUGj2erJMzSMIqKFO68EefdhfZogegrlB+Hlty5T3qqAjTdbnaSk6QReR1kbJ9aZOx3PxS54lfxdvdIgIT3LbBtLdeaeCkKZt26dw6N+pWayIL0Fr60NZEdxIt6CqiHm/CWNPHVG2M3oENzBz1A/BRhzO5kIkGvyNCjn6RwjSEmT37U4MGY4OIBCVeMxY1VPseEolo2SgKKAlPJTQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(2906002)(31696002)(31686004)(956004)(8936002)(508600001)(36756003)(54906003)(86362001)(16576012)(316002)(26005)(186003)(83380400001)(38100700002)(66556008)(66946007)(5660300002)(66476007)(8676002)(6916009)(6486002)(4326008)(25903002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UVFYZm16SUJNZnRlYi8zRlFudFExeW5nMkZKS0hLTWRWZWYvRmlkS1dYenRr?=
 =?utf-8?B?RjFQNHpaYXNpTm5XUlZIejVBVy9ZNGFOZkdaTm8wSDlESHNYWklwUXBuejAr?=
 =?utf-8?B?RlI0K0dJWXdUVmNoeWZzTXV5bldhSVdINWd0c3pkc2xZVmxWdHoyNUtKRnRr?=
 =?utf-8?B?QjFhQnVmRThZS0M2TmdHOXJsRG5MaFFoY1AyUXhFYXdkN2RxTWtZZTM4aGNl?=
 =?utf-8?B?OThoZzZsMGhzMW1HRmxkVjd4M1pTeHpCNVk3UXFOdUU0WWoxV1F4VFgrOGI2?=
 =?utf-8?B?K1V6Z1IzNE9hdmNKLzFWK0FKMGFKcXlZdUkyMzcvNE5zQzFpRHdiYTdXS3pC?=
 =?utf-8?B?MExwWjBDNkVheGNOZDhjQVlzRlZRSmIrUWRUQU5MNk5kV3EzbURiaGJhUGUy?=
 =?utf-8?B?THcxUHdrNlBackNOWUtxdzIvL1JETkdmaFlBWWVCcFd1TzdqSm0vcUJFMnNF?=
 =?utf-8?B?R3hDTmZadDVHaDRpMVIyOFhBc0JoQXptVExRUWxISVU4MnEvNG5MS2ZvRWV1?=
 =?utf-8?B?QjllWEVPUUYzSmd6ZFpEUUJRRFB2ODdvRWNNUU5pOWxxSWR2THRoV0RLSnpz?=
 =?utf-8?B?amVBMDJvaVBVTmFZUEUxTGtxc205aW5Ec1RIODZidmdUK20xMEhmYytGQmRY?=
 =?utf-8?B?OGxGa2hGWTAydEpxMnVOK1NHdU0vYTNpSzM3dkZGdTl5a01vMzlTdEFKVEht?=
 =?utf-8?B?aU5GeW05OW82TEpCSDNyTWVzcmt0S1phdkt0aWxFM0RQMHJ2a1pGT1dVQUF1?=
 =?utf-8?B?a2wzaStIRzlFcGgyVEs1TUhlS25TaUl5UjByL2hMUHJHYTJFbmp0NUx5YUx3?=
 =?utf-8?B?SVdFS3h2UU80ZndaQU1hZkprYkJrbE5ScFUyVU1KWTR6NlNlSnFqVUx3cWJD?=
 =?utf-8?B?MkkvR1h4VFlwQWNKd3duQnhQeU9tcVN0dlN6R2l3ZGY2d1ZEVzNMR1hrbFNj?=
 =?utf-8?B?dXRSekI0MHJlWDJwZEg2VXZhSUQ4eHY2NHpKdm5MQ1NkQkVVN2o2MGVkL1d4?=
 =?utf-8?B?QU5MOWxua2dPd3c0dWUrZDV6RmVXV0VvcG82dDZrY1hVSDdqbThaMkJmVjFw?=
 =?utf-8?B?WDFWS0FtbnEzQkVRVzBXWDd6UkV4ZElubSthWlBiQ3VzWDErUGorNFp1L0Rq?=
 =?utf-8?B?NUdDeCtvMys0Ym9pUGhwNi8yejlxbUxFaXJvZnI5Vm85VlRtS0ZnbWRwTzRh?=
 =?utf-8?B?b0JnUC9OS2dlVVErVXhDK1FGOVEzaHpDb3pHdHBqV2pYc09SSFQyZldTQmVl?=
 =?utf-8?B?WEw5MFl4NWdXTFcwRitqY0ZrSk5YS1ZwNzkwa05tcEw5alhydFh1cFcwNGQr?=
 =?utf-8?B?eVRKeHFMNHNqNzF1NjEveHk0YVd0RDRaUGhQd0dqZjhBQUxIdFpZQkhLNGJR?=
 =?utf-8?B?SEJHNVdKU1lMRk9Ob3hLcXNiU0VpdlVCbGRLaUp6cHI3dWFaNWRnd3FPMWl6?=
 =?utf-8?B?bHR0eWc0NUhJby8yRUxEYWFkVVZKSDlWdGxIQS9ZRHVWTTF1b3h4ZFkwSUVC?=
 =?utf-8?B?RVVLV3pZYjI0V3cvT2N4dEo1Rk0vSGtyMTRkOXRabmVYeHh2dndGRlA0NWpi?=
 =?utf-8?B?NkluMDY1aXdiZDhKWlk3SVZWMGZaWnFDS1dJSm9RdThENCsyQ3R2NnIxWHc1?=
 =?utf-8?B?TVBKNlB1K0hieGEvSGFxVG53am91eGFQTWdOd2JudEJtQndrRVVyMUNBTG5K?=
 =?utf-8?B?ZzVPRU41YjlMeTd6clNsRFRFOWVDbFZlU3ZDSUY4NE1sZ01XM0YwcmJBUjFY?=
 =?utf-8?B?dkxVcUxDT2lvWS9Od05xUXo4bytPLzRYN1U1cjRYTksyMDlPQUgzVEUzOWY3?=
 =?utf-8?B?SEVhcFZrb2Rmcmw4RHVPdm03Y3plc3N5VUkvMTFRajBpc1pSY0FxSkZGN1Jl?=
 =?utf-8?B?MnFJdWhCdzl2Ry9QV1NBOGwxMTlJZ3pUdjFXc3dQT3g0ZStKUndmcFA3V2hE?=
 =?utf-8?B?dnIxOUl2NnhHSkJFcFhvejQ0SVY5UGtiQ0UxdWdpVHZJa3NJM21TeXVqOG91?=
 =?utf-8?B?NWk1RTdGbENqdFBqbWwzZnNubWdmaWJieFRIMWUydlJ5dHRYeTdlWE4reW9C?=
 =?utf-8?B?Q01qdStlaHV3ajBIeTJIS1VzRjVWeDNsUTBGbUxqR3diWkFGVEZlVUp4K2V1?=
 =?utf-8?B?cUQxcVlvcDNUaExISmRBeXlGbmRxdXMvZXhtNmR5SWh4eVl4QWNMd3FBcGFa?=
 =?utf-8?Q?HfDwxmg7Et1yVRhaCN6MjUI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11b10955-8600-4235-efc4-08d9b6477ddd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:27:22.1315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6usmQgYID0yeUgHE/pkw7qxr/rlwmRN9b7VkPfIb6o2xXi+MXApcjelLPew1mKYHpC2eWddAuOLbUOR4iAZNeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

Assuming that the accounting for IOMMU page tables will also take care
of the P2M needs was wrong: dom0_paging_pages() can determine a far
higher value, high enough for the system to run out of memory while
setting up Dom0. Hence in the case of shared page tables the larger of
the two values needs to be used (without shared page tables the sum of
both continues to be applicable).

To not further complicate the logic, eliminate the up-to-2-iteration
loop in favor of doing a few calculations twice (before and after
calling dom0_paging_pages()). While this will lead to slightly too high
a value in "cpu_pages", it is deemed better to account a few too many
than a few too little.

As a result the calculation is now deemed good enough to no longer
warrant the warning message, which therefore gets dropped.

Also uniformly use paging_mode_enabled(), not is_hvm_domain().

While there also account for two further aspects in the PV case: With
"iommu=dom0-passthrough" no IOMMU page tables would get allocated, so
none need accounting for. And if shadow mode is to be enabled (including
only potentially, because of "pv-l1tf=dom0"), setting aside a suitable
amount for the P2M pool to get populated is also necessary (i.e. similar
to the non-shared-page-tables case of PVH).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v5: Fix the case where no command line (or built-in) option was given.
    Further re-work of what was done for v4. Also check
    opt_pv_l1tf_hwdom. Actually remove the warning message.
v4: Rework to eliminate the up-to-2-iteration loop.

--- a/xen/arch/x86/dom0_build.c
+++ b/xen/arch/x86/dom0_build.c
@@ -19,6 +19,7 @@
 #include <asm/io_apic.h>
 #include <asm/p2m.h>
 #include <asm/setup.h>
+#include <asm/spec_ctrl.h>
 
 struct memsize {
     long nr_pages;
@@ -321,12 +322,22 @@ unsigned long __init dom0_paging_pages(c
     return ((memkb + 1023) / 1024) << (20 - PAGE_SHIFT);
 }
 
+
+/*
+ * If allocation isn't specified, reserve 1/16th of available memory for
+ * things like DMA buffers. This reservation is clamped to a maximum of 128MB.
+ */
+static unsigned long __init default_nr_pages(unsigned long avail)
+{
+    return avail - (pv_shim ? pv_shim_mem(avail)
+                            : min(avail / 16, 128UL << (20 - PAGE_SHIFT)));
+}
+
 unsigned long __init dom0_compute_nr_pages(
     struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_len)
 {
     nodeid_t node;
-    unsigned long avail = 0, nr_pages, min_pages, max_pages;
-    bool need_paging;
+    unsigned long avail = 0, nr_pages, min_pages, max_pages, iommu_pages = 0;
 
     /* The ordering of operands is to work around a clang5 issue. */
     if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set )
@@ -344,53 +355,47 @@ unsigned long __init dom0_compute_nr_pag
         avail -= d->max_vcpus - 1;
 
     /* Reserve memory for iommu_dom0_init() (rough estimate). */
-    if ( is_iommu_enabled(d) )
+    if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough )
     {
         unsigned int s;
 
         for ( s = 9; s < BITS_PER_LONG; s += 9 )
-            avail -= max_pdx >> s;
+            iommu_pages += max_pdx >> s;
+
+        avail -= iommu_pages;
     }
 
-    need_paging = is_hvm_domain(d) &&
-        (!iommu_use_hap_pt(d) || !paging_mode_hap(d));
-    for ( ; ; need_paging = false )
+    if ( paging_mode_enabled(d) || opt_dom0_shadow || opt_pv_l1tf_hwdom )
     {
-        nr_pages = get_memsize(&dom0_size, avail);
-        min_pages = get_memsize(&dom0_min_size, avail);
-        max_pages = get_memsize(&dom0_max_size, avail);
+        unsigned long cpu_pages;
+
+        nr_pages = get_memsize(&dom0_size, avail) ?: default_nr_pages(avail);
 
         /*
-         * If allocation isn't specified, reserve 1/16th of available memory
-         * for things like DMA buffers. This reservation is clamped to a
-         * maximum of 128MB.
+         * Clamp according to min/max limits and available memory
+         * (preliminary).
          */
-        if ( !nr_pages )
-        {
-            nr_pages = avail - (pv_shim ? pv_shim_mem(avail)
-                                 : min(avail / 16, 128UL << (20 - PAGE_SHIFT)));
-            if ( is_hvm_domain(d) && !need_paging )
-                /*
-                 * Temporary workaround message until internal (paging) memory
-                 * accounting required to build a pvh dom0 is improved.
-                 */
-                printk("WARNING: PVH dom0 without dom0_mem set is still unstable. "
-                       "If you get crashes during boot, try adding a dom0_mem parameter\n");
-        }
-
-
-        /* Clamp according to min/max limits and available memory. */
-        nr_pages = max(nr_pages, min_pages);
-        nr_pages = min(nr_pages, max_pages);
+        nr_pages = max(nr_pages, get_memsize(&dom0_min_size, avail));
+        nr_pages = min(nr_pages, get_memsize(&dom0_max_size, avail));
         nr_pages = min(nr_pages, avail);
 
-        if ( !need_paging )
-            break;
+        cpu_pages = dom0_paging_pages(d, nr_pages);
 
-        /* Reserve memory for shadow or HAP. */
-        avail -= dom0_paging_pages(d, nr_pages);
+        if ( !iommu_use_hap_pt(d) )
+            avail -= cpu_pages;
+        else if ( cpu_pages > iommu_pages )
+            avail -= cpu_pages - iommu_pages;
     }
 
+    nr_pages = get_memsize(&dom0_size, avail) ?: default_nr_pages(avail);
+    min_pages = get_memsize(&dom0_min_size, avail);
+    max_pages = get_memsize(&dom0_max_size, avail);
+
+    /* Clamp according to min/max limits and available memory (final). */
+    nr_pages = max(nr_pages, min_pages);
+    nr_pages = min(nr_pages, max_pages);
+    nr_pages = min(nr_pages, avail);
+
     if ( is_pv_domain(d) &&
          (parms->p2m_base == UNSET_ADDR) && !memsize_gt_zero(&dom0_size) &&
          (!memsize_gt_zero(&dom0_min_size) || (nr_pages > min_pages)) )



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:28:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:28:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237281.411508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5o6-0008Vp-5q; Fri, 03 Dec 2021 10:28:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237281.411508; Fri, 03 Dec 2021 10:28:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5o6-0008Vi-22; Fri, 03 Dec 2021 10:28:46 +0000
Received: by outflank-mailman (input) for mailman id 237281;
 Fri, 03 Dec 2021 10:28:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt5o3-0008K0-Oi
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:28:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c9e6582f-5423-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:28:43 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-ww_8QyEVN3Oq6BCyi27G-Q-1; Fri, 03 Dec 2021 11:28:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:28:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:28:40 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:20b:2e::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 10:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c9e6582f-5423-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638527322;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zQPfrq5PnLPIcrr5GCqLB0gNS8JjF4R/bwJtL4gdSxc=;
	b=TdmAYv92GkFn1eaZNF5YgXvEJnHR6tFqibqoyOX47zOy/93dtQJD3eQ+6vYLaHiGWce2nk
	SmYYmHMx2rYB81yXZ+JFpCK8lgDFJIPORnnFiEwCZop63ORIal0EiDwuVsk6564x7dpXFk
	ZfhTPeTeGwZQVDFFoetam5gFAkwI6i8=
X-MC-Unique: ww_8QyEVN3Oq6BCyi27G-Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gE9jq2vvdl7F6GK5ulA56fuPSNxAuVbqdu/jP7NHQ173fH/5GWZQUf2pCd0zYa2TowfBlMNpEUiDvn/USv/zDIqGow3ppDtKw5lukpltDCYK7zi4M4yVvD8uPSV5V6oethEO1OstPBxr0f62awO4AbYvQeWx1z0pwSCkHOdAStjvwxaX+3/4O/ddUU2d9pvGdhqSyILB1L3/1OJ8FPM0GtSYN8ZgZsnJ4SHn3lQEi6YkPcmCKBmf1jt3usvWi+12SyZZ/ZG+vOjcexMXq3Gr6QWxIGGbxgokf784fMFDjQHj9fbWhQLx5KmSl9wyu708yBzX785dbkChJ9gRG/LM+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zQPfrq5PnLPIcrr5GCqLB0gNS8JjF4R/bwJtL4gdSxc=;
 b=Vjc0dcz3HyuKbGmu/tlby0RuLXfDVMO6kRqRhfIhigxJbTbkOTwAXhY5sawN74mZj8zdeTTN0Ct0ksPkOICCdNWsyCHQ7bhBkwl0CVphr2Xx4pd93tpzvBjeHUvpG1XzLyvaufScNSqYIV70hKQQ6Kaz4y0to3ndAdk8I7BsCj87j9JxTmJj67zhqWRXV7AKvKYaqwZD502N6fmCpVciLlAzBkT9ND1xFxPfcc+1Odr5+0m/oKhfR/vEzE9zNz6lNUCqNV/yE5aUlJpo+0dcb+IDeh7PG0OB4ABV+ciUlRo6rrqlLtNfh7liGprnsC/JxtWiEQ5t9sfdFJ6lJIER7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <05eeb76d-3aed-f543-f0c0-dcfe4e2bcb6e@suse.com>
Date: Fri, 3 Dec 2021 11:28:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0023.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf500c7e-74b8-4747-69cb-08d9b647acbe
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352430B05CF16C5DAF1F904B36A9@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kKr9mKhb/IcvUis49SnYvGKdG8ym+wUFiUL1MHe5ss2jZsCIbE5zXN6OTgoMOY+q338JnTyvKoNEU9Dj7K1w6K+0JtsFIc3hE7Ghye/aGEPrUmK5+4KeogsI+h5+D8nphcoIvyIMx3kq9rwZC4XPuVD1bVNqpkLzC2ZSX/U2gGYxAt1zFo1LBBQWmF41I8TGq2FD7B40iIVPpEaVO8ULWGAZSJoUAfFOmYix0oQ7ne+xb2jfdTbTSRlkk8Uoo3wEi6d6XLs34d5RB1UOpM7KZhc/EMmHoHvN0orSI3+mJa+9Z27MfQn5IGHs+fnEC2PDbYANIcx8phgImi9WxSzO9XlRPkMeMPyYAg4kzBT3JtKduyCRUv6O12qt8w57yXdDMl6C5+jpv0sccvBusr1Kv/pS2Z0tthL3Y9tgSygLK+iqVFzu7gr/rKOsYdMuwU6tBz8PftQqHO4iEi5sqhAt7iujb6FhMFNIXJ4P7ntSsWf95xwgIvgfy5+gmYlJpBBV7Wr7WSI0lnT3M/z/h5xImYozDbYAHcSfQYQqAgCW8FMghbv+XgsBXF5WrPt0vOZwcSLF+aE1WNnNK5ZcMmNibErN/QIH7hjEgz3D67iO3GuCVXVY1GzjpTuC5nuRydwrDNC+JljgKjo2rJhau3ltwMFWfxSKt+sJbPOlYN8duFgwpon6IB14Emqy8cTDmYjZvHrZBvAVBW6RQ948f5dXi6AtF5/lJlZP8sjxrufZAY6+I+gQKaIFtvTevYCYHLK/
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(2906002)(31696002)(31686004)(956004)(8936002)(508600001)(36756003)(54906003)(86362001)(16576012)(316002)(26005)(186003)(83380400001)(38100700002)(66556008)(66946007)(5660300002)(66476007)(8676002)(4744005)(6916009)(6486002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzFDNVJrb2FSYzdrcVNxeldXdmVjYlhrT3ZHVlZjV1ZvOHpZYnVEK3ZJQS9Z?=
 =?utf-8?B?MStYeVVEOE5pZDNsNGtRR0hqRjVlMkw0SG5NOUUxak1KeXRpWTFSa2g0NVlo?=
 =?utf-8?B?enpKcE5wM3B6cXJ5TmhsVDQreGxIQjN5MTNGQXFEaFdOUzI5ZXEyTzhnSTAw?=
 =?utf-8?B?ZXdRYkpmY1lhKzY0RU5nOXJRSjhuZWZla3lqQnc3a3B4cE5qUndxcFVXK1gx?=
 =?utf-8?B?M1ljeEVzdWQ3dUhmSWUzQ1UxN1E1eWJnMStkZTlmSmxVU1FrR2JWdmZDMm1m?=
 =?utf-8?B?eUFwSmFpYUFLSHZOdHBDKzBMUXRrUXB6RUlzeld2TGVpV01qektoOFhmRzhG?=
 =?utf-8?B?NExSUWZKZTRTakxaVnBMa2FKeWxOSitCZ3p2N1VoczY3Tlphd2gwbWNTR2lz?=
 =?utf-8?B?V1dFaWE3SU96T0h5YUV4dkNHODNsaUk3dUFMVlZob2RTalZpOExDOFY0Mi8r?=
 =?utf-8?B?QWRQZUZ1L3hhWnpuWjJRYmM2bUtCejh0RjVlTXpOU25rT2xkZ3NvZURhNllX?=
 =?utf-8?B?UWtGeDB4VDYrNHlFL1pNR3U3RXMra2pLRDZSa3Frb1cwOTRld3JjWmRmaHNl?=
 =?utf-8?B?RVVnWGlWM1A4VCs2WWlnRm92UC9GSG44aFZrU3JOUVVHRzNuUHoxMzVVTFdL?=
 =?utf-8?B?SlZZbUJzV2tFRWw5U0NGQ2xnTDVtckpTVFZVaVZFaGsxV1ZDMWJjdWhOVXUy?=
 =?utf-8?B?Q3NFSkVhM3JDa1d2cytkalFsWHQ4b0puaFRla2tvRTdsKzRJRTdXdG5PSFYz?=
 =?utf-8?B?Z2lEYzc4TmJObDdmV09UWjdMelFpMWtpajBLcG1jaGtXRWRPd25oL0FYaXFr?=
 =?utf-8?B?M3JMR3Rab1NXTUgzYXBNNUVLYVljd2N5clhhT0JTa0lvUFNZWWltT21SOWhn?=
 =?utf-8?B?eXJzdTNUcVNLbmEzQUw1VGc1VXBBYnpuVTE2OUg3VzNVS0lmdXVhN3ZGOW1T?=
 =?utf-8?B?d0cxZC9obThsL3ZsWkFjZjZEUVpCc3YvMFo4Ymg4ampHVitEL0kraXdGNEs2?=
 =?utf-8?B?R2twQnVzWXlWWmhkbUJSWDk0aE02dmthSUhsdlVpelU1RUlVSEM2a3ZSK1Nk?=
 =?utf-8?B?YVU1QVFoQjBSWlB2cFh4VDI2dzVSeWNWcFNjZE9YZ0RyckZJNWh6MDFsR3p5?=
 =?utf-8?B?aTJoMTl5dExiaXVRU1FmdVRKQTk1UFlQSUhvMWtWU2prclVsWFl4MGg5RFJV?=
 =?utf-8?B?Q0YvZWtzV0RRZlozTVhBelRiOEh6NFZ3dHVHVzJjY3NQWjZ6Z01XMU56SFZQ?=
 =?utf-8?B?TTRkZDlLOEhhcTh0NG9STDVlZ2lpRDNOMFI2VmJ4V1lvVEJIallBYUd6ak9H?=
 =?utf-8?B?dWY0ejFYWmtiYkU2NXNtcnVDSFA2VEkyVVNuTmRBRm9YUGVkY0pZZFpiYlZN?=
 =?utf-8?B?Z1dBYkJDSmV0OWJXaHVCaU1oQzFhNkxKSjR6RnhxYzZETG9qMmVHYmRmNU9H?=
 =?utf-8?B?US9TOWVUQUFacGdzWW1XNGhnNExQS3RiTkxhTjZHSGV3N0xvbU5FNVZpWThF?=
 =?utf-8?B?Y2hhdzRlVFBFQzRSYVJlT2FQbkdramhPVWJ1blFaQ0lUYWJVWEZHQ3JMQUk4?=
 =?utf-8?B?WXhQR29SZzB2QlJnV3k2Z084ZURaV0s4Ukl6MkM0NXBpNXQvU0VjdVRKenhV?=
 =?utf-8?B?c3ZVa05nVFhCVStHS1d3R3luYTJsamcyeW9iZjNERHZxREh2dU5mSUhwUC8w?=
 =?utf-8?B?Vm5KMGxkODRhMlN0RkR4bHJ6b0RTMFgza0ZyL01FVHRDaXZLMFVKYXNWMGhE?=
 =?utf-8?B?Q3FxTisrK0VKbjRCV3dqUXdSc2JncXFQd0IyYkYwaGpQZGUraXJBUiswSzNS?=
 =?utf-8?B?d0ZDem9XQnpkdzlSZTgrbTdqRHkreEFtUE9vL2FSOEtLVU56dGpNenlZTEpG?=
 =?utf-8?B?b29uaVFTMjRaeVdiRWJWc0dONFFVWHQ4WDA5eVhtVjQxZko1MWdnMzZjSWJI?=
 =?utf-8?B?cVVrVWc5REl3eE5DQkFNZnVEZFlsa1daWkNwMUttMC9pYXJFMkVxUFJ5aU5T?=
 =?utf-8?B?K1RESndOZkRuOGRkVU9NMHBTTXB2amFDNnBhSjIxL3Y4bFFGTHJIenlNMWlw?=
 =?utf-8?B?c3Nhb1F1NlFuUFFiUzByOEZPeGhDWi9kWFV6YnFIa3RSa0Z4UldkY0YrMHl3?=
 =?utf-8?B?L3UxZktxN2ZTU1RJQlk5eWZ2N21DcG9mWnhIWmYyYzVUWmNkUEJKcU9xRG1G?=
 =?utf-8?Q?Sq/icaNo9khTqhfZbinaP1M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf500c7e-74b8-4747-69cb-08d9b647acbe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:28:40.7728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cRwYuU50Llv3OyfnyZA+dkSGgfEvIIpxrrJ7apD3vy3d6ihBfITaekrVUGzQKVX63X1A1KufqsFr3i2mIelQsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
running in. Permit further PCI related ones (only their modern forms).
Also include the USB2 debug port operation at this occasion. While
largely relevant for the latter, drop the has_vpci() part of the
conditional as redundant with is_hardware_domain(): There's no PVH Dom0
without vPCI.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v5: For now leave out PHYSDEVOP_{prepare,release}_msix and
    PHYSDEVOP_restore_msi_ext. Drop has_vpci() part of the conditional.
v3: New.

--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -94,7 +94,10 @@ static long hvm_physdev_op(int cmd, XEN_
         break;
 
     case PHYSDEVOP_pci_mmcfg_reserved:
-        if ( !has_vpci(currd) || !is_hardware_domain(currd) )
+    case PHYSDEVOP_pci_device_add:
+    case PHYSDEVOP_pci_device_remove:
+    case PHYSDEVOP_dbgp_op:
+        if ( !is_hardware_domain(currd) )
             return -ENOSYS;
         break;
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:33:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:33:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237288.411519 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5s1-0001We-Na; Fri, 03 Dec 2021 10:32:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237288.411519; Fri, 03 Dec 2021 10:32:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt5s1-0001WX-KU; Fri, 03 Dec 2021 10:32:49 +0000
Received: by outflank-mailman (input) for mailman id 237288;
 Fri, 03 Dec 2021 10:32:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5e4h=QU=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mt5s0-0001WR-Az
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:32:48 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a0e6c18-5424-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:32:46 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1638527558682794.7941430149524;
 Fri, 3 Dec 2021 02:32:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a0e6c18-5424-11ec-b1df-f38ee3fbfdf7
ARC-Seal: i=1; a=rsa-sha256; t=1638527561; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=JkIDVH9Wb5ZqmknRJlkR+8Zg8NnpOByef3lHBO2BGy0eqSo56/n/iz3BQcYVLKRbC24uFwmqs5i/lGFRPXA9hHuTPvTlI+K3pYq/BngWxNnMp2jhMN7wTVsU24Ss1sv2CBcTehhUZFuQ3lOyyfvzMnriyGeD7Ix6ssXqZG4Q9gQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1638527561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=IzlS3kgJSrMonzIiyfZ3uL8xyz5tf3DhYMDDDegUafc=; 
	b=WG3rCzIG0xVLE8NFBJDznm8Cei07od5chXBKQvsgJCx8Fpu1WOP9YoNNFm3/m6cByANtiibv2He+p2x3y9w3eHWKOKwdl7L0hTnG9M8cghpcwHIrP+jdhzUe7DGk8CWP+HhEfXeV+rXTWQlJbpqscsVy0Ld58FJ8AcFCcTg4I0s=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638527561;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=IzlS3kgJSrMonzIiyfZ3uL8xyz5tf3DhYMDDDegUafc=;
	b=n2LnPWEGyshLVRS+n8Vamedg21C/bviiQ8v6wdgoEv/A9DyFpIeNNDJUy6X0RaYM
	naSpEKrLDlpl1MhRg7zMZEDdwWHKDSeqDqoQN/QrtDmPn7YR01LFIatjiUAXcPglPJ5
	JHdxt/d/Fo9IW4JWel5vgvS7LSedvN/8lxrhoNJc=
Subject: Re: [PATCH 3/4] xen/xsm: Use __init_data_cf_clobber for xsm_ops
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, Jan Beulich <JBeulich@suse.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-4-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <17592382-02e2-7ba8-1d25-57d6451c3f5a@apertussolutions.com>
Date: Fri, 3 Dec 2021 05:32:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211126212258.7550-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 11/26/21 4:22 PM, Andrew Cooper wrote:
> All calls through xsm_ops are fully altcall'd.  Harden all fnptr targets.
> 
> This yields:
> 
>    (XEN) altcall: Optimised away 197 endbr64 instructions
> 
> of 1655 on an everything-enabled build of Xen, which is ~12%.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:41:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:41:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237303.411565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt60A-0003Yl-0d; Fri, 03 Dec 2021 10:41:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237303.411565; Fri, 03 Dec 2021 10:41:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt609-0003Ye-TV; Fri, 03 Dec 2021 10:41:13 +0000
Received: by outflank-mailman (input) for mailman id 237303;
 Fri, 03 Dec 2021 10:41:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt608-0003YY-5G
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:41:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 86b5cd04-5425-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:41:09 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-iSP_buYKMzKDAoide2Qifw-1; Fri, 03 Dec 2021 11:41:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3534.eurprd04.prod.outlook.com (2603:10a6:803:8::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:41:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:41:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P189CA0028.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Fri, 3 Dec 2021 10:41:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86b5cd04-5425-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638528069;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=BeKQsoEw/QHB4fxVezv70Xopat3rYrWVb++YQOpzQGg=;
	b=KGYrbQnR1r39Q2pXSs6DZFlBLzB72EUieIAoilkmL0heGMNwJgnLyPnKtglKIBAIwP78I1
	BS73rG5Q9VTMd7BscO5avoCgc6VlTVtoUiy1V1gKza8RQvlx6L9VND2PGaRQMH147u0QhH
	4biV+kuQwfNSOLE+dfG6XEX0y2eANgo=
X-MC-Unique: iSP_buYKMzKDAoide2Qifw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AtvHw8prQqbmGQ5I43T72VqSWQw5WVQTIEKSa1OCzU8U9kt8WirnlKtDvIJROJCnTmjTHf3wYgs/35K6IK3YmSDwkQ3APYWRu/COtV1k2klDVTVAjXk3IKUORbeT99qKDhsDVuY9Gm3alo6fe6hsASz7vjK227qoXnsQPDQEvxWvT2K9r/ktZJVBw2mghutSJSf64MqxdQh+X5wWkI/C2KGv6FlP+LMjmHjGQx99NTLlpR6gaFssLmdON90KFWP4ypXXvXXwgtt0ihtl+jNu1oafe3GfSVW4f+m/5BkA5JD5FFT3NeggX4kZsJW7n1Mkpt59d7diMfks6uIFQfniVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BeKQsoEw/QHB4fxVezv70Xopat3rYrWVb++YQOpzQGg=;
 b=XBlbLvV1D77c1aeh652yJWhbxfIL7W/lak4GHHglExo+JlBmhr5wtqkSBxacUsWDt2M0K6debtI2kGtw6bUXxaeDO4H01tA8bCTyLo2DGmvaspg7Xos59zqirOnc/3KvTx6DmUTat0n+2jwCyvlosiBV1JWrBeXR08AQXPHR/cgHIsO6U6UsMsC39OOYbZBdByEshNVAeZCOLpGqv/hyhS/UMQFRUBNTh5WhyecwvZnQQ2tYp3Uj8dZ3GyYGiUS/HgqqWK2XcxUAEeFvNRubtcinr1wATi39UVBMuGsyuh0VzmBBAm5gXub+9HFvSaWXLi67/FCaGlx7rUcj/IWGog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7fadbc39-4760-1be8-fdda-455a1a321eff@suse.com>
Date: Fri, 3 Dec 2021 11:41:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] VT-d: avoid allocating domid_{bit,}map[] when possible
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0028.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4991bc00-4184-4a9a-1783-08d9b6496914
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3534:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3534D57767ECDACFD7DA86D9B36A9@VI1PR0402MB3534.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	21Iz680MIje4sMfx7f/holr3TEeWfm3Z9W4s40qmDIdz7LPFLjFxnPpt9ONIKZRr2Fnpo/ZXkpZyijK+tp8Q19SM0GFmxN20oucTswzpadwWsBUnN2Q1+wVpVuHjvxcWEn3wJQ1xzpOPzaZElF3XMaJw+95s+LQSNt4SDJaH+Ufc8DYsEbV4lW/x1pU4kHpAeR2BsOPy6ROxOySO2A4dGGXQt0s51ZZu3lnAspPd0AJ+iMuxN7wHcyUsdhvdiBqzPQZcMcONrMHE9H/OVdLgvVkbZ2nncHRoS/rmo9hAa9H12Y4yP4n9jj4WmnyIGk+keCypg48Y/4iEu2GN6+2+Gsc5J5hAZ33SDOzk1qUG3RG1WjvsFWIO+K4Ml8wPnWxe5xYg/Qx5DjgBhkmBf1pVnvec7VfpB6q/i8cMoBbSa8eVVeOC10y0CJfVmMRvnMzXF7HPXzawSwwuREN4/gFjAJonnntv92ZLHziJbJ1o1KZqJd0XDg1fkH2WPZTCIun/dfjCgTcTX1GyUmllpQ306MaBIuSY9O+ZhB4ItUQOxDcdnju6ANAC21JMcdM9jAGt7FfabdFd/MmqG5YgDodP5f++QmSr8F1O9+5v4ma+zGO7EutelGvCQu1HMnPhxzk78GA3U1L8LMnaGGCZKvDyp3+25G6+Wr1GTnkMy8kHjk2pC1AX4T1XsGtc+owBfal8vzzkNmX7wmsIqsIRhIAfwFvemtoXvLYTrLq1C4iOmFer0/7cRdxCS3lWAKoFCRGl
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(31696002)(2616005)(8676002)(508600001)(86362001)(6486002)(8936002)(36756003)(186003)(956004)(66476007)(316002)(38100700002)(66556008)(16576012)(26005)(66946007)(4326008)(31686004)(6916009)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFdUaDJwUjlUR2JKS2puV0U0YnJDUnpndzU0TVRuQTBPVkY2Z0JkMlR4S3pX?=
 =?utf-8?B?WmVUL0NXcmFzdHJoMGZidTRNUkRvWm4wUmw3N3crOWR4UmduNDluQ2oyWDEv?=
 =?utf-8?B?dHBjMnRqSm4xZzFlZGhjeFM5YjBOV2d4SnBHNDBKTHhyRjFRbXpVSVNqeHVE?=
 =?utf-8?B?SjFRSDFYMm5aK1BLMFREbk5SbkNxbmRrb2pYZ1ZTVnBVMlFBSHdVMHNSRW5G?=
 =?utf-8?B?aE1NSGdILy9nRjBxMFJGQ0Q2UWJsOUJsT0dsUC9SRW1ZbmwrZTBmYkVDOHVy?=
 =?utf-8?B?dDcvQjJVRkFlSWJFeW93K3F4a1Z1SlFZVU5yK2RNUUpYNUhmYU9jdlBoRFlh?=
 =?utf-8?B?d0o5QXhMTW9meEZwK0F1OUk2NVkyT2x4aXpQYU93Z0VoS0xqWFZ6SUdUVWdu?=
 =?utf-8?B?OUxDb2lVK29LL0hGREZad3lmQmFycHAveC9pejlhZGp4NEJoUGFsUE9TOXpk?=
 =?utf-8?B?ZE0xbnNJQXFqVSs3aU0wdTNXbzJLS3hzVUFNbmU0ZERSWERZM2ZGajdTQnVl?=
 =?utf-8?B?NERxZmNoT2xJUEEycTBNWnJockdEbEE1eTdra2Zmc051WTlyL0dHdWpldFc4?=
 =?utf-8?B?VWdjT3c0TnRuNVhCUzI1dXVLb1A3TkhpMGlMTTVFcUQySzR2V3hDdFRVTUND?=
 =?utf-8?B?R1l1amMwcWI1LzgvaWtTTmxNdFg2VHVQNjl6L3BhZVQwRm8xTWZmelJvaWRT?=
 =?utf-8?B?L2tvWnhpMTVldlV3Tnh4dFQwNXUyQ3lYU2Q0cXNiTUtCd1k3RW1zV1hMOFdt?=
 =?utf-8?B?RWdxLzJjVVRsQzZhZFN2a2dPL2NwRENvcmpySUhQUTRtYXdLSTFMMktYRzh6?=
 =?utf-8?B?WXN6b2pwMEVwWFd4NzZDb2E0WFpFelJiWEhVZ3dNWE5Fc2xCdUNvMTlhelJq?=
 =?utf-8?B?ZUN6SXJqU05BQndvSFRRQkhveG1seEN6MW1ZWmdySTVvakV0Y3lKQ0hQN1Y5?=
 =?utf-8?B?WVBWVi9KaVEwMGtZKzV1eEVHR2VFQSswSTA4aTZrSkpvOVN4Nk9NTzhxOHhP?=
 =?utf-8?B?ak9ZYXJSVnhmTWJpdG9nN3ZVQksvbTBMQTlzMiszSmltbERLUkRvSFNLK09w?=
 =?utf-8?B?VjZYSzM1RXF5L1BhbW1HNTc4YkcrT1ZtS3pNbVJKSXZzdmtZdEZaVHFKbDNW?=
 =?utf-8?B?bHdXd3R0aDNJOVVkOUYvbUpndFdkU0FBa2FWL1NYUEFUNW53V3V6bkVnU0xa?=
 =?utf-8?B?bEl4YlY5cHVkRkpSSFlaM2w1NEVnVmRjK2pvN2NualpnclphVUFURVpURGdM?=
 =?utf-8?B?eTd6WU1adXh2QXFKdVlrak5wa3hyWnFqdnlkUlc5RmVWei9Kc0M2VUhrV0oz?=
 =?utf-8?B?OFRlV0JsamZSU3RmN0lFZURNV05Ld2dTbzk0WDQ4dVYwSWtpaE1BckRlZUtq?=
 =?utf-8?B?d054MU9xUXFnMjVvTko2bitVdFVEYTFXZUd6eWJ4ZU13VVRyZ2RZY1JzZTFz?=
 =?utf-8?B?bHE5SDRBd3F6aWE2elJpeW1lRDExUmVXSDhnTFRTRWF1SjZWcGdBTFN4KzJ5?=
 =?utf-8?B?Z2JrcUJObXNabEswOUZIOXJoNVhkWVhOY2w4Ukw1a1piQmp0UW1aamlrUEwr?=
 =?utf-8?B?ZkVsMVpBM1lubTBQV2swM0FieDhlZzFnYVkyclhUQThGV215Yzd6M3JrUEw3?=
 =?utf-8?B?SEF4QzhGVk1jYzVxWmMxeXhkeElnajY2WldaMzd0UkhWOG1acWxLNUZyMGVp?=
 =?utf-8?B?dnFCS0JmQ2Y1cC9UVDE0QldJU1FmVkp2bzFmVnJSejFHQXFvU2VpRnEzK3p6?=
 =?utf-8?B?d0ZUWFpkREw4aEV3ZzZvRzhGOWhkZ1NZSUZUR3JReVk1NE1ab1cxVUhBMHF3?=
 =?utf-8?B?dGNjZkp2Nm9MMUV6VEVIbWhmYzNtdDNGYzFBeENZUzRDeHMxQ09SUXdGeThJ?=
 =?utf-8?B?Zk5TdFZjdVpZK2xGSmF1OHdnUlpLQ3A1azRSVDc5SkJIMUMvbzlqb0Vmc01u?=
 =?utf-8?B?UU9DMGRhbWkraWdxOHFtWDc5M1J4c0pkSmhmYmM5Z0kxd2JRY2g0YmJKRXA0?=
 =?utf-8?B?RmJyOTRVdnVNNzhEY3lIUlVwM3FFVG56aDlPQlpKbGQxbjVuVExjcWFBWlFG?=
 =?utf-8?B?N00yejhkd2FsdzExWXBWdlZyOG5Fb3ZZQmppV2F6QTZ1Zys4UXc2aGxpZlNT?=
 =?utf-8?B?SERJbWZoZGdYc205Ry9IUDMybzVMK3JJUVI3L2xCQjl0L0F5eHFWWEhvQUJv?=
 =?utf-8?Q?4aOXiB1BFXHCCF4JEkUaPwc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4991bc00-4184-4a9a-1783-08d9b6496914
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:41:06.3117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iXOKsLT23SxLqXZgilTdrKFgif7/Xx1z5oQJx3ndxGblAsJH/6W6ZIdpYKF0mFwQMEuPM12LjJWgihtJxiv0/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3534

When an IOMMU implements the full 16 bits worth of DID in context
entries, there's no point going through a memory base translation table.
For IOMMUs not using Caching Mode we can simply use the domain IDs
verbatim, while for Caching Mode we need to avoid DID 0.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
For the case where the memory tables are needed, xvzalloc_array() would
of course be an option to use here as well, despite this being boot time
allocations. Yet the introduction of xvmalloc() et al continues to be
stuck ...
---
v2: Use different BUILD_BUG_ON().

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -62,11 +62,32 @@ static struct tasklet vtd_fault_tasklet;
 static int setup_hwdom_device(u8 devfn, struct pci_dev *);
 static void setup_hwdom_rmrr(struct domain *d);
 
+static bool domid_mapping(const struct vtd_iommu *iommu)
+{
+    return (const void *)iommu->domid_bitmap != (const void *)iommu->domid_map;
+}
+
+static domid_t convert_domid(const struct vtd_iommu *iommu, domid_t domid)
+{
+    /*
+     * While we need to avoid DID 0 for caching-mode IOMMUs, maintain
+     * the property of the transformation being the same in either
+     * direction. By clipping to 16 bits we ensure that the resulting
+     * DID will fit in the respective context entry field.
+     */
+    BUILD_BUG_ON(DOMID_MASK >= 0xffff);
+
+    return !cap_caching_mode(iommu->cap) ? domid : ~domid;
+}
+
 static int domain_iommu_domid(const struct domain *d,
                               const struct vtd_iommu *iommu)
 {
     unsigned int nr_dom, i;
 
+    if ( !domid_mapping(iommu) )
+        return convert_domid(iommu, d->domain_id);
+
     nr_dom = cap_ndoms(iommu->cap);
     i = find_first_bit(iommu->domid_bitmap, nr_dom);
     while ( i < nr_dom )
@@ -91,26 +112,32 @@ static int context_set_domain_id(struct
                                  const struct domain *d,
                                  struct vtd_iommu *iommu)
 {
-    unsigned int nr_dom, i;
+    unsigned int i;
 
     ASSERT(spin_is_locked(&iommu->lock));
 
-    nr_dom = cap_ndoms(iommu->cap);
-    i = find_first_bit(iommu->domid_bitmap, nr_dom);
-    while ( i < nr_dom && iommu->domid_map[i] != d->domain_id )
-        i = find_next_bit(iommu->domid_bitmap, nr_dom, i + 1);
-
-    if ( i >= nr_dom )
+    if ( domid_mapping(iommu) )
     {
-        i = find_first_zero_bit(iommu->domid_bitmap, nr_dom);
+        unsigned int nr_dom = cap_ndoms(iommu->cap);
+
+        i = find_first_bit(iommu->domid_bitmap, nr_dom);
+        while ( i < nr_dom && iommu->domid_map[i] != d->domain_id )
+            i = find_next_bit(iommu->domid_bitmap, nr_dom, i + 1);
+
         if ( i >= nr_dom )
         {
-            dprintk(XENLOG_ERR VTDPREFIX, "IOMMU: no free domain ids\n");
-            return -EBUSY;
+            i = find_first_zero_bit(iommu->domid_bitmap, nr_dom);
+            if ( i >= nr_dom )
+            {
+                dprintk(XENLOG_ERR VTDPREFIX, "IOMMU: no free domain id\n");
+                return -EBUSY;
+            }
+            iommu->domid_map[i] = d->domain_id;
+            set_bit(i, iommu->domid_bitmap);
         }
-        iommu->domid_map[i] = d->domain_id;
-        set_bit(i, iommu->domid_bitmap);
     }
+    else
+        i = convert_domid(iommu, d->domain_id);
 
     context->hi |= (i & ((1 << DID_FIELD_WIDTH) - 1)) << DID_HIGH_OFFSET;
     return 0;
@@ -140,7 +167,12 @@ static int context_get_domain_id(const s
 
 static void cleanup_domid_map(struct domain *domain, struct vtd_iommu *iommu)
 {
-    int iommu_domid = domain_iommu_domid(domain, iommu);
+    int iommu_domid;
+
+    if ( !domid_mapping(iommu) )
+        return;
+
+    iommu_domid = domain_iommu_domid(domain, iommu);
 
     if ( iommu_domid >= 0 )
     {
@@ -196,7 +228,13 @@ static void check_cleanup_domid_map(stru
 
 domid_t did_to_domain_id(const struct vtd_iommu *iommu, unsigned int did)
 {
-    if ( did >= cap_ndoms(iommu->cap) || !test_bit(did, iommu->domid_bitmap) )
+    if ( did >= min(cap_ndoms(iommu->cap), DOMID_MASK + 1) )
+        return DOMID_INVALID;
+
+    if ( !domid_mapping(iommu) )
+        return convert_domid(iommu, did);
+
+    if ( !test_bit(did, iommu->domid_bitmap) )
         return DOMID_INVALID;
 
     return iommu->domid_map[did];
@@ -1297,24 +1335,32 @@ int __init iommu_alloc(struct acpi_drhd_
     if ( !ecap_coherent(iommu->ecap) )
         vtd_ops.sync_cache = sync_cache;
 
-    /* allocate domain id bitmap */
     nr_dom = cap_ndoms(iommu->cap);
-    iommu->domid_bitmap = xzalloc_array(unsigned long, BITS_TO_LONGS(nr_dom));
-    if ( !iommu->domid_bitmap )
-        return -ENOMEM;
 
-    iommu->domid_map = xzalloc_array(domid_t, nr_dom);
-    if ( !iommu->domid_map )
-        return -ENOMEM;
+    if ( nr_dom <= DOMID_MASK + cap_caching_mode(iommu->cap) )
+    {
+        /* Allocate domain id (bit) maps. */
+        iommu->domid_bitmap = xzalloc_array(unsigned long,
+                                            BITS_TO_LONGS(nr_dom));
+        iommu->domid_map = xzalloc_array(domid_t, nr_dom);
+        if ( !iommu->domid_bitmap || !iommu->domid_map )
+            return -ENOMEM;
 
-    /*
-     * If Caching mode is set, then invalid translations are tagged with
-     * domain id 0. Hence reserve bit/slot 0.
-     */
-    if ( cap_caching_mode(iommu->cap) )
+        /*
+         * If Caching mode is set, then invalid translations are tagged
+         * with domain id 0. Hence reserve bit/slot 0.
+         */
+        if ( cap_caching_mode(iommu->cap) )
+        {
+            iommu->domid_map[0] = DOMID_INVALID;
+            __set_bit(0, iommu->domid_bitmap);
+        }
+    }
+    else
     {
-        iommu->domid_map[0] = DOMID_INVALID;
-        __set_bit(0, iommu->domid_bitmap);
+        /* Don't leave dangling NULL pointers. */
+        iommu->domid_bitmap = ZERO_BLOCK_PTR;
+        iommu->domid_map = ZERO_BLOCK_PTR;
     }
 
     return 0;
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -82,7 +82,7 @@
 #define cap_plmr(c)        (((c) >> 5) & 1)
 #define cap_rwbf(c)        (((c) >> 4) & 1)
 #define cap_afl(c)        (((c) >> 3) & 1)
-#define cap_ndoms(c)        (1 << (4 + 2 * ((c) & 0x7)))
+#define cap_ndoms(c)        (1U << (4 + 2 * ((c) & 0x7)))
 
 /*
  * Extended Capability Register



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:44:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:44:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237315.411591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt63P-0004OD-Ob; Fri, 03 Dec 2021 10:44:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237315.411591; Fri, 03 Dec 2021 10:44:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt63P-0004O6-Lm; Fri, 03 Dec 2021 10:44:35 +0000
Received: by outflank-mailman (input) for mailman id 237315;
 Fri, 03 Dec 2021 10:44:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5e4h=QU=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mt63O-0004Nw-8E
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:44:34 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff3f820e-5425-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:44:33 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1638528267238734.1398885193619;
 Fri, 3 Dec 2021 02:44:27 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff3f820e-5425-11ec-976b-d102b41d0961
ARC-Seal: i=1; a=rsa-sha256; t=1638528269; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=KT2Gru+LrRepHwPqRm6hHPPFbRYBTCLCDmY8zphTwwoIJjBMZwtAaPCUIHyy9HVAMkmTTpcQmYZ68qA44qi2a9ZrGDv1HTtatkEGzkH+hRsxpPUXmuV1X6MxsxKpQyYmTwiuPhB+K9vBZHDmobj3WjelHWMzu/tBPPPc8PwBj7w=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1638528269; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=kSDw7C59Qoo3SKlNbWkKjlxqOSlzCZg9uZsCqFY3pRw=; 
	b=lAN6FnOn2FJ9S2Y7A2/645EgFjvdRkeK7Nm+E8DD4IC574ROJe9GysFR09qWd2FGqlCX6zalRCrRwvdVtO4ohyGTA/sJL6u1HIjmbQlKaimy3fr7LKVmvgOwhoFABCgL4/jTsCBq+g9HQCvo35rmYoud4DgsdgIsojzkBGIxvIE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638528269;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=kSDw7C59Qoo3SKlNbWkKjlxqOSlzCZg9uZsCqFY3pRw=;
	b=S+WGih6N1x+R6upaRUVaBi8MnDGDus8k6/j5MJVaV49v219bOYbpMLT6Zu1/uPOR
	qtfI+n2yDzPiMx/3z+uXX97Lgyl17pobjtbF41W47X3etWNdq+i5ETsRCyXFP/9uJRS
	gyGs2FKpk2rL0P2uHaeqo8UsGR0XPzkcDhDRcuvE=
Subject: Re: [PATCH 14/65] xsm/flask: Annotate fnptr targets in the security
 server
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-15-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <55d493fb-7882-1ebb-6d40-305eb9d0d6cf@apertussolutions.com>
Date: Fri, 3 Dec 2021 05:44:03 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211126123446.32324-15-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 11/26/21 7:33 AM, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:46:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:46:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237324.411611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt65S-00055X-7M; Fri, 03 Dec 2021 10:46:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237324.411611; Fri, 03 Dec 2021 10:46:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt65S-00055Q-3r; Fri, 03 Dec 2021 10:46:42 +0000
Received: by outflank-mailman (input) for mailman id 237324;
 Fri, 03 Dec 2021 10:46:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5e4h=QU=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mt65R-00055K-Cg
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:46:41 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4b1ff5e2-5426-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:46:40 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1638528395358886.0942523011702;
 Fri, 3 Dec 2021 02:46:35 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4b1ff5e2-5426-11ec-976b-d102b41d0961
ARC-Seal: i=1; a=rsa-sha256; t=1638528396; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=CfjSyFCXC4W0mmRI1bIQ5yaqXlbYPTUrVzAXzoo2iZjI5xJ58RhsQGQAvf6OtUOWYRFMZRqMEplkkdR4+tPnAgpGKM63F8nNTjaKvIQSr8dduBK7LmesI48j7YSCYEK04KIStTeVACVgfVT2MIOywaV0NIUarbkYMZe35TjVRcg=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1638528396; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=kSDw7C59Qoo3SKlNbWkKjlxqOSlzCZg9uZsCqFY3pRw=; 
	b=GRW+yvst1fHRszOL6/2luxqD7e2PP9UIpdMfr4bA7rSTHY5g6Fyd/SUfWXmFsJ/tZZiTO3j255jB578WyqcMgr1Emow4FJ6gy6+DcHpzqw+VE/g2vaXJBGZ59D7H8TLbNmjLtJUnPm7PHDQzg3DuOIw5XAYzdMT6x8X/x1UPAME=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638528396;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=kSDw7C59Qoo3SKlNbWkKjlxqOSlzCZg9uZsCqFY3pRw=;
	b=fZV9Vb5Sf1DxW2PMqmY/q7tZ49DgxH+llewErY4Kki7XoTe+zS0+SQYAdMKdAFFw
	Bhm4SKnjVdFEF2cLIfcBglZltlsCQbO21N48QbedmKMSNViL/aboV3dxvGsetMQ+EAD
	OvANGn0vuJzGlyoGzvlDcMjDYS8pNBjKh6goaE0Y=
Subject: Re: [PATCH 15/65] xsm: Annotate fnptr targets
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-16-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <d4d43654-9df2-9a8e-33de-e7bc2cd3e38a@apertussolutions.com>
Date: Fri, 3 Dec 2021 05:46:11 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211126123446.32324-16-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 11/26/21 7:33 AM, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:48:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:48:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237329.411621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt671-0005uL-Ha; Fri, 03 Dec 2021 10:48:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237329.411621; Fri, 03 Dec 2021 10:48:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt671-0005uE-Ej; Fri, 03 Dec 2021 10:48:19 +0000
Received: by outflank-mailman (input) for mailman id 237329;
 Fri, 03 Dec 2021 10:48:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5e4h=QU=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mt670-0005u8-0d
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:48:18 +0000
Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com
 [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 848bf863-5426-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:48:16 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 163852849217445.058757401994285;
 Fri, 3 Dec 2021 02:48:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 848bf863-5426-11ec-b1df-f38ee3fbfdf7
ARC-Seal: i=1; a=rsa-sha256; t=1638528492; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=TaBRyp4nFoqA/S9tFHNyss1oBo5irgI8QCYvAMI0KM7eebRnAYWtJUt2k5L/uj03VslQgFHgymqQHUUD9Dr1AFhUgmGzd32cn4OYfOSNUgF2xMvPPvaCWfVrPWt7LoSpx2MFdGNfIfX0QM2ygT/X0LwmPZZxmSjZ5nOBql1olaE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1638528492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=1dRofJOzVtY4OZ1Nw1VTYn7dI1mHMPytqIhGHOjfe4k=; 
	b=lPscpkjsVWAN8SxZNKOH/QJTvBv5RUqwmqUyLLwDYOH3yF1wUV2ks7KCuTO4cTRWsJjXaiRXirPIKzELC2o3FFoSyp3yyfCNRMb7QhJBNfcRjZ9cWLKlL9wRai1bDudEv+TXm+uIj8l1xfLvVRrh1MDINXKh+wVU4WR5CnD0NSw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1638528492;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=1dRofJOzVtY4OZ1Nw1VTYn7dI1mHMPytqIhGHOjfe4k=;
	b=UqoOenT7jSMIfJOTU63EQZUo58BsRsVs/wO0Cw+8Wbzpqr4SmUOjcaStEo5X7Jps
	oX8ybL6Yn4OdgjfHXxgSZ/Azkz7LkTxVfBuhSovDt0o4Ketn9+UJVmJq4DhgALz7j/B
	XZvjYRpiHnkoKVFJ0bZlz3GoUWTAwPDwZxBW3JHs=
Subject: Re: [PATCH 0/2] xsm: Further fixes
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
References: <20211201111555.16408-1-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <06b3cac9-7cd5-7402-f6ad-7d82a43eb8df@apertussolutions.com>
Date: Fri, 3 Dec 2021 05:47:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 12/1/21 6:15 AM, Andrew Cooper wrote:
> Andrew Cooper (2):
>    xsm: Switch xsm_ops to __alt_call_maybe_initdata
>    xsm: Drop extern of non-existent variable
> 
>   xen/include/xsm/xsm.h | 2 --
>   xen/xsm/xsm_core.c    | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:55:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:55:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237336.411633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6DW-0007JD-7K; Fri, 03 Dec 2021 10:55:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237336.411633; Fri, 03 Dec 2021 10:55:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6DW-0007J6-4E; Fri, 03 Dec 2021 10:55:02 +0000
Received: by outflank-mailman (input) for mailman id 237336;
 Fri, 03 Dec 2021 10:55:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6DU-0007J0-A3
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:55:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 75253080-5427-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:54:59 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-yhIfI2YdOHu5naMKw_zaQg-1; Fri, 03 Dec 2021 11:54:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3293.eurprd04.prod.outlook.com (2603:10a6:802:11::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 10:54:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:54:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:20b:312::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Fri, 3 Dec 2021 10:54:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 75253080-5427-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638528898;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ER/BOQk6TDm0gj9BC3vEDaNIiwfCia7A1Mz5radM/p8=;
	b=gpg/seBcLTmIvVeWM69tiXtuVAbUNM3O3FQwNdjTtip4A5GEObum7KWt0zzZmMahScxMaP
	FHWQVZvWAIk65yWvSTheQbgC/+NprhFnwk73X1rVMvPAi8FDK8/IOPzHw1t9gU5DeFKaIR
	CnaUQqx9YvI0bJ3R7dmNUu3Oset3rF8=
X-MC-Unique: yhIfI2YdOHu5naMKw_zaQg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nqwy31mDTetDOwkzlIPnvKXxSZQ2EUZj2AHSNLuKQIKmUWrtOGjA/c8mssKgizF+B6bH5TUaXX9voHIKaHGBrgJyDUftdgVUz3uwxI1aI0wC1jIfyIJ4WM0PbctkZZzuGmMB4/mVvp1emPQ2fAnFJslXNQGCaiSZcNXD4LoTet/qy0NO1aDvRr1zs3I20XxZz1MJnu4FMDJSkrzJJZjzQpHktjj5MrmMKhjBjluzKvFaw4bklPxP946BD1EwfS1+G+QIrKsDntX842BDeVhWtAn4+4CSI/nqWCfjJpXhjA3ympXfZkTtMf5zVujkaBcclLDM/U0HW9MxEAXVKgwNFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ER/BOQk6TDm0gj9BC3vEDaNIiwfCia7A1Mz5radM/p8=;
 b=SrcIsPO6tDVan5eHf2g7mgA/IHgrL0ixS4RzH29kE/lQC+OFYc1fxMyJapF+erbNaNpyYHB1yu5tc4aoP7b5uWsJyL3DehETkagJDhMudLVuN4FPl05IzkQ3+tqivbXGjuFm9x12ndaUbcU/sS8ac1m1wc43yefVq6fFVZvezGLhNoPjCY0Sldt05+M6a6yIO2fANdqk7lUGDz+h6e0y1qsnHQjrjojZQ5PxHoao7RxTZfvie9SnWj6YOF9aLbK1yLPvKriybt4h/bGRP7mNKyGCRL6xC6AeA3DQPK5NH7veKsbzgb5L33ihSOqKgcwEjczjFokDURypRMx4M16kog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
Date: Fri, 3 Dec 2021 11:54:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3]: EFI: some tidying
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0052.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e8c92bb-a2d8-4e65-0f79-08d9b64b57ff
X-MS-TrafficTypeDiagnostic: VI1PR04MB3293:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB32931D9F3CA95F2E8F2C542BB36A9@VI1PR04MB3293.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	k/KjFXwDqeCcqvQnkw1rX8xtLDrYfDynB+VdB9sWA4xp526xUEvG7pTm0Aaj1tufsaXUGs8MVqyvXK4FpBVJgzBd2f5uGizZvTR/M4b5IAtg9+BedAUglwhdrIfjmZ2BQG3mmhZO0Rx9zd4g7FBx745ZirKKa0IyeIvRfwElFr6JFeiO44gppMY/Jj2r18riU2bX/NkvCUTj7VX6qbQM42UPEcnNF/mNVZSnf5qZN37N1attLn7xl5P5iq1VK02BY9IKLdmRAR/1HEEo5TD2mKf2WIrBAa4A63OhROCdkkZaxIOTV9WUSIwWY8knsffCmCf/vAek77VgClGrPsCouoUCCkIJZjGiE/9VpJBAPWYz2KwRtu2aYZcCkfyRiGtTIbL/1dsI/eM7sPn6X4RtyWs9mtkJLRiBGvaOkl6orKr3x+UjCv50Zg9qVG21BjQbnDFKbIZn7Z+7EFuGPr2IVIDMcdp8w9ZNwEcBFrv0+GwdVfU/JcJmM+CqB+FESNpVrStAg+gLUomm03fJPOSZXVPX6PwV41PZKYGWBSw/LqzjiEvlYNb3T4MPh3QNVAR2ZIdsEPsOt21YTyzIIrN/PX1Hx5zSycYQJmlna1nlegA35T0quokJUAPn6of4BEwY59cy8s0///Nc5diVxRAOAyjmRxyZkNOoa7uCkvSbRmHG2io6ZU+bv4fL/eacI8aITBS7ObF122R2X/ACfjPHxvck5OJzhkH2+eo3KDQ0omv0cVDYL8JcSAuiEaj/f3sa
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(186003)(16576012)(54906003)(558084003)(508600001)(8936002)(956004)(6486002)(8676002)(2616005)(6666004)(38100700002)(6916009)(4326008)(316002)(2906002)(66556008)(66476007)(86362001)(36756003)(26005)(31696002)(5660300002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L3lLNDhCS2dqN256VVRrN0NrUDhyaDVTVXpqanFUaWNoeVRxaGh3MlJmdkdV?=
 =?utf-8?B?VHNhRXZ6ZS9SZ0Z1b1lRZ3JpWWI3OFdZQ2ZkUlovbldyUUNhYnJuL2U4Z09w?=
 =?utf-8?B?bDY0Qk5mYzN6ZEtZZ3I4YmJUMC9vdHNCQ2dib3ZZbGxWQzVPb251VEI0YUJ5?=
 =?utf-8?B?TGphNkVtZXBLQnlkSS8xM1F6WkVEbUswdjc2OWs1eGlmcEg1WTdxaG9FT1pD?=
 =?utf-8?B?RDZtR09ibnNXZXloZTRSeHpvcVFVWG9qMWFYVEJJSjBzbUNtbUVlSFZvbnhw?=
 =?utf-8?B?MmFkNXFjU2FrdHpUQ1lXZGJmNFhSMTUxY2Q2MjVTUi9GZ3dvMWZPSTdFUzl6?=
 =?utf-8?B?TDAvS2VmUXR1QlhDTUpGMjd3MExLUkxjQ2hZdW1ZWURuYVhrbVozdjU5YjNW?=
 =?utf-8?B?R2gyTTRZZHIvZHVZb3UvSUJUNjBvM2lrVWI4RlNaZ1RXbjVvMGZnZ3hFU2kv?=
 =?utf-8?B?NUFodHZSNmcvb21GNFJCY3I0VUtzZDNjUE9XMWdGV0ZpVmViMCtlVVVDd1du?=
 =?utf-8?B?a1UxNUhCVVkrdmpScFJDRno0NktRbUsvODV1dXcvTC92SkhZeVFOZnNCODNn?=
 =?utf-8?B?RWFYOHk3MHVaOTl0L0hEN0YwY3NEaFdSaEJTOC93SGlEWmMvUi8rQTVoVXpK?=
 =?utf-8?B?WEx3aVB4bHB3VmhGdGxhTVFmYlQ0T2xXZmszRlVRelpVMUhFLzY0T0RBRnRV?=
 =?utf-8?B?YktpaS8zNzYzTGcyeE5rTXZjL3Y0NjE1WEkxSU1BWFNGOHFjUlQ5RUFpTmNk?=
 =?utf-8?B?ZFJpMkM2U21FblBJSHF1bDQ1WEdWcSt0K242MDJZRTArcGI1K1lvaWpVekJS?=
 =?utf-8?B?WEthSXhzbjBTV25GU0w2OXlpTTJpL1BSalBiVUNLS1piOXNzV2k2cGRudWVV?=
 =?utf-8?B?S1B6V1NjMkNFblJ6SjFFdkFJRTljejFzQ3VCRDRRQ2lZQnA1OGV0VW91UFh1?=
 =?utf-8?B?VlNXbnMxVjZOK1dXbm16SXg2MGszYnFCT280aDNOWmQrVGxjMUt5ZUU4cE92?=
 =?utf-8?B?TldRbDJyejI5TncvMitPYk0wZjFwUnVtS2R4MjFMUHpDZDRXRStlazVmWG9D?=
 =?utf-8?B?ayt3MUtScVI4K0s1Q0dYZTlaNktzOGhyWUhLaTIzK1RuRnQ1V2t2S3Nnd1ox?=
 =?utf-8?B?MWJsMjgvMFVYNFhTRnFQYVZMWDYwUHErc0g5VGcyK0Vnem1HeXpoOXl4UHpw?=
 =?utf-8?B?QWM3TGl1ZUhoUk1zWmpkSVpGZHdyb1p2cTlqT3J0a2VtTWpUL1VjbzdlSGFr?=
 =?utf-8?B?cTVLaHo0QWZGKzJodFBKWFBDY3gyVTVlMy9LRTJhdSttZ1VSM0RlNVNJYTRH?=
 =?utf-8?B?SWZqWnBIVmZvc1RoTTdBenJhNUdmS1RLa3RJQ3QyVHpJUnYyZ0MwaERXWEh2?=
 =?utf-8?B?N0FDbHdKY2Z5b1JIYkJla21kUG9ucW91ZzdPQ0sySzMvMjAvaTg3QjR3M1ox?=
 =?utf-8?B?MWJkREg5MVBENzZ3SU5TU2tXcnJLVDFFOHB1SWo4YTdyK1B6R3EyczEwUHAz?=
 =?utf-8?B?eDBpS29QcXZMT3Vja29halBjalZLbzRSaXNsb2FtRGNZdThGK3haa0VKR3NK?=
 =?utf-8?B?NFQxbElzbW4vWXlibDREQm42OTlBcVo5eEFKU1dMcTJ4M1hCMk94aHVNNzM3?=
 =?utf-8?B?RGRNd0t2NTRRRnNrbXY5UnpKejJmSDVwbGpKS0ZXTFZBdUlrSTRFNlk3Tjlp?=
 =?utf-8?B?ZE1ZZGZYSGNxRG90dXhrUUpFY0dQbGtURFk4dnF2SGNCVlR3SUkveVlaZ1I4?=
 =?utf-8?B?RmF0dnk3eVBUa3RrY3hlWjVibXJMS3NWN1Z5OXVBN2lwenlCRXg2QTVNOE9J?=
 =?utf-8?B?Nzk4YlpwMWcyMzR1Tngzcm1KUGZjdEJLT0xxN0ljRWp4UE1IZ080SHFkUFZv?=
 =?utf-8?B?Z1h0ejZqZE1mOVN6eUd0VDZZa29DblM2T2V5QjcvT2phZVpuRDllU1p6enhm?=
 =?utf-8?B?MHFaSGZYclFTVWkvamw4eFM1NVhaL2ttaUxnSjJiRnNFUHNyVm5zN2tLQTVt?=
 =?utf-8?B?L01tTGV3V2tCbUlxSU5HdFRQdjg5YVowM1FTS1QvUjgwajBjWmg1Q2RNb1pp?=
 =?utf-8?B?N2J1NGgrRXE5RXB1UWxDRkk4SWRmcGlSYmEyWUdCWTFPUWhGYi9RR1Z3aTIx?=
 =?utf-8?B?S3FjZWRSUHdCcVl0K3V3WjN5Q3p6Z0hqOTd5bjRsVFY3R04vN3QyMERrcVRI?=
 =?utf-8?Q?MTM6cEgHvPiPpjgPAZpAO84=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8c92bb-a2d8-4e65-0f79-08d9b64b57ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:54:56.6590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sa6XsjAZznAZHTekkEoJm1dh6hGmTLSveJkdQiO22TY+WsaltHd5aLud6ifD3UF9Lw1axm7I2o/X96qD4YIgfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3293

1: move efi-boot.h inclusion point
2: constify EFI_LOADED_IMAGE * function parameters
3: drop copy-in from QueryVariableInfo()'s OUT-only variable bouncing

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:56:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:56:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237341.411644 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6F5-0007t1-JR; Fri, 03 Dec 2021 10:56:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237341.411644; Fri, 03 Dec 2021 10:56:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6F5-0007su-G8; Fri, 03 Dec 2021 10:56:39 +0000
Received: by outflank-mailman (input) for mailman id 237341;
 Fri, 03 Dec 2021 10:56:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6F4-0007sk-UW
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:56:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0033287-5427-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:56:37 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-w61jVg3JMDK7ZefYJVqMhw-1; Fri, 03 Dec 2021 11:56:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:56:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:56:34 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0132.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::37) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 10:56:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0033287-5427-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638528997;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QD9We1Cx5H7zmR7/ANXcnQ1Rln6q7zD3LKt1U64J4VU=;
	b=awNekeR3AE3BFT+EhaUWUD/0Iy/eaxKqbkla6/7tlbblbe2MEzbrBiBtWujaD3/8uuxGL8
	Lm9fso7KVP5sINjmJml5rROYDWwbLSkDVAdbRR4P5Hvwv9VzNyzWVd8T1dhjAPoqcH91bm
	H6Y5ux4vIQp75ag7GW5GLslRDgxJBPQ=
X-MC-Unique: w61jVg3JMDK7ZefYJVqMhw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cypgf/yfxOH2eOVbElMvsTcMbRRiENLi2VQLrmaLcdUxYgpjxiHM78q3O838shZfCPo1gEkKkHkNAkIuvtYqM1YLooA8B1x9+mLxzFHLZpCSMPs3IbfyDtnXhwq1zOfy9wIhvSepPJhE5i7NvLKBcPxOavBXH+htj2v5j5m1upPJgT0L24M2Nwqi8PKqF9AkU9fvX37Xfu+s4trfAjw4JB4YcJkxHh2aJgpSRIZeDChh1eKIjfdMDaidwBeCLyvVQ7r90DgFfsdiY4Cso19vgANNPFpXuqewylr/cApQB16lgkxs080Agx14pv2v8GQYPdVC5Es1uldkZUuVGbg/Gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QD9We1Cx5H7zmR7/ANXcnQ1Rln6q7zD3LKt1U64J4VU=;
 b=BOJhsg9LDei6THoSrvTUPkyaWYf04eapTH6s0WyRQyMx3AEFGbFbEhVyoEuUzOJXQ9CQCtYBvrHcDZaoZQjoVxu1R9ZKLVMX+FQcoodb7g0IkGz8xyCPEfoiWfzTaN+YtN1Hhq0ykgj0eQsth3fYXPPXwb7X5gq+Spbjzuz0m2R4okZleGvSQHmVR97aHlylJc1L9tizMw7x0MPdvFLG6Om54FwMmhXNMXOIgX5zfgRx8KwBEAuX8V03IBYIKuvt8ATcTQZnLuSqK6ws0y0QZcfIbSPCYU4wk/oxxFzjkde1KBdZrwJgNTx6/C92U6WYlGKxWAoMzlkkjvbGEDdzjw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
Date: Fri, 3 Dec 2021 11:56:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
In-Reply-To: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0132.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0e6c7a3d-642a-4a54-f908-08d9b64b9284
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3391074D9A6BD0E212255318B36A9@VI1PR0402MB3391.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:949;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6ZIsJhoj2chQ+jrQgpTPKQPD5tod0g7pz9mCDVRBT+rf2Pl57+We61xQpfO8ZXOvlhoxTy8fKbVxNiHXLqZ12iZUZlSYKzox5g1eLSZGW0ZQJidtjBlkL/DwS+yzByv39w4DrdrXBdLhtWgYGAyFZbM5Us/j6xrLb9UZkaxLZFCwSZLxLkgrPc47RsmrAHUXv3OR5kKlZhuZyPoLCpyiim2cpFvg1LbzKcoeYbrOXvZvZGFjIWQsFNsiSQ5uWFb/sBL0T2TojIvH8nSXceBN6Y6904oFV99Y3De0d0K4hq941NVffAWUBcK3MDZDai7URwenjrH+dDPwiwzAwV37Grc5tZo3qGWutEl7z7G59FH7Eq4Yv6uDDrPi3OANjIt0vFEpml+OhwvJ1tGP8C/zIZ8jmDTAqzmhkp1ZLWyfPCVyJD+Ygzn+XV5y3pRwY0rs4BUEK+41RQAm0/fqZkHgZ/WUcV5lIJGOipyfUoL0GNjT11u4ki50jVJefBRaEofBr3qEZO5Loek9wruwxxFldRxdXxPSGgaDEQwjbMjbQNfHyWgR5TXJ0GxpBiXeuc8NRwx8wq9sh7W7yA05tkSfR7bYyBbPr8NYgR3S/WoPpZHXwxZDgOHKqpjrNJXucictf9Rp96sYqOJS5BXx0K2PgQOBdJ83xOzref61nWq9UpPX330ZVB/hMYRgshO0nPNfCXR2qo1p8WqpyPOvIMpxbnnNPBvPPaYwKYsDucmw0JKCEZXZjOmQhjdX6ReJ+wFr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(4326008)(186003)(2906002)(54906003)(66476007)(5660300002)(66556008)(31696002)(2616005)(16576012)(6486002)(508600001)(66946007)(36756003)(86362001)(8936002)(316002)(26005)(956004)(8676002)(38100700002)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SzdZdi9GNEQ4YnRDZFdkbDA3ZFVQdExqcWxIZTlQWlpxOTFQd3ZLbVJBbEFG?=
 =?utf-8?B?YW1YcXBOYkNkL1hiKzRsM05IM0VBWHA3MGNlc2ZBTHFSZXR2cFZ6MHhFMytU?=
 =?utf-8?B?YzhhY3FKNVZreGw3WkN2bUkwdVlleWpjeUdvRjBjRDlRNzBlbzlVTVR6d1R6?=
 =?utf-8?B?OE4zMHdXVytVRkk0MjVrb1pSTjBkdTNXays0REtlaVVqNXo3TFFBeldhVEE4?=
 =?utf-8?B?dWZOS0V5cEx6OThsei8vcmtaTi9iMjQzeHVFVGxpczlOdXloNDlycEJQcXhn?=
 =?utf-8?B?UldRd3BZOFdISWRWRWYvdlBPbm9tNldCdlNuVzU4bExidUtPa1g5bDdCbkVM?=
 =?utf-8?B?ZDFwMEV6QmdjUFcvK0pBdGxYTmU5anNlQUtlUEpmWHR3ZTRGZFZodUZhRU5r?=
 =?utf-8?B?RHF3enNscVpOUVkrTDlyNGUwZ1hzVHlTUW9keklOU3o5c0hUd2RiVGxoNitj?=
 =?utf-8?B?WDAzVGVvQ2daSjg0L29Fc2dSRTBFcUd5Z2NQQXZRZjRoMHVXTVZTSVdiKzBt?=
 =?utf-8?B?bHUyNFMvZlpXSmFIRFgvdm1UQ3VKZTBsNElvZmtyUjlMYkZTajR3bCtKS3Fa?=
 =?utf-8?B?UXh3Q1BJS0pUcm41dlMwSzlxZEFpZGVEcWdqWjN3S0pvc1ZkWjNVTWFwVXFF?=
 =?utf-8?B?OW5VWHB5TTk5QWFoZ3lzTEZiUnk1MmM3WDY4RUplSFp1OE5ydXlIZHMzU1F6?=
 =?utf-8?B?QWtzT0ZFNklSQWY4c1p3UG1SVUdtclo2UHcvZFkrQ2YwV0pyUUVObTN5c2Q1?=
 =?utf-8?B?dU5GYXZNdUZMU2cxUHdNQS9jcGlDRUZXdDZRdlcreC9aUzNKNStxUVZSZjFa?=
 =?utf-8?B?elZrRmFvc3JZZVM1VGhZS2FNYk5sY2pTbnNGWURoUmRleTd4QTdvZkNvTk50?=
 =?utf-8?B?eW5oZSt6YlVGUFZnN1lZMjd0TjZOL3ZaMmRzMDlJMUgrOEpLODl0QWFkSG5L?=
 =?utf-8?B?bWJ4ZjIyaUhKZkR2WE9ncDMrM05KZFp1b3NxbUhPMDNsUmxFY0duZ3k0OVNh?=
 =?utf-8?B?SGV6ejFmVFJwZmI0b2t2YVZORW41ZDFKVUhiNDRYYSthbExhVzJBN2g5QU4y?=
 =?utf-8?B?UWpaTC9rZzIyRFAwalcrdnd1ekdETm05TjJuSUtBaWJmRHkzQ252SXVGdlpT?=
 =?utf-8?B?RUpDZ0IyZHVmMzVzNkE5ajZaUnptVG1iV0NFVEhRbFRKVzhwdklGWjBQajkv?=
 =?utf-8?B?WHZmRTRuSTA2U1p4OFBwM1Q2bHhOQllCdXJxVnRUN3RUVlJxNkhoR2cxMUd1?=
 =?utf-8?B?RmJuVUZnU2hlSE9MNlRRYlYrOGRrNEZJRTN5ajVJY1RrT0pVa2JKSTBXWlNE?=
 =?utf-8?B?MS85VkZUR0hETGtoN1lJZ0ZtWTJqc0FxbDNHNWIxZFhEcFVmZm5tVXZJV0V5?=
 =?utf-8?B?M1RscEphWW04aERXYWxnTHZIeWlBN0MxUjBQTjMzTGxQQUpkSTZDakQzRjVx?=
 =?utf-8?B?ZkhxbFFUZjA3cHZWZldDd3ZpQjZXZTFTRDl3MlhnbFl6cFlZK0JxOW1xVkQ2?=
 =?utf-8?B?OGVoWjEyN3FRMkxLZlFQWUtqZlFCSnBZUU1GUzl6SEI0cjNoVHhlYURqbnBo?=
 =?utf-8?B?Q3prdmxpaGc2ZUZBcDZwdWVhYXFwdXBkYStCeTVrZ2pGUVkrbG9RR1k1VDF2?=
 =?utf-8?B?ajFlWkJXYXFTa1lwbXBBVS9yL211K3ZKTklqM1ZCejBvVVJ0RndjOU1ubFIr?=
 =?utf-8?B?cVJGbFRwVzE5R0Nnc3NQcURnMDNqSW9jbEdMVmZKMFBQTEo4STZFRk5LVEpo?=
 =?utf-8?B?bGJ6VWY2MDFzQUhsVzNRUWhGaGZqR3lhWDZBenB1TFBUUGV5TnBOdGM2aGp5?=
 =?utf-8?B?NFFLdWpLanpCeXN2NjByM3ZzTXNwTFFzcUFaNGRTSDU5Z05yVitpejgzbUhm?=
 =?utf-8?B?cm96OXprTUgwVEdoQTZXT29WOVVWODU2Q2x0d2kwRlUyVERsM2hsaVdoUkkx?=
 =?utf-8?B?enhNUGlMRDJQaGMxZnp6REs1QW85OXJtam5FY2ZnVDYybmYxY2VoR1Z2Ulls?=
 =?utf-8?B?NEFyeURhM3RDckwwVm5rVWdTRkJrd2Q4MTRITVRTZ1VxVHBnWTZvVVVJTit3?=
 =?utf-8?B?NGtYbXZxaVBHMUZLeXhTdjZkVnRuK1hTSHEzWnNsRHBJS215d3pLUU1XYTVB?=
 =?utf-8?B?TTV3WnJxdW9uZ1FZb0wzNDZKRlFjckJndDV0ODBMSGMxVnZMSzEwN25rWE5S?=
 =?utf-8?Q?vI00+Li4WpVAhZa0gkH2hbU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e6c7a3d-642a-4a54-f908-08d9b64b9284
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:56:34.8135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5UneFSaI4BqUH1QBy9++ApcIU1pxPAQ7JfZ48vU7fZPBpZSF+6un+UgSQvrypJ2WBPM18FrvGR/MBvAQP72VOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391

When it was introduced, it was imo placed way too high up, making it
necessary to forward-declare way too many static functions. Move it down
together with
- the efi_check_dt_boot() stub, which afaict was deliberately placed
  immediately ahead of the #include,
- blexit(), because of its use of the efi_arch_blexit() hook.
Move up get_value() and set_color() to before the inclusion so their
forward declarations can also be zapped.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -111,25 +111,10 @@ struct file {
     };
 };
 
-static CHAR16 *FormatDec(UINT64 Val, CHAR16 *Buffer);
-static CHAR16 *FormatHex(UINT64 Val, UINTN Width, CHAR16 *Buffer);
-static void  DisplayUint(UINT64 Val, INTN Width);
-static CHAR16 *wstrcpy(CHAR16 *d, const CHAR16 *s);
-static void PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode);
-static char *get_value(const struct file *cfg, const char *section,
-                              const char *item);
-static char *split_string(char *s);
-static CHAR16 *s2w(union string *str);
-static char *w2s(const union string *str);
-static EFI_FILE_HANDLE get_parent_handle(EFI_LOADED_IMAGE *loaded_image,
-                                         CHAR16 **leaf);
 static bool read_file(EFI_FILE_HANDLE dir_handle, CHAR16 *name,
                       struct file *file, const char *options);
 static bool read_section(const EFI_LOADED_IMAGE *image, const CHAR16 *name,
                          struct file *file, const char *options);
-static size_t wstrlen(const CHAR16 * s);
-static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz);
-static bool match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2);
 
 static void efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable);
 static void efi_console_set_mode(void);
@@ -168,19 +153,6 @@ static void __init PrintErr(const CHAR16
     StdErr->OutputString(StdErr, (CHAR16 *)s );
 }
 
-#ifndef CONFIG_HAS_DEVICE_TREE
-static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
-{
-    return 0;
-}
-#endif
-
-/*
- * Include architecture specific implementation here, which references the
- * static globals defined above.
- */
-#include "efi-boot.h"
-
 static CHAR16 *__init FormatDec(UINT64 Val, CHAR16 *Buffer)
 {
     if ( Val >= 10 )
@@ -291,30 +263,6 @@ static bool __init match_guid(const EFI_
            !memcmp(guid1->Data4, guid2->Data4, sizeof(guid1->Data4));
 }
 
-void __init noreturn blexit(const CHAR16 *str)
-{
-    if ( str )
-        PrintStr(str);
-    PrintStr(newline);
-
-    if ( !efi_bs )
-        efi_arch_halt();
-
-    if ( cfg.need_to_free )
-        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
-    if ( kernel.need_to_free )
-        efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size));
-    if ( ramdisk.need_to_free )
-        efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size));
-    if ( xsm.need_to_free )
-        efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size));
-
-    efi_arch_blexit();
-
-    efi_bs->Exit(efi_ih, EFI_SUCCESS, 0, NULL);
-    unreachable(); /* not reached */
-}
-
 /* generic routine for printing error messages */
 static void __init PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode)
 {
@@ -542,6 +490,7 @@ static CHAR16 *__init point_tail(CHAR16
             break;
         }
 }
+
 /*
  * Truncate string at first space, and return pointer
  * to remainder of string, if any/ NULL returned if
@@ -559,6 +508,95 @@ static char * __init split_string(char *
     return NULL;
 }
 
+static char *__init get_value(const struct file *cfg, const char *section,
+                              const char *item)
+{
+    char *ptr = cfg->str, *end = ptr + cfg->size;
+    size_t slen = section ? strlen(section) : 0, ilen = strlen(item);
+    bool match = !slen;
+
+    for ( ; ptr < end; ++ptr )
+    {
+        switch ( *ptr )
+        {
+        case 0:
+            continue;
+        case '[':
+            if ( !slen )
+                break;
+            if ( match )
+                return NULL;
+            match = strncmp(++ptr, section, slen) == 0 && ptr[slen] == ']';
+            break;
+        default:
+            if ( match && strncmp(ptr, item, ilen) == 0 && ptr[ilen] == '=' )
+            {
+                ptr += ilen + 1;
+                /* strip off any leading spaces */
+                while ( *ptr && isspace(*ptr) )
+                    ptr++;
+                return ptr;
+            }
+            break;
+        }
+        ptr += strlen(ptr);
+    }
+    return NULL;
+}
+
+static int __init __maybe_unused set_color(uint32_t mask, int bpp,
+                                           uint8_t *pos, uint8_t *sz)
+{
+   if ( bpp < 0 )
+       return bpp;
+   if ( !mask )
+       return -EINVAL;
+   for ( *pos = 0; !(mask & 1); ++*pos )
+       mask >>= 1;
+   for ( *sz = 0; mask & 1; ++*sz)
+       mask >>= 1;
+   if ( mask )
+       return -EINVAL;
+   return max(*pos + *sz, bpp);
+}
+
+#ifndef CONFIG_HAS_DEVICE_TREE
+static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
+{
+    return 0;
+}
+#endif
+
+/*
+ * Include architecture specific implementation here, which references the
+ * static globals defined above.
+ */
+#include "efi-boot.h"
+
+void __init noreturn blexit(const CHAR16 *str)
+{
+    if ( str )
+        PrintStr(str);
+    PrintStr(newline);
+
+    if ( !efi_bs )
+        efi_arch_halt();
+
+    if ( cfg.need_to_free )
+        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
+    if ( kernel.need_to_free )
+        efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size));
+    if ( ramdisk.need_to_free )
+        efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size));
+    if ( xsm.need_to_free )
+        efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size));
+
+    efi_arch_blexit();
+
+    efi_bs->Exit(efi_ih, EFI_SUCCESS, 0, NULL);
+    unreachable(); /* not reached */
+}
+
 static void __init handle_file_info(const CHAR16 *name,
                                     const struct file *file, const char *options)
 {
@@ -685,42 +723,6 @@ static void __init pre_parse(const struc
                    " last line will be ignored.\r\n");
 }
 
-static char *__init get_value(const struct file *cfg, const char *section,
-                              const char *item)
-{
-    char *ptr = cfg->str, *end = ptr + cfg->size;
-    size_t slen = section ? strlen(section) : 0, ilen = strlen(item);
-    bool match = !slen;
-
-    for ( ; ptr < end; ++ptr )
-    {
-        switch ( *ptr )
-        {
-        case 0:
-            continue;
-        case '[':
-            if ( !slen )
-                break;
-            if ( match )
-                return NULL;
-            match = strncmp(++ptr, section, slen) == 0 && ptr[slen] == ']';
-            break;
-        default:
-            if ( match && strncmp(ptr, item, ilen) == 0 && ptr[ilen] == '=' )
-            {
-                ptr += ilen + 1;
-                /* strip off any leading spaces */
-                while ( *ptr && isspace(*ptr) )
-                    ptr++;
-                return ptr;
-            }
-            break;
-        }
-        ptr += strlen(ptr);
-    }
-    return NULL;
-}
-
 static void __init efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 {
     efi_ih = ImageHandle;
@@ -1114,21 +1116,6 @@ static void __init efi_exit_boot(EFI_HAN
     efi_fw_vendor = (void *)efi_fw_vendor + DIRECTMAP_VIRT_START;
 }
 
-static int __init __maybe_unused set_color(u32 mask, int bpp, u8 *pos, u8 *sz)
-{
-   if ( bpp < 0 )
-       return bpp;
-   if ( !mask )
-       return -EINVAL;
-   for ( *pos = 0; !(mask & 1); ++*pos )
-       mask >>= 1;
-   for ( *sz = 0; mask & 1; ++*sz)
-       mask >>= 1;
-   if ( mask )
-       return -EINVAL;
-   return max(*pos + *sz, bpp);
-}
-
 void EFIAPI __init noreturn
 efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 {



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:57:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237348.411654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6G4-0000Iv-0m; Fri, 03 Dec 2021 10:57:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237348.411654; Fri, 03 Dec 2021 10:57:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6G3-0000Io-U8; Fri, 03 Dec 2021 10:57:39 +0000
Received: by outflank-mailman (input) for mailman id 237348;
 Fri, 03 Dec 2021 10:57:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6G3-0007qi-2R
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:57:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d426d624-5427-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 11:57:38 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-6c8DX1yBOnSyOEKqLJyx5g-1; Fri, 03 Dec 2021 11:57:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:57:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:57:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0036.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::49) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 10:57:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d426d624-5427-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638529058;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fdGuHEod0PjyKKkct1qPtti9jY5e6u+ZzA9caApkWi8=;
	b=Z7G5Q5JsfHV/zMl8MDGFEW+Ecxz6N9zg5h/oZafMyMMCpabZ1HGNhc9FjPu4rlxmDJETeE
	kC7B+OmiKNrvhJr7g9OUSwlEDyjAVBLpwN121/hb6FpECcXh8AAtsFiBs0RIPPBPCZ07JI
	OHa5x2cg52fCqbpktNZ4QIMMU4Fmi74=
X-MC-Unique: 6c8DX1yBOnSyOEKqLJyx5g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Faz+QAnarOJ23z3QiRZ0Ukp2/WXg2JosfCFtbTds/j4RFBoux53KnycfiUoO0KJgZRR3eB7uACJKmqPE7PmZ05THwWIwACmyLOdhFAfoZQnm/Vwsv7HEEVoi28Ugz4uR2nwYL7IOkxRT9y6If8ksPokf/bPvQp1A40vPy26BWOatgIqatVtdpFOFN/E8C9RtgdjCiz6Bs4+YPinRfrCS6l9fJ9rusPrzWsIW3w1PcQT8T6BGlKj/lDRNB4J26q2kEC76WXW7zm9/SIRxPw56v1KLXJDn/p7nj0CCrixZTKBf3KqDUwquSICr4wA3YhPA9Zj+UEbmMYEvTGvBrd/Wxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fdGuHEod0PjyKKkct1qPtti9jY5e6u+ZzA9caApkWi8=;
 b=QT8a0ONwjD4LQY9PLihw+c1qdZNpKF3agrxWhql/n1dCX7zuStk2Vf0cojAsYS1JJL4f4Qw0gFrj+gfJITD5W/tbqxDqR/xPIXiXl32e61oX5T4ABpmis8TC1tulIHb5R42VVQFxSsdObzkh9m9FlyDbngmK7Dl1DdPUglo6v2t9Que9/r8L5u6HkJmqD2mQmhTpX0eSGqvIvp/woGhOasUR+KsJM3zaci5/efybKU84rkrwtdAPVKTQefKCrpNzjHBnp4elpJ5cmwXW47cmWqZc78d1d0uDKyA1QIJvvSzV/LfqT8e8+vkZheA8YaLR0yZu+1E2isoEilijYTWRAw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
Date: Fri, 3 Dec 2021 11:57:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/3] EFI: constify EFI_LOADED_IMAGE * function parameters
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
In-Reply-To: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0036.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 17e26e88-f964-4342-5fae-08d9b64bb6ab
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33911B0443028A7A6EFEE5DAB36A9@VI1PR0402MB3391.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OXkmzpEvH/38LjDuUPlQH6oqk02ybulncz2RhBHrMr3aJoHMjiZ167gid06vg9BThol6i5xWJKqStbUoC48kf8s3RfthZNsBHQpkf3XvuSqq4fXqrqk5Gx654lcxr9fS6UkDp7t8TzvJg8RlYetyiHtppgj0UFkH8XnGSZQpwPnwFQxsJ4T9KcIApvxSiyzqJuFvVSdnNk9VU8rHnLSQg8btSXexluqx747cRolI5Gy6CNsEe0hGhoLV9fWcKerQY10pL6oaPkwnzTmfnTcUCyNC69DO1JCb8KXDUoe2oCBbzMvBDbwE1n/9NjNT1RRIN6JEqsRvsV4+wUOB/OSCUgFWx9HoF47cWqUEthQovU6L0wB5s/MMwROKoPbWXLWe+do6kDtlMVs4+KzKCJLZLUbEATTXb+RX7/ga+de/jsGuKJIUYdq8hffKFzbLdGA2duBEtIPRPrUVzLuXgPeLTsfSBvebEjW8bFrMzzqNPwa3OIFtZWmiTpyDVtInREaGubo0kR8dOMOSorI+aDnd/hNg3Uy10moeb6XaC5pBFWZvG3FOT3KQgFV9L8RB9Gj4JyC7J0yxqi2nYz5VkxtJfvR0uZGHKKH4hXCpkvG1Sac6hcVCVIV4tcuY4wQne6o921G8W+FTG+4QGvDzJOG4rZqQtWaMYnAGOxqDkS5YHtWdiVgbOsEhKJQWTRx+qkm13gdtHfO/Ry4AcDquTGBLHn9C3LxTgu4G16MoLkEgwJxHzTV8Jw+j8CrGVSsJ3F8o
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(4326008)(186003)(2906002)(54906003)(66476007)(5660300002)(66556008)(31696002)(2616005)(16576012)(6486002)(508600001)(66946007)(36756003)(86362001)(8936002)(316002)(26005)(956004)(8676002)(38100700002)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZlRvdXlSNmJEaXJCVDN5RU9rVExoOWlOVTJ1QS8wKzdrWGpuV0VQODY1UnVQ?=
 =?utf-8?B?R2hwMWN3K2RwdXhYS2JXMm9jeDJoYVlmN01HWndQR3VCeDB5Tm4xRHMrbDAz?=
 =?utf-8?B?dk5iUkxyZlp6TkVqcDJPaUlNeWttTXE0YXBYMEtFakUxbGpNcnpsWjNEQUtG?=
 =?utf-8?B?SUdXdzdVUjN2MnBpelBDWEZnQSs3TXo2bXVCM2NtSkdtRFBYUm85MWNKYmlS?=
 =?utf-8?B?WHFla1B1L0p6VmJyVVdoNHRXUUk5OEVld2xvRWZLKzdDSjBHY0N3WEpwaWpt?=
 =?utf-8?B?Zm9nTU5KMUU2WmFwVi9VVS9Cenpjemh6SkRIZStacGRkempkYUJsYk85Y0hu?=
 =?utf-8?B?SDMwMDhmVjF0U1V0WklpSUtueVpmcnI5ajFFVmpSREtRUXFZN0l1UUdmQ1RI?=
 =?utf-8?B?TmkxQmJXRUxKR2w5Ty9GQjd6aFJKa3B0M1RjRkJ4ZjR0Qzd1Z1dCblRvdjNk?=
 =?utf-8?B?ZkZUaG4yOVJLcXhzaVgzUHdHQW45OXdZNEFtZm50b2Z0RzZiZjUxWUJBREhO?=
 =?utf-8?B?WFh3YkY4M1UvOXRybEoxTDZDYlJsQjloTlExYUw1eGttbDBpM0F6NGNsU2dH?=
 =?utf-8?B?WEwyRVNKbG1WaHNkcWt4UnVqWDk5d1Fnam1vdHFGVVpCeGgyQzRzTzcrN2JN?=
 =?utf-8?B?bnNld3Boem9KN3duUU9qZi9FeENHR1FCNHhrc0plemxlc0RVdUpHTWo2NXJl?=
 =?utf-8?B?UHZjdFpZRGhaY3lqRzR2Z3lsQ0JkR3dLMGxhWkZHVmdNbXNtUEtadzZUT21h?=
 =?utf-8?B?Ni9xd3hSbnc0MlpXOFlnQ0gwb0NlUG9MMUVyT2t5bmtIM0NIMnNncEdNVm9m?=
 =?utf-8?B?dFc1eCtHYW1pUmZBRE1Bb0oyK3N1VkM5WHhLL2NpZlByYXdoeGY3eG9jTWpD?=
 =?utf-8?B?ZWplRHcwZnFUOGVFSHBqcVhpZ1FFRXlDWEo0TW5rdFpDL0FrZUlURTlXUG5Y?=
 =?utf-8?B?elRRQUx5aS9KSG5hUkZrdVlISlVJa29KMEJnYVV4R010RTdsL2FKVlo4T2RM?=
 =?utf-8?B?ZVkxVVI2K2taTU1rb1U1UHhpdlZDUE4zMjM1S1BoM1dYaWprUDNxbGtVUjVP?=
 =?utf-8?B?K1hUMklqSDRMbmJlSFVMQ3RrZkdrMmhRc1dyMmRPYXRqZUhyMUlmbWZDY09w?=
 =?utf-8?B?NU4xQmtQeFA1U0ZUbXlnWmpPbzJQdEVDZVU2VXpWeXY2bEdJV0pQVGxpV2xC?=
 =?utf-8?B?UFpGRHFqT3VXTlpZQU5uN0hUUE5YYVZrcDA3K0hTYkJnLzRqOWxvTDBrTEtO?=
 =?utf-8?B?djY0N1l0L1FJbzFUb0hjcEwvdmMzc0l3c1NvNHhZVzhldHdjbXpCQXRYemdv?=
 =?utf-8?B?akpINkFqOXJDZGpGWVRlUHI2Mlc2Vm1XN1dEOU52S2NIYnJWV3NVSEF1Yjhz?=
 =?utf-8?B?QXJ3aVpuUWp4WHJGSjdDVHVIcTcvWW5TMDNKZGJuY1N6Zm4vS2RwQll5OUIz?=
 =?utf-8?B?VE4zeUQyMzdzK1VFd2FDNE44ZXBHcHdORXY5VWlESGF0TXNaOXI1NHVuV0NP?=
 =?utf-8?B?NGpMeWlGdVo2SDZMdkE2YlYyc1dEY2ZrSWhkQzF1dEZ1SXAzNXRkN3kxdDJD?=
 =?utf-8?B?dWtwNW1GMUZCUm9uT0FwRDgxWUwyWk1HTTYyOGVVemhmWXR0S0FwVTQ3TXRO?=
 =?utf-8?B?R0FXaFpEVWtoTjh1RHM4T1lmbEdtT2xCV1pSK21XMHE1cmgzQTdHc0x5VnNr?=
 =?utf-8?B?bThNT3p3K3RZYXhSRTNWdHcxd3h2djRUL2tZd0kvSXZrM3Q0Vk5nNmJETUhm?=
 =?utf-8?B?SzFycXlHY3V4MzVhWEc1Mi9ITVdHUXdtdGdQTWYxK2lpdmFnSmIvVGNUVVU4?=
 =?utf-8?B?OVliRUtSY3NBdGFoNTFTTExJZTVZOHVlK3ZoRHNjVWtGejcyRmFCQ1VHOG02?=
 =?utf-8?B?NkVRckFkZXFURGU1Z1hqU0RIb2t1NXFleWtTV2ovcno0S0w0MzBYVnhDY20y?=
 =?utf-8?B?Zk5OWkFLeW5tK1R3L2xkZFNJMXIvblhKV2pxOHdwOXhNY2liYTY5dG9PdWp2?=
 =?utf-8?B?T3ZKMzIvTjB5eFl5VzNaaVFCWWVydmlKL084VHUwLzhmclVQdnZiejJZUzRw?=
 =?utf-8?B?b0VLQUVYYUtDWFQ5V3dBWkVJejNlamdERzJtOExteGUzOFp6VVc1VHJEWE5r?=
 =?utf-8?B?bEcvWUUvSXhwd1MvbFg4VG81dGV6MmhIZUI5Y1kwZSszcUtTYjlxZC9FVSsr?=
 =?utf-8?Q?S6VoTw5qxq2Fox21JrfGRn4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17e26e88-f964-4342-5fae-08d9b64bb6ab
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:57:35.4412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WXBHDNu5nYwmIaNTo+1bKc5jXuRa4r0ZoKyyH04vfubo3CPb+vKKko1PqnmhDExA230rQzmTpYrHUdrJkg4oiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391

Instead of altering Arm's forward declarations, drop them. Like
elsewhere we should limit such to cases where the first use lives ahead
of the definition.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -44,20 +44,6 @@ void __flush_dcache_area(const void *vad
 
 static int get_module_file_index(const char *name, unsigned int name_len);
 static void PrintMessage(const CHAR16 *s);
-static int allocate_module_file(EFI_LOADED_IMAGE *loaded_image,
-                                EFI_FILE_HANDLE *dir_handle,
-                                const char *name,
-                                unsigned int name_len);
-static int handle_module_node(EFI_LOADED_IMAGE *loaded_image,
-                              EFI_FILE_HANDLE *dir_handle,
-                              int module_node_offset,
-                              int reg_addr_cells,
-                              int reg_size_cells,
-                              bool is_domu_module);
-static int handle_dom0less_domain_node(EFI_LOADED_IMAGE *loaded_image,
-                                       EFI_FILE_HANDLE *dir_handle,
-                                       int domain_node);
-static int efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image);
 
 #define DEVICE_TREE_GUID \
 {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0xe0}}
@@ -650,7 +636,7 @@ static void __init PrintMessage(const CH
  * This function allocates a binary and keeps track of its name, it returns the
  * index of the file in the modules array or a negative number on error.
  */
-static int __init allocate_module_file(EFI_LOADED_IMAGE *loaded_image,
+static int __init allocate_module_file(const EFI_LOADED_IMAGE *loaded_image,
                                        EFI_FILE_HANDLE *dir_handle,
                                        const char *name,
                                        unsigned int name_len)
@@ -713,7 +699,7 @@ static int __init allocate_module_file(E
  * for the reg property into the module DT node.
  * Returns 1 if module is multiboot,module, 0 if not, < 0 on error
  */
-static int __init handle_module_node(EFI_LOADED_IMAGE *loaded_image,
+static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_image,
                                      EFI_FILE_HANDLE *dir_handle,
                                      int module_node_offset,
                                      int reg_addr_cells,
@@ -814,7 +800,7 @@ static int __init handle_module_node(EFI
  * in the DT.
  * Returns number of multiboot,module found or negative number on error.
  */
-static int __init handle_dom0less_domain_node(EFI_LOADED_IMAGE *loaded_image,
+static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *loaded_image,
                                               EFI_FILE_HANDLE *dir_handle,
                                               int domain_node)
 {
@@ -862,7 +848,7 @@ static int __init handle_dom0less_domain
  * dom0 and domU guests to be loaded.
  * Returns the number of multiboot modules found or a negative number for error.
  */
-static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
+static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image)
 {
     int chosen, node, addr_len, size_len;
     unsigned int i = 0, modules_found = 0;
@@ -942,7 +928,7 @@ static void __init efi_arch_halt(void)
     stop_cpu();
 }
 
-static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_image)
+static void __init efi_arch_load_addr_check(const EFI_LOADED_IMAGE *loaded_image)
 {
     if ( (unsigned long)loaded_image->ImageBase & ((1 << 12) - 1) )
         blexit(L"Xen must be loaded at a 4 KByte boundary.");
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -709,7 +709,7 @@ static void __init efi_arch_halt(void)
         halt();
 }
 
-static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_image)
+static void __init efi_arch_load_addr_check(const EFI_LOADED_IMAGE *loaded_image)
 {
     xen_phys_start = (UINTN)loaded_image->ImageBase;
     if ( (xen_phys_start + loaded_image->ImageSize - 1) >> 32 )
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -389,7 +389,7 @@ static unsigned int __init get_argv(unsi
     return argc;
 }
 
-static EFI_FILE_HANDLE __init get_parent_handle(EFI_LOADED_IMAGE *loaded_image,
+static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *loaded_image,
                                                 CHAR16 **leaf)
 {
     static EFI_GUID __initdata fs_protocol = SIMPLE_FILE_SYSTEM_PROTOCOL;
@@ -561,7 +561,7 @@ static int __init __maybe_unused set_col
 }
 
 #ifndef CONFIG_HAS_DEVICE_TREE
-static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
+static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image)
 {
     return 0;
 }



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 10:58:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 10:58:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237352.411666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6Gn-0000ts-Ab; Fri, 03 Dec 2021 10:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237352.411666; Fri, 03 Dec 2021 10:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6Gn-0000tl-7W; Fri, 03 Dec 2021 10:58:25 +0000
Received: by outflank-mailman (input) for mailman id 237352;
 Fri, 03 Dec 2021 10:58:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6Gm-0000nF-2H
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 10:58:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eede6215-5427-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 11:58:23 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-N0ogYuKWOOScXHG18jhiKw-1; Fri, 03 Dec 2021 11:58:21 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 10:58:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 10:58:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0033.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::46) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 10:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eede6215-5427-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638529102;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lyHpDq+f1Yn1Y+Nw40SlcTxVr78qVUTB+hT/e8DkD7A=;
	b=R81Az5JckaS5zU8uTGusKqQ2f1inQJvajCIT2ioQ6Bc061zEPHzAU2aZedR8difqr04KkC
	qpYCQc4E43AfKyf8GbfFB3A8lokx1FsI0u2PaAwqYE7u/+yoJcseRDZFMnHpkEHg9eszAG
	kJ1kI8/Qs3wnTeyjUPFQDB2H6XgvjTM=
X-MC-Unique: N0ogYuKWOOScXHG18jhiKw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z4cMBeRZRMNoZ/Nip+eSIwLTXwb/K69kihURpo+cxoh/+tpeOdcOPSouardHbSIvYbOuTkkiCmwRUGNwpP+K1XgUPghP8175/RPXnjlDkI8PQnTurYFw3NG/QNPgOLJHcGdBbCy8fJsS5fSQpYLmJjpmh0b8dcfQWIF4gHOPfrPJGCT0SKZHSyes4/Wq+AcQGm5sH/Ls/JmznqtXXfza1+rvbl33ndVluGTOK8fCZXRRTseUdTbaEFOfAzJpNMg+iqR0DpZuKOB77q5cMnx84hqIeMVT6KlyRaNkowCZB8GuuowZgjkhBEz84rAEEuU2P6KzHDflD1IEEfXeufRpyQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lyHpDq+f1Yn1Y+Nw40SlcTxVr78qVUTB+hT/e8DkD7A=;
 b=WqG6OZAd/jLKfirDmd/v21p9vssEy+5msy/81qCn7XJuxPVThdlTViMWs3SVwEiSuFrKqQnMlpeEoazB1H7RlkwqSJqlVJX8MS9QDIVPUVnCuR8CtawpVerbmsQ+itRkPc4U9O0ZhjIwOSLF6yMeIvXxxSZoR9ub+8YMl3m9CYqDoWeDIXMTl/TTqn8gncwLxlrJJ//xzJEhM3xwtsp5rLsJ4OBzThTNnuc7BbWo4Y7aAup18xnoEgZxlTwTpEf8NOCrJwCKsWm2mUPsrfn/kaksj+oH7v83COXP8eK/xaWYzXhgAdynIVyKjK2lm2rI7NOcVT7+i7s7/9HXU6R44Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <edde87a3-beb3-c109-65ef-36e74df28e7a@suse.com>
Date: Fri, 3 Dec 2021 11:58:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/3] EFI: drop copy-in from QueryVariableInfo()'s OUT-only
 variable bouncing
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
In-Reply-To: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0033.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f987c2f7-a0a0-4f3a-5914-08d9b64bd180
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33917D2C8D78A66A4B163680B36A9@VI1PR0402MB3391.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	4U2wHwhL+ZtWppXaUosfUeeoLsrCidE862UBvFYyEmRikUh6808eDT6sKRtRokZUfw5y/D3XZMrEAU6Rz+V0teLnwMD8acoVR+HwP8bm/NBYeMwF8aOAah/FVQexziPz/Vp5jEV+L1KMCLE3QQbTAct3dp9fxksSWIZiJx1YlcnzWniH6V7FTae9h/zIZ0VJLW7vC+eruRU0+/uXqM167GXbj+6UecqvVi14HK7ATM8VUtdj2l2gVQvhOBngPfPdMFh7UExOlmM+drUUibu1VAEJTw5BWUMNQnIt90Q9bkr79xKybeQsG0/eZTawqswY7GSFrvWc2tE7lmJj35I9Q7xQViRRg8GULleED3dJFyVbqZAZrcw7j1+rydDkteT4gVwSjN+t07Ydzpq29Ucv6mYWepwfQ2cIA3tViNtNPUWLmBy87pv54Rv9mP94j4/UM8uyV2CD60SlSKhSDhpTBZ0Nn2iXvvrW3yza+cXSgSRCeUkJaFoiGNWtZNRs23Pehp6/8xq9mNdDH/52J18FCG2d1i17tFVp3CVTGPVTV3Yi2h1KFNCbpWIpaD+SxKY/WuoqZGOQjMVKuWOy74SCUy3Eu/8cY2JS1tyqW4WK2oF4YfBUJL9akEmxm9BYMFkAdq4qTCb92CDByPTnby0o6iQNFsrq7UGde9R7QIFukaD5aJ7/8sg7i1zV+8s5O9gsXpjjXaRKemONrAA+DgGmwljko+FBt8Crun2H8Llw6Hc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(4326008)(186003)(2906002)(54906003)(66476007)(5660300002)(66556008)(31696002)(2616005)(16576012)(6486002)(508600001)(66946007)(36756003)(86362001)(8936002)(316002)(26005)(956004)(8676002)(38100700002)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VjhmeDNHT094SWY4OW1MOU9tMEdUNkd3N1BiSERvZUZVWkIzNHZQVWpmVEFj?=
 =?utf-8?B?SlNPclJPU1ExTHEyT00yV3JKK3B5WS8yeHYxYlFlTXVGbUhJbC9VdEZLVzV5?=
 =?utf-8?B?NzVidGp3V0xJU2dmYjRiVVZrR2IwODNiaFdJNEFZRDN1Tk1EUUxGWjlIZEVl?=
 =?utf-8?B?MWVnNHNndlVxSXFGK1dDOHpVd0Ztcng1c2Ewd3RBV0s1QzF0bmdpdWlUanRJ?=
 =?utf-8?B?RGJHakZJRi9BTXhmSE1GRlVUK3ZiRlZmNENuUm1pSkNzTFdtdHV4KzE2eWFz?=
 =?utf-8?B?cUhTM3loNW50NUJDeGthQmlrUnNGcEgvdThscUh3Nko1WUx6OFplbUJjU2Ns?=
 =?utf-8?B?YlJFRUpQeERhbUovTi9NNjUxempUcE84ZitaWkh5bHBYOVdnalNlaXlsc3Z6?=
 =?utf-8?B?YmFvbVA3STVOWjBkRjhUOUtMbHovUSt0Uzg2NElGWUpXdjdBT25Tbi9DN2VS?=
 =?utf-8?B?VWNudUFaTStETE0zVHVrUStLZXdlU1BUcE9KbVFUUkFKd2FoMC9VckphbmRs?=
 =?utf-8?B?bDdZMkpiejNRbGxGVU8vakIwaHdSUWdKVEU3SkxBMFpuTXdQQTlLQWNKdG5v?=
 =?utf-8?B?Z2Qxc1Q0UG1XbkloWVhBenozekw3SG5rQ0crWnJIb2JTVVpwUlAwK0lRNCsw?=
 =?utf-8?B?azNIVGNXdEk2T2Q5WndORWxONTRaMHZoMjFCVTdIUExSdnpBd0ZpTjFYK013?=
 =?utf-8?B?ZGVVQVJUL3k5ZGFVSitUUlpmQjJER2hYZEVwUitjVmZCOW5FWThvVnJJM2Np?=
 =?utf-8?B?MGhwVWFKd3h6SFU0SU9LbUdiSy9USGVSWUtNdHN5U0N2ZlhSWi83N0lSVnBt?=
 =?utf-8?B?ZS9NaEpvNVdXRW9yR3BsVG9OcDlRZ2MzV05BSEpzQytCTlcrYmRjMWd3ZlE3?=
 =?utf-8?B?VFBtOFNKZm1FK2VUNUdlNk0yYnhZQWxCaGYrYTIxL05wVnRkc0lxbC9KVVQ5?=
 =?utf-8?B?K0ZPQW5uaDBSOWZFVXI3SWxJMzZTV25HOEdMbDRaeTlYMnFndWRMZ3NUbTNl?=
 =?utf-8?B?OVpSVHNlV2Zqa1g5Ri85WDUwVnd6eW82RllaMGdXSW1KN1dPMnhCbHAxNkVl?=
 =?utf-8?B?SEtOc3g0S0Y5bXZBM0NwV0w1bEJSbTJ6cGE4VlQ4U2V4Q1o4WGRlSVpoS2p3?=
 =?utf-8?B?cGswejJDdzV1MWJMMUhuUWVsSkdUbHR6bG42OWFrVkhicDc5UGdXMHNxcjBJ?=
 =?utf-8?B?b2c2RHhaS0NsQXl6TTBmK3ZWRDJnZE5SU0ttQkdJS1VuQVJSa1k3T09Mckdn?=
 =?utf-8?B?Q01Qa3lnaFhVTnpaWDRlWHVSak5UajBZb3g1bWRPeCt1OHFibFFkOFNXcFp1?=
 =?utf-8?B?T24rdWcyR0tzWHUyZ0V4bzR6Q2pseUFvSXdCZUJoNnhTcVI4MVBnTTQwaEMx?=
 =?utf-8?B?VFJNRDRCOG1QQ3orb3ZoRG44MjNpazZ4VUZyaEt3UmtZR1hZZjdKNEFwQW5Y?=
 =?utf-8?B?RytSNHhkNHU1OG1SNzZsSis1M2YzdktWbE5yNFB5ZnAwK1ZWMEViazlqenJM?=
 =?utf-8?B?SmU0RWlCZDlYMDZ5Znl5VWN2dU9RMGFrZGdhQmwyZUROYmdneUFLUUcwQmgr?=
 =?utf-8?B?QnJ2eU1DRDhyN0YvbkFlNUtqYnNlV0hza3NqaFhLQ3BWMFRTdXZYQ0hkdDVL?=
 =?utf-8?B?Nngrckxzamt3SHc3R3BySkQ0b0lVMXI3M1Q4bFBaVUFHR2hSZDFpNkZrVXZt?=
 =?utf-8?B?TjR0ZnpER1JyYy8wNVhac3hBaXZmeVh0VHRZRUNtMkhpd2FwOGxxemtMQi8w?=
 =?utf-8?B?NE5tN3FBaElvVHVFdVVIcG9qUW9tMk00WFVTby9zaVhCWTgwdnVRSDFjZUph?=
 =?utf-8?B?cDFTOGc2MzNhVDJvcmFraDdpZmV0YWFlRDdlc1BrdmlmMFVwMU1SMnhJOXhK?=
 =?utf-8?B?UkNoN3dZM2I4cXhaYWQ0c0tsbFhOSmQ1VGNoQ1FrUGgwSkgvQmRnYVlnZkhT?=
 =?utf-8?B?dTVvUTBRem1BQmVjTEpyRUpnR1hZeWpPRW1maDhuNUFDaHVrNHpDMlhWcG84?=
 =?utf-8?B?RW83Sm5IV250L1ZMak9IUUtKdm1PMVpPSkVWZTA2QUVUZGE4anE2cDJqb0hm?=
 =?utf-8?B?elVadWNCUHNFMHo1dzRtdHZ1Y0JkMzVSUDlEZFR6d0lGYW9MVXp6ZDVjTHVB?=
 =?utf-8?B?MVlUdjZYK2JnNEtrbnQ3eEExaGlBUE4yazNhNHF2ZlNaejBiRG9wckZRZ0dE?=
 =?utf-8?Q?hle8/M2ueqxh2sPZCpxLrcc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f987c2f7-a0a0-4f3a-5914-08d9b64bd180
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 10:58:20.4886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B8A1AYkIZEJtRPlwzGhfNzju25hkPMVVSF5+JHf5mZbeWZvjR6/g5DBt8EojKcH93xHMNExOpzu/j3NuGaYijA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391

While be12fcca8b78 ("efi: fix alignment of function parameters in compat
mode") intentionally bounced them both ways to avoid any functional
change so close to the release of 4.16, the bouncing-in shouldn't really
be needed. In exchange the local variables need to gain initializers to
avoid copying back prior stack contents.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/efi/runtime.c
+++ b/xen/common/efi/runtime.c
@@ -608,7 +608,15 @@ int efi_runtime_call(struct xenpf_efi_ru
 
     case XEN_EFI_query_variable_info:
     {
-        uint64_t max_store_size, remain_store_size, max_size;
+        /*
+         * Put OUT variables on the stack to make them 8 byte aligned when
+         * called from the compat handler, as their placement in
+         * compat_pf_efi_runtime_call will make them 4 byte aligned instead
+         * and compilers may validly complain.  This is done regardless of
+         * whether called from the compat handler or not, as it's not worth
+         * the extra logic to differentiate.
+         */
+        uint64_t max_store_size = 0, remain_store_size = 0, max_size = 0;
 
         if ( op->misc & ~XEN_EFI_VARINFO_BOOT_SNAPSHOT )
             return -EINVAL;
@@ -642,21 +650,6 @@ int efi_runtime_call(struct xenpf_efi_ru
         if ( !efi_enabled(EFI_RS) || (efi_rs->Hdr.Revision >> 16) < 2 )
             return -EOPNOTSUPP;
 
-        /*
-         * Bounce the variables onto the stack to make them 8 byte aligned when
-         * called from the compat handler, as their placement in
-         * compat_pf_efi_runtime_call will make them 4 byte aligned instead and
-         * and compilers may validly complain.
-         *
-         * Note that while the function parameters are OUT only, copy the
-         * values here anyway just in case. This is done regardless of whether
-         * called from the compat handler or not, as it's not worth the extra
-         * logic to differentiate.
-         */
-        max_store_size = op->u.query_variable_info.max_store_size;
-        remain_store_size = op->u.query_variable_info.remain_store_size;
-        max_size = op->u.query_variable_info.max_size;
-
         state = efi_rs_enter();
         if ( !state.cr3 )
             return -EOPNOTSUPP;



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:02:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:02:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237358.411677 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6KV-0002Kk-RX; Fri, 03 Dec 2021 11:02:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237358.411677; Fri, 03 Dec 2021 11:02:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6KV-0002Kd-OX; Fri, 03 Dec 2021 11:02:15 +0000
Received: by outflank-mailman (input) for mailman id 237358;
 Fri, 03 Dec 2021 11:02:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6KU-0002KX-MM
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:02:14 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 78562438-5428-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:02:13 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-z7fE4Dv8PnSXCePnbj4VhQ-1; Fri, 03 Dec 2021 12:02:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3389.eurprd04.prod.outlook.com (2603:10a6:803:b::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 11:02:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:02:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 11:02:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78562438-5428-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638529333;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gTzUmTFi+bQ85l6C7lOA0QHrHZGSoFzJbGdTk8XU1AA=;
	b=JOY2z7i72sD6TlVE7ORGnxwe39GfsKkUfpjUS44TqUOj4oKGo/5hQtvd/YcccX352vJGF7
	0lrcvw4KHz24AepEKuOLVU7QVzb7ywVwXzGMfHRJ7hTzL+aBn7VH7x7zkX5p0QgyAPrLiL
	Zo54ic3qlJLXEBN7U6UoGPPDRrrwLec=
X-MC-Unique: z7fE4Dv8PnSXCePnbj4VhQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=idZ+E++HqI77X5GUvn2i+KnwLc34Ar94GayWB3vhCN6+Kv6lxKWwE46O78lF48rPQmzVUaIpsT6juqzEx8LWYmHP249OefOSZRfN6Pymy79iAq1zO9xwcSmLzmHKq5xOunIAUh53wlDKN0IWdRL7rBibi267boAYQDTKFikZPUb7hnLrsjRNHiH8rQVpQBMYREYlDXFUVgLs26soBBEnkDMTMvIbtuLmAMynyfsN+yeQ82OmJLN0UeIj/nrAeRyTT9z/oNujQ69S7QhQX5BzjGsMRi2DFlvbrrltD5eeXXLv99lOqYqZgZtof1+wmGq4h4TRhuiz5qpc/3dSib5m+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gTzUmTFi+bQ85l6C7lOA0QHrHZGSoFzJbGdTk8XU1AA=;
 b=BpDwn1M9uSSKYdbbrYTKO/5iNI7n0tIpJsuiM1i5KBze0y9QlyNVclbEQfDZGZ0dZMlVZyv0I/wh8w9hLre2kFuHaLamYj7dxFVNRa8C0Uktv0yo+ERZBGgZcN0VOHbFYywBiu2eERCuIeNIC8v4nTJzZktnH9WYJexkLBzIDcpD6MMkQJ0LkumTdk5BqgZ9dSPVHqYHh/HzORH1r7AZqp/GCTYID1rM9fbAWR31SUCeecVAmia12upVJU3axDgQEhOE1mUT5Xv5BH9syqbnpV57bg0RRDAL8Y3gZyD4++5ynLL5yv7xJeI11b0bUiXJuMTIaA1j0iM9VeUeRFJLmA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9e7d9c7a-9884-c3ba-e2b4-1477d01172f6@suse.com>
Date: Fri, 3 Dec 2021 12:02:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Ping: [PATCH 0/2] x86/vMCE: address handling related adjustments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <b16904ec-0302-4094-7d89-f484cbf0f8a5@suse.com>
In-Reply-To: <b16904ec-0302-4094-7d89-f484cbf0f8a5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0011.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d54e9ba7-bdb4-4ea6-67d8-08d9b64c5a95
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3389:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB338974D2C520ECA51C902B29B36A9@VI1PR0402MB3389.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sgGoJo2Z92IqtFVAv7N7cEx2Yy5ILJM4Q+cUt7d10S9KpSFU1c1nwh5Eke+cd2EOSTU/OWVlY5uY0kxLEXEJoAfWods32BKV0nR7TSRsiKzetkflHhm5pNnAArn/AHxPNSQQFcnlte3OjPfW8o3xknMDr1eXZ/vk58/LVRTW2oamKLCv6lhPNKD8IWPFy/X49KixyLcwspe7p2YT4TKwStdZRGD8pdvPbD0U3v/8BmomZqRxbt6TE5G6//4uJR318NYUGBOkbhDQ7wJWXdDQ12iWveI4AmGGuhOWKNn1Ex3ncIypA+z6zWhpkSJ2f5kbt/0c2SM5Kon+sJf7Jg9DMPWpPVixK8JHTDkFgXzY/uaM61nl/mMaAf7dA4JkNop7lxMx3iMspVuJe1bj4M17O3KoVMJaRqsAC8mT4VGUIr9rYusljyBwsYaOdLYimfSp57azSXztAABCp5MAy0wo8cPXzVRUjCm1akCItIC6kW17XRvTd4aY3yj8h1XiRDOMIZumiRlFntNMWE4ARCuvsECfBoUKrJu0ZtqsNZ2/8cI/0XyrKTK4YxNi4KKCi3XbcaL5UlGtBLGooLBb/4cUlCLMu2GHyou0vl2Jzr0o1pOOaboevA9nK6FbtHDpcysYkVjK9W0hnzu2hLdGTewXEAOlepJ3Ss6UMKQAl8p654lm8dAYd7Nyiygdn0lkgNHNJ4OSxQNfs1ReQYQkKxrdV5qtLUQl1iKkKwV2YQo85Lg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(66946007)(110136005)(8676002)(508600001)(316002)(38100700002)(5660300002)(186003)(53546011)(26005)(16576012)(8936002)(2616005)(83380400001)(956004)(31686004)(31696002)(4326008)(86362001)(2906002)(36756003)(6486002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OUZXTDhRSUd3SEwxUUpRYThoUDkva3haWTNjeTltU1p6eXJxV2NaeEpQbFJm?=
 =?utf-8?B?enl6SEk4SFhkeEZ0bGdIY3FpZEF5RXVBTEVlL0RYVFVJSVJUYmh6U2pGeE5Q?=
 =?utf-8?B?Y1dscFVFMFg1OWpKQ0ZlNEM2RWN4cFNxOTROME1lSmtEczRVSEVaOFVZb3M3?=
 =?utf-8?B?Q1Q1VzVwaWtiMzZUVHowM2phZWF2YnlJTVNsZUh2azVPM0dPbmtMSU1SNEJN?=
 =?utf-8?B?WHladzM5YjJxZjNqUmdCYktkU1lkQ3JLK0pTMTlnM0Y5aC8zOGxmaUxFM2Mv?=
 =?utf-8?B?eEdLdUduVGtQa25hWjNGRlNWQTdLTElTU2FOd1h0VndZOHhmcHRJeW44MVJH?=
 =?utf-8?B?NndvckUrRllLTU41cm95UyszcEQ5amdmSThxUDNNdXJYK1VHMWExSU9hbURT?=
 =?utf-8?B?SlRMeml1SWV1L2xNUVlyZEQ3TUo2MUdZaEpIWU5lUE02Mkg5QVFkT2JMeUdE?=
 =?utf-8?B?MElmajZrWFU3RUtPbGxxZytOalR2NWgzZmQ2V0MyQVFMTHptWTY2cHNxNklz?=
 =?utf-8?B?aHFQaDVVb01XRktoWDRqbm1hRDRMeXBlNTR5aGg2UmVRdTNIRU9ROWpHdXIz?=
 =?utf-8?B?cm5OWm1Td2JOR3Rsd0tyay9kdi9LTHI5bEdqRENCTklUMWZueGlzMk1rOU9x?=
 =?utf-8?B?MCtzdXF6OUNZSkVtdXZPVXZFamZjaHBUSWNjeDlPeWFRTFQzaXJIVHF5WmlE?=
 =?utf-8?B?bGtFTlYrY2k0WjJyQk16V01ROWFDRHdzSkc5angySTU4eFJja3lzbndGTFI2?=
 =?utf-8?B?cStJd3owU2NFMlV3WVR0dDIvRHltMnhRY3N2SUdRcGxRZUVxeXNkeGw1UnZY?=
 =?utf-8?B?RzcrUWZoMXJNSEhJWG1maTN4bUN4TGRJODFEd09JMmdIc2dNYjFvRzRYK2lY?=
 =?utf-8?B?ZGY3R1JmekQ4ODJEOFJBM3E4VHFwSnc4aGhyZy9CbUhIbW14SUlLSnUrZGl0?=
 =?utf-8?B?amJIVE9mNGlXT3BlL3B0Vk56eUxmRjJnbTc0K084K21CWHVCb3RtT3N6elgx?=
 =?utf-8?B?bGx2VFR1dU9qZXZnV1d1YnIwM0EzSG1XK3ZaTlZYWDZNT003ZHIvYm16RnRq?=
 =?utf-8?B?emd6UFBSNTFaUHhIb0doOS9lSVZYejJYazhLdjVSY081ODJpY0JjMktsSUtD?=
 =?utf-8?B?cU9XRmZTNk1hTXhua0VyVFM0YW9mNGVuZXZyckM5NW0xbDhRZFNGa0JwQ2F2?=
 =?utf-8?B?Y2FRQzNJd0djUVFmMWlOQnR1N1NzbkdMaU5mTW1NVWthZjFndFF6K3IydXFl?=
 =?utf-8?B?K2pLWXJEZ3VFNXBKMTNPTStGRnplT0t6cFFmMWpKUDFNN2I5OXpyWmVEOXRH?=
 =?utf-8?B?OEw5QTJMbk41bTRyN2RFSVJVTFJvRkZ0NkYxcndhSDdYc01qSVNBU1AvUVdm?=
 =?utf-8?B?TjcrSFV3U0RySE9LNTQ3OEJqV053RlZFQkZjeWZyZXZ6YmdzMHhHS2NTK2dh?=
 =?utf-8?B?UFJieFRuS2ZCT1JqcHNFU2tudS9SV1lrRVZ4YVBsWlNWRDBuVFNhRU85Q2JB?=
 =?utf-8?B?aTBzdDRFMWZjZjhraGZQNXhxWkwxS3RkN00veHc4TUJYeXY3UDU4eG1oZlN4?=
 =?utf-8?B?Mm5NY09tRCtWcmxKNWYwdUZjR1FMdnM0OGNzSkFnaFFZY285MHVJUmcwejhW?=
 =?utf-8?B?cEEwMnhqbTk2cVlpcVpURDNlUHJOTWRYQXM4a3lXNk5HaDU1VWpZQXEvdGc2?=
 =?utf-8?B?V255MXpiWHNYM0NBVWM3YStvcXBwc1g2eG9vZVJsanQzak1ISGNvcDdSUjBU?=
 =?utf-8?B?a3NuYjFDVDVKbE01dVhPZVZjdnQyNUt6V2tqQ0hVcE1sdEUrZjlDZFR0Tkg5?=
 =?utf-8?B?eDdUZkV0KzhpdmxEOTM2QUNwakpqekJvWjJ6T1VnTTV2QnlVek9xRXdQRkVq?=
 =?utf-8?B?R1Y1c3NSTzlmeHR0MnE3cS95UnZRR0pQcERzWmsyYTdWSGVqVlJjSWdwQk41?=
 =?utf-8?B?WFkyS0pLYTd4MnA4L3BXK2VXT2NtZjNhdnFSWmd0ZDhxS3daL2gwd1FZZmV5?=
 =?utf-8?B?Q3c4RXhib2xrU1VWSGhPb0dudHZBSVVMNURwTGRtNXd0T093VWFSWkRmZ3F5?=
 =?utf-8?B?K1RobG1Ha3VrYlQyNVRZeHFGTlliRVp4Q2gxOEFNQ29BR0FQOU5XTFYvYm9E?=
 =?utf-8?B?cmhZQXlldXNqUWpCcjdYdkdOeittY0tjdDMweCtZRnA4d1pacVhNc0k5MXpK?=
 =?utf-8?Q?c9YX83fGqV1obi4YhI6YhMM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d54e9ba7-bdb4-4ea6-67d8-08d9b64c5a95
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:02:10.5525
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yxH/kMQtB51LmX9BI50oDbj9xzKxX3tt0tMewEKxfXnolrPgoA5LqgV2Ld3W1xC4HoGi+r0Oel7SfNbo1WCkoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3389

On 28.06.2021 13:56, Jan Beulich wrote:
> While going through uses of get_gpfn_from_mfn(), I've noticed
> some anomalies here (but of course there are more left). Patch
> 2 is specifically RFC, for altering the public interface.
> 
> 1: adjustments to unmmap_broken_page()
> 2: change address space for incident reporting

Anyone?

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:19:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:19:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237369.411691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6aw-0004M5-H9; Fri, 03 Dec 2021 11:19:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237369.411691; Fri, 03 Dec 2021 11:19:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6aw-0004Ly-E8; Fri, 03 Dec 2021 11:19:14 +0000
Received: by outflank-mailman (input) for mailman id 237369;
 Fri, 03 Dec 2021 11:19:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6av-0004Ls-9w
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:19:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6b6050b-542a-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:19:11 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-fyJXiNhbOVOt3BPP9QuC-A-1; Fri, 03 Dec 2021 12:19:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5471.eurprd04.prod.outlook.com (2603:10a6:803:d0::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 11:18:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:18:59 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR02CA0023.eurprd02.prod.outlook.com (2603:10a6:20b:6e::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 11:18:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6b6050b-542a-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638530350;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=BQXIPX/L8qQrakgKoP511OLFf74HLVrRAZwLdKfXCY0=;
	b=ORKGpt/Cf6gVL4MGfx9Fs0Wmv4lcTohDUPg+3WDqsmIDamjQ4aWv2lwWWiWVfVXQl/AOBv
	gnaP7OvL0X/Gel8GobkctCeNBs4LgbSJZ2JEBuMfu7aoacmSC7VNoX8YvNd3qkImJXppt2
	jaxPZ9Zr01KZkMVKj5oexDf9bF2P5JQ=
X-MC-Unique: fyJXiNhbOVOt3BPP9QuC-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lulFvkU1FlgbbvYsMspp+HJI10eg5/dqKxd7ok70zUYTl7y96c5LhODCLyaNqqlpJ3FRWdPVp8oIfdhHNo8GLHZQNYmrV7ePLded3V5v01xNhhm6r8Xgi3FdC1k4akAQx/fQReS/2LYb1LazbRtHA3A2vPK8lfPdh8Qsz2hWw6uDMHYAqzSRVSvafihaaw+EzQx40w42k7x9yQDWE/chXs55L+1XBzVqj/psQxtcdxCZosOkxp52gCe2gy8liAM/rzSOKf9oD4tsmXFnmKY9BxsPb1AOKdoIGpMhZU2FkBTKjsT4984y5yvQTIUdwGJj5s1r3+RyOg14x9hBwNsPeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BQXIPX/L8qQrakgKoP511OLFf74HLVrRAZwLdKfXCY0=;
 b=TrG8yTZcT7rxyDEYkwLplRXUcEKUNyhirO6mZZ4XswLkLHPqXyUmvx4/bkn4xEeytWFtaVJdHbhRnSuxIBW2yiywpsC5uj4JKTxiRjoKrxb4mpuYKB2gulaf8CMDufHuFKjN5Fxa/6gj/5NV/WOZfu91TYT1AfqQWVhZ8l8eB1vWMTsH6belQdRKRwrSHLAPOX0P/FV7s/ePvYeA+lMA2lpMLTZXP9Ra2iV80eWlN7gnwJOmuMSWnvtol9ZP+hIoxyRPhGLCuxvMDEadtcjZsBCz8DaA6figAByHI6MNG+TjJLdsIkV6j2iTG5y9hRncyk0FVMM73hZlb991cqpNnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
Date: Fri, 3 Dec 2021 12:18:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3] x86: insn-fetch related emulation adjustments
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0023.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e478e195-f1d5-4fec-0864-08d9b64eb3dc
X-MS-TrafficTypeDiagnostic: VI1PR04MB5471:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB54712D6DE6D3A82EDAAA5986B36A9@VI1PR04MB5471.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3CPq5a1IOUxq4sP4cEVMJSqAJCw+Akyn9AIkIVMpZMP/6LVtpn5trLpAIhJO/tOwqowutDLWGws8BNQvJ5JqO+cygW29Ox6P5KEZ/XWJtW6I1fF1fK1uNYMVqu6IyWiYEKb8t0zqx9RM4rU8gVDvhfWybM2LbrK2AXmEtgDUOrkLz3I4sxlLEAoxUyuKpC2AC1Iqhtyi7NbApn3dI/vtYxfhp/EFQVXMNJOcNOIfEsW9siNRS7aapil+q9JSEH9bwlqt49mj1dRlcPYqYSq4PoF7atxFD33gmlyS9voXGif3yIINGBncEh/qIpCv3iRQAGcYVzfLorJFaX7CpRv2MVlau5JZnVpibqm10smGiPO48V5e+7Bhpv+ZXze8a0LJcO9maLBngWZ+NisX4NvmpAofoDi+avK/27Tft0Rq0BOMcoLDnJUhD/UE/Ued4ktTaJMMO1/aKKLYLNATBVmlsiVhiLIDgqY2r3QHbcCgB4IfdWpZJY4xNPHBaVBPT2yJgD38qG9Ns4QtlI9Iy1AJb6TgmqfzhCB0TvfMA4Z2Hzu7f4P9dUPcUY6XBZ0tT1FJ7uwRxWt3rxJKDgkxEbwRc2vTjo7C4NnMHyw8/ArPsZDiniBgGmlVf5Xtg5/gRlui+dkRAybWEEFr/yQ3iScIqj/9gn/fwYIt8Nqtz+7x6d/t7WX/tTBbqlBAQjSp9q2g6AYBSMkZbhIXauj4aULGdPp65QD+zt7d4KEtVGJkgyxTXvKMqxSNciXqXMmgvVcp
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(2906002)(66556008)(16576012)(38100700002)(956004)(558084003)(4326008)(2616005)(66476007)(186003)(316002)(6916009)(54906003)(26005)(86362001)(8936002)(5660300002)(6486002)(31686004)(31696002)(8676002)(36756003)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NFBNcEpjaGtGL25UY0R2Y3lpUUR3R0c2Q2dxcEs3a3RKVXpXU3ArcHE5dG9X?=
 =?utf-8?B?bllxVDNYY3FNbkxpZ0NNS2FLZ1NycmVDM2NCUWg2L1NnSGgwb1ZzVnNrZEZm?=
 =?utf-8?B?RXFCZGxIQUpDYjgycGhMcHRDZmlnQ0NtTStqc2xLbWRrNUx3THprdWNsamwx?=
 =?utf-8?B?NFBQSXlVQVNsMU9EUWJ6T2VYa0drdTVlSlNBN3hYR3JYaVN4eURpdVNCbmVX?=
 =?utf-8?B?QXBFaHN4VzJURmFSeklPS0pDMmduMkJEZDU0cnhoTVljajdQR3pJKys0Qm03?=
 =?utf-8?B?Sk0rTVJwYVA5ZDlNRmZYTGE2QlNuRFpsUFczU3Q1UHZobTJOVnQvd3FRYStU?=
 =?utf-8?B?Y0N6aVlLQUdGUklMREgrYWxwSDBtaWs5SG5nSVd2NEF0T2JzTUM0cnVZTzdl?=
 =?utf-8?B?b1RiekxnT3BSY3U4SWl1cVRVYkNvV3k2RDZEK0JwTkhZb0FIbGZnbXFybUV5?=
 =?utf-8?B?K0o5cis2NUtIL2ZtQlR6MXdPdlRKWjZCNWMyUEtVUDVJeHpEQWVGRk04eDNa?=
 =?utf-8?B?R3A0bmdWY0VCQWZoc1pOTnVrcDhIelZ3MEdTdjNXUVVoSHJkQXBPU1F1eTFp?=
 =?utf-8?B?R2VwVCtZZWxrMGRFaGxjbThMaTRBbjI2S0FkWVA3SUdpL3FhNUl6cUlCbjNP?=
 =?utf-8?B?dXkzZURFbU1HbzRhd1l0bVhmMTVMQ2ZPRnJGcjk4V3lmaC9IbUZkekp2aSs4?=
 =?utf-8?B?WjZFd2NEdW1RaDY4dnZ0MWE2Z2lwWDZQVlRGZE0ySGRTVnJ4VnU5KzBzb2Jw?=
 =?utf-8?B?dUw3b3dFT1hRZGpnYS9mbm5ndjVWOTE5TVFVUVFFVGNrV3RvRDQzaVFMN2ho?=
 =?utf-8?B?Ujl1WTZIME5KSDhpV0YzVTQxTTlmYk04TzZEaTZ0M2h1Y0pHY3gxaFNrUkRt?=
 =?utf-8?B?RFVWTzFSd0pyZGVhcEVCRFdFNTFrN0hRZGljcTJnRXAzeFJJRGdvYkhudlF4?=
 =?utf-8?B?ancva1Fnc0RoQnFyeFF4VjJSenQ5NHlReHEwNExGY2ltOVg3bzhkZ09QNmx3?=
 =?utf-8?B?THVkVnhvVUpOVlFzcjlYTTFUUVk2RDR3K1dXSVBuQkEwa1NxcWliTnBJQWVX?=
 =?utf-8?B?aTZMblp4S2lKOHQ3dnpucVRNbGJVZ1c1b3NTQ0xORGdqUlRraS9uR3gvYStt?=
 =?utf-8?B?dzU1NEw2azFQZEVZcWFSd3FGR0dYVTFjTnVBekU3NXQwVmxmODNrbjlQeVpG?=
 =?utf-8?B?bUp1cGFBLytxeUg5alJSWjVmM1BNTDRUVEp0T2dtdmZtM01JdHRyVmNtS2JG?=
 =?utf-8?B?OFB5SGFLaFRLLzE3Rll0V2NwWDNrV2V2S2lmRlg5RXdmSnJlaTh1dTNPK3Rm?=
 =?utf-8?B?VXRqR0h0UUJndmZ3U1pxc0FGRmYzME9nbEUwbHplKzV1N2Z6d3ZPejZtUlJn?=
 =?utf-8?B?YkM2TmlRTnFoYUllK0NWWlJQMW9NWFNrUWJpYU5yNzFUaTlXcFRIYjBCNTQw?=
 =?utf-8?B?cTJCTlZlU296MVE4bU1Ib1hkMGloOEJyQXRRSFl5WUZSdG5wcWI2OEVFV3NT?=
 =?utf-8?B?dDRwWVhGemc1ZTVJSVIzT1A0bWM4SHlFMXFsNkRMU2FCMWh0Tml2R3JGb29M?=
 =?utf-8?B?VHVuNVVwM0N2aUV0SitGMTBwTnBESHlWQ2R5Uncvcm5NKzVPeTlXTEN0RVVs?=
 =?utf-8?B?R0dYbUZnNTB6QTRZWCtaYkdLQ29Kb1NhYkJrd1VreXE2elIvK2dNS2daZnFG?=
 =?utf-8?B?M3JyZm9uclo1L1d0d0JUSVh0YlgxY0xXU1IwWVFuOVlWYkNMMGFEWFFtSFF2?=
 =?utf-8?B?WU9iWTRUUVpyZmpQL3ZkNTdrbGlrSmdIUmdMTDZtRDRMcmYvRzU5eWRvUmh2?=
 =?utf-8?B?T1hIZWdRSGRUUnhsakkyTHRBNFpENzFYRmlnbVpLRlk3YkdKMGwzeFdrTnRT?=
 =?utf-8?B?VlorcjRBV0k4dFkrOTlmVm9SZlpwcTEwRnd1NmRidDNXU0o4ZnpOYUs2dk5w?=
 =?utf-8?B?QkpCWmtMdCtwU2dONnpvQVNOS1dtRTFjMTJhZjlkNW5Xd1BMTWRIZkM2WUdu?=
 =?utf-8?B?WWg3dytqZTM2U252QXNkbW5rQVVDUkJnM0xueHJtZ21OV1E0RlRkVVpSeEp2?=
 =?utf-8?B?RFB1VUxvMUVYcVk0OHFaZEZRR3RraithQzNvU2tuUWJqeEpacVFyekxqeWxJ?=
 =?utf-8?B?Vlh3QzlLczdKYklWcVRFRVluOGhZeVNIZzhwcWtlL1F2L2h4NmlWeWZwOGlq?=
 =?utf-8?Q?i/X3dIJo91SnXCJhZ609yFQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e478e195-f1d5-4fec-0864-08d9b64eb3dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:18:59.2800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RPPU46BWFVpF+KxJunLHathyZ7sSU9VcrPDGwJLjdqjOMucytfQGp2gqup7pE0n6gy9Phu+O5TXC7J/koikyRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5471

Two fixes and some tidying.

1: HVM: permit CLFLUSH{,OPT} on execute-only code segments
2: HVM: fail virt-to-linear conversion for insn fetches from non-code segments
3: emul: drop "seg" parameter from insn_fetch() hook

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:20:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:20:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237374.411704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6c1-0005dp-SL; Fri, 03 Dec 2021 11:20:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237374.411704; Fri, 03 Dec 2021 11:20:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6c1-0005di-P2; Fri, 03 Dec 2021 11:20:21 +0000
Received: by outflank-mailman (input) for mailman id 237374;
 Fri, 03 Dec 2021 11:20:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mRw7=QU=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mt6c0-0004uM-K4
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:20:20 +0000
Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com
 [2607:f8b0:4864:20::633])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ff219311-542a-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:20:19 +0100 (CET)
Received: by mail-pl1-x633.google.com with SMTP id u11so1886437plf.3
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 03:20:19 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 q32sm2126609pja.4.2021.12.03.03.20.06
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 03:20:17 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff219311-542a-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=7XsAJ2cZU1lppUyPBmVsEbXy/GKDAj/Ht+i8uHD7lok=;
        b=fQI0WyY3dvLwdv22bT+tWb115e4Q95jD6vrbYcmPVcwOyogr9umcIO0a/KZzkZF0rU
         qjv+YjbgPRKUi57eJSOspJ/nc9Xx0y6B+ShA6u79dQDpjAliXRhyzyFFhlcxT7Mkch1K
         q1Htr6xBNQmACCzFHpqEJQ4IFR5KLc5Up09f0yDbrMAL2dGNIoDCk2kVY9vf7H/OqfTF
         vj7WVjaYIRG9InmQYKKZoLEcnyr9fnCfLZMJ00mCUyXKJGM6wmAKtV6BkqeDbPJtqzHZ
         wVggDDSxJtPp+HclUV3H9xLVWitco7xUeWkf/kzzWR666KG5ZxHBXQifzIXarMd5G5hy
         YahQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=7XsAJ2cZU1lppUyPBmVsEbXy/GKDAj/Ht+i8uHD7lok=;
        b=nKh4d2dPqY6Gem9IxtGc77jqQOWFwnbRRI+7LrKzSNlQ910FmA5Yq2HqWP48oocpjc
         ltQitOknXZrZ4oYMlKbQ+v4fjlDXRTiZEf8GRxNjNvqPEjTQ52pNJZSc29Ib9q35wYLm
         amhQPenVx+Lx0pkrE4npY4eANufR6GeIJL7P3j7CBXrKz8jXfsw7LKh32aVuu8SdrbGP
         iUROsBJOt58SEuqCGJBTYrTPsvs/kUga+OAREuY/E+uqHrNMWZIilFSoq1ErcWXZhe+r
         T8T2OfwD0B/ysR1lObwjglWwYoa/z/iXYD2FybxsSSZeAKZq12QPuuBypQ/KaqHnzn7f
         v1+g==
X-Gm-Message-State: AOAM532IMviLB/EDdREJSlXPzYQxvSMIoIrlcGn03jTHZ2lPsn8sjfra
	Smy92c2+O9ceQ/U5Rfa6TBQ=
X-Google-Smtp-Source: ABdhPJwyiDbpHGaLzHTehq+eMK96rnMASx0J/gnS2CYK1pGpGeM2FntwySwLQ6ehw5HLLx+8am9Xvw==
X-Received: by 2002:a17:90b:3447:: with SMTP id lj7mr13390043pjb.112.1638530418013;
        Fri, 03 Dec 2021 03:20:18 -0800 (PST)
Message-ID: <e78ba239-2dad-d48f-671e-f76a943052f1@gmail.com>
Date: Fri, 3 Dec 2021 19:20:04 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
Content-Language: en-US
To: Tom Lendacky <thomas.lendacky@amd.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-2-ltykernel@gmail.com>
 <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit



On 12/2/2021 10:42 PM, Tom Lendacky wrote:
> On 12/1/21 10:02 AM, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>
>> In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
>> extra address space which is above shared_gpa_boundary (E.G 39 bit
>> address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
>> physical address will be original physical address + shared_gpa_boundary.
>> The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
>> memory(vTOM). Memory addresses below vTOM are automatically treated as
>> private while memory above vTOM is treated as shared.
>>
>> Expose swiotlb_unencrypted_base for platforms to set unencrypted
>> memory base offset and platform calls swiotlb_update_mem_attributes()
>> to remap swiotlb mem to unencrypted address space. memremap() can
>> not be called in the early stage and so put remapping code into
>> swiotlb_update_mem_attributes(). Store remap address and use it to copy
>> data from/to swiotlb bounce buffer.
>>
>> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
> 
> This patch results in the following stack trace during a bare-metal boot
> on my EPYC system with SME active (e.g. mem_encrypt=on):
> 
> [    0.123932] BUG: Bad page state in process swapper  pfn:108001
> [    0.123942] page:(____ptrval____) refcount:0 mapcount:-128 
> mapping:0000000000000000 index:0x0 pfn:0x108001
> [    0.123946] flags: 0x17ffffc0000000(node=0|zone=2|lastcpupid=0x1fffff)
> [    0.123952] raw: 0017ffffc0000000 ffff88904f2d5e80 ffff88904f2d5e80 
> 0000000000000000
> [    0.123954] raw: 0000000000000000 0000000000000000 00000000ffffff7f 
> 0000000000000000
> [    0.123955] page dumped because: nonzero mapcount
> [    0.123957] Modules linked in:
> [    0.123961] CPU: 0 PID: 0 Comm: swapper Not tainted 
> 5.16.0-rc3-sos-custom #2
> [    0.123964] Hardware name: AMD Corporation
> [    0.123967] Call Trace:
> [    0.123971]  <TASK>
> [    0.123975]  dump_stack_lvl+0x48/0x5e
> [    0.123985]  bad_page.cold+0x65/0x96
> [    0.123990]  __free_pages_ok+0x3a8/0x410
> [    0.123996]  memblock_free_all+0x171/0x1dc
> [    0.124005]  mem_init+0x1f/0x14b
> [    0.124011]  start_kernel+0x3b5/0x6a1
> [    0.124016]  secondary_startup_64_no_verify+0xb0/0xbb
> [    0.124022]  </TASK>
> 
> I see ~40 of these traces, each for different pfns.
> 
> Thanks,
> Tom

Hi Tom:
       Thanks for your test. Could you help to test the following patch 
and check whether it can fix the issue.


diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 569272871375..f6c3638255d5 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
   * @end:       The end address of the swiotlb memory pool. Used to do 
a quick
   *             range check to see if the memory was in fact allocated 
by this
   *             API.
+ * @vaddr:     The vaddr of the swiotlb memory pool. The swiotlb memory 
pool
+ *             may be remapped in the memory encrypted case and store 
virtual
+ *             address for bounce buffer operation.
   * @nslabs:    The number of IO TLB blocks (in groups of 64) between 
@start and
   *             @end. For default swiotlb, this is command line 
adjustable via
   *             setup_io_tlb_npages.
@@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
  struct io_tlb_mem {
         phys_addr_t start;
         phys_addr_t end;
+       void *vaddr;
         unsigned long nslabs;
         unsigned long used;
         unsigned int index;
@@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct 
device *dev)
  }
  #endif /* CONFIG_DMA_RESTRICTED_POOL */

+extern phys_addr_t swiotlb_unencrypted_base;
+
  #endif /* __LINUX_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 8e840fbbed7c..34e6ade4f73c 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -50,6 +50,7 @@
  #include <asm/io.h>
  #include <asm/dma.h>

+#include <linux/io.h>
  #include <linux/init.h>
  #include <linux/memblock.h>
  #include <linux/iommu-helper.h>
@@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;

  struct io_tlb_mem io_tlb_default_mem;

+phys_addr_t swiotlb_unencrypted_base;
+
  /*
   * Max segment that we can provide which (if pages are contingous) will
   * not be bounced (unless SWIOTLB_FORCE is set).
@@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
         return DIV_ROUND_UP(val, IO_TLB_SIZE);
  }

+/*
+ * Remap swioltb memory in the unencrypted physical address space
+ * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
+ * Isolation VMs).
+ */
+void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
+{
+       void *vaddr = NULL;
+
+       if (swiotlb_unencrypted_base) {
+               phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
+
+               vaddr = memremap(paddr, bytes, MEMREMAP_WB);
+               if (!vaddr)
+                       pr_err("Failed to map the unencrypted memory 
%llx size %lx.\n",
+                              paddr, bytes);
+       }
+
+       return vaddr;
+}
+
  /*
   * Early SWIOTLB allocation may be too early to allow an architecture to
   * perform the desired operations.  This function allows the 
architecture to
@@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
         vaddr = phys_to_virt(mem->start);
         bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
         set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
-       memset(vaddr, 0, bytes);
+
+       mem->vaddr = swiotlb_mem_remap(mem, bytes);
+       if (!mem->vaddr)
+               mem->vaddr = vaddr;
+
+       memset(mem->vaddr, 0, bytes);
  }

  static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, 
phys_addr_t start,
@@ -196,7 +225,17 @@ static void swiotlb_init_io_tlb_mem(struct 
io_tlb_mem *mem, phys_addr_t start,
                 mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
                 mem->slots[i].alloc_size = 0;
         }
+
+       /*
+        * If swiotlb_unencrypted_base is set, the bounce buffer memory will
+        * be remapped and cleared in swiotlb_update_mem_attributes.
+        */
+       if (swiotlb_unencrypted_base)
+               return;
+
         memset(vaddr, 0, bytes);
+       mem->vaddr = vaddr;
+       return;
  }

  int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int 
verbose)
@@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, 
phys_addr_t tlb_addr, size_t size
         phys_addr_t orig_addr = mem->slots[index].orig_addr;
         size_t alloc_size = mem->slots[index].alloc_size;
         unsigned long pfn = PFN_DOWN(orig_addr);
-       unsigned char *vaddr = phys_to_virt(tlb_addr);
+       unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
         unsigned int tlb_offset, orig_addr_offset;

         if (orig_addr == INVALID_PHYS_ADDR)


Thanks.



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:21:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:21:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237380.411716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6ct-0006DM-4o; Fri, 03 Dec 2021 11:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237380.411716; Fri, 03 Dec 2021 11:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6ct-0006DF-1p; Fri, 03 Dec 2021 11:21:15 +0000
Received: by outflank-mailman (input) for mailman id 237380;
 Fri, 03 Dec 2021 11:21:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt6cr-00064Q-AJ
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:21:13 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e87694b-542b-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 12:21:12 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50926)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt6ce-000gSe-if (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 11:21:00 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 8BE491FB51;
 Fri,  3 Dec 2021 11:21:00 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e87694b-542b-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
Date: Fri, 3 Dec 2021 11:21:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 10:56, Jan Beulich wrote:
> When it was introduced, it was imo placed way too high up, making it
> necessary to forward-declare way too many static functions. Move it down
> together with
> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>   immediately ahead of the #include,
> - blexit(), because of its use of the efi_arch_blexit() hook.
> Move up get_value() and set_color() to before the inclusion so their
> forward declarations can also be zapped.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Why does blexit() need moving?  It isn't static, and has a real
prototype in efi.h

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:22:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:22:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237387.411727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6dg-0006oc-Eq; Fri, 03 Dec 2021 11:22:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237387.411727; Fri, 03 Dec 2021 11:22:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6dg-0006oV-Bl; Fri, 03 Dec 2021 11:22:04 +0000
Received: by outflank-mailman (input) for mailman id 237387;
 Fri, 03 Dec 2021 11:22:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6de-0004uM-Rb
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:22:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3cb877d8-542b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:22:02 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-HKHCOk5sOmiL2Ao6kdds0w-1; Fri, 03 Dec 2021 12:22:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4445.eurprd04.prod.outlook.com (2603:10a6:803:6e::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 11:21:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:21:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0036.eurprd06.prod.outlook.com (2603:10a6:203:68::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 11:21:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3cb877d8-542b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638530522;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=arRBtooexp9YOjjgqZoKeIru/O8fhzNxUbCM5wJ1rzw=;
	b=N7x5oDJr0BbTq2qmFjOT9adogWbl480WUsVcIDNS32aT1KkuTghMeY/WuFYTdqSpDvddNy
	+PlJCMwE7qYPAyNCDYo0AGkT31Y6ghrioe7uqpV2JNlCdhUyaM7cpCmNch+d/3XUt4Glwa
	JSq7xdTwnNg9lNvoc+t7+MvFeqJ5lvQ=
X-MC-Unique: HKHCOk5sOmiL2Ao6kdds0w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M3u9qxZX1/15FAaZnOpL6ftR3cjZr4impl4oZp0v1Shh6zLhJ0nusdRwWNv8y//7UAluG6IO1PLJAFJG+ZHTsAHDKneyOU0NmAeJO6dgh84M39yBNccMBb8gTxjwXb4N/TfE8+5vYB1I+wUg2zj3vitScKmDFr37wwqIhtCisjKPu6u19m1Vf1NO1TF7Iu3Q6m9RrrCqYwLendwTkAXWq2SfmyAAooP+kip78+VaAhrONlUlpbxxJfBScnC1VZBXoI8HMNhZPaHUAxrs+0mXIVHS6cYJcfJCGWezgc5onGByiiyzcIrGsuj26zsmkw//TB9DdO51GWyOjxF8MyrM4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=arRBtooexp9YOjjgqZoKeIru/O8fhzNxUbCM5wJ1rzw=;
 b=PJpRwChpTLtbaGVRVhxiOkVfMMYAiPG/xwWEODn5RtHzyltTLgilDUwz/3cKceFT7bkU9Er5B4kXfzM3cSKpo7ziiHfkLDPTp8LIBCMip1jXepKVboAILkJqLCFEwR/lKUraX6x9hi91wgj8fiMgxT7HssNAGl+mu7uN6/tkpRAnfxbIePhi/Gmw79aEZy7iJ07D7a6w2NlOblBvnS24b7wEd4CM3VnskY0Zi3OUu5oEc3QnXU75i7cYaJ+n0Gcezq9NSGc1Zm4pkR/NDOdd0c28Qi1dz+/Is9f2f4Oedh+QscWZoofHtLOjx9BM4Q9EpeB74jhe95zA1Wili/uYWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
Date: Fri, 3 Dec 2021 12:21:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/3] x86/HVM: permit CLFLUSH{,OPT} on execute-only code
 segments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
In-Reply-To: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0036.eurprd06.prod.outlook.com
 (2603:10a6:203:68::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7eaf728d-1c75-42ac-e841-08d9b64f1edd
X-MS-TrafficTypeDiagnostic: VI1PR04MB4445:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB44458CD6FB9532383F848EEEB36A9@VI1PR04MB4445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vOEJQI8gX8RyoTV+1b1tZto/ooLZGlVBaYkpzZOb+HWwX6DqOzDXuC+Mqaoij6K3PP1Dx+P09i/R2tOiLTnT47xpHnwCX6We7kwbQ1hjZV/3Dh504GJC+oZV/OZAmmyvyfklpZUu4aY7XQolpZt5k5zOd1Yych38dAZQ/+hz1GC8R76n0N57hzoVAsHSPaoUKk0i1nw3Q4dz/j0zLkxjx0Eo2hqTRpw/l3Vn7FHv/S0lZMHzJLKjbSAKtOQWwM2VQkIi1PWEsaH1RZ9KIM5hfnsyFveztIbCsbS/czBwNn1nqMNg1ou49RMXAn0VayYIfDjmb5D0xxMiPlVGmPgwW1ZVQYlVsqkjmjaTD25bOrXZAl4PzyyVIKQQaXYw97XZFcf7mGLfXn0I9if+8VsgScGo1Il3UpS2ijdKwYuCr92Ne6uD/+iyPGnRTvPnOM2ta34Sl7cRVW0XywvnScZ85j1VDIUe2crpTlbguAXZaiQzuRfvB1u1PGk4KmDToYQ/mjrMlZQIXgVzJBN+7xEKhOTZI4Pucjqmwt018um6F9o8UQVEzfRcnit64KjMMrAbwGuMviA3HDVlXmyE2CC47EzGoxTJ4NHlr557Yizciykci2ChYw/Ok42CO3GZXFUmOA5unQTjJ5O4KZNVbuYCS1n0TRK6e+hKV9zFEtxdGYFBX/afoBjoyGs+TABt9cJIt5MLzuMFsDM0tBu6TxuHUAgxYEoTt/8wEHYs/pU597o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(36756003)(2616005)(31696002)(31686004)(86362001)(316002)(2906002)(66946007)(26005)(8676002)(6916009)(66476007)(66556008)(83380400001)(956004)(5660300002)(6486002)(16576012)(186003)(8936002)(54906003)(4744005)(4326008)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z1R6REVObUVwbUw0RGlKSHVONmE3dWpCbUJaMC8yRk82WllMdFZhbm9OSEQw?=
 =?utf-8?B?SUFJZGRScVRiTlVQdFo3Sk1QUFBBeFFNOGh2dFlpWW8weU5wQVNxTEgvenRs?=
 =?utf-8?B?V1YyNVIyY3Bhc2lvSVQ1UEZIRVZOcnBlTlVFbFBweG5iTldGeHJWc1VGYi85?=
 =?utf-8?B?bXZPaW9qdWlMVXRnOE93Qk9Da3pZL1d0ZDFyTVlkZ25sVVE1NHlUVys5UExs?=
 =?utf-8?B?S0QyRkpqL0pKeXhmajNDL21iaEtTTU1UcXZyUVUvNktaY2ZTU1ZBVndwRm5U?=
 =?utf-8?B?WVlXeXNzVHZsUEt5Wm9NN05DYTR2djl1ZjdSL1FXVUcxcTlIMkJOdjFvL1pl?=
 =?utf-8?B?Q0ZGWXBVaFFwU3NJOGxtdmJKQmJTNmQxeHRGcHZnaUpPL1BoUzRWNEo0THN1?=
 =?utf-8?B?ei9pMjFuNUdJZXJUemhxVWRGdjREdktPYjlhWjFQRCtuMDcvcHBqanN2dEV5?=
 =?utf-8?B?cnZaSEJQOHNVUTdmWlRpOFB5Q21HdTZpYzVqajlMdEtlRDFLdFgycE5oTnAv?=
 =?utf-8?B?UTNsMnQ2cGoxMmhnMlZ0VjFlczZsNjh4aXE4S2VaOE9ubHRnc1RreTlsWkky?=
 =?utf-8?B?Rld5WnZQdTY4S2ZYZFZJVVQ5TmxpSDNTc3NLVGdaa1FXdnNlYnE3clljeG9W?=
 =?utf-8?B?RnJuUGZxbjdFZDVrOUMwa05UZnI0WEJPR0FtSkpnclZ4bGVtT3A2RGtuUjgr?=
 =?utf-8?B?YU92Q2p1WGRvcGI2UDFrd1d1dGJiVzV5UWROUnZrQUpGU1VlbTNaemxuL2lB?=
 =?utf-8?B?QWIwazZFUnJiOEFXLzdacEpQNUFubUhkRmV1OUNqUGFEVmJ1a3ZDcU94WmRT?=
 =?utf-8?B?SllYR0Z4bWhHcVdDUm9hRzEwZXNveFV6NkMxS0d1NEhxRjI1dXczeU1DZGpM?=
 =?utf-8?B?UnVLSndkUXU4OGdoeW11WGJidlIvQVBqbkorRmhudXgvT0dBS245b3J0TmdJ?=
 =?utf-8?B?S1BQN3B4c1pVV3lWcXFYTXNnQjBNOFMrbU04UzArR21MWFVrT3I0L0xIRWVG?=
 =?utf-8?B?K2FEU1RzMUpqTGVvM3pCSmhwU1BSTVRrSC95NmZwQWR1ZXlXU3BWdU1VbXdL?=
 =?utf-8?B?UGlGaDZrS3hPV1p2dThDclcxYUFYN3R3dGFWTFloemxpRHUreFJ0d1JyUU1t?=
 =?utf-8?B?R0lIeXE4T244K0phT25QdHpoNGM2bHVOOVNmaGQ3bFQ5K21ndEphMkF1TFg2?=
 =?utf-8?B?bmE0MTFZU0Nud3pmZjhMVlVlOWhEWm5LdkM5d1Y5c3RicHBPNHpyRzlHa29O?=
 =?utf-8?B?RFlmb0VUcXgyWklVN2ZQYXo3NjdhNVpYNHpEU1NIUllhVDRtWnpnNlUySTZx?=
 =?utf-8?B?emtQN05mLy9YZUwvNEtpNk4yVWtjK2Q3UzhvRGg0cW5Bc2JmS3hwZW11b0hH?=
 =?utf-8?B?cnFVVU9BOExJSVRkSEI5bjF1b3FTei9qcUpEVTF5eGc0eDVUd3ZCaWFJNk5l?=
 =?utf-8?B?Nk82Z0VpWFBjNUgxdmJoMVRucWdHMEZBTVFKMExoT3lRSXJvdEpqc3AyaTd6?=
 =?utf-8?B?T3NUN3gwM0JZRkh5dFJpamhvcFovaFBYNWIybFR0MmpwOC9kVitsdVJrRnFS?=
 =?utf-8?B?QkIzS2JCK0oxb1dSN1NHRytoRVVibmJqbXZyVXhlT08yaXRxVkI4dnovZzY5?=
 =?utf-8?B?UXFPcy9KcW9qUG5neFVJd1poSDNHWDNySUhYRzAxRno1dExPNjN3WlIvMSs3?=
 =?utf-8?B?cExGMGIrb3hkYTMvVU9wWDhBRGpmb2F2Nmh4dUhMUEdIT1krWlZPQ1lSV3pi?=
 =?utf-8?B?cS90RGtva3dzOG1HVUxNZ1hVaENnNmprR3BDdUxFUGxlNGNaN1A0a0V3V2Mx?=
 =?utf-8?B?dHc3NFlIVi95SlRBMmdmQ2JXRGFkTFpkV1ZndlF3Vkc0ci9TVGRLRVpaTGRs?=
 =?utf-8?B?eUFhNmxacUd3V2RhR3VkLzdKRVJ1eWxFbzdUb0VObDM4bEpzRmFjMmNaRnNw?=
 =?utf-8?B?ZGlTeVExWU1YS2VaSlEvQjdscVo0MmdJdk5saW1YSmFhZlN3dEkzYTQ3Zk9K?=
 =?utf-8?B?Sk5ETlU5NkU3Wm8vTW5kbldkSHpBUkJ3MW1MY3lWMnlBblFjSW45V1JJQ0Zl?=
 =?utf-8?B?bjJIWTRYa2tZTVp1K2liN0cxWU5YQ3VKcS9CeGZYM3FWWTZ0N2dkY1dKQ2NR?=
 =?utf-8?B?SGRIM3ZiMHFyVzIvWUQxQTJkQ215WHJQcHFWYjIrQzhyZXlHY1FWeTllNjk0?=
 =?utf-8?Q?7cfFduXUYwLgPt0TZmZ/Q58=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7eaf728d-1c75-42ac-e841-08d9b64f1edd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:21:58.7586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SoBAdIdZsXYsggmIPA6er2t1pzT18kG0wsqxbNigUhF5IjGLVHHQjkh3/8y4h5nNUty86KdeUd5U3H0botH4Tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4445

The SDM explicitly permits this, and since that's sensible behavior
don't special case AMD (where the PM doesn't explicitly say so).

Fixes: 52dba7bd0b36 ("x86emul: generalize wbinvd() hook")
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -2310,7 +2310,9 @@ static int hvmemul_cache_op(
         ASSERT(!is_x86_system_segment(seg));
 
         rc = hvmemul_virtual_to_linear(seg, offset, 0, NULL,
-                                       hvm_access_read, hvmemul_ctxt, &addr);
+                                       op != x86emul_clwb ? hvm_access_none
+                                                          : hvm_access_read,
+                                       hvmemul_ctxt, &addr);
         if ( rc != X86EMUL_OKAY )
             break;
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:22:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:22:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237393.411738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6eI-0007ST-Uh; Fri, 03 Dec 2021 11:22:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237393.411738; Fri, 03 Dec 2021 11:22:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6eI-0007SM-QO; Fri, 03 Dec 2021 11:22:42 +0000
Received: by outflank-mailman (input) for mailman id 237393;
 Fri, 03 Dec 2021 11:22:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6eI-0004uM-2A
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:22:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54123a22-542b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:22:41 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-ie8y1T6FPRyK7F5eBeHQEA-1; Fri, 03 Dec 2021 12:22:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4445.eurprd04.prod.outlook.com (2603:10a6:803:6e::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 11:22:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:22:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0040.eurprd06.prod.outlook.com (2603:10a6:203:68::26) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 11:22:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54123a22-542b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638530561;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=x2S2aIcZK036FRm3DGzFftaBrE1z/LAoM88V/xmz2FM=;
	b=RCKXidmQLxXaJpR8Mlb4/uaa0ofauD81orBlL1XRYkkZLYAlTxTSGMg6NCLw3v4PrvLV/w
	fmLuPbZuUnXQ2fxilY1ocR0o/NPtaEaOLHwIPZ7BRxYzgjlZMcXKRDzhyn/g80mzq4BHR+
	o/n+9PyasjDXWAtjkpFzzV2mIi/7tfU=
X-MC-Unique: ie8y1T6FPRyK7F5eBeHQEA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RPAp4KGTOd3ZP8ae8K5FEFuhs4c+qOLiFRnj6UpE0ko2IiXI3fwCOOpWv721KpGw2QN9iaRI5aEYF6nDjLfzEj6ETJq7UqAzF7ymKQmr27aOATz951vVJ0TFGIfWntOrvnry2DNfQjd9LuIrKvsJoVcXlT8ja9YANAdQhN1WD5lOWsQPTHoDjGPfE6tDyx7KN2KTnOWlSa8DrHA3MZZIipd1KQDFcQMF/3xWweIE6H44wWp8Buj0nGkcDFWOuV0bFVOJHNENeLWwrscWeZJtdgmTTdAXsyh/lze6F2AuFVKucvhdZpP45qDYxF1l3PgbKPkQm7q1Q+o5KoXZwKW2uA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x2S2aIcZK036FRm3DGzFftaBrE1z/LAoM88V/xmz2FM=;
 b=XzRPudmb5wm+F4jIINIOPj4ylUibqYHhJsV2iN2o+q6XBumCHOvFF6BxUx7pgyELeGcAVUUEsLtSENGaDLkUcU9OQ/YhGoJhCJijqrzEwMpGaWsaALBZrjmDwQ/xn5bBFmLhTQQ2DLRF5mxF1vYY6I7ff9wOsBAFU31HMy4OAPnApvM/hYwtTzKj7+8mkRElWCnvfcjbrqEArMHWdF5mXqL+0d4EjAYCmG4Zs/8Rj6SDbzGBinbbTR0pR+sBLaKg+cLdkUKMj9T7k4NdLKQakFrC/vYTtVneMBBXXSJMtmrB7h098gd2iv+Ve33aMJj+w6prvnvZev8hw2Grf+UYog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <46fdafdd-d6a9-778b-d634-fad8d2f6925a@suse.com>
Date: Fri, 3 Dec 2021 12:22:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/3] x86/HVM: fail virt-to-linear conversion for insn fetches
 from non-code segments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
In-Reply-To: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0601CA0040.eurprd06.prod.outlook.com
 (2603:10a6:203:68::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1eeba3b1-3dd4-4290-dfc6-08d9b64f36ab
X-MS-TrafficTypeDiagnostic: VI1PR04MB4445:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4445AAA539922031B56B95C4B36A9@VI1PR04MB4445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Nc8rk46xWop+QM98H9mxOX+W3dnrS78Hn4IFA6yqE0oRUNSU92PJFgUHoymGbAcZDwJDjFBnEquAiskjI5R/kYa0h/Wv4ZIsN0pLo1+gVTaB0Huc1JAcjGHCKK0yodG/SdLpe+dPjn4iGbvQViYHn0sv5yMEaRFfYQ0hxGXWb/csaCpo4VmZ4SZl4QeZryrvDlxsxYFiAEw7UBz68Vve3OiZVeWnysHdLsfHFQAYo3BaBUpYYP7mEPz7jNO0ORUx9cUfqRWkcpx7IYocHwSUhOBELeRLQf3m/SXIBCQBlS0iBntZ7ad1yuTdUa9YCUm7IFNK9ZjMjxDQKtMdaBvugLul6yCbw6IO+ZibIxvYXGXHDqPoVNQxmg+gMI0dMOT63+iJwLLb+F9rIpYgnxfDIRFolVL+aZ1oN5d7WIP/BSvT4x+4tVpFLZcjYr5VYtXn7e8i5/aNPGRZHrB33JYUaGCXFSTeiLPYK3yyc9PPQqyPJ6dtv1YB4BW0soeRs0UP03QdfBMc+uKxFql9vM6NH7jFDOi5DInvQRBMR7WZ2UQJiMpADv0OAsGquIcbnGHKcgxxWzXk9Y2j1ebIHwLGgHM96YIe0G3tUHVV1LHpoCJOwBMeW9T98qn0RaaWlCio2szqW6fgXPQrINO0eUcw+4R67aPgTCQuhV6dzzQsbnqIG101C4v1Xd1UOyK2M4UCZ4XBtMiYUPiVdezXiwCJGF1j0pX3ObhIaDSV/0Ai3c4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(36756003)(2616005)(31696002)(31686004)(86362001)(316002)(2906002)(66946007)(26005)(8676002)(6916009)(66476007)(66556008)(83380400001)(956004)(5660300002)(6486002)(16576012)(186003)(8936002)(54906003)(4744005)(4326008)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QXF2VENsaWpHK21pZTNINlhRbC9KcmFKNks4bHNJTGlFWGNBWUp1YWMrZnRu?=
 =?utf-8?B?Mjc5R1BXMGNlVHNXNnF0YjNUOTkrVTBWanpxaXUwUXV1cHZ4MS9pQWdNV1lX?=
 =?utf-8?B?Smx0QzhROGxuVEhXeE5tcmRGeDYrOE14Smx0Y2hEVEtwTDd1bVowbDNqV1kr?=
 =?utf-8?B?dDJ6Ym1FRlc3bWc2TWhscVlPdzRsYVlySXBWM3RWdG9meXVmQVU4eXkwRW5E?=
 =?utf-8?B?OGlaWnlxbXdhLzR4bUdaRU1nZGxsK3VTekprOFkzVlRocFRYSVJ4dm01Nk4x?=
 =?utf-8?B?RjBZN21WRzIwdUZXWklmRFkzcFlvYXRrT3V6dmIvRFM4RVZWOEd1VVlkSXdU?=
 =?utf-8?B?ekc3OXh6Q3lxY1BiSjV0K1NRQzZxUkI5OGxXOGV3SmhhNlcyOGc4SkVyV0o2?=
 =?utf-8?B?b2Z3MXpKMW1KdWpMdDlud2pWRktGREdLVFE2K2J1cUdkNElsVktCR3pMSzJ4?=
 =?utf-8?B?NDdQWVJGdk1xMmFKNFgvTmNHTGJhZVVtQzdWZUJVTnM2TnJRQkpldXVPd0NX?=
 =?utf-8?B?d29TbU00OEdYZE5WMEtISkJEOFJjTG9IdEUwTWxhRnNVcDRYbHd6bVYzSnJm?=
 =?utf-8?B?Q3dBTFZBdHQ0QVBLNHFLL0lJZ215V2tLcUkzclp5M202bXpzRmR1RmZSTlp5?=
 =?utf-8?B?VERBdXhUc1owL3JBM2FKdFd5a3JTdTNQM2dldlBsT3FkTGFvckFtUkV6Zzc3?=
 =?utf-8?B?SHB0Qmh3SU4rdW1WQ2gzT1pCQ25DVlZlWkV5Rks1QnBWQTFSR2NmektSOHZa?=
 =?utf-8?B?NTBZcjNRaWZIRlVjc20rVGM1QW0wNHhjTEtNV053VEMzYzIrdUIzYzhiUXQ5?=
 =?utf-8?B?MlFHZXozS01pTHQwWHZ1NWh5aXFOVkFUcUNHbnZGaUpHSDNTSFo2SkFxd1hl?=
 =?utf-8?B?RUlaZGJqUitvc0tpNHZBNW5nbFFacUVSWk0rOVcrR0o5S0lDeWxNcEJXNTVl?=
 =?utf-8?B?bnorQWpzYitzd0FDVFg5M0pybHRmbVRCcUhXVU5TUjcybnN0VXhIVDZFMGVr?=
 =?utf-8?B?Ry90RjJvNllvVGFvSDFSMHNxWEFNK0p1ZDdoc3lRMS8zRnFWdTB2WWx0a2pH?=
 =?utf-8?B?M0ZXZXRma1FhR2w0bFZlbnJCU1U1WWZ0VFNiV3RQTVp6NzJOOTdOU2cvci9u?=
 =?utf-8?B?WERvUjJiMjVDOG11OFAyeit4N0c0d2NWMERyZkJSb3FoSEE3M01oaktzZ21u?=
 =?utf-8?B?b0grMnNtbm8yVE1ERmhOMFd5bHhWb3hLSytFVVRwc0kzSkd0enhsL2tqSE5q?=
 =?utf-8?B?OEFNSDNlUHlMUkdEVDdadFFrQzFJVEtOdk9IbjVSY3UvcjlwT0lPYUhKRmVx?=
 =?utf-8?B?TjM2TEhmSUJzMm1FMTdwb1VuRkY0c2RzZHhLZ2VIaWlEdEsxU3Y1VFhQUU83?=
 =?utf-8?B?MjNlS3RoSXdCNmFZNXRrN0U1cUVCYU9udVd6U1JNNDBqOWRrSUd5aGhYRjV2?=
 =?utf-8?B?dElraThiQVMwL2xvSU1NQlFPZDhVKzI4L2Zoek8wN2tPWlVMU2RvdlpaTDYw?=
 =?utf-8?B?M0dOZG44Qjl4R2NQaXd3RnVRY25NUGMrM2NoZXQrelZGODhhRnI0L1NJTWd3?=
 =?utf-8?B?eW52R2lIeVVrSU12c0c5V09YU01haTVNdWFGVzNEMzRwVlB1S1B6RlhKZlk5?=
 =?utf-8?B?SlRvVUlNbmlrVjRPdXBZMHFqd0NtZ0ZZczE1NVQvVi84MkdMWUVObXV1aUln?=
 =?utf-8?B?ZFFHR0RlVzZUY2VWS2JiWmprcWpQcGxZWlRqbm91ZmowSHFMamlPTk56N3Aw?=
 =?utf-8?B?ZkR0ajlkeDN5TW15U2lHQnZxYVpQekdNc1p6c2cyb0RPUjdmckJvUmJLSXRR?=
 =?utf-8?B?R3dtbzZnU2dKUDRCYTJ0VFRzWVVadHg0SE5oeStTY1c4c0xaMkxLWnkyYXhB?=
 =?utf-8?B?a1NYUU4wcyttMnV5eWlIbFUrUmtMU3oxdWVTTEtiaWxId0pQMXluQVR5WTZD?=
 =?utf-8?B?YmpKd3N1aVlIUStmcjczeG96TWdXOGliS1I4Ym5vTkFPRjR6ODZ4OVFqd0M0?=
 =?utf-8?B?dDdmN0VKVnFzMENpbDBRRVplN1l6OWt0eGthcXk3dEk2dFBkUlUrb3lySU1Z?=
 =?utf-8?B?UWFNWVJPVkRna0FCTXh1bDFueVNsSGR5VVB5aDI1TlZETVlQcmRtYzJaak84?=
 =?utf-8?B?Wk8yYjJUR3RQN1JOam4vQnV6a1I0cU9SVGJKZTZQdm9lc2QwY1Qyc3FWSjFC?=
 =?utf-8?Q?Bxekx4pq7D+SqkbnkLQSS7E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1eeba3b1-3dd4-4290-dfc6-08d9b64f36ab
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:22:38.6810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SnKVYnFu0bwLOCRe7POMucUX42qQhe67DGRgqEP5COKhInqGihRpo/x61f2jqSdtR/MDN9KY77l77wf75OIhpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4445

Just like (in protected mode) reads may not go to exec-only segments and
writes may not go to non-writable ones, insn fetches may not access data
segments.

Fixes: 623e83716791 ("hvm: Support hardware task switching")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2551,6 +2551,9 @@ bool hvm_vcpu_virtual_to_linear(
      */
     ASSERT(seg < x86_seg_none);
 
+    /* However, check that insn fetches only ever specify CS. */
+    ASSERT(access_type != hvm_access_insn_fetch || seg == x86_seg_cs);
+
     if ( !(v->arch.hvm.guest_cr[0] & X86_CR0_PE) )
     {
         /*
@@ -2615,10 +2618,17 @@ bool hvm_vcpu_virtual_to_linear(
                 if ( (reg->type & 0xa) == 0x8 )
                     goto out; /* execute-only code segment */
                 break;
+
             case hvm_access_write:
                 if ( (reg->type & 0xa) != 0x2 )
                     goto out; /* not a writable data segment */
                 break;
+
+            case hvm_access_insn_fetch:
+                if ( !(reg->type & 0x8) )
+                    goto out; /* not a code segment */
+                break;
+
             default:
                 break;
             }



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:23:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:23:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237394.411748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6fO-00086j-7V; Fri, 03 Dec 2021 11:23:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237394.411748; Fri, 03 Dec 2021 11:23:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6fO-00086c-4L; Fri, 03 Dec 2021 11:23:50 +0000
Received: by outflank-mailman (input) for mailman id 237394;
 Fri, 03 Dec 2021 11:23:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mRw7=QU=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mt6fM-00086R-PK
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:23:48 +0000
Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com
 [2607:f8b0:4864:20::529])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7b3fe6d2-542b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:23:47 +0100 (CET)
Received: by mail-pg1-x529.google.com with SMTP id s37so2692974pga.9
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 03:23:47 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 s19sm3163132pfu.104.2021.12.03.03.23.35
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 03:23:46 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b3fe6d2-542b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=5qOEsIBGR+o+C/Sd/hZPIupqUBKJep0nylH6kuX0Ydw=;
        b=q0Pme1zsdQbsn/2lt0smQ5WZz4BXmeUPnOOQ1muby1YCdz5IT1U09UP1jUBBmxEyPL
         NOru1PSpvapDsmivD7kZ9TeY4nIh4h/PD8j+3/Qjz2xIc5mwaH978BhiApU+G+OBiI7v
         q/qNUWoMUpEW19dcyNf3m0rrPCJ/jIoQ8FNY77sy6LiOJroeLUPHkq2iJ8x4EVpI8qAR
         W8mXj1YcXAKXWrwiItNpeq0F/HQ8gvHL9KZdDyXlYDHHoBYGqS65rRws5i+e6DI7+Z4H
         wLyunjYStAzQIYUzq5SzqUYg0FmBREr2lO1ssgnjS7fDp96JlKgzobkXt7gXkITr/9HS
         GSkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=5qOEsIBGR+o+C/Sd/hZPIupqUBKJep0nylH6kuX0Ydw=;
        b=zN1B8hEVJ3uzzlZbeZ5HWWCKIMyZQAdsVg03Ic+0z38mQTleSxCzAiXsGJjFxzJXpY
         P8TaBT5xUKRDSq74oC4CEaxlA+r1YOMpA72AW/Jnx0CqDThZ457hfGB5aSAGPFlA1G6n
         RhRSxtnguqmlWXQI0cySnbM/wVLsGmgERJS/z8iF4bGSzCz01t9+FITi3mMj7bP3Iu4o
         UZP9gjSnDMiVxk7w46OTupna9KoH9mbED5GtdsgK+kpfUDoxCNXvqkWTA51D46v3/9nI
         4xoRs0pXPAB4tg/6ffIl/xEHto+YCGLT11GaSct7pQXXXL5QVNAxpWADkkjJQcxc9T6H
         AZ8g==
X-Gm-Message-State: AOAM533atOCSv3y1b0iRxLzIVxEnDBkh1WrM0mlDZjaFqWGP+H1q52e3
	bsy2Px7zCIv381asRjTpe5o=
X-Google-Smtp-Source: ABdhPJxsVhY/s/+3W38Gewn81IUYDNoXcMk2IwynUbTteHgWiue1YzqLNGeWHF+qlwyyWcrcPKXfoQ==
X-Received: by 2002:a63:2fc5:: with SMTP id v188mr4006669pgv.190.1638530626460;
        Fri, 03 Dec 2021 03:23:46 -0800 (PST)
Message-ID: <03718701-d27b-7da9-2849-46af3efaaa98@gmail.com>
Date: Fri, 3 Dec 2021 19:23:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 2/5] x86/hyper-v: Add hyperv Isolation VM check in the
 cc_platform_has()
Content-Language: en-US
To: Wei Liu <wei.liu@kernel.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 thomas.lendacky@amd.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org,
 linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
 netdev@vger.kernel.org, vkuznets@redhat.com, brijesh.singh@amd.com,
 konrad.wilk@oracle.com, hch@lst.de, parri.andrea@gmail.com,
 dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-3-ltykernel@gmail.com>
 <20211202143946.7o7ncwcjq3t6xcrq@liuwe-devbox-debian-v2>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <20211202143946.7o7ncwcjq3t6xcrq@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/2/2021 10:39 PM, Wei Liu wrote:
>> +static bool hyperv_cc_platform_has(enum cc_attr attr)
>> +{
>> +#ifdef CONFIG_HYPERV
>> +	if (attr == CC_ATTR_GUEST_MEM_ENCRYPT)
>> +		return true;
>> +	else
>> +		return false;
> This can be simplified as
> 
> 	return attr == CC_ATTR_GUEST_MEM_ENCRYPT;
> 
> 
> Wei.

Hi Wei:	
	Thanks for your review. Will update.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:25:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:25:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237397.411759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6gk-0000H8-HK; Fri, 03 Dec 2021 11:25:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237397.411759; Fri, 03 Dec 2021 11:25:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6gk-0000H1-EV; Fri, 03 Dec 2021 11:25:14 +0000
Received: by outflank-mailman (input) for mailman id 237397;
 Fri, 03 Dec 2021 11:25:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6gi-0000G0-Os
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:25:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ade10ce8-542b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:25:12 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-ELRM_cNLPwyLocTF4jhw3Q-1; Fri, 03 Dec 2021 12:25:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 3 Dec
 2021 11:25:09 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:25:09 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:20b:6e::32) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 11:25:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ade10ce8-542b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638530711;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZOmI8Ih5PM/6pBakJPiDAUUNfeWIayaIXjU/j9/N+80=;
	b=O/tzcZmgiZXnn43uRNNs1xacXMD7V22J/gN3AhEW5YunKixrsT6GHdPWh/dUdeOHYzQE33
	L+Pbo1OOa82zbPmMnF05ed1HQgTX/vjRXnpThYZ/vHfAZnDSWA4Rt/Fe+wj05nfahUUaQR
	0C0kkMfL/N/eU+pstjgd6Sbl7g0RLuA=
X-MC-Unique: ELRM_cNLPwyLocTF4jhw3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FUofhmL8p4U9VS6pWFl5oGzXMn7KB9WgqGCJVZ2r6D0FN7U580ak9rgm9WmRO0o/LKhiwAKKJgSOh/Sa+47AUWqJVG51WQZsuxvcgtWnf8Lji0lzoWbi1uw9/jOVwv6I1hnEYnCXHe3dOzOITesKUTYXMI94A+iHHeYVKpZWgJ3KQMIZAz7R0/zUi0+9vXxA/Bdo/hmAqmPu1p6NhU3F7KsHh4nmTSResPciPwvXD0Jav3T3kWUMZ+wqeikyXi2lwiVDtgLs4v5zqSO6cgfU4msqb10BFMearyIfnyLVvnnHcAX6/PB0TyfCLf71ihmHCr+xTyXNllRzSMNu1HS4/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OcG6n8Inaqi+6Glj4y9+FfnxSpvy+Xiyjo8nlMWC198=;
 b=UT1yTV8Y3Bi9hCTT/bIkORorjjRdJZ4A7wtRDEHXB64aVen06RpMb6PLrrospFfjNk8NouEr3FY7M0oSyUwe7XODSTFcr9kwNT5vMaBocRczqhvbHlziiHKu2Dzd/XJXn5fVisttcCNNVE6mYoL6ptEHXr0CRF+dd2aPKZN6SxM/RXXGwNLlQFhRAgYskylpWp4vOSkWIz8AqjXY8pPO8bGHoiRFBp/pNcNBoNeDoqhsjayhvqaG6RsoECs+APnkB7YUwc/xqfih7K1rtmdPU1iLpOKu7vt02239FXzTb//O4y2hH62aX4+iQUkaCv+i+eSCSe88NANeqLOuECYV+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <00c116e8-b3d4-bd78-781d-21a4057e989b@suse.com>
Date: Fri, 3 Dec 2021 12:25:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR02CA0019.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd4bba9a-bc23-4e03-b831-08d9b64f90c0
X-MS-TrafficTypeDiagnostic: VE1PR04MB7375:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB7375C552CB8712BB550FD799B36A9@VE1PR04MB7375.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	M+qBAJqb0tyo0U6WyMsD16NiY7mikkbUGxQZIgoQiiJoQiF+pO3lNI5Ul4RO8p/xUZ3UHNwfFOrz2YvpmMWcCTDkNgBtCKnR8gfB/w1KEbzoOaF2ZUvnRO92PD4R8Im/42vRljWw9iLrnsrfwAcAmIGD3typmxs63MyrrcMevtXk658ghluIIDId0RAjacvksuekFlIrd+J68ZSW8iLmFDTV91rdVwDpX8QO3G8dzh1ddpwKMWyDgNOqCEPx6i+WMw74txs589Osr0Nmzwd8BRVZo/wtnR/U86H+TNby3P5hTAMAvSWWLsipfp3vx+wrVrTO0kyw7L76X3VsSO2sJIR+T4or7A9jMEYsLdfEYb4sh5EYfz13Oaq06UCc3fRet7TZd5grc+IVilmu/TqRMtRsvXIS16AQwpFUTagvm2V9OUSdMttU8brU+4KkIUqhNotVhceECU7ps95hL99QhdHNw1rpSlZNxyPDBwGZFsE3tRdBN3yxmYoltj7V2wWdk3ebKeDskeEx9Oph0wnJ/rUd6dgdlbTLnJoydAiKWbXvhOTynaowg5JVYI7giQRswPLPJpPYQD+aG41Dld7DV1quEhcKT+0nIUMIBjzyqSEIYl1FXfRvOkm9qBvvcpqh1EYmUauaHrHrGQuc9WvSaTgyQfOfazNfAywoozDtpjkdTio2W7sYdDVq8uTIkebTUgMSvVRjUOseHK9w8JWMxyy9v4OKjzKBQjAiiMZwgDk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(36756003)(16576012)(26005)(66556008)(4744005)(2906002)(956004)(6916009)(54906003)(66476007)(31696002)(2616005)(316002)(66946007)(4326008)(508600001)(38100700002)(8676002)(83380400001)(5660300002)(53546011)(86362001)(6486002)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zlCgo5AUf2F8MDdIMh9T/R+rAPxFXUBX5Wwk9lTRray4hvqaP7Y9Qyvw2QnE?=
 =?us-ascii?Q?2bfgvblkwAVaP1Ijx1S0ir7leccrK+ewCTat19EC0QWlmahoTaWr69J6dpwG?=
 =?us-ascii?Q?d/71y8qP8UOeXkQknzb9NqoysE8Olh5vjt2HJOJGGqIvwAeVycs6+7bljVR8?=
 =?us-ascii?Q?GbHxNZhGT6ruE/BRDMwsGieLi56p0rEbf9Y0G4iBvLCC+D9m7XhBnWDxoApT?=
 =?us-ascii?Q?Lox4/umNG0GXWs0/kICQkXNT+mPIymYGZn/9h6LtfF2/hlpokz053IepQPC4?=
 =?us-ascii?Q?ZkrPBSLKkC5/CJjdyhoQneGlfoZdf4KlaoT9LragjYV2vX9TLXLrO0Dt6zng?=
 =?us-ascii?Q?g9Oi5rDX808QV5oY3/pYn5ojdIX/s5WByjCrKUhDXHnhe1Jj4e+LF4ScXX4K?=
 =?us-ascii?Q?b6kdChOGsnew3qjniwH5i+rWD6aKN2QIm8Z1LqpjH23SYY8h9uC/Sv4rub9V?=
 =?us-ascii?Q?4bi/7syL10GtGaZRuXETCk9an+ZUIYSTW3UMkQy2DOTx2b0FTNUG3IUkqoiG?=
 =?us-ascii?Q?63BALlOCf87ztvYtEfq0KiFjBPRNePbxB8tq8zDsYHrAQJnfE68Lns2t/zjX?=
 =?us-ascii?Q?MtxnmSJ/FJhPFWihE7SrsroEz90DFOun4YWVjIlhMxWlhBX4u7+IxwxacWwO?=
 =?us-ascii?Q?HIjq4PwYKe+z5KQSV31o+y4w9CehhNaCFTMFGQhVPzw2B90iblmw8gvkJJcb?=
 =?us-ascii?Q?O+djhz5Tk+KS66fn4algx+pGtx8338VZKu1XV8bh7ApR60nvdd9HNYeMvSYP?=
 =?us-ascii?Q?KdqOysCJnXObqxkcNnH3cKl0FITEDnAzx+RUp5M+Y6+K5AhwbY6IEyUsqJ0D?=
 =?us-ascii?Q?Cae7Gf9JVv38uRlSvbbLp5SrcEHAeVjGO789lMfIvWWK6AJpQwYPcf4gJKlh?=
 =?us-ascii?Q?D9ikFxWzDg3PFwTyBJKSZjFpAvm14PA9kOuM8Q56GKPfcFvYUwUWvuGOlNwQ?=
 =?us-ascii?Q?UEGAeCp4BQHDuAF8F8OcA1WCu8PeyFhp1wnF2HgDrZPGfCZ7Y4hSWGBve1+W?=
 =?us-ascii?Q?l+OuNG9BGaEsZEOusRI1aDBMFnwzz69PGD3XOiiFotBrwW1QlQ/yHxad+e+4?=
 =?us-ascii?Q?DglHL0hxcRMVNlBHqT01qz6wbesFht1VZS7/bNA1RKFMgjzzRLaIDp9PfDpE?=
 =?us-ascii?Q?/oJZSH6eJbHf9aeiEL3dN/OyzEtrnpHnmdR6mZDAk9/AOPQRMZluRNBHqOjW?=
 =?us-ascii?Q?m2cRkNAyfQtpP0QxWwczpC67arPtZSPxU9Y0FD5ri+qPUYDsATBDgE1e5wwz?=
 =?us-ascii?Q?MwsDbnWdhzbBELfWsKjoogsh2Im3p8UuDZG6NEiJMkrCF+hcWU7hrT3FK9hx?=
 =?us-ascii?Q?dUNKgI+rJKYjr7+1lAsT7soWhEDnAt1fBwzz8SR3I1qnCQbqUgmeEznJhhNZ?=
 =?us-ascii?Q?bS8GEUM60GkUNJSUJEr9taRznokJUNf81xNaUXoxjHs/oJf5C7iKsDesPff1?=
 =?us-ascii?Q?w07UPNLDdMS6vdyDf4LiU2P8ngAmbg0BSl6nTZEpjTBar26cLGZsRPua5AtA?=
 =?us-ascii?Q?e91lZJPzxfSnR/kRGLbhFbGxCKJ/nogc0lfFrNKYuxOuv/pchCmgYBd3DgNm?=
 =?us-ascii?Q?h5ydj/GBaYOjbx2K8oLWDn5XDZuw5zH7mIkfz5sL2zFZxrF/XIsLRqqWaE4s?=
 =?us-ascii?Q?TqJTIgB6qLMmBAMfe5UYqaQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd4bba9a-bc23-4e03-b831-08d9b64f90c0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:25:09.8245
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HrShAkS3ulHkEytXBQTYoHJJgj/2i4KeH6ugN5yl5OXbuU4WLyDWaUM2iNg2DFGkfdQwhvGcbyRFN8YoBDYMyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375

On 03.12.2021 12:21, Andrew Cooper wrote:
> On 03/12/2021 10:56, Jan Beulich wrote:
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>   immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Why does blexit() need moving?=C2=A0 It isn't static, and has a real
> prototype in efi.h

Oops - clearly an oversight of mine.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:26:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:26:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237401.411771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6hb-0000qT-R9; Fri, 03 Dec 2021 11:26:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237401.411771; Fri, 03 Dec 2021 11:26:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6hb-0000qM-OD; Fri, 03 Dec 2021 11:26:07 +0000
Received: by outflank-mailman (input) for mailman id 237401;
 Fri, 03 Dec 2021 11:26:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mRw7=QU=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mt6ha-0000my-FV
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:26:06 +0000
Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com
 [2607:f8b0:4864:20::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd78d405-542b-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 12:26:05 +0100 (CET)
Received: by mail-pl1-x630.google.com with SMTP id b13so1898272plg.2
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 03:26:05 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b])
 by smtp.gmail.com with ESMTPSA id
 mp12sm5062949pjb.39.2021.12.03.03.25.53
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 03:26:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd78d405-542b-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=Df2I2A2zVcIhvBHXD5z9iabD7nB5LthE/+eMaX0CJns=;
        b=LrhVabQro3+RJTAF2UUwo++Q3tHVPc9KkdjTXgZj5009TrrrQoEZbScehBEamrCUSN
         uAuPgOUZCbn39oord0X3XW7U/XIJ2WzNu0xdbBsMDjNH8DRAcaKxm/RnUdXTK7TPH9GB
         /3QVEkipv/oDwHi2iskl2LfbgoDlNjPpNEnAH9c0t4ds6OIO4vgwzDl9tD4vqPr3Jj1i
         soeN//lG51eXYc9/8Noh0CxgiHul5HzjoLY8pcB7lUlMXYr1yF0iF5iR8ZnAimEr0fEF
         u9pUnIeyp3+uCAIcJI0WC45iQsDzZ7vfXZh4Mm9tVdhmXvGp7nCrb22wqTAz0TVn9HBO
         JiOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=Df2I2A2zVcIhvBHXD5z9iabD7nB5LthE/+eMaX0CJns=;
        b=1oPEW9mD3W8vJJ6nCm9eC46OqPkIWmvZ8zHYwhXktqEwq1bxAfkhRYGF9OzYe2rfzf
         hdzrUY1JZh7VxhsdBt4WZLD8OHRM9lGURd7+vxzBIZNEFeaKLYNseNLpGADfsFtCq1sI
         WodjIii/EIIBAGmIdAsmJuz8+BSH+qPDUHM8C0Y1Jg0P3I6r1DqHTXnRvwmG7nnyeoB6
         ZEL1P46qfi09U74WdjUnDNpQRjAVRQlwsxHzC2p4bOdgJF54GiEZY7EThxdoZ5tTjt5d
         1lEA93TZj3FrQT3sAZ2ehomOklM0xlyQ8lMfIBZpk7HpJJexv2vc0lE/M33PDGsWbQue
         vDLw==
X-Gm-Message-State: AOAM530OCZa+rAuwh21Rqu9OqPLM/3fwM18KuPhxIAdwVkBoNPbwuIGi
	djPLFoqiQhDw/wEkmKbiqho=
X-Google-Smtp-Source: ABdhPJzPvoKIz31xLOmSdpnjjIrMa2J9GjBdJxPwkC+KmRLj7Ds+PG6GrIFi6sWFBo0epAEx6rdfGQ==
X-Received: by 2002:a17:90b:190f:: with SMTP id mp15mr13348018pjb.210.1638530764387;
        Fri, 03 Dec 2021 03:26:04 -0800 (PST)
Message-ID: <4006e942-b6bf-ac21-c56b-4719e514dbd2@gmail.com>
Date: Fri, 3 Dec 2021 19:25:52 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Content-Language: en-US
To: Wei Liu <wei.liu@kernel.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 thomas.lendacky@amd.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org,
 linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
 netdev@vger.kernel.org, vkuznets@redhat.com, brijesh.singh@amd.com,
 konrad.wilk@oracle.com, hch@lst.de, parri.andrea@gmail.com,
 dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-4-ltykernel@gmail.com>
 <20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <20211202144336.z2sfs6kw5kdsfqgv@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/2/2021 10:43 PM, Wei Liu wrote:
> On Wed, Dec 01, 2021 at 11:02:54AM -0500, Tianyu Lan wrote:
> [...]
>> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
>> index 46df59aeaa06..30fd0600b008 100644
>> --- a/arch/x86/xen/pci-swiotlb-xen.c
>> +++ b/arch/x86/xen/pci-swiotlb-xen.c
>> @@ -4,6 +4,7 @@
>>   
>>   #include <linux/dma-map-ops.h>
>>   #include <linux/pci.h>
>> +#include <linux/hyperv.h>
>>   #include <xen/swiotlb-xen.h>
>>   
>>   #include <asm/xen/hypervisor.h>
>> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
>>   EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
>>   
>>   IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
>> -		  NULL,
>> +		  hyperv_swiotlb_detect,
> 
> It is not immediately obvious why this is needed just by reading the
> code. Please consider copying some of the text in the commit message to
> a comment here.
> 

Thanks for suggestion. Will update.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:26:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:26:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237403.411781 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6he-00018N-9i; Fri, 03 Dec 2021 11:26:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237403.411781; Fri, 03 Dec 2021 11:26:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6he-00018A-6i; Fri, 03 Dec 2021 11:26:10 +0000
Received: by outflank-mailman (input) for mailman id 237403;
 Fri, 03 Dec 2021 11:26:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt6hd-0000G0-Oa
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:26:09 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cf5d8ee3-542b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:26:09 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40488)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt6hV-000KAH-nr (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 11:26:01 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 3AD7E1FD7A;
 Fri,  3 Dec 2021 11:26:01 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cf5d8ee3-542b-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a29b2b16-6d9f-10ea-d039-e19005b4e5f0@srcf.net>
Date: Fri, 3 Dec 2021 11:26:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
 <00c116e8-b3d4-bd78-781d-21a4057e989b@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <00c116e8-b3d4-bd78-781d-21a4057e989b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 11:25, Jan Beulich wrote:
> On 03.12.2021 12:21, Andrew Cooper wrote:
>> On 03/12/2021 10:56, Jan Beulich wrote:
>>> When it was introduced, it was imo placed way too high up, making it
>>> necessary to forward-declare way too many static functions. Move it down
>>> together with
>>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>>   immediately ahead of the #include,
>>> - blexit(), because of its use of the efi_arch_blexit() hook.
>>> Move up get_value() and set_color() to before the inclusion so their
>>> forward declarations can also be zapped.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Why does blexit() need moving?  It isn't static, and has a real
>> prototype in efi.h
> Oops - clearly an oversight of mine.

With that left as was, everything else looks fine, so the whole series
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237415.411793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6iO-00028y-MQ; Fri, 03 Dec 2021 11:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237415.411793; Fri, 03 Dec 2021 11:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6iO-00028r-Ia; Fri, 03 Dec 2021 11:26:56 +0000
Received: by outflank-mailman (input) for mailman id 237415;
 Fri, 03 Dec 2021 11:26:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V//U=QU=xilinx.com=ayankuma@srs-se1.protection.inumbo.net>)
 id 1mt6fI-00064Q-Im
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:23:44 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on20600.outbound.protection.outlook.com
 [2a01:111:f400:7e89::600])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77923883-542b-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 12:23:43 +0100 (CET)
Received: from SA0PR11CA0179.namprd11.prod.outlook.com (2603:10b6:806:1bb::34)
 by DM6PR02MB5307.namprd02.prod.outlook.com (2603:10b6:5:45::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 11:23:39 +0000
Received: from SN1NAM02FT0055.eop-nam02.prod.protection.outlook.com
 (2603:10b6:806:1bb:cafe::2d) by SA0PR11CA0179.outlook.office365.com
 (2603:10b6:806:1bb::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 11:23:39 +0000
Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by
 SN1NAM02FT0055.mail.protection.outlook.com (10.97.5.78) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 11:23:38 +0000
Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by
 xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2176.14; Fri, 3 Dec 2021 11:23:37 +0000
Received: from smtp.xilinx.com (172.21.105.198) by
 xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id
 15.1.2176.14 via Frontend Transport; Fri, 3 Dec 2021 11:23:37 +0000
Received: from [10.71.119.136] (port=64457)
 by smtp.xilinx.com with esmtp (Exim 4.90)
 (envelope-from <ayan.kumar.halder@xilinx.com>)
 id 1mt6fB-0001wq-9p; Fri, 03 Dec 2021 11:23:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77923883-542b-11ec-976b-d102b41d0961
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CbJiamsWfrhX0amJuPVVirEfbbEGCLJ3/6sIoL4RkRKrHR98Ez9u2RjcBivGBhuFlJZmD9jW967LTL4H6GwQUJQCjF8TdjkFNA5Vm63DJOzOJuVrq5zky8ttWEDuwzw9y5SxRzThcHXvQVJhDmqPgbWX/2XTijHQJoaMJjxwsaOW0qjyMW9DtrOF6k8dysbuXYCvU+j42fzqf9LVYBSvhmt2kqrN1fkOWpyNL7TEsvi5n50xmGlpLF6mt77A+L75t5xo1rpf36WcOY7re5/U1E5Z8ja1FgM1NANV8W9J2Cqo3woMplsNZw4/oAjQ7WiguQ9V7FuxHNxjnL00C4jFqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mvlwS1dvBlnlZTr3CCWS9Qgh2Tyhuiho/pCIHihSSno=;
 b=eDG/Z82nmRPO8bcehmmxdfobV6L+Vf3GlmIf1z5ikERR02pDCPB8de5wQVNXxuWvusPxcs4kXGYr1rjMqYUyZIGgo7lTS7srKiIh+X771NnPxkMHM1TCFpTYnLp0j/vWNxgfFsoKBWkixoZieWWrvk7KkcTwq+vKorXecFn7U54q+RNGuIfZ8jHAK20Nv7RauG/dbYclYW97BNA3Yu4XirrcL5tCOmhGSouOvjfiB27GEBVj8DldkJe0vUB8dxRI6Xgh78i+3yA4usH6B8zA+OdNoNcP/l7To8PEWneHrTrZZUEh2heHUziOR6cDKBhChYqRrGWVDN5AloX/UJcXuA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 149.199.80.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mvlwS1dvBlnlZTr3CCWS9Qgh2Tyhuiho/pCIHihSSno=;
 b=Uo6kgS0BeIECj0liZiXxM8KrYmGJLAto4beg8HGR0vEFGAs33NxIItuKlp+P2niBbXmAGJzbLR5WXjsNr3M2qhwAYU2Qip4qztteEA1fQEcbqglyIevyhOsMrSX0jAUI/5ud7LNoCZP/uWsWezKosoa1eJei9XcrRQ8YxHk2V2k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198)
 smtp.mailfrom=xilinx.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=xilinx.com;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.80.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com;
Message-ID: <fa4c0e20-3640-e948-a39d-42c80aa40e9b@xilinx.com>
Date: Fri, 3 Dec 2021 11:23:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
To: Bertrand Marquis <Bertrand.Marquis@arm.com>, Michal Orzel
	<Michal.Orzel@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
 <B3D7A1CC-6CEB-45C9-914C-6BF5540EA1BE@arm.com>
From: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
In-Reply-To: <B3D7A1CC-6CEB-45C9-914C-6BF5540EA1BE@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e2737c03-3740-4ed7-34d8-08d9b64f5aa0
X-MS-TrafficTypeDiagnostic: DM6PR02MB5307:
X-Microsoft-Antispam-PRVS:
	<DM6PR02MB5307FE7FDE2F531D9ABC5FA1B26A9@DM6PR02MB5307.namprd02.prod.outlook.com>
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gvS1Stq7dYgwmzbBiy1MtrvE2ku1vAra0AVriHpH06HHy7zME1fr1RgFag7AGHTsXzu6m8gqJz0Oum5U9sSgjtCwXd8lPdym7XsAKSUjnYqugR1WowBF9Pv6GZrKICM1OC3kyLpdb2qYxdIyh2vc1IzkOJaKx0V+7ic9v5h08M9qBnWzTJ0oCeOgge/wTDzfZS4N5UCEke9qpycXv0NyoKB+fmDL8VQ37naBcLXN/+sdQvEDcv/LrIYm/iHBOkN8ozHuRee3DMS/t1Mwsmbjft9b9up2VhhYddhSZE21xo1ulIYblK+wXuJqX2TAdMscEbOH+SGZjC/xxwNVwaB31DiKsZh4Uhhg8rchKbXasidLOmMSTS9t2vwqzJS/mQutjgVFfdP9zZBD50jo31Z9wqf1grb6qbT2LWrdHkjWn6cUF62vd8tckhGiZG2ZkJbMRCDSQmF7LSY8RNhOnSYjSqjqutGm1B+dntdkTTBjSqjMuVlW1CEdHroHu/ph+/rs3lTpCh9JrNSVmRR0/VpAz2B9uEJAwDysijfAURghiLqlwgRJUjON8iEMsx5gvSfaw+WZL/QJFBvjaBp5RCM58k8TZDwzqScgjtg/AZ3/WDV0NZN7LsnotQsFpaydQos5SJouvCrCqGuI2IEd8DefAhjkrd7kgHijUncx6APVVzVFQMt19ECgKsqUtZfXL3sTC7r+iOljDfAN7fMJgPEPe+Eh2ZKwAEHcOHgUhM6uhC67y3voAZCiZlYBVq5YT8V+AeCVDwjkRlG4eKA7n1nqeg==
X-Forefront-Antispam-Report:
	CIP:149.199.80.198;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:xir-pvapexch02.xlnx.xilinx.com;PTR:unknown-80-198.xilinx.com;CAT:NONE;SFS:(46966006)(36840700001)(2616005)(508600001)(316002)(7636003)(186003)(36860700001)(31696002)(70586007)(8676002)(4326008)(54906003)(426003)(70206006)(336012)(356005)(5660300002)(36756003)(110136005)(82310400004)(9786002)(83380400001)(53546011)(26005)(8936002)(2906002)(47076005)(31686004)(50156003)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:23:38.6100
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e2737c03-3740-4ed7-34d8-08d9b64f5aa0
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.80.198];Helo=[xir-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource:
	SN1NAM02FT0055.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5307



On 03/12/2021 10:19, Bertrand Marquis wrote:
> Hi Michal,
> 
>> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
>>
>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>> forgot to modify a comment about lr_pending list,
>> referring to a function that has been renamed.
>> Fix that.
>>
>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Bertrand is very fast. :D.
I wanted to check if it is ok to add my R-b.
> 
> Thanks for that
> 
> Cheers
> Bertrand
> 
>> ---
>> xen/include/asm-arm/vgic.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index e69a59063a..ade427a808 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>       * corresponding LR it is also removed from this list. */
>>      struct list_head inflight_irqs;
>>      /* lr_pending is used to queue IRQs (struct pending_irq) that the
>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>       * no LRs were available at the time.
>>       * As soon as an LR is freed we remove the first IRQ from this
>>       * list and write it to the LR register.
>> -- 
>> 2.29.0
>>
> 
> 


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:27:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:27:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237421.411804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6ie-0002iu-Us; Fri, 03 Dec 2021 11:27:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237421.411804; Fri, 03 Dec 2021 11:27:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6ie-0002in-Rb; Fri, 03 Dec 2021 11:27:12 +0000
Received: by outflank-mailman (input) for mailman id 237421;
 Fri, 03 Dec 2021 11:27:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt6f3-00064Q-7F
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:23:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6fda1e7c-542b-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 12:23:28 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-UPImK2diOhqP9Q_ZdHKf0g-1; Fri, 03 Dec 2021 12:23:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 3 Dec
 2021 11:23:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:23:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0025.eurprd05.prod.outlook.com (2603:10a6:20b:488::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23 via Frontend
 Transport; Fri, 3 Dec 2021 11:23:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fda1e7c-542b-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638530607;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HFvGg2AyKiCL3CXNR/7f8T5X0LRpA3l3GkYroFgY/v8=;
	b=NIL2SB0goXbkvd8J+knD6SIM4UOupXp0+TJ01ARU4mkX68sxM11ncjL278rZOnqSStSWWE
	keOnUGMSd0hQ6/zRf1DN6w6KrTvM4EQ/JriELWJ5RIIdu9yxrmRml3u0oKPkVMCYjfJATN
	67Qvt5OcvSrWj49qFATTGbtYwnhzETs=
X-MC-Unique: UPImK2diOhqP9Q_ZdHKf0g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZI8uQOflQKFH/uNIokRfzmeVuCktWAEgbxdfHmV+/+NA1HSN9PiYMQpfOeROCADM0aGIok6tXQthyczOGrjiZ6u9DzubYNZ3R52EerYWsK1BuJfIjLzw6BRMRG1JK9ZYn1HLDDX6vQoaj4zS8q3cwGQAx7eQPNhO1BmHSM6JGl+QzaMNWbRm4H8V3VpsBup75Hdn1Nx9nyNslx8dldDiSsH0QfhO/bXXLTGcFSBGdKv31tNJhv1NxRpHVLCEGeGGlxMiL37CNU9++nYg08EvUCzEEeJKH+lsOfLgrlvIWwGNsWbRORXwNfK9LCwVrJsaG2WpDktPVTSaqB4SBeWUBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HFvGg2AyKiCL3CXNR/7f8T5X0LRpA3l3GkYroFgY/v8=;
 b=AZeXxxs70HsmgRDNJ2lh9BhZ0VFwK9JwsNNFraXpPA3dtyvwUEU3o0GE5gAySMLcrSyRU4sW0fNYCnm1flehhKl2cZrbMNc/zxdArbqjP/kDiDK5IeNy85SOlv6SFbXHqfsbkVHlEpM3PDoTImmBYl3m8MFcr5mYTRDPig+EExvQC//7drwICQ/7/0VpSIEJGdBEw0YmnX7spnD+EhHDRdr6U0COBMfHyf4LtRdaIIuPYxtT5J7acl7lZnPct1TdEeD0iqsPt9GuKdI06hss66LyayFKW88EKSCJuTH6Pq+1RaHm7KfWkR7tfVBWkPevIyBiZZnxrOIs7lrEk4OUTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53cf0492-e197-d3e6-8898-9e199bbc5399@suse.com>
Date: Fri, 3 Dec 2021 12:23:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/3] x86emul: drop "seg" parameter from insn_fetch() hook
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
In-Reply-To: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0025.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 979c54f3-86d8-413d-5d59-08d9b64f5278
X-MS-TrafficTypeDiagnostic: VE1PR04MB7375:
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB73753E0426978088A92D1DFBB36A9@VE1PR04MB7375.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2150;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YXvBS01+dT4U/cy00IGBI6NziOyeaC10JbhIijIIaXRiNJ2Kj3WifcDf732zylaBc0cGI4IfIP8tu3NjnBv5EB6BfoswdM0M/5sN9PoRzX/m/ZYuC0UKtJTXTAulOJKUPfvLrkibyECO1Yd6x/LydY527+7//TiBgpCePBjqzfXS6DQ0JfcBca/btnXqlrM7yojC17LPLcocgiePxI/SMqKr+AMpvEw6NCvpUCVjPkEGLcgmr8sp32Ggbe1lAmN3NVxTHgRf8AWU81eVdNptkUv8zYqRihx49ibEX8cuIG5OVW+XyoVXnwtp8iUWRlWzE/7aQm99eJdTTXgyejZNM8Vya4rmrMtdb20H70XH/ok7thYXhV5C2Va/HWHEH18D/8jcG802L0+HJk35f3Wx18hjCF3Bfky7yoFLS4CduIG6HMgyQDBOO4Dhpq1CQDGE+ZHw+aRHAL6ieIRQ9GVtDy2Zgl4+dz+6R44KpFJdnMgWzjPJd15HZo7ySjM5cDAPcOSWjd48HFAr11LIpkg+/Loml3GV7+qNKLKE5UKpsc3qFHN4nr0EGzaXlFSMQZyBS5RQdbLTvl/ORudwZvYh5EdLuLgLe44blzwVztZtxU+e7Cgd7vogDgR6AwxQERnDAlN79afsleiooKKedi7JvHWF2l8EPQhR6uYWt+RKLgjNIFjq6Uf8830ls5yHBq5CmuJjLa+4JHDwYN67XeljZ7O5QYVG66PdtkVuycUySoM5WKo0yvOFLYDwg0P5KGaPikDon4evodkfDxXjAnpRWW4ngXnYu0zixWLeyv+l7mU2BXEngDu4JUvEdJM0Vqq+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(36756003)(16576012)(26005)(66556008)(2906002)(30864003)(956004)(6916009)(54906003)(66476007)(31696002)(2616005)(316002)(66946007)(4326008)(508600001)(38100700002)(8676002)(83380400001)(5660300002)(86362001)(6486002)(8936002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bnF1MnNxbkpoaUVhbmVvNmVDVHdSMHFYOVJ4QkxTREhJZW4rcnhqaEhuNGJt?=
 =?utf-8?B?cHNmK29NRmhIdEVmNXVvOXpBbzBXdDJPSkpyTEtUSTlKODMrN09pWUN1ZlIx?=
 =?utf-8?B?MDNmSFM2em05dzY1Q3dNM0xDVGc3YUkxd2UxbG9LMm45VU41SjllN0JpeUFn?=
 =?utf-8?B?NE1qYklaNExUZExUdGsxbjRZc0FTcGlPVjk4Nyt2ZWFwZFFxRXUvcWF4WVA2?=
 =?utf-8?B?aFVOQmlyRCtkd3dqZlhsVE0wTFZzWWtnZk1nenJrcm43Nk1QdlNob0Q2U25J?=
 =?utf-8?B?RjV2R040RW5GQjU0MGROa0kvemV0UmZNL2gxY05Td3dxdmFvK2NpQUZITlJK?=
 =?utf-8?B?NUJob0EreHZ6a1BQdVBadkN0SVZBdHYrVlZaWUdFNUZJRFRZMVAxdDZraHhz?=
 =?utf-8?B?K0F5dnp3QmYwZEwwUWo2ejEzSE1GZEN5bWhSUzczNnRFczRWVEhLcU9GMXhI?=
 =?utf-8?B?Ly83SE9EUnhjb0FIQ29Pd0tMdjFpRE5jK21UUXFCMmt2YkM1YjRDZjF4Y3Uv?=
 =?utf-8?B?Rm9ZM09VZlAyT0lRVTNrcmo4bU9namRPcFVWQ1l6Wm1BTEVtWjVKREFFOUtW?=
 =?utf-8?B?VjNydlU3ZEJ1WVJRTzc0ekZMTGhDTU11SlZMMU1PQ2h2NGJDQ0JaKzB5eklZ?=
 =?utf-8?B?WDVjclJva3ZKai9PVGFuWGVia3ZLOG15aFRONUJTZVlVRzFCL0thTTljOVZB?=
 =?utf-8?B?NnVtNXdpVkpYRkFqUDdnTkdiOFZuYTR0WmNsYy9HVE1IWHFaV2VNR2VlYmo0?=
 =?utf-8?B?LzR6dW1TUWpCSFNhdjFTQ0oxbnBLYjBYN3lwNXRaNW5EUlJWY3J0VmUyNWcz?=
 =?utf-8?B?eGFpTlk5LzFQT1pXN0ZzeUhXN3hnTVVoOFBaTHBNUnRPbFRHMVFySG1UTkYz?=
 =?utf-8?B?bi9wdWF3dTVzZkZCRllFRkhCSEcrTlNSVmtpTTBCYXZ5MkdXZlNzM251L1NW?=
 =?utf-8?B?d01PZGw0TGhlMlRCam83dUVFVWZnYTZrT05UTXF2TTl5djFaT2ZUN1ppYlRH?=
 =?utf-8?B?MWY5Y3crQ2tyUXEvaW9BTHJpYWduUTN6Y1Q2L09MbVJUWHFvSDNLaUFNQXdW?=
 =?utf-8?B?NFF0alZYam1nQWVPZEhQbG4rWlJ3aFZLbEVEcE4zaFZaL24rUVZmb2ExWlNF?=
 =?utf-8?B?dmV4THNTWk92YVIyNjcwOUY3cElKRGVlNEpLSGpKTkYwc01yRDVaeXBaUXQv?=
 =?utf-8?B?UU1JWXhNTGRscHVocVFLQm13cm5wcUdMcXEvd3grK01jUEU4ZHJiNWZIT3VD?=
 =?utf-8?B?aElvMmI5S29YVWEzN1hpRzhnNDBPYWFvZFduMC8xamlXc2RsZVdtQVlYeGV1?=
 =?utf-8?B?LzN3NGNoRGFWY1NVM0Z6dC8vemtBa1Y5ZFVldlh0ZHIveHZ1dTB0VkhhZWt5?=
 =?utf-8?B?aFB1elVzZE54WkVaOHUwZGN1U0Y2bThtak5VeXJyZ29sT3pQMGQrOHVQZ0g2?=
 =?utf-8?B?aVQrQ1JoME55SnBsQ2hBbVZ2WXM2SG95cUU0VDBjLzAxMFIzMFdrRk53ZTRZ?=
 =?utf-8?B?MXpoRUFNMmsycGJjZStOVC9SYmpkZVFIRXJEZno3WXdZRnZXb0VaZ3pReHlX?=
 =?utf-8?B?azJCV3liaGlKZHh3WS8vWStxWm83ZVdmdS9PYjl2bFB2Z3I2WU5uelFJWXZy?=
 =?utf-8?B?cTF5Mm5qT25TekUrbEVVcThJcmh1ZzN4cjVwcmg3NWhGdzN1aDhlVEt6NklX?=
 =?utf-8?B?aEJlTnVnU0VQSXRaS0RPeFdQWStBNFJVYUY2QjRUNmlGOVQxYitIVjBRa0FB?=
 =?utf-8?B?TEVabVZOcktGYVBEeW5OSHkyVkpLcjdjaGVGOGNid2pnMm1kaXFkd0Nid0dO?=
 =?utf-8?B?RGN0Ti9ORURQN3dvK20xTEl2TGZtUnN5V3Jsb1A1MWtReEpyVnJmWU1mbnVU?=
 =?utf-8?B?TmtWV1F4VUZ1RkxSbStqeUpXWTFmVWk3RmdIZ2c5U3NOcmkzMXpOOHZ5dGwz?=
 =?utf-8?B?akpPWW1NcEhWRUQ5OXdjeTAwSlJ5TytCRi9kNk1zSXMzVXJoNCtCeFdxcWxC?=
 =?utf-8?B?UXJPZDlDU2Y3NE9sT1hwRk45Q0ticW13L0tzTXFuMUVUUnhUT0tjZU1nd0ZE?=
 =?utf-8?B?VUxJT3g3VEtPM3BaSjJYZ1dra3VreWtMdjZFWTdyVWlGYXJKZU5LbitudlRV?=
 =?utf-8?B?VjBwNTgyL0xWeGFpYzZaZEM4N0xNNnFVVFFYN2Z2bDFRdno2cjRRMGFzaEJl?=
 =?utf-8?Q?TPgXsnCqADNIHiGTg/BHrjw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 979c54f3-86d8-413d-5d59-08d9b64f5278
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:23:25.3286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kFrKd2f9rVxbEXrdUPzgeKaODOG8yHCXBRvlbMuP44mTp5qwCoZZOHQmh6qfqlC5zDJ5Q68mQFXfSOmPvB7cDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375

This is specified (and asserted for in a number of places) to always be
CS. Passing this as an argument in various places is therefore
pointless. The price to pay is two simple new functions, with the
benefit of the PTWR case now gaining a more appropriate error code.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
In principle in the PTWR case I think we ought to set PFEC_insn_fetch in
the error code only when NX is seen as available by the guest. Otoh I'd
kind of expect x86_emul_pagefault() to abstract away this detail.
Thoughts?

Note: While probably trivial to re-base ahead, for now this depends on
      "x86emul: a few small steps towards disintegration"
      (https://lists.xen.org/archives/html/xen-devel/2021-08/msg00367.html).

--- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
+++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
@@ -197,14 +197,11 @@ static int fuzz_read_io(
 }
 
 static int fuzz_insn_fetch(
-    enum x86_segment seg,
     unsigned long offset,
     void *p_data,
     unsigned int bytes,
     struct x86_emulate_ctxt *ctxt)
 {
-    assert(seg == x86_seg_cs);
-
     /* Minimal segment limit checking, until full one is being put in place. */
     if ( ctxt->addr_size < 64 && (offset >> 32) )
     {
@@ -222,7 +219,7 @@ static int fuzz_insn_fetch(
         return maybe_fail(ctxt, "insn_fetch", true);
     }
 
-    return data_read(ctxt, seg, "insn_fetch", p_data, bytes);
+    return data_read(ctxt, x86_seg_cs, "insn_fetch", p_data, bytes);
 }
 
 static int _fuzz_rep_read(struct x86_emulate_ctxt *ctxt,
--- a/tools/tests/x86_emulator/predicates.c
+++ b/tools/tests/x86_emulator/predicates.c
@@ -2049,8 +2049,7 @@ static void print_insn(const uint8_t *in
 
 void do_test(uint8_t *instr, unsigned int len, unsigned int modrm,
              enum mem_access mem, struct x86_emulate_ctxt *ctxt,
-             int (*fetch)(enum x86_segment seg,
-                          unsigned long offset,
+             int (*fetch)(unsigned long offset,
                           void *p_data,
                           unsigned int bytes,
                           struct x86_emulate_ctxt *ctxt))
@@ -2110,8 +2109,7 @@ void do_test(uint8_t *instr, unsigned in
 }
 
 void predicates_test(void *instr, struct x86_emulate_ctxt *ctxt,
-                     int (*fetch)(enum x86_segment seg,
-                                  unsigned long offset,
+                     int (*fetch)(unsigned long offset,
                                   void *p_data,
                                   unsigned int bytes,
                                   struct x86_emulate_ctxt *ctxt))
--- a/tools/tests/x86_emulator/test_x86_emulator.c
+++ b/tools/tests/x86_emulator/test_x86_emulator.c
@@ -594,14 +594,13 @@ static int read(
 }
 
 static int fetch(
-    enum x86_segment seg,
     unsigned long offset,
     void *p_data,
     unsigned int bytes,
     struct x86_emulate_ctxt *ctxt)
 {
     if ( verbose )
-        printf("** %s(%u, %p,, %u,)\n", __func__, seg, (void *)offset, bytes);
+        printf("** %s(CS:%p,, %u,)\n", __func__, (void *)offset, bytes);
 
     memcpy(p_data, (void *)offset, bytes);
     return X86EMUL_OKAY;
--- a/tools/tests/x86_emulator/x86-emulate.h
+++ b/tools/tests/x86_emulator/x86-emulate.h
@@ -113,8 +113,7 @@ WRAP(puts);
 void evex_disp8_test(void *instr, struct x86_emulate_ctxt *ctxt,
                      const struct x86_emulate_ops *ops);
 void predicates_test(void *instr, struct x86_emulate_ctxt *ctxt,
-                     int (*fetch)(enum x86_segment seg,
-                                  unsigned long offset,
+                     int (*fetch)(unsigned long offset,
                                   void *p_data,
                                   unsigned int bytes,
                                   struct x86_emulate_ctxt *ctxt));
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -1294,7 +1294,6 @@ static int hvmemul_read(
 }
 
 int hvmemul_insn_fetch(
-    enum x86_segment seg,
     unsigned long offset,
     void *p_data,
     unsigned int bytes,
@@ -1312,7 +1311,7 @@ int hvmemul_insn_fetch(
     if ( !bytes ||
          unlikely((insn_off + bytes) > hvmemul_ctxt->insn_buf_bytes) )
     {
-        int rc = __hvmemul_read(seg, offset, p_data, bytes,
+        int rc = __hvmemul_read(x86_seg_cs, offset, p_data, bytes,
                                 hvm_access_insn_fetch, hvmemul_ctxt);
 
         if ( rc == X86EMUL_OKAY && bytes )
--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -162,8 +162,7 @@ hvm_emulate_read(enum x86_segment seg,
 }
 
 static int
-hvm_emulate_insn_fetch(enum x86_segment seg,
-                       unsigned long offset,
+hvm_emulate_insn_fetch(unsigned long offset,
                        void *p_data,
                        unsigned int bytes,
                        struct x86_emulate_ctxt *ctxt)
@@ -172,11 +171,9 @@ hvm_emulate_insn_fetch(enum x86_segment
         container_of(ctxt, struct sh_emulate_ctxt, ctxt);
     unsigned int insn_off = offset - sh_ctxt->insn_buf_eip;
 
-    ASSERT(seg == x86_seg_cs);
-
     /* Fall back if requested bytes are not in the prefetch cache. */
     if ( unlikely((insn_off + bytes) > sh_ctxt->insn_buf_bytes) )
-        return hvm_read(seg, offset, p_data, bytes,
+        return hvm_read(x86_seg_cs, offset, p_data, bytes,
                         hvm_access_insn_fetch, sh_ctxt);
 
     /* Hit the cache. Simple memcpy. */
--- a/xen/arch/x86/pv/emul-gate-op.c
+++ b/xen/arch/x86/pv/emul-gate-op.c
@@ -163,6 +163,12 @@ static int read_mem(enum x86_segment seg
     return X86EMUL_OKAY;
 }
 
+static int fetch(unsigned long offset, void *p_data,
+                 unsigned int bytes, struct x86_emulate_ctxt *ctxt)
+{
+    return read_mem(x86_seg_cs, offset, p_data, bytes, ctxt);
+}
+
 void pv_emulate_gate_op(struct cpu_user_regs *regs)
 {
     struct vcpu *v = current;
@@ -205,7 +211,7 @@ void pv_emulate_gate_op(struct cpu_user_
 
     ctxt.ctxt.addr_size = ar & _SEGMENT_DB ? 32 : 16;
     /* Leave zero in ctxt.ctxt.sp_size, as it's not needed for decoding. */
-    state = x86_decode_insn(&ctxt.ctxt, read_mem);
+    state = x86_decode_insn(&ctxt.ctxt, fetch);
     ctxt.insn_fetch = false;
     if ( IS_ERR_OR_NULL(state) )
     {
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -1258,8 +1258,7 @@ static int validate(const struct x86_emu
     return X86EMUL_UNHANDLEABLE;
 }
 
-static int insn_fetch(enum x86_segment seg,
-                      unsigned long offset,
+static int insn_fetch(unsigned long offset,
                       void *p_data,
                       unsigned int bytes,
                       struct x86_emulate_ctxt *ctxt)
@@ -1269,8 +1268,6 @@ static int insn_fetch(enum x86_segment s
     unsigned int rc;
     unsigned long addr = poc->cs.base + offset;
 
-    ASSERT(seg == x86_seg_cs);
-
     /* We don't mean to emulate any branches. */
     if ( !bytes )
         return X86EMUL_UNHANDLEABLE;
--- a/xen/arch/x86/pv/ro-page-fault.c
+++ b/xen/arch/x86/pv/ro-page-fault.c
@@ -52,6 +52,21 @@ static int ptwr_emulated_read(enum x86_s
     return X86EMUL_OKAY;
 }
 
+static int ptwr_emulated_insn_fetch(unsigned long offset,
+                                    void *p_data, unsigned int bytes,
+                                    struct x86_emulate_ctxt *ctxt)
+{
+    unsigned int rc = copy_from_guest_pv(p_data, (void *)offset, bytes);
+
+    if ( rc )
+    {
+        x86_emul_pagefault(PFEC_insn_fetch, offset + bytes - rc, ctxt);
+        return X86EMUL_EXCEPTION;
+    }
+
+    return X86EMUL_OKAY;
+}
+
 /*
  * p_old being NULL indicates a plain write to occur, while a non-NULL
  * input requests a CMPXCHG-based update.
@@ -247,7 +262,7 @@ static int ptwr_emulated_cmpxchg(enum x8
 
 static const struct x86_emulate_ops ptwr_emulate_ops = {
     .read       = ptwr_emulated_read,
-    .insn_fetch = ptwr_emulated_read,
+    .insn_fetch = ptwr_emulated_insn_fetch,
     .write      = ptwr_emulated_write,
     .cmpxchg    = ptwr_emulated_cmpxchg,
     .validate   = pv_emul_is_mem_write,
@@ -290,14 +305,14 @@ static int ptwr_do_page_fault(struct x86
 
 static const struct x86_emulate_ops mmio_ro_emulate_ops = {
     .read       = x86emul_unhandleable_rw,
-    .insn_fetch = ptwr_emulated_read,
+    .insn_fetch = ptwr_emulated_insn_fetch,
     .write      = mmio_ro_emulated_write,
     .validate   = pv_emul_is_mem_write,
 };
 
 static const struct x86_emulate_ops mmcfg_intercept_ops = {
     .read       = x86emul_unhandleable_rw,
-    .insn_fetch = ptwr_emulated_read,
+    .insn_fetch = ptwr_emulated_insn_fetch,
     .write      = mmcfg_intercept_write,
     .validate   = pv_emul_is_mem_write,
 };
--- a/xen/arch/x86/x86_emulate/decode.c
+++ b/xen/arch/x86/x86_emulate/decode.c
@@ -34,8 +34,7 @@ struct x86_emulate_state *
 x86_decode_insn(
     struct x86_emulate_ctxt *ctxt,
     int (*insn_fetch)(
-        enum x86_segment seg, unsigned long offset,
-        void *p_data, unsigned int bytes,
+        unsigned long offset, void *p_data, unsigned int bytes,
         struct x86_emulate_ctxt *ctxt))
 {
     static DEFINE_PER_CPU(struct x86_emulate_state, state);
@@ -618,7 +617,7 @@ static unsigned int decode_disp8scale(en
    generate_exception_if((uint8_t)(s->ip -                            \
                                    ctxt->regs->r(ip)) > MAX_INST_LEN, \
                          X86_EXC_GP, 0);                              \
-   rc = ops->insn_fetch(x86_seg_cs, _ip, &_x, _size, ctxt);           \
+   rc = ops->insn_fetch(_ip, &_x, _size, ctxt);                       \
    if ( rc ) goto done;                                               \
    _x;                                                                \
 })
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -357,7 +357,7 @@ do {
         ip = (uint16_t)ip;                                              \
     else if ( !mode_64bit() )                                           \
         ip = (uint32_t)ip;                                              \
-    rc = ops->insn_fetch(x86_seg_cs, ip, NULL, 0, ctxt);                \
+    rc = ops->insn_fetch(ip, NULL, 0, ctxt);                            \
     if ( rc ) goto done;                                                \
     _regs.r(ip) = ip;                                                   \
     singlestep = _regs.eflags & X86_EFLAGS_TF;                          \
@@ -2301,7 +2301,7 @@ x86_emulate(
                    ? 8 : op_bytes;
         if ( (rc = read_ulong(x86_seg_ss, sp_post_inc(op_bytes + src.val),
                               &dst.val, op_bytes, ctxt, ops)) != 0 ||
-             (rc = ops->insn_fetch(x86_seg_cs, dst.val, NULL, 0, ctxt)) )
+             (rc = ops->insn_fetch(dst.val, NULL, 0, ctxt)) )
             goto done;
         _regs.r(ip) = dst.val;
         adjust_bnd(ctxt, ops, vex.pfx);
@@ -2822,14 +2822,14 @@ x86_emulate(
             break;
         case 2: /* call (near) */
             dst.val = _regs.r(ip);
-            if ( (rc = ops->insn_fetch(x86_seg_cs, src.val, NULL, 0, ctxt)) )
+            if ( (rc = ops->insn_fetch(src.val, NULL, 0, ctxt)) )
                 goto done;
             _regs.r(ip) = src.val;
             src.val = dst.val;
             adjust_bnd(ctxt, ops, vex.pfx);
             goto push;
         case 4: /* jmp (near) */
-            if ( (rc = ops->insn_fetch(x86_seg_cs, src.val, NULL, 0, ctxt)) )
+            if ( (rc = ops->insn_fetch(src.val, NULL, 0, ctxt)) )
                 goto done;
             _regs.r(ip) = src.val;
             dst.type = OP_NONE;
--- a/xen/arch/x86/x86_emulate/x86_emulate.h
+++ b/xen/arch/x86/x86_emulate/x86_emulate.h
@@ -254,13 +254,12 @@ struct x86_emulate_ops
 
     /*
      * insn_fetch: Emulate fetch from instruction byte stream.
-     *  Except for @bytes, all parameters are the same as for 'read'.
+     *  Except for @bytes and missing @seg, all parameters are the same as for
+     *  'read'.
      *  @bytes: Access length (0 <= @bytes < 16, with zero meaning
      *  "validate address only").
-     *  @seg is always x86_seg_cs.
      */
     int (*insn_fetch)(
-        enum x86_segment seg,
         unsigned long offset,
         void *p_data,
         unsigned int bytes,
@@ -750,8 +749,7 @@ struct x86_emulate_state *
 x86_decode_insn(
     struct x86_emulate_ctxt *ctxt,
     int (*insn_fetch)(
-        enum x86_segment seg, unsigned long offset,
-        void *p_data, unsigned int bytes,
+        unsigned long offset, void *p_data, unsigned int bytes,
         struct x86_emulate_ctxt *ctxt));
 
 unsigned int
--- a/xen/include/asm-x86/hvm/emulate.h
+++ b/xen/include/asm-x86/hvm/emulate.h
@@ -92,8 +92,7 @@ static inline bool handle_mmio(void)
     return hvm_emulate_one_insn(x86_insn_is_mem_access, "MMIO");
 }
 
-int hvmemul_insn_fetch(enum x86_segment seg,
-                       unsigned long offset,
+int hvmemul_insn_fetch(unsigned long offset,
                        void *p_data,
                        unsigned int bytes,
                        struct x86_emulate_ctxt *ctxt);



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237432.411815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6t6-0004hV-2D; Fri, 03 Dec 2021 11:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237432.411815; Fri, 03 Dec 2021 11:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt6t5-0004hO-Uu; Fri, 03 Dec 2021 11:37:59 +0000
Received: by outflank-mailman (input) for mailman id 237432;
 Fri, 03 Dec 2021 11:37:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=aSTI=QU=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1mt6t3-0004hI-MZ
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:37:57 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0621.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::621])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 74e99da1-542d-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 12:37:56 +0100 (CET)
Received: from AS8PR04CA0074.eurprd04.prod.outlook.com (2603:10a6:20b:313::19)
 by DB8PR08MB5531.eurprd08.prod.outlook.com (2603:10a6:10:11e::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 11:37:52 +0000
Received: from VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::1c) by AS8PR04CA0074.outlook.office365.com
 (2603:10a6:20b:313::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 11:37:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT063.mail.protection.outlook.com (10.152.18.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 11:37:51 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Fri, 03 Dec 2021 11:37:51 +0000
Received: from 36628c90befc.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2CB0E46D-8118-4F5F-8807-0FB156956B6E.1; 
 Fri, 03 Dec 2021 11:37:42 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 36628c90befc.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 11:37:42 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB5896.eurprd08.prod.outlook.com (2603:10a6:20b:294::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 3 Dec
 2021 11:37:41 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::69d7:e26:6610:ebd8%4]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:37:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74e99da1-542d-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ojA+V2sFIMFVxJ+V0ettajToh0xyk9noTUR9uY9+agQ=;
 b=7LTU5Novq8zumt+zntdafG8vsYznkhPOrqLCr6ZM1NE0QzEFSgSuDyrj5C8eRrzgwTk6PhM0TEWIwQvULn0k+vqvgAd7KmmnzA3AWFBdUP1HfWgOnetQcf5u6v1bE/10NAXRQI355fYpUbYj9PEWxehp5Oco/HIjs8JCEDY6Brk=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 2071fc8ef9a972d0
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NbHr2arcZbIr9qgUlPqJOWtagrAqYfTl6imyrwgIBfNVa6zuwBnQLfyz4YvdvFQ0sj95D9ob8RShxysCxFe3ccRre7FXE+G9lq52ISg2Kqsf68cRZwKiudNzsHqld72U3xheaDwZ43PTNqwfthg4Ky70ZBkdTkYA9E7iGciTY87yE6ez9G8H9N9ayqDSymCwOeIZgRfKhEWptCI5iRUSRzouAAFEtk5HTaJvf44kl6MSldLYXP0ZbxGp8QNgt92fFLhY62WmJ4MLJyTB5RP6XxY8RdGFXWzcSMaiWjj5ikzBUqYZpezg363jRAKNTbFdZji8i1+E3CjkgZxDvABpFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ojA+V2sFIMFVxJ+V0ettajToh0xyk9noTUR9uY9+agQ=;
 b=HiZl+IR8M0PprKc0fAYDGphWB61W0GP+m7PduyppIZbriYUUl1kOKjtSlXv1pEIolU9ASFvG8RCh6t5xtoYYHL3hzCRCjgPYURJY9pyQJnHyhGQRMewiV77qnktRW9BeQSX9KHHwH4lTZ0yV86raIF70JIvcXbqBZ8bU4rguwSJEYoQanu5foUzYavdLRf5ChhDFQOOT8qydmdttJl95OUxvvrBVlo0BueeYcQVXNv3uk6e75azg29Aho1AlPgmFSJgcBEUPzqPFh46b8S+wCL8SyJ3EGWOUCiP3E/gk0KJwuUU8DAF3oEyU1fnyhca/cYj6tfCbngm8Guu9qpuUcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ojA+V2sFIMFVxJ+V0ettajToh0xyk9noTUR9uY9+agQ=;
 b=7LTU5Novq8zumt+zntdafG8vsYznkhPOrqLCr6ZM1NE0QzEFSgSuDyrj5C8eRrzgwTk6PhM0TEWIwQvULn0k+vqvgAd7KmmnzA3AWFBdUP1HfWgOnetQcf5u6v1bE/10NAXRQI355fYpUbYj9PEWxehp5Oco/HIjs8JCEDY6Brk=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
CC: Michal Orzel <Michal.Orzel@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
Thread-Topic: [PATCH] arm/vgic: Fix reference to a non-existing function
Thread-Index: AQHX6CxjOPaugM9lo0aVspePzsZYTqwgjh6AgAAR9gCAAAPtgA==
Date: Fri, 3 Dec 2021 11:37:41 +0000
Message-ID: <D7D0ADA8-E650-4FE2-B8B4-D68D2FA0201A@arm.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
 <B3D7A1CC-6CEB-45C9-914C-6BF5540EA1BE@arm.com>
 <fa4c0e20-3640-e948-a39d-42c80aa40e9b@xilinx.com>
In-Reply-To: <fa4c0e20-3640-e948-a39d-42c80aa40e9b@xilinx.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: f28c8faf-72e1-4c60-c03b-08d9b6515703
x-ms-traffictypediagnostic: AS8PR08MB5896:|DB8PR08MB5531:
X-Microsoft-Antispam-PRVS:
	<DB8PR08MB55310C78D406E54EB07C477E9D6A9@DB8PR08MB5531.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 282ekoGbKo92kv/W+jKH7R4hdfKUXG4PJz+4ghs4TmTR0t3szzaUkaegg8mUq4UEihCCBzgmjFKvIlp92mkDMlSlHjYQNbuxb3sEzUpvANKDpAZuU//4+t/95ZHmHZEsIoPm0++YMj8Zmw1OtXDKbcNazB4ZqAln/UuRHvKWW3QMKS/RAhVw24jcLv9HoWf6d2TadzqVNjKcmI93SYAKtgq93xpA5/wKSnD5OSBUnLz/pxCS+FCpTcJaCW5tR3Ty//Py6z8xWv7Vq+pLG7szmGxsS4QteXe89yGSKAQ0WCh8nR/yayEQq0o5AK0YcO1aeDPifgYZUmY8B4hMPR/tNv/8961A3giUXeFPTPz1b1W8Jl6MTUQLA/OZ7n1cFUtAhn893l2kG5C6HdHKzFEpqd2xXjVjnT0jlZ6HvUnke7ZXNLjNKodtJ4flBsNXE2t+QAGf0n2PKbFLuu2mALgXSODGgUBxTWhBfY/IAZWJI3FE7TFUViaDqWxhGj27XOtyQOG0Eo/l4Edce5ZL1CHJcQtCPbCwph3HrdUwPJSwpnvtq6xJyan0Fy6orm92AaiYIDethE4N3buitBdcIUv8LgZENYRZzPuPmXgVVozzLGO26PztvVaZ4emSTARFY/UEarg+8+MWqSTKXKWpoO0/TH/FGMBU/XhfDCbo+d1jG/VQGW/xiutc2DcSWfouqdU3sKCY77sSw3wb8Qa2am/TGG7K9ekIZkOTWktIoEvSPpM48qtV72wNoax4EtQQWMzD
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(71200400001)(508600001)(6506007)(316002)(2906002)(86362001)(66556008)(38070700005)(36756003)(8936002)(33656002)(4326008)(5660300002)(66476007)(64756008)(8676002)(26005)(6512007)(66946007)(76116006)(91956017)(83380400001)(66446008)(38100700002)(2616005)(122000001)(6486002)(53546011)(54906003)(6916009)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C450AA42084EC54C9038A967EE0113CE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5896
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1f429616-d202-43ea-9991-08d9b65150be
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TdDcuT0z3rT7PgfGocgWSivdKr/XZG+RRn7GXub+cVrcsCTCKfrgHXejZzyTHO1XdhYfUFBdSl655d8JrwnkCfY2hIdbeHSGDeN5xePDvlQMvfd72jRhRVwZP+lD9dcjAk5AnsGpaNWTQmifZ3tH8QwdxnkZ0pFeYyaPnZxwgylZ7eJf2m/LO1NbGavMKDMmOLa/J6HDzBN0uiv67GMZxaGaYJ5Ub39RXAFf+uAnTpGATqEBBOtaCCIXuwE1CY+X5k59RxGrO4oenpak+rsQ1MTvw/PLPRxRCMgLkGUPu3hHArE8GzHgC8JXxW4RYJPlvSVQn71mxt21oGLpPCAfHdf+L7+2Rn0a2mRFVpSGhxy85d8StIEETPHJm8xDhAeA2C4n3UsQwIWmID4VZFodetpbBvUdXa3jlRX0GEpBLNOv6LY6xOe+iHn18Vyu4t/GoAXHSuY7WpXfhsHyPegzcc2BWmV3zSo0EtsIH/DIKAycaru0G7qj/0iGC/BLRMa/nMP7yBKgm1krgFwx3chSA0UbA5hST4GIaVqNk6hfwuzmlr1vMZamIn5wBTpfWoEdscHZhsAdcMuafQ/DPIQ5YIsFsq9gLGFJmHO3cPv2417nMsxXVS0OKQc986MVxtqUYGcgJwnxxnCwRZTIz9JupuwCSmQ4g+6L+qqRqgw42colUouka5xB2m6AVmbIT+mwHTqYAWTFvLZwJaCNxkmE1g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(36756003)(70206006)(6486002)(83380400001)(4326008)(33656002)(81166007)(70586007)(6862004)(53546011)(356005)(54906003)(47076005)(107886003)(6512007)(2616005)(508600001)(336012)(5660300002)(82310400004)(316002)(86362001)(8676002)(186003)(2906002)(8936002)(6506007)(26005)(36860700001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:37:51.7011
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f28c8faf-72e1-4c60-c03b-08d9b6515703
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT063.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5531

Hi Ayan,

> On 3 Dec 2021, at 11:23, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>=
 wrote:
>=20
>=20
>=20
> On 03/12/2021 10:19, Bertrand Marquis wrote:
>> Hi Michal,
>>> On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@arm.com> wrote:
>>>=20
>>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>>> forgot to modify a comment about lr_pending list,
>>> referring to a function that has been renamed.
>>> Fix that.
>>>=20
>>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>=20
> Bertrand is very fast. :D.

To be fare we are working together with Michal ;-)

> I wanted to check if it is ok to add my R-b.

It is always ok and welcome if you feel you understood and check the change=
 and it is ok for you :-)
There is never enough reviewers.

Cheers
Bertrand

>> Thanks for that
>> Cheers
>> Bertrand
>>> ---
>>> xen/include/asm-arm/vgic.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>=20
>>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>>> index e69a59063a..ade427a808 100644
>>> --- a/xen/include/asm-arm/vgic.h
>>> +++ b/xen/include/asm-arm/vgic.h
>>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>>      * corresponding LR it is also removed from this list. */
>>>     struct list_head inflight_irqs;
>>>     /* lr_pending is used to queue IRQs (struct pending_irq) that the
>>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) b=
ut
>>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq)=
 but
>>>      * no LRs were available at the time.
>>>      * As soon as an LR is freed we remove the first IRQ from this
>>>      * list and write it to the LR register.
>>> --=20
>>> 2.29.0
>>>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:48:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:48:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237441.411828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt73Z-0006MW-0l; Fri, 03 Dec 2021 11:48:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237441.411828; Fri, 03 Dec 2021 11:48:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt73Y-0006MP-U2; Fri, 03 Dec 2021 11:48:48 +0000
Received: by outflank-mailman (input) for mailman id 237441;
 Fri, 03 Dec 2021 11:48:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt73Y-0006MJ-C8
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:48:48 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f91214d1-542e-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:48:47 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50940)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt73W-00014v-h5 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 11:48:46 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2FF751FD7A;
 Fri,  3 Dec 2021 11:48:46 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f91214d1-542e-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <c375875f-0a21-e02b-6a2b-63ab91451373@srcf.net>
Date: Fri, 3 Dec 2021 11:48:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/3] x86/HVM: permit CLFLUSH{,OPT} on execute-only code
 segments
In-Reply-To: <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 11:21, Jan Beulich wrote:
> The SDM explicitly permits this, and since that's sensible behavior
> don't special case AMD (where the PM doesn't explicitly say so).

APM explicitly says so too.

"The CLFLUSH instruction executes at any privilege level. CLFLUSH
performs all the segmentation and paging checks that a 1-byte read would
perform, except that it also allows references to execute-only segments."

and

"The CLFLUSHOPT instruction executes at any privilege level. CLFLUSHOPT
performs all the segmentation and paging checks that a 1-byte read would
perform, except that it also allows references to execute-only segments."

> Fixes: 52dba7bd0b36 ("x86emul: generalize wbinvd() hook")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

With the commit message tweaked, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>.  Far less invasive than I was fearing.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:49:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:49:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237445.411839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt74X-0006ur-Az; Fri, 03 Dec 2021 11:49:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237445.411839; Fri, 03 Dec 2021 11:49:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt74X-0006uk-8D; Fri, 03 Dec 2021 11:49:49 +0000
Received: by outflank-mailman (input) for mailman id 237445;
 Fri, 03 Dec 2021 11:49:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt74W-0006uW-98
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:49:48 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ce86d7e-542f-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:49:47 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35060)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt74U-000ToG-7j (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 11:49:46 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 285AE1FD7A;
 Fri,  3 Dec 2021 11:49:46 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ce86d7e-542f-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <3452b90a-c2f5-168b-9f3e-10f8655c4cde@srcf.net>
Date: Fri, 3 Dec 2021 11:49:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] x86/HVM: fail virt-to-linear conversion for insn
 fetches from non-code segments
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <46fdafdd-d6a9-778b-d634-fad8d2f6925a@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <46fdafdd-d6a9-778b-d634-fad8d2f6925a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 03/12/2021 11:22, Jan Beulich wrote:
> Just like (in protected mode) reads may not go to exec-only segments and
> writes may not go to non-writable ones, insn fetches may not access data
> segments.
>
> Fixes: 623e83716791 ("hvm: Support hardware task switching")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 11:56:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 11:56:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237454.411854 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ak-0008Lc-41; Fri, 03 Dec 2021 11:56:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237454.411854; Fri, 03 Dec 2021 11:56:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ak-0008LV-0e; Fri, 03 Dec 2021 11:56:14 +0000
Received: by outflank-mailman (input) for mailman id 237454;
 Fri, 03 Dec 2021 11:56:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7Ai-0008LP-BB
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:56:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd770355-542f-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 12:56:03 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-VGXj-yWUPauVY41QXSOpuQ-1; Fri, 03 Dec 2021 12:56:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 11:56:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 11:56:00 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0042.eurprd05.prod.outlook.com (2603:10a6:20b:489::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 11:55:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd770355-542f-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638532563;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TKi+PArMQpts+Kuwfjj5NwY3kQsFfC1paZ0n+CyD3jU=;
	b=dtVW56+dgieow9+jCnO6rQuYdk19GwqcKa8v2eDr8mpu3lQ/bh0Hq+W4Dn2rt0IETGJmtg
	XmcZAoj+kUDIuD9WS5bHlOlkLeEz+S8grEexIn9BMAsyqR+viCU7WQNsmdGKqbIDh5wnVl
	aMCioByxC0tfi3B7HZXs9TeLiHvgyRE=
X-MC-Unique: VGXj-yWUPauVY41QXSOpuQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LXpJYtAYhzw0CWJAq4mSvPzLrfq9+MEFpvGPsNfXmRQGAdCnhc8VY+57CHWE/DhWfjtQKVbdwsZQBA4sYYPhOJKH3kXBVOtjWywx28hJDVJQ6euVs/g4aoblWnLda4aaTdU2Cp5AFglXmWBgxDcvRKk62KLgYRFe3ZXbzgolZ5lB8zb1O3W1eZQXFaLh8JzCT27gXTuoG4k3zABKq05Hj+C4HwCO9/ZTII1zRb0KtO+5iSKRKf44vgGUeJY/NV5BH5oFPH7x31gkAmYcs3jNgV6GYrcKMkWVqFc2dQDMR9g2Ujz0k17l+cgfuwKvj6cs7QvZ2sqzc4arackn3AsCrg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gVXn41K2c2U1kGH5e7upCj/T3lY72QTk8lKOWSWrFDY=;
 b=YKdCYMxeHqxHaWiItMiEODWFbgchR29nHb7eFjEZSEOHg1VC4PiyyLcw96m2hkCp2r3tcqNFDnaOjSP1itSbYp7P7o50hTDRL7+D8xbnBkOUSp7QBsN259a82T1Cv8hUMxXIw5xWiaN2lPy2TilscjkW9QY7h+YU89vzfuh0/6NQFUIBkOtta4G5UYfD2+EkEV6XQ3qfNl9p9Pq42iE29iop6bkKA+EG3H0WUmasMwlZ1FH/woBHmeGOdIyAV8i4HZtrJhjZNOtHJMEj1pvE/3ypmO8ObmToJnDLrbRywEta1C50LVDgBWbIhl0n7/1Mg4urwQW3DbVWbQfocFI0Ug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bb2f1d15-199c-b7d9-5a3e-70563e927cbf@suse.com>
Date: Fri, 3 Dec 2021 12:55:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] x86/HVM: permit CLFLUSH{,OPT} on execute-only code
 segments
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
 <c375875f-0a21-e02b-6a2b-63ab91451373@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c375875f-0a21-e02b-6a2b-63ab91451373@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR05CA0042.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2387f8d3-8b32-46db-69ea-08d9b653dfbf
X-MS-TrafficTypeDiagnostic: VI1PR04MB2960:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2960B2915A5F8FF555E15A51B36A9@VI1PR04MB2960.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LzpDjFDNy/4tgrj/jWh92R5/kYpAb3IBwVOGLx86mJFkT9FJ/hztXG8ScOkamFKjfWVXHPUSzFE7GqEuHzmWUUKORB9ETROTixbl2AHiG+trXM8g4DlUKJUMmQgTqgQP6VOiy+U42p+YrlXjCcqccteN+wl6GIvaLVuAFrzyqY10Lm2HOpZLS7zm3v6M2q2FJjbKE8X5Lte1q4NuFUef8a38rWMiH28kApsoQV2w9UzZEVMc8ar4R3S2BgaxeA4osfUeTocsK029a7amIubfBtzbcg1OHBaTUFGv8L4wpBp3srCjil3Dj0Ykx6sP+6rLosG8WtBUT4oVy887t59vkcDufnn5ze36mOBcNFJgnqmPj0QGWDmPzL7pYxnsFb8qrytMXCJH0LPAFZkDLXf+HDcWFbbS4RnqYqR4WWlUrZ8AknPXcEQ8YJpBawII8j8JmKIMytTIb8le3kNsiZCLLMIdKyXWEVxTr2Tp+jYW8zmQaSiBXrYLX/Lg4iPkrnhhoxHoKesWlQMeNovTTywiEQHKDbD+Ciaiw3Lx1qnrUcYhfgrpP8tuLtW+vzSs8o8EnxTezPZ5fk4O866n7aqU5VdQHd6c+2F0tVjfSLoWoawEb72VudBaxJEGDewp+ZLeoz9gNx4HbZqKxyxmcXz8QBnznTXbj/NLLndPMfrADhvbFFTAnLPIe1cUywM45ghVniqUCIof8WYRLg7Xf2E3fIQKe1wnwOelIx4R8aYST44=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(26005)(2616005)(31686004)(31696002)(38100700002)(316002)(54906003)(8936002)(16576012)(110136005)(186003)(8676002)(2906002)(36756003)(53546011)(86362001)(83380400001)(4326008)(6486002)(66946007)(508600001)(66556008)(5660300002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kWzOjoPjPX0iNZIVtTuV11+kd8VdY1KJWOfOTHUoev8lhZGSRUWoPlmb53cS?=
 =?us-ascii?Q?pYYWgjvmUj1LQT5zv9C8VlDElR3IYRC10xpSyaduojVBY56nGDUYGgrE6cdR?=
 =?us-ascii?Q?F2DgZSFAXrfXMEMAi1ECFDsJe6uJ1nk2mK1xcHGISsz4vdrvjICJNC5pxlQa?=
 =?us-ascii?Q?Vdq2EvoHSCJIDbeMvaCEkxebL/ft1blXuP9GRMQARUJEzcZnQSQ2OcwJxQ6X?=
 =?us-ascii?Q?2tA3DO32//+7D2eq6h8QxFvcpAuMrRU0lpzQQ03Zb9BE6vSEtBYKi+VXT4Em?=
 =?us-ascii?Q?Jf14Glxqop/24YxeHyqFfx1Nf+kWiswQEur2PwIhEX9HtfR5c/n3vt25W0+L?=
 =?us-ascii?Q?3o1lml7KWlLu3lDhDkq6lKxfOOh85FAjdnr8wCF7N+GwqtkeAs7CIOdSFKLg?=
 =?us-ascii?Q?9MJSOY+8vRs0g64CK5dH9KYMJ4HzcujyCWSznJpWld5XkrjiXYSErcmSIYxm?=
 =?us-ascii?Q?jpK+ae/mHcXpfpTZywIQ1rKQivBcVnb+2ILfR/m/6NfZvmWMUbfP+SaV2cHi?=
 =?us-ascii?Q?vYe2cr8illbAejM0fJT+IrE12rK5kcJDL0Xe5h922zXZymlwcVzb8wF4Vm3N?=
 =?us-ascii?Q?cb5auQ2KkL07dzzj8AcBFRNDVtM1f169onuW/J77l6NbkVdG7O5iobMVbUJm?=
 =?us-ascii?Q?ZTUPo5lK74JnwPWnx4yKpS6sVAERmkAptGyqXKo2JpspQd+wF0ooFWVC6GrF?=
 =?us-ascii?Q?CYa29NjuBfCffu9avNwbgCtjNahchzUa8PM0B/ib2KyS1xwU+gRcZuUy8joA?=
 =?us-ascii?Q?rodg1Gxp+58q2h4MW8NhkjsjZdvoN1ylmBUJdIeAH3TWkA41rJ6NQi3EidkI?=
 =?us-ascii?Q?uJl++C3ZOcB/VHWdio1b9xdJoCgAZKq7mNLWAy4Q2NnW7fCePRUbZU6dtedB?=
 =?us-ascii?Q?0XFOSISN8svygGLpHGfikKiLGjxuDo56ApiIaWBxi7UmnppYc6gGedzj5qXK?=
 =?us-ascii?Q?4XL69+YUgdBDpyxe4fxK7Kz2zMWlk6PwBI47HPe/v4QPeF1bsnOkWlXWDUAR?=
 =?us-ascii?Q?55JQsuYpoy5vFAHxmfjArfZ0xjXkXlXAZUzi2NPOUi5Emx74sBFvAU3C1vnS?=
 =?us-ascii?Q?0TEg8VaC4+7jVcKXB9HnODUrYJGMVbcG5NkHdPAU46TlGfeYW8SRgjNf7bz3?=
 =?us-ascii?Q?APgvQZ/FL/+v0fFHyqnzUEqBzcMZGs53E0q39+RSTNhUUMKQ+Net7xLQg3x/?=
 =?us-ascii?Q?Tcaz2fJX8SuQbo7ElSRZKUIo/mh5WgC5qZpg5NvWIFju1PxyHC9dNxnvQI6Y?=
 =?us-ascii?Q?6OlwncJGj/MF8XI36CjZqmvx3t+XgBk8YMaHj6LZlUCc2DGk7UjTX/7m4RU8?=
 =?us-ascii?Q?NxuIQSNwGBdLkzvpQi5jAOuWlT+uPa/J3+rjht2/1nufb+hOj/CQdpr+vYbX?=
 =?us-ascii?Q?+245YNrh7nIs3i+Wkslg97+y8jT1PNS6+GEXjr71wjcdG68Exj0aoIT9UBl8?=
 =?us-ascii?Q?N3ej232OI8jpcZ1jMYOmEsxDdphvySklhMsoZGyE9J6M+eEIJE9GF6AEThLM?=
 =?us-ascii?Q?J4DD+NRNBbTSMOcGjtIaN7BWXKVqBBlMI/jtRtcD2jPTVt9cnek1fonRrXKu?=
 =?us-ascii?Q?ke5KcPGPn4urAzXIJ4Zphf/S9A+oErd6bf0XX/QOWg1hjccqcbKgQsVThNuG?=
 =?us-ascii?Q?ZSb/EAAAiUp+i5khAAq9FB8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2387f8d3-8b32-46db-69ea-08d9b653dfbf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:56:00.3239
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gIjKiehfxsYSjD5Ua8lM6u0hV1YJAoKlt6XMB11IojnARgqjwSq/usUcu7HkdvGXoxu++q0LmIMBpzfMupu2zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960

On 03.12.2021 12:48, Andrew Cooper wrote:
> On 03/12/2021 11:21, Jan Beulich wrote:
>> The SDM explicitly permits this, and since that's sensible behavior
>> don't special case AMD (where the PM doesn't explicitly say so).
>=20
> APM explicitly says so too.
>=20
> "The CLFLUSH instruction executes at any privilege level. CLFLUSH
> performs all the segmentation and paging checks that a 1-byte read would
> perform, except that it also allows references to execute-only segments."
>=20
> and
>=20
> "The CLFLUSHOPT instruction executes at any privilege level. CLFLUSHOPT
> performs all the segmentation and paging checks that a 1-byte read would
> perform, except that it also allows references to execute-only segments."

Somehow I didn't read further after the page table related paragraph,
perhaps on the assumption that like in the SDM it would be all in one
paragraph.

>> Fixes: 52dba7bd0b36 ("x86emul: generalize wbinvd() hook")
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> With the commit message tweaked, Reviewed-by: Andrew Cooper
> <andrew.cooper3@citrix.com>.=C2=A0 Far less invasive than I was fearing.

Thanks. I've switched to simply saying "Both SDM and PM explicitly
permit this."

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:02:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:02:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237474.411864 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Gs-0001sK-79; Fri, 03 Dec 2021 12:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237474.411864; Fri, 03 Dec 2021 12:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Gs-0001sD-44; Fri, 03 Dec 2021 12:02:34 +0000
Received: by outflank-mailman (input) for mailman id 237474;
 Fri, 03 Dec 2021 12:02:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7Gr-0001j7-94
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:02:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e54fe0ba-5430-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 13:02:32 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-7QzOhWvPPaqZ02oowxjW6A-1; Fri, 03 Dec 2021 13:02:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3389.eurprd04.prod.outlook.com (2603:10a6:803:b::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 12:02:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:02:29 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0057.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:02:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e54fe0ba-5430-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638532952;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=XwL1PPN+OeXKousOQd5DQY904fspE25C/YY29dKe/go=;
	b=C4Qyxrye/t1DMGdoYH2bb8rtP5u168gAYxer0u+MTwiZ+p9tMs3Yu/VdDQgDY1lIinIRJV
	F5wuGXi+QcMJe4AUOKB5/HdxE16/9TeMfD04+7dpC7+ZJiGyMSlhBZ8CWSpATUivVzgZJu
	KaP7R3xXzKKmA8j+2hv5BDDJv3ZaEEg=
X-MC-Unique: 7QzOhWvPPaqZ02oowxjW6A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Oz6yOPcBJe7L9xsSS8sQTlyUWMLuFAk9t51j2B3e6LK0YcY2McQdxPIz7+xVnVGyga3pSSEiv/PspsT44gQLSqcvgdiMEArrw4sv5SN4bRFyrU1Nw5hTrXuNtGQ+mB65++SP1mrVX4GrmIHNe7sPI0OWiVpjtozUMDk/L+QyAOd4/1pP76A/GMIJhhy80vastLxru6iQ3Hdo2ZAbdEY6+LEaXVf1rlibvO0pBp2JDFjsO6Gyg2yNW9IoB528gFCJwv9d8qb7s50SHXknryVrcS31q+8oaakT49DiocAn3ZXSRZe4FihihMyqHeIf+oK5QA+DgufEOeDJ+uJsjSxxBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WZwSn5ClLjz4JbfN8SDAIvbVfOtrJs/h4s8ZhYOz1jQ=;
 b=BNJoUgpamKqzP5ZqTmYar/2Jw3reJSN6FzSGaQA+TIRGVTIm9WWfMT4bvMe63llzI25BF3nGPpW7kJm6vqLIqAZE9cElp9IJO3aSTuIt0GZXAA5L7nsJwmUQH3XLdH7yRmMdhFhNQ/zNVr6aVeiP2JnjwG+pp0gwmp8YKR3khZMm+2Ql9gqSwd7sY8N46riBN67G/q29dFbo9Sufz2P1cXZZEmVvMpY/6oA7KCdqehTmAAn4vCUpd4FcppewybOoTQfbYEUoVpVQ3kdt6xPuuqyBQKUWC8n8iOs/YNcPLy+kKti4q8AiOTSSMNXm3WvuyNoZKWhY2OoP8pgHYR/eWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Date: Fri, 3 Dec 2021 13:02:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/5] perfc: assorted adjustments
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P194CA0057.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:84::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2cdf33a9-a14b-481e-6ac1-08d9b654c7e2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3389:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33898DBC7622AC9C15BB6301B36A9@VI1PR0402MB3389.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o1Rqtmky/acIg6IFWVpC2i0SGS3xU2sGuPrdUTfSYYAO6CQUVgNYe0YTSrkHBdtGtUMM2Tv7K5Ft17P6uKwFf1yt4au9DI3ZN1ICvfAamrvpIQ0yQZVQVOKzNdCh3vCLzkmv+HAxxByQ7evZbs4M/l6bz8irXtjk/pGUSVBAC6aLG/ZVm4nywbDCgBNYulZ7aEaiN5SLWnduBPGAwFC5NluUamWmBbqQnLykKwDT7TbCX4eaW9P3Tu5mwHnkGs1NHJzkN7f3msMNfiVhfVaz9hMh6fa+QfYyjK0djIYl1mLryc0xyf/1IrrIZP3DERVK5ScEZfxCHVfza67ixWyPWHA1mGFYgT4e+/y5bdhQGkbiZ9bzMlwb9VRdDdQFNv7SBpr18W/q5e7QnxEI6M1AE8qURZYzH9PhjA+hQqdJLyRH7MECNKxOc3ErVx0TYSwiUY1HUSr6bA/eD42YmIO7+pqutjIvg8jFAbaKvPnxDdkMxCCl5KyT8xTKR8lLPdz4moR5hHlouNDJjgz8b7IIZgMNd97zJ7tDOmjx1hJCtYEkvZxnRutmCNJGG2yePqmBxqMprf69hN0VH2JKWbJQ40P5qEMuEnlbSZc5fZ3NbIIUZJPsqhTX9ybhi9L7ndZ8ILbto7N2V67ks5Ef3anqTEgmPuNJOVOyRw3yUWqYsxtFFUhyZt/KxvM5J+nX8YYJvVCVhyVBsxQWEv3rZqhyQwFJF+n6LGpoocdq8F02w1E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(66476007)(54906003)(66946007)(66556008)(8676002)(508600001)(316002)(38100700002)(5660300002)(186003)(16576012)(8936002)(26005)(2616005)(956004)(4744005)(31686004)(31696002)(4326008)(86362001)(2906002)(36756003)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rSP6t1V4hTjqw5ieJE6hn5PGwtwmNw1YsNZuA7RHld2AtcjWEH1XaCxF0cyN?=
 =?us-ascii?Q?62D6jU/5unMFFKPuBjmmE3IMvxbLztDrRIAp0QhjdvTpiAZ+w2RWQWF4eA5A?=
 =?us-ascii?Q?E7lOptSVzA4p2evck6Cflsd0VaMXQ+Fi35Lwdmxpg/RLWE8h5J6kj7KC8+lA?=
 =?us-ascii?Q?/K8fGOplVApUPI0Wr2DgKd4t8Lfn+Qm77KMiU7TAaQIrXeG5Ko+v8otlL04V?=
 =?us-ascii?Q?q2dzjeQedmNgcloMCbH6UoolEQDhJk1nbxAi/SXh1L6jpdeq1gTZ+Bqgicj3?=
 =?us-ascii?Q?wtd9m7rrvtKxRwGn0RAoXFg+E8IlzOKEZHYJOSGoSKvqlL6WgoXuGFS4BArK?=
 =?us-ascii?Q?gY6wHEr0XUAMGMiO6wD3AkTfKXlsyxESj0Zx1960lJG+otjzd/l277dlROtB?=
 =?us-ascii?Q?3kQp3OLDoP8+apT+BPI+gqdZshqbId/7viQD3ef9ayxolS13eQVX80WdlN/a?=
 =?us-ascii?Q?Y08eLPlFN3z/Je0vWSzeAQouHtNpv0sG02vB6O++fOPeHHPphl7+H1eWfNm5?=
 =?us-ascii?Q?2oWf/K4I12Sb8jDFk9fFLaCjnNmBkdLlVpAofVfX8SszvtCqSgoAmAfQliI/?=
 =?us-ascii?Q?bWQcfwOJST3+W4hAMVj1AveiyxucW3aFxiFrSZzhlerSTJtYVtLOaHD/n1Q/?=
 =?us-ascii?Q?nDhj+DpViibM/XXMrvsS4/7V+VmH2a3c4zHpFJGohkmkgyhTQpdaDCg55frn?=
 =?us-ascii?Q?NY5GGzTMNd1QYTO3owZ3M5xTuYhjeHqDdhHHk5kFnRw1WPZqa4ul1YV53PER?=
 =?us-ascii?Q?s9STQWNoIjN2OiaTnRJ4/mTPz01EWOOpr77oGrOeN4btBUqb3n6qpUOBfS8n?=
 =?us-ascii?Q?weSFz717xkMkHOlilXRmjiKxZ+Fhpowv5uAlr1uAVT0tEla0/o4AoO2Yt96k?=
 =?us-ascii?Q?QSwBvaDhv35gabZEmQuOxnA5jjwkXRZvklT6njAEAoWbqLX6NjnTAob/Jerh?=
 =?us-ascii?Q?kS8+sLnGK/QrdKNRr74pkUtXJorZQt5zIeEHmDqfivoJAxm8uYDsWfGj2sQ2?=
 =?us-ascii?Q?nMBdtz7FkqGzzM4cvD8pWqzoROCe4uBaYnX+uEYm0834NFc+yjEnsB2tvOF6?=
 =?us-ascii?Q?R//sgQYNSlFK6dEH8i1DVo8+EAS+DgYY9pzlgNDq3bOkcPipcXxPHG+Tl/hU?=
 =?us-ascii?Q?VYi6s16Gg+KrAj0rq+j571UVuTHR3y/IFbAbZeSLQTwvEsZJuHlX0Ragdoe2?=
 =?us-ascii?Q?39aCIdA5jjbsMbL+JpCCeFM66hG09QpMNkcFbFRh1EMpSCkoJdBAVGu+2lCH?=
 =?us-ascii?Q?q4/7FxN9ksp5JgCKhs/Jcw/wBayJrMNEMWwKtkrMowix0E+9HqZAmK9Fc0qt?=
 =?us-ascii?Q?bbd7dys65QahbOU74vOuH4xsD90/AvguqIGju6QuaDTVRm/Ev2axGTdwoQPS?=
 =?us-ascii?Q?m3n60U5qz35hIWLr1YFFG1CCnawBacMAJAh7fI8LAtEvm1NoTAKhzHIvCtXX?=
 =?us-ascii?Q?WWIQSnOtGMv3RJqzseFxhJtmUmYNeuCNizeLu2DVBRiE5pd6HGYRnY3gMCIH?=
 =?us-ascii?Q?g2g5pCXVW/ofBWDFLWmGmr8x+Oy0LIN3P2nh3r218g9KE9bt/GvHRYaFlTc5?=
 =?us-ascii?Q?7250cgbvG20qzcgnr97REFUwrNrLNvSVgeragS5wFhCZPmiFFmfDdLe8Vset?=
 =?us-ascii?Q?bz5JMPvOku4yHbSdoVzThDs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cdf33a9-a14b-481e-6ac1-08d9b654c7e2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:02:29.8187
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eGmiJfl1IIdbg5BXYDWfI6e1uFLi6Ug6qLlOe95DZV7YG1Sp9lrX/gFXjB8ICVY8Iyc4yclG+OLxtQ0qWsOuzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3389

Addressing some observations made while reviewing other patches. I'm
including the last patch here despite it largely duplicating one that
J=C3=BCrgen did submit - there's one extra adjustment plus an open question
there.

1: perfc: conditionalize credit/credit2 counters
2: x86/perfc: conditionalize HVM and shadow counters
3: VMX: sync VM-exit perf counters with known VM-exit reasons
4: SVM: sync VM-exit perf counters with known VM-exit reasons
5: xenperf: name "newer" hypercalls

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:03:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:03:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237480.411876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7I2-0002Un-Hm; Fri, 03 Dec 2021 12:03:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237480.411876; Fri, 03 Dec 2021 12:03:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7I2-0002Ug-Ei; Fri, 03 Dec 2021 12:03:46 +0000
Received: by outflank-mailman (input) for mailman id 237480;
 Fri, 03 Dec 2021 12:03:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7I1-0002ST-DU
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:03:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1013ebcd-5431-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:03:44 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-Bog92kQBPyaBRnbAxCAPLw-1; Fri, 03 Dec 2021 13:03:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 12:03:41 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:03:41 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0027.eurprd08.prod.outlook.com (2603:10a6:20b:c0::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:03:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1013ebcd-5431-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533024;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fuphnGsPrrpPYXSMHIcEABMTB/3qmzYatmHPuIsrm+E=;
	b=AjypZCwIacqcN3CuRRm65uv+u0/0I+iXXJ19sKuftldKJ9BYPiXeOQJiWee2nbqMxBhoEj
	4z8r8lVCem0GmTUahXclFATA5qiCY6TnQokt3ZUzTwYnZDateT1T418eFI/JDYHCnzVFRS
	50rfYFUxuKVeXDixoIdsSHCsVsjSpkY=
X-MC-Unique: Bog92kQBPyaBRnbAxCAPLw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MmuV8VC2L4FoV4b/VDdNIFRLt5iFAwkl0kpn+WRgcBxuuzHfVOHH1KDcBO+62MT+f4lFaU07tq/y/U586BobRiBBb3rk4cpuDhWzdxk8dE0JCsH1yVGHKhKequOE+ioI6FLFj2Gm229PBAmXRKuyHLPVeUQmceIaezMYD1wavAndI8xMrBzt+UBmfkgTV2X4LimU1W8M8LNUH/08vnZtXywBbEtFeCzKMLTVu2JPTjn1AWtygOqYYm35S6Ll6GnjlQfFgM74QwVUW6NpjtIkFHjKEOVe4Ax/HoJ+UDNo7nq9YqFxk3QoVguVEvtt3P9Cl7rIq7M0NhDy6GZ1G9HzmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fuphnGsPrrpPYXSMHIcEABMTB/3qmzYatmHPuIsrm+E=;
 b=GimHJ6/i3ROjsM4Jq/I/QdJOeYqGo8PlPgxZur6QvyNGIY+yszG4fZ2V+eXSTc898cLofLhC4MrF1fvEMFqCK0pJEtSre327TSX4j7TJTvlMqGAm5MC7/HDM0TrAeV7HQKSQ4BVTAExLFvJPhSH6AQWZ20/eKtZmiJaoiVCY/oLho2+tJgPhWjZbSq+wCjFw+FNSq3SPBCD/zky257dZF3rBK5wiAIySsSOT4LUVyzg4eiwoppyU7xcGrVSF9KtOgd8Ig67iUwXErSIanDkL1GW89oljCDgy1LRCBoe1X4RRgWzoKSRNZHXQEN2oW53vcLtzgvjriRm/pdhzzLDGQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <22325915-c51c-a091-59e2-e6e214576f80@suse.com>
Date: Fri, 3 Dec 2021 13:03:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/5] perfc: conditionalize credit/credit2 counters
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0027.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f1a81c85-d218-451b-f80d-08d9b654f269
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2958077BCC52361807F3D924B36A9@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5Dj7w4jnu5FJAQimA1BSCsu/wfRpyTlcUNDvsdLQpqZ1AafJOVTFT86Od7a1wNIg7kXaJ83Hpe0rHRdRuCJlV+yw12bn59+CqwS8ApS+zh0hEhEGlhWV4M1dM8dTT49qx+6zHyBHMyanK1s9fw4ZvH8MBZUU2l67nHopnNfqzlb8wwyLQIA1lM0aMyYp0V5mvU4vMjJM9KJTBB24cE6AkR3bmzIYy9HcsUYT+nejJRYtfwlXHxaevGcX2pVeqZHv+1cOzFRZX3zSS191ycedmMSPGKUgnJPzNBtL1JT4KoZP+C+NxIB4Ac+1FWODNiMGyeLlRK2/GRZwABL0tDCpHPHpV71w4fVgs0qZMpLlpndEt7AXIc8Z4aIR3B4/8JS7MtvJ0gqcVm2yapy9aCkNvn+tqf95sNH+QWjQvsuctqZWWaiJ36WLpItk2Jtt+AM/uNamXOsVHdmKJII6LaZ76q2FpR8wm/gCIDpnsk+0yiSetsuVvmBFObWV7vakqrgGZ6IJNOjNKEL4ssD7tOvaw3hEZz1zXaVJzzyCR/PTonoTpGCmVGcuLvr19WKI5bIHMER/56Qm/oEmN2/ts86sWv5ZUs4IHQrso3jKVc08+rW4SRd6yaITzhG5D6tlaWTHSoHEWjP7UviJRe7UV8Guf2fru3LLqTXhQrR4ArTtTrEgF3gcx9bEXVUicZIZzodJbsSPcm5iBSVaHLCjVYvF4b6GYcFgN0z3pyCbmf1B0DI4B3IZxXdSNqYS2zs3PMRT
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(83380400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ejFNaXNGSWc3empodHpweVdjS3dLM1ZrU21FT0ZKMVV2Z0ZQRXlDUlhXaUNM?=
 =?utf-8?B?U1dUT1lJZnlBWEM1MHBqSUd0eGZscmhCTnByZk1SOU1wNlpET2Y2b1NjUU1E?=
 =?utf-8?B?MWZ2U0RnaVRJZ3FZZjJzYUdpbFEzcHVuU1NYbHJjWU9meDU4RTFxQmw1S2Uw?=
 =?utf-8?B?TkRGWjUxTXVSTE9GQkhFanBqaXBWR3l5UWtUMzRIcmM5VExZQjVHVGpTQmRY?=
 =?utf-8?B?S1paNXBHU0hVZ1JTYTJ6a0hrMG8vbGRpNGRFRzVnMlEwZ1pTRkp5bHIwb2Uv?=
 =?utf-8?B?SUZHaWpBT2dDWGFWamVIOGphWmlUcGZIRWtvKzZRTWNKbFlqNEpralVKMzRy?=
 =?utf-8?B?UkQ5ZS9QWGFBWkZvT1MwalpEQnpJQ0N4MGcvUDRIQ2c5MFBiS2x3d2VHYmQx?=
 =?utf-8?B?YXpjUzd0Lzd6cFBhWEx5MHJmdW15b2RIM0RoU0RSUytVTXdpTGx0VzJVUXpT?=
 =?utf-8?B?TmZxSTdEbUxvYURoN1VIME5KUlk4YU9DNGpPdmtUT2poRXlrYm5wdnI4dGk4?=
 =?utf-8?B?NGVUNFVvdnJWaUlTd0lIYzN2ZzBnMGg0blZ2cnlhVzRtaVl3TTZyWVNYL1Y1?=
 =?utf-8?B?YkV3TEFLbDM0OGJmdUZxdkwyblRyeWR2OG5JODF4dXByRklsaGpESG93bExB?=
 =?utf-8?B?Z2Zkd1dvVUkrSTZTZ2pWL0p5akhxZGwvVHBFOGp1RmorRXdFSkswOEh4ZmR6?=
 =?utf-8?B?YzJBdE84QXUyRTRBRGdDUEpJajRQOVA0d0FWY0RCZlA0Mm1XWWNud3A1NnlW?=
 =?utf-8?B?L3A2NGd3T1o3aXBwNmpCS3dvbTJqbWlkaG5meXR1bjE5bTZ2Wm4xU0dGNTEz?=
 =?utf-8?B?VWlHaXUwYTQzNytNSGlPQS9aNmY0cXFnaTN4LzdZd0Z0TEdzblEvK2dXcWJQ?=
 =?utf-8?B?eFdadk5xci9nNldZUVlZVHJpN3QwazFNeU5GbDRlSWR0aWlQd2x4U0g1aTlu?=
 =?utf-8?B?T200c2lwM2ZablZPTjVnOTAxZjVZMFdFT1hWd1lUK0x2WnU1eit1ZzBKWmEr?=
 =?utf-8?B?cW5ndVIyRFYxQ2F5cVRkTkVxN05ma29MZlRHVWl4ajRDemdtUlNnS0t5YjZ5?=
 =?utf-8?B?OW9TMzVPUEEwRG9SK2xIc3djdU4wemJGMHhWbGJuZ1IxY1NNMlhuNWxUNFdY?=
 =?utf-8?B?QkZZSDdFY0lLSkNrTDl6SW1IVkpndUFlUUt5eWhoWU40MWx0UWJ2WVpkdnZL?=
 =?utf-8?B?MzVNVkIwOVk1Y3dEOUZYcXZwb1dVdzIwTFMzWlFQR0J3OE1xQ3VGMFdrK2JC?=
 =?utf-8?B?aVhXdXkvUXJ1aHU1TGFqbUNmUkhFQjZudGZmZmJZZXQ1WlJiaHJvZFcrZEtp?=
 =?utf-8?B?ZWE1aGlkUTVhV0puUWRJM1JmSytxV3hlSHNTOGljSUJ3dUwvVlozdjU2cS9s?=
 =?utf-8?B?UmxYYzA3cWhieUs5aXR4THc4b3FMUmNsTzdsS1BGdWdSY2pTa2YxUlRyaVlX?=
 =?utf-8?B?SnBJNDV3NmlvWDZYdExqQUVvbWNhYU5PeXN0Zm1VaDRVWlZNcFY5RHBBeGVL?=
 =?utf-8?B?QlR2YmxNV0krVlZwNkJZWkJscWEyYWtZNWl4ZTJPSGdUQ3NWanBPV0h5b0pz?=
 =?utf-8?B?TTRJWksvVkVuYmlFTFFOejAycWpKd01yNzcxQkYzVElybkJ6V3lZLzdGYlJm?=
 =?utf-8?B?SzdZNkdaZFpZUkIvM3JKVWdLd1Rua0dqZ2dlTFBqenVyYVYzRFBsUXdIK3Zp?=
 =?utf-8?B?NnJ1Mk1UOUd4d0NzYzltelQxa1F5KzJLQ21iYUlWa3hZRDB2UlN2akF5dk9E?=
 =?utf-8?B?R2ZMR1k2UkxKWlptbGtRb25MTWo0VXY0YnNsOU1meGtRY3paeUNOVGorNGZ2?=
 =?utf-8?B?dncxK3ZYaDdvcGRYeGY1c2djcTg0Y2ZadHFCOXRvOUZlRDFmWHVEVDBsbW1m?=
 =?utf-8?B?SnlDSm5tWk5EbUFLUHRhS2V6NG5DMnRsbnlTQXJzTEJPVDJvMFhvbDAvMnB5?=
 =?utf-8?B?aWVCaDRWYXMrMllGQlFMeGQ3R0ttdmxPckxLUmN6RWVaSy95ZW5QWUJxbWtC?=
 =?utf-8?B?R3phZHI5Q3o1c1FWc3BsY0FQN1l0M0FNUThCRnFiM3pHVlJIWEVSWHhOR3pl?=
 =?utf-8?B?dDhEMkFabkcyeTRUczkya1NMaGhqODNwTkZVQ2U1MURzOUZtWVpxOEFtNy82?=
 =?utf-8?B?L1BZQUZpVmRTZ0dURTVFTW1pZ1ZXMEFHa2NFQmtsUndYS2NwSmljSWtwUENM?=
 =?utf-8?Q?PVfm9+5E5HJJF58ndWSzG9U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1a81c85-d218-451b-f80d-08d9b654f269
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:03:41.1124
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q8hdu8D4Y1s9pcGvio7y3ZwnjyY2/IVqTLlysCORLki+BAfHqUhsint0CRRvm/Xl/D+ogny306MKmChfUR85PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

There's no point including them when the respective scheduler isn't
enabled in the build.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/perfc_defn.h
+++ b/xen/include/xen/perfc_defn.h
@@ -37,6 +37,7 @@ PERFCOUNTER(tickled_busy_cpu,       "sch
 PERFCOUNTER(unit_check,             "sched: unit_check")
 
 /* credit specific counters */
+#ifdef CONFIG_SCHED_CREDIT
 PERFCOUNTER(delay_ms,               "csched: delay")
 PERFCOUNTER(acct_run,               "csched: acct_run")
 PERFCOUNTER(acct_no_work,           "csched: acct_no_work")
@@ -58,8 +59,10 @@ PERFCOUNTER(migrate_queued,         "csc
 PERFCOUNTER(migrate_running,        "csched: migrate_running")
 PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
 PERFCOUNTER(unit_hot,               "csched: unit_hot")
+#endif
 
 /* credit2 specific counters */
+#ifdef CONFIG_SCHED_CREDIT2
 PERFCOUNTER(burn_credits_t2c,       "csched2: burn_credits_t2c")
 PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
 PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
@@ -77,6 +80,7 @@ PERFCOUNTER(credit_reset,           "csc
 PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu")
 PERFCOUNTER(tickled_cpu_overwritten,"csched2: tickled_cpu_overwritten")
 PERFCOUNTER(tickled_cpu_overridden, "csched2: tickled_cpu_overridden")
+#endif
 
 PERFCOUNTER(need_flush_tlb_flush,   "PG_need_flush tlb flushes")
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:04:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:04:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237487.411886 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ij-00033p-Qc; Fri, 03 Dec 2021 12:04:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237487.411886; Fri, 03 Dec 2021 12:04:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ij-00033i-Nd; Fri, 03 Dec 2021 12:04:29 +0000
Received: by outflank-mailman (input) for mailman id 237487;
 Fri, 03 Dec 2021 12:04:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7Ih-0002qC-Rk
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:04:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29a564c5-5431-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 13:04:27 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-LR79iWxJNseilWv7fZIBzQ-1; Fri, 03 Dec 2021 13:04:26 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 12:04:25 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:04:25 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0029.eurprd08.prod.outlook.com (2603:10a6:20b:c0::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23 via Frontend Transport; Fri, 3 Dec 2021 12:04:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29a564c5-5431-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3+yaC36DqlsYgMBtQOA6Ygvl1IDjxBnVmeHuhg98YSw=;
	b=CvWZPOSsPsq7fU+h4k3ERFJ2VYiDRXcxCj8J7L2wy/d/1U3eYuaRHIhD+Io8/+IrLDsRuM
	3E2yFvIOS4ArpWubtHUhKXVNjfkgAbcRH0gIitNTNisHwA10QbUFGCq/yzXBAFK7qQYGmZ
	USDn+XZH/m8kghIloZAnbahFTPL4VEg=
X-MC-Unique: LR79iWxJNseilWv7fZIBzQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kMxaTo5j16RN5X8zgqO22CAtF9pOAKIXToGkYzxHYY5mp9jvuYdmke0CTrCQoaG2Z5wO7hBADLB+wX8kytYvjbpkIGDogu6OZmsM4ASZ0vgAZEMXlgaEJHgxWc3FqYkPaAiF9o4MAQuesTqOg9HvEjW4b/qQ4VELGElkRyWcwyig8uyQ0aE7nQRyd/XsqaT7QTp7PtFsHNwb/MywSAMxBzxWrj4h8L8yOe3oEDKIbj0XqC97WL1zI3iHtXBATVfbaxfyYe5GBPiGqcScH0h48n3G/xBHRzth9GESveQesAZQxG8VKyAydcjSysmUd/sUjZwq+QKmbxgQgooVqDoGew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3+yaC36DqlsYgMBtQOA6Ygvl1IDjxBnVmeHuhg98YSw=;
 b=BNsB2S1hDC+n1GTCnC9+W+sqdG2R6CvrxPHlsrjEWTOZR6Q3ScDm2mLNTu0e+2VZgYKIs7FOknFzA4dCUF9rmpwECS7qmX0vZuvHxdiemFEcf39j+z9lHHov1dNFJg/CeEkjxpu5Cx7NRJOzW1ui/Qlt510NWaLbJUL5nXtiNuJMvWuOKdENL4fpnIKp5MOUbFV4RfT5q4Ys7B5uI4a9bo36/uX8Y2XjrN8Dvne49/3CllqzIyLAbp3vQ1wHYJJbNVrCCd32GVW5VuJvgVaHhm8GIsiPxT8oEcCwrqppwa8jzynexi3QFTCZ/j7bqiBvvF21xXycWdoyiJQgL/z8NA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ea513864-58c0-fb90-cee6-f668309fcc38@suse.com>
Date: Fri, 3 Dec 2021 13:04:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/5] x86/perfc: conditionalize HVM and shadow counters
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0029.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 83757df3-360a-42a3-f0a6-08d9b6550ca2
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29582D1221A39D98E60E869AB36A9@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	duvvBCEKiXprorkxaxK+fmynmWcqjILkC1CRV8IYljMmwIyS9DCD+7cru5Ivv0dpgqiGOEajLeAg/QZAfhN5ZqF73VuX5hMPI0TdM4GR0Gkin+T2dQ4+7vGlcs3vmp3ZqwWnZ2fBuHVFqSssfKjQHwWZal82GNV/2ce0FNDETsnG1cINor6SAETOrwJUYYODy02/t5CeIla0PwooUYVcb/2A9ok0Gnbpm6RYvBhOtexHyEUPAq3sNBSBcRBYfVk0GMd6dygR3C4akwqqX+7nQLWa1hD4D51ZJV8vZlPM8aXnEgjzGWe6xY4ZwF50sRdLMNBGWmnCReIBUyLpS0J66NSktnqsRi1fd2n9bZ+rBgjxMhOtJ/t+EkHe/3wOJ+uh3kwhiM6t3u89RFEVa304lwmX8/3Frlta5w/bV4EMrRsF3WWMfnvrq67XiWwg4ig8rNs+gl+edgJkaJajKZocGOjpQn6TFCj7QSjBHbjIkmJl/eUSDKJ2mhmUHN4jpotbQdIVfRrmLQ30WuxxwqM34YrboiYYarKDGuljm6rQsRaypNJTeV/1x3ahJXCbvdd/4NdF6vdaVDCPN1b5PpulGJIRL+/d7SJ8FQCFpYPY1PqPR5tAXvTpbWZL4JJeVHniBzO1eqsLbgvLC/rJOul/jIjQjNBvzHOvTqkr0OeKApV6rVRY1hU5FQpiKNqqdXh6wPhbrtOlxIwTYOltys1FKtzCbzZ/BV4fUua3u1M5xKXVw1VcJ0f8MPwgC16++0RF
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(6666004)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RUV5aDMzZ2FNN2VUbFVQNTd6c2hLdFcxT1EvelpSaERZRGFaSDNLcmNTVnE5?=
 =?utf-8?B?d09aZHVaYU5uZXdONzNIb1pEM05DUnZFMTdhaXR5Mk1telZBNktxNWh5ZEp2?=
 =?utf-8?B?OWxsaGlYUXRlZkZlZDVDdUZJRFlkS0dwVFBaMGdMM0RRUno2SUtSSDJnKzkx?=
 =?utf-8?B?bm5HMjB0ZkxYN213aTl1RGxMZHRBcWI3dGlUZG1vNFRBR0QvUkUvMWVyb3RG?=
 =?utf-8?B?NDQvLzNsbzNPNUhzNHBUUXU0QUIvNmRLaUhpMGlGaHd1TWFJNVNxOW41bURa?=
 =?utf-8?B?cFl2bHpEVEorM2p6NjVmd0pTbjVWamZTbTNqYnFmYVJBT1RSSDFsSVllZm9h?=
 =?utf-8?B?Y0EvMlM4M1A0Tkd0dk5PcEZrYzlvcGJCL1pDY3JjbDhKOGdVckZ2MFlIdTFY?=
 =?utf-8?B?a21RWVRhbWNQTXdEaVZkMUVseDVRUU1uSk80MXhrTVQ0d0o3bGpFYmRNeVZ1?=
 =?utf-8?B?WFFaSTc0aDhsbG9oTEdTZ1pEQ1JpdlBaT1d5d2s4eldTV3YyMmdzOXRocFFZ?=
 =?utf-8?B?Y3lZZW9ocndjM2oxSGVjSGpacTVjSFJsVmxubTdTdjkwd0lqWTlRNmtpbmc4?=
 =?utf-8?B?ZkYvbHY2RHdOdkN5OUV0QlB0SlI5eHFtRDVyaW5HM0lVQzM1SlZSN3pkVG5K?=
 =?utf-8?B?K2NMa0x2eHVyT3BvOTFmcmphYW0ybVhjY2QzbTV0SDVFQXZOK0VtSDlxWVB6?=
 =?utf-8?B?UXBabllwSWk2aG1FdnlNamZvUWM3bXFPNzh2Tnk2YkM3NHNzcVB4Q0I0bkov?=
 =?utf-8?B?U09hcHIyWjE4NHQ4azJ1a09Qdzd2SVgwVmdoTHdXWldFNDVkRmJqdWJ6bllW?=
 =?utf-8?B?b0o3SUY0TUdxdFFtdFBzN2o1L1VrRzZ3MGJ6RHBtS3hnU1hiLzZIUHZlZTVD?=
 =?utf-8?B?ZndTZUVvNEVDajFaZlRpaGk1dkZUQmhOdVkyWjA4MlY2VWtVZmQzQi9nemwx?=
 =?utf-8?B?b1NSaGwydXdsTXNIL0YzeEdISEhDS083VFVselZqaStrZGF4dTA0Uk1nYXRi?=
 =?utf-8?B?aUhyYkptMnhnMmNCSkpwWUhPcUFTZXVtSW14MFJJWnFTbFBvcXUrTnpuOGg3?=
 =?utf-8?B?ZGQ2ejRaT3BLcWF6N3poSXZHQjRkZDhOQ1M4KytOVVIrT3c5b0hyVmNCS2pP?=
 =?utf-8?B?N3ZwWHRhNFo3Z015UWh6d1ByRzN5K0J2UHNmeFkwVWwvaVVKamlQcFJYM1l6?=
 =?utf-8?B?U2F2WERhSi9XdDZFbnV1NG1OMjZ0UkhnU2cwYmp5VzFlTUFSUWUyc3E4Uktv?=
 =?utf-8?B?WlAwL0FhOW1OTlhxbGNEOWtmaFF3WWdERHRuWTVUeGE2S2x5T2xVSlhzUVV4?=
 =?utf-8?B?WHFjMm5hblFHMklJbWtpeENpaFFHYUFDVERkUDZFR0s4UHd6bXM0ejlsTjc0?=
 =?utf-8?B?c1N2TldBR2JvKzZWS01HT3VFdjU5QlN5WWJHT1N0UThndksvbVp6WnNuYTVs?=
 =?utf-8?B?QmJYWStLM2pZZ2tYbit0eDZGaTFQL2IrSzlmWHAvUHRyOXJqWDZ0bktkckVU?=
 =?utf-8?B?a0o0eDY0VEZHRFdFZ2xubFQ0Sit0YktHQ081Zzh3YXl1TEo2ZUphRFI0YnQv?=
 =?utf-8?B?ZnVQYW9UMkdYVzJ3ZXh5RTBLU0FNc1FOMllSUFREc3VrMVQxbmFBaTY4anBq?=
 =?utf-8?B?bzd4elgwaFhvUks5OWppaGVTVG9HVjBMN1ZFWDFLVWFoQ1JoMmlvTUxSOTRs?=
 =?utf-8?B?dUtmQ05Ocis5NFZyM21aM3RLQ2ZWbDN1aFBLeUgweGtuaTROQXB3ZUUvaWw3?=
 =?utf-8?B?RXZ4THZkaThtMkt1bGJZQm5qbC9saUo2elo4NlRSaWlPRmtrcFhFcjhjRTR5?=
 =?utf-8?B?ZDVGS3Jrd0htUFpnZUhJM3YreHB3SDIxT3dMSEZzVjZ5UjlvVkJHMlpmMEUy?=
 =?utf-8?B?eFJvNnlHbDkwWXorRER4ai90WE1CQnMyV2lWYlpCMmpMNElDVlVVMTE0dFdH?=
 =?utf-8?B?UjJsalk1NVFpQk4xTkpTWmJTazRaRlJqajA0ZW1iakpMZ0tzcW5SN2JIQjZL?=
 =?utf-8?B?QmVERExtaU04RWZRTUYzaFVSd3JUQ2hDSE5SSDFJRWwzRmFJZFBLMzVhWGI2?=
 =?utf-8?B?dUdZWUNkU0JJWnF2Um9iUnBYV0pQTUxMZUdYU2E5Tk5TVnhqd3E3MnFIbkNG?=
 =?utf-8?B?NnpBYnRYakZLNjhnbTlaT0hsdjdqSjN5NlRSSWZHempqQ2FoRWl0emJ4a0Nl?=
 =?utf-8?Q?HvegpAm24IfYJaXK+tej6js=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83757df3-360a-42a3-f0a6-08d9b6550ca2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:04:25.1125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ry14BUNpxSS5vItZ6Ocy7ZrT4ieHtt659dW8q4Qzn/lEWNt8FBKkUfnJvnS1l7Dn7veKwR+FmnoZW5UTKrN/eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

There's no point including them when the respective functionality isn't
enabled in the build. Note that this covers only larger groups; more
fine grained exclusion may want to be done later on.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/asm-x86/perfc_defn.h
+++ b/xen/include/asm-x86/perfc_defn.h
@@ -4,6 +4,8 @@
 
 PERFCOUNTER_ARRAY(exceptions,           "exceptions", 32)
 
+#ifdef CONFIG_HVM
+
 #define VMX_PERF_EXIT_REASON_SIZE 56
 #define VMX_PERF_VECTOR_SIZE 0x20
 PERFCOUNTER_ARRAY(vmexits,              "vmexits", VMX_PERF_EXIT_REASON_SIZE)
@@ -13,6 +15,8 @@ PERFCOUNTER_ARRAY(cause_vector,
 #define SVM_PERF_EXIT_REASON_SIZE (1+141)
 PERFCOUNTER_ARRAY(svmexits,             "SVMexits", SVM_PERF_EXIT_REASON_SIZE)
 
+#endif /* CONFIG_HVM */
+
 PERFCOUNTER(seg_fixups,             "segmentation fixups")
 
 PERFCOUNTER(apic_timer,             "apic timer interrupts")
@@ -37,6 +41,8 @@ PERFCOUNTER(exception_fixed,        "pre
 PERFCOUNTER(guest_walk,            "guest pagetable walks")
 
 /* Shadow counters */
+#ifdef CONFIG_SHADOW_PAGING
+
 PERFCOUNTER(shadow_alloc,          "calls to shadow_alloc")
 PERFCOUNTER(shadow_alloc_tlbflush, "shadow_alloc flushed TLBs")
 
@@ -112,6 +118,8 @@ PERFCOUNTER(shadow_unsync,         "shad
 PERFCOUNTER(shadow_unsync_evict,   "shadow OOS evictions")
 PERFCOUNTER(shadow_resync,         "shadow OOS resyncs")
 
+#endif /* CONFIG_SHADOW_PAGING */
+
 PERFCOUNTER(realmode_emulations, "realmode instructions emulated")
 PERFCOUNTER(realmode_exits,      "vmexits from realmode")
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:05:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:05:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237495.411898 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Jb-0003jS-8r; Fri, 03 Dec 2021 12:05:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237495.411898; Fri, 03 Dec 2021 12:05:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Jb-0003jL-5m; Fri, 03 Dec 2021 12:05:23 +0000
Received: by outflank-mailman (input) for mailman id 237495;
 Fri, 03 Dec 2021 12:05:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7JZ-0002qC-OY
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:05:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49c332f6-5431-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 13:05:21 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-4aArlK__OeKx5HHZ9fkoig-1; Fri, 03 Dec 2021 13:05:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 12:05:19 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:05:19 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0106.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::47) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 12:05:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49c332f6-5431-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533120;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Xbkw59rq1m1qExzkUUzR8dD75QHb9SESG2q0qwJbyuw=;
	b=cnQoWFxtAl3GV3qYoaYb5hoR5esLESldkEhtGlnHValQH8yIwAfVIbCIT0HX+0o0Rc4abD
	KRc37Lav2nZqi1m03DRuEhpiTTNkXkXt696Krwk7DrKowb/H03jBYS1B7bvljUuqI12YKg
	7kjlqGaRhf+mT7D0l9a2SQQZUfX/zTc=
X-MC-Unique: 4aArlK__OeKx5HHZ9fkoig-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nFkB0amN2zbx4hCmnZpBuluRFwAgHLjdVsE1haljjVLPHyXNE0SQc9IimNGldHAZ9sleuEgAWdz75I9UndAO1lYAZGek9+nt+IxBycZoCoj5siv6GkqoYEDE+BmEj9UUoQqH7gVzw4gEGmAOT8iV654DmT/pXNrnwwkxqgAkUi085KeFx2V2yQtQLd8xPN05VzxZJphNZA0VYw1l6mL2ySQa+NugsNPUfTQ0WkFe76zQ/gOpGFn9SbYgGJmWjkU7jjpvfw5jYPA2OnE9IJwxOfPiuUY+Czb/FX37sT8EvwpQVmh0Ch5chwueoinIKbl4P0ziZPlsQbAwUWbQnMR2Zg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Xbkw59rq1m1qExzkUUzR8dD75QHb9SESG2q0qwJbyuw=;
 b=Jd9M4bL3YxbFrizf0YJAzMlT70UZzNabBtL1VyLnGBkLzvL9gqft1h/OR7EapE21PphuH1P3DiWBxgQJlVg7c7NzCoVifhMhVjMNGIkMe4VhH5PB6TRiIfnRNM2zZq1fxHfvLbiCWqifok3ghM7X6YYjKUF8yk1admlBvQ4NNKz2/oIQ8NYpIIruuexdD3yI2zunK0Arspuq+rg9dq75i4xx55qFNog/9Hi953MzsPNU5jubk1+8tpYiGU5velAjP3FurJGi3dFOGShIFakZuTi4Zm8MVVjk1xv66WJcibf9p5eoy++5x68LSVtXVtXWllpGyDq6bsG8Aj/kkv1cVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <efb282e9-4ddd-22d1-a2e4-36a4d0964ada@suse.com>
Date: Fri, 3 Dec 2021 13:05:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/5] VMX: sync VM-exit perf counters with known VM-exit
 reasons
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0106.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b9a317e-6516-4be7-3bab-08d9b6552cbf
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29581486017F0D331CC845B2B36A9@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VQObLVjU2MPHfCKkf2NmKbKHhpe6yHq37qZIC4V62OHPt+OBX7fLD8sykMwzKLrWLmLdZEgmiD+Az16GvKKu5RwzfrUC3LmwXZ+O1YA6ll8PT/qapkxPAkk2ogDOG+YFyNTf23eCFevsdM244zdOhSfof54dQfkmeFoTnECjssZz62/lp5gW8GshAs+8Bfe68PljkxkBRGJx4C4fnaMgAwKz0YHOZcEpF2sqEAwsDxTrm5uyxZnpNSzv7znNCMNXoQl6zlYq3aHXWNClK8+sWanMv4dBCW0dzGzMwglQtgHdi8jZ+HtjXijd9Xk3/JgKDoY9Uc4Rtm8zHoUfkUu8O7uel94RbP+s2gMguM3qUvc0RTS1HQ/O+3e1Jl3PScIj0a0Y8WbJUtEJHiSalImaZlLsjXuEEvFu6JRRuoYDbT4jrarAm5guzeBemGkJvQD37Wz7kOp98Hs7wmJaqhD/LlUO9Ht6+YgN3SFADXnGFGoOw2H6T+4psWuvSN4Pn7me40XqwheE0io8A8/i9VXA8PyRi2O2BZ6UiyuTD26zds4Ti67Lxov34zZwcC7i1/r1AEOGwysr0s6SvfNC9yHdOqXOWlg7l7MfYqAWdf1eddoRZ9Zw7NVlb5SxMUZtp8zZjVWo1K3oOmkTWeb6J3kMWD6lnrdHzCIOOT7C/Xm5ZlSV8UMmPmI2SruUcRaB1O+qiS6LTSgxoswVlKM2rrVCtiTmEOQRAJJvn+uB6EaZzyDFMCoojbbrz1x04a/+x8sJ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(38100700002)(26005)(4326008)(8936002)(16576012)(31696002)(316002)(6916009)(508600001)(86362001)(31686004)(5660300002)(54906003)(2616005)(2906002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YkRQZExmZE8ybDg4bFRLSHQydE55ekFvSUVtRHpUemVITVRXTkI5QnhnUWQ0?=
 =?utf-8?B?L1hwanNvdDZaTm5PWVJScVJOU0dOMTQrWW16WHpEdm4raTk0bk9QaFpRcUs2?=
 =?utf-8?B?Qk5rTlRZb1A0NEJCV2RpWVpzUXBJaDhZSDhIZUdMSXJPRmZGL2NuVTJZdkw2?=
 =?utf-8?B?M3dEeTc1Qm9EdzVJbVh5OVZBUEI0OHJzcWJVR2M3VlVOUUQ3Q0hKc2RuN090?=
 =?utf-8?B?MEVLWkZJSDNkUlZnM09XbVRiaGFkUkFqQXhLRkQ4UkNRYTNscThXVTd5bWEw?=
 =?utf-8?B?ZlpUYU9TMGhWelBnT0hkV0VIUmNRcHUzaXMyaHVXcko2Y2w1Rm1GZElMYXl1?=
 =?utf-8?B?amE2bm0wWWtMUUlEV09md3BMZ3l6R25aaTFXbFJ6T2VvK1hNWlRRbjZtc3JQ?=
 =?utf-8?B?VUtMcDA5N202VGc3M2dWeWd1NGlSaUx4VXRZM1Y3SlVpMi85VDhUeVVlNW1h?=
 =?utf-8?B?SEVFYllSTjJPUGczRllUUlZMcjZkVUw5b01XYW55bllxRS9taXBUL0tCNVNh?=
 =?utf-8?B?VWI0dzVIQ2tqTHdmUVJlMlBtK0hTb2RzY1daaEE0VkRVTWxlV3JvbFp5bFBi?=
 =?utf-8?B?NWMvK1l6TnZyQ3JiaEI2enJjckpKYjEvTWVMMGEzTHI2ZVB4dk4vci9tRExJ?=
 =?utf-8?B?MldNTDhmMjdpWFNjRUc0NGF5emtCcjludnc2Rk1HOGdqaEdSYlJteVRoUHlD?=
 =?utf-8?B?a1YraFFSM2ttQS8ySDRNekV2dnk0VVlKTTJsV2ZFL2JmY2psdWRpU09nKzlh?=
 =?utf-8?B?OFJPNm5oWkZ4eGR5d3R5UTM5QkRBczZNUVo2SFBhWHlBT01WWXE3L1R0bXVr?=
 =?utf-8?B?SlVCSEVsMVMyeVNFNkVPSEFVWHlmM01XaE1rOVp2VzdZOHBEYldJTzNwNzF3?=
 =?utf-8?B?QVpVQjlVOTJqWXRTLzV1YjEzcGFOeE85Wmh4eXZyMHRMaHk5a2FNMzRIZWZo?=
 =?utf-8?B?RERmVzhPYnViTWZuT2NjQXJFQ1ZtVUw2Q1pVMVdqdndwQUJXMHlUVWFMUUZQ?=
 =?utf-8?B?UVdCL0x2bzR2d2pJdVg5NVVTY2VKWU9MdEtsVkFpSWUxTllQdWJaRHZtbmEw?=
 =?utf-8?B?MUZzTndFWnhOeVBhaERpdkNlTzkyV3NkOUZ2MjJXdWVyS25iNSs3ZXcyQVgv?=
 =?utf-8?B?VTU2RGVTOTRLL1dmWWFteFFqaFFUMWkxYkdOQTZsSmdxRE5ZK2x1eG1vZ245?=
 =?utf-8?B?QXNFaHhWVVp4aWhnN21FRHRLaGJQUXVNaGh6bnkzcEpaVmVZYURUNjdLWHRZ?=
 =?utf-8?B?NXdSQU4vbVBNbzE2OFJEUFpEbEhnTHB1RjQveVZRNytrQXk3Q01sVGVwVzlV?=
 =?utf-8?B?TjlVYzhGb0ZzQUVvUytsTm9kWGNaa3hUcXFaRmVpbWxOUnY1U2NMQUNpWXRT?=
 =?utf-8?B?VFBlUWZ1SWs2RHVGcVRyanNpcm5FbDhBblhNVG1TR1NDZFBSaFZvQVVJUTNs?=
 =?utf-8?B?c1lPNy8xUFBiSG9OdTBDeXdWU1RrdE5XVWtqNGJoSGVNUGtBVUp6bnoyaklN?=
 =?utf-8?B?Tm56d2xkMDJLUFQweDJUL0ROTkdXaTV6andsSGhDWFlXdGhrV0RwRHRJNk5G?=
 =?utf-8?B?WHhZQTd0NjB2VDlmYm90WU5aOW9FbWtma2RIY0p5YWd6VXI2bFNOWUhCVFcv?=
 =?utf-8?B?OWptU3RSMFE3c1hyejU4NDdMZkpheWNEdlBmeVpwWGt1VVAzY0JjdUc5UW82?=
 =?utf-8?B?dWppaDRjSlFvclRId2M4cmQ5Uk5qQ1c4d3BEU2FFS3RNMkdpZmhLRmhpZTl2?=
 =?utf-8?B?OVFzTnJsQVN1NkQwTzdlN0RueTh5bmd1VEtlMncwUDhkeXZoUlh1bE5hclJo?=
 =?utf-8?B?Uys0K29zclZDaVp6cjlTNHgrL21xMkg3UjJrRXR3ZllBemVhTzF1YW13RHVJ?=
 =?utf-8?B?dHFUSUF4T2NZeXI0ZGFvUUxaRnhDcDZKb3pDeEx4L25nMHR0THp6cnZyMUZt?=
 =?utf-8?B?ZG5vVzdjeU1GaXRQUkhydHlZclZtenpRQmg2dG9ibFo5YW5LcG8zYUQrcE9E?=
 =?utf-8?B?NEV3UGc1VlBBTERYcmRjVnZ6L0lUMmVLQUdVQ0RiYzNVRGtDVlFxYlE4RFYr?=
 =?utf-8?B?cENaenNDME56NGZ1SnN2WDkrd2dIZkdud1lCRDFUcC84dXIwUGhqTTlBY2Vu?=
 =?utf-8?B?NTU3RUU4OStwT1FieHBYTThzQ3BEaE1KTkxuSVBxMk1RTE1oRTN2RFQvRmo0?=
 =?utf-8?Q?LGZwVCmF8pmffS8h64Dn2U8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9a317e-6516-4be7-3bab-08d9b6552cbf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:05:18.9830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TTnF0JN7iTaZdOWRZ0IldTLjZ7T4brZhAPFgHhYYTduDHAEZP7mvRyFR8jW0iFpyxLESu1Pve/Ajo/2zID5Cpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

This has gone out of sync over time. Introduce a simplistic mechanism to
hopefully keep things in sync going forward.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I wasn't sure about the #ifdef: Using CONFIG_PERF_COUNTERS there would
seem slightly odd next to a construct which specifically abstracts away
this aspect.

--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -3869,7 +3869,10 @@ void vmx_vmexit_handler(struct cpu_user_
     else
         HVMTRACE_ND(VMEXIT, 0, 1/*cycles*/, exit_reason, regs->eip);
 
-    perfc_incra(vmexits, exit_reason);
+#ifdef VMX_PERF_EXIT_REASON_SIZE
+    BUILD_BUG_ON(VMX_PERF_EXIT_REASON_SIZE != EXIT_REASON_LAST + 1);
+#endif
+    perfc_incra(vmexits, (uint16_t)exit_reason);
 
     /* Handle the interrupt we missed before allowing any more in. */
     switch ( (uint16_t)exit_reason )
--- a/xen/include/asm-x86/hvm/vmx/vmx.h
+++ b/xen/include/asm-x86/hvm/vmx/vmx.h
@@ -220,6 +220,8 @@ static inline void pi_clear_sn(struct pi
 #define EXIT_REASON_XSAVES              63
 #define EXIT_REASON_XRSTORS             64
 
+#define EXIT_REASON_LAST                EXIT_REASON_XRSTORS
+
 /*
  * Interruption-information format
  */
--- a/xen/include/asm-x86/perfc_defn.h
+++ b/xen/include/asm-x86/perfc_defn.h
@@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions,
 
 #ifdef CONFIG_HVM
 
-#define VMX_PERF_EXIT_REASON_SIZE 56
+#define VMX_PERF_EXIT_REASON_SIZE 65
 #define VMX_PERF_VECTOR_SIZE 0x20
 PERFCOUNTER_ARRAY(vmexits,              "vmexits", VMX_PERF_EXIT_REASON_SIZE)
 PERFCOUNTER_ARRAY(cause_vector,         "cause vector", VMX_PERF_VECTOR_SIZE)



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:05:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:05:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237496.411909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Je-00040V-I2; Fri, 03 Dec 2021 12:05:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237496.411909; Fri, 03 Dec 2021 12:05:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Je-00040O-Dd; Fri, 03 Dec 2021 12:05:26 +0000
Received: by outflank-mailman (input) for mailman id 237496;
 Fri, 03 Dec 2021 12:05:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt7Jd-0003za-90
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:05:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7Jc-0003fw-RA; Fri, 03 Dec 2021 12:05:24 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7Jc-0005lv-LN; Fri, 03 Dec 2021 12:05:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=adGjGgbfhyT+4XXLd4J/8JrDKs9zuriW9xY3SzirS0A=; b=zoyoEk1sh0ztwp/AKv5isUYici
	vBjaRv4jZ3LXC9tynuAWm2aImi1iLGbbvl0zAfx61A8ONKSmzWWVbD9PAjuCneg7+cOCJjR9gSNV0
	W3je0JjjIT2VUzhbxAqd0z5Y1gcdvYGy1aGfxtwxAnh0naRHhcUgg4S7n7Z6cI97I0Ds=;
Message-ID: <4f14f0ec-82f4-df4a-5d87-9c39727b4634@xen.org>
Date: Fri, 3 Dec 2021 12:05:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211203095837.20394-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 03/12/2021 09:58, Michal Orzel wrote:
> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
> forgot to modify a comment about lr_pending list,
> referring to a function that has been renamed.
> Fix that.
> 
> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84

The format for fixes tag is a 12 characters sha1 followed by the commit 
message. In this case, it would be:

Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq")

I can fix it on commit.

Acked-by: Julien Grall <jgrall@amazon.com>

> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>   xen/include/asm-arm/vgic.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index e69a59063a..ade427a808 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -195,7 +195,7 @@ struct vgic_cpu {
>        * corresponding LR it is also removed from this list. */
>       struct list_head inflight_irqs;
>       /* lr_pending is used to queue IRQs (struct pending_irq) that the
> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>        * no LRs were available at the time.
>        * As soon as an LR is freed we remove the first IRQ from this
>        * list and write it to the LR register.
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:06:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237504.411920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7KP-0004rk-QN; Fri, 03 Dec 2021 12:06:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237504.411920; Fri, 03 Dec 2021 12:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7KP-0004rd-NA; Fri, 03 Dec 2021 12:06:13 +0000
Received: by outflank-mailman (input) for mailman id 237504;
 Fri, 03 Dec 2021 12:06:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7KO-0004Rn-Of
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:06:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66b24870-5431-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:06:09 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-4QVetuCsOQ22W_Mt-roe_w-1; Fri, 03 Dec 2021 13:06:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 12:06:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:06:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0083.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 12:06:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66b24870-5431-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533169;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lrCpsxf//rC38Yu1bAGmHgfd83NmkO7BJIS+XBF2CsI=;
	b=iUGyGd39fQx7XAt1YrDWM7G8y8erEwX9u97Wu+wYDj6RKbkTd+55IXBMKkgJqSy7mUyiuE
	DFiORNFOxFqEMXZQmn3zSzJgyPEJrMTpAVmrOYFTTEwJahctlqRN0yhqXoMfCHayLFkggR
	r25O9jR1szwRIzDY9QxJVk16SNRNEu4=
X-MC-Unique: 4QVetuCsOQ22W_Mt-roe_w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a1fVguAM5V8rx83t9IR/psERW/1mMT7Ma0P50Va4QH+bxVshLAa9wWHPvCyGdkBByN8DWEyuWNfyfROhdptYIb44Ne+QojjsdP/vZBf/t325IB2btsiUfnZBY9KHUoGo08Zk8c7lU0rerd292jWihxi3lh6lVyoLXoseyS2KIKV9MyEGzmZlPOt7LP+XMIY8r7rT5TXiR01xZwY8bwMWLbegSq8fOIBqtzMwqZJfm39ufinaCeopU9zLTJbLXoYRx1I2jnIYE+tASUQWi6AdHhkyPBCXCNp0cm+DhEZLiTlo/P7bvGmcOudbWrE2cqouRiSwGeQ6w5W/F96cIfKdgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=lrCpsxf//rC38Yu1bAGmHgfd83NmkO7BJIS+XBF2CsI=;
 b=EIFiabaRuSdJ74uTdAWIrYqUwXOZWC9oHIhJuF1lF/evV0wdthMDVXr8m8DTVn5cAcNbjocO00BPhQayQhTeDqiYqDPEG6Izx1qRwloQv3jgm7rwVx/F6nl3FxFuFMq+DsySsQ2kMBdpibXU8npDpzqs8fKnfbj7ME6H2RjhQ9EklyJK1TEdY7DgJQ6ZWEe7ldaHuFtJx5WxXYjkiIqBUCdcaa8xXJYWBuyn/V+NuNOnEBQsDlhsLNf4jO8ajM02v8ZB/8L6eo5h2hR28P5FzzR/pZ5CS7upQfBlrjqdgn5pc+NvzLyW+yKMlnAOoWF/fmjSm0wGZ45omgvW7nrQzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c94bc336-fdee-43af-540e-06e0904d8db7@suse.com>
Date: Fri, 3 Dec 2021 13:06:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 4/5] SVM: sync VM-exit perf counters with known VM-exit
 reasons
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0083.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 084287df-8497-4aca-636c-08d9b65548ee
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41913D6110B9C0C220D4E449B36A9@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CBdYD8brSmj+sXlIdI1900fIoJ4ZXlTSOX0qxa6umyea1KrNEqDF8cO7v+GC0exJ6I/rSfKld5ZmeFfBoVsfrzqTAlyZZ0K2sxIE2IeFrKokNnNgd19sX1TsWdQ0X7VF5pjI5YO6gICPq1sGaCFkZq1DJ+v+pJjMbAnQVo17jBnN8DdUHMk1DbKMhcKBZUnZaLVJGppkYqXToZf1r16lLK1MEqYV+zCE0pVfl7j0MT+e+LOtkJUue1CcU5R3IiocHhFOQI/qQc3NdTDa/LX9iEF4gW+CyiX7fD+dDYXQvC0opOsqHm+nqMl704iVu/nCbKI8k3k/pylEV6gifv0SuJ7JiD0BrNkYP7+K98+tXp+UmHHUBZzVIcg0xxQJSfQBuhyjCLkyQ9nc7dZRNYkeC9k803SXdmlFJIqYI0LR3+wf9fr8U06qZRWJwqw21u9yIQr7XNm90nbXsdjyTSd+Ul28ZLgwZDcXDT15wt1bJC0EhkYM8Qq5XiXxpaXnL2KLdxHVYkeIYU6vEb/Cj/g5xeULscNViV2Hkmxo2/fVU1CY56lmikd4xzOyf+URfQ7Mdqk7FqukWKjpYXg0+9t8K0Q6q+QU1KPLl3TvHC8kkCmqWWvfSf41cbsRNTpsU7pwOS9Y//FKtMRTEZkwPI4uj55rmc8kKrhot9pEfg9YiuicDk34rMoOH4AFzBjXvfN/wYHVtRZV0xkYz9xk/LnpYh10sB1JSHhyCFBvsbOsVmc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(8936002)(5660300002)(2906002)(4326008)(8676002)(83380400001)(508600001)(54906003)(6486002)(956004)(36756003)(2616005)(186003)(38100700002)(26005)(31696002)(66946007)(31686004)(66476007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MndkOWlpTDBHcWQ4ei9vRXNSMVJ1UEZGU0tJOXM3eklVZUJjYjJ5eG04V0FH?=
 =?utf-8?B?anlTa0hLNjFRSUdncUtLY3REeDZQbFJPY0EyeGN3eUQ2RXJHZTJSVWtXS0Zr?=
 =?utf-8?B?K1dXNUNDV2crdExsaTFtcjRuNjJTbWxKK1pEZytIaEQwOE1xVytYKzlaYUNz?=
 =?utf-8?B?VUViOUtYUTJpaDBPU2JBeUtYMmRFTFdjRTl1WUdsOXJZa1g2aFZNSytKRW1t?=
 =?utf-8?B?Snp2UnJFa25ZMjhpWkNTWG5GbmRmNjRNczNuNEhFa3MvSXRuVzR0QXh4Mnhx?=
 =?utf-8?B?ZFhOOUNld2pveVRKQjNpMmoyOGQ5R1BZSC9JUmdVZHRReWdvSjFPK1Roanov?=
 =?utf-8?B?dy9kWCtrME1aZDBFNDBBWWpyOFVuRWc0dkNCRzBSNm91MU1pQnpLSDFGL3Iv?=
 =?utf-8?B?cUlMUkc1V1h0Z3VTd0JWSWdOLzFTSlUzNVhnWW1xVjBWall3dHdnQWF5WGRQ?=
 =?utf-8?B?UC9xdDFpTDR5ZVZXSUFDZGFlcHdIZ1NtdzZWSmt1L01WYVZ2em9jUi96dUFT?=
 =?utf-8?B?SmFCb1V5SysxRGpXMGdlaWlraEd3SXZYb2orOTRwUFlvWEN3TEQwVkFKVjVz?=
 =?utf-8?B?a0lFT1ZXdXNxWHRpKzVjSUEva0hLVXJQR3pBaEI3RVlpcm1USUZWTU1ITVlU?=
 =?utf-8?B?TVhQZU5CdzFYeXJhT1dFRUhEWHFMKzhvY3NjK1dxL1RhbHd2cThpMWJxRlNy?=
 =?utf-8?B?dnBmazBDMDM5QkZ0Ulhmb3Yvc3QzODNMU2l6ajBpalkwZ0ZEOUpkckhUTzF6?=
 =?utf-8?B?VlFFS1VkU09qM281b3pBUXVFeGdBdXppZk5CakNWeHBldnRhQWFmVnJtRDdp?=
 =?utf-8?B?VWc2UDdPZ1RoWDVOd1pPRjFqanc4bU1HK0FpK00yNTF4TXI1SVA1OXhJeUFK?=
 =?utf-8?B?OEFFdnBac3hOMHBlL2lMVE5DcEpBdVBtTDFiK3VmZHJMdkdCYy8wMDJocGZw?=
 =?utf-8?B?RWp2Vm8rVGhlK3h4THlQcHJWdkNsOHFwbi9TSTBZQXpWME1Jc3pwdkJtekI2?=
 =?utf-8?B?aStVTGhhZnVyWFpUbWtoQVRLTUpHbzhheGE3NVJDRnYyOEM3dW56eDZWSXNC?=
 =?utf-8?B?WkZQWEJ4ZTkzV0pETnVOVGtrMGlBWDFrdUhhbkFYYkZXaEFHTlBJcmVuWDFP?=
 =?utf-8?B?RkVBeGtiZWJVSmRpRXdZOVBneDNoSGJQbmNkcHlDeFVKd0MvTWpGUlVsWXkr?=
 =?utf-8?B?T0pJZncvNmhhNUkyRWJLcEt0eU5sZ2x5bWlHWkhIVC8xeUFsQ0JNZHYxcUJn?=
 =?utf-8?B?MmhqRWpkL2pCeFdLQ0gvY3dTbjBDRGh1SytsUFg2dFcrWm5EZllJSDR3bWlG?=
 =?utf-8?B?czF6YVhQOTEyYU8rNSs2S3FubEpnVnJoclo2VWxpNTVrT1plQ0NKa2xsUEkx?=
 =?utf-8?B?S20wSFNlUUNCZUZ6K3pWSjNlcHBvZnA2T0VVbVlPdk53eFJ0R0lQN1NuR3Ew?=
 =?utf-8?B?amk3dWR1NC9Sak1hc1hpamZDTXlVdGdnSGY4MTA2YUF6SjZtYU5qd2M1V01I?=
 =?utf-8?B?dllxQ0VRNkQ1TjA3Yjd4Y1V3RjQ3Uk9PcUxFM0JTN01pYkRCN2F1clRyaGJ6?=
 =?utf-8?B?M2JxUTg3OTNQMjhKL29yWlhISXZjbGw1UnhaYWVHMUtmUDVHV3VBL0t1elNY?=
 =?utf-8?B?aWI4MkpkaDJneG1CSFpuRENMVzIwOHFNYVNJcjFlVlFTTXNzY2MxYlMybDV6?=
 =?utf-8?B?UHo5c3JxRERCVmY5ajBwMWc1c3hZaDM2NmkrZkdiNklrQ3NqSys4bjJzWEhi?=
 =?utf-8?B?bUVndmdTd0FNNmNmSzJOQ2l0Z3MxaGxpU2o4K2Q1Y1F4Ly82NnNJN2tHOGVp?=
 =?utf-8?B?d21JUEZqRDZ3NGwwL0JzRlExR0ltdmlKQjdVOG8xMXhRL1U2cFRTSUx6V2RD?=
 =?utf-8?B?ZjFRNi9WRlY2UTVsUy94UkRSSmFhZ1BHNlFNRUcvN3BrRFVneEhkODRQLzQy?=
 =?utf-8?B?OUt6dVNFS3VaWGVMM1FpaloyRXgzaHhUZzJvUjBQSVZSV0plYU11d1IwU2RR?=
 =?utf-8?B?QU9CVk9EMGhFVkxZUkJYZHJqWjRNQ2FTamNtY0Zhc21mVkVMbm5JVk8zdzFu?=
 =?utf-8?B?Y0NlaHl2Qy95SVlDb3krYnMyTmdnK292bWtCbzhYSkxXYXlFaGwrbW9rOTh1?=
 =?utf-8?B?dEtFNFhmK3BIOVpESG04YUFTTHVpV0FUcDM4cDFlenFEYXFhNDZBQUNPUDdM?=
 =?utf-8?Q?1WJF4g4dYWct2Cikf9mdi6A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 084287df-8497-4aca-636c-08d9b65548ee
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:06:06.2793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r9AYsZLSo+4t/iINfivrIxR5brrFFY01/R1rBmftFceYwH7kn4f3dPEEVwdS4HZaQigYTxB025JykEm0yqDpXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

This has gone out of sync over time, resulting in NPF and XSETBV exits
incrementing the same counter. Introduce a simplistic mechanism to
hopefully keep things in better sync going forward.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Given their large (and growing) number, I wonder whether we shouldn't
fold "SVMexits" and "vmexits". They can't both be active at the same
time.

I wasn't sure about the #ifdef: Using CONFIG_PERF_COUNTERS there would
seem slightly odd next to a construct which specifically abstracts away
this aspect.

--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -2644,6 +2644,10 @@ void svm_vmexit_handler(struct cpu_user_
         goto out;
     }
 
+    /* Note: "+2" to account for VMEXIT_NPF_PERFC. */
+#ifdef SVM_PERF_EXIT_REASON_SIZE
+    BUILD_BUG_ON(SVM_PERF_EXIT_REASON_SIZE != VMEXIT_LAST + 2);
+#endif
     perfc_incra(svmexits, exit_reason);
 
     hvm_maybe_deassert_evtchn_irq();
--- a/xen/include/asm-x86/hvm/svm/vmcb.h
+++ b/xen/include/asm-x86/hvm/svm/vmcb.h
@@ -302,6 +302,7 @@ enum VMEXIT_EXITCODE
     VMEXIT_MWAIT_CONDITIONAL= 140, /* 0x8c */
     VMEXIT_XSETBV           = 141, /* 0x8d */
     VMEXIT_RDPRU            = 142, /* 0x8e */
+#define VMEXIT_LAST VMEXIT_RDPRU
     VMEXIT_NPF              = 1024, /* 0x400, nested paging fault */
     VMEXIT_INVALID          =  -1
 };
--- a/xen/include/asm-x86/perfc_defn.h
+++ b/xen/include/asm-x86/perfc_defn.h
@@ -11,8 +11,8 @@ PERFCOUNTER_ARRAY(exceptions,
 PERFCOUNTER_ARRAY(vmexits,              "vmexits", VMX_PERF_EXIT_REASON_SIZE)
 PERFCOUNTER_ARRAY(cause_vector,         "cause vector", VMX_PERF_VECTOR_SIZE)
 
-#define VMEXIT_NPF_PERFC 141
-#define SVM_PERF_EXIT_REASON_SIZE (1+141)
+#define VMEXIT_NPF_PERFC 143
+#define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1)
 PERFCOUNTER_ARRAY(svmexits,             "SVMexits", SVM_PERF_EXIT_REASON_SIZE)
 
 #endif /* CONFIG_HVM */



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:07:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:07:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237512.411931 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ld-0005kT-4m; Fri, 03 Dec 2021 12:07:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237512.411931; Fri, 03 Dec 2021 12:07:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7Ld-0005kM-1f; Fri, 03 Dec 2021 12:07:29 +0000
Received: by outflank-mailman (input) for mailman id 237512;
 Fri, 03 Dec 2021 12:07:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7Lb-0004Rn-6z
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:07:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9482a559-5431-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:07:26 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-FAZvQMsONi25VyTIfy6i3w-1; Fri, 03 Dec 2021 13:07:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 12:07:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:07:24 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR1001CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 12:07:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9482a559-5431-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533246;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ms0YHIDv5FBReZC9ySpmTf7afFn9dSpJLL3t23RnwNE=;
	b=bGnQWmiZTnPgU9kWETHVHSSbG/xU6V5Fz8Qb5ZBVMkCW/qHPTvjLp5AzsrKLvJzsdCsAmU
	qEw3kJ8MjdEDZD9bYLwO9eMZOUgrczOmUdnjj7+YU2YgzB6DFS9ppNVukkH9ewf1BzHcJv
	pWdQdoXrHjageyYyEiJAR595VCoOtWY=
X-MC-Unique: FAZvQMsONi25VyTIfy6i3w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cR2ezW4bj9BBvDk1dLj+Iwniy+DMTauA4SLL+43kZXbVAB5OJo1vudK3a70zRykmztKTGr4AmmUosby1Fb3sw9Pdr2pyBi+T3n8BEtxRm9I+LJJrcZ+jJEdHG5BCJ6lipZAlQiYemaVVa7V7r4VXY/6tfRCEJj/+1vKPn0/j8q1hozVLTsTcaZsezi4/tSqZwkMSrwbZMQozdLiZJzIZbvgreUCr5aHAPUlKn6P5i8oa2AO0XQ/svq34YvFrjPeAMJzKKMh0LpiDjrgPQ0W/g/kIdRQRUy3cT5tLTRq6W6yHdeiTZEd57m9zeQzVMk5rqZfC/taksC5DLLBU6fHyHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ms0YHIDv5FBReZC9ySpmTf7afFn9dSpJLL3t23RnwNE=;
 b=DqxKR/X9lIIscjP9rs+vxRIKTipCqogWbuns3njs/koiS5wyqoUSzQm0L6v7M1VGwQPNOg96yJ6N2KT0wFOT8BFE4tG9/FvZUsHo+1QW/hb30fulx0pMuBIIWM8JQu06sGAHRLW07+RoHg9GL+ll3PFuQ2F2eHH4RYpX35iJ/Ma/mV1LLi3kJuACCDFZYau5qlJrsgkb4R5hmaSemEOFzer1ghb20erdYPOyIz4wU8I0/S0bXLlfNqdPTE4NfgLF5RJfvIHowIDe/iX7iw3R2/rBHhu2qBqxf023cYj30wCUte86SCDSzlUYbQZwqS1uk6WdxMjSXhESKVm1//zXfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dcded1c5-85c8-dd43-6662-115652ce7932@suse.com>
Date: Fri, 3 Dec 2021 13:07:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 5/5] xenperf: name "newer" hypercalls
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@citrix.com>, Ian Jackson
 <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
In-Reply-To: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0011.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f6d02cf6-7dfa-4641-c8d1-08d9b6557769
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191AA42FCC11EADF4F8D8B4B36A9@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ib0gUJMBMdgPLzuafH6a+RCwI2lLJjWdN9Bj/y7FT22ytfjoeFAnZKoq+VgUFwGvDqO/VTdqhgxph0vNGySH1X5AGR7doyOr/5Gj9V+Hg9MDo6b/yMDITFAtbXlCt0joWZJ/ETDIke+aV8iNApS6eULynpiXkOVD4OEVoRMjTbu1aD5Kx7LO4x+lH0UMZhx5N6W4tR+gG6nnLLXQN0VSdi3KawC4Hz837lQQv9lW7QQt5y2uMU8c9IC+rLzBBa5RzCLdjnXSIt3nBm4fEA0h4iulztX7aw8GMV7JsgKbU2JkPGnwkuTNAT61qogv2Dhxj3nz68nBoQ1F2g4fVggUMQhYedvOkUy4ehPjvaLAJjJlNDhBt78ErT9SyKw588rbMeZQs76a/g5v6DrpTTNAcu5pezXmkzW62BV1BOYAo7VYAWlEks6GGO/IeQhfrjcDIFuqsF4Q8K3wzYQ8tYrffqEo1zf9PRLaQuW6vy9ujujpBb5cjkrb20f270u4UEpLJgyxKYv0wPa++2zHi+crmqjgBKIkVPNAFpjpoGvdkG9vi2IKVsOzkpD3gf00VJ5K3yvbu8L0L5Wrp8ebbavwx0OVNi+vHnCCZSxP+9UVqxBF627UVw+wCSmvXiimSwqXnOKLqWU/CcAWc+d2rhfBEtDYvFdSANIFOYP0I/xduhwX1iKKO1Q+K8WBRy8QYPZ3+gZslXNAa/r21C7jX+NSI+7q2W3MJ7afLPuTsAh3s4w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(8936002)(5660300002)(2906002)(4326008)(8676002)(83380400001)(508600001)(54906003)(6486002)(956004)(36756003)(2616005)(186003)(38100700002)(26005)(31696002)(66946007)(4744005)(31686004)(66476007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUsrSWdsZWUyNE1ZOFp3OSs0VTY3Vlgza3dva1YvMHZiQzdSUDM5RVltRFR2?=
 =?utf-8?B?Z0lQZXJucUpsTThYNmt0MmpwdkJjNHIxRm4zOXF1UkFLQ29BTjNzNXVNMVM3?=
 =?utf-8?B?eE9rS2dJeDhDQ3AzTzI0RHNDUmFCYkVPY2tadGFpOWQ1dHlvSXZrcXRNOXpV?=
 =?utf-8?B?TC9Ockw4L0k2V3l1QWFnUUp2R0JlK0xua0x2NjJBNXE5UnZsTkxhTE1nSTdU?=
 =?utf-8?B?cHQwWURaRGwzdTlJK2JHbVI1c0hSWC9kYzJQZHJhMEZXRVV0U3YzYnVuNHcr?=
 =?utf-8?B?REFsbnB0b2lKNkRZMWRBbHNHeXpDUitINnhkOTRZQ0JmTXYyR3hXY2wyV1RF?=
 =?utf-8?B?aDZBekJZMW9UOGp0dGM2NWp1VW5ZbndTMlFvR3VxUURVWCt6RVMwV1o1MDNv?=
 =?utf-8?B?TUR5ODdNNm51VUJtNjFWaVp3QitFWjRWTlBINytmRTFwWHpnZ2l1ZzdQTXhz?=
 =?utf-8?B?RGtvOUIvMk5SSnI2WStxaUQ3YTUvbzZncHlQcUFVNGorSHBvazhsWDdERGlm?=
 =?utf-8?B?S1RtMExqc1dMMUYzWFdVU09sVXluRStIK29LVmRyUUZMUUl5ZHkyblB6MXBB?=
 =?utf-8?B?bGdHL2dhL3JvUFkwYTV2QjRMbGRFT2ovV3luV25obHRVKytubVh2WjdhNmxw?=
 =?utf-8?B?YVhkdklWZXRtQjBEQ0ZIUXUrOHAxQitOUWNOWnZhSmtLMVd1NTkzOUxsSDZ5?=
 =?utf-8?B?d0s4Y0FCSkRXWk1HVkh1QmYvNkxWcVA2REFQbER2R0RlblRMaDRDcTFpbkJK?=
 =?utf-8?B?S25KbVNsMkx3UkVVQUlTNUtBRjdDUklkSXoyakIvRlBUMGg5bE9GeHgzN1ow?=
 =?utf-8?B?MGQrOFBmaG0xSUxadEJYcWpEbnRrUFNodHJRUnA1NzNnNkJWQStpR2FuNGcr?=
 =?utf-8?B?dDVuSDh5TEFIVFNRdEZMbmJxTUg0QzVLUWZLbjdjdDdLaVpmZm1pZTJlQkY1?=
 =?utf-8?B?Ylc2cFR2TFR1SUlGVk8wbC81RU1lOGRqWFlPaXBOUlcydDYyaHp1WUdNU0ti?=
 =?utf-8?B?QjNiaFJOVTRabFd3bnc3T05OQVFOSFY4M09SeC9EVWNBVDVjZUZpbW1pTHkv?=
 =?utf-8?B?b0JHV29NNmdEUWtCcFg0THkzU3o0ZGJtLytYaWtseG43aU1RWTJ6Y2o3eS85?=
 =?utf-8?B?QkJkUDA3NWpLWXZod0daSzBOMGJNc0ZCb3VtSFpWVTE4QTJOdTJrQ1paa1NZ?=
 =?utf-8?B?ek84NklMWm1Ed2VHZU45T2NJK2ZtTTVvQ0lBUFBOMVJnWU9keGUvdTQ5dWpw?=
 =?utf-8?B?OTQxVEV3MUZ2NnhPSTdpZ0tHbllDU0dCdjltN3hwNTZIWThQV2xoeTRySzU2?=
 =?utf-8?B?TjRteE9HVThDcVdvMG5XOVdXbGdzamVLbUJhakpuRk5Ed2tRd1M2N0s0aVJL?=
 =?utf-8?B?YTR0bk1LVHpocEpWclNtTHFLT3Y0Rkc2YkUzSTRzWFNSMzd3d2Nhc2pidFZz?=
 =?utf-8?B?SDlOM1hlVUgyaU9objFZanhEK3lILy9ra0E1ekNLTkFQdTBCeURMOXBQOVhJ?=
 =?utf-8?B?eTFMNFBJaGhUdFlSSXVlSTJTaG5aRkM1S3E2b2oyZ3FzakpQcTl3VE5WYVdD?=
 =?utf-8?B?MndVRzlMYkl3T1BQa013Qnl6eU8yK0VuRklYdGdyOVNidnZIck9BeVVJNkVG?=
 =?utf-8?B?R0ZPRzhnL0p1U0NDU1VjcUFNYWNNK2MrTi9lZFdiSTZndS9ZNEkwQXhqSXFX?=
 =?utf-8?B?NmloUDZXWGRxOVJPZXpreERzOFpwV2oweTdxRFh3dWc2dHBTRlFjcTdXN2Ur?=
 =?utf-8?B?S0c4d1d1a1VKbmlIUzk0M254YU5aSVhPbzVOVXRJYmcwWXFYRzk3L0wrbkNF?=
 =?utf-8?B?aDVYbVg3NmJoWHdycklmMWNURWhIQlhQYjZpYzliWU1wVlJlY1hjUXJvc0hG?=
 =?utf-8?B?WHZxZFVWa1R6S083SE5uOGMySWxZcW8xYnFzeHIxS3dLT215K21iVkJVTGtl?=
 =?utf-8?B?K0lEd2xLN0p3cmNjRUtVR0daTjBNOUVTMDJVMWJFd1p0YWt2SnJwOFBlZHNN?=
 =?utf-8?B?Q2E3N01hTFhmOUI3M1NrY1JGQS9HY0ppZEJHTFdzRnRJTUJuSytQVWY5RDZn?=
 =?utf-8?B?c3VXY0tRbjg2NkpBVFFWa01sa2lPM2NYMmY3L0g0QUo4N3BhSHpGdzdNMWMr?=
 =?utf-8?B?b0ErSDVVckpoQit1VDVta0VqZ0l3ZHFCVlpWdVJSbnhEVU1aV3FBdFpqNjl0?=
 =?utf-8?Q?Lu7C/i3/xGiyOJH70RIFQ6o=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6d02cf6-7dfa-4641-c8d1-08d9b6557769
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:07:24.2512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ixtlYJ56UE+a7ubUQfRnFBp54EwMArX1ODunnjrv1joCHt2NtlPCwXEpHfSJPY/m2uEJuP77cD3UrmLjjLwpXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

This table must not have got updated in quite a while; tmem_op for
example has managed to not only appear since then, but also disappear
again (adding a name for it nevertheless, to make more obvious that
something strange is going on if the slot would ever have a non-zero
value).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I wasn't really sure about x86's real names for arch_0 and arch_1. The
tool runs on the same host as the hypervisor, so __i386__ / __x86_64__
conditionals wouldn't be inappropriate to use ...

--- a/tools/misc/xenperf.c
+++ b/tools/misc/xenperf.c
@@ -18,7 +18,7 @@
 #include <string.h>
 
 #define X(name) [__HYPERVISOR_##name] = #name
-const char *hypercall_name_table[64] =
+static const char *const hypercall_name_table[64] =
 {
     X(set_trap_table),
     X(mmu_update),
@@ -57,6 +57,11 @@ const char *hypercall_name_table[64] =
     X(sysctl),
     X(domctl),
     X(kexec_op),
+    X(tmem_op),
+    X(argo_op),
+    X(xenpmu_op),
+    X(dm_op),
+    X(hypfs_op),
     X(arch_0),
     X(arch_1),
     X(arch_2),



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:09:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:09:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237520.411953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7NF-0006jG-Rw; Fri, 03 Dec 2021 12:09:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237520.411953; Fri, 03 Dec 2021 12:09:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7NF-0006j7-Od; Fri, 03 Dec 2021 12:09:09 +0000
Received: by outflank-mailman (input) for mailman id 237520;
 Fri, 03 Dec 2021 12:09:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7NE-0006im-WE
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:09:09 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d10b6660-5431-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:09:08 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-ajWXNYwuOJ-jlQmmTUi3NA-1; Fri, 03 Dec 2021 13:09:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 12:09:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:09:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0168.eurprd06.prod.outlook.com (2603:10a6:20b:45c::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Fri, 3 Dec 2021 12:09:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d10b6660-5431-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638533347;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=EEAm6RV7+XIh6QsPEcjZTodJxZuPMJwRlxvbvSLKLZg=;
	b=I1Nd1QRcUu6HyqARmHV/qgikkgFje0LdfvsrsNMy12DDB4ioPdG6Z9N3+Melc8BcvkH7Zo
	HSkMUIQENZIJJZaxP4e8AkTpq+VzcLeF7fFjQ3yYbd4Yk7dp5m/+sWqiLvMDdNyKvIWfRz
	LtEmbKeTR4dzhK7eU/IugSXP79xCeLg=
X-MC-Unique: ajWXNYwuOJ-jlQmmTUi3NA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XUSmjy3mo8kcJaKxpaLK5FFGUYK/OqtdjAS2TJxvBdA20u22M6hurjFzCYoJOaJhz8jpubtnM12K5JJdCJJKL1PkyuZJHLNewPoQ843ltvrVqWl4cR4rZqf3y60cJMAUm3kzBXlwl4imjSufnAYgmgEHXbxpis5YylrB7CjR3H8FMo7EGOeN5u2+G+52nGtKTWWW2//AxWM2O9VlNDN+BFHZnwDZADhkV9RkAgb3+rFnCr4FyKOyoi36EXh4waGNDKjq9t57xSZLSFT2pSapES48LM7bxblBHSO4FaZ/w+ruVsL/zzB1QYsOBNRcyhTj18R4lmtKAreNFrlSKMVcqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EEAm6RV7+XIh6QsPEcjZTodJxZuPMJwRlxvbvSLKLZg=;
 b=QyRZMjbkOpclCTHyxwhyVL0O9RFSpfWZbkFHxIkW3nqdfNO3fk946iFXbNxNuS9Ib3YGSeC4SjAV/uWkWBFjt0qYxldwbZ5BWua55jP4jg0+AN4JednA0eQzuRBaxj6xxF4a0WXojipUR1dasVHBTaku/CH2i0+Uu+Ea+5bY/PI+UOsq0VunSAALZ8seQC+0+Te33oPPeGugFhXgYoQU8RE71MB+9yq0PiTWL286SV5rlOZrXdSQZg1mrCZYY/GZsZG4LZD/VsJrfvbh9qHGmkPcE/6pbEdTqsSjMxGGGG3eb23QZ28Cs2gSORLGhkswTsfWHRbebM98h6fz3xhU7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <94338540-4bcc-7ad7-9de1-944c0dc96709@suse.com>
Date: Fri, 3 Dec 2021 13:09:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <iwj@xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] tools/xen-detect: avoid possible pitfall with cpuid()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0168.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6714bd0f-aad0-49b6-152b-08d9b655b3be
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41911C673A609DAA1A03379EB36A9@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	JSAl1RhD8/ndmaUjPV+zdV149R26xoP3R8bIXh9ACZnk/DtjbEbJsBizoVktmmaVCAOqzwq0U3rI9kGnqO/HuDnsmFJ7DV8X5vVUGfAvJB0AJJY97XQDRx92wF12h7p4l5gzYsQ7jVudIehqIfgoHK1gA8U6E9TwwXtT2fhEE1SEGnqJZBw/MZocAmfuDDv2JZwT/cKpOZ8bOsJPVz1ynO0JVqzvNaOKcfuWYODG3v2ihYEXUMTL2HNNTW0q6/F/hk3vLjl3izFIEpxLkGDyg7Yk0hjpwCN4Qz1VcyC6kS1KYlwPpUvHz0hAwklCdICnc7SYaKNDej+C6+UrhsRJ9Y3an+or8MqiIFEPFJdiJHm9NNWDXMSxICkVoT029w5KaqNNvINCld5grvSO2q5F0W04KYW6u+bZ+hqCjbhk/nEXpwOLPAmvGiYkruaetfyAAbocIgrLv4/jqXmmQ8Aagnqn9xWPRlkD+YZad86jyLgXmTIdDptR+URrtozBS32Nl7GMY3AZpHx7cCjHM19Xx+QYlUQUZDTTar7AfI+eG6mPUs0qhcZpZbesSjjy21uygfX9cUgz1AmnS78WuTOifksoJW5Dxi5ha+mgVsibuJkSZC8B0xfD2/d5FXIqRWejECEoNVVLfvoU3wU8j6Iqw9iAqDqlWkDsqDw/rX0qNXM3BkhlG6Fkx1ybiwWjynYBOVfjcgBrftE6tbJyZKNZnqcSr+8vNBiWGp/ip41WVV0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(8936002)(5660300002)(2906002)(4326008)(8676002)(83380400001)(508600001)(54906003)(6486002)(956004)(36756003)(2616005)(186003)(38100700002)(26005)(31696002)(66946007)(31686004)(66476007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGVwZkFQZGxQRnFJSVRULzBNa1VTUktYejBEeUUzZEJxcmV5eVNDK0M0UDNa?=
 =?utf-8?B?REpKK21NSmNDLzE1b3RpTm1nMERPZExtUExnNjljWklmb21IekF3MTZpbWpX?=
 =?utf-8?B?N1dQZWVtY3ZFeEdwMDJ1azIvWFlScTA5MVlHN0ExTmRUaEt3d3ZSSEhSWTkw?=
 =?utf-8?B?RnJ2QUFoaDY1WU1nVGp4WUpqdXlFSVJiNlg0dkg4cWVCOGNERkFEaTljNVph?=
 =?utf-8?B?Y1dkTUtDaUVLVWM2STlnYWF2MTBRRXBKRlZQYUZGM2gzSTh1VS85aFFGTHAy?=
 =?utf-8?B?eUFkdHZXSUJEenJUWk9wV0dkMnkwNlNvUmlYWis5T09ySjJLNmpGT1dyZStj?=
 =?utf-8?B?RE9Zd1BlNVU3QjQ3d3FMSzdYZjFJenRGamkzWGtFejA2VEJGRlgwV1dqbHpj?=
 =?utf-8?B?dWZzZ2ZWc1hYTmpaOUJuUVBXem1FMWtoNlZIL3A2ajBUb3JPUGlOWGlKUjhN?=
 =?utf-8?B?T3ZDWXk4RGFLajZjWk5ManVIakZ2UVViK0ZoOTRNeEdqMkJvM0xJWE9iM2Z2?=
 =?utf-8?B?ZFdwQkdqRTV2dDFwN3ltYyt3R2k2aTlpMUErN2hWeVh2QmJOZTRjYjRyazZw?=
 =?utf-8?B?NUZQMmJwZU5KcWRkT2YyQ1RRMFBpdDMrV0lna0lVdnhYMFBJeHgvbHFNRnQz?=
 =?utf-8?B?TU9DVnd3TW9nRHd5VnhHU2phOGpaNzhINlY4b1ROVmZ4MXZhZHZsK21mQVpp?=
 =?utf-8?B?T1dxVzFQTnpCWUZmOFZsVm4wc1c4ZVpWR1FUckQ1c3JOaEZXd0lOZkRNREVh?=
 =?utf-8?B?SnpJTDVkZytScmhQLy9UU21hamxyVE5UTS9sYkRNL05CNEc5RGtYNFBFSXB4?=
 =?utf-8?B?c2laNGwwcGY3b08wdWdaWEJMKzRrOUFtTVZwbU9iZG0rZ1NYdTdhdEt2NGJh?=
 =?utf-8?B?dlI1RU5Qa0pBcUdJYzU4UlIxVGJOTTJzQyt6TG9jQ3lUaG9UUmlwUDcwT1VG?=
 =?utf-8?B?TVRETHVVZUprdk5TNkNMdFJlK0FQTzFXUjRwWVFkRGkxaU9SaFBJQ2dHWGdi?=
 =?utf-8?B?STZ5R2VhelEzR0Zkc1hoTDd2VVhXWHg0UU1SMHV3WThtalVmNkR5NHF2YXg1?=
 =?utf-8?B?TUJHTnpkb0phbEVTOU1FWFJ0VTdCRGhKNCtMYVgxSGdSOGE5ZXRjNnR0aG5V?=
 =?utf-8?B?aDJMUHl1ZE9xRllSaWh0a2txWGJISkZIZm9ERkorTE5QWU5iV3FQbHlaa0xq?=
 =?utf-8?B?aXhxbk53OU40SmlvdU5VWnFob2Z0Q1RRclVxc0s5WkNTYVNKTnM5eHRUQzNi?=
 =?utf-8?B?ajJSK2ZWdTQ1WjNHekhUVTJ2UFRKSzVDOFNLWnRkbWk5alN4RzdhRU9EejNU?=
 =?utf-8?B?QW9JMWs3b1hsNjY5M2hQMm9zajQ4K3JaWHBUR1IyTU5XL3VabnN5RnJUY3hw?=
 =?utf-8?B?R1Q0R3JacFdENWc0SkF4NVVhb3RwNEJVc3VpTFIraW5RRzU0VHdTUXcrMUg5?=
 =?utf-8?B?eGZvaTRCbjZXN0xmSHlmRjlOMXZKQ0Z3bXBlOFNzSE1Jbk12UEN0UkMwcWNm?=
 =?utf-8?B?WjJBT25ML2pHUHhMWjlacjdyQmZYazFlK25kWDU2Qk9PdXhEakhFdkRGb092?=
 =?utf-8?B?U3NhYUxINjNpazJvTXhoSTRFUUo0ZVBXemJvTU4rd2VwZHozRXpiaE1EZ1Nx?=
 =?utf-8?B?bDN3a3IvZm5UY1UrZzFvMVhaQnEwejFTTzZqbzU4ZUlSSE9TUkEvcVkrNm03?=
 =?utf-8?B?RUJlcWxleGNvcGVMV2pQN1hxN3lEM1Y3VWdFYTNZbi95dkU3YnF5NnFyN0J2?=
 =?utf-8?B?d2hWL2R5RlhHNXN2eEVXcWhPTEpiZVJjVmNMQTZWRzdnRHRnN09JdVQ3WlZi?=
 =?utf-8?B?bnYrSXl4dXUwN0tlMEJUYzJseDNva3Z5TFJSWUFad204RnJTbXJKOW14RTlw?=
 =?utf-8?B?UWRQTWt5azhCOFB1amM3UVZaT0RSRzJxN1FDSXh0di9LaFZhaTdEekVtdzlx?=
 =?utf-8?B?RDlEOU1VMjIySlErZllOa3E1R2VYK21BNzFmQ1pyMDhTY09VZTUwS0V3TEM1?=
 =?utf-8?B?VnFyaUFlNXFBdURFalU1Vm9RTkEyUk5WRUhhQzN5eTVUVGdBcit5M3MxYkdp?=
 =?utf-8?B?WnlQRG9mVGh5eUwvWjNKa1lCeXNXT29pckhUYnBERDRYMEd1TmFnV0pJb1Rs?=
 =?utf-8?B?OHJ1UXJPRnh2K1pkaWtEYTBSSGg0VDRTeHcwVG5veVJKeVZxaW9wRDFxdTh0?=
 =?utf-8?Q?+/bSerdUjr/nBZyZZc2LoLg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6714bd0f-aad0-49b6-152b-08d9b655b3be
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:09:05.4709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UYlXlLyJ52J+Z6KoH2Buu3WJXzZSD5N1A1Yc/eEixMJvP1m3ZoD5c+5k76h8Vhq8/0UpN23TqkX88z6t8lA1xA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

The 64-bit form forces %ecx to 0 while the 32-bit one so far didn't - it
only ended up that way when "pv_context" is zero. While presently no
leaf queried by callers has separate subleaves, let's avoid chancing it.

While there
- replace references to operands by number,
- relax constraints where possible,
- limit PUSH/POP to just the registers not also used as input,
all where applicable also for the 64-bit variant.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm pretty sure %edx also wouldn't need to be subject to PUSH/POP here,
but I didn't want to go more "against" the comment than obviously
justifiable by the input registers used. In fact I've observed gcc to
pick %edx for putting "pv_context" in.

--- a/tools/misc/xen-detect.c
+++ b/tools/misc/xen-detect.c
@@ -52,17 +52,19 @@ static void cpuid(uint32_t idx, uint32_t
 #ifdef __i386__
     /* Use the stack to avoid reg constraint failures with some gcc flags */
     asm volatile (
-        "push %%eax; push %%ebx; push %%ecx; push %%edx\n\t"
-        "test %1,%1 ; jz 1f ; ud2a ; .ascii \"xen\" ; 1: cpuid\n\t"
-        "mov %%eax,(%2); mov %%ebx,4(%2)\n\t"
-        "mov %%ecx,8(%2); mov %%edx,12(%2)\n\t"
-        "pop %%edx; pop %%ecx; pop %%ebx; pop %%eax\n\t"
-        : : "a" (idx), "c" (pv_context), "S" (regs) : "memory" );
+        "push %%ebx; push %%edx\n\t"
+        "test %[pv],%[pv] ; jz 1f ; ud2a ; .ascii \"xen\" ; 1: cpuid\n\t"
+        "mov %%eax,(%[regs]); mov %%ebx,4(%[regs])\n\t"
+        "mov %%ecx,8(%[regs]); mov %%edx,12(%[regs])\n\t"
+        "pop %%edx; pop %%ebx\n\t"
+        : "+a" (idx), "=c" (idx /* dummy */)
+        : "c" (0), [pv] "r" (pv_context), [regs] "SD" (regs)
+        : "memory" );
 #else
     asm volatile (
-        "test %5,%5 ; jz 1f ; ud2a ; .ascii \"xen\" ; 1: cpuid\n\t"
+        "test %[pv],%[pv] ; jz 1f ; ud2a ; .ascii \"xen\" ; 1: cpuid\n\t"
         : "=a" (regs[0]), "=b" (regs[1]), "=c" (regs[2]), "=d" (regs[3])
-        : "0" (idx), "1" (pv_context), "2" (0) );
+        : "0" (idx), "2" (0), [pv] "r" (pv_context) );
 #endif
 }
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:09:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:09:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237519.411942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7N9-0006Rj-Km; Fri, 03 Dec 2021 12:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237519.411942; Fri, 03 Dec 2021 12:09:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7N9-0006Rc-GR; Fri, 03 Dec 2021 12:09:03 +0000
Received: by outflank-mailman (input) for mailman id 237519;
 Fri, 03 Dec 2021 12:09:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ek4d=QU=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mt7N8-0006RR-BE
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:09:02 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id cc91410b-5431-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 13:09:01 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E794E1396;
 Fri,  3 Dec 2021 04:08:59 -0800 (PST)
Received: from [10.57.0.138] (unknown [10.57.0.138])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B534F3F5A1;
 Fri,  3 Dec 2021 04:08:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc91410b-5431-11ec-b1df-f38ee3fbfdf7
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
 <4f14f0ec-82f4-df4a-5d87-9c39727b4634@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <6b66bb69-9cb3-3311-d690-848b95295d18@arm.com>
Date: Fri, 3 Dec 2021 13:08:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4f14f0ec-82f4-df4a-5d87-9c39727b4634@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 03.12.2021 13:05, Julien Grall wrote:
> Hi Michal,
> 
> On 03/12/2021 09:58, Michal Orzel wrote:
>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>> forgot to modify a comment about lr_pending list,
>> referring to a function that has been renamed.
>> Fix that.
>>
>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
> 
> The format for fixes tag is a 12 characters sha1 followed by the commit message. In this case, it would be:
> 
> Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq")
> 
> I can fix it on commit.
Please do. I forgot about this requirement.
> 
> Acked-by: Julien Grall <jgrall@amazon.com>
> 
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>>   xen/include/asm-arm/vgic.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>> index e69a59063a..ade427a808 100644
>> --- a/xen/include/asm-arm/vgic.h
>> +++ b/xen/include/asm-arm/vgic.h
>> @@ -195,7 +195,7 @@ struct vgic_cpu {
>>        * corresponding LR it is also removed from this list. */
>>       struct list_head inflight_irqs;
>>       /* lr_pending is used to queue IRQs (struct pending_irq) that the
>> -     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
>> +     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
>>        * no LRs were available at the time.
>>        * As soon as an LR is freed we remove the first IRQ from this
>>        * list and write it to the LR register.
>>
> 
> Cheers,
> 
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:13:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:13:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237533.411964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7R0-0008Pc-Dc; Fri, 03 Dec 2021 12:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237533.411964; Fri, 03 Dec 2021 12:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7R0-0008PV-8e; Fri, 03 Dec 2021 12:13:02 +0000
Received: by outflank-mailman (input) for mailman id 237533;
 Fri, 03 Dec 2021 12:13:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt7Qz-0008PP-6H
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:13:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7Qy-0003pz-MI; Fri, 03 Dec 2021 12:13:00 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7Qy-0006Qa-Gd; Fri, 03 Dec 2021 12:13:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=G08tjXDpc2BAPpX+vTX4PfvHnYD5+X0cErmJ/iHQFGc=; b=JGTPyOFErsR82D0qCQValf114z
	UbIuyyP415wutiqE6iD17YLteRa2K8Eomrdnhvw7tsLPaNlcQzUX+XR7RqqrEO12m62Hld5nDK0OK
	bbBM0jD5iLVg8leK9yBpYMX5diwTAvXc3KADHTP6Mr+5biMDNpJfymIluzHCb0U2Vblw=;
Message-ID: <8c0f108f-379c-cece-26b3-9fceccc6e91e@xen.org>
Date: Fri, 3 Dec 2021 12:12:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] arm/vgic: Fix reference to a non-existing function
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211203095837.20394-1-michal.orzel@arm.com>
 <4f14f0ec-82f4-df4a-5d87-9c39727b4634@xen.org>
 <6b66bb69-9cb3-3311-d690-848b95295d18@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6b66bb69-9cb3-3311-d690-848b95295d18@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 03/12/2021 12:08, Michal Orzel wrote:
> On 03.12.2021 13:05, Julien Grall wrote:
>> Hi Michal,
>>
>> On 03/12/2021 09:58, Michal Orzel wrote:
>>> Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
>>> (xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
>>> forgot to modify a comment about lr_pending list,
>>> referring to a function that has been renamed.
>>> Fix that.
>>>
>>> Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
>>
>> The format for fixes tag is a 12 characters sha1 followed by the commit message. In this case, it would be:
>>
>> Fixes: 68dcdf942326 ("xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq") >>
>> I can fix it on commit.
> Please do. I forgot about this requirement.

Done and committed. I have also re-wrapped the commit message to 72 
characters rather than 50-characters.

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:24:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:24:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237542.411982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7bx-0001hx-FG; Fri, 03 Dec 2021 12:24:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237542.411982; Fri, 03 Dec 2021 12:24:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7bx-0001hq-CC; Fri, 03 Dec 2021 12:24:21 +0000
Received: by outflank-mailman (input) for mailman id 237542;
 Fri, 03 Dec 2021 12:24:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt7bv-0001hk-Mo
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:24:19 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ef82b31b-5433-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:24:18 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44288)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt7bt-000Bdm-2M (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 12:24:17 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6A66D1FB51;
 Fri,  3 Dec 2021 12:24:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef82b31b-5433-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <eb59334a-ebb7-9cee-f7be-596deaf32d2e@srcf.net>
Date: Fri, 3 Dec 2021 12:24:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <53cf0492-e197-d3e6-8898-9e199bbc5399@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/3] x86emul: drop "seg" parameter from insn_fetch() hook
In-Reply-To: <53cf0492-e197-d3e6-8898-9e199bbc5399@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 11:23, Jan Beulich wrote:
> This is specified (and asserted for in a number of places) to always be
> CS. Passing this as an argument in various places is therefore
> pointless. The price to pay is two simple new functions,

This is actually a very interesting case study.

Both are indirect targets, so need cf_check (or rather, will do
imminently.  I'll fold a suitable fix when I rebase the CET series).

On the face of it, there's now a pile of parameter shuffling just to get
a 0 in %rdi, which isn't ideal.

However, for fine grained CFI schemes using a type hash, it actually
prevents mixing and matching of read/fetch hooks, so ends up as a
hardening improvement too.

>  with the
> benefit of the PTWR case now gaining a more appropriate error code.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
> In principle in the PTWR case I think we ought to set PFEC_insn_fetch in
> the error code only when NX is seen as available by the guest. Otoh I'd
> kind of expect x86_emul_pagefault() to abstract away this detail.
> Thoughts?

I have mixed feelings.  x86_emul_pagefault() is the wrong place to put
such logic because it, like its neighbours, is just a thin wrapper for
filling the pending event information.

Architecturally, PFEC_insn_fetch is visible for NX || SMEP, and we do
have logic to make this happen correctly for HVM guests (confirmed by my
XTF test, which I *still* need to get around to adding to CI).  I think
it's all contained in the main pagewalk, but I can't remember offhand.

However, PV guests explicitly share their paging settings with Xen, and
we don't hide EFER.NX based on CPUID, although we do appear to hide
CR4.SMEP unilaterally (hardly surprising).

Given the ubiquity of NX these days, and the fact that PV guests are
known-fuzzy in the pagetable department, I'm not sure it's worth the
overhead of trying to hide.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:29:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:29:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237549.411993 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7h8-0002Zz-3i; Fri, 03 Dec 2021 12:29:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237549.411993; Fri, 03 Dec 2021 12:29:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7h8-0002Zs-0N; Fri, 03 Dec 2021 12:29:42 +0000
Received: by outflank-mailman (input) for mailman id 237549;
 Fri, 03 Dec 2021 12:29:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nXUW=QU=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mt7h6-0002Zk-Dd
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:29:40 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae86f62a-5434-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:29:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae86f62a-5434-11ec-976b-d102b41d0961
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638534577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tH/VGVdJtYJdCNVnG83SXJ3AsmMc03qyODmOpVdcDS4=;
	b=xYaZvCwZtS2vFnzsBQ5VOMoblYtNt1vCBLPPUiI2MovBDFcrX+W1xQv0kH1WT+jl1WTouw
	mu3+/VDOxmaph/y5tWFFqXIgrnZo88AD7a1E4qKMJky69BH8z/vBeyK2bbh/I9zR8aT8ZS
	KxLlZM8lHFGzC4jk8O9OTVNdg44S5aWhCorI5DyXjQD4tVUfql5eazYnN1AStOT+Plv06O
	5vX/4ecr6lzNs6ghewDypetz2AKIrb7U4Wbxhd9bRJfSkzX8H5V0AtWXLjtIgCnq14GjqL
	x6InjLrMmNKU744M8beo+YWvGUln//9f6pQNS6s2CN79Fd9IRYiuJShql28/Sw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638534577;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=tH/VGVdJtYJdCNVnG83SXJ3AsmMc03qyODmOpVdcDS4=;
	b=0z+2aAy/+cRUeKX5JZDeihNkPRrp7mPzxSVuDk8R5JoI9jEZyK7Wuw6Gjx+OnrL+FBFuo+
	0u6UWtOnP/kp4/Bg==
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: "Dey, Megha" <megha.dey@intel.com>, LKML <linux-kernel@vger.kernel.org>,
 Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Michael Ellerman
 <mpe@ellerman.id.au>, Andrew Cooper <amc96@cam.ac.uk>, Juergen Gross
 <jgross@suse.com>, linux-pci@vger.kernel.org,
 xen-devel@lists.xenproject.org, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()
In-Reply-To: <20211203004545.GF364748@otc-nc-03>
References: <20211126233124.618283684@linutronix.de>
 <20211127000919.004572849@linutronix.de>
 <7ad200fa-dda3-4932-cd23-ad6e79288ea4@intel.com> <871r2v71mg.ffs@tglx>
 <20211202192139.GE364748@otc-nc-03> <87r1au68rb.ffs@tglx>
 <20211203004545.GF364748@otc-nc-03>
Date: Fri, 03 Dec 2021 13:29:37 +0100
Message-ID: <87a6hh6fda.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Ashok,

On Thu, Dec 02 2021 at 16:45, Ashok Raj wrote:
> On Thu, Dec 02, 2021 at 09:40:08PM +0100, Thomas Gleixner wrote:
> Not worried about MSI-x for IDXD :), I assumed the purpose of this exercise
> was about 2 things.
>
> - Fix the VFIO mask/unmask weirdness ending up disable, reenable with more
>   interrupts. 
>   - We are only fixing the case by not calling the disable_msi, but just
>     growing on demand.
>
> - Use this as a case to build IMS. but if we treat MSIx and IMS
>   differently, IMS would be bit different in how the dynamic parts
>   work.

Conceptually they are not different, really. You are mixing concepts
and implementation details.

> Although there is no real need for MSIx being dynamic except to avoid host
> vector exhausion, do you think we could still allocate specific entries.
> Since unmask is per-vector, is there benefit to doing just that vs
> allocating current+N?

This is either a rethoric question or a trick question, right?

>> VFIO exactly knows which entry is unmasked simply because the write into
>> the MSI-X table in the device config space is trapped so it knows
>> exactly which entry is unmasked, no? Guess how VFIO knows about $N more?
>
> bah.. i missed that little fact.
>
> When VFIO knows exactly which entry is being unmasked, is it enough to just
> allocate exact one, or do we need to all all N? I didn't see why we need to
> grown by N additional vectors instead of only allocating 1 for the entry
> being unmasked?

That's exactly the point. The current implementation does so, because
the PCI/MSI infrastructure does not provide a mechanism to allocate a
particular vector post init.
 
>> > Maybe for MSIx we don't have a need to shrink based on current usage. IMS
>> > requires both grow and shrink. But it might be odd to have 2 domains behave
>> > quite differently.
>> 
>> We are not implementing the full MSI[X] zoo for IMS either. So the
>> interfaces are different in the first place.
>
> The ones that actually differ between the MSIx and IMS are:
>
> - Discovery on where to find that unlike the PCIe standard mechanism.
>   (Although in initial implementation we have forced a common way to manage
>   this, but I think people already hinted this isn't going to work
>   for different vendors or even between gen1/gen2 devices.
> - Managing the location of the add/data write, mask/unmask etc.
> - Might have other attributes such as PASID etc for the IDXD case exposed
>   to guest/user space.

You are looking at this from the wrong direction, i.e. top down. Why?

Because if you look at it from bottom up, then you'll see the following:

  The base of all this is a function block which translates a write of
  message data to the message address into an interrupt raised in a
  CPU.

  The interrupt remap unit is just another translator which converts the
  write to the remap table into a write to the CPU function block, if
  the encoded protections are valid.

>From a device perspective the message address and the message data are
completely opaque and all the device knows about them is that it has to
write message.data to message.address in order to raise an interrupt in
some CPU.

Of course the device needs to have some sort of storage where the OS can
save the composed message data and the message address so that the
device itself can access it when it wants to raise an interrupt.

IOW. The message storage is device specific.

For IO/APIC the message is saved in the per pin routing entry.

HPET has it's own routing entry

PCI/MSI provides standartised storage for the messages.

IMS allows the device to define where the message is stored. That's a
fundametally new concept, right?

No. It is not. All of the above are already IMS implementations. And
each implementation has their own quirks and oddities which is why
we end up with different irqdomains and irqchips.

If you look at other architectures there are various other flavours of
devices which have their own device specific message store, IOW they
all are device specific IMS flavours.

They all have two things in common:

  - They provide storage for messages
  - To raise an interruupt they write message.data to message.address

So IMS is conceptually nothing new. It's just a marketing brandname for
something which exists since the invention of message based interrupt
for obvious reasons.

What's different for all of the above variants is the way how it is
exposed to the devices. Wired interrupts which end up at the IO/APIC pin
obviously cannot expose the underlying message mechanism because the
device cannot make use of it. And a device cannot allocate a pin either
because it obviously cannot rewire the PCB.

For PCI/MSI we have an PCI/MSI sepcific interface which is aware of the
PCI/MSI way to store the messages and to deal with the quirks and
limitations of PCI/MSI.

For IMS we surely will model an interface which handles all IMS variants
in a uniform way too, but that interface will be different from PCI/MSI
because it does not need any of the PCI/MSI quirks at all.

That interface will more look like the underlying msi irqdomain
interface simply because pretending it is PCI specific is an artificial
exercise.

There is nothing PCI specific about it. The only connection which needs
to be made is through msi_desc::dev and perhaps some meta info so that
the IOMMU can figure out from which PCI device this message will
originate..

Adding a pci_foo() wrapper around it which reliefs the programmer from
writing &pdev->dev and filling in some meta info is just an obvious
conveniance add on.

See?

That interface is really the least of all problems.

We need to settle the other way more important qeustion how to
store/manage MSI descriptors and how to handle the per device IMS
irqdomain first.

You can handwave about the interface as long as you want. It won't
materialize before the underlying infrastructure is not sorted out.

Once that is done then the interface is mostly defined by that
infrastructure and writing it up is not going to be rocket science.

See?

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:39:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:39:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237557.412006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7qD-0004Im-3p; Fri, 03 Dec 2021 12:39:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237557.412006; Fri, 03 Dec 2021 12:39:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7qD-0004If-0K; Fri, 03 Dec 2021 12:39:05 +0000
Received: by outflank-mailman (input) for mailman id 237557;
 Fri, 03 Dec 2021 12:39:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt7qC-0004IX-7h
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:39:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id feb37fe2-5435-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:39:02 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-b221BH7jOZydz3_0f0j1Fw-1; Fri, 03 Dec 2021 13:39:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 12:38:52 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:38:52 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0163.eurprd06.prod.outlook.com (2603:10a6:20b:45c::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 12:38:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: feb37fe2-5435-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638535142;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IMH9z9dNLeljwCG0NUZ3oQRW/DQoP73m0aKjVbemS/E=;
	b=RprdeBh8ql7h5msViNPibbvGpXTGj1zfjdYmf+fL2NPW2vx6aQQC2E4GrjNDcM19/cCgx9
	ff45AnMI7TBLlQQNSrgrkkj/mPvDROvlvn1FnyQx6PAb+xfo+SPl5FynKtzvoy1lUyZA8V
	5kkru3zxl3g+LYhZiGjVqVRtRBw33t4=
X-MC-Unique: b221BH7jOZydz3_0f0j1Fw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UoC6gumCGwM9664o2gPVFVBXs1DlrVRdblhoM9m3JewZNaIDy5MeOylqUbcJ+7OJdRkxCfcFOq61X8LZw0nrZpwppCFGVcROHwhfsD6Q5w5aZrGWuZY0+hdhMx3o3AB9bia8gv6fs9cFZKVfG5BLIK9ArucSz+3J0dpk88gKLc8IfSVZVqHbxXo3SC/l4zeRmKv0TbEgfnD3MFEXFl2TB5hwVOigtOOMuyn4Syc2Tyk80yEd8ENjZUmCgLlVfeyHSEq9luqWw2nqQWrFFl4H9AYF0b74Fh9N0OdDZJivKNneYNz4j32dRbN7wmLR0Ce9nNcTFKlaIuEXvR+v/am8zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0VYRfu9EyLwvA7J3Z1EnTAe0vKAKo8A9fD7jOLH5kiw=;
 b=ko311QiCSV1NMs3YLRvImm0YJqB0x+Ms601n8IKm++p/nlxk3iiiMFRQa7Fgo4yOFA6JFMZ4wdm18Z+QQEadk3O1hOqbjVk4MEKSw0VNDgsH6U5BxuxYwRGnIb41YRWjfn8lIoMkneMie38x2uWsp1YebcGgpCqGU+SMy41IhKKtiJyooWBePZgeIecRc/P2zAcPYendOO9pDm91Lv9ch2D/IxVv6cbCcZmc/VgGxH5ONWPacpuemqR5MYtyo7nUm5SdFRroaF3x77/2JEDsTPV8GwdXfA9EVy9Mzz4WUH2NZbtaMwrkzZhag8HxOvbMtjvTSpIjorjjWu5gKtbJZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2a3a0a37-525d-e2aa-b396-b01d97434d56@suse.com>
Date: Fri, 3 Dec 2021 13:38:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
 <YajTvrZz0xGOR3vT@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YajTvrZz0xGOR3vT@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0163.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc9b25e5-ab18-43ee-6f0c-08d9b659dcc7
X-MS-TrafficTypeDiagnostic: VI1PR04MB3120:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3120714FC1F3C90F008E383AB36A9@VI1PR04MB3120.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hJ5hT0fLYSnlzia/QexKJdBkPamkvuQEYcuhSXZs4z3X9Tgd1M/YfRmT176Q29YvsNxeN0RG6Q5g/1kSbQ++yFp/asexIbikZPRS86ZmrDe5Y+B9Oa7IB89wrmK6Ui1SNH1C8B5uFqM0sJf6pwh42xf7Ygjz21W9xiM6ZM0YHwsa9ufqkVpAZyjRQZasYVKl+Ocd7W/3CMfLapinsLN0u2HuIhKOAVkFRRZa9iDxpskDqp2BlWmbseKG78r/EvmJsqjqvAwFHDZiH3IE/4INnasSx7VAqU0rDsG5rS2YSY0/V9RIZe+JIB+DjkrKyWW2gS4eOR4vDzezz5Ln90C10bvaWhvS8pd+3qiMA3avN2wwmU8AsE2JOYpLHXP9kauUhUe2m7CwzLfrKRLRonNwsMElOsqGxtxey9dApOW4ylYRuhdgRcKcZ6TlP9Ifz6h/olHrmrti576Oy2ucrClMK1D95Yfdf+ZPevpmUdngwEyU7/BHQmhC/YFX8KVYvu8ofslntYh4ItOYreJ62bYn4Ur78aussl9UoftPSOY1l9vU2KwbVIt9yshXefnkPz82foNTDuLbv+l1G8l2ochDbLbwNzlQG96JuGQ6o++U2PE/odg0SsMkzhfM72fE61/eGNW4pManMHCk5v7lH02NgDBr28AlVfHe7rpek4goliBDwuaTXytEVA7vr9mNicglR7MpygZQkuyJ+evcF5WID7ZrzAw4boqpIFR41jRvj+Y=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(66946007)(66476007)(83380400001)(26005)(5660300002)(508600001)(186003)(2906002)(316002)(6666004)(38100700002)(4326008)(86362001)(54906003)(8936002)(6916009)(66556008)(6486002)(2616005)(31686004)(8676002)(31696002)(956004)(53546011)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ydKdKRPGhH+ZNlb7MPLgxIiljxYN+jL9TXdlG5E7BCJw7D8i7dO/JM7xL+wK?=
 =?us-ascii?Q?kvuOaLL5nWGK2xaR8v1NxtARAZmAWaXT4KifMYyrG6c2EghwfR7zhWpFBSD8?=
 =?us-ascii?Q?Opt8jX3Zo0ypzcsqOq5YDlO4Rg3ax4hK213q6TuulN/qQA3+VK85xSvFUR7A?=
 =?us-ascii?Q?Cfe9bKQWa2XsXnhJXc+X20CCLITvX21/05CALRxr00smc4uvnsJLQcE3TD0n?=
 =?us-ascii?Q?TOCdVUZeKYU1x56mjujTrxFO+moDxRPCTM0EhhSgY9ylUdx6WRx8Z/+5KXG0?=
 =?us-ascii?Q?26YIa900JtdqbA+v5V7W9mU/D+SDFrbT4HQvZ9f8FUbna9i+ouq4raaXr+s0?=
 =?us-ascii?Q?Adv6zjJhMDvyhQA39XDYV0KgrQDSA5XRFdWq6hlg6xLr7uhi//pICC7wpWdA?=
 =?us-ascii?Q?S3v+l+YPZwx8XTVDfevJ9KEyC97Y3sJaa7tmKXYTHN/nNJpwtGdgELG8rSk2?=
 =?us-ascii?Q?10F58z5mqQuVuuJRyOY/UICgvvs5rJwWqWihv4tJupOXKPCY4HsqYeJTje90?=
 =?us-ascii?Q?fUxtrA5WVDHOjGNQkjn3LGczqcrhzj8sVol4MZliUSIzvL7O4bcChaR8LBmt?=
 =?us-ascii?Q?8xgtCAb0gvUYlbwsuQdiQ5un+GETi+imW4JUkNNG4lyGnsqnp5pdLr9vtvTS?=
 =?us-ascii?Q?C7vh3i7cf3rt3dR8fsjvzBfthRZa3K7AZg1dfoNzP1jjTq19VxrtwZcJPLBu?=
 =?us-ascii?Q?fhnk1n/p6RB+UByo0wH6MkbdlPRGw+Pwpg+bELxz51URHAETN7EFy9FXaN9J?=
 =?us-ascii?Q?AeOXL6FRIsdU3qjAHkBcOl5jhTAz5TrtcRtRAEM4zYlyD0MyMKDgCx2KSP59?=
 =?us-ascii?Q?aTE/ZJ89aZffJdwkNH9Er4o+Clsrx3ZlHme3s5LNgJVlekVnDLpfHEjuvI9y?=
 =?us-ascii?Q?0jUX4pC9KdAxnZN2wPV8Ih0PcGPRUCVPGc4axtVWZip3ZNK/PGSlcySdEUNg?=
 =?us-ascii?Q?xCJsfWiZq1H1vckP+lOtNG05XosvE4rL0TGNXOuLszTRgkCHfS01XycDXFYh?=
 =?us-ascii?Q?6suW3iJDt/mkB/qIPF46HGqwaYYQUls7Ncrm8J7jx82rrJ+UBMpcSkZMf/j7?=
 =?us-ascii?Q?+cvH8GLy5ec0DcX87FruQBaYJy5OrMQsCypNAMkXpU8va4B8t8sspdwEYUNE?=
 =?us-ascii?Q?KJ1EAJQaSk+vTY24YFLtY3r+wtFWBrhiy3OoFb5GQ5CoMghY6WTBWSFMx2JP?=
 =?us-ascii?Q?HhUkVZvBJeiN8sbkwd1YP8hqgeUmUUraIFFig+dvEgZENRWAbrCY2vvPhQ54?=
 =?us-ascii?Q?WfTPt6STHW+l+vCE1UeGJubbTMu5ea/vqa/9zL3kumjrDXDLkVvr6OgxXhHq?=
 =?us-ascii?Q?qQS7vSqZmGEoIdAS824gzyiqRSwHSegbdzB/OVfV9DBh0YoOIse2+Zi7I5pk?=
 =?us-ascii?Q?kE5bmZxAP5TlTZJkpNsTYE4jN9Jv8854C9EeTzD3Ws2Pqnd4c0EEHKMMAcCy?=
 =?us-ascii?Q?OQY4W7aeOIbwdNk2ej7ltcfxJUd6PmoJEp0uXeS9asM0tZ/CPFH1U/rEETtw?=
 =?us-ascii?Q?x6mlQbatBH5FB6n7B9++wmtmq085EYFmMwkB6St5Lzv4cnjikRmbMzTBtgdl?=
 =?us-ascii?Q?TI/q7b4qX1M43CWmCRgR47ae+bsn3eNCV1UxSsifccw85SC47e5GMByDaRFv?=
 =?us-ascii?Q?r8UTCDx8d2l8+i79x73obPQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc9b25e5-ab18-43ee-6f0c-08d9b659dcc7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:38:52.3627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M2OSLrli2JopLpAJPQGJL8VUKhymmAhWW3AajivaTdfRl1TnTsZ72nL7lKCC9nXNdk2vJbmEtaQMM1HkcuWqDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120

On 02.12.2021 15:10, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote:
>> @@ -689,7 +763,8 @@ int __init dom0_construct_pv(struct doma
>>          l1tab++;
>> =20
>>          page =3D mfn_to_page(_mfn(mfn));
>> -        if ( !page->u.inuse.type_info &&
>> +        if ( (!page->u.inuse.type_info ||
>> +              page->u.inuse.type_info =3D=3D (PGT_writable_page | PGT_v=
alidated)) &&
>=20
> Would it be clearer to get page for all pages that have a 0 count:
> !(type_info & PGT_count_mask). Or would that interact badly with page
> table pages?

Indeed this wouldn't work with page tables (and I recall having learned
this the hard way): Prior to mark_pv_pt_pages_rdonly() they all have a
type refcount of zero. Even if it wasn't for this, I'd prefer to not
relax the condition here more than necessary.

>> @@ -720,6 +795,17 @@ int __init dom0_construct_pv(struct doma
>>      /* Pages that are part of page tables must be read only. */
>>      mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
>> =20
>> +    /*
>> +     * This needs to come after all potentially excess
>> +     * get_page_and_type(..., PGT_writable_page) invocations; see the l=
oop a
>> +     * few lines further up, where the effect of calling that function =
in an
>> +     * earlier loop iteration may get overwritten by a later one.
>> +     */
>> +    if ( need_iommu_pt_sync(d) &&
>> +         iommu_unmap(d, _dfn(PFN_DOWN(mpt_alloc) - nr_pt_pages), nr_pt_=
pages,
>> +                     &flush_flags) )
>> +        BUG();
>=20
> Wouldn't such unmap better happen as part of changing the types of the
> pages that become part of the guest page tables?

Not sure - it's a single call here, but would be a call per page when
e.g. moved into mark_pv_pt_pages_rdonly().

>> @@ -840,22 +928,41 @@ int __init dom0_construct_pv(struct doma
>>  #endif
>>      while ( pfn < nr_pages )
>>      {
>> -        if ( (page =3D alloc_chunk(d, nr_pages - domain_tot_pages(d))) =
=3D=3D NULL )
>> +        count =3D domain_tot_pages(d);
>> +        if ( (page =3D alloc_chunk(d, nr_pages - count)) =3D=3D NULL )
>>              panic("Not enough RAM for DOM0 reservation\n");
>> +        mfn =3D mfn_x(page_to_mfn(page));
>> +
>> +        if ( need_iommu_pt_sync(d) )
>> +        {
>> +            rc =3D iommu_map(d, _dfn(mfn), _mfn(mfn), domain_tot_pages(=
d) - count,
>> +                           IOMMUF_readable | IOMMUF_writable, &flush_fl=
ags);
>> +            if ( rc )
>> +                printk(XENLOG_ERR
>> +                       "pre-mapping MFN %lx (PFN %lx) into IOMMU failed=
: %d\n",
>> +                       mfn, pfn, rc);
>> +        }
>> +
>>          while ( pfn < domain_tot_pages(d) )
>>          {
>> -            mfn =3D mfn_x(page_to_mfn(page));
>> +            if ( !rc )
>> +                make_pages_writable(page, 1);
>=20
> There's quite a lot of repetition of the pattern: allocate, iommu_map,
> set as writable. Would it be possible to abstract this into some
> kind of helper?
>=20
> I've realized some of the allocations use alloc_chunk while others use
> alloc_domheap_pages, so it might require some work.

Right, I'd leave the allocation part aside for the moment. I had actually
considered to fold iommu_map() and make_pages_writable() into a common
helper (or really rename make_pages_writable() and fold iommu_map() into
there). What I lacked was a reasonable, not overly long name for such a
function. Plus - maybe minor - I wanted to avoid extra MFN <-> page
translations.

With a fair name suggested, I'd be happy to give this a try.

>>  #ifndef NDEBUG
>>  #define pfn (nr_pages - 1 - (pfn - (alloc_epfn - alloc_spfn)))
>>  #endif
>>              dom0_update_physmap(compat, pfn, mfn, vphysmap_start);
>>  #undef pfn
>> -            page++; pfn++;
>> +            page++; mfn++; pfn++;
>>              if ( !(pfn & 0xfffff) )
>>                  process_pending_softirqs();
>>          }
>>      }
>> =20
>> +    /* Use while() to avoid compiler warning. */
>> +    while ( iommu_iotlb_flush_all(d, flush_flags) )
>> +        break;
>=20
> Might be worth to print a message here in case of error?

Maybe. But then not just here. See e.g. arch_iommu_hwdom_init().

>> @@ -372,16 +372,30 @@ void __hwdom_init arch_iommu_hwdom_init(
>>                                          perms & IOMMUF_writable ? p2m_a=
ccess_rw
>>                                                                  : p2m_a=
ccess_r,
>>                                          0);
>> +        else if ( pfn !=3D start + count || perms !=3D start_perms )
>> +        {
>> +        commit:
>> +            rc =3D iommu_map(d, _dfn(start), _mfn(start), count,
>> +                           start_perms, &flush_flags);
>> +            SWAP(start, pfn);
>> +            start_perms =3D perms;
>> +            count =3D 1;
>> +        }
>>          else
>> -            rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER=
_4K,
>> -                           perms, &flush_flags);
>> +        {
>> +            ++count;
>> +            rc =3D 0;
>> +        }
>> =20
>>          if ( rc )
>>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx faile=
d: %d\n",
>>                     d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, r=
c);
>=20
> Would be nice to print the count (or end pfn) in case it's a range.

I can do so if you think it's worth further extra code. I can't use
"count" here in particular, as that was updated already (in context
above). The most reasonable change towards this would perhaps be to
duplicate the printk() into both the "if()" and the "else if()" bodies.

> While not something that you have to fix here, the logic here is
> becoming overly complicated IMO. It might be easier to just put all
> the ram and reserved regions (or everything < 4G) into a rangeset and
> then punch holes on it for non guest mappable regions, and finally use
> rangeset_consume_ranges to iterate and map those. That's likely faster
> than having to iterate over all pfns on the system, and easier to
> understand from a logic PoV.

Maybe; I didn't spend much time on figuring possible ways of
consolidating some of this.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:46:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:46:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237564.412018 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7wi-0005gq-Rt; Fri, 03 Dec 2021 12:45:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237564.412018; Fri, 03 Dec 2021 12:45:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt7wi-0005gj-ON; Fri, 03 Dec 2021 12:45:48 +0000
Received: by outflank-mailman (input) for mailman id 237564;
 Fri, 03 Dec 2021 12:45:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt7wh-0005gd-SQ
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:45:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7wg-0004Mv-VF; Fri, 03 Dec 2021 12:45:46 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt7wg-0000WU-Oa; Fri, 03 Dec 2021 12:45:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oEPU0l2cxa7JpNUJKmbJilk4BczgfWAitWF/QkcCq44=; b=UD8jWhUSvjGzy9foe4ZW1f/i06
	MtX0jaG387C4+4a3LK7ZpHVb795uFQ3hcUWAlrh8gkqOFUdAuReEkkEyx9RjVysCFMA1eimzYBWH/
	8sWeqPxBkTxToz+/LbtFcQngJjGH4SQTjWYzCVbhg3nNNw/5uD+X/370efHRs2w9uE9g=;
Message-ID: <d7951950-e5e3-01b6-c9ee-9fb3f3657b81@xen.org>
Date: Fri, 3 Dec 2021 12:45:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] docs/efi: Fix wrong compatible in dts example
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211202150517.53029-1-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211202150517.53029-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

I have committed the patch with a couple of changes.

On 02/12/2021 15:05, Luca Fancellu wrote:
> The example in section "UEFI boot and dom0less on ARM" has
> a wrong compatible for the DTB passthrough, it is "ramdisk"
> instead of "device-tree".
> This patch fixes the example.

I have re-wrapped the commit message to 72-characters rather than 
58-characters.

> 
> Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI boot")

The sha1 should be 12-characters for Fixes tag. You can configure git to 
ouput one for you. See [1] for more details.

> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Acked-by: Julien Grall <jgralL@amazon.com>

> ---
> Question: Does it makes sense to backport it to 4.16?

I think so. I would tend to read the same documentation as the version
of Xen I am using. Documentation patches are also not considered risky.

Stefano can you add it in your backport list?

[1] https://xenbits.xen.org/docs/unstable/process/tags.html

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:49:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:49:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237570.412032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt80G-0006YC-BW; Fri, 03 Dec 2021 12:49:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237570.412032; Fri, 03 Dec 2021 12:49:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt80G-0006Y5-8N; Fri, 03 Dec 2021 12:49:28 +0000
Received: by outflank-mailman (input) for mailman id 237570;
 Fri, 03 Dec 2021 12:49:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yEHZ=QU=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1mt80E-0006Xz-IL
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:49:26 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 702cfd1f-5437-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 13:49:24 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id D256F62A30;
 Fri,  3 Dec 2021 12:49:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF1CDC53FC7;
 Fri,  3 Dec 2021 12:49:20 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 702cfd1f-5437-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638535761;
	bh=gp94SRYawnm+2OyVuYPvciRbORwhED6UQuA7fvk+mng=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=rrnhkgXG+JHJZrkhMzsKW6pcdjm64IJORZ170ZEnD0B1qJhscCgGMEC5kiuuNGVlf
	 wIOWmELvcoXTQZTnps4wVOwo3W0Wj6rKWLbHToizoyJBoQ4nueu2nCNp6FOx8bXOBj
	 PRz9KUlJ/Vwuo0X7IxQ/EGZ6VKiTiXICAFsvBy9w=
Date: Fri, 3 Dec 2021 13:49:18 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
Message-ID: <YaoSTnkYyCFXOyvJ@kroah.com>
References: <20211123132048.5335-1-jgross@suse.com>
 <20211123132048.5335-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123132048.5335-3-jgross@suse.com>

On Tue, Nov 23, 2021 at 02:20:47PM +0100, Juergen Gross wrote:
> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
> domU to communicate with a USB device assigned to that domU. The
> communication is all done via the pvUSB backend in a driver domain
> (usually Dom0) which is owner of the physical device.
> 
> The pvUSB frontend is a USB hcd for a virtual USB host connector.
> 
> The code is taken from the pvUSB implementation in Xen done by Fujitsu
> based on Linux kernel 2.6.18.
> 
> Changes from the original version are:
> - port to upstream kernel
> - put all code in just one source file
> - move module to appropriate location in kernel tree
> - adapt to Linux style guide
> - minor code modifications to increase readability
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/usb/host/Kconfig   |   11 +
>  drivers/usb/host/Makefile  |    1 +
>  drivers/usb/host/xen-hcd.c | 1606 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 1618 insertions(+)
>  create mode 100644 drivers/usb/host/xen-hcd.c

This looks sane to me, but I don't know the HCD interface as well as
others on linux-usb do, like Alan Stern.

What tree do you want this to be merged through, my USB one?

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:50:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:50:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237576.412043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt81Q-0007r0-MN; Fri, 03 Dec 2021 12:50:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237576.412043; Fri, 03 Dec 2021 12:50:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt81Q-0007qs-J1; Fri, 03 Dec 2021 12:50:40 +0000
Received: by outflank-mailman (input) for mailman id 237576;
 Fri, 03 Dec 2021 12:50:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt81P-0007qN-1Q
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:50:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d333860-5437-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:50:38 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2058.outbound.protection.outlook.com [104.47.5.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-esFGO2z0OWyqmEXH1suymw-1; Fri, 03 Dec 2021 13:50:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 12:50:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:50:34 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:20b:130::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend
 Transport; Fri, 3 Dec 2021 12:50:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d333860-5437-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638535837;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Qe6yEJ+aGUWE6fZf6eyPC4snHVft0GIs90q8N6YOv/Q=;
	b=Pxqq5kf3bK+OoIN2SzPMsQ0YjZaRWG9vFD6dNAe5BXWTZ8cpKzuEVGQRo4vnJD3Re9rgIi
	Pt5DxdHUGKqDlHwmfD41zS29PrBUhhdzfhcX/GA6b/PJmQS7e8EEeOJ1eimqmRdTyi0lss
	cnC5DoEUoUEkyTXwswvtbLtEvzsNIQs=
X-MC-Unique: esFGO2z0OWyqmEXH1suymw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q9t2NSFq11pJiWzKlqxf4USQJ5Ad7Xw+u9nhDRfAZ2x0f7bo4n5P3YpDy1wduyMbudScwjNyEzTuyd+oLd9h31ykaaEEdU4fXlZRfe/gGTle8CPJl2qhfXD2hSV+EuwLITAO7ZLpvz0ZmqJOqmZWFl/A4ZpNXjAsgmQ1MLuj+GRpBbJ8D2QVPmax2B3Te9Qy2vtjxQ/sr4t2VRg+17m2DFA0ZO8dQT9U3iETZ1gkYlz9FNiRaxiMEQmjwEE3z0nBseIJyS+DqMdKMX7w6J5nulpIZ7p/vziMv3w3cC2NlLEGSAtA/oNocwCT+7v3dZSw+QlY7f2W5qrwJgMliANU5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KrPc8cD+EJ8zaFM/6eDcq7gpUw2conBGCQOsCRVdOrY=;
 b=KnpdIX9uLkvCTRrvIav5axOrtCPwz0rkCDv/MGxfxSST+KQEEKLYTVyVDHuRT074TJtiorwhAux3BIaF7HRIYAZLFn0L3NEz3gxdwtdvmnTkFQOM4VbgdrX87niNjsv0wPzVebRrfRBG65FtIKi8QtkerCwBGUF+XMYKEvQQIGijDyUpE8JSyYzy1TbGDztte7WJ8tVabDFmtkC2/3nGqlJKN8uhYpUuWf2OcDusToKpwOmO6/3JRFaU0enxw5E1JnIxHC9FjxuUu+to5b1YF6hWi/k6kCb6+5xyEkoowU4F4Jfl5UO+L2bxHDjFUd5uPsHGj3joRr8lywtgvU3bzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0418bdcc-62eb-3d98-1c1a-6b1af0f75d00@suse.com>
Date: Fri, 3 Dec 2021 13:50:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR03CA0012.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 29a1ed01-afb4-4c3b-a32f-08d9b65b7f44
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23367B94C9F0B5247790D338B36A9@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2582;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SOUSBofXR2CH+fIiFA7SJucqv+7pYOER2SeI8z3zeGHpqGmpBV5SKZpaZ++qB3ID+1Bf90TCD7mvG4ouqzv8JKYaWulSMixMoE2HYSk/thDhwLTfG7TV6g3G78s0PAgvt5OotPz/fM4apyKWVXj2ppP/2p/p+4/zIGrxn6xlwjo5Qh1inN1biY7sGA4FBEVJ3FXocmYqD+2IlgrPi6Qf+bpqqRaK4Zbo+lIsk9TscQqAtYeJvhyP7dSssQOs5HN4JcANLWG03Cz/xM/Az2/z6FlVQeyfUz81sZJB55zp5xWv1iBvyXvZrJAxnY1sWZC6YEU+Dlm/+9EW5D0TK9R/DBPI276gBSKWT/K0LP70eLyn2T1GX0K66Bf12LFAWiFm5XKqPr3u3bcTiOSasRAVCpbjHiXGSSjenriw4jOnp8jVjerPVxvyQWxsp6JTsiNQtZEImGCRszfZ8j3YHeLU0/CYsy62MHPYdFvybPkNhYWD83hMzIr9AFvBxdT1iuGWqdN92hNHcm/kz7CjRnhtrRD7SNYY51Wvg+emF0ym8lomB24jTyRAspUCavZxH4Kk5Ufo1rzYNyxcflcu3tjFlyHIKN1zrv5rxUMTma3xOLQ1YUAeHrZBa1ZmF2lr42KFFMv0kpSZFD4utEjDr92qa+0IFDDVyBiqb4R1g8QKf/FpEcukLbNUIUX3wMjiTT+NJoaS0k4X+Gl0eYzu5cFirE9U4wjHGQH1Btubb5C2nBk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(316002)(8676002)(36756003)(8936002)(66946007)(31686004)(83380400001)(66556008)(38100700002)(53546011)(66476007)(2616005)(956004)(6916009)(86362001)(186003)(6486002)(54906003)(16576012)(31696002)(2906002)(508600001)(5660300002)(4326008)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2qmYH+BTe9cKHrQDrPXrSBTtpH31UtE5odv60QVXknrYD7FPHDyv9eCKc9Wj?=
 =?us-ascii?Q?2vDcVQDG44m5jkecvJGaMkI2fQef3xwyEbfcdAAQJnFDjKQTey3ZtBcQcS7n?=
 =?us-ascii?Q?Gc/fGtvCvgYP7Ksc8dveYLCa07lVUPBajs/gFpoKs1Iz5WWGCpa1VxROn6sy?=
 =?us-ascii?Q?pw21mdm2xbbfw4i1NnOPhmBnTRq+NAfopAp/IocXMA0Y164oVb45Kq45D2kt?=
 =?us-ascii?Q?FOyAEbdxeoFpLv3zQr6gpdducA+I703ty786mqL9lu/6vZpaG3jNSl5w8CGy?=
 =?us-ascii?Q?b14rq9I+qJdwfMkVlj6dNL70wSFNOOjyK1sp+qGYpz7d9WDp+ZYaCZhOJs18?=
 =?us-ascii?Q?1nQHCrPom9sqOX4E3w0+8WyAKIrjdBCP0WNze7uVW9Gv9SphK+xXIiT9iFCZ?=
 =?us-ascii?Q?/Klfmx5IzbyfPpKydkyC89EkRrj8/PKMnbp3rQL/vgYToGIhfhc+95jArpa4?=
 =?us-ascii?Q?BLqvnqOfv5jtskPI/spPujAaZZbF+RN+ie8JYrdSxa4J+BWBLuWZRDGUH23t?=
 =?us-ascii?Q?8CD8kYFu4XlvFji5D7rqBRhuQ8/+p0ItApIkFSYmr9t59wCc9+Ia3BIIpUR0?=
 =?us-ascii?Q?B8sjGzjNIVup2C7E8ii2h21EXgp7dEfHdz8uCXnsqawlQlIRd0OAb1uoWyST?=
 =?us-ascii?Q?Eie6QmHVTe3Nd4DJ3owOZ5ezBeWMq7Xc1R/R0rNSJtMFVz3SAOOcYhkMcnmt?=
 =?us-ascii?Q?1x9aDjkUWtm2UT9ieLDDIJiZVHPWXEisWYUIU51iLqv6uR0xofFQiN6pIPcJ?=
 =?us-ascii?Q?gIpjRyegQm88zhtq92uSxd9WziSZ2b2b+ndlQ4URDFAzKvDjTTCMSpfhrbZC?=
 =?us-ascii?Q?ulLX6LW8+6yveeb3nTkanvWwb8jkN+Fs7SVQzkC1lv8zznO39vAtEq2DlH9Z?=
 =?us-ascii?Q?MOIhlFLsfw/gUivUCx25zlGKopTWLFX886hTrr6srzBGoASidM95TrBpZekf?=
 =?us-ascii?Q?SP76mNkRS/F19SU0065ntFcb3gv0Wb/EgFQHJhjOuRlRV2YPpaNjHT9o7n1H?=
 =?us-ascii?Q?oo6DKqUY6XDZt04H9FqLbhv3wMPCgFmJMKxdrjHrOiHvFrh59kE94Wjax+aB?=
 =?us-ascii?Q?bw6F77l94EFf37uGK0q2xIdfuODO4IMyT0CdaPIbaYc64iarO9+Jtpro+yxS?=
 =?us-ascii?Q?358twUhMhQsB47ocFH8TXnLrbeIYRnsS9+tPu+M892VLseHVQ7X5XTbNkkvR?=
 =?us-ascii?Q?UDkrvA9ISqUcsrwl+wjRPe6g7NDgG3OjqDpWJ8pcm/dqxPFH9IwRcdOMcgJ2?=
 =?us-ascii?Q?xSXqZcpMczpnCN+dCZQquP0rUosNxJeVGMRVKowElajAOST/204ZbOnoyaNZ?=
 =?us-ascii?Q?Q47r0ux8331h74xhqrcPyu6RPwrL9wbDVN+7A/hMVjYERuyao3oa7XjpxdlW?=
 =?us-ascii?Q?ICIdNrfXbucjVRbyDU+NPnujLV7wqHruXgS9C8sBBMWehtPUocLKoc+RPu02?=
 =?us-ascii?Q?p4GPBAwskmDRVRp+6tBnJwoX1mgBbxrNF6S2aXjvJV1KhI9Jim0DSkfgwsua?=
 =?us-ascii?Q?Q1pQYeFkheBUTqpsgmTVkFymj4EGP0bawtsp8StEzCNrW1pyM7aMUJOiufvG?=
 =?us-ascii?Q?oEoZnNPNOWNua+JML4SXV0/ckRf4+4MhfQmILfVA4BIwE7oV9rg8T+qMBIxK?=
 =?us-ascii?Q?cL5ldx0YAYK+6tlJtYB5cJQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29a1ed01-afb4-4c3b-a32f-08d9b65b7f44
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:50:34.4728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pq700X23Ly8387rzftRrXr2fFAJa6si97rHtuzptgIt0v8lvWyfuc4J69xAImf3F7nDZ/yoljtEzrIDqJ1/m/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 03.12.2021 12:21, Andrew Cooper wrote:
> On 03/12/2021 10:56, Jan Beulich wrote:
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>   immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Why does blexit() need moving?=C2=A0 It isn't static, and has a real
> prototype in efi.h

Correct, but the movement is for the functions it uses from efi-boot.h:
efi_arch_halt() and efi_arch_blexit() at least (which actually the
commit message also says, for one of the two at least).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:50:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:50:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237578.412054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt81Y-0008Aw-4F; Fri, 03 Dec 2021 12:50:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237578.412054; Fri, 03 Dec 2021 12:50:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt81Y-0008Ap-0I; Fri, 03 Dec 2021 12:50:48 +0000
Received: by outflank-mailman (input) for mailman id 237578;
 Fri, 03 Dec 2021 12:50:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=A+hS=QU=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mt81X-0007qN-8A
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:50:47 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1dd99bf-5437-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:50:46 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 7E5B61FD3F;
 Fri,  3 Dec 2021 12:50:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 592F213DC9;
 Fri,  3 Dec 2021 12:50:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yofvE6USqmGHUAAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 03 Dec 2021 12:50:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1dd99bf-5437-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638535845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SKtEJiiVmVjiKuYxlfAWTyTTb/iSm7ZWQwrEhO21/xE=;
	b=tb8s6wAurXzbDiX3OdN+edOGFXNBgKE2Nl9AU4N/jGYGULm4dicV5mVQOy5jY2xYei5eis
	cbeHaB5+Awj4heQPFh59gjOEGhEVwbgwbMNeyStEH/rDUahqWg6aTBMl/mhHMioZWax53a
	hvSFt+vdfvdl1DNag6hNGjfyT+dQK9o=
Subject: Re: [PATCH v7 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20211123132048.5335-1-jgross@suse.com>
 <20211123132048.5335-3-jgross@suse.com> <YaoSTnkYyCFXOyvJ@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <b43c416e-d81a-7d21-5b92-7bc8329bb296@suse.com>
Date: Fri, 3 Dec 2021 13:50:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YaoSTnkYyCFXOyvJ@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="x1mYDcVqmz7b5bc8MJK83imoEBOV0AN4c"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--x1mYDcVqmz7b5bc8MJK83imoEBOV0AN4c
Content-Type: multipart/mixed; boundary="IrZAaRCDRAW8mmqbSA2GhRkvh41Wxu1ze";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org
Message-ID: <b43c416e-d81a-7d21-5b92-7bc8329bb296@suse.com>
Subject: Re: [PATCH v7 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
References: <20211123132048.5335-1-jgross@suse.com>
 <20211123132048.5335-3-jgross@suse.com> <YaoSTnkYyCFXOyvJ@kroah.com>
In-Reply-To: <YaoSTnkYyCFXOyvJ@kroah.com>

--IrZAaRCDRAW8mmqbSA2GhRkvh41Wxu1ze
Content-Type: multipart/mixed;
 boundary="------------BE40DD6938C15AA655817C7F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------BE40DD6938C15AA655817C7F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 03.12.21 13:49, Greg Kroah-Hartman wrote:
> On Tue, Nov 23, 2021 at 02:20:47PM +0100, Juergen Gross wrote:
>> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen=

>> domU to communicate with a USB device assigned to that domU. The
>> communication is all done via the pvUSB backend in a driver domain
>> (usually Dom0) which is owner of the physical device.
>>
>> The pvUSB frontend is a USB hcd for a virtual USB host connector.
>>
>> The code is taken from the pvUSB implementation in Xen done by Fujitsu=

>> based on Linux kernel 2.6.18.
>>
>> Changes from the original version are:
>> - port to upstream kernel
>> - put all code in just one source file
>> - move module to appropriate location in kernel tree
>> - adapt to Linux style guide
>> - minor code modifications to increase readability
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>   drivers/usb/host/Kconfig   |   11 +
>>   drivers/usb/host/Makefile  |    1 +
>>   drivers/usb/host/xen-hcd.c | 1606 ++++++++++++++++++++++++++++++++++=
++
>>   3 files changed, 1618 insertions(+)
>>   create mode 100644 drivers/usb/host/xen-hcd.c
>=20
> This looks sane to me, but I don't know the HCD interface as well as
> others on linux-usb do, like Alan Stern.
>=20
> What tree do you want this to be merged through, my USB one?

Either that, or I can carry it through the Xen tree.

Its your choice. :-)


Juergen

--------------BE40DD6938C15AA655817C7F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------BE40DD6938C15AA655817C7F--

--IrZAaRCDRAW8mmqbSA2GhRkvh41Wxu1ze--

--x1mYDcVqmz7b5bc8MJK83imoEBOV0AN4c
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGqEqQFAwAAAAAACgkQsN6d1ii/Ey83
nQf+Jd52GN9HgJC6vsgHZCz14Cz5jdkhbcDLc6uQeP3YMSNNGQWKXvJEoKj+tyaHr6gQBp+ipqRJ
SwdQ3JsneWyp1EY2vXy99hdINWcA/fOa2iiYOFWUQx+T8n2qx3kv1HPZjGGWYDWqXRPmPsFrQEXf
b6XVRRBp4/7qmMidy58sAcWYmHQwpLL1XvzJ6tdfMCPzFrMgPWBrrtnL9Lu0ADrcJ0hWapdt5h/P
J34DrhzYJLbdhH2CMUrUBS3Ne5f6kLWOwHcBhj/vsr1P2utnf1BAoZRta7sA1rfZcuKdl7QLezzM
CG6Z9YJUu4Avwt93fIQvwJG9pi80Lp0H0K3pzQJc0g==
=OjP3
-----END PGP SIGNATURE-----

--x1mYDcVqmz7b5bc8MJK83imoEBOV0AN4c--


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:55:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:55:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237590.412072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt85i-0000lb-OH; Fri, 03 Dec 2021 12:55:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237590.412072; Fri, 03 Dec 2021 12:55:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt85i-0000lU-LO; Fri, 03 Dec 2021 12:55:06 +0000
Received: by outflank-mailman (input) for mailman id 237590;
 Fri, 03 Dec 2021 12:55:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt85h-0000kG-DR
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:55:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt85c-0004Y7-D4; Fri, 03 Dec 2021 12:55:00 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt85c-0000zp-6d; Fri, 03 Dec 2021 12:55:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Fvf2QVb6ygCzQF5irm/wFeKDgyIGyIyJG/7PObKzZrk=; b=BR18M0yOnCsffdbp1rPtahseV3
	oCMzZHTNOdOHqFisIDomkm6ZYwz+/6wHFNQ4WwjnPGi1UtUNm+ilxLCYuGm4S+Zalazx7Wr3k0C8K
	C8UVanpkgtdyP8WPgyOxaYY0nvhNXzGRPphu7i/UtOfbGZaQdjHp5QYwuGUkNkpd+tiU=;
Message-ID: <5d543a80-ab1c-8625-c97d-e1d6f1fb3f19@xen.org>
Date: Fri, 3 Dec 2021 12:54:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 6/7] xen/arm: process pending vPCI map/unmap operations
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 "Durrant, Paul" <pdurrant@amazon.co.uk>
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
 Julien Grall <jgrall@amazon.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-7-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-7-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vPCI may map and unmap PCI device memory (BARs) being passed through which
> may take a lot of time. For this those operations may be deferred to be
> performed later, so that they can be safely preempted.
> 
> Currently this deferred processing is happening in common IOREQ code
> which doesn't seem to be the right place for x86 and is even more
> doubtful because IOREQ may not be enabled for Arm at all.
> So, for Arm the pending vPCI work may have no chance to be executed
> if the processing is left as is in the common IOREQ code only.
> For that reason make vPCI processing happen in arch specific code.
> 
> Please be aware that there are a few outstanding TODOs affecting this
> code path, see xen/drivers/vpci/header.c:map_range and
> xen/drivers/vpci/header.c:vpci_process_pending.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> [x86 part]
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Julien Grall <jgrall@amazon.com>

This patch technically needs an acked-by from Paul for the IOREQ part. Paul?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:57:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:57:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237594.412083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt888-0001dA-6f; Fri, 03 Dec 2021 12:57:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237594.412083; Fri, 03 Dec 2021 12:57:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt888-0001d3-3P; Fri, 03 Dec 2021 12:57:36 +0000
Received: by outflank-mailman (input) for mailman id 237594;
 Fri, 03 Dec 2021 12:57:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt887-0001ct-11; Fri, 03 Dec 2021 12:57:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt886-0004cw-QN; Fri, 03 Dec 2021 12:57:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt886-00076C-Ex; Fri, 03 Dec 2021 12:57:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt886-00084z-EQ; Fri, 03 Dec 2021 12:57:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7vMJ49uHrUNlV/gN4gJKmCoQ0MQJXh0upGM0/TN/2Jk=; b=kWg5ZnrKibPiHKqPfqkSJnH6D8
	aQFAky/7LjD6/Q7+zUiCGCgUeZ7F+nRTYu02FxyI7J4wPNEWm/0uMYb3A+aAYMSxv54NcmtNb8fN+
	7knEfuJsTJ1QFvQt75cH4HgFD0AyYXsZ8oQb8USPndiPypyxe2RXWejuFGnnFp55ZQLs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167055-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167055: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit1:debian-install:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-xl-vhd:guest-destroy:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5f58da2befa58edf3a70b91ed87ed9bf77f1e70e
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 12:57:34 +0000

flight 167055 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167055/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166942
 test-arm64-arm64-libvirt-xsm  8 xen-boot                 fail REGR. vs. 166942
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit1  12 debian-install           fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-libvirt    18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail REGR. vs. 166942

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds    22 guest-start/debian.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166942

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd      19 guest-destroy           fail blocked in 166942
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                5f58da2befa58edf3a70b91ed87ed9bf77f1e70e
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    5 days
Failing since        166963  2021-11-30 20:54:02 Z    2 days    5 attempts
Testing same since   167055  2021-12-03 01:12:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akhil P Oommen <akhilpo@codeaurora.org>
  Alex Bee <knaerzche@gmail.com>
  Alex Deucher <aleander.deucher@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Williamson <alex.williamson@redhat.com>
  Alexandra Winter <wintera@linux.ibm.com>
  Amir Tzin <amirtz@nvidia.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Bean Huo <beanhuo@micron.com>
  Ben Ben-Ishay <benishay@nvidia.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Benjamin Poirier <bpoirier@nvidia.com>
  Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Chen Jun <chenjun102@huawei.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Corey Minyard <cminyard@mvista.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Airlie <airlied@redhat.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Woodhouse <dwmw@amazon.co.uk>
  Deren Wu <deren.wu@mediatek.com>
  Dmitry Bogdanov <dbezrukov@marvell.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Douglas Gilbert <dgilbert@interlog.com>
  Dust Li <dust.li@linux.alibaba.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Dumazet <edumazet@google.com>
  Erik Ekman <erik@kryo.se>
  Felix Fietkau <nbd@nbd.name>
  Flora Cui <flora.cui@amd.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Fuad Tabba <tabba@google.com>
  Gal Pressman <gal@nvidia.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  George Shen <George.Shen@amd.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guangming <Guangming.Cao@mediatek.com>
  Guchun Chen <guchun.chen@amd.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurchetan Singh <gurchetansingh@chromium.org>
  Gustavo A. R. Silva <gustavoars@kernel.org>
  Hangbin Liu <liuhangbin@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Igor Russkikh <irusskikh@marvell.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakub Kicinski <kuba@kernel.org>
  Jane Jian <Jane.Jian@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jian-Hong Pan <jhp@endlessos.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jimmy Kizito <Jimmy.Kizito@amd.com>
  Joerg Roedel <jroedel@suse.de>
  José Roberto de Souza <jose.souza@intel.com>
  Juergen Gross <jgross@suse.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kalle Valo <kvalo@codeaurora.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Larry Finger <Larry.Finger@lwfinger.net>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Lijo Lazar <lijo.lazar@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Lu Baolu <baolu.lu@linux.intel.com>
  Luca Coelho <luciano.coelho@intel.com>
  Lucas Tanure <tanureal@opensource.cirrus.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Lyude Paul <lyude@redhat.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Maor Dickman <maord@nvidia.com>
  Maor Gottlieb <maorg@nvidia.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Marek Behún <kabel@kernel.org>
  Mark Bloch <mbloch@nvidia.com>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matt Johnston <matt@codeconstruct.com.au>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Max Filippov <jcmvbkbc@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Stapelberg <michael@stapelberg.ch>
  Mike Christie <michael.christie@oracle.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  Moshe Shemesh <moshe@nvidia.com>
  msizanoen1 <msizanoen@qtmlabs.xyz>
  Muchun Song <songmuchun@bytedance.com>
  Mustapha Ghaddar <mghaddar@amd.com>
  Mustapha Ghaddar <mustapha.ghaddar@amd.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Nikita Danilov <ndanilov@aquantia.com>
  Ole Ernst <olebowle@gmx.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Perry Yuan <Perry.Yuan@amd.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philip Chen <philipchen@chromium.org>
  Philip Yang <Philip.Yang@amd.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Ping-Ke Shih <pkshih@realtek.com>
  Qian Cai <quic_qiancai@quicinc.com>
  Raed Salem <raeds@nvidia.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sameer Pujar <spujar@nvidia.com>
  Sameer Saurabh <ssaurabh@marvell.com>
  Santosh Shilimkar <santosh.shilimkar@oracle.com>
  Sean Christopherson <seanjc@google.com>
  shaoyunl <shaoyun.liu@amd.com>
  Shen, George <George.Shen@amd.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Steev Klimaszewski <steev@kali.org>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephen Boyd <swboyd@chromium.org>
  Stephen Suryaputra <ssuryaextr@gmail.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudarsana Reddy Kalluru <skalluru@marvell.com>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  Sumit Semwal <sumit.semwal@linaro.org>
  Sven Schuchmann <schuchmann@schleissheimer.de>
  Takashi Iwai <tiwai@suse.de>
  Tariq Toukan <tariqt@nvidia.com>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tianhao Chai <cth451@gmail.com>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vitaly Rodionov <vitalyr@opensource.cirrus.com>
  Waiman Long <longman@redhat.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wenjia Zhang <wenjia@linux.ibm.com>
  William Kucharski <william.kucharski@oracle.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Xiayu Zhang <Xiayu.Zhang@mediatek.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Zhou Qingyang <zhou1615@umn.edu>
  Łukasz Bartosik <lb@semihalf.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 7762 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 12:58:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 12:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237602.412100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt89K-0002Ih-N3; Fri, 03 Dec 2021 12:58:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237602.412100; Fri, 03 Dec 2021 12:58:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt89K-0002Ia-K2; Fri, 03 Dec 2021 12:58:50 +0000
Received: by outflank-mailman (input) for mailman id 237602;
 Fri, 03 Dec 2021 12:58:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt89I-0002IO-M4
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 12:58:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c10a5160-5438-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 13:58:47 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-hUm8MLN-Nw2ULcVYE9fr2A-1; Fri, 03 Dec 2021 13:58:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Fri, 3 Dec
 2021 12:58:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:58:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P250CA0015.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 12:58:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c10a5160-5438-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638536327;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CDwMGSsNsGyKOrQJt5yo+oTfSCvjuXNawQ3MyaW6biE=;
	b=lqEU2r6fZHm9uKX2VF4tLBhtLT23bcoNfvwTBKn9d14z+fY7w6Ys4V8BL2TZ5gHel34MH5
	V9BvNtktVVWTsSBeLJ4Jq3pSPOIaSqCGYxQjG1IUDsExP5rnXYGoqo/kxTMii2Dbau29f5
	lAEGU3/Fpex/yBCNcSnRsrOgB2FrE2Q=
X-MC-Unique: hUm8MLN-Nw2ULcVYE9fr2A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sx8S/Quxi5Zq+ozFWW1x/CY9H/VCGPSDaIAbWiyu/8mjaFcNQ+4/KXWoYmnifdoM0lTrmGJ1JPTbtqrFca9f6SqrAaDr28AdC0FGCteFa6z3JgMonYO7GySGdTa1FIkqEbfcP70k7cWe8wyYFKHj6PJraS938y45gt8+v/eGfD5WqElfCvGeLL5MGMuv6Gzdp1tg0v1bWN5TcbrVX7R69f4ckZMfCRv4Fm9jyngQQZhpcc5TiXt+ajVU23GYedMHghUjOgw+/KL/R65y0Vl6wEms5Zu3IXqUASFh+tNSP8xE/xJdDzW0B3m+kNy2hl01CdLllCp0hEyTHH5/cUlfUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CDwMGSsNsGyKOrQJt5yo+oTfSCvjuXNawQ3MyaW6biE=;
 b=OTg5Vckh/yApyUKJPGcGsK15FW5llQTOQX87cWIMJZeYWwrZA8JNcNN3HIiEDna429QP8ETXjIU76vb6dotB/mAwHmrnhFMK8U3mizjMDSULkw15z/1TCn8S+CIdGFxWTQeu/yO+vjGuZhqTaMk+gsIgs6x9cpbtoIYIdeyQebj764ZWZj4l0wpZ0SHmMPdzGKzp9Us8L/K9fMaarAugk9jauKmUYNENbD61eeOJ3QSYqGIAwmQu8D5Bs+Yan5+2CELMNFomc4LnPM7OYn/qjPxJgzobglHJpOzf4Ke+e9F1JKrqK7w9O17dYN2k72jIl0sr99vcFT3dpOjqtFZogA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8daff8dc-52b1-3575-abc0-85d6f757eb1a@suse.com>
Date: Fri, 3 Dec 2021 13:58:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 57/65] x86/setup: Read CR4 earlier in __start_xen()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-58-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-58-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P250CA0015.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c414639d-e987-462f-feea-08d9b65ca366
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039E5D07A8AC8C7C556289AB36A9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hMjCLgW3Ieqd3Vlpt2O7SkoKlYENKk2rwHl81/PAzmzWiZrXDofHnbmMYetGSuBy371a1Lid2OuYUrxB7KkuZGuSREsvWCScmHcRjAyAh3NxXdmRQdamniXiLlopugk9uIUA5VRA03A6GiI0yAv6F6D3zgh0vuyzNjqeLs0EA9wyhk4zd0z9+KehhD/5bvXXxtkaMnirNNH/jQOpn/0aC778bHFQJTIs5p+7wAHodUg7KrZHfpSn/CZLSPlGCWJAQZyATIy4V6UGSYrmr++quNxASwldhvV+Vev1TPYD5pwsAbiEd1WMGZ/lMVifL8PUd0y8RT499H9L4LBaQSS7Zk55cCCedatpVvp2ndwMr01F2v5LqJoHsVkrfppnfrWIn6ebkGFDeQlJR0bY1eQPXo1HpDQdhfZaQmaXo2Iz8JJCFgCLiW8KKxsd8BfOtwWiUIUzTg3OxE4zvsZgOx5PDUHZrkSeALUF5fYKtALCHdgZ1ywFIcLtNxXlN4u2of/Jw/SYe5Iq2ommtCumhFsqNFqrYhE7eea+faiHgjJCDc1FJQE2l7vmueIvMLgHcmYZVsKoar5iU6emX9Wt/lhryI9BaZM3b+OPwDOhe5H+u1PvmYKnT8HpQ6hlFVbsqDxYSi1WnTS9EOsLzDdNq2QbLkoi1Sa3T8cQoSXc+BgAy1S3cdN7OKvm0igAU8cY59ewzvmivPwDpWwnAaJ3jMpn5Hi9CjsCkxxeotN4tcDhlfo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(8676002)(86362001)(31686004)(2616005)(66556008)(186003)(66476007)(16576012)(316002)(26005)(956004)(54906003)(36756003)(31696002)(38100700002)(66946007)(6486002)(5660300002)(53546011)(4326008)(508600001)(558084003)(6916009)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?enA1alltYUsyZkZ5eVYyTUQ5dVB1VlhvWEJsWnZIOThPeGxhR085b0k3akcy?=
 =?utf-8?B?YW5uTmMyWlVvZDZYcXNzaGVaUlJBc2d0SWpiUE5FMm5rOThTZ1k5RHFyY3pS?=
 =?utf-8?B?SURrNmY4bVZLcFFPTlp4MG1tVG1RYnlUMnJuSGxCUUkvTUZHNDhmTW5tNUhC?=
 =?utf-8?B?OG5xaHFyTEtKMFQwMGRmWXYvcUVOaWo5cTBlaVo4QnJXU0lCK281YUhoZXRO?=
 =?utf-8?B?MThpTGFrbXM4eUVYT08rSmdyNnF5QUZzSVpqM1R4enBnMC9CTmUveEZEWWZh?=
 =?utf-8?B?OUtobSs4Y0pqVmowaWZ2NWxRS005THZPSEhRK0pLNmhkSk9IdW9PRFJVS3Mr?=
 =?utf-8?B?RVBHMnhxZEp5Tml2TGtZRCtBejBvTWFWbVNwTEQ4RkRXbnZLVHdWTHk0RFhH?=
 =?utf-8?B?Y2xrTHR5ZEwvSjFjNER5K1JjRmVSeXhSMHM4bmtuTGtMRGU1RzIyN21tZnBY?=
 =?utf-8?B?MVluNW9XYTNyeGtIRllES0Ntb2QwVGtGdHJ2azhUSGNXS2xHU04rNXhJUXJP?=
 =?utf-8?B?MnVraHVLd2t3R2ZjZHNCcitIZFhnWUhoZllpdDBUWGd1T1MxdGpXZ0NwM2Nl?=
 =?utf-8?B?UnQ1aWhJMUVhZVcreGJqb2x2L0ErY1MwNDNrTHZlR3pERUNVZlVraHR2NWJY?=
 =?utf-8?B?dUJKN1RIK1lwWGpJZnIyMEhpTXpDSlhhbnhKRGVER2ZHWmpzUmhBN0Z1MjNy?=
 =?utf-8?B?YjBwQTQ1b0VlbDk1b1FHTkdPTmw2QVRIN0plNlNWVzJsYU11dEJucXl1VDUw?=
 =?utf-8?B?OXlPMXdWZHYwRVFCOXNFNFc5QlpVUFdsZjFPajJxTW5KaEo2NVN6aGhobmVk?=
 =?utf-8?B?QWY3cUJaeFpGSUlSakwyeXl3VVVJYzFJejZRSGI4b1dhWnNpZFdBM1E5Nzl0?=
 =?utf-8?B?STJEWXBwNStnU3VHTGpXbDB1a3RDMVB6eUdQOHlwNWpQTnFrRVllZXQxTXgw?=
 =?utf-8?B?bnVibWQ2MFBHU1d6TU54QXJBQWlYZ1pjWnREdGozeEQ5UlMvKzlVQVVoV3A2?=
 =?utf-8?B?eTZxd3JmVzVWYVJieGJOdmYwOUdvM1ZZK1NudTZjZDZETUVjZVpjcDZGN3FO?=
 =?utf-8?B?ay8wQ011bW5LbHNyUVI2RzNvL0MybjRzVjB4bWpIbSs2VXZUczBVWjBYZmV2?=
 =?utf-8?B?SFIzbTl3SlZIWnc3Wlp5QTlKbnN5TlA3R2xEdXozdXdlUDlGMTBBVTJsQ0Nu?=
 =?utf-8?B?YS9VY1ZwWURnejc1dGdsOHVpemVvZmJYNGJNaCs0OThvRUNDRzNST2RmaVRL?=
 =?utf-8?B?dnFISlB3QUYyd3lSRHFtWCtaa0VuZFFmenNjb0NXb0VxODdJQndDK3hiTVBF?=
 =?utf-8?B?aGpmR3pCNmlJVFpQd0FKa0d6VU04d2hKbHZ5WEpJS240QklOVG10ZUZGeGkz?=
 =?utf-8?B?TVRIaVBQTGlYZXRXREcxUUxlcWVJNVJ3SVhXNDdUbzN1Vk1taVlzOVY2Vnhu?=
 =?utf-8?B?UGNISTdiU0xWN2pWQm1zN1JIcXFlN1BmaElhQ0JOK3pBYXJLNWNJNlFnSnRG?=
 =?utf-8?B?TVF5Si9uTHVFWW5HOGtyQy8yVTc1bDJKa01jemtrNlNkcllEclcxbXcvRlpG?=
 =?utf-8?B?OGoxYVAxYzNEbHhEeTlqd3hhZjFXRkZEeDFwT1dGV1B2OWgyQ3psdzdGUzZS?=
 =?utf-8?B?L2hpcFVwUmRxRVRrUmpjazdHWEdiUHVsa2VRc2grZzl0bHNhS3NqUjlGU09C?=
 =?utf-8?B?bUMvakhSOFdVTWNxbzNkRGhwS24xUHFMRloyUXFUVU1OTjBiZERaRHNEZDgy?=
 =?utf-8?B?MEtHT092VVhQNVd3T0lXdHI1VzNFaTYyeFloYmVBRkRSaGVQd095QnFsU1ZV?=
 =?utf-8?B?OVBoZFFKYURwVDE1ZVZyY2h4WWQ2WWdpY3JqdXArWG1hVHhpVTZkdTZiVkFO?=
 =?utf-8?B?eVhTQzJGSUZCbEJDbDkrN0U0OW1iOTRNY3loNHlmanBZZU81aHhpbXlKazla?=
 =?utf-8?B?WlJ6UUF0aThOZS9iRFBCdk95UjRYemEvOWc3dkpNTGY0eGlVQ2h0NjNQNzVl?=
 =?utf-8?B?Tk9rT09FWTIySDhNUnBBV1V6UkU3V3Q1RWh0L0VOV0JGY0xwdmJOL2ZvS3pw?=
 =?utf-8?B?S3liMnZCUTFJY3Mxb2Y2VERpakNZbkRPZHg1K240bjlRdTVsQ2lTRTZESUJh?=
 =?utf-8?B?OEhyUEZPZ1hCT3lMUmtGbjBUN09HOFRRWHI2RUFnUWZNNjF2Z1dZSTMvVFRz?=
 =?utf-8?Q?MBSbUtkIOwlu0+80j+125Zk=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c414639d-e987-462f-feea-08d9b65ca366
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:58:44.6287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MUghak0CTWpMy4xHyXuc5Oi4CoYBsIxZPzqMedTcJt0TnoXhR7IMWqLDo1eyPk98eK5PGOdv/qR9iaSS9VC8hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 26.11.2021 13:34, Andrew Cooper wrote:
> This is necessary for read_cr4() to function correctly.  Move the EFER caching
> at the same time.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:00:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:00:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237606.412111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8AX-0003Ti-0z; Fri, 03 Dec 2021 13:00:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237606.412111; Fri, 03 Dec 2021 13:00:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8AW-0003TB-Sp; Fri, 03 Dec 2021 13:00:04 +0000
Received: by outflank-mailman (input) for mailman id 237606;
 Fri, 03 Dec 2021 13:00:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8AV-0003D2-Nq
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:00:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id edd538b7-5438-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 14:00:02 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-SqofBKZXMfm3zklGrtOw4A-1; Fri, 03 Dec 2021 14:00:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Fri, 3 Dec
 2021 12:59:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 12:59:59 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 3 Dec 2021 12:59:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: edd538b7-5438-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638536402;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8L6gKBQB4yw9bPpzm9o0BysGMBwhBrfVCZM/fzk3hqs=;
	b=Ytzwbdt89jmw3J+Y6vTNPqs9xr6QozsWbRmcUAwKGAWbU3/oSoBqvfnGtnABx+AJRFfIRN
	cwsjNUffXZzJXXQGBqAZqUZnSEhoGHgdr4A3QpFWJly8az15R+PAeTb0k0k1vv6qP+cosC
	seaJasIzxvVm5WujuXHMW1ZA10KC7r0=
X-MC-Unique: SqofBKZXMfm3zklGrtOw4A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P6X1e3vU7+p95LldtGs05B9lWJsTJgujDud9Ymw49MrKpCugUU7J9OEwUqqAUxhwZG9EtNSBcLmydVARmV/rHZRtCZ3APRNZNpfquHHu0idVIsK74pj8DzpHreXIBdKUM1hSvq9SPZ6/wVUIx0IEu8P8Acrg774JW0gtb2kRSpjH3dOrhRU3G0+EDVEJtxMlmmmXlzQr+2sv9ddP6YhIOwB5ANJyazBAcFMP5CQooh/l4+lpghgRVOOpesGCH0RFoDuJDq7WL3A6wxLrucRgHQIA6/TsZyYdel/xzaTWa0BQfMtzYCx/YbMyDTI25UH53rUB6DvHiC7wV4C+vBExNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8L6gKBQB4yw9bPpzm9o0BysGMBwhBrfVCZM/fzk3hqs=;
 b=FAZoI8c6FcNi91TWV7QdRph525xM02EoVEYvuTz6+laZgPghjP8IKHEHPouknUKVFsSKrwcq4IkViDZ5nELR9Qqdzes7p7cgHlFyDoiualWL+3qcJPhJooflnwpUHmBuXOfMO4skiO28XQkbqq3PjlQMTmh4ft6zXrYRfVsR+nMDDIogaAErcECGb2FVTju3NDpBjuURfPJO/V7UfPvsHyu2aMzXpGNMjw7uLeUJsaQmlsyM1g10uloLsGz9iHghfMV0lKBoPQNCcZLBUAQ4KStoNtD5OtsWTU5pWVzxJ2TrVdqSnb4egJHoqFBX9ljAv7UV+Tu2kC/nMN3S2NoaoA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a87263b9-5cff-d106-a3f2-0e8719c9124e@suse.com>
Date: Fri, 3 Dec 2021 13:59:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 58/65] x86/alternatives: Clear CR4.CET when clearing
 CR0.WP
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-59-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-59-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8d16dace-d359-4353-bea8-08d9b65ccfc0
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2957C82EB01FD23DACBEB5C0B36A9@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1824;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lnjXU2DAzoWvI3QXcMSxEnh+sAnhTCrfcNSyaJoWV7JkwnagBrN33kfx8TKG8P0GD4hm5EeFIoDcQJM5HYavZp5MxVK3CGNtDk+ny5J74rZU1Tj4Wn83d7bTYxEwlOvqlnuMD0x9IMgl2b74AWAu/tOO23NY9U7XE41ofmtcK/mcRyQc5XLWzFEukOuw8lKkieLDZvjyTDgccBi3TCBy3Lhx5TKAA4vxxnf8rhLP2Zrop9d2OT6+Cs+OoHQpCmM7cFOktaDpVS48b2hZsgikWRU/kfKuK5SNPeNz8DeQ1YlYvGGRsEJt17aVospEZhHwaL8vcopcH+pSd/fK1r8Td0s9vJf0MQ3Z76d5UutOFTgYThJByvjaWqqRWfNggHIhLMee5bAxMPHecPkmVtgf/hmORV/HfNGLZLu8sqeq/zBJg2lMptHwqs8ss9VqYUxH9uLq4u2Au5iLwsEH6aHL9BttFMlEFymXF9Liajmk1t6krxiU/2kCgwZkrPcDZLVEwDDawTXNzwAtE+dJLn3Kms/IL/lYfanzqdOJAIECFa7k5KfDRej/kyI072RbxuOhsUHYAx3sVpRxM25PviBfaNYbbMXg1QmVhsRO5XXwb++npFZ65NX6Me/BUY84IjrPZCKAAPYFvoEXWYOXWx5HmHo6ss6qNaJSMo+GrKV8s3Jrjanp11GriyCFW6GbS4pPO8kTos6+p6pvK72MTHxBuIyty30UCm/iY9ea8NJpxJs=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(86362001)(956004)(6916009)(53546011)(31686004)(54906003)(2906002)(6486002)(508600001)(5660300002)(38100700002)(558084003)(31696002)(8936002)(4326008)(26005)(66476007)(66556008)(66946007)(186003)(2616005)(36756003)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eWpZakNmL3BJdFBmODNJcDU4ekZ1L2F5cUdNYmN0Q01iWHJqM1lCS3orZEQv?=
 =?utf-8?B?aG03U05qQ1VHYVFrTC9yVUNtMjRwVlNia2lFKy9jS002Z1lJc3AycG0rRi9y?=
 =?utf-8?B?aWNVQk8zN2JWMVVLTys5aXY4bk5UYnd0VHFQY0VianphVFQyTjduRWhaV2RZ?=
 =?utf-8?B?MDc4d25maWNwWmdKMlZEcG92Q1RZbVRYcllsRXhHUUhZN0hiTHp6RjJHaGJs?=
 =?utf-8?B?MU0vbitTbjFWZ01SQk9vc2l6eVptNDRDYzZSZzk0RzlLSHZLYnBSZVZtNGpB?=
 =?utf-8?B?RDZsb2llbFJJa3BQbkVGRUp4aUNYb3V1cUtTTjJBNGRIbTVHSGdOZERsT0FB?=
 =?utf-8?B?RmxxNWFkV0JRUTBLL3M3TzlhajRCb3MvQnpHWXA2NVFMTEFIVVp4VUJ1TVlv?=
 =?utf-8?B?S1pjSDIrTkhZM3hNbDJzTFRxVjN5N2w5OTVlSTA1TWJQM0VHNGtDYWNDMlZ2?=
 =?utf-8?B?VVJ6YTlEaEdSajNNWTRDblcrRVRYTmJHNlhWRnFHZVFkUkFMcHRZQ2FOcXls?=
 =?utf-8?B?SzhmSzRHaTlVYWxBYndHUFQ3SHprMXhqckhKZFNaT1dkdjdVdDNvUUl5aDlv?=
 =?utf-8?B?bWU3S1VERkJOeERaZWFiTG8rY3M1TGdPUEtKTCtxaVNYU2NPd1ZjQ0tqeVFh?=
 =?utf-8?B?RklkVnkrNHZtb3JuY3V0THc0dDBMN1Q5bnNPYU1jbEdkNFJVM3pnekM1YURa?=
 =?utf-8?B?QzdFT2kyVzNxV1RWZnVYWXpDc1B4eTFDd3VlSmNvb0F1Y0JVcnpQcUdiY0ZD?=
 =?utf-8?B?SXpJNmNzVTBxMzA1YXZkSm1xRml3N2s5N0hUaW1sMVhPQjA3U09qYnhLYko2?=
 =?utf-8?B?eGJGTWZVOWZiRlo4SVFPT25WR0VzN2lhcXNReFRXN25CdDBlY1IyaFFHdjBC?=
 =?utf-8?B?VGtMTnpseEk0MHY4MkQrbVhFZkVJM1ZVOUZjRXBCUXo3UkJrcXRRcWhZVjZv?=
 =?utf-8?B?MGRtdFVzV2RkcGlJUmVoMWlkRXlDT0ZoK3VyZVZVSlJWU1ZndEkrS0YxRm1I?=
 =?utf-8?B?TVQwTlZYSWxQSTlHWmo5K0xBcmdEenpuUTYzVUJUUnpmOUFCMkdSYkhteXg4?=
 =?utf-8?B?VWtXY0FOdlBHK2UzczVISUFmMEcybEhncmVzSkdZbE5BdFB6ekFXWlg3alMr?=
 =?utf-8?B?MDhYMUs3TjdiYUkvUC84dFova3FSUjNtdjJ6Q1J2TEFiMU1LcFR5Q0J3Z2ty?=
 =?utf-8?B?ZFduNE1jWnJZb0ZISUkrbEtlVHNMYW1BRmxYZklIWEo4VkgwU3hNSHNJVXVE?=
 =?utf-8?B?VC9kSlI4WVJ4TU14bzAvMllJN3U1Y29heU9HdFZtZUJlbkdNRVpvNDNoQmZF?=
 =?utf-8?B?ajR4bnVQMTlhODZzenJ2eloxMGFVandmYldNa204WW4valY4QnBTWU40VUNG?=
 =?utf-8?B?TXZzZGtMSmhuTGVlWWlwWU5GdnpaQ3RCTkpSSzBPMk9SUXR0TlBpdnBWSlNw?=
 =?utf-8?B?TzVZc0kzejB6ckFiUFBXcjgzYWtqSU4xYzVMZGVuc3B3bUlBWndGL1hKemZQ?=
 =?utf-8?B?alJNdkZkSlVRc29XajdSQy9kdHlxZ2QzUDhmaW52Tk1aUmg5VTlEV2FLMWl2?=
 =?utf-8?B?T3RHT3FGTThHRW01YWVJODNjNm9IQTNGaUxWaHlFVS9lMXZtL1d5MGRXZnBP?=
 =?utf-8?B?eE53VUcwZlJaQ0lNNDlQUlpQNWtwMWhDditSdzJpREF1ZHVHcVM5dGVjclI3?=
 =?utf-8?B?aEwyNExmOUQxaGlIa20vTWJCYXgxeDlFNGVtaGQvU3ZRQUFFZm5BQ2YyR2ZD?=
 =?utf-8?B?a1drUjhZQ2lvVnBlYmtSWWJjYVZ0UFJmY3FhL0hIaW1aV1hJRVFBUGdwYnMw?=
 =?utf-8?B?cEJHdXpzdUhBOUNYQWIxUTM4SG0xTTU1OTU4cXM1WWxmVDJnblpieEZIZFVu?=
 =?utf-8?B?dFhjaC9OcHpwaUNXcjlRQm5HcWNsWFVGRDkvVWw1Tnp3MzV1K3FQV0oyazM5?=
 =?utf-8?B?UmdRUEhsQ3lMYkdyUUxRckZVR2ZNTjRUSC9URCsxREEwNy9yVDBQcDFGM3hj?=
 =?utf-8?B?MmRPUkFwRVBSODEwbXlYMnVGQ2dkZ3Q3NGQ4V05waTJXK0xQVmVlRnAwZ3lC?=
 =?utf-8?B?QWh6ZS9UOTFTTlpvaThjZlBpYUs1RWZTNzl5Q0V1M2F6K01sSXpXUjYvejJz?=
 =?utf-8?B?cUpUNkhwOEJaVnpZQzNWTWs2cFplWEdRNmNDMFJVMTFKZnJTQ3BpL25qTS9q?=
 =?utf-8?Q?VazDnRIQtQvAi4J5O9/dtM8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d16dace-d359-4353-bea8-08d9b65ccfc0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 12:59:59.0226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w/b285eEMGA1YC9edPUqo7sn+BwL5xNXFoMhYaJBfdtQFkAjrjPccOaSbo2Nx88T49LnF/15VsDslWCWEdIDaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

On 26.11.2021 13:34, Andrew Cooper wrote:
> This allows us to have CET active much earlier in boot.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:01:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:01:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237613.412135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8C3-0004Oj-HG; Fri, 03 Dec 2021 13:01:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237613.412135; Fri, 03 Dec 2021 13:01:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8C3-0004Oc-Be; Fri, 03 Dec 2021 13:01:39 +0000
Received: by outflank-mailman (input) for mailman id 237613;
 Fri, 03 Dec 2021 13:01:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt8C2-0004OT-GA
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:01:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt8C1-0004jX-Cc; Fri, 03 Dec 2021 13:01:37 +0000
Received: from 54-240-197-232.amazon.com ([54.240.197.232]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt8C1-0001t1-67; Fri, 03 Dec 2021 13:01:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=CR8dscnd52wvDxYKBMuYTBECdFZU19Y9HvG1QbW51/I=; b=qQc8d9fDo7+bbFnLSdwFCdNawa
	D9LVhhgbgWWN5iuC6CDXFE4MqSkP033Alc07/cF45uh57kU4Zfnz24qEWISI4eeS3XSMTygx0dpJ5
	jFzej4ddkwqFnKyzzy+UL2acVCX/GYj3pC3p/f7UL/Yw//1hcafEzOptqNeqESWNsJes=;
Message-ID: <f543ce0d-8b0d-2b02-e9af-ae8d90f4896d@xen.org>
Date: Fri, 3 Dec 2021 13:01:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 0/7] PCI devices passthrough on Arm, part 2
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> This is an assorted series of patches which aim is to make some further
> basis for PCI passthrough on Arm support. The series continues the work
> published earlier by Arm [1] and adds new helpers and clears the way for
> vPCI changes which will follow.
> 
> RFC is at [2], [3]. Design presentation can be found at [4].
> 
> I have removed patch
> [PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices
> as it seems that this needs more time for decision on how to achive
> that.
> 
> I have also added a new patch
> [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host bridge
> with a tiny latent bug fix.
> 
> Thank you,
> Oleksandr
> 
> [1] https://patchwork.kernel.org/project/xen-devel/list/?series=558681
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (7):
>    xen/arm: rename DEVICE_PCI to DEVICE_PCI_HOSTBRIDGE

[...]

>    xen/arm: do not use void pointer in pci_host_common_probe

I have committed these two commits. I was going to also commit patch #6, 
but it looks like an ack is missing from Paul.

I still haven't reviewed the rest of the patches.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:16:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:16:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237626.412151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Pz-00069R-PB; Fri, 03 Dec 2021 13:16:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237626.412151; Fri, 03 Dec 2021 13:16:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Pz-00069K-LE; Fri, 03 Dec 2021 13:16:03 +0000
Received: by outflank-mailman (input) for mailman id 237626;
 Fri, 03 Dec 2021 13:16:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt8Py-00069A-GY; Fri, 03 Dec 2021 13:16:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt8Py-0004yS-CO; Fri, 03 Dec 2021 13:16:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt8Py-00083v-5f; Fri, 03 Dec 2021 13:16:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt8Py-0005tT-57; Fri, 03 Dec 2021 13:16:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8oomaWCObGV6U3MuPTcheTzH7HImV29Q2ktY7BWzlZs=; b=yfstF/Qy+j2SrpTVSg+HQpJWWn
	plcNL269q4M6CDuLw/KG8pq0I9aWM95j1m5l8HFrJEBFubk3tu8GzpvxbD/a2r40dIp+ieOj7WHpR
	nTUmnmg/8q+kh2x+QuBmN0naiblXc2Np1vRUF9KhddkMeT64NYm3LDMFfUWq53RUa468=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167073-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167073: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=05657c6d1821dfc4e9a618767a942b3555406046
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 13:16:02 +0000

flight 167073 xen-unstable-smoke real [real]
flight 167086 xen-unstable-smoke real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167073/
http://logs.test-lab.xenproject.org/osstest/logs/167086/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  05657c6d1821dfc4e9a618767a942b3555406046
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    3 days
Failing since        166977  2021-12-01 17:08:21 Z    1 days    9 attempts
Testing same since   167051  2021-12-03 00:00:28 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 05657c6d1821dfc4e9a618767a942b3555406046
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:11:01 2021 +0000

    x86/boot: Support __ro_after_init
    
    For security hardening reasons, it advantageous to make setup-once data
    immutable after boot.  Borrow __ro_after_init from Linux.
    
    On x86, place .data.ro_after_init at the start of .rodata, excluding it from
    the early permission restrictions.  Re-apply RO restrictions to the whole of
    .rodata in init_done(), attempting to reform the superpage if possible.
    
    For architectures which don't implement __ro_after_init explicitly, variables
    merges into .data.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 8de86b5cd4353bf2cc415e4563f973f071b4e8a3
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 20:04:11 2021 +0000

    x86/boot: Adjust .text/.rodata/etc permissions in one place
    
    At the moment, we have two locations selecting restricted permissions, not
    very far apart on boot, dependent on opposite answers from using_2M_mapping().
    The later location however can shatter superpages if needed, while the former
    cannot.
    
    Collect together all the permission adjustments at the slightly later point in
    boot, as we likely need to shatter a superpage to support __ro_after_init.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit c182e89d0b341d2efc930c2e1211d3e866c0effb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:01:50 2021 +0000

    x86/boot: Drop xen_virt_end
    
    The calculation in __start_xen() for xen_virt_end is an opencoding of
    ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
    
    This corrects the bound calculations in arch_livepatch_init() and
    update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
    with CONFIG_XEN_ALIGN_2M.
    
    Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
    dynamically"), there have not been extraneous mappings to delete, meaning that
    the call to destroy_xen_mappings() has been a no-op.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit ffa5d037c78fe175f31373deec0759ff8cc8d66c
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:52:05 2021 +0000

    x86/boot: Fix data placement around __high_start()
    
    multiboot_ptr should be in __initdata - it is only used on the BSP path.
    Furthermore, the .align 8 then .long means that stack_start is misaligned.
    
    Move both into setup.c, which lets the compiler handle the details correctly,
    as well as providing proper debug information for them.
    
    Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 3099ff3ce15481b4f1536470cb87ac0ebf82b7bb
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 19:19:43 2021 +0000

    x86/boot: Better describe the pagetable relocation loops
    
    The first loop relocates all reachable non-leaf entries in idle_pg_table[],
    which includes l2_xenmap[511]'s reference to l1_fixmap_x[].
    
    The second loop relocates only leaf mappings in l2_xenmap[], so update the
    skip condition to be opposite to the first loop.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>

commit a15b143a5f1c20dc6893bc3e50873e308ef61d87
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Nov 29 16:09:08 2021 +0000

    x86/boot: Drop incorrect mapping at l2_xenmap[0]
    
    It has been 4 years since the default load address changed from 1M to 2M, and
    _stext ceased residing in l2_xenmap[0].  We should not be inserting an unused
    mapping.
    
    To ensure we don't create mappings accidentally, loop from 0 and obey
    _PAGE_PRESENT on all entries.
    
    Fixes: 7ed93f3a0dff ("x86: change default load address from 1 MiB to 2 MiB")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit eb41074692094dff1413efb44fa4928a9140aa41
Author: Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Date:   Tue Nov 30 18:12:38 2021 +0000

    bitops: Fix incorrect value in comment
    
    GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment
    in bitops.h.
    
    Signed-off-by: Ayan Kumar Halder <ayankuma@xilinx.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    [Tweak text, to put an end to any further bikeshedding]
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 6c1c97e24f830a921a23e3b9694e20493c9986ee
Author: Ian Jackson <iwj@xenproject.org>
Date:   Wed Dec 1 18:07:40 2021 +0000

    CHANGELOG.md: Start new "unstable" section
    
    I have just forward-ported the CHANGELOG.md updates from the
    stable-4.16 branch.  But we need a new section for work in this
    release cycle.
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>

commit eef266eb770128db0d5258009b744f0e0c31c9bd
Author: Ian Jackson <iwj@xenproject.org>
Date:   Tue Nov 30 11:40:21 2021 +0000

    CHANGELOG.md: Set 4.16 version and date
    
    Signed-off-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit 36aa64095d0419d52d2466405ac13b9858463f48)

commit e058b2d4e5e2ad7ad03941d36ef9243291b35671
Author: Roger Pau Monne <roger.pau@citrix.com>
Date:   Wed Nov 24 12:24:03 2021 +0100

    CHANGELOG: add missing entries for work during the 4.16 release cycle
    
    Document some of the relevant changes during the 4.16 release cycle.
    
    Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
    Release-Acked-by: Ian Jackson <iwj@xenproject.org>
    (cherry picked from commit e2544a28beacd854f295095d102a8773743ac917)

commit 9012687f05adf96440316ce338514db574ebfde0
Author: Luca Fancellu <luca.fancellu@arm.com>
Date:   Tue Nov 16 15:06:24 2021 +0000

    arm/efi: Improve performance requesting filesystem handle
    
    Currently, the code used to handle and possibly load from the filesystem
    modules defined in the DT is allocating and closing the filesystem handle
    for each module to be loaded.
    
    To improve the performance, the filesystem handle pointer is passed
    through the call stack, requested when it's needed only once and closed
    if it was allocated.
    
    Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

commit ad9cf6bde5b90d4c1e5a79a2803e98d6344c27d7
Author: Vikram Garhwal <fnu.vikram@xilinx.com>
Date:   Thu Nov 11 23:27:20 2021 -0800

    Update libfdt to v1.6.1
    
    Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc.
    This update is done to support device tree overlays.
    
    A few minor changes are done to make it compatible with Xen:
        fdt_overlay.c: overlay_fixup_phandle()
    
            Replace strtoul() with simple_strtoul() as strtoul() is not available in
            Xen lib and included lib.h.
    
            Change char *endptr to const char *endptr. This change is required for
            using simple_strtoul().
    
        libfdt_env.h:
            Remaining Xen changes to libfdt_env.h carried over from existing
            libfdt (v1.4.0)
    
    Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
    Tested-by: Luca Fancellu <luca.fancellu@arm.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:18:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:18:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237634.412165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Rv-00073f-Ei; Fri, 03 Dec 2021 13:18:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237634.412165; Fri, 03 Dec 2021 13:18:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Rv-00073Y-AA; Fri, 03 Dec 2021 13:18:03 +0000
Received: by outflank-mailman (input) for mailman id 237634;
 Fri, 03 Dec 2021 13:18:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8Ru-00073S-H1
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:18:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 70b088be-543b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 14:18:01 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2057.outbound.protection.outlook.com [104.47.8.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-4VAkWZnjND62joS597Uqwg-1; Fri, 03 Dec 2021 14:18:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 13:17:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:17:50 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0407.eurprd06.prod.outlook.com (2603:10a6:20b:461::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Fri, 3 Dec 2021 13:17:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 70b088be-543b-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638537481;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Dk7g7pKTgvSk4erLP9gyvcK/63CC8Tw0S3OEfmyM7og=;
	b=GLCb8ioClphLgUPXp9vRyvZvZC+6nxNQRNTIKOaSWYw+6060O4UZwAlSffEUHPMHWnAqRk
	Kp9AzGWt/Y+PBPL4jM1jq9CEdkHm8hBegsg/6kYhDac5WvhqB8IPy6OfsyUgmiey0tkXCK
	UZWfo4fB7KcgpcwX99SwhL59o5cZ1XM=
X-MC-Unique: 4VAkWZnjND62joS597Uqwg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VWOoLeNCL/EgPxud9lB6L7LNgD1LQihjVvp+g4EC+34/oBuToXND4+FNoGl7S3kfFYMGVSY4a3mU33GBTOVH9XYfAObyXdBKREJZuaaZZaBUISEdP4b35L7vakQVv/OXTf1MPXJdSV1Qb+7ii/1i9GIYFqRZjDrV3w1dx6SaX6ddic8O3pg9hjRbHj2RE6hn7/TsAA68WeE6TzdWp5ynSz9Bm8AlnSp1SOILhLpVZIMbmhQe0RLJrnsNSVemXJ8jPq3YbfdiFBlFKOIV4OQKPHGY5nW+LlPPbBWnXZOT0aofDs8Eee4MKDXY32hfgjP8NXNkuO6u7ny0O/tNLLdB5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=We+YTmrpzElMidYTz8f2f3DZP3Q1/nzvwAU2jGItKiA=;
 b=GzB8zfyIcsVNbXoO1/XG0bpkmmV2WZiZPyC/U3GRUHXL6r0cDXJpgkftCOLJTOgx9cxa7TETVJiMDp5uVGG7ZrmrtXEvnZQbG99nSVG1xYGOjFgsyRM8+69anYbxsT1ADZbH5/1X8dfOsQ5XPmDnS4dUtCtnr0qRdFJR/7VBcd57nTlvkT2QAA1v/m85qNs75jsR8smwGQHzA5hjpc1v7BhJiykAWivFZhFuTFAEkU9Dn79OIOd9/vZiJ2kInxb8r1UmEDpMpr4zwO0Q/AU+9Wl9dQ9QJkZla8bDByacKLOPjR+PCCP+s6hmD3eMPaeohoRksRWfGOt0mBBR7T+HFA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a8434878-129d-8207-09e3-4909e638a4d0@suse.com>
Date: Fri, 3 Dec 2021 14:17:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 59/65] x86/traps: Rework write_stub_trampoline() to not
 hardcode the jmp
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-60-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-60-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0407.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aaf2f789-36e7-48eb-286f-08d9b65f4e72
X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3295A52ECCE2193AA30ABDFCB36A9@VI1PR04MB3295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6/fj/i7OUHNW8lPTkjwqSNALbiguZTtX+wd3JiVa31nv8O7iDSUHLk96Hv0473lWzt85bElI4vvnU73M3JldGaCMSQnaEX1U1mHBgNGQ5GOr5CZ6sghjUvfjX7azZBzNp1HKwF83v2trWZal+G1mdDbvXaUg3fHBq/fDDu20y2xkG4xhg7Uy5T8tbMQx0xoU2aQ77DSZCrOy0On6WbDjYyE3LdHtoxW54FppHOBaV56TG2NDucU49P8Z2utHqLukZiKg3PFV0x5GI++H8TGeZ+vNMBuUhhaBYHivxzywImJw/LqGwjTh6WtW7Mr8VAsviuexxBKpL5MdgVSOVeufPwQyK4WSVav/537pja+WcIltSlfB9ablZ09G0d8gBUIiXuQSzULmuiyCgLqCNgsoZuFzzdI3uD56a2SyF1NY6gO3RMAs+Ij1izE7G7KdTMsNLpUqwTLhZtBrPmFWH42pQqg0oF5ZIL1zKYkQTm5aG19CecNtkV+RBds4s3Ha7tLSXVVZ0O14/jOtlfO6pC1MYYfjkKhOzQi/i4sNIHsiefMkdTlrvZmxF8NioGUHvlCI68d8xhwhu6fkidaCSTfyv0tRufcqn/Un7esCDvZ9ySS9rumAhlGyiO/pddiy1xVitcKQFX3cl/cK31Zt2IamfSVciX7hedyvbEbm9S7Xg0UbvesFXjccgcZ2VTcSHJlAmBgpy0kJMbkQscz0kaAWjybkgT8Q1+1BAzhKL+dwMsI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(16576012)(5660300002)(316002)(8936002)(83380400001)(66476007)(6486002)(66946007)(36756003)(4326008)(53546011)(6916009)(508600001)(38100700002)(956004)(26005)(31696002)(86362001)(8676002)(31686004)(2616005)(2906002)(54906003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4sE/1gxvyyjkxABPI1lt7WckZV6P/puP0PIjiIlH/vWxS0QbLn+4X3pDN9Wu?=
 =?us-ascii?Q?lNC4K54XVZdsdBAqK7Qpf9CDa22kgxXTEdKfVjnay7G1oJNx6kDkUYeHiqoc?=
 =?us-ascii?Q?diiLHkVFetFG/TDN91KMcdt4jy1vu3spU3rlpOg5siY+hwkTtVyWVENaasCm?=
 =?us-ascii?Q?mq1BBijcBsE/avaT36FN0nVoG57K4tS3clByfq8rlfmRdVfog3c5O0+BCBNi?=
 =?us-ascii?Q?Zr9tH3DqxHmdt/pFMcplpCLgvCRPiQZMgsKVeNogkdrgLWdpKkB5hLqDsgiH?=
 =?us-ascii?Q?fZ4CfKXDWQv0th22BCiIdcRTyoNJW321spxxay/q3r82YYjLBXYRSLEyKUio?=
 =?us-ascii?Q?PsRCZgU+CyAPP1WSS9I5EbU9OfrYpLgkaN0f8BroImU6auLo5eRvN2W/kxeW?=
 =?us-ascii?Q?I6qFfWhEyeYLzHjnDitGs2C1m3Vm5rFCQI2FpjXqiAfL2HaGXQc9wd0/Wubp?=
 =?us-ascii?Q?y9nxKa4VCuexrQ8A3K13dkTAfSMOCudpCiT9HmO5FnoBqbz3iDZplywuatoh?=
 =?us-ascii?Q?7C0ZCYy+jautCzjCrTuwZKF1/SThI2dH/NmlYoaA3Vs/drgdvhxzunygMpPc?=
 =?us-ascii?Q?bOp7NxVgMVMIu84HMPEeazV0Tg524ogK73fD4e7D4hITo67XkNDjcrYfkIw6?=
 =?us-ascii?Q?8RWYfIka2Ym6M8U+Oj2CT1scQvL9IpqueeFUs8+QQnb0NHRkg9PfG0Mf24X9?=
 =?us-ascii?Q?iRNtC8tm/kAyIxVkolIIlgtcn2QRoMbhFhC3qh5iT/5jzaCMsNGYK8OZEXAp?=
 =?us-ascii?Q?21pvH0wowD4MgAPBmbghSG7jq+fxHpZ32rtkf89isapzahk0hqsi9jNWb0oF?=
 =?us-ascii?Q?IA7xsFcy8ghl1YBnu7fejhG/9R9hSLHFkHrDD1Zq/sQBnG9YDIGW5Ou9tImw?=
 =?us-ascii?Q?67yY5c+2RqIdTPTxaNaizdIT8zkZcUowaiY+J+YhkKqglzLw0uYQs8fkb3ZA?=
 =?us-ascii?Q?vh/IfBKEqKWcSrna+GOK/Hy36XeHCYn4sgl06vzDSItHTxRAw3STWVZFtZVf?=
 =?us-ascii?Q?Wlm0ItTH1DMsladze60r3VSMu+Zt2Li3tw2Ss4CEOeX0QLhYgK3qiJ9RsVVW?=
 =?us-ascii?Q?VRsrCW9rSq5wjjSTe5MgkQMExfnKQYqvyRtbKG/ThE24TE8aWFkvsrNUiHDK?=
 =?us-ascii?Q?hPG9mgo5PdCi4B77B1kSGQYk9hEMua0d+8SqBms64k7kX4hDN9TZCQIxXbPs?=
 =?us-ascii?Q?bTUupq7k2L2SZNkfDs4W1Je0djmVegYUQW8eE7QNTHiQKKhJ8cV0x4IaeWIZ?=
 =?us-ascii?Q?RV41S82Ez8Ti1Te1cAOMU0BzRhpBEqRe1l8bzMtWprzka91+Ec3NbKk51VZ3?=
 =?us-ascii?Q?okKQFOHjEkkP8C7NhYCYlVprcXGgMzr5HzXuBBWemqidnOS/Jl6zphFceMr8?=
 =?us-ascii?Q?LVGfhPAJAMQ+jF0WUWk/Beda1nFVahR8K289Wi/xLoOJjZqduzOseUmdb1of?=
 =?us-ascii?Q?DdXLuKLr56lAw8E7/Syay0zlwjqUX5nCarNehJJiUB7UYFlwpECEUl7mqjSo?=
 =?us-ascii?Q?EfRzsDkKt6MbdAqYcUoy1Xe6owLMZCD0Hi0jiU/Ugwf+pGcaxkwypPnYoA7Y?=
 =?us-ascii?Q?85i61rickZIX8y/A8eWqO2cR7aiTjUaTM1GEPHlXd+Ud3da1JGgFCvj/xJ6M?=
 =?us-ascii?Q?5ixc95UVqyo4Bxte7GOjyzs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aaf2f789-36e7-48eb-286f-08d9b65f4e72
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:17:50.5587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wVvniTPxARyI8l3xEBM/G88oZwrANbagf5mnzqatyIlv3pw2ULvZDQMwrdBDenMDW6l8OxmOS91YNvNuCEzpDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295

On 26.11.2021 13:34, Andrew Cooper wrote:
> For CET-IBT, we will need to optionally insert an endbr64 instruction at =
the
> start of the stub.  Don't hardcode the jmp displacement assuming that it
> starts at byte 24 of the stub.
>=20
> Also add extra comments describing what is going on.  The mix of %rax and=
 %rsp
> is far from trivial to follow.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> ---
>  xen/arch/x86/x86_64/traps.c | 36 ++++++++++++++++++++++--------------
>  1 file changed, 22 insertions(+), 14 deletions(-)
>=20
> diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
> index d661d7ffcaaf..6f3c65bedc7a 100644
> --- a/xen/arch/x86/x86_64/traps.c
> +++ b/xen/arch/x86/x86_64/traps.c
> @@ -293,30 +293,38 @@ static unsigned int write_stub_trampoline(
>      unsigned char *stub, unsigned long stub_va,
>      unsigned long stack_bottom, unsigned long target_va)
>  {
> +    unsigned char *p =3D stub;
> +
> +    /* Store guest %rax into %ss slot */
>      /* movabsq %rax, stack_bottom - 8 */
> -    stub[0] =3D 0x48;
> -    stub[1] =3D 0xa3;
> -    *(uint64_t *)&stub[2] =3D stack_bottom - 8;
> +    *p++ =3D 0x48;
> +    *p++ =3D 0xa3;
> +    *(uint64_t *)p =3D stack_bottom - 8;
> +    p +=3D 8;
> =20
> +    /* Store guest %rsp in %rax */
>      /* movq %rsp, %rax */
> -    stub[10] =3D 0x48;
> -    stub[11] =3D 0x89;
> -    stub[12] =3D 0xe0;
> +    *p++ =3D 0x48;
> +    *p++ =3D 0x89;
> +    *p++ =3D 0xe0;
> =20
> +    /* Switch to Xen stack */
>      /* movabsq $stack_bottom - 8, %rsp */
> -    stub[13] =3D 0x48;
> -    stub[14] =3D 0xbc;
> -    *(uint64_t *)&stub[15] =3D stack_bottom - 8;
> +    *p++ =3D 0x48;
> +    *p++ =3D 0xbc;
> +    *(uint64_t *)p =3D stack_bottom - 8;
> +    p +=3D 8;
> =20
> +    /* Store guest %rsp into %rsp slot */
>      /* pushq %rax */
> -    stub[23] =3D 0x50;
> +    *p++ =3D 0x50;
> =20
>      /* jmp target_va */
> -    stub[24] =3D 0xe9;
> -    *(int32_t *)&stub[25] =3D target_va - (stub_va + 29);
> +    *p++ =3D 0xe9;
> +    *(int32_t *)p =3D target_va - (stub_va + (p - stub) + 4);
> +    p +=3D 4;
> =20
> -    /* Round up to a multiple of 16 bytes. */
> -    return 32;
> +    return p - stub;
>  }

I'm concerned of you silently discarding the aligning to 16 bytes here.
Imo this really needs justifying, or perhaps even delaying until a
later change. I'd like to point out though that we may not have a space
issue here at all, as I think we can replace one of the MOVABSQ (using
absolute numbers to hopefully make this easier to follow):

    movabsq %rax, stack_bottom - 8
    movq %rsp, %rax
    movq -18(%rip), %rsp
    pushq %rax
    jmp target_va

This totals to 26 bytes, leaving enough room for ENDBR64 without crossing
the 32-byte boundary. But I fear you may eat me for using insn bytes as
data ...

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:24:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:24:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237641.412175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Xi-0008SG-2F; Fri, 03 Dec 2021 13:24:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237641.412175; Fri, 03 Dec 2021 13:24:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8Xh-0008S9-VS; Fri, 03 Dec 2021 13:24:01 +0000
Received: by outflank-mailman (input) for mailman id 237641;
 Fri, 03 Dec 2021 13:24:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8Xh-0008S3-74
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:24:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4674c357-543c-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 14:24:00 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-N_B56hExPYu48TU-SHSAPg-1; Fri, 03 Dec 2021 14:23:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3536.eurprd04.prod.outlook.com (2603:10a6:803:2::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 13:23:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:23:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0300.eurprd06.prod.outlook.com (2603:10a6:20b:45a::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 13:23:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4674c357-543c-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638537839;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=omDvQtMbf62t8NfugCyDhm6LIXr3IUu9OA3WrUT9o4U=;
	b=Z6XQPc28N+UB8WYem05siuZ3xX0xTk0p4hdhDaGbQG5zOM+Rp1M1h6XYqBwZWHKrarO8TN
	Dl1rQYv6f+fR8wFwmyObRPWnXBxzzRP7AQ1I/kxfTr8rU/GmU0xL1Flm18OFfrPl8FYusb
	3xvFY1DSdXLNqHskUmX91Vbcah3zN20=
X-MC-Unique: N_B56hExPYu48TU-SHSAPg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PZq8C14XO8eM2H6nJqWGIbHlm+46JJCSTz1Yh3IMU/pg34oqLF+gJAfrOtJSOp+sEvJmQvHHP4qmWEeM3E8K+aZGD3+yE6OSY1eR0HDRU/56slMMmZx4eevSNFEcIZ0cA1UfXJKkUjSuBcCs90gfbfGgfJyypC5lPZ7yPhPWViTfaD2Uh3OYNA4VqYFzJmdn1Sm5J6qgpAimFjJEOCMaWtjrOv7oYz0wCOlLIi5ngUb7bRyzM/OPMvHqSu2NOf0sEy0b7/W3CVgfNPMpoWfGyDuC6kTC/19SG3PoKPMRwsvhw03xZPHLviENrwe253NIsxhlHIts4ZrdSko+2q0rjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=omDvQtMbf62t8NfugCyDhm6LIXr3IUu9OA3WrUT9o4U=;
 b=U8fJshMIPMYzapMeRc6K3UM9JG3eDEonP8oTxWwSPksXlNaHfTpzDFzGOn7CC0DC2oQBp56uB4WrtwHBcSan+XdnGPGIwXWwM123IVGi1vzXASMQ2ldjABGMT8CRcIzLvhWIW8n2Yam/dUIi/8fw3GRtLKHv1F6es5CEgjNGC4m6TnBgClmjJ88ug/e5QIFozN3hVgd3XMWqGLR1aStzrmWcthEcoVbl87US1mCliNnNDHbNFo/+GyTBy3YovcYyocgI16N39+xmBpKflsgENjwp7//lGRhyy4mt1nXSPpPs5jNFXuUr+KwGCeoJtCl2aIW+3Yyi4orOuO785U5Ygg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c41e4bf9-e523-ec9b-aeb9-c91662685dc4@suse.com>
Date: Fri, 3 Dec 2021 14:23:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-63-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0300.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ce17f17-818c-40c2-9121-08d9b66028f0
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3536:
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3536A11FEA70008DBEDBC3ABB36A9@VI1PR0402MB3536.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ULhgh8l6lkoR/K4gu2ZOcwz5sVqPFkziZSeJ8Mje7sfJ4nKhCGCxVFRLt9f8D7tck4mi/ZfARuyPmj6Yw0POIL2LrHP4hOAuC2gY0QlOCOtJYG7QxtrpYNBbSTRHkIpbkpoylnUn/SjhyTLz7WZRr9GBphV6e7iRHqlwZEmXNAnaPgtjpPeP7MhOGpfmJ2Qq44kKJGDOqga+znpIL3oxhV4izbwWAcLvfQuPGR5xmrSFFUe5PqW5U6/W5XfrK/qsuofWzwuUxAjROiN3+Fq+uDgVSGoSIDXKiFRRZMK/3dAb14A3g5T3su8YbU7b6M/aJZ/AQqWE7LlN9182XfPtC79I2mcMFZJMm94+4N+99ojTV5KyQjvBG7x5fOQGW965ldPJQnk3nnnsZf87x1vl/UvnvBQ1xOZb3gZliwh+sPGHLitPx0sWUvRHdYawfkF+MEdC7J0ZV5b7+6jP04SXdL4MNJV7+BcySeDf03fUo6gs3YoNt6Pm7OlDI1gaZk84HZT39LqSQJ28/qXHmQXfbHOZOuygDP2A70gEqaB+p6N4XVyD1bVluhetiqCZNYSn/SMywXrej6/x7hatdmW1nbz3+S/beb17jooBfmU5+3hIo5Wgo5E2rsIdcL/AG0sYKhMh8fZiY8BGWIy8h4BdBpHcQCM1SRIR0DtGXz46crN61XddB1AakrN0JdXj3f1zh2495JvdLCKdw90Cjk1gk7cBrqgItPpkgwtv5HsWsDM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(2906002)(956004)(38100700002)(66556008)(66476007)(2616005)(53546011)(4326008)(8676002)(8936002)(6916009)(86362001)(186003)(54906003)(36756003)(5660300002)(31696002)(316002)(26005)(66946007)(6486002)(16576012)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3NFd0tOaU11ZG5YWVFvM1ZBa2tRTDN2cENTeEgxbXJlVHFyYmp1MW9JL1JT?=
 =?utf-8?B?WDFSbEN0allTMDB0OXh2emJsaDZXS0tQRjliaGhpNFYwcWduUklDNFRBSkRs?=
 =?utf-8?B?bnNHNkNicUl0bjdxRG1IZmhFdkVHenpBM1BibTRLcVc2cDEwaVdWZkVDRDhE?=
 =?utf-8?B?YUE0Y21MU3NzT1R3dHljZklGelI1VkZOeExzZDVQTStjOThBUEM4VG5Jcnlx?=
 =?utf-8?B?THdiV0wrYUN4dkFkdDV1WVQzL0ozRys3V3UxUGw5RE9BZGlFMWd2MXU1clF0?=
 =?utf-8?B?M1E0WGlCcnpCb3hGeEo3eHdTYkpSOUZwNzl6NHBySnpjWVB5bDJ0YWJpZ0Ju?=
 =?utf-8?B?S0kwaFoyVlVrVHlqZ0dORTRuMU05TjI0VUZ4a3NuaDN5VjIxeG1CS1lNNCtM?=
 =?utf-8?B?MXlmNkJ6OWZTM294c1Y5eXVwS21aQUE4WmFBU2lIMU1hVzVqVjdGTlNQQzJo?=
 =?utf-8?B?bTBhYlFpS2M1ejhnYkZPcFoxZitKc3JjZmhFa0Fmc2hUZ2tXSkEvbkxBaFBa?=
 =?utf-8?B?UzZNbndkd3FNSHptOG8yM2dFQWxFZkg0UGVrbWtVemNma3NzcXZHd1F4RmNP?=
 =?utf-8?B?cTdQeUNoaEhoZ25aOUNhWi8wQmJ2MjJ3Y09wWWhueC93TTlGSHJ3NlFJaWJJ?=
 =?utf-8?B?TU5uVnh0bVF0bVZDd0lMZ0owdnNVMnpNeUh0Z2N0Tk5jMVRiUDhGaklnTDYz?=
 =?utf-8?B?QWR0YVBLNVZFL1Rydis3K28wajVmcXZ3V1BGdCt0ZmQyWHZyTHpjVjkxWklx?=
 =?utf-8?B?Z0Y1S2dkVUp0dWlBM1UyZmdoMmV0R1FlZjhOV0NvbVBvLy9UTW9HS0Z3dlgw?=
 =?utf-8?B?Rkpja2IrM3F6Q0RXZ3V5UXlKdlFiZXVZUi9sQWZ5ZFgrYlNJb2pzUUVQK2hr?=
 =?utf-8?B?OGNzMW4xdkFxckMwSU0wSkh1U2hUZ0wzYTdNRXlIaFdEanJIR0M4bXc2RE9s?=
 =?utf-8?B?cjlBdlY1bWdicFZWcmdvNU5QK29iYVRHdEowVHhWdXZqaGZjeUV4MXdseE5l?=
 =?utf-8?B?VkdvSTdiK2FOWVp0YVNNQzU2V3FUVDlhNzVxLytGcDh4L1RjaFBNaW5xTVNv?=
 =?utf-8?B?cSs1YTdFS0hQVEUyTG9Xcm42dnZ2Vm9wclA0VmNMampiRWM2azhpMzF2VzNB?=
 =?utf-8?B?NGlld0ZmYm50djZBQ2xpNStSbU5zWUVBMklubGdjeUZ5UzFVVXNsUjFudERz?=
 =?utf-8?B?WEVPYnRpWWJPeksxZ1Bkb054bVNTdi9lS0tPRDdRQlhOTjcwQ1dOaE1wdkE1?=
 =?utf-8?B?NzMwY21XbjFXZEJodWJnQTl5RDA5UXprQjJaclk0U1ZtYUdlRmREUWJwa0Iz?=
 =?utf-8?B?TWROWVJLU0Rqdlo4d1J0OXpWVzhEWGNVRG5sUHlsd1JsT3pIc0c5ODc3VVNp?=
 =?utf-8?B?R3VaKzVOaWFmUkg5WjJWSFhGVHFydXdKNmlUVzROQXRxa0RXbW1HeWVyajZK?=
 =?utf-8?B?aVZjMy9GOEppYzNJN2liRGt5U0NkSmswYUE0WUtQRzYvM1ZMblpOR3JsOVVY?=
 =?utf-8?B?NmE1S3ZrZDBaK3ZtQ2RLMUdIMGxNaGFkN0hVbW1VdHViWHptRU1tZ3FIQ2Ru?=
 =?utf-8?B?bytnWnB3OWlKaDl6T3ZTYUMvaERNY09oNXlISVpadEJZakRDclRpNmRDYUlB?=
 =?utf-8?B?Q2xFMW5qbHMzMnNDeXNBYzRIZkVhZlVPN20xZWh2R3laR0JNbDd2OUZZOHB0?=
 =?utf-8?B?a1dFdVhmR2R1QTVWSUNHVlBPU2Q3cG4rcVZJaVA0TXZJTUN2dzhseVJCb2Q5?=
 =?utf-8?B?TXlTZmk2RE1pUldseXlOL2F6MmN4YTZnWnBuY2tRM1lnZVMxSzUvU1M4OU9G?=
 =?utf-8?B?VUpkQXBoV0VuMEJ5UHhaenlYVnpYOTlsT2huQWV0Mnl0am9KVU04d0V2cjB6?=
 =?utf-8?B?cVBXeWVSb1ZFd01XY2NKeks3R3JIcjlYZnRnMm5ReUNiZDhQWDVIMjBjWUpK?=
 =?utf-8?B?SHl5eVJqdE82Mmh5OVN2R000OEZ5a3ZzcDUzT0lCeENuWFBFS1V6Z1pKOWp0?=
 =?utf-8?B?Q055ekZDMHVuUnFrWitBRFhrQXFlRHRCaWJsUHMvT3BPL09INUl4c2QvVVdC?=
 =?utf-8?B?SngxMlZLc0QvZEw1eG9MTTUvc0MwVThXWE50aGhKZFhmbXoyQVowWDRwN2Za?=
 =?utf-8?B?aWFjUyt4NmJOM3B0RldpNWIzNjZIMjZvbHZEcXJZRzUwRE5pRkpmRU16UW9O?=
 =?utf-8?Q?x8T+O/jI++rQyd03sy/DMjs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce17f17-818c-40c2-9121-08d9b66028f0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:23:57.1464
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X7CzG4DoRinnX0jsI1ULMN7WXkzxPudp1/YMnLuBFyVFvcGyUTYokGvyVS+v7GLZK3mzIdkJ355HuJHvlC9XrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3536

On 26.11.2021 13:34, Andrew Cooper wrote:
> Each IDT vector needs to land on an endbr64 instruction.  This is especially
> important for the #CP handler, which will escalate to #DF if the endbr64 is
> missing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

One remark though:

> @@ -1136,7 +1158,8 @@ autogen_stubs: /* Automatically generated stubs. */
>  #endif
>  
>          ALIGN
> -1:      pushq $0
> +1:      ENDBR64
> +        pushq $0
>          movb  $vec,4(%rsp)
>          jmp   common_interrupt
>  
> @@ -1146,7 +1169,8 @@ autogen_stubs: /* Automatically generated stubs. */
>          .elseif vec == X86_EXC_CSO || vec == X86_EXC_SPV || \
>                  vec == X86_EXC_VE  || (vec > X86_EXC_CP && vec < TRAP_nr)
>  
> -1:      test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
> +1:      ENDBR64
> +        test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
>          jz    2f             /* size is 8 bytes.  Check whether the processor gave us an */
>          pushq $0             /* error code, and insert an empty one if not.              */
>  2:      movb  $vec,4(%rsp)

Like with initializers of compound objects vs trailing commas there, I
think it would help if we moved away from placing insns on the same
lines as labels. As can be seen here, inserting something always means
touching two lines instead of just adding one.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:33:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:33:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237646.412187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8gB-0001gi-V0; Fri, 03 Dec 2021 13:32:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237646.412187; Fri, 03 Dec 2021 13:32:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8gB-0001gb-Qa; Fri, 03 Dec 2021 13:32:47 +0000
Received: by outflank-mailman (input) for mailman id 237646;
 Fri, 03 Dec 2021 13:32:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8gA-0001gV-Ha
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:32:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7f9eb962-543d-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 14:32:45 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21--N13POSsMTaLjAY_p2puEQ-1; Fri, 03 Dec 2021 14:32:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 13:32:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:32:42 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0078.eurprd04.prod.outlook.com (2603:10a6:20b:313::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Fri, 3 Dec 2021 13:32:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f9eb962-543d-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638538365;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=zb7cm9reoOABpbeZcWOi636UrNj1FmHcrdrZtUHPBoU=;
	b=GseGT8KcP8QPuWZ7gNWROghKdMqiET6JJCIZDoUKXaeWdB3vhjyB+WVi7AAx97qwkcDBWq
	hlHdS0djhpk//25tk0wpQ8aeNwRKdPEglnPGBuiv3gNPyIdm1g6y10VtzQuC0SR1aBOE6Y
	OTai3Xn0iOsJSJjmbSy/2H/Qy/weqYI=
X-MC-Unique: -N13POSsMTaLjAY_p2puEQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I8UpvYNlwl08JamvKz/I6q0dcEHPmjCq8VXnrgWQVSq5Wm50h38ttgSfJFjJM/S5vj7Ef5Rq/ejH9Juw9JWynqXaqVc2HGx4rlWxjIVqWm5j4LFyS+grifsijG2XpuEIFj85eVBmy+giIFhB1VB6HSgk25I6xGRcGT1tdNz0r5YnIU7O8TB04w3pbTkTy3LWS9w/NBl9iq5KAlh4ManWQloa+FAfyJxu6KVxEUFyvnfghi1PlNnIO2c1NVh0RF2fRtSoMLMR3zVvjyDKo2Bo0J6sTfoAaRAsW3mrV85qap3JoMlkTPC6L9dKJdDvfNaFU80Rc9wsIW8LpwPzihZyEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zb7cm9reoOABpbeZcWOi636UrNj1FmHcrdrZtUHPBoU=;
 b=efdUoGqPhwdHi9gH8xq6xprEcSu8LK98cDEZ5zSaaNSUttjm4lRoeZX4nDlkuphBWp9WjMtrCG/oOD4kbsB7FU1AOQTnmYbjFxFX51cuJtv2kIEBoneUGbnn7t+CK+WRj4N07OfINPjfODhcK08FwTn2YKakc6fwu4RSVkc+Ifi9Q4T6hZWkuYyGaoy+BC//ZcvWv5nHDDaNKCqvY10KUpskjbDjWagf98ymvOow0XKKEVoMPEnBNwJ4CHZs5O04Y2LfCAeMjvaepJE+FMR9zJoE7K11K7GnD3N0QYaF+emztBS4bqXDBfDTzFtxRqFIOKolvaIpwASDcJXmNdyQpA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
Date: Fri, 3 Dec 2021 14:32:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-63-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0078.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a0331c4-bc73-4245-ea90-08d9b6616234
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5165A87AFE77F83A50DC1D67B36A9@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0Cdfd1IjHibNbTjEy+jzPX7VsOY2aNmlom5oJZCRx5HHjU+qxk8iQAP9J6CmEc86LmEL3KPhQ06LZch6habLRp8ov2BLdfooGPCP4yDmGxVcshoYRgcLwbrFpBKLHH+QGWvN3JKry6a7JTbu42sKYZ6OP0kk0AEyfSjBvr+H7dKI0b7F+lxijUva5Soldwc2eOou/b58CdkJgdsYSuKuJl0h46c6PvW2ZIdBv/9KYeg9KnsCBId8s+UqbaVrFBM/tYDo0ssnKyj3/kARGWTHeHu11gIIEwIl1kPrtDqGlU79QL7D8fCQMkeqkwT60Ki2PwB9clPNTcqEnnx7MGS1u9q+xpb+j/NXEjSsZMzLXrvqIKnnF+Lp1TTDU3NQG+wQ/jTiALE6D2BmmpKryXN1VbACn8YfdWt4TBnqzPVmQ7IzeDkBaHc/fPKMa/mlsJFqGf7VWSg4w4Qs+740YVBN1rwAcnnQIXC8js694uQtHwlpi35nIrFqmUS8/9EfFipqUnkBBHPCfIsB21NkmBjBoG6Miym7BErli6MuSWSr0KRWQqi1f6sFidewrSo3ruqskahH53MBmWp/+nBaeJMLayjb62cxTeCMm+rS8gUrjz6SgrTTupJuM4Mk4YBBh5LyyeDHB0oVwcOnYGUbhoL7Bssrwd9cfd+d0h9VQhzCVk6sINpW3divbw3ctWUQIUMwu/S8d6XJJgo5pzwyHe5qPoBx7lr80PfZ4Ltc0/TVqxY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(54906003)(186003)(4326008)(6916009)(8936002)(2906002)(26005)(16576012)(86362001)(8676002)(5660300002)(6666004)(508600001)(53546011)(38100700002)(316002)(66476007)(956004)(31686004)(2616005)(66556008)(4744005)(36756003)(31696002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S3dyVHhzSjk2dkpLOUxEVW00ZWI0b0Vyb2VnV1ZPdTF5ZnBjL1BJMTF3ekt2?=
 =?utf-8?B?ZlkvSU1Ea21aTC91MDg2aUxPcWpzOUo3bUZIRVNDdTd2R01MbmhWYnN2MzRv?=
 =?utf-8?B?aTF4ck5GTitid0FYcVBTRTJnSFFtWGpxYkNzYmc1eGx5N2E0a01oaU9FSWQ1?=
 =?utf-8?B?NkVhTnlMUGZOWlJkR1hBNXdQTCtNWm5wWWc4Q2FNdXZMR0ptemNtOUdDQW9L?=
 =?utf-8?B?MnlRdVVsUzRybmpSR0tsc3FwbTQ0aEQwM3ZaeUNtOWY3TSsweVFFbE1KNkE2?=
 =?utf-8?B?ZXF2dm9RY2l4VERzOGo1K3ord3J3TTFIdXVwbkh1dzh4S3l1cXlXbmdYVlZI?=
 =?utf-8?B?eW5MNlowRW45K0lESjBoZXdJOFU4NlNGUzZpSHpyNFhnQWZ0ZVRQR2NOTHV1?=
 =?utf-8?B?a0Y2alpqL1NuNXdXLzk3NVlBcG5CTlRwaUNmVFJuSmVMMmtVdVo3MHM3bjZz?=
 =?utf-8?B?L2xtTGhnaUVybG5wYzd2TXNsbnJBUzVNWDhIM1BWdi83MnFxTEVtc1M2aUli?=
 =?utf-8?B?ekIyZndFN2ZQUXBMTGYyNEpMQ3RNOXU2VGM4eko0VFZ5QVlkODFmRjNhY08y?=
 =?utf-8?B?NnlObUNyVjZHMjdiQ282TDFGNEdJdXpnS0VIei93cmRacFN0R09ZaWRMVWh6?=
 =?utf-8?B?cTZjRzgwUWRyZmxYeVhJVjlqNUpWSUFHTWdjUERpcjZEV0RhM1VVS3JvMEF0?=
 =?utf-8?B?a0JSSFFFK3VtRW41YUtPa0hDbEZraXJBWkxINjNKYWtLdWxJMGdGZ3RRWHl2?=
 =?utf-8?B?T1FBTkRlQUZwdVFMVXJqbTdJQXZlcU53VVNjd1YyYU8xT01PVnRUTE1hSzR2?=
 =?utf-8?B?N3NmNGE5YXY4REZNRUk4VjcrYWhzOTJYVURhOUEzaVQrLzJtcmVyZ1FMZ3N4?=
 =?utf-8?B?eFZuOWNucFNvamx1MktCeDJVM0dGdXpCeitqMVhWaXlzOGJPRjhqWXBRVG9u?=
 =?utf-8?B?SDF3Ni9wRGxIcU5XeTJjc0tyWUNjQnFIempwTWxNcGJKSytBOXlIWUtwck5t?=
 =?utf-8?B?WXUxMGQ0SXJqeG44YjBiU2E1d204bkdLMmpGc2IxRkJYVVJCZU5pTUdMWUZT?=
 =?utf-8?B?U0l6ZldyQjlnbUlLVHlYRHc5K1kyNjBYWEJ2Y2N2eFRRbFlzdE9QNEZJUU9Y?=
 =?utf-8?B?V005d2RrQTR2WjJjbkI5Y01pNkh3SmhJeENvWGxKdGtsamVDcUNaQXlOWkt3?=
 =?utf-8?B?Y3VQMW40RFdNVld4ZEYwRTBUbzVNV3grTHRXa3YwK2VDODhsMzkvQjIxTzdU?=
 =?utf-8?B?VmZlMUpiYk9mOWp6VDU4K3J0MG5rVnZHQlJOa2JBSTVJMEhDMGk3dXdnLytV?=
 =?utf-8?B?eGpEZHB4REVPcVgrS2VBVXhzM3hTM2tjeWQxa2xuSXB3Tmg4MFhqM2RZYWVz?=
 =?utf-8?B?Rm10T05qRjFXR05zc3ZURFBqMGFKcHB4UVhDSWhZL3p1a3hlczBON2J5Zi9h?=
 =?utf-8?B?M0NrYXVHQ2FLYktlOTJMY1JpaldJTnlNV2diU282bDE3WFFIL0RkNjl3SW9K?=
 =?utf-8?B?eEUxbEMrM0NiajdOUUI0amVTSVp5SU54R3UzRXVOcDBGWStrUFE2V3RCNVFG?=
 =?utf-8?B?VlRXQk94SlcvYVJ0d3BHWWh3S2RGMVhrWmh6RnVnNzVtb0NYUXNnYkNERTRk?=
 =?utf-8?B?L3c0bjlaUjZXMElrREpzUUNUVUloaTZXbUpodWJPSytxRU4rd3YyT1ZPY0k4?=
 =?utf-8?B?ZVNHWEZ5NHFYQUZJUTNoQTBmbGJwS1BZbDJHTWJpcE4xYXJSZTQ0SzJnbnkx?=
 =?utf-8?B?ZkJxejJiTmh6azcrL2lxeTdoTVR0THBaQmpNYjBCc1d5aWtZays0cG1rbVdY?=
 =?utf-8?B?azRmR3ZKV1JVdHFvb1FSc3cvS1VaVlczbzgrRUx6aTJxVEJldngzeUtXR1hI?=
 =?utf-8?B?YTVvb3ArOUhsb00rZUZvT3JRb29DZlo1OXdqTFB0ekxpV1pPV0Y2V3QzYVdy?=
 =?utf-8?B?OWJyUTMyNHVzdXFCeHhkK0ZkelJiTEZVaGhVNVlhTWhlWkJjS0lPUU9uWFB2?=
 =?utf-8?B?RFY3RHlGeCt1dUlkUDVuZW55ZUJsYlFkSE42SXJLdDQ4NFp1MVZFRFpHeHh0?=
 =?utf-8?B?QmhsSjdhZFFpbTRRekk3Mk51TitMdkE1bkpQVmFTL0lLa0pCMTFrTkY5N0hI?=
 =?utf-8?B?VWRwTzhnaEpXZFFxdHJZbnVwZ1ZtZnlER0tVU1RlRFd5dlA5QkxHTE1zaDRI?=
 =?utf-8?Q?kUTQVfuwkA04LOjUWZi7yX8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a0331c4-bc73-4245-ea90-08d9b6616234
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:32:42.8112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WKmH3YSDOax2B57YhufyeM48zsAEi7U492fFWQuEwBSt2L5bbUt4zJQh6GujNBsEuZvXnvC53xNBOLH/8oBhAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 26.11.2021 13:34, Andrew Cooper wrote:
> Each IDT vector needs to land on an endbr64 instruction.  This is especially
> important for the #CP handler, which will escalate to #DF if the endbr64 is
> missing.

One question here: How does this work? I don't recall there being any "CET
shadow" along the lines of "STI shadow" and "SS shadow", yet there's
clearly an insn boundary here that gets "skipped" if the 2nd #CP gets
converted to #DF. And fetching of the first handler insn also isn't part
of exception delivery (and could cause other exceptions first, like #PF).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:34:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:34:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237652.412198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8hs-0002LG-CS; Fri, 03 Dec 2021 13:34:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237652.412198; Fri, 03 Dec 2021 13:34:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8hs-0002L9-9M; Fri, 03 Dec 2021 13:34:32 +0000
Received: by outflank-mailman (input) for mailman id 237652;
 Fri, 03 Dec 2021 13:34:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt8hr-0002Kv-2M
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:34:31 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bd1fd776-543d-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 14:34:29 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:50974)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt8hj-000WBP-hE (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 13:34:23 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2446D1FC8B;
 Fri,  3 Dec 2021 13:34:23 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd1fd776-543d-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <115c178b-f0a7-cf6e-3e33-e6aa49b17baf@srcf.net>
Date: Fri, 3 Dec 2021 13:34:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: xen-devel <xen-devel@lists.xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: xen: linker symbol mess, and freeing errors
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello,

Following the __ro_after_init work, I tried to complete a few pieces of
cleanup that I'd accrued, and everything has unravelled.

On x86, the __2M_* symbols haven't really been 2M aligned since their
introduction, and the utter mess that was _stext starting at 1M has long
since been cleared up.  Dropping the 2M prefix reveals that we have both
__init_{start,begin} and identifying that lead to discovering that

    /* Destroy Xen's mappings, and reuse the pages. */
    if ( using_2M_mapping() )
    {
        start = (unsigned long)&__2M_init_start,
        end   = (unsigned long)&__2M_init_end;
    }
    else
    {
        start = (unsigned long)&__init_begin;
        end   = (unsigned long)&__init_end;
    }

is a tautology that nothing is capable of optimising.

So I set about trying to simply both x86 and ARM down to a single sets
of bounding variables, with a requirement that these would be expected
to be common across all architectures.

I'm intending to use __$FOO_{start,end} because we're semi-consistent on
this already, and get rid of the ones such as _{s,e}$FOO because they're
unnecessarily obscure, and complicated to read for a compound foo.

At this point (as I haven't really started yet), I could be persuaded on
a different naming scheme if anyone has any strong views.


But that's only the start of the fun.  The is_kernel() predicate is
broken (or at least problematic) because it covers the init section. 
Reviewing its usage shows that ARM is broken when trying to handle
BUG/ASSERT in livepatches, because they don't check is_patch() on the
message target.  But for both x86 and ARM, this should be restricted to
(a new) is_active_rodata() predicate.

The x86 xen_region[] bss logic is broken, because of ebmalloc.  Its dumb
to have the ebmalloc region anywhere but at the end of bss (at least we
could avoid punching a hole in the middle of the BSS, and avoid needing
an extra region for tboot/etc), but honestly, 1M is excessive for what
it contains, and 8k is probably plenty (so call it 32/64k for headroom),
and we'll be in a far better position not freeing it at all.  Saving a
few kb of memory is absolutely not worth the breakages it introduces. 
In particular...

is_xen_fixed_mfn() is broken for it's main caller, because it includes
MFNs which are not Xen's, and the offline page logic will take the wrong
action.

The helper is also unnecessarily complicated, and unnecessarily
different between x86 and ARM.  ARM has paddr_t phys_offset, while x86
has xen_phys_start  (ARM even extern's it, looking like copy&paste from
x86), both of which relate to XEN_VIRT_START.

Details like this really need to be common, as they're invariant of
architecture.  Furthermore, making it common allows us to consolidate
helpers such as is_xen_fixed_mfn() in common logic too, which
substantially reduces the complexity for common code trying to figure
out whether predicates with the same name are the same in each arch
(because some are not).

Therefore, I'm going to make it common, along with a very clear
description of what it is and how to use it.

On x86, we further have a mess between XEN_VIRT_START and
__XEN_VIRT_START, along with XEN_IMG_OFFSET.  Now that head.S was
rewritten to be position independent for MB2, this is easy to resolve,
and doing so will massively simplify the linker file, and the setup logic.

On ARM, the embedded dtb support wants a rethink, because it was placed
after BSS, rendering any space-saving null and void in the compiled (and
loaded) image.  There is also nothing which checks the BSS is correctly
aligned for the zeroing loops (which I do have fix for).


I'm fairly sure I've forgotten some things, but lets start with these
for now.  I really am quite alarmed at the mess and errors we've got
with freeing various pieces of the compiled image.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:40:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:40:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237658.412209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8n4-0003FB-1Q; Fri, 03 Dec 2021 13:39:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237658.412209; Fri, 03 Dec 2021 13:39:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8n3-0003F4-UP; Fri, 03 Dec 2021 13:39:53 +0000
Received: by outflank-mailman (input) for mailman id 237658;
 Fri, 03 Dec 2021 13:39:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8n3-0003Ex-Bq
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:39:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e21b14c-543e-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 14:39:52 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-zOuDlrK3MSigQKX8YLvphg-1; Fri, 03 Dec 2021 14:39:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 13:39:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:39:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0056.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 13:39:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e21b14c-543e-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638538792;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hlb2C9KX4/QLshera0eJldEU/BNffZR+O7olz5J/0EE=;
	b=ZsU8a/4EpOMHFGSYEgWJYnus9LlTKqEB/b6Eod7049jMv7RO3jOZiBqVbS+SMwzIzufH2A
	pK7OiTbXhoEVdNvbgW6a35PJoKxj30p53STc0ELdEIfL04QEIlDxHWb86YcCAHZq4QTLrz
	M+2Vik5pTsi1YcA7kS2XVpUQssPAgX0=
X-MC-Unique: zOuDlrK3MSigQKX8YLvphg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iseIm7/ybvP/4QRtccxY0XQ7iselk8p75xPB+YmhGQrbPYkhWlHCnKu1u8RZDhtkDIZg9jQrHKpx1llRqX6xBlpu/JDGaofdMHkGClOk4OIzNiK+VL5KsHE0yCZZU0egTOTPx1VppJo2xjmFEZUZtlI8CohImMLP3PNPyITuU2rZ678OQ5IPpiEvmKj4FzLQQ0JJ3DT6PnTyimNUvqN37Q81+bcr3ZXhL622JocSV4DnnU4Jt2CNGhGovjV9e1Khwjh+LjHafAFKH5ynaqUO5YlOBRd9UyGiUb72h7LJ651ovzH55Urwk6Xhv0cn+k+PMoZKEfJkG+tfTPVJDuYWpw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hlb2C9KX4/QLshera0eJldEU/BNffZR+O7olz5J/0EE=;
 b=gTSYotlCeXNW1rYJLI3gO6jXzn5fnbIp/tA1cIn3JeU6KBptuWZavixTp26ZqowuTZuuhSbMjAJoyixvLLaV+3k8IsRpBDgsp2AbALcvURkH3yvXMStQMFZvQlDbpeNpADQpq7FCauHzNY7k2tBtlqpoafwTOkddStJS1YrvCyuAjiME8cH6ljZ7kRaA3pxm7he6yaUDQhDvAWFjGzoDF1vHDqIfVz96JKSB2Mj95s5Z9B1agrGbLFu+vQOeP5O5ljlzlJ3yGvX+OYp+ncnGk2NSE0of7QTv0D/ja9DHS41quEOXTp9pJslzg1fXFX45mHPdoD+aMUD+s1ZT64pmrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <789422cb-e800-9a46-b70b-b6e882ae2cbf@suse.com>
Date: Fri, 3 Dec 2021 14:39:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v1.1 60/65] x86/emul: Update emulation stubs to be CET-IBT
 compatible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163714.28870-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126163714.28870-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0056.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5acf3c6c-98bd-44a0-93c6-08d9b662602b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5325:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB532512E5A91FDBE5D3A98EA1B36A9@VI1PR04MB5325.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0VgGXVfbU24CNpXKy+O52qZl2Ku2FOUwc+9KGSUeEhuEn7kpfcRsjhXRYE//R8GmE6z9pKA4INTB9JOlFA8fZA2nMUTghtP9eczHzYdTGC4sU7ohpiQHjA5gKloxPRifcCEP4kNfpq6PJcx9q9Bgs7lTd0K8/+OVhBR+sGD7W67V8LL/53cuFOmXoXEsXljYEHd2GvKOFYMrmUV3hZpdPLzLlKe89Xv8fditJXCpZtAHgKTR2oJFQyipjzscK0j4lT8JP6skGUKL8jJPQVsIAXL4eERWM8myXLKYL8MFSTciD9+1nqe3dBa9yFFi52gj2OZdhGGcT/AbPbDrWqd1IdrrawRVaorlKh6L1jgJGWDtIAbnhL+dXFDayJfzSpppjD6o8ZsssMH+i0Eslx+fhw2khDXk55aXsWEtvCtYFbrdE8AxOeITvDaaAh8QgdJ1hMKJ6sx5N/sDZYmCsLA684hJvwVm0b+HXdryXUrRGbSrLzT+h20f9kICgLkAtDfcL/IpH/XH6svIvUc+w9vHcw3vSia1vkxS1s1jKm3Su7TiUTMe2+/K0WPk/fci3MRf1gJORUr74zVFGeqfmp9v4Fn5GWmYKA2z3zFa/R1oEhN3zJ+eCCEzYyUu7ZIlPGb78Cr0ebnBxW2GDiEwwjFgOHApRwVbevVv2qjyoAplxIrTRK50GgweXLwl070B9WND1VGhlUVxmxyU8bhjgcPHmAgdpyiHmT1QpAO0YrGmuck=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(66556008)(2616005)(54906003)(956004)(8936002)(4326008)(38100700002)(316002)(2906002)(36756003)(16576012)(8676002)(86362001)(6916009)(31686004)(53546011)(508600001)(31696002)(26005)(6486002)(186003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHB4UE5lY1kvaHNuWUV5RDRnY3VWakRjS3k1aitqY2d4U3pEOUlCWTY5dC91?=
 =?utf-8?B?WXdJZ2hYTlNJTzdaVlV6MW04TDZFUVR3YWQ2Z2pzZ1kwU0ZYSmVpWE9OeG9M?=
 =?utf-8?B?ajlCazZxeTNwOUovakNWR1FTellPcTFNTlRoNjZZbmdMWXNiK1hFYlV5U1Rk?=
 =?utf-8?B?czVoMnVkUnMyUG42V01XWXV4bFlLakxxckRtTG1rYVR4MFEvcU1WV01Bbnl3?=
 =?utf-8?B?WjI1UFYvemdOZGh5TjJtRlVXakZtaHgvSU5OUE9RT1VvRUxNOElpUzdSeTRv?=
 =?utf-8?B?M0p5cnF4enJvL3hsUnpFdnh2WGZ4M0xWSmNYMzhBNEg2NFNnR1k4ODRpUEFL?=
 =?utf-8?B?MXZwblB4MXhFLzFsMXpkRFF3M0xjTXQvSHhWcElSTjBsdnA5NUkzYnkwdmdZ?=
 =?utf-8?B?WkF5dnRBQXZZYng1bUJ6eVppeGxQNjdMdVRpcDV2SVRianZhSHNCWHM5K1Ur?=
 =?utf-8?B?OGswNmw1bW9DRFZDaDVlZkFyZmRoU0RVa0ZSMHdJTGN3MkhmVzhMekVsN3Zv?=
 =?utf-8?B?S2M1ZURZbThrU0NZWkgrR2tRZEZSWlhaZ2M0T250VDNlZXFOMEJ0cUlGanVY?=
 =?utf-8?B?S0Jld1RsZXM3aUV1UjFaUjJkODduZ0M1WnFwMFk5ampNeXV1dU1RV3V5Qitq?=
 =?utf-8?B?ZksrTVl5cUNrU2NJUStxMFVYNlpzYU0vNS9BSzEvT2pmT1E0THJTVHZqZTJM?=
 =?utf-8?B?TFVZRnBjUEVPdE1IL0JBcFAzcldZOE1BUlM2bzRqVmUzQTU4czI2bzVpb0oz?=
 =?utf-8?B?MjNHbEgzMlkxbXNVTy94RFhwSGdvU0tQandBUFVva1huWEdvaWVhMGI1Nlg4?=
 =?utf-8?B?cWk5SzdZQUU1aHgrOWRaeGY1eHlpVXRmTDBjRVFBdThPQjNPQnpTTjV0d1Zh?=
 =?utf-8?B?WlZEd2w2QnpRNlcyUG8vd1NGcndwY1liN3REc2J6L1FwR2RuQ243TkFoMkha?=
 =?utf-8?B?bTU5SzU0R29rQ2wwVWdzajQ3ZHBRSUFuSGg3bmphbEVUNWVlWmh2cFFBZ0VR?=
 =?utf-8?B?b0UvcG9iTmpTZXpRbVIzQUhuYm1nNFFSTzBlSlNSdHlxMFJhVFZwYjlQOXo1?=
 =?utf-8?B?M3Z1SGhYRVEyUEY4Z2N4RTBkOFozK2xrTmlDR3lKdS9FaFh2ek9wMTR4N2hm?=
 =?utf-8?B?L0l3QkF1WkdtYWZFdTNPL0hscHNXdGVSemJrd25LbXBNVXJsZDg1TkRsNUZX?=
 =?utf-8?B?K3dLMjZuenp4RUgwY08vdFJrM01kUVk4eDJKLzgwK29qOERzOWpNai84SC84?=
 =?utf-8?B?RnRHUHRyNVpkWjE3dEM5Q1IrOFFCNmdhMGdndXdETHJKRjVDNG5aZ0RBVzh4?=
 =?utf-8?B?QlBZYU4xVjVmMnU1bEtoQ3NTMnV2SUtCWXBUdjVsd3YyMlVWL0ZHWmNNS2Z1?=
 =?utf-8?B?U0diblJ5Z1pZRXN1dE5kWXNaVW96U2syUVY5dGFHZGZEcm9rUGQ2UFhBVUdL?=
 =?utf-8?B?MVZHWXl3aGoveTZmTEU0Z2MyaTJ1c09DZithWEFRQTM1bS93cTlGZk1USnFO?=
 =?utf-8?B?RFR5djlnK2VXTjNEN0wvV1JnZ1hpckNxeDNGS3JSMXlTUmFGVlpqN0lNelZX?=
 =?utf-8?B?SG5FdDNRbHBnNkViVFgvTjB3RU9GUGpmdGNneFV3NDVBeWc2TGpYem9OanRN?=
 =?utf-8?B?bWNtN2hkdUhTdkxKa3F3SklRdkhKb3NCMkR0VEFsY3hlTURCRERJSWx2Z1FB?=
 =?utf-8?B?YVg5UlhiSTdEajNkejNyK3d1a0tadzJuWEhyN2pSZkpIbnUyNTJoVGF4dC9h?=
 =?utf-8?B?VVlvNTV6ZG1oTmFjOGwxbHZNTWtybGVWNm1TbkxnVkphVXhuSWl2QVdYSGF5?=
 =?utf-8?B?WUxQbkcyNnRucHVySFNrNnAxa1d1L1lhd0xwUXlMZ0FiRDFFeUoxdFNwdWND?=
 =?utf-8?B?bC91ZHc1cVRyV1FUTjdaQjAvVG5ZOEVqc1VIQW1sU0JmL2VZYXF2dDNtbmUr?=
 =?utf-8?B?bHpSYjRrWnU3Y1ZPTUs5eXFVNG9JZFZNSElQa2JGM1BRcUt6VFpJN3lPMnQ2?=
 =?utf-8?B?VXJHM3Zvb1JaWlYzaWEraTlFbGFLVVh1azFwVGRnVzQ4Znh1R1VrbENYZmU5?=
 =?utf-8?B?bStRY1RueVhsMjllQWxlWE9rdndwZEZKRFNNeHpGcWdMY0hVK1VHeHBVdytJ?=
 =?utf-8?B?NE1GS3M1Z0ZaNHhOVFNlRk5jVTdQVC80ZG9zY1RVNkM3aXorL2t2TTZTcENO?=
 =?utf-8?Q?AvEnWF4cq3rVihfCs6DsTPg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5acf3c6c-98bd-44a0-93c6-08d9b662602b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:39:48.7623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rejO42idWTPpfCavVjUYNm2rbcsKLWpXDhCKcU2PgpHxU6tbLJPvHCcw3LYzHuVTw5mqKBP+e+NHyncloA/0MA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325

On 26.11.2021 17:37, Andrew Cooper wrote:
> --- a/xen/arch/x86/extable.c
> +++ b/xen/arch/x86/extable.c
> @@ -129,19 +129,23 @@ search_exception_table(const struct cpu_user_regs *regs)
>  static int __init cf_check stub_selftest(void)
>  {
>      static const struct {
> -        uint8_t opc[4];
> +        uint8_t opc[8];
>          uint64_t rax;
>          union stub_exception_token res;
>      } tests[] __initconst = {
> -        { .opc = { 0x0f, 0xb9, 0xc3, 0xc3 }, /* ud1 */
> +        { .opc = { 0xf3, 0x0f, 0x1e, 0xfa,   /* endbr64 */
> +                   0x0f, 0xb9, 0xc3, 0xc3 }, /* ud1 */
>            .res.fields.trapnr = TRAP_invalid_op },
> -        { .opc = { 0x90, 0x02, 0x00, 0xc3 }, /* nop; add (%rax),%al */
> +        { .opc = { 0xf3, 0x0f, 0x1e, 0xfa,   /* endbr64 */
> +                   0x90, 0x02, 0x00, 0xc3 }, /* nop; add (%rax),%al */
>            .rax = 0x0123456789abcdef,
>            .res.fields.trapnr = TRAP_gp_fault },
> -        { .opc = { 0x02, 0x04, 0x04, 0xc3 }, /* add (%rsp,%rax),%al */
> +        { .opc = { 0xf3, 0x0f, 0x1e, 0xfa,   /* endbr64 */
> +                   0x02, 0x04, 0x04, 0xc3 }, /* add (%rsp,%rax),%al */
>            .rax = 0xfedcba9876543210,
>            .res.fields.trapnr = TRAP_stack_error },
> -        { .opc = { 0xcc, 0xc3, 0xc3, 0xc3 }, /* int3 */
> +        { .opc = { 0xf3, 0x0f, 0x1e, 0xfa,   /* endbr64 */
> +                   0xcc, 0xc3, 0xc3, 0xc3 }, /* int3 */
>            .res.fields.trapnr = TRAP_int3 },
>      };

Instead of the recurring hex values followed by the /* endbr64 */ comment,
how about having a local #define for this? Preferably with such a change
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:49:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:49:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237668.412223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8vl-0004vf-V1; Fri, 03 Dec 2021 13:48:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237668.412223; Fri, 03 Dec 2021 13:48:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt8vl-0004vY-S1; Fri, 03 Dec 2021 13:48:53 +0000
Received: by outflank-mailman (input) for mailman id 237668;
 Fri, 03 Dec 2021 13:48:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt8vk-0004vS-Bh
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:48:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bf25517c-543f-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 14:48:51 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-YkTYVuZJMKedBGFy94d5XQ-1; Fri, 03 Dec 2021 14:48:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 13:48:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:48:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0252.eurprd06.prod.outlook.com (2603:10a6:20b:45f::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 13:48:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bf25517c-543f-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638539330;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=00IiUJ+qCnjd6G/lxZPyTmg1lhKbzuTbjO8qNUGdmNo=;
	b=fJVXPEWcKxY7Eay6xdN66vVaVmRMSb8RLRL6JpCqb9IPMqXDQvh2IGFuiphBMzvC+59Czm
	MN65jyPVFf+A5kzj7IixvXbxHVjAf/vKHdr4zC0To5eldfRyJVr+rST3xtlknC5kZuM8UI
	LXaBiw/cjUrVlNn79giUsupOpWDUF0w=
X-MC-Unique: YkTYVuZJMKedBGFy94d5XQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fLhQysXXbNa9WlEwrSS2qjP7SKaiRE1U8bZZtlb5XLM21Pv6VuNwOjELmJN+ln9EXgCCBbj9z0Hb6pgiHOMnd+JBny6gxuI5DkXCv6kjlGIGjVXaypdvJgfr4koj+2nfLW35rs/v+4LkbUat9CatTK7TuLX3nEmMm0iwcmMsy3dsJvPy5VM1hMDyxUckwUW9mbIWWW7m1dBfpFcQeTtIqflVaVJrfY1x83z5vI7Xy2dr06qP8/EI/DCd3VdyL5N2hoERQwF6PXngsoI12HXE3tVmBMgX3/8ORYxM67IZVykLdjY7gKLpTZDkBrJE/ju/sTQALwuNOzXpwANoC5m6XA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=00IiUJ+qCnjd6G/lxZPyTmg1lhKbzuTbjO8qNUGdmNo=;
 b=j1HvlFMOG6ik3GhCLQOzpwpvpTmL5iDvcM24GwY1sk9fiwADSiBmAAWv+LiBgO6xFIl79SvRV7sMepsxTLKcb5LbI61LifXpw6+LYrZon0Xwvxsh8l6tt5E152Y79M2zv65EHIN152vw4EpYUfED3rWhyCVepO9P4+rosaGwFUYFZrTt4RNGwhSSI96rmEfsfXensdQ4uUQKkCVcLxBLbCzoolXv9rsWJ8uFFEM4lT7EdxkyckrbjalczE5iERQV4v15tE1dH7BIrKqqGk/Wb9vb1hrTyjYjNR1dB2wczh1k19BFmDLy6Pp5wV/7957rMV2h/j639NBq6dt/r8lySQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8605b44d-17ed-84c3-aa98-87c789c623fd@suse.com>
Date: Fri, 3 Dec 2021 14:48:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v1.1 61/65] x86/entry: Make syscall/sysenter entrypoints
 CET-IBT compatible
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163747.29517-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126163747.29517-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0252.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b73fad69-b2f0-45c5-7213-08d9b663a1cc
X-MS-TrafficTypeDiagnostic: VI1PR04MB3119:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3119C68F52FF5C4A3F9FE2C2B36A9@VI1PR04MB3119.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tkBHnb0MeaKVw1FvXIw1Ebw67mmIrstnbFCIUPu7Op1ZqxtEsU/SQg0qf6xn6ybVgpZoN0Txhyzp7/S7TQe3d5gQFVdTfCoYaNG4WHKcbAfv3r6ZG8aseFeXdO9AfD4XpxLhuVD9yeov1aEf5UCG89UKJ+ZVOFTcCEEcfPqJw9Go1UeApbB6Z/ZPiXmLL0if3v4lftB33SjLhC7URYRDO7QzHsLegDiJ7pEUYvZ0ZNxjlwceQb0HqgZLBqSaaOhOAqxZWLJ3oXXd/QrJGsFJRqtbCrtzroT9ln7rb2Xz1yUoUm9zmHi4i0IK1TqpD+aBybyVZ6BUavWEQw0BNTUTXmbbj7jPjQPupHMHaysXVn9XWm8+TRajVn4XHI+Kqv4U2MIP0KcaSN/AtwTpAc3iLQ91M7ew+fnty39um7fo9mXp+PGtorEEvAo4FjpbUbbcKst4S/VW8dlz7I3yQZdWaYFlojR69PduSwZ6ndg/H/uN8A0jrlhrWU2BpMxbLXmQssBWwEkDrYfsaD7/xMuxcgOtwbs2EkC/YZROq8UR2CYL5bcOzK9Vpj5Mpsn9+C2JRSj2RqjdiXc7Q6h1zSkq8N8IfyKetgyJcvNzDdB4ZWcZ7Cf6p1qEjej1k2HUauH7ot7IYdRBz+xgXAagzNw+jfOB8tI/dtbANZNNmrvs3GXUIDsvdbkwfAHr0UNA4UrPNqsay6uUSmc0MWSKfem089IAxyUnh4w71OO3y12DljE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66556008)(36756003)(6666004)(6916009)(83380400001)(956004)(5660300002)(66476007)(8676002)(4326008)(2616005)(26005)(53546011)(186003)(508600001)(6486002)(31696002)(316002)(2906002)(31686004)(86362001)(8936002)(54906003)(16576012)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bDVLTzRKRjc0dGIyQjk5WXBDeHdhUVltRFVpZnN3V3p5ME1JNnJaSHdMTGJM?=
 =?utf-8?B?WkV1TkU5UE5SekJxcm5BZnRaUXVvYk1sRER4aWRrclVWbkJqbmIzNWxSQjZM?=
 =?utf-8?B?V0oyOGxoVGVkVThHMHVzaGlzUk45YytwSExJYS93UzNVSVByZnQ0a2dJK05V?=
 =?utf-8?B?VUFoQzVSUUhNK3oxbVFaRzhpZVNZUFprTEVScWd1amEvc0xrdWhXcVhsdVpC?=
 =?utf-8?B?ZHA1OHBZcjMya2pZckUzWTlqMTVtbk8zZGRaS2JhRllpbnpOSUlvSDdyeVpo?=
 =?utf-8?B?S2F3RC9VN2VNbjNJT0dkL2NCRTRJWXRJemZlM0M0OGgxcnBsbm43eWhWR25X?=
 =?utf-8?B?MWRqSVNnZG1vaWo3Q1dWRHpmLzJvQmpycTYvaE5xTHBuRk4yNk9LQ0tVdXNv?=
 =?utf-8?B?WUNBYXJwOThZczdzUUk2QVlHTm8xM1o3NlE4VS9Kd2JXZHZsbE1GRktXRklZ?=
 =?utf-8?B?RUVGQW94dW1WdFlZQ0pnZjAvdEFnd3BuNzlySGVENkJrSFErRWdFYUZvZ0k5?=
 =?utf-8?B?dUdaQVMzUEQrR0UwSytBYWtNY3hxUlRlZjNRQ0hRbHU4ZHNuOUxibGVVRi9u?=
 =?utf-8?B?S3RnN0NWZTFrSWU3UDY2cDU4WHhtT3F1Yjl4Q01laWpwSTk4SWd5NlpidnZG?=
 =?utf-8?B?NW9DYXdCbGxad3BkazBQenJab1JMYU10d25hT3d2eitPaFYwM2RXQzM1WUdU?=
 =?utf-8?B?bFREaUdVQStYd1I1eHlENy9ESGJUVGEzZENmSFIwTS9LbEtZV0NMWE96aUds?=
 =?utf-8?B?YUNuSDAvY1JDT2NCcE1neG5wNDU4QnIxTVV4RUNUZkJ1QW5tR2g1SFdFckhC?=
 =?utf-8?B?VUhNdDZOaDk2R0hNTlRiUU9Ua0l5NU5kMW45d2RBa2lTNEdnSnBHMS9NVGVi?=
 =?utf-8?B?UDJhbDl1UC9OWFdTZVAybWhFb2kyV1hvb0lYUkxFZ0xqaVJvMVlOSG5rZjlT?=
 =?utf-8?B?ZS9HbDFDbUR0eE1oUEl0ZkFrdTZ5L1loa2hTdTdQU1oxQStsSUwyaFhYRkZG?=
 =?utf-8?B?SFpzMUJzSFA4Z2lNV0I5WTVoR29jVHU3Ynh0UjkyaHd1c1BwaEpxYXdnZFJ4?=
 =?utf-8?B?QVAzZklGeG1Eb0dubVFmSXRGVE9oaEQ5bWh5a1hWbWR4bmZZV25PVGVvTGNP?=
 =?utf-8?B?NnBvQTVBS1R2R0ZIRXE5dVFFcDk5ZDdFSHZYWW5mNHdkazV6TkQ2L1lFcDdE?=
 =?utf-8?B?MTJkMlN1dnJLa2xITVRuTXdwTUJtM2cxbjY0elFoblJWcG1nN0NjNEhTUTFI?=
 =?utf-8?B?SHlxQmwvZ0tVd1hFYnhmZklIYm11U0pMMFFQaG5lSnRQWHFESUI2aEtBVi8x?=
 =?utf-8?B?bUZ2OSs1bjN6RENLVlptZXQ0bGxUdGlnM2d3ek1XMzI3YjlZbGlDc0RNaC81?=
 =?utf-8?B?UnJZNFZnR2c0dUNnREhyYlVDUU9YUjY4c0xnSWRzUndyTDlnZFNMK2dNaGM0?=
 =?utf-8?B?Q2xnL1k4RS9aWUpPRmJkUDByUXorZFdncVRLTUxaQjFCTW9FbmdOeXpJMjVX?=
 =?utf-8?B?TXYyQXpOTW10djAweEY4WlcvbC8xcnJMRXFOYnZCNERpcFhVMWQ2RlMreS91?=
 =?utf-8?B?TzlFaE4wdFQvcTBWV3dNVjZuMk1lUG1rZVFwZUxCOUhZTzVLekpkMVpEeVZl?=
 =?utf-8?B?M1NGbFdodkVidzc3a1VOc2Z0L3BncmxOVDV1SGRoL0ZzZFR6aUR3cjZMamZh?=
 =?utf-8?B?WUpMZHNuQkR5ZXNRMU1WUHhsZGpiY1h4alRJQ2UxYVp0QURVdDR6MjVHVkxq?=
 =?utf-8?B?TGFxVi8xd1pFSHJ4TWxVS2tnNXBkMyt0TDhQaUlRMHA1eC9hOVhLeksvdit6?=
 =?utf-8?B?cVNhTXpVK3VvZHBpTmpMMUZSUmwvY2IzTTlnZ1A5VUxFNFplZnNKNWVHT1BB?=
 =?utf-8?B?elh4Z3ZYcyt4dk1PeUpzUEduRTRleDhncHBKOGhVMm5yZko3SkEvUGsxN3Bh?=
 =?utf-8?B?Nkh5bFRURERINUFqQ21aa0c2aXM5a1c0QTRQb3BFSTBvNnRheU9MTXhING1h?=
 =?utf-8?B?SWJENHF2enRuZm1xdW13SmhCdXliTm82cHBXQ3NkQ2VZbHYwbWtIc0Q3V1R2?=
 =?utf-8?B?N1l6ck5CYkQ1M0RQR3EwUm5OVDFZMTY2ZmlvYVRzcWorY1F6Z0hwQmhKMjZU?=
 =?utf-8?B?L3dPS2JKdm96Zm9pc0NRUHFoU2NSYWhpU0ZSWDB4d1orV1h5TUJlZXd1bndo?=
 =?utf-8?Q?5wnOAsx+Bz+gBBQRJEf7lBY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b73fad69-b2f0-45c5-7213-08d9b663a1cc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:48:48.4082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jno6J1l7lrchwwnHLTCaoplcIYRjua89hAfMPqbWbgrn0piBLIBgRmt9t9ytgx2B3Iwig15YNYgcN264UvUKgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119

On 26.11.2021 17:37, Andrew Cooper wrote:
> Each of MSR_{L,C}STAR and MSR_SYSENTER_EIP need to land on an endbr64
> instruction.  For sysenter, this is easy.
> 
> Unfortunately for syscall, the stubs are already 29 byte long with a limit of
> 32.  endbr64 is 4 bytes.  Luckily, there is a 1 byte instruction which can
> move from the stubs into the main handlers.

Oh, you actually found a different solution to the space problem. I should
probably have looked here first, but this being a v1.1 it sits lower in my
mailbox ...

> Move the push %rax out of the stub and into {l,c}star_entry(), allowing room
> for the endbr64 instruction when appropriate.  Update the comment describing
> the entry state.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> @@ -295,6 +296,12 @@ static unsigned int write_stub_trampoline(
>  {
>      unsigned char *p = stub;
>  
> +    if ( cpu_has_xen_ibt )
> +    {
> +        place_endbr64(p);
> +        p += 4;
> +    }
> +
>      /* Store guest %rax into %ss slot */
>      /* movabsq %rax, stack_bottom - 8 */
>      *p++ = 0x48;
> @@ -315,10 +322,6 @@ static unsigned int write_stub_trampoline(
>      *(uint64_t *)p = stack_bottom - 8;
>      p += 8;
>  
> -    /* Store guest %rsp into %rsp slot */
> -    /* pushq %rax */
> -    *p++ = 0x50;
> -
>      /* jmp target_va */
>      *p++ = 0xe9;
>      *(int32_t *)p = target_va - (stub_va + (p - stub) + 4);

With this it's even less clear to me why you did remove the 16-byte
alignment in the other patch. Initially I expected you would extend
the "first half" of stub space by 2 bytes.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:59:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:59:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237680.412237 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt964-0006fb-3E; Fri, 03 Dec 2021 13:59:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237680.412237; Fri, 03 Dec 2021 13:59:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt964-0006fU-02; Fri, 03 Dec 2021 13:59:32 +0000
Received: by outflank-mailman (input) for mailman id 237680;
 Fri, 03 Dec 2021 13:59:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt962-0006fO-FR
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:59:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b516649-5441-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 14:59:29 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-L5m3LtYuM621NnMlGE6bOw-1; Fri, 03 Dec 2021 14:59:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5902.eurprd04.prod.outlook.com (2603:10a6:803:ed::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 13:59:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 13:59:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 13:59:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b516649-5441-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638539968;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PDg05RpEF1bPYLL6/rK0bqFh/BJbTp9zWAak54uQXhU=;
	b=YwiyCXAet5LmM29Vr4YCAy7srOtlq2A49rCLhu0P4OxMIdULHU52oZuC+DMt04doJdirj/
	+Jlwg3ycwR8zmgpqQV0as7/3vSNbGQauIrs0sOTTFTXrXZHlwsNR7r8E8T2q6Br1ZlKrk9
	Qv69VPhCthDmDPwU9zImgD5mFAvXGhU=
X-MC-Unique: L5m3LtYuM621NnMlGE6bOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DWlsuNde5RZB9XYD3UDqCYl/PwM/yZGN6FFJsPYQPfSL7in9gbl79cLKQo+Uj1qyyoVRbagv8U4tch0ecLIu4Bw7DxbZZFirrhZP2NK5TLosQ4Km3SHcaVR2JLvhr2trFP1SvDDozQOw6YVpM/5vJ6JOvApy+bFi+2olhAsGdUu5Sw63FfqPNACZ8g5+yYvO0KNCtJ5kyeFUI2+uHSXKIRZN665u5du0rNTDjYkUeHQtV+C46EM85rgJr5ED4u5io0rTqH7A/QKWyDqirnQrpQQB6tzh34nOMOmxedPq0NFXqg2aNgzyRuSJlHG+llwYlafS1P6QrcOLs2a/Q94sUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PDg05RpEF1bPYLL6/rK0bqFh/BJbTp9zWAak54uQXhU=;
 b=Ml69u60zydKZlquVKrcRMtWoe83wOMl9K2e3BVisyC8fvl8kwyQNc+NvWhrdS8eqZZQ1KfJxltipx+cDmjUrOZRUMBtFwh22Vk613fKCMd71py3oOKsS5HSsSoK4qmuHgfHF9PtffQhrHTLUYEcWJD4Xb8aWqT3knKKBZIs3X88qMWmSJFVd65N4EdaBBfZLAzeszNNKCNNCZXqUcfRcdBB2i1igBmwcbmZU40aM4TrGUyATXOzR/f5HiPujZFM+CxsHKSsBZ28N5q4owL0+w0eWu//jaNK9Q+VSiiPPOKWOM1tzwiTGTlN906AgmlIV4wipNA7rDoaoOBgX6w+yhg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e5da1903-20bc-4523-9d0a-6071f117c3ce@suse.com>
Date: Fri, 3 Dec 2021 14:59:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 59.5/65] x86: Introduce helpers/checks for endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163340.26714-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126163340.26714-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0010.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b3b6a7db-f24a-42ca-7140-08d9b6651e18
X-MS-TrafficTypeDiagnostic: VI1PR04MB5902:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59022C71097473FE8E547EE8B36A9@VI1PR04MB5902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bWxRATvo0ahK6unZeIolAQyVQ25CuAb8gUNvPwmgqWcv3EIJXdV99o7yO+c1o6DxbOagDXiVe0kMZ8ksNq7Z4Dw53WTXWjWJJiETj0tvRjqt2+ZAFRGoaBNFRCIibmR4OYLy0VZe4n+BUNhlWVf3Eg+jScDmnaGuV7RXh0tfmtKMlmX+6BxrSltHafLVNJPiU1kBjFM6GCqhLDGO1faiNzedZ6GsCelxTf0Zgh9tNFsdhkxw7n75/2ZOBPGnMCfefP0KCUC9Tj6joEtmjmJDxfDiNYR0yBOoXhCBdBFZkmV+438osN8np+csDmogNji4f0mK3jefVHKA+KNAbOXDqkoNLEVlqWR1fgzTwtE5p2t+r57EW7u2HysNHdiWU8dwCZNzU6tvzxw1P0XLK3aU5gb76pb6TQqhNDQrCSbOwKg8Rl/8nlNQbqBKzIE4zItAzw+e6RhYcJnHf6Jv8JW0lbUivakb2wvKGRiBpp4ByDVrxnH2P3p9G6gcVwn0ZTI3gJgnLICJNASlJNZmbPtRjlh9SG6+8DST5wMlAG/csu6Rol0U4FuPu2D4CAaR9Mbf9f7I4qdXvcvQ68O1MLFC19fRNLZ6sSxvceBh2ScICENzBmqDP92xlA6RrXlb8ebGB8F0ky9+N6r5TeBmUHUB+GGFCoZ26gtf3OAQnzBbTDkvMDJ4w+RMYEcY6FU/WToVEnobLmtSIryE0kwkEtmu9YSe+hFkdC248TCwyWqz1yhR+IJTt2A32n4mL9Id2up1Q5u+6GFPOBKFQ/08tPYTr4nRfjmYqIkAcWNeznX+mmMe/9wpypP4YW12t4hzXFCEj+nPB92eqZvjXva1lLQMLA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(36756003)(66556008)(316002)(31696002)(31686004)(54906003)(16576012)(2906002)(86362001)(6486002)(26005)(53546011)(38100700002)(186003)(4326008)(6916009)(8936002)(8676002)(66476007)(5660300002)(956004)(2616005)(66946007)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?amx5Z252T3dLQ1U4eG9kUVlwTFUxNnF5Wk5vcXZLZEtRUkRadXorTWxaaC9T?=
 =?utf-8?B?UmFOSGpxUGNYV2JyUHRvSkR2UCtQSGVOZG84VFlseitZZFcrV05EZUk1UHRo?=
 =?utf-8?B?b2p1eExOaHRUWGtuamFNRUpWSW16QXpMZm1za1hIOEZLVUxnZ1VVU0RvOEc1?=
 =?utf-8?B?SmVkYzVzVDRBNFh4NWtRMGFubWhjMkQ3R25ZT0I0ZmlPdVc1Qm50dDI2b1ZV?=
 =?utf-8?B?ZGx1OWdZR1lCR0FDbFgwbUhKZ3dOM1d0QVYyeTRNNG96Wk1JMDd5dUZCZUFN?=
 =?utf-8?B?Sm5KM0QzOTd3cUxxRXAxQWhQeEFQM3Y4c3dZUzZ3VWUzWExnVmVnZjQ5NXZW?=
 =?utf-8?B?UUU5eU01dllzaitKZ1dzOW13aXFjSE1pWkN5VHNQYlFyZFo4Y3dNY1BGcmQr?=
 =?utf-8?B?OXQ5a21IemZSajIvNGFVL3BsektuZTlIUTA2MnVNWWNiOXgwUTBJTVBpUXdJ?=
 =?utf-8?B?OXZJV0VMc0h0aVd3dWhjQTdZZ1NNbW1mTTAyci9GOVJBU1dGc2k4bmpLeTlx?=
 =?utf-8?B?N1BhUDBuNkRFQjUyeDRVQjhDWlFBalp1NzA1amgwc3dIZzYyanZUVDdEMGY3?=
 =?utf-8?B?WFNDL3ZVSUV2bWJkb2VzZjcrcXlROWl1NEVYSnNobFd4MmJrMEhadWhBTDV0?=
 =?utf-8?B?TUhLblp5WVNKM1djeUtwVGRvT0tpRFd0TEZXd0Q0NlhHYTJrOUx2VyswU05p?=
 =?utf-8?B?eWlUYXV4K1RHQnZLTHFkK0syeWNXZi9OaE5MTjdFenZFS2FyZ2UxQUhXMmxJ?=
 =?utf-8?B?c3ZCUjhUc2RWeDkyR2tLTi9Sa2RDVGJnM01CT3J2aFhnU3JmeGplRDZQNU1j?=
 =?utf-8?B?cGhMQmlyR1gzZkN3MkRybVl5Yi92MnplT3lINVpPbGgzZ00zaWVrdkUvZ3NU?=
 =?utf-8?B?RXpUOGdRNUJTWEVuVkhiQ1dqZ3JNNHpRRjd4ZG9UenNwdzBqeXZJaXFlNFJ6?=
 =?utf-8?B?ZGpzVnFublVhTUMwU3YxVjRTSU1EV1duaFlUY2kveGpsOGZFQktxYmRIUFp1?=
 =?utf-8?B?dnNYRFpaT3FPTnExZXlVYzZCK3RPaDdGbG1EV1NROGkzeUtSTjZ5RmNuaHdO?=
 =?utf-8?B?MGxpaEUxY2l2SWhUaWtKa3ozd1E5Wit1KzRyMmpwOHFqcDNVeGttVnpBQWpY?=
 =?utf-8?B?Qkw0bWhsTGlqWkdjVzg5VThVdmhJRi9rbm1pQkxGNjg2VklWdnpSOW02czkx?=
 =?utf-8?B?S3dYRzZWUCsvSksyeHFZTUNnWnZITVdCSEx3dmJLZFBoeXV6U0lKV0RmTkdD?=
 =?utf-8?B?Mi82ZU1JSmlmNk1CNDZxS0wvZUk2blNJMVdoaVRsVm9ZbHp2ZG1QYmRlVXNI?=
 =?utf-8?B?ZlJPUUhiR25QRWxSSnp2cFMyODlwYmJHRVpJVFhSSndTSmU0QUlqRjE3NnB4?=
 =?utf-8?B?ZXozR0NlTXFDbFRHYS9CbVN1L2x5eFpkY2RodC9xNWlNUzRPM1EyS3lkNk02?=
 =?utf-8?B?K1lvNjUxQVZVSWxSSHhMZHlSSmRMaTBQNE1RYU5pMjM0NnFXVlZ5Z1dRUytR?=
 =?utf-8?B?dWFDeU5DanBjZWt5Ly8xVjQrS013ejIyNHZvdCtjT1JRekV4SUdJM0o5OEl5?=
 =?utf-8?B?ZHowbjFsNUVLaExFNmUxVVk0MDhxTFRUMmlEL0dhaVdHMm5acGhnNXhxREwx?=
 =?utf-8?B?TkYwQk9sYytLL1cycjZrMXdXRXo3Y3RCeEJncWJlTWxkMUxzRlE4SlA1bDk5?=
 =?utf-8?B?R0lsY3ZWbXFuZmxrM3RQZnJRQmVhTHFuOE1ySFdMK3RwYWtvTGs3ck5lL3dD?=
 =?utf-8?B?YTAxeWgvakpob2hjbzJaM2I0dGVEcHB4MDZhTGx1SUhqNWhMQzkwTXVYTlZ1?=
 =?utf-8?B?ZTc1cUNyanhlMngvMkJSV3gvK0NyZmk0ZzlFN0c1ZzV3ZmtUMkh1SXNpYXpY?=
 =?utf-8?B?VHJaSFNXVENaZnVGZ09HaitZZE10RWk5Z2NCY1lzZlJuNHpoVWV5NVl6OG9T?=
 =?utf-8?B?c1pvN1lrZTU0ZUswckpuYzBicUhlSzJ6T3o0bE9yOXhSdDEzd3A5bStsUk5D?=
 =?utf-8?B?ZnlyK3dMNmZQV2tiWEQwdjBpUTR1aFlIdDdlM1ROSVp4NDZ5Q1M3TzVJbk1Y?=
 =?utf-8?B?VVFtajdYTEZPNUlIR0pFK3Jxd2N0U2E2eHZGakdZd3RKb2Q4QnE0bWo3dHUz?=
 =?utf-8?B?ckx3V01Gck80azhtWkxOTnVqb2ZaMUdVKzkrdXEvSEFZZCt1dGdPMVpGTVcw?=
 =?utf-8?Q?7Kion8jSBaSW7nBn+VYI4GE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3b6a7db-f24a-42ca-7140-08d9b6651e18
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:59:26.4015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4im0N6s+b954ZNmhrBT72+yiPx0rO6eINQ9LNuG95zFSDb+9VOxHuswj/ViFzCiXr04jJOlhnxkXwPH3vzL1Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5902

On 26.11.2021 17:33, Andrew Cooper wrote:
> ... to prevent the optimiser creating unsafe code.  See the code comment for
> full details.
> 
> Also add a build time check for endbr64 embedded in imm32 operands, which
> catches the obvious cases where the optimiser has done an unsafe thing.

But this is hardly enough to be safe. I'd even go as far as saying we can
do without it if we don't check more thoroughly.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -190,6 +190,10 @@ $(TARGET)-syms: prelink.o xen.lds
>  	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y= $(@D)/.$(@F).1.o
>  	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
>  	    $(@D)/.$(@F).1.o -o $@
> +ifeq ($(CONFIG_XEN_IBT),y)
> +	$(OBJDUMP) -d $@ | grep 0xfa1e0ff3 >/dev/null && \
> +		{ echo "Found embedded endbr64 instructions" >&2; false; } || :

I guess I'm confused: The "false;" suggests to me you want to make the
build fail in such a case. The "|| :" otoh suggests you want to silence
errors (and not just the one from grep when not finding the pattern
aiui).

Also isn't passing -q to grep standard enough (and shorter) to use in
place of redirecting its output to /dev/null?

> --- /dev/null
> +++ b/xen/include/asm-x86/endbr.h
> @@ -0,0 +1,55 @@
> +/******************************************************************************
> + * include/asm-x86/endbr.h
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Copyright (c) 2021 Citrix Systems Ltd.
> + */
> +#ifndef XEN_ASM_ENDBR_H
> +#define XEN_ASM_ENDBR_H
> +
> +#include <xen/compiler.h>
> +
> +/*
> + * In some cases we need to inspect/insert endbr64 instructions.
> + *
> + * The naive way, mem{cmp,cpy}(ptr, "\xf3\x0f\x1e\xfa", 4), optimises unsafely
> + * by placing 0xfa1e0ff3 in an imm32 operand, which marks a legal indirect
> + * branch target as far as the CPU is concerned.
> + *
> + * gen_endbr64() is written deliberately to avoid the problematic operand, and
> + * marked __const__ as it is safe for the optimiser to hoist/merge/etc.
> + */
> +static inline uint32_t __attribute_const__ gen_endbr64(void)
> +{
> +    uint32_t res;
> +
> +    asm ( "mov $~0xfa1e0ff3, %[res]\n\t"
> +          "not %[res]\n\t"
> +          : [res] "=r" (res) );

Strictly speaking "=&r".

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 13:59:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 13:59:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237681.412248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt96E-0006ym-Bk; Fri, 03 Dec 2021 13:59:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237681.412248; Fri, 03 Dec 2021 13:59:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt96E-0006yc-7u; Fri, 03 Dec 2021 13:59:42 +0000
Received: by outflank-mailman (input) for mailman id 237681;
 Fri, 03 Dec 2021 13:59:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt96C-0006xZ-PS
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 13:59:40 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4161c867-5441-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 14:59:39 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40538)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt96A-000LWp-oF (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 13:59:38 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 5CCFB1FC17;
 Fri,  3 Dec 2021 13:59:38 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4161c867-5441-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <57190224-879a-8309-e1a9-534072af9aa0@srcf.net>
Date: Fri, 3 Dec 2021 13:59:38 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-60-andrew.cooper3@citrix.com>
 <a8434878-129d-8207-09e3-4909e638a4d0@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 59/65] x86/traps: Rework write_stub_trampoline() to not
 hardcode the jmp
In-Reply-To: <a8434878-129d-8207-09e3-4909e638a4d0@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 13:17, Jan Beulich wrote:
> On 26.11.2021 13:34, Andrew Cooper wrote:
>> For CET-IBT, we will need to optionally insert an endbr64 instruction at the
>> start of the stub.  Don't hardcode the jmp displacement assuming that it
>> starts at byte 24 of the stub.
>>
>> Also add extra comments describing what is going on.  The mix of %rax and %rsp
>> is far from trivial to follow.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> ---
>>  xen/arch/x86/x86_64/traps.c | 36 ++++++++++++++++++++++--------------
>>  1 file changed, 22 insertions(+), 14 deletions(-)
>>
>> diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
>> index d661d7ffcaaf..6f3c65bedc7a 100644
>> --- a/xen/arch/x86/x86_64/traps.c
>> +++ b/xen/arch/x86/x86_64/traps.c
>> @@ -293,30 +293,38 @@ static unsigned int write_stub_trampoline(
>>      unsigned char *stub, unsigned long stub_va,
>>      unsigned long stack_bottom, unsigned long target_va)
>>  {
>> +    unsigned char *p = stub;
>> +
>> +    /* Store guest %rax into %ss slot */
>>      /* movabsq %rax, stack_bottom - 8 */
>> -    stub[0] = 0x48;
>> -    stub[1] = 0xa3;
>> -    *(uint64_t *)&stub[2] = stack_bottom - 8;
>> +    *p++ = 0x48;
>> +    *p++ = 0xa3;
>> +    *(uint64_t *)p = stack_bottom - 8;
>> +    p += 8;
>>  
>> +    /* Store guest %rsp in %rax */
>>      /* movq %rsp, %rax */
>> -    stub[10] = 0x48;
>> -    stub[11] = 0x89;
>> -    stub[12] = 0xe0;
>> +    *p++ = 0x48;
>> +    *p++ = 0x89;
>> +    *p++ = 0xe0;
>>  
>> +    /* Switch to Xen stack */
>>      /* movabsq $stack_bottom - 8, %rsp */
>> -    stub[13] = 0x48;
>> -    stub[14] = 0xbc;
>> -    *(uint64_t *)&stub[15] = stack_bottom - 8;
>> +    *p++ = 0x48;
>> +    *p++ = 0xbc;
>> +    *(uint64_t *)p = stack_bottom - 8;
>> +    p += 8;
>>  
>> +    /* Store guest %rsp into %rsp slot */
>>      /* pushq %rax */
>> -    stub[23] = 0x50;
>> +    *p++ = 0x50;
>>  
>>      /* jmp target_va */
>> -    stub[24] = 0xe9;
>> -    *(int32_t *)&stub[25] = target_va - (stub_va + 29);
>> +    *p++ = 0xe9;
>> +    *(int32_t *)p = target_va - (stub_va + (p - stub) + 4);
>> +    p += 4;
>>  
>> -    /* Round up to a multiple of 16 bytes. */
>> -    return 32;
>> +    return p - stub;
>>  }
> I'm concerned of you silently discarding the aligning to 16 bytes here.
> Imo this really needs justifying, or perhaps even delaying until a
> later change.

Oh.  That was an oversight, and I'm honestly a little impressed that the
result worked fine.

return ROUNDUP(p - stub, 16);

ought to do?

>  I'd like to point out though that we may not have a space
> issue here at all, as I think we can replace one of the MOVABSQ (using
> absolute numbers to hopefully make this easier to follow):
>
>     movabsq %rax, stack_bottom - 8
>     movq %rsp, %rax
>     movq -18(%rip), %rsp
>     pushq %rax
>     jmp target_va
>
> This totals to 26 bytes, leaving enough room for ENDBR64 without crossing
> the 32-byte boundary. But I fear you may eat me for using insn bytes as
> data ...

Well that's entertaining, and really quite a shame that RIP-relative
addresses only work with 32bit displacements.

While it is shorter, it's only 3 bytes shorter, and the stack layout is
custom anyway so it really doesn't matter if the push lives here or not.

Furthermore (and probably scraping the excuses barrel here), it forces a
data side TLB and cacheline fill where we didn't have one previously. 
Modern CPUs ought to be fine here, but older ones (that don't have a
shared L2TLB) are liable to stall.

Perhaps lets leave this as an emergency option, if we need to find more
space again in the future?

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 14:03:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 14:03:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237689.412259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9AH-0000GX-SI; Fri, 03 Dec 2021 14:03:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237689.412259; Fri, 03 Dec 2021 14:03:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9AH-0000GQ-Oy; Fri, 03 Dec 2021 14:03:53 +0000
Received: by outflank-mailman (input) for mailman id 237689;
 Fri, 03 Dec 2021 14:03:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EuM9=QU=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mt9AG-0000GK-Tl
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 14:03:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d802b85a-5441-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 15:03:51 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-3oWnzzAdPh-d5tvwk88P5Q-1; Fri, 03 Dec 2021 15:03:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Fri, 3 Dec
 2021 14:03:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%5]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 14:03:49 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0082.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 14:03:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d802b85a-5441-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638540231;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XGCsuCtzO/s2HKEU6qPlE6FbZFHB+IRDx0UauEYKxtM=;
	b=ck4FdNV8l7wfrSwxA1e4ml+dNbp7kt4JsyYlFBcnXdvCdPDiO29Gnz7pMqsd03e7cBGMhE
	PB/BQ49zfzO89CBwTyqSailAfVYGJJ+KMuda+6TkTqptH3865EsbQkwN8B1sjmU3NJjZgz
	ZnWtF6IJCk5eGkzU4z3hrDNGwC08Y2w=
X-MC-Unique: 3oWnzzAdPh-d5tvwk88P5Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oM92Gl/gePMR4lsUIu+U/gUzRH8F/hPk8jmMCf7GTuylDxW+Q5ceJVSydjcXPX1lVxjg9rbefQQCxqf6FG3KIEXuUjCMUmdyDVXjEI6y7a1pk095MBjWpUdiDqFbKz0Vl30357gEfUSMZwg2BI3SXiXBgm5qbSZ5GxlvxZTLO3gp8DriPx9g8Yyu3lTPvMMq0ifjjHEBOsm15ofvClATUcqI6klqfOpYLrM1jwqLz2C4ecdMLP7dtyv2vbyijD3zkf2Rr0m+x8q0KsaJUthBBiIZ4wHLmWA5csq4Gql2Rz/prOvUYgqi9niCWLvvFnLW4+ENcVpkItlVnwHwROXr/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zx3J8gPY/VjfIr6NrBe442u2MW4Q426sUZp1jxLwy7k=;
 b=SbJaTm6AbZLsBf7R62wAYI6oxZnAG0f6iXC62RFHpFHfr1nS8TZrTFhmDJApolEi2JpyWpUV+MmBD40dhzBrLS5wLu56vT5GI2qs6KBhFoniP1G//Pvu2h/UVeC3YUdbuUeOF8EPMxPuSsoF0DzCdgsCU+E4OWM6lvV8qW6EEVZMDnxjAwCi1HHZ/D3UdY1KTolXFrKhhPfaBgDsiM5fOchVg+1aro8BkBiX6ziri2VRroeaZPTBZz4WGwdrc7H9cm0HUu9cxL/tv9ft/sESVfSkGS5JizrOzJuZgNUHUE56nB0jesHSYN8s4+ozXjo4rjjwoWzDmx8Has//Vw76XQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4922cb60-700f-c135-aefa-81c6ae55c9a2@suse.com>
Date: Fri, 3 Dec 2021 15:03:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 59/65] x86/traps: Rework write_stub_trampoline() to not
 hardcode the jmp
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-60-andrew.cooper3@citrix.com>
 <a8434878-129d-8207-09e3-4909e638a4d0@suse.com>
 <57190224-879a-8309-e1a9-534072af9aa0@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <57190224-879a-8309-e1a9-534072af9aa0@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P193CA0082.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aba30e92-8e42-412c-d3e2-08d9b665baf1
X-MS-TrafficTypeDiagnostic: VI1PR04MB2958:
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29582FB3DD01488B95A3B3BFB36A9@VI1PR04MB2958.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AQ4PhsKt6MZzLutudyNfP6VF7ABdJkebfHEIuVrtrf5l0iSOYpyI6o01ScgfcF7eafmPGH+ma/t/GQL12hKJ0otTUUoNz8h4v6Z+nx4nZQuxjCtmwIZispEUeh9WVu24rThOY+/feEtx+4WIlOgMIoUDvlA9KN/anJkX6jI58UPEVgXUT1B7eQI7wMQmpWgMqG1Hnr7IPCY/EW9WfZxSJ0Z8Gs4cTIJAzYJu5mqQZgS+luG2YPOPWr9d6GQKBrBKDzM8sLGFdoHINyFL5daK09iWWbNfNY9KLzXDTn4MSus9pBmN2GAqfNp2TzQRWMje+xoWZEOm9owZbZw5f+5wm2joAwfCAelFu4Xv7Sh8Sugfn0kHZMDJlK+33uIpOGRS6Nm6Z1O99ves5ylaHAGO9WITFK0k97OrZp/KonOMPIwGg72bWbNbE9BO6KoliTKqteqwvRnQPMxn4kH2VUX0xKTTsNGxaaxgR3qHFBP9ejTWX1j3w/VpOOkTABBMcbcH7M9qEYDZi1uMs5wNv1QLeXBLqjfiaQJVlTGfCfJWWwtKQgFLwOlEqW+fysYb63DEB9kVaJpwyYgC4xIpoIyBIAzbMznF+UL4Fe4ixPJFddebStS9BU9t9ain6JJGzgCFUDocNrLJ9aduuFVI3aacTw5w/q26F5m8wuEnf3dUYrUB99GtJZdjd7xKDPbps2owdB3ijw/ItTWMMIEBlN55TFw9ScW6KglV1r6ObxCsWwqMqWp3aBV3oDECg4Zxg/6Z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(8676002)(186003)(66556008)(956004)(36756003)(53546011)(38100700002)(26005)(16576012)(4326008)(8936002)(31696002)(316002)(508600001)(86362001)(110136005)(31686004)(5660300002)(54906003)(2906002)(6486002)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?so7uHTQLdHCHhmaIYK+jjA/CuirrqvSfitK/76A/NiS0rK7aStwWs4n7SV7X?=
 =?us-ascii?Q?4t9xGk0ebEOTp2l9Xb15x8pkW1S2Pn6UPPymFfJp5yJKcVOKBF7Noal6Nt3M?=
 =?us-ascii?Q?V5xlCkQ+p4VIEf7tSgLPUbHaHXh14EHc2RXl6mzB9qnuBSLzyd/BBMQlHPWo?=
 =?us-ascii?Q?VL291M0HVz82j/2iOzoC9yU/u9j4L22/RFcttbExssT7oV7MWjU3phjlMbaE?=
 =?us-ascii?Q?XA3+lm7tqpO6GDgCo+ugLb8KOPnNMz3GZC62KPwWoEXKMZVYdZPA4UJDtFgH?=
 =?us-ascii?Q?7btQYlbd/NIYBoudkcQpWe+LsBZeUvd3DuUdny3eM6A+4Yx23o3cuum9llaW?=
 =?us-ascii?Q?rrSUeOVaKbZXEivF3owIlDa2sCTi+/wfcjblBO79B0+38TJbTfq9AtY4iY1E?=
 =?us-ascii?Q?3w6GRKgU4rBVN6SbxqwfKOFFidhIHEtOrOKjLzVWQdYrXQpWF5zTjZu2r5Q7?=
 =?us-ascii?Q?NW6IJUTX+Gu00B/iwolqJEroCL51yIkevG+Lkr0ooZPnC6yvQAAmNtGO3nGp?=
 =?us-ascii?Q?A+53JMoe0GwenohuwqWRtcTmeebfbnopVU4Ywi26iejjrgDCGf1A7zHTxE9q?=
 =?us-ascii?Q?aAkZc7GRpSWNrQU+v/XSKsZV0t7BL6iAm7qAuc11tlaEaUSetqvRQhgKiAgJ?=
 =?us-ascii?Q?0CanvQvhGsJ/Hd7wzb5ldDGHvrs4pN2Sdwzj4N2Kbj7EiFPPbXS6Cgpe/Jox?=
 =?us-ascii?Q?i46K6d860wd/JwPPKjR6ZFpBEz0L3yu4GgQh1pJiuE4sT3AXXvORvQLbZJFF?=
 =?us-ascii?Q?FZoEqCZKp+6vdq9ClOzGjXjTtFvkgSLDlY+4aY8tLORplIkdOsjpzSVP7Ald?=
 =?us-ascii?Q?bATVCy2bYmDYm0EewshAgsFoxUwD+qgnWiHBOAfVIV3mB6PRlo+y7pbXjgOh?=
 =?us-ascii?Q?ZQlt9Xu7z3byfchtx4uVcKjDNRkeVVl8VglYyXj/mGcCD9xmBxl2s66anaOh?=
 =?us-ascii?Q?8qUb3YO0PAAxElvQV/+Ijge35bVGFFokbBIU2OpUNGnovXAEmo3FCd8eK5q9?=
 =?us-ascii?Q?a0vjICCfCWwKU0phtrZizPh/Zl7zhGrJ8hmIapLRZC827C6zFuzvRTcixdYd?=
 =?us-ascii?Q?Z76PCyWU65nb8tX122+6zeMRfQdHrsVPKYBzaNl6w9hGAMlCM7EUKvgSLx2f?=
 =?us-ascii?Q?1LER7op6ZpxNdnAIQ3T35toe/FK1tgmvRLm3QCU73covUlrp8oUlf+XGwHEK?=
 =?us-ascii?Q?W+jrfUMHBB8cvpNvDb4otGY2/vvEUgG0SpQKp+nfYPgC8lE/EUxsNAHnXnSB?=
 =?us-ascii?Q?96qDtt6lBcYgh+xhqAuQbUFzcd1PM9k/pCFeyCk9ym89YI5thOuU23czeqim?=
 =?us-ascii?Q?1EqAcSoiLbHDd7UV5ZQawovEXxW6B1TBmIRX70YZrQ4i8Q+OTldsierog4SC?=
 =?us-ascii?Q?mRbM/Bg9VW5d2EC4OxuvniDiFBVAByXvzLVfeZ8TiFNLCqxXh2WMaHQNpdYc?=
 =?us-ascii?Q?ATYHdlqUi5iuoJJQyyBe9R3EcdVcidyE1OlirJb4gM/Gy0dvD3HI54XPGNg/?=
 =?us-ascii?Q?xS5K52xXnPfO0jPPoJKqtW2Wqt9imYodxxrshIrbBHXA4RedJnpZP46+0niT?=
 =?us-ascii?Q?Sir4uenyuWlCPzSDeg4dlnxeZ31arsnAjcSQO6mVNDYLBK8Fb217ROKgzg0f?=
 =?us-ascii?Q?9YMhe6/TPoqosn/4hxNIjNQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aba30e92-8e42-412c-d3e2-08d9b665baf1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 14:03:49.6097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ALViwcgNwgdO/Ca0MrB3yzJUBMtpZMseghgRcYovtQmDLGAHItRSgNE4ftYS7AKozC2uhxtT3Nl2zb/6PCmaPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958

On 03.12.2021 14:59, Andrew Cooper wrote:
> On 03/12/2021 13:17, Jan Beulich wrote:
>> On 26.11.2021 13:34, Andrew Cooper wrote:
>>> For CET-IBT, we will need to optionally insert an endbr64 instruction a=
t the
>>> start of the stub.  Don't hardcode the jmp displacement assuming that i=
t
>>> starts at byte 24 of the stub.
>>>
>>> Also add extra comments describing what is going on.  The mix of %rax a=
nd %rsp
>>> is far from trivial to follow.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Jan Beulich <JBeulich@suse.com>
>>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>> CC: Wei Liu <wl@xen.org>
>>> ---
>>>  xen/arch/x86/x86_64/traps.c | 36 ++++++++++++++++++++++--------------
>>>  1 file changed, 22 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
>>> index d661d7ffcaaf..6f3c65bedc7a 100644
>>> --- a/xen/arch/x86/x86_64/traps.c
>>> +++ b/xen/arch/x86/x86_64/traps.c
>>> @@ -293,30 +293,38 @@ static unsigned int write_stub_trampoline(
>>>      unsigned char *stub, unsigned long stub_va,
>>>      unsigned long stack_bottom, unsigned long target_va)
>>>  {
>>> +    unsigned char *p =3D stub;
>>> +
>>> +    /* Store guest %rax into %ss slot */
>>>      /* movabsq %rax, stack_bottom - 8 */
>>> -    stub[0] =3D 0x48;
>>> -    stub[1] =3D 0xa3;
>>> -    *(uint64_t *)&stub[2] =3D stack_bottom - 8;
>>> +    *p++ =3D 0x48;
>>> +    *p++ =3D 0xa3;
>>> +    *(uint64_t *)p =3D stack_bottom - 8;
>>> +    p +=3D 8;
>>> =20
>>> +    /* Store guest %rsp in %rax */
>>>      /* movq %rsp, %rax */
>>> -    stub[10] =3D 0x48;
>>> -    stub[11] =3D 0x89;
>>> -    stub[12] =3D 0xe0;
>>> +    *p++ =3D 0x48;
>>> +    *p++ =3D 0x89;
>>> +    *p++ =3D 0xe0;
>>> =20
>>> +    /* Switch to Xen stack */
>>>      /* movabsq $stack_bottom - 8, %rsp */
>>> -    stub[13] =3D 0x48;
>>> -    stub[14] =3D 0xbc;
>>> -    *(uint64_t *)&stub[15] =3D stack_bottom - 8;
>>> +    *p++ =3D 0x48;
>>> +    *p++ =3D 0xbc;
>>> +    *(uint64_t *)p =3D stack_bottom - 8;
>>> +    p +=3D 8;
>>> =20
>>> +    /* Store guest %rsp into %rsp slot */
>>>      /* pushq %rax */
>>> -    stub[23] =3D 0x50;
>>> +    *p++ =3D 0x50;
>>> =20
>>>      /* jmp target_va */
>>> -    stub[24] =3D 0xe9;
>>> -    *(int32_t *)&stub[25] =3D target_va - (stub_va + 29);
>>> +    *p++ =3D 0xe9;
>>> +    *(int32_t *)p =3D target_va - (stub_va + (p - stub) + 4);
>>> +    p +=3D 4;
>>> =20
>>> -    /* Round up to a multiple of 16 bytes. */
>>> -    return 32;
>>> +    return p - stub;
>>>  }
>> I'm concerned of you silently discarding the aligning to 16 bytes here.
>> Imo this really needs justifying, or perhaps even delaying until a
>> later change.
>=20
> Oh.=C2=A0 That was an oversight, and I'm honestly a little impressed that=
 the
> result worked fine.
>=20
> return ROUNDUP(p - stub, 16);
>=20
> ought to do?

Yes, sure. Then
Reviewed-by: Jan Beulich <jbeulich@suse.com>

>>  I'd like to point out though that we may not have a space
>> issue here at all, as I think we can replace one of the MOVABSQ (using
>> absolute numbers to hopefully make this easier to follow):
>>
>>     movabsq %rax, stack_bottom - 8
>>     movq %rsp, %rax
>>     movq -18(%rip), %rsp
>>     pushq %rax
>>     jmp target_va
>>
>> This totals to 26 bytes, leaving enough room for ENDBR64 without crossin=
g
>> the 32-byte boundary. But I fear you may eat me for using insn bytes as
>> data ...
>=20
> Well that's entertaining, and really quite a shame that RIP-relative
> addresses only work with 32bit displacements.
>=20
> While it is shorter, it's only 3 bytes shorter, and the stack layout is
> custom anyway so it really doesn't matter if the push lives here or not.
>=20
> Furthermore (and probably scraping the excuses barrel here), it forces a
> data side TLB and cacheline fill where we didn't have one previously.=C2=
=A0
> Modern CPUs ought to be fine here, but older ones (that don't have a
> shared L2TLB) are liable to stall.

Well, that was why I though you might eat me for the suggestion.

> Perhaps lets leave this as an emergency option, if we need to find more
> space again in the future?

Yeah - as said elsewhere, due to the v1.1-s I did look at patches in the
wrong order, and hence wasn't aware yet that you have found a different
way to squeeze in the ENDBR.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 14:11:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 14:11:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237696.412273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9H9-0001rt-Pk; Fri, 03 Dec 2021 14:10:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237696.412273; Fri, 03 Dec 2021 14:10:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9H9-0001rm-MU; Fri, 03 Dec 2021 14:10:59 +0000
Received: by outflank-mailman (input) for mailman id 237696;
 Fri, 03 Dec 2021 14:10:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt9H8-0001rf-PX
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 14:10:58 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d5afb6a7-5442-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 15:10:57 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35098)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt9H6-000HOP-9B (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 14:10:56 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A72211FC8B;
 Fri,  3 Dec 2021 14:10:56 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5afb6a7-5442-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <ef297668-96ba-851d-2990-179f6dcb9f37@srcf.net>
Date: Fri, 3 Dec 2021 14:10:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163340.26714-1-andrew.cooper3@citrix.com>
 <e5da1903-20bc-4523-9d0a-6071f117c3ce@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 59.5/65] x86: Introduce helpers/checks for endbr64
 instructions
In-Reply-To: <e5da1903-20bc-4523-9d0a-6071f117c3ce@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 13:59, Jan Beulich wrote:
> On 26.11.2021 17:33, Andrew Cooper wrote:
>> ... to prevent the optimiser creating unsafe code.  See the code comment for
>> full details.
>>
>> Also add a build time check for endbr64 embedded in imm32 operands, which
>> catches the obvious cases where the optimiser has done an unsafe thing.
> But this is hardly enough to be safe. I'd even go as far as saying we can
> do without it if we don't check more thoroughly.

I will do the full check in v2.  Marek wrote the full check in response
to a discussion about this patch.

>
>> --- a/xen/arch/x86/Makefile
>> +++ b/xen/arch/x86/Makefile
>> @@ -190,6 +190,10 @@ $(TARGET)-syms: prelink.o xen.lds
>>  	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y= $(@D)/.$(@F).1.o
>>  	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
>>  	    $(@D)/.$(@F).1.o -o $@
>> +ifeq ($(CONFIG_XEN_IBT),y)
>> +	$(OBJDUMP) -d $@ | grep 0xfa1e0ff3 >/dev/null && \
>> +		{ echo "Found embedded endbr64 instructions" >&2; false; } || :
> I guess I'm confused: The "false;" suggests to me you want to make the
> build fail in such a case. The "|| :" otoh suggests you want to silence
> errors (and not just the one from grep when not finding the pattern
> aiui).

The exit code of grep needs inverting for the build to proceed
correctly.  Without || :, all builds fail when they've not got the pattern.

> Also isn't passing -q to grep standard enough (and shorter) to use in
> place of redirecting its output to /dev/null?

That caused problems on the BSDs.  c/s e632d56f0f5 went through several
iterations before settling on this pattern.

>
>> --- /dev/null
>> +++ b/xen/include/asm-x86/endbr.h
>> @@ -0,0 +1,55 @@
>> +/******************************************************************************
>> + * include/asm-x86/endbr.h
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
>> + *
>> + * Copyright (c) 2021 Citrix Systems Ltd.
>> + */
>> +#ifndef XEN_ASM_ENDBR_H
>> +#define XEN_ASM_ENDBR_H
>> +
>> +#include <xen/compiler.h>
>> +
>> +/*
>> + * In some cases we need to inspect/insert endbr64 instructions.
>> + *
>> + * The naive way, mem{cmp,cpy}(ptr, "\xf3\x0f\x1e\xfa", 4), optimises unsafely
>> + * by placing 0xfa1e0ff3 in an imm32 operand, which marks a legal indirect
>> + * branch target as far as the CPU is concerned.
>> + *
>> + * gen_endbr64() is written deliberately to avoid the problematic operand, and
>> + * marked __const__ as it is safe for the optimiser to hoist/merge/etc.
>> + */
>> +static inline uint32_t __attribute_const__ gen_endbr64(void)
>> +{
>> +    uint32_t res;
>> +
>> +    asm ( "mov $~0xfa1e0ff3, %[res]\n\t"
>> +          "not %[res]\n\t"
>> +          : [res] "=r" (res) );
> Strictly speaking "=&r".

Ok.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 14:12:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 14:12:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237701.412284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9IX-0002RN-4I; Fri, 03 Dec 2021 14:12:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237701.412284; Fri, 03 Dec 2021 14:12:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9IX-0002RG-1F; Fri, 03 Dec 2021 14:12:25 +0000
Received: by outflank-mailman (input) for mailman id 237701;
 Fri, 03 Dec 2021 14:12:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mt9IV-0002R0-DC
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 14:12:23 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0827c63e-5443-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 15:12:22 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44318)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mt9IT-000mMJ-1s (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 14:12:21 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 662331FC8B;
 Fri,  3 Dec 2021 14:12:21 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0827c63e-5443-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <76c98cae-13d5-4ad8-9238-71bef56609d1@srcf.net>
Date: Fri, 3 Dec 2021 14:12:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
 <c41e4bf9-e523-ec9b-aeb9-c91662685dc4@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <c41e4bf9-e523-ec9b-aeb9-c91662685dc4@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 13:23, Jan Beulich wrote:
> On 26.11.2021 13:34, Andrew Cooper wrote:
>> Each IDT vector needs to land on an endbr64 instruction.  This is especially
>> important for the #CP handler, which will escalate to #DF if the endbr64 is
>> missing.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

>
> One remark though:
>
>> @@ -1136,7 +1158,8 @@ autogen_stubs: /* Automatically generated stubs. */
>>  #endif
>>  
>>          ALIGN
>> -1:      pushq $0
>> +1:      ENDBR64
>> +        pushq $0
>>          movb  $vec,4(%rsp)
>>          jmp   common_interrupt
>>  
>> @@ -1146,7 +1169,8 @@ autogen_stubs: /* Automatically generated stubs. */
>>          .elseif vec == X86_EXC_CSO || vec == X86_EXC_SPV || \
>>                  vec == X86_EXC_VE  || (vec > X86_EXC_CP && vec < TRAP_nr)
>>  
>> -1:      test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
>> +1:      ENDBR64
>> +        test  $8,%spl        /* 64bit exception frames are 16 byte aligned, but the word */
>>          jz    2f             /* size is 8 bytes.  Check whether the processor gave us an */
>>          pushq $0             /* error code, and insert an empty one if not.              */
>>  2:      movb  $vec,4(%rsp)
> Like with initializers of compound objects vs trailing commas there, I
> think it would help if we moved away from placing insns on the same
> lines as labels. As can be seen here, inserting something always means
> touching two lines instead of just adding one.

I had actually wondered the same, without drawing a comparison to
trailing commas.  I'll adjust.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 14:34:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 14:34:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237731.412316 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9dp-0006FU-Cr; Fri, 03 Dec 2021 14:34:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237731.412316; Fri, 03 Dec 2021 14:34:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9dp-0006FN-9U; Fri, 03 Dec 2021 14:34:25 +0000
Received: by outflank-mailman (input) for mailman id 237731;
 Fri, 03 Dec 2021 14:34:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mt9do-0006FF-6W
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 14:34:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt9dm-0006N9-0n; Fri, 03 Dec 2021 14:34:22 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=[192.168.21.218]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mt9dl-0008OS-QI; Fri, 03 Dec 2021 14:34:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=eRvzrfBk6CIpwOvSbfQcW4y46M5tUBQDWJUOBJotQMc=; b=gwwChUyy84EIEreTddi4wNrxpB
	zrBGCToL20eMfoS/94JzM2H4dYQyvqZKNJ4CBAp3LZVDsiWEYC/Z/bj4/U8zw5shH0uhkrzIitud+
	2GaK8B92la8YB45W+1LpXntA95RW9otXcOJLzPseJ4XgojRCS+YDFYqaBqd3R1M6TMPQ=;
Message-ID: <eae1afb7-e101-c833-3ad9-7f3b8015cc3b@xen.org>
Date: Fri, 3 Dec 2021 14:34:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: xen: linker symbol mess, and freeing errors
To: Andrew Cooper <amc96@srcf.net>, xen-devel
 <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <115c178b-f0a7-cf6e-3e33-e6aa49b17baf@srcf.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <115c178b-f0a7-cf6e-3e33-e6aa49b17baf@srcf.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 03/12/2021 13:34, Andrew Cooper wrote:
> Hello,

Hi,

> On ARM, the embedded dtb support wants a rethink, because it was placed
> after BSS, rendering any space-saving null and void in the compiled (and
> loaded) image. 

While I understand the compiled/loaded image are going to be bigger, I 
think this is correctly place it is going to be relocated by Xen during 
the boot process. So I don't think it should be placed in the middle of 
Xen binary.

Furthermore, IHMO, this is a legacy/development feature because one 
should really use the DT provided by the firmware.

So I am not convinced this is worth to spend time re-ordering things 
around (and potentially breaking more stuff).

> There is also nothing which checks the BSS is correctly
> aligned for the zeroing loops (which I do have fix for).

AFAICT, the worse things that could happen is Xen will crash at boot 
when zeroing which is easily noticeable and reliable. That said,
it would be good to make it a compiler error to save time.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 14:35:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 14:35:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237738.412327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9eu-0006xF-O1; Fri, 03 Dec 2021 14:35:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237738.412327; Fri, 03 Dec 2021 14:35:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mt9eu-0006x8-JW; Fri, 03 Dec 2021 14:35:32 +0000
Received: by outflank-mailman (input) for mailman id 237738;
 Fri, 03 Dec 2021 14:35:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt9et-0006wu-EP; Fri, 03 Dec 2021 14:35:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt9et-0006OO-AS; Fri, 03 Dec 2021 14:35:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mt9es-0002m0-W6; Fri, 03 Dec 2021 14:35:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mt9es-0000AH-VZ; Fri, 03 Dec 2021 14:35:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=14UFJukrrABwh+IN1+jhcT+WNy3lcEEkRZMfng0a6T4=; b=ElNnuUXICFdajt1NeOXdEjpA4P
	39Sf4GrxOg/DyatxRoTb18xoT/OlnMKidKn72uWPC7PTOmeQ1eHfiAcpebTGlNgk/sgVqL2J3Nmfi
	OjHKNaIxUHNno6XwrakLHzsDnGAiSUjlmqcY0aD+F1PVM8dSo3e3fRv+2rU/PAWcfEqk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167066-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167066: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=a7a03324d86e111f81687b5315b8f296dde84340
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 14:35:30 +0000

flight 167066 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167066/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              a7a03324d86e111f81687b5315b8f296dde84340
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  511 days
Failing since        151818  2020-07-11 04:18:52 Z  510 days  493 attempts
Testing same since   167066  2021-12-03 04:20:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 86372 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 15:02:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 15:02:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237756.412349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtA48-0002VF-3B; Fri, 03 Dec 2021 15:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237756.412349; Fri, 03 Dec 2021 15:01:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtA48-0002V8-0K; Fri, 03 Dec 2021 15:01:36 +0000
Received: by outflank-mailman (input) for mailman id 237756;
 Fri, 03 Dec 2021 15:01:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtA47-0002Uy-51; Fri, 03 Dec 2021 15:01:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtA47-0006qb-0p; Fri, 03 Dec 2021 15:01:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtA46-00044A-E6; Fri, 03 Dec 2021 15:01:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtA46-0008Ub-Dd; Fri, 03 Dec 2021 15:01:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DvX4lTRYHaO+WKKGC/LQQm8QdUiz9vwxg6BG/lsZbHk=; b=FJOmdAgDeyEgoigdlTJAaaXMF5
	G33HSdIoeXUXma+9iGyZYP+5HVBpS758Vgm3cyGQ+k5S+Y5/j57kpOvLGdFPwyTsgEdwrbu6Ya7ko
	qxpOmLZ5Q3Ic5X4B6jiZGa+6JSGVc8m+4ualC36VZ9hN2DtNbs44R8I7uAcv9nR96b3A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167061-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 167061: regressions - FAIL
X-Osstest-Failures:
    seabios:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    seabios:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=2dd4b9b3f84019668719344b40dba79d681be41c
X-Osstest-Versions-That:
    seabios=64f37cc530f144e53c190c9e8209a51b58fd5c43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 15:01:34 +0000

flight 167061 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167061/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 165173
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 165173

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165173
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165173
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165173
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165173
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              2dd4b9b3f84019668719344b40dba79d681be41c
baseline version:
 seabios              64f37cc530f144e53c190c9e8209a51b58fd5c43

Last test of basis   165173  2021-09-24 03:09:48 Z   70 days
Testing same since   167061  2021-12-03 02:40:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Kevin O'Connor <kevin@koconnor.net>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 2dd4b9b3f84019668719344b40dba79d681be41c
Author: Kevin O'Connor <kevin@koconnor.net>
Date:   Thu Dec 2 20:43:20 2021 -0500

    docs: Note v1.15.0 release
    
    Signed-off-by: Kevin O'Connor <kevin@koconnor.net>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 15:30:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 15:30:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237772.412376 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAWI-0006QD-HQ; Fri, 03 Dec 2021 15:30:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237772.412376; Fri, 03 Dec 2021 15:30:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAWI-0006Q6-ES; Fri, 03 Dec 2021 15:30:42 +0000
Received: by outflank-mailman (input) for mailman id 237772;
 Fri, 03 Dec 2021 15:30:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mtAWG-0006Q0-SN
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 15:30:40 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a7e812-544d-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 16:30:37 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40562)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mtAWC-000bGB-oS (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 15:30:36 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 692C81FC17;
 Fri,  3 Dec 2021 15:30:36 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a7e812-544d-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a96abdb7-cdf7-2b24-d293-d3d2c6c77c78@srcf.net>
Date: Fri, 3 Dec 2021 15:30:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
 <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
In-Reply-To: <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 03/12/2021 13:32, Jan Beulich wrote:
> On 26.11.2021 13:34, Andrew Cooper wrote:
>> Each IDT vector needs to land on an endbr64 instruction.  This is especially
>> important for the #CP handler, which will escalate to #DF if the endbr64 is
>> missing.
> One question here: How does this work?

Honestly, I'm not sure.

>  I don't recall there being any "CET
> shadow" along the lines of "STI shadow" and "SS shadow", yet there's
> clearly an insn boundary here that gets "skipped" if the 2nd #CP gets
> converted to #DF. And fetching of the first handler insn also isn't part
> of exception delivery (and could cause other exceptions first, like #PF).

I can't make my observations of real hardware behaviour match the
description in the spec.

Given what a mess it all is, I wouldn't be surprised if the exception
delivery microcode has a special case to escalate this to #DF.

If it didn't escalate to #DF, then you'd end up with an infinite stream
of #CP's, which will most likely cause a stack overflow because #CP
needs to be not-IST for shadow stack reasons.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 15:35:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 15:35:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237777.412387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAb5-000749-63; Fri, 03 Dec 2021 15:35:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237777.412387; Fri, 03 Dec 2021 15:35:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAb5-000742-2J; Fri, 03 Dec 2021 15:35:39 +0000
Received: by outflank-mailman (input) for mailman id 237777;
 Fri, 03 Dec 2021 15:35:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sOtX=QU=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mtAb3-00073w-IU
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 15:35:37 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on060f.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::60f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a902ad18-544e-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 16:35:36 +0100 (CET)
Received: from AM6P195CA0030.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::43)
 by AM6PR08MB4820.eurprd08.prod.outlook.com (2603:10a6:20b:d0::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 15:35:27 +0000
Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::da) by AM6P195CA0030.outlook.office365.com
 (2603:10a6:209:81::43) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 15:35:26 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 15:35:26 +0000
Received: ("Tessian outbound c61f076cbd30:v110");
 Fri, 03 Dec 2021 15:35:26 +0000
Received: from d63e3eb33bf2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 82E5A3A3-9A92-4685-803C-55000D582D91.1; 
 Fri, 03 Dec 2021 15:35:09 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d63e3eb33bf2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 15:35:09 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5627.eurprd08.prod.outlook.com (2603:10a6:102:83::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 15:35:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb%6]) with mapi id 15.20.4690.034; Fri, 3 Dec 2021
 15:35:07 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0106.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::21) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Fri, 3 Dec 2021 15:35:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a902ad18-544e-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qxziB9C61EFjJ3SsjaOKt6jCBqwDCfxuryjlIe1PoXk=;
 b=D4e4XqB8DWVXjYol43XfVw8myyyA/h1Visw/qz3HnUjrlIrzEGsno2bhKR0rpYWKz8SVlfp05nMCWp2/kr7UmzwmGmyPEmpRohVAhW15ijALd3Ctx23dLpu2sujiLsmsL0lI3tV0AjrFbmxXcRYo0wHgkbH1Kd6L8+l5BtBO488=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a783a2545ab541fa
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lgvp0zg7veizxsIfFdhsPFDzhvHfAGC29ykYnjCIkl/c4RoCCODilZRawpsmCcjExq0TxX886zrwzyTslCC7uR4R/RVBxTqtGkgQYcWh30BTLf/eIDAVDWkplFjINeZdeM6ZjblQtWAtU7Su3bmHQiFUz0DPZ+YPXTM4T4Op3t7zxMtGG4uWlRh4o2qgB4YkieMMgCu2+bHzLbPwEUN+kbA+7FTaN72ehDffAMJgJMrdHt9qABjwyY0AfhlaTUVESdA7oxho7XJSv9GV1drVHykYcQF6h2lcAzJY5BOZ7Ulqqk67iISMYYQpTb0wGnSzkh9ksC4bIovysVX5lPHr4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qxziB9C61EFjJ3SsjaOKt6jCBqwDCfxuryjlIe1PoXk=;
 b=ksLbRSj6RLMQsRDlP2JDgDnH60+ayLEhfBhxfoScOOHOKERAf2+ewE6Vgsz3CByCKiyBcKKXs2ptnhBBd+sO/j5F43xMA+Og0sPhBv9I08iZSe2+lrlzzMM01TKnMMN7x49BpIzXaBhQ4QIeClQOVeheftgWoXuJZLL8YEe9m/Sz+SZ5qO2/w5F7VoCFuCinxB0/+Szo9r3QBFmIh024oM1xtQbf44XVAH51k7tjQKwEdf8jTjH42DdiwcysfQnLG6DEPblfAwwcBEdNKlhNFiUDPF46ui28akKJf1lSZ7gD+UOJpwcKXd28dWFzgieYbWIxhKC6FTnIfvsijy9f+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qxziB9C61EFjJ3SsjaOKt6jCBqwDCfxuryjlIe1PoXk=;
 b=D4e4XqB8DWVXjYol43XfVw8myyyA/h1Visw/qz3HnUjrlIrzEGsno2bhKR0rpYWKz8SVlfp05nMCWp2/kr7UmzwmGmyPEmpRohVAhW15ijALd3Ctx23dLpu2sujiLsmsL0lI3tV0AjrFbmxXcRYo0wHgkbH1Kd6L8+l5BtBO488=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 0/7] (mainly) xz imports from Linux
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
Date: Fri, 3 Dec 2021 15:35:04 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E1B0C587-5B7A-4BD8-A585-F9E1CC707B28@arm.com>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0106.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:191::21) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 15de16ee-f357-4d54-71dd-08d9b672877b
X-MS-TrafficTypeDiagnostic: PR3PR08MB5627:|AM6PR08MB4820:
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4820CAF446C1671E73ACAB24E46A9@AM6PR08MB4820.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 NDDjx57wkh9t03csElMfC2uF3xtzxUPtC/7GBvyD6MowWQyKXVbpw39zPvDe6M7mv86lubnY7YnILJONAP3iOQrAaHprEUBZGQbadui3Z2l0RZTw583/TG/x5eGjBv3KxhSURQJHbkknaoPmlDyRr0EaSxQnR4F99CHPEzS8Few8dI7dOIHmNeJkadtouVQ5MaprEIjBysgnV8oGanNCA0OJ/1KargaxlhuQIQJjowOtnoXAojjigQgPf0OsGY7HQz+daJOXjvbBmhYA6bD76fp/qvLffPgbgwb0aYuG8Mxsok1gtH6Iwwuo9neereiztncZM/UmGDZf6cNFrL+ElfwkGBbU+AeOn0ly4UM5vYl2gtBTfB0P1ZPCIeBYFsqkD6/GhF53jmZSABRLYMPLelFDew2ByNpK5RcLtDtA9y0GbwnQR0ca1UQ3dnLqFwPRjLOXp/tEfU4z12xf41JNaPjNlCKyncD+dSMidRlwpsm3bP2afny33NZASQscVtD20ATdk051TCRTNgWq2MgsBQmsftj58wfjI3XnliMcXUtr2cbfZBS+nj2lv+YvM1uLLIPexSC5/q/5PfWttqtMVZ0CPa/16DthyxO3sq8qLhoNW+0fzzhNR+ZDP4Z1Tn3DgZQXM3oFhoKU/O/xwthEMrEIEncHoxnU8/j5JqYCYJ9BLXxjjMZh24NPT26Li05GE2eveaLCRUpyMpA/VYjy4WtL1/LM3jkLJ3xB5YV+RAg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(6916009)(53546011)(66476007)(66556008)(54906003)(66946007)(86362001)(26005)(508600001)(38100700002)(8676002)(316002)(6512007)(2906002)(8936002)(6486002)(52116002)(4744005)(4326008)(33656002)(83380400001)(5660300002)(956004)(2616005)(44832011)(36756003)(186003)(38350700002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5627
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	fcd5e57d-6d34-42d8-d69a-08d9b6727bb7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	H/Mxdew0UklNNSgYKalUiOyI1YWfBVAJrry72TxnuNG4aor1rrqRBCnYCGFW7vLP6ZxXE78FZEgAGqcwynHWusyilBZgvOlbodOYGk8EpP1E0vkJ+uXLyflmk0F7A/ZppilDGh6JT+K582qbWsHUHMK/xmhIGVtWj7MftasHUuvpg4/+pKJuvxWKBs6O206ry37Rs7YvxR6j0e8syKNjQ9jXMuOWHR+L9R+wzX/Iudnw5vhVAI03pdYVgh0myUXLHMBlPkD8XPLBJGnoLhAe1zlk5qTOjlB8wa7UTe6L7h0OnAXRS0S7ia0LOcUO6EWihIKSiv19a81X/JTXddryOdXEssFEsbfLIw/Rt+dLH21TTblWHv9IShkv4HfO3qVRyeep7EO6UxySHYVuwlkIjgY9fqQq3S+IKgxDwrgmpaqbDcrsZ1UaN0QPJrD/MGdL6qBiRagT/6H0zxGkyodcOGhSPtgKNcOBHzjLlrdq7h8Tw36SU26hpMv5EFTgz5faGJeevrUSlEAJfHd4QhOmiG4WZGvhEXDhmYQb9XUrtTjmW/SnjxLSPijoGkHPfArGxHWjdfoBvXv7fWqJQb68x9Peu8hHbrO0Xcxs4Bm0sArncpQveMOjQ6NyA5mBtSKPFUU0xOauB0OsAvV+3yVdXzKKWWw4c2b7LcauqErYOCFfWqYJyMGvm97U1Chd8bxGUKQzmqhntA5x19iuUsjkIQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2906002)(508600001)(81166007)(36860700001)(6862004)(83380400001)(86362001)(5660300002)(70586007)(356005)(36756003)(8936002)(6486002)(316002)(8676002)(82310400004)(53546011)(4326008)(47076005)(6512007)(4744005)(33656002)(186003)(70206006)(2616005)(26005)(44832011)(336012)(956004)(54906003)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 15:35:26.4239
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 15de16ee-f357-4d54-71dd-08d9b672877b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4820

Hi Jan,

> On 19 Nov 2021, at 10:20, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> While going through their 5.15.3 log I did notice two changes, which made
> me go check what else we might be missing. The series here is the result.
> Linux has also updated zstd, but that includes a pretty large change whic=
h
> I'm not ready to deal with right now. Them moving closer to the upstream
> zstd sources is certainly a good thing, so I suppose sooner or later we
> will want to follow them in doing so.
>=20
> 1: xz: add fall-through comments to a switch statement
> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
> 3: decompressors: fix spelling mistakes
> 4: xz: avoid overlapping memcpy() with invalid input with in-place decomp=
ression
> 5: xz: fix spelling in comments
> 6: xz: move s->lzma.len =3D 0 initialization to lzma_reset()
> 7: xz: validate the value before assigning it to an enum variable
>=20

For the whole serie

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 15:51:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 15:51:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237797.412397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAqH-0001LW-GJ; Fri, 03 Dec 2021 15:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237797.412397; Fri, 03 Dec 2021 15:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAqH-0001LP-DP; Fri, 03 Dec 2021 15:51:21 +0000
Received: by outflank-mailman (input) for mailman id 237797;
 Fri, 03 Dec 2021 15:51:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mtAqF-0001LJ-Vp
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 15:51:19 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d9d5ce9c-5450-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 16:51:18 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35120)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mtAq9-000XjX-6i (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 15:51:13 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CD5BF1FC17;
 Fri,  3 Dec 2021 15:51:12 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d9d5ce9c-5450-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <9aa6f7bc-225b-3c52-acb7-8676d7dd52a0@srcf.net>
Date: Fri, 3 Dec 2021 15:51:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net>
 <0418bdcc-62eb-3d98-1c1a-6b1af0f75d00@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <0418bdcc-62eb-3d98-1c1a-6b1af0f75d00@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 12:50, Jan Beulich wrote:
> On 03.12.2021 12:21, Andrew Cooper wrote:
>> On 03/12/2021 10:56, Jan Beulich wrote:
>>> When it was introduced, it was imo placed way too high up, making it
>>> necessary to forward-declare way too many static functions. Move it down
>>> together with
>>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>>   immediately ahead of the #include,
>>> - blexit(), because of its use of the efi_arch_blexit() hook.
>>> Move up get_value() and set_color() to before the inclusion so their
>>> forward declarations can also be zapped.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Why does blexit() need moving?  It isn't static, and has a real
>> prototype in efi.h
> Correct, but the movement is for the functions it uses from efi-boot.h:
> efi_arch_halt() and efi_arch_blexit() at least (which actually the
> commit message also says, for one of the two at least).

Ah ok.


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 15:54:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 15:54:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237804.412409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAt4-0001zP-Un; Fri, 03 Dec 2021 15:54:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237804.412409; Fri, 03 Dec 2021 15:54:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtAt4-0001zI-Rc; Fri, 03 Dec 2021 15:54:14 +0000
Received: by outflank-mailman (input) for mailman id 237804;
 Fri, 03 Dec 2021 15:54:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=eKMT=QU=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1mtAt3-0001zA-R3
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 15:54:13 +0000
Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr
 [80.12.242.129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4245f965-5451-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 16:54:12 +0100 (CET)
Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id tAszmOO0S2lVYtAszm6OyC; Fri, 03 Dec 2021 16:54:12 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4245f965-5451-11ec-976b-d102b41d0961
X-ME-Helo: [192.168.1.18]
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Fri, 03 Dec 2021 16:54:12 +0100
X-ME-IP: 86.243.171.122
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
To: Joe Perches <joe@perches.com>, Juergen Gross <jgross@suse.com>,
 boris.ostrovsky@oracle.com, sstabellini@kernel.org, roger.pau@citrix.com,
 axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
Date: Fri, 3 Dec 2021 16:54:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Le 03/12/2021 à 04:03, Joe Perches a écrit :
> On Thu, 2021-12-02 at 20:07 +0100, Christophe JAILLET wrote:
>> Le 02/12/2021 à 19:16, Joe Perches a écrit :
>>> On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
>>>> Le 02/12/2021 à 07:12, Juergen Gross a écrit :
>>>>> On 01.12.21 22:10, Christophe JAILLET wrote:
>>>>>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
>>>>>> some open-coded arithmetic in allocator arguments.
>>>>>>
>>>>>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>>>>>> consistency.
>>>>>>
>>>>>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
>>> []
>>>>>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>>> []
>>>>>> @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int
>>>>>> minor, unsigned int nr)
>>>>>>         if (end > nr_minors) {
>>>>>>             unsigned long *bitmap, *old;
>>>>>> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
>>>>>> -                 GFP_KERNEL);
>>>>>> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>>>>>>             if (bitmap == NULL)
>>>>>>                 return -ENOMEM;
>>>>>>             spin_lock(&minor_lock);
>>>>>>             if (end > nr_minors) {
>>>>>>                 old = minors;
>>>>>> -            memcpy(bitmap, minors,
>>>>>> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
>>>>>> +            bitmap_copy(bitmap, minors, nr_minors);
>>>>>>                 minors = bitmap;
>>>>>>                 nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
>>>
>>> 		nr_minors = end;
>>> ?
>>>
>>
>> No,
>> My understanding of the code is that if we lack space (end > nr_minors),
>> we need to allocate more. In such a case, we want to keep track of what
>> we have allocated, not what we needed.
>> The "padding" bits in the "long align" allocation, can be used later.
> 
>>
>> first call
>> ----------
>> end = 65
>> nr_minors = 63
>>
>> --> we need some space
>> --> we allocate 2 longs = 128 bits
>> --> we now use 65 bits of these 128 bits
> 
> or 96, 32 or 64 bit longs remember.

32 and 64 for sure, but I was not aware of 96. On which arch?

> 
>>
>> new call
>> --------
>> end = 68
>> nr_minors = 128 (from previous call)
> 
> The initial allocation is now bitmap_zalloc which
> specifies only bits and the nr_minors is then in
> BITS_TO_LONGS(bits) * BITS_PER_LONG
> 
> Perhaps that assumes too much about the internal
> implementation of bitmap_alloc
> 
> 

I get your point now, and I agree with you.

Maybe something as what is done in mc-entity.c?
Explicitly require more bits (which will be allocated anyway), instead 
of taking advantage (read "hoping") that it will be done.

Could be:

@@ -440,26 +440,25 @@ static int xlbd_reserve_minors(unsigned int minor, 
unsigned int nr)
  	int rc;

  	if (end > nr_minors) {
  		unsigned long *bitmap, *old;

-		bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
-				 GFP_KERNEL);
+		end = ALIGN(end, BITS_PER_LONG);
+		bitmap = bitmap_zalloc(end, GFP_KERNEL);
  		if (bitmap == NULL)
  			return -ENOMEM;

  		spin_lock(&minor_lock);
  		if (end > nr_minors) {
  			old = minors;
-			memcpy(bitmap, minors,
-			       BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
+			bitmap_copy(bitmap, minors, nr_minors);
  			minors = bitmap;
-			nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
+			nr_minors = end;
  		} else
  			old = bitmap;
  		spin_unlock(&minor_lock);
-		kfree(old);
+		bitmap_free(old);
  	}

  	spin_lock(&minor_lock);
  	if (find_next_bit(minors, end, minor) >= end) {
  		bitmap_set(minors, minor, nr);
@@ -2608,11 +2607,11 @@ static void __exit xlblk_exit(void)
  {
  	cancel_delayed_work_sync(&blkfront_work);

  	xenbus_unregister_driver(&blkfront_driver);
  	unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
-	kfree(minors);
+	bitmap_free(minors);
  }
  module_exit(xlblk_exit);

  MODULE_DESCRIPTION("Xen virtual block device frontend");
  MODULE_LICENSE("GPL");




From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:10:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:10:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237814.412439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB97-0005dl-Qr; Fri, 03 Dec 2021 16:10:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237814.412439; Fri, 03 Dec 2021 16:10:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB97-0005dX-MQ; Fri, 03 Dec 2021 16:10:49 +0000
Received: by outflank-mailman (input) for mailman id 237814;
 Fri, 03 Dec 2021 16:10:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BQRQ=QU=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mtB95-0005N2-Vx
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:10:48 +0000
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com
 [2607:f8b0:4864:20::430])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92c37a01-5453-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 17:10:47 +0100 (CET)
Received: by mail-pf1-x430.google.com with SMTP id o4so3300734pfp.13
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 08:10:47 -0800 (PST)
Received: from [10.11.23.113] (wsip-24-120-54-60.lv.lv.cox.net. [24.120.54.60])
 by smtp.gmail.com with ESMTPSA id w19sm2713866pjh.10.2021.12.03.08.10.45
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 08:10:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92c37a01-5453-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:references:from:in-reply-to
         :content-transfer-encoding;
        bh=XoL6Grb/bJtvvyOFRBlLY63JKkRh7VeY4v7ZnbbCBGc=;
        b=SOJ9rHCIYoJDRrUPHbyhGDiYgj+aySuB4y+E/XCdhYGTrFwsF33KPzFqQ3hZv5IWko
         +TuSKC4S6vNYpqWr7C8qXvonSErwcyLHUjHdjPF9QA9bfrIPBssnXrCdV2NqTEInCmLV
         aeLD3da2lrR/YyXVN9qOL7mXx3WeODtEsfNRbFhrSmqzoGIYZc5pKUZXWSQpS0q9wEpH
         QDGjitscNjuDF2reREItCqYWzzL4nvA54zGmLtepve/KOADCPu1zKg3j59QFDWCumuFZ
         CKQwLVrjVoy820JjJ7So5sTjY1VTlgZx6crjGqXHVzqF/jH8LcvdgYhkk8LIriNP2nVV
         vrAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:references:from:in-reply-to
         :content-transfer-encoding;
        bh=XoL6Grb/bJtvvyOFRBlLY63JKkRh7VeY4v7ZnbbCBGc=;
        b=eSntKCmqoC6Y93LB31NaMtyukdDSwjkCTfw+uIaTPjXlNy+X6Zukb8WYnk5KsPItEm
         0jhry54Y+jKqknLr+nMZWHHtl6wL0I6vERFwlsf1Fy8xWzT5ukUXimtRht9h2XuDosEF
         jUaDt593xOkgSrIX2l+uJzcjlY4n3OWo2fRLBEHxBEIF3TJSwlE8xqE2hQ1eZrE/3KGr
         ITyvAFgGEiqj4YoI225m7Ll/PZrZWcj5o8kMj2aFsoarxu0ymynSXTmZnpc6UcKc8vug
         Z2gLnS1NtHVon1RBfD9ZOBuFnFLQno+fcefSqTiYyXENQaWbXFRLNtYg0Eo1sDNRAUPV
         aitw==
X-Gm-Message-State: AOAM531qLlWcukROFYW8DLE8yZhhKKnnn3Z9x6sOehj6yrqIIE5z/+nk
	Q3PqdRL38YWVBwM6JinSbBDIxltQ8aL/UQ==
X-Google-Smtp-Source: ABdhPJx08RY05QSK05UPhcxaDTteUlpF6rLSoyl/NUtBTZOTZsPu9PiBsb1TbIMex8WKD+j4C1lw0g==
X-Received: by 2002:a65:5ccb:: with SMTP id b11mr5039148pgt.408.1638547845685;
        Fri, 03 Dec 2021 08:10:45 -0800 (PST)
Message-ID: <9647b586-e325-0d3a-3369-e3b13e45af9d@gmail.com>
Date: Fri, 3 Dec 2021 08:10:44 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: [PATCH v7 6/7] xen/arm: process pending vPCI map/unmap operations
Content-Language: en-US
To: xen-devel@lists.xenproject.org
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-7-andr2000@gmail.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20211124075942.2645445-7-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 23/11/2021 23:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vPCI may map and unmap PCI device memory (BARs) being passed through which
> may take a lot of time. For this those operations may be deferred to be
> performed later, so that they can be safely preempted.
> 
> Currently this deferred processing is happening in common IOREQ code
> which doesn't seem to be the right place for x86 and is even more
> doubtful because IOREQ may not be enabled for Arm at all.
> So, for Arm the pending vPCI work may have no chance to be executed
> if the processing is left as is in the common IOREQ code only.
> For that reason make vPCI processing happen in arch specific code.
> 
> Please be aware that there are a few outstanding TODOs affecting this
> code path, see xen/drivers/vpci/header.c:map_range and
> xen/drivers/vpci/header.c:vpci_process_pending.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> [x86 part]
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:10:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:10:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237813.412428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB93-0005NH-Hk; Fri, 03 Dec 2021 16:10:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237813.412428; Fri, 03 Dec 2021 16:10:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB93-0005NA-Eg; Fri, 03 Dec 2021 16:10:45 +0000
Received: by outflank-mailman (input) for mailman id 237813;
 Fri, 03 Dec 2021 16:10:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/Fj5=QU=perches.com=joe@srs-se1.protection.inumbo.net>)
 id 1mtB91-0005N2-PO
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:10:43 +0000
Received: from smtprelay.hostedemail.com (smtprelay0009.hostedemail.com
 [216.40.44.9]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f59a762-5453-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 17:10:41 +0100 (CET)
Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
 by smtprelay05.hostedemail.com (Postfix) with ESMTP id 0E2FB180AF868;
 Fri,  3 Dec 2021 16:10:40 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by
 omf12.hostedemail.com (Postfix) with ESMTPA id 564242D; 
 Fri,  3 Dec 2021 16:10:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f59a762-5453-11ec-976b-d102b41d0961
Message-ID: <737d7d96deec73039699d62cd42b26b8862ae373.camel@perches.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Juergen Gross
	 <jgross@suse.com>, boris.ostrovsky@oracle.com, sstabellini@kernel.org, 
	roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Date: Fri, 03 Dec 2021 08:10:37 -0800
In-Reply-To: <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
References: 
	<1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
	 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
	 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
	 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
	 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
	 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
	 <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Rspamd-Queue-Id: 564242D
X-Spam-Status: No, score=-4.90
X-Stat-Signature: skzu1e47gn4yh4br1u6yk3izt6hqdaja
X-Rspamd-Server: rspamout03
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX1/Cp6pUluPgKVCI9lR+/9PfIk4J2JPI1hA=
X-HE-Tag: 1638547838-500636

On Fri, 2021-12-03 at 16:54 +0100, Christophe JAILLET wrote:
> Le 03/12/2021 � 04:03, Joe Perches a �crit�:
> > On Thu, 2021-12-02 at 20:07 +0100, Christophe JAILLET wrote:
> > > Le 02/12/2021 � 19:16, Joe Perches a �crit�:
> > > > On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
> > > > > Le 02/12/2021 � 07:12, Juergen Gross a �crit�:
> > > > > > On 01.12.21 22:10, Christophe JAILLET wrote:
> > > > > > > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
> > > > > > > some open-coded arithmetic in allocator arguments.
> > > > > > > 
> > > > > > > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > > > > > > consistency.
> > > > > > > 
> > > > > > > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> > > > []
> > > > > > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> > > > []
> > > > > > > @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int
> > > > > > > minor, unsigned int nr)
> > > > > > >   ����� if (end > nr_minors) {
> > > > > > >   ��������� unsigned long *bitmap, *old;
> > > > > > > -������� bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> > > > > > > -���������������� GFP_KERNEL);
> > > > > > > +������� bitmap = bitmap_zalloc(end, GFP_KERNEL);
> > > > > > >   ��������� if (bitmap == NULL)
> > > > > > >   ������������� return -ENOMEM;
> > > > > > >   ��������� spin_lock(&minor_lock);
> > > > > > >   ��������� if (end > nr_minors) {
> > > > > > >   ������������� old = minors;
> > > > > > > -����������� memcpy(bitmap, minors,
> > > > > > > -������������������ BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
> > > > > > > +����������� bitmap_copy(bitmap, minors, nr_minors);
> > > > > > >   ������������� minors = bitmap;
> > > > > > >   ������������� nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
> > > > 
> > > > 		nr_minors = end;
> > > > ?
> > > > 
> > > 
> > > No,
> > > My understanding of the code is that if we lack space (end > nr_minors),
> > > we need to allocate more. In such a case, we want to keep track of what
> > > we have allocated, not what we needed.
> > > The "padding" bits in the "long align" allocation, can be used later.
> > 
> > > 
> > > first call
> > > ----------
> > > end = 65
> > > nr_minors = 63
> > > 
> > > --> we need some space
> > > --> we allocate 2 longs = 128 bits
> > > --> we now use 65 bits of these 128 bits
> > 
> > or 96, 32 or 64 bit longs remember.
> 
> 32 and 64 for sure, but I was not aware of 96. On which arch?

For more clarity that should have been a period instead of comma after 96.


> > The initial allocation is now bitmap_zalloc which
> > specifies only bits and the nr_minors is then in
> > BITS_TO_LONGS(bits) * BITS_PER_LONG
> > 
> > Perhaps that assumes too much about the internal
> > implementation of bitmap_alloc
> 
> I get your point now, and I agree with you.
> 
> Maybe something as what is done in mc-entity.c?
> Explicitly require more bits (which will be allocated anyway), instead 
> of taking advantage (read "hoping") that it will be done.

Sure, that's sensible.

> Could be:
> 
> @@ -440,26 +440,25 @@ static int xlbd_reserve_minors(unsigned int minor, 
> unsigned int nr)
>   	int rc;
> 
>   	if (end > nr_minors) {
>   		unsigned long *bitmap, *old;
> 
> -		bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> -				 GFP_KERNEL);
> +		end = ALIGN(end, BITS_PER_LONG);

Though it may be more sensible to use some other alignment
like round_up and not use BITS_PER_LONG at all as the
number of these may not be dependent on 32/64 bit arches
at all.

Maybe something like:

#define GROW_MINORS	64

		end = round_up(nr_minors, GROW_MINORS);

etc...



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:11:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:11:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237815.412450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB9J-00061o-1o; Fri, 03 Dec 2021 16:11:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237815.412450; Fri, 03 Dec 2021 16:11:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB9I-00061h-Us; Fri, 03 Dec 2021 16:11:00 +0000
Received: by outflank-mailman (input) for mailman id 237815;
 Fri, 03 Dec 2021 16:10:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sOtX=QU=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mtB9H-0005Mw-AF
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:10:59 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0617.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::617])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 98fe7aec-5453-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 17:10:57 +0100 (CET)
Received: from AS9PR06CA0082.eurprd06.prod.outlook.com (2603:10a6:20b:464::31)
 by AM6PR08MB5048.eurprd08.prod.outlook.com (2603:10a6:20b:ee::31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 16:10:54 +0000
Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:464:cafe::97) by AS9PR06CA0082.outlook.office365.com
 (2603:10a6:20b:464::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 16:10:54 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 16:10:54 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Fri, 03 Dec 2021 16:10:53 +0000
Received: from 786644f4d708.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C4C4DF0D-9EDB-4F2D-8FA6-ABC070EE50B3.1; 
 Fri, 03 Dec 2021 16:10:40 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 786644f4d708.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 16:10:40 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6848.eurprd08.prod.outlook.com (2603:10a6:102:132::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Fri, 3 Dec
 2021 16:10:38 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb%6]) with mapi id 15.20.4690.034; Fri, 3 Dec 2021
 16:10:37 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Fri, 3 Dec 2021 16:10:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98fe7aec-5453-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1qA4duZcbz/voKu+ZvOyNrnRJAO2jf+E917ADEEEhbk=;
 b=Aai+yfqi0bSiyAluC/Gkh1HB5zomGX9COWaxALOYhGJunttn7G7GJPPNQ6gxgnz5m67+fwSjXOCdlaGWtnYdJuFxzGmkYy1Wdqn3kBAYJmaiq0an9/kBupPWkpc3AI/2SEX4CKEm/Bi83FI9nmS3E3vIUFjHhjlluw8QdJiwbVE=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6b4ab85f767c3478
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HAWgdu/QP22UL0npSSywoU4DA3FMZnf0NeUBrRvk/c3ABVDKUi/thphtCXAcvII9+zIVJXfLP+fzLl8j9jwqc6A0tjjlAvWRMqGrxH5HU0G3AjI1ljXi+bE/kNzk+c5oosBx9/ZoBl2lBx1tx67WRxrUZmCW0pwtDy0eu7QTbaysvwKHuLSS/vWhdMHqn7An/Be2b9TV5pgw5/HAD7vLch7anYi9ncnytN5bsCaWhEtz4Y1rgcsa804mG7Sje+odU0UTUKiwAHvG/GAg1H/rRN34phW24Pekgm3k2n4gN3jAgY+u+s/f9eyAdZS9tTxWQw+9ve3d75IvCEuJeIWoLg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1qA4duZcbz/voKu+ZvOyNrnRJAO2jf+E917ADEEEhbk=;
 b=NA79mNCAtt/2iWTsOJBw33QWUikQSWJdh16PICAnTlHHLCbz7k+8FoB+bpxAiuRRsv4dkqYGioUmMJdHpW+wzicRlcVXh5AdZdm7mViYiC8gy1+4/376vlm389/vG494FBjdYvf7gNxLPpmWeWohbtzvFF4ECdRr1DSI0joIEe8cmF8n+drqjjgHHDgah/Lee6KWU5EzKrCw7il5GtZP+eljqrzMDzRKQVqGbqIBW3x8iPaBIdc1iAgYmi9cawhCPKniJsdKgiuPGMRE/K/2ZTPhOziqDgfo4spbNMT3uyDNdTcP7uqLn7HQHAO+R5kLYPb8XXYiePmutnwKYzr++Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1qA4duZcbz/voKu+ZvOyNrnRJAO2jf+E917ADEEEhbk=;
 b=Aai+yfqi0bSiyAluC/Gkh1HB5zomGX9COWaxALOYhGJunttn7G7GJPPNQ6gxgnz5m67+fwSjXOCdlaGWtnYdJuFxzGmkYy1Wdqn3kBAYJmaiq0an9/kBupPWkpc3AI/2SEX4CKEm/Bi83FI9nmS3E3vIUFjHhjlluw8QdJiwbVE=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
Date: Fri, 3 Dec 2021 16:10:35 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F1FE39BE-191B-4245-84EE-1109B9762B54@arm.com>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::18) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99dab915-204e-45ac-0c0d-08d9b6777bad
X-MS-TrafficTypeDiagnostic: PAXPR08MB6848:|AM6PR08MB5048:
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB5048924D68FAA0AD6332360FE46A9@AM6PR08MB5048.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1079;OLM:1079;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 TxHu5vpRt2FdB6GmdYbHS6FwhFbHAsl26boh5ygQ3jg+d4gPBiVUAApnSqvGWCh3ooJ4rTVDRBdEqOkD2t2kyOVmruAyWGn3y82zgeLfLtYIwEOFHumYPoxyaNtmGsPZuPLNvIN3YqAKbK0HVThSltBgKOsc0r+XDjXthsmdxT8DQhERh4pjXpi74w3a3o+X1El1ukmse2eyDE028251vxn78rW3FSrp1A5kOrbpk1jur64h3itDrRhdw2ojVyIabNmEok49KESQszwCUWzrJATzYvVOpjAnkPGP+VStRPfjJ2P6brRByIttiPMga7k85P4dpFEvBQMafZPq2c6JL97E8QbxM7ikF2idf38cVHrCtj4gT1F8dRUG38ZN6CONPdNpu374ckxp6aeQt3RKFZeYq4ndw7vu/j8ODSmdAsMlQTzQBUqyZULoJRHfbWO51BPkNtb7EnfXNUdW4cLwh9v2offx/8fPIF75pHcUjycamfjZTcy2S/Pb2g1iM2qLQW7CiriFzFzdibz40h68MfqNhqVfTs89aSKcQIyhBkXi/pqlw3vafifHfzaS3UdWtER/93wfDiKLYTmpYHgQ0v0efIBBOeDbc2AkuolziZZL/nkFXYiwzROWvjnwNW0zTjZYr9SDrou5wbD23SJMXTytCqj/N6Q+gw3u5ULrVgbeuYMybwHvO/TvFDcWkoAl7ixzyZZKyGXRcrmJ/ltWzWRb5NaeKeOsgQhaL3zpQ5z/2vc+4BGMx17Z50I4sOZt
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(8676002)(5660300002)(54906003)(86362001)(66946007)(66476007)(6916009)(6512007)(186003)(6486002)(52116002)(66556008)(44832011)(4326008)(83380400001)(36756003)(2906002)(26005)(38350700002)(2616005)(8936002)(33656002)(956004)(508600001)(6506007)(38100700002)(53546011)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6848
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	452fddf9-8aa8-45da-e943-08d9b6777194
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MQGy1+zvQfmYXdZUlrzLMiQL4a/zTDrfXxibQ5kIeF693jHH+jtdHYNGfnGL5+Rt9VM4x2A6lz+zT+O79hRzFj4NZCnY+Q04fzro0V2ooZE3UTDTgsqpk7uD1/yUvjXGOae0eJjz7fCgSP413FvmvHDgEwB8bMOqpVGeKcYUmuhlmSHvGYFyfiGZh0APDgO4PYiRqjkTDo2izjdJ3//hyZ34Zmk5qe8me0IukrLx+T1MWAxD7UuT1COb1VI/3zE3goshEO+6qB0kblICjCZCp9Ljuzprrq7SlBXTNAA16C/76GubIPeTPWVVfriqzj/5DTNeHw1rtxff7o5KW0j3UUQ7MC5Q4zaytW0uUPrJpCzlRlOQt4GTgLjUVVfMttC352hGAYtQhWmwMUsIBo3bMO3WMIo231qu1Esu5NdfF233a7OuH8CpveYTXOGMBk8w6XxJC38HMaX6P6TcbIiM2EfPbKq27y6gopAsUiV0xt3CCLNo2dZ3fpUvozU8eLVZcqzaY6qoDrx8sSUPlaIKCctFQZpcMweQTuiMKbAIe53UA5gh4890mh2JZyLz4/DzbnIIfyi4iOSJbcIUHwWR7HPlqIt+SuFySQ4nQiYhSo2oMiWgK0aaMJI0/laqrbpX392wEX1XJ5yI8qURZeZHBcNAhn+p/+aOW8YbAHtplLVhdSqfmf4FDXq8CXOHY700dUX+vmlViTqtK3UlRQEODw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(508600001)(186003)(81166007)(6862004)(336012)(2616005)(86362001)(36860700001)(44832011)(82310400004)(6512007)(54906003)(2906002)(956004)(26005)(70586007)(70206006)(33656002)(8936002)(36756003)(316002)(5660300002)(8676002)(53546011)(6486002)(6506007)(356005)(47076005)(83380400001)(4326008);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 16:10:54.0530
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 99dab915-204e-45ac-0c0d-08d9b6777bad
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5048



> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> When it was introduced, it was imo placed way too high up, making it
> necessary to forward-declare way too many static functions. Move it down
> together with
> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>  immediately ahead of the #include,
> - blexit(), because of its use of the efi_arch_blexit() hook.
> Move up get_value() and set_color() to before the inclusion so their
> forward declarations can also be zapped.
>=20

With the =E2=80=9Cconst=E2=80=9D attribute now some function in this serie =
are above the char line
limit, however everything looks fine.

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -111,25 +111,10 @@ struct file {
>     };
> };
>=20
> -static CHAR16 *FormatDec(UINT64 Val, CHAR16 *Buffer);
> -static CHAR16 *FormatHex(UINT64 Val, UINTN Width, CHAR16 *Buffer);
> -static void  DisplayUint(UINT64 Val, INTN Width);
> -static CHAR16 *wstrcpy(CHAR16 *d, const CHAR16 *s);
> -static void PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode);
> -static char *get_value(const struct file *cfg, const char *section,
> -                              const char *item);
> -static char *split_string(char *s);
> -static CHAR16 *s2w(union string *str);
> -static char *w2s(const union string *str);
> -static EFI_FILE_HANDLE get_parent_handle(EFI_LOADED_IMAGE *loaded_image,
> -                                         CHAR16 **leaf);
> static bool read_file(EFI_FILE_HANDLE dir_handle, CHAR16 *name,
>                       struct file *file, const char *options);
> static bool read_section(const EFI_LOADED_IMAGE *image, const CHAR16 *nam=
e,
>                          struct file *file, const char *options);
> -static size_t wstrlen(const CHAR16 * s);
> -static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz);
> -static bool match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2);
>=20
> static void efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTabl=
e);
> static void efi_console_set_mode(void);
> @@ -168,19 +153,6 @@ static void __init PrintErr(const CHAR16
>     StdErr->OutputString(StdErr, (CHAR16 *)s );
> }
>=20
> -#ifndef CONFIG_HAS_DEVICE_TREE
> -static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
> -{
> -    return 0;
> -}
> -#endif
> -
> -/*
> - * Include architecture specific implementation here, which references t=
he
> - * static globals defined above.
> - */
> -#include "efi-boot.h"
> -
> static CHAR16 *__init FormatDec(UINT64 Val, CHAR16 *Buffer)
> {
>     if ( Val >=3D 10 )
> @@ -291,30 +263,6 @@ static bool __init match_guid(const EFI_
>            !memcmp(guid1->Data4, guid2->Data4, sizeof(guid1->Data4));
> }
>=20
> -void __init noreturn blexit(const CHAR16 *str)
> -{
> -    if ( str )
> -        PrintStr(str);
> -    PrintStr(newline);
> -
> -    if ( !efi_bs )
> -        efi_arch_halt();
> -
> -    if ( cfg.need_to_free )
> -        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
> -    if ( kernel.need_to_free )
> -        efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size));
> -    if ( ramdisk.need_to_free )
> -        efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size));
> -    if ( xsm.need_to_free )
> -        efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size));
> -
> -    efi_arch_blexit();
> -
> -    efi_bs->Exit(efi_ih, EFI_SUCCESS, 0, NULL);
> -    unreachable(); /* not reached */
> -}
> -
> /* generic routine for printing error messages */
> static void __init PrintErrMesg(const CHAR16 *mesg, EFI_STATUS ErrCode)
> {
> @@ -542,6 +490,7 @@ static CHAR16 *__init point_tail(CHAR16
>             break;
>         }
> }
> +
> /*
>  * Truncate string at first space, and return pointer
>  * to remainder of string, if any/ NULL returned if
> @@ -559,6 +508,95 @@ static char * __init split_string(char *
>     return NULL;
> }
>=20
> +static char *__init get_value(const struct file *cfg, const char *sectio=
n,
> +                              const char *item)
> +{
> +    char *ptr =3D cfg->str, *end =3D ptr + cfg->size;
> +    size_t slen =3D section ? strlen(section) : 0, ilen =3D strlen(item)=
;
> +    bool match =3D !slen;
> +
> +    for ( ; ptr < end; ++ptr )
> +    {
> +        switch ( *ptr )
> +        {
> +        case 0:
> +            continue;
> +        case '[':
> +            if ( !slen )
> +                break;
> +            if ( match )
> +                return NULL;
> +            match =3D strncmp(++ptr, section, slen) =3D=3D 0 && ptr[slen=
] =3D=3D ']';
> +            break;
> +        default:
> +            if ( match && strncmp(ptr, item, ilen) =3D=3D 0 && ptr[ilen]=
 =3D=3D '=3D' )
> +            {
> +                ptr +=3D ilen + 1;
> +                /* strip off any leading spaces */
> +                while ( *ptr && isspace(*ptr) )
> +                    ptr++;
> +                return ptr;
> +            }
> +            break;
> +        }
> +        ptr +=3D strlen(ptr);
> +    }
> +    return NULL;
> +}
> +
> +static int __init __maybe_unused set_color(uint32_t mask, int bpp,
> +                                           uint8_t *pos, uint8_t *sz)
> +{
> +   if ( bpp < 0 )
> +       return bpp;
> +   if ( !mask )
> +       return -EINVAL;
> +   for ( *pos =3D 0; !(mask & 1); ++*pos )
> +       mask >>=3D 1;
> +   for ( *sz =3D 0; mask & 1; ++*sz)
> +       mask >>=3D 1;
> +   if ( mask )
> +       return -EINVAL;
> +   return max(*pos + *sz, bpp);
> +}
> +
> +#ifndef CONFIG_HAS_DEVICE_TREE
> +static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
> +{
> +    return 0;
> +}
> +#endif
> +
> +/*
> + * Include architecture specific implementation here, which references t=
he
> + * static globals defined above.
> + */
> +#include "efi-boot.h"
> +
> +void __init noreturn blexit(const CHAR16 *str)
> +{
> +    if ( str )
> +        PrintStr(str);
> +    PrintStr(newline);
> +
> +    if ( !efi_bs )
> +        efi_arch_halt();
> +
> +    if ( cfg.need_to_free )
> +        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));
> +    if ( kernel.need_to_free )
> +        efi_bs->FreePages(kernel.addr, PFN_UP(kernel.size));
> +    if ( ramdisk.need_to_free )
> +        efi_bs->FreePages(ramdisk.addr, PFN_UP(ramdisk.size));
> +    if ( xsm.need_to_free )
> +        efi_bs->FreePages(xsm.addr, PFN_UP(xsm.size));
> +
> +    efi_arch_blexit();
> +
> +    efi_bs->Exit(efi_ih, EFI_SUCCESS, 0, NULL);
> +    unreachable(); /* not reached */
> +}
> +
> static void __init handle_file_info(const CHAR16 *name,
>                                     const struct file *file, const char *=
options)
> {
> @@ -685,42 +723,6 @@ static void __init pre_parse(const struc
>                    " last line will be ignored.\r\n");
> }
>=20
> -static char *__init get_value(const struct file *cfg, const char *sectio=
n,
> -                              const char *item)
> -{
> -    char *ptr =3D cfg->str, *end =3D ptr + cfg->size;
> -    size_t slen =3D section ? strlen(section) : 0, ilen =3D strlen(item)=
;
> -    bool match =3D !slen;
> -
> -    for ( ; ptr < end; ++ptr )
> -    {
> -        switch ( *ptr )
> -        {
> -        case 0:
> -            continue;
> -        case '[':
> -            if ( !slen )
> -                break;
> -            if ( match )
> -                return NULL;
> -            match =3D strncmp(++ptr, section, slen) =3D=3D 0 && ptr[slen=
] =3D=3D ']';
> -            break;
> -        default:
> -            if ( match && strncmp(ptr, item, ilen) =3D=3D 0 && ptr[ilen]=
 =3D=3D '=3D' )
> -            {
> -                ptr +=3D ilen + 1;
> -                /* strip off any leading spaces */
> -                while ( *ptr && isspace(*ptr) )
> -                    ptr++;
> -                return ptr;
> -            }
> -            break;
> -        }
> -        ptr +=3D strlen(ptr);
> -    }
> -    return NULL;
> -}
> -
> static void __init efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Sys=
temTable)
> {
>     efi_ih =3D ImageHandle;
> @@ -1114,21 +1116,6 @@ static void __init efi_exit_boot(EFI_HAN
>     efi_fw_vendor =3D (void *)efi_fw_vendor + DIRECTMAP_VIRT_START;
> }
>=20
> -static int __init __maybe_unused set_color(u32 mask, int bpp, u8 *pos, u=
8 *sz)
> -{
> -   if ( bpp < 0 )
> -       return bpp;
> -   if ( !mask )
> -       return -EINVAL;
> -   for ( *pos =3D 0; !(mask & 1); ++*pos )
> -       mask >>=3D 1;
> -   for ( *sz =3D 0; mask & 1; ++*sz)
> -       mask >>=3D 1;
> -   if ( mask )
> -       return -EINVAL;
> -   return max(*pos + *sz, bpp);
> -}
> -
> void EFIAPI __init noreturn
> efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
> {
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:11:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:11:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237822.412461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB9t-0006zC-Hp; Fri, 03 Dec 2021 16:11:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237822.412461; Fri, 03 Dec 2021 16:11:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtB9t-0006z1-E4; Fri, 03 Dec 2021 16:11:37 +0000
Received: by outflank-mailman (input) for mailman id 237822;
 Fri, 03 Dec 2021 16:11:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sOtX=QU=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mtB9s-0005Mw-IN
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:11:36 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0620.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::620])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id afab47dd-5453-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 17:11:35 +0100 (CET)
Received: from AM5P194CA0024.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::34)
 by PAXPR08MB7490.eurprd08.prod.outlook.com (2603:10a6:102:2b7::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 16:11:32 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:203:8f:cafe::41) by AM5P194CA0024.outlook.office365.com
 (2603:10a6:203:8f::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Fri, 3 Dec 2021 16:11:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 16:11:32 +0000
Received: ("Tessian outbound c61f076cbd30:v110");
 Fri, 03 Dec 2021 16:11:32 +0000
Received: from 18801550ae52.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9422E206-035F-41FD-B36E-3728AEE7DAB6.1; 
 Fri, 03 Dec 2021 16:11:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 18801550ae52.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 16:11:15 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5802.eurprd08.prod.outlook.com (2603:10a6:102:8a::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 16:11:14 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb%6]) with mapi id 15.20.4690.034; Fri, 3 Dec 2021
 16:11:14 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Fri, 3 Dec 2021 16:11:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afab47dd-5453-11ec-b1df-f38ee3fbfdf7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zH3HvH4aM5H9UhOvfuZBtBMWLykdiyXiuBdAVWV3zSw=;
 b=YgBp+qhKJmhvBY2/v7LGaad31g7ARAS454CrENEBtdc/ieePv1d9AhBkVVQEBdabe36sqs77iEvy+6OSoXDAlilFUfAetaYz69Ht4Z+C1IQt4md14oRxGG6qNHf/I133222hUPbj05WetSrJetOF2bKBKgou2MB2AFCMs779AY4=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 8c5aa8ac2abbc702
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eAz1qZ8m9e8VCaM2aJpyDvDiAp0NibZ290K3JKjS4FtMutfU/r5lRoUZlK1y1mOZOXNX80jMX2d3KlB+1fMmv3g+wQ4XBMgtMpghfCU9I8VMl7UPYJ01vkdJAzQ7EWt5DdjQRvatAuOED9Dmzex+evHWpDWCINAUG5erJimrVupZw8X40GMZ6hyQuSYF8kkt9Bj24+Kr4tqI7QkvS4fyY0gdD4kCk9Ik7+OqA3FSrMgjE1QN2Qr2eZOaS5kcBF2PaG3SMEHTuMf4boRl4xNtxgQArdC3fhClcVTWH3HyGbbs1t1ZgY8C3NZW/xPDpWIVEEyswph20XnJSbv7CAi5+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zH3HvH4aM5H9UhOvfuZBtBMWLykdiyXiuBdAVWV3zSw=;
 b=IK/IsRNuTTzIR6IeD06r/c7sTYZdK27WOCVR9bD3KOe2QdmU+P65Vzs7GJnoBwSuHvR2dbZf/+1wWbN9Hr5jWULlONW4/b+qHyXI1980n+IeXb4D5hBlBzR7jZArqwk2dvUt/IDeCRYjx8+NmtWXrS9P2f/v6Cu3Z4zcNsbvh0qfJSZfkhY/tufW+UxIPKYu0ArlTzgPwH3J+Yz3oj1spPRf5rVHnHL/PLgGxYUD0zGhUHs5bhjd+cSD2/euT3LpigfHa/zuROgeo11+U+QcOX1CpAe7ZxJ/izhe93W4dSe11EZAUgPsF2VsphHh8NqsnhNIp6PNELlhGQy+f5ydjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zH3HvH4aM5H9UhOvfuZBtBMWLykdiyXiuBdAVWV3zSw=;
 b=YgBp+qhKJmhvBY2/v7LGaad31g7ARAS454CrENEBtdc/ieePv1d9AhBkVVQEBdabe36sqs77iEvy+6OSoXDAlilFUfAetaYz69Ht4Z+C1IQt4md14oRxGG6qNHf/I133222hUPbj05WetSrJetOF2bKBKgou2MB2AFCMs779AY4=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 2/3] EFI: constify EFI_LOADED_IMAGE * function parameters
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
Date: Fri, 3 Dec 2021 16:11:13 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5F73AA67-25D3-4E19-BE27-43B3DF4CF184@arm.com>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::18) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 93671c50-dc06-450d-08fe-08d9b6779289
X-MS-TrafficTypeDiagnostic: PR3PR08MB5802:|PAXPR08MB7490:
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB74903C1E9BAF329AD1A944D0E46A9@PAXPR08MB7490.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5BErYuuBVVGN87lPUavA8m7lnJljAQOF5kK+uPhEvbtabkxawfdfsTj8vmV2ztpC6V6Wwny5aK6GSM5CQhAVYuy1ayA0DYHn+NGY45JtohUHqT8ldagS+wdeSg0mZ1Hf0/imKG+4ajpWedt/T7Da7IlYtGWqJJekdZy48ab/VIkN8VzKBh57JepCi1yZx5HjiFTKFoAb81EkaqPpTypjp2kaaz886dyefOrmRQH53jEJqFglCi9o9/wNE0/MOf4HM3GGUrvwFPaEpgG8ifVgoo180S7p2OFl/61htc2+qtq0tkVFsEqqN5DM+Ohz1ND7TH1EVsKaX4q+7BG5+8UK6piWPrB6ktfGhd5jn+HwwtMejYTCJLZc8IN4rt+JG1e3dI3l+tQRcGjTAnNCJI7Qge+FPvP9FkfaGW7GIvdDbbxvI4js8cfhLJWLrtsIyfnR5Bj1JKwBzkIssDDJM8qHpU3KemE6UyQD/aw2p6HS43iyc0Q4uewDwLSqqr9e/7EIcbaGdzT/rpFf5HhgIVyWrphLzORKJHVAhLvpcpiuUMsPAXodk0ucog/pRBOPTSDfDI5uP0vYoZXCPKMCpPDTx1r7cDvKlUIWHyhUsywAiO8p+HH/bAZ0xEq6G2Gjl+w2Y461kPZujg/TZ0WdwqsI9iBIaZF7QYJZ7kZDVU8ji5/9Jd1O2dCmJiHEBrrAThXdBY1diC3UwCU5grmQT1V82xrfESfoMzhCH+gctyO39NE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(53546011)(2906002)(508600001)(6506007)(52116002)(26005)(6916009)(8936002)(956004)(316002)(5660300002)(2616005)(186003)(4326008)(44832011)(6486002)(66556008)(8676002)(66946007)(38350700002)(33656002)(66476007)(38100700002)(83380400001)(54906003)(86362001)(36756003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5802
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3cdcde03-5dc9-4873-174f-08d9b6778746
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gVK1KG9GJkop0+xiuYPCrbfflAIX0bAr0bFmkVUS3Ffj3o3ufQU+bMFTWEMJca7RffbLpKxxVHfHZXsKtT5o61mIYypUW89K2thsShC9FJUMpbwGUVjsM1paS1GM1YpsXBANNMfIRtZDz2XJgYsZxKXZ/XMYZibP/WGGN11ixCpaYbGAsZAHFQzOFnRc1VjudTERdFuEyl7RVXRB94bV0fllbT2tpUYjrKnQps2KZGNV586cc3eILXQTw7IcSTlVM1J2Agus5sl4y4UUG7Wcl5OX2vIgiUxpauSATZQlciE4FIEU7DOuZ2sLwGhpoT5Q4Ir7KNRnP3bj/V0JNu+7snQqAdXKoamnW+ZfmWYCAk74s2ZmhsAVEfrzTBffaU9Bg8UiOcScQEChhKyqGejPCctTaKUwg6wtXVyd1A+JNDt2OeYQ5Ko5PM4Nc0/CfaliSWrA6LcZatOOdwHSLIfahqmaALBPL78YrXfjTCgzmoAZ4G581A0lL4gCsFkngWe38hOQzBx3mCvcZ5xsp07e5xyw2dr+23Bzx7WBS4NmJK0n7UgzIzgiX+USSHe9zats1OUwVI7inWCbZe/gBK0pow95/jQszpXIqfqjxVkGSZ/yOskcZQZfnbRRER243FCNceFZjHqVD8Hb/89ZIhUbLB6NcEQXHYNnXgQ7iLmtjyOlBnkNxIQGeclcYRy8cg5JEwvz3EMOSSUoMoASD8joNA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(2616005)(6512007)(47076005)(36756003)(8936002)(356005)(81166007)(82310400004)(26005)(186003)(70586007)(86362001)(2906002)(33656002)(70206006)(44832011)(316002)(8676002)(5660300002)(6486002)(6506007)(6862004)(53546011)(36860700001)(336012)(4326008)(508600001)(956004)(83380400001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 16:11:32.4516
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 93671c50-dc06-450d-08fe-08d9b6779289
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7490



> On 3 Dec 2021, at 10:57, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> Instead of altering Arm's forward declarations, drop them. Like
> elsewhere we should limit such to cases where the first use lives ahead
> of the definition.
>=20

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -44,20 +44,6 @@ void __flush_dcache_area(const void *vad
>=20
> static int get_module_file_index(const char *name, unsigned int name_len)=
;
> static void PrintMessage(const CHAR16 *s);
> -static int allocate_module_file(EFI_LOADED_IMAGE *loaded_image,
> -                                EFI_FILE_HANDLE *dir_handle,
> -                                const char *name,
> -                                unsigned int name_len);
> -static int handle_module_node(EFI_LOADED_IMAGE *loaded_image,
> -                              EFI_FILE_HANDLE *dir_handle,
> -                              int module_node_offset,
> -                              int reg_addr_cells,
> -                              int reg_size_cells,
> -                              bool is_domu_module);
> -static int handle_dom0less_domain_node(EFI_LOADED_IMAGE *loaded_image,
> -                                       EFI_FILE_HANDLE *dir_handle,
> -                                       int domain_node);
> -static int efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image);
>=20
> #define DEVICE_TREE_GUID \
> {0xb1b621d5, 0xf19c, 0x41a5, {0x83, 0x0b, 0xd9, 0x15, 0x2c, 0x69, 0xaa, 0=
xe0}}
> @@ -650,7 +636,7 @@ static void __init PrintMessage(const CH
>  * This function allocates a binary and keeps track of its name, it retur=
ns the
>  * index of the file in the modules array or a negative number on error.
>  */
> -static int __init allocate_module_file(EFI_LOADED_IMAGE *loaded_image,
> +static int __init allocate_module_file(const EFI_LOADED_IMAGE *loaded_im=
age,
>                                        EFI_FILE_HANDLE *dir_handle,
>                                        const char *name,
>                                        unsigned int name_len)
> @@ -713,7 +699,7 @@ static int __init allocate_module_file(E
>  * for the reg property into the module DT node.
>  * Returns 1 if module is multiboot,module, 0 if not, < 0 on error
>  */
> -static int __init handle_module_node(EFI_LOADED_IMAGE *loaded_image,
> +static int __init handle_module_node(const EFI_LOADED_IMAGE *loaded_imag=
e,
>                                      EFI_FILE_HANDLE *dir_handle,
>                                      int module_node_offset,
>                                      int reg_addr_cells,
> @@ -814,7 +800,7 @@ static int __init handle_module_node(EFI
>  * in the DT.
>  * Returns number of multiboot,module found or negative number on error.
>  */
> -static int __init handle_dom0less_domain_node(EFI_LOADED_IMAGE *loaded_i=
mage,
> +static int __init handle_dom0less_domain_node(const EFI_LOADED_IMAGE *lo=
aded_image,
>                                               EFI_FILE_HANDLE *dir_handle=
,
>                                               int domain_node)
> {
> @@ -862,7 +848,7 @@ static int __init handle_dom0less_domain
>  * dom0 and domU guests to be loaded.
>  * Returns the number of multiboot modules found or a negative number for=
 error.
>  */
> -static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
> +static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image=
)
> {
>     int chosen, node, addr_len, size_len;
>     unsigned int i =3D 0, modules_found =3D 0;
> @@ -942,7 +928,7 @@ static void __init efi_arch_halt(void)
>     stop_cpu();
> }
>=20
> -static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_ima=
ge)
> +static void __init efi_arch_load_addr_check(const EFI_LOADED_IMAGE *load=
ed_image)
> {
>     if ( (unsigned long)loaded_image->ImageBase & ((1 << 12) - 1) )
>         blexit(L"Xen must be loaded at a 4 KByte boundary.");
> --- a/xen/arch/x86/efi/efi-boot.h
> +++ b/xen/arch/x86/efi/efi-boot.h
> @@ -709,7 +709,7 @@ static void __init efi_arch_halt(void)
>         halt();
> }
>=20
> -static void __init efi_arch_load_addr_check(EFI_LOADED_IMAGE *loaded_ima=
ge)
> +static void __init efi_arch_load_addr_check(const EFI_LOADED_IMAGE *load=
ed_image)
> {
>     xen_phys_start =3D (UINTN)loaded_image->ImageBase;
>     if ( (xen_phys_start + loaded_image->ImageSize - 1) >> 32 )
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -389,7 +389,7 @@ static unsigned int __init get_argv(unsi
>     return argc;
> }
>=20
> -static EFI_FILE_HANDLE __init get_parent_handle(EFI_LOADED_IMAGE *loaded=
_image,
> +static EFI_FILE_HANDLE __init get_parent_handle(const EFI_LOADED_IMAGE *=
loaded_image,
>                                                 CHAR16 **leaf)
> {
>     static EFI_GUID __initdata fs_protocol =3D SIMPLE_FILE_SYSTEM_PROTOCO=
L;
> @@ -561,7 +561,7 @@ static int __init __maybe_unused set_col
> }
>=20
> #ifndef CONFIG_HAS_DEVICE_TREE
> -static int __init efi_check_dt_boot(EFI_LOADED_IMAGE *loaded_image)
> +static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image=
)
> {
>     return 0;
> }
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:12:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:12:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237827.412472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBAP-0007cz-RG; Fri, 03 Dec 2021 16:12:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237827.412472; Fri, 03 Dec 2021 16:12:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBAP-0007cs-ND; Fri, 03 Dec 2021 16:12:09 +0000
Received: by outflank-mailman (input) for mailman id 237827;
 Fri, 03 Dec 2021 16:12:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sOtX=QU=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mtBAO-0007cV-LD
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:12:08 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0624.outbound.protection.outlook.com
 [2a01:111:f400:fe06::624])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c26daed1-5453-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 17:12:07 +0100 (CET)
Received: from AM6P192CA0013.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::26)
 by AM5PR0802MB2433.eurprd08.prod.outlook.com (2603:10a6:203:9f::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 3 Dec
 2021 16:12:04 +0000
Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::65) by AM6P192CA0013.outlook.office365.com
 (2603:10a6:209:83::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Fri, 3 Dec 2021 16:12:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 16:12:04 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Fri, 03 Dec 2021 16:12:03 +0000
Received: from a11e18501705.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D91C490B-C7A6-43E4-B14C-56C23BBBF470.1; 
 Fri, 03 Dec 2021 16:11:47 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a11e18501705.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 16:11:47 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PR3PR08MB5802.eurprd08.prod.outlook.com (2603:10a6:102:8a::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec
 2021 16:11:45 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb%6]) with mapi id 15.20.4690.034; Fri, 3 Dec 2021
 16:11:45 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Fri, 3 Dec 2021 16:11:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c26daed1-5453-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zCRiyhMnjTaYecQ/DEDtokAnrGVsW8nWixQd2afqiQ0=;
 b=AWADUkJxY6h6eWVgyDxudmNSChQ1DSOS6JVQOCu8/CxCwpeJhA5dETtto2vRyfkRfGxt04X9YD7AQJY2cRGHZMuUQjgv6KbWKA8/83Kc6NfDjqafAIjF7eKaKmngE+uPmHvvNvcf2M/YZTMUJFy5GqNbEhDcdVsGhcg6Ig5FqnQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 819b9da4436ebf44
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DjFhRPYCBs3HW//WGPCjgLhg5GpSA+dxT0npvJ7PkwxlS9v/1xHU2qbQJqD9Mco8eTSkLL4gJXSeWdgEiUbGbctxTzOe7KC1mWvKKYwSVUPZUrMf6Fc8//TKV88csRlEhUoUdBFf0vJvY6mPlzF2e2+fFtl444tTmSOu/WeR/RczmtqBB31EuUoatfXW3MalFWNeh/XYvqasAAC/jtyxbxgoin+mMkCjkn+COt4nHlkfRU5C1gvmXaR+AZZU/SzZf6YIfYnEDzJYuV5Z5HxxzpvLGlbdNyenk1jN6znFZXmPm+aHVwf5kepqsnst+frzoOOBIgbwfwu4HrVl9Iyyow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zCRiyhMnjTaYecQ/DEDtokAnrGVsW8nWixQd2afqiQ0=;
 b=CpDCh6dZS54IHno4NQwUTX5dDaRiSBY9aCr4+gc2bv4mS3VRA624NLsN8wij8r27owrLL9cQ0BoDg1GknH2Avp5WlOL8Wez2FVTAnYPVx1c91RDfRFK4SY9HvZ3JePIPUsZAbtgBl+bXIcFCk4DFFe+dsScHgISe0SFA96vlLlcp0Y4Rrnja9MyrYynEWvb+PrtWDDwK+f4ht8krkgcBFeNyT5Kd3Qfv73X7hzEnlORtOdZq4BvkQOCHLJ53HdF4xZ2fywV3HVSi5K8BkUUK8YWGFQJW753qGm4a8S0P9UAS4x+re/T3S50GuMIQtvs6KyJkFnELEdhl3suiViQFQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zCRiyhMnjTaYecQ/DEDtokAnrGVsW8nWixQd2afqiQ0=;
 b=AWADUkJxY6h6eWVgyDxudmNSChQ1DSOS6JVQOCu8/CxCwpeJhA5dETtto2vRyfkRfGxt04X9YD7AQJY2cRGHZMuUQjgv6KbWKA8/83Kc6NfDjqafAIjF7eKaKmngE+uPmHvvNvcf2M/YZTMUJFy5GqNbEhDcdVsGhcg6Ig5FqnQ=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 3/3] EFI: drop copy-in from QueryVariableInfo()'s OUT-only
 variable bouncing
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <edde87a3-beb3-c109-65ef-36e74df28e7a@suse.com>
Date: Fri, 3 Dec 2021 16:11:44 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 =?utf-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <CDB88FAF-B16A-41F1-88E3-D35EDBEB5027@arm.com>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <edde87a3-beb3-c109-65ef-36e74df28e7a@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO2P265CA0030.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:61::18) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ab61dd88-658c-4399-ead0-08d9b677a565
X-MS-TrafficTypeDiagnostic: PR3PR08MB5802:|AM5PR0802MB2433:
X-Microsoft-Antispam-PRVS:
	<AM5PR0802MB24337AE88461FEA4B3317873E46A9@AM5PR0802MB2433.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 L52W75vWF0sBSPtyEgGKLNyyY6tBrHr2gTBAXY4GL0X8kqYO13ByOUSApuh8iuFF/DOS8ypW+ZF/Wt3qEEzCslWV5k8/DuXLoAB2smmMsmYj/qrgtoSY3sf3HatelE5PmRVzeT9bFhFl4MP2NwLm5ULOXU+lPw4oAgOu/Wh7Qx5EtneB4TPwL/jrBxuFbx7OXtzmUhl3TKka75ZCoM9PPTCHSXiLt7mpbLX8VA+QRjX9X0Pk/l7lijA91jj8XPQWJ+imaEIc8c8UVuo3GHHlH6NrjHeSIE7DGNL9f0tagmzuZyIajxkE8gPpEj6OLVk0QSh8jnk0mH675gScs3Z8XiG07VQstASy+lhC1R/f8kMH1/vVOSvMOpaLefVT1nyiDnMbz8Af6WeF5VreAso0hTka9zo4lf7JPnqdKTBNU3p3H3w7FEU7xa7TfHdpMGKXeGi4OON3HNX4SAu+Y5fFqoCXHOtZ25s/8tB0kjWe9HZPAlCpgIfzhefe9dS5TifeNUzvvgRagROdd69ED8qvEY1/aJyt+su20rzt8WL0qJ6xV8Vx4ix+IBbMwj3mON2oH3f+IXRGhOVj5a8DPOoswuR5ESMpDjvmuu5bh5Y3Vss2Y2WqExzvOC9K6+5B4kAeEPKCdzB+v3YcaOyED64WCTYu//jIea+Jt3gji78BslSiNCuH0PDuzV/wiDaGxGQThqnbjUJVzj4qjbH/jOE1fd0C3Bk0uN7wreG8AdMaW5Q=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(53546011)(2906002)(508600001)(6506007)(52116002)(26005)(6916009)(8936002)(956004)(316002)(5660300002)(2616005)(186003)(4326008)(44832011)(6486002)(66556008)(8676002)(66946007)(38350700002)(33656002)(66476007)(38100700002)(83380400001)(54906003)(86362001)(36756003)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5802
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a931acaa-e7cf-46b8-bbb2-08d9b6779a24
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Pq5m0AwiQ39Kh7eip+j0RSuvH1KU3qPyZvNghrxsCFcSL3CjHRgNDQ6egX7fNanFqE6zcjinAuapU0qrVd4cm06QbMxgdLMhjXjCFPK95vwXpznIz/I0PtMpsqoi50tRrq51zhUvT5fA9CTIgV1G8inq4mrvOOVHiLaLcMlS3HBTBDEl3xmMksNaJH4v3NALWpAUiyDjHdOwC/AGyS8HqA+tZOQzM2+bRqEe6rKyDVU2MMj1rHHX5Gjam3zrk53xSNHuGd9n0djdq8F8aW/THvNjp5viEZzFcMF5AMUmw54+eJrmUES5SDDkpMnFe2mx4HFtAGiC5O4bv76eIM8nszA/BEKHEAC0SnHV3wTRpc0XTOAOzmGUXBLIBs1s5dggCUfrZ46Se2d3/j25j7+akjfh0RsFLaiYSRf34Jv3F7BOfT7DxEhuiF9UaqtON+O4bekgKZyMYhe0buy96DDUGeNA1uEEjk91Q2P8WyxJdRBj4QjTXW5ZxiS8bSL1v/+97jnzwt1yk0ZWwzJJttxi5w+gDUAz1Oo/iuBS6Jpom49tVUP125kDoTu30IdK4xmZMTFk2sioKcL68GwDRhSkfO+U3CxA9eyI/zV/AqapZruC3IvJE7QJxYW1ug3RkJfMv8RcKu/gM+KysY+ltmDgpQy14vivm205QU9qqKkfp5X8hX/oY0Awxp6Bmqg65rCfRSJHauXmzeAjZzz/UwZ08Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6512007)(107886003)(6486002)(33656002)(186003)(70586007)(44832011)(8676002)(83380400001)(86362001)(36756003)(6506007)(956004)(53546011)(316002)(26005)(82310400004)(8936002)(4326008)(336012)(81166007)(2906002)(5660300002)(508600001)(54906003)(6862004)(70206006)(36860700001)(47076005)(356005)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 16:12:04.0825
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ab61dd88-658c-4399-ead0-08d9b677a565
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2433



> On 3 Dec 2021, at 10:58, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> While be12fcca8b78 ("efi: fix alignment of function parameters in compat
> mode") intentionally bounced them both ways to avoid any functional
> change so close to the release of 4.16, the bouncing-in shouldn't really
> be needed. In exchange the local variables need to gain initializers to
> avoid copying back prior stack contents.
>=20

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> --- a/xen/common/efi/runtime.c
> +++ b/xen/common/efi/runtime.c
> @@ -608,7 +608,15 @@ int efi_runtime_call(struct xenpf_efi_ru
>=20
>     case XEN_EFI_query_variable_info:
>     {
> -        uint64_t max_store_size, remain_store_size, max_size;
> +        /*
> +         * Put OUT variables on the stack to make them 8 byte aligned wh=
en
> +         * called from the compat handler, as their placement in
> +         * compat_pf_efi_runtime_call will make them 4 byte aligned inst=
ead
> +         * and compilers may validly complain.  This is done regardless =
of
> +         * whether called from the compat handler or not, as it's not wo=
rth
> +         * the extra logic to differentiate.
> +         */
> +        uint64_t max_store_size =3D 0, remain_store_size =3D 0, max_size=
 =3D 0;
>=20
>         if ( op->misc & ~XEN_EFI_VARINFO_BOOT_SNAPSHOT )
>             return -EINVAL;
> @@ -642,21 +650,6 @@ int efi_runtime_call(struct xenpf_efi_ru
>         if ( !efi_enabled(EFI_RS) || (efi_rs->Hdr.Revision >> 16) < 2 )
>             return -EOPNOTSUPP;
>=20
> -        /*
> -         * Bounce the variables onto the stack to make them 8 byte align=
ed when
> -         * called from the compat handler, as their placement in
> -         * compat_pf_efi_runtime_call will make them 4 byte aligned inst=
ead and
> -         * and compilers may validly complain.
> -         *
> -         * Note that while the function parameters are OUT only, copy th=
e
> -         * values here anyway just in case. This is done regardless of w=
hether
> -         * called from the compat handler or not, as it's not worth the =
extra
> -         * logic to differentiate.
> -         */
> -        max_store_size =3D op->u.query_variable_info.max_store_size;
> -        remain_store_size =3D op->u.query_variable_info.remain_store_siz=
e;
> -        max_size =3D op->u.query_variable_info.max_size;
> -
>         state =3D efi_rs_enter();
>         if ( !state.cr3 )
>             return -EOPNOTSUPP;
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:30:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:30:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237846.412492 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBRq-0002Bg-MX; Fri, 03 Dec 2021 16:30:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237846.412492; Fri, 03 Dec 2021 16:30:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBRq-0002BZ-Hu; Fri, 03 Dec 2021 16:30:10 +0000
Received: by outflank-mailman (input) for mailman id 237846;
 Fri, 03 Dec 2021 16:30:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mtBRp-0002BT-7i
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:30:09 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 467cc671-5456-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 17:30:07 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:51008)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mtBRe-000xOG-gZ (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 16:29:58 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id E9EB41FC8B;
 Fri,  3 Dec 2021 16:29:57 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 467cc671-5456-11ec-976b-d102b41d0961
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d54208f3-160a-90be-586b-659200029302@srcf.net>
Date: Fri, 3 Dec 2021 16:29:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Dario Faggioli <dfaggioli@suse.com>, Jan Beulich <JBeulich@suse.com>
Cc: "julien@xen.org" <julien@xen.org>, "wl@xen.org" <wl@xen.org>,
 "iwj@xenproject.org" <iwj@xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 "George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>
References: <20210920172529.24932-1-andrew.cooper3@citrix.com>
 <20210920172529.24932-2-andrew.cooper3@citrix.com>
 <da06dfe42adad13650755650518a232dd41ac46e.camel@suse.com>
 <8e3f7318-2fb4-0011-f582-268816ebb59c@suse.com>
 <db0443d4fc414e17e0bba075043f8ae60b062860.camel@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 01/12] xen/trace: Don't over-read trace objects
In-Reply-To: <db0443d4fc414e17e0bba075043f8ae60b062860.camel@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 30/09/2021 09:07, Dario Faggioli wrote:
> On Mon, 2021-09-27 at 09:51 +0200, Jan Beulich wrote:
>> On 24.09.2021 16:51, Dario Faggioli wrote:
>>> On Mon, 2021-09-20 at 18:25 +0100, Andrew Cooper wrote:
>>>
>>>> There is one buggy race record, TRC_RTDS_BUDGET_BURN.  As it must
>>>> remain
>>>> __packed (as cur_budget is misaligned), change bool has_extratime
>>>> to
>>>> uint32_t
>>>> to compensate.
>>>>
>>> Mmm... maybe my understanding of data alignment inside structs is a
>>> bit
>>> lacking, but what the actual issue here, and what would we need to
>>> do
>>> to fix it (where, by fix, I mean us being able to get rid of the
>>> `__packed`)?
>>>
>>> If rearranging fields is not enough, we can think about making
>>> priority_level and has_extratime smaller, or even combining them in
>>> just one field and decode the information in xentrace.
>> I guess Andrew has tried to avoid re-arranging field order so that
>> the consumer side doesn't need to also change.
>>
> Right, but is it really worth it, in this case?
>
> Aren't we (very very likely) in control, by having them here in the
> tree, of all the consumers? And is is this a stable ABI?
>
> Also, both xentrace_format and xenalyze are being modified in this
> series anyway...
>
> Maybe there's still something I'm missing, but if we've getting rid of
> those ugly bitfields and __packed attributes, it seems to me that doing
> it completely --i.e., including in this case-- is worth the small
> change in the tools.

This patch needs backporting to stable trees.  We shouldn't be changing
the ABI, even if its stability is unclear.

Which means patch 2 needs altering to avoid ABI changes.  /sigh

~Andre


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 16:30:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 16:30:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237848.412503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBSF-0002eE-UB; Fri, 03 Dec 2021 16:30:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237848.412503; Fri, 03 Dec 2021 16:30:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtBSF-0002e7-Qz; Fri, 03 Dec 2021 16:30:35 +0000
Received: by outflank-mailman (input) for mailman id 237848;
 Fri, 03 Dec 2021 16:30:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sOtX=QU=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mtBSE-0002BT-Pu
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 16:30:35 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0605.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::605])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5661d722-5456-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 17:30:34 +0100 (CET)
Received: from AS9PR06CA0004.eurprd06.prod.outlook.com (2603:10a6:20b:462::20)
 by AM0PR08MB3747.eurprd08.prod.outlook.com (2603:10a6:208:105::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Fri, 3 Dec
 2021 16:30:30 +0000
Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:462:cafe::67) by AS9PR06CA0004.outlook.office365.com
 (2603:10a6:20b:462::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Fri, 3 Dec 2021 16:30:30 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Fri, 3 Dec 2021 16:30:29 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Fri, 03 Dec 2021 16:30:29 +0000
Received: from a79cd7973414.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0FAC48ED-7CED-418A-BFF8-EADA11DAD459.1; 
 Fri, 03 Dec 2021 16:30:13 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a79cd7973414.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 03 Dec 2021 16:30:13 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6688.eurprd08.prod.outlook.com (2603:10a6:102:130::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 3 Dec
 2021 16:30:11 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::1d24:822b:651c:5eeb%6]) with mapi id 15.20.4690.034; Fri, 3 Dec 2021
 16:30:11 +0000
Received: from smtpclient.apple (82.8.129.65) by
 SA0PR11CA0034.namprd11.prod.outlook.com (2603:10b6:806:d0::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Fri, 3 Dec 2021 16:30:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5661d722-5456-11ec-976b-d102b41d0961
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qh5am0VjrmfVIB+arjVKc6QYJcXBkq8K24X2CYEx2Co=;
 b=e4R9lkxBlxgOOiDoXGp2rcDZspGTtlPBoAfzw7wP99Of+k9peIR1UR5p0+pDzaiofuBMGyORQTCGfkCkp2esp9LSNqNlR7QxiqnjQ5hv3XyxZpFraSbwsOyRSYL2ROu5xWPcnJttomFs3dGye2APnAIdtbDMJyBQ0HR3B3NI/es=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: b4d3cf6bbf725bc7
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XWzAOCOHp6tWI7uVQCp4JH0XIwznor0mabk2vUcOrm579ZtD1X9u7YSQPa5HPo0+QUDcw5dJOJiWVJI1O6yZEdRdGWFjs5rFW/dFnjH6e7o+hW5GXnb6FD7nWn6FYCSFedweHA1+c5+StLeuw472WE7b1iEB3t7FeLmvO5HcXVXBOGyIXA5BZ6xqUsur43IMy8hzSpK4RwJuKTsIwsthHmhYPJfE6rxX90YybftbzviyYG0MNy0J/iaQBzPRhjc/XGOJMp4/uP6Vdyd170oJXVPbMKGMOqWlOhdIuNsA2Rqwyup0TpJTxJC/kjOl/dTItZd0l0pf+Vrk8UsfPjP0UQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qh5am0VjrmfVIB+arjVKc6QYJcXBkq8K24X2CYEx2Co=;
 b=D5i519QomG4IO0uK/hjxPKq0onwx6NuSnN9YblQCNvFaHrEQ2r/zlPhHLhdU5nWQO6PGOibD5RdtSYUtDPwqHt7qXam1FrIVtCCTA7ziK2O38HbnsTGajDFgBbFP41knCqNrWWLXHQZ2emHzsHqcWHLcivblF5N5c7azhH1uUVY0sL3icni3OpjbtVqiTqw9+qlR/0BYpjpobpjVditrTk4R2MqrjOqdKwldFLdBkV0rGq+7aMyysydYsA3mJkDvcPpm+H/Yl7Ddr85/wrwH87umsx0/WiDw6gq9Z6mvU8oq6YHYFiV7SypWZVm7ec4z3RwBrWVW6nJ/YbCcubh6Yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qh5am0VjrmfVIB+arjVKc6QYJcXBkq8K24X2CYEx2Co=;
 b=e4R9lkxBlxgOOiDoXGp2rcDZspGTtlPBoAfzw7wP99Of+k9peIR1UR5p0+pDzaiofuBMGyORQTCGfkCkp2esp9LSNqNlR7QxiqnjQ5hv3XyxZpFraSbwsOyRSYL2ROu5xWPcnJttomFs3dGye2APnAIdtbDMJyBQ0HR3B3NI/es=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 1/5] perfc: conditionalize credit/credit2 counters
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <22325915-c51c-a091-59e2-e6e214576f80@suse.com>
Date: Fri, 3 Dec 2021 16:30:02 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: 7bit
Message-Id: <95FF4173-9435-4260-88E3-39A9BBDAA69E@arm.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <22325915-c51c-a091-59e2-e6e214576f80@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: SA0PR11CA0034.namprd11.prod.outlook.com
 (2603:10b6:806:d0::9) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 60c4e5a1-0583-4f9c-183b-08d9b67a3863
X-MS-TrafficTypeDiagnostic: PAXPR08MB6688:|AM0PR08MB3747:
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3747D6E46A35F5DD867B4515E46A9@AM0PR08MB3747.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Q5twp5jxs6gUYm+2nkDCB+Y5G/BoYDcleHjxZ9ElqUBz+74LpojtFHfiwSvfCY1PO4XDNyHU7+6PUpNyicbsEMb2TDXkrt5N3o+H6iTj6NnBqCs0QNXdBopGLsFgkvud9h0VBtj+Oc5Mcco9CdRnElLnWjLC2NJzXoZQzKphjZQ+nU0MjZFqp8EoJ1o8kijrOWRJOd5WJu8racBPlaLLvEKLCwXjCWgtZ6ttXwnpYsn5kFVla0pprnDy5w2uiR3ILcHLdKYTdZq98XfZGnjoq5ICHUECeo9I2B0KUEOqnCoc3pmkG0EcgrNH0H0XOKSAQHqHvwkdxnU5eMxQn/lI5Srhgqu0nBZ0UFlTx8hoWH4ioZNyo00/Tx/B1aLzwJF8Kl/8V+cVOdIwnXx/rDrH0ubYydmsGwQ9LMLNKgKa0cF4uE1LwtqLCB5+ST9HniLlVjuFFAOeYH0Z3+0BQkowov+x57b56kkl0da4HSZT8+mgrzB6YHFCBxu2n6tKq5vzJKMANxR4Kn/uLdM6IqTOaV4P6P1m87y5L4TVkipIi7mWXKA6wocszX+bSRkNNVdP1dZ0/IZFAeIQ72j8s9ykEU9BcJ2OvyyBGRdP8fsvRbhjzoUsaw9XnS//FAPlSesDKKfURleB9t/L8BesCc+7WR9P1qvTjaFOlzI89F7Ry/TgUhtA6i/UKq9rKYkfdyuUCe8LkXfoIJSCpmZLz4EtaGmLRFUllXZto80HQ3DZMZop88YqYMd26Hp2Reaf9s7W
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(8936002)(66946007)(86362001)(66476007)(956004)(26005)(83380400001)(33656002)(6506007)(508600001)(5660300002)(6486002)(36756003)(8676002)(53546011)(2906002)(6666004)(52116002)(186003)(54906003)(6512007)(38100700002)(38350700002)(44832011)(6916009)(2616005)(4326008)(316002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6688
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	e36eae6f-6307-4395-62e5-08d9b67a2cfc
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TyFtb8UU4zJXQhdqHZoK8SfTYnMwDSnPOUh1aHQCsPUTnl/VoSfTDxgfYvISKeZ4LUEl7ninAFbRHm9c/gSrvAq5HFcpW2hV4LMBt42UO50SWh7iMu4k0EahlksCBr2DvN/l3WN+hVzxqyetAsYMCII1OCtINJXidmm/k11Vu0Mnk7t8b+Sq6p8qqwycKGl9AW+Y0ppa0xJfzpu61Fszgu5jXjVEtpnv1nlR0RjVFuxZJR8f6aw8Sk+9lXFcQhC/Nnm3IMWF2t47aVYq7sFwy2jvlGJDznG/xRcU3hhqtRET9zDusOkpRfRnAtXE8nbhazDkaiFsosPT7cI0xWdDhxCLbEYnObdEbh77FPuX5z1PxUtfOGtYAuBIjKywwzhTl1N3viUOCnkxuR03Ng7cTU0Jk55iwWCK+AG5BEz5kzAzOmyM5tcJVnl+umG9KVgR35Uye/AUd13uWJmMem3Anl0NhG8Jm1r690BoYTrSq6d5kW3NwTP1yCdky3IudLwrE3Prl027cWbXjieV7Of2aEHuDZpUmKoy/rqy3aYP34kjfYfHyIjyU9Hvw8YIh+hSRYIe08PuddZWyUrKmSwWldTyuB0ermJMUbq5YsXzPbuoIWQAWFc1gr+m9o/ARFzgaby6d2xUkP1ALl7rCywLRcRN2qr1DC56ni9oofprZoeZ5rss19K7Ec0iXHSLrU1b1z8YQkohG3MhjcqL+SpuKA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(956004)(82310400004)(33656002)(36756003)(70586007)(508600001)(336012)(26005)(4326008)(5660300002)(44832011)(86362001)(36860700001)(6862004)(70206006)(47076005)(54906003)(53546011)(81166007)(356005)(6506007)(8676002)(6666004)(186003)(316002)(8936002)(6486002)(2906002)(83380400001)(6512007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 16:30:29.6825
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 60c4e5a1-0583-4f9c-183b-08d9b67a3863
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3747



> On 3 Dec 2021, at 12:03, Jan Beulich <jbeulich@suse.com> wrote:
> 
> There's no point including them when the respective scheduler isn't
> enabled in the build.
> 

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/include/xen/perfc_defn.h
> +++ b/xen/include/xen/perfc_defn.h
> @@ -37,6 +37,7 @@ PERFCOUNTER(tickled_busy_cpu,       "sch
> PERFCOUNTER(unit_check,             "sched: unit_check")
> 
> /* credit specific counters */
> +#ifdef CONFIG_SCHED_CREDIT
> PERFCOUNTER(delay_ms,               "csched: delay")
> PERFCOUNTER(acct_run,               "csched: acct_run")
> PERFCOUNTER(acct_no_work,           "csched: acct_no_work")
> @@ -58,8 +59,10 @@ PERFCOUNTER(migrate_queued,         "csc
> PERFCOUNTER(migrate_running,        "csched: migrate_running")
> PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
> PERFCOUNTER(unit_hot,               "csched: unit_hot")
> +#endif
> 
> /* credit2 specific counters */
> +#ifdef CONFIG_SCHED_CREDIT2
> PERFCOUNTER(burn_credits_t2c,       "csched2: burn_credits_t2c")
> PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
> PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
> @@ -77,6 +80,7 @@ PERFCOUNTER(credit_reset,           "csc
> PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu")
> PERFCOUNTER(tickled_cpu_overwritten,"csched2: tickled_cpu_overwritten")
> PERFCOUNTER(tickled_cpu_overridden, "csched2: tickled_cpu_overridden")
> +#endif
> 
> PERFCOUNTER(need_flush_tlb_flush,   "PG_need_flush tlb flushes")
> 
> 
> 



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 17:22:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 17:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237870.412525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtCGY-0000Pw-0W; Fri, 03 Dec 2021 17:22:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237870.412525; Fri, 03 Dec 2021 17:22:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtCGX-0000Pp-Tm; Fri, 03 Dec 2021 17:22:33 +0000
Received: by outflank-mailman (input) for mailman id 237870;
 Fri, 03 Dec 2021 17:22:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCGW-0000Pf-T6; Fri, 03 Dec 2021 17:22:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCGW-0001ON-LM; Fri, 03 Dec 2021 17:22:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCGW-000370-8f; Fri, 03 Dec 2021 17:22:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCGW-0002lF-8B; Fri, 03 Dec 2021 17:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FfcU9OTYHmR+UcnEq4P7OngFGRLD89vMRm9B/RgmvpI=; b=5fd9hYEamF9kHlE6J8l7ZEocUz
	1A3H3f5kUFUTn9ZvB4Hp7N+mEtWMZvz+lAIfQ+M355lsgFSzoDZhsqC+ppIHZBUCOXULDMUxr48BX
	ayBzfb8Cekol6EY9smkDYaC8rAT1e2TkEPvo5g09wrhl68We3I8N/oDp8OnTDERWqqDI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167081-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167081: regressions - FAIL
X-Osstest-Failures:
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
X-Osstest-Versions-This:
    ovmf=dfafa8e45382939fb5dc78e9d37b97b500a43613
X-Osstest-Versions-That:
    ovmf=f0f3f5aae7c4d346ea5e24970936d80dc5b60657
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 17:22:32 +0000

flight 167081 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167081/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166961
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166961

version targeted for testing:
 ovmf                 dfafa8e45382939fb5dc78e9d37b97b500a43613
baseline version:
 ovmf                 f0f3f5aae7c4d346ea5e24970936d80dc5b60657

Last test of basis   166961  2021-11-30 14:41:39 Z    3 days
Testing same since   167081  2021-12-03 10:10:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit dfafa8e45382939fb5dc78e9d37b97b500a43613
Author: wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
Date:   Tue Nov 30 09:51:10 2021 +0800

    MdeModulePkg/DxeCorePerformanceLib:Variable Initial
    
    SmmBootRecordDataSize is initialized in InternalGetSmmPerData,
    but this function may fail. so to avoid using SmmBootRecordDataSize
    without intialization, set it to 0 at first.
    
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Liming Gao <gaoliming@byosoft.com.cn>
    Cc: Dandan Bi <dandan.bi@intel.com>
    Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
    Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
    Reviewed-by: Dandan Bi <dandan.bi@intel.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 17:45:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 17:45:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237887.412553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtCcg-0003Kl-2z; Fri, 03 Dec 2021 17:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237887.412553; Fri, 03 Dec 2021 17:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtCcg-0003Ke-03; Fri, 03 Dec 2021 17:45:26 +0000
Received: by outflank-mailman (input) for mailman id 237887;
 Fri, 03 Dec 2021 17:45:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCce-0003KU-3J; Fri, 03 Dec 2021 17:45:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCcd-0001lh-VI; Fri, 03 Dec 2021 17:45:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCcd-0004Qx-OR; Fri, 03 Dec 2021 17:45:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtCcd-0007Ws-Ns; Fri, 03 Dec 2021 17:45:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/CzrkU1F9Y7bQtxU0bdr8DQyGv5dvFV58ehbmzvLtak=; b=fR/bqPTBzpgyUo2d1RqAndf/8S
	mz5pJaeXQ1nGGVexRdbSZPG7J0osF9D7nsIgoilh5T/6bwAp8QsjQ+tOosNLRPn6lh5c/1TUPNfqi
	2tUb2AM0lb4YhvqUM81DI3pq0lGIeUgBiVUXZ2eR9b2My3PYXK5oq/Nd8OVuWhVdM1rQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167092-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167092: regressions - FAIL
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=7b57956b20d90f47dafb7ba1eb52d23e42efd786
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 17:45:23 +0000

flight 167092 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167092/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166958
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166958
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166958

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  7b57956b20d90f47dafb7ba1eb52d23e42efd786
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    3 days
Failing since        166977  2021-12-01 17:08:21 Z    2 days   10 attempts
Testing same since   167092  2021-12-03 14:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tim Deegan <tim@xen.org>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-libvirt                                     fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 552 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 18:42:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 18:42:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237906.412578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDVW-0002BV-63; Fri, 03 Dec 2021 18:42:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237906.412578; Fri, 03 Dec 2021 18:42:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDVW-0002BO-3D; Fri, 03 Dec 2021 18:42:06 +0000
Received: by outflank-mailman (input) for mailman id 237906;
 Fri, 03 Dec 2021 18:42:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LwEy=QU=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mtDVU-0002BI-0i
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 18:42:04 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2abdd5c-5468-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 19:42:00 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35194)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mtDVO-000oBv-9T (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 03 Dec 2021 18:41:58 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id BEB421FC8B;
 Fri,  3 Dec 2021 18:41:58 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2abdd5c-5468-11ec-b1df-f38ee3fbfdf7
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <86264d00-7551-5c38-f806-e35048f73c55@srcf.net>
Date: Fri, 3 Dec 2021 18:41:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126212258.7550-1-andrew.cooper3@citrix.com>
 <20211126212258.7550-3-andrew.cooper3@citrix.com>
 <3ca82514-2adf-2445-04d1-0020dde16019@suse.com>
 <4ee538d8-5063-1bf6-025a-62474be7ab0c@srcf.net>
 <33d466b3-338b-d2dc-f993-c5fac22072e0@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/4] x86/altcall: Optimise away endbr64 instruction where
 possible
In-Reply-To: <33d466b3-338b-d2dc-f993-c5fac22072e0@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 02/12/2021 08:01, Jan Beulich wrote:
> On 01.12.2021 20:07, Andrew Cooper wrote:
>> On 01/12/2021 08:20, Jan Beulich wrote:
>>> On 26.11.2021 22:22, Andrew Cooper wrote:
>>>> With altcall, we convert indirect branches into direct ones.  With that
>>>> complete, none of the potential targets need an endbr64 instruction.
>>> Assuming that no other hooks remain which re-use the same function. I
>>> think this constraint wants at least mentioning explicitly.
>> Fair point, but I think it is entirely reasonable to expect logic not to
>> mix and match altcall on the same hook.
> Take XSM's silo_xsm_ops and dummy_ops as an example. With what
> xsm_fixup_ops() does it should be entirely benign if silo_xsm_ops
> set any or all of the hooks which are currently unset to what
> dummy_ops has.

We're talking very specifically about ops and ops-like structures, and
we don't just have random code calling dumy_ops->foo() when you've also
got xsm_foo() { altcall(ops->foo); }

In this case specifically, each of {flask,silo,dummy}_ops are static,
and xsm_fixup_ops() gets called exactly once on the root xsm_ops object,
so even code inside silo.c can't call silo->foo() and hit the dummy foo().

>>>> Furthermore, removing the endbr64 instructions is a security defence-in-depth
>>>> improvement, because it limits the options available to an attacker who has
>>>> managed to hijack a function pointer.
>>>>
>>>> Introduce a new .init.data.cf_clobber section.  Have _apply_alternatives()
>>>> walk over the entire section, looking for any pointers into .text, and clobber
>>>> an endbr64 instruction if found.  This is some minor structure (ab)use but it
>>>> works alarmingly well.
>>> Iirc you've said more than once that non-function-pointer data in
>>> those structures is fine; I'm not convinced. What if a sequence of
>>> sub-pointer-size fields has a value looking like a pointer into
>>> .text? This may not be very likely, but would result in corruption
>>> that may be hard to associate with anything. Of course, with the
>>> is_endbr64() check and with a build time check of there not being
>>> any stray ENDBR64 patterns in .text, that issue would disappear.
>>> But we aren't quite there yet.
>> I disagree with "not very likely" and put it firmly in the "not
>> plausible" category.
>>
>> To cause a problem, you need an aligned something which isn't actually a
>> function pointer with a bit pattern forming [0xffff82d040200000,
>> ffff82d04039e1ba) which hits an ENDBR64 pattern.  Removing the stray
>> ENDBR64's doesn't prevent such a bit pattern pointing at a real (wrong)
>> function.
> Why "aligned" in "aligned something"?

The non-function-pointer thing inside the ops struct needs to be 8-byte
aligned to trigger this bad behaviour to begin with, because we
interpret the struct as an array of unsigned longs.

Any 8-byte block containing a bool for example can't cause problems, nor
can a pair of adjacent uint32_t's if they're not on an 8 byte boundary.

>  And I also don't see what you're
> trying to tell me with the last sentence. It's still .text corruption
> that would result if such a pattern (crossing an insn boundary)
> happened to be pointed at.

We (will) have tooling to detect and reject ENDBR64 bit patterns which
aren't real ENDBR64 instructions.

But this "integer bit pattern that looks like a function pointer"
problem can target one of ~1600 (fewer in most builds) real ENDBR64
instructions of an unrelated function.

>> These structures are almost exclusively compile time generated.
>>
>> So yes - it's not impossible, but it's also not going to happen
>> accidentally.
> I wonder how you mean to exclude such accidents. It occurs to me that
> checking the linked binary for the pattern isn't going to be enough.
> Such a patter could also form with alternatives patching. (It's all
> quite unlikely, yes, but imo we need to fully exclude the possibility.)

Again, we're taking specifically ops structures, not arbitrary structures.

hvm_funcs is the only thing so far that has non-function pointer
members, and its got a string pointer (fine - not .text), and a couple
of integer fields, none of which will plausibly alias a function pointer.

I will fully admit that there is a risk of things going wrong.  I'm
happy copious health warnings wherever necessary, but I don't see
anything going wrong in practice without a deliberate attempt to tickle
this corner case.

>>>> --- a/xen/arch/x86/alternative.c
>>>> +++ b/xen/arch/x86/alternative.c
>>>> @@ -173,6 +173,9 @@ text_poke(void *addr, const void *opcode, size_t len)
>>>>      return memcpy(addr, opcode, len);
>>>>  }
>>>>  
>>>> +extern unsigned long __initdata_cf_clobber_start[];
>>>> +extern unsigned long __initdata_cf_clobber_end[];
>>> const please. I also would find it quite a bit better if these
>>> were suitably typed such that ...
>>>
>>>> @@ -329,6 +332,41 @@ static void init_or_livepatch _apply_alternatives(struct alt_instr *start,
>>>>          add_nops(buf + a->repl_len, total_len - a->repl_len);
>>>>          text_poke(orig, buf, total_len);
>>>>      }
>>>> +
>>>> +    /*
>>>> +     * Clobber endbr64 instructions now that altcall has finished optimised
>>>> +     * all indirect branches to direct ones.
>>>> +     */
>>>> +    if ( force && cpu_has_xen_ibt )
>>>> +    {
>>>> +        unsigned long *val;
>>>> +        unsigned int clobbered = 0;
>>>> +
>>>> +        /*
>>>> +         * This is some minor structure (ab)use.  We walk the entire contents
>>>> +         * of .init.data.cf_clobber as if it were an array of pointers.
>>>> +         *
>>>> +         * If the pointer points into .text, and has an endbr64 instruction,
>>>> +         * nop out the endbr64.  This causes the pointer to no longer be a
>>>> +         * legal indirect branch target under CET-IBT.  This is a
>>>> +         * defence-in-depth measure, to reduce the options available to an
>>>> +         * adversary who has managed to hijack a function pointer.
>>>> +         */
>>>> +        for ( val = __initdata_cf_clobber_start;
>>>> +              val < __initdata_cf_clobber_end;
>>>> +              val++ )
>>>> +        {
>>>> +            void *ptr = (void *)*val;
>>> ... no cast was needed here.
>> Unless you know what this type is, I already tried and am stuck. 
>> Everything else requires more horrible casts on val.
> It's as simple as I thought is would be; proposed respective patch
> at the end of the mail (the two //temp-marked #define-s were needed so
> I could build-test this without needing to pull in further patches of
> yours). No new casts at all, and the one gone that I wanted to see
> eliminated.

I can't have been very caffeinated while having those problems, clearly...

I have no idea how I didn't manage to come up with that as a working
solution.

>>>> --- a/xen/include/xen/init.h
>>>> +++ b/xen/include/xen/init.h
>>>> @@ -18,6 +18,8 @@
>>>>  #define __init_call(lvl)  __used_section(".initcall" lvl ".init")
>>>>  #define __exit_call       __used_section(".exitcall.exit")
>>>>  
>>>> +#define __initdata_cf_clobber __section(".init.data.cf_clobber")
>>> Just to repeat what I've said elsewhere: I think we want a const
>>> version of this as well.
>> I can, but does it really matter?  initconst is merged into initdata and
>> not actually read-only to begin with.
> My remark wasn't about the actual mapping properties at all. What I'm
> after is the compiler being able to spot modifications. If I see a
> struct instance marked "const" and if I know the thing builds okay, I
> know I don't need to go hunt for possible writes to this struct
> instance. When it's non-const, to be sure there's no possible conflict
> with the patching (yours or just the altcall part), I'd need to find
> and verify all instances where the object gets written to.

I've added __initconst_cf_clobber too.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 18:59:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 18:59:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237917.412593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDmT-0004H5-QL; Fri, 03 Dec 2021 18:59:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237917.412593; Fri, 03 Dec 2021 18:59:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDmT-0004Gg-NO; Fri, 03 Dec 2021 18:59:37 +0000
Received: by outflank-mailman (input) for mailman id 237917;
 Fri, 03 Dec 2021 18:59:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Gfv3=QU=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1mtDmS-0004Ga-5c
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 18:59:36 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-cusazlp170100000.outbound.protection.outlook.com
 [2a01:111:f403:c111::])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 263392ea-546b-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 19:59:33 +0100 (CET)
Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11)
 by MW2PR2101MB1019.namprd21.prod.outlook.com (2603:10b6:302:5::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.4; Fri, 3 Dec
 2021 18:59:29 +0000
Received: from MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::40d7:92be:b38f:a9cd]) by MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::40d7:92be:b38f:a9cd%3]) with mapi id 15.20.4778.007; Fri, 3 Dec 2021
 18:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 263392ea-546b-11ec-b1df-f38ee3fbfdf7
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lwvvorw3+A+YYcD5vSTxaajypwrEDSblNTf15y8nBuFDxy9pl2iteCEGoAzTWU4+Neck9CAlJlGg47Syj+46hZmHGC/VuM1nJnorGizfpa3YGQ7PRL1h3YiB1/qEJmHDWkMQ482EA17hW3AleMLlfOuDeWwP8Nyu5aUbUukOGtZ3tPnHW/O7MDCeN6hIDbARVOttrQ/JI620sN9+uWOwdoyTZ2vviv+IjXg1WCqJkSNZ44ASHtV0Y7+AusIHsiR6i1Mm8l3crOpaMOCcBtSdIgBOOE+Qp6Sw/cUT5fzB1Yhai29RBKMKh2BNO/rKXE2Taev5aufAcAHKjWcAZ/ReWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1zvSmGZWeL7RWAEcBm9oIjTfTcaBDiK4JIFwRC9Z5qI=;
 b=DmA9wQkU4WWD70vdJ0rTD7Utt4ya1UcV9DrNvYAkSwSk2FZMOWwb7QsIbs6cRwzxRUCFb0k8LE0mhH46wwrUg2hWxz2JuLz52YzNKugvjGUe47SerHwK52YKCmlCOIf11P/6hxKHtgJTE0NoqHoKaShnDpW45eXETGCYLFLzNmYvS8UKHw+QSX8B4nIefEWx5rw72hvJ02EN7KGoLcPl8NUjzuHAxWbYf1+t0xA/BipuZc6sHKj3/UR1Xwy+LkfWRc6/kuZ1GkQ+NDGyAbBFOTwQfq3BgH2R524Arty1KNdNkfHcUiaBCZo7XTMGw0022uI8t2S1AtgCTd7N866Z9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1zvSmGZWeL7RWAEcBm9oIjTfTcaBDiK4JIFwRC9Z5qI=;
 b=BiC27HDQ44LRg9RXfOjZHExAaPOFEGxSNUX1P8QoDaUcBh8HcGtMWo/XjI9KTkBpjCqf829atRtTQUtzU285LfbyFmgSUL9mKjzGT9hjoee1TATPnI0wcuCFKA23nyxvxREAKRdkP4vidPKJBTbfCFg+6WCUAN4eXASP+yAtXSs=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Tianyu Lan <ltykernel@gmail.com>, KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger
	<sthemmin@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan
 Cui <decui@microsoft.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "jgross@suse.com"
	<jgross@suse.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, "joro@8bytes.org"
	<joro@8bytes.org>, "will@kernel.org" <will@kernel.org>, "davem@davemloft.net"
	<davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>, "martin.petersen@oracle.com"
	<martin.petersen@oracle.com>, "arnd@arndb.de" <arnd@arndb.de>,
	"hch@infradead.org" <hch@infradead.org>, "m.szyprowski@samsung.com"
	<m.szyprowski@samsung.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>, "thomas.lendacky@amd.com"
	<thomas.lendacky@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, vkuznets
	<vkuznets@redhat.com>, "brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, "hch@lst.de" <hch@lst.de>,
	"parri.andrea@gmail.com" <parri.andrea@gmail.com>, "dave.hansen@intel.com"
	<dave.hansen@intel.com>
Subject: RE: [PATCH V3 5/5] hv_netvsc: Add Isolation VM support for netvsc
 driver
Thread-Topic: [PATCH V3 5/5] hv_netvsc: Add Isolation VM support for netvsc
 driver
Thread-Index: AQHX5sz1lOYUX8sXwkWf4jhcdD0xcKwhHfRw
Date: Fri, 3 Dec 2021 18:59:28 +0000
Message-ID:
 <MWHPR21MB15934DE25012A8565256336ED76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-6-ltykernel@gmail.com>
In-Reply-To: <20211201160257.1003912-6-ltykernel@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7aa46730-7ac1-4f56-a342-d06f8d3c5a0d;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-12-03T18:44:18Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e4fd0545-1fe9-490d-11ea-08d9b68f0888
x-ms-traffictypediagnostic: MW2PR2101MB1019:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <MW2PR2101MB1019D55A2C3EF51484B7E581D76A9@MW2PR2101MB1019.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:862;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ydoQvVlPfMxx+YfYtW+339jBk6xMiWetvoI6kXCiqRvtC6JfucpyOWfrd0a+h5RxygwYl1I15pZuDA/v6Wjcp3XaJ1B83XVnxyWcHSKltL3yJuiSFfAwXb7WKwZ154+PE8lS46uTBLyzoFr21VpaXTifhDJylakapYurHcVSWxqt7rOZkj9rlLmhPfRbTVUwUXqrZqjYrsGAY7idYxiUuG5Rj2qrTI+1Cvsqr3NbYEtWUINEvXyOYDmvWq0wC0c92gUaJX1U5XKYyeDdVq2OusotUAhVrhTXmkLb04/Z4ZBTzf2pZ3djvQczH1R0zfTcqyMZkFQ/HZcStt8NYkJ0cIa4AO2C2CaspPns3WLiw1h7hEbRVnUbAugzCm2Tm64htPq9XL8lIE9Iqgke5rYfmAMvVBfZwPVj9ZS/IqL3oc5A80gv+QQBaq5M0Zl/MnpPu1OcJBKmwqNVcJnyUiVuOS9RabA/rjQFKa63SHLSOfFl9lZwXAA7axn7q5ffN9ZlnJbLnoVSuw62EiPDZ+pyMTrB6z8uxekQq1O8CoN2H1lcAW/gNHrPHg34zJmH/TApJTIXZKHyl0XHBUZxx+W/a8U4OUzRedAdNFREgbEM52vLDdmUj8sbzjN4wjUH5SB4ovixqy060ke6VuebNhQBHkYGMhRIOHV2WYVJ9Tz+gv3xectNAtgHdZkeOiTk8egzDXvUNcIGI9n4GCeaSzB6uinDf7/YrcewVU2V2KDxWj2EcAQBIU3a0vW83ymH8zlCPHru2tVQ/LoBsV4dtth2iQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7406005)(83380400001)(7696005)(38100700002)(52536014)(26005)(122000001)(7416002)(33656002)(2906002)(30864003)(55016003)(8990500004)(921005)(76116006)(110136005)(10290500003)(66476007)(54906003)(508600001)(66946007)(38070700005)(71200400001)(9686003)(316002)(64756008)(4326008)(186003)(66446008)(82960400001)(8676002)(8936002)(82950400001)(5660300002)(6506007)(86362001)(66556008)(20210929001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?zro05vSCjNhuL5MHhJZOTjES/UopVWOcpIskjM1HonsMdpJeWb4uyjKZK49+?=
 =?us-ascii?Q?sPTbWrp09l4kVjrnPUElkyQPSW2rCsjz9I0uqEYXSscsthBnmLBxIn9OFuIn?=
 =?us-ascii?Q?/ko3l7vahMQIWCVgMS/3clNRo8sbdGJ5KSN2jUawD6pr/3m+Psh7Jzpt1zEQ?=
 =?us-ascii?Q?Jo7rc1X4wPqQvquhEWhM0xaZf6BcSdmfAmq5oyLzqWxYdyTJMT6D3Nv1IZoP?=
 =?us-ascii?Q?G5S6svamQHo/NG72c6H1PIyRkVThXgCZ3TFHfTKL5mSGkbfMmz3L9ofEOVkG?=
 =?us-ascii?Q?hz4W72vOpX/2jIXdE0XrP1g7TOIt9Euax44m2MkDuaA5K9MegcMEjJjBMTH7?=
 =?us-ascii?Q?uEUas+uIia4ztMbRKx7d/v0XVEjHFiAfySOL7pCa0OLlQ30Att4f6rmBQQmG?=
 =?us-ascii?Q?eG3bdaBrnYhaxeD7M7lV/Nux6v/mcc4gErL5Ek2QWc8JizuQN/XpSsJdGg9y?=
 =?us-ascii?Q?NJQ3DVOjgBuhQBPIdd9BaeNTA3YuoZHCGdMnY/cgQxDqGqvm9go9EaA1/LfZ?=
 =?us-ascii?Q?QrlLu/dnubx1sw92+WypKQcH8BRbW/a6hCxKmDjYYO9kls5FWRsTllUzPQcQ?=
 =?us-ascii?Q?AjjfxzU/CReHsPVVAjj2X+8CozdfyXNgeU3F3vNpN7gmiSiEZ7IIwa69v2Az?=
 =?us-ascii?Q?ydOhQIzKdk2xL7PZup1Qi1LaEHZKNz/4zh9H+iH9aZg6KgxkZs1PbfbdgiI1?=
 =?us-ascii?Q?pZW9idJgm8kIDWzDfxW6Z4Ycyr66zEdbkrtcVnNY7O+5BXwlxst96aJAj+va?=
 =?us-ascii?Q?uGNSZu81g3h2Acq4GNRQxb/1fdEDa01z6/9Tiu73WxzTprkmlrqV8cTO3MmJ?=
 =?us-ascii?Q?I2GixJzZjMahihMWVm+gILXztvQQjyjGEQm+2JKNRflygrVIQllAzhf/FhCS?=
 =?us-ascii?Q?+247wG9pKiyt2JF7bph+WCgID9oRz90f/AqwVG2JSdM7Uj3H7IFuCXiibXw7?=
 =?us-ascii?Q?Z5CIgeeV0XFrHXT/1Nu1vAO9ceHSzVeEL/rHUDBp67rXjOutI2+lqgWTKTeO?=
 =?us-ascii?Q?f1vR1eEABitU9o9v3kHjGkgPLwF4V7aNHXqPmzLnpgTSCQ4cQzk2oal1cAJD?=
 =?us-ascii?Q?YN/2lAfhZCo/gwpodcKhFT9/R/sNpwGwtI0+4gbTXJ3b/U7jHJDY2ZhkDRDc?=
 =?us-ascii?Q?LwIW15Tg5VbdX+hcaVnPNvMTJFSbakCQCm7cOSh+4lNhi1dWe2mnuBBb3Pig?=
 =?us-ascii?Q?/6V6BEnNe/xjAuu0yO4fc8kRTSDXPv99wtqcMFQ4Ygsmd1VYaPGOHrk/7nvz?=
 =?us-ascii?Q?wyXUbAlq1VOevie58iYz06IJn0uRxxqzKCZ3WnD9X7eDNgCwJUUU36Bc0cBl?=
 =?us-ascii?Q?jQvDM79Xd8wsUD8PEGR8F0J0vKgcxSc+1EnINQRLjntgo1ELCmE2REZSZ/fN?=
 =?us-ascii?Q?GRseoeIIFNtDnDxO2JKwMGlnQIsKBY+nAH/Jp1VZ3NbYVxiNU7LuuwvZkEz6?=
 =?us-ascii?Q?76Mg1mInYSEe7Xh27WOuH1Av+0Shqefq64UumAWF4FB2m1sBvHvYXXfx8xHq?=
 =?us-ascii?Q?ah4Ul6oRzXrIQUL5/YXRuzb1yKj618fuHOVSq+UzA+6kToluDHd4w0XfFOOq?=
 =?us-ascii?Q?5cuYbfyBTSZnEyFbShNhPGM5BuhBHX/yNn/Pq4tMkSOwJjzQ2TTma10tmB9S?=
 =?us-ascii?Q?d402NcSXuQalpQsaEegUQG2pmbbC1GUqaMH59uPaQpgJqr25hurQg7ODq8ET?=
 =?us-ascii?Q?QmrLAA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4fd0545-1fe9-490d-11ea-08d9b68f0888
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 18:59:28.7049
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NNhAqCcIO2/MvZ83887pIu/DkGlbprQSyQM4VAMD175E+8fHTfeqdSeFGghpyHZnawQeWGOLtdfagQjnJczuCNx+Z3JOc24ccqsSmogkqcU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1019

From: Tianyu Lan <ltykernel@gmail.com> Sent: Wednesday, December 1, 2021 8:=
03 AM
>=20
> In Isolation VM, all shared memory with host needs to mark visible
> to host via hvcall. vmbus_establish_gpadl() has already done it for
> netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_
> pagebuffer() stills need to be handled. Use DMA API to map/umap
> these memory during sending/receiving packet and Hyper-V swiotlb
> bounce buffer dma adress will be returned. The swiotlb bounce buffer
> has been masked to be visible to host during boot up.
>=20
> rx/tx ring buffer is allocated via vzalloc() and they need to be
> mapped into unencrypted address space(above vTOM) before sharing
> with host and accessing. Add hv_map/unmap_memory() to map/umap rx
> /tx ring buffer.
>=20
> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
> ---
> Change since v2:
>        * Add hv_map/unmap_memory() to map/umap rx/tx ring buffer.
> ---
>  arch/x86/hyperv/ivm.c             |  28 ++++++
>  drivers/hv/hv_common.c            |  11 +++
>  drivers/net/hyperv/hyperv_net.h   |   5 ++
>  drivers/net/hyperv/netvsc.c       | 136 +++++++++++++++++++++++++++++-
>  drivers/net/hyperv/netvsc_drv.c   |   1 +
>  drivers/net/hyperv/rndis_filter.c |   2 +
>  include/asm-generic/mshyperv.h    |   2 +
>  include/linux/hyperv.h            |   5 ++
>  8 files changed, 187 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> index 69c7a57f3307..9f78d8f67ea3 100644
> --- a/arch/x86/hyperv/ivm.c
> +++ b/arch/x86/hyperv/ivm.c
> @@ -287,3 +287,31 @@ int hv_set_mem_host_visibility(unsigned long kbuffer=
, int pagecount, bool visibl
>  	kfree(pfn_array);
>  	return ret;
>  }
> +
> +/*
> + * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolatio=
n VM.
> + */
> +void *hv_map_memory(void *addr, unsigned long size)
> +{
> +	unsigned long *pfns =3D kcalloc(size / HV_HYP_PAGE_SIZE,

This should be just PAGE_SIZE, as this code is unrelated to communication
with Hyper-V.

> +				      sizeof(unsigned long), GFP_KERNEL);
> +	void *vaddr;
> +	int i;
> +
> +	if (!pfns)
> +		return NULL;
> +
> +	for (i =3D 0; i < size / PAGE_SIZE; i++)
> +		pfns[i] =3D virt_to_hvpfn(addr + i * PAGE_SIZE) +

Same here:  Use virt_to_pfn().

> +			(ms_hyperv.shared_gpa_boundary >> PAGE_SHIFT);
> +
> +	vaddr =3D vmap_pfn(pfns, size / PAGE_SIZE, PAGE_KERNEL_IO);
> +	kfree(pfns);
> +
> +	return vaddr;
> +}
> +
> +void hv_unmap_memory(void *addr)
> +{
> +	vunmap(addr);
> +}
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index 7be173a99f27..3c5cb1f70319 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -295,3 +295,14 @@ u64 __weak hv_ghcb_hypercall(u64 control, void *inpu=
t, void *output, u32 input_s
>  	return HV_STATUS_INVALID_PARAMETER;
>  }
>  EXPORT_SYMBOL_GPL(hv_ghcb_hypercall);
> +
> +void __weak *hv_map_memory(void *addr, unsigned long size)
> +{
> +	return NULL;
> +}
> +EXPORT_SYMBOL_GPL(hv_map_memory);
> +
> +void __weak hv_unmap_memory(void *addr)
> +{
> +}
> +EXPORT_SYMBOL_GPL(hv_unmap_memory);
> diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_=
net.h
> index 315278a7cf88..cf69da0e296c 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -164,6 +164,7 @@ struct hv_netvsc_packet {
>  	u32 total_bytes;
>  	u32 send_buf_index;
>  	u32 total_data_buflen;
> +	struct hv_dma_range *dma_range;
>  };
>=20
>  #define NETVSC_HASH_KEYLEN 40
> @@ -1074,6 +1075,7 @@ struct netvsc_device {
>=20
>  	/* Receive buffer allocated by us but manages by NetVSP */
>  	void *recv_buf;
> +	void *recv_original_buf;
>  	u32 recv_buf_size; /* allocated bytes */
>  	struct vmbus_gpadl recv_buf_gpadl_handle;
>  	u32 recv_section_cnt;
> @@ -1082,6 +1084,7 @@ struct netvsc_device {
>=20
>  	/* Send buffer allocated by us */
>  	void *send_buf;
> +	void *send_original_buf;
>  	u32 send_buf_size;
>  	struct vmbus_gpadl send_buf_gpadl_handle;
>  	u32 send_section_cnt;
> @@ -1731,4 +1734,6 @@ struct rndis_message {
>  #define RETRY_US_HI	10000
>  #define RETRY_MAX	2000	/* >10 sec */
>=20
> +void netvsc_dma_unmap(struct hv_device *hv_dev,
> +		      struct hv_netvsc_packet *packet);
>  #endif /* _HYPERV_NET_H */
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index 396bc1c204e6..b7ade735a806 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -153,8 +153,21 @@ static void free_netvsc_device(struct rcu_head *head=
)
>  	int i;
>=20
>  	kfree(nvdev->extension);
> -	vfree(nvdev->recv_buf);
> -	vfree(nvdev->send_buf);
> +
> +	if (nvdev->recv_original_buf) {
> +		hv_unmap_memory(nvdev->recv_buf);
> +		vfree(nvdev->recv_original_buf);
> +	} else {
> +		vfree(nvdev->recv_buf);
> +	}
> +
> +	if (nvdev->send_original_buf) {
> +		hv_unmap_memory(nvdev->send_buf);
> +		vfree(nvdev->send_original_buf);
> +	} else {
> +		vfree(nvdev->send_buf);
> +	}
> +
>  	kfree(nvdev->send_section_map);
>=20
>  	for (i =3D 0; i < VRSS_CHANNEL_MAX; i++) {
> @@ -338,6 +351,7 @@ static int netvsc_init_buf(struct hv_device *device,
>  	unsigned int buf_size;
>  	size_t map_words;
>  	int i, ret =3D 0;
> +	void *vaddr;
>=20
>  	/* Get receive buffer area. */
>  	buf_size =3D device_info->recv_sections * device_info->recv_section_siz=
e;
> @@ -373,6 +387,17 @@ static int netvsc_init_buf(struct hv_device *device,
>  		goto cleanup;
>  	}
>=20
> +	if (hv_isolation_type_snp()) {
> +		vaddr =3D hv_map_memory(net_device->recv_buf, buf_size);
> +		if (!vaddr) {
> +			ret =3D -ENOMEM;
> +			goto cleanup;
> +		}
> +
> +		net_device->recv_original_buf =3D net_device->recv_buf;
> +		net_device->recv_buf =3D vaddr;
> +	}
> +
>  	/* Notify the NetVsp of the gpadl handle */
>  	init_packet =3D &net_device->channel_init_pkt;
>  	memset(init_packet, 0, sizeof(struct nvsp_message));
> @@ -476,6 +501,17 @@ static int netvsc_init_buf(struct hv_device *device,
>  		goto cleanup;
>  	}
>=20
> +	if (hv_isolation_type_snp()) {
> +		vaddr =3D hv_map_memory(net_device->send_buf, buf_size);
> +		if (!vaddr) {
> +			ret =3D -ENOMEM;
> +			goto cleanup;
> +		}
> +
> +		net_device->send_original_buf =3D net_device->send_buf;
> +		net_device->send_buf =3D vaddr;
> +	}
> +
>  	/* Notify the NetVsp of the gpadl handle */
>  	init_packet =3D &net_device->channel_init_pkt;
>  	memset(init_packet, 0, sizeof(struct nvsp_message));
> @@ -766,7 +802,7 @@ static void netvsc_send_tx_complete(struct net_device=
 *ndev,
>=20
>  	/* Notify the layer above us */
>  	if (likely(skb)) {
> -		const struct hv_netvsc_packet *packet
> +		struct hv_netvsc_packet *packet
>  			=3D (struct hv_netvsc_packet *)skb->cb;
>  		u32 send_index =3D packet->send_buf_index;
>  		struct netvsc_stats *tx_stats;
> @@ -782,6 +818,7 @@ static void netvsc_send_tx_complete(struct net_device=
 *ndev,
>  		tx_stats->bytes +=3D packet->total_bytes;
>  		u64_stats_update_end(&tx_stats->syncp);
>=20
> +		netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
>  		napi_consume_skb(skb, budget);
>  	}
>=20
> @@ -946,6 +983,88 @@ static void netvsc_copy_to_send_buf(struct netvsc_de=
vice *net_device,
>  		memset(dest, 0, padding);
>  }
>=20
> +void netvsc_dma_unmap(struct hv_device *hv_dev,
> +		      struct hv_netvsc_packet *packet)
> +{
> +	u32 page_count =3D packet->cp_partial ?
> +		packet->page_buf_cnt - packet->rmsg_pgcnt :
> +		packet->page_buf_cnt;
> +	int i;
> +
> +	if (!hv_is_isolation_supported())
> +		return;
> +
> +	if (!packet->dma_range)
> +		return;
> +
> +	for (i =3D 0; i < page_count; i++)
> +		dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma,
> +				 packet->dma_range[i].mapping_size,
> +				 DMA_TO_DEVICE);
> +
> +	kfree(packet->dma_range);
> +}
> +
> +/* netvsc_dma_map - Map swiotlb bounce buffer with data page of
> + * packet sent by vmbus_sendpacket_pagebuffer() in the Isolation
> + * VM.
> + *
> + * In isolation VM, netvsc send buffer has been marked visible to
> + * host and so the data copied to send buffer doesn't need to use
> + * bounce buffer. The data pages handled by vmbus_sendpacket_pagebuffer(=
)
> + * may not be copied to send buffer and so these pages need to be
> + * mapped with swiotlb bounce buffer. netvsc_dma_map() is to do
> + * that. The pfns in the struct hv_page_buffer need to be converted
> + * to bounce buffer's pfn. The loop here is necessary because the
> + * entries in the page buffer array are not necessarily full
> + * pages of data.  Each entry in the array has a separate offset and
> + * len that may be non-zero, even for entries in the middle of the
> + * array.  And the entries are not physically contiguous.  So each
> + * entry must be individually mapped rather than as a contiguous unit.
> + * So not use dma_map_sg() here.
> + */
> +int netvsc_dma_map(struct hv_device *hv_dev,
> +		   struct hv_netvsc_packet *packet,
> +		   struct hv_page_buffer *pb)
> +{
> +	u32 page_count =3D  packet->cp_partial ?
> +		packet->page_buf_cnt - packet->rmsg_pgcnt :
> +		packet->page_buf_cnt;
> +	dma_addr_t dma;
> +	int i;
> +
> +	if (!hv_is_isolation_supported())
> +		return 0;
> +
> +	packet->dma_range =3D kcalloc(page_count,
> +				    sizeof(*packet->dma_range),
> +				    GFP_KERNEL);
> +	if (!packet->dma_range)
> +		return -ENOMEM;
> +
> +	for (i =3D 0; i < page_count; i++) {
> +		char *src =3D phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT)
> +					 + pb[i].offset);
> +		u32 len =3D pb[i].len;
> +
> +		dma =3D dma_map_single(&hv_dev->device, src, len,
> +				     DMA_TO_DEVICE);
> +		if (dma_mapping_error(&hv_dev->device, dma)) {
> +			kfree(packet->dma_range);
> +			return -ENOMEM;
> +		}
> +
> +		/* pb[].offset and pb[].len are not changed during dma mapping
> +		 * and so not reassign.
> +		 */
> +		packet->dma_range[i].dma =3D dma;
> +		packet->dma_range[i].mapping_size =3D len;
> +		pb[i].pfn =3D dma >> HV_HYP_PAGE_SHIFT;
> +	}
> +
> +	return 0;
> +}
> +
>  static inline int netvsc_send_pkt(
>  	struct hv_device *device,
>  	struct hv_netvsc_packet *packet,
> @@ -986,14 +1105,24 @@ static inline int netvsc_send_pkt(
>=20
>  	trace_nvsp_send_pkt(ndev, out_channel, rpkt);
>=20
> +	packet->dma_range =3D NULL;
>  	if (packet->page_buf_cnt) {
>  		if (packet->cp_partial)
>  			pb +=3D packet->rmsg_pgcnt;
>=20
> +		ret =3D netvsc_dma_map(ndev_ctx->device_ctx, packet, pb);
> +		if (ret) {
> +			ret =3D -EAGAIN;
> +			goto exit;
> +		}
> +
>  		ret =3D vmbus_sendpacket_pagebuffer(out_channel,
>  						  pb, packet->page_buf_cnt,
>  						  &nvmsg, sizeof(nvmsg),
>  						  req_id);
> +
> +		if (ret)
> +			netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
>  	} else {
>  		ret =3D vmbus_sendpacket(out_channel,
>  				       &nvmsg, sizeof(nvmsg),
> @@ -1001,6 +1130,7 @@ static inline int netvsc_send_pkt(
>  				       VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
>  	}
>=20
> +exit:
>  	if (ret =3D=3D 0) {
>  		atomic_inc_return(&nvchan->queue_sends);
>=20
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_=
drv.c
> index 7e66ae1d2a59..17958533bf30 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2512,6 +2512,7 @@ static int netvsc_probe(struct hv_device *dev,
>  	net->netdev_ops =3D &device_ops;
>  	net->ethtool_ops =3D &ethtool_ops;
>  	SET_NETDEV_DEV(net, &dev->device);
> +	dma_set_min_align_mask(&dev->device, HV_HYP_PAGE_SIZE - 1);
>=20
>  	/* We always need headroom for rndis header */
>  	net->needed_headroom =3D RNDIS_AND_PPI_SIZE;
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis=
_filter.c
> index f6c9c2a670f9..448fcc325ed7 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -361,6 +361,8 @@ static void rndis_filter_receive_response(struct net_=
device *ndev,
>  			}
>  		}
>=20
> +		netvsc_dma_unmap(((struct net_device_context *)
> +			netdev_priv(ndev))->device_ctx, &request->pkt);
>  		complete(&request->wait_event);
>  	} else {
>  		netdev_err(ndev,
> diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper=
v.h
> index 3e2248ac328e..94e73ba129c5 100644
> --- a/include/asm-generic/mshyperv.h
> +++ b/include/asm-generic/mshyperv.h
> @@ -269,6 +269,8 @@ bool hv_isolation_type_snp(void);
>  u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_=
size);
>  void hyperv_cleanup(void);
>  bool hv_query_ext_cap(u64 cap_query);
> +void *hv_map_memory(void *addr, unsigned long size);
> +void hv_unmap_memory(void *addr);
>  #else /* CONFIG_HYPERV */
>  static inline bool hv_is_hyperv_initialized(void) { return false; }
>  static inline bool hv_is_hibernation_supported(void) { return false; }
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index 74f5e92f91a0..b53cfc4163af 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1584,6 +1584,11 @@ struct hyperv_service_callback {
>  	void (*callback)(void *context);
>  };
>=20
> +struct hv_dma_range {
> +	dma_addr_t dma;
> +	u32 mapping_size;
> +};
> +
>  #define MAX_SRV_VER	0x7ffffff
>  extern bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp, u8 *b=
uf, u32 buflen,
>  				const int *fw_version, int fw_vercnt,
> --
> 2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 19:11:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 19:11:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237922.412604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDxx-0006i1-UN; Fri, 03 Dec 2021 19:11:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237922.412604; Fri, 03 Dec 2021 19:11:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtDxx-0006hu-R2; Fri, 03 Dec 2021 19:11:29 +0000
Received: by outflank-mailman (input) for mailman id 237922;
 Fri, 03 Dec 2021 19:11:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIma=QU=amd.com=Thomas.Lendacky@srs-se1.protection.inumbo.net>)
 id 1mtDxw-0006ho-7f
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 19:11:28 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2061e.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::61e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cee48751-546c-11ec-976b-d102b41d0961;
 Fri, 03 Dec 2021 20:11:26 +0100 (CET)
Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12)
 by DM8PR12MB5399.namprd12.prod.outlook.com (2603:10b6:8:34::5) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4734.23; Fri, 3 Dec 2021 19:11:22 +0000
Received: from DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a]) by DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a%3]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 19:11:22 +0000
Received: from office-ryzen.texastahm.com (67.79.209.213) by
 SN4PR0801CA0002.namprd08.prod.outlook.com (2603:10b6:803:29::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 3 Dec 2021 19:11:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cee48751-546c-11ec-976b-d102b41d0961
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WBPW+Q9ypdbz/mPEtjQqV8xRsr+rBlc+UuDyn8iElIVZEKm0iL29QPKr1IYVaKDOoePYI3L73wfxT1ViwE2CdOJfAtFY0BCIi1AdKcYo5+GaA6wWxjbv9esQkhnev3hspQSZxe4qOC2V0aOxVPEsv4dCK2Wn37rZ1gTlhBS+VuEsk1rwixf6SF0tP7q7i9lbVI8NloHqDLm1eE4Cq1tTCH6Pijz8e3kg5jbw8lQYiRdNGm+mflkl1u2KhXBxEj+i3IS0h8YPtoyK8RxAIvsUrVJ7DYUzNu1IMp1Q4N+/WhCalDYRQ6TBuCflSqveTasA5QRWIKP4e/KFi7f8qFzlqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Sfmy+MHGUEfiCYS0Rl5GVzq7hAgUj6XvKDuFFGuA6Tg=;
 b=XVmTgNFiepKh0BcJr/A2eXWup80JU1zFl3qTh76kKkN73zclF3but2kRmU+LKEVHLmVAZS2ZHPr11Nqarwc3H4js8bGc1CjVSDpQjKsLgFqQzfS92fzV9Vtd0loJxSF26+NIPMhRfYmULBEtdiRmgZ3WBUsr0FQ/5o6HSZ8koNUwrRETGnjWP1QOctN3Hfgn6VZ9YLGNFmbsYCqTIk6CMpW8GGXyXtmDsBtepNQR9IvZRaCjSUBRsNAgtRjTWPD8b4wKbp9uAWRDBbXyVrtHhgEGLRhrWuFN7hovbjEvXwkRRIAAj7Ng33Q8jjDlPIT4HZykQWxZfkw9jirSJDvH0g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Sfmy+MHGUEfiCYS0Rl5GVzq7hAgUj6XvKDuFFGuA6Tg=;
 b=IDBkJzq8eV3mhPaBRRf2WQ6oS69/Pkfbpp4hU+7/DrQPoHcQtj5M0hAphz/pCKC4r1NRSQJK4wr9axnTg9uosscX2qw+Z8rRF6SuDNrdZU1SewbBIN3TUdnO7DJU/IOGsA/4uQNtIHlsacR36otf9bpSQMapX116d/CMPEa5UQY=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Subject: Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-2-ltykernel@gmail.com>
 <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
 <e78ba239-2dad-d48f-671e-f76a943052f1@gmail.com>
From: Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <06faf04c-dc4a-69fd-0be9-04f57f779ffe@amd.com>
Date: Fri, 3 Dec 2021 13:11:17 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <e78ba239-2dad-d48f-671e-f76a943052f1@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN4PR0801CA0002.namprd08.prod.outlook.com
 (2603:10b6:803:29::12) To DM4PR12MB5229.namprd12.prod.outlook.com
 (2603:10b6:5:398::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 92accadf-6adc-4fe8-1ff3-08d9b690b164
X-MS-TrafficTypeDiagnostic: DM8PR12MB5399:
X-Microsoft-Antispam-PRVS:
	<DM8PR12MB53997ADC847CF6B2F8048AE5EC6A9@DM8PR12MB5399.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FxnKwLtS83nvAhaLzvqADUsfPgwgpLbXVkI3W0oTcJv0WXep7++my1H/dbW32fZPsg7BLO2GJfbotOsdLim8SuPBvAeDGRWk2nE7xJ9hEcM+fSLtEJtVxMTzStQMY/fqXJfZSfHftOm/kXbk4XdMooRXFf/AGVdHekcnK3FLT45g7js9rUQBoW5zJWZPfpS4ermJ3QMh7L9nbQMjaLdpMjfFltGFE27O6ue1XLbLDIvf9qdkM/53ZqdrDTC+SyDzshVHcqFh1SkttAHcblE0bI1irKKmP2xt/Net53FwzZZzb+ex6Lm1T66egw9MZEULbuCu5yC98OfN2bV09OGLARZDo+8AlW5n+CU/NqVAgXgMQUbF9mcS2wPekYhZqDlX17UOYWzuNOKrrlrrpfod6EiW3m5n+acLU/4nUJKpkD/y0fFUvFRHuGv0UO42T7Sww4aKkfym93/d6sLPbhdNTEyI1kz/1czyqGeGnSQNRZRzsua7MB0yfYBCucWsvvpD0CH/yeGY6V85lnWopgPsGY7bH5kpFrRQMpF2fwacCFYnQq1FLnRuNXSGPR8qycLtBE9ElhPyKqrPJM1UmStqLDUulN+g5Krtkf/ACxd599X5v5EH1D/rGABTqVJKWDj6zEaCS/R8MNEFrzEGYUjLrsLWukJ6zvwzoYuMEUeSj+1l/n17IWje5UDakyFy0LU5OFPC9mlpXLYh5ifmAoMfmfNoElUSuEsuMpgMqqQgOCkKeIZQnFu6epOS8x0EDgyHAtIaxEIm3w3BEhqcVLzUfQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(6512007)(2616005)(36756003)(31696002)(6506007)(8936002)(26005)(31686004)(7406005)(8676002)(7416002)(38100700002)(66556008)(5660300002)(66476007)(316002)(956004)(86362001)(508600001)(921005)(66946007)(2906002)(186003)(6486002)(45080400002)(4326008)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzdDZjRRbmRZOVVxYWw1K0hPNGRCMzlQSzNBVTdnMHE3SWZLUE9YWUVrdXYx?=
 =?utf-8?B?UEZyQVVLQkNxaHZqL3FsRzhXdTl3NWk1YjFYOGZDbDZWTDN6WE10cnYwMkVR?=
 =?utf-8?B?aFlkMHg0Qkg4VGZtMXNUMmQyWHV3NTRWWjZ3TWdDY3Ywb0FuN1Yraml1clJY?=
 =?utf-8?B?ZjFiU3dGMFUrdUIxUFFZcTNmZFgycXRyK1MwNzBtZ0prdHNtVGJpMDlZZ0Nz?=
 =?utf-8?B?eFBjK2tQTnZvUXdtL0VOV2hwWXJHSkVlMXdNVDA1eHZyaUZZWUdISWViUSt1?=
 =?utf-8?B?ZUZlQlZ1d2FkOW1OdnpKWkVXSmNieXE1TWMxZWtNNkZOMWJnUEpYWktkd1c3?=
 =?utf-8?B?RkxpYVFHQzV3aTBxVkpRK2lEbW1BaTNrWUZUYThRdEhxQTlHcTdtOXNhanoz?=
 =?utf-8?B?ZzN0M2hrQi90UDZ6T2ZYUVdMSVNvcHAxNVdYbU5Mb2Q5c0hPM0RJN3VvTTQz?=
 =?utf-8?B?V0tLQzl0bXB2SWVMNkcwQ1BwcXpYSjJNaEJoeUNyYVpsM3h1VTBnQmZZN0px?=
 =?utf-8?B?bTJwQkNiQmZsNVFjSHpMSXFENzIyLy9iQTJjb0J4alphZzRXUjYxelRPQUdk?=
 =?utf-8?B?VWh4VE5uT3JadFNwYStxUTZKS2tVSk9SbTV3YVZUZWtUa0p1ZkptYk5qcFNF?=
 =?utf-8?B?VjN3d01TNzNwNERrdWtRSUZCV2lNaEIzZDNHZnRIRXJoSXp4UytTMHNpTG1T?=
 =?utf-8?B?K0wzT29KYVBhK2E2ZnFjV2o1S0lmTTMwZDNkUG9Sc1pSblNNWjU1QmFxTDVz?=
 =?utf-8?B?NW5GbGI2UGRIOEQ3NHdLRVNMNm9aQTlPK2Q4SmRWRm9CeGxKeE5qcTJtVVhH?=
 =?utf-8?B?UndXcVZVOFE1ek9FbU94a1piV2J5NnM4YUY3N2JsVjZJQ1JCbFhTMzFVbjFo?=
 =?utf-8?B?MlRBY2tLdG9IZTd0NFBHUGFUMVpTMXNzUUNrSjJmQ1ZYQTA1c2hMN2lDQVZh?=
 =?utf-8?B?NFhnZ1VqV1JGdE1nTy9Gc1FtbVZ0SUpNNXB6U2gvQWxoQXN4UTFCNklUQ2hQ?=
 =?utf-8?B?VWliKzlGRzM4RkxpZUc0SXFkSlpaczdWOHprV1ExMFpKUW13Mm1aQ0tSVlFQ?=
 =?utf-8?B?RXBwVTg1SWFXNmJ5WmlWNFBCQ1YzZzl4WUtzSWl5QzB5OU5abDNETlVGM2FM?=
 =?utf-8?B?endvLy9WR0lUNzAxelJScC83Vll6MDhnRzhVcHZmSXlxRWpyRDhrMG1SSndm?=
 =?utf-8?B?d2tCb3JoR2JoY0Y0Z3VSS1Q4c3VhdDZKTlJQaStocDNJUmRxblhURTA4NmNj?=
 =?utf-8?B?NitzMnlabVdHQW1mekZoRWNzUGdrUEQ1TFNNdmt4TmMyVGptOXlFdHJQK1pi?=
 =?utf-8?B?dHh2NjlmVWFHbWRDVTFSTllNZUorN2kwWDdrak50UlFRY1NEUFBMUktTaTAw?=
 =?utf-8?B?WVhoT1ZxTkhQb1pRMTk0YnBrQWVUSklXdXIwbGE5eWlESDRtMnNqVFUvUlYr?=
 =?utf-8?B?SzJUT2VsUFlBMWI2YnB2dVQ2VzFHRmpnWm1qYnlMNGgwak8xbDRjR1RDanVI?=
 =?utf-8?B?TkJacGxiY09Hak5IVzZpMG8wS0lPZDZVMFJYSG9mVUpXODkyOUQ3MG5kc0ZZ?=
 =?utf-8?B?TkpCaE1xR2pYaEJqUlpRMmxDNEhDNDNaOEtMd2UyUjEyc29URVBZQWZlVFNl?=
 =?utf-8?B?b1R1dW4zQTI2VDZhaUVOd0owNzlaUytKMnFVYnM5UlRBWTlsWUYyNEtGQS9L?=
 =?utf-8?B?RGVBaDAweUxBYnBKeGRHYW8zSzUwUUVhMTd2b1ZoaXM5NWZubk1QY2FZd1pa?=
 =?utf-8?B?dm43KzlJSUlMTkpYdnVrUlpiRlJJcERGeXJxWW90eTFYM01tWXlLSUdadzU4?=
 =?utf-8?B?aHNkdlprZG9IR3RaZE9MekhoM3Z5NHdXWDJ6bU5PRUR5andlaFllZmdpcyto?=
 =?utf-8?B?SGx2cU5YRENaUkllQzJ6NXlJL1hlQkZpZUhrU2lBdm84Um81TGJvQ3VtSzYx?=
 =?utf-8?B?S2tUUmtLdFJIb3VsZkMrVmxXeERiMHA5ZDZ1TGpTMS9iSkJtUUdzU1ZYUWpW?=
 =?utf-8?B?U3p2dk05d25XS3RKTk1PRkNpY1Z0QzY1ZmwvZ0s0M1VPcG9sbWNMSFlsMFZy?=
 =?utf-8?B?TWlvVjk3NHplbW9oY0xzcU9hbXlxeFNXUDJ0bGNnNGl5dmMvdHpoMkRGaTV4?=
 =?utf-8?B?RS8yYTFOZ3IrUXk1Q3BqVW9IUTYrVzRSbGdxMHJSanh4KzNXclphcEtSbnJN?=
 =?utf-8?Q?VgqsU58cgRcU2iV8tTEgFs8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92accadf-6adc-4fe8-1ff3-08d9b690b164
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 19:11:22.0576
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z/wjtckrxKQppp3WLCFKpwtEtvRoebkt7iogo0Vxo4Ee8u//UJxSgedThS8vkFUtBS6/kaDwRBtG+Uu4/S5w4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5399

On 12/3/21 5:20 AM, Tianyu Lan wrote:
> On 12/2/2021 10:42 PM, Tom Lendacky wrote:
>> On 12/1/21 10:02 AM, Tianyu Lan wrote:
>>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>>
>>> In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
>>> extra address space which is above shared_gpa_boundary (E.G 39 bit
>>> address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
>>> physical address will be original physical address + shared_gpa_boundary.
>>> The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
>>> memory(vTOM). Memory addresses below vTOM are automatically treated as
>>> private while memory above vTOM is treated as shared.
>>>
>>> Expose swiotlb_unencrypted_base for platforms to set unencrypted
>>> memory base offset and platform calls swiotlb_update_mem_attributes()
>>> to remap swiotlb mem to unencrypted address space. memremap() can
>>> not be called in the early stage and so put remapping code into
>>> swiotlb_update_mem_attributes(). Store remap address and use it to copy
>>> data from/to swiotlb bounce buffer.
>>>
>>> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>
>> This patch results in the following stack trace during a bare-metal boot
>> on my EPYC system with SME active (e.g. mem_encrypt=on):
>>
>> [    0.123932] BUG: Bad page state in process swapper  pfn:108001
>> [    0.123942] page:(____ptrval____) refcount:0 mapcount:-128 
>> mapping:0000000000000000 index:0x0 pfn:0x108001
>> [    0.123946] flags: 0x17ffffc0000000(node=0|zone=2|lastcpupid=0x1fffff)
>> [    0.123952] raw: 0017ffffc0000000 ffff88904f2d5e80 ffff88904f2d5e80 
>> 0000000000000000
>> [    0.123954] raw: 0000000000000000 0000000000000000 00000000ffffff7f 
>> 0000000000000000
>> [    0.123955] page dumped because: nonzero mapcount
>> [    0.123957] Modules linked in:
>> [    0.123961] CPU: 0 PID: 0 Comm: swapper Not tainted 
>> 5.16.0-rc3-sos-custom #2
>> [    0.123964] Hardware name: AMD Corporation
>> [    0.123967] Call Trace:
>> [    0.123971]  <TASK>
>> [    0.123975]  dump_stack_lvl+0x48/0x5e
>> [    0.123985]  bad_page.cold+0x65/0x96
>> [    0.123990]  __free_pages_ok+0x3a8/0x410
>> [    0.123996]  memblock_free_all+0x171/0x1dc
>> [    0.124005]  mem_init+0x1f/0x14b
>> [    0.124011]  start_kernel+0x3b5/0x6a1
>> [    0.124016]  secondary_startup_64_no_verify+0xb0/0xbb
>> [    0.124022]  </TASK>
>>
>> I see ~40 of these traces, each for different pfns.
>>
>> Thanks,
>> Tom
> 
> Hi Tom:
>        Thanks for your test. Could you help to test the following patch 
> and check whether it can fix the issue.

The patch is mangled. Is the only difference where set_memory_decrypted() 
is called?

Thanks,
Tom

> 
> 
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index 569272871375..f6c3638255d5 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
>    * @end:       The end address of the swiotlb memory pool. Used to do a 
> quick
>    *             range check to see if the memory was in fact allocated by 
> this
>    *             API.
> + * @vaddr:     The vaddr of the swiotlb memory pool. The swiotlb memory pool
> + *             may be remapped in the memory encrypted case and store 
> virtual
> + *             address for bounce buffer operation.
>    * @nslabs:    The number of IO TLB blocks (in groups of 64) between 
> @start and
>    *             @end. For default swiotlb, this is command line 
> adjustable via
>    *             setup_io_tlb_npages.
> @@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
>   struct io_tlb_mem {
>          phys_addr_t start;
>          phys_addr_t end;
> +       void *vaddr;
>          unsigned long nslabs;
>          unsigned long used;
>          unsigned int index;
> @@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct device 
> *dev)
>   }
>   #endif /* CONFIG_DMA_RESTRICTED_POOL */
> 
> +extern phys_addr_t swiotlb_unencrypted_base;
> +
>   #endif /* __LINUX_SWIOTLB_H */
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index 8e840fbbed7c..34e6ade4f73c 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -50,6 +50,7 @@
>   #include <asm/io.h>
>   #include <asm/dma.h>
> 
> +#include <linux/io.h>
>   #include <linux/init.h>
>   #include <linux/memblock.h>
>   #include <linux/iommu-helper.h>
> @@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;
> 
>   struct io_tlb_mem io_tlb_default_mem;
> 
> +phys_addr_t swiotlb_unencrypted_base;
> +
>   /*
>    * Max segment that we can provide which (if pages are contingous) will
>    * not be bounced (unless SWIOTLB_FORCE is set).
> @@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
>          return DIV_ROUND_UP(val, IO_TLB_SIZE);
>   }
> 
> +/*
> + * Remap swioltb memory in the unencrypted physical address space
> + * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
> + * Isolation VMs).
> + */
> +void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
> +{
> +       void *vaddr = NULL;
> +
> +       if (swiotlb_unencrypted_base) {
> +               phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
> +
> +               vaddr = memremap(paddr, bytes, MEMREMAP_WB);
> +               if (!vaddr)
> +                       pr_err("Failed to map the unencrypted memory %llx 
> size %lx.\n",
> +                              paddr, bytes);
> +       }
> +
> +       return vaddr;
> +}
> +
>   /*
>    * Early SWIOTLB allocation may be too early to allow an architecture to
>    * perform the desired operations.  This function allows the 
> architecture to
> @@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
>          vaddr = phys_to_virt(mem->start);
>          bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
>          set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
> -       memset(vaddr, 0, bytes);
> +
> +       mem->vaddr = swiotlb_mem_remap(mem, bytes);
> +       if (!mem->vaddr)
> +               mem->vaddr = vaddr;
> +
> +       memset(mem->vaddr, 0, bytes);
>   }
> 
>   static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t 
> start,
> @@ -196,7 +225,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem 
> *mem, phys_addr_t start,
>                  mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
>                  mem->slots[i].alloc_size = 0;
>          }
> +
> +       /*
> +        * If swiotlb_unencrypted_base is set, the bounce buffer memory will
> +        * be remapped and cleared in swiotlb_update_mem_attributes.
> +        */
> +       if (swiotlb_unencrypted_base)
> +               return;
> +
>          memset(vaddr, 0, bytes);
> +       mem->vaddr = vaddr;
> +       return;
>   }
> 
>   int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int 
> verbose)
> @@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, 
> phys_addr_t tlb_addr, size_t size
>          phys_addr_t orig_addr = mem->slots[index].orig_addr;
>          size_t alloc_size = mem->slots[index].alloc_size;
>          unsigned long pfn = PFN_DOWN(orig_addr);
> -       unsigned char *vaddr = phys_to_virt(tlb_addr);
> +       unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
>          unsigned int tlb_offset, orig_addr_offset;
> 
>          if (orig_addr == INVALID_PHYS_ADDR)
> 
> 
> Thanks.
> 


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 19:18:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 19:18:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237930.412614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtE47-0007Tm-PN; Fri, 03 Dec 2021 19:17:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237930.412614; Fri, 03 Dec 2021 19:17:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtE47-0007Tf-MK; Fri, 03 Dec 2021 19:17:51 +0000
Received: by outflank-mailman (input) for mailman id 237930;
 Fri, 03 Dec 2021 19:17:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtE46-0007TV-DD; Fri, 03 Dec 2021 19:17:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtE46-0003MQ-7S; Fri, 03 Dec 2021 19:17:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtE45-0000cC-Qs; Fri, 03 Dec 2021 19:17:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtE45-0001YP-QO; Fri, 03 Dec 2021 19:17:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XNM2hQDfmfsWcIs1//8EnStcYqOahUgDpR9bf3inPFs=; b=WWCZjNLRaz8boVRjCjvVJJyMVY
	SoR9Kej8ziEWrrAC2mf4KHsYBM/+ybHmgepK38C5YgkeF/TyZLGUmaeVMGLft7ZJuldx8OS/Q52Zy
	Iyq87IT7PL/62Byen7k7lELudP4OwGwF+jLgGjN9ILUAVPqO7JkwWPOzI9vlqpqtZv84=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167058-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167058: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    qemu-mainline:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-arndale:guest-start:fail:regression
    qemu-mainline:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-xsm:guest-start.2:fail:regression
    qemu-mainline:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-multivcpu:guest-start.2:fail:regression
    qemu-mainline:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt:guest-start:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:regression
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-start:fail:allowable
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a69254a2b320e31d3aa63ca910b7aa02efcd5492
X-Osstest-Versions-That:
    qemuu=50456a6794fbb8dc94a31eb9534e91c586da7add
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 19:17:49 +0000

flight 167058 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167058/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166954
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-arndale  14 guest-start              fail REGR. vs. 166954
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt    20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-shadow  22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt     20 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt-xsm 21 guest-start.2            fail REGR. vs. 166954
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-multivcpu 23 guest-start.2           fail REGR. vs. 166954
 test-amd64-i386-xl-shadow   22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-xsm      22 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-multivcpu 14 guest-start             fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-libvirt     14 guest-start              fail REGR. vs. 166954
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166954
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166954
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166954
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail REGR. vs. 166954

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     14 guest-start              fail REGR. vs. 166954
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166954

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166954
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166954
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166954
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166954
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166954
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                a69254a2b320e31d3aa63ca910b7aa02efcd5492
baseline version:
 qemuu                50456a6794fbb8dc94a31eb9534e91c586da7add

Last test of basis   166954  2021-11-30 08:39:11 Z    3 days
Failing since        166968  2021-12-01 06:37:45 Z    2 days    4 attempts
Testing same since   167058  2021-12-03 01:55:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eduardo Habkost <ehabkost@redhat.com>
  John Snow <jsnow@redhat.com>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 fail    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit a69254a2b320e31d3aa63ca910b7aa02efcd5492
Merge: 682aa69b1f cc20926e9b
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Thu Dec 2 08:49:51 2021 -0800

    Merge tag 'ide-pull-request' of https://gitlab.com/jsnow/qemu into staging
    
    Pull request
    
    # gpg: Signature made Wed 01 Dec 2021 10:17:38 PM PST
    # gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
    # gpg: Good signature from "John Snow (John Huston) <jsnow@redhat.com>" [full]
    
    * tag 'ide-pull-request' of https://gitlab.com/jsnow/qemu:
      tests/qtest/fdc-test: Add a regression test for CVE-2021-20196
      hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196
      hw/block/fdc: Extract blk_create_empty_drive()
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit cc20926e9b8077bff6813efc8dcdeae90d1a3b10
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date:   Wed Nov 24 17:15:36 2021 +0100

    tests/qtest/fdc-test: Add a regression test for CVE-2021-20196
    
    Without the previous commit, when running 'make check-qtest-i386'
    with QEMU configured with '--enable-sanitizers' we get:
    
      AddressSanitizer:DEADLYSIGNAL
      =================================================================
      ==287878==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000344
      ==287878==The signal is caused by a WRITE memory access.
      ==287878==Hint: address points to the zero page.
          #0 0x564b2e5bac27 in blk_inc_in_flight block/block-backend.c:1346:5
          #1 0x564b2e5bb228 in blk_pwritev_part block/block-backend.c:1317:5
          #2 0x564b2e5bcd57 in blk_pwrite block/block-backend.c:1498:11
          #3 0x564b2ca1cdd3 in fdctrl_write_data hw/block/fdc.c:2221:17
          #4 0x564b2ca1b2f7 in fdctrl_write hw/block/fdc.c:829:9
          #5 0x564b2dc49503 in portio_write softmmu/ioport.c:201:9
    
    Add the reproducer for CVE-2021-20196.
    
    Suggested-by: Alexander Bulekov <alxndr@bu.edu>
    Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Message-id: 20211124161536.631563-4-philmd@redhat.com
    Signed-off-by: John Snow <jsnow@redhat.com>

commit 1ab95af033a419e7a64e2d58e67dd96b20af5233
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date:   Wed Nov 24 17:15:35 2021 +0100

    hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196
    
    Guest might select another drive on the bus by setting the
    DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR).
    The current controller model doesn't expect a BlockBackend
    to be NULL. A simple way to fix CVE-2021-20196 is to create
    an empty BlockBackend when it is missing. All further
    accesses will be safely handled, and the controller state
    machines keep behaving correctly.
    
    Cc: qemu-stable@nongnu.org
    Fixes: CVE-2021-20196
    Reported-by: Gaoning Pan (Ant Security Light-Year Lab) <pgn@zju.edu.cn>
    Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
    Reviewed-by: Hanna Reitz <hreitz@redhat.com>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Message-id: 20211124161536.631563-3-philmd@redhat.com
    BugLink: https://bugs.launchpad.net/qemu/+bug/1912780
    Resolves: https://gitlab.com/qemu-project/qemu/-/issues/338
    Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
    Reviewed-by: Hanna Reitz <hreitz@redhat.com>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Signed-off-by: John Snow <jsnow@redhat.com>

commit b154791e7b6d4ca5cdcd54443484d97360bd7ad2
Author: Philippe Mathieu-Daudé <philmd@redhat.com>
Date:   Wed Nov 24 17:15:34 2021 +0100

    hw/block/fdc: Extract blk_create_empty_drive()
    
    We are going to re-use this code in the next commit,
    so extract it as a new blk_create_empty_drive() function.
    
    Inspired-by: Hanna Reitz <hreitz@redhat.com>
    Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
    Message-id: 20211124161536.631563-2-philmd@redhat.com
    Signed-off-by: John Snow <jsnow@redhat.com>

commit 682aa69b1f4dd5f2905a94066fa4c853adc33251
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Wed Dec 1 07:20:06 2021 +0100

    Update version for v6.2.0-rc3 release
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit 24c4cd1311a45fa8ecfcde2f7b7afe84eb17dfac
Author: Eduardo Habkost <ehabkost@redhat.com>
Date:   Tue Nov 30 15:47:22 2021 -0500

    MAINTAINERS: Change my email address
    
    The ehabkost@redhat.com email address will stop working on
    2021-12-01, change it to my personal email address.
    
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211129163053.2506734-1-ehabkost@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <20211130204722.2732997-2-ehabkost@redhat.com>
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 19:18:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 19:18:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237932.412629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtE4E-0007ny-9G; Fri, 03 Dec 2021 19:17:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237932.412629; Fri, 03 Dec 2021 19:17:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtE4E-0007nr-5Y; Fri, 03 Dec 2021 19:17:58 +0000
Received: by outflank-mailman (input) for mailman id 237932;
 Fri, 03 Dec 2021 19:17:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Gfv3=QU=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1mtE4D-0007mm-0l
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 19:17:57 +0000
Received: from na01-obe.outbound.protection.outlook.com
 (mail-cusazlp170100000.outbound.protection.outlook.com
 [2a01:111:f403:c111::])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b690d6c8-546d-11ec-b1df-f38ee3fbfdf7;
 Fri, 03 Dec 2021 20:17:55 +0100 (CET)
Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11)
 by CO1PR21MB1299.namprd21.prod.outlook.com (2603:10b6:303:162::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.8; Fri, 3 Dec
 2021 19:17:43 +0000
Received: from MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::40d7:92be:b38f:a9cd]) by MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::40d7:92be:b38f:a9cd%3]) with mapi id 15.20.4778.007; Fri, 3 Dec 2021
 19:17:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b690d6c8-546d-11ec-b1df-f38ee3fbfdf7
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jlKkrXUDcjSaNNJAmPpDb3GnG4BvTfHy7JIcGJ25CIsnqiPnj9B2WpEoec91L8M1tmuTxzFRrGvRF1qRfjO/OP5i8KjpOSvHmbqIBBNSa2l3Q794Z6gY3/9o3oizsYa7eu/2VpLShpxEk1r/dzqz8dRQoNqTClgg9Q4n+1aIV/lT3e+c2PZhbc0cJqhhBw7ogFRiTs9lqYKpmadq+EZDcN3OkmJiAOpZRIjcRwQtAMEQKyX67lMASghe2aR48ukHI7TauoHTPJKwXCIR/5RQUBzSu7wYLZR5I898X5AdMxj54eoVVyl40aE/7txCkeoA8c77dW8JhO16XxB/RciWqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6QKFdHkFnmZT/268ovAJY1KqmJi2qAxqEcFjgnH4g64=;
 b=JnPxzOiHuefFYRrAZ9sUvaEgfLdkslk0r1Dk0X74KmObG4JajOPTTFzTQbuwseQ9fecaM3yV7dB4ru0VvUdUgpQxcxt++G16wXsu2kRZMEdCCP74DTS0SqD3sJUhzU6QFmqMbFnDGuh5c4DRb+WQltU2qTLlfOXIQ361HlDV+ksF/2AF43walPj66pmyvGX5bWORlsYFAlJg9VhXapWG8zTpWF3NagmwKWzPi/TqrrNxw3WaDu24C3UKmSqB1bxoblP/zKO3YyvpgfsJN/21r4JGHZpMnjjIosJBeEdJmzq8o4g+GpSqfZ4IVFPUOFH+OHnioZ1Us7h1elMzOeDuWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6QKFdHkFnmZT/268ovAJY1KqmJi2qAxqEcFjgnH4g64=;
 b=F4f5y9mW5sziN9S049BCwGy644n4tQfdiDac8kcj2CaJTB4JHGdjVrqlZP4O9lQIeCuHyByjnA36lcVBg9Q5ItpBs7/z5D12gQDEwp3IBmnA+m8s6Z7kxw2+2S0o7B5sEFc5oy/w3i6uUitVjWKvBNSevbRXURUz+C0XA0bc2OE=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Tianyu Lan <ltykernel@gmail.com>, KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>, Stephen Hemminger
	<sthemmin@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan
 Cui <decui@microsoft.com>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>, "x86@kernel.org"
	<x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>, "jgross@suse.com"
	<jgross@suse.com>, "sstabellini@kernel.org" <sstabellini@kernel.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>, "joro@8bytes.org"
	<joro@8bytes.org>, "will@kernel.org" <will@kernel.org>, "davem@davemloft.net"
	<davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>, "martin.petersen@oracle.com"
	<martin.petersen@oracle.com>, "arnd@arndb.de" <arnd@arndb.de>,
	"hch@infradead.org" <hch@infradead.org>, "m.szyprowski@samsung.com"
	<m.szyprowski@samsung.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	Tianyu Lan <Tianyu.Lan@microsoft.com>, "thomas.lendacky@amd.com"
	<thomas.lendacky@amd.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, vkuznets
	<vkuznets@redhat.com>, "brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>, "hch@lst.de" <hch@lst.de>,
	"parri.andrea@gmail.com" <parri.andrea@gmail.com>, "dave.hansen@intel.com"
	<dave.hansen@intel.com>
Subject: RE: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Thread-Topic: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Thread-Index: AQHX5sz0da2bpS4G3kSooomr0KO256whJnrA
Date: Fri, 3 Dec 2021 19:17:43 +0000
Message-ID:
 <MWHPR21MB159390BE1B546A6F90FB1F18D76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-4-ltykernel@gmail.com>
In-Reply-To: <20211201160257.1003912-4-ltykernel@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8dd46aee-85bd-466d-b3ba-54bde5af1115;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-12-03T19:14:48Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5251b19c-f02a-416f-2cf4-08d9b6919537
x-ms-traffictypediagnostic: CO1PR21MB1299:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <CO1PR21MB129956038B1237CE51CE9D01D76A9@CO1PR21MB1299.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:287;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 qssSGgFrOaU2Eb0f+jm0raF00qJOlEhq+s2N0a/GMEn8KAhYprTvxQ1Q0qqmkdtpLgmI7LOE2EkqYo/8SvOXZ5qWNbQYXn6gqN+QWMmz/ng707O+PvuwhklHXXmkwYqGP+HiDCrI2LWjvjbUbeu9o5abs+eycew6AJsjtFq2+fQqNdqHoe6GXPKFyxYtvIn58nqcYQiNLc4qNiDn3bhnurSzP9f/YMjHFGvNgDZ7VZv11XG1MDpH3AM0cKZPqyKMDoWhaL0V2AoX/lh0tBk9MOGG/+xY5rkOidd/HbAyz4jlL7tElcFiCuxVYU+LC2FnjnMi7qLnHrwKsOR7Q+v+qwFwb+U/3frqJgoumJCFIhsGRIxHFp2So5t+dlchh7fX8HM3P9coVd61B2Dwl6ML0UDAg+J6eJ06IdTntrndEbT6uyICVYbBrx/3RPgJ+B/KLBzTEa62crE97ioPbdysJ+kpk0hzWrYeOmlaHSfuyo80tuhjEVJQlagmVM7xNGcaItU05oIQL30BiBr8yUUQmgahER9ILYxL+i2tDz3EERL3TliQzHLI+ahYp643y+uytrG/GvL7E1GDLfNXHCVfo7dPrJ8ocgt9vOeNA5/Of4j9X6YvURck+tCoxXzcFMiFpKbB/7sLoyVT9Gnvp+f9YtKGfWBTKWnEAytOvXwKVV4B9b0OD4pN7LRBcp9C4yh/84w/AeYXDqISCpJVJ5J9S1lcpTrq8ulB70mIHSnqgH35kii0lMXY+aM4QpGIR9jPJe0K/NPtdQlsbeeVV+qEew==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(83380400001)(8936002)(7406005)(921005)(508600001)(66446008)(4326008)(5660300002)(7416002)(8676002)(2906002)(6506007)(186003)(38070700005)(71200400001)(7696005)(26005)(54906003)(66476007)(33656002)(66946007)(82950400001)(66556008)(316002)(82960400001)(8990500004)(38100700002)(55016003)(86362001)(64756008)(122000001)(52536014)(9686003)(10290500003)(110136005)(76116006)(20210929001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?jBeCuWxzy9lXQ1RGnkwZuvWLCe0xsZmEQsPvNgGdjFdd7qTKknJgagkEtoE7?=
 =?us-ascii?Q?sLk14MZO3Ptt3Np0cVK3pZXWUiOlbNyXFaMz8ywvMmqM7AQyDZEaQU8gAZlT?=
 =?us-ascii?Q?nSKnWwPr3tMAie5RPq3SgmJiKcwNho+qJwIZXS53FupmBckz0bEBY5KsMGTP?=
 =?us-ascii?Q?lDZhi/huUEOGuFPEk5kBHyHoHz6O8kd63tF+7CAW6AANKxxlghAQ3UoAInga?=
 =?us-ascii?Q?g25nnfeGkdYJX37Hcr/IRlPFLEjLBORrvFK63jh2c0XUNQtjZZhZDRFKir+X?=
 =?us-ascii?Q?7qIK3SWD45omT0AA4hI7/yxPP9SI6lXwG/BYcv6PX3Gk8HQmZ/tdR2cIG/wP?=
 =?us-ascii?Q?iBNDoM+3fCDPSMEUAD72RcdSlWcXPrxqAfVKSJ7Ah9yj8iFXS0uW/DIRHqDQ?=
 =?us-ascii?Q?rnGh182oDyYmJ4ozxT0r5IJF6ldVo+JEbXaKL4cbnOmdGdPcawjr5fHJn7E4?=
 =?us-ascii?Q?RU7V5tbrv7qHS2A1JoM8H3OEKF6iUl58mSaO/AV0J48FxCcRBSVQ+PCmPkVb?=
 =?us-ascii?Q?gkViz2dezigg9kpGMBZXMKoWMw7fdaQc4Ae0dwGdYBsrlZrRCIEA23V8jZWM?=
 =?us-ascii?Q?ri25h3bBgDjPh4RsKqXUqNC/DGvXPfgwX2dw9DXnAC/XLXY9l4JlAbhuNgIe?=
 =?us-ascii?Q?ExKhW218kg7HKuPMYpXvLfloHG6du+Fb8SQi8XNdmO0mZDnhn0XPo49Te5Kb?=
 =?us-ascii?Q?4PyM8XJRwd6T5LYKD5HqNgOu1Bs+2RXWIdDCGZminvxeNKilu2PP40hZEPtN?=
 =?us-ascii?Q?g2vsTXLp1bOtcLdU9iqO060yqntt8Tjz5nrOcHSBFkpnn0sLX9GSWUbNhgkC?=
 =?us-ascii?Q?ra2MVc4j8Fp2sN6siO9/tz1luMtRRL3evw8Tq8jvcSo1iy0RtsRMb43PQCSW?=
 =?us-ascii?Q?MhIOTkzLYK/hEkLr8kqf6XMoBXzI2imYrq+lgRLtFIlQ/X8PKUuWOGfWuPkI?=
 =?us-ascii?Q?+7TnG5ZQ+O6IWo+NAaadJjKSNK+IVj5pHTaUjyh++lkMzKC4tT7OmVmxDYJ3?=
 =?us-ascii?Q?RmjvnQ59+JUrE0GovOtk5+eXaTqex4Ku94348VjRA6+yEzt0iKoEI01jhOjD?=
 =?us-ascii?Q?F/VuTos6AN5tDxim3qQ0q0tsqZKZz3W8aVHgdazhI78EoQnWRAi+jJZzh3+q?=
 =?us-ascii?Q?3uXQgzqIayA1hZsLFN6kDUqzqzNsbi4rOuJVYYdMfCt0G7xqJvNE7FkHqF5X?=
 =?us-ascii?Q?S/QzDoMu2R7JIdzDqnEL6E4+N1rY7g/8WoCFimDtV/QHVHkV31nPN6P8NTwu?=
 =?us-ascii?Q?6oa8Ea+dwgv9OAYiAMhV8L11HsA+3cqKxcQJdrEX77hsujebIwk/17lspS4L?=
 =?us-ascii?Q?Fo5xGMPaBhopYAJmUleikiEfP51nuQuDgdLDnCXRxTg8z9KGvGic7gImEFCv?=
 =?us-ascii?Q?y5oSA1G3KjjSxWBWZPYk6NeBCcgo9HZu95Lh8c3u7QztqyXcvoLtxyEOtVBG?=
 =?us-ascii?Q?iuE36Q0iu7AYgd+g0n02wj6bDn7klluBiKL+2MwqcB0iwfVduxYtvb/kJHP4?=
 =?us-ascii?Q?Zue0N/21HfGiNe/sx4kgGiVyn8RSfDlAlfEat+HB1jQ4JcxRhK+uqW7bpvZM?=
 =?us-ascii?Q?Z3Q5JFGpJa7sYJQDay9GIbxtmX2cWoQGRZzLeMShag9fL64bCpkHz5fXRjiC?=
 =?us-ascii?Q?wJNI4H7xdLvv4OyT5IEhzDFFqzjmwUSudZTT+fTigq4eenix64m0EzMbZZlW?=
 =?us-ascii?Q?n3Uaug=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5251b19c-f02a-416f-2cf4-08d9b6919537
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 19:17:43.7670
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gfd7gGbGDucndglGUVBEZe+9MhoIEPbgrtNFc5E50IBzPbi/E3o+H9w/csb+P3jKFZNhFVm3CidK/R8ICH5tF40HXiW+F6TCfi2K8gxo1kc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR21MB1299

From: Tianyu Lan <ltykernel@gmail.com> Sent: Wednesday, December 1, 2021 8:=
03 AM
>=20
> hyperv Isolation VM requires bounce buffer support to copy
> data from/to encrypted memory and so enable swiotlb force
> mode to use swiotlb bounce buffer for DMA transaction.
>=20
> In Isolation VM with AMD SEV, the bounce buffer needs to be
> accessed via extra address space which is above shared_gpa_boundary
> (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
> The access physical address will be original physical address +
> shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
> spec is called virtual top of memory(vTOM). Memory addresses below
> vTOM are automatically treated as private while memory above
> vTOM is treated as shared.
>=20
> Hyper-V initalizes swiotlb bounce buffer and default swiotlb
> needs to be disabled. pci_swiotlb_detect_override() and
> pci_swiotlb_detect_4gb() enable the default one. To override
> the setting, hyperv_swiotlb_detect() needs to run before
> these detect functions which depends on the pci_xen_swiotlb_
> init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
> _detect() to keep the order.
>=20
> Swiotlb bounce buffer code calls set_memory_decrypted()
> to mark bounce buffer visible to host and map it in extra
> address space via memremap. Populate the shared_gpa_boundary
> (vTOM) via swiotlb_unencrypted_base variable.
>=20
> The map function memremap() can't work in the early place
> hyperv_iommu_swiotlb_init() and so call swiotlb_update_mem_attributes()
> in the hyperv_iommu_swiotlb_later_init().
>=20
> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
> ---
>  arch/x86/xen/pci-swiotlb-xen.c |  3 +-
>  drivers/hv/vmbus_drv.c         |  3 ++
>  drivers/iommu/hyperv-iommu.c   | 56 ++++++++++++++++++++++++++++++++++
>  include/linux/hyperv.h         |  8 +++++
>  4 files changed, 69 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xe=
n.c
> index 46df59aeaa06..30fd0600b008 100644
> --- a/arch/x86/xen/pci-swiotlb-xen.c
> +++ b/arch/x86/xen/pci-swiotlb-xen.c
> @@ -4,6 +4,7 @@
>=20
>  #include <linux/dma-map-ops.h>
>  #include <linux/pci.h>
> +#include <linux/hyperv.h>
>  #include <xen/swiotlb-xen.h>
>=20
>  #include <asm/xen/hypervisor.h>
> @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void)
>  EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
>=20
>  IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
> -		  NULL,
> +		  hyperv_swiotlb_detect,
>  		  pci_xen_swiotlb_init,
>  		  NULL);
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 392c1ac4f819..0a64ccfafb8b 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -33,6 +33,7 @@
>  #include <linux/random.h>
>  #include <linux/kernel.h>
>  #include <linux/syscore_ops.h>
> +#include <linux/dma-map-ops.h>
>  #include <clocksource/hyperv_timer.h>
>  #include "hyperv_vmbus.h"
>=20
> @@ -2078,6 +2079,7 @@ struct hv_device *vmbus_device_create(const guid_t =
*type,
>  	return child_device_obj;
>  }
>=20
> +static u64 vmbus_dma_mask =3D DMA_BIT_MASK(64);
>  /*
>   * vmbus_device_register - Register the child device
>   */
> @@ -2118,6 +2120,7 @@ int vmbus_device_register(struct hv_device *child_d=
evice_obj)
>  	}
>  	hv_debug_add_dev_dir(child_device_obj);
>=20
> +	child_device_obj->device.dma_mask =3D &vmbus_dma_mask;
>  	return 0;
>=20
>  err_kset_unregister:
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index e285a220c913..dd729d49a1eb 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -13,14 +13,20 @@
>  #include <linux/irq.h>
>  #include <linux/iommu.h>
>  #include <linux/module.h>
> +#include <linux/hyperv.h>
> +#include <linux/io.h>
>=20
>  #include <asm/apic.h>
>  #include <asm/cpu.h>
>  #include <asm/hw_irq.h>
>  #include <asm/io_apic.h>
> +#include <asm/iommu.h>
> +#include <asm/iommu_table.h>
>  #include <asm/irq_remapping.h>
>  #include <asm/hypervisor.h>
>  #include <asm/mshyperv.h>
> +#include <asm/swiotlb.h>
> +#include <linux/dma-direct.h>
>=20
>  #include "irq_remapping.h"
>=20
> @@ -337,4 +343,54 @@ static const struct irq_domain_ops hyperv_root_ir_do=
main_ops =3D {
>  	.free =3D hyperv_root_irq_remapping_free,
>  };
>=20
> +static void __init hyperv_iommu_swiotlb_init(void)
> +{
> +	unsigned long hyperv_io_tlb_size;
> +	void *hyperv_io_tlb_start;
> +
> +	/*
> +	 * Allocate Hyper-V swiotlb bounce buffer at early place
> +	 * to reserve large contiguous memory.
> +	 */
> +	hyperv_io_tlb_size =3D swiotlb_size_or_default();
> +	hyperv_io_tlb_start =3D memblock_alloc(hyperv_io_tlb_size, PAGE_SIZE);
> +
> +	if (!hyperv_io_tlb_start)
> +		pr_warn("Fail to allocate Hyper-V swiotlb buffer.\n");

In the error case, won't swiotlb_init_with_tlb() end up panic'ing when
it tries to zero out the memory?   The only real choice here is to
return immediately after printing the message, and not call
swiotlb_init_with_tlb().

> +
> +	swiotlb_init_with_tbl(hyperv_io_tlb_start,
> +			      hyperv_io_tlb_size >> IO_TLB_SHIFT, true);
> +}
> +
> +int __init hyperv_swiotlb_detect(void)
> +{
> +	if (!hypervisor_is_type(X86_HYPER_MS_HYPERV))
> +		return 0;
> +
> +	if (!hv_is_isolation_supported())
> +		return 0;
> +
> +	/*
> +	 * Enable swiotlb force mode in Isolation VM to
> +	 * use swiotlb bounce buffer for dma transaction.
> +	 */
> +	if (hv_isolation_type_snp())
> +		swiotlb_unencrypted_base =3D ms_hyperv.shared_gpa_boundary;
> +	swiotlb_force =3D SWIOTLB_FORCE;
> +	return 1;
> +}
> +
> +static void __init hyperv_iommu_swiotlb_later_init(void)
> +{
> +	/*
> +	 * Swiotlb bounce buffer needs to be mapped in extra address
> +	 * space. Map function doesn't work in the early place and so
> +	 * call swiotlb_update_mem_attributes() here.
> +	 */
> +	swiotlb_update_mem_attributes();
> +}
> +
> +IOMMU_INIT_FINISH(hyperv_swiotlb_detect,
> +		  NULL, hyperv_iommu_swiotlb_init,
> +		  hyperv_iommu_swiotlb_later_init);
>  #endif
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index b823311eac79..1f037e114dc8 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1726,6 +1726,14 @@ int hyperv_write_cfg_blk(struct pci_dev *dev, void=
 *buf, unsigned int len,
>  int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context,
>  				void (*block_invalidate)(void *context,
>  							 u64 block_mask));
> +#if IS_ENABLED(CONFIG_HYPERV)
> +int __init hyperv_swiotlb_detect(void);
> +#else
> +static inline int __init hyperv_swiotlb_detect(void)
> +{
> +	return 0;
> +}
> +#endif
>=20
>  struct hyperv_pci_block_ops {
>  	int (*read_block)(struct pci_dev *dev, void *buf, unsigned int buf_len,
> --
> 2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 20:07:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 20:07:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237953.412645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtEpq-00061R-NN; Fri, 03 Dec 2021 20:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237953.412645; Fri, 03 Dec 2021 20:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtEpq-00061K-KM; Fri, 03 Dec 2021 20:07:10 +0000
Received: by outflank-mailman (input) for mailman id 237953;
 Fri, 03 Dec 2021 20:07:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yIma=QU=amd.com=Thomas.Lendacky@srs-se1.protection.inumbo.net>)
 id 1mtEpq-00061E-1w
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 20:07:10 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on20603.outbound.protection.outlook.com
 [2a01:111:f400:7e89::603])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95a391be-5474-11ec-a5e1-b9374ead2679;
 Fri, 03 Dec 2021 21:07:08 +0100 (CET)
Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12)
 by DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 20:07:02 +0000
Received: from DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a]) by DM4PR12MB5229.namprd12.prod.outlook.com
 ([fe80::1ddd:71e4:5803:e44a%3]) with mapi id 15.20.4734.028; Fri, 3 Dec 2021
 20:07:02 +0000
Received: from office-ryzen.texastahm.com (67.79.209.213) by
 SN6PR16CA0051.namprd16.prod.outlook.com (2603:10b6:805:ca::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Fri, 3 Dec 2021 20:06:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95a391be-5474-11ec-a5e1-b9374ead2679
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CWdLt9Du38kEfy+ZifqRZ0BbExQJ0JqFhGZGtflLSZpRvaGEiVj3E6ui81fZtSU5NV8RJOqhD7oHWbPzNZ40QqjSJ3LRqcLz4CTSUZsgIPRk8319c8Tyu5w6p6MJEE9lytkmbym8LeNaJcU0O51Gk52cmzB1pPj+Cd8zsSrZyGDWSOGf/XK24DW6sKSTI1PAWrrYV58L6hbTA8VtzVcjBn7xC0eHJw2s/2xzOOJo2DZOOscAfrB5i2U/rCQeceb9pLC2C+O4R0C8h4NOM7R+gYfcjqtJUXNFn+79bqYl+EDYUC3jabySlcXPhG7Hvpi1iBJ4JE7mhZYTvwDitZWSRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qU7G+ZiaWrsg+p7MM9oMcVNwq3c0SZRE6z6LspM1vKA=;
 b=fhS71m0B1eSNcWNeVIym6bYyLZhYCd07WLuvrBOtFhFnsXoq6res7GochKz9dmCTXTg3M2Fi5EAt/9MxIcDeaIB0KVbtfLilmtq6PDml5v6sklTj2qwqHUaDVs1DRcvicYqRbbFa+UuwPBmDo1yJjNR5WYqHPinj+wPQxsNY7Qy1UZdU1uJl3rQg2I2kLurzDptnveN2yIIq7d/ZMT7otskoD05AXHoxVvwVujTWjGSW8mMVBZg7haBc53UsmYpzNGYopWFjMR7lDfC/fOVukiVE7JXKE2YRHu2VLKVGJilAHYm4u2GZ20+BrqQxTzC3HXLR9E2UBZ4NcEe1+8SWZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qU7G+ZiaWrsg+p7MM9oMcVNwq3c0SZRE6z6LspM1vKA=;
 b=D8lmOURMOLEy5n1O1VpgG7PBLINbz5CbTx9hrG1dABsPmaqaCjF7b0oDXHR6TolLODpB4miIleymZVg/bACcvPDHKvlWPBeXasuGZkOd5X2Piyh6n/TYdhF5kH13+zfDvnzsr16ZN3Q5zbJEbINHQZRQzVYp3cPjlmwAAxYq7M0=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Subject: Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-2-ltykernel@gmail.com>
 <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
 <e78ba239-2dad-d48f-671e-f76a943052f1@gmail.com>
 <06faf04c-dc4a-69fd-0be9-04f57f779ffe@amd.com>
Message-ID: <1b7b8e20-a861-ab26-26a1-dad1eb80a461@amd.com>
Date: Fri, 3 Dec 2021 14:06:58 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <06faf04c-dc4a-69fd-0be9-04f57f779ffe@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN6PR16CA0051.namprd16.prod.outlook.com
 (2603:10b6:805:ca::28) To DM4PR12MB5229.namprd12.prod.outlook.com
 (2603:10b6:5:398::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4dd0dd4e-1914-4c16-3f9c-08d9b698784c
X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:
X-Microsoft-Antispam-PRVS:
	<DM4PR12MB5070F11FF25976AA7BF5A2A9EC6A9@DM4PR12MB5070.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o1WNw3gw4sfxpai0SCYeyLMCLThQbioDmSsgisuE3MtWeyEiUaoAAxqFmr/0PFnseMEaMaI8MxYD4Vh7wBVYBC8K72RXfAhwHunGXZpjvNF2dVRsfA+aBE9KbYqOvnDF1/UkF5qxik975l/HnWWxdxoxnQ7czlUdmdAGH8DwPb5Acf5CyHhiFSC0Plvx1mMkXA5CChp2++XnS1/ILz1zlEUqE1bsZz0uYvt3KIp63T2VtAbjmlQxNMK7J0FFVlRRWgsEJop205ZwxVjjx9jfQPuyVOF/Onv319UGWcDlk8jxcQnaMsynX7w+OnL+yV8GcJpGHd4QrHRLznSWbKux0BcDU64OF0tSKFCR0dGuhLv6I9VXTYyZwuwfr33owb+so4+o7osKduHkjgdI0vt7dLmXyx4rwYcFPxksnSGvWs+iSjj2Um73H6dl+49+f00NCOWiDcYluudYZ5bDmO/syt4LT2N2lWi1cZPdC1ctzgWTX8/ztpvBxQG0A5k0det4AMuCrOn41yR06f2QWThLvoXiaulYZobBByhb+VWfnAXYT1t3e0/unNchZ6VdS0KPR3H5IuV49cI6Pk+FhNQ64i4xaWhANAss0YNT6rGqLrTHlQLFyV+6GcK96vPmF15fGL7An5X5lfYVAEW7n9TZzmyu12WR+sHCgK7KbVBUrFVsTlWNzpdVV9mSgSllUr8O/Tvwc9S45RvSE8kZD/7pvxhcxQrASK2wDTIN/z9yFarWhHZOJ7XnJWZsJIt0JqI5WhTVtFx07mR1mvVNvg1oeQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(4326008)(31696002)(921005)(38100700002)(6512007)(36756003)(86362001)(8676002)(186003)(2616005)(5660300002)(7406005)(7416002)(956004)(31686004)(66556008)(6506007)(53546011)(66476007)(66946007)(8936002)(2906002)(45080400002)(6486002)(26005)(508600001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anNOVERHVG5TTGR0emFJM203UWprTXVTM01zSVdUa00wWnJ4Um9UamEwSjZP?=
 =?utf-8?B?UHdwcWtJR0ZiMFVOTnp4TzhNWGxXNkU4YytSRVE0ZlR6Sml2Z0lBdVFQR1hx?=
 =?utf-8?B?SlRxV3NvdEl4SUttWmFnNGVGTGtnbVBiVTM5NlNWeFc3MnNXdzRCbHYwYXpB?=
 =?utf-8?B?UU1aZC8xNm1jYnJoOUtsa3FIeGJ5ZTNyclhnd01TbVlEQ2ROQU4wb1l2dERR?=
 =?utf-8?B?ZStVTnN5ejJxT2k3aGxVcjY2TXNNOEVjRzZHY3VveXpjZUVxQ0RPVTJrWTB6?=
 =?utf-8?B?TEVxS2pGWk5PK2R1a1VjditxT1NvMzVQazd4SXpUd092cVNIZ1MvaFJXYnNs?=
 =?utf-8?B?MnlVSnprT3VWSG52V0w1Z0w0R0ZOZG9nMmVFaDhnV2czSDljTWsyTkRXZm1z?=
 =?utf-8?B?dUFhSWRxSnhza2E1OTJZbW9OeHJxZ0gyUDhnWkIyZFpwbUR1VGdOdktBQ1RS?=
 =?utf-8?B?NGZiQlRnZ3hsdXdwY3NTeVRValZZd0ZZcjFYZ2RHNng4dUtHaU9saVlWY2NC?=
 =?utf-8?B?SWhUVjNENXJlYlNaWXcvaTVkSytFTGxDNnNnYzBmdUdaVGQxMFBRVmQ5VDY4?=
 =?utf-8?B?RmhDOWI5Q0F4RU5iUDc4bVRVN21UWFpYM2lBUmpQZzhLbmNIRmd4YzJnWk9M?=
 =?utf-8?B?Yk5UVXkzNCthVndJUkdzcWF1Lzh2S3J1MGN6ZFl2bEMwWXgrMkQ3dUd0VnB2?=
 =?utf-8?B?NFM0K2xyZjlkOWZhTWptczVjWDBMdjBBTVphSTVudDFrMDJqUS95MXI5SjBn?=
 =?utf-8?B?MS8vVkEzWVMxZ2FrdzdQSEpKNFRwQ1Q5TktOdG1GRUdkMCtwbUJKRHlUUmVW?=
 =?utf-8?B?MjJkLzlNWm9tRWZBZjVvSEZvZHdyNW9MUWo1VnpNU2llYlBGUk8zTTlHUWti?=
 =?utf-8?B?dUllYlk5WGpqQ0doK3FyYWFTdURMMTMrcUcvNUJqeEVDdGtpeFNVTU44SUdB?=
 =?utf-8?B?eVhONmNjd0wyNm1rR1hnUVNhUmVYZjQ1Uk1aRnF1aG5iZVU3WWUzQ0wzUjd0?=
 =?utf-8?B?ZExES2ZuUFk4ME9GT1lpa2p5OU1oWE50UklxSDBmenVGWW11eUhjcDNoZDdS?=
 =?utf-8?B?RzhCcVB6VENDSWRPeDQzZ2N2NnlKKzFzSTNkaW9sNGp6cEtQdnNjNWU4YnBU?=
 =?utf-8?B?UDhwbUxwNmFQb1pkTm0vaSs4R3pjZ0xyM25ZMXdtYTNsdFArQkJUazVjaGwx?=
 =?utf-8?B?WFNPc3ZEbFJIUzk5UDllZ0wyb0pEYUdHRmdFN2JLMGlwengxcmtMOEc5Z3Ja?=
 =?utf-8?B?K1E1RWtIK2JjTEE2ZEM4bjNvdDU2eU9KM3VHeUZ1U1lDL09BWHZEUFlQUEVm?=
 =?utf-8?B?UldzbmJEOGlrUFBFT2NFUWpFK1k3TFQwb1lhcnVWcWhDL0l5b1FEZ21TM2po?=
 =?utf-8?B?SnlTVk5nL2lPdVBDVm13YW1YZnJJZk5XOERadmJpM3M2YVMrY3NYK0IrdU9D?=
 =?utf-8?B?aTY3cDFMY2hLS1JWdkQ2S05CZzY0ak9XSmVtUDZURnh2Rm50d0VOS0FoYWVQ?=
 =?utf-8?B?MVUzbGg3Q0xnNjZKK0s4d2FCblNIaDhRS0t3YWt4QVZRN1BnMWYyWmEyUVFZ?=
 =?utf-8?B?eHU2cEpoUDRsTElnNkY4Ry9WY3lZc0kzWEJmNnRoMk1aUytxeStubG1DZlI3?=
 =?utf-8?B?VHAxeC9yZWdKZDVNc3Y4ZzV0UTVCUWhPMlgwcjlCclZxUlB2T0hLTVRWTWp6?=
 =?utf-8?B?UkQ3RkVnNnR5UXRIeHBBMktaczJNRjBZZkNrRmVBa3lDMGdqY25sNWg3MEFB?=
 =?utf-8?B?QXNtQ0s0b1FVbG8zSGNJNVJ0THNZUDZYT2xXTnZUY29lZUI0UWxGTHY0K3hS?=
 =?utf-8?B?T0tqUmEwTDBDV3N3RFR2azd1RHpzTks4SFBnOEx3cldPa0hPZTNCZ0NmbnJR?=
 =?utf-8?B?Z09mM0FMb3dkL2dXbE5VZDRGTTRoR3hwL2pWV1BCTmpDRjVWdFlaUmpJOGN1?=
 =?utf-8?B?bW0wSGVIc2JJc1lHYXdDM2pLUTgvdlZEbzh6ZWkwUG9zeW95UHhqSkY3aDk0?=
 =?utf-8?B?dm83ODl0YWYrcjF6SUJTWTJxUnBjMXZySkZmWGJVbXhleWl4dnJCT2ZPSDJN?=
 =?utf-8?B?RklRUjZuVnlxNE5XQjFRUjZmL21BK040dWpwQmIrNXpxY3hBcFZweUdqOW1F?=
 =?utf-8?B?aEltay92RzV4dUNhd2lMZDA2QlVHNG5QRnZVQ3U4dmZaM1JXbWhIL3Z3eEpQ?=
 =?utf-8?Q?iAy2VZ1220VEuoGkCOuhywE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd0dd4e-1914-4c16-3f9c-08d9b698784c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 20:07:02.1054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FNFDqGR43QFLZPhB63ocWTL6UWhWK+2BmgzGd4pfDMYVnGmtlXQNiWgVo2GTMo0Lkzq5sI8C7GcF6s1/lkSayg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5070

On 12/3/21 1:11 PM, Tom Lendacky wrote:
> On 12/3/21 5:20 AM, Tianyu Lan wrote:
>> On 12/2/2021 10:42 PM, Tom Lendacky wrote:
>>> On 12/1/21 10:02 AM, Tianyu Lan wrote:
>>>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>>>
>>>> In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
>>>> extra address space which is above shared_gpa_boundary (E.G 39 bit
>>>> address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
>>>> physical address will be original physical address + shared_gpa_boundary.
>>>> The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
>>>> memory(vTOM). Memory addresses below vTOM are automatically treated as
>>>> private while memory above vTOM is treated as shared.
>>>>
>>>> Expose swiotlb_unencrypted_base for platforms to set unencrypted
>>>> memory base offset and platform calls swiotlb_update_mem_attributes()
>>>> to remap swiotlb mem to unencrypted address space. memremap() can
>>>> not be called in the early stage and so put remapping code into
>>>> swiotlb_update_mem_attributes(). Store remap address and use it to copy
>>>> data from/to swiotlb bounce buffer.
>>>>
>>>> Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>>
>>> This patch results in the following stack trace during a bare-metal boot
>>> on my EPYC system with SME active (e.g. mem_encrypt=on):
>>>
>>> [    0.123932] BUG: Bad page state in process swapper  pfn:108001
>>> [    0.123942] page:(____ptrval____) refcount:0 mapcount:-128 
>>> mapping:0000000000000000 index:0x0 pfn:0x108001
>>> [    0.123946] flags: 0x17ffffc0000000(node=0|zone=2|lastcpupid=0x1fffff)
>>> [    0.123952] raw: 0017ffffc0000000 ffff88904f2d5e80 ffff88904f2d5e80 
>>> 0000000000000000
>>> [    0.123954] raw: 0000000000000000 0000000000000000 00000000ffffff7f 
>>> 0000000000000000
>>> [    0.123955] page dumped because: nonzero mapcount
>>> [    0.123957] Modules linked in:
>>> [    0.123961] CPU: 0 PID: 0 Comm: swapper Not tainted 
>>> 5.16.0-rc3-sos-custom #2
>>> [    0.123964] Hardware name: AMD Corporation
>>> [    0.123967] Call Trace:
>>> [    0.123971]  <TASK>
>>> [    0.123975]  dump_stack_lvl+0x48/0x5e
>>> [    0.123985]  bad_page.cold+0x65/0x96
>>> [    0.123990]  __free_pages_ok+0x3a8/0x410
>>> [    0.123996]  memblock_free_all+0x171/0x1dc
>>> [    0.124005]  mem_init+0x1f/0x14b
>>> [    0.124011]  start_kernel+0x3b5/0x6a1
>>> [    0.124016]  secondary_startup_64_no_verify+0xb0/0xbb
>>> [    0.124022]  </TASK>
>>>
>>> I see ~40 of these traces, each for different pfns.
>>>
>>> Thanks,
>>> Tom
>>
>> Hi Tom:
>>        Thanks for your test. Could you help to test the following patch 
>> and check whether it can fix the issue.
> 
> The patch is mangled. Is the only difference where set_memory_decrypted() 
> is called?

I de-mangled the patch. No more stack traces with SME active.

Thanks,
Tom

> 
> Thanks,
> Tom
> 
>>
>>
>> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
>> index 569272871375..f6c3638255d5 100644
>> --- a/include/linux/swiotlb.h
>> +++ b/include/linux/swiotlb.h
>> @@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
>>    * @end:       The end address of the swiotlb memory pool. Used to do 
>> a quick
>>    *             range check to see if the memory was in fact allocated 
>> by this
>>    *             API.
>> + * @vaddr:     The vaddr of the swiotlb memory pool. The swiotlb memory 
>> pool
>> + *             may be remapped in the memory encrypted case and store 
>> virtual
>> + *             address for bounce buffer operation.
>>    * @nslabs:    The number of IO TLB blocks (in groups of 64) between 
>> @start and
>>    *             @end. For default swiotlb, this is command line 
>> adjustable via
>>    *             setup_io_tlb_npages.
>> @@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
>>   struct io_tlb_mem {
>>          phys_addr_t start;
>>          phys_addr_t end;
>> +       void *vaddr;
>>          unsigned long nslabs;
>>          unsigned long used;
>>          unsigned int index;
>> @@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct 
>> device *dev)
>>   }
>>   #endif /* CONFIG_DMA_RESTRICTED_POOL */
>>
>> +extern phys_addr_t swiotlb_unencrypted_base;
>> +
>>   #endif /* __LINUX_SWIOTLB_H */
>> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
>> index 8e840fbbed7c..34e6ade4f73c 100644
>> --- a/kernel/dma/swiotlb.c
>> +++ b/kernel/dma/swiotlb.c
>> @@ -50,6 +50,7 @@
>>   #include <asm/io.h>
>>   #include <asm/dma.h>
>>
>> +#include <linux/io.h>
>>   #include <linux/init.h>
>>   #include <linux/memblock.h>
>>   #include <linux/iommu-helper.h>
>> @@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;
>>
>>   struct io_tlb_mem io_tlb_default_mem;
>>
>> +phys_addr_t swiotlb_unencrypted_base;
>> +
>>   /*
>>    * Max segment that we can provide which (if pages are contingous) will
>>    * not be bounced (unless SWIOTLB_FORCE is set).
>> @@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
>>          return DIV_ROUND_UP(val, IO_TLB_SIZE);
>>   }
>>
>> +/*
>> + * Remap swioltb memory in the unencrypted physical address space
>> + * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
>> + * Isolation VMs).
>> + */
>> +void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
>> +{
>> +       void *vaddr = NULL;
>> +
>> +       if (swiotlb_unencrypted_base) {
>> +               phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
>> +
>> +               vaddr = memremap(paddr, bytes, MEMREMAP_WB);
>> +               if (!vaddr)
>> +                       pr_err("Failed to map the unencrypted memory 
>> %llx size %lx.\n",
>> +                              paddr, bytes);
>> +       }
>> +
>> +       return vaddr;
>> +}
>> +
>>   /*
>>    * Early SWIOTLB allocation may be too early to allow an architecture to
>>    * perform the desired operations.  This function allows the 
>> architecture to
>> @@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
>>          vaddr = phys_to_virt(mem->start);
>>          bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
>>          set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
>> -       memset(vaddr, 0, bytes);
>> +
>> +       mem->vaddr = swiotlb_mem_remap(mem, bytes);
>> +       if (!mem->vaddr)
>> +               mem->vaddr = vaddr;
>> +
>> +       memset(mem->vaddr, 0, bytes);
>>   }
>>
>>   static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, 
>> phys_addr_t start,
>> @@ -196,7 +225,17 @@ static void swiotlb_init_io_tlb_mem(struct 
>> io_tlb_mem *mem, phys_addr_t start,
>>                  mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
>>                  mem->slots[i].alloc_size = 0;
>>          }
>> +
>> +       /*
>> +        * If swiotlb_unencrypted_base is set, the bounce buffer memory 
>> will
>> +        * be remapped and cleared in swiotlb_update_mem_attributes.
>> +        */
>> +       if (swiotlb_unencrypted_base)
>> +               return;
>> +
>>          memset(vaddr, 0, bytes);
>> +       mem->vaddr = vaddr;
>> +       return;
>>   }
>>
>>   int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int 
>> verbose)
>> @@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, 
>> phys_addr_t tlb_addr, size_t size
>>          phys_addr_t orig_addr = mem->slots[index].orig_addr;
>>          size_t alloc_size = mem->slots[index].alloc_size;
>>          unsigned long pfn = PFN_DOWN(orig_addr);
>> -       unsigned char *vaddr = phys_to_virt(tlb_addr);
>> +       unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
>>          unsigned int tlb_offset, orig_addr_offset;
>>
>>          if (orig_addr == INVALID_PHYS_ADDR)
>>
>>
>> Thanks.
>>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 20:34:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 20:34:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237961.412656 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtFFo-0001F3-UZ; Fri, 03 Dec 2021 20:34:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237961.412656; Fri, 03 Dec 2021 20:34:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtFFo-0001Ew-Rg; Fri, 03 Dec 2021 20:34:00 +0000
Received: by outflank-mailman (input) for mailman id 237961;
 Fri, 03 Dec 2021 20:33:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=u6Th=QU=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mtFFn-0001Eq-6c
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 20:33:59 +0000
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com
 [2a00:1450:4864:20::42a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5601af36-5478-11ec-8a4d-196798b21f7b;
 Fri, 03 Dec 2021 21:33:57 +0100 (CET)
Received: by mail-wr1-x42a.google.com with SMTP id q3so8135471wru.5
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 12:33:56 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id q26sm3512045wrc.39.2021.12.03.12.33.54
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 03 Dec 2021 12:33:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5601af36-5478-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=P3/coR+Ce+KVGKSZhioMDcgTipywu+ws8A9dJr646ig=;
        b=LyzHFQOJydTY0dTQ9IiPnaEzQOlDFtUpNULqLvhCU+K3+vxJBHyZ39531/gGP4l29e
         s/bSiNsOMg76kEpKtK/cseYGHUAIehIy09cgowPrKeqUBufjB0Ytmzjy3Bm0nL32CX1h
         r3NN2dUyeJgRBL69Pur7sUk7ykuKOoYBZ3OYzDtixffTlhON5hmU1uJYXw45mFrbqKav
         c72EI1R9MMnx5//Cd1LnBmbvrqkyUGiv6pvxLmeGDX/k3exScS0Dxt28JyGaSIGCJPlX
         pFFWgJqogsf0hkSWMCSjt6sq/sK+K6I4nV//Qqzk/50Afs6xgIva5e79qBKTrqwukVl5
         6Njg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=P3/coR+Ce+KVGKSZhioMDcgTipywu+ws8A9dJr646ig=;
        b=Q6J5kLeN4AzIioSS45f6OcaU/6JCXFHclft5rd6bK5Y/BRNI9+jFHyHgf1eRQSEZas
         G35DPsSyQ4PCVlB8qZt0Kpqs/YHb5ZWkV3qxyNAeTnVDoPM3NXaOQ9fijnY1ajMWimzA
         +t7iIcmkCueBCZHruexSBGQha1G9njCzkfpqMgeiK91yDd+5gpfcg90K4sXozxDt1i87
         gEoXxASZjbwFBCeiiqUcBfiwjsHO4wD9+12u1WAt/XO74WhpWhQgPltpzotTxXwDEK3S
         JOdSf3YJNLqUMEKrJn6B1uueilzzL70v/VWZ5C1O/n9vrq1dNkPw14BxPHHI1/s3bjOr
         ZVxQ==
X-Gm-Message-State: AOAM531oYe9iiBnURzqqr+q869WL0sPHKGwaGZ63RTI30l3HdbDRoAJp
	q8M9Hi6URjsmwqDqIDMpPGoCuTQiWnw=
X-Google-Smtp-Source: ABdhPJzCPEm5ernGdJkUaeY4aMhqxbyqZEf73lTI/M/t1xgZ1oGcrHhjca1bEcrvEV7ChopMEhPfew==
X-Received: by 2002:adf:fa81:: with SMTP id h1mr23769190wrr.27.1638563635137;
        Fri, 03 Dec 2021 12:33:55 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Bob Eshleman <bobbyeshleman@gmail.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Connor Davis <connojdavis@gmail.com>
Subject: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
Date: Fri,  3 Dec 2021 22:33:30 +0200
Message-Id: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Rework Arm implementation to store grant table frame GFN
in struct page_info directly instead of keeping it in
standalone status/shared arrays. This patch is based on
the assumption that grant table page is the xenheap page.

To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
to hold 52-bit/28-bit + extra bit value respectively. In order
to not grow the size of struct page_info borrow the required
amount of bits from type_info's count portion which current
context won't suffer (currently only 1 bit is used on Arm).
Please note, to minimize code changes and avoid introducing
an extra #ifdef-s to the header, we keep the same amount of
bits on both subarches, although the count portion on Arm64
could be wider, so we waste some bits here.

Introduce corresponding PGT_* constructs and access macros.
Update existing gnttab macros to deal with GFN value according
to new location. Also update the use of count portion on Arm
in share_xen_page_with_guest().

While at it, extend this simplified M2P-like approach for any
xenheap pages which are proccessed in xenmem_add_to_physmap_one()
except foreign ones. Update the code to set GFN portion after
establishing new mapping for the xenheap page in said function
and to clean GFN portion when putting a reference on that page
in p2m_put_l3_page().

And for everything to work correctly introduce arch-specific
macros arch_alloc_(free)xenheap_page to be called from
alloc_(free)xenheap_pages() respectively, the former's purpose
on Arm is to clear the GFN portion before use, the latter was
left dummy for now. On x86 both are just stubs.

This patch is intended to fix the potential issue on Arm
which might happen when remapping grant-table frame.
A guest (or the toolstack) will unmap the grant-table frame
using XENMEM_remove_physmap. This is a generic hypercall,
so on x86, we are relying on the fact the M2P entry will
be cleared on removal. For architecture without the M2P,
the GFN would still be present in the grant frame/status
array. So on the next call to map the page, we will end up to
request the P2M to remove whatever mapping was the given GFN.
This could well be another mapping.

Besides that, this patch simplifies arch code on Arm by
removing arrays and corresponding management code and
as the result gnttab_init_arch/gnttab_destroy_arch helpers
and struct grant_table_arch become useless and can be
dropped globally.

Suggested-by: Julien Grall <jgrall@amazon.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Dear @RISC-V maintainers, please note in current patch I drop arch
specific gnttab_init(destroy)_arch helpers as unneeded for both Arm and x86.
Please let me know if you are going to reuse them in the nearest future and
I will retain them.

You can find the related discussions at:
https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-54412190171c@xen.org/
https://lore.kernel.org/xen-devel/1628890077-12545-1-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1631652245-30746-1-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/

Changes RFC1 -> RFC2:
 - update patch description
 - add/update comments in code
 - clarify check in p2m_put_l3_page()
 - introduce arch_alloc_xenheap_page() and arch_free_xenheap_page()
   and drop page_arch_init()
 - add ASSERT to gnttab_shared_page() and gnttab_status_page()
 - rework changes to Arm's struct page_info: do not split type_info,
   allocate GFN portion by reducing count portion, create corresponding
   PGT_* construct, etc
 - update page_get_frame_gfn() and page_set_frame_gfn()
 - update the use of count portion on Arm
 - drop the leading underscore in the macro parameter names

Changes RFC2 -> RFC3:
 - update patch description
 - drop PGT_count_base and MASK_INSR() in share_xen_page_with_guest()
 - update alloc_xenheap_page() and free_xenheap_page() for SEPARATE_XENHEAP
   case (Arm32)
 - provide an extra bit for GFN portion, to get PGT_INVALID_FRAME_GFN
   one bit more than the maximum number of physical address bits on Arm32

Changes RFC3 -> V4:
 - rebase on Jan's "gnttab: remove guest_physmap_remove_page() call
   from gnttab_map_frame()"
 - finally resolve locking question by recent Julien's suggestion,
   so drop the RFC tag
 - update comments in Arm's mm.h/p2m.c to not mention grant table
 - convert page_set(get)_frame_gfn to static inline func and
   rename them to page_set(get)_xenheap_gfn()
 - rename PGT_INVALID_FRAME_GFN to PGT_INVALID_XENHEAP_GFN
 - add ASSERT(is_xen_heap_page(...)) in page_set(get)_frame_gfn
 - remove BUG_ON() in arch_free_xenheap_page
 - remove local type_info in share_xen_page_with_guest()
 - remove an extra argument p2m in p2m_put_l3_page()
 - remove #ifdef CONFIG_GRANT_TABLE in p2m_put_l3_page()
 - also cover real-only pages by using p2m_is_ram instead of a check
   against p2m_ram_rw in p2m_put_l3_page() and use "else if" construct
 - call arch_free_xenheap_page() before clearing the PGC_xen_heap in
   free_xenheap_pages()
 - remove ASSERT() in gnttab_shared(status)_page and use simpler
   virt_to_page
 - remove local pg_ in gnttab_shared(status)_gfn
 - update patch description to reflect recent changes
---
 xen/arch/arm/mm.c                 | 24 ++++++++++++++--
 xen/arch/arm/p2m.c                |  7 +++--
 xen/common/grant_table.c          |  9 ------
 xen/common/page_alloc.c           | 20 +++++++++++++-
 xen/include/asm-arm/grant_table.h | 58 ++++++++++++---------------------------
 xen/include/asm-arm/mm.h          | 39 ++++++++++++++++++++++++--
 xen/include/asm-x86/grant_table.h |  5 ----
 xen/include/asm-x86/mm.h          |  4 +++
 8 files changed, 102 insertions(+), 64 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index eea926d..4f4cab3 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1382,8 +1382,10 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d,
     spin_lock(&d->page_alloc_lock);
 
     /* The incremented type count pins as writable or read-only. */
-    page->u.inuse.type_info =
-        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1;
+    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask);
+    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none
+                                                  : PGT_writable_page) |
+                                MASK_INSR(1, PGT_count_mask);
 
     page_set_owner(page, d);
     smp_wmb(); /* install valid domain ptr before updating refcnt. */
@@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
     }
 
     /* Map at new location. */
-    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
+    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
+        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
+    else
+    {
+        struct p2m_domain *p2m = p2m_get_hostp2m(d);
+
+        p2m_write_lock(p2m);
+        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) )
+        {
+            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access);
+            if ( !rc )
+                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
+        }
+        else
+            rc = -EBUSY;
+        p2m_write_unlock(p2m);
+    }
 
     /*
      * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 8b20b43..fd8aff9 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -720,6 +720,8 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn,
  */
 static void p2m_put_l3_page(const lpae_t pte)
 {
+    mfn_t mfn = lpae_get_mfn(pte);
+
     ASSERT(p2m_is_valid(pte));
 
     /*
@@ -731,11 +733,12 @@ static void p2m_put_l3_page(const lpae_t pte)
      */
     if ( p2m_is_foreign(pte.p2m.type) )
     {
-        mfn_t mfn = lpae_get_mfn(pte);
-
         ASSERT(mfn_valid(mfn));
         put_page(mfn_to_page(mfn));
     }
+    /* Detect the xenheap page and mark the stored GFN as invalid. */
+    else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) )
+        page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN);
 }
 
 /* Free lpae sub-tree behind an entry */
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 0262f2c..01d7a29 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -94,8 +94,6 @@ struct grant_table {
 
     /* Domain to which this struct grant_table belongs. */
     struct domain *domain;
-
-    struct grant_table_arch arch;
 };
 
 unsigned int __read_mostly opt_max_grant_frames = 64;
@@ -1997,14 +1995,9 @@ int grant_table_init(struct domain *d, int max_grant_frames,
 
     grant_write_lock(gt);
 
-    ret = gnttab_init_arch(gt);
-    if ( ret )
-        goto unlock;
-
     /* gnttab_grow_table() allocates a min number of frames, so 0 is okay. */
     ret = gnttab_grow_table(d, 0);
 
- unlock:
     grant_write_unlock(gt);
 
  out:
@@ -3911,8 +3904,6 @@ grant_table_destroy(
     if ( t == NULL )
         return;
 
-    gnttab_destroy_arch(t);
-
     for ( i = 0; i < nr_grant_frames(t); i++ )
         free_xenheap_page(t->shared_raw[i]);
     xfree(t->shared_raw);
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index d0baaa2..2306d9a 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2161,6 +2161,7 @@ void init_xenheap_pages(paddr_t ps, paddr_t pe)
 void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 {
     struct page_info *pg;
+    unsigned int i;
 
     ASSERT(!in_irq());
 
@@ -2169,6 +2170,9 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
     if ( unlikely(pg == NULL) )
         return NULL;
 
+    for ( i = 0; i < (1u << order); i++ )
+        arch_alloc_xenheap_page(&pg[i]);
+
     memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));
 
     return page_to_virt(pg);
@@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
 
 void free_xenheap_pages(void *v, unsigned int order)
 {
+    struct page_info *pg;
+    unsigned int i;
+
     ASSERT(!in_irq());
 
     if ( v == NULL )
         return;
 
+    pg = virt_to_page(v);
+
     memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
 
-    free_heap_pages(virt_to_page(v), order, false);
+    for ( i = 0; i < (1u << order); i++ )
+        arch_free_xenheap_page(&pg[i]);
+
+    free_heap_pages(pg, order, false);
 }
 
 #else  /* !CONFIG_SEPARATE_XENHEAP */
@@ -2220,7 +2232,10 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
         return NULL;
 
     for ( i = 0; i < (1u << order); i++ )
+    {
         pg[i].count_info |= PGC_xen_heap;
+        arch_alloc_xenheap_page(&pg[i]);
+    }
 
     return page_to_virt(pg);
 }
@@ -2238,7 +2253,10 @@ void free_xenheap_pages(void *v, unsigned int order)
     pg = virt_to_page(v);
 
     for ( i = 0; i < (1u << order); i++ )
+    {
+        arch_free_xenheap_page(&pg[i]);
         pg[i].count_info &= ~PGC_xen_heap;
+    }
 
     free_heap_pages(pg, order, true);
 }
diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
index d31a4d6..d6fda31 100644
--- a/xen/include/asm-arm/grant_table.h
+++ b/xen/include/asm-arm/grant_table.h
@@ -11,11 +11,6 @@
 #define INITIAL_NR_GRANT_FRAMES 1U
 #define GNTTAB_MAX_VERSION 1
 
-struct grant_table_arch {
-    gfn_t *shared_gfn;
-    gfn_t *status_gfn;
-};
-
 static inline void gnttab_clear_flags(struct domain *d,
                                       unsigned int mask, uint16_t *addr)
 {
@@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
 #define gnttab_dom0_frames()                                             \
     min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext))
 
-#define gnttab_init_arch(gt)                                             \
-({                                                                       \
-    unsigned int ngf_ = (gt)->max_grant_frames;                          \
-    unsigned int nsf_ = grant_to_status_frames(ngf_);                    \
-                                                                         \
-    (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_);                  \
-    (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_);                  \
-    if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn )                \
-    {                                                                    \
-        while ( ngf_-- )                                                 \
-            (gt)->arch.shared_gfn[ngf_] = INVALID_GFN;                   \
-        while ( nsf_-- )                                                 \
-            (gt)->arch.status_gfn[nsf_] = INVALID_GFN;                   \
-    }                                                                    \
-    else                                                                 \
-        gnttab_destroy_arch(gt);                                         \
-    (gt)->arch.shared_gfn ? 0 : -ENOMEM;                                 \
-})
-
-#define gnttab_destroy_arch(gt)                                          \
-    do {                                                                 \
-        XFREE((gt)->arch.shared_gfn);                                    \
-        XFREE((gt)->arch.status_gfn);                                    \
-    } while ( 0 )
-
 #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
     ({                                                                   \
-        int rc_ = 0;                                                     \
         gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx);                  \
-        if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) ||           \
-             (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn,   \
-                                              0)) == 0 )                 \
-            ((st) ? (gt)->arch.status_gfn                                \
-                  : (gt)->arch.shared_gfn)[idx] = (gfn);                 \
-        rc_;                                                             \
+        (!gfn_eq(ogfn, INVALID_GFN) && !gfn_eq(ogfn, gfn))               \
+         ? guest_physmap_remove_page((gt)->domain, ogfn, mfn, 0)         \
+         : 0;                                                            \
     })
 
 #define gnttab_get_frame_gfn(gt, st, idx) ({                             \
@@ -88,11 +54,21 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
         : gnttab_shared_gfn(NULL, gt, idx);                              \
 })
 
-#define gnttab_shared_gfn(d, t, i)                                       \
-    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
+#define gnttab_shared_page(t, i) ({                                      \
+    virt_to_page((t)->shared_raw[i]);                                    \
+})
+
+#define gnttab_status_page(t, i) ({                                      \
+    virt_to_page((t)->status[i]);                                        \
+})
 
-#define gnttab_status_gfn(d, t, i)                                       \
-    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
+#define gnttab_shared_gfn(d, t, i) ({                                    \
+    page_get_xenheap_gfn(gnttab_shared_page(t, i));                      \
+})
+
+#define gnttab_status_gfn(d, t, i) ({                                    \
+    page_get_xenheap_gfn(gnttab_status_page(t, i));                      \
+})
 
 #define gnttab_need_iommu_mapping(d)                    \
     (is_domain_direct_mapped(d) && is_iommu_enabled(d))
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index 7b5e7b7..74b6485 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -98,9 +98,16 @@ struct page_info
 #define PGT_writable_page PG_mask(1, 1)  /* has writable mappings?         */
 #define PGT_type_mask     PG_mask(1, 1)  /* Bits 31 or 63.                 */
 
- /* Count of uses of this frame as its current type. */
-#define PGT_count_width   PG_shift(2)
-#define PGT_count_mask    ((1UL<<PGT_count_width)-1)
+ /* 2-bit count of uses of this frame as its current type. */
+#define PGT_count_mask    PG_mask(3, 3)
+
+/*
+ * Stored in bits [28:0] or [60:0] GFN if page is xenheap page.
+ */
+#define PGT_gfn_width     PG_shift(3)
+#define PGT_gfn_mask      ((1UL<<PGT_gfn_width)-1)
+
+#define PGT_INVALID_XENHEAP_GFN   _gfn(PGT_gfn_mask)
 
  /* Cleared when the owning guest 'frees' this page. */
 #define _PGC_allocated    PG_shift(1)
@@ -166,6 +173,32 @@ extern unsigned long xenheap_base_pdx;
 
 #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
 
+static inline gfn_t page_get_xenheap_gfn(struct page_info *p)
+{
+    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
+
+    ASSERT(is_xen_heap_page(p));
+
+    return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_;
+}
+
+static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn)
+{
+    gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn;
+
+    ASSERT(is_xen_heap_page(p));
+
+    p->u.inuse.type_info &= ~PGT_gfn_mask;
+    p->u.inuse.type_info |= gfn_x(gfn_);
+}
+
+/*
+ * As the struct page_info representing the xenheap page on Arm can contain
+ * the valid GFN we need to clear it beforehand.
+ */
+#define arch_alloc_xenheap_page(p)   page_set_xenheap_gfn(p, INVALID_GFN)
+#define arch_free_xenheap_page(p)    do {} while ( 0 )
+
 #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)
 /* PDX of the first page in the frame table. */
 extern unsigned long frametable_base_pdx;
diff --git a/xen/include/asm-x86/grant_table.h b/xen/include/asm-x86/grant_table.h
index a8a2143..5c23cec 100644
--- a/xen/include/asm-x86/grant_table.h
+++ b/xen/include/asm-x86/grant_table.h
@@ -14,9 +14,6 @@
 
 #define INITIAL_NR_GRANT_FRAMES 1U
 
-struct grant_table_arch {
-};
-
 static inline int create_grant_host_mapping(uint64_t addr, mfn_t frame,
                                             unsigned int flags,
                                             unsigned int cache_flags)
@@ -35,8 +32,6 @@ static inline int replace_grant_host_mapping(uint64_t addr, mfn_t frame,
     return replace_grant_pv_mapping(addr, frame, new_addr, flags);
 }
 
-#define gnttab_init_arch(gt) 0
-#define gnttab_destroy_arch(gt) do {} while ( 0 )
 #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
     (gfn_eq(gfn, INVALID_GFN)                                            \
      ? guest_physmap_remove_page((gt)->domain,                           \
diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
index cb90527..3c153c6 100644
--- a/xen/include/asm-x86/mm.h
+++ b/xen/include/asm-x86/mm.h
@@ -327,6 +327,10 @@ struct page_info
 
 #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
 
+/* No arch-specific actions are needed for the xenheap page */
+#define arch_alloc_xenheap_page(p)   do {} while ( 0 )
+#define arch_free_xenheap_page(p)    do {} while ( 0 )
+
 #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)
 extern unsigned long max_page;
 extern unsigned long total_pages;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Dec 03 21:05:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 21:05:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237967.412668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtFjO-00057q-B2; Fri, 03 Dec 2021 21:04:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237967.412668; Fri, 03 Dec 2021 21:04:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtFjO-00057j-7f; Fri, 03 Dec 2021 21:04:34 +0000
Received: by outflank-mailman (input) for mailman id 237967;
 Fri, 03 Dec 2021 21:04:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DjoY=QU=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1mtFjM-00057d-Ik
 for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 21:04:32 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9a60869b-547c-11ec-a5e1-b9374ead2679;
 Fri, 03 Dec 2021 22:04:30 +0100 (CET)
Received: from pps.filterd (m0246617.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B3JjNpj014831; 
 Fri, 3 Dec 2021 21:04:23 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cqkx5jydh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 03 Dec 2021 21:04:23 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B3Kfnkh196003;
 Fri, 3 Dec 2021 21:04:22 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2170.outbound.protection.outlook.com [104.47.57.170])
 by aserp3030.oracle.com with ESMTP id 3ckaqmtrjy-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 03 Dec 2021 21:04:21 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4192.namprd10.prod.outlook.com (2603:10b6:208:1d9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Fri, 3 Dec
 2021 21:04:19 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4755.015; Fri, 3 Dec 2021
 21:04:18 +0000
Received: from [10.74.107.202] (138.3.200.10) by
 SA9PR13CA0086.namprd13.prod.outlook.com (2603:10b6:806:23::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 3 Dec 2021 21:04:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a60869b-547c-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=szOXj5f+2qZZfgQ73vq4k3ILmT/WdvXYPwEh83QnMX4=;
 b=JMwdHivr5FWAi7Uu9E6o9YNuwBpMRm2UvudrV+uUe3XKJR6Z3/xsuE/grlkNFEwvsr+i
 8ms12eRjl8jhu3PJckncLW0WeRxdt7RuhO1r2IF6AJy5gzlgif7+EoUtywF88GRTYwUF
 kly65p4XNZHBWE3elbCeHXuaeWtLAuft+wTcN/JEVnxCAan83kIOZwMSx1XtYaxRYUtw
 D+pNkgqRfvAHMNnXYGcxKpi9tqszxGj7gODxbUqagmHmvapcpGEzFdi8QZXTiY12Vwwo
 yq0CmDfmUjADYxtEhDiUX726/r0V3Caczic72YvXzn7bVBXmZbpcb7ETp6lOg8dNGn7Q Gw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FN1RXX94Y1twwFEPXgO7MFBiVpOpY8nSPPS+XvbSmXrSitLiJfxd9Bz6YlJLPdQ4EPeOAscccIM5Er+LJ8kVcMB6k6/tYBpPBYgLzMWcylxQVwwzvKm0P3KgW9eHTO+xnili/eP0ansq03UPJ0Ldm582Ngyr3a02trfIvEjfg0RA/Q64zQDANeCijRxwGdGIk5SLDMhPD4+oiNHlSEZy3DfR4I0DhORXwaccNBbzFoG7OaFzMJ6ao+/Wt9M8HRI5A7Zqr3ulxhzzyq9Q9h3DmtNbSHR7fiLRZ0am5Jh7n5DlZQ2rD/xMcR01uN91RAsYWk5XKW0BIY/CeS9fJGrm2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=szOXj5f+2qZZfgQ73vq4k3ILmT/WdvXYPwEh83QnMX4=;
 b=QMc0tkb48IP5cQL7CwAVYv0QSpfwxuXR1z3gBazjABo4wKvmyXaKDOV9/vHfX+u1iB9lNt5VlaSA+uMIbZ50zr3JhNYNzAzGq1LWT3yYvvjg/lLLRrUHobAHJ8ac7v6Of+HvK3SVlqcZKhO1gW2kN2EpgdfsXTcuxdwU7XRBrJQiZiaSz3Di0WKRr54t/30w9cUuOfU+SOPOMWg6350Vrrax42asF6RBQrjWnoUrSeiOJ/xtYuzKoW8leeAqs0Xb42S3siP4/PCu92CK8O/39FS1YWIt+psAe/1w7vFeDLlh4IvuNs+EdqtUs8Xl/QjAqhI44bS+cU8L7T3m7yK4Zw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=szOXj5f+2qZZfgQ73vq4k3ILmT/WdvXYPwEh83QnMX4=;
 b=t7EiTie8iKJ7hsLMSoo9B1QM1SN+HDxJqBfmvCPAsnXkMZx/VHxYLsRcXgaSFSTeddszgEnBfq554OAwyfnrHm0kcB8KTR/jGwmxVCC8TBqzDg1A4+ByfaAxDFIosJ5oGNQXQGY8W//ektNfmdz9PQVVW4s0Oi7kWunV6nxKnvE=
Message-ID: <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
Date: Fri, 3 Dec 2021 16:04:11 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Joe Perches <joe@perches.com>, Juergen Gross <jgross@suse.com>,
        sstabellini@kernel.org, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
 <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SA9PR13CA0086.namprd13.prod.outlook.com
 (2603:10b6:806:23::31) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2ea824a3-aec1-47d1-7fdd-08d9b6a078c1
X-MS-TrafficTypeDiagnostic: MN2PR10MB4192:
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4192EF91F93A39FF9F2FA4648A6A9@MN2PR10MB4192.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	y2q2/OxiAY+BiE5VhtOTWyR5uk+ZDPIgNcN1hyaen02kq+SOUdITYYl6uOWar4OsULYDdcqx29S3G1Odni39prgCO2gsiKnkau7g7b0SZsRuyjVyyyVE6WfVmcleL0kNlD9zJfW1eKlskAglenPFNTw7iWPdvmWDZrNqCtB0g0WxMSm9ecBtINmO/T2lu/62Tvp6yOA5WqgZHkJyX9cpYeS4kyOaVvtfN0UsKXRSxGqPvMInlM0ku1+ONLYXIt/0HVO7fFy8PR9N7U47h5MIz3FlH/jAaAgKi+H0USPlm3n83TVg7tMbBgNjowkiG1GvW7FBCFhcVrETVghnYvdCoShp1OifqdRZ4g4H+jK6LVErrHoK2tkOv15Xf9HjfYLO2HR+flbEYPvil4tJWbbgi68hamau+y1eI5m8FMHHRFmlYtungeBY4lVBSxDF6aO1xATkkFo95bgSteu6W6wP2WqyUXLrZhq3gxI7Gsr+O1PcVrSRw1ucgYsTBCVMBrc/2IcpBP24LjB/HClGYIEQgw/bcsxNjE6k0oYyvEUF+A1cu4+CicUExe9KsCuvzeor6AILdT8XKCu6UpsZqcYZWL+y9EMa9w0IoNpYtYHLhr3z/ddOgh6rBAhbVoVxr7MoVJENYg3zauFeJk4l8HCjKeI7bgvguqIJtJtYep8IEDchlZI5Mm1SaRK5eZYa5X3SgWo0c2/lW4kBHn/OKp1tQ2N5B/mhbi5KPew1fXbsBetdWX36EHqkUFq91Od0Z4XZ
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66574015)(4326008)(26005)(316002)(8936002)(86362001)(44832011)(2906002)(16576012)(508600001)(8676002)(7416002)(36756003)(110136005)(38100700002)(6666004)(66476007)(66946007)(31686004)(2616005)(956004)(66556008)(31696002)(5660300002)(186003)(83380400001)(6486002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?c3VySmtaRHpGQ0d3a3h5U0Nqck4rVzJ4TGJCUzg4STAzeGwreFdGOGV6QzA1?=
 =?utf-8?B?bUhMMUhBUlg5OXFaRU91cDJxb2xZR0RxT3NubTVVM1VDNkJaVzlGaXFXanlU?=
 =?utf-8?B?c2NtZlNIejQwY2dQNy9reStmUFBvQ0l5MmpRNFFCN0JmK0MzQlAzK3NRcDBK?=
 =?utf-8?B?WENKY0ZDVjRheWl6dklOdmhjaHltTDhzN2Nqa0pCeFRqUVZraDRyUDNOS0Rw?=
 =?utf-8?B?NEN4dll1NXoycWFxRFd1emR3S2RVNjRGZDhEdWVrRG4xYXNscFozd2ZJTDJv?=
 =?utf-8?B?SVM3d0tnRTJ4RkUvTVBWY1BCaHNNS1NUeWpZS2xYOTlodVBETythYzlCdEp0?=
 =?utf-8?B?SDFTMDQvekpkWWI3UGp2RDlSTDhmL2xQK1FYZG1GVmJENFMzN2oydmdiT053?=
 =?utf-8?B?b3FJUlBMdkM0djJ3dkdFTEVZekhMNG9tTFVJaGZzQWhweXRnRStLbGhLS0lT?=
 =?utf-8?B?SFdJSXZXMFpIQkp5NldCZUo0Zjk4eTlVUDBHL3BacUpBY2x4blNsclV3Qy8x?=
 =?utf-8?B?djlQTDNtb2dBWDVWRG9FY2dta1ZMK0NsQkdXS05saFlSY0lYV2JJdzgwclhD?=
 =?utf-8?B?cS9yeFBqc0wvNDZKRUFKSGVEN3FBeEhXNWZ6Ukg4MkZNYTRTeEErckhYT0k2?=
 =?utf-8?B?YWgwRm15U3FlV0FnT1dPRmNFZUN4clVrMURDNUIydEovaGxoVGJZVzZ4SjU3?=
 =?utf-8?B?TXYyMDRKeEtqUmFxR0tlRkJYNjAzR0xQZFUzWStoaFROb2FUeHFtU2VoeHRw?=
 =?utf-8?B?a1M1c1FQb2hJb2c1aTdpTUg3TlVJSmRnZ09tREF4TklhZUVBc1F1MWF6Z3Jn?=
 =?utf-8?B?NUQvQ1ozeThVQUcwVEQxc3dNZEppVEJOWXVyU1RrRDRYNjVSUWNvSmJ5eEJ1?=
 =?utf-8?B?R0d0VFVVVDd5YlErMll3TmYwbUtheC9Ka2NqRVFjaEM2bDk0TWdXc2xMNTE3?=
 =?utf-8?B?VGJ3ZEhVWkhYM1E1SXhHTjIxOXA3a2dWQlRJZjQ0Qytuc0htUkxkU1VSZVBX?=
 =?utf-8?B?Z3ZFMThlUFVvZmlKbVA2a0locU4ydlBiUWtSVFJoNmZLUWpBcTRTMkVaMnV5?=
 =?utf-8?B?cUJqeFNtMmdOSWMvQ3QrdzFkZnFRWXY1UWxmYlJXemY0cDQ0eGd5b2ZnclJs?=
 =?utf-8?B?RjBjcDNFWWdnNXhUL2U2VGJOQXdIR2FENVBHY0RGbGhDbW1FV0MrZDRSYUpC?=
 =?utf-8?B?Z04wMllyQUV0c1h2Mjl6dXlYN1RJUnpCTFZHdlc2WGQ0cWtUeDVJam5OV3Zy?=
 =?utf-8?B?cllVREZxc0U0clJOaDJMNzlsdEhlOEEzQXA1c3JwUUM3elluSnBFNFJJK21H?=
 =?utf-8?B?cnRNbjBVUXRXWm9nUFpaRG5JTGFwUFIyK0dWRTI4VUVUdnhObWVHalJNbjlr?=
 =?utf-8?B?bHV3Y1UrMWZUK0xudHF3c2ljWGNIWDBJWCtneHpkZVRabWl6SHlIV1J0dFNC?=
 =?utf-8?B?QnliMGNiZzFYTVF3NSswT1ltUHJSQkJNT1BCbDk0VitUazZLQWpoNUh0djRK?=
 =?utf-8?B?VVJzZzlCRjlzeEJkR2crbitDUDIyd1oybnBiOURoc09SSkk1eVVxWWhOMWVr?=
 =?utf-8?B?RXVjbHRYZDBSN0pobnkxM3h1bW1od0UzellST2ZqbVYrVEhkd2xuVWVYQ1N4?=
 =?utf-8?B?WXpnOHh4MDNzSmhkNDhacDFkTnNsWVY1ZDN0eExPbFZ5cDJzWUVrVXI0THI1?=
 =?utf-8?B?b2V2RVdudjdxWXhZQXRqL1YweVo0YkRnejN0TE80b0xVSGVMdHIxakFCVURr?=
 =?utf-8?B?WXNBdjRZSGhVRE05KzgrNzR0NDhKVW9icUpjWlB4MFd1OStXRzlac2hWM3FT?=
 =?utf-8?B?SytaTnJFSmpTektYRlVNcmtJRW1ReDBhazFlR3pzNDJ0ZW5xWXNaNVBwYjNM?=
 =?utf-8?B?MTJvYmg1UlpIb2I3NEc3Uk9oVHVYWFFJZjlIaHJkSnBKVGtpaFZWWnVYUDht?=
 =?utf-8?B?WEhUMGY5WGNOQjhsaVQzT0YyZmV4eXRId3FCV1FvcVJ6MzRYc09Sb3FIRUp3?=
 =?utf-8?B?cWhQNWhWSDRUTndvOGNWUUFkaDVTMzFBTmF2YzJUVkltaHl6QWRPbkhGRkFL?=
 =?utf-8?B?L1pCaGFhYnVEWGZkZGRtRGhKYUZ4SkdjZ2JVd0NoazFORS9TU3NjUzUzL3Rn?=
 =?utf-8?B?bDNNL2RSa2pSUkpQV1Vac2x3Wm9kNVhlTTExbUZ2dVVoMlBmdVFwSHhxVGdB?=
 =?utf-8?B?N3hjVVNsUTg4RjY4c2kyaUN0K09wM2RENHdjWStVY05jeUVFVVA0c0IwZWRx?=
 =?utf-8?Q?MlODytgP7Ek76mPPH0cvDlypGQhrqVRRxlEP1jzUiI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ea824a3-aec1-47d1-7fdd-08d9b6a078c1
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 21:04:18.7919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EjCh/p+jwiH28u3dulEacD0hwO1CubbnGss8XBo/JG9q5eZHT3GTwLhc7pay1MBABOc3puHV3zee4R2StHsdoZuX+PAqN9OO69Cmo6JQ+80=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4192
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10187 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112030133
X-Proofpoint-GUID: K1yRVTY7jyhcxZSyIV47rN2jvdC2qh4u
X-Proofpoint-ORIG-GUID: K1yRVTY7jyhcxZSyIV47rN2jvdC2qh4u


On 12/3/21 10:54 AM, Christophe JAILLET wrote:
> Le 03/12/2021 à 04:03, Joe Perches a écrit :
>> On Thu, 2021-12-02 at 20:07 +0100, Christophe JAILLET wrote:
>>> Le 02/12/2021 à 19:16, Joe Perches a écrit :
>>>> On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote:
>>>>> Le 02/12/2021 à 07:12, Juergen Gross a écrit :
>>>>>> On 01.12.21 22:10, Christophe JAILLET wrote:
>>>>>>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid
>>>>>>> some open-coded arithmetic in allocator arguments.
>>>>>>>
>>>>>>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>>>>>>> consistency.
>>>>>>>
>>>>>>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
>>>> []
>>>>>>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>>>> []
>>>>>>> @@ -442,16 +442,14 @@ static int xlbd_reserve_minors(unsigned int
>>>>>>> minor, unsigned int nr)
>>>>>>>         if (end > nr_minors) {
>>>>>>>             unsigned long *bitmap, *old;
>>>>>>> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
>>>>>>> -                 GFP_KERNEL);
>>>>>>> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>>>>>>>             if (bitmap == NULL)
>>>>>>>                 return -ENOMEM;
>>>>>>>             spin_lock(&minor_lock);
>>>>>>>             if (end > nr_minors) {
>>>>>>>                 old = minors;
>>>>>>> -            memcpy(bitmap, minors,
>>>>>>> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
>>>>>>> +            bitmap_copy(bitmap, minors, nr_minors);
>>>>>>>                 minors = bitmap;
>>>>>>>                 nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
>>>>
>>>>         nr_minors = end;
>>>> ?
>>>>
>>>
>>> No,
>>> My understanding of the code is that if we lack space (end > nr_minors),
>>> we need to allocate more. In such a case, we want to keep track of what
>>> we have allocated, not what we needed.
>>> The "padding" bits in the "long align" allocation, can be used later.
>>
>>>
>>> first call
>>> ----------
>>> end = 65
>>> nr_minors = 63
>>>
>>> --> we need some space
>>> --> we allocate 2 longs = 128 bits
>>> --> we now use 65 bits of these 128 bits
>>
>> or 96, 32 or 64 bit longs remember.
>
> 32 and 64 for sure, but I was not aware of 96. On which arch?
>
>>
>>>
>>> new call
>>> --------
>>> end = 68
>>> nr_minors = 128 (from previous call)
>>
>> The initial allocation is now bitmap_zalloc which
>> specifies only bits and the nr_minors is then in
>> BITS_TO_LONGS(bits) * BITS_PER_LONG
>>
>> Perhaps that assumes too much about the internal
>> implementation of bitmap_alloc
>>
>>
>
> I get your point now, and I agree with you.
>
> Maybe something as what is done in mc-entity.c?
> Explicitly require more bits (which will be allocated anyway), instead of taking advantage (read "hoping") that it will be done.
>
> Could be:
>
> @@ -440,26 +440,25 @@ static int xlbd_reserve_minors(unsigned int minor, unsigned int nr)
>      int rc;
>
>      if (end > nr_minors) {
>          unsigned long *bitmap, *old;
>
> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
> -                 GFP_KERNEL);
> +        end = ALIGN(end, BITS_PER_LONG);
> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>          if (bitmap == NULL)
>              return -ENOMEM;
>
>          spin_lock(&minor_lock);
>          if (end > nr_minors) {
>              old = minors;
> -            memcpy(bitmap, minors,
> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
> +            bitmap_copy(bitmap, minors, nr_minors);
>              minors = bitmap;
> -            nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
> +            nr_minors = end;
>          } else
>              old = bitmap;
>          spin_unlock(&minor_lock);
> -        kfree(old);
> +        bitmap_free(old);
>      }
>
>      spin_lock(&minor_lock);
>      if (find_next_bit(minors, end, minor) >= end) {


I don't think this will work anymore, we may now fail if another thread gets a minor above the original (i.e. no aligned) @end.


-boris


> bitmap_set(minors, minor, nr);
> @@ -2608,11 +2607,11 @@ static void __exit xlblk_exit(void)
>  {
>      cancel_delayed_work_sync(&blkfront_work);
>
>      xenbus_unregister_driver(&blkfront_driver);
>      unregister_blkdev(XENVBD_MAJOR, DEV_NAME);
> -    kfree(minors);
> +    bitmap_free(minors);
>  }
>  module_exit(xlblk_exit);
>
>  MODULE_DESCRIPTION("Xen virtual block device frontend");
>  MODULE_LICENSE("GPL");
>
>


From xen-devel-bounces@lists.xenproject.org Fri Dec 03 21:30:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 03 Dec 2021 21:30:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.237975.412678 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtG8c-0000XW-Gy; Fri, 03 Dec 2021 21:30:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 237975.412678; Fri, 03 Dec 2021 21:30:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtG8c-0000XP-E0; Fri, 03 Dec 2021 21:30:38 +0000
Received: by outflank-mailman (input) for mailman id 237975;
 Fri, 03 Dec 2021 21:30:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtG8a-0000XF-VJ; Fri, 03 Dec 2021 21:30:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtG8a-0005bn-Ot; Fri, 03 Dec 2021 21:30:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtG8a-0000QV-E8; Fri, 03 Dec 2021 21:30:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtG8a-000750-Dd; Fri, 03 Dec 2021 21:30:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zy9Y4DjlRaNEQkkVmAxWAcpr9s2YqTn+K9FmYZd8mLc=; b=tQIVSnf2INP5OXdmn3Or6JffXz
	6/y+xiUpp2flAPFcBONXPDqUUNanPe4HKIkfAQYLQXqmJ980imNX949czwsmDjnnKkF9qgaM73zcI
	iX4Zxkyf6u0hyjpKMl2atRGqVR9jcDkSu127Qx7XOzVsOmeGxr92o37H4pTLRZw7FiFU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167071-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167071: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-shadow:guest-start.2:fail:regression
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:regression
    linux-5.4:test-amd64-amd64-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start.2:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-destroy:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start.2:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-destroy:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    linux-5.4:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
X-Osstest-Versions-That:
    linux=9334f48f567334f54101223012ec9d3b4628bed8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 03 Dec 2021 21:30:36 +0000

flight 167071 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167071/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl         18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-shadow    23 guest-start.2            fail REGR. vs. 166839
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166839
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166839
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166839
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup fail in 167023 REGR. vs. 166839
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 167023 REGR. vs. 166839

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt     14 guest-start      fail in 166970 pass in 167071
 test-arm64-arm64-xl-credit1  14 guest-start      fail in 166970 pass in 167071
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 166970 pass in 167071
 test-amd64-amd64-dom0pvh-xl-amd 23 guest-start.2 fail in 166990 pass in 167023
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 20 guest-destroy fail in 166990 pass in 167023
 test-amd64-i386-xl           14 guest-start      fail in 166990 pass in 167071
 test-arm64-arm64-xl-seattle  14 guest-start      fail in 166990 pass in 167071
 test-armhf-armhf-libvirt     14 guest-start      fail in 166990 pass in 167071
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail in 166990 pass in 167071
 test-arm64-arm64-xl-credit2  19 guest-start.2    fail in 167023 pass in 166970
 test-armhf-armhf-libvirt     20 guest-destroy    fail in 167023 pass in 166970
 test-amd64-amd64-xl-pvshim   14 guest-start      fail in 167023 pass in 167071
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 167023 pass in 167071
 test-arm64-arm64-xl-xsm      14 guest-start      fail in 167023 pass in 167071
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-i386-xl-shadow 22 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl 22 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 167023 pass in 167071
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167023 pass in 167071
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 167023 pass in 167071
 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167023 pass in 167071
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 167023 pass in 167071
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail pass in 166970
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat  fail pass in 166970
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166970
 test-amd64-amd64-xl-pvshim   22 guest-start/debian.repeat  fail pass in 166990
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 166990
 test-amd64-amd64-xl-rtds     22 guest-start/debian.repeat  fail pass in 166990
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 166990
 test-amd64-i386-xl-xsm       22 guest-start/debian.repeat  fail pass in 166990
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166990
 test-amd64-amd64-xl-pvhv2-intel 14 guest-start             fail pass in 167023
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install    fail pass in 167023
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 167023
 test-amd64-i386-libvirt      20 guest-start/debian.repeat  fail pass in 167023
 test-amd64-i386-xl           22 guest-start/debian.repeat  fail pass in 167023
 test-amd64-amd64-xl-shadow   22 guest-start/debian.repeat  fail pass in 167023
 test-arm64-arm64-xl-credit2  18 guest-start/debian.repeat  fail pass in 167023
 test-amd64-amd64-examine      4 memdisk-try-append         fail pass in 167023
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 167023
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 167023
 test-armhf-armhf-xl-credit2  18 guest-start/debian.repeat  fail pass in 167023
 test-amd64-i386-libvirt-raw  19 guest-start/debian.repeat  fail pass in 167023
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 167023
 test-armhf-armhf-libvirt     18 guest-start/debian.repeat  fail pass in 167023

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166839
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166839
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166839
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166839
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5
baseline version:
 linux                9334f48f567334f54101223012ec9d3b4628bed8

Last test of basis   166839  2021-11-26 10:11:13 Z    7 days
Testing same since   166970  2021-12-01 08:40:40 Z    2 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Chuanqi Liu <legend050709@qq.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  Diana Wang <na.wang@corigine.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Grzegorz Jaszczyk <jaz@semihalf.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Huang Pei <huangpei@loongson.cn>
  Hulk Robot <hulkrobot@huawei.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gerecke <jason.gerecke@wacom.com>
  Jason Gerecke <killertofu@gmail.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol@gmail.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kumar Thangavel <kumarthangavel.hcl@gmail.com>
  Kumar Thangavel <thangavel.k@hcl.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Manfred Spraul <manfred@colorfullife.com>
  Marek Behún <kabel@kernel.org>
  Marek Behún <marek.behun@nic.cz>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Mingjie Zhang <superzmj@fibocom.com>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nitesh B Venkatesh <nitesh.b.venkatesh@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Ondrej Jirman <megous@megous.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Peng Fan <peng.fan@nxp.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Remi Pommarel <repk@triplefau.lt>
  Richard Cochran <richardcochran@gmail.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Mendoza-Jonas <sam@mendozajonas.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <horms@verge.net.au>
  Simon Horman <simon.horman@corigine.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
  Tobias Brunner <tobias@strongswan.org>
  Todd Kjos <tkjos@google.com>
  Tomasz Maciej Nowak <tmn505@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Weichao Guo <guoweichao@oppo.com>
  yangxingwu <xingwu.yang@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           fail    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 3389 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 01:16:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 01:16:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238006.412711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtJeo-0003aA-9d; Sat, 04 Dec 2021 01:16:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238006.412711; Sat, 04 Dec 2021 01:16:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtJeo-0003a3-6X; Sat, 04 Dec 2021 01:16:06 +0000
Received: by outflank-mailman (input) for mailman id 238006;
 Sat, 04 Dec 2021 01:16:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtJen-0003Zt-Fk; Sat, 04 Dec 2021 01:16:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtJen-0002zY-7u; Sat, 04 Dec 2021 01:16:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtJem-0001Da-V7; Sat, 04 Dec 2021 01:16:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtJem-0002gf-UZ; Sat, 04 Dec 2021 01:16:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eUJAEorrtRZ2bn2GgoEc6ce6xSZ87mEfHEQJc/l3kO0=; b=ltVajvKb2cQ1+jtOD1u0hrBVuT
	7DNRQ26IfPmgFN6Sjboc8nNtibZ2S9VvW8Vjg66cgGx7zk+7ryCL1skVlD7J3ylLx46T1aIEfH3mF
	Ljwvmfwo2+Py1DeMFdcRYTIn0PYmqRY6KuIoGQ4bq1XV/fu+nNVqnhNZtjq+ohoGeKhQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167083-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167083: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    xen-unstable:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit2:guest-destroy:fail:regression
    xen-unstable:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-stop.audited:fail:regression
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-destroy:fail:regression
    xen-unstable:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    xen-unstable:test-amd64-i386-xl:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start.2:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-destroy:fail:heisenbug
    xen-unstable:test-amd64-amd64-pygrub:guest-start.2:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-cubietruck:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-pair:guest-start/debian:fail:heisenbug
    xen-unstable:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl:guest-start:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl:guest-start:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-vhd:guest-start.2:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 04 Dec 2021 01:16:04 +0000

flight 167083 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167083/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166912
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166941
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-armhf-armhf-xl-credit2  20 guest-destroy            fail REGR. vs. 166941
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166941
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 23 guest-stop.audited fail in 166966 REGR. vs. 166941
 test-amd64-i386-libvirt-xsm  22 guest-destroy  fail in 166975 REGR. vs. 166912
 test-amd64-amd64-xl 22 guest-start/debian.repeat fail in 167042 REGR. vs. 166941

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl           14 guest-start      fail in 166966 pass in 167083
 test-amd64-i386-pair       25 guest-start/debian fail in 166966 pass in 167083
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail in 166966 pass in 167083
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 166966 pass in 167083
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 167083
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 21 guest-start.2 fail in 166966 pass in 167083
 test-arm64-arm64-libvirt-raw 12 debian-di-install fail in 166966 pass in 167083
 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 166966 pass in 167083
 test-arm64-arm64-libvirt-xsm 14 guest-start      fail in 166975 pass in 167083
 test-amd64-i386-xl           24 guest-destroy    fail in 166975 pass in 167083
 test-amd64-amd64-pygrub      22 guest-start.2    fail in 166975 pass in 167083
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 166999 pass in 167042
 test-amd64-amd64-dom0pvh-xl-intel 14 guest-start fail in 166999 pass in 167083
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 166999 pass in 167083
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 166999 pass in 167083
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 166999 pass in 167083
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 166999 pass in 167083
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 166999 pass in 167083
 test-armhf-armhf-xl-cubietruck 18 guest-start/debian.repeat fail in 166999 pass in 167083
 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 167042 pass in 166966
 test-amd64-i386-libvirt-xsm  14 guest-start      fail in 167042 pass in 167083
 test-amd64-amd64-libvirt-xsm 14 guest-start      fail in 167042 pass in 167083
 test-amd64-amd64-pair      25 guest-start/debian fail in 167042 pass in 167083
 test-amd64-i386-libvirt-pair 25 guest-start/debian fail in 167042 pass in 167083
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-i386-xl-xsm 22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-i386-xl  22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 167042 pass in 167083
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail in 167042 pass in 167083
 test-armhf-armhf-xl-credit2  14 guest-start      fail in 167042 pass in 167083
 test-armhf-armhf-xl-multivcpu 14 guest-start     fail in 167042 pass in 167083
 test-armhf-armhf-libvirt     14 guest-start      fail in 167042 pass in 167083
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167042 pass in 167083
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167042 pass in 167083
 test-amd64-amd64-xl-credit2  22 guest-start/debian.repeat  fail pass in 166966
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat  fail pass in 166966
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail pass in 166966
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail pass in 166975
 test-amd64-i386-libvirt      20 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 166975
 test-armhf-armhf-xl-arndale  18 guest-start/debian.repeat  fail pass in 166975
 test-amd64-amd64-xl-pvshim   22 guest-start/debian.repeat  fail pass in 166999
 test-amd64-amd64-xl-credit1  22 guest-start/debian.repeat  fail pass in 166999
 test-arm64-arm64-xl          18 guest-start/debian.repeat  fail pass in 166999
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 166999
 test-armhf-armhf-libvirt     18 guest-start/debian.repeat  fail pass in 166999
 test-amd64-amd64-xl          14 guest-start                fail pass in 167042
 test-arm64-arm64-xl-seattle  18 guest-start/debian.repeat  fail pass in 167042
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail pass in 167042
 test-arm64-arm64-xl-xsm      14 guest-start                fail pass in 167042
 test-amd64-amd64-xl-shadow   22 guest-start/debian.repeat  fail pass in 167042
 test-amd64-i386-xl-shadow    22 guest-start/debian.repeat  fail pass in 167042
 test-armhf-armhf-xl          14 guest-start                fail pass in 167042
 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 167042
 test-armhf-armhf-xl-vhd      18 guest-start.2              fail pass in 167042

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds   22 guest-start/debian.repeat fail blocked in 166941
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 167042 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 167042 never pass
 test-armhf-armhf-xl         15 migrate-support-check fail in 167042 never pass
 test-armhf-armhf-xl     16 saverestore-support-check fail in 167042 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    6 days
Failing since        166960  2021-11-30 12:35:41 Z    3 days    6 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    2 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                fail    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              fail    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  fail    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              fail    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-i386-libvirt                                      fail    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    fail    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 396 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 02:41:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 02:41:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238015.412728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtKz4-0005wl-OU; Sat, 04 Dec 2021 02:41:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238015.412728; Sat, 04 Dec 2021 02:41:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtKz4-0005wd-Jq; Sat, 04 Dec 2021 02:41:06 +0000
Received: by outflank-mailman (input) for mailman id 238015;
 Sat, 04 Dec 2021 02:41:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtKz3-0005wT-8M; Sat, 04 Dec 2021 02:41:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtKz2-0004lw-V0; Sat, 04 Dec 2021 02:41:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtKz2-0003iy-Na; Sat, 04 Dec 2021 02:41:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtKz2-0001Sr-N6; Sat, 04 Dec 2021 02:41:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/kOUdWNT//W6BmewwUXDaUM+rRH/u/Y/H36r3SNMvPc=; b=169uf3SR5hS1AVowgh7mqqcf84
	iifpfqTPI7Bz1KjQgM9GNAV++pr2qveHUDNmOzKoY3meXohtkwLs2qNrVHvVLudbYhexffv768r/R
	k6CyXELDqHDfNXQe1HOVi6DZ4CIU4AcwcL9oIRJm6lb1dGdwXk9dMrnWVq6HDO+Sk01g=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167089-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167089: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    linux-linus:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-xl-credit2:guest-start.2:fail:regression
    linux-linus:test-armhf-armhf-xl:guest-start/debian.repeat:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    linux-linus:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:regression
    linux-linus:test-arm64-arm64-libvirt-xsm:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit1:debian-install:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-cubietruck:guest-start.2:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:guest-destroy:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5f58da2befa58edf3a70b91ed87ed9bf77f1e70e
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 04 Dec 2021 02:41:04 +0000

flight 167089 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167089/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 166942
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-xsm     22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-pvshim  22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl         22 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-xl-credit2  19 guest-start.2            fail REGR. vs. 166942
 test-armhf-armhf-xl         18 guest-start/debian.repeat fail REGR. vs. 166942
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail REGR. vs. 166942
 test-armhf-armhf-libvirt    18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-xsm     18 guest-start/debian.repeat fail REGR. vs. 166942
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 166942

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-xsm  8 xen-boot         fail in 167055 pass in 167089
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 167055 pass in 167089
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 167055 pass in 167089
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 167055 pass in 167089
 test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail in 167055 pass in 167089
 test-armhf-armhf-xl-credit1  12 debian-install   fail in 167055 pass in 167089
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 167055 pass in 167089
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167055 pass in 167089
 test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail in 167055 pass in 167089
 test-amd64-amd64-libvirt     20 guest-start/debian.repeat  fail pass in 167055
 test-arm64-arm64-xl          18 guest-start/debian.repeat  fail pass in 167055
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 167055
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 167055
 test-armhf-armhf-xl-cubietruck 19 guest-start.2            fail pass in 167055

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166942

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd    17 guest-start/debian.repeat fail blocked in 166942
 test-armhf-armhf-xl-vhd      19 guest-destroy fail in 167055 blocked in 166942
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                5f58da2befa58edf3a70b91ed87ed9bf77f1e70e
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    6 days
Failing since        166963  2021-11-30 20:54:02 Z    3 days    6 attempts
Testing same since   167055  2021-12-03 01:12:38 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akhil P Oommen <akhilpo@codeaurora.org>
  Alex Bee <knaerzche@gmail.com>
  Alex Deucher <aleander.deucher@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Williamson <alex.williamson@redhat.com>
  Alexandra Winter <wintera@linux.ibm.com>
  Amir Tzin <amirtz@nvidia.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Bean Huo <beanhuo@micron.com>
  Ben Ben-Ishay <benishay@nvidia.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Benjamin Poirier <bpoirier@nvidia.com>
  Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Chen Jun <chenjun102@huawei.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Corey Minyard <cminyard@mvista.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Airlie <airlied@redhat.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Woodhouse <dwmw@amazon.co.uk>
  Deren Wu <deren.wu@mediatek.com>
  Dmitry Bogdanov <dbezrukov@marvell.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Douglas Gilbert <dgilbert@interlog.com>
  Dust Li <dust.li@linux.alibaba.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Dumazet <edumazet@google.com>
  Erik Ekman <erik@kryo.se>
  Felix Fietkau <nbd@nbd.name>
  Flora Cui <flora.cui@amd.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Fuad Tabba <tabba@google.com>
  Gal Pressman <gal@nvidia.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  George Shen <George.Shen@amd.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guangming <Guangming.Cao@mediatek.com>
  Guchun Chen <guchun.chen@amd.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurchetan Singh <gurchetansingh@chromium.org>
  Gustavo A. R. Silva <gustavoars@kernel.org>
  Hangbin Liu <liuhangbin@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Igor Russkikh <irusskikh@marvell.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakub Kicinski <kuba@kernel.org>
  Jane Jian <Jane.Jian@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jian-Hong Pan <jhp@endlessos.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jimmy Kizito <Jimmy.Kizito@amd.com>
  Joerg Roedel <jroedel@suse.de>
  José Roberto de Souza <jose.souza@intel.com>
  Juergen Gross <jgross@suse.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kalle Valo <kvalo@codeaurora.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Larry Finger <Larry.Finger@lwfinger.net>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Lijo Lazar <lijo.lazar@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Lu Baolu <baolu.lu@linux.intel.com>
  Luca Coelho <luciano.coelho@intel.com>
  Lucas Tanure <tanureal@opensource.cirrus.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Lyude Paul <lyude@redhat.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Maor Dickman <maord@nvidia.com>
  Maor Gottlieb <maorg@nvidia.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Marek Behún <kabel@kernel.org>
  Mark Bloch <mbloch@nvidia.com>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matt Johnston <matt@codeconstruct.com.au>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Max Filippov <jcmvbkbc@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Stapelberg <michael@stapelberg.ch>
  Mike Christie <michael.christie@oracle.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  Moshe Shemesh <moshe@nvidia.com>
  msizanoen1 <msizanoen@qtmlabs.xyz>
  Muchun Song <songmuchun@bytedance.com>
  Mustapha Ghaddar <mghaddar@amd.com>
  Mustapha Ghaddar <mustapha.ghaddar@amd.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Nikita Danilov <ndanilov@aquantia.com>
  Ole Ernst <olebowle@gmx.com>
  Olga Kornievskaia <kolga@netapp.com>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Pavel Begunkov <asml.silence@gmail.com>
  Perry Yuan <Perry.Yuan@amd.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philip Chen <philipchen@chromium.org>
  Philip Yang <Philip.Yang@amd.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Ping-Ke Shih <pkshih@realtek.com>
  Qian Cai <quic_qiancai@quicinc.com>
  Raed Salem <raeds@nvidia.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sameer Pujar <spujar@nvidia.com>
  Sameer Saurabh <ssaurabh@marvell.com>
  Santosh Shilimkar <santosh.shilimkar@oracle.com>
  Sean Christopherson <seanjc@google.com>
  shaoyunl <shaoyun.liu@amd.com>
  Shen, George <George.Shen@amd.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Steev Klimaszewski <steev@kali.org>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephen Boyd <swboyd@chromium.org>
  Stephen Suryaputra <ssuryaextr@gmail.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudarsana Reddy Kalluru <skalluru@marvell.com>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  Sumit Semwal <sumit.semwal@linaro.org>
  Sven Schuchmann <schuchmann@schleissheimer.de>
  Takashi Iwai <tiwai@suse.de>
  Tariq Toukan <tariqt@nvidia.com>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tianhao Chai <cth451@gmail.com>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vitaly Rodionov <vitalyr@opensource.cirrus.com>
  Waiman Long <longman@redhat.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wenjia Zhang <wenjia@linux.ibm.com>
  William Kucharski <william.kucharski@oracle.com>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Xiayu Zhang <Xiayu.Zhang@mediatek.com>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Zhou Qingyang <zhou1615@umn.edu>
  Łukasz Bartosik <lb@semihalf.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          fail    
 test-armhf-armhf-xl                                          fail    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           fail    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 fail    
 test-amd64-amd64-xl-xsm                                      fail    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  fail    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   fail    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 fail    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 7762 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 04:05:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 04:05:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238026.412742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtMIH-00073m-3w; Sat, 04 Dec 2021 04:05:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238026.412742; Sat, 04 Dec 2021 04:05:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtMIG-00073f-Vw; Sat, 04 Dec 2021 04:05:00 +0000
Received: by outflank-mailman (input) for mailman id 238026;
 Sat, 04 Dec 2021 04:05:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMIG-00073V-En; Sat, 04 Dec 2021 04:05:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMIG-0006Cr-93; Sat, 04 Dec 2021 04:05:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMIF-0006GQ-Sm; Sat, 04 Dec 2021 04:04:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMIF-00056f-SI; Sat, 04 Dec 2021 04:04:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zMVKgCT72iJcEFwcHfuDF+VLW70FbOST74YjLT5/gmM=; b=UI947P7I/ONGCS3om6KtYvKJ0t
	wAMPQZqc87pkEaF3jS+kTRpNLxV1/ofg4oghH6FgNZEDQCi8GNTQp/CkbjwMXYJB9FV0JQbJ0jk4j
	eHHZgmf96L5YUgDIQrIYy7Fdsaof5eyDvDaM7WBnVyJT0SaBAupt2ojZvxa5Kr44K4/E=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167096-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 167096: regressions - FAIL
X-Osstest-Failures:
    seabios:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:regression
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:regression
    seabios:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    seabios:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-destroy:fail:heisenbug
    seabios:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    seabios:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=2dd4b9b3f84019668719344b40dba79d681be41c
X-Osstest-Versions-That:
    seabios=64f37cc530f144e53c190c9e8209a51b58fd5c43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 04 Dec 2021 04:04:59 +0000

flight 167096 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167096/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup        fail REGR. vs. 165173
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 165173
 test-amd64-i386-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 165173

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail in 167061 pass in 167096
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 16 guest-destroy fail pass in 167061
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 167061
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167061

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165173
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165173
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165173
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165173
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              2dd4b9b3f84019668719344b40dba79d681be41c
baseline version:
 seabios              64f37cc530f144e53c190c9e8209a51b58fd5c43

Last test of basis   165173  2021-09-24 03:09:48 Z   71 days
Testing same since   167061  2021-12-03 02:40:21 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Kevin O'Connor <kevin@koconnor.net>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        fail    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 2dd4b9b3f84019668719344b40dba79d681be41c
Author: Kevin O'Connor <kevin@koconnor.net>
Date:   Thu Dec 2 20:43:20 2021 -0500

    docs: Note v1.15.0 release
    
    Signed-off-by: Kevin O'Connor <kevin@koconnor.net>


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 04:49:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 04:49:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238034.412758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtMzb-000445-6k; Sat, 04 Dec 2021 04:49:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238034.412758; Sat, 04 Dec 2021 04:49:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtMzb-00043y-3u; Sat, 04 Dec 2021 04:49:47 +0000
Received: by outflank-mailman (input) for mailman id 238034;
 Sat, 04 Dec 2021 04:49:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMza-00043o-Ev; Sat, 04 Dec 2021 04:49:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMza-0006uO-2E; Sat, 04 Dec 2021 04:49:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMzZ-0007G5-Nb; Sat, 04 Dec 2021 04:49:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtMzZ-0001C1-N6; Sat, 04 Dec 2021 04:49:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sE+ChIyJ7kLPeV7Di9DipIqy43Bcf7GLG5yffj1BV5o=; b=UqxM057pGR/x7LUinc2NpOHzGv
	wnf1bp3P+X4r02/GJxsZ1BUCH/zLbz5gsY4jXpyUhwFyzdO43WunM+4CRpGVbXkIRfmdVRcVkM7DZ
	FFMOG0XuSvTjb0VmizyaOzESt/zofna7gvk/TgMHGt63961SO1gPBznmLr9izQqQJgBQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167104-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167104: regressions - FAIL
X-Osstest-Failures:
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:regression
X-Osstest-Versions-This:
    ovmf=dfafa8e45382939fb5dc78e9d37b97b500a43613
X-Osstest-Versions-That:
    ovmf=f0f3f5aae7c4d346ea5e24970936d80dc5b60657
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 04 Dec 2021 04:49:45 +0000

flight 167104 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167104/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166961
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 166961

version targeted for testing:
 ovmf                 dfafa8e45382939fb5dc78e9d37b97b500a43613
baseline version:
 ovmf                 f0f3f5aae7c4d346ea5e24970936d80dc5b60657

Last test of basis   166961  2021-11-30 14:41:39 Z    3 days
Testing same since   167081  2021-12-03 10:10:57 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         fail    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit dfafa8e45382939fb5dc78e9d37b97b500a43613
Author: wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>
Date:   Tue Nov 30 09:51:10 2021 +0800

    MdeModulePkg/DxeCorePerformanceLib:Variable Initial
    
    SmmBootRecordDataSize is initialized in InternalGetSmmPerData,
    but this function may fail. so to avoid using SmmBootRecordDataSize
    without intialization, set it to 0 at first.
    
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Liming Gao <gaoliming@byosoft.com.cn>
    Cc: Dandan Bi <dandan.bi@intel.com>
    Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
    Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
    Reviewed-by: Dandan Bi <dandan.bi@intel.com>


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 06:58:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 06:58:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238043.412773 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtOzA-0002Nv-Pb; Sat, 04 Dec 2021 06:57:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238043.412773; Sat, 04 Dec 2021 06:57:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtOzA-0002No-MV; Sat, 04 Dec 2021 06:57:28 +0000
Received: by outflank-mailman (input) for mailman id 238043;
 Sat, 04 Dec 2021 06:57:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Lxa8=QV=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1mtOz9-0002Ni-BH
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 06:57:27 +0000
Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr
 [80.12.242.129]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6fb1e510-54cf-11ec-a5e1-b9374ead2679;
 Sat, 04 Dec 2021 07:57:25 +0100 (CET)
Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id tOz3mtyH7MNzvtOz3m2FTn; Sat, 04 Dec 2021 07:57:24 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fb1e510-54cf-11ec-a5e1-b9374ead2679
X-ME-Helo: [192.168.1.18]
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Sat, 04 Dec 2021 07:57:24 +0100
X-ME-IP: 86.243.171.122
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Joe Perches <joe@perches.com>, Juergen Gross <jgross@suse.com>,
 sstabellini@kernel.org, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
 <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
 <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
Date: Sat, 4 Dec 2021 07:57:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit

Le 03/12/2021 à 22:04, Boris Ostrovsky a écrit :
> 
> On 12/3/21 10:54 AM, Christophe JAILLET wrote:
>> Le 03/12/2021 à 04:03, Joe Perches a écrit :
>>
>> I get your point now, and I agree with you.
>>
>> Maybe something as what is done in mc-entity.c?
>> Explicitly require more bits (which will be allocated anyway), instead 
>> of taking advantage (read "hoping") that it will be done.
>>
>> Could be:
>>
>> @@ -440,26 +440,25 @@ static int xlbd_reserve_minors(unsigned int 
>> minor, unsigned int nr)
>>      int rc;
>>
>>      if (end > nr_minors) {
>>          unsigned long *bitmap, *old;
>>
>> -        bitmap = kcalloc(BITS_TO_LONGS(end), sizeof(*bitmap),
>> -                 GFP_KERNEL);
>> +        end = ALIGN(end, BITS_PER_LONG);
>> +        bitmap = bitmap_zalloc(end, GFP_KERNEL);
>>          if (bitmap == NULL)
>>              return -ENOMEM;
>>
>>          spin_lock(&minor_lock);
>>          if (end > nr_minors) {
>>              old = minors;
>> -            memcpy(bitmap, minors,
>> -                   BITS_TO_LONGS(nr_minors) * sizeof(*bitmap));
>> +            bitmap_copy(bitmap, minors, nr_minors);
>>              minors = bitmap;
>> -            nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;
>> +            nr_minors = end;
>>          } else
>>              old = bitmap;
>>          spin_unlock(&minor_lock);
>> -        kfree(old);
>> +        bitmap_free(old);
>>      }
>>
>>      spin_lock(&minor_lock);
>>      if (find_next_bit(minors, end, minor) >= end) {
> 
> 
> I don't think this will work anymore, we may now fail if another thread 
> gets a minor above the original (i.e. no aligned) @end.
> 

So, maybe adding an "official" 'bitmap_size()' (which is already 
existing and duplicated in a few places) would ease things.

It would replace the 'nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;' 
and hide the implementation details of the bitmap API.

Something like:
static __always_inline size_t bitmap_size(unsigned long nr_bits)
{
	return BITS_TO_LONGS(nr_bits) * sizeof(long);
}

CJ

> 
> -boris
> 


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 07:05:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 07:05:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238049.412783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtP7A-0003rE-Jn; Sat, 04 Dec 2021 07:05:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238049.412783; Sat, 04 Dec 2021 07:05:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtP7A-0003r7-Gm; Sat, 04 Dec 2021 07:05:44 +0000
Received: by outflank-mailman (input) for mailman id 238049;
 Sat, 04 Dec 2021 07:05:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iFJX=QV=perches.com=joe@srs-se1.protection.inumbo.net>)
 id 1mtP79-0003qz-Om
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 07:05:43 +0000
Received: from smtprelay.hostedemail.com (smtprelay0222.hostedemail.com
 [216.40.44.222]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 96cda5e8-54d0-11ec-a5e1-b9374ead2679;
 Sat, 04 Dec 2021 08:05:41 +0100 (CET)
Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
 by smtprelay06.hostedemail.com (Postfix) with ESMTP id 9057818224D70;
 Sat,  4 Dec 2021 07:05:39 +0000 (UTC)
Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by
 omf09.hostedemail.com (Postfix) with ESMTPA id 0CAE82002C; 
 Sat,  4 Dec 2021 07:05:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96cda5e8-54d0-11ec-a5e1-b9374ead2679
Message-ID: <06f74e760966a090027bcfec8c22e97bc040e933.camel@perches.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Boris Ostrovsky
	 <boris.ostrovsky@oracle.com>, Juergen Gross <jgross@suse.com>, 
	sstabellini@kernel.org, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Date: Fri, 03 Dec 2021 23:05:37 -0800
In-Reply-To: <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
References: 
	<1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
	 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
	 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
	 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
	 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
	 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
	 <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
	 <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
	 <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.23
X-Stat-Signature: kghtzb7181hs7t5uegz983zku95oz1k9
X-Rspamd-Server: rspamout02
X-Rspamd-Queue-Id: 0CAE82002C
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Session-ID: U2FsdGVkX18WQvFgT880/VPxHgQ21iyOmrOfGf3TeLs=
X-HE-Tag: 1638601537-186527

On Sat, 2021-12-04 at 07:57 +0100, Christophe JAILLET wrote:
> So, maybe adding an "official" 'bitmap_size()' (which is already 
> existing and duplicated in a few places) would ease things.
> 
> It would replace the 'nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;' 
> and hide the implementation details of the bitmap API.
> 
> Something like:
> static __always_inline size_t bitmap_size(unsigned long nr_bits)
> {
> 	return BITS_TO_LONGS(nr_bits) * sizeof(long);
> }

Or maybe a bitmap_realloc



From xen-devel-bounces@lists.xenproject.org Sat Dec 04 07:22:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 07:22:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238055.412795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPN1-0006aO-Sk; Sat, 04 Dec 2021 07:22:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238055.412795; Sat, 04 Dec 2021 07:22:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPN1-0006aH-P3; Sat, 04 Dec 2021 07:22:07 +0000
Received: by outflank-mailman (input) for mailman id 238055;
 Sat, 04 Dec 2021 07:22:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Auw7=QV=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtPN0-0006aB-Ql
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 07:22:06 +0000
Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com
 [2607:f8b0:4864:20::102c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e1ba1dd5-54d2-11ec-8a4d-196798b21f7b;
 Sat, 04 Dec 2021 08:22:05 +0100 (CET)
Received: by mail-pj1-x102c.google.com with SMTP id
 p18-20020a17090ad31200b001a78bb52876so6898509pju.3
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 23:22:05 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 t10sm4331860pga.6.2021.12.03.23.21.53
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 23:22:03 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e1ba1dd5-54d2-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=ZkQEYozmB0wgYJcxDO/m983AAdy8n14FhucCaGoUzA4=;
        b=blREAYP23qBjIahcqczEuNSUq6MRbQ5UXgW1oG4ZGSSpOed90dbanN+LHvJF7N6ME0
         Y9LKoSwodHr9BOd//+DW6OvBPSh6Rf4BdMb2EzDvtQ+sVoes1f6+7VWyUKFWqiaSHHqU
         Am+FtOCVPnOAgj6oTP0k0IWgh4dooTt7QX7KQKbCT+o69WR7nP4hJQspPwFm25qXtPCW
         kBdkmADgMPc7HTKvYOavrblwjUfXQ3wlSxkW6E/shgs8QAhLWvPBZ3tVRmEVD7CWY44S
         t8LTdIFpatSjby01xMjLjf42MSd1m5DtLtC+1uS3bLpAx3vREm/i+1aUCO81LPZgXzuP
         nkWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=ZkQEYozmB0wgYJcxDO/m983AAdy8n14FhucCaGoUzA4=;
        b=nf5g6E9l0jkGlu+hSpcdacZnlMwQoW+j1n92qFeeZV1RS0kl+idSmLGj2yMYnUYQlN
         5uK5bMpYx641iLflehuyUJG+f7gpxaKZUEIEz9WU1phpiyCzLfQI9YUYBFIX02ZeWhr/
         jlX+JumoLx0sKeWAvzOP18GzGzcMwNO2SRkWlFjVgjlxWNUaee/e/iQoAb63FVbA6Ufq
         9vVsbqQ3g11hHvs4LoFlh6eZ3dq7STb8hMO3oJ/dG5t8DrF/uS6qoSY4g/4P1PccBsmZ
         tzWRqdcIA9Sgez0krnZAfJ5hIk2pEpMvL9NuDLgjGa8arclp4S0iSrFfNJBv84i2CJT0
         GzRA==
X-Gm-Message-State: AOAM533+tJyPsWCfPudRygLLBES0gX3roGbAi/wnAEXMPaUZVcgeGV9p
	zRRg4GSpDTTp08FFqNsipAo=
X-Google-Smtp-Source: ABdhPJzcZuwuxSGpXoC+LpAfScg+HY+PAZl5x85Fy3cmkRF8TnHHjxYQIiUVC9++sZKTL0nxBihlXA==
X-Received: by 2002:a17:903:1105:b0:143:a593:dc6e with SMTP id n5-20020a170903110500b00143a593dc6emr28523850plh.6.1638602524291;
        Fri, 03 Dec 2021 23:22:04 -0800 (PST)
Message-ID: <59e41c28-260f-876d-c7cf-a13669ad8984@gmail.com>
Date: Sat, 4 Dec 2021 15:21:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
Content-Language: en-US
To: Tom Lendacky <thomas.lendacky@amd.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jgross@suse.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, Tianyu.Lan@microsoft.com,
 xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-2-ltykernel@gmail.com>
 <41bb0a87-9fdb-4c67-a903-9e87d092993a@amd.com>
 <e78ba239-2dad-d48f-671e-f76a943052f1@gmail.com>
 <06faf04c-dc4a-69fd-0be9-04f57f779ffe@amd.com>
 <1b7b8e20-a861-ab26-26a1-dad1eb80a461@amd.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <1b7b8e20-a861-ab26-26a1-dad1eb80a461@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 12/4/2021 4:06 AM, Tom Lendacky wrote:
>>> Hi Tom:
>>>        Thanks for your test. Could you help to test the following 
>>> patch and check whether it can fix the issue.
>>
>> The patch is mangled. Is the only difference where 
>> set_memory_decrypted() is called?
> 
> I de-mangled the patch. No more stack traces with SME active.
> 
> Thanks,
> Tom

Hi Tom:
	Thanks a lot for your rework and test. I will update in the next version.

Thanks.


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 07:26:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 07:26:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238061.412806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPRd-0007EH-EP; Sat, 04 Dec 2021 07:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238061.412806; Sat, 04 Dec 2021 07:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPRd-0007EA-BF; Sat, 04 Dec 2021 07:26:53 +0000
Received: by outflank-mailman (input) for mailman id 238061;
 Sat, 04 Dec 2021 07:26:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Auw7=QV=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtPRb-0007E4-Rz
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 07:26:51 +0000
Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com
 [2607:f8b0:4864:20::432])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bb6ac3f-54d3-11ec-a5e1-b9374ead2679;
 Sat, 04 Dec 2021 08:26:51 +0100 (CET)
Received: by mail-pf1-x432.google.com with SMTP id u80so5071807pfc.9
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 23:26:50 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 m184sm4248180pga.61.2021.12.03.23.26.39
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 23:26:49 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bb6ac3f-54d3-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=eCoo4UdX0KSai3rgxqp+sZCsWhUUBGl2p1rpp3l5eBw=;
        b=SrgtERJGlFYclhGBMZWqWPGAIZbR6fQ6Uu4tpnTSOZi4kEEMeogHi+38ibOB1Ey21P
         NsKwL8E3bcEDfz8ZW+SzX7lW4BoeQcApz4UUqds31/0hKjtB8GC+RLIm017R9iXqjTQ5
         5L1ib+SOX+p6av7/1hxf7B+3Qxk2Iw7WqrJvdJo9bhmIi2CFI/RD70cSaIdmmD4TnbkS
         5y6tetKfkLX0NGXFeSmkkx7JTdHF8qPgaL8esKv9vgiuB4mG86p3+JuYbDIU/22ynW84
         XgstoStjjO1fceJiyUS6HIleMKpq85ai6WbYYTiWfwnyb44HUdjQ0qsdqcUOoB5fcM8p
         lk9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=eCoo4UdX0KSai3rgxqp+sZCsWhUUBGl2p1rpp3l5eBw=;
        b=C6n5RWxvR8iX3LSVmQ9IGV2k4U50X3zXE0EVwgDzAYUXpFg500DQlbqlGl0Gi/dVcy
         8KrATf4Cr9/ljLKzGlyuMDcKC67MZoONGoMWT6K398yCPSpcyrA/VE7YDcq6YOnX4Af2
         UGAAY0oXWcSgtyXl+1xkHWV5wXM9K9AxFidFX2br43loT2te72wDEvOh7yE6nkamwGLM
         nJGFmMo4o9a5vFl+Ckepo4mviNFX9AethCCfyPO4pcxBjkPfS1EyVavI8KWnoAEFMbF7
         TiuKHTX8Iboh1Lz3HdaNrfZBCBoSlyYEnEDX0DuPuXEOMiewXSl3FVdYUX/0umvGJsjn
         vfqg==
X-Gm-Message-State: AOAM53103Qc2iqAMu7YtxUiLpkPlCYY6xFcaW1E973BW8I2onphoyE2n
	azMM2p1jP0Rv2rJEaKDp3JS3PdSaGIIbcA==
X-Google-Smtp-Source: ABdhPJwCQRkn3xmR+kfR3YlZKVCxe03wvGUj2OGYKR6Vkh9NokqMfnW2TUg5Koi/TslOtDsFr3TRJg==
X-Received: by 2002:a63:8ac1:: with SMTP id y184mr8696835pgd.48.1638602809615;
        Fri, 03 Dec 2021 23:26:49 -0800 (PST)
Message-ID: <877e6f24-2004-0681-f9f3-241fb6ace427@gmail.com>
Date: Sat, 4 Dec 2021 15:26:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Content-Language: en-US
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
 "jgross@suse.com" <jgross@suse.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
 "joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>,
 "davem@davemloft.net" <davem@davemloft.net>,
 "kuba@kernel.org" <kuba@kernel.org>, "jejb@linux.ibm.com"
 <jejb@linux.ibm.com>, "martin.petersen@oracle.com"
 <martin.petersen@oracle.com>, "arnd@arndb.de" <arnd@arndb.de>,
 "hch@infradead.org" <hch@infradead.org>,
 "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
 "robin.murphy@arm.com" <robin.murphy@arm.com>,
 Tianyu Lan <Tianyu.Lan@microsoft.com>,
 "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
 "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 vkuznets <vkuznets@redhat.com>, "brijesh.singh@amd.com"
 <brijesh.singh@amd.com>, "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
 "hch@lst.de" <hch@lst.de>, "parri.andrea@gmail.com"
 <parri.andrea@gmail.com>, "dave.hansen@intel.com" <dave.hansen@intel.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-4-ltykernel@gmail.com>
 <MWHPR21MB159390BE1B546A6F90FB1F18D76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <MWHPR21MB159390BE1B546A6F90FB1F18D76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/4/2021 3:17 AM, Michael Kelley (LINUX) wrote:
>> +static void __init hyperv_iommu_swiotlb_init(void)
>> +{
>> +	unsigned long hyperv_io_tlb_size;
>> +	void *hyperv_io_tlb_start;
>> +
>> +	/*
>> +	 * Allocate Hyper-V swiotlb bounce buffer at early place
>> +	 * to reserve large contiguous memory.
>> +	 */
>> +	hyperv_io_tlb_size = swiotlb_size_or_default();
>> +	hyperv_io_tlb_start = memblock_alloc(hyperv_io_tlb_size, PAGE_SIZE);
>> +
>> +	if (!hyperv_io_tlb_start)
>> +		pr_warn("Fail to allocate Hyper-V swiotlb buffer.\n");
> In the error case, won't swiotlb_init_with_tlb() end up panic'ing when
> it tries to zero out the memory?   The only real choice here is to
> return immediately after printing the message, and not call
> swiotlb_init_with_tlb().
> 

Yes, agree. Will update.


From xen-devel-bounces@lists.xenproject.org Sat Dec 04 07:43:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 07:43:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238071.412817 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPh6-0001bT-EY; Sat, 04 Dec 2021 07:42:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238071.412817; Sat, 04 Dec 2021 07:42:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtPh6-0001bM-BI; Sat, 04 Dec 2021 07:42:52 +0000
Received: by outflank-mailman (input) for mailman id 238071;
 Sat, 04 Dec 2021 07:42:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Auw7=QV=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtPh5-0001bG-8m
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 07:42:51 +0000
Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com
 [2607:f8b0:4864:20::102b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c77693c2-54d5-11ec-8a4d-196798b21f7b;
 Sat, 04 Dec 2021 08:42:50 +0100 (CET)
Received: by mail-pj1-x102b.google.com with SMTP id x7so4041395pjn.0
 for <xen-devel@lists.xenproject.org>; Fri, 03 Dec 2021 23:42:50 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 mz7sm7286643pjb.7.2021.12.03.23.42.38
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 03 Dec 2021 23:42:48 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c77693c2-54d5-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=k/XW81IzuVveDnfkiaihrgRy1fm8QRuVkAriBYUSktQ=;
        b=aeetCr9E159DG34hEjAeWGhArTHlrTQp+RvPNuwjMb9u/3PFY53wzhtHubgWJQvDgG
         Jozxdg5UENxD6v0AUKHmjx4efncr1d3uH51laaSKr9cPyQcT+BdlVcFvxfS2q7alc9M+
         IQoElcNzWMNvIxf21BBZKf234HszCsVWMj7scSChzf64nuKTXacuscJrUCAKLRq29Wrh
         e5337Xbg+LNRcQZd6EO7eqCabhSTi7bBHidYnjemVzHYg6jyVwVpnU2LRvbC5rtLuJMX
         22ZzHU6J0KwMuux99RJ5m0Zk9mxBVsGjyiM9lko2MTYAamfaDiH1DIbBhIO1ffuEquNb
         e04w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=k/XW81IzuVveDnfkiaihrgRy1fm8QRuVkAriBYUSktQ=;
        b=GgQcN1KAkuNUPBjJcjOjDUp59xuxXHrZzrExQidolyPYXDqht3b4tfV/8odO7wBfmh
         GsOh2gn8b+x7wit1TbG21H5m577sFE5Fi0Gya7d4F13LFd808ifhGyMFmlHirz3neOcR
         QYlyZK0CwwcS7B6xnVSaEBFVTqq83wFdSmjYRtFsJsL9p3SGnDG4Zx+lS1JYOWp5RU8S
         DeVMwZLBIv5riRt3IiXE3wpQxWF13cRyex1ar9E/fWMnVC618bvmToIue4OtUpEHxdNs
         V5Ta4H2qvN7oSwKV9gaSEt3W27pqdjM7/E3nNI2ABQj/yZvgqDyfwuxMJl3jRxjRZ+1m
         QpYA==
X-Gm-Message-State: AOAM530BC0xVFgGMBLIRaubTb3JYKKOUhNdl+5tzEKdQn+sS0fRvrueP
	MK2kZUYm+bpDe9fUKNiugFo=
X-Google-Smtp-Source: ABdhPJwRWGj4ETvjt39e2arm3ZwL48sLjKr/6To2ton+oBAvgGlhyx9UEyFTCkGwPmBxwIqCiR8C4Q==
X-Received: by 2002:a17:902:714f:b0:142:892d:a46 with SMTP id u15-20020a170902714f00b00142892d0a46mr28039873plm.39.1638603768758;
        Fri, 03 Dec 2021 23:42:48 -0800 (PST)
Message-ID: <448de4ec-b73e-597f-16fe-623123c04d1e@gmail.com>
Date: Sat, 4 Dec 2021 15:42:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V3 5/5] hv_netvsc: Add Isolation VM support for netvsc
 driver
Content-Language: en-US
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
 KY Srinivasan <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 "wei.liu@kernel.org" <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
 "tglx@linutronix.de" <tglx@linutronix.de>,
 "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
 "jgross@suse.com" <jgross@suse.com>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
 "joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>,
 "davem@davemloft.net" <davem@davemloft.net>,
 "kuba@kernel.org" <kuba@kernel.org>, "jejb@linux.ibm.com"
 <jejb@linux.ibm.com>, "martin.petersen@oracle.com"
 <martin.petersen@oracle.com>, "arnd@arndb.de" <arnd@arndb.de>,
 "hch@infradead.org" <hch@infradead.org>,
 "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
 "robin.murphy@arm.com" <robin.murphy@arm.com>,
 Tianyu Lan <Tianyu.Lan@microsoft.com>,
 "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
 "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
 "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 vkuznets <vkuznets@redhat.com>, "brijesh.singh@amd.com"
 <brijesh.singh@amd.com>, "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
 "hch@lst.de" <hch@lst.de>, "parri.andrea@gmail.com"
 <parri.andrea@gmail.com>, "dave.hansen@intel.com" <dave.hansen@intel.com>
References: <20211201160257.1003912-1-ltykernel@gmail.com>
 <20211201160257.1003912-6-ltykernel@gmail.com>
 <MWHPR21MB15934DE25012A8565256336ED76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <MWHPR21MB15934DE25012A8565256336ED76A9@MWHPR21MB1593.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/4/2021 2:59 AM, Michael Kelley (LINUX) wrote:
>> +
>> +/*
>> + * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolation VM.
>> + */
>> +void *hv_map_memory(void *addr, unsigned long size)
>> +{
>> +	unsigned long *pfns = kcalloc(size / HV_HYP_PAGE_SIZE,
> This should be just PAGE_SIZE, as this code is unrelated to communication
> with Hyper-V.
>

Yes, agree. Will update.



From xen-devel-bounces@lists.xenproject.org Sat Dec 04 22:18:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 04 Dec 2021 22:18:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238189.412827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtdMK-0005I5-IB; Sat, 04 Dec 2021 22:18:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238189.412827; Sat, 04 Dec 2021 22:18:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtdMK-0005Hy-Eh; Sat, 04 Dec 2021 22:18:20 +0000
Received: by outflank-mailman (input) for mailman id 238189;
 Sat, 04 Dec 2021 22:18:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mtdMJ-0005Hs-78
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 22:18:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mtdMJ-0000YH-5U
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 22:18:19 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mtdMJ-00068d-4T
 for xen-devel@lists.xenproject.org; Sat, 04 Dec 2021 22:18:19 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mtdLz-0002Uc-CH; Sat, 04 Dec 2021 22:17:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=HflXVQd4U/EunfNUxkFSZ7aNxu449XTon/iisxA5kSg=; b=IfBirCfKrBgQ6muHT7ufulyYUm
	R7PMTmYpFnynCXibHv+J8u0VZtv65Z5xIXAURdPBzp1lXtYk7vccZU2qs+Ay5AcwstUvfRS6LCzkU
	NHJqd8sDGGrSYZ5ZQo1+/vRxCbMLdqGRIP3/AcvxufGdzyh4mPM7Olqp59/+VQPDfUQQ=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH] production-config: renumbering the test lab
Date: Sat,  4 Dec 2021 22:17:53 +0000
Message-Id: <20211204221753.2222-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Our dhcp pool exhausted.  I am going to force push this.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 production-config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/production-config b/production-config
index 9a4054445..023b81622 100644
--- a/production-config
+++ b/production-config
@@ -27,7 +27,7 @@ HostDB_Executive_NoConfigDB 1
 Include /root/osstest-hosts-config
 
 DnsDomain test-lab.xenproject.org
-NetNameservers 172.16.144.4
+NetNameservers 10.149.64.4
 
 OwnerDaemonHost db
 QueueDaemonHost osstest
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 02:02:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 02:02:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238208.412872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtgqD-0007RW-WD; Sun, 05 Dec 2021 02:01:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238208.412872; Sun, 05 Dec 2021 02:01:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtgqD-0007RO-P6; Sun, 05 Dec 2021 02:01:25 +0000
Received: by outflank-mailman (input) for mailman id 238208;
 Sun, 05 Dec 2021 02:01:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtgqC-0007RE-BM; Sun, 05 Dec 2021 02:01:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtgqC-0006mS-0i; Sun, 05 Dec 2021 02:01:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtgqB-0001EX-L6; Sun, 05 Dec 2021 02:01:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtgqB-0005vS-KZ; Sun, 05 Dec 2021 02:01:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=EESQR8ledLGjo8pJXf/cAZXzy5C3XawoiBV25ntE9II=; b=Uv2g/LhjEajCrfXREBn6FLV45B
	gXvacIQrtuhledLN/clp4X7ywD9azXIiC+VmXxm0Z2dV/yO/jn6WCXawMPPnEp+FhraS4AvZLrnyG
	CadRv+9aTNi55mLA3PPVsMvhiF/KFfmYU1BxLrkbRrcOvRcGzm04WaUlWfPWbVyR0fsA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167110-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167110: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 05 Dec 2021 02:01:23 +0000

flight 167110 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167110/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166958  2021-11-30 12:00:32 Z    4 days
Failing since        166977  2021-12-01 17:08:21 Z    3 days   12 attempts
Testing same since   167105  2021-12-03 18:02:58 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tim Deegan <tim@xen.org>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7f147bf4a..ea0c08bc77  ea0c08bc77fe7bd7e4e65c648e17752e91912d01 -> smoke


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238263.412985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj1-0006TW-Pd; Sun, 05 Dec 2021 08:18:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238263.412985; Sun, 05 Dec 2021 08:18:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj1-0006TP-MA; Sun, 05 Dec 2021 08:18:23 +0000
Received: by outflank-mailman (input) for mailman id 238263;
 Sun, 05 Dec 2021 08:18:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj0-0006T9-5g
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:22 +0000
Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com
 [2607:f8b0:4864:20::534])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e70cf450-55a3-11ec-a5e1-b9374ead2679;
 Sun, 05 Dec 2021 09:18:20 +0100 (CET)
Received: by mail-pg1-x534.google.com with SMTP id k4so7393452pgb.8
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:20 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:17 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e70cf450-55a3-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=dfM94A9YIlyVB8rT/Fyc0cGVK5U5XvE0VXTSezF6RKs=;
        b=XjtWZ4TQugWlqSvIgCkbqi7HQ5b8zuwuwua6IwpffcpwfAyDaobtNwXYuWcvpbBFE4
         9WcjLsStsKid77+RD2YC7kd02/pHapke3O37ldqGjOQxX3qpaITr2seyiQsoxB3w7Wc0
         p/CMzw4L9gQcgza+P0xpVKrvTkJmfwAcQbe9cdQN/96UJkevU198ptb2fql3Nl42vmjo
         z6E4jbyPJsG1mpx5G3qbcemu+YT6WaxTXXHQPNWZTvdAzgx2cPqLhcMeWwsECq7ROn0S
         jdr1XwQiTJQJh0m1FBJbpNlLwobl8Bf+uppKRO+fqeRzV4k1EfksDNQY4LqGbBl9E3qY
         gIAQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=dfM94A9YIlyVB8rT/Fyc0cGVK5U5XvE0VXTSezF6RKs=;
        b=1Al6GdsiO9ekUOGTW4AKvpyz7MAAL4atULa8npRu/SAVj6kfS+oLEkg9h/Rbbt2CuH
         FiGTY4syMt408QYxn/gRFOlpfiRlHU9q35zdds8w9dCZSnxmUO2RL7TRwm8I0qRV1SzZ
         zFbH7EjJX3oXKi3FqDe+MxpxaCi5HRI+n9qZXARdXIvtJ2ahHdozCsT5jkKjzxUl5SdQ
         AMp+eYiK6aOfTKfgamughHXAvKVi87aGJuHN3QiL5EIz9oIrYLQr0JjqVqlAqyx0ENJY
         mG+RPtHTBwI9M8ZtT687lLmrOheLW5hJdJ5WPXwQrHSfSfYuws971Qd+EiGcNck1bHPQ
         69FQ==
X-Gm-Message-State: AOAM532hRICs0C5M54mmPt62dxEsjNwIqL0ghha5+7fcXaX+D349LLD+
	D6hd+uQCBHXGlDm0i9DrxO0=
X-Google-Smtp-Source: ABdhPJx1nL+30YTsDOKE6LJfYcCpMeKCOeoz9AVpsf63uFFgijhWvJ6bOiQ0k+V3CXM4JXAEUKtCKw==
X-Received: by 2002:aa7:8755:0:b0:494:67a6:1c84 with SMTP id g21-20020aa78755000000b0049467a61c84mr28292360pfo.26.1638692297989;
        Sun, 05 Dec 2021 00:18:17 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 0/5] x86/Hyper-V: Add Hyper-V Isolation VM support(Second part)
Date: Sun,  5 Dec 2021 03:18:08 -0500
Message-Id: <20211205081815.129276-1-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based
security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset
is to add support for these Isolation VM support in Linux.

The memory of these vms are encrypted and host can't access guest
memory directly. Hyper-V provides new host visibility hvcall and
the guest needs to call new hvcall to mark memory visible to host
before sharing memory with host. For security, all network/storage
stack memory should not be shared with host and so there is bounce
buffer requests.

Vmbus channel ring buffer already plays bounce buffer role because
all data from/to host needs to copy from/to between the ring buffer
and IO stack memory. So mark vmbus channel ring buffer visible.

For SNP isolation VM, guest needs to access the shared memory via
extra address space which is specified by Hyper-V CPUID HYPERV_CPUID_
ISOLATION_CONFIG. The access physical address of the shared memory
should be bounce buffer memory GPA plus with shared_gpa_boundary
reported by CPUID.

This patchset is to enable swiotlb bounce buffer for netvsc/storvsc
in Isolation VM.

This version follows Michael Kelley suggestion in the following link.
https://lkml.org/lkml/2021/11/24/2044

Change since v3:
	* Fix boot up failure on the host with mem_encrypt=on.
	  Move calloing of set_memory_decrypted() back from
	  swiotlb_init_io_tlb_mem to swiotlb_late_init_with_tbl()
	  and rmem_swiotlb_device_init().
	* Change code style of checking GUEST_MEM attribute in the
	  hyperv_cc_platform_has().
	* Add comment in pci-swiotlb-xen.c to explain why add
	  dependency between hyperv_swiotlb_detect() and pci_
	  xen_swiotlb_detect().
	* Return directly when fails to allocate Hyper-V swiotlb
	  buffer in the hyperv_iommu_swiotlb_init().

Change since v2:
	* Remove Hyper-V dma ops and dma_alloc/free_noncontiguous. Add
	  hv_map/unmap_memory() to map/umap netvsc rx/tx ring into extra
	  address space.
	* Leave mem->vaddr in swiotlb code with phys_to_virt(mem->start)
	  when fail to remap swiotlb memory.

Change since v1:
	* Add Hyper-V Isolation support check in the cc_platform_has()
	  and return true for guest memory encrypt attr.
	* Remove hv isolation check in the sev_setup_arch()

Tianyu Lan (5):
  Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM
  x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has()
  hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
  scsi: storvsc: Add Isolation VM support for storvsc driver
  hv_netvsc: Add Isolation VM support for netvsc driver

 arch/x86/hyperv/ivm.c             |  28 ++++++
 arch/x86/kernel/cc_platform.c     |  12 +++
 arch/x86/xen/pci-swiotlb-xen.c    |  12 ++-
 drivers/hv/hv_common.c            |  11 +++
 drivers/hv/vmbus_drv.c            |   4 +
 drivers/iommu/hyperv-iommu.c      |  58 +++++++++++++
 drivers/net/hyperv/hyperv_net.h   |   5 ++
 drivers/net/hyperv/netvsc.c       | 136 +++++++++++++++++++++++++++++-
 drivers/net/hyperv/netvsc_drv.c   |   1 +
 drivers/net/hyperv/rndis_filter.c |   2 +
 drivers/scsi/storvsc_drv.c        |  37 ++++----
 include/asm-generic/mshyperv.h    |   2 +
 include/linux/hyperv.h            |  14 +++
 include/linux/swiotlb.h           |   6 ++
 kernel/dma/swiotlb.c              |  43 +++++++++-
 15 files changed, 349 insertions(+), 22 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238266.413017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj4-0007Fk-QL; Sun, 05 Dec 2021 08:18:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238266.413017; Sun, 05 Dec 2021 08:18:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj4-0007FI-MK; Sun, 05 Dec 2021 08:18:26 +0000
Received: by outflank-mailman (input) for mailman id 238266;
 Sun, 05 Dec 2021 08:18:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj2-0006TA-Lm
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:24 +0000
Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com
 [2607:f8b0:4864:20::52f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9938e49-55a3-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 09:18:23 +0100 (CET)
Received: by mail-pg1-x52f.google.com with SMTP id m15so7396111pgu.11
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:23 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9938e49-55a3-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=HEtQ2VgG/AmO4M2o0U/qmYacDg8cWHw/nJTaFUeWEoM=;
        b=qVZeIp4wgKkg5FZMbPln6Q/k5s4EHMptgSE2q5o2Xt4yqRYPYjNg7ie0xdW0nU9pK3
         EUPzswRFN0nOeut8n+3r/e0zksf/HiSEBtBx9sn7LR7AgOoxN7xP6SbnHLmWjDcawUWf
         jivfnKtLrjpcSCl9pE113Any9Pq+pa4y9vDbCp+72hnYT17zr/DO7aqWlmnAZjsV9COL
         rKWIGdD84O/9Ch/nucGUpRkDiPhw6cJlPuNmBx1VMYhoKhOTKm0A7D6au5Eoumm4sqxd
         mpOLxi2IMNgtgXsv9pyUZ3m8W2OGNM46u91gZ5lcUWV/daJknoScyM1JyagbFjwbAtVK
         krGw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=HEtQ2VgG/AmO4M2o0U/qmYacDg8cWHw/nJTaFUeWEoM=;
        b=AYxY+cxUry5sB2V4g9q0GdoUGeyeeoUwuSVB0IULZpPbAMPT4p9E/OYyafivjpRgZY
         lOireoSWkmoGIAvVIG+w9vasLnMen5ABqjtldnDXcI+UuZRnSHgGq4DA15TBuujimNXG
         fqNvuAqJqGvDTiQvflSvwnyEEPm1dc3aN3gg6n8YGOT2XZbfieiEHHKNvWDZllNYdThH
         bJb4rA3W9kURxws32054P85mSBLoTp07G2GdxMTb13y2i6K73D1MKw8dfyYBoK9l05Se
         hEiAf3i6pKLlnCGa+buD6ccSO5zWPuQDV6cqWoV4JZUnBl1/hFApYPeWSSh9g49cos+Y
         d0Lg==
X-Gm-Message-State: AOAM530Qo6Zc+IdnoBQQxUWleesuKMsX+ONcdorVSngmiIWDBUVWnfwl
	Qck8r2i640NvxDDA9aiJlmo=
X-Google-Smtp-Source: ABdhPJxDrjBlMEFOekoi/ebwbSRvDUyUkIlPU98qCt8JNd3nV7P8t6G2JhmCP59zVAcQ4e+N2RRH4w==
X-Received: by 2002:a05:6a00:a94:b0:44c:ecb2:6018 with SMTP id b20-20020a056a000a9400b0044cecb26018mr29289107pfl.57.1638692302327;
        Sun, 05 Dec 2021 00:18:22 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM
Date: Sun,  5 Dec 2021 03:18:11 -0500
Message-Id: <20211205081815.129276-4-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211205081815.129276-1-ltykernel@gmail.com>
References: <20211205081815.129276-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

hyperv Isolation VM requires bounce buffer support to copy
data from/to encrypted memory and so enable swiotlb force
mode to use swiotlb bounce buffer for DMA transaction.

In Isolation VM with AMD SEV, the bounce buffer needs to be
accessed via extra address space which is above shared_gpa_boundary
(E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
The access physical address will be original physical address +
shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
spec is called virtual top of memory(vTOM). Memory addresses below
vTOM are automatically treated as private while memory above
vTOM is treated as shared.

Hyper-V initalizes swiotlb bounce buffer and default swiotlb
needs to be disabled. pci_swiotlb_detect_override() and
pci_swiotlb_detect_4gb() enable the default one. To override
the setting, hyperv_swiotlb_detect() needs to run before
these detect functions which depends on the pci_xen_swiotlb_
init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
_detect() to keep the order.

Swiotlb bounce buffer code calls set_memory_decrypted()
to mark bounce buffer visible to host and map it in extra
address space via memremap. Populate the shared_gpa_boundary
(vTOM) via swiotlb_unencrypted_base variable.

The map function memremap() can't work in the early place
hyperv_iommu_swiotlb_init() and so call swiotlb_update_mem_attributes()
in the hyperv_iommu_swiotlb_later_init().

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v3:
	* Add comment in pci-swiotlb-xen.c to explain why add
	  dependency between hyperv_swiotlb_detect() and pci_
	  xen_swiotlb_detect().
	* Return directly when fails to allocate Hyper-V swiotlb
	  buffer in the hyperv_iommu_swiotlb_init().
---
 arch/x86/xen/pci-swiotlb-xen.c | 12 ++++++-
 drivers/hv/vmbus_drv.c         |  3 ++
 drivers/iommu/hyperv-iommu.c   | 58 ++++++++++++++++++++++++++++++++++
 include/linux/hyperv.h         |  8 +++++
 4 files changed, 80 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c
index 46df59aeaa06..8e2ee3ce6374 100644
--- a/arch/x86/xen/pci-swiotlb-xen.c
+++ b/arch/x86/xen/pci-swiotlb-xen.c
@@ -4,6 +4,7 @@
 
 #include <linux/dma-map-ops.h>
 #include <linux/pci.h>
+#include <linux/hyperv.h>
 #include <xen/swiotlb-xen.h>
 
 #include <asm/xen/hypervisor.h>
@@ -90,7 +91,16 @@ int pci_xen_swiotlb_init_late(void)
 }
 EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late);
 
+/*
+ * Hyper-V initalizes swiotlb bounce buffer and default swiotlb
+ * needs to be disabled. pci_swiotlb_detect_override() and
+ * pci_swiotlb_detect_4gb() enable the default one. To override
+ * the setting, hyperv_swiotlb_detect() needs to run before
+ * these detect functions which depends on the pci_xen_swiotlb_
+ * init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
+ * _detect() to keep the order.
+ */
 IOMMU_INIT_FINISH(pci_xen_swiotlb_detect,
-		  NULL,
+		  hyperv_swiotlb_detect,
 		  pci_xen_swiotlb_init,
 		  NULL);
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 392c1ac4f819..0a64ccfafb8b 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -33,6 +33,7 @@
 #include <linux/random.h>
 #include <linux/kernel.h>
 #include <linux/syscore_ops.h>
+#include <linux/dma-map-ops.h>
 #include <clocksource/hyperv_timer.h>
 #include "hyperv_vmbus.h"
 
@@ -2078,6 +2079,7 @@ struct hv_device *vmbus_device_create(const guid_t *type,
 	return child_device_obj;
 }
 
+static u64 vmbus_dma_mask = DMA_BIT_MASK(64);
 /*
  * vmbus_device_register - Register the child device
  */
@@ -2118,6 +2120,7 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 	}
 	hv_debug_add_dev_dir(child_device_obj);
 
+	child_device_obj->device.dma_mask = &vmbus_dma_mask;
 	return 0;
 
 err_kset_unregister:
diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
index e285a220c913..44ba24d9e06c 100644
--- a/drivers/iommu/hyperv-iommu.c
+++ b/drivers/iommu/hyperv-iommu.c
@@ -13,14 +13,20 @@
 #include <linux/irq.h>
 #include <linux/iommu.h>
 #include <linux/module.h>
+#include <linux/hyperv.h>
+#include <linux/io.h>
 
 #include <asm/apic.h>
 #include <asm/cpu.h>
 #include <asm/hw_irq.h>
 #include <asm/io_apic.h>
+#include <asm/iommu.h>
+#include <asm/iommu_table.h>
 #include <asm/irq_remapping.h>
 #include <asm/hypervisor.h>
 #include <asm/mshyperv.h>
+#include <asm/swiotlb.h>
+#include <linux/dma-direct.h>
 
 #include "irq_remapping.h"
 
@@ -337,4 +343,56 @@ static const struct irq_domain_ops hyperv_root_ir_domain_ops = {
 	.free = hyperv_root_irq_remapping_free,
 };
 
+static void __init hyperv_iommu_swiotlb_init(void)
+{
+	unsigned long hyperv_io_tlb_size;
+	void *hyperv_io_tlb_start;
+
+	/*
+	 * Allocate Hyper-V swiotlb bounce buffer at early place
+	 * to reserve large contiguous memory.
+	 */
+	hyperv_io_tlb_size = swiotlb_size_or_default();
+	hyperv_io_tlb_start = memblock_alloc(hyperv_io_tlb_size, PAGE_SIZE);
+
+	if (!hyperv_io_tlb_start) {
+		pr_warn("Fail to allocate Hyper-V swiotlb buffer.\n");
+		return;
+	}
+
+	swiotlb_init_with_tbl(hyperv_io_tlb_start,
+			      hyperv_io_tlb_size >> IO_TLB_SHIFT, true);
+}
+
+int __init hyperv_swiotlb_detect(void)
+{
+	if (!hypervisor_is_type(X86_HYPER_MS_HYPERV))
+		return 0;
+
+	if (!hv_is_isolation_supported())
+		return 0;
+
+	/*
+	 * Enable swiotlb force mode in Isolation VM to
+	 * use swiotlb bounce buffer for dma transaction.
+	 */
+	if (hv_isolation_type_snp())
+		swiotlb_unencrypted_base = ms_hyperv.shared_gpa_boundary;
+	swiotlb_force = SWIOTLB_FORCE;
+	return 1;
+}
+
+static void __init hyperv_iommu_swiotlb_later_init(void)
+{
+	/*
+	 * Swiotlb bounce buffer needs to be mapped in extra address
+	 * space. Map function doesn't work in the early place and so
+	 * call swiotlb_update_mem_attributes() here.
+	 */
+	swiotlb_update_mem_attributes();
+}
+
+IOMMU_INIT_FINISH(hyperv_swiotlb_detect,
+		  NULL, hyperv_iommu_swiotlb_init,
+		  hyperv_iommu_swiotlb_later_init);
 #endif
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index b823311eac79..1f037e114dc8 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1726,6 +1726,14 @@ int hyperv_write_cfg_blk(struct pci_dev *dev, void *buf, unsigned int len,
 int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context,
 				void (*block_invalidate)(void *context,
 							 u64 block_mask));
+#if IS_ENABLED(CONFIG_HYPERV)
+int __init hyperv_swiotlb_detect(void);
+#else
+static inline int __init hyperv_swiotlb_detect(void)
+{
+	return 0;
+}
+#endif
 
 struct hyperv_pci_block_ops {
 	int (*read_block)(struct pci_dev *dev, void *buf, unsigned int buf_len,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238265.412998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj2-0006dz-FV; Sun, 05 Dec 2021 08:18:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238265.412998; Sun, 05 Dec 2021 08:18:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj2-0006cV-8g; Sun, 05 Dec 2021 08:18:24 +0000
Received: by outflank-mailman (input) for mailman id 238265;
 Sun, 05 Dec 2021 08:18:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj1-0006TA-Jm
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:23 +0000
Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com
 [2607:f8b0:4864:20::52d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8c7b142-55a3-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 09:18:22 +0100 (CET)
Received: by mail-pg1-x52d.google.com with SMTP id l64so1868917pgl.9
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:22 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.20
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8c7b142-55a3-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4R1/x5dPl8v2bhM1Wqw8GMKwcXKdEyhlm+eRit5majU=;
        b=a199mwwb41SK+3g5nwV1xKmU5gwizT35AAVUi8EUk8s8aLOnPfOSMZ+DMLR46xQuuT
         MqpKzZctmq0YmBBHMP3tAH2eroIBBD8cjLj9PwaEnB2C+snyDUEO0j82lTDGHRmYP/Ig
         bOlyN98YpBfGN+bx8S2gYeEnhpOJjbcYfo8JrVl6Zu9l3rXzJxaFYHM8Fh6XecuDTX9k
         5k2jwAETpzg9EPf0K2t1k+SG8YOophQYDcE2OtnxPueV/d+iE6faWflgKeHhF2CU0RAD
         qzeN6hrSJXIMDWCljoYMoMo+3fsMt5kyd2hroMZAspPvmtkNm8//oYiJKnc/mtxPyMW4
         vQlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4R1/x5dPl8v2bhM1Wqw8GMKwcXKdEyhlm+eRit5majU=;
        b=GxsDgmhHcGdqVyr2Pzq+O2qHoo9qE3pXjtAV433DYH9ZQPn7t86PpTLOjLoUtpc4SZ
         UM9e5HU9Sa0x/eiWGGU8J+cvSOjamYZCgrKSzD99sRdiTs4I9HPv5V3aRApJzFGen99b
         Ihqc/uIURxnQqqB3Ac+Y0CifJFhRNDvF+a0HRKz2CN/3j8kH+ASMl/weDw0xMM5FC45b
         BOhesMhIZrRLwBClCjVY4tKjfj/TgC78E+ZJctWceKQ6+C21OAG0IKiQ7dD9kWKwaR9F
         0iWIkxPML/7rEvwS9xOVATvm4NTh9mThObYj1/iJOmbsHmKGtUEOOq6W03wmgRdfNo4n
         XfjA==
X-Gm-Message-State: AOAM531I0ClI/PAjivLNj/8b9ykEWZbJqSaLrEgxiJJk3/SN6dclOQcp
	Z8/YJrb5wXDcyEtG+TRJo9o=
X-Google-Smtp-Source: ABdhPJwjVr/PR4pWsnzxcrhE9ySNvBZumxc7tiGS3XuTHA+biQhguZE4c/ixNuJ3guQaZnB9mhHD+w==
X-Received: by 2002:a05:6a00:1741:b0:4ad:55e0:55b with SMTP id j1-20020a056a00174100b004ad55e0055bmr3973425pfc.58.1638692301062;
        Sun, 05 Dec 2021 00:18:21 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 2/5] x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has()
Date: Sun,  5 Dec 2021 03:18:10 -0500
Message-Id: <20211205081815.129276-3-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211205081815.129276-1-ltykernel@gmail.com>
References: <20211205081815.129276-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

Hyper-V provides Isolation VM which has memory encrypt support. Add
hyperv_cc_platform_has() and return true for check of GUEST_MEM_ENCRYPT
attribute.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v3:
	* Change code style of checking GUEST_MEM attribute in the
	  hyperv_cc_platform_has().
---
 arch/x86/kernel/cc_platform.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/x86/kernel/cc_platform.c b/arch/x86/kernel/cc_platform.c
index 03bb2f343ddb..27c06b32e7c4 100644
--- a/arch/x86/kernel/cc_platform.c
+++ b/arch/x86/kernel/cc_platform.c
@@ -11,6 +11,7 @@
 #include <linux/cc_platform.h>
 #include <linux/mem_encrypt.h>
 
+#include <asm/mshyperv.h>
 #include <asm/processor.h>
 
 static bool __maybe_unused intel_cc_platform_has(enum cc_attr attr)
@@ -58,9 +59,20 @@ static bool amd_cc_platform_has(enum cc_attr attr)
 #endif
 }
 
+static bool hyperv_cc_platform_has(enum cc_attr attr)
+{
+#ifdef CONFIG_HYPERV
+	return attr == CC_ATTR_GUEST_MEM_ENCRYPT;
+#else
+	return false;
+#endif
+}
 
 bool cc_platform_has(enum cc_attr attr)
 {
+	if (hv_is_isolation_supported())
+		return hyperv_cc_platform_has(attr);
+
 	if (sme_me_mask)
 		return amd_cc_platform_has(attr);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238267.413028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj6-0007WH-4b; Sun, 05 Dec 2021 08:18:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238267.413028; Sun, 05 Dec 2021 08:18:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj6-0007Vj-0l; Sun, 05 Dec 2021 08:18:28 +0000
Received: by outflank-mailman (input) for mailman id 238267;
 Sun, 05 Dec 2021 08:18:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj4-0006T9-1E
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:26 +0000
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com
 [2607:f8b0:4864:20::102a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ea5d6651-55a3-11ec-a5e1-b9374ead2679;
 Sun, 05 Dec 2021 09:18:25 +0100 (CET)
Received: by mail-pj1-x102a.google.com with SMTP id
 w33-20020a17090a6ba400b001a722a06212so7590564pjj.0
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:25 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:23 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea5d6651-55a3-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=brPB+isubduGZ0dFkchshqyMjV+4uHMaO2+7Xc0wGRk=;
        b=d+pRTiyTvRH5TOIdeq8tkDweJDBPZRanHXQhj0YflzD4Il2KCdLON3cC58pHDs8qX9
         OGEp/At7kf/f/+6HkyyKsAqzvAGnInBSq0i+DqkcYw3qOwJNcz5v/DdzlqrsWBz4dp3r
         ZrUePPnfHGvvxMJ8axGmVh/ZjNrM6QEcFVD5j49e0lYjjHlQN9RN9/AqEVHhOVaGGenW
         gtzqWAeiHKj1f/U/EfydqsGjRVi6DCB3x4MgQhKfD33v6xwaiSXh2e2GWM2D2iVnFMLP
         yQbMKY3jgpbGK4JwlKTX8SQfCFNQpLUcN96i5b7r6lFGqNBYGmwfN8dQSHd9Ipcb2/Mo
         U55A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=brPB+isubduGZ0dFkchshqyMjV+4uHMaO2+7Xc0wGRk=;
        b=Fn0em6kJvRkaE6LN+pQ5aUF81jgi95PI8i/5frhuh+ahYStfUsjZ0DLnNfKSa2D8m5
         IIzp3vQRt7/gN/FKh2MUIk94vjDVJWnNcjz3U/t4A/jJWMLow1bgaI7JXgwHM2w3co6D
         G6rtaPiohVf3AWUjUO2r84lC/VJqGazU+LF39JnSzoeIemy8cePnsoZ36cHVk7yJKdad
         Gf8i1x6AfL/F75l5FcKhe48O5JMvGxQrMGXNG64nJeZh3eA5TTY5CtsVxeR+QZ/9Dccu
         X06JMPrECQB6GwD2qtB5ua95UVYodxfwCixkixDpgbTzJrj4sR24+4yPNdi8fwL5Gv/d
         Jgow==
X-Gm-Message-State: AOAM531VelUd7+PbmkMnESHI7vbt40bKQ5hgBXUMUVz+X0p8PTWalBWP
	ndQJhFTM40uZjrJwfqM5biA=
X-Google-Smtp-Source: ABdhPJzWds7gw4/7Hsf56r+CojhqWW7GcWTPaWgp5Pi8SFfxCERK/Yp6qhd5zk9W3uMOhKEfc1n27g==
X-Received: by 2002:a17:90a:c287:: with SMTP id f7mr28508697pjt.114.1638692303692;
        Sun, 05 Dec 2021 00:18:23 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 4/5] scsi: storvsc: Add Isolation VM support for storvsc driver
Date: Sun,  5 Dec 2021 03:18:12 -0500
Message-Id: <20211205081815.129276-5-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211205081815.129276-1-ltykernel@gmail.com>
References: <20211205081815.129276-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM, all shared memory with host needs to mark visible
to host via hvcall. vmbus_establish_gpadl() has already done it for
storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_
mpb_desc() still needs to be handled. Use DMA API(scsi_dma_map/unmap)
to map these memory during sending/receiving packet and return swiotlb
bounce buffer dma address. In Isolation VM, swiotlb  bounce buffer is
marked to be visible to host and the swiotlb force mode is enabled.

Set device's dma min align mask to HV_HYP_PAGE_SIZE - 1 in order to
keep the original data offset in the bounce buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
 drivers/hv/vmbus_drv.c     |  1 +
 drivers/scsi/storvsc_drv.c | 37 +++++++++++++++++++++----------------
 include/linux/hyperv.h     |  1 +
 3 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 0a64ccfafb8b..ae6ec503399a 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -2121,6 +2121,7 @@ int vmbus_device_register(struct hv_device *child_device_obj)
 	hv_debug_add_dev_dir(child_device_obj);
 
 	child_device_obj->device.dma_mask = &vmbus_dma_mask;
+	child_device_obj->device.dma_parms = &child_device_obj->dma_parms;
 	return 0;
 
 err_kset_unregister:
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 20595c0ba0ae..ae293600d799 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -21,6 +21,8 @@
 #include <linux/device.h>
 #include <linux/hyperv.h>
 #include <linux/blkdev.h>
+#include <linux/dma-mapping.h>
+
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_host.h>
@@ -1336,6 +1338,7 @@ static void storvsc_on_channel_callback(void *context)
 					continue;
 				}
 				request = (struct storvsc_cmd_request *)scsi_cmd_priv(scmnd);
+				scsi_dma_unmap(scmnd);
 			}
 
 			storvsc_on_receive(stor_device, packet, request);
@@ -1749,7 +1752,6 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	struct hv_host_device *host_dev = shost_priv(host);
 	struct hv_device *dev = host_dev->dev;
 	struct storvsc_cmd_request *cmd_request = scsi_cmd_priv(scmnd);
-	int i;
 	struct scatterlist *sgl;
 	unsigned int sg_count;
 	struct vmscsi_request *vm_srb;
@@ -1831,10 +1833,11 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	payload_sz = sizeof(cmd_request->mpb);
 
 	if (sg_count) {
-		unsigned int hvpgoff, hvpfns_to_add;
 		unsigned long offset_in_hvpg = offset_in_hvpage(sgl->offset);
 		unsigned int hvpg_count = HVPFN_UP(offset_in_hvpg + length);
-		u64 hvpfn;
+		struct scatterlist *sg;
+		unsigned long hvpfn, hvpfns_to_add;
+		int j, i = 0;
 
 		if (hvpg_count > MAX_PAGE_BUFFER_COUNT) {
 
@@ -1848,21 +1851,22 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 		payload->range.len = length;
 		payload->range.offset = offset_in_hvpg;
 
+		sg_count = scsi_dma_map(scmnd);
+		if (sg_count < 0)
+			return SCSI_MLQUEUE_DEVICE_BUSY;
 
-		for (i = 0; sgl != NULL; sgl = sg_next(sgl)) {
+		for_each_sg(sgl, sg, sg_count, j) {
 			/*
-			 * Init values for the current sgl entry. hvpgoff
-			 * and hvpfns_to_add are in units of Hyper-V size
-			 * pages. Handling the PAGE_SIZE != HV_HYP_PAGE_SIZE
-			 * case also handles values of sgl->offset that are
-			 * larger than PAGE_SIZE. Such offsets are handled
-			 * even on other than the first sgl entry, provided
-			 * they are a multiple of PAGE_SIZE.
+			 * Init values for the current sgl entry. hvpfns_to_add
+			 * is in units of Hyper-V size pages. Handling the
+			 * PAGE_SIZE != HV_HYP_PAGE_SIZE case also handles
+			 * values of sgl->offset that are larger than PAGE_SIZE.
+			 * Such offsets are handled even on other than the first
+			 * sgl entry, provided they are a multiple of PAGE_SIZE.
 			 */
-			hvpgoff = HVPFN_DOWN(sgl->offset);
-			hvpfn = page_to_hvpfn(sg_page(sgl)) + hvpgoff;
-			hvpfns_to_add =	HVPFN_UP(sgl->offset + sgl->length) -
-						hvpgoff;
+			hvpfn = HVPFN_DOWN(sg_dma_address(sg));
+			hvpfns_to_add = HVPFN_UP(sg_dma_address(sg) +
+						 sg_dma_len(sg)) - hvpfn;
 
 			/*
 			 * Fill the next portion of the PFN array with
@@ -1872,7 +1876,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 			 * the PFN array is filled.
 			 */
 			while (hvpfns_to_add--)
-				payload->range.pfn_array[i++] =	hvpfn++;
+				payload->range.pfn_array[i++] = hvpfn++;
 		}
 	}
 
@@ -2016,6 +2020,7 @@ static int storvsc_probe(struct hv_device *device,
 	stor_device->vmscsi_size_delta = sizeof(struct vmscsi_win8_extension);
 	spin_lock_init(&stor_device->lock);
 	hv_set_drvdata(device, stor_device);
+	dma_set_min_align_mask(&device->device, HV_HYP_PAGE_SIZE - 1);
 
 	stor_device->port_number = host->host_no;
 	ret = storvsc_connect_to_vsp(device, storvsc_ringbuffer_size, is_fc);
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 1f037e114dc8..74f5e92f91a0 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1261,6 +1261,7 @@ struct hv_device {
 
 	struct vmbus_channel *channel;
 	struct kset	     *channels_kset;
+	struct device_dma_parameters dma_parms;
 
 	/* place holder to keep track of the dir for hv device in debugfs */
 	struct dentry *debug_dir;
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238268.413040 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj7-0007oo-JN; Sun, 05 Dec 2021 08:18:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238268.413040; Sun, 05 Dec 2021 08:18:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj7-0007np-DJ; Sun, 05 Dec 2021 08:18:29 +0000
Received: by outflank-mailman (input) for mailman id 238268;
 Sun, 05 Dec 2021 08:18:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj5-0006T9-Jk
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:27 +0000
Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com
 [2607:f8b0:4864:20::530])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb385bbb-55a3-11ec-a5e1-b9374ead2679;
 Sun, 05 Dec 2021 09:18:26 +0100 (CET)
Received: by mail-pg1-x530.google.com with SMTP id k4so7393590pgb.8
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:26 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:24 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb385bbb-55a3-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=1g0RnzssZkBnBKymEz0YZXD32oRDdHA8PZSX43vBfcQ=;
        b=GLV5SN0aM1zX+npMBCV8ehIn8sPfIInvB3Ok1Q4s5tUiQaAawCS8qK3tyqYp4kzUH5
         5M+CDcEFe/xznZhgI6svYBO7tH1vy2jUjd0iDZAslp8luBrXA4gwa4dv62TXBbjsL7vU
         wtuuFui9z2YcQ2TZW5S66WgyU7CFrMAAvJrs0pjOjOwGlzLTdMAk2UMnlIo5wl2UHp44
         ABgxN2MdvrXhMQXihZYqv5SV/KRdJcQwPPAviTcO9YhrXmi+FzfdEW9Buo+LhuQKqR/l
         D2TGTok8m6RystIaIp4W9W7MTsZ2tg/WrRu/nvb0xaRoRMRIo2qahZ5P0NT/wzY8ANCE
         XmMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=1g0RnzssZkBnBKymEz0YZXD32oRDdHA8PZSX43vBfcQ=;
        b=phfPtu8wPIKCktiVxaPTvWFCLgfY0oNSuAN7PDvVwx3KMWilEcOumEdL3opVIyLmS2
         KC40UbSW5AYe/26v3Tu2toMEKZw4d0otnrU2WvyNJEfnBWN/4Tgr5YKt2n32THB4dXfz
         hluUdE2NMtAvTF3uQZIYZ18daj9FqUhEdM9wwfaWZTMU+clvIcg6tN4+r4qw0xTrT1zS
         2NXeuQYHPdQp8BH5JD6I1tupsL7QRy2WPajsZPtiOgLgNrfztqY2iQL/OcbD0p9veSJc
         18bRn5OrvfIE58dHvnH6c8cdvyJj3IXWZ9x+ICxjtQWgtLcnBEloV8UL4ugayLwke5i4
         +A3g==
X-Gm-Message-State: AOAM532MelV6qnU9xLhdxdoV/VnRx9hHWj3VOPeYHLiXFByx03tsZGUw
	oCBukMkHZ0+PMbEo53XngZA=
X-Google-Smtp-Source: ABdhPJzmsHani2koAEhC+FclZq201HIttbqR1IpHXAGPX5Onn+eERvWMeBnYUf+pPYE3TO/rGmUFsA==
X-Received: by 2002:a62:8042:0:b0:4a8:15eb:db10 with SMTP id j63-20020a628042000000b004a815ebdb10mr29233467pfd.28.1638692305084;
        Sun, 05 Dec 2021 00:18:25 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 5/5] hv_netvsc: Add Isolation VM support for netvsc driver
Date: Sun,  5 Dec 2021 03:18:13 -0500
Message-Id: <20211205081815.129276-6-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211205081815.129276-1-ltykernel@gmail.com>
References: <20211205081815.129276-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM, all shared memory with host needs to mark visible
to host via hvcall. vmbus_establish_gpadl() has already done it for
netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_
pagebuffer() stills need to be handled. Use DMA API to map/umap
these memory during sending/receiving packet and Hyper-V swiotlb
bounce buffer dma address will be returned. The swiotlb bounce buffer
has been masked to be visible to host during boot up.

rx/tx ring buffer is allocated via vzalloc() and they need to be
mapped into unencrypted address space(above vTOM) before sharing
with host and accessing. Add hv_map/unmap_memory() to map/umap rx
/tx ring buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v3:
       * Replace HV_HYP_PAGE_SIZE with PAGE_SIZE and virt_to_hvpfn()
         with vmalloc_to_pfn() in the hv_map_memory()

Change since v2:
       * Add hv_map/unmap_memory() to map/umap rx/tx ring buffer.
---
 arch/x86/hyperv/ivm.c             |  28 ++++++
 drivers/hv/hv_common.c            |  11 +++
 drivers/net/hyperv/hyperv_net.h   |   5 ++
 drivers/net/hyperv/netvsc.c       | 136 +++++++++++++++++++++++++++++-
 drivers/net/hyperv/netvsc_drv.c   |   1 +
 drivers/net/hyperv/rndis_filter.c |   2 +
 include/asm-generic/mshyperv.h    |   2 +
 include/linux/hyperv.h            |   5 ++
 8 files changed, 187 insertions(+), 3 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 69c7a57f3307..2b994117581e 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -287,3 +287,31 @@ int hv_set_mem_host_visibility(unsigned long kbuffer, int pagecount, bool visibl
 	kfree(pfn_array);
 	return ret;
 }
+
+/*
+ * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolation VM.
+ */
+void *hv_map_memory(void *addr, unsigned long size)
+{
+	unsigned long *pfns = kcalloc(size / PAGE_SIZE,
+				      sizeof(unsigned long), GFP_KERNEL);
+	void *vaddr;
+	int i;
+
+	if (!pfns)
+		return NULL;
+
+	for (i = 0; i < size / PAGE_SIZE; i++)
+		pfns[i] = vmalloc_to_pfn(addr + i * PAGE_SIZE) +
+			(ms_hyperv.shared_gpa_boundary >> PAGE_SHIFT);
+
+	vaddr = vmap_pfn(pfns, size / PAGE_SIZE, PAGE_KERNEL_IO);
+	kfree(pfns);
+
+	return vaddr;
+}
+
+void hv_unmap_memory(void *addr)
+{
+	vunmap(addr);
+}
diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index 7be173a99f27..3c5cb1f70319 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -295,3 +295,14 @@ u64 __weak hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_s
 	return HV_STATUS_INVALID_PARAMETER;
 }
 EXPORT_SYMBOL_GPL(hv_ghcb_hypercall);
+
+void __weak *hv_map_memory(void *addr, unsigned long size)
+{
+	return NULL;
+}
+EXPORT_SYMBOL_GPL(hv_map_memory);
+
+void __weak hv_unmap_memory(void *addr)
+{
+}
+EXPORT_SYMBOL_GPL(hv_unmap_memory);
diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 315278a7cf88..cf69da0e296c 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -164,6 +164,7 @@ struct hv_netvsc_packet {
 	u32 total_bytes;
 	u32 send_buf_index;
 	u32 total_data_buflen;
+	struct hv_dma_range *dma_range;
 };
 
 #define NETVSC_HASH_KEYLEN 40
@@ -1074,6 +1075,7 @@ struct netvsc_device {
 
 	/* Receive buffer allocated by us but manages by NetVSP */
 	void *recv_buf;
+	void *recv_original_buf;
 	u32 recv_buf_size; /* allocated bytes */
 	struct vmbus_gpadl recv_buf_gpadl_handle;
 	u32 recv_section_cnt;
@@ -1082,6 +1084,7 @@ struct netvsc_device {
 
 	/* Send buffer allocated by us */
 	void *send_buf;
+	void *send_original_buf;
 	u32 send_buf_size;
 	struct vmbus_gpadl send_buf_gpadl_handle;
 	u32 send_section_cnt;
@@ -1731,4 +1734,6 @@ struct rndis_message {
 #define RETRY_US_HI	10000
 #define RETRY_MAX	2000	/* >10 sec */
 
+void netvsc_dma_unmap(struct hv_device *hv_dev,
+		      struct hv_netvsc_packet *packet);
 #endif /* _HYPERV_NET_H */
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 396bc1c204e6..b7ade735a806 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -153,8 +153,21 @@ static void free_netvsc_device(struct rcu_head *head)
 	int i;
 
 	kfree(nvdev->extension);
-	vfree(nvdev->recv_buf);
-	vfree(nvdev->send_buf);
+
+	if (nvdev->recv_original_buf) {
+		hv_unmap_memory(nvdev->recv_buf);
+		vfree(nvdev->recv_original_buf);
+	} else {
+		vfree(nvdev->recv_buf);
+	}
+
+	if (nvdev->send_original_buf) {
+		hv_unmap_memory(nvdev->send_buf);
+		vfree(nvdev->send_original_buf);
+	} else {
+		vfree(nvdev->send_buf);
+	}
+
 	kfree(nvdev->send_section_map);
 
 	for (i = 0; i < VRSS_CHANNEL_MAX; i++) {
@@ -338,6 +351,7 @@ static int netvsc_init_buf(struct hv_device *device,
 	unsigned int buf_size;
 	size_t map_words;
 	int i, ret = 0;
+	void *vaddr;
 
 	/* Get receive buffer area. */
 	buf_size = device_info->recv_sections * device_info->recv_section_size;
@@ -373,6 +387,17 @@ static int netvsc_init_buf(struct hv_device *device,
 		goto cleanup;
 	}
 
+	if (hv_isolation_type_snp()) {
+		vaddr = hv_map_memory(net_device->recv_buf, buf_size);
+		if (!vaddr) {
+			ret = -ENOMEM;
+			goto cleanup;
+		}
+
+		net_device->recv_original_buf = net_device->recv_buf;
+		net_device->recv_buf = vaddr;
+	}
+
 	/* Notify the NetVsp of the gpadl handle */
 	init_packet = &net_device->channel_init_pkt;
 	memset(init_packet, 0, sizeof(struct nvsp_message));
@@ -476,6 +501,17 @@ static int netvsc_init_buf(struct hv_device *device,
 		goto cleanup;
 	}
 
+	if (hv_isolation_type_snp()) {
+		vaddr = hv_map_memory(net_device->send_buf, buf_size);
+		if (!vaddr) {
+			ret = -ENOMEM;
+			goto cleanup;
+		}
+
+		net_device->send_original_buf = net_device->send_buf;
+		net_device->send_buf = vaddr;
+	}
+
 	/* Notify the NetVsp of the gpadl handle */
 	init_packet = &net_device->channel_init_pkt;
 	memset(init_packet, 0, sizeof(struct nvsp_message));
@@ -766,7 +802,7 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
 
 	/* Notify the layer above us */
 	if (likely(skb)) {
-		const struct hv_netvsc_packet *packet
+		struct hv_netvsc_packet *packet
 			= (struct hv_netvsc_packet *)skb->cb;
 		u32 send_index = packet->send_buf_index;
 		struct netvsc_stats *tx_stats;
@@ -782,6 +818,7 @@ static void netvsc_send_tx_complete(struct net_device *ndev,
 		tx_stats->bytes += packet->total_bytes;
 		u64_stats_update_end(&tx_stats->syncp);
 
+		netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
 		napi_consume_skb(skb, budget);
 	}
 
@@ -946,6 +983,88 @@ static void netvsc_copy_to_send_buf(struct netvsc_device *net_device,
 		memset(dest, 0, padding);
 }
 
+void netvsc_dma_unmap(struct hv_device *hv_dev,
+		      struct hv_netvsc_packet *packet)
+{
+	u32 page_count = packet->cp_partial ?
+		packet->page_buf_cnt - packet->rmsg_pgcnt :
+		packet->page_buf_cnt;
+	int i;
+
+	if (!hv_is_isolation_supported())
+		return;
+
+	if (!packet->dma_range)
+		return;
+
+	for (i = 0; i < page_count; i++)
+		dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma,
+				 packet->dma_range[i].mapping_size,
+				 DMA_TO_DEVICE);
+
+	kfree(packet->dma_range);
+}
+
+/* netvsc_dma_map - Map swiotlb bounce buffer with data page of
+ * packet sent by vmbus_sendpacket_pagebuffer() in the Isolation
+ * VM.
+ *
+ * In isolation VM, netvsc send buffer has been marked visible to
+ * host and so the data copied to send buffer doesn't need to use
+ * bounce buffer. The data pages handled by vmbus_sendpacket_pagebuffer()
+ * may not be copied to send buffer and so these pages need to be
+ * mapped with swiotlb bounce buffer. netvsc_dma_map() is to do
+ * that. The pfns in the struct hv_page_buffer need to be converted
+ * to bounce buffer's pfn. The loop here is necessary because the
+ * entries in the page buffer array are not necessarily full
+ * pages of data.  Each entry in the array has a separate offset and
+ * len that may be non-zero, even for entries in the middle of the
+ * array.  And the entries are not physically contiguous.  So each
+ * entry must be individually mapped rather than as a contiguous unit.
+ * So not use dma_map_sg() here.
+ */
+int netvsc_dma_map(struct hv_device *hv_dev,
+		   struct hv_netvsc_packet *packet,
+		   struct hv_page_buffer *pb)
+{
+	u32 page_count =  packet->cp_partial ?
+		packet->page_buf_cnt - packet->rmsg_pgcnt :
+		packet->page_buf_cnt;
+	dma_addr_t dma;
+	int i;
+
+	if (!hv_is_isolation_supported())
+		return 0;
+
+	packet->dma_range = kcalloc(page_count,
+				    sizeof(*packet->dma_range),
+				    GFP_KERNEL);
+	if (!packet->dma_range)
+		return -ENOMEM;
+
+	for (i = 0; i < page_count; i++) {
+		char *src = phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT)
+					 + pb[i].offset);
+		u32 len = pb[i].len;
+
+		dma = dma_map_single(&hv_dev->device, src, len,
+				     DMA_TO_DEVICE);
+		if (dma_mapping_error(&hv_dev->device, dma)) {
+			kfree(packet->dma_range);
+			return -ENOMEM;
+		}
+
+		/* pb[].offset and pb[].len are not changed during dma mapping
+		 * and so not reassign.
+		 */
+		packet->dma_range[i].dma = dma;
+		packet->dma_range[i].mapping_size = len;
+		pb[i].pfn = dma >> HV_HYP_PAGE_SHIFT;
+	}
+
+	return 0;
+}
+
 static inline int netvsc_send_pkt(
 	struct hv_device *device,
 	struct hv_netvsc_packet *packet,
@@ -986,14 +1105,24 @@ static inline int netvsc_send_pkt(
 
 	trace_nvsp_send_pkt(ndev, out_channel, rpkt);
 
+	packet->dma_range = NULL;
 	if (packet->page_buf_cnt) {
 		if (packet->cp_partial)
 			pb += packet->rmsg_pgcnt;
 
+		ret = netvsc_dma_map(ndev_ctx->device_ctx, packet, pb);
+		if (ret) {
+			ret = -EAGAIN;
+			goto exit;
+		}
+
 		ret = vmbus_sendpacket_pagebuffer(out_channel,
 						  pb, packet->page_buf_cnt,
 						  &nvmsg, sizeof(nvmsg),
 						  req_id);
+
+		if (ret)
+			netvsc_dma_unmap(ndev_ctx->device_ctx, packet);
 	} else {
 		ret = vmbus_sendpacket(out_channel,
 				       &nvmsg, sizeof(nvmsg),
@@ -1001,6 +1130,7 @@ static inline int netvsc_send_pkt(
 				       VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
 	}
 
+exit:
 	if (ret == 0) {
 		atomic_inc_return(&nvchan->queue_sends);
 
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 7e66ae1d2a59..17958533bf30 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -2512,6 +2512,7 @@ static int netvsc_probe(struct hv_device *dev,
 	net->netdev_ops = &device_ops;
 	net->ethtool_ops = &ethtool_ops;
 	SET_NETDEV_DEV(net, &dev->device);
+	dma_set_min_align_mask(&dev->device, HV_HYP_PAGE_SIZE - 1);
 
 	/* We always need headroom for rndis header */
 	net->needed_headroom = RNDIS_AND_PPI_SIZE;
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index f6c9c2a670f9..448fcc325ed7 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -361,6 +361,8 @@ static void rndis_filter_receive_response(struct net_device *ndev,
 			}
 		}
 
+		netvsc_dma_unmap(((struct net_device_context *)
+			netdev_priv(ndev))->device_ctx, &request->pkt);
 		complete(&request->wait_event);
 	} else {
 		netdev_err(ndev,
diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
index 3e2248ac328e..94e73ba129c5 100644
--- a/include/asm-generic/mshyperv.h
+++ b/include/asm-generic/mshyperv.h
@@ -269,6 +269,8 @@ bool hv_isolation_type_snp(void);
 u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_size);
 void hyperv_cleanup(void);
 bool hv_query_ext_cap(u64 cap_query);
+void *hv_map_memory(void *addr, unsigned long size);
+void hv_unmap_memory(void *addr);
 #else /* CONFIG_HYPERV */
 static inline bool hv_is_hyperv_initialized(void) { return false; }
 static inline bool hv_is_hibernation_supported(void) { return false; }
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 74f5e92f91a0..b53cfc4163af 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1584,6 +1584,11 @@ struct hyperv_service_callback {
 	void (*callback)(void *context);
 };
 
+struct hv_dma_range {
+	dma_addr_t dma;
+	u32 mapping_size;
+};
+
 #define MAX_SRV_VER	0x7ffffff
 extern bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp, u8 *buf, u32 buflen,
 				const int *fw_version, int fw_vercnt,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238264.412990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj2-0006X2-41; Sun, 05 Dec 2021 08:18:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238264.412990; Sun, 05 Dec 2021 08:18:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmj1-0006Wj-VH; Sun, 05 Dec 2021 08:18:23 +0000
Received: by outflank-mailman (input) for mailman id 238264;
 Sun, 05 Dec 2021 08:18:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtmj1-0006TA-2Q
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:18:23 +0000
Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com
 [2607:f8b0:4864:20::62a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e80c604f-55a3-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 09:18:21 +0100 (CET)
Received: by mail-pl1-x62a.google.com with SMTP id p18so5009251plf.13
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:18:21 -0800 (PST)
Received: from ubuntu-Virtual-Machine.corp.microsoft.com
 ([2001:4898:80e8:7:87aa:e334:f070:ebca])
 by smtp.gmail.com with ESMTPSA id s8sm6439905pgl.77.2021.12.05.00.18.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 05 Dec 2021 00:18:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e80c604f-55a3-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=cx8DmDucAVd/dOxMJIWoV1500es0laNWH4pwuIs0A1I=;
        b=J9unkTMUHekG+nABUZyTJ0X6rMpuoJDQCrzyx8KcNnCmhLA9uf7j+JFT8N8nBXx1I3
         bPMxAe29BAcVjyDyUiex3xQtEDYRVZvtkgiLG5XywwOAdzEe6jOtQNlb5aYzkGoXQVcc
         WCgb2HNGKw6hZ3CYJ3s4I254Nmy777zDKyjc+ihnoRF9RnoWxtCAo0ABZ2UdyYtrpoR7
         imgQlRsfiX8tucfrcxXByhFEhwr4Tn+l9WlB3BXfnPRKJxivf+4D9LmBRTNlkBT5hKaU
         ZcMe91ws2Pkx3hJNuPzCWWAk+wpQzKKSR3DmIpZme3+OawdRrr+VnqykrehE/QugktXj
         Fpnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=cx8DmDucAVd/dOxMJIWoV1500es0laNWH4pwuIs0A1I=;
        b=AjYBYVyHJpom8xuikdBcDjX9YqSllMX6bDNSiIonB9WzD4vcWHZ7QQOa1ZGRjOsGBm
         mATX/s/RswysaqSfX6jeXmWqlV57ALVnHnFgdhuC66GzMokWYjJZSd8Nz8mGfZ+HoL//
         xZhaVYaYtyWH20SJAINvWJV18VaTO+Gd2GtgpQy/hXupU6n/K2BP+U6RJra08kbQTG+/
         OyE2UyzSXLt7tKT1kt15sKIDPgXRNRG2LXJ5i04g1fwyzYDYuF3IihvEn9TupyQO8C4C
         2Oae2FjVAuT1vw+lTfFxcr8NM0BhRf9TWKZtcXMxAYPVqK2WoCWnM38T692q6S+n7+Vc
         dmcQ==
X-Gm-Message-State: AOAM531yTgxhqlqz3Idv5oEvtWum3qsDYu6j8Jx6WP0qRnu3UWWA4ZLE
	W/kSxJAnVJheIZhoABGqsd4=
X-Google-Smtp-Source: ABdhPJw0sC++Y7ylQvcvWJ3gyPwvm3vBrUAwZo7z4zD8IOAhoofY0ZRb4CSQlUCNF7xqVz6XNKnpgQ==
X-Received: by 2002:a17:903:408c:b0:142:45a9:672c with SMTP id z12-20020a170903408c00b0014245a9672cmr35466353plc.7.1638692299698;
        Sun, 05 Dec 2021 00:18:19 -0800 (PST)
From: Tianyu Lan <ltykernel@gmail.com>
To: kys@microsoft.com,
	haiyangz@microsoft.com,
	sthemmin@microsoft.com,
	wei.liu@kernel.org,
	decui@microsoft.com,
	tglx@linutronix.de,
	mingo@redhat.com,
	bp@alien8.de,
	dave.hansen@linux.intel.com,
	x86@kernel.org,
	hpa@zytor.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	boris.ostrovsky@oracle.com,
	joro@8bytes.org,
	will@kernel.org,
	davem@davemloft.net,
	kuba@kernel.org,
	jejb@linux.ibm.com,
	martin.petersen@oracle.com,
	arnd@arndb.de,
	hch@infradead.org,
	m.szyprowski@samsung.com,
	robin.murphy@arm.com,
	thomas.lendacky@amd.com,
	Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org,
	michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org,
	linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	netdev@vger.kernel.org,
	vkuznets@redhat.com,
	brijesh.singh@amd.com,
	konrad.wilk@oracle.com,
	hch@lst.de,
	parri.andrea@gmail.com,
	dave.hansen@intel.com
Subject: [PATCH V4 1/5] Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM
Date: Sun,  5 Dec 2021 03:18:09 -0500
Message-Id: <20211205081815.129276-2-ltykernel@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211205081815.129276-1-ltykernel@gmail.com>
References: <20211205081815.129276-1-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Tianyu Lan <Tianyu.Lan@microsoft.com>

In Isolation VM with AMD SEV, bounce buffer needs to be accessed via
extra address space which is above shared_gpa_boundary (E.G 39 bit
address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access
physical address will be original physical address + shared_gpa_boundary.
The shared_gpa_boundary in the AMD SEV SNP spec is called virtual top of
memory(vTOM). Memory addresses below vTOM are automatically treated as
private while memory above vTOM is treated as shared.

Expose swiotlb_unencrypted_base for platforms to set unencrypted
memory base offset and platform calls swiotlb_update_mem_attributes()
to remap swiotlb mem to unencrypted address space. memremap() can
not be called in the early stage and so put remapping code into
swiotlb_update_mem_attributes(). Store remap address and use it to copy
data from/to swiotlb bounce buffer.

Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
---
Change since v3:
	* Fix boot up failure on the host with mem_encrypt=on.
	  Move calloing of set_memory_decrypted() back from
	  swiotlb_init_io_tlb_mem to swiotlb_late_init_with_tbl()
	  and rmem_swiotlb_device_init().

Change since v2:
	* Leave mem->vaddr with phys_to_virt(mem->start) when fail
	  to remap swiotlb memory.

Change since v1:
	* Rework comment in the swiotlb_init_io_tlb_mem()
	* Make swiotlb_init_io_tlb_mem() back to return void.
---
 include/linux/swiotlb.h |  6 ++++++
 kernel/dma/swiotlb.c    | 43 +++++++++++++++++++++++++++++++++++++++--
 2 files changed, 47 insertions(+), 2 deletions(-)

diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 569272871375..f6c3638255d5 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -73,6 +73,9 @@ extern enum swiotlb_force swiotlb_force;
  * @end:	The end address of the swiotlb memory pool. Used to do a quick
  *		range check to see if the memory was in fact allocated by this
  *		API.
+ * @vaddr:	The vaddr of the swiotlb memory pool. The swiotlb memory pool
+ *		may be remapped in the memory encrypted case and store virtual
+ *		address for bounce buffer operation.
  * @nslabs:	The number of IO TLB blocks (in groups of 64) between @start and
  *		@end. For default swiotlb, this is command line adjustable via
  *		setup_io_tlb_npages.
@@ -92,6 +95,7 @@ extern enum swiotlb_force swiotlb_force;
 struct io_tlb_mem {
 	phys_addr_t start;
 	phys_addr_t end;
+	void *vaddr;
 	unsigned long nslabs;
 	unsigned long used;
 	unsigned int index;
@@ -186,4 +190,6 @@ static inline bool is_swiotlb_for_alloc(struct device *dev)
 }
 #endif /* CONFIG_DMA_RESTRICTED_POOL */
 
+extern phys_addr_t swiotlb_unencrypted_base;
+
 #endif /* __LINUX_SWIOTLB_H */
diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index 8e840fbbed7c..34e6ade4f73c 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -50,6 +50,7 @@
 #include <asm/io.h>
 #include <asm/dma.h>
 
+#include <linux/io.h>
 #include <linux/init.h>
 #include <linux/memblock.h>
 #include <linux/iommu-helper.h>
@@ -72,6 +73,8 @@ enum swiotlb_force swiotlb_force;
 
 struct io_tlb_mem io_tlb_default_mem;
 
+phys_addr_t swiotlb_unencrypted_base;
+
 /*
  * Max segment that we can provide which (if pages are contingous) will
  * not be bounced (unless SWIOTLB_FORCE is set).
@@ -155,6 +158,27 @@ static inline unsigned long nr_slots(u64 val)
 	return DIV_ROUND_UP(val, IO_TLB_SIZE);
 }
 
+/*
+ * Remap swioltb memory in the unencrypted physical address space
+ * when swiotlb_unencrypted_base is set. (e.g. for Hyper-V AMD SEV-SNP
+ * Isolation VMs).
+ */
+void *swiotlb_mem_remap(struct io_tlb_mem *mem, unsigned long bytes)
+{
+	void *vaddr = NULL;
+
+	if (swiotlb_unencrypted_base) {
+		phys_addr_t paddr = mem->start + swiotlb_unencrypted_base;
+
+		vaddr = memremap(paddr, bytes, MEMREMAP_WB);
+		if (!vaddr)
+			pr_err("Failed to map the unencrypted memory %llx size %lx.\n",
+			       paddr, bytes);
+	}
+
+	return vaddr;
+}
+
 /*
  * Early SWIOTLB allocation may be too early to allow an architecture to
  * perform the desired operations.  This function allows the architecture to
@@ -172,7 +196,12 @@ void __init swiotlb_update_mem_attributes(void)
 	vaddr = phys_to_virt(mem->start);
 	bytes = PAGE_ALIGN(mem->nslabs << IO_TLB_SHIFT);
 	set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
-	memset(vaddr, 0, bytes);
+
+	mem->vaddr = swiotlb_mem_remap(mem, bytes);
+	if (!mem->vaddr)
+		mem->vaddr = vaddr;
+
+	memset(mem->vaddr, 0, bytes);
 }
 
 static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
@@ -196,7 +225,17 @@ static void swiotlb_init_io_tlb_mem(struct io_tlb_mem *mem, phys_addr_t start,
 		mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
 		mem->slots[i].alloc_size = 0;
 	}
+
+	/*
+	 * If swiotlb_unencrypted_base is set, the bounce buffer memory will
+	 * be remapped and cleared in swiotlb_update_mem_attributes.
+	 */
+	if (swiotlb_unencrypted_base)
+		return;
+
 	memset(vaddr, 0, bytes);
+	mem->vaddr = vaddr;
+	return;
 }
 
 int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
@@ -371,7 +410,7 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
 	phys_addr_t orig_addr = mem->slots[index].orig_addr;
 	size_t alloc_size = mem->slots[index].alloc_size;
 	unsigned long pfn = PFN_DOWN(orig_addr);
-	unsigned char *vaddr = phys_to_virt(tlb_addr);
+	unsigned char *vaddr = mem->vaddr + tlb_addr - mem->start;
 	unsigned int tlb_offset, orig_addr_offset;
 
 	if (orig_addr == INVALID_PHYS_ADDR)
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:34:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:34:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238297.413050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmyn-0003Xf-5V; Sun, 05 Dec 2021 08:34:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238297.413050; Sun, 05 Dec 2021 08:34:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtmyn-0003XY-2O; Sun, 05 Dec 2021 08:34:41 +0000
Received: by outflank-mailman (input) for mailman id 238297;
 Sun, 05 Dec 2021 08:34:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LI7m=QW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mtmyl-0003XS-F1
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:34:39 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ec7f18b-55a6-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 09:34:38 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5930C1FDF1;
 Sun,  5 Dec 2021 08:34:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 20BC2139DB;
 Sun,  5 Dec 2021 08:34:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uegnBpt5rGE3MgAAMHmgww
 (envelope-from <jgross@suse.com>); Sun, 05 Dec 2021 08:34:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ec7f18b-55a6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638693277; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KEMzzd75tVTlzS/yF7YeuRBeMsa+nqRCS/y7F4rsJUM=;
	b=ZLDXNQcz0VwuP3iA6JpzBV1gBxlRehA5Wyhl2CSlKPFR1mCFjFd2xh0TRBhxdrPWFDPK+r
	jIrLD+0SrXq7gF3b/YUziPl9vPuZJBqYF+yBkXnXPZvfp00fCHkbcRiZON0I2rw6ozmQK0
	+Xswh5pD67z5fMmvDGEM3E0Z6vs+wj0=
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Message-ID: <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
Date: Sun, 5 Dec 2021 09:34:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211205081815.129276-4-ltykernel@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="ugcej3gKaigLQ3omKQ5Ra0cQpqisQwDQs"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ugcej3gKaigLQ3omKQ5Ra0cQpqisQwDQs
Content-Type: multipart/mixed; boundary="y3W2WyKJKK59IlhYplQoWEexoVy2cBgl7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
Message-ID: <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
In-Reply-To: <20211205081815.129276-4-ltykernel@gmail.com>

--y3W2WyKJKK59IlhYplQoWEexoVy2cBgl7
Content-Type: multipart/mixed;
 boundary="------------701B30531DDB67673841A1BC"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------701B30531DDB67673841A1BC
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 05.12.21 09:18, Tianyu Lan wrote:
> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>=20
> hyperv Isolation VM requires bounce buffer support to copy
> data from/to encrypted memory and so enable swiotlb force
> mode to use swiotlb bounce buffer for DMA transaction.
>=20
> In Isolation VM with AMD SEV, the bounce buffer needs to be
> accessed via extra address space which is above shared_gpa_boundary
> (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
> The access physical address will be original physical address +
> shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
> spec is called virtual top of memory(vTOM). Memory addresses below
> vTOM are automatically treated as private while memory above
> vTOM is treated as shared.
>=20
> Hyper-V initalizes swiotlb bounce buffer and default swiotlb
> needs to be disabled. pci_swiotlb_detect_override() and
> pci_swiotlb_detect_4gb() enable the default one. To override
> the setting, hyperv_swiotlb_detect() needs to run before
> these detect functions which depends on the pci_xen_swiotlb_
> init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
> _detect() to keep the order.

Why? Does Hyper-V plan to support Xen PV guests? If not, I don't see
the need for adding this change.


Juergen

--------------701B30531DDB67673841A1BC
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------701B30531DDB67673841A1BC--

--y3W2WyKJKK59IlhYplQoWEexoVy2cBgl7--

--ugcej3gKaigLQ3omKQ5Ra0cQpqisQwDQs
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGseZoFAwAAAAAACgkQsN6d1ii/Ey/H
vwf/bVcz0h71VPNyyHBiTM8U3L7spNMl6dKPxsu7MuBqatDouQsTGFEgVSpMK/UQkfzHwBmHRQJd
+0LM3/Ya8/G2v5VFKzS15AtUOgzzm73xoO8knoPHpkidw4ZKF5WFzn4UuYrGqluWauMlXb3sZuo1
0uMhZlqxfUG5RbOb38dR+Lv0aCsadCC23K0zT29bcDjgkqg8Y/U4BZddMujvXozlfh2rIwTdpXUZ
/iPXhL+SBnPI/xmmHRWI41yY/7/F3ClHmdV4d6dmxpneaI9jr56IWkSKzxSaIvhPpdsqr0ikywSI
fxV566qv5mppOytgoA3tf5wQhplYQ6bga7F/7+VXrw==
=3cnJ
-----END PGP SIGNATURE-----

--ugcej3gKaigLQ3omKQ5Ra0cQpqisQwDQs--


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 08:48:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 08:48:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238308.413068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtnCK-0005Si-Fa; Sun, 05 Dec 2021 08:48:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238308.413068; Sun, 05 Dec 2021 08:48:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtnCK-0005Sb-Ca; Sun, 05 Dec 2021 08:48:40 +0000
Received: by outflank-mailman (input) for mailman id 238308;
 Sun, 05 Dec 2021 08:48:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p5+j=QW=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1mtnCJ-0005SV-Po
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 08:48:39 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 233ad047-55a8-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 09:48:38 +0100 (CET)
Received: by mail-pj1-x1029.google.com with SMTP id
 p18-20020a17090ad31200b001a78bb52876so8466426pju.3
 for <xen-devel@lists.xenproject.org>; Sun, 05 Dec 2021 00:48:38 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b])
 by smtp.gmail.com with ESMTPSA id
 m10sm6512901pgv.75.2021.12.05.00.48.26
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 05 Dec 2021 00:48:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 233ad047-55a8-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=8ElIWeK3HZUhVw6Ru2fZxbGUFywB7lrb6pvwqCD90RQ=;
        b=bhv+ck/2NjW3XdA5BdRJjrWjIx7SyB0AZD+SN7/uKgD3cNgz6NnwAapRCo31zVSjzb
         NgZfsJ9/WQJJVn0VQnfOvhjrrQOUzDrWIZM6PBt02DsFfzOz0P0ty/E37M6lr8XytZ8A
         GgSWqw3N3Wxkk4kEV7dVoFtJ/fMVjrGspM0eMj7D7dAa6oC4rMqhk2Wmz428zuCyQ5ZD
         c+miU2npH6exTC0s6kc0N84Ux0N5mF2cpbZBZ2fD2HS6+BdfQnTvvbKBTj/M+EhVg9eP
         ySsd7Y2jJxO1lk6Nu30PxbFhUxeOGHSf8UIIB9fVS7RViOaS3EpL1I+yAKQTnYjJJO58
         teFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=8ElIWeK3HZUhVw6Ru2fZxbGUFywB7lrb6pvwqCD90RQ=;
        b=1XEE6hJcszFxNYh9sWpibIGHYfIQWUXQj1OkLq2R+H+ZHZ0Ahu3nm7JKIcKKCXBbC2
         EL8rXarN2YjD5p/blbTyqhJlQN09/REMftE7r60yzTkmwYRDhAMccSLiDwVyrZzXiLnM
         uVfMXVaj1TrgX3OYqU3esL2UOWT5BdmKWSj3CeCK1G+LjsCFeWbapicEa7Ur1gwKxRQh
         jhyTMnC+CoiHuztcaSeuTDndq4ryV/cBDBlHfMl10LZFBLVgWTFBmPWXBUF6+WA5Kkv4
         WYvRWpPklAa0ekjVF99zbc4UP8Sf4aT/TgaZ1/kDoudYOaS+pUpyLHwBXWjT9yPoopfA
         g/WQ==
X-Gm-Message-State: AOAM531ZSvJo24xeHAlG7K7G5pVqE3Vo49aiT4Lj786wbG7MNGSLk9Wy
	roxBObARwKrgTBRn7Vfambg=
X-Google-Smtp-Source: ABdhPJzbQjlNRx+yi2tFC2SlLvbS0vVoKxN+s/34myLn6vcm23U1Ad+X1dwpNWhVsnVmCKxk4h5fmA==
X-Received: by 2002:a17:902:b28a:b0:142:3e17:38d8 with SMTP id u10-20020a170902b28a00b001423e1738d8mr35656284plr.56.1638694116990;
        Sun, 05 Dec 2021 00:48:36 -0800 (PST)
Message-ID: <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>
Date: Sun, 5 Dec 2021 16:48:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
 <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/5/2021 4:34 PM, Juergen Gross wrote:
> On 05.12.21 09:18, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>
>> hyperv Isolation VM requires bounce buffer support to copy
>> data from/to encrypted memory and so enable swiotlb force
>> mode to use swiotlb bounce buffer for DMA transaction.
>>
>> In Isolation VM with AMD SEV, the bounce buffer needs to be
>> accessed via extra address space which is above shared_gpa_boundary
>> (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
>> The access physical address will be original physical address +
>> shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
>> spec is called virtual top of memory(vTOM). Memory addresses below
>> vTOM are automatically treated as private while memory above
>> vTOM is treated as shared.
>>
>> Hyper-V initalizes swiotlb bounce buffer and default swiotlb
>> needs to be disabled. pci_swiotlb_detect_override() and
>> pci_swiotlb_detect_4gb() enable the default one. To override
>> the setting, hyperv_swiotlb_detect() needs to run before
>> these detect functions which depends on the pci_xen_swiotlb_
>> init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
>> _detect() to keep the order.
> 
> Why? Does Hyper-V plan to support Xen PV guests? If not, I don't see
> the need for adding this change.
> 

This is to keep detect function calling order that Hyper-V detect 
callback needs to call before pci_swiotlb_detect_override() and 
pci_swiotlb_detect_4gb(). This is the same for why
pci_swiotlb_detect_override() needs to depend on the 
pci_xen_swiotlb_detect(). Hyper-V also has such request and so make xen 
detect callback depends on Hyper-V one.


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 09:48:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 09:48:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238356.413118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mto8G-0004z8-G7; Sun, 05 Dec 2021 09:48:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238356.413118; Sun, 05 Dec 2021 09:48:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mto8G-0004z1-CD; Sun, 05 Dec 2021 09:48:32 +0000
Received: by outflank-mailman (input) for mailman id 238356;
 Sun, 05 Dec 2021 09:48:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mto8F-0004yr-4T; Sun, 05 Dec 2021 09:48:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mto8E-00074K-VG; Sun, 05 Dec 2021 09:48:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mto8E-0002Si-MG; Sun, 05 Dec 2021 09:48:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mto8E-0002Yp-Lm; Sun, 05 Dec 2021 09:48:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0+wjSGyThsCzZXpTrGIjPVo5avNuQ1rCuJigxsa6/H8=; b=OpBiMJaWTDVUXSlWBptpSXQlBU
	icDgGBlbHkOQ6L7ymTRG6d/vOhHuQf8e/5yvMzCrk/1iunb6N66EWP+JK06ce3aDkSTT0LGu86tld
	aQi3yeRTNEFRFwRe4JdcNrM3dWtqCnBwV58ue4GoFoj4QVzS4n3RkzKbnQINHIh2LWo4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167144-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167144: all pass - PUSHED
X-Osstest-Versions-This:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 05 Dec 2021 09:48:30 +0000

flight 167144 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167144/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   166971  2021-12-01 09:19:46 Z    4 days
Testing same since   167144  2021-12-05 09:18:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tim Deegan <tim@xen.org>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7f147bf4a..ea0c08bc77  ea0c08bc77fe7bd7e4e65c648e17752e91912d01 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 10:32:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 10:32:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238377.413144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtooE-0002PC-GO; Sun, 05 Dec 2021 10:31:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238377.413144; Sun, 05 Dec 2021 10:31:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtooE-0002P5-CZ; Sun, 05 Dec 2021 10:31:54 +0000
Received: by outflank-mailman (input) for mailman id 238377;
 Sun, 05 Dec 2021 10:31:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LI7m=QW=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mtooC-0002Oy-Jz
 for xen-devel@lists.xenproject.org; Sun, 05 Dec 2021 10:31:52 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8dd4906f-55b6-11ec-8a4d-196798b21f7b;
 Sun, 05 Dec 2021 11:31:49 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9B4041FD38;
 Sun,  5 Dec 2021 10:31:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C107F1348A;
 Sun,  5 Dec 2021 10:31:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qYOyLBKVrGH8TQAAMHmgww
 (envelope-from <jgross@suse.com>); Sun, 05 Dec 2021 10:31:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8dd4906f-55b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638700308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=K7SjtJiY99hUvKc+7aYw88KA13ESSI3BIsezmC/7IyY=;
	b=ohafv7Z6p35vo8D6RqjNwU7ojURa1cOTkJi+dJivIYoiyBnTVP2smtpL8AGkv+hHcm+OWp
	cHxyTRuCDEDMji92LoYs5I8f4KoZYj7RLwUTQRF/E7oDoVKcK3XB3xHv9Ik2toMmz+h/d3
	5k6HsZi0t+woqJbJVkd6B+89Fie9qE8=
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
 <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
 <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <ed9aa3d5-9ac8-2195-e617-85599ffd7864@suse.com>
Date: Sun, 5 Dec 2021 11:31:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="2lNGFmlfQKDxEQnMi4PlLmBojmVqlWXfg"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2lNGFmlfQKDxEQnMi4PlLmBojmVqlWXfg
Content-Type: multipart/mixed; boundary="xiSNwffzrwFZS3WSVpqneCffSxZ2oqvaj";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Tianyu Lan <ltykernel@gmail.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
Message-ID: <ed9aa3d5-9ac8-2195-e617-85599ffd7864@suse.com>
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
 <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
 <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>
In-Reply-To: <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>

--xiSNwffzrwFZS3WSVpqneCffSxZ2oqvaj
Content-Type: multipart/mixed;
 boundary="------------6DEB2D258518C218A03A410C"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6DEB2D258518C218A03A410C
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 05.12.21 09:48, Tianyu Lan wrote:
>=20
>=20
> On 12/5/2021 4:34 PM, Juergen Gross wrote:
>> On 05.12.21 09:18, Tianyu Lan wrote:
>>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>>
>>> hyperv Isolation VM requires bounce buffer support to copy
>>> data from/to encrypted memory and so enable swiotlb force
>>> mode to use swiotlb bounce buffer for DMA transaction.
>>>
>>> In Isolation VM with AMD SEV, the bounce buffer needs to be
>>> accessed via extra address space which is above shared_gpa_boundary
>>> (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.=

>>> The access physical address will be original physical address +
>>> shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
>>> spec is called virtual top of memory(vTOM). Memory addresses below
>>> vTOM are automatically treated as private while memory above
>>> vTOM is treated as shared.
>>>
>>> Hyper-V initalizes swiotlb bounce buffer and default swiotlb
>>> needs to be disabled. pci_swiotlb_detect_override() and
>>> pci_swiotlb_detect_4gb() enable the default one. To override
>>> the setting, hyperv_swiotlb_detect() needs to run before
>>> these detect functions which depends on the pci_xen_swiotlb_
>>> init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
>>> _detect() to keep the order.
>>
>> Why? Does Hyper-V plan to support Xen PV guests? If not, I don't see
>> the need for adding this change.
>>
>=20
> This is to keep detect function calling order that Hyper-V detect=20
> callback needs to call before pci_swiotlb_detect_override() and=20
> pci_swiotlb_detect_4gb(). This is the same for why
> pci_swiotlb_detect_override() needs to depend on the=20
> pci_xen_swiotlb_detect(). Hyper-V also has such request and so make xen=
=20
> detect callback depends on Hyper-V one.

And does this even work without CONFIG_SWIOTLB_XEN, i.e. without
pci_xen_swiotlb_detect() being in the system?


Juergen

--------------6DEB2D258518C218A03A410C
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6DEB2D258518C218A03A410C--

--xiSNwffzrwFZS3WSVpqneCffSxZ2oqvaj--

--2lNGFmlfQKDxEQnMi4PlLmBojmVqlWXfg
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGslRIFAwAAAAAACgkQsN6d1ii/Ey9y
Tgf/UCpwSO5ZoUwzIdaAOOQ5xJjsv/5TLJU+V/47jZW8b5iw54q5T19UV0gNLP/mxxuaq8lKREwG
63YPWXsyVexiOXe6rIum4MEg5cyVKCqxrtaB9iWUTTD9uAhhd79db5Vq7M8Fa6//tBtbDvbuA1WH
MfASOYJQXrrBcBPGOb/PZfLJcm91NmSv2WGPFpNfP4dNSTExkMBRp2y2KpfbWVbB0K9GEfzPNOlZ
JnXv6k+OR31oyd/0nsL9KVQ09lattw1Nmh8cMaNh81+SzqnSlnfd1j/jJ2E8djTuCJGurGTBIANr
nHiJ2MbcApZE66yH0xNQtjdZdEx4soeSG6IALNYkpA==
=f6Cb
-----END PGP SIGNATURE-----

--2lNGFmlfQKDxEQnMi4PlLmBojmVqlWXfg--


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 15:03:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 15:03:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238448.413212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtt24-0006Fq-Jc; Sun, 05 Dec 2021 15:02:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238448.413212; Sun, 05 Dec 2021 15:02:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtt24-0006Fj-Ga; Sun, 05 Dec 2021 15:02:28 +0000
Received: by outflank-mailman (input) for mailman id 238448;
 Sun, 05 Dec 2021 15:02:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtt22-0006FZ-Ub; Sun, 05 Dec 2021 15:02:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtt22-000433-NA; Sun, 05 Dec 2021 15:02:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtt22-0001J3-Fx; Sun, 05 Dec 2021 15:02:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtt22-0004l9-FS; Sun, 05 Dec 2021 15:02:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/4uMfGAONgRrdRx+FBZYvo2raQddufFtmhTW7Bvu+uI=; b=fvPTD2p0M5vGnw+CIxRWERj50V
	FsROauiJ5uukgA8h5cFIaghy+YFrl5IOpue37tOw269iImYHu1LC08KgPhgUeev6/UQDfTVCtDOKK
	zhs45jC7cH9dvUtMzIGqMBvxicc9VGw+bwriDxA4sfMGrCyrIIPpSYBMTUZsNNC4HO+0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167117-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167117: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:nested-setup:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-coresched-i386-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start.2:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-destroy:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-arndale:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-intel:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-intel:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-seattle:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-coresched-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvhv2-amd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-dom0pvh-xl-amd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-pvshim:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-shadow:guest-start.2:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-thunderx:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug
    linux-5.4:test-armhf-armhf-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-ovmf-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
X-Osstest-Versions-That:
    linux=9334f48f567334f54101223012ec9d3b4628bed8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 05 Dec 2021 15:02:26 +0000

flight 167117 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167117/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167023 pass in 167071
 test-amd64-amd64-xl-pvshim   14 guest-start      fail in 167023 pass in 167117
 test-amd64-amd64-qemuu-nested-amd 13 nested-setup fail in 167023 pass in 167117
 test-amd64-amd64-xl-pvhv2-intel 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-arm64-arm64-xl-xsm      14 guest-start      fail in 167023 pass in 167117
 test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-coresched-i386-xl 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-i386-xl-shadow 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-amd64-xl 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-amd64-xl-xsm 22 guest-start/debian.repeat fail in 167023 pass in 167117
 test-arm64-arm64-xl-credit2  19 guest-start.2    fail in 167023 pass in 167117
 test-armhf-armhf-libvirt     20 guest-destroy    fail in 167023 pass in 167117
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 167023 pass in 167117
 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167023 pass in 167117
 test-armhf-armhf-xl 18 guest-start/debian.repeat fail in 167023 pass in 167117
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail in 167023 pass in 167117
 test-armhf-armhf-xl-arndale 18 guest-start/debian.repeat fail in 167023 pass in 167117
 test-amd64-amd64-xl-pvhv2-intel 14 guest-start   fail in 167071 pass in 167117
 test-amd64-amd64-qemuu-nested-amd 12 debian-hvm-install fail in 167071 pass in 167117
 test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-dom0pvh-xl-intel 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-multivcpu 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-coresched-amd64-xl 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-pvhv2-amd 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-dom0pvh-xl-amd 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl  22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-pvshim 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-xsm 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-shadow    23 guest-start.2    fail in 167071 pass in 167117
 test-amd64-i386-libvirt 20 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl-xsm 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl-thunderx 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-arm64-arm64-xl-credit2 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-arm64-arm64-libvirt-xsm 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-examine    4 memdisk-try-append fail in 167071 pass in 167117
 test-armhf-armhf-libvirt 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 14 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-libvirt-raw 19 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-i386-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-xl-qemuu-ovmf-amd64 20 guest-start/debianhvm.repeat fail in 167071 pass in 167117
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 167023
 test-armhf-armhf-xl-vhd       8 xen-boot                   fail pass in 167071
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167071

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 167071 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 167071 never pass
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166839
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166839
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166839
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166839
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166839
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166839
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166839
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166839
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5
baseline version:
 linux                9334f48f567334f54101223012ec9d3b4628bed8

Last test of basis   166839  2021-11-26 10:11:13 Z    9 days
Testing same since   166970  2021-12-01 08:40:40 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Alexander Aring <aahringo@redhat.com>
  Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Helgaas <bhelgaas@google.com>
  Boris Ostrovsky <boris.ostrovsky@oracle.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christian Lamparter <chunkeey@gmail.com>
  Christoph Hellwig <hch@lst.de>
  Chuanqi Liu <legend050709@qq.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Hildenbrand <david@redhat.com>
  David S. Miller <davem@davemloft.net>
  Diana Wang <na.wang@corigine.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dylan Hung <dylan_hung@aspeedtech.com>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Grzegorz Jaszczyk <jaz@semihalf.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil-cisco@xs4all.nl>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Huang Pei <huangpei@loongson.cn>
  Hulk Robot <hulkrobot@huawei.com>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gerecke <jason.gerecke@wacom.com>
  Jason Gerecke <killertofu@gmail.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johan Hovold <johan@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Joshua Dickens <joshua.dickens@wacom.com>
  Juergen Gross <jgross@suse.com>
  Julian Anastasov <ja@ssi.bg>
  Julian Sikorski <belegdol@gmail.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Kumar Thangavel <kumarthangavel.hcl@gmail.com>
  Kumar Thangavel <thangavel.k@hcl.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
  Manfred Spraul <manfred@colorfullife.com>
  Marek Behún <kabel@kernel.org>
  Marek Behún <marek.behun@nic.cz>
  Marek Szyprowski <m.szyprowski@samsung.com>
  Mark Brown <broonie@kernel.org>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maurizio Lombardi <mlombard@redhat.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Mingjie Zhang <superzmj@fibocom.com>
  Nathan Chancellor <nathan@kernel.org>
  Neal Cardwell <ncardwell@google.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nitesh B Venkatesh <nitesh.b.venkatesh@intel.com>
  Noralf Trønnes <noralf@tronnes.org>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Ondrej Jirman <megous@megous.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Peng Fan <peng.fan@nxp.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Remi Pommarel <repk@triplefau.lt>
  Richard Cochran <richardcochran@gmail.com>
  Rob Herring <robh@kernel.org>
  Roger Pau Monné <roger.pau@citrix.com>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sam Ravnborg <sam@ravnborg.org>
  Samuel Mendoza-Jonas <sam@mendozajonas.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <horms@verge.net.au>
  Simon Horman <simon.horman@corigine.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stefan Schmidt <stefan@datenfreihafen.org>
  Stefano Garzarella <sgarzare@redhat.com>
  Stefano Stabellini <stefano.stabellini@xilinx.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Takashi Iwai <tiwai@suse.de>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Petazzoni <thomas.petazzoni@bootlin.com>
  Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
  Tobias Brunner <tobias@strongswan.org>
  Todd Kjos <tkjos@google.com>
  Tomasz Maciej Nowak <tmn505@gmail.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Varun Prakash <varun@chelsio.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Weichao Guo <guoweichao@oppo.com>
  yangxingwu <xingwu.yang@gmail.com>
  Ziyang Xuan <william.xuanziyang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9334f48f5673..57899c4e26bf  57899c4e26bf5a02b9b405267a1812f26b9ccce5 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 19:49:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 19:49:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238495.413270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtxVG-0002ur-Ql; Sun, 05 Dec 2021 19:48:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238495.413270; Sun, 05 Dec 2021 19:48:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtxVG-0002uk-NS; Sun, 05 Dec 2021 19:48:54 +0000
Received: by outflank-mailman (input) for mailman id 238495;
 Sun, 05 Dec 2021 19:48:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxVF-0002uY-5L; Sun, 05 Dec 2021 19:48:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxVE-0000o9-UD; Sun, 05 Dec 2021 19:48:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxVE-0007HD-Gg; Sun, 05 Dec 2021 19:48:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxVE-0000Jv-GB; Sun, 05 Dec 2021 19:48:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UOqp/I/x7ljq8XTgiz16Sxxd8YypegW6qYBVM4OxrHg=; b=jFa9E7RME6IBiQDEjpio0ObI4m
	wkQHGJJ6pkwNzuds6F+IBimfYCHA/UPyh+J4YttMZsgUZw1yhNeMSEove7ZgsmO2XemRXvz+sf3Hh
	5vv7slxGVJF30ZnJQ5v0YGlFOuyB52fYhrUVxPTehxIzdDJ21Z3MY24EO13r9/vMzKH8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167130-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167130: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4cf9f43f1da4f3a54cb71caecdae18950046e03b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 05 Dec 2021 19:48:52 +0000

flight 167130 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167130/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4cf9f43f1da4f3a54cb71caecdae18950046e03b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  513 days
Failing since        151818  2020-07-11 04:18:52 Z  512 days  494 attempts
Testing same since   167130  2021-12-05 04:21:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 86571 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Dec 05 20:19:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 05 Dec 2021 20:19:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238504.413288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtxye-0006em-74; Sun, 05 Dec 2021 20:19:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238504.413288; Sun, 05 Dec 2021 20:19:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mtxye-0006ef-3x; Sun, 05 Dec 2021 20:19:16 +0000
Received: by outflank-mailman (input) for mailman id 238504;
 Sun, 05 Dec 2021 20:19:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxyc-0006eV-9m; Sun, 05 Dec 2021 20:19:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxyc-0001NU-0T; Sun, 05 Dec 2021 20:19:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxyb-0000YG-MB; Sun, 05 Dec 2021 20:19:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mtxyb-0002Dj-Lg; Sun, 05 Dec 2021 20:19:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=otsZXy9j3AMHurgc8BOpSjr/x8SC8XH4dA7qH0XoSqk=; b=tn8O83pfh3iPrwJwW8drO3PdtI
	VRIh+UlvW+Dh2Ibkj9gwQ4edi2Ng1V6S/kVfYDj3MUUtCgSusZBSkr4IP7ix3ZPC2VlpZXPLVr34O
	XYD80yFHtAVCT+mhDpkccXtWjvzJhpC5HGlJ1k8FVwi6eaQSlRoB5q35wQOs11A/kNgs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167118-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167118: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-libvirt:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=23b55d673d7527b093cd97b7c217c82e70cd1af0
X-Osstest-Versions-That:
    linux=c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 05 Dec 2021 20:19:13 +0000

flight 167118 linux-linus real [real]
flight 167164 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167118/
http://logs.test-lab.xenproject.org/osstest/logs/167164/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt 20 guest-start/debian.repeat fail pass in 167164-retest
 test-arm64-arm64-xl-xsm       8 xen-boot            fail pass in 167164-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-xsm     15 migrate-support-check fail in 167164 never pass
 test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 167164 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166942
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166942
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166942
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166942
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166942
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166942
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                23b55d673d7527b093cd97b7c217c82e70cd1af0
baseline version:
 linux                c5c17547b778975b3d83a73c8d84e8fb5ecf3ba5

Last test of basis   166942  2021-11-27 18:11:40 Z    8 days
Failing since        166963  2021-11-30 20:54:02 Z    4 days    7 attempts
Testing same since   167118  2021-12-04 23:14:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaro Koskinen <aaro.koskinen@iki.fi>
  Adrian Hunter <adrian.hunter@intel.com>
  Akhil P Oommen <akhilpo@codeaurora.org>
  Alain Volmat <alain.volmat@foss.st.com>
  Alex Bee <knaerzche@gmail.com>
  Alex Deucher <aleander.deucher@amd.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alex Williamson <alex.williamson@redhat.com>
  Alexandra Winter <wintera@linux.ibm.com>
  Amir Tzin <amirtz@nvidia.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Anup Patel <anup.patel@wdc.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnd Bergmann <arnd@arndb.de>
  Aya Levin <ayal@nvidia.com>
  Baokun Li <libaokun1@huawei.com>
  Bean Huo <beanhuo@micron.com>
  Ben Ben-Ishay <benishay@nvidia.com>
  Ben Gardon <bgardon@google.com>
  Benjamin Coddington <bcodding@redhat.com>
  Benjamin Poirier <bpoirier@nvidia.com>
  Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
  Borislav Petkov <bp@suse.de>
  Catalin Marinas <catalin.marinas@arm.com>
  Chen Jun <chenjun102@huawei.com>
  chongjiapeng <jiapeng.chong@linux.alibaba.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christoph Hellwig <hch@lst.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Christophe Leroy <christophe.leroy@csgroup.eu>
  Colin Xu <colin.xu@gmail.com>
  Corey Minyard <cminyard@mvista.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dan Johansen <strit@manjaro.org>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Airlie <airlied@redhat.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Woodhouse <dwmw@amazon.co.uk>
  Deren Wu <deren.wu@mediatek.com>
  Dmitry Bogdanov <dbezrukov@marvell.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Doug Smythies <dsmythies@telus.net>
  Douglas Anderson <dianders@chromium.org>
  Douglas Gilbert <dgilbert@interlog.com>
  Dust Li <dust.li@linux.alibaba.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Dumazet <edumazet@google.com>
  Erik Ekman <erik@kryo.se>
  Felix Fietkau <nbd@nbd.name>
  Finn Thain <fthain@linux-m68k.org>
  Flora Cui <flora.cui@amd.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Fischer <florian.fl.fischer@fau.de>
  Fuad Tabba <tabba@google.com>
  Gal Pressman <gal@nvidia.com>
  Gao Xiang <xiang@kernel.org>
  George Kennedy <george.kennedy@oracle.com>
  George Shen <George.Shen@amd.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Guangming <Guangming.Cao@mediatek.com>
  Guchun Chen <guchun.chen@amd.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurchetan Singh <gurchetansingh@chromium.org>
  Gustavo A. R. Silva <gustavoars@kernel.org>
  Hangbin Liu <liuhangbin@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Heiko Carstens <hca@linux.ibm.com>
  Hou Wenlong <houwenlong93@linux.alibaba.com>
  Huang Jianan <huangjianan@oppo.com>
  Huang Pei <huangpei@loongson.cn>
  Hyunchul Lee <hyc.lee@gmail.com>
  Igor Russkikh <irusskikh@marvell.com>
  Ilie Halip <ilie.halip@gmail.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakub Kicinski <kuba@kernel.org>
  James Smart <jsmart2021@gmail.com>
  Jane Jian <Jane.Jian@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jason Wang <jasowang@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jeremy Kerr <jk@codeconstruct.com.au>
  Jian-Hong Pan <jhp@endlessos.org>
  Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
  Jimmy Kizito <Jimmy.Kizito@amd.com>
  Joerg Roedel <jroedel@suse.de>
  José Roberto de Souza <jose.souza@intel.com>
  Juergen Gross <jgross@suse.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kalle Valo <kvalo@codeaurora.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Larry Finger <Larry.Finger@lwfinger.net>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Lijo Lazar <lijo.lazar@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Longpeng <longpeng2@huawei.com>
  Lorenzo Bianconi <lorenzo@kernel.org>
  Lu Baolu <baolu.lu@linux.intel.com>
  Luca Coelho <luciano.coelho@intel.com>
  Lucas Tanure <tanureal@opensource.cirrus.com>
  Luiz Angelo Daros de Luca <luizluca@gmail.com>
  Lyude Paul <lyude@redhat.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Maor Dickman <maord@nvidia.com>
  Maor Gottlieb <maorg@nvidia.com>
  Marc Zyngier <maz@kernel.org>
  Marco Elver <elver@google.com>
  Marek Behún <kabel@kernel.org>
  Mark Bloch <mbloch@nvidia.com>
  Mark Brown <broonie@kernel.org>
  Mark Rutland <mark.rutland@arm.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Matt Johnston <matt@codeconstruct.com.au>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Max Filippov <jcmvbkbc@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Michael Ellerman <mpe@ellerman.id.au>
  Michael S. Tsirkin <mst@redhat.com>
  Michael Stapelberg <michael@stapelberg.ch>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  Moshe Shemesh <moshe@nvidia.com>
  msizanoen1 <msizanoen@qtmlabs.xyz>
  Muchun Song <songmuchun@bytedance.com>
  Mustapha Ghaddar <mghaddar@amd.com>
  Mustapha Ghaddar <mustapha.ghaddar@amd.com>
  Namjae Jeon <linkinjeon@kernel.org>
  NeilBrown <neilb@suse.de>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nicholas Piggin <npiggin@gmail.com>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Nikita Danilov <ndanilov@aquantia.com>
  Niklas Schnelle <schnelle@linux.ibm.com>
  Ole Ernst <olebowle@gmx.com>
  Olga Kornievskaia <kolga@netapp.com>
  Ondrej Jirman <megous@megous.com>
  Paolo Abeni <pabeni@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Cercueil <paul@crapouillou.net>
  Paul Ely <paul.ely@broadcom.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Pavel Begunkov <asml.silence@gmail.com>
  Perry Yuan <Perry.Yuan@amd.com>
  Peter Geis <pgwipeout@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Philip Chen <philipchen@chromium.org>
  Philip Yang <Philip.Yang@amd.com>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Ping-Ke Shih <pkshih@realtek.com>
  Qian Cai <quic_qiancai@quicinc.com>
  Raed Salem <raeds@nvidia.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
  Rob Clark <robdclark@chromium.org>
  Rob Clark <robdclark@gmail.com>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sameer Pujar <spujar@nvidia.com>
  Sameer Saurabh <ssaurabh@marvell.com>
  Santosh Shilimkar <santosh.shilimkar@oracle.com>
  Sean Christopherson <seanjc@google.com>
  shaoyunl <shaoyun.liu@amd.com>
  Shen, George <George.Shen@amd.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Shyam Prasad N <sprasad@microsoft.com>
  Sreekanth Reddy <sreekanth.reddy@broadcom.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Steev Klimaszewski <steev@kali.org>
  Stefan Binding <sbinding@opensource.cirrus.com>
  Stefano Garzarella <sgarzare@redhat.com>
  Stephen Boyd <swboyd@chromium.org>
  Stephen Suryaputra <ssuryaextr@gmail.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudarsana Reddy Kalluru <skalluru@marvell.com>
  Sukadev Bhattiprolu <sukadev@linux.ibm.com>
  Sumit Semwal <sumit.semwal@linaro.org>
  Sven Schuchmann <schuchmann@schleissheimer.de>
  Takashi Iwai <tiwai@suse.de>
  Tang Yizhou <tangyizhou@huawei.com>
  Tariq Toukan <tariqt@nvidia.com>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Tianhao Chai <cth451@gmail.com>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Tony Lu <tonylu@linux.alibaba.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vitaly Rodionov <vitalyr@opensource.cirrus.com>
  Waiman Long <longman@redhat.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wenjia Zhang <wenjia@linux.ibm.com>
  Will Deacon <will@kernel.org>
  William Kucharski <william.kucharski@oracle.com>
  Wolfram Sang <wsa@kernel.org>
  Wu Zongyong <wuzongyong@linux.alibaba.com>
  Xiayu Zhang <Xiayu.Zhang@mediatek.com>
  Xiongfeng Wang <wangxiongfeng2@huawei.com>
  Yang Guang <yang.guang5@zte.com.cn>
  Yang Xu <xuyang2018.jy@fujitsu.com>
  Ye Bin <yebin10@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>
  Zhenyu Wang <zhenyuw@linux.intel.com>
  Zhou Qingyang <zhou1615@umn.edu>
  Łukasz Bartosik <lb@semihalf.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      fail    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     fail    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c5c17547b778..23b55d673d75  23b55d673d7527b093cd97b7c217c82e70cd1af0 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 00:00:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 00:00:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238532.413340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu1Qa-00062V-7v; Mon, 06 Dec 2021 00:00:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238532.413340; Mon, 06 Dec 2021 00:00:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu1Qa-00062O-50; Mon, 06 Dec 2021 00:00:20 +0000
Received: by outflank-mailman (input) for mailman id 238532;
 Mon, 06 Dec 2021 00:00:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu1QZ-00062E-Nf; Mon, 06 Dec 2021 00:00:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu1QZ-0005aq-J3; Mon, 06 Dec 2021 00:00:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu1QZ-0005LW-9w; Mon, 06 Dec 2021 00:00:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu1QZ-0002rn-9R; Mon, 06 Dec 2021 00:00:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7CJSKoqmCcggQyVu+x2gHAliaHDdA0Wr4uJMptJVXUM=; b=vOhCxAWFEnYti4kBL5YbE3FVYG
	tBt0uOxE//6lns/UkW/9hu96N+ugaeZ2TCA5rz5NmiMxmbd+amEI+swrKwWANlTL38ujJ5Txmq468
	3nxr2DCWQwPYhP1wvP0UMPIHebwg18jMW8ZU3yyidZTipPuHSm9I5HouaVqmqrLI6A9k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167119-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167119: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
X-Osstest-Versions-That:
    xen=5449ba84e99849ee2339fd79f9717e10113d702d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 00:00:19 +0000

flight 167119 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167119/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-examine      4 memdisk-try-append           fail  like 166912
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166941
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166941
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166941
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166941
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166941
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166941
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166941
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166941
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166941
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db
baseline version:
 xen                  5449ba84e99849ee2339fd79f9717e10113d702d

Last test of basis   166941  2021-11-27 16:15:54 Z    8 days
Failing since        166960  2021-11-30 12:35:41 Z    5 days    7 attempts
Testing same since   166966  2021-12-01 05:46:26 Z    4 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Roger Pau Monné <roger.pau@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   5449ba84e9..e7f147bf4a  e7f147bf4ac725492962a501da72f5ab6be682db -> master


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 03:16:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 03:16:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238567.413445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu4U7-0004aV-9Z; Mon, 06 Dec 2021 03:16:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238567.413445; Mon, 06 Dec 2021 03:16:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu4U7-0004aO-5M; Mon, 06 Dec 2021 03:16:11 +0000
Received: by outflank-mailman (input) for mailman id 238567;
 Mon, 06 Dec 2021 03:16:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4U5-0004aD-95; Mon, 06 Dec 2021 03:16:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4U5-0002tz-2Y; Mon, 06 Dec 2021 03:16:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4U4-0004S8-N2; Mon, 06 Dec 2021 03:16:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4U4-0003nd-MW; Mon, 06 Dec 2021 03:16:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bPVuO/UwVwmujqFYVxLBNbdLviHTcLKk6RZpYyhvuGk=; b=VYV7MQWLSGIuRc/4T+O7H5T5iS
	0XxOLNsT7BycDi/0zDXfeLdytOUR5cfGJkZM3GO9APwmN7L1a2wCPZOGvXv17/CdlGVFxUzJChJCj
	TqRDoK8Ga/Uitm2UdogQHMtNYuRpt9Kdpb6WUiW1oYlGnFyyc3VE5AZ4PT6q/80A6ewY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167122-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167122: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=dfafa8e45382939fb5dc78e9d37b97b500a43613
X-Osstest-Versions-That:
    ovmf=f0f3f5aae7c4d346ea5e24970936d80dc5b60657
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 03:16:08 +0000

flight 167122 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167122/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 dfafa8e45382939fb5dc78e9d37b97b500a43613
baseline version:
 ovmf                 f0f3f5aae7c4d346ea5e24970936d80dc5b60657

Last test of basis   166961  2021-11-30 14:41:39 Z    5 days
Testing same since   167081  2021-12-03 10:10:57 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Wenyi Xie <xiewenyi2@huawei.com>
  wenyi,xie via groups.io <xiewenyi2=huawei.com@groups.io>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f0f3f5aae7..dfafa8e453  dfafa8e45382939fb5dc78e9d37b97b500a43613 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 03:38:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 03:38:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238577.413458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu4pg-0007Ru-69; Mon, 06 Dec 2021 03:38:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238577.413458; Mon, 06 Dec 2021 03:38:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu4pg-0007Rn-3G; Mon, 06 Dec 2021 03:38:28 +0000
Received: by outflank-mailman (input) for mailman id 238577;
 Mon, 06 Dec 2021 03:38:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4pf-0007Rd-F0; Mon, 06 Dec 2021 03:38:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4pf-0003GW-8f; Mon, 06 Dec 2021 03:38:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4pe-0005Nd-Sp; Mon, 06 Dec 2021 03:38:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu4pe-0004F9-SM; Mon, 06 Dec 2021 03:38:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vg34r1cwpoljQk2yFSGgHhGvjZ5O5cbX+X42wZOjEHQ=; b=kUs8xl4CfH8Jn0xBqtfVOqIHKs
	IenlMsDlqULuntkeU6AHAXNNVt/TDAx5ilRiM58tCbqbiSplRpKi9+DtDNqznKq3cTzY0gvmBIRlD
	2hjHiyYNVIFX9MUUs81XmkFaL0ov8AUQAyIcKWjI/47al2COpfjqxT4mm3uqliYjRlbQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167120-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 167120: tolerable FAIL - PUSHED
X-Osstest-Failures:
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=2dd4b9b3f84019668719344b40dba79d681be41c
X-Osstest-Versions-That:
    seabios=64f37cc530f144e53c190c9e8209a51b58fd5c43
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 03:38:26 +0000

flight 167120 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167120/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 165173
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 165173
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 165173
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 165173
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 165173
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              2dd4b9b3f84019668719344b40dba79d681be41c
baseline version:
 seabios              64f37cc530f144e53c190c9e8209a51b58fd5c43

Last test of basis   165173  2021-09-24 03:09:48 Z   73 days
Testing same since   167061  2021-12-03 02:40:21 Z    3 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Kevin O'Connor <kevin@koconnor.net>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/seabios.git
   64f37cc..2dd4b9b  2dd4b9b3f84019668719344b40dba79d681be41c -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 04:54:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 04:54:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238589.413479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu611-0007r1-0F; Mon, 06 Dec 2021 04:54:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238589.413479; Mon, 06 Dec 2021 04:54:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu610-0007qu-TS; Mon, 06 Dec 2021 04:54:14 +0000
Received: by outflank-mailman (input) for mailman id 238589;
 Mon, 06 Dec 2021 04:54:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu60z-0007qk-S3; Mon, 06 Dec 2021 04:54:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu60z-0004gC-Hz; Mon, 06 Dec 2021 04:54:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu60z-00087e-4C; Mon, 06 Dec 2021 04:54:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu60z-0006Sm-3g; Mon, 06 Dec 2021 04:54:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iQL+94DGNE8WTrXJb178syrD0+1Mh6Rd6v8Yj1WiNGk=; b=LqbEzVaCtO9GnnyK/2dFqAwemM
	KR9crayD4QP9CkFQY1rofMmiQ/O5dj3RciDX/Hw1cHJ6LE031OrFGVzPvk8Zlz57td+56geXaE8Ky
	zmzQuOUAVaKC6cP6z9Agcob6NvF35hPwCbi0GVLQqtEArIhFK0tC3rw0kTo6KBPUn6Hk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167168-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167168: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=944207047ca4dabe8e288f653e7ec6da05e70230
X-Osstest-Versions-That:
    linux=23b55d673d7527b093cd97b7c217c82e70cd1af0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 04:54:13 +0000

flight 167168 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167168/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167118

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167118
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167118
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167118
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167118
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167118
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167118
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167118
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167118
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                944207047ca4dabe8e288f653e7ec6da05e70230
baseline version:
 linux                23b55d673d7527b093cd97b7c217c82e70cd1af0

Last test of basis   167118  2021-12-04 23:14:16 Z    1 days
Testing same since   167168  2021-12-05 20:21:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Al Cooper <alcooperx@gmail.com>
  Alexander Potapenko <glider@google.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Andrew Halaney <ahalaney@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
  Badhri Jagan Sridharan <badhri@google.com>
  Baruch Siach <baruch@tkos.co.il>
  Borislav Petkov <bp@alien8.de>
  Borislav Petkov <bp@suse.de>
  Dan Carpenter <dan.carpenter@oracle.com>
  Darrick J. Wong <djwong@kernel.org>
  Dave Hansen <dave.hansen@linux.intel.com>
  Dietmar Eggemann <dietmar.eggemann@arm.com>
  Eric Sandeen <sandeen@redhat.com>
  Feng Tang <feng.tang@intel.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Frank Li <Frank.Li@nxp.com>
  Frederic Weisbecker <frederic@kernel.org>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Hasegawa Hitomi <hasegawa-hitomi@fujitsu.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Ignat Korchagin <ignat@cloudflare.com>
  Ilia Sergachev <silia@ethz.ch>
  Jay Dolan <jay.dolan@accesio.com>
  Joerg Roedel <jroedel@suse.de>
  Johan Hovold <johan@kernel.org>
  Jun Li <jun.li@nxp.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lukas Wunner <lukas@wunner.de>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Marco Elver <elver@google.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Michael Sterritt <sterritt@google.com>
  Ole Ernst <olebowle@gmx.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Patrik John <patrik.john@u-blox.com>
  Paul E. McKenney <paulmck@kernel.org>
  Pavankumar Kondeti <quic_pkondeti@quicinc.com>
  Pawel Laszczak <pawell@cadence.com>
  Peter Chen <peter.chen@kernel.org>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Phil Auld <pauld@redhat.com>
  Pierre Gondois <Pierre.Gondois@arm.com>
  Qais Yousef <qais.yousef@arm.com>
  Sean Christopherson <seanjc@google.com>
  Su Bao Cheng <baocheng.su@siemens.com>
  Sven Eckelmann <sven@narfation.org>
  Thomas Gleixner <tglx@linutronix.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tony Luck <tony.luck@intel.com>
  Zhou Qingyang <zhou1615@umn.edu>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   23b55d673d75..944207047ca4  944207047ca4dabe8e288f653e7ec6da05e70230 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 06:34:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 06:34:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238627.413577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu7Za-0002UD-0W; Mon, 06 Dec 2021 06:34:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238627.413577; Mon, 06 Dec 2021 06:34:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu7ZZ-0002U6-Sp; Mon, 06 Dec 2021 06:34:01 +0000
Received: by outflank-mailman (input) for mailman id 238627;
 Mon, 06 Dec 2021 06:34:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu7ZY-0002Tw-Ut; Mon, 06 Dec 2021 06:34:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu7ZY-0006lr-ME; Mon, 06 Dec 2021 06:34:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu7ZY-0005Tt-B4; Mon, 06 Dec 2021 06:34:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu7ZY-00029p-Ae; Mon, 06 Dec 2021 06:34:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aHsUGFIBzUFgHR9H6NNKMZ54DOiPWZ9uJArJhotdjt8=; b=W+wTWmo0TMckTHDrLgRCNS9ESX
	U99GdebBEoiYfeNZhXgkcPAFdbr6N92X9gHvNt2wzbzDvrQruVa4RxjMYLnGInFKGWz0TkW1m32P3
	FXovbM7FYR0MhHpa7OZwXVSk0cootihcxqFrtyGUC+9HyQyyy6zLxMB8Gu3tIeShqfhA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167121-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167121: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-raw:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=99fc08366b06282614daeda989d2fde6ab8a707f
X-Osstest-Versions-That:
    qemuu=50456a6794fbb8dc94a31eb9534e91c586da7add
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 06:34:00 +0000

flight 167121 qemu-mainline real [real]
flight 167180 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167121/
http://logs.test-lab.xenproject.org/osstest/logs/167180/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-raw 19 guest-start/debian.repeat fail pass in 167180-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166954

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166954
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166954
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166954
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166954
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166954
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166954
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166954
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166954
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                99fc08366b06282614daeda989d2fde6ab8a707f
baseline version:
 qemuu                50456a6794fbb8dc94a31eb9534e91c586da7add

Last test of basis   166954  2021-11-30 08:39:11 Z    5 days
Failing since        166968  2021-12-01 06:37:45 Z    4 days    5 attempts
Testing same since   167121  2021-12-04 23:14:54 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Eduardo Habkost <ehabkost@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  John Snow <jsnow@redhat.com>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   50456a6794..99fc08366b  99fc08366b06282614daeda989d2fde6ab8a707f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238638.413595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lg-0008PG-SQ; Mon, 06 Dec 2021 07:23:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238638.413595; Mon, 06 Dec 2021 07:23:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lg-0008P9-OU; Mon, 06 Dec 2021 07:23:44 +0000
Received: by outflank-mailman (input) for mailman id 238638;
 Mon, 06 Dec 2021 07:23:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Le-0008Mk-Ov
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:42 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fb54773-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9BC782192D;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7136C1330B;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CIJWGny6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fb54773-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=d8/sEf5zxip/z6wrXT3urxSeGPiRIv+pRBh5TUEPjPg=;
	b=sLHRlJRgHai3r+90pA2coKYs9ibAH4mCtD76N9qGrGMXaMr3rg9LAALP04EJ7vL1KjMQrA
	kFV9HwUesSh0/l0lhyBYOvNpt+LqYKWDwjPly9BqLThPvPNQ+5lVxcKVj1yhHCi+qBaQDM
	CgomOAfJe0Nf/fJuEJ7vKIgHiGcOuY8=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 05/10] mini-os: don't repeat definition available via header file
Date: Mon,  6 Dec 2021 08:23:32 +0100
Message-Id: <20211206072337.9517-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

arch/x86/setup.c is repeating the definition of __pte() instead using
the appropriate header. Fix that.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/setup.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/x86/setup.c b/arch/x86/setup.c
index 1ec68d3..b27bbed 100644
--- a/arch/x86/setup.c
+++ b/arch/x86/setup.c
@@ -29,6 +29,7 @@
 #include <mini-os/os.h>
 #include <mini-os/lib.h> /* for printk, memcpy */
 #include <mini-os/kernel.h>
+#include <mini-os/hypervisor.h>
 #include <xen/xen.h>
 #include <xen/arch-x86/cpuid.h>
 #include <xen/arch-x86/hvm/start_info.h>
@@ -61,13 +62,6 @@ char stack[2*STACK_SIZE];
 
 extern char shared_info[PAGE_SIZE];
 
-#if defined(__x86_64__)
-#define __pte(x) ((pte_t) { (x) } )
-#else
-#define __pte(x) ({ unsigned long long _x = (x);        \
-    ((pte_t) {(unsigned long)(_x), (unsigned long)(_x>>32)}); })
-#endif
-
 static inline void fpu_init(void) {
 	asm volatile("fninit");
 }
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238642.413624 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Li-0000Uz-N3; Mon, 06 Dec 2021 07:23:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238642.413624; Mon, 06 Dec 2021 07:23:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Li-0000U6-EV; Mon, 06 Dec 2021 07:23:46 +0000
Received: by outflank-mailman (input) for mailman id 238642;
 Mon, 06 Dec 2021 07:23:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Lg-0008Mk-P7
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f7d7449-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 395151FDF2;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0E8A01330B;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 8D9LAny6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f7d7449-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2T/0NcFBUay+umzcIVeBLzt93p/NF1ROTt/i4aaQWm8=;
	b=Efh8bL88xHn6VBERl0JJiPtNHp4+hYDaguiD7BajgSnsl1zjovl6LdewERRMNpnIvJ+zAg
	+N/0Aw1awnndKXgPYBx7VqGyfzGegxatcKxZnM2tdUBUNqmw4p+gSU/wEyCxlNpAKvf6GH
	9sxgiwDdn7genYuvrgcOIKLeZ0DmU8k=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode
Date: Mon,  6 Dec 2021 08:23:30 +0100
Message-Id: <20211206072337.9517-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Sizing the available memory should respect memory holes, so look at
the memory map when setting the boundary for the memory allocator.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/mm.c  |  6 +-----
 e820.c         | 13 ++++++++-----
 include/e820.h |  2 +-
 3 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8df93da..3bf6170 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -107,7 +107,6 @@ void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -117,11 +116,8 @@ void arch_mm_preinit(void *p)
         xprintk("could not get memory size\n");
         do_exit();
     }
-    last_free_pfn = ret;
 
-    max = e820_get_maxpfn();
-    if ( max < last_free_pfn )
-        last_free_pfn = max;
+    last_free_pfn = e820_get_maxpfn(ret);
 }
 #endif
 
diff --git a/e820.c b/e820.c
index 336a8b8..14fd3cd 100644
--- a/e820.c
+++ b/e820.c
@@ -155,10 +155,10 @@ void arch_print_memmap(void)
 }
 #endif
 
-unsigned long e820_get_maxpfn(void)
+unsigned long e820_get_maxpfn(unsigned long pages)
 {
     int i;
-    unsigned long pfn, max = 0;
+    unsigned long pfns, max = 0;
 
     e820_get_memmap();
 
@@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
     {
         if ( e820_map[i].type != E820_RAM )
             continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
+        pfns = e820_map[i].size >> PAGE_SHIFT;
+        max = e820_map[i].addr >> PAGE_SHIFT;
+        if ( pages <= pfns )
+            return max + pages;
+        pages -= pfns;
+        max += pfns;
     }
 
     return max;
diff --git a/include/e820.h b/include/e820.h
index af2129f..6a57f05 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -49,6 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
-unsigned long e820_get_maxpfn(void);
+unsigned long e820_get_maxpfn(unsigned long pages);
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238639.413600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lh-0008SV-7g; Mon, 06 Dec 2021 07:23:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238639.413600; Mon, 06 Dec 2021 07:23:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lh-0008S6-0r; Mon, 06 Dec 2021 07:23:45 +0000
Received: by outflank-mailman (input) for mailman id 238639;
 Mon, 06 Dec 2021 07:23:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Lf-0008Mw-N6
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:43 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7022ded4-5665-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 08:23:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 389BF1FE05;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0E5901330B;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kLs5An26rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7022ded4-5665-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NkthQq3sOoUO2D/mfhsQzY8AtroPqg7IVvaaK/lNSyg=;
	b=NGet1YZOyh4euiYxkOXsJV6LrEs7LCH7qOFfbjS6pHlqjn7LH2kEJpxYVaflWNi5aRJFq1
	F2GoEyVlbMEHX/ZvoJZFkB8hmgmzYs16rUTewlgN7xhDFfkq+NQaZqWNXI5TinfAKPNiEZ
	vkLeF+R1YlpPPKC2g614AirthTWs+yU=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 08/10] mini-os: add proper pvh grant table handling
Date: Mon,  6 Dec 2021 08:23:35 +0100
Message-Id: <20211206072337.9517-9-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Grant table initialization for PVH requires some additional actions
compared to PV mode. Add those.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/gnttab.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
index 56e59d7..281c207 100644
--- a/arch/x86/gnttab.c
+++ b/arch/x86/gnttab.c
@@ -22,11 +22,15 @@
  */
 
 #include <mini-os/os.h>
+#include <mini-os/console.h>
+#include <mini-os/e820.h>
 #include <mini-os/hypervisor.h>
 #include <mini-os/gnttab.h>
 #include <mini-os/mm.h>
 #include <mini-os/types.h>
+#include <xen/memory.h>
 
+#ifdef CONFIG_PARAVIRT
 grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
 {
     struct gnttab_setup_table setup;
@@ -39,6 +43,33 @@ grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
     HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
     return map_frames(frames, nr_grant_frames);
 }
+#else
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    int i, rc;
+    struct xen_add_to_physmap xatp;
+    unsigned long pfn;
+    unsigned long frames[nr_grant_frames];
+
+    pfn = e820_get_reserved_pfns(nr_grant_frames);
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        xatp.domid = DOMID_SELF;
+        xatp.idx = i;
+        xatp.space = XENMAPSPACE_grant_table;
+        xatp.gpfn = pfn + i;
+        rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp);
+        if ( rc )
+        {
+            xprintk("could not init grant table\n");
+            do_exit();
+        }
+        frames[i] = pfn + i;
+    }
+
+    return map_frames(frames, nr_grant_frames);
+}
+#endif
 
 void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
 {
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238650.413675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Ln-0001WZ-GT; Mon, 06 Dec 2021 07:23:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238650.413675; Mon, 06 Dec 2021 07:23:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Ln-0001UJ-5M; Mon, 06 Dec 2021 07:23:51 +0000
Received: by outflank-mailman (input) for mailman id 238650;
 Mon, 06 Dec 2021 07:23:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Lk-0008Mk-PU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:48 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fd34f57-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CC5DD1FE02;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A1AF01330B;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KBYtJny6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fd34f57-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vd3HZ1Ub/A6C0NepRB2jPIIL8ubajSRfG+DMd9e6lrQ=;
	b=qHWwtj7KcAOcPH8k3zOeliWh+e0spXwxDmmr1q/QVVhN62V4tJBjwiMqJKYRJ1lO6Gi1Ut
	lEgK3mDVN36vJTDIAFV81d5ILR18qUCN5ynObSV6aGi66CVhknpVzLO26jSWGfS0fwO+R+
	06lm+HKOUvMveLFJKNI3h2wtEFwxu/w=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 06/10] mini-os: add memory map service functions
Date: Mon,  6 Dec 2021 08:23:33 +0100
Message-Id: <20211206072337.9517-7-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add two functions for adding reserved areas to the memory map and
for removing them again.

Those will be needed for proper grant table/mapping support in PVH
mode.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 e820.c         | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |  4 +++
 2 files changed, 76 insertions(+)

diff --git a/e820.c b/e820.c
index 50029bb..2888932 100644
--- a/e820.c
+++ b/e820.c
@@ -66,6 +66,21 @@ static void e820_remove_entry(int idx)
         e820_map[i] = e820_map[i + 1];
 }
 
+static void e820_insert_entry(int idx)
+{
+    int i;
+
+    if ( e820_entries == E820_MAX )
+    {
+        xprintk("E820 memory map overflow\n");
+        do_exit();
+    }
+
+    e820_entries++;
+    for ( i = e820_entries - 1; i > idx; i-- )
+        e820_map[i] = e820_map[i - 1];
+}
+
 static void e820_swap_entries(int idx1, int idx2)
 {
     struct e820entry entry;
@@ -153,6 +168,63 @@ void arch_print_memmap(void)
         printk("%012lx-%012lx: %s\n", from, to, type);
     }
 }
+
+unsigned long e820_get_reserved_pfns(int pages)
+{
+    int i;
+    unsigned long last = 0, needed = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0; i < e820_entries && e820_map[i].addr < last + needed; i++ )
+        last = e820_map[i].addr + e820_map[i].size;
+
+    if ( i == 0 || e820_map[i - 1].type != E820_RESERVED )
+    {
+        e820_insert_entry(i);
+        e820_map[i].addr = last;
+        e820_map[i].size = needed;
+        e820_map[i].type = E820_RESERVED;
+    }
+    else
+    {
+        e820_map[i - 1].size += needed;
+    }
+
+    return last >> PAGE_SHIFT;
+}
+
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages)
+{
+    int i;
+    unsigned long addr = start_pfn << PAGE_SHIFT;
+    unsigned long size = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0; i < e820_entries && addr < e820_map[i].addr; i++ );
+
+    BUG_ON(i == e820_entries || e820_map[i].type != E820_RESERVED);
+
+    if ( addr == e820_map[i].addr )
+    {
+        e820_map[i].addr += size;
+        e820_map[i].size -= size;
+        if ( e820_map[i].size == 0 )
+            e820_remove_entry(i);
+        return;
+    }
+
+    if ( addr + size == e820_map[i].addr + e820_map[i].size )
+    {
+        e820_map[i].addr = addr;
+        e820_map[i].size = size;
+        return;
+    }
+
+    e820_insert_entry(i + 1);
+    e820_map[i + 1].addr = addr + size;
+    e820_map[i + 1].size = e820_map[i].addr + e820_map[i].size -
+                           e820_map[i + 1].addr;
+    e820_map[i + 1].type = E820_RESERVED;
+    e820_map[i].size = addr - e820_map[i].addr;
+}
 #endif
 
 unsigned long e820_get_maxpfn(unsigned long pages)
diff --git a/include/e820.h b/include/e820.h
index 49daefa..694ce3b 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -51,5 +51,9 @@ extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
 unsigned long e820_get_max_pages(unsigned long pfn, unsigned long pages);
+#ifndef CONFIG_E820_TRIVIAL
+unsigned long e820_get_reserved_pfns(int pages);
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages);
+#endif
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238645.413643 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lk-0000pl-8e; Mon, 06 Dec 2021 07:23:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238645.413643; Mon, 06 Dec 2021 07:23:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lj-0000ol-Tt; Mon, 06 Dec 2021 07:23:47 +0000
Received: by outflank-mailman (input) for mailman id 238645;
 Mon, 06 Dec 2021 07:23:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Li-0008Mw-Fb
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:46 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f37a3df-5665-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 08:23:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 970A8212BF;
 Mon,  6 Dec 2021 07:23:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 66A981330B;
 Mon,  6 Dec 2021 07:23:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id V+avF3u6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f37a3df-5665-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=YTvNTjnUOIGBj3YdpCPw4zpcXKpaBuF0gzLw707mgsE=;
	b=tmk7+wFY10jFTOB9Ko3FAHrAoEIsfCMGn3XfYgI99dBVTXqEVi/13y8voc+0MyZa/uu3Np
	KRLLLYL0AwST/uuAfRVsYtWo1D792Nenvpfc+RMBkAtFxFGkqJYS2VEfQwgJX9mWU7HjXH
	kc9BtSYyKCefIUGLD45/hTSaqDSomFY=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 00/10] mini-os: add missing PVH features
Date: Mon,  6 Dec 2021 08:23:27 +0100
Message-Id: <20211206072337.9517-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Mini-OS in PVH mode is missing some features, especially in the areas
of ballooning and grant tables.

With this series I am able to run Xenstore stubdom in PVH mode.

Juergen Gross (10):
  mini-os: split e820 map handling into new source file
  mini-os: sort and sanitize e820 memory map
  mini-os: don't assume contiguous RAM when initializing in PVH mode
  mini-os: respect memory map when ballooning up
  mini-os: don't repeat definition available via header file
  mini-os: add memory map service functions
  mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
  mini-os: add proper pvh grant table handling
  mini-os: prepare grantmap entry interface for use by PVH mode
  mini-os: modify grant mappings to work in PVH mode

 Makefile           |   1 +
 arch/arm/mm.c      |  11 +-
 arch/x86/balloon.c |   4 +-
 arch/x86/gnttab.c  | 109 ++++++++++++++++++
 arch/x86/mm.c      | 121 +-------------------
 arch/x86/setup.c   |   8 +-
 balloon.c          |  33 ++++--
 e820.c             | 269 +++++++++++++++++++++++++++++++++++++++++++++
 gntmap.c           | 125 +++++++++++++--------
 include/balloon.h  |   5 +-
 include/e820.h     |  11 ++
 include/gntmap.h   |   1 +
 mm.c               |   7 +-
 13 files changed, 508 insertions(+), 197 deletions(-)
 create mode 100644 arch/x86/gnttab.c
 create mode 100644 e820.c

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238652.413692 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lp-0001uJ-AP; Mon, 06 Dec 2021 07:23:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238652.413692; Mon, 06 Dec 2021 07:23:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lo-0001sz-TC; Mon, 06 Dec 2021 07:23:52 +0000
Received: by outflank-mailman (input) for mailman id 238652;
 Mon, 06 Dec 2021 07:23:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Ll-0008Mk-PV
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:49 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 702d5e8a-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 67E9A21940;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F43413A9C;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eKQ0Dn26rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 702d5e8a-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6ZwIQ/iqw4tJOJDbjhXNjxEyNK1FoP/fIru8GNLpj3E=;
	b=Dx4H9mkwe6zA3efQNNiTwU8kUNk9Ej8hkMBKut7osjyQ2cr7rnD6CpIA0Nj0RHtFNQgcyg
	TXfAw58DejxvNQ7ZkIyHrNSxZegZP9MrQRcqoeaTzRwkxZaq5qsws8rpYRbWhG91FY5ejP
	Q0+4ad5Lmp4I657Xw5k2xxfGMqbAuks=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 09/10] mini-os: prepare grantmap entry interface for use by PVH mode
Date: Mon,  6 Dec 2021 08:23:36 +0100
Message-Id: <20211206072337.9517-10-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of passing the pointer of a grantmap entry to the
_gntmap_[un]map_grant_ref() sub-functions use the map pointer and the
entry index instead. This will be needed for PVH mode usage.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 gntmap.c | 48 +++++++++++++++++++++++-------------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index f6ab3ad..7ae8fe6 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -55,36 +55,34 @@ struct gntmap_entry {
 };
 
 static inline int
-gntmap_entry_used(struct gntmap_entry *entry)
+gntmap_entry_used(struct gntmap *map, int idx)
 {
-    return entry->host_addr != 0;
+    return map->entries[idx].host_addr != 0;
 }
 
-static struct gntmap_entry*
-gntmap_find_free_entry(struct gntmap *map)
+static int gntmap_find_free_entry(struct gntmap *map)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
-        if (!gntmap_entry_used(&map->entries[i]))
-            return &map->entries[i];
+        if (!gntmap_entry_used(map, i))
+            return i;
     }
 
     DEBUG("(map=%p): all %d entries full",
            map, map->nentries);
-    return NULL;
+    return -1;
 }
 
-static struct gntmap_entry*
-gntmap_find_entry(struct gntmap *map, unsigned long addr)
+static int gntmap_find_entry(struct gntmap *map, unsigned long addr)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
         if (map->entries[i].host_addr == addr)
-            return &map->entries[i];
+            return i;
     }
-    return NULL;
+    return -1;
 }
 
 int
@@ -105,12 +103,13 @@ gntmap_set_max_grants(struct gntmap *map, int count)
 }
 
 static int
-_gntmap_map_grant_ref(struct gntmap_entry *entry, 
+_gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
                       uint32_t domid,
                       uint32_t ref,
                       int writable)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
 
@@ -135,8 +134,9 @@ _gntmap_map_grant_ref(struct gntmap_entry *entry,
 }
 
 static int
-_gntmap_unmap_grant_ref(struct gntmap_entry *entry)
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_unmap_grant_ref op;
     int rc;
 
@@ -160,19 +160,19 @@ int
 gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
 {
     int i, rc;
-    struct gntmap_entry *ent;
+    int idx;
 
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
-        if (ent == NULL) {
+        idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
+        if (idx < 0) {
             printk("gntmap: tried to munmap unknown page\n");
             return -EINVAL;
         }
 
-        rc = _gntmap_unmap_grant_ref(ent);
+        rc = _gntmap_unmap_grant_ref(map, idx);
         if (rc != 0)
             return rc;
     }
@@ -189,7 +189,7 @@ gntmap_map_grant_refs(struct gntmap *map,
                       int writable)
 {
     unsigned long addr;
-    struct gntmap_entry *ent;
+    int idx;
     int i;
 
     DEBUG("(map=%p, count=%" PRIu32 ", "
@@ -206,9 +206,9 @@ gntmap_map_grant_refs(struct gntmap *map,
         return NULL;
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_free_entry(map);
-        if (ent == NULL ||
-            _gntmap_map_grant_ref(ent,
+        idx = gntmap_find_free_entry(map);
+        if (idx < 0 ||
+            _gntmap_map_grant_ref(map, idx,
                                   addr + PAGE_SIZE * i,
                                   domids[i * domids_stride],
                                   refs[i],
@@ -233,15 +233,13 @@ gntmap_init(struct gntmap *map)
 void
 gntmap_fini(struct gntmap *map)
 {
-    struct gntmap_entry *ent;
     int i;
 
     DEBUG("(map=%p)", map);
 
     for (i = 0; i < map->nentries; i++) {
-        ent = &map->entries[i];
-        if (gntmap_entry_used(ent))
-            (void) _gntmap_unmap_grant_ref(ent);
+        if (gntmap_entry_used(map, i))
+            (void) _gntmap_unmap_grant_ref(map, i);
     }
 
     xfree(map->entries);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238646.413647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lk-0000tH-L2; Mon, 06 Dec 2021 07:23:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238646.413647; Mon, 06 Dec 2021 07:23:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lk-0000rp-An; Mon, 06 Dec 2021 07:23:48 +0000
Received: by outflank-mailman (input) for mailman id 238646;
 Mon, 06 Dec 2021 07:23:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Li-0008Mk-PL
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6f610693-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 08A651FD5F;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D17051330B;
 Mon,  6 Dec 2021 07:23:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +KHPMXu6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f610693-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9EBgP/t2UoDrCarm09EUmFu2+s1qFBTeUbKK/KiO/DY=;
	b=BRqj6916g8tEUhYg2upskhF6cz1U43E+S8kWYjh4/UANTdYbnyxixtQ0HloMJ9ZR7FWFOz
	DXxLfY9F/iyeWYFWKluw1kbLFenMDocBRk0rG0hYDlJ3571vIMJADFgot0qLlVzrDxLijz
	Itl0wPxaH91UsJn7gYh4bdUmNigV4iI=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
Date: Mon,  6 Dec 2021 08:23:29 +0100
Message-Id: <20211206072337.9517-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Do some processing of the E820 memory map obtained from the hypervisor:

- align the entries to page boundaries
- sort the entries by their start address
- merge adjacent entries of same type

This is relevant for PVH mode only.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 e820.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/e820.c b/e820.c
index 2165280..336a8b8 100644
--- a/e820.c
+++ b/e820.c
@@ -57,6 +57,60 @@ static char *e820_types[E820_TYPES] = {
     [E820_PMEM]     = "PMEM"
 };
 
+static void e820_remove_entry(int idx)
+{
+    int i;
+
+    e820_entries--;
+    for ( i = idx; i < e820_entries; i++ )
+        e820_map[i] = e820_map[i + 1];
+}
+
+static void e820_swap_entries(int idx1, int idx2)
+{
+    struct e820entry entry;
+
+    entry = e820_map[idx1];
+    e820_map[idx1] = e820_map[idx2];
+    e820_map[idx2] = entry;
+}
+
+static void e820_sanitize(void)
+{
+    int i;
+    unsigned long end;
+
+    /* Adjust map entries to page boundaries. */
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        end = (e820_map[i].addr + e820_map[i].size + PAGE_SIZE - 1) & PAGE_MASK;
+        e820_map[i].addr &= PAGE_MASK;
+        e820_map[i].size = end - e820_map[i].addr;
+    }
+
+    /* Sort entries by start address. */
+    for ( i = 0; i < e820_entries - 1; i++ )
+    {
+        if ( e820_map[i].addr > e820_map[i + 1].addr )
+        {
+            e820_swap_entries(i, i + 1);
+            i = -1;
+        }
+    }
+
+    /* Merge adjacent entries of same type. */
+    for ( i = 0; i < e820_entries - 1; i++ )
+    {
+        if ( e820_map[i].type == e820_map[i + 1].type &&
+             e820_map[i].addr + e820_map[i].size == e820_map[i + 1].addr )
+        {
+            e820_map[i].size += e820_map[i + 1].size;
+            e820_remove_entry(i + 1);
+            i--;
+        }
+    }
+}
+
 static void e820_get_memmap(void)
 {
     long ret;
@@ -71,6 +125,8 @@ static void e820_get_memmap(void)
         do_exit();
     }
     e820_entries = memmap.nr_entries;
+
+    e820_sanitize();
 }
 
 void arch_print_memmap(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238653.413697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lq-00024f-By; Mon, 06 Dec 2021 07:23:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238653.413697; Mon, 06 Dec 2021 07:23:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lp-00022P-PT; Mon, 06 Dec 2021 07:23:53 +0000
Received: by outflank-mailman (input) for mailman id 238653;
 Mon, 06 Dec 2021 07:23:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Lm-0008Mw-GE
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:50 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f396786-5665-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 08:23:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CA4D61FD59;
 Mon,  6 Dec 2021 07:23:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9EF421330B;
 Mon,  6 Dec 2021 07:23:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KKGEJXu6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f396786-5665-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ghs7dH81d+PxzOXZve6mJ+XqQ2rbDs2GA2Tqi5wpJxo=;
	b=OKwKoUrehXPVJyeGD0q7h6PTVg1vpJY4V3WRj8a0M5nmGD2nhxvxM0zF1W8AXCkJDP8y3d
	oipMt3+qVet8MOZX0Swjma4RTLCZ4YGo8jAHf+Dd6ZZzreBpv8tC4xV8TwFfeh6fVsif42
	caXHqF6dCnlRbxGY2ZEk+0wFANnkF0I=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 01/10] mini-os: split e820 map handling into new source file
Date: Mon,  6 Dec 2021 08:23:28 +0100
Message-Id: <20211206072337.9517-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce e820.c containing all the E820 memory map handling.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 Makefile       |   1 +
 arch/arm/mm.c  |   8 ----
 arch/x86/mm.c  |  70 +----------------------------
 e820.c         | 119 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |   6 +++
 5 files changed, 128 insertions(+), 76 deletions(-)
 create mode 100644 e820.c

diff --git a/Makefile b/Makefile
index 4b76b55..06b60fc 100644
--- a/Makefile
+++ b/Makefile
@@ -41,6 +41,7 @@ src-$(CONFIG_TPMFRONT) += tpmfront.c
 src-$(CONFIG_TPM_TIS) += tpm_tis.c
 src-$(CONFIG_TPMBACK) += tpmback.c
 src-y += daytime.c
+src-y += e820.c
 src-y += events.c
 src-$(CONFIG_FBFRONT) += fbfront.c
 src-y += gntmap.c
diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index f806c9f..9068166 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -7,14 +7,6 @@
 #include <lib.h>
 
 uint32_t physical_address_offset;
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
 
 unsigned long allocate_ondemand(unsigned long n, unsigned long alignment)
 {
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8ba14a5..8df93da 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -64,15 +64,6 @@ extern char stack[];
 extern void page_walk(unsigned long va);
 
 #ifdef CONFIG_PARAVIRT
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
-
 void arch_mm_preinit(void *p)
 {
     start_info_t *si = p;
@@ -112,25 +103,11 @@ desc_ptr idt_ptr =
     .base = (unsigned long)&idt,
 };
 
-struct e820entry e820_map[E820_MAX];
-unsigned e820_entries;
-
-static char *e820_types[E820_TYPES] = {
-    [E820_RAM]      = "RAM",
-    [E820_RESERVED] = "Reserved",
-    [E820_ACPI]     = "ACPI",
-    [E820_NVS]      = "NVS",
-    [E820_UNUSABLE] = "Unusable",
-    [E820_PMEM]     = "PMEM"
-};
-
 void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    struct xen_memory_map memmap;
-    int i;
-    unsigned long pfn, max = 0;
+    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -142,53 +119,10 @@ void arch_mm_preinit(void *p)
     }
     last_free_pfn = ret;
 
-    memmap.nr_entries = E820_MAX;
-    set_xen_guest_handle(memmap.buffer, e820_map);
-    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
-    if ( ret < 0 )
-    {
-        xprintk("could not get memory map\n");
-        do_exit();
-    }
-    e820_entries = memmap.nr_entries;
-
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type != E820_RAM )
-            continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
-    }
-
+    max = e820_get_maxpfn();
     if ( max < last_free_pfn )
         last_free_pfn = max;
 }
-
-void arch_print_memmap(void)
-{
-    int i;
-    unsigned long from, to;
-    char *type;
-    char buf[12];
-
-    printk("Memory map:\n");
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
-        {
-            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
-            type = buf;
-        }
-        else
-        {
-            type = e820_types[e820_map[i].type];
-        }
-        from = e820_map[i].addr;
-        to = from + e820_map[i].size - 1;
-        printk("%012lx-%012lx: %s\n", from, to, type);
-    }
-}
 #endif
 
 /*
diff --git a/e820.c b/e820.c
new file mode 100644
index 0000000..2165280
--- /dev/null
+++ b/e820.c
@@ -0,0 +1,119 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/types.h>
+#include <mini-os/lib.h>
+#include <mini-os/console.h>
+#include <mini-os/os.h>
+#include <mini-os/posix/limits.h>
+#include <mini-os/e820.h>
+#include <xen/memory.h>
+
+#ifdef CONFIG_E820_TRIVIAL
+struct e820entry e820_map[1] = {
+    {
+        .addr = 0,
+        .size = ULONG_MAX - 1,
+        .type = E820_RAM
+    }
+};
+
+unsigned e820_entries = 1;
+
+static void e820_get_memmap(void)
+{
+}
+
+#else
+struct e820entry e820_map[E820_MAX];
+unsigned e820_entries;
+
+static char *e820_types[E820_TYPES] = {
+    [E820_RAM]      = "RAM",
+    [E820_RESERVED] = "Reserved",
+    [E820_ACPI]     = "ACPI",
+    [E820_NVS]      = "NVS",
+    [E820_UNUSABLE] = "Unusable",
+    [E820_PMEM]     = "PMEM"
+};
+
+static void e820_get_memmap(void)
+{
+    long ret;
+    struct xen_memory_map memmap;
+
+    memmap.nr_entries = E820_MAX;
+    set_xen_guest_handle(memmap.buffer, e820_map);
+    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
+    if ( ret < 0 )
+    {
+        xprintk("could not get memory map\n");
+        do_exit();
+    }
+    e820_entries = memmap.nr_entries;
+}
+
+void arch_print_memmap(void)
+{
+    int i;
+    unsigned long from, to;
+    char *type;
+    char buf[12];
+
+    printk("Memory map:\n");
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
+        {
+            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
+            type = buf;
+        }
+        else
+        {
+            type = e820_types[e820_map[i].type];
+        }
+        from = e820_map[i].addr;
+        to = from + e820_map[i].size - 1;
+        printk("%012lx-%012lx: %s\n", from, to, type);
+    }
+}
+#endif
+
+unsigned long e820_get_maxpfn(void)
+{
+    int i;
+    unsigned long pfn, max = 0;
+
+    e820_get_memmap();
+
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type != E820_RAM )
+            continue;
+        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        if ( pfn > max )
+            max = pfn;
+    }
+
+    return max;
+}
diff --git a/include/e820.h b/include/e820.h
index 920551c..af2129f 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -24,6 +24,10 @@
 #ifndef __E820_HEADER
 #define __E820_HEADER
 
+#if defined(__arm__) || defined(__aarch64__) || defined(CONFIG_PARAVIRT)
+#define CONFIG_E820_TRIVIAL
+#endif
+
 /* PC BIOS standard E820 types and structure. */
 #define E820_RAM          1
 #define E820_RESERVED     2
@@ -45,4 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
+unsigned long e820_get_maxpfn(void);
+
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238647.413655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Ll-000120-8z; Mon, 06 Dec 2021 07:23:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238647.413655; Mon, 06 Dec 2021 07:23:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lk-0000zi-QB; Mon, 06 Dec 2021 07:23:48 +0000
Received: by outflank-mailman (input) for mailman id 238647;
 Mon, 06 Dec 2021 07:23:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Lj-0008Mw-Ff
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:47 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7022dedf-5665-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 08:23:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0823F1FE04;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D21C21330B;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YC8CMny6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7022dedf-5665-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=jJ0RmLtKB8UkcvX+Y3JuijTbu6nHqV/hpfXxOIuN+R4=;
	b=dNA4rT4w7GOiBlM5Kmz8jsutTtW4O/BdSr4y396zKhGKNlRRf6sRGYOoPEhT9pubzIaxgV
	vUNVo9O8b28ePqjllYVqkYx5QLJLa+NLpclGZLvUJHx6m1m/s2KjJbR4625rUfKAMVbAHh
	hh/ji8MQP/L/ZsLI+F2z3eDzE5ZiHW0=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 07/10] mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
Date: Mon,  6 Dec 2021 08:23:34 +0100
Message-Id: <20211206072337.9517-8-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Having grant table code in arch/x86/mm.c seems wrong. Move it to the
new file arch/x86/gnttab.c, especially as the amount of code is
expected to grow further.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/gnttab.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++
 arch/x86/mm.c     | 47 ----------------------------
 2 files changed, 78 insertions(+), 47 deletions(-)
 create mode 100644 arch/x86/gnttab.c

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
new file mode 100644
index 0000000..56e59d7
--- /dev/null
+++ b/arch/x86/gnttab.c
@@ -0,0 +1,78 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/os.h>
+#include <mini-os/hypervisor.h>
+#include <mini-os/gnttab.h>
+#include <mini-os/mm.h>
+#include <mini-os/types.h>
+
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+    return map_frames(frames, nr_grant_frames);
+}
+
+void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+#ifdef CONFIG_PARAVIRT
+    int i;
+
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte(0x0 << PAGE_SHIFT), UVMF_INVLPG);
+    }
+#endif
+    return;
+}
+
+void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+#ifdef CONFIG_PARAVIRT
+    int i;
+#endif
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+
+#ifdef CONFIG_PARAVIRT
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte((frames[i] << PAGE_SHIFT) | L1_PROT), UVMF_INVLPG);
+    }
+#endif
+}
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index c30d8bc..220c0b4 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -837,53 +837,6 @@ void arch_init_mm(unsigned long* start_pfn_p, unsigned long* max_pfn_p)
 #endif
 }
 
-grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-    return map_frames(frames, nr_grant_frames);
-}
-
-void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-#ifdef CONFIG_PARAVIRT
-    int i;
-
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){0x0<<PAGE_SHIFT}, UVMF_INVLPG);
-    }
-#endif
-    return;
-}
-
-void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-#ifdef CONFIG_PARAVIRT
-    int i;
-#endif
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-
-#ifdef CONFIG_PARAVIRT
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){(frames[i] << PAGE_SHIFT) | L1_PROT}, UVMF_INVLPG);
-    }
-#endif
-}
-
 unsigned long alloc_virt_kernel(unsigned n_pages)
 {
     unsigned long addr;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:23:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:23:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238655.413711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Ls-0002Ka-29; Mon, 06 Dec 2021 07:23:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238655.413711; Mon, 06 Dec 2021 07:23:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Lr-0002GP-3A; Mon, 06 Dec 2021 07:23:55 +0000
Received: by outflank-mailman (input) for mailman id 238655;
 Mon, 06 Dec 2021 07:23:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Ln-0008Mw-G9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f91d96a-5665-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 08:23:42 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6BA2A1FDFB;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F22913A9C;
 Mon,  6 Dec 2021 07:23:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kF8qDny6rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f91d96a-5665-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775420; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fifZXfrZUGkUNpcAkG1BRfuMQBISL/dU4QUsOAzQL4U=;
	b=U7vdUqmDl+BDqN1mx8zjLDu96BhdhcWXq6/5iz61LD62GKIzbUBiD3T/HyEFWp5I49it6z
	uurD1jtDEmFVhZsQBdzctRD1tOjpdvcyPwVmNrxqODmABcUHkwV+WQtC9n7tZATJVMtlNV
	7eUgUf2JwnHICoD2dAJekdXOvvj0zE0=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 04/10] mini-os: respect memory map when ballooning up
Date: Mon,  6 Dec 2021 08:23:31 +0100
Message-Id: <20211206072337.9517-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today Mini-OS won't look at the memory map when ballooning up. This can
result in problems for PVH domains with more than 4 GB of RAM, as
ballooning will happily run into the ACPI area.

Fix that by adding only pages being marked as RAM in the memory map and
by distinguishing between the current number of RAM pages and the first
unallocated page.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/arm/mm.c      |  3 +++
 arch/x86/balloon.c |  4 ++--
 arch/x86/mm.c      |  2 ++
 balloon.c          | 33 ++++++++++++++++++++++++---------
 e820.c             | 21 ++++++++++++++++++++-
 include/balloon.h  |  5 +++--
 include/e820.h     |  1 +
 mm.c               |  7 ++-----
 8 files changed, 57 insertions(+), 19 deletions(-)

diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index 9068166..11962f8 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -3,6 +3,7 @@
 #include <arch_mm.h>
 #include <mini-os/errno.h>
 #include <mini-os/hypervisor.h>
+#include <mini-os/balloon.h>
 #include <libfdt.h>
 #include <lib.h>
 
@@ -70,6 +71,8 @@ void arch_init_mm(unsigned long *start_pfn_p, unsigned long *max_pfn_p)
     }
     device_tree = new_device_tree;
     *max_pfn_p = to_phys(new_device_tree) >> PAGE_SHIFT;
+
+    balloon_set_nr_pages(*max_pfn_p, *max_pfn_p);
 }
 
 void arch_init_demand_mapping_area(void)
diff --git a/arch/x86/balloon.c b/arch/x86/balloon.c
index 10b440c..fe79644 100644
--- a/arch/x86/balloon.c
+++ b/arch/x86/balloon.c
@@ -61,10 +61,10 @@ void arch_remap_p2m(unsigned long max_pfn)
     p2m_invalidate(l2_list, L2_P2M_IDX(max_pfn - 1) + 1);
     p2m_invalidate(l1_list, L1_P2M_IDX(max_pfn - 1) + 1);
 
-    if ( p2m_pages(nr_max_pages) <= p2m_pages(max_pfn) )
+    if ( p2m_pages(nr_max_pfn) <= p2m_pages(max_pfn) )
         return;
 
-    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pages));
+    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pfn));
     for ( pfn = 0; pfn < max_pfn; pfn += P2M_ENTRIES )
     {
         map_frame_rw(new_p2m + PAGE_SIZE * (pfn / P2M_ENTRIES),
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 3bf6170..c30d8bc 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -72,6 +72,7 @@ void arch_mm_preinit(void *p)
     pt_base = (pgentry_t *)si->pt_base;
     first_free_pfn = PFN_UP(to_phys(pt_base)) + si->nr_pt_frames;
     last_free_pfn = si->nr_pages;
+    balloon_set_nr_pages(last_free_pfn, last_free_pfn);
 }
 #else
 #include <mini-os/desc.h>
@@ -118,6 +119,7 @@ void arch_mm_preinit(void *p)
     }
 
     last_free_pfn = e820_get_maxpfn(ret);
+    balloon_set_nr_pages(ret, last_free_pfn);
 }
 #endif
 
diff --git a/balloon.c b/balloon.c
index 5676d3b..80d89c7 100644
--- a/balloon.c
+++ b/balloon.c
@@ -23,14 +23,24 @@
 
 #include <mini-os/os.h>
 #include <mini-os/balloon.h>
+#include <mini-os/e820.h>
 #include <mini-os/errno.h>
 #include <mini-os/lib.h>
 #include <mini-os/paravirt.h>
 #include <xen/xen.h>
 #include <xen/memory.h>
 
-unsigned long nr_max_pages;
-unsigned long nr_mem_pages;
+unsigned long nr_max_pfn;
+
+static unsigned long nr_max_pages;
+static unsigned long nr_mem_pfn;
+static unsigned long nr_mem_pages;
+
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn)
+{
+    nr_mem_pages = pages;
+    nr_mem_pfn = pfn;
+}
 
 void get_max_pages(void)
 {
@@ -46,16 +56,18 @@ void get_max_pages(void)
 
     nr_max_pages = ret;
     printk("Maximum memory size: %ld pages\n", nr_max_pages);
+
+    nr_max_pfn = e820_get_maxpfn(nr_max_pages);
 }
 
 void mm_alloc_bitmap_remap(void)
 {
     unsigned long i, new_bitmap;
 
-    if ( mm_alloc_bitmap_size >= ((nr_max_pages + 1) >> 3) )
+    if ( mm_alloc_bitmap_size >= ((nr_max_pfn + 1) >> 3) )
         return;
 
-    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pages + 1) >> 3));
+    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pfn + 1) >> 3));
     for ( i = 0; i < mm_alloc_bitmap_size; i += PAGE_SIZE )
     {
         map_frame_rw(new_bitmap + i,
@@ -70,7 +82,7 @@ static unsigned long balloon_frames[N_BALLOON_FRAMES];
 
 int balloon_up(unsigned long n_pages)
 {
-    unsigned long page, pfn;
+    unsigned long page, pfn, start_pfn;
     int rc;
     struct xen_memory_reservation reservation = {
         .domid        = DOMID_SELF
@@ -81,8 +93,11 @@ int balloon_up(unsigned long n_pages)
     if ( n_pages > N_BALLOON_FRAMES )
         n_pages = N_BALLOON_FRAMES;
 
+    start_pfn = e820_get_maxpfn(nr_mem_pages + 1) - 1;
+    n_pages = e820_get_max_pages(start_pfn, n_pages);
+
     /* Resize alloc_bitmap if necessary. */
-    while ( mm_alloc_bitmap_size * 8 < nr_mem_pages + n_pages )
+    while ( mm_alloc_bitmap_size * 8 < start_pfn + n_pages )
     {
         page = alloc_page();
         if ( !page )
@@ -99,14 +114,14 @@ int balloon_up(unsigned long n_pages)
         mm_alloc_bitmap_size += PAGE_SIZE;
     }
 
-    rc = arch_expand_p2m(nr_mem_pages + n_pages);
+    rc = arch_expand_p2m(start_pfn + n_pages);
     if ( rc )
         return rc;
 
     /* Get new memory from hypervisor. */
     for ( pfn = 0; pfn < n_pages; pfn++ )
     {
-        balloon_frames[pfn] = nr_mem_pages + pfn;
+        balloon_frames[pfn] = start_pfn + pfn;
     }
     set_xen_guest_handle(reservation.extent_start, balloon_frames);
     reservation.nr_extents = n_pages;
@@ -116,7 +131,7 @@ int balloon_up(unsigned long n_pages)
 
     for ( pfn = 0; pfn < rc; pfn++ )
     {
-        arch_pfn_add(nr_mem_pages + pfn, balloon_frames[pfn]);
+        arch_pfn_add(start_pfn + pfn, balloon_frames[pfn]);
         free_page(pfn_to_virt(nr_mem_pages + pfn));
     }
 
diff --git a/e820.c b/e820.c
index 14fd3cd..50029bb 100644
--- a/e820.c
+++ b/e820.c
@@ -160,7 +160,8 @@ unsigned long e820_get_maxpfn(unsigned long pages)
     int i;
     unsigned long pfns, max = 0;
 
-    e820_get_memmap();
+    if ( !e820_entries )
+        e820_get_memmap();
 
     for ( i = 0; i < e820_entries; i++ )
     {
@@ -176,3 +177,21 @@ unsigned long e820_get_maxpfn(unsigned long pages)
 
     return max;
 }
+
+unsigned long e820_get_max_pages(unsigned long pfn, unsigned long pages)
+{
+    int i;
+    unsigned long end;
+
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type != E820_RAM ||
+             (e820_map[i].addr >> PAGE_SHIFT) > pfn )
+            continue;
+
+        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        return ((end - pfn) > pages) ? pages : end - pfn;
+    }
+
+    return 0;
+}
diff --git a/include/balloon.h b/include/balloon.h
index 6cfec4f..8f7c8bd 100644
--- a/include/balloon.h
+++ b/include/balloon.h
@@ -32,11 +32,11 @@
  */
 #define BALLOON_EMERGENCY_PAGES   64
 
-extern unsigned long nr_max_pages;
-extern unsigned long nr_mem_pages;
+extern unsigned long nr_max_pfn;
 
 void get_max_pages(void);
 int balloon_up(unsigned long n_pages);
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn);
 
 void mm_alloc_bitmap_remap(void);
 void arch_pfn_add(unsigned long pfn, unsigned long mfn);
@@ -50,6 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
 {
     return needed <= nr_free_pages;
 }
+static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
 
 #endif /* CONFIG_BALLOON */
 #endif /* _BALLOON_H_ */
diff --git a/include/e820.h b/include/e820.h
index 6a57f05..49daefa 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -50,5 +50,6 @@ extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
+unsigned long e820_get_max_pages(unsigned long pfn, unsigned long pages);
 
 #endif /*__E820_HEADER*/
diff --git a/mm.c b/mm.c
index 932ceeb..6493bdd 100644
--- a/mm.c
+++ b/mm.c
@@ -396,8 +396,9 @@ void init_mm(void)
 
     printk("MM: Init\n");
 
-    get_max_pages();
     arch_init_mm(&start_pfn, &max_pfn);
+    get_max_pages();
+
     /*
      * now we can initialise the page allocator
      */
@@ -407,10 +408,6 @@ void init_mm(void)
     arch_init_p2m(max_pfn);
     
     arch_init_demand_mapping_area();
-
-#ifdef CONFIG_BALLOON
-    nr_mem_pages = max_pfn;
-#endif
 }
 
 void fini_mm(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:27:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:27:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238674.413741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8PG-0006kK-Ll; Mon, 06 Dec 2021 07:27:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238674.413741; Mon, 06 Dec 2021 07:27:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8PG-0006kD-Il; Mon, 06 Dec 2021 07:27:26 +0000
Received: by outflank-mailman (input) for mailman id 238674;
 Mon, 06 Dec 2021 07:27:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mu8PF-0006k7-GK
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:27:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f50ec011-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:27:24 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-rJ-yQyYxMP2cVt18pJXM-w-1; Mon, 06 Dec 2021 08:27:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 07:27:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 07:27:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P251CA0028.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 07:27:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f50ec011-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638775644;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+IeeCAORjmg3WSBQ6ouUuwSR7asRfORXe50C0iGd6TQ=;
	b=Y5ZqRk8N1dpR7xkSyT0Nqc23q1M08d7kbffGReacqcjhsbYueqJBDNs5sBlA5hVC3oX3Wl
	YmXYKwZZbJW7DzFxgbbh3MMlgX6Ar+8+fEu96QtRFfOf/ZxaZeHu29GugfHv2BFn4/5J46
	rzbtfLk2tGIhaTpI5YQqcNWmK3r/HTU=
X-MC-Unique: rJ-yQyYxMP2cVt18pJXM-w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TmNVKz5jFrTP+lcGqaTIqkxdSbx+nbF8aDh0nOQgJN5N/cObVdLHEasEd2L9inpmyVoV83sHMOmvHFWeGMk6vLWngHOA2lPsZtlSljs0kqQChgs+E402PL7H3pw42QDeU9y+1rqp+PMEevBpCeTc19rCtfJGgyeOCNZ/93JXIyvg9z93l4wbT9o0Ofa2fz5O4dfnyK9bXzTbI/cowL+TH38Vx7YPCOHlnqKrRz6VxC6vzvprJI/6LAKGSM28Fo+r/0lWrHio3WzfQ1d2uWEj/XTOSey1y05iblI7WLzBcLCOTVaWWNMJ5EvH2lxbx7G+QkUZ3O2tMxxp0mV8tY1COg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A+9MgHcc47O3DL0m+Q3Hvp3+k3MJhtMIN8Toor36pMA=;
 b=cR3H2y++6Odz0lqYnaAMfyaxPZ5ARgJtCoAKeUzT8Msm0JIfbHpXe9BOEDXhHS/IvpzuK84Rs1d8Wt1uYd66Dpi2RQvxATf80RN/9HC4nglCUcYsG8SWjzxhyVOab5sxmuRvQyGI7EFAazZhw6tj2yeQsXeaCgykyOpHzQfBbJJwCDwg2O2JuL3sza6qfwCE2ltsjOzpa8Qfn7FlRuEHQBsZC/CtxBPmh0gW4ZeF9Ox46HT/YK5mKKJc74TzTceXK0EQgheYlohH5lADcPqDdeAaXzTenw0znk+K0AYgk0Z+Bhk1MQ2DkuLnjyin/z5gi8VYaLBEpIUOhLvSQQbPGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1a6dd0a2-5a09-d39f-b0b9-c7c33f313403@suse.com>
Date: Mon, 6 Dec 2021 08:27:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Content-Language: en-US
To: Luca Fancellu <luca.fancellu@arm.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <F1FE39BE-191B-4245-84EE-1109B9762B54@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <F1FE39BE-191B-4245-84EE-1109B9762B54@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P251CA0028.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 83acd905-460f-4768-5993-08d9b889d6c6
X-MS-TrafficTypeDiagnostic: VI1PR04MB5903:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5903822FD8DC599F6FA65ED7B36D9@VI1PR04MB5903.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	peuW028Q0V3MOVSrTqaotHXtfpika2pauoONqaKVivK2BWEI/Ab26Zss/1lInT3k/m1j3nRz1slkG6tAIdXSZTcEAsrdoIiOLHk6YEJnShs6E0UKAgN5rqCCQHI93SQB0zt93cjSh2L998AJo/K+rebQo1iKOAD/N7kxazyCAM7yHYYfmC4rPOgFKdU//K1ZC4nugmE4EZxz3jqAcszYbJaxnfskk8dlQ/vU1FDntoWd7cx6VeF9T83uZKRWWlDkDYJuc3uBKO9GLKQC7S1ldf9+J0KA6+DR2Rzvr/vLcOVjY2zmoODRAw35HL7OaA8fPcj7cJ4Vpluj+xEk1ne49CMOeKOlhcmNcv5RUiaLHJlfNV/VxQ/bjWd5pwH0qdqK2x3peWhGNTnQUKQxIa8qdXY/oc0iX3hf/t+GyzA1s0cFVnourJTaQAPt0J1xtIfnNgFiTZiy90tx2us+qjK0tbWpnCyoH4FN/v2vwE/S9+OdzBSHM9HrxII4sqXFVk9U/kdIep9Li+mwO+c3bvUYevyCNCIUA9QvBq4FMeTiXwUG0SLwFG+u2MoIRu5fJ/0XTljsriNRHWNUP44/6ofta6l3U38aYlc2haQEZNp1aGqm+o9OFgXjI6lUtyMqTYcBDYRMEhd/3Vxg8RVN4pdLoJWJBSeVRB8WkRL5tjQKa3DTr/whbCJCy+r0CIg7kZTFY2NFhEA/uTHWeZ7AXMCuIXINAkhtQCRaOnmxh22EB7c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(6916009)(4326008)(2616005)(66556008)(31686004)(508600001)(2906002)(6486002)(31696002)(956004)(16576012)(66946007)(66476007)(8676002)(26005)(316002)(8936002)(5660300002)(186003)(54906003)(53546011)(86362001)(83380400001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e0O9FMreRAmEBbEq61YtGXmrHmBY1curgsQVhA2NEhotoql0mCk/T3137MZ6?=
 =?us-ascii?Q?3wXshfgNZp7CKbdJStVc0GqikHs8aNaf/gSE32TnLgoavjT1eVUk9W577Up8?=
 =?us-ascii?Q?DjKR7cjEMszqLVBJon4WbJnDohRfh11y5DYNph3GYm6uaW6OnnBweibT+o4y?=
 =?us-ascii?Q?Go9gaSSzaUD9t1tvS9VhgD0ViQUbCL24Br0AEvRVcCvn0QPFvbCVeHr2c2qE?=
 =?us-ascii?Q?wwJ0EEpNIgo213Tvz6zS0MZbvB+pBt0BjFzHLWUnr588aTYM74X1v/2RdXn7?=
 =?us-ascii?Q?eqoyp2h0BpgDISdRUj6Yx7Ti21b/zXe54+dlnT55PJYiDZIYyTPkbbsJH4KN?=
 =?us-ascii?Q?EouBIMY1+51iq/PdcFrncDRcjfK/+qgDel1ofbU2fcq0gLZ1OMwjldnLd5cf?=
 =?us-ascii?Q?6iCadxPp7EP9zOEj5/YiDhG7dyOl2tbzQ1eaCxgXas4q7IY1FFwbeCzPTskN?=
 =?us-ascii?Q?56sBybFTcjgUY+SUEzdt38iwuHhL0um//mIIYjjbq5m7QxbXFGH0kV2gaX29?=
 =?us-ascii?Q?yitRkbJEVGvOyNnSPbBebXLYhXFgEFEa0XS1FesX1Ru90DSsfGTPUcxaVTL1?=
 =?us-ascii?Q?ws18i8DRzHugHNR+A8pXpSKHSVflZ20EmurWsZFrU+Awnu4HW7cv/WU7Sm1v?=
 =?us-ascii?Q?fIHdfT19BH0EYMRK24//LADkqcKFvl6LBbv4OGJ/XszNt538kFGNMIn2iuYh?=
 =?us-ascii?Q?YHB2XeAu8zVt1zR7VsXcDdnNj1h7lDb8PWPvEYix2I8C3S+jZ54gWGN5Gpsj?=
 =?us-ascii?Q?F5dH6ww6QAnc7s7xdDveqZu48bBhEqyOn24sTGEoQ5unbloUxc3Q/e7eaWNW?=
 =?us-ascii?Q?0RR9mCT9kF5/71SGqkZcPeXkc+SynNP4SFiFGloDBljTKMcMisIwo311WtcX?=
 =?us-ascii?Q?gT+5ZZIBI+rNAUPwKtyRyIBkoavJsB1NF3M1WAMoBPXiiuHCVvUniZIo6nRm?=
 =?us-ascii?Q?MILTGVSlzhU45r9LKKXuf94Vgkhj8GfJcwt1kIpCmNdCZmlWfduViJgEwAw7?=
 =?us-ascii?Q?D5bOieg8Ioh0ZIwMb369yq6TTNw51YfzlRihu2AWwjpLxkjkIPdKnQs/1/wu?=
 =?us-ascii?Q?IMA/XIWx4eVsZGVNgCnrrgU05dSRhNO1YSrxr/yYYOs3OJkEf8Rjxj8eFnRm?=
 =?us-ascii?Q?JLaHZj4HH7gn4tNarU2FbsdSUhAAatPMwuA8dDNnuB3W7LtxUyp9hUjUHi8d?=
 =?us-ascii?Q?wmWA3TAivqi7nBmxvZzrgaxRwlnO0hQH8KuwzMtfEuhF6Kw0PfnWPhH1I6sg?=
 =?us-ascii?Q?+mPKmmSdMotMaCcycm+OyyiEB8oTf75x244uTJvxAvsEp1XTXgXqxh5bSF9a?=
 =?us-ascii?Q?sIUEYIdbE7l6YdxhTHKu+JtJ1r7vNUeZ0jx2PrMfOTQz/VnVpGplCpRgl3V1?=
 =?us-ascii?Q?x8G9EZ/4p0YALEnLDSabzV+o1RmZBP0/tm81R6CwAuZgNMCZMvrRBcFuKCa4?=
 =?us-ascii?Q?xr0Ivm4K5TnJ2+IAiGINShak6TVH2mMY0FsOIowTEXKT6hlZPDRt02rEQ8zD?=
 =?us-ascii?Q?2ltkUlw1GpRF3CuRvOGPbFtiybh5aKNwao6m1aI+pottgYIlvcMKuvWBMgH2?=
 =?us-ascii?Q?27W13RdWVhZ7oJ1xi/r1A/q5uR7nRreU2YzskYV1QOHa0uEeIvCQNgTQZ4y7?=
 =?us-ascii?Q?b9BFXAFmUM7S/WP73Uxbp/0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 83acd905-460f-4768-5993-08d9b889d6c6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 07:27:20.5468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MEJGIIzL4bEW3CG+FEhisYz6L5SLXi/WDPkRQ9jnIM63+QGtH09WT5Tc1K2R1YKOmMyegu4DgIr37o04HL5jAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903

On 03.12.2021 17:10, Luca Fancellu wrote:
>> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>  immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>=20
> With the =E2=80=9Cconst=E2=80=9D attribute now some function in this seri=
e are above the char line
> limit, however everything looks fine.

I wonder which part of this patch you're referring to. I don't recall any
addition of const here - I think I'm strictly only moving code around some
code and delete some declarations. I've further checked the code being
moved, and I couldn't spot any line going beyond 80 chars.

> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Thanks.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 07:27:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 07:27:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238684.413752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Pl-0007M4-03; Mon, 06 Dec 2021 07:27:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238684.413752; Mon, 06 Dec 2021 07:27:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8Pk-0007Lx-Rb; Mon, 06 Dec 2021 07:27:56 +0000
Received: by outflank-mailman (input) for mailman id 238684;
 Mon, 06 Dec 2021 07:27:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mu8Ln-0008Mk-Q4
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 07:23:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 704d2002-5665-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 08:23:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9B0511FD5F;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6F70C1330B;
 Mon,  6 Dec 2021 07:23:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WBT3GX26rWHVdAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 07:23:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 704d2002-5665-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638775421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=130MnSWpuIXwnTm+cjFHpVCXYuVhbtrRePozwlMpV2g=;
	b=AjWTSxYJ89XHPHLQyeWDS9DruwhbMIEjTvgUQZfbYULENVf01Zk806s0nai32nYXZUYys7
	qzDQHb/ETuvZPzcVy73h72PRM3pubDegRurfcWareknP4FbyHbLW8bKR2Koc1pFcKB6LhU
	dumF55ESzsn9V9MbWQP4ulrTkzxjYag=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 10/10] mini-os: modify grant mappings to work in PVH mode
Date: Mon,  6 Dec 2021 08:23:37 +0100
Message-Id: <20211206072337.9517-11-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

For being able to use the grant mapping interface in PVH mode some
changes are required, as the guest needs to specify a physical address
in the hypercall interface.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 gntmap.c         | 81 ++++++++++++++++++++++++++++++++++--------------
 include/gntmap.h |  1 +
 2 files changed, 59 insertions(+), 23 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index 7ae8fe6..126b04f 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -32,6 +32,7 @@
 
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
+#include <mini-os/e820.h>
 #include <mini-os/xmalloc.h>
 #include <errno.h>
 #include <xen/grant_table.h>
@@ -97,11 +98,42 @@ gntmap_set_max_grants(struct gntmap *map, int count)
     if (map->entries == NULL)
         return -ENOMEM;
 
+#ifndef CONFIG_PARAVIRT
+    map->start_pfn = e820_get_reserved_pfns(count);
+#endif
+
     memset(map->entries, 0, sizeof(struct gntmap_entry) * count);
     map->nentries = count;
     return 0;
 }
 
+static int
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
+{
+    struct gntmap_entry *entry = map->entries + idx;
+    struct gnttab_unmap_grant_ref op;
+    int rc;
+
+#ifdef CONFIG_PARAVIRT
+    op.host_addr    = (uint64_t) entry->host_addr;
+#else
+    op.host_addr    = (uint64_t)(map->start_pfn + idx) << PAGE_SHIFT;
+#endif
+    op.dev_bus_addr = 0;
+    op.handle       = entry->handle;
+
+    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
+    if (rc != 0 || op.status != GNTST_okay) {
+        printk("GNTTABOP_unmap_grant_ref failed: "
+               "returned %d, status %" PRId16 "\n",
+               rc, op.status);
+        return rc != 0 ? rc : op.status;
+    }
+
+    entry->host_addr = 0;
+    return 0;
+}
+
 static int
 _gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
@@ -112,10 +144,17 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
     struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
+#ifndef CONFIG_PARAVIRT
+    unsigned long pfn = map->start_pfn + idx;
+#endif
 
     op.ref = (grant_ref_t) ref;
     op.dom = (domid_t) domid;
+#ifdef CONFIG_PARAVIRT
     op.host_addr = (uint64_t) host_addr;
+#else
+    op.host_addr = (uint64_t)pfn << PAGE_SHIFT; 
+#endif
     op.flags = GNTMAP_host_map;
     if (!writable)
         op.flags |= GNTMAP_readonly;
@@ -128,31 +167,18 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
         return rc != 0 ? rc : op.status;
     }
 
-    entry->host_addr = host_addr;
-    entry->handle = op.handle;
-    return 0;
-}
-
-static int
-_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
-{
-    struct gntmap_entry *entry = map->entries + idx;
-    struct gnttab_unmap_grant_ref op;
-    int rc;
-
-    op.host_addr    = (uint64_t) entry->host_addr;
-    op.dev_bus_addr = 0;
-    op.handle       = entry->handle;
-
-    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
-    if (rc != 0 || op.status != GNTST_okay) {
-        printk("GNTTABOP_unmap_grant_ref failed: "
-               "returned %d, status %" PRId16 "\n",
-               rc, op.status);
-        return rc != 0 ? rc : op.status;
+#ifndef CONFIG_PARAVIRT
+    rc = do_map_frames(host_addr, &pfn, 1, 0, 0, DOMID_SELF, NULL,
+                       writable ? L1_PROT : L1_PROT_RO);
+    if ( rc )
+    {
+        _gntmap_unmap_grant_ref(map, idx);
+        return rc;
     }
+#endif
 
-    entry->host_addr = 0;
+    entry->host_addr = host_addr;
+    entry->handle = op.handle;
     return 0;
 }
 
@@ -165,6 +191,10 @@ gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
+#ifndef CONFIG_PARAVIRT
+    unmap_frames(start_address, count);
+#endif
+
     for (i = 0; i < count; i++) {
         idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
         if (idx < 0) {
@@ -242,6 +272,11 @@ gntmap_fini(struct gntmap *map)
             (void) _gntmap_unmap_grant_ref(map, i);
     }
 
+#ifndef CONFIG_PARAVIRT
+    e820_put_reserved_pfns(map->start_pfn, map->nentries);
+    map->start_pfn = 0;
+#endif
+
     xfree(map->entries);
     map->entries = NULL;
     map->nentries = 0;
diff --git a/include/gntmap.h b/include/gntmap.h
index fde53f3..d3d7e88 100644
--- a/include/gntmap.h
+++ b/include/gntmap.h
@@ -10,6 +10,7 @@
 struct gntmap {
     int nentries;
     struct gntmap_entry *entries;
+    unsigned long start_pfn;
 };
 
 int
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 08:04:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 08:04:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238725.413766 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8yp-0004Jf-VG; Mon, 06 Dec 2021 08:04:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238725.413766; Mon, 06 Dec 2021 08:04:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu8yp-0004JY-Rj; Mon, 06 Dec 2021 08:04:11 +0000
Received: by outflank-mailman (input) for mailman id 238725;
 Mon, 06 Dec 2021 08:04:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mu8yo-0004JS-Co
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 08:04:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 16c498dd-566b-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 09:04:08 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-qjOV47uONoCzoVhU2hU87A-1; Mon, 06 Dec 2021 09:04:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 08:04:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 08:04:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR2P281CA0019.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 08:04:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16c498dd-566b-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638777848;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=QHy3Po9Hq6NQybQT3MQiEqo9cdlBS05cCFyBDEiqRxU=;
	b=fS8ufosaR0YE0CZnPnVbonXYPGPiks7KQafJRIwactf7qpV8ntVUeEPQTduGv0JqcvEjt/
	GPQimsxsPQlJ+P3YRHdFOnyB/cUNiMnWVTm2EZLZu0GvtHJaCffD3cAsp59o/hTTHFBZ6b
	1Zde+ifImSZf8Z6cEV0EwmGd06M5JxQ=
X-MC-Unique: qjOV47uONoCzoVhU2hU87A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mA0MuzyQimkgducQ1NJkFK+oPyUa7YRPkDULK4UXTD4up0V0QnCiVMaXgN340lNyGmbtz5TfkKUIrkC5IO+aG0CRgwdOjeclQUPQKE/dkUzW8FWgZ9B4k+RTGEsja4U53PhZWXeJm77L753U95S9qe2jZcig3q5sAMilI/DDXp0POmz5D0CsMaELF4HMhF0q1Rk7CNOGwZZ4Fjot1H7iIED78OhzEKP+uocIQWW/wcUpEU1cW/MgtnrtQLPd5CMR6l6t+dLQxmvDYpP42JrbszHQaces11EndyEhnS9zWZUf/eTnXzz+cLz01gQlf143GRJ9/lVej8jyf9WXCvMF0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9J+hbBIj1avDe+Vi9V13D4/4hloqmCBy6Qf5jdxfXmc=;
 b=iOluXtM5sNf0gEuAw1IJBATaea+hVYqIwn4ibNF4/WT2l7SBsnpSzW0g6m/ixlDO8/vnfQaI4iK3HAgnqbxr5cKTlVcTtLGkmerLB1yWoQaZjFgug6Rrc7uZSWuPhUuGtoFWgUHGoLio31DK5xkdQ+ILv8oRIFw4F4LUjUTFYH6AT7XBxxg2EysnLtJp0pXhGsnG+HWWEsk90cFzs2gmsLvai22qywShNg8oezUf4rFqQ3C52/PhU+wasAS/J3P70FVJ/aQcAcdovBsswByWdc5RFiNhZ1LUc7uej6exv5BuC9F4nJ9lNesyOvGPCVv34NFiLjThlvVz1FNjA/i4TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5afac577-ec37-8a66-b144-0ce9d7d40f1c@suse.com>
Date: Mon, 6 Dec 2021 09:04:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 59.5/65] x86: Introduce helpers/checks for endbr64
 instructions
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163340.26714-1-andrew.cooper3@citrix.com>
 <e5da1903-20bc-4523-9d0a-6071f117c3ce@suse.com>
 <ef297668-96ba-851d-2990-179f6dcb9f37@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ef297668-96ba-851d-2990-179f6dcb9f37@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR2P281CA0019.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:14::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 90618400-7963-435e-666a-08d9b88ef9c1
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533F49442ECE3C2C14BAC8DB36D9@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gqas9F5PA0K3+a3HH7zfe1FPadxQVKT8QEM7L1CwgxK1U+X2afJSLbDICqKVKY7vajZYmyDzpAAU2PkHGEGorZ6XRZm+PALJTDAhAl5lP/Pk0EzkM6XuZH6cOoPUGbDj4npuJoKyJKI6pxZhZA0jVWuX7GzYg2tvra7H4gF/N+ilNgyZ6ahkrJjAynfN+n74Dcl3SlNUvlZVQxNZc2+QKHrxMchFOWYeOqYOXZTE3zYBvewJoWQyBdNnv+J5bLm5xeGembz+PbN7DtTnGZWFXpxmTGG4a6/zKzQ+i6HuR6NRIr/P92ejcz7qW2tA6aWYyRp0prf6W7FY2asffSjOGFesJ8jumGveDULrqlqJp67O8yvZW8Zner4tEvj9+YxtA6GMfO/RDob5LyFEWIhSLE6tqmWaZUnmdHcrgwQUdvZUxt2vJ04fYYqj7ON+G273aBAbNECLVzgL1sQ5LcKOJgPvrvie+/edF6KgIlpj+xS2IvjLDfac3SPDl0B7ESGBUBdWCcshjfhgV6IxFFRCnQgw2/GpiABsQhT3p5E+xd/s2W/sp1xI/9RATPXrRVrk/z6P88LFidTYX6ve4OXopvszHSNhMl0cKaZGILlUNjnJqB/ht70Y9RLDkPrx8wNqoNogGhIrKsm6W/BNuNuFhLT9eMgTXVpXM62ASNMZ93Zo5ihU1wUzgXmAmyH1qccyztS2Tpc4BfRd/R1j1baLEm5B3ja9VZW55BSrKxrFHtw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(66946007)(54906003)(8676002)(8936002)(110136005)(4326008)(53546011)(2906002)(186003)(26005)(36756003)(956004)(2616005)(5660300002)(86362001)(6486002)(31696002)(508600001)(83380400001)(316002)(16576012)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iWKg6mxApkUxtgDBJ3lAGF7eJAxEIWk9iRC7YeqC9B/03/xUZ+7aVFTXI5Jr?=
 =?us-ascii?Q?k2sxaK0V5r7sNkxaPy5G8vq8Nel1togquhT0N5YZjBPqC/d7+ZUNRkyfKpR7?=
 =?us-ascii?Q?eeudntFjXUCH+xxoV0fM60jesJ14zlOoEza+NmwBfdH+D5wDoIGyQBPL7h/y?=
 =?us-ascii?Q?G6KhFPKpcjMf6I/OiU7OeeyQ57kF26azkEFzc338qLslwEOsILyrhhKciapR?=
 =?us-ascii?Q?RSbcS9PBIjv0h/MPz0FRY2PVBRklwcdT3VATvMjCGk9Nkzku8LYpOkiuSu61?=
 =?us-ascii?Q?F+vHjd5uYY5YD4tCjOWLDbMcYZvuKW80lxR4hhEQoWIJ4uuoc/COdCkN8mFF?=
 =?us-ascii?Q?gn+9r0D5GVm7HuXANkpIgSU+tRXutIc+Di4EoyCGLdljZl0Bf/7ARMFPUoRU?=
 =?us-ascii?Q?TvoztDoMNJGzjmIX+fzHKQbxBqS+mYyMLk2/aVbCLhyani4L87uEc3IMfeaO?=
 =?us-ascii?Q?J0cfsfBor20AR2uuIPnZ66eokg4ldURzEtwZP+iKiWKYQd92mIhq7IqNeW99?=
 =?us-ascii?Q?GuC9X/NU5W9vGBl3H9iJHg7D/ejd0IZdrKAsvvcEOGDw2C34NT9EUC2Kxn2i?=
 =?us-ascii?Q?XYtl/c8lPrMJAWIYYRJLFo1v6LrAOQvFKk4putMYBHKU20t7EkpnxNnOJwyg?=
 =?us-ascii?Q?rN9fhD04vDmzquYibevxbv06p5gVPY48nUbSV6PSPWZnTD+ZCfqb/qOkx4ZN?=
 =?us-ascii?Q?xVKkx/w7An3luB5JzSpq2TZSHA6C9VnPkJYtfkLp88TyuyiyIxZ4adFpAPYe?=
 =?us-ascii?Q?yylBuJ4FiAwYNvOV0IkPW1v4N6xfKeyv2rSFWUE0lv5ftdIQbMIjl/ep2Qk5?=
 =?us-ascii?Q?aqnJiBxoxoXciOhmiMmMma0j3o4SZXPFbVLPhWNEVIwAC7TlMKUmlfDWPQUw?=
 =?us-ascii?Q?6SmwWM2I9OmLBxU1Twdhj+IOpSvVpUsJtdh+8C+4o6grks83OavFoj8iGmdC?=
 =?us-ascii?Q?xvHhZ6j9cXVCjzNwTMilJ3cpnkh5nq83EMNC6ZygZFEDh+tHsT9c7SR58cle?=
 =?us-ascii?Q?8863niXKa9CLU1qEsKsxSk20I21sZAPDesSxuaOmSl13MQzuUqUuoAcnhfJl?=
 =?us-ascii?Q?+QS/XyOGitwaaK6T6o8BbGRRtwBfYRdVHRqSqXPbGgF4C17kYu4gsH1MmiGO?=
 =?us-ascii?Q?BswKIWFvcomc1KKIQn1/gmjp/h0vaAkP0PMtR6LYqSkIawRDdzXVcHlMDwa3?=
 =?us-ascii?Q?5uyb3MdHQDLAggDKN/F2zLSV6snUtFMBPy/JarhPcpqEIzGu/imKKNhJMvX3?=
 =?us-ascii?Q?/79BN+NUHn45WyCx31TUum22SQBRYU0c7lY8iW/hCW+4eqgTIUEuM3/bH8dT?=
 =?us-ascii?Q?BOaWLyutEpM3QfRpcg7J6kEpzhMkNgSbOzPWg9wC7qlMEo6gPi/qr1kiwoHY?=
 =?us-ascii?Q?1LbKv4L7ggIY5JAra3G6O1zwr/QYvYnLSfPU75vW4UM+fS7732FSxd8EKUDD?=
 =?us-ascii?Q?5Miz0O+Wrk86D3wZ+yox3DymX+ki6gPXJRpDevlq+0539hivyvOBtkGHRQtg?=
 =?us-ascii?Q?Zu6msH6BP6R/enXOj+o8fs4gsc5cJFpkL9TvVHVmFl/SpaVhIv/MA5+PAGVu?=
 =?us-ascii?Q?kEstj+/VpmSw+/kRbDgu8Fx6rlMk45xqGohchW8PZkaGWpvuxWB4vFd2lR0h?=
 =?us-ascii?Q?RZdj+0R6vPYrTGW1jNC/pJE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90618400-7963-435e-666a-08d9b88ef9c1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 08:04:06.6123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HzNdrhOZDcQyC3OOIIm/MbK4e5z3FiwA2dOQYsjoDEHFtRT8c0IzK2f0SRrnLoHB4an4ssVWUwf2Mq/aXBthZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 03.12.2021 15:10, Andrew Cooper wrote:
> On 03/12/2021 13:59, Jan Beulich wrote:
>> On 26.11.2021 17:33, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/Makefile
>>> +++ b/xen/arch/x86/Makefile
>>> @@ -190,6 +190,10 @@ $(TARGET)-syms: prelink.o xen.lds
>>>  	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y=3D $(@D)/.$(@F).1.o
>>>  	$(LD) $(XEN_LDFLAGS) -T xen.lds -N prelink.o $(build_id_linker) \
>>>  	    $(@D)/.$(@F).1.o -o $@
>>> +ifeq ($(CONFIG_XEN_IBT),y)
>>> +	$(OBJDUMP) -d $@ | grep 0xfa1e0ff3 >/dev/null && \
>>> +		{ echo "Found embedded endbr64 instructions" >&2; false; } || :
>> I guess I'm confused: The "false;" suggests to me you want to make the
>> build fail in such a case. The "|| :" otoh suggests you want to silence
>> errors (and not just the one from grep when not finding the pattern
>> aiui).
>=20
> The exit code of grep needs inverting for the build to proceed
> correctly.=C2=A0 Without || :, all builds fail when they've not got the p=
attern.

But doesn't this invert not only failure of grep, but also the
unconditional "failure" of "false"? IOW doesn't this step therefore
always succeed, making the message merely a warning-like one? Or if
that's the intended behavior, what's the "false" good for?

>> Also isn't passing -q to grep standard enough (and shorter) to use in
>> place of redirecting its output to /dev/null?
>=20
> That caused problems on the BSDs.=C2=A0 c/s e632d56f0f5 went through seve=
ral
> iterations before settling on this pattern.

Odd. The commit message doesn't mention any of this. v2 of that patch
already didn't use -q, and also doesn't identify a respective change
from v1. I wasn't able to locate v1.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 08:36:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 08:36:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238736.413777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9UG-00085z-Cr; Mon, 06 Dec 2021 08:36:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238736.413777; Mon, 06 Dec 2021 08:36:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9UG-00085s-9q; Mon, 06 Dec 2021 08:36:40 +0000
Received: by outflank-mailman (input) for mailman id 238736;
 Mon, 06 Dec 2021 08:31:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/ULk=QX=actia.se=jonas.blixt@srs-se1.protection.inumbo.net>)
 id 1mu9Pj-00081Y-Ki
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 08:31:59 +0000
Received: from mail.actia.se (mail.actia.se [195.67.112.82])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f98b6ed0-566e-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 09:31:57 +0100 (CET)
Received: from S036ANL.actianordic.se (192.168.16.117) by
 S036ANL.actianordic.se (192.168.16.117) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.17; Mon, 6 Dec 2021 09:31:56 +0100
Received: from S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69]) by
 S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69%3]) with mapi id
 15.01.2375.017; Mon, 6 Dec 2021 09:31:56 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f98b6ed0-566e-11ec-8a4d-196798b21f7b
From: Jonas Blixt <jonas.blixt@actia.se>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: XEN CAN Driver
Thread-Topic: XEN CAN Driver
Thread-Index: AQHX6nupqGV1RK1HBkO11DPjYT8S6w==
Date: Mon, 6 Dec 2021 08:31:56 +0000
Message-ID: <5a2d079fe8db41338464381dd2dc9575@actia.se>
Accept-Language: en-US, sv-SE
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.11.250.22]
x-esetresult: clean, is OK
x-esetid: 37303A29D82D1F50627660
Content-Type: multipart/mixed;
	boundary="_004_5a2d079fe8db41338464381dd2dc9575actiase_"
MIME-Version: 1.0

--_004_5a2d079fe8db41338464381dd2dc9575actiase_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hello XEN developers,

We're working on a virtualized CAN driver for XEN (PV-CAN) with the intenti=
on to upstream the patches.
In our project we use the PV CAN driver to expose a pysical CAN interface t=
o domU. We use cangw in
dom0 for routing between the physical interface and the PV CAN interface.

The driver implements two rings, a tx and rx ring for sending CAN frames be=
tween dom0 and domU.
It uses three interrupts, one for indicating to domU that there are frames =
to be processed in the tx ring,
one for the other way around to indicate to dom0 that domU has transmitted =
a can frame and=A0
the third to implement flow control in domU.

We're unsure if we are using the RING_ -macros the way it's intended. For e=
xample, before
writing to the rx ring we want to check if there is enough available space =
in that ring.
This is how we currently do that:

=A0=A0=A0 if (abs(priv->rx_ring.sring->req_prod - priv->rx_ring.sring->req_=
event)
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 >=3D RING_SIZE(&priv->rx_ring)-2) {

This seems wrong but at least works. The macros we tried first (RING_FREE_R=
EQUESTS and RING_FULL)=A0
does not seem to work for us and that might be an indication we're not usin=
g the RING -macros correctly.

The backend driver has one callback for receiving can frames from the inter=
face in
dom0 (pvcan_tx) and one interrupt handler for receiving frames from domU (p=
vcan_interrupt_rx).
The frontend driver has a similar setup.=A0

When we are sending frames to domU we're using the RING_GET_RESPONSE macro =
to allocate space
in the tx_ring and in the frontend driver(pvcan_interrupt) we're also using=
 the RING_GET_RESPONSE
to receive the same frame. However in the other direction we're using RING_=
GET_REQUEST.
I think we needed to have this setup to get the interrupts between dom0 and=
 domU.

Should we use two different rings for full duplex communication or is one r=
ing enough? I suppose if
we only used one ring the RESPONSE/REQUEST macros make more sense, I imagin=
e that
the front end would always allocate and write RESPONSES and the backend wou=
ld allocate and write
REQUESTS.

Another curious thing we did to get this working is in the pvcan_interrupt_=
rx (backend). When we
receive frames using the RING_GET_REQUEST we also call RING_GET_RESPONSE. T=
his
is the result of trial and error so I can't justify it beyond: if we did no=
t have this the ring would stall.


Any guidance on how a reasonable ring buffer setup should look like in this=
 kind of driver=A0
would be greatly appreciated.

Best Regards
Jonas

--_004_5a2d079fe8db41338464381dd2dc9575actiase_
Content-Type: text/x-chdr; name="pvcan.h"
Content-Description: pvcan.h
Content-Disposition: attachment; filename="pvcan.h"; size=480;
	creation-date="Mon, 06 Dec 2021 08:31:37 GMT";
	modification-date="Mon, 06 Dec 2021 08:31:37 GMT"
Content-Transfer-Encoding: base64

I2lmbmRlZiBfX1hFTl9QVUJMSUNfSU9fUFZDQU5fSF9fCiNkZWZpbmUgX19YRU5fUFVCTElDX0lP
X1BWQ0FOX0hfXwoKI2luY2x1ZGUgPGxpbnV4L2Nhbi5oPgojaW5jbHVkZSAicmluZy5oIgoKc3Ry
dWN0IHB2Y2FuX3JlcXVlc3QKewogICAgc3RydWN0IGNhbmZkX2ZyYW1lIGNmZDsKfTsKCnN0cnVj
dCBwdmNhbl9yZXNwb25zZQp7CiAgICBzdHJ1Y3QgY2FuZmRfZnJhbWUgY2ZkOwp9OwoKREVGSU5F
X1JJTkdfVFlQRVMoeGVuX3B2Y2FuX3J4LCBzdHJ1Y3QgcHZjYW5fcmVxdWVzdCwKICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgcHZjYW5fcmVzcG9uc2UpOwpERUZJTkVfUklO
R19UWVBFUyh4ZW5fcHZjYW5fdHgsIHN0cnVjdCBwdmNhbl9yZXF1ZXN0LAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBwdmNhbl9yZXNwb25zZSk7CgojZW5kaWYgIC8vIF9f
WEVOX1BVQkxJQ19JT19QVkNBTl9IX18K

--_004_5a2d079fe8db41338464381dd2dc9575actiase_
Content-Type: text/x-csrc; name="xen-pvcan-front.c"
Content-Description: xen-pvcan-front.c
Content-Disposition: attachment; filename="xen-pvcan-front.c"; size=12130;
	creation-date="Mon, 06 Dec 2021 08:31:38 GMT";
	modification-date="Mon, 06 Dec 2021 08:31:38 GMT"
Content-Transfer-Encoding: base64

I2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgojaW5jbHVkZSA8bGludXgva2VybmVsLmg+CiNpbmNs
dWRlIDx4ZW4veGVuLmg+CiNpbmNsdWRlIDx4ZW4veGVuYnVzLmg+CiNpbmNsdWRlIDx4ZW4vZXZl
bnRzLmg+CiNpbmNsdWRlIDx4ZW4vaW50ZXJmYWNlL2lvL3JpbmcuaD4KI2luY2x1ZGUgPHhlbi9p
bnRlcmZhY2UvaW8vcHZjYW4uaD4KI2luY2x1ZGUgPGxpbnV4L2lmX2FycC5oPgojaW5jbHVkZSA8
bGludXgvaWZfZXRoZXIuaD4KI2luY2x1ZGUgPGxpbnV4L2Nhbi5oPgojaW5jbHVkZSA8bGludXgv
Y2FuL2Rldi5oPgojaW5jbHVkZSA8bGludXgvY2FuL3NrYi5oPgojaW5jbHVkZSA8eGVuL2dyYW50
X3RhYmxlLmg+CiNpbmNsdWRlIDxuZXQvcnRuZXRsaW5rLmg+CiNpbmNsdWRlIDx4ZW4vcGFnZS5o
PgoKc3RydWN0IHB2Y2FuX3ByaXZhdGUKewogICAgc3RydWN0IGNhbl9wcml2IGNhbjsJCS8qIG11
c3QgYmUgdGhlIGZpcnN0IG1lbWJlciEgKi8KICAgIHN0cnVjdCB4ZW5idXNfZGV2aWNlICp4ZW5k
ZXY7CiAgICBzdHJ1Y3QgbmV0X2RldmljZSAqY2FuZGV2OwogICAgaW50IGlycTsKICAgIHVuc2ln
bmVkIGludCBldnRjaG5fcng7CiAgICB1bnNpZ25lZCBpbnQgZXZ0Y2huX3R4OwogICAgLyogUlgg
UmluZyAoSW5wdXQgdG8gZG9tMCkgKi8KCXN0cnVjdCB4ZW5fcHZjYW5fcnhfZnJvbnRfcmluZyBy
eF9yaW5nOwogICAgZ3JhbnRfcmVmX3QgcnhfcmluZ19yZWY7CiAgICAvKiBUWCBSaW5nIChPdXRw
dXQgZnJvbSBkb20wKSovCglzdHJ1Y3QgeGVuX3B2Y2FuX3R4X2Zyb250X3JpbmcgdHhfcmluZzsK
ICAgIGdyYW50X3JlZl90IHR4X3JpbmdfcmVmOwp9OwoKc3RhdGljIG5ldGRldl90eF90IHB2Y2Fu
X3R4KHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBuZXRfZGV2aWNlICpkZXYpCnsKICAgIHN0
cnVjdCBjYW5fZnJhbWUgKmNmZCA9IChzdHJ1Y3QgY2FuX2ZyYW1lICopIHNrYi0+ZGF0YTsKICAg
IHN0cnVjdCBuZXRfZGV2aWNlX3N0YXRzICpzdGF0cyA9ICZkZXYtPnN0YXRzOwogICAgc3RydWN0
IHB2Y2FuX3ByaXZhdGUgKnByaXYgPSBuZXRkZXZfcHJpdihkZXYpOwogICAgc3RydWN0IHB2Y2Fu
X3JlcXVlc3QgKnJlcTsKICAgIGJvb2wgbm90aWZ5OwoKICAgIGlmIChjYW5fZHJvcHBlZF9pbnZh
bGlkX3NrYihkZXYsIHNrYikpCiAgICB7CiAgICAgICAgcHJpbnRrKCJjYW5fZHJvcHBlZF9pbnZh
bGlkX3NrYlxuIik7CiAgICAgICAgc3RhdHMtPnR4X2Ryb3BwZWQrKzsKICAgICAgICByZXR1cm4g
TkVUREVWX1RYX09LOwogICAgfQoKICAgIC8vIE5lZWQgdG8gd2FpdCBzbyB0aGF0IHdlIGRvbid0
IG92ZXJmbG93IHRoZSBzaGFyZWQgcmluZyBidWZmZXIuCiAgICBpZiAoYWJzKHByaXYtPnJ4X3Jp
bmcuc3JpbmctPnJlcV9wcm9kIC0gcHJpdi0+cnhfcmluZy5zcmluZy0+cmVxX2V2ZW50KQogICAg
ICAgICA+PSBSSU5HX1NJWkUoJnByaXYtPnJ4X3JpbmcpLTIpIHsKICAgICAgICBuZXRpZl9zdG9w
X3F1ZXVlKGRldik7CiAgICB9CgoJcmVxID0gUklOR19HRVRfUkVRVUVTVCgmcHJpdi0+cnhfcmlu
ZywgcHJpdi0+cnhfcmluZy5yZXFfcHJvZF9wdnQpOwoKICAgIHN0YXRzLT50eF9wYWNrZXRzKys7
CiAgICBzdGF0cy0+dHhfYnl0ZXMgKz0gY2ZkLT5jYW5fZGxjOwoKICAgIGJhcnJpZXIoKTsKICAg
IG1lbWNweSgmcmVxLT5jZmQsIGNmZCwgc2l6ZW9mKCpjZmQpKTsKICAgIHdtYigpOwoKCXByaXYt
PnJ4X3JpbmcucmVxX3Byb2RfcHZ0Kys7CglSSU5HX1BVU0hfUkVRVUVTVFNfQU5EX0NIRUNLX05P
VElGWSgmcHJpdi0+cnhfcmluZywgbm90aWZ5KTsKCiAgICBpZiAobm90aWZ5KQogICAgICAgIG5v
dGlmeV9yZW1vdGVfdmlhX2V2dGNobihwcml2LT5ldnRjaG5fcngpOwoKICAgIGNvbnN1bWVfc2ti
KHNrYik7CgogICAgcmV0dXJuIE5FVERFVl9UWF9PSzsKfQoKc3RhdGljIGlycXJldHVybl90IHR4
cXVldWVfcmVhZHlfaW50ZXJydXB0KGludCBkdW1teSwgdm9pZCAqZGF0YSkKewogICAgc3RydWN0
IHB2Y2FuX3ByaXZhdGUgKnByaXYgPSBkYXRhOwogICAgc3RydWN0IG5ldF9kZXZpY2UgKmNhbmRl
diA9IHByaXYtPmNhbmRldjsKICAgIG5ldGlmX3dha2VfcXVldWUoY2FuZGV2KTsKICAgIHJldHVy
biBJUlFfSEFORExFRDsKfQoKc3RhdGljIGludCBwdmNhbl9jaGFuZ2VfbXR1KHN0cnVjdCBuZXRf
ZGV2aWNlICpkZXYsIGludCBuZXdfbXR1KQp7CiAgICAvKiBEbyBub3QgYWxsb3cgY2hhbmdpbmcg
dGhlIE1UVSB3aGlsZSBydW5uaW5nICovCiAgICBpZiAoZGV2LT5mbGFncyAmIElGRl9VUCkKICAg
ICAgICByZXR1cm4gLUVCVVNZOwoKICAgIGlmIChuZXdfbXR1ICE9IENBTl9NVFUgJiYgbmV3X210
dSAhPSBDQU5GRF9NVFUpCiAgICAgICAgcmV0dXJuIC1FSU5WQUw7CgogICAgZGV2LT5tdHUgPSBu
ZXdfbXR1OwogICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyBpbnQgcHZjYW5fb3BlbihzdHJ1Y3QgbmV0
X2RldmljZSAqZGV2KQp7CiAgICBpZiAoIW5ldGlmX2NhcnJpZXJfb2soZGV2KSkKICAgICAgICAg
ICAgbmV0aWZfY2Fycmllcl9vbihkZXYpOwoKICAgIG5ldGlmX3N0YXJ0X3F1ZXVlKGRldik7Cgog
ICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyBpbnQgcHZjYW5fc3RvcChzdHJ1Y3QgbmV0X2RldmljZSAq
ZGV2KQp7CiAgICBuZXRpZl9zdG9wX3F1ZXVlKGRldik7CiAgICByZXR1cm4gMDsKfQoKc3RhdGlj
IGNvbnN0IHN0cnVjdCBuZXRfZGV2aWNlX29wcyBwdmNhbl9uZXRkZXZfb3BzID0KewogICAgLm5k
b19vcGVuID0gcHZjYW5fb3BlbiwKICAgIC5uZG9fc3RvcCA9IHB2Y2FuX3N0b3AsCiAgICAubmRv
X3N0YXJ0X3htaXQgPSBwdmNhbl90eCwKICAgIC5uZG9fY2hhbmdlX210dSA9IHB2Y2FuX2NoYW5n
ZV9tdHUsCn07CgovKiBJbnB1dCBDQU4gZnJhbWVzIGZyb20gYmFja2VuZCAqLwpzdGF0aWMgaXJx
cmV0dXJuX3QgcHZjYW5faW50ZXJydXB0KGludCBkdW1teSwgdm9pZCAqZGF0YSkKewogICAgc3Ry
dWN0IHB2Y2FuX3ByaXZhdGUgKnByaXYgPSBkYXRhOwogICAgc3RydWN0IG5ldF9kZXZpY2UgKmNh
bmRldiA9IHByaXYtPmNhbmRldjsKICAgIHN0cnVjdCBuZXRfZGV2aWNlX3N0YXRzICpzdGF0cyA9
ICZjYW5kZXYtPnN0YXRzOwogICAgUklOR19JRFggcmNvbnMsIHJwcm9kOwogICAgc3RydWN0IHNr
X2J1ZmYgKnNrYjsKICAgIHN0cnVjdCBjYW5fZnJhbWUgKm5ld19jZmQ7CiAgICBzdHJ1Y3QgcHZj
YW5fcmVzcG9uc2UgKnJzcDsKICAgIGludCBtb3JlX3RvX2RvOwoKcmVhZF9tb3JlX3Jlc3BvbnNl
czoKCglyY29ucyA9IHByaXYtPnR4X3JpbmcucnNwX2NvbnM7CglycHJvZCA9IHByaXYtPnR4X3Jp
bmcuc3JpbmctPnJzcF9wcm9kOwoKCWlmICghbGlrZWx5KG5ldGlmX2NhcnJpZXJfb2soY2FuZGV2
KSB8fAoJCSAgICFSSU5HX0hBU19VTkNPTlNVTUVEX1JFU1BPTlNFUygmcHJpdi0+dHhfcmluZykp
KQogICAgICAgIHJldHVybiBJUlFfSEFORExFRDsKCiAgICBybWIoKTsKCiAgICB3aGlsZSAocmNv
bnMgIT0gcnByb2QpCiAgICB7CiAgICAgICAgcnNwID0gUklOR19HRVRfUkVTUE9OU0UoJnByaXYt
PnR4X3JpbmcsIHJjb25zKTsKCiAgICAgICAgc2tiID0gYWxsb2NfY2FuX3NrYihjYW5kZXYsICZu
ZXdfY2ZkKTsKCiAgICAgICAgaWYgKCFza2IpCiAgICAgICAgewogICAgICAgICAgICBzdGF0cy0+
cnhfZHJvcHBlZCsrOwogICAgICAgICAgICBicmVhazsKICAgICAgICB9CgogICAgICAgIGlmICgh
bmV3X2NmZCkKICAgICAgICB7CiAgICAgICAgICAgIHN0YXRzLT5yeF9kcm9wcGVkKys7CiAgICAg
ICAgICAgIGJyZWFrOwogICAgICAgIH0KCiAgICAgICAgc2tiLT5wa3RfdHlwZSA9IFBBQ0tFVF9C
Uk9BRENBU1Q7CiAgICAgICAgc2tiLT5kZXYgPSBjYW5kZXY7CiAgICAgICAgc2tiLT5pcF9zdW1t
ZWQgPSBDSEVDS1NVTV9VTk5FQ0VTU0FSWTsKCiAgICAgICAgbWVtY3B5KHNrYi0+ZGF0YSwgJnJz
cC0+Y2ZkLCBzaXplb2YocnNwLT5jZmQpKTsKCiAgICAgICAgaWYgKGNhbl9kcm9wcGVkX2ludmFs
aWRfc2tiKGNhbmRldiwgc2tiKSkKICAgICAgICB7CiAgICAgICAgICAgIHN0YXRzLT5yeF9kcm9w
cGVkKys7CiAgICAgICAgfQogICAgICAgIGVsc2UKICAgICAgICB7CiAgICAgICAgICAgIG5ldGlm
X3J4KHNrYik7CiAgICAgICAgICAgIHN0YXRzLT5yeF9wYWNrZXRzKys7CiAgICAgICAgICAgIHN0
YXRzLT5yeF9ieXRlcyArPSByc3AtPmNmZC5sZW47CiAgICAgICAgfQoKICAgICAgICAodm9pZCkg
UklOR19HRVRfUkVRVUVTVCgmcHJpdi0+dHhfcmluZywKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgcHJpdi0+dHhfcmluZy5yZXFfcHJvZF9wdnQpOwoKICAgICAgICBwcml2LT50eF9yaW5nLnJl
cV9wcm9kX3B2dCsrOwoKCQlwcml2LT50eF9yaW5nLnJzcF9jb25zID0gKytyY29uczsKICAgIH0K
CglSSU5HX0ZJTkFMX0NIRUNLX0ZPUl9SRVNQT05TRVMoJnByaXYtPnR4X3JpbmcsIG1vcmVfdG9f
ZG8pOwoKICAgIGlmICghIW1vcmVfdG9fZG8pCiAgICB7CiAgICAgICAgZ290byByZWFkX21vcmVf
cmVzcG9uc2VzOwogICAgfQoKCXJldHVybiBJUlFfSEFORExFRDsKfQoKc3RhdGljIGludCB4ZW5f
cHZjYW5fZnJvbnRfcHJvYmUoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldiwKICAgICAgICAgICAg
ICBjb25zdCBzdHJ1Y3QgeGVuYnVzX2RldmljZV9pZCAqaWQpCnsKICAgIHJldHVybiAwOwp9Cgpz
dGF0aWMgaW50IHB2Y2FuX2Nvbm5lY3Qoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldikKewogICAg
c3RydWN0IHB2Y2FuX3ByaXZhdGUgKnByaXY7CiAgICBzdHJ1Y3QgbmV0X2RldmljZSAqY2FuZGV2
OwogICAgc3RydWN0IHhlbmJ1c190cmFuc2FjdGlvbiB4YnQ7CglzdHJ1Y3QgeGVuX3B2Y2FuX3J4
X3NyaW5nICpyeF9zcmluZzsKCXN0cnVjdCB4ZW5fcHZjYW5fdHhfc3JpbmcgKnR4X3NyaW5nOwog
ICAgZ3JhbnRfcmVmX3QgcnhfZ3JlZiwgdHhfZ3JlZjsKICAgIGludCByYzsKCiAgICBjYW5kZXYg
PSBhbGxvY19jYW5kZXYoc2l6ZW9mKHN0cnVjdCBwdmNhbl9wcml2YXRlKSwgMSk7CgogICAgaWYg
KCFjYW5kZXYpCiAgICB7CiAgICAgICAgZGV2X2VycigmZGV2LT5kZXYsICJhbGxvY2F0aW5nIHBy
aXZhdGUgc3RydWN0dXJlIik7CiAgICAgICAgcmMgPSAtRU5PTUVNOwogICAgICAgIGdvdG8gZmFp
bDE7CiAgICB9CgogICAgcHJpdiA9IG5ldGRldl9wcml2KGNhbmRldik7CiAgICBkZXZfc2V0X2Ry
dmRhdGEoJmRldi0+ZGV2LCBwcml2KTsKICAgIHByaXYtPnhlbmRldiA9IGRldjsKICAgIHByaXYt
PmNhbmRldiA9IGNhbmRldjsKCiAgICAvKiBTZXR1cCBSWCByaW5nICovCiAgICByeF9zcmluZyA9
IChzdHJ1Y3QgeGVuX3B2Y2FuX3J4X3NyaW5nICopCiAgICAgICAgICAgICAgICAgICAgZ2V0X3pl
cm9lZF9wYWdlKEdGUF9OT0lPfF9fR0ZQX0hJR0gpOwoKICAgIGlmICghcnhfc3JpbmcpCiAgICB7
CiAgICAgICAgcmMgPSAtRU5PTUVNOwogICAgICAgIGdvdG8gYWxsb2Nfc2hyX2ZhaWw7CiAgICB9
CgoJU0hBUkVEX1JJTkdfSU5JVChyeF9zcmluZyk7CglGUk9OVF9SSU5HX0lOSVQoJnByaXYtPnJ4
X3JpbmcsIHJ4X3NyaW5nLCBQQUdFX1NJWkUpOwoKICAgIHJjID0geGVuYnVzX2dyYW50X3Jpbmco
ZGV2LCByeF9zcmluZywgMSwgJnJ4X2dyZWYpOwoKICAgIGlmIChyYyA8IDApCiAgICAgICAgZ290
byBncmFudF9yeF9yaW5nX2ZhaWw7CgogICAgcHJpdi0+cnhfcmluZ19yZWYgPSByeF9ncmVmOwoK
ICAgIGRldl9kYmcoJmRldi0+ZGV2LCAicngtcmluZy1yZWYgPSAlaVxuIiwgcnhfZ3JlZik7Cgog
ICAgLyogQWxsb2NhdGUgVFggcmluZyAqLwogICAgdHhfc3JpbmcgPSAoc3RydWN0IHhlbl9wdmNh
bl90eF9zcmluZyAqKQogICAgICAgICAgICAgICAgICAgIGdldF96ZXJvZWRfcGFnZShHRlBfTk9J
T3xfX0dGUF9ISUdIKTsKCiAgICBpZiAoIXR4X3NyaW5nKQogICAgewogICAgICAgIHJjID0gLUVO
T01FTTsKICAgICAgICBnb3RvIGdyYW50X3J4X3JpbmdfZmFpbDsKICAgIH0KCglTSEFSRURfUklO
R19JTklUKHR4X3NyaW5nKTsKCUZST05UX1JJTkdfSU5JVCgmcHJpdi0+dHhfcmluZywgdHhfc3Jp
bmcsIFBBR0VfU0laRSk7CgogICAgcmMgPSB4ZW5idXNfZ3JhbnRfcmluZyhkZXYsIHR4X3NyaW5n
LCAxLCAmdHhfZ3JlZik7CgogICAgaWYgKHJjIDwgMCkKICAgICAgICBnb3RvIGdyYW50X3R4X3Jp
bmdfZmFpbDsKCiAgICBwcml2LT50eF9yaW5nX3JlZiA9IHR4X2dyZWY7CgogICAgZGV2X2RiZygm
ZGV2LT5kZXYsICJ0eC1yaW5nLXJlZiA9ICVpXG4iLCB0eF9ncmVmKTsKCiAgICAvKiBTZXR1cCBl
dmVudCBjaGFubmVsICovCiAgICByYyA9IHhlbmJ1c19hbGxvY19ldnRjaG4oZGV2LCAmcHJpdi0+
ZXZ0Y2huX3J4KTsKCiAgICBpZiAocmMpCiAgICB7CiAgICAgICAgcmMgPSAtRU5PTUVNOwogICAg
ICAgIGdvdG8gZ3JhbnRfdHhfcmluZ19mYWlsOwogICAgfQoKICAgIHJjID0geGVuYnVzX2FsbG9j
X2V2dGNobihkZXYsICZwcml2LT5ldnRjaG5fdHgpOwoKICAgIGlmIChyYykKICAgIHsKICAgICAg
ICByYyA9IC1FTk9NRU07CiAgICAgICAgZ290byBncmFudF90eF9yaW5nX2ZhaWw7CiAgICB9Cgog
ICAgcmMgPSB4ZW5idXNfdHJhbnNhY3Rpb25fc3RhcnQoJnhidCk7CgogICAgaWYgKHJjKQogICAg
ewogICAgICAgIHJjID0gLTE7CiAgICAgICAgZGV2X2VycigmZGV2LT5kZXYsICJDb3VsZCBub3Qg
c3RhcnQgeGVuc3RvcmUgdHJhbnNhY3Rpb25cbiIpOwogICAgICAgIGdvdG8gaXJxX2JpbmRfZmFp
bDsKICAgIH0KCiAgICByYyA9IHhlbmJ1c19wcmludGYoeGJ0LCBkZXYtPm5vZGVuYW1lLCAidHgt
cmluZy1yZWYiLCAiJXUiLAogICAgICAgICAgICAgICAgICAgICAgICBwcml2LT50eF9yaW5nX3Jl
Zik7CgogICAgaWYgKHJjKQogICAgewogICAgICAgIGRldl9lcnIoJmRldi0+ZGV2LCAiQ291bGQg
bm90IHdyaXRlIHR4LXJpbmctcmVmICglaSlcbiIsIHJjKTsKICAgICAgICByYyA9IC0xOwogICAg
ICAgIGdvdG8geGVuYnVzX2Fib3J0X3RyYW5zYWN0aW9uOwogICAgfQoKICAgIHJjID0geGVuYnVz
X3ByaW50Zih4YnQsIGRldi0+bm9kZW5hbWUsICJyeC1yaW5nLXJlZiIsICIldSIsCiAgICAgICAg
ICAgICAgICAgICAgICAgIHByaXYtPnJ4X3JpbmdfcmVmKTsKCiAgICBpZiAocmMpCiAgICB7CiAg
ICAgICAgZGV2X2VycigmZGV2LT5kZXYsICJDb3VsZCBub3Qgd3JpdGUgcngtcmluZy1yZWYgKCVp
KVxuIiwgcmMpOwogICAgICAgIHJjID0gLTE7CiAgICAgICAgZ290byB4ZW5idXNfYWJvcnRfdHJh
bnNhY3Rpb247CiAgICB9CgogICAgcmMgPSB4ZW5idXNfcHJpbnRmKHhidCwgZGV2LT5ub2RlbmFt
ZSwgImV2ZW50LWNoYW5uZWwtcngiLCAiJXUiLAogICAgICAgICAgICAgICAgICAgICAgICBwcml2
LT5ldnRjaG5fcngpOwoKICAgIGlmIChyYykKICAgIHsKICAgICAgICByYyA9IC0xOwogICAgICAg
IGRldl9lcnIoJmRldi0+ZGV2LCAiQ291bGQgbm90IHdyaXRlIGV2ZW50LWNoYW5uZWxcbiIpOwog
ICAgICAgIGdvdG8geGVuYnVzX2Fib3J0X3RyYW5zYWN0aW9uOwogICAgfQoKICAgIHJjID0geGVu
YnVzX3ByaW50Zih4YnQsIGRldi0+bm9kZW5hbWUsICJldmVudC1jaGFubmVsLXR4IiwgIiV1IiwK
ICAgICAgICAgICAgICAgICAgICAgICAgcHJpdi0+ZXZ0Y2huX3R4KTsKCiAgICBpZiAocmMpCiAg
ICB7CiAgICAgICAgcmMgPSAtMTsKICAgICAgICBkZXZfZXJyKCZkZXYtPmRldiwgIkNvdWxkIG5v
dCB3cml0ZSBldmVudC1jaGFubmVsLXR4XG4iKTsKICAgICAgICBnb3RvIHhlbmJ1c19hYm9ydF90
cmFuc2FjdGlvbjsKICAgIH0KCiAgICByYyA9IHhlbmJ1c190cmFuc2FjdGlvbl9lbmQoeGJ0LCAw
KTsKCiAgICByYyA9IGJpbmRfZXZ0Y2huX3RvX2lycWhhbmRsZXIocHJpdi0+ZXZ0Y2huX3J4LCBw
dmNhbl9pbnRlcnJ1cHQsIDAsICJwdmNhbi1yeCIsCiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgcHJpdik7CiAgICBpZiAocmMgPD0gMCkKICAgIHsKICAgICAgICBkZXZfZXJyKCZk
ZXYtPmRldiwgImFsbG9jYXRpbmcgSVJRIik7CiAgICAgICAgcmMgPSAtMTsKICAgICAgICBnb3Rv
IGlycV9iaW5kX2ZhaWw7CiAgICB9CgogICAgcmMgPSBiaW5kX2V2dGNobl90b19pcnFoYW5kbGVy
KHByaXYtPmV2dGNobl90eCwgdHhxdWV1ZV9yZWFkeV9pbnRlcnJ1cHQsIDAsICJwdmNhbi10eCIs
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcHJpdik7CiAgICBpZiAocmMgPD0g
MCkKICAgIHsKICAgICAgICBkZXZfZXJyKCZkZXYtPmRldiwgImFsbG9jYXRpbmcgSVJRIik7CiAg
ICAgICAgcmMgPSAtMTsKICAgICAgICBnb3RvIGlycV9iaW5kX2ZhaWw7CiAgICB9CgoKICAgIHBy
aXYtPmlycSA9IHJjOwoKICAgIGRldl9kYmcoJmNhbmRldi0+ZGV2LCAicHZjYW4gaXJxID0gJWlc
biIsIHByaXYtPmlycSk7CiAgICAvKiBDcmVhdGUgcHZjYW4gaW50ZXJmYWNlICovCgogICAgY2Fu
ZGV2LT50eXBlID0gQVJQSFJEX0NBTjsKICAgIGNhbmRldi0+bXR1ID0gQ0FOX01UVTsKICAgIGNh
bmRldi0+aGFyZF9oZWFkZXJfbGVuID0gMDsKICAgIGNhbmRldi0+YWRkcl9sZW4gPSAwOwogICAg
Y2FuZGV2LT50eF9xdWV1ZV9sZW4gPSAxNjsKICAgIGNhbmRldi0+ZmxhZ3MgPSBJRkZfTk9BUlA7
CiAgICBjYW5kZXYtPm5ldGRldl9vcHMgPSAmcHZjYW5fbmV0ZGV2X29wczsKICAgIGNhbmRldi0+
bmVlZHNfZnJlZV9uZXRkZXYgPSB0cnVlOwoKCXJjID0gcmVnaXN0ZXJfY2FuZGV2KGNhbmRldik7
CgoJaWYgKHJjIDwgMCkKCQlnb3RvIHJlZ2lzdGVyX2Rldl9mYWlsOwoKCXJldHVybiAwOwoKeGVu
YnVzX2Fib3J0X3RyYW5zYWN0aW9uOgogICAgZGV2X2VycigmZGV2LT5kZXYsICJGYWlsZWQgdG8g
Y29uZmlndXJlIHhlbnN0b3JlXG4iKTsKICAgIHhlbmJ1c190cmFuc2FjdGlvbl9lbmQoeGJ0LCAx
KTsKcmVnaXN0ZXJfZGV2X2ZhaWw6CglpZiAocHJpdi0+aXJxKQogICAgewoJCXVuYmluZF9mcm9t
X2lycWhhbmRsZXIocHJpdi0+aXJxLCBwcml2KTsKICAgICAgICBwcml2LT5pcnEgPSAwOwogICAg
fQppcnFfYmluZF9mYWlsOgogICAgaWYgKHByaXYtPmV2dGNobl9yeCkKICAgICAgICB4ZW5idXNf
ZnJlZV9ldnRjaG4oZGV2LCBwcml2LT5ldnRjaG5fcngpOwogICAgaWYgKHByaXYtPmV2dGNobl90
eCkKICAgICAgICB4ZW5idXNfZnJlZV9ldnRjaG4oZGV2LCBwcml2LT5ldnRjaG5fdHgpOwpncmFu
dF90eF9yaW5nX2ZhaWw6CiAgICBmcmVlX3BhZ2UoKHVuc2lnbmVkIGxvbmcpIHR4X3NyaW5nKTsK
Z3JhbnRfcnhfcmluZ19mYWlsOgogICAgZnJlZV9wYWdlKCh1bnNpZ25lZCBsb25nKSByeF9zcmlu
Zyk7CmFsbG9jX3Nocl9mYWlsOgogICAga3ZmcmVlKHByaXYpOwpmYWlsMToKICAgIHJldHVybiBy
YzsKfQoKCnN0YXRpYyBpbnQgcHZjYW5fZGlzY29ubmVjdChzdHJ1Y3QgeGVuYnVzX2RldmljZSAq
ZGV2KQp7CiAgICBzdHJ1Y3QgcHZjYW5fcHJpdmF0ZSAqcHJpdjsKICAgIHN0cnVjdCBuZXRfZGV2
aWNlICpjYW5kZXY7CgogICAgcHJpdiA9IGRldl9nZXRfZHJ2ZGF0YSgmZGV2LT5kZXYpOwoKICAg
IGlmICghcHJpdikKICAgIHsKICAgICAgICByZXR1cm4gMDsKICAgIH0KCiAgICBjYW5kZXYgPSBw
cml2LT5jYW5kZXY7CgogICAgaWYgKCFjYW5kZXYpCiAgICB7CiAgICAgICAgcmV0dXJuIDA7CiAg
ICB9CgoJaWYgKHByaXYtPmlycSkKICAgIHsKCQl1bmJpbmRfZnJvbV9pcnFoYW5kbGVyKHByaXYt
PmlycSwgcHJpdik7CiAgICAgICAgcHJpdi0+aXJxID0gMDsKICAgIH0KCglpZiAocHJpdi0+cnhf
cmluZ19yZWYgIT0gMCkKICAgIHsKICAgICAgICBnbnR0YWJfZW5kX2ZvcmVpZ25fYWNjZXNzKHBy
aXYtPnJ4X3JpbmdfcmVmLCAwLAogICAgICAgICAgICAgICAgICAodW5zaWduZWQgbG9uZylwcml2
LT5yeF9yaW5nLnNyaW5nKTsKICAgICAgICBwcml2LT5yeF9yaW5nX3JlZiA9IDA7Cgl9CgoJcHJp
di0+cnhfcmluZy5zcmluZyA9IE5VTEw7CgoJaWYgKHByaXYtPnR4X3JpbmdfcmVmICE9IDApCiAg
ICB7CiAgICAgICAgZ250dGFiX2VuZF9mb3JlaWduX2FjY2Vzcyhwcml2LT50eF9yaW5nX3JlZiwg
MCwKICAgICAgICAgICAgICAgICAgKHVuc2lnbmVkIGxvbmcpcHJpdi0+dHhfcmluZy5zcmluZyk7
CiAgICAgICAgcHJpdi0+dHhfcmluZ19yZWYgPSAwOwoJfQoKCXByaXYtPnR4X3Jpbmcuc3Jpbmcg
PSBOVUxMOwoKICAgIGlmIChjYW5kZXYpCiAgICB7CiAgICAgICAgdW5yZWdpc3Rlcl9uZXRkZXYo
Y2FuZGV2KTsKICAgICAgICBwcml2LT5jYW5kZXYgPSBOVUxMOwogICAgfQogICAgcmV0dXJuIDA7
Cn0KCnN0YXRpYyB2b2lkIHhlbl9wdmNhbl9mcm9udF9vdGhlcmVuZF9jaGFuZ2VkKHN0cnVjdCB4
ZW5idXNfZGV2aWNlICpkZXYsCgkJCSAgICBlbnVtIHhlbmJ1c19zdGF0ZSBiYWNrZW5kX3N0YXRl
KQp7CiAgICBzd2l0Y2ggKGJhY2tlbmRfc3RhdGUpCiAgICB7CiAgICAgICAgY2FzZSBYZW5idXNT
dGF0ZUluaXRpYWxpc2luZzoKICAgICAgICAgICAgeGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhl
bmJ1c1N0YXRlSW5pdGlhbGlzaW5nKTsKICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgY2FzZSBY
ZW5idXNTdGF0ZUluaXRpYWxpc2VkOgogICAgICAgIGNhc2UgWGVuYnVzU3RhdGVSZWNvbmZpZ3Vy
aW5nOgogICAgICAgIGNhc2UgWGVuYnVzU3RhdGVSZWNvbmZpZ3VyZWQ6CiAgICAgICAgY2FzZSBY
ZW5idXNTdGF0ZVVua25vd246CiAgICAgICAgICAgIGJyZWFrOwoKICAgICAgICBjYXNlIFhlbmJ1
c1N0YXRlSW5pdFdhaXQ6CiAgICAgICAgICAgIGlmIChkZXYtPnN0YXRlICE9IFhlbmJ1c1N0YXRl
SW5pdGlhbGlzaW5nKQogICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgIGlmIChwdmNh
bl9jb25uZWN0KGRldikgIT0gMCkKICAgICAgICAgICAgICAgIGJyZWFrOwoKICAgICAgICAgICAg
eGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRlQ29ubmVjdGVkKTsKICAgICAgICAg
ICAgYnJlYWs7CgogICAgICAgIGNhc2UgWGVuYnVzU3RhdGVDb25uZWN0ZWQ6CiAgICAgICAgICAg
IHByX2luZm8oIk90aGVyIHNpZGUgc2F5cyBpdCBpcyBjb25uZWN0ZWQgYXMgd2VsbC5cbiIpOwog
ICAgICAgICAgICBicmVhazsKCiAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNsb3NlZDoKICAgICAg
ICAgICAgaWYgKGRldi0+c3RhdGUgPT0gWGVuYnVzU3RhdGVDbG9zZWQpIHsKICAgICAgICAgICAg
ICAgIGJyZWFrOwogICAgICAgICAgICB9CiAgICAgICAgICAgIHB2Y2FuX2Rpc2Nvbm5lY3QoZGV2
KTsKICAgICAgICAgICAgeGVuYnVzX2Zyb250ZW5kX2Nsb3NlZChkZXYpOwogICAgICAgICAgICBi
cmVhazsKICAgICAgICBjYXNlIFhlbmJ1c1N0YXRlQ2xvc2luZzoKICAgICAgICAgICAgcHZjYW5f
ZGlzY29ubmVjdChkZXYpOwogICAgICAgICAgICB4ZW5idXNfZnJvbnRlbmRfY2xvc2VkKGRldik7
CiAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICBicmVhazsK
CX0KfQoKc3RhdGljIGNvbnN0IHN0cnVjdCB4ZW5idXNfZGV2aWNlX2lkIHhlbl9wdmNhbl9mcm9u
dF9pZHNbXSA9CnsKCXsgInB2Y2FuIiAgfSwKCXsgIiIgIH0KfTsKCnN0YXRpYyBzdHJ1Y3QgeGVu
YnVzX2RyaXZlciB4ZW5fcHZjYW5fZnJvbnRfZHJpdmVyID0KewoJLmlkcyAgPSB4ZW5fcHZjYW5f
ZnJvbnRfaWRzLAoJLnByb2JlID0geGVuX3B2Y2FuX2Zyb250X3Byb2JlLAoJLm90aGVyZW5kX2No
YW5nZWQgPSB4ZW5fcHZjYW5fZnJvbnRfb3RoZXJlbmRfY2hhbmdlZCwKfTsKCnN0YXRpYyBpbnQg
X19pbml0IHhlbl9wdmNhbl9mcm9udF9pbml0KHZvaWQpCnsKCXByaW50ayhLRVJOX05PVElDRSAi
WEVOIFBWIENBTiBmcm9udGVuZCBkcml2ZXIgaW5pdFxuIik7CgoJcmV0dXJuIHhlbmJ1c19yZWdp
c3Rlcl9mcm9udGVuZCgmeGVuX3B2Y2FuX2Zyb250X2RyaXZlcik7Cn0KCnN0YXRpYyB2b2lkIF9f
ZXhpdCB4ZW5fcHZjYW5fZnJvbnRfZXhpdCh2b2lkKQp7Cgl4ZW5idXNfdW5yZWdpc3Rlcl9kcml2
ZXIoJnhlbl9wdmNhbl9mcm9udF9kcml2ZXIpOwp9CgoKbW9kdWxlX2luaXQoeGVuX3B2Y2FuX2Zy
b250X2luaXQpOwptb2R1bGVfZXhpdCh4ZW5fcHZjYW5fZnJvbnRfZXhpdCk7CgpNT0RVTEVfTElD
RU5TRSgiR1BMIik7Ck1PRFVMRV9BTElBUygieGVuOnB2Y2FuLWZyb250Iik7Cg==

--_004_5a2d079fe8db41338464381dd2dc9575actiase_
Content-Type: text/x-csrc; name="xen-pvcan-backend.c"
Content-Description: xen-pvcan-backend.c
Content-Disposition: attachment; filename="xen-pvcan-backend.c"; size=13829;
	creation-date="Mon, 06 Dec 2021 08:31:38 GMT";
	modification-date="Mon, 06 Dec 2021 08:31:38 GMT"
Content-Transfer-Encoding: base64

I2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgojaW5jbHVkZSA8bGludXgva2VybmVsLmg+CiNpbmNs
dWRlIDx4ZW4veGVuLmg+CiNpbmNsdWRlIDx4ZW4veGVuYnVzLmg+CiNpbmNsdWRlIDx4ZW4vaW50
ZXJmYWNlL2lvL3JpbmcuaD4KI2luY2x1ZGUgPHhlbi9pbnRlcmZhY2UvaW8vcHZjYW4uaD4KI2lu
Y2x1ZGUgPHhlbi9ldmVudHMuaD4KI2luY2x1ZGUgPGxpbnV4L2lmX2FycC5oPgojaW5jbHVkZSA8
bGludXgvaWZfZXRoZXIuaD4KI2luY2x1ZGUgPGxpbnV4L2Nhbi5oPgojaW5jbHVkZSA8bGludXgv
Y2FuL2Rldi5oPgojaW5jbHVkZSA8bGludXgvY2FuL3NrYi5oPgoKCnN0cnVjdCBwdmNhbl9wcml2
YXRlCnsKICAgIHN0cnVjdCBjYW5fcHJpdiBjYW47ICAgICAgICAvKiBtdXN0IGJlIHRoZSBmaXJz
dCBtZW1iZXIhICovCiAgICBzdHJ1Y3QgeGVuYnVzX2RldmljZSAqeGVuZGV2OwogICAgc3RydWN0
IG5ldF9kZXZpY2UgKmNhbmRldjsKICAgIHVuc2lnbmVkIGludCBldnRjaG5fcng7CiAgICB1bnNp
Z25lZCBpbnQgZXZ0Y2huX3R4OwogICAgc3RydWN0IHhlbl9wdmNhbl9yeF9iYWNrX3Jpbmcgcnhf
cmluZzsKICAgIHN0cnVjdCB4ZW5fcHZjYW5fdHhfYmFja19yaW5nIHR4X3Jpbmc7CiAgICBpbnQg
aXJxX3J4OwogICAgaW50IGlycV90eDsKICAgIGdyYW50X3JlZl90IHR4X3JpbmdfcmVmOwogICAg
Z3JhbnRfcmVmX3QgcnhfcmluZ19yZWY7Cn07CgoKCmlycXJldHVybl90IHB2Y2FuX2ludGVycnVw
dF9yeChpbnQgaXJxLCB2b2lkICpkYXRhKQp7CiAgICBzdHJ1Y3QgbmV0X2RldmljZSAqY2FuZGV2
ID0gKHN0cnVjdCBuZXRfZGV2aWNlICopIGRhdGE7CiAgICBzdHJ1Y3QgcHZjYW5fcHJpdmF0ZSAq
cHJpdiA9IG5ldGRldl9wcml2KGNhbmRldik7CiAgICBzdHJ1Y3QgbmV0X2RldmljZV9zdGF0cyAq
c3RhdHMgPSAmY2FuZGV2LT5zdGF0czsKICAgIFJJTkdfSURYIHJjb25zLCBycHJvZDsKICAgIHN0
cnVjdCBza19idWZmICpza2I7CiAgICBzdHJ1Y3QgY2FuX2ZyYW1lICpuZXdfY2ZkOwogICAgc3Ry
dWN0IHB2Y2FuX3JlcXVlc3QgcmVxOwogICAgc3RydWN0IHB2Y2FuX3Jlc3BvbnNlICpyZXM7CiAg
ICBpbnQgbW9yZV90b19kbzsKCmdldF9tb3JlX3JlcXVlc3RzOgoKICAgIHJjb25zID0gcHJpdi0+
cnhfcmluZy5yZXFfY29uczsKICAgIHJwcm9kID0gcHJpdi0+cnhfcmluZy5zcmluZy0+cmVxX3By
b2Q7CiAgICBybWIoKTsKCiAgICBpZiAoUklOR19SRVFVRVNUX1BST0RfT1ZFUkZMT1coJnByaXYt
PnJ4X3JpbmcsIHJwcm9kKSkKICAgIHsKICAgICAgICBkZXZfZXJyKCZjYW5kZXYtPmRldiwgInJp
bmcgb3ZlcmZsb3dcbiIpOwogICAgICAgIHJldHVybiBJUlFfSEFORExFRDsKICAgIH0KCiAgICB3
aGlsZSAocmNvbnMgIT0gcnByb2QpCiAgICB7CiAgICAgICAgcmVxID0gKlJJTkdfR0VUX1JFUVVF
U1QoJnByaXYtPnJ4X3JpbmcsIHJjb25zKTsKCiAgICAgICAgc3RhdHMtPnJ4X3BhY2tldHMrKzsK
ICAgICAgICBzdGF0cy0+cnhfYnl0ZXMgKz0gcmVxLmNmZC5sZW47CgogICAgICAgIHNrYiA9IGFs
bG9jX2Nhbl9za2IoY2FuZGV2LCAmbmV3X2NmZCk7CiAgICAgICAgc2tiLT5wa3RfdHlwZSA9IFBB
Q0tFVF9CUk9BRENBU1Q7CiAgICAgICAgc2tiLT5kZXYgPSBjYW5kZXY7CiAgICAgICAgc2tiLT5p
cF9zdW1tZWQgPSBDSEVDS1NVTV9VTk5FQ0VTU0FSWTsKICAgICAgICBtZW1jcHkoc2tiLT5kYXRh
LCAmcmVxLmNmZCwgc2l6ZW9mKHJlcS5jZmQpKTsKCiAgICAgICAgcmVzID0gUklOR19HRVRfUkVT
UE9OU0UoJnByaXYtPnJ4X3JpbmcsCiAgICAgICAgICAgICAgICAgICAgcHJpdi0+cnhfcmluZy5y
c3BfcHJvZF9wdnQpOwoKICAgICAgICBiYXJyaWVyKCk7CiAgICAgICAgcHJpdi0+cnhfcmluZy5y
c3BfcHJvZF9wdnQrKzsKICAgICAgICBwcml2LT5yeF9yaW5nLnJlcV9jb25zID0gKytyY29uczsK
ICAgICAgICBuZXRpZl9yeChza2IpOwogICAgfQoKICAgIFJJTkdfRklOQUxfQ0hFQ0tfRk9SX1JF
UVVFU1RTKCZwcml2LT5yeF9yaW5nLCBtb3JlX3RvX2RvKTsKCgogICAgaWYgKCEhbW9yZV90b19k
bykKICAgIHsKICAgICAgICBnb3RvIGdldF9tb3JlX3JlcXVlc3RzOwogICAgfQoKICAgIC8vIE5v
dGlmeSB0aGUgZnJvbnRlbmQtZHJpdmVyLCB0aGF0IG1vcmUKICAgIC8vIGZyYW1lcyBjYW4gYmUg
c2VudAogICAgbm90aWZ5X3JlbW90ZV92aWFfaXJxKHByaXYtPmlycV90eCk7CgogICAgcmV0dXJu
IElSUV9IQU5ETEVEOwp9CgovKiBEdW1teSBpbnRlcnJ1cHQgaGFuZGxlciB0aGF0IGlzIG5ldmVy
IHVzZWQgKi8KaXJxcmV0dXJuX3QgcHZjYW5faW50ZXJydXB0X3R4KGludCBpcnEsIHZvaWQgKmRh
dGEpCnsKICAgIHJldHVybiBJUlFfSEFORExFRDsKfQoKCi8qIFRyYW5zbWl0dCBDQU4gZnJhbWVz
IHRvIGRvbVUgKi8Kc3RhdGljIG5ldGRldl90eF90IHB2Y2FuX3R4KHN0cnVjdCBza19idWZmICpz
a2IsIHN0cnVjdCBuZXRfZGV2aWNlICpkZXYpCnsKICAgIHN0cnVjdCBwdmNhbl9wcml2YXRlICpw
cml2ID0gbmV0ZGV2X3ByaXYoZGV2KTsKICAgIHN0cnVjdCBwdmNhbl9yZXNwb25zZSAqcnNwOwog
ICAgc3RydWN0IGNhbl9mcmFtZSAqY2ZkID0gKHN0cnVjdCBjYW5fZnJhbWUgKikgc2tiLT5kYXRh
OwogICAgc3RydWN0IG5ldF9kZXZpY2Vfc3RhdHMgKnN0YXRzID0gJmRldi0+c3RhdHM7CiAgICBi
b29sIG5vdGlmeTsKCiAgICBpZiAoY2FuX2Ryb3BwZWRfaW52YWxpZF9za2IoZGV2LCBza2IpKQog
ICAgewogICAgICAgIHN0YXRzLT50eF9kcm9wcGVkKys7CiAgICAgICAgcmV0dXJuIE5FVERFVl9U
WF9PSzsKICAgIH0KCiAgICBzdGF0cy0+dHhfcGFja2V0cysrOwogICAgc3RhdHMtPnR4X2J5dGVz
ICs9IGNmZC0+Y2FuX2RsYzsKCiAgICByc3AgPSBSSU5HX0dFVF9SRVNQT05TRSgmcHJpdi0+dHhf
cmluZywgcHJpdi0+dHhfcmluZy5yc3BfcHJvZF9wdnQpOwoKICAgIGJhcnJpZXIoKTsKICAgIG1l
bWNweSgmcnNwLT5jZmQsIGNmZCwgc2l6ZW9mKCpjZmQpKTsKICAgIHdtYigpOwoKICAgIHByaXYt
PnR4X3JpbmcucnNwX3Byb2RfcHZ0Kys7CgogICAgUklOR19QVVNIX1JFU1BPTlNFU19BTkRfQ0hF
Q0tfTk9USUZZKCZwcml2LT50eF9yaW5nLCBub3RpZnkpOwoKICAgIGlmIChub3RpZnkpCiAgICAg
ICAgbm90aWZ5X3JlbW90ZV92aWFfaXJxKHByaXYtPmlycV9yeCk7CgogICAgY29uc3VtZV9za2Io
c2tiKTsKCiAgICByZXR1cm4gTkVUREVWX1RYX09LOwp9CgpzdGF0aWMgaW50IHB2Y2FuX2NoYW5n
ZV9tdHUoc3RydWN0IG5ldF9kZXZpY2UgKmRldiwgaW50IG5ld19tdHUpCnsKICAgIC8qIERvIG5v
dCBhbGxvdyBjaGFuZ2luZyB0aGUgTVRVIHdoaWxlIHJ1bm5pbmcgKi8KICAgIGlmIChkZXYtPmZs
YWdzICYgSUZGX1VQKQogICAgICAgIHJldHVybiAtRUJVU1k7CgogICAgaWYgKG5ld19tdHUgIT0g
Q0FOX01UVSAmJiBuZXdfbXR1ICE9IENBTkZEX01UVSkKICAgICAgICByZXR1cm4gLUVJTlZBTDsK
CiAgICBkZXYtPm10dSA9IG5ld19tdHU7CiAgICByZXR1cm4gMDsKfQoKc3RhdGljIGludCBwdmNh
bl9vcGVuKHN0cnVjdCBuZXRfZGV2aWNlICpkZXYpCnsKICAgIGlmICghbmV0aWZfY2Fycmllcl9v
ayhkZXYpKQogICAgICAgIG5ldGlmX2NhcnJpZXJfb24oZGV2KTsKCiAgICBuZXRpZl9zdGFydF9x
dWV1ZShkZXYpOwogICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyBpbnQgcHZjYW5fc3RvcChzdHJ1Y3Qg
bmV0X2RldmljZSAqZGV2KQp7CiAgICBuZXRpZl9zdG9wX3F1ZXVlKGRldik7CiAgICByZXR1cm4g
MDsKfQoKc3RhdGljIGNvbnN0IHN0cnVjdCBuZXRfZGV2aWNlX29wcyBwdmNhbl9uZXRkZXZfb3Bz
ID0KewogICAgLm5kb19vcGVuID0gcHZjYW5fb3BlbiwKICAgIC5uZG9fc3RvcCA9IHB2Y2FuX3N0
b3AsCiAgICAubmRvX3N0YXJ0X3htaXQgPSBwdmNhbl90eCwKICAgIC5uZG9fY2hhbmdlX210dSA9
IHB2Y2FuX2NoYW5nZV9tdHUsCn07CgoKc3RhdGljIHZvaWQgYmFja2VuZF9jb25uZWN0KHN0cnVj
dCB4ZW5idXNfZGV2aWNlICpkZXYpCnsKICAgIHN0cnVjdCBuZXRfZGV2aWNlICpjYW5kZXY7CiAg
ICBzdHJ1Y3QgcHZjYW5fcHJpdmF0ZSAqcHJpdjsKICAgIHN0cnVjdCB4ZW5fcHZjYW5fcnhfc3Jp
bmcgKnB2Y2FuX3J4X3NyaW5nOwogICAgc3RydWN0IHhlbl9wdmNhbl90eF9zcmluZyAqcHZjYW5f
dHhfc3Jpbmc7CiAgICBpbnQgcmM7CiAgICB2b2lkICphZGRyOwoKICAgIGNhbmRldiA9IGFsbG9j
X2NhbmRldihzaXplb2Yoc3RydWN0IHB2Y2FuX3ByaXZhdGUpLCAxKTsKCiAgICBpZiAoIWNhbmRl
dikKICAgIHsKICAgICAgICB4ZW5idXNfZGV2X2ZhdGFsKGRldiwgLUVOT01FTSwgImFsbG9jYXRp
bmcgcHJpdmF0ZSBzdHJ1Y3R1cmUiKTsKICAgICAgICByYyA9IC1FTk9NRU07CiAgICAgICAgZ290
byBlcnJfb3V0OwogICAgfQoKICAgIHByaXYgPSBuZXRkZXZfcHJpdihjYW5kZXYpOwogICAgZGV2
X3NldF9kcnZkYXRhKCZkZXYtPmRldiwgcHJpdik7CiAgICBwcml2LT54ZW5kZXYgPSBkZXY7CiAg
ICBwcml2LT5jYW5kZXYgPSBjYW5kZXY7CgoKICAgIHByaXYtPnR4X3JpbmdfcmVmID0KICAgICAg
ICAgICAgeGVuYnVzX3JlYWRfdW5zaWduZWQoZGV2LT5vdGhlcmVuZCwgInR4LXJpbmctcmVmIiwg
MSk7CgogICAgaWYgKHByaXYtPnR4X3JpbmdfcmVmIDw9IDApCiAgICB7CiAgICAgICAgZGV2X2Vy
cigmZGV2LT5kZXYsICJDb3VsZCBub3QgcmVhZCB0eC1yaW5nLXJlZlxuIik7CiAgICAgICAgZ290
byBmcmVlX2NhbmRldjsKICAgIH0KCiAgICBkZXZfZGJnKCZkZXYtPmRldiwgInR4LXJpbmctcmVm
ID0gJWlcbiIsIHByaXYtPnR4X3JpbmdfcmVmKTsKICAgIHByaXYtPnJ4X3JpbmdfcmVmID0KICAg
ICAgICAgICAgeGVuYnVzX3JlYWRfdW5zaWduZWQoZGV2LT5vdGhlcmVuZCwgInJ4LXJpbmctcmVm
IiwgMSk7CiAgICBpZiAocHJpdi0+cnhfcmluZ19yZWYgPD0gMCkKICAgIHsKICAgICAgICBkZXZf
ZXJyKCZkZXYtPmRldiwgIkNvdWxkIG5vdCByZWFkIHJ4LXJpbmctcmVmXG4iKTsKICAgICAgICBn
b3RvIGZyZWVfY2FuZGV2OwogICAgfQogICAgZGV2X2RiZygmZGV2LT5kZXYsICJyeC1yaW5nLXJl
ZiA9ICVpXG4iLCBwcml2LT5yeF9yaW5nX3JlZik7CgogICAgcHJpdi0+ZXZ0Y2huX3J4ID0KICAg
ICAgICAgICAgeGVuYnVzX3JlYWRfdW5zaWduZWQoZGV2LT5vdGhlcmVuZCwgImV2ZW50LWNoYW5u
ZWwtcngiLCAxKTsKCiAgICBpZiAocHJpdi0+ZXZ0Y2huX3J4IDw9IDApCiAgICB7CiAgICAgICAg
ZGV2X2VycigmZGV2LT5kZXYsICJDb3VsZCBub3QgcmVhZCBldnRjaG5cbiIpOwogICAgICAgIGdv
dG8gZnJlZV9jYW5kZXY7CiAgICB9CgogICAgZGV2X2RiZygmZGV2LT5kZXYsICJldmVudC1jaGFu
bmVsLXJ4ID0gJWlcbiIsIHByaXYtPmV2dGNobl9yeCk7CgogICAgcHJpdi0+ZXZ0Y2huX3R4ID0K
ICAgICAgICAgICAgeGVuYnVzX3JlYWRfdW5zaWduZWQoZGV2LT5vdGhlcmVuZCwgImV2ZW50LWNo
YW5uZWwtdHgiLCAxKTsKCiAgICBpZiAocHJpdi0+ZXZ0Y2huX3R4IDw9IDApCiAgICB7CiAgICAg
ICAgZGV2X2VycigmZGV2LT5kZXYsICJDb3VsZCBub3QgcmVhZCBldnRjaG5fdHhcbiIpOwogICAg
ICAgIGdvdG8gZnJlZV9jYW5kZXY7CiAgICB9CgogICAgZGV2X2RiZygmZGV2LT5kZXYsICJldmVu
dC1jaGFubmVsLXR4ID0gJWlcbiIsIHByaXYtPmV2dGNobl90eCk7CgogICAgcmMgPSB4ZW5idXNf
bWFwX3JpbmdfdmFsbG9jKGRldiwgJnByaXYtPnJ4X3JpbmdfcmVmLCAxLCAmYWRkcik7CgogICAg
aWYgKHJjKQogICAgewogICAgICAgIGRldl9lcnIoJmRldi0+ZGV2LCAiQ291bGQgbm90IG1hcCBy
eC1yaW5nXG4iKTsKICAgICAgICBnb3RvIGZyZWVfcmluZzsKICAgIH0KCiAgICBwdmNhbl9yeF9z
cmluZyA9IGFkZHI7CgogICAgQkFDS19SSU5HX0lOSVQoJnByaXYtPnJ4X3JpbmcsIHB2Y2FuX3J4
X3NyaW5nLCBQQUdFX1NJWkUpOwoKICAgIHJjID0geGVuYnVzX21hcF9yaW5nX3ZhbGxvYyhkZXYs
ICZwcml2LT50eF9yaW5nX3JlZiwgMSwgJmFkZHIpOwoKICAgIGlmIChyYykKICAgIHsKICAgICAg
ICBkZXZfZXJyKCZkZXYtPmRldiwgIkNvdWxkIG5vdCBtYXAgdHgtcmluZ1xuIik7CiAgICAgICAg
Z290byBmcmVlX2NhbmRldjsKICAgIH0KCiAgICBwdmNhbl90eF9zcmluZyA9IGFkZHI7CgogICAg
QkFDS19SSU5HX0lOSVQoJnByaXYtPnR4X3JpbmcsIHB2Y2FuX3R4X3NyaW5nLCBQQUdFX1NJWkUp
OwoKICAgIHByaXYtPmlycV9yeCA9IGJpbmRfaW50ZXJkb21haW5fZXZ0Y2huX3RvX2lycWhhbmRs
ZXIoZGV2LT5vdGhlcmVuZF9pZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgcHJpdi0+ZXZ0Y2huX3J4LAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdmNhbl9pbnRlcnJ1cHRfcngs
IDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICJwdmNhbi1iYWNrZW5kLXJ4IiwgY2FuZGV2KTsKCiAgICBpZiAocHJpdi0+aXJxX3J4IDwg
MCkKICAgIHsKICAgICAgICBkZXZfZXJyKCZkZXYtPmRldiwgIkNvdWxkIG5vdCBhbGxvY2F0ZSBp
cnFcbiIpOwogICAgICAgIGdvdG8gZnJlZV9yaW5nOwogICAgfQoKICAgIGRldl9kYmcoJmNhbmRl
di0+ZGV2LCAic2V0dGluZyB1cCBjYW4gaW50ZXJmYWNlLCB3aXRoIGlycSA9ICVpXG4iLCBwcml2
LT5pcnFfcngpOwoKICAgIHByaXYtPmlycV90eCA9IGJpbmRfaW50ZXJkb21haW5fZXZ0Y2huX3Rv
X2lycWhhbmRsZXIoZGV2LT5vdGhlcmVuZF9pZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcml2LT5ldnRjaG5fdHgsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
cHZjYW5faW50ZXJydXB0X3R4LCAwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJwdmNhbi1iYWNrZW5kLXR4IiwgY2FuZGV2KTsK
CiAgICBpZiAocHJpdi0+aXJxX3R4IDwgMCkKICAgIHsKICAgICAgICBkZXZfZXJyKCZkZXYtPmRl
diwgIkNvdWxkIG5vdCBhbGxvY2F0ZSBpcnFcbiIpOwogICAgICAgIGdvdG8gZnJlZV9yaW5nOwog
ICAgfQoKICAgIGRldl9kYmcoJmNhbmRldi0+ZGV2LCAic2V0dGluZyB1cCBjYW4gaW50ZXJmYWNl
LCB3aXRoIGlycSA9ICVpXG4iLCBwcml2LT5pcnFfdHgpOwoKICAgIC8qIENyZWF0ZSBwdmNhbiBp
bnRlcmZhY2UgKi8KCiAgICBjYW5kZXYtPnR5cGUgPSBBUlBIUkRfQ0FOOwogICAgY2FuZGV2LT5t
dHUgPSBDQU5fTVRVOwogICAgY2FuZGV2LT5oYXJkX2hlYWRlcl9sZW4gPSAwOwogICAgY2FuZGV2
LT5hZGRyX2xlbiA9IDA7CiAgICBjYW5kZXYtPnR4X3F1ZXVlX2xlbiA9IDE2OwogICAgY2FuZGV2
LT5mbGFncyA9IElGRl9OT0FSUDsKICAgIGNhbmRldi0+bmV0ZGV2X29wcyA9ICZwdmNhbl9uZXRk
ZXZfb3BzOwogICAgY2FuZGV2LT5uZWVkc19mcmVlX25ldGRldiA9IHRydWU7CgogICAgZGV2X2Ri
ZygmY2FuZGV2LT5kZXYsICJyZWdpc3RlciBjYW4gaW50ZXJmYWNlXG4iKTsKCiAgICByYyA9IHJl
Z2lzdGVyX2NhbmRldihjYW5kZXYpOwoKICAgIGlmIChyYyA9PSAwKQogICAgICAgIHJldHVybjsK
CiAgICBkZXZfZXJyKCZjYW5kZXYtPmRldiwgIkNvdWxkIG5vdCByZWdpc3RlciBwdmNhbiBpbnRl
cmZhY2VcbiIpOwoKICAgIGlmIChwcml2LT5pcnFfdHgpCiAgICB7CiAgICAgICAgdW5iaW5kX2Zy
b21faXJxaGFuZGxlcihwcml2LT5pcnFfdHgsIGNhbmRldik7CiAgICAgICAgcHJpdi0+aXJxX3R4
ID0gMDsKICAgIH0KICAgIGlmIChwcml2LT5pcnFfcngpCiAgICB7CiAgICAgICAgdW5iaW5kX2Zy
b21faXJxaGFuZGxlcihwcml2LT5pcnFfcngsIGNhbmRldik7CiAgICAgICAgcHJpdi0+aXJxX3J4
ID0gMDsKICAgIH0KCgpmcmVlX3Jpbmc6CiAgICB4ZW5idXNfdW5tYXBfcmluZ192ZnJlZShkZXYs
IHB2Y2FuX3J4X3NyaW5nKTsKICAgIHhlbmJ1c191bm1hcF9yaW5nX3ZmcmVlKGRldiwgcHZjYW5f
dHhfc3JpbmcpOwpmcmVlX2NhbmRldjoKICAgIGZyZWVfY2FuZGV2KGNhbmRldik7CmVycl9vdXQ6
CiAgICByZXR1cm47Cn0KCnN0YXRpYyB2b2lkIGJhY2tlbmRfZGlzY29ubmVjdChzdHJ1Y3QgeGVu
YnVzX2RldmljZSAqZGV2KQp7CgogICAgc3RydWN0IHB2Y2FuX3ByaXZhdGUgKnByaXYgPSBkZXZf
Z2V0X2RydmRhdGEoJmRldi0+ZGV2KTsKICAgIHN0cnVjdCBuZXRfZGV2aWNlICpjYW5kZXYgPSBw
cml2LT5jYW5kZXY7CgogICAgLyogRGlzYWJsZSBpcnEgKi8KICAgIGlmIChwcml2LT5pcnFfdHgp
CiAgICB7CiAgICAgICAgdW5iaW5kX2Zyb21faXJxaGFuZGxlcihwcml2LT5pcnFfdHgsIGNhbmRl
dik7CiAgICAgICAgcHJpdi0+aXJxX3R4ID0gMDsKICAgIH0KICAgIGlmIChwcml2LT5pcnFfcngp
CiAgICB7CiAgICAgICAgdW5iaW5kX2Zyb21faXJxaGFuZGxlcihwcml2LT5pcnFfcngsIGNhbmRl
dik7CiAgICAgICAgcHJpdi0+aXJxX3J4ID0gMDsKICAgIH0KCiAgICAvKiBVbiBhbGxvY2F0ZSBy
aW5ncyAqLwoKICAgIGlmIChwcml2LT5yeF9yaW5nLnNyaW5nKQogICAgewogICAgICAgIHhlbmJ1
c191bm1hcF9yaW5nX3ZmcmVlKGRldiwgcHJpdi0+cnhfcmluZy5zcmluZyk7CiAgICAgICAgcHJp
di0+cnhfcmluZy5zcmluZyA9IE5VTEw7CiAgICB9CgogICAgaWYgKHByaXYtPnR4X3Jpbmcuc3Jp
bmcpCiAgICB7CiAgICAgICAgeGVuYnVzX3VubWFwX3JpbmdfdmZyZWUoZGV2LCBwcml2LT50eF9y
aW5nLnNyaW5nKTsKICAgICAgICBwcml2LT50eF9yaW5nLnNyaW5nID0gTlVMTDsKICAgIH0KCiAg
ICBpZiAocHJpdi0+Y2FuZGV2KQogICAgewogICAgICAgIHVucmVnaXN0ZXJfbmV0ZGV2KGNhbmRl
dik7CiAgICAgICAgcHJpdi0+Y2FuZGV2ID0gTlVMTDsKICAgIH0KfQoKc3RhdGljIHZvaWQgc2V0
X2JhY2tlbmRfc3RhdGUoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldiwKICAgICAgICAgICAgZW51
bSB4ZW5idXNfc3RhdGUgc3RhdGUpCnsKICAgIHdoaWxlIChkZXYtPnN0YXRlICE9IHN0YXRlKQog
ICAgewogICAgICAgIHN3aXRjaCAoZGV2LT5zdGF0ZSkKICAgICAgICB7CiAgICAgICAgICAgIGNh
c2UgWGVuYnVzU3RhdGVJbml0aWFsaXNlZDoKICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUlu
aXRpYWxpc2luZzoKICAgICAgICAgICAgICAgIHN3aXRjaCAoc3RhdGUpCiAgICAgICAgICAgICAg
ICB7CiAgICAgICAgICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUluaXRXYWl0OgogICAgICAg
ICAgICAgICAgICAgIGNhc2UgWGVuYnVzU3RhdGVDb25uZWN0ZWQ6CiAgICAgICAgICAgICAgICAg
ICAgY2FzZSBYZW5idXNTdGF0ZUNsb3Npbmc6CiAgICAgICAgICAgICAgICAgICAgICAgIHhlbmJ1
c19zd2l0Y2hfc3RhdGUoZGV2LCBYZW5idXNTdGF0ZUluaXRXYWl0KTsKICAgICAgICAgICAgICAg
ICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNsb3Nl
ZDoKICAgICAgICAgICAgICAgICAgICAgICAgeGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1
c1N0YXRlQ2xvc2VkKTsKICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg
ICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICAgICAgICAgQlVHKCk7CiAgICAgICAg
ICAgICAgICB9CiAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgY2FzZSBYZW5idXNT
dGF0ZUNsb3NlZDoKICAgICAgICAgICAgewogICAgICAgICAgICAgICAgc3dpdGNoIChzdGF0ZSkK
ICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICBjYXNlIFhlbmJ1c1N0YXRlSW5p
dFdhaXQ6CiAgICAgICAgICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNvbm5lY3RlZDoKICAg
ICAgICAgICAgICAgICAgICAgICAgeGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRl
SW5pdFdhaXQpOwogICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAg
ICAgICBjYXNlIFhlbmJ1c1N0YXRlQ2xvc2luZzoKICAgICAgICAgICAgICAgICAgICAgICAgeGVu
YnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRlQ2xvc2luZyk7CiAgICAgICAgICAgICAg
ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAg
ICAgICAgICAgICAgIEJVRygpOwogICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgYnJl
YWs7CiAgICAgICAgICAgIH0KICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUluaXRXYWl0Ogog
ICAgICAgICAgICB7CiAgICAgICAgICAgICAgICBzd2l0Y2ggKHN0YXRlKQogICAgICAgICAgICAg
ICAgewogICAgICAgICAgICAgICAgICAgIGNhc2UgWGVuYnVzU3RhdGVDb25uZWN0ZWQ6CiAgICAg
ICAgICAgICAgICAgICAgICAgIGJhY2tlbmRfY29ubmVjdChkZXYpOwogICAgICAgICAgICAgICAg
ICAgICAgICB4ZW5idXNfc3dpdGNoX3N0YXRlKGRldiwgWGVuYnVzU3RhdGVDb25uZWN0ZWQpOwog
ICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICBjYXNlIFhl
bmJ1c1N0YXRlQ2xvc2luZzoKICAgICAgICAgICAgICAgICAgICBjYXNlIFhlbmJ1c1N0YXRlQ2xv
c2VkOgogICAgICAgICAgICAgICAgICAgICAgICB4ZW5idXNfc3dpdGNoX3N0YXRlKGRldiwgWGVu
YnVzU3RhdGVDbG9zaW5nKTsKICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg
ICAgICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgICAgICAgICAgICAgQlVHKCk7CiAgICAg
ICAgICAgICAgICB9CiAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgfQogICAgICAg
ICAgICBjYXNlIFhlbmJ1c1N0YXRlQ29ubmVjdGVkOgogICAgICAgICAgICB7CiAgICAgICAgICAg
ICAgICBzd2l0Y2ggKHN0YXRlKQogICAgICAgICAgICAgICAgewogICAgICAgICAgICAgICAgICAg
IGNhc2UgWGVuYnVzU3RhdGVJbml0V2FpdDoKICAgICAgICAgICAgICAgICAgICBjYXNlIFhlbmJ1
c1N0YXRlQ2xvc2luZzoKICAgICAgICAgICAgICAgICAgICBjYXNlIFhlbmJ1c1N0YXRlQ2xvc2Vk
OgogICAgICAgICAgICAgICAgICAgICAgICBiYWNrZW5kX2Rpc2Nvbm5lY3QoZGV2KTsKICAgICAg
ICAgICAgICAgICAgICAgICAgeGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRlQ2xv
c2luZyk7CiAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAg
IGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgICAgICAgIEJVRygpOwogICAgICAgICAgICAgICAg
fQogICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgIH0KICAgICAgICAgICAgY2FzZSBY
ZW5idXNTdGF0ZUNsb3Npbmc6CiAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgIHN3aXRjaCAo
c3RhdGUpCiAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgY2FzZSBYZW5idXNT
dGF0ZUluaXRXYWl0OgogICAgICAgICAgICAgICAgICAgIGNhc2UgWGVuYnVzU3RhdGVDb25uZWN0
ZWQ6CiAgICAgICAgICAgICAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNsb3NlZDoKICAgICAgICAg
ICAgICAgICAgICAgICAgeGVuYnVzX3N3aXRjaF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRlQ2xvc2Vk
KTsKICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgZGVm
YXVsdDoKICAgICAgICAgICAgICAgICAgICAgICAgQlVHKCk7CiAgICAgICAgICAgICAgICB9CiAg
ICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgfQogICAgICAgICAgICBkZWZhdWx0Ogog
ICAgICAgICAgICAgICAgQlVHKCk7CiAgICAgICAgfQogICAgfQp9CgpzdGF0aWMgaW50IHB2Y2Fu
YmFja19wcm9iZShzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LAogICAgICAgICAgICBjb25zdCBz
dHJ1Y3QgeGVuYnVzX2RldmljZV9pZCAqaWQpCnsKICAgIHhlbmJ1c19zd2l0Y2hfc3RhdGUoZGV2
LCBYZW5idXNTdGF0ZUluaXRpYWxpc2VkKTsKICAgIHJldHVybiAwOwp9CgpzdGF0aWMgaW50IHB2
Y2FuYmFja19yZW1vdmUoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldikKewogICAgYmFja2VuZF9k
aXNjb25uZWN0KGRldik7CiAgICB4ZW5idXNfc3dpdGNoX3N0YXRlKGRldiwgWGVuYnVzU3RhdGVD
bG9zZWQpOwogICAgcmV0dXJuIDA7Cn0KCnN0YXRpYyB2b2lkIHB2Y2FuYmFja19vdGhlcmVuZF9j
aGFuZ2VkKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZW51bSB4ZW5idXNfc3RhdGUgZnJvbnRlbmRfc3RhdGUpCnsK
ICAgIHN3aXRjaCAoZnJvbnRlbmRfc3RhdGUpCiAgICB7CiAgICAgICAgY2FzZSBYZW5idXNTdGF0
ZUluaXRpYWxpc2luZzoKICAgICAgICAgICAgc2V0X2JhY2tlbmRfc3RhdGUoZGV2LCBYZW5idXNT
dGF0ZUluaXRXYWl0KTsKICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgY2FzZSBYZW5idXNTdGF0
ZUluaXRpYWxpc2VkOgogICAgICAgICAgICBicmVhazsKICAgICAgICBjYXNlIFhlbmJ1c1N0YXRl
Q29ubmVjdGVkOgogICAgICAgICAgICBzZXRfYmFja2VuZF9zdGF0ZShkZXYsIFhlbmJ1c1N0YXRl
Q29ubmVjdGVkKTsKICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNs
b3Npbmc6CiAgICAgICAgICAgIHNldF9iYWNrZW5kX3N0YXRlKGRldiwgWGVuYnVzU3RhdGVDbG9z
aW5nKTsKICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgY2FzZSBYZW5idXNTdGF0ZUNsb3NlZDoK
ICAgICAgICBjYXNlIFhlbmJ1c1N0YXRlVW5rbm93bjoKICAgICAgICAgICAgc2V0X2JhY2tlbmRf
c3RhdGUoZGV2LCBYZW5idXNTdGF0ZUNsb3NlZCk7CiAgICAgICAgICAgIGJyZWFrOwogICAgICAg
IGRlZmF1bHQ6CiAgICAgICAgICAgIHhlbmJ1c19kZXZfZmF0YWwoZGV2LCAtRUlOVkFMLCAic2F3
IHN0YXRlICVzICglZCkgYXQgZnJvbnRlbmQiLAogICAgICAgICAgICAgICAgICAgIHhlbmJ1c19z
dHJzdGF0ZShmcm9udGVuZF9zdGF0ZSksIGZyb250ZW5kX3N0YXRlKTsKICAgICAgICAgICAgYnJl
YWs7CiAgICB9Cn0KCnN0YXRpYyBjb25zdCBzdHJ1Y3QgeGVuYnVzX2RldmljZV9pZCBwdmNhbmJh
Y2tfaWRzW10gPQp7CiAgICB7ICJwdmNhbiIgfSwKICAgIHsgIiIgfQp9OwoKc3RhdGljIHN0cnVj
dCB4ZW5idXNfZHJpdmVyIHB2Y2FuYmFja19kcml2ZXIgPQp7CiAgICAuaWRzICA9IHB2Y2FuYmFj
a19pZHMsCiAgICAucHJvYmUgPSBwdmNhbmJhY2tfcHJvYmUsCiAgICAucmVtb3ZlID0gcHZjYW5i
YWNrX3JlbW92ZSwKICAgIC5vdGhlcmVuZF9jaGFuZ2VkID0gcHZjYW5iYWNrX290aGVyZW5kX2No
YW5nZWQsCn07CgpzdGF0aWMgaW50IF9faW5pdCBwdmNhbmJhY2tfaW5pdCh2b2lkKQp7CiAgICBw
cmludGsoS0VSTl9OT1RJQ0UgIlhFTiBQViBDQU4gYmFja2VuZCBkcml2ZXIgaW5pdFxuIik7CiAg
ICByZXR1cm4geGVuYnVzX3JlZ2lzdGVyX2JhY2tlbmQoJnB2Y2FuYmFja19kcml2ZXIpOwp9Cm1v
ZHVsZV9pbml0KHB2Y2FuYmFja19pbml0KTsKCnN0YXRpYyB2b2lkIF9fZXhpdCBwdmNhbmJhY2tf
ZXhpdCh2b2lkKQp7CiAgICB4ZW5idXNfdW5yZWdpc3Rlcl9kcml2ZXIoJnB2Y2FuYmFja19kcml2
ZXIpOwp9Cm1vZHVsZV9leGl0KHB2Y2FuYmFja19leGl0KTsKCk1PRFVMRV9MSUNFTlNFKCJHUEwi
KTsKTU9EVUxFX0FMSUFTKCJ4ZW46cHZjYW4tYmFjayIpOwo=

--_004_5a2d079fe8db41338464381dd2dc9575actiase_--


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 08:36:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 08:36:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238738.413788 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9UX-0008UT-Sg; Mon, 06 Dec 2021 08:36:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238738.413788; Mon, 06 Dec 2021 08:36:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9UX-0008UL-Oz; Mon, 06 Dec 2021 08:36:57 +0000
Received: by outflank-mailman (input) for mailman id 238738;
 Mon, 06 Dec 2021 08:36:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mu9UV-0008RJ-Kd
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 08:36:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa4dfd6f-566f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 09:36:54 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-tafLl-8fMfulVtp6SpfboA-1; Mon, 06 Dec 2021 09:36:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Mon, 6 Dec
 2021 08:36:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 08:36:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0066.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::43) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Mon, 6 Dec 2021 08:36:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa4dfd6f-566f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638779813;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cGc8cUwvGg7L/5Dgxzq27jqpcFYF9MeWp9OU2x0atT4=;
	b=XsH9Bc7Qf0ZHFxs+ZvmCA6u1N5BYolvwjT53rio2grzNKKZnvsd6YV9HARq9yOu9LHs0OP
	3NsdTRuYRfb6NJIoi1EeN4cxfkT6JuXMy2h7BE+37T73GUdU00iaMfzaaPnKgnoMYkE3S2
	et2qJM93c13ueiBNa8vckfizpE8ZBvI=
X-MC-Unique: tafLl-8fMfulVtp6SpfboA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ey9fYSnLpvkHym19sTIg2AyGQlHR3VIwTgT5DPeKlQVDxrBFokbubXxq/l89+Tdt/KGh5gw/uTJdbvFC4zSY3fvw1W4QeTbj8kdghxS3FTpCm6m8IJIdJ1VCrPcfD5/w+Ne/5YhhDTQPYmDex0wLSHBjcMnaTRkFiPWLeRxZt5pOMHGVkSh0OjFsInn9G9OOaND4oZu0n4J/OQ83rEJ7werTQvuHhvwkitKQpzFJMz9qCByjXT9Fklm2rfD4/qjiqlxdANGZ107cE3opXIezqQvO6RaYOwRa6EmAmjD0AxP8N/30140r2RupiEHrEYXXkWTWZ32K5zbYWypexxvdig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cGc8cUwvGg7L/5Dgxzq27jqpcFYF9MeWp9OU2x0atT4=;
 b=PymPTwGbo+uLuo/h4zDDuKyVXIT2zBcGyh1+6pxj71UBN/voeA256JaAjtjVJ/RZSEZ06JX5pBYUBD/vddQGaxg7pFn2Kx/Z24XjhFwDlVvB65pMO5MxoWk7j/5vV7/xUqTwE24mizXydIzxCkm5pbutQYL2xWlZdj6Lph5pt0XrC4KQUsjM1xecQubBOnMbF7ccijBShyUQeKZg3R2SO9m0hP2EUYe32qiDEp4DYodEoYcwD2qpwgn78+RrOpM7z1/0Ebv2dVd+AgwguOPNhz35xni3oyqhTMyLtffubYkPkzejTRteO10kLcysQybOXDrfCMQkl5eqgy3HKhkBHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bddd9fc4-d442-9272-0fcd-4472c83e36e7@suse.com>
Date: Mon, 6 Dec 2021 09:36:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 08/65] xen: Annotate fnptr targets from acpi_table_parse()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-9-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-9-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0066.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::43) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e681c21a-c8f1-439f-8a64-08d9b8938cb2
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2606181CBBBA7101EC950150B36D9@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N38PW756cwQeWkRB0JBRSTQ+u9t6PgIA3WNRMtPm78bB4uTs48oqr8yo4IO+HMMAWX3arxbPQG5vZZs8fyqUgRgJYd+Vlduq6UbwPFENtjDF5Gkbw9Q7aVUn+dy9ET3CVDD8mdIlxRFqQ5kmqBGE2N6cqE6Ib2u77BFhBIVDsiQj1WcoD6JBj/NLEMBe9Pr7G3h4yLhOfnXkqG/zmEIuYPOVz5bMBSqsaji1roi3syXEcw9PByg5E5RDmyHSyPnzyRRSmygsSI5yNix9Br2gZruYzE5YcRz9jveKvyVezxzfW2L0nucuTTcxumEG0AKP2bHKBnHYH/V8ldK23xe/MfV9Crh57u3uI3s7E+kRYlIpjUM3ptPi0DVjwJaUS+rZT39vXb4rdwhF8C9llYALhb7a4z9oSzLFXrS/H56yexYc9nkD+MVcU6PUI6N5JEY11YrgpyryipOFUYBeEcvI/2HPXi1PnCq6NGC46RhQYls4COwr+D/1JGFObVBk1uTcLWDvi4+nT4njzJL2Pw03rj/VpLl9X+Q7bPzAcbES+kDXp5z075xS04ymQh254lk4SIWbpMGGvqiVMGWxQGyDWFObzSboPRTPbITG5CvEQkEC2ky+JZcNX61omCnBtxqKFlz/vlnULFBeb2HxHOziKbhEmVmuTjweoZiQ1N6/R6lZpK+8+mTR85AezjZW4hdgMSchoFSs1gSe5yshM5JihJG+/OHKXxRR+tHXGpUJ8wY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(2616005)(45080400002)(26005)(2906002)(956004)(316002)(16576012)(66946007)(4326008)(66556008)(8676002)(66476007)(38100700002)(6486002)(5660300002)(31686004)(86362001)(6916009)(54906003)(83380400001)(186003)(8936002)(53546011)(508600001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UXNLcGltTEw5OW9MMGpsNFRsYzFudm40Q1M5MlB1N2EwNUtjRWkzbnJVSjh2?=
 =?utf-8?B?a0JNbHhqcGNiTzFpZkREQmEzMEJWbVJOdzVBbkNtMkl3eTQzclNzMUxZR1lr?=
 =?utf-8?B?c0ZFYWZLR0ZlNjBUcStnSkNKVjdtbHd2SjUwYk85U3FzelVYWTJ2Qm1KbHRG?=
 =?utf-8?B?WnNtM2szNnMzSmhNRC9XODV6bEM0Szc3Tm5Mamo0VitDR0ZnMm1Gam1qc0Fv?=
 =?utf-8?B?dVJ4NlZ3T3hDREtXaHhpL1RhY1FDb3RJcmFpaEZJaUZxMzlveERrMnFjZ2Iy?=
 =?utf-8?B?RDF3dW1TeGlKTWhETjBZUW9ML2QzaG5XL1BrQlhpMVpGWGtuQU84Rlgrblk1?=
 =?utf-8?B?UC85aHV6QUtFL2RYWTB2cW1TOE9KT0g2aGRneHd1OVZTVCs4V1FYcElHK3Mr?=
 =?utf-8?B?ZHNoaVRSZGkyZ3NIS3F5WFR2L3VLczJNbDJLdG1Zd3JBdFdOdGF2U3FqakJE?=
 =?utf-8?B?SVZzMEEyTllCSHBGelNQeDlGYzVRUzF3cDlpeitJY0pRNTdQcDN5eDAraDB0?=
 =?utf-8?B?ckl4Z0ZBQUdRNVhncXYwOGtock9lMjluNTBib29sMFR0bG4weHVqSE90cFpU?=
 =?utf-8?B?N2tnNWY5dUxoR1ZuWTBFbVVtRHpVU2ZJam5XYzU4RXZsckdDZDVhWkloQWNB?=
 =?utf-8?B?dlZRakltaitQbFdISCtBRHVmbGtSOTRmc2NWVzlJeVVEbXEyckFEVnBiR1Ri?=
 =?utf-8?B?UDVIZy9iVTNXYzc1VU55WTNnN0NQZVhsRG91RU9PTzhpU0hsa1pYYW5OSTQ5?=
 =?utf-8?B?Q2o0ZVdMWk9rZnBzVFVWcUFDTE52WkdhbnFmeE5NQ2EzZDFoS2ZUWHlkSDNW?=
 =?utf-8?B?bFl5YnNkYlZZU0lvYk8rSHgwelhIa3dRdEovNHYwaExzQTdMbDFFQWd6eU9i?=
 =?utf-8?B?ZlMyRDZoSmhyWDNGKzUwWm8rcmNxaUFnSFZjWmp3UkRvQ1lOVS9mNmk0aEQ1?=
 =?utf-8?B?Y04xaDdjZEgxTldXaWRXMUVVUkdWS1pCVzRvcHRvZGc1NUltdDcyTFdBOWF0?=
 =?utf-8?B?QytmT1JQdkFGL3A0T1FlSmVzYUVWM3lFbzYyVm45RC9YRVFoTEQ2RWZvaGZx?=
 =?utf-8?B?dVZpN2krSUNUakwrQUN4em5MTjJHajM2akpKMTkwcTR1RjV2QTFmaG00aFRQ?=
 =?utf-8?B?S3doclc4bHJKUm9JWFVTeE1TTVA3bklVblVFdVRMMHNxT1M2TEltTmw0Y1Fh?=
 =?utf-8?B?ZzNON1JpTjJHeHYzOGpBeUdjZnBOQWtlaHZjK1JZWEptWlFvZEJEdlRYVEgx?=
 =?utf-8?B?VS9ZaTNCL0lmNDJIT1VZNGdmSTMrSHUybE5HWmkxd0J1ai82YmhNeDRJd3BM?=
 =?utf-8?B?VHZPaXB5c1B2WDRlZ0lLWkMzSWVjbDMwOTJvUkF2S1FIS3FOOTQ0UTV5Y21v?=
 =?utf-8?B?WnJ6cEVLRXYybmlpdThXL0RyekhOTEhmTXdVclgzejgxTWM3REZTNGZXVytG?=
 =?utf-8?B?dXpOOWozOVN2SEF2bDl1U0pNZmlhbjZSTGI4bU11YWUwcTEvckVLZytCeURw?=
 =?utf-8?B?c09EV2JOcFRqVEZabVVxT0RWdVpHZWdOL0ZEaWhCRE5iMko2ekZhNFlJbHpK?=
 =?utf-8?B?RWhxMkhqTXlKOHAvN0lVOU5JcXcybEg3cUliaGlBWkp1eFc0MlZ4ZlJSbjB0?=
 =?utf-8?B?bGo1aENBRXJMem1nU2p6MWJCWUYwYVdUWE1ZWnpHUktDU2RyVktaM3hubDJw?=
 =?utf-8?B?NHhHUDlFWXEwTWJkbCs4RFpxNDMyR2x4anY1NUloVzN3Y041TU5Pa2Z6MjY4?=
 =?utf-8?B?dVY2Y2NMTGxLRi94SUZoNm1UTVN1ZTduVk1ZenNFa3pTS0RiWlVpck0yYll1?=
 =?utf-8?B?c0NuWEVPSXBWUlBLNVhtdytFZVRkNXg3S0lINHdraU54dTQrakVJZ2xZOElB?=
 =?utf-8?B?NmRkbkhFTHg5djlxdE5pbDVqWHBSRGl6SEJ2L2RrUFhRNmdGVnJFYnU3SVpw?=
 =?utf-8?B?UGg3RHljMmlDNG5BZStVUUp4aDNiNEEzT3g1VmZJQ3BoQnlzRy94WGtXSlpY?=
 =?utf-8?B?RGZHV3BNUjFpOEZ2YmJTYkZiZExNOTZveHlVMVNmaHgxLzNsU1ZjRmZwS2Nq?=
 =?utf-8?B?WjVMcitMdysyd0xhMSs1OEpramp6QUZpWWdKMEhXTWxQUWVOOGNvYVNiSmQx?=
 =?utf-8?B?MzBpNkxVaklWakJneVlCb044WjZmQlJuSVNtL2g4VnBRbzlIbWo1Z1V2Z0RK?=
 =?utf-8?Q?osQ4d05JOqrJ2ARNZtF0oA8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e681c21a-c8f1-439f-8a64-08d9b8938cb2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 08:36:51.1299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VzdxF5H1nUbUP7CFioKCTERZK66+UdDU5Dn4hunZZuWNEHXb6vxDUkH3FSgvOFSb6w3CVkgRDhSI8X9h0W7fkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

On 26.11.2021 13:33, Andrew Cooper wrote:
> --- a/xen/arch/x86/hvm/dom0_build.c
> +++ b/xen/arch/x86/hvm/dom0_build.c

Elsewhere in this file we have

        rc = map ?   map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn))
                 : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn));

which has been in this shape only as of commit e3b418ac4919
("x86/pvh-dom0: Remove unnecessary function pointer call from
modify_identity_mmio()"). Aren't we relying on the compiler not
transforming this back into the earlier

        rc = (map ? map_mmio_regions : unmap_mmio_regions)
             (d, _gfn(pfn), nr_pages, _mfn(pfn));

? And aren't we further relying on the compiler not transforming direct
calls into indirect ones for other reasons (I recall Microsoft's compiler
being pretty aggressive about this when the same function was called
more than once in close succession, it at least certain past versions)?
Is the widened effect of the annotation intended to also guarantee that
indirect calls will not be produced by the compiler for any reason when
the annotation is absent on a targeted function's declaration?

I've made an attempt at auditing our code for further similar constructs,
and I couldn't spot any. But the pattern isn't easy to grep for without
producing a very large result set, so there's still the chance that I may
have overlooked something.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 08:40:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 08:40:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238748.413800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9Xc-0001sN-Bm; Mon, 06 Dec 2021 08:40:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238748.413800; Mon, 06 Dec 2021 08:40:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9Xc-0001sG-7l; Mon, 06 Dec 2021 08:40:08 +0000
Received: by outflank-mailman (input) for mailman id 238748;
 Mon, 06 Dec 2021 08:40:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j7EA=QX=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mu9Xb-0001s7-9c
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 08:40:07 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20612.outbound.protection.outlook.com
 [2a01:111:f400:7d00::612])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1bcd075d-5670-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 09:40:05 +0100 (CET)
Received: from DB6PR0501CA0019.eurprd05.prod.outlook.com (2603:10a6:4:8f::29)
 by VI1PR08MB3967.eurprd08.prod.outlook.com (2603:10a6:803:df::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Mon, 6 Dec
 2021 08:40:01 +0000
Received: from DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:8f:cafe::fe) by DB6PR0501CA0019.outlook.office365.com
 (2603:10a6:4:8f::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 08:40:01 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT036.mail.protection.outlook.com (10.152.20.185) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Mon, 6 Dec 2021 08:40:01 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Mon, 06 Dec 2021 08:40:01 +0000
Received: from c033d31f18c0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9BDD2AA8-CCDE-49CA-98C1-817EC150A7A1.1; 
 Mon, 06 Dec 2021 08:39:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c033d31f18c0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 06 Dec 2021 08:39:45 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PA4PR08MB5918.eurprd08.prod.outlook.com (2603:10a6:102:e7::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 08:39:43 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622%5]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 08:39:43 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LNXP265CA0075.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Mon, 6 Dec 2021 08:39:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bcd075d-5670-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DXPbVL2EdEFUiGXcxX5ln7kXU648RW6dIlZm86JJVgo=;
 b=MzP3W7delf2qLP4Inqfye8e8DydJTOkayGck/eIGtPQtMzhQABeeR+coJsueWwOM3vtKD2Cr0qgOkYOXU1nbrJ1u5cvmrG9kLusaADDc5v2TURnI0t93M3PcM7MEbc/NciScDu22BYyD/a1SFM2GSJPw6SthxEJpQFR+FpKpSx0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 42c5fcbab6fa6cec
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WRlEC2FT+0nPVtObVgZbZTJzYB2Mf356lvyBRC+CyZ08WdJRt1eMTwss7cONv3sBsJ0wikyZTyaMOqO1UKTGd9rjbZI83tFNRHIRNaN4qd9GQGuXeBtHKCDRyBXcyEXwadMtmTV0DmjK1JtZejAow0CiXj65Ypu6abg558T2Q3b9Rc4oN9IS5AN/K3UHrCah6jJ6yjF2R7g4JGIqg1Ug18PN4BShtYf6k6b8qXM73X0G1YMCDDDKfY6hBw0kpIoOjuD5mdSoZ9yrpoQp2SmfhATndLsQUaJNQN2sO+A8cOo/uu/voaQZuzDVcJmwuwZExZKqzFdYwM8LCDjbfwfsxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DXPbVL2EdEFUiGXcxX5ln7kXU648RW6dIlZm86JJVgo=;
 b=PkwoAmfG1Q/bkeYoTS8L9kCB+Lv4ChUsNdHmzASbW8OisvsBhSDChNQg7hR7PnjnIc2BDFCn+L78mpM0wLCte3aUpo7f6to59vkuR0GCK0ytG7oXB62jL0XrajWcIxZLiP6CfWXCoRFgfdJm2Eev/HlkEDnGpM9TQCU0A7QA0ZHmhEFfh3/9ss1/qRf8BSq2UsAWcXaoDtC/pCH2j9uq+HnydKLD1S5qEIFNio6plUQOQZLeJwCWh48+Chcj8WZLYFLmqgRoS0liyoM2OBYQvQhwjAVttBuPhtb73rW5XhnpGIRMtf4k0fgfjtiSO9cFJbSvGQx3VHmu336RcpBXQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DXPbVL2EdEFUiGXcxX5ln7kXU648RW6dIlZm86JJVgo=;
 b=MzP3W7delf2qLP4Inqfye8e8DydJTOkayGck/eIGtPQtMzhQABeeR+coJsueWwOM3vtKD2Cr0qgOkYOXU1nbrJ1u5cvmrG9kLusaADDc5v2TURnI0t93M3PcM7MEbc/NciScDu22BYyD/a1SFM2GSJPw6SthxEJpQFR+FpKpSx0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <1a6dd0a2-5a09-d39f-b0b9-c7c33f313403@suse.com>
Date: Mon, 6 Dec 2021 08:39:35 +0000
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4DF1E272-4A0E-43AE-8140-B5B9B4C3252F@arm.com>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com>
 <F1FE39BE-191B-4245-84EE-1109B9762B54@arm.com>
 <1a6dd0a2-5a09-d39f-b0b9-c7c33f313403@suse.com>
To: Jan Beulich <jbeulich@suse.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LNXP265CA0075.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:76::15) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: ecdba553-e770-49cb-b23f-08d9b893fe2a
X-MS-TrafficTypeDiagnostic:
	PA4PR08MB5918:EE_|DB5EUR03FT036:EE_|VI1PR08MB3967:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB39678EB099FA209DA177098FE46D9@VI1PR08MB3967.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CgRRzr7ZuNVfyYWxLUkNFyQceiuV1dnZELtqn5amzEu1AU0AVrmN159ARd1YmxgojmB5gf1P9tzc9UHgTeC8PonfXt1mW7XBVpPMfhnfUm3MvzQmdliTDGSXIZa7G6eJ9ehjgc2K2QPsRVwEnKFfiF3KE7HLoXJ/aO0+S0QL74IBCiosaX1ulCBSlLOUlPYdUCfiyUdaS3kHg6+pFi2Vpzh0vjQTv6dWeTquZcwnLzMgeT3mhsBZph5lHyaizyJwtmUYsFtFU4ojoVlOUYBZN+cFLmKj0lBvBeAJjYtOuQNFJCecj1fjMQansFTUuEeFAbRhYjxDvfcsPHm41bvkShUI3fi1xIdTXphOrOS26xLfRdMeIbHMIPKYN2OwlKNBwcZEzSwKVnNfNMcCPQ2E2RW9avZuO6LuFE2YbyV+dMZac7LVD2OJcvGZItZ/w+mLN2M6FuSWWZnKcvu9FbUoKEVfVjaWhojRErpvmTqGLUiuhmI8PSU13lBBjH+XDB9l6hJnDV8ofUhEDg0t/wFb55dGXr7HBdsG2LOfwWczmaeg2WZrkrRXYR3TfnFXaf2qprv+DWMLL1rhtTOOiCVEY5OkbM9yXENItc874FX0Ca3ryFY8PpW6AgLqHVF5EPpvU9KOKuJ2d6bYxi1tPhKEhnMLfD48xPEEN5EMmiuImFlrBUxDfLADBeN6kswI5RvRb91UzQ0Dxir6/j6tIPHwdPCjxdtm446/9sXW/9PwSgENMZ2C6mS5AbxYEd6jTXfa
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(38100700002)(38350700002)(508600001)(53546011)(83380400001)(6506007)(2906002)(186003)(8676002)(6512007)(26005)(5660300002)(33656002)(6916009)(66946007)(66556008)(6486002)(44832011)(66476007)(956004)(52116002)(4326008)(54906003)(36756003)(2616005)(6666004)(316002)(86362001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5918
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9f06d6c5-2927-4527-b622-08d9b893f32f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jwnvFn+D8twBR2bFh7RS/3b3IBW8H+iDHT2GONxHLmMUDIh+w3CmMb1Ay4t3Du+o+mOjMNlebmo/gPhOnxLZuGQV18u4+ppPi+hDxQEOccaIBCff4x2VAW5/40A73EPaJIotDnSENYl7TsTUfKfQTXvrRhvvP95okoEMEya7K00jGJAWdeRhbpMrX/mFUnEA2TgA+5a0Nub9+q02K9e1gHzASYB/vSPA8BCqAnKLUCnatO10nttL4NBgwqj5BDx9mjpUcUIoBLm5NbffTPD4KPtpbeL5TCW1wZ86cj1Q+MkSuCikLIjbNKPDVl71IpUFd7iWIgH52USDnpgmIlNJvdTxqarKao68LFXl/ZIIOpV2NgDH5DLjsQx1xOmwN4OCzr/rpLuWXD13NxZCiKRQMYumccP9DDU+/JGmWmeYxwwXrhslHv6879e/X6rua+YrO4YAhTGgMIbnqLWtGQw4vOYBa0jUWt6tAF1f3wzUhvlGwBFh77kurC7JzqKWofzdKcDk3efMev2qyjGzvhSTcwlLyZ4jpf8Oi5/bUeb9pztSeecK9c0Wy3nL9A/lRrKpbD4Ti/WGZQiYqVm64QRHps/biSunCKbW2oQpAvLWdAU/5G9zKEUW2GzzyLDYc04MCheEBlXxsMCOF89Z5Z2rHQPDKJBbdhjbPPAfxO8h3ogzsMmv6bu3XzRNh1iKRsM5D0nhehh7LeRMnlDKkTRYKQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(44832011)(70586007)(82310400004)(36756003)(5660300002)(53546011)(70206006)(54906003)(956004)(6506007)(6862004)(8676002)(8936002)(336012)(4326008)(2906002)(26005)(186003)(33656002)(2616005)(6486002)(356005)(83380400001)(81166007)(47076005)(36860700001)(86362001)(6512007)(316002)(508600001)(6666004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 08:40:01.3393
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ecdba553-e770-49cb-b23f-08d9b893fe2a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3967



> On 6 Dec 2021, at 07:27, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 03.12.2021 17:10, Luca Fancellu wrote:
>>> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@suse.com> wrote:
>>>=20
>>> When it was introduced, it was imo placed way too high up, making it
>>> necessary to forward-declare way too many static functions. Move it dow=
n
>>> together with
>>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>> immediately ahead of the #include,
>>> - blexit(), because of its use of the efi_arch_blexit() hook.
>>> Move up get_value() and set_color() to before the inclusion so their
>>> forward declarations can also be zapped.
>>>=20
>>=20
>> With the =E2=80=9Cconst=E2=80=9D attribute now some function in this ser=
ie are above the char line
>> limit, however everything looks fine.
>=20
> I wonder which part of this patch you're referring to. I don't recall any
> addition of const here - I think I'm strictly only moving code around som=
e
> code and delete some declarations. I've further checked the code being
> moved, and I couldn't spot any line going beyond 80 chars.

Yes sorry, it was a comment for the second patch, where you constify a=20
function parameter

>=20
>> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
>=20
> Thanks.
>=20
> Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 08:47:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 08:47:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238755.413811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9eP-0002kI-2s; Mon, 06 Dec 2021 08:47:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238755.413811; Mon, 06 Dec 2021 08:47:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mu9eO-0002kB-VA; Mon, 06 Dec 2021 08:47:08 +0000
Received: by outflank-mailman (input) for mailman id 238755;
 Mon, 06 Dec 2021 08:47:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu9eN-0002k1-Sh; Mon, 06 Dec 2021 08:47:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu9eN-00018r-Ha; Mon, 06 Dec 2021 08:47:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mu9eN-0004h4-6c; Mon, 06 Dec 2021 08:47:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mu9eN-0007hx-6B; Mon, 06 Dec 2021 08:47:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UbJiaprPiugHI4WPgTxpP3WCkO3uzH6KxKZM8hXnpew=; b=WIxf38qN2H/0Q2AbsJC22Eqi0q
	1QwGXO5tvjyWsGl8dwLw0NYf8PH6SVhFC6Gf/UZp0cJ7alzO0fsPMjYiBDsH9YQHi9uaIukbvRzZq
	ukFI9P7FfR9oTMcopjMKN8rmvnBbCEpNnexmGyCUPJcMrku7INyR7fXDP15Cgo3NJvsc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167178-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167178: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4cf9f43f1da4f3a54cb71caecdae18950046e03b
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 08:47:07 +0000

flight 167178 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167178/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4cf9f43f1da4f3a54cb71caecdae18950046e03b
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  514 days
Failing since        151818  2020-07-11 04:18:52 Z  513 days  495 attempts
Testing same since   167130  2021-12-05 04:21:16 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 86571 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 09:43:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 09:43:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238772.413825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muAWD-00016E-GI; Mon, 06 Dec 2021 09:42:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238772.413825; Mon, 06 Dec 2021 09:42:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muAWD-000167-DA; Mon, 06 Dec 2021 09:42:45 +0000
Received: by outflank-mailman (input) for mailman id 238772;
 Mon, 06 Dec 2021 09:42:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muAWC-000161-5T
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 09:42:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id db8c2fdf-5678-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 10:42:42 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-HTbxj_4rNw2fo1am_lrOlQ-1; Mon, 06 Dec 2021 10:42:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 09:42:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 09:42:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0063.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::40) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 09:42:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db8c2fdf-5678-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638783762;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OIrDnTas8zwAPPDeyyTSIXpj1SlL3QBX2vGbydk8SGY=;
	b=Fp1rfMKQL3h1IJQYBn6pmNpgEIwpCsfy8e43vafEGfyQWzDwmVFz7W/c8XgJze6b9+5sGB
	mRjp1VomEjM5HEUOxLTGNuES/c2KWTWKvat+JuIUYFjiFbryxPxBv57HrrXaT+GrnTwhmh
	UrpgGe+TgojtTQUkpViZFqs59g5v4JM=
X-MC-Unique: HTbxj_4rNw2fo1am_lrOlQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LgmLJK/XSq6A9xO5arv/61CX8kQMEKM9NOlibOsv88l+lTHfRbd0u39rzGxGb7vrO/KPtpfJM9boL79ILGOd54oETqoe/JlPlK4zUytYGz7MBbA6V4U5mp17INQMEekMHqz6pOlTdAEodYo7JDZNT4q63Cqzt3gmRKLR7XrOJ8DuLBeXgVQEpc5ABMiwGe91cn5vIHZfiCcrtockIq1zlTvm59PMJbCH1X2GT43KE8OSn0NdmEmLfeQVocLxf02wAWxp/VT3ff79jMCQpY+C4U0Gf02Ht4t2klIARDWHNFcmbv+4AeYyrftSstrDtHsh5v0ejfzL/vz4g2q0rhGhoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OIrDnTas8zwAPPDeyyTSIXpj1SlL3QBX2vGbydk8SGY=;
 b=D531wMv5ELd3+dB1yZv7vu6YYah6Oa6XAWaoZFTygxw4pLDscBzz0SBrZRKkfjL36FcQyzmJKp5ln2atiWM66bwIRrJdBJTdaFMvx1utm/hc06DeViBB5As4LrN2Uon9A9JlgpNMRrLhwIek43Tj2taFism95lFJxGolABJlpEeOHr0QJzErjyE0Npb7SvyIXKJC5KRTDzPipwjsSFZPXE0mVPbQSdVxUR+yrguef6zsN9DNSszqRcJdSFTTMEO19IzmKpYCtJl6v12uO89+y/Ev3JfjGAs6OofgS9qna5uXugHc3z2Ov9HB23f3XYJIWj8bTw72f3a32Wban8TNvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <22317ebe-4e21-5515-9061-33b21eefd4ae@suse.com>
Date: Mon, 6 Dec 2021 10:42:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
 <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
 <a96abdb7-cdf7-2b24-d293-d3d2c6c77c78@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <a96abdb7-cdf7-2b24-d293-d3d2c6c77c78@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0063.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 19f53c71-d1c0-42ab-11d5-08d9b89cbe3e
X-MS-TrafficTypeDiagnostic: VI1PR04MB4845:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4845BEDBF8F3DB559F1F6A24B36D9@VI1PR04MB4845.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	oz9SXZyWpfnNvMzmPv0FteR0Ul2IZXAOAK/3kFa5NDZQu2H4u1Y73eumhnvr5gYzcoOtqRddFgAfTfFKSBM7DbFuhCajz3K+hwuvtPGMZaP+UKXJi5zuzg2sb0jxEx7PAPGlwH1jKbdMEAedWCFsbz8jXJCjj65adUV0QqgrUTPO5YFDeSzcHNSmiZYpb6xkyWsHBn6Ka9l8Yy2jk79cz0CTgbtFQa/dUPpG7dZ4cqg/zt+GoQT3wHictWgexouwenCtwwuCyMfqOqzNxPy2VFKu3QxSc16ArrlrvGhKgCTF2pLeVQNxYdDdmzoFtsX+o5kInstIgeGdd9tw17BJklkfT3fZK7FoXFbDVwtHrBBMQJc+bKghO+YYkV05a9HDujlqFfFy33BedtrPKtM7C2ocborx3bQtmhHH8GXMgO/cjwI05jsP2trm4rJWncUnhAXQtI7hj6r+/MI6YDtNVH6byZsMReiDMovat8RAYc+aZ/nebm1fM4crJvXB1z4sCW18+KGzzqwCoQiKg6DpBgu4xze6IkiBN8hUP/YVR8UFPi7jBj2oqMFbR6q7/MIPwefABjaPGW8gwSwu9vi28rpn3aLBohk+aFvJRD/f1rjZEATpfamqu3rAUEgWp/0jCLy+kqbc4v34m5FoCb4BxhYOC9aPywNMvrCK1ZKMHNiS6dBV5EyYwwieF65bg70PCa2HcXss426gnjz/FS1q7VoylJzkXyO13xMxEw/+qek=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(110136005)(16576012)(316002)(8936002)(54906003)(31686004)(4326008)(53546011)(8676002)(956004)(2616005)(508600001)(83380400001)(26005)(186003)(5660300002)(66556008)(38100700002)(6486002)(36756003)(2906002)(66946007)(66476007)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dHpHV2crL1VOVmM4dk1JMEU0WVk3VG16NXpOWWFlZnZXNzhmcXpCSlRUSDVk?=
 =?utf-8?B?NURWWHRURXFHTy9uZHl1VGdhczJHRi9xRkxjL2oxc2xaOXp6K0EvYWRXMVJ4?=
 =?utf-8?B?a0Mrd2YzNzZRWHIrMHFwNU8xUG1oM1ZpRHN6ckdITTRLVmxvVVRwMEZXanRw?=
 =?utf-8?B?T2diS3lldmlYQ0EvaUVlV3pKVmJkeEhKQTNtNjB1dGtpaDRwRmovTjMwTmdt?=
 =?utf-8?B?eHBNd1hBL01yVWh4WDlRcGJqU0VPa200aTFYRjFzTVh4SHFjMUljQk9GZ2Nk?=
 =?utf-8?B?NFFObExDd1VOVjNQM0d2Rkthd3dpeTV2R21qS1A0M1JMSitrN0FFc29oeGVZ?=
 =?utf-8?B?Mk9sa3R1T1h6b3JJTjdEYUhUamdvWXZ3bUQzYlZlOVBHY0JMSWhEelNOUGVJ?=
 =?utf-8?B?UXBrZHB0VTRlSWdLN2JPZldWbXJsa3htZk1INHNIME8wRXpudFhBSzhYRWlv?=
 =?utf-8?B?d3FHTGFsYVlXTlJJQVllNVhQMWcvMVVpdDVoK3V1dXkrMnlTZytsbWVSMWRz?=
 =?utf-8?B?d2NBaUwwQjNPZHhPRVlBb21UZFd3amVZZ3M0UDRYN0VxUnJVdTNRZTJkbU9T?=
 =?utf-8?B?YnVPU1VWYkdSSkUrclNIc2I4MUYvdTZZUm9uS2ppK3FKQkVMZEk2VXlMUldK?=
 =?utf-8?B?b3BNSE5tT2FUWkNKMFgzYTFCVG5XeXVRVGwxdW4rQUgrck9CbDliOXBSTm9H?=
 =?utf-8?B?L3kvNU14cTRUTVlFc0g3N0JkQjdMYzVsUkZuRU5SaW5FYUVWTjFRNnA4c1FX?=
 =?utf-8?B?d3dFcmpyeHdMai81K1JNKytyVnFkUmRqeXVWcEVKNTg3KzlhSjFTUTFTM1ll?=
 =?utf-8?B?YjByaUVMM2lnYU9KWHV1SW5nNzhvV3RNQVkzVnJmR0tOQzlXWWFDR1doRmVp?=
 =?utf-8?B?aXhIOGMyaUFYUys4S2FvTDJldEVReW5GODBiODk1ZklFaGRZQVZvU1ExbHM3?=
 =?utf-8?B?ZitPWU5tNVJOV1hLYWVjeUZ6TFZXTWRVYitKdXRjeEtyTlNHeHR3TjhHdFlL?=
 =?utf-8?B?UEE5alVtNGFxSHZLYXd1NVY2SmZSRG1odDRIZk1TT3MrenlWa3F5bnVjSzdW?=
 =?utf-8?B?ZU1MR3NmMTRlV2hQaHB2WUxVemRFVnZnbGRWVzFVeUo1M3lRQ0oxTlJsek9m?=
 =?utf-8?B?ckhWc3ladWlnSDFTL01zVHJLdE10VHZqQTVUZVpLQkk2YmVna2U2TkdYUFlS?=
 =?utf-8?B?ZUVmenEyMXkxeGFyT2Z5YzJBckpMK3BtaG9meHh6aHJDbWlEMm54cDJmTGNU?=
 =?utf-8?B?dUdBeWh4allQRGtvTkNzbG9JZ0dvYmRqT3JEZGVGd2MzTzJKc2dLaWhRWkNR?=
 =?utf-8?B?MFNuUVRaYVVGank0dGc0c2ZSY3BjdVo2bmc3TmRDaWhnQ2hoWlBuanlUOFpC?=
 =?utf-8?B?OEdlSWQ3ckk4aEZxUktCWVVmRXdnUmF4WStTRVB0c0hocWZWTXlJZjRIemMz?=
 =?utf-8?B?M2ZqRlpRdHdsZTQ0NnpsOGM3bU4wVG80WmZiK1BxUVUzU2RMMVpKWUpZWGRU?=
 =?utf-8?B?b2JiWEZKdW43V3dtV2NEVkxhOFJOMVRFMndXOHVBSTlYSkNocEdoL0ZQREZj?=
 =?utf-8?B?N044K2FpeS8xRyttNW9WT2lrSndEZVFqUG9TM1loZlIwWGUxU1RLWWY5WjF0?=
 =?utf-8?B?LzhYalFZeGg5c3p2S0N4NzZnc1p2USszMkxaa2NTV0twYnBNbEtTbHlKVEJR?=
 =?utf-8?B?NjhCT242enJtRWQ2ZndhNndDaDJhQzAxeDUyZWthcEN4bXBJMWZRSU1kM1FS?=
 =?utf-8?B?RTVZZGE4b3B3UFh1bUVoTHdOZHVmZXpkcXBlNlliSDk5QjFwcURnNzUyU3hT?=
 =?utf-8?B?RG5nQzNBTFdtY0dmSEVqM2hRV1JpLzI0bUdpRWRMK0tMdXNpMmV6V2NXUDkx?=
 =?utf-8?B?TmxqN0NQMnNENkFZTFhTUHY0a0pSam5HYU9oTDZMbkpYUm1ROWc5clZlOXhU?=
 =?utf-8?B?dkJtR0crRU9zVjdpa0VlU3kwMldmNGEzcWJXemtKeUEyelhVWm1BT1FFNjVK?=
 =?utf-8?B?eGl0VTAvcTJIMmpmRHV0eG1jNE80WlM1cmdmU3FwUGVZOENHOHNXUkxzN0NR?=
 =?utf-8?B?ajZHejJZai9sd1k5eGM1OG4veE81Q3BPdzNpTHFsaWkrUjg1TE9sVEI0aHZu?=
 =?utf-8?B?WkpzQ2w4Q2NVZVFiYUlzMXJ2ZkJIaXNwNld0bmxWVHBsV2Nkem9YOThIYjN1?=
 =?utf-8?Q?QyT+Xd/cNBUxeGtRxC05FNg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19f53c71-d1c0-42ab-11d5-08d9b89cbe3e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 09:42:39.7282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ef/uI9QsSKegkMLH4FLK/YXHapdaVFWmeKxfGpsSKx6kT3HlEL6jH+KLj1TyOOOjIm6GQ99RMxABuK1TH+SsSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4845

On 03.12.2021 16:30, Andrew Cooper wrote:
> On 03/12/2021 13:32, Jan Beulich wrote:
>> On 26.11.2021 13:34, Andrew Cooper wrote:
>>> Each IDT vector needs to land on an endbr64 instruction.  This is especially
>>> important for the #CP handler, which will escalate to #DF if the endbr64 is
>>> missing.
>> One question here: How does this work?
> 
> Honestly, I'm not sure.
> 
>>  I don't recall there being any "CET
>> shadow" along the lines of "STI shadow" and "SS shadow", yet there's
>> clearly an insn boundary here that gets "skipped" if the 2nd #CP gets
>> converted to #DF. And fetching of the first handler insn also isn't part
>> of exception delivery (and could cause other exceptions first, like #PF).
> 
> I can't make my observations of real hardware behaviour match the
> description in the spec.

I haven't been able to find a description at all of exception behavior
when the exception occurs in wait-for-endbr state. There is text saying
that #BP and #DB can occur this way, but I couldn't find anything about
the tracker state changes in such cases. While I could see the state to
remain engaged (requiring an ENDBR at the handler's entry point), I
cannot see how the state would get re-engaged upon IRET from the
exception handler, unless the return is back to CPL3.

> Given what a mess it all is, I wouldn't be surprised if the exception
> delivery microcode has a special case to escalate this to #DF.

I am meanwhile wondering whether any exception in wait-for-endbr state
at CPL < 3 would promote to #DF, for loss of state. Albeit there must
still be a distinction between CALL/JMP induced state and that
resulting from interrupt or exception delivery. Yet there's no
architectural (or shadow) state expressing "first insn of an exception
handler".

I'm not even convinced the aforementioned statements about #DB and #BP
are actually meant to cover more than just CPL3, or at best ENDBR at
normal CALL/JMP destinations.

While for Xen's own use we may get away without knowing how all of this
actually works (perhaps accepting the fact that one can't set breakpoints
at exception handler entry points, depending on whether their delivery
would promote to #DF), as soon as we were to support CET-IBT for guests
we'd definitely need to know.

Jan

> If it didn't escalate to #DF, then you'd end up with an infinite stream
> of #CP's, which will most likely cause a stack overflow because #CP
> needs to be not-IST for shadow stack reasons.
> 
> ~Andrew
> 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 10:49:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 10:49:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238786.413836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muBYi-0008NM-JN; Mon, 06 Dec 2021 10:49:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238786.413836; Mon, 06 Dec 2021 10:49:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muBYi-0008NF-GJ; Mon, 06 Dec 2021 10:49:24 +0000
Received: by outflank-mailman (input) for mailman id 238786;
 Mon, 06 Dec 2021 10:49:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muBYh-0008N9-4N
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 10:49:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2b33d7cf-5682-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 11:49:21 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-3mnH_djAPGGCFG0uQS-UVA-1; Mon, 06 Dec 2021 11:49:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 10:49:17 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 10:49:17 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0017.eurprd05.prod.outlook.com (2603:10a6:203:91::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Mon, 6 Dec 2021 10:49:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b33d7cf-5682-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638787761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ETWBE5Tgi7RxJH6hIPyvMR1Kms4ofCQDjyr6RKVTKrI=;
	b=CBLKTRIx46VV/a26bydoI9/qKycBCgk/gGl8KJ0lf6jh2C7Gn5+Spu/loUcUnpbYanxCcF
	dqnX1Hv8VryyLXP9b5f9TWRwvFmgNRc07Edh+c58vJIilHVx67uAod6xCGvgwAEi+G/3IA
	gEsR8tM+lYf3c64dWmaBa9lQHGgSUXk=
X-MC-Unique: 3mnH_djAPGGCFG0uQS-UVA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mmBMBWBJiy7PS2KeTKkIy5zGDqm9Ig/Dts85EHda4+x6uhWBTJ4paL90Cb8yxrE2Kex1mjBN9ar666BBCLAbPigZ0VmepZpB75aTCLBdzFD0ulIcGmk2D9AuJECQbCRlVqX1yjPMkKuIHRaxtQwcWAfeOT8rZp0S0Lfr6Zm3XXltRUnZ4ivLsgFrxSkBC6E1pu+OpJrHz3SitFYqHDtLVvBAgRAOEch54I1i2w/AtnNrBFm3kX1A9wK4tuIFmfyX3hcANbqqGv+vpCnr9bAOjH7gjrl7n8YgUXuIWn/m9KpqfStU2b0EYR1ziNKYkvfXk3eMwUAtc0uuQUDFdcOEsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ETWBE5Tgi7RxJH6hIPyvMR1Kms4ofCQDjyr6RKVTKrI=;
 b=EAzv1dyFhRcnC+CVCC2YNjIeSwRLb6M7HmJ5NvJ5GdpEiUqfA2d+ItmhdsNrcFx0dgDyjNEUkXAsDjr+OAzq0Ir6YgneuzQevot/s5cx7/+fpDgzLOz6PCUiTcxH6qwlhC5XexrEdHIWjTi+v+sUX1BlRa8w+SuTc6fo8b6+sP1GlFlvL5cj9C75KY9nW4CnU01RpF+2gvxrDid4RyNEX+30aRsOuLa5k9dOfR5Xrk1hVJXwRvnpoS37cabTNSYJc1X1aHlUICWfAcWQFfpeXSAO8+2tetd7JDMC8VDLg2gGhRmtl5SVZXEtEEpU86l1XplfA1BLR4w9h6fMQ2S+ng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <64b55cdc-484d-5657-e0af-3462ebadd09f@suse.com>
Date: Mon, 6 Dec 2021 11:49:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 63/65] x86/setup: Rework MSR_S_CET handling for CET-IBT
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-64-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-64-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0017.eurprd05.prod.outlook.com
 (2603:10a6:203:91::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 70c42c52-aca8-44b0-98db-08d9b8a60d1e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB377492345CA3BA00EC96C9ABB36D9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CwmXh32o3I8rVYU5e25A+hPlzdV8TGSW0Z+4BkYfSliuCSh10GpDlF9D5H35Ny9XgSYTBKfOcGvbggt+sB12jiICMvo0mEC9Jvgb8fcOSdpJ7je53xx3yAV27tyQpvJfTV5yAptU2Vb+EHMvYa9tlf/SW8Ld4XXUgTR+3lquIGc2I2+3//CH/qUqv0oKzIgxBLwoZXsn0Rg+RQqLGk3Xbw8qravuw/vwcgKBSF8wpSsGSYyvxwh1Bf+4391d4PXh3UVLFhQlQwA/OOtnboi+FqMQgcMlP36XYxC4SxKhqit5f1Jk/ka88Ww/KYt0Bggg52LkhnkzmDh8wXlhSuZbMT+U3+FbHnNIHpEEv1TSVGwiLCkTZEd0sJShIw8Z6PzG/fmaQ+1CBHjoPnIp8M6ftAtH2xIuwRNJG4f/P/Pj+OU36YgUAiUAtZcVUDw7YOV4TzdFSWY9vKmZPfuHXhJUBYgZQFQthl6TlOvsnJkFkTfNFusQhBW+I+UA0YdbkDsatE5dXBm0dSoDPrEsWGgnzbaV3WYJD7cty1TfmL05uX9TiJCY7MaI0Pej6z9Ndrmkyr16Uigeam7GeWBLIV2YWUkyWYCpZ/26DqYCNYeQ3UHq5Xe7L7zXiiXtdfeqNsu2ttkLFn4gAP47gh+AxZl1PM/yodS/aBe8oF/NX73FR8dr6mn1c74X2JuNsIgCEnK+EcDRPtI2SuZM8kZndAdFhp9PZX72qatSJbMkLN/X//I=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(66556008)(66946007)(66476007)(26005)(8936002)(31686004)(508600001)(31696002)(53546011)(6486002)(8676002)(6916009)(956004)(5660300002)(186003)(54906003)(83380400001)(2906002)(36756003)(38100700002)(316002)(16576012)(2616005)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T015SkY0RjlPWEVQaUM1U1htSnQrTDk0anQ0VWZyOFVoV3g3VXZUREN1VDRX?=
 =?utf-8?B?T2xoNHRuYjlGcWt3M1E5T2dOQVZ6aEgrMXEyTElzWjVCMytZd0ZqNzkza25G?=
 =?utf-8?B?anFvQTlzRGpWNUViK3FQcVFIb1BET3loamVuNkxURFpNTk9iQVBUQyt2NjMz?=
 =?utf-8?B?SzQrMHFTZ0hkZS9nbTdOeXVXVWtuWDZJK0VPUkhHWDJqV0hkUEF3cUM2dnNY?=
 =?utf-8?B?L2xtbXJHOVZoTjlYWG5oYXV4WnJPMWhMdWQ3R1RrNEtTTVV4ZlRtWFJOc0NX?=
 =?utf-8?B?aGV6UDNQekhYRFpDK2haNThsdTJXdFpzOWhQd2hCMlNoOG5nTis5VnJNbEIv?=
 =?utf-8?B?andFT0VHci85ckNYeWNQaXNHT01STjJBeUtsL0xOa29CeVB1YTR1MkloajZm?=
 =?utf-8?B?aWhpbDNtV0JobFE2TEI1MnI2UXVhSFIzcFl3YnhZMXRKa2pUd21NNHhMOXlF?=
 =?utf-8?B?NHhyV0wxeCtvaWsyRlhkVzJMQ2NtV2tKamprS3RMaUhrOTVrTXVPWXVMQ0Q4?=
 =?utf-8?B?OGRLL3J2QmxlTnRoZm9zNk8yVy9iQ0JjK2ZQejhpUzFHZUh5UTNmdnptc292?=
 =?utf-8?B?OHRUdlk3ZTlOSElDbVM3bUsxVVJkaC9YaHBadFJNcmo2aVNwRFhxS3BoRFV1?=
 =?utf-8?B?Zjhkck50KzBGSGlJWlNYWE9PZXdabitiM1BPSi9LVElMaUdSSDNZc3RHQlVO?=
 =?utf-8?B?cGxXdWllOWR1Mk5wemk5TE9FRG9BVEEyVTBwOS9qeFZUSWNFSVgrK0RUZkc3?=
 =?utf-8?B?alovZ1VuVjhPZENTWWh4cFFMRzY3b3R3clAzOFg0RVlKd2xmTmF4MVRFeitP?=
 =?utf-8?B?dEttakQ5a1RKN1N5YlZMRjBqQTlnblR6bUJoTjdSYStOTDN1d2I0NzR5WUM2?=
 =?utf-8?B?RnQvcHlYYXRHazZwQmlQUXdoUWhHU3BoQWd0VjBuMktmTThSTk0yUU5MM1Er?=
 =?utf-8?B?TDZwWWEySFZZL20yVFgzK29CQXVaTWNTaXRlSktSZCsreXZISzJUQ21JRnRN?=
 =?utf-8?B?ME5tbytqbTUvSmZPS1ozN2o1RVdxT3FPWkwvT1laTG5hVTlRZmwxUjhjTjdw?=
 =?utf-8?B?aUJ6L1E1Z1U3RHRaMVVyMXNrYXNQdXFiYzI5UmVUMU0wckhnMktvazZrYjFv?=
 =?utf-8?B?aWx0SkVGakJFRFdZNUVUcFlLNjlzR0ZrR2hlbXFnTEVPTWlhZ24yaGNTYTlC?=
 =?utf-8?B?YVVIUXdIT1d6T0l1MFp0QWVrWjhINDhWQlNRRHdxdFRLaVJ5RkxOQ2ZnOStP?=
 =?utf-8?B?Kzc0UzhRaGdHdy91ZWg2UEF1TnJ6OFJNL0puL3RacFMvOTVHVTJ1NXkxaVJt?=
 =?utf-8?B?NHZCeGQ0bU41czVLYndScWZmQmw2N1JWcEZTY2pWeGdxbkcvNU5ESVhQdVdE?=
 =?utf-8?B?UG5GbzZqN3pOYmtNbVUwTnJjUGJxVVhTenlBNWd2OElkdStEUlc2RmtOeGdl?=
 =?utf-8?B?Qis3dkRmd2JTYjRXZlJqUVB1a2xUNlFqU2xKcDM4RFFQdnEyT2FUWmxKamFv?=
 =?utf-8?B?UDVKOTNoTGJuRkhlR0VBbjUzRTJQQUJxZXdkbVFSNkcyOVNwZlk4cUVvUURm?=
 =?utf-8?B?WVNlYWhibmpLVllrK1ZoblZuMEFnTXZEK25wYlp6eU5LdFZJb21WZ3FsNWhP?=
 =?utf-8?B?eUFDS0VyTE44RW5SYTBaU0cxcFJxUmZzRm1uVXJKS1hJZDVRL3ZuRHNmYms1?=
 =?utf-8?B?TDZ2aHl1eUsySjhVUlVGL0pjTTlIdXY5aWR4SE5LckxQT0FPTVB2NFdWVHgv?=
 =?utf-8?B?SFFXa1VKQXRXRXZhQ2IyYjUzdzVjZEs0eVp0b2tyOEY2YUxWZytWdHFINXdN?=
 =?utf-8?B?Z1lHMTVLZjRhbmRhTnI3ajVTMmltWTlZSzFtUHE4a2pySGxSK2FoTWRKS2Rx?=
 =?utf-8?B?aFVmVlNEWUljb2ZGcnRXdWNkbUhmVlRhcUtrTVFDditLSWcxa2xSdnJvakEx?=
 =?utf-8?B?SURlQ1lGZllxTDZYNUdJWDI1TnpjUzFNSEwrNHVqbUZneUJaQ04zeGo5TW0z?=
 =?utf-8?B?OHRCNmZSaXhnZU11TExrbXhpM2h4YXJhaXVlTG1rWVg4WEdCSVhRMlptWEJj?=
 =?utf-8?B?dU1PbjVMYjM0Y3FMK2daRENyM0NEaVdnS3lMeW9OdWs4TDRNbDB2V2J6b25z?=
 =?utf-8?B?TEpJTUJZTGE1eDEzbDU4VWZqSTVTWE05Q2NoeEg5c3VRTkVCWHRpeVNOeks3?=
 =?utf-8?Q?xceSNIOxPODOVUr7sbWKa+s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 70c42c52-aca8-44b0-98db-08d9b8a60d1e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 10:49:17.5166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UY+g6KO9azwnBUsz4TePEDDld6klyXU0iMi6atqRjV+iR7AH+LZ3e5sphkr2JxgAHOOWdh0G+ye6iqGWESH1Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

On 26.11.2021 13:34, Andrew Cooper wrote:
> --- a/xen/arch/x86/acpi/wakeup_prot.S
> +++ b/xen/arch/x86/acpi/wakeup_prot.S
> @@ -63,7 +63,24 @@ ENTRY(s3_resume)
>          pushq   %rax
>          lretq
>  1:
> -#ifdef CONFIG_XEN_SHSTK
> +#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
> +        call    xen_msr_s_cet_value
> +        test    %eax, %eax
> +        je      .L_cet_done

Nit: I consider it generally misleading to use JE / JNE (and a few
other Jcc) with other than CMP-like insns. Only those handle actual
"relations", whereas e.g. TEST only produces particular flag states,
so would more consistently be followed by JZ / JNZ in cases like
this one. But since this is very much a matter of taste, I'm not
going to insist on a change here.

> +        /* Set up MSR_S_CET. */
> +        mov     $MSR_S_CET, %ecx
> +        xor     %edx, %edx
> +        wrmsr
> +
> +        /* Enable CR4.CET. */
> +        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
> +        mov     %rcx, %cr4

Is it valid / safe to enable CR4.CET (with CET_SHSTK_EN already
active) before ...

> +#if defined(CONFIG_XEN_SHSTK)
> +        test    $CET_SHSTK_EN, %eax

(Intermediate remark: Using %al would seem to suffice and be a
shorter encoding.)

> +        je      .L_cet_done
> +
>          /*
>           * Restoring SSP is a little complicated, because we are intercepting
>           * an in-use shadow stack.  Write a temporary token under the stack,
> @@ -71,14 +88,6 @@ ENTRY(s3_resume)
>           * reset MSR_PL0_SSP to its usual value and pop the temporary token.
>           */
>          mov     saved_ssp(%rip), %rdi
> -        cmpq    $1, %rdi
> -        je      .L_shstk_done
> -
> -        /* Set up MSR_S_CET. */
> -        mov     $MSR_S_CET, %ecx
> -        xor     %edx, %edx
> -        mov     $CET_SHSTK_EN | CET_WRSS_EN, %eax
> -        wrmsr
>  
>          /* Construct the temporary supervisor token under SSP. */
>          sub     $8, %rdi
> @@ -90,12 +99,9 @@ ENTRY(s3_resume)
>          mov     %edi, %eax
>          wrmsr
>  
> -        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in load_system_tables(). */
> -        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
> -        mov     %rbx, %cr4

... the writing of MSR_PL0_SSP in context here? ISTR some ordering
issues back at the time when you introduced CET-SS, so I thought I'd
better ask to be sure.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 11:07:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 11:07:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238793.413846 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muBps-0002bB-29; Mon, 06 Dec 2021 11:07:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238793.413846; Mon, 06 Dec 2021 11:07:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muBpr-0002b4-VO; Mon, 06 Dec 2021 11:07:07 +0000
Received: by outflank-mailman (input) for mailman id 238793;
 Mon, 06 Dec 2021 11:07:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muBpr-0002aw-0C
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 11:07:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a58a00b8-5684-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 12:07:05 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-IM1ohmDZP5C4gf4y4Ijf2g-2; Mon, 06 Dec 2021 12:07:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5904.eurprd04.prod.outlook.com (2603:10a6:803:e6::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Mon, 6 Dec
 2021 11:07:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 11:07:02 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0069.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::46) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 11:07:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a58a00b8-5684-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638788825;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=elz+xgbj7jJUe9dM4ZRSPj7epxPvJ1nvaPRQGhIGOSU=;
	b=OtLWJaK7bShSsoRlE93u+iJKNoiT4OF8IEFihTONp16KBCGi5AZrgpuBQKFbAFVxP57w3t
	LgRWbOFdDu4Si2gHDhWnDRIVKYif+1Q3bV1nOhJ6Bc4oKvaeQZzwND75X8+1mVbIG+TdAr
	LHCYANpfX24rjHEbI8NVQDL4K4PC5ZQ=
X-MC-Unique: IM1ohmDZP5C4gf4y4Ijf2g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LiSO7baha5GGNJ1GZFr1DSqfRUjzUP8+7zc1/SwCVKd6ILUVuydUQBSoQnCQ98rZ9JAp4ZkgT9Hm2ALIIiGGew8CV9+jLeGYkMH9//cS92Lw8c0GX5Ca1cwoa4XiZ7eD7RnfiI+D4SQOkk1H3G1B8EHYZBOM53ey1Q4bai0sMCxYJiPJpt8fI11mVkZyDWoIUFQll5frwBWFGMA5o70XsW1lV+cIuiURk2KE0CnBedH/mfzhE7+9J9Xex5uCzWadZnWLNac8wtDsvGdL+VUIEiifPS7XwpGDxQLIi9sRUNwm1Lhiy+h0zySRf6+zjIRrDK2CfQFxtCRhGtqdqzbxXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=elz+xgbj7jJUe9dM4ZRSPj7epxPvJ1nvaPRQGhIGOSU=;
 b=EJqjBOS8JguYAtSqy5TwwsBFU2kDKBC+DJYyUIrx9By/RlUm7gVpcChQrenCdNGBbDXwN5/hYOBuezLxwHic1z+kxMKanlegqM4UhIIMDPVFHZTSLIV6dCcQB9K1zSL2Vvdpi1e3y3QXqxpi7v/T7yNIHsvDHfxSFWCLK6bd3DcVUCoGECgROlXCkL3G1TW7nLOB63yC3EgNJNIhVAzOjLUbRxFUZCxLGx40KoweBEZ3ROegoTPAZEXz2lEAGPId53RXj7ovwmjwdI98OGmBulDzMrC4Fva02uDQLoHSSH0dBx21mEj/lxz3xJ97r3MPqM0KZdwL863jT7JkCD2SPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f3a94e22-5136-8cb8-6df5-58899a8bc4a7@suse.com>
Date: Mon, 6 Dec 2021 12:06:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v1.1 64/65] x86/efi: Disable CET-IBT around Runtime
 Services calls
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163830.30151-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126163830.30151-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0069.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e218d5bd-767c-4817-d325-08d9b8a88759
X-MS-TrafficTypeDiagnostic: VI1PR04MB5904:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59047FF2BEA2CA0D9ED3759EB36D9@VI1PR04MB5904.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	80qAvamlf2D32MHk7j8mv7BFK3IUU7MKVlyEHy1lmURB/Y0GA88j0pLhXRca4740ZGfpr//GAlfV/1L7MYq+1OGLPrFb9sRBAW74ELsqNBMmQAiB6QtyxyV2Jpy2BPFEb5HF6kI4Y3EFvA8B77gBt+mqRfAXa6jMfVIZLC6Gc/RcfRDrqtsmphPtG4w/5HpPBlVKQHe6NNcguGgtuB3fG7W0yAvvKzaZBUsYAVjNIFU1TQjFtwxqKcOzFBABzlS6Qs4FwV+Hd81uNFaDsSyDLkoeb35Mbhhc0xhT9W+1D5ewIbHUI5B8wrl9i9Q259F3SShRiXNFtN+n8vJ6mSZyL62LggqcTcMG6eqAp416V9Tn+stcYBilqKaHnf2BUDkcVi4o2ED/8BE2jLQqSsbe/5vjR2cwrwrp0vGb1R82ftM+6RwYYrYRlNg/FAdjdA0OG2yDhj1/D5ffXhLJtXLeKnzdmg8EYMmIrBAPIyv/GVrnmM4bKew3gGuo1Oea0b2TiXQen7jw46CTVCFG0RiBqsueHPbRLfJ/siFTwF69y7UFOCVv2bs+gUkJSzoPEPgifPyrDYsgpIbHev+aisTiCXxVcl72y6F97zvYJS83PeFklHRCYFeTypgliTbGCN0QxS9rOO82h3ziddl95+zYm2xMAcfYJQg3hymeoi+SAxfxQJEbbWKt69Dq3LaQuS0Exm/4GkhoqksPoLxvqworvIgPbzNbVMHtVgtD+FiRL3c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(6916009)(956004)(316002)(16576012)(4326008)(508600001)(86362001)(6486002)(54906003)(5660300002)(38100700002)(2616005)(36756003)(53546011)(66476007)(66946007)(66556008)(8936002)(31686004)(8676002)(26005)(2906002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUJiYUdFVWp1N3RLQW9rem8ySXZyUTc0cmRwUGtoMDluVy9nYjZmUWx6MEFx?=
 =?utf-8?B?Sk5zZGRzUzBabmRUZ2U4VU9BNGhxQkRoY1lDWnMzcjV4eW8zQVNoZHRvZjZh?=
 =?utf-8?B?VGhmcm8xQmdTRnl6QW9VRytjMkNoN2VMNysyM2NJK1REVUw1ek5BNjNiditG?=
 =?utf-8?B?N094MVIwRFVFTm41dG1ML0ZTd3RJMEIxVENmOVg1UGFNY0Zla3FOc2VwcXlU?=
 =?utf-8?B?dkZQL01ibzJ4WUMyaWg5MGFvN1B3RmludnNBKzM2MDM3c0NWdnM2YUhPd1Iw?=
 =?utf-8?B?K0hJRGFNTDVKbms5L3VmL0M4emFjYjFaUktIRG4zQzBRZlBtaVhrTGoybGFj?=
 =?utf-8?B?QzZ1QjVjRHFleWh2SHhEY3ZlUFBQODNXY0xSNE9mY1N6blhuQUduVXUxa21K?=
 =?utf-8?B?bU1UOFA5QzdJeUJPZGw3R3gzSE5hNlVKTVNVazFub2lMNmVvUVFQL1g0d3Yv?=
 =?utf-8?B?VjJQU2RzQ2RvczA0cDdTNTljYXZJcDlVWDUya1o5MmxjeUsrSjJRQ2lYOWxm?=
 =?utf-8?B?SGRqUi9Eb0J5a2dyai9WbGxoWkYwSVduK2ZqOHVBZko4RndNaDBQK2dZUkY1?=
 =?utf-8?B?NjJocVJZMG0yV2RhSmY3MXVqK05vM3Rha3krNGliS2trM0xMdCsxcjc0clBS?=
 =?utf-8?B?Z2pvRlhvWStNQWlOMWZXQUZkTk9BWnBkb3QwRURLVjZaSVYrSGJMT3QyZzNI?=
 =?utf-8?B?Tk5oVUlka2pmc2NSQ3FaU2FFdXcrUUtXdlhNMU0vL3F5ejV4U0hMc1FBbHBJ?=
 =?utf-8?B?cys4emd1THhwWnFrY2VIZUt1S082RktXZkp6Z1RpNE1sL3JnM1d6bVJJcW5N?=
 =?utf-8?B?V3FLU29IMTlYOWdnRlFOWWpVRjhjVmlWNkF1YVFoTmhlZ0J0Nm0rcFRzb0Yv?=
 =?utf-8?B?V3EzVXJTb2dBcnVTSjFOWUE2TG9DdndrSmErbzl5WFV2cGVCd3d3NkVzN1Z1?=
 =?utf-8?B?S25XazdLSDJDKzR5MU5aOU1DYTB4V2ZxOU9LN3dvYWl1QmlzbWlPN2NCUFpv?=
 =?utf-8?B?UnBjL1dzYkhJWmVlckU1RlBDckp3RWxGeFAxRElKNGpocE12WmxObVNuYmVT?=
 =?utf-8?B?VnpaRlZZL2t6MjhISGhhYjhDRVgzT1E4Q2F4cm1aOFJXU0xGanNDQllLL28v?=
 =?utf-8?B?YVd0SXhTamU3dHBiZFZCOUpZM1p6ZjhndHJNNm5jdDA1YkFKTit3MzJEdkJl?=
 =?utf-8?B?RWhtT3BlWU5NMnAvdW45ZFRLbWJrUjFPRWpXakhpOTdYeFN0a1RZRk1zWjJh?=
 =?utf-8?B?ZzhLUkpKQmMxMnFuT0pHeHNuRllHT2ZXa0Zod2lvTjlHN0lzUWVmc1Bla0ti?=
 =?utf-8?B?Vjl4dW0rVE1Rb2NINUVPSEZ3NFlhU0k1VTNjN2JnTmpuYTNPWGUxRGxRODJM?=
 =?utf-8?B?SEVNUytSYmJYUTI1WVltZ2lBeHhwbG11b2ZpcUkyU3BhZW1kU0FCWTE4R1RV?=
 =?utf-8?B?MmhwcWpPdlFnajZjUG1rU2JYcTYza1A2TzBBeE1TZlhFak5JQ3I0TkZlTHps?=
 =?utf-8?B?VlNHWUhSQnlaMTN3V3loQjIwcjRpMGpvcXdFZHh2WGRPQXdKRW55NUpKWG5W?=
 =?utf-8?B?SmxHY0ZmaUJFU2FaQkR0V3QwMGtpMllFYTAyT1UvbDZvRWlublEvSE5uRVNB?=
 =?utf-8?B?bHpzVTZKcGZER2QwbVpCU2VTTU56b0NVV1l6NGhodXdQbTF5QXJ6V0VGOTVa?=
 =?utf-8?B?cmNpeDJMZFZiS1BOam1PZjFiV0U2U0crTHdWeG00NHJDZkEzcVFMWjhtR1Ro?=
 =?utf-8?B?dHo2T1BRMU5LU2J0cmFNQkIwYTF1UmhBN2pCZm5vdUlDSFpHOWlXQXpiQ3Fo?=
 =?utf-8?B?cmRWaUFEWFZrelg3TWtyaktBTGM3N09DN3UvMmJXTnRDV0kwK0x4eTNmNHVW?=
 =?utf-8?B?WFh3eC9WcXRTZ3JpakNTMTltRmp5ZVZ5aG9tTlRrcHlxbWtlOHJQOWtMc3li?=
 =?utf-8?B?dFhmNnkveFhXMlNZRlgwUEwxMlZLMVJOKzNkeEtoNzZSTHEyZzR3RVhDb0N3?=
 =?utf-8?B?S1NwQUN0V3huc0dsU0tYaXZiUm14eG1jOVFpMm1TcjJ2ZEg3YTFuaWhWbzZ1?=
 =?utf-8?B?alA4Q1JVbVBxVlFJSVBlYXdySTVSQ0ZlS05xUmpmcnJjdnVmUFZ3YXVkMFVJ?=
 =?utf-8?B?WU53ZjQyUHJpWUptYnRwU3BYQW5LMGQrV09qb3B6RlY5NEw3QnJ5UWY3L0NE?=
 =?utf-8?Q?t9rz6Spmwj8DOb+6h3AUwU0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e218d5bd-767c-4817-d325-08d9b8a88759
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 11:07:02.0489
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: huUg6tLfVygyA5TM4vUpW2z93SKz5xvfDguOq7NNUh1LevfJXEiz8h39pUcomHdxlefyxCtd8VyymhgE9n1opQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904

On 26.11.2021 17:38, Andrew Cooper wrote:
> --- a/xen/arch/x86/efi/stub.c
> +++ b/xen/arch/x86/efi/stub.c
> @@ -11,6 +11,8 @@
>  #include <efi/efidevp.h>
>  #include <efi/efiapi.h>
>  
> +bool __initdata efi_no_cet_ibt;

I'm having trouble seeing what this is needed for - when this file gets
built, neither boot.c nor runtime.c will get compiled, and hence there
should not be any reference to the symbol that needs satisfying.

> @@ -735,6 +736,14 @@ static void __init efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTabl
>  
>      StdOut = SystemTable->ConOut;
>      StdErr = SystemTable->StdErr ?: StdOut;
> +
> +#ifdef CONFIG_X86

CONFIG_XEN_IBT?

> +    /*
> +     * Heuristic.  Look under an arbitrary function pointer to see if UEFI was
> +     * compiled with CET-IBT support.  Experimentally some are not.
> +     */
> +    efi_no_cet_ibt = !is_endbr64(efi_rs->GetTime);

I'm afraid I consider this insufficient. Even if the core EFI was built
with IBT support, some driver may not have been. Hence I think there
needs to be a command line control to force turning off IBT. The only
question is whether we want to also honor its positive form - that
would, afaict, be a recipe for a guaranteed crash if used wrongly (and
it would be meaningless when used on IBT-aware firmware).

Not only in context of such a command line option I'm also inclined to
suggest to invert the polarity of the variable, naming it "efi_cet_ibt"
(and the command line sub-option "no-ibt" or "no-cet-ibt").

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 11:23:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 11:23:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238801.413857 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC5E-00056O-F9; Mon, 06 Dec 2021 11:23:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238801.413857; Mon, 06 Dec 2021 11:23:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC5E-00056H-By; Mon, 06 Dec 2021 11:23:00 +0000
Received: by outflank-mailman (input) for mailman id 238801;
 Mon, 06 Dec 2021 11:22:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muC5D-000567-BG; Mon, 06 Dec 2021 11:22:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muC5D-0003oE-0d; Mon, 06 Dec 2021 11:22:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muC5C-0001Uv-MN; Mon, 06 Dec 2021 11:22:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muC5C-0006P0-Ls; Mon, 06 Dec 2021 11:22:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=73dPMWEfK5F0oZtWxslsv7Qh0JzGAssiL5ZjFjzO3EU=; b=q2NXXJlyk7jsvnt5gdWW+MD7aW
	/jEN1lnKMv+6Nh95Ygt4JWRgMWUeLMnExuD5Y0m9lY5OhreTdhu/phFoxxpx6BwgbOR11QVNnY58K
	Q8ZP5YFeDE3HxM0uL7ZWR8wWAkFNR35FCtTdKpmvJyUYjzvEn+XDGWyZfOO7W+HOPIRI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167174-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167174: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 11:22:58 +0000

flight 167174 xen-unstable real [real]
flight 167208 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167174/
http://logs.test-lab.xenproject.org/osstest/logs/167208/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167119

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167208-retest
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167208-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail like 167083
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail like 167083
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167119
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167119
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167119
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167119
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167119
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167119
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167119
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167119
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167119
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167119
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167119
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167119
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   167119  2021-12-04 23:14:29 Z    1 days
Testing same since   167174  2021-12-06 00:02:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tim Deegan <tim@xen.org>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 602 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 11:24:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 11:24:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238808.413872 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC6l-0005hI-Tw; Mon, 06 Dec 2021 11:24:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238808.413872; Mon, 06 Dec 2021 11:24:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC6l-0005hB-PM; Mon, 06 Dec 2021 11:24:35 +0000
Received: by outflank-mailman (input) for mailman id 238808;
 Mon, 06 Dec 2021 11:24:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muC6k-0005h1-HA
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 11:24:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1610f5a9-5687-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 12:24:33 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-UTOJ8Yr7PUO8XxEJsu4T0Q-1; Mon, 06 Dec 2021 12:24:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3933.eurprd04.prod.outlook.com (2603:10a6:803:24::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Mon, 6 Dec
 2021 11:24:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 11:24:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0103.eurprd06.prod.outlook.com (2603:10a6:20b:465::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Mon, 6 Dec 2021 11:24:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1610f5a9-5687-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638789873;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ljyOQVJzhmY3HQCtr60ZGufz8NUz80QQWkVKU7vzOFM=;
	b=Zf6ncNf0QhfA6eqlK7FrBKeUt6hEUjRah+NYm/xq3I+xTjg00wpxgxY0hXOaUkhCMDxF3s
	Ul40ddYl9qEh+JQx1+X0lZnv50LccYHro/ODuk9lyWdlg3TUhAHRGaEhf805KLyVu3sNPM
	GsilLvEoRLL6sPBBI6z8Orz2e30LI6A=
X-MC-Unique: UTOJ8Yr7PUO8XxEJsu4T0Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hp4aODkgUHW3geLbfQ/UCv/7TjrhqaGsSfAjJRarj8uOmzc0LJceBl/Ea5kjHTx0a/F/1ftyshtm+27y/lWYdjGwOGttWk6kZzJ0O4JmATtgyIuL6tE/uP2nSCrMb5ZU0gaPS01M+5UqEFIqextoqLQTiRb8Q4jK3ohqDOsDnG4fk5TdtWix5RX3vCb7+Mhi7S8Ba3RtLJRo/FIT3Ear8iz89kq4sPBudUNxXRCwRzPbE7VKmssQcfLyl2r8cpclOUZvg8klrOq22W9aHHULJoHmc38/UoCuZHyx+yRPvKfepUgpVEiPW+0a1jqOc3hDShXivGZsq0KpPkERv31bkg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ljyOQVJzhmY3HQCtr60ZGufz8NUz80QQWkVKU7vzOFM=;
 b=ABV88f1hofmot+T6wvet85QG47U4OgEiwNDDBVQNmAAHJnV8mFhnXa23NOAWWn3zuUYbJ5oh9fNua/LNUxUjaG+WxnEgjYvS1S7E1nSdph9AC8QfCRJM+Y1nGfw510AKnjOXpzQuIB1+xGIc1gdAlsazx6CsMNWE7053Gas5eVkDoJdbdNA/5BaJA7eQmDmz9YnfHD7h/ReWA9qGHI62NtzWEo39qP/cyaZ92ukIAU+lsUBn8CBJBmw8w4kGu9P8/seLoOE8YMNl/wKldU4hf42ytG9z9ChipiEYf9ET300iZezuBQSSSwb/xXsj7JzO4LQ8QdC/d4QUWzsmSCgN5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1c9d73bf-c3f1-3bf7-de56-a41c298cd50d@suse.com>
Date: Mon, 6 Dec 2021 12:24:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 65/65] x86: Enable CET Indirect Branch Tracking
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-66-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211126123446.32324-66-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0103.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf2d37a2-984e-4ea3-b46a-08d9b8aaf88c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3933:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3933A5842CC959EA560BE026B36D9@VI1PR0402MB3933.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	F2Lu2f93AIHavtWVSEKBKo+e2ipBvOfBRe+UKYN5a+3Lj2R5x/BEx+k6u9N/5ZRqIX6nKHF1P46ydl7D+xppXKSqoInSHsJqDfmyFYmaDjknYh7/6yqnkgJOKoJjZ4JMB05hPXB2H+rPcLWPLgglk8XM+h7yHacwmWtB5lbhmdFFrE875ubHym17iMGOfC9Idno2cjF/Le0i68rxX/up7vvdz2zQ/Rokne5aNgIRnKcHnZBNQWdhFVRBgwMBYxNbioXKMwDiRX3MCEnqLjBSJ7oX8iRlFrK/8mMIePvfTW1kPAdMSXCO0UKdnVBgJZKNoJHL4NVgT4SsDCtp/6v70s4ypTDe3ap/UDvQmNP1c81LLnuHSwf53qKm2npBRe6hc8X8TqxCKsWNOCIST/ZuFZjMq67Y6EnTnQFN6t4ECFhXd6TkFS+A0qiwSjrme1Qkd4tkOviqcVG8ZRGt3buTe98WVLzt43Vz1EDBg/D7Mny74zdm2fr8ACOnVM4BuBodQxFQnk7MTFn32NQtg/CZ5a+MtqWFnzSixUPWV0gIu3mD6ihl7daDezBnQ6NqgcYbtRAma/Jjl347/3BKbAwFe3yrscmyVZLkc8vXGm0taducmJEON/c13h3Lzd/FcKp8T7dTGmKa3aQoJfkK5OVNfjIkyuE7sZCex15PwF9kl/7UkH7Pk20iju6rSa/vgM243m6ElzS+QJ2uvD13Xp+ZWF5bzi0PeXpHPFzYyNK9VCE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66946007)(36756003)(66556008)(26005)(316002)(16576012)(2906002)(186003)(31686004)(38100700002)(54906003)(53546011)(6486002)(6916009)(4326008)(31696002)(5660300002)(508600001)(86362001)(956004)(2616005)(83380400001)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?czJhTlJQbmhCQlBqQUE2eWdHY3h0QUtSc2VKbm9hYlR5cjNOL256aUsxSDhx?=
 =?utf-8?B?dkpTc2srT0RzZ3V5TGlhSmVtdy9sRTF6RFRCU0E3TFZiMnNGRy9relZEQjVN?=
 =?utf-8?B?Z1hmaVJjS2o4NGZ1V1pZazR3dkNnMVF6b2xEaWFVUzNRdUU5MXcwWmIyd1c4?=
 =?utf-8?B?azAvQzRJK0ZKTG5Dc3lLd3hKMWYvbEV3TnlsdFY4c09JcGVZUnAvZjJMNStj?=
 =?utf-8?B?aFRLWHNMZDhzb3loU2ZzaTRxcDc1THdsNXp5WkdydmFQOUE5a0JJVWEvaU13?=
 =?utf-8?B?Tng0c0lzTWJickZhMXd1Ykt3Q2NVODlqdCtWRTRmU1MxQTF1MUtXbThVWTBj?=
 =?utf-8?B?Q3duU3R3WmxrN2Y0WHVmYU8yT3huYXF5LzN0RFVCdzR3N09tOWVqdGhLNVlZ?=
 =?utf-8?B?andGaVV1a0xySXZNdFRzOWpNMzZtejlveU9yUDN5YjUrUVd3TWdOQ0QyMVV6?=
 =?utf-8?B?S2t6SE95MWFlN3VKNDU1WFlld3RLQzd4Nndoa0RwUmtjNnBKVnYyUGxnWUFu?=
 =?utf-8?B?Z3ZNLytRTlBRYVhmVjUwN1dWb2dreDFUcWx3eGUyb1IySTNSNEpvYndwOThC?=
 =?utf-8?B?Mmw2ZHN3RnhtSW1LWXdFU2VSTytPTktHRkEvWFZGVCtVN1BLdUt4TDBENTNv?=
 =?utf-8?B?QWMvSVlkMU9uM2ovOTJQMUpUbFJBQkZKSlBxME15NTNJK2h1VzhvTWIxQTZr?=
 =?utf-8?B?SzNhMGdObnJRYVBnU0VnRnZLTW5hVFFhMXFTMHRVSjJqTlN6c0I4WE8xM1Rp?=
 =?utf-8?B?TnVpek9GTWg3TnVGNm1XeEo4bHUrZmFScHpkako5NU95a3dIM2JVY2ZvWm5K?=
 =?utf-8?B?b1JpVWdjVVJOTDRNMUl0cHlkTlprdTJFdlBreW9ZUjFWdUczZUZ3ekIyTGxj?=
 =?utf-8?B?THducGx2dUhlQkw5d0dGSlB0MlJ6Z0hqNXVHMlQ4Q0wvWHZkazA4MStnSkZv?=
 =?utf-8?B?WTFBWXJUcjhJb0w3dDU0U0xBNVBMUU1wNjhDdGZwT1luRVNaM1kzeHFubW12?=
 =?utf-8?B?cmZxRnFMNzE0a1JzRndPYno5RVZ0UEtlbEt3Kzd1bnVGeU5Qdmo5a1hUSjkr?=
 =?utf-8?B?UFoyQkVON0hMSkszSGZDNVBDeldpK3c3SjZnYURzT1padDh2VXVlV3JSOUxD?=
 =?utf-8?B?SE1EMnVDRWp2TWt2NWNhQWgzdVZyVDNyT1VtZ1RmeHJmbllxcHY5aHBlVGs4?=
 =?utf-8?B?KzAvLytQb2NaaWQ4b3djMHMySHpISzJpSkY5c2pBVkJpakRhamF1Vm1SZFVS?=
 =?utf-8?B?bEcrK1lYYVpaV1QvY1NmS1BFTlEvQ2M1ejZjS09ramxzUDRRL3RJc3RnejEv?=
 =?utf-8?B?cHBZMnRFVS9aQWIraWhmY2x5R0hwWmJZTWJQRmw3am9LbVFsRHRXaEhzWUdM?=
 =?utf-8?B?M2h1Y0c5TGY4TEl3N2N1clNEdnduZ3gybHRlZTlCZWNRdGcwM3pCd0pzU3hQ?=
 =?utf-8?B?UTBGK3N6TXY3ZTM4WTA0ZndJbysxaVBMcjFINW04SWRBUnFWZG9ZMVNTd3RI?=
 =?utf-8?B?elprTFFuZnlZTCtWb0MvU0lQWktKRUlWOXh0YkZDRDdHR3RLcjN4c2ZBejRx?=
 =?utf-8?B?by9USTd1a0dMa1kreFAwbXRlbHgwcXZIZzMya2lVMnFzM0VWeW9jU2h0WFd0?=
 =?utf-8?B?Y0lLbGVoZmdGNks1cVZiUzBVMXlYZ21wN3Q4WGxueFZrS3R2QkZGSk5sR3VR?=
 =?utf-8?B?dkU4T1VKUkkvMUJVUmpCYXdVM3BCN0pGU3NxOVFHTUV3RCttRlFQcVV4aHFx?=
 =?utf-8?B?NDlSZ0E3MXVQRTExRVRIZUZyNk1zbHl0MFV0VlN1TWNRZ3Y5V2tqckJ5dmVm?=
 =?utf-8?B?enFOQzlKZThubnFPQzZuTnVDS1JhdnV5RjBIVm9OL3lzY1ljSTdLSEZ4aG94?=
 =?utf-8?B?WjRpNXA2S0ZyTlk0K3NYWEN5b1R4UThTZHlRS21rVHY3TGVzQzR4TnlXYWsv?=
 =?utf-8?B?ZlhjVXVHRWkyNFVrNHBTT2NhSmF2YlE3TG5hazYyOTJSL21CZHRSTnJELzRr?=
 =?utf-8?B?dnhMbUV2RzZrWGJldG5kTGpsMWRpRzNHdDhNdHN5S2JBNlFwWGR2enROZ0Va?=
 =?utf-8?B?M3NlOU94Qk8zRm4xUDVWbDljcjdUZ3BaVFh3dW9HLzJlT2d0YjFzODh5Y1Zi?=
 =?utf-8?B?bHRqeC9GMUQ1QWpEaEtJL0FZbVFYQkZLd3NuN2VESC9zYmk3ZDJKVjFXR1Bt?=
 =?utf-8?Q?CJhxjfvNO3ZjNN6tciigV9A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf2d37a2-984e-4ea3-b46a-08d9b8aaf88c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 11:24:30.6705
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: otr490mjsuSR4onkI2/pNkfYCftrgHYGGaGfTmSrn3FpBikciH3Vz1Td9aPhCvSZLwpUUKDz82HQGUB/3Yty+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3933

On 26.11.2021 13:34, Andrew Cooper wrote:
> With all the pieces now in place, turn CET-IBT on when available.
> 
> MSR_S_CET, like SMEP/SMAP, controls Ring1 meaning that ENDBR_EN can't be
> enabled for Xen independently of PV32 kernels.  As we already disable PV32 for
> CET-SS, extend this to all CET, adjusting the documentation/comments as
> appropriate.
> 
> Introduce a cet=no-ibt command line option to allow the admin to disable IBT
> even when everything else is configured correctly.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> @@ -1102,11 +1116,33 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>          printk("Enabling Supervisor Shadow Stacks\n");
>  
>          setup_force_cpu_cap(X86_FEATURE_XEN_SHSTK);
> +    }
> +
> +    if ( opt_xen_ibt && boot_cpu_has(X86_FEATURE_CET_IBT) )
> +    {
> +        printk("Enabling Indirect Branch Tracking\n");
> +
> +        setup_force_cpu_cap(X86_FEATURE_XEN_IBT);
> +
> +        if ( efi_no_cet_ibt )
> +            printk("  - UEFI Runtime Services not IBT safe\n");

Here it becomes clear why you need the variable also in efi/stub.c.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 11:26:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 11:26:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238816.413883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC89-0006NF-BQ; Mon, 06 Dec 2021 11:26:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238816.413883; Mon, 06 Dec 2021 11:26:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muC89-0006N8-8V; Mon, 06 Dec 2021 11:26:01 +0000
Received: by outflank-mailman (input) for mailman id 238816;
 Mon, 06 Dec 2021 11:26:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DWHB=QX=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1muC87-0005h1-Tc
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 11:26:00 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 48a8fb67-5687-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 12:25:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 48a8fb67-5687-11ec-a5e1-b9374ead2679
Date: Mon, 6 Dec 2021 12:25:55 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638789957;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XLs7YgdFMIcnSazYWZg4jsTq0LGaE/jvcz9Rja/NPMc=;
	b=nAoYk+Ns+6rmT6S9GzrSjhIPCBYjUqfpnGgNgz+swrTZH5Hw/lUwxcA6aKMJq7Q1zV6wb8
	lyNZuLXvJ7mORj0HmC2r9A1REaO6OPTuOtCiJhf4MK6jQvZS22Km7jBifTDhEfnLl0amBK
	LKOsEWmcdXrqg2LxF0mM4c8iJ22mWlKB0hM2uMXvqS1S4wXaJHQyrzN8sTx0C5l77fk0tj
	rX9FyDns92354iLK4whoATvbvW0u1G3rUCCx9LfCZFM2UjgRe43x8C4beJ10j+bdrhHmU+
	rDQqwswK9S41FtMsOXDdIKm1HF133yCuAlr6FysAznUe6Qn4lQo+lYA2435Z1Q==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638789957;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=XLs7YgdFMIcnSazYWZg4jsTq0LGaE/jvcz9Rja/NPMc=;
	b=doqpd2ejENwBdGZzJ4Idl5tc2F68NpSZ4at5EQ4oLMg2zEZwjKY7pzeUgsuXYAnBVvv0S5
	TSsw8u9yi/SU/hDA==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Longpeng (Mike, Cloud Infrastructure Service Product Dept.)" <longpeng2@huawei.com>,
	linux-kernel@vger.kernel.org,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>, x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be
 brought up again.
Message-ID: <20211206112555.ubscfwwxnn5bnyte@linutronix.de>
References: <20211122154714.xaoxok3fpk5bgznz@linutronix.de>
 <87y25djhaj.ffs@tglx>
 <4d04ea65-ea74-dcfd-5b0e-984b44f91961@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4d04ea65-ea74-dcfd-5b0e-984b44f91961@oracle.com>

On 2021-11-24 21:17:34 [-0500], Boris Ostrovsky wrote:
> 
> On 11/24/21 5:54 PM, Thomas Gleixner wrote:
> > Any comment from XEN folks?
> 
> 
> If memory allocation in cpu_initialize_context() fails we will not be
> able to bring up the VCPU because xen_cpu_initialized_map bit at the
> top of that routine will already have been set. We will BUG in
> xen_pv_cpu_up() on second (presumably successful) attempt because
> nothing for that VCPU would be initialized. This can in principle be
> fixed by moving allocation to the top of the routine and freeing
> context if the bit in the bitmap is already set.
> 
> 
> Having said that, allocation really should not fail: for PV guests we
> first bring max number of VCPUs up and then offline them down to
> however many need to run. I think if we fail allocation during boot we
> are going to have a really bad day anyway.
> 

So can we keep the patch as-is or are some changes needed?

> -boris

Sebastian


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 11:38:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 11:38:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238825.413897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muCJt-0008Fr-Eu; Mon, 06 Dec 2021 11:38:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238825.413897; Mon, 06 Dec 2021 11:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muCJt-0008Fk-Bp; Mon, 06 Dec 2021 11:38:09 +0000
Received: by outflank-mailman (input) for mailman id 238825;
 Mon, 06 Dec 2021 11:38:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muCJs-0008Fe-SW
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 11:38:08 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa97bec5-5688-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 12:38:07 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:51264)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muCJp-000GU9-hI (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 11:38:05 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 14E3B1FE08;
 Mon,  6 Dec 2021 11:38:05 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa97bec5-5688-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <21f914a0-3d20-6ce2-cc4a-b3bfe26284fa@srcf.net>
Date: Mon, 6 Dec 2021 11:38:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
 <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
 <a96abdb7-cdf7-2b24-d293-d3d2c6c77c78@srcf.net>
 <22317ebe-4e21-5515-9061-33b21eefd4ae@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
In-Reply-To: <22317ebe-4e21-5515-9061-33b21eefd4ae@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 09:42, Jan Beulich wrote:
> On 03.12.2021 16:30, Andrew Cooper wrote:
>> On 03/12/2021 13:32, Jan Beulich wrote:
>>> On 26.11.2021 13:34, Andrew Cooper wrote:
>>>> Each IDT vector needs to land on an endbr64 instruction.  This is especially
>>>> important for the #CP handler, which will escalate to #DF if the endbr64 is
>>>> missing.
>>> One question here: How does this work?
>> Honestly, I'm not sure.
>>
>>>  I don't recall there being any "CET
>>> shadow" along the lines of "STI shadow" and "SS shadow", yet there's
>>> clearly an insn boundary here that gets "skipped" if the 2nd #CP gets
>>> converted to #DF. And fetching of the first handler insn also isn't part
>>> of exception delivery (and could cause other exceptions first, like #PF).
>> I can't make my observations of real hardware behaviour match the
>> description in the spec.
> I haven't been able to find a description at all of exception behavior
> when the exception occurs in wait-for-endbr state. There is text saying
> that #BP and #DB can occur this way, but I couldn't find anything about
> the tracker state changes in such cases. While I could see the state to
> remain engaged (requiring an ENDBR at the handler's entry point), I
> cannot see how the state would get re-engaged upon IRET from the
> exception handler, unless the return is back to CPL3.

Critically, there are two wait-for-endbr states.  One in MSR_U_CET and
one in MSR_S_CET, and the active one is dependent on CPL.

Interrupting CPL3 does leave the state visible (and frozen) in MSR_U_CET.

Interrupting CPL!=0 does not.  The interrupt/exception delivery
microcode forces the wait-for-endbr state which is why the entrypoints
need ENDBR64, and while I haven't confirmed yet, I'm pretty certain that
a WRMSR to MSR_S_CET which sets wait-for-endbr needs an ENDBR64
following it.

IRET does not alter the wait-for-endbr state, but does switch which of
the two trackers is active, as a side effect of changing CPL.


#CP is a decode-class fault, and takes priority over #UD and #NM. 
However, the #BP/#DB special cases are specific to the INT3/INT1
instructions, to specifically permit putting a breakpoint on an ENDBR
instruction and to take the breakpoint exception rather than #CP. 
Critically, #CP has higher priority than General Detect #DB.

(I've already got the beginnings of an XTF test case for shstk corner
cases, but it's got nothing on how complicated the IBT side of things
looks.)

>> Given what a mess it all is, I wouldn't be surprised if the exception
>> delivery microcode has a special case to escalate this to #DF.
> I am meanwhile wondering whether any exception in wait-for-endbr state
> at CPL < 3 would promote to #DF, for loss of state. Albeit there must
> still be a distinction between CALL/JMP induced state and that
> resulting from interrupt or exception delivery. Yet there's no
> architectural (or shadow) state expressing "first insn of an exception
> handler".

Architecturally, no, but there is internally by virtue of the fact that
all interrupt/exception delivery is organised by microcode.

> I'm not even convinced the aforementioned statements about #DB and #BP
> are actually meant to cover more than just CPL3, or at best ENDBR at
> normal CALL/JMP destinations.
>
> While for Xen's own use we may get away without knowing how all of this
> actually works (perhaps accepting the fact that one can't set breakpoints
> at exception handler entry points, depending on whether their delivery
> would promote to #DF), as soon as we were to support CET-IBT for guests
> we'd definitely need to know.

I'm afraid I don't follow the point you're trying to make.  INT3/INT1
are explicitly special, to let you breakpoint an ENDBR instruction, and
that really ought to mean everywhere.

Another possibility is that my observations are an errata in TGL, or
that I've made a mistake somewhere.

However, until we start getting to the point of having some real XTF
tests for behaviour, including that of the emulator, I doubt we'll get
much clarity.  Furthermore, there's a pile of work to do before that is
a possibility.  As a minimum, I need to fix up and repost my xsave
cleanup series, then implement XSAVES support for guests, before we can
make CET an opt-in feature pending completion of the emulation work.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 12:28:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 12:28:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238838.413908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muD61-0005pj-Ek; Mon, 06 Dec 2021 12:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238838.413908; Mon, 06 Dec 2021 12:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muD61-0005pc-BW; Mon, 06 Dec 2021 12:27:53 +0000
Received: by outflank-mailman (input) for mailman id 238838;
 Mon, 06 Dec 2021 12:27:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muD60-0005pU-1i
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 12:27:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed5e31d9-568f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 13:27:50 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-glmvmHS7PY2dKppgkBvBYA-2; Mon, 06 Dec 2021 13:27:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Mon, 6 Dec
 2021 12:27:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 12:27:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 12:27:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed5e31d9-568f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638793670;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZsTyoy4yZVHRzzrvmZ5OyK1yJBPZbg00HhNofeXOFyc=;
	b=Luy+R5N272hX5fUuhD5Pqv6IGCGv6CRQMYZiNsT7pObOWydPtERJCzNf2ERqKB7RuEaA6g
	7JB7iRRZTuRGBOW7QWN9FbVgDJqlsUjQ54jiu9uwkBYzNZHqeeq+85c4w8VwutZRbCuozj
	gmsOlK7XuY93kuUn1TRsRpHQLmK0kJ4=
X-MC-Unique: glmvmHS7PY2dKppgkBvBYA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mxIhRzQ68umEirBQqvEZBVb2TGNPWbasH7CQ3OI859J8UtwHg8bxPZ9qccwjddg2YGZYrU1b/knJvBSeeLBkofhbELIb04y4q8XHVjJhvEM/RYFLbGh93oq6S+nulXbr428dexsiWZi9tpuIi0/pXkf7Icsjs68TBREt7hdvnzwumA3vOIVWAt6rafrqytaIGbZTKeANRYETacde8iycZ6D6936z8+Xip43wd5gbYqyDb2ZWl6Ny9e3tYPwRMLRUUvOyhDtqsMr15pV4Go3wPfFfuQk91/4T3vWHLmWC5s1RwDmrQF7rN8Z3cYRNzZVXb9y2J/hhIGE+98mvsy1DLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=b4hU1cqEC3U1hgiryBGOPyCMWJsqTZwA50OnsF9uySw=;
 b=dBnft2/pVRA8DBOm1f8zB5cd+xpCM9Td6Lk197fhN+T9/cZoyI/PCLybGL22C1fOuti8bSaUlIY9jbhG8bSGYJKM2rfrqPm7xRkW+Ubf8D5ngh16blxJjJ+stlLgxQMjk1qdxqAL/NRH1YOoC62fyS3w7So05bPkbwFGSgGjEoTUsiqXhDWL5v8VgHvyHT1XMOy25emAakWSstTYSaLEG3PTxf4hw5hcuX2vC0ji4ttKLjbGgVPVxh3G7fdfxmagqDCj44hDTlrU1PtL6ikok1+KxoR/vpyHibIz6xxkKmRfxUAGBCjP2xmaQnRx9shwFgTixz40HjFizGpL3nCqjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fe01dfb7-d762-3960-1d02-738a88e6e626@suse.com>
Date: Mon, 6 Dec 2021 13:27:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 62/65] x86/entry: Make IDT entrypoints CET-IBT compatible
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-63-andrew.cooper3@citrix.com>
 <a64a40ef-82f7-2264-5656-aaa5c94384f1@suse.com>
 <a96abdb7-cdf7-2b24-d293-d3d2c6c77c78@srcf.net>
 <22317ebe-4e21-5515-9061-33b21eefd4ae@suse.com>
 <21f914a0-3d20-6ce2-cc4a-b3bfe26284fa@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <21f914a0-3d20-6ce2-cc4a-b3bfe26284fa@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0402CA0021.eurprd04.prod.outlook.com
 (2603:10a6:203:90::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 964b9c00-43f2-49cd-8e39-08d9b8b3cf70
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4384A07D0CC00D0C0F811848B36D9@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GL5CimTKfW+vZFC+PeOvWFHv/tulMYLpRTbxf3GYdoFR3QfK1osqwVyZ2DXHxqhqOh/M0iZs0ceKYoJEycqqrohiS3eUe2HdbV8RGCUbjTXbu8X5YMMyA27sPjjP0nSkymiXvN6nc09UKMpVta56EKVK2ibut3n9CN2SLKoWABvQYBGt1o4EAUO9U9Remu5mbneSgNER4aYwX/5B0saecIKPhz4su9zvXOltkao9vVjvaVlKvsS7KRrZCm/OA5O2Ac0MqfFkfaJKiBL/9arEqZj2S4VWy2bZXyyvZoKzVEdoHxtAV86HDUL/kJ1yNdP51CBdGNglGkQ1Lv5F4cJlmMgT0dWlSakDBFm2PosXZEeySdoB9hXjgHoGrTicVA78ZYyad32eWY4Y23g19rO4iSv85YKb759U2cG9ybFmnd9rP0mXcgwZOa2ogN9xFy3qeeR5TPFqRM2QCRPx2mY/s+uLHCfXWlIGhwhyS+1TSvqysEf4s5uM7TMV3QPxFc2vFPQ6//AqNIg5STIhodFa0U3YEMAlRspFRfqsMn+2g0VkH62d8lDhhVS/akJQZAt3C+mn2b6lJvIhoSpeGhThGISb9ZjZ51iw2xyQa8JVo8lLMrXkT/Q6PTlvKMioCAv24ABIjfT6Ea8NYD9G5kziP6SNiGAplqZ7yCpMCwEzkwE3olLyXB8OPOVmYYsIqRg+vaIKX3+Rjz/FhXW2T7rLAH5pzpNTuDHGABnPGqT3UO8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(4326008)(26005)(6486002)(16576012)(508600001)(54906003)(8676002)(83380400001)(53546011)(31686004)(956004)(38100700002)(31696002)(110136005)(2906002)(2616005)(66946007)(186003)(86362001)(66476007)(66556008)(36756003)(5660300002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ji4ZQF8RZDI9Lr6soJb03MYOcGKzifJmSfov8dj1Rl53NK66JRl9e9rYeaIO?=
 =?us-ascii?Q?u/lxUETWlS1ecYuSKZYbXSwj2nNpgdvTwoTGR1Ra6zYt0rTMJLX5IUGG4Ryo?=
 =?us-ascii?Q?TBKrempoYoMF+Ur+QLhPEp6sz8/WxiSbzzFQNXVyRRoOJJ7Gygfjy1P0TaEL?=
 =?us-ascii?Q?jd/KzrINLNULLQEnTr4SfKFYMD0FXJ3FEo7UISg8pqVM7Gx+fuvInB3hLnbS?=
 =?us-ascii?Q?KhO4Y5IOdQbhJOxxJPZ4b3+vijsBw2pp66mw250qXMmtOSXIYzXzdxwLzgl4?=
 =?us-ascii?Q?YfCX3U7CSp+KC3RqFAMLneoVE163XvMLPasLvv645zsUKEHKj81DtKu/LRrp?=
 =?us-ascii?Q?TfB2cwpxJsYHeOPbgHU3+95qy9DZAqRbm4EOn5LvGUlAjmrHBO50KOmhJlTE?=
 =?us-ascii?Q?YY2NW36oZ+QJUVHETomqKLPTIuXBdKv34iSCvwMqcgdWCw9ZoYgfou37z4no?=
 =?us-ascii?Q?zaUaEioOX7SSf1xAu18RYuXDvsTp/wUKcrn/VioS9CSNNG1oYnkA/kmdvAAs?=
 =?us-ascii?Q?tZLv8fFSlDP2fuaiGLwXNIRECyvhWg+vIXMX6cO1P6yVwJF4sw35+C3EDqTC?=
 =?us-ascii?Q?TqB6nfFLgCp8YdkoFSZomIrdlz5d9bH7C3+oZ8shk7JZpOOQ6ZMJy+1RNtNM?=
 =?us-ascii?Q?eCsqnjjECq7VQDcG/TVzUwxwiGwvyO6xzZ/PmcwauZpV7vYklU2mQiSkZHcL?=
 =?us-ascii?Q?1jVS3hHXNU8DnC22fFBUY1Oqz4meG3fayysPiRBt1r4BmghXuc148nkyGYNK?=
 =?us-ascii?Q?D38TAsbQjidK7l5fs/j7LbgXahOQofeW8Acx1m0PzM+VWMdJaxtius6by1ns?=
 =?us-ascii?Q?mN2Xdls3bZy0zdWWbl+2vbDov/ZpCbsAiO4IxEgqjzuCY0J4avM6SAVLN3iz?=
 =?us-ascii?Q?8BEh4HKhehKSNyPK3R7j9jo14tZnpD6SvrVJlS8/XCn0ftQTojeeTYzF4bqB?=
 =?us-ascii?Q?mEdCFSqzL7IkUtRqibJa3GzmrWz5qt1RCFm4Em6K31+S08fJrXF4c/MMJjUv?=
 =?us-ascii?Q?Vh+latvqeuzPqpRk7keooyXzEWtR0mOkkrVLSj/4PYijnQyYlAbmOUqIWzCT?=
 =?us-ascii?Q?7ow8Kzdf4siDE7fceV+4grUw35wSgLS4G2IVIbYJ9yhVEVzmRvD40LO0Bliz?=
 =?us-ascii?Q?p3ozYIG00WrepA1Xfax5eih6aUnHGlf9L7df6uSqwD9Mfhxwbn6mX1leIULE?=
 =?us-ascii?Q?Ci8mIjBQhomXEIUKTlxmZPBUwJcpMZmd24Cy+dMja9TKE6AHGv1MALCMdGbO?=
 =?us-ascii?Q?wfCijcrcqMrh4QntbHvxpBvaNyV1t/BnyRSXMIxTsBv20D7ugqIZlveQu/0I?=
 =?us-ascii?Q?Cb7gpUemaK6JFRCYcA4poe+9GcpQNDvy2nk+QrzosXlowoLYh1m1Wt5miQpH?=
 =?us-ascii?Q?MvCZUBcXhwi/uDFCE3gWlW5EpEAbSJhA2EEBOnlyMTRxPBsD38sERTXveKc5?=
 =?us-ascii?Q?hIzuX0IrE33uBsZeUJnRM0SN81ScspjzXJKlMugfXX62NSGUdhxezUwr8PSS?=
 =?us-ascii?Q?G3aTddH0ex/7s32KugnmAx5jfBWPxqeG8van2Z8vy6Gi0s6LTJw9DbwRDZDM?=
 =?us-ascii?Q?gMazIPd5tTF9nYNXmoXqOyok2GWWHT5ODgLbjkGtyrjPv0izLT5o5kWUW7KB?=
 =?us-ascii?Q?rJcsx/IS6TTwS2M2sbWOkgo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 964b9c00-43f2-49cd-8e39-08d9b8b3cf70
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 12:27:47.0631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JhDR5FWCwbiKnOS00wwQQRcVKsEUneIVniWi9HKa8soGdALelrkfdguDzWuKmNTvQZDxZ0H8OT/AaNQNIAP9mQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 06.12.2021 12:38, Andrew Cooper wrote:
> On 06/12/2021 09:42, Jan Beulich wrote:
>> On 03.12.2021 16:30, Andrew Cooper wrote:
>>> On 03/12/2021 13:32, Jan Beulich wrote:
>>>> On 26.11.2021 13:34, Andrew Cooper wrote:
>>>>> Each IDT vector needs to land on an endbr64 instruction.  This is esp=
ecially
>>>>> important for the #CP handler, which will escalate to #DF if the endb=
r64 is
>>>>> missing.
>>>> One question here: How does this work?
>>> Honestly, I'm not sure.
>>>
>>>>  I don't recall there being any "CET
>>>> shadow" along the lines of "STI shadow" and "SS shadow", yet there's
>>>> clearly an insn boundary here that gets "skipped" if the 2nd #CP gets
>>>> converted to #DF. And fetching of the first handler insn also isn't pa=
rt
>>>> of exception delivery (and could cause other exceptions first, like #P=
F).
>>> I can't make my observations of real hardware behaviour match the
>>> description in the spec.
>> I haven't been able to find a description at all of exception behavior
>> when the exception occurs in wait-for-endbr state. There is text saying
>> that #BP and #DB can occur this way, but I couldn't find anything about
>> the tracker state changes in such cases. While I could see the state to
>> remain engaged (requiring an ENDBR at the handler's entry point), I
>> cannot see how the state would get re-engaged upon IRET from the
>> exception handler, unless the return is back to CPL3.
>=20
> Critically, there are two wait-for-endbr states.=C2=A0 One in MSR_U_CET a=
nd
> one in MSR_S_CET, and the active one is dependent on CPL.
>=20
> Interrupting CPL3 does leave the state visible (and frozen) in MSR_U_CET.
>=20
> Interrupting CPL!=3D0 does not.=C2=A0 The interrupt/exception delivery
> microcode forces the wait-for-endbr state which is why the entrypoints
> need ENDBR64, and while I haven't confirmed yet, I'm pretty certain that
> a WRMSR to MSR_S_CET which sets wait-for-endbr needs an ENDBR64
> following it.

That's my expectation, too.

> IRET does not alter the wait-for-endbr state, but does switch which of
> the two trackers is active, as a side effect of changing CPL.

Well, it only really _switches_ when going from CPL<3 to CPL3. Otherwise
it leaves what is there, meaning wait-for-endbr disengaged. And hence
an interruption at the target of an indirect CALL/JMP will squash the
requirement for an ENDBR to be there. Perhaps a weakness that the
architects considered acceptable and "better" than having to add a way
to save/restore state (where at least the restore part would necessarily
need to be part of IRET itself).

> #CP is a decode-class fault, and takes priority over #UD and #NM.=C2=A0
> However, the #BP/#DB special cases are specific to the INT3/INT1
> instructions, to specifically permit putting a breakpoint on an ENDBR
> instruction and to take the breakpoint exception rather than #CP.=C2=A0
> Critically, #CP has higher priority than General Detect #DB.

That's what the text in the spec suggests. Yet why would #DB / #BP be
any more special / important than, say, #PF?

>>> Given what a mess it all is, I wouldn't be surprised if the exception
>>> delivery microcode has a special case to escalate this to #DF.
>> I am meanwhile wondering whether any exception in wait-for-endbr state
>> at CPL < 3 would promote to #DF, for loss of state. Albeit there must
>> still be a distinction between CALL/JMP induced state and that
>> resulting from interrupt or exception delivery. Yet there's no
>> architectural (or shadow) state expressing "first insn of an exception
>> handler".
>=20
> Architecturally, no, but there is internally by virtue of the fact that
> all interrupt/exception delivery is organised by microcode.
>=20
>> I'm not even convinced the aforementioned statements about #DB and #BP
>> are actually meant to cover more than just CPL3, or at best ENDBR at
>> normal CALL/JMP destinations.
>>
>> While for Xen's own use we may get away without knowing how all of this
>> actually works (perhaps accepting the fact that one can't set breakpoint=
s
>> at exception handler entry points, depending on whether their delivery
>> would promote to #DF), as soon as we were to support CET-IBT for guests
>> we'd definitely need to know.
>=20
> I'm afraid I don't follow the point you're trying to make.=C2=A0 INT3/INT=
1
> are explicitly special, to let you breakpoint an ENDBR instruction, and
> that really ought to mean everywhere.

Maybe. The point I was trying to make was the more general case of an
exception of the ENDBR at the beginning of another exception handler.
Perhaps there indeed is merely a special case for #CP. But that wouldn't
help with e.g. #PF occurring on the #CP handler entry point and the #PF
handler lacking ENDBR. How these cases are meant to work (and which ones
have special treatment) is necessary for us to know the latest when we
want to allow guests to use the features. There, besides getting things
to function correctly, it would also be relevant to know to be sure
there's no XSA-156 equivalent lurking.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 12:46:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 12:46:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238844.413919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDNs-0008I7-0z; Mon, 06 Dec 2021 12:46:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238844.413919; Mon, 06 Dec 2021 12:46:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDNr-0008I0-U7; Mon, 06 Dec 2021 12:46:19 +0000
Received: by outflank-mailman (input) for mailman id 238844;
 Mon, 06 Dec 2021 12:46:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muDNq-0008Hp-5W
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 12:46:18 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80c9bbf1-5692-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 13:46:17 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9082F212C0;
 Mon,  6 Dec 2021 12:46:15 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 569A413C18;
 Mon,  6 Dec 2021 12:46:15 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id RTnhExcGrmGACgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 12:46:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80c9bbf1-5692-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638794775; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/A9hituH0+aNT0T1wCGc2OkDoQuYF+gpjDznKK7VZyY=;
	b=sMm+Y895O0EMvsESVYoYMPjP+qY/t980M9zrWHQy010a6pGQqMqpy34xMtKhzo6hxaeM96
	L2yuI7aFWFCEaWR503e4VfHsKhGdxpghBvA68AOKebDHvflqU5YL4qxLbFXOYNEaKyK/fq
	/S7mGpe2S0PIThYZ2G4/8Q9ZpzFCDCs=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] mini-os: support event channel 0 for console
Date: Mon,  6 Dec 2021 13:46:12 +0100
Message-Id: <20211206124612.24758-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206072337.9517-1-jgross@suse.com>
References: <20211206072337.9517-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The console event channel might be 0 for the console, so use the value
of ~0 as invalid instead.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 console/xencons_ring.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/console/xencons_ring.c b/console/xencons_ring.c
index b6db74e..5c2573e 100644
--- a/console/xencons_ring.c
+++ b/console/xencons_ring.c
@@ -17,7 +17,7 @@
 DECLARE_WAIT_QUEUE_HEAD(console_queue);
 
 static struct xencons_interface *console_ring;
-uint32_t console_evtchn;
+uint32_t console_evtchn = ~0;
 
 static struct consfront_dev* resume_xen_console(struct consfront_dev* dev);
 
@@ -55,7 +55,7 @@ static inline void notify_daemon(struct consfront_dev *dev)
 
 static inline struct xencons_interface *xencons_interface(void)
 {
-    return console_evtchn ? console_ring : NULL;
+    return (console_evtchn != ~0) ? console_ring : NULL;
 } 
  
 int xencons_ring_send_no_notify(struct consfront_dev *dev, const char *data, unsigned len)
@@ -181,7 +181,7 @@ struct consfront_dev *xencons_ring_init(void)
 {
     struct consfront_dev *dev;
 
-    if (!console_evtchn)
+    if (console_evtchn != ~0)
         return 0;
 
     dev = malloc(sizeof(struct consfront_dev));
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 12:49:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 12:49:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238851.413934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDQW-0000kd-I6; Mon, 06 Dec 2021 12:49:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238851.413934; Mon, 06 Dec 2021 12:49:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDQW-0000kW-Dj; Mon, 06 Dec 2021 12:49:04 +0000
Received: by outflank-mailman (input) for mailman id 238851;
 Mon, 06 Dec 2021 12:49:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muDQV-0000kQ-6H
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 12:49:03 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e36a59aa-5692-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 13:49:02 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 231B921B40;
 Mon,  6 Dec 2021 12:49:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F1FF913C32;
 Mon,  6 Dec 2021 12:49:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id T0XkOb0GrmHECwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 12:49:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e36a59aa-5692-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638794942; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=/auGAqrKxpTK5DtRttjAh+FAkfrM4EO5V1g3/AquMvI=;
	b=XuD72peyg1LbNkmcxnjY/KY//wc+UTTDlHl766yeMJxPHYCQtEKo3QIr2YtlgG7JvTblH2
	iy7K5ye1X0u65Kvx0eOLfzH08B028k0Az63yZFTBNHesMAD+db5t3o1yTmMdySYaaEyOKx
	j5T29xM5W/Rb3ut9g622loMwewkNqpg=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] tools/helpers: fix PVH xenstore-stubdom console parameters
Date: Mon,  6 Dec 2021 13:48:59 +0100
Message-Id: <20211206124859.24911-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When using a PVH mode xenstore-stubdom the frame number of the console
should be a PFN instead of a MFN.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/helpers/init-xenstore-domain.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index b205a79ee6..5799ba5232 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -30,7 +30,7 @@ static char *param;
 static char *name = "Xenstore";
 static int memory;
 static int maxmem;
-static xen_pfn_t console_mfn;
+static xen_pfn_t console_frame;
 static xc_evtchn_port_or_error_t console_evtchn;
 
 static struct option options[] = {
@@ -283,7 +283,9 @@ static int build(xc_interface *xch)
     }
 
     rv = 0;
-    console_mfn = xc_dom_p2m(dom, dom->console_pfn);
+    console_frame = (dom->container_type == XC_DOM_PV_CONTAINER)
+                    ? xc_dom_p2m(dom, dom->console_pfn)
+                    : dom->console_pfn;
 
 err:
     if ( dom )
@@ -528,7 +530,7 @@ int main(int argc, char** argv)
     do_xs_write_dir_node(xsh, fe_path, "tty", "");
     snprintf(buf, 16, "%d", console_evtchn);
     do_xs_write_dir_node(xsh, fe_path, "port", buf);
-    snprintf(buf, 16, "%ld", console_mfn);
+    snprintf(buf, 16, "%ld", console_frame);
     do_xs_write_dir_node(xsh, fe_path, "ring-ref", buf);
     xs_close(xsh);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 12:57:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 12:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238857.413945 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDY5-00029e-Af; Mon, 06 Dec 2021 12:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238857.413945; Mon, 06 Dec 2021 12:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDY5-00029X-7G; Mon, 06 Dec 2021 12:56:53 +0000
Received: by outflank-mailman (input) for mailman id 238857;
 Mon, 06 Dec 2021 12:56:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muDY4-00029R-63
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 12:56:52 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f9930dff-5693-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 13:56:49 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44610)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muDY0-0004Rb-29 (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 12:56:48 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 760971FE08;
 Mon,  6 Dec 2021 12:56:48 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9930dff-5693-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <043425e2-44e1-2e05-8f90-5d3c7835938c@srcf.net>
Date: Mon, 6 Dec 2021 12:56:48 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206124859.24911-1-jgross@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/helpers: fix PVH xenstore-stubdom console
 parameters
In-Reply-To: <20211206124859.24911-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 12:48, Juergen Gross wrote:
> When using a PVH mode xenstore-stubdom the frame number of the console
> should be a PFN instead of a MFN.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

I tried fixing this before, but it appears that it didn't stick (for
reasons pertaining to legacy pv-grub, so perhaps not relevant any more).

What needs to go in xenstore is a gfn, so at a minimum the variable
should be named console_gfn.

With at least that change made, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>

The proper fix is to alter dom->{console,store}_pfn to be gfns, because
that's what all the users actually want.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:08:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:08:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238866.413962 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDig-00043x-Dn; Mon, 06 Dec 2021 13:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238866.413962; Mon, 06 Dec 2021 13:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDig-00043q-9U; Mon, 06 Dec 2021 13:07:50 +0000
Received: by outflank-mailman (input) for mailman id 238866;
 Mon, 06 Dec 2021 13:07:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3Xlh=QX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muDie-00043k-Go
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:07:48 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7fbc92bb-5695-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:07:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fbc92bb-5695-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638796066;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=9k71yHsPu4B98K1Cd0X0PtdTYyyopEnc/TMQhN3V4E4=;
  b=hpecua329P+kT93QaCyHXVB0j8IyPbGsORMWbsfZmKlz9Mv59E9B2YYD
   uK2ZNu7uZ2YWXdOUxIA+7fKXRzbyTlhNf8J4YfZypxiiBaIzX5vDRzcMK
   jJ2b3/tECAo4uDqA/0fKzQqAZ7Lhxk1OfGL1phKu4VjxfQYqiX4Aoqw5O
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: AStHQWB7mUOo3vhzOP1bLnPKBIANeGZScR24iMq6p1i1b4a66WL1JMglxPRKQPRdJztantguhE
 jXDNTHw32oztN2NwebU+xMiX2IMqLV0x5xwUdoSwNY69eR/z0SxkeLX1vyQgFC5W6bGFF+t82j
 Ra3+X88sFY1Y0Whq1CZjdgyZzNp7Uf5ZbzS7Dl1wRLCIX327/Q8XXIKgJWK2T2Bwof6Kz/8ES6
 A3lixLqa96Z37TRsKOW4C+tztBcgAhcwIyskdoqFRGn5bzgp4QtVWs6OMRVC7oyZLKhxq7ifID
 oApw4GlTnbwEr6HTQjuSQZIF
X-SBRS: None
X-MesageID: 59345909
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/KDOKqA8XAVYQRVW/xXkw5YqxClBgxIJ4kV8jS/XYbTApG4l1jRVn
 TNNWmyDPq2IZmWkLowlOd+/80pQ75aGy4c3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/hieFxN9dz
 /B37beqaCcjZ4T9pvkGTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFjWxs25EWTJ4yY
 eIIMAtKfhfqXyEVM1NHL6sjsfmXl1PWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiHOWskUTd911KbUR8iCtwPP90jiEHXdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4gDGJGT9bxgbQ+0RqmBNzDJrVml
 CJb8/VyFMhUUfmweNWlGY3g3NiBvp5pygH0j191BIUG/D+w4XOldo04yGggfxc2aJdZI2W3P
 x+7VeZtCHl7ZiHCgUhfOd3ZNijX5fK4SYSNug78MLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirV4/s7ikl0z/uVdfDVbLIYo43KymMrpksfja+VqNq
 L6y9aKikn1ibQE3WQGPmaZ7ELzABSJT6Unep5MFe+idDBBhHW19Wfbdzal4I95unrhPl/eO9
 Xa4AxcKxF36jHzBCAOLdnE8N++/Acch9So2bX42IFKl+3k/eoLzvq0RQIQ6IOs8/+t5wP8qE
 /RcI5ecAu5CQyjs8igGacWvt5RrcRmm3FrcPyesbDUlUYRnQgjFpo3tcgf1rXFcBSurr8ou5
 ban01qDE5YEQg1jCufQae6ukAzt7SRMxroqUhKRcNdJeUjq/Ix7EADLj6c6c5MWNBHO5jqGz
 ALKUx0WkvbA/t0u+97TiKHa84rwS7liHlBXFnXw5KqtMXWI5XKqxIJNXbrafT3ZU2+oqqyua
 f8MkqP5OfwD2l1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQf5LdQwrJ5uBetX
 hPd89ZXDryFJcf5HQNDPwEidOmCiakZlzS6AS7Z+6kmCPubJIa6bHg=
IronPort-HdrOrdr: A9a23:pEmcva6nUGfgM7DlkgPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.87,291,1631592000"; 
   d="scan'208";a="59345909"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/build: Move exception tables into __ro_after_init
Date: Mon, 6 Dec 2021 13:07:25 +0000
Message-ID: <20211206130725.13511-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

It turns out that we've always been abusing the fact that .rodata is
read/write during early boot, so we can sort the two tables.

Now that we have a real __ro_after_init concept, reposition them to better
match reality.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/xen.lds.S | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 4db5b404e073..ca22e984f807 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -100,6 +100,18 @@ SECTIONS
 
        __ro_after_init_start = .;
        *(.data.ro_after_init)
+
+       . = ALIGN(8);
+       /* Exception table */
+       __start___ex_table = .;
+       *(.ex_table)
+       __stop___ex_table = .;
+
+       /* Pre-exception table */
+       __start___pre_ex_table = .;
+       *(.ex_table.pre)
+       __stop___pre_ex_table = .;
+
        . = ALIGN(PAGE_SIZE);
        __ro_after_init_end = .;
 
@@ -129,17 +141,6 @@ SECTIONS
        *(.note.gnu.build-id)
        __note_gnu_build_id_end = .;
 #endif
-       . = ALIGN(8);
-       /* Exception table */
-       __start___ex_table = .;
-       *(.ex_table)
-       __stop___ex_table = .;
-
-       /* Pre-exception table */
-       __start___pre_ex_table = .;
-       *(.ex_table.pre)
-       __stop___pre_ex_table = .;
-
 #ifdef CONFIG_HAS_VPCI
        . = ALIGN(POINTER_ALIGN);
        __start_vpci_array = .;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:09:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:09:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238872.413973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDjy-0004hE-SE; Mon, 06 Dec 2021 13:09:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238872.413973; Mon, 06 Dec 2021 13:09:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDjy-0004h7-NU; Mon, 06 Dec 2021 13:09:10 +0000
Received: by outflank-mailman (input) for mailman id 238872;
 Mon, 06 Dec 2021 13:09:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3Xlh=QX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muDjx-0004gj-D8
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:09:09 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0ab5429-5695-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:09:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0ab5429-5695-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638796147;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=+i/cei/bpytCa2fBr5hnfAPuM5YQs1bp5y5I3yPOIm8=;
  b=c6+r+xTPGRfLezpvdZlUcgHRSMaRwiKI5b1+DOAGUsipS/8Ui6oPNZi2
   WYPcpNvRsFnqqLYsRO5GRc96QFT3g0MPKRwdfOe0EUyoT9V4LaKTVSR32
   WYEofvya9zwQUiH2PU3v0Pfj4i3K3B5u9bZ0nUd3JvTdGJKFJdnewao6z
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: /Ao5kkJBxVLDmkhEpCb9lOEG5c3IvYIXm7B+N05NDvUEXi0Osu+kw3ooC7RZ7oXPXCUGh50Sgd
 W2iOCL8JVj/IrJ+1ibksei6l0h927YFNWuID/fjlBl7gZ84n8BoTQ0Ds1sC3/BcmFw5C4ZumPn
 jocbt9eFsi2vMcq1dvtKlTKCvYxt4vymlCt01TaoaM8xc5fY/VzvV1Zp4lntr0GxWyU/HofQjd
 ovkHpGgnGjcBz54+/AzJiJnnyxcaRDDtuQBY8nfA5UjbYvBmbfHSxONndu+/vUUaET4jqQbV7+
 KzZOQBJRRDxGgDH9Vxs3967B
X-SBRS: None
X-MesageID: 59298447
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2UNGxa2H0npYChuV0fbD5e92kn2cJEfYwER7XKvMYLTBsI5bpzcOz
 zZLWjjXPq6LamSkLd4nPoW/808HvZ+Dyd43HFFrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es5w7Bh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhmfZD0
 PYUjqOMRAZzOI7lis0CDh5TDHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9t15ofTaqCO
 KL1bxIyNj/kTiNAOm4oEcwuscirhWDUNARX/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 kDs8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKalhg6acJzStYF1AyMkKz3yhSwGTUDRSEUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/46SPbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNP8D2BLwQKChRqlEGp/ZgPb1
 JTjs5LBhN3i9bnXyESwrBwlRdlEJ5+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43aZZbI260O
 hWN5lM5CHpv0J2CN/Ufj2WZUZtC8EQdPY69CqC8giRmPPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLa0XOTz4ieLGDJNUIJ9bWGazghcRsPnZ/V6Lq
 okHbKNnCXx3CYXDX8UeyqZLRXhiEJTxLcyeRxV/erHRLwx4NnsmDvONk7otd5Y8x/Zel/vS/
 2H7UUhdkQKtiXrCIASMS3ZidLKwAsov8SNlZXQhbQSyxnwuQYez96NDJZE5SqYqqb54xvluQ
 vhbJ8jZWqZTSi7K8ig2ZIXmqNAwbwyigA+DZnL3YDU2c5N6aRbO/9voIlnm+CUUV3Llvsoiu
 bywkAjcRMNbFQhlCc/XbtOpzk+w4idByL4jAROQL4AKKkv28YVsJyjgtdMNIpkBeUfZ2z+X9
 weKGhNE9+PDlJA4rYvSjqeeoob3T+YnRhhGH3PW5KqdPDXB+jbx2pdJVeuFcGyPVG7w/6n+N
 +xZw+ulba8ClVdO9YF9D6xq3eQ14N62/+1WyQFtHXPqaVW3C+w/finajJcX7qAdlKVEvQaWW
 16U/ogIMLqED8rpDVoNKVd3de+Ez/wVxmHf4PldzJ8WP8OrEG5riXlvAiQ=
IronPort-HdrOrdr: A9a23:BpsrTqBxJvLJV5TlHemg55DYdb4zR+YMi2TC1yhKJyC9Ffbo8P
 xG/c5rsSMc5wxwZJhNo7y90cq7MBbhHPxOkOos1N6ZNWGM0gaVxelZnO3fKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.87,291,1631592000"; 
   d="scan'208";a="59298447"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/boot: Restrict directmap permissions for .text/.rodata
Date: Mon, 6 Dec 2021 13:08:55 +0000
Message-ID: <20211206130855.15372-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

While we've been diligent to ensure that the main text/data/rodata mappings
have suitable restrictions, their aliases via the directmap were left fully
RW.  Worse, we even had pieces of code making use of this as a feature.

Restrict the permissions, as we have no legitimate need for writeability of
these areas via the directmap alias.

Note that the pagetables and cpu0_stack do get written through their directmap
alias, so we can't just read-only the whole image.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

Ever so slightly RFC, as it has only had light testing.

Notes:
 * The stubs are still have RX via one alias, RW via another, and these need
   to stay.  Hardening options include splitting the stubs so the SYSCALL ones
   can be read-only after setup, and/or expanding the stub size to 4k per CPU
   so we really can keep the writeable alias as not present when the stub
   isn't in active use.
 * Future CPUs with Protection Key Supervisor (Sapphire Rapids and later)
   would be able to inhibit writeability outside of a permitted region, and
   because the protection key is per logical thread, we woulnd't need to
   expand the stubs to 4k per CPU.
 * At the time of writing, PV Shim still makes use of .rodata's read/write
   alias in the directmap to patch the hypercall table, but that runs earlier
   on boot.  Also, there are patches out to address this.
 * For backporting, this patch depends on c/s e7f147bf4ac7 ("x86/crash: Drop
   manual hooking of exception_table[]"), and nothing would break at compile
   time if the dependency was missing.
---
 xen/arch/x86/setup.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f40a9fe5d351..c8641c227d9a 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1566,6 +1566,14 @@ void __init noreturn __start_xen(unsigned long mbi_p)
         destroy_xen_mappings((unsigned long)&__2M_rwdata_end,
                              ROUNDUP((unsigned long)&__2M_rwdata_end, MB(2)));
 
+    /*
+     * Mark all of .text and .rodata as RO in the directmap - we don't want
+     * these sections writeable via any alias.
+     */
+    modify_xen_mappings((unsigned long)__va(__pa(_start)),
+                        (unsigned long)__va(__pa(__2M_rodata_end)),
+                        PAGE_HYPERVISOR_RO);
+
     nr_pages = 0;
     for ( i = 0; i < e820.nr_map; i++ )
         if ( e820.map[i].type == E820_RAM )
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:22:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:22:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238880.413984 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDwF-00078F-23; Mon, 06 Dec 2021 13:21:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238880.413984; Mon, 06 Dec 2021 13:21:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDwE-000788-TA; Mon, 06 Dec 2021 13:21:50 +0000
Received: by outflank-mailman (input) for mailman id 238880;
 Mon, 06 Dec 2021 13:21:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muDwD-000782-Ri
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:21:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 776b7c7a-5697-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:21:48 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-LSzbM9kXNj6cXoqInMGpiw-1; Mon, 06 Dec 2021 14:21:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7024.eurprd04.prod.outlook.com (2603:10a6:800:124::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:21:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:21:46 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR07CA0018.eurprd07.prod.outlook.com (2603:10a6:20b:46c::24) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 13:21:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 776b7c7a-5697-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638796908;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=sq+Uv+r1URWNwJMKVE9OH314VncJ4FseKCufvyP/8Dw=;
	b=TaaBmm8iR6189N4JpXK8Z1twZal4aIwRNWnoaZP6KdxrcY4YVDhus6GR05fBbC02IOj1rg
	bkPvDcEXBfDnip0lJTwvSE1cJH1irh4kjDMN8Gwkuh1O7SpQpI2dY6Vaihi0gsf0VhBlXV
	IupW5McLdqgVzn84PPkN8pSsQkTU3eU=
X-MC-Unique: LSzbM9kXNj6cXoqInMGpiw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dDzMCYMlxayglk9bxiKQADY1j86y/v/+uuLN94TK//mkuI1N2K/9UwBgQRtbkOw66A2ScFPn2wgx4HaIZ0Bc45iM0Bj2Kl1qg9apj2k2Ox6MTeP7DwP40QBkuxvoqyN84o1cx9MutYsQfLyAkBQAaXKnItNLVYT+R6pVYHf10WJapRCJ16eNz6TwSHbBN7A4uBN2a2mbs7CxdpEsjmrhRDjJXf5HwPBh/dgD1/m+FcAoyr19pC9R98lHylaAoukRY39YqrgtUNofv14T+CdxGUVAWS+2w7QGojega3TBI4WwYT+BHKK8BNA+8+KPqEJtj9r36o3DD4fZ7fL9hPyAQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sq+Uv+r1URWNwJMKVE9OH314VncJ4FseKCufvyP/8Dw=;
 b=Ml8mO+PdXkOOZq4I6EGaZ9dnzM3h/q7H28QSkIsukw/LuFviVE05UfaGZ6J1HCBkeT/dJhf9ArvDnihVVOcVO12E1sid2UsfEHLyhRo5DFngVVQzxzmu1vc7ME3xY6n6lL5VpRJ3MnBFNMWl7RLI3aJ47tJvLf5QsjoCWRS4VsIblMNh91WPPWSZFhSec8njxxc8LpMzULm3Tl802MURXra7ewmcWCeabs0MV0aRgdL0b1SJfweo+6/Ar8bs+USQk3pIqWfsB5iVbCiwDlO4za9Nc6M0dC8SzTLbz2JyL1ySlYRUbJW/YmjLDbqSR3lONupgAeyLgqLK/23LKaxZxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <61c1d38c-65a6-e150-ed53-b565d30c18c9@suse.com>
Date: Mon, 6 Dec 2021 14:21:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] x86/paging: address observation made while working on
 XSA-387
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0018.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 78869865-6d93-487c-affc-08d9b8bb5a31
X-MS-TrafficTypeDiagnostic: VI1PR04MB7024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70240267E268727E2A958F5AB36D9@VI1PR04MB7024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:136;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	J6g7MKGDVMzFRnQi56FveLCREhLKMWQIGYO8dxJW9YpG8YARIuVB+X2MaN4WfmfNg3Sm+Ml7EfxF3nreZtNCDsOhXeUFIEH2QOdb3yeMbCGfk1i+kzUr7L4SwuyJDonptBhC24PF1HV+xQ7mOcZFsH/qhZOBsRubzR0Q8X0Yby2JGqzxTV2D+Uw2VwbR6u9MLqk67+R3YcW29iXshCyD3w+ZSMpKH3niBvNY7Q5K2eUPtMM/vPAH2DMxDj5dREkqXj9I1FAbW7Ki7C8hcchzB2++lko011YoK1m0tgx+PHRXnT2R8hx+EIDtB3XjfNBlEPc49wi+zrQ8m7gv/de1riroPHe2aW1TIduq75IKprd1R657luBeIXYsCas1/XK9eO0CVnCBY3RBzXQKCv/E+bidncD8tOOIe/IA5XsnVgRqdNB9n742VUtO8/Nch3uEmWOBO7s8LgRSYRZQCf6NmYTk4jONYQRpkztDM7xBoncumGGlwxOeCG6VYnaZ6BFU6QBmsA6eHjs53gqVDtTujF7nhMwco/hp1g6WL7DrfbymnathiP6vNcJfl63OBEi3hV+4uLWZl3mt8JsF5TghOsaaSmUAIc6VmDgPM1MRS5xtV9n67XrQAStwXOTj3WJ5YubOYbGYbqJKjbWFLbjCoHeQhEZXg2oxl804RFzmVC862ZBWZSfJ4fGjdjlxhCUIm4AFUa/F++P6keDDnACE53wAozPg3BFrmtBlpsifCFw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(6486002)(2906002)(86362001)(31686004)(186003)(36756003)(4326008)(31696002)(54906003)(16576012)(316002)(66946007)(66556008)(38100700002)(66476007)(558084003)(8676002)(6916009)(508600001)(8936002)(26005)(2616005)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0tCOXl2UWp0UFNodVFuVFF1SjB2eEJZSHMxcUYrL0NrZk0vb08rRzZFVnl2?=
 =?utf-8?B?VitpSlR0UFZjUE82K0NENWY0MkFQdmZkQUlKa296UGZMdE1lMGtJU2VmNUZB?=
 =?utf-8?B?cDZhbHA3eVE4Sk01NXZmWWJJaWxOWlloc1VFR3JwOGFhM245WXVydFdlUnRi?=
 =?utf-8?B?aXNpKzlMME9YdFhTaHRQcjJCeSt4TXpHL2RJZHpOZUFyNUM3djhZdFBjbG90?=
 =?utf-8?B?aERKNzdzOEQ5amgyVXFHamVVbkh3aXlnWHVRUW1rb0RVeUhGY0RTSkp5WFB0?=
 =?utf-8?B?akU0UWlJeHR1M3I0bnNQbmt0V3FGcUVsK0lTbGJ3bHVuaUsrdUJTY0x2a3o3?=
 =?utf-8?B?aE9ocVV4UndLSC9FbmVtdy9vYStiR2N3Q2J2cUlrOThJam4xWjBCMTA4RWk5?=
 =?utf-8?B?bnRRb3FubU81dmZYOE04Z1dCcG5HUE9XN2wzOU1UcjNXMHozZ0N0ZHNkM3NH?=
 =?utf-8?B?d0FhalZHUFBqTElVd3RGODk2ZmFYMWhGWkFSZDFkdW9NblJXSDBjWVZhUCtM?=
 =?utf-8?B?ZEtMNkI1NTh0UnBXdTBLcG5sc0tmVm5EZCtLdWQxeHd6ZG1ncW9Zc1BIa2VZ?=
 =?utf-8?B?UFZGZU92NTk5SjZ1ZEM1VnQzRnlBVHQ2Y3ZDT0JzUjhjMHRPN0haa2NlUU5R?=
 =?utf-8?B?bzNsZVRyY0lQRG5qUUE1OVUxT2w0cnNRdVJtbjNsYkhTbG1vRFYvcmZwOEo1?=
 =?utf-8?B?SmFzNGRGbkh3a1JpS2RsdTFiOFh6SzJMRFVNTk5qSTlPTi9OM1NwNjFVbUY1?=
 =?utf-8?B?WTY3RUltalVQR1ZLcWpybkc4UzlxVlhmaXpWSmtzRkYyLzB1QklzVWhhcTdC?=
 =?utf-8?B?SFF4K2J4aWJvVXhSWWFnVUtzZ1BJR1NqWkdDU2hDd3FoeUxlb2dYNWRETml3?=
 =?utf-8?B?UnZQT042dzhQSDZHQ0UxZ1pjcnlKK0FnT2tkTXJ4T1psT2wvYXhCMnRaaGwr?=
 =?utf-8?B?b1huVHNPK1pvUUVLMUdETllGVkdmRTl2anRYWkxVaHNNekc5VDJQYzdUemp5?=
 =?utf-8?B?QnFFRmRpZ2tlZEVmZ2ZOb1pRYmcyWHJmK2RNSjBQeEJwR3gwQ1Z1Z1dTZzV6?=
 =?utf-8?B?bVBxa0RKOEhjdzB2bzZaV0gyK0YzY2puOVFUQ3ZBRVNpTGhsREE0cU5maUFF?=
 =?utf-8?B?cnFDb3NKb0p2clpNL0x2dGd4LzJzMkgzcmxiYW5Od2JBYVR2aHErWTNmbkM2?=
 =?utf-8?B?Sk1GRXRNSnFaVnhUSXhnMW5QekV5YWl1VWp1dEJJRHVaVWhrd1V6N2ZWUDBj?=
 =?utf-8?B?T281K1Qwc0tlZUdSaGtMQmNGK3lKTWpOditVaTdnd0lTZm1mSmRNd2hvQjhI?=
 =?utf-8?B?T05za1lvb0hrNmxKMnRYV0ZHQTg3akdsVThwZzdaaXlnaGtSYVpFdVFYU1cy?=
 =?utf-8?B?NUFraGRWam9CR2tEQXdZcFJBdHNvRDYxZ3gzMjNDSG93aktJSE4xMnQ5UHRo?=
 =?utf-8?B?MS9kOU1heG9FeU80V0JhSGtxNDNycmNwOERYOGtBVjVZS0FJdlA1Um9Gd1FU?=
 =?utf-8?B?MUNPb1pwQXpnV21oU2dOM3JPL1BkVGZJUHZTMUpuRXZDWTk3WWl2S2M1NHpW?=
 =?utf-8?B?YnUzY0dqU1pxWTdyVlZuNFBXL3JHOElJb0ppdDN3dFZiQWhBbVZnclRiQytK?=
 =?utf-8?B?bmRxTVBjdytjWUxmQWdiU0RwdUw4KzFaWThGZWtXTzlGZmlSNFluSkYyM3Vt?=
 =?utf-8?B?b0FGMGFZRStRRThVY2s2cm05YmFmV1RmcGpOUEhPUVBpREJTd3pXQU1CYTZy?=
 =?utf-8?B?MzRRSW5PQks1OHZTa1FxRDNtR0lyU1dZTENJV1BOczZId1FOOFJGZDkyeisr?=
 =?utf-8?B?SExaOXRqZWs2ajVCV2t6elErY3lPaUJUb2UxOXJZTXVTVXFwWmJWQkwrM1gy?=
 =?utf-8?B?OFFuT25oaklsRy9iK3F5ckJiTktzRHp3NW5NZHdkYUxqVGtXTHpCZk1rTkNx?=
 =?utf-8?B?RWNCazdyemdSQ2VEcTdzOGlHOXp6WnlLSVdWTXJpZFZGV1g4RWtscW1ocnV6?=
 =?utf-8?B?WDRPZ0FMdGI1YXp3aUtPdEppa1hJazhUYTcwc0dRcU4yWW9lL3ZQQ1JTZ2U5?=
 =?utf-8?B?TkVQVGlyVmYyWm12TWZDazlUVEw0Nm9hS0c3VktuNGY1bFM4MjVNZDRkT1FZ?=
 =?utf-8?B?WksyQ3grQ0ZmRUprMkkrSkJJdFYxSmRVMis0RlFhQ2MrS0FXbGdCblU5dHdt?=
 =?utf-8?Q?sBCnEcRBZIbnMRAG12Mzfbs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78869865-6d93-487c-affc-08d9b8bb5a31
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:21:46.2995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nxiw9JIRNn2J6st9JykPxv4pcUygCJ15jphYgnl6DLzmm7mblMfCcvKTmvZADtulNJ7zCQOFDZJNtJYrv/iVQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7024

1: tidy paging_mfn_is_dirty()
2: replace most mfn_valid() in log-dirty handling

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:24:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:24:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238893.414023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDz1-00084Y-Ng; Mon, 06 Dec 2021 13:24:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238893.414023; Mon, 06 Dec 2021 13:24:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDz1-00084R-K9; Mon, 06 Dec 2021 13:24:43 +0000
Received: by outflank-mailman (input) for mailman id 238893;
 Mon, 06 Dec 2021 13:24:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muDz0-000827-1A
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:24:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dd92eea2-5697-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:24:40 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-g_DZWoWMN5GqEvmL3CQEpQ-1; Mon, 06 Dec 2021 14:24:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:24:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:24:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0047.eurprd02.prod.outlook.com (2603:10a6:20b:3a::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 13:24:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dd92eea2-5697-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797079;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Wz5reFBIoDMHY6Wx6KZn6tzgyF4Qv4/Rr22OybwzF7k=;
	b=BlLaYDp9vNfYkTO9S8ImKADA/qKz6P0oO9tn0j0wDrcXwlFAHhWDnxf/SL+w6+DYJxzAJ5
	obPPYswB9By5kiYoIffJ45QqAtUXdaQ8XjNH3tTM/tnb+0LD7WwFyXiN5nJhTKgfx34FAC
	6H97ySInhqbEK1khFagZTBLOyQJDscg=
X-MC-Unique: g_DZWoWMN5GqEvmL3CQEpQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I2AGsXfHiYimp6XepQVG32upadsAedynS3GgX85EDl9qQssPGT2y06zMOxVDFbKo9GbTwZJSPriUfOV3rBY2Bc5FNC51TUMLtEiFJqhoLOGeu84QGs/y7bXVy99xqhn9lU2SLLkXwyo06LsCJ8dgXB9Jq744/JZbAnpsz7AFV1PsR9YbJ+aivsHWFlSZpbe2kay+F+Fchd5K2xLfZa4fbxIiQ9him5u6ea4n/cfSydCFE5D0RKQtY59GPrucfKKlVh8aFPsiFjzNY24B7HnZssQw9PnQZUtk73CqiH6/NSYLBECMeymk9w7Qks3LARn/2O9MJUqAeprzdKr3qYM1HA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wz5reFBIoDMHY6Wx6KZn6tzgyF4Qv4/Rr22OybwzF7k=;
 b=C1J32GxekkMnO1PGdnCnpBaF+Z0u06F7AnlN7UWD1QBZgY8LyGbErwiwX6CETVAM/sIf5m1q9rH9WXKK27m015lr4Z679J4n/ZQHcfqJfP5DJY96DKUvkr9SuMpUKtGkGIoYXofbGjmi/Im8Ek2CgdL97Kt+/AT9IS9YWbs3Dof9lP0nI/kExN3BCZALkgIWxxRneOoYth0wDB6i6qqq+riNtQ/CUu4FoHni6kwjjuXmD2evVH/3NckC94ehbYU9VEDoCT2/XjJ4rpfLR0xUDbG61qrdEideYyU5PH/U0MGZKxLsvQEUCaHbSKeDr+OO6/8A0dsUgxTfCyTS8iIhog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
Date: Mon, 6 Dec 2021 14:24:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] mini-os: support event channel 0 for console
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206124612.24758-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211206124612.24758-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0047.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b62ed72-d34c-449b-2600-08d9b8bbbf6a
X-MS-TrafficTypeDiagnostic: VI1PR04MB6176:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61765937BE47CC46B01DA6B0B36D9@VI1PR04MB6176.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/9pXj7xd3e+s/St+4XHNv+M4rgmPepHF56SQnqOBiAiJrYsxQtgSuyG7sIxS5gszsK0JjPfzkrgbDyZSrpAo5gxGAlmAlJ6lOxb8sjF82UXGafwoa+etNeMm/TI0lbx8X95EueTMrifpU1ewBzSs/Ub81ZhtcrJhNONhMakfy7xhmz1DdX41KlAYf8PaR2BEDSC0hTseURGYbabg0ENeq+Fbs5MP7XjHSUl4Y1/bUDyxYTAdr+x2LTi/+cpcAdCUBEzB1JA7Ojfn5oEpHii4m3SQwzjdF5bN1Oy2tm/Xhygt6VHp8/5RO69QqR3u3qDCdddDJg90IwScPIzWsRkuXL4dxsfKw05Ef6Cims/KZMDvY2LrW6jEOSZEVWR4W8AgN1POzJwSjcEMo4d7CRkarF+mXovRGaSbsaICCtKwE/8Uaa56yXxVdChXJTl+6jklcbhwRbhmO3oxvkz4aM3MmJV3gS4eRxwvl3Ojd3jah9z0Gx1b0CxY6lI2pYtVHJ/NlzOU639r6nY78d66l9u5j/dU/HYyx7lXPlhsIh89dggUysC+w2OnGZRAgFDp1VFJ0ph8hnei6SBK242RuFARmhUAz2CB0T5w5gaY+iYwxlQJoWs7FOd0gBaGYdPkqght5JcVHVNCt/k+rC4cZjLfwndsC+Km2lHxkvhXEfupYpqotjO61TMbaVhyNjjEagk+ONR0qUmS2whunv8zRo7K2+w8zuG1f1GyMtloaIzuTUi4DvCfrnWH4NbjlPyc5a8e
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(558084003)(86362001)(6636002)(6486002)(31686004)(508600001)(66556008)(2616005)(6862004)(38100700002)(66946007)(4326008)(66476007)(31696002)(8676002)(186003)(316002)(37006003)(16576012)(2906002)(26005)(5660300002)(36756003)(53546011)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UnYvVmJ0R0lOYS9Jb2J4RGdYSWd2amk5QVI5bHBaVE5Rcjl3djRNTzhmbllr?=
 =?utf-8?B?REJJWlAzZE5uSFNGRHBNUnltWXhYUnlNcjRiUVd5OGVyL1ZucXBPOGpLKysy?=
 =?utf-8?B?YjBwOGNPWjBRcmcxajF2eW1SM2YrSFFzWnQwSWlrMGs3bWZJL1NmVjRaTWxy?=
 =?utf-8?B?RzVId2NDY3p1MUZpT1VLOXlRS0dYNVRSTXA5WEIrNmFrZ2UzSm16azhpNHds?=
 =?utf-8?B?Z3dsTE5RL2VxUVVRMCtqcCszV3ZpWUVXeVZpK0IwRTJvOUExeGVmNDdsQnlw?=
 =?utf-8?B?M0Mzd3RrM1JDdjkrc2tqZlEzYlMvTWJuVzI2Rkl3NHJLQkFDTW5uVWhQL0Vm?=
 =?utf-8?B?OTlGY1FucUp6WDNiTEZjdVl4OHc1dGFueGZ1clVteGF2OFlWQnRGVllXaUJy?=
 =?utf-8?B?RWNaL0tZWTd4QkgxeGs4VkdGTS9vOGV6Y1VUSVkxMjhaTlI1bTEwS1lBdnZh?=
 =?utf-8?B?azd3OEY4cm5WWFRNYkpGWVVFTTlTODFaNkhoSkJZTWU0OUxmQ29XNUtaSm1F?=
 =?utf-8?B?b2duTlZiUHJXQzd3QXRaaEdzSHkwbTI3aUlScGZCRVJPa3g0elVXV1NLYlNP?=
 =?utf-8?B?RmdHNGlVNkJIWEhpS0gvUUhJN0czcDVqaHRQSFNobktCdGJ5eU5qVElKa3J0?=
 =?utf-8?B?L293aWptenovdE9mTlBocHhWcmRxQWZoNXpSZkxHNlplOENMMzBkZk9rQ0Ra?=
 =?utf-8?B?WE9Ldk1ubE9tZFh5cXJuRUpDU1RRUnlUNGg0VUZTWHBsM2IwWWlwUmgrVUZC?=
 =?utf-8?B?b0RES3NXb2tiN0xsNU9UUjlOdWZiVkE1NFRTcnN5UCs0dTBLYkRJanpidmpE?=
 =?utf-8?B?RGZxUnFuT1phRUk3UCsycklUY3JMWkcvSkU1VmNrbjdmMmc1ektOSmNFNkUw?=
 =?utf-8?B?SUxwVUtRc3FmUmJ0d0dOZlFXK3VUOUthUlIzWjZkQjI2bnpQaEZrL2s5NWM5?=
 =?utf-8?B?ZWNUSEFVRFdmRUZTc25NdWVtVDNxeWNmRStuVnJ1WktIRGZ0Z0h1TWVRSUly?=
 =?utf-8?B?Qm1PMDdPQ1lEdmwvUVhkNnh2Nm9sSDlmUnhIK01QOWEyMERIMURqN3d6WHJN?=
 =?utf-8?B?dGJNWFdtbFo2aDlxZGJrdCtSTDA5L3VnZ09ydGc2cXFJZ1dTa1E5VUN5QzVp?=
 =?utf-8?B?VDBSWnh2OEhaRXZLRjYwVjdxRktHMDJ1Y3RzQVh4eFFLNmYvdmVXQWY4bTdp?=
 =?utf-8?B?eDgwdlZLWDl3WThGSWNXcXorRThnM3Q1OHVmVkVVcjNNRUFkT3BvSllSdENw?=
 =?utf-8?B?OFhzdVgybjFpZEhpeUdLR2pVR2cwZ0M0QzgvTmUwTUNUcmk0L0FzdlJueW41?=
 =?utf-8?B?L3U2dTZ6eS9OQlN1MVYwbmFSN3BaUE1pSWpsSHJwM0kvN3U2T3BtMktNeGdZ?=
 =?utf-8?B?OEI4Q2cwWTBVTFpqSjdMcWkzcENPTmJVSkxqeUo3YXV6QWZDSVYxVDBNdDRx?=
 =?utf-8?B?ZnBQSWw3V0t4d0k0Vm8zYzFvVG4xUE0zT3JuZkJPZ3FJSFVJL3V4bWdXQ1BZ?=
 =?utf-8?B?blBoRHdkOExWQk42T1V4cUZ1WXlJcTVMalB4dWhhS1R3dFQrT05TelI4SGRz?=
 =?utf-8?B?SlExekFRU0NyMTZHdWZJamJEdzduK0pZQ3EvZUU5NHdkMFhRQlpwQkU3R1pH?=
 =?utf-8?B?amRqTmJnckcwc0NqcWxQK0tzbUZPZnZOYlNIL3NOQWRZbDFWK3o5WnI5V2JZ?=
 =?utf-8?B?elY5SjZtN0ZuTVp5U01sbWU4Y0FLUTRGWUNVREZlc0ZSR1VPQkorQm14WWhk?=
 =?utf-8?B?djN1SjI0TW91TEVrQ1d0SmZlTlJ0UFZERUdMWUJLTTU2U2dZd3M5Y0IybkQr?=
 =?utf-8?B?YnlabnZYUnlRdzlEL2JDWjlVemhGMGxnbnVMWGw1aGFTSEJwM21LRmdKYW9a?=
 =?utf-8?B?M24xR1pwN3dMN3ZXU0tVbmMzMllCV29kNFdkSS92U2VXWHE5VVlyUXJsUzAx?=
 =?utf-8?B?ZE12czhWMlBHa21veTMvQzZWMW5IMWtLVFU0YU9UemhSaGRhM2ljTUZ5dVFn?=
 =?utf-8?B?VzRlNGs4N045b21kcGlDa2VTVC9jZGNIcnJ6dHhlemVHbS9xVEJRaGlvaU5R?=
 =?utf-8?B?b1dJenhmK1IvU0hGVDllR0JuOVhnaWt5ZUVFUUhCNUNpa3NKY2I3Nnh2d1N1?=
 =?utf-8?B?Z20zWHFOdU9lS1N2aUxtUDAzSGtRa00xWXJQeGtJSHVSdWF5RDQyUUJ6eHJV?=
 =?utf-8?Q?T9pqZ6HvRbHPhlWgc0Zd1ME=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b62ed72-d34c-449b-2600-08d9b8bbbf6a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:24:36.1514
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QA2ZKKsLHFGecx1rAEH3Jtz2mrlGPa1mzNaXifp79f2xAd3tCJHikA9hLHizlKbFcpvLqjeF1iEKJz+yyfZYLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176

On 06.12.2021 13:46, Juergen Gross wrote:
> The console event channel might be 0 for the console, so use the value
> of ~0 as invalid instead.

I may be missing something mini-os specific here, but in Xen channel 0
is always invalid. It's not just here that this value would be used as
a sentinel.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:25:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:25:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238897.414034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDzc-0000Cq-0p; Mon, 06 Dec 2021 13:25:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238897.414034; Mon, 06 Dec 2021 13:25:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDzb-0000Ch-TY; Mon, 06 Dec 2021 13:25:19 +0000
Received: by outflank-mailman (input) for mailman id 238897;
 Mon, 06 Dec 2021 13:25:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muDza-00006G-2D
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:25:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3c4364a-5697-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:25:17 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-v5fdYRZ4OUu7QHgtNCUuHQ-1; Mon, 06 Dec 2021 14:25:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7024.eurprd04.prod.outlook.com (2603:10a6:800:124::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:25:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:25:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0202CA0069.eurprd02.prod.outlook.com (2603:10a6:20b:3a::46) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Mon, 6 Dec 2021 13:25:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3c4364a-5697-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797117;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qEsj9ndE9Q/guZXie3VtZKqzHbg+waaXmZENccFoZSo=;
	b=YQGjFPuf4p5k0i5fn5Yv6hFI9zSpAoOuAoaxMCHSO7N+pVY+HjIkN4p194yWTxj+IsaQBw
	HlGwyQvQD8+u1LJq8tXMyuNy1meEQt3kKfy81OnNOp17kUJAbKIP5PlXOPnswtVfCGUcYZ
	g22KU21wcHFtSYbPpwlLtEc8i5oitEI=
X-MC-Unique: v5fdYRZ4OUu7QHgtNCUuHQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VUvRpZEW59XVzwhyslnO8WMGV104htmC65eSt+/sZGCNVoMDEJJ+ADgQwU63E1VUCjQHMEFbkmNGf5SxZoWjM0zLeLYuMinikRnvobyE0PB2klH+DTqyf8LX9pmd3udmxXNzNYKJBSgPM5SM/w18xtk0GCJYv7S+O6K49WGWH0LZd0CVp0GY5+K+xtxDzpw769dcRQtDVQ3qi+LSq7Csdd0UZjZG3LocsCfE6CrwjXzPCpy2f8y4H1+XbOMgDamUgr0aWvyl0vqv3+/hbBoZetdLa4cxwVdMZKPSxzOdJkaESez/rm4vbM2J46IkQgM5ifsvGyPZFUGzFS2JopUYbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qEsj9ndE9Q/guZXie3VtZKqzHbg+waaXmZENccFoZSo=;
 b=PvTXyMEY94dkfTY9uovKoxq62fORdCvx27G2ztMFZkpuBpjUAEzQDkX0Ky2Nxha971Ze0bJM1xzdoV6XLqAs19APak7EpDUU07rYTuB/EC2G54kDnNmoZkfFpqnKViLh36R0mGpb0RUKKha4ZQx2TTNhXdnmiZn/C3QkfUGKc/xxxL+LGQFfWAYcLaDqaf683snquApwfhEBNmuZK5lceSQsgcGiepmBmZNyTZZV/RujcLLa6mHbrpeEjAVp9QrbsbsKzH2z5y6pfsColqCSAB25jlunIF4yvVtrY95ryOd26LZ+LgR5hegkzRAA0bX7hvtyZBitPqgBF/0+ranC6Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aa49dc63-965a-bf9b-3d42-11286b709a24@suse.com>
Date: Mon, 6 Dec 2021 14:25:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 1/2] x86/paging: tidy paging_mfn_is_dirty()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <61c1d38c-65a6-e150-ed53-b565d30c18c9@suse.com>
In-Reply-To: <61c1d38c-65a6-e150-ed53-b565d30c18c9@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0202CA0069.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3785d258-9018-437f-83f8-08d9b8bbd6c4
X-MS-TrafficTypeDiagnostic: VI1PR04MB7024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70249C3E45EC0872E3283A15B36D9@VI1PR04MB7024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1ZPPKKrEaDGXpCFmOQdam3nCEmK5iyDKzROmE+B2LuaZKnPdHJ+byW0fxA1L8pCCHL2avmAZB1kX4yAnpK3FEWJ1tBohFkCqiiKzUJyauTOkKaWd0UUwXbRMucJVtRBMbtraNOPqNJ2irzIZXrYDeYefBRkTZ0wycfp2SUOIkPpUK+SfkexH9fsDYz3Sp8+IkD39NH9GdnRIpCRtKbRkkqFHfK09LNFqQVwzKLCtxHmW+yW4YsVY8cn71JUhdXrFtl9rkKhIlZbyHw0Us1h8JvuBaHcAGSioXtUrnvGz8KGpHg1wtlKZWxHE9EzVG89F44R/MwCotO10S0xF+xSHo2yEqEtRMknqvHrjyCyadZDGot6wGGpKUNH7M3/baC/9+K2OPxMIuqo31vgJi1RgbcWjTylmu1TRhP6pi2pq8T5mRMSoQAr64U6VFSrmbJ3HJ90AmAQA57pnpEbAbRhQxZpwxzTp+RU3KUyAFqNqFNZnmbO+udynj7clyOFIcfIh+iuK4/mQv4K7Ruk5ElNfBn6giKh9irUrZjJReTvsmNgE0qKvlUJ85AFl3scl0fcyQsLtKlVbxg21RTGoD2AVxMSJcJYzDFwLfi3YV2IXN0EQAf6fsSO7jsdHAJEeLpuNvAHginbYPxeeMN1D/aQcJtDOUl3EeJ85g53eq3Mzu9Vyq2DKaz7w3w+HASdhNymHTe7Rn1eN+DdPqZWDblsQt9/p8gd0uwMCsGSjokZug4TtSf2zYqYmwAKufmolf2qR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(6486002)(2906002)(86362001)(31686004)(186003)(36756003)(4326008)(31696002)(54906003)(16576012)(316002)(83380400001)(66946007)(66556008)(38100700002)(66476007)(8676002)(6916009)(508600001)(8936002)(26005)(2616005)(956004)(14143004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2tJRW0vNm5lekcwVGpLcnczOW1ZN1U4cWkxL2xWckdEUVRGc29HcFZkbkVF?=
 =?utf-8?B?RzVjTEdKQldFTXc5RnBUdjB6KytKd0dzbzBJY2xkaU5KcWNFNnRLTlg0M1NV?=
 =?utf-8?B?MVg0YlZyT0lXaFhaZ0pFQ1dYRnk3aExnUk12NFkxUXRMZUliMDVrUjZqdWNL?=
 =?utf-8?B?b0tYYjdjM05NVkN1QTJJbkJiSjkvcU1uQUZQL2hiS3BLZ0lCMWRoSll2K0Ju?=
 =?utf-8?B?K1RqVlByOUs4eVNvVHJTbTlOY0FxVXp2TmJFdnU1Tkc0ZE9ZYngwa3dkTFN4?=
 =?utf-8?B?RjBXOVlreml4TkNRYUVkREx3a0V6Wmpodzd5bVY3QTUrTktXRWtraWJzd3ZT?=
 =?utf-8?B?OVMxUkVDOGZTU050TUVOS0pJL20rL0kvOXFrQTAyVGE5Z09ZMDIvdEFLak93?=
 =?utf-8?B?RmczV1ZqY1hNcHRwN3JzL2lRSFVSSVk3anV2NGZMQ2ZibmV1emFDMEVrNSt5?=
 =?utf-8?B?Y3ZWOU9KbHBrYnZnRzVCMS9TbUlTTmFwL0NzQmhiVzVBblNTVWZjcDBTa1Ns?=
 =?utf-8?B?KzNJZ1dXZVNxUWV4VVIzUTdQRmh4dXlpOUhiVTd2QnlIZ1hYWU1WM2ZaVW9L?=
 =?utf-8?B?UXgrRmlmQU8rbWorVWhXY1cwWkh6VUp0OHptWEhoNUt6djlFSXZrQ3ZseTE1?=
 =?utf-8?B?THo0aGxPbllqRFBVSlBmOTlCVHYrQ1ZIMU1BVllxSi9BdFV1cVF2WXIvTklO?=
 =?utf-8?B?TTRZdUhscitJQS9BRWNVTk5qeFhzUnlrNjNvcXVvZXVWZ1Z5MjNaWFdOSE1r?=
 =?utf-8?B?Z2NESmpJbVo0V29DT1lWWklqWUFsUEszcXZBcmRwb3RTVEhYbW5IM3JROGsx?=
 =?utf-8?B?aklFYjIxRHNRci9aQXhPR3JtbXlSL3hwNUNvYUVYWHJuR2lWdmVWWlhla09u?=
 =?utf-8?B?dlNvcVZjcVdnb1JzYyt0WnZES2gxczk4WFVjR2tzbDF0dDNZM3RnbWdDTjdi?=
 =?utf-8?B?Wlh4TFRrdy81dW1sT3VmQlRoYTVJVTZTUHJWMVJBbS9ZNzVWL092MDdrVmFM?=
 =?utf-8?B?Tkh5b2s3dndUWVNmdFdsblQ4OHFlT3JEKzdUblVwMEs1dXJjTE1sR3NxL1lX?=
 =?utf-8?B?elFuOHlNQ1FxYW45aUl6d0UyaFkwNVNHZDhtZUc3MFUrQmlLNHVDV2RDS2lZ?=
 =?utf-8?B?M1Zxa2ZyR05pc0ZXM3BsRVZZSWl4cDhNcHVua2hNOEgyL1ZsOTVQZXFxcWNL?=
 =?utf-8?B?Yis5bWZRbmFtUDRrbEZ4VFpSUTZUcko1L2VOV3ovMm1tMk9hazhvNUNzNlZl?=
 =?utf-8?B?azVicENRWTRqcmc3U0FkU3dQeUM3YWprd2RIclJLdGR5SGpqWlo0VDhQYm5L?=
 =?utf-8?B?SngwZU5ZUjBZNi9kbDBBTVFqWkx4QjBBN0E5ZzN1N2tIblhrMnBnaGc4RUZH?=
 =?utf-8?B?SzN1OFlYUEhSNlZCMnFqTmdtdFp5THJNMkMzMUFWdzhKS2N2Rnphei96Wm5G?=
 =?utf-8?B?Wmh5Z2hjSURTc2MrUFdHTzZQZHlHbXE2S2xqK3d6R1VKdTdsNGhLbE5FR2U4?=
 =?utf-8?B?RUdBeFFWNWsyN0Y2UWRXWFBGM1J3TUV6S0I2WncrSVpob2grTDNyeUwvS1BU?=
 =?utf-8?B?Nm5sMHp2b1o5RXp5a1F0UERFRXZzcG9ZRG9JNGQ3b1lQaDFYWXVSL2txS1FM?=
 =?utf-8?B?czZRVWdmOE5FT1VVUVlnbFhLNVFpYWNrOGVUSEozY2tEMVN0TFIydDNhK1pP?=
 =?utf-8?B?clRrL1ZnUGdLVFh6a3FOYno4cUgvZVBNQ0RmOWk1Yi9RVUJCS29tdEF2K2lH?=
 =?utf-8?B?c2F6NU11aUM2Mnhsblp2Mk1DdkVzYk1XMVY3a2VlSlNlVmlvN1NCcWhIQ2ZU?=
 =?utf-8?B?c283b2VFTEZwNDJTaDBJRFJXUWd6cFVreVFYSFR4UjNBTk0zL0c1K2lVbll4?=
 =?utf-8?B?RmpqemNMK3ZNd1hCSHpwemM4YklwY0YzUHFzQUtEL3FyRzJpWWlSWDZrQ1BH?=
 =?utf-8?B?ck4yTllPMnlNMFVwTDdMeS82dG9WdXpYcmZYQnd2R0hIbDN1RnhpY1orWjBY?=
 =?utf-8?B?U0dmUkR0eWtFK3d4VklyMk9pT2JuRU5mZ3M1NGxybDFTWnF4RnY5OElIT0oy?=
 =?utf-8?B?c1hRZ3NmOWtFUFRUS25KMng4aHYwMWRZbTZnVmtWek1hTS9CNzNpWFBhOUx6?=
 =?utf-8?B?R2MxemZnQmIyV2ZOc3IwZWxLQWlacUUvMFMwa0xkOWNBRHRKVHBjOUNUOXdh?=
 =?utf-8?Q?Cq8rdZksaGGSEZq0jBpnDIY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3785d258-9018-437f-83f8-08d9b8bbd6c4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:25:15.3013
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sqIFL8fd6X1r+EElkR4K+8mzfZ1GOQDL1JwIeihL9scjbNA8Voy49iA8J3vIuCBmrY79AKUd36w11ArWU6pLHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7024

The function returning a boolean indicator, make it return bool. Also
constify its struct domain parameter, albeit requiring to also adjust
mm_locked_by_me(). Furthermore the function is used by shadow code only.

Since mm_locked_by_me() needs touching anyway, also switch its return
type to bool.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Change return type of mm_locked_by_me().

--- a/xen/arch/x86/mm/mm-locks.h
+++ b/xen/arch/x86/mm/mm-locks.h
@@ -40,7 +40,7 @@ static inline void mm_lock_init(mm_lock_
     l->unlock_level = 0;
 }
 
-static inline int mm_locked_by_me(mm_lock_t *l)
+static inline bool mm_locked_by_me(const mm_lock_t *l)
 {
     return (l->lock.recurse_cpu == current->processor);
 }
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -351,14 +351,14 @@ void paging_mark_dirty(struct domain *d,
     paging_mark_pfn_dirty(d, pfn);
 }
 
-
+#ifdef CONFIG_SHADOW_PAGING
 /* Is this guest page dirty? */
-int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn)
+bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn)
 {
     pfn_t pfn;
     mfn_t mfn, *l4, *l3, *l2;
     unsigned long *l1;
-    int rv;
+    bool dirty;
 
     ASSERT(paging_locked_by_me(d));
     ASSERT(paging_mode_log_dirty(d));
@@ -367,36 +367,37 @@ int paging_mfn_is_dirty(struct domain *d
     pfn = _pfn(get_gpfn_from_mfn(mfn_x(gmfn)));
     /* Invalid pages can't be dirty. */
     if ( unlikely(!VALID_M2P(pfn_x(pfn))) )
-        return 0;
+        return false;
 
     mfn = d->arch.paging.log_dirty.top;
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l4 = map_domain_page(mfn);
     mfn = l4[L4_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l4);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l3 = map_domain_page(mfn);
     mfn = l3[L3_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l3);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l2 = map_domain_page(mfn);
     mfn = l2[L2_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l2);
     if ( !mfn_valid(mfn) )
-        return 0;
+        return false;
 
     l1 = map_domain_page(mfn);
-    rv = test_bit(L1_LOGDIRTY_IDX(pfn), l1);
+    dirty = test_bit(L1_LOGDIRTY_IDX(pfn), l1);
     unmap_domain_page(l1);
-    return rv;
-}
 
+    return dirty;
+}
+#endif
 
 /* Read a domain's log-dirty bitmap and stats.  If the operation is a CLEAN,
  * clear the bitmap and stats as well. */
--- a/xen/include/asm-x86/paging.h
+++ b/xen/include/asm-x86/paging.h
@@ -173,7 +173,7 @@ void paging_mark_pfn_dirty(struct domain
 
 /* is this guest page dirty? 
  * This is called from inside paging code, with the paging lock held. */
-int paging_mfn_is_dirty(struct domain *d, mfn_t gmfn);
+bool paging_mfn_is_dirty(const struct domain *d, mfn_t gmfn);
 
 /*
  * Log-dirty radix tree indexing:



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:25:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:25:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238900.414045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDzx-0000jB-Ds; Mon, 06 Dec 2021 13:25:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238900.414045; Mon, 06 Dec 2021 13:25:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muDzx-0000j2-Aa; Mon, 06 Dec 2021 13:25:41 +0000
Received: by outflank-mailman (input) for mailman id 238900;
 Mon, 06 Dec 2021 13:25:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muDzv-0000iL-QU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:25:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 007edb62-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:25:38 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-NzfYniWuOsyPEm1yDV4NTw-1; Mon, 06 Dec 2021 14:25:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:25:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:25:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 13:25:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 007edb62-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797138;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6gE0gFOUnMMz5JyRTUC/L9rSE2loRh2H07DZe6ZHJT0=;
	b=cDx9psvM1o531StI9NxrEojqhQh4KCf9pt2EX9Fnfk7SYXXbbCupuo0dV+vPhS6HvaBtOu
	XkufHmmnR5rpDBDnnLHQIVx7Y7Us9l60Du3wnzqQpKPiw7BB6zuVyVsa+Zc1V5RRTQBytn
	L8ok7+BMdlnt+45hvmXyptAlT9+XVvQ=
X-MC-Unique: NzfYniWuOsyPEm1yDV4NTw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kYXd/9OAYsq7kQVzWjWRcc3CDz1grDcbXCpknTmUpl17SaGVJshsZeTavCOCmGDMNe30as1GZugtnEgc7iTJFQMRH0CudLrx/KMpTY7oreZWwIQJUaRk9Rnw2USqRUKU2GSpBrfquVsz+dHs2aAmX5JIKuL95S4keTvyDTU78l0WSqA8auEg9BT11N8+JFZKcey0UGkiIefOIbcx95koMdWVyC3HHLvasR8z4NuFUC+wa9TsgGQQmqreMAw8zdmd7YTMGGQkvoSsV8pxy0N0MKMDF+blFTMYAqMRJsmmk0lhPh0vI7VVUmzQ7fy/roLGcEokSw4oFKjAzLDCt0xXtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6gE0gFOUnMMz5JyRTUC/L9rSE2loRh2H07DZe6ZHJT0=;
 b=D+HCphIiP77AqoxzaIgPIvGsxTTaIbFtrkggcLQe9Gx9CWIkYyeIFSbDafgv+uSy4DoqzdG+cpX0hzrmL6P10Fuf3mCbyIQe8IYrOmxrvCeRqROHLR+RJ+CHw1ewkeXpc2qiKnu6sOhJ/cJjyoeZrs0/tX08T16JK6zpRO/w+f2Ca77Eh4kGe+IczDb/OZcaOBko3dgS+uu6Nl09jhzNTkAqzdNH0kYPeTwHrwQKFyAFpbnLzGlIqqIUJYj79yDucx/A86SaYs42FzuMZSPYjzPCG2SM7bYBc8WTUoHN+KGXLDNKsbG4EbfO4hFJc+fSYj/s7kmdsahswgwQTH6IGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fe8a690e-9305-c512-9d2f-4256c5c9b910@suse.com>
Date: Mon, 6 Dec 2021 14:25:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 2/2] x86/paging: replace most mfn_valid() in log-dirty
 handling
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>
References: <61c1d38c-65a6-e150-ed53-b565d30c18c9@suse.com>
In-Reply-To: <61c1d38c-65a6-e150-ed53-b565d30c18c9@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d1bee3bb-4837-4d16-995b-08d9b8bbe368
X-MS-TrafficTypeDiagnostic: VI1PR04MB6176:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61764BD7F6232A80E256C090B36D9@VI1PR04MB6176.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:243;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/fuYhG/LT1tcpXo9PFYUHZUEbKl9lzXxVYUt1CwPGjFN+EbhqLQ1nSrLwwRYcEEICUzz26E9JcIx8jL+gBoT2SUfmS/hzKs/qvhEM93r23Bz+nHNj0c12UxJaeKxtH3cQo2nfc9fbzy3au2NWhhF37s/omOzvy/QTW/FEG6Ciy4V04nV/RiNTZehOCdjKF4cnhHwGblzv8Umpy+XpU5GDWhlGkG7LUss1Sdw9d9ocBUo7KEDTlqeOHvJ/wG5E8Af12cmAcZKC2IiKJEz4aMH2WRNghUe7foMFlXGr5z1Pur108N4PtsSO0Ywnyl7rR1iS+BBZ2EMOy9pnUstTgsdc/qTERc4unXIAPRwD0udy6yTnwx09DklP9qKBQhxlP6UixPqlho4LZd9ZlxObVnF8h6egqlEXRxezym9RdpKoIB8De3j5OaYRyxtr5BUWSg8oM06cxLQe9tmvPm/qi/0KnJgL2/sFwb1ZtWNiNfDASwXuwSYyOM/qIHGVYPpUoZvWhcLYxTcXhhgyEqTuAcaQvlCP1zoURsqbvxlpyPBI3g+wMLAh2jA5UXqpWYjjuERJugPTsqQbk3nmwG3ZF4tt9hRxjSRW/dudMcfNUAku4l8+6J37iaSTnWEOaAdJ130lkyQ5OmWUmgT7M6qJhWa35j0RoYYFY/r4taLBD1gi+SW4OT+dGsz9kAfG067cr8LmjlzFZJ5Lvrmrf4Kq1IMIZB67NAJ9jvb8/f2Q88Im3hFrG5Y4HQTKdpesaI2S5q+KVSfoEqCzc4T2yl421kWKQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(86362001)(6486002)(6916009)(31686004)(508600001)(66556008)(2616005)(38100700002)(66946007)(4326008)(66476007)(54906003)(31696002)(8676002)(83380400001)(186003)(316002)(16576012)(2906002)(26005)(5660300002)(36756003)(8936002)(14143004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cnBrdXQyR0xRa2RGNXJuR09sRWhDMEhNbmYydUczTm1kRFdkY21TTjFWZWZT?=
 =?utf-8?B?UmpGeW8vMkwxeEd2ZHR1M2hod0J3bWxXVmtEYm9YWWVVM280bVZVaXVNSUt5?=
 =?utf-8?B?OFZLRXh6L25XTC8xWXBmZzhkUHl6OEpQK1ZMbUk3MytKWThzSytoYXpJaHZB?=
 =?utf-8?B?S0R1eGswUEV3YlJPa3ZLNlRWTjVKUXh4ZFVQcXVyNFJtcDVpSTVHby9vS3pr?=
 =?utf-8?B?YWNXa2ZLWEh1VDczZ09qWWR6Unc4T09ONlFnOEgraGNkVEtMVVV3QzI1bFps?=
 =?utf-8?B?dG5pWlRWV0pxYUlCTkZvRW9yQmwvWmFtMUVOQ1NEdUxDSWtPZHBhdjVSU2tw?=
 =?utf-8?B?RmF0MlNGWFoyWDVTeC9FK1BZeFZWbEpHaFNTVnhsSUgxMUhnWE11RnBxQ3JF?=
 =?utf-8?B?NUlKV3h4WllXVDJlRVJRT1dkUVlITUowaFY4Q0pqSjVua0g4UWFQNmtlSnBh?=
 =?utf-8?B?SWtlSmRLdVhBem5wU0h3YjBDbXBIRmR6a0xqR2p6YXVNQm5vcHBleUoybkZC?=
 =?utf-8?B?VENaUWdETGhLVytETEJzSGxPZHp4K2VuZ3R2UlppaHNvYTRJTWtwdEF6NjlW?=
 =?utf-8?B?N0trSTlqdG5FUGsraExUcDFVd2JnSElEUzdqRWF6K3JSOVNoVzVUYXd3UGFW?=
 =?utf-8?B?d21XWkR3aStDZ3RnSHdqU0RPb05GcFdSREw3N09LczB6aWF1TEJuMW16eHkw?=
 =?utf-8?B?Z0NNbUJ3Rnc4Q2hLc0dlLzdsN2RjYlBRZzQyR2dUSW1vOWxXVllYQVNtVWxE?=
 =?utf-8?B?cFhsbDBEdjZQeVVjeUpQU2p1aklRY1l3Qy9Ea1hBbmVHbk1nUTg0Q1Fhdjg0?=
 =?utf-8?B?UTA0RFczd3ZnbUlPNHNKRFdWcWhZbGNDYWc2dDNFRWZWT1ExbWJpTUNtNU8r?=
 =?utf-8?B?VmllcjZPS1hEYVJKNzNod3NPZDIyVU16bks4UnNBWU00YmJ0cWVzeXN3RWZI?=
 =?utf-8?B?SnRkcG1PSTFOa2dKaHdLb205clVYL05RNTBpT1FiOEZ1Z3o3RERxQnZQMjZt?=
 =?utf-8?B?eEpld0NHTFlhUlE4RVdNKzM1czNkUzc4LzRTL013QjExZ2xaMnVqeWZZUjFz?=
 =?utf-8?B?N0c4b2w1c2FWMjJmRXNxZStlNzZZbXdSZ1NUSU9oZEN4djhyN21HZGlScDk2?=
 =?utf-8?B?YnQ0TjExY3oxNHV5Qld5eEo5R25ZMXE2d1ZxWmQ2TGU3TlBRVWxmeDJrV0Rl?=
 =?utf-8?B?dzVaWFBybm9aQXF2bTRxY2FIbHdQRFNpQytMemRVeVpQYkFuNm1yc1RmaFhh?=
 =?utf-8?B?ai83VmV2RVZKMFZFbVoyUks0NEcyOE5VWlh2QlhzMHU1cCtRQVNhVERWcmdS?=
 =?utf-8?B?Z25jdEp1U1ZlaUZaU0x4dkMzN2RhL1NDSExXVEFlSXBENVlUYkxJOVZmUS85?=
 =?utf-8?B?SUUydDJINWcrM3lZNW1JQnRHd09sWTU5alREdkhSSWtwNDhjbUk1T0VkT28r?=
 =?utf-8?B?MlZ6b2U5eHE3cytjWjBwMlBWYzB3VTMyZlJRSGxaYWYxVVJUTXhZL1FvZi85?=
 =?utf-8?B?eVhRSHR2QldvZXdLTCtOZm5OU1VVbU1uNmMxMDBYR1hRUUlNOVdEZmhMMTA2?=
 =?utf-8?B?SGRCZjZBRGJ2bU16dS9kMzQ1bjR4azJpbTUxUEhoeDRqMEVYWFpqVVE2aFJ0?=
 =?utf-8?B?WkZDdWsvWnRpaTZpVjl2TVNDa0ZxVlZwRVVkZzZLMzVTVkdUTnBBZTAxVFZX?=
 =?utf-8?B?R3ZSV0JTVnZKY014SEpyVXpibkZqN2t6blk0Y0p3ZW5BaStFVkIzQ0pHODdz?=
 =?utf-8?B?UlIrNDl3QzBvQlZ5SDR0L0k2UW93Q2VyczczRUtDR09Kc0Y4SkdscGlibGEw?=
 =?utf-8?B?VVh0V2dRTUFFQjhkTlM4NXlIUG1jdmMvY3pNMUM0NXYyaitBbUora2RpZWE1?=
 =?utf-8?B?aVg4M2pUMFR4MFY3OUlkYmRMdFE4cWNVbU9ZcHhlTUZUdlM5YnczVUExbjZW?=
 =?utf-8?B?VFhBM0IxUXcxSmNDTmVSelF5UWpXNDdMVTBjUjdUbW42OCtValA5QzNON2tq?=
 =?utf-8?B?YlhwbWV6cFRFbWZ4NVBYY000RFhDTmt0SmFRWkNaeTFmeHBYUjVlamprdUZ0?=
 =?utf-8?B?STlZOU96REtPb0puQmV2d1hLeHVsaU4xa3NxZ0tieTBRTGZldUcvU0I0SklN?=
 =?utf-8?B?YXpmdjI4cFN2dnRRVGpyRFFYZm4xdFNMK2JPbXRkTGViNE14STZneXZCMSsx?=
 =?utf-8?Q?uePtL/meDc0PWzMZjoH17ro=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1bee3bb-4837-4d16-995b-08d9b8bbe368
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:25:36.4473
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NRNmn+2DA8uNRsTNpn2FP24qwh5oefY++JtlnzcwRi2+hmYCZRi2KmmSOdUc1LvZr5rvRgIxiz44ySKcjWTDvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176

Top level table and intermediate table entries get explicitly set to
INVALID_MFN when un-allocated. There's therefore no need to use the more
expensive mfn_valid() when checking for that sentinel.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -74,7 +74,7 @@ static mfn_t paging_new_log_dirty_leaf(s
 {
     mfn_t mfn = paging_new_log_dirty_page(d);
 
-    if ( mfn_valid(mfn) )
+    if ( !mfn_eq(mfn, INVALID_MFN) )
         clear_domain_page(mfn);
 
     return mfn;
@@ -84,7 +84,8 @@ static mfn_t paging_new_log_dirty_leaf(s
 static mfn_t paging_new_log_dirty_node(struct domain *d)
 {
     mfn_t mfn = paging_new_log_dirty_page(d);
-    if ( mfn_valid(mfn) )
+
+    if ( !mfn_eq(mfn, INVALID_MFN) )
     {
         int i;
         mfn_t *node = map_domain_page(mfn);
@@ -98,7 +99,7 @@ static mfn_t paging_new_log_dirty_node(s
 /* get the top of the log-dirty bitmap trie */
 static mfn_t *paging_map_log_dirty_bitmap(struct domain *d)
 {
-    if ( likely(mfn_valid(d->arch.paging.log_dirty.top)) )
+    if ( likely(!mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN)) )
         return map_domain_page(d->arch.paging.log_dirty.top);
     return NULL;
 }
@@ -116,7 +117,7 @@ static int paging_free_log_dirty_bitmap(
 
     paging_lock(d);
 
-    if ( !mfn_valid(d->arch.paging.log_dirty.top) )
+    if ( mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN) )
     {
         paging_unlock(d);
         return 0;
@@ -143,20 +144,20 @@ static int paging_free_log_dirty_bitmap(
 
     for ( ; i4 < LOGDIRTY_NODE_ENTRIES; i4++, i3 = 0 )
     {
-        if ( !mfn_valid(l4[i4]) )
+        if ( mfn_eq(l4[i4], INVALID_MFN) )
             continue;
 
         l3 = map_domain_page(l4[i4]);
 
         for ( ; i3 < LOGDIRTY_NODE_ENTRIES; i3++ )
         {
-            if ( !mfn_valid(l3[i3]) )
+            if ( mfn_eq(l3[i3], INVALID_MFN) )
                 continue;
 
             l2 = map_domain_page(l3[i3]);
 
             for ( i2 = 0; i2 < LOGDIRTY_NODE_ENTRIES; i2++ )
-                if ( mfn_valid(l2[i2]) )
+                if ( !mfn_eq(l2[i2], INVALID_MFN) )
                     paging_free_log_dirty_page(d, l2[i2]);
 
             unmap_domain_page(l2);
@@ -288,35 +289,35 @@ void paging_mark_pfn_dirty(struct domain
     /* Recursive: this is called from inside the shadow code */
     paging_lock_recursive(d);
 
-    if ( unlikely(!mfn_valid(d->arch.paging.log_dirty.top)) ) 
+    if ( unlikely(mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN)) )
     {
          d->arch.paging.log_dirty.top = paging_new_log_dirty_node(d);
-         if ( unlikely(!mfn_valid(d->arch.paging.log_dirty.top)) )
+         if ( unlikely(mfn_eq(d->arch.paging.log_dirty.top, INVALID_MFN)) )
              goto out;
     }
 
     l4 = paging_map_log_dirty_bitmap(d);
     mfn = l4[i4];
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         l4[i4] = mfn = paging_new_log_dirty_node(d);
     unmap_domain_page(l4);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         goto out;
 
     l3 = map_domain_page(mfn);
     mfn = l3[i3];
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         l3[i3] = mfn = paging_new_log_dirty_node(d);
     unmap_domain_page(l3);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         goto out;
 
     l2 = map_domain_page(mfn);
     mfn = l2[i2];
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         l2[i2] = mfn = paging_new_log_dirty_leaf(d);
     unmap_domain_page(l2);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         goto out;
 
     l1 = map_domain_page(mfn);
@@ -370,25 +371,25 @@ bool paging_mfn_is_dirty(const struct do
         return false;
 
     mfn = d->arch.paging.log_dirty.top;
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         return false;
 
     l4 = map_domain_page(mfn);
     mfn = l4[L4_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l4);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         return false;
 
     l3 = map_domain_page(mfn);
     mfn = l3[L3_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l3);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         return false;
 
     l2 = map_domain_page(mfn);
     mfn = l2[L2_LOGDIRTY_IDX(pfn)];
     unmap_domain_page(l2);
-    if ( !mfn_valid(mfn) )
+    if ( mfn_eq(mfn, INVALID_MFN) )
         return false;
 
     l1 = map_domain_page(mfn);
@@ -477,17 +478,18 @@ static int paging_log_dirty_op(struct do
 
     for ( ; (pages < sc->pages) && (i4 < LOGDIRTY_NODE_ENTRIES); i4++, i3 = 0 )
     {
-        l3 = (l4 && mfn_valid(l4[i4])) ? map_domain_page(l4[i4]) : NULL;
+        l3 = ((l4 && !mfn_eq(l4[i4], INVALID_MFN)) ?
+              map_domain_page(l4[i4]) : NULL);
         for ( ; (pages < sc->pages) && (i3 < LOGDIRTY_NODE_ENTRIES); i3++ )
         {
-            l2 = ((l3 && mfn_valid(l3[i3])) ?
+            l2 = ((l3 && !mfn_eq(l3[i3], INVALID_MFN)) ?
                   map_domain_page(l3[i3]) : NULL);
             for ( i2 = 0;
                   (pages < sc->pages) && (i2 < LOGDIRTY_NODE_ENTRIES);
                   i2++ )
             {
                 unsigned int bytes = PAGE_SIZE;
-                l1 = ((l2 && mfn_valid(l2[i2])) ?
+                l1 = ((l2 && !mfn_eq(l2[i2], INVALID_MFN)) ?
                       map_domain_page(l2[i2]) : NULL);
                 if ( unlikely(((sc->pages - pages + 7) >> 3) < bytes) )
                     bytes = (unsigned int)((sc->pages - pages + 7) >> 3);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:30:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:30:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238912.414055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE43-0001lB-0F; Mon, 06 Dec 2021 13:29:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238912.414055; Mon, 06 Dec 2021 13:29:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE42-0001l4-TV; Mon, 06 Dec 2021 13:29:54 +0000
Received: by outflank-mailman (input) for mailman id 238912;
 Mon, 06 Dec 2021 13:29:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE41-0001ky-BH
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:29:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 97674f77-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:29:51 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-IFcU3Z6rN2SdMgnKV-E19g-1; Mon, 06 Dec 2021 14:29:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 13:29:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:29:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0046.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 13:29:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97674f77-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797391;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=XaFqQ/j5v8nVoRuIcB8FLvaeesWu7Z2skNYq1vYcRGw=;
	b=cCSr6i0mr5JWwKfSt7NviYs7Dw8XSEHvPyNcgScIDn9A7755GwWhvXS2u2aE4NaEockijS
	qQm1pV0qVPjTSDC98WFSfYLEOZ65GEhl3dBuSu1xEsjSiOBhxP5VnHQeuXIBUL/oPk3OdK
	2fHaS3uCHe0be9UIfFD1SAvip1tGJqA=
X-MC-Unique: IFcU3Z6rN2SdMgnKV-E19g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=h7RtipHL6iWBdo3rgFUxdxA1UhHnAcINeyn488UbnWt0CM8Ux/rYPWDdzuvz4G6wUX9vckE6z340VWDDJ7+mZ+DSJF3pzHlC8V3EBqt+z1C1VI7/K9rHKdXxy3WADlFcXz4svH28R5uR/CSXLHAuRIh8jP8pJiYQnI8sWlhJD8vOMQrD6dMLkixCw2R9Q3vHJZ1iexhb5td72ctbIKPAm4/aKlHZR1SxCQW0NJYu8X47x4XGFc+JKf0oUPPv5aW2FFvFo0Q19Oomfit5oaa8QbG0dML+86m1cAiYiqB1LRGu9wQd1cxmj82d9nP6SLolfZMXkWhZS9IrpGMCe4mo6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XaFqQ/j5v8nVoRuIcB8FLvaeesWu7Z2skNYq1vYcRGw=;
 b=TJ+48e3cy+9SlFXJlG9a96hKZ93/7zR23aeXUXzfshEaKrQuAlmgPAQCW4VGBZXmQm/XELFYzWLuOItOsUzB0H1Ff2ZuwbYe3a3Zhdy7AVdnPehAXYvjw8yd8M8VNKx6yfAVFEXgIeLi8Yr6GVnv4/36jYYR4urW996wcvRBi96Udd/Wyfy1KAVmn3Pb0IpOW/WmNkPo9745FDzMlNa9I9hF8LZ0v/xXsgJrmWV+BaLZRoCkoA6vq28C8qt5cogJp9Oi7XjqKQBV7rQdfVVZFvPfNx4g6SvUlfprWhbIiKzUeCr0at21s+xEha/Pctpk5aAGvXeewvx7Jx+GXEmR8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Date: Mon, 6 Dec 2021 14:29:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/7] (mainly) xz imports from Linux
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0046.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eb9bbc42-789e-4c37-aa8a-08d9b8bc7975
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB28292549FDC7EB43CC74B94EB36D9@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Z9Im3KAz/2WgTu6CAoifqhFOf9k8LV3uY8C76NkPupChGWjPwdXw7m9WsxxHu4UIU8pfZ7T5X6hqylvriPU/Ikh+yw5pssw292D7uVeTwZQ+JCeu5yfSQuG0xxh79NZXPCcm1d9kEebj2lS7OIJCKilgNgqW40uVFxlJ3I4LBPRjGZLFPZ1izR9YAD4eYgP7ol5jRrNEgAYAC1PpOOL+Es98C337H9QyqEXnTNDH5lrSyH4i6c8iVHH5ns4rHX23ea6YHkg7LCGkfto06OEqfqj4viK9yfOzBAun2L5Xiqh7WgU5sCjKzeZNQ91d1XL/wbhccqzzVKXw8eGOmmGIBvPtv8N2NYSHhYqPQ01BXMX5vel1PuU02SYlZJQX59sVBDc5fCEeVLlYSNEp4p4G7DsiHk3cN+2XDm9cKsvDW2hrh4w5AKxOLjhnUmU4LSeBCO4dFQVOocLv9fK0sJvkho6ca2pjE6uaMeIpZqgVbRJ1hGtiPlzNt2Gg1C8LWwyNbu45bNflY0Vx4YVbDcWPkPlS5iV/ctdfdJlI/tYYDmGi3AsvzJOvOu4KkciDR+y/T1ffpCZd9reRf1BjIM3zeK7yM1VHi32pdFfm1iZMZUgv1pxMGmkuHNaGNbD8CnY5malyg3WBBQhypihZykY1gQsTklgSRNbOAPlo0X/H773d6Jpj+hHs9ppgIIoOpjOB/HhXGNmCy4V01Q7a6MbMOlC3xmia0LzNdZ7zDYMMJIMflnYyPb32O2mzoAjH4hL0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31696002)(2906002)(5660300002)(6486002)(66476007)(316002)(6916009)(83380400001)(54906003)(4326008)(66946007)(508600001)(16576012)(66556008)(26005)(8936002)(4744005)(38100700002)(956004)(2616005)(36756003)(8676002)(186003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3pKSWcxQ0FtTXV1WEZDUjduQjBJS0czN25Fd1g0TnNEbEV4Uk1BTTUzZTJy?=
 =?utf-8?B?NFFPWS9NcmVyOU8xVzN1eEttRzJ1TmF2MG9mUDJqTWY5MGg5RDFFZFVUcklk?=
 =?utf-8?B?WmZLeHVRRS8zNTI2emNCTEU4dmFBR05lblJEeDhhM2k5bUdsV0ErVXIvUGor?=
 =?utf-8?B?eWV6R0FzZ0gxekJwdUdMcitjUEJXN1VZUllDVTJCZFVockRDalZOMyszcDZ2?=
 =?utf-8?B?UWtFTFQ5dFJZSWNVZC9OdDVDdzl5Z3YrYXVreCtLRVI1U0dUa0RpbFlYK3NC?=
 =?utf-8?B?U1A0VmFpdnBhdElCcWlZSUpCUTV6NFlHYk90dnAzSUgzb2wzTnNtTE9GL3BE?=
 =?utf-8?B?MVRpdDUzTDZsQnI2cncxV014Rkl4V1F5Mm16MDZOMVJQd1BQd25WZXV2MnFi?=
 =?utf-8?B?YkUyTTlWL1RrRTM5SHRldnQ2OUFFTENvZytMYUFtSldGZEFXcXlmdmhFaHkx?=
 =?utf-8?B?d0hJckh1bHk4YzQrSjVoK21MbHRlbUl1VEN5RlZGeW9KWHJlNDJTVlR3Nkcv?=
 =?utf-8?B?K250dzRlSVc0YUt3VmlSVC94MFNFSXdiNU9kbzVhN2R3RXNreGdHc0M2KzVs?=
 =?utf-8?B?ZTJ2MEVxUnVYdXR0Z0NIazB4VkMzc01ydk9od25rWnFkenBRek15eTVzbVRx?=
 =?utf-8?B?QitaUlZYaGYyQ3ExTDFTWE5UTVZvUnVBVDhzRXFpQmN4QzdPYjhaNlROMDF5?=
 =?utf-8?B?bDUrR3k4ZW9Vd1VLMjJGV253OHRqZjAweUsrSG5ZV1lFYjd6UGRpaVduUkpE?=
 =?utf-8?B?Qi8xUzJySWNZWmh5SEFvOUtnNzE2bXVwWTk0VzgvOHdyT1BuSzdDVXFTVkxH?=
 =?utf-8?B?d21DODV4TXAyZWFRSmVYd1JKOGdiQzRHMlY0YWthSy9GZzB4c0FmcHdTc2Zv?=
 =?utf-8?B?dURhbnYrL01kSHZpR0EwQ3hwR1VOaTBZWFZnVE1kelJjWGVQRmFHbVJkdjJE?=
 =?utf-8?B?YjBVK3lDZDlrcE50VE1oeXNNNnptRzUyOERaZ1VwV0NrRFpPaUs1RzdsbXdw?=
 =?utf-8?B?MG5ZQVhmUkNVZTJSSFl3UnBMbHY3eUZwM0xUUS8rY1VPOVk4aE13OFBhN3NH?=
 =?utf-8?B?eHJFMHhXeDloYVlodnhqMHlMNzJvVWVMcHJVVks1d3hSODU3WlRpYzE1cG54?=
 =?utf-8?B?aldEK1lFOStKN0FDZlFYYTBBMzAwd0hCSFN5UmVVM0E0aS9odC9uY3N2b0Jy?=
 =?utf-8?B?TFcwWnBpeVFkZTI0YUtpQTNBVDdPR1hGa0VYV3pwWlB0R0lMRDNVaHpVZ0ZD?=
 =?utf-8?B?RStlZ0xVWFlqK2s1U3V4QlZRTUkvamhLeXVKU2NLdzJ3aWUxVGwzVGlkSGt5?=
 =?utf-8?B?b2VjWDhFTStEb0ZnRmhncExtRHVjUVd2VVlzYnpSeUtQYkVwZkpPeStlcm1R?=
 =?utf-8?B?VU5ISmIyVmtNTkhkN1pBd0h3VFFiSnJRenUrVVlWV0srR2c1UDJBUlp3NXR4?=
 =?utf-8?B?R0N0Qis0Vld1VnZYZWI4M01qMUc2bzBFOWtESUdHUUtMVVFZYjQybEMzajJW?=
 =?utf-8?B?TTVFbUx4QkxSS3BRTmoxT2FTWDdFdlBZZGhNclRHVmhjZGhDclNQeUs2Qm5D?=
 =?utf-8?B?aCtRNzBLbmt4UkJCSy90WUVXZkpWbE5nRnNuZmFVNnFzR0ZmSG8xVVhDNG5u?=
 =?utf-8?B?VHVLSjVnY3RsSmxpUFdnNjJ3SnJqRklsQUYxTHlwSFp3TUVuYUV4M0NGVlgw?=
 =?utf-8?B?WkJzQ1BqelhJQXdCZ2w1TkJZcDUwV29nYjIzTUZveTBaT2MrSWFEai9JWVRk?=
 =?utf-8?B?N1BUbEcwa3c5dkJwcTJjcnRZdXlWV3FqdGxVVnhodFVreHp2ZHh0dzZMUFgr?=
 =?utf-8?B?bXJVQzBhL3hueEVVenBlS1ZvWWpIZDBubkhKK294MmgvK2g2OEZXVHIzV2Q5?=
 =?utf-8?B?OTJKcUJreHBueXkvZ1daZlo1NTlDUFJlRzZCcDJJRUtqNmIzbWtRcDlxVEZD?=
 =?utf-8?B?NnNJSEgwNUU5RmM0MjBBQ1JCRHRYd1A2b05DYXhmUHFNNkJNT0Z6eFNRcXNF?=
 =?utf-8?B?VjR2eFZPN1JtVzU1VVZxYjJvQVQ5Z3I2S3daOElOWitsZmpmZ1lKVTFmREJV?=
 =?utf-8?B?MWFnMW55RnpiMDJhWU0yOG1Qd3B6S3VWaEJxK1RuMnc0RWtRWU9FYXVRMFVN?=
 =?utf-8?B?ZGRrU3hQekQ1NS9PTUc1cUlFYitTeUpKZFlNWGQxdVB6cG0weFplNVRsWHJD?=
 =?utf-8?Q?3roCptehR7n26yikaqqjkPg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb9bbc42-789e-4c37-aa8a-08d9b8bc7975
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:29:48.2401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cBj/S64UzSrpdUEPe8XVeFo0kWefFsVhI/YTm7FAIyJRR2lTeRmBvXk5Od25YkjMRnXuYSF4zPDp7bEYK/jHMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

While going through their 5.15.3 log I did notice two changes, which made
me go check what else we might be missing. The series here is the result.
Linux has also updated zstd, but that includes a pretty large change which
I'm not ready to deal with right now. Them moving closer to the upstream
zstd sources is certainly a good thing, so I suppose sooner or later we
will want to follow them in doing so.

The only change in v2 is the re-adding of some previously dropped S-o-b
representing the original, documentable submission flow.

1: xz: add fall-through comments to a switch statement
2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
3: decompressors: fix spelling mistakes
4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
5: xz: fix spelling in comments
6: xz: move s->lzma.len = 0 initialization to lzma_reset()
7: xz: validate the value before assigning it to an enum variable

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:30:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:30:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238915.414067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE4T-0002vq-9V; Mon, 06 Dec 2021 13:30:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238915.414067; Mon, 06 Dec 2021 13:30:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE4T-0002vj-5H; Mon, 06 Dec 2021 13:30:21 +0000
Received: by outflank-mailman (input) for mailman id 238915;
 Mon, 06 Dec 2021 13:30:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muE4S-0002vN-4o
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:30:20 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7af0572-5698-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:30:19 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AFF9921138;
 Mon,  6 Dec 2021 13:30:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 79B1D13BAE;
 Mon,  6 Dec 2021 13:30:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qh0KHGoQrmFAIAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 13:30:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7af0572-5698-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638797418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rjH3GlR6qZT+gmpjB2DhmHifnrM7sEnhkVMQpV3UbrE=;
	b=gS6adLdFpQXfcIb97KxYBNFuK2u8R+zBKWC7a2XW9CMfeRrykQBu3V2raxnNFjdw1EFmoK
	+lECzyB3BGaNGHJawdRoplBik6ZGfVN3Q72zf6MxbskPRpEYoPP8PaxdDB+9rlbWocvNRp
	svgM+2KCXB2kAWQMkQQ4e8MPeIP55qM=
Subject: Re: [PATCH] mini-os: support event channel 0 for console
To: Jan Beulich <jbeulich@suse.com>
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206124612.24758-1-jgross@suse.com>
 <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <e3a098f7-e296-de04-889b-3983d23e58c5@suse.com>
Date: Mon, 6 Dec 2021 14:30:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="0yj4b187kHHxs2gYxzlqTiOSZhnZSWTHm"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--0yj4b187kHHxs2gYxzlqTiOSZhnZSWTHm
Content-Type: multipart/mixed; boundary="Ppp2vYvGThO8wQQ2EBYyUaL68OiVZg9IC";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
Message-ID: <e3a098f7-e296-de04-889b-3983d23e58c5@suse.com>
Subject: Re: [PATCH] mini-os: support event channel 0 for console
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206124612.24758-1-jgross@suse.com>
 <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
In-Reply-To: <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>

--Ppp2vYvGThO8wQQ2EBYyUaL68OiVZg9IC
Content-Type: multipart/mixed;
 boundary="------------2BC56277A4C35AB15AE644E2"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------2BC56277A4C35AB15AE644E2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 14:24, Jan Beulich wrote:
> On 06.12.2021 13:46, Juergen Gross wrote:
>> The console event channel might be 0 for the console, so use the value=

>> of ~0 as invalid instead.
>=20
> I may be missing something mini-os specific here, but in Xen channel 0
> is always invalid. It's not just here that this value would be used as
> a sentinel.

Maybe this is a special case for Xenstore stubdom. Without this change
I can't connect to the console when the system is up, with this patch
it is possible.


Juergen

--------------2BC56277A4C35AB15AE644E2
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2BC56277A4C35AB15AE644E2--

--Ppp2vYvGThO8wQQ2EBYyUaL68OiVZg9IC--

--0yj4b187kHHxs2gYxzlqTiOSZhnZSWTHm
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGuEGkFAwAAAAAACgkQsN6d1ii/Ey+U
2gf/QyjWryYWgG4hsAgy3ipz3es5FZ5ydqr/7kmBNEpyn89hb4XemnnrBpT1D61h/deoUH/i6qII
OyM6GQWfCPUPSTDXXffU1BV+RrbWpXxMbKgGlW8xJAdopuHRPk8DhM3UOqVfHtR+oC6rEuHWDAWm
sIJkFvnaQ8JEXgYdwBKhsp1F7ET3zr25eGWZy3YEtJd51Mw5/qipJCz33pOZg28Fadx97S8mMxnI
GSPYf2Siz7kAZEkLx6p750ErOIXO2m3+lc3Aiws1YL50sWkpi47Tw53Q+ulVz2Yv8SGp+0HNqoHR
bHerv1WGQ0uMKG4ymJYpt7kQSziu02ElD/Oe4OXVfQ==
=OwFN
-----END PGP SIGNATURE-----

--0yj4b187kHHxs2gYxzlqTiOSZhnZSWTHm--


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:31:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:31:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238920.414082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE56-0003fY-Lv; Mon, 06 Dec 2021 13:31:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238920.414082; Mon, 06 Dec 2021 13:31:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE56-0003fR-Ig; Mon, 06 Dec 2021 13:31:00 +0000
Received: by outflank-mailman (input) for mailman id 238920;
 Mon, 06 Dec 2021 13:30:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE54-0002vN-Go
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:30:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id beb659bb-5698-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:30:57 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-E_ekhWD0NRKdcgcUKKBhbg-1; Mon, 06 Dec 2021 14:30:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 13:30:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:30:54 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0043.eurprd04.prod.outlook.com (2603:10a6:20b:46a::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend
 Transport; Mon, 6 Dec 2021 13:30:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: beb659bb-5698-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797457;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2L7R3Ro54o4RSNjLVMfI6YXuaCvbMiNR4YzG+3Qu/4Y=;
	b=HifjjfJ2Sn35CA3gWZLDNRIXvjtQXScTK7Xj3jS6RbuBduDnhsAZ1P7JKchgJihCFr+O72
	31UJ0MiL6dC7YmxgfNPzufi8JOaKvSkvFG8t/OnndLC+RWVUOekRCeYL30CssaMjL5ViuQ
	ABawaSVg5jwAXOgYONxc/Bm2rj2RGxQ=
X-MC-Unique: E_ekhWD0NRKdcgcUKKBhbg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eAxBncdaWK6FyM/gnxo9MZV4Kq+VfpwWF65JQ2s5yDNcCBk6Bq/nrSnKXw0ymjMBKLzoj19i1m2cjgV25mUjSGh4i09E3YRMOlbdafLq+NeDDg+cfg5p7Tgb2ULzk3vttDULkuHWk6m4HpqaR2eVSw4hFwNJW1sbUPDElIrPkxMpFFDQ9qi5QDWF720naSm1ZeQUdFLqu2GloTpzkJA7Gk/qz5BAApHpcbBjgO6dauuqTN3YpwpIqDVDh+7DmYLrvE+rpZlbdAd6C16ZP+ic3uBEneAqiKi+xInnYeqU6tHqkD3FStrjZ1SsX5ely43C315m+knKbOOGqwUiXQDd0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2L7R3Ro54o4RSNjLVMfI6YXuaCvbMiNR4YzG+3Qu/4Y=;
 b=Wx2phLVvCFQqzRqOFUhuK+KXW3qOFEG9D4f0DCrIjtWbOkFgh4VDQ42Yc4iCFBKOwMBBwuWhZX8trX6c+AnO5Z/im8zTzHjgQ+/bMa1PlA9I7MfpH7TlFl8/10L6Fk8ehBJreLMzIIreWcB5XSDJlp1L2GFiaba0nHR6DoAWFeqx0zuWO7w9Gi0pVksHT6++hT8CYTLqL445I7dbCb1Vx4Xj7adDLml3nLRHDZEHH2esxlKJGzSrcgaqOPft7h3MUMr4gYeElXP7Vtj9fgRsea2bvxQuec61Mx4VEXEf1QEyy/MnF3N88Thht+v1U1BV9GSpGxuYXwWl8BA5nNzyNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9666b3cc-d4c7-1a51-3a23-419d16232465@suse.com>
Date: Mon, 6 Dec 2021 14:30:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0043.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 79d074b7-9d3e-41f8-712a-08d9b8bca110
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB28294D8E2E234A3E3614AF93B36D9@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:196;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PtnM4Zt9DpTwyc1kxM0AMkgjADKPHuLwqrTEO3VZdaoKvGniGtP3g97QXfyggIip5Vq+ba2a6Qvb49o1nKliEFtpxGhX5VyewbxCwiVjZrvpxCQ8JHUbNiQvpVruz2Z6QHnxF//i0SJXqxq1E9g+FvJZDV7m3GKq4Jk+Z2UMH90INkcSCZFeSOOxjeLIXDHtWc2sxknU5YzhlBO+kP4BouGaql8eopG/s8x7sw74MLImTefXqZYTtVHSS8tCWMSyIoRUnbUIEo28h0OVerlkkALr8Rw0seJ7HFJw/HJTB1IMzKktuHi8nwxxUwBMA2N24RK63so39ofdCfzaV344iQuJcyhj/MP3oga5gq5FjmhIpOO2VLAoNbFzHbJxCo5BJUcjlQo4BBGtGFbYZpnYY2y+iWN8HWHNxfNsNnx1+1l8sXwT57W7gu501kLBmLoa8C/KEBfNp0NEQNw1jzEmXMD4kxTcPvWKcc6Bzzf/rIhN9MQPYZqMi+J49eOlgH+VTvx2qcFXjKBNigXMDTfjdRi9ALhgJsSvVGbfd3SuRIuOGq7yX7xkHOfzHKaW5ay8hi7OfRZfeXEWTOfLL9VK9LrUGbyH26A7ffXLtwv3sE41w66VqMFEL45AWrPdgQLZaAYb8CHPTBMnBkhxKhjbWjRx30pw85CSiXkeMjg96+icclgJQnz7cW/CbOTNk7NZuNG1Aw3yCSj9L10CjRMvdMktZXdC/qT7u/cFfjO4qGk6vOdCV1wllKkZkIufh2bW
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(956004)(2616005)(8936002)(186003)(31686004)(8676002)(36756003)(6486002)(66476007)(316002)(6916009)(5660300002)(86362001)(31696002)(83380400001)(2906002)(26005)(4326008)(54906003)(66946007)(16576012)(508600001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkRNRHIrNnNsaXVvOVpLZHUrNHNHTVRHd3lJUmxWK0FWZ0JmeU1zQjhCQmti?=
 =?utf-8?B?SjlZUC9xQVdqSTVzMUxHRjhVZ2ZIclFLdEZEb1FlVjJobzdlUXJ6K0RSVTVI?=
 =?utf-8?B?aHNRY2FWU0Q3K3dDeE9WQmZ2Q2w0Wi9iTHlzbDBUVkZVanJFcVNVZHQ0VUlw?=
 =?utf-8?B?MFIvWER1cnhrVkQ1NHA2N1BkMGdaNjFiM21YYmhMZVdJVElEUTVCcUZpY1NW?=
 =?utf-8?B?RDFtRktxNjF0dVZ5dFRia0JFb2JGcFJlTmRhTWUzdHh6YzZxTUFJWEQ1eTQx?=
 =?utf-8?B?ZHpOS09RMnlsZ2JrYzN3dHgydVRDRkJGQlF6NXdYTDdmaUpYWEtEVGl3RXdZ?=
 =?utf-8?B?Q2JsRXNRWXVXZm13aUhrZE9KbUdqbG53UGZDT1lqVllFdSswbXYyQzZOUTVt?=
 =?utf-8?B?RDhKSWJKdndlNThxR3gxMGdZRENXRXpoZmpvSU1FNldHRVFpUXVSTVN4UXly?=
 =?utf-8?B?bWFOTHJHczZ2bkNOclB4WTZsbFpWT2pmRFV2aXI0Sll2U2tYNzNOV2p0K3VI?=
 =?utf-8?B?U3FQMG5sSFJoUm5UWHY4UTBOQTNwWCs5SU9lWml4d0Nia0F2UHBPdnptdzBi?=
 =?utf-8?B?OHZSa2hsN2JSMWJWYVpmRVM2cldjbVQ5N2tlaXRjdGNxMHNCbEJWblhtaWtE?=
 =?utf-8?B?S3FraWlqdVdjY3dGY2h2eDl5b2NXVE9ScEc3L2h4Y2I2bWFIYml2U1c5cnh2?=
 =?utf-8?B?cWxJMXhtSktGL3I4Ty8wZWV5b2REWThnT1BKb3lSQU51Z3RzT3ljQXpiYmMv?=
 =?utf-8?B?ak1VOHJJZFNCamxLSDY4c3pvdW0rNFNxSVVxRUYybktCNjRsc2NaOUU5M21r?=
 =?utf-8?B?bWFIOTh5V0VSSkkvck9rNWJJWUE3QnZXVytRZ1BEVWM0ZER1T2JWY0xQVGh2?=
 =?utf-8?B?NlZEUUZMdTFUTFNFZWZsQzdDOGNDb1VzN2ZMQVpMLzJZTmJNaW91aFlqTExJ?=
 =?utf-8?B?RituMTV1Qmp5Qmo5QXE4S0d1T0VuRXpXTGNxdDRLcnNsY3hvcHF0R2t2UWMy?=
 =?utf-8?B?Mnd5WDVrR3VrY1NoM0hxV1B2SW1yaXJLbHczSUY0cGZxV0ZXVXlVNXZXM2Qr?=
 =?utf-8?B?TzJ4VXVDcmNlQ2svS2VQYWxWT3JqTU5Vd3IwcFN1UnkvRmRibHAyYWI0U2x5?=
 =?utf-8?B?bGpscU9HU2l0MXVkTlY1SEo5MmlwdjFtYXVIMElEYnlOYzVPblR2dGZZalZH?=
 =?utf-8?B?NWV2dzk1OU9uQVhITC9zcmt1cUFIeW04aDF1YzZJQVpMbHQwKzZ0TndoaHhs?=
 =?utf-8?B?MkhKVTBSUjE2aGl6cFJTYjhveWxGM0RUNVB2NWl4bzIvZElYdy9UOFlRZmly?=
 =?utf-8?B?V3NQOWhzMEFqYksvTHBFeDhCM0t2Mjc2aVRSZEcwL1dvVmlHQml5bjM5blpS?=
 =?utf-8?B?dTV1VjFsY3VNL3hBSUJoUHkzbVdKaUM3MUpROXdkZXJpbDRLYkpjS255cVFa?=
 =?utf-8?B?NXBCeGdHZ0dQcmlId21lRUlCQzZDWXZxaklWV3VmWTRndW8yWkFnSXJMRGdW?=
 =?utf-8?B?ZWh6RFliTVlGNEtuc3FzRHNyT3UwdmlmNnFSUEpkOVZSUGt2TUZpSFU0M2Nj?=
 =?utf-8?B?TkQ2YmRIY2xDY2pDTzRxaWpWSWVLdDdacS8yd3daL1o3WE12V0pPaGovY2ll?=
 =?utf-8?B?dVdTMHhpMnlLQ2MvZ2owbmVhRTJqNGxScUNCRGFhYm1IS05lcDk3ZDg4ZVc4?=
 =?utf-8?B?eDIvUHVHQmF0WFBDMzUvaTViY2JGQzA2eGxZRnZGZlVoOFVDTUZLWmtXa3hX?=
 =?utf-8?B?TjJoUkVnVVo5clhBNGZZNkJUanRZN0JKaGhsOFJTRDN5ZTNCUGdRUy9oZ01M?=
 =?utf-8?B?dkFRNzl0S2k0ckVWNVV0WHNDeEloR0dDclNPQlpzZVhlNlowTEpUalZVZk83?=
 =?utf-8?B?N1QySjB6ZHpXM0hoYWxiYnNJeEY4OERQTjdFTUZ0Z3dLcUZ4ZlRVeUlvZmJp?=
 =?utf-8?B?THFkUTdZVGpwVVdnVC8wRW9kR1pOVkJCWjRZRkN1d3ZSMS9nNmw2aFF2T2Jq?=
 =?utf-8?B?QkpWL3JIb1R0VTgwSDNsMmNQcERha01pZFUyQjBmdkNpVFBtY2JnWHhFL014?=
 =?utf-8?B?NFZZUFdYMDVheHhtSXIxTzJrcTRaUFd4YjE0dTZHUkVpOXRMTk1HN2dheGxv?=
 =?utf-8?B?ZFhPRWtHVTQ3Z1VJU1F6RFR0aXE2eEI1YU5DcWJzemlFZmxMbVNVWkZxaE1v?=
 =?utf-8?Q?99nNW0y9w1eDSV7w05n0P08=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79d074b7-9d3e-41f8-712a-08d9b8bca110
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:30:54.6406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cVru0BmsaqEEy1jCrM9Tj9SJc4Wx6nrhUfxxfw4hlQh7NkYtD3gtc52P8lu7ghAJQcK7EPPJGexejQTWjNQQVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

From: Lasse Collin <lasse.collin@tukaani.org>

It's good style. I was also told that GCC 7 is more strict and might
give a warning when such comments are missing.

Suggested-by: Andrei Borzenkov <arvidjaar@gmail.com>
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
[Linux commit: 5a244f48ecbbd03a11eb84819c5c599db81823ee]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
Linux has meanwhile further moved to using the "fallthrough" pseudo-
keyword, but us doing so requires the tool stack to first make this
available for use in at least stubdom builds.
---
v2: Retain the other S-o-b, for lack of mailing list source of the
    original submission.

--- a/xen/common/xz/dec_stream.c
+++ b/xen/common/xz/dec_stream.c
@@ -583,6 +583,8 @@ static enum xz_ret __init dec_main(struc
 			if (ret != XZ_OK)
 				return ret;
 
+		/* Fall through */
+
 		case SEQ_BLOCK_START:
 			/* We need one byte of input to continue. */
 			if (b->in_pos == b->in_size)
@@ -606,6 +608,8 @@ static enum xz_ret __init dec_main(struc
 			s->temp.pos = 0;
 			s->sequence = SEQ_BLOCK_HEADER;
 
+		/* Fall through */
+
 		case SEQ_BLOCK_HEADER:
 			if (!fill_temp(s, b))
 				return XZ_OK;
@@ -616,6 +620,8 @@ static enum xz_ret __init dec_main(struc
 
 			s->sequence = SEQ_BLOCK_UNCOMPRESS;
 
+		/* Fall through */
+
 		case SEQ_BLOCK_UNCOMPRESS:
 			ret = dec_block(s, b);
 			if (ret != XZ_STREAM_END)
@@ -623,6 +629,8 @@ static enum xz_ret __init dec_main(struc
 
 			s->sequence = SEQ_BLOCK_PADDING;
 
+		/* Fall through */
+
 		case SEQ_BLOCK_PADDING:
 			/*
 			 * Size of Compressed Data + Block Padding
@@ -643,6 +651,8 @@ static enum xz_ret __init dec_main(struc
 
 			s->sequence = SEQ_BLOCK_CHECK;
 
+		/* Fall through */
+
 		case SEQ_BLOCK_CHECK:
 			if (s->check_type == XZ_CHECK_CRC32) {
 				ret = crc32_validate(s, b);
@@ -665,6 +675,8 @@ static enum xz_ret __init dec_main(struc
 
 			s->sequence = SEQ_INDEX_PADDING;
 
+		/* Fall through */
+
 		case SEQ_INDEX_PADDING:
 			while ((s->index.size + (b->in_pos - s->in_start))
 					& 3) {
@@ -687,6 +699,8 @@ static enum xz_ret __init dec_main(struc
 
 			s->sequence = SEQ_INDEX_CRC32;
 
+		/* Fall through */
+
 		case SEQ_INDEX_CRC32:
 			ret = crc32_validate(s, b);
 			if (ret != XZ_STREAM_END)
@@ -695,6 +709,8 @@ static enum xz_ret __init dec_main(struc
 			s->temp.size = STREAM_HEADER_SIZE;
 			s->sequence = SEQ_STREAM_FOOTER;
 
+		/* Fall through */
+
 		case SEQ_STREAM_FOOTER:
 			if (!fill_temp(s, b))
 				return XZ_OK;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:31:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:31:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238926.414092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE5P-0004B2-VQ; Mon, 06 Dec 2021 13:31:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238926.414092; Mon, 06 Dec 2021 13:31:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE5P-0004Au-Ro; Mon, 06 Dec 2021 13:31:19 +0000
Received: by outflank-mailman (input) for mailman id 238926;
 Mon, 06 Dec 2021 13:31:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE5O-0002vN-Cd
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:31:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ca8b90c9-5698-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:31:17 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-1203vd6lPwWmIyTnIi7LrQ-1; Mon, 06 Dec 2021 14:31:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 13:31:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:31:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:46a::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Mon, 6 Dec 2021 13:31:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca8b90c9-5698-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797477;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NCSQ+AXXRTjdtJyeP2akK62GyR4QHv+YZ2pLR/0+MYY=;
	b=N+jIBQTod0rSqSca6OhF0Y5AAPCqiCSEBvM9INGhPUR53QF8VsO/f3KwwuLv/IRQXqPTAK
	7Qm50/OLOwkeUuKGo8OAT9/tDB3LrMAdOhL2WjWExO2LvucAOz+4TXtS4vgJyOTc3aN2B0
	6ZDCCnELuSZA/eNsUTlR+5JJFwNTfNA=
X-MC-Unique: 1203vd6lPwWmIyTnIi7LrQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YXD/pMNJm4DdDLSYKHPhETw1V5AUWHQkHOyd1x7mmvyAbmqBaKt/bbBDF2Sfx1pwgW5PlklwXnbR7Hefaf0XZjeOceUmCxTPfImxs89dLm/WRDJNtLYiGAO5616Llkl9WgDW+T7Gal/C+QR8UACAjlhsdeBKP+ur+Btr+jtFo2wyCov5SPoG0K+ODyVzewGVqQYCNsp0LkUeL5ttLc9N+AVbQSVRSfyWnxCL4CXYEP9YVsEs0+f8Xeef5v1MZgq5vVBx39kFMaLJkAtXZz8HYmYvc/FZxYBQWqj7PgDTM6veHJgLgNe4K/aHa1znbKmuDLjtzpCHmr95pDRVjkhxCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NCSQ+AXXRTjdtJyeP2akK62GyR4QHv+YZ2pLR/0+MYY=;
 b=g48RbDNF3lnvgZuKyy30myXG1eODG+qfVC2IkR38+ApkVofWlP4KNmRzVZCuU0gSgV3iWpsUx/i6jmyYvRpJciBvmhxyCgNDnAdXUgUyag0hTARMGbsLreHIx01YPHkuFJSQrMSzhkQL0xb35FGRMsR+p8VKhhStmaVSZNDTGVpvi2h6SeK3ISIhyMOB0rS6SSBPZXSAw/20S6xjpT39EdTKBDbDtFos84pk764Y+22hMh3TNAoqad/fxcZFR/AgoHlzuClBWuXlGNSppj34DnvwbDKEL6jQsf8GKcj0CGLCv4bQ4njYopnbaaUCRTbgN5fg41q75hhDuHE5qGiLug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bdf92555-56ff-1205-6c27-1388ce745a7d@suse.com>
Date: Mon, 6 Dec 2021 14:31:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 2/7] xz: fix XZ_DYNALLOC to avoid useless memory
 reallocations
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0059.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ad052fe7-2175-4be0-37cb-08d9b8bcad4c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2829D84C82EEC937765B6FD8B36D9@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:56;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G83S7QF4hvyypzbKflfnJf+cTPkeQng7ZZXzeHHUtmjk3U5z/bI46C2wR7Gmr1BjH/GBpyD3oCG2I2Dqwz+kMnAyvzDkO+K4DiRIL1x6g3xiokR5dc8eTGSzwp7XdnfjnJlXxBv3hy9XissWzOjtxt5JqIkwVKllQiXlNBRS+sNxHqUlnWJlDqRU7odeCXtCeI96fA90+pJB/nBjJgP0R/ITKStUaHQiUlXwof1P2NbgRdp4uQ9+idMQmVJJfHjZRFo4hxWns5qU6MIIVCbTrj1mkd6gT8ntZouoOrMZRg6JneLiX85pkEl2bjFJIaGQ84r1FE2tCac5Igx5cGk6QEbkGGOwu+H+/t2QY1D43Fs3oXyXfOCURnFwCYaiZ+fGw2yaxPs766hrEVH/rDRbk2I5+nz8WDj8TNnmJqn40axia/Mh3GQ4x+Twa82uW43oTQhYyR08M19LWAg1xEWdieSL+itYc9+SlKmh1EiYP0hf/xJ1oX5AKCNPFgGb10o8d6pCxBctIT+GKNMezUG90Qe25eLFphgdGQPPxe3YBJJjFoZldV3MXaBwJncHQWpuDo5uJdULqQ2q9yLslC45zKR4ahGiPe/pf8JLQMOLw2j+ZHvvTbOAE3vrdJH5tXyoveXGgyEDSV1keI+Mh3qUoZTSL1/GgI0s0/dFDGdsnqd20aydg/JduM6miiDVg3nf1eYiTyrlkdxN73+f1JzUg9dKWySWFarZmbJgCXTOLNUfyMdeN2TlB7slMrMDjOwlgVVo5vC8fYsjsqf3F04sARfM9JYiASjoe15TLyQsx75hQaJeEl6elZ0G/GDuqVVQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4744005)(956004)(2616005)(8936002)(186003)(31686004)(8676002)(36756003)(6486002)(66476007)(316002)(6916009)(5660300002)(86362001)(31696002)(2906002)(26005)(4326008)(966005)(54906003)(66946007)(16576012)(508600001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0JYRmFmdmFYWUo5cU94blQyNWFxWSt6R1ZOYmVRT0ZMSkhuOWFEeEtZVGFP?=
 =?utf-8?B?TjFXTnRFWVZrVnhoQ3Ixdi9XRXdkRHh4OEp1T2VFUksvbWdiTm9PL1pKYXZO?=
 =?utf-8?B?M3hPVjFYTy80MkJPUTQ5ZmtHTjlPUFpGSjRmYXZoVkZUVjNKNzd4WTIzNWVi?=
 =?utf-8?B?UlhzWWdaa3Z6YXJWZGZWWE9lQzh5UGE0UnQ5K0hnZXVFMll2RHZRZXhjMytL?=
 =?utf-8?B?NHMwV3k1ZmJrcitVVHE3VlFtUklKNW1LZGtLNDB3SkpvN1JsendrMWhnQlB2?=
 =?utf-8?B?d2tEeHUvU0FMM3crbUhvYkdMbWM1ZEpsLzlSdFdDa0Jic3kybnByY3JRdEF0?=
 =?utf-8?B?UHd2cU5YMWtES0hRaFh5dkc0T0QvNlJ5WGpwSVJYTnFwdFlycUkxMHRrYlBL?=
 =?utf-8?B?aWRuUlZWd3dDdzl4WHZnYTNyTDNkNm9wZzU0RVREL1ZycXo3bnlrUU5aeXQw?=
 =?utf-8?B?SXBsRDhNOXBxTHNhZ1VqNFR6NFNjNzltVldCdEN5aGJ5V3V0ejFreUhXUFhn?=
 =?utf-8?B?WkNJR3BENW1qU2RyRVJMemtvUHdiZ01Oc25jNm1ocDZNMTRzMkZxZ2RqS25N?=
 =?utf-8?B?czlUNzVrQUcwZXhwSld6WmdrcHJLUVV1dkdDWmwyNG9CNWZXa0M0cXlHeUJh?=
 =?utf-8?B?UllzL2ExczYzeTV6TU9IQWxrWGIySE1TQnZYY0tDZnBkQkc0V1pZN2xsSENa?=
 =?utf-8?B?U3pYcEFHUnFxaTFEbW54RFFlc2ExRU1PU3dzcERJZXovSGtDV0JrVXQ5R24r?=
 =?utf-8?B?WE5ac0c3VWk5SWNQa29rR1p4QzBoTVhOemU4d3NNRTdvTkpMT2Eyak9iRGRT?=
 =?utf-8?B?U1FxdDN2VWViNHZJWHJnSnpFZzhLK3lLYlJCVTJoeC9CeFQwTkZiNktwbUtW?=
 =?utf-8?B?bEE2a0dFb0R3eHhwQUJZb1NrY2pUTTd2Y3k1WDIxUWx4b01xVDhwVzEvc000?=
 =?utf-8?B?R3R2VmthdnBydFlQdG1jTHE4RHVCRDdES1RUd05IN2NKSWtnaW5lcnhzQzdB?=
 =?utf-8?B?Z20wY1lONVhWa2NqU2lqRitseXY2TzZiQzVGbmxRVlF2cUQvMmxZbVd0U0l1?=
 =?utf-8?B?MFF1aTlhODZBd1p3STN2TzVzdTlwTHNxVWFpajB1a3MyYldKZWpZUzNJd2Zr?=
 =?utf-8?B?Zyt0eDdxK0E2Zjl4S0JUYVM5cjM1VHhGM2lxOGl3eHQxaWtDbXNsMVdOZzU2?=
 =?utf-8?B?ZzNRaWtZZER2VHZrY2ZJS0Q4bEFZUUVrcndzZ2NjYldrRmZjUHhZSldQVkhp?=
 =?utf-8?B?cmp0UUtsNkJtV0FkMzJyMnU1eXh6VkJPUXh6bTZuQWFmellkTUc0cDgrTDVY?=
 =?utf-8?B?WmxKOFZQVDVNSDQ3WXdxUEJ6Z2ZTUm1ielpjTGVsbVo3alpBNldERnJ6cmlP?=
 =?utf-8?B?aGVZMjlpUDJveEZHY3FPK2N0Z0NnYmptSlp2RU5Vd0pDUVZGbUJRUENEUEwv?=
 =?utf-8?B?elZQTytldy9oOHlDcnQ2NFRwQ2NxNlFYVlJuN3hMVThJTk5lY3pJSVRSb3ZE?=
 =?utf-8?B?LytQWnBmU3ZTWXNjMjFwUENxbGQ2TnMxTVZkOVd5ZEltRlNiRmFLRWJNYll1?=
 =?utf-8?B?VWVDR3kwUEYxckIwM2ZVcDFpa1dzbmVzRlRMb3ZXd0hQZGJBbENWdDFOME40?=
 =?utf-8?B?aDY1WUpmcXVRVzJXUituaU40Sy9LMFhra0hQUlZwM3FWb2FJWVB0c3hSWmZE?=
 =?utf-8?B?Z0ZLbko4a1ROMXN2RlZYSEcxajdaK2NhRlB4RTY4QUVEMjFlMHZHVEt5Mkdp?=
 =?utf-8?B?UXZIWE54TDNRQmlBRU1ML2xIOUR1UFg2SVRqOFIxT2ZjTDZrRU9ianJncTYx?=
 =?utf-8?B?dkhNMnkrVW14UU1YYVhWNC9GakIrVXpIMjNjZml4dDJhVHNzR200Y1RoRDh6?=
 =?utf-8?B?UnZZUGVyenFpYk5RaWordVJzSmFhZG5GNzQ4NTBTQi9wWFZXaG5GM2lCc2RY?=
 =?utf-8?B?Q1h0SDZLQUEyaGVJKzEyMzRVTmFROG02dWE5MlJ3RnhKZEttNDRzczRsY29Q?=
 =?utf-8?B?UnNjZ3ZOczVvTjhFTjNuT0dZYmJwQ2RVUEtiRFJYL3Bjb0toSk15RGxoaGxP?=
 =?utf-8?B?U3ZTQ2dQVU5Ba3hEREptc0FQUkMvOC9LNVh3OE5Bb1Uxb0RDUE9hcmxlVU5a?=
 =?utf-8?B?amFQc0dKSlQ0V2JOeVQ1VjV4a3JpbHRkYzRBZUpvdUhkYUp1VDR6OVJRRmNO?=
 =?utf-8?Q?rWHcU8ay71cJTPiYxXOyf14=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad052fe7-2175-4be0-37cb-08d9b8bcad4c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:31:15.1770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZwuFnTOYtfaJ8ww7xrKzlOSXNUvNI2Tmy7z1kt78Vqx3PVsXqcclc5vpkbD8uSNzJLWt/g2jx80yGONhGHbP7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

From: Lasse Collin <lasse.collin@tukaani.org>

s->dict.allocated was initialized to 0 but never set after a successful
allocation, thus the code always thought that the dictionary buffer has
to be reallocated.

Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
Reported-by: Yu Sun <yusun2@cisco.com>
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Acked-by: Daniel Walker <danielwa@cisco.com>
[Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

--- a/xen/common/xz/dec_lzma2.c
+++ b/xen/common/xz/dec_lzma2.c
@@ -1146,6 +1146,7 @@ XZ_EXTERN enum xz_ret __init xz_dec_lzma
 
 		if (DEC_IS_DYNALLOC(s->dict.mode)) {
 			if (s->dict.allocated < s->dict.size) {
+				s->dict.allocated = s->dict.size;
 				large_free(s->dict.buf);
 				s->dict.buf = large_malloc(s->dict.size);
 				if (s->dict.buf == NULL) {



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:31:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:31:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238931.414103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE5n-0004pX-6h; Mon, 06 Dec 2021 13:31:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238931.414103; Mon, 06 Dec 2021 13:31:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE5n-0004pQ-3f; Mon, 06 Dec 2021 13:31:43 +0000
Received: by outflank-mailman (input) for mailman id 238931;
 Mon, 06 Dec 2021 13:31:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE5m-0001ky-5h
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:31:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d8a94c20-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:31:41 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-Ol2FtoHwM_-8VHNEUxWd3Q-1; Mon, 06 Dec 2021 14:31:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 13:31:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:31:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0005.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.21 via Frontend Transport; Mon, 6 Dec 2021 13:31:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d8a94c20-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797501;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=eAJSbOAWfHuLFcVKCx4FIX88ogDJjxq7Nkbi5ApfgJ8=;
	b=PeezM512LJkJP7h4cNygVKkhFonY3Je6x2WEN8aSQmEhnsiehzEMG2QhgXNiza/BppeEeP
	T6BddUHvwFLDY6zLCSEu9k5nIsyVpSZQkYJXTd1SOHF0ATVWkoiewBiLh9c2HAkcpzOJvo
	gzpO9fkohvOF5G6yjLhsuX2MwckvJZQ=
X-MC-Unique: Ol2FtoHwM_-8VHNEUxWd3Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BL6Nwfj6zQQmSEWMR90RZA2I9/ZNwgV2ZtLp2sg7d7iIo2pWMI1YkqnF7A+QxEuQNyiug+lch/3g2asgtYfOk78rfKfH/r4WrxTctObC9XazF18mM0r4OXkk/cIwodmAYtmzOAU3xFiA++236H3CpT4LZBfIKKlbt7q8jOihOWVEEfGs3VVvcH0X/shdsurKMGSut+AaxK48TTzdy5PhPOZiZDN9nTuCZfDBR0Vf/H3XkVM4cs8fD9oGZ2dvZ7Xnnr+dV0pmqjZEeN99k8sDtcVPo5xFqevrphvebPdYI0zxusewKt5uk0TV4rVO64uoNAqbsP9tpEiDvyjSETkwyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=eAJSbOAWfHuLFcVKCx4FIX88ogDJjxq7Nkbi5ApfgJ8=;
 b=lKgTmMKOh1UBILzYgPFB7BxMNeN/fy7Thz/68TXRqWxjcNqQKTG5gbxoJhJt+XDdNmlmYWlopnoeB6irqJVsrXcyTfc8ZzKEiqCo3ui1+0JsbKdUbakT+iNjdA6hkduM7KOUfq+trephArWcNMuw4G5dnv01wtxTV+r2z2KsTMtEgKunoeN+3s8MrgrjZPlwNMRxBOY/12urV3Gc69TBx+Y/S1yaJQicvXhJ1VpQ9VkmGyrApn/fbkAv4ZUiJ+BA59Is3jj2yBbYOXBv3hEeQtiEXpJKYv29FRwao8mZ1NDpYLMxE4V3VHasNH2M6YvP8voImGzPah3/PiQzkOD/EA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <994c93b1-1a3c-bb66-255a-ec9c1837d6ce@suse.com>
Date: Mon, 6 Dec 2021 14:31:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 3/7] decompressors: fix spelling mistakes
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0005.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bea26491-c1e8-4b98-b1fa-08d9b8bcbaec
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2829713D2A741D2047DE5A5FB36D9@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:335;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Bio5tA6h9DtxB+5cGgl5ATxPvKqniFH3dn+K1RLAqY1TW7prPZNP0VT6knJfYYJfzFE8yAW91M3AFVWOsHhvdWCGzZ0E4QFwqzayZZApX/tFXh6MuCJekCVrqV90ayvw5zWoeJWzAuN3CPbI33ZsWvJl/2KuG7arxy/0KRLDN/tcrkbNCyIgNCZnryxpOGBKYaDwwlKFCSksHiY9UD49yw+zvYBuwccDetcJYuU+KblIAr6NXpLKkk1rOX1uHyvVouczS0twMbpOq3eLjtyKlOTuTTYgsvfkOEZ+BLZ533ismR6hTND4OpDyEK9S0ia/ivAnIUXsVkCbjcof1XmslYL6I9DL1/rvhsYPNJvB2hjBDwLehzOqMF3rtTtnD3qNC9RaN5YoV2fiMiWUnk/aJiVeECFvUeElCN0sPP3YP3irM3bVdXt6rd2xTgexSp/n7VB1hto+ZUSxG/3uXBzi23Ps+pfUWsCxVinionpZ6o8FBuYMWi9U46/KesaAxNskIDedHIMHSHGvY5yQzIBvICNXoX+FESCNQv4XOZ6Kw6VE1ck78otn3CtOdTuk1vn5K3VtW3xKt9rJhG3RZPmoEbIAVftZNnKHx1twAgf98qSfmazMDtW0GzcFxwk5P6Wnt6Hwmhaaw64cVZU6mPfBKc7EVJOZVT4UzoFedv8QzjguiF30cTM+ic6AmWwpOMDzc3OURf0G3IwLCMBZFIbgxcJfmhdHc6Qh6tPRUjsgbmYGLEv4LXvueFslOVMZG+iDnNFvZ5cDKswvKIjZNwitLeamBEuNOyczA3BSB8rgbOW23NmGuESeY+YkFMsEDz0m
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(956004)(2616005)(8936002)(186003)(31686004)(8676002)(36756003)(6486002)(66476007)(316002)(6916009)(5660300002)(86362001)(31696002)(83380400001)(2906002)(26005)(4326008)(966005)(54906003)(66946007)(16576012)(508600001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VDA4Z1lYTEJOSUxoNVVDZ21SNXJ0NEY5aEZSNGQ3RXZpWUZlVFNWaXZYR2pF?=
 =?utf-8?B?dkVScmtibEJqVTE5R1hxZEwwZDlBTUF6dnZ0Um4vSm1ydkxoSXdlcy9PazR5?=
 =?utf-8?B?TGhUdU5pcUxsS2puSUt6WnU4Nll0WWJsak0rbjh0WjliamJScFRXZzloM0dz?=
 =?utf-8?B?ME5QN3Nmd2pja3grVndhVUJvR3NnQTdxUFlpR3dDVWNDWnlIUTk0VE0vdjFJ?=
 =?utf-8?B?aHNZY2xmL09wemp4a2srSXNocVBKSTJDQ0ZVb2VmKzg3b05ORUhBM2lrVnIw?=
 =?utf-8?B?L2pvZmRvK0czWWE5Uy9QdERXdEtSVE5IQkVhNDVPSSthTVVMbWVpREFGbXlI?=
 =?utf-8?B?MlhqMGlELzZzeGpEcEt4TElSVVhWSWZrUVVQc2VYU0Y2U0U1dXlqVUQzaXhX?=
 =?utf-8?B?eGRCOUI4a1owL2svL1ZKWXdDSWhZL0pBNk1zVHBrbXhkSHpSODBBVG1oUHJy?=
 =?utf-8?B?WVhtajJOU0twazltZnhxTXhFWUx2TFFNbEUwb21BdGF5bnpWNnZYZXNGZzYr?=
 =?utf-8?B?TFlvVHBsaDJhQ2lRYm5iOFRjaDloS2lISVNyMXNEbEF1bXJ4WTVieUowd2Fx?=
 =?utf-8?B?R0RPMlhTblZoTWdsRis4U0NUTXRPNGZud3dYNzZCU1VGMXljbWhnQ2ZJRjlp?=
 =?utf-8?B?NzY0bjMwcmtsYjVpQTAwOUhRdWY2bUowaVZjSlM5dkVDcmlFRDV0dXdybTdr?=
 =?utf-8?B?cHRpNG5xUHUydFl2TVJCbG81cW11L3U2Q1Q2UmhpNjY1UXZKR1RLZlRmNU9K?=
 =?utf-8?B?dmgwWVAya1NaUE51bHRSTzYzNkhYWU5vT3JnY2NabytwZkRvWGxaVERRc3lV?=
 =?utf-8?B?ekRJU2NoT1h3bHJNSWFKKzdOY2FZMnBHWWVXcnVGVzZZcHRhOE5RcVRIOHBp?=
 =?utf-8?B?VGFPYW9rN2RXaGp1Uzc0dGJVc1V6dlZ5dEllNHFPb2RmMEJWeHJNL3Ruck1H?=
 =?utf-8?B?MVNiM2dIY0xQTTlEL2tMZW5Ubmpxb01GL28yUVUxWEV0c2w0MFFVSThlbUs2?=
 =?utf-8?B?dHBKNHc3OCtPQmR0WE81SVBRckVQWDZYOWVuWEIwUmNYcmVtamgyT1RvdThh?=
 =?utf-8?B?b0xieUxFdmFPaHVMZE9DemJEcjJlZy9tWE5PRGJ2UE5TLzExRzNhTmZTb1NK?=
 =?utf-8?B?VzBRWEhyTWFScUs0bTRQa2M5bDBRT0RrWEVpdFJhVndScHNIdXRseDBRWnl1?=
 =?utf-8?B?OFFscmFqSm9Pc1U5L0xpM0JQQ1RXUTNvY3JwUGlqcFVaNGp2SUYycUJrcW42?=
 =?utf-8?B?WUovYUhsR2tVb0p5bllhbWxvSUg2cCtTc0d6NW9KY2xVK0t2TlVYdHluYmhT?=
 =?utf-8?B?Q1lpNXl2bHpBSnVFZTNOV2laVnEwWVVUN0tCNmhZQXRQR0lqTlpHSit3YnlB?=
 =?utf-8?B?dGxSa2pHTnZsMWt6TWs0Ylc5RTM0M1MrUENaWUdncXhsWGJhYkZTRWFyTlB5?=
 =?utf-8?B?ZzZWL1NqdGJaK2pIODlsYW9tZ25GRHRkTVZCdllzM0NIRTcwbUZkRnUxR2F0?=
 =?utf-8?B?ZDJtL2h1MStPaVZQaEFYajF6MGthZVBrT3VtdXFkTnJ4NmZGOTVnUkZRRDVX?=
 =?utf-8?B?aW9ZM1JJRkRsVFNzTEVDbnRMeWZYR0hWUjVJcmFtQkVmbnBRZzRGc2pRc0FO?=
 =?utf-8?B?eGVEbDJVUWppcHI4d1NBaHZwbGpnMm93bEUyR2podTNnL25WRXFMOW9qMEdo?=
 =?utf-8?B?NHVYaGlCKzAvS2U5Q0FRVnF6U2VKclFuWTNGenlMZ0pydnoyeXlObVhyMlZV?=
 =?utf-8?B?TSt6bEhOOTJEanhLY3krR2lDd0twZy9XR3VoRWpjemwzWWx1OUtqdVh4U2Mv?=
 =?utf-8?B?VTJ3eXlpdUdOajlFVGJNdHBFMDVIS0Urek1RaHBwWGRhb3JQNSs3U3h6QXlL?=
 =?utf-8?B?N1MwcHR2bEFXZEZPZGRuWHl1KzBkSS9EclRsUFZ2eFdEOHpyTE9BKy9YbkdW?=
 =?utf-8?B?aUh5eUJYcFdlbVhlazZTbmM0TGovV0NNNjEva0M2cjc1eXJTWG1pUWxLYWVU?=
 =?utf-8?B?MEI0NDdIZnBmYmswcTZqQThwV1dDT2llMVFVempvbEdrVDVuMTVzcTlNblg4?=
 =?utf-8?B?dElic0x2NFlhUTRhQ1N3VUErUFBwbmwvZ0l3RVN6ckc2RUZtbUYrTEVlbUp5?=
 =?utf-8?B?bmxtRWRNRCt3dlc4OUFxbkVxRDF0OFpxUXlKcjRHaGlYZzUxdUlKN3NHVGRq?=
 =?utf-8?Q?ojLFLOaONV/uAJKe9Y8fTOI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bea26491-c1e8-4b98-b1fa-08d9b8bcbaec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:31:38.0341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nOkXFw06gutDTV2AdGsUn8oQJ+riNUMmGV5c/1NJSQaEe5lZ6BNkwoFVJXM8AjdKweK4vVK1JA+aublu+UUiNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

From: Zhen Lei <thunder.leizhen@huawei.com>

Fix some spelling mistakes in comments:
sentinal ==> sentinel
compresed ==> compressed
immediatelly ==> immediately
dervied ==> derived
splitted ==> split
nore ==> not
independed ==> independent
asumed ==> assumed

Link: https://lkml.kernel.org/r/20210604085656.12257-1-thunder.leizhen@huawei.com
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
[Linux commit: 05911c5d964956442d17fe21db239de5a1dace4a]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

--- a/xen/common/bunzip2.c
+++ b/xen/common/bunzip2.c
@@ -73,7 +73,7 @@
 
 /* This is what we know about each Huffman coding group */
 struct group_data {
-	/* We have an extra slot at the end of limit[] for a sentinal value. */
+	/* We have an extra slot at the end of limit[] for a sentinel value. */
 	int limit[MAX_HUFCODE_BITS+1];
 	int base[MAX_HUFCODE_BITS];
 	int permute[MAX_SYMBOLS];
@@ -326,7 +326,7 @@ static int __init get_next_block(struct
 			pp <<= 1;
 			base[i+1] = pp-(t += temp[i]);
 		}
-		limit[maxLen+1] = INT_MAX; /* Sentinal value for
+		limit[maxLen+1] = INT_MAX; /* Sentinel value for
 					    * reading next sym. */
 		limit[maxLen] = pp+temp[maxLen]-1;
 		base[minLen] = 0;
--- a/xen/common/unxz.c
+++ b/xen/common/unxz.c
@@ -23,7 +23,7 @@
  * uncompressible. Thus, we must look for worst-case expansion when the
  * compressor is encoding uncompressible data.
  *
- * The structure of the .xz file in case of a compresed kernel is as follows.
+ * The structure of the .xz file in case of a compressed kernel is as follows.
  * Sizes (as bytes) of the fields are in parenthesis.
  *
  *    Stream Header (12)
--- a/xen/common/unzstd.c
+++ b/xen/common/unzstd.c
@@ -16,7 +16,7 @@
  * uncompressible. Thus, we must look for worst-case expansion when the
  * compressor is encoding uncompressible data.
  *
- * The structure of the .zst file in case of a compresed kernel is as follows.
+ * The structure of the .zst file in case of a compressed kernel is as follows.
  * Maximum sizes (as bytes) of the fields are in parenthesis.
  *
  *    Frame Header: (18)
--- a/xen/common/xz/dec_bcj.c
+++ b/xen/common/xz/dec_bcj.c
@@ -422,7 +422,7 @@ XZ_EXTERN enum xz_ret __init xz_dec_bcj_
 
 	/*
 	 * Flush pending already filtered data to the output buffer. Return
-	 * immediatelly if we couldn't flush everything, or if the next
+	 * immediately if we couldn't flush everything, or if the next
 	 * filter in the chain had already returned XZ_STREAM_END.
 	 */
 	if (s->temp.filtered > 0) {
--- a/xen/common/xz/dec_lzma2.c
+++ b/xen/common/xz/dec_lzma2.c
@@ -147,8 +147,8 @@ struct lzma_dec {
 
 	/*
 	 * LZMA properties or related bit masks (number of literal
-	 * context bits, a mask dervied from the number of literal
-	 * position bits, and a mask dervied from the number
+	 * context bits, a mask derived from the number of literal
+	 * position bits, and a mask derived from the number
 	 * position bits)
 	 */
 	uint32_t lc;
@@ -484,7 +484,7 @@ static always_inline void rc_normalize(s
 }
 
 /*
- * Decode one bit. In some versions, this function has been splitted in three
+ * Decode one bit. In some versions, this function has been split in three
  * functions so that the compiler is supposed to be able to more easily avoid
  * an extra branch. In this particular version of the LZMA decoder, this
  * doesn't seem to be a good idea (tested with GCC 3.3.6, 3.4.6, and 4.3.3
@@ -761,7 +761,7 @@ static bool_t __init lzma_main(struct xz
 }
 
 /*
- * Reset the LZMA decoder and range decoder state. Dictionary is nore reset
+ * Reset the LZMA decoder and range decoder state. Dictionary is not reset
  * here, because LZMA state may be reset without resetting the dictionary.
  */
 static void __init lzma_reset(struct xz_dec_lzma2 *s)
--- a/xen/common/zstd/huf.h
+++ b/xen/common/zstd/huf.h
@@ -131,7 +131,7 @@ typedef enum {
 	HUF_repeat_none,  /**< Cannot use the previous table */
 	HUF_repeat_check, /**< Can use the previous table but it must be checked. Note : The previous table must have been constructed by HUF_compress{1,
 			     4}X_repeat */
-	HUF_repeat_valid  /**< Can use the previous table and it is asumed to be valid */
+	HUF_repeat_valid  /**< Can use the previous table and it is assumed to be valid */
 } HUF_repeat;
 /** HUF_compress4X_repeat() :
 *   Same as HUF_compress4X_wksp(), but considers using hufTable if *repeat != HUF_repeat_none.



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:32:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:32:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238932.414115 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE67-0005OY-J0; Mon, 06 Dec 2021 13:32:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238932.414115; Mon, 06 Dec 2021 13:32:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE67-0005OR-F6; Mon, 06 Dec 2021 13:32:03 +0000
Received: by outflank-mailman (input) for mailman id 238932;
 Mon, 06 Dec 2021 13:32:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oXlf=QX=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1muE65-0001ky-Gj
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:32:01 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2d0e4a8-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:31:59 +0100 (CET)
Received: from pps.filterd (m0246629.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B6C47sG005927; 
 Mon, 6 Dec 2021 13:31:54 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3csd2y9rj2-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 06 Dec 2021 13:31:52 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B6DQ2jT054756;
 Mon, 6 Dec 2021 13:31:43 GMT
Received: from nam04-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam08lp2175.outbound.protection.outlook.com [104.47.73.175])
 by aserp3020.oracle.com with ESMTP id 3cr053dwst-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 06 Dec 2021 13:31:43 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4381.namprd10.prod.outlook.com (2603:10b6:208:1d3::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:31:41 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%5]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021
 13:31:41 +0000
Received: from [10.74.106.57] (138.3.200.57) by
 SN6PR16CA0053.namprd16.prod.outlook.com (2603:10b6:805:ca::30) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 13:31:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2d0e4a8-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=7aS3u+2gf4pMCXS+tFHbbmOSTXhOTTvkvURD2k6C/+k=;
 b=JQK9OTw9d4p051+mNAmmeBYV6eWBpPTtisFL1OS5/2FwhzftwLpT1U1vIhocegxOw1FK
 0QM4Gzt0UXRn2F7+oLS5QkxeXq1KtWzCi4jZu1ra3ZuKKDlDHTCaH7gE+7OeOMO9JGjr
 7UllCQAhRdmWY3Ryk1xuNqd3Nvh/ho1O2o9xdYAXES8h0dEjX67z+3kD23E7UT3MJBRS
 hiBA26guw62SgE0ROscvv1onXXGwQrpeXedpy79sZ3ZQDrZvdFIgk+DGC6TuSBxGa85N
 XG1E/eD7aY7wh4PVvruBn2AVLsMqYxYaarD9VREkCwuAQK+X89L0u801labfj7sgDQPH wg== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ngtOog1yQCVqKfbrxzx+flPg2D+F6PazUqyRadj9tuzzzIoLUT45jKArz0zmPPKk9qPEgoxGBXgsmVZsOO7d4b6eGHrtxgzkaiy1XRypz+FpoesD3KxTn2J9nDFVPYvin1EwDeB75vGAZdvzTwDEqy71h8BTjLeZ4JqZ1ZrYvVuel5kwBHTJJaAJae1qXjU822IPUbAp4SVSSzipgx0KNP+zrX6cvAK3V+cQ+g0G0dChonMOephOD287gW32Tb1dS8iwHKmMggE1PSDE6hdqKp1rkozCBXAQUzBR2lFbAlLEWq4soJFpNUpvyExTKNPU8bg06kdhO3u01WtNm0D3Qg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7aS3u+2gf4pMCXS+tFHbbmOSTXhOTTvkvURD2k6C/+k=;
 b=CxcrunJeFh1xWaZDzXyYBAH4UCq6Oyow/gmvq/9fKZPto/+oax/se3q82LWkrMLzz/BW893lOBKerSAAIkIao2bsaThbZFZbG/y75aF/knPFUiH2qvnL5UZY5kFkxRhkWqKAcsU/L6vtUmD6QcfAtF0oNP412t1wIHVVwuhyBOPYNpuuYFn58IO2WHepSJWTl5d05Z/EPFL1hJ1/c5L4Q/snRXvn+Bd67jmIRtewcwZCs1ARtmE5ysSrQnXqJ4cfNZfi53LidaYw/QbKQuYF7sXIN2VLn+vwGDfdlCzm/n3b/Yrqdu9VsTfmhSpiqyn42SF4CJi+GONfn5y7KahPSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=7aS3u+2gf4pMCXS+tFHbbmOSTXhOTTvkvURD2k6C/+k=;
 b=UrBGgjsY5XhtOBqQos7nsg2rvkVZ7oEx886Zkmt+M2SWd//v5wDb3yTUZNa92ZKBlujHbxhxnBOUMzl0ucI3lVlxCWVpzCG85ewSdKW4v3LVdp2FyCReL5NXJQ2kHoqNN9uPhlhevAJI7CkCxhlQ5rfbO+5bFAmiV3OdJ6RYvEM=
Message-ID: <cae0b982-99fb-e808-0ff8-2f8d175b2d6d@oracle.com>
Date: Mon, 6 Dec 2021 08:31:33 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
Content-Language: en-US
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Joe Perches <joe@perches.com>, Juergen Gross <jgross@suse.com>,
        sstabellini@kernel.org, roger.pau@citrix.com, axboe@kernel.dk
Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
 <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
 <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
 <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
 <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
 <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
 <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
 <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
 <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN6PR16CA0053.namprd16.prod.outlook.com
 (2603:10b6:805:ca::30) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 25f84b14-f19c-4041-fb2c-08d9b8bcbd02
X-MS-TrafficTypeDiagnostic: MN2PR10MB4381:EE_
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4381984A968DDAC5628444B88A6D9@MN2PR10MB4381.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	IHyWnyyCei+WbVEa8GQ5JDKI+6aVmzCzEqvOt1mRkqyYEyk/4ZByMzwFhpAdA+AKf0Ka0fdVYmlQcdVocO+AEsSlKz0eXpBrElLzzQp7AryzSk6zqHm/Lm8SZ8PjUyMgXsB6A5KGqcgsXXPbKue+9TZ7UsqRfl2GlRAcylurigN7upf4MAwOcPzsv3DPJs4MS69WynDipSMULP05TL+MvM47P9RwCN0mc8lRWnJE7u+e/7nlXHABLK5/PBMI3Mev3nNYbwjENcl5ROJiL/BJFZZAssB7/E7Tx6eEPQvY/nR0r7P5pPtbSrSlVBkeGBGAQLtkrj5+VpkISZS4O2aisUkTEculw8rN5WPfDSbI17FIeXxbAU6PYSkygtEUbgCjWtj9KUrIKEXHOG9IMCtUYtgPI3DI3oulY/btvM8jrXR2qmGSIQj1UahrGqjmxYtht7C3ja5LpFmggaRvdMH0OxCa4KhgvhlIki50JBDKVv41ku/5edmvFp42Sv6s28J8wzXke4i+f4j7nX2uXBXjpjDbVr//481nhqNek42e22dnOIHJXHOSCwToAorDpmPHD0U6AEZTrIRC/qNn7Ob8P+AXEDJF9CBNz7tjHu8Jy6SyXU6J8jywRfj51IQbQjRmiy+JbHZLdmUL1WPVBI5cq+J0gPL4ZMBTW3X6Z6CdbAmytdp+DkN7V7uGZrlfgry2z5wW1bibrGPsYSXKNks5/TUYNrMH1CX0GhVq7k/ee845nYBvTseZpeTnGfI//gCZ
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(4326008)(6486002)(6666004)(5660300002)(26005)(4744005)(36756003)(186003)(31686004)(7416002)(31696002)(8676002)(2616005)(53546011)(44832011)(66946007)(316002)(66476007)(8936002)(110136005)(66556008)(86362001)(508600001)(2906002)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VGZiWFM4K0hLSWl6VGg3aUNsSGM4am5vMmhaSkpvMmRQODJ1VTdUS3Q4Zkp2?=
 =?utf-8?B?U0VFR3BhcHhXektLbEZyS3NhdTAwZzk2OXRkTTVSVWFUTDJTRmljd3o5SkZj?=
 =?utf-8?B?VCtzMmsxUUpOOFJKRTlsZXBQODVrUitYQ0VVZG5JVzNtZ0IvbHZQUzduRkpo?=
 =?utf-8?B?ZFo0WlErMHRaSi9UaFQrNVBvYjZFMlBTeUxhVDVBNlIwTjZhYmMrcTZDbWhn?=
 =?utf-8?B?dmZtUlJsTTlmTzZ1VkltcXFzYXBZdThPMWdxSzdaNzFYclpCakwySWJBZkJK?=
 =?utf-8?B?eGdRMXVyOXpjZDgrakYrR3RvOWpqRFh1Yi9aazQ4M3ZadGMrc3FQUGQ0cUlr?=
 =?utf-8?B?M1A5ZEhDbFNBRkE5UDJwTGMxZjhOMml4UWZuelJVK2NnQnRZdTZPWVZsZ1lY?=
 =?utf-8?B?RHdQTzFHY3RBQWZCR2hDM2xkZUNjdGUvTkpyRll0eGFnYlFRekRxUyttOWlY?=
 =?utf-8?B?M2YyUnZWUCtTK3RoUXc0T1ZRamRXSlFOWG05RWNwOUJMWFZoVGRZRUtnWkRH?=
 =?utf-8?B?VXJGZldZQysxSFc3emlMUlplVGRnVWxMaTdsdUdGVERhOXE3Y21KMGdhT05U?=
 =?utf-8?B?bEUwb0VsY1lHM2NYS05manpHY3dLc1RQSVpJUmFwK00weFgzMG1DcmlvTG92?=
 =?utf-8?B?dU1XYTJjdlVSeFRlZ3hTZGIzbnBOMDdDS0h5WWN0b3c3VTY3Ums5Wjk1eTVL?=
 =?utf-8?B?UkRIbTRWaFE4eEtyK3VvTklsQk9QVzAveHBMdHB6L09mcXUzQUlNWXF0dTRW?=
 =?utf-8?B?RzU5cFROdllOYzdWUzVSQzJHM2RDQzZSL3NIWkJKKzV2LzNyZXJIZ2M2NEtE?=
 =?utf-8?B?aTNhNmp4SmF5Sm1sWHM4OFBBdHl2TmphZzRKMzBoM0cveTBxUjU1czladktk?=
 =?utf-8?B?dmJrRzVhN295WHU0WERWWHgzd2V3RE1ENHBIZ25NdkVibzB1WVpldll1N1lG?=
 =?utf-8?B?YWg0U1c4Q1AvdEVwaklFUGp6VGhtMmlab1FCZ1Jhd0I3cmZUT0l6NjNaTVRz?=
 =?utf-8?B?bGZpK3g0Ris2ZnpSQWNmTy93MkNueFdpZUY3cjd3WWVIODNyVXI3VlBodHNF?=
 =?utf-8?B?QUlycWVHSGpRVWhwbzVZWEE5YzFaRHlMdzlPUFo3Y1d1cjNucFMzWWhzSWM5?=
 =?utf-8?B?UDQzcytUMkhvRFpYb1NPVTUxclZ5cmVnSWE3V1FOVktlM00waHNNNTJneTNq?=
 =?utf-8?B?K1lJUDhXZnNUVEJpQUFlKytLdDlhbm1rWnVYaW4rNCt0RHY3VlhuOVNoanpk?=
 =?utf-8?B?eFdsYlY5NWJNNm9Ib3lqbVJFNTB5cGwrZURVd0pSYytmV2hBWWI5M0xLV0JX?=
 =?utf-8?B?d001YjVuVlZUVnhpNTJLejFsbkxybWlQd0dmVUlUZzRmRW1VKzVQTUhYSVpp?=
 =?utf-8?B?V2NLQnJaMDhibU5weGhiRDFuWlhCeHlZTmhlWlNDTG9qSStpMU5yalhpaWJN?=
 =?utf-8?B?VnVtbWVuL0ZMbjFsMU5PNDZ5MEs5azhDRHQ1N3A3WTNSQTdzSlVGekRzTVZt?=
 =?utf-8?B?eFg0ekkrVEVqK2pVR2pmRFdaSjRFem53aWhhUWMxeGhZcXpFWXk0bG5IWVZH?=
 =?utf-8?B?TGR1K0lpMTk0MGRoaTBRczhNY1VpUzhaME9TZHJTM0FwT211MTNOdElZTW1K?=
 =?utf-8?B?LzB1Z0pNUHJrUlZxNTdNbUdqcWI3WkR3N1d1UTJ4NHlPMEErZmV6ZWtKdUlp?=
 =?utf-8?B?ekh4aHBteFdFYkhvNGV4Qk1IMDBQZ1h4NDNLekVjV3F6Q3haWlhZczNsMG5B?=
 =?utf-8?B?MUVBMjFEY2JUSUxjQ3NNOXRrU2ZJM2xkTmVmZEtMU3psTFZrWDlVeDhVYnVi?=
 =?utf-8?B?UEZ0UXZrOEJJdk5xWlJjZ3g0MkhEdnFkVGIvUU1CMTFJS1FwQmMxN0dDSlFD?=
 =?utf-8?B?WUVTdGJDdTcxWXQxN3FaSzUrVnpIbzdqQWVXeGlqWVY3clZEQlhGdWYyMExI?=
 =?utf-8?B?U0tQWmlUVUZxSDRqRkE5aERWWDBsdXNoMDUxejd5L3M1LzZRWVFiU09IYWZq?=
 =?utf-8?B?VDF2aFV1ZXZMelRxWFJZVmRpaHkxZHdkKy95anN2NSt4MTdVTzgrWDhlSnFB?=
 =?utf-8?B?UzNPNlBkUzZZTk1kYm5neU9ZRmdxTDZoMlpBYStTRnJSZXpqWC9zbk9nRHgv?=
 =?utf-8?B?Lzh2bU1aODc1akJVZisxL3hBRnJPTjVnanh3Z0hscEZYOEJER3JMdGJxQmZ5?=
 =?utf-8?B?Zkg5eHVhR2VKZUgwUmpOQm52U1NZenBzcEFUTjBsNVV3Z09MOVRwYlhtNmNh?=
 =?utf-8?Q?Q1q90ShfLKuNN4dCcRNxcxvnlhLty3h5rpTd7FZsJM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f84b14-f19c-4041-fb2c-08d9b8bcbd02
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:31:41.5660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4I6r1/YPuEK4MVEjWmc9fLAQ1GcPolFnsslPpMuPNZg5jSV6zsJj+UMeCLukweIWrKKLoavVzbJHbKu6KfbhKXZ1Id4chBJkX67PTATGx/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4381
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10189 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112060083
X-Proofpoint-GUID: 7p_BFoSUyQbuIpArm8R6z-eW2QcpYcuj
X-Proofpoint-ORIG-GUID: 7p_BFoSUyQbuIpArm8R6z-eW2QcpYcuj


On 12/4/21 1:57 AM, Christophe JAILLET wrote:
>
> So, maybe adding an "official" 'bitmap_size()' (which is already existing and duplicated in a few places) would ease things.
>
> It would replace the 'nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;' and hide the implementation details of the bitmap API.
>
> Something like:
> static __always_inline size_t bitmap_size(unsigned long nr_bits)
> {
>     return BITS_TO_LONGS(nr_bits) * sizeof(long);
> }
>

Yes, I think this would be a useful helper. Should be sizeof(unsigned long) though to keep things consistent.


-boris



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:33:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:33:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238934.414126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE7F-0006CO-Uz; Mon, 06 Dec 2021 13:33:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238934.414126; Mon, 06 Dec 2021 13:33:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE7F-0006CF-Rn; Mon, 06 Dec 2021 13:33:13 +0000
Received: by outflank-mailman (input) for mailman id 238934;
 Mon, 06 Dec 2021 13:33:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE7E-0006Bt-Bv
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:33:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e3c92b1-5699-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:33:11 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2052.outbound.protection.outlook.com [104.47.12.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-tUU2hR1TO-uXqufT8ZrcKA-1; Mon, 06 Dec 2021 14:33:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:33:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:33:08 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0046.eurprd04.prod.outlook.com (2603:10a6:20b:f0::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 13:33:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e3c92b1-5699-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797590;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oa6iC2T5QUROEVeYq1WfshK6wYPb0g27s45ej1AfY/A=;
	b=maAX+bD6rTZqv999b8CMYezBC5UcaFQg+TjdqVUeS9RB+DwvmevMTsMDfhf54VO9esxEbY
	jTAdoS2MIuZbr1ugiYPZ4RxJpdmses/SfJfej3vuqJk+gVgsHGhUvre1F5abj7NTaU/HdC
	tS04RdLXOKnz9FtlylwWGjdrDcyYUc4=
X-MC-Unique: tUU2hR1TO-uXqufT8ZrcKA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Sx6ArBvDmjIXYc+m+1xoxAxezSSvaBdU8eFEGbDrM6oc0qjUnowaj8JDACb+N77BuYXmogStwNe8LACuGNsivbwLJCu15LjRlbjgjiqqpRGhulWw6GS6HW9JvhQyxFK5JhiYaz7zjj1Fz8wk4bdQeqEMr/sLDRfnLzO3u2c7awEauEhAVNXMO3XuOVnoLs0iMECeMbf8Bg7rgQtdTq9NEmXflgamS4vcdcjNVfLBwDeMwJX1BeGvEqXKoB1xKdPbUEPZNmEZslXIAuwfBbhz9uomkJYAPKGFmzdy1dUVQQPPSO8iOclDuSFjFdYZSJv7WiI9C+kocoRLiCacDaONaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oa6iC2T5QUROEVeYq1WfshK6wYPb0g27s45ej1AfY/A=;
 b=YY2ijtEuvcQou1VPWHRGyLHH2Osh4dvOygRJ2GlhAk4DMhWJ9rzgVUjwZDlqsmq/eSfpXFwHQ4wyQZlbaIl97zMFe5wsI4CAGnkgfbqP8WDGQibu2FyGyhScXklV8yvcd4ntc8b+q2jyoAFpnJP8pbt2wfFQdEvFW8shq6Cyo6k4d/pdJz9CJioTRUCfmmNkO07b/NZ+eCjsilXMSrgJ0AT/vY2yE6dnuUtkyIk6bv/8hcDPCTVN/+JHVdjJt/525/1eHYHl7cZ87YAQfszK8EgwYQhZ7sL5JhBm/zApy5xndNfYm9V8+lDCIo+gtLOTJKHtrEGYYCn5rQIcBfZ1vQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81c95433-0931-5869-499e-b8f15dfc74de@suse.com>
Date: Mon, 6 Dec 2021 14:33:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 7/7] xz: fix spelling in comments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0046.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a3e8f3d7-3856-4261-b6d1-08d9b8bcf0c4
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB574140855239959FF016AE60B36D9@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Pv/+Vv7WnhJhWTNXnPlgYkviHVbXMylfJb2fsglz9CkkXn2tFEVKAvFIgZlbUWDsXrCrMGAlAfTxv3hBWr2B2PUJnt3WR+FXP/n1rC+cb26rOTVqDQ+R6uIlNBlRrwF+7LdFVYGBN7QpyC88uV0TSUGOKKfhbZxF0Ttk1lzOkwDb+Wr+NEN3N50oX9V4uNWoDRQbL6Ra00de/6Qm55+4EZml3zW/2ysY7bu16g+JSw3hkJ9Md/P+j4EuN2A9SUXLJHF0EbUIRaFSJzHiOy6Q1YRO4/aiF9z4ov1VAeXm5S83JYtWV0evKnNm/LFO+/5guY1EuPce5FMlsneXoWPkQWCvPYWZctj7cxPpvUwDSoedMToVnmA3xoOdx9WZz1ByWq10p9gs6cmTIbYItohzA6DUtSrCb9jldAhdspFr7c3k+yDm1BpeRn/M310X/2SnLyYgc93dTMK/h26Y4WB3sT31NL5xVw4m8c9iRDY6LFjmVDj8xlYtRjCjS7Q3J0BuJrxqiZtgyyMFiG4aB8udl8YrACDOr5lJ051JdWP3l+8lQr5VwdQBAxXzWWpWzc0hBsHu3LY4SqKO0B/8w2JyJBxV8iK3dBVcqCYyoznPVQ5Yd4LN1+soJS5i714nPIYsmsBx49Dw0sWXxw8RBfWVkBochCkhTOwNEaye5+KsAFYE6ZWwUc+BdiViHIJkaliakfj3xCypZo3qs+pAmTHFEMZExnI92bY3X7k6R1pdVwVrllrhzhDLU4NY7CGAyr2waTi08LSHHKWy2Pb2I4FECmehcGqpyO7RjcYHsYAuHLR1Mumx+6GeXqD8jgHFEKuq
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(6486002)(8676002)(956004)(186003)(26005)(4326008)(2616005)(38100700002)(86362001)(31696002)(36756003)(8936002)(66946007)(66476007)(66556008)(508600001)(316002)(2906002)(5660300002)(6916009)(54906003)(16576012)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WnIwQ0Q0MUM3OEZiUnFEVE9TbG1qUUF1NUd6cTZjMEhUQ3J4b2tNVUREN2ht?=
 =?utf-8?B?QkpNT2tTaERjZGQrYWo5bERZdFpmdVhNMHpYanhpRk1iWTM3czlXVFVFYnRo?=
 =?utf-8?B?TkRXREtHRU5RODkxZGl5ZDluNWI1MmxoS25rR2FWeWNmTWNPeHo1MHl6Zk56?=
 =?utf-8?B?MFNjUWhEQnJGSmMxakdkY0cxV2RMZjNnaStNRTVzdGlHemZSY1J6SENvWVlB?=
 =?utf-8?B?YWpPMUlDSjA5aFJLN1c1MVM2NWF5Mk9JSmVkRDl3N2NjRXJOM2xwMTVPU2FB?=
 =?utf-8?B?aFpHd0ZGdnJrNmtuTXplYlFkMmxYVlI3V1o2SXhLTitUajJ6dVFaMnVLZjg2?=
 =?utf-8?B?Q2lkNnlKYm0zd2lIZDlaUS9WNFZYdjhDZGhLM2VEYTIzZnFSYnZaclNRYnlV?=
 =?utf-8?B?Zy9Rcjd0a3BCYmlwNlFpSnNWdHAxcUI2aU40Z1cySnorNTk2SXZOQzJjUXoz?=
 =?utf-8?B?OENOSElJc3lFTFZDZm5HcWVCUnZ6WTJsd1ErT1M0ZTRFdHpWNFNrTjk2RlBK?=
 =?utf-8?B?MnhpdHc5RGE4YllEalBiaWUzNTBQU0k4ZnJxTmFkdHY2bXJNRFZUK1lJQUJX?=
 =?utf-8?B?MFh3QVpLL1JDZWNqamZPQ09XRjRMRXEvTHR0TjRKUGVtMnBBZXN0UWFHWXhS?=
 =?utf-8?B?TXJxSzZ4bFZGM3prUEUyYlovRS9mSHlYRFlONWxXd1NjSlVJRG9LbjJ6VjRs?=
 =?utf-8?B?SjMvL0ttaU5WS1Q1VTBxOEFkTHlrSXU1cGtmamRKYTAvZ2w1VUpUMEpSNHdL?=
 =?utf-8?B?QjJmMHh0ZVNjcjFrenkyTVdWOWx0T0I0RU1veTNiOVlqd3RDZEdvYlI2RWFY?=
 =?utf-8?B?cW9jTlNVVWNmWUp5aElZeTFVYUpTYnhKRWJSTWRwVElsVGxDdXFhN1h5SlhU?=
 =?utf-8?B?dDU4NXUwVjdaTm44Vnp4aHVIMEF0cTJ1bXBuWkhVVUxXa00rZzBILzl3c0pR?=
 =?utf-8?B?eGFyaTlZMVlhRFJSYzVxdkU0VnBuMnAvSmRTNzFqZUxNNGpIUVpSelQ2UHRN?=
 =?utf-8?B?YndEdGpHWTZ2NHp4NEUxb04wdnBodjhtckJPUE1iWm1LQ3BlMC90NllwRVRk?=
 =?utf-8?B?cFZmWEtPZmI2ZHUyekZFQU1ObDBGaDhmTHdYd0Z4Q1R4OWVQTDZkSG5LOGta?=
 =?utf-8?B?eHZndzFCVmxNVnlSWkJIZ25FUnlvcWVCbWgvcHdsYzFkRXZlSHhnN0hZUm1S?=
 =?utf-8?B?Z1VyMGwrQXFzRUVBeklRcTZPNDZMZ3lzeWpxVnIrNlJ5c1RaVDZobE4zU1RB?=
 =?utf-8?B?WkQ1b3hSWVhMWXJZQlc1UkxNcUlsUXFBQUFpcW80Wk9uNHl5S2luRXpzMC9v?=
 =?utf-8?B?T2ZZekxwYmZSMDdVdmcvb3lZUDRpV3RDVEJMdTdGbzNIQVlpOXdSTHQxd21I?=
 =?utf-8?B?QmJWanU1a2dwQnVwUmYvaDlwaHpLb09XR2k5dXhGQXliM282M25QSy84QTF1?=
 =?utf-8?B?TjhMNmZ5NXdhVEpyMEJETmtJdXV4amZDYlZ4QnZrdnJxUmpyMW4veGNJNmdk?=
 =?utf-8?B?cHg2ZExOQWo5TTJZQUYxWmpuQW9KdGlrYURvNjliOHliaE8zaEJLSDFNaFJo?=
 =?utf-8?B?WVQ3VjVkUURxa0pKRjVsVFFCanBjdGJ1L3FFVHIwOSt3bjNRRk4va0lscW00?=
 =?utf-8?B?SSs1QlNZOUtnU24zeUlWMEpNOG80Qml3SzV4R2lOWGRHTXdVUlFRNlpKRkh1?=
 =?utf-8?B?bVQ0TnBEYm9OREhCbytoMFBPSW8xMVFNTWZLQldpYmM1MTh2Y0lVZTNNVjlT?=
 =?utf-8?B?VDkzbGpSSVl4K1p0czJ0UnI5TTZ2OWFQZ3MwMXJDQWIwN2IxMGFMWTVzTWJJ?=
 =?utf-8?B?Yko1K1dmWlNzc2NnelM5d1gzNGM0L1JsWXpUTmpvV0tUR1RqL2h4RlNqOFRt?=
 =?utf-8?B?Z290S0JqWm9JU3h2bDJId2l1ZzR3QzMyVTN3Y1BXK3lXNVZkS0t6MWNHMWJ2?=
 =?utf-8?B?TkhjUjhtWkN1NXI1eStzeS9wTE9BMDZCSXlpaTVMcEtyczkzNDlpcG54V1gy?=
 =?utf-8?B?V05yZHloZmZRVnJlVm5aaUowRDl0T1JmRVJmZ0dJRnRzRk1wSkFLRG9DRGcz?=
 =?utf-8?B?ejd1cm55enlxRE9rY0lsOWg5dVhGb3ExVjlrNHBHY2E0RUhiWTFDWWxIMkZs?=
 =?utf-8?B?RHdqNGY0aS9PQmxnQ0d0U2kzQzBtUHlKS1djYWdkWlp3S0Vpb0RpVzNHcmRS?=
 =?utf-8?Q?nLgs60UQxV/Y+aXcEafYdr8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3e8f3d7-3856-4261-b6d1-08d9b8bcf0c4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:33:08.3661
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V7UbTg+qr2Ks+qAiKGKlq69ZzcMokPvKHcUD9oVPRaZUz9iCe5eAAIwyKcvbdCBRZcatGh9DWVLi840yLxLhzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

From: Lasse Collin <lasse.collin@tukaani.org>

uncompressible -> incompressible
non-splitted -> non-split

Link: https://lore.kernel.org/r/20211010213145.17462-6-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
[Linux commit: 0a434e0a2c9f4395e4560aac22677ef25ab4afd9]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
v2: Retain one more S-o-b.

--- a/xen/common/unxz.c
+++ b/xen/common/unxz.c
@@ -20,8 +20,8 @@
  *
  * The worst case for in-place decompression is that the beginning of
  * the file is compressed extremely well, and the rest of the file is
- * uncompressible. Thus, we must look for worst-case expansion when the
- * compressor is encoding uncompressible data.
+ * incompressible. Thus, we must look for worst-case expansion when the
+ * compressor is encoding incompressible data.
  *
  * The structure of the .xz file in case of a compressed kernel is as follows.
  * Sizes (as bytes) of the fields are in parenthesis.
@@ -58,7 +58,7 @@
  * uncompressed size of the payload is in practice never less than the
  * payload size itself. The LZMA2 format would allow uncompressed size
  * to be less than the payload size, but no sane compressor creates such
- * files. LZMA2 supports storing uncompressible data in uncompressed form,
+ * files. LZMA2 supports storing incompressible data in uncompressed form,
  * so there's never a need to create payloads whose uncompressed size is
  * smaller than the compressed size.
  *
@@ -127,8 +127,8 @@
  * memeq and memzero are not used much and any remotely sane implementation
  * is fast enough. memcpy/memmove speed matters in multi-call mode, but
  * the kernel image is decompressed in single-call mode, in which only
- * memmove speed can matter and only if there is a lot of uncompressible data
- * (LZMA2 stores uncompressible chunks in uncompressed form). Thus, the
+ * memmove speed can matter and only if there is a lot of incompressible data
+ * (LZMA2 stores incompressible chunks in uncompressed form). Thus, the
  * functions below should just be kept small; it's probably not worth
  * optimizing for speed.
  */
--- a/xen/common/xz/dec_lzma2.c
+++ b/xen/common/xz/dec_lzma2.c
@@ -505,7 +505,7 @@ static always_inline void rc_normalize(s
  * functions so that the compiler is supposed to be able to more easily avoid
  * an extra branch. In this particular version of the LZMA decoder, this
  * doesn't seem to be a good idea (tested with GCC 3.3.6, 3.4.6, and 4.3.3
- * on x86). Using a non-splitted version results in nicer looking code too.
+ * on x86). Using a non-split version results in nicer looking code too.
  *
  * NOTE: This must return an int. Do not make it return a bool or the speed
  * of the code generated by GCC 3.x decreases 10-15 %. (GCC 4.3 doesn't care,



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:36:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:36:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238937.414136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE9w-0006r2-Ds; Mon, 06 Dec 2021 13:36:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238937.414136; Mon, 06 Dec 2021 13:36:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muE9w-0006qv-At; Mon, 06 Dec 2021 13:36:00 +0000
Received: by outflank-mailman (input) for mailman id 238937;
 Mon, 06 Dec 2021 13:36:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE9w-0006qp-1N
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:36:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 724cc350-5699-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:35:59 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-efPC-gXYPD-k-aF7yfLXpQ-1; Mon, 06 Dec 2021 14:35:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:35:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:35:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0077.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 13:35:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 724cc350-5699-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797758;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OwCd0k1dZADe9T46w75OhIlRsJRPbYwLRfHEwwId6XU=;
	b=MqBZfLUJ5v68pvSdw4PPY+I3xg1l4XEJZkDQu62Vj0MPFRs5+EYv+J5rLsVRuPlyS76od/
	C7jr6Dv9/ki0gewhiq8WzL5qbLrJo0NaKtWJRYIWJ5z7kJfDKMTz0w3hCtjanZt0R6fAgr
	aEvhk4TtrMWRQmoldqkEznSjl0vPaJE=
X-MC-Unique: efPC-gXYPD-k-aF7yfLXpQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EDA/qV57OVeITELoC0D4pCtwDi/5N7RNspqIfQlTlMCH1Zxnv1Cm+hNE+T+J7r1INEekgE/hKnPFDV387re3MwNdR14P7eqFlMZcAXu+iyS++DQ5cwXNBXCeylYD/JEgJxVK7RJ2SQ5JwhbKOYDPd+I3imS2CaGAxzG2mz86e5mHFmdYjrg4KBXp5D600C+hZvnoh/e4ZJOLNwvpquFozq37Jq30SNxpK3kc4J1mubG1LhVHUpixRseA4WgovW9V7jeaxTEY2kVs8sKXJGfRWn50W58HNCGnnWnFmmM31N74C8uevensF07ul1IOUAMx6n6ugyLjxe8kcN66C7p7tg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OwCd0k1dZADe9T46w75OhIlRsJRPbYwLRfHEwwId6XU=;
 b=dfqxF+S5qYCkYVtoQAUHh8YBAXyNrhoixqCqjVdNmRuvu2qOS44+b+VRv890UylKj+x/qXLi/4loeSteAw6CMOJU5JFVAnl5IpS2Kc277IzRMvDZsJCjWMiNrTAFclZgGbla2q/KOP7PF7XoCdnJ7rMUfFl3vMY9nLspRViBJRsj6ZDRVS7GG3Zwt5hWozpL/4n1lrn1kPhTUG6dYqkKNI4RdrcNoync9950XH+YpAz80lbefjcjVGCvXscXwILtoxdI5sTri+ZQkzmv5ZrN0Yqea9MUR1aXx53+XGU1iL0PwYQgn2kQNYuImLODS00toQ9VfH+EmTj6Y3TsiSgh0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <526c1f1e-3a67-91ca-a69f-0d1f5ffb2ce4@suse.com>
Date: Mon, 6 Dec 2021 14:35:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 0/7] (mainly) xz imports from Linux
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0077.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4ada3803-e281-419c-b3b6-08d9b8bd54df
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5741E42366F63727520A9624B36D9@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kkLIZUVcytpHhqNYdZdZWwCnuQRrksJsZGZLU/qTs7E4YzNtO5zKreX8gGjgykucJ1oen6c7C6xgZDoZljlrOUqCMzm3vppfKfvCLNn6scK53lqvwaY7+ja4Z7ZzJT4PQjM29LpsohKZXt6KxWqVxDn6fSdnx73v3+ai33wUNzAWRSkQOjAFHfZV5qCcb2lSHxfZQIuFwrHeHVUk9JvItPgTaoqGXhNuwFglYeYMFpCSjw1GmUXRUhVfQ3ubmnAgRk7VFmlTAXO14OZqspk8PxuzHuB5QTAySX1ko02yTUqiFXSeYIvDcXmuHQZwW+88uCGCFvn9ZUQwQX6fBIFJOSXPNx0HZPPVH47WyhataSNK6niwbsm+7srkMc6JOexNTo88XiYyFbOIAH+Jh5pBxQ13OuuTALgnYncSYEqCRnhS+hHomOHzCGMfoEZveFTbCRPuslMjBKM4oNN53KevIGL2f5u9JfP6o0K4WuZZhwIsW830AporWkga4XWpix8E99ICJSKRy4DgJrDe5epmt2P7g2DRiLRwhn7Us0oiqyDC6l6qb4vDLl4568gMESXK09iq2fEwDKIgjdEhvmw/avybZnMPTC19ES+zOkvZ6ZsYHJHBlBeHdXprviLdrVbARh9ikI5sj5QUX/cSnMzEJnjMYyfzxBN4uEFob5efIHcgef/w3EOHg1fWz3pfFyecG4WJ3QRuHH5xtV7aol+X0/lyPoSmA5boEP7YFElTBYY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(6486002)(8676002)(83380400001)(956004)(186003)(26005)(4326008)(2616005)(38100700002)(53546011)(86362001)(31696002)(36756003)(8936002)(66946007)(66476007)(66556008)(508600001)(316002)(2906002)(5660300002)(6916009)(54906003)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFZuUkNYRWk1MDdKenFETGxJaGx0ejBHM2o3ZVhLTmhQRTRMa1ZqUm9Wanh0?=
 =?utf-8?B?V0swaDAyUHFJdXh0TUp3STBnc2E3ZlY3REtScjB1T21meGk4S0RUMUpxdEhQ?=
 =?utf-8?B?Nm8rVGUwWHJWUHVHTWU0RVVjNEpmN3dDL3R1SGNSRmxHWVJpTituM2N0akhQ?=
 =?utf-8?B?dXVZRmlzOExOaEdzdWQzNFJwd0JrL0lYM1hRb3RZVmowaUJVaENDanA4aXFk?=
 =?utf-8?B?YjNSSGZsaGJrUHBCUWphSktiR0o5WGtXS21TazNOYVB1NWpPcVJUTlVqbzB0?=
 =?utf-8?B?a2Z2aGxEZU85M0ZzN3Fwb254Y0hDenF6QVEyc2dXUllQK2lNTTN3QmpuSUI4?=
 =?utf-8?B?Ni95WU1xTWRpMGtoNEJZQUZtc0hEOTg4RFk1NFFodzU2dUVzRmNiR0lZVkYz?=
 =?utf-8?B?UUJGTWRmZlArZ2hCSCtwTmhFNDNWZHYrd3NUcS81cjlJSS9GK0tYUjRKUTcr?=
 =?utf-8?B?UUVMbXRzbVZ5UDdydWIrdWdDbnB4SUdlRWcvZUl4Rk5sK005SFpsakR2VkhZ?=
 =?utf-8?B?KzFlQlpHTFBVemk1bGh0QWtUMnBFK01zOUdhYXlVQzhnZ21LYXowdnNMSnZL?=
 =?utf-8?B?VHZYSUh3Zlh2bEtDTVgrcWxUdnQwMnkwSjhOd2FYVWNSZGVGWDhES3kzd29O?=
 =?utf-8?B?RUd3elhjTWxSNWlRUDZmNmY1T0ZRSWNPdStEb0JoTTBiOG1lemlvb0RqREhz?=
 =?utf-8?B?aXl0OUxHbDNsNm5OaTBIOXlzT3VaR1d3ODNwT240aU5PdTJSQmJtMUFZRGwr?=
 =?utf-8?B?RXVRRUNqVWVMWElWZUwwYWZFYTRJaXNEd2NFZmwvZDBhUUoxY2JNQm0xTU1v?=
 =?utf-8?B?R3ZsR2VrbklWbmloVGYvSmFKa2lXNC9CaDdGY1lFY3RpUVl1VFRtMEpZbFIy?=
 =?utf-8?B?b09uYnVmZThvclptTkJUdlhvclI2SVphbUxreTFybm1teVRSWEM2N2pDRmR3?=
 =?utf-8?B?QWkzOVpHbFlYeHVkSTFzWjNJd3BZZEUwMWFDRUUrWHBPT081SkdpZWZ4SVVG?=
 =?utf-8?B?cWlZNEd4UEtlb1A4Znkwek1SSUhZN0JRWVBKNEVNTEVsMC92NDVTWjRRK0Q0?=
 =?utf-8?B?ZFJXVEc5N3FaRzVHMTNpc2tDanU0RVlHZjdHeXd1NGVLc1R5RXl3TGY2Nk1F?=
 =?utf-8?B?NWpTaC9NSjk5TWJBNXd1clovTUVNT0F1VlJzUUlYUWZvREhydzBLUjkyR0VN?=
 =?utf-8?B?SndNTVZqSTFsT2hCNSt0LzErVXd1QmlIN1ZENzVySVEyMDBZQmx3ekVUS2h0?=
 =?utf-8?B?VVo1NzVzYUo3c2RJc1ZvemVxakoxckY5dzZtcUMzUDBhcUVkWU92UU9XbDRl?=
 =?utf-8?B?enowcGZhM0tWMG9RcGNNVjIzSFliQTdQU2FxRzd4WlRVS1FQRDNpQ1I0Qy9r?=
 =?utf-8?B?YkZZTkx4Qm41VzBYOGxQZXlxNklsT1BKZk5WNFB1RXd2VS9xc1g1ajZiaDd1?=
 =?utf-8?B?SDdTU3FYblB2OVNLWkZKWmlkMFlyMjlyMGk3T2VEOEY1U2xRNVVSUG51R0NC?=
 =?utf-8?B?S3FidENnaWhNWTEyYWtGbWJKYkxSenloYURKQWFTRkhYdExjbnRlelh5R3VQ?=
 =?utf-8?B?aFZpdkxvM1EwWFZlQWZUdUY2dTVSVGR0Tkc3ZWJDbDJneHNuemZiTUFQZ2lL?=
 =?utf-8?B?TEdrdmthb0h2UWpQSktmU2RzL3c2aWdXaHRLM1VwWnRhM3VoTEppV0hMUUZW?=
 =?utf-8?B?SkpnNU8vMGZ6QWhxV2xGaDErVnErWWY1ODhRVXBzWHRUcUswMFRDVXpzU0Vw?=
 =?utf-8?B?Q3lDZXpUT0ZWNEM1a3BrSithYndENWF3ZUNoMG5GeTNCbXVDK0xyVElBZWVY?=
 =?utf-8?B?V0ZTUDJFanhWRXNSdTI0eFNBMldMb0NYZmw5WmxaUit0eERtaHBtYll1OUtq?=
 =?utf-8?B?OE84eTJZMGhsVVFvSFcra0xHRWxsbUd0TDNmZm80K1l6SFFVaWRSOWlpR3hs?=
 =?utf-8?B?MGhLWjVsOWFKUFlCY3J4Ty96NGxSVmJ6eUZiMWUvTHk5RmZ4eU1WSEQyRWto?=
 =?utf-8?B?Mm1hdmxvM3pWUlRZaDJTTk1PUEdLMWFnK0RlV1h1UGVpS05GbENuMlpHUFJ5?=
 =?utf-8?B?N0JOYzVUWmIrWnQrRGd3MTk5ZlpubWNaM2c2Qm1mY0txTHo5bDN0cUdOcGlz?=
 =?utf-8?B?RlZDM2ZkY1JOVTQ2Y0k5SGFxRzhLdFpBYnBOYmxZbUp6S2tHNkNNaXlRRVRO?=
 =?utf-8?Q?ONw7wUwiBUDHs3go6vOkRJw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ada3803-e281-419c-b3b6-08d9b8bd54df
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:35:56.3301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fj/pG6cVQzLhe61+AAyJfnvVGDpO/HgWmXLWcNK8s6cauhW4k6KAsabhdGdZc33YnlxaJAmFLK5d/zFeTivuPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

On 06.12.2021 14:29, Jan Beulich wrote:
> While going through their 5.15.3 log I did notice two changes, which made
> me go check what else we might be missing. The series here is the result.
> Linux has also updated zstd, but that includes a pretty large change which
> I'm not ready to deal with right now. Them moving closer to the upstream
> zstd sources is certainly a good thing, so I suppose sooner or later we
> will want to follow them in doing so.
> 
> The only change in v2 is the re-adding of some previously dropped S-o-b
> representing the original, documentable submission flow.

Oh, actually there was another (benign) change:

> 1: xz: add fall-through comments to a switch statement
> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
> 3: decompressors: fix spelling mistakes
> 4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
> 5: xz: fix spelling in comments
> 6: xz: move s->lzma.len = 0 initialization to lzma_reset()
> 7: xz: validate the value before assigning it to an enum variable

The last three have been switched around to match the sequence they went
into upstream Linux (IOW the order spelled out above does not match the
actual series; I'm sorry).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:37:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:37:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238949.414159 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAu-0007qm-6J; Mon, 06 Dec 2021 13:37:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238949.414159; Mon, 06 Dec 2021 13:37:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAu-0007qc-13; Mon, 06 Dec 2021 13:37:00 +0000
Received: by outflank-mailman (input) for mailman id 238949;
 Mon, 06 Dec 2021 13:36:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE6T-0001ky-UY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:32:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f2d0088e-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:32:25 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-IiH8PSerNzGGjue-maWf6A-1; Mon, 06 Dec 2021 14:32:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 6 Dec
 2021 13:32:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:32:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0100.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::41) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 13:32:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2d0088e-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797544;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rp6zR0202WWrjoyuiwHgeOxRqJmRNX0SFCkPJp8UDMs=;
	b=dmYFzTBvg4ds7ZOFlatT3jDKJbz4O+EzSgGauo3q+KTQK7KgYX4tdtNMEL4vsEhHeo78Do
	ce00qfnveTJNBX4g6x9hQ+Zx0ppASMULAxX4HOFlMpyzTJUfyFiOD5sFHpk+KISe1z3EZf
	CZOPj76iaILD66OzIbx1ftIcbjqhitE=
X-MC-Unique: IiH8PSerNzGGjue-maWf6A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WM6/Gv1euXEQC3S54uNn4M0kDCP+s0AqBUCGE6Ko5N7MGraL90j1ue5dVESzCCe8ZoDK9wQakA0bNSWF0xrHdIiDskXWxbXIwa6EY0ndEHVCOvG+KcaSam6lUSWisgGLP77vMEUNqKQhByl3US+rh/XnDp6DOM1OCRmySkZd5Gc1FYSXltHGo5We3eoaLFCqUBAEB5SgyRTTN7dz+2OobYM0x8MePygaEZSPRyTee/adk0PrhYM9RnyMKYwxoPMRIisNrJJUOtqNogKleeAAlIRWRoDvKsXksawOzEuvb/O85lIE1CzGha65Jp8WeyKRJmXM8+MHzosFFsOdCIhc0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=rp6zR0202WWrjoyuiwHgeOxRqJmRNX0SFCkPJp8UDMs=;
 b=cnGyLezyYcbt4BtrTRTBRbqLC305q3EP0ZTRN486klPyofKBrE9o0cvMXym8XJqG3AR3te3e+MMTIWLLqtZSsD6jhfWUDRqgnBMlBjQDzIokHJU7QpU88xauZjGod2YdZRnxmVAdHaV0Rr/IIyav6z+rrtIGiRDoPDUp+0whPK0kZKNALpPu22vA2Kn6ZVmZLaVKppNMMbJazsSdxtoIvOfwNh2QwZ+PHPylmFOh6GnTzaD7YwGpX8abe3+uW1lKNsvSghht/d/iBDYBjnoNecpz4pIdSBKDCfqACKmfJFUw9K7TVd7EYlRrUC0SnMLEp5U+/TqXC7zfagZFsGbQeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4c2e3dca-2fe3-704e-4bc2-c3da16d33aec@suse.com>
Date: Mon, 6 Dec 2021 14:32:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 5/7] xz: validate the value before assigning it to an enum
 variable
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0100.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb53db07-1a1a-4e13-e593-08d9b8bcd585
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2957A7F9DC5F9E33E9BD7A10B36D9@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jn8M1/oXROoBjORD06mcs5F1su68MGL91wNnu33WtmBcG8CYBoB08pjmgdWaOLmqrXR60J0bDS+T6Kamj6Yqp/rvL50fYRmzl7MOc2vCRIX5U2/to69WxkgZ5HeAMw/az9tkZWShX+ftJ9yvKh2nM9KdM3KwXY33A2GlvT3pDJYy/sUA5Out3zZ5Vm0WVdqdwgd3AduK8mfoUEHP3Mp2a38R63aMOliMsw4PhwkDe81ekblvLO+iXyva5h+vcWiEwoN7UZHlAWTQMJDBKkKlnS5jtcxpM0i8KnFdki9vkUpp6qlAKtCLKTpFyWZFidy11fI96pcg4b9pNdL/qEh7i6ncQzRn3b5xVWiM33kkbV5MD5KPlJLf/9GgfRqa2oRevTlWpkcUTWnvT8q8APBdGXFE2EIr9RFSYn6bm5EASOADeDeunmj2dLG4JCE5xUTcc+XUwCX99eB6IiPMaUpo96rTPmoK+fwVsHXyN1XTI+8FaB7Du4IVQ/Ps9nmhFJ9dQOPfoqw+M8c+07vasCJCOEBmfhBKueyZ4QOpn+aG+1AViJfvJCFmp5EgMzS4/P8TGbX36Wlb+X8dA3sJodPNZlAXXEUaDLY8UUgYXGdBP71pIgiMn/ZnhiOSCX2C7v85VS1wdQtnJhdwN40McQURumwAOEjoFE0nFFu+bxr/Wk+yC1xtQS5SZ+UvxUpFwvqk6i5erUaq1WqySBXKtRRW0RCtkScTf5zeUbVa+oQcKUgvsnKlMVEXC6gtAqs0RHfBOQ48qxrhygWTPz8SXPxVkeUnpoay8xYAbdla2ruPZr3sh4KpFVB9srNYsaquLmFM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(8676002)(36756003)(83380400001)(31696002)(16576012)(6916009)(54906003)(5660300002)(15650500001)(956004)(966005)(2616005)(2906002)(508600001)(4326008)(31686004)(86362001)(6486002)(26005)(8936002)(186003)(66946007)(38100700002)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?clM2Y1RtYUZ2djZvL1pDdk40c0Z5ci9DdWpSa2FSZk4vK1JPQzIyS3hqM1J4?=
 =?utf-8?B?TnJJOVFsVjNiVmQyTFZ6NXppVSs0L1ZUeTMyYTVOVUZvSjJzeDBKY3kyaEJ0?=
 =?utf-8?B?YWxCWXRMSngvdDlkK1JRUlBMNlJZRG84MVNqcUN4Q2tCdE53SEdxLzJBY3Nz?=
 =?utf-8?B?dEFNOWY0cXBLSisrTm5BQUdrNWFkZlltMzhOOEhOeUpGVm5OMnpDbElQMjNq?=
 =?utf-8?B?Z25UNU9UcFE1cjJOQUNIWHpKNEtsa21UaGJHc1dPMU1nbndkczVwNktESCtY?=
 =?utf-8?B?UUl6M1lzR0Ricys2SERGQWpNZUxkRUFtYjNqdU1GZUh5NGtITENqL0NzeG12?=
 =?utf-8?B?ejRvYytZd0dMWkNkU2M4WHVrQjYrOGsyTkovT1VydWtYdXErRmlhQ0x3ZFVI?=
 =?utf-8?B?NzFGT2ZtWk9IdklFdVlFcmpIOWNDWWFGUytNRXNEeCt0R2R6d0w2UnRpVGo4?=
 =?utf-8?B?WHdiaktzY0lTRU5mL0lGVXhOcDhnbmlaTVNGZmxTbzZLcjN4RXpVZnBXcTY5?=
 =?utf-8?B?a203eUh4RjExRzhiT2svbWZiM0RHMWdoK2FoaVNIMlpsVXpMdW1pUUs2cm5P?=
 =?utf-8?B?WENSOUpEVzVDeDR6NEd3N1BSUGlHMHp0eVVsTE9Hay9rdFJZaEpvQTIyM0pX?=
 =?utf-8?B?Vjh2aDRSa1YzRmpoR0JNV1pwb2RZdzlJTWduSDJjeU1wSmxoZEFBOVJGV1lp?=
 =?utf-8?B?QlluNWlwWXg1YUxSY29DRnIyWmIreDc5K0JkaURyWVZkN0ppeWowdXZIL05z?=
 =?utf-8?B?WXJxQTZxUGUxem9DYnRZSUdsOWNZQUxoVHRhYThEQ3pscXNJZE5MWFVJZ2JT?=
 =?utf-8?B?dkhYZTl6WWFDOG0zQ21SNG1CNHJzRXRZbU5FZGRQR0VtWVYzcTBkdEhPLzkx?=
 =?utf-8?B?S2VoV29YaWpUMGdDRXVrbUgwaVZPWmRqRElEaGpRZ21hR083Mll3TWVERTFI?=
 =?utf-8?B?TXVFS3F0U1dTS29TYVUrTzFJZlluMkNLQjFrOUVSOFlkZ1lIS3NtRHZ6alln?=
 =?utf-8?B?a082VUVUZUZrSDVrKzFNS0IvMDYrVXhuSzl6VzYzN2xvT2ZrZ2g4dzRKcTZp?=
 =?utf-8?B?TWZNUlZza3lVTEhhUnZ0MDNucVpTWEFoQTFwNllpOEF3TEJyVHVocVk5MzFB?=
 =?utf-8?B?Qy9yUGl6WllEYS9NTnRkYlE4Sm1YVFMyZDhkTUJNT3ZMamRhKyszUHdjNkd5?=
 =?utf-8?B?QmJPL25XNWlHOEVxc2xPY3g1QjlybkZoZGZLZE9mUFFNT3JkL050VEtaZGVn?=
 =?utf-8?B?SmtYV04zVytTa2lTVEs0Q2hjZ0xpYzhkSmFycXhZZjhGVUdaRGFnT09SRHc4?=
 =?utf-8?B?U1pjUjFwVk9NM0JYTjZhQXI4aGxaanRmNHRJaEF4b0p6Zm5halF0TUZFQ3E4?=
 =?utf-8?B?NEs3eTlZZ01ZeEpSOGNIcnZJRWJBcElBejFibURtSVR2UmdoRTZ6QkJ5cTdN?=
 =?utf-8?B?QjNmZFV6Mi9XajNrQWI5cVVhckpRWWVsVU5BM0htSFFoeHFub2wzME5kNnRE?=
 =?utf-8?B?WStnOTVUOTcvM2R4Mm1Tc055bXZMYWdSbHJVTGhoVUdud0d4Ukd3d0xHbC93?=
 =?utf-8?B?Ym82ME9rRkt5cEViN1JDaWVwOUE5Z3RMMzQ5eTBobXpEVkRVVGpGdTJ5bThq?=
 =?utf-8?B?RTRWRVQvVjZHWXhDSzZwTklmQVpqOCtxUGFkOHN2T0xGalRNWDl4TXRJUm1J?=
 =?utf-8?B?TWYySnVPZXQyTUNmcHhxbThZMWFPVTk0bS9sN3kxZmtYNDhTaGJwam1lTG9w?=
 =?utf-8?B?SzBCZ2lKYWliUVpidFh3K1Q0TVpFQkgrZEVyaHh2RUpXNEtUMXgwa1RuM3lN?=
 =?utf-8?B?WnNsaURyYnRna2I2Y0lFVXFiTmlYbjUrWExCc2pucGNGS29PUytSUm5EN21M?=
 =?utf-8?B?Ry80dUVzQVRsYXkwRnBTSWErUnBLREJqbTFZVzF3cGVQMmNjTGFIY2pmNU90?=
 =?utf-8?B?N0tZYUlRMXN4TEhBK21jU25zbUVJTGhLQ0p5MXR3WThQc20zNFFKZ0tINXlY?=
 =?utf-8?B?NnBLQmVzQmFaSktxMjdvYytTNlFPWW1hRWpZbXBvWXVRYnE1RzQwNzZBai8y?=
 =?utf-8?B?TzV2a1FXRkxFVVh5L0tWL0VmMzB4KzlqczVKbDU0VmZGWE9YQ2RhUGI3Z3Z0?=
 =?utf-8?B?bVJFNnNGVnAzVW5mMlJiWTJERC9lOHEvVHB1RlVhaEdJY0hlN2dmdkdaeXJR?=
 =?utf-8?Q?fDdit8cov0RyYKZgg+JPt0Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb53db07-1a1a-4e13-e593-08d9b8bcd585
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:32:22.6569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZHdtlcUZi4SUblvqOdliMZdFEI4DvBVzzPUb8Vbj9EPsImgOUBIhfoAdWntGcQO9Int+eqdDdCpecz/6xC/51Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

From: Lasse Collin <lasse.collin@tukaani.org>

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
[Linux commit: 4f8d7abaa413c34da9d751289849dbfb7c977d05]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
v2: Retain one more S-o-b.

--- a/xen/common/xz/dec_stream.c
+++ b/xen/common/xz/dec_stream.c
@@ -402,12 +402,12 @@ static enum xz_ret __init dec_stream_hea
 	 * we will accept other check types too, but then the check won't
 	 * be verified and a warning (XZ_UNSUPPORTED_CHECK) will be given.
 	 */
+	if (s->temp.buf[HEADER_MAGIC_SIZE + 1] > XZ_CHECK_MAX)
+		return XZ_OPTIONS_ERROR;
+
 	s->check_type = s->temp.buf[HEADER_MAGIC_SIZE + 1];
 
 #ifdef XZ_DEC_ANY_CHECK
-	if (s->check_type > XZ_CHECK_MAX)
-		return XZ_OPTIONS_ERROR;
-
 	if (s->check_type > XZ_CHECK_CRC32)
 		return XZ_UNSUPPORTED_CHECK;
 #else



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:37:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:37:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238944.414148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAo-0007Uu-SR; Mon, 06 Dec 2021 13:36:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238944.414148; Mon, 06 Dec 2021 13:36:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAo-0007Un-Ov; Mon, 06 Dec 2021 13:36:54 +0000
Received: by outflank-mailman (input) for mailman id 238944;
 Mon, 06 Dec 2021 13:36:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muEAn-0006qp-FD
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:36:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 924a5a34-5699-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:36:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4EC4B2114D;
 Mon,  6 Dec 2021 13:36:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 36BD913BAE;
 Mon,  6 Dec 2021 13:36:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id TDsXDPQRrmFAIwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 13:36:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 924a5a34-5699-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638797812; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=h4BWGVsrE4Oco0xccQ1YnIvtM6fhDzH8Kupet9TSctQ=;
	b=jWCsJdPArrYcpSzSYNI4zp4TDWKv1eQAHZEpXEqOujV+QP8P0Ss/2nVp1MH5aK4wNXB7hU
	ytokC+U79UXXShWdnNm11ici4ERHHjDT6i5hrWLIPV/WndZxhcc7xcgPPAyLxCkkhy3EIB
	Ce5VImpHVCbFQcW56kwgH8NMXhgZnxI=
To: Jonas Blixt <jonas.blixt@actia.se>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <5a2d079fe8db41338464381dd2dc9575@actia.se>
From: Juergen Gross <jgross@suse.com>
Subject: Re: XEN CAN Driver
Message-ID: <e87175c9-bf55-f79a-a910-b94d69aead86@suse.com>
Date: Mon, 6 Dec 2021 14:36:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <5a2d079fe8db41338464381dd2dc9575@actia.se>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1OkKmluj8gSLfKk0SMNcXrAO6D1rgyFmU"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1OkKmluj8gSLfKk0SMNcXrAO6D1rgyFmU
Content-Type: multipart/mixed; boundary="fYxAjp0VkgfMCsyXNbVwNe4zNdFA2kzC0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jonas Blixt <jonas.blixt@actia.se>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <e87175c9-bf55-f79a-a910-b94d69aead86@suse.com>
Subject: Re: XEN CAN Driver
References: <5a2d079fe8db41338464381dd2dc9575@actia.se>
In-Reply-To: <5a2d079fe8db41338464381dd2dc9575@actia.se>

--fYxAjp0VkgfMCsyXNbVwNe4zNdFA2kzC0
Content-Type: multipart/mixed;
 boundary="------------8A65E2AFE35C2B27B564A14A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------8A65E2AFE35C2B27B564A14A
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi,

On 06.12.21 09:31, Jonas Blixt wrote:
> Hello XEN developers,
>=20
> We're working on a virtualized CAN driver for XEN (PV-CAN) with the int=
ention to upstream the patches.
> In our project we use the PV CAN driver to expose a pysical CAN interfa=
ce to domU. We use cangw in
> dom0 for routing between the physical interface and the PV CAN interfac=
e.
>=20
> The driver implements two rings, a tx and rx ring for sending CAN frame=
s between dom0 and domU.
> It uses three interrupts, one for indicating to domU that there are fra=
mes to be processed in the tx ring,
> one for the other way around to indicate to dom0 that domU has transmit=
ted a can frame and
> the third to implement flow control in domU.
>=20
> We're unsure if we are using the RING_ -macros the way it's intended. F=
or example, before
> writing to the rx ring we want to check if there is enough available sp=
ace in that ring.
> This is how we currently do that:
>=20
>  =A0=A0=A0 if (abs(priv->rx_ring.sring->req_prod - priv->rx_ring.sring-=
>req_event)
>  =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 >=3D RING_SIZE(&priv->rx_ring)-2)=
 {
>=20
> This seems wrong but at least works. The macros we tried first (RING_FR=
EE_REQUESTS and RING_FULL)
> does not seem to work for us and that might be an indication we're not =
using the RING -macros correctly.
>=20
> The backend driver has one callback for receiving can frames from the i=
nterface in
> dom0 (pvcan_tx) and one interrupt handler for receiving frames from dom=
U (pvcan_interrupt_rx).
> The frontend driver has a similar setup.
>=20
> When we are sending frames to domU we're using the RING_GET_RESPONSE ma=
cro to allocate space
> in the tx_ring and in the frontend driver(pvcan_interrupt) we're also u=
sing the RING_GET_RESPONSE
> to receive the same frame. However in the other direction we're using R=
ING_GET_REQUEST.
> I think we needed to have this setup to get the interrupts between dom0=
 and domU.
>=20
> Should we use two different rings for full duplex communication or is o=
ne ring enough? I suppose if
> we only used one ring the RESPONSE/REQUEST macros make more sense, I im=
agine that
> the front end would always allocate and write RESPONSES and the backend=
 would allocate and write
> REQUESTS.
>=20
> Another curious thing we did to get this working is in the pvcan_interr=
upt_rx (backend). When we
> receive frames using the RING_GET_REQUEST we also call RING_GET_RESPONS=
E. This
> is the result of trial and error so I can't justify it beyond: if we di=
d not have this the ring would stall.

Basically all answers to your questions depend on the protocol used.

Is the data being sent/received by the domU put directly onto the
rings, or is it mapped via grant mappings by dom0?

Are all the requests on the rings of the same size?

Are the single requests/responses acknowledged by the other side
(I guess "yes", as I presume this is what you are referring to as
"flow control")?


Juergen


--------------8A65E2AFE35C2B27B564A14A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8A65E2AFE35C2B27B564A14A--

--fYxAjp0VkgfMCsyXNbVwNe4zNdFA2kzC0--

--1OkKmluj8gSLfKk0SMNcXrAO6D1rgyFmU
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGuEfMFAwAAAAAACgkQsN6d1ii/Ey84
eAf/YwmBNZ10yh+zifDq0pCHAivMo3K2BVFIra5MabeBq29ajeYIwJxV91eFsonOLgksMCIK95RA
hxVuYvxGvkQjYy5unDNVpV6WPenGy1yxZEDMUiQZG0id7bF0zB8gBJ5DGH4wrhB6+9KySOxtOR41
cLq0bLSmQVZDGiVBEYaExMYUdeoDTYuJqM7nKxo961Rh9cvoAjpWMV3MB9gYLHICS3LUwAyzs0yv
TdWUrX8myIRc6xZwrVyQ8zovmlHhWiaclEP0T6GIYcLzuP0gnA1kpeEJR66bliLGsiji6s49W6Sj
aALwfdaTL2M5dubOwLhdJV+iUTCJlncOlSZW/cUGRA==
=4Vjn
-----END PGP SIGNATURE-----

--1OkKmluj8gSLfKk0SMNcXrAO6D1rgyFmU--


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:37:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:37:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238951.414169 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAv-0008BC-ER; Mon, 06 Dec 2021 13:37:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238951.414169; Mon, 06 Dec 2021 13:37:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEAv-0008Ad-9m; Mon, 06 Dec 2021 13:37:01 +0000
Received: by outflank-mailman (input) for mailman id 238951;
 Mon, 06 Dec 2021 13:36:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE6t-0002vN-DM
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:32:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 019b8d4a-5699-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:32:50 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-ckVGP_caOFCRqsyow_THQw-1; Mon, 06 Dec 2021 14:32:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:32:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:32:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0020.eurprd07.prod.outlook.com (2603:10a6:20b:451::13) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 13:32:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 019b8d4a-5699-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797569;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0H0YRL04KECEnhSZHc0txOpsgQMjHkGgxeFv8W2+jqE=;
	b=D/6tE1R+cawc9hyHcLOvREHYrRaKQ8BjnPYIpTkogf+uEDfh8GBaE9HsyAMiJ/7viitO9g
	oVGTFU22erumMurarkVebqnnLzrB2slo/QBJMcMeYdzuaBSSBfrJ99j3wqdUwMwF4+30iY
	AsPHxz/r7/Agy45IKXfp8B1zJeo4b50=
X-MC-Unique: ckVGP_caOFCRqsyow_THQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UuusALwaYDo70rTqtwEigMhnhMGU3Vvh3d7lBVjX9Q10tZrOn1xr+9RL9BCE9toUlvKXSZWOwC6+wI1sbgW5T4OhalDG9woYMDTF7Qoo0E/V5oB6CVeortBtMXvyX+VNA2NVGYQ4fm69UXIgmkFzz8XIMr1U82Nkn2LfVWuiDydvJwsbz3vAiR4OXL7FdtH0ClKT+qBN/8cS7RZejGqajArztcncoOySBc3OXehbgqevhS/ArdlyM15JW1K81BmplCs98v1u4yWmzZNoj6eHIGzNVqv7Qqj8YYvAOQcc7eKta/ibKe9HJnmMZlT+YgVrTBV8nhKlRGEB0JoC2uw5Vw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0H0YRL04KECEnhSZHc0txOpsgQMjHkGgxeFv8W2+jqE=;
 b=f0uVbyaYbJzew4awXtkAUJB/GXEP+g7qkTYFwiZLvhuV2a0R9OyOGEuaZs94USVdMAkaCUrFIg8xzQ80C9ajShp1i4JKNb2nbR8HsCjFQ8ZNjEsSFq2kO64JOUIaXCjEPxKQ7NUL8wdKMlNKYitl5PK4Rcx7kQ1wamDHUCjnHPopD+uaH1HTPdM9+pKXHEwcu9YAfbsIAoANv3EBuie+fMP4ZwPC3makoJSD/d2MUvU9ejepeRD35mLDqTCurwspfDhgfZJ+dVfnbdpW0X60rmNcMdkzL8Vsiicu5emVCsGteHec1v7p5GtcTBnVnmeRATRMpxovlYXqhEV3G7Y0QA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1fdbf442-ad2c-7348-06a1-9efa47443ce4@suse.com>
Date: Mon, 6 Dec 2021 14:32:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 6/7] xz: move s->lzma.len = 0 initialization to
 lzma_reset()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0020.eurprd07.prod.outlook.com
 (2603:10a6:20b:451::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7b9101cb-262b-4af4-b7a1-08d9b8bce490
X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57413B42A037B8ABB9EC757BB36D9@VI1PR04MB5741.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:113;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mjgz4oKlgb+prCkFWc30aspYNaqSwXNJvTpbRq+eKsoBQMz/4jPlp3uX7dpEF96IrsfrbVL/WnpXNPUQSNCUYTWpHmxMAvXA05bHtlZ5RZYtSU1KS8B9Fbzd2/ubxfdXWruUu0bVfDQBfWaqPFmb4pAA6QDkvSBQ1EOxkYdmyTjX1g/BWrIrmHqGbKoex0K9yvLlZvilGnhhuuGDgZkFaVb65de4QAj59z7SeH9oiZPpI9EFrcyP8p3D8Usn1NVwKDkH63WNV8h2gAZOo9cxmLvK8aIn080bVdcYVKt8DCZAnaJszOKrJF1DPFIaGM42GCDvUsRJ/uEXdRp1q5TgeGscXd/do+EczNZgH6nwDZXvnP49mRExJMNRHHjYXp0pmcUqlYRFAA715BXERUcFaHuO8gm9M5YK7NYw73bBwxFzsPL4N4khfWLGh1JiiaHz0rqsAuAMnLqXMbeyn4JZ3f+fJXJom+BpYHQGw06TMeeA16drBRFU+RO0bjsCeKoZq3lJimZpGQByndCCxOGgvGIXtM8ZQ6QFvB5CY3qGsY4iErC2LMicK7n/F/05tEs4qt+ZKF5RJ8wQAaDeLwFDiZK+Zwzd7XsIC96jseB2ArVoCNqlkLgpt0hGHE9KWdPO2AXn54PU/o8hudfw8hGx5CA32V6IGipArjx7GL5LUBUjsLqXFmX8Mv3lT8+BteAqkTZMqsDv7WZ4PIlDm0rl+i8B9dzRfgqoEwRiZ6KZWlVoodDVTCIQRZY6tNHwDcwTIxSLh6Fw3kO/IlC8/jDfvD2+4F5ZjJb7tAD16ercUbBc/bS1Xi3AGtia9jRLB74y
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(6486002)(8676002)(956004)(186003)(26005)(4326008)(2616005)(38100700002)(86362001)(31696002)(36756003)(8936002)(66946007)(66476007)(66556008)(508600001)(316002)(2906002)(5660300002)(6916009)(54906003)(16576012)(966005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0hvVFhXNjJiZ1VhSGIrMHBiWVpKOXgzZUVBa3M3Ui9yaHAyMHNIdTVueDRs?=
 =?utf-8?B?dmkyMGY1OVlYeS84NG9YaFRQbjdTd05ZdHJNWjRQUGtSMngwNFpRem9sakNv?=
 =?utf-8?B?MFRJT3J2dllWZEUyRkNzNVRMYlg4THNXcnMzRmxDZEFucXRhYjdCckNqaWFu?=
 =?utf-8?B?NkVuQktzYmhJNUFPZ05rckdGSlJpNytLazZuWjR4Mk1FYVE3UXVUN1ZVWUpU?=
 =?utf-8?B?TXpVdmNlTDlHRnMyY1p5RHlTTXNTMUMyQmV3ckcyT1pydFJXVUVqankyN3ox?=
 =?utf-8?B?L2pSNXp3OGJKbmY5YndJcmdOOG5yb2RjVk5OUS9jdi9kc0ZDalFZUWloQ0VK?=
 =?utf-8?B?ZTJzaitDYVo3N1BaMTBlN3JhclQ4RHU5RVBoOTdjZ3dlN09vbkdGSGFKNHp2?=
 =?utf-8?B?Uk1xbHVQcjNxYmROaWs4LzhIRUZQbCtHVHJwblVZWXNXY2NiYmVzVXE5S3l4?=
 =?utf-8?B?TTliMitySHZhTUdER0FBRzUyUGxMOVpzM0tjWDl2cUc1cWdnamtKekx4aUVx?=
 =?utf-8?B?aGpPMy9zYWpGbEVtbFlXMlFkb1dBYVJRbWVxVU9lOU5WNmpVbnJHUmlsQTB0?=
 =?utf-8?B?L1FGSjhHaitWMndYckNMNEoxemdLTEcwQXVKM1hzV29VeWlsNkNaOHM0Q3A3?=
 =?utf-8?B?azFYVjVha2xVM21yY28ycm1DRUFQV2FVaW1telRpRmRyTCtKd2VRRmYxcHVC?=
 =?utf-8?B?ZjUxZjJXRGNvcDZ3S04wc2toTldKSEVnZTUwK3Y5SDg5VXFhbmJiWU9PUE9s?=
 =?utf-8?B?M3dkeXpaQW8wc1NIRTlxSk1rTkdibzd2Q3JFT1VRaVhHcmpROUc3WjJPYk9C?=
 =?utf-8?B?UnZWMzB6TnJIdlhvZHRGTEVTSTI3czNGNVdGZ0x1cWNwRHJXdUFJOEN2dEls?=
 =?utf-8?B?bjJHVTByWkF0dlBhenI0dEhRMkdGZE9lMnkzVnJMbEJsdzJEM001aE1rU1A0?=
 =?utf-8?B?eU1ia1E2NTNsRVh6NWhQRGgyVm9vYm1MMWNaVUpWREhZZ08wZ1RjZks0K001?=
 =?utf-8?B?enZ0U3hjYVRSSXQ1R0NYZ1UrU3FxQW9TNlBSUHJQaVFPS0NmVllVZHNjcWFs?=
 =?utf-8?B?NTJUOStNbVQ3NHFacGF5NHBKbkhXYmpuWkdmaUQ3SGxUYTNmbXBWSUEwZkJa?=
 =?utf-8?B?YWZsdHY2aHNiUU0xR3ZkWEJvQVg4Z0owNnA1OTRuK3dvWUpzTW9KbTVZbG9z?=
 =?utf-8?B?TE9NODhrcEpQdDFQSEhEaTIzZHlTV0t1eTJJcHhjYzM1ckJyVHIrWWV5dGFG?=
 =?utf-8?B?b1RwWmFkaEk0anJTZ1dDTnpVQUlnQVFtZStjMm9yYjFtZm5NZkVrcWU1MUNo?=
 =?utf-8?B?RGI5S3N6T3VLV290bnRMWkNTOXpHRHRoRE8xbGNQZnlMN2FPY203MzVCVWxu?=
 =?utf-8?B?OTNMVlFkZEZrbUlSMlUvbHQ0UWpSNWIvVllIRkFEbjV1MFBHSjRxc1llZmM3?=
 =?utf-8?B?NUJxMlFLbk55T3RveU1URXg0SExhMS9kVk1wTjIzdk0rL25RTFJBUStFQVZK?=
 =?utf-8?B?MDRFajQ3QnNNbDVINWg5Rmx1RG9FNEpsMlB6eDdrc3ZORlpTNUxmVHovMzVR?=
 =?utf-8?B?VCtCT0JCazZpTVhSTXQzZEhiQVZNcG53SytqQm9Jam4zUEpPMzJtQVFVK3Rn?=
 =?utf-8?B?d0ZlY25kWldMZkJKWURxNVBWSUpNY09MUElDZytPL2d5U3laRlR5bnVnb2lG?=
 =?utf-8?B?SXBoeTI3WWd0Nkx4ckp0dUVDU2J6bVNZeDVUaU9wT3J4WWFSTGh2d0J4S21a?=
 =?utf-8?B?TFdtOS9GdG1pOFQ5Wk8ycW0xUUpEK3VnRXZYNlRrZXJCUGlIcDZNa3IxNmJo?=
 =?utf-8?B?bzZhbVpoQXZpTzJySHFvcUZyTlQyWjF6NUxwNjVpdWZMSGYwOWx0VWN2QktQ?=
 =?utf-8?B?OTd6a1Z6V3VhZjNML2kyKzdLZk9yU2xrOWhBeVh4SlFHV2d4ZjFxYko1VThN?=
 =?utf-8?B?a2x6TGtNcE1FNGtVdmV0RjhmZGpxUDZkdnk1NzIrRzA5U0VveGd4cVdIY0s1?=
 =?utf-8?B?YTNPMUh5NGQ2MFRaR3FuVUsyNE0ydFNHNzgvclBJOG11UVdlMm11YXptWDRF?=
 =?utf-8?B?NTNuQ292NE9DV1RDWStDMXB4SUN5Z3JHRG1jODEyRXExSHhCM1RlN3hOa1hI?=
 =?utf-8?B?OWtjUGRjdFhUUkVWN1I5N2JlRHlkNGg3M1VTQ0k0UnZ0a2NvbjF4ejhtNzBE?=
 =?utf-8?Q?uUpcRBEdbMbH1y05WaxaQNc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9101cb-262b-4af4-b7a1-08d9b8bce490
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:32:47.9206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hrqb7I+fJYfinTvMr48BzkjUJNEpRAYF+uyCKIxI1nBYRgI+BoPqaA3wyEVY36hT90nVyCeuys/H8+UQ8jBI/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741

From: Lasse Collin <lasse.collin@tukaani.org>

It's a more logical place even if the resetting needs to be done
only once per LZMA2 stream (if lzma_reset() called in the middle
of an LZMA2 stream, .len will already be 0).

Link: https://lore.kernel.org/r/20211010213145.17462-4-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
[Linux commit: a98a25408b0e9b0264abcc3dabfafd9ff2ea1046]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
v2: Retain one more S-o-b.

--- a/xen/common/xz/dec_lzma2.c
+++ b/xen/common/xz/dec_lzma2.c
@@ -791,6 +791,7 @@ static void __init lzma_reset(struct xz_
 	s->lzma.rep1 = 0;
 	s->lzma.rep2 = 0;
 	s->lzma.rep3 = 0;
+	s->lzma.len = 0;
 
 	/*
 	 * All probabilities are initialized to the same value. This hack
@@ -1174,8 +1175,6 @@ XZ_EXTERN enum xz_ret __init xz_dec_lzma
 		}
 	}
 
-	s->lzma.len = 0;
-
 	s->lzma2.sequence = SEQ_CONTROL;
 	s->lzma2.need_dict_reset = true;
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:37:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:37:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238958.414181 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEB0-0000FS-US; Mon, 06 Dec 2021 13:37:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238958.414181; Mon, 06 Dec 2021 13:37:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEB0-0000FE-QS; Mon, 06 Dec 2021 13:37:06 +0000
Received: by outflank-mailman (input) for mailman id 238958;
 Mon, 06 Dec 2021 13:37:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muE68-0001ky-E1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:32:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e5ee144e-5698-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:32:03 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-C6k-nKTgP8C1J_jTnYD5Qw-1; Mon, 06 Dec 2021 14:32:02 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 6 Dec
 2021 13:32:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:32:00 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0164.eurprd06.prod.outlook.com (2603:10a6:20b:45c::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 13:31:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5ee144e-5698-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638797523;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dWQiEscHMitckPtyowVTpPJHsuAivRldTvGBRFOefis=;
	b=ajxz1CLmt/FHzTqXjAthCwCKhp9jHcLu1ldwV5FHSo+vY23iXkL4FZUOLsFo6lerdtqBSE
	opwPHH+rUV6U5+UXv9+ytScqeQLVv2LEcJRTDl4G/Lt56F019e2rSCkIxifAh1FLL9rH+E
	Bc0xRPqn15m264KCKNOklEgAvX5qQjE=
X-MC-Unique: C6k-nKTgP8C1J_jTnYD5Qw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H+zX6MH6j8KzjVL8+V2jneBYcmEqAH55NfIQ1Z0VUdO8VWSOAwdaWXa47EtMCwRb294F8V1hjIJvGCvMvCRI5ZBCq4CEaqTRVwJFYl4canveTG3ByhkYnZB0zhXlL5ao/gGtiaxAq3NLRDHRKD50qQBXkD7Pq9FjTISYK0fP3gChrKr45kLHnF5B98n1hUMKZ6S1esmCZn+WcCwhWXnzoWJqLxuT86O1axsjz6etWIUh3AaGQrce02v4GzGfRATkHm9WLlhmAFWNIIZBG8jUBXmyfp35CjXoISZ7tiWVLalX85lLwAy4XvNmyvlEkZ/T5vDVp8Zv6EGOJJxDicQqsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dWQiEscHMitckPtyowVTpPJHsuAivRldTvGBRFOefis=;
 b=C4lYfd5u8+rfYb4FiJJApHqJFt84lnEdLzquapTlmZmG5u+anwYt8vpLogNOGwp0LHxuHC1coFytqjZ1Sd2/9Qi1s5b8S58F1sVR9NAf/cX9BA/H48lPlU/bbNtpXO3QF34dfhSPQxnsWU6lujkICWMrMjiCCwqHEFHOOOcz8F+3Pe/abeFQMTjriXkDeTUn3OAN2K9ExlSJpgcwV5rmMrAyTWArluGZjI1rgpv22TydE6OprDSqhmlk3HFJr9R0Mmo7Xcr+XDqsxqy9Cn49tyQCeg/9OPYq/EBfODmWC1NtqsJ/jWm4xc9ThDI4nyDLCGDypXQT0U7tfk/6jXuLdw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2f04d5ea-e0ef-6750-1552-3783cbcc0125@suse.com>
Date: Mon, 6 Dec 2021 14:31:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 4/7] xz: avoid overlapping memcpy() with invalid input with
 in-place decompression
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
In-Reply-To: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0164.eurprd06.prod.outlook.com
 (2603:10a6:20b:45c::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af54db1c-8ed9-4f69-1620-08d9b8bcc851
X-MS-TrafficTypeDiagnostic: VI1PR04MB2957:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB295741F595E653930EF660DAB36D9@VI1PR04MB2957.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fJK7mQ8UQQz0ACv8kLYabRXWpjpgfAN8FidIxTcMKEa4Dg3faDcChbhSdIRNR/QNfUFHwpDc6+kq7df4hTASHV/IZHTfx7sMPepSdx1bucVu9dyOQr33hgnldnhd/UtfVvOOfdIlGfnqcy5xIngib5D4b1ehIR4vH/rpFUrh1ldph68r3b3rz0SQ0aMGHCRVNP6nsSECSx5NgDL7+1wamU3+ZR0q6yanxpLSgnRNBZTBzttyrIv7li2+6GyATI3sBcRE1gsW5nve6/DxyUg7UYQDeQirHOpAjjxD+vS9nV08i4ymYwlh0lSopY3Vs5n6a4xgBwXDX4YULsG3YTE+3js5x4sd3wN6KMKwobwRie3jFL5+Bv4H4DEPiTU2nV6GkoOINv4WG0eIh627z5c1339uBmkUY9/fe3BS5eHLBE98IxTxE+7zMD/ZVntUPgGjfawisOXBA9bfgfrG4J2nsbqkw3dft2nlT0u3zxhNP8FYq0qpaIEHpSd12W44W2veXtAWKlTMc+opjobUfyVMv19FJTVfFaK95b0hpAsHX8s57p5FDVB1WEh5Znip5prGyh9CS1q8Rke+1laKR7+Jb1mzRftRcPkPKr9i0ZLavHnLhANJE+mIG+IPox6uOM902NQ7iugFT/nL5FxQDwahu/IGSNhUj46mWpgeI4OnfWf89ii8gFN6jesG2MsUqqkZ3L5CJo1wtSOguH84az6pRaXWMisii+vmLIyvmSTB2Jf+dmec44xbo/rcdJZzRghhYwoWAQneT7ADoUC+v6IDC22l8prJX/Bo70uhcdEHuD8AZP0lVUYa0QJLiYvN1Wdi
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(8676002)(36756003)(31696002)(16576012)(6916009)(54906003)(5660300002)(956004)(966005)(2616005)(2906002)(508600001)(4326008)(31686004)(86362001)(6486002)(26005)(8936002)(186003)(66946007)(38100700002)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTF4cENrOExkZnRTblluSFZLK2hFV2E4VDlTUGFCK1VhYW8ySmtLeit2ek56?=
 =?utf-8?B?SUlFbjNTTlRTRFZacGN1dmRtTzF5VTczRVBxZTBHNkc2em9oa0hUL0J3d21T?=
 =?utf-8?B?T0hhN1B6cDJQR1dCTGVTVlloSUoycllLa3dlVEkxYUh0QXcwNUxMVVZPWHFO?=
 =?utf-8?B?WFpMRkpZUGF2Q0QySEdQN3NRTnFEMFdRMkkybzNJY3ltRkdhM3RPUisySXNX?=
 =?utf-8?B?Y01PV3JLOWZDcWc3b3JvQ0VNYmRDYzBLTmx2NFIzeEdUWUJOTFduMUxxVG1t?=
 =?utf-8?B?bSsvVDhOTGkxZ0I2eDZrMlJ1c1hzV3ptWjdjalJIWm9SMkRmdktadTQ3UDk5?=
 =?utf-8?B?NEFsSXVUWHp6M0wzcnQ1OVZVZ0dUcDdVMXoyemRlL0Q2MUJ2L1hkeEtTTXd4?=
 =?utf-8?B?TWUyMzlRUVd0MnVyVit1TWVwU0drYkVkRVBVMk1YeTZReEdhOEt2WnVmOGVN?=
 =?utf-8?B?MUtwQkQ0a3JJejZQMk5lODhIMXFyK0hlMkZabHBuRnFaei9rcUZweGFJaHoz?=
 =?utf-8?B?OXR3VG9oaFZwWWxLMVFLdmNEZ2lrbEs3bm5xK2tKZWp5a2pZamJpUS9UaW94?=
 =?utf-8?B?MXBNWjhQUnoyancyQmp0SDl0SERpUkVqUDJCUEd3RDN3b2RjZDRRY09FWUth?=
 =?utf-8?B?ZXVpRFg3c2oxRFpwZ1pRWmlhbW5DWGlJdVIraHRqbFMzS2w0ajhURUluZkpa?=
 =?utf-8?B?OGxVcWFPRHZRcVZIWndVUDU0MHVoY3RLSFRoNkorTjZMMVd0cVYxei9iWFBF?=
 =?utf-8?B?ZkxnbFl5N1I1bXBiU0xFSFdZWUtjSFFsc2ZRUzNIQmNsS3VZYS8rb2p0dlU2?=
 =?utf-8?B?aHRMODVFUHdUdTI3R3pQZmIxMElMWWdoQnBWMDdEaTljdzdEbXJtT1V2T0Ex?=
 =?utf-8?B?emZrQko5NGY5S21DeU5GYnJ2V05hSUNsc1I0c2xTRERXYWlWZE1VcW9mS0RL?=
 =?utf-8?B?eDNMdVluV2RVNTU4KytKbVI1cHI5Tk5SdjBQZVZUcnUzL3pOd1lMQUs2NEhy?=
 =?utf-8?B?aE5uUzJqNUJ0ZXBTMTVOcWRxMC9vY0g0dmNLRDJveHFaRStNOFBveGc0VmVY?=
 =?utf-8?B?aDJab1ZNenNpTTNQVnErY3IrVVZaeWJxTlE4bW1Zeld6OUdJWWJoSm1kVHVJ?=
 =?utf-8?B?eVFjeE91OWs4K0lpeDRhMlpFRUdaOXIzeE1pRkJVKzVOV2ZpbU8yN052dG9B?=
 =?utf-8?B?cUJad0hEVWxyV3g3RFZGSVl2YU9KYjgyd0ZxK1B6U3BBYXdzUkhxeHZ4S2g1?=
 =?utf-8?B?cGdEdFF3UnVnN016bDZFbnh2cloweXRxNElKRkFsbkFMOUM1d0I1b20xaUg0?=
 =?utf-8?B?UU9OVEtSNElSajhsNlNGS041VnZMZVgxWUdzMGdIVjNGSFoyK2s1RnoyL0ZI?=
 =?utf-8?B?OStXcVg5bk5KRUo2SXV4VExVd2ZGWHpCQVUybktrTEg4MUNFR2t4SWNFcEFx?=
 =?utf-8?B?N1pKUkpZNlY1MmI3OE5UaUlHdHRQNlg5WHYycEI0ZzhHakh6N2REdTdqT0Rz?=
 =?utf-8?B?cEEya2lpbW5kTDIzNkhxUmdFVTI5SzVwRCs0WjJpTjBRZmQvZjcxWlJ4UnJR?=
 =?utf-8?B?M3hhNURrRFZNNVlTYXZWVEM0NEpsQ0pDY1BiSDhUcndrQkVVKy83ZHhBZGpO?=
 =?utf-8?B?OUVoRU52aUp6cEUwZm8yOGI1d1JFbVU4a0NyeG80L1hSU2tFRDVJMHJHNVRQ?=
 =?utf-8?B?ZUVWQ0NNSmdBWkJ1Tm9JcEpLQWJTd1V4S2xXUmlSNGV6K3ZCeUxjMVdaN0t0?=
 =?utf-8?B?aWRlZ1lTOFd4cEZyVUsySGM0RjVQN1poMkI4L3NKVjBNNWUxRTM4OCtjcU1F?=
 =?utf-8?B?WjlDcEVheDllVkpDZjFIS0tXYkFmYUlteVdsdVE0YjNOaGpuM3VuWkxTZGVn?=
 =?utf-8?B?SkRjZHdVY0lqNUNBRndKdEJIZ1o0ZHE0cTM3K0F0RjcvU3FRV2VIeC9XeXl1?=
 =?utf-8?B?SlpkQjdNTUlxZTJYZy9Cald0d3duVnFFU01NYmZ6TkNXam1QNmtBdG1ROUwv?=
 =?utf-8?B?T0N4eE9pNEkrTks3V1NkSldVdHRUL0l5eU1JK1dNTWpVeWpwOWRSQTVMWURQ?=
 =?utf-8?B?RklqVmVkb0pZRERQVzJ3U3o3bTh5Y3hTb04zVWR0QkoyRjMzM0pZU3YzdnFQ?=
 =?utf-8?B?ZGVTdmxZZTZRVUtZOWhDTFNsSVdBWWNvRWROUzE4VFZ1U2RJQ2E2aENaTEJk?=
 =?utf-8?Q?DTwsdw7q236ELH6WjP46y8Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af54db1c-8ed9-4f69-1620-08d9b8bcc851
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:32:00.5844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ieVMLoUdiuiDtRBYs+EVO47IX1iz50Qs6LPJepkHPETjfG/dPgBcZ7U62vb4oNXtLusmGsp9WipPy7eI7FLfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957

From: Lasse Collin <lasse.collin@tukaani.org>

With valid files, the safety margin described in lib/decompress_unxz.c
ensures that these buffers cannot overlap. But if the uncompressed size
of the input is larger than the caller thought, which is possible when
the input file is invalid/corrupt, the buffers can overlap. Obviously
the result will then be garbage (and usually the decoder will return
an error too) but no other harm will happen when such an over-run occurs.

This change only affects uncompressed LZMA2 chunks and so this
should have no effect on performance.

Link: https://lore.kernel.org/r/20211010213145.17462-2-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
[Linux commit: 83d3c4f22a36d005b55f44628f46cc0d319a75e8]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
---
v2: Retain one more S-o-b.

--- a/xen/common/unxz.c
+++ b/xen/common/unxz.c
@@ -127,7 +127,7 @@
  * memeq and memzero are not used much and any remotely sane implementation
  * is fast enough. memcpy/memmove speed matters in multi-call mode, but
  * the kernel image is decompressed in single-call mode, in which only
- * memcpy speed can matter and only if there is a lot of uncompressible data
+ * memmove speed can matter and only if there is a lot of uncompressible data
  * (LZMA2 stores uncompressible chunks in uncompressed form). Thus, the
  * functions below should just be kept small; it's probably not worth
  * optimizing for speed.
--- a/xen/common/xz/dec_lzma2.c
+++ b/xen/common/xz/dec_lzma2.c
@@ -387,7 +387,14 @@ static void __init dict_uncompressed(str
 
 		*left -= copy_size;
 
-		memcpy(dict->buf + dict->pos, b->in + b->in_pos, copy_size);
+		/*
+		 * If doing in-place decompression in single-call mode and the
+		 * uncompressed size of the file is larger than the caller
+		 * thought (i.e. it is invalid input!), the buffers below may
+		 * overlap and cause undefined behavior with memcpy().
+		 * With valid inputs memcpy() would be fine here.
+		 */
+		memmove(dict->buf + dict->pos, b->in + b->in_pos, copy_size);
 		dict->pos += copy_size;
 
 		if (dict->full < dict->pos)
@@ -397,7 +404,11 @@ static void __init dict_uncompressed(str
 			if (dict->pos == dict->end)
 				dict->pos = 0;
 
-			memcpy(b->out + b->out_pos, b->in + b->in_pos,
+			/*
+			 * Like above but for multi-call mode: use memmove()
+			 * to avoid undefined behavior with invalid input.
+			 */
+			memmove(b->out + b->out_pos, b->in + b->in_pos,
 					copy_size);
 		}
 
@@ -421,6 +432,12 @@ static uint32_t __init dict_flush(struct
 		if (dict->pos == dict->end)
 			dict->pos = 0;
 
+		/*
+		 * These buffers cannot overlap even if doing in-place
+		 * decompression because in multi-call mode dict->buf
+		 * has been allocated by us in this file; it's not
+		 * provided by the caller like in single-call mode.
+		 */
 		memcpy(b->out + b->out_pos, dict->buf + dict->start,
 				copy_size);
 	}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:38:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:38:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238973.414192 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muECe-0001i2-E8; Mon, 06 Dec 2021 13:38:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238973.414192; Mon, 06 Dec 2021 13:38:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muECe-0001hv-9C; Mon, 06 Dec 2021 13:38:48 +0000
Received: by outflank-mailman (input) for mailman id 238973;
 Mon, 06 Dec 2021 13:38:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3Xlh=QX=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muECd-0001hg-H2
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:38:47 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d4d2d159-5699-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:38:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4d2d159-5699-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638797926;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=6oMmZ8HEgzBLe2fLCyP3ITktUGqesp5ZKkUue/5pPCw=;
  b=QRlDgFxxj26+a7XSbAbXacGLi1NLrE7nuh4NSOgdXWvySm5jz8dw3MLI
   mlgMcS9jzDHtubny+M44J2VmoQ7o8F+ElioScdne0r5np1Ss6xzT3g0m1
   iYEpXlVxOB1Z/v5lPUP+slXjF8xIMcA3hCDZZ8P21XtaGT+rQDGEjSOUL
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: tlTJxcwR8AbYtJyTpjGo0Pkh/WsShdyJCJfDD0UNxjIB2hqhbpmgjkTWVKzefjRwOKxNAjdHSn
 Ar6TFbmeMOWalMI9w30orSGt8CE8F8G6bfhjvN80Kz6r9+aI+wqZByo6UIjmqX0Tg6HFcbkyeq
 l2r6xWrF1zCqTic0/IE0iRlT3VYe9c8zH7a2qfL2WNFshR9Sypm9ZphIu9p1wZEBwRULSIOpjR
 M7dxGmwsXFVcDmU+zItu6pWTx9/fwc55QdHw8XZy1/c6YbUT0EDeW54Nz1K5ZJ2BpiOY1dZfIx
 8wlqEZaP+zU+28nChD6Rp0Ry
X-SBRS: 4.0
X-MesageID: 59744673
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DDlvNqCLCZOGTBVW/xLkw5YqxClBgxIJ4kV8jS/XYbTApDwmhjUBx
 jRNDGmCOK3cajehfIp+atu/8kgPvZfWnNIxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/jC+jhdNK4
 9V0qL+aa1x0favcucItakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFjWhs2p4RRp4yY
 eIabBtJQhaQZyESFWsJKYBhs8L4in7gJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiHmelAQfYPFQKvAZwiPWl+nS8ye/NlFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4gDGJGT9bxgbQ+0RqmBNzDJrVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtAPumAjfh03bZZsldrVj
 Kn741k5CHh7ZiTCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2l3tW+I8mbcyjp/hR+ebHOiL9pHZsGAfmU93VG4vY+liIq
 IgGaJPRo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7r8aPfVhrHn8PEfjUze9zcoBphf0NxOzJ4
 mu8SglTz1+m3S/LLgCDa3ZCbrLzXMkg8SJnbHJ0ZVv4iWI+ZYuP7bsEc8dld7cQ6+E+n+V/S
 OMIepvcD60XGCjH4TkUcbL0sJdmKEawnQuLMif8OGo/cpdsShbn4NjhegezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeIRy+/pJrJir9iu4MD/sNcRiTlCGH0
 wu2AAsDobWfqYEC79SU17uPqJ2kErUiExMCTXXb97u/KQLT4nGnnd1bSO+NcD3QCDH09aGla
 bkHxv3wKqRazlNDso46GLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeaOeAN87SGVIMIBYoM7aY3vYOlziOtfk4LS0WPsOsEGZrhamKAySxtQ==
IronPort-HdrOrdr: A9a23:M5pKkKCg7hR4+kblHehusceALOsnbusQ8zAXPh9KKCC9I/b3qy
 nxppsmPH7P+XgssRQb+exoV5PwOU80maQFhLX5eI3SITUO21HYbb2Kj7GSuAEIcheWnoU2uM
 sQENkdNDSzNykBsS+Q2njeLz9U+qj/zEnev5a5854Cd3APV0hI1XYHNi+rVmlNACVWD5swE5
 SRouBdoSC7RHgRZsOnQlEYQunqvbTw5dLbSC9DIyRixBiFjDuu5rK/OQOfxA0iXzRGxqpn2X
 TZkjb++r6ov5iAu1zhPi7ontZrcenau59+7f+3+48owwDX+0OVjN4IYcz9gNl6mpDo1L9gqq
 ixn/5pBbUD15qWRBDtnfMosDOQiwrHLBTZuAelaDLY0LzErGdTMbsyuatJNhTe8EYup9d6ze
 ZC2H+YrYNeCVfakD36/MWgbWAkqqOYmwturQcotQ0SbWLeUs4ZkaUPuEdOVJsQFiPz744qVO
 FoEcHH/f5TNUiXanjI11MfiuBFdhwIb2K7qmFrgL3n79GXpgEz86I1/r1pop4wzuN0d3Af3Z
 WxDk1BrsA5cvMr
X-IronPort-AV: E=Sophos;i="5.87,291,1631592000"; 
   d="scan'208";a="59744673"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/irq: Improve local_irq_restore() code generation and performance
Date: Mon, 6 Dec 2021 13:38:28 +0000
Message-ID: <20211206133828.8811-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

popf is a horribly expensive instruction, while sti is an optimised fastpath.
Switching popf for a conditional branch and sti caused an 8% perf improvement
in various linux measurements.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/include/asm-x86/system.h | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/xen/include/asm-x86/system.h b/xen/include/asm-x86/system.h
index 65e63de69a67..4be235472ecd 100644
--- a/xen/include/asm-x86/system.h
+++ b/xen/include/asm-x86/system.h
@@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index,
 })
 #define local_irq_restore(x)                                     \
 ({                                                               \
-    BUILD_BUG_ON(sizeof(x) != sizeof(long));                     \
-    asm volatile ( "pushfq\n\t"                                  \
-                   "andq %0, (%%rsp)\n\t"                        \
-                   "orq  %1, (%%rsp)\n\t"                        \
-                   "popfq"                                       \
-                   : : "i?r" ( ~X86_EFLAGS_IF ),                 \
-                       "ri" ( (x) & X86_EFLAGS_IF ) );           \
+    if ( (x) & X86_EFLAGS_IF )                                   \
+        local_irq_enable();                                      \
 })
 
 static inline int local_irq_is_enabled(void)
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:40:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:40:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238978.414203 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEEe-00034N-QF; Mon, 06 Dec 2021 13:40:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238978.414203; Mon, 06 Dec 2021 13:40:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEEe-00034G-Mw; Mon, 06 Dec 2021 13:40:52 +0000
Received: by outflank-mailman (input) for mailman id 238978;
 Mon, 06 Dec 2021 13:40:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=oXlf=QX=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1muEEc-000344-Tn
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:40:50 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1edd099e-569a-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:40:49 +0100 (CET)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B6D40pI006632; 
 Mon, 6 Dec 2021 13:40:06 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3csc72a1pr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 06 Dec 2021 13:40:06 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B6Da3pJ089851;
 Mon, 6 Dec 2021 13:40:05 GMT
Received: from nam12-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam12lp2171.outbound.protection.outlook.com [104.47.59.171])
 by aserp3020.oracle.com with ESMTP id 3cr053e60h-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 06 Dec 2021 13:40:05 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2978.namprd10.prod.outlook.com (2603:10b6:208:79::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:40:02 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%5]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021
 13:40:02 +0000
Received: from [10.74.106.57] (138.3.200.57) by
 SN6PR2101CA0026.namprd21.prod.outlook.com (2603:10b6:805:106::36) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 13:39:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1edd099e-569a-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=FTSWx2zpYLbbOuaN9PiB/j55Kh0iAWfbOK3m5GF2lPY=;
 b=cFq0LNqvpJzRYah7P4URkNIAL+F3GPgbBGJvdAJ0UGsMBS5VK/1wk6esHL4TtEbFddiD
 A+JwM95uGgPabVWA6fTYBa/JI8xyKhBoNDgxAmhrclp4HwZ5QBuLmqiiGpQgQN5qUq90
 UYctfyAwRZndKfULMbM4ea07MZye9dLZ4k+XYpSKBYo+VHchE3YvjHPcVr+5ys0hJOBc
 J0cHwtx0vYX0+DiXVnAUh7Er5hfMETCn4svi8J2xU7JKqsu43hGzsr5cFSV9Jvh8UuCv
 iMw95KXNdXAxGF8E4ORsgiuPuXA8bvvsWEk72RK/3DDzj95SoW2Z8Nr+OrlgEKlfi1jo 8Q== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IC6kIJOjoUzzLOvT73dD+gGpwmn8EPUA1kAIbjgbv70YiQvkhMTC7IzTooMZ/eT75RF01lBewR1f3kG/k/v7/YC3e3uvia6HsXpyJSqL5lLN8AKn46o44L6YTV5TpgawQm4/0Ha5O3LdnQmZKP0zGvUSPsSc7hC8kCRi1mnb7lj0smDc2qoxzTkqNwvCglxkZXeI8SarDTy7XDOZd1TPrV/tJR/zVSCinjNT7pdfiHKbb7yD5PJONoZ4WnJPULL2AOvCjn60m8HExtLJpS4C0It4D5VXlyfC2Qffj1dx2ZdzF2HYBpokUnZBzh1WlKtM5RLl4h494ougjMk5sbDkzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FTSWx2zpYLbbOuaN9PiB/j55Kh0iAWfbOK3m5GF2lPY=;
 b=EIIg6if26uQ2+5Kw5v/KM7l+rvI5grtQGaSbIv+WYNaALJtKfZvumbCW7Q/10UTiUUPA4uAoAggiEFGau3cdkH1HORj7doApyy5pmLji/+Q6POp8icChc75oUhD9T00clLy4c61Dh/tw7hgAG1QoKRDEgPmqVgwPSwRE5htokLKHbH8Z1pd0K/foLfOEoMupgh+dvvzpkUTKuTxigkTdAM2ajhvx66eDoBGSEoKJZ2oFedooIevXeiQP6fH0r2Luw34ja147sMwb20tdjBo9VScaAs/PUttZthNO+WNNTUPkPDA8Ph+WI6GlVIM+z7CwS3wIE1p7EM66K3rC+5RCYw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FTSWx2zpYLbbOuaN9PiB/j55Kh0iAWfbOK3m5GF2lPY=;
 b=Db2nm9wtiLU41o46JP4TC6M3SLK66jCv8rs8MVVXmcuzMpdiQPlbnUzOgEILckPqzV8vMvBet0tVsOBJ3yVwO9jijeZreXwyewzF6Ioy+zTeC8c5ssAqn0gGGCn5wMiKjnEJz2K3pz6QOIOYXmjayrkZxzf2CsAcNHbrxxZEBqU=
Message-ID: <5a687e9c-f375-d9cc-f781-37cd5bedacb9@oracle.com>
Date: Mon, 6 Dec 2021 08:39:53 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be
 brought up again.
Content-Language: en-US
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        "Longpeng (Mike, Cloud Infrastructure Service Product Dept.)"
 <longpeng2@huawei.com>,
        linux-kernel@vger.kernel.org,
        "Gonglei (Arei)" <arei.gonglei@huawei.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini
 <sstabellini@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20211122154714.xaoxok3fpk5bgznz@linutronix.de>
 <87y25djhaj.ffs@tglx> <4d04ea65-ea74-dcfd-5b0e-984b44f91961@oracle.com>
 <20211206112555.ubscfwwxnn5bnyte@linutronix.de>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211206112555.ubscfwwxnn5bnyte@linutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SN6PR2101CA0026.namprd21.prod.outlook.com
 (2603:10b6:805:106::36) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 320bff4b-b5fe-4841-b299-08d9b8bde7bc
X-MS-TrafficTypeDiagnostic: BL0PR10MB2978:EE_
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2978A395237B15D45F7E631B8A6D9@BL0PR10MB2978.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	Iz8VjNkWoZlUUu5M2gkdJJUMpnyt48j6FMNskSRzgEBIwJCsjtAwc3F1bKBuUXFpWNBR1nCwIQnnlmdcLPsrfyWHLYdBcuCwYbQ5xy6D7ep1p6zmv8qeMn6IXxdwhZWsK538YFix6lB7GpKZ8N2FiVUBlptCrkKKByhgVkoRmv7UJS+BCUzF0wPLkwch+3v28+cF3y0dZDzhQ2faD1SpNGvikXCYVJgj8EJIf62qcJJbrCwkHWDq7I1YGmn3yzzxkjAh6td7M1p3bclSL9S4NE8x4tCu/yoZ0hWONN0/rbA+PgRp1WPWkNpkEUWwXhIzalhigaWzYEp701eNqUuMAgy9SWObCxqeYKBT3sSJ1C42G8BW0gkehI27V2PkEWXFwqqJ5Lwq05TjUwkOPhwu4CNp1+4dF0/JSif6hDLkvyMZBA+2DwFQepBNMvz9uPr2Nt0EyfOk50Y1RREYtnT6LG6ioLqsSyt0yBFbgnhmzbLcvUjbBdJF0oDgaYUCIBQaC6ZJEfucnkWIvpG4WGOfv2YP3oetX0xQ4MgO940QoZ2dZEQy/5uF+GveUrCx5Br8K7o3aIL1PqRn+CQVjpTel4Qym4ck4fnJ3mIMMokjv0yfex9LMeif6x6CObD3uZ8ufcntT81Wg5nUjGExD2Ve64o+Zk3ZcWdsL+CfNSHGU0UH0AaSU173zQchIHim3CNSgT6daI7CRD8v7BqGK+P0td3LkOEvLByGX05KJv93ZGV3lfrK2EoHQ0f5sxn9l1xi
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(8676002)(508600001)(8936002)(4001150100001)(66946007)(38100700002)(66476007)(66556008)(6666004)(956004)(53546011)(44832011)(26005)(2616005)(186003)(36756003)(2906002)(6486002)(86362001)(5660300002)(31686004)(7416002)(316002)(54906003)(4326008)(31696002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?UUd4NXJMV1diY0o3aDdFMGlqeTBaUktsRjk3Y2FyNXJ5U0lEV09MTzNiU0hq?=
 =?utf-8?B?UjZHNk1xNSt4MjZCNXVFYU02NmE0VGJpOTZqUVA2Wlg2OXM1cmFTQ09Nd1pz?=
 =?utf-8?B?cjlmc0FBdUpKQlRHNmtSR2RvL0FDb0ZFYnU5TkhmWE9TaVhwTzRsZVhwZDll?=
 =?utf-8?B?VlRXSVdGaFlaaGFsaUVodENHUmp5VGlsblk3TG45VlFnUkErK1pXS3kvczJs?=
 =?utf-8?B?MlphZ1Y3VE1BSGxQZFpqQVZqaWZBdHFIS3ZYMkRCTE9UZVJkVmRyQnJjdHFq?=
 =?utf-8?B?QThyTUdtQzNjV2VzY1AxRktCNG9KTlpzdnlBR291ZThDYlhVSHVUQ0IveVZi?=
 =?utf-8?B?bE11dHZWVlkzMlRKdldTUjE2WXhZdFhkRE05R2JvM3BraWlpcXRwUkt6NnZL?=
 =?utf-8?B?bmZXaG8vQ2YyV28zbStWdnhaeEpCS01lMW9Pdkxvb2hBUldabmpBL1Vuelg2?=
 =?utf-8?B?V0R0NDVjaEIraHBjT3V3SW1YaTh4THhTYnpUL3RvY1lZM3FsSXNaMFd1SjNt?=
 =?utf-8?B?c2poZzJJb0tFT0locnNYZi82QmhjcU5zRS9aajZYak5QZzJCM3ZpVUNTS3lO?=
 =?utf-8?B?VlNoQ1lrUjhpU2tsb3dHU25LZUM2NkRlak84RVdFeUV3WUhldGI4UURvYkh3?=
 =?utf-8?B?T3gzZUZxNmJ1a2VwOHN4eFFJMW9iUnVyQ2tUeGwzQ1BLQXRjS0tOOUxuYURF?=
 =?utf-8?B?UGhha2l6bFR1UDNSOVJnZ2lQNlVDcUNYN0RvR2xyOEcyY24vdTJOdGl5dk5L?=
 =?utf-8?B?ampONjk1WXRWZi9mNlFmdnRVVk93VWdtSk9aMUhmc3g4Y2paZ1E4d0txRHdE?=
 =?utf-8?B?aEVVdjZRSDV4QXJhanNDN2kvZjExK05oRkJ6M1FicXF6VEFNdlN2SjNzNFhh?=
 =?utf-8?B?ZURXQzhPV0dPWFh0a3Vudy9pbzdmUUNPZGF1bXpPSi9zUFFFVzJNZ3lnbGp0?=
 =?utf-8?B?Q3FoMldHc2ovWWJRNjFOY29SZU13bHB1SzhLTmhOZUt6SjJRUHlWc3hydnRE?=
 =?utf-8?B?TXdLWjJBNExxVUhQMkhneHBQdnB3SzkvQXRsQ2IwcXBtclByWTlveVZIUWhw?=
 =?utf-8?B?ZzNMMFZMWDlTTkI4cTVFLzlPSVZkdThnd0hPdWtYdmtYb0dTR3hra2hOekFJ?=
 =?utf-8?B?Q2pGS0dJb3M2dkdXdmhUczJsWnBTMWd4cksvK2ZwbGUrME1CMTQ2bjFUNklv?=
 =?utf-8?B?UytiTURodE9iU2FFWWkxUlJZS1VmVithbVhJUGZHMFRCeGwveXRXbjZnSUZu?=
 =?utf-8?B?L0Zzdk5PRWtIUy95eEtoSlFuQmJ0bHFBUTkxcWswM21ER0ljODFrZnZFaVhy?=
 =?utf-8?B?a2syanErdnFZRFNVVFlBY05XRy9CSWFxRkcrbWZ3M2dxWUNuaXBlZGVVVnp3?=
 =?utf-8?B?ME52M1RLYmV0RzcxWWgyZU5raXpSYlZkdFBLeFJhNytNc0hxVVoyc092dndM?=
 =?utf-8?B?LzNuenNHRUc5RHRZTC9jSUh2YlN1Sm52eWxRL09DcHcrcUlTSkVPSEpuNFNt?=
 =?utf-8?B?ellZOWM4S3VSaURkSzFyYkNpQWwzbWNpRVFUV3B3eHRWSWI4Rmg3c0JtQ1N3?=
 =?utf-8?B?ZlJRTU9OQ3VLdksvUU1Cb3FTRC9uUVhqU2tSUDBzQnVKd0ltZWdHYi9GRTlp?=
 =?utf-8?B?TTFEOGUrTXhmWXByUVloN0VCM1c4SlpqYk9LY3BmNVdsZzVQek4yYXpTTEEy?=
 =?utf-8?B?aTlCWG1HZ0VVQmhaaXc2aCtVQUJZdnJMcHpWOWN5c1JFMTUxZUtiZGRmUCtN?=
 =?utf-8?B?Njl4bjNZSGdhOEs0K0I3dEd6N1k5L2ZkaGZtVDZHQjJGK0pYRHRzbE5IRXhP?=
 =?utf-8?B?cVdlb2hiaUlPQUhpY2hzOWMwWkhZQjVxY09mYXFWdnBDTXp4TDUyOTVzTjZn?=
 =?utf-8?B?ZWlZMzBGTHpRZ3JLR3ZVdUgzRWZqMEpJQnYrdmwwSWRPekVRYzBoS0lxVGJp?=
 =?utf-8?B?dHdwZmdBa0JNNHRDN29ERmJFczRnb2ZUK1phVnJjUUFCZmJjaC95Q0pLODB3?=
 =?utf-8?B?TjNoeEQrY3dWMVBMYkJtSDdCc3ZqUS93eE1JK1pFU2xEWG1VQzZ2VWVBV0RJ?=
 =?utf-8?B?SFlzVTdzY1hoVHpVSU1YK3J1bGlucWVVZ1U3TjdzWkVCcHBaWGp6WldQeHg3?=
 =?utf-8?B?b1hqRERXb0N4Ujl2amFZbUE2U2ZrQ1hvWlBnc2MwdHFRQUk0VGFEdmVQYmlY?=
 =?utf-8?B?NVFQZzF5NnRpSC92UEp6dmowcDFZR1BFbGdPWWN1RStrZllxOTZPU2JJKzMr?=
 =?utf-8?Q?uzE60qXnbkZf9r5cPVaKChwVvYh2ztyL/AR5PKKl7w=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 320bff4b-b5fe-4841-b299-08d9b8bde7bc
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:40:02.7720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pkjaqUObnPSxKDefcTwHWi/5Ke+PRss1uc4DUIp+cMtJ+q+vBI+/u1GsO8yKa6wye1IkhhJ+O54oq400EFJSxoAhEBA++kdyEw4bD9GAfRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2978
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10189 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112060084
X-Proofpoint-ORIG-GUID: 3geAe5Ak03wp3KAmWXAZp0du-t9lWZEL
X-Proofpoint-GUID: 3geAe5Ak03wp3KAmWXAZp0du-t9lWZEL


On 12/6/21 6:25 AM, Sebastian Andrzej Siewior wrote:
> On 2021-11-24 21:17:34 [-0500], Boris Ostrovsky wrote:
>> On 11/24/21 5:54 PM, Thomas Gleixner wrote:
>>> Any comment from XEN folks?
>>
>> If memory allocation in cpu_initialize_context() fails we will not be
>> able to bring up the VCPU because xen_cpu_initialized_map bit at the
>> top of that routine will already have been set. We will BUG in
>> xen_pv_cpu_up() on second (presumably successful) attempt because
>> nothing for that VCPU would be initialized. This can in principle be
>> fixed by moving allocation to the top of the routine and freeing
>> context if the bit in the bitmap is already set.
>>
>>
>> Having said that, allocation really should not fail: for PV guests we
>> first bring max number of VCPUs up and then offline them down to
>> however many need to run. I think if we fail allocation during boot we
>> are going to have a really bad day anyway.
>>
> So can we keep the patch as-is or are some changes needed?


I think for the sake of completeness we could add


diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 6a8f3b53ab83..86368fcef466 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -277,8 +277,11 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle)
                 return 0;

         ctxt = kzalloc(sizeof(*ctxt), GFP_KERNEL);
-       if (ctxt == NULL)
+       if (ctxt == NULL) {
+               cpumask_clear_cpu(cpu, xen_cpu_initialized_map);
+               cpumask_clear_cpu(cpu, cpu_callout_mask);
                 return -ENOMEM;
+       }

         gdt = get_cpu_gdt_rw(cpu);


-boris



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:44:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:44:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238986.414214 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEI5-0003mL-GF; Mon, 06 Dec 2021 13:44:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238986.414214; Mon, 06 Dec 2021 13:44:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEI5-0003mE-BG; Mon, 06 Dec 2021 13:44:25 +0000
Received: by outflank-mailman (input) for mailman id 238986;
 Mon, 06 Dec 2021 13:44:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEI4-0003m8-RU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:44:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f1158ba-569a-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:44:23 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-Gy1gicE4MD2T2FoWTTZijw-1; Mon, 06 Dec 2021 14:44:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5902.eurprd04.prod.outlook.com (2603:10a6:803:ed::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.28; Mon, 6 Dec
 2021 13:44:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:44:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0082.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 13:44:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f1158ba-569a-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638798263;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=MJFCJ+Hmy/dkB/YXnNr1iTVUpk9yYd3VJjNm55eawj0=;
	b=gNzmHkrHptFMb/HKoEFDew2qfWFLjUXSz13JpMMrmDAyJ+mpjl7Wk9j3aKY09UxhAe5WZV
	002+MQQoU/kwi+4wk/q/DXAz9+HHW7IXhm5Wmc5aOVBfi1/oLDZuPPfJleShJbr6IEjYa9
	sHnzenq2jFQIBJUf4vwTNEjJ7K5+AAc=
X-MC-Unique: Gy1gicE4MD2T2FoWTTZijw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BteJ8c849aEBVZebx0yqy/FO+s1TvAYTK7xJ6c5khE2xS/87qlHn7xBZRg2tnuhQANvrCvvNumw23/CmMry3ood826waBM7eecBmdKl9DwfLKVsfK/BNOleOh2xzZmu2aU9+4INyxWx+NPg2B0bE6q4UPga2gGu/XVmyGL0eHFd9xqvpHrW7YL2WFVb9R3YSgZt8mrlBNllPGQJvsmBM3E2LD+R1srvPKI+5LUcwWPGCCt2ql5W1NmyVXFKqYmeb67z7mGmnkBMPSluVC8FqdSFmxahv4XL5JUXzWasJf/szYaz5ZufUL/o0PeCpS9aRw2rKlaumdolNSHxK6qohhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MJFCJ+Hmy/dkB/YXnNr1iTVUpk9yYd3VJjNm55eawj0=;
 b=c4KTLORYW97xsuabWyadkMUQPEOJZtjnuHujf+NBfaBxFFqSPbDENsl6mDvSFvHmhrmtA3fAXerudA8Mv/Z86zQJnXH4rmK0pWkZ5TRkUrJRD9DkygcrQesDhdRSwbi9obdyy+2oYEDBUJZtM2p+wBuJCZECxHqr2e5FxU76U4K6Mb9tK8EYX/oP2ZvOFQze7K7fs/P4upBWuhFidCAX/hyXlcqt/Bf7ipj0J9Ig5f2aFcGIFHsZx9plaKv9OboYXc3ihRU8y4d0Q9r2s6jEdxOtudFMaGW3OTb93TqoCHSZmQyeqZ8c8tlTVmQr070idMXM0ik9yFhM0ftL4CXDhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
Date: Mon, 6 Dec 2021 14:44:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Ian Jackson <iwj@xenproject.org>
Cc: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <24992.55453.893877.246946@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0082.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c47d6114-6942-4c9c-7aed-08d9b8be8178
X-MS-TrafficTypeDiagnostic: VI1PR04MB5902:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB590273026E7A885776D7799AB36D9@VI1PR04MB5902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iwO/dhOQYikzIpndVzqr1vl3Gw2I9/KecSzB9m0UTlFbBSdO7jqNJZhuTbakpcPcjuirlTxxcZfzdhxiZd5+0O6qK7h86Jg5NPGkKhGINKh2HKBetMeJpADlY9D77hwy4N4+vVk9JJNpPXdktqavNirlgssgR6aCCIB+FSkpVQpKLSbtV12Xqr/NtQrlTfpIq3sO6O0uILCBCVUAWHdwE2hDypLO1S5z6S7khlzx1WOVIX4V7TfnFznT5zBiXEDmJWikmXaFvVWys/63XWXYNH4LJ3iyqicm7mcUCUl13jra5Skk4EC0Ojw6sFE15BcR+CrtXdHlrHb9mEOYe2HmBrdLINsBOkjmcbfnOBN9oDNYJmRvY4GsoEA9mCvo2noPCMuKa6n4NaimsBkMWJbbR50FE6LwjbPOnY196nSGSY8hu79o1Kz5XJ/HuUE7gcq41t99ktZ4OVCL+37g+j8dlECmij3wgq5sq/8Biy6JzLHYvjrmslWrM+YfbVi1diWfJt0/Y8PcuSbJ6Qpf7zCMx2A5yPoR0HlUxdi3xsR6AqcKQuD2neo8wSLMpvG2IVd329w6WckaMw83byqLMqq93U9bLv9x2ZuxfwGA5Bd7H8ZqsYUIFF5RgGv4C31hioSK/+cJnh85rr1HIIJvivO61jsV4TLagoCEQdFx/oykUWIstioRb5UH49QywofittfOH0ZthR/wo1cMSihhmrTGQiMWw8z49BxQozq8jgIjo2Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(66476007)(8936002)(6916009)(66946007)(8676002)(53546011)(956004)(2616005)(4326008)(186003)(66556008)(26005)(6486002)(5660300002)(54906003)(2906002)(316002)(16576012)(36756003)(508600001)(31696002)(86362001)(31686004)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?LzEvVzFVUGh4eFVEckhQL0JUek9aQVVFeHhpQlN6SGFLa0VaL1JkUmhBUzlW?=
 =?utf-8?B?eWJYUndraXh1SFRTeGgyUU9XUWM5TUlORWphTERHZDFrUXgxVTFJUnFPRTk2?=
 =?utf-8?B?bmptVEFyR0NkUFViUU4yYkd4cGFpL3kzKzRtbFF4S0xDd1J6N2p1TzdsZzdC?=
 =?utf-8?B?b2Z0T2pqNDM3emlDWU14Q09VVk5yWXZzTkZrV1lHK1pBS1dCbG5lWmZSdHpY?=
 =?utf-8?B?SytXcW9zMnMzNmtnZ2hpdVJ6YnYyQUxRTHVlbWtpckZ3aU5UMzZIbXFwS1hn?=
 =?utf-8?B?RXRwZlVmWkxSQ1pRdWpUR1F5aU95K2tzVDBtdkRwakVPVnVWbFdkSXFNNGxj?=
 =?utf-8?B?dW5uVmRERnF5dUtSTFoxL2N6N01mMTZDK3B1RDRoTy91b291WnVzeCtjQ0lC?=
 =?utf-8?B?bU1Wa3JCMHBxSnRqQ2xJbEJyRGs2WDNJZFllSkh5ckkxVXovMGNuQ3NQVkht?=
 =?utf-8?B?TnA1T1dTd2I3ZUJKaFZmRDdlazJQSjVNZTcvL2ZNWk41QXk2a29rVVZ0Yjda?=
 =?utf-8?B?M1ZJRGF5c0Z3Rk1Mak9MWW04SDdqa3F4dUFYNFV5K2l1YlRSeU9IRDRvN2Jy?=
 =?utf-8?B?QVZ1RjlnTDA5RmhYUzVvM0lZM0ppS2tadDJjNmUvNHAvWlViZVgyZGQxRFFW?=
 =?utf-8?B?Q0JjOXVCZDB0NkRCeXdDWDZhK3lLUmN1V0dOaDZaMFRSVjBEWW9iSFlnMFBL?=
 =?utf-8?B?RlBmajlPbk56cHVTMW1aY3AzV0V2aUdRZ3hCNm9Rck1YSUJxVUFmTEx3clhj?=
 =?utf-8?B?TDlqdGllQVR4cE1GdG1nRm9MLzlYbmJUZlJkUEVRUm1KUjJTTElmZmxkVmc2?=
 =?utf-8?B?QWR5WHBtRzdzNlhNRGJHdmYzZjJBZkJZNEtDVFhTU3ZrdjF3cjdLUlNZUDBV?=
 =?utf-8?B?YVl1SC9oSis3czZlaERyQ0JkTFBEZlBnYklJSUxqUzR5UmdLT0o4WkZqWlRU?=
 =?utf-8?B?OXpNNHd5RVRHUklWTytvdWZSK0lVNC81WU1KMDFvTGg3elhmYkdFdTJWbC83?=
 =?utf-8?B?NzhRK0l1Y3lOemtzVUNrbEtET20zL2lKejlydmxPdVovbUQ3VGNtZy9ZS3Jj?=
 =?utf-8?B?bnZSaWpyUkVWTVBobmpvUkxiMlArcTA0SlRnRnMrejZzYU5kRGdiQ0FUN0VC?=
 =?utf-8?B?TWNZSW9vZ3dMOVVkWnRtWFR0WnFvczZuSWtxSUhYd1h0a2g1T1paZzd5eHNh?=
 =?utf-8?B?eXRMY09nQkdubGtkeUY3cUljUFVmK092OXZJRVJYTzh6azNkclVhSG1xUFB3?=
 =?utf-8?B?Ulh4UDZ0cFFpbSs1R2dESXBBbHFQM0Qyam5OK0xqbjhvMnhZaG5qMldFL1Ur?=
 =?utf-8?B?N1NzdHA5ajBkNWphVlNielJoUDd6R1gzRHZjMmpleTNjbWQrZFo2NDN0MDJW?=
 =?utf-8?B?T3VlY3c5ZHQ5b0UyMm14NGxZRlZhdTc0MXpZa3VIWjFlQjc4UmZxRklJSG5q?=
 =?utf-8?B?SHdoMGRwNTlRQjgvNWIxRElZYkI5Nk5valdCSVhyWEFtbW15WkpuZHpTalJk?=
 =?utf-8?B?RG91NTB5eW5DNUVEa1ExbllMVHozYXZKS2JDZVNYdVJtaEpGM3hubzB3NGVY?=
 =?utf-8?B?UnBGSis2UUZ1a3AvNXE3Q3ExVWFKdVUxWTkyd3VYakR4OWJQRVFPeWtDVkNG?=
 =?utf-8?B?T0RnUk5KWHRJQ3hLaGYvVnFoNWNtRHowSGJKbzVSL0ZsTzhKcWErWjhySkdP?=
 =?utf-8?B?RnBwTVhydloxN2Exa0NkbXIzUXJEcXk2ZUVyMHYrdThJQmlSczhwdkhkaXZz?=
 =?utf-8?B?aXJUc2wzMzF2bjdjVGFPNTNTcXV3Wk0wcTAzZFFtVm5sY2tETE1nTUdrbVZL?=
 =?utf-8?B?bjlENFFlM2w0TGtwRndnS0o4SVcxNUZSSE5Ydk5TSGdmcDE0YjdFMVJOUXFB?=
 =?utf-8?B?TEE2TzYxVkR3USsvRlN1QjBFdC8vbGc5SmpaWGdlbXlsTHhYeGEyOFdaYnRU?=
 =?utf-8?B?Yy9xdkNnb0JUM05tY09hdFA4cWlic1RpQmEzUGNTdjlPTmZFckhESW53bDcy?=
 =?utf-8?B?RkVFWURTdnAwQ3FKTGVhU3RaK1JBNmFlYm94Szl4UW16ODUvcEczTnVKa1ZX?=
 =?utf-8?B?TlNkY3hHaDhuRktYWTdqZktNWW1ZcEx3QmE2WGZzcU1yNE9yMmRJSzdpTGhu?=
 =?utf-8?B?R2ZWMCtkUmw1b2FBbWNyc3hYM2Ixc0FNVjlCcE54dEhqbVZaREU3b0wxTG40?=
 =?utf-8?Q?vQ2HgQOHGbKVIf2sx+mei0k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c47d6114-6942-4c9c-7aed-08d9b8be8178
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:44:20.6468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fgOzgV6LtX7WoEpoimapFYamDW2Y/P4bMmv+81Pc1DG1p6G6ALRCqrr5G+PWHT5Z6RDjkHnoVVO/TxQSMPaR5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5902

On 26.11.2021 13:52, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>> On 26.11.2021 11:04, Julien Grall wrote:
>>> For this case, you provided some sort of an explanation but so far, I am 
>>> still waiting for a link to confirm that the signed-off-by match the one 
>>> on the ML.
>>
>> I haven't been able to easily find a mail archive holding this patch.
> 
> I 100% agree with Julien on all points in this thread.
> 
> Please can we keep the Linux S-o-b.
> 
> Note that S-o-b is not a chain of *approval* (whose relevance to us is
> debateable) but but a chain of *custody and transmission* for
> copyright/licence/gdpr purposes.  That latter chain is hightly
> relevant to us.
> 
> All such S-o-b should be retained.
> 
> Of course if you got the patch somewhere other than the Linux commit,
> then the chain of custody doesn't pass through the Linux commit.  But
> in that case I expect you to be able to say where you got it.

I've submitted v2 with S-o-b restored as far as necessary to meet this
requirement. I did not restore all of them, because I continue to not
see the value of retaining them. You saying "is highly relevant to us"
is a statement, but not an explanation of why tags beyond those in the
original submissions need retaining.

Without me seeing the need / value, I'm afraid I see only two ways
forward: Either things are acceptable as they are now (and will be for
future similar imports), or it needs to be someone else to put time
into spotting and then pulling in such changes.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:46:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:46:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.238991.414225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEJt-0004MP-R0; Mon, 06 Dec 2021 13:46:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 238991.414225; Mon, 06 Dec 2021 13:46:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEJt-0004MI-NO; Mon, 06 Dec 2021 13:46:17 +0000
Received: by outflank-mailman (input) for mailman id 238991;
 Mon, 06 Dec 2021 13:46:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEJt-0004MA-3f
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:46:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e21f08c3-569a-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 14:46:16 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-PJoQsTZUMxqc8g2lI-lDIQ-1; Mon, 06 Dec 2021 14:46:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7040.eurprd04.prod.outlook.com (2603:10a6:800:121::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 13:46:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:46:13 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0145.eurprd04.prod.outlook.com (2603:10a6:20b:127::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 13:46:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e21f08c3-569a-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638798375;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fM6hAJ2Gk/MdXKd56GTzhYd2Gh0RSVIo21mXClaoYUg=;
	b=MmAjfiwYZuWI10Sx1QhYPvFkmwTXM3UuBOsDZDU0VzacYmmOgQnvZDYFhWycAiL7VwpWlw
	ODErHDOS8D9LuajFvW5godqtF9Q8xfgXCx6kCeHcef9pjUXWR0xshYHuozyVBkm3MXgy5z
	esnzh3FIX2ZbNp1ST0E3jkKMbZVMVH8=
X-MC-Unique: PJoQsTZUMxqc8g2lI-lDIQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iZXX2S/2J3ODvb9nJEEwv8iyXo8yxCfMXSu+Iggt5bM+8jO9JnUnVrIlFz/9iGsOh57cX5tBInWMC+J+ZsuBsipZGtRtHm5yq+8yG3LTTMOu1Sa4pTRUTox1ErM9Jv1I9+aV1er1ncUCRL5XWSgiA5cSM0Dv8SZeim6HrHuz+njlcWv+u5oWNI5xFcJuQDlT71gV2T3Jn/J/HPSYfLOezNWlRP2ChZ7OksbvrEIEkTOcSa7bETXft4FLRnT1v1yNA4H6RoxKbIG4UEnB2BjvQeAHGRV9tCifSaWJW7BqlMthheudl2W7AX8pJzngMce3Y2AXJSCzgd1FVMhYPtPy9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fM6hAJ2Gk/MdXKd56GTzhYd2Gh0RSVIo21mXClaoYUg=;
 b=KIjESMT6ed1weWD568Iuqi99jF/5VDz65YsR2xcV927Zzi+lEWiskM/ovoWfAw20Geu/PX6f7TvnLvrdcUQzv5AZ3gXZdcbNSR/dWmDEjMPo94u60uaDx6/wcYNKeFHjht1772+Z6ubNyBnG+TjlCMGzM0HCkWKOfDtf24Fql73zx15zqy9bX63qywvc/hwDNcCAhigfDBfSKLh7NeEebUr1UzMkjAMBPlih7TpG1rBqPxKu7TFRYO8dBHwEuqwg0bNWoPnRsmQ91wxfcNuCjgXUoA1hBBpyHmpkAY0H43OaBB5MSqOCEElVYS96vkBx8EraetMWLjddMt9YmAKc5Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ec046d2d-9a36-200f-59d7-9137c35a7497@suse.com>
Date: Mon, 6 Dec 2021 14:46:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/build: Move exception tables into __ro_after_init
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206130725.13511-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211206130725.13511-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0145.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fbb0bad-7b24-4850-63c5-08d9b8bec49a
X-MS-TrafficTypeDiagnostic: VI1PR04MB7040:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70404430E9B6FAF4DD448A24B36D9@VI1PR04MB7040.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2657;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	KpN0rO0ZSpsZk6Ct6fQJUQNKq/FJ6Sk2C4cNCnW4CPA9ErmFdChQ6vv0MOlrG8IWubpaVk5lC+z9SHviZ0y5B+zTJgOxUSuddOTkFTEK9C0tF4kwFI280DF+8R2OzWoUh4nJwkrrLMDmk9P1W/naItuAXPv1xCoDSKI30hVQpCLF3sEec2FBYJvHOZAQuYd9ZzYRmy4Rc8w55wetioWJ1nZGn10DfW8zzkWQ7ylsBYuYq7JrKzlBOpFNWiXe+rC2S5U9ioMqD1uuWQPgpZYA/CJyhZ70uCSTGZ2hj0hxa8FusW5iSFja0d4SSWb5NK6N6HdpeaFxgyyfrYfh3DI8h9rtqmPJLY9I138cq+0yWSu4zCBuF8ZjPgym2opOLP2mopZfdXggVebP7KIn85H04+hl0oSKf15694KB8k9XyPw4dKRcBu1V8jvErrLTgTGJDHfCgUM8ozln3MdjKBb+xciWwFhnmh1TiQ2ziZlTrVtuXbYqBn7cX7y7DbinoIrmZuQUwMTRY4HeePrhpa854dW0CQwumbhIz3FWqMExj54XsfNrjxz8BSYIm9vmlpnjxHagwtUigSM+ZYU+AKqfIgSim55kcBMwIXIi5JbUaFAEur5WlOmvFHIWZSXqYbtiKY8pmojZsT+hGRPxH9MLDflDd+ZjrUVHrIVgwJbfHuN0d/Hm4wf9YK91MGbV3wqywo0vKRYLSY5B+imTzRXB6j9bRpfsxvbViGfyD+n5o6s=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(86362001)(186003)(6916009)(316002)(2906002)(26005)(16576012)(4326008)(2616005)(66946007)(956004)(6486002)(53546011)(4744005)(508600001)(54906003)(36756003)(31686004)(8936002)(5660300002)(66556008)(8676002)(66476007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L1ZmM3hGQ2YwMTlTU0dNei9TTTFxQWZWemR0SzVidzM0TFFmWHJLWm1qTita?=
 =?utf-8?B?SzZMSXdLSDZDQWo2WnYrTWJWZEIzbU5GVmZmUnNYNnd6UjRBVjhQenJvelNi?=
 =?utf-8?B?bkg1RVlDU1B4eE1KQUlaQk5KT2UyWVdMQVd6amNmQ1Y5QXpCWVZqRENTTlRh?=
 =?utf-8?B?bkpFNHJyRVBURW91VktqeGJiNDNvcE9kaFFrNStwSHlNSEJWRFBpcEpCYUNr?=
 =?utf-8?B?cGt0Y3ArVU1YQTZHQlo5RE8wRmZ1SEhLNnlycHM3K2pwZ1BYUjJ6R21wdTZS?=
 =?utf-8?B?cStFZ0lMbHI5NmdNNWVPcHBFendGWHlXMWtDeGk5MmcrTGNOYzFBdjcwS3M2?=
 =?utf-8?B?aTRQci9oWVRDemE5ay9CSHBmSi91WldZcEYyTVEzeDBhbWF4cDR3UDNJUVkw?=
 =?utf-8?B?M0ZJWWZCN2Mxa2pjdWFYTjZXdjFyeVpKZEN2OXlGdDFhSlFJQWRHdjRZdWJB?=
 =?utf-8?B?L0pkSkdVMURxQ0lTZVU5TmpzWVNTVzc4QkN3OXVNbUd5RXNlSWtUNnZGTGw0?=
 =?utf-8?B?VjBIUGlBZGY4bGkzRU5ibHo0Wkd3QnVhVGlWVUxOQXRRUmgwc05JM2haLzhs?=
 =?utf-8?B?RnZxZnN4eWRqV0FEOExhRjZxQmJuYTl5d3RjdlMwU3BOVFJ6V0dieFRBbzg3?=
 =?utf-8?B?bUpLZTAxdGNackw5bEE3Skc5cTMyaHNyV2dFOXpaNW03c0ZiU091ZkdlNzRh?=
 =?utf-8?B?VXZjTHlIMC93REJQcHJ2SmI2UFFOMmcrQklBVFl5bXE3dWdmZTNsaEE0Ukd2?=
 =?utf-8?B?Wkp5UkZiV0pDcjl1a1hkVXNOU3dZbWF6RDc0cW5oVitiOTB2eW1NS2RhcWsv?=
 =?utf-8?B?RjBXMmlUektES1B0U2dlWGhOYndlZWF1dFFCSmE0eUJQVjdiK2pnVjZ1Yi9y?=
 =?utf-8?B?aU1FT3FYQ2Z3Q3c0M1R0UGE5bjFCSjdXK3pGdUl1WmNMbG10UzNld25uYzF2?=
 =?utf-8?B?N3N5enlzMTJTQnVzMmtOS2FVK1hDYVpjK2g2RjFlV3Qwd1RHaGg3VmZ5ZDlr?=
 =?utf-8?B?K2pmbUhwOFMzWTd3bGQ1NnJ3eVdxaUNweTNVeGlxUTkwTlpZVXF6K2NQemd0?=
 =?utf-8?B?TkJZT3NTQUFYc1VweTVBNUo2MDRUK3ZJYkUrV1FRRitRcU9Ha1pQWG5sdnI5?=
 =?utf-8?B?NlcycHVuYWZBaXcyRkw4M1hFbk5ZQlJ0NThRTHFEdHY3Zjlmc2tITjhneFRJ?=
 =?utf-8?B?WjBGLytyVngzUENDNi9pN0IzNDNSZUlCYk9RcndGOGpnS3k0R3NpeENWM0pw?=
 =?utf-8?B?d21pSXlkK0QrSHNLT0RPWk9YTEpybVRjN2xiNjVHM1Q0aklyYnVTNDQ2bTBE?=
 =?utf-8?B?SG91N0pQajFsTlJsa05nTW00TnlkWE9OVXFMallvV2ZCOWJ1NFRCZHJqYWJp?=
 =?utf-8?B?ODRJT1g5TGU0Ym5xd1dTbEJ0TVlhMHVhY25sOTRSYUs1VVVLU0haTFgzbW13?=
 =?utf-8?B?K1NvZTR2d29La1JoaTRldlhQSEc2dEJQZXE2bnNXQmRQdExPQmZUSUhvVnd5?=
 =?utf-8?B?cWdzUW8yVE94RFEyZHlGcXJ4eDV0cE5SbHdiT0hIeU1PRVdLazJGd2F5WDZR?=
 =?utf-8?B?U0h6ci9ZOUp2VHNFN1NpbUxta2FYZmdjNmRrU3ZMRkxUUGJKbmdpMDBCNzJE?=
 =?utf-8?B?VTN0eS9MNUl4U0p2d1IrWmE5cVhVdUdBWjRUc0x5MlY2YkJNa2psNXYrZkNG?=
 =?utf-8?B?bVUwUHFYMlhCdDVxeGs0K3k5Wm9UdDBucEdMQ0t0Y0lGd1E1TllHNDNKUzlX?=
 =?utf-8?B?V05rVnFzcFlFMkJIYjF0N1BNQUFGODI2N2FEdDl0YVh0bU9VakplVHNyTmlM?=
 =?utf-8?B?ZFhsZDR1ang0Z25NNEc0cFJCdnYwK3U1bUVkK3M1WDRUUGoyajFxRnUwOEJy?=
 =?utf-8?B?cFlra2kyRmNLTmFBdVlmRUtZY1JTTHF0UkZxV3FienluUHdIY1VRYkZpRzVw?=
 =?utf-8?B?QnJtMXUzNitPOHlrQ3c5b0E4YU41OGNoNVNLb20xdDlvcWMrbk5QZXdLZm82?=
 =?utf-8?B?S0sybi9zSHVYQitUVDhyaklSWHJKcFZDRkx1VzhpRHJmTWh2M0xEcWhUNlR0?=
 =?utf-8?B?azdjQkg5RUxDZWoyU2NuVzNTdDhlRXZVcWFORnZ0YkpQcXl0SVpjbkptS0JG?=
 =?utf-8?B?K3VDOVVyWk0vNFZaMjF5bHY2YU1hSEpPbk5NR3I0TDloWVNSNjlUcUxVY1hn?=
 =?utf-8?Q?lcw8NLT/TxxaRkKagyx+Pic=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fbb0bad-7b24-4850-63c5-08d9b8bec49a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:46:13.2974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i4dS0eUBZPJotCoz6XKdWIXVI2vPKpWBR963H1eA3L+hGdsKyTzMYRrZAQX7lmIVlzw4V3OdIjQ6qNDVZNQDvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7040

On 06.12.2021 14:07, Andrew Cooper wrote:
> It turns out that we've always been abusing the fact that .rodata is
> read/write during early boot, so we can sort the two tables.
> 
> Now that we have a real __ro_after_init concept, reposition them to better
> match reality.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:55:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:55:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239003.414235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muES3-000632-Mt; Mon, 06 Dec 2021 13:54:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239003.414235; Mon, 06 Dec 2021 13:54:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muES3-00062v-JX; Mon, 06 Dec 2021 13:54:43 +0000
Received: by outflank-mailman (input) for mailman id 239003;
 Mon, 06 Dec 2021 13:54:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muES2-00062l-ML; Mon, 06 Dec 2021 13:54:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muES2-0006V6-HW; Mon, 06 Dec 2021 13:54:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muES2-00072C-5s; Mon, 06 Dec 2021 13:54:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muES2-000751-5L; Mon, 06 Dec 2021 13:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FRZU1BIv4VLFSAVHBLyOQGH2+lYH4Ceb7HOozDJciMc=; b=r3KN9ZaJZMJ9xw5uzhiqrgPHTo
	nBFDGL/AR8Sj2Zyl1nNBIWydEdHCLNnaY++NbON4HQ1b/lWzziEro5fa2rNRynw3aowZY4VhbfICc
	T8dT+Q1uVMPG+yw0j+Cdfz6Qa8VWx8ARZvyzdqPs8yQb8HRPwSZ2d1FAoqPujLS2T7sk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167179-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167179: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
X-Osstest-Versions-That:
    linux=944207047ca4dabe8e288f653e7ec6da05e70230
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 13:54:42 +0000

flight 167179 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167179/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167168
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167168
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167168
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167168
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167168
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167168
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167168
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167168
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
baseline version:
 linux                944207047ca4dabe8e288f653e7ec6da05e70230

Last test of basis   167168  2021-12-05 20:21:55 Z    0 days
Testing same since   167179  2021-12-06 04:55:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Helge Deller <deller@gmx.de>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   944207047ca4..0fcfb00b28c0  0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:56:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239012.414250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muETG-0006gQ-7Y; Mon, 06 Dec 2021 13:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239012.414250; Mon, 06 Dec 2021 13:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muETG-0006gJ-4Y; Mon, 06 Dec 2021 13:55:58 +0000
Received: by outflank-mailman (input) for mailman id 239012;
 Mon, 06 Dec 2021 13:55:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muETE-0006g0-Gw
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:55:56 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3ae02403-569c-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:55:55 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:51296)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muETB-000Hwt-iw (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 13:55:53 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id BB0F01FE08;
 Mon,  6 Dec 2021 13:55:53 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ae02403-569c-11ec-8a4d-196798b21f7b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <b7c3525e-9acb-cef8-56b6-894975eeb530@srcf.net>
Date: Mon, 6 Dec 2021 13:55:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <20211206133828.8811-1-andrew.cooper3@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86/irq: Improve local_irq_restore() code generation and
 performance
In-Reply-To: <20211206133828.8811-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 13:38, Andrew Cooper wrote:
> popf is a horribly expensive instruction, while sti is an optimised fastpath.
> Switching popf for a conditional branch and sti caused an 8% perf improvement
> in various linux measurements.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> ---
>  xen/include/asm-x86/system.h | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/xen/include/asm-x86/system.h b/xen/include/asm-x86/system.h
> index 65e63de69a67..4be235472ecd 100644
> --- a/xen/include/asm-x86/system.h
> +++ b/xen/include/asm-x86/system.h
> @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index,
>  })
>  #define local_irq_restore(x)                                     \
>  ({                                                               \
> -    BUILD_BUG_ON(sizeof(x) != sizeof(long));                     \
> -    asm volatile ( "pushfq\n\t"                                  \
> -                   "andq %0, (%%rsp)\n\t"                        \
> -                   "orq  %1, (%%rsp)\n\t"                        \
> -                   "popfq"                                       \
> -                   : : "i?r" ( ~X86_EFLAGS_IF ),                 \
> -                       "ri" ( (x) & X86_EFLAGS_IF ) );           \
> +    if ( (x) & X86_EFLAGS_IF )                                   \
> +        local_irq_enable();                                      \
>  })

Bah.  There's still the one total abuse of local_irq_restore() to
disable interrupts.

I'll do a pre-requisite patch.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 13:58:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 13:58:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239019.414261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEW4-0007a5-MG; Mon, 06 Dec 2021 13:58:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239019.414261; Mon, 06 Dec 2021 13:58:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEW4-0007Zy-Ij; Mon, 06 Dec 2021 13:58:52 +0000
Received: by outflank-mailman (input) for mailman id 239019;
 Mon, 06 Dec 2021 13:58:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEW3-0007Zs-K3
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:58:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3985698-569c-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 14:58:50 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-PX-7x9g7N-WxjOu0RXYLFg-1; Mon, 06 Dec 2021 14:58:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 13:58:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 13:58:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::10) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 13:58:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3985698-569c-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638799130;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oClr/AW8JQ8GztO8qndzhAbdaIpmxjM9iR3dXIMZw7Q=;
	b=MiDINsiq7SztCUI+YsRs14W7W8oPqN4nEJYbZnWS7IKxElsV3QjhdZ5S57SSImtKAxpBWs
	UMGuzcxMGyMy8QZj9hQOt8RjTm332aCsxh27fn++iSCvvfJSNdFPXqSxn1AeNj14BnIuYN
	yKAS5ME7boTvMLhYP6oSWjsemtBoMeg=
X-MC-Unique: PX-7x9g7N-WxjOu0RXYLFg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T28HLl0dxGvmMLNaBw08HkHX31zYAe3Q6kfYr3wlOp72er5AkY8S0/9wD5cS/+xN67ms6gKUi2rQfIQl5KZvsEHe8Xm2rSkArd6yPAH3Hjr7vOpZfoMVJzKoQv1K3efrAikXELsBNRLR0zBWcWOupPzy3Jb+rCELN+2xYcIT8bLKPw4WMZdO9rnMPpNrZfdRE6HNKtZa4MVWbfwNz4oLzLVJ6HdlUdOLxM1R4DX29CJN3esv0yg1G26RhR7FxxnxaZ7sliUOoqE0LS4sHxXRk4y09rXFg3w3SYHfx07nnoH7juCdchMOSTiGIXj51SLMsNUlo3EyvPA4nKzsYtpFew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hthfPL9z/NcdxxnI5ltv4B8p1fDABZ758m7L2Hlcxzk=;
 b=VNIcTR8ZIpe7W6tSlLH6sIzMN4S/P/avGsO0RLvvRO9IQ+RjsKG8UGnXOaMaBfdPhqxvW9DjnNzhILkcGWufW8BXcPC5qRzdJHwiVjjrd9+4nsXhu9pa7H6a+BJRZtF7wk3hGAzrhxhF1WymdHClWGw1MFviMf4O3n18xnN+d8nPeMqarsL0qK8rF4Vd5ad4TW+44yEUhOJSa9bRUzIPsTsr+CrGAM02Q5yNt3bl6zMwDDbDdHHVti+6z2IOMB9zb0zuPvd+037QmXtjIu0Z0crj1qG08rrbFHuGlz1ZxTr+V/GofUWKP57GdQVTJ7kaO7axsURi5n7KeWpmsbVw9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9ac98bc7-5b39-3c88-556b-53a5fdeb2445@suse.com>
Date: Mon, 6 Dec 2021 14:58:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/boot: Restrict directmap permissions for
 .text/.rodata
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206130855.15372-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211206130855.15372-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0071.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:49::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ea9854fd-cbb0-4447-f6d9-08d9b8c08613
X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3295867BF2E1E9F74AC051BCB36D9@VI1PR04MB3295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yg6Bvk8yEAzoNT5Wqu1kUZqGAdbgjJYp9rfpDhFaF+ofQe0vXT8yOmPtxK3wVVxscil+IjJfORTjg/izIYy8Gc8iPMmInGOkHAQx1gGO7JsaUK4nueSkF4cmIo7zkzqt22eKbLQcBE1HpD1zpS7gP9PcImhsBigwcJkBw4IFkvyXZZNlFshQe3cBI6PxTz+s0EGSchUmdevT7zvuyV3FCSP/zL6Aex7FrcmQKFVOkQLGcOB8Rss7ipxshINhzKKposev/xTmpAWVE9Mw/59HkbBxYZ2HPN58gFQoFE3IZR8Xl4ABJrkifX3GNYecBMMs5w+Rypi6JNejKQ6jKgINzh0pRdZukOT066Kxf2/XBmj29qHXHaJFT8GZVNUBFuhHRHCEsWlSATMi6QAaW+kECnHdn8EOV245LIMKaKtXY7Q9BUX8AR4EAfRWWSIOlk0pZdJOhIOClfn8iWIbHyzNDPP8JG+NtynXHu4ZpyelzgiyfJ2a12ZAxfMpR0AzybH+TRAp3XLhopzi31oLegoLX6b9repHCuOB1NRm9M3rHqAZD9A59p422TF/uFj71lOJhT/OE73rmUaHOaxgp04Am3rrB4Tran1zIqaEYMBqcrqXezd6OXjaxl0yNujKYk8pBpFdZwzxSerczm80Gt01PbeKnHOoBq/Pa6l5n1qwpUVRQ7kowZSHiPseKfEK/1X9KkPK3jvuTM6mPPXc0e7ehKO9xLYrv5pJkW9lXm97RyYGbZFcL8+CxJKtxlxml7Crut1S1Qr3Iz2wU4WEifwPNQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(83380400001)(66556008)(316002)(38100700002)(5660300002)(53546011)(956004)(6916009)(36756003)(26005)(66946007)(4326008)(508600001)(66476007)(8936002)(6486002)(31696002)(8676002)(2906002)(31686004)(2616005)(186003)(54906003)(86362001)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?i9pk4Vja9/yJhBKSRAS6s7jP6MAr9hdTfly1HnYwWlQKqQz0PLKJqojDC1gs?=
 =?us-ascii?Q?ps8+NnfYJkfcmyvdJ7suNjRXMqOi2HBq1Y3gmdYGHsc4bjwhC3O+Wj9PdxwY?=
 =?us-ascii?Q?WOKR6o0QYcgTiVdBGKzfPtDBA50/sdjLLOgX41RMzwa6gQyTd033DkDZUmMl?=
 =?us-ascii?Q?0Qo1s6MT8F9UC7RTYqg2bg+sUUOJuKsV3c4rkQ4/uAQGj877hlTQ2oI2s3nn?=
 =?us-ascii?Q?KSkCTOAxq48X9p8Xs4O4Fr6J/i4BlHFMRC0Rr2BUo+ajvNCAxURyIwpn5oGO?=
 =?us-ascii?Q?lSwOrr1869FNBcYKjQjlFPUEeyPghMH6JRAlFKD7A6rjEzlrxIIHngt4FSBM?=
 =?us-ascii?Q?+hvShgqONf6s7KVAKJf1EKWsT3dI7UKh5+v0JVvpSoKd46CAuw7IG554ifAF?=
 =?us-ascii?Q?YfqAbCd+g98a4hLTNNLXXv+iAS2w5BrgSpuydaj5DerWSq8h143/2X2pqGcY?=
 =?us-ascii?Q?AV9XYSojtcGAg3EGL48LndNl6/m3LYv3Jy55dWCvAOXG8gmQYi1MRLvvuboh?=
 =?us-ascii?Q?zEVTe76aFjja24hjfRZxYN5pm8l5anMpmTLJCk81fGUa6rwGw04LVJPNH4/I?=
 =?us-ascii?Q?fKdRucTqWMwFV8qLKBrsTphJZenH6XBvHJVGEGlnLSts+bYgPrxxWGFpYK4C?=
 =?us-ascii?Q?d1avHXzWR45e6i9gEy1pGAwJg9R9dXyU53AeaHIixIRCBEQKqxgCTzgWD3GO?=
 =?us-ascii?Q?8/PstfrS6/bZ7Ia4B+SS8F/YRy1NZonv7vm5Ga2ERqA6xVylNZkNA4MdmboR?=
 =?us-ascii?Q?d9AbPf/HNeoFjXsniwYZlwhjmDAGNN37PEXtXVqDusrh40jZOiTaSFIO56dO?=
 =?us-ascii?Q?V4lSuihl3g49VM73ev6bGjvkUhS9C4dDFTopO927FQu2LfD4uXSO9YPIXpnF?=
 =?us-ascii?Q?ZEjQxypOU48WOMa7BqAqrylTGcJznvH48hwJDJiU8Z7qIifbRyHgvqY8rt+E?=
 =?us-ascii?Q?4e54LfqZepM7WYYjbGuNH19+QaMBC0Bv2F2YttAJMTMYlG+R4TH5+VYzN4Fr?=
 =?us-ascii?Q?GxN2qf6WBoFeJspSQZr/UOPR2lvJFdrDbO7NRL05W5clfqg7yQYao3UPYxPO?=
 =?us-ascii?Q?4CGnsNoBq28obtFUofTe8xQ/j25ZNX8T2+0LzpKV7kkHAJt0VqHu2oVPTgDI?=
 =?us-ascii?Q?wEQtFJqZhOHAZw4VOH6IFjlN5WYmDiuGGBs9WUR4erh20LmN/V803BL78/mh?=
 =?us-ascii?Q?fyErkhMiq5bmyHEoIY956qkyUH9Q0KgoxA5FzaxfL4n09lXFGcl9yUiGFro2?=
 =?us-ascii?Q?GEgL12H8vYHg0rOKIdXJUfaEOMT9b/2eA3EK0vVbRcYttvmxq/dgFffiD+YW?=
 =?us-ascii?Q?vQWLgPZwC9m5SbrlkVzt0FJXUa6KAUK0QZAtwyp+IEiFYs1TckiBohTC7a0p?=
 =?us-ascii?Q?DT0BkCmi5YsBXCtB9ECKl8abuG0d8V9VlG/dOeQk5g9FKFCV9FvxxIatba20?=
 =?us-ascii?Q?Q+zsAX+l/n+W0II1/J6MT1qvDJMQjhscszHeknZa9ulmhmpzYyVyGIMNTrmd?=
 =?us-ascii?Q?7tvwPL+QJKUzLgACoX0AFCz3Ga8aCVWW3wTk23OC2UShTcQhWLtBX44zejp5?=
 =?us-ascii?Q?VG0eLSYWEZ8wnwsnVkvubgyXquiNKTT4D53Kx4fXB2jam/l+nPAnd73m96bg?=
 =?us-ascii?Q?9OuGzI4iqZGpV5MgYZbXLWo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea9854fd-cbb0-4447-f6d9-08d9b8c08613
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:58:47.3442
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TRJv/cx58SQjMGtct/S9m/Rgz2ki9XDgvFXcoi2riS/446FRJp2fsGEHsy5/Tw+jlYAr6ShSxLvD5ZZJ77+hSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295

On 06.12.2021 14:08, Andrew Cooper wrote:
> While we've been diligent to ensure that the main text/data/rodata mappin=
gs
> have suitable restrictions, their aliases via the directmap were left ful=
ly
> RW.  Worse, we even had pieces of code making use of this as a feature.
>=20
> Restrict the permissions, as we have no legitimate need for writeability =
of
> these areas via the directmap alias.

Where do we end up reading .text and/or .rodata through the directmap? Can'=
t
we zap the mappings altogether?

As to superpage shattering - I understand this is not deemed to be an issue
in the common case since, with Xen moved as high up below 4G as possible,
it wouldn't normally live inside a 1G mapping anyway? This may want calling
out here. Plus, in non-EFI, non-XEN_ALIGN_2M builds isn't this going to
shatter a 2M page at the tail of .rodata?

> Note that the pagetables and cpu0_stack do get written through their dire=
ctmap
> alias, so we can't just read-only the whole image.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
>=20
> Ever so slightly RFC, as it has only had light testing.
>=20
> Notes:
>  * The stubs are still have RX via one alias, RW via another, and these n=
eed
>    to stay.  Hardening options include splitting the stubs so the SYSCALL=
 ones
>    can be read-only after setup, and/or expanding the stub size to 4k per=
 CPU
>    so we really can keep the writeable alias as not present when the stub
>    isn't in active use.
>  * Future CPUs with Protection Key Supervisor (Sapphire Rapids and later)
>    would be able to inhibit writeability outside of a permitted region, a=
nd
>    because the protection key is per logical thread, we woulnd't need to
>    expand the stubs to 4k per CPU.

I'm afraid I don't follow: The keys still apply to entire pages, don't they=
?
This would still allow write access by all 16 CPUs sharing a page for their
stubs.

>  * At the time of writing, PV Shim still makes use of .rodata's read/writ=
e
>    alias in the directmap to patch the hypercall table, but that runs ear=
lier
>    on boot.  Also, there are patches out to address this.

I did consider committing that change, but it wasn't clear to me whether
there were dependencies on earlier parts of the series that it's part of.

>  * For backporting, this patch depends on c/s e7f147bf4ac7 ("x86/crash: D=
rop
>    manual hooking of exception_table[]"), and nothing would break at comp=
ile
>    time if the dependency was missing.

Hmm, not nice. I'm likely to forget if we would indeed decide to backport
the one here.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:07:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:07:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239026.414272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEdy-0000kk-Gx; Mon, 06 Dec 2021 14:07:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239026.414272; Mon, 06 Dec 2021 14:07:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEdy-0000kd-Ck; Mon, 06 Dec 2021 14:07:02 +0000
Received: by outflank-mailman (input) for mailman id 239026;
 Mon, 06 Dec 2021 14:07:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0EtG=QX=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1muEdx-0000kX-19
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:07:01 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c720c08c-569d-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:06:59 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 1077C68B05; Mon,  6 Dec 2021 15:06:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c720c08c-569d-11ec-8a4d-196798b21f7b
Date: Mon, 6 Dec 2021 15:06:51 +0100
From: Christoph Hellwig <hch@lst.de>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
	wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, jgross@suse.com,
	sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
	will@kernel.org, davem@davemloft.net, kuba@kernel.org,
	jejb@linux.ibm.com, martin.petersen@oracle.com, arnd@arndb.de,
	hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
	thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, brijesh.singh@amd.com, konrad.wilk@oracle.com,
	hch@lst.de, parri.andrea@gmail.com, dave.hansen@intel.com
Subject: Re: [PATCH V4 2/5] x86/hyper-v: Add hyperv Isolation VM check in
 the cc_platform_has()
Message-ID: <20211206140651.GA5100@lst.de>
References: <20211205081815.129276-1-ltykernel@gmail.com> <20211205081815.129276-3-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211205081815.129276-3-ltykernel@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Sun, Dec 05, 2021 at 03:18:10AM -0500, Tianyu Lan wrote:
> +static bool hyperv_cc_platform_has(enum cc_attr attr)
> +{
> +#ifdef CONFIG_HYPERV
> +	return attr == CC_ATTR_GUEST_MEM_ENCRYPT;
> +#else
> +	return false;
> +#endif
> +}

Can we even end up here without CONFIG_HYPERV?


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:07:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:07:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239030.414283 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEeH-0001Hz-OI; Mon, 06 Dec 2021 14:07:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239030.414283; Mon, 06 Dec 2021 14:07:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEeH-0001Hs-LJ; Mon, 06 Dec 2021 14:07:21 +0000
Received: by outflank-mailman (input) for mailman id 239030;
 Mon, 06 Dec 2021 14:07:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEeG-0001F4-D5
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:07:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d2fb0414-569d-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:07:19 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-R_wCW8EgMJ6k0W8l_kMYLQ-1; Mon, 06 Dec 2021 15:07:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:07:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:07:16 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 14:07:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d2fb0414-569d-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638799639;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Sy7Bvu/V1pNuLdYx0BstD1vAemGMPJL9FALhPZsZ+HA=;
	b=dEFdkG1TvJMEiaC59q7IVfdrNhm2I+bSDLzGKCNdGH5njSNuJaHSRzmdcMT1LpIXDom8+D
	qmyFCmMPZ8QnJSvdSWrrGBUQvSlQnK2rxHmvHf7NCAScGZRp7UEUbSNfd6n4p/VZpELi4Y
	MlaiT7A27/vnZoTCKJus4Vou9y74qC8=
X-MC-Unique: R_wCW8EgMJ6k0W8l_kMYLQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RYr6YGJ2S0m/vPxn1hY2OrPy19kMnw33YEX6woQxu+DB+BORfyIXRMWSQI1K3YCGcZX8yCAb2iuz5MBepDknzYkAG/DOTfU8/8/g+RviUnC0rhjRb+q5mm72BjgFzW0Pvd4x9Eh+mMp0gf/lMojdmRv4RTrjgCI/e4bRKRCCYmM4+eez4tdlbHBt4A5/GliBroWsI9XeW4W/ipgkfmbCyBARk4iNHvPz/CjSvWnzcXfI81gu4n1hxbNVa4IzAHdCnbrjIpNLUExt/vYwcSu/pqUEo1yiTiPrdtUy1BjvhptJbYxJBF9HAfb/jDOX3/Iu00UHeuVVibRCONHjDYYq5w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X/ijlGOwIXpRo8SfXahGIkGaSLFMOXDD/vSOr8ascyo=;
 b=RjbkohPMXwBrkl3tFfGTRYs2E0GKCF4IO94/rEGj3UrsbwGqNtW7wUK9B8SH+JzLHrYvIQ1tkKB+wlH35PqIcE0FlFelGRdt9YObceyG7q22EOjhxkvIGuHDcwCNVJKoE1CrnnOZK+2zjatKwwCXeDJIWfjCu20AFZ2IThMQWpjxL6CuyqJ7sj7miNVpon4InHaYsp7GWe573hk1cFcQpzJ+e5uz/UVlz3RwmZD2+M6tFWD0kchFm7ZcV1n5lv72Bh77mAPtafXVnw2LjKgo5jf725H0kUw0moHsbQoY/riHZpUyZDhrArFT8IZG6UssFnHy5HzWAan4Nu6B85Hojg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1884c09b-2583-efd7-bcfa-8413865c53b6@suse.com>
Date: Mon, 6 Dec 2021 15:07:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/irq: Improve local_irq_restore() code generation and
 performance
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206133828.8811-1-andrew.cooper3@citrix.com>
 <b7c3525e-9acb-cef8-56b6-894975eeb530@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b7c3525e-9acb-cef8-56b6-894975eeb530@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89d80f5b-2447-4f60-a951-08d9b8c1b578
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039D23A7E2E3074F14D498AB36D9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	md2MSLrp0wU0qpiecDeBrjEb7nsSAnxuD/4ISm8GW0ohx6cXznDWurm9kabl6hrDDZDMJVMHBqxcwtEtZySurJAtj24y/0P2B3ejKwf+RC8XV3I0ogXzwQBoIO8ry8l/lsLOnKcrFOnKb6p6A4FWT7iQGoe979oww5YCF0Rm8VksXQNFZYa/6Kab82LFD06YXY9rXewlwTa0Xkrz+V9/CSbiE5mtW3qCKncFors/AOdwVCCXYs7ITM5sOwGDGKYEPFogTP5ny7wOs+RvB82/2uG0zfp+c/PTiXGdfgJI6fFiNDy+PtT9C57Cmd7QatYNwrrh+Rgl0hS1VgCGEr4KlbvsdclgOTXnP9ODCfNuIl5u2dtKLZFkZX0x0HHb1DDKFAvBcjWugD28BmLdBkkP+arFMGCcQ6SzNxaQquWl351o2ZgOy8pBLc41goskKpp5JeRQA8PMwSNfr2KQnc3fAqIjPlkNvSgcjeZX/BzMft8xRmPdmrROsDutB9bTZQXjLjNh4O6wcCiFd21E8Xw+QjWqFS+x6EVaEaGx1VTbC8ZwXm/X1ZwAi0l7t6zXcT8nMlTZgz7oDLWmkdKPoSpSWcjeoM6SSIBuod0SWybFYrv1wBHn8ZEXAZPydnPpyNlYazOUJ3f+TaJ/joTPPzZ9uq4sOrPpzzbKfIeFgJrGCts4vqZKN3ziUsvKo/EftCVvPfTUXiiEEVm7TsFAR5z+fsbYwS80gttrO4VN50BuB4c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(4326008)(31686004)(6486002)(5660300002)(26005)(36756003)(186003)(31696002)(83380400001)(2616005)(53546011)(8676002)(66946007)(316002)(54906003)(66476007)(110136005)(8936002)(66556008)(86362001)(508600001)(2906002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?U0koKfBb0Z3u2+T0XZd/nS1cEKMbror7Lh2KiP81WJNn9WqFMYh1omO+R7ru?=
 =?us-ascii?Q?XZrt6PZlTr9/NCiqIJ5auoZcFK9CeL0SEQVBSrHY8Mvp0DAb6759DTpTWkJW?=
 =?us-ascii?Q?UvJgRSLF9AndL0Gy4PgPOqzcibMln+8tDVWWD0oY9TXM/nHKlUqR+unzAK1Y?=
 =?us-ascii?Q?AArp90eR3M0i8avIxjdyqkR4loVZKr9oZ/8mr+Mx7CJclzKRrwpWkIh5EyU5?=
 =?us-ascii?Q?zWEkx18OqIVqb68YWwEHZW9s0zXCZw+9QYznYTtUmAhqFnUx8PvoNNY6Wi1u?=
 =?us-ascii?Q?0o6fEhoxowsE23Jau6RNAOXmG9tLOCBt7o7ey6jVHSqZld+X51CdACTCOUBN?=
 =?us-ascii?Q?Voywv1AGL7ZSsoULSisG2CXG0D9T1hWxykz6WJoocEIr7LMjaccHmmWGyRkT?=
 =?us-ascii?Q?TsZBji1wtqanovnpzNw/3xjbETSIltVXBA9Ym4tdQTipPi+iPlHQKLd50kiJ?=
 =?us-ascii?Q?Hfw1kWDBYb8QR3ye7DMTRZu9bgcXUozLCpqg8PQ+1R5nLi7AD6PMtUSQua+C?=
 =?us-ascii?Q?zbKKsRRyhuaB4OTLpFGGnp5Ujs+YLuzYPj6oU8tESonZltmst6Xtpez0qBYT?=
 =?us-ascii?Q?uFkrouaNaNTCCq2Z75Hqc3ZwxR0U8AkX0i/UgruzMQIAOOX6odCbiIn7KGlT?=
 =?us-ascii?Q?H5qtInVwEaiKfM147ovDC6DqdCwN3Xf4+rBc6KOFy+1yCRNQJ9jNYBEPQ0yI?=
 =?us-ascii?Q?dIG8BBsGA/SQd0sgCtJTTa4N/V4NV0SaXvDXh8vfDm+UBvix80+OhSCKj+9x?=
 =?us-ascii?Q?/3G1J4fVtSOw7RE48+MPEMA4bWSZ4ajNGsnItGR28jvdeZMfJ1HBfZkzEcoh?=
 =?us-ascii?Q?u1fRY/lrQ9PbSmS/+3I1LTPfezbF+Wo0yhDu1zNmKk7LCreJgUK3OwMiCaKj?=
 =?us-ascii?Q?RbHQyHK+8Q6+Fn+74LMkweVbAJJ1l/pqNCnFbV4kSRa0lN6xjsx0OfUY3UBF?=
 =?us-ascii?Q?Sv6bGW/Ij4zpeIK7aZw7pNl61l6q5AUoU10Smid1Lb4JQIvjKJ6vGlFNNBaO?=
 =?us-ascii?Q?gHr4tYs7ynkt3yUXYAMhs0Tfh/itBmI0v6mKhCVrHsLq4/mA7Mko2GPeh6nO?=
 =?us-ascii?Q?CPtyC5IrW6VePAOSbGV//bmzWUNi46nfUBfwY+UZSIvWb5KsjVE5pQD78JrD?=
 =?us-ascii?Q?VJhdqZpkFwIBqKFJ02oTt1bcorSXMeeBmn/MKG5LOX6RPCL0nRSuBOn+Ntso?=
 =?us-ascii?Q?mnNIKOxRcNY2aSHMNT+vUmGNZG8E33vs62BADTZgk8mKJTh99S5Na0dLtLkx?=
 =?us-ascii?Q?/eBsNgAB+KrcgNaVjd6DggXNz9lXLILK1DMH1E5UztcffNx9YBtv9kRbP6VI?=
 =?us-ascii?Q?06BxXIeq9f880NdtN5w7ZfQJWE/HpGTZ5rYv0SH7cB/YA8U3CcbSwb+Q7VZu?=
 =?us-ascii?Q?BWWbhMmsVhNm4wmvjpXsJTuB/iR9DTP9u2abu9JZDm9mDRB7zxNbgE/OO+Uk?=
 =?us-ascii?Q?QalberDXDFsUxiR4SSXQ4R7y6dMWm0A2RFWDHoJFWCH6g+f13zbjYNH8Spn0?=
 =?us-ascii?Q?VYEWJhQOMNSoNSTXTSlsOrEzNAq/drTsQGRwUN0piZvBSI85jXuZA+bTp/CX?=
 =?us-ascii?Q?MGdxsiTR4orblt80ul4tU3Euud1J1LUijK8U4rS3Yo3LREf8vlJk1A7SL+pm?=
 =?us-ascii?Q?Mj/pfWYYXrTTV5NR5yXFgCE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89d80f5b-2447-4f60-a951-08d9b8c1b578
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:07:16.3967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f0bBMsoWOq1oDOMoLg7RcXCQv57lhK0Ye90KzcXd4Lvdta84VeKnvAW1bvvcanBAm4xw6Q/d7TUo4Ge8NV12BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 06.12.2021 14:55, Andrew Cooper wrote:
> On 06/12/2021 13:38, Andrew Cooper wrote:
>> popf is a horribly expensive instruction, while sti is an optimised fast=
path.
>> Switching popf for a conditional branch and sti caused an 8% perf improv=
ement
>> in various linux measurements.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> ---
>>  xen/include/asm-x86/system.h | 9 ++-------
>>  1 file changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/xen/include/asm-x86/system.h b/xen/include/asm-x86/system.h
>> index 65e63de69a67..4be235472ecd 100644
>> --- a/xen/include/asm-x86/system.h
>> +++ b/xen/include/asm-x86/system.h
>> @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec=
(unsigned long index,
>>  })
>>  #define local_irq_restore(x)                                     \
>>  ({                                                               \
>> -    BUILD_BUG_ON(sizeof(x) !=3D sizeof(long));                     \
>> -    asm volatile ( "pushfq\n\t"                                  \
>> -                   "andq %0, (%%rsp)\n\t"                        \
>> -                   "orq  %1, (%%rsp)\n\t"                        \
>> -                   "popfq"                                       \
>> -                   : : "i?r" ( ~X86_EFLAGS_IF ),                 \
>> -                       "ri" ( (x) & X86_EFLAGS_IF ) );           \
>> +    if ( (x) & X86_EFLAGS_IF )                                   \
>> +        local_irq_enable();                                      \
>>  })
>=20
> Bah.=C2=A0 There's still the one total abuse of local_irq_restore() to
> disable interrupts.

Question is whether that's really to be considered an abuse: To me
"restore" doesn't mean only "maybe re-enable", but also "maybe
re-disable". And a conditional STI-or-CLI is likely still be better
than POPF.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:09:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:09:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239037.414293 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEgK-00028R-BC; Mon, 06 Dec 2021 14:09:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239037.414293; Mon, 06 Dec 2021 14:09:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEgK-00028K-8P; Mon, 06 Dec 2021 14:09:28 +0000
Received: by outflank-mailman (input) for mailman id 239037;
 Mon, 06 Dec 2021 14:09:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0EtG=QX=lst.de=hch@srs-se1.protection.inumbo.net>)
 id 1muEgJ-00028E-26
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:09:27 +0000
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1dd87902-569e-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:09:25 +0100 (CET)
Received: by verein.lst.de (Postfix, from userid 2407)
 id 6C59868B05; Mon,  6 Dec 2021 15:09:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1dd87902-569e-11ec-8a4d-196798b21f7b
Date: Mon, 6 Dec 2021 15:09:16 +0100
From: Christoph Hellwig <hch@lst.de>
To: Tianyu Lan <ltykernel@gmail.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
	wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, jgross@suse.com,
	sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
	will@kernel.org, davem@davemloft.net, kuba@kernel.org,
	jejb@linux.ibm.com, martin.petersen@oracle.com, arnd@arndb.de,
	hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
	thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com,
	xen-devel@lists.xenproject.org, michael.h.kelley@microsoft.com,
	iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
	vkuznets@redhat.com, brijesh.singh@amd.com, konrad.wilk@oracle.com,
	hch@lst.de, parri.andrea@gmail.com, dave.hansen@intel.com
Subject: Re: [PATCH V4 1/5] Swiotlb: Add Swiotlb bounce buffer remap
 function for HV IVM
Message-ID: <20211206140916.GB5100@lst.de>
References: <20211205081815.129276-1-ltykernel@gmail.com> <20211205081815.129276-2-ltykernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211205081815.129276-2-ltykernel@gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

Please spell swiotlb with a lower case s.  Otherwise this look good

Acked-by: Christoph Hellwig <hch@lst.de>

Feel free to carry this in whatever tree is suitable for the rest of the
patches.


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:14:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:14:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239042.414304 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEku-0003Vm-Tj; Mon, 06 Dec 2021 14:14:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239042.414304; Mon, 06 Dec 2021 14:14:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEku-0003Vf-Qo; Mon, 06 Dec 2021 14:14:12 +0000
Received: by outflank-mailman (input) for mailman id 239042;
 Mon, 06 Dec 2021 14:14:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BmDh=QX=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1muEkt-0003VX-Jr
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:14:11 +0000
Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com
 [2607:f8b0:4864:20::52f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7c2ecc1-569e-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:14:10 +0100 (CET)
Received: by mail-pg1-x52f.google.com with SMTP id g16so2155472pgi.1
 for <xen-devel@lists.xenproject.org>; Mon, 06 Dec 2021 06:14:10 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 pi17sm14658528pjb.34.2021.12.06.06.13.58
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 06 Dec 2021 06:14:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7c2ecc1-569e-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=LG+zF8eXNnqFsGFKA2ZTnXSPUueJWK5YxbpbucSufXI=;
        b=mQqUkA3xIsQY4XmQYBzGNmYRws6Q0JrMJpuTq/VEAZ58elCNocHbrP8QMV+4phw9Ut
         vWKeJdfRRl2H6A3/U0ZfFrg46WCHuxCz5sAlIyGUXSN9dXWnqcoQP+R/jmprw5bfpFHj
         fKOmzAhbS2g+OM1Z5BI3nXKStQ11a7SSrQ5tFd6125uR6KPjsGJebIfx224pdX+EvGle
         FqorCYj7anmbSaX4e41EWyvuvtjfgov84k+oRDD0xrawuDr2dYvzxxLjG9dUVswmsHTE
         elai+rbP43KznXg+HMIMYpPzORZYpPi24LOHZHh8JFVSoiDVYRN7mdHXVcauIlegBAj5
         mHBg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=LG+zF8eXNnqFsGFKA2ZTnXSPUueJWK5YxbpbucSufXI=;
        b=r98KrEc38Hzri2/oRGLEkOaZL/30z0HumrkPB5CuWgUjsCzjXT7KsnwxLmNGWv4CcC
         tMxUeXZxx9uL4Pi7u/8hWnhsXIDMZZlUNt/GQ0IjxKUUlbUfdSbTjRo+N+OeqsOUIS9V
         0akAS7UJiDow85pTnWvzfLXJJGnHvcARKLv6tnuQs77RB5qH43RSYLSBgVYGIydnKOxD
         OL2PN5cMtDzKeav8UqCxOproZwJ8a/ZSmn48Ysp1uwIO/qiKKopnAL+DQZjMXoNgO4y5
         S3zL1/h0nsLNysL6YuomTpidGEHq+HrkIgrqrB/QAfGy0poW3YIUD3OZn892My3rcfi+
         wjjQ==
X-Gm-Message-State: AOAM532ean8g3neAcsK0RnMfnAjxcobLkL8Lbq6xFhZ8My1SPK0TWGGk
	h0WXNeV2K3ZHxc6Uj7ZuVWo=
X-Google-Smtp-Source: ABdhPJySAj+QT4OHzaoYLk1cSWHqCc54qgRjOngjnxP5g2RiZmDR4g0TxiHn1EhVWrwC669mfsgWOQ==
X-Received: by 2002:a62:7e4c:0:b0:4a2:678e:8793 with SMTP id z73-20020a627e4c000000b004a2678e8793mr36890086pfc.75.1638800049309;
        Mon, 06 Dec 2021 06:14:09 -0800 (PST)
Message-ID: <4d9049eb-d3a8-3872-c4c3-4ad41d93b58c@gmail.com>
Date: Mon, 6 Dec 2021 22:13:57 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V4 2/5] x86/hyper-v: Add hyperv Isolation VM check in the
 cc_platform_has()
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
 wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
 hpa@zytor.com, jgross@suse.com, sstabellini@kernel.org,
 boris.ostrovsky@oracle.com, joro@8bytes.org, will@kernel.org,
 davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org,
 linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
 netdev@vger.kernel.org, vkuznets@redhat.com, brijesh.singh@amd.com,
 konrad.wilk@oracle.com, parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-3-ltykernel@gmail.com> <20211206140651.GA5100@lst.de>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <20211206140651.GA5100@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Christoph:
	Thanks for your review.

On 12/6/2021 10:06 PM, Christoph Hellwig wrote:
> On Sun, Dec 05, 2021 at 03:18:10AM -0500, Tianyu Lan wrote:
>> +static bool hyperv_cc_platform_has(enum cc_attr attr)
>> +{
>> +#ifdef CONFIG_HYPERV
>> +	return attr == CC_ATTR_GUEST_MEM_ENCRYPT;
>> +#else
>> +	return false;
>> +#endif
>> +}
> 
> Can we even end up here without CONFIG_HYPERV?
> 

Yes, I will update in the next version.

Thanks.


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:16:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:16:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239047.414315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEmV-00045w-9A; Mon, 06 Dec 2021 14:15:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239047.414315; Mon, 06 Dec 2021 14:15:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEmV-00045p-68; Mon, 06 Dec 2021 14:15:51 +0000
Received: by outflank-mailman (input) for mailman id 239047;
 Mon, 06 Dec 2021 14:15:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEmU-00043L-6d
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:15:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 030da0c2-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:15:49 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-FQXdlZ3EN-qiAGFRgtURcQ-1; Mon, 06 Dec 2021 15:15:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2446.eurprd04.prod.outlook.com (2603:10a6:800:4e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Mon, 6 Dec
 2021 14:15:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:15:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0022.eurprd04.prod.outlook.com (2603:10a6:20b:92::35) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 14:15:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 030da0c2-569f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800149;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=v3iQFA/7LIAqjfS4sMAhAUE/Rcgq7GBgOfxiaKoVp54=;
	b=Qa6teoVpZ5+u2rZ4s4CBOJi1eBq+VVl60UwWCnsI4gd+/Qj4ZonyrH8WqFZLtRZwhu+sfJ
	sbdpcFJj4imFtjfPcHiasql2yR47j4JqUY8AwMJ64J+croSXmfhqblzTjqrw4O5MTjDqxs
	Y8EAN0h0KZHDHRIaFq4Ihh2Eut4BW7U=
X-MC-Unique: FQXdlZ3EN-qiAGFRgtURcQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cJaf0+uh8LvFL/4eGAmBa8q26zk7u/sDqHj/eQskbDZmxaLrIsworEQ7GHMFjE+V2Z36VunIOwTEB8s9D9bhEbelHEqSZJSkbqpvDRj2H3NLp7RlokHuSz8s6U7eh4EKHk9ekvFhmWWOIyXlfpL88EfIAuZvj3uC3PXFVtwe/+QyjKodAicb9Yc7vP91Rf/uJZ1MvlGJ6/HunQGB8SRHXdMBxeApFI9Eqg9+elR6VlTduUHsbxEaB4MCQMPpNKOv6E1Sq6SVqwuTP7xjf4fE1dxeX96IE6F49obffDRppSwIhvS2HAGdfS+5Oz/pi6lChuNqZL8jN176xddzE0gaFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v3iQFA/7LIAqjfS4sMAhAUE/Rcgq7GBgOfxiaKoVp54=;
 b=mWay7bL0R7KAkvaetRMX4V7HUhDtoATxdDKBNHRfCqXMkbQP3RB5ORw7/JhnRAIO6it2bGXocp9dRW6DqpI7dQjx7O5Ow5pAMaaLLMhymh3D2eDhJ9F+yZomInZa8VfzoZvvyMVtVaWm6gLW+yCHrPgkUET1Ub/OycYlH3lNsTmNvuKeOb60fgV+JturcpKoCLkGyQzqQ2DOPX7lWe4kSdSNOmW3ZVmdEtWz0OUi1N3HUwQaTT3bdoHhGmlZxYw2f8oj6lVlyd6PdvwL6WbKHxvOzU2/A5xWVW4ia5+QRzhIMfTuPyE5AhC+Py5M+ooVa4mQherDurm4QCCs0n57pw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Date: Mon, 6 Dec 2021 15:15:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 0/7] x86/boot: (mostly) video mode handling adjustments
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0022.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d127622f-a535-41fc-fa8f-08d9b8c2e5d9
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2446:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2446E60D6ACAAC427DE6B9D1B36D9@VI1PR0401MB2446.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OkUW5ROvyFkgvMYwFFfremzPQGVdiSj8d1Sy0rL006DXITiOcbSPi7kPDCawI6bPUQyIeGNHQAUFP3aMzG3Y9PPCCYH2a/pFgyAL7Ub9ixAPLnKSsqF7v16MO/i2cox5DuwTOCb3SKAvCKo6C8ntPrZ6oLdS2D6rKDzJ14umjH07n7OkfKh13Tntyy6ioQpthp6jAMKB9PEKKyzaAr4ft+aq2kNgC2cwa+9sWW72E4j5d2sR9mmnrgbV3b040Q/03UnvFCBHAlzfVMOkbBNTbsndbhRGLsCZT28gFkDvUh30SBd5+xRp1KLsVlve4zE0hnkWeiu91Mr6w520ldWra7GYuvuPlM6JQ5847bZE9qSBzI18suY9lhEDefJlebgnQF5fvmjZf8t1i8N75tAxUW/ebTgJ5RPXtxWW0HtCDCdAdXUSbU1kZES4dQ2MldPdbar5gPq/5MxA/n8AUYZSteJKI+oJM/zsJlba7BgtwVEjHztQOPV9RAg9vhRVjRizBY6DbPUD90UPNywz/pSrezVsoRYswglV6F+fAK7I1d67ucb3xaw90wYLOEbtxHrtcx2jEMkthrMW0fBcDx23IpPCAfd/WcAZAA+Mg9/8CNolWWigpx8GtHKkB2we8QQJzoo/gVsMyMIcTa4pwVtZyT/cllYwqCyef6Wypt1dKFEXdd48TTzpmRqixPX6TjEcgodC8hbmSEQNeaPRL69a1h5SeU9zZYgupG1dt7znV+w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(54906003)(8676002)(8936002)(6486002)(4326008)(316002)(2906002)(31696002)(186003)(508600001)(66946007)(6916009)(66556008)(4744005)(36756003)(2616005)(956004)(66476007)(38100700002)(26005)(5660300002)(31686004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SEtPWHQ4SGo5NlZHSmNicnF6SVlDMGFmK3ZiaFplL3JtMTJCb2t4ZEExT0xG?=
 =?utf-8?B?Q0VtZmZyVnlkMlRJYTVaWG01TldhbE5weUZLajhuWmRFS05MQ1FMZGdzYSs5?=
 =?utf-8?B?bFljV3VMS1FWVVpTUk0yd2pSS3pHeXRnaTFQMjFicnFCV3dNWjJRUUZSOW9S?=
 =?utf-8?B?QURsdk81MzdRdHdQdHFvQTBUN2QrTlNKS1JOQmwvSXVRRjhtK25UY1UvQU1n?=
 =?utf-8?B?MDZxSzk5Wk1TNUVBeEpFelFUV2MweXZQSE1VU0ozNjJoenk2R2NEUDBrNjNl?=
 =?utf-8?B?QUk2UitMTFpWeXF2WlltaGlSeWxKTVd4c05ndlJkRk4xZ0VaZDdNZlNOR0pK?=
 =?utf-8?B?dHpSN2JhMExyVktLeUFyMnlqSVlNR1c2L1JrRDVBS0JOMTdpaW5MQ3lpeG1p?=
 =?utf-8?B?Um1OY0hLRXBiUkgzai9LbGY0M09kRjhpeUlQcXloelFvRU1qWUc1SzRTZjU3?=
 =?utf-8?B?elR4RTlaanNZd1N0VnJiVDR6TG9oa1pSS0xIeVRhdmdzREpQcCtaMFNIenBp?=
 =?utf-8?B?cWp4dFFjbzhvMkx2VnhjQ1E1cDBUWmp1N2F3VTYzbXp4Smoxdm5kekhNOTNp?=
 =?utf-8?B?OWllNmdvcUJ3akk0M3g3Y3VlbGVIS200TjdUM1UrOTlEV0ducW9pZklxcHRq?=
 =?utf-8?B?WkNWeXNzKyttRXk1Q0pQb2RMMXluS01vVVE5bWVySXFaMmt0YmRBcVRXM3JN?=
 =?utf-8?B?MW1XeVRSMDBhKzFwZ01qYU1DT1VQbTFyMVhhTjdSd3h6MzNGSVVwVDlnYzM0?=
 =?utf-8?B?dHRMMGdINHdZQzJrQXB3UGNpbFQ2VFJnU1plZjg0a2dFNU9tY0pRdDlndlBj?=
 =?utf-8?B?eTZrU3BaTWxjK1R3YUxPVnk3TXVaMnYxb0V5YnUxR0p6bzYxRk9MenJaeG9R?=
 =?utf-8?B?Y09EeHZSblEyNEowNWtvTy9IOWNET3laa2ZNaFBhNlVJN1ZuTnU1eHJyRGFh?=
 =?utf-8?B?bnFaNlBoeUJpMkZZR1dPaFhDckJiVWl0ekdBT0t4YnVNU2xyU080TVdrNEh2?=
 =?utf-8?B?SHh6VG5HL0dmbmljNERjZmNZUkcvZXVwSDIzN0lWdXVNK2c4U2ZtZzVyUXVh?=
 =?utf-8?B?SC80OFcxL09ZbURFQkFRWGg5UjJZSmZMWExMcWl2TE5MOHZ1cm9HTFVNaDYr?=
 =?utf-8?B?UjV1TjVKaTBKVHZyZmFPZEJOWjBHNHZRSUtkb2tKUWZ3MXhzVVdPUzlWYng2?=
 =?utf-8?B?dzF1SzFPK0g5RGJ6YUMxQXowbXJsZWNESVhCZmhwdWVITFRQdlRTMmhoUEpW?=
 =?utf-8?B?cHpSL1UzOEVIVTJITGwzNEI5SXpFSC92OGcxQ3JBc1JEWm0xTW5IU3pzVmsy?=
 =?utf-8?B?RHk3ajdvY3hqRG5ZL1gxU1BMT1RxVzZvV1RnUlNxY2xYODZ1RG8xWE1vcWV3?=
 =?utf-8?B?MENkdE44T3dWd0M2MW5EWVFmRG1ITWZtYThmZ1FxdHR3Ry9XeS9XR0x3cHA4?=
 =?utf-8?B?OGN1bWN5RHlCU3Awem5CRWxpM1gxMWE4ZWNxeVd0WnB1QTl2ZGtRaHhONjRG?=
 =?utf-8?B?VG5BVjhoWk5KdElmQTNUTWdPRUZGb3VsUVJaTk9peVBYVnZEZytNdm5LMWI3?=
 =?utf-8?B?MC9ON0xzRUdzSGZxZ2o0SVNIMkhXY2tpWTFhZTAwT3lJcVVZKy85QTVFanpG?=
 =?utf-8?B?SkFEV0dKakxZK0plU1NKdVNCeEtVb2VHaGk5ZEc4MG5Cekc1ZmtVYzRrV2Zl?=
 =?utf-8?B?V0c4NUN4cjN2WU9FNVkvM1NJcVB5SFVLN2pnaERqVFdqRlNpa1BiMW1QQnZs?=
 =?utf-8?B?MGNtaThTRUdFRUIvbVZEcWJlbk5GczYyR2dYUEJsL0NCaEhHT3dHWFJ4anVv?=
 =?utf-8?B?U3A2VStVZW1ZTDZUTGY3d21JWjlnbkNadzN3OHpzaXlzSWcxOEhBSCtSdTNP?=
 =?utf-8?B?bzdaWENKRlZ0UndSMDV4cWEyT0xkWVVTRnFZajVNditRMlpHSDFrSXdSaG5y?=
 =?utf-8?B?STJrV29sQWcvT3Y0Y3NRK1pobUQ3VWdFQlB1d295akd1dytkellpNG14ekUv?=
 =?utf-8?B?VDJQbEc4c3U4dCswK2ptWThOclhxS2p1dHZFUUlaS3Rnbi9Ob0l1bWZXNjVm?=
 =?utf-8?B?eDZTc0twVWZuaGI4ZVBBdDBaOExobktIenNubzdERnYydUNmSWhHTTV2Q0pj?=
 =?utf-8?B?ZTdHUEJuKzR1NjcvT3lwK0FLUGlhdVdZVExuUE0rWWJic0k5UDBYeHdrMk5p?=
 =?utf-8?Q?2IBoDz1oeN9fnGPJSYXQAoc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d127622f-a535-41fc-fa8f-08d9b8c2e5d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:15:47.0719
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: voJhRoJOfspdgdvNKzXVvAjh0kkdxZnYoXFzqyMop4WYQIJFvWrdv6Gs4wWXKQHxgnUub12Sw6pIvEqVinVO0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2446

v3 has only some re-basing changes compared to v2. I have to admit that
I find it particularly sad that the enhancement done by patch 1 has not
made 4.16. This series had been submitted well in time.

1: make "vga=current" work with graphics modes
2: obtain video info from boot loader
3: EFI: retrieve EDID
4: simplify mode_table
5: fold branches in video handling code
6: fold/replace moves in video handling code
7: fold two MOVs into an ADD

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:16:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:16:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239050.414327 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEnQ-0004fA-Iy; Mon, 06 Dec 2021 14:16:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239050.414327; Mon, 06 Dec 2021 14:16:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEnQ-0004f3-Fg; Mon, 06 Dec 2021 14:16:48 +0000
Received: by outflank-mailman (input) for mailman id 239050;
 Mon, 06 Dec 2021 14:16:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEnO-00043L-HU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:16:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2499bfd7-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:16:45 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-S5doW1pBNbOVUk1ADMe3mg-1; Mon, 06 Dec 2021 15:16:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 14:16:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:16:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:20b:92::44) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Mon, 6 Dec 2021 14:16:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2499bfd7-569f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800205;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CCXIWoro/Z07Cad4JvCje2Mc2lnFKaod9gLVxAbT61s=;
	b=VK4wlbeg3uq4fs9BscC0rchGvYuCq1nSGaNbUcpu8TDiEVBTsNmPWLE1gYsl+oDs1uMA+f
	dXh92Pwr3ou5QoFE2txYrUj5TQBa+BZ3CD0A8PmiIlZp8slOHc4l1zPMKfJK+xorW9r48Q
	zbUrUUSG0KazhuR0Nc+APIrbMqz9gok=
X-MC-Unique: S5doW1pBNbOVUk1ADMe3mg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Vedn7eq2GorbbUlO/9kDE3arJPck3DHKOvcVftHLeirJhXpMSp84dR4i6eb6gWnRheFDGqunfoMAsFprtMzey3uC0dQcQvUosVWZd68+CWnHQMx+3xCAeRhaXjpzvDf+KIkPngQaeEDi92yk0MnduT6VLmU7rOaTd5v2AqUrNxqAX995x4y49adyoizd3wkb31BpD957ol+7jJ+2PddPFHomgdJCiI5DGW61twBrlGYgaxKyt1xeJOjyYteWs3dqKxEq/URSPLtSqm1+UdvK5ktaQq0QbFtiGeYo+mlMsiDeot3jwZFfnudr9oBZIdpmbz52uzDMNWwleMCaB3y5HA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CCXIWoro/Z07Cad4JvCje2Mc2lnFKaod9gLVxAbT61s=;
 b=GurcxUDor/UPoY3EAlHXMuYTGVV9H+CVHicPVl1Lfbswkec0h5PtMr25r15Ua+JLfe3l50IXso8OXJh/qaqrgsjxszYCPiRSuK1zu6zPGFc5BY86vSotvRFf1ukvuqxhTY1HosHmv3yczDO19zIdueIb0z5yO4c+ouVvf5+jdAiBTsonH3byMfEtWaBLYLXUUbNFz3Y/O155byjhpMuEYv2v1NMjPyP7fCGLlNwJju6fzSTdP89fAEaBscdfWl9linvK0P8vl9+oV94EtObf2ooGrQZRNlhZx62QXJQUEH8ZEeL8NA5KYO6+2eNluulZAtBHX3DkDdlB6t6CWqbC7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <66a73afe-6d32-9c1a-0346-9344877690a4@suse.com>
Date: Mon, 6 Dec 2021 15:16:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 1/7] x86/boot: make "vga=current" work with graphics modes
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0031.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::44) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 64f7dbdc-3ad2-490d-72e6-08d9b8c30759
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3774372C6571D2819AAD0F27B36D9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	O+PpJ/kzbGUCkLn7q3co/3/n+Qu87W5Hj1UYS87FNos4pBnYRzQcImNmdzUUuGIdBWaD937PnniEREZJbIO4pXx8vgrdBTNSrOvNrjNzmHm8ltv0UZcNpEBFrKY4c1J7+T35G0xhC0++MiUVt3ZECgz9aD9py4jy22UW6nWEJHog6PGjsKKllO0u2TO0AzISasMT51VkLVbBTo+x9s4Aur8lWz5MLJ6G1ehn6tp2vPjKN1TW6bcl4hHqfmKMFAaGMjTbSBmpiC/Ly2Zp2X059NNN2bKjLjYgVLXjT/buxhCKKWzyo4i/i3027sychJgmJ8/U07JJJofBS8ss7gTv5rNrK5xFuC2ZqB/3TQIipRpLG3P1Ymq6pHxe//1jYPwHocqDc7zD0LE/jeH8CRmEp8C/TjysogKkQxwGM6AWLFuZFAQ+D8Z6hN0nXVHhwGU4eKLFparjoWoYb6rGAIBZJgAED5lENd0YUH95+5toTsEmfZKkVl9yoFTU7q5xkcTPRthPRMt0uVk7IG/nm3De9RNPSrKmikY5HHP9Gvs4VKWPceUfSP+AC5pSJJ6IVY9x2ElwcvSfiRBpcX2eFYFAbpgt1t5xPAptWXPbBKJKIjpzN20UlczGNsFW/DVg1MSnt/zJKeRuMSDY08aNt0I/kWiLss6ysu7p6VoCcMp+SUeBEtLaOe8CYV0iwGYMXvGosjXUA6BQrXWqxHsVopFxnem3QVDNwdwyNoNJ+SAo9IY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(4326008)(66476007)(66556008)(66946007)(8936002)(31696002)(508600001)(31686004)(6486002)(8676002)(6916009)(956004)(5660300002)(186003)(54906003)(83380400001)(2906002)(36756003)(16576012)(316002)(2616005)(38100700002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZFp5ZTlvNnFWRjQ4bkhmSWRoNnFrdkFoR0JUd3J5eE8vcjRJdkl4MEJUcmpp?=
 =?utf-8?B?anFhcXZKbzRHdlZFbEs5Z3J0bUdIcXhVWGdaMndBbjZVL1JEcDR1K1BPbkF6?=
 =?utf-8?B?bVN0VGVyL2h2d1BoZzV3ZUp4QTdhTmFyTUtQQlRRcmZmRWoxQlg5QnlhZWxN?=
 =?utf-8?B?RHBmQXBOdUZiODRIRTBleDBEVy9ZWkxLdFFnL1Y4citvbEV2RlBtMkNmZmJh?=
 =?utf-8?B?a3pyQkduOFVHakIvaG9UTHdQZk44WlplcVNJSkZlaXdxN25Nei9wZDZTellF?=
 =?utf-8?B?QzBkaFN2Zk9XcWVHNVFub1YyUytyT0xYMWk1WERNdHhublJ1MU1rUmhibFNn?=
 =?utf-8?B?dUpQd1pkYlc2NkF3d2IrbHE2bGw0eVBUVTB0Qm5JQ2dmclJlYmIvMkxjdE92?=
 =?utf-8?B?ZEd5Z0JWK0FtSW1WRUxHQVRjRDMrTlZZalZYTi82M3BjTnlMK0Y3RS9vVW1i?=
 =?utf-8?B?Z1VCRnR5b2Y1TEUxNk5hSTNEQmxXa3hwT3ppVHF0M0NqUDJxRzlRZ1RoLzho?=
 =?utf-8?B?dFZBUUhZZTViVHB3WUNRTWFSNnE0Z05ObDlHVDEzVGkya01xaHhKS2U0NXdw?=
 =?utf-8?B?WlFmTmQ2V2ZsempMOTZGbEExVDRkZEt4L2xDSWRJaHJvaEF4SEhOVlJVQ0NU?=
 =?utf-8?B?WG5QRmJhTE5pV2JpQU5hQ1ZPUGxNNnZDV3Fqd2NoT01lbE12Vk1COFJiSjNl?=
 =?utf-8?B?M0piTWF2MkRMSWRUTXQ0QTcxVFhQeVN5ZEJwSkxGS0hod3M3UXJTNm5nK1VQ?=
 =?utf-8?B?Z01RTVY2QVdmOTY2MzlLdFl5TEJXUnQrM2ZUS1JvbDhacVYrNHJzQ3JjZUFQ?=
 =?utf-8?B?TlRhRjhwRjRKdjVvWHBwZ3pqYW1CNDE4R2tRWE5ITGdGQ21pK1VFRElFcXp5?=
 =?utf-8?B?dDhQRU55OHorYjdpNkxPQk1JMm83NjdTcFNWMXZlNUc1WHpFVEZ2S1FmVWp3?=
 =?utf-8?B?N3Q5Sk9aemVqaFB2YmVPWVNGc0Qxb3hCNW9YcUF0ZW54VFBEZm9SbU84NGJE?=
 =?utf-8?B?bXJsWXBlUkJ3a28wS2g2aHFkLzB0enp3TmZWU0lCRFVQT1I0K0RsTjNZVktU?=
 =?utf-8?B?WXZkY1ZXUFhqaElnZVExTTY0MEUxNXlDMDBVYm0zMmNTOXNhaUoxS1N3M3RJ?=
 =?utf-8?B?dG1ncXZwbXhCcHRDekJUU0trYzZNYmZBbHZYVW5MMnZIY2FLYkJCcnAvRDRD?=
 =?utf-8?B?M0tsMjBUbjROdGtMOXp2dHdMcDRsSmgxUFNxSDZYY3FzQ0duRFA3WjVNT2lY?=
 =?utf-8?B?OXFsNzl4ZXBIUmRPNndkK1JCUWp4S1ZETStublpSbEdDeUhEY1loenhZaW1Q?=
 =?utf-8?B?a3ZZclNOaTlxeEFSU3F5UFRMNDQycGt6TEJaTkhyaEcveUZqeG9PeXFoL3hZ?=
 =?utf-8?B?QWwzeE51bjVYZjVySTNaeDlHNm5RUEEzRGljbmlOWG1ZOXFKRVhxdmtnSUNw?=
 =?utf-8?B?WkloZjE3cUtWMGlzMmNQYnU2RlRMQ2I2RDFQc29aaGJXOE1IbVYwNmRBL0tZ?=
 =?utf-8?B?K1lVajFxbGExOFdaU3Z3ZUlYd2hBNnhxNjFRZExPT3dLNDRBOFZZU1o3MHg5?=
 =?utf-8?B?bVMvQlYyYVBxbDFUSVB2NlRONndpWWVRSDBZb2xMN29wVlFhaG1vNjhzR2dX?=
 =?utf-8?B?a2liNzJlVzVVTzZuYlNIQWhFRUZFOWRkd2R5QXM0dmpiQnVhQXlsVCtrQW1w?=
 =?utf-8?B?YzB6NjNkdXUwYlF1TUI2TXE3US9wcVVublFDOHRNNjhnaXQrZEdKdmlXUWll?=
 =?utf-8?B?YVVPQWJxZE0yVGRTT1gxWU5MVURTL0FSbXNhY1RjZElpVmwyek96SFJsYksr?=
 =?utf-8?B?STUwQnFneG5XVFJLY2dUdGthd1dSR2NURjEzMk9GdGtjRUgrdmxWYUtqZ0Va?=
 =?utf-8?B?NWIzc3ZscHhvaUNGOUlvNFVROUZscUFhQ0huaFZWMmt5N2tsOFhwWk5oU2hE?=
 =?utf-8?B?THhUS3VjUTZtdXpyM0F6ZU9WZHNIa0YvTTJ6WmxhanFBYUV3VUUvYlI1SFpt?=
 =?utf-8?B?eWsrSjBvOXpXM3B3dzBHRVpWT0lqalRqNmFzMjJVOFRZbXJHV29mV2NPaDlQ?=
 =?utf-8?B?OWF4aU50aGJXRko3Zm5zblJrYzBaZXVxWVJXcUs4aHNzblJxbHZYUVpxQkxS?=
 =?utf-8?B?UVF3WmRBZEx3SkJiK0FtUlhtOTFyZW5NUE10T25iNU5vODZyS3JCKzdWcVNR?=
 =?utf-8?Q?P81LI/kd1zCpz+m2hnlz3uo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64f7dbdc-3ad2-490d-72e6-08d9b8c30759
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:16:43.2391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 91NTFtDtz5KSApjkElcJEUVVqVV0INb7tnpA353mZXvpOGTdeLujSVf6eFaYI88vcmbYXGD1Flg4S3vAeTLyFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

GrUB2 can be told to leave the screen in the graphics mode it has been
using (or any other one), via "set gfxpayload=keep" (or suitable
variants thereof). In this case we can avoid doing another mode switch
ourselves. This in particular avoids possibly setting the screen to a
less desirable mode: On one of my test systems the set of modes
reported available by the VESA BIOS depends on whether the interposed
KVM switch has that machine set as the active one. If it's not active,
only modes up to 1024x768 get reported, while when active 1280x1024
modes are also included. For things to always work with an explicitly
specified mode (via the "vga=" option), that mode therefore needs be a
1024x768 one.

For some reason this only works for me with "multiboot2" (and
"module2"); "multiboot" (and "module") still forces the screen into text
mode, despite my reading of the sources suggesting otherwise.

For starters I'm limiting this to graphics modes; I do think this ought
to also work for text modes, but
- I can't tell whether GrUB2 can set any text mode other than 80x25
  (I've only found plain "text" to be valid as a "gfxpayload" setting),
- I'm uncertain whether supporting that is worth it, since I'm uncertain
  how many people would be running their systems/screens in text mode,
- I'd like to limit the amount of code added to the realmode trampoline.

For starters I'm also limiting mode information retrieval to raw BIOS
accesses. This will allow things to work (in principle) also with other
boot environments where a graphics mode can be left in place. The
downside is that this then still is dependent upon switching back to
real mode, so retrieving the needed information from multiboot info is
likely going to be desirable down the road.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm not convinced boot_vid_mode really needs setting here; I'm doing so
mainly because setvesabysize also does.
---
v2: Use 0x9b instead of 0x99 for attributes check: I think the value
    used by check_vesa also wants to be converted, to match vesa2's.
    (Perhaps the value wants to become a #define, albeit before doing so
    I'd question the requirement of the mode to be a color one.)

--- a/xen/arch/x86/boot/video.S
+++ b/xen/arch/x86/boot/video.S
@@ -575,7 +575,6 @@ set14:  movw    $0x1111, %ax
         movb    $0x01, %ah              # Define cursor scan lines 11-12
         movw    $0x0b0c, %cx
         int     $0x10
-set_current:
         stc
         ret
 
@@ -693,6 +692,39 @@ vga_modes:
         .word   VIDEO_80x60, 0x50,0x3c,0        # 80x60
 vga_modes_end:
 
+# If the current mode is a VESA graphics one, obtain its parameters.
+set_current:
+        leaw    vesa_glob_info, %di
+        movw    $0x4f00, %ax
+        int     $0x10
+        cmpw    $0x004f, %ax
+        jne     .Lsetc_done
+
+        movw    $0x4f03, %ax
+        int     $0x10
+        cmpw    $0x004f, %ax
+        jne     .Lsetc_done
+
+        leaw    vesa_mode_info, %di     # Get mode information structure
+        movw    %bx, %cx
+        movw    $0x4f01, %ax
+        int     $0x10
+        cmpw    $0x004f, %ax
+        jne     .Lsetc_done
+
+        movb    (%di), %al              # Check mode attributes
+        andb    $0x9b, %al
+        cmpb    $0x9b, %al
+        jne     .Lsetc_done             # Doh! No linear frame buffer
+
+        movb    $1, bootsym(graphic_mode)
+        movw    %bx, bootsym(boot_vid_mode)
+        movw    %bx, bootsym(video_mode)
+
+.Lsetc_done:
+        stc
+        ret
+
 # Detect VESA modes.
 vesa_modes:
         movw    %di, %bp                # BP=original mode table end



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:17:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:17:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239055.414337 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEnk-0005JG-WD; Mon, 06 Dec 2021 14:17:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239055.414337; Mon, 06 Dec 2021 14:17:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEnk-0005J9-T9; Mon, 06 Dec 2021 14:17:08 +0000
Received: by outflank-mailman (input) for mailman id 239055;
 Mon, 06 Dec 2021 14:17:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BmDh=QX=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1muEnj-0004et-4h
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:17:07 +0000
Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com
 [2607:f8b0:4864:20::430])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 308f6e8f-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:17:06 +0100 (CET)
Received: by mail-pf1-x430.google.com with SMTP id g18so10286237pfk.5
 for <xen-devel@lists.xenproject.org>; Mon, 06 Dec 2021 06:17:06 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:18:efec::50b])
 by smtp.gmail.com with ESMTPSA id
 d6sm10030597pgv.48.2021.12.06.06.16.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 06 Dec 2021 06:17:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 308f6e8f-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=MlPjTzqAzGMiJV1XIvo3CWuIKKPvCgUAVf8fFzgqOVA=;
        b=aUNHCl+dyTHAibi55HobGp+ZEySdQG08OEI+Y5k9nKK1X7xf+qtKsmguZgkbi+whPm
         GdJx9SeuhwP2ruODw9GfMgbHlzGk1gA6u4kF0GNnRTEbqTtzWhv5aQOvFkSisqrp80Je
         AuiZLyvBxRbWVKNJfUOgUEgQe+/ruz2KLZzOD08be7j/r8WHZNcwGCfhgny3RP1zHKHA
         1KDnGlCjbWtR+gN0SkVDdYDBRV83mT0qrFufECTGnYo50zNSja6vhsEoHMcB7bAvEpfm
         2tJ0a1+Qw3wjhe2hKKQCf2+fKGAqtRWFQXDtWW6xNYHAMZ+JXZUxTRR80tunhwvY2yh9
         HWsg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=MlPjTzqAzGMiJV1XIvo3CWuIKKPvCgUAVf8fFzgqOVA=;
        b=uAY+zmvbsLUciXB0+mBoaDn4opAxITg35DZzi+BHJIXWNnK7U+GaDDoFOBwzvuFMAC
         K08dqzYRPbVwRUus94dJgkFzdYMNLnC7umO4Y2FiK6n3Sjh+hSCLUzaVXspupwypB8Vy
         WlGRlL20gY2SduaIy+yNZZHfoxfNsjdLRextcktri8vH7t+Fyct+zWbSPxEihH1F2VKa
         wg0THv/NLAPVzA2pexMxITWE470Wb4sVww/4ZtH5kb+OQlxzR8VFQ0BfYBQvdSGmPzmJ
         iAIKtMkyvgLHPilrIf0LdgYXzFUVGjS64fd/m8oHSLRZhQvNdeT9D+JrOqFu34lQMde9
         2ZGg==
X-Gm-Message-State: AOAM533Z9av51ene6YD2vXld1XBxE8rv/NK0hSTUyLu8bcZFRyxj2jH9
	dpb5ehkuI9vr4BVtMyxRZsM=
X-Google-Smtp-Source: ABdhPJwC0KD/zVGir6spSXosBbRFLHsih0Tulm1FqYapzoO5PMARObP84mGb9GeA31fKmf/7FDoFjA==
X-Received: by 2002:a62:1cc4:0:b0:49f:99b6:3507 with SMTP id c187-20020a621cc4000000b0049f99b63507mr37506196pfc.76.1638800225207;
        Mon, 06 Dec 2021 06:17:05 -0800 (PST)
Message-ID: <ed333f81-0527-ae98-6348-a2bf6e783dae@gmail.com>
Date: Mon, 6 Dec 2021 22:16:51 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V4 1/5] Swiotlb: Add Swiotlb bounce buffer remap function
 for HV IVM
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
 wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
 hpa@zytor.com, jgross@suse.com, sstabellini@kernel.org,
 boris.ostrovsky@oracle.com, joro@8bytes.org, will@kernel.org,
 davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org,
 linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
 netdev@vger.kernel.org, vkuznets@redhat.com, brijesh.singh@amd.com,
 konrad.wilk@oracle.com, parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-2-ltykernel@gmail.com> <20211206140916.GB5100@lst.de>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <20211206140916.GB5100@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/6/2021 10:09 PM, Christoph Hellwig wrote:
> Please spell swiotlb with a lower case s.  Otherwise this look good
> 
> Acked-by: Christoph Hellwig <hch@lst.de>
> 
> Feel free to carry this in whatever tree is suitable for the rest of the
> patches.
> 

Sure. Thanks for your ack and will update "swiotlb" in the next version.



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:17:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:17:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239060.414353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEo3-00061Q-B9; Mon, 06 Dec 2021 14:17:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239060.414353; Mon, 06 Dec 2021 14:17:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEo3-00061H-7Q; Mon, 06 Dec 2021 14:17:27 +0000
Received: by outflank-mailman (input) for mailman id 239060;
 Mon, 06 Dec 2021 14:17:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muEo1-00043L-Vy
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:17:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3bd67aa1-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:17:24 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 49A5F21B45;
 Mon,  6 Dec 2021 14:17:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A97513C4C;
 Mon,  6 Dec 2021 14:17:24 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YwUeBXQbrmFENgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 14:17:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bd67aa1-569f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638800244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ci4XGMPd4XtETtT8yrd6qqmUEhD9O23TZHpCQkVi1tk=;
	b=P8H03erbeHbkyRoLuX8UKi1ZswOrKYHzumFywaQfHesIRVEi23MmdkXbwm5UWGqVKC0prV
	5uJ8ASQDZrKIFQdPAfI6SyLrW0RXd0mojhSNyGF7qpklNV/4mEVjc7/mG1F0MV+XhylMwd
	hYNdF4r9iYTdExGrGkYUuGIlEfCMxRU=
To: Jan Beulich <jbeulich@suse.com>
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206124612.24758-1-jgross@suse.com>
 <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] mini-os: support event channel 0 for console
Message-ID: <4cd75f8f-9026-9d3b-750b-3f3c6eb200c2@suse.com>
Date: Mon, 6 Dec 2021 15:17:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="EldJmA8XQezjl9Kra1ypXlj8GflOIsPrP"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EldJmA8XQezjl9Kra1ypXlj8GflOIsPrP
Content-Type: multipart/mixed; boundary="2hNHuU50ZUpvu1NRS1f8nBdWgvnfgdhwD";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: samuel.thibault@ens-lyon.org, wl@xen.org,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org
Message-ID: <4cd75f8f-9026-9d3b-750b-3f3c6eb200c2@suse.com>
Subject: Re: [PATCH] mini-os: support event channel 0 for console
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206124612.24758-1-jgross@suse.com>
 <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>
In-Reply-To: <39a4ae01-7ea9-7526-74da-1fea71274890@suse.com>

--2hNHuU50ZUpvu1NRS1f8nBdWgvnfgdhwD
Content-Type: multipart/mixed;
 boundary="------------FD3935A15D5EE7887C6FDEA3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FD3935A15D5EE7887C6FDEA3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 14:24, Jan Beulich wrote:
> On 06.12.2021 13:46, Juergen Gross wrote:
>> The console event channel might be 0 for the console, so use the value=

>> of ~0 as invalid instead.
>=20
> I may be missing something mini-os specific here, but in Xen channel 0
> is always invalid. It's not just here that this value would be used as
> a sentinel.

This made me look at th domain creation paths again, and it seems as if
the parameter settings for HVM guests is split in an awful way: the
console ring page pfn is set from libxenguest, while the console event
channel is set from libxl only. :-(

This means that this patch can be dropped, while init-xenstore-domain
needs to gain another one.

Thanks for your feedback,


Juergen

--------------FD3935A15D5EE7887C6FDEA3
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FD3935A15D5EE7887C6FDEA3--

--2hNHuU50ZUpvu1NRS1f8nBdWgvnfgdhwD--

--EldJmA8XQezjl9Kra1ypXlj8GflOIsPrP
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGuG3MFAwAAAAAACgkQsN6d1ii/Ey8L
WAf4p++3OidMd8W+sJDBABGF/LRbbdyxcSoMW7KovZ5qC1oAwhNTxeH5+aKo1gKFdjqq8G1LGvFr
d6xn3mVeKCHDv5RTkdJ0yxzsVlF+CPrumk71ERzbZ5PDOfrc8yJG/Qmyb/LyIllP1nYv/gMonFSX
uPnbc6aptWhqeajjtsX7Z6z5fA/+P7DjnqemYpXuHxxx8JKXgsVjkALwTHTnMI+mwaiWze+2QovZ
xh1AQoPmrTBzhC9OgqEsFqlgOQzpma0LDYBJZGevcuL32Mi6U3sm57GtVMKlvF2g7AglJh4/glMQ
mWbWv06l4biMhTJ3LlHmSZEiVQ1V8WjfP3nAnyLI
=gvaW
-----END PGP SIGNATURE-----

--EldJmA8XQezjl9Kra1ypXlj8GflOIsPrP--


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:18:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:18:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239065.414364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEpN-0006rF-Nl; Mon, 06 Dec 2021 14:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239065.414364; Mon, 06 Dec 2021 14:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEpN-0006r6-KO; Mon, 06 Dec 2021 14:18:49 +0000
Received: by outflank-mailman (input) for mailman id 239065;
 Mon, 06 Dec 2021 14:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEpM-0004et-GJ
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:18:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d26117a-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:18:47 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-d0_4mdOCNhGb3VwROfVe9g-1; Mon, 06 Dec 2021 15:18:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:18:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:18:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0040.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 14:18:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d26117a-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800327;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EUZmArQIIQmbBqFpDtIyWDFCexGoWWvsGI0iICXtIpk=;
	b=NEOoqzDVdLBcFShl3f3b86XclGBMqTVisffNRFPgJHDPxjBs6i1Q4yPdxwBN5SBZUagbBv
	DInkDNMqnnO5yTqw9CcRDjD69FLoSakPtJJQ3zd7Ih9TLsiPobrAOHME6DCfUcyJ/+DspS
	XiIGXsygN6sPR07myONRrlrwMmgD/yI=
X-MC-Unique: d0_4mdOCNhGb3VwROfVe9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m5ekcXEZMaAJPtHRN8ZmvFY1+ZSsJcDxTyOs4Vm0ukkrzPmxnXA5WViPw8sO992hPVS0bJ6m6ghSIg3J0tumDxO17M222No93K6ITJevNJwo+UW/jIWNusC/aiZpiX0AMsmMHtQfk5uqW8jfu7CyllXO3+fzugI+xWXFux7HGGY85Y1X04oB3R1CafS/PgTH86EZHBUZctyIsD3XvgI5TIHphqB/htkWcvFfToX4jO39ENgoPjbxyDWZlCpCQgkyR6EQmwMQ+l7aE/UEVwSiCP0X/S8wyAoPQ6P0d1V7HJJlYElW2fJ8/AN2RyuXdgC4OBssmoBAxwpNyPxWSIsvrw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EUZmArQIIQmbBqFpDtIyWDFCexGoWWvsGI0iICXtIpk=;
 b=clqfn6WVdhoqMsRS01FC6buM0UkJb5Hj+ozOyQRFcy76k9p4agpYcFlLfylaEfdILU8skhVM6L2HMUaBgZx18o53gP63O4ym9OkdHCY2kG4UHWWhP1FKkKRtYGHQxo7X2c+Hbg7JVqUs634XBdF4Ni9Vp6EvzRQcpPhIBxv9CTLgKFasCNS67PaoulhH8t5+uOlRHEeYVjMBYrdiy5qR6pEl7OCjGa4Kwuk5zG3/Zx6d0uQyACpxIQOWTRuBWzbaQhiVycjV9rCfZhNZ7vPw28pU5GFHmgEhUzCOzLPrQ55AQ9RYn1OGS5dDzI1QjrJVwuyhTxXdAV7yB2Bi1lmhmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fa60f944-5164-977c-94e1-8b81a57d1feb@suse.com>
Date: Mon, 6 Dec 2021 15:18:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 3/7] x86/EFI: retrieve EDID
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0040.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8080d6ca-4ac1-4a91-c166-08d9b8c34f67
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23337B4F54C6996C7126DBCAB36D9@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2/if1WGU39mV9KB/HN+Rq7oGgjng2MyLWQs9czmiezqWDZo5pcEySYragH3zJHGt1DkYzc2loF2Uy6PX4Gxtvg6TJTOE9gog+atVztIPTTp6nwWQCd7VcFRKRTV6V97stGnFcwgfX3QJQrfW3F4iLN6CCWt9zKeke36M05XGvROK17emJUvQvzbzMkviRkLLodnvOUCMNY1BcavsV+Zg6gT/JntBqkXb6GaffBu0OhVq2JKUA4iUifGseELTGFBNEYp5Ac8ajrpYMpY76ujSSPQM9Z4qg7dtOSSD3nzElxTEmhmSbnxTq7bPOHxMXeBMBcqGziRgO9goSW9yRqjmWnnAB7G0OIYXsCQ4NqryIUkLcG/4D8tF/l1eOvqhsvIUNkzcsiEg0mIFQUl8qRf1XeVF8JO+Sv1NLLyNMdqeyJsdRfFHkU7mON1YJ/eXYsi2tGmO/HLS/G66YWo9rM7PeAS8Mn4caMquntx5y2O7qTbNzjp1Av4mn5uJtSgDLMgb8lG/AJnO7PqY+KQ1xzWgDm156vvYGCGA2albsfLX+0wzka6nV0WRTPzwwJ6Ba4lTACZ6jsTQYMpItWRuy8x5j5czgzReeH51xJeYnsJdHIR6SyO1WALwLDpfpWfKe6kYXt0PGONXtJwMy4QHTP6X0WUndY+RhcVzUBBIm0eQ7tG8Uj0YjjUSkG0beY8z7jSURGdSnpmf49cjhLQIi9pgmYWpl6aUlMCpemycCWzTmGCwtKW1dLhYeO4/yOmkrN4N/lKJZeM3m5PgW4XuV3Drqg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(54906003)(316002)(16576012)(86362001)(31696002)(66476007)(66556008)(66946007)(5660300002)(2906002)(508600001)(8936002)(4326008)(8676002)(186003)(6486002)(2616005)(956004)(83380400001)(38100700002)(6916009)(26005)(36756003)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aGwrZGRWK0V4Y1NCV0xBalpBMG1vcXF1bFZjNEdkZ0JpcnNkL2dKd21YK1BK?=
 =?utf-8?B?WVZnc3VuWDJpM0t4RTlYYUpjWitMSE16cW1YYjVERERpUFFTYnlGb2RyZFdp?=
 =?utf-8?B?Z3k0RE9oWk5wYUQ1c2VheStJdnJOL1Y3cTI3V2VlQVlrVGRVUG1SNnVmc0Jo?=
 =?utf-8?B?Y3R6L2xOUEpndVhYUjArd043bGY2amJjOUI5bUM3Vk56cXdvV1FHbDFGYUI1?=
 =?utf-8?B?MGtlMk5Fa0ovbzRyTGlKTFphVWhkUm93QTlwcWp5TWxVM1MrVmc0ckFjNUFo?=
 =?utf-8?B?ZHFWUmhyZXdyQzJSK1hDUEVlcGVLdUcwYmtLYkZNN0Y0NVdHVGJpY3YvRWZx?=
 =?utf-8?B?eW1WTzNTZ1NiaWxPTWRHZFpSWGFScVRwWk1qdHpDelNOR245TWxiQzVHQ2pk?=
 =?utf-8?B?b2NRdEtEb0kvNjBWQThKd2p4elBxRUFhTkRVTk1Ubm15Vzk5ZzI5aXVWbnZ2?=
 =?utf-8?B?eFNKVGVVSTBIWEZINkp3MG9jWUtkQzU4R1pUY1NBeEtwU0hJOSt6dHdCTHd5?=
 =?utf-8?B?TitwK1AwcWh5TjhEUUlpSWRnT1VEU0ZOQmxNSWVrU2dMYTlZK2VJMU1GVDhI?=
 =?utf-8?B?WTVZbjNpeDlKb2pqNWlDSkVCRFhoTm1IUnYycGgyRmFNdjl4WE9tVDJXWi9n?=
 =?utf-8?B?UnpwYXFWeFdlVm1lazFJeDR2WDNBbWFGRndZN3ByZ3RpeVhRcWJsdmt0bVNH?=
 =?utf-8?B?b3U4dnBYQWpSdFg5UUlhU3hnakV2a2ZyRkJMWHhDTXduOVhWcUM5R1B2NldX?=
 =?utf-8?B?Z2ZaYWNXb1hDdyt0alZYZy8rM0NiOFN3Z3ZSNmtzK1dxNHBabmlFK0ZjbG9h?=
 =?utf-8?B?ckI5ZUd1bTc4QlhPZXZibzFTZ1JiODBBZDNyMFhNZkh5Y2FjYXVhYnQyQ0dB?=
 =?utf-8?B?Nmw4d01LTjcxbkpWNmJkL3l1cFpXOHEyT2xNUzdHR1ovU29mU0taeW9qNWpr?=
 =?utf-8?B?dytiSUJ3Vk5MWFJnNm1CTEhKM21YdWtyOEI5MWRNSEFNMFVSK2lEQVVBVlRW?=
 =?utf-8?B?K2g4a1dzbElUOFQ0d1l5TWhMd3F6ZFJybmhjM0hDL3M5TDdMK3JaR3lxM2Q5?=
 =?utf-8?B?dmNRV1VWc3JnVGJnRVdzS0VUSTcrSjhGMkJScGdhbXpDbHZ6SHdaUUFYQTdP?=
 =?utf-8?B?RXpQUkxkeUFDWjNRekZIb1NHMzFSS0tWdlZZb1BoT1FKUThVQzg1WDZaNldV?=
 =?utf-8?B?aDVOTmd5QXFHTEJlaXpGV2dCeTRMeWpBMDZyN3FFT21rcUg0Qm1sdGVDWGJ0?=
 =?utf-8?B?RDBNZXpmTXhIa0d1djRRdEtTdTJpWkVMczVwYk8wTC9KZ2pNTWJDUHRaUjQ4?=
 =?utf-8?B?MzVLZllha2YrR3FhL053aUthL1R0Wm92QjVUanQwS0NuVDlscDNwT0daUVFN?=
 =?utf-8?B?QkZ6MWl5dEJyL3BrUFRSTFhSSUxWUGM5QlBoSnJuek1GRFV6blRNN0t3VTFw?=
 =?utf-8?B?Skp1VlJMcXBTNTJyR1RnNDM2S2lFVHdRbjNpMHVkR2x2aEhrM1lYK1lUUUhK?=
 =?utf-8?B?RzBRcnhhVElIRGtsVVg5a0ZwUC80dFZOL3JNdkpodE14QUE5TlkyWmNvaWlt?=
 =?utf-8?B?RUcrdEpwYi9HeXhkZ0x5KzMxT2JRaDJpT3dQY3V6NFVHUUtXTFpqWjFyS3ND?=
 =?utf-8?B?MGYwdnRoVTZid2lSdHdxWFpsTGZxZ3BHWmJFQVFjOVZ0VVg5cFJBYlM3RFUy?=
 =?utf-8?B?SXZ2bFYxSVQ3NGV1RDdhNnVyQkFSZnAvaXoyUUFDMURKWkEyTlJMaFhJQXo4?=
 =?utf-8?B?MnNoaGFPY0l1Z1E1dHE5LzRwUnhwVWQyalpvZTFEWDdRc2V2MHM4aVB1ZUhG?=
 =?utf-8?B?MVNtemREVnZzb1N5ektucDVUdWNiQXE3anM2cFhjTk1USjk5cGRRL1YrQkR5?=
 =?utf-8?B?NDc1UGZ6WVhoT1pyaWVNKzFjMldrN1NMMzBtclM1aHBkdUV6NjlRT2o5a2da?=
 =?utf-8?B?UEJpYWNpUnhPcTY3MUxnUytpVnFGeUM3VGt5QzZnNFpudWNiVkIwbWttVUps?=
 =?utf-8?B?c2VVSDBXSWwzZkZWVjZ5d09PQ05Da0IwdExkcDJib0FUekkySFhtRHpIVWpU?=
 =?utf-8?B?QTZuTVpLVGR0dWZHanJ4bUo3TjJNSi9HRDlHdURLekpvR3JIbERaN3Z6K2Vy?=
 =?utf-8?B?SDUrUUFzREpWU203bTNsSDlTR3N0NHFrY0ZEK1hWTi9QYWlFZTE1SXljZUhV?=
 =?utf-8?Q?9JHfACcxi4oL5AlfMLSf/VI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8080d6ca-4ac1-4a91-c166-08d9b8c34f67
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:18:44.1308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HAcS2Zfq+1VztLiy0O2oaOz4xK+s022MuyrojzchNeS6+SMvnkNKcfeL8RJNO7eRRwv5VnGVcWeJkHGdigmKTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

When booting directly from EFI, obtaining this information from EFI is
the only possible way. And even when booting with a boot loader
interposed, it's more clean not to use legacy BIOS calls for this
purpose. (The downside being that there are no "capabilities" that we
can retrieve the EFI way.)

To achieve this we need to propagate the handle used to obtain the
EFI_GRAPHICS_OUTPUT_PROTOCOL instance for further obtaining an
EFI_EDID_*_PROTOCOL instance, which has been part of the spec since 2.5.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Setting boot_edid_caps to zero isn't desirable, but arbitrarily setting
one or both of the two low bits also doesn't seem appropriate.

GrUB also checks an "agp-internal-edid" variable. As I haven't been able
to find any related documentation, and as GrUB being happy about the
variable being any size (rather than at least / precisely 128 bytes),
I didn't follow that route.
---
v3: Re-base.
v2: New.

--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -478,6 +478,10 @@ static void __init efi_arch_edd(void)
 {
 }
 
+static void __init efi_arch_edid(EFI_HANDLE gop_handle)
+{
+}
+
 static void __init efi_arch_memory_setup(void)
 {
 }
--- a/xen/arch/x86/boot/video.S
+++ b/xen/arch/x86/boot/video.S
@@ -922,7 +922,14 @@ store_edid:
         pushw   %dx
         pushw   %di
 
-        cmpb    $1, bootsym(opt_edid)   # EDID disabled on cmdline (edid=no)?
+        movb    bootsym(opt_edid), %al
+        cmpw    $0x1313, bootsym(boot_edid_caps) # Data already retrieved?
+        je      .Lcheck_edid
+        cmpb    $2, %al                 # EDID forced on cmdline (edid=force)?
+        jne     .Lno_edid
+
+.Lcheck_edid:
+        cmpb    $1, %al                 # EDID disabled on cmdline (edid=no)?
         je      .Lno_edid
 
         leaw    vesa_glob_info, %di
--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -568,6 +568,49 @@ static void __init efi_arch_video_init(E
 #endif
 }
 
+#ifdef CONFIG_VIDEO
+static bool __init copy_edid(const void *buf, unsigned int size)
+{
+    /*
+     * Be conservative - for both undersized and oversized blobs it is unclear
+     * what to actually do with them. The more that unlike the VESA BIOS
+     * interface we also have no associated "capabilities" value (which might
+     * carry a hint as to possible interpretation).
+     */
+    if ( size != ARRAY_SIZE(boot_edid_info) )
+        return false;
+
+    memcpy(boot_edid_info, buf, size);
+    boot_edid_caps = 0;
+
+    return true;
+}
+#endif
+
+static void __init efi_arch_edid(EFI_HANDLE gop_handle)
+{
+#ifdef CONFIG_VIDEO
+    static EFI_GUID __initdata active_guid = EFI_EDID_ACTIVE_PROTOCOL_GUID;
+    static EFI_GUID __initdata discovered_guid = EFI_EDID_DISCOVERED_PROTOCOL_GUID;
+    EFI_EDID_ACTIVE_PROTOCOL *active_edid;
+    EFI_EDID_DISCOVERED_PROTOCOL *discovered_edid;
+    EFI_STATUS status;
+
+    status = efi_bs->OpenProtocol(gop_handle, &active_guid,
+                                  (void **)&active_edid, efi_ih, NULL,
+                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
+    if ( status == EFI_SUCCESS &&
+         copy_edid(active_edid->Edid, active_edid->SizeOfEdid) )
+        return;
+
+    status = efi_bs->OpenProtocol(gop_handle, &discovered_guid,
+                                  (void **)&discovered_edid, efi_ih, NULL,
+                                  EFI_OPEN_PROTOCOL_GET_PROTOCOL);
+    if ( status == EFI_SUCCESS )
+        copy_edid(discovered_edid->Edid, discovered_edid->SizeOfEdid);
+#endif
+}
+
 static void __init efi_arch_memory_setup(void)
 {
     unsigned int i;
@@ -729,6 +772,7 @@ static void __init efi_arch_flush_dcache
 void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
 {
     EFI_GRAPHICS_OUTPUT_PROTOCOL *gop;
+    EFI_HANDLE gop_handle;
     UINTN cols, gop_mode = ~0, rows;
 
     __set_bit(EFI_BOOT, &efi_flags);
@@ -742,11 +786,15 @@ void __init efi_multiboot2(EFI_HANDLE Im
                            &cols, &rows) == EFI_SUCCESS )
         efi_arch_console_init(cols, rows);
 
-    gop = efi_get_gop();
+    gop = efi_get_gop(&gop_handle);
 
     if ( gop )
+    {
         gop_mode = efi_find_gop_mode(gop, 0, 0, 0);
 
+        efi_arch_edid(gop_handle);
+    }
+
     efi_arch_edd();
     efi_arch_cpu();
 
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -118,7 +118,7 @@ static bool read_section(const EFI_LOADE
 
 static void efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable);
 static void efi_console_set_mode(void);
-static EFI_GRAPHICS_OUTPUT_PROTOCOL *efi_get_gop(void);
+static EFI_GRAPHICS_OUTPUT_PROTOCOL *efi_get_gop(EFI_HANDLE *gop_handle);
 static UINTN efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop,
                                UINTN cols, UINTN rows, UINTN depth);
 static void efi_tables(void);
@@ -758,7 +758,7 @@ static void __init efi_console_set_mode(
         StdOut->SetMode(StdOut, best);
 }
 
-static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(void)
+static EFI_GRAPHICS_OUTPUT_PROTOCOL __init *efi_get_gop(EFI_HANDLE *gop_handle)
 {
     EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *mode_info;
     EFI_GRAPHICS_OUTPUT_PROTOCOL *gop = NULL;
@@ -783,7 +783,10 @@ static EFI_GRAPHICS_OUTPUT_PROTOCOL __in
             continue;
         status = gop->QueryMode(gop, gop->Mode->Mode, &info_size, &mode_info);
         if ( !EFI_ERROR(status) )
+        {
+            *gop_handle = handles[i];
             break;
+        }
     }
     if ( handles )
         efi_bs->FreePool(handles);
@@ -1216,6 +1219,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
     if ( use_cfg_file )
     {
         EFI_FILE_HANDLE dir_handle;
+        EFI_HANDLE gop_handle;
         UINTN depth, cols, rows, size;
 
         size = cols = rows = depth = 0;
@@ -1224,7 +1228,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
                                &cols, &rows) == EFI_SUCCESS )
             efi_arch_console_init(cols, rows);
 
-        gop = efi_get_gop();
+        gop = efi_get_gop(&gop_handle);
 
         /* Get the file system interface. */
         dir_handle = get_parent_handle(loaded_image, &file_name);
@@ -1354,7 +1358,11 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
         dir_handle->Close(dir_handle);
 
         if ( gop && !base_video )
+        {
             gop_mode = efi_find_gop_mode(gop, cols, rows, depth);
+
+            efi_arch_edid(gop_handle);
+        }
     }
 
     /* Get the number of boot modules specified on the DT or an error (<0) */
@@ -1381,7 +1389,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SY
 
     efi_arch_edd();
 
-    /* XXX Collect EDID info. */
     efi_arch_cpu();
 
     efi_tables();
--- a/xen/include/efi/efiprot.h
+++ b/xen/include/efi/efiprot.h
@@ -724,5 +724,52 @@ struct _EFI_GRAPHICS_OUTPUT_PROTOCOL {
   EFI_GRAPHICS_OUTPUT_PROTOCOL_BLT         Blt;
   EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE        *Mode;
 };
+
+/*
+ * EFI EDID Discovered Protocol
+ * UEFI Specification Version 2.5 Section 11.9
+ */
+#define EFI_EDID_DISCOVERED_PROTOCOL_GUID \
+    { 0x1C0C34F6, 0xD380, 0x41FA, { 0xA0, 0x49, 0x8a, 0xD0, 0x6C, 0x1A, 0x66, 0xAA} }
+
+typedef struct _EFI_EDID_DISCOVERED_PROTOCOL {
+    UINT32   SizeOfEdid;
+    UINT8   *Edid;
+} EFI_EDID_DISCOVERED_PROTOCOL;
+
+/*
+ * EFI EDID Active Protocol
+ * UEFI Specification Version 2.5 Section 11.9
+ */
+#define EFI_EDID_ACTIVE_PROTOCOL_GUID \
+    { 0xBD8C1056, 0x9F36, 0x44EC, { 0x92, 0xA8, 0xA6, 0x33, 0x7F, 0x81, 0x79, 0x86} }
+
+typedef struct _EFI_EDID_ACTIVE_PROTOCOL {
+    UINT32   SizeOfEdid;
+    UINT8   *Edid;
+} EFI_EDID_ACTIVE_PROTOCOL;
+
+/*
+ * EFI EDID Override Protocol
+ * UEFI Specification Version 2.5 Section 11.9
+ */
+#define EFI_EDID_OVERRIDE_PROTOCOL_GUID \
+    { 0x48ECB431, 0xFB72, 0x45C0, { 0xA9, 0x22, 0xF4, 0x58, 0xFE, 0x04, 0x0B, 0xD5} }
+
+INTERFACE_DECL(_EFI_EDID_OVERRIDE_PROTOCOL);
+
+typedef
+EFI_STATUS
+(EFIAPI *EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID) (
+  IN      struct _EFI_EDID_OVERRIDE_PROTOCOL   *This,
+  IN      EFI_HANDLE                           *ChildHandle,
+  OUT     UINT32                               *Attributes,
+  IN OUT  UINTN                                *EdidSize,
+  IN OUT  UINT8                               **Edid);
+
+typedef struct _EFI_EDID_OVERRIDE_PROTOCOL {
+    EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID  GetEdid;
+} EFI_EDID_OVERRIDE_PROTOCOL;
+
 #endif
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:19:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:19:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239068.414375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEpi-0007N1-5R; Mon, 06 Dec 2021 14:19:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239068.414375; Mon, 06 Dec 2021 14:19:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEpi-0007Mr-2O; Mon, 06 Dec 2021 14:19:10 +0000
Received: by outflank-mailman (input) for mailman id 239068;
 Mon, 06 Dec 2021 14:19:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEpg-0004et-9t
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:19:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 79240bcd-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:19:07 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-QjLZ0HWqOW6ixsfJSOfAYw-1; Mon, 06 Dec 2021 15:19:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:19:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:19:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0068.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::45) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Mon, 6 Dec 2021 14:19:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79240bcd-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800347;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+iOZotKkLcJY4CXebIky0sg+x0ejVE7dgfMqo24AelE=;
	b=kJFFmyp1d0jPmdqiqV5MGZn6gpiukgIaRfqSwyojnh/qBa7NjlWJWh3rtlmIiK8LTONLEr
	+ZHWokoMIo6gdOWBsa6Fr/xl+UWgLJFjGSWOQ1isIsX64pg6PNZKt/Loc0HiBZckxbSsUx
	0elHbl7SjyZYMy1lks5eTfi4erKRgRU=
X-MC-Unique: QjLZ0HWqOW6ixsfJSOfAYw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TndpcjUim0B/L9qCrAJ48B8VadykP/+F0CNnzTy1YS4zh5TVaVEejxDKtjog6Mh6DiCUt86Qkqhyw1kPH08M81adXeTHbVdKGzEBZxpgoYzcOMF7lo7S1WxP7MxnDfTtLr2qdTs6ZU7dSwfoEB9I7mnzlxdt7m8zhdFMa2hRTiBgrRwb5BrEjs39dupf+57sll4JMQ4FEL0/ulD+iQePA7FYJ0hKuOgV0E7VvFCLTuKxwNagQHC51QVTlZoW1O3GtRtKTna7dr6D6bd5BD9YvagJdcaUgbxqgKrp9U9LNd+6wWyrssqhEEdJT4tJ+1/VbjzhzGDnoGNrQUxlSI74Tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+iOZotKkLcJY4CXebIky0sg+x0ejVE7dgfMqo24AelE=;
 b=hH6d3D2rVc9iMKqj3WBlFQB5e96X8BvlK0GE+XgVXaBSXKTuIRbcSVWXVh64USv8gF0g3OxLFJXXvZ3EZaCIYBQyUhnQyf9CfVmlgVPDnzKqQub4w7yG9+PgJNfvjYiALtdLcqdvGRqlO54i6QDnSOmOZYraeaeDzuv2BvbOWRYFW3nuEZWPo7JKE+ek3CpPjPbik08HlMlLtqYapbHiR9U6xh3I/RVnC60xciPNTXvZE2ZnXVqLSAFAj1v5+xvAfI8KWrcP7oiXiaN7gv8uiwtkeZup67XzzWqBa784JcPRG/9+8qzF1FUV795GGwUuliQ//FqRRVEbqpRPIOWk9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d0aaae21-c8dc-72b6-4097-73c7f6f93ee2@suse.com>
Date: Mon, 6 Dec 2021 15:19:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 4/7] x86/boot: simplify mode_table
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0068.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:8e::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0f7b90e7-5f06-4178-a377-08d9b8c35be6
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB233368085E363B20101777ACB36D9@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/QR0unRc3FOhYq+SK7gZJGKwM3qPBOxKEzyqezdaAZld+U4A4I1P0i380BYcB4l/URUAQbJh91jI9yf3BnuM1RPZt5d6xse3vbMndbp2h/dfL/oHdulT31pYcAGBhMQPFQld3xd17k810PSo8VVQQmvewA7V6U6bS2+LUBZFJo7CVqSid/nTitKd6PrWhMzhBfrOUbY5NQS/rsdOiaba/3xplHM/f1b0kk74vTqQHAg/od1Fq9eiyJNd5EjxEb66BNwhdlSYngkHRG7RLNiRFgbmvZ/Cq7WkBFK1WC8BUqIWzzG38XzGaZha+CUXDj3I9tiesdc4jkQDdK9rbOwnx6npYWTsHH2ORnB8bJZG4X4sWQEC266CvqTQM0UUCzUXTADWDzb/4WjA6NJHi8x5ofsJH/za+p0KqYMbEbCMloBuE0wk8xFEvZm8sLIxZilZ4YFW8Co+GbWtql/ofNbmxPNZJNlM0eDyLYpjYuG73Q9wubq+NhggmDsuEg7L/8jg++uFJXQ80/WE1ZJF/grwAbZSKw3Wazv7fP4ujWT+TT/ZuMJJeS4g6YrIZ78rK30sBerYTJnBEk+W7uQi0WaDJiPcEmrDPMofw0+860E/973cJu0hk9GprF09Q1zz3o2o4xopw82tawkHHHPdIDEcRo4688XglRarCYGpsVKXGA90z2bmI2eLbyHrULQwyubSrl2LrdeLb0CXxSTQLmB9722rUzTEB6SchR1n24eXcoY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(54906003)(316002)(16576012)(86362001)(31696002)(66476007)(66556008)(66946007)(5660300002)(2906002)(508600001)(8936002)(4326008)(8676002)(186003)(6486002)(2616005)(956004)(38100700002)(6916009)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YyszWUNyV3F0VUdubENkSUxSQmN2c3VRWHhYaEJKbnVkVnBuRWJjZHhGQ2d3?=
 =?utf-8?B?TFZvWC9oRUtvczliSGRLazVPbm81MmZCSHV2WEd5cFpybDhuaUdYVmRnakp2?=
 =?utf-8?B?a2tWRndmUFVrUHlDTTFlSTB1RU9PRVpFU2RwbjNFcE1nc3FEY0dSVC82ajll?=
 =?utf-8?B?em8yR3FVYm1JL2xSa0ZJQ1BRbmg3VnJ6VlpJM3o0dTJ6T1UrM2J6NElHRlVl?=
 =?utf-8?B?SWdKcWZTWVlua0NDcUcwQzdMUjhjOHBUOFNSbk9PSWI3YjhkNElIbk9SRzE2?=
 =?utf-8?B?UEc5RnNQVDlESTdlclJIaTFXN29lbXhoR0JLcGNOZ09XUmx0bUF1TEtYcTk1?=
 =?utf-8?B?UENNK2tzNkc1MjFmSit0YWV2NFNjOFVaMmRaSGUyQkpjQTJLSUhabVdzRlFn?=
 =?utf-8?B?dzlkOHNxUlVWQWZOUHgvOEN3SERDUXBZNEpidkpWV2h0eWZIQUlLbUxES3Bm?=
 =?utf-8?B?d3dLV1laQ0dwcGlOeURLcFNYTDFmWTd6aE1iOTdPM3VpRVJNR2RxMmhmMmU5?=
 =?utf-8?B?M3hJbHdjR2N0UnRDdStNc1lHQy9TektYY1ZyckFWRFdsWEsvZmVuYThKaHQz?=
 =?utf-8?B?MEo2blBKVU1vQkxxQktobTk0Y2tVYXArWW5jODcxTkM1ejlXbE9CWGhZeGU3?=
 =?utf-8?B?SlFtV0NDaW9wUVBsWFdUZFJ6Z3FxaXgwUUJhdUduWWt6TWlTZXBNQjVrdGtk?=
 =?utf-8?B?YXdSM0RWRENzOWsrcnpVRDlSN21YOGhnNDA0M1A1Qmo0R1ExTkl3RFhSRms5?=
 =?utf-8?B?OUJpaDlRcnU3VzYzdElLYjkxUVpHdEhWMCtmQTI5V1Uxa0FDOFJwMjVhY3pj?=
 =?utf-8?B?dTN4SmhRRm4rRXZlSEtIWHJxOGk1bllrekFTM3hHeFp2MTRkVTV0RXFOVFF2?=
 =?utf-8?B?dVVHVlhuc0xKc3F4NTJkSTlwQUdQTWU5ellQRmZBSjdNaTQzbXU3bk9LOXhh?=
 =?utf-8?B?dFkwN2xOQmNHT0hXRy9TYytYb3NaREJiRGZueStrbnVVY3lQYzRDTlFQTExq?=
 =?utf-8?B?TUNMTVowaHB3Q2paY2ptV0hxTllaOHhEVFpWVFVIclZsVG5BdUZ3d2QvVFpk?=
 =?utf-8?B?clNlWXFrODcxSGc1WHgwdVJ0RXd6MEFWV2J2U1I2Z0pvMFZnbzVsazdoMTFC?=
 =?utf-8?B?OHF1Mm91cHM0bTZGN0xGa0luRUZDNXlHdTM4ek1ob0ZyWGt3RWViRjVIRjBH?=
 =?utf-8?B?d09UWDJjemtKWFVCUFRLVDBLNFJVYWlLYm04SlM2dFNzYWhTV3FUeFZPY29E?=
 =?utf-8?B?VG43cjJDZS9lOGVVSmp4c3FmOXM4K2ZZSWY5TnNOdTZOZS9IS2pzcU5Ud1BR?=
 =?utf-8?B?c0FEWUJkcmVxbVlkT203V0dCUktVaDBKemVreDRWK3NJNDVRSStlcmJ2bmU3?=
 =?utf-8?B?OGtNcG9LWUpaTjhYTDRHdnJKaG4wOFBQaVJVRVdRaDJCcVowc0N6NzVPSjNx?=
 =?utf-8?B?VERla2RlbkZkVXBIWnI0WG12Z0FhTHh3ei8xN2hBZTdnTEZUL0NONEpsOGZW?=
 =?utf-8?B?ZFNNekI5OE1yenJUVFUrcktud0hBRURGcUE4ajl2SVNPaHI0Q0YzTVZnMGd2?=
 =?utf-8?B?RDdDN3ZZbnZCYXNDakxNOUNPdWZjYVVWUytBQ1o5MW15YjRxWk1BQzJ3RmU1?=
 =?utf-8?B?WWNFdkFmZmR4TTd4N2ZPQ0N2ZVZQaTJyRVpZMVhhckNvRW16VWRobjVyZnU1?=
 =?utf-8?B?OXloRlV5dU9BTTZBay9VemM5VGlPVUhXNkxKcHJITVdXbS9YZUZWdkd5Rjl0?=
 =?utf-8?B?ekUxY1FtVThxdmxJWXpYSVZCWFVCaWpzMjlSZGdJQzlPUVdxa3lqNkt5TDJ0?=
 =?utf-8?B?VExuTHZQVFZ5amhDTWR6WVJrT3dQazhNYkJwa1ovblBFY3kvNkQ5VDBpbW9D?=
 =?utf-8?B?bTVtR2NqemNmZzNlNW5OSXFkbk45TnZZekI0dWpNSWFaOXN2cEdVaWtVVk02?=
 =?utf-8?B?cTVOVmxZS0ErRCtYU2VtUFFvbytJQ0RLb29Uczh3SDQ0QU10b2lZQS9XTUF0?=
 =?utf-8?B?aW40czVpdEtXb0lGYmp0STV5cEVVY3lMMU1HZnFmSDRPWjk5cHlQdUE5aHQv?=
 =?utf-8?B?RERGNVR5WktLL0xwMHZSTGJMd0tLVHhPbGQ2R2h6VzgxRmgzYmI1UjgvajNH?=
 =?utf-8?B?aXhHMUNsc0YvKzNZOHIvcFBqMUMybmw4ZzhaelVoZ0VsRkhxajZKbUhEcXBU?=
 =?utf-8?Q?4gQxmll76vNAma3s9IWM2F4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f7b90e7-5f06-4178-a377-08d9b8c35be6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:19:05.0850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +FVAcr2PiWIYpbDUyk5Kt3SBVP2TJN/hMeu46pzjVJmnfXYY7NGDyuv0KjHnhueRpYv8AkQM80UgZPKKNOWJmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

There's no point in writing 80x25 text mode information via multiple
insns all storing immediate values. The data can simply be included
first thing in the vga_modes table, allowing the already present
REP MOVSB to take care of everything in one go.

While touching this also correct a related but stale comment.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/boot/video.S
+++ b/xen/arch/x86/boot/video.S
@@ -655,8 +655,9 @@ outidx: outb    %al, %dx
 # Build the table of video modes (stored after the setup.S code at the
 # `modelist' label. Each video mode record looks like:
 #        .word        MODE-ID             (our special mode ID (see above))
-#        .byte        rows                (number of rows)
-#        .byte        columns             (number of columns)
+#        .word        rows                (number of rows)
+#        .word        columns             (number of columns)
+#        .word        0                   (color depth; gfx modes only)
 # Returns address of the end of the table in DI, the end is marked
 # with a ASK_VGA ID.
 mode_table:
@@ -665,12 +666,6 @@ mode_table:
         jnz     mtab1
 
         leaw    modelist, %di           # Store standard modes:
-        movw    $VIDEO_80x25,(%di)      # The 80x25 mode (ALL)
-        movw    $0x50,2(%di)
-        movw    $0x19,4(%di)
-        movw    $0x00,6(%di)
-        addw    $8,%di
-
         leaw    bootsym(vga_modes), %si # All modes for std VGA
         movw    $vga_modes_end-vga_modes, %cx
         rep     movsb
@@ -684,6 +679,7 @@ ret0:   ret
 
 # Modes usable on all standard VGAs
 vga_modes:
+        .word   VIDEO_80x25, 0x50,0x19,0        # 80x25
         .word   VIDEO_80x50, 0x50,0x32,0        # 80x50
         .word   VIDEO_80x43, 0x50,0x2b,0        # 80x43
         .word   VIDEO_80x28, 0x50,0x1c,0        # 80x28



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:19:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239071.414397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEq8-0008Hl-PC; Mon, 06 Dec 2021 14:19:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239071.414397; Mon, 06 Dec 2021 14:19:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEq8-0008Hc-Je; Mon, 06 Dec 2021 14:19:36 +0000
Received: by outflank-mailman (input) for mailman id 239071;
 Mon, 06 Dec 2021 14:19:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEq7-0007zW-Uj
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:19:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89b0cfbe-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:19:35 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-lJdjzbS3MuOjJ_ka8juchA-1; Mon, 06 Dec 2021 15:19:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:19:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:19:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0060.eurprd04.prod.outlook.com (2603:10a6:20b:312::35) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 14:19:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89b0cfbe-569f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800375;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GFSJGrEWRuZxL/lqFamJoez8zlHu39Sdg/lvj6ulEMc=;
	b=RZense3Ddp5Q+ToGfwvz7aET70HX/Px2n6dQ7chC0gYTOOM9iptNY4PNwC2XAy9/eT7DMZ
	p+3++ZK3TKjd4aTBmOl/bGTsBaeD42DcummmlgbSmjPaidIOgolpYfFBnwam4gEj+IdwgK
	VYCHbdCT0tAExxoAODnYTfZCKOlqFdg=
X-MC-Unique: lJdjzbS3MuOjJ_ka8juchA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F1mqj9o9WuS1AMchop50knu52etmeAqFRsUCqrvJqnFuLEIpDyccFvSzv1PqGLoF06CpiMxoooo769691scWOs5I+lmNgsI9/M9r/r+2y3cSmnV0uoZ3qTXTiBrfnCgg1oPuZLC4BBlfsOrPqtX9HBHkbE7YAic+EaOJDOCYPfrb0B3xoAVth5XTQlkXuwJi5UAMzdFPyEBUK5jdvItwjf1Yoft31SGmhI6KgSvpM+BwXs5INp6QVAWH8x9o3BYL70FhBW8YqxO1XUooIY5CBiI1BGjvM0M8Qbwi2fIbQ5QjbuHzfvi8Rs+KntThd4mndjKHfCJUAvZ9t/ConMZPqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GFSJGrEWRuZxL/lqFamJoez8zlHu39Sdg/lvj6ulEMc=;
 b=nRRek+Dt6p8yYmmrup+jN+UOE4ERZjbBj6CGTydgQ26XDsUNNAJdySomfaGZZjpgd1zUp/uM2Xd2HnYhCQ8/OZ+5dzsq31zj01VF8IZRvCMA34/ghibVGCA2m00t+6mBye6Km3blJV+gIrvRyhFpvmmBDZaCfyXSp3KzYSYO26R1m+tq8ncJoWXuLIL5Yde1JmtgyyBxqP+R1vulBm4an+KXJXpJi3k+XduyQ+30d/649oPdmfMZ1JsWNgnKUo/aae6X1MSbMGzTnRW6yvaqJ572ZuXomDQY1v0aQqDxuYCyTpj4qfsIL/4YQReCzahgFH6loWbmAsli6tG5vy/ulQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dda4e10a-6b52-1690-801a-f997d0307277@suse.com>
Date: Mon, 6 Dec 2021 15:19:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 5/7] x86/boot: fold branches in video handling code
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0060.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd288551-6fe5-4ab8-23f7-08d9b8c36cc2
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23333D5104FD8B8C4673DF00B36D9@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3383;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6m8uUsnsvvzTt7yNTqDLYdmiMBqXzXA32E/myIxYj+kHtrlbg746IGTqtIvOA3ODm91oqPNDTVsn326aejeC+PCfZxxWVoF3n9wMnQU/r3rYDkJEqgvHdZ9LZkJS8OHW1Fc38XeV+yCC8iI6KAQz0658SfojTnUVxQrawdiUJ3WItBFAz7BjAB71sZ7CBpHOBAtqEg6Nf2+InnrQ5TYgGSUeufnhF6QwLuBYEU78CO1Mk7Q7jKbwPixcksdtAJUbl0Eg6VTxpWYnlcpvKi05FS94RzoCKR1wZLVcxN+3fY06aJ43g7ypaBDDaWs61SZ+D4bupZI9Fh+PAIUC2oKurGhBt+CMfOD4mwVf9Q3Fswcp53kYhKlSaadL4Ey1ccCUCxjy9250afp0lJoGvV/7UfGrxkd9H+QZPC4ErXKR1J9L9U5L5hCp3GqNyn7/bnUO1mGQmSVidfwhCgBsp+YJud+jZNpPtG3jL9Y/hDCXmdajmCwTUwJPlRGvDXJuVLE7WWLAOR8HV8yv6wewZIzgHg95HngcWYmcTUGMg1peYEjcRs8HIb5UhOrNqnRTStZav1QNkCo9wQ1cPa4uIdq/tgbZYndbBa5BCqkxrqyTXhDxJJTMPZntr6oX6FPCgXLxQc2PlawRCain/MNF/bmMLNCwa+7OPMf1Wwao1YrReJ6fojT9TraJDi/y9Z089/Uw6h2x126JXkvemrGZzlnqMWbUezz5meplkOOR+9qDwBw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(54906003)(316002)(16576012)(86362001)(31696002)(66476007)(66556008)(4744005)(66946007)(5660300002)(2906002)(508600001)(8936002)(4326008)(8676002)(186003)(6486002)(2616005)(956004)(83380400001)(38100700002)(6916009)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TkJRemlvRjFwY0pnWWF4U2g5R2xPOXVkaE9JNm9aKzJseUtwalVwTFF5UERO?=
 =?utf-8?B?cWc4Ym5EUGRKQktrRndDditqZ1UrTExyTlRpbysyMWZuOW9qQ3RmU1dzTm5k?=
 =?utf-8?B?WDdmSXU2dVpjZlpkVXU4SHlvOUlmekRVa21rTEI3WWJobmJyMjNQc1BUNDM0?=
 =?utf-8?B?RHRDYWRSQVpxajhabGlaT2R6TC84NVpoZlEyOVM1Z2dva2VoMTA3a1hNWG13?=
 =?utf-8?B?Z2NaUThHVGV1NlpnUHRxMXh4WnZ4VldyQllvWGxPOUZxWjlZR0JENkJYSUhG?=
 =?utf-8?B?NDEwd2JpRC9QUFRqbFVQZDYzeXFUajlxeGw3cEFFdkw2dkRtU3NIWXRJNUwr?=
 =?utf-8?B?RlRXMHYzYkxEWk1yYmhDakROL2xsa2NNazdFbDVnQXlMTmVpcDU5QWhZdkNV?=
 =?utf-8?B?MHJ5V1ZJM2N0MlhJbzhUdnJ2b2FMM2k3WGxkb3k1WlNKTUVEOTdCeE1XRmpy?=
 =?utf-8?B?S2UwVmFEQkppdkwvTkV1ZU9uQjREMy9oMnNsZHNLLzRYN0FWZ2dsYW14REF0?=
 =?utf-8?B?dEpOZmdRU284Q3FWdno2N3NBKzEyZktxV213VTVsNTNjTnVHK1FlUUZoZFI3?=
 =?utf-8?B?NjJTcFRPSE43d3RWTUhWc2dYV2VGUEhkNisyclRCd01JOHVmdUtIYjczc2xX?=
 =?utf-8?B?eTBxUnZPSjNKQVl4T2wvZEdLTXJ6anhXcG01MFpLVnhpT2dKWkU4eDZrTldN?=
 =?utf-8?B?emRWcmlrYjFNNmZDSktvNHlIT21zeDdtazVMV3BVdnNPT1g5dTI1cnNXTy9w?=
 =?utf-8?B?REt4R0g2RG9CUVJkcURWb0JiVkEwNFFvb2w3OGVYRXFSWlJjdVE3TE1LQms0?=
 =?utf-8?B?VUFOTGFoNmtiN3U0S3FKeUFXQnlmeDYvaHF1aUN1L1pSUW42NS9KZS83R003?=
 =?utf-8?B?eGNSdGdiWjlXUDBoMUZDR0Y3S1RKVllJekFKV21zODFFZ1VuZTBwNnpJRTEz?=
 =?utf-8?B?UWY1cXRWUHBqQUpraURYb1ljejVMaFE3cEpQZHMyeUZ2YkphbVdzSm5hWFNW?=
 =?utf-8?B?UnpJTVdyZHVPYzhWZDN5dU0zdW1yNDlxVmdudys0ODJYUndxZUM3bmwxUzBr?=
 =?utf-8?B?WVVaSS9IMGpzUUtUNTRoc0JSVmluR3BQMmVJV2crY3RYL0NPNmVMeGpGSzhn?=
 =?utf-8?B?N0pqTmVvWklha3hUbFRTMWtNZE8yK2JMTFVXNE1ZY0tLd25rdnZtaHJhM29y?=
 =?utf-8?B?Q3ZtWWNocDRiVFdRYjhVVUdjVCtmb0s1Tk0rYlpqeGs0VUlHK3RtdUVMWkps?=
 =?utf-8?B?M1VaWGF6UWJ4YkRRelQ3TU40SHJxWEVmc3JVUC9BdmdLcGRqTnNla2F1bGxk?=
 =?utf-8?B?SmhaTlpNVm53bjc2Q3JyTmUyRVE1U0U0OVl5RkI5RjBtMGVYRUdyd0VXM1l4?=
 =?utf-8?B?aFFnbUswUVhWTWNTUGRlbzNGYmJJQzZVdG9yaU80cS9yOWU5bGZsdzBSYVAz?=
 =?utf-8?B?QXNQM2duRXNHNVJZeHJXRmF6c1NlYTArYVh3ZGtMZnM2bmdHSVJmWVpOU2Z1?=
 =?utf-8?B?WDI3cDBEdUdMSGsrNUV5SFk5MVBjMW9uZU5PSFFQSnNNN0Z4Y0xEbUJDUzBY?=
 =?utf-8?B?MHl1dng5NU5sK0dXczdjbDlOems5R3hJb2JSRHgvMElVd1ZUUkttbW9HYS82?=
 =?utf-8?B?NTQxUHJqNE9Eb2xTV2ZCR3o4c3gzZXNxTkllWCt6UUVYRUN0ZVozK2JBUTk0?=
 =?utf-8?B?U2lkR2tGaXdOdGhsaXpnVkF5T2IvNWFtRThVbXpXZmNOVWdQeVBaQ0pHMld3?=
 =?utf-8?B?YzVRVlRCOFRCNHBNRUFtb3BZYWtUTzFsZnJJT3c1WnRzSzlJWU9GNjBQbkpz?=
 =?utf-8?B?blE4VGFvc0h5ZE40dUo3Wk9XSXBZSXArVHMrNThTc01yTnlUQXN4N2lmUTR1?=
 =?utf-8?B?WDZZSW94aXhzcUZnT2EyZXJha0hzYUJwQkpHT1ByVDFpekpJQWRveVJKUnhC?=
 =?utf-8?B?SXppWjFTeGNscCs0NktuUjEyaGFpREpud3VTajBZeXBxbTRsb0M2dDdWTmUw?=
 =?utf-8?B?VnBvdHo4R05WcVNTa3VyZlQ3NnNIZEVUclhNelYzV2ZBZ3IwWmc0bDZGeHF5?=
 =?utf-8?B?Y2VXeVlaMkRZdUQxcGM1S2Z5RnNQeDkvWVBxbzZRS2lRZWdRenFSNWE4a1p3?=
 =?utf-8?B?dlVFR1BWVEIydnpud1RKaTVQM01Ua0xXOG1EVE1HT0d6OVdCRmlSZ09naExP?=
 =?utf-8?Q?POZ4z74SO3PXDUDybc4hFHs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd288551-6fe5-4ab8-23f7-08d9b8c36cc2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:19:33.3811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fajpi0vNe3WitnrpJTtJR6EXEiHW6k/fQjAM8r4EEHEtAIbZnSgiDKOSuEbuilnrmYXVR5W0XoLrDXuPgXfg4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

Using Jcc to branch around a JMP is necessary only in pre-386 code,
where Jcc is limited to disp8. Use the opposite Jcc directly in two
places. Since it's adjacent, also convert an ORB to TESTB.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/boot/video.S
+++ b/xen/arch/x86/boot/video.S
@@ -332,8 +332,7 @@ lment:  movb    $0, (%di)
         cmpw    $0x656d, (%si)          # 'me'
         jnz     lmhx
         cmpw    $0x756e, 2(%si)         # 'nu'
-        jnz     lmhx
-        jmp     listm
+        jz      listm
 
 lmhx:   xorw    %bx, %bx                # Else => mode ID in hex
 lmhex:  lodsb
@@ -401,10 +400,8 @@ mode_set:
         cmpb    $VIDEO_FIRST_VESA>>8, %ah
         jnc     check_vesa
 
-        orb     %ah, %ah
-        jnz     setbad
-
-        jmp     setmenu
+        testb   %ah, %ah
+        jz      setmenu
 
 setbad: clc
         ret



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:19:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:19:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239070.414386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEq6-0007zw-Fg; Mon, 06 Dec 2021 14:19:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239070.414386; Mon, 06 Dec 2021 14:19:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEq6-0007zp-Bs; Mon, 06 Dec 2021 14:19:34 +0000
Received: by outflank-mailman (input) for mailman id 239070;
 Mon, 06 Dec 2021 14:19:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w5uy=QX=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muEq5-0007zW-F6
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:19:33 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 8741af70-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:19:31 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D8C41FB;
 Mon,  6 Dec 2021 06:19:30 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.4.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E9A23F5A1;
 Mon,  6 Dec 2021 06:19:28 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8741af70-569f-11ec-8a4d-196798b21f7b
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] xen/arm: Do not include in the image functions...
Date: Mon,  6 Dec 2021 15:19:23 +0100
Message-Id: <20211206141923.26757-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
CONFIG_NEW_VGIC is not set.

enter_hypervisor_from_guest is protecting calls to these functions
with CONFIG_NEW_VGIC but their definitions and declarations are not
protected. This means that we are including them in the image even
though we are not making use of them. Fix that.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/domain.c        | 2 ++
 xen/arch/arm/vtimer.c        | 2 ++
 xen/include/asm-arm/event.h  | 2 ++
 xen/include/asm-arm/vtimer.h | 2 ++
 4 files changed, 8 insertions(+)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 96e1b23550..7baa2b7417 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1108,12 +1108,14 @@ void vcpu_mark_events_pending(struct vcpu *v)
     vgic_inject_irq(v->domain, v, v->domain->arch.evtchn_irq, true);
 }
 
+#ifdef CONFIG_NEW_VGIC
 void vcpu_update_evtchn_irq(struct vcpu *v)
 {
     bool pending = vcpu_info(v, evtchn_upcall_pending);
 
     vgic_inject_irq(v->domain, v, v->domain->arch.evtchn_irq, pending);
 }
+#endif
 
 /* The ARM spec declares that even if local irqs are masked in
  * the CPSR register, an irq should wake up a cpu from WFI anyway.
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index 0196951af4..63a8374f7d 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -347,6 +347,7 @@ bool vtimer_emulate(struct cpu_user_regs *regs, union hsr hsr)
     }
 }
 
+#ifdef CONFIG_NEW_VGIC
 static void vtimer_update_irq(struct vcpu *v, struct vtimer *vtimer,
                               register_t vtimer_ctl)
 {
@@ -395,6 +396,7 @@ void vtimer_update_irqs(struct vcpu *v)
     /* For the physical timer we rely on our emulated state. */
     vtimer_update_irq(v, &v->arch.phys_timer, v->arch.phys_timer.ctl);
 }
+#endif /* CONFIG_NEW_VGIC */
 
 /*
  * Local variables:
diff --git a/xen/include/asm-arm/event.h b/xen/include/asm-arm/event.h
index b14c166ad6..f4193cb62e 100644
--- a/xen/include/asm-arm/event.h
+++ b/xen/include/asm-arm/event.h
@@ -5,7 +5,9 @@
 
 void vcpu_kick(struct vcpu *v);
 void vcpu_mark_events_pending(struct vcpu *v);
+#ifdef CONFIG_NEW_VGIC
 void vcpu_update_evtchn_irq(struct vcpu *v);
+#endif
 void vcpu_block_unless_event_pending(struct vcpu *v);
 
 static inline int vcpu_event_delivery_is_enabled(struct vcpu *v)
diff --git a/xen/include/asm-arm/vtimer.h b/xen/include/asm-arm/vtimer.h
index 9d4fb4c6e8..1e945ae2c5 100644
--- a/xen/include/asm-arm/vtimer.h
+++ b/xen/include/asm-arm/vtimer.h
@@ -27,7 +27,9 @@ extern bool vtimer_emulate(struct cpu_user_regs *regs, union hsr hsr);
 extern void virt_timer_save(struct vcpu *v);
 extern void virt_timer_restore(struct vcpu *v);
 extern void vcpu_timer_destroy(struct vcpu *v);
+#ifdef CONFIG_NEW_VGIC
 void vtimer_update_irqs(struct vcpu *v);
+#endif
 
 #endif
 
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:27:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:27:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239087.414408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExE-0001mX-I8; Mon, 06 Dec 2021 14:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239087.414408; Mon, 06 Dec 2021 14:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExE-0001mQ-F5; Mon, 06 Dec 2021 14:26:56 +0000
Received: by outflank-mailman (input) for mailman id 239087;
 Mon, 06 Dec 2021 14:26:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEqj-0004et-I9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:20:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ffa662c-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:20:12 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-YWmGVimnM4GaEqKzmODPNA-1; Mon, 06 Dec 2021 15:20:11 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:20:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:20:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 14:20:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ffa662c-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800412;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=juBJGq4ZapzX50bKGD151YensGcEVFSl2L4HTOV0500=;
	b=I3hcgTriyde+o9Kpz0eA7nuclXpFLrxLNbWyvi+5d95TpvVB984po+6jnq2ZgmOy+mTNvI
	dEzUf1oIVDZ58rX2ORd8kr3AKiK0I1JpTjKYgIFP6v5Rat3C2EmTXcF1e0Jx4OG81qO7LC
	tF7esXy9otpL2KTpdEMZXWynfes0EHw=
X-MC-Unique: YWmGVimnM4GaEqKzmODPNA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dSI9SuUMgo/E8SWU9yMqXTF+Mu3lCr0yNu8X9rZkh+g7LjL01aeOEymM8yt+DtGjneJk/TXjKdPzAOjN5Zw+Yg79iHK5uG1jS9ONYYALEjEEviIFkVnBdTR6AVjpGWmU8SWrPQNqnp61qMChzBHbeUgLb+WwNI9u7orPr0SaByEeqDAbjW4ri61Bvz/wHPr+xDeCKlTwgDLLzxKHghFMR9j5kCFyboM+pnsmGp1WMZisnqYDNztQekeORpB6xJ4KvU7nnItr6qx8r8OepsxA41eDe5YzGpti+0Mu8H9M5zUKrBNuJOEWYQcWAK+LNaUB3ebzO/ZfKa8H4xKKwNmb9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=juBJGq4ZapzX50bKGD151YensGcEVFSl2L4HTOV0500=;
 b=HN975pnAwacdR9JVgm4IoOQ5fNSfrBB8hzgh0ZgEHJgJIi2M9gOL6E615uywvt7ibBKtgl8h9lyRJS76rdybjcNyE8OfR/hCfPtUNfvbASQo4PuotvfiPFAwYvYQYhO1TgMPfy14OuJ60VWhT/uXX8ekFdtz7inK2ClqXwrOa5a3sTYfdgjwjHJGSUuJ7kQC2VbBumdcGRJ57KD4IH71zxEtBvm1SkV3oqbTvIqP6Lj+/dFdJF2pzg2mvEHIdyjg3BhQpBuCYOOWs/vHGuvI47SlZBqbzDhTSKbWLvkFXXMlUZmSCiVMuVOCQl+ku4mdwLDxuL9Zz3GyACE28B9W9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8db595d1-a0c7-4a7a-4a06-16689adbf938@suse.com>
Date: Mon, 6 Dec 2021 15:20:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 6/7] x86/boot: fold/replace moves in video handling code
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0006.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f946c7c7-737c-473b-1091-08d9b8c3829c
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2333937533AB0095D829B4CDB36D9@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Nis2F3zYkPzKQl4LzPMTLoZh8BP8J+gGlmco6zMRCvt7s8y6J6B2ysj7xF7JdU10flXTbZtfwDSU2lv6SPDpesRV0E/zpSN6fwgEQBWGkLwEZyW4hc8mEi2dsYVA7iBEAB+qcIXBs5M+skVfH87SEloQ/R40n0AY9TjuN4Rfi19qpMLG8DrFilM491rOmsyOMxfMKhXOmIFYneHcdDW6Xd67MR2tHS8iJSfLiZRUplLdBlKDWZpZu7k9dMzQ9B+VEMz3oaNYLnZAifGGRBLmTcEyQrA+4MpeitHwmIU72p5KgXxYRBBt79QYV48OoBCpxYi5WOqSh4iPnKQCtBgCdv2JLUBAXjkH1AzUbtRxoRlSqR//XFv1lcuWBnkghUbju13MQAw27uWDH/FGICUjYYZLpEiWIaMe4zX9v1Pw+4euGVCizn7iDB6OfwuEC4vR0ilbEsBE9Vq+j9mDq4aVCgj2wYxEx3t7zexbEemsPt/A8/PkQYB++QF/KfqHR7rcbfhq1Dx9gwHBDN73dsNWjJgVVzPEsemTx9xWpTcLQt9wnlqo92piEIu7thw2tBERazVuPSMvYmEjzsIAX/PRG/aBt9cqUW2IlovC4/I1HOOWtS761Jt0TDI8y/uatV1fIvZ/xShZrxXD7ZSv08TnuJhYZ87C677XCWtZtndRDUPpMlAhU9h6jdSBHaT0ZRXtGY5Uq3kebWu0tk8yKrmeuichvCg/KYOi2pKGGX11WWA=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(54906003)(316002)(16576012)(86362001)(31696002)(66476007)(66556008)(66946007)(5660300002)(2906002)(508600001)(8936002)(4326008)(8676002)(186003)(6486002)(2616005)(956004)(38100700002)(6916009)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWx2Y21oYnJOUVFxdlpkSFRFWFJxZ0dsaFpDSVRYVXU2ajF1SHlseEhhY2dG?=
 =?utf-8?B?dUVzRzZ4blRTaldTZXBrblFTR3ByS3RiemlrblFwNFF6TVpTbFREaWgwVjFw?=
 =?utf-8?B?RHkwTE0zb2xFd1lNVGRMTTBzc21tRUl2RWZRQzk4ZDZ5OGgxazdhZG0vdEFK?=
 =?utf-8?B?cjJYZWlHMFBBVXh4NVBMcHViVGptZ3JYU01PT2ZRZXJlY25FM2dCeDJkc1Jo?=
 =?utf-8?B?TVpVRTFBZS9ybGJzVm9vdXIxdm1zOFMySHNzYWVUc1g1MU56ejBhYUZVTE5p?=
 =?utf-8?B?YVNpK01reG10eFZGcmlucW01MVZRZ24yRWVRTFZkMW5IYjNyRmZGamxuZ05Q?=
 =?utf-8?B?OVNrM3JQYlVzVzFkcnJzZ0VqZ3FyNlFVZzBudjdXL0poZy9WNFJhSXdSbnFl?=
 =?utf-8?B?dFBwMzFEajVOL2RjSFBBalVZSitwMWZ3aTNxaXNZT0VrdW4xdmdXSnNDTUF4?=
 =?utf-8?B?d0FFQTNrdjM5Z2hIQk1URDIrZFd4cXAzeml3MWxOcUM4Rk9kMG9IdGMreGlv?=
 =?utf-8?B?bWlEeVRpbUtmU25tK1RoQVM3N1VtV2hCejVhSHd0cmUyc0xKWWxrbk16U0li?=
 =?utf-8?B?dXI0Sm9DY3FzNWF6WE9JMjR3Ri9vRFF4RExUeXJGdlJheW9LVjhMVmVHekth?=
 =?utf-8?B?K0I3RXRxQzFGMGcvSnNDdy91TXhtbFlmS3BBdHBZRG1aNVFoM2RiRzAvK3BD?=
 =?utf-8?B?WnBDWHllajRoay9VbktuSjAyK0x2ekd3MDRLODNudHlqYng3a1UySzd1bGIx?=
 =?utf-8?B?ZCtTM3VLbWROejR1SllyZHFOamFoMVkzQkdBSnRLWVF5NWtlYXh0VU1UNWdE?=
 =?utf-8?B?QkpDZ2poeEZjV1BIY0hXZkdnR2c5VHUvNGUzZWoyMFpqSWE0aCs1UHR4eDR1?=
 =?utf-8?B?NlA4RkFjUUFFK2kvWnhDcXdiaGhybi8zcjR0dXFMWVRRVisrNHVqTkdpT3M1?=
 =?utf-8?B?SlFiS0ZJaUpDaUwwd3lhN1BJVjA1SlBzejlxRkFCVkpIZ0NKSEpsT3g5WkE1?=
 =?utf-8?B?ZW5PNDZ5aWVWeU1CWk9DU3FyZkI4TytSRElneEp2dnpqOFVHNS9EMmppcEZs?=
 =?utf-8?B?L2lwdXZPVUszRHpBNGdBL3BWdGloakI2SnlvWmdiQTF4UnRsR2VxTFU0aGFo?=
 =?utf-8?B?Z2Q0dkFXeXFkeFVnS2ZwT3ZGWDh3WUJDSi95UThJcWp2aVB5ZzlGZ00rbHlx?=
 =?utf-8?B?V2xjeVdqeFJHTCtob0Jxb0hPcitwdk9pMWpaV2NUdlJBc3cwOUR5VWJwSEFJ?=
 =?utf-8?B?SGhraTlxbC9jd2I1c2pSWlR3c3JEYVIxZFQ5STI2aDY5enBmTU1STGV6RkFM?=
 =?utf-8?B?bXk4Wk1hWGQwbXM0TUZWazlkdHgxa0NSK0wxVGJMQU9lM0JGWEhvZjFoQWpv?=
 =?utf-8?B?anl0YkgxNDFKSElPR3lpS3FYS0lzUHRCbTJJMzdySHdYMUk4WmIrTkhGNzBI?=
 =?utf-8?B?YWZIWFFFL0FjSnNWQ1c2NTBQNWlwWWRvbjVHMHFFWnFRbCswOUVxTGQ0a2lF?=
 =?utf-8?B?bG1BQ3RCM2c3TVV0UHVEWUowd2o3a3U4S3lhdGRadkdLVERlWitVeGVxUnU3?=
 =?utf-8?B?V1ZJbFI2VHJWWm90KzIxTkJUKzdWSFBxVzhkMjBwdkE2R0hadHFheVdLQlAy?=
 =?utf-8?B?T2d2dWZKUUp0L3h1RDJVdzgvbWFOcmIrNDlBZzdZTjZhS1ZReFN5eEVjUE5X?=
 =?utf-8?B?WmgvaEhzcWpid0padDBueGxrbjVWUkpBWlFvZUdHR00vQnpLZWlpNHFBTlZM?=
 =?utf-8?B?ckgwWjNPQVJsYU1KM2dzM2pPNFZlVjV6c1JxRHlGNGd4OHlIcTIwb1pwY2sr?=
 =?utf-8?B?RGRuNnJIN3htN2haNFBZODlSWXY5OEk0MVVxU0JXQkpFYVRqVkNReDh4N3Vl?=
 =?utf-8?B?cU1wRExKbGpkTWYvdHRjR0dpSFhIdjNSU25xWk1WZnhYSzM1enNab2c3dmZU?=
 =?utf-8?B?UFdjOWU2ZWVaYXdtcFlyU2lrMlVDeUhRaVRxVFAzRTd1WTBwbklCbXRVVGgy?=
 =?utf-8?B?WUE4MlB0NWJDeUNxV3h6UlF3SzBUdWdjRm9QbGlKVFJReE9mcHVxTFdmR3JK?=
 =?utf-8?B?Um1OLzdnaHVDc0FVdlhCTCthSkhJRjdqOVVsUFdta2cxaktOSFZvZHZBRkVT?=
 =?utf-8?B?emVYSGJiL2NHNEFMc21qaDhqNCtwQ0pWNTBPZklUNFJ2cnhJSnNWVWV4cE00?=
 =?utf-8?Q?0fwGjgjHpFks1CokeUbiPWQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f946c7c7-737c-473b-1091-08d9b8c3829c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:20:10.0434
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4c9v+gm6dIaSdFJn3sBVZNX0grqqECno/hEIr/pSgHtU1woHlnSnwPXlpOdXHI90Q3Zf4MitjJtm9WCBtZO7ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

Replace (mainly) MOV forms with shorter insns (or sequences thereof).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Of course there's more room for improvement. For example there look to
be a number of LEAs which really could be MOVs.

--- a/xen/arch/x86/boot/video.S
+++ b/xen/arch/x86/boot/video.S
@@ -121,8 +121,7 @@ mopar_gr:
         movw    %ax, _param(PARAM_LFB_WIDTH)
         movw    20(%di), %ax
         movw    %ax, _param(PARAM_LFB_HEIGHT)
-        movb    25(%di), %al
-        movb    $0, %ah
+        movzbw  25(%di), %ax
         movw    %ax, _param(PARAM_LFB_DEPTH)
         movl    40(%di), %eax
         movl    %eax, _param(PARAM_LFB_BASE)
@@ -135,8 +134,7 @@ mopar_gr:
 
 # get video mem size
         leaw    vesa_glob_info, %di
-        xorl    %eax, %eax
-        movw    18(%di), %ax
+        movzwl  18(%di), %eax
         movl    %eax, _param(PARAM_LFB_SIZE)
 
 # store mode capabilities
@@ -144,14 +142,11 @@ mopar_gr:
         movl    %eax, _param(PARAM_CAPABILITIES)
 
 # switching the DAC to 8-bit is for <= 8 bpp only
-        movw    _param(PARAM_LFB_DEPTH), %ax
-        cmpw    $8, %ax
+        cmpw    $8, _param(PARAM_LFB_DEPTH)
         jg      dac_done
 
 # get DAC switching capability
-        xorl    %eax, %eax
-        movb    10(%di), %al
-        testb   $1, %al
+        testb   $1, 10(%di)
         jz      dac_set
 
 # attempt to switch DAC to 8-bit
@@ -164,17 +159,17 @@ mopar_gr:
 
 dac_set:
 # set color size to DAC size
-        movb    bootsym(dac_size), %al
+        movzbw  bootsym(dac_size), %ax
         movb    %al, _param(PARAM_LFB_COLORS+0)
         movb    %al, _param(PARAM_LFB_COLORS+2)
         movb    %al, _param(PARAM_LFB_COLORS+4)
         movb    %al, _param(PARAM_LFB_COLORS+6)
 
 # set color offsets to 0
-        movb    $0, _param(PARAM_LFB_COLORS+1)
-        movb    $0, _param(PARAM_LFB_COLORS+3)
-        movb    $0, _param(PARAM_LFB_COLORS+5)
-        movb    $0, _param(PARAM_LFB_COLORS+7)
+        movb    %ah, _param(PARAM_LFB_COLORS+1)
+        movb    %ah, _param(PARAM_LFB_COLORS+3)
+        movb    %ah, _param(PARAM_LFB_COLORS+5)
+        movb    %ah, _param(PARAM_LFB_COLORS+7)
 
 dac_done:
 # get protected mode interface information
@@ -504,7 +499,8 @@ setvesabysize:
         call    mode_table
         leaw    modelist,%si
 1:      add     $8,%si
-        cmpw    $ASK_VGA,-8(%si)        # End?
+        movw    -8(%si),%bx
+        cmpw    $ASK_VGA,%bx            # End?
         je      setbad
         movw    -6(%si),%ax
         cmpw    %ax,bootsym(vesa_size)+0
@@ -515,9 +511,7 @@ setvesabysize:
         movw    -2(%si),%ax
         cmpw    %ax,bootsym(vesa_size)+4
         jne     1b
-        movw    -8(%si),%ax
-        movw    %ax,%bx
-        movw    %ax,bootsym(boot_vid_mode)
+        movw    %bx,bootsym(boot_vid_mode)
         jmp     check_vesa
 
 # Table of routines for setting of the special modes.
@@ -773,8 +767,7 @@ vesa2:  pushw   %cx
         movw    %bx, 2(%di)
         movw    0x14(%di), %bx          # Height
         movw    %bx, 4(%di)
-        xorw    %bx, %bx
-        movb    0x19(%di), %bl          # Depth
+        movzbw  0x19(%di), %bx          # Depth
         movw    %bx, 6(%di)
 
         addw    $8, %di                 # The mode is valid. Store it.
@@ -901,8 +894,7 @@ gettime:
         movb    %dh, %al                # %dh contains the seconds
         andb    $0x0f, %al
         movb    %dh, %ah
-        movb    $0x04, %cl
-        shrb    %cl, %ah
+        shrb    $4, %ah
         aad
         popw    %cx
         ret
@@ -959,8 +951,8 @@ store_edid:
 .Lforce_edid:
         movw    $0x4f15, %ax            # do VBE/DDC
         movw    $0x01, %bx
-        movw    $0x00, %cx
-        movw    $0x00, %dx
+        xorw    %cx, %cx
+        xorw    %dx, %dx
         movw    $bootsym(boot_edid_info), %di
         int     $0x10
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:27:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239089.414419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExO-0002Da-U0; Mon, 06 Dec 2021 14:27:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239089.414419; Mon, 06 Dec 2021 14:27:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExO-0002DT-R5; Mon, 06 Dec 2021 14:27:06 +0000
Received: by outflank-mailman (input) for mailman id 239089;
 Mon, 06 Dec 2021 14:27:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w5uy=QX=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muErC-0004et-6h
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:20:42 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id b081380c-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:20:41 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBDF01FB;
 Mon,  6 Dec 2021 06:20:39 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.4.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 776063F5A1;
 Mon,  6 Dec 2021 06:20:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b081380c-569f-11ec-a5e1-b9374ead2679
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on entry...
Date: Mon,  6 Dec 2021 15:20:32 +0100
Message-Id: <20211206142032.27536-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

to hypervisor when switching to AArch32 state.

According to section D1.20.2 of Arm Arm(DDI 0487A.j):
"If the general-purpose register was accessible from AArch32 state the
upper 32 bits either become zero, or hold the value that the same
architectural register held before any AArch32 execution.
The choice between these two options is IMPLEMENTATIONDEFINED"

Currently Xen does not ensure that the top 32 bits are zeroed and this
needs to be fixed.

Fix this bug by zeroing the upper 32 bits of these registers on an
entry to hypervisor when switching to AArch32 state.

Set default value of parameter compat of macro entry to 0 (AArch64 mode
as we are on 64-bit hypervisor) to avoid checking if parameter is blank
when not passed.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/arm64/entry.S | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index fc3811ad0a..d364128175 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -109,8 +109,16 @@
  * If 0, we rely on the on x0/x1 to have been saved at the correct
  * position on the stack before.
  */
-        .macro  entry, hyp, compat, save_x0_x1=1
+        .macro  entry, hyp, compat=0, save_x0_x1=1
         sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
+
+        /* Zero the upper 32 bits of the registers when switching to AArch32 */
+        .if \compat == 1      /* AArch32 mode */
+        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
+        mov w\nr, w\nr
+        .endr
+        .endif
+
         push    x28, x29
         push    x26, x27
         push    x24, x25
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:27:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239091.414422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExP-0002G7-6X; Mon, 06 Dec 2021 14:27:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239091.414422; Mon, 06 Dec 2021 14:27:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExP-0002FM-2R; Mon, 06 Dec 2021 14:27:07 +0000
Received: by outflank-mailman (input) for mailman id 239091;
 Mon, 06 Dec 2021 14:27:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEr3-0004et-IH
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:20:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id abf877bd-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:20:32 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-EXMgWJVFN6al_o42eC66nA-1; Mon, 06 Dec 2021 15:20:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:20:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:20:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:20b:312::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 14:20:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abf877bd-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800432;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KNU533Nas71KGaxkrjt8Y4qhfH0SyWRPA/lY3YgjMd0=;
	b=HJ2vg5iAb+UVWo7C3erMEG2We4go+ub2MlUSm3MWI8ggDBS+hfapHSEo+JwJTxFmCupPm7
	g15U+I1aN11wviQSgm7pOshfevFcOwhJOTNwJE2y3e2MIzjL3fF9Bm76BE9HGI9cjClsVF
	y6DiTZO0NrHLf6MkbfNgw2tW/Nnn/6M=
X-MC-Unique: EXMgWJVFN6al_o42eC66nA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jzAArQcSkhr1ruc0LADmNaN3rCMlbvb5x20QU2Ed8IU+5/n2kYJ9dPYBTxuGohQBwCBsoEbm5HeinNwfsE9UY4A27QCYKIHSj2LhUUMS5ieDq/Uwfk8cBmGcxOElyvxS+ZKbfSqNPWSP5LwbelaR0xNChN0c8XUakJ5I0C83ND/tqSNxnh0H3dqRdo0BfJT0fFGM3nUVd6zQT1I+F6LCvGewJ61FSPDjm8cF3C83QyXLMOWFp61Z7UGUmqTrlL+3xjiR2GFQ4s9/2ioCYYH0Qmhn8zoTP3qhMmaeQxZ4NX6FUwRcLNzAfqJoWRfi3QLPKo39TX9EG8cmB8RRFWO8mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KNU533Nas71KGaxkrjt8Y4qhfH0SyWRPA/lY3YgjMd0=;
 b=SQGkW7LfnzCTjVVMeQQDcJzRhEL01zWPITCzXdh3afniwy+SSEglYO4lLvxy0U1KijfZed2oAytXKX0eGsv9ZGIvxTdu3jloRPU699icW19NPsfb9Oo+CmxQAN2z/lMKcf0iGTkRoVKE4UCyG5CO9eIMnltaxGpXFedaZmCOyTwDrBOaXHgq5PsndK3SNnhVb8vVclPxAoi+772pdh4bsRSqSk6fbuniYDqIzYI0fOcXp5aCbF+lg0nerSqjFtlhL8c9UZeCl9AVUVZk2n7Kh95oJp65v/js2kDamw5t8u4UJpVpaPuLVBBIayhtDHZl360QEIxPH+5hNyNEBNulWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <905a1d43-9f35-21b4-fdec-97c592f59afc@suse.com>
Date: Mon, 6 Dec 2021 15:20:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 7/7] x86/boot: fold two MOVs into an ADD
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0044.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 48b1df6d-2759-47a5-495c-08d9b8c38ed1
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23338C4196BFED1E95E57BC1B36D9@VI1PR0401MB2333.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sEst+LtSrESXJbSMKLk+6JvrbflMca+Z4VxXFVmg3a+xUNNLMvNmowwx6YQmAGU10i9+LVZojhz5d77pmZiTYFxQeI+30nAP13NWC64c5r4fcBsbNsBdWe8ZDWokBG91ke1MfuZ/vIawqBHiuS63ToSz4R0HyK0lTEFqHM0BbYlveZxGvwDxRQR1n5bGLJHJqbUatpj+Cs73Dcz/tu4k1UVVBcFhIfiicE1OmAiFsy1mQoRxWwavY+DiiRE7rawuux0UymF+zSbcmY5AN1NsRzuZMPNHPoBZ+/sDqXHMvAuaQqxPd258N5aaZNC4c0zIBPu/h0QUMmOvZBt+nEvQiSZY5pJlDS540T7e1V7yrIVLfG+sKk+rlnOjaGIpJ3+GR0IcFb9UDGqbuFvTrpMDfJrGAEqLo8gqUCsGis04AvJ2Rs56OB+8AnB5NO9nPH7oORPjtsqGikcpu0bqcIwtkxdwkIov2Sz0BN7nLUU4vKbbBX9NMgnk/0B733+GdEZrOfm/uZXFenlAPr4AWtmsVrO0gPYcMr8OLa1ZtR0KCa87BXFlYaT3BadRlCnnu1daaZP9xXUQ5sGoPGtIl0ewC9ELv6hK4MootBEXZlq7PcPq+8xPkgBTxGQVtc+4EDELmMUue/oGnCALuRNAZLeBVDwSjF0HfOy9LTQIIlHboqnlSwcX1us+ro+upQIrqFAhdex9TePjhetaQk7eN36LccbzUwKTlsrQGatW+ncX7js=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(54906003)(316002)(16576012)(86362001)(31696002)(66476007)(66556008)(4744005)(66946007)(5660300002)(2906002)(508600001)(8936002)(4326008)(8676002)(186003)(6486002)(2616005)(956004)(38100700002)(6916009)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzI4cTIwdWpaS3lyTkovaXZjRHlpMlZnVzlGRTVCUjcxSjM0SjdFQlJmVnVT?=
 =?utf-8?B?UmpVRUFrL0w2aWVkT3VmZHZpVXJrQ252WUw1ay9TRENkNlFUcStBQmRBSkFO?=
 =?utf-8?B?UHdTVVoyWmJuZ0Y5NGJYbzI0OTAxZXl3ZWxQQTR5VXhCRDc1VDVocWlyMUFm?=
 =?utf-8?B?cng1NHgzdXVHOEdEc0QyZUlBaWlrVEttTzVMM0g1eW5XL0gxQWY0Qnh2azIz?=
 =?utf-8?B?NkdoZW9JUnUrOThCb1pnM2lJa285ZUNXenhHVnNZa0NWZXRyd0pZUkNSQjlk?=
 =?utf-8?B?UDVrN1lwamhwcTZtVDM3Z0c2c2g3cFJQVVozWkFtaVc2T3Z0ZEFzWHg2djVu?=
 =?utf-8?B?eGlQOWZXQ3NUOEFuci84R0F1VDR3Q04vTnlKQk0rNW5IdGFzYW14TzFmTTdi?=
 =?utf-8?B?aXF4a3VuemoxdjdIRmtMSkMzdkt1ZTdLbkswblVaOEdaWXBaS0RGWWtkRzRP?=
 =?utf-8?B?MVZRM1JlTlVZWkVxVTdyT0cvSkp6MXdtNHRoQVJqNzNxdlY5UDE4a291dFdn?=
 =?utf-8?B?czBEVEJWUEtGc0JsZGdqRFdLR0thaVZ2SUpZYW9ZNHFFcXBSaEZKZjJzWnky?=
 =?utf-8?B?K0twUUYyejdZT0ZZajFTaWwyOHROdkFFWkVDUytTVGpsSTZOS0FNaHkvazI3?=
 =?utf-8?B?MEEvL0lrMHBmVDlBT0lFQmFTSFZJdHMrNGo1MEl4R0FiQ083Rk9ObVJ3bHhF?=
 =?utf-8?B?TWIzL1Zyc0puM05LOEUrMmt4ZXV0T1NKQUIvSmRqMlhOeUpJNTU5aXhaYmZ0?=
 =?utf-8?B?Rzk3ZTJlNTJPOTRtMUFKVjNZazhyN01BQmhIbzE1QWFzcEtNRVNZRE1vQzdw?=
 =?utf-8?B?WnZrTHYrZTc5V3NkWE5wOThlRFpXVS9HTVpQcG8yV04xbXdnaXhLRVFDRit1?=
 =?utf-8?B?Ti9FQVE1UEtUS0VVWmFPWFBQa1hXVHVCWkV1Y3luNGVVUVBpUE9DeEZPdVhi?=
 =?utf-8?B?MkRjTE9GL25seHowQmczMXNMWDRBbkNNQ3FXUmdET2FFVWtHYmlsdzVXemhG?=
 =?utf-8?B?RzEyUGQySU9KZFdJY1E3TjdsZVRNcXdEU3VUMWFwZ0d4bVJraUExL2F6S0NV?=
 =?utf-8?B?SXRjUmh5WUpmZGkyMnlPQnpINmVRS2crZGhoYW4zbXZPWmNabHM1SXVDV3ZZ?=
 =?utf-8?B?SlVldmUzcUNCSnQwY1VpTUJOSUlhYWhCaGpTSDN1Wi9QZUp4RTJKR2RzRURL?=
 =?utf-8?B?dC9ZZW8xV1NLNUFtczh4cm5xMlFZam8xeG5FNDI1VDBOZGxCb1hlZG5BRTVa?=
 =?utf-8?B?bHVaeWhPbUMxNWkrQkN4cW9DdlEvQU1nY1BySFA1bTVvS2w1SnhIa1VWWXlO?=
 =?utf-8?B?NTJtRmV3UlJwS0hhM0Jld2N2OUpLVzZ1T0Fqam1TN1FDME5uSUx5ZlhPWVRp?=
 =?utf-8?B?a0ZQcHRWek0wUGxXdVlJdXk2cDl3cWRoVEd6Q2cwNTVPMXl1TmxkK0R3WFNI?=
 =?utf-8?B?WVd6ZThIY1JaTDY5enlwcmVCTS9MYkZLYUxEZU5DeXpWaDVQQWVPdGNyQ05T?=
 =?utf-8?B?dEgxL0ZPRFlVTDI4MWQ3SVo0L3JEM3Y1NkRMOXQwVFcrK1NFNHRBZlZkRHFr?=
 =?utf-8?B?d3BtcklEbXI1Tk9DZzJDZndjdHNkc1ZPc2pQWS8zbHlsUTU0ZDhDNzdSK216?=
 =?utf-8?B?Znh1WThjUmx5YXgwd0xubVVza1BuQXhOd2tuaDJUR3N2dmQzcDQzbDZITXJs?=
 =?utf-8?B?clVyRndiRTJackJnaEJYSDlMY21zZElrMVRhekk3ZFNBNnhzRFM4eGx3VWky?=
 =?utf-8?B?dndBcHIweENRaWpiRnQxK0cvN0V4YUJSK3hnM2hqM1Bka3JLOW85S282SUk3?=
 =?utf-8?B?Q0ZuVTRLb3U2T3VjTnpYc3hkb3FBSFhvNjgwaXRJMnJtakFXaGY1ckp2OVNT?=
 =?utf-8?B?SEkwRnFXUE85ZHdkYnJuRU9pM0ZDZlZwK25tZVJkaEU3YmdrQXFTVXp2Zm9n?=
 =?utf-8?B?RGR1K1FmaTk3eWpWRTJoczhWM2ozRzNwRFhCdU1TN0Q2ZjY3S0x1a292QzdC?=
 =?utf-8?B?UUhUVEZBTTN2R0VncXZXQVBpNVI4OTFuNWEveVpBb1Q3Ym9maXZ1TG1pVVRH?=
 =?utf-8?B?M29OdDFoWDFzeWdySmtWK1hUbWJjVVlBeFVhZ0FUdUN5UG5PcUNEQXk3d3I4?=
 =?utf-8?B?VjFEc01jU2FWZnhGN2Q3QUE3NGM2TjlpeTlZTVpKTFNFemh0WXJTZkR0dGlM?=
 =?utf-8?Q?hoYalOwCXjJFeByH1sIJMH4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b1df6d-2759-47a5-495c-08d9b8c38ed1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:20:30.5498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rfxdOZpd6vHHsU2FBC8TmXhkOgno80co6s9UtLgbHjgOvr0K4bhd2xHv2tY/Y8BNvR4Rv39msPWlLYG+7ZEi7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333

There's no point going through %ax; the addition can be done directly in
%di.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/arch/x86/boot/mem.S
+++ b/xen/arch/x86/boot/mem.S
@@ -24,9 +24,7 @@ get_memory_map:
         cmpw    $E820_BIOS_MAX, bootsym(bios_e820nr) # up to this many entries
         jae     .Ldone
 
-        movw    %di,%ax
-        addw    $20,%ax
-        movw    %ax,%di
+        addw    $20,%di
         testl   %ebx,%ebx                       # check to see if
         jnz     1b                              # %ebx is set to EOF
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:27:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:27:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239094.414431 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExP-0002NO-Ph; Mon, 06 Dec 2021 14:27:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239094.414431; Mon, 06 Dec 2021 14:27:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExP-0002Jg-Dj; Mon, 06 Dec 2021 14:27:07 +0000
Received: by outflank-mailman (input) for mailman id 239094;
 Mon, 06 Dec 2021 14:27:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=BmDh=QX=gmail.com=ltykernel@srs-se1.protection.inumbo.net>)
 id 1muEq7-0004et-40
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:19:35 +0000
Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com
 [2607:f8b0:4864:20::1029])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88b39947-569f-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:19:34 +0100 (CET)
Received: by mail-pj1-x1029.google.com with SMTP id
 cq22-20020a17090af99600b001a9550a17a5so10934053pjb.2
 for <xen-devel@lists.xenproject.org>; Mon, 06 Dec 2021 06:19:34 -0800 (PST)
Received: from ?IPV6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b])
 by smtp.gmail.com with ESMTPSA id
 h1sm3517800pfh.219.2021.12.06.06.19.22
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 06 Dec 2021 06:19:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88b39947-569f-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:subject:content-language:to
         :cc:references:from:in-reply-to:content-transfer-encoding;
        bh=7+TjBg26qYjN6N7+9VcAF9zyslm2ABiWax4bLutA+tA=;
        b=f9M5JLJRG6hZFPCcZ1VGBj6dk4h92i9GiiVgKsNNUQFiDTSIXmaER9IaQWziUfrQ/0
         qa3GNaf/njTkL1uJ81a318oppGqxeZ4BbcT9GGYMjs1cw8PHMlBEDdFp5Gu7W2ZYhqeP
         DQ0dE5SsoRhc/sIPqjG5IRHWnrHc+0w5hEjT3ppnETiBZyKvJyuh5hygqrwyVBhoEnmJ
         IwRmbyJ5sNomLrxjpRo1y9wtWt2MJXEM2X247X8t1UvJ2rV20IbyXdb2S1lE9i34MGPO
         C7yQKcwPzpoDJz5kk+NMg8L4gzvSsI27nnr11s1xyG3B7cafIHH1YyJFJ5x78gBD3amG
         bCXA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=7+TjBg26qYjN6N7+9VcAF9zyslm2ABiWax4bLutA+tA=;
        b=AsLxf+NrMQ+Hdoz/4wR0YGhShW9kAzc97SHwTVyzapizK0eumDn3vJqeyJtAgpVXVY
         ZfQ3qUYl504DwXosCScNJyrxcSMXqToLly9RmUPbKHFadpLDysZL+4MYeVPMlxggljMs
         +1s2VYkc3S9dK2j5XYkyNZUAaUB+EBdr6ZYh0ajkPk38h9+x+TpkTd3knGEPM1niQD7s
         BImW0/TQHoD4odCYzLb0gGFqotfo0Tfsj+HsLITuO3CWkyFjCLfnh9vZx/gEIie3zmu0
         VByuMQVSfivZWX1gTQqiBXm/4VEyN0bh/OWtJTacCcpkVQqOabtiz5OsfVpk7OHT2cMD
         sAiA==
X-Gm-Message-State: AOAM533MyZYOulihaYOXlZkOmnE5ExOYDbQafSQuTK+sw7++Qr6IbFJI
	qkdpdTM/UV9xOiUPMEzxSew=
X-Google-Smtp-Source: ABdhPJw5eBcqMnlmCu3VP7SDK7JlPHBF3sS/6sU5CfZhorAn8F+Tm/Z37W+b1RJF7S8Gmv/jOQFzmw==
X-Received: by 2002:a17:90b:4b51:: with SMTP id mi17mr37838716pjb.48.1638800372941;
        Mon, 06 Dec 2021 06:19:32 -0800 (PST)
Message-ID: <581569ce-b166-1cad-2624-66de319cc2b9@gmail.com>
Date: Mon, 6 Dec 2021 22:19:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V4 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for
 Isolation VM
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, kys@microsoft.com,
 haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org,
 decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
 sstabellini@kernel.org, boris.ostrovsky@oracle.com, joro@8bytes.org,
 will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com,
 martin.petersen@oracle.com, arnd@arndb.de, hch@infradead.org,
 m.szyprowski@samsung.com, robin.murphy@arm.com, thomas.lendacky@amd.com,
 Tianyu.Lan@microsoft.com, xen-devel@lists.xenproject.org,
 michael.h.kelley@microsoft.com
Cc: iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
 linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com,
 brijesh.singh@amd.com, konrad.wilk@oracle.com, hch@lst.de,
 parri.andrea@gmail.com, dave.hansen@intel.com
References: <20211205081815.129276-1-ltykernel@gmail.com>
 <20211205081815.129276-4-ltykernel@gmail.com>
 <a5943893-510a-3fc8-cbb7-8742369bf36b@suse.com>
 <125ffb7d-958c-e77a-243b-4cf38f690396@gmail.com>
 <ed9aa3d5-9ac8-2195-e617-85599ffd7864@suse.com>
From: Tianyu Lan <ltykernel@gmail.com>
In-Reply-To: <ed9aa3d5-9ac8-2195-e617-85599ffd7864@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 12/5/2021 6:31 PM, Juergen Gross wrote:
> On 05.12.21 09:48, Tianyu Lan wrote:
>>
>>
>> On 12/5/2021 4:34 PM, Juergen Gross wrote:
>>> On 05.12.21 09:18, Tianyu Lan wrote:
>>>> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>>>>
>>>> hyperv Isolation VM requires bounce buffer support to copy
>>>> data from/to encrypted memory and so enable swiotlb force
>>>> mode to use swiotlb bounce buffer for DMA transaction.
>>>>
>>>> In Isolation VM with AMD SEV, the bounce buffer needs to be
>>>> accessed via extra address space which is above shared_gpa_boundary
>>>> (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG.
>>>> The access physical address will be original physical address +
>>>> shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP
>>>> spec is called virtual top of memory(vTOM). Memory addresses below
>>>> vTOM are automatically treated as private while memory above
>>>> vTOM is treated as shared.
>>>>
>>>> Hyper-V initalizes swiotlb bounce buffer and default swiotlb
>>>> needs to be disabled. pci_swiotlb_detect_override() and
>>>> pci_swiotlb_detect_4gb() enable the default one. To override
>>>> the setting, hyperv_swiotlb_detect() needs to run before
>>>> these detect functions which depends on the pci_xen_swiotlb_
>>>> init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb
>>>> _detect() to keep the order.
>>>
>>> Why? Does Hyper-V plan to support Xen PV guests? If not, I don't see
>>> the need for adding this change.
>>>
>>
>> This is to keep detect function calling order that Hyper-V detect 
>> callback needs to call before pci_swiotlb_detect_override() and 
>> pci_swiotlb_detect_4gb(). This is the same for why
>> pci_swiotlb_detect_override() needs to depend on the 
>> pci_xen_swiotlb_detect(). Hyper-V also has such request and so make 
>> xen detect callback depends on Hyper-V one.
> 
> And does this even work without CONFIG_SWIOTLB_XEN, i.e. without
> pci_xen_swiotlb_detect() being in the system?
> 
Hi Juergen:
	Thanks for your review. This is a issue and I just sent out a v5 which 
decouples the dependency between xen and hyperv.


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:27:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:27:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239102.414452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExb-0003Vm-4j; Mon, 06 Dec 2021 14:27:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239102.414452; Mon, 06 Dec 2021 14:27:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muExa-0003UN-Tt; Mon, 06 Dec 2021 14:27:18 +0000
Received: by outflank-mailman (input) for mailman id 239102;
 Mon, 06 Dec 2021 14:27:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muEoO-00043L-AX
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:17:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49541680-569f-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:17:47 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-t4lefXQdOmeyXvzdf7pBvA-1; Mon, 06 Dec 2021 15:17:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 14:17:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:17:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:20b:b2::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.20 via Frontend Transport; Mon, 6 Dec 2021 14:17:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49541680-569f-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638800267;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dCgwMX/P2r3dO1pV7Q9gj9sxLbIsHw+iCcJmAXUNoHc=;
	b=iENc5wEgYrnLdoQXins0weQ2ufbBFDuHMf8x+uFLwm59/1NunW3zeWzcy4Mh+vyn8dJKcQ
	OdbWgkAdIF7iOUIuyorQKfhnvPGuk+Eul+v9tSV772FLRbNNiJQSIp9gNnehnr+EOcVfx4
	aUxkYpSRlCxbh+nt3uGMldnaZ/rXe4s=
X-MC-Unique: t4lefXQdOmeyXvzdf7pBvA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QyS7k/UZxW+J6allgJCLFypcoBUz0aIcsK20irNRJw2WRQ1f5YFsYg2J3KMOZABB7QcJVRJiPYDWSuBhMWzycSO0SAzSL0Dsp/YLolLreC9IcMvDPt74xEouv3/I58lLq/i+onoH7l41rSmmLLCwRoSXqw4OO/cFBHMZgaAgDfYkCj+5ZjbO4En4lnGGBwBJyikdttgpxFJ+ydLMx8zi5QXkZ2q9FzdTFevA40qaUO1uQU657R68jGkvNc4FvL1reTvIH9tMeNmulgX1Z09e+jJvSbzNanZJNa6L9m+GbFI+SVm4ucIFTKDHBiPsn01aj27KT0DDVOWxiZrlzAe9GQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=dCgwMX/P2r3dO1pV7Q9gj9sxLbIsHw+iCcJmAXUNoHc=;
 b=NTKPL+yM3t5XHckJPP8SYkro39ZclmrVt9cRRsVAlBenNC+2LGs2t+Bl/W/AtM4+92Sq8jDdcj5pddRbsjEk++6hRHqXop8XohsNMulU+WaIQa27JzgBkFyQtNsapJ7oQ7+Gox3lJwBDE/GnAfs2Zm9juXFlz7FgPq9Z/chJ8UJoWsXcLsJv0vHM5OAl5uHXUJV0jAFUKkxCZInXYo7B46QboVc6mtZ+Xz3PDSFLWjwIl+zVxlw+VU146TJny1ogN+beznbtaDgvG27gyRi4sosp4+uE0Na165eSqbOHkOPPUBK+4kAOsSm8sn6MokBDCKBMngzfNkIKYU54VA/38w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <53325a1b-8777-0a4f-a334-b967662ec839@suse.com>
Date: Mon, 6 Dec 2021 15:17:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v3 2/7] x86/boot: obtain video info from boot loader
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
In-Reply-To: <4af7ce92-8f4b-0be2-2439-a1bfaff59be6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0006.eurprd08.prod.outlook.com
 (2603:10a6:20b:b2::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54f5b9ca-ab7d-4963-3558-08d9b8c32b1b
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB377402EC80E9EC3F9C00E784B36D9@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BZax0OFq0NJtjfgHMsgjBU0kJFftiMv9PlhmapIEkvsCMrmoLJFNCOZdDdLu244OW5lrIiSlfeJ/VNh0RitAX6xs/tmwQBzOGroczHXlQ51Z7A8Gc64BGYrNyrtoVsHxslwYhplGxYHEDpHbPZbhZTAWz72zv8WzLX2oCZAYJHm/Zw/RR+RSqPevdgO7XDhA4UdQzu0OOFMCz+u+VVQZXQMdFM1TkVIZdhcHOUcNsuUcaNJcvAE0qpW605u3CiW952uD+eMzt5HC/Sx3vI+XkFrtSeHEbTxSqK9Sy0uxOQn6yQ41U5cWW4cS9trxiyzrYxD49NPE5gcM/AjDLLR2Krqva/vZMfutV2Luo5YkP4BPGvlS62k5NCetaLm/rsNB0YwH+X7uCFQCPvur2pareoKnREsU8yBaIoszU4ljtfMEVExKQ4wxVBxY4YJysd+O7TrG8uK5FmcqFYyK9s2SWkpSKH1WnXva7tlRggzDvgPL2GgLhxmAlAPLq5GSniDD3kM2s8RhzVgJrtKDbNLbDg3AUQdjezbNMxqJoGNsDe+6b7+QzgTSw+Vsdc3DgneALTpzzc2tENLSUuN3R+2DaOa4jEsUcc/A+IrkNydII3GnKCiusRPQvOnYrZyqeYn/MWgST0RhLCtMGoiNqAtVswr+Uq7NI3Nz/YsKHMb0MgTClfbxpcIE+kXdb4R+KhRQ6/qnTKCiR2AC5p/3IF1orA5OTmexZzopMcAPo5BGjdU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(4326008)(66476007)(66556008)(66946007)(8936002)(31696002)(508600001)(31686004)(6486002)(8676002)(6916009)(956004)(5660300002)(186003)(54906003)(2906002)(36756003)(16576012)(316002)(2616005)(38100700002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NC83OUdraSsvMUtiVUlvakNVQUtuTG9uRHJTVVVRb2lIbmxGTTdkZVh3bWd1?=
 =?utf-8?B?aXErd2ZnVWxSbmdjMitlemNYT0lxQzcrbCtnRnZtOWlRUGFrZW1Xd1dEY0dW?=
 =?utf-8?B?a0hxK3NFc1VZZGpIZFRYWkRpTkE4WHYyU1NtSzBpRm9veVoxbExMblBDeGVy?=
 =?utf-8?B?SDlMa25kZDVNamIzYlpMUmQ1Nno0VDRTZnBEWWozWWJJWmtIMWM1akFBSnFD?=
 =?utf-8?B?TExnbVk4bjFOZFhJM2huNzJnYy9aeTJub0Uxd2hxL0szelVoVkVHSHYxaDdP?=
 =?utf-8?B?VnhBTG5KcWlpNFVLS1Y2c3g0bCtLaVl1SXFCY1d6WUhYR1ZVN1EzcXNVVkQx?=
 =?utf-8?B?ZmhnTWZsNThzNmFhS3NqbHQxdml6bHQ3eW10bWpYODlyMTZuU1dCZTM0Uy9N?=
 =?utf-8?B?RHNvQ0w4MWtRRG5paXRWVW9TR0I1M0l5dTBMakxucGVWUEJ6U3NCUW11cWdj?=
 =?utf-8?B?angxSVdiano2cXNFcmkwTjFnRGpmem5QdHVZSUM1YVh6OExTYmRBNXZ6V29M?=
 =?utf-8?B?akgrUUQ5UXlUOWFlSDVYVG9xa3RwdXdKUXFJcnIzVGV3aHlHZnc3Sm9nenR0?=
 =?utf-8?B?aDdwS2s1NHQwd0EwYzRWYVlRRU1JY0ZXbVZFeUtueG1xMVB2VmVaQXZZRFlk?=
 =?utf-8?B?MVpoZ0l3RlJXdHNpVmZmaTI2MFZhM29xL3ZjRXdLSjVsVENBNDhYN0lwTTRD?=
 =?utf-8?B?WndTeWFiWU5LZXkwb2lGZk9uazdncEZrWGdmSjFscENYeFRyeVlHMG14eTRw?=
 =?utf-8?B?MnU1eHpLUHczeitGVGZaTEVsaTBKRnhhaVkvWGNQRDBCeDJxSW1yMkRTdlNo?=
 =?utf-8?B?eGlKZVNYeC9kSXpzbnlXek81N01Zei8rL3BsT0dFZ2hFa1RmVTNDSzJmckZs?=
 =?utf-8?B?bitieExvQzZkaVY5TnFMRWhBR2VINzd4ajcrSGEzYzJxYklGNGV6L0N0d1JG?=
 =?utf-8?B?Qmd6WUVISFlnSU1SSXA4d3lDK212NFFZelZueGxBZHgrcXgralN6VzhNOW9k?=
 =?utf-8?B?MUtRUWk1bmlhcFpJcGM5N2psTVJHc2R3ZjZXZm55cGN0aDF1REtpcXZkVUNP?=
 =?utf-8?B?Y25nK3FFT1NxZWxjL3JmMTJMMFlaYndCRnREeWZjK0R2QXcvdGN0MjVUaFR3?=
 =?utf-8?B?NllLSnlIMXMxeUc1Q0xjRTQrNklmV0U0eDBtQ1FaVU1YeTRSQnJzeVg2Z1VJ?=
 =?utf-8?B?ZkpWZkJQZGxGOVA2Vzc2eGpQcTU1UEd3RzVkOXNCOWpDeC9TTTlhRmp0WkZZ?=
 =?utf-8?B?RDc0TFdjQ1ZQU09PR1lEQ0EwaVY1ckl3L0RpTHBha0k5ZFp5ZDBMbWdSaEli?=
 =?utf-8?B?TnNvNFNFbXBmQmt0NkJBRFlDc1Era053QnZwa0pHTFpHU2FTWFVoQXVqd0dx?=
 =?utf-8?B?aGpqdGhFbS8xVGZTS0hnK0x0NlhSd3BEc0h3eitxaE1qdVZRSXdaUUlobnFD?=
 =?utf-8?B?cDRmLzR1VTBrU3ZzekU2TFA1MjBaUzFyNS82TnVNWWpwRE5yQVBkWWlUY2RB?=
 =?utf-8?B?Q1lBSGxrL25SakJIS2t0U00rNkdYVkwvNzZpaklHbXQ4MllCQUk3ZTRjWEZV?=
 =?utf-8?B?N1RoempmVjRUVXU0WkJzV1RUYTBtOUU0SnN6c0NPOFdicHl4MWUwcWVHNnYr?=
 =?utf-8?B?VUZCL0RCVmlYcE4wRXplNUZWbG5pYkExSTQ5RzNCWG85RTFQUUpWYzFkb0F3?=
 =?utf-8?B?SytHQVdYdjRXMHpDZmFldDl2QUgrK2laKzFNQlRBUUV3Y29YOWZ5NDhlZDFv?=
 =?utf-8?B?bUd2RmxrK21HRXdoa2Jnam13dnlxMFp4R3lwVHc4bnJJUnEzVW9wY3lRWjJu?=
 =?utf-8?B?NG9idDdqSi91STZRY1NjRjEvQ05LNWcxbVpEbzkxcmN0YXl0c0pBUnNPL1A5?=
 =?utf-8?B?MHJhbUk3bndRT1daTVV0emJlcHRSSERaU3Y1TDJLb3hQWkJsQk1qQVYyYSs3?=
 =?utf-8?B?L2dBZUY2cDBlRk5yT1U3MCtpWEEwa3N1dmcvRGtOYUJmYnlaUnk4VEFSUjhv?=
 =?utf-8?B?SjBPdTQ1MkdQTHRQbDRUSDFMRDdQSi9jeWhSaERMck1WZk5sMm5yTzA0TWp1?=
 =?utf-8?B?Q1V4SlFmMGxwY0J6clZ0a3hoamJNYThVWTFZT2RxK09mY2xzTmEvV1pIMnNI?=
 =?utf-8?B?ZW1RRnhKcmNsWnRjdnN4TWR3dTF3T2hRK25kWWE3NnBLcG5tQnZNZ1k5V0E4?=
 =?utf-8?Q?Df3cGUFLrRjGuTDqI+/093s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54f5b9ca-ab7d-4963-3558-08d9b8c32b1b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:17:43.2312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FjqE855dXw2D5qDfUQC5qdVV/MtSB/Xk6xQjSuzUIcy1NUV81o5WZ5DCi+2pc05FcwW7nWaHts8ly1OOjeoQFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

With MB2 the boot loader may provide this information, allowing us to
obtain it without needing to enter real mode (assuming we don't need to
set a new mode from "vga=", but can instead inherit the one the
bootloader may have established).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v3: Re-base.
v2: New.

--- a/xen/arch/x86/boot/Makefile
+++ b/xen/arch/x86/boot/Makefile
@@ -6,7 +6,7 @@ CMDLINE_DEPS = $(DEFS_H_DEPS) video.h \
 	       $(BASEDIR)/include/xen/kconfig.h \
 	       $(BASEDIR)/include/generated/autoconf.h
 
-RELOC_DEPS = $(DEFS_H_DEPS) \
+RELOC_DEPS = $(DEFS_H_DEPS) video.h \
 	     $(BASEDIR)/include/generated/autoconf.h \
 	     $(BASEDIR)/include/xen/kconfig.h \
 	     $(BASEDIR)/include/xen/multiboot.h \
--- a/xen/arch/x86/boot/defs.h
+++ b/xen/arch/x86/boot/defs.h
@@ -53,6 +53,7 @@ typedef unsigned int u32;
 typedef unsigned long long u64;
 typedef unsigned int size_t;
 typedef u8 uint8_t;
+typedef u16 uint16_t;
 typedef u32 uint32_t;
 typedef u64 uint64_t;
 
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86/boot/head.S
@@ -562,12 +562,18 @@ trampoline_setup:
         mov     %esi, sym_esi(xen_phys_start)
         mov     %esi, sym_esi(trampoline_xen_phys_start)
 
-        mov     sym_esi(trampoline_phys), %ecx
-
         /* Get bottom-most low-memory stack address. */
+        mov     sym_esi(trampoline_phys), %ecx
         add     $TRAMPOLINE_SPACE,%ecx
 
+#ifdef CONFIG_VIDEO
+        lea     sym_esi(boot_vid_info), %edx
+#else
+        xor     %edx, %edx
+#endif
+
         /* Save Multiboot / PVH info struct (after relocation) for later use. */
+        push    %edx                /* Boot video info to be filled from MB2. */
         push    %ecx                /* Bottom-most low-memory stack address. */
         push    %ebx                /* Multiboot / PVH information address. */
         push    %eax                /* Magic number. */
--- a/xen/arch/x86/boot/reloc.c
+++ b/xen/arch/x86/boot/reloc.c
@@ -14,9 +14,10 @@
 
 /*
  * This entry point is entered from xen/arch/x86/boot/head.S with:
- *   - 0x4(%esp) = MAGIC,
- *   - 0x8(%esp) = INFORMATION_ADDRESS,
- *   - 0xc(%esp) = TOPMOST_LOW_MEMORY_STACK_ADDRESS.
+ *   - 0x04(%esp) = MAGIC,
+ *   - 0x08(%esp) = INFORMATION_ADDRESS,
+ *   - 0x0c(%esp) = TOPMOST_LOW_MEMORY_STACK_ADDRESS.
+ *   - 0x10(%esp) = BOOT_VIDEO_INFO_ADDRESS.
  */
 asm (
     "    .text                         \n"
@@ -32,6 +33,39 @@ asm (
 #include "../../../include/xen/kconfig.h"
 #include <public/arch-x86/hvm/start_info.h>
 
+#ifdef CONFIG_VIDEO
+# include "video.h"
+
+/* VESA control information */
+struct __packed vesa_ctrl_info {
+    uint8_t signature[4];
+    uint16_t version;
+    uint32_t oem_name;
+    uint32_t capabilities;
+    uint32_t mode_list;
+    uint16_t mem_size;
+    /* We don't use any further fields. */
+};
+
+/* VESA 2.0 mode information */
+struct vesa_mode_info {
+    uint16_t attrib;
+    uint8_t window[14]; /* We don't use the individual fields. */
+    uint16_t bytes_per_line;
+    uint16_t width;
+    uint16_t height;
+    uint8_t cell_width;
+    uint8_t cell_height;
+    uint8_t nr_planes;
+    uint8_t depth;
+    uint8_t memory[5]; /* We don't use the individual fields. */
+    struct boot_video_colors colors;
+    uint8_t direct_color;
+    uint32_t base;
+    /* We don't use any further fields. */
+};
+#endif /* CONFIG_VIDEO */
+
 #define get_mb2_data(tag, type, member)   (((multiboot2_tag_##type##_t *)(tag))->member)
 #define get_mb2_string(tag, type, member) ((u32)get_mb2_data(tag, type, member))
 
@@ -146,7 +180,7 @@ static multiboot_info_t *mbi_reloc(u32 m
     return mbi_out;
 }
 
-static multiboot_info_t *mbi2_reloc(u32 mbi_in)
+static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out)
 {
     const multiboot2_fixed_t *mbi_fix = _p(mbi_in);
     const multiboot2_memory_map_t *mmap_src;
@@ -154,6 +188,9 @@ static multiboot_info_t *mbi2_reloc(u32
     module_t *mbi_out_mods = NULL;
     memory_map_t *mmap_dst;
     multiboot_info_t *mbi_out;
+#ifdef CONFIG_VIDEO
+    struct boot_video_info *video = NULL;
+#endif
     u32 ptr;
     unsigned int i, mod_idx = 0;
 
@@ -254,17 +291,64 @@ static multiboot_info_t *mbi2_reloc(u32
             ++mod_idx;
             break;
 
+#ifdef CONFIG_VIDEO
+        case MULTIBOOT2_TAG_TYPE_VBE:
+            if ( video_out )
+            {
+                const struct vesa_ctrl_info *ci;
+                const struct vesa_mode_info *mi;
+
+                video = _p(video_out);
+                ci = (void *)get_mb2_data(tag, vbe, vbe_control_info);
+                mi = (void *)get_mb2_data(tag, vbe, vbe_mode_info);
+
+                if ( ci->version >= 0x0200 && (mi->attrib & 0x9b) == 0x9b )
+                {
+                    video->capabilities = ci->capabilities;
+                    video->lfb_linelength = mi->bytes_per_line;
+                    video->lfb_width = mi->width;
+                    video->lfb_height = mi->height;
+                    video->lfb_depth = mi->depth;
+                    video->lfb_base = mi->base;
+                    video->lfb_size = ci->mem_size;
+                    video->colors = mi->colors;
+                    video->vesa_attrib = mi->attrib;
+                }
+
+                video->vesapm.seg = get_mb2_data(tag, vbe, vbe_interface_seg);
+                video->vesapm.off = get_mb2_data(tag, vbe, vbe_interface_off);
+            }
+            break;
+
+        case MULTIBOOT2_TAG_TYPE_FRAMEBUFFER:
+            if ( (get_mb2_data(tag, framebuffer, framebuffer_type) !=
+                  MULTIBOOT2_FRAMEBUFFER_TYPE_RGB) )
+            {
+                video_out = 0;
+                video = NULL;
+            }
+            break;
+#endif /* CONFIG_VIDEO */
+
         case MULTIBOOT2_TAG_TYPE_END:
-            return mbi_out;
+            goto end; /* Cannot "break;" here. */
 
         default:
             break;
         }
 
+ end:
+
+#ifdef CONFIG_VIDEO
+    if ( video )
+        video->orig_video_isVGA = 0x23;
+#endif
+
     return mbi_out;
 }
 
-void * __stdcall reloc(u32 magic, u32 in, u32 trampoline)
+void *__stdcall reloc(uint32_t magic, uint32_t in, uint32_t trampoline,
+                      uint32_t video_info)
 {
     alloc = trampoline;
 
@@ -274,7 +358,7 @@ void * __stdcall reloc(u32 magic, u32 in
         return mbi_reloc(in);
 
     case MULTIBOOT2_BOOTLOADER_MAGIC:
-        return mbi2_reloc(in);
+        return mbi2_reloc(in, video_info);
 
     case XEN_HVM_START_MAGIC_VALUE:
         if ( IS_ENABLED(CONFIG_PVH_GUEST) )
--- a/xen/arch/x86/boot/video.h
+++ b/xen/arch/x86/boot/video.h
@@ -28,4 +28,45 @@
 /* The "recalculate timings" flag */
 #define VIDEO_RECALC        0x8000
 
+#ifndef __ASSEMBLY__
+struct boot_video_info {
+    uint8_t  orig_x;             /* 0x00 */
+    uint8_t  orig_y;             /* 0x01 */
+    uint8_t  orig_video_mode;    /* 0x02 */
+    uint8_t  orig_video_cols;    /* 0x03 */
+    uint8_t  orig_video_lines;   /* 0x04 */
+    uint8_t  orig_video_isVGA;   /* 0x05 */
+    uint16_t orig_video_points;  /* 0x06 */
+
+    /* VESA graphic mode -- linear frame buffer */
+    uint32_t capabilities;       /* 0x08 */
+    uint16_t lfb_linelength;     /* 0x0c */
+    uint16_t lfb_width;          /* 0x0e */
+    uint16_t lfb_height;         /* 0x10 */
+    uint16_t lfb_depth;          /* 0x12 */
+    uint32_t lfb_base;           /* 0x14 */
+    uint32_t lfb_size;           /* 0x18 */
+    union {
+        struct {
+            uint8_t  red_size;   /* 0x1c */
+            uint8_t  red_pos;    /* 0x1d */
+            uint8_t  green_size; /* 0x1e */
+            uint8_t  green_pos;  /* 0x1f */
+            uint8_t  blue_size;  /* 0x20 */
+            uint8_t  blue_pos;   /* 0x21 */
+            uint8_t  rsvd_size;  /* 0x22 */
+            uint8_t  rsvd_pos;   /* 0x23 */
+        };
+        struct boot_video_colors {
+            uint8_t  rgbr[8];
+        } colors;
+    };
+    struct {
+        uint16_t seg;            /* 0x24 */
+        uint16_t off;            /* 0x26 */
+    } vesapm;
+    uint16_t vesa_attrib;        /* 0x28 */
+};
+#endif /* __ASSEMBLY__ */
+
 #endif /* __BOOT_VIDEO_H__ */
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -519,35 +519,7 @@ static void __init setup_max_pdx(unsigne
 static struct e820map __initdata boot_e820;
 
 #ifdef CONFIG_VIDEO
-struct boot_video_info {
-    u8  orig_x;             /* 0x00 */
-    u8  orig_y;             /* 0x01 */
-    u8  orig_video_mode;    /* 0x02 */
-    u8  orig_video_cols;    /* 0x03 */
-    u8  orig_video_lines;   /* 0x04 */
-    u8  orig_video_isVGA;   /* 0x05 */
-    u16 orig_video_points;  /* 0x06 */
-
-    /* VESA graphic mode -- linear frame buffer */
-    u32 capabilities;       /* 0x08 */
-    u16 lfb_linelength;     /* 0x0c */
-    u16 lfb_width;          /* 0x0e */
-    u16 lfb_height;         /* 0x10 */
-    u16 lfb_depth;          /* 0x12 */
-    u32 lfb_base;           /* 0x14 */
-    u32 lfb_size;           /* 0x18 */
-    u8  red_size;           /* 0x1c */
-    u8  red_pos;            /* 0x1d */
-    u8  green_size;         /* 0x1e */
-    u8  green_pos;          /* 0x1f */
-    u8  blue_size;          /* 0x20 */
-    u8  blue_pos;           /* 0x21 */
-    u8  rsvd_size;          /* 0x22 */
-    u8  rsvd_pos;           /* 0x23 */
-    u16 vesapm_seg;         /* 0x24 */
-    u16 vesapm_off;         /* 0x26 */
-    u16 vesa_attrib;        /* 0x28 */
-};
+# include "boot/video.h"
 extern struct boot_video_info boot_vid_info;
 #endif
 
--- a/xen/include/xen/multiboot2.h
+++ b/xen/include/xen/multiboot2.h
@@ -158,6 +158,59 @@ typedef struct {
     multiboot2_memory_map_t entries[];
 } multiboot2_tag_mmap_t;
 
+typedef struct
+{
+    uint32_t type;
+    uint32_t size;
+    uint16_t vbe_mode;
+    uint16_t vbe_interface_seg;
+    uint16_t vbe_interface_off;
+    uint16_t vbe_interface_len;
+    uint8_t vbe_control_info[512];
+    uint8_t vbe_mode_info[256];
+} multiboot2_tag_vbe_t;
+
+typedef struct
+{
+    uint8_t red;
+    uint8_t green;
+    uint8_t blue;
+} multiboot2_color_t;
+
+typedef struct
+{
+    uint32_t type;
+    uint32_t size;
+    uint64_t framebuffer_addr;
+    uint32_t framebuffer_pitch;
+    uint32_t framebuffer_width;
+    uint32_t framebuffer_height;
+    uint8_t framebuffer_bpp;
+#define MULTIBOOT2_FRAMEBUFFER_TYPE_INDEXED  0
+#define MULTIBOOT2_FRAMEBUFFER_TYPE_RGB      1
+#define MULTIBOOT2_FRAMEBUFFER_TYPE_EGA_TEXT 2
+    uint8_t framebuffer_type;
+    uint16_t reserved;
+
+    union
+    {
+        struct
+        {
+            uint16_t framebuffer_palette_num_colors;
+            multiboot2_color_t framebuffer_palette[];
+        };
+        struct
+        {
+            uint8_t framebuffer_red_field_position;
+            uint8_t framebuffer_red_mask_size;
+            uint8_t framebuffer_green_field_position;
+            uint8_t framebuffer_green_mask_size;
+            uint8_t framebuffer_blue_field_position;
+            uint8_t framebuffer_blue_mask_size;
+        };
+    };
+} multiboot2_tag_framebuffer_t;
+
 typedef struct {
     u32 type;
     u32 size;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:28:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:28:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239121.414463 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEyd-0004vf-HJ; Mon, 06 Dec 2021 14:28:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239121.414463; Mon, 06 Dec 2021 14:28:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEyd-0004vV-E8; Mon, 06 Dec 2021 14:28:23 +0000
Received: by outflank-mailman (input) for mailman id 239121;
 Mon, 06 Dec 2021 14:28:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muEyc-0004uv-GK
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:28:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muEyZ-0007Fl-M8; Mon, 06 Dec 2021 14:28:19 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muEyZ-0004WD-Fw; Mon, 06 Dec 2021 14:28:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Y07Z0IucIf7KAhsvg+ocjOpbTTJeKNdY3IVrIFYq6MM=; b=ema2e6nHCMRM+BagCv1mxsYbL+
	abxmG4aKREQz7HqnvePSmWWzo+p2jmS1KUOarzA68tfAc6uRqxMzCbjiuqPocBdObJT8J4Yih11RV
	AzB0rzp+Xk362zZ845kRoevNj1K1sBLQ0OPgbJ2JhqflZzGUpxtg6VqBhlOhhFf+g2ug=;
Message-ID: <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
Date: Mon, 6 Dec 2021 14:28:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
To: Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 06/12/2021 13:44, Jan Beulich wrote:
> On 26.11.2021 13:52, Ian Jackson wrote:
>> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>>> On 26.11.2021 11:04, Julien Grall wrote:
>>>> For this case, you provided some sort of an explanation but so far, I am
>>>> still waiting for a link to confirm that the signed-off-by match the one
>>>> on the ML.
>>>
>>> I haven't been able to easily find a mail archive holding this patch.
>>
>> I 100% agree with Julien on all points in this thread.
>>
>> Please can we keep the Linux S-o-b.
>>
>> Note that S-o-b is not a chain of *approval* (whose relevance to us is
>> debateable) but but a chain of *custody and transmission* for
>> copyright/licence/gdpr purposes.  That latter chain is hightly
>> relevant to us.
>>
>> All such S-o-b should be retained.
>>
>> Of course if you got the patch somewhere other than the Linux commit,
>> then the chain of custody doesn't pass through the Linux commit.  But
>> in that case I expect you to be able to say where you got it.
> 
> I've submitted v2 with S-o-b restored as far as necessary to meet this
> requirement. I did not restore all of them, because I continue to not
> see the value of retaining them. You saying "is highly relevant to us"
> is a statement, but not an explanation of why tags beyond those in the
> original submissions need retaining.
> 
> Without me seeing the need / value, I'm afraid I see only two ways
> forward: Either things are acceptable as they are now (and will be for
> future similar imports), or it needs to be someone else to put time
> into spotting and then pulling in such changes.

I am a bit confused how this would require more time. They are already 
in the commit message from Linus's git and you have a correct commit id. 
So this is merely a copy/paste.

I am not going to ack it but I am also not going to Nack it if another 
maintainer agrees with your approach.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:29:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:29:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239124.414480 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzm-0005eO-7i; Mon, 06 Dec 2021 14:29:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239124.414480; Mon, 06 Dec 2021 14:29:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzm-0005d8-1a; Mon, 06 Dec 2021 14:29:34 +0000
Received: by outflank-mailman (input) for mailman id 239124;
 Mon, 06 Dec 2021 14:29:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muEzk-0005aS-UF
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:29:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed62540e-56a0-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:29:32 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id AF16C21B3F;
 Mon,  6 Dec 2021 14:29:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7EF0213C32;
 Mon,  6 Dec 2021 14:29:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id HcXAHUsermHAOwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 14:29:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed62540e-56a0-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638800971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=uCgiU0aiQotZBoCIqLTKFsblShz3FTd5ovsiFhY/JnQ=;
	b=TVTW2womoD5iGmE0XxpQy8fsjIKYxBIUc2ZHzwt3L3eGGUupohBYPTe7S8PdO6n0cMascB
	I11VnkMw4SeSU7dskBRYOvHJ0oN2UzoALL+fnF+9+PQzrBy54To0ldKfyW3rRN3gro4DtF
	pBye3dRymXw8fXjX9iW3x9RmYl/uXWE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 0/2] tools/helpers: PVH xenstore-stubdom console fixes
Date: Mon,  6 Dec 2021 15:29:27 +0100
Message-Id: <20211206142929.29105-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The console parameters for a PVH Xenstore-stubdom have been missing
or were just wrong.

Juergen Gross (2):
  tools/helpers: fix PVH xenstore-stubdom console parameters
  tools/helpers: set event channel for PVH xenstore-stubdom console

 tools/helpers/init-xenstore-domain.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:29:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:29:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239123.414474 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzl-0005au-Sy; Mon, 06 Dec 2021 14:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239123.414474; Mon, 06 Dec 2021 14:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzl-0005aj-Ot; Mon, 06 Dec 2021 14:29:33 +0000
Received: by outflank-mailman (input) for mailman id 239123;
 Mon, 06 Dec 2021 14:29:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muEzk-0005Zn-Qy
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:29:32 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ed6f0b53-56a0-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:29:32 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E36001FD34;
 Mon,  6 Dec 2021 14:29:31 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B5F9913C32;
 Mon,  6 Dec 2021 14:29:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iJfiKksermHAOwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 14:29:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed6f0b53-56a0-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638800971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nT3PojRsjaFLQH8p/xAS/Bo0Edytu7k5yswmTd3p+WU=;
	b=l/AVPQvCcOUNyZWRJHaL9WSGm7BqoSi1U3QcYqtENEdexWTxtvkGrsISDso9akMmqD1uPn
	fgqnDBzxPOM/frDFDx/yOV3tYPhPVbaRLTSe5gMhsWcVfP9l/S1Jod294ENh+5VOS1JSDh
	2wEy9V84fp0IoWopk3Cme8c1m3pYsLk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 1/2] tools/helpers: fix PVH xenstore-stubdom console parameters
Date: Mon,  6 Dec 2021 15:29:28 +0100
Message-Id: <20211206142929.29105-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206142929.29105-1-jgross@suse.com>
References: <20211206142929.29105-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When using a PVH mode xenstore-stubdom the frame number of the console
should be a PFN instead of a MFN.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
V2:
- rename variable (Andrew Cooper)
---
 tools/helpers/init-xenstore-domain.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index b205a79ee6..9457d0251b 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -30,7 +30,7 @@ static char *param;
 static char *name = "Xenstore";
 static int memory;
 static int maxmem;
-static xen_pfn_t console_mfn;
+static xen_pfn_t console_gfn;
 static xc_evtchn_port_or_error_t console_evtchn;
 
 static struct option options[] = {
@@ -283,7 +283,9 @@ static int build(xc_interface *xch)
     }
 
     rv = 0;
-    console_mfn = xc_dom_p2m(dom, dom->console_pfn);
+    console_gfn = (dom->container_type == XC_DOM_PV_CONTAINER)
+                  ? xc_dom_p2m(dom, dom->console_pfn)
+                  : dom->console_pfn;
 
 err:
     if ( dom )
@@ -528,7 +530,7 @@ int main(int argc, char** argv)
     do_xs_write_dir_node(xsh, fe_path, "tty", "");
     snprintf(buf, 16, "%d", console_evtchn);
     do_xs_write_dir_node(xsh, fe_path, "port", buf);
-    snprintf(buf, 16, "%ld", console_mfn);
+    snprintf(buf, 16, "%ld", console_gfn);
     do_xs_write_dir_node(xsh, fe_path, "ring-ref", buf);
     xs_close(xsh);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:29:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:29:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239125.414496 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzn-00065Y-DF; Mon, 06 Dec 2021 14:29:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239125.414496; Mon, 06 Dec 2021 14:29:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muEzn-00064y-8u; Mon, 06 Dec 2021 14:29:35 +0000
Received: by outflank-mailman (input) for mailman id 239125;
 Mon, 06 Dec 2021 14:29:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=9VqD=QX=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muEzl-0005aS-Nc
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:29:33 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed895e3e-56a0-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:29:32 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1A97321B3E;
 Mon,  6 Dec 2021 14:29:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E817313E13;
 Mon,  6 Dec 2021 14:29:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YF9ZN0sermHAOwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 06 Dec 2021 14:29:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed895e3e-56a0-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638800972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KQS0ebaKdMfO0vK1bTUVKAaK4Cn4ZEScp/e9jp/SwyM=;
	b=SwkCrBQE0avjcYDpBTC/+xzbPko1megwESbCugBUs0zMD7M9Jd9DZCTpp5wKyPPwb2cuz8
	UqvEBUOZ/09JSGyShdOX1HohRj8LCuRDZTk5Rac7UtvLag6ayT3cRg0B85RWB7SLBtE8a3
	KS+MI3+frpljL6uy/iNpZ9pRWHFqrWk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/2] tools/helpers: set event channel for PVH xenstore-stubdom console
Date: Mon,  6 Dec 2021 15:29:29 +0100
Message-Id: <20211206142929.29105-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211206142929.29105-1-jgross@suse.com>
References: <20211206142929.29105-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In contrast to the PFN of the console ring page the event channel of
the console isn't being set automatically by xc_dom_build_image().

Call xc_hvm_param_set() explicitly for that reason.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- new patch
---
 tools/helpers/init-xenstore-domain.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index 9457d0251b..3eff839827 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -249,6 +249,14 @@ static int build(xc_interface *xch)
             fprintf(stderr, "xc_domain_set_memory_map failed\n");
             goto err;
         }
+
+        rv = xc_hvm_param_set(xch, domid, HVM_PARAM_CONSOLE_EVTCHN,
+                              console_evtchn);
+        if ( rv )
+        {
+            fprintf(stderr, "xc_hvm_param_set failed\n");
+            goto err;
+        }
     }
     rv = xc_dom_build_image(dom);
     if ( rv )
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:31:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:31:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239138.414507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF1a-00086p-R2; Mon, 06 Dec 2021 14:31:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239138.414507; Mon, 06 Dec 2021 14:31:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF1a-00086i-Mz; Mon, 06 Dec 2021 14:31:26 +0000
Received: by outflank-mailman (input) for mailman id 239138;
 Mon, 06 Dec 2021 14:31:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muF1Z-00086N-C9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:31:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3011950b-56a1-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:31:24 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-vKjMIHPFNFOZNicTD4E6yA-1; Mon, 06 Dec 2021 15:31:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5469.eurprd04.prod.outlook.com (2603:10a6:803:cf::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:31:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:31:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::17) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.19 via Frontend Transport; Mon, 6 Dec 2021 14:31:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3011950b-56a1-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638801083;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3iuR0Zr9QGdCrW4Jn4AhEG3vUxn77hkSa8XImjiKQ+0=;
	b=Q/DA5Km4z7prTNv1oP8rZorD9rz7YrcFQLi9uj2WXiXAhhzbzJ0dkwy3/eTZaqBbPEXubW
	Lizc3UJ2S1uUpIu0071i2H8HX1ki5NPc7Qem7G3BxAd38/QAnxf3xseVvLeXY2HLBoD2jV
	oNu/XyzO9/HK/HBCiHY2I/LwvDi8BZs=
X-MC-Unique: vKjMIHPFNFOZNicTD4E6yA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MiysS4r+ig1Sa5w9nLkVA1NNj3B+DEpwxLKYCNPNrjOxdEexdKqIMA1ATIuBukLOPI5eSjgsgFoQsf5skOax+RYyVS1TQHhRILq0mayecu7At2/SRe7Vxjgh7p2n93r/2vn9vWlQfeTmz7ql1eTsKiAk0ric0+Z2w7F9xwgddiS+FFmhzleUnKi0yx30wKSCXJYLpGyG+Q3/Nn0UzQ8wLriXsZezRl5Y4CCQBMX1b1CTUh87O1SBf87gK5qzdACglFUqMUtdIpgj3cwB9X4WZJyjk/5Va1Q4Cyp91iy1sK0cvZ5mGVAdP1ksjWWpgqW7Fh3Aq1mAtFu6foJ98nLquw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fORdP+BzeerQGMsb/wiYQImQtw7HqY0znJ8TJp8Yr4M=;
 b=A60TpJxqwgFoB2nO2M8YZKXeHAkaMnwKxKO0GGkvN6DVH9wVbhnoi8aaNND5Ze3fEzZs4PhlkicwYfvwYjqJbG1jiFMGdzvCDKcSZSOM568eZUBj9ui2GI1/S+/wLGUVHUTYTUkxmo55pujwPt+LZjsOHuVA5FlTr6xd2/4nXJm/iVt4QQAE3Chl3yNBzYrby0SOI3edAeua/bSU9oC/AM6SbuAaeOP+1KPEOlzXLQPj35jqMGXmbaoVoYeY7AVgUw1COanXMsfKcU+VN0dVE8Y+EF5Kz6LjPYSPg+C2dGVf3gcvVlb6oK1smBG5Vhym1OHqyyoLyT8DTfedWh86Lw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21dc2bb1-4f8a-ac58-7573-4138969034a8@suse.com>
Date: Mon, 6 Dec 2021 15:31:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 02/12] libx86: introduce helper to fetch cpuid leaf
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-3-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-3-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P191CA0004.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8b::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9c130141-2eb4-42a5-dc0b-08d9b8c5125d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5469:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB54698CD059493AABFC94E5FFB36D9@VI1PR04MB5469.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3BrSNkK71+juYn4kt8F+71voEPdlAcD/QVw/hi9d8l9Vh4ohr4g/jb4bU/jo9fCLp5Xfdm4FmwaFsc+2L+vGt7faHvFoZ+QvrdYz3v3GAK4rguVrVYYmp6PqpWvNxz8eXwyDhKlEZVZmUJl3VBfaXVTJz5+uWr427XF1b6iL0van0hINkAJ8gMwX7AXjWOQVN86KI86swlAgmh6Fy2L1nx7K4r8asDCwQMt2amqCIZuzQB4FS/+3XT61ztiwmvAq3Ov4+f6c/ZpaN7gWckMn62d6aPi6YAbEeTsDB1dea9kdyHiThrru6FnSBGvaOpqYd8DHMkefdApIYRFnKivRm96rXqN7tyLttLkSKD8EzXBHP3Pq8veUifAdrjoNOcoJYsw43DH3G8LOROJFulKZljZ+7wNRjBIRwbmIpaynk1alE/dWguEIgyk2f8SuhEComxCKgwUwtaJgRc/hfbf5YCCYqXdRfysQk5LXDZpVzTYrqpNyDpUDYbtdx9Q6e8STRbaDA29qzfCbP/pAKucBJKV4hTaRfV1Dg3R4SKJvzTIAZL+n6vnrMmDQBxbU+nkPP/zP/m1L+mLymUxr7oOhXkR0U4rZ6/SGwL58ymC9TaMOxLnD7dNJ6u6nKfr9KYoFQolxx0RTQ8nhQWel6Ij3gyPgBL6l/WBp1q0BexzIpqnYsuqeekuGSkqblNjLzJjhmZrvlw3dhLCcH5W/xY36/v6My3ZuBjlZ14jZh1J0+ec=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(956004)(186003)(5660300002)(16576012)(8676002)(53546011)(26005)(6916009)(31696002)(36756003)(2616005)(4326008)(83380400001)(316002)(86362001)(31686004)(508600001)(6486002)(54906003)(8936002)(2906002)(66476007)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Vp6DFeBK2q0CDFrsvht7gLWMKDqBARCakhqQDVDchAwc3innA5/Oq9gdkxbq?=
 =?us-ascii?Q?K5rIZ6KJ9Sd65rZk1TBpjNODl6Mv48bYT4Zd1Zsylh7TBMAu6pKWsNmGRZ8S?=
 =?us-ascii?Q?Z31Eyqk/kFYj/jxT+WhilanAOIdBWomY7GV4FSjDRU/k+nWgr8pHsaZST/Wh?=
 =?us-ascii?Q?aOHFn5k66IZR4E4UMFkaij+ilRe+7Srrv95oUG19GynYnc0brL5KFBFPNYLf?=
 =?us-ascii?Q?UUrFpAZXI7m/HGWzLqM9jAijOlTubA7vU4kvyYMW+kbMdCJ94e9oqV+0o3jF?=
 =?us-ascii?Q?rUJErpdzm23+44JD4Ka//JKTbHMb6X51UQ6hjPtDl6mUqM9QT9FDb3tLdI70?=
 =?us-ascii?Q?KRHSeR3rCEHC9VXIlIdbtaRIBLFsiEsXeOz1H0SG1cuDNpzoVEzUGy1qW+h6?=
 =?us-ascii?Q?RcQmEA0hKgTMOJXoYJorGMyuPdy8r7J6OEEuMGa093MpUGxYEdZp1hxKD7ai?=
 =?us-ascii?Q?mOdCsNfK6q7rm3pwun6aY3OCVD+4YwdIfzJycHq6ZhA+EUEtondzhHQXYpk3?=
 =?us-ascii?Q?bpWvsIZTG9cOlNYKAVuKaXp1OU4v8VSbw0RRl4/QaorZZtXJur5CDzGBRFKN?=
 =?us-ascii?Q?pUDFG0sfy+dbPG1o1rLlA8u/IxWHBlx9ygUelwRTMs6cAOSPhWJs8v61rjdd?=
 =?us-ascii?Q?9gAvpx2CW4NddPGypxwXGpelH0nXWasHdX6Zgm7PukW4WxvrH9+Y/Mlu0nKN?=
 =?us-ascii?Q?71NMWrfMx0sc1PHkj6WqPp4Ynm+v3pz819euF0FbfsALWlD6QceecpZKliyu?=
 =?us-ascii?Q?PYRCrDyyNCo7R2PsLareyW0lQqEPpy/JZXDDOeSYH/BVi/uW/ojuiFpFG8Xw?=
 =?us-ascii?Q?Y1O1Ko4gVeAKdmYzY6MLNujT8XAKol+L4AZu6Kvdu19ig6KIaMqaiUKVagk4?=
 =?us-ascii?Q?1BKWIZr74Goeb+iH84MlA5XCSAglYQHou6RCGX3wkwetFYteSyb5t8KPlrTa?=
 =?us-ascii?Q?Vv25YG3diUXvw3tBbmjfX54ZnYK1XNOhylba/13Obat9Bk9TRdbqj43/K3S/?=
 =?us-ascii?Q?FyKul18Pwb+o9Jx1v9xO7ZroTCT0CGFT5GyGy93y1ZhDQp1x8SYYmLpw5dma?=
 =?us-ascii?Q?PDKzgE7qkWpvIf2MeNiz0JogaIKNB5X/X199lHoPiMjqGwPhAcVHk2DWzVZh?=
 =?us-ascii?Q?v4P94y6mUjSfhAZiguaMvQTsdRthoR0ggjdVaJV5q3e0h0witvkFyOnkeqiJ?=
 =?us-ascii?Q?J76jBxbC3l8sRHmJKUIrCfiESv/p7OeBcWoDXZc4jNdcI6vOJKGyWbfihSiT?=
 =?us-ascii?Q?HN6nZQHQkDBLbp2jaJ9TRiwoj3qw0+yW04Vf/lbE2UqYHSzfYR2D9Uxup754?=
 =?us-ascii?Q?w/XUKdeKovnr6Rh69Qim+Tx7GhCG4uuxK9MXwTvQDaPkUS7LJ0SmlG8NB4nl?=
 =?us-ascii?Q?RHqQVVQiG6AzV4wLXNTh1SZo4UTlbjXA2cRSkVPGkYjSOIgGDf/sxSF5FkEC?=
 =?us-ascii?Q?zIAa0VcXYnOQU2b9+YMfLbsx5dobJsV8cgZhAu1g8zVnxhwtwE42QgBjQ1O5?=
 =?us-ascii?Q?n2xl3UlRAPStPlEek2UHrxvVhEoGORiK5FiP02sEYTh3tubXbRPgrccn2fRF?=
 =?us-ascii?Q?Atye1F/Ad0TIYLuEX2kzXalekD89m2uAo6C+7nFqr7idZWmiPjXvJj84vF5h?=
 =?us-ascii?Q?EX3Zgt9YWuvT5WNjhqJJu3g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c130141-2eb4-42a5-dc0b-08d9b8c5125d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:31:20.7673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 64qs1zXK/sKKaJejksJKjJtKz2IzxDgNvDTmFDt5+S9q8TBC/H4XUo1r5e3Ltk1m6PxhuyPj8GoETIZTYT32rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5469

On 29.11.2021 16:33, Roger Pau Monne wrote:
> Introduce a helper based on the current Xen guest_cpuid code in order
> to fetch a cpuid leaf from a policy. The newly introduced function in
> cpuid.c should not be directly called and instead the provided
> x86_cpuid_get_leaf macro should be used that will properly deal with
> const and non-const inputs.
>=20
> Also add a test to check that the introduced helper doesn't go over
> the bounds of the policy.
>=20
> Note the code in x86_cpuid_copy_from_buffer is not switched to use the
> new function because of the boundary checks against the max fields of
> the policy, which might not be properly set at the point where
> x86_cpuid_copy_from_buffer get called, for example when filling an
> empty policy from scratch.
>=20
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> ---
> Regarding safety of the usage of array_access_nospec to obtain a
> pointer to an element of an array, there are already other instances
> of this usage, for example in viridian_time_wrmsr, so I would assume
> this is fine.

I wonder what it is that you think one might be concerned about. Such
pointer retrieval is no different from an actual array access imo.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:34:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:34:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239143.414518 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF4T-0000Jx-9C; Mon, 06 Dec 2021 14:34:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239143.414518; Mon, 06 Dec 2021 14:34:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF4T-0000Jp-6A; Mon, 06 Dec 2021 14:34:25 +0000
Received: by outflank-mailman (input) for mailman id 239143;
 Mon, 06 Dec 2021 14:34:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muF4S-0000Jh-Ah
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:34:24 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b0959af-56a1-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 15:34:23 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-pNUOgj--NyGazL-3bkn5XQ-1; Mon, 06 Dec 2021 15:34:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Mon, 6 Dec
 2021 14:34:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:34:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0017.eurprd02.prod.outlook.com (2603:10a6:20b:100::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Mon, 6 Dec 2021 14:34:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b0959af-56a1-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638801263;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DDU6h2HZbLdF/32bzQjhs6Ad2vWnmia5jq3SOr8EQGw=;
	b=DpBixOMZAjbBcNe1RkIaGnptvp6zQMFbGk909zVI8Q/N4r5zHmxxNWcS63W4hXTP/C2wFk
	aITp6quX6moCAkbLW/Q3cwvuyN+k0TCebj1WqmP41auNzjono9NPAW/kGVY2Cs+H0AFg6T
	D37E4H9RTNBs4Ho+ejdUYv/+XINHrG0=
X-MC-Unique: pNUOgj--NyGazL-3bkn5XQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Q4AZKy15E+JiLI6bjJBPEyIeipuVUsbRS8zKZsylDOI8iZoJ2GlN5GR38hhF/yDFTca0K0/B4I4CIiElPWrou24BD+R+xPmKeMwgX12MyBYQnw5bCJbKne8YYntBgtFfL50UPmUBXPjHn32Y5jDQPFrlLpOz1RweJzQnDlS6tXW5B5I+L5hLuCwA3foi/XSoVbdFARTUoF+2mtpwKQglgDlzE+CN+cFrFK7jdgPlQhpejVs2B+soS600axhqaXJqIXpjsgLC4M/f4K+Vdsn+yJtNSYNgmlMYzNwb6aLcYo5jFjNVupi/Fl13q3lNFGK9Mz4z0n7GjYxLvLDDqX8lHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DDU6h2HZbLdF/32bzQjhs6Ad2vWnmia5jq3SOr8EQGw=;
 b=hckkX4bAmAzgv1kBjH1OvN0AIa0YwZ1o8L1wFpBYjV1Xsq/DRmIcvsc8ZOoD4iEoKMpyT/7fIkK/xvV77VCftOH0CvIrISqnokqnE9fDE73+6yajU+YEwU5zx8FsjRGOH6A23A+qwiruymLfSvO+RYRwSBecDjXhohjpKyCa6QQuTjPh9H0yq5qYF2aqq4ai13XLMMrOKGQ2VoxxYv7NusxjrNssUrYMC7tOBPRLgSEeyGc0Cw9Lddw0FdSe9P/A6L2s5dxn5i9pDvtcAX2bb8lrzsSg2HhXw9Dwlc0McIU4Sgtk+UhpYPSLQDIKV7dHXOQcxZ4Iwj7QUDLGl05mwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <545f5185-9cd0-63cb-3519-470d587e12ea@suse.com>
Date: Mon, 6 Dec 2021 15:34:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 04/12] libx86: introduce helper to fetch msr entry
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-5-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-5-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0017.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: daacca21-a662-45a2-b6da-08d9b8c57d7a
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB24484097ED49FA24D11B3764B36D9@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3968;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	9dnt4JdDPs9cbTNdcXk9/o1wWqC0PF2o3In5YDpkHJj5nFn2HkR3qENXMnAg65m7YNFjX2vscte5nOfisP/vqxOloMWU81gkfqbPV8igPA46baiIQq2q+XTv4jTfN/6psSxA6uuBZo6BelAsvvtx+7SJohZEy9L2DmHSDm5pI+uwzoTxZf/1CBf7xb9X84a2nbDxUlcEaj4eNhPg4jVJV4y+SCqqh7JPPou9q2IvxlYdVP2a4fqOYvWgrfYS/6MBRprbE/mvc7CYZuwda0Ze5c1l3IxfWOi+ckpB3+d32c+tywnEXQwxskl0ZzT6S3ZEMMqnEbakvGhdghAp22wfQupeQ9uQFi7YZhDntcxMNv5H4JYGxGN7x1Kpid/haygoCbzZminzpU0XwdKEXWEGIT4Nh1EWdH/GICFWmVgALbbP7eUPmxF5PJ2qAYPJhmJxeYfOe/JLLqtPpsRNJOVWgq4c8FQccSMwF2xZSlk6oVjnG7mvK7TSiQEnAq7HexXvwhWgoym3f1t5QhiMUDCUp0aDIf0yHSTFMlV9aD7k/dInAbGpn+pe2r5NOJgbTMHUlwNAqXQ0kRLbyagNp+QD1pAtvzWYr3k7TVyP+Z1CCGYusl9K2IEVL5S5XMyzY9z74i75zG5XwfRBGiL9Gkqd4WvGSOiGJaKmCVkfetJT4sy1quOGcte5dKK4NQ6mVP4YkwuO7WGQzOmW6VBdBowCm2TLPptJrflfxD2tPM9yl84=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(5660300002)(6916009)(4744005)(8936002)(66946007)(53546011)(8676002)(956004)(2616005)(66556008)(66476007)(26005)(6486002)(36756003)(508600001)(31696002)(316002)(16576012)(54906003)(4326008)(186003)(2906002)(83380400001)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U2JZUlQxOUV6ekRCa1MyeDllaTBYU3VYWXhzTG5yL09jWG5WY2FtTnM5cVI5?=
 =?utf-8?B?cWFmMUF6UGY4ZG90Q01lTG5DYjh1V25JNmd0bituWFBoeHdOa0k0aVM4c0hM?=
 =?utf-8?B?M0RTZEdZaC83Nld2T1M0eWJCa05WcDJrQVFucFhPd2lsdjh1L2dBOGZhdWov?=
 =?utf-8?B?cVBDTU9NTW11Q3JiZjRCZkR1ZDE4U1lxd0l5TE9maHRZOGNnZ21nN0RmM0Fs?=
 =?utf-8?B?YkFiVUxQaTBmN2VKb0lvQkFSVmlORHVFcUpwcFE3aXRteUMvRGQrelZQQUM2?=
 =?utf-8?B?ZTRXaHVhMVBNWlhyZzZOY0ltQ2c0aXN4RmZpTkNlTTcyem9lTjJiUk13cXNx?=
 =?utf-8?B?MXh6UVRiREVRL3FzU0ZKcUNRdWtWR3ltdHhOcXdtZU4vaEt4RmlxaUtMcjh0?=
 =?utf-8?B?SFNaOGJzVkloNzZKK2FjRVdXQ1V2anVQVlBUOXIvN3NkS2llb0lncmc5aTUv?=
 =?utf-8?B?QklvMGc0L2pvWHJZVVN1RTVSdGxad29nOTd2MHNReFFoMDlVM1U0cmRDNXht?=
 =?utf-8?B?VE1lMkNiVVdSbjJWWEVkU1o5cU1IOEhzVlI2dzg1NlZ1Z0s1MUJ2aGVFNnc0?=
 =?utf-8?B?dlcva1BZNWQ4cmJkUVQySjNycTY0RC9FZlFqTUc4b0EvdzRHY0d5ZHY3QzQx?=
 =?utf-8?B?THRDUENPc0JEWUpCZnl3OVI2R3huQlQ3WGRlakRQMk9jZU00YTRIbGhUd0I3?=
 =?utf-8?B?NGYvdWZ3N0paT1N4VEVWdXlWYTVGb0dkU1lHTmI5cmwyeVdtT1krVUlIMWdR?=
 =?utf-8?B?RE1BMTVWVzEwYWVMZmdFdm8zcDd5Rjdzc01xUGJsRnVQZUo3V240VU5aVHRS?=
 =?utf-8?B?SVZ4WUdvc1RuRUZFelMvdmUvQ0V1TC9od0MyTXN0VmNIWVArMHIwYlFKVFJK?=
 =?utf-8?B?THA2TzltekVJTXV2NGF1Uk42R2RVS1M0Yy9abzJ6K1Q1UzRjbWFreC94V21B?=
 =?utf-8?B?b3F2K3h6eTJFR3N2cys5Q3JpeDZCbHhSbVIyN3o5QTFWTjhERXhxOHZlMTg2?=
 =?utf-8?B?ZE1PNDNzak1VbHlGaElVVmxzb2FWM3dySnBWeFA0OVora1luSjF5bFRXYkdL?=
 =?utf-8?B?aDNTYzdWUnp1T2VSY0dpU29GNVJ1V1BTOUpPS2tMYkJuZWoxUWNZTHJrckE4?=
 =?utf-8?B?VnZodlR3WGVjSlIzSEtjTVRlRTdnZEdIV1ZlQzdZWGEvK3ZCY3NYQjFJU1U4?=
 =?utf-8?B?c3FZWnV6WG8yVDBkMDJNUXdjUGVHU1FSYU9YN2xkSnVZTm1KVW9WU3FFck1l?=
 =?utf-8?B?RGNicFhLZnFVUTZSUHVhWkZOSGZGcW95QkdIL0xkZk02ZWc0VFlIOWhZMkg1?=
 =?utf-8?B?Rk51SjlEM0xydU94SUExZjFybi9CMmVxQTlaMGsxTXhGN3VDMUpDU1VrMzdI?=
 =?utf-8?B?NmpGMkQycDlLOXBhL2RRMFVlMzN1cUdjbDZNeWFiV2RpNnFleVUzWmJISS9P?=
 =?utf-8?B?TEZGMzNpQTdhOXEvWnh6YUJNY0E1TTdaejV5WGZaK3hXWUFyN0lwYjY0ZDBz?=
 =?utf-8?B?U0EwTGpKbisrQjlxaURKN2FGd28yNjh5T252MzYvS2xjMlFMYUN4c3ZaZS9J?=
 =?utf-8?B?a0o5d0p3WjFOMTRiWEdkTjJYWWRKTTlSOHFWR2dyanhpNlBmOGpLQXIxelI1?=
 =?utf-8?B?T2tFYzZkd0p2UUlXMlR3d2dJNHA1QkQ3ME52QkgycFJIQm1rYVNUV05GbGFU?=
 =?utf-8?B?N3Z4NEsyemVXZS93WUZBeHErUWJFVHV1RThvbGFvd3dpWUV6Y0V5L01DR3Z0?=
 =?utf-8?B?b1hyMkI4VjZVNTJ3RzcrVVNLd2lqVysxR3FWNjZFN1duYlgyN0R2NVVhMVl1?=
 =?utf-8?B?U09jODFLNzJzRUZ5U0Y5RVVCb1htaGNMRHFTY0ttWm9DdWhLREFRdzhFekQy?=
 =?utf-8?B?blFkWXk2UVJzaXBMYnJ3ZzZ0R0JjTTRGUkpuZ3BIMkxuNVZYYTZyMWgyOVVN?=
 =?utf-8?B?dml2YUxoZVZIMndrL1dEaHdrWDZYNms4djQ1VTJWeFBUSEFuRjdtN0FTL2FX?=
 =?utf-8?B?UHRRbENZTml0aW9rQWQxaFdLNXhlTEJORjRUajE4Njlmbmt0NGVqczdjeUw0?=
 =?utf-8?B?ckx3d29abmVMSFNIeGg1Q2drVEJEOTZMeTI2Zk93YkFUK2JVWmo1OWttVmdh?=
 =?utf-8?B?M3k2blRId2Rydmk0cDFKd0o5MUsrWi9NeHlBZU9VQ2VvUGVJK1JvRitCZ3Ry?=
 =?utf-8?Q?Ir7u5Wz5qLbo6jikGMzP9Qw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: daacca21-a662-45a2-b6da-08d9b8c57d7a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:34:20.4457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RwVoEPIW4eVxlgpCtQSWp+CWZ0wioh2bh2tz0UjrYy7JyrBAvzcmgt955dqWWPAxlDpgcSCCuJRQjT7Drqpw+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 29.11.2021 16:33, Roger Pau Monne wrote:
> --- a/tools/tests/cpu-policy/test-cpu-policy.c
> +++ b/tools/tests/cpu-policy/test-cpu-policy.c
> @@ -386,16 +386,6 @@ static void test_msr_deserialise_failure(void)
>              .msr = { .idx = 0xce, .flags = 1 },
>              .rc = -EINVAL,
>          },
> -        {
> -            .name = "truncated val",
> -            .msr = { .idx = 0xce, .val = ~0ull },
> -            .rc = -EOVERFLOW,
> -        },
> -        {
> -            .name = "truncated val",
> -            .msr = { .idx = 0x10a, .val = ~0ull },
> -            .rc = -EOVERFLOW,
> -        },
>      };

Why is this removal necessary? I don't think any of the additions further
down actually replaces these.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:39:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:39:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239161.414528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF9C-0001JP-W9; Mon, 06 Dec 2021 14:39:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239161.414528; Mon, 06 Dec 2021 14:39:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF9C-0001JI-Sq; Mon, 06 Dec 2021 14:39:18 +0000
Received: by outflank-mailman (input) for mailman id 239161;
 Mon, 06 Dec 2021 14:39:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muF9B-0001J6-B8
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:39:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muF9B-0007Uc-9Y
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:39:17 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muF9B-0005GI-8X
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:39:17 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muF97-0000dr-H1; Mon, 06 Dec 2021 14:39:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:Cc:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=EzADy5cG4yhRyR428zJIdhFwA6YiEfSnkAOMkAe5B4U=; b=1GJ7qqYM82UB5xIu9oo4K43AbL
	9Kz+0N6cBPCiK/j7kuLb48fGitQ+pJ4x2xBNAkKvBL1LhGP2EuC8v2JBNc13M4jVGN1gOPyCUA32a
	GNtM+qe8fHYyU7+vSU9YWO36WgivlvfMZ4XX+dMZJ8H+OffMeGMG35H5nKZ6NJ5Wcfk0=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25006.8329.278548.571087@mariner.uk.xensource.com>
Date: Mon, 6 Dec 2021 14:39:05 +0000
To: xen-devel@lists.xenproject.org,
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>
Subject: [PATCH] MAINTAINERS: Resign from my maintainership roles

I am leaving Citrix to go and work for the Tor Project.  My last day
working full-time on Xen will be the 15th of December.  While I won't
be disappearing entirely, I won't have time to do patch review, and
no-one should be waiting for my ack.

Thanks to everyone for your support over the years.  I have really
appreciated working with such good co-maintainers and colleagues.

Thanks,
Ian.

>From 608531a0cc34a5bc096ccf585e16f182b5ed83e1 Mon Sep 17 00:00:00 2001
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wl@xen.org>
Date: Mon, 6 Dec 2021 14:34:20 +0000
Subject: [PATCH] MAINTAINERS: Resign from my maintainership roles

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
 MAINTAINERS | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 136f51ad5c..e43dc0edce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -256,7 +256,6 @@ S:	Supported
 F:	xen/drivers/passthrough/arm/smmu-v3.c
 
 Change Log
-M:	Ian Jackson <iwj@xenproject.org>
 R:	Community Manager <community.manager@xenproject.org>
 S:	Maintained
 F:	CHANGELOG.md
@@ -375,7 +374,6 @@ F:	xen/arch/x86/machine_kexec.c
 F:	xen/arch/x86/x86_64/kexec_reloc.S
 
 LIBS
-M:	Ian Jackson <iwj@xenproject.org>
 M:	Wei Liu <wl@xen.org>
 R:	Juergen Gross <jgross@suse.com>
 S:	Supported
@@ -396,7 +394,6 @@ F:	tools/include/xentoollog.h
 F:	tools/libs/
 
 LIBXENLIGHT
-M:	Ian Jackson <iwj@xenproject.org>
 M:	Wei Liu <wl@xen.org>
 M:	Anthony PERARD <anthony.perard@citrix.com>
 S:	Supported
@@ -458,7 +455,6 @@ S:	Supported
 F:	tools/python
 
 QEMU-DM
-M:	Ian Jackson <iwj@xenproject.org>
 S:	Supported
 T:	git https://xenbits.xenproject.org/git-http/qemu-xen-traditional.git
 
@@ -517,7 +513,6 @@ F:	xen/arch/arm/tee/
 F:	xen/include/asm-arm/tee
 
 TOOLSTACK
-M:	Ian Jackson <iwj@xenproject.org>
 M:	Wei Liu <wl@xen.org>
 S:	Supported
 F:	autogen.sh
@@ -639,7 +634,6 @@ F:	xen/include/asm-x86/guest/hyperv-tlfs.h
 F:	xen/include/asm-x86/hvm/viridian.h
 
 XENSTORE
-M:	Ian Jackson <iwj@xenproject.org>
 M:	Wei Liu <wl@xen.org>
 M:	Juergen Gross <jgross@suse.com>
 R:	Julien Grall <julien@xen.org>
@@ -665,7 +659,6 @@ F:	docs/misc/xsm-flask.txt
 THE REST
 M:	Andrew Cooper <andrew.cooper3@citrix.com>
 M:	George Dunlap <george.dunlap@citrix.com>
-M:	Ian Jackson <iwj@xenproject.org>
 M:	Jan Beulich <jbeulich@suse.com>
 M:	Julien Grall <julien@xen.org>
 M:	Stefano Stabellini <sstabellini@kernel.org>
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:39:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:39:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239162.414540 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF9E-0001Z6-8R; Mon, 06 Dec 2021 14:39:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239162.414540; Mon, 06 Dec 2021 14:39:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muF9E-0001Yz-3y; Mon, 06 Dec 2021 14:39:20 +0000
Received: by outflank-mailman (input) for mailman id 239162;
 Mon, 06 Dec 2021 14:39:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muF9C-0001JC-MO
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:39:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muF9C-0007Ug-Bl; Mon, 06 Dec 2021 14:39:18 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muF9C-0005GA-6H; Mon, 06 Dec 2021 14:39:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4VwpTfZamIt2RpE5WV0n6aJNbr+/ynJ/bABg4AUcSIk=; b=Od6328SSFKyVDWcSbRidcuohRH
	6T/BYkD1kssbzdwP9m/IbaOM85Sehj7tpo1tTFoAyArPohnoQzRt125QSrvQT5eHCRuj7R0Szm1T7
	mFPCYljLuAxq/SXbaCy1neCk1SdpU9ICJrMvLS6H/uSzUUrzSW5YHMCX5iJ5nz9nGeZ8=;
Message-ID: <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
Date: Mon, 6 Dec 2021 14:39:16 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Do not include in the image functions...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206141923.26757-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211206141923.26757-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 06/12/2021 14:19, Michal Orzel wrote:
> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
> CONFIG_NEW_VGIC is not set.
> 
> enter_hypervisor_from_guest is protecting calls to these functions
> with CONFIG_NEW_VGIC but their definitions and declarations are not > protected. This means that we are including them in the image even
> though we are not making use of them. Fix that.

While I agree, they are only used by the new vGIC, the implementation of 
the functions are not. So I don't think they should be protected by 
CONFIG_NEW_VGIC.

Actually, I am not convinced they should be protected. But I guess you 
did that for a reason. Would you be able to clarify what is your reason?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:46:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:46:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239171.414550 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFFc-0003Hm-Uu; Mon, 06 Dec 2021 14:45:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239171.414550; Mon, 06 Dec 2021 14:45:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFFc-0003Hf-Rz; Mon, 06 Dec 2021 14:45:56 +0000
Received: by outflank-mailman (input) for mailman id 239171;
 Mon, 06 Dec 2021 14:45:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFFc-0003HZ-0I
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:45:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3728bb59-56a3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:45:54 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-TKhwINvUOyCfvgxSeO4MOw-1; Mon, 06 Dec 2021 15:45:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 14:45:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:45:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0097.eurprd04.prod.outlook.com (2603:10a6:20b:31e::12) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Mon, 6 Dec 2021 14:45:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3728bb59-56a3-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638801954;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3W/txn/hWiilUjdldPJb2V129+5aZT5R3XJ2wEN0+gw=;
	b=ZvCFpOBHIM+9EWVk7e3pQhT+i17VYJHkuygeTrZIZKIBHt31GvKXQJEDyBiNqYvJMY2Qd+
	z1hEsfIqETAJA5ZZ3TWGWgPn7Jk9/UAUBTYWgPtm4dSeCTdwdzl+4arTXiQXS/gPXtHzQB
	LSFZ+WFUsHw4ZShtDsKu8VwjzhorPwQ=
X-MC-Unique: TKhwINvUOyCfvgxSeO4MOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hAKee9lki7UmMZIGbVrVMkbEj+ybYaLxZ9u6RqdmtlCS3+SlQvFJfjh/0ZtgO6kbrLiyHLHL5c7NuIP4EO5zKq+zrUBJI0XCadbdSVDCexH8CE2G5UHzN2TR5iCar8JHSlGyG/jmeW6Kn9N+B6R5H0hMVBnLlcQ49S4wsBUAgDi/L8FOD22aMBtZ+Bp1EE+EqB6zdDIxYFBBiwgHJQG8vE/kPuG08bmMth+i6y1JhSbzPG5sRYM862A/Lm8/4hkixeSYzn3nH99I3u8BYP+6i7ogFA7qf9hmRtj2ZuHMVoKXpOzE9tctJ93/m6no4cxdkPbzADCj7taJ3Ks7ke31IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3W/txn/hWiilUjdldPJb2V129+5aZT5R3XJ2wEN0+gw=;
 b=fiNevMrajgFj7YLxe6pvHkWmWWgpGshh9zMPAb4pueKP24mSg5CQwN4z5IrRO4q6vMQlWrfvDz+aVGjgznW3/8uq3bWqsu5hanqrvXzh9BZCV7YFKbn8U977E82O0b+Q2xvex/eS/NjjhHnCpPhHDU33mZ3T6+9gzeWp+Q7sJtdD7EfX7yPnBk/OBHkw2SHPnDWvj54uhJHUGTWGDGkShiowghDOxj5SF5zToE37eGr+RRDnAs2+ctViYMbBU0DYIDtnjaz2KfUq3y8E4N2M6/hwxqHmzLkasnexbOdY1ppiiG3S3G0zYpFM12BqJFvUhOKL6qSErmW5aK3YBimtyw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3d46117a-972f-e341-94a0-0393d47c046f@suse.com>
Date: Mon, 6 Dec 2021 15:45:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211206142032.27536-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0097.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf29676a-1fde-471d-a2fc-08d9b8c7192e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2829F9C404C52AC3A75B473DB36D9@VI1PR0402MB2829.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Fk3Rw1Qi+V5rr2YJne/jyr/eR2bnIcvSEa30lIP4C/Ww33B3ehLjDizTT/wk/Pu44v02qY74yjxn70XUylRhf4ZsX0TwGOuFywa83PmkOllpOPtMcvkNeaBS43X4hTCCr8fCzM/9is04jAiWWeP/NNewwsLpPA34iKJIFgPVot4ee8DT6o/Z1WZ+Zdu0H7DdhTCX6hanmCDpn9OxVKWfiHK/I9R5C0eEpOR5DJFLnx1HbL/j5hgCf/Cgbbuk1U1FxGVEbQrLniofpB0dzH2KBarjFzrE3g0X8SoO6vPs/hPRLtjIDxY6BjcmHm8Rn7QM62Ai4QuVD2pfdQn0ndqkrqWecQxDGu3hJAH+wVIP1nEnXimgfrtR8WO5Rx5h7jF9a7D7ct55XU/Sjswfhln/yxSOrrXlg3F7vNCOy0fwkxAiu2C2hr+cyFLES0jfj6JfVIQ3G4IFgooe68BZiCQRtce5A9KneDlUg46SKopqM3NpDdHTVNtVf8xWfVVe0ALsmsoffAa0XyGc8m5HN/a4ew05CG2lj++mzOBj70tIqO1oYi4fq2CTkNnkPibgGei6OWrMvGduwHyzFs3AKDxaunFHwZQaXvHf3JC2KWSPAqchSDNGW7lTGjsFn4BcoVpYIFLIIxcRJ79Rts4r5GpCmRUKtuv9WcSGkvx5xFb9qqY+bmHNGnn1rPWF/P0eJVT5pHDW7GqjO4sXscVITPaztoRrWNYdeDCCChz6QKNTFxc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4744005)(2616005)(956004)(8936002)(186003)(31686004)(8676002)(36756003)(6486002)(53546011)(316002)(6916009)(66476007)(5660300002)(86362001)(31696002)(2906002)(26005)(4326008)(66946007)(16576012)(54906003)(508600001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHF4MHRoSjlzYmZscTJTM2g5RC9FUDZabjhlOG9hdGNkbUFYaGFMVXhCcUVm?=
 =?utf-8?B?N3hyamJud3h4WExNQUZndGhWUUVJWFJTZGVsWFRrdWV3SXRLbEdERWhmVTVq?=
 =?utf-8?B?dy9OM2RQd282ZzN5RTd3aEROQUZodVREWURCZVlvVVJHTHhYN3BZUENOdDhk?=
 =?utf-8?B?RkFDeHcvaTFUNFZPTzBMTUVyVUR1aHZrVDZJLytkWnpTT0VudHkxcWJlbEJ4?=
 =?utf-8?B?ZkpQdUdVaWROdFFrRzR1UVZYZXNWM3h3NXNJL1F0cnJ2bTJnZm5nZk9CK01t?=
 =?utf-8?B?ZnNSaVVpTTNPZzk0MXBGdjF1V3VUMEs3RE0zVFYzS3o2UHMwT2ZoQ3ZxY01Z?=
 =?utf-8?B?czMxcVJlTVlkYzFQUEg0RmdUemMwanBEbHRoOWwvSzZla1l0WFBmU2Z2V3h1?=
 =?utf-8?B?ZnlzTmZ5b1QwcDE4VHVlVnpWNVVwckVDMkFmTFlSSkVidmVnNCtsUk5hOFVz?=
 =?utf-8?B?RjVSWjBiL0Z1bWF5ZjdvOTJBbTlxc2t4dm0yR0kzeGVlZTlLcHU4WEJZaFRT?=
 =?utf-8?B?SGxQVE1WVXhiVEEraVUxeXF5NWZpdnRNQ3RsbG5OczY0WUxHeTgvaFQrKzhq?=
 =?utf-8?B?VlZjQVRXZ2ZLUUwrL1Q5R3QyRzV0Z0g0YnkxTXVETm9jUEZMNmY3SXlnV2Qr?=
 =?utf-8?B?UFZIMXZSSzdpNGxUZ0tDdWQyS0NvUFNUL2t1bTVteXgzS1k2YXNqRjU4MnRP?=
 =?utf-8?B?Wmt3cmJCTWZ4QUo5TDU2U0QrODgyT3h3dXNDSU5Vd1cwK2Y3Njd5aitZQmth?=
 =?utf-8?B?L2FlenZTK1dYMElDSG9FRkNoZTJBZWtaUWM0WjZMc1ZnWVgwQjZlaS9EUU03?=
 =?utf-8?B?YmRWbkV3Y1BlWERucUZMbEtiYzc3RDJJWVp5Q0pUWmhWZkJTQkZtVlFKajVU?=
 =?utf-8?B?d1ZLL010NE1MLzJkd2x2MHh6eGdlbHh4L0Z2em8wSUpXUG12Y1RtbllzMkdH?=
 =?utf-8?B?Tmx2ZEpvamRGNlJMcnN6RGY3dS9hVjdYRWJrK28xcWQ5Yi9MT2NTY0NISzRZ?=
 =?utf-8?B?aG1VOHlKNDFPQ3U0TCtQMGRHTTEwdHFqVHl3ajBGeHFndU9jL0tHbGpPUk5Q?=
 =?utf-8?B?ZjBJUGNiTWFGaGd5WG9GeS91OVNGcXlaL2FMWnpJSFMwS3duUFBKUUw2RUxN?=
 =?utf-8?B?Tm81bjhiTEl3aGJpa1l2T1c3aXhZZ1ZmYWVGRnZoUnB5bWE0ZkJ2Kyttcklq?=
 =?utf-8?B?L0owZXl0dS9kdXlYR3lrRytFN0YyY21UMm1NVktWOURNNWJycXBrOHRPSlkv?=
 =?utf-8?B?cjNCMjNEOFJIb09VeEdIUVlUMG5OcnhYUE1Fc0RmZ2N5NHhVTkZVN1g0SnpM?=
 =?utf-8?B?MjBGU3dqNy9CNVEyd2ZLZThONXNic2s1VE5TL2xDQWgraDhEYnlFY1lTd2xQ?=
 =?utf-8?B?bDg3ZnR1UkJtODdvb0JSdGt0NFJqU0cxakxZWlR0MXJPajVQQWtXYUxiY3J6?=
 =?utf-8?B?TWI1OHFNQlJXbTNONnUwTHhhRlBFVTBxU2Q0UWRhVHVGdTdPR1cvRmxjdHRr?=
 =?utf-8?B?QjZXVEFYRW9hZG12cVBnaUYxMlkyUk9FR3BSMjhCaUNtRXYxblJxQlZJbk55?=
 =?utf-8?B?ejJUczNiQWZBbk9hVXdISXVKcmh0ZnJ4RHNvU3YvY3VtMi9FUVNkMHNJbkpY?=
 =?utf-8?B?Q2E3WTJzRVZzVzlNYlpjaEtYbHoyL1dmc2RxUDI1V2xaSFZHNm53THIvTVd6?=
 =?utf-8?B?Mks3V3FmZE0wRTU1Mlg5cnZqTWJYaEJBTXZQZlc1dW1WZE5HTWVqSGVmTGxi?=
 =?utf-8?B?VVFpT2sxaFplQ25GcDFRTC9RUm82U1FNd0VLZEpwUEFsbnk5S1k4YUowYkFr?=
 =?utf-8?B?RWtyL2Z2cU5oTTNRd3lHdEJBc0I3VHVZQVRVNCsvQUFKRnNBbEFJWEN2UUVU?=
 =?utf-8?B?NENVaGhPK0hUUmY3K1lQbld2SmVzZ2R1cmYxWURZQlJNMTFXTHBFS2JIaDdO?=
 =?utf-8?B?alFjZ29vWkJQQVNDT1A4QnVNS3NyM0pwMVFUWkxLOFo5a2F3YXJ1QnNqRlRX?=
 =?utf-8?B?SXEzeE1MS3Q5ZzA2cGZqRUhZUmlocllGYktPenJ1OGc3aUhGeW41ZFlRVGo4?=
 =?utf-8?B?c3NVa0JHb29XekNSRTVNMTRXSHFXS0lvMHY1TG1PTzRmSVoxc0xtVzFrUlZu?=
 =?utf-8?B?R0hPR2RHYXJscFRwb29NdmRZN0xMZXZWUFBaQVhaamljNkRjaFhFcWo4Yy85?=
 =?utf-8?Q?DvvQl9D0TH9agMsVvGKu7GU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf29676a-1fde-471d-a2fc-08d9b8c7192e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:45:51.1624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1/nr4gEMV63Rn64vr6AX4uxbdP6TjFcF8S/PIUFliKWU4auyFo2rhcrlE1j1Me9D9bIBmy2TBx+LnMNFiRVdvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829

On 06.12.2021 15:20, Michal Orzel wrote:
> to hypervisor when switching to AArch32 state.

Do you perhaps mean "from AArch32 state" (also in further places below?
The 64-bit hypervisor runs in AArch64 state in all cases aiui.

> --- a/xen/arch/arm/arm64/entry.S
> +++ b/xen/arch/arm/arm64/entry.S
> @@ -109,8 +109,16 @@
>   * If 0, we rely on the on x0/x1 to have been saved at the correct
>   * position on the stack before.
>   */
> -        .macro  entry, hyp, compat, save_x0_x1=1
> +        .macro  entry, hyp, compat=0, save_x0_x1=1
>          sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
> +
> +        /* Zero the upper 32 bits of the registers when switching to AArch32 */
> +        .if \compat == 1      /* AArch32 mode */
> +        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
> +        mov w\nr, w\nr
> +        .endr
> +        .endif

Don't you at least want, perhaps even need to respect save_x0_x1 being
zero here?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:48:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:48:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239185.414562 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFIP-00047a-CP; Mon, 06 Dec 2021 14:48:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239185.414562; Mon, 06 Dec 2021 14:48:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFIP-00047T-9T; Mon, 06 Dec 2021 14:48:49 +0000
Received: by outflank-mailman (input) for mailman id 239185;
 Mon, 06 Dec 2021 14:48:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muFIO-000467-13
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:48:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muFIN-0007fS-Va
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:48:47 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muFIN-0005td-Ui
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:48:47 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muFIH-0000he-Ip; Mon, 06 Dec 2021 14:48:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=UW2k1BtVHnHqEg+VZyCrefmLxXbX7VEIKtelnPPraTo=; b=FdcPLk5stZRTlzf2v/pSm6T9T+
	f0eP9v0mhIQ2IEMRWBnEH6uE6QLjWeUDpwRTOSWDhH2My/OO5LPgYu8Gqt5Ct4jMwLidfY/JoOvQB
	zd2Q87IuLRlY1qLy1pqB1cTMnmSQBPpzZyh2Yk+jm1RgAMdvFZHOeNgjOpr5n/qMuWMw=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25006.8899.913446.519189@mariner.uk.xensource.com>
Date: Mon, 6 Dec 2021 14:48:35 +0000
To: xen-devel@lists.xenproject.org
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
    Anthony PERARD <anthony.perard@citrix.com>,
    Doug Goldstein <cardoe@cardoe.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Jan Beulich <jbeulich@suse.com>,
    Juergen Gross <jgross@suse.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>
Subject: [PATCH for-xen-stable] MAINTAINERS: Resign from my tools stable branch maintainership

As below.  CCing many people out of staging's MAINTAINERS entries for
bits of tools/.

I will be applying this shortly, to all stable trees, because I need
to do something about the just-released 4.16 tree and it will be
easier if I just make that like the others.

Note that my @citrix and @eu.citrix email was already wrong here, for
some time - Citrix corporate email was not working well, so I changed
my MAINTAINERS entries a year or two ago, but apparently I overlooked
it.

My iwj@xenproject mail will continue to work.

Ian.

>From c623a84c2a4fda1cd25f5347a6298706218eb5fb Mon Sep 17 00:00:00 2001
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Date: Mon, 6 Dec 2021 14:40:24 +0000
Subject: [PATCH for-xen-stable] MAINTAINERS: Resign from tools stable branch
 maintainership

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 85f660c30f..f4c08d0b19 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -60,7 +60,7 @@ The maintainer for this branch is:
 
 Tools backport requests should also be copied to:
 
-	Ian Jackson <Ian.Jackson@eu.citrix.com>
+	TODO - Loooking for new tools stable maintainer
 
 
 	Unstable Subsystem Maintainers
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 14:51:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 14:51:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239191.414573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFKh-0005X0-Pw; Mon, 06 Dec 2021 14:51:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239191.414573; Mon, 06 Dec 2021 14:51:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFKh-0005Wt-Mw; Mon, 06 Dec 2021 14:51:11 +0000
Received: by outflank-mailman (input) for mailman id 239191;
 Mon, 06 Dec 2021 14:51:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFKg-0005Wn-FI
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 14:51:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f20fdfb3-56a3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 15:51:08 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-5PamRZifPYea6fl1lP0ZJw-1; Mon, 06 Dec 2021 15:51:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 14:51:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 14:51:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0211.eurprd06.prod.outlook.com (2603:10a6:20b:45e::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend
 Transport; Mon, 6 Dec 2021 14:51:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f20fdfb3-56a3-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638802268;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aRrX5R8iqzxW+LDnFBZt/gF5dtxcJY7nJSkqCuYa0xg=;
	b=L5OtJu8Bj79p6tj4369H2qD0g408w5zMAz+wGSsXqcT06B9wXj8FYwdC/fI0Gw7qoslehV
	63ZN7d4y5QLfT2egNO8qq7uXnYCFxi8FaoICAY7MHumKEHv0V05U6HBxC5RIu0yxg1RBPr
	YDpg2BqKIbzlxn3VABgo1RUt8rr7hLo=
X-MC-Unique: 5PamRZifPYea6fl1lP0ZJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=euOMpTDWnMFNELBv8Hs7RJRlZrI0+8s9+LWnGKTzpI1jXjk6fPXhWiuiaQkYG2lr+op+ADei+FQeDooolKb5MFh7xla04dHFs3wsvRDS4SvSkalxpd50mfO8GNJNJgW7mfiU0VwfPjnJSxVklveqWyn8gz7d0h2nGnu0iSSjnjciAQU+VKh4cRct5UPHFZUQ/s/EnxowhLPK6qbn8ZlI0leCjHQhc9TaT3WUHfPoa8Z5a2x+EV2OV9dh0H9gl0DJ7tpebamG3jjT0TutqlZab2CJATgKIyDHPEwHrjbT6TbhsMncnhMCB8WD+3BmHS/h6Ld+jLyRY4QXFKKWvrkPQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aRrX5R8iqzxW+LDnFBZt/gF5dtxcJY7nJSkqCuYa0xg=;
 b=m0ne4NnElTkkIqD8jNhsIztcZmLiJmHBzG7y0DYsaVxh8fkKZ3Geerp7ljFPR2RMIy2e1bvwaeA8ZLfg2JUZt1X784TInNBQeXcZd6iZrYgUf46Tx+rjvfpczsm7Wn3UHStnKESGg+qxEV4Wa+iIvDU4K3/GxemO5xkKAutMhV1Ljb8bMaD5IW1Ee0lRJvoP2AkXG3Cv2exCD+0E8NO5afPQwn31pxK/pe9xs/xEuP3Bthnkz44MULMkeoY4o2ETv/Q+rxMOC1Yx9qm0Eii1Wnor1I9GwLx0lJS/nYUENuzqH7rxbaza/Sqdozg3ojUND+3I+iSwWoDvftHgJfQiyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9d6fd0d0-eee2-8f95-9c6a-7e9a0beb1a27@suse.com>
Date: Mon, 6 Dec 2021 15:51:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] MAINTAINERS: Resign from my maintainership roles
Content-Language: en-US
To: Ian Jackson <iwj@xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <25006.8329.278548.571087@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <25006.8329.278548.571087@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0211.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ce506ce1-be3e-4731-f26c-08d9b8c7d414
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7039481FD2909070D34CF4F8B36D9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HoY0Wm/UymnSQZsS9V/ZksNlD36itiBJPkhn+oG+eTt/eF7okOKrX/rWvi/5wEpvQ9Trvcjmg24tCNRt+Sl28rFI8RiM+TioOfAJIRRE34tLWLdfxyAP0iq831KvEU1OXlXnvoCCqv3uud4OYXtOlyginGRwtaIX03GhFBXS5RTROiuYVYLC04vz9ht5kK4SxgJUbodHqjgF9dykzN8NfsORIkQWErip7qcdRrYKvbKUsmFul3X6TuiYVEu7heVRc4Vtd7sEZy8szXrj3gMwmSnEEerZrsxbkBXVNLpPV/3UvwcUrlczh7DH93psFs5F6ZDVRsTjZFuOCKOTyVX7roVXIGJcp3i36X6cgoDZQsh9TNfAEpxLYTyaf3sYCyWTJDsbHT/UaDhfyQkPPdlTnOggOBWkEU5hmMo695MhUlu6rk/mMPKQU/e8IitjTbY2XijNxwViWgAYN/AMM45ZOA3I/wfVfAk15slkwSrQOsA7DysKQE3N5C/xYjffqw+R2ofVMoExpDAPIw4liICXT/9EuAspZJHpCvbLeeSFG4cPRAgWtSRPvp5hveF25dveS6BqAB/Mftdv+jv2OpzC9/d2x2X6M3msaN7pspK5QW9FHTL3KXCicSASNGI4Xf8Qe9dhc0yaXxfiitVTTppjnO7S83c4eduaVEJwmYWvQbPh5FZ7pmW6Sw0gl/0nG5XkN9xeGhTW+wQuazl6xQ+fTOT480dSyGag9CoD2RHm7Zg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(66476007)(66946007)(316002)(2906002)(508600001)(16576012)(8936002)(66556008)(86362001)(5660300002)(31686004)(26005)(6486002)(956004)(38100700002)(4326008)(2616005)(53546011)(31696002)(8676002)(36756003)(186003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MC9POURkTXJTbmwvczM5WU1jb1pQV0ZtYW9ibkFERkpxVzhnZkdJaWk2SitP?=
 =?utf-8?B?SDhRVGp5YXYyRkJURFppc2owRGU2VHBBd2daY2tzOVRjeHE1T09Cd0VOMWhL?=
 =?utf-8?B?NzBoeUNJdlNuU3Z2SHJ4Z2JLSnpyemtENTFxYU1seE9la2I3bUsxUm9UZUxv?=
 =?utf-8?B?WXNtNFZyUjJDR2krMlhvb1BmNExJc0FoTmgyRFRPRmtId0xxYWdqMlVSQm50?=
 =?utf-8?B?UzF5aWVQZnBkN1FLcnJ6Vkc4ejdLY0FNREpjNXFRRGZsWnpBa085WklSS3g4?=
 =?utf-8?B?WXB5bmxUMXhLeVExV1RrMWZZcTNCbGtwcjNxOFBCeEF0cVJBTVNDbzNIM2Qv?=
 =?utf-8?B?QldzZElmRFBieXVxTmwzOVJXUXRJVHB5cFNSVXh6Z3Z3bzRBT3lnSWNKczZ4?=
 =?utf-8?B?WTVPc3JQYlhma0hsTS9McEJLeERpZFhPcmpLVTFsSGIxcHhOMkdQVFhTbXND?=
 =?utf-8?B?NC9uVjQvL3FIYmdlWmxGQ1dtK2RHd1Z1OEtzQ2xFN01OeTRmSEQyYXo5bFBP?=
 =?utf-8?B?RHBWbC9ESDZnN1JoampYN0d4dzNwSnFYdFh4S3hJb3YxbDFzWGtxTHJqTzN0?=
 =?utf-8?B?bU1aWlU0Vy80S1FqL0FHQ0ovYWR5ZEhKbVR3WkVtODJiWVE5enAydS9ramNj?=
 =?utf-8?B?UHhPQ3E4Z0ZESk90b2VYcVBTeGg4aklDd3g1Q1N1ZDVXVE0rWnUvck1mbm1y?=
 =?utf-8?B?U0lxUHNrRkIrakM0eUNMVmFFdG9wVWVESnE1UUFSWldmdnNSQm9KQnR6UmJ6?=
 =?utf-8?B?UVNKcjhPN3cyZS9ISWlSYjVCUHNHOVlZM2MxbDJyQ2RnSTFzOVVFbzlCM3JT?=
 =?utf-8?B?dWhmWDY4ZDVVL2FLVlhzMXE2MmV1YmtGSytuOVpUS0x2TXlFVGI2OTh2RVpr?=
 =?utf-8?B?NUd1My8xaCsxQnlpYlcxeHVBOXdCQkNpVmdXMW5aQW0zeGFGWVhMZHI5dkR1?=
 =?utf-8?B?RTF0c3dFQkhaT3FUekE4eUdpczFMWUk2Zkk5eDdBMUlPQlhQU3pUQ2Z5RjRN?=
 =?utf-8?B?YkdTVDZNR2RlUDZPcGFjM0FUaHE5SkRPTDVRNzJZemQ1RmtmaGt2VHJpMFpL?=
 =?utf-8?B?RUxmUWFMZmZXR0pmWTlGdGNaL2g5bjBEUzZqSWVPNFZsMHhTL1YxS2ZldWNR?=
 =?utf-8?B?VzVndXNFU3hCMi9taUh2c1V4c3U2VlVxakNmUFZWVzMyS3VtUVpCdk1BQmFM?=
 =?utf-8?B?WTIxbjI4dG5NQlBxMDFNbU1MWEM2MnlnU2VjRHJFVTFXWEJkMzZSa0Q2Tk5q?=
 =?utf-8?B?M2syQ3lDTHkvSWU2dStjSEZTZGEybFp1WDdZS1RzS0trL3F1WFdLRllXK3FZ?=
 =?utf-8?B?RHM4b2QwNitrd0NlSjJIa3J2b1dQbE9FR2g3WU04dDlFcnJJNmdqUkIybFp3?=
 =?utf-8?B?SVFicUhPeW5GZGxoR2lpcTlpL3Iwc2JzZUJBRlgzNWE2bmJLNU1kdUVoYXd2?=
 =?utf-8?B?OHhCMzRJMnZ6SVF0bGpZYjUwbURwaUhqcVpWWHFIcUNhNzJDaDBtZWNsZDNt?=
 =?utf-8?B?ZWJGRFlCb05QalJkcDM2WUhjVGlReEdubi9TamxUUjFDQVVnNFdMZ0ovMDhC?=
 =?utf-8?B?bmtvNisyb3duMFVObUlKMnc3U2xDNjBxbFMwTHBpb1N6Qi9iVWliaUpPU2g0?=
 =?utf-8?B?K3VuLzByUjJvM3RhN2d0V3pxRnR0d2dMOURONm9uT3h3Y3VBMitUUkNlbTNp?=
 =?utf-8?B?QTBJMW5jRXd3M1MxcU9SR2RQSWFWaGhSSDI5UWErUEp0dDlRcG1sL1BpdUJw?=
 =?utf-8?B?ZGFvNEdiSmdVNE16OEZTSEhiSmxyUVpqclNJTjZnU2JSNWlBRndxNGZ1c1Y1?=
 =?utf-8?B?Nk0vdU5YcUo3WFBJcThVbmFUcGMreWU3dGEyVlA1RTBYWU5md2tyZVBaV2hP?=
 =?utf-8?B?aCt0THB3bXpFR3I3amkwRU11aWR1M0syZ1VBK21GN0xhQ0tZcjNPNG01NHZM?=
 =?utf-8?B?OWdhbERzN0lFcHFVS2JZeXZQWFUySVZjMXB5L1FKT2lZc0kvUmZxUFFDMThj?=
 =?utf-8?B?UmR6N2ZhcWF0aFZlcFYwVFltUDdSMmlGZjhxOWRsY2NXcWhKQTQ0ZU5jRTVi?=
 =?utf-8?B?QUVlS1hWRnE3QXo3czhkNkRTRjlIVnZwbndvWXJKZ2hQZ2h6UHZieUNoTDJ4?=
 =?utf-8?B?Tzg0NW5Ma0NETndUekp0ZHZSWElvWGROb0oybXJwZXlMUjkxM29DcmZyWCt6?=
 =?utf-8?Q?Rwr7zoVkAIMnaSa1aPa0TjU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce506ce1-be3e-4731-f26c-08d9b8c7d414
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 14:51:04.7160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DWOxTcmDCq5v6hIEtLPQ4g5Yu5kIS9tIfsONuDOuwkBK8+SYiEsQ3URgyPGQOZFqlLYSKIbvsO11DyqAwxba2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 06.12.2021 15:39, Ian Jackson wrote:
> I am leaving Citrix to go and work for the Tor Project.  My last day
> working full-time on Xen will be the 15th of December.  While I won't
> be disappearing entirely, I won't have time to do patch review, and
> no-one should be waiting for my ack.
> 
> Thanks to everyone for your support over the years.  I have really
> appreciated working with such good co-maintainers and colleagues.

Thank you very much as well for all you did for the project.

> From 608531a0cc34a5bc096ccf585e16f182b5ed83e1 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <iwj@xenproject.org>
> To: xen-devel@lists.xenproject.org
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Wei Liu <wl@xen.org>
> Date: Mon, 6 Dec 2021 14:34:20 +0000
> Subject: [PATCH] MAINTAINERS: Resign from my maintainership roles
> 
> Signed-off-by: Ian Jackson <iwj@xenproject.org>
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>

In case it's deemed needed, yet much to my regret,
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:01:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239199.414584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFUO-0007K8-Sv; Mon, 06 Dec 2021 15:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239199.414584; Mon, 06 Dec 2021 15:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFUO-0007K1-Px; Mon, 06 Dec 2021 15:01:12 +0000
Received: by outflank-mailman (input) for mailman id 239199;
 Mon, 06 Dec 2021 15:01:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w5uy=QX=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muFUM-0007Jv-P2
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:01:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 5629dce5-56a5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:01:05 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4DC701042;
 Mon,  6 Dec 2021 07:01:05 -0800 (PST)
Received: from [10.57.4.16] (unknown [10.57.4.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 493993F5A1;
 Mon,  6 Dec 2021 07:01:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5629dce5-56a5-11ec-8a4d-196798b21f7b
Subject: Re: [PATCH] xen/arm: Do not include in the image functions...
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206141923.26757-1-michal.orzel@arm.com>
 <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <e149b283-23bd-9d8f-4be4-4a26722f0ed6@arm.com>
Date: Mon, 6 Dec 2021 16:00:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 06.12.2021 15:39, Julien Grall wrote:
> Hi Michal,
> 
> On 06/12/2021 14:19, Michal Orzel wrote:
>> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
>> CONFIG_NEW_VGIC is not set.
>>
>> enter_hypervisor_from_guest is protecting calls to these functions
>> with CONFIG_NEW_VGIC but their definitions and declarations are not > protected. This means that we are including them in the image even
>> though we are not making use of them. Fix that.
> 
> While I agree, they are only used by the new vGIC, the implementation of the functions are not. So I don't think they should be protected by CONFIG_NEW_VGIC.
> 
> Actually, I am not convinced they should be protected. But I guess you did that for a reason. Would you be able to clarify what is your reason?
> 
>From what I know + what the commit introducing these fucntions states (b9db96f71a74), the current vGIC does not handle level-triggered vIRQs.
The functionality of these functions is only related to new VGIC implementation which can handle level triggered vIRQs.
So I do not think that these functions are generic and thus I believe they should be protected.
> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:06:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:06:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239206.414595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFZg-0007yu-HH; Mon, 06 Dec 2021 15:06:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239206.414595; Mon, 06 Dec 2021 15:06:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFZg-0007yn-Dt; Mon, 06 Dec 2021 15:06:40 +0000
Received: by outflank-mailman (input) for mailman id 239206;
 Mon, 06 Dec 2021 15:06:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFZf-0007yh-Cd
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:06:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c40170a-56a6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:06:38 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-DJWBKCHHMsanzmJlQdhJAQ-1; Mon, 06 Dec 2021 16:06:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 15:06:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 15:06:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:206:1::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Mon, 6 Dec 2021 15:06:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c40170a-56a6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638803197;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4+G1ETFJKAA319VUsgzTu4AQUFm6aAXLHCeMOry6wIk=;
	b=FoAkxpHXfl4ffR2bRYh9QzTQCrJiBWOUPmZ4tnZE4rxvN4mOUnaYMBxR55e9ZUbdml+QZd
	PSq+xfH7EVL+UhvHlzVzkkWM4CGWQ3koEGf2LHcjEvNmlh8lVGsg0qz59ZWEJY53i+Aj0H
	g+CKLG2cHU0EVHG32NP3nOVwlKfh1wM=
X-MC-Unique: DJWBKCHHMsanzmJlQdhJAQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=csB/0wyFwJfFAh+hw1HqOOC4GcfNILJe/TBM7QNjAm/ywuDw68oZyfPZhNYsoAOdhFoi1GvbVOGucfc8g+bSyX1tTn+WgYt8xD+e9Ugou10J90FH+84pV9QTb8cVzvGAbkAzgLvB/VKxCGZiO42t0q3LlyFbDI8vQ65gdKE1rPLAdCLDh0f8zFmfCibW2dGSajMXzvtPn5z4YjHeqcPbe4NrSTCAhn22b6q0+9NlL5lhQs46oAYGeZ74+bj5oSjgnaEcGjZFszU0PwSBJknQNJhubRB2tNhEJxc/6qIniuLAXNj3Q2G1sHl5jA2IG4eSRblei9NwjWHCA8YqHYwQrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4+G1ETFJKAA319VUsgzTu4AQUFm6aAXLHCeMOry6wIk=;
 b=VkeK8vkXXcYQXV9ctwYIZELKH+KG9UH0G7mydL2r7uBrS4qkC+PGxTOzVA46oYdR16vA50PCJZG63szpZPeYwgeJgZezhJNiPVsa6hM+F3I36tZssBvmUg5XUzVjKCaZk1dXLkjPbKHvz70alvCKPuF1ZdSatk/KSkFsEgrd+zuQ0mPlhebVaibk2WoS/pcyDkN61KC3Jhs8xKIIzbdwuKjLvuWSZkJkyXqXxZKb57CzsrkkWRwpEBDFEHGmUNbiiDyt2K6lfh504Wx9ZgaeyAqs3g2FywgtBq1fndVQmnn9q5mEnj0DOIPq+42ncyNBvJ8kfxJugvXFlYxhvdW5Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
Date: Mon, 6 Dec 2021 16:06:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0011.eurprd04.prod.outlook.com
 (2603:10a6:206:1::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd686d5d-fcb0-4a2e-753c-08d9b8c9fec4
X-MS-TrafficTypeDiagnostic: VI1PR04MB5903:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB59031E3EB1D046110874B85EB36D9@VI1PR04MB5903.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2Rwi92TpZjOlP0ccDt2H4lxzyBGrniFqZVJU9WPVUP/7v8MIPhKJJz1ixK9K94McF9BLKfjD7u5ihyxye2BpSYx2kOiFim4jiih+Ik6PIj4Bm8iWAJGueLcUvIPwP4KY9mHYFfWAIkHiR2SAWBsW1KIaYSn2kXfrZS2KkCGsOufuJ8EvrizThrVAuNcpVKM9KpineQiujtei3oXP01+nUwEuOYAcNSMjYJPJB/qUoU0tWydPIXiKHrYwgMaFB85v04A0NUoClMUzS6Yxas6IXuUT6qHTnJvGlCC3nWY+D089Wj1HRhx0kZk5h7JEusOWuqCTYjE/imUAJMqTISpgK+0q79DaSZiVCQsl+OFW8hyUa5JMAYIe/SnfnShchf53GikBrp73XCUAn4Q6pBoJeAYyDobz4VZ4cOEbgMU0rX0ye+nIR8Lztjgo/vIZzHz/cP0YvZTO/7m2K2HPlqLCoEGNoEJfwnbzdwf4GAHi0gTySiAf0Li4PQzNu0XknGmX5aJxVI6KdVSspdCsSpn4hbOD76W2L7Z6cU0IRhgCxjBo/oazbc11QD2liESfH/Dw4Uo6dscJRLJckiWzB7l1/iY2QuKXRyd92o8cMwBkURD5InPWs7RTKtUAtwD7gvqS349UR662ILoXjZceHo/gRE6Yo+sjWKL0cjsreY6gpI5rISJJLctTypxwAms8QOxD94snkyMiZOehrd8B0x+QzJ7J3Rh/UYrYOP++Pd6oV/g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(8676002)(66476007)(66946007)(54906003)(86362001)(38100700002)(186003)(53546011)(83380400001)(16576012)(5660300002)(316002)(8936002)(2616005)(4326008)(66556008)(6916009)(36756003)(31696002)(6486002)(956004)(31686004)(508600001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0FQK0xqdmVjLzlGeGFaajF0WWc0YWJiMUJEcWpMUVlRTFlGVFpYNko4SnNu?=
 =?utf-8?B?dW1FQjkzVm9QQ1pHNXQ4b0xnR1liR0xnYnI4OWlXbmVuVmtlV2tUVC8vQjRu?=
 =?utf-8?B?ZXVoRU4yZVE2eDBXeWM1VXN2NGxZYzRQSkU3d2JOY0hpdUg1OUlxdXhqWnYy?=
 =?utf-8?B?TmpOZ0NKUzhhWmExaS8ybWpFdFlKdy95ZDJGTUJUYXMreXdqZkg0K1ZTTGFx?=
 =?utf-8?B?VUZreEFaQlI3TVArZVY4dEk2SG5WSWRQTXBvTVc0QVYvTThyTkwvME9zOW0r?=
 =?utf-8?B?Q1puVzNqbkp2cHhpMTJENFFLVFFSRDkwNHo3QUNQdVdaTE9OdExHWm5hVmRk?=
 =?utf-8?B?ZVZkTTBMeVVMOTFsOGdMeWlDdlZqTXRjZmNkOVBDWFppUmp2VzRTaU1BU2tF?=
 =?utf-8?B?Q0F6YVVzWkxwVTBLZ2FTcTkvNkh5SGdCd0dmbkp4UGF1M0toNzhhbjEvSTVY?=
 =?utf-8?B?S1J2a1BaeXpOdTZ6WTY3TWdlODByNk9VaktRMjMydGlXazRtMmhTN09pYy9y?=
 =?utf-8?B?NHNWY3I4UTREYWZ6bGJIOTZ5U3kwK0kvZ2pSbzBWVUlpMEpMVFM2Qm5RVDg0?=
 =?utf-8?B?Q0E5ODNTNHRIc0N1aUdKSWovZlRHZE10eE5BTnQ0c1BGUHpzUHZ6Qm9wZEk3?=
 =?utf-8?B?ZjdzYTdHVnlNMVZaSDVKaHkyanhJbEZLaGVhMnpuWnN4VEJMMVBvdDVNaXkr?=
 =?utf-8?B?NXFqVCtXaTBxOFI1R0lqQUVGc0tBbnVRZjFUWDRWNXpHanZ1UzZNbVU3UjBQ?=
 =?utf-8?B?RlBOWDBlZy80UFRvN3dETU1qbGxQMFZJY1lDWlFqaXpKcENIRXJ1UmFXdTQ4?=
 =?utf-8?B?UWxEdVpoWFRpdTI3MjYvRUFHRjJFT3Z1TEVBbUZtNURjVlV0R0pXTTNFd3RJ?=
 =?utf-8?B?UVM0d3FvdTZEQVdMa0JncVN0S3BMSHN0aDBkTHhIQjBrNkVLUzdoanpoS2Nl?=
 =?utf-8?B?QTJMdHJXcDg2amJXZDJLZEtxWldkai9yZm5kMWxQOWJRL3ArcUdXMytIQkF0?=
 =?utf-8?B?eWdtYlV2OU02azhySTR6Zlh5Q3Y3U3pSOW1aSTFYUE1PWHQ5eExuM25sMFhy?=
 =?utf-8?B?UDRINHpBd0gvaFV1MnE4Z2FMOFlqR201ck1ydUxJc0RnVklsbnoyc25ZRGtQ?=
 =?utf-8?B?WHhvSVBtVkE0OGdXS094VEtjUXpPNTdZdHdkdjl1SmVXeHFpNVkyUThyWmpJ?=
 =?utf-8?B?MEhLOHFjWmN0L21oUmx3dlB0TUJTNjliTG9wYWg4YWxydm1jVVFJZWVrZFRv?=
 =?utf-8?B?NUk0UHN0NWNhRUxKK1NjV29zWlFEcUQxZFhOZUc2WjRwemR4VlB3Tm1kTUlh?=
 =?utf-8?B?aFBkdmd6SnkwMVlBRlRqU1dwVFBSTVordWdoTzFVV25VOGNpeDRGeTRROVgr?=
 =?utf-8?B?YnlKY1J4M3ZxRG5vUS9aTHUrTldLaU5YeDVXUERjL3M5MUZoaDQwd2VwL0VK?=
 =?utf-8?B?R2dFc1RXRXI3enMxcHBDb2ppZ1oyVFkyT0I2eXJLVmhjQmw2U1pKa2g4bGta?=
 =?utf-8?B?OXZmZHFJME42YlJSWjNWZ3NIZlBRNmlyaDdPZkZKOGk0NU1PM2RDNnpUKzMx?=
 =?utf-8?B?M0hrcjdyZCtwT3BHeVF4ODhsemlBbk9ZMldUNlFlTkFzQmcrR05jVEhNSTVR?=
 =?utf-8?B?NStha1RibUNWeUVJV0VaU3h6YWR6V3VpNzBsODdzYlAzM2UwZ015bGhOUzlj?=
 =?utf-8?B?K0VZTnoyWUxLR29mbzFFUFBMVGE0eUhPcHY3QkhxLzUwQkgxTW9icjAwOUlT?=
 =?utf-8?B?Sk41Q2w4N1BrMGsyV2J2U0tiWVR1THVFQU9SajZpWHo1a3hkbGpVY2hSUDFn?=
 =?utf-8?B?ZTBZN1V4NnVJV0gzWjBiVzFaWUVjZDFqczJIV1pNWUhkUDhNbFI1d21lOTdl?=
 =?utf-8?B?WTRhakNZWCtZWE1vYjcvNzQwZE5KTHNMZ1N3cHdCRkFmaEdaY2ZuM1lsUm50?=
 =?utf-8?B?Z0pWcVA0ZDIzRG4vWlR0U1FVbSt6bWkxUVlIWUhHbWlJWWYweVZGYWxSSlVw?=
 =?utf-8?B?YUFGdVloU0haSi8xYXMwbm8zRGxUaml0ZE0wQTF0QWQzZTRNelFReUgwaWxS?=
 =?utf-8?B?WUZYZFBtcFNhNkM4UXpLVUpwbzRzeWRTUlcvdXZQelhqZ3RwSmVpTzY2bXZR?=
 =?utf-8?B?OVlQcVBOSUtpY21XdHF1anhFaDRxZkNpTllZM1lDKytaUlMrRVZiZTdKOVRn?=
 =?utf-8?Q?iY8Y1aabHT4ikqH03loSOk4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd686d5d-fcb0-4a2e-753c-08d9b8c9fec4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 15:06:35.3190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 33Dr1rsW3+bjy3deDPmT2iMjnS8ts96Ai64lL/gEKpv4GKafXXt71OYPuGaVSDFW9/mtPsit9Bg71KKsGWnpMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903

On 06.12.2021 15:28, Julien Grall wrote:
> On 06/12/2021 13:44, Jan Beulich wrote:
>> On 26.11.2021 13:52, Ian Jackson wrote:
>>> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>>>> On 26.11.2021 11:04, Julien Grall wrote:
>>>>> For this case, you provided some sort of an explanation but so far, I am
>>>>> still waiting for a link to confirm that the signed-off-by match the one
>>>>> on the ML.
>>>>
>>>> I haven't been able to easily find a mail archive holding this patch.
>>>
>>> I 100% agree with Julien on all points in this thread.
>>>
>>> Please can we keep the Linux S-o-b.
>>>
>>> Note that S-o-b is not a chain of *approval* (whose relevance to us is
>>> debateable) but but a chain of *custody and transmission* for
>>> copyright/licence/gdpr purposes.  That latter chain is hightly
>>> relevant to us.
>>>
>>> All such S-o-b should be retained.
>>>
>>> Of course if you got the patch somewhere other than the Linux commit,
>>> then the chain of custody doesn't pass through the Linux commit.  But
>>> in that case I expect you to be able to say where you got it.
>>
>> I've submitted v2 with S-o-b restored as far as necessary to meet this
>> requirement. I did not restore all of them, because I continue to not
>> see the value of retaining them. You saying "is highly relevant to us"
>> is a statement, but not an explanation of why tags beyond those in the
>> original submissions need retaining.
>>
>> Without me seeing the need / value, I'm afraid I see only two ways
>> forward: Either things are acceptable as they are now (and will be for
>> future similar imports), or it needs to be someone else to put time
>> into spotting and then pulling in such changes.
> 
> I am a bit confused how this would require more time. They are already 
> in the commit message from Linus's git and you have a correct commit id. 
> So this is merely a copy/paste.

I didn't say "more time", did I? What I did (indirectly) say is that for
areas like this one it looks like I'm the only one to check at least
every once in a while. This has been working straightforwardly in the
past, but is now suddenly causing issues. And as indicated - if I would
understand the importance of tags which got mechanically added on the
way of flowing into Linux, I would likely be willing to give up my
position of viewing such extra tags as more getting in the way than
being helpful (much like I would always strip Cc: tags before committing,
as I firmly believe they have no place in the repo). But such an
explanation hasn't been given so far.

> I am not going to ack it but I am also not going to Nack it if another 
> maintainer agrees with your approach.

FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
I'm now in a position to put this in with Luca's R-b.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:10:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:10:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239215.414612 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFdc-0001Is-5a; Mon, 06 Dec 2021 15:10:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239215.414612; Mon, 06 Dec 2021 15:10:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFdc-0001Il-29; Mon, 06 Dec 2021 15:10:44 +0000
Received: by outflank-mailman (input) for mailman id 239215;
 Mon, 06 Dec 2021 15:10:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muFdb-0001Id-4T
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:10:43 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad1382f1-56a6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 16:10:42 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35436)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muFdY-000s8w-8u (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 15:10:40 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 875621FDB9;
 Mon,  6 Dec 2021 15:10:40 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad1382f1-56a6-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <bd34ada6-15b2-6720-7669-4247aed536f3@srcf.net>
Date: Mon, 6 Dec 2021 15:10:40 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206133828.8811-1-andrew.cooper3@citrix.com>
 <b7c3525e-9acb-cef8-56b6-894975eeb530@srcf.net>
 <1884c09b-2583-efd7-bcfa-8413865c53b6@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86/irq: Improve local_irq_restore() code generation and
 performance
In-Reply-To: <1884c09b-2583-efd7-bcfa-8413865c53b6@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 14:07, Jan Beulich wrote:
> On 06.12.2021 14:55, Andrew Cooper wrote:
>> On 06/12/2021 13:38, Andrew Cooper wrote:
>>> popf is a horribly expensive instruction, while sti is an optimised fastpath.
>>> Switching popf for a conditional branch and sti caused an 8% perf improvement
>>> in various linux measurements.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Jan Beulich <JBeulich@suse.com>
>>> CC: Roger Pau Monné <roger.pau@citrix.com>
>>> CC: Wei Liu <wl@xen.org>
>>> ---
>>>  xen/include/asm-x86/system.h | 9 ++-------
>>>  1 file changed, 2 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/xen/include/asm-x86/system.h b/xen/include/asm-x86/system.h
>>> index 65e63de69a67..4be235472ecd 100644
>>> --- a/xen/include/asm-x86/system.h
>>> +++ b/xen/include/asm-x86/system.h
>>> @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nospec(unsigned long index,
>>>  })
>>>  #define local_irq_restore(x)                                     \
>>>  ({                                                               \
>>> -    BUILD_BUG_ON(sizeof(x) != sizeof(long));                     \
>>> -    asm volatile ( "pushfq\n\t"                                  \
>>> -                   "andq %0, (%%rsp)\n\t"                        \
>>> -                   "orq  %1, (%%rsp)\n\t"                        \
>>> -                   "popfq"                                       \
>>> -                   : : "i?r" ( ~X86_EFLAGS_IF ),                 \
>>> -                       "ri" ( (x) & X86_EFLAGS_IF ) );           \
>>> +    if ( (x) & X86_EFLAGS_IF )                                   \
>>> +        local_irq_enable();                                      \
>>>  })
>> Bah.  There's still the one total abuse of local_irq_restore() to
>> disable interrupts.
> Question is whether that's really to be considered an abuse:

These are Linux's APIs, not ours, and they've spoken on the matter. 
Furthermore, I agree with this being an abuse of the mechanism.

>  To me
> "restore" doesn't mean only "maybe re-enable", but also "maybe
> re-disable".

nor does "save" mean "save and disable", but that's what it does.

The naming may not be completely ideal, but the expected usage is very
much one way.

>  And a conditional STI-or-CLI is likely still be better
> than POPF.

It likely is better than popf, but for one single abuse which can be
written in a better way anyway, it's really not worth it.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:11:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:11:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239218.414622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFe3-0001oC-DY; Mon, 06 Dec 2021 15:11:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239218.414622; Mon, 06 Dec 2021 15:11:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFe3-0001o5-AY; Mon, 06 Dec 2021 15:11:11 +0000
Received: by outflank-mailman (input) for mailman id 239218;
 Mon, 06 Dec 2021 15:11:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muFe2-0001cz-EY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:11:10 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9ed6934-56a6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:11:03 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40882)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muFdu-000l6E-nT (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 15:11:02 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 249A51FDB9;
 Mon,  6 Dec 2021 15:11:02 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9ed6934-56a6-11ec-8a4d-196798b21f7b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <211f1b19-5f36-3153-bdc3-d904193b3643@srcf.net>
Date: Mon, 6 Dec 2021 15:11:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206130855.15372-1-andrew.cooper3@citrix.com>
 <9ac98bc7-5b39-3c88-556b-53a5fdeb2445@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86/boot: Restrict directmap permissions for
 .text/.rodata
In-Reply-To: <9ac98bc7-5b39-3c88-556b-53a5fdeb2445@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 13:58, Jan Beulich wrote:
> On 06.12.2021 14:08, Andrew Cooper wrote:
>> While we've been diligent to ensure that the main text/data/rodata mappings
>> have suitable restrictions, their aliases via the directmap were left fully
>> RW.  Worse, we even had pieces of code making use of this as a feature.
>>
>> Restrict the permissions, as we have no legitimate need for writeability of
>> these areas via the directmap alias.
> Where do we end up reading .text and/or .rodata through the directmap? Can't
> we zap the mappings altogether?

I felt it was safer to keep readability via the directmap.

I'm not aware of any logic we have which reads the directmap in order,
but it ought to be possible.

> As to superpage shattering - I understand this is not deemed to be an issue
> in the common case since, with Xen moved as high up below 4G as possible,
> it wouldn't normally live inside a 1G mapping anyway? This may want calling
> out here. Plus, in non-EFI, non-XEN_ALIGN_2M builds isn't this going to
> shatter a 2M page at the tail of .rodata?

cpu0_stack has already shattered down to 4k, which is likely in the same
superpage as rodata in a non-2M build.

But at the end of the day, it is a security/performance tradeoff.

memcpy(__va(__pa(divide_error)), "\x0f\x0b", 2);
asm ("div %ecx" :: "c" (0));

is an especially low barrier for an attacker who has a partial write gadget.

The security benefits are substantial, and the perf downsides are a
handful of extra pagetables, and a handful of pagewalks taking extra
steps, in non-fast paths (i.e. distinctly marginal).

It occurs to me while writing this that the same applies to livepatches.

>
>> Note that the pagetables and cpu0_stack do get written through their directmap
>> alias, so we can't just read-only the whole image.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>>
>> Ever so slightly RFC, as it has only had light testing.
>>
>> Notes:
>>  * The stubs are still have RX via one alias, RW via another, and these need
>>    to stay.  Hardening options include splitting the stubs so the SYSCALL ones
>>    can be read-only after setup, and/or expanding the stub size to 4k per CPU
>>    so we really can keep the writeable alias as not present when the stub
>>    isn't in active use.
>>  * Future CPUs with Protection Key Supervisor (Sapphire Rapids and later)
>>    would be able to inhibit writeability outside of a permitted region, and
>>    because the protection key is per logical thread, we woulnd't need to
>>    expand the stubs to 4k per CPU.
> I'm afraid I don't follow: The keys still apply to entire pages, don't they?
> This would still allow write access by all 16 CPUs sharing a page for their
> stubs.

It would be all stubs, because there are only 16 protection keys and we
wouldn't want to interleave adjacent stub mappings.

The logic would now be:

pks_allow_write_access();
write new stub;
pks_revoke_write_access();

so as to limit writeability of any stub to just the critical intending
to modify it.

This way, an unrelated buggy hypercall couldn't write into the stub.

>>  * At the time of writing, PV Shim still makes use of .rodata's read/write
>>    alias in the directmap to patch the hypercall table, but that runs earlier
>>    on boot.  Also, there are patches out to address this.
> I did consider committing that change, but it wasn't clear to me whether
> there were dependencies on earlier parts of the series that it's part of.

I've got a dis-entangled version in my CET series.

https://github.com/andyhhp/xen/commit/8d55e1c8ff1d979c985b3fb75c23627348c15209

which needed some header file adjustments to build.

But yes - I too was thinking that it ought to be committed.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:15:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:15:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239225.414633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFiB-0002XI-Us; Mon, 06 Dec 2021 15:15:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239225.414633; Mon, 06 Dec 2021 15:15:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFiB-0002XB-Rx; Mon, 06 Dec 2021 15:15:27 +0000
Received: by outflank-mailman (input) for mailman id 239225;
 Mon, 06 Dec 2021 15:15:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFiA-0002X5-18
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:15:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 56421f89-56a7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:15:25 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-Z3DFPhqRNoOd-WVeIRndFw-1; Mon, 06 Dec 2021 16:15:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Mon, 6 Dec
 2021 15:15:23 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 15:15:22 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0057.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::34) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 15:15:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56421f89-56a7-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638803724;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DIFaz3vAvQo/bWdfPBqwGYou86Srb3EiWYTbGAA7w/4=;
	b=MKspDNp4MHeS38hEVF8tVYd/N6r6SVhwfA0XasmupId5Lz5OGy5Rbp6tjvBgNTCqhFq/1a
	u0CTnSZ6uSsmrfE8Ra3iwiYbRBcqce6XfssaHjPNy74kEbWpbo0SriOtWK512519yaJE7H
	MP1qkSeMLc2eaX8aj4Z07hmzA+76NjA=
X-MC-Unique: Z3DFPhqRNoOd-WVeIRndFw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Td12/nKndSIL/LLNj+ew2zetkaBvTP1JNmiHoUkvTNRJxsXBo+0S0GcezU6SInGe+LrQ6UBL0vPVFkWLlS4itqLDqdiA/X/Bt2QR4fUSpbpBDurHXfHlju8mLCnsoeNBIq1rhBjaX55W3AifsaFV9FHGIhFXGU0yb1A+jjikM/mJLRqekmdoEG9Sy363GYN8KKwB7B7BuiH+IdV6FfbdBx0P7Ose35c4JtPMlP8lTWyqQK2ton8ptUG3UvJuxoexxTRizXCZp00QAgHPrfahP+wU9fpvQD2oYKhklFEtTE5JRiifv6pMA/3ODBDh0IAQZ4z0mB5EmAUM4FEOHRU3Bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0Xuibp43/JaJ8UQdYMRsGOxHv7rpHvG3g7rC77lZ7Ag=;
 b=J2tAHx4Qp0LyG227+eirwKPtCNGfSWI21a+CZy6tCMIiPbrpiMyM35z/Dt7jwExf8K0ylsHleV5SE6UCVtp7xfPBMwuZjZ/Nn++XJnh7/AI+1WDpUxYoqHeUWGJPfX55O8SIEwGGv9qiLV81Mpq3JkY+EOOGMfGe1kE1q9KkJRWh1Gv0xPSb1TQo8pxJh55wL9ZryrsX/6+B4Cs2qomsdI7p3Kxx3CCG9rd1xypeiZp+OvLEk1gy5no2oSqcp17OZqen917T3V1C42yNC4g0thy6mArAAGBBb6LcI7Zz8R3BTsduv3dyzbT2vGcqpf04Dt/qX/zEhwh7kOpw0xnZqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0b3b89f4-caca-a591-13aa-35683b9925e9@suse.com>
Date: Mon, 6 Dec 2021 16:15:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/irq: Improve local_irq_restore() code generation and
 performance
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206133828.8811-1-andrew.cooper3@citrix.com>
 <b7c3525e-9acb-cef8-56b6-894975eeb530@srcf.net>
 <1884c09b-2583-efd7-bcfa-8413865c53b6@suse.com>
 <bd34ada6-15b2-6720-7669-4247aed536f3@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bd34ada6-15b2-6720-7669-4247aed536f3@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0057.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 851382b2-1347-42bc-39ca-08d9b8cb3934
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5742460257F64DC446A7895AB36D9@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	lmjIWJ3Y2V0rxMGGArb+llDusQ5heFrayJ07mzvazLwITi1PvbXUH5SGS4f0AS5vjio+ZHzbuCJU6rjgH5PSnNzLxr07522MSk0EWLEvRDtsh/gfftNNXtykbDNNUIlP7C8qhiKB0PlLUt5DPw1xd/0tLTNf281ajwd3s1uXQVVncNPlf4Ato+76WnHR+m+VBld9MT2QHzmrEqedcV/9cNHH6e+0Gm1DZ9DTkxJ13+YCvNfcnsNlEzqTf1qjh6cdxnfjcywMFT1LcB/yW6xrJ3blSN5rdT8jcPtwrQbpPSQP3rBGzvC/vWOlZvrPcAGT4huwz1WROI8xXovvlSIxVdpkqGjxoM8xYowg9KK/g7f5R9INsZLX2sLSGB5+IPeVHLsa9f+K+L0aRGbPWnzsMhXGdzqC4UrZGXTi2cMZ+4NN135MJJwdXWgSI2o6EkYIHmBEqmn7uMzHLxvSxOxqEgalFgnZ+uSjp8AE3Ed7bCQS6mvMdVgnbh4C2i7C941B0rW6Jq1HBd3pCoCfzFp553jt5FUN/kP0OFG2JTJ/JDAASByNUkU4AI2pUEYn983fiUFSv+MzSlklP604c88f1/xCbCWmgMIrgmoTz5lJj9FN06MUJsVGD1h03Tp6L9mdoOImpjl1Cs69G1DeSWx6noFMcBlJkToixZztlOIKTQFg3LQYJxzDwXTzGJa5HjC2y5mxhaV4BkjpOdEC6jHiDfoeBcGE9KCFTwCaFl3wMho=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(110136005)(54906003)(31696002)(31686004)(86362001)(316002)(16576012)(2906002)(83380400001)(36756003)(8936002)(53546011)(26005)(8676002)(38100700002)(508600001)(186003)(66476007)(66556008)(66946007)(6486002)(956004)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8q0qCrNcURe3vEVTrP8lgjJouUVzYN/v0LWllrz8AP+hB4kwsQtNBOCBmZ0y?=
 =?us-ascii?Q?PbyWNQJkVPgWZnrxtyecgXvzrJeE0DmvNjkGYRvkhZJHwDA7WMEifUAN+hRK?=
 =?us-ascii?Q?3SQfgtoxFAmlGdhnnq4K9rk6eMguJ949CLaiE/k2Y/iRa4xlZet2L/1LEWdr?=
 =?us-ascii?Q?LKvPwcyaYfVUnTJxwjIF6qFVW4pF0cvEqh40QnwuEwKVTjDOVYUR5cTYCRL1?=
 =?us-ascii?Q?BE6EFrWZHCgHDjukc/N+zVVxrJOj0zLmsjmE+K4vpU+GOoXrzS/HigZJ2fyA?=
 =?us-ascii?Q?rXJGiPv0RMzYsOpXG0WJ4QYQhld2d+gMLeN1c80nWoOOpZEsBC1aKeMchsyb?=
 =?us-ascii?Q?iNjpbNFN2uPhr0uH8DifcwDPmecTwX6YRngRnZTDRTZXuh/t7XxToByCVBye?=
 =?us-ascii?Q?kGY3rMyH93TgVGiU99Uop57K6zTm9cIIJLmEnhCAuYit/YEGOxQxFn9XiAs1?=
 =?us-ascii?Q?Mi/hMCYzoH9gQ9Fwc3C4pJ/MwPJaI3udfmlfIjLkwcwy3pMt/MJUIJAkyd6h?=
 =?us-ascii?Q?GXVtcEzy7qSbcbCj6Sxan0DASYd4LBS3xSaXgm/eGESbqJIheLYK0AGAXDng?=
 =?us-ascii?Q?NXTeRcnc/O60QuKpOe2wJOXd1qBFJ3d1gAREUvhPDcqRh5oQcS/rtPvJZ/cE?=
 =?us-ascii?Q?PoSKXA4HdZ8oVGI7LepdFTMItLg+LUB1R8oST/diMwShB16cMi2QaWjYbxyG?=
 =?us-ascii?Q?BbB/r4ruApqdzejrfCJEwEWRfDtFPJSHgptGNvVbZCLqRoBqTqZ+JOavP/3g?=
 =?us-ascii?Q?pmBqSuFWVJkvXVcsyd/9lYFRIi6zULVMY8sPP3F9C9kf3k2MyhjAsBRXiEPr?=
 =?us-ascii?Q?WjIo6pVZ43KMYsMiIsvzoahXJHZCsLhWg4PVxbHpb5ZmDtUloD52h2eNBQoN?=
 =?us-ascii?Q?O6kTaWMRuT0Zq2K4KQEr7CcYWaUUVDe3uuWQ9aZfEeIlheIIqXOSj2Jv1b/U?=
 =?us-ascii?Q?Lwd3MltxYCbOb1bfvuTQUjMMr2TLUOY4NJnriQl1QvcadLU+bsOYi0VjpnFS?=
 =?us-ascii?Q?QPDTVfz52MKn8Xs9X9elgsH41i3uxrHaiy3kBPGWvpOlRyM9SPWg5D8l5qPr?=
 =?us-ascii?Q?xD1CrStpt41s2FPkDhPgYSEmS6ICgQJrfNgc+o5oo3rUnbXQyKBQkTV/Btpr?=
 =?us-ascii?Q?7FFSjgZyClgTupwW6TwVRxFRSgXf0bZuTSOCVfQQG6SU65WEZ+exDf5UHRIw?=
 =?us-ascii?Q?5T6GEgvQb1uvUM+j/HU0ZOLF1ExM3A5CKi92wXl2sMfszCFmlDZjSO7dr9F0?=
 =?us-ascii?Q?gyv2u8RhgM7HelODCn8au531NK98kpqQTjTVM8Kva9/HDE7yf7DSPgxAi5QD?=
 =?us-ascii?Q?re9b3xVRdecKCWTeStN233cZY9APW0iM66IRc7Sw8QLJsxX6SkNlGFcrg3xm?=
 =?us-ascii?Q?rTx4AZHkWpZY64/k5Kd32M9SCbB61ytQwMEj6VkmukUk/euwNj94GXGRlelx?=
 =?us-ascii?Q?Qb3JNGijNQJCNp+0rYM5XbG4LVN+kvRQsXYBPfXfTid7mINAVCGjPsHXKxeB?=
 =?us-ascii?Q?5YVVZ5Ozbgy2IPYR7eeKreWEj6jx+nDe2jPx4oePTW2biNubfr/5gOssEKcv?=
 =?us-ascii?Q?DCDV6X1RM9Msw5fq+jSTcQLML5iHZuKGTIauIakFJs1ZvlkKxz1DoYxauc4c?=
 =?us-ascii?Q?j63Qz5foz08W2MuefmgnBiY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 851382b2-1347-42bc-39ca-08d9b8cb3934
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 15:15:22.8480
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mQWqV6SIoRZUVXAznRVIJerL0e0vEH3Oo3OhgL5umc8yVDbgkuaMXzqOe5j0TGqhI+UHneeH9xLrSIPzeE6m3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 06.12.2021 16:10, Andrew Cooper wrote:
> On 06/12/2021 14:07, Jan Beulich wrote:
>> On 06.12.2021 14:55, Andrew Cooper wrote:
>>> On 06/12/2021 13:38, Andrew Cooper wrote:
>>>> popf is a horribly expensive instruction, while sti is an optimised fa=
stpath.
>>>> Switching popf for a conditional branch and sti caused an 8% perf impr=
ovement
>>>> in various linux measurements.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> ---
>>>> CC: Jan Beulich <JBeulich@suse.com>
>>>> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
>>>> CC: Wei Liu <wl@xen.org>
>>>> ---
>>>>  xen/include/asm-x86/system.h | 9 ++-------
>>>>  1 file changed, 2 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/xen/include/asm-x86/system.h b/xen/include/asm-x86/system=
.h
>>>> index 65e63de69a67..4be235472ecd 100644
>>>> --- a/xen/include/asm-x86/system.h
>>>> +++ b/xen/include/asm-x86/system.h
>>>> @@ -267,13 +267,8 @@ static inline unsigned long array_index_mask_nosp=
ec(unsigned long index,
>>>>  })
>>>>  #define local_irq_restore(x)                                     \
>>>>  ({                                                               \
>>>> -    BUILD_BUG_ON(sizeof(x) !=3D sizeof(long));                     \
>>>> -    asm volatile ( "pushfq\n\t"                                  \
>>>> -                   "andq %0, (%%rsp)\n\t"                        \
>>>> -                   "orq  %1, (%%rsp)\n\t"                        \
>>>> -                   "popfq"                                       \
>>>> -                   : : "i?r" ( ~X86_EFLAGS_IF ),                 \
>>>> -                       "ri" ( (x) & X86_EFLAGS_IF ) );           \
>>>> +    if ( (x) & X86_EFLAGS_IF )                                   \
>>>> +        local_irq_enable();                                      \
>>>>  })
>>> Bah.=C2=A0 There's still the one total abuse of local_irq_restore() to
>>> disable interrupts.
>> Question is whether that's really to be considered an abuse:
>=20
> These are Linux's APIs, not ours, and they've spoken on the matter.=C2=A0
> Furthermore, I agree with this being an abuse of the mechanism.
>=20
>>  To me
>> "restore" doesn't mean only "maybe re-enable", but also "maybe
>> re-disable".
>=20
> nor does "save" mean "save and disable", but that's what it does.
>=20
> The naming may not be completely ideal, but the expected usage is very
> much one way.
>=20
>>  And a conditional STI-or-CLI is likely still be better
>> than POPF.
>=20
> It likely is better than popf, but for one single abuse which can be
> written in a better way anyway, it's really not worth it.

Fine with me as long as we can be very certain that's it's really only
one such case.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:21:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:21:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239234.414655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnR-0004U0-Sc; Mon, 06 Dec 2021 15:20:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239234.414655; Mon, 06 Dec 2021 15:20:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnR-0004Tt-PP; Mon, 06 Dec 2021 15:20:53 +0000
Received: by outflank-mailman (input) for mailman id 239234;
 Mon, 06 Dec 2021 15:20:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DWHB=QX=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1muFnR-0004IB-Au
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:20:53 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18e9d030-56a8-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 16:20:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18e9d030-56a8-11ec-a5e1-b9374ead2679
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638804051;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CpKf9mvjkPjVBj3xIynQ2IUnpCyITLeKj1fi9KomO3Y=;
	b=uWwUXVC0WnVC3w1cQSTya5dZeSue12+qWIVuC9ayyFkiDFL9G0Sfv5sgG3Mgji+USmrR3i
	EWpfPFRxIdEY4IeWA5TWOKrxndqoCjKhwS6Z84fCwmzqI5MqDfCdegIbuQZB9GjhIHEpm9
	FJUtBRyeKaSoniNraKma5SZ8iP39mUCHkVgOKy+C16EcbvOsEWo9i5G2eiITHhzNmorRso
	R1QtcOksTF0JVbuDGxPjJ7j9MocO7Ohie4/A49LY70+rxjBb6jRaD1eLJouksuwvmd3vQZ
	Rkq3hMTMD3s+vWnN5KKN/KHj6i88h4DUhAnWP0giyBHHvJVKFll4ezdxsGpv4A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638804051;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CpKf9mvjkPjVBj3xIynQ2IUnpCyITLeKj1fi9KomO3Y=;
	b=O6EsH4ldQp4/tYChtuSnommkfShCw+Bw6sFmYII9N55xtHImCMLD/K/4e4TqkJmdda93r3
	FJIAmKHYkC9TGkCw==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng  <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 1/2] x86/xen: Allow to retry if cpu_initialize_context() failed.
Date: Mon,  6 Dec 2021 16:20:33 +0100
Message-Id: <20211206152034.2150770-2-bigeasy@linutronix.de>
In-Reply-To: <20211206152034.2150770-1-bigeasy@linutronix.de>
References: <20211206152034.2150770-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>

If memory allocation in cpu_initialize_context() fails then it will
bring up the VCPU and leave with the corresponding CPU bit set in
xen_cpu_initialized_map.
The following (presumably successful) CPU bring up will BUG in
xen_pv_cpu_up() because nothing for that VCPU would be initialized.

Clear the CPU bits, that were set in cpu_initialize_context() in case
the memory allocation fails.

[ bigeasy: Creating a patch from Boris' email. ]

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/x86/xen/smp_pv.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 6a8f3b53ab834..86368fcef4667 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -277,8 +277,11 @@ cpu_initialize_context(unsigned int cpu, struct task_s=
truct *idle)
 		return 0;
=20
 	ctxt =3D kzalloc(sizeof(*ctxt), GFP_KERNEL);
-	if (ctxt =3D=3D NULL)
+	if (ctxt =3D=3D NULL) {
+		cpumask_clear_cpu(cpu, xen_cpu_initialized_map);
+		cpumask_clear_cpu(cpu, cpu_callout_mask);
 		return -ENOMEM;
+	}
=20
 	gdt =3D get_cpu_gdt_rw(cpu);
=20
--=20
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:21:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:21:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239233.414645 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnQ-0004EH-LF; Mon, 06 Dec 2021 15:20:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239233.414645; Mon, 06 Dec 2021 15:20:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnQ-0004EA-I5; Mon, 06 Dec 2021 15:20:52 +0000
Received: by outflank-mailman (input) for mailman id 239233;
 Mon, 06 Dec 2021 15:20:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DWHB=QX=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1muFnO-0004E4-OM
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:20:50 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 178cdb64-56a8-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:20:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 178cdb64-56a8-11ec-8a4d-196798b21f7b
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638804048;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=eBUTJfSYTohYJrigB87qpawZTrkhnOrjrQMyd+1Fhwk=;
	b=eZhwLxSP0xjHaMsmjzLmKUFhWGkGcU+lY49u+slmdMBVa+B0yQeSb0014cmr+9hLtaYxW0
	LITXrzJUUAolVmD0pv6AunfmcFoB6/h5I9tYVNgMUzYyFFUDI3AVfMF9n53HXYCS58ovlj
	HBeuhzlOx/59V1aUzWeEGcArXrZyHafIH1BEASzggpKSMKI6GyHZnHVid8Tnd9aidotcaZ
	nUiTVJByJwlV6FPuPPkjkD0yBQr1siMsmnEobJHOCt9o70Amkq43iDz7+v8bmdu51IlxCL
	ATYKYRa9JqOJXMUwMwbDyxtmzJw0ZVVn+K2ayBGtNZ51tEvg6tsNwmaZO5PMhg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638804048;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding;
	bh=eBUTJfSYTohYJrigB87qpawZTrkhnOrjrQMyd+1Fhwk=;
	b=puPYMI4UmCOWYPLU0RULgaRZC/m0aDW6qv/I9YVdjynxikd2Cgh4EdqYAy0l1xOJHZ0zmi
	Obr7NxW+CZS4qpCw==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng  <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 0/2 v2] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
Date: Mon,  6 Dec 2021 16:20:32 +0100
Message-Id: <20211206152034.2150770-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

This is a repost of the previous patch (#2) and adding Boris
(Ostrovsky)'s suggestion regarding the XEN bits.
The previous post can be found at
   https://lore.kernel.org/all/20211122154714.xaoxok3fpk5bgznz@linutronix.d=
e/

Sebastian




From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:21:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:21:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239235.414667 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnY-0004og-49; Mon, 06 Dec 2021 15:21:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239235.414667; Mon, 06 Dec 2021 15:21:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnY-0004oX-0x; Mon, 06 Dec 2021 15:21:00 +0000
Received: by outflank-mailman (input) for mailman id 239235;
 Mon, 06 Dec 2021 15:20:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=DWHB=QX=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1muFnW-0004E4-NN
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:20:58 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1cd615dd-56a8-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:20:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1cd615dd-56a8-11ec-8a4d-196798b21f7b
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638804057;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=41Yw8yf+7TjYHl20/Q/EDf0gZtvNJ2sbLTnT1+NsteE=;
	b=LQgKbrKct/We7aHQ0TZFYlFpu0pNkOgrZ0sdarc6GLYKUkQoeNNAReN09czDjhMhsLh9te
	BX3g529ypr8U7D45FxquyLLsCnFTwa0E8VwTVABJ3Nz8tDiFDmwt9s65LduJcR/MYqdWBf
	TIlYLOsZZ356mha/P1VdYYQwPYgxszdT1xkJgZqKp7s4Q4jUgb4VTxhB2dRrgJejQ+s6Hu
	RG2ATWq0wWTu0Hp7ii/kr1uHYB2VoBrrmPiAeKTaaGoYw854rUmH3ZiCOjFfry6OfkAJFM
	QqoIe6pKucm2KTK3qWnikwFJv8x4UouEHovyaNHMt7s4xGg1BcQDOUnjW0tbtA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638804057;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=41Yw8yf+7TjYHl20/Q/EDf0gZtvNJ2sbLTnT1+NsteE=;
	b=sxMj8+RWZBRXTITuDvoBALBqgfRKj9Zi74fNBcRPtr6Ur/ZuBm1c25eHa7tYX8nSmHpODY
	3rlnDKXz8mPQb8Bg==
To: linux-kernel@vger.kernel.org,
	x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Longpeng  <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Dongli Zhang <dongli.zhang@oracle.com>,
	Henry Wang <Henry.Wang@arm.com>
Subject: [PATCH 2/2] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE state to be brought up again.
Date: Mon,  6 Dec 2021 16:20:34 +0100
Message-Id: <20211206152034.2150770-3-bigeasy@linutronix.de>
In-Reply-To: <20211206152034.2150770-1-bigeasy@linutronix.de>
References: <20211206152034.2150770-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

From: "Longpeng(Mike)" <longpeng2@huawei.com>

A CPU will not show up in virtualized environment which includes an
Enclave. The VM splits its resources into a primary VM and a Enclave
VM. While the Enclave is active, the hypervisor will ignore all requests
to bring up a CPU and this CPU will remain in CPU_UP_PREPARE state.
The kernel will wait up to ten seconds for CPU to show up
(do_boot_cpu()) and then rollback the hotplug state back to
CPUHP_OFFLINE leaving the CPU state in CPU_UP_PREPARE. The CPU state is
set back to CPUHP_TEARDOWN_CPU during the CPU_POST_DEAD stage.

After the Enclave VM terminates, the primary VM can bring up the CPU
again.

Allow to bring up the CPU if it is in the CPU_UP_PREPARE state.

[bigeasy: Rewrite commit description.]

Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lore.kernel.org/r/20210901051143.2752-1-longpeng2@huawei.com
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Tested-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Henry Wang <Henry.Wang@arm.com>
Link: https://lore.kernel.org/r/20211122154714.xaoxok3fpk5bgznz@linutronix.=
de
---
 kernel/smpboot.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/smpboot.c b/kernel/smpboot.c
index f6bc0bc8a2aab..b9f54544e7499 100644
--- a/kernel/smpboot.c
+++ b/kernel/smpboot.c
@@ -392,6 +392,13 @@ int cpu_check_up_prepare(int cpu)
 		 */
 		return -EAGAIN;
=20
+	case CPU_UP_PREPARE:
+		/*
+		 * Timeout while waiting for the CPU to show up. Allow to try
+		 * again later.
+		 */
+		return 0;
+
 	default:
=20
 		/* Should not happen.  Famous last words. */
--=20
2.34.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:21:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:21:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239239.414678 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnn-0005VP-E7; Mon, 06 Dec 2021 15:21:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239239.414678; Mon, 06 Dec 2021 15:21:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFnn-0005VI-AS; Mon, 06 Dec 2021 15:21:15 +0000
Received: by outflank-mailman (input) for mailman id 239239;
 Mon, 06 Dec 2021 15:21:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFnl-0004E4-Ob
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:21:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 22e65ace-56a8-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:21:08 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-nScjYSXWPgqcoBQ7azuCFQ-1; Mon, 06 Dec 2021 16:21:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 15:21:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 15:21:05 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0081.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 15:21:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22e65ace-56a8-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638804068;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=A8yGCbuRfPLdHuumi0i8w7IofLM0p4XnO4lBTRfXeZQ=;
	b=TrENjTj+yxo8GsKg3cvJtdqX5a8ErI0nTZItG3ixpqgAMiXlEQPnrdYrbszwSJ7HapdVjc
	09odcVseQZCcTm/0buCdP33+Ka2SVpVI0Sq8V46HmDO+UP6J8Mzyh3B5fkmt5SNjIq3JIo
	UYbbMlHPswfxLXRuz+77PIhnTzMmQBY=
X-MC-Unique: nScjYSXWPgqcoBQ7azuCFQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hmtz5PN13TySJ9KDyuzzveVriKxOuf9ZXw39FzhnlmnFgppoQF4vwKXUUtiuJasRIcWl6w9ghUlyTbslzwcVx/WIAJD3EfuzeTdQ4qG7Mi2XmzFo1nD/3unF7TT3Vg1CJUBkkLxSal+jn2TEMwnPk4uGExJMbM0JBkosZ7fIF3MAMFKJqIdjA2O9z28quMDkusAEIFPF22DsC1Vnn9umnTgqscQWQ3XWHIbTs8B2pA1PWV9Sp2uyR/aTP3pYcyLk9cPDI6uvBpRICmRVUYXPZ7WIQSfezxUQOclomvMCfNgF/a05XlgjzWZP5fzPiXVZ1eHLoArnK1wjbmAgP5rnJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A8yGCbuRfPLdHuumi0i8w7IofLM0p4XnO4lBTRfXeZQ=;
 b=b2o5dMwfX5UoDwFU6pHVYmmTu5PDNP3gz+X5VM6eB+DMvcCha4G4W4DhkhWojei12sBz6oZWC6IuPvLNstgICFmoukoBrjfeoDYq30LmcUqBsaCUTIhT+OS7nijwDEP6RgL65FgwYfLmSm1eBc/+DSdmqzcvsch8l3imTQGZ5ROgoPzUwXp8CV5VEPhklbIdUIWdcONgGmxc6Gl04SFdffVrJeBLm4cmek2VENFCcRFLWGwN3IoKgQZ7uN3u7xEGTnI9+u832/2/meA2KB49oh9sHui9HcX6loSu91z0Rg3EObpnSkoTX3xIjHXgrJNoOjxnLckuB0xOAC1Z0vWHrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b0932fc9-b55c-59d2-29cf-e0ce76dedcc0@suse.com>
Date: Mon, 6 Dec 2021 16:21:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/boot: Restrict directmap permissions for
 .text/.rodata
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211206130855.15372-1-andrew.cooper3@citrix.com>
 <9ac98bc7-5b39-3c88-556b-53a5fdeb2445@suse.com>
 <211f1b19-5f36-3153-bdc3-d904193b3643@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <211f1b19-5f36-3153-bdc3-d904193b3643@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0081.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:8c::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c95e97d4-eb28-43d5-f6fe-08d9b8cc059b
X-MS-TrafficTypeDiagnostic: VI1PR04MB3295:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB3295A6F8F9E17211862A61CFB36D9@VI1PR04MB3295.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3FzUCNNRLXMc3aLCckO7Ajhw7X4jBdC6jBegs8OQjFxWOkfC6QeTraIuummnF/oCvvombvRE3PN1mNsS4LUwtaEnwqM+V/haBhLc0GOZrtm6+/rCf8fjVUetknNg6b3+8aNqsheACWITS9Q7IdBYvjPZjdmFaLxfQ0tv2esenhC4rr0fLJA/qrN3MeIv9cOe56bevOhKLqjoaUzZYdhcR4RDx1Qwc8vhTfS1WBzUhAyR6sC53QeHeq4En1QcWxp6kV3Z4tLmivopI/Nq+NrpV1Rl8+/RAif44oIMez5pChxYYQtjDk7pzu/nJunosKKpgqy1rJmTbWEB4fBLcUpqKhEY5mSLq5OSgzyDwuCtnXzMNd6Ob96qUVJ+PsKk++UghtT9+b5lplnNGvP6dIDyQAEESoRd2QjFq/byzvHWtFXdZvu4wZ8+lnPObHh5P1pxsCiXG1Kmag9nZsgs26FyFdNHvqevtBeoEk0mRrFIZ4OAxteVp+t6K/B9LMANFTKB27o/8NLkyWCJ4U9IP7K5ttj8UcrbVxgv+R6EFu8waQhk2OV++/XO4OfLLNwlsH6txYZt5kMjEzAiqqd+YVlF3Xa7dCl6ACfPcIBh94dxhVHsSXhfE1fVGQhQY2dWeCR2pzganvB8dD+L7HmXLumUhUyBkd2FqFjEunG+bmVxMtvRsquKXOmf64Kd6ymHHW9S2xepLqBDMGA8WN97vMZkicOOQsPs9Z1B8VS4TBFIQP+6vatPt1Jv8y31lIIb68o09tdE3gFOfOvZujvtMCQ6rA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(16576012)(83380400001)(66556008)(38100700002)(110136005)(5660300002)(53546011)(956004)(36756003)(66946007)(4326008)(26005)(508600001)(66476007)(6486002)(8936002)(31696002)(8676002)(2906002)(31686004)(2616005)(186003)(54906003)(86362001)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d2pXSzJKaGZtMjFMNi9Wc1ZqNFhDb1p5RWVOTkZKeDB0c09Jc3lWYm50dEsz?=
 =?utf-8?B?YXczZXhab2Zmc3NVVHI3QURJbXZWbGR0Y3Q1K3lSZzltdnBtbTlEWitWeHI5?=
 =?utf-8?B?U05sNGNiVlpFZ2toWDRlNjVxTlh5Qm1mZU9MWVJTRHY0a2c3a3VKSlB2Y2FK?=
 =?utf-8?B?MmZ2OWY1b0djcGJqc1RGa2h1TVcwQkdTSGpid0ZBd0dzY0lHOTM3WmtuQkRJ?=
 =?utf-8?B?ei8xVWNKWmlrU3R1bEd1bTY2WTFTWnN1akJlZ0NJeDJISXRZUDlHZWFmSTlB?=
 =?utf-8?B?eE9YQVVpdWRrSGNoZ2ZDUFExZU8ydWRyWmEwck5lUXVpMzZwZ3NZUTl5VUIr?=
 =?utf-8?B?NkViZ0hjaFBBV0lzdDFjUjUrRkpDYmFCalFhRHo2RXN1dDc4Q0JkSERmMHAy?=
 =?utf-8?B?dGg2VTk4Z2RXUk1Sd2VhR005N05zK29vcm9hZTlBN21TSGJETExvZkozbTVo?=
 =?utf-8?B?ZlRaay9uMVBNRzJSSmRZQVZLY1YxNExmOVQrMXpCazA3cE54dENoVkZRbDhV?=
 =?utf-8?B?WC9XNDUyT0ZjS2dpWWpDVXE5bThNNVBncDhGdmRoS0gyK3JTNWRmSzdCWnA1?=
 =?utf-8?B?Yk41eDlXeHdzc0VkUUxZcUluNEh3dk5ZblFqVEpsaENuRmJxSkNzSnhDMDND?=
 =?utf-8?B?UHcwbzdtbTY0VnUwQWZxaDJYenl0M1dqbzh1WDFLMEpXRXphRFJwWnpvR2FN?=
 =?utf-8?B?d1JIaG9yaW9yUVVkYXNDanBLWkpqVm1lTVBZc0YxcUJNYUxuQVNjVm9sT1Fw?=
 =?utf-8?B?QVY5bmNyUWs2WVFERmhIMVVVUlJLM0Z4L1lCOGN6NXpJY2pINHlyYW5qODdo?=
 =?utf-8?B?OCswclZzU2EvOTh2MzRkaGJaMHh5ZlNTVVB0SFZsM1pQeFNzQ1RsbzgxUFhx?=
 =?utf-8?B?dFArZkhxYTFZREVmeGpRQVllS2NKUGFnK0J4VzdBb3ZvbjhiNmFwcEM1YTc0?=
 =?utf-8?B?NVZTMzVzS3d4ZmZmblYxRk5zM2ZaZ2NHNnJSLzd6azFjRE1HN2haMEYrTnJn?=
 =?utf-8?B?VFNESUZaZ25STE9jMjJ3MXJKUDRRVXREdGZrZEtneStqeU1hdmpLck96S2tw?=
 =?utf-8?B?azZGSExHWlZqNDFuV1Q0OWVNU3BqMXg0NTBVYnJoOUo2bWhWdjBIa0NlNTRs?=
 =?utf-8?B?RStmQ3JHUnBlcGdaeWsrOGMvL1RnQTgwTWdSMlM3WWp3UG9SMFFQaDkvVDJW?=
 =?utf-8?B?TElyTUhwSGpNU1JHRjJUYWszZTgzR0I0elE5a2Izb0NLYnRxbk5vTVdOQysy?=
 =?utf-8?B?ZVpYL2o3aklyM2NORUxNVFJGaExqRVQvUW9ZNkR5RlpyU25vT09rekVYeURM?=
 =?utf-8?B?REZwS1o1d2p3QkdYN1pXSnYzOTg4ZGx1YWo5RVlBS05acGhqckpEZTg2Y3Zw?=
 =?utf-8?B?V2theDk1ZmxGSi9SN1RFMHVYaGtvbExNeE4zUEJERHY5ZUZRakZURXl5OUsz?=
 =?utf-8?B?cjA1QXVUd1I2YjJoSjZHV0hpdnB1R2p3WVFBMERCWjFjMXVKQ3lTR1NpNG9V?=
 =?utf-8?B?bmRqRjBoQ3k5U2MrdDR4emYxa1g2ck1KMFEzZU5Xa3UxQjd1VSs5RkdZVnFW?=
 =?utf-8?B?VTJlZkRNSE1zUWFHSDllN3lKWC80ajNwVFc1M1Awa3hJQStuY0FCNC8vRXhT?=
 =?utf-8?B?eWJFRDlxdk5WL3MwYUk5ZzBZL1F1eHltcDZnWUZYT2lrTTFFcFhsbGljelN1?=
 =?utf-8?B?bStzajJIajExbDhMWHI4dkhBUTd1NXdaWjhWTFA3VXA4ajJpdWpGRXdHVFQ4?=
 =?utf-8?B?UEo5d3owU0Zzemc2dEJYZyszbi9XdjNKejdPS3B2Zkt0L3llajZwblFlQ0h4?=
 =?utf-8?B?OURjckU2TmpoTGxFelZzbGdqd1Q3ZThJTEFXYUlmVSt5MUgrb2s4N3JlSm80?=
 =?utf-8?B?WHFEaUdIcXlpQ2dQM1VLUWtrUzRlTkpkN3VOTzZpQnVtYW8yMnR3cnJLYU1D?=
 =?utf-8?B?RzFWeXNkRlZaakFDSlptWVFSc2pGYXljbkhDM0RVT2t6UVEvdXVIa0VGcGJ3?=
 =?utf-8?B?UStub1VOSWNIYXo1UlpOQkl3NHZ3RGhuWnYwdjdvMVNlc1BiZHdUdG9laE9N?=
 =?utf-8?B?aUNjV3U1UU9zZEREeHc4Yzl5MFUycTJxNHM4M0w0V0JwUldhQmtaOFBJQy9B?=
 =?utf-8?B?cjI0S01uVGlXSnpLNktyTjNoWUdrUzJmN0kxbFFFR0FMT1BDRE8vdEhCWE9t?=
 =?utf-8?Q?FFVW/fqS6dy3CJp6bIRZzXs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c95e97d4-eb28-43d5-f6fe-08d9b8cc059b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 15:21:05.7811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IB02vbxsFbh1MfqeIa9zwdUd27xLiPSzouHjWuKCv4+PLboFI9IN5YeNJiqZ1BXzLul7htNm8s5+KNMr+LYrxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295

On 06.12.2021 16:11, Andrew Cooper wrote:
> On 06/12/2021 13:58, Jan Beulich wrote:
>> On 06.12.2021 14:08, Andrew Cooper wrote:
>>> While we've been diligent to ensure that the main text/data/rodata mappings
>>> have suitable restrictions, their aliases via the directmap were left fully
>>> RW.  Worse, we even had pieces of code making use of this as a feature.
>>>
>>> Restrict the permissions, as we have no legitimate need for writeability of
>>> these areas via the directmap alias.
>> Where do we end up reading .text and/or .rodata through the directmap? Can't
>> we zap the mappings altogether?
> 
> I felt it was safer to keep readability via the directmap.
> 
> I'm not aware of any logic we have which reads the directmap in order,
> but it ought to be possible.

Could you add a sentence to this effect to this description, please?

>> As to superpage shattering - I understand this is not deemed to be an issue
>> in the common case since, with Xen moved as high up below 4G as possible,
>> it wouldn't normally live inside a 1G mapping anyway? This may want calling
>> out here. Plus, in non-EFI, non-XEN_ALIGN_2M builds isn't this going to
>> shatter a 2M page at the tail of .rodata?
> 
> cpu0_stack has already shattered down to 4k, which is likely in the same
> superpage as rodata in a non-2M build.
> 
> But at the end of the day, it is a security/performance tradeoff.
> 
> memcpy(__va(__pa(divide_error)), "\x0f\x0b", 2);
> asm ("div %ecx" :: "c" (0));
> 
> is an especially low barrier for an attacker who has a partial write gadget.
> 
> The security benefits are substantial, and the perf downsides are a
> handful of extra pagetables, and a handful of pagewalks taking extra
> steps, in non-fast paths (i.e. distinctly marginal).

How do you easily know what paths there are accessing data on the same
(potential) superpage? However, thinking about it, with the directmap
mapping presumably not getting used at all, how the mapping is arranged
doesn't really matter (except for the extra memory needed, but as you
say that's probably marginal).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:25:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:25:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239250.414689 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFs9-0006eS-0s; Mon, 06 Dec 2021 15:25:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239250.414689; Mon, 06 Dec 2021 15:25:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFs8-0006eL-U5; Mon, 06 Dec 2021 15:25:44 +0000
Received: by outflank-mailman (input) for mailman id 239250;
 Mon, 06 Dec 2021 15:25:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFs7-0006eF-Oy
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:25:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c67717dd-56a8-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:25:42 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-00e4U4wAOVilkXoa1t_zGg-1; Mon, 06 Dec 2021 16:25:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 15:25:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 15:25:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0024.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::37) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 15:25:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c67717dd-56a8-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638804342;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Kr0cj4QOEF2tnC3drtQqJd3HaRInyWKrIhu6JAJnMws=;
	b=NQAi48EX0b4KsyjD4oAFj0NuTxrUgKkciVAAvBlCUpMWfJ/ZT5JwBlENhrFpmUOBOTkC2C
	rMSWBSnQZlbxL8V8gN5a8r5jPQuKUogHyYHQLZIFPzsL8fiH73G6AfmlI1iKs9pHJz8FYm
	4sMtwua4l+g8YNFNEgqC0Wj+IpcLIhQ=
X-MC-Unique: 00e4U4wAOVilkXoa1t_zGg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DUJuk3mlGQSHSkuAwAspG1I4X9/TPv4gc3YW3IHaxk+PgRmQNE1EaxNdWF9tDgFzVWYXh45sKrKormgmNMEaDkSSsJkCFKfoViiQqDdyHPA0ulmrSP1MEsCSm0V7VcLbUa0kcbz+bdnuAt/Ly2NQuoVFZFe/JZ2ojX9i24U8oFcN2lY91qgGCuo0gtRbMXRsQFFa/2p3Po/7KK1Xc+AYzJ5I66wTPIuE1j+uWCC7N3kivWSeXvSD6R7lkVmXHAR6BuvJ/y45Hl4zSnkBadlEY14fNAzhZKiRVNzjOZmkQHp8OLRA4yRIxPz5ILTspHyRPEikPeUXkOVvkuwOO1yEvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kr0cj4QOEF2tnC3drtQqJd3HaRInyWKrIhu6JAJnMws=;
 b=KkBZ71fy2uK8RPvAlw9sq+MOPb2RKhXb1h6jYwStEgJgViOtb+d7WzLHI7Hf9celDyzFuTjk5qAvrE+0HCBUvvN1XQHgNSfZtZBmiAvLazSoyBTfKGLNOLNOypwoeKpdJxyApGWfuwCJjSxamHzAMXUF3wguu5YJB8xTIVCezSdTywc338vKFpwyB7dscocjhC8j0EsXurfKGahUSZGgfhR31qc/qMCZQKc03kbQz9bPJ8Kqatk8wL9Fzuklka07m5O42qC9zKlqsMg4x3Rc3zlMaeFDS0V7LtVw/2YLUnLcAvUvlbge7E/W1JO4LV17Do+lNtT8yOev6BWqC3WJ2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3a7c19ab-5454-fa04-f167-f94d56398b14@suse.com>
Date: Mon, 6 Dec 2021 16:25:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 03/12] libs/guest: allow fetching a specific CPUID leaf
 from a cpu policy
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-4-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-4-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0024.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:81::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0541e1cf-e823-4222-c290-08d9b8cca818
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191E10001099CBEA63D4FC5B36D9@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wRR9jZ3FnasPEQqBNNRJuh1LxNqolZfsamz7gQkYDQP06ASOXAoC9KP9alusRzoh14g606YzPDSsYPm6JLlXNfHQTrXj6U5J2T7g/s3yfdY+XWiSaLnLbT0kEqAvrk/sviqx/IE0+PoY9UScmICZjot5ADsYCb2aaDigtFR7aO471xRryymFbK3nyWU3o+tm1cn62xI2MjUqqu2H/OlQYrImswtilgNTW+wLJtNE/CJmiyECx/Ipxz7W6jfNgiEQvzWeiAKwn1fYOhHoL5pceMexdM6mnGFVxJSXUHbZIFcMySJsl7a+RXXrxl9wzp2ZqmE818FNmaFAJ4tJEAgsX2ljzloHwKM8/qggq7rQVv/+/GeUQdAHkaCoxQx15wSbYPVIhWpi7oJh+VYcTq01PmG0JiS9sy69Sx5ssHKOjUtU0ErKJ/B2Chm4DvA4wqhx440cEw88lSQFxQCiLwGQ+vCPrCVI9/8z0xcTrCcyNXZzN1SiCIdsDJYWy8d8G9mRl8J9/5qR7aCqsiEn8xFBFsfh+J/4q1/kXdqhk1wzFxu4YCD26w3dfFVsALRQHXdgG5wmctCLHZ334kY8pzN3lS58C0Rq1+Yu7BNj3/UHDK5CFB+jvn6qgew4QL0scUQ6C/bO0cw5yKY+gsoUiKM+7Y4Jl/ZDfjQ5qpFtp9h5pv4R+aPztTgSxzgZf/W28AzPldCVJ/ZVrTRRXq/Fz/gLHCTycfE9jhTjL3mAVQnosQ++vYxtkHsXe7foykfm/I52
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(5660300002)(66476007)(31696002)(316002)(66556008)(66946007)(508600001)(6916009)(31686004)(16576012)(186003)(26005)(2906002)(2616005)(8676002)(86362001)(6486002)(54906003)(38100700002)(956004)(8936002)(83380400001)(53546011)(36756003)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Nkh5blBXcE1lWENuZUhBSkE3UFdRSk44aDRJb3ZtWE1rdW9aN1U1NWlxb3R2?=
 =?utf-8?B?dnpKbkhyenl2dU9wQWVKbk4wNjhYaXQyeFMyWFBBZUswQ0MyTS9VSFpSWWIx?=
 =?utf-8?B?TXMwQzFtalRUQldoU3lDMy9CeXVwN2JsUmE1R1dTN3FWRUNFbVNYNFNOWVlw?=
 =?utf-8?B?aHhFL0t0TGN2TUFkamxHdEdOWkpVNGlBWlQ2eDIzcDRwNERzcytiNTE5N3cr?=
 =?utf-8?B?NnFvWEpZWGF2Q2RIWW1WSThFcEVlR2toQzA3bnhSWEhUcGNXUTRzZ21tNUxX?=
 =?utf-8?B?eVp4bXlJc2g3a1N6VkUySEg4MFltTHZQTXJuMFFtMWdaaXZFV1lsMjU3REZ5?=
 =?utf-8?B?aERnYjloUUVFM1ZnZ0IxU3k1aVlhbnFRbEZIQzd4c3JQdkkwS2ZOTUpGSHFD?=
 =?utf-8?B?bVpJTWk5bGtwM2ozK0pGTjZmem5mdysvWW8zY2pjMEwrQnl3alpMRFNSUXd5?=
 =?utf-8?B?RkVXampZS0cxdnAxcldIUUlzNDFmeDRselgzYldOcWVFMktnS0NXeENUcFNu?=
 =?utf-8?B?bXR2VUJ1T1A5YmpGUFZWLytjajcrSGx1cTZoaVNyd0ZMZDB5S3c0bGVjVnN5?=
 =?utf-8?B?U2tnQXlnUmw4R1drUGh0MjAzNFBoS0NOdEg2UVVPZUpUa1k4c0RqNGtyMDVs?=
 =?utf-8?B?VlN5Q3JsVmhtUE1JdldRQU5rbFlDU1N2TWFEM0FXanVra3JsK3pGNHV3emRo?=
 =?utf-8?B?bG9SdDZLVHJsZjAyWEtuQWN2cjVFTlJvMEpkajBiZVlUT2FaSThJeE44anli?=
 =?utf-8?B?QWMrNU11eTFDTFMvZkYyblFmenhETTRFajVmcDhPc3JXV1lwMDFIT1NpRXN6?=
 =?utf-8?B?Vld6cFlHQ2RMeUhNZmQ0Y1psVGpqU2RHS2VRRTZWazhZbWxhZzBOOEJqTHFr?=
 =?utf-8?B?Y3ovY0o1ZHRLTmJ1UTBoMytDWElRNGYvTFlQa1pqTjRQVjBLb256alZMRGUy?=
 =?utf-8?B?c2o0RFhKUjlRVEt6QW1GYmxnNFRkU2huWnI1WTRKY1dkZnVEYzhzdkV0Q2tG?=
 =?utf-8?B?QnpmS29qRVlCa3NsMGw1MlhuY3d0N2FEL0xyUUN5UE1lNzJ6aEkvOHNMZGZM?=
 =?utf-8?B?TUZCNVJnMmEzRVpRbjhKQW04d1ZsdnV6akpkczM5QnlHV3krQi92amlMK1Zl?=
 =?utf-8?B?ZHlkem84Q0o0V2lxazB0ZjNhOTArdzN5b3pDc3VuYkNBdHhOOTN6bWEvUjdD?=
 =?utf-8?B?V0Nqb3VsZWVlVTA2YTlEQjk0a0tQdk93SEJLVXNzZTg0bEJTYjJ1RDJPam1k?=
 =?utf-8?B?MmJjbUpNM08rOUNUS2hXNjErdU9TcGY3aGFHYit2Tm5FRWZGK1FySTBhRU9O?=
 =?utf-8?B?QUFpdFZpeU5yS2syY2FVZDFxOVV1dS9HYnFWbVlZS3psVlVveEYrZFI4RHBr?=
 =?utf-8?B?d2IwdTI5NklnMWRlR05DQ2xNcExjb0IxUzBiaHpBV2ViZ0RZWmZUd1hRQ1lr?=
 =?utf-8?B?ZnoxazJQN2FsSHc2UUVPcG1EckI2Q09vdkFHajd2RWttT0JKQ21abDFPVFVG?=
 =?utf-8?B?YkV3UmdUVXNSanAwUzJRNDdFci9kR2xpWTh3WE5xS2pWeVNCYUNoZ1l3d04z?=
 =?utf-8?B?WU1lcnpqWHlDZXhab1FRcFJXWUtHcEtPYVdSTUVFZEpKdUQ5ZnZId2s0Z3gx?=
 =?utf-8?B?a2tyWGxLcm80cDB5NlZvcUxKQXVxWWtoN2p4V2t4aEZ6cy80M1YrYjdPTWlU?=
 =?utf-8?B?TFlYc0R6Vzl2ZGpVbUFGckxoOEI5YW52NHpiMmNIekFMWGhPaSs2elowaXlP?=
 =?utf-8?B?YnR6aTVCeDBoT3NKK1ZELzlWL25xdlRMZHcwakhPQk1qbVQwZ21EamJWWGdX?=
 =?utf-8?B?Vm9Qd1hVYldJSVFEUDZ3eGIvb3ZWU1lGS3g5MlZtc1dWNkEwSG00TDltUWlD?=
 =?utf-8?B?bk9GZzdhMVV5Z2FPRU1yMTY2aGwxYmo0Y2JrbnVZdW9LZ00zV1kyOG95U3Jj?=
 =?utf-8?B?Tjc0ajRwblZQL1RhcW12aHM2VTkrMXgxM0s2Z1gvelp6UzBSOWdlTXpFVDN5?=
 =?utf-8?B?UzM0SnYwY3VvaG9jTmE1Q2p0MndUUXkySUNvZ0JWaGc1b1A1WDhMaEx4T3lr?=
 =?utf-8?B?WFFVTG9HYWFLWVg2WXcwZEl6enNUUjBEbHl4YWxZVDVoSHloUUo1bEw2cTZp?=
 =?utf-8?B?cjAyOEM1MFphT1NQeTFIdXMzNWdjWkRYVzMxaGxMNHNlKzdzNG14Wmp4SjAr?=
 =?utf-8?Q?2xmk85DyKwAPyZx+QABG0NY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0541e1cf-e823-4222-c290-08d9b8cca818
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 15:25:38.4428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: awcX5RBszEhgkn29Ys+oEz5JBzKRqhfUeWd4q1OZqm9OQOGs9XqaYtso5x1XUdCFjvFhPHGb8cj08YsFPsKTLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

On 29.11.2021 16:33, Roger Pau Monne wrote:
> Introduce an interface that returns a specific leaf/subleaf from a cpu
> policy in xen_cpuid_leaf_t format.
> 
> This is useful to callers can peek data from the opaque
> xc_cpu_policy_t type.
> 
> No caller of the interface introduced on this patch.
> 
> Note that callers of find_leaf need to be slightly adjusted to use the
> new helper parameters.

Is this sentence a leftover from an earlier version? I can't associate
it with anything.

> --- a/tools/libs/guest/xg_cpuid_x86.c
> +++ b/tools/libs/guest/xg_cpuid_x86.c
> @@ -855,6 +855,29 @@ int xc_cpu_policy_update_msrs(xc_interface *xch, xc_cpu_policy_t *policy,
>      return rc;
>  }
>  
> +int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t *policy,
> +                            uint32_t leaf, uint32_t subleaf,
> +                            xen_cpuid_leaf_t *out)

Is it common practice in libxc / libxg to have xch parameters even if
they're unused?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:27:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:27:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239261.414700 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFtu-0007VO-Jt; Mon, 06 Dec 2021 15:27:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239261.414700; Mon, 06 Dec 2021 15:27:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFtu-0007Up-Ee; Mon, 06 Dec 2021 15:27:34 +0000
Received: by outflank-mailman (input) for mailman id 239261;
 Mon, 06 Dec 2021 15:27:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muFtt-0007TJ-M8
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:27:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0800910b-56a9-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 16:27:32 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-rF03TJFyOz644Z6HbyGtMA-1; Mon, 06 Dec 2021 16:27:31 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Mon, 6 Dec
 2021 15:27:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 15:27:27 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0017.eurprd06.prod.outlook.com (2603:10a6:20b:462::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend
 Transport; Mon, 6 Dec 2021 15:27:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0800910b-56a9-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638804452;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1BNddKplu6/hbDUq0SSdInku9dxv92u8Dvp6sZ+8eYg=;
	b=nHlpHUAewM9FXqffojyBteiv48uvUvRUNrKbDGO5cpSHqFcQI2zegsU1WAcE1TF7xW2Sz2
	o1neWmx7ijFNlYFbsUKvx9UF+D/jBjkrT1hTiTwqawwunTPGbwHg++TE/gGldBEuP9FS1d
	jHlWUKBSNvU2JDvqnb2bfMrS+Qya084=
X-MC-Unique: rF03TJFyOz644Z6HbyGtMA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ao5Ewfm5gi0L3XIVRO68MjZb03Js4ejeb8MXWExKyxclWW4MMg+yrSIUP7gSjtKqIiqi9eT8AdNeQkDEVjhklv7JImydcOxbZPESSQqK0nJ/4AtuN7cCoyf8QtFhymAEs5/TtfllAPW+085UCpm3jKwr1LeudJreQZF2nJKa30PD6e/rdyfXUcZadabZqurXewUJ44lnn7cEu84RlT1jZLYJrzOj4ReejsF3EvvRDSoAGAr2buahQS5PfKQ58ZfILQi4S9EykbnUfzsp1UEiR6153V7ODwTbKw+XYcSDYOnb+0cUuiTsxMziMCVctOcZX0MTsB0QYNu2FZz9GSXH5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1BNddKplu6/hbDUq0SSdInku9dxv92u8Dvp6sZ+8eYg=;
 b=HcHalbZBaV5FqLXasUY2K5xiylQbZM78i9uW7y3VQvBIcCthaoJEGX5IMGOAO3605cRBHPsDgY4C83ODQ9gauBxBIwQUveJ8zDLoT/eSAell1sTXxlzsvtXBWxTK9hAQkCRYHf3z/CwZeoNCff/UXAa5lBpDVmBBH+aL2WFSC0vf8Xucu9FTLH2HoL1umxawD0CSM/eENMl6OjqtgPXj352zzCNOnBh/p397rjrMpPm2n4vo59LM633ocBIBl8JUvF6DPdjq554SKW9D0YlxpGsl2MDLW3uBz2NiK0YWNsEeRwMPTlzO8NZKIwkBfB1tG8j4r5JNw9P+u/3CXhcY7w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f7c427b9-2564-dc0a-d03d-411df83ba9c8@suse.com>
Date: Mon, 6 Dec 2021 16:27:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 05/12] libs/guest: allow fetching a specific MSR entry
 from a cpu policy
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-6-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-6-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0017.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 95f40b7f-c45c-482c-fd87-08d9b8cce8c0
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB435284ADE062E3786BACBB57B36D9@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rjZ/dztHeom6tZCKZE6zIwbCVOn1u+o4VkOiu4DKmFt7aXaa6rI5kHcKjVL8KfGhQNlIsVH4AUvSbDRqcaD9Mx8a3GKMHf6HBgwfdmuUd5Nzels/i1xHESXFeixz6S+wE9SwbDW/GhIgSS+LHMvJqtOYC6MG23JaRmbuZ1XVtCpOThVuXxAwCk1kR5sJpdPv4G9KOug2OUYy72erjez6ND+ae2Hhz+JhCEZ+O4P1nuvfSv8//EJzvagPjOaVn2E8oz73xFy07D1xNwJP7S3CZj2rmhauojiSOPgZdgbJRjOsM1Eag0fxziVsF91HRQ7fDDvnjmhnfQ27qb/yhtFfnvJTS6ECWD1TeerYL8eQksgu8mKNFktQLPQCfLC579OCZOuC4LWeUOpoyjKYJLzj2Wl/xsYOyYeMdO4Gk8iYiJOFYeziwSknuF5vmihRDijXnwpLVwSbYsHteR6uBxFd+apOkcaNIaS0x7iEedtTGYHsh9QL+SeEcmHXhtjB8HYw/Kl4fnPoJBZbuhhOU1UHK+075DE9qHRuh04sOv2nKaqfc8AFToEVmaFZv/d4+xSKEBdyXLbN5Q7B6O/QR5vAD4HizUX7lOLW+mig8qkdj0UZSi3IhLa9QtlXmsyk16uWSPf4aBRkCi1jFGc+0e5IkUUbljXvQ885gfGVEKBNXdqh3kk9NYTRv33RJhSN4IjmRk++pmPxCpDJYG4EihxWOQO01wibZTx99c4am+M21WI9yx8dpr2WoRPm8aeEXhm6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(4744005)(316002)(16576012)(31686004)(8676002)(5660300002)(8936002)(54906003)(6486002)(66476007)(66556008)(66946007)(31696002)(36756003)(4326008)(6916009)(26005)(956004)(2616005)(38100700002)(2906002)(186003)(86362001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dU0ySlpZYTQweUNJR0JsaHdXYXJkWlVqbVZFOVRGKzZrVnBvbHN4TWwxRjFp?=
 =?utf-8?B?TUJGdkJHMEkrNWRWaVNsY05EVlRMSFNOVWlzMmNHZGFRWldPN2pBN3BIYytZ?=
 =?utf-8?B?VDFTdVFPc2QvWHIrWG9IOG0vUGorMmRxcFlvZUdOQjVuLzZ3eFBFdkNBUXpN?=
 =?utf-8?B?YUNKWWI1aDZRT2o0WSs2Vit2REFqS09vUlllQUJXbWVQU2RnYUNBZ0ZIaXRX?=
 =?utf-8?B?dGsxNFVwamZ3NkRHRzk2R2FTNlJ2QTJsbEtmWm5DcUxxWC9RMUlWVjFNMU1F?=
 =?utf-8?B?ZTZYMzNCR1QvNitINEwyOVlUWG1RbFF2dHlwZzZNR2pHT0lqTHEvSnpYckxp?=
 =?utf-8?B?STFOcWRpbUNqTWorcTRrOWwrWVp4ZmJqVUNKRTVRRG4wdXJ5bjNKaHEwK1pv?=
 =?utf-8?B?QkVFVDF3Q2U5T0FnYzg0VXNwRDhtbmdZVDVqRnFCQk9HWExEaG5CbS9YTzds?=
 =?utf-8?B?OTJoRGlmTmozcFlGM2Y5dzRlQWo4alZZVUVhMDRoV0lVMGVYUzY0UVVHdDVK?=
 =?utf-8?B?ckJVZDdpWjYzOVZwVmdwVmF4Vlc5U3dBTS9rd1Y0M2VqUzlDdlFGbi9ud2Zp?=
 =?utf-8?B?ZU1aNWZMQlpRbEczaXBiWndvdTNoVE1VY1ZJSmxlTEgvK3pacm1KVFE0alFR?=
 =?utf-8?B?SkZCck9aU3VtdE9TWGF5azJnQjNJVHpyYzh3d25hWXRQd0ZIcG9iTG1keFFR?=
 =?utf-8?B?VU9oWlFPYzdCbElFOUVDQ0dzOGV1eVE1UXFKRC9TZGRZYzRhOUVkTThRaG81?=
 =?utf-8?B?ZXYvMnp1Q1lPUWN2dVJMeUxjTW11RlFLUG5HWEZsT2xGOHNiT0hIMmd0Slpv?=
 =?utf-8?B?WXRWOUliNVFDVklCSVVDUC9hWUl2VDNtRzdWS2UxTTlrVkFjRkx0L2F1dHdi?=
 =?utf-8?B?TU5UcC93bzlmTVFETmtPYjRwM1prbTE3ZFUvVWowY3Y3WGxXRWR2N3VxSzFM?=
 =?utf-8?B?cUROdFZQTGhsQ0RxV00yTk5JMjRiaFVPNUxId1NoWWQ5eUNpdGhMVDNUdEFQ?=
 =?utf-8?B?ODN2MXRZbFA3cmtubzMzVTREVFhNZlVTU0dSWUNYdmNrYi9KVDlzMmhrOXhr?=
 =?utf-8?B?dHUvMUNDTmtZZWdOamw3aG9pbmhUVVExT2N1SzNzQ2h2eXh6QUYrVlJaY1lW?=
 =?utf-8?B?OFFidUFMNlpTallLdkZYTVF5T0wybzJnMDU0UzA3K24rWnhZSndKVUkwdVU0?=
 =?utf-8?B?VmlDdkxheVdYcEh6M2FBUzJTTTJocGlZUHVnRUFmbDlzWFNnTUFvRi84TmIz?=
 =?utf-8?B?ODN1R2laOEE0UXhIV3VUZnJ3N242TGNPcEhzbEJDZyt2WEEzT2xiM3BIRWx4?=
 =?utf-8?B?dEdFRmNKUnRPYjhqeXYzNkZNdWovanY1Nm9neU9QYk9obnBUVDNJZ3RNY3JL?=
 =?utf-8?B?ZXczZGRJVFcycnhIdWFDc1pVbElyRjRoaTlpZjljYjE0dE1MQWlzLzMyQlhk?=
 =?utf-8?B?dEhNRG1DQTdKaHpmSS8xVzEzUkVEcmVGMExza3R4WGp3OWVTL0hwWHU1RzV1?=
 =?utf-8?B?c3BYVlFrUFh2bUVYenhvbnZHem1rLzIxQTNEb0h4UGNGV1lESFFrMUFiTHVD?=
 =?utf-8?B?R0t0VlBibGpuc2hXaTFGcVZKY2JoaFBvWktyWWN2cVc0TjhIREFXMGVmdnNV?=
 =?utf-8?B?aGJVSk9MMFVucWlyNnpOaEdlQi9WeTAyM3o3MVR0TmdLSEcxV29QSmg5ekI5?=
 =?utf-8?B?NSsyMy9VY0IxQTlxZ1MyMWtVUG9WUTY3aGFCY0NEeXgrRDNtUVVuSlM4M0Ro?=
 =?utf-8?B?RElwNWVtcmI2aUpBVE9kYVNxNEh1d1YrZDJnbmxXNzR3Z1hoZkQvRldtdUV1?=
 =?utf-8?B?aE12c041cTlzVmZSTHRnMzFpZDIrRjhxUGUrRUJyT2Q4V2R3ZXc0d3l3VFlQ?=
 =?utf-8?B?aXpUNGwyNGpJYjRHSGRDb0NCbkM1KzFiM2ZiTWNyem54NlBVRGpwTUYvUkha?=
 =?utf-8?B?RWg4T3Q1NmhyZ3l3b2JUSGVmbUVzYkNNenVEUlQxZ2JyNElEK3VNdmU1OUJJ?=
 =?utf-8?B?WVBjdWE3R2l4dGNoK2hjM3E1dS9OQWtpQjF0NWtENkxBbzBwcHlZeUNGWXZF?=
 =?utf-8?B?RWtoOWVybE54Y2pBS0NyUWkvZ2htZk00L01xWEEvT3RmQW4rYTA5Q2YwTzJm?=
 =?utf-8?B?N2tyclVHUDFIbmFSSkpvMXBMK2hzM3A4Z2ZzNmtTY0tZbGdoM2dCcXNZOEYr?=
 =?utf-8?Q?nxvrWADDI3AB36VbRt0l2N0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95f40b7f-c45c-482c-fd87-08d9b8cce8c0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 15:27:26.9575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fruIy0SWNJYQ+hhvt5KCBqaoLh3ymNeWsXGdT6OfSjVbDFGzhW04yiBazAML77/5KRud24KGuCngXef6jE90Ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 29.11.2021 16:33, Roger Pau Monne wrote:
> --- a/tools/libs/guest/xg_cpuid_x86.c
> +++ b/tools/libs/guest/xg_cpuid_x86.c
> @@ -878,6 +878,26 @@ int xc_cpu_policy_get_cpuid(xc_interface *xch, const xc_cpu_policy_t *policy,
>      return 0;
>  }
>  
> +int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t *policy,
> +                          uint32_t msr, xen_msr_entry_t *out)
> +{
> +    const uint64_t *val;
> +
> +    *out = (xen_msr_entry_t){};

Unless there's a specific reason for the divergence, this just-in-
case initialization should imo be consistently there (or absent)
in both the MSR and the CPUID function.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:29:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239269.414711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFvP-00088n-TL; Mon, 06 Dec 2021 15:29:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239269.414711; Mon, 06 Dec 2021 15:29:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muFvP-00088g-QD; Mon, 06 Dec 2021 15:29:07 +0000
Received: by outflank-mailman (input) for mailman id 239269;
 Mon, 06 Dec 2021 15:29:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muFvP-00088X-2p
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:29:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muFvO-0008SL-OC; Mon, 06 Dec 2021 15:29:06 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muFvO-00020i-Ht; Mon, 06 Dec 2021 15:29:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mjMkyOsjAWmAU2prdmFj4WRlyZ99pmfYcBSAbMD3GbA=; b=QvXd8s8ViicGDQvsaNS/p6XmVi
	m6YhTMMnv7efRBsIJ8wMy8+3CEbYMyojFIJ0zAJqN6xryIeT0NargqkpiI1iSbn7thrBJ/AUO/Gyd
	58OvWhYAmHRwG1DROzyK2XmLq6Ot5cYHpwnp8NUosbxRuoHAQpOg3ydAkMAKOP/Z+J5c=;
Message-ID: <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
Date: Mon, 6 Dec 2021 15:29:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206142032.27536-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211206142032.27536-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 06/12/2021 14:20, Michal Orzel wrote:
> to hypervisor when switching to AArch32 state.
> 
> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
> "If the general-purpose register was accessible from AArch32 state the
> upper 32 bits either become zero, or hold the value that the same
> architectural register held before any AArch32 execution.
> The choice between these two options is IMPLEMENTATIONDEFINED"

Typo: Missing space between IMPLEMENTATION and DEFINED.

> 
> Currently Xen does not ensure that the top 32 bits are zeroed and this
> needs to be fixed.

Can you outline why this is a problem and why we need to protect? IIRC, 
the main concern is Xen may misinterpret what the guest requested but we 
are not concerned about Xen using wrong value.

> 
> Fix this bug by zeroing the upper 32 bits of these registers on an
> entry to hypervisor when switching to AArch32 state.
> 
> Set default value of parameter compat of macro entry to 0 (AArch64 mode
> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
> when not passed.

Which error do you see otherwise? Is it a compilation error?

> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>   xen/arch/arm/arm64/entry.S | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
> index fc3811ad0a..d364128175 100644
> --- a/xen/arch/arm/arm64/entry.S
> +++ b/xen/arch/arm/arm64/entry.S
> @@ -109,8 +109,16 @@
>    * If 0, we rely on the on x0/x1 to have been saved at the correct
>    * position on the stack before.
>    */
> -        .macro  entry, hyp, compat, save_x0_x1=1
> +        .macro  entry, hyp, compat=0, save_x0_x1=1
>           sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
> +
> +        /* Zero the upper 32 bits of the registers when switching to AArch32 */
> +        .if \compat == 1      /* AArch32 mode */
> +        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
> +        mov w\nr, w\nr
> +        .endr
> +        .endif

So Jan mentioned, the x0/x1 may have already been saved. So you may need 
to fetch them from the stack and then clobber the top 32-bit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:37:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:37:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239287.414742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG3M-0001fc-Us; Mon, 06 Dec 2021 15:37:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239287.414742; Mon, 06 Dec 2021 15:37:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG3M-0001fV-QJ; Mon, 06 Dec 2021 15:37:20 +0000
Received: by outflank-mailman (input) for mailman id 239287;
 Mon, 06 Dec 2021 15:37:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j7EA=QX=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1muG3K-0001Ov-Sf
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:37:18 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 6470d889-56aa-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 16:37:17 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB0281042;
 Mon,  6 Dec 2021 07:37:16 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D8463F5A1;
 Mon,  6 Dec 2021 07:37:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6470d889-56aa-11ec-a5e1-b9374ead2679
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] arm/efi: Handle Xen bootargs from both xen.cfg and DT
Date: Mon,  6 Dec 2021 15:36:58 +0000
Message-Id: <20211206153658.49727-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Currently the Xen UEFI stub can accept Xen boot arguments from
the Xen configuration file using the "options=" keyword, but also
directly from the device tree specifying xen,xen-bootargs
property.

When the configuration file is used, device tree boot arguments
are ignored and overwritten even if the keyword "options=" is
not used.

This patch handle this case, if xen,xen-bootargs is found in the
device tree, it is used for xen boot arguments regardless they
are specified in the Xen configuration file or not.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 docs/misc/efi.pandoc        | 4 ++++
 xen/arch/arm/efi/efi-boot.h | 7 +++++++
 2 files changed, 11 insertions(+)

diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index abafb3452758..b7d99de87f15 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -249,6 +249,10 @@ UEFI stub for module loading.
 When adding DomU modules to device tree, also add the property
 xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
 Otherwise, Xen will skip the config file and rely on device tree alone.
+When using the Xen configuration file in conjunction with the device tree, you
+can specify the Xen boot arguments in the configuration file with the "options="
+keyword or in the device tree with the "xen,xen-bootargs" property, but be
+aware that a device tree value has a precedence over the configuration file.
 
 Example 1 of how to boot a true dom0less configuration:
 
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index c4ed41284597..fc1f2b9ad60e 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -497,6 +497,13 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name,
     if ( chosen < 0 )
         blexit(L"Unable to find chosen node");
 
+    /* If xen,bootargs is found in /chosen, use it for Xen */
+    if ( fdt_get_property(fdt, chosen, "xen,xen-bootargs", NULL) )
+    {
+        PrintStr(L"Using Xen boot arguments from device tree.\r\n");
+        return;
+    }
+
     status = efi_bs->AllocatePool(EfiBootServicesData, EFI_PAGE_SIZE, (void **)&buf);
     if ( EFI_ERROR(status) )
         PrintErrMesg(L"Unable to allocate string buffer", status);
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:37:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:37:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239288.414753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG3i-0002AX-5n; Mon, 06 Dec 2021 15:37:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239288.414753; Mon, 06 Dec 2021 15:37:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG3i-0002AQ-2C; Mon, 06 Dec 2021 15:37:42 +0000
Received: by outflank-mailman (input) for mailman id 239288;
 Mon, 06 Dec 2021 15:37:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=j7EA=QX=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1muG3g-0001Ov-QN
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:37:40 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 71f35000-56aa-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 16:37:40 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6BBBF1042;
 Mon,  6 Dec 2021 07:37:39 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8691E3F5A1;
 Mon,  6 Dec 2021 07:37:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 71f35000-56aa-11ec-a5e1-b9374ead2679
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
Date: Mon,  6 Dec 2021 15:37:30 +0000
Message-Id: <20211206153730.49791-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Currently the maximum number of memory banks is fixed to
128, but on some new platforms that have a large amount
of memory, this value is not enough and prevents Xen
from booting.

Create a Kconfig parameter to set the value, by default
128.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/arch/arm/Kconfig        | 8 ++++++++
 xen/include/asm-arm/setup.h | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4d3..805e3c417e89 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -25,6 +25,14 @@ menu "Architecture Features"
 
 source "arch/Kconfig"
 
+config MEM_BANKS
+	int "Maximum number of memory banks."
+	default "128"
+	help
+	  Controls the build-time size memory bank array.
+	  It is the upper bound of the number of logical entities describing
+	  the memory.
+
 config ACPI
 	bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED
 	depends on ARM_64
diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index 95da0b7ab9cd..785a8fe81450 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -6,7 +6,7 @@
 #define MIN_FDT_ALIGN 8
 #define MAX_FDT_SIZE SZ_2M
 
-#define NR_MEM_BANKS 128
+#define NR_MEM_BANKS CONFIG_MEM_BANKS
 
 #define MAX_MODULES 32 /* Current maximum useful modules */
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:41:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:41:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239296.414763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG6t-0003cQ-KI; Mon, 06 Dec 2021 15:40:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239296.414763; Mon, 06 Dec 2021 15:40:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muG6t-0003cJ-HG; Mon, 06 Dec 2021 15:40:59 +0000
Received: by outflank-mailman (input) for mailman id 239296;
 Mon, 06 Dec 2021 15:40:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muG6t-0003cD-4T
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:40:59 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7ebeb79-56aa-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 16:40:58 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35444)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muG6o-000NXy-6z (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 15:40:54 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id ACFE01FC17;
 Mon,  6 Dec 2021 15:40:53 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7ebeb79-56aa-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <88d03de3-587c-c5e5-3e36-975bd5994503@srcf.net>
Date: Mon, 6 Dec 2021 15:40:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
Content-Language: en-GB
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211206153730.49791-1-luca.fancellu@arm.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206153730.49791-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 15:37, Luca Fancellu wrote:
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..785a8fe81450 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -6,7 +6,7 @@
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
>  
> -#define NR_MEM_BANKS 128
> +#define NR_MEM_BANKS CONFIG_MEM_BANKS

$ git grep -wc NR_MEM_BANKS
arch/arm/bootfdt.c:1
arch/arm/domain_build.c:5
arch/arm/efi/efi-boot.h:3
include/asm-arm/setup.h:2

For this few instances, it is probably better to use CONFIG_MEM_BANKS
everywhere, rather than add the level of indirection.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 15:48:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 15:48:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239306.414775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGEJ-0004aO-Cy; Mon, 06 Dec 2021 15:48:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239306.414775; Mon, 06 Dec 2021 15:48:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGEJ-0004aH-A2; Mon, 06 Dec 2021 15:48:39 +0000
Received: by outflank-mailman (input) for mailman id 239306;
 Mon, 06 Dec 2021 15:48:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muGEH-0004aB-Qe
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:48:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muGEH-0000Nw-Pb
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:48:37 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muGEH-0003hD-Oa
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 15:48:37 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muGEB-0000y1-5c; Mon, 06 Dec 2021 15:48:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Subject:CC:To:Date:Message-ID:
	Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=HTFMcRpkPvbbZQwmTP1v/lYud0gS38QzmjK5LvTmuzw=; b=hXVrkuWi7fcsj7QLJc1iqfP+if
	wDhypv7yR4qNaCnsO4/ETdu/+0PJddH1EEo5V+dAsfCJRvJpRDOWZnFc6ax/raQ16JXX9xs5HcBiD
	AXdIwnuZSXtAvJghgWELfgWicVu387qgJk2vJw6ukHzY0AGBMvs1H17eV+Kpsx3E984g=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25006.12472.636170.668786@mariner.uk.xensource.com>
Date: Mon, 6 Dec 2021 15:48:08 +0000
To: xen-devel@lists.xenproject.org,
CC: committers@xenproject.org,
    Jan Beulich <jbeulich@suse.com>
Subject: Xen staging-4.16 branch now open
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Ian Jackson writes ("Xen 4.16 is released"):
> Xen 4.16, the product of 9 months' work by the Xen Project community,
> is now released.

I have now done the administrivia to staging-4.16 and it is open for
backports according to the usual protocol.

Ian.


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:06:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:06:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239317.414798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGVV-0007o6-VE; Mon, 06 Dec 2021 16:06:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239317.414798; Mon, 06 Dec 2021 16:06:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGVV-0007nz-SF; Mon, 06 Dec 2021 16:06:25 +0000
Received: by outflank-mailman (input) for mailman id 239317;
 Mon, 06 Dec 2021 16:06:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muGVU-0007nt-N3
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:06:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGVR-0001Fa-OW; Mon, 06 Dec 2021 16:06:21 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGVR-000547-IH; Mon, 06 Dec 2021 16:06:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=pEWNCCOIQ/yHyd2fjQMSx0RUaWOVqXiAU4E4rFbgIOE=; b=1egXWtbdRqL9TadHu1VZwoNwiL
	hKFWZRI+7uKf/yYEbgWV2PpAj37H+t/4gva3pMdzgIYthIucPOnnRLcpB3V09gxgueNc0hYtSrMme
	wiXqHwo/Xoy/JbifD6N/omAeRdgnTiqcofNN5jsjfHfcvwb3fAr0SZKXcfcKxMt0wF1E=;
Message-ID: <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
Date: Mon, 6 Dec 2021 16:06:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 06/12/2021 15:06, Jan Beulich wrote:
> On 06.12.2021 15:28, Julien Grall wrote:
>> On 06/12/2021 13:44, Jan Beulich wrote:
>>> On 26.11.2021 13:52, Ian Jackson wrote:
>>>> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>>>>> On 26.11.2021 11:04, Julien Grall wrote:
>>>>>> For this case, you provided some sort of an explanation but so far, I am
>>>>>> still waiting for a link to confirm that the signed-off-by match the one
>>>>>> on the ML.
>>>>>
>>>>> I haven't been able to easily find a mail archive holding this patch.
>>>>
>>>> I 100% agree with Julien on all points in this thread.
>>>>
>>>> Please can we keep the Linux S-o-b.
>>>>
>>>> Note that S-o-b is not a chain of *approval* (whose relevance to us is
>>>> debateable) but but a chain of *custody and transmission* for
>>>> copyright/licence/gdpr purposes.  That latter chain is hightly
>>>> relevant to us.
>>>>
>>>> All such S-o-b should be retained.
>>>>
>>>> Of course if you got the patch somewhere other than the Linux commit,
>>>> then the chain of custody doesn't pass through the Linux commit.  But
>>>> in that case I expect you to be able to say where you got it.
>>>
>>> I've submitted v2 with S-o-b restored as far as necessary to meet this
>>> requirement. I did not restore all of them, because I continue to not
>>> see the value of retaining them. You saying "is highly relevant to us"
>>> is a statement, but not an explanation of why tags beyond those in the
>>> original submissions need retaining.
>>>
>>> Without me seeing the need / value, I'm afraid I see only two ways
>>> forward: Either things are acceptable as they are now (and will be for
>>> future similar imports), or it needs to be someone else to put time
>>> into spotting and then pulling in such changes.
>>
>> I am a bit confused how this would require more time. They are already
>> in the commit message from Linus's git and you have a correct commit id.
>> So this is merely a copy/paste.
> 
> I didn't say "more time", did I?
This seemed to be implied by asking someone else to do it.

> What I did (indirectly) say is that for
> areas like this one it looks like I'm the only one to check at least
> every once in a while. This has been working straightforwardly in the
> past, but is now suddenly causing issues. 

It is quite possible that this may have splipped in the previous review 
I have done. But now that I noticed it, I would like to confirm the 
signed-off-by was carried correctly.

> And as indicated - if I would
> understand the importance of tags which got mechanically added on the
> way of flowing into Linux, I would likely be willing to give up my
> position of viewing such extra tags as more getting in the way than
> being helpful (much like I would always strip Cc: tags before committing,
> as I firmly believe they have no place in the repo). But such an
> explanation hasn't been given so far.
The problem is how a reviewer can verify you did carry the tags properly 
when porting?

I agree that with the copy/paste, we may add mechanical tags. But it is 
reducing the effort for both the reviewer as they only need to check 
against the commit.

>> I am not going to ack it but I am also not going to Nack it if another
>> maintainer agrees with your approach.
> 
> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
> I'm now in a position to put this in with Luca's R-b.

 From the check-in policy section in MAINTAINERS:

4. There must be no "open" objections.

So I think this cannot be check-in given two maintainers disagree on the 
approach. That said, as I wrote earlier my condition for not Nacking is 
another maintainer agree with your approach.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:09:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:09:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239326.414809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGYr-0000LE-IH; Mon, 06 Dec 2021 16:09:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239326.414809; Mon, 06 Dec 2021 16:09:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGYr-0000L3-F0; Mon, 06 Dec 2021 16:09:53 +0000
Received: by outflank-mailman (input) for mailman id 239326;
 Mon, 06 Dec 2021 16:09:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muGYq-0000Kx-6R
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:09:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0dd389e-56ae-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 17:09:50 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-rt8v_X88P3aRRumxyH_ncQ-1; Mon, 06 Dec 2021 17:09:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 16:09:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:09:45 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0205.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Mon, 6 Dec 2021 16:09:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0dd389e-56ae-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638806990;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gwHfPBo0d9s7C8a5NxcBva7KOBPhUBVBC5hZqQePnWw=;
	b=UhYnAaT+q2xeP10/ElDsPoUI/sCPTeHJYQMqbIHnVMZ4qzHf6393kwpUH6QJffJszAY67Z
	o/4KPguijiae65ItoR7oqSqvolqfkcbcUcIleNHVIYrm/0klPt3OSOvBK+p/rIznjv11m5
	w0wC6oPrR3GIT3ocErF+/PDYHWyxw00=
X-MC-Unique: rt8v_X88P3aRRumxyH_ncQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bzD7jXEKwiy63JldO5/gySVXtRt5PyAflI3FeUarfG3LrrpSqz3zn1tsKOktgifJjay7Nyq8hp2wnxshOn0COPvhOPG8kox1JR47SFqwPCMUPsj5/knLn3wuzIgmtddJqKoPG15POAqcZC/9htEnOgVq1zCpwE8+XEDPDa9RQooxH975arVs9T9N10JaCgTY8Ba1Wy90WMnJqPQZ4KhzBdSviUbuECJ0wEzTNvWVZ5J5pomzNKzmemqY2EFvWnlsbDXnZo3JbXBe89SxDgJnf6nDqZy6T+R4IgKHOcv2QzQ6pY6ha5aFwp/5u2l6C7tA9+0jUtz4ydlEdh2i0BPMVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gwHfPBo0d9s7C8a5NxcBva7KOBPhUBVBC5hZqQePnWw=;
 b=aG6eRdUeCMf19CYui0RhZQCqM6JMyQeUy5VYLlF3gQqVmsEwCk+3c/m9PJqw7AIl5WDU2ZvCh88B7+TlXqA32O3t5mBF5m252CNoDTrXxsx8DNcGOIt4XGt9jXQnG736oJJGK96vDu4IjABHJVxuRqqMlllrvp4VtTgOk86y+C7g/0gyF/nM0vlaEuI5dl3xC64iSrLvh0Qik6PQwCl55iYVajCgRUqtWvkJaHsqD9jmcC+SsG5DMd1qrPuvSsVqKEN4X2OaDIm9lhNUxDrl1H9oSgU9ixgfdqTO4MRnTdl7WIGDzwplV2PcpJZODx1gzO0j7L3fJsu29PcqfOJarA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <205f13b4-6f2e-7937-7fc9-f1ce7082ae3f@suse.com>
Date: Mon, 6 Dec 2021 17:09:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 07/12] libs/guest: introduce helper set cpu topology in
 cpu policy
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-8-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-8-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0205.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3008af30-0e6a-4e84-d29e-08d9b8d2d208
X-MS-TrafficTypeDiagnostic: VI1PR04MB4382:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4382F4C6AEA4EC8047048205B36D9@VI1PR04MB4382.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1227;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gOvPwJvmKh/sTLyVQNtDU/azKZ95gZ8DUrPQcIMd6jGlcWOh9jZJo5V+1PXcuE0P1TI45RiYgwDNC63z5lxFPHvBOu4++yETgqlXtw6cmw/OOe/WVz7y0rPwCJQsqp5P/AI26IjYyUOAQ44dgyxlDzqoHGaSDqlsJQxFl5NrUfyoNGFEB6fqLt8Xrojp3IZMIzbb1qpE2c2KJlV++B65dWrhUYU8HnvMBuzPiBHrlo7Lii2AqcslumLVqKo+l1ZIu6r61JriPf21zG9ohca4sFFPPrwu0u8HPXDfnNFtWKHIPqvgEC3bZUBxtIbQaFwhJW2opqH9n0q5MPaL7qydnDglV50G/MblmDNQoJ920lkOg2lIAQ12S7A4y0rYB0pGZnIflnE+XIONdcY1tt3DKxDlf1Tqi+K1yhpMcpb26qTbhuN/mgozI/AutpefQzZem7TejHm0FvH7bvvEWCvpVik+PawcBiwcnJBU/OV2kGTALWY3L+24EqgVst9vG1QdVWpM3Kyr81X3Kxx7zo6PctN90bWe0qOhyeX0w4AIcTbdnt+xw5akL1U/F75LCsEdNaA2YhsuNINo51wt4zw+7d3vg/ilqtoxtHF1fyw+mnpy1ku8/tASeQYmfvJyAmNmTsixWGzouFI4v/DhtOPndt+DJmNhh9xbMt35lsWFsL/YpMP51WT2EANuzXhKCHvghdySUcBm6SilqZYZoRfAVlwBN3YYnGEGFcts50kSLE0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(38100700002)(956004)(86362001)(5660300002)(54906003)(6666004)(31686004)(6916009)(16576012)(2616005)(316002)(31696002)(4326008)(66556008)(6486002)(36756003)(508600001)(53546011)(83380400001)(66476007)(2906002)(26005)(8676002)(186003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0dxWHhzQm4zbStVUTNsZS8xa1ZpT1loZkV2VE1kcmdIWkttWVF5UHp3bmNu?=
 =?utf-8?B?MnJrM0cvOWljRnlxWVBZbjhjbkFZTGNseGVkMXZIa0lPMElJdmc2SGRYSlpH?=
 =?utf-8?B?dUlCcFpNMXFGbEdhYS8ySjNxMDBlWWwwUE91L3RCbUtxblNFOGtiVSswRVU0?=
 =?utf-8?B?WmxMZ3dJZEptY1dwZDBqQVBFcithQm5NY0tkNThvM3JGMjRiU1lCOUk0Zit5?=
 =?utf-8?B?OU85V25rR3BhQVVtK0ROMHcrMlArNmZzMCthb3N3Z08xaEYzekFNcUpGdnB1?=
 =?utf-8?B?anN6dW9yNnNJcGRVMDVKL200a0gwRUx1anpWREoyMU9LeWtmblpJVHFyQWRI?=
 =?utf-8?B?RnkreXJFWXZKWG5QalNFYnBZb29OOGY5cWQ2Yy9qRmRWMW45TGZ2ZDlwVmM3?=
 =?utf-8?B?bXBua0wxYTduVzY0ZFV1VUdvRUh2cFZjOXZnZE1oVkNhMVJFaUlMa2dWVUM5?=
 =?utf-8?B?YlMzbFdMMkk0aWtFNTc2SmIxNVlLV0taWEFXRmVQY3QxMjJwaEJoeEkvK2dR?=
 =?utf-8?B?ZStkWWs2djRmcHFNQnJMM0V4U0pPd1NHZFFlaEJaYzNVMzg1aXh5Z1RYNHZx?=
 =?utf-8?B?ZGV1d0syalFWNVAvT003N1JyQWNIemFTMFVCQ01uTnhwNGlsd1lnYjVTQjNr?=
 =?utf-8?B?Rjk1cjNvQVFOME9xSHU3aUdYSmpOU2dwZ2VibE1QWUpJRHNQdkhnRXlrK2pw?=
 =?utf-8?B?UFRtbE9zTmF5L2tHdlpXTmYxY2sxQU1zZ3JuWXRBNzNGRVFrWndSSU9tc0lQ?=
 =?utf-8?B?dlQrcWRxcjdDWmo1QS8wZG12SStYN1NYZFNTVFJEbWEzWm92NXlhTXdxTmlr?=
 =?utf-8?B?NEQxWU90cEpzQm5FeXlEQ29ydnpCVlJiLzJ5NlBhZy9VZW9TVVFTMHJYcG5K?=
 =?utf-8?B?U1JEQTE3WjlFbHhMT2ljYno4eWpPNGNReHpUd0N3bXNQaW82WlJEaXNRZE1E?=
 =?utf-8?B?SElUVG5nY0VTUHlsRlhidXhqSWQwV0pickMzS04xRTdmUUVZZXEyUDFzR3B4?=
 =?utf-8?B?cWFKWDNtT3cxcUdHTHhVSFFrOUluUkoySjlNRmxkc0lNMVVGcXRZZlpZSHY5?=
 =?utf-8?B?alZTVnE1aVhubElQb2k0NSsrcXo2dEJtb1pHcVJwRnJaL3Y3ZXNENFJFamZa?=
 =?utf-8?B?REM3K3ROWVhtNytnR05pUWh0MW5JQ2Y5NkE3S282S0pUYVo4WHo5RjE5ekYx?=
 =?utf-8?B?M2p1OHdEUGRvaTh0Vjd1M1prZDRyeCszWlpUZVorY0JTR3VQbTh2S2dITDhW?=
 =?utf-8?B?L0NCcThucW5YN1FYQ3JSanlPSnZLNk9qcnpEalJZcys4RFppNVQ0KzRxZU9j?=
 =?utf-8?B?cEhQVDAybjQ2MU9RL3lQZm9wU1BER3F3WmFReElnVGNYWHVqUk14eXIvN3dR?=
 =?utf-8?B?YmFlYlRDY2pQYklObFA3NzRRa25sdm9FNDZoYkhNdXZXUjJxb2E2MHg5U1JT?=
 =?utf-8?B?QjdLUlFqMklUaytnQ2VFeVgwWFE4WHM1a2wzMTB4NXpxNHd5K3V6NTNqY1I0?=
 =?utf-8?B?ZlVzSFB2V2dRRTVSdXRLL0NtR2d0ZEJXM1BFd2hXTFJ3aE1qbnBXYkFnb3hC?=
 =?utf-8?B?Q2FHNWFJM0w0YlJxTmVpMVI1aDBMSDNDNTUzSks3TWhoQUwxdHJhejZpMmky?=
 =?utf-8?B?bUphOEF4eEppUzU2emtNZEhEM01WRkVpSDVpZnFlaHBoUGpRK3J5TVllK3BZ?=
 =?utf-8?B?NG0rNUFZeWY4RVlUaTROQTJzV0RrVTBsdnZDYlh4SFpIbEMxTnV4Z0ZyWTBk?=
 =?utf-8?B?VEJjamRlUnV4MnBRQTZyWlorT2tWeHMrNi83dFgrYW9ZMVp3VEJ4aHhPdy9C?=
 =?utf-8?B?eTQ5K0hXZy91Q3IxMFpjUFN6UkMza1hSRnBSc2xvUmd2NXRsQ2FyckxjYnlp?=
 =?utf-8?B?ZnNwWjNjM1lHRXdjQ1FOajBBTUhWOXdRWlpJZkk5b1F3enZUL1hSQ2J0eGtn?=
 =?utf-8?B?eVFaMDlCTWtpYlJKaStXaEFHZGhyYkNUcmN3K3IyaVJrY1ZnV2FVeERWR25t?=
 =?utf-8?B?RTVubktxVzBUTUJIdnV5QnA2bFk0TFAzK1AzcXI0a1FCdG5tMEE4WWU1NDR1?=
 =?utf-8?B?R3AxdGQ0THZBSFhiTmgwOVB5b3lNS29hSWVmRVFaMk10VW1xRVA3YnRHS2o5?=
 =?utf-8?B?SGFhR0FReFpWZXhSMXZwSkVBb3ZSV3BmZVQ5OTRJOFFCU2I5T01mbWI0Z29K?=
 =?utf-8?Q?6rEbrqMGqv/wPgKsRlMplVM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3008af30-0e6a-4e84-d29e-08d9b8d2d208
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:09:45.8191
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CZLiSeYeEU8T0SviRPFruod5UVLygCf9BNj6E10niS4HW+2QCqB0SdopI3h8eqoC6nPlBMy/P/V5TQKnKeZKiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382

On 29.11.2021 16:33, Roger Pau Monne wrote:
> @@ -458,22 +456,6 @@ int xc_cpuid_apply_policy(xc_interface *xch, uint32_t domid, bool restore,
>           (p = calloc(1, sizeof(*p))) == NULL )
>          goto out;
>  
> -    /* Get the host policy. */
> -    rc = xc_get_cpu_featureset(xch, XEN_SYSCTL_cpu_featureset_host,
> -                               &len, host_featureset);

You go from retrieving the host featureset to ...

> @@ -944,3 +865,98 @@ int xc_cpu_policy_make_compat_4_12(xc_interface *xch, xc_cpu_policy_t *policy,
>      xc_cpu_policy_destroy(host);
>      return rc;
>  }
> +
> +int xc_cpu_policy_legacy_topology(xc_interface *xch, xc_cpu_policy_t *policy,
> +                                  bool hvm)
> +{
> +    if ( !hvm )
> +    {
> +        xc_cpu_policy_t *host;
> +        int rc;
> +
> +        host = xc_cpu_policy_init();
> +        if ( !host )
> +        {
> +            errno = ENOMEM;
> +            return -1;
> +        }
> +
> +        rc = xc_cpu_policy_get_system(xch, XEN_SYSCTL_cpu_policy_host, host);

... retrieving the host policy, which afaict is a larger blob of data.
Is there a particular reason for doing so?

> +        if ( rc )
> +        {
> +            ERROR("Failed to get host policy");
> +            xc_cpu_policy_destroy(host);
> +            return rc;
> +        }
> +
> +
> +        /*
> +         * On hardware without CPUID Faulting, PV guests see real topology.
> +         * As a consequence, they also need to see the host htt/cmp fields.
> +         */
> +        policy->cpuid.basic.htt = host->cpuid.basic.htt;
> +        policy->cpuid.extd.cmp_legacy = host->cpuid.extd.cmp_legacy;
> +    }
> +    else
> +    {
> +        unsigned int i;
> +
> +        /*
> +         * Topology for HVM guests is entirely controlled by Xen.  For now, we
> +         * hardcode APIC_ID = vcpu_id * 2 to give the illusion of no SMT.
> +         */
> +        policy->cpuid.basic.htt = true;
> +        policy->cpuid.extd.cmp_legacy = false;
> +
> +        /*
> +         * Leaf 1 EBX[23:16] is Maximum Logical Processors Per Package.
> +         * Update to reflect vLAPIC_ID = vCPU_ID * 2, but make sure to avoid
> +         * overflow.
> +         */
> +        if ( !policy->cpuid.basic.lppp )
> +            policy->cpuid.basic.lppp = 2;
> +        else if ( !(policy->cpuid.basic.lppp & 0x80) )
> +            policy->cpuid.basic.lppp *= 2;
> +
> +        switch ( policy->cpuid.x86_vendor )
> +        {
> +        case X86_VENDOR_INTEL:
> +            for ( i = 0; (policy->cpuid.cache.subleaf[i].type &&
> +                          i < ARRAY_SIZE(policy->cpuid.cache.raw)); ++i )
> +            {
> +                policy->cpuid.cache.subleaf[i].cores_per_package =
> +                  (policy->cpuid.cache.subleaf[i].cores_per_package << 1) | 1;
> +                policy->cpuid.cache.subleaf[i].threads_per_cache = 0;
> +            }
> +            break;
> +
> +        case X86_VENDOR_AMD:
> +        case X86_VENDOR_HYGON:
> +            /*
> +             * Leaf 0x80000008 ECX[15:12] is ApicIdCoreSize.
> +             * Leaf 0x80000008 ECX[7:0] is NumberOfCores (minus one).
> +             * Update to reflect vLAPIC_ID = vCPU_ID * 2.  But avoid
> +             * - overflow,
> +             * - going out of sync with leaf 1 EBX[23:16],
> +             * - incrementing ApicIdCoreSize when it's zero (which changes the
> +             *   meaning of bits 7:0).
> +             *
> +             * UPDATE: I addition to avoiding overflow, some

Nit: Would you mind switching "I" to "In" at this occasion?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:12:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:12:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239332.414820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGbT-0001hj-Vy; Mon, 06 Dec 2021 16:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239332.414820; Mon, 06 Dec 2021 16:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGbT-0001hc-Sr; Mon, 06 Dec 2021 16:12:35 +0000
Received: by outflank-mailman (input) for mailman id 239332;
 Mon, 06 Dec 2021 16:12:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muGbS-0001hW-Ic
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:12:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50f4e4b5-56af-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 17:12:32 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-OerlG2WINJmbGQcW0YRKEg-1; Mon, 06 Dec 2021 17:12:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 16:12:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:12:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0073.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Mon, 6 Dec 2021 16:12:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50f4e4b5-56af-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638807151;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2EeyQvF3gtY2MjpZQJDxVwGagS3cXTUVFohohBdYWiI=;
	b=Oq/OOPAbwRabn5nF/h0pYG2C19KGFtUCXmmA+Cb2CVKvQFqwqZTI8xwsojYPOl/rBs0CPI
	2dDwbasGBD2TaZuaHWp29vEBmJtbhgOHg7I0kg3bGlb2ijGWE/Nf2r6XOQ5C8k3FeJ3pru
	ToClg2BBo1DvAkpmtUPcXeXdy67ic8g=
X-MC-Unique: OerlG2WINJmbGQcW0YRKEg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cwuohtX+TtOncdOXbWaV4UQOBd9dfx1yYqqiXBcKSl9J9dCZIx82GvxXjuV1sNgZtZiJZ6p6sbAThf/x4UDSsZPgXpFklYaQWzBdCj7vbLC9GPYTO5vtaNSj3++5d3WfhgMD+NurItKjz9DOVWqg3dseZxYlIV5iBoPMiB66UvhDVWrt4fLdFoFbzaReZffPeaYhrSVRwDniDDXkp8CUZpZXlFVxndiMU6aZcvKyEPe4KjHjzkE2HTIcjicNtEsgILxzncYNBQjXEAbrh0MJWdI7trXFZ9W6yk++POov/68uG0JO4h4MktBLc4iLdxaAhW0Jonh4xyKHW/rCmLblvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2EeyQvF3gtY2MjpZQJDxVwGagS3cXTUVFohohBdYWiI=;
 b=eVsajxqD+U9cVO7UsPz/gRK12QwG90BknFY7OV0K1M/Vp1ETFMr0kwdSnvJOpxC1mDhE4Ys5IVZnn4JiUp9UaKNtiVLXAVGpKwoIewwXbGAPCoDZx9LhoimjaKX8IfYxtVuUfTxy7JL5GExWSzlj/pYnNO2GaFkcqSaOJUEZMUrBbjkV+c7GSSP1hzuwAfuwurJohj1E6Tqhdnz4cdX311iS2f5spRr6m59OG9FOcDGbltGZOBpLS9rol6CFl5tnKX/QWTKLRXw9ux9EBlGuLaJU1PBFMIp6ba19bhLi0/ZgwQGOMYmDq1QRRmKISYTPjisKVH31QbvipU5MB7XPZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
Date: Mon, 6 Dec 2021 17:12:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0073.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85ff5f29-da3e-4cd0-6f62-08d9b8d333d9
X-MS-TrafficTypeDiagnostic: VI1PR04MB7152:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7152F209E3292AF5A11CFBADB36D9@VI1PR04MB7152.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EkXFNk4jUpY1ZGZ+5OTw1ntSoBxUugX98ApjKBSWv54DTzLZnVRfLVnNFXu35Mu6OQ3n3odZuH0+i5ob8EsyV8XHPbtCwd6UBQpQISDUafbzF2DMZJs36ncZ7Wqk9C4CTY027BoXimOk0m2bXE/goo0VBCFkv6o3DPIbQiheTi3TWrv6mLi4nbaocgrRMC9G+fUOIKd5lwg1yazUMkMRdO6xvHgHPeqrGdYlyQFlROFLLWL71eS6T6IeoAvxeyNzGy8AwcX6W9MJTGdSyaKvpTPApexLWrbEZlRtadZd2dnvkJ+hOFFUIjBGuFDuUvB8NoqcVfo1/Bdp0lVRCkaS+RB/jPlKGSurHHhHjaC7KV2xr3B7m/xn5jB7y7x/l0BpQvRzQldJ6bA3LT8Mhqvl/UHI39eV9ImMtXv2Wv8Rbx2rUkpcQsG8wqHRgUKFnvXUytwDCtnfzbtO3NJy9cFv/e6X7ntUk6yFYPagACw5wIdMnDQ7wOP1WN1SBW33O/WahnanKpNMeCQ1bLMQWTWGxShmKZ+XiUdTAQ13hNHOKfPVJftkwkn4RY8Pb2GzLsJT0Pf0il8Wn8C1WG7+A9PwORoDg9JXc71R1TIaR4hZ94DONrarN0lgIZj9QbtvFx2hEonzc3uSVsY9TPi/Bnplb2PuD5z2dvelEkaJz/Fk89/g51GBp5xgsBO4MEQf0MH6WXGY6T4dhmr/i6YgiWG/+UuOgtachhecV+yECNhGP8SgJUN7Nn2nh28PABOnYbk0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(36756003)(956004)(31686004)(53546011)(4326008)(6916009)(86362001)(38100700002)(31696002)(6486002)(26005)(66946007)(54906003)(8936002)(66476007)(2906002)(508600001)(16576012)(66556008)(4744005)(8676002)(5660300002)(2616005)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGFia1hyeWM2MnpBVGtNZlh6c0ZrTzhlTGM1Z216aWJUOENnS2crWDRQSFZZ?=
 =?utf-8?B?VlZVU2lMY3BUOCtFVzZDL2R5NzdjQkRSNHZNOGQwS1R4Qk1DYmdnQzg0N0sw?=
 =?utf-8?B?enFMejczR1Q1QnM5eGRtdytOY3hyZGh1UnB6NVUxZXdHQ25TY1krNnNZbFln?=
 =?utf-8?B?MDZsNGx5b0tOYmVmQVFjOVZoakw1QmEvdVRONzR1MUQ3OXJJelRFaWxUdzFh?=
 =?utf-8?B?MHFxWkNpdS9sQkZXbXlYQVN5dlZtaUJrb05ZcGJpUHloWW84T01lbW93ZVF6?=
 =?utf-8?B?dnByeWJzYzdqM3RLQTY4MjNiR3JvSHJDZDZ4dEtNcEt1WDU0b3ZUYkdMQ0FL?=
 =?utf-8?B?aG1xbVBnT0l1MUFCUzNjeTNBQTc3T0tCUU9SaWxJRm0vNlVTd2M4N3RpYVpL?=
 =?utf-8?B?MEphY0w4U2N0SVdEeldOejNqWUpMTmdFZjRKTE44WWw2aTdBQnBEVXJZVzVz?=
 =?utf-8?B?dUhGbmZDVmlVU2NCY2pLSmN3K1NYdEtoMFduZ2pnSFJxYnhqQk9VUlA1YmUv?=
 =?utf-8?B?d0lZcTl6MWdBci9veTVwVDlDV3BjU3hoV0lPRm13ZUM2V1VvRzdPNGZNRzM1?=
 =?utf-8?B?cG41WkIva1lDSittWjZUVEpHY1R6RHVMZnBxbDZPbE9VUk44clRqRnZ4WS8x?=
 =?utf-8?B?QVNPR1VXQ2lZRGVhYnN1TG9UZTVDZGlEQWErOXBhNkhOSGd0SVQ2N2ZseGcz?=
 =?utf-8?B?QXRDZTFUT0RGeWFLUjFOcklOcWptbkdNdUZtWUZmQkhadk9PKzViRTk4bjkw?=
 =?utf-8?B?b3hVOHVCUHluR3BqNGs3UGw5UmpFbjlQUXdtQjFEWEtoajNsVC9JOXQvQ2Ey?=
 =?utf-8?B?Q2ZuM3EwWVpkS05UZnNNT2w5V0hMR2RvNkFoMkN5TXk1MS9iK2d4RzdjYVRw?=
 =?utf-8?B?SnNmNVhJLzF6eStiOURuNWhMTUZmRzlUQVU3SnVCejVZTW1JaUszV2hQaGNs?=
 =?utf-8?B?NW5sUWdZMlJWQTA4V2RtTk15R3d1UkMwb2VneVh2dDUyc1dZVDZKWXRxZU5G?=
 =?utf-8?B?eWJUd25STm5lSkdSQkVET2JzalNkQVB4RlcwYk45NjhtdTMzUVgwTGpIdEFq?=
 =?utf-8?B?YzNBdE5DTnlMclJadUxneDBDNGdGNzZIQWtxT21BSURPRDl0SUNWOUQrZ1ZN?=
 =?utf-8?B?K0k0RWdWNVp4UXRQUHk2VHVtVXljS2xoZTlQTTZuZnQzcTJmc3lnUWtnaURp?=
 =?utf-8?B?L2FPSW4rUnlOaWlOcHNrVzBpN1hiaXlITG1ES2tCVllGVUdyNDlpeVpGa0lC?=
 =?utf-8?B?MktoWUFTeTBMKzNkRndrWi9rdGR1RnNhV2hCU2s4dU1TbFBzZTB4eW1wSmQv?=
 =?utf-8?B?TlZOMDIrL2hkVE9PSVNGMUJjUUtad2lpQkQwMFpSKzlCTWxJVEJJN05ZMVFa?=
 =?utf-8?B?TlhGcmtFQmh4TUQ5UHUvRFZDbVJtQkhEeCtCY1RXTXdFb3pGaTdwN2kyK042?=
 =?utf-8?B?NlJobE9zZFRVMVVlcS9NL1ErUnE1OUo0ZjVtRjl5cmFsUGJjRkZHYVY2dFdP?=
 =?utf-8?B?b2hZL1JjQ3ZXZndQcXJxZHNjQlEzNzBoMU8wWnRkZW5GaElNSkxLQk5TMDVU?=
 =?utf-8?B?czgvNGdidkxoT09mVUR4L3Nvbkw0dHgrcEtWbk5uc2ZidENETVhCTjlFeWNG?=
 =?utf-8?B?SmFDQUlkOGYzejBPRTJHa1hJZFovdmR0NUZMZHJpNzh4dDRFdG1uMHQ0RTFM?=
 =?utf-8?B?aldkZEZldURxUUF2UFAwU0tEWGpUSllnRjlaRFMrTVN6TG4wbFByTCtHZmlu?=
 =?utf-8?B?V3hjVlRlaXZVcGEwbjFieWVDSFB1RjJCd1FVVHJPNGhVdWhYeWdYWjdKZ0g3?=
 =?utf-8?B?N1VEdm9DOFp6aEpER2xMc3VFd1Fhb0lLbVZ2cEYwODZpMmxCcWdSNm1saUNr?=
 =?utf-8?B?L2xWTU1LcTMvTHlEV3FnUW1qOXNJTlUyL0JRWSsrYk9WMEQxYXNOWWljS2h3?=
 =?utf-8?B?NkVNUFY2Ri8wTEVwMW5HME90dnE4WXZBanVDY09LSzBrV1prNm1nRmcra3Rh?=
 =?utf-8?B?Tzl5eG1GWVg1QVQxdXc4eDNxV2oyenV1VkhlcGdQL0NjaVE3YzRNcXhIcFNw?=
 =?utf-8?B?VVZGTGgzK3pjcm9KZ3lTejVqTFhGQ0dTMTZQcG5GemRobXhBWkQ1eDJ6cHlo?=
 =?utf-8?B?ZlkwQ3MydXYyRnJGNmljb0VhRkhhaGs2OTlhN3FxVk0xdXd2SWZna2RLU2dz?=
 =?utf-8?Q?CptHWlQ2P2pBAd5N/g9E8Xw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85ff5f29-da3e-4cd0-6f62-08d9b8d333d9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:12:29.9542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CcAq9v80bVJLO37wZJZksZe0ure3Gm1b8txwa9FFbPFioRce/kz0jnWQ44Ot57tPPUEcbFj4pTYYdZHns0ADLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152

On 06.12.2021 17:06, Julien Grall wrote:
> On 06/12/2021 15:06, Jan Beulich wrote:
>> On 06.12.2021 15:28, Julien Grall wrote:
>>> I am not going to ack it but I am also not going to Nack it if another
>>> maintainer agrees with your approach.
>>
>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>> I'm now in a position to put this in with Luca's R-b.
> 
>  From the check-in policy section in MAINTAINERS:
> 
> 4. There must be no "open" objections.
> 
> So I think this cannot be check-in given two maintainers disagree on the 
> approach. That said, as I wrote earlier my condition for not Nacking is 
> another maintainer agree with your approach.

Hmm, I did address both your and Ian's concerns in v2, admittedly by only
going as far as minimally necessary. I therefore wouldn't call this an
"open objection".

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:15:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:15:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239336.414831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGeL-0002JP-EP; Mon, 06 Dec 2021 16:15:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239336.414831; Mon, 06 Dec 2021 16:15:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGeL-0002JI-Au; Mon, 06 Dec 2021 16:15:33 +0000
Received: by outflank-mailman (input) for mailman id 239336;
 Mon, 06 Dec 2021 16:15:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Dgx3=QX=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1muGeJ-0002J7-Sn
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:15:32 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bb3e8e7a-56af-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 17:15:30 +0100 (CET)
Received: by mail-lj1-x22d.google.com with SMTP id k23so22033857lje.1
 for <xen-devel@lists.xenproject.org>; Mon, 06 Dec 2021 08:15:30 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id t5sm1542563lfd.80.2021.12.06.08.15.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 06 Dec 2021 08:15:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb3e8e7a-56af-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=aFt6wJuLTMkarW2MTZg0Cl6fCaMkyk475xCqByUy3Ic=;
        b=aPKpBzugMJ7+mYvHtgX529n7TM0k4idGYbQx6KnQnyIzLe6OCbpJOGvWcs7QyLrI68
         8f+S6v++BBOZ32KF87LImFsG96WbWOdVUD6hFVVgW06Wv5/ZT2Tc1k1GIBOodnMxRL4j
         2t7CW6CqFX1bxP2xT9LRuASSZfwC9y/6IoBXq46+nAe6wRlYQTfnpk/QE0vfGUe/srNJ
         sSUm9pVQaiZk84bbBHAHFZNR+3RDODs5faxYDDgRDN9VeIddSP5MQRhmtDorDEpcTO/Z
         X1/zcsRBRNx4iWuZBxbCaxVmeGStsOfcC7gHF9Xu77cV7eDPXXg8j1RWOkNMFjogrfVF
         BAsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=aFt6wJuLTMkarW2MTZg0Cl6fCaMkyk475xCqByUy3Ic=;
        b=uMP8GupzWytVzkgnUk48L+7tH9C8wIQVrm+U0wbLafUfCieduuN7aWsin7lgxhQZb3
         9DM3CULaIEOaBKk26ALRoNK8CSdKFXbI35Rw7YyUGX7nKcZImQPJKmUpoBdVM6zt2Xuu
         I5VpHjLLRpXME5N2nUVQtyYR5YPwcDE40ZPZNzJHsBYMOBhbhhdN6EwubZN/NjXMBuP5
         FEx7C9D+kGprVkRqWF7nacGurEQmbxZZUvssXrfJHRYTgd+GcZcu3W7mjxVlMNk0Rw0k
         BX5sm4QKOD/1YlEZgdVvKGSc/RmDGngqhquuACe8ya3Eff+iAv3fB8LlKAAsWunBGC49
         EXmg==
X-Gm-Message-State: AOAM5328JjXqV2nIR1aeKw8f/UKR3s+jwwAJPI0Ri37xlO5+feQ/0tlc
	V0ouTYYmZ0kYNISr7cWGaxQ=
X-Google-Smtp-Source: ABdhPJztnFXATEnoOaL3qLxlj6sPuyseluIBdMTni7Jz4xfAMgSOVBCCD7kE0G10R6auy1SjxUUleA==
X-Received: by 2002:a2e:b0e3:: with SMTP id h3mr36113081ljl.62.1638807329678;
        Mon, 06 Dec 2021 08:15:29 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
From: Oleksandr <olekstysh@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
Message-ID: <930f979b-66d2-c7ca-0be5-3f4afb7f2de2@gmail.com>
Date: Mon, 6 Dec 2021 18:15:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


Hi Jan


May I please ask, are you OK with the proposed changes?


On 03.12.21 22:33, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Rework Arm implementation to store grant table frame GFN
> in struct page_info directly instead of keeping it in
> standalone status/shared arrays. This patch is based on
> the assumption that grant table page is the xenheap page.
>
> To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space
> to hold 52-bit/28-bit + extra bit value respectively. In order
> to not grow the size of struct page_info borrow the required
> amount of bits from type_info's count portion which current
> context won't suffer (currently only 1 bit is used on Arm).
> Please note, to minimize code changes and avoid introducing
> an extra #ifdef-s to the header, we keep the same amount of
> bits on both subarches, although the count portion on Arm64
> could be wider, so we waste some bits here.
>
> Introduce corresponding PGT_* constructs and access macros.
> Update existing gnttab macros to deal with GFN value according
> to new location. Also update the use of count portion on Arm
> in share_xen_page_with_guest().
>
> While at it, extend this simplified M2P-like approach for any
> xenheap pages which are proccessed in xenmem_add_to_physmap_one()
> except foreign ones. Update the code to set GFN portion after
> establishing new mapping for the xenheap page in said function
> and to clean GFN portion when putting a reference on that page
> in p2m_put_l3_page().
>
> And for everything to work correctly introduce arch-specific
> macros arch_alloc_(free)xenheap_page to be called from
> alloc_(free)xenheap_pages() respectively, the former's purpose
> on Arm is to clear the GFN portion before use, the latter was
> left dummy for now. On x86 both are just stubs.
>
> This patch is intended to fix the potential issue on Arm
> which might happen when remapping grant-table frame.
> A guest (or the toolstack) will unmap the grant-table frame
> using XENMEM_remove_physmap. This is a generic hypercall,
> so on x86, we are relying on the fact the M2P entry will
> be cleared on removal. For architecture without the M2P,
> the GFN would still be present in the grant frame/status
> array. So on the next call to map the page, we will end up to
> request the P2M to remove whatever mapping was the given GFN.
> This could well be another mapping.
>
> Besides that, this patch simplifies arch code on Arm by
> removing arrays and corresponding management code and
> as the result gnttab_init_arch/gnttab_destroy_arch helpers
> and struct grant_table_arch become useless and can be
> dropped globally.
>
> Suggested-by: Julien Grall <jgrall@amazon.com>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Dear @RISC-V maintainers, please note in current patch I drop arch
> specific gnttab_init(destroy)_arch helpers as unneeded for both Arm and x86.
> Please let me know if you are going to reuse them in the nearest future and
> I will retain them.
>
> You can find the related discussions at:
> https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-54412190171c@xen.org/
> https://lore.kernel.org/xen-devel/1628890077-12545-1-git-send-email-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/1631652245-30746-1-git-send-email-olekstysh@gmail.com/
> https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/
>
> Changes RFC1 -> RFC2:
>   - update patch description
>   - add/update comments in code
>   - clarify check in p2m_put_l3_page()
>   - introduce arch_alloc_xenheap_page() and arch_free_xenheap_page()
>     and drop page_arch_init()
>   - add ASSERT to gnttab_shared_page() and gnttab_status_page()
>   - rework changes to Arm's struct page_info: do not split type_info,
>     allocate GFN portion by reducing count portion, create corresponding
>     PGT_* construct, etc
>   - update page_get_frame_gfn() and page_set_frame_gfn()
>   - update the use of count portion on Arm
>   - drop the leading underscore in the macro parameter names
>
> Changes RFC2 -> RFC3:
>   - update patch description
>   - drop PGT_count_base and MASK_INSR() in share_xen_page_with_guest()
>   - update alloc_xenheap_page() and free_xenheap_page() for SEPARATE_XENHEAP
>     case (Arm32)
>   - provide an extra bit for GFN portion, to get PGT_INVALID_FRAME_GFN
>     one bit more than the maximum number of physical address bits on Arm32
>
> Changes RFC3 -> V4:
>   - rebase on Jan's "gnttab: remove guest_physmap_remove_page() call
>     from gnttab_map_frame()"
>   - finally resolve locking question by recent Julien's suggestion,
>     so drop the RFC tag
>   - update comments in Arm's mm.h/p2m.c to not mention grant table
>   - convert page_set(get)_frame_gfn to static inline func and
>     rename them to page_set(get)_xenheap_gfn()
>   - rename PGT_INVALID_FRAME_GFN to PGT_INVALID_XENHEAP_GFN
>   - add ASSERT(is_xen_heap_page(...)) in page_set(get)_frame_gfn
>   - remove BUG_ON() in arch_free_xenheap_page
>   - remove local type_info in share_xen_page_with_guest()
>   - remove an extra argument p2m in p2m_put_l3_page()
>   - remove #ifdef CONFIG_GRANT_TABLE in p2m_put_l3_page()
>   - also cover real-only pages by using p2m_is_ram instead of a check
>     against p2m_ram_rw in p2m_put_l3_page() and use "else if" construct
>   - call arch_free_xenheap_page() before clearing the PGC_xen_heap in
>     free_xenheap_pages()
>   - remove ASSERT() in gnttab_shared(status)_page and use simpler
>     virt_to_page
>   - remove local pg_ in gnttab_shared(status)_gfn
>   - update patch description to reflect recent changes
> ---
>   xen/arch/arm/mm.c                 | 24 ++++++++++++++--
>   xen/arch/arm/p2m.c                |  7 +++--
>   xen/common/grant_table.c          |  9 ------
>   xen/common/page_alloc.c           | 20 +++++++++++++-
>   xen/include/asm-arm/grant_table.h | 58 ++++++++++++---------------------------
>   xen/include/asm-arm/mm.h          | 39 ++++++++++++++++++++++++--
>   xen/include/asm-x86/grant_table.h |  5 ----
>   xen/include/asm-x86/mm.h          |  4 +++
>   8 files changed, 102 insertions(+), 64 deletions(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index eea926d..4f4cab3 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1382,8 +1382,10 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d,
>       spin_lock(&d->page_alloc_lock);
>   
>       /* The incremented type count pins as writable or read-only. */
> -    page->u.inuse.type_info =
> -        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1;
> +    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask);
> +    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none
> +                                                  : PGT_writable_page) |
> +                                MASK_INSR(1, PGT_count_mask);
>   
>       page_set_owner(page, d);
>       smp_wmb(); /* install valid domain ptr before updating refcnt. */
> @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
>       }
>   
>       /* Map at new location. */
> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    else
> +    {
> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +
> +        p2m_write_lock(p2m);
> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) )
> +        {
> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access);
> +            if ( !rc )
> +                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
> +        }
> +        else
> +            rc = -EBUSY;
> +        p2m_write_unlock(p2m);
> +    }
>   
>       /*
>        * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 8b20b43..fd8aff9 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -720,6 +720,8 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn,
>    */
>   static void p2m_put_l3_page(const lpae_t pte)
>   {
> +    mfn_t mfn = lpae_get_mfn(pte);
> +
>       ASSERT(p2m_is_valid(pte));
>   
>       /*
> @@ -731,11 +733,12 @@ static void p2m_put_l3_page(const lpae_t pte)
>        */
>       if ( p2m_is_foreign(pte.p2m.type) )
>       {
> -        mfn_t mfn = lpae_get_mfn(pte);
> -
>           ASSERT(mfn_valid(mfn));
>           put_page(mfn_to_page(mfn));
>       }
> +    /* Detect the xenheap page and mark the stored GFN as invalid. */
> +    else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) )
> +        page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN);
>   }
>   
>   /* Free lpae sub-tree behind an entry */
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index 0262f2c..01d7a29 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -94,8 +94,6 @@ struct grant_table {
>   
>       /* Domain to which this struct grant_table belongs. */
>       struct domain *domain;
> -
> -    struct grant_table_arch arch;
>   };
>   
>   unsigned int __read_mostly opt_max_grant_frames = 64;
> @@ -1997,14 +1995,9 @@ int grant_table_init(struct domain *d, int max_grant_frames,
>   
>       grant_write_lock(gt);
>   
> -    ret = gnttab_init_arch(gt);
> -    if ( ret )
> -        goto unlock;
> -
>       /* gnttab_grow_table() allocates a min number of frames, so 0 is okay. */
>       ret = gnttab_grow_table(d, 0);
>   
> - unlock:
>       grant_write_unlock(gt);
>   
>    out:
> @@ -3911,8 +3904,6 @@ grant_table_destroy(
>       if ( t == NULL )
>           return;
>   
> -    gnttab_destroy_arch(t);
> -
>       for ( i = 0; i < nr_grant_frames(t); i++ )
>           free_xenheap_page(t->shared_raw[i]);
>       xfree(t->shared_raw);
> diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
> index d0baaa2..2306d9a 100644
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2161,6 +2161,7 @@ void init_xenheap_pages(paddr_t ps, paddr_t pe)
>   void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>   {
>       struct page_info *pg;
> +    unsigned int i;
>   
>       ASSERT(!in_irq());
>   
> @@ -2169,6 +2170,9 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>       if ( unlikely(pg == NULL) )
>           return NULL;
>   
> +    for ( i = 0; i < (1u << order); i++ )
> +        arch_alloc_xenheap_page(&pg[i]);
> +
>       memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));
>   
>       return page_to_virt(pg);
> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>   
>   void free_xenheap_pages(void *v, unsigned int order)
>   {
> +    struct page_info *pg;
> +    unsigned int i;
> +
>       ASSERT(!in_irq());
>   
>       if ( v == NULL )
>           return;
>   
> +    pg = virt_to_page(v);
> +
>       memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>   
> -    free_heap_pages(virt_to_page(v), order, false);
> +    for ( i = 0; i < (1u << order); i++ )
> +        arch_free_xenheap_page(&pg[i]);
> +
> +    free_heap_pages(pg, order, false);
>   }
>   
>   #else  /* !CONFIG_SEPARATE_XENHEAP */
> @@ -2220,7 +2232,10 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>           return NULL;
>   
>       for ( i = 0; i < (1u << order); i++ )
> +    {
>           pg[i].count_info |= PGC_xen_heap;
> +        arch_alloc_xenheap_page(&pg[i]);
> +    }
>   
>       return page_to_virt(pg);
>   }
> @@ -2238,7 +2253,10 @@ void free_xenheap_pages(void *v, unsigned int order)
>       pg = virt_to_page(v);
>   
>       for ( i = 0; i < (1u << order); i++ )
> +    {
> +        arch_free_xenheap_page(&pg[i]);
>           pg[i].count_info &= ~PGC_xen_heap;
> +    }
>   
>       free_heap_pages(pg, order, true);
>   }
> diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
> index d31a4d6..d6fda31 100644
> --- a/xen/include/asm-arm/grant_table.h
> +++ b/xen/include/asm-arm/grant_table.h
> @@ -11,11 +11,6 @@
>   #define INITIAL_NR_GRANT_FRAMES 1U
>   #define GNTTAB_MAX_VERSION 1
>   
> -struct grant_table_arch {
> -    gfn_t *shared_gfn;
> -    gfn_t *status_gfn;
> -};
> -
>   static inline void gnttab_clear_flags(struct domain *d,
>                                         unsigned int mask, uint16_t *addr)
>   {
> @@ -46,41 +41,12 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>   #define gnttab_dom0_frames()                                             \
>       min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext))
>   
> -#define gnttab_init_arch(gt)                                             \
> -({                                                                       \
> -    unsigned int ngf_ = (gt)->max_grant_frames;                          \
> -    unsigned int nsf_ = grant_to_status_frames(ngf_);                    \
> -                                                                         \
> -    (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_);                  \
> -    (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_);                  \
> -    if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn )                \
> -    {                                                                    \
> -        while ( ngf_-- )                                                 \
> -            (gt)->arch.shared_gfn[ngf_] = INVALID_GFN;                   \
> -        while ( nsf_-- )                                                 \
> -            (gt)->arch.status_gfn[nsf_] = INVALID_GFN;                   \
> -    }                                                                    \
> -    else                                                                 \
> -        gnttab_destroy_arch(gt);                                         \
> -    (gt)->arch.shared_gfn ? 0 : -ENOMEM;                                 \
> -})
> -
> -#define gnttab_destroy_arch(gt)                                          \
> -    do {                                                                 \
> -        XFREE((gt)->arch.shared_gfn);                                    \
> -        XFREE((gt)->arch.status_gfn);                                    \
> -    } while ( 0 )
> -
>   #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
>       ({                                                                   \
> -        int rc_ = 0;                                                     \
>           gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx);                  \
> -        if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) ||           \
> -             (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn,   \
> -                                              0)) == 0 )                 \
> -            ((st) ? (gt)->arch.status_gfn                                \
> -                  : (gt)->arch.shared_gfn)[idx] = (gfn);                 \
> -        rc_;                                                             \
> +        (!gfn_eq(ogfn, INVALID_GFN) && !gfn_eq(ogfn, gfn))               \
> +         ? guest_physmap_remove_page((gt)->domain, ogfn, mfn, 0)         \
> +         : 0;                                                            \
>       })
>   
>   #define gnttab_get_frame_gfn(gt, st, idx) ({                             \
> @@ -88,11 +54,21 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
>           : gnttab_shared_gfn(NULL, gt, idx);                              \
>   })
>   
> -#define gnttab_shared_gfn(d, t, i)                                       \
> -    (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i])
> +#define gnttab_shared_page(t, i) ({                                      \
> +    virt_to_page((t)->shared_raw[i]);                                    \
> +})
> +
> +#define gnttab_status_page(t, i) ({                                      \
> +    virt_to_page((t)->status[i]);                                        \
> +})
>   
> -#define gnttab_status_gfn(d, t, i)                                       \
> -    (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i])
> +#define gnttab_shared_gfn(d, t, i) ({                                    \
> +    page_get_xenheap_gfn(gnttab_shared_page(t, i));                      \
> +})
> +
> +#define gnttab_status_gfn(d, t, i) ({                                    \
> +    page_get_xenheap_gfn(gnttab_status_page(t, i));                      \
> +})
>   
>   #define gnttab_need_iommu_mapping(d)                    \
>       (is_domain_direct_mapped(d) && is_iommu_enabled(d))
> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index 7b5e7b7..74b6485 100644
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -98,9 +98,16 @@ struct page_info
>   #define PGT_writable_page PG_mask(1, 1)  /* has writable mappings?         */
>   #define PGT_type_mask     PG_mask(1, 1)  /* Bits 31 or 63.                 */
>   
> - /* Count of uses of this frame as its current type. */
> -#define PGT_count_width   PG_shift(2)
> -#define PGT_count_mask    ((1UL<<PGT_count_width)-1)
> + /* 2-bit count of uses of this frame as its current type. */
> +#define PGT_count_mask    PG_mask(3, 3)
> +
> +/*
> + * Stored in bits [28:0] or [60:0] GFN if page is xenheap page.
> + */
> +#define PGT_gfn_width     PG_shift(3)
> +#define PGT_gfn_mask      ((1UL<<PGT_gfn_width)-1)
> +
> +#define PGT_INVALID_XENHEAP_GFN   _gfn(PGT_gfn_mask)
>   
>    /* Cleared when the owning guest 'frees' this page. */
>   #define _PGC_allocated    PG_shift(1)
> @@ -166,6 +173,32 @@ extern unsigned long xenheap_base_pdx;
>   
>   #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
>   
> +static inline gfn_t page_get_xenheap_gfn(struct page_info *p)
> +{
> +    gfn_t gfn_ = _gfn(p->u.inuse.type_info & PGT_gfn_mask);
> +
> +    ASSERT(is_xen_heap_page(p));
> +
> +    return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_;
> +}
> +
> +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn)
> +{
> +    gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn;
> +
> +    ASSERT(is_xen_heap_page(p));
> +
> +    p->u.inuse.type_info &= ~PGT_gfn_mask;
> +    p->u.inuse.type_info |= gfn_x(gfn_);
> +}
> +
> +/*
> + * As the struct page_info representing the xenheap page on Arm can contain
> + * the valid GFN we need to clear it beforehand.
> + */
> +#define arch_alloc_xenheap_page(p)   page_set_xenheap_gfn(p, INVALID_GFN)
> +#define arch_free_xenheap_page(p)    do {} while ( 0 )
> +
>   #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)
>   /* PDX of the first page in the frame table. */
>   extern unsigned long frametable_base_pdx;
> diff --git a/xen/include/asm-x86/grant_table.h b/xen/include/asm-x86/grant_table.h
> index a8a2143..5c23cec 100644
> --- a/xen/include/asm-x86/grant_table.h
> +++ b/xen/include/asm-x86/grant_table.h
> @@ -14,9 +14,6 @@
>   
>   #define INITIAL_NR_GRANT_FRAMES 1U
>   
> -struct grant_table_arch {
> -};
> -
>   static inline int create_grant_host_mapping(uint64_t addr, mfn_t frame,
>                                               unsigned int flags,
>                                               unsigned int cache_flags)
> @@ -35,8 +32,6 @@ static inline int replace_grant_host_mapping(uint64_t addr, mfn_t frame,
>       return replace_grant_pv_mapping(addr, frame, new_addr, flags);
>   }
>   
> -#define gnttab_init_arch(gt) 0
> -#define gnttab_destroy_arch(gt) do {} while ( 0 )
>   #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn)                      \
>       (gfn_eq(gfn, INVALID_GFN)                                            \
>        ? guest_physmap_remove_page((gt)->domain,                           \
> diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
> index cb90527..3c153c6 100644
> --- a/xen/include/asm-x86/mm.h
> +++ b/xen/include/asm-x86/mm.h
> @@ -327,6 +327,10 @@ struct page_info
>   
>   #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
>   
> +/* No arch-specific actions are needed for the xenheap page */
> +#define arch_alloc_xenheap_page(p)   do {} while ( 0 )
> +#define arch_free_xenheap_page(p)    do {} while ( 0 )
> +
>   #define frame_table ((struct page_info *)FRAMETABLE_VIRT_START)
>   extern unsigned long max_page;
>   extern unsigned long total_pages;

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:19:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:19:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239348.414842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGhz-0003HY-3v; Mon, 06 Dec 2021 16:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239348.414842; Mon, 06 Dec 2021 16:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGhz-0003HR-0T; Mon, 06 Dec 2021 16:19:19 +0000
Received: by outflank-mailman (input) for mailman id 239348;
 Mon, 06 Dec 2021 16:19:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muGhx-0003HL-FT
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:19:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4203186a-56b0-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 17:19:16 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-AT6H4VqwOvCTRjhUqZRMYA-2; Mon, 06 Dec 2021 17:19:15 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Mon, 6 Dec
 2021 16:19:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:19:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0601CA0047.eurprd06.prod.outlook.com (2603:10a6:203:68::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Mon, 6 Dec 2021 16:19:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4203186a-56b0-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638807556;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wLLJfZsIamwKBgwTqCJ9ke0Jna0S849SFV2e/v26xhE=;
	b=LYt9spXy4HZ5hzSWOs95DeqciO/o+29EzpZ4vBUfyb+9bokgzP9QWa8al9i41dnipHkDEx
	MrfbfAiz97JQ6arYB911uxXTfMrv1FvpD+tuJZarfNrYlSoALKtwHaN6GJIsJGJVBxYSvl
	UUQltUB2ZEr+wOm01us5x2e+qMSrr3w=
X-MC-Unique: AT6H4VqwOvCTRjhUqZRMYA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jMmwl44vNKgy2y6sztziO24YjioCgjhqBACziH0ltkUSkqJY5l91Cz3t1Ej9kbwj734v9P227ZjF/bugEJfyzYrcElFU2h7VC6t2vdzfqRBeRgXiQo6hU+6Ctsq6mXFvCrxOFTxQb/aSr1vffK1VLUwlplUxkkK/brZIZXmKcO3PIeNd2TKXUv0t+RozeWLMZon8GvcgGfpo+MRBmLWM9J65f9G3zsOqfl6IDF1n463bicE5kbGmKkQ+KU+nrFMzLc3kk9Auf5MXuIAuTCvzIwDktFK9iBa9NXi7fN0hvYu1ALzgND051aGgUCEP8qajuHjo+cBWgfv+C6suqJRi+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vwciUovSapFRG8mtklJgF5F53Fmgy9xFXrmDVrqqEtk=;
 b=CDWbIOFo53DoJwAoMhzZZm01qO30pso1oRIKyBwp+6RPUDDfjDEy1wbbRhVb8yNUs1yGgamsGJXcqqNm5TwNkSZu7GOb8Dc+2irAUo7rrqhIXIYiDaEIBxQ00ITnKf8w5bnknldcB11rt3JHeAvGLfToeeNflpE8Stc9r3lgrF2E0cG7dGGn85ZmoTnD1jCcAVfQ8IGFAwro8jagP5/TowHAQMsmB3V6qtXfEdu8YZo3EVc8BLKlbd+x8XesTCHeES/YG+Ia0WcyeWCg1wGHbKQmL4FdOiE0lqOKlekrldQSLItd7AlM/yaV+ABHAuC4CvAVUJZua+7q86NYlkQrhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1893b85f-5fc0-1b63-2b6c-a26d4667786c@suse.com>
Date: Mon, 6 Dec 2021 17:19:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v5 09/12] libs/guest: apply a featureset into a cpu policy
Content-Language: en-US
To: Roger Pau Monne <roger.pau@citrix.com>
CC: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
References: <20211129153355.60338-1-roger.pau@citrix.com>
 <20211129153355.60338-10-roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211129153355.60338-10-roger.pau@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0047.eurprd06.prod.outlook.com
 (2603:10a6:203:68::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 558a0d08-1af4-4d91-f430-08d9b8d423aa
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5744C973D149AFA7E603E98BB36D9@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2150;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	nLyb0e6yNyMf6+ahogDSWeafG20Nub3MbHdkhHM2+9WQm4pX7a5QkIKUxz8mTzIxNtB2k0sxWpOjAWRIdvcXbFTIBpfq8il/6Q0DoZBspw+9MwrGBBTjBxxjtR3Uba9ohBTONcq2jTiIeMvARHOk5OrVqXcVzjZgikRFHjFZcFMemRgwYXa+6EHAyS73OgDYX5M1SBoqpIHZwkOgJKMwiJ6XqJL6geHw/+ToO5yi0tlSWtHQHrE1pwba1ZhD3Vkc/3bqZQ7Z1P/F5/ZHN6YwAXbA+0ZP2rMafko05PA6sP4k7gXijKlY/LuomAPTB7vWPRDgVU/1ozMUygG1YNnG+pBjeukb8ySiACeGfiVFncs1n8QvKe5ySSzPxu5EmZZErjTqHsP8nMYe/f4UJKA+TUKuRoz1SRfvajTMFntZYJ5Cv2LS3cz+jNF6RT7QHUamfhtzaqGtiLJxwGGisx+S6Tnded120MSePmX3Jj9OZpTbPSbbWPYby9PjTT2QzUig0VEnsNcjKDirUCwWzXlCCgoNVnhtv7gWumbTFGSWqIZnNvOYk5kATkmYj5rc6vmGauX8Ale33dpH95jo9qwj+kesZUyoXzKjOUBmu+KhSUKM9KYkSaHkZ++/3oPkL7K+GkGfW4mqZ6SdRkZYaAa8ndkUSKFMO9wczGdGUJlOKcPjpRdzaHqhYnrl9pVLwK/Qc0Es68y7Wb5Hj/4pqa0uCvwGBMGuZZm3BX4G2V8Ry5TkF7TMeZBe3Q2p2peJ7exK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(186003)(2616005)(4744005)(31686004)(2906002)(956004)(8936002)(8676002)(6916009)(508600001)(66556008)(66476007)(66946007)(53546011)(26005)(36756003)(316002)(16576012)(4326008)(54906003)(38100700002)(31696002)(6486002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4RvNJX0V9fh0Bmg+cfj82ip/OGcBxR9gD5nIItat4b6Wo4QLodiWk2JggdIq?=
 =?us-ascii?Q?vfuUV5bwyLvdNkv7D98dtAxSjGfZ4ub82/3GiA1PVIeiVd5M67v0MALyKilw?=
 =?us-ascii?Q?QGgSJob4iM8sB8QpddE7voVTAZ+m/TwSKE8vev78jBXqeGrpH2EKIYM+nDIe?=
 =?us-ascii?Q?yNLdOdjo9O3BScBDx9veEWLHxu2bsQ8Mb1+00woWDKEXvAt53IV4eyiImIcT?=
 =?us-ascii?Q?SYwcH8H+f4KZWkqlc3MUGZ0QwBVe8VEfMcBKYsFg9U3VlwpBG70Zq3PYE6Re?=
 =?us-ascii?Q?U1oiF93KPPuXiIAR8SsJTnSwRun/bS9sKRQQefntGZVa6py4DL1h8AGdKi0w?=
 =?us-ascii?Q?oOdn2nXz1hgVrQWolz+TNxeVCMIlfZLlWsZkbnL2yOOKnSxD6U6uXozUPSM5?=
 =?us-ascii?Q?riGSdf1xpo+N4AsHiwKh3rq38+TDNNtzA+nyPa79ukG3wrg7B0rdZbphFHio?=
 =?us-ascii?Q?bBQPYCteST1p0gSlo2ht4u3F7Opay2SMhzBKdgbB8xxBpwlp92t7wOXgZ8SE?=
 =?us-ascii?Q?m+clCtN4FBia6/PrC5aEnWk4TlhvtuAJJ+UQsiAb2k1LDv/ZchpX1o26uvC+?=
 =?us-ascii?Q?allSJd7OPqqxZAs5X+el9MEByRruc1pgD1rEK6+TdMJhaMLHFRESTFAcANt9?=
 =?us-ascii?Q?24mk1xNChwDMiZ4gf18Vpec9cHTNEKw4r3ssq+XtUI+4P72J3YhgJhXXTs0k?=
 =?us-ascii?Q?g0QBo30O7ECAFR45YJK/RoFtbb6eSNTYnXgvMd+N4IuDxyU9CF+BHTHhZ3PN?=
 =?us-ascii?Q?ornLfRwWknM7XfQycNY/Z4IokqPrtiWKHXLWDOdbTUNYBx2h8KpUTN+jZIPI?=
 =?us-ascii?Q?HsrJ6WHGa/1TzARFZQhd4Xd1UXQN7qDO5oC3ix68kpx7rXwpcprEc3JuL5U1?=
 =?us-ascii?Q?ypq14AilwjjHGLkJ9PDdJCQh36EiKo7tALf1uArCP6tIb8f3j1a+7N3l7r/b?=
 =?us-ascii?Q?8bEzIiDuEXHwrsXGD2rEsWAv/7OEuLFzG+mKFg31OeJu2v8tCd2PRrSKVYGF?=
 =?us-ascii?Q?U/azLvCWBZ93X3nSwWS/SAxQQuvBlpfoxxLOVcHYy2NuM2BZOTkNANIuqfMo?=
 =?us-ascii?Q?vhNuie/UFAimM/4QzmPkA6BFtOa664B/7kzlyi4tjF0FvwXnkTetOsYpacDf?=
 =?us-ascii?Q?TFWGptI1Th6k618zPMt4+y8LL1edFvZhauT7iKnlOFbbdFcCg2fCylc6sWOI?=
 =?us-ascii?Q?mT11YreF9+KXsrfUpgItHkR6QrT4oqN9nfJWrQuxw7UksGeYBqaXBE80qZc2?=
 =?us-ascii?Q?gsAf9xnAhaHY/0ZmeMZGTgJTi9dMjwKQyKkl8O5RgfuEofaE+agWbRvAuP9F?=
 =?us-ascii?Q?AHjT6HAD7SsdbDe2Lmgsgo/28+NA0URsatlxxWRmqhtxWBRvndBEQA3UtQZ4?=
 =?us-ascii?Q?lrmw4EXKfcd0cQZlR1EyPTx+P1fe5qoeKk7LBS/S9QkbMLIL5FR9YIWMKmHq?=
 =?us-ascii?Q?BhKQVPDsgC2BF6qbqEO6T30o83mLv1Mq70NL9NKKayeG6DW4z/HTUbxQRa7u?=
 =?us-ascii?Q?EC0bUGjmcuFNL3XlvzYm4nKkfGiH7DOZnWYAb8uiyX3tKeuiv8ikYMPS9mD4?=
 =?us-ascii?Q?0jpDhFE1amOtkzwOSC8fDY//hS7vWPtKmQUACbXOki6m4VX6KTKKvwG86mDr?=
 =?us-ascii?Q?GICYgQCDbTUpUkxoGSSjzy8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 558a0d08-1af4-4d91-f430-08d9b8d423aa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:19:12.3338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7cOibVV6dIa3sPfimr+jcBZyF9O2zca7/iKQSC689A6Q5viBA0Zral9LjG+ugtQxJq4mxAVXWKGgU8zrmin9jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 29.11.2021 16:33, Roger Pau Monne wrote:
> Pull out the code from xc_cpuid_apply_policy that applies a featureset
> to a cpu policy and place it on it's own standalone function that's
> part of the public interface.
>=20
> No functional change intended.
>=20
> Signed-off-by: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:21:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:21:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239354.414858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGjw-0004ef-IH; Mon, 06 Dec 2021 16:21:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239354.414858; Mon, 06 Dec 2021 16:21:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGjw-0004eY-F0; Mon, 06 Dec 2021 16:21:20 +0000
Received: by outflank-mailman (input) for mailman id 239354;
 Mon, 06 Dec 2021 16:21:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muGju-0004e8-Rw
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:21:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGjr-0001Yy-W9; Mon, 06 Dec 2021 16:21:15 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGjr-00064c-QH; Mon, 06 Dec 2021 16:21:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7Dg3ydem1lgxY47qSTmEkw750BxEA2zKC3KXdut4/xo=; b=00g9JKii2Fwhdqh6LGQ5ixXf15
	xVpi+mt5grMyQnuYlio/H8C1g71cAz475aL9gT4x2HeerqUAzC2GsGuoPTD3vw71hKk+op4qfl/9I
	FdKzn2QVK6QEJW4Biec78lz2Qe+txd13h2IGdaSMCSJJGBFZqqrmT//VpGA0NfiAZUpU=;
Message-ID: <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
Date: Mon, 6 Dec 2021 16:21:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 06/12/2021 16:12, Jan Beulich wrote:
> On 06.12.2021 17:06, Julien Grall wrote:
>> On 06/12/2021 15:06, Jan Beulich wrote:
>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>> I am not going to ack it but I am also not going to Nack it if another
>>>> maintainer agrees with your approach.
>>>
>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>> I'm now in a position to put this in with Luca's R-b.
>>
>>   From the check-in policy section in MAINTAINERS:
>>
>> 4. There must be no "open" objections.
>>
>> So I think this cannot be check-in given two maintainers disagree on the
>> approach. That said, as I wrote earlier my condition for not Nacking is
>> another maintainer agree with your approach.
> 
> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
> going as far as minimally necessary. I therefore wouldn't call this an
> "open objection".

I believe my objection is still open. I still have have no way to verify 
what you did is correct.

For instance, the tags in patch #2 are:

Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
Reported-by: Yu Sun <yusun2@cisco.com>
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Acked-by: Daniel Walker <danielwa@cisco.com>
[Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]

The tags in the Linux commit are:

Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Reported-by: Yu Sun <yusun2@cisco.com>
Acked-by: Daniel Walker <danielwa@cisco.com>
Cc: "Yixia Si (yisi)" <yisi@cisco.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

* The first two matches the original e-mails
* I couldn't find the 3rd on the ML.
* The Cc could be ignored
* The signed-off-by are I guess what you call "mechanical"

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:24:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:24:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239360.414870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGnB-0005O2-1U; Mon, 06 Dec 2021 16:24:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239360.414870; Mon, 06 Dec 2021 16:24:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGnA-0005Nv-Uc; Mon, 06 Dec 2021 16:24:40 +0000
Received: by outflank-mailman (input) for mailman id 239360;
 Mon, 06 Dec 2021 16:24:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muGnA-0005Np-BB
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:24:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 026ee43c-56b1-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 17:24:39 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2053.outbound.protection.outlook.com [104.47.6.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-cAKXeXhmNgqWsKsfVs4-AA-1; Mon, 06 Dec 2021 17:24:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec
 2021 16:24:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:24:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0403.eurprd06.prod.outlook.com (2603:10a6:20b:461::33) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Mon, 6 Dec 2021 16:24:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 026ee43c-56b1-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638807879;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6EGC4bhYg8Cm8dTR5PZqCzbg4FNGIQQt/WhIZIz7lAA=;
	b=Lmx329QVRxE7oWTXtt8CNCdmB62pdyrRnrcEccWInk52yySfKpYe4BhodCyWOOCgVRgEqS
	T8kaQcqy4pw8EdS1c7qi9FZFh5IozZmdZ8Ni93vl0lGTHnPYxZRQ8ZimfbeDX1E5+Iku/i
	r2900HB91Fd3CVNGwu6RK9b95PLMg+M=
X-MC-Unique: cAKXeXhmNgqWsKsfVs4-AA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hnxE+LWTFrVP1zRLLw0bkPsblVNW4Aw69vTKIBzpjV3DZwFFMWW1tCCXqMu8PX4jSxiWVBmBQ2kc9e6XD3ZYn6feSw7ns6n4H7eBafZsQ3PgIVC5s9vHl7ovkLIREB6PyTI/aUud2FuIifVofiTrNHEpnKvkZm90H7xnE+q3+9Y+7CyNHGWaVfX0lkupMhMRWnTxe3gtYyLItR9rWgabud6ndzDP+dyOr8ML1eaxy0R4AdKZT2C2GLs1aHztvaIwu315QoK07H4LhU+aeFoeXpUNt/qL7KjqBr6OFYDAABXNs7nOIE7MZZe4R+Sa670Jm5vyLhjTq83aYbgj/V/Ysg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6EGC4bhYg8Cm8dTR5PZqCzbg4FNGIQQt/WhIZIz7lAA=;
 b=MGl3sfDAuDykz6LwdIqNwEMGOkW7uoxsLt1C9BZwMqsINDO6zdJM90lxnQ/qewXNiVqPdGh0oTzL2rKohgP0RpZIhaObk7Rd7rk2WXblPky6qfoxyj+Zt8406ranubplG+v3XjnjsUNGCidNNOFB3Jm9c6U3FJR3iXb7jfTY3DRqFf67orbckx2eyjQFBR1UDMP5ntGjPiNfJJV63gIEdAA0zkkGFUEC9occyYVimTpi+k9QBIgOz8s9mvKLatntMXIGx/AZQ6SQj+q7VshKk4a89MnvabFc4ypA6Ku/hKWHVdAQRXGcpirrW3RMJwf1IJDSkMvG6Dz5sOFiRr+JjQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1a708488-efff-114f-0693-c9772b5ff9b2@suse.com>
Date: Mon, 6 Dec 2021 17:24:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0403.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d216a99c-0909-4bbd-e6e0-08d9b8d4e4be
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3775118EA1F9FA615DBFBBC9B36D9@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PbATuyrCyMtrdksX/bFvsqpAkU+awR8Z7RWBjxrB+4ayetIsnVkBjRA+C3bA6pXGw44SWTlPXDwW97eng3L8+EM0IA+5rEock6QZcVhiajTBPPqhIFqDdwE0+N10zPfh2O64+eCeYGxUjvPYc6NTxaElzfLn2UGl3Yoqc4Q+pqle2Zu8/vRsEdCrKSZer9BkysIZM8d0W8rAN65mv9Eyc+irwSkOtc8jIRDqmfPGVbcdkxLq6WWFyMTf90gVX2lve/sR78wlSWH+b+byolyvm+H2ZbfYJ5l3nN+s1Y2DjP9VZcebl2GR+UyFqlCMqTEBANQjSpJdpGf53lq9H6kT9qkxKk04CbnaQ6+y4OpO35eE5/gd2cc2Yy6sLiZKfrr0ZulaY51BafroXqDBjXsJ2kynmMoconWqYruYk8pDIfYppyyNEjWfUMaAzJDguCE15ClE1G7Ln9g1aUgHUI0FiGnLDJkOGNwMGER1k3lLcThuh1I104YP/7EJE5sM6UiMZHf8wmL8QQtfr2H1OG7XCFiCRlkcUgVHMyH8Zudt50/iIdmqFbXNEEvbIP09A/a9eCe+xVOJ4iNeNOSLdP8+iWKJGypGHnRd4jow0rdndHqGK94qlITPlwt/4Ieto/HE/J9GpEM5v7jcGJ9CtnQ8rSq8By63nJX13ag9Sd4hXhrV3ZazjSBXjyghRYnQj644ybtxRfbu5+886lKDycHzQMJrsM9DAb4Qa9OPX13GMYAFA0srGKJDGpWwGRVXUyvu87Cn8Sn7iZc0Yzw4ApJG7XaaNauRZzb8HNmNIgqOva+FeLKxSjSNmP5YiCTyGUxRvTpWaDtxnOXa6QpO/njgTg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(956004)(31686004)(8936002)(186003)(6486002)(36756003)(8676002)(2616005)(5660300002)(508600001)(83380400001)(38100700002)(6916009)(53546011)(966005)(54906003)(66476007)(2906002)(66946007)(16576012)(86362001)(66556008)(316002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YytCbFF0MU50czQ3YnB3czNSUXVNUHRlTUJSOFNRRHJjK0NkNGlSNDJBRFhN?=
 =?utf-8?B?SUJxV0YvakhJUnNibnVWYWs1ajFGMDJ2Tm1uUGg5YlV4NUZkVVlqWW9ZM0Mz?=
 =?utf-8?B?TmtzSzA1UHlybHdzV21OOXJnc21FVWNJRG5RVUpFS25IbitnOHJZTTJ5M0Ja?=
 =?utf-8?B?TEowQStsbXBnUFRPTy85SWpNZHV3VGxjYUhIVjFuemtadmo5aGFDMjB1R212?=
 =?utf-8?B?c0RjcHovRjUvTE1LcG4ySnZMNGltMFlubHlUL3AvNjVFbWZ0SlBGMUVRNUlC?=
 =?utf-8?B?aUk1UlpoRkE1OVRDdFpZVW15d2dEYjQ2MjZnL3VjRWtqWFlncFJPSlA4SGhn?=
 =?utf-8?B?Zm5xc1I0MEZKM2lwQ1p1TUFRYm5YMHRScmRVbS9NNGxhdlpRUTNUOVRWeUN4?=
 =?utf-8?B?ZmUyS0lUQ1dYSFYvbXRjMTdiaHhkRkQrcm5OYkFxbHhnaGFYL1FidzVFZW1W?=
 =?utf-8?B?eHpDcDRlbEFDSTFZMDhzUEptL01DU3ZJTHRYU1dQNXRCSXJaeWtZQlpGOEVs?=
 =?utf-8?B?RVdyRGhUaklEamtGczJucDRySzlGTmlRVThub2FUYjJlbWpZRkRTeWRrT0Rs?=
 =?utf-8?B?M0JETW1kTzYxQXZGbzNkUkxNRXcvN0Nnb25mTnNGZmhkWTNma3VsTUt1SGVx?=
 =?utf-8?B?TGtZZkxJY2h6TmdqRmxvc2plL2REYklLS3ZMWU9iYmdKOWlxdjlkakt4RGM0?=
 =?utf-8?B?ek9YOC9RdTV3WHhlbk9kdUFHRnN0YWN3cEFldGpTSi9MRnlLNEZhTEFka3I1?=
 =?utf-8?B?ZTBiTSthRUhXNkl0dTg0TUcrMnJZMklIS2JGRXhjYTBwZGFvWWYybXhnL1Vk?=
 =?utf-8?B?eVN3YnNTWUZSZHZxOGMyZlRQRCtab1FnMDlKQW9saXlrR1VDNHJ5OWhVOUpp?=
 =?utf-8?B?RW8vMHVHQWw4VjRXUWRKK1JDMTJYUzc0eTMvZlYwVHBPZUE0RXNLVVhwYmxR?=
 =?utf-8?B?RmMvSmZGWWx2QkVPalVUYWFxQVlIQTlrbHpwNlVlY0VZWjE3ZUgwWnVDYzdH?=
 =?utf-8?B?UjhtL0ZSc2k3VHVhQ3JyelgzK2JxdGovbTVZZFRCdW9IaC9MQTEvdklWaFVX?=
 =?utf-8?B?QTVVWHY3amE3R3p3U1RIT05iMnp0aFRRa0xrZUx1NkJkU1pWcGl4aFhxd1Bz?=
 =?utf-8?B?NTByQmlHQXJMcUpmekRkVFZzcks5VTZjeUVWRmh0aHR5UzJWQVd4Tk1vOUI1?=
 =?utf-8?B?M0k3ZUswNjRXVVZvYzc4ZGdwbDgwZ1dHRk01Ny9xZjZLK2ovRnQrQjNkbEhZ?=
 =?utf-8?B?Tlp1b1NBMXhiOVNnQWZRL2x6QjBGMWVsVnF3RnowQW5UcEZ5STcvZS8vNThm?=
 =?utf-8?B?SXdLQ2ZjRFdUVjRaZVdWaHR6R2ZFMlJBSG5sUWxRNkFObUxNWU9SSURGVUpO?=
 =?utf-8?B?T28ydzBoNzUxcXY0MU04Q2RobTJ2bnBuQlk0SllTdnFyTmFqUDgxVHQ1ZWlG?=
 =?utf-8?B?WXdMeTFVVzRwd2FscHpBOHpwS2Q5S0ZqZ1Z6YnA5bWl4akpMR1d0THdpYVVX?=
 =?utf-8?B?anNiSFVIRHFkbTZQb2JaYTNSeTBNdWlZWVVtZlN1UmVDaUlteFBpeVh0QzVx?=
 =?utf-8?B?UGlzblpVSXdHWk94M2NieDNncS9XbFN6T1NrcmVMVSttOWwrN0ZvTElHOEd0?=
 =?utf-8?B?a2owSDRYTVpQR0oxbmRMdytHMTJOUjczNEE4QzVVZnZtNFVsd0V4T0tzZFFW?=
 =?utf-8?B?ZU5TSllRVVRKc09ZTUpnaERkN2k1bUJxRXhHd3FEckRXZnpoNGIvVVpyc0RR?=
 =?utf-8?B?TDdFWDdKdTAvb0haMmluVGlqckJXNGNldWdMYm9Ta3I1UFFCQ3ExdWZBd2g1?=
 =?utf-8?B?Q213N1hnWUt2SEhxWjBMaEZKb29iek9vVGdXV2MvRlUzbWpwTlVreGVHYjRZ?=
 =?utf-8?B?Q0p3UC9hMFMzMVJ3Qzhxa0ZkZEcxYXhJcElqU3M2SEN6eW9nUDdPSndmcVlU?=
 =?utf-8?B?Yy93OEpsRU5VMENjVlpNSy9OdVNkTFhwRC9JYTVaemMvTC94eTFCZHQzQmRG?=
 =?utf-8?B?S1dmemJPS2t2Vm5rS0pmRWYzbk9kOTZHc0cxek0xZEUxNENFVHZwT2EyaDMv?=
 =?utf-8?B?aVIrMXlvczVOZ0Z0NmJFM3hSNXZJVGM3NHBHaFRqODAvV0RYWFNYY1RxLzU0?=
 =?utf-8?B?R3o0TnV1cUlGSzZMdUc3STUrNU4rZmtoK1puL2pOMzhRdWdidzdacTdaUGNn?=
 =?utf-8?Q?r5ert6OnSYpucHTplMnhcss=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d216a99c-0909-4bbd-e6e0-08d9b8d4e4be
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:24:36.1608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZGfThXlIkic8RqfDwIHBxn2RD3oiTWYinK1zzwhukvSS81QK/F7G6zyc0FJFu2Koln/6cCZCvQQTFj5ee1VDlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

On 06.12.2021 17:21, Julien Grall wrote:
> On 06/12/2021 16:12, Jan Beulich wrote:
>> On 06.12.2021 17:06, Julien Grall wrote:
>>> On 06/12/2021 15:06, Jan Beulich wrote:
>>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>>> I am not going to ack it but I am also not going to Nack it if another
>>>>> maintainer agrees with your approach.
>>>>
>>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>>> I'm now in a position to put this in with Luca's R-b.
>>>
>>>   From the check-in policy section in MAINTAINERS:
>>>
>>> 4. There must be no "open" objections.
>>>
>>> So I think this cannot be check-in given two maintainers disagree on the
>>> approach. That said, as I wrote earlier my condition for not Nacking is
>>> another maintainer agree with your approach.
>>
>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>> going as far as minimally necessary. I therefore wouldn't call this an
>> "open objection".
> 
> I believe my objection is still open. I still have have no way to verify 
> what you did is correct.
> 
> For instance, the tags in patch #2 are:
> 
> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
> Reported-by: Yu Sun <yusun2@cisco.com>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Acked-by: Daniel Walker <danielwa@cisco.com>
> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
> 
> The tags in the Linux commit are:
> 
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Reported-by: Yu Sun <yusun2@cisco.com>
> Acked-by: Daniel Walker <danielwa@cisco.com>
> Cc: "Yixia Si (yisi)" <yisi@cisco.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> * The first two matches the original e-mails
> * I couldn't find the 3rd on the ML.
> * The Cc could be ignored
> * The signed-off-by are I guess what you call "mechanical"

Am I understanding right that now you're complaining about me
having retained one tag too many? So far all discussion was about
too few tags.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:30:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:30:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239367.414881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGsh-00072q-Nl; Mon, 06 Dec 2021 16:30:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239367.414881; Mon, 06 Dec 2021 16:30:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muGsh-00072j-Jw; Mon, 06 Dec 2021 16:30:23 +0000
Received: by outflank-mailman (input) for mailman id 239367;
 Mon, 06 Dec 2021 16:30:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muGsg-00072d-GY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:30:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGsd-0001i5-1Y; Mon, 06 Dec 2021 16:30:19 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muGsc-0000BA-Rg; Mon, 06 Dec 2021 16:30:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=DjieWqTnLrf40ufKV94QEKNdBFHfPiZqhGkuQwuhFHQ=; b=HMK5m0A7v/WyadltEXHxtI4T3k
	/oCrc75Q1YkMhuNnt8Osvb3x+Y7OLT9mtf6QFirX8V3uTs+PSxce5cubDcZtcrmvn8iB+DdFsOmEm
	QxiHavr2f7Ak4zajf+NbtXp6U6Ah4utntb59IX72j7KP4F2POoJrAq5lcM6FhdGmZeQI=;
Message-ID: <5612585c-f650-18e9-676e-58dffb68280b@xen.org>
Date: Mon, 6 Dec 2021 16:30:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
 <1a708488-efff-114f-0693-c9772b5ff9b2@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1a708488-efff-114f-0693-c9772b5ff9b2@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 06/12/2021 16:24, Jan Beulich wrote:
> On 06.12.2021 17:21, Julien Grall wrote:
>> On 06/12/2021 16:12, Jan Beulich wrote:
>>> On 06.12.2021 17:06, Julien Grall wrote:
>>>> On 06/12/2021 15:06, Jan Beulich wrote:
>>>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>>>> I am not going to ack it but I am also not going to Nack it if another
>>>>>> maintainer agrees with your approach.
>>>>>
>>>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>>>> I'm now in a position to put this in with Luca's R-b.
>>>>
>>>>    From the check-in policy section in MAINTAINERS:
>>>>
>>>> 4. There must be no "open" objections.
>>>>
>>>> So I think this cannot be check-in given two maintainers disagree on the
>>>> approach. That said, as I wrote earlier my condition for not Nacking is
>>>> another maintainer agree with your approach.
>>>
>>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>>> going as far as minimally necessary. I therefore wouldn't call this an
>>> "open objection".
>>
>> I believe my objection is still open. I still have have no way to verify
>> what you did is correct.
>>
>> For instance, the tags in patch #2 are:
>>
>> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
>> Reported-by: Yu Sun <yusun2@cisco.com>
>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>> Acked-by: Daniel Walker <danielwa@cisco.com>
>> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
>>
>> The tags in the Linux commit are:
>>
>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>> Reported-by: Yu Sun <yusun2@cisco.com>
>> Acked-by: Daniel Walker <danielwa@cisco.com>
>> Cc: "Yixia Si (yisi)" <yisi@cisco.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>
>> * The first two matches the original e-mails
>> * I couldn't find the 3rd on the ML.
>> * The Cc could be ignored
>> * The signed-off-by are I guess what you call "mechanical"
> 
> Am I understanding right that now you're complaining about me
> having retained one tag too many? So far all discussion was about
> too few tags.
I am complaining on the fact that this is really difficult to figure out 
how you decided which tags to keep.

I will repeat what I said before, it should have been so much easier if 
you just copied/pasted the one from the Linux commit.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:41:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:41:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239384.414895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH2o-0000Tx-Qu; Mon, 06 Dec 2021 16:40:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239384.414895; Mon, 06 Dec 2021 16:40:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH2o-0000Tq-Nq; Mon, 06 Dec 2021 16:40:50 +0000
Received: by outflank-mailman (input) for mailman id 239384;
 Mon, 06 Dec 2021 16:40:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muH2n-0000Tk-5J
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:40:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muH2m-0001uX-2e; Mon, 06 Dec 2021 16:40:48 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muH2l-0000ym-Sq; Mon, 06 Dec 2021 16:40:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=693K+3xMOgysjnPdnbcZxJSUGbh0Yd6C7XdavfpaaGo=; b=LVQcEyu5flySv4Gdzw8GvMaYn/
	02K1CLNQ5Si1av2xnX/ecpeM8XoZsCwH7d7i86nURl9fnghq79xaYPx/M3W5h0gtrIE8XLNenpslw
	AENoHthImnJZTkLdc7YfkImPH3wUgZfUcnrMi6hx+WDFf8uBR6l1BmIuMj4gio7zY10Y=;
Message-ID: <65035935-935a-f8a9-a797-5d6a1bce4e66@xen.org>
Date: Mon, 6 Dec 2021 16:40:46 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Do not include in the image functions...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206141923.26757-1-michal.orzel@arm.com>
 <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
 <e149b283-23bd-9d8f-4be4-4a26722f0ed6@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e149b283-23bd-9d8f-4be4-4a26722f0ed6@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 06/12/2021 15:00, Michal Orzel wrote:
> Hi Julien,

Hi Michal,

> On 06.12.2021 15:39, Julien Grall wrote:
>> Hi Michal,
>>
>> On 06/12/2021 14:19, Michal Orzel wrote:
>>> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
>>> CONFIG_NEW_VGIC is not set.
>>>
>>> enter_hypervisor_from_guest is protecting calls to these functions
>>> with CONFIG_NEW_VGIC but their definitions and declarations are not > protected. This means that we are including them in the image even
>>> though we are not making use of them. Fix that.
>>
>> While I agree, they are only used by the new vGIC, the implementation of the functions are not. So I don't think they should be protected by CONFIG_NEW_VGIC.
>>
>> Actually, I am not convinced they should be protected. But I guess you did that for a reason. Would you be able to clarify what is your reason?
>>
>  From what I know + what the commit introducing these fucntions states (b9db96f71a74), the current vGIC does not handle level-triggered vIRQs.
> The functionality of these functions is only related to new VGIC implementation which can handle level triggered vIRQs.

This is a known error in the vGIC implementation which should be 
resolved before this leads to a disaster.

> So I do not think that these functions are generic and thus I believe they should be protected.

None of the functions rely on the internal of the new vGIC. In fact, as 
I wrote above, the current vGIC ought to be able to handle level-trigger 
interrupt properly.

They are not called for the current vGIC because there was concern about 
the performance impact on each trap (see [1]).

So I think those functions ought to stay compiled in for everyone.

Cheers,

[1] 
https://lore.kernel.org/xen-devel/22601816-8235-7891-b634-4af5348a1337@arm.com/



>> Cheers,
>>
> 
> Cheers,
> Michal
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:42:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:42:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239389.414907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH4S-000152-7E; Mon, 06 Dec 2021 16:42:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239389.414907; Mon, 06 Dec 2021 16:42:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH4S-00014v-3q; Mon, 06 Dec 2021 16:42:32 +0000
Received: by outflank-mailman (input) for mailman id 239389;
 Mon, 06 Dec 2021 16:42:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muH4Q-00014n-LV
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:42:30 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8013438c-56b3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 17:42:29 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-joOXOMAXNkm6dpZMAXXQ4Q-1; Mon, 06 Dec 2021 17:42:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec
 2021 16:42:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:42:26 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR02CA0001.eurprd02.prod.outlook.com (2603:10a6:20b:6e::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 16:42:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8013438c-56b3-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638808948;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HZi3AxTdExXlR+Y06/82M2J28uaSxo3qoPiHhYf1K5o=;
	b=nN/dqG9rN2jD9f73DQmlAi858zruRBz2muaVyL/HP4vH6Np6unJsuYyCiy+vcCZ7TnH5PR
	PQLtSL9R4uZ7OKqU00NHhmdwZkecA1vU5aSsMDszx2tSXPxC0CatZHFwBfHrKqPt3eGVfa
	dLElUJsDtMIXbplZfaSPWSK7jH2m5P8=
X-MC-Unique: joOXOMAXNkm6dpZMAXXQ4Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZOo+ryosl4qWptBjRCNuGhyRdyXmJtQRK/gu8UW7Qw4VYd3LmxCZemzZWarI5e4MBfb4ebePCJipzj/xjZ6vpxH0U4eo0jGCxy+S/cqa+KHyZT1OB8lYzEHBEhVHMQBN6jFbDAwfgP0CQWkGrGSo4Byghq7VYp5qZ1lg7klnoyisI5fziVfbY1B/7nfhRbXHmNcZ/iQiT0ywwIP04e/qCBEamhQl0yMSPEPt64a4ToGS5TLbpJVAgOkawWlYIPWK/44Rs0RG+zn6A2k7iB9oGdUIfn7eqCxFYP2yVThMsEnxziR/tlzEv/Li5HrFUMG2HR9vxADBqi70BGGXaVK+KA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HZi3AxTdExXlR+Y06/82M2J28uaSxo3qoPiHhYf1K5o=;
 b=Lf/x9UxawKs+hoZtBW+G9XC4DmR7fbxzykBmtBYttTtFVUG3Vaa+wijZuz26yLqQfoFIs2/iiX8HlqXy5UuHIpxb8+mtOm1uKPS+G2ZyI8KVqEduaeD/taGVDuiaZW/33dNY03PSO/4gJpNDcIn5gHo4DfmVMCozZDcrGdYTY0TN80aYJfhGJkq8+4dNtC4zj6oSYYvUzoN/Eyr4UbSMN5iHIWgPJ/9G4HGYsenjtmuyyJCnEnJwTeiPYrcGyCSUfVMPCdf77No0KRGb9nl0X6ifrrQ9xi4fRZdb3lPwromF0/4pfRl5kLLiGeuSTkGZixFld9NeGoWjguJQ0wn6ZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0a6d8d02-12e4-3c39-ba63-735d94805ded@suse.com>
Date: Mon, 6 Dec 2021 17:42:24 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 06/47] build: avoid re-executing the main Makefile
 by introducing build.mk
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-7-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-7-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR02CA0001.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9cc7556b-f9d5-4bf0-910f-08d9b8d762a6
X-MS-TrafficTypeDiagnostic: VI1PR04MB5325:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53256869DA3F8C28008BBA90B36D9@VI1PR04MB5325.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yGaNqifkIs7slp4kibzY8Ubz6yDVKUNWxb2PS6hnp+ZY7jmmdTP1xSy4IKRHrKWeyMdbNM0SAvSDBaj6FivBkxPrtVWIUWOwkfM+uAa6wI4q5AVTq1cQ0I9j+qiBs6W992J6JafZVlqXJKKlj0x8RK0KZFDyJueniHAiBWVvlhuqFpQcNSucO0ss2lSjmKLS4mZxqfaK9w11OKkkPZ8Yg83JLkRdOogtFYRvdcNPSYBBkf8uCikr8RwsQRkVEGCHhqH32KDVTZB0zhr4HyKziZOaRB2RB08vKXZGTBdoBPI+2zSAx6/knZUHyIRB0MuP1P1C8nPG5ri/r8ORW1DPNkd1m940m8ui7i61yWhgiUadaXfnRQ/HU4UGp+cEA9DnqvL+UyuMnNjcZnN8Xrxlo/URbheZ3dBKUjW7iyxykNt6JMKGTi3IZzPPhJ4pbt9k4EJeEiXF3oZNVs7wEJV+1XBFr1Xvpak6URpSeMmEvYBr+jmPLoYLgZ9CoYjhjQVd0RJov9J3IssDLoLWUo+WLOtY1U6IezUUDA6/jtCihPvmJP0U7FsiVDWeRxIuSuFoAl6EQBJb7/bRnBgBjjcIDvqRFYxAZwigCog/4bjgTp5q1wJ5YYcSIz4AcTxxLKCyTxJI8ITT+L+HDxQOjEwAOi9XG47fe8BwAUlJbQAmoUJOlXIupMLqnCSfDk21cJg420QDKjzyIHuZXCe6H6/iI5dSGfhoMVve6MqszaunQL/7DiZ0qo+XDB15dWhDe5Xs
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(38100700002)(4326008)(6486002)(31686004)(26005)(5660300002)(6916009)(36756003)(186003)(31696002)(8676002)(53546011)(2616005)(66946007)(316002)(54906003)(66476007)(8936002)(66556008)(86362001)(508600001)(2906002)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NjQ3YW1aUkJEbUFydDZ5S0VEOEE1SE9VUVpqcjAvT2VtYVg3anNWRVE4U0Yr?=
 =?utf-8?B?dHBIbW5lcWN6OUtoclBOa1VCVmptZnRDRFVpY1dBMXZDZTJZcVl2SkJVZDZU?=
 =?utf-8?B?b0t1WW1HYUZmRUZycE5Rbmtsc2Z6bkM4SU1zdjQ3enJQU1AwMHlHNlpkbkJa?=
 =?utf-8?B?c3UvSVhBelhzNmNKWFNUaTBuTDJKRDF4RlF4OE1VKzdPZ2xsQlJwcTJsRERX?=
 =?utf-8?B?TE9XTXRGUWpsb0VhdkJZWmR1M01YcXE5L1kwNVdJU2JMQ0ZSNDMrMEhleDJ0?=
 =?utf-8?B?aTFOMlJDa1g1WkRlWERNeFZxUEFVU2w4QjRuZTZOV29iNkxIdGt5bHZ0Z3FE?=
 =?utf-8?B?UmhyTkhCYXB4S1FVOFVMNFkwNm13SGVmNXowWXA3OTFwT0dNc25odko5RjFX?=
 =?utf-8?B?QnppK2ZBaG51YmRSUFdnRldSbzdMM3dYN1RuKzY3aWQ0bmdrekNPOFhCd1pV?=
 =?utf-8?B?N2tlbXc5Y2JCQSt1SkhFVVNYazBDOXNuaDFRZFU3NWhuOUJWOHhpb05Bb1Z2?=
 =?utf-8?B?T2h1UXJlRGJjWm9UQ3dVZW9UWVhMSDdMbStvclVFT1ZldlhnN0pqKzR3MDRF?=
 =?utf-8?B?bHYwTkwvd3VhNVluZ1lGc0NkWDZLMVU5Y2VLbGhoWENtMmJxQ3NJQ3lnVm9Q?=
 =?utf-8?B?cEpFUmo2elovcU10Z2lWR3BaTXNMaXVRaWk0bVMwR0tNTThtZmRhckFmK3Yv?=
 =?utf-8?B?QTlEWVdCTDNPR0NXY3lxR0lKTXBYVTJPTTQ2WklvUDFORUdmUVQ0Wmw5akZo?=
 =?utf-8?B?NWtDbXpraGNIUFloK2dGRGY1L0ExQkFhd2NnVXdxZWhNVFNOeEVXVUF5VDZ3?=
 =?utf-8?B?ZW4vbGZQVW5YclNickwzUDhNamlvQVNaZmgwb1crd1p2MnQ5dFNWMHZnOVJn?=
 =?utf-8?B?TUxzOWxadytncHg0VTlxSlVyTUJLekxhU2g4WEdVSE1hcVltR3JXeVpVbHNJ?=
 =?utf-8?B?VmVUaUJ5WS9mUDRGZzFqc1dMWFVIR0doeHVkUXA5b1Vkempqd2M5M3NxVVhC?=
 =?utf-8?B?MElsdXdJQUg1cTlyN3FEcERFMXZKVjJwOFBvWVJQRjdzc2lvR1B1VkpMZUdv?=
 =?utf-8?B?bnFqRTY5c3AwbklUWDZZL1U5T1pVcXIzZW1VV0JOUjNpUTRDTXdLd2NmTzdv?=
 =?utf-8?B?MXcrOXBRbGY2NFFOTDhiVjcxUVRKM20vcDBpelJFWkxyL0wwTWttRmNGVGh6?=
 =?utf-8?B?YnZQSmZOS2ZwVjJQT0dxWVZnTmpJajVWam9TTUxnU1lJYmtKeG9yV0hLbHJY?=
 =?utf-8?B?U012KzYyUjVMQ3hqUERGUjF5YkxYQzFiTDNhN205ZXFHSkpmL2JadUpYNmVh?=
 =?utf-8?B?TGw5dGhqdzNxSCtkc2ZGMUlYS292aFZ5Q3ZYNGVTa1BvR1JxbGdjSWIxYms4?=
 =?utf-8?B?MlA2R20wRThsMGNkdGk5cEh4NGRSUWQvalFKMEJTNEtqT2lvR2psc1FFWCt2?=
 =?utf-8?B?aEh6TTc4TU1oU0ZoM2NOZlNxditPTjF4V2dDRmFtcnVXaVNIVHRjT1Rka09m?=
 =?utf-8?B?bEVSTzV5ekE4WFNqY0Z5ZFBWSFpaSmJBTTBqYUtTWWdUTEtlVGtsMzBVcUxZ?=
 =?utf-8?B?TmNHeWhWUTNFOEdUTVJuU1F1Z0tRL2NhYTVFaCtmY3FyTjBDTDFpc0ZFZUpC?=
 =?utf-8?B?UzQ0eFBZeVZ6eXVGZUZwWktLNEtiLzcrYnphTmRCcUY4eDlzSnhhY2h0c2Jr?=
 =?utf-8?B?TDFxUWZWNkhDQXE4cmxSRkpQcHJ4MjF2MjVELzFWdGcxbDJYZlNHOWRYSkdB?=
 =?utf-8?B?NHNjcDFzNEI1dlhVVkxaQnRyNk8yeVY1VHdlS3M5R09uNHMrdjJjRXFwMVFs?=
 =?utf-8?B?MHZwMVdxL2FQVVJNTElJeWp6dUYzMVFraWszMGxsVWhqQ0NKTFF0L1lEcU1s?=
 =?utf-8?B?eGFVNXZaOW1PMmI1bW9pVEliRGVzU2VvWDNvSGlHVmxNU01xZU56UFZlTmFT?=
 =?utf-8?B?RTZEUXM3U0pOd3NrL2RpMmhOY1NxL3hYUzB1amU5eldiZ1BGZjZhYWQxYmFv?=
 =?utf-8?B?Qm0xY2d1VDNENTBNOUI2VVRSZERsc1FLdWV0Y01mM3B3TldqekVkVi8yY1gr?=
 =?utf-8?B?T1VhQ2hVL1pmVXJhM2lsSHRrWlNOZXB2TWNteGR2Rk5HZFdyZ2dIUWpEY2lD?=
 =?utf-8?B?emxLUGt1VUoxa0djT1QrZ3lMOUNHYXZrU0xLeGI2VExvOG9acUNram4vYzNY?=
 =?utf-8?Q?/vl6halFtBRyGeKy5sF4tb4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cc7556b-f9d5-4bf0-910f-08d9b8d762a6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:42:26.3427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7+UogSRdwGpzg/nsCYbjUKRqGxsI+2dqyWkjzZYrENke/eMtkmwjbQK2oL8yQ61dv4CX6ajI+WPvm54g8im7bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325

On 25.11.2021 14:39, Anthony PERARD wrote:
> Currently, the xen/Makefile is re-parsed several times: once to start
> the build process, and several more time with Rules.mk including it.
> This makes it difficult to work with a Makefile used for several
> purpose, and it actually slow down the build process.
> 
> So this patch introduce "build.mk" which Rules.mk will use when
> present instead of the "Makefile" of a directory. (Linux's Kbuild
> named that file "Kbuild".)
> 
> We have a few targets to move to "build.mk" identified by them been
> build via "make -f Rules.mk" without changing directory.
> 
> As for the main targets like "build", we can have them depends on
> there underscore-prefix targets like "_build" without having to use
> "Rules.mk" while still retaining the check for unsupported
> architecture. (Those main rules are changed to be single-colon as
> there should only be a single recipe for them.)
> 
> With nearly everything needed to move to "build.mk" moved, there is a
> single dependency left from "Rules.mk": the variable $(TARGET), so its
> assignement is moved to the main Makefile.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:46:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:46:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239395.414917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH88-0001jR-NA; Mon, 06 Dec 2021 16:46:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239395.414917; Mon, 06 Dec 2021 16:46:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muH88-0001jK-KE; Mon, 06 Dec 2021 16:46:20 +0000
Received: by outflank-mailman (input) for mailman id 239395;
 Mon, 06 Dec 2021 16:46:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muH87-0001jE-K3
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:46:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muH87-00021Q-Ha
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:46:19 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muH87-0001V9-GM
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:46:19 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muH7T-0001DM-Og; Mon, 06 Dec 2021 16:45:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:CC:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=zpKGbNzZ5iNrE/1aOkVmB/OoE7IzfFoUjJ55fuVCEa0=; b=jpI0hitwkQ/wJs9CMpmQbGtbrz
	xYw7DwxtwbGAERWXJTWHiQ+Xy1qUW+e58DNwv80ZSPVVPkcVLO9tgP3gPbSVZk1CtGQO6j8fPWmkP
	tWAMUPgNDhIhddVvMCZHuEhSkURgQ2/HT7975/EMAJLlX4RXNhyJaA+3dMwdr87l1u+M=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25006.15894.801771.928097@mariner.uk.xensource.com>
Date: Mon, 6 Dec 2021 16:45:10 +0000
To: Julien Grall <julien@xen.org>,
    Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
In-Reply-To: <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
	<0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
	<a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
	<b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
	<0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
	<71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
	<ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
	<c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
	<0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
	<6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
	<bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
	<24992.55453.893877.246946@mariner.uk.xensource.com>
	<2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
	<c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
	<e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
	<53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
	<5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
	<9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Julien Grall writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
> On 06/12/2021 16:12, Jan Beulich wrote:
> > Hmm, I did address both your and Ian's concerns in v2, admittedly by only
> > going as far as minimally necessary. I therefore wouldn't call this an
> > "open objection".
> 
> I believe my objection is still open. I still have have no way to verify 
> what you did is correct.

I can't believe this is still outstanding.  I think I understand
Julien's position, and I agree with what I have understood.

In particular, I think I understand why Julien feels it necessary to
make an issue of this.  The Signed-off-by lines are there to help
provide assurance that we aren't making legal mistakes.  They need to
be verifiable by a reviewer.  So that means that when a patch's own
declaration of its origin is "this patch came from Linux commit XYZ"
then all the S-o-b in that Linux git commit should be retained.

If the patch came from somewhere else, eg a mailing list post, I think
it would be OK to say something like "this patch came from lmkl, [url
to posting], and has since been committed to Linux as [commitid]~".
In that case the S-o-b should match the mailing list posting, but the
Xen patch being posted must then be identical to the mailing list
posting.

IOW it should be a deterministic process to start with the patch's
declaration of where it came from (or which sources it came from), and
verify that 1. the patch really did come from there and 2. all of the
approriate tags, especially S-o-b, are present.

By far the easiest way to achieve this is to take the patch from Linux
git using (eg) git-cherry-pick.  git will automatically DTRT. [1]

I don't have as strong an opinion about other tags, eg ones indicating
approval in Linux.  However, I think the overwhelming majority of
people would think it conventional to transfer all of the tags from
the original commit even if they are irrelevant in the new context.



I don't understand Jan's position.

Jan, why are you fighting so hard to delete these tags ?  What
practical harm does its presence do ?


[1] Jan, I know that you don't use git very much.  I think this is a
great shame.  I find it perplexing to see how anyone can work without
it.  The git command line UI is indeed terrible, but by now almost
everyone has either bitten the bullet of learning it, or adopted one
of the overlay UI packages that now exist.  (Personally I did learn
the cli but am starting to forget git cli nonsence since now I do
almost everything with magit inside emacs.)

I think the time has long passed when it is reasonable for a key Xen
developer to ask others to do additional work, or deal with anomalies,
in order to accomodate an unwillingness to use git.  Obviously we all
have our own workflows, but git has heavily influenced our shared
norms (and data formats).  If someone chooses not to use git, they
must at least be able to pretend.


Sorry,
Ian.


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 16:53:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 16:53:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239403.414929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHEZ-0003Q9-DW; Mon, 06 Dec 2021 16:52:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239403.414929; Mon, 06 Dec 2021 16:52:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHEZ-0003Q2-AO; Mon, 06 Dec 2021 16:52:59 +0000
Received: by outflank-mailman (input) for mailman id 239403;
 Mon, 06 Dec 2021 16:52:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muHEY-0003Pw-8u
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 16:52:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6212bc5-56b4-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 17:52:56 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-QW98Xi5jOtavbvncoJZNoA-1; Mon, 06 Dec 2021 17:52:55 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Mon, 6 Dec
 2021 16:52:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 16:52:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:20b:312::9) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Mon, 6 Dec 2021 16:52:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6212bc5-56b4-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638809576;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=joui1Zy17jMpXVG4p+Fro0dNZj0AQu1QlOhnmwZMn+w=;
	b=X7Qn2GvC13wiIOxDlihaa9sIVNBypjkEqKRNm/eiwJMoX5PkPTHBsynH3JClW+GpotAmac
	ReM7z7Hf+ceGXIyc7TWKukHZnMnNTCyRresvNPRPDLPomNRUnKCPwFnZOou2WUkyZjO9+n
	7EZJd2/LLvRWzJJfO9jnUy0VD5+znS8=
X-MC-Unique: QW98Xi5jOtavbvncoJZNoA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IiRdMbOrcpkZvYmd7c30+SVxtYzWluAXVoqCjSj2PRrCR8MNVdlJYJnHL2nNoMkghVlpuE1cnhndOaJJux2AqGDBn9xGojWFqRv6wC9e0qtOKEKOOIq05wT9Zf3LM4Mr66TJwvOHUCMOh073MjXJBYi0oMhDozYSM/CIt57MckzZy7BKFU6/oe2HZ/85OH91YpQ8BYMe3I6OYX2MAuWzTaoU4Ljj25vJmbB2Fuj100VBrxC3ccQoSDJmrtVkY1AfNGUXzBSbZxxxgJ12XLVj8iVV+aoA+MZQ6rO+AHJe8vw3VCWuERbsW8aY1ZKLei0Y4mrAC6VQuHGOU4sSMi0RwQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=joui1Zy17jMpXVG4p+Fro0dNZj0AQu1QlOhnmwZMn+w=;
 b=NW9CfsbLCGgu18t+rGz1j3IW5KDJizW2KJOOItqNjVd6EuQ2a8kruNh7s1Q7kiIDp+8tqFKA9h9tfMAMu7m9UNoTYY1cFIRwT3ki0W7FmUelr14yHodFzA+IjXt9J4P7Wpk/O+fyWITvHSigKR+dp7kA7NCEyOImG9pRNeIt0LU5DF3syWGRwv5n20drm35sC8bQLGiDsbj88M3vWmrR1huCO3rOFF1YjIbyYwvZO4Xpo6hyhB4l1YuSZ38WswKvivShUNeESBBqVSTKv/4Uc2Jsk7XFYSkfHSwaM7QtiZbg/2W7rWqYXK53DVb8IQoNYYeL/Pm3XYcyHfZw4Gg2ng==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b4bde105-094d-067a-4657-a7ff041aee4a@suse.com>
Date: Mon, 6 Dec 2021 17:52:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 07/47] build: set ALL_OBJS to main Makefile; move
 prelink.o to main Makefile
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-8-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-8-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0034.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b540426-0b2e-45bf-85af-08d9b8d8d86a
X-MS-TrafficTypeDiagnostic: VI1PR04MB2960:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB2960928C8B58E2B4D65995A3B36D9@VI1PR04MB2960.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gYwcysj63j+wXdyCrscouADtZcYLMy/8G5iuHqKenY1wWdXjN0McxXRJ02K/5hMVaioRRg3WsSUWKGgsXcq5fsA7Qs9/W12Mc67+Sgk5lR34wEZKkE64zMpkTVcrSkhdsqtjddyBV1Gv0y2WUSK8k74NS46wYpI/dooGAOCOn+di+SS1TviGMD9yZIrg6R1KoE07DMddjIjQZPLHb7XlEn+LkXEXC+5Q6hAP67PNldjm8fWljzrSGXgnOeKi+0AIJ7rIrdUBOpa+r/YN1ZfyUdQHwYx9N0776f/Kbjm0XesJF9JivusX0qRhCddnV7vZU9Be0En/l1AZIne2CGyIMqyBGExE6JbOBx8CkS+axubnk23VNctXxy9cctC5IrKxr7v5MN+hz2ouuTWJxB9ziIv3NnTFDcEQO3I9MBVz6KbKul1NrKbUUhqIN+zjg0iDNI8cSY56N1z81q+H8TebN94M2PCGO7ayGYcAmw11XQraiH/LXjeTW7mMYg/7+uNrsj07WJYK0BIWMA3IbPcilnnsu9aliqIY9RgKP1vRmn5cdAnhcUEocGiJISOgxDNW5PHN9CzY4k8uTpvdu1yOPCTQL9RldkglZG1OYg1E5g4jpeB1CFwjT2MAhrwfwuoTMHPzNxDrimbI3johjkogWXlqjidHxBYvFK3iOq/UU47QsLG+6n28rm8kEvHECoCoH4NuxWY8Q2g08ZrqEYm6dLT5x0jyX192eZjrfJspsqeUXfUgirk7fHQTJrK9XIN0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(2616005)(54906003)(66476007)(36756003)(66946007)(53546011)(31696002)(4326008)(83380400001)(7416002)(66556008)(8676002)(508600001)(16576012)(26005)(316002)(5660300002)(8936002)(956004)(6486002)(31686004)(2906002)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NG5pSFlnV1phTHcyU282aU01bmJrQVYzdW9vbGEwTlhTSFIyUnYvY1NmZUJw?=
 =?utf-8?B?UlJyeml1YXdyWlVvZzU1anNkRkJTeFQ4T1VmNFl5amlHbjU2QVV6L1VhSkVY?=
 =?utf-8?B?dFA0U0FCU0xOWCsrNU04RU5QNzVmZ2RBOXJmWTFKRFp2OWNLekREeWlDTElS?=
 =?utf-8?B?c0F2TjRkWXRaMmpHcmVybjNsdGhUeFBHUHd0V1VZT1ZjRGI2WVBmNlo1YitQ?=
 =?utf-8?B?OTJZS2w0UHREaFRaUHI4MFlleGpKdzVDbVRycHBmbXNFUnA0dE03dC84SWdz?=
 =?utf-8?B?Zlhpb3FMWDlwSkhWV0NydlhDMnRNSW9wZU55YjArUUFpSjZDYWNlem9kK0Ju?=
 =?utf-8?B?TXk1USt4QzdVUlFZU3B0SWUzdnYybXhsSWhkU1BFWGkzSnR6SzkvRjllVVR5?=
 =?utf-8?B?aFRoQmg5ZDdwN1lWYWJTdDF6OGdWSXFkMWtFaGFVZHlnT2hRZll3OUN4Q1F6?=
 =?utf-8?B?ZXlaOVBhTFNITVh5MTJhbWhXT1pzMTFPTE5tbWRMd2VJdkpLVGJnaGhRdE9X?=
 =?utf-8?B?bVRjRG8xNGsvTW5scVhVSVlXTlJpcGt5K1hHbVR4VnB3aHNpemRwa29GKy9x?=
 =?utf-8?B?Wk4xdmVEOEQ3QzFhWnJXNVAzaEVxdysrOHIvTkJNQTBrMWhwZ3BDUXRwdWI4?=
 =?utf-8?B?bkttZGlDekxPYjdFTTdDME9INXBIV29LbWNiM25zMnBoc2JlZDlMWEtGSGZp?=
 =?utf-8?B?SDFuaUR3YWZZRWZkWjIxRkl1aVJyREZSYVliZDhVYXRxOGlUMTgwK3VrS3dM?=
 =?utf-8?B?RDNMTlp2dHo3eWhPczBHQlZVSDRtd2tsRDhReHY0MWJnY0RYeGZmMy94bisr?=
 =?utf-8?B?U2Z2Z3pCQ3h6Qll6QkJOTnRjMW5kd0Y0bzJmNlNFM2V0K2hSSnl4WGU4d2Zv?=
 =?utf-8?B?RkFJenpuRUl0VlJ0ZUNac3BjTTNaMVR4d1BOVUJsUEtzOGFadU4zVlVSMTZF?=
 =?utf-8?B?M1g4ZlVUdFpFYUd3VmFnYmo5ZTEvZFBGVDdqS0J0ciswZXJKU0gvc2JPalRV?=
 =?utf-8?B?djVrQUo4WUQvTTZmTGlQOEswWURyY0FCUEtkdEF4cmxNTEdDMUovYTRPbktI?=
 =?utf-8?B?OFRoclF1KzdtMU9xWm51TTFGN0V6VEM3VDVJSDVBSWt1czBRVWdqMnVhSUxF?=
 =?utf-8?B?Zzh1amlvWFh1TWFFeE5hT2ttWUlEdTN6T0luRWNGOE9LV0twR0tpRkMwcmdh?=
 =?utf-8?B?QlVGQ05mWWY4T0s2eVJmUDE2NTNnTUZxNEM2Q2FIMG83Vkh4VUJoWDEzeVd2?=
 =?utf-8?B?bjJIclJmbnQ1MWZKWENwbFY4RThwOENKdU1qN0R2cVNmRFdBNDlYVWxsVnR3?=
 =?utf-8?B?d1Y2YjB1dVRVaDZKWm9HZWRJOE9nWVJmVTlsaStxSm5OT0Vab1puTlF6a1BC?=
 =?utf-8?B?N0RlTHBhU1pnMVArTVpHSTJxTllZVDNnTk55cE4yL2dYWVBXOGYxUnVnQlR5?=
 =?utf-8?B?TklvVXNjQnlTaUJnTFBMcjdIalJwd0M0WjdEUy9LUnA4V3JyL29IZWMySDZM?=
 =?utf-8?B?Z2tDY2tCcThBandMUFlUQ01zc1RTS3J5VWVuelFHMHdsU0lLU0g3WDNUdlA5?=
 =?utf-8?B?a2VaVnp2TUs3ZTYzQm1nTlhQSERVaHl4ZzMyYldxeHJreG9BZWd3Y1hMbkQ2?=
 =?utf-8?B?T0Nyb3docWZiL3RZMVNaVllGbjZDbnJMR2Vzd29wZVRWTkN6OGNqQVpDY29L?=
 =?utf-8?B?bkk2ZllOdVVaSFB5OW1ZbDRlOXFwUk5qRU81TjBEUlZ3WmdXdmg1TGtQclp2?=
 =?utf-8?B?SnJFSUtqN3c2L3dsNDNWN2FJTFN6RFpybTJqUWh0TS9GOXdMMlNjUnUxdVBr?=
 =?utf-8?B?UlJRSHYycTI0ejZhK0tHbStSNWJvNTk1TXZYRHFBQTN2SllrQWRIQnRzeUEw?=
 =?utf-8?B?MjRNQWFNeW9kK1A1WEpONlg4Sk1HSHd4YnFxS1lOQ3hxNFluSWZRa2VWZFEw?=
 =?utf-8?B?TTA0cW5uL2w5N3ZjTXllZ1dIQ0xuMlJYUzc0S2pNb2hJQjA0K1RHWDJtMW5Q?=
 =?utf-8?B?UU5mamlqVG1BTGlnemE0VDRva3JKTUdpREwzMjJSdHkyUUlzUUZQd3Jsanox?=
 =?utf-8?B?M0x2djZzS1pXeldOUXM3YUVnTmtSbTVLQVlSa3Qza0JnSVlFYXVHODgrQzc0?=
 =?utf-8?B?d1hqQkNPbzVROTViWk5aMlZJb3pONkVQZXdoL3NGNk1KY3I4TUZmQjBpTXls?=
 =?utf-8?Q?N9mfOTw6yp95UYfLT0ZWSAs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b540426-0b2e-45bf-85af-08d9b8d8d86a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 16:52:53.4291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sFuuvG8UOKgjbi/QuXFwL9dyn3OTN1hVJdF5YkTiZxWbK2GwjrCGmwSKD4YyR1bJzVyjWOENkGfpB9ULdhm1Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960

On 25.11.2021 14:39, Anthony PERARD wrote:

Nit: In the title, do you mean "set ALL_OBJS in main Makefile; ..."?

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -285,8 +285,21 @@ CFLAGS += -flto
>  LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>  endif
>  
> +# Note that link order matters!
> +ALL_OBJS-y                := common/built_in.o
> +ALL_OBJS-y                += drivers/built_in.o
> +ALL_OBJS-y                += lib/built_in.o
> +ALL_OBJS-y                += xsm/built_in.o
> +ALL_OBJS-y                += arch/$(TARGET_ARCH)/built_in.o
> +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o
> +
> +ALL_LIBS-y                := lib/lib.a
> +
>  include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk
>  
> +export ALL_OBJS := $(ALL_OBJS-y)
> +export ALL_LIBS := $(ALL_LIBS-y)

Who's the consumer of these exports? I ask because I don't consider the
names very suitable for exporting, and hence I'd prefer to see their
scope limited. If e.g. it's only a single make invocation where they
need propagating, doing so on the command line might be better.

> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -0,0 +1,5 @@
> +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
> +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
> +# build head.o
> +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o
> +arch/arm/$(TARGET_SUBARCH)/head.o: ;

Can't this be a single line:

arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o ;

?

> @@ -235,7 +218,7 @@ $(TARGET).efi: FORCE
>  	echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled'
>  endif
>  
> -efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o
> +# These should already have been rebuilt when building the prerequisite of "prelink.o"
>  efi/buildid.o efi/relocs-dummy.o: ;

If the comment is true in all cases, do they really still need an empty
rule?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:00:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:00:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239411.414940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHLU-0005Cl-8m; Mon, 06 Dec 2021 17:00:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239411.414940; Mon, 06 Dec 2021 17:00:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHLU-0005Ce-5K; Mon, 06 Dec 2021 17:00:08 +0000
Received: by outflank-mailman (input) for mailman id 239411;
 Mon, 06 Dec 2021 17:00:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muHLT-0005CY-8S
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:00:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6309c0d-56b5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:00:06 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-7HpNBHdIPs-NjBLYRWiIww-1; Mon, 06 Dec 2021 18:00:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 6 Dec
 2021 17:00:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 17:00:03 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0106.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::47) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.20 via Frontend Transport; Mon, 6 Dec 2021 17:00:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6309c0d-56b5-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638810006;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ro03WXeRgue+HJrGelJsql20dtKmvllsT2bxUS+wI1M=;
	b=cTJL7IdATZRbLsd1xZ5biCsrCsaTPlkkf/DHEb6iox/W5Iz08fzn4HOFrrDSqfPTxjg2oB
	BLMouY+3Hbv2TTrCFi+Ri6bjivdF8wI75lsrVsyZeZgMV1flQYJ0rKKRAYUBuRqx0z14Qb
	NM7+BNXko+NldbZTzQzFqLeyoiwKvF0=
X-MC-Unique: 7HpNBHdIPs-NjBLYRWiIww-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OeJJ+BWQRZE+sjP94ElvuX1fcURn9lFUigDgurBHURTZrOGW2z+6VTDkhZT9m/9HnHSAHWhcqBCCem9KYreDDe/wDbBbjfCXhPWqmi6W1oe8rMpLcQDYl0c0sMofxGlcNVudG1dct0VCiTP3PwUE+g5eQ9x4VdF3brNYEM+u2t08sYu7akkMGk74KBiapNBcQAXlCXY+2ORThHHwiJcxvTm/bufyoYpL3Wg84FsBbAvKGEXztKT1mXV+YL30FotdcEeFiO/5ddIz7d+pWhrvyZlD/S6DXTHZ7uIV4SVZbke97CL59NFO3OtSDpTTe/+A7pXLHFBrtUo56iust447SQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ro03WXeRgue+HJrGelJsql20dtKmvllsT2bxUS+wI1M=;
 b=Isge1wsacaziFZFqG7Pd4787XJps58ec+V334Sbejd/IWv4TVzpvKuOu829jQMxlXiSlheGzsfR41tTAdLuUT+Wwz9qAvdASVf3R0udNYjS/RrK/g9OOzuvcLidzfNKwYSkrFtt/RgbXPuaBYiy2IQidqB9Qyo/MjdullflSHGVhJ7tdFJdAn4ktoLP76vITi6HsY2cpMRTAemA4JND814Xi6N8Xa8vfECnC6obkTULcQirjHY86UXDFw944XjLwBd48bG+kDgYKiLx5yxn2trimEasRTFkOiDW29qSL9133jWzg6Ewx/5u6aTsyGuvESTuYXZjucYDNKaQZczxdTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fc884bbf-a16f-2fad-9a3d-b1b95fb0a7b6@suse.com>
Date: Mon, 6 Dec 2021 18:00:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 09/47] build: rework test/livepatch/Makefile
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-10-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-10-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0106.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 67eb10b6-0f35-423f-f6b6-08d9b8d9d8de
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3776D0E9665AE357D5FC3177B36D9@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+T/0FTeosV8oPHsb3z9ITEcHUnPBedX7lKdmYWcGwdbVMMTokMljFtuN6h+FChNSd/bFnnktW8JUxYc958hsV2tgzaq0RFu1yxjjFArbMLcPRaLbDAisk0/LN1dOGQ3j6hlehX5ECmSpL6mtIMxa9dO3uJ6TFuQbGWju+nhvq6j7YNBf1SbRqFAWZaElVYBPVHXH22dnUfV3WlWSr8j5PkyeyWnOdrEOIbJl0iyX2aQjyUvHK2cA4v0wHoj0GEzTNHkwXhLTahNIU5hW6DiCQ8XjfHAqDI7WZokxSIJ48RdkKByiFqbR+mxbCRi/c8ZmP8qCcZcN9jVFsbX89UlSbP127nxLgQoyvKWdxnUZs8Vig1a0tNiYZ9m6OAE8fmU97umxJVc4/vmHDpm1zp6QHT2ydR+BehOIMFwsWFDpLEdDnjQriWMDA0/zGHQ8ACPsSvUArmnz76OFC8hCdJObuvlIGAPdR/JyBL3Wnk/GFegZPVPxbdQVVavnEdtPzLfrSo7f2+B2gFhyj5hLy3U9p6jw8VKB+3Qj8Oq8cHPxVlfhaAd3eXMwyHdALDb1iQMzY4JFDqycdrkMN2i8sR0d/TxzhXw0Y9MrVrO/OKhnE0sIyngB4zzP7ywV96+6iXXBJIh4SYEYE49Pp9D99au7bkEcZQHgJrQjJrXdbpTnJnW6aDPj9o2Fjx3s064PKaDzOLfnsbp0eMC3lof0881NlbUJ8LhPKpGnD7NE5w+INE+3DnE4j21MzHu6ZPmx3WRt
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(16576012)(508600001)(316002)(31686004)(186003)(8676002)(66556008)(66476007)(6486002)(36756003)(8936002)(83380400001)(66946007)(31696002)(6916009)(956004)(2616005)(54906003)(86362001)(2906002)(53546011)(38100700002)(7416002)(4326008)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S1V4ZzdlYVFIVVhlTFc0aWVad3pYNEpjeTdkbjBYY3Nna3RxMDVJM2d5by82?=
 =?utf-8?B?RWxOTXI3QnN6dzJuQXJ1YVdDWld5TVgzMTkvWG1qakZ4aDVRelRhS1hrektX?=
 =?utf-8?B?TGpTTCtldXhady8vbmVRNGNwTUp2ZGZHUkt3US9qaHRMSFozYnpkUlpQUDJz?=
 =?utf-8?B?REpQK1ZXdXloejhMTDZ0YkE5U2h0NEVBaXNCcXoyR0owRnpQdlNUbzgvQ0dx?=
 =?utf-8?B?UVFhRXVrajYrRGZPR1VycjJMeXBWd3FyMWN4dFV2RGgrZ2lrMVpBY2c2K05h?=
 =?utf-8?B?MTBSdlhkNUtSKzJQMWluQ2l6eU1WWUk1aUpCZm8zWURhc0ZLZEhSRW9lcXJo?=
 =?utf-8?B?T1R6alBwOVJMV3doN2tJSS9CbFQyKytzTU5uRm1McUpyVWRoVTRMeURhTHBO?=
 =?utf-8?B?Um0rR2JaeDUwdmZKbFJEOEJENzlVU2RVNDFNMlk5cGx4ZVpaWnBEZGxCb0FT?=
 =?utf-8?B?aTluQW5GSnpsT2VDNzZLTVk2dXZUd3lFQlhhTUZhN0VhTzdEK3dnRWJXSitu?=
 =?utf-8?B?Vzd0My85cDlzN1BjZHFvUnhVSndTcWZnREV5Wk1QZHpaaXFGQWpCSzN5VnlB?=
 =?utf-8?B?b2ZxeEFCb2F1K2gvMlB3Zis2aU16NmxZQy9obUdhNU9FV1ltTDdvTm9WZnRE?=
 =?utf-8?B?NDl3b1djcUhYOW1sK0RDY0pmOG8yeTFuWXRUbHMvR21OdnNnRGx1cTZkVmNQ?=
 =?utf-8?B?eTFGeE9QMCtnVGpGOFBtT2VJSm5tVkFyeHFxQU9nOVcwMVJ2YzF1dGczVUFl?=
 =?utf-8?B?VEFWOWI3MkV5clVOVVM5Qi9FbndKbXQyektaTTErMXdTUXJYamY1NDVWc0k0?=
 =?utf-8?B?YkVBbmxlS25zd2d4SWRsYkl0OHJ4NGQ2SFBNQk01YnR2RDVJdkp3dzlCSEcw?=
 =?utf-8?B?N0d1V0d4TGZHSmVudXpDQi9uemNwck5xQXNFZFpnZW9iWi9lM29lNzhIbEM2?=
 =?utf-8?B?ZXk1b2R3Rjg5NHoxY1lOU2V4U0hHZHEwZzRoYnM2dnRpM0lmVURFMTdPVmxu?=
 =?utf-8?B?aHhuYVAzVnJoZWkrVHZ6NUgvZ2pFTlhBMko5bmdsKzNoMk40L2szUWYzN21M?=
 =?utf-8?B?Y295YUFJOTZ6UlZ0emZpY0pNQlFTc2lLcDR6T0FOMGcwMno1Z3VBWXEvWC81?=
 =?utf-8?B?Nk85SG9IY2dHUGtEOEY1OEVuUlplancrVkV6THRTUTM5eVNWYVEwVWI2bHhR?=
 =?utf-8?B?V3poRG13ajZjekMxUi95Q1g2aUVITWR6VEUycU92dVZyUnd4cFpZVEVwMm5I?=
 =?utf-8?B?aDJlV1owZjJTbEJyT2JJMkNyWWluS1B4ZWlrdWh6R3RvcWFWd25wSmcyQXdM?=
 =?utf-8?B?SFIwQmxsZ0VwZUxMVHVBUzhhNnE5Yzdwckd2Q2l0V2w2MWgvRzFFbmEyT0g2?=
 =?utf-8?B?WmVPTnpQalJGOVNiMEZGbG45UWdXYXdnTzRlNzZKNU5FYW0vM1I0TzJBTW4r?=
 =?utf-8?B?Sk9PbkdNcnVTdE5sc3UrMng1K1BNSTFvYjBvNHVpSzZKdmxFZjlISWlFbXFL?=
 =?utf-8?B?djIrNzRSMCtCNzZKR0QvcmVpKy9TWFZHQWVpQkFpeHEzMFJFVDFGTk14UDhV?=
 =?utf-8?B?SDVPeThPbmdqeTFicjFwY3dvVE5JWjdBWDkwUHI0OTRtSXFvdW5tbVp2dTNn?=
 =?utf-8?B?OVdtak1qSTh2UXpRd3JTQ0docTRuUGVwQ1pBdzNtdHh2NDRIV1B3clhtSzdB?=
 =?utf-8?B?ZHRKV1hsazhTOWN3VDBMb3dhbmJaQnV1NFpWQ2JxVWoyVUhoQyttWld0UHpV?=
 =?utf-8?B?Q04wZ2o2UTVKMDI4eUZmaGpQalJqYXZTTitJUm9LcjE4SHRZUU1sQnR2SEVa?=
 =?utf-8?B?dkZETUJPd2dNLzAxUkNpd3VqZko0dFZHOGNXbkZYNXUwQWlsUnBBZGhxUFdC?=
 =?utf-8?B?S3pmdU5QS0NGOUxlM2NxQmRadm9sd3Q1ZjVZckg2U1N4VWN5WHQxWmVSckpu?=
 =?utf-8?B?T3ZOYWduTWw1aWJXNlJrVGlqOXk2KzgydFc0SFJhblRLMzhnZ0ZuODl0WkNN?=
 =?utf-8?B?SVRDMDlSZjEwYW9mSjlwOTVYOU5ma0xoQ1ZTdnR2SlJIaitYWFdZVG8yS2Vq?=
 =?utf-8?B?MExUM0xjRldOekRXTjgvdWs3Qyt4anJVblNNVko3YU1DN3dNL29xTEtUTTk0?=
 =?utf-8?B?VS9kZXBTb2NEWHZ2dnZueWNrNDBld09lVU5vSm9BMS90VDBmdk1tMDZFZVB3?=
 =?utf-8?Q?n0IwiAwc5vBrLC0lFXyI5YU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67eb10b6-0f35-423f-f6b6-08d9b8d9d8de
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 17:00:03.7159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QVYRwIHim1wBjlCfbnrY9aPdxLrfHrSLEBpNu3Ca2Dkic5mXWiCjdtX5s0XqHx3/sME/8HgXccl4EOg/MOiCYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 25.11.2021 14:39, Anthony PERARD wrote:
> This rework the livepatch/Makefile to make it less repetitive and make
> use of the facilities. All the targets to be built are now listed in
> $(extra-y) which will allow Rules.mk to build them without the need of
> a local target in a future patch.
> 
> There are some changes/fixes in this patch:
> - when "xen-syms" is used for a target, it is added to the dependency
>   list of the target, which allow to rebuild the target when xen-syms
>   changes. But if "xen-syms" is missing, make simply fails.
> - modinfo.o wasn't removing it's $@.bin file like the other targets,
>   this is now done.
> - The command to build *.livepatch targets as been fixed to use
>   $(XEN_LDFLAGS) rather than just $(LDFLAGS) which is a fallout from
>   2740d96efdd3 ("xen/build: have the root Makefile generates the
>   CFLAGS")
> 
> make will findout the dependencies of the *.livepatch files and thus
> what to built by "looking" at the objects listed in the *-objs
> variables. The actual dependencies is generated by the new
> "multi-depend" macro.
> 
> "$(targets)" needs to be updated with the objects listed in the
> different *-objs variables to allow make to load the .*.cmd dependency
> files.
> 
> This patch copies the macro "multi_depend" from Linux 5.12, and rename
> it to "multi-depend".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> 
> Notes:
>     v8:
>     - rename multi_depend to multi-depend
>     - use $() for single-letter make variable
>     - re-indent one line
> 
>  xen/scripts/Kbuild.include  |   9 ++
>  xen/test/livepatch/Makefile | 213 ++++++++++++++----------------------
>  2 files changed, 91 insertions(+), 131 deletions(-)

The tiny non-livepatch part
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:02:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:02:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239416.414951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOE-0005tz-M0; Mon, 06 Dec 2021 17:02:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239416.414951; Mon, 06 Dec 2021 17:02:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOE-0005ts-Ih; Mon, 06 Dec 2021 17:02:58 +0000
Received: by outflank-mailman (input) for mailman id 239416;
 Mon, 06 Dec 2021 17:02:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOD-0005ta-1F
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:02:57 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59a3eda5-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:02:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59a3eda5-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810175;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=/MLBUm6LRp5jlDNoHboN38G/J77fSfY6CJn4+sPxHV8=;
  b=femy/F2Wg7nBcNN7sBvqo7XwuWZNj7OTYSldI4yY6JcB1NOmtCgaZj2H
   gWtQD5h+4dnwhpuDsmMNsKU9XmS6zFKSrcI7u6vn9lpyvDcLjJsekPMlO
   AZlXtYmDZ/lEbOvpTb4wvyU0t+3Y4oZ+cm9Db3c18xuDXlRdQzQ4Mq/nP
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: CJ5nYeJZiZtaaIXMhDDYXS7M5ttIaBarD0oHlaFkXHVilSxn8A8Kymy8SWQAimN8m+HgynPcOX
 QTyrMfVKbrCz0Un4Q7Zoh+c8ddW9FCMR/3DdZjmXVVPckvNjLZ6Zr2XAXsIXAUh8GlS+wPSU7s
 UZ8d+9607pRlFT6l9tVbzaKIH2vXW0xodJd25z1i8CFNhHzGbDW//47VPxmU9gxYx9Mbg4ZuRm
 GbR7tRPzZ2pTnNAg86mDtP8wyJXRy1biPqbXCckhMNbwyAj3K3yW+WjRS2Av5u3WIVL94tAWce
 Y6kPrKlPhpnLFdClb0ilE3Bv
X-SBRS: 5.1
X-MesageID: 59323913
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Lc8Un6KlMCpPxtJKFE+R+5MlxSXFcZb7ZxGr2PjKsXjdYENShjAPn
 DEdWjiDOK2DYDb8f48ibdzlpk8PupGDytFqGgNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Onutv8
 ch2saaIcgICE5TqgsYkcURxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph3ZoVTK+FD
 yYfQThQTA3EYT4QA1YGEMMjxduGr0H6dQQN/Tp5ooJoujOOnWSdyoPFPd7YfNXMWMtUm1qDq
 3zP12PjCxoeOZqUzj/t2n6jiuLAhyrTRJMZFLr+8OVjxlKU2AQ7ExQTSFa/5+W5i0S3RtZDA
 0ES4W8qvK80skuxQbHVQBmQsHOC+BkGVLJ4EfA+6QyL4rrZ5UCeHGdsZjxOcts9r+ctWCcnk
 FSOmrvBHidzubeYTXac8La8rj6oPyURa2gYakcsQQIb7vH5rYo0jxaJScxseIa8iMH1Hjfhh
 SiHtiEki50ciMcK0+Ow+lWvqyKhoN3FQxA44i3TX3m59UVpaYi9fYuq5FPHq/FaI+6xQkGau
 XkYm+CX9O0UEYyWjyuJXfkMG7eyof2CNVX0g1RiAp0g/DSF4GO4cMZb5zQWDEZ2MO4UdDnxe
 kjRtAhNophJMxOXgbRfOtzrTZ5wlO65SIqjBqu8gsdyjoZZMw684hhzXkqq51vou2UVt7sdA
 LXGWJP5ZZoFMphPwD2zTuYb9LYkwCEi2G/eLazGIwSbPam2PyDMF+pcWLeaRqVgtf7f/l2Jm
 zpKH5LSk003bQHoXsXAHWf/x3guJGNzO535otc/mgWrcls/QzFJ5xM8LNocl21Zc0Z9y76gE
 pKVABYwJL/DaZvvc1/ihpdLMuyHYHqHhShnVRHAxH7xs5TZXa6h7b0Ea7w8dqQ9+epowJZcF
 qdeK5raU6kVEGqYq1zxiKURSqQ4LnxHYirUYEKYjMUXJcY8F2QlBPe6FucQyMX+JnXu7pZvy
 1FR/gjaXYACV2xf4DX+M5qSI6eKlSFFwopaBhKQSvEKIRmE2NU6ekTZ065sS+lReEqr+9dv/
 1vPafvujbKW+NFdHRigrf3skrpF5MMiRBcHRDeCsu7tXcQYl0L6qbJ9vC+zVWi1fAvJFG+KP
 425Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra
 HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr
 r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/
 eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
IronPort-HdrOrdr: A9a23:bqdbPKrOoytuDfXa1HNlwfcaV5oheYIsimQD101hICG8cqSj+P
 xG+85rsCMc6QxhP03I9urgBEDtex7hHP1OkOss1NWZPDUO0VHAROoJ0WKL+UyFJ8SUzIBgPM
 lbH5SWcOeAbmRHsQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59323913"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, David Scott <dave@recoil.org>, Ian Jackson
	<iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Christian Lindig
	<christian.lindig@citrix.com>, "Daniel P. Smith"
	<dpsmith@apertussolutions.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, Andrew Cooper <andrew.cooper3@citrix.com>, "Elena
 Ufimtseva" <elena.ufimtseva@oracle.com>, Juergen Gross <jgross@suse.com>,
	George Dunlap <george.dunlap@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Julien Grall
	<julien@xen.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 00/57] Toolstack build system improvement, toward non-recursive makefiles
Date: Mon, 6 Dec 2021 17:01:43 +0000
Message-ID: <20211206170241.13165-1-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v1

Hi everyone,

I've been looking at reworking the build system we have for the "tools/", and
transforming it to something that suit it better. There are a lot of
dependencies between different sub-directories so it would be nice if GNU make
could actually handle them. This is possible with "non-recursive makefiles".

With non-recursive makefiles, make will have to load/include all the makefiles
and thus will have complete overview of all the dependencies. This will allow
make to build the necessary targets in other directory, and we won't need to
build sub-directories one by one.

To help with this transformation, I've chosen to go with a recent project
called "subdirmk". It help to deal with the fact that all makefiles will share
the same namespace, it is hooked into autoconf, we can easily run `make` from
any subdirectory. Together "autoconf" and "subdirmk" will also help to get
closer to be able to do out-of-tree build of the tools, but I'm mainly looking
to have non-recursive makefile.

Link to the project:
    https://www.chiark.greenend.org.uk/ucgi/~ian/git/subdirmk.git/

But before getting to the main course, I've got quite a few cleanup and some
changes to the makefiles. I start the patch series with patches that remove old
left over stuff, then start reworking makefiles. They are some common changes like
removing the "build" targets in many places as "all" would be the more common
way to spell it and "all" is the default target anyway. They are other changes
related to the conversion to "subdirmk", I start to use the variable $(TARGETS)
in several makefiles, this variable will have a special meaning in subdirmk
which will build those target by default.

stubdom has some changes also as it won't be able to use tools/ Makefiles
as-is anymore.

As for the conversion to non-recursive makefile, with subdirmk, I have this WIP
branch, it contains some changes that I'm trying out, some notes, and the
conversion, one Makefile per commit. Cleanup are still needed, some makefile
not converted yet, but it's otherwise mostly done.

    https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.toolstack-build-system-v1-wip-extra

With that branch, you could tried something like:
    ./configure; cd tools/xl; make
and `xl` should be built as well as all the xen library needed.
Also, things like `make clean` or rebuild should be faster in the all tools/
directory.

Cheers,

Anthony PERARD (57):
  .gitignore: Non existing toolcore/include files.
  tools/configure.ac: Remove left over system_aio
  tools/Rules.mk: Remove $(CFLAGS.opic) from %.opic: %.S
  libs: Remove _paths.h from libs ctrl and util.
  libs: Remove -Iinclude from CFLAGS
  libs/libs.mk: Remove generic variable that already exist
  libs/guest: Drop spurious include in Makefile
  libs/light: Remove non-existing CFLAGS_libxl.o var
  libs/light: Remove -I.
  libs/stat: Remove duplicated CFLAGS from deps
  libs/store: Remove PKG_CONFIG_REMOVE
  tools: remove some unneeded subdir-distclean-* targets
  tools/firmware/hvmloader: remove "subdirs-*" prerequisite
  tools/flask/utils: remove unused variables/targets from Makefile
  tools/libacpi: cleanup Makefile, don't check for iasl binary
  tools/ocaml: Remove generation of _paths.h
  tools/xl: Remove unnecessary -I. from CFLAGS
  tools: Use config.h from autoconf instead of "buildmakevars2header"
  tools/configure.ac: Create ZLIB_LIBS and ZLIB_CFLAGS
  tools/Rules.mk: introduce FORCE target
  tools/include/xen-foreign: avoid to rely on default .SUFFIXES
  tools/console: have one Makefile per program/directory
  tools/debugger: Allow make to recurse into debugger/
  tools/debugger/gdbsx: Fix and cleanup makefiles
  tools/examples: cleanup Makefile
  tools/firmware/hvmloader: rework Makefile
  tools/fuzz/libelf: rework makefile
  tools/fuzz/x86_instruction_emulator: rework makefile
  tools/helper: Cleanup Makefile
  tools/hotplug: cleanup Makefiles
  tools/libfsimage: Cleanup makefiles
  tools/misc: rework Makefile
  tools/vchan: Collect targets in TARGETS
  tools/xcutils: rework Makefile
  tools/xenpaging: Rework makefile
  tools/xenstore: Cleanup makefile
  tools/xentop: rework makefile
  tools/xenstrace: rework Makefile
  libs: Remove both "libs" and "build" target
  libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS
  libs: Remove need for *installlocal targets
  libs,tools/include: Clean "clean" targets
  libs: Rename $(SRCS-y) to $(OBJS-y)
  libs/guest: rename ELF_OBJS to LIBELF_OBJS
  libs/guest: rework CFLAGS
  libs/store: use of -iquote instead of -I
  libs/stat: Fix and rework python-bindings build
  libs/stat: Fix and rework perl-binding build
  libs/toolcore: don't install xentoolcore_internal.h anymore
  tools/Rules.mk: Cleanup %.pc rules
  .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc}
  stubdom: only build libxen*.a from tools/libs/
  stubdom: introduce xenlibs.mk
  tools/libs: create Makefile.common to be used by stubdom build system
  tools/xenstore: introduce Makefile.common to be used by stubdom
  stubdom: build xenstore*-stubdom using new Makefile.common
  stubdom: xenlibs linkfarm, ignore non-regular files

 tools/configure.ac                           |  20 +-
 Config.mk                                    |   9 -
 stubdom/xenlibs.mk                           |  13 ++
 tools/Rules.mk                               |   9 +-
 tools/libfsimage/Rules.mk                    |  26 +--
 tools/libfsimage/common.mk                   |  11 +
 tools/libs/libs.mk                           |  36 +--
 .gitignore                                   |  44 +---
 config/Tools.mk.in                           |   3 +-
 configure                                    |  45 ++++
 docs/configure                               |  45 ++++
 m4/paths.m4                                  |   9 +
 stubdom/Makefile                             |  26 ++-
 tools/Makefile                               |  32 +--
 tools/config.h.in                            |  27 +++
 tools/configure                              |  67 +++++-
 tools/console/Makefile                       |  57 +----
 tools/console/client/Makefile                |  39 ++++
 tools/console/client/main.c                  |   1 -
 tools/console/daemon/Makefile                |  50 +++++
 tools/console/daemon/main.c                  |   1 -
 tools/debugger/Makefile                      |   8 +
 tools/debugger/gdbsx/Makefile                |  20 +-
 tools/debugger/gdbsx/gx/Makefile             |  15 +-
 tools/debugger/gdbsx/xg/Makefile             |  25 +--
 tools/examples/Makefile                      |  21 +-
 tools/firmware/Makefile                      |   3 -
 tools/firmware/hvmloader/Makefile            |  18 +-
 tools/flask/utils/Makefile                   |  16 +-
 tools/fuzz/libelf/Makefile                   |  21 +-
 tools/fuzz/x86_instruction_emulator/Makefile |  32 ++-
 tools/helpers/Makefile                       |  31 +--
 tools/helpers/init-xenstore-domain.c         |   1 -
 tools/hotplug/FreeBSD/Makefile               |  11 +-
 tools/hotplug/Linux/Makefile                 |  16 +-
 tools/hotplug/Linux/systemd/Makefile         |  16 +-
 tools/hotplug/NetBSD/Makefile                |   9 +-
 tools/hotplug/common/Makefile                |  16 +-
 tools/include/Makefile                       |   1 +
 tools/include/xen-foreign/Makefile           |   9 +-
 tools/libacpi/Makefile                       |  17 +-
 tools/libacpi/README                         |   6 -
 tools/libfsimage/common/Makefile             |  11 +-
 tools/libfsimage/ext2fs-lib/Makefile         |   9 -
 tools/libfsimage/ext2fs/Makefile             |   9 -
 tools/libfsimage/fat/Makefile                |   9 -
 tools/libfsimage/iso9660/Makefile            |  11 -
 tools/libfsimage/reiserfs/Makefile           |   9 -
 tools/libfsimage/ufs/Makefile                |   9 -
 tools/libfsimage/xfs/Makefile                |   9 -
 tools/libfsimage/zfs/Makefile                |   9 -
 tools/libs/call/Makefile                     |   7 +-
 tools/libs/call/Makefile.common              |   6 +
 tools/libs/ctrl/Makefile                     |  55 +----
 tools/libs/ctrl/Makefile.common              |  44 ++++
 tools/libs/ctrl/xc_private.h                 |   2 -
 tools/libs/devicemodel/Makefile              |   7 +-
 tools/libs/devicemodel/Makefile.common       |   6 +
 tools/libs/evtchn/Makefile                   |   7 +-
 tools/libs/evtchn/Makefile.common            |   6 +
 tools/libs/foreignmemory/Makefile            |   7 +-
 tools/libs/foreignmemory/Makefile.common     |   6 +
 tools/libs/gnttab/Makefile                   |   9 +-
 tools/libs/gnttab/Makefile.common            |   8 +
 tools/libs/guest/Makefile                    | 109 +--------
 tools/libs/guest/Makefile.common             |  84 +++++++
 tools/libs/guest/xg_dom_core.c               |   1 -
 tools/libs/guest/xg_offline_page.c           |   2 +-
 tools/libs/hypfs/Makefile                    |   4 +-
 tools/libs/light/Makefile                    | 222 +++++++++----------
 tools/libs/light/libxl_dom.c                 |   2 -
 tools/libs/light/libxl_internal.h            |   1 -
 tools/libs/light/libxl_utils.c               |   1 -
 tools/libs/stat/Makefile                     |  70 +++---
 tools/libs/stat/bindings/swig/perl/.empty    |   1 -
 tools/libs/stat/bindings/swig/python/.empty  |   1 -
 tools/libs/stat/xenstat_qmp.c                |   1 -
 tools/libs/store/Makefile                    |  20 +-
 tools/libs/toolcore/Makefile                 |  10 +-
 tools/libs/toolcore/Makefile.common          |   9 +
 tools/libs/toollog/Makefile                  |   3 +-
 tools/libs/toollog/Makefile.common           |   2 +
 tools/libs/util/Makefile                     |  27 +--
 tools/libs/vchan/Makefile                    |   9 +-
 tools/misc/Makefile                          |  16 +-
 tools/ocaml/xenstored/Makefile               |   7 -
 tools/ocaml/xenstored/systemd_stubs.c        |   2 -
 tools/vchan/Makefile                         |   6 +-
 tools/xcutils/Makefile                       |  15 +-
 tools/xenpaging/Makefile                     |  24 +-
 tools/xenstore/Makefile                      |  83 +++----
 tools/xenstore/Makefile.common               |  34 +++
 tools/xentop/Makefile                        |  19 +-
 tools/xentrace/Makefile                      |  11 +-
 tools/xl/Makefile                            |   9 +-
 tools/xl/xl.h                                |   1 -
 96 files changed, 953 insertions(+), 990 deletions(-)
 create mode 100644 stubdom/xenlibs.mk
 create mode 100644 tools/libfsimage/common.mk
 create mode 100644 tools/console/client/Makefile
 create mode 100644 tools/console/daemon/Makefile
 create mode 100644 tools/debugger/Makefile
 create mode 100644 tools/libs/call/Makefile.common
 create mode 100644 tools/libs/ctrl/Makefile.common
 create mode 100644 tools/libs/devicemodel/Makefile.common
 create mode 100644 tools/libs/evtchn/Makefile.common
 create mode 100644 tools/libs/foreignmemory/Makefile.common
 create mode 100644 tools/libs/gnttab/Makefile.common
 create mode 100644 tools/libs/guest/Makefile.common
 delete mode 100644 tools/libs/stat/bindings/swig/perl/.empty
 delete mode 100644 tools/libs/stat/bindings/swig/python/.empty
 create mode 100644 tools/libs/toolcore/Makefile.common
 create mode 100644 tools/libs/toollog/Makefile.common
 create mode 100644 tools/xenstore/Makefile.common

-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:02:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:02:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239417.414956 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOF-0005vt-0G; Mon, 06 Dec 2021 17:02:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239417.414956; Mon, 06 Dec 2021 17:02:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOE-0005vh-Q2; Mon, 06 Dec 2021 17:02:58 +0000
Received: by outflank-mailman (input) for mailman id 239417;
 Mon, 06 Dec 2021 17:02:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOD-0005ti-PF
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:02:57 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5aafbb36-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:02:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aafbb36-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810175;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=TKhye1HdvBigP9+nr6Vr3o8+wKLgJNZaOQSBuxAwT3A=;
  b=D9pSmLqtU6tjHnaq4wiHRboT7YKSEUgXwBxwKlV6AJ0leXicu4zpK17s
   oUNOiAYaI8Pk0UJEEukdILCH/TcFNldERvuHVTlugF2/hYAvhrUvvVArL
   IS1fvldlg43w5FH+bSxmJZiTECMTBXdwZY0H4ZasEv5gOu2+19IW5PzvB
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IoCEYYuY/DFWYmh5ZyCzieeAJWqnNZtsTDbox4g5TBa6c6aASZlK9sGjCzw/778vYTuenwhs/1
 BabPmbzf8+v3CPGnaSHZqaYLPJQ7TlcfQS36CWLgBaJ1fPfEa+IZDHlAQVLzRXvN1ZZlYFfC6E
 AmvWDkK4vJ3edBmZczrFyOymvFF9G8QsAdaAgp4uwdcVhqfj1USGS5TT29Kyhx6SLliwjb1eeg
 WKq+y97A/5MtXWZcr7lfuspnw4SllwDM594lJpZz5iI/zdUkPVefQAc9NnBksUxlGmpf/UHveD
 KH1phze3r0WTLoP4of1TZDrE
X-SBRS: 5.1
X-MesageID: 58884262
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HBweeasv9KWcO5iyglgQT8dxpufnVM1ZMUV32f8akzHdYApBsoF/q
 tZmKT/XM/yMMWH9eoojO4m09RkA7JaHy9BkTAtu+CozHn8b+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllseRQgIYH7L1gN8SWT14CCFxD6Ia0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 5pJNWAxNnwsZTUXNn4HLZE6mdvyhybWS2EAhA/El7Qetj27IAtZj+G2bYu9lsaxbcdImkeVo
 ErW8mK/BQsVXPSE0iaM+H+ogu7JnAv4VZgUGbn+8eRl6HWMwkQDBRtQUkG0ydG7gEOjX9NUK
 2QP5zEj66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZIbsAms8knAyQnz
 FaTk/vmADVutPueTnf13raLrxuiNC4NN2gAaCQYCwwf7LHeTJob10yVCIw5Sejs04OzSWqYL
 y22QDYWpO4yhss69rqC5WvIiRaMvZjGfAFpz1CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U
 Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQc3R8FJyti7x5K0kWm8ChlaLVwhDMsLcCSBj
 KT76VIIv8870JdHgMZKj2ON5yYCkPGI+TfNDKm8gj9yjn5ZLlXvEMZGPxH44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2IFc+hnkn9i+TBNBZ5rIvp1nPUNIjVC4ve/23oH
 yt3bZPWm32zrsWgCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF7rrE+lqAtE
 KFeEyhCa9wWIgn6F/0mRcGVhORfmN6D3Gpi5gKpP2oyeYBOXQvM9oO2dwfj7nBWXCG2qdE/s
 /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aYcMNOfEjM8ZRxL3CjhPEAPMxRew7IwSGX1
 ljKDE5A9/XNuYI87PLAmbuA89WyC+J7E0cDRzvb4L+6ODP05G2mxYMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpRSyZYU6qB7VsJmi98fNO7qAdlKVEvQaWW
 16U/oUIM7u+J864QkUaIxAob7rf2KhMyCXS9/k8PG7z+DRzoOicSUxXMhSB1H5dIb9yPN93y
 OstopdLuQm2ix5sOdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cHdcchIP2krP
 iSQ1fjLiLlrz0bfd2Y+SCrW1u1HiJVS4B1HwTfu/bhSdgYpUhPv4CBszA==
IronPort-HdrOrdr: A9a23:/6+aKqCLRx9gtI3lHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P
 xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884262"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 01/57] .gitignore: Non existing toolcore/include files.
Date: Mon, 6 Dec 2021 17:01:44 +0000
Message-ID: <20211206170241.13165-2-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

4664034cdc (tools/libs: move official headers to common directory)
forgot one .gitignore update.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index 9513506dd9..cad5aacd8d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -384,7 +384,6 @@ tools/include/xen-foreign/arm64.h
 .git
 tools/misc/xen-hptool
 tools/misc/xen-mfndump
-tools/libs/toolcore/include/_*.h
 tools/firmware/etherboot/eb-roms.h
 tools/firmware/etherboot/gpxe-git-snapshot.tar.gz
 tools/misc/xenhypfs
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239418.414973 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOI-0006SS-AM; Mon, 06 Dec 2021 17:03:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239418.414973; Mon, 06 Dec 2021 17:03:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOI-0006SE-6d; Mon, 06 Dec 2021 17:03:02 +0000
Received: by outflank-mailman (input) for mailman id 239418;
 Mon, 06 Dec 2021 17:03:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOH-0005ti-2k
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:01 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5dadd8a9-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dadd8a9-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810179;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=3N07QGAtESY5bqMCOllijGa4cGWUF9eCtceys/Ns6K8=;
  b=G3uvCrDpG55W6OnGgWheKFcApMFKReNySs6pcy3IHXDdqF6zVnKuIir6
   ZIY6saXzkDYiDY9VAALTB1Cvo0UNVknkfnjmlpGpnfmyhF1VvyIDMKPMp
   gRaAposA5P6Fl4wPsxT0AYd2x3QygQ0bj/90eEerea9mQnAODuB5KQdZo
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: sywNBfXnP6sCqwGVg2yegclBoqeRZnnFfSn58+Cl4ZZG7I16R0TtNXSMWYLApskeUxPrGeebHe
 mhcZUMyPzOzs8ejPT3BDhEZxO5moiK05kzJOlWtxUC8O3A7ipB23thcCb6A5cRO1UskjNPi2xE
 hguUILyYzYPLdG8xIQpmPWO+7djnNu4CyBRscbxSHYvSyW/wP7OPsS20qKVzAoCG/fm+Lntc/p
 hVcDjGgHBoAo6zyPTEW12Gd+TwI2wJXqZVMs8ES1lG4WL2HHrQVpZsrFnUq3AvC0TR5nNEgJ3l
 auopn4rdLPQmW6rlQzgSjrVu
X-SBRS: 5.1
X-MesageID: 58884268
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hyi46Kj/IFKkH2L/EOlsBdcwX161hhcKZh0ujC45NGQN5FlHY01je
 htvDGiHOvuLM2v3fNAnPYy+9kgBvcDVnN9rQAVvqC48EHgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1DtYKaSC0LLJfqs7wNeTJKGnt3LKtvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauON
 5pFM2Q/BPjGSxdvYHpPEI1up8CDlEnxTzkCon6Jg6VitgA/yyQuieOwYbI5YOeiRNpXtlaVo
 Hrc+Gb0CQ1cM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80iMosag18l3tVtTnVge0iHGBtx8YHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSIC2
 F+XtdLDJy5VlpbNWVi25L7OpCK0EH1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm
 G7T8nVn71kHpYtSjvjgowib6965jsGRFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5
 yhsdyRzAYkz4XCxeM6lHbxl8FKBva/t3NjgbbhHRcNJG9OFoSHLQGyoyGsiTHqFy+5dEdMTX
 GfduBlK+LhYN2awYKl8buqZUppxnfe6RIm/DK6LPrKih6SdkifdpkmCgmbKgAjQfLUEy/lja
 f93j+7yZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeNm+58INI8wPwO/goKl
 1nkMnJlJJPErSWvAW23hrpLMdsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:R4ZhS66j+dofRWlu2gPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884268"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 03/57] tools/Rules.mk: Remove $(CFLAGS.opic) from %.opic: %.S
Date: Mon, 6 Dec 2021 17:01:46 +0000
Message-ID: <20211206170241.13165-4-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

$(CFLAGS.opic) isn't set anywere, never was, just remove it.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Rules.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/Rules.mk b/tools/Rules.mk
index b022da3336..4e9b4ee17f 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -155,7 +155,7 @@ INSTALL_PYTHON_PROG = \
 %.o: %.S
 	$(CC) $(CFLAGS) $(CFLAGS_$*.o) -c $< -o $@ $(APPEND_CFLAGS)
 %.opic: %.S
-	$(CC) $(CPPFLAGS) -DPIC $(CFLAGS) $(CFLAGS.opic) -fPIC -c -o $@ $< $(APPEND_CFLAGS)
+	$(CC) $(CPPFLAGS) -DPIC $(CFLAGS) -fPIC -c -o $@ $< $(APPEND_CFLAGS)
 
 subdirs-all subdirs-clean subdirs-install subdirs-distclean subdirs-uninstall: .phony
 	@set -e; for subdir in $(SUBDIRS) $(SUBDIRS-y); do \
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239419.414983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHON-0006pY-KN; Mon, 06 Dec 2021 17:03:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239419.414983; Mon, 06 Dec 2021 17:03:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHON-0006pL-GO; Mon, 06 Dec 2021 17:03:07 +0000
Received: by outflank-mailman (input) for mailman id 239419;
 Mon, 06 Dec 2021 17:03:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOL-0005ta-NN
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:05 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f9b3036-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f9b3036-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810184;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=dGQdT72+D933SmY+1liMgkLhAn+NNQrE1q7y6JIxSec=;
  b=PjiKhHIG75Agld5T/rU17D0dM7fEinshu7IVykFyXykb4eb2hU2E0DWT
   4PQBfYMKwtGchp/4eDi7zjT9YprI6n0eK3Kg889Kpaauvwf3+zN9TUMlA
   it4xMW/Q4X8iFLtUa8M4rnwZp+otmBeQFxUnVYypwx78n5yD1t5HS5TQH
   I=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ETkRjVaNhYjj/HzEsJIubXXXXxCCCHgqibvlJb3/+Tfl7F1NIIb1HiSwEKIs2YJIekabFHjh/5
 Giu8A7s/4ZfeU2/SxuJD2LYmVjMkiZ0RDc/dX/Y32xUDuDf5+OUiYsq0iMHOGSLwTs1U29vyBr
 xmwxd17wqxsd4TVvUzZ5uCSc58X2S/XZ04QnOCB9AEt0YBQzNej3RgEX0T3If2UrsybNyAlXlh
 HFhHniAzu95a9i6BzLzb+S5mSnsVnaAFb1DsBClAb/w66itz+hz/OTj8Kkhlcrit9OFaMHwRLD
 ViZJXnlHrz3x9/Tz3xrKuHlM
X-SBRS: 5.1
X-MesageID: 59387736
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:q1bA+ailmAzhCbocan0uFl5rX161yhcKZh0ujC45NGQN5FlHY01je
 htvDD2Gaa7bZGP0Lt5yat+z9BlU6MKHytI2HQNt+S4zFC0b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Xs6eOTA14EpHilaceYQtIKhlMZLF/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPP
 JpGNmExBPjGSzBwM3QOKc0uprapmSLxeB9gjWmH4rVitgA/yyQuieOwYbI5YOeiXt5Jl0yVo
 mbH+WXRARwAMtGbjz2f/RqEhPLLnC79cJIfEvu/7PECqF+c3GsIEzUNSEC25/K+jyaWRNZ3O
 0ESvC00osAa/Uq3Tt77TlugrWSNpBI0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSME/NvLsIw1lgjITNtoDOiylNKdJN3r6
 2nU9m5k3exV1JNVkfXglbzav96yjoLPdTAw7FT7YkyorQBLdp6cX77x9WGOuJ6sM72lZlWGu
 XEFne2X4+YPEYyBmUSxfQkdIF26z63baWOB2DaDC7Fkrm3woCD7Iei89RknfB8xWvvobwMFd
 6M6Vel5wJZIdEWnYqZsC25aI5R7lPOwfTgJux29UzavXnSTXFLelM2NTRTJt4wIrKTKuftlU
 Xt8WZzzZUv28Yw9kFKLqx41iNfHPBwWy2LJXozcxB+6y7eYb3P9Ye5bawvRNLFktvna/1W9H
 zNj2y2ikU83vArWOHa/zGLuBQpScShT6W7e9aS7idJv0iI5QTp8Wpc9MJsqepB/nrQ9qws71
 irVZ6Os83Km3SevAVzTMhhLMeqzNb4i/SNTFXF9Zj6Ahil8CbtDGY9CLvPbi5F8r7c9pRO1J
 tFYE/i97gNnFm6apm9DNMal9+SPtn2D3GqzAsZsWxBnF7YIeuAD0oWMktLH+HZcAyypm9E5p
 rH8hArXTYBaH1ZpDdrMaeLpxFS05CBPlOV3VkrOA99SZESzr9Q6d32v1qc6c5MWNBHO5jqGz
 ALKUx0WkvbA/t0u+97TiKHa84rwS7liHlBXFnXw5KqtMXWI5XKqxIJNCb7afT3UWG7u1r+lY
 OFZk6P1PPEdxQ4YuItgCbd7i6k54oK39bNdyw1lGlTNbkiqVew8ciXXg5EXu/QUlLFDuAawV
 kaewfVgOO2EaJH/DVocBAs5deDfh/sarSbfsKYuK0Lg6S4poLfeCRdOPwOBgTB2JaduNN932
 v8ovcMb5lDtihcuNdra3ClY+37Vcy4FWqQj8JobHJXqmkwgzVQbOc7QDSr/4ZeubdRQMxZ1f
 m/I1fSa37kMlFDfd3cTFGTW2bsPjJsDjxlG0VseKgnbgdHCnPI2gEVc/Dlfot65FfmbPzaf4
 lRWCnA=
IronPort-HdrOrdr: A9a23:nUlQmajm/a4XMtgmAW1mQX/+bHBQXtwji2hC6mlwRA09TySZ//
 rAoB19726StN9xYgBYpTnuAsi9qB/nmKKdpLNhX4tKPzOW3FdATrsD0WKK+VSJcEfDH6xmpM
 JdmsBFebvN5DNB4/oSjjPVLz9Z+qjlzJyV
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387736"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH 04/57] libs: Remove _paths.h from libs ctrl and util.
Date: Mon, 6 Dec 2021 17:01:47 +0000
Message-ID: <20211206170241.13165-5-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

libxenutil doesn't include _paths.h so no need to generate it.

libxenctrl doesn't use macros from _paths.h so can be removed.
Fix libxenguest to include _paths.h properly instead of relying on
xc_private.h

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore                    | 2 --
 tools/libs/ctrl/Makefile      | 5 -----
 tools/libs/ctrl/xc_private.h  | 2 --
 tools/libs/guest/Makefile     | 2 +-
 tools/libs/guest/xg_suspend.c | 1 +
 tools/libs/util/Makefile      | 6 +-----
 6 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/.gitignore b/.gitignore
index cad5aacd8d..111eb03b86 100644
--- a/.gitignore
+++ b/.gitignore
@@ -117,7 +117,6 @@ tools/libs/hypfs/headers.chk
 tools/libs/hypfs/xenhypfs.pc
 tools/libs/call/headers.chk
 tools/libs/call/xencall.pc
-tools/libs/ctrl/_*.[ch]
 tools/libs/ctrl/libxenctrl.map
 tools/libs/ctrl/xencontrol.pc
 tools/libs/foreignmemory/headers.chk
@@ -157,7 +156,6 @@ tools/libs/store/utils.h
 tools/libs/store/xenstore.pc
 tools/libs/store/xs_lib.c
 tools/libs/util/*.pc
-tools/libs/util/_paths.h
 tools/libs/util/libxlu_cfg_y.output
 tools/libs/util/libxenutil.map
 tools/libs/vchan/headers.chk
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index 519246b0d6..5d866b8d04 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -54,11 +54,6 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
-$(LIB_OBJS) $(PIC_OBJS): _paths.h
-
 -include $(DEPS_INCLUDE)
 
 clean: cleanlocal
diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h
index 2e483590e6..824d3cfc21 100644
--- a/tools/libs/ctrl/xc_private.h
+++ b/tools/libs/ctrl/xc_private.h
@@ -29,8 +29,6 @@
 #include <limits.h>
 #include <sys/ioctl.h>
 
-#include "_paths.h"
-
 #define XC_WANT_COMPAT_MAP_FOREIGN_API
 #define XC_INTERNAL_COMPAT_MAP_FOREIGN_API
 #include "xenctrl.h"
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 2ce92d247e..b49e5059f2 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -111,7 +111,7 @@ libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
 genpath-target = $(call buildmakevars2header,_paths.h)
 $(eval $(genpath-target))
 
-xc_private.h: _paths.h
+$(LIB_OBJS) $(PIC_OBJS): _paths.h
 
 -include $(DEPS_INCLUDE)
 
diff --git a/tools/libs/guest/xg_suspend.c b/tools/libs/guest/xg_suspend.c
index 0ce6364963..128353029c 100644
--- a/tools/libs/guest/xg_suspend.c
+++ b/tools/libs/guest/xg_suspend.c
@@ -19,6 +19,7 @@
 #include <xenevtchn.h>
 
 #include "xc_private.h"
+#include "_paths.h"
 #include "xenguest.h"
 
 #define SUSPEND_LOCK_FILE    XEN_RUN_DIR "/suspend-evtchn-%d.lock"
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index f5f9e89fee..87425d862a 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -39,7 +39,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-$(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS) _paths.h
+$(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
 
 %.c %.h:: %.y
 	@rm -f $*.[ch]
@@ -49,14 +49,10 @@ $(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS) _paths.h
 	@rm -f $*.[ch]
 	$(FLEX) --header-file=$*.h --outfile=$*.c $<
 
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
 -include $(DEPS_INCLUDE)
 
 clean: cleanlocal
 
 .PHONY: cleanlocal
 cleanlocal:
-	$(RM) -f _*.h
 	$(RM) -f libxlutil.map
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239420.414995 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOP-00076c-03; Mon, 06 Dec 2021 17:03:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239420.414995; Mon, 06 Dec 2021 17:03:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOO-00076P-Qt; Mon, 06 Dec 2021 17:03:08 +0000
Received: by outflank-mailman (input) for mailman id 239420;
 Mon, 06 Dec 2021 17:03:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHON-0005ta-Ar
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6161c2ab-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6161c2ab-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810186;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PF7/5zEo4jDOxqZUxq2UUbdYIZsE8xugvykCl7MlfeA=;
  b=IOvCR0hAmGfvnMho4dsTZb0iP6Zfq4eCDMvqBVowvp0BCv3WdjbMS0QE
   FplmuyhlYCsxFx4fkP9AZrzBKXkNvz+5xD0TbuQjrlS8+QB1Qi7Spc7Go
   1lYbLYpPvP8e77oPBlKRggQh5/jBtk0r3FYiSm2d/EtCO4iFkaGrqXxOk
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: n6U9gc6/9UNcQbsKdjvz9fL3AJSy6ydRf6ZAl+5Rionxf8kDM84dd0gdl/bqsKxGBmz5lZL7LP
 LxRUjdwc9qZt4mnJLeFuBZHtYp6OlmNP8W/U8fRmMX44xJxjKMcWOm/v/mro5tDMapNXMqPVAw
 gGrDvQmlVFHhQ8SwTnCH6OsA2YVSwXiGaqr2ZDStqxA3pYNFwHMEg4WHvPDDKkcdpRmiXZ2tfP
 t3Ee/nfjCvt1+YtrqzCGDUgqm0mVXyE/WyM9FofspfeT/m3Lo1SU4+j/Xs2EMDsbSjFbOFraJR
 v/urDFspNKj4356RFAadETh3
X-SBRS: 5.1
X-MesageID: 59387743
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YwohFKB+5vpF7BVW/9jkw5YqxClBgxIJ4kV8jS/XYbTApGgn3jRWz
 2IYCm6OOq2PajGmL48lPorl9htS75bVnYBhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/qgyJgPN71
 M92moGIFR4ZIYLuscYFekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWxg2Z8SRp4yY
 eIwODw1chLFOCR2O3o4A6gwksL3pyfwJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt822urv/CmzvhX4AfH6H+8eRl6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZtD7Qx2/pm/CphMGUsBcO+I/4QCJjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHkYSVVlGX6q2vgi6KZTElMkAgTA0cZF5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjv9tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWS0bb1HRcBJG9GRF5iLJ9o4DNZWfhgBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66PPoUUM8UrLlHYrEmCgHJ8OUi3yiDAdollZ
 v+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwJzLqVp
 S/kBRcDoLc97FWeQTi3hrlYQOuHdf5CQbgTZETA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:/gqaCqphLyvcB3/DgszHo/IaV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387743"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 06/57] libs/libs.mk: Remove generic variable that already exist
Date: Mon, 6 Dec 2021 17:01:49 +0000
Message-ID: <20211206170241.13165-7-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

comma, empty, space are already defined in "Config.mk".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 830bdc851f..dfbbef4080 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -26,9 +26,6 @@ ifneq ($(nosharedlibs),y)
 LIB += lib$(LIB_FILE_NAME).so
 endif
 
-comma:= ,
-empty:=
-space:= $(empty) $(empty)
 PKG_CONFIG ?= $(LIB_FILE_NAME).pc
 PKG_CONFIG_NAME ?= Xen$(LIBNAME)
 PKG_CONFIG_DESC ?= The $(PKG_CONFIG_NAME) library for Xen hypervisor
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239421.414999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOP-0007BR-C8; Mon, 06 Dec 2021 17:03:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239421.414999; Mon, 06 Dec 2021 17:03:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOP-00079u-5M; Mon, 06 Dec 2021 17:03:09 +0000
Received: by outflank-mailman (input) for mailman id 239421;
 Mon, 06 Dec 2021 17:03:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOO-0005ta-9c
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:08 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 61157ab3-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61157ab3-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810187;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=DaXrysSp90BOa7sFLTeOykjPBw9Q7LCEVZdF9MEMsoE=;
  b=DzcK9qCnzNPwzJM9IMZIbmWbKDB/8CF4X8em30ULNMPw7nqyzq0ub1cl
   JhokXC6VwnbSDAcAYzds6aMNJvGbxo0UT5XLszNd+y7ehYS95YW8Ra3BF
   e1pWBACmlQbvoVJRJeKNoCku3dp4WYoFMp/7Cp+mqfTA6naEYIGaEsG+Y
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3g1gjSOqn/8TRY7RoV705Ql66WfCzKRg3U1yPMjNX42Imr3IJpqCpwx6XsHQOsZi8WCOBbnQJz
 Gi3tRlJI/dbYEWP9RTLpOe4YAyam0r0AO3WSCtxiPneJ6eZx3nC0YYzcee/IwQ7ZeJHq/ZWWwz
 kHLDvHlMqtWERlReTWCqS/6/Igoywp7hGZ3x7eaUPxA1WxapJUGJSwF6kLABxlBKsWfF8wMD7u
 21NtmMebKRNqxqnM3leHMi+r+3HSpqk1hkpGxqbM4+Gl0yAf2FT3p7G6lNDCvlLKEaDLgk57lD
 /lnDE4ZRXFM4tASLRHArTFKl
X-SBRS: 5.1
X-MesageID: 59370474
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eMYLxqIiAzREeCT3FE+RIZIlxSXFcZb7ZxGr2PjKsXjdYENS12EHx
 mEXXD2DP6qCMTDzKNtzYYy3oEtSu56Dn9VkHgRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3Sz8Bvx
 ot3m6WcWCVxP6f3mO8ddwJXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph3Z8WQamCD
 yYfQSZ2aQj4YUEXBmkKNZduoN73l3P2VwQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 G3c+H/iKgoHL9HZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVVhukoHmCr1gEVsBZCeES5wSEy66S6AGcblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpXOGWKD+OmugwqeKApNLGU5ZSQEaRAKtoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNt1shPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWB2DaD/LF7rlxBHkJPm6gKulmSw28zba45lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIEePcIgKVXdon4+DaJ144wLuBJ2+U3YE
 c3EGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivruSo
 yzmBBYHkAGXaL+uAVziV02PoYjHBf5XxU/X9wR2Zz5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:pprZf61ZUOn8izpAeBbdQwqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370474"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 05/57] libs: Remove -Iinclude from CFLAGS
Date: Mon, 6 Dec 2021 17:01:48 +0000
Message-ID: <20211206170241.13165-6-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

They are no more directory libs/*/include.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index ebdb2a4782..830bdc851f 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -12,7 +12,7 @@ MINOR ?= 0
 SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map
 
 CFLAGS   += -Werror -Wmissing-prototypes
-CFLAGS   += -I./include $(CFLAGS_xeninclude)
+CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
 LDUSELIBS = $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239422.415017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOR-0007lO-Ss; Mon, 06 Dec 2021 17:03:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239422.415017; Mon, 06 Dec 2021 17:03:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOR-0007kg-L9; Mon, 06 Dec 2021 17:03:11 +0000
Received: by outflank-mailman (input) for mailman id 239422;
 Mon, 06 Dec 2021 17:03:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOP-0005ti-TL
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:10 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62568e49-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62568e49-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810188;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=AqCx8xVKCHbiltbPVLDXC8pN1HeD+g0vLeuICQJzUro=;
  b=OUA2kz0NewsT4bjgZ1J81sQqvPk55TZFbuzd98Z8qKdIwLOcIsOp3JUx
   q1pt4tZzRGLsLPyY/HyBXk6rAt7ypxuNqJUNoAEdu9rgjVIb/q5bdzGE8
   k5TMF55EdtQ8zf1KKf744UY+BqtiVEpjDmMQyW6vwt5hTqR5aUZi68zvc
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: HJjA2Up8hf8DgKMSCXZebzVgqV349LhdLVMYes+U2mPE3xpuNPK5L2hdCmi2ubW0cUGP1CDSHS
 UUEf2xTYYpynmnEUecbQcNzjKcUDL4EVNK2HidrbXD2TDrskuTuvmddd64RafEx4tyG21XY8yA
 ZpJNVGdAxm21uXsTrEr3ySyBHMsfr5lR8KYevbpPy8qOqTkhxjnG1SUQdRd1TDvJSfDgmcBUGc
 j4pqzcc3lRtj8nzMpUHIArGGVDCfXOXM41Ce1FRGbKWsaQ6yzG/0PXQb9bhJnA5ibiCKaiNNTM
 dndxTkEf+FW/8o/fVBmscTB+
X-SBRS: 5.1
X-MesageID: 58884283
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Pg+hravF2vr3pgb5U9tkiR2suOfnVKdZMUV32f8akzHdYApBsoF/q
 tZmKTrXPvbZYDH3f90jYdu38xxQ6JPczNQxQQRpriswQX9E+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplqJDgYjkbO6/1nadGAz5VEQpuYY5F0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 5pJNWA/N3wsZTVsIFoaDatgo92Pg0bYLSdWrVm1poM4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhMVLtuE0hKe72mhwOTImEvTWZ0QPK218OZwh1+ezXBVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhcaR9pXFfx88AyXw7DYywmcD2kACDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8sD/iEhYnKG07YGxfHSwI4fLz/KIwp0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9XwsQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm3FF52LJ9k4DNRCyKFBaJxsldjBO
 hC7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHcrH40NBPKhT6ywCDAdJ3T3
 7/BK65A6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILOO5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:YHOioql0awuY245S25XUtKoqfQbpDfIm3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7Qr5OUtQ/uxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVybygc378
 ldmsZFZOEYdWIK7vrH3A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884283"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 07/57] libs/guest: Drop spurious include in Makefile
Date: Mon, 6 Dec 2021 17:01:50 +0000
Message-ID: <20211206170241.13165-8-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This include hasn't been useful since e567964a54 (tools: drop ia64
support).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/guest/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index b49e5059f2..c6d882e239 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -71,8 +71,6 @@ SRCS-y                 += xg_dom_decompress_unsafe_xz.c
 SRCS-y                 += xg_dom_decompress_unsafe_zstd.c
 endif
 
--include $(XEN_TARGET_ARCH)/Makefile
-
 CFLAGS   += -Werror -Wmissing-prototypes
 CFLAGS   += -I. -I./include $(CFLAGS_xeninclude)
 CFLAGS   += -D__XEN_TOOLS__
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239426.415028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOX-0008R6-KG; Mon, 06 Dec 2021 17:03:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239426.415028; Mon, 06 Dec 2021 17:03:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOX-0008QC-BC; Mon, 06 Dec 2021 17:03:17 +0000
Received: by outflank-mailman (input) for mailman id 239426;
 Mon, 06 Dec 2021 17:03:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOV-0005ti-Nh
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:15 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66618f48-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66618f48-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810194;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=7opyQyqBD4bp65pDWsyDxZ8R2Dsh09XMMGy7CWwOvJI=;
  b=Fgj3h/7HAaQJnB5vD7uZFcKyj0c8uCDydFmDrA2h2u0SHwfSMUXgShfu
   qvA8z7YWepiiFNv6RKNEGSIYrw1NA0u6i8Ivia8G8Hiu/QnHB9FzP/O4c
   JhJaWtzJlT7Zte8AhmdYJ34r9I+Aqbu3r8CMl3vYbodB8iMTAwd8sqNPf
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8pVUxEHKFUaBG3nW93DwpRmzURM2NQdzzTlXAu0dv9eARkPc86GZAfDlgyxHaQ2+4qZYs3UBXe
 rJ69QzDvJUaR8S34/qi92Rr6934oTj+YPWDx5kSbv6I5RxsH/GO8QsTlRJJ56Or3jbPfS3JrWj
 gdY8jzCHTY5nnfqTi+Ftv5iW6HilNnerQ3u5XLG7lOHv9jNEcDW98zyLojblhcasmCApYRKSlC
 9QEVBNXHLeLrZbHs0fiaoS1QhNuN3yJH+KNfSekVIHbGX4+lkps/BQdCSRfZd53GltrypV7duZ
 YkOPP4jvcaH1CpYih5qzD6lf
X-SBRS: 5.1
X-MesageID: 58884308
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TEoWtKzDfR/VkO+P1916t+fGwSrEfRIJ4+MujC+fZmUNrF6WrkUHz
 TQXWj/QO66OajHyct4ga4y18UwH7ZfcnYBqSQE+qiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wbZn2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt85gy
 /lTvKHzc0AoY4fOlcZEeABVHC4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25AeTaqFP
 5pxhTxHRz+RWgF+BE0tJIMzo7b5jWnOdj4IgQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krE8H7+GQoyL8GExHyO9XfEru7QnwvrVYQKDrq6+/V2xlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzWxpmKEuRgNHcJdCeQg5CmCz6PV50CSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYWyM9ZuKpA7xA28UcEUAaA1dZhII7Na29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysgPNb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM2d3XC3270k5JGQWy2yGskTKuOGpxbEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQOcguLl7apnswOh74M4XRfK4Ey/tX1
 XCzK5nEMJrnIf4/kGreqxk1j9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgo
 ivgBxQGkQWn3hUq62yiMxheVV8mZr4nxVpTAMDmFQ/AN6ELbdn94aEBWYEweLV7puVvweQtF
 6sOetmaA+QJQTPComxPYZ74pY1kVRKqmQPRYHb1PGlhJ8ZtF17T59vpXgrz7y1SXCC5gtQz/
 u+73QTBTJtdGwk7VJTKaOiixk+atGQGnL4gRFPBJ9ReIR2+8IVjJyHroOUwJsUAdUfKyjeAj
 l7EChYEv+jd5YQy9YCR16yDqo6oFcp4H1ZbQDaHverna3GC8zP6k4FaUeuOcTTMb0/O+f2vN
 bdP0vXxEPwbh1IW4YByJKlmkPAl7Nz1qr4Ekgk9RCfXb06mA69LK2Wd2ZUdrbVEw7JUtFfkW
 k+L/dUGa7yFNNm8TQwULQshKO+CyesVin/Z6vFseBf24yp+/bymV0ROPkbT1HwBfeUtaI51k
 /08vMM26hCkjkt4O9mLuSlY6mCQIyFSSK4grJwbXNfmhwdDJouuunAA5vsaOK2yVug=
IronPort-HdrOrdr: A9a23:f16jNq/R3G++yVG+Dbluk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884308"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 10/57] libs/stat: Remove duplicated CFLAGS from deps
Date: Mon, 6 Dec 2021 17:01:53 +0000
Message-ID: <20211206170241.13165-11-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Those CFLAGS_* are already added in libs.mk via USELIBS_stat.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/stat/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index c99508ae6b..911a2de8ec 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -15,7 +15,7 @@
 XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenstore) $(CFLAGS_xeninclude) -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
 SRCS-y += xenstat.c
 SRCS-y += xenstat_qmp.c
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239427.415034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOY-00005S-9n; Mon, 06 Dec 2021 17:03:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239427.415034; Mon, 06 Dec 2021 17:03:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOX-0008WA-SC; Mon, 06 Dec 2021 17:03:17 +0000
Received: by outflank-mailman (input) for mailman id 239427;
 Mon, 06 Dec 2021 17:03:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOW-0005ti-8n
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:16 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6588a4fd-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6588a4fd-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810194;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=h0c7AVYNaXZXmkfcs0ZxJdS6Ur35AwxyJVtAoKnfTKc=;
  b=LWFF16ct4xVIY6fDCj6QcwdMTo9oDR7dP/MH/+RRviEa7qdK2zDqGtKm
   Bp8soBIxMFRy8FA/53O9ERtDjEzJjk4ErUMIa8vhdCf20XoV1ktluqA1k
   v3pv+WESYs5Xrft8PZXQE5qkHJZZ8zTTKrutKz2ASLc0L5wmVDqDf3wIt
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: CUPI3Te5pu8yikiSgt36ZmvPy4SXldVYUlepazbb7qdU9b+0gLED1RSYTYEaCcbZeInv6nsXpl
 L5/QHf3iFQlcO1g/QSx3wyHCUws3X79RfytV5ZAwKXfs8DWaxBwMkhaa+HT1l9200NsoOJE3ky
 GXry/CCnS9s++b+6ESnU3cSQ9qV3OiBa9LtvTbbGkVzSc4Lpb5uge5cvVPI2X9BebpHxI2t5P8
 D+z5fT5eOEY/pMfTM7m+8qegH8TYMgSFEvZ/n2ZfViNqfMH37DT7RaCsLgpxu5RS/KZSDIDO9L
 16ynw3bfaExbj7QBjsxybNmc
X-SBRS: 5.1
X-MesageID: 59323973
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AM8JzagBsNLPyXWlzKBE0n2tX161kRcKZh0ujC45NGQN5FlHY01je
 htvD2qBOqncM2X1KNF3ao7npE8B68LSyNI1SlRsrS8yQykb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1zi56gbh87EpT2u6MYYgsDOTFaEJR/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPP
 JBCOGU0BPjGSz9sKEU9J5Fvps3ytiXQVxxXmBW1iINitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAB4AM8eE4SGY6X/qjejK9Qv6R4A6BLC+7uRtglCY2ioUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxastxgAW91WAqsi5RuE0Kb87AOQB2xCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J+qkzGiHjAHAVY4RmgBfBleycnHjbgK20enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPtTwsTDmAeB8wJF1p7Vrl
 FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8rlxBGFb5JOi8BQ2Swm8zaK7onhezP
 yfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlTXo3s/OBTKgT+9+KTJrU3ZE
 c3BGSpLJSxFYZmLMRLsH7tNuVPV7n5WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchMClQek2ySYcV7ih7IKQOqHYKuTZEkTZUQEVWtEEVB5CWp2xKtAJZYxY5c98+lvkax9Q
 /UfIp3SCfVTUDXXvT8aaMCl/oBlcR2qgyOIPjakP2djL8IxGVSR94+2ZBbr+QkPEjGz6Zk0r
 Yq/216JWpEEXQljUprbMar901OrsHEBs+tuRE+UcMJLcUDh/dEyeSz8h/M6Oe8WLhDHymfI3
 gqaG05A9+LMv5U04J/CgqXd99WlFO53H0x7GWjH7OnpaXmGrzT7mYIZCbSGZzHQUm/w6Z6OX
 +QNwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 0/TqNlXPbKFZJHsHFILfVd3a+2C0bcfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s6JwM9giyqhs2KdLX3Clb+lOFImEET6h65IoRB5Xmi1Zzx1xPCXAG5vQaPH1bhw1wD3QX
IronPort-HdrOrdr: A9a23:Ff8hiK19/q6VXWir7HklWwqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59323973"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 09/57] libs/light: Remove -I.
Date: Mon, 6 Dec 2021 17:01:52 +0000
Message-ID: <20211206170241.13165-10-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

There is no need to include current directory.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/light/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 975413ade8..bfd58226ce 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -44,7 +44,6 @@ SRCS-$(CONFIG_X86) += $(ACPI_OBJS:.o=.c)
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
-CFLAGS += -I.
 
 CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239430.415045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOZ-0000ZY-NN; Mon, 06 Dec 2021 17:03:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239430.415045; Mon, 06 Dec 2021 17:03:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOZ-0000Xh-DY; Mon, 06 Dec 2021 17:03:19 +0000
Received: by outflank-mailman (input) for mailman id 239430;
 Mon, 06 Dec 2021 17:03:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOX-0005ti-Nr
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:17 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 676f0b32-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 676f0b32-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810196;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=+OlQ+THP4J9buVH+FPSpdVxwEazvI9jKgpeddJ/Kp5A=;
  b=iKtBvJc+2k0w4+GT68DgiCO1zLX0/PnFkYYDTCjGBwYR7QeBAjR2pif3
   mjXDXdiVHQgwoJW7j2VybdR4Zt44cGSQAM+O30hsvuPhba8S/+s0CGSSv
   d2ySe1QbvPUtOHo76aCq26L1uuC/GcLhoT98bgVkxRUg3s+A7WGVU6ktr
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JphdPSgst0BUiYRj99VRgUlnyVZmt1yRiAvgwSsBdNYRgLBuKZeAtaitwXnORAfWTvWzxWq32C
 zruFi2OAg3zCXKYLrZTAJpFtD4EtijKIEqfy9XM0JciFW1aEj52A1GfhNQXc1Rmg/NU3Hz+vfD
 Bi5/ghIaV0VNXVxqmtAN3PEtnwA7dEqjxV756NR2o1Egr7Lidr737KyeWV8EoRyTZHJDpqg5Q5
 x46551nG8uN9EYCWx2mkIPPqvnOEoquUom/1NmXTgFifTm4mhRdGvXheF4FB/ZF1JoYlS4PCyF
 UlWGPcPHJ2b2DU7z55Q1hQ3I
X-SBRS: 5.1
X-MesageID: 58884312
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3ZPd76hzM32AmLbB5oEqUblgX161kRcKZh0ujC45NGQN5FlHY01je
 htvCmCPaPePZzfzfYt+a4S/90tS78TVn95gHAE5/no0Hykb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1Hl4WtVz5uM5Hss8sGSDtDUCp0FL1JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauON
 5pFMmM1BPjGSyRJGmkuFdU0puWh33jELjBm9n2NgpNitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAB4AM8eE4SGY6X/qjejK9Qv6R4A6BLC+7uRtglCY2ioUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxastxgAW91WAqsi5RuE0Kb87AOQB2xCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J+ejyqvJxFSIFMiTgAfVikeoNLpiZE820enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPtTwsTDmAeB8wJF1p7Vrl
 FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8rlxBGFb5JOi8BQ2Swm8zaK7onhezP
 yfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlTXo3s/OBTKgT+9+KTJrU3ZE
 c3BGSpLJSxFYZmLMRLsH7tNuVPV7n5WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchMClQek2ySYcV7ih7IKQOqHYKuTZEkTZUQEVWtEEVB6CWp2xKtAJZYxY5c98+lvkax9Q
 /UfIp3SCfVTUDXXvT8aaMCl/oBlcR2qgyOIPjakP2djL8IxGVSR94+2ZBbr+QkPEjGz6Zk0r
 Yq/216JWpEEXQljUprbMar901OrsHEBs+tuRE+UcMJLcUDh/dEyeSz8h/M6Oe8WLhDHymfI3
 gqaG05A9+LMv5U04J/CgqXd99WlFO53H0x7GWjH7OnpaXmGrzT7mYIZCbSGZzHQUm/w6Z6OX
 +QNwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 0/TqNlXPbKFZJHsHFILfVd3a+2C0bcfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s6JwM9giyqhs2KdLX3Clb+lOFImEET6h65IoRB5Xmi1Zzx1xPCXAG5vQaPH1bhw1wD3QX
IronPort-HdrOrdr: A9a23:mWu96q6G6aQ8/iYysgPXwMLXdLJyesId70hD6qhwISY7TiX+rb
 HKoB17726StN9/YhAdcLy7VZVoIkmsl6Kdg7NwAV7KZmCP0wGVxelZnO/fKlbbdREWmNQw6U
 4ZSdkcNOHN
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884312"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 11/57] libs/store: Remove PKG_CONFIG_REMOVE
Date: Mon, 6 Dec 2021 17:01:54 +0000
Message-ID: <20211206170241.13165-12-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

PKG_CONFIG_REMOVE doesn't do anything anymore. Commit dd33fd2e81
(tools: split libxenstore into new tools/libs/store directory) had
reintroduced it without saying why.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/store/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 43b018aa8c..c208dbb48a 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -27,8 +27,6 @@ CFLAGS += -I $(XEN_ROOT)/tools/xenstore
 xs.opic: CFLAGS += -DUSE_PTHREAD
 ifeq ($(CONFIG_Linux),y)
 xs.opic: CFLAGS += -DUSE_DLSYM
-else
-PKG_CONFIG_REMOVE += -ldl
 endif
 
 -include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:03:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:03:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239436.415061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOh-0001hU-3o; Mon, 06 Dec 2021 17:03:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239436.415061; Mon, 06 Dec 2021 17:03:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHOg-0001hG-Vm; Mon, 06 Dec 2021 17:03:26 +0000
Received: by outflank-mailman (input) for mailman id 239436;
 Mon, 06 Dec 2021 17:03:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOf-0005ta-M2
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:25 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b143b41-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b143b41-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810203;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=w1OhVzUVsrx+N6DExzCgUwZ3ahqbZkwu+S8c7CbAdw8=;
  b=ViSjD6rE/UWDJTaNOWM1wjzvA2LCCSzTEr2F36OlMcBoL7HwF67sGKTf
   X3oTjNiiaA4GSQN18Y+eo+b88ZsJu30CCRjMSmOve2iI3QybzW2M8sESF
   NLtyUoGpjyhnQAMzKxneZzCmT9/v69nn4BXso4XkfYdoofSEdFOqb0ggd
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bwRPUq4fICmYJLpimF/3ueD5XfxVp4E3AL4hfpYkj4/UihUftKhHUC8AsKBaP4DAe0uvstUWOH
 0UqN06As0HvWcRYdQFQZm0WCkK4mv5NcNdnSvIzV6boHkSjtGP7r4PxrwGbGj1TshW198t15v0
 wVTk3gC+dig9LOTdJ7giNmgRtkmgh6sU1KSTzBxvgj6QazJ0TmaSFqe4M2JEl7gOUn6IvCtrzz
 mCSfCbi52c9p7YrujQqvA+qL+iCv+yLzyqVNGlQDBr+0JDVgLXnDUxF6HX0ZBB2asj2bbbZwcR
 sl4lf1kMP272OmqQV4rWbXYQ
X-SBRS: 5.1
X-MesageID: 59370544
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KWF+IKpwVQiRakiB6bmxgvMxvEBeBmKFYhIvgKrLsJaIsI4StFCzt
 garIBnUaKvcYGr0fNh2adji9ENSvJGAn9RjSlQ/ripjQiwQo5uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx24DnW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnYCvTg0tOpTzo74UcTtYAR5xDK5DyqCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ptCNmIyMEiojxtnI1c+Jssep82TnWT0bBxojnGnt5oe7D2GpOB2+Oe0a4eEEjCQfu1Zhl2dp
 37G123hDwsGKceEzj6Y7nOrgPSJliT+MKoTC7+Q5vNsmEeUxGEYFFsRT1TTiea9ol6zXZRYM
 UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL86gCFBm8CX3hZZcYvrsMeSjkj1
 1vPlNTsbRRjv7GYRmiU3quFpjO1fy4OJCkNYjFscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6
 yyVqyI6g4wstpQC9Ye772/IsjGplIecG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl
 CNawpbDtYjiGbnIzXXQG7tVQNlF8t7caGWE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O
 RSD0e+9CXI6AZdLUUOVS9/oYyjJ5fK5fTgAahwyRoAUCnSWXFXYlByCnWbKgwjQfLEEyMnTw
 6uzf8e2Fmo9Aq961jewTOp1+eZ1nXBhnzKOH8qlkETPPV+iiJi9E+1t3LymNL9R0U95iF+Nr
 4Y32zWilX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul
 lngCh4w4Aeu3hXvdFTVAk2PnZuyBP6TW1pgZndyVbtpslB+CbuSAFA3K8FqIOJ5rbM7lpaZj
 ZAtIq29PxiGcRyfkxx1UHU3hNUKmM2DiV3cMiy7TiI4epI8FQXF9sW9Jlnk9TUUDzrxvsw7+
 uXy2gTeSJsFZgJjEMeJN67/kwLv5SAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkSrMsHkdTE2TBw6yxMC3WojiqzYNaCb7adjHBTmLkvq6lY
 LwNnf37NfQGmndMspZ9TOk3nf5vuYO3quYDnAp+HXjNY1C6MZ9aIyGLjZtVq6lA5r5Fog/qC
 EiBzcZXZOeSM8T/HV9PeAd8Nraf1esZkyX55OguJBmo/zd++beKXBkAPxSIjyABfrJ5PJl8n
 LUksc8SrQe+lgArIpCNiSUNrzaAKXkJUqMGsJAGAdC01lp3mw8aOZGMWDXr5JyvaslXNhh4K
 zCZs6POmrBAyxeQaHE0D3XMgbJQiJlmVMqmF7Pey4BlQub4u8I=
IronPort-HdrOrdr: A9a23:23baMa/0SjlEZ9hPreJuk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370544"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel
 P. Smith" <dpsmith@apertussolutions.com>, Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: [XEN PATCH 14/57] tools/flask/utils: remove unused variables/targets from Makefile
Date: Mon, 6 Dec 2021 17:01:57 +0000
Message-ID: <20211206170241.13165-15-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

They are no *.opic or *.so in this subdir, so no need to clean them.

The TEST* variables doesn't seems to be used anywhere, and they weren't
used by xen.git when introduced.
Both CLIENTS_* variables aren't used.
Both target "print-dir" and "print-end" only exist in this directory
and are probably not used anywhere.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/flask/utils/Makefile | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index ae87102144..5449f05b13 100644
--- a/tools/flask/utils/Makefile
+++ b/tools/flask/utils/Makefile
@@ -4,13 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 
-TESTDIR  = testsuite/tmp
-TESTFLAGS= -DTESTING
-TESTENV  = XENSTORED_ROOTDIR=$(TESTDIR) XENSTORED_RUNDIR=$(TESTDIR)
-
 CLIENTS := flask-loadpolicy flask-setenforce flask-getenforce flask-label-pci flask-get-bool flask-set-bool
-CLIENTS_SRCS := $(patsubst flask-%,%.c,$(CLIENTS))
-CLIENTS_OBJS := $(patsubst flask-%,%.o,$(CLIENTS))
 
 .PHONY: all
 all: $(CLIENTS)
@@ -35,21 +29,13 @@ flask-set-bool: set-bool.o
 
 .PHONY: clean
 clean: 
-	rm -f *.o *.opic *.so
+	rm -f *.o
 	rm -f $(CLIENTS)
 	$(RM) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
 
-.PHONY: print-dir
-print-dir:
-	@echo -n tools/flask/utils: 
-
-.PHONY: print-end
-print-end:
-	@echo
-
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:05:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:05:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239438.415072 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHQK-0003wY-Hv; Mon, 06 Dec 2021 17:05:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239438.415072; Mon, 06 Dec 2021 17:05:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHQK-0003wR-Eh; Mon, 06 Dec 2021 17:05:08 +0000
Received: by outflank-mailman (input) for mailman id 239438;
 Mon, 06 Dec 2021 17:05:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muHQJ-0003w9-PI
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:05:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muHQJ-0002MJ-FL; Mon, 06 Dec 2021 17:05:07 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muHQJ-0007Rn-9M; Mon, 06 Dec 2021 17:05:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=iA9VwzgeLjQmDbv4EP3jDSQdCyXowGa9YKkwLg0zx9A=; b=Vl0GTnROOex8INQUCbOUucg6Hl
	/kB6MJ6vUQV/og2gpMLkhAQd1Rqyi3kS+ZKYIGGPe7TzZm86Fpf7iamTtoIQB5mFqOUUo8OrUA5Ou
	s51AyPvo5uT2bVyePYRDwTnErzdM45eo5DHMVK4XOdFu1saP/LLgPS6X0IRQj9RufkW8=;
Message-ID: <f439d5c4-aa6c-4066-3941-e497b67aeae1@xen.org>
Date: Mon, 6 Dec 2021 17:05:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211206153730.49791-1-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211206153730.49791-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 06/12/2021 15:37, Luca Fancellu wrote:
> Currently the maximum number of memory banks is fixed to
> 128, but on some new platforms that have a large amount
> of memory, this value is not enough 

Can you provide some information on the setup? Is it using UEFI?

> and prevents Xen
> from booting.

AFAIK, the restriction should only prevent Xen to use all the memory. If 
that's not the case, then this should be fixed.

> 
> Create a Kconfig parameter to set the value, by default
> 128.

I think Xen should be able to boot on any platform with the default 
configuration. So the value should at least be bumped.

> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
>   xen/arch/arm/Kconfig        | 8 ++++++++
>   xen/include/asm-arm/setup.h | 2 +-
>   2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4d3..805e3c417e89 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -25,6 +25,14 @@ menu "Architecture Features"
>   
>   source "arch/Kconfig"
>   
> +config MEM_BANKS
> +	int "Maximum number of memory banks."
> +	default "128"
> +	help
> +	  Controls the build-time size memory bank array.
> +	  It is the upper bound of the number of logical entities describing
> +	  the memory.

NR_MEM_BANKS is going to be used by multiple internal structure in Xen 
(e.g. static memory, reserved memory, normal memory). So how could an 
admin decide the correct value?

In particular for UEFI, we are at the mercy of the firmware that can 
expose any kind of memory map (that's why we had to increase the 
original number of banks).

So maybe it is time for us to move out from a static array and re-think 
how we discover the memory.

That this is probably going to take some time to get it properly, so
I would be OK with bumping the value + a config gated UNSUPPORTED.

> +
>   config ACPI
>   	bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED
>   	depends on ARM_64
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..785a8fe81450 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -6,7 +6,7 @@
>   #define MIN_FDT_ALIGN 8
>   #define MAX_FDT_SIZE SZ_2M
>   
> -#define NR_MEM_BANKS 128
> +#define NR_MEM_BANKS CONFIG_MEM_BANKS
>   
>   #define MAX_MODULES 32 /* Current maximum useful modules */
>   
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239444.415099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS4-0004uI-Ki; Mon, 06 Dec 2021 17:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239444.415099; Mon, 06 Dec 2021 17:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS4-0004t5-G2; Mon, 06 Dec 2021 17:06:56 +0000
Received: by outflank-mailman (input) for mailman id 239444;
 Mon, 06 Dec 2021 17:06:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOz-0005ti-Iy
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:45 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 777aeaf9-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 777aeaf9-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810223;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=7od1NQnHrZh8LHMHI1xfAIazt/3++YtpIBfjzwrGbJA=;
  b=T8m4sR9zUKBAtCIOe6QwybgT2k87mEfEvPWSj1B/bKn4UGSOWNQqGoGh
   NGYZRYV4oyS9Vxn/HxAf9+zoTq6bA9U17u7YQEXJm+t54ez2yjrwBKjUr
   tFVm+I7q7GWF14bLwPq1W8xSZacDdHQ940EhLJ/LLkOho2K6ikhKlfbOP
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Xad40hXYlKAP97Y0XfEAJkxukn9MI3i9GzdkP5YZpw7m6Hd7+KDeJvSY8Q4EDsJH8ws+osXi+V
 Zg51uPCmAI8d+/gD71lpZ0iUAF6FV4l3XPLVVwyFr2ZtxXRdH2DMlSNI2SQBiS9APcy9llBLSB
 I0nn/zCaaqMS8JQE2WqYTsWv6bSu0wrFkQivD3cl3ggQJ2CgG5lcLNJPFYEyAONTzAVI+H9Xen
 aMbLx9G5GC5+YUUM5NaE7qzCw4DUdaQ5DaWFuZZVuxSbOPEYHCypWfdG6Y2mBkPvyWK6mdZ7PZ
 rLNFJZsdziTo7wfFIiR5cmOw
X-SBRS: 5.1
X-MesageID: 59370631
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/8Ey5q8RxsQcCVQEY+dQDrUDenmTJUtcMsCJ2f8bNWPcYEJGY0x3z
 2pKWDuGbv/bYTf0eNgjbdix8E0PsZ6EzdAxQQdqrng8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgt9
 PQRn8G6DjsZFYzSt6MtfDheOTFhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0fRqmGO
 ZFAAdZpREznIDJgHwg0M5InwsixqUvWfw958E3A8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSAzRKV/3TqgfXA9Qv2XI8UHful+P9vnEae2GU7DwcfXl+25/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Uz7h2NzazFpR6UHGEeQhZObdUnsIk9QjlC6
 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBTM+RHMuEAFC3+nIgZ8cySLgb9BJALHg27UZBgrM6
 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4ZdN7BJmRtq
 kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JBVd0JiN2dDB0wWirhRdMPS
 BWJ0e+2zMUMVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOhDCyyhlxy/thZ
 sfznSOQ4ZAyU/4PIN2eHbh17FPW7npmmTO7qW7TkXxLLoZylFbKEOxYYTNin8gy7b+eoRW9z
 jqsH5Di9vmra8WnOnO/2ddKdTgidCFnbbir+50/XrPSeWJORTB+Y8I9NJt8IuSJaYwOzbyWl
 px8M2cFoGfCaYrvdV/XNys9Mey3Bv6SbxsTZEQRALph4FB7Ca7H0UvVX8JfkWAP+LMxwPhqY
 eMCfsncUP1DRi6eo2YWbIXnrZwkfxOu3FrcMy2gaTk5XphhWw2WpYO0IlqxrHEDXnitqM8zg
 7y8zQeHE5ANcBtvUZTNY/W1wlLv4XVEwLBuX1HFK8V4cVn39NQ4MDT4i/I6epleKRjKyjaA+
 RyRBBMU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTqtqqu4Z
 OhTw/XtC9E9nQ5H49hmDrJm7aMi/N+z9bVU+RtpQSfQZFOxB7I+fnTfhZtTtrdAz6NysBetX
 h7d4cFTPLiENZ+3EFMVIwZ5PO2P2etNx2vX5PUxZk77+DV27PyMVkALZ0uAjylULb1UNoI5w
 Lh+5J5KulLn0hd6YMybii109niXKi1SWqoqgZgWHYv3h1d50VpFe5HdVnf77Zznhw+g6aX2z
 ut4XJb/uok=
IronPort-HdrOrdr: A9a23:2Fi/C6FVbeipoVA7pLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q
 eTdZUgpGbJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQts5
 uIGJIRNDSfNzRHZL7BkWqFL+o=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370631"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 24/57] tools/debugger/gdbsx: Fix and cleanup makefiles
Date: Mon, 6 Dec 2021 17:02:07 +0000
Message-ID: <20211206170241.13165-25-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

gdbsx/:
  - Make use of subdir facility for the "clean" target.
  - No need to remove the *.a, they aren't in this dir.
  - Avoid calling "distclean" in subdirs as "distclean" targets do only
    call "clean", and the "clean" also runs "clean" in subdirs.
  - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all"
    recipe by forcing make to check for update of "xg/xg_all.a" and
    "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making
    "gdbsx", make will recurse even when both *.a already exist.
  - List target in $(TARGETS).

gdbsx/*/:
  - Fix dependency on *.h.
  - Remove some dead code.
  - List targets in $(TARGETS).
  - Remove "build" target.
  - Cleanup "clean" targets.
  - remove comments about the choice of "ar" instead of "ld"

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/debugger/gdbsx/Makefile    | 20 ++++++++++----------
 tools/debugger/gdbsx/gx/Makefile | 15 +++++++--------
 tools/debugger/gdbsx/xg/Makefile | 25 +++++++------------------
 3 files changed, 24 insertions(+), 36 deletions(-)

diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
index 8d7cd94a31..4aaf427c45 100644
--- a/tools/debugger/gdbsx/Makefile
+++ b/tools/debugger/gdbsx/Makefile
@@ -1,20 +1,20 @@
 XEN_ROOT = $(CURDIR)/../../..
 include ./Rules.mk
 
+SUBDIRS-y += gx
+SUBDIRS-y += xg
+
+TARGETS := gdbsx
+
 .PHONY: all
-all:
-	$(MAKE) -C gx
-	$(MAKE) -C xg
-	$(MAKE) gdbsx
+all: $(TARGETS)
 
 .PHONY: clean
-clean:
-	rm -f xg_all.a gx_all.a gdbsx
-	set -e; for d in xg gx; do $(MAKE) -C $$d clean; done
+clean: subdirs-clean
+	rm -f $(TARGETS)
 
 .PHONY: distclean
 distclean: clean
-	set -e; for d in xg gx; do $(MAKE) -c $$d distclean; done
 
 .PHONY: install
 install: all
@@ -28,7 +28,7 @@ uninstall:
 gdbsx: gx/gx_all.a xg/xg_all.a 
 	$(CC) $(LDFLAGS) -o $@ $^
 
-xg/xg_all.a:
+xg/xg_all.a: FORCE
 	$(MAKE) -C xg
-gx/gx_all.a:
+gx/gx_all.a: FORCE
 	$(MAKE) -C gx
diff --git a/tools/debugger/gdbsx/gx/Makefile b/tools/debugger/gdbsx/gx/Makefile
index 3b8467f799..ff5c8e9e6e 100644
--- a/tools/debugger/gdbsx/gx/Makefile
+++ b/tools/debugger/gdbsx/gx/Makefile
@@ -2,21 +2,20 @@ XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
 GX_OBJS := gx_comm.o gx_main.o gx_utils.o gx_local.o
-GX_HDRS := $(wildcard *.h)
+
+TARGETS := gx_all.a
 
 .PHONY: all
-all: gx_all.a
+all: $(TARGETS)
 
 .PHONY: clean
 clean:
-	rm -rf gx_all.a *.o .*.d
+	rm -f *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
 
-#%.o: %.c $(GX_HDRS) Makefile
-#	$(CC) -c $(CFLAGS) -o $@ $<
-
-gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS)
-	ar cr $@ $(GX_OBJS)        # problem with ld using -m32 
+gx_all.a: $(GX_OBJS) Makefile
+	ar cr $@ $(GX_OBJS)
 
+-include $(DEPS_INCLUDE)
diff --git a/tools/debugger/gdbsx/xg/Makefile b/tools/debugger/gdbsx/xg/Makefile
index acdcddf0d5..a02c7649cf 100644
--- a/tools/debugger/gdbsx/xg/Makefile
+++ b/tools/debugger/gdbsx/xg/Makefile
@@ -1,35 +1,24 @@
 XEN_ROOT = $(CURDIR)/../../../..
 include ../Rules.mk
 
-XG_HDRS := xg_public.h 
 XG_OBJS := xg_main.o 
 
 CFLAGS += -D__XEN_TOOLS__
 CFLAGS += $(CFLAGS_xeninclude)
 
+TARGETS := xg_all.a
 
 .PHONY: all
-all: build
+all: $(TARGETS)
 
-.PHONY: build
-build: xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a $(XG_HDRS) $(XG_OBJS) Makefile
-# build: mk-symlinks xg_all.a
-
-xg_all.a: $(XG_OBJS) Makefile $(XG_HDRS)
-	ar cr $@ $(XG_OBJS)    # problems using -m32 in ld 
-#	$(LD) -b elf32-i386 $(LDFLAGS) -r -o $@ $^
-#	$(CC) -m32 -c -o $@ $^
-
-# xg_main.o: xg_main.c Makefile $(XG_HDRS)
-#$(CC) -c $(CFLAGS) -o $@ $<
-
-# %.o: %.c $(XG_HDRS) Makefile  -- doesn't work as it won't overwrite Rules.mk
-#%.o: %.c       -- doesn't recompile when .c changed
+xg_all.a: $(XG_OBJS) Makefile
+	ar cr $@ $(XG_OBJS)
 
 .PHONY: clean
 clean:
-	rm -rf xen xg_all.a $(XG_OBJS)  .*.d
+	rm -f $(TARGETS) $(XG_OBJS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
+
+-include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239442.415083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS2-0004aW-UU; Mon, 06 Dec 2021 17:06:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239442.415083; Mon, 06 Dec 2021 17:06:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS2-0004aP-QZ; Mon, 06 Dec 2021 17:06:54 +0000
Received: by outflank-mailman (input) for mailman id 239442;
 Mon, 06 Dec 2021 17:06:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOx-0005ta-MS
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:43 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 756262cf-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 756262cf-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810221;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=u/6PZxBQJwWZ+PXJwgzjsbEo629MujlLZMLcLeCujlQ=;
  b=f9RFxzrPYYVtwxxYoVKLRk80zEB2lGWGAMAlbp4Sghbtw7UjqlsD8DAr
   6jeBsH74tMt7mFB9sJWCq/+yOJwcm42p6dlE4vnLOQt+6EkvFXblX2C6N
   9irAP6aopRBufxpnhMWVpi5sRsREw9mGcz7na5cOYSexeh5m6cDHj5cYm
   w=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: DCiuWfY2Y08sKGXPVqAJ6Ok9zf23qVIeQuhnPe0J7NtVc91nyTuJd5YHr4KcFzF5xHa+AhrV90
 xZJVv7Q7ks3qK0NJ9tYEpF9CgUvaS6sJMeoykj1yn46NZ/P21U7dQY8UWFenKYe7XdaZQIxCbU
 EazkXoyPCGPn9d2eKlnHtMjUVFBeR13aO8XePePHADnBIrqdjdIjcY4mHRAyre+zDjva0EhTgf
 goJmQlNC0ShSaCI12gicMoJgJeWQBpAbjqOpnANGrijUa9lJ6nb/8oSy2uYW1kOwcLh2XLEED4
 o4P9nGX9FuqDgbE3qlkDC046
X-SBRS: 5.1
X-MesageID: 59766443
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3t1H3KAYHyA7+BVW/7Lkw5YqxClBgxIJ4kV8jS/XYbTApGx20jJUx
 2UXX2/UO/+CNzehKY93YNvl9RxVuZbdnYc1QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/kQuXxsJy6
 dZ25YGobykQOIj1iKMnTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWhu2JwSRp4yY
 eIVNTlmdCrySiQUAX4mAcIQ28KCglzgJmgwRFW9+vNsvjm7IBZK+LrwNNvYfPSaSMMTmVyXz
 krd5HjwCBweMN2ZyBKG/2iqi+uJmjn0MKoNEJWo+/gsh0ecrkQRAhALUVqwodGil1WzHdlYL
 iQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLd5RqZAW4VCCZMctU8uOc5QDUr0
 hmCmNaBLT1wspWFRHSF7LCWoDiufy8PIgc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdAw/um
 iKJjSsF16gLq+Ay0YCC7Rf9nGf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOjxv67tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj
 KM+VGpsCH5v0JmCMPYfj2GZUZ1CIU3c+TLNDKq8gj1mOMcZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlGgeBxl31knz2MFfgXKihLN5LEPhZ5rp9fbzOzgh0RtvvY8G05D
 f4BXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/LYa+zv5dMDh5UZf5mOp5E6Q8xvg9vrqYr
 xmVBx4DoHKi1CKvFOl/Qi06AF8Zdc0k9ixT0O1FFQvA5kXPlq7ztvpCLMVuIuF8nAGhpNYtJ
 8Q4lwy7KqwnYlz6F/41MfERdaRuK0amgxygJS2gbGRtdpJsXVWRqNTlYhHu5G8FCS/u7Zkyp
 Lip1wX6R5sfRls9UJaKOaz3l17h72IAnO9SXlfTJoUBckvb74U3eTf6ieU6Ip9QJEyblCeaz
 QufHTwRufLJ/90u6NDMiK3d99WpHuJyE1B0BW7e6brqZyDW8nD6md1LUfqSfCCbX2Txof3wa
 eJQxvD6EfsGgFcV7NYsT+c1lfozvoK9qaVbwwJoGGTwQ26qUr4wcGOb2cRvt7FWwuMLswWBR
 U/SqMJRPq+EOZ25HQdJdhYldOmKydodhiLWsaYuOEz/6SJ6oOiHXEFVM0XegSBRNuIoYoYsw
 ONns88K8Q2vzBEtN4/e3CxT8m2NKF0GUrkm6c5GUNO61FJzxwEQe4HYBw/3/IqLOodFPUQdK
 zOJgLbP2uZHzU3YfntvTXXA0IKxX3jVVMymGLPaG2m0pw==
IronPort-HdrOrdr: A9a23:ewE0EqOXModhVMBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766443"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 22/57] tools/console: have one Makefile per program/directory
Date: Mon, 6 Dec 2021 17:02:05 +0000
Message-ID: <20211206170241.13165-23-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Sources of both xenconsoled and xenconsole are already separated into
different directory and don't share anything in common. Having two
different Makefile means it's easier to deal with *FLAGS.

Some common changes:
Rename $(BIN) to $(TARGETS), this will be useful later.
Stop removing *.so *.rpm *.a as they aren't created here.
Use $(OBJS-y) to list objects.
Update $(CFLAGS) for the directory rather than a single object.

daemon:
    Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
    Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
	instead.

client:
    Remove the unused $(LDLIBS_xenconsole)

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore                    |  4 +--
 tools/console/Makefile        | 49 +++-------------------------------
 tools/console/client/Makefile | 39 +++++++++++++++++++++++++++
 tools/console/daemon/Makefile | 50 +++++++++++++++++++++++++++++++++++
 4 files changed, 94 insertions(+), 48 deletions(-)
 create mode 100644 tools/console/client/Makefile
 create mode 100644 tools/console/daemon/Makefile

diff --git a/.gitignore b/.gitignore
index b39b996718..c31fa9b841 100644
--- a/.gitignore
+++ b/.gitignore
@@ -159,8 +159,8 @@ tools/libs/util/libxenutil.map
 tools/libs/vchan/headers.chk
 tools/libs/vchan/libxenvchan.map
 tools/libs/vchan/xenvchan.pc
-tools/console/xenconsole
-tools/console/xenconsoled
+tools/console/client/xenconsole
+tools/console/daemon/xenconsoled
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
 tools/debugger/gdb/gdb-6.2.1/*
 tools/debugger/gdb/gdb-6.2.1.tar.bz2
diff --git a/tools/console/Makefile b/tools/console/Makefile
index 207c04c9cd..63bd2ac302 100644
--- a/tools/console/Makefile
+++ b/tools/console/Makefile
@@ -1,50 +1,7 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-CFLAGS  += -Werror
+SUBDIRS-y := daemon client
 
-CFLAGS  += $(CFLAGS_libxenctrl)
-CFLAGS  += $(CFLAGS_libxenstore)
-LDLIBS += $(LDLIBS_libxenctrl)
-LDLIBS += $(LDLIBS_libxenstore)
-LDLIBS += $(SOCKET_LIBS)
-
-LDLIBS_xenconsoled += $(UTIL_LIBS)
-LDLIBS_xenconsoled += -lrt
-CONSOLE_CFLAGS-$(CONFIG_ARM) = -DCONFIG_ARM
-
-BIN      = xenconsoled xenconsole
-
-.PHONY: all
-all: $(BIN)
-
-.PHONY: clean
-clean:
-	$(RM) *.a *.so *.o *.rpm $(BIN) $(DEPS_RM)
-	$(RM) client/*.o daemon/*.o
-
-.PHONY: distclean
-distclean: clean
-
-daemon/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
-daemon/io.o: CFLAGS += $(CFLAGS_libxenevtchn) $(CFLAGS_libxengnttab) $(CFLAGS_libxenforeignmemory) $(CONSOLE_CFLAGS-y)
-xenconsoled: $(patsubst %.c,%.o,$(wildcard daemon/*.c))
-	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenforeignmemory) $(LDLIBS_xenconsoled) $(APPEND_LDFLAGS)
-
-client/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
-xenconsole: $(patsubst %.c,%.o,$(wildcard client/*.c))
-	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_xenconsole) $(APPEND_LDFLAGS)
-
-.PHONY: install
-install: $(BIN)
-	$(INSTALL_DIR) $(DESTDIR)/$(sbindir)
-	$(INSTALL_PROG) xenconsoled $(DESTDIR)/$(sbindir)
-	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	$(INSTALL_PROG) xenconsole $(DESTDIR)$(LIBEXEC_BIN)
-
-.PHONY: uninstall
-uninstall:
-	rm -f $(DESTDIR)$(LIBEXEC_BIN)/xenconsole
-	rm -f $(DESTDIR)$(sbindir)/xenconsoled
-
--include $(DEPS_INCLUDE)
+.PHONY: all clean install distclean uninstall
+all clean install distclean uninstall: %: subdirs-%
diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
new file mode 100644
index 0000000000..44176c6d93
--- /dev/null
+++ b/tools/console/client/Makefile
@@ -0,0 +1,39 @@
+XEN_ROOT=$(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS += -Werror
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenstore)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+LDLIBS += $(LDLIBS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenstore)
+LDLIBS += $(SOCKET_LIBS)
+
+OBJS-y := main.o
+
+TARGETS := xenconsole
+
+.PHONY: all
+all: $(TARGETS)
+
+xenconsole: $(OBJS-y)
+	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(APPEND_LDFLAGS)
+
+.PHONY: install
+install: all
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) xenconsole $(DESTDIR)$(LIBEXEC_BIN)
+
+.PHONY: uninstall
+uninstall:
+	rm -f $(DESTDIR)$(LIBEXEC_BIN)/xenconsole
+
+.PHONY: clean
+clean:
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
+
+.PHONY: distclean
+distclean: clean
+
+-include $(DEPS_INCLUDE)
diff --git a/tools/console/daemon/Makefile b/tools/console/daemon/Makefile
new file mode 100644
index 0000000000..0f004f0b14
--- /dev/null
+++ b/tools/console/daemon/Makefile
@@ -0,0 +1,50 @@
+XEN_ROOT=$(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS += -Werror
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenstore)
+CFLAGS += $(CFLAGS_libxenevtchn)
+CFLAGS += $(CFLAGS_libxengnttab)
+CFLAGS += $(CFLAGS_libxenforeignmemory)
+CFLAGS-$(CONFIG_ARM) += -DCONFIG_ARM
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+LDLIBS += $(LDLIBS_libxenctrl)
+LDLIBS += $(LDLIBS_libxenstore)
+LDLIBS += $(LDLIBS_libxenevtchn)
+LDLIBS += $(LDLIBS_libxengnttab)
+LDLIBS += $(LDLIBS_libxenforeignmemory)
+LDLIBS += $(SOCKET_LIBS)
+LDLIBS += $(UTIL_LIBS)
+LDLIBS += -lrt
+
+OBJS-y := main.o
+OBJS-y += io.o
+OBJS-y += utils.o
+
+TARGETS := xenconsoled
+
+.PHONY: all
+all: $(TARGETS)
+
+xenconsoled: $(OBJS-y)
+	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(APPEND_LDFLAGS)
+
+.PHONY: install
+install: all
+	$(INSTALL_DIR) $(DESTDIR)/$(sbindir)
+	$(INSTALL_PROG) xenconsoled $(DESTDIR)/$(sbindir)
+
+.PHONY: uninstall
+uninstall:
+	rm -f $(DESTDIR)$(sbindir)/xenconsoled
+
+.PHONY: clean
+clean:
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
+
+.PHONY: distclean
+distclean: clean
+
+-include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239443.415094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS4-0004r6-9T; Mon, 06 Dec 2021 17:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239443.415094; Mon, 06 Dec 2021 17:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHS4-0004qz-5g; Mon, 06 Dec 2021 17:06:56 +0000
Received: by outflank-mailman (input) for mailman id 239443;
 Mon, 06 Dec 2021 17:06:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOg-0005ta-M1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:26 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bcafb74-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bcafb74-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810205;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=7aOw8syolA2pTNhK+TaqXfl93M4Y1PlS90vYN+kTCEs=;
  b=ZXBM6mt2KR8XlgTCinH9E4/rzpLzIt+hWK1iktxaj+pxOp+/8jn9chIg
   +gona542ud50hqtV4TZe6DmqpSKCLzTlio5hDQ/W1ZfpMkn44jCx1xtAD
   U0jABKCKXJt8tt+uh88JILsVL/MRx66yv8hdtCPALOhJczHPc1R1MGB1n
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: rQVJznZ5uG9sm+n5Vr8uI41OMqkvi/LSOFE2AFkmUsO58NtDw0w7Ab6eRfrJl+81DSs9hU0C1C
 Y6TxwQ0bK1y1MhkZRtDH/DaWEvC2jn8SLpo1H6ao5P62cqamfqS9JhM2VwHJvAnmZ35CQ9YCdx
 nVFTq91G8HSvLGCWjwQAwxsM/u+Okbu2HjJQ2f4fSIpjjCL8q3yxYUZlxm3B4sfLbD8WAHRrGg
 EBdHDVbSeY85GwKtXY7fLp6mH8Mx5KbOeNsauSRXJa5AZmrHkKmpuuFZaLR8780wsAgR85ITdX
 jDm6V/7RUTMAOfJozAYJ3EHP
X-SBRS: 5.1
X-MesageID: 59766334
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Aapz5qnY0gOW1xt3iF16ZGHo5gxnIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJXzyAM/aOM2OmftxxYYWz/E9Uv5DWnINlSgFrqCwzRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PVpl6KobgcbAvHVwe0bUBAfSjleY7ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeBO
 ZRCMmYHgBLofREQAVsdL5MFl9i4hzr4cwdbsVbEqv9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQ88ywyra805QqzQ8P0RRGQr3uNvxpaUN1Ve9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxQK8
 n23h/TpNwAzqeScT3GUse6MjW2tbH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE/8CRFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTQGY3h/5nzvp5p1QEwZ3Y1RfHNEBz3pBaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZ96kvKxSI6/CK+EBjarXnSXXFXdlM2JTRTPt10BbWB2yf1vU
 XtlWZjE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz8uYdykEW9EO9fWHPXN7hRxPrd/G39r
 oYOX+PXmk43eLCvPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6OLnO56JdU6x/89eyWh1
 ijVZ3K0AWHX3RXvQThmoFgyAF82dZog/389IwI2OlOkhyoqbYq1tf9NfJorZ7g3sudkyKcsH
 fUCfsyBBNVJSyjGpGtBPcWs8tQ6eUT5nx+KMgqkfCM7I8xqSTvW94K2ZQDo7iQPUHa67JNsv
 7262wrHapMfXAA+Xt3OYfeiwgrp73gQke5/RWXSJdxXdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YnRxhUBWjW67qyJBL2xGv7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB748cHmL2c5D6v9EyrND4FbkX
 0uO/p9ROKmTOdOjG1kUfVJ3YuOG3PASuz/T8fVqfxmquH4ppOKKARdIIh2BqC1BN78kYooqz
 NAotNMS9wHi2AEhNcyLj3wM+mmBRpDav37Lan3O7FfXtzcW
IronPort-HdrOrdr: A9a23:1zU9FaC39zQ1h83lHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo8f
 xG/c5rrSMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN
 5dmsNFaeEYY2IUsS+D2njbL+od
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766334"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 02/57] tools/configure.ac: Remove left over system_aio
Date: Mon, 6 Dec 2021 17:01:45 +0000
Message-ID: <20211206170241.13165-3-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

system_aio isn't set since 3d4678108a (tools: remove in tree libaio).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/configure.ac | 1 -
 tools/configure    | 2 --
 2 files changed, 3 deletions(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 3ac62626a5..5a4fb9022d 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -402,7 +402,6 @@ AC_CHECK_LIB([lzo2], [lzo1x_decompress], [zlib="$zlib -DHAVE_LZO1X -llzo2"])
 PKG_CHECK_MODULES([libzstd], [libzstd],
     [zlib="$zlib -DHAVE_ZSTD $libzstd_CFLAGS $libzstd_LIBS"], [true])
 AC_SUBST(zlib)
-AC_SUBST(system_aio)
 AX_CHECK_EXTFS
 AX_CHECK_PTHREAD
 AX_CHECK_PTYFUNCS
diff --git a/tools/configure b/tools/configure
index 21e3a83795..8e4a59c2cb 100755
--- a/tools/configure
+++ b/tools/configure
@@ -641,7 +641,6 @@ PTHREAD_LIBS
 PTHREAD_LDFLAGS
 PTHREAD_CFLAGS
 EXTFS_LIBS
-system_aio
 zlib
 libzstd_LIBS
 libzstd_CFLAGS
@@ -8772,7 +8771,6 @@ $as_echo "yes" >&6; }
 fi
 
 
-
 ac_fn_c_check_header_mongrel "$LINENO" "ext2fs/ext2fs.h" "ac_cv_header_ext2fs_ext2fs_h" "$ac_includes_default"
 if test "x$ac_cv_header_ext2fs_ext2fs_h" = xyes; then :
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239449.415116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSI-0005of-1J; Mon, 06 Dec 2021 17:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239449.415116; Mon, 06 Dec 2021 17:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSH-0005oW-TK; Mon, 06 Dec 2021 17:07:09 +0000
Received: by outflank-mailman (input) for mailman id 239449;
 Mon, 06 Dec 2021 17:07:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPL-0005ti-G6
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8461dcdc-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8461dcdc-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810246;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=SYJTJIKxHEFQcMKNpvz4kHz4LT/E8ZyffBaU/35UM+o=;
  b=SZpZIlN/a17Ht6GaXvXX8/7SyBd3Pp2dTxLfhp7yRWDcgEMHZ9E4rZRi
   7rTWRxC+oRNoPbUoDjMaJbXUz/Dd1Fw+EB2JyRBGsbAICc9S/ptJ609+o
   molDybIW1BCryY0UNuuxS50EkR4doQccRDH/wQyhfotnzr7biwB1Mfw+6
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: VCdhQLflCCIZyRDomZsky6KSMXnle3oGtqd3o5o8N7VxYOorQ/qkUU4iNNAzQcdffkS21AIJlM
 gjy7VQ1ZNkfstePOqeQz9jCWEGCmsmIgPuQxysZk6bxRWtWiOC/eUdbHseV8hXQs6u+kM7oren
 PuEWLFXSw/BosuoSlvze/WY/Ghk4McC4ekghT9eaICt8yd2pKILl2RtEIr8+AJV6myEICKQOrl
 7l+4ouN8vfjx09W+Ht9XEoR+i4Bjjf5XXCh9PH/Hrxs5ic4iTxyUC+YU2ioEU+Z6jsoEAbqPq3
 AHXvs4FrJVgDM+kwDSDm51q8
X-SBRS: 5.1
X-MesageID: 59387870
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:otoXGKiBxFDXDfpOgfhSP/JAX161khcKZh0ujC45NGQN5FlHY01je
 htvXGDSOanZN2qme4xyYI+z8UpSvMLczYc3QQVsryA8E38b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /136cCxYg0DM5HDhbw6dTgbThByIY9/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPP
 JpGOWU3BPjGSxIICGg0N6gFpc6HljrQcjNGrnCL9INitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAw4YHMySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1jYVXcZQFOsrrhmA0KPO7y6WA2EFSnhKb9lOiSMtbWV0j
 BnTxYqvXGEx9u3OIZ6AyluKhQnuZSk+J0UPWSAZFSwjwpq+kY0vrCuaG76PD5WJptHyHDjxx
 RWDoy4/m6gfgKY36kmrwbzUq2ny/8aUF2bZ8i2SBzv4tV0hOOZJcqTxsQCDhcusOrp1WbVoU
 JIsv8GFpN4DApiW/MBmaLVcRer5jxpp3dC1vLKOI3XD32n0k5JAVdoJiN2bGKuPGpxeEdMOS
 BWM0T69HLcJYBOXgVZfOupd8fgCw6n6DsjCXfvJdNdIaZUZXFbZp3ExPx/NhTqzzxhEfUQD1
 XGzK5zE4ZEyU/sP8dZLb71Fje9DKt4Wmws/uqwXPzz4iOHDNRZ5uJ8OMUeUb/BR0U93iF69z
 jqrDOPTk083eLSnOkH/qNdPRXhXfSlTLc2n8KR/K7/cSjeK7Ul8Upc9N5t6INc790mU/8+Vl
 kyAtrhwlACi2CaZcFrSMRiOqtrHBP5CkJ7yBgR0VX7A5pTpSdv0hEvGX5doL7Qh6sJ5yvt4E
 6sMd8maW6wdQTXb4TUNK5L6qdU6JhisgAuPOQujYSQ+IME8F1CYpIe8c1u97jQKAwq2qdA6/
 ++q2DTETMdRXA9lFsvXNq6ilgvjoXgHletudELUOd0PKl70+Y1nJnWp3P86Ks0BMzvZwT6e2
 1rECBsUv7CV8YQ07MPIleaPqILwS7lyGU9THm/667eqNHaFojr/kNEYCOvRJGLTTmL5/qmmd
 N559fCkPa1VhktOvqp9D61vkfA06ezwquII1Q9jBnjKMQimU+syPnmc0MBTnaRR3bsF6xCuU
 0eC99QGa7WEPMTpTAwYKAY/N7nR0PgVnn/Z7OgvIVW87yhypeLVXUJXNhiKqSpcMLoqb991n
 bZ/4JYbu16llx4nEtealSQFpW2DI0sJX7gjqpxHUpTgjRAmyw0abJHRYsMsDEpjtzmY3pEWH
 wKp
IronPort-HdrOrdr: A9a23:2jT6tqsanajhhILcCJNg4BUy7skDfNV00zEX/kB9WHVpmszxra
 +TdZMgpHrJYVcqKRYdcL+7WZVoLUmwyXcX2/hyAV7BZmnbUQKTRekIh7cKqweQfxEWndQy6U
 4PScRD4aXLfDtHsfo=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387870"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: [XEN PATCH 26/57] tools/firmware/hvmloader: rework Makefile
Date: Mon, 6 Dec 2021 17:02:09 +0000
Message-ID: <20211206170241.13165-27-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Setup proper dependencies with libacpi so we don't need to run "make
hvmloader" in the "all" target. ("build.o" new prerequisite isn't
exactly proper but a side effect of building the $(DSDT_FILES) is to
generate the "ssdt_*.h" needed by "build.o".)

Make use if "-iquote" instead of a plain "-I".

For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
to "mv", in case the target already exist.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/firmware/hvmloader/Makefile | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile
index b754220839..fc20932110 100644
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -60,8 +60,7 @@ ROMS += $(ROMBIOS_ROM) $(STDVGA_ROM) $(CIRRUSVGA_ROM)
 endif
 
 .PHONY: all
-all: acpi
-	$(MAKE) hvmloader
+all: hvmloader
 
 .PHONY: acpi
 acpi:
@@ -73,12 +72,15 @@ smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\""
 ACPI_PATH = ../../libacpi
 DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
 ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES)) build.o static_tables.o
-$(ACPI_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
+$(ACPI_OBJS): CFLAGS += -iquote . -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
 CFLAGS += -I$(ACPI_PATH)
 vpath build.c $(ACPI_PATH)
 vpath static_tables.c $(ACPI_PATH)
 OBJS += $(ACPI_OBJS)
 
+$(DSDT_FILES): acpi
+build.o: $(DSDT_FILES)
+
 hvmloader: $(OBJS) hvmloader.lds
 	$(LD) $(LDFLAGS_DIRECT) -N -T hvmloader.lds -o $@ $(OBJS)
 
@@ -87,21 +89,21 @@ roms.inc: $(ROMS)
 
 ifneq ($(ROMBIOS_ROM),)
 	echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new
-	sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
 
 ifneq ($(STDVGA_ROM),)
 	echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
-	sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
 ifneq ($(CIRRUSVGA_ROM),)
 	echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new
-	sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
+	$(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new
 	echo "#endif" >> $@.new
 endif
-	mv $@.new $@
+	mv -f $@.new $@
 
 .PHONY: clean
 clean:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239450.415121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSI-0005sf-Cs; Mon, 06 Dec 2021 17:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239450.415121; Mon, 06 Dec 2021 17:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSI-0005rg-5t; Mon, 06 Dec 2021 17:07:10 +0000
Received: by outflank-mailman (input) for mailman id 239450;
 Mon, 06 Dec 2021 17:07:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOh-0005ta-MC
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:27 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d4fd33b-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d4fd33b-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810206;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=6zpFISsadUpEdibZxGtzCtaH4deu+VADURLBhws2jBc=;
  b=SeHQwDa0XVc4UsQOU/i5z1+hx6LezT6sbrmFJESuc6gQk4IAyNAN53bo
   LFV6ywxXOo7NCAoGYDTSkw13SHDe+Z3wsQw9ge0NHJATs3HdYE+1tvgH+
   RAiJrVfHeMdMfqAyx2CFv49KoFQDUlHmE6yBnVg4LCkfTFu/lZgl5Ctu7
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PcBNEWStTXnPQRTOStgLiSO+Hkw4w2ZGUiqgPSko1EwZGkhTwxQe6XtTMNgvx0tP/m7s8MwshY
 OiV9P7E8pjM3FCO/7WdzjhbSFuvkaIiFeeFe6JGZ16oiQjg/0LBxxKwV0/7q/LV+CTwkYe8XLb
 +I9W9kbIwWKQ31JY540+AFef3ZLiYhiBzHlgMuXlqXM5EcHnF9b7XxtXiGUcs0mx8r/HLyvTh8
 wnILDiLU1+2LDufcFD04FBMNVcPdO1XnDdgvpolmerxkyW4sCGlVWhR7GeW0gXf4VAhAhBoE3I
 nhIWzsygH60kyi8WIwaWM4QL
X-SBRS: 5.1
X-MesageID: 59766356
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gSNHa6kv82GQ8P1r6eCQ3Svo5gxxIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcWmCEOPeKZ2WmfowlboXi/EoOvJXTx9JgTQJqqStmFiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 IsWupagcBUIAor3srQ6Ux9UQhtcGpQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeBO
 ZRCNGQHgBLoODdRZwwmDcIEgeK6oFClSxJV63e7uv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z7DQsdL8e30iee/zSngeqntSLkWqoCGbug7PlojVaPgGsJB3U+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yFaNuAIcXNxBVfU38giXxoLb5g+YAi4PSTspVTA9nJZoH3pwj
 AbPxo63Q2w02FGIdZ6D3unPojmiADo0EUg5T38jTQ0JsuPBh7hm23ojUe1fOKKyi9T0HxT5z
 DaLsDUyit0vsCIb60mo1QuZ2mzx//AlWiZwv1yKBTz9smuVcab8P9TwgWU3+8qsO2pworOpm
 HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8R4n9hO0yT6FWy13N2YDB0zWirjUWW2C
 HI/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvL1/YpnAzPxTOgDCFfK0QfUcXY
 83znSGEVylyNEia5GDuG7d1PUEDmEjSOl8/tbiklk/6gNJylVaeSKsfMUvmUwzKxPjsnekhy
 P4Gb5Hi40wGCIXWO3CLmaZOfQFiBSVqXvje9p0IHtNv1yI7QQnN/deKmuh/E2Gk9owI/tr1E
 oaVBhUFlQGh3CKfcm1nqBlLMdvSYHq2llpjVQREALpi8yNzCWp2xKtAJZYxY5c98+lvkax9Q
 /UfIp3SCfVTUDXXvT8aaMCl/oBlcR2qgyOIPjakP2djL8IxGVSR94+2ZBbr+QkPEjGz6Zk0r
 Yq/216JWpEEXQljUprbMar901OrsHEBs+tuRE+UcMJLcUDh/dEyeSz8h/M6Oe8WLhDHymfI3
 gqaG05A9+LMv5U04J/CgqXd99WlFO53H0x7GWjH7OnpaXmGrzT7mYIZCbSGZzHQUm/w6Z6OX
 +QNwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 0/TqNlXPbKFZJHsHFILfVd3a+2C0bcfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s6JwM9giyqhs2KdLX3Clb+lOFImEET6h65IoRB5Xmi1Zzx1xPCXAG5vQaPH1bhw1wD3QX
IronPort-HdrOrdr: A9a23:9Lw3I62aXwsciwjlYF5alwqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766356"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 08/57] libs/light: Remove non-existing CFLAGS_libxl.o var
Date: Mon, 6 Dec 2021 17:01:51 +0000
Message-ID: <20211206170241.13165-9-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This var was originally $(CFLAGS_$*.o), and probably was copied from
the generic %.o:%.c rules.

Nothing sets CFLAGS_libxl.o, so remove it.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/light/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 194bc5f268..975413ade8 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -200,7 +200,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	touch $@
 
 _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
-	$(CC) $(CPPFLAGS) $(CFLAGS) $(CFLAGS_libxl.o) -c -E $< $(APPEND_CFLAGS) \
+	$(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \
 		-DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
 		>$@.new
 	mv -f $@.new $@
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239451.415125 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSI-0005yj-R0; Mon, 06 Dec 2021 17:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239451.415125; Mon, 06 Dec 2021 17:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSI-0005xV-Iy; Mon, 06 Dec 2021 17:07:10 +0000
Received: by outflank-mailman (input) for mailman id 239451;
 Mon, 06 Dec 2021 17:07:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPD-0005ti-Ht
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:59 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8036e85b-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8036e85b-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810237;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=dj/c4lZoChrbctTMjaQaIy2bS8KFSLyGQmK8KBYSLbU=;
  b=K4NhiaaUXXvl7nDrfbjCeTpp+X3PcqLQRUXFF78E765mDlFSpGMqhWwq
   HkdMvNf0MOg8I3FDO4rOt1mlhXlJypuRO+2Y5qAAMMrfjaX/nLf7tikBR
   8rb8ift+mUXCQlw+Sd7fvJItE0/w8LwOzaHindzUZi2mgZGAC9GF2dOxp
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: KaZPQnglizzoDd4Bpo4yhDDtljZTC28JsQTJSgHbvz6kwXgzGRWLJ0SP51Tjm4WvvtE+Ww9n3X
 bdwmUISl7ck8k8cbPgeWcvyqZvZLebj7Z0v3oOpHD2zNoCSJr75Ar25J1bm1ushuqRb940YkFA
 MRqKfypBtaUWWbZA1NP0BQzEnKkR92Rv/lH2u2VY8LAozY7jyFYZnFYthXEmY0fFvNBD168iuK
 2AqKlaE6peajvgagSUYMyXkYJNuLaonR9Xg4oC+G4olt3Y2mYOEKhxyrGzuTUt2QAw/OcJrRcb
 c8rK3IXkvM76s2MOrUBIQpgG
X-SBRS: 5.1
X-MesageID: 59766494
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LkCESKgMl2n5C3b+KNANPQmGX161iRcKZh0ujC45NGQN5FlHY01je
 htvXWjSPKnYYzenfNxyPo21/UlQvMLdyIBiHgdsriw1QSIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1ts7uzTT5yNZfcs+pGWRNmEhsmBfZ/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPO
 JRHNWszBPjGSx5EHAYaOJAYoMaXoCTebDJ/rAiNipNitgA/yyQuieOwYbI5YOeiRNpXtlaVo
 Hrc+Gb0CQ1cM8aQoRKa9lq8i+mJmjn0MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN80iMosag18l3tVtTnVge0iHGBtx8YHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSIC9
 lmunNfQXjdVoJabEniXyLau9QvpAH1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm
 G7T8nVn71kHpYtSjvjgowib6965jsGRFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5
 yhsdyRzAYkz4XCxeM6lHbxl8FKBva/t3NjgbbhHRcNJG9OFoSHLQGyoyGsiTHqFyPosdz7ze
 1P0sghM/pJVN3bCRfYpONLuUZV3l/K+SoSNuhXogjxmOMIZmOivpn4GWKJt9zq1zBhEfV8XZ
 /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOY7N04RF3EnCPje8ooPHgJ1ClE9Qz9J5j646e5JRrGJaIwJzLqVp
 S/kBRcDoLc97FWeQTi3hrlYQOuHdf5CQbgTZ0TA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:Kwg196mntGwb9VibjlMtLfNmkObpDfIm3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7Qr5OUtQ/uxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVybygc378
 ldmsZFZOEYdWIK7vrH3A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766494"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 31/57] tools/libfsimage: Cleanup makefiles
Date: Mon, 6 Dec 2021 17:02:14 +0000
Message-ID: <20211206170241.13165-32-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove the need for "fs-*" targets by creating a "common.mk" which
have flags that are common to libfsimage/common/ and the other
libfsimages/*/ directories.

In common.mk, make $(PIC_OBJS) a recursively expanded variable so it
doesn't matter where $(LIB_SRCS-y) is defined, and remove the extra
$(PIC_OBJS) from libfsimage/common/Makefile.

Use a $(TARGETS) variable to list things to be built. And $(TARGETS)
can be use in the clean target in common.mk.

iso9660/:
    Remove the explicit dependency between fsys_iso9660.c and
    iso9660.h, this is handled automaticaly by the .*.d dependency files,
    and iso9660.h already exist.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libfsimage/Rules.mk            | 26 ++++++++------------------
 tools/libfsimage/common.mk           | 11 +++++++++++
 tools/libfsimage/common/Makefile     | 11 +++--------
 tools/libfsimage/ext2fs-lib/Makefile |  9 ---------
 tools/libfsimage/ext2fs/Makefile     |  9 ---------
 tools/libfsimage/fat/Makefile        |  9 ---------
 tools/libfsimage/iso9660/Makefile    | 11 -----------
 tools/libfsimage/reiserfs/Makefile   |  9 ---------
 tools/libfsimage/ufs/Makefile        |  9 ---------
 tools/libfsimage/xfs/Makefile        |  9 ---------
 tools/libfsimage/zfs/Makefile        |  9 ---------
 11 files changed, 22 insertions(+), 100 deletions(-)
 create mode 100644 tools/libfsimage/common.mk

diff --git a/tools/libfsimage/Rules.mk b/tools/libfsimage/Rules.mk
index bb6d42abb4..cf37d6cb0d 100644
--- a/tools/libfsimage/Rules.mk
+++ b/tools/libfsimage/Rules.mk
@@ -1,25 +1,18 @@
-include $(XEN_ROOT)/tools/Rules.mk
-
-CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
-CFLAGS += -Werror -D_GNU_SOURCE
-LDFLAGS += -L../common/
-
-PIC_OBJS := $(patsubst %.c,%.opic,$(LIB_SRCS-y))
-
-FSDIR = $(libdir)/xenfsimage
+include $(XEN_ROOT)/tools/libfsimage/common.mk
 
 FSLIB = fsimage.so
+TARGETS += $(FSLIB)
 
-.PHONY: fs-all
-fs-all: $(FSLIB)
+.PHONY: all
+all: $(TARGETS)
 
-.PHONY: fs-install
-fs-install: fs-all
+.PHONY: install
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(FSDIR)/$(FS)
 	$(INSTALL_PROG) $(FSLIB) $(DESTDIR)$(FSDIR)/$(FS)
 
-.PHONY: fs-uninstall
-fs-uninstall:
+.PHONY: uninstall
+uninstall:
 	rm -f $(addprefix $(DESTDIR)$(FSDIR)/$(FS)/, $(FSLIB))
 	if [ -d $(DESTDIR)$(FSDIR)/$(FS) ]; then \
 		rmdir $(DESTDIR)$(FSDIR)/$(FS); \
@@ -28,7 +21,4 @@ fs-uninstall:
 $(FSLIB): $(PIC_OBJS)
 	$(CC) $(LDFLAGS) $(SHLIB_LDFLAGS) -o $@ $^ -lxenfsimage $(FS_LIBDEPS) $(APPEND_LDFLAGS)
 
-clean distclean::
-	rm -f $(PIC_OBJS) $(FSLIB) $(DEPS_RM)
-
 -include $(DEPS_INCLUDE)
diff --git a/tools/libfsimage/common.mk b/tools/libfsimage/common.mk
new file mode 100644
index 0000000000..77bc957f27
--- /dev/null
+++ b/tools/libfsimage/common.mk
@@ -0,0 +1,11 @@
+include $(XEN_ROOT)/tools/Rules.mk
+
+FSDIR := $(libdir)/xenfsimage
+CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
+CFLAGS += -Werror -D_GNU_SOURCE
+LDFLAGS += -L../common/
+
+PIC_OBJS = $(patsubst %.c,%.opic,$(LIB_SRCS-y))
+
+clean distclean::
+	rm -f $(PIC_OBJS) $(TARGETS) $(DEPS_RM)
diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
index 24bc90e73e..bcda86d754 100644
--- a/tools/libfsimage/common/Makefile
+++ b/tools/libfsimage/common/Makefile
@@ -1,5 +1,5 @@
 XEN_ROOT = $(CURDIR)/../../..
-include $(XEN_ROOT)/tools/libfsimage/Rules.mk
+include $(XEN_ROOT)/tools/libfsimage/common.mk
 
 MAJOR = 4.16
 MINOR = 0
@@ -13,12 +13,10 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
 
 LIB_SRCS-y = fsimage.c fsimage_plugin.c fsimage_grub.c
 
-PIC_OBJS := $(patsubst %.c,%.opic,$(LIB_SRCS-y))
-
-LIB = libxenfsimage.so libxenfsimage.so.$(MAJOR) libxenfsimage.so.$(MAJOR).$(MINOR)
+TARGETS = libxenfsimage.so libxenfsimage.so.$(MAJOR) libxenfsimage.so.$(MAJOR).$(MINOR)
 
 .PHONY: all
-all: $(LIB)
+all: $(TARGETS)
 
 .PHONY: install
 install: all
@@ -40,9 +38,6 @@ uninstall:
 	rm -f $(DESTDIR)$(libdir)/libxenfsimage.so.$(MAJOR)
 	rm -f $(DESTDIR)$(libdir)/libxenfsimage.so.$(MAJOR).$(MINOR)
 
-clean distclean::
-	rm -f $(LIB)
-
 libxenfsimage.so: libxenfsimage.so.$(MAJOR)
 	ln -sf $< $@
 libxenfsimage.so.$(MAJOR): libxenfsimage.so.$(MAJOR).$(MINOR)
diff --git a/tools/libfsimage/ext2fs-lib/Makefile b/tools/libfsimage/ext2fs-lib/Makefile
index 431a79068e..b9b560df75 100644
--- a/tools/libfsimage/ext2fs-lib/Makefile
+++ b/tools/libfsimage/ext2fs-lib/Makefile
@@ -9,13 +9,4 @@ FS_LIBDEPS = $(EXTFS_LIBS)
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/ext2fs/Makefile b/tools/libfsimage/ext2fs/Makefile
index c62ae359ac..fe01f98148 100644
--- a/tools/libfsimage/ext2fs/Makefile
+++ b/tools/libfsimage/ext2fs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_ext2fs.c
 
 FS = ext2fs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/fat/Makefile b/tools/libfsimage/fat/Makefile
index 7ee5e7588d..58bcc0751d 100644
--- a/tools/libfsimage/fat/Makefile
+++ b/tools/libfsimage/fat/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_fat.c
 
 FS = fat
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/iso9660/Makefile b/tools/libfsimage/iso9660/Makefile
index bc86baf2c0..acf3164046 100644
--- a/tools/libfsimage/iso9660/Makefile
+++ b/tools/libfsimage/iso9660/Makefile
@@ -4,15 +4,4 @@ LIB_SRCS-y = fsys_iso9660.c
 
 FS = iso9660
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
-fsys_iso9660.c: iso9660.h
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/reiserfs/Makefile b/tools/libfsimage/reiserfs/Makefile
index 5acfedf25e..42b751e007 100644
--- a/tools/libfsimage/reiserfs/Makefile
+++ b/tools/libfsimage/reiserfs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_reiserfs.c
 
 FS = reiserfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/ufs/Makefile b/tools/libfsimage/ufs/Makefile
index f32b9178bd..cca4f0a588 100644
--- a/tools/libfsimage/ufs/Makefile
+++ b/tools/libfsimage/ufs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_ufs.c
 
 FS = ufs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/xfs/Makefile b/tools/libfsimage/xfs/Makefile
index 54eeb6e35e..ebac7baf14 100644
--- a/tools/libfsimage/xfs/Makefile
+++ b/tools/libfsimage/xfs/Makefile
@@ -4,13 +4,4 @@ LIB_SRCS-y = fsys_xfs.c
 
 FS = xfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
diff --git a/tools/libfsimage/zfs/Makefile b/tools/libfsimage/zfs/Makefile
index 084e5ec08d..434a9c3580 100644
--- a/tools/libfsimage/zfs/Makefile
+++ b/tools/libfsimage/zfs/Makefile
@@ -28,13 +28,4 @@ LIB_SRCS-y = zfs_lzjb.c zfs_sha256.c zfs_fletcher.c fsi_zfs.c fsys_zfs.c
 
 FS = zfs
 
-.PHONY: all
-all: fs-all
-
-.PHONY: install
-install: fs-install
-
-.PHONY: uninstall
-uninstall: fs-uninstall
-
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239455.415149 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSL-0006uM-HX; Mon, 06 Dec 2021 17:07:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239455.415149; Mon, 06 Dec 2021 17:07:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSL-0006uB-CS; Mon, 06 Dec 2021 17:07:13 +0000
Received: by outflank-mailman (input) for mailman id 239455;
 Mon, 06 Dec 2021 17:07:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPw-0005ta-LZ
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ade9877-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ade9877-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810282;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=EZdSsjGi/UmXxIGTmBZueTfn63DyjUZHifcM4599pLk=;
  b=Gp4e483wY3MOy1vbJgAlzXd8J+PI6wdz3V9toqSpuuLD422cc0SHdCGY
   8oumqsEmr59EYSQba2+58bcum7Ankx/KHuCatp/CC60jIu710+eAM33tD
   zQSbhuJkgLn3O3YrPi9ohuepS5bmFK0iyoo3q6q4Puyv6GCiFGkEPd8Up
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: BGEtRBNmU1ClXNirFlNE0N5aOIfsaLHkc1Ick+0Tbt5xZEZcFcTkg/dIHu4C2HI3BqUDPPLD26
 Jxxf2m18eLRYSrgN2FUS7vbC7zCkP4aBwYU+bHStq3XkiMW/gypfctJpxweymeh8MItr2LiDHh
 VWNPLcVvR+57nscZNZJI/5QUB4xGH9ofsKM1CP6mcejBXYthvLFAZITpB2kmzmguSwaS0eHsPl
 gjZtEUTQu9Re/a3vdYuzk7t1DINSUL7CaEj3oviLEL92GgrqeE6GLVHJC3Y0OylJybEU4uAEAi
 NN8/A4QmF2KSqAekhESBji17
X-SBRS: 5.1
X-MesageID: 59370749
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:N7stm6uA8bt9lpc8pybJL8Fe9ufnVMFZMUV32f8akzHdYApBsoF/q
 tZmKWGCa66LZWGhLd4lb4ux9E5XvJTXn4VqQVA5qCkzEi8b+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpluaKbeCsOeff3pN9NVDh3HQA9HbBHweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 pFGMWUzPXwsZTVpa1IOGckno9uTxXLaWGwB9WytlYsotj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKgoTMcGSzXyZ8nOmj/LLgQv2XplXEKy/8LhtmlL77m4cEhoNTnOgvOK0zEW5Xrp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmEzLbU5ACIQHAJVDdbZPQpscY3QXoh0
 Vrht9L2BxR/vbuNU3Wf+7yI6zSoNkAowXQqPHFeC1Ffup+6/d913kmnostf/LCdguPeKB3Xh
 GqxkBNugJQ8g+9I97i6xAWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9jAEATY1
 JQQs43Htb1VU8nR/MCYaLxVROnB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj
 SbuVeJtCH17YSLCgUxfOdvZ5yEWIU7IT46Nuhf8NIUmX3SJXFXblByCnGbJt4wXrGAikLskJ
 bCQetu2AHARBMxPlWTtF7hHgOJxnH5hlQs/oKwXKTz9i9Jyg1bPFt843KamNLhlvMtoXi2Lm
 zqgCyd640oGC7CvCsUm2YUSMUoLPRAG6WPe8KRqmhq4ClM+QgkJUqaJqZt4ItANt/kFx4/go
 yDmMmcFmQWXuJEyAVjTApyVQOi0BsgXQLNSFXFEAGtELFB/O9vyt/lGKMNsFVTlncQ6pcNJo
 zA+U53oKpxypv7voVzxtLHx895vcgqFnwWLM3b3aTQzZcc4FQfI5sXlbk3k8yxXVni7ss43o
 ruB0ALHQMVcG1Q+XZiOMP//nUmsuXU9mf5pWxeaKNdkZ0ixopNhLDb8j6FrLphUewnD3DaTy
 y2fHQwc+bvWu4Yw/dSQ3fKEoo6lHvFQBE1fG2WHv7+6OTODpjiowJNaUfbOdjfYDTum9KKnb
 ORT7vf9LPxYwwoa79siS+5mlPts6cHuqrlWyhVfME/KN1n7WKl9JnSm3NVUsvEfzLFupgbrC
 FmE/cNXOOvVNZq9QkIRPgcscs+KyeoQxmvJ9f0wLUj3uH138b6AXRkANhWAknUAfr58MYdjy
 uY9os8GrQe4j0NyYNqBiylV8UWKL2ABDPp75s1LXtezh1p50ExGbLzdFjTyscOGZNh7O0U3J
 iOZ2fjZjLNGy0ueK3c+GBAhBwaGaUjibPyS8GI/Gg==
IronPort-HdrOrdr: A9a23:ejS48698lX7bzHjNuZpuk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370749"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH 54/57] tools/libs: create Makefile.common to be used by stubdom build system
Date: Mon, 6 Dec 2021 17:02:37 +0000
Message-ID: <20211206170241.13165-55-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This new "Makefile.common" is intended to be used by both tools/ and
stubdom/ build system without stubdom needed to use tools/ build
system.

It should contain the necessary list of objects and CFLAGS needed to
build a static library.

Change stubdom/ to check Makefile.common, for the linkfarm.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/Makefile                         |  2 +-
 tools/libs/call/Makefile                 |  7 +-
 tools/libs/call/Makefile.common          |  6 ++
 tools/libs/ctrl/Makefile                 | 45 +-----------
 tools/libs/ctrl/Makefile.common          | 44 ++++++++++++
 tools/libs/devicemodel/Makefile          |  7 +-
 tools/libs/devicemodel/Makefile.common   |  6 ++
 tools/libs/evtchn/Makefile               |  7 +-
 tools/libs/evtchn/Makefile.common        |  6 ++
 tools/libs/foreignmemory/Makefile        |  7 +-
 tools/libs/foreignmemory/Makefile.common |  6 ++
 tools/libs/gnttab/Makefile               |  9 +--
 tools/libs/gnttab/Makefile.common        |  8 +++
 tools/libs/guest/Makefile                | 90 +-----------------------
 tools/libs/guest/Makefile.common         | 84 ++++++++++++++++++++++
 tools/libs/toolcore/Makefile             |  8 +--
 tools/libs/toolcore/Makefile.common      |  9 +++
 tools/libs/toollog/Makefile              |  3 +-
 tools/libs/toollog/Makefile.common       |  2 +
 19 files changed, 182 insertions(+), 174 deletions(-)
 create mode 100644 tools/libs/call/Makefile.common
 create mode 100644 tools/libs/ctrl/Makefile.common
 create mode 100644 tools/libs/devicemodel/Makefile.common
 create mode 100644 tools/libs/evtchn/Makefile.common
 create mode 100644 tools/libs/foreignmemory/Makefile.common
 create mode 100644 tools/libs/gnttab/Makefile.common
 create mode 100644 tools/libs/guest/Makefile.common
 create mode 100644 tools/libs/toolcore/Makefile.common
 create mode 100644 tools/libs/toollog/Makefile.common

diff --git a/stubdom/Makefile b/stubdom/Makefile
index fba4c977ef..fbc63a5063 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -365,7 +365,7 @@ define BUILD_lib
 	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
 	fi
 
- libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile
+ libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile.common
 	$$(do_links)
 endef
 
diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
index e5cb7c937c..103f5ad360 100644
--- a/tools/libs/call/Makefile
+++ b/tools/libs/call/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 3
 
-OBJS-y                 += core.o buffer.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/call/Makefile.common b/tools/libs/call/Makefile.common
new file mode 100644
index 0000000000..85e608f8ad
--- /dev/null
+++ b/tools/libs/call/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o buffer.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index df145ba8ec..7bcac0d4b6 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -1,50 +1,7 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-OBJS-y       += xc_altp2m.o
-OBJS-y       += xc_cpupool.o
-OBJS-y       += xc_domain.o
-OBJS-y       += xc_evtchn.o
-OBJS-y       += xc_gnttab.o
-OBJS-y       += xc_misc.o
-OBJS-y       += xc_flask.o
-OBJS-y       += xc_physdev.o
-OBJS-y       += xc_private.o
-OBJS-y       += xc_csched.o
-OBJS-y       += xc_csched2.o
-OBJS-y       += xc_arinc653.o
-OBJS-y       += xc_rt.o
-OBJS-y       += xc_tbuf.o
-OBJS-y       += xc_pm.o
-OBJS-y       += xc_cpu_hotplug.o
-OBJS-y       += xc_vm_event.o
-OBJS-y       += xc_vmtrace.o
-OBJS-y       += xc_monitor.o
-OBJS-y       += xc_mem_paging.o
-OBJS-y       += xc_mem_access.o
-OBJS-y       += xc_memshr.o
-OBJS-y       += xc_hcall_buf.o
-OBJS-y       += xc_foreign_memory.o
-OBJS-y       += xc_kexec.o
-OBJS-y       += xc_resource.o
-OBJS-$(CONFIG_X86) += xc_psr.o
-OBJS-$(CONFIG_X86) += xc_pagetab.o
-OBJS-$(CONFIG_Linux) += xc_linux.o
-OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
-OBJS-$(CONFIG_SunOS) += xc_solaris.o
-OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
-OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
-OBJS-$(CONFIG_MiniOS) += xc_minios.o
-OBJS-y       += xc_evtchn_compat.o
-OBJS-y       += xc_gnttab_compat.o
-OBJS-y       += xc_devicemodel_compat.o
-
-CFLAGS   += -D__XEN_TOOLS__
-CFLAGS	+= $(PTHREAD_CFLAGS)
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-
-# Needed for posix_fadvise64() in xc_linux.c
-CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
+include Makefile.common
 
 LIBHEADER := xenctrl.h xenctrl_compat.h
 PKG_CONFIG := xencontrol.pc
diff --git a/tools/libs/ctrl/Makefile.common b/tools/libs/ctrl/Makefile.common
new file mode 100644
index 0000000000..0a09c28fd3
--- /dev/null
+++ b/tools/libs/ctrl/Makefile.common
@@ -0,0 +1,44 @@
+OBJS-y       += xc_altp2m.o
+OBJS-y       += xc_cpupool.o
+OBJS-y       += xc_domain.o
+OBJS-y       += xc_evtchn.o
+OBJS-y       += xc_gnttab.o
+OBJS-y       += xc_misc.o
+OBJS-y       += xc_flask.o
+OBJS-y       += xc_physdev.o
+OBJS-y       += xc_private.o
+OBJS-y       += xc_csched.o
+OBJS-y       += xc_csched2.o
+OBJS-y       += xc_arinc653.o
+OBJS-y       += xc_rt.o
+OBJS-y       += xc_tbuf.o
+OBJS-y       += xc_pm.o
+OBJS-y       += xc_cpu_hotplug.o
+OBJS-y       += xc_vm_event.o
+OBJS-y       += xc_vmtrace.o
+OBJS-y       += xc_monitor.o
+OBJS-y       += xc_mem_paging.o
+OBJS-y       += xc_mem_access.o
+OBJS-y       += xc_memshr.o
+OBJS-y       += xc_hcall_buf.o
+OBJS-y       += xc_foreign_memory.o
+OBJS-y       += xc_kexec.o
+OBJS-y       += xc_resource.o
+OBJS-$(CONFIG_X86) += xc_psr.o
+OBJS-$(CONFIG_X86) += xc_pagetab.o
+OBJS-$(CONFIG_Linux) += xc_linux.o
+OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
+OBJS-$(CONFIG_SunOS) += xc_solaris.o
+OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
+OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
+OBJS-$(CONFIG_MiniOS) += xc_minios.o
+OBJS-y       += xc_evtchn_compat.o
+OBJS-y       += xc_gnttab_compat.o
+OBJS-y       += xc_devicemodel_compat.o
+
+CFLAGS   += -D__XEN_TOOLS__
+CFLAGS	+= $(PTHREAD_CFLAGS)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+
+# Needed for posix_fadvise64() in xc_linux.c
+CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index a0a2d24f99..b70dd774e4 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += common.o
-OBJS-$(CONFIG_FreeBSD) += common.o
-OBJS-$(CONFIG_SunOS)   += compat.o
-OBJS-$(CONFIG_NetBSD)  += compat.o
-OBJS-$(CONFIG_MiniOS)  += compat.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/devicemodel/Makefile.common b/tools/libs/devicemodel/Makefile.common
new file mode 100644
index 0000000000..a7bf7c35bb
--- /dev/null
+++ b/tools/libs/devicemodel/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += common.o
+OBJS-$(CONFIG_FreeBSD) += common.o
+OBJS-$(CONFIG_SunOS)   += compat.o
+OBJS-$(CONFIG_NetBSD)  += compat.o
+OBJS-$(CONFIG_MiniOS)  += compat.o
diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile
index 8208ecf650..3dad3840c6 100644
--- a/tools/libs/evtchn/Makefile
+++ b/tools/libs/evtchn/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/evtchn/Makefile.common b/tools/libs/evtchn/Makefile.common
new file mode 100644
index 0000000000..20629f521a
--- /dev/null
+++ b/tools/libs/evtchn/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile
index 4427435932..b70dd774e4 100644
--- a/tools/libs/foreignmemory/Makefile
+++ b/tools/libs/foreignmemory/Makefile
@@ -4,11 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-OBJS-y                 += core.o
-OBJS-$(CONFIG_Linux)   += linux.o
-OBJS-$(CONFIG_FreeBSD) += freebsd.o
-OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
-OBJS-$(CONFIG_NetBSD)  += netbsd.o
-OBJS-$(CONFIG_MiniOS)  += minios.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/foreignmemory/Makefile.common b/tools/libs/foreignmemory/Makefile.common
new file mode 100644
index 0000000000..ff3b1d4f3e
--- /dev/null
+++ b/tools/libs/foreignmemory/Makefile.common
@@ -0,0 +1,6 @@
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
index 7d7aeeadff..3dad3840c6 100644
--- a/tools/libs/gnttab/Makefile
+++ b/tools/libs/gnttab/Makefile
@@ -4,13 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-OBJS-GNTTAB            += gnttab_core.o
-OBJS-GNTSHR            += gntshr_core.o
-
-OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
-OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
-OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
-OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
-OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/gnttab/Makefile.common b/tools/libs/gnttab/Makefile.common
new file mode 100644
index 0000000000..759e36e1cb
--- /dev/null
+++ b/tools/libs/gnttab/Makefile.common
@@ -0,0 +1,8 @@
+OBJS-GNTTAB            += gnttab_core.o
+OBJS-GNTSHR            += gntshr_core.o
+
+OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
+OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
+OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
+OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
+OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 62b8fead86..86b2b59650 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -1,97 +1,11 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifeq ($(CONFIG_LIBXC_MINIOS),y)
-# Save/restore of a domain is currently incompatible with a stubdom environment
-override CONFIG_MIGRATE := n
-endif
-
-OBJS-y += xg_private.o
-OBJS-y += xg_domain.o
-OBJS-y += xg_suspend.o
-OBJS-y += xg_resume.o
-ifeq ($(CONFIG_MIGRATE),y)
-OBJS-y += xg_sr_common.o
-OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
-OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
-OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
-OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
-OBJS-y += xg_sr_restore.o
-OBJS-y += xg_sr_save.o
-OBJS-y += xg_offline_page.o
-else
-OBJS-y += xg_nomigrate.o
-endif
-OBJS-y       += xg_core.o
-OBJS-$(CONFIG_X86) += xg_core_x86.o
-OBJS-$(CONFIG_ARM) += xg_core_arm.o
-
-vpath %.c ../../../xen/common/libelf
-
-LIBELF_OBJS += libelf-tools.o libelf-loader.o
-LIBELF_OBJS += libelf-dominfo.o
-
-OBJS-y += $(LIBELF_OBJS)
-
-ifeq ($(CONFIG_X86),y) # Add libx86 to the build
-vpath %.c ../../../xen/lib/x86
-
-OBJS-y                 += cpuid.o msr.o policy.o
-endif
-
-# new domain builder
-OBJS-y                 += xg_dom_core.o
-OBJS-y                 += xg_dom_boot.o
-OBJS-y                 += xg_dom_elfloader.o
-OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
-OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
-OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
-OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
-OBJS-y                 += xg_dom_binloader.o
-OBJS-y                 += xg_dom_compat_linux.o
-
-OBJS-$(CONFIG_X86)     += xg_dom_x86.o
-OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
-OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
-
-ifeq ($(CONFIG_LIBXC_MINIOS),y)
-OBJS-y                 += xg_dom_decompress_unsafe.o
-OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
-OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
-OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
-OBJS-y                 += xg_dom_decompress_unsafe_xz.o
-OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
-endif
-
-CFLAGS += -D__XEN_TOOLS__
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-CFLAGS += -iquote ../../../xen/common/libelf
-
-# To be able to include xc_private.h
-CFLAGS += -iquote $(XEN_libxenctrl)
-
-# Needed for posix_fadvise64() in xc_linux.c
-CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
-
-CFLAGS	+= $(PTHREAD_CFLAGS)
-CFLAGS	+= $(CFLAGS_libxentoollog)
-CFLAGS	+= $(CFLAGS_libxenevtchn)
-CFLAGS	+= $(CFLAGS_libxendevicemodel)
-
-# libxenguest includes xc_private.h, so needs this despite not using
-# this functionality directly.
-CFLAGS += $(CFLAGS_libxencall) $(CFLAGS_libxenforeignmemory)
-
-ifeq ($(CONFIG_MiniOS),y)
-ZLIB_CFLAGS :=
-ZLIB_LIBS :=
-endif
+include Makefile.common
 
 xg_dom_bzimageloader.o xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
 
-$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 LIBHEADER := xenguest.h
 
diff --git a/tools/libs/guest/Makefile.common b/tools/libs/guest/Makefile.common
new file mode 100644
index 0000000000..a026a2f662
--- /dev/null
+++ b/tools/libs/guest/Makefile.common
@@ -0,0 +1,84 @@
+ifeq ($(CONFIG_LIBXC_MINIOS),y)
+# Save/restore of a domain is currently incompatible with a stubdom environment
+override CONFIG_MIGRATE := n
+endif
+
+OBJS-y += xg_private.o
+OBJS-y += xg_domain.o
+OBJS-y += xg_suspend.o
+OBJS-y += xg_resume.o
+ifeq ($(CONFIG_MIGRATE),y)
+OBJS-y += xg_sr_common.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
+OBJS-y += xg_sr_restore.o
+OBJS-y += xg_sr_save.o
+OBJS-y += xg_offline_page.o
+else
+OBJS-y += xg_nomigrate.o
+endif
+OBJS-y       += xg_core.o
+OBJS-$(CONFIG_X86) += xg_core_x86.o
+OBJS-$(CONFIG_ARM) += xg_core_arm.o
+
+vpath %.c ../../../xen/common/libelf
+
+LIBELF_OBJS += libelf-tools.o libelf-loader.o
+LIBELF_OBJS += libelf-dominfo.o
+
+OBJS-y += $(LIBELF_OBJS)
+
+ifeq ($(CONFIG_X86),y) # Add libx86 to the build
+vpath %.c ../../../xen/lib/x86
+
+OBJS-y                 += cpuid.o msr.o policy.o
+endif
+
+# new domain builder
+OBJS-y                 += xg_dom_core.o
+OBJS-y                 += xg_dom_boot.o
+OBJS-y                 += xg_dom_elfloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
+OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
+OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
+OBJS-y                 += xg_dom_binloader.o
+OBJS-y                 += xg_dom_compat_linux.o
+
+OBJS-$(CONFIG_X86)     += xg_dom_x86.o
+OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
+OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
+
+ifeq ($(CONFIG_LIBXC_MINIOS),y)
+OBJS-y                 += xg_dom_decompress_unsafe.o
+OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
+OBJS-y                 += xg_dom_decompress_unsafe_xz.o
+OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
+endif
+
+CFLAGS += -D__XEN_TOOLS__
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -iquote ../../../xen/common/libelf
+
+# To be able to include xc_private.h
+CFLAGS += -iquote $(XEN_libxenctrl)
+
+# Needed for posix_fadvise64() in xc_linux.c
+CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
+
+CFLAGS	+= $(PTHREAD_CFLAGS)
+CFLAGS	+= $(CFLAGS_libxentoollog)
+CFLAGS	+= $(CFLAGS_libxenevtchn)
+CFLAGS	+= $(CFLAGS_libxendevicemodel)
+
+# libxenguest includes xc_private.h, so needs this despite not using
+# this functionality directly.
+CFLAGS += $(CFLAGS_libxencall) $(CFLAGS_libxenforeignmemory)
+
+$(LIBELF_OBJS): CFLAGS += -Wno-pointer-sign
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 360a10e5da..5b81814e52 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -3,19 +3,13 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR	= 1
 MINOR	= 0
-AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
 LIBHEADER := xentoolcore.h
 
-OBJS-y	+= handlereg.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
 PKG_CONFIG_DESC := Central support for Xen Hypervisor userland libraries
 
-$(OBJS-y): $(AUTOINCS)
 $(PIC_OBJS): $(AUTOINCS)
-
-$(XEN_INCLUDE)/_xentoolcore_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
-	$(PERL) $^ --prefix=xentoolcore >$(notdir $@).new
-	$(call move-if-changed,$(notdir $@).new,$@)
diff --git a/tools/libs/toolcore/Makefile.common b/tools/libs/toolcore/Makefile.common
new file mode 100644
index 0000000000..4d6c7687f8
--- /dev/null
+++ b/tools/libs/toolcore/Makefile.common
@@ -0,0 +1,9 @@
+OBJS-y	+= handlereg.o
+
+AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
+
+$(OBJS-y): $(AUTOINCS)
+
+$(XEN_INCLUDE)/_xentoolcore_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
+	$(PERL) $^ --prefix=xentoolcore >$(notdir $@).new
+	$(call move-if-changed,$(notdir $@).new,$@)
diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
index c09aa02ba5..2361b8cbf1 100644
--- a/tools/libs/toollog/Makefile
+++ b/tools/libs/toollog/Makefile
@@ -4,7 +4,6 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR	= 1
 MINOR	= 0
 
-OBJS-y	+= xtl_core.o
-OBJS-y	+= xtl_logger_stdio.o
+include Makefile.common
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/toollog/Makefile.common b/tools/libs/toollog/Makefile.common
new file mode 100644
index 0000000000..c053ac6a73
--- /dev/null
+++ b/tools/libs/toollog/Makefile.common
@@ -0,0 +1,2 @@
+OBJS-y	+= xtl_core.o
+OBJS-y	+= xtl_logger_stdio.o
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239466.415160 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSX-00081b-Rp; Mon, 06 Dec 2021 17:07:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239466.415160; Mon, 06 Dec 2021 17:07:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSX-00081M-O4; Mon, 06 Dec 2021 17:07:25 +0000
Received: by outflank-mailman (input) for mailman id 239466;
 Mon, 06 Dec 2021 17:07:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPf-0005ti-O7
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 91512ef9-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91512ef9-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810266;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=QUW3oQGRCIsCTBwhj/I18yejXA0w2YENn2RLNn0NPtM=;
  b=JuePm0wKVw0oYpRWf4feSH/z17Y2zzA7sbfGg0JrYjQKk3XVPuYqp6qV
   lgbR+ytUlUnVBz24vtosHouW+1p2qx8y1VnTzzKa8Ck9cNKhWN1vtrRIO
   GaM2q3TsFWdbL8OP6fC5XLNn52ufifnTcTRPBIGIDzqZzpNjTDsRwrByr
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: IItMqUgkway0r+Nq/loDXcAFMx6wq8tuD+pZ2gYoiVbGJm7EqQJjdH8CHBcAIbgEgwADRLXjp6
 ozRSMSShm8lK8KIo7Hu4sF7Nn+mHIXX/8rKohQjZZzY6Ko7kY4Y4WS4XhSE8HKRIa/eOGlaWIv
 zbzrfqesfBhQD8sJKNBwjCi2ChkI2sAdwaxw67hK6Qfl2bfigD3KPK0uZEPLOhK5yI/Jh41Z7e
 jmiPgqz32EiTCpnGLbGPtINNtFtTZcGY1tOs4/wMbE3AJiH9HNdlbwuGWrj3ihCiWQ4HePaPoN
 hIHCP/PAbKR72oUs8tNWR2sV
X-SBRS: 5.1
X-MesageID: 58884496
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:E4mUoq9bdH6w7H0DknP1DrUDcXmTJUtcMsCJ2f8bNWPcYEJGY0x3z
 GYbUGuPP6zfZ2P9LtB0a96//E9QucTXz4BmTgI5+Ck8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgu7
 fJxvr6sWTwyL43+qtkQUDV/TH1xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0eTaaCO
 5tHAdZpRAT7TgEQK3ocMooRxdqHhCH8LRBjinvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru/WvjBQoBHMeC0jfD+XWp7sfOgiHTSI8UDKe/9PNhnBuU3GN7IA0bUx63rOe0jma6WslDM
 AoE9yw2t68w+Ue3CN7nUHWQqXiYvhkaSpxIHvcz8g2lxa/d4gLfDW8BJgOtc/R/6pVwH2Zzk
 AbUwZW5XlSDrYF5V1rC05CophGuKRMOPE8wVxIJTicivIXs9dRbYg30cv5vF6u8j9vQED72w
 iyXoCVWu4j/nfLnxI3gowmZ3mvESozhC1dsu16JBj7NAhZRPdb9P+SVBU7nAeGsxWpzZn2Ip
 zA6lseX94ji5rndxXXWEI3h8FxEjstp0QEwY3YyRvHNFBz3ohZPmLy8Bhkkfi+F1e5eJlfUj
 Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMMhK1XWoXs0OxHAt4wIrKTKuftlU
 Xt8WZzzZUv29Iw9lGbmLwvj+eFDKt8CKZP7GsmgkkXPPUu2b3+JU7YVWGZinchihJ5oVD79q
 o4FX+PTkk03eLSnPkH/rN5CRXhXfCNTLc2n9KRqmhurf1MO9JcJUKSKn9vMuuVNwsxoqws/1
 i3nBxIDlgOg3SavxMfjQikLVY4DlK1X9RoTVRHA937ys5T6SYrwvqoZabUterwrqL5qwfJuF
 qFXcMScGPVfDD/A/m1FP5X6qYVjcjWthB6PYHX5MGRuIcY4Slyb4MLgcyvu6DIKUni9u/whr
 uDyzQjcW5cCGVhvVZ6EdPK1wlqtlnEBg+YuDVDQK9xedRy0oohnIiD8lNEtJMQIJUmRzzeWz
 V/OUxwZufPMs8k+99yQ3fKIqIKgEu1fGEtGHjaEsebqZHeCpmf6mN1OSueFezzZRVjYwqT6a
 LUH1ez4Pd0GgE1O79h2HYF0wP9s/NDovbJbkFhpRS2Zc1SxB7p8CXCaxs0T5LZVz7pUtAbqC
 EKC/t5WZeeANM//SQNDIQMkaqKI1O0OmymU5vMweR2o6Chy9buBcENTIxjT13ANcOoraNsok
 bU7pcobyw2jkR57YN+Jgxdd+3mIMnFdAb4ssYsXAdOzhwcmor2YjUcw1sMiDEmzVuhx
IronPort-HdrOrdr: A9a23:EYaJNa3ZMI7xKRYqPmM61QqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884496"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 46/57] libs/store: use of -iquote instead of -I
Date: Mon, 6 Dec 2021 17:02:29 +0000
Message-ID: <20211206170241.13165-47-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/store/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 6cc9baaabe..65092d8432 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -22,7 +22,7 @@ CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
 CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
 
 vpath xs_lib.c $(XEN_ROOT)/tools/xenstore
-CFLAGS += -I $(XEN_ROOT)/tools/xenstore
+CFLAGS += -iquote $(XEN_ROOT)/tools/xenstore
 
 xs.opic: CFLAGS += -DUSE_PTHREAD
 ifeq ($(CONFIG_Linux),y)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239467.415164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSY-00085Z-7I; Mon, 06 Dec 2021 17:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239467.415164; Mon, 06 Dec 2021 17:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSY-00084i-19; Mon, 06 Dec 2021 17:07:26 +0000
Received: by outflank-mailman (input) for mailman id 239467;
 Mon, 06 Dec 2021 17:07:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOs-0005ti-Hz
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 72be75aa-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 72be75aa-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810215;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=TP5c4pGgMR6VLoF6V/Z6C00XsVMt1l37Dl5Mn5goLHs=;
  b=XNEFPWL3ysde62lYteDSgvIx87Kso0Agwkk4anpu0fNgWzXUSjVUFdB4
   IbdxUzbxfBiXX3w4DvlQpyQZhl8z5vdh3X8+a1j8dXFRtSxoh/FSNdpCs
   UQsYlxUmwsRivnBcTVACV4zQnM5af+NCRpv/4koY7YNIBz17lrrLeA+rB
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3opwMbn2x99q3zhORKoPiG1HPUCQz+KfI/stRL/eUlB/VpKRjdaFi+5ZdqH5cJMC5Fwz4ARgYd
 KjG5m/WCPXAcyqWEnzT2rYGMqmfwmCWPAVfmoNZb27rzSw9A0Bp6/ht/HLeu4mdsZIJPvszldp
 odOwOtxX1o9r/KM5BKbfSRtnVTTnLLyg4MBRlS63driEzDVobqQEtKTGB1l00eJqTC7AEFs+jz
 g7cMc3XhAaamoTsYjXedwDZCw7Z1odriExKccmuyjqWf4LDerzxrIm0Y/ojutyq1ntenzHwIx6
 hA4Fby4hGAlEwtdi8F+6FpW2
X-SBRS: 5.1
X-MesageID: 59324043
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ocq29qj/XbQ/3OmvjBdDANPvX161kRcKZh0ujC45NGQN5FlHY01je
 htvWGGBMv+Ja2bxKt0ga4qx9BxX7cSAnNE1SQBsry1mFnkb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0dsJuqTAINP5TCncMAYiRfKyJ1EepJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPP
 JBFMWY0BPjGSwJ9BHoOBKA+puDytHz9axFlr2CO9INitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAB4AM8eE4SGY6X/qjejK9Qv6R4A6BLC+7uRtglCY2ioUEhJ+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxastxgAW91WAqsi5RuE0Kb87AOQB2xCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J/EqDSoPC0xLFYMYAgZfDYC29rojMY820enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPtTwsTDmAeB8wJF1p7Vrl
 FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8rlxBGFb5JOi8BQ2Swm8zaK7onhezP
 yfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlTXo3s/OBTKgT+9+KTJrU3ZE
 c3BGSpLJSxFYZmLMRLsH7tNuVPV7n5WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchMClQek2ySYcV7ih7IKQOqHYKuTZEkTZUQEVWtEEVB9CWp2xKtAJZYxY5c98+lvkax9Q
 /UfIp3SCfVTUDXXvT8aaMCl/oBlcR2qgyOIPjakP2djL8IxGVSR94+2ZBbr+QkPEjGz6Zk0r
 Yq/216JWpEEXQljUprbMar901OrsHEBs+tuRE+UcMJLcUDh/dEyeSz8h/M6Oe8WLhDHymfI3
 gqaG05A9+LMv5U04J/CgqXd99WlFO53H0x7GWjH7OnpaXmGrzT7mYIZCbSGZzHQUm/w6Z6OX
 +QNwqGuKuADkXZLr5F4T+Rhw5Uh6oa9vLRd1AllQinGNgz5FrN6L3Ca9sBTrakRlKRBsA67V
 0/TqNlXPbKFZJHsHFILfVd3a+2C0bcfmyXI7ORzK0L/vXcl8L2CWERUHh+NlC0Cc+clbNJ7m
 b8s6JwM9giyqhs2KdLX3Clb+lOFImEET6h65IoRB5Xmi1Zzx1xPCXAG5vQaPH1bhw1wD3QX
IronPort-HdrOrdr: A9a23:2qWUFa974l+A6GU9IWRuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324043"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 20/57] tools/Rules.mk: introduce FORCE target
Date: Mon, 6 Dec 2021 17:02:03 +0000
Message-ID: <20211206170241.13165-21-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

And replace the one defined in libs.mk.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Rules.mk     | 3 +++
 tools/libs/libs.mk | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/Rules.mk b/tools/Rules.mk
index 4e9b4ee17f..0d3febfbb6 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -210,3 +210,6 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR)
 	echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)"; \
 	echo "Requires.private: $(PKG_CONFIG_REQPRIV)"; \
 	} > $@
+
+.PHONY: FORCE
+FORCE:
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 5c2f16dda4..996d467346 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -135,6 +135,3 @@ clean:
 
 .PHONY: distclean
 distclean: clean
-
-.PHONY: FORCE
-FORCE:
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239474.415182 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSi-0000nc-Pp; Mon, 06 Dec 2021 17:07:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239474.415182; Mon, 06 Dec 2021 17:07:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSi-0000nJ-Ki; Mon, 06 Dec 2021 17:07:36 +0000
Received: by outflank-mailman (input) for mailman id 239474;
 Mon, 06 Dec 2021 17:07:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPj-0005ti-Pj
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:31 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 93194e60-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 93194e60-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810270;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=p5aAroINdY0XxstjIhOll7B4+KbnIHxusYrnLiZlbAY=;
  b=Pqr2cvAxtlIySiaJWHrtWXJOLgJFVDinliXRFLIJczfsqZLSMQKJ7jn+
   F5Ocly2PXPSP2GrJs/D0c7olTh/NAcxf5hLlMUFFAlsbXmLb9v6GB3h0r
   gsSveEpt6fjzwhFNllFgO0XayXI5+ZHwaY98Pb84AMuRCfRg0/Gy+GROs
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: HBQFEQ+Y1u8kQ2/rCy/yYli3LDSL6ypUwUk7RO+01grHlWf6UQ/ZmXkXODPK73GhJsz/hPT65x
 lszt5Za7VFGBZ9rQR6qQYRCE2QQ6pKwZslXlC3CzIG3PGTqE8itXD1jyuUNTbxNjnJT6OdHDXT
 AwepTnXXDdrBelbcIKrytpl2sDp7GqQ1jiXL+WyWNMPH5QBL7mb4j+UjhfA67AtgVelfHLzfkp
 ZJu2UsIqVMstvwjSo46qF92JYoGVUr8f8g9ioEE6rgGij8jXxmhV2ByvFsSVqluDfid5P1NAKz
 7srUcgCrRnB+lvJuNloc51IC
X-SBRS: 5.1
X-MesageID: 59324146
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ZiC+katT2BP3OfOz8s5ve02bpefnVKdZMUV32f8akzHdYApBsoF/q
 tZmKW/SMviDYDP1LYwjO4+woUpUup6HmN9jQAM6+S8zEy4S+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplurXpbQoQHZT2qronekIIIzkvB/F50eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 pFDNWMzMnwsZTVhIF0NGct9t920h2XfUHp9kH67r60etj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhMVLtuE0hKe72mhwOTImEvTWZ0QPK218OZwh1+ezXBVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhcaR9pXFfx88AyXw7DYywmcD2kACDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8ohrrHSUsDlY4V3E+ZFBV08Gymt0Mp0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9XwsQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm3FF52LJ9k4DNRCyKFBaJxsldjBO
 hC7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHcrH40NBPKhT6ywCDAdJ3T3
 7/BK65A6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILOO5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:kNp2CaxHh+WItbtFnv2GKrPwAr1zdoMgy1knxilNoERuA6ilfr
 OV7ZMmPH7P+U0ssR4b+exoVJPsfZqYz+8R3WBzB8bZYOCFghrKEGgK1+KLqFfd8m/Fh4xgPM
 xbHJSWfeeQMbEMt6jHCWeDf+rJHLG8gd2VbKzlvhFQpElRGthdBilCe36mLnE=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324146"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 47/57] libs/stat: Fix and rework python-bindings build
Date: Mon, 6 Dec 2021 17:02:30 +0000
Message-ID: <20211206170241.13165-48-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Fix the dependency on the library, $(SHLIB) variable doesn't exist
anymore.

Rework dependency on the include file, we can let `swig` generate the
dependency for us with the use of "-M*" flags.

The xenstat.h file has moved so we need to fix the include location.

Rather than relaying on the VCS to create an empty directory for us,
we can create one before generating the *.c file for the bindings.

Make use of generic variable names to build a shared library from a
source file: CFLAGS, LDFLAGS, and LDLIBS.

Fix python's specific *flags by using python-config, and add them to
generic flags variables: CFLAGS, LDLIBS.

To build a shared library, we need to build the source file with
"-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
new tools/libs/stat directory).

The source file generated by swig seems to be missing a prototype for
the "init" function, so we need "-Wno-missing-prototypes" in order to
build it.

Add some targets to .PHONY.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/stat/Makefile                    | 27 +++++++++++++++------
 tools/libs/stat/bindings/swig/python/.empty |  1 -
 2 files changed, 19 insertions(+), 9 deletions(-)
 delete mode 100644 tools/libs/stat/bindings/swig/python/.empty

diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index e39fe29bd1..d5d9cb3659 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -49,23 +49,34 @@ install-bindings: install-perl-bindings install-python-bindings
 .PHONY: uninstall-bindings
 uninstall-bindings: uninstall-perl-bindings uninstall-python-bindings
 
-$(BINDINGS): $(SHLIB) $(SHLIB_LINKS) include/xenstat.h
+$(BINDINGS): libxenstat.so
 
-SWIG_FLAGS=-module xenstat -Iinclude -I.
+SWIG_FLAGS = -module xenstat -I$(XEN_INCLUDE)
+SWIG_FLAGS += -MMD -MP -MF .$(if $(filter-out .,$(@D)),$(subst /,@,$(@D))@)$(@F).d
 
 # Python bindings
-PYTHON_VERSION=$(PYTHON:python%=%)
-PYTHON_FLAGS=-I/usr/include/python$(PYTHON_VERSION) -lpython$(PYTHON_VERSION)
 $(PYMOD): $(PYSRC)
 $(PYSRC): bindings/swig/xenstat.i
-	swig -python $(SWIG_FLAGS) -outdir $(@D) -o $(PYSRC) $<
-
+	mkdir -p $(@D)
+	swig -python $(SWIG_FLAGS) -outdir $(@D) -o $@ $<
+
+$(PYLIB): CFLAGS += $(shell $(PYTHON)-config --includes)
+$(PYLIB): CFLAGS += -fPIC
+$(PYLIB): CFLAGS += -Wno-missing-prototypes
+$(PYLIB): LDFLAGS += $(SHLIB_LDFLAGS)
+$(PYLIB): LDLIBS := $(shell $(PYTHON)-config --libs)
+$(PYLIB): LDLIBS += $(LDLIBS_libxenstat)
 $(PYLIB): $(PYSRC)
-	$(CC) $(CFLAGS) $(LDFLAGS) $(PYTHON_FLAGS) $(SHLIB_LDFLAGS) -lxenstat -o $@ $< $(APPEND_LDFLAGS)
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
+.PHONY: python-bindings
 python-bindings: $(PYLIB) $(PYMOD)
 
-pythonlibdir=$(prefix)/lib/python$(PYTHON_VERSION)/site-packages
+pythonlibdir = $(shell $(PYTHON) -c \
+	       'import distutils.sysconfig as cfg; \
+	        print(cfg.get_python_lib(False, False, prefix="$(prefix)"))')
+
+.PHONY: install-python-bindings
 install-python-bindings: $(PYLIB) $(PYMOD)
 	$(INSTALL_PROG) $(PYLIB) $(DESTDIR)$(pythonlibdir)/_xenstat.so
 	$(INSTALL_PROG) $(PYMOD) $(DESTDIR)$(pythonlibdir)/xenstat.py
diff --git a/tools/libs/stat/bindings/swig/python/.empty b/tools/libs/stat/bindings/swig/python/.empty
deleted file mode 100644
index 2a8dd4274d..0000000000
--- a/tools/libs/stat/bindings/swig/python/.empty
+++ /dev/null
@@ -1 +0,0 @@
-This directory is empty; this file is included to prevent version control systems from removing the directory.
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239476.415187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSj-0000rY-DF; Mon, 06 Dec 2021 17:07:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239476.415187; Mon, 06 Dec 2021 17:07:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSi-0000py-Vb; Mon, 06 Dec 2021 17:07:36 +0000
Received: by outflank-mailman (input) for mailman id 239476;
 Mon, 06 Dec 2021 17:07:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOq-0005ti-Ho
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:36 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 714dd024-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 714dd024-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810214;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=87Jwg3dUCW2JRgwzDCH17RKTaiNypi0W5MI+j9zb2Dw=;
  b=LQZ1fSRynnjoshix7PuQJUgu4lwgFfIx5cXQl47wdlSPOeFSCWkQQFCU
   6hy+1H35iV3yaZ2rlwXE2i+KdjFZVVy0kDROboZgan1IyARYSwBKH28C9
   FWXsqcLPqeqFhx5NYmtBU02VEtWOm0P6HoH+25dss2LULOtyp35kbOcM/
   k=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: aRgDtDW9+i7arDAhUgwN9Wt3ZP+K9bzn48v7bdjUxgCDVK4pTw3RyGQ/3ZpDYguReP0VIyqa8g
 P+AMN+z2PsPWPaBKj2RNfhnMiKc/q+YpE9wEJ0eCYZYcrEwvC8D6evICfZaAcSWZvUfl+UAgpj
 tiesAr6vB1vHb2CtvL5UEVbgBJDFERpA/7T8s47WHyug4QkBleYKfDj4npuUULkHrMIxoCy/oF
 X37WQBIXSp5FNrSOo7AGmwf49WYlWBZnI8xZicEgk5R4VqII/lvsMxu0s+CTnlOtribpmLBRrn
 4sy7WHlXmCM8U2pSY/0RXVZ5
X-SBRS: 5.1
X-MesageID: 59324028
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ejcUyqNr2ibBIcDvrR1UkMFynXyQoLVcMsEvi/4bfWQNrUoj0TEHz
 mRJDTvTP/vYMDHzftF3Odu1801TupPRn4dlQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En5400o9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoyi1rfVSw
 tdOjMyTdwk1bojjg88dbSANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWZr3JwWR6a2i
 8wxWSo/MyrQWkJzCnwSJ8wQhPy5mGDfWmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6aq
 XjB5H/RGQwBOZqUzj/t2nOzhMffkCXjQoUQGbaksPlwjzW71mEVTREbS1a/if24kVKlHcJSL
 VQO/SgjprR081akJvH0WQG4p3iV+AYRQdNKH8U17QiMzuzf5APxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmKCpe1e+/LWXlGORByYJfUotfgQEczJQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r8tlshDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGCF6bKMN8N4n9hIx5JFVdoKiN2ZDB02WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKNYoROMksLlXZo3EGiausM4bFyhJEfUYXY
 8jzTCpRJSxCVfQPIMSeGY/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9yr2Vo
 yrjAxAAkzISRxTvcG23V5yqU5u3Nb4XkJ7xFXZE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:K8bvzKEIbgwv9TqvpLqE4seALOsnbusQ8zAXP0AYc3Nom6uj5q
 WTdZUgpHjJYVkqOU3I9ersBEDiewK/yXcW2+ks1N6ZNWGM0ldARLsSibcKqAePJ8SRzIJgPN
 9bAstDNOE=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324028"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 19/57] tools/configure.ac: Create ZLIB_LIBS and ZLIB_CFLAGS
Date: Mon, 6 Dec 2021 17:02:02 +0000
Message-ID: <20211206170241.13165-20-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Use both ZLIB_CFLAGS and ZLIB_LIBS instead of cherry-picking flags
from a single "ZLIB" variable.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/configure.ac        | 19 ++++++++++++++-----
 config/Tools.mk.in        |  3 ++-
 tools/configure           | 22 ++++++++++++++--------
 tools/libs/guest/Makefile | 12 +++++-------
 4 files changed, 35 insertions(+), 21 deletions(-)

diff --git a/tools/configure.ac b/tools/configure.ac
index 5a4fb9022d..56afe7930d 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -391,17 +391,26 @@ AX_CHECK_FETCHER
 
 # Checks for libraries.
 AC_CHECK_HEADER([bzlib.h], [
-AC_CHECK_LIB([bz2], [BZ2_bzDecompressInit], [zlib="$zlib -DHAVE_BZLIB -lbz2"])
+    AC_CHECK_LIB([bz2], [BZ2_bzDecompressInit],
+        [ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_BZLIB"
+         ZLIB_LIBS="$ZLIB_LIBS -lbz2"])
 ])
 AC_CHECK_HEADER([lzma.h], [
-AC_CHECK_LIB([lzma], [lzma_stream_decoder], [zlib="$zlib -DHAVE_LZMA -llzma"])
+    AC_CHECK_LIB([lzma], [lzma_stream_decoder],
+        [ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_LZMA"
+         ZLIB_LIBS="$ZLIB_LIBS -llzma"])
 ])
 AC_CHECK_HEADER([lzo/lzo1x.h], [
-AC_CHECK_LIB([lzo2], [lzo1x_decompress], [zlib="$zlib -DHAVE_LZO1X -llzo2"])
+    AC_CHECK_LIB([lzo2], [lzo1x_decompress],
+        [ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_LZO1X"
+         ZLIB_LIBS="$ZLIB_LIBS -llzo2"])
 ])
 PKG_CHECK_MODULES([libzstd], [libzstd],
-    [zlib="$zlib -DHAVE_ZSTD $libzstd_CFLAGS $libzstd_LIBS"], [true])
-AC_SUBST(zlib)
+    [ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_ZSTD $libzstd_CFLAGS"
+     ZLIB_LIBS="$ZLIB_LIBS $libzstd_LIBS"],
+    [true])
+AC_SUBST([ZLIB_CFLAGS])
+AC_SUBST([ZLIB_LIBS])
 AX_CHECK_EXTFS
 AX_CHECK_PTHREAD
 AX_CHECK_PTYFUNCS
diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 934d899967..6c1a0a676f 100644
--- a/config/Tools.mk.in
+++ b/config/Tools.mk.in
@@ -66,7 +66,8 @@ CONFIG_9PFS         := @ninepfs@
 LINUX_BACKEND_MODULES := @LINUX_BACKEND_MODULES@
 
 #System options
-ZLIB                := @zlib@
+ZLIB_CFLAGS         := @ZLIB_CFLAGS@
+ZLIB_LIBS           := @ZLIB_LIBS@
 CONFIG_LIBICONV     := @libiconv@
 EXTFS_LIBS          := @EXTFS_LIBS@
 CURSES_LIBS         := @CURSES_LIBS@
diff --git a/tools/configure b/tools/configure
index 829753b5dd..a052c186a5 100755
--- a/tools/configure
+++ b/tools/configure
@@ -641,7 +641,8 @@ PTHREAD_LIBS
 PTHREAD_LDFLAGS
 PTHREAD_CFLAGS
 EXTFS_LIBS
-zlib
+ZLIB_LIBS
+ZLIB_CFLAGS
 libzstd_LIBS
 libzstd_CFLAGS
 FETCHER
@@ -8605,7 +8606,7 @@ fi
 ac_fn_c_check_header_mongrel "$LINENO" "bzlib.h" "ac_cv_header_bzlib_h" "$ac_includes_default"
 if test "x$ac_cv_header_bzlib_h" = xyes; then :
 
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for BZ2_bzDecompressInit in -lbz2" >&5
+    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for BZ2_bzDecompressInit in -lbz2" >&5
 $as_echo_n "checking for BZ2_bzDecompressInit in -lbz2... " >&6; }
 if ${ac_cv_lib_bz2_BZ2_bzDecompressInit+:} false; then :
   $as_echo_n "(cached) " >&6
@@ -8642,7 +8643,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_bz2_BZ2_bzDecompressInit" >&5
 $as_echo "$ac_cv_lib_bz2_BZ2_bzDecompressInit" >&6; }
 if test "x$ac_cv_lib_bz2_BZ2_bzDecompressInit" = xyes; then :
-  zlib="$zlib -DHAVE_BZLIB -lbz2"
+  ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_BZLIB"
+         ZLIB_LIBS="$ZLIB_LIBS -lbz2"
 fi
 
 
@@ -8652,7 +8654,7 @@ fi
 ac_fn_c_check_header_mongrel "$LINENO" "lzma.h" "ac_cv_header_lzma_h" "$ac_includes_default"
 if test "x$ac_cv_header_lzma_h" = xyes; then :
 
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for lzma_stream_decoder in -llzma" >&5
+    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for lzma_stream_decoder in -llzma" >&5
 $as_echo_n "checking for lzma_stream_decoder in -llzma... " >&6; }
 if ${ac_cv_lib_lzma_lzma_stream_decoder+:} false; then :
   $as_echo_n "(cached) " >&6
@@ -8689,7 +8691,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_lzma_lzma_stream_decoder" >&5
 $as_echo "$ac_cv_lib_lzma_lzma_stream_decoder" >&6; }
 if test "x$ac_cv_lib_lzma_lzma_stream_decoder" = xyes; then :
-  zlib="$zlib -DHAVE_LZMA -llzma"
+  ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_LZMA"
+         ZLIB_LIBS="$ZLIB_LIBS -llzma"
 fi
 
 
@@ -8699,7 +8702,7 @@ fi
 ac_fn_c_check_header_mongrel "$LINENO" "lzo/lzo1x.h" "ac_cv_header_lzo_lzo1x_h" "$ac_includes_default"
 if test "x$ac_cv_header_lzo_lzo1x_h" = xyes; then :
 
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for lzo1x_decompress in -llzo2" >&5
+    { $as_echo "$as_me:${as_lineno-$LINENO}: checking for lzo1x_decompress in -llzo2" >&5
 $as_echo_n "checking for lzo1x_decompress in -llzo2... " >&6; }
 if ${ac_cv_lib_lzo2_lzo1x_decompress+:} false; then :
   $as_echo_n "(cached) " >&6
@@ -8736,7 +8739,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_lzo2_lzo1x_decompress" >&5
 $as_echo "$ac_cv_lib_lzo2_lzo1x_decompress" >&6; }
 if test "x$ac_cv_lib_lzo2_lzo1x_decompress" = xyes; then :
-  zlib="$zlib -DHAVE_LZO1X -llzo2"
+  ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_LZO1X"
+         ZLIB_LIBS="$ZLIB_LIBS -llzo2"
 fi
 
 
@@ -8812,10 +8816,12 @@ else
 	libzstd_LIBS=$pkg_cv_libzstd_LIBS
         { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }
-	zlib="$zlib -DHAVE_ZSTD $libzstd_CFLAGS $libzstd_LIBS"
+	ZLIB_CFLAGS="$ZLIB_CFLAGS -DHAVE_ZSTD $libzstd_CFLAGS"
+     ZLIB_LIBS="$ZLIB_LIBS $libzstd_LIBS"
 fi
 
 
+
 ac_fn_c_check_header_mongrel "$LINENO" "ext2fs/ext2fs.h" "ac_cv_header_ext2fs_ext2fs_h" "$ac_includes_default"
 if test "x$ac_cv_header_ext2fs_ext2fs_h" = xyes; then :
 
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 8f5f3acd21..1f4b7f7c58 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -89,13 +89,12 @@ CFLAGS	+= $(CFLAGS_libxendevicemodel)
 CFLAGS += $(CFLAGS_libxencall) $(CFLAGS_libxenforeignmemory)
 
 ifeq ($(CONFIG_MiniOS),y)
-zlib-options =
-else
-zlib-options = $(ZLIB)
+ZLIB_CFLAGS :=
+ZLIB_LIBS :=
 endif
 
-xg_dom_bzimageloader.o: CFLAGS += $(filter -D%,$(zlib-options))
-xg_dom_bzimageloader.opic: CFLAGS += $(filter -D%,$(zlib-options))
+xg_dom_bzimageloader.o: CFLAGS += $(ZLIB_CFLAGS)
+xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
 
 LIBHEADER := xenguest.h
 
@@ -103,8 +102,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-libxenguest.so.$(MAJOR).$(MINOR): COMPRESSION_LIBS = $(filter -l%,$(zlib-options))
-libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
+libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(ZLIB_LIBS) -lz
 
 -include $(DEPS_INCLUDE)
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239477.415193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSk-0000zd-3t; Mon, 06 Dec 2021 17:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239477.415193; Mon, 06 Dec 2021 17:07:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSj-0000ws-I2; Mon, 06 Dec 2021 17:07:37 +0000
Received: by outflank-mailman (input) for mailman id 239477;
 Mon, 06 Dec 2021 17:07:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPN-0005ti-8r
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:09 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 863b6834-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 863b6834-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810247;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Qi8ktRfGxKz6TVNBfNc+szyw4+rNfchyhf2q4Nw7GMs=;
  b=bfXvX2kvt3XeFh/G1829Dt/y4fs8KMMlPWqYYhQnz5g4fvKUT5FCJs0b
   vaJQ7OSZiZ3IDf5CeQDVMRLRC/WnVpNae+prvQlB+A7VOjYuRzUOehcej
   QEExhX26tpHWBdGfvE+JP7JnlCCWUGCwhxZR/kAjRSg7xhj+UK4YjOMsn
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: qpV4d4+1FPX+nHxG7J9nJXYwjDyegjkOgLVYA1UFwoOXpRRtyx1G+7iEWpMl33LJiMrqZ6/g6m
 gjqr/1HkC77E1Ma0jS766dfiGeSzrzXiS1ODIpN5+h8pOllVk77qFtnl0QIyeD/ksPX9Bteea4
 vN0rzMrHGSQM7xfny9VE7n1XEWUY2Zbl4fmIvogBKAMHjL0A5N24xc5EZlYUew2I+jlRVJb4Cl
 kg+7XkvHTVgQpaLTCP2exdSnZUo61IH+X1vzcgl+QxvZkrcDN5fFQnQSGv7yMPtlHTZ5XI70b8
 JRk2bRZcs4o54cWIqJ4Kc1mh
X-SBRS: 5.1
X-MesageID: 59387915
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0tYB5K1oaEDJErUU//bD5TJ2kn2cJEfYwER7XKvMYLTBsI5bpzFWz
 WRMCmuOOviMN2aje9l2PoW08ksCvJLTmoJlGVBspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es5w7Bh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhuvE2y
 sRdt9uLaTw5fYL0x8U9CitEOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t15seQqeHO
 qL1bxIwXBXQJDZgP2sVVrUblduvhHXwTm1x/Qf9Sa0fvDGIkV0ZPKLWGNvKePSaSMNNhEGaq
 2nauWPjDXkyK9i32TeDtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pWL
 VAU/Sw/67A/7kWxQvHyWhS5pDiPuRt0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nOoXAj47x
 l3OpPPSFX9AiOK0aSuv6p7B+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hie22r0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJczU/MBuaL9UdF1M2xpjGGeG6bKIN8N+nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpONLuUZV3l/K+SoSNuhXogjxmOMIZmOivpn4GWKJt9zq1zBhEfV8XZ
 /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1ORDt8VqSPmOx5IOSIXc19z4/1w
 510YWcAoHKXuJENAVzbApy6QL+wD5t5s1whOikgYQSh13Q5ON7956YDbZonO7Ig8bU7n/JzS
 vAEfeSGA+hOFWubq2hMM8GlodwwbgmviCKPIzGhPGo1cal/SlGb4dTjZAbuqnUDV3Llqcskr
 rS8/QrHWp5fFR96BcPbZav3nVO8tHQQgsxoWE7MLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94rwSrlwBEtXGWXf/I2aDyiC8zrx25JEXcaJYSvZCDH+9pK9a
 LgH1Pr7KvAGwgpH6tIuD7ZxwKsizNLzvLsGnB98FXDGYln3WLNtJn6KgZtGuqFXn+ILvAK3X
 gSE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6rOidTEFfHxiQkygMfrJ6PbQsz
 folpMNLuRe0jQAnM4regy1Zn4hWwqfsj0nzWkkmPbLW
IronPort-HdrOrdr: A9a23:Vg+O/aDxGI9vsczlHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P
 xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387915"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 35/57] tools/xenpaging: Rework makefile
Date: Mon, 6 Dec 2021 17:02:18 +0000
Message-ID: <20211206170241.13165-36-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

- Rename $(SRCS) to $(OBJS-y), we don't need to collect sources.
- Rename $(IBINS) to $(TARGETS)
- Stop cleaning "xen" and non-set variable $(LIB).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xenpaging/Makefile | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
index 04743b335c..e2ed9eaa3f 100644
--- a/tools/xenpaging/Makefile
+++ b/tools/xenpaging/Makefile
@@ -5,33 +5,33 @@ CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl) $(
 LDLIBS += $(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxenctrl) $(LDLIBS_libxenstore) $(PTHREAD_LIBS)
 LDFLAGS += $(PTHREAD_LDFLAGS)
 
-POLICY    = default
+POLICY   := default
 
-SRC      :=
-SRCS     += file_ops.c xenpaging.c policy_$(POLICY).c
-SRCS     += pagein.c
+OBJS-y   := file_ops.o
+OBJS-y   += xenpaging.o
+OBJS-y   += policy_$(POLICY).o
+OBJS-y   += pagein.o
 
 CFLAGS   += -Werror
 CFLAGS   += -Wno-unused
 
-OBJS     = $(SRCS:.c=.o)
-IBINS    = xenpaging
+TARGETS := xenpaging
 
-all: $(IBINS)
+all: $(TARGETS)
 
-xenpaging: $(OBJS)
+xenpaging: $(OBJS-y)
 	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
 
 install: all
 	$(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	$(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(TARGETS) $(DESTDIR)$(LIBEXEC_BIN)
 
 uninstall:
-	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(IBINS))
+	rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(TARGETS))
 
 clean:
-	rm -f *.o *~ $(DEPS_RM) xen TAGS $(IBINS) $(LIB)
+	rm -f *.o *~ $(DEPS_RM) TAGS $(TARGETS)
 
 distclean: clean
 
@@ -39,6 +39,6 @@ distclean: clean
 
 .PHONY: TAGS
 TAGS:
-	etags -t $(SRCS) *.h
+	etags -t *.c *.h
 
 -include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239478.415200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSk-0001Ak-Ry; Mon, 06 Dec 2021 17:07:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239478.415200; Mon, 06 Dec 2021 17:07:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSk-00015v-9Q; Mon, 06 Dec 2021 17:07:38 +0000
Received: by outflank-mailman (input) for mailman id 239478;
 Mon, 06 Dec 2021 17:07:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPq-0005ti-Ks
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:38 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9735eac8-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9735eac8-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810277;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=V6q43yBVZCXzj8p3r41jU3G4+oX+b+ENWb++VEuZ+aU=;
  b=FMwMRMQdElWlrMQNn7SmLn9RRX08mqbAFdYPyFkhBuZr1BdEA6WFAliz
   0LdRcXPA21PRJ3niQmnSSDvY1+hj+deeDVatozF/rwcYusHjUTXeoSlFP
   6lbSWk2ytQTM4PtGOWn4BViROTiKq62b6WIwNkKDs1jeCA3ni6rTyN2Cb
   o=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3WMfjEkaPwGHAycu7VCXq3LyrKnRM1dLtKl1FM/AuvZ8zQmJ+6Qs5coSO8fm2xX4e4kA10ZkB9
 OmEe5yFOwNwR5mZCsWfg3I/imuaCaeyolTc6sezXRW/i3Jt5JPjaVDdZ/yqO+nMQAff7/X3WBt
 LQxbn3bGhQJiQP56F1oB1QuyrztdTdgrvaHSpWJYNmIh7MrY6foU8rEuIQIcaSuxIoSNZ0OWCf
 tz4Qq8FOzMokEMObF7nIK9d1gsNNcvO8a6vlVjMz8mrfU5iI6vk4ICVbYmVxTZET7qTdqWj9sR
 p66nHAxpYvimm0OZhKUsLcg8
X-SBRS: 5.1
X-MesageID: 58884528
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IvAgGa+RDRV3dB+CeF4XDrUDG3mTJUtcMsCJ2f8bNWPcYEJGY0x3z
 GJLCjuEaPjZZTHxKNgnbNvj9ksEvMKBm981HlNs/CE8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhhx
 ZIXl6WbdzwvL7ORnuAjQgEBTg9HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0eTaaCO
 pBJAdZpRAnFMkweIlMVNLU7hvemlFn6SD9XtGvA8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo
 CTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3uFuqE2ewCoUEhJ+fVmxrOS9i0W+c8lCM
 EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmECUj5Gbs1grMIsTCYm/
 lCMltLtQzdotdW9SG2f3qeZqyuoPioYJnNEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3
 RiaoW9kpYw4s/UNxrvm+1T5kir1+7bwG1tdChrsYkqp6QZwZYiAboOu6ETG4fsoELt1XmVtr
 1BfxZHAsblm4YWl0XXUHb5TRO3BC+OtaWWE2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M
 RaI6Wu9CHK+VUZGjJObgarsUqzGLoC6TLwJs8w4iPIUOPCdkyfdo0lTiba4hTyFraTVufhX1
 W2nWcitF20GLq9s0SC7QewQuZdymHtumjmCGMqhkUv3uVZ7WJJzYe1fWLdpRrpmhJ5oXS2Pq
 4oPXyd040s3vBLCjtn/rtdIcAFiwYkTDpHqsc1HHtNv0SI9cFzN/8T5mOt7E6Q8xvw9vr6Ro
 hmVBx8JoHKi1CavAVjbNRhehEbHAM8XQYQTZnd3Yz5FGhELPO6S0UvoX8dtIOR8qrU8laUco
 jtsU5zoP8mjgw/vo1w1BaQRZqQ+HPhyrQ7RbSejfhYleJtsG17A9tP+J1O9/ygSFCun88A5p
 uT4hA/cRJMCQSVkDdrXN63znw/g4yBFlbIgRVbML/lSZF7orNpgJRvug6JlOMoLMxjCmGeXj
 l7EHRcCqODRiIYp692V17ucpoKkHrImTEpXFmXW95isMize8jbxyINMSr/QLzvcSHn16OOpY
 uAMl6PwN/gOnVBrtYtgEuk0kfJitoW3/7IDl1ZqBnTGaVivG4hMGHje0JkdrLBJy59YpRCyB
 hCF9O5FNOjbI8jiClMQelYoN7zRyfEOlzDOxv0pO0GmtjRv9b+KXEgObRmBjCtRcOl8PI8/m
 LpzvccX70q0iwYwM8bAhSdRrjzeInsFWqQhl5cbHI601VZ7lgAcOcTRWn3s/ZWCS9RQKU17c
 DabiZ3Li6lY2kefIWE4EmLA3LYFiJkD0PyQIITu+7hddgL5u8IK
IronPort-HdrOrdr: A9a23:ycY4K6CqxUfGaX3lHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8v
 xG/c5rsiMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAH0WKI+VPd8kPFmtK1rZ
 0QEJRDNA==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884528"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 51/57] .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc}
Date: Mon, 6 Dec 2021 17:02:34 +0000
Message-ID: <20211206170241.13165-52-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore | 28 ++--------------------------
 1 file changed, 2 insertions(+), 26 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8fb74a4c94..d494d1125a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -105,26 +105,10 @@ tools/config.cache
 config/Tools.mk
 config/Stubdom.mk
 config/Docs.mk
-tools/libs/toolcore/headers.chk
-tools/libs/toolcore/xentoolcore.pc
-tools/libs/toollog/headers.chk
-tools/libs/toollog/xentoollog.pc
-tools/libs/evtchn/headers.chk
-tools/libs/evtchn/xenevtchn.pc
-tools/libs/gnttab/headers.chk
-tools/libs/gnttab/xengnttab.pc
-tools/libs/hypfs/headers.chk
-tools/libs/hypfs/xenhypfs.pc
-tools/libs/call/headers.chk
-tools/libs/call/xencall.pc
+tools/libs/*/headers.chk
+tools/libs/*/*.pc
 tools/libs/ctrl/libxenctrl.map
-tools/libs/ctrl/xencontrol.pc
-tools/libs/foreignmemory/headers.chk
-tools/libs/foreignmemory/xenforeignmemory.pc
-tools/libs/devicemodel/headers.chk
-tools/libs/devicemodel/xendevicemodel.pc
 tools/libs/guest/libxenguest.map
-tools/libs/guest/xenguest.pc
 tools/libs/guest/xc_bitops.h
 tools/libs/guest/xc_core.h
 tools/libs/guest/xc_core_arm.h
@@ -144,21 +128,13 @@ tools/libs/light/testidl.c
 tools/libs/light/test_timedereg
 tools/libs/light/test_fdderegrace
 tools/libs/light/tmp.*
-tools/libs/light/xenlight.pc
-tools/libs/stat/headers.chk
 tools/libs/stat/libxenstat.map
-tools/libs/stat/xenstat.pc
-tools/libs/store/headers.chk
 tools/libs/store/list.h
 tools/libs/store/utils.h
-tools/libs/store/xenstore.pc
 tools/libs/store/xs_lib.c
-tools/libs/util/*.pc
 tools/libs/util/libxlu_cfg_y.output
 tools/libs/util/libxenutil.map
-tools/libs/vchan/headers.chk
 tools/libs/vchan/libxenvchan.map
-tools/libs/vchan/xenvchan.pc
 tools/console/client/xenconsole
 tools/console/daemon/xenconsoled
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239480.415206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSl-0001Ox-GX; Mon, 06 Dec 2021 17:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239480.415206; Mon, 06 Dec 2021 17:07:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSl-0001ME-1v; Mon, 06 Dec 2021 17:07:39 +0000
Received: by outflank-mailman (input) for mailman id 239480;
 Mon, 06 Dec 2021 17:07:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPJ-0005ta-2M
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:05 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 83437ede-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 83437ede-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810243;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=K4Dj/rVFjE9NpLbUJO3gjrHpVBFNDjlJe0A8PqFvnrE=;
  b=cS4FK9s+UNI/2wIWZhIPFfiiUOHcJuNu/llEuqmFKBxZywzc8G9cp0Cv
   FE9C+cBv5QoMVOOnuEP1FiSEQqsNuoc1Y8koj/BK7sW9Y12CJuC6mRHfv
   Bx5F4eeMV5sJ11EYMRkxFk/RZR9P1GP+UkJHvQDHcWXusikPisCV7Ui4N
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: iabrFiwKvGkQrp4HCnq03XzGhA4+0DmWE3LQWanf1QciZdWcmxY3j1yvT03bZU5uyYRXr3SY+D
 Hex5fJbqJPan8kqZK3eJ7MQ/mHQ/s9Qx5ffrt0Zxqw+X17X/6Vkc12U5/GLdoDBbWrXznktVQ5
 tqOc9yiG2Haek+LibX+tQNNO652oFRFJ4hKWYwiusUVfBBoKM9xTfUMjRJBsnergzZIhfdsoDE
 GZ67+5zo6eRv/IJ/arCW7BM/JtzTshJVFAWDoFkWohEgPG0lsG5LvnzQXgraUwAnmbxnhBciu0
 rL6Ry2qh8Swzjd2Eo/lpG1iJ
X-SBRS: 5.1
X-MesageID: 59370667
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:naf2Oa/6aCwNHzb+Ud8ZDrUDZnmTJUtcMsCJ2f8bNWPcYEJGY0x3n
 WFOXDuHP/bZY2GjKYx0bt63pEkBsJKBz4c3HQc/rXg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgrw
 +xUvqPhQz0FN4zvpacTSDJXAgNxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0fRqmGO
 ZRGAdZpREidRRRWIg0mNIsBwf+DpFrDSyBXomvA8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSAzRKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 0US5iopq7l07EGxR8PxdxK9qX+A+BUbXrJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeHzcTz
 1S2ztnTKTVOk4DWR2m2+aa2ombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2v0/sChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU
 JTpdqGjAAEy4XOlyXXlrAYlRujBCxO53Nv02wQH834JrWvFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtzqW5twnPW6T4q6Bpg4i+aihLArLmdrGwk0OiatM53FyhBwwcnTx
 7/FGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo
 r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l9UaKMmu14JNQ+90mX/8+Rl
 kyAtoZj4AKXrRX6xc+iMBiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:jMc7gKOE7fDIqsBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370667"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 34/57] tools/xcutils: rework Makefile
Date: Mon, 6 Dec 2021 17:02:17 +0000
Message-ID: <20211206170241.13165-35-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Use TARGETS to collect targets to build

Remove "build" target.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xcutils/Makefile | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/tools/xcutils/Makefile b/tools/xcutils/Makefile
index 82d42624c8..198be22a5a 100644
--- a/tools/xcutils/Makefile
+++ b/tools/xcutils/Makefile
@@ -11,7 +11,7 @@
 XEN_ROOT	= $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-PROGRAMS = readnotes lsevtchn
+TARGETS := readnotes lsevtchn
 
 CFLAGS += -Werror
 
@@ -19,10 +19,7 @@ CFLAGS_readnotes.o  := $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl) $(CFLAGS_libx
 CFLAGS_lsevtchn.o   := $(CFLAGS_libxenevtchn) $(CFLAGS_libxenctrl)
 
 .PHONY: all
-all: build
-
-.PHONY: build
-build: $(PROGRAMS)
+all: $(TARGETS)
 
 readnotes: readnotes.o
 	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(APPEND_LDFLAGS)
@@ -31,17 +28,17 @@ lsevtchn: lsevtchn.o
 	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS)
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	$(INSTALL_PROG) $(PROGRAMS) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_PROG) $(TARGETS) $(DESTDIR)$(LIBEXEC_BIN)
 
 .PHONY: uninstall
 uninstall:
-	rm -f $(addprefix $(DESTDIR)$(LIBEXECDIR)/, $(PROGRAMS))
+	rm -f $(addprefix $(DESTDIR)$(LIBEXECDIR)/, $(TARGETS))
 
 .PHONY: clean
 clean:
-	$(RM) *.o $(PROGRAMS)
+	$(RM) *.o $(TARGETS)
 	$(RM) $(DEPS_RM)
 
 .PHONY: distclean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239481.415216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSm-0001dq-Ho; Mon, 06 Dec 2021 17:07:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239481.415216; Mon, 06 Dec 2021 17:07:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSl-0001Zt-T3; Mon, 06 Dec 2021 17:07:39 +0000
Received: by outflank-mailman (input) for mailman id 239481;
 Mon, 06 Dec 2021 17:07:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOj-0005ta-Vz
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:30 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6efd5052-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6efd5052-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810208;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=xZ8A4jgJ4Y38L4d9figc1Ddx9Yxc2qvFPaFW8MGy500=;
  b=HnkWPBaHObDBKQwgG5LZ6gF08fvqp4yXg/JWzUjs0elW+cWrkaEbTFFM
   lRnVjHUeBlqPm7ynSX6hTYLRZ2WS8mowd0T2NIrLPqr81bMM5OYR5GO3v
   T1M6aQZDqOVYNmRUK//BkZ9HqC0aSfq7PEajrbbZNxY3VlKSK9w8szB5l
   4=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: repNzCQmembTuxtYYe4kLpCJIOHAMIBVWfcZn6aJyjwy5jPOmG9aQICne92kvFmNGgFtXLKp3n
 J0k6mD2z5fwGo2FZiB5SOJtEy0jwpEpEqbmBJLHgzazVhg73dwAxy9WdFEeHnVv8xAa2iPwp47
 NFC9lTisWdhTLf5T7wMRr8z93+0fDD8T18a2OaYh6Wg/3hrqV2nav42XO+SgKlmcviVV2yQuCo
 AdsAwb7LMuUmKbv95RgPzBVDkIdTPXyAH4mKnvinjCIzksaOgCbbQ1PVy0kgUoK8gqUIiRoJtn
 V9sY3/Bpepaie9d3RCe9Vi98
X-SBRS: 5.1
X-MesageID: 61420633
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OZlPaa6fPS2ASOrKJYN37wxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 mAWW2+DPqmNa2LxeYglati3oBwF68DWnNJqHVZrpCFhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 NFVhbq8WwITLqT0xOAtAkdADAUvBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRKqEP
 5RCMlKDajzwbgEIP21ULqkOs7qi3GvAI2FIonmK8P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2Qd/DYuqq4jslSmVNDnUzW3pXeFulgXXN84LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobWAuz
 m+vk8HsPyxmiOGReSPD7qiw/ArnbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr1/sCRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1
 JTodiX30QzvMX1vvHHUKAnuNOvwjxpgDNE6qQQ1d3XG327yk0NPhagKvFlDyL5Ba67ogwPBb
 k7Joh9275ROJnasZqIfS9vvUJR1l/m9T467CaC8gj9yjn5ZLlXvEMZGPxH44owQuBJ0zfFX1
 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI50/P7FZqX1bMEe1tGALXNogRtfrYyC2Io
 4c3H5bbkH13DbyhChQ7BKZOdDjm21BgXsuowyGWH8beSjdb9JYJV6WMnOh/ItM9xMy4VI7gp
 xmAZ6OR83Kn7VWvFOlAQioLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:WoN1567+X5EqBYCxqQPXwMLXdLJyesId70hD6qhwISY7TiX+rb
 HKoB17726StN9/YhAdcLy7VZVoIkmsl6Kdg7NwAV7KZmCP0wGVxelZnO/fKlbbdREWmNQw6U
 4ZSdkcNOHN
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420633"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 17/57] tools/xl: Remove unnecessary -I. from CFLAGS
Date: Mon, 6 Dec 2021 17:02:00 +0000
Message-ID: <20211206170241.13165-18-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

GCC will search the directory where the source file is for
quote-includes.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xl/Makefile b/tools/xl/Makefile
index 656b21c7da..2e129f00e1 100644
--- a/tools/xl/Makefile
+++ b/tools/xl/Makefile
@@ -7,7 +7,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS += -Werror -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
-CFLAGS += -I. -fPIC
+CFLAGS += -fPIC
 
 CFLAGS += $(PTHREAD_CFLAGS)
 LDFLAGS += $(PTHREAD_LDFLAGS)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239482.415223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSn-0001qP-3l; Mon, 06 Dec 2021 17:07:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239482.415223; Mon, 06 Dec 2021 17:07:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSm-0001lR-HQ; Mon, 06 Dec 2021 17:07:40 +0000
Received: by outflank-mailman (input) for mailman id 239482;
 Mon, 06 Dec 2021 17:07:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPo-0005ta-Kr
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:36 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95c7e7e0-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95c7e7e0-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810275;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=e1NkHAQPfUnAtHDePdITPlx+ldg10pRV4o24t5c0gJk=;
  b=O3f6icxWvYVrM0z4Wa29/2DAIPr9tWzzBhN5nxJr/wQTbIL2bCLW/oy4
   PdH8VLCD3Dzdp8gm0LHUn/iL9GoKwscHYNWAQLByw7CG9Ghx7LtlLv7Kx
   qGx690gjq6bsk9z2fSOuI5G0NQRE+RNLaZb2/yONvrO+3VzVtywlKOyfl
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: YdG7wedAVNPucWIF4lx8DrQU/DiJl0Mh2wZ06U+Eud91fHe24OImndvWB4o7ou1i+MQLJiWHpx
 QRrJ661YgHjG2u/Nn349JE77F5HGHXN+AByoZGY8hIrKQs8/M6CQGCdTEcN1Obx+hEEJIaATMF
 hpKEb88BfzPv8VQehCniew98sW2E7uhAonnxPdLbrpmpKSY2E3C6xMZEPGNmat4wPBfSf4hFft
 8CdlkXXFgTk0VT8xWGLXXHFLc0gb95C6Yp+MOu5T7zao+qIWZkiE+Cj8DVXkIu/7+D8Wimjtbv
 ySny5v8Wflm252tJ6klHBA6Z
X-SBRS: 5.1
X-MesageID: 59388021
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OBHA4KKSBFpFt4b6FE+RIJIlxSXFcZb7ZxGr2PjKsXjdYENS1TcPx
 2EbCzqBa63eNmD3eNl/YIS//U1U65GBnIIxG1RlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Og4lu4
 ttdmaDscjUwBPbSm9kkSUBxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph3ZAeRayHD
 yYfQTxfVhicSQZhBhQeLJ0+wtqi2Sf7LSIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 G3c+H/iKgoHL9HZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVVhukoHmCr1gEVsBZCeES5wSEy66S6AGcblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpWSVSuC3LmEgQ/uAhoMFzQcZhI9V1IstoyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNt1shPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWB2DaD/LF7rlxBHkJPm6gKulmSw28zba45lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIEePcIgKVXdon4+DaJ144wLuBJ2+U3YE
 c3EGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivruSo
 yzmBBYHkAGXaL+uAVziV02PoYjHBf5XxU/X9wRwVbpx83R8M4up8okFcJ47Iesu+OB5lKYmR
 PgZYcSQRP9IT22fqTgaaJD8qq1kdQiq2l3Sb3b0PmBncs4yXRHN9//lYhDrqHsEAB2ouJZsu
 LanzA7aH8YOHlwwEMbMZfuz5FqtpnxByvlqVk7FL4ALKkXh+YRnMQLrifozL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSDpzit245NVuqMbAvxbmKs9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy7IF6wu7X
 kWDpotTNbmTYZ63FVcQIEwub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4YNE/3
 OMsmM8K8Aju2BMlP+GPgj1Q62nRfGcLVL8qt81CDYLm4ubxJoquvXAI5vfK3ayy
IronPort-HdrOrdr: A9a23:6IJ9mKMWWMMOQMBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59388021"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 49/57] libs/toolcore: don't install xentoolcore_internal.h anymore
Date: Mon, 6 Dec 2021 17:02:32 +0000
Message-ID: <20211206170241.13165-50-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

With "xentoolcore_internal.h" been in LIBHEADER, it was installed. But
its dependency "_xentoolcore_list.h" wasn't installed so the header
couldn't be used anyway.

This patch also mean that the rule "headers.chk" doesn't check it
anymore as well.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/toolcore/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 632048c899..360a10e5da 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -5,7 +5,7 @@ MAJOR	= 1
 MINOR	= 0
 AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
-LIBHEADER := xentoolcore.h xentoolcore_internal.h
+LIBHEADER := xentoolcore.h
 
 OBJS-y	+= handlereg.o
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239492.415252 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSr-0002yP-Lh; Mon, 06 Dec 2021 17:07:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239492.415252; Mon, 06 Dec 2021 17:07:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSr-0002wC-29; Mon, 06 Dec 2021 17:07:45 +0000
Received: by outflank-mailman (input) for mailman id 239492;
 Mon, 06 Dec 2021 17:07:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOa-0005ti-Li
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:20 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 689c9f84-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 689c9f84-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810199;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=o+VIkl7f43OW2o365l1olvv7vAkXSoY1AlwWimrAG00=;
  b=THkylvUyJ5DCfhEqb6RvhlFWZay+kQisAdmvxQvS+giF4tH/D13Cob/n
   BXOXXVMDL6hJ58W81RgkQasX3nUwpQEz4Gnu7ojGdoTmozwuXWTXdCLpn
   34ZHaW6fouxbRc5Wc1D4e+/TMUsK9hwwyH6+VL/J5L6cRfxdb/E5Caok8
   k=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0u3+9w6TGNhrEv6BTnCAmsn0lu//TRr+GLUBiUyj5sWVevqLmlzTFlq60tqodiJ4DpEl4WBbVD
 mBSA/JV/bsdIHKk8KmvM+AH4BsGEYCUjMRhizOEECYvPUM7UmOj1nFAR/IoUOUcuFj3fezBwoN
 kPb/MYMaAA+UwUPBhJjAIPq5v48XlOP0Bz1k70HePCxfVQj4D41yWnzisQ3eJp4/TqZ0I/WFxu
 sOs7snehAiFw2E40cZY6HNh0kVrvX6pBQxnfqYLEzmifHJ/nk0dYtf5JnNJb+K2ywYfsyhKu8h
 9tijHoiQOyz2cTa8VMoWX5/V
X-SBRS: 5.1
X-MesageID: 59387780
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0tTLJKBZwyv3zhVW/8/kw5YqxClBgxIJ4kV8jS/XYbTApDh00WYGy
 2AaDzrSOKmPZjD2c9Fxa4rj9EoB7ZCEyIBqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/lQvSjfNsw
 oV3tI2MSSYTPvySieU3akwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWxg2Z8eRZ4yY
 eIEUwJTNzLcQiZTBWkHU6t5oOSFqkLGJmgwRFW9+vNsvjm7IBZK+LnyMvLFd9qSX8JXk02E4
 GXc8AzRHRUyJNGZjz2f/RqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma3Xc5fL
 EoFvDIjt6Eo+GSkS9D8W1uzp3vsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQMIY790VWDZ67
 F6Yo9PIPzw+7qyUY0vIo994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3ipQif6w9AsKQlWeLcCu//emu+pj10a4e+D2BDwQiKtK0QRGp1o7Tog
 ZTlpyR8xL1XZX1uvHbUKAnoIF1Pz6zfWNE7qQQwd6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0Nv8oOdPsUZ50kviI+THZuhb8NIAmjn9ZLlDvwc2TTRTIgzCFfLYEz8nTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvPLsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmrflA7RTp/UqCJmtvMueVNxsxoqwsBx
 VnlMmcw9bY1rSavxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:p5n6PK3LpLGMJROv8H3UUAqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387780"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 12/57] tools: remove some unneeded subdir-distclean-* targets
Date: Mon, 6 Dec 2021 17:01:55 +0000
Message-ID: <20211206170241.13165-13-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Those two are already covered by subdir-distclean-% target in
Rules.mk.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Makefile          | 3 ---
 tools/firmware/Makefile | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 757a560be0..8936b754c8 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -296,9 +296,6 @@ subdir-uninstall-debugger/kdd: .phony
 subdir-all-debugger/kdd: .phony
 	$(MAKE) -C debugger/kdd all
 
-subdir-distclean-firmware: .phony
-	$(MAKE) -C firmware distclean
-
 subtree-force-update:
 ifeq ($(CONFIG_QEMU_XEN),y)
 	$(MAKE) qemu-xen-dir-force-update
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 1f27117794..345037b93b 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -85,9 +85,6 @@ clean: subdirs-clean
 .PHONY: distclean
 distclean: subdirs-distclean
 
-subdir-distclean-etherboot: .phony
-	$(MAKE) -C etherboot distclean
-
 subdir-distclean-ovmf-dir: .phony
 	rm -rf ovmf-dir ovmf-dir-remote
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239493.415259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSs-00037f-UR; Mon, 06 Dec 2021 17:07:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239493.415259; Mon, 06 Dec 2021 17:07:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSr-00034S-QU; Mon, 06 Dec 2021 17:07:45 +0000
Received: by outflank-mailman (input) for mailman id 239493;
 Mon, 06 Dec 2021 17:07:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPP-0005ti-0k
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:11 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8684aff7-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8684aff7-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810249;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=HYzxa9IJ0gs1g2ZQBPATfpRkikT39MPJWLs4P8HFYcY=;
  b=RaWmFIHpTc4H59/E6Q1dMIU1PaQZmh1v41GwfSd1VaIK4BmzwInlVtot
   eNSDNeaoY8jFW/bvdELpxoOnBY5ZIDbHavizOWf5S5lHuz5e26phP7jna
   Aaz+ncRTQBiDBLLoLi9Gs7UtHoPAOvkxNA9b1M55KOVgax7jjeqDh1nY5
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PMFEPc+L8bkSjMM1BsImfIQ/8HRwMqQdH5O+591xy3I2KyxaSv59Y3B/fEAZqVJOsHufkVvtZo
 9IxObt2WtsY2qFYZ6TZYMhI5sHUZzuX+S3Zy3CIE03FdM6MPUIsoPDEgDSWLqeg/f5Mh3yArCm
 qKe67eEpZ9DvkE4VMU8RvC+vDdSUQ6p2byrW/k7qUAvRHrA++PPfN3y5tNMGVwQanE0iAQdnAA
 UH7sL84CMfG9fASDgSrsyrB22fLgkPh750njAnvHRlpewf7hb+9bbjQdIObYEiv4s1SXvAnOt1
 6ZHC1rebJ9FUWTJF6Ahiod54
X-SBRS: 5.1
X-MesageID: 61420789
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+sF+Z6Oe3UH/4cnvrR1DkMFynXyQoLVcMsEvi/4bfWQNrUon0jEGn
 WQXXT2BOPnbYzH8ed1xPoXj9UtXuMPdnN9rGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En5400o9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2Wrg9l7w
 ttzjrjucAEkb/KPkbVaSgYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm5s3JgRTae2i
 8wxYCFyVSjmXQV0H3wuKo4inb6ln2X2bGgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKg4eHMySz3yC6H3Erv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWUtRDK
 0sS62w2oLI77kCDQdz0Xhn+q3mB1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvR2ltM/TzYk6
 GStwervCG0w87TEDmuCo+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0ISrRGiYL
 ySi6XFn2u5N1ZJjO7CTpAif21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTVPlhdwTXGY3h+Y1FAd7falUwZnY1QPEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/QnPNjgVp5wk/ewfTgAahwyRoAUCnSWXFXYlByCmGbKhzy9+KTSuf9X1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY8RTx6VaaOmehJlk4Mt/09q9okN
 0qVAidwoGcTT1WdQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:Od3UPKqI97AP6oVSHMwMHv8aV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420789"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 37/57] tools/xentop: rework makefile
Date: Mon, 6 Dec 2021 17:02:20 +0000
Message-ID: <20211206170241.13165-38-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Add "xentop" to "TARGETS" because this variable will be useful later.

Always define all the targets, even when configured with
--disable-monitor, instead don't visit the subdirectory.
This mean xentop/ isn't visited anymore during "make clean" that's how
most other subdirs in the tools/ works.

Also add missing "xentop" rules. It only works without it because we
still have make's built-ins rules and variables, but fix this to not
have to rely on them.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Makefile        |  2 +-
 tools/xentop/Makefile | 19 ++++++++-----------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/tools/Makefile b/tools/Makefile
index 79b4c7e3de..0c1d8b64a4 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -17,7 +17,7 @@ SUBDIRS-$(CONFIG_XCUTILS) += xcutils
 SUBDIRS-$(CONFIG_X86) += firmware
 SUBDIRS-y += console
 SUBDIRS-y += xenmon
-SUBDIRS-y += xentop
+SUBDIRS-$(XENSTAT_XENTOP) += xentop
 SUBDIRS-y += libfsimage
 SUBDIRS-$(CONFIG_Linux) += vchan
 
diff --git a/tools/xentop/Makefile b/tools/xentop/Makefile
index 0034114684..1e52b29b37 100644
--- a/tools/xentop/Makefile
+++ b/tools/xentop/Makefile
@@ -13,24 +13,23 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-ifneq ($(XENSTAT_XENTOP),y)
-.PHONY: all install xentop uninstall
-all install xentop uninstall:
-else
-
 CFLAGS += -DGCC_PRINTF -Werror $(CFLAGS_libxenstat)
 LDLIBS += $(LDLIBS_libxenstat) $(CURSES_LIBS) $(TINFO_LIBS) $(SOCKET_LIBS) -lm
 CFLAGS += -DHOST_$(XEN_OS)
 
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
-LDFLAGS += $(APPEND_LDFLAGS)
+
+TARGETS := xentop
 
 .PHONY: all
-all: xentop
+all: $(TARGETS)
+
+xentop: xentop.o
+	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: install
-install: xentop
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
 	$(INSTALL_PROG) xentop $(DESTDIR)$(sbindir)/xentop
 
@@ -38,11 +37,9 @@ install: xentop
 uninstall:
 	rm -f $(DESTDIR)$(sbindir)/xentop
 
-endif
-
 .PHONY: clean
 clean:
-	rm -f xentop xentop.o $(DEPS_RM)
+	rm -f $(TARGETS) xentop.o $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:07:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239496.415279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSx-0004LM-CO; Mon, 06 Dec 2021 17:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239496.415279; Mon, 06 Dec 2021 17:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHSx-0004Jc-4f; Mon, 06 Dec 2021 17:07:51 +0000
Received: by outflank-mailman (input) for mailman id 239496;
 Mon, 06 Dec 2021 17:07:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOn-0005ta-2J
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:33 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ff0ced6-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ff0ced6-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810211;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=O21sRR07hYjYj9vZuB9LwkDXcVWb8j2cB7UEoDG9SQo=;
  b=gzQISgmCBs5jFoLRLGEge8hR6s8xJ/7YGN9xFVAox3wghdopMpD6fcjw
   Bp1IPN6H/445TC/ZnlAam5aFBLy58BiU/h6MpfUMPk/BNEcZV3Ju0wAxc
   qlkEI4JCvTh/jXhcnB4/WQme1yZay7c/BzLiRHZIl0ZIsEMZGuQj0c8xS
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: oZfcFkjPoi6ndXydETePffndu0po/Iso82qr0s/mXfuc2V1tiZVOzKp1GOqx0G+Jtv07mUwSR9
 /U5HLCvRDYG7kLXyHHh6fJkL0NYnt5/rrKSmKlO9WWeaXFJrBUztWpASrL9HTpT4SMBJ8cx6kG
 ZKrmxi52a2VBPi2BtDqLFxl3TUYcUhxNNuUOYg71jBFeYO3l7PdxcB1PxbEUhKl4Q17oyaFgSt
 uheY96XsUd1RKqR84dNTFkXcFqxmRMZqdtL6uUe7LtnsIGx6oGAsPFkJkVfOa2/hD0ghHAKU+N
 qCPj7LOGOwni5OlqqHTJ8Gu7
X-SBRS: 5.1
X-MesageID: 59766382
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5SPthq6GHf8bIFRZ2URFjwxRtMrAchMFZxGqfqrLsTDasY5as4F+v
 mtLUTqEOPbZYDH8eNF3bNu29R9X6JaGmtdgQQJvrio3Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk
 dBWkJqUGSYQIKDnyMoBdEBAPzpwMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTKmAO
 ZFJM1KDajybXSNOOmc0D6kcgb3zhWPATzcGmVCs8P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTWogfCbm5/f5Cm0CIyyoYDxh+fUu2p7y1h1CzX/pbK
 lcI4Ww+oK4q7kupQ9LhGRqirxastxgAW91WAqsi5RuE0Kb87AOQB2xCRTlEAOHKr+dvG2Zsj
 AXQ2Yq0W3o/69V5VE5x6J/NqCiXPwxFDFYcaARUYxciusHPu48820enoslYLIa5idj8GDfVy
 j+MrTQji7h7sfPnx5lX7nic3Wvy+8Ghohodo1yOAzn7tl8RiJuNPtTwsTDmAeB8wJF1p7Vrl
 FwNgICg4e8HFvlhfwTdEbxWTNlFCxtoWQAwYGKD/bF8rlxBGFb5JOi8BQ2Swm8zaK7onhezP
 yfuVft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlTXo3s/OBTKgT+9+KTJrU3ZE
 c3BGSpLJSxFYZmLMRLsH7tNuVPV7n5WKZzvqWDTkE38jOv2iI+9QrYZKlqeBt3VH4vfyDg5B
 +13bpPQoz0GCbWWSnCOreY7cABbRVBmVMueg5EGKYa+zv9ORThJ5wn5muh6JeSIXs19y4/1w
 51KchMClQek2ySYcV7ih7IKQOqHYKuTZEkTZUQEVWtEEVB5Me5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:vHcYuK+g+3P0knOV80Fuk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766382"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Jan Beulich <jbeulich@suse.com>, Ian Jackson
	<iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 15/57] tools/libacpi: cleanup Makefile, don't check for iasl binary
Date: Mon, 6 Dec 2021 17:01:58 +0000
Message-ID: <20211206170241.13165-16-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

iasl is been check for presence by ./configure, so this Makefile
doesn't have to do it. Also start to use $(IASL) that ./configure
generate.

iasl hasn't been download by our build system for a while and the
dependency on iasl is in the main xen.git README.

Make use of $< in one rule instead of spelling the %.asl file again.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libacpi/Makefile | 17 ++++-------------
 tools/libacpi/README   |  6 ------
 2 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/tools/libacpi/Makefile b/tools/libacpi/Makefile
index 2448687dbb..60860eaa00 100644
--- a/tools/libacpi/Makefile
+++ b/tools/libacpi/Makefile
@@ -38,11 +38,10 @@ MKDSDT_CFLAGS-$(CONFIG_X86) = -DCONFIG_X86
 # complete $(ACPI_BUILD_DIR) as path, even if it has '.' symbols.
 TMP_SUFFIX	= tmp
 
-vpath iasl $(PATH)
 all: $(C_SRC) $(H_SRC)
 
-$(H_SRC): $(ACPI_BUILD_DIR)/%.h: %.asl iasl
-	iasl -vs -p $(ACPI_BUILD_DIR)/$*.$(TMP_SUFFIX) -tc $<
+$(H_SRC): $(ACPI_BUILD_DIR)/%.h: %.asl
+	$(IASL) -vs -p $(ACPI_BUILD_DIR)/$*.$(TMP_SUFFIX) -tc $<
 	sed -e 's/AmlCode/$*/g' -e 's/_aml_code//g' $(ACPI_BUILD_DIR)/$*.hex >$@
 	rm -f $(addprefix $(ACPI_BUILD_DIR)/, $*.aml $*.hex)
  
@@ -74,21 +73,13 @@ $(ACPI_BUILD_DIR)/dsdt_anycpu_arm.asl: $(MK_DSDT)
 	$(MK_DSDT) --debug=$(debug) >> $@.$(TMP_SUFFIX)
 	mv -f $@.$(TMP_SUFFIX) $@
 
-$(C_SRC): $(ACPI_BUILD_DIR)/%.c: iasl $(ACPI_BUILD_DIR)/%.asl
-	iasl -vs -p $(ACPI_BUILD_DIR)/$*.$(TMP_SUFFIX) -tc $(ACPI_BUILD_DIR)/$*.asl
+$(C_SRC): $(ACPI_BUILD_DIR)/%.c: $(ACPI_BUILD_DIR)/%.asl
+	$(IASL) -vs -p $(ACPI_BUILD_DIR)/$*.$(TMP_SUFFIX) -tc $<
 	sed -e 's/AmlCode/$*/g' -e 's/_aml_code//g' $(ACPI_BUILD_DIR)/$*.hex > $@.$(TMP_SUFFIX)
 	echo "int $*_len=sizeof($*);" >> $@.$(TMP_SUFFIX)
 	mv -f $@.$(TMP_SUFFIX) $@
 	rm -f $(addprefix $(ACPI_BUILD_DIR)/, $*.aml $*.hex)
 
-iasl:
-	@echo
-	@echo "ACPI ASL compiler (iasl) is needed"
-	@echo "Download and install Intel ACPI CA from"
-	@echo "http://acpica.org/downloads/"
-	@echo 
-	@exit 1
-
 clean:
 	rm -f $(C_SRC) $(H_SRC) $(MK_DSDT) $(C_SRC:=.$(TMP_SUFFIX))
 	rm -f $(patsubst %.c,%.hex,$(C_SRC)) $(patsubst %.c,%.aml,$(C_SRC)) $(patsubst %.c,%.asl,$(C_SRC))
diff --git a/tools/libacpi/README b/tools/libacpi/README
index 2b9d6e188c..4ab5ed2de7 100644
--- a/tools/libacpi/README
+++ b/tools/libacpi/README
@@ -24,9 +24,3 @@ In case that the acpi_dsdt.asl need to be updated, please
 Follow the instruction:
 
 # make acpi_dsdt.c
-
-Note:
-DSDT compiler "iasl" is needed. By default, it will be downloaded 
-using wget in Makefile. if it failed, please download manually from 
-http://developer.intel.com/technology/iapc/acpi/downloads.htm. 
-then compile and install iasl
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239502.415298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTA-0006TS-Jt; Mon, 06 Dec 2021 17:08:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239502.415298; Mon, 06 Dec 2021 17:08:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTA-0006SP-B8; Mon, 06 Dec 2021 17:08:04 +0000
Received: by outflank-mailman (input) for mailman id 239502;
 Mon, 06 Dec 2021 17:08:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHP5-0005ta-6k
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:51 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a879e1f-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a879e1f-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810229;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=BHKgdcCFIcw2aiewzH6pZ1uVlVigf4URrqTZQIJcZwI=;
  b=aWAlpeRPquChvIDdxnpX6wHzzAIuOAEFMGyzOUu1kshr98uix1niOO02
   55uxkwsBg3xRDiVDXqp2nIIKi2U76ClZ4lWm0xk44Ejxdsa5104jU/pNJ
   aalJ27VffPoTTKSKKCGfT4i4vU8i4IhyQ3jmmfwWpS8x2eZLOPfuYkvJ9
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: awMe2UEYGgJ6YVSNJTcx4uOQBPZtcMozEo6Gb0XSc5/gjJpI/J1x5WSIwh5RKy0Sst6+qLRvHY
 +kvYfuB/0MtGUz2UzWeeoaJSPcFPAM6+dV82njyVa/NqTe0mV2aiTfMhqadskkpyaY6mSgk2VB
 qsXkg38jpOkufAuoZeWpSIJh9IYqG1RIsol4Db+vogdA9jzn2r5aqrglEFYLgcLcOH1HccN5x6
 BF5SsHhzI6K9Yh3I5cXWZ7XQ0PT2n9/Oilfr1yT4gl7EArt4aoZPK0LYMuB44+tE6dUIgptUGn
 25SxMsOVel72n0dmof0BCmui
X-SBRS: 5.1
X-MesageID: 59324094
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:o7nY7azFhEaYtWPCfgh6t+eswSrEfRIJ4+MujC+fZmUNrF6WrkVSy
 WYeDD+BO6mNNzHwe95yPN+y/RhX6JfWm9FmGlNrpCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wbZn2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt4Eo+
 e1ui4eecgwKFIqLnu88bDBUFRgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25EVR6qGN
 pZxhTxHSBXyXw1kKkksBbUejOjr33PdfRYCtwfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRGQoGPdaSzT6E9HOEheLVmy7/HoUIG9WQ6fpCkFCVgGsJB3U+V1G2vP24gU6WQM9EJ
 gof/S9Ghbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xD24YTjlHeZo+udU/XzAC2
 VqAntevDjtq2JWUVnC15rqStSm1OyUeMSkFfyBscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6
 2HTnRAdua49tsUo/YL8+1vmvBugoKGcG2bZ+T7rdm6i6wp4YqusaIqp9UXX4J58EWqJcrWSl
 CNawpbDtYjiGbnIzXXQG7tVQNlF8t7caGWE6WODCaXN4NhEF5SLWYlLqA9zK05yWirvUW+4O
 RSD0e+9CXI6AZdLUUOVS9/oYyjJ5fK5fTgAahwyRoAUCnSWXFXYlByCnWbKgwjQfLEEyMnTw
 6uzf8e2Fmo9Aq961jewTOp1+eZ1nXBhnzKOH8qlkETPPV+iiJi9E+1t3LymNL9R0U95iF+Nr
 4Y32zWilX2zr9ESkgGIqNVOfDjm3FAwBIzsqtw/SwJwClEOJY3VMNeImelJU9U8x8x9z76Ul
 lngCh4w4Aeu3hXvdFTVAk2PnZuyBP6TW1pgZndyVbtpslB+CbuSAFA3K8FqIOJ5rbM7lpaZj
 ZAtIq29PxiGcRyfkxx1UHU3hNAKmM2DiV3cMiy7TiI4epI8FQXF9sW9Jlnk9TUUDzrxvsw7+
 uXy2gTeSJsFZgJjEMeJN67/kwLv5SAQyLBoQk/FAthPY0GwooJkHDP8060sKMYWJBSdmjbDj
 1SKAQ0VrPXmqpMu9IWbnriNqoqkSrMsHkdTE2TBw6yxMC3WojiqzYNaCb7adjHBTmLkvq6lY
 LwNnf37NfQGmndMspZ9TOk3nf5vuYO3quYDnAp+HXjNY1C6MZ9aIyGLjZtVq6lA5r5Fog/qC
 EiBzcZXZOeSM8T/HV9PeAd8Nraf1esZkyX55OguJBmo/zd++beKXBkAPxSIjyABfrJ5PJl8n
 LUksc8SrQe+lgArIpCNiSUNrzaAKXkJUqMGsJAGAdC01lp3mw8aOZGMWDXr5JyvaslXNhh4K
 zCZs6POmrBAyxeQaHE0D3XMgbJQiJlmVMqmF7Pey4BlQub4u8I=
IronPort-HdrOrdr: A9a23:N+xA662ldZKWd4fSpzOQyQqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324094"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 27/57] tools/fuzz/libelf: rework makefile
Date: Mon, 6 Dec 2021 17:02:10 +0000
Message-ID: <20211206170241.13165-28-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rename ELF_LIB_OBJS to LIBELF_OBJS as to have the same name as in
libs/guest/.

Replace "-I" by "-iquote".

Remove the use of "vpath". It will not works when we will convert this
makefile to subdirmk. Instead, we create symlinks to the source files.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore                 |  1 +
 tools/fuzz/libelf/Makefile | 21 ++++++++++-----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index c31fa9b841..4267bb4dee 100644
--- a/.gitignore
+++ b/.gitignore
@@ -197,6 +197,7 @@ tools/flask/utils/flask-setenforce
 tools/flask/utils/flask-set-bool
 tools/flask/utils/flask-label-pci
 tools/fuzz/libelf/afl-libelf-fuzzer
+tools/fuzz/libelf/libelf-*.c
 tools/fuzz/x86_instruction_emulator/asm
 tools/fuzz/x86_instruction_emulator/afl-harness
 tools/fuzz/x86_instruction_emulator/afl-harness-cov
diff --git a/tools/fuzz/libelf/Makefile b/tools/fuzz/libelf/Makefile
index 9eb30ee40c..9211f75951 100644
--- a/tools/fuzz/libelf/Makefile
+++ b/tools/fuzz/libelf/Makefile
@@ -1,25 +1,24 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-# libelf fuzz target
-vpath %.c ../../../xen/common/libelf
-CFLAGS += -I../../../xen/common/libelf
-ELF_SRCS-y += libelf-tools.c libelf-loader.c libelf-dominfo.c
-ELF_LIB_OBJS := $(patsubst %.c,%.o,$(ELF_SRCS-y))
+LIBELF_OBJS := libelf-tools.o libelf-loader.o libelf-dominfo.o
 
-$(patsubst %.c,%.o,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
-
-$(ELF_LIB_OBJS): CFLAGS += -DFUZZ_NO_LIBXC $(CFLAGS_xeninclude)
+CFLAGS += -iquote ../../../xen/common/libelf
+$(LIBELF_OBJS): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS): CFLAGS += -DFUZZ_NO_LIBXC $(CFLAGS_xeninclude)
 
 libelf-fuzzer.o: CFLAGS += $(CFLAGS_xeninclude)
 
-libelf.a: libelf-fuzzer.o $(ELF_LIB_OBJS)
+$(LIBELF_OBJS:.o=.c): libelf-%.c: ../../../xen/common/libelf/libelf-%.c FORCE
+	ln -nsf $< $@
+
+libelf.a: libelf-fuzzer.o $(LIBELF_OBJS)
 	$(AR) rc $@ $^
 
 .PHONY: libelf-fuzzer-all
 libelf-fuzzer-all: libelf.a libelf-fuzzer.o
 
-afl-libelf-fuzzer: afl-libelf-fuzzer.o libelf-fuzzer.o $(ELF_LIB_OBJS)
+afl-libelf-fuzzer: afl-libelf-fuzzer.o libelf-fuzzer.o $(LIBELF_OBJS)
 	$(CC) $(CFLAGS) $^ -o $@
 
 # Common targets
@@ -31,7 +30,7 @@ distclean: clean
 
 .PHONY: clean
 clean:
-	rm -f *.o .*.d *.a *-libelf-fuzzer
+	rm -f *.o .*.d *.a *-libelf-fuzzer $(LIBELF_OBJS:.o=.c)
 
 .PHONY: install
 install: all
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239499.415292 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTA-0006NZ-4J; Mon, 06 Dec 2021 17:08:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239499.415292; Mon, 06 Dec 2021 17:08:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHT9-0006MS-TV; Mon, 06 Dec 2021 17:08:03 +0000
Received: by outflank-mailman (input) for mailman id 239499;
 Mon, 06 Dec 2021 17:08:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPP-0005ti-Vf
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:12 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 874d5a64-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 874d5a64-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810250;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=e7pmrxgtWsIGIZ5tVVe5aoQ7uLgeznvSpyvXPWFCwoA=;
  b=U8iOup8OIC6OdKMBp2RdqRnQUHMgPH0UsTrO6XUIgCy7qzJuUzx8E8vU
   hACVIrLzgxnWL1YBD4hMeaSmW4PzWrt3YUwT7Cdu/vteYLQzHc1dQ5ibG
   J0AvWQV79FYterrX7Z/LbdQtIAZRrtnn7x30fTE2rWpXiizEIH/moqpIz
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: TPSJXAen5poGq0NHSgj7d/Jrn9ofLRQWYiFXY8kBD3h9KB36fb4n+zT5yrt9qb1SDA0/ErZYzw
 PAU/Npr2QWPPwApgVzC2LxL8GI2q3AtgKgAb584tjQPndOJAB+sMKYpIk7KwdksB7To0LApOQr
 kfx8Uq9NJCt81RUrxkfInf1/j9Y9E02Kr5mh8CrMMEz+WHKpfQTPLPgv0VTNTIUpP75nM70CQO
 WhqqE5e9KQXCC3rWbMBvlgJSo8PjYLSoteH5iozCCqn4m4h0Ck6Y2OIiVQ9aQyCluNlnbBaMWy
 KIESkAOsddjuH5SIg80wvc1J
X-SBRS: 5.1
X-MesageID: 59766522
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:AdWoLq5ARxueqiCzJq8cogxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 mMZXGiHPP6NNGKnctt2bojn80sOsJ+Ay9dnHQVpqSo1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 MdikZCoQh8SJ6TBluISTl5FCCdyFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTKmAO
 ZdDM1KDajznTS0VB2spEK45v+2xp1WvUydJp0m88P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2Qd/DYuqq4jslSmVNDnUzW3pXeFulgXXN84LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobRg4+
 XuFh9jxPiVmvbOTRm/a66ySoRrnbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr1/sCRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1
 JTodiX30QzvMX1vvHHUKAnuNOvwjxpgDNE6qQQ1d3XG327yk0NPhagKvFlDyL5Ba67ogwPBb
 k7Joh9275ROJnasZqIfS9vvUJR1l/m9T467CaC8gj9yjn5ZLlXvEMZGPxH44owQuBJ0zfFX1
 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI50/P7FZqX1bMEe1tGALXNogRtfrYyC2Io
 4c3H5bbkH13DbyhChQ7BKZOdDjm21BgXsuowyGWH8beSjdb9JYJV6WMnOh/ItM9xMy4VI7gp
 xmAZ6OR83Kn7VWvFOlAQioLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:R5wqNKyIjKo/IKHM+wwgKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766522"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: [XEN PATCH 38/57] tools/xenstrace: rework Makefile
Date: Mon, 6 Dec 2021 17:02:21 +0000
Message-ID: <20211206170241.13165-39-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove "build" targets.

Use "$(TARGETS)" to list binary to be built.

Cleanup "clean" rule.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xentrace/Makefile | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
index 9fb7fc96e7..2b166335dc 100644
--- a/tools/xentrace/Makefile
+++ b/tools/xentrace/Makefile
@@ -14,14 +14,13 @@ SBIN     = xentrace xentrace_setsize
 LIBBIN   = xenctx
 SCRIPTS  = xentrace_format
 
-.PHONY: all
-all: build
+TARGETS := $(BIN) $(SBIN) $(LIBBIN)
 
-.PHONY: build
-build: $(BIN) $(SBIN) $(LIBBIN)
+.PHONY: all
+all: $(TARGETS)
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(bindir)
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
 	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
@@ -43,7 +42,7 @@ endif
 
 .PHONY: clean
 clean:
-	$(RM) *.a *.so *.o *.rpm $(BIN) $(SBIN) $(LIBBIN) $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239506.415313 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTH-0007dp-QY; Mon, 06 Dec 2021 17:08:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239506.415313; Mon, 06 Dec 2021 17:08:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTH-0007dA-Lh; Mon, 06 Dec 2021 17:08:11 +0000
Received: by outflank-mailman (input) for mailman id 239506;
 Mon, 06 Dec 2021 17:08:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPX-0005ti-7H
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:19 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b818dc7-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b818dc7-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810257;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ytpv1GJ97QFgCSDKhxDlCpFXGIfYKNw5dkuyhzF8ZW0=;
  b=cB/FqGgNcRy3UFOOj1Di8R3FwJjzEUhS4FRLJwFf8pBmETMvmJC4KlsD
   cDBCDc2bbAqEIypGzI4+OATxOO2Hp2KgZ99uueF73PUGMQE7C7S+LuptL
   iBLlQcujT5BRLQtGjhUtALdmbI5vyxkhi8m7BgyLuxLOk09/GEm2LQIc5
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2a7bXfnfX/hJI9VilSP3+m6XrAQHGhSghUBZDAmP73tecoD3mRLo4lwx/Ien1avZWKkk22q8RF
 tlUfJxOEtQwShxLmVFwRsqQ45NA0/U8QMTsE8HH02kv4U8hSo4kE2kjnUYM3jodzsUhKT0DpBy
 Srm3kNMQm1oFrE59ZVJHZ/h/SHscdZ4/+gpAyrAAi/IoKUuNmlDuC3M808BbuaQsUpUpiOpikn
 pKolnkVXPfUD+EgAsp2keHtkKBQiHXfoyG1t2/sKIOqmVub/HSh1LWYFJVRuiS1ACoi5OKssFD
 bNhxCCtvOBAtQHbI/Z5pLAoY
X-SBRS: 5.1
X-MesageID: 59387971
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:UuFQTK7yYcnk/Gh1Pia83wxRtMnAchMFZxGqfqrLsTDasY5as4F+v
 mYfWGuPbq2KNjCkKo0iPdi19UMB6JLXzNZmSwBkqHs1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zm
 dhshY2WWxkSZfOSnt9HeglFUBNTIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTK2OO
 JtGMFKDajzuWj5xNEY2EKsZo6Dyp1/jQSFmrlea8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12b2GBYBL/SE1CGItHmrg4fnnDz5cJIfEqWi8fxni0HVwXYcYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHeCoh4bXcsWC+Ag4RuB4qXR6gedQGMDS1Z8hMcO7ZFsA2Zwj
 xnQwo2vVWcHXKCppWy1p7q1nSKUKzYudjFcYxReZBsYoOvOv9Rm5v7QdepLHKmwh9zzPDj/x
 TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNf9P9TA1LTN0RpXwG91pHGlt
 WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHQsBJG9eFoSfLkWVsDNdWfh0B3iEsI2CBX
 aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YqJFDdrXw0PxDPjwgBdXTAd4llY
 /93lu72Uh4n5VlPlmLqF4/xL5d1rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNDfDgicClgbbir+pM/SwJ2Clc/cI3XI6SKmu1Jlk0Mt/k9q9okC
 VnhABIFkwSm2iWcQehIA1g6AI7SsV9EhSpTFUQR0ZyAgRDPuK6js/UScYUZZ74i+LAxxPJ4V
 aBdKc6BHu5OWnLM/DFENcvxq4lrdRKKgwOSPnX6PGhjLsA4HwGZqMX5egbP9TUVCnblv8UJv
 LD9hBjQRoAORlo+AZ+OOu6v1V64oVMUhPl2AxnTOtBWdUi1qNpqJiX9g+UZOcYJLRmflDKW2
 xzPWUUTpPXXop9z+97M3PjWo4CsGup4P0xbA2iEsurmaXiEpjKumNYSXvyJcDbRUHLP1J+jP
 egFnevhNPAnnUpRt9YuGbhc0q9jtcDkoKVXz1o4ESyTPUirEL5pPlKPwdJL6v9W3rZctAa7B
 hCP991dNenbMc/pCgdMdg8sb+DF3vAIgDjCq/8yJRyitiNw+bOGV2RUPgWN13MBfOckbtt9z
 LdzotMS5iy+lgEuY4SPgS1j/miRKmANDvc8vZYADY630gcmxzmuu3AH5vMaNH1XV+hxDw==
IronPort-HdrOrdr: A9a23:JdkTsawH3TvmnH+QEREMKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387971"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 41/57] libs: Remove need for *installlocal targets
Date: Mon, 6 Dec 2021 17:02:24 +0000
Message-ID: <20211206170241.13165-42-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

There is no need for an extra "installlocal" target, we can use
double-colon rules instead.

"install-headers" in "libs/store" was introduced for the same reason
that "installlocal" exist, so it is replaced as well.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk        |  4 ++--
 tools/libs/light/Makefile | 10 ++--------
 tools/libs/store/Makefile | 10 ++--------
 3 files changed, 6 insertions(+), 18 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 91d4efeaed..7f2c676be4 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -97,7 +97,7 @@ endif
 endif
 
 .PHONY: install
-install: all
+install:: all
 	$(INSTALL_DIR) $(DESTDIR)$(libdir)
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)
 	$(INSTALL_SHLIB) lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
@@ -108,7 +108,7 @@ install: all
 	$(INSTALL_DATA) $(PKG_CONFIG) $(DESTDIR)$(PKG_INSTALLDIR)
 
 .PHONY: uninstall
-uninstall:
+uninstall::
 	rm -f $(DESTDIR)$(PKG_INSTALLDIR)/$(LIB_FILE_NAME).pc
 	for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$$i; done
 	rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 622fa04470..5e52db9b30 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -243,17 +243,11 @@ libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so
 testidl: testidl.o libxenlight.so
 	$(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS)
 
-install: installlocal $(LIBHEADERS)
-
-.PHONY: installlocal
-installlocal: libxl-save-helper
+install:: $(LIBHEADERS) libxl-save-helper
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_PROG) libxl-save-helper $(DESTDIR)$(LIBEXEC_BIN)
 
-uninstall: uninstalllocal
-
-.PHONY: uninstalllocal
-uninstalllocal:
+uninstall::
 	rm -f $(DESTDIR)$(LIBEXEC_BIN)/libxl-save-helper
 
 clean: cleanlocal
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 457122a041..1bacee6cf1 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -32,10 +32,7 @@ endif
 -include $(DEPS_INCLUDE)
 
 .PHONY: install
-install: install-headers
-
-.PHONY: install-headers
-install-headers:
+install::
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)/xenstore-compat
 	$(INSTALL_DATA) $(XEN_INCLUDE)/xenstore-compat/xs.h $(DESTDIR)$(includedir)/xenstore-compat/xs.h
@@ -44,10 +41,7 @@ install-headers:
 	ln -sf xenstore-compat/xs_lib.h $(DESTDIR)$(includedir)/xs_lib.h
 
 .PHONY: uninstall
-uninstall: uninstall-headers
-
-.PHONY: uninstall-headers
-uninstall-headers:
+uninstall::
 	rm -f $(DESTDIR)$(includedir)/xs_lib.h
 	rm -f $(DESTDIR)$(includedir)/xs.h
 	rm -f $(DESTDIR)$(includedir)/xenstore-compat/xs_lib.h
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239509.415325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTK-000855-69; Mon, 06 Dec 2021 17:08:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239509.415325; Mon, 06 Dec 2021 17:08:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTK-00084c-12; Mon, 06 Dec 2021 17:08:14 +0000
Received: by outflank-mailman (input) for mailman id 239509;
 Mon, 06 Dec 2021 17:08:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOy-0005ti-Il
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76273470-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76273470-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810222;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=vquC9c6kCd5w0itVlwryUdZY6Xf5eopjc/5kMFiENpA=;
  b=MU2UQfzsAPQsdhcN+yQpZ6Z4cvIpsW9atwYSpz+pGTMwC4J8f1bT0OUz
   nj/Agmy3Pw1rePed29tMBMkUIjfb2rho6cNFnYrYLX7kVRHcpSamknOLw
   oSZd3EOkElWCjZLj5bi/JuXs+C04sbu3EDF8fa0Avt+N9rMadka8C9grB
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: PjI0lSRzKGh+01Gm8V8MTKvNoepTO8v0kB3HtlU9u2c3s6NbxJsbdJiwRR0qBiwd2i3V0o12EI
 lcp36u0e7+ov2/gJx/NJjikO7dg7Hu+jdFtQDUDSS9X0m0UyLfC9c+j9qTizC2RlOhFhmzwlYl
 L1/1im/wLthpD+odbJ7DT+fZgRxl1NyUT9q8SUJkLja2gt4zIBGO9tMoCYVaoo0DEvGmUfaIxZ
 6mn8QyZ0SeJ2SV0/LTbbh60zhmgJu2t7G8FxEdot6UsJVC6uP4cfmcDEmHFVEXxEitI5mooLeP
 BRiLBcFuiN0b9ZXO6sqXUsAd
X-SBRS: 5.1
X-MesageID: 59370624
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LRsjCamw/ODarrNOB8UXSeXo5gxnIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeCD/Qb/beMDP8KYt/aoXnphwG6sSEyYUwHFA+qH1gHiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NBJp6K5GCsuB4Lvm/tMAxVKTjN1AqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeFO
 JJHM2YHgBLocQxIAUgZDrIFxu6FlnvDfGZVk1WHqv9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQ88ywyra805QqzQ8P0RRGQr3uNvxpaUN1Ve9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxQv0
 k23loLFAgVAk76KGCKR5OqGpgy9bH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE/8CRFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTQGY3h/5nzvp5p1QEwZ3Y1RfHNEBz3pBaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZ96kvKxSI6/CK+EBjarXnSXXFXdlM2JTRTPt10BbWB2yf1vU
 XtlWZjE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz8uYdykEW9EO9fWHPXN7hRxPrd/G39r
 oYOX+PXmk43eLCvPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6OLnO56JdU6x/89eyWh1
 ijVZ3K0AWHX3RXvQThmoFg5AF82dZog/389IwI2OlOkhyoqbYq1tf9NfJorZ7g3sudkyKcsH
 fUCfsyBBNVJSyjGpGtBPcWs8tQ6eUT5nx+KMgqkfCM7I8xqSTvW94K2ZQDo7iQPUHa67JNsv
 7262wrHapMfXAA+Xt3OYfeiwgrp73gQke5/RWXSJdxXdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YnRxhUBWjW67qyJBL2xGv7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB748cHmL2c5D6v9EyrND4FbkX
 0uO/p9ROKmTOdOjG1kUfVJ3YuOG3PASuz/T8fVqfxmquH4ppOKKARdIIh2BqC1BN78kYooqz
 NAotNMS9wHi2AEhNcyLj3wM+mmBRpDav37Lan3O7FfXtzcW
IronPort-HdrOrdr: A9a23:rrlq2a86BdzPZfMURVluk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370624"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 23/57] tools/debugger: Allow make to recurse into debugger/
Date: Mon, 6 Dec 2021 17:02:06 +0000
Message-ID: <20211206170241.13165-24-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Avoid the need for explicite rules to recurse into debugger/* dirs by
adding a Makefile in debugger/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Makefile          | 27 +--------------------------
 tools/debugger/Makefile |  8 ++++++++
 2 files changed, 9 insertions(+), 26 deletions(-)
 create mode 100644 tools/debugger/Makefile

diff --git a/tools/Makefile b/tools/Makefile
index 8936b754c8..79b4c7e3de 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -32,8 +32,7 @@ SUBDIRS-$(CONFIG_GOLANG) += golang
 SUBDIRS-y += xl
 SUBDIRS-y += helpers
 SUBDIRS-$(CONFIG_X86) += xenpaging
-SUBDIRS-$(CONFIG_X86) += debugger/gdbsx
-SUBDIRS-$(CONFIG_X86) += debugger/kdd
+SUBDIRS-$(CONFIG_X86) += debugger
 SUBDIRS-$(CONFIG_TESTS) += tests
 
 SUBDIRS-y += python
@@ -272,30 +271,6 @@ subdir-clean-qemu-xen-dir:
 
 subdir-uninstall-qemu-xen-dir: ;
 
-subdir-clean-debugger/gdbsx subdir-distclean-debugger/gdbsx: .phony
-	$(MAKE) -C debugger/gdbsx clean
-
-subdir-install-debugger/gdbsx: .phony
-	$(MAKE) -C debugger/gdbsx install
-
-subdir-all-debugger/gdbsx: .phony
-	$(MAKE) -C debugger/gdbsx all
-
-subdir-uninstall-debugger/gdbsx: .phony
-	$(MAKE) -C debugger/gdbsx uninstall
-
-subdir-clean-debugger/kdd subdir-distclean-debugger/kdd: .phony
-	$(MAKE) -C debugger/kdd clean
-
-subdir-install-debugger/kdd: .phony
-	$(MAKE) -C debugger/kdd install
-
-subdir-uninstall-debugger/kdd: .phony
-	$(MAKE) -C debugger/kdd uninstall
-
-subdir-all-debugger/kdd: .phony
-	$(MAKE) -C debugger/kdd all
-
 subtree-force-update:
 ifeq ($(CONFIG_QEMU_XEN),y)
 	$(MAKE) qemu-xen-dir-force-update
diff --git a/tools/debugger/Makefile b/tools/debugger/Makefile
new file mode 100644
index 0000000000..51efd3680b
--- /dev/null
+++ b/tools/debugger/Makefile
@@ -0,0 +1,8 @@
+XEN_ROOT=$(CURDIR)/../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+SUBDIRS-y := gdbsx
+SUBDIRS-y += kdd
+
+.PHONY: all clean install distclean uninstall
+all clean install distclean uninstall: %: subdirs-%
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239510.415331 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTL-0008DV-2k; Mon, 06 Dec 2021 17:08:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239510.415331; Mon, 06 Dec 2021 17:08:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTK-0008Bh-QC; Mon, 06 Dec 2021 17:08:14 +0000
Received: by outflank-mailman (input) for mailman id 239510;
 Mon, 06 Dec 2021 17:08:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHQ4-0005ta-1N
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:52 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ea6bac9-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ea6bac9-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810290;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=H1pWpWC+QbCQo3x/OTxy8zwavbLBTT32ayVn9iwZfeQ=;
  b=avbsSRoktxCkSjZxujgOZN7JBhS//EEnNM2GWvXQjdN6Hfsajc7kGTga
   9zfK35AR5exboGp3F7UclZKROfAkgqzFRrWgWCLJSdIJv05JU+tJ9ov0f
   JTCZz45kUvjbAXnlgJnmAu95Jefi1OvO3eTAGzgQU60TTQGvGifsL8utW
   g=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: r+J7dNGSsVG/yNJLfBDMBjLnynN8OtCkf/pc8yKPV2Ay0uLBPM3fYM/ytpLczoxpqek3QJThef
 bxpGAxzoT1Kx94nkLF7+12ypCWeQBAovU1o6sghBVPcsWoY2R0HzHFL7eUjy2w7PXZ26xsfEUn
 s+2O2CYhhIBi2bfwhLJtguxeoGe9aRIP3LTj2Y4AjjHpg6oK09d4TvXCwa+qNjNO12zRetlvti
 EiicT2q4lJWg1yMtQCQ554P+3e9L1AqaxSxD67ywBcz87Uos0/tUeuAOamWdHUn4kD8lypVnKF
 qnL65K1+m6JLmvJIF0eVSgE8
X-SBRS: 5.1
X-MesageID: 61420896
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:w06y9q9QxQDZ1/Um8g9zDrUDBHmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 WAYXzuHOqyJZ2ukKop0PI60pEhQ7JSBydMwGlBpqHs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPggl
 osTlJKXZD1yJ+6UgsANCQNaLgBHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4XQayGN
 5tHAdZpRA/GQAAROk8FM4ARtv2xrWH4KDdCmmvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru5G38HxwecsCfyDCM73awruLJhmb/SYUUUrqi+ZZCgUKR7nweDgUMUlm2quX/jVSxM/pPJ
 kpR9icwoKwa8E2wUsK7TxC+uGSDvBMXR5xXCeJSwAiL1qrT5RffHmUeRyRNQNMjvc4yAzct0
 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqNHFaEyoLxPTZ+5hw1gjrXox5EpOUt4igcd3v+
 AyioC87jrQVqMcE0aSn4FzK6w6RSoj1oh0dvVuOAD/8hu9tTMv8PtHztwCHhRpVBN/BFgHpg
 ZQSpySJAAni57mpnTfFfugCFarBCx2tYGyF2g4H83XMGl2QF5+fkWJ4vWgWyKRBaJ9sldrVj
 Kn741k5CHh7ZiTCUEOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj62wBd2wPxlY
 8nEIa5A6Er274w9llJaoM9HjtcWKt0WnzuPFfgXMTz5uVZhWJJlYehcawbfBgzIxKiFvB/U4
 75i2ziikH1ivBnFSnCPq+Y7dAlSRVBiXMyeg5EHJ4arf1s9cEl8WqC5/F/UU9E890ijvryTp
 S/Vt44x4AeXuEAr3i3WMC0+M+22As4kxZ/5VAR1VWuVN7EYSd7HxM8im1EfJtHLLcRvkqx5S
 ecrYcKFDqgdQzjL4W1FP5L8sJZjZFKgggfXZ3ipZz02fphBQQ3V+4C7IluzpXdWVifn59Ejp
 7CA1x/ARcZRTQpVE8uLOumkyEm8vCZBlbsqDVfIONRaZG7l7JNud37qlvYyLsxVcUfDyzKW2
 hy4GxAdoeWR8YY5/MOQ3fKPrpuzEvs4FU1fRjGJ4bGzPCjc32yi3Y4fD7rYIWGDDDv5ofzwa
 /9UwvfwNOw8sGxL64csQax2ya8e5sf0o+MIxApTA3iWPU+gDaltIyfa0JAX5LFN3LJQpSC/R
 lmLpotBIbyMNc7oTAwRKQ4iYrjR3P0YgGCPv/E8IUG87y5r5ruXF05VOkDU2iBaKbJ0NqIjw
 Psg55FKu1Du1EJyP4bUlD1Q+kSNMmcEAvcuuZwtCYP2jhYmlwNZapvGBy6quJyCZr2g6KXxz
 uN4UEYau4lh+w==
IronPort-HdrOrdr: A9a23:ILF63arvXBiiqAt6UhSp/a0aV5oheYIsimQD101hICG8cqSj+P
 xG+85rsCMc6QxhP03I9urgBEDtex7hHP1OkOss1NWZPDUO0VHAROoJ0WKL+UyFJ8SUzIBgPM
 lbH5SWcOeAbmRHsQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420896"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH 57/57] stubdom: xenlibs linkfarm, ignore non-regular files
Date: Mon, 6 Dec 2021 17:02:40 +0000
Message-ID: <20211206170241.13165-58-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

When we will convert tools/ build system, their will be a need to
replace some use of "vpath". This will done making symbolic links.
Those symlinks are not wanted by stubdom build system when making a
linkfarm for the Xen libraries. To avoid them, we will use `find`
instead of plain shell globbing.

For example, there will be a link to "xen/lib/x86/cpuid.o" in
"tools/libs/guest/".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 1fa075b9ad..b312f710cd 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -345,7 +345,7 @@ define do_links
   mkdir -p $(dir $@)include
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
-  ln -sf $(dir $<)*.[ch] .; \
+  find $(dir $<) -maxdepth 1 -type f -name '*.[ch]' -exec ln -sf {} . \; ; \
   ln -sf $(dir $<)Makefile.common .
   touch $@
 endef
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239512.415347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTP-0000WU-HB; Mon, 06 Dec 2021 17:08:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239512.415347; Mon, 06 Dec 2021 17:08:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTP-0000Vt-8D; Mon, 06 Dec 2021 17:08:19 +0000
Received: by outflank-mailman (input) for mailman id 239512;
 Mon, 06 Dec 2021 17:08:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHP8-0005ta-Jl
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:54 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d822592-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d822592-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810233;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=g6V0HqnXbYzHAD7EivABin1e8USUEILeVoIQJoAVubg=;
  b=iHzwURRIaMCdc37MJlnwpAC5z9q1fIivjlKiZqF8rrr8+v+cFTSQnX/F
   9A64/b1Ina9TSQvCjgNwKSAAvenKtRycXQg+Hs5xhWZGy3Udh3krm/UtM
   f7MAv6wWdJBQnUeJm4Pv0006Nn92ZxuppqTJbm1MIlR3URPJ9aU7oENYv
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 7/1qdosxqVBF3zM5qtTebA3u2rnoSw5LAZGhE+j1lAyqMYdI0LUXajeAEhx5B7gUJgQ0OlJjr/
 kUNYk8djWIPBtaXfQGRv2A8lJmTN4gnkjDvOvnpnx0orc0+Ro0NkjbjMmfViS6oZNfZEgNXSTO
 n77YSzVIFmGRkaDQasK3w2DE1XdPuRQmVw7P4dp1NqP7q+zqDQWeVkgJOA2CcQhCXLT5WuSbJD
 jdH3MyTxPqO5fLhBcx20jwPdcr/1N087hnT3L0BiVYIa3ZD2MZMkB/Sd+SqGpL35y2++ghjsjg
 PMFsjhpDZn+qBSofm7ADzWw5
X-SBRS: 5.1
X-MesageID: 59324106
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:X1KEoaklooZlzp+vnSEM0Tbo5gxnIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcW2HTOazeZmqhfNBzbo6y9UlSu5/TzocxGVBv/H01ESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Nlisb+JdhktB+rJxrQcawBzDgdeeoQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeFP
 ZZAMWQHgBLoTC9UJEwyOJACvf64ln/HYzQEug2Fqv9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQ88ywyra805QqzQ8P0RRGQr3uNvxpaUN1Ve9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxQm+
 Vuqpuz3AQUotePFSEqE3aqyjXSbbH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE/8CRFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTQGY3h/5nzvp5p1QEwZ3Y1RfHNEBz3pBaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZ96kvKxSI6/CK+EBjarXnSXXFXdlM2JTRTPt10BbWB2yf1vU
 XtlWZjE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz8uYdykEW9EO9fWHPXN7hRxPrd/G39r
 oYOX+PXmk43eLCvPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6OLnO56JdU6x/89eyWh1
 ijVZ3K0AWHX3RXvQThmoFg6AF82dZog/389IwI2OlOkhyoqbYq1tf9NfJorZ7g3sudkyKcsH
 fUCfsyBBNVJSyjGpGtBPcWs8tQ6eUT5nx+KMgqkfCM7I8xqSTvW94K2ZQDo7iQPUHa67JNsv
 7262wrHapMfXAA+Xt3OYfeiwgrp73gQke5/RWXSJdxXdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YnRxhUBWjW67qyJBL2xGv7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB748cHmL2c5D6v9EyrND4FbkX
 0uO/p9ROKmTOdOjG1kUfVJ3YuOG3PASuz/T8fVqfxmquH4ppOKKARdIIh2BqC1BN78kYooqz
 NAotNMS9wHi2AEhNcyLj3wM+mmBRpDav37Lan3O7FfXtzcW
IronPort-HdrOrdr: A9a23:TzVd8qmjgezrFwhV4p28pDhCKLrpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324106"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 29/57] tools/helper: Cleanup Makefile
Date: Mon, 6 Dec 2021 17:02:12 +0000
Message-ID: <20211206170241.13165-30-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Use $(TARGETS) to collect targets.
Collect library to link against in $(LDLIBS).
Remove extra "-f" flags that is already part of $(RM).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/helpers/Makefile | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
index 7f6c422440..2fe3be2f89 100644
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -5,10 +5,10 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-PROGS += xen-init-dom0
+TARGETS += xen-init-dom0
 ifeq ($(CONFIG_Linux),y)
 ifeq ($(CONFIG_X86),y)
-PROGS += init-xenstore-domain
+TARGETS += init-xenstore-domain
 endif
 endif
 
@@ -17,6 +17,10 @@ $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenctrl)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxentoollog)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenstore)
+xen-init-dom0: LDLIBS += $(LDLIBS_libxenlight)
 
 INIT_XENSTORE_DOMAIN_OBJS = init-xenstore-domain.o init-dom-json.o
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
@@ -25,27 +29,32 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxentoollog)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenstore)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenctrl)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenguest)
+init-xenstore-domain: LDLIBS += $(LDLIBS_libxenlight)
 
 .PHONY: all
-all: $(PROGS)
+all: $(TARGETS)
 
 xen-init-dom0: $(XEN_INIT_DOM0_OBJS)
-	$(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
-	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: install
 install: all
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
-	for i in $(PROGS); do $(INSTALL_PROG) $$i $(DESTDIR)$(LIBEXEC_BIN); done
+	for i in $(TARGETS); do $(INSTALL_PROG) $$i $(DESTDIR)$(LIBEXEC_BIN); done
 
 .PHONY: uninstall
 uninstall:
-	for i in $(PROGS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done
+	for i in $(TARGETS); do rm -f $(DESTDIR)$(LIBEXEC_BIN)/$$i; done
 
 .PHONY: clean
 clean:
-	$(RM) -f *.o $(PROGS) $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 distclean: clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239514.415358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTW-0001QL-QL; Mon, 06 Dec 2021 17:08:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239514.415358; Mon, 06 Dec 2021 17:08:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTW-0001Q6-Le; Mon, 06 Dec 2021 17:08:26 +0000
Received: by outflank-mailman (input) for mailman id 239514;
 Mon, 06 Dec 2021 17:08:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPg-0005ta-7S
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:28 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90c3a7a2-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90c3a7a2-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810267;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=1nH3DERE1JlMh8VwtbIndoxT3Z56m8Z/3wBuefLC+Yw=;
  b=XV9s3SIefE0kF/n7YJUfCBGvChX1OviAHpE8ALt/VPcPgL6LYtR8pqoP
   8rJGH9m0sCrSZPzOQ0boDl/dr2PJBqcxQ5fBX1obo4ZNNCHXh73bM2xZj
   IEkyYNI0DxdG+bc5W8jZsPs5rpGyz4PzmedFnDh9MOTyZ4E0gux0BuWji
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: aDd2dpyJ7gRfSVbxV4+9/bzhPrf3mPz4foNM8gwZeG9SEPtXKtb3t64tf6/AXampwdzjPdLOoM
 sA7Uexx3oSwZwtLqp5Emnz+oBUSIqPdKLY9hn3X0FkZvVgrwMt3Led8LAnCIx9TRUen14VD3XM
 C3AOgMF+1UMgm++3gfJzPvP7AvZ409pZVDDPbkAeYXN0vSbG3f/v6eeukk0sJ36eJw3ONatVrj
 fA67+69DtiNidWjHJmVvGuB5uD9JBlXwgXTr+Xh12Nq9BcLPuv61rU7M+z0Xz2/6NPaHzIA+Y6
 BYLgJDC5GvOZ14VJakOWh/DJ
X-SBRS: 5.1
X-MesageID: 59766550
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kA42gqKMdy6/d3K4FE+RIJIlxSXFcZb7ZxGr2PjKsXjdYENS1jcPy
 GUcUGiPMv6DZmb1e4oiPIS+o00F6pLUndBmGQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2nsspjk
 +RLk6C2Cj0SL/zsl84FdCJhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph2Z4QQKuGD
 yYfQWM2cxKHXxpWBmwSN4oSrfqmnWjxLxQN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 G3c+H/iKgoHL9HZwj2Amlqtme3njS79QJgVFrCz6rhtmlL77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHVVhukoHmCr1gEVsBZCeES5wSEy66S6AGcblXoVRYYNoZg7pVvA2V3i
 BnZxLsFGACDrpW7ZGiPrYaSiw+0ehIuPD4iagUcajA8toyLTJ4IsjrDSdNqEaiQh9LzGC3tz
 z3ikBXSl4n/nuZQifzloAmvbyaE48GQE1Vrvlm/sneNt1shPOaYi5qUBU83BBqqBKKQVRG/s
 XcNgKByB8heXMjWxERhrAjgdYxFBspp0hWB2DaD/LF7rlxBHkJPm6gKulmSw28zba45lcfBO
 hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIEePcIgKVXdon4+DaJ144wLuBJ2+U3YE
 c3EGftA8F5AUfg3pNZIb7l1PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYrpw3PVBt3VGJis+V2Pm
 /4GbpPi40wGDIXWP3mGmaZOfAtiBSVqWvjLRzl/K7frzvxOQzp6VZc8ANoJJuRYokiivruSo
 yzmBBYHkAGXaL+uAVziV02PoYjHBf5XxU/X9wR1Vbpx83R8M4up8okFcJ47Iesu+OB5lKYmR
 PgZYcSQRP9IT22fqTgaaJD8qq1kdQiq2l3Sb3b0PmBncs4yXRHN9//lYhDrqHsEAB2ouJZsu
 LanzA7aH8YOHlwwEMbMZfuz5FqtpnxByvlqVk7FL4ALKkXh+YRnMQLrifozL51eIBnP3GLCh
 Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSDpzit245NVuqMbAvxbmKs9fXwf
 /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy7IF6wu7X
 kWDpotTNbmTYZ63FVcQIEwub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4YNE/3
 OMsmM8K8Aju2BMlP+GPgj1Q62nRfGcLVL8qt81CDYLm4ubxJoquvXAI5vfK3ayy
IronPort-HdrOrdr: A9a23:bIKx8K3LAnLHUrfS1DC0ewqjBLgkLtp133Aq2lEZdPRUGvb2qy
 nIpoV/6faUskd3ZJhOo7G90cW7LE80lqQFg7X5X43DYOCOggLBR+tfBOPZslnd8kbFmNK1u5
 0NT0EHMqySMWRH
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766550"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 45/57] libs/guest: rework CFLAGS
Date: Mon, 6 Dec 2021 17:02:28 +0000
Message-ID: <20211206170241.13165-46-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove '-Werror -Wmissing-progress -I./include $(CFLAGS_xeninclude)',
those flags are already added via "libs.mk".

Flag "-I." isn't needed, we just need to fix the #include of
"xg_core.h" as this header isn't expected to be installed.

Make use of "-iquote" instead of '-I' for double-quote included
headers.

Also, regroup the CFLAGS into the same place in the makefile.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/guest/Makefile          | 20 +++++++++-----------
 tools/libs/guest/xg_offline_page.c |  2 +-
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 770b9a7ef1..62b8fead86 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -28,18 +28,13 @@ OBJS-y       += xg_core.o
 OBJS-$(CONFIG_X86) += xg_core_x86.o
 OBJS-$(CONFIG_ARM) += xg_core_arm.o
 
-CFLAGS += -I$(XEN_libxenctrl)
-
 vpath %.c ../../../xen/common/libelf
-CFLAGS += -I../../../xen/common/libelf
 
 LIBELF_OBJS += libelf-tools.o libelf-loader.o
 LIBELF_OBJS += libelf-dominfo.o
 
 OBJS-y += $(LIBELF_OBJS)
 
-$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
-
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
 
@@ -70,10 +65,12 @@ OBJS-y                 += xg_dom_decompress_unsafe_xz.o
 OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
 endif
 
-CFLAGS   += -Werror -Wmissing-prototypes
-CFLAGS   += -I. -I./include $(CFLAGS_xeninclude)
-CFLAGS   += -D__XEN_TOOLS__
-CFLAGS   += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -D__XEN_TOOLS__
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -iquote ../../../xen/common/libelf
+
+# To be able to include xc_private.h
+CFLAGS += -iquote $(XEN_libxenctrl)
 
 # Needed for posix_fadvise64() in xc_linux.c
 CFLAGS-$(CONFIG_Linux) += -D_GNU_SOURCE
@@ -92,8 +89,9 @@ ZLIB_CFLAGS :=
 ZLIB_LIBS :=
 endif
 
-xg_dom_bzimageloader.o: CFLAGS += $(ZLIB_CFLAGS)
-xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
+xg_dom_bzimageloader.o xg_dom_bzimageloader.opic: CFLAGS += $(ZLIB_CFLAGS)
+
+$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 LIBHEADER := xenguest.h
 
diff --git a/tools/libs/guest/xg_offline_page.c b/tools/libs/guest/xg_offline_page.c
index cfe0e2d537..c594fdba41 100644
--- a/tools/libs/guest/xg_offline_page.c
+++ b/tools/libs/guest/xg_offline_page.c
@@ -25,7 +25,7 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <sys/time.h>
-#include <xg_core.h>
+#include "xg_core.h"
 
 #include "xc_private.h"
 #include "xg_private.h"
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239515.415368 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTY-0001lN-7N; Mon, 06 Dec 2021 17:08:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239515.415368; Mon, 06 Dec 2021 17:08:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTY-0001ko-0Q; Mon, 06 Dec 2021 17:08:28 +0000
Received: by outflank-mailman (input) for mailman id 239515;
 Mon, 06 Dec 2021 17:08:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPC-0005ti-Hf
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:58 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7ec7773b-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ec7773b-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810236;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=+tvgdAnTgDFIQbMFRm+czYIkxCdj45NAL3MUbvPerCo=;
  b=iGzNgPAll4NXo4QGfBMALzALgTVoahZZ81DO/YR72M/+8A2ZMGYMIhop
   ukiNI44csFvm3vjUa8aRZCdYzKDXMekZLtV+j3HPAj0lVG7ZbkkU8aKSZ
   ngYacN/feHaMKwVFTtBGG6Y7Wt3QKCTDACpYUQzMnXkUvfmK2Nt2o0t8C
   g=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: iloVjZmQX9y2crvLCIwpl57pl72O/tj1fGFcXIMnyxNR5L62S4fLq2TAUErUIG26ZvmQom57Wr
 evCFk/pXmCpBYi6uYfz6td4S78HrBxmsKd9jy6tfVpAP6GEnF1zLXD+Del7xwWJs3Ln4Vg8HDZ
 IQPLvYfP9V3y26GpQ/MWl8WUFIjvdlWVVss3VU996osWDOzF5TIwJFGW80rRiF86wOe/TR/osj
 qlmeqmrudTtI6uD1rqM/wdXNymlPnpM3jVv+mI9qx70JkSykByTwBPVc9v7wm+iRz9iHuKrXTs
 1sG0QKqmDvwqAqqn5361BuoL
X-SBRS: 5.1
X-MesageID: 58884430
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:80ta/6/Ph8jNt+z5v5zZDrUDZnmTJUtcMsCJ2f8bNWPcYEJGY0x3y
 2MWDGnUb/qJazegeNonb9yxp0oOupbWx9c3TFNkrSk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3NYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+l
 udJibWqdjxuI+rQs9g+aTtBNHtxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0eTaaCO
 5FBAdZpRDX5fBJpCg86Motkw+aP1nLFbx9S803A8MLb5ECMlVcsgdABKuH9e8OIbdVYmF6Co
 WDL9Hi/BQsVXPSAzRKV/3TqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03A
 0US5iopq7l07EGxR8PxdxK9qX+A+BUbXrJt//YSsV/XjPCOukDAWzZCHmUphMEaWNEeSmIY0
 mOghezSQiEorJapaki/75DOombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJupe/L6JYs7dQm+pn
 W3TxMQqr/BK1JNQif3nlbzSq2v0/sChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU
 JTpdqGjAAEy4XOlyXXlrAYlRujBCxO53Nv02wQH834JrWvFxpJbVdoMiAyS3W8wWir+RRfnY
 VXIpSRa74JJMX2hYMdfOtzqW5twnPW6T4q6Bpg4i+aihLArLmdrGwk0OiatM53FyhBwwcnTx
 7/FGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvuqWPTlHyaPU6lTCfNE98taQLWBshgtf/siFiFo
 r53aprRoz0CAbKWX8Ui2dNKRbz8BSNgXs6eRg0+XrPrHzeK70l9UaKMmu14JNQ+90mX/8+Rl
 kyAtoZj4AKXrRX6xc+iNhiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:7ULPX6/n17Smibw22ZZuk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884430"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 30/57] tools/hotplug: cleanup Makefiles
Date: Mon, 6 Dec 2021 17:02:13 +0000
Message-ID: <20211206170241.13165-31-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Remove "build" targets.

Use simply expanded variables when recursively expanded variable
aren't needed. (Use ":=" instead of "=".)

Don't check if a directory already exist when installing, just create
it.

Fix $(HOTPLUGPATH), it shouldn't have any double-quote.

Some reindentation.

FreeBSD, "hotplugpath.sh" is already installed by common/.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/hotplug/FreeBSD/Makefile       | 11 +++--------
 tools/hotplug/Linux/Makefile         | 16 ++++++----------
 tools/hotplug/Linux/systemd/Makefile | 16 +++++++---------
 tools/hotplug/NetBSD/Makefile        |  9 +++------
 tools/hotplug/common/Makefile        | 16 ++++++----------
 5 files changed, 25 insertions(+), 43 deletions(-)

diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makefile
index de9928cd86..a6552c9884 100644
--- a/tools/hotplug/FreeBSD/Makefile
+++ b/tools/hotplug/FreeBSD/Makefile
@@ -2,18 +2,15 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS = vif-bridge block
+XEN_SCRIPTS := vif-bridge block
 
-XEN_SCRIPT_DATA =
+XEN_SCRIPT_DATA :=
 
-XEN_RCD_PROG = rc.d/xencommons rc.d/xendriverdomain
+XEN_RCD_PROG := rc.d/xencommons rc.d/xendriverdomain
 
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-scripts install-rcd
 
@@ -44,12 +41,10 @@ install-rcd:
 	   do \
 	   $(INSTALL_PROG) $$i $(DESTDIR)$(INITD_DIR); \
 	done
-	$(INSTALL_DATA) ../common/hotplugpath.sh $(DESTDIR)$(XEN_SCRIPT_DIR)
 
 .PHONY: uninstall-rcd
 uninstall-rcd:
 	rm -f $(addprefix $(DESTDIR)$(INITD_DIR)/, $(XEN_RCD_PROG))
-	rm -f $(DESTDIR)$(XEN_SCRIPT_DIR)/hotplugpath.sh
 
 .PHONY: clean
 clean:
diff --git a/tools/hotplug/Linux/Makefile b/tools/hotplug/Linux/Makefile
index 0b1d111d7e..9a7b3a3515 100644
--- a/tools/hotplug/Linux/Makefile
+++ b/tools/hotplug/Linux/Makefile
@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS = vif-bridge
+XEN_SCRIPTS := vif-bridge
 XEN_SCRIPTS += vif-route
 XEN_SCRIPTS += vif-nat
 XEN_SCRIPTS += vif-openvswitch
@@ -22,16 +22,13 @@ XEN_SCRIPTS += launch-xenstore
 
 SUBDIRS-$(CONFIG_SYSTEMD) += systemd
 
-XEN_SCRIPT_DATA = xen-script-common.sh locking.sh logging.sh
+XEN_SCRIPT_DATA := xen-script-common.sh locking.sh logging.sh
 XEN_SCRIPT_DATA += xen-hotplug-common.sh xen-network-common.sh vif-common.sh
 XEN_SCRIPT_DATA += block-common.sh
 
 .PHONY: all
 all: subdirs-all
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-initd install-scripts subdirs-install
 
@@ -41,9 +38,9 @@ uninstall: uninstall-initd uninstall-scripts subdirs-uninstall
 # See docs/misc/distro_mapping.txt for INITD_DIR location
 .PHONY: install-initd
 install-initd:
-	[ -d $(DESTDIR)$(INITD_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
-	[ -d $(DESTDIR)$(SYSCONFIG_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(SYSCONFIG_DIR)
-	[ -d $(DESTDIR)$(LIBEXEC_BIN) ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
+	$(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(SYSCONFIG_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
 	$(INSTALL_DATA) init.d/sysconfig.xendomains $(DESTDIR)$(SYSCONFIG_DIR)/xendomains
 	$(INSTALL_DATA) init.d/sysconfig.xencommons $(DESTDIR)$(SYSCONFIG_DIR)/xencommons
 	$(INSTALL_PROG) xendomains $(DESTDIR)$(LIBEXEC_BIN)
@@ -64,8 +61,7 @@ uninstall-initd:
 
 .PHONY: install-scripts
 install-scripts:
-	[ -d $(DESTDIR)$(XEN_SCRIPT_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
 	set -e; for i in $(XEN_SCRIPTS); \
 	    do \
 	    $(INSTALL_PROG) $$i $(DESTDIR)$(XEN_SCRIPT_DIR); \
diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile
index a5d41d86ef..26df2a43b1 100644
--- a/tools/hotplug/Linux/systemd/Makefile
+++ b/tools/hotplug/Linux/systemd/Makefile
@@ -1,12 +1,12 @@
 XEN_ROOT = $(CURDIR)/../../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-XEN_SYSTEMD_MODULES = xen.conf
+XEN_SYSTEMD_MODULES := xen.conf
 
-XEN_SYSTEMD_MOUNT =  proc-xen.mount
+XEN_SYSTEMD_MOUNT := proc-xen.mount
 XEN_SYSTEMD_MOUNT += var-lib-xenstored.mount
 
-XEN_SYSTEMD_SERVICE  = xenstored.service
+XEN_SYSTEMD_SERVICE := xenstored.service
 XEN_SYSTEMD_SERVICE += xenconsoled.service
 XEN_SYSTEMD_SERVICE += xen-qemu-dom0-disk-backend.service
 XEN_SYSTEMD_SERVICE += xendomains.service
@@ -14,7 +14,7 @@ XEN_SYSTEMD_SERVICE += xen-watchdog.service
 XEN_SYSTEMD_SERVICE += xen-init-dom0.service
 XEN_SYSTEMD_SERVICE += xendriverdomain.service
 
-ALL_XEN_SYSTEMD =	$(XEN_SYSTEMD_MODULES)  \
+ALL_XEN_SYSTEMD :=	$(XEN_SYSTEMD_MODULES)  \
 			$(XEN_SYSTEMD_MOUNT)	\
 			$(XEN_SYSTEMD_SERVICE)
 
@@ -30,10 +30,8 @@ distclean: clean
 
 .PHONY: install
 install: $(ALL_XEN_SYSTEMD)
-	[ -d $(DESTDIR)$(XEN_SYSTEMD_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_DIR)
-	[ -d $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
 	$(INSTALL_DATA) *.service $(DESTDIR)$(XEN_SYSTEMD_DIR)
 	$(INSTALL_DATA) *.mount $(DESTDIR)$(XEN_SYSTEMD_DIR)
 	$(INSTALL_DATA) *.conf $(DESTDIR)$(XEN_SYSTEMD_MODULES_LOAD)
@@ -48,5 +46,5 @@ $(XEN_SYSTEMD_MODULES):
 	rm -f $@.tmp
 	for mod in $(LINUX_BACKEND_MODULES) ; do \
 		echo $$mod ; \
-		done > $@.tmp
+	done > $@.tmp
 	$(call move-if-changed,$@.tmp,$@)
diff --git a/tools/hotplug/NetBSD/Makefile b/tools/hotplug/NetBSD/Makefile
index f909ffa367..1cd3db2ccb 100644
--- a/tools/hotplug/NetBSD/Makefile
+++ b/tools/hotplug/NetBSD/Makefile
@@ -2,22 +2,19 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen script dir and scripts to go there.
-XEN_SCRIPTS =
+XEN_SCRIPTS :=
 XEN_SCRIPTS += locking.sh
 XEN_SCRIPTS += block
 XEN_SCRIPTS += vif-bridge
 XEN_SCRIPTS += vif-ip
 XEN_SCRIPTS += qemu-ifup
 
-XEN_SCRIPT_DATA =
-XEN_RCD_PROG = rc.d/xencommons rc.d/xendomains rc.d/xen-watchdog rc.d/xendriverdomain
+XEN_SCRIPT_DATA :=
+XEN_RCD_PROG := rc.d/xencommons rc.d/xendomains rc.d/xen-watchdog rc.d/xendriverdomain
 
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: install-scripts install-rcd
 
diff --git a/tools/hotplug/common/Makefile b/tools/hotplug/common/Makefile
index ef48bfacc9..e8a8dbea6c 100644
--- a/tools/hotplug/common/Makefile
+++ b/tools/hotplug/common/Makefile
@@ -1,22 +1,19 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-HOTPLUGPATH="hotplugpath.sh"
+HOTPLUGPATH := hotplugpath.sh
 
 # OS-independent hotplug scripts go in this directory
 
 # Xen scripts to go there.
-XEN_SCRIPTS =
-XEN_SCRIPT_DATA = $(HOTPLUGPATH)
+XEN_SCRIPTS :=
+XEN_SCRIPT_DATA := $(HOTPLUGPATH)
 
 genpath-target = $(call buildmakevars2file,$(HOTPLUGPATH))
 $(eval $(genpath-target))
 
 .PHONY: all
-all: build
-
-.PHONY: build
-build: $(HOTPLUGPATH)
+all: $(HOTPLUGPATH)
 
 .PHONY: install
 install: install-scripts
@@ -25,9 +22,8 @@ install: install-scripts
 uninstall: uninstall-scripts
 
 .PHONY: install-scripts
-install-scripts: build
-	[ -d $(DESTDIR)$(XEN_SCRIPT_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
+install-scripts: all
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_SCRIPT_DIR)
 	set -e; for i in $(XEN_SCRIPTS); \
 	   do \
 	   $(INSTALL_PROG) $$i $(DESTDIR)$(XEN_SCRIPT_DIR); \
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239516.415380 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTZ-00029u-Ql; Mon, 06 Dec 2021 17:08:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239516.415380; Mon, 06 Dec 2021 17:08:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTZ-00029W-Lw; Mon, 06 Dec 2021 17:08:29 +0000
Received: by outflank-mailman (input) for mailman id 239516;
 Mon, 06 Dec 2021 17:08:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOt-0005ti-I1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:39 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7392cda0-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7392cda0-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810216;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ncr3lIi38E0siWJzJi6btExaNaeaiEW2/teWOIwBcPA=;
  b=XqLP5lf+8ZGqBKikfTLLnVMx2N3n96+HxSjcir0iQ2bzAtZkLyiAtXCK
   6VfT+cfGlmYaWi6VyfKVCWBNRgqeT1QqtQJUfdJm5Bo1yVfyFaRnjCI3r
   zLunzSnnE3NtdsZo9+lHhVqO8dlfTnY6KvHibjJVnPAvjN10A48CaL/0A
   k=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Ek1RNuKqMkEJMUikv7DTFzl70J0nrxT6CuQdemUffhBIDJ/a2TxQgpNwYzDSS6JqcForF07C74
 v4oydXezartqG+ofeCK+cnAIBcboagjErP50ngRKTFP7UFtqlWksPNivnrR3M6eDmKtSlXtKD5
 a4HTmQ/cFWlN2uebgNLTG6R5SVgWefVQ3VYjs5RWXBjmweHw5JtmhX/0zx2OZqOoeHC6OFSvL2
 8d8i6MTgM3lFjhPtXti64qljJ/JsICkQaxkmKzrxh81WaGhjITsugSIE8TgqmG53eeBP0fho7D
 sbjJH/LOwzqSa1YSho6KvOqq
X-SBRS: 5.1
X-MesageID: 61420662
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:b9u3z67Cnf4KxuhWL6cLkAxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 mEbWTqEM/+PajH1Ltxya9u+8EhX7JCBzIJqGVRl+H1gHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 tJDlcGVZBcVEo7AoOYMbT1UGConIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRKqEP
 5RHM1KDajz9chBmAmoIUakvlcmyoHKvKWZYhnOK8P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2Qd/DYuqq4jslSmVNDnUzW3pXeFulgXXN84LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobTIt2
 H/Uuv75ORBMvIWXWEy5+ryf9CznbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr1/sCRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1
 JTodiX30QzvMX1vvHHUKAnuNOvwjxpgDNE6qQQ1d3XG327yk0NPhagKvFlDyL5Ba67ogwPBb
 k7Joh9275ROJnasZqIfS9vvUJR1l/m9T467CaC8gj9yjn5ZLlXvEMZGPxH44owQuBJ0zfFX1
 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI50/P7FZqX1bMEe1tGALXNogRtfrYyC2Io
 4c3H5bbkH13DbyhChQ7BKZOdDjm21BgXsuowyGWH8beSjdb9JYJV6WMnOh/ItM9xMy4VI7gp
 xmAZ6OR83Kn7VWvFOlAQisLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:Ap5ncKG7vr5hDYJHpLqE4seALOsnbusQ8zAXP0AYc3Nom6uj5q
 WTdZUgpHjJYVkqOU3I9ersBEDiewK/yXcW2+ks1N6ZNWGM0ldARLsSibcKqAePJ8SRzIJgPN
 9bAstDNOE=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420662"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 21/57] tools/include/xen-foreign: avoid to rely on default .SUFFIXES
Date: Mon, 6 Dec 2021 17:02:04 +0000
Message-ID: <20211206170241.13165-22-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

When a rule isn't a pattern rule, and thus don't have a %, the
value of the automatic variable stem $* depends on .SUFFIXES. GNU make
manual explain that it is better to avoid this "bizarre" behavior
which exist for compatibility.

Use $(basename ) instead. So we can one day avoid make's build-in
rules and variables.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/include/xen-foreign/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/include/xen-foreign/Makefile b/tools/include/xen-foreign/Makefile
index e395011fdd..6ce51daf5e 100644
--- a/tools/include/xen-foreign/Makefile
+++ b/tools/include/xen-foreign/Makefile
@@ -25,28 +25,28 @@ check-headers: checker
 	rm tmp.size
 
 arm32.h: mkheader.py structs.py $(ROOT)/arch-arm.h $(ROOT)/xen.h
-	$(PYTHON) $< $* $@.tmp $(filter %.h,$^)
+	$(PYTHON) $< $(basename $@) $@.tmp $(filter %.h,$^)
 	#Avoid mixing an alignment directive with a uint64_t cast or sizeof expression
 	sed 's/(__align8__ \(uint64_t\))/(\1)/g' < $@.tmp > $@.tmp2
 	rm $@.tmp
 	$(call move-if-changed,$@.tmp2,$@)
 
 arm64.h: mkheader.py structs.py $(ROOT)/arch-arm.h $(ROOT)/xen.h
-	$(PYTHON) $< $* $@.tmp $(filter %.h,$^)
+	$(PYTHON) $< $(basename $@) $@.tmp $(filter %.h,$^)
 	#Avoid mixing an alignment directive with a uint64_t cast or sizeof expression
 	sed 's/(__align8__ \(uint64_t\))/(\1)/g' < $@.tmp > $@.tmp2
 	rm $@.tmp
 	$(call move-if-changed,$@.tmp2,$@)
 
 x86_32.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_32.h $(ROOT)/arch-x86/xen.h $(ROOT)/xen.h
-	$(PYTHON) $< $* $@.tmp $(filter %.h,$^)
+	$(PYTHON) $< $(basename $@) $@.tmp $(filter %.h,$^)
 	#Avoid mixing an alignment directive with a uint64_t cast or sizeof expression
 	sed 's/(__align8__ \(uint64_t\))/(\1)/g' < $@.tmp > $@.tmp2
 	rm $@.tmp
 	$(call move-if-changed,$@.tmp2,$@)
 
 x86_64.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_64.h $(ROOT)/arch-x86/xen.h $(ROOT)/xen.h
-	$(PYTHON) $< $* $@.tmp $(filter %.h,$^)
+	$(PYTHON) $< $(basename $@) $@.tmp $(filter %.h,$^)
 	#Avoid mixing an alignment directive with a uint64_t cast or sizeof expression
 	sed 's/(__align8__ \(uint64_t\))/(\1)/g' < $@.tmp > $@.tmp2
 	rm $@.tmp
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239517.415391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTd-0002nd-AC; Mon, 06 Dec 2021 17:08:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239517.415391; Mon, 06 Dec 2021 17:08:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTd-0002mz-5M; Mon, 06 Dec 2021 17:08:33 +0000
Received: by outflank-mailman (input) for mailman id 239517;
 Mon, 06 Dec 2021 17:08:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPE-0005ti-Hk
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:00 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80ea4f3f-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80ea4f3f-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810238;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Kq8ZIrj5FFoEo4CvpADkcXU/4kPXXPzk2tAot7bbAmY=;
  b=bqO4YQQVfm561ukIXF2wMxutim7aL5jLqhISLCzsu3iSrmWKlwfjjuIR
   8B3ptw5+WnD8tym+VQuQeZLJv9bP4+83OyluATcBGTVq5PNtATgnvJIfI
   s+ciEVFWVCipfUYal3Nu/VWSP66XMrBP2vDhxKZMwd1XHTEyEGKSyGLu8
   E=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 94Kj7Yjpo0IxUHdVCkmhcFS401UUiFTEzSFb9kzcVxi9CGB4Zn+w43Ax6XbQMHxeJm8WePzlK+
 y6nsB8Z4jag/WihSwHLTKPl25voTydchBjDTVqE6i+C5xLDEV+AeRlPDxpYS9y/8uyzlFuZFt/
 7QhqgjvwfDPCtojE6DtjMeSuzBmQ9jc9ji3DyQdBbNAnGL94nXNXq8t7g/gB90RddF7Tlglw5E
 +fjdHuGY38qInhWHgxwHYv901Vf2DYjZrjNG/lr9X5oWbwDzhGPu0O0OSTq+1zIPG17f0YTFUA
 AUz7p2mRon0kZxbmiT3n5fFO
X-SBRS: 5.1
X-MesageID: 58884443
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gF3/66OSt4JW4zrvrR1DkMFynXyQoLVcMsEvi/4bfWQNrUog1DAOz
 TYdWT+BbKqPYTCned4jbI3l/R8EuZKAyIRiTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En5400o9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxqkgfB04
 Y1uj82LFz53AKHWoLQteRYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWdg1pwSQa22i
 8wxeBF2ZhL4UjR0JHgMML8QreizqUbtWmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKg4eHMySz3yC6H3Erv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWUtRDK
 0sS62w2oLI77kCDQdz0Xhn+q3mB1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvQJmdEWQBVy9
 WXYpI3QWwJjqoXFeViSo+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0ISrRGiYL
 ySi6XFn2u5N1ZJjO7CTpAif21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshTVPlhdwTXGY3h+Y1FAd7falUwZnY1QPEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/QnPNjgVp5wk/ewfTgAahwyRoAUCnSWXFXYlByCmGbKhzy9+KTSuf9X1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfPVyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY8RTx6VaaOmehJlk4Mt/09q9okN
 0qVAidwoGcTT1WcQelTQnw8Or7pQ7hlqnc3YX4lMVqygiBxaoez9qYPMZAweOB/puBkyPd1S
 dgDetmBXasTGmiWpWxFYMmvtpFmeTSqmRmKY3ivbg8gcsMyXAfO4NLlIFfirXFcEiqtuMIii
 LS8zQeHE4EbTgFvAZ+OOvKixl+8p1YHn+d2UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1
 gC3BxYEpLaS/99poYeR3a3d9tWnCepzGEZeDlL317fuOHmI5HenzK9BTP2MIWLXWlTr9fjwf
 u5S1fz9bqEKxQ4Yr4pmHr935qsi/N+z9aRCxwFpEXiXPVSmDrRsfiuP0cVV7/Afw7ZYvU29W
 16V+8kcMrKMYZu3HFkULQsjT+KCyfBLxWWCsaVreB33tH1t4b6KcUROJB3d2iVSIYx8PJ4h3
 ep86tUd7Bayi0ZyP9uL5syOG79g8pDUv30bi6wn
IronPort-HdrOrdr: A9a23:m2APWK+YaiSY8Il1+uBuk+DeI+orL9Y04lQ7vn2YSXRuHfBw8P
 re+8jztCWE8Qr5N0tApTntAsS9qDbnhPxICOoqTNOftWvd2FdARbsKheCJ/9SjIVyaygc079
 YHT0EUMrPN5DZB4foSmDPIcOod/A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884443"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 32/57] tools/misc: rework Makefile
Date: Mon, 6 Dec 2021 17:02:15 +0000
Message-ID: <20211206170241.13165-33-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Add missing "xen-detect" rule. It only works without it because we
still have make's built-ins rules and variables, but fix this to not
have to rely on them.

Rename $(TARGETS_BUILD) to $(TARGETS).

Remove the unused "build" target.

Also, they are no more "build-only" targets, remove the extra code.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/misc/Makefile | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/misc/Makefile b/tools/misc/Makefile
index 8b9558b93f..5e7787e501 100644
--- a/tools/misc/Makefile
+++ b/tools/misc/Makefile
@@ -50,16 +50,13 @@ TARGETS_COPY += xencov_split
 TARGETS_COPY += xenpvnetboot
 
 # Everything which needs to be built
-TARGETS_BUILD := $(filter-out $(TARGETS_COPY),$(TARGETS_ALL))
+TARGETS := $(filter-out $(TARGETS_COPY),$(TARGETS_ALL))
 
-# ... including build-only targets
-TARGETS_BUILD += $(TARGETS_BUILD-y)
-
-.PHONY: all build
-all build: $(TARGETS_BUILD)
+.PHONY: all
+all: $(TARGETS)
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(bindir)
 	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
 	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
@@ -75,7 +72,7 @@ uninstall:
 
 .PHONY: clean
 clean:
-	$(RM) *.o $(TARGETS_BUILD) *~ $(DEPS_RM)
+	$(RM) *.o $(TARGETS) *~ $(DEPS_RM)
 
 .PHONY: distclean
 distclean: clean
@@ -86,6 +83,9 @@ xen-access: xen-access.o
 xen-cpuid: xen-cpuid.o
 	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(APPEND_LDFLAGS)
 
+xen-detect: xen-detect.o
+	$(CC) $(LDFLAGS) -o $@ $< $(APPEND_LDFLAGS)
+
 xen-hvmctx: xen-hvmctx.o
 	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS_libxenctrl) $(APPEND_LDFLAGS)
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239518.415399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTe-0003C4-Tg; Mon, 06 Dec 2021 17:08:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239518.415399; Mon, 06 Dec 2021 17:08:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTe-0003BO-LK; Mon, 06 Dec 2021 17:08:34 +0000
Received: by outflank-mailman (input) for mailman id 239518;
 Mon, 06 Dec 2021 17:08:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0GdR=QX=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muHOw-0005ta-ME
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7611c199-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:41 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-ej0sc7dGP-afHWbY2h7NrA-1; Mon, 06 Dec 2021 18:03:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 6 Dec
 2021 17:03:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021
 17:03:38 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Mon, 6 Dec 2021 17:03:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7611c199-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638810220;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nz375AMFecIdgYkYtENyDLTLBQN7pwZgXN4e0X8P7uw=;
	b=OcxGXnUxH172PvgO/Rz4z0f3zVfE3d5H4ONxZBwLyvEQObwLF45Z91K6QXx1f6F9iEIbEy
	9RUYfAYZiuhzwzjktBuQK539C4fC1PiQGm/bBVAxsNiaesBChfcFfP09jvWgoVYTehOmcH
	aUvxc4cWVYYYBJvxPgW3R+hDJjiy6PU=
X-MC-Unique: ej0sc7dGP-afHWbY2h7NrA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UVO4jNMJ/bw/rcN8KVyOmE1G6rUMIXMYPrBG9SrwarbVUW/Us9Tyderlz91uabqI0G0cIh2x1nXfisTQ8d9z34H6JVTxvfXenYcRPdEsifn0lry5njNn0oX1P2PoMxrVrB6eNAbMFbAlz/X00Dw7JLnq1aKq63FGjQF7bU3QxRhsQbxTOkOmp+igUAI8XJjGG8l280eEt2p+qKmDDjRKiMKid/G8HFM/6nZaCk7Qbw+UzDQJyM/StL6RUQTzivKF+WJU0OebJnTS2+bdNHU5FFPC3lvesiQygPgDvrSXqJxoLNqDDNa72srqsK0irvUY+Hf+8VoJwVhjz4PH5wiJbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nz375AMFecIdgYkYtENyDLTLBQN7pwZgXN4e0X8P7uw=;
 b=epo2+tQ++u1ptebuyUlnl4tq2eMOqc7AOVTV+ahS9iAhXCedUS8iy9ALj4Wt6SHFD6k5s6JDZSzkiwGzHBYU+l1gHpQwDcvU5Il6cf/u0I8aBWWerrrlFVxipdMRscoj84qyyVTn1MQKZXMXifTTH4cTqhdvVSSbugrex1FGFVOYSErub6gvBdYe2NrQoOiG82XRhSnS/PPyruF1mC9boX68JvAzImaOY36iUVd70rrHvjo9AZ4yW2TQUqoYAegWlHnC/2N3j5jEDXHPfDPvBBV+W/JwRwUry2DR3j/Qfo6e5Da2t3BZsERVghAkR5d3Ii1vHRgd/tnk1RV4VqBdJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c2a1fc6d-3ae5-b799-cd27-4ad28f88dbcf@suse.com>
Date: Mon, 6 Dec 2021 18:03:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 10/47] build: rework cloc recipe
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-11-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-11-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bb60b728-e853-4b79-9435-08d9b8da58a4
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37763C2E6A9CBC4823FB9D5BB36D9@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NnaqmLmCdokWnY46xOC3BuBPSqvzUT4Jh5DmqKTEU2nwucgpfQl62fphHLPiDb8wSJDNVQMhspOsXPulmX2BZB/nN+kNR3KmhzH7t1+uH195Mvl/n8AKpLalBkBXW8CUp5G8uRdZLHCQlt9aF5oN8ST9id1OzobVD9iR8nh8H7euPZ9bR0sC4Qh82/JGYrEf47UohkdP8t/zlLq57HsKYgLoTfL7oBvDgWEVnmYQMAibcxKll2v54TQwTJBGLCKGt+7/PZoMwXwLqdEIUgmS6xBMyTGZgZqJuiK/lbEUhxTNWjOaK+LMsEhu4auAobOXSjVTA6HuJCNAIJSKW1ibyHsHq5RayEpk3N+Tak6d05vSj26vB4uHPUTPEyoi80cAQ4unHBudRqNPNgRpMYxLPfMNd+KVVkmSw1tEaUGI8DfMoaGgb86JSTR0F50UYKwLOFSNfMuIu44OThSRyahgwkEgkb/hMCZcjeY8dLH5guBeO7hS5wPbHqXNhFDZdH5iRyhhpFyxH3CR5NUSeiIxaZU/yfqArg6FEi0B4NOqvxfIY+BctXEeV7kp8a+Ui3ZWIQh/vQ1BaM3CHkP5ILKyAbht5zadi+eWVJrHpOpLMgzxBbKZE677KJCU9nhnfmMKu6DsCcuAIBmueLRqX8FxQlG84+B8s6OHtUnY7hC+MfDOb06ZcaOv71deqb+xon2u/2XhtCoBf/SNAFlIbn26a7AXV9BvXhEw16KUxBq7L0fJzEoPblKRmWWjYUzt00Fn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(16576012)(508600001)(316002)(31686004)(186003)(8676002)(66556008)(66476007)(6486002)(36756003)(8936002)(66946007)(4744005)(31696002)(6916009)(956004)(2616005)(54906003)(86362001)(2906002)(53546011)(38100700002)(4326008)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NERETVRHQ05ZcVlha1BmN2tYME5xUjBNVHBKUTc3YncxL0wvYkNTTEkvdVRX?=
 =?utf-8?B?UjNWOE5XWk5OWHlWdTE4OTBpTyszVHlBYlBGMk11dDJreGoxTk9MamJ5TWEw?=
 =?utf-8?B?V1o3S09Fckh4UDV0UFNPMHRJQ0pLeEFXKzRxRzYrdXR1WkFib1ZQcElxa1U1?=
 =?utf-8?B?Uk5rTHlYcnQrSjhPMks3WWswazFVZ04wSnhLUURmcHpLRGtLdkhoNUhRRFU5?=
 =?utf-8?B?a1BTc1JFSEU3Qy9GNzdPbmkrZjdpT1hCZjh3N0N1elcrejRzN1VZVmc2cWox?=
 =?utf-8?B?eDU5UkhXbE5JWGZDWHcwT1BzaWlXcG53UHZCVUFUWkNoVVlnMFVPRzBWcndG?=
 =?utf-8?B?MHpFenZlSjBqbjdhd0srNVQzNUgzNjJxNEw1UFIwZGtqemtNOVlNa25jb2xV?=
 =?utf-8?B?eUNPSDBvRkdORVN1akh2VlRjaWk4N1hRQWNCSkJFTWxkSXJxdXd5Nk1NWGFq?=
 =?utf-8?B?NytzMmw4cUk2a2luL21ZMWhMOW4yUFM1czl1RkJ1WVYvYTFoNnEraDdCamlT?=
 =?utf-8?B?c0F0Nm9QUFhmcmN1WEFITGR1M0NtaFV2TjB2ZHBrUHM1dVdzWGNobmRyam9V?=
 =?utf-8?B?dDVCUWNhVHkyZG0yKy9JaWhrUFhpc0ljMTZ6KzZsNEpzcGx6NUhnYXllR0c0?=
 =?utf-8?B?dWVFNGpLYXFtekRjSVcwb3Rpd0FBa0xLWXMxWU5UVUltMzNrZlR6akhIYVZk?=
 =?utf-8?B?cnpETGxqYVd4eEpFSkFQMEdJNmtzRTI4MzM1U0FKZFdIS1BPTGVWYUxuaTBL?=
 =?utf-8?B?U3dIWSs1L0tFWVpLd1V3SUlTNmNBT3pIZXhuMytKSGlreFcvemI5VllGQXQr?=
 =?utf-8?B?dm83cDdPRVlPQ2JYb2pNaDRNUnFpMjdEUjNnenZEblpNaExGVUlXYkJvbjZq?=
 =?utf-8?B?TWpubE1rMmF3VC9hRkpZMVFvb2dNYUtHL3liYU53K2E0RVpHZW13ajFBYWZ0?=
 =?utf-8?B?UDM0RXVZM2l5UXpOV0Q0QStYeEM5MWl3Z3NrY1dkWEhkaERwN1RvaWg2T0Nt?=
 =?utf-8?B?eUozbWhLSG5GVjRwWWFMendjMU1pa0RmdUxuYytWaWY5ZXdQVkZmNHdMODN6?=
 =?utf-8?B?bTlWUzNnQ2s0Q3E0UjE2R3VsUTJqQXlXTCtPRSt6NStTM0dsek1rOTdHS2Z3?=
 =?utf-8?B?aTZCME5NbVdxMUdpR2lqeVhPMkxyaVZRQ05vLzQ5NjFoamkyYzRIWU1nL0hi?=
 =?utf-8?B?aW1jZTREcWllakozTWV2Y2phS2xtMXBKcEMvcDMzQnoyRFJzc1BqaUQ1MnhK?=
 =?utf-8?B?MVZSZEwvV1paT0pWb3NJWVNUbC9xaEZiWTAzSHJRK1pVNUNpMU9MT3RWVGp2?=
 =?utf-8?B?MnQ3NGJITm93dXFNcXpnZXVjY3FISGg2RTBLWWZrU2kxVkZzUnBmNjcvMWhz?=
 =?utf-8?B?RkFpMytpWjhXRWoyWUpUdUtXdE5ObmhtYW83QytYT1Q5TlNXTnltbE1LQStw?=
 =?utf-8?B?Mm1uWmYwMmVDc1B1aGFudHpaVjVMOXltd0pBODdaM2RBY3FoenoxOGRWeWs4?=
 =?utf-8?B?Wk9tR0xxcVVUR3I0OFFUSXVpaXpWZGpyeTF0MGxXY2VkTUorbHQrR3IyOXda?=
 =?utf-8?B?Y3BZaW5WNEl5Z1VTbFZhUENrcXpiVVh2Sk54MFpEWUNKc1FjYXQyQzk3SnQx?=
 =?utf-8?B?RHBYMzJiQWxhL3NoZlBoNWFtbFhwYmVxSDZ5V3Y1WDBTM3F2WUZvVWwwdHpo?=
 =?utf-8?B?cjVFMkpnTWxDYnc5cDVSMW4zMk12dm9oMGppNC9qNWtCREl3UWNYenFxaDJR?=
 =?utf-8?B?aVQxTURLVnRBakhhYWFzRVNQYUgxc0duSk93Rll0ZGNxUmlsd2FsWmRUMnAw?=
 =?utf-8?B?eVQ2N1dTaVF0L2o5a3liQ3hPVUF6VVAxZEF3TzkyMzZtU1BXWG9Vd0M5Umpa?=
 =?utf-8?B?dnFVMVcwd3l5cGdkejI1cjZ3V2R2RkRwaFZNVExIL2NZbkZoLys2eDNQM3Jx?=
 =?utf-8?B?MTNRQ0dFSGJwa1ZTcjFvck9ZdzZaTE1BeDZyMXdvSEdGbUtDYnpneDVLS1dB?=
 =?utf-8?B?WEZiUllTUWxoWmIzZ0lNT2dFNFdnSk4vOTI0TUlIcVlPYTVjTXNjaFRSVGFC?=
 =?utf-8?B?dEw5L0hweDN0ejl4MXFGTlBlSllXRHNBWjF6TlZKenBxNXRUNWZpcFJYUTk5?=
 =?utf-8?B?YTBrL2djTG8vc1E4OWZxdVVRbklsVHYrWEVWZkNxMUFDQTQvU1A4cXprdmF0?=
 =?utf-8?Q?DR4fw3jepcgQaODYMJoajP8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb60b728-e853-4b79-9435-08d9b8da58a4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 17:03:38.0387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T+jUWQarll2meIX7d+0bBMw2afwzYqPPz+wQNHk6VVnM5qmDFUxnJcGX7TXCmtmqXhYVB2Hpr+2AXLwjYjfjKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 25.11.2021 14:39, Anthony PERARD wrote:
> We are going to make other modifications to the cloc recipe, so this
> patch prepare make those modification easier.
> 
> We replace the Makefile meta programming by just a shell script which
> should be easier to read and is actually faster to execute.
> 
> Instead of looking for files in "$(BASEDIR)", we use "." which is give
> the same result overall. We also avoid the need for a temporary file
> as cloc can read the list of files from stdin.
> 
> No change intended to the output of `cloc`.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239519.415405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTf-0003HP-Jd; Mon, 06 Dec 2021 17:08:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239519.415405; Mon, 06 Dec 2021 17:08:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTf-0003G4-4q; Mon, 06 Dec 2021 17:08:35 +0000
Received: by outflank-mailman (input) for mailman id 239519;
 Mon, 06 Dec 2021 17:08:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPY-0005ti-9l
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:20 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8cc123d2-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cc123d2-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810259;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=EhMsevpH10Vo5lsrbd8HMBQJe8BAiJGveppQnUZtweM=;
  b=UNPc3qf38AS57BFuoVBeIesUcO+Zzxks1p7BRXLgdFPVYgYrbvXo/YFN
   OWypbqTe7GEIEKsPIN063ZM0Ex1tblutWOD0rBQ97lwWpz4p4GvV0oHmi
   kmCmwdyqg6HQl6vHbM8aUcFdcf5eV2SoY6NeKuozks2Mj2zDmTNRJrovv
   8=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 7gHSWxTipzDruyc8beHxu7ykn5ZO6eho71NfjYqJhR0Qa/VqvEOx22soiCv84a1Lzp4qzcGyOJ
 RAas3Csww+eNvMMFRJ0OFmJzaJ2XBIJg56HZ98wieLzFzc7Rvox93g0jcX624oISXrzPis8Cel
 OsNkyCf3Avkvo4qi4IDuHzOu7vNp8dk3nkvfjPtDcAnkDatqjKmiTYZZvkk2cfrVJiZVhmj/DG
 tLIz+SecDJdjvEgEw94UVtG17zHBRfQS8xSGaL3+k8tF2nl6Bw7+39cp3VsvO3UQCIT/+W1sTB
 XgCSUaFMUNB4GlFWTPvnSsun
X-SBRS: 5.1
X-MesageID: 59370712
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sEBDdqDtauODgxVW/9jkw5YqxClBgxIJ4kV8jS/XYbTApGwi1DcAz
 zdOCD/XOayLZjf0e4h/Ot+xoEtTvMPWz9cxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/k2XQnvF/0
 vZxmJWBZzUoZZ2RpckdTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWxv3p8XR54yY
 eI6MiVySy7LfidRYH0MVNUPmOqNmT7wJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt822urv/CmzvhX4AfH6H+8eRl6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZtD7Qx2/pm/CphMGUsBcO+I/4QCJjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHqO3MSFOT7JSogDqDFxoUdl9fWAIEUl5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjv9tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWS0bb1HRcBJG9GRF5iLJ9o4DNZWfhgBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66PPoUUM8UrLlHYrEmCgHJ8OUi3yiDAdollZ
 v+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwJzLqVp
 S/kBRcDoLc97FWeQTi3hrlYQOuHdf5CQbgTZkTA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:+KPxQa5VGOIhYMCVpwPXwMLXdLJyesId70hD6qhwISY7TiX+rb
 HKoB17726StN9/YhAdcLy7VZVoIkmsl6Kdg7NwAV7KZmCP0wGVxelZnO/fKlbbdREWmNQw6U
 4ZSdkcNOHN
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370712"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 42/57] libs,tools/include: Clean "clean" targets
Date: Mon, 6 Dec 2021 17:02:25 +0000
Message-ID: <20211206170241.13165-43-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

There is no need for an extra "cleanlocal" target, we can use
double-colon rules instead.

Generated headers are now in tools/include/, so remove those file
there.

Remove -f flag as it's already in $(RM).

libs.mk:
  - don't try to remove "*.rpm" anymore.

libs/light:
  - "_paths.*.tmp" isn't created anymore.
  - clean "libxenlight_test.so" and "libxl_test_*.opic".

libs/util:
  - fix clean of version-script file.

include/xen-foreign:
  - remove __pycache__

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk                 |  4 ++--
 tools/include/Makefile             |  1 +
 tools/include/xen-foreign/Makefile |  1 +
 tools/libs/ctrl/Makefile           |  5 +----
 tools/libs/guest/Makefile          |  3 +--
 tools/libs/light/Makefile          | 19 ++++++++-----------
 tools/libs/stat/Makefile           |  5 +----
 tools/libs/util/Makefile           |  7 ++-----
 tools/libs/vchan/Makefile          |  5 +----
 9 files changed, 18 insertions(+), 32 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 7f2c676be4..3078e45cf4 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -121,8 +121,8 @@ TAGS:
 	etags -t *.c *.h
 
 .PHONY: clean
-clean:
-	rm -rf *.rpm $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
+clean::
+	rm -rf $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
 	rm -f headers.chk headers.lst
 	rm -f $(PKG_CONFIG)
diff --git a/tools/include/Makefile b/tools/include/Makefile
index 42605d46b9..a9c11d06c8 100644
--- a/tools/include/Makefile
+++ b/tools/include/Makefile
@@ -80,6 +80,7 @@ uninstall:
 clean:
 	rm -rf xen xen-xsm acpi
 	$(MAKE) -C xen-foreign clean
+	rm -f _*.h
 
 .PHONY: dist
 dist: install
diff --git a/tools/include/xen-foreign/Makefile b/tools/include/xen-foreign/Makefile
index 6ce51daf5e..b538d0ea94 100644
--- a/tools/include/xen-foreign/Makefile
+++ b/tools/include/xen-foreign/Makefile
@@ -13,6 +13,7 @@ clean:
 	rm -f $(headers)
 	rm -f checker checker.c
 	rm -f *.pyc *.o *~
+	rm -rf __pycache__
 
 distclean: clean
 
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index 5d866b8d04..a46e30a168 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -56,8 +56,5 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 
 -include $(DEPS_INCLUDE)
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenctrl.map
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 636b4ea5cb..67837c4e73 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -106,6 +106,5 @@ libxenguest.so.$(MAJOR).$(MINOR): LDLIBS += $(ZLIB_LIBS) -lz
 
 -include $(DEPS_INCLUDE)
 
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenguest.map
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 5e52db9b30..719630eda2 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -250,17 +250,14 @@ install:: $(LIBHEADERS) libxl-save-helper
 uninstall::
 	rm -f $(DESTDIR)$(LIBEXEC_BIN)/libxl-save-helper
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
-	$(RM) -f _*.h *.o $(CLIENTS)
-	$(RM) -f _*.c *.pyc _paths.*.tmp _*.api-for-check
-	$(RM) -f testidl.c.new testidl.c *.api-ok
-	$(RM) -f $(TEST_PROGS)
-	$(RM) -rf __pycache__
-	$(RM) -f libxenlight.map
-	$(RM) -f $(AUTOSRCS) $(AUTOINCS)
+clean::
+	$(RM) _*.h *.o $(CLIENTS)
+	$(RM) _*.c *.pyc _*.api-for-check
+	$(RM) testidl.c.new testidl.c *.api-ok
+	$(RM) $(TEST_PROGS) libxenlight_test.so libxl_test_*.opic
+	$(RM) -r __pycache__
+	$(RM) libxenlight.map
+	$(RM) $(AUTOSRCS) $(AUTOINCS)
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) clean
 
 -include $(DEPS_INCLUDE)
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index c8c81048c0..24b5949b3e 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -115,10 +115,7 @@ install: install-perl-bindings
 uninstall: uninstall-perl-bindings
 endif
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f $(BINDINGS) $(BINDINGSRC) $(DEPS_RM)
 	rm -f libxenstat.map
 
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 87425d862a..4e41bc9ff0 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -51,8 +51,5 @@ $(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
 
 -include $(DEPS_INCLUDE)
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
-	$(RM) -f libxlutil.map
+clean::
+	$(RM) libxenutil.map
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index df112f1b88..f6f1002800 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -13,8 +13,5 @@ NO_HEADERS_CHK := y
 include $(XEN_ROOT)/tools/libs/libs.mk
 -include $(DEPS_INCLUDE)
 
-clean: cleanlocal
-
-.PHONY: cleanlocal
-cleanlocal:
+clean::
 	rm -f libxenvchan.map
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239522.415422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTi-00044A-Nn; Mon, 06 Dec 2021 17:08:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239522.415422; Mon, 06 Dec 2021 17:08:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTi-00042d-E0; Mon, 06 Dec 2021 17:08:38 +0000
Received: by outflank-mailman (input) for mailman id 239522;
 Mon, 06 Dec 2021 17:08:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHQ3-0005ta-1G
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:51 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9dfbc2af-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9dfbc2af-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810288;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=gMyekfXDcNGsX/CAW1bRg9GKSv3KBjGtY1LOz0Cm4h8=;
  b=XZDnVTNGfvU0yHyLfSFnHg3kJhwyBz0/FrVDHR0671U7CSBF0P6F8al1
   SVWXh3Jk9LjDAJ9DqGrWDLwNtQ8QeWgfM43UGXqyL7dqZMCICNtyKAMvH
   NVAPQT8rxJhm8xVTGjniswl9VypA/wCxKdJ0IYHHXyGjFZhhcoAQWm9hC
   E=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: ugtc2Lghlgyvw+rhhLlTfiB9+xuEkNj3nNyDf6h/3r+8Jt0zdMzq0hqm5gt+q9edMT8tzqeOKc
 xKbZo3AteLb6eQae8rcjZhLjOJPJ/v1OvLYRP+vy5kL2eOYuO22FB/y23Kw5YfkSvyCTl8uiJz
 q+Lo55CZaY4uRHDNyy4cCPfAsh05eVPXkDtfVtBuYTWPPwymD4t3M1whOpYsF8E52CVybJJlN1
 keynlX72wBfcdUMStaZF/x659LKdtEjXFgjSszAA+Lm+jAmGHwWR9bTyLz5E/N4UGbnWEPMgIf
 T8z8YN0xqZFzkyvtIlQvJEvt
X-SBRS: 5.1
X-MesageID: 59388058
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9vOAfK3CqD9bG5ysQPbD5Vd2kn2cJEfYwER7XKvMYLTBsI5bp2APn
 GQWWmyDb/3eYzb0L4ojPdyx/B5XuZaHyoBnTgFrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es5w7Bh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhoN1j2
 N8X6ZOJeTwyEoOVwsgZSyRFHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t15seTa6DN
 6L1bxJmN0XkUxxkeWwqAYkOpMijwUCgUCZh/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 nnP+nn0BlcGNN2VwCeB7lqhgPSKmTL8XsQVDrLQ3v91gnWDy2oLEhoUWFCn5/6jhSaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Uz7h2NzazFpR6UHGEeQhZObdUnsIk9QjlC6
 7OSt4q3X3o16uTTEC/DsOfPxd+vBcQLBVAPdz8OF1cK2unYu60d10jjSs5eDaHg27UZBgrM6
 zyNqSE/gZAagsgKy7i38Dj7vt68mnTaZlVrv1uKBwpJ+is8Pdf4PNLwtTA3+N4ZdN7BJmRtq
 kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JBVd0JiN2dDB0wWirhRdMPS
 BWJ0e+2zMUMVEZGlYctP+qM5z0ClMAM7+jNWPHOdcZpaZNsbgKB9ywGTRfOhDCyyhlxy/thZ
 sfznSOQ4ZAyU/4PIN2eHbh17FPW7npmmTO7qW7TkXxLLoZylFbKEOxYYTNin8gy7b+eoRW9z
 jqsH5Di9vmra8WnOnO/2ddKdTgidCFnbbir+50/XrPSeWJORTB+Y8I9NJt8IuSJaYwOzbyWl
 px8M2cFoGfCaYrvdV/XNys9Mey3Bv6SbxsTZEQRALph4FB7Ca7H0UvVX8FfkWAP+LMxwPhqY
 eMCfsncUP1DRi6eo2YWbIXnrZwkfxOu3FrcMy2gaTk5XphhWw2WpYO0IlqxrHEDXnitqM8zg
 7y8zQeHE5ANcBtvUZTNY/W1wlLv4XVEwLBuX1HFK8V4cVn39NQ4MDT4i/I6epleKRjKyjaA+
 RyRBBMU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTqtqqu4Z
 OhTw/XtC9E9nQ5H49hmDrJm7aMi/N+z9bVU+RtpQSfQZFOxB7I+fnTfhZtTtrdAz6NysBetX
 h7d4cFTPLiENZ+3EFMVIwZ5PO2P2etNx2vX5PUxZk77+DV27PyMVkALZ0uAjylULb1UNoI5w
 Lh+5J5KulLn0hd6YMybii109niXKi1SWqoqgZgWHYv3h1d50VpFe5HdVnf77Zznhw+g6aX2z
 ut4XJb/uok=
IronPort-HdrOrdr: A9a23:hiF2la1wElSBYvc6naLsFwqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoV86faUskdoZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOceEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59388058"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH 56/57] stubdom: build xenstore*-stubdom using new Makefile.common
Date: Mon, 6 Dec 2021 17:02:39 +0000
Message-ID: <20211206170241.13165-57-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Makefile.common have everything needed by stubdom, when used with
xenlibs.mk, so we don't need "Makefile" anymore.

Also, remove DESTDIR for "xenstore" related targets, "xenlibs.mk"
doesn't use DESTDIR so its value doesn't matter.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/Makefile | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index 6b804824ba..1fa075b9ad 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -346,8 +346,7 @@ define do_links
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
   ln -sf $(dir $<)*.[ch] .; \
-  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
-  ln -sf $(dir $<)Makefile .
+  ln -sf $(dir $<)Makefile.common .
   touch $@
 endef
 
@@ -356,13 +355,11 @@ define BUILD_lib
  libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
-	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
+	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -f $(CURDIR)/xenlibs.mk -C $$(@D) $$(@F)
 
  clean-libxen$(1):
 	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
 	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
-	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
-	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
 	fi
 
  libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile.common
@@ -494,7 +491,7 @@ xenstore-minios-config.mk: $(CURDIR)/xenstore-minios.cfg
 
 .PHONY: xenstore
 xenstore: $(CROSS_ROOT) xenstore-minios-config.mk
-	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
+	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
 
 #############
 # xenstorepvh
@@ -505,7 +502,7 @@ xenstorepvh-minios-config.mk: $(CURDIR)/xenstorepvh-minios.cfg
 
 .PHONY: xenstorepvh
 xenstorepvh: $(CROSS_ROOT) xenstorepvh-minios-config.mk
-	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
+	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
 
 ########
 # minios
@@ -657,8 +654,8 @@ clean:
 	rm -f *-minios-config.mk
 	rm -fr pkg-config
 	-[ ! -d ioemu ] || $(MAKE) DESTDIR= -C ioemu clean
-	-[ ! -d xenstore ] || $(MAKE) DESTDIR= -C xenstore clean
-	-[ ! -d xenstorepvh ] || $(MAKE) DESTDIR= -C xenstorepvh clean
+	-[ ! -d xenstore ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstore clean
+	-[ ! -d xenstorepvh ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstorepvh clean
 
 # clean the cross-compilation result
 .PHONY: crossclean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239523.415434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTl-0004eA-KR; Mon, 06 Dec 2021 17:08:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239523.415434; Mon, 06 Dec 2021 17:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTl-0004cr-2B; Mon, 06 Dec 2021 17:08:41 +0000
Received: by outflank-mailman (input) for mailman id 239523;
 Mon, 06 Dec 2021 17:08:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHQI-0005ti-Sw
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:05:07 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7d97e8c-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:05:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7d97e8c-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810305;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=YMeuk4EyZtrq5dKLGLHEQrPw6+SmC/P2I22RLaT9xR0=;
  b=KG4g3iqiEiPHqkIZjm0b9afwU6Xl3XHjC3EGNhDrfGxo089cQzf3v2nj
   JiLI9FfkLY1nBgR5lKksl3I3UkfNt7RSxkVtIYyTlwWdXTJ5LMnWLFtsf
   Mtwyqd2CPZHNwdOs633aRf1t3Qfir7SMmT4uhmh9NkXYZNAGrV6sfZHor
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: cZS7i5NppI0ZKBWbjhuZdXUvxBO/n20vAk5qiRBhcoYZGSRAFnU8YMVx7THk7K+kyvTv8nQzUJ
 YmhYF7xk3sUjKNWkf4a0ja6nQPm3CaLTBoZhXCVABD4XPuoeSwz5sZtZEUyB/XLQ7QmPC0s86K
 wWYG66gocSEaWB+rm7xD+Xnt33ofQKWP3pDGrf18eR2FMhmejZQn7vFben4y4E0t9SgQoPxWsD
 iL+OgYvGJZfykaRZIXzcTSIT/cJcf71YHxmWDFmJE/36YpxYg+KuZkgq4En2qtpVOZu9toliJi
 XWPfPJ0R/3KSfKo1UYOGLYry
X-SBRS: 5.1
X-MesageID: 59324170
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:g6ctca702jhmC5dxa2011gxRtL/AchMFZxGqfqrLsTDasY5as4F+v
 jYcCDiCP62Iamf3fIx2bdix/EgGvcCAyYNlGwZtri80Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 cUQioGpcC4TboaLiM4DDxtoQjFmMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTK2EO
 5NGMVKDajzMcRpMfWkQAqllt8C2nVfCb3oArQia8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13/wBwwXMJqDyTuP+2+omsfCmzi+XJMVEvu/7PECqFyMxEQDBRsOT1y5rPKlzEmkVLp3O
 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmEzLbU5ACIQHAJVDdbZPQpscY3QXoh0
 Vrhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTSIUEDQY+uDKmtEYyQLlUIphIP+lltKgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7AFgHZ1
 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGwnTKuKGpxdEdMMX
 KM1kVkLjHO0FCH1BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzyxhzy/BiY
 83FLpbE4ZMm5UJPlmDeqwA1i+BD+8zD7TmLGcCTI+qPj9Jym0J5uZ9aaQDTP4jVHYuPoRnP8
 sY3Cid54043bQEKWQGOqdR7BQlTdRATXMmqw+QKJr/rClc3QwkJVq6OqY7NjqQ4xsy5YM+Tp
 SrjMqKZoXKi7UD6xfKiNio+NeixBMkn9hrW/0UEZD6V5pTqWq73hI93Snf9VeB5nAC65fIrH
 fQDZeuaBfFDFmbO9zgHNMGvp41+bhW7wwmJOnP9MjQ4epdhQS3P+8PlIVSzpHVfUHLvuJtsu
 aCk2yPaXYEHG1ZoAvHJZa/91Fi2p3Ucxr5/BhOaPtlJdUzw24F2MCit3OQvKsQBJEyblDuX3
 gqbGzkCouzJr9Nn+dXFn/nc/YyoD/F/DgxRGGyCteS6MizT/2yCx45cUbnXIWCBBT2soKj7P
 Ldb1fDxNvEDjW1miYskHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc
 UuT4d0Ga66RMcboHVNNdgooauOPiaMdljXItKlnJUz74Gl8/aadUFUUNB6J0XQPILxwOYIj4
 OEgpM9JtFDv1kt0ao6L3nJO6mCBDn0cSKF25JgVDbjihhcv1lwfM4fXDTX74c3XZthBWqXwz
 uR4WEYWa2xg+3f/
IronPort-HdrOrdr: A9a23:k09PNqk6F+yEXIqagw+YTEKu2FnpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59324170"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH 53/57] stubdom: introduce xenlibs.mk
Date: Mon, 6 Dec 2021 17:02:36 +0000
Message-ID: <20211206170241.13165-54-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This new makefile will be used to build libraries that provides
"Makefile.common".

At some point, we will be converting Makefile in tools/ to "subdirmk"
and stubdom build will not be able to use those new makefiles, so we
will put the necessary information for stubdom to build the xen
libraries into a new Makefile.common and xenlibs.mk will use it.
We only need to build static libraries and don't need anything else.

The check for the presence of "Makefile.common" will go aways once
there is one for all libraries used by stubdom build.

Also remove DESTDIR= from "clean" targets, we don't do installation in
this recipe so the value of DESTDIR doesn't matter.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/xenlibs.mk | 13 +++++++++++++
 stubdom/Makefile   |  9 +++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)
 create mode 100644 stubdom/xenlibs.mk

diff --git a/stubdom/xenlibs.mk b/stubdom/xenlibs.mk
new file mode 100644
index 0000000000..5c8742ccf9
--- /dev/null
+++ b/stubdom/xenlibs.mk
@@ -0,0 +1,13 @@
+include $(XEN_ROOT)/tools/Rules.mk
+
+include Makefile.common
+
+LIBNAME := $(notdir $(CURDIR))
+FILENAME_$(LIBNAME) ?= xen$(LIBNAME)
+LIB_FILE_NAME = $(FILENAME_$(LIBNAME))
+
+lib$(LIB_FILE_NAME).a: $(OBJS-y)
+	$(AR) rc $@ $^
+
+clean::
+	rm -f $(OBJS-y) lib$(LIB_FILE_NAME).a
diff --git a/stubdom/Makefile b/stubdom/Makefile
index 5fb5dbc341..fba4c977ef 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -346,6 +346,7 @@ define do_links
   cd $(dir $@); \
   ln -sf $(dir $<)include/*.h include/; \
   ln -sf $(dir $<)*.[ch] .; \
+  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
   ln -sf $(dir $<)Makefile .
   touch $@
 endef
@@ -355,10 +356,14 @@ define BUILD_lib
  libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
-	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -C $$(@D) $$(@F)
+	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
 
  clean-libxen$(1):
-	[ ! -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ] || $$(MAKE) DESTDIR= -C libs-$$(XEN_TARGET_ARCH)/$(1) clean
+	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
+	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
+	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
+	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
+	fi
 
  libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile
 	$$(do_links)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239524.415446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTq-0005YQ-01; Mon, 06 Dec 2021 17:08:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239524.415446; Mon, 06 Dec 2021 17:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTp-0005XQ-M4; Mon, 06 Dec 2021 17:08:45 +0000
Received: by outflank-mailman (input) for mailman id 239524;
 Mon, 06 Dec 2021 17:08:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOn-0005ti-Qt
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:34 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 700d862b-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 700d862b-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810211;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=RWy6yBKQlpWU/yOobumQhfvikIxayYaBVBCgNTpsaGY=;
  b=Ix2xokHxeNA08wqscMEfNNR4NaOJBxqVXTDHwcwH1Kn+kE5BGOtgfUaU
   BzB8NalIk+peJ2Tq28kZWPye2WYm2HVYfg8Ii1V0KSp2kEjwKoKCtn1u3
   UvIYfFTQYZTPufXSOFWoabirY4VFQH8D28I5f8s4+R7APixf8vQtYo/W2
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: obWCpb7PgP7lGZ/vw06wj6m0gHJBU8RE7gWQvx/pTLNahDBgblg3U6Q5ByCSCSgbzGB1F2w1pI
 SL2+zthHzTPYMe/ysIqhbJzJ8iRLQjLQFn9zlME7hEHLm/ABXeTfl1FntUXy5wCtW+6IVvfY0e
 A99BeNIHArW4xCNfYOXx38dYSD7D49oVwlnT3SdXdmRVxH+OGZQ4peOhu7qT6V6XR4JQ8ICusd
 xG9Xk/5q7zO3oIA2pRZshU/64X64SioAxjtXU79vnLeQIeZ2lLM1j7HTGDCSnprpYF61AWbh0X
 BaOrReTNfUx/zR8hhEH85UBQ
X-SBRS: 5.1
X-MesageID: 61420642
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:hqg2YKr+XxWLlLt/GyNHLjxo2YleBmKyYhIvgKrLsJaIsI4StFCzt
 garIBnUM/7bazOgfN8nYNu1pkxXvsSBnIUwQFQ//CBkEyhD9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx24DnW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncS+STUCY4fzpLUYakV9CDBgAbFa5IaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZNFM2IxME6ojxtnPQkuBrE6kPmU2nTnaB1BuXHJt6E72j2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfNgCf6VYQ6BLC+sPlwjzW7xGMJDwYNfUCmuvT/gUm7M/pAL
 2QE9yxoqrI9nGSiSMX9WBup5maJpBcGV/JfFuQ77EeGza+8yxaUAC0IQyBMbPQitdQqXno62
 1mRhdTrCDdz9rqPRhq19L2ZsDezMig9NnIZaGkPSg5ty9j8oqkjgxTXVNFhHaWpyNrvFlnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhFgA11C6KdF2ZvwZAOKu+dpKU9UTH1KMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDB4xap5sRNP/X
 KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2voXgGia24hTmFfK0QfUcXY
 83znSGEVylyNEif5GDqL9rxKJdyrszE+UvdRIrg0zOs2qeEaXieRN8taQXVPr9jvf7e+luKo
 76z0vdmLT0FCoUShQGNruYuwa0idyBnVfgaVeQJHgJ8HuaWMD54UKKAqV/QU4dkg75Uho/1E
 oKVASdlJK7ErSSfc22iMyk7AJu2BMoXhS9rbEQEYAfzs1B+MNnH0UvqX8ZuFVXR3Lc4lqAco
 jhsU5joP8mjvRyboWlANsek89Q5HPlp7CrXVxeYjPEEV8YIb2T0FhXMJ2MDLQECUXi6s9UQu
 bql2l+JSJYPXV06Xs3XdOiu3xW6un1EwLB+WE7BI99yfkTw8dc1d3yt36Fve8xcew/ewja61
 hqNBUtKr+f6vIJoosLCgrqJrtn1HrImTFZaBWTS8Z2/KTLeoji42YZFXevRJWLdWWr49b+Mf
 +JQy/2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAn+YLtxG3V
 0SD/shhFY+IYM61QkQMIAcFb/iY0a1GkDfl8vlocl7x4zV6/eTbXBwKbQWMkiFUMJB8LJghn
 bU6oMcT5gGy1kgqP9KBgnwG/miANCVdAaAut5VcC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf
 WDI1PaT2ewEyxqQaWc3GFjMwfFZ1MYHtx19xVMfI0iEx4jejfgt0RwNqTk6Q2y5FPmcPz6f7
 oSzC3BIGA==
IronPort-HdrOrdr: A9a23:Db7ZU6k+b6ypTBP9Y1458iQUkWPpDfIm3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7Qr5OUtQ/uxoV5PgfZqxz/NICOoqTNWftWvd2FdARbsKheCJ/9SJIVybygc378
 ldmsZFZOEYdWIK7vrH3A==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420642"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of "buildmakevars2header"
Date: Mon, 6 Dec 2021 17:02:01 +0000
Message-ID: <20211206170241.13165-19-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

This avoid the need to generate the _paths.h header when the
information is from autoconf anyway.

They are no more users of the "buildmakevars2header" macro, so it can
be removed from "Config.mk".

Also removed the extra "-f" flag where "$(RM)" is used (xl/Makefile).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 Config.mk                            |  9 ------
 tools/libs/libs.mk                   |  1 -
 .gitignore                           |  6 ----
 configure                            | 45 ++++++++++++++++++++++++++++
 docs/configure                       | 45 ++++++++++++++++++++++++++++
 m4/paths.m4                          |  9 ++++++
 tools/config.h.in                    | 27 +++++++++++++++++
 tools/configure                      | 45 ++++++++++++++++++++++++++++
 tools/console/Makefile               | 12 ++------
 tools/console/client/main.c          |  1 -
 tools/console/daemon/main.c          |  1 -
 tools/helpers/Makefile               |  8 ++---
 tools/helpers/init-xenstore-domain.c |  1 -
 tools/libs/guest/Makefile            |  5 ----
 tools/libs/guest/xg_dom_core.c       |  1 -
 tools/libs/guest/xg_suspend.c        |  1 -
 tools/libs/light/Makefile            |  8 ++---
 tools/libs/light/libxl_dom.c         |  2 --
 tools/libs/light/libxl_internal.h    |  1 -
 tools/libs/light/libxl_utils.c       |  1 -
 tools/libs/stat/Makefile             |  7 +----
 tools/libs/stat/xenstat_qmp.c        |  1 -
 tools/xl/Makefile                    |  7 +----
 tools/xl/xl.h                        |  1 -
 24 files changed, 179 insertions(+), 66 deletions(-)

diff --git a/Config.mk b/Config.mk
index 6587c7d626..1c1998a5a8 100644
--- a/Config.mk
+++ b/Config.mk
@@ -167,15 +167,6 @@ define buildmakevars2file-closure
 	$(call move-if-changed,$(1).tmp,$(1))
 endef
 
-buildmakevars2header = $(eval $(call buildmakevars2header-closure,$(1)))
-define buildmakevars2header-closure
-    $(1): .phony
-	rm -f $(1).tmp; \
-	$(foreach var, $(BUILD_MAKE_VARS), \
-	          echo "#define $(var) \"$($(var))\"" >>$(1).tmp;) \
-	$(call move-if-changed,$(1).tmp,$(1))
-endef
-
 CFLAGS += -fno-strict-aliasing
 
 CFLAGS += -std=gnu99
diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index dfbbef4080..5c2f16dda4 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -132,7 +132,6 @@ clean:
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
 	rm -f headers.chk headers.lst
 	rm -f $(PKG_CONFIG)
-	rm -f _paths.h
 
 .PHONY: distclean
 distclean: clean
diff --git a/.gitignore b/.gitignore
index b42264e209..b39b996718 100644
--- a/.gitignore
+++ b/.gitignore
@@ -123,7 +123,6 @@ tools/libs/foreignmemory/headers.chk
 tools/libs/foreignmemory/xenforeignmemory.pc
 tools/libs/devicemodel/headers.chk
 tools/libs/devicemodel/xendevicemodel.pc
-tools/libs/guest/_*.[ch]
 tools/libs/guest/libxenguest.map
 tools/libs/guest/xenguest.pc
 tools/libs/guest/xc_bitops.h
@@ -146,7 +145,6 @@ tools/libs/light/test_timedereg
 tools/libs/light/test_fdderegrace
 tools/libs/light/tmp.*
 tools/libs/light/xenlight.pc
-tools/libs/stat/_paths.h
 tools/libs/stat/headers.chk
 tools/libs/stat/libxenstat.map
 tools/libs/stat/xenstat.pc
@@ -163,8 +161,6 @@ tools/libs/vchan/libxenvchan.map
 tools/libs/vchan/xenvchan.pc
 tools/console/xenconsole
 tools/console/xenconsoled
-tools/console/client/_paths.h
-tools/console/daemon/_paths.h
 tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/*
 tools/debugger/gdb/gdb-6.2.1/*
 tools/debugger/gdb/gdb-6.2.1.tar.bz2
@@ -207,7 +203,6 @@ tools/fuzz/x86_instruction_emulator/afl-harness-cov
 tools/fuzz/x86_instruction_emulator/wrappers.c
 tools/fuzz/x86_instruction_emulator/x86_emulate
 tools/fuzz/x86_instruction_emulator/x86-emulate.[ch]
-tools/helpers/_paths.h
 tools/helpers/init-xenstore-domain
 tools/helpers/xen-init-dom0
 tools/hotplug/common/hotplugpath.sh
@@ -422,7 +417,6 @@ tools/firmware/etherboot/ipxe.tar.gz
 tools/firmware/etherboot/ipxe/
 tools/python/xen/lowlevel/xl/_pyxl_types.c
 tools/python/xen/lowlevel/xl/_pyxl_types.h
-tools/xl/_paths.h
 tools/xl/xl
 
 docs/txt/misc/*.txt
diff --git a/configure b/configure
index 502273b263..bb7f27ddad 100755
--- a/configure
+++ b/configure
@@ -1946,6 +1946,11 @@ CONFIG_DIR=$sysconfdir
 XEN_CONFIG_DIR=$CONFIG_DIR/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_CONFIG_DIR "$XEN_CONFIG_DIR"
+_ACEOF
+
+
 
 # Check whether --with-initddir was given.
 if test "${with_initddir+set}" = set; then :
@@ -1998,6 +2003,11 @@ fi
 XEN_SCRIPT_DIR=$xen_scriptdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_SCRIPT_DIR "$XEN_SCRIPT_DIR"
+_ACEOF
+
+
 
 # Check whether --with-xen-dumpdir was given.
 if test "${with_xen_dumpdir+set}" = set; then :
@@ -2038,6 +2048,11 @@ LIBEXEC=`eval echo $libexecdir/$libexec_subdir`
 
 LIBEXEC_BIN=${LIBEXEC}/bin
 
+
+cat >>confdefs.h <<_ACEOF
+#define LIBEXEC_BIN "$LIBEXEC_BIN"
+_ACEOF
+
 LIBEXEC_LIB=${LIBEXEC}/lib
 
 LIBEXEC_INC=${LIBEXEC}/include
@@ -2045,12 +2060,27 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
+cat >>confdefs.h <<_ACEOF
+#define XENFIRMWAREDIR "$XENFIRMWAREDIR"
+_ACEOF
+
+
 XEN_RUN_DIR=$rundir_path/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_RUN_DIR "$XEN_RUN_DIR"
+_ACEOF
+
+
 XEN_LOG_DIR=$localstatedir/log/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOG_DIR "$XEN_LOG_DIR"
+_ACEOF
+
+
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
@@ -2060,6 +2090,11 @@ XEN_RUN_STORED=$rundir_path/xenstored
 XEN_LIB_DIR=$localstatedir/lib/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LIB_DIR "$XEN_LIB_DIR"
+_ACEOF
+
+
 SHAREDIR=$prefix/share
 
 
@@ -2073,12 +2108,22 @@ case "$host_os" in
 esac
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOCK_DIR "$XEN_LOCK_DIR"
+_ACEOF
+
+
 XEN_PAGING_DIR=$localstatedir/lib/xen/xenpaging
 
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_DUMP_DIR "$XEN_DUMP_DIR"
+_ACEOF
+
+
 DEBUG_DIR=$debugdir_path
 
 
diff --git a/docs/configure b/docs/configure
index f93d086e9a..d4fced9858 100755
--- a/docs/configure
+++ b/docs/configure
@@ -1849,6 +1849,11 @@ CONFIG_DIR=$sysconfdir
 XEN_CONFIG_DIR=$CONFIG_DIR/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_CONFIG_DIR "$XEN_CONFIG_DIR"
+_ACEOF
+
+
 
 # Check whether --with-initddir was given.
 if test "${with_initddir+set}" = set; then :
@@ -1901,6 +1906,11 @@ fi
 XEN_SCRIPT_DIR=$xen_scriptdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_SCRIPT_DIR "$XEN_SCRIPT_DIR"
+_ACEOF
+
+
 
 # Check whether --with-xen-dumpdir was given.
 if test "${with_xen_dumpdir+set}" = set; then :
@@ -1941,6 +1951,11 @@ LIBEXEC=`eval echo $libexecdir/$libexec_subdir`
 
 LIBEXEC_BIN=${LIBEXEC}/bin
 
+
+cat >>confdefs.h <<_ACEOF
+#define LIBEXEC_BIN "$LIBEXEC_BIN"
+_ACEOF
+
 LIBEXEC_LIB=${LIBEXEC}/lib
 
 LIBEXEC_INC=${LIBEXEC}/include
@@ -1948,12 +1963,27 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
+cat >>confdefs.h <<_ACEOF
+#define XENFIRMWAREDIR "$XENFIRMWAREDIR"
+_ACEOF
+
+
 XEN_RUN_DIR=$rundir_path/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_RUN_DIR "$XEN_RUN_DIR"
+_ACEOF
+
+
 XEN_LOG_DIR=$localstatedir/log/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOG_DIR "$XEN_LOG_DIR"
+_ACEOF
+
+
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
@@ -1963,6 +1993,11 @@ XEN_RUN_STORED=$rundir_path/xenstored
 XEN_LIB_DIR=$localstatedir/lib/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LIB_DIR "$XEN_LIB_DIR"
+_ACEOF
+
+
 SHAREDIR=$prefix/share
 
 
@@ -1976,12 +2011,22 @@ case "$host_os" in
 esac
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOCK_DIR "$XEN_LOCK_DIR"
+_ACEOF
+
+
 XEN_PAGING_DIR=$localstatedir/lib/xen/xenpaging
 
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_DUMP_DIR "$XEN_DUMP_DIR"
+_ACEOF
+
+
 DEBUG_DIR=$debugdir_path
 
 
diff --git a/m4/paths.m4 b/m4/paths.m4
index 7be314a3e2..826faada45 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -39,6 +39,7 @@ AC_SUBST(CONFIG_DIR)
 
 XEN_CONFIG_DIR=$CONFIG_DIR/xen
 AC_SUBST(XEN_CONFIG_DIR)
+AC_DEFINE_UNQUOTED([XEN_CONFIG_DIR], ["$XEN_CONFIG_DIR"], [Xen's config dir])
 
 AC_ARG_WITH([initddir],
     AS_HELP_STRING([--with-initddir=DIR],
@@ -83,6 +84,7 @@ AC_ARG_WITH([xen-scriptdir],
     [xen_scriptdir_path=$XEN_CONFIG_DIR/scripts])
 XEN_SCRIPT_DIR=$xen_scriptdir_path
 AC_SUBST(XEN_SCRIPT_DIR)
+AC_DEFINE_UNQUOTED([XEN_SCRIPT_DIR], ["$XEN_SCRIPT_DIR"], [Xen's script dir])
 
 AC_ARG_WITH([xen-dumpdir],
     AS_HELP_STRING([--with-xen-dumpdir=DIR],
@@ -117,18 +119,22 @@ AC_SUBST(LIBEXEC)
 dnl These variables will be substituted in various .in files
 LIBEXEC_BIN=${LIBEXEC}/bin
 AC_SUBST(LIBEXEC_BIN)
+AC_DEFINE_UNQUOTED([LIBEXEC_BIN], ["$LIBEXEC_BIN"], [Xen's libexec path])
 LIBEXEC_LIB=${LIBEXEC}/lib
 AC_SUBST(LIBEXEC_LIB)
 LIBEXEC_INC=${LIBEXEC}/include
 AC_SUBST(LIBEXEC_INC)
 XENFIRMWAREDIR=${LIBEXEC}/boot
 AC_SUBST(XENFIRMWAREDIR)
+AC_DEFINE_UNQUOTED([XENFIRMWAREDIR], ["$XENFIRMWAREDIR"], [Xen's firmware dir])
 
 XEN_RUN_DIR=$rundir_path/xen
 AC_SUBST(XEN_RUN_DIR)
+AC_DEFINE_UNQUOTED([XEN_RUN_DIR], ["$XEN_RUN_DIR"], [Xen's runstate path])
 
 XEN_LOG_DIR=$localstatedir/log/xen
 AC_SUBST(XEN_LOG_DIR)
+AC_DEFINE_UNQUOTED([XEN_LOG_DIR], ["$XEN_LOG_DIR"], [Xen's log dir])
 
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 AC_SUBST(XEN_LIB_STORED)
@@ -138,6 +144,7 @@ AC_SUBST(XEN_RUN_STORED)
 
 XEN_LIB_DIR=$localstatedir/lib/xen
 AC_SUBST(XEN_LIB_DIR)
+AC_DEFINE_UNQUOTED([XEN_LIB_DIR], ["$XEN_LIB_DIR"], [Xen's lib dir])
 
 SHAREDIR=$prefix/share
 AC_SUBST(SHAREDIR)
@@ -151,12 +158,14 @@ case "$host_os" in
 *) XEN_LOCK_DIR=$localstatedir/lock ;;
 esac
 AC_SUBST(XEN_LOCK_DIR)
+AC_DEFINE_UNQUOTED([XEN_LOCK_DIR], ["$XEN_LOCK_DIR"], [Xen's lock dir])
 
 XEN_PAGING_DIR=$localstatedir/lib/xen/xenpaging
 AC_SUBST(XEN_PAGING_DIR)
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 AC_SUBST(XEN_DUMP_DIR)
+AC_DEFINE_UNQUOTED([XEN_DUMP_DIR], ["$XEN_DUMP_DIR"], [Xen's dump directory])
 
 DEBUG_DIR=$debugdir_path
 AC_SUBST(DEBUG_DIR)
diff --git a/tools/config.h.in b/tools/config.h.in
index 52e01b2c84..9563d3acb6 100644
--- a/tools/config.h.in
+++ b/tools/config.h.in
@@ -96,6 +96,9 @@
 /* IPXE path */
 #undef IPXE_PATH
 
+/* Xen's libexec path */
+#undef LIBEXEC_BIN
+
 /* OVMF path */
 #undef OVMF_PATH
 
@@ -129,6 +132,30 @@
 /* QMP proxy path */
 #undef STUBDOM_QMP_PROXY_PATH
 
+/* Xen's firmware dir */
+#undef XENFIRMWAREDIR
+
+/* Xen's config dir */
+#undef XEN_CONFIG_DIR
+
+/* Xen's dump directory */
+#undef XEN_DUMP_DIR
+
+/* Xen's lib dir */
+#undef XEN_LIB_DIR
+
+/* Xen's lock dir */
+#undef XEN_LOCK_DIR
+
+/* Xen's log dir */
+#undef XEN_LOG_DIR
+
+/* Xen's runstate path */
+#undef XEN_RUN_DIR
+
+/* Xen's script dir */
+#undef XEN_SCRIPT_DIR
+
 /* Enable large inode numbers on Mac OS X 10.5.  */
 #ifndef _DARWIN_USE_64_BIT_INODE
 # define _DARWIN_USE_64_BIT_INODE 1
diff --git a/tools/configure b/tools/configure
index 8e4a59c2cb..829753b5dd 100755
--- a/tools/configure
+++ b/tools/configure
@@ -3926,6 +3926,11 @@ CONFIG_DIR=$sysconfdir
 XEN_CONFIG_DIR=$CONFIG_DIR/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_CONFIG_DIR "$XEN_CONFIG_DIR"
+_ACEOF
+
+
 
 # Check whether --with-initddir was given.
 if test "${with_initddir+set}" = set; then :
@@ -3978,6 +3983,11 @@ fi
 XEN_SCRIPT_DIR=$xen_scriptdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_SCRIPT_DIR "$XEN_SCRIPT_DIR"
+_ACEOF
+
+
 
 # Check whether --with-xen-dumpdir was given.
 if test "${with_xen_dumpdir+set}" = set; then :
@@ -4018,6 +4028,11 @@ LIBEXEC=`eval echo $libexecdir/$libexec_subdir`
 
 LIBEXEC_BIN=${LIBEXEC}/bin
 
+
+cat >>confdefs.h <<_ACEOF
+#define LIBEXEC_BIN "$LIBEXEC_BIN"
+_ACEOF
+
 LIBEXEC_LIB=${LIBEXEC}/lib
 
 LIBEXEC_INC=${LIBEXEC}/include
@@ -4025,12 +4040,27 @@ LIBEXEC_INC=${LIBEXEC}/include
 XENFIRMWAREDIR=${LIBEXEC}/boot
 
 
+cat >>confdefs.h <<_ACEOF
+#define XENFIRMWAREDIR "$XENFIRMWAREDIR"
+_ACEOF
+
+
 XEN_RUN_DIR=$rundir_path/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_RUN_DIR "$XEN_RUN_DIR"
+_ACEOF
+
+
 XEN_LOG_DIR=$localstatedir/log/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOG_DIR "$XEN_LOG_DIR"
+_ACEOF
+
+
 XEN_LIB_STORED=$localstatedir/lib/xenstored
 
 
@@ -4040,6 +4070,11 @@ XEN_RUN_STORED=$rundir_path/xenstored
 XEN_LIB_DIR=$localstatedir/lib/xen
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LIB_DIR "$XEN_LIB_DIR"
+_ACEOF
+
+
 SHAREDIR=$prefix/share
 
 
@@ -4053,12 +4088,22 @@ case "$host_os" in
 esac
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_LOCK_DIR "$XEN_LOCK_DIR"
+_ACEOF
+
+
 XEN_PAGING_DIR=$localstatedir/lib/xen/xenpaging
 
 
 XEN_DUMP_DIR=$xen_dumpdir_path
 
 
+cat >>confdefs.h <<_ACEOF
+#define XEN_DUMP_DIR "$XEN_DUMP_DIR"
+_ACEOF
+
+
 DEBUG_DIR=$debugdir_path
 
 
diff --git a/tools/console/Makefile b/tools/console/Makefile
index 3f4cddab03..207c04c9cd 100644
--- a/tools/console/Makefile
+++ b/tools/console/Makefile
@@ -22,27 +22,19 @@ all: $(BIN)
 clean:
 	$(RM) *.a *.so *.o *.rpm $(BIN) $(DEPS_RM)
 	$(RM) client/*.o daemon/*.o
-	$(RM) client/_paths.h
-	$(RM) daemon/_paths.h
 
 .PHONY: distclean
 distclean: clean
 
-daemon/main.o: daemon/_paths.h
+daemon/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
 daemon/io.o: CFLAGS += $(CFLAGS_libxenevtchn) $(CFLAGS_libxengnttab) $(CFLAGS_libxenforeignmemory) $(CONSOLE_CFLAGS-y)
 xenconsoled: $(patsubst %.c,%.o,$(wildcard daemon/*.c))
 	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenforeignmemory) $(LDLIBS_xenconsoled) $(APPEND_LDFLAGS)
 
-client/main.o: client/_paths.h
+client/main.o: CFLAGS += -include $(XEN_ROOT)/tools/config.h
 xenconsole: $(patsubst %.c,%.o,$(wildcard client/*.c))
 	$(CC) $(LDFLAGS) $^ -o $@ $(LDLIBS) $(LDLIBS_xenconsole) $(APPEND_LDFLAGS)
 
-genpath-target = $(call buildmakevars2header,client/_paths.h)
-$(eval $(genpath-target))
-
-genpath-target = $(call buildmakevars2header,daemon/_paths.h)
-$(eval $(genpath-target))
-
 .PHONY: install
 install: $(BIN)
 	$(INSTALL_DIR) $(DESTDIR)/$(sbindir)
diff --git a/tools/console/client/main.c b/tools/console/client/main.c
index 80157be421..ada6728caa 100644
--- a/tools/console/client/main.c
+++ b/tools/console/client/main.c
@@ -41,7 +41,6 @@
 
 #include <xenstore.h>
 #include "xenctrl.h"
-#include "_paths.h"
 
 #define ESCAPE_CHARACTER 0x1d
 
diff --git a/tools/console/daemon/main.c b/tools/console/daemon/main.c
index 30124a1c19..aac7233a48 100644
--- a/tools/console/daemon/main.c
+++ b/tools/console/daemon/main.c
@@ -31,7 +31,6 @@
 
 #include "utils.h"
 #include "io.h"
-#include "_paths.h"
 
 int log_reload = 0;
 int log_guest = 0;
diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
index 1bcc97ea8a..7f6c422440 100644
--- a/tools/helpers/Makefile
+++ b/tools/helpers/Makefile
@@ -24,6 +24,7 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenguest)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenctrl)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenstore)
 $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += $(CFLAGS_libxenlight)
+$(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
 .PHONY: all
 all: $(PROGS)
@@ -31,8 +32,6 @@ all: $(PROGS)
 xen-init-dom0: $(XEN_INIT_DOM0_OBJS)
 	$(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
 
-$(INIT_XENSTORE_DOMAIN_OBJS): _paths.h
-
 init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
 	$(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS)
 
@@ -47,9 +46,6 @@ uninstall:
 
 .PHONY: clean
 clean:
-	$(RM) -f *.o $(PROGS) $(DEPS_RM) _paths.h
+	$(RM) -f *.o $(PROGS) $(DEPS_RM)
 
 distclean: clean
-
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index b205a79ee6..dba4292803 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -16,7 +16,6 @@
 #include <xen/io/xenbus.h>
 
 #include "init-dom-json.h"
-#include "_paths.h"
 
 #define LAPIC_BASE_ADDRESS  0xfee00000UL
 #define MB(x)               ((uint64_t)x << 20)
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index c6d882e239..8f5f3acd21 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -106,11 +106,6 @@ include $(XEN_ROOT)/tools/libs/libs.mk
 libxenguest.so.$(MAJOR).$(MINOR): COMPRESSION_LIBS = $(filter -l%,$(zlib-options))
 libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
 
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
-$(LIB_OBJS) $(PIC_OBJS): _paths.h
-
 -include $(DEPS_INCLUDE)
 
 .PHONY: cleanlocal
diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c
index 2e4c1330ea..c17cf9f712 100644
--- a/tools/libs/guest/xg_dom_core.c
+++ b/tools/libs/guest/xg_dom_core.c
@@ -33,7 +33,6 @@
 
 #define XG_NEED_UNALIGNED
 #include "xg_private.h"
-#include "_paths.h"
 
 /* ------------------------------------------------------------------------ */
 /* debugging                                                                */
diff --git a/tools/libs/guest/xg_suspend.c b/tools/libs/guest/xg_suspend.c
index 128353029c..0ce6364963 100644
--- a/tools/libs/guest/xg_suspend.c
+++ b/tools/libs/guest/xg_suspend.c
@@ -19,7 +19,6 @@
 #include <xenevtchn.h>
 
 #include "xc_private.h"
-#include "_paths.h"
 #include "xenguest.h"
 
 #define SUSPEND_LOCK_FILE    XEN_RUN_DIR "/suspend-evtchn-%d.lock"
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index bfd58226ce..fb5a9ca87e 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -153,7 +153,7 @@ LIBXL_TEST_OBJS += $(foreach t, $(LIBXL_TESTS_INSIDE),libxl_test_$t.opic)
 TEST_PROG_OBJS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t.o) test_common.o
 TEST_PROGS += $(foreach t, $(LIBXL_TESTS_PROGS),test_$t)
 
-AUTOINCS = $(XEN_INCLUDE)/_libxl_list.h _paths.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+AUTOINCS = $(XEN_INCLUDE)/_libxl_list.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
 AUTOSRCS = _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
 
 CLIENTS = testidl libxl-save-helper
@@ -191,9 +191,6 @@ build: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
 
 $(LIB_OBJS) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
 
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
 libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	$(PERL) $^
 	touch $@
@@ -216,9 +213,8 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 
 $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h $(XEN_INCLUDE)/_libxl_list.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
-libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h _paths.h
+libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
-xl.h: _paths.h
 
 $(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
 $(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index fe9f760f71..c28867f87b 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -24,8 +24,6 @@
 #include <xen/hvm/hvm_xs_strings.h>
 #include <xen/hvm/e820.h>
 
-#include "_paths.h"
-
 //#define DEBUG 1
 
 libxl_domain_type libxl__domain_type(libxl__gc *gc, uint32_t domid)
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index 0b4671318c..37d5c27756 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -73,7 +73,6 @@
 #endif
 
 #include "libxl.h"
-#include "_paths.h"
 #include "_libxl_save_msgs_callout.h"
 
 #if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 1)
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index 4699c4a0a3..b91c2cafa2 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -18,7 +18,6 @@
 #include <ctype.h>
 
 #include "libxl_internal.h"
-#include "_paths.h"
 
 #ifndef LIBXL_HAVE_NONCONST_LIBXL_BASENAME_RETURN_VALUE
 const
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 911a2de8ec..01417b5334 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -30,8 +30,6 @@ APPEND_LDFLAGS += $(LDLIBS-y)
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-$(LIB_OBJS) $(PIC_OBJS): _paths.h
-
 PYLIB=bindings/swig/python/_xenstat.so
 PYMOD=bindings/swig/python/xenstat.py
 PYSRC=bindings/swig/python/_xenstat.c
@@ -121,10 +119,7 @@ clean: cleanlocal
 
 .PHONY: cleanlocal
 cleanlocal:
-	rm -f $(BINDINGS) $(BINDINGSRC) $(DEPS_RM) _paths.h
+	rm -f $(BINDINGS) $(BINDINGSRC) $(DEPS_RM)
 	rm -f libxenstat.map
 
 -include $(DEPS_INCLUDE)
-
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
diff --git a/tools/libs/stat/xenstat_qmp.c b/tools/libs/stat/xenstat_qmp.c
index 2205a04131..9909b9727e 100644
--- a/tools/libs/stat/xenstat_qmp.c
+++ b/tools/libs/stat/xenstat_qmp.c
@@ -23,7 +23,6 @@
 #include <xenctrl.h>
 
 #include "xenstat_priv.h"
-#include "_paths.h"
 
 #ifdef HAVE_YAJL_YAJL_VERSION_H
 #  include <yajl/yajl_version.h>
diff --git a/tools/xl/Makefile b/tools/xl/Makefile
index 2e129f00e1..b7f439121a 100644
--- a/tools/xl/Makefile
+++ b/tools/xl/Makefile
@@ -29,11 +29,6 @@ $(XL_OBJS): CFLAGS += $(CFLAGS_libxentoollog)
 $(XL_OBJS): CFLAGS += $(CFLAGS_XL)
 $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs it.
 
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
-$(XL_OBJS): _paths.h
-
 .PHONY: all
 all: xl
 
@@ -54,7 +49,7 @@ uninstall:
 
 .PHONY: clean
 clean:
-	$(RM) -f *.o xl _paths.h $(DEPS_RM)
+	$(RM) *.o xl $(DEPS_RM)
 
 distclean: clean
 
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index cf12c79a9b..c5c4bedbdd 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -17,7 +17,6 @@
 
 #include <assert.h>
 
-#include "_paths.h"
 #include <xentoollog.h>
 
 struct cmd_spec {
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239525.415451 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTq-0005dg-Tv; Mon, 06 Dec 2021 17:08:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239525.415451; Mon, 06 Dec 2021 17:08:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTq-0005bs-8i; Mon, 06 Dec 2021 17:08:46 +0000
Received: by outflank-mailman (input) for mailman id 239525;
 Mon, 06 Dec 2021 17:08:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOj-0005ta-0t
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:29 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6d8bd62f-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d8bd62f-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810207;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=s3UfqkrJCrnPU+r8syU57IaF/HqfNRQQBSiB7nWPZBY=;
  b=GF/H/cQFUOq5+kGF3FD5MfbubV0i2pV7rNiTa2wwE8mKIZLl22cUosa0
   vsRj1HWRGzCTAlDabNG+QPVkTbpoGX9h9TH8gll+m29VNKwxjfi3uvGPi
   Aaj4fAM2aTUsll+9+T+4EGGfWoKceO6TKlldC/1ToTapiuQUx3pzVuAtX
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: HYhPvvTleilbuF6X8DLTbabFZKcrRfFBG/XY4Mui4lz53nhgfaMq/YsdElTK5/anpFGDVc3Z/y
 pHiYx6Q1kDxW2rqRXjhQz1pURUtCw7uoI0CLC6cMpO283BM4GUsSlKWXbLT3uC3LvuyPcC17zQ
 bBlaApaUAVzsXZxyc+j/n3cQroxFZR8vlQ6GY6/dQvfLEVg4F8mppewlw7uaZR5RcHF5r5E5/8
 44XCTxsbvXTJKic1pK/IumRlLrplsbj5sHfc39o6oFSQxzGCHAJ+CwjAgWg2+qcmQqyEfW87zk
 fOnZsXQJ+Q3oh6Sh/lbUL0m8
X-SBRS: 5.1
X-MesageID: 61420628
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vVb2Zqn3Lf42Oa/bZd7wKzjo5gwrIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJOWmyBa/jeNzTwc9pyaonnpBgP7ZeBmoNgSlBt/ns8QSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PFn8sSZTAMAApWPurggXzN/GnpxE6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ6+CP
 ZJHM2oHgBLoaCVkY01KArgFu9y0oWLZS2F5tmjKqv9ii4TU5FMoi+W8WDbPQfSRXtlclEuco
 mPA/kz6DwscOdjZziCKmlqum+vOkCXTSI8UUrqi+ZZCjFSNy0QJBRYRVF/9puO24mahX/pPJ
 kpS/TAhxYA78lCrSd/sGQW1uneesjYTXtNRF6sx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz
 FiLktj1Qzt1v9W9S3iQ67OVpjOaIjUOICkJYipsZQoa4fHzrYcrlBXNQ91/VqmvgbXI9SrYm
 m7Q6nJk3vNK0JBNh/7TEU37byyEgrKOFicw4izrZiGHsj51TqmsPIOG5g2OhRpfF7qxQl6Et
 XkCvsGR6uESEJ2A/BCwrPUx8KKBvKjcbmCF6bJ7N9x4rmn2pSb/FWxFyGgmfB8BDyoSRdP+j
 KY/Uyt17YQbAnalZLQfj2mZW5VzlviI+TgIu5npgjtyjnpZKVbvEMJGPxf4M4XRfK4Ey/tX1
 XCzK5nEMJriIf47pAdavs9EuVPR+ggwxHnIWbfwxAm93LyVaRa9EOleYATUP71jtv3b8G05F
 uqz0ePQkX2zt8WkPUHqHXM7dwhWfRDX+7iowyCoSgJzClU/QzxwYxMg6bggZ5Zkj8xoehTgp
 RmAtrtj4AOn3xXvcFzSAlg6Me+Hdcsv/BoTYH13VX71iidLXGpaxPpGH3fBVeJ8r7ILID8dZ
 6RtRvhs9dwTEGmaoGpEMsGmxGGgHTzy7T+z0+OeSGBXV/Zdq8bhoLcIpyPjq3sDCDSZr8w7r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJncdsRLRjjxyeB0
 1rECxkvuuSQ8ZQ+98PEhP7Yot7xQfd+BEdTA0LS8a2yaXvB5mOmzIIZCLSIcDnRWXna4qKnY
 ekJnfjwPOdexARBspZmEqYtxqU7voO9q7hfxwViPXPKc1X0Ve8wfijYhZFC7/QfyKVYtA26X
 lO01uNbYbjZatn4FFMxJRY+arjR3/8jhTSPv+8+J1/35XEr8ePfA1lSJRSFlAdUMKBxbNE+2
 e4ktcMbt16/hx4tPorUhyxY7T3RfHkJUqFhvZAGGo77zAEszwgaM5DbDyb35rCJaslNbRZ2c
 mPF2vKaiuQO3FfGfloyCWPJjLhUipk5sRxXyEMPegaSkd3fi/5rhBBc/FzblOiOIsmrBw6rB
 lVWCg==
IronPort-HdrOrdr: A9a23:BelfVqyk0NFLBGIL0wFUKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420628"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Christian Lindig
	<christian.lindig@citrix.com>, David Scott <dave@recoil.org>
Subject: [XEN PATCH 16/57] tools/ocaml: Remove generation of _paths.h
Date: Mon, 6 Dec 2021 17:01:59 +0000
Message-ID: <20211206170241.13165-17-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

_paths.h isn't useful anymore in systemd_stubs.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore                            | 1 -
 tools/ocaml/xenstored/Makefile        | 7 -------
 tools/ocaml/xenstored/systemd_stubs.c | 2 --
 3 files changed, 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index 111eb03b86..b42264e209 100644
--- a/.gitignore
+++ b/.gitignore
@@ -409,7 +409,6 @@ tools/ocaml/libs/xentoollog/xentoollog.ml
 tools/ocaml/libs/xentoollog/xentoollog.mli
 tools/ocaml/libs/xs/paths.ml
 tools/ocaml/libs/xc/xenctrl_abi_check.h
-tools/ocaml/xenstored/_paths.h
 tools/ocaml/xenstored/oxenstored
 tools/ocaml/xenstored/oxenstored.conf
 tools/ocaml/xenstored/paths.ml
diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile
index 89ec3ec76a..0b5711b507 100644
--- a/tools/ocaml/xenstored/Makefile
+++ b/tools/ocaml/xenstored/Makefile
@@ -30,8 +30,6 @@ systemd_OBJS = systemd
 systemd_C_OBJS = systemd_stubs
 OCAML_LIBRARY += systemd
 
-$(foreach obj,$(systemd_C_OBJS),$(obj).o): _paths.h
-
 LIBS_systemd += $(LDFLAGS-y)
 
 OBJS = paths \
@@ -100,8 +98,3 @@ genpath-target = $(call buildmakevars2module,paths.ml)
 $(eval $(genpath-target))
 
 GENERATED_FILES += paths.ml
-
-genpath-target = $(call buildmakevars2header,_paths.h)
-$(eval $(genpath-target))
-
-GENERATE_FILES += _paths.h
diff --git a/tools/ocaml/xenstored/systemd_stubs.c b/tools/ocaml/xenstored/systemd_stubs.c
index 31a1a5d384..f4c875075a 100644
--- a/tools/ocaml/xenstored/systemd_stubs.c
+++ b/tools/ocaml/xenstored/systemd_stubs.c
@@ -27,8 +27,6 @@
 
 #include <systemd/sd-daemon.h>
 
-#include "_paths.h"
-
 CAMLprim value ocaml_sd_notify_ready(value ignore)
 {
 	CAMLparam1(ignore);
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239526.415453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTr-0005lb-Ek; Mon, 06 Dec 2021 17:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239526.415453; Mon, 06 Dec 2021 17:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTq-0005jP-Vz; Mon, 06 Dec 2021 17:08:46 +0000
Received: by outflank-mailman (input) for mailman id 239526;
 Mon, 06 Dec 2021 17:08:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPR-0005ti-UY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:14 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89180612-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89180612-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810252;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=PaRpznZsW3QhyTgpNv/aUOxfOv+4R+mSSEyH1lNtJQI=;
  b=SBZBSIKGVRDPx6CFF3/ef9ANDdOGrVSmsAXDxOwcfJqUeuEmhGn8CUw7
   OeRX0AQgNewZMuWdeGb60ikOoXokholMfVLtznyQnohegyM7yMXNVoQcy
   RcYYi1epG6Ao+MHISWoY5/1k0EySeDc6A8SKZT79X0bnfFY7m/55PCvDI
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: d9acAcAOzi3U71V7z8h/8EuIXSErJ2b8x8dW0cCN7EUtusQeiXA6t/bTKIrDD55MOoVxAJN3CF
 Ml0gjjQWsWFHpRFYv4F3gc+5nBhO+UHulabfemub3AFf1XnVyx1hAJfi4c2fZ+e6Jphwts/tj1
 /U1ldUSuYUvKegC9AnW6OCFv3FY4fId5ftFG5tVIJx+qCQqZRkz/vBQoPVBrYD47eVMUaLQMrb
 8Irf8fhrnXBPlBu92NkltPNLof+32pcMFhL7VNZZ+FN3LojrWfeaqUaSiPlnDIjLISWxOJf+Ll
 csJl/p8j/chk4exi5uXC5LrM
X-SBRS: 5.1
X-MesageID: 61420800
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:XyWYf658CpoDonqek1zseQxRtMnAchMFZxGqfqrLsTDasY5as4F+v
 jZOCGHXOqzYZWL0f41wPY/g/EMB65eGxtdjHlRs+H0yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zl
 IgchaWJaQATGqjnl74aAxhkHgx6IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRKqEP
 5pBMVKDajzmOxx3GgoeMKlno7i4j3LzSWBZtGia8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u12b2GBYBL/SE1CGItHmrg4fnnDz5cJIfEqWi8fxni0HVwXYcYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQiHeCoh4bXcsWC+Ag4RuB4qXR6gedQGMDS1Z8hMcO7ZFsA2Zwj
 xnQwo2vVWcHXKCppWy1qurFnQqLGS8vCWopanUDHQo57vTnv9Rm5v7QdepLHKmwh9zzPDj/x
 TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNf9P9TA1LTN0RpXwG91pHGlt
 WNMpcWR5ftm4XqlxH3UG7Vl8F1ECp+43NzgbbxHQsBJG9eFoSfLkWVsDNdWfh0B3iEsI2CBX
 aMrkVkNjKK/xVPzBUONX6q/Ct4x0Y/rHsn/W/bfY7JmO8YqJFDdrXw0PxDPjwgBdXTAd4llY
 /93lu72Uh4n5VlPlmLqF4/xL5d1rszB+Y8jbc+ilEn2uVZvTHWUVa0EIDOzghMRt8u5TPHu2
 48HbaOikkwHOMWnO3W/2dNDfDgicClgbbir+pM/SwJ2Clc/cI3XI6SKmu1Jlk0Mt/k9q9okC
 VnhABIFkwSm2iWcQehIA1g6AI7SsV9EhSpTFUQR0ZyAghDPuK6js/UScYUZZ74i+LAxxPJ4V
 aBdKc6BHu5OWnLM/DFENcvxq4lrdRKKgwOSPnX6PGhjLsA4HwGZqMX5egbP9TUVCnblv8UJv
 LD9hBjQRoAORlo+AZ+OOu6v1V64oVMUhPl2AxnTOtBWdUi1qNpqJiX9g+UZOcYJLRmflDKW2
 xzPWUUTpPXXop9z+97M3PjWo4CsGup4P0xbA2iEsurmaXiEpjKumNYSXvyJcDbRUHLP1J+jP
 egFnevhNPAnnUpRt9YuGbhc0q9jtcDkoKVXz1o4ESyTPUirEL5pPlKPwdJL6v9W3rZctAa7B
 hCP991dNenbMc/pCgdMdg8sb+DF3vAIgDjCq/8yJRyitiNw+bOGV2RUPgWN13MBfOckbtt9z
 LdzotMS5iy+lgEuY4SPgS1j/miRKmANDvc8vZYADY630gcmxzmuu3AH5vMaNH1XV+hxDw==
IronPort-HdrOrdr: A9a23:a2TtT6gOPfXwgsD7MfyFeYmVuXBQXuIji2hC6mlwRA09TySZ//
 rBoB19726TtN9xYgBZpTnuAsm9qB/nmaKdpLNhWItKPzOW31dATrsSjrcKqgeIc0aVm9K1l5
 0QF5SWYOeAdGSS5vya3ODXKbkdKaG8gcKVuds=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="61420800"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 39/57] libs: Remove both "libs" and "build" target
Date: Mon, 6 Dec 2021 17:02:22 +0000
Message-ID: <20211206170241.13165-40-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

"libs" is odd and has been introduced without a reason by c7d3afbb44.
Instead, only use "all".

Also remove "build" target as "all" is more appropriate and nothing is
using "build" in libs/ in the xen.git repo.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk        | 12 +++---------
 tools/libs/light/Makefile |  2 +-
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 996d467346..7c5ae26bbd 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -53,13 +53,7 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR = $(XEN_INCLUDE)
 $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR = $(CURDIR)
 
 .PHONY: all
-all: build
-
-.PHONY: build
-build: libs libxen$(LIBNAME).map $(LIBHEADERS)
-
-.PHONY: libs
-libs: headers.chk $(LIB) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL)
+all: headers.chk $(LIB) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(LIBHEADERS)
 
 ifneq ($(NO_HEADERS_CHK),y)
 headers.chk:
@@ -96,14 +90,14 @@ lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
 ifneq ($(nosharedlibs),y)
-libs: $(PKG_ABI)
+all: $(PKG_ABI)
 $(PKG_ABI): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) headers.lst
 	$(ABI_DUMPER) $< -o $@ -public-headers headers.lst -lver $(MAJOR).$(MINOR)
 endif
 endif
 
 .PHONY: install
-install: build
+install: all
 	$(INSTALL_DIR) $(DESTDIR)$(libdir)
 	$(INSTALL_DIR) $(DESTDIR)$(includedir)
 	$(INSTALL_SHLIB) lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index fb5a9ca87e..be32d95d39 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -187,7 +187,7 @@ testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
 	$(PYTHON) gentest.py libxl_types.idl testidl.c.new
 	mv testidl.c.new testidl.c
 
-build: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
+all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
 
 $(LIB_OBJS) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239527.415462 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTt-0006Ar-Di; Mon, 06 Dec 2021 17:08:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239527.415462; Mon, 06 Dec 2021 17:08:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTs-00066N-NH; Mon, 06 Dec 2021 17:08:48 +0000
Received: by outflank-mailman (input) for mailman id 239527;
 Mon, 06 Dec 2021 17:08:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPd-0005ti-K4
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:25 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ed2b36a-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ed2b36a-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810263;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=qNEiXbZNcqKEkFNMg9wHhNcWDaVP6Y/xsY+VPfn4eh0=;
  b=GhF2qD+8Bf3DZeX7Fo++ffP8NDxi67gOBZMIGpELxd8F66sVFV2XQZfk
   vbNnPiO7TE8QkjJHH5qTifrJOmd5iCkRPlzLSAv9I7YGBGsAsVlIexGHR
   Th4RPHQZl9Yin8+S1bpgSJHtEO9DMGjqW33g9/fxv7t8OiJtjgRd8PD8X
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: xExfwYnABfsPqQDlHb1Z8/1Yp7pRi/cEttHbvh0dQB9S5rwHUP3z7fp3ALFsXLaNtPULBZbg0Z
 hq9mJ48m0GrgpNVJ2yS8RL1l1D8HQgKRoZZlb0ziquFuJ15/a0UR58QTibn97kTKEc5lxDmGoE
 D+KRi7Gd7HDjo+CF3omn2LRMdGoYnh7T+mxEwUG5Fe1XmYx8hqnRrFzwRTyZPX6pN3bkrK3Py/
 zsedEiZGoF2b52iA4F2lVTZXUA884I+4OeVfCti0VaARKt8HJMOSHE3x+/XKQs5RuIuA0x3ViA
 thGk8uLp6u8jyckhK56W2kAK
X-SBRS: 5.1
X-MesageID: 58884486
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:H1Omlauxkx4sAWI2IXbWlfpzqufnVKdZMUV32f8akzHdYApBsoF/q
 tZmKWjVaa2LNjD1KNxwOdjjoUsC6pGBmtRhHFFp+yFjRi8S+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnJ29TwcOBrT1kulBYyZUDCZvOPZ+weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 5pJNWY/MnwsZTUSE2wRL4oQsNyhuUL2UHpXhFKemqs4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhMVLtuE0hKe72mhwOTImEvTWZ0QPK218OZwh1+ezXBVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhcaR9pXFfx88AyXw7DYywmcD2kACDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8hDK/PygyFXY7byJYfTQJ/N7ypdoLt0eaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9XwsQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm3FF52LJ9k4DNRCyKFBaJxsldjBO
 hC7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHcrH40NBPKhT6ywCDAdJ3T3
 7/BK65A6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILOO5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:V+oIT669Pq5m5c90UwPXwM7XdLJyesId70hD6qhwISY7TiX+rb
 HIoB17726MtN9/YhAdcLy7VZVoBEmsl6KdgrNhWYtKPjOHhILAFugLhuHfKn/bakjDH4ZmpM
 FdmsNFZuEYY2IXsS+D2njaL+od
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="58884486"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 44/57] libs/guest: rename ELF_OBJS to LIBELF_OBJS
Date: Mon, 6 Dec 2021 17:02:27 +0000
Message-ID: <20211206170241.13165-45-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

It seems a better name. Latter, we will introduce LIBX86_OBJS to
collect lib/x86/* objects.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/guest/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 455e23c432..770b9a7ef1 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -33,13 +33,12 @@ CFLAGS += -I$(XEN_libxenctrl)
 vpath %.c ../../../xen/common/libelf
 CFLAGS += -I../../../xen/common/libelf
 
-ELF_OBJS-y += libelf-tools.o libelf-loader.o
-ELF_OBJS-y += libelf-dominfo.o
+LIBELF_OBJS += libelf-tools.o libelf-loader.o
+LIBELF_OBJS += libelf-dominfo.o
 
-OBJS-y += $(ELF_OBJS-y)
+OBJS-y += $(LIBELF_OBJS)
 
-$(ELF_OBJS-y): CFLAGS += -Wno-pointer-sign
-$(ELF_OBJS-y:.o=.opic): CFLAGS += -Wno-pointer-sign
+$(LIBELF_OBJS) $(LIBELF_OBJS:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239529.415469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTu-0006RD-ED; Mon, 06 Dec 2021 17:08:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239529.415469; Mon, 06 Dec 2021 17:08:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTt-0006Jh-Nw; Mon, 06 Dec 2021 17:08:49 +0000
Received: by outflank-mailman (input) for mailman id 239529;
 Mon, 06 Dec 2021 17:08:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHOl-0005ta-Ux
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:32 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6fcc8f94-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:03:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fcc8f94-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810210;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=UhFgmmoOwKtG2lUQa+HnpdBh/Zms8eKZ6E/nA9EQD1A=;
  b=Z1VIgh6Ab/2rTOtL/4e3YhCyiaQlQaK2quttx2yYlvlwny9ApUgUNPrM
   Ez5mWSmul+jzc+x12kmMAOTbvhUdfWT7NW3bShADSiKybNT3BYOHuF0HP
   BfYpcpdewlx3qOr/R5RvVaN3YlEWgZ8RDAr1hlJQwIAL+/1/9b9rmJj6u
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 2cQgVYcnPwKL4omFLQzgezRglJDjdbeB177CK6FPg8FOgTO0hKvmBJs0wS5rSKMvxBQAxvep1e
 16YVNcy5ZFA0xxFgAOuBi4t0o7AMl7pBPGvKH78636RH4zuzpvzScc2OXD/C2rxzkyofIkeV9j
 xpZOkg6GtVWtDU9qsrb9eemm22XuSBjFrfRRcOb1pNfPteTF53HOHxF5cJAZeDTa30nIPqiwui
 7WhbBTOI8+qcQ6vB2Kzf2HG5DLNvydzw1+xBzEy6MuTlSy39XiQTuPAEbQvsJtXXNUnNQBnkp/
 RfyYzGSb6Ca/KLwBNZydODSp
X-SBRS: 5.1
X-MesageID: 59766370
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:jw7WIan2kwBJLn13GEGcVNHo5gxzIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeUDiFbP2PZTanL492YYWxpEsPvJ6Dx99mSAE4qntgFiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PVLjaW5bVsYBJfzpOtFYTJgDgBhA6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeBO
 ZRCNmIHgBLoc1pRPEwyGrsCt9yZ2iCgXmx8iVDJuv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z4HRMyJNGZ0SCC8H+nmqnIhyyTcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhcaR9pXFfx88AyXw7DYywmcD2kACDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8jTWKACExcV44XxA4QlM3yOH+gZ4NgUeaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9XwsQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm3FF52LJ9k4DNRCyKFBaJxsldjBO
 hC7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHcrH40NBPKhT6ywCDAdJ3T3
 7/BK65A6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILO9bHAH43e8RlcL852vZkyPIoH
 fAJd9/ZWqZESyjd+iRbZp749dQweBOujAOIHiykfDlgIMIwG12XoofpLln16S0DLiurrs9i8
 beu4RzWHMgYTAN4AceINP/2lwGtvWIQkf5ZVlfTJoUBY13l9YVncnSjjvI+L8wWBw/Ewz+Wi
 1SfDRsC/LGfqI4p6tjZw6uDqt7xQed5G0NbGUjd7Kq3anaGrjbyn9cYXb/RLz7HVW7y9KGzX
 slvzqnxYK8dgVJHk4tgCLI3n6gw0MTi+u1BxQN+EXSVM1nyUuF8ImOL1NVkv7FWwuMLohO/X
 0+C94UIObiNP8+5QlcdKBB8M7aG3PAQ3DLT8e40MAPx4youpOiLVkBbPh+tji1BLeQqbNN5k
 Ll54MNGuRaijhcKM8qdinEG/muBGXUMTqE7u8xIG4TskAcqlglPbJG05vUaO31ThwGg6nUXH
 wI=
IronPort-HdrOrdr: A9a23:7DuPbaP/E6TtBcBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766370"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: [XEN PATCH 13/57] tools/firmware/hvmloader: remove "subdirs-*" prerequisite
Date: Mon, 6 Dec 2021 17:01:56 +0000
Message-ID: <20211206170241.13165-14-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

hvmloader's last subdir have been removed in 73b72736e6 ("acpi: Move
ACPI code to tools/libacpi"), so there is no need to use "subdirs-*"
target anymore.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/firmware/hvmloader/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile
index e980ce7c5f..b754220839 100644
--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -60,7 +60,7 @@ ROMS += $(ROMBIOS_ROM) $(STDVGA_ROM) $(CIRRUSVGA_ROM)
 endif
 
 .PHONY: all
-all: acpi subdirs-all
+all: acpi
 	$(MAKE) hvmloader
 
 .PHONY: acpi
@@ -104,7 +104,7 @@ endif
 	mv $@.new $@
 
 .PHONY: clean
-clean: subdirs-clean
+clean:
 	rm -f roms.inc roms.inc.new acpi.h
 	rm -f hvmloader hvmloader.tmp *.o $(DEPS_RM)
 	$(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(CURDIR) clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239531.415490 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTy-0007GB-Am; Mon, 06 Dec 2021 17:08:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239531.415490; Mon, 06 Dec 2021 17:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHTx-0007BR-5d; Mon, 06 Dec 2021 17:08:53 +0000
Received: by outflank-mailman (input) for mailman id 239531;
 Mon, 06 Dec 2021 17:08:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPs-0005ta-DY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:40 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98427bb0-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98427bb0-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810279;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=17GkR2xfeFdZkqadd7WfridmnTOn9dqn81AQSUR5V8Y=;
  b=J9ufKmkMFChxQwBbExT+t1+v6uNH19nH/9wxyT1vk3TmQzDidfe3xptB
   4578FWxRfZF8cU2R/UgMfdZwmed0OulSXsOKIfr7Xujy+I7wNZ7sGzb3h
   FtxJTlMm9/sUb5S1sxkwwftLsBPBnT/Cv8PZQW5efIzRk1AyMn3f9QFfC
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: UhMOe3HRq3IERCXBxThFhYhUOmg/zdsXCCRGZvlVBmcE4BIEchc7diJKsCJYjDbo+jKYCVGa4j
 xzLpUfxdlwpJiRgjyXY2D6Mfvoehl8Vt3+JBfHvWJt4A05qrNmxtrWi9xEipg0G4Ff491qskY2
 xp8vFZbah0Rks6rY2tXprW7h5FZYl8UjOgYmScAOuVi71JLyjp2HT7/4vd4geeqU6RqNEqn9Hi
 ERIrBwawgstyAyPnHW9Ca75fvBTAyS6WR7VPeC/HEcrNp5mIEL0MGIEEAgFTApyy9GI0/+Z9XC
 pplvkS2dkKBEgQKpNfb4Vzq/
X-SBRS: 5.1
X-MesageID: 59370747
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:ocw5Oqjh1HCGEWY+22waEaFJX1615BcKZh0ujC45NGQN5FlHY01je
 htvDT+Eb/aKNmX0Ktl3YYnloBwGv8TczoJgHlZor389QXgb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0Wka2pUBUoH5ecgekGf15ZMgFgL5dvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPP
 JVBNmYwBPjGSyVTOQtUFMIApuCluiHSSSdd9E7J+7VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRGRgfKdGbjyaF83ilm+vTtS79Q8cWBbq+sPlwjzW7x3MRIA0bU0Ohpvu0gVL4XMhQQ
 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l4qPS/waeAHlCVjNbYcYqnMAzTD0uk
 FSOmrvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsFi80+sDxoaAJ3gvCVfokEY+VkM/PMGSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgDZ5
 CBspiSI0AwZ4XhhfgSpSf5FIrym7u3t3Nb00Q82RMlJG9hAFheekWFsDNNWeR4B3iUsI2aBj
 KrvVeV5vsU70JyCN/AfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZ3wf5la
 MrBK5jzXR727JiLKhLsHY/xNpdxmUgDKZ77H8inn3xLL5LADJJqdVv1GATXNb1ohE91iA7U7
 8xeJ6O3J+Z3C4XDjt3s2ddLdzgidCFjbbiv8pA/XrPTc2JORTB6Y9eMkOxJRmCQt/kM/gs+1
 irmAREwJZuWrSCvFDhmnVg/Mu6yBsgm8ipgVcHuVH7xs0UejU+UxP93X/MKkXMProSPFNZ4E
 KsIfduuGPNKRmiV8jgRd8Cl/odjaA6qlUSFOC/8OGozeJtpRgro/N74f1SwqHlSX3Tv7cZu8
 ae90g77QIYYQ1gwBsjhd//ynUi6umIQmbwuUhKQcMVTYkjl7KNjNzf10q0sO8gJJBianmma2
 g+aDA02v+7Ip4NpotDFibrd99WiEvdkH1ocFG7etO7kOS7f92ul4IlBTOfXImyNCDKqoP2vP
 LwHwev9PfsLmEdxn7B9S7s7n7gj49bPpqNBylg2Fnv8cFn2WKhrJWOL3JcTu/QVlKNZowa/R
 mmG5sJeZeeSIMrgHVMceFglY+CE2a1GkzXe961ockDz5Ssx97ubS0RCeRKLjXUFfrdyNYokx
 8YnudIXtFPj2kZ7bI7eg3AG7XmII1wBT74j58MTD4LcgwY2zk1PPM7HASjs7ZDTM9hBPyHG+
 NNPaHYuU1iE+nf/Tg==
IronPort-HdrOrdr: A9a23:35G8C6MxWg2RDMBcTsejsMiBIKoaSvp037Eqv3ofdfUzSL3+qy
 nOpoVj6faaslcssR0b9OxofZPwI080lqQFhbX5X43DYOCOggLBR+tfBMnZsljd8kXFh4hgPM
 xbHZSWZuedMbEDt7eY3DWF
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370747"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: [XEN PATCH 52/57] stubdom: only build libxen*.a from tools/libs/
Date: Mon, 6 Dec 2021 17:02:35 +0000
Message-ID: <20211206170241.13165-53-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Avoid generating *.map files or running headers.chk when all we need
is the libxen*.a.

Also, allow force make to check again if libxen*.a needs rebuilt by
adding a '.PHONY' prerequisite.

Also, remove DESTDIR= as we don't do installation in this target, so
the value of DESTDIR doesn't matter.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/stubdom/Makefile b/stubdom/Makefile
index ccfcf5b75f..5fb5dbc341 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -354,8 +354,8 @@ define BUILD_lib
  .PHONY: libxen$(1) clean-libxen$(1)
  libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
  libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
- libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE)
-	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) DESTDIR= CONFIG_LIBXC_MINIOS=y -C libs-$$(XEN_TARGET_ARCH)/$(1)
+ libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
+	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -C $$(@D) $$(@F)
 
  clean-libxen$(1):
 	[ ! -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ] || $$(MAKE) DESTDIR= -C libs-$$(XEN_TARGET_ARCH)/$(1) clean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239533.415500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU1-00080l-EB; Mon, 06 Dec 2021 17:08:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239533.415500; Mon, 06 Dec 2021 17:08:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU0-0007vE-E9; Mon, 06 Dec 2021 17:08:56 +0000
Received: by outflank-mailman (input) for mailman id 239533;
 Mon, 06 Dec 2021 17:08:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHP0-0005ti-J6
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76fafa5b-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76fafa5b-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810224;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Ix7uXYCPxugAAtLthbMjrkXsWY6ZoE/GgEwLTETP25c=;
  b=HkuGhOiQBrLNYJa4UIkLEKTPPtJUsvjCuMKRN80MengjAkbJQP3vt0j0
   6Bhd6+WI0qBTim5Z2LISx6bNS/9fYMLqQUAF9EeZM1Otxt0P8YJiqifFF
   wk7Bz8qLhTcNebpBRasxGqBs3DMMh2PtTSPXr8E4qEuY+Hnv/FolyhSdO
   Q=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: W+6FDTCdqCvWJA91+Gi73joeTWqDf7MYYkzAqMOaROaKbqtY4oGOrlJaoLwkdkhkjx9LCLRdY6
 /yhNcqoBH5dyxVqiUkM8e/6ilOJv11Zk7h/U8Rj5S0gB6S5ogZuiert7E486DpnXZF0wG0Ep2g
 DIsjyLrXsjdd8ai2RPdYwnJ7bW5F25bnp6CoxhO1wAnz8PplF21Tl8aKPBWLQfXYwXzivpIzzf
 8+8Nglt8SK8xnTXr8yVGKPh1jcAcw8OlzcFEJTGyXQipi/FWRo9hHgi3ABt9ht3RJOy+IbSrYe
 VG1CGlsFL9cOnNQcQFsTL/w6
X-SBRS: 5.1
X-MesageID: 59370634
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sdDexa7J3WzLRb1HIZpuEQxRtN7AchMFZxGqfqrLsTDasY5as4F+v
 mROWm+CM/eDM2emc9l1PNzlpksH7JfUndNlGQA5qC5nHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zy
 cgWk6bzcCwVLvPIvedMSiYIHhFFBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTK2BP
 5RCNVKDajzwIEEeGlIHJK4Mjby6tlvkWRRSqlK88P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 2Qd/DYuqq4jslSmVNDnUzW3pXeFulgXXN84LgEhwFjTkOyOuV/fXzVaCG4aADA7iCMobT03j
 Xmz3OrCOSwxtJiWGGuiprqklgrnbED5MlQ+TSMDSAIE5fzqr4cykg/DQ75fLUKlsjHmMWqum
 m7X9UDSk51W1JdWjPvjoTgrlhr1/sCRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1
 JTodiX30QzvMX1vvHHUKAnuNOvwjxpgDNE6qQQ1d3XG327yk0NPhagKvFlDyL5Ba67ogwPBb
 k7Joh9275ROJnasZqIfS9vvUJR1l/m9T467CaC8gj9yjn5ZLlXvEMZGPxH44owQuBJ0zfFX1
 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI50/P7FZqX1bMEe1tGALXNogRtfrYyC2Io
 4c3H5bbkH13DbyhChQ7BKZOdDjm21BgXsuowyGWH8beSjdb9JYJV6WMnOh/ItM9xMy4VI7gp
 xmAZ6OR83Kn7VWvFOlAQikLhGrHUcktoHQlEzYrOFr0iXEvbZz2tPUUdoctfKlh/+tmlKYmQ
 /4AcsSGI/JOVjWYpGhNMcij9NRvJEaxmAaDHyu5ezxjLZRucBPEp43/dQz1+ShQUifu7Zkio
 6et3x/wSIYYQ1gwF97fbf+ilgvjvXUUlO9ocVHPJ91fJBfl/IRwcnSjhf4rOcAcbx7Ew2LCh
 QqRBB4Zo8jLopM0r4aV1fzV8d/xHrInTERAHmTd4bKnDgXg/zKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmB+8yInSC2sUT5KRByqUA5FmzU
 0OLvNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOonOYwo9
 u4tpcoK5lHtkREtKNuH0nhZ+mnkwqbsiEn7WkX22LPWtzc=
IronPort-HdrOrdr: A9a23:gyIN6KDA4wJph53lHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P
 xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370634"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 25/57] tools/examples: cleanup Makefile
Date: Mon, 6 Dec 2021 17:02:08 +0000
Message-ID: <20211206170241.13165-26-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Don't check if a target exist before installing it. For directory,
install doesn't complain, and for file it would prevent from updating
them.

Remove XEN_CONFIGS-y which isn't used.

Remove "build" target.

Add an empty line after the first comment. The comment isn't about
$(XEN_READMES), it is about the makefile as a whole.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/examples/Makefile | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/tools/examples/Makefile b/tools/examples/Makefile
index 14e24f4cb3..48b520e133 100644
--- a/tools/examples/Makefile
+++ b/tools/examples/Makefile
@@ -2,6 +2,7 @@ XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 # Xen configuration dir and configs to go there.
+
 XEN_READMES = README
 
 XEN_CONFIGS += xlexample.hvm
@@ -10,14 +11,9 @@ XEN_CONFIGS += xlexample.pvhlinux
 XEN_CONFIGS += xl.conf
 XEN_CONFIGS += cpupool
 
-XEN_CONFIGS += $(XEN_CONFIGS-y)
-
 .PHONY: all
 all:
 
-.PHONY: build
-build:
-
 .PHONY: install
 install: all install-readmes install-configs
 
@@ -26,10 +22,8 @@ uninstall: uninstall-readmes uninstall-configs
 
 .PHONY: install-readmes
 install-readmes:
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
-	set -e; for i in $(XEN_READMES); \
-	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
+	set -e; for i in $(XEN_READMES); do \
 	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \
 	done
 
@@ -39,12 +33,9 @@ uninstall-readmes:
 
 .PHONY: install-configs
 install-configs: $(XEN_CONFIGS)
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
-	[ -d $(DESTDIR)$(XEN_CONFIG_DIR)/auto ] || \
-		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)/auto
-	set -e; for i in $(XEN_CONFIGS); \
-	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
+	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)/auto
+	set -e; for i in $(XEN_CONFIGS); do \
 	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \
 	done
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:08:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:08:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239534.415509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU3-0008H1-3l; Mon, 06 Dec 2021 17:08:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239534.415509; Mon, 06 Dec 2021 17:08:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU1-0008Bn-Ux; Mon, 06 Dec 2021 17:08:57 +0000
Received: by outflank-mailman (input) for mailman id 239534;
 Mon, 06 Dec 2021 17:08:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPO-0005ti-Fh
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:10 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 870083b8-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 870083b8-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810249;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=0MivWbgo/dLtJel8lLkqzy+izVyO5ow6ugdRMsmNQz0=;
  b=EOySLkNTKVERhcqzMXigBnfPDtTn5pAR8B6Ypw68AYeQfFYORdRc7mhh
   N+yM0E36fha1MAm5a21u2VQyk9fjr9pPweDs+KHAojSHDzy3uksIyPCH9
   kLe7q0C3WZw8HGT7O1bnzY0ydItym3U3ndDhcY69AV8xuSgHA+hPEPKp5
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: rveRkO69cS5gYtM8H32HobqBjT2KVOUK5TVZeI+5UwQqioiB+OXKu5w7jiSiiCfFnAEKNDq5rJ
 g0lz0xDT/NW4GnU6DRrHx0fjMwYA40k2Nf1LMHVLA1o5xxhshiRkmZoI3KdTvIfoY213EoNyhx
 pBaKM57RKF/Vl404T+3Wiuhf8Ak/l2ZcuZS93NNT9Pw0ndw8E8zZxOYilJc98R5e/MN6Pggtkh
 dshOn3RjUwMrxzvmv8CMoEyEjg7ZzLclaC6Wa3MpmcN5Iamsx/sD5W07Khx5fPWEdvun7X8rB0
 e/hWg+j3Wi5eYf6QFmI2Rs2W
X-SBRS: 5.1
X-MesageID: 59387924
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:unO4M62HfnKd/mC98PbD5Vh2kn2cJEfYwER7XKvMYLTBsI5bpzZTn
 2ZNDTiBaamOMzDzKNl1PIi0p01T6sPXnIJgGQZqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan8ZqTNMEn970Es5w7Bh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhu/R65
 OcR5JaJRVk7bo7lobsFWR0GHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t15seQqeEO
 6L1bxJWZUTwMzIQFm0dVtE7mbyHiWTeQixh/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 mDJ5WPiGTkBKceSjzGC9xqEhPLLnC79cJIfEvu/7PECqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySDR9/hXxq+sTicswQVQdZ4HOgz6QXLwa3Riy6YGWosXjNHcMYhtsI9WXotz
 FDhoj/yLWUx6vvPEyvbr+rK62PpUcQIEYMcTQsgRic3v4jpmY1tnELsZ+88CKSx0NKgTFkc3
 Au2hCQ5grwSi+sC2KO64U3LjlqQm3TZcuImzl6JBzz4t2uVcKbgPtX1sgaDsZ6sOa7AFgHZ1
 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyyyGwnTKuKGpxdEdMMX
 KM1kVkLjHO0FCH1BZKbm6rrV6wXIVLcPdrkTOvISdFFf4J8cgSKlAk3OxXAgDq8zRJ2z/5vU
 Xt+TSpKJSxAYUiA5GDpL9rxLJdxnnxurY8tbc6TI+ubPUq2OyfOFOZt3KqmZeEl9qKUyDg5A
 P4EX/ZmPy53CbWkCgGOqNZ7BQlTcRATWMCnw+QKJ7XrClc3Rwkc5wr5nOpJU5Z7hJ5ciuqg1
 ij7Aie0PnKk3iaZQehLA1g+AI7SsWFX8ShmYHdyZAnwgBDOo++Htc8iSnf+RpF/nMQL8BK+Z
 6NdEylZKvgQGDnB5RoHapzx8N5reBix3FrcNCu5ejkvOZVnQlWRqNPjewLu8ggIDza26pRi8
 +HxiFuDTMpRXRlmAebXdOmrkwG7s08Clb8gREDPONRSJhnhqdA4Nyzrg/YrCMgQMhGflCCC3
 gObDE5A9+nAqoM46vfTgqWAo9v7GudyBBMCTWLa8ay3JW/R+W/6md1MV+OBfDb8UmLo+fr9O
 bUJnq+kaPBexQREqYtxFbpv3JkS3dq3qu8I1BlgEVXKc0+vVuFqLE6Z0JQdraZK3LJY51e7A
 xrd5tlANLyVE8r5C1pNdhE9Z+GO2PxIyDnf6fM5fBfz6CNtpefVVExTO1+HiTBHLaszO4Qgm
 L9ztMkT4g25qxwrLtfZ0XwEqzXSdiQNA/c9q5UXII73kQ56mFhNbKvVBjLy/JzSOc5HNVMnI
 2PMiafP71iGKpEur5bn+aDx4Ndg
IronPort-HdrOrdr: A9a23:HShvlaqm77F9uaY9dR+79q0aV5oteYIsimQD101hICG8cqSj+P
 xG+85rsiMc6QxhIU3I9urgBEDtex7hHNtOkOss1NSZLW3bUQmTTL2KhLGKq1aLJ8S9zJ856U
 4JSdkZNDSaNzZHZKjBjDVQa+xQo+W6zA==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387924"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
Date: Mon, 6 Dec 2021 17:02:19 +0000
Message-ID: <20211206170241.13165-37-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Regroup *FLAGS together, use $(LDLIBS).

Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't
decribe how to link to a potential libxenstored.so, instead add the
value to $(LDLIBS) of xenstored.

Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).

Remove the "-I." from $(CFLAGS), it shouldn't be needed.

Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
in $(CFLAGS) and both aren't used anyway.

Rename ALL_TARGETS to TARGETS.
Only add programmes we want to build in $(TARGETS), not phony-targets
(replace "clients").

Store all `xenstored` objs into $(XENSTORED_OBJS-y).

Replace one $< by $^ even if there's only one dependency,
(xenstore-control).

clean: "init-xenstore-domain" isn't built here, so stop trying to
remove it, remove $(TARGETS).

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/xenstore/Makefile | 81 ++++++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 37 deletions(-)

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 292b478fa1..7fe1d9c1e2 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -5,7 +5,6 @@ MAJOR = 3.0
 MINOR = 3
 
 CFLAGS += -Werror
-CFLAGS += -I.
 # Include configure output (config.h)
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 CFLAGS += -I./include
@@ -16,36 +15,53 @@ CFLAGS += $(CFLAGS_libxentoolcore)
 CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
 CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
 
-CFLAGS  += $(CFLAGS-y)
-LDFLAGS += $(LDFLAGS-y)
+ifdef CONFIG_STUBDOM
+CFLAGS += -DNO_SOCKETS=1
+endif
 
-CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
-CLIENTS += xenstore-write xenstore-ls xenstore-watch
+XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
+XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
+XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
 
-XENSTORED_OBJS = xenstored_core.o xenstored_watch.o xenstored_domain.o
-XENSTORED_OBJS += xenstored_transaction.o xenstored_control.o
-XENSTORED_OBJS += xs_lib.o talloc.o utils.o tdb.o hashtable.o
+XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_SunOS) += xenstored_solaris.o xenstored_posix.o xenstored_probes.o
+XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
 
-XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_SunOS) = xenstored_solaris.o xenstored_posix.o xenstored_probes.o
-XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_FreeBSD) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o
+$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
 
-XENSTORED_OBJS += $(XENSTORED_OBJS_y)
-LDLIBS_xenstored += -lrt
+xenstored: LDLIBS += $(LDLIBS_libxenevtchn)
+xenstored: LDLIBS += $(LDLIBS_libxengnttab)
+xenstored: LDLIBS += $(LDLIBS_libxenctrl)
+xenstored: LDLIBS += -lrt
+xenstored: LDLIBS += $(SOCKET_LIBS)
 
-ALL_TARGETS = clients
-ifeq ($(XENSTORE_XENSTORED),y)
-ALL_TARGETS += xs_tdb_dump xenstored
+ifeq ($(CONFIG_SYSTEMD),y)
+$(XENSTORED_OBJS-y): CFLAGS += $(SYSTEMD_CFLAGS)
+xenstored: LDLIBS += $(SYSTEMD_LIBS)
 endif
 
-ifdef CONFIG_STUBDOM
-CFLAGS += -DNO_SOCKETS=1
+xenstore: LDLIBS += $(LDLIBS_libxenstore)
+xenstore: LDLIBS += $(LDLIBS_libxentoolcore)
+xenstore: LDLIBS += $(SOCKET_LIBS)
+
+xenstore-control: LDLIBS += $(LDLIBS_libxenstore)
+xenstore-control: LDLIBS += $(LDLIBS_libxenctrl)
+xenstore-control: LDLIBS += $(LDLIBS_libxenguest)
+xenstore-control: LDLIBS += $(LDLIBS_libxentoolcore)
+xenstore-control: LDLIBS += $(SOCKET_LIBS)
+
+CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
+CLIENTS += xenstore-write xenstore-ls xenstore-watch
+
+TARGETS := xenstore $(CLIENTS) xenstore-control
+ifeq ($(XENSTORE_XENSTORED),y)
+TARGETS += xs_tdb_dump xenstored
 endif
 
 .PHONY: all
-all: $(ALL_TARGETS)
+all: $(TARGETS)
 
 .PHONY: clients
 clients: xenstore $(CLIENTS) xenstore-control
@@ -62,37 +78,28 @@ xenstored_probes.o: xenstored_solaris.o
 CFLAGS += -DHAVE_DTRACE=1
 endif
 
-ifeq ($(CONFIG_SYSTEMD),y)
-$(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
-xenstored: LDFLAGS += $(SYSTEMD_LIBS)
-endif
-
-$(XENSTORED_OBJS): CFLAGS += $(CFLAGS_libxengnttab)
-
-xenstored: $(XENSTORED_OBJS)
-	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenctrl) $(LDLIBS_xenstored) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+xenstored: $(XENSTORED_OBJS-y)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
-xenstored.a: $(XENSTORED_OBJS)
+xenstored.a: $(XENSTORED_OBJS-y)
 	$(AR) cr $@ $^
 
 $(CLIENTS): xenstore
 	ln -f xenstore $@
 
 xenstore: xenstore_client.o xs_lib.o
-	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
 xenstore-control: xenstore_control.o
-	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
 xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
-	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
 
 .PHONY: clean
 clean:
 	rm -f *.a *.o xenstored_probes.h
-	rm -f xenstored
-	rm -f xs_tdb_dump xenstore-control init-xenstore-domain
-	rm -f xenstore $(CLIENTS)
+	rm -f $(TARGETS)
 	$(RM) $(DEPS_RM)
 
 .PHONY: distclean
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239535.415516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU4-0000D9-O0; Mon, 06 Dec 2021 17:09:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239535.415516; Mon, 06 Dec 2021 17:09:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU3-00009C-JE; Mon, 06 Dec 2021 17:08:59 +0000
Received: by outflank-mailman (input) for mailman id 239535;
 Mon, 06 Dec 2021 17:08:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPp-0005ti-GG
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:37 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96699ceb-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96699ceb-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810276;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=zPznA+ybTAJl3D8zcQnhTs5UDGVeYxfDltfmGygnLGQ=;
  b=STIgGQTNlh9jB0/IGPm8JuavQoMZ/tfLLm998++yJRPOYM5rsWUUqf3k
   m/MOplJNeY0OGxD9GZTCnatGeOwfE3RhSg9Sjj0laJX0RuTH4QZgQasNp
   poLuEFAf2juiEYddGz6xHvdwV4+Eh/jY56nclM2cN4cr9HYII0sPcsSiX
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: gZwrIIIs3fLrpeQ+GGmDbXU+P58vuCi5Hayev4yJSne9H5ciXanMGjY0fP3svhoj80aZfncUS2
 WCBeQCInyhrPO8+SJKNNSG0P0FIhMMxYHyXzjocvEyOpvqbV9Mgin3kKEhhoZZf9gHUNNBXlpO
 /TYODsuZhpcdc3Bq3h27Zt6FM7+f48BW2C8g9TLFteRjHfOCvX9XmpIhkloprMQK21Y6YuPTqU
 z4SdBaN6pURXCI1svNLy4X6oPeHR200PIvc19ZBQmcRgCyl+h2Dh/62EWcBmWz4Tvxh4JgNIR5
 3dep41H4LxF6zQ+SvphuvSX+
X-SBRS: 5.1
X-MesageID: 59388028
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dn+4VqLhcPaplsttFE+RN5IlxSXFcZb7ZxGr2PjKsXjdYENS12MGz
 zAdDGHQaaqJamHyeN92Odiy9EIAv5eGy9NiTAJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xbZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3OsOtew
 9IWj6aiEyUtFK+Px9QRDStXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph3ZAeRayOD
 yYfQSpUaUuZWx9LBls0MpYavNuGhnXteSIN/Tp5ooJoujOOnWSdyoPFMcXXUsyHQ91PmUSVr
 X6A+H72ajkFMPSPxDzD9Wij7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9tZN
 0wT/DtotaUo/VanZtb4Vhy85nWDu3Yht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIO8+ANajctj
 WWzjYnLARZt8+KlRSyv+eLBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Qmf22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUMjleM+lGrxl8FSVCxCtame0bblHRcZJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPEsM93rWplwl/a/RbwJs8w4iPIUOPCdkyfdo0lTibO4hTixwCDAb4lhU
 XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r
 ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI6Qjx8UKGInut6E2Gn9owM/tr1E
 riGchcw4DLCabfvcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:UVriIqyDW1TiTI9jG0rwKrPwKr1zdoMgy1knxilNoRw8SKOlfq
 eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ
 0QFZSWY+efMbEVt6rHCXGDYrUd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59388028"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 50/57] tools/Rules.mk: Cleanup %.pc rules
Date: Mon, 6 Dec 2021 17:02:33 +0000
Message-ID: <20211206170241.13165-51-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

PKG_CONFIG_VARS isn't used anymore.
For "local" pkg-config file, we only have one headers directory now,
"tools/include", so there is no need to specify it twice. So remove
$(CFLAGS_xeninclude) from "Cflags:".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/Rules.mk | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/Rules.mk b/tools/Rules.mk
index 0d3febfbb6..47424935ba 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -184,12 +184,11 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR)
 	echo "prefix=$(PKG_CONFIG_PREFIX)"; \
 	echo "includedir=$(PKG_CONFIG_INCDIR)"; \
 	echo "libdir=$(PKG_CONFIG_LIBDIR)"; \
-	$(foreach var,$(PKG_CONFIG_VARS),echo $(var);) \
 	echo ""; \
 	echo "Name: $(PKG_CONFIG_NAME)"; \
 	echo "Description: $(PKG_CONFIG_DESC)"; \
 	echo "Version: $(PKG_CONFIG_VERSION)"; \
-	echo "Cflags: -I\$${includedir} $(CFLAGS_xeninclude)"; \
+	echo "Cflags: -I\$${includedir}"; \
 	echo "Libs: -L\$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)"; \
 	echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)"; \
 	echo "Requires.private: $(PKG_CONFIG_REQPRIV)"; \
@@ -200,7 +199,6 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR)
 	echo "prefix=$(PKG_CONFIG_PREFIX)"; \
 	echo "includedir=$(PKG_CONFIG_INCDIR)"; \
 	echo "libdir=$(PKG_CONFIG_LIBDIR)"; \
-	$(foreach var,$(PKG_CONFIG_VARS),echo $(var);) \
 	echo ""; \
 	echo "Name: $(PKG_CONFIG_NAME)"; \
 	echo "Description: $(PKG_CONFIG_DESC)"; \
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239537.415523 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU6-0000VK-CH; Mon, 06 Dec 2021 17:09:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239537.415523; Mon, 06 Dec 2021 17:09:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU4-0000Oh-PZ; Mon, 06 Dec 2021 17:09:00 +0000
Received: by outflank-mailman (input) for mailman id 239537;
 Mon, 06 Dec 2021 17:08:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPc-0005ti-Jz
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:24 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e39d86a-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e39d86a-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810261;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=UGaD29iaA2ETS2WyEXEUNDVMklxMoCd2TNwszrikX0M=;
  b=OemMnwp1XKxMfbYBnccu6e7sGn/blqX2zwZfzlAUuUMEU7OKlLDaJscH
   1fWtck4T1lwRalNQ6/nM9GBH92e3dsm2Zvfd0kU1sV+0XNmkwSGX+6YEF
   aVZV8b6F8l06SmCWspMrGLyusZv9QUdNcAa7mIRCT09nX8X2z7ADXktDj
   Q=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: zUwf+n7CQ3+PAcuKXy6ZFit//IErd1iSeRqdiE+IIIY1Owjf6TF/2NlcBC29unDhhQXpli8v4B
 0Wvi4FBS5i6qG3suHbI0qHlbR1OvTSRkIF+RsKdznUrhK7ZIz5cbp05dP/OFo6ZMjUPBcN9bUG
 Y4GHgaEVTQvE1EZJ2iUtdiahB3Dby2krDqDAZ5EshNP52Vp5pCI0s+AcsT3MFYVUyxsz7Xhw8V
 F/d15HvCSVHyHFzSEiiGWhoUBWiiFsbQLzrnNz5UzEujtLhGCscOs/vFWDxSYZvADhzIBamAD2
 Kv2sdeKpmn3aZbP2jVAAXb41
X-SBRS: 5.1
X-MesageID: 59387986
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:9p0T+aCHjOnzcBVW/9jkw5YqxClBgxIJ4kV8jS/XYbTApDwkhTcFz
 2cbXWmDafuNa2qhKt8iaYrn8klQ6Jfczd83QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/sjGYropym
 O5xhY3zTRYNLrPynt9BakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWxg2ZEeQ54yY
 eIQYj9tdi3vQidTI1s6I8MMx9z5nUfGJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tkSXv
 GXd5EziHwoXcteYzFKt822urv/CmzvhX4AfH6H+8eRl6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDZtD7Qx2/pm/CphMGUsBcO+I/4QCJjKHT5m6k6nMsF2AbLoZ87YlvGGJsh
 gThc87V6SJHibmEeCiepoyonSLxPTkxPXE8YxRYdF5QizX8m70bghXKR9dlNae6iNzpBD39q
 wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjv9tlsRWWKzW2C/BbE3B95kJZ3RcFSOt
 WNsdyO2vLFXVsHleMBgrYww8FCVCxStbWS0bb1HRcBJG9GRF5iLJ9o4DNZWfhgBDyr8UWW1C
 HI/QCsIjHOpAFOkbLVsf6W6ANkwwK7rGLzND66PPoUUM8UrLlHYrEmCgHJ8OUi3yiDAdollZ
 v+mnTuEVy5GWcyLMhLoLwvi7VPb7n9nnj6CLXwK5x+mzaCfdBaopUQtazOzghQCxPrc+m39q
 o8HX+PTkkk3eLCuM0H/rN9IRXhXfCdTOHwDg5EOHgJ1ClE9Qz9J5j646e5JRrGJaIwJzLqVp
 S/kBRcDoLc97FWeQTi3hrlYQOuHdf5CQbgTZkTA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:KNUab6k/Bgqx5Pj2V1hRF6rtONLpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59387986"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 43/57] libs: Rename $(SRCS-y) to $(OBJS-y)
Date: Mon, 6 Dec 2021 17:02:26 +0000
Message-ID: <20211206170241.13165-44-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

The only thing done thing done with $(SRCS-y) is to replace ".c" by
".o". It is more useful to collect which object we want to build as
make will figure out how to build it and from which source file.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk                |   7 +-
 tools/libs/call/Makefile          |  12 +--
 tools/libs/ctrl/Makefile          |  74 +++++++-------
 tools/libs/devicemodel/Makefile   |  12 +--
 tools/libs/evtchn/Makefile        |  12 +--
 tools/libs/foreignmemory/Makefile |  12 +--
 tools/libs/gnttab/Makefile        |  14 +--
 tools/libs/guest/Makefile         |  86 ++++++++--------
 tools/libs/hypfs/Makefile         |   2 +-
 tools/libs/light/Makefile         | 162 +++++++++++++++---------------
 tools/libs/stat/Makefile          |  12 +--
 tools/libs/store/Makefile         |   4 +-
 tools/libs/toolcore/Makefile      |   4 +-
 tools/libs/toollog/Makefile       |   4 +-
 tools/libs/util/Makefile          |  16 +--
 tools/libs/vchan/Makefile         |   4 +-
 16 files changed, 218 insertions(+), 219 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 3078e45cf4..d3b056e799 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -17,8 +17,7 @@ CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
 LDLIBS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
 
-LIB_OBJS := $(SRCS-y:.c=.o)
-PIC_OBJS := $(SRCS-y:.c=.opic)
+PIC_OBJS := $(OBJS-y:.o=.opic)
 
 LIB_FILE_NAME = $(FILENAME_$(LIBNAME))
 LIB := lib$(LIB_FILE_NAME).a
@@ -76,7 +75,7 @@ headers.lst: FORCE
 libxen$(LIBNAME).map:
 	echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >$@
 
-lib$(LIB_FILE_NAME).a: $(LIB_OBJS)
+lib$(LIB_FILE_NAME).a: $(OBJS-y)
 	$(AR) rc $@ $^
 
 lib$(LIB_FILE_NAME).so: lib$(LIB_FILE_NAME).so.$(MAJOR)
@@ -122,7 +121,7 @@ TAGS:
 
 .PHONY: clean
 clean::
-	rm -rf $(LIB) *~ $(DEPS_RM) $(LIB_OBJS) $(PIC_OBJS)
+	rm -rf $(LIB) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS)
 	rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(MAJOR)
 	rm -f headers.chk headers.lst
 	rm -f $(PKG_CONFIG)
diff --git a/tools/libs/call/Makefile b/tools/libs/call/Makefile
index 93d404b79e..e5cb7c937c 100644
--- a/tools/libs/call/Makefile
+++ b/tools/libs/call/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 3
 
-SRCS-y                 += core.c buffer.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o buffer.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile
index a46e30a168..df145ba8ec 100644
--- a/tools/libs/ctrl/Makefile
+++ b/tools/libs/ctrl/Makefile
@@ -1,43 +1,43 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y       += xc_altp2m.c
-SRCS-y       += xc_cpupool.c
-SRCS-y       += xc_domain.c
-SRCS-y       += xc_evtchn.c
-SRCS-y       += xc_gnttab.c
-SRCS-y       += xc_misc.c
-SRCS-y       += xc_flask.c
-SRCS-y       += xc_physdev.c
-SRCS-y       += xc_private.c
-SRCS-y       += xc_csched.c
-SRCS-y       += xc_csched2.c
-SRCS-y       += xc_arinc653.c
-SRCS-y       += xc_rt.c
-SRCS-y       += xc_tbuf.c
-SRCS-y       += xc_pm.c
-SRCS-y       += xc_cpu_hotplug.c
-SRCS-y       += xc_vm_event.c
-SRCS-y       += xc_vmtrace.c
-SRCS-y       += xc_monitor.c
-SRCS-y       += xc_mem_paging.c
-SRCS-y       += xc_mem_access.c
-SRCS-y       += xc_memshr.c
-SRCS-y       += xc_hcall_buf.c
-SRCS-y       += xc_foreign_memory.c
-SRCS-y       += xc_kexec.c
-SRCS-y       += xc_resource.c
-SRCS-$(CONFIG_X86) += xc_psr.c
-SRCS-$(CONFIG_X86) += xc_pagetab.c
-SRCS-$(CONFIG_Linux) += xc_linux.c
-SRCS-$(CONFIG_FreeBSD) += xc_freebsd.c
-SRCS-$(CONFIG_SunOS) += xc_solaris.c
-SRCS-$(CONFIG_NetBSD) += xc_netbsd.c
-SRCS-$(CONFIG_NetBSDRump) += xc_netbsd.c
-SRCS-$(CONFIG_MiniOS) += xc_minios.c
-SRCS-y       += xc_evtchn_compat.c
-SRCS-y       += xc_gnttab_compat.c
-SRCS-y       += xc_devicemodel_compat.c
+OBJS-y       += xc_altp2m.o
+OBJS-y       += xc_cpupool.o
+OBJS-y       += xc_domain.o
+OBJS-y       += xc_evtchn.o
+OBJS-y       += xc_gnttab.o
+OBJS-y       += xc_misc.o
+OBJS-y       += xc_flask.o
+OBJS-y       += xc_physdev.o
+OBJS-y       += xc_private.o
+OBJS-y       += xc_csched.o
+OBJS-y       += xc_csched2.o
+OBJS-y       += xc_arinc653.o
+OBJS-y       += xc_rt.o
+OBJS-y       += xc_tbuf.o
+OBJS-y       += xc_pm.o
+OBJS-y       += xc_cpu_hotplug.o
+OBJS-y       += xc_vm_event.o
+OBJS-y       += xc_vmtrace.o
+OBJS-y       += xc_monitor.o
+OBJS-y       += xc_mem_paging.o
+OBJS-y       += xc_mem_access.o
+OBJS-y       += xc_memshr.o
+OBJS-y       += xc_hcall_buf.o
+OBJS-y       += xc_foreign_memory.o
+OBJS-y       += xc_kexec.o
+OBJS-y       += xc_resource.o
+OBJS-$(CONFIG_X86) += xc_psr.o
+OBJS-$(CONFIG_X86) += xc_pagetab.o
+OBJS-$(CONFIG_Linux) += xc_linux.o
+OBJS-$(CONFIG_FreeBSD) += xc_freebsd.o
+OBJS-$(CONFIG_SunOS) += xc_solaris.o
+OBJS-$(CONFIG_NetBSD) += xc_netbsd.o
+OBJS-$(CONFIG_NetBSDRump) += xc_netbsd.o
+OBJS-$(CONFIG_MiniOS) += xc_minios.o
+OBJS-y       += xc_evtchn_compat.o
+OBJS-y       += xc_gnttab_compat.o
+OBJS-y       += xc_devicemodel_compat.o
 
 CFLAGS   += -D__XEN_TOOLS__
 CFLAGS	+= $(PTHREAD_CFLAGS)
diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index 3e50ff6d90..a0a2d24f99 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += common.c
-SRCS-$(CONFIG_FreeBSD) += common.c
-SRCS-$(CONFIG_SunOS)   += compat.c
-SRCS-$(CONFIG_NetBSD)  += compat.c
-SRCS-$(CONFIG_MiniOS)  += compat.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += common.o
+OBJS-$(CONFIG_FreeBSD) += common.o
+OBJS-$(CONFIG_SunOS)   += compat.o
+OBJS-$(CONFIG_NetBSD)  += compat.o
+OBJS-$(CONFIG_MiniOS)  += compat.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/evtchn/Makefile b/tools/libs/evtchn/Makefile
index b8c37b5b97..8208ecf650 100644
--- a/tools/libs/evtchn/Makefile
+++ b/tools/libs/evtchn/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makefile
index 0eb9a3a712..4427435932 100644
--- a/tools/libs/foreignmemory/Makefile
+++ b/tools/libs/foreignmemory/Makefile
@@ -4,11 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 4
 
-SRCS-y                 += core.c
-SRCS-$(CONFIG_Linux)   += linux.c
-SRCS-$(CONFIG_FreeBSD) += freebsd.c
-SRCS-$(CONFIG_SunOS)   += compat.c solaris.c
-SRCS-$(CONFIG_NetBSD)  += netbsd.c
-SRCS-$(CONFIG_MiniOS)  += minios.c
+OBJS-y                 += core.o
+OBJS-$(CONFIG_Linux)   += linux.o
+OBJS-$(CONFIG_FreeBSD) += freebsd.o
+OBJS-$(CONFIG_SunOS)   += compat.o solaris.o
+OBJS-$(CONFIG_NetBSD)  += netbsd.o
+OBJS-$(CONFIG_MiniOS)  += minios.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
index ae390ce60f..7d7aeeadff 100644
--- a/tools/libs/gnttab/Makefile
+++ b/tools/libs/gnttab/Makefile
@@ -4,13 +4,13 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 2
 
-SRCS-GNTTAB            += gnttab_core.c
-SRCS-GNTSHR            += gntshr_core.c
+OBJS-GNTTAB            += gnttab_core.o
+OBJS-GNTSHR            += gntshr_core.o
 
-SRCS-$(CONFIG_Linux)   += $(SRCS-GNTTAB) $(SRCS-GNTSHR) linux.c
-SRCS-$(CONFIG_MiniOS)  += $(SRCS-GNTTAB) gntshr_unimp.c minios.c
-SRCS-$(CONFIG_FreeBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) freebsd.c
-SRCS-$(CONFIG_NetBSD)  += $(SRCS-GNTTAB) $(SRCS-GNTSHR) netbsd.c
-SRCS-$(CONFIG_SunOS)   += gnttab_unimp.c gntshr_unimp.c
+OBJS-$(CONFIG_Linux)   += $(OBJS-GNTTAB) $(OBJS-GNTSHR) linux.o
+OBJS-$(CONFIG_MiniOS)  += $(OBJS-GNTTAB) gntshr_unimp.o minios.o
+OBJS-$(CONFIG_FreeBSD) += $(OBJS-GNTTAB) $(OBJS-GNTSHR) freebsd.o
+OBJS-$(CONFIG_NetBSD)  += $(OBJS-GNTTAB) $(OBJS-GNTSHR) netbsd.o
+OBJS-$(CONFIG_SunOS)   += gnttab_unimp.o gntshr_unimp.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 67837c4e73..455e23c432 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -6,69 +6,69 @@ ifeq ($(CONFIG_LIBXC_MINIOS),y)
 override CONFIG_MIGRATE := n
 endif
 
-SRCS-y += xg_private.c
-SRCS-y += xg_domain.c
-SRCS-y += xg_suspend.c
-SRCS-y += xg_resume.c
+OBJS-y += xg_private.o
+OBJS-y += xg_domain.o
+OBJS-y += xg_suspend.o
+OBJS-y += xg_resume.o
 ifeq ($(CONFIG_MIGRATE),y)
-SRCS-y += xg_sr_common.c
-SRCS-$(CONFIG_X86) += xg_sr_common_x86.c
-SRCS-$(CONFIG_X86) += xg_sr_common_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_restore_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.c
-SRCS-$(CONFIG_X86) += xg_sr_save_x86_pv.c
-SRCS-$(CONFIG_X86) += xg_sr_save_x86_hvm.c
-SRCS-y += xg_sr_restore.c
-SRCS-y += xg_sr_save.c
-SRCS-y += xg_offline_page.c
+OBJS-y += xg_sr_common.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86.o
+OBJS-$(CONFIG_X86) += xg_sr_common_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_restore_x86_hvm.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_pv.o
+OBJS-$(CONFIG_X86) += xg_sr_save_x86_hvm.o
+OBJS-y += xg_sr_restore.o
+OBJS-y += xg_sr_save.o
+OBJS-y += xg_offline_page.o
 else
-SRCS-y += xg_nomigrate.c
+OBJS-y += xg_nomigrate.o
 endif
-SRCS-y       += xg_core.c
-SRCS-$(CONFIG_X86) += xg_core_x86.c
-SRCS-$(CONFIG_ARM) += xg_core_arm.c
+OBJS-y       += xg_core.o
+OBJS-$(CONFIG_X86) += xg_core_x86.o
+OBJS-$(CONFIG_ARM) += xg_core_arm.o
 
 CFLAGS += -I$(XEN_libxenctrl)
 
 vpath %.c ../../../xen/common/libelf
 CFLAGS += -I../../../xen/common/libelf
 
-ELF_SRCS-y += libelf-tools.c libelf-loader.c
-ELF_SRCS-y += libelf-dominfo.c
+ELF_OBJS-y += libelf-tools.o libelf-loader.o
+ELF_OBJS-y += libelf-dominfo.o
 
-SRCS-y += $(ELF_SRCS-y)
+OBJS-y += $(ELF_OBJS-y)
 
-$(patsubst %.c,%.o,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
-$(patsubst %.c,%.opic,$(ELF_SRCS-y)): CFLAGS += -Wno-pointer-sign
+$(ELF_OBJS-y): CFLAGS += -Wno-pointer-sign
+$(ELF_OBJS-y:.o=.opic): CFLAGS += -Wno-pointer-sign
 
 ifeq ($(CONFIG_X86),y) # Add libx86 to the build
 vpath %.c ../../../xen/lib/x86
 
-SRCS-y                 += cpuid.c msr.c policy.c
+OBJS-y                 += cpuid.o msr.o policy.o
 endif
 
 # new domain builder
-SRCS-y                 += xg_dom_core.c
-SRCS-y                 += xg_dom_boot.c
-SRCS-y                 += xg_dom_elfloader.c
-SRCS-$(CONFIG_X86)     += xg_dom_bzimageloader.c
-SRCS-$(CONFIG_X86)     += xg_dom_decompress_lz4.c
-SRCS-$(CONFIG_X86)     += xg_dom_hvmloader.c
-SRCS-$(CONFIG_ARM)     += xg_dom_armzimageloader.c
-SRCS-y                 += xg_dom_binloader.c
-SRCS-y                 += xg_dom_compat_linux.c
-
-SRCS-$(CONFIG_X86)     += xg_dom_x86.c
-SRCS-$(CONFIG_X86)     += xg_cpuid_x86.c
-SRCS-$(CONFIG_ARM)     += xg_dom_arm.c
+OBJS-y                 += xg_dom_core.o
+OBJS-y                 += xg_dom_boot.o
+OBJS-y                 += xg_dom_elfloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_bzimageloader.o
+OBJS-$(CONFIG_X86)     += xg_dom_decompress_lz4.o
+OBJS-$(CONFIG_X86)     += xg_dom_hvmloader.o
+OBJS-$(CONFIG_ARM)     += xg_dom_armzimageloader.o
+OBJS-y                 += xg_dom_binloader.o
+OBJS-y                 += xg_dom_compat_linux.o
+
+OBJS-$(CONFIG_X86)     += xg_dom_x86.o
+OBJS-$(CONFIG_X86)     += xg_cpuid_x86.o
+OBJS-$(CONFIG_ARM)     += xg_dom_arm.o
 
 ifeq ($(CONFIG_LIBXC_MINIOS),y)
-SRCS-y                 += xg_dom_decompress_unsafe.c
-SRCS-y                 += xg_dom_decompress_unsafe_bzip2.c
-SRCS-y                 += xg_dom_decompress_unsafe_lzma.c
-SRCS-y                 += xg_dom_decompress_unsafe_lzo1x.c
-SRCS-y                 += xg_dom_decompress_unsafe_xz.c
-SRCS-y                 += xg_dom_decompress_unsafe_zstd.c
+OBJS-y                 += xg_dom_decompress_unsafe.o
+OBJS-y                 += xg_dom_decompress_unsafe_bzip2.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzma.o
+OBJS-y                 += xg_dom_decompress_unsafe_lzo1x.o
+OBJS-y                 += xg_dom_decompress_unsafe_xz.o
+OBJS-y                 += xg_dom_decompress_unsafe_zstd.o
 endif
 
 CFLAGS   += -Werror -Wmissing-prototypes
diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile
index efa955bd50..630e1e6f3e 100644
--- a/tools/libs/hypfs/Makefile
+++ b/tools/libs/hypfs/Makefile
@@ -6,6 +6,6 @@ MINOR    = 0
 
 LDLIBS += -lz
 
-SRCS-y                 += core.c
+OBJS-y += core.o
 
 include ../libs.mk
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 719630eda2..d3ae2f6179 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -1,31 +1,31 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y += osdeps.c
-SRCS-y += libxl_paths.c
-SRCS-y += libxl_bootloader.c
-SRCS-y += flexarray.c
+OBJS-y += osdeps.o
+OBJS-y += libxl_paths.o
+OBJS-y += libxl_bootloader.o
+OBJS-y += flexarray.o
 ifeq ($(CONFIG_LIBNL),y)
-SRCS-y += libxl_netbuffer.c
+OBJS-y += libxl_netbuffer.o
 else
-SRCS-y += libxl_nonetbuffer.c
+OBJS-y += libxl_nonetbuffer.o
 endif
 ifeq ($(CONFIG_X86),y)
-SRCS-y += libxl_convert_callout.c
+OBJS-y += libxl_convert_callout.o
 else
-SRCS-y += libxl_no_convert_callout.c
+OBJS-y += libxl_no_convert_callout.o
 endif
-SRCS-y += libxl_remus.c
-SRCS-y += libxl_checkpoint_device.c
-SRCS-y += libxl_remus_disk_drbd.c
+OBJS-y += libxl_remus.o
+OBJS-y += libxl_checkpoint_device.o
+OBJS-y += libxl_remus_disk_drbd.o
 ifeq ($(CONFIG_LIBNL),y)
-SRCS-y += libxl_colo_restore.c
-SRCS-y += libxl_colo_save.c
-SRCS-y += libxl_colo_qdisk.c
-SRCS-y += libxl_colo_proxy.c
-SRCS-y += libxl_colo_nic.c
+OBJS-y += libxl_colo_restore.o
+OBJS-y += libxl_colo_save.o
+OBJS-y += libxl_colo_qdisk.o
+OBJS-y += libxl_colo_proxy.o
+OBJS-y += libxl_colo_nic.o
 else
-SRCS-y += libxl_no_colo.c
+OBJS-y += libxl_no_colo.o
 endif
 
 ACPI_PATH  = $(XEN_ROOT)/tools/libacpi
@@ -40,82 +40,82 @@ vpath static_tables.c $(ACPI_PATH)/
 acpi:
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
 
-SRCS-$(CONFIG_X86) += $(ACPI_OBJS:.o=.c)
+OBJS-$(CONFIG_X86) += $(ACPI_OBJS)
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
 
 CFLAGS-$(CONFIG_X86) += -DCONFIG_PCI_SUPP_LEGACY_IRQ
 
-SRCS-$(CONFIG_X86) += libxl_cpuid.c
-SRCS-$(CONFIG_X86) += libxl_x86.c
-SRCS-$(CONFIG_X86) += libxl_psr.c
-SRCS-$(CONFIG_X86) += libxl_x86_acpi.c
-SRCS-$(CONFIG_ARM) += libxl_nocpuid.c
-SRCS-$(CONFIG_ARM) += libxl_arm.c
-SRCS-$(CONFIG_ARM) += libxl_libfdt_compat.c
+OBJS-$(CONFIG_X86) += libxl_cpuid.o
+OBJS-$(CONFIG_X86) += libxl_x86.o
+OBJS-$(CONFIG_X86) += libxl_psr.o
+OBJS-$(CONFIG_X86) += libxl_x86_acpi.o
+OBJS-$(CONFIG_ARM) += libxl_nocpuid.o
+OBJS-$(CONFIG_ARM) += libxl_arm.o
+OBJS-$(CONFIG_ARM) += libxl_libfdt_compat.o
 ifeq ($(CONFIG_ARM_64),y)
 DSDT_FILES-y = dsdt_anycpu_arm.c
-SRCS-y += libxl_arm_acpi.c
-SRCS-y += $(DSDT_FILES-y)
+OBJS-y += libxl_arm_acpi.o
+OBJS-y += $(DSDT_FILES-y:.c=.o)
 dsdt_anycpu_arm.c:
 	$(MAKE) -C $(ACPI_PATH) ACPI_BUILD_DIR=$(CURDIR) DSDT_FILES="$(DSDT_FILES-y)"
 else
-SRCS-$(CONFIG_ARM) += libxl_arm_no_acpi.c
+OBJS-$(CONFIG_ARM) += libxl_arm_no_acpi.o
 endif
 
-SRCS-OS-$(CONFIG_NetBSD) = libxl_netbsd.c
-SRCS-OS-$(CONFIG_Linux) = libxl_linux.c libxl_setresuid.c
-SRCS-OS-$(CONFIG_FreeBSD) = libxl_freebsd.c libxl_setresuid.c
-ifeq ($(SRCS-OS-y),)
+OBJS-OS-$(CONFIG_NetBSD) = libxl_netbsd.o
+OBJS-OS-$(CONFIG_Linux) = libxl_linux.o libxl_setresuid.o
+OBJS-OS-$(CONFIG_FreeBSD) = libxl_freebsd.o libxl_setresuid.o
+ifeq ($(OBJS-OS-y),)
 $(error Your Operating System is not supported by libxenlight, \
 please check libxl_linux.c and libxl_netbsd.c to see how to get it ported)
 endif
-SRCS-y += $(SRCS-OS-y)
-
-SRCS-y += libxl.c
-SRCS-y += libxl_create.c
-SRCS-y += libxl_dm.c
-SRCS-y += libxl_pci.c
-SRCS-y += libxl_dom.c
-SRCS-y += libxl_exec.c
-SRCS-y += libxl_xshelp.c
-SRCS-y += libxl_device.c
-SRCS-y += libxl_internal.c
-SRCS-y += libxl_utils.c
-SRCS-y += libxl_uuid.c
-SRCS-y += libxl_json.c
-SRCS-y += libxl_aoutils.c
-SRCS-y += libxl_numa.c
-SRCS-y += libxl_vnuma.c
-SRCS-y += libxl_stream_read.c
-SRCS-y += libxl_stream_write.c
-SRCS-y += libxl_save_callout.c
-SRCS-y += _libxl_save_msgs_callout.c
-SRCS-y += libxl_qmp.c
-SRCS-y += libxl_event.c
-SRCS-y += libxl_fork.c
-SRCS-y += libxl_dom_suspend.c
-SRCS-y += libxl_dom_save.c
-SRCS-y += libxl_usb.c
-SRCS-y += libxl_vtpm.c
-SRCS-y += libxl_nic.c
-SRCS-y += libxl_disk.c
-SRCS-y += libxl_console.c
-SRCS-y += libxl_cpupool.c
-SRCS-y += libxl_mem.c
-SRCS-y += libxl_sched.c
-SRCS-y += libxl_tmem.c
-SRCS-y += libxl_9pfs.c
-SRCS-y += libxl_domain.c
-SRCS-y += libxl_vdispl.c
-SRCS-y += libxl_pvcalls.c
-SRCS-y += libxl_vsnd.c
-SRCS-y += libxl_vkb.c
-SRCS-y += libxl_genid.c
-SRCS-y += _libxl_types.c
-SRCS-y += libxl_flask.c
-SRCS-y += _libxl_types_internal.c
+OBJS-y += $(OBJS-OS-y)
+
+OBJS-y += libxl.o
+OBJS-y += libxl_create.o
+OBJS-y += libxl_dm.o
+OBJS-y += libxl_pci.o
+OBJS-y += libxl_dom.o
+OBJS-y += libxl_exec.o
+OBJS-y += libxl_xshelp.o
+OBJS-y += libxl_device.o
+OBJS-y += libxl_internal.o
+OBJS-y += libxl_utils.o
+OBJS-y += libxl_uuid.o
+OBJS-y += libxl_json.o
+OBJS-y += libxl_aoutils.o
+OBJS-y += libxl_numa.o
+OBJS-y += libxl_vnuma.o
+OBJS-y += libxl_stream_read.o
+OBJS-y += libxl_stream_write.o
+OBJS-y += libxl_save_callout.o
+OBJS-y += _libxl_save_msgs_callout.o
+OBJS-y += libxl_qmp.o
+OBJS-y += libxl_event.o
+OBJS-y += libxl_fork.o
+OBJS-y += libxl_dom_suspend.o
+OBJS-y += libxl_dom_save.o
+OBJS-y += libxl_usb.o
+OBJS-y += libxl_vtpm.o
+OBJS-y += libxl_nic.o
+OBJS-y += libxl_disk.o
+OBJS-y += libxl_console.o
+OBJS-y += libxl_cpupool.o
+OBJS-y += libxl_mem.o
+OBJS-y += libxl_sched.o
+OBJS-y += libxl_tmem.o
+OBJS-y += libxl_9pfs.o
+OBJS-y += libxl_domain.o
+OBJS-y += libxl_vdispl.o
+OBJS-y += libxl_pvcalls.o
+OBJS-y += libxl_vsnd.o
+OBJS-y += libxl_vkb.o
+OBJS-y += libxl_genid.o
+OBJS-y += _libxl_types.o
+OBJS-y += libxl_flask.o
+OBJS-y += _libxl_types_internal.o
 
 ifeq ($(CONFIG_LIBNL),y)
 CFLAGS_LIBXL += $(LIBNL3_CFLAGS)
@@ -175,7 +175,7 @@ LDLIBS-y += $(PTHREAD_LIBS)
 LDLIBS-y += -lyajl
 LDLIBS += $(LDLIBS-y)
 
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\"
 $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore)
 libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools  # include libacpi/x86.h
@@ -189,7 +189,7 @@ testidl.c: libxl_types.idl gentest.py $(XEN_INCLUDE)/libxl.h $(AUTOINCS)
 
 all: $(CLIENTS) $(TEST_PROGS) $(AUTOSRCS) $(AUTOINCS)
 
-$(LIB_OBJS) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
+$(OBJS-y) $(PIC_OBJS) $(SAVE_HELPER_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): $(AUTOINCS) libxl.api-ok
 
 libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
 	$(PERL) $^
@@ -216,8 +216,8 @@ $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h _libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
 
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
-$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS) $(SAVE_HELPER_OBJS): $(XEN_INCLUDE)/libxl.h
+$(OBJS-y) $(PIC_OBJS) $(LIBXL_TEST_OBJS): libxl_internal.h
 
 _libxl_type%.h _libxl_type%_json.h _libxl_type%_private.h _libxl_type%.c: libxl_type%.idl gentypes.py idl.py
 	$(eval stem = $(notdir $*))
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 24b5949b3e..e39fe29bd1 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -17,12 +17,12 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS += -include $(XEN_ROOT)/tools/config.h
 
-SRCS-y += xenstat.c
-SRCS-y += xenstat_qmp.c
-SRCS-$(CONFIG_Linux) += xenstat_linux.c
-SRCS-$(CONFIG_SunOS) += xenstat_solaris.c
-SRCS-$(CONFIG_NetBSD) += xenstat_netbsd.c
-SRCS-$(CONFIG_FreeBSD) += xenstat_freebsd.c
+OBJS-y += xenstat.o
+OBJS-y += xenstat_qmp.o
+OBJS-$(CONFIG_Linux) += xenstat_linux.o
+OBJS-$(CONFIG_SunOS) += xenstat_solaris.o
+OBJS-$(CONFIG_NetBSD) += xenstat_netbsd.o
+OBJS-$(CONFIG_FreeBSD) += xenstat_freebsd.o
 
 LDLIBS-y += -lyajl
 LDLIBS-$(CONFIG_SunOS) += -lkstat
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index 1bacee6cf1..6cc9baaabe 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -8,8 +8,8 @@ ifeq ($(CONFIG_Linux),y)
 LDLIBS += -ldl
 endif
 
-SRCS-y   += xs_lib.c
-SRCS-y   += xs.c
+OBJS-y   += xs_lib.o
+OBJS-y   += xs.o
 
 LIBHEADER = xenstore.h xenstore_lib.h
 
diff --git a/tools/libs/toolcore/Makefile b/tools/libs/toolcore/Makefile
index 3550786491..632048c899 100644
--- a/tools/libs/toolcore/Makefile
+++ b/tools/libs/toolcore/Makefile
@@ -7,13 +7,13 @@ AUTOINCS := $(XEN_INCLUDE)/_xentoolcore_list.h
 
 LIBHEADER := xentoolcore.h xentoolcore_internal.h
 
-SRCS-y	+= handlereg.c
+OBJS-y	+= handlereg.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
 PKG_CONFIG_DESC := Central support for Xen Hypervisor userland libraries
 
-$(LIB_OBJS): $(AUTOINCS)
+$(OBJS-y): $(AUTOINCS)
 $(PIC_OBJS): $(AUTOINCS)
 
 $(XEN_INCLUDE)/_xentoolcore_list.h: $(XEN_INCLUDE)/xen-external/bsd-sys-queue-h-seddery $(XEN_INCLUDE)/xen-external/bsd-sys-queue.h
diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
index dce1b2de85..c09aa02ba5 100644
--- a/tools/libs/toollog/Makefile
+++ b/tools/libs/toollog/Makefile
@@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR	= 1
 MINOR	= 0
 
-SRCS-y	+= xtl_core.c
-SRCS-y	+= xtl_logger_stdio.c
+OBJS-y	+= xtl_core.o
+OBJS-y	+= xtl_logger_stdio.o
 
 include $(XEN_ROOT)/tools/libs/libs.mk
diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile
index 4e41bc9ff0..17b95f7c71 100644
--- a/tools/libs/util/Makefile
+++ b/tools/libs/util/Makefile
@@ -1,13 +1,13 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
-SRCS-y += libxlu_cfg_y.c
-SRCS-y += libxlu_cfg_l.c
-SRCS-y += libxlu_cfg.c
-SRCS-y += libxlu_disk_l.c
-SRCS-y += libxlu_disk.c
-SRCS-y += libxlu_vif.c
-SRCS-y += libxlu_pci.c
+OBJS-y += libxlu_cfg_y.o
+OBJS-y += libxlu_cfg_l.o
+OBJS-y += libxlu_cfg.o
+OBJS-y += libxlu_disk_l.o
+OBJS-y += libxlu_disk.o
+OBJS-y += libxlu_vif.o
+OBJS-y += libxlu_pci.o
 
 CFLAGS += -Wno-format-zero-length -Wmissing-declarations \
 	-Wno-declaration-after-statement -Wformat-nonliteral
@@ -39,7 +39,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-$(LIB_OBJS) $(PIC_OBJS): $(AUTOINCS)
+$(OBJS-y) $(PIC_OBJS): $(AUTOINCS)
 
 %.c %.h:: %.y
 	@rm -f $*.[ch]
diff --git a/tools/libs/vchan/Makefile b/tools/libs/vchan/Makefile
index f6f1002800..a41f3623c8 100644
--- a/tools/libs/vchan/Makefile
+++ b/tools/libs/vchan/Makefile
@@ -5,8 +5,8 @@ CFLAGS += $(CFLAGS_libxenctrl)
 
 LIBHEADER := libxenvchan.h
 
-SRCS-y += init.c
-SRCS-y += io.c
+OBJS-y += init.o
+OBJS-y += io.o
 
 NO_HEADERS_CHK := y
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239538.415536 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU9-0001Dw-ES; Mon, 06 Dec 2021 17:09:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239538.415536; Mon, 06 Dec 2021 17:09:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHU7-00015k-Vb; Mon, 06 Dec 2021 17:09:03 +0000
Received: by outflank-mailman (input) for mailman id 239538;
 Mon, 06 Dec 2021 17:09:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHQ2-0005ta-19
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:50 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9de2d1a9-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9de2d1a9-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810288;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=TRgfprArJiMn7DHfVSl2ZO32FkfcY3fIM9au9u7h+C8=;
  b=Ae7pEEwaDCij3PCSLcwxgt/gbCox+XhaoJ1tATux5kxoxLJi9AONo16b
   TctbhNcLMvX85LPRmf1f1nYldCRQW7b+DNByLWAzmAxgSQbRHOM3xQsZ4
   0Ix6XvVy44Cdpsd2yRpwboTrbQ8sbZOogvnNrL1DIDJEGTmkbdq+gtbpd
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: AG/RYGxOdGeT1KPb7BH6o2MK689W9LDGxCwOyK2xPWwW1dFft0tUVE1q8fB6mslsLNYg7nzv9F
 R1bKxMymAgmlc7/k8SCO0ShxIeglfqvAcP7PwapiVpU+iWL1LvC5C8deF5WDlwPwCPmClpO+96
 3DCy2APEQNJDgwSZy5iyY/AfROnQ/ac/F6K1VpGIktLSbDhZ9YVf13t5DCwCC5GiJ7XWqO1IrR
 XuaKT5RUj/uvRN0tn39ERJuTmb4WvrDY5SgxMZ6MKbNzxckewEpzgWx3VhUoyW9pNAbde7UdVL
 VCOEhIHrp78XrUTzXcuRpNuu
X-SBRS: 5.1
X-MesageID: 59766580
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:c917V67A+5WdjtjNkNlUSwxRtK/AchMFZxGqfqrLsTDasY5as4F+v
 mVNXDuGOKmNazT9c4x+bY63pkkB7MOAxtNhGVY6/yAwHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tAw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zj
 +9v7sKtYiEQBqycne9eXjcFLjwjFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTKmAO
 ZdJMVKDajyQQQIIAlhOJ6glkeazg0v6dzRbg1Oa8P9fD2/7k1UqjemF3MDuUsOObdVYmACfv
 G2u13/wBwwXMJqDyTuP+2+omsfCmzi+XJMVEvu/7PECqF+c3GsIEzUNSEC25/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8Uz7h2NzazFpR6UHGEeQhZObdUnsIk9QjlC/
 l6Wnfv5CDp3qrqXRHmBsLCOoluP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLV5SX1YPoMhfJ+
 zHaqSN9iptOsNNW/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl
 D1dwpXFsrhSZX2YvHXVGL1lIV2/2xqS3NQwa3ZLFoJpyTmi8mXLkWt4sGAnfxcB3irplFbUj
 K7vVeF5ucY70JiCN/Yfj2eN5yICl/KI+TPNDK+8Uza2SsItHDJrBQk3DaJq40jjkVI3jYY0M
 oqBfMCnAB4yUPo8nGXsFrpHi+F0lkjSIF8/o7ihlXxLNpLEOxaopUotagPSPojVEovayOkqz
 zqvH5TTkEgOOAEPSiLW7ZQSPTg3wYsTXvjLRzhsXrfbeGJOQTh5Y9eImO9JU9E1zsx9y7aTl
 lngCxAw9bYKrSCeQel8Qis4M+2HsFcWhS9TABHAyn70gSV+Otj2s/9EH3b1FJF+nNFeITdPZ
 6FtU6297j5nE1wrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp
 by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf
 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
IronPort-HdrOrdr: A9a23:qUHjW6vrVHF9h3RKqsW01J8X7skDcNV00zEX/kB9WHVpmszxra
 +TdZMgpHjJYVcqKQgdcL+7WZVoLUmwyXcx2/hyAV7AZniDhILLFuFfBOLZqlWKcREWtNQtsJ
 uIG5IObuEYZmIVsS+V2mWF+q4bsbq6zJw=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766580"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Juergen Gross
	<jgross@suse.com>
Subject: [XEN PATCH 55/57] tools/xenstore: introduce Makefile.common to be used by stubdom
Date: Mon, 6 Dec 2021 17:02:38 +0000
Message-ID: <20211206170241.13165-56-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Also change stubdom to depends on Makefile.common.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 stubdom/Makefile               |  4 ++--
 tools/xenstore/Makefile        | 34 +++-------------------------------
 tools/xenstore/Makefile.common | 34 ++++++++++++++++++++++++++++++++++
 3 files changed, 39 insertions(+), 33 deletions(-)
 create mode 100644 tools/xenstore/Makefile.common

diff --git a/stubdom/Makefile b/stubdom/Makefile
index fbc63a5063..6b804824ba 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -371,10 +371,10 @@ endef
 
 $(foreach lib,$(STUB_LIBS),$(eval $(call BUILD_lib,$(lib))))
 
-xenstore/stamp: $(XEN_ROOT)/tools/xenstore/Makefile
+xenstore/stamp: $(XEN_ROOT)/tools/xenstore/Makefile.common
 	$(do_links)
 
-xenstorepvh/stamp: $(XEN_ROOT)/tools/xenstore/Makefile
+xenstorepvh/stamp: $(XEN_ROOT)/tools/xenstore/Makefile.common
 	$(do_links)
 
 LINK_DIRS := xenstore xenstorepvh $(foreach dir,$(STUB_LIBS),libs-$(XEN_TARGET_ARCH)/$(dir))
diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 7fe1d9c1e2..a6fc917b81 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -1,36 +1,11 @@
 XEN_ROOT=$(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
+include Makefile.common
+
 MAJOR = 3.0
 MINOR = 3
 
-CFLAGS += -Werror
-# Include configure output (config.h)
-CFLAGS += -include $(XEN_ROOT)/tools/config.h
-CFLAGS += -I./include
-CFLAGS += $(CFLAGS_libxenevtchn)
-CFLAGS += $(CFLAGS_libxenctrl)
-CFLAGS += $(CFLAGS_libxenguest)
-CFLAGS += $(CFLAGS_libxentoolcore)
-CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
-CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
-
-ifdef CONFIG_STUBDOM
-CFLAGS += -DNO_SOCKETS=1
-endif
-
-XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
-XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
-XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
-
-XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_SunOS) += xenstored_solaris.o xenstored_posix.o xenstored_probes.o
-XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
-XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
-
-$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
-
 xenstored: LDLIBS += $(LDLIBS_libxenevtchn)
 xenstored: LDLIBS += $(LDLIBS_libxengnttab)
 xenstored: LDLIBS += $(LDLIBS_libxenctrl)
@@ -81,9 +56,6 @@ endif
 xenstored: $(XENSTORED_OBJS-y)
 	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
 
-xenstored.a: $(XENSTORED_OBJS-y)
-	$(AR) cr $@ $^
-
 $(CLIENTS): xenstore
 	ln -f xenstore $@
 
@@ -97,7 +69,7 @@ xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
 	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
 
 .PHONY: clean
-clean:
+clean::
 	rm -f *.a *.o xenstored_probes.h
 	rm -f $(TARGETS)
 	$(RM) $(DEPS_RM)
diff --git a/tools/xenstore/Makefile.common b/tools/xenstore/Makefile.common
new file mode 100644
index 0000000000..49002651a1
--- /dev/null
+++ b/tools/xenstore/Makefile.common
@@ -0,0 +1,34 @@
+# Makefile shared with stubdom
+
+XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
+XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
+XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
+
+XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_SunOS) += xenstored_solaris.o xenstored_posix.o xenstored_probes.o
+XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
+XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
+
+CFLAGS += -Werror
+# Include configure output (config.h)
+CFLAGS += -include $(XEN_ROOT)/tools/config.h
+CFLAGS += -I./include
+CFLAGS += $(CFLAGS_libxenevtchn)
+CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenguest)
+CFLAGS += $(CFLAGS_libxentoolcore)
+CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
+CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
+
+ifdef CONFIG_STUBDOM
+CFLAGS += -DNO_SOCKETS=1
+endif
+
+$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
+
+xenstored.a: $(XENSTORED_OBJS-y)
+	$(AR) cr $@ $^
+
+clean::
+	rm -f *.a *.o
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239544.415567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUP-0004Qw-RP; Mon, 06 Dec 2021 17:09:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239544.415567; Mon, 06 Dec 2021 17:09:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUP-0004Oj-Jz; Mon, 06 Dec 2021 17:09:21 +0000
Received: by outflank-mailman (input) for mailman id 239544;
 Mon, 06 Dec 2021 17:09:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPp-0005ta-Md
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:37 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 969b80ed-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 969b80ed-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810276;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=6gPon+8ie7LTESQTDwjPUyrtRsfp7PjeTPv6/Lsi+SE=;
  b=D/nkpGKBvWy0S5AH7X/9jNocRO0JJj6uEEiT7o6Ocs0gHcrbwvJIfbiM
   qNvmAYFXZySAVYbQPWvAipI4KJAXDlBSpzZwYHQPVHH2bswyo74gKWGmY
   tdmDetmPnBz7W9rAi9rUslwrQACsizCtQgWOTyvm50KCJGEu4GUW6ao+p
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: gf5YhVC7b28sGIfSw4cd8CgRx51//9NucJR41a3vpFzAQ5ebjMsz45YTg3KawPEPor0PswS0De
 tapNmDQgAEUWdo59XVgxyJeBxNTZ/3Wyr0LqArvDOU7mC/8dVQBku1T2FJ93fRt26C2yAW4CQ8
 RP76zSV6Ab0TzgTZZOtjYFw9Fcf1pyFB0eastBC+JT6ONtupZj4aUJkAvwzJ/bVKCf9g1/+KRs
 dgl/lY8FFKtA7iHei6wJMqmTfTCKsZx+sfUA8RP1wUnxMNwdW5pim94Hn6Hijjb3/Qr/4S7Geh
 TIhkDcYh3UbRnvMtJH+Tfb/Q
X-SBRS: 5.1
X-MesageID: 59766556
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0/hyE6wfouvGd0AEaHZ6t+fGwSrEfRIJ4+MujC+fZmUNrF6WrkUPm
 jZLUGqDO/2MN2Cgco92YYq290hSvJWBx4RlQABr/yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wbZn2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/ttx
 IRSs4aIcwp3JafIuNk5DEIDPS4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25ERQ6iDO
 pRxhTxHfDebZkRFOg8sDosjvsSxtHCmSxlUgQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krE8H7+GQoyL8GExHyO9XfEru7QnwvrVYQKDrq6+/V2xlqJyQQ7GBAQEFe2v/S9okq/QM5Eb
 VwZ/DI0qqo//1DtScPyNzWxpmKEuRgNHcJdCeQg5CmCz6PV50CSAW1sc9JaQIV47olsH2Vsj
 wLX2YOybdByjFGLYVmB+uaLqymKAyVLNmUGRRIgElBezda29enfkSnzZtpkFae0iPj8Fjfx3
 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+ysgPNb9D7FE/2Q3+hqpwGyxalCa9
 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM2d3XC3270k5JGQWy2yGskTKuOGpxbEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQOcguLl7apnswOh74M4XRfK4Ey/tX1
 XCzK5nEMJrnIf4/kGreqxk1j9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq
 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgo
 ivgBxQGkQWn3hUq62yiMxheVV8mZr4nxVpTAMDmFQ/AN6ELbdn94aEBWYEweLV7puVvweQtF
 6sOetmaA+QJQTPComxPYZ74pY1kVRKqmQPRYHb1PGlhJ8ZtF17T59vpXgrz7y1SXCC5gtQz/
 u+73QTBTJtdGwk7VJTKaOiixk+atGQGnL4gRFPBJ9ReIR2+8IVjJyHroOUwJsUAdUfKyjeAj
 l7EChYEv+jd5YQy9YCR16yDqo6oFcp4H1ZbQDaHverna3GC8zP6k4FaUeuOcTTMb0/O+f2vN
 bdP0vXxEPwbh1IW4YByJKlmkPAl7Nz1qr4Ekgk9RCfXb06mA69LK2Wd2ZUdrbVEw7JUtFfkW
 k+L/dUGa7yFNNm8TQwULQshKO+CyesVin/Z6vFseBf24yp+/bymV0ROPkbT1HwBfeUtaI51k
 /08vMM26hCkjkt4O9mLuSlY6mCQIyFSSK4grJwbXNfmhwdDJouuunAA5vsaOK2yVug=
IronPort-HdrOrdr: A9a23:UFpHP6BBoK/VnJ3lHemq55DYdb4zR+YMi2TC1yhKJiC9Ffbo8P
 xG/c5rrCMc5wxxZJhNo7290ey7MBHhHP1OkO0s1NWZPDUO0VHAROoJ0WKh+UyEJ8SXzJ866U
 4KScZD4bPLYWSS9fyKgzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766556"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 48/57] libs/stat: Fix and rework perl-binding build
Date: Mon, 6 Dec 2021 17:02:31 +0000
Message-ID: <20211206170241.13165-49-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

For PERL_FLAGS, use make's shell rather than a backquote.

Rather than relying on the VCS to create an empty directory for us,
we can create one before generating the *.c file for the bindings.

Make use of generic variable names to build a shared library from a
source file: CFLAGS, LDFLAGS, and LDLIBS.

To build a shared library, we need to build the source file with
"-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
new tools/libs/stat directory).

The source file generated by swig seems to be missing many prototype for
many functions, so we need "-Wno-missing-prototypes" in order to
build it. Also, one of the prototype is deemed malformed, so we also
need "-Wno-strict-prototypes".

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/stat/Makefile                  | 15 +++++++++++----
 tools/libs/stat/bindings/swig/perl/.empty |  1 -
 2 files changed, 11 insertions(+), 5 deletions(-)
 delete mode 100644 tools/libs/stat/bindings/swig/perl/.empty

diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index d5d9cb3659..962f02090b 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -94,13 +94,20 @@ uninstall: uninstall-python-bindings
 endif
 
 # Perl bindings
-PERL_FLAGS=`perl -MConfig -e 'print "$$Config{ccflags} -I$$Config{archlib}/CORE";'`
+PERL_FLAGS = $(shell $(PERL) -MConfig -e 'print "$$Config{ccflags} -I$$Config{archlib}/CORE";')
 $(PERLMOD): $(PERLSRC)
 $(PERLSRC): bindings/swig/xenstat.i
-	swig -perl $(SWIG_FLAGS) -outdir $(@D) -o $(PERLSRC) $<
-
+	mkdir -p $(@D)
+	swig -perl $(SWIG_FLAGS) -outdir $(@D) -o $@ $<
+
+$(PERLLIB): CFLAGS += -fPIC
+$(PERLLIB): CFLAGS += -Wno-strict-prototypes
+$(PERLLIB): CFLAGS += -Wno-missing-prototypes
+$(PERLLIB): LDFLAGS += $(PERL_FLAGS)
+$(PERLLIB): LDFLAGS += $(SHLIB_LDFLAGS)
+$(PERLLIB): LDLIBS := $(LDLIBS_libxenstat)
 $(PERLLIB): $(PERLSRC)
-	$(CC) $(CFLAGS) $(LDFLAGS) $(PERL_FLAGS) $(SHLIB_LDFLAGS) -lxenstat -o $@ $< $(APPEND_LDFLAGS)
+	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
 
 .PHONY: perl-bindings
 perl-bindings: $(PERLLIB) $(PERLMOD)
diff --git a/tools/libs/stat/bindings/swig/perl/.empty b/tools/libs/stat/bindings/swig/perl/.empty
deleted file mode 100644
index 2a8dd4274d..0000000000
--- a/tools/libs/stat/bindings/swig/perl/.empty
+++ /dev/null
@@ -1 +0,0 @@
-This directory is empty; this file is included to prevent version control systems from removing the directory.
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239545.415572 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUQ-0004YS-FX; Mon, 06 Dec 2021 17:09:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239545.415572; Mon, 06 Dec 2021 17:09:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUQ-0004Wm-41; Mon, 06 Dec 2021 17:09:22 +0000
Received: by outflank-mailman (input) for mailman id 239545;
 Mon, 06 Dec 2021 17:09:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPV-0005ti-GU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:17 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8a860490-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:04:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a860490-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810256;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=tbDeksLVu0GyFKO1SroA0BOmx1FzKwu8uJ22siMq6ic=;
  b=fhJ5CmriJANP2RvZWfHSrPzvANdZlDR80vvd7jpPV1fTaWIc6dHgUhTx
   YnbeRlYR+xcVAJnb6bwg9wEA16zsWoNTpRpIQlIiODfGM8tYJpdtsH3gv
   RsetQyFhejESbwhCTrBCjggX2PZkdy1jnJ2M/1/1WZZf724HTpmB8/b2M
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: MewBrood5Ax81IjdRTLTa7qtc8aDM2EA+0sCHzqmQ00R/+VsRDA4P8sy46YtZbwp7fBtmpS2BG
 Mx/oidONc1O2PWmNYeje2PxlEFYTB56ay8U66G9oJ5kgpPE8hmnlqVHatV0R9KqCYk1sovIkqD
 gUJu9wXKPz9IJxkIcohgNW0q5d0/kIZSY5vdHGmtlixVY1VPNCf6SjuzCyOsigdu8bw+07Czfe
 KoKlwV+xJZkY7YkfLEJHRyIqK4qFRai3TgTwZyBtDIGtxvZeUi4M6mOfV5gZsn+tW6UtevSCc9
 IE/Uqtownkum5PPQAMLYrJbC
X-SBRS: 5.1
X-MesageID: 59370702
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Bi0NfKszY4judmKn2+nOfA0C5ufnVKdZMUV32f8akzHdYApBsoF/q
 tZmKWnSOfmCYWf9edp+Ot+0phsOsMCBy4VrSVA+/H0wQStA+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHhJZS5LwbZj29cy2YbhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplr46KYhkEE4TwpLonFEN7Dn1fOoFN9+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 pFGMWU3NnwsZTV/KAooDogQrdu6oVPgQSJclHnLpIo4tj27IAtZj+G2bYu9lsaxbdpRtlaVo
 CTB5WuRKhMVLtuE0hKe72mhwOTImEvTWZ0QPK218OZwh1+ezXBVDwcZPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHslhcaR9pXFfx88AyXw7DYywmcD2kACDVGbbQbWNQeHGJwk
 AXTxpWwWGIp4Ob9pW+hGqm8tyGIEjY4AEY+WXE+ClEm/oXCp604gUeaJjp8K5KdgtrwEDD25
 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9XwsQCz0BpWEGqOorBtV
 lAgktPW0u0BBIrleMelELRUR+HBCxpo3VThbb9T83sJqm3FF52LJ9k4DNRCyKFBaJxsldjBO
 hC7hO+pzMUPVEZGlIcuC25LN+wkzLL7CfPuXe3OY9xFb/BZLVHcrH40NBPKhT6ywCDAdJ3T3
 7/BK65A6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILO+5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:fBYhv63/b9S5OQJjkpxtpQqjBLQkLtp133Aq2lEZdPRUGvb2qy
 nIpoV96faUskdpZJhOo7G90cW7LE80sKQFg7X5Xo3SODUO2lHJEGgK1+KLqFfd8m/Fh4tgPM
 9bAs5D4bbLY2SS4/yX3ODBKadC/OW6
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370702"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: [XEN PATCH 40/57] libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS
Date: Mon, 6 Dec 2021 17:02:23 +0000
Message-ID: <20211206170241.13165-41-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

LDLIBS is more appropriate and intended to be used to add library
dependencies. APPEND_LDFLAGS wasn't intended to be changed by the
build system.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libs/libs.mk        |  4 ++--
 tools/libs/guest/Makefile |  2 +-
 tools/libs/hypfs/Makefile |  2 +-
 tools/libs/light/Makefile | 18 +++++++++---------
 tools/libs/stat/Makefile  |  2 +-
 tools/libs/store/Makefile |  2 +-
 6 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index 7c5ae26bbd..91d4efeaed 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -15,7 +15,7 @@ CFLAGS   += -Werror -Wmissing-prototypes
 CFLAGS   += $(CFLAGS_xeninclude)
 CFLAGS   += $(foreach lib, $(USELIBS_$(LIBNAME)), $(CFLAGS_libxen$(lib)))
 
-LDUSELIBS = $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
+LDLIBS += $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDLIBS_libxen$(lib)))
 
 LIB_OBJS := $(SRCS-y:.c=.o)
 PIC_OBJS := $(SRCS-y:.c=.opic)
@@ -85,7 +85,7 @@ lib$(LIB_FILE_NAME).so.$(MAJOR): lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
 	$(SYMLINK_SHLIB) $< $@
 
 lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxen$(LIBNAME).map
-	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDUSELIBS) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,lib$(LIB_FILE_NAME).so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS) $(APPEND_LDFLAGS)
 
 # If abi-dumper is available, write out the ABI analysis
 ifneq ($(ABI_DUMPER),)
diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
index 1f4b7f7c58..636b4ea5cb 100644
--- a/tools/libs/guest/Makefile
+++ b/tools/libs/guest/Makefile
@@ -102,7 +102,7 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(ZLIB_LIBS) -lz
+libxenguest.so.$(MAJOR).$(MINOR): LDLIBS += $(ZLIB_LIBS) -lz
 
 -include $(DEPS_INCLUDE)
 
diff --git a/tools/libs/hypfs/Makefile b/tools/libs/hypfs/Makefile
index 39feca87e8..efa955bd50 100644
--- a/tools/libs/hypfs/Makefile
+++ b/tools/libs/hypfs/Makefile
@@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
 MAJOR    = 1
 MINOR    = 0
 
-APPEND_LDFLAGS += -lz
+LDLIBS += -lz
 
 SRCS-y                 += core.c
 
diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index be32d95d39..622fa04470 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -166,14 +166,14 @@ NO_HEADERS_CHK := y
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
-LDUSELIBS-y += $(PTYFUNCS_LIBS)
-LDUSELIBS-$(CONFIG_LIBNL) += $(LIBNL3_LIBS)
-LDUSELIBS-$(CONFIG_Linux) += -luuid
-LDUSELIBS-$(CONFIG_Linux) += -lrt
-LDUSELIBS-$(CONFIG_ARM) += -lfdt
-LDUSELIBS-y += $(PTHREAD_LIBS)
-LDUSELIBS-y += -lyajl
-LDUSELIBS += $(LDUSELIBS-y)
+LDLIBS-y += $(PTYFUNCS_LIBS)
+LDLIBS-$(CONFIG_LIBNL) += $(LIBNL3_LIBS)
+LDLIBS-$(CONFIG_Linux) += -luuid
+LDLIBS-$(CONFIG_Linux) += -lrt
+LDLIBS-$(CONFIG_ARM) += -lfdt
+LDLIBS-y += $(PTHREAD_LIBS)
+LDLIBS-y += -lyajl
+LDLIBS += $(LDLIBS-y)
 
 $(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
 $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\"
@@ -232,7 +232,7 @@ $(XEN_INCLUDE)/_%.h: _%.h
 	$(call move-if-changed,_$*.h,$(XEN_INCLUDE)/_$*.h)
 
 libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS)
-	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDUSELIBS) $(APPEND_LDFLAGS)
+	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
 
 test_%: test_%.o test_common.o libxenlight_test.so
 	$(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS)
diff --git a/tools/libs/stat/Makefile b/tools/libs/stat/Makefile
index 01417b5334..c8c81048c0 100644
--- a/tools/libs/stat/Makefile
+++ b/tools/libs/stat/Makefile
@@ -26,7 +26,7 @@ SRCS-$(CONFIG_FreeBSD) += xenstat_freebsd.c
 
 LDLIBS-y += -lyajl
 LDLIBS-$(CONFIG_SunOS) += -lkstat
-APPEND_LDFLAGS += $(LDLIBS-y)
+LDLIBS += $(LDLIBS-y)
 
 include $(XEN_ROOT)/tools/libs/libs.mk
 
diff --git a/tools/libs/store/Makefile b/tools/libs/store/Makefile
index c208dbb48a..457122a041 100644
--- a/tools/libs/store/Makefile
+++ b/tools/libs/store/Makefile
@@ -5,7 +5,7 @@ MAJOR = 4
 MINOR = 0
 
 ifeq ($(CONFIG_Linux),y)
-APPEND_LDFLAGS += -ldl
+LDLIBS += -ldl
 endif
 
 SRCS-y   += xs_lib.c
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239546.415584 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUR-0004yz-U9; Mon, 06 Dec 2021 17:09:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239546.415584; Mon, 06 Dec 2021 17:09:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUR-0004xI-K8; Mon, 06 Dec 2021 17:09:23 +0000
Received: by outflank-mailman (input) for mailman id 239546;
 Mon, 06 Dec 2021 17:09:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHPI-0005ta-2K
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:04:04 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81e9c64e-56b6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:04:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81e9c64e-56b6-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810242;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=lpc84js2a7j5ldQO1A3ja4tbuLNhFUTRDx1cJp21TZ8=;
  b=eOPBwlimQoYdiwIenV0vriJLN4D6h/+/KeJjTn8CqHBc2gELjOyNRi8R
   JKIP83lSSNK8IG0bmzCqKmcQ96+Romg8x+JerCfvDi+jstMCPAu7VpeOt
   oMcKMt0fY2dqLeZ2EiHez3cLvI15Hjk3oXqWZdnQF17U2gCLVKd3V6ebH
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: j0KG2gvRPE/D7iuQvUkz21OplqOlk31EUGpuyIOfhrP17do5sM7CQ/I8VUgf8lL8oRL/Xw1Nl2
 FwopbUsdB6ioUrMph607yshOEgEiMRkNNvbvF+gcH1Q7Jgqb2CMBuqgHEX75V9BdC2RYEDnUTD
 KZ55tUQ+QxjG9J6Sky3VCBp4kxzF6yBQ5H24KvpubIWuWkv8ZZfh6x8npSb6b8Ob55fREwXPDS
 GazovbgsOKuhilHVXC4O9uz5UY1JR8gK6zqy+Tb03ekiz9J6qG8vonl/da9La4UXM8ijNgWJ8j
 kM0TG6xeOo1RXX5kWAuZb5J5
X-SBRS: 5.1
X-MesageID: 59370662
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eLD++6DMLgMZFRVW/8/kw5YqxClBgxIJ4kV8jS/XYbTApGwlgmBVy
 GdJUGDSOaqLZmSne4onb4u+oUIOsMeHzt9qQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX570Uw7wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/0BmquPN7k
 vR0qbu7RSdwAIeUp8EtekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTQ+9whsMlPY/zMZkWoH1IxjDFF/c2B5vERs0m4PcFjWxv3p4QR54yY
 eIEajZpMkjnTCF3AQ83A455gsuugljWJmgwRFW9+vNsvjm7IBZK+LnyMvLFd9qSX8JXk02E4
 GXc8AzRHRUyJNGZjz2f/RqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma3Xc5fL
 EoFvDIjt6Eo+GSkS9D8W1uzp3vsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQIcKl+gVT2YL7
 0OulN/JXAJF6IKweVvIo994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3ipQif6w9AsKQlWeLcCu//emu+pj10a4e+D2BDwQiKtK0QRGp1o7Tog
 ZTlpyR8xL1XZX1uvHbUKAnoIF1Pz6zfWNE7qQQwd6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0Nv8oOdPsUZ50kviI+THZuhb8NIAmjn9ZLlDvwc2TTRTIgzCFfLYEz8nTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvPLsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmrflA7RTp/UqCJmtvMueVNxsxoqwsBx
 VnlMmcw9bY1rSavxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:0n9VZ676BiLXgfkzbAPXwPDXdLJyesId70hD6qhwISY6TiX+rb
 HJoB17726NtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ
 0QCpSWY+eQMbEVt6nHCXGDYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59370662"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: [XEN PATCH 33/57] tools/vchan: Collect targets in TARGETS
Date: Mon, 6 Dec 2021 17:02:16 +0000
Message-ID: <20211206170241.13165-34-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

And use the new TARGETS to clean them. Now "clean" will remove
"vchan-socket-proxy".

$(RM) already have the "-f" flags, so remove the second one.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/vchan/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/vchan/Makefile b/tools/vchan/Makefile
index a731e0e073..c886c22e12 100644
--- a/tools/vchan/Makefile
+++ b/tools/vchan/Makefile
@@ -11,8 +11,10 @@ NODE2_OBJS = node-select.o
 $(NODE_OBJS) $(NODE2_OBJS): CFLAGS += $(CFLAGS_libxenvchan) $(CFLAGS_libxengnttab) $(CFLAGS_libxenevtchn)
 vchan-socket-proxy.o: CFLAGS += $(CFLAGS_libxenvchan) $(CFLAGS_libxenstore) $(CFLAGS_libxenctrl) $(CFLAGS_libxengnttab) $(CFLAGS_libxenevtchn)
 
+TARGETS := vchan-node1 vchan-node2 vchan-socket-proxy
+
 .PHONY: all
-all: vchan-node1 vchan-node2 vchan-socket-proxy
+all: $(TARGETS)
 
 vchan-node1: $(NODE_OBJS)
 	$(CC) $(LDFLAGS) -o $@ $(NODE_OBJS) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS)
@@ -30,7 +32,7 @@ install: all
 
 .PHONY: clean
 clean:
-	$(RM) -f *.o vchan-node1 vchan-node2 $(DEPS_RM)
+	$(RM) *.o $(TARGETS) $(DEPS_RM)
 
 distclean: clean
 
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:09:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:09:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239553.415600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUa-0006Fo-Oq; Mon, 06 Dec 2021 17:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239553.415600; Mon, 06 Dec 2021 17:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHUa-0006FE-Gu; Mon, 06 Dec 2021 17:09:32 +0000
Received: by outflank-mailman (input) for mailman id 239553;
 Mon, 06 Dec 2021 17:09:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+yl1=QX=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muHP8-0005ti-TQ
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:03:55 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d14dfc1-56b6-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 18:03:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d14dfc1-56b6-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638810233;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=fz7iB4/hMl48cBu22uue0tUZKrebFs2DyNDqcnDK2Iw=;
  b=ROxuHnGSlcrATfWsflv6fhHKkdpgAY4sXEMp0yo9UfA6xPu762IPO69V
   wE2nas5k2pr2q5tFe7gyHIb6xQkeuKTm8XQ96CW/bz5gc4BqDM4/DbHiK
   dbNHm6U8Yo4xjfmYUw5UQhOyAXZbEQnuwUBL/esgHGpu81zvwzaxV12Y9
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: rirpVZty3j+bOOjV58EewuXvHGh72oMfFIzE1grCdfzyyFYMI0I0jfwqx1uVIrPgNyZsu4/GBn
 bDPg8yO86RRGlotZjf08VliKBcOa8+0ykg+tp0tPpW5mvcZ2Udcgm4lzilnDDs9HKtelc9dkvT
 +9qg5Rfg3/FrbE3IUd5rNnqx+bELznVHN/LEiIBRslWLovavcfRAIrTXYd/FfKMLqcpP3zPwez
 Yzjilyz6uyCODfBOSniUCc5In7jNYbDPIEY5Mmr3ijRckKuDS3l1//xTG77Ji9vk0C4MGyx4Fa
 Oj9cfJTMT1h7HwhIgB8pLFjn
X-SBRS: 5.1
X-MesageID: 59766481
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:1pHFnKmo4M32J74P2aZkctfo5gwaIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeC23UbPaJYDD9L9gkOYXl9h8Av8fTytYyTVBtriEwRCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA187IMsdoUg7wbdg2NY22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NtmnJKfVA0mBZ3dqMoMVkllOhhlEKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKeBO
 ZRFOWMHgBLoZydXBXEpVLwEo+7xgkb2axMb9kzOqv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOTo/O0l0q/UNJ3M
 FEP92wlqq1a3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsRzhdaNsgpYkuSCYjz
 FOhkNbgBDgpu7qQIVqc6bW8vT60ITISL2IJeWkDVwRt3jX4iNht1FSVFI8lSfPryI2ucd3t/
 9yUhCYVrrs8kMQE7JWqzX7WhmKRj6HSYwFgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg
 JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWF2QY3d6TN4QhB7JJKkWp4xDhlbHlkPc8fEdMCS
 B+C4FgBjHO/0ZbDUEOWX25TI5lzpUQDPY68PhwxUjaoSsIrHONg1HsxDXN8J0i3zCARfVgXY
 P93i/qEA3cAErhAxzGrXeob2rJD7nlgnjOMH8GmlU75jur2iJuppVEtagHmggcRtvzsneko2
 4wHa5viJ+t3DoUSnRU7AaZMdAtXfBDX9Lj9qtBNd/7rH+aVMDpJNhMl+pt4I9YNt/0Mzo/gp
 yjhMmcFmAuXrSCWcm2iNyE8AI4DqL4i9BrXywR3Zg32s5XiCK7yhJoim2wfIeN6qbc9lKEsF
 JHouayoW5xyd9gOwBxFBbGVkWCoXE3DadumM3X3bT4hUYRnQgCVqNbochG2rHsFDzattNt4q
 Lqlj1uJTZ0GTgVkLcDXdPPwkA/h4SlDwLp/DxnSP91eWETw64w2eSb/ueA6fpMXIhLZyzrEi
 wvPWUUEpfPAqpMe+cXSgfzWtJ+gFuZzRxIIH2TS4busGzPd+26vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw109TnvRblmtBrdxGVW83JFC5v9X27tUmQqqQ
 UbTqNNUDqqEZZH+G1kLKQt7MunajaMImiPf5OgeKVnh4HMl56KOVEhfMkXeiCFZK7cpYoopz
 f145ZwT4g27zBErLsyHnmZf8GHVdi4MVKAut5c7Bo73i1V0lgEeMMKEUiKmsouSb9hsM1UxJ
 m7GjaXPsL1Q207efidhDnPKx+dc2cwDtR0iIIXu/LhVdg4pXsMK4SA=
IronPort-HdrOrdr: A9a23:tpesOqnjWiLHPUrUxexJ662u7cbpDfIq3DAbv31ZSRFFG/Fxl6
 iV88jzsiWE7wr5OUtQ4OxoV5PgfZqxz/NICMwqTNWftWrdyQ+VxeNZjbcKqgeIc0aVygce79
 YET0EXMqyXMbEQt6jHCWeDf+rIuOP3k5yVuQ==
X-IronPort-AV: E=Sophos;i="5.87,292,1631592000"; 
   d="scan'208";a="59766481"
From: Anthony PERARD <anthony.perard@citrix.com>
To: <xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@gmail.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [XEN PATCH 28/57] tools/fuzz/x86_instruction_emulator: rework makefile
Date: Mon, 6 Dec 2021 17:02:11 +0000
Message-ID: <20211206170241.13165-29-anthony.perard@citrix.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20211206170241.13165-1-anthony.perard@citrix.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

Rework dependencies of all objects. We don't need to add dependencies
for headers that $(CC) is capable of generating, we only need to
include $(DEPS_INCLUDE). Some dependencies are still needed so make
knows to generate symlinks for them.

We remove the use of "vpath" for cpuid.c. While it works fine for now,
when we will convert this makefile to subdirmk, vpath will not be
usable. Also, "-iquote" is now needed to build "cpuid.o".

Replace "-I." by "-iquote .", so it applies to double-quote includes
only.

Rather than checking if a symlink exist, always regenerate the
symlink. So if the source tree changed location, the symlink is
updated.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 .gitignore                                   |  1 +
 tools/fuzz/x86_instruction_emulator/Makefile | 32 +++++++++-----------
 2 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/.gitignore b/.gitignore
index 4267bb4dee..8fb74a4c94 100644
--- a/.gitignore
+++ b/.gitignore
@@ -201,6 +201,7 @@ tools/fuzz/libelf/libelf-*.c
 tools/fuzz/x86_instruction_emulator/asm
 tools/fuzz/x86_instruction_emulator/afl-harness
 tools/fuzz/x86_instruction_emulator/afl-harness-cov
+tools/fuzz/x86_instruction_emulator/cpuid.c
 tools/fuzz/x86_instruction_emulator/wrappers.c
 tools/fuzz/x86_instruction_emulator/x86_emulate
 tools/fuzz/x86_instruction_emulator/x86-emulate.[ch]
diff --git a/tools/fuzz/x86_instruction_emulator/Makefile b/tools/fuzz/x86_instruction_emulator/Makefile
index 1a6dbf94e1..f11437e6a2 100644
--- a/tools/fuzz/x86_instruction_emulator/Makefile
+++ b/tools/fuzz/x86_instruction_emulator/Makefile
@@ -8,33 +8,27 @@ else
 x86-insn-fuzz-all:
 endif
 
-# Add libx86 to the build
-vpath %.c $(XEN_ROOT)/xen/lib/x86
+cpuid.c: %: $(XEN_ROOT)/xen/lib/x86/% FORCE
+	ln -nsf $< $@
 
-x86_emulate:
-	[ -L $@ ] || ln -sf $(XEN_ROOT)/xen/arch/x86/$@
+x86_emulate: FORCE
+	ln -nsf $(XEN_ROOT)/xen/arch/x86/$@
 
 x86_emulate/%: x86_emulate ;
 
-x86-emulate.c x86-emulate.h wrappers.c: %:
-	[ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$*
+x86-emulate.c x86-emulate.h wrappers.c: %: $(XEN_ROOT)/tools/tests/x86_emulator/% FORCE
+	ln -nsf $< $@
 
-CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -I.
+CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -iquote .
+cpuid.o: CFLAGS += -iquote $(XEN_ROOT)/xen/lib/x86
 
 GCOV_FLAGS := --coverage
 %-cov.o: %.c
 	$(CC) -c $(CFLAGS) $(GCOV_FLAGS) $< -o $@
 
-x86.h := $(addprefix $(XEN_ROOT)/tools/include/xen/asm/,\
-                     x86-vendors.h x86-defns.h msr-index.h) \
-         $(addprefix $(XEN_ROOT)/tools/include/xen/lib/x86/, \
-                     cpuid.h cpuid-autogen.h)
-x86_emulate.h := x86-emulate.h x86_emulate/x86_emulate.h $(x86.h)
-
-# x86-emulate.c will be implicit for both
-x86-emulate.o x86-emulate-cov.o: x86_emulate/x86_emulate.c $(x86_emulate.h)
-
-fuzz-emul.o fuzz-emulate-cov.o cpuid.o wrappers.o: $(x86_emulate.h)
+x86-emulate.h: x86_emulate/x86_emulate.h
+x86-emulate.o x86-emulate-cov.o: x86-emulate.h x86_emulate/x86_emulate.c
+fuzz-emul.o fuzz-emul-cov.o wrappers.o: x86-emulate.h
 
 x86-insn-fuzzer.a: fuzz-emul.o x86-emulate.o cpuid.o
 	$(AR) rc $@ $^
@@ -51,7 +45,7 @@ all: x86-insn-fuzz-all
 
 .PHONY: distclean
 distclean: clean
-	rm -f x86_emulate x86-emulate.c x86-emulate.h
+	rm -f x86_emulate x86-emulate.c x86-emulate.h wrappers.c cpuid.c
 
 .PHONY: clean
 clean:
@@ -67,3 +61,5 @@ afl: afl-harness
 
 .PHONY: afl-cov
 afl-cov: afl-harness-cov
+
+-include $(DEPS_INCLUDE)
-- 
Anthony PERARD



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 17:12:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 17:12:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239557.415611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHX0-0000p1-68; Mon, 06 Dec 2021 17:12:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239557.415611; Mon, 06 Dec 2021 17:12:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muHX0-0000ou-2G; Mon, 06 Dec 2021 17:12:02 +0000
Received: by outflank-mailman (input) for mailman id 239557;
 Mon, 06 Dec 2021 17:12:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muHWz-0000oo-NB
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 17:12:01 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e7d875b-56b7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 18:12:00 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44694)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muHWv-0011Gn-2G (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 17:11:57 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 5B0FE1FDB9;
 Mon,  6 Dec 2021 17:11:57 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e7d875b-56b7-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a8519cba-9f63-998a-908c-a87faf8f4a88@srcf.net>
Date: Mon, 6 Dec 2021 17:11:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206142929.29105-1-jgross@suse.com>
 <20211206142929.29105-3-jgross@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v2 2/2] tools/helpers: set event channel for PVH
 xenstore-stubdom console
In-Reply-To: <20211206142929.29105-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 14:29, Juergen Gross wrote:
> In contrast to the PFN of the console ring page the event channel of
> the console isn't being set automatically by xc_dom_build_image().
>
> Call xc_hvm_param_set() explicitly for that reason.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

So, technically, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

However...

That said, there is a distinct lack of joined-up thinking in this interface.

It makes no sense whatsoever to for xc_dom_build_image() to build the
grant, but leave the evtchn to the caller.

And indeed,

xg_dom_x86.c: start_info->console.domU.evtchn = dom->console_evtchn;

we set it up on the PV side of things.  So I think the proper fix is to
wire up the HVM side and prevent the callers needing to do this.


Furthermore, I doubt we skip setting up the xenstore connection.

Really, the users of xc_dom_build_image() want a console Y/n, xenstore
Y/n type interface, and judging by the fields we've already got, that
can reasonably be done on the non-zero-ness of *_evtchn

(It is also weird that the caller is required to bind the evtchn, but
that's so baked into the API that I'd need to rearrange code between
Ocaml daemons to make use of a "library code allocates evtchn+grant
together" option.)

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:12:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:12:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239713.415625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muITL-00011u-Pf; Mon, 06 Dec 2021 18:12:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239713.415625; Mon, 06 Dec 2021 18:12:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muITL-00011n-MB; Mon, 06 Dec 2021 18:12:19 +0000
Received: by outflank-mailman (input) for mailman id 239713;
 Mon, 06 Dec 2021 18:12:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=gMFW=QX=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muITK-00011g-GV
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:12:18 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ad4da63-56c0-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 19:12:16 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44712)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muITH-000uWW-0Z (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 06 Dec 2021 18:12:15 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 00A0B1FDB9;
 Mon,  6 Dec 2021 18:12:14 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ad4da63-56c0-11ec-a5e1-b9374ead2679
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <3f742d50-1b45-b0f0-d7ad-dc3d4763f5c7@srcf.net>
Date: Mon, 6 Dec 2021 18:12:14 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211130100445.31156-1-andrew.cooper3@citrix.com>
 <20211130100445.31156-9-andrew.cooper3@citrix.com>
 <282f884c-834e-caf7-4e09-6c7a662c666e@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH RFC 8/8] x86/boot: Check that permission restrictions have
 taken effect
In-Reply-To: <282f884c-834e-caf7-4e09-6c7a662c666e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 02/12/2021 13:33, Jan Beulich wrote:
> On 30.11.2021 11:04, Andrew Cooper wrote:
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>>
>> RFC.  I don't know if this is something we'd want to keep or not.
>>
>> Getting extable handling working for test_nx_data is proving tricky, and while
>> I can't spot anything that should stop the extable from working with NX
>> faults, from a security hardening perspective, there really ought to
>> be.
>>
>> (Spurious faults aside), there are no circumstances where an NX fault is
>> legitimate, and restricting extable's ability to interfere with the fatality
>> of an NX fault provides a better security posture.
> Gating the extable_fixup() invocation accordingly should be possible.
> A respective check could live even earlier, but the window between
> the !guest_mode() check and the function's invocation isn't very large
> anyway.
>
> Since we can't have both testability and such faults being uniformly
> fatal, but since otoh we use pre_extable quite sparingly, how about
> forcing the fixup to take that path by disabling interrupts around
> the test?

That feels like an abuse of an unrelated mechanism, not to mention fragile.

> In any event this touches the insufficient selectiveness of the fixup
> machinery again: Any kind of fault will be recovered from whenever a
> fixup record is attached to an insn.

There are multiple things here.  Yes, I agree that fixing up all faults
is suboptimal.

But even within #PF alone, things such as SMAP/SMEP faults are
programmer error with no hope of extable being able to adequately
resolve, and should be fatal.

I actually like the approach that Linux has recently taken, by
describing a fixup type rather than arbitrary logic, in an attempt to
keep the number of special cases from getting out of hand.  This
approach is quite easy to filter into specific exceptions.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239722.415640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZx-00026H-Rs; Mon, 06 Dec 2021 18:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239722.415640; Mon, 06 Dec 2021 18:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZx-000261-KG; Mon, 06 Dec 2021 18:19:09 +0000
Received: by outflank-mailman (input) for mailman id 239722;
 Mon, 06 Dec 2021 18:19:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-00023m-V8
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-00041Q-TK
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-0004SN-S1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZZ-0001ab-PV; Mon, 06 Dec 2021 18:18:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From;
	bh=/xWqCJ7e+7pgQhkBZx8kQDeJeJ9c/oGVBEOm162UKU4=; b=5vhTEcvS8520hCBqARN4XiBezy
	wmgVCQ+72hWg+KzhbkxgxF7w8D0+rR+u/rG0DpWOhQj1kn/3Ez0k9QlK0j8pxEhKRdaLyaAu1XcbB
	oo7u72irBwheRYmKArsmPalK2uAk7tMJ+TF285JPbQ4+xkWOL1H7j7Lhp+d7y2OTSzsQ=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 00/13] Miscellaneous improvements
Date: Mon,  6 Dec 2021 18:18:26 +0000
Message-Id: <20211206181839.23463-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

These patches were accumulated during the Xen 4.16 freeze and as RM I
chose to defer them.  I am submitting them to osstest pretest now.

Ian Jackson (12):
  make-flight: do_examine_one: add firmware argument
  ts-memdisk-try-append: Reindent (nfc)
  ts-memdisk-try-append: Enable perl warnings
  ts-memdisk-try-append: More defensive case test
  examination: skip memdisk on non-BIOS hosts, run per-firmware on x86
  starvation: Only count "pass" and "fail" as done jobs
  sg-run-job: Do not set a step status to pass unless it's running
  TestSupport: sub broken: break out "$msg"
  TestSupport: sub broken: Add a newline
  TestSupport: sub broken: exit with status 0 for skip
  TestSupport: sub broken: document that it does not return.
  ts-memdisk-try-append: Fix for fact that broken() does not return

Roger Pau Monne (1):
  ts-xen-install: enable timestamp on guests logs

 Osstest/Executive.pm        |  3 ++-
 Osstest/TestSupport.pm      | 13 ++++++++++--
 make-flight                 | 24 +++++++++++++++++++--
 mfi-common                  |  1 +
 tcl/JobDB-Executive.tcl     |  1 +
 ts-hosts-allocate-Executive |  5 ++++-
 ts-memdisk-try-append       | 42 +++++++++++++++++++++++++------------
 ts-xen-install              |  2 +-
 8 files changed, 71 insertions(+), 20 deletions(-)

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239723.415646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZy-0002CT-5X; Mon, 06 Dec 2021 18:19:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239723.415646; Mon, 06 Dec 2021 18:19:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZx-00029y-V5; Mon, 06 Dec 2021 18:19:09 +0000
Received: by outflank-mailman (input) for mailman id 239723;
 Mon, 06 Dec 2021 18:19:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-00023y-Ml
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-00041Y-Lw
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-0004Ss-L9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZb-0001ab-4V; Mon, 06 Dec 2021 18:18:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=0/OUNZQAV8JGMY/13VgnZluycff2ARMtudSMh6lwEvk=; b=JU8tqdMvdZ7iM+tnM6psy7kiEr
	UcdkgWLBooYlaRS1Y+1mEXoZAPfhZ20eej1Ty6Q0i+LbJDAYEUIuX0TFOeDpfrqsaM9zKtVRfOWWV
	EdwKFIrI8aQnaarH0Mw4Nz3sotL6G93N5yUlaxzbHAJ7/fEJ+MviiNMpOSsDtMPAeQG8=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 04/13] ts-memdisk-try-append: More defensive case test
Date: Mon,  6 Dec 2021 18:18:30 +0000
Message-Id: <20211206181839.23463-5-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index bfb36caf7..d5c12866f 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -34,14 +34,14 @@ arch=`perl -I. -we '
 case "$arch" in
 amd64)
     ;;
-'')
-    echo >&2 'Job arch retrieval failed?'
-    exit 1
-    ;;
-*)
+[a-z]*)
     echo "Arch $arch not supported for memdisk tests"
     exit 0
     ;;
+*)
+    echo >&2 'Job arch retrieval failed?'
+    exit 1
+    ;;
 esac
 
 if ./ts-freebsd-host-install --test-boot --record-append $@; then
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239725.415665 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZz-0002cC-C5; Mon, 06 Dec 2021 18:19:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239725.415665; Mon, 06 Dec 2021 18:19:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZz-0002Yu-1g; Mon, 06 Dec 2021 18:19:11 +0000
Received: by outflank-mailman (input) for mailman id 239725;
 Mon, 06 Dec 2021 18:19:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-00025u-J9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-00041l-IB
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-0004Tc-H9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZb-0001ab-U0; Mon, 06 Dec 2021 18:18:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=E4sdrcKA9Vi1NCC94foXRbrUT73w1XN6CbQdZ8WGihM=; b=ckl7geURG7dCT1Vv4lpzpctz6F
	9/iBtNwa3I9eeu25U4J2FI85B2jKrhMetAgC+WIYWFUnBho91H7LCu8i9mgGIbQoUbZyrTo+rKwn8
	xVZVO9y9xHUmiV2h/zywlFBlyNAxkSg8THEpl0TBm3akMrvtle42XvF9+Fy5HubDt/Zk=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 07/13] sg-run-job: Do not set a step status to pass unless it's running
Date: Mon,  6 Dec 2021 18:18:33 +0000
Message-Id: <20211206181839.23463-8-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This avoids skip etc. being treated as pass.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 tcl/JobDB-Executive.tcl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tcl/JobDB-Executive.tcl b/tcl/JobDB-Executive.tcl
index 38248823e..8e0062f59 100644
--- a/tcl/JobDB-Executive.tcl
+++ b/tcl/JobDB-Executive.tcl
@@ -326,6 +326,7 @@ proc step-set-status {flight job stepno st} {
                AND status<>'broken'
                AND status<>'starved'
                AND status<>'fail'
+               AND NOT ('$st' = 'pass' AND status <> 'running')
         "
         set pause 0
         db-execute-array stopinfo "
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239721.415636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZx-00024J-GN; Mon, 06 Dec 2021 18:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239721.415636; Mon, 06 Dec 2021 18:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZx-00024C-Cf; Mon, 06 Dec 2021 18:19:09 +0000
Received: by outflank-mailman (input) for mailman id 239721;
 Mon, 06 Dec 2021 18:19:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-00023n-V0
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-00041S-Tf
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZv-0004SP-Sd
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:07 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZa-0001ab-95; Mon, 06 Dec 2021 18:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=lEtnuJt+WSxztv0gI+YXz7Qx8X+A2HNxfMWZD6HRtIs=; b=wvUjxe2uF+XeLWkd/xfRulO+8V
	8UAuscO2uAeMnsQl+7jCkp8Vocvq3vOUto4kgsCx02mkuVJPknsyGFi4OHrf2v7DGy+iqAwbb3Pf9
	L9LFNeG5/VDQURq9Vx10fe2cOna0j8MtVzRfGM5Q4HS7jI4p2L5OvrQsvzDMpMUjGftk=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 01/13] make-flight: do_examine_one: add firmware argument
Date: Mon,  6 Dec 2021 18:18:27 +0000
Message-Id: <20211206181839.23463-2-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Nothing sets this yet.

No functional change (checked with standalone-generate-dump-flight-runvars)

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 make-flight | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/make-flight b/make-flight
index ecbb195bc..acb19b113 100755
--- a/make-flight
+++ b/make-flight
@@ -687,20 +687,31 @@ do_pv_debian_tests () {
 }
 
 do_examine_one () {
+  local firmware="$1"
+
   case "$branch" in
     xen-unstable)		;; # only likely to regress on -unstable
     osstest)			;; # very likely to regress
     linux-*)			;; # often seems to regress
     *)			return	;; # stuff used for guests is irrelevant
   esac
+
+  local firmware_suffix
+  local firmware_hostflag
+  if [ "$firmware" ]; then
+    firmware_suffix=-$firmware
+    firmware_hostflag=,PropEq:Firmware:bios:$firmware
+  fi
+
   local freebsd_runvars
   # set_freebsd_runvars expects $arch to be set to the desired FreeBSD arch.
   local arch=$dom0arch
   # Pass true to not append any hostflags when creating the FreeBSD runvars.
   set_freebsd_runvars true
-  job_create_test test-$xenarch$kern-$dom0arch-examine \
+  job_create_test test-$xenarch$kern-$dom0arch-examine${firmware_suffix} \
                   host-examine-xen xl $xenarch $dom0arch \
-                  all_hostflags=$most_hostflags $freebsd_runvars
+                  all_hostflags=$most_hostflags$firmware_hostflag \
+                  $freebsd_runvars
 }
 
 test_matrix_do_one () {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239726.415674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa0-0002jj-10; Mon, 06 Dec 2021 18:19:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239726.415674; Mon, 06 Dec 2021 18:19:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZz-0002hh-GU; Mon, 06 Dec 2021 18:19:11 +0000
Received: by outflank-mailman (input) for mailman id 239726;
 Mon, 06 Dec 2021 18:19:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-00025z-JY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-00041n-Ig
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZx-0004Th-Hs
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:09 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZc-0001ab-Cc; Mon, 06 Dec 2021 18:18:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=HAxun9MazXyqzqKC8qATdNCpO7XqgWpXADfqESY/Jcw=; b=YHRjbWl/B5Gn96/S5QoB0HUGVw
	OeaawK0kz+G/w4LlOBEB7hrOcrYgB4xWzK2YBVxzQlIVxdnYgkiafMm89wJ8zdCyhkGTXNDZA8fGW
	X9zoviaRTe/S5czo3U5KY4OfPi37rgRiHv44qtK+lD0YBY5h+eOQ53/fxcIDmifyywE8=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 08/13] TestSupport: sub broken: break out "$msg"
Date: Mon,  6 Dec 2021 18:18:34 +0000
Message-Id: <20211206181839.23463-9-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

No functional change.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/TestSupport.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index a0ca69437..b17bf08a6 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -281,8 +281,10 @@ sub broken ($;$) {
                AND (status='queued' OR status='running' OR status='preparing')
 END
     });
-    die uc($newst).": $m; ". ($affected>0 ? "marked $flight.$job $newst"
-                         : "($flight.$job not marked $newst)");
+    my $msg = uc($newst).": $m; ".
+      ($affected>0 ? "marked $flight.$job $newst"
+                   : "($flight.$job not marked $newst)");
+    die $msg;
 }
 
 sub complete_testid ($) {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239724.415654 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZy-0002L5-H7; Mon, 06 Dec 2021 18:19:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239724.415654; Mon, 06 Dec 2021 18:19:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZy-0002HU-AU; Mon, 06 Dec 2021 18:19:10 +0000
Received: by outflank-mailman (input) for mailman id 239724;
 Mon, 06 Dec 2021 18:19:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-000245-Nj
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-00041b-N5
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZw-0004Su-M9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:08 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZb-0001ab-Dt; Mon, 06 Dec 2021 18:18:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=tKYzhrg4LaQRu+bVlR1HwzJODJv++S9HM1BoZIlLRIs=; b=fIjBgc3PxOxTwqcpRFoCJd6/R9
	C22jX851az0qrpi0rEja0WQGME8WN4BSFbgPtarV0bBDyUuF6vrY/4yl8sCYbMkaGAzeUKcqh/lmA
	Vc1tPzqvtpDcn7/R1XLE0kdtCKVw7E1LxDHU3yX5AmKIRo7dRZX2Kx/P7wbCD9hEhAiE=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 05/13] examination: skip memdisk on non-BIOS hosts, run per-firmware on x86
Date: Mon,  6 Dec 2021 18:18:31 +0000
Message-Id: <20211206181839.23463-6-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This is a combination of two changes:

ts-memdisk-try-append: skip memdisk test on non-BIOS hosts

make-flight: examine: Insist on -bios and -uefi tests on x86

  This will let us skip ts-memdisk-try-append on non-bios platforms
  without risking regression.  It will also definitely spot
  regressions which will occur on any uefi host.

  standalone-generate-dump-flight-runvars reveals the changes are as
  follows:

  New jobs
     test-amd64-i386-examine-bios     test-amd64-i386-examine-uefi
     test-amd64-amd64-examine-bios    test-amd64-amd64-examine-uefi
  added everywhere that has the corresponding plain job, namely
     osstest
     linux-*
     xen-unstable

  These jobs are just like the plain jobs, except that one of
     ,PropEq:Firmware:bios:bios
     ,PropEq:Firmware:bios:uefi
  has been added to the end of all_hostflags.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 make-flight           |  9 +++++++++
 mfi-common            |  1 +
 ts-memdisk-try-append | 18 ++++++++++++++++++
 3 files changed, 28 insertions(+)

diff --git a/make-flight b/make-flight
index acb19b113..d7eeb4ebb 100755
--- a/make-flight
+++ b/make-flight
@@ -736,6 +736,15 @@ test_matrix_do_one () {
   do_credit12_tests
 
   do_examine_one
+  case "$dom0arch" in
+    i386|amd64)
+      # Test on BIOS, which makes sure we test one where FreeBSD should
+      # work.  See ts-memdisk-try-append, and set_freebsd_runvars in
+      # mfi-common.
+      do_examine_one bios
+      do_examine_one uefi
+      ;;
+  esac
 
   # No further arm tests at the moment
   if [ $dom0arch = armhf -o $dom0arch = arm64 ]; then
diff --git a/mfi-common b/mfi-common
index 771843f05..59e712f4e 100644
--- a/mfi-common
+++ b/mfi-common
@@ -163,6 +163,7 @@ set_freebsd_runvars () {
     if [ x$no_hostflags != xtrue ]; then
         # osstest doesn't yet know how to install FreeBSD on UEFI hosts, so
         # limit the usable hardware to boxes that boot from BIOS.
+        # See also in ts-memdisk-try-append.
         freebsd_runvars="all_hostflags,=PropEq:Firmware:bios:bios"
     fi
 
diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index d5c12866f..18c4aaa5c 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -28,6 +28,20 @@ arch=`perl -I. -we '
     $whhost ||= "host";
     our $ho = selecthost($whhost);
 
+    if (get_target_property($ho,"firmware") ne "bios") {
+        # osstest does not yet know how to install FreeBSD on UEFI hosts
+	# See also in set_freebsd_runvars in mfi_common
+
+	# Skipping this test on non-BIOS does not lead to pushes
+	# where this test is broken, because make-flght test_matrix_do_one
+	# arranges to run this test on BIOS too.
+
+        broken("skipping memdisk because firmware is not bios",
+	       "skip");
+	print "SKIP\n" or die $!;
+	exit 0;
+    }
+
     print $ho->{Arch} or die $!;
     ' "$@"`
 
@@ -38,6 +52,10 @@ amd64)
     echo "Arch $arch not supported for memdisk tests"
     exit 0
     ;;
+SKIP)
+    echo "Step skipped."
+    exit 0
+    ;;
 *)
     echo >&2 'Job arch retrieval failed?'
     exit 1
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239727.415680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa0-0002of-AV; Mon, 06 Dec 2021 18:19:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239727.415680; Mon, 06 Dec 2021 18:19:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIZz-0002lw-S2; Mon, 06 Dec 2021 18:19:11 +0000
Received: by outflank-mailman (input) for mailman id 239727;
 Mon, 06 Dec 2021 18:19:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZy-0002N6-Fz
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZy-000421-Ew
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIZy-0004UY-EB
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:10 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZc-0001ab-M2; Mon, 06 Dec 2021 18:18:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=gGu0w5xm335ZO+mQt5bBh31RANCZN/xrtBOK2vpeXWI=; b=fBJVNz5JogQeGjob2UH724w5gv
	fD+bUVRBCkw20NnLoQZrwNF+518fmozZVd3YES0WdKVA4frRZzDrDIVDPnqDP8vejfasvmRCLqyYJ
	IRYkyI12/trEihCrlY3S/WOKWGoiPApMLjV+ottWbJDaSuXyisvDabzjC3Fw2/lDFe4E=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 09/13] TestSupport: sub broken: Add a newline
Date: Mon,  6 Dec 2021 18:18:35 +0000
Message-Id: <20211206181839.23463-10-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

This suppresses printing of the the line number, which is not useful.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/TestSupport.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index b17bf08a6..ff890f96c 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -283,7 +283,8 @@ END
     });
     my $msg = uc($newst).": $m; ".
       ($affected>0 ? "marked $flight.$job $newst"
-                   : "($flight.$job not marked $newst)");
+                   : "($flight.$job not marked $newst)").
+		     "\n";
     die $msg;
 }
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239728.415713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa6-0004BM-Gz; Mon, 06 Dec 2021 18:19:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239728.415713; Mon, 06 Dec 2021 18:19:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa6-0004BD-BF; Mon, 06 Dec 2021 18:19:18 +0000
Received: by outflank-mailman (input) for mailman id 239728;
 Mon, 06 Dec 2021 18:19:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00043g-HX
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00042t-GY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-0004XO-Fq
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZa-0001ab-IC; Mon, 06 Dec 2021 18:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=l2p5B8Z1X/IiNxWnmW87oEopqHbNh5M0axAqa8AjdDo=; b=GjVWN4nCkoIOy58NdCKqouH+Aj
	orPXkU72aXgMQZ1m0ULCyxIn9ULJPeYifv6E+Ilm9KiwZ+/7JT7sWj3zgsw0hNRHXtMGxgTvigHGv
	OkKj5HdvG49FoUWzw8AAWh4NkySkCP2DKa1LhJcFoTVKdlXCZatBhpcP4v5vESBN2TAQ=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 02/13] ts-memdisk-try-append: Reindent (nfc)
Date: Mon,  6 Dec 2021 18:18:28 +0000
Message-Id: <20211206181839.23463-3-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index 4b54eff01..a35751eb3 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -19,17 +19,17 @@
 set -xe -o posix
 
 arch=`perl -I. -e '
-                use Osstest;
-                use Osstest::TestSupport;
+    use Osstest;
+    use Osstest::TestSupport;
 
-                tsreadconfig();
+    tsreadconfig();
 
-		our $whhost = pop @ARGV; # arg parsing bodge
-		$whhost ||= "host";
-		our $ho = selecthost($whhost);
+    our $whhost = pop @ARGV; # arg parsing bodge
+    $whhost ||= "host";
+    our $ho = selecthost($whhost);
 
-                print $ho->{Arch} or die $!;
-              ' "$@"`
+    print $ho->{Arch} or die $!;
+    ' "$@"`
 
 case "$arch" in
 amd64)
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239729.415719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa7-0004GR-AQ; Mon, 06 Dec 2021 18:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239729.415719; Mon, 06 Dec 2021 18:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa6-0004Et-Om; Mon, 06 Dec 2021 18:19:18 +0000
Received: by outflank-mailman (input) for mailman id 239729;
 Mon, 06 Dec 2021 18:19:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00043i-Hi
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00042s-GY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-0004XN-Fh
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZa-0001ab-Qq; Mon, 06 Dec 2021 18:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=icR62vyDL1qMkaGEnJxyTT6ACzd2sPw3zE4q96m+q6E=; b=L0/0P/lHruNEaIO6/xmH1bcBIs
	1mgMpVUBmvhz5g9fRUKuPv/Gqm6rO0uHLy+r7OnankmHDdYIytx71tjYhPBu1oG9ilyZv5OtWnwx4
	wEU+jA0f+tw/ytr9fIzenvOTx8fwQYUdpxt0Z6IYNACcLhS0TQWvukv6Xx1zk9XzKiys=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 03/13] ts-memdisk-try-append: Enable perl warnings
Date: Mon,  6 Dec 2021 18:18:29 +0000
Message-Id: <20211206181839.23463-4-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index a35751eb3..bfb36caf7 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -18,7 +18,7 @@
 
 set -xe -o posix
 
-arch=`perl -I. -e '
+arch=`perl -I. -we '
     use Osstest;
     use Osstest::TestSupport;
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:19:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:19:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239730.415724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa7-0004ML-Oo; Mon, 06 Dec 2021 18:19:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239730.415724; Mon, 06 Dec 2021 18:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIa7-0004K5-B3; Mon, 06 Dec 2021 18:19:19 +0000
Received: by outflank-mailman (input) for mailman id 239730;
 Mon, 06 Dec 2021 18:19:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00043e-Gn
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-00042q-G1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIa4-0004XL-FE
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:19:16 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZb-0001ab-Lh; Mon, 06 Dec 2021 18:18:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=bqo9dp3bh1RBhH7U9oY8kFETe1MnW3DmvX4ubqZj5Mg=; b=N2UAcpaYQAmrzs4S0wzvHYUQ07
	enpFOaOdLCYB4IUgqM35kBDh/cM/kSGVI5EDJWeJ8frpq8ywJ3EYMgwIWUjuvXQm4xamKvsxGFzzZ
	oFyjtexfALV932EwD/lLUQ13U3ryLf+0rk8B9o993Wd2tNcFrnyY3OGGNwbPcZARt6SI=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 06/13] starvation: Only count "pass" and "fail" as done jobs
Date: Mon,  6 Dec 2021 18:18:32 +0000
Message-Id: <20211206181839.23463-7-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The main effect is to treat "broken" and "blocked" jobs as not part of
the flight for starvation calculations.

This is correct for commissioning flights and OK for other flights.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/Executive.pm        | 3 ++-
 ts-hosts-allocate-Executive | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index d95d848dc..9d7c71369 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1148,7 +1148,8 @@ END
 #        to allow for slow jobs, compared to other jobs
 #    W   number of jobs waiting - strictly, jobs in states
 #          preparing queued running
-#    D   number of jobs done - strictly, other states
+#    D   number of jobs done - strictly, jobs in states
+#          pass fail
 #  tuning parameters:
 #    Xt  X when D=9 W=1, ie cancel one job out of ten
 #    Xh  X when D=1 W=1, ie cancel one job out of two
diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
index 4dfcd0cd1..19047d49e 100755
--- a/ts-hosts-allocate-Executive
+++ b/ts-hosts-allocate-Executive
@@ -846,11 +846,14 @@ sub starving ($$$) {
 	    # is indistinguishable from a flight which is at the head
 	    # of the queue for a small set of resources.
 	    return (0, "job $j status $st, don't give up just yet");
-	} else {
+	} elsif ($st eq 'pass' ||
+		 $st eq 'fail') {
 	    $d++;
 	    return (0, "job $j status $st but no step finished time!")
 		unless defined $fin;
 	    $maxfin = $fin if $fin > $maxfin;
+	} else {
+	    # disregard - neither W or D
 	}
     }
     # we quit if the total time from the start of the flight
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:38:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:38:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239779.415761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIs3-0002Nh-QS; Mon, 06 Dec 2021 18:37:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239779.415761; Mon, 06 Dec 2021 18:37:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIs3-0002NZ-N2; Mon, 06 Dec 2021 18:37:51 +0000
Received: by outflank-mailman (input) for mailman id 239779;
 Mon, 06 Dec 2021 18:37:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs1-0002Mh-Mq
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs1-0004P0-M2
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:49 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs1-0005wH-L1
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:49 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZd-0001ab-GN; Mon, 06 Dec 2021 18:18:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=I5yXtPyPBnrZoZJSoImKqyDBmegh/vmnKZGykPQCUgw=; b=LKM4x4aOGRg1SL7JkO8jyOpTxl
	4mqvOrGATgpUiY2idBUfn37XvJplz5x5aDacHFnj2gbLKI3uR3aVx59pOwFi3PdCMJyL+7/0MfCVx
	RysZcOYygo2daovJry2ZcX/n+FVeBDRap2//JE7vx/D8I9+coDKhBSnxWekvU6rvGqio=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 11/13] TestSupport: sub broken: document that it does not return.
Date: Mon,  6 Dec 2021 18:18:37 +0000
Message-Id: <20211206181839.23463-12-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/TestSupport.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index ebe436275..8103ea1d3 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -261,6 +261,7 @@ sub fail ($) {
 sub broken ($;$) {
     my ($m, $newst) = @_;
     # must be run outside transaction
+    # dies or exits
     my $affected;
     $newst= 'broken' unless defined $newst;
     eval {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:38:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:38:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239778.415749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIry-00026b-IW; Mon, 06 Dec 2021 18:37:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239778.415749; Mon, 06 Dec 2021 18:37:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIry-00026U-FS; Mon, 06 Dec 2021 18:37:46 +0000
Received: by outflank-mailman (input) for mailman id 239778;
 Mon, 06 Dec 2021 18:37:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIrx-00026O-62
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIrx-0004Ok-3X
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:45 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIrx-0005vO-2R
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:45 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZd-0001ab-00; Mon, 06 Dec 2021 18:18:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=QQIjB4bvZcjYIHEme4Iso/oFJMJrpCjQ9+ROuu/dI2c=; b=Ad22Dr4CnydoGPKYUmhV4ZS1fZ
	DiV7+ZaDsAook6bTdt6tvqUeCjsyQPi7KUG+odqb2+oBlqCiw3KPZQV0L1j7mLa0xsZFga+Y1Qv8p
	pBKvX/pl3CFdnT8TUXilxfuwBUYM/I03c6WsF1KsMxSnayrjeLMJSWfMCNrhpLgOjqpY=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 10/13] TestSupport: sub broken: exit with status 0 for skip
Date: Mon,  6 Dec 2021 18:18:36 +0000
Message-Id: <20211206181839.23463-11-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Otherwise, whatever calls us will set the step to fail (or something).

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/TestSupport.pm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index ff890f96c..ebe436275 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -285,7 +285,12 @@ END
       ($affected>0 ? "marked $flight.$job $newst"
                    : "($flight.$job not marked $newst)").
 		     "\n";
-    die $msg;
+    if ($newst =~ m{^(?:skip)$}) {
+	print STDERR $msg;
+	exit 0;
+    } else {
+	die $msg;
+    }
 }
 
 sub complete_testid ($) {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:38:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:38:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239780.415771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIs8-0002h4-23; Mon, 06 Dec 2021 18:37:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239780.415771; Mon, 06 Dec 2021 18:37:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIs7-0002gx-V8; Mon, 06 Dec 2021 18:37:55 +0000
Received: by outflank-mailman (input) for mailman id 239780;
 Mon, 06 Dec 2021 18:37:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs6-0002fi-AC
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:54 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs6-0004PC-9K
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:54 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIs6-0005xb-8K
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:54 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZd-0001ab-Q5; Mon, 06 Dec 2021 18:18:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=31pX3+SfB7iKjeeoteDv87TcVHN7S3/nDg1EO4lRsig=; b=tscEimCN5t0rG7jiUuMk4DAaaL
	zWmvv2Cqt1680aeGETXlqFuoPXL2TUjUAB2+MxSThYPGGp9bmgksVmP+HiAyDtAz/T/9csqik4xr0
	PKOUmLCHU8oyTNospg5m3OgasoTaAWhjTVViUnTPWClKHkrOhUEtJDlZdkJ1coOP8lhQ=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 12/13] ts-memdisk-try-append: Fix for fact that broken() does not return
Date: Mon,  6 Dec 2021 18:18:38 +0000
Message-Id: <20211206181839.23463-13-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 ts-memdisk-try-append | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ts-memdisk-try-append b/ts-memdisk-try-append
index 18c4aaa5c..e34415b05 100755
--- a/ts-memdisk-try-append
+++ b/ts-memdisk-try-append
@@ -38,8 +38,6 @@ arch=`perl -I. -we '
 
         broken("skipping memdisk because firmware is not bios",
 	       "skip");
-	print "SKIP\n" or die $!;
-	exit 0;
     }
 
     print $ho->{Arch} or die $!;
@@ -52,7 +50,7 @@ amd64)
     echo "Arch $arch not supported for memdisk tests"
     exit 0
     ;;
-SKIP)
+'')
     echo "Step skipped."
     exit 0
     ;;
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:38:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:38:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239781.415783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIsC-00031x-C6; Mon, 06 Dec 2021 18:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239781.415783; Mon, 06 Dec 2021 18:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIsC-00031q-7C; Mon, 06 Dec 2021 18:38:00 +0000
Received: by outflank-mailman (input) for mailman id 239781;
 Mon, 06 Dec 2021 18:37:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIsA-00030F-T2
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIsA-0004PO-SK
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:58 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1muIsA-0005yn-RP
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 18:37:58 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1muIZe-0001ab-B9; Mon, 06 Dec 2021 18:18:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=Ezi+pDANaaVnGfDPhbBun2anRmQhQjQ+Vf4Yn52Xjy8=; b=UOSYx1lw+uauCKIitsPDcgQVxF
	dyhTThXCyiS6fSnxuvgFdo1wpeEm6JIHm7T7c6YOjFkmx6NGnzF2dxBdd5YMkpuyflMTxcTsdYRqm
	8JdGIscC4dTyLPuAI8lj7iWhxjiTBaDgYsfTwUSiYXuHMTouaKjlsu0h74BBOK/gY+p8=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 13/13] ts-xen-install: enable timestamp on guests logs
Date: Mon,  6 Dec 2021 18:18:39 +0000
Message-Id: <20211206181839.23463-14-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211206181839.23463-1-iwj@xenproject.org>
References: <20211206181839.23463-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Roger Pau Monne <roger.pau@citrix.com>

Enable the timestamp feature of xenconsoled so guests logs have a time
reference. Can be helpful when debugging boot related slowness.

This requires using the XENCONSOLED_ARGS option and setting both the
log and the timestamp options. Note that setting XENCONSOLED_TRACE
will override any options in XENCONSOLED_ARGS, so they can not be used
in conjunction.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Ian Jackson <iwj@xenproject.org>
---
 ts-xen-install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ts-xen-install b/ts-xen-install
index 47865eb60..bf55d4e5c 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -140,7 +140,7 @@ sub adjustconfig () {
 
     my @commons_config =
         (
-	   "XENCONSOLED_TRACE" => "guest",
+	   "XENCONSOLED_ARGS" => '"--log=guest --timestamp=all"',
 	);
 
     my $xenstored = target_var($ho, 'xenstored');
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 18:38:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 18:38:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239788.415794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIsg-0004HU-Or; Mon, 06 Dec 2021 18:38:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239788.415794; Mon, 06 Dec 2021 18:38:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muIsg-0004HL-Ll; Mon, 06 Dec 2021 18:38:30 +0000
Received: by outflank-mailman (input) for mailman id 239788;
 Mon, 06 Dec 2021 18:38:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muIsf-0004H1-L5; Mon, 06 Dec 2021 18:38:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muIsf-0004QL-Ib; Mon, 06 Dec 2021 18:38:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muIsf-0005vE-BE; Mon, 06 Dec 2021 18:38:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muIsf-0002xd-Ae; Mon, 06 Dec 2021 18:38:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7qqaYaWckHz/XGHzbjlGWX4OQjaa7w/ynLBSy6OSsYs=; b=xKj2Y/OhhxirxcxN+VU8W9wddz
	s2HoBJWaDAMlOkByg/RofzxgVARRBVQBsP1x65vDonRuCj7wFrUwEz/ShxTFooPNi+87aVJXxtaNH
	z+SwY2fFtY7KnnpP3EC+7s8q+aYiWY4imVcGCYk2cFZIuWqSRmUKLpIhLtJWokj6vbb8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167213-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167213: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb
X-Osstest-Versions-That:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 18:38:29 +0000

flight 167213 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167213/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb
baseline version:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01

Last test of basis   167110  2021-12-04 22:19:19 Z    1 days
Testing same since   167213  2021-12-06 14:01:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ea0c08bc77..f0abfb5eca  f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb -> smoke


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 19:31:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 19:31:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239838.415825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muJhe-0004du-5N; Mon, 06 Dec 2021 19:31:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239838.415825; Mon, 06 Dec 2021 19:31:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muJhe-0004dn-2H; Mon, 06 Dec 2021 19:31:10 +0000
Received: by outflank-mailman (input) for mailman id 239838;
 Mon, 06 Dec 2021 19:31:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muJhd-0004dh-2u
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 19:31:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muJhc-0005LF-K5; Mon, 06 Dec 2021 19:31:08 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.26.205]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muJhc-00011X-Dt; Mon, 06 Dec 2021 19:31:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Z0kyI+2+HqZ6AlQwoVkqd9bi4NchKr2lcUo+cH6Q158=; b=ejxsjpL4pM+77PvGFsaO6X2JP2
	XFX3WTHmY6ln3fUoHpAcfr4fiWkjys4x9dmaRhHXGGLXZnEz47xkj0ylnRxnbInXi1BgPMqu7w0TJ
	0Yu2wElLO5tYs7bxgFeoR9SHZaJBVRfU3ysqvShDDj9yBLQ1TNmDe6czNYdBkSXJQ3Rk=;
Message-ID: <4315f3f8-4431-3257-dc95-a3089532237b@xen.org>
Date: Mon, 6 Dec 2021 19:31:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
Cc: Andre Przywara <Andre.Przywara@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>,
 "stefanos@xilinx.com" <stefanos@xilinx.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
 <20211130094950.1bf368d6@donnerap.cambridge.arm.com>
 <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
 <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

On 01/12/2021 08:41, Bertrand Marquis wrote:
> Hi Ayan,
> 
>> On 30 Nov 2021, at 19:13, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
>>
>> Hi Andre,
>>
>> Thanks for your comments. They are useful.
>>
>> On 30/11/2021 09:49, Andre Przywara wrote:
>>> On Mon, 29 Nov 2021 19:16:38 +0000
>>> Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
>>> Hi,
>>>> At the moment, Xen is only handling data abort with valid syndrome (i.e.
>>>> ISV=0). Unfortunately, this doesn't cover all the instructions a domain
>>>> could use to access MMIO regions.
>>>>
>>>> For instance, Xilinx baremetal OS will use:
>>>>
>>>>          volatile u32 *LocalAddr = (volatile u32 *)Addr;
>>>>          *LocalAddr = Value;
>>>>
>>>> This leave the compiler to decide which store instructions to use.
>>> As mentioned in the other email, this is wrong, if this points to MMIO:
>>> don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
>>> an MMIO area, you should not see traps that you cannot handle already.
>>> So I don't think it's a good idea to use that as an example. And since
>>> this patch only seems to address this use case, I would doubt its
>>> usefulness in general.
>> Yes, I should have fixed the comment.
>>
>> Currently, I am testing with baremetal app which uses inline assembly code with post indexing instructions, to access the MMIO.
>>
>> ATM, I am testing with 32 bit MMIO only.
>>
>> On the usefulness, I am kind of torn as it is legitimate for post indexing instructions to be used in an inline-assembly code for accessing MMIO. However, that may not be something commonly seen.
>>
>> @Stefano/Bertrand/Julien/Volodymyr :- As you are the Arm mantainers, can you comment if we should have decoding logic or not ?
> 
> Andre gave you the official statement from Arm and there is nothing more I can say.

I think this would be handy for other hypervisor and OS developper to 
know what they can expect when running in a virtualized environment. So 
would it be possible to update the Arm Arm reflecting this statement?

> I will leave this decision to Stefano and Julien.

I have had a chat on IRC with Stefano about this. I think the main 
sticking point is the Arm Arm doesn't clearly state those instructions 
should not be used by a virtualized OS on MMIO regions.

To me, this topic looks similar to the set/way instruction dilemma. They 
are a pain to virtualize (and the Arm Arm clearly hint it) but we had to 
do it because some OSes relied on them.

I think the main difference is the Arm Arm doesn't hint they should not 
be used (it only says a valid syndrome is not provided) and the 
implementation should hopefully be smaller and self-contained.

So I would be inclined to allow Xen to decode post-indexing instructions 
(pending the review).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239879.415840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSG-0001WW-Vv; Mon, 06 Dec 2021 22:27:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239879.415840; Mon, 06 Dec 2021 22:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSG-0001WP-Sw; Mon, 06 Dec 2021 22:27:28 +0000
Received: by outflank-mailman (input) for mailman id 239879;
 Mon, 06 Dec 2021 22:27:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSF-0001Vt-FB
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:27 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id afc47430-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afc47430-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210147.872865823@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829644;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=TvVbtaLszVomfbTSaDkZ3Si83Q0PTUXmzyd/sxp3aOQ=;
	b=2PszHZiuiUTEj+gbLOwH5J07JyOXMbPmbCF5/f0ECB+TDx6fg7HRqd/7nSafRiLEh/tB2J
	I89obIOz4EfihV8wPu6DVbEqAjw/vu0lG3MVaBJQOCX84dIVCgJcpP/4YaTYj0DWyUOU+p
	QY7yu7nySNOGDJllJoRD8mO5pRKX6dZ+TpEE7VtehF+zj9YNKxWJrbFRJPs4IpnpV7iPLb
	eXidnoRUF/iI20Q4u50DI+RHcaKyBY/xpS4sXM1RqwV+zb/rkRAS11jus+lRlFQbQ+/IC4
	zfPKJkcA3/LscOUNOfG7uESwv6dj4mHkFlfcsQphYvz9RbwoDVZGHnz96iSF7w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829644;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=TvVbtaLszVomfbTSaDkZ3Si83Q0PTUXmzyd/sxp3aOQ=;
	b=dTYY6yq8X+q85zEA0MFqc5lmEol5cxwjMuFVu15JeS/3f+qTFpB+7//Ug3/O6D2uzzNFJo
	H/Ml5sGXok1eYqCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 00/23] genirq/msi, PCI/MSI: Spring cleaning - Part 1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Date: Mon,  6 Dec 2021 23:27:23 +0100 (CET)

VGhlIFtQQ0ldIE1TSSBjb2RlIGhhcyBnYWluZWQgcXVpdGUgc29tZSB3YXJ0cyBvdmVyIHRpbWUu
IEEgcmVjZW50CmRpc2N1c3Npb24gdW5lYXJ0aGVkIGEgc2hvcnRjb21pbmc6IHRoZSBsYWNrIG9m
IHN1cHBvcnQgZm9yIGV4cGFuZGluZwpQQ0kvTVNJLVggdmVjdG9ycyBhZnRlciBpbml0aWFsaXph
dGlvbiBvZiBNU0ktWC4KClBDSS9NU0ktWCBoYXMgbm8gcmVxdWlyZW1lbnQgdG8gc2V0dXAgYWxs
IHZlY3RvcnMgd2hlbiBNU0ktWCBpcyBlbmFibGVkIGluCnRoZSBkZXZpY2UuIFRoZSBub24tdXNl
ZCB2ZWN0b3JzIGhhdmUganVzdCB0byBiZSBtYXNrZWQgaW4gdGhlIHZlY3Rvcgp0YWJsZS4gRm9y
IFBDSS9NU0kgdGhpcyBpcyBub3QgcG9zc2libGUgYmVjYXVzZSB0aGUgbnVtYmVyIG9mIHZlY3Rv
cnMKY2Fubm90IGJlIGNoYW5nZWQgYWZ0ZXIgaW5pdGlhbGl6YXRpb24uCgpUaGUgUENJL01TSSBj
b2RlLCBidXQgYWxzbyB0aGUgY29yZSBNU0kgaXJxIGRvbWFpbiBjb2RlIGFyZSBidWlsdCBhcm91
bmQKdGhlIGFzc3VtcHRpb24gdGhhdCBhbGwgcmVxdWlyZWQgdmVjdG9ycyBhcmUgaW5zdGFsbGVk
IGF0IGluaXRpYWxpemF0aW9uCnRpbWUgYW5kIGZyZWVkIHdoZW4gdGhlIGRldmljZSBpcyBzaHV0
IGRvd24gYnkgdGhlIGRyaXZlci4KClN1cHBvcnRpbmcgZHluYW1pYyBleHBhbnNpb24gYXQgbGVh
c3QgZm9yIE1TSS1YIGlzIGltcG9ydGFudCBmb3IgVkZJTyBzbwp0aGF0IHRoZSBob3N0IHNpZGUg
aW50ZXJydXB0cyBmb3IgcGFzc3Rocm91Z2ggZGV2aWNlcyBjYW4gYmUgaW5zdGFsbGVkIG9uCmRl
bWFuZC4KClRoaXMgaXMgdGhlIGZpcnN0IHBhcnQgb2YgYSBsYXJnZSAodG90YWwgMTAxIHBhdGNo
ZXMpIHNlcmllcyB3aGljaApyZWZhY3RvcnMgdGhlIFtQQ0ldTVNJIGluZnJhc3RydWN0dXJlIHRv
IG1ha2UgcnVudGltZSBleHBhbnNpb24gb2YgTVNJLVgKdmVjdG9ycyBwb3NzaWJsZS4gVGhlIGxh
c3QgcGFydCAoMTAgcGF0Y2hlcykgcHJvdmlkZSB0aGlzIGZ1bmN0aW9uYWxpdHkuCgpUaGUgZmly
c3QgcGFydCBpcyBtb3N0bHkgYSBjbGVhbnVwIHdoaWNoIGNvbnNvbGlkYXRlcyBjb2RlLCBtb3Zl
cyB0aGUgUENJCk1TSSBjb2RlIGludG8gYSBzZXBhcmF0ZSBkaXJlY3RvcnkgYW5kIHNwbGl0cyBp
dCB1cCBpbnRvIHNldmVyYWwgcGFydHMuCgpObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZCBl
eGNlcHQgZm9yIHBhdGNoIDIvTiB3aGljaCBjaGFuZ2VzIHRoZQpiZWhhdmlvdXIgb2YgcGNpX2dl
dF92ZWN0b3IoKS9hZmZpbml0eSgpIHRvIGdldCByaWQgb2YgdGhlIGFzc3VtcHRpb24gdGhhdAp0
aGUgcHJvdmlkZWQgaW5kZXggaXMgdGhlICJpbmRleCIgaW50byB0aGUgZGVzY3JpcHRvciBsaXN0
IGluc3RlYWQgb2YgdXNpbmcKaXQgYXMgdGhlIGFjdHVhbCBNU0lbWF0gaW5kZXggYXMgc2VlbiBi
eSB0aGUgaGFyZHdhcmUuIFRoaXMgd291bGQgYnJlYWsKdXNlcnMgb2Ygc3BhcnNlIGFsbG9jYXRl
ZCBNU0ktWCBlbnRyaWVzLCBidXQgbm9uIG9mIHRoZW0gdXNlIHRoZXNlCmZ1bmN0aW9ucy4KClRo
aXMgc2VyaWVzIGlzIGJhc2VkIG9uIDUuMTYtcmMyIGFuZCBhbHNvIGF2YWlsYWJsZSB2aWEgZ2l0
OgoKICAgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RnbHgv
ZGV2ZWwuZ2l0IG1zaS12Mi1wYXJ0LTEKCkZvciB0aGUgY3VyaW91cyB3aG8gY2FuJ3Qgd2FpdCBm
b3IgdGhlIG5leHQgcGFydCB0byBhcnJpdmUgdGhlIGZ1bGwgc2VyaWVzCmlzIGF2YWlsYWJsZSB2
aWE6CgogICBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdGds
eC9kZXZlbC5naXQgbXNpLXYyLXBhcnQtMwoKVjEgb2YgdGhpcyBzZXJpZXMgY2FuIGJlIGZvdW5k
IGhlcmU6CgogICBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjExMTI2MjIyNzAwLjg2MjQw
Nzk3N0BsaW51dHJvbml4LmRlCgpDaGFuZ2VzIHZlcnN1cyBWMToKCiAgLSBBZGQgbWlzc2luZyBp
bmNsdWRlcyBhbmQgdXNlIGNvcnJlY3QgdmFyaWFibGUgbmFtZSBpbiBsZWdhY3kgY29kZSAtIENl
ZHJpYwoKICAtIE1vdmVkIHRoZSBNU0kgbG9jayBmcm9tIHN0cnVjdCBkZXZpY2UgdG8gc3RydWN0
IHBjaV9kZXYgLSBOZXcgcGF0Y2gKCiAgICBUaGlzIGlzIHJlYWxseSBQQ0kvTVNJIHNwZWNpZmlj
IGFuZCB0aGVyZSBpcyBubyBwb2ludCB0byBoYXZlIGl0CiAgICBpbiBldmVyeSBzdHJ1Y3QgZGV2
aWNlLiBOZWl0aGVyIGRvZXMgaXQgbWFrZSBzZW5zZSB0byBoaWRlIGl0CiAgICBpbiBtc2lfZGV2
aWNlX2RhdGEgYXMgdGhlIFYxIHNlcmllcyBwYXJ0IDIgZGlkLgoKICAtIFBpY2tlZCB1cCBSZXZp
ZXdlZC9UZXN0ZWQvQWNrZWQtYnkgdGFncyBhcyBhcHByb3ByaWF0ZQoKVGhhbmtzLAoKCXRnbHgK
LS0tCiBhcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzR4eC9tc2kuYyAgICAgICAgICAgIHwgIDI4MSAt
LS0tLS0tLS0tLS0KIGIvRG9jdW1lbnRhdGlvbi9kcml2ZXItYXBpL3BjaS9wY2kucnN0ICAgICAg
fCAgICAyIAogYi9hcmNoL21pcHMvcGNpL21zaS1vY3Rlb24uYyAgICAgICAgICAgICAgICB8ICAg
MzIgLQogYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zLzR4eC9NYWtlZmlsZSAgICAgICB8ICAgIDEg
CiBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvY2VsbC9heG9uX21zaS5jICAgIHwgICAgMiAKIGIv
YXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L3BjaS1pb2RhLmMgfCAgICA0IAogYi9hcmNo
L3Bvd2VycGMvcGxhdGZvcm1zL3BzZXJpZXMvbXNpLmMgICAgICB8ICAgIDYgCiBiL2FyY2gvcG93
ZXJwYy9zeXNkZXYvS2NvbmZpZyAgICAgICAgICAgICAgIHwgICAgNiAKIGIvYXJjaC9zMzkwL3Bj
aS9wY2lfaXJxLmMgICAgICAgICAgICAgICAgICAgfCAgICA0IAogYi9hcmNoL3NwYXJjL2tlcm5l
bC9wY2lfbXNpLmMgICAgICAgICAgICAgICB8ICAgIDQgCiBiL2FyY2gveDg2L2h5cGVydi9pcnFk
b21haW4uYyAgICAgICAgICAgICAgIHwgICA1NSAtLQogYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS94
ODZfaW5pdC5oICAgICAgICAgICB8ICAgIDYgCiBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9o
eXBlcnZpc29yLmggICAgIHwgICAgOCAKIGIvYXJjaC94ODYva2VybmVsL2FwaWMvbXNpLmMgICAg
ICAgICAgICAgICAgfCAgICA4IAogYi9hcmNoL3g4Ni9rZXJuZWwveDg2X2luaXQuYyAgICAgICAg
ICAgICAgICB8ICAgMTIgCiBiL2FyY2gveDg2L3BjaS94ZW4uYyAgICAgICAgICAgICAgICAgICAg
ICAgIHwgICAxOSAKIGIvZHJpdmVycy9iYXNlL2NvcmUuYyAgICAgICAgICAgICAgICAgICAgICAg
fCAgICAxIAogYi9kcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12Mm0uYyAgICAgICAgICAgICB8ICAg
IDEgCiBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy1wY2ktbXNpLmMgIHwgICAgMSAK
IGIvZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtbWJpLmMgICAgICAgICAgfCAgICAxIAogYi9k
cml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoMTFrL3BjaS5jICAgICB8ICAgIDIgCiBiL2RyaXZl
cnMvcGNpL01ha2VmaWxlICAgICAgICAgICAgICAgICAgICAgIHwgICAgMyAKIGIvZHJpdmVycy9w
Y2kvbXNpL01ha2VmaWxlICAgICAgICAgICAgICAgICAgfCAgICA3IAogYi9kcml2ZXJzL3BjaS9t
c2kvaXJxZG9tYWluLmMgICAgICAgICAgICAgICB8ICAyNjcgKysrKysrKysrKysKIGIvZHJpdmVy
cy9wY2kvbXNpL2xlZ2FjeS5jICAgICAgICAgICAgICAgICAgfCAgIDc5ICsrKwogYi9kcml2ZXJz
L3BjaS9tc2kvbXNpLmMgICAgICAgICAgICAgICAgICAgICB8ICA2NDcgKysrKy0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLQogYi9kcml2ZXJzL3BjaS9tc2kvbXNpLmggICAgICAgICAgICAgICAgICAg
ICB8ICAgMzkgKwogYi9kcml2ZXJzL3BjaS9tc2kvcGNpZGV2X21zaS5jICAgICAgICAgICAgICB8
ICAgNDMgKwogYi9kcml2ZXJzL3BjaS9wY2ktc3lzZnMuYyAgICAgICAgICAgICAgICAgICB8ICAg
IDcgCiBiL2RyaXZlcnMvcGNpL3Byb2JlLmMgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCAK
IGIvZHJpdmVycy9wY2kveGVuLXBjaWZyb250LmMgICAgICAgICAgICAgICAgfCAgICAyIAogYi9p
bmNsdWRlL2xpbnV4L2RldmljZS5oICAgICAgICAgICAgICAgICAgICB8ICAgIDIgCiBiL2luY2x1
ZGUvbGludXgvbXNpLmggICAgICAgICAgICAgICAgICAgICAgIHwgIDEzNiArKy0tLQogYi9pbmNs
dWRlL2xpbnV4L3BjaS5oICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDIgCiBiL2tlcm5lbC9p
cnEvbXNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA0MSArCiAzNSBmaWxlcyBjaGFu
Z2VkLCA3MDIgaW5zZXJ0aW9ucygrKSwgMTAzMyBkZWxldGlvbnMoLSkKCg==


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239882.415868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSJ-00024J-Tq; Mon, 06 Dec 2021 22:27:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239882.415868; Mon, 06 Dec 2021 22:27:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSJ-00023r-NL; Mon, 06 Dec 2021 22:27:31 +0000
Received: by outflank-mailman (input) for mailman id 239882;
 Mon, 06 Dec 2021 22:27:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSI-0001m5-Eq
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:30 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b2384895-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2384895-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210223.985907940@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829648;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=id3JgIbjZgRZL0ofCnsEvlAPkFN569FAc5JY13SwTCA=;
	b=dtv/3kpiYCPMOT1Cw9v7Go2jJd37JGwlcLZUvP4q4CZcykY4ErTRRN6blBqFVnD+UMlUBq
	IbSPQ6DvtU6NnokqTJsz/cifnF9TB+UGigT98bUbP9QgHqbfvg52eg506MBfCI6r0vmnKg
	MjmihgmNqzycJJpD74maNXj+PIYFNlMBjC2jDqEuC5sJzApTh0mV0k/vM21wv4lw/G5jbY
	c+q6mtr7VmBYGvYZ1YxwZqR2FwhcE+UxV1sory9IQr1hjBCtnqVHcLm1yLHb4mf4LwL7lv
	6hxQ11J1Pdt/jtTptuAe42u7/7PQhmsoi6nY65ueu367lfi5FaYMMDOataiBBg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829648;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=id3JgIbjZgRZL0ofCnsEvlAPkFN569FAc5JY13SwTCA=;
	b=ezCUc6zchqpEga5Qcxe/swEQdw1F2Cr+alSEzDGugyM3PP2DlRV+GaFXioXu01RmdcdePb
	sl3sBReGfGtugoBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 03/23] genirq/msi: Guard sysfs code
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:28 +0100 (CET)

No point in building unused code when CONFIG_SYSFS=n.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |   10 ++++++++++
 kernel/irq/msi.c    |    2 ++
 2 files changed, 12 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -239,9 +239,19 @@ void __pci_write_msi_msg(struct msi_desc
 void pci_msi_mask_irq(struct irq_data *data);
 void pci_msi_unmask_irq(struct irq_data *data);
 
+#ifdef CONFIG_SYSFS
 const struct attribute_group **msi_populate_sysfs(struct device *dev);
 void msi_destroy_sysfs(struct device *dev,
 		       const struct attribute_group **msi_irq_groups);
+#else
+static inline const struct attribute_group **msi_populate_sysfs(struct device *dev)
+{
+	return NULL;
+}
+static inline void msi_destroy_sysfs(struct device *dev, const struct attribute_group **msi_irq_groups)
+{
+}
+#endif
 
 /*
  * The arch hooks to setup up msi irqs. Default functions are implemented
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -72,6 +72,7 @@ void get_cached_msi_msg(unsigned int irq
 }
 EXPORT_SYMBOL_GPL(get_cached_msi_msg);
 
+#ifdef CONFIG_SYSFS
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)
 {
@@ -204,6 +205,7 @@ void msi_destroy_sysfs(struct device *de
 		kfree(msi_irq_groups);
 	}
 }
+#endif
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 static inline void irq_chip_write_msi_msg(struct irq_data *data,



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239881.415862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSJ-00022L-J0; Mon, 06 Dec 2021 22:27:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239881.415862; Mon, 06 Dec 2021 22:27:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSJ-00022A-F9; Mon, 06 Dec 2021 22:27:31 +0000
Received: by outflank-mailman (input) for mailman id 239881;
 Mon, 06 Dec 2021 22:27:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSH-0001Vt-6u
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:29 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1504199-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1504199-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210223.929792157@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wYOapsewmvCjRKNhvhV0vpzUO9z80CJEqQBEg5ZWMSo=;
	b=cLSzakHMaYNtI4aJ6BLkP0Y1ckKByNqQRdbeialjjHb7VsdJKr1LXNnGFwD5jPorL/dB3X
	r8LL7BBEXT9ttMDduYesmAWnKu89MMUh+WbP//3UR9Oqi8u6Ke9f0j6kvDzk55pgKJlLw8
	pXM/pbZ+DKZAxpGnovR5d0BXBdradoJwITrMoZLhwgv5vAP0K0ZMzZys/cJmxk0kAoxLqB
	9HeDnDnYxU3SNfvQbR+KwVpjQ6g9EPn1CLChmqViSe3oPCpxc2+ZyZ9945UmAuQkVFQb/B
	Ms+5OGgiP91cMgej9Fb+5+mTuU/pnBqgmKdO+oCNOau73VDp3kwOD/z+rrVPrQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829647;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wYOapsewmvCjRKNhvhV0vpzUO9z80CJEqQBEg5ZWMSo=;
	b=AC1UyRei3djvmFCd8sCxirgN9BF19ZHUhoSg/ujiTsv7YGfDjxkFl5ncJxZvQt8R7ZWn4X
	QnYXgZVa/LFvUdBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 02/23] PCI/MSI: Fix pci_irq_vector()/pci_irq_get_affinity()
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:26 +0100 (CET)

pci_irq_vector() and pci_irq_get_affinity() use the list position to find the
MSI-X descriptor at a given index. That's correct for the normal case where
the entry number is the same as the list position.

But it's wrong for cases where MSI-X was allocated with an entries array
describing sparse entry numbers into the hardware message descriptor
table. That's inconsistent at best.

Make it always check the entry number because that's what the zero base
index really means. This change won't break existing users which use a
sparse entries array for allocation because these users retrieve the Linux
interrupt number from the entries array after allocation and none of them
uses pci_irq_vector() or pci_irq_get_affinity().

Fixes: aff171641d18 ("PCI: Provide sensible IRQ vector alloc/free routines")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
V2: Fix typo in subject - Jason
---
 drivers/pci/msi.c |   26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1187,19 +1187,24 @@ EXPORT_SYMBOL(pci_free_irq_vectors);
 
 /**
  * pci_irq_vector - return Linux IRQ number of a device vector
- * @dev: PCI device to operate on
- * @nr: device-relative interrupt vector index (0-based).
+ * @dev:	PCI device to operate on
+ * @nr:		Interrupt vector index (0-based)
+ *
+ * @nr has the following meanings depending on the interrupt mode:
+ *   MSI-X:	The index in the MSI-X vector table
+ *   MSI:	The index of the enabled MSI vectors
+ *   INTx:	Must be 0
+ *
+ * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
  */
 int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
 {
 	if (dev->msix_enabled) {
 		struct msi_desc *entry;
-		int i = 0;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (i == nr)
+			if (entry->msi_attrib.entry_nr == nr)
 				return entry->irq;
-			i++;
 		}
 		WARN_ON_ONCE(1);
 		return -EINVAL;
@@ -1223,17 +1228,22 @@ EXPORT_SYMBOL(pci_irq_vector);
  * pci_irq_get_affinity - return the affinity of a particular MSI vector
  * @dev:	PCI device to operate on
  * @nr:		device-relative interrupt vector index (0-based).
+ *
+ * @nr has the following meanings depending on the interrupt mode:
+ *   MSI-X:	The index in the MSI-X vector table
+ *   MSI:	The index of the enabled MSI vectors
+ *   INTx:	Must be 0
+ *
+ * Return: A cpumask pointer or NULL if @nr is out of range
  */
 const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
 {
 	if (dev->msix_enabled) {
 		struct msi_desc *entry;
-		int i = 0;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (i == nr)
+			if (entry->msi_attrib.entry_nr == nr)
 				return &entry->affinity->mask;
-			i++;
 		}
 		WARN_ON_ONCE(1);
 		return NULL;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239886.415918 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSR-0003aA-8j; Mon, 06 Dec 2021 22:27:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239886.415918; Mon, 06 Dec 2021 22:27:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSR-0003Zy-3v; Mon, 06 Dec 2021 22:27:39 +0000
Received: by outflank-mailman (input) for mailman id 239886;
 Mon, 06 Dec 2021 22:27:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSQ-0001m5-Ee
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:38 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b7824a62-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7824a62-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.265589103@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829657;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OKsXQmZewVMh9C4veaPA025YU+pW4cMZqzIAn23b/9c=;
	b=vZzNCRO+uOrMt1rLYUlSjWHvY3GnOwXQ/odIk4OnimL55yM4E7H9Z+gKxR4cdWzJuc9jJT
	M0aZip9AGf/BRov7wd4DUsRP6NuHKtBNXayKEfTNAPYWG4mlPDCTJXpLfq+Eq2Q7uel0c0
	GCYlxK1amEskkZn0CPcuIPlwQANt3pdUSVU0mXb6Dh6glegghN2NwscVEl8RJS6xJpYmzr
	0oSjRQ0h7Lm4xi7TTTOAuPFvY1F1jeW22TqUuxURSvBD6YjS5m5HOdgSgSZmuNW7/hljHH
	0p6i/mhLMFw2u59Zr1gi+Goyq9OYh0ugIdb202nzF0CcX0f/aD/i2jlLaPiQJw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829657;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OKsXQmZewVMh9C4veaPA025YU+pW4cMZqzIAn23b/9c=;
	b=M/NxrnxGKVPLqAlsqI5UQ6dl9IZUEhUwGcQJKRyC/Ho89KfJQzOP0MU4EFQc7/B84xAAnW
	7QekxbEDbxz2NvAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 08/23] PCI/sysfs: Use pci_irq_vector()
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:36 +0100 (CET)

instead of fiddling with msi descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/pci-sysfs.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -62,11 +62,8 @@ static ssize_t irq_show(struct device *d
 	 * For MSI, show the first MSI IRQ; for all other cases including
 	 * MSI-X, show the legacy INTx IRQ.
 	 */
-	if (pdev->msi_enabled) {
-		struct msi_desc *desc = first_pci_msi_entry(pdev);
-
-		return sysfs_emit(buf, "%u\n", desc->irq);
-	}
+	if (pdev->msi_enabled)
+		return sysfs_emit(buf, "%u\n", pci_irq_vector(pdev, 0));
 #endif
 
 	return sysfs_emit(buf, "%u\n", pdev->irq);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239892.415974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSZ-0005Ol-Rp; Mon, 06 Dec 2021 22:27:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239892.415974; Mon, 06 Dec 2021 22:27:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSZ-0005M5-Es; Mon, 06 Dec 2021 22:27:47 +0000
Received: by outflank-mailman (input) for mailman id 239892;
 Mon, 06 Dec 2021 22:27:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSX-0001Vt-U0
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:45 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbebaa4c-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbebaa4c-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210224.539281124@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829665;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=fpyg7awX8dijQzBRp+WIS78Jmos3C/8mTMn+TSrhxD8=;
	b=pnGIDteYP84F0igC2k+ACUhibYQ3881OhRiiuaVIOBjTshXhjGeVdgZAA/lcK5sjvLEMoj
	ROvDFYYNJX0JhR2QOKUEjXyWb04lLq7PP9xV81Z0D1FytvGg8OABck9JmC/ylB+YU2AvRJ
	PZVaY5Ia3WuXqX49dyC//GQiLcA+5A6GZy5/1+M3d4XVPgxEHo1T/dGhvFuUZ1a4SJvQjn
	ICbirvZcyT0c9k1KJC4jGdKAhnGZprc4Xqsi6XNBDU2/0hwWf55EV2aY3VwLmgUvxv9n/d
	Nfe/m+FudbplubW4O/Khqp8m6T0J7JnGYcrRL/PejELQssL7PtUMHvHQVkjmhA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829665;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=fpyg7awX8dijQzBRp+WIS78Jmos3C/8mTMn+TSrhxD8=;
	b=RuOHGkoAA1Vj7KuipSnVapOZhwsUvKElxjyliNOso5sc0g+RXjuUG8oJb8SOmIunMIh0Pt
	uWzxF181jxyPh3AQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 13/23] PCI/MSI: Cleanup include zoo
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:44 +0100 (CET)

Get rid of the pile of unneeded includes which accumulated over time.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
V2: Address build fail on powerpc - Cedric
---
 drivers/pci/msi.c |   16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -7,22 +7,14 @@
  * Copyright (C) 2016 Christoph Hellwig.
  */
 
+#include <linux/acpi_iort.h>
 #include <linux/err.h>
-#include <linux/mm.h>
-#include <linux/irq.h>
-#include <linux/interrupt.h>
 #include <linux/export.h>
-#include <linux/ioport.h>
-#include <linux/pci.h>
-#include <linux/proc_fs.h>
-#include <linux/msi.h>
-#include <linux/smp.h>
-#include <linux/errno.h>
-#include <linux/io.h>
-#include <linux/acpi_iort.h>
-#include <linux/slab.h>
+#include <linux/irq.h>
 #include <linux/irqdomain.h>
+#include <linux/msi.h>
 #include <linux/of_irq.h>
+#include <linux/pci.h>
 
 #include "pci.h"
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239890.415953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSX-0004nW-8u; Mon, 06 Dec 2021 22:27:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239890.415953; Mon, 06 Dec 2021 22:27:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSX-0004lH-1l; Mon, 06 Dec 2021 22:27:45 +0000
Received: by outflank-mailman (input) for mailman id 239890;
 Mon, 06 Dec 2021 22:27:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSU-0001m5-L7
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9f97979-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9f97979-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.429625690@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829661;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=0nldqX+BIdCQSZe/qG73eGbIrco+/ubuHfsykwvcOLw=;
	b=hq7ndPqCIkYDSqc3aknpP0229cYCDRhoC9zQSCdYk5vM3i10WTZ7av+6rlEAZ6u05mIkbr
	XQDS6b4vGsXFqVoC8oP4KMoWd1eM06kWded8LIrvh6OjRqXQSape8awI79GsZVK8u9eX85
	aD0FDvGiqwvqK/Cp05pH8gDNLFxywYdDcwRzqFrfA9dJF6ZcS2GW43vxTzQkYENzlCGZky
	BY7obUIDVSkFmUZxkFtoCauQiQu+i1InDE5QQr8JmsWmr3vI1aYNQ3VOuIyKzaHGlqfRLM
	9QjgPuj7fL5uEDouHN+Uw0zGzemm1NJG4B4f588z9m3byoVyCwYZWW8vxb8wOA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829661;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=0nldqX+BIdCQSZe/qG73eGbIrco+/ubuHfsykwvcOLw=;
	b=QKsxVt2/sl1syiew/XZKhTW9zsEcW7PxttjhPWSCOKgIZScBCrlr47vPlSJl0Ltkx0XjvV
	If8/ySJn0kVVjADg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Wei Liu <wei.liu@kernel.org>,
 x86@kernel.org,
 linux-hyperv@vger.kernel.org,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 11/23] x86/hyperv: Refactor hv_msi_domain_free_irqs()
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:41 +0100 (CET)

No point in looking up things over and over. Just look up the associated
irq data and work from there.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
Cc: x86@kernel.org
Cc: linux-hyperv@vger.kernel.org
---
 arch/x86/hyperv/irqdomain.c |   55 +++++++++++++-------------------------------
 1 file changed, 17 insertions(+), 38 deletions(-)

--- a/arch/x86/hyperv/irqdomain.c
+++ b/arch/x86/hyperv/irqdomain.c
@@ -253,64 +253,43 @@ static int hv_unmap_msi_interrupt(struct
 	return hv_unmap_interrupt(hv_build_pci_dev_id(dev).as_uint64, old_entry);
 }
 
-static void hv_teardown_msi_irq_common(struct pci_dev *dev, struct msi_desc *msidesc, int irq)
+static void hv_teardown_msi_irq(struct pci_dev *dev, struct irq_data *irqd)
 {
-	u64 status;
 	struct hv_interrupt_entry old_entry;
-	struct irq_desc *desc;
-	struct irq_data *data;
 	struct msi_msg msg;
+	u64 status;
 
-	desc = irq_to_desc(irq);
-	if (!desc) {
-		pr_debug("%s: no irq desc\n", __func__);
-		return;
-	}
-
-	data = &desc->irq_data;
-	if (!data) {
-		pr_debug("%s: no irq data\n", __func__);
-		return;
-	}
-
-	if (!data->chip_data) {
+	if (!irqd->chip_data) {
 		pr_debug("%s: no chip data\n!", __func__);
 		return;
 	}
 
-	old_entry = *(struct hv_interrupt_entry *)data->chip_data;
+	old_entry = *(struct hv_interrupt_entry *)irqd->chip_data;
 	entry_to_msi_msg(&old_entry, &msg);
 
-	kfree(data->chip_data);
-	data->chip_data = NULL;
+	kfree(irqd->chip_data);
+	irqd->chip_data = NULL;
 
 	status = hv_unmap_msi_interrupt(dev, &old_entry);
 
-	if (status != HV_STATUS_SUCCESS) {
+	if (status != HV_STATUS_SUCCESS)
 		pr_err("%s: hypercall failed, status %lld\n", __func__, status);
-		return;
-	}
 }
 
-static void hv_msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
+static void hv_msi_free_irq(struct irq_domain *domain,
+			    struct msi_domain_info *info, unsigned int virq)
 {
-	int i;
-	struct msi_desc *entry;
-	struct pci_dev *pdev;
+	struct irq_data *irqd = irq_get_irq_data(virq);
+	struct msi_desc *desc;
 
-	if (WARN_ON_ONCE(!dev_is_pci(dev)))
+	if (!irqd)
 		return;
 
-	pdev = to_pci_dev(dev);
+	desc = irq_data_get_msi_desc(irqd);
+	if (!desc || !desc->irq || WARN_ON_ONCE(!dev_is_pci(desc->dev)))
+		return;
 
-	for_each_pci_msi_entry(entry, pdev) {
-		if (entry->irq) {
-			for (i = 0; i < entry->nvec_used; i++) {
-				hv_teardown_msi_irq_common(pdev, entry, entry->irq + i);
-				irq_domain_free_irqs(entry->irq + i, 1);
-			}
-		}
-	}
+	hv_teardown_msi_irq(to_pci_dev(desc->dev), irqd);
 }
 
 /*
@@ -329,7 +308,7 @@ static struct irq_chip hv_pci_msi_contro
 };
 
 static struct msi_domain_ops pci_msi_domain_ops = {
-	.domain_free_irqs	= hv_msi_domain_free_irqs,
+	.msi_free		= hv_msi_free_irq,
 	.msi_prepare		= pci_msi_prepare,
 };
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239880.415852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSI-0001mD-7x; Mon, 06 Dec 2021 22:27:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239880.415852; Mon, 06 Dec 2021 22:27:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSI-0001m6-4A; Mon, 06 Dec 2021 22:27:30 +0000
Received: by outflank-mailman (input) for mailman id 239880;
 Mon, 06 Dec 2021 22:27:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSG-0001Vt-6s
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:28 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b0657015-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0657015-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210223.872249537@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829645;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gqz42Pofka0siw8CcddaQz8SUgWLIxuaB16oER6dwV4=;
	b=pe+GcvL6ODtEZD4skWxk/PvzK4F2OW++iXRqeyGbhc0IlKAUIUscA/0YJ8LK43n/sn9oot
	4a+8++vMkE5sKGwHy/ADtrtQAUoXJY48gJoE/AR9bBgX/KzNPqc/113f8bs1q76ETUz7iH
	eM7jScACOqG3CV6StNnqqhuKbbL/SYxHEzsSSIvdjcOOf1HiAyfStD7FbIzX6vU4tqBGEF
	FhRme1JpynfK8Szyi6xWoQlc7HPLO1yvWoEkbxTTZ2KgqRBsLuUmoOuff/xWezXF1i/sBB
	eXgIQTCvaTyUQLeZ8NwlR8UrvXbQAbU/jOQHxFJiOUeSAc+QA2QUEsqYIB8hLg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829645;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gqz42Pofka0siw8CcddaQz8SUgWLIxuaB16oER6dwV4=;
	b=ZkE5ZE9yfufGy0hPQxtaVpW4nh5o7qTk0egIVSjesPqKuGg4dq5nuUEI42HrRuv5UjaXT9
	yqKgJ4nKA8OI9YDw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 01/23] powerpc/4xx: Remove MSI support which never worked
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:25 +0100 (CET)

This code is broken since day one. ppc4xx_setup_msi_irqs() has the
following gems:

 1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely
    broken:
    
    When the result is greater than or equal 0 (bitmap allocation
    successful) then the loop terminates and the function returns 0
    (success) despite not having installed an interrupt.

    When the result is less than 0 (bitmap allocation fails), it prints an
    error message and continues to "work" with that error code which would
    eventually end up in the MSI message data.

 2) On every invocation the file global pp4xx_msi::msi_virqs bitmap is
    allocated thereby leaking the previous one.

IOW, this has never worked and for more than 10 years nobody cared. Remove
the gunk.

Fixes: 3fb7933850fa ("powerpc/4xx: Adding PCIe MSI support")
Fixes: 247540b03bfc ("powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/platforms/4xx/Makefile |    1 
 arch/powerpc/platforms/4xx/msi.c    |  281 ------------------------------------
 arch/powerpc/sysdev/Kconfig         |    6 
 3 files changed, 288 deletions(-)

--- a/arch/powerpc/platforms/4xx/Makefile
+++ b/arch/powerpc/platforms/4xx/Makefile
@@ -3,6 +3,5 @@ obj-y				+= uic.o machine_check.o
 obj-$(CONFIG_4xx_SOC)		+= soc.o
 obj-$(CONFIG_PCI)		+= pci.o
 obj-$(CONFIG_PPC4xx_HSTA_MSI)	+= hsta_msi.o
-obj-$(CONFIG_PPC4xx_MSI)	+= msi.o
 obj-$(CONFIG_PPC4xx_CPM)	+= cpm.o
 obj-$(CONFIG_PPC4xx_GPIO)	+= gpio.o
--- a/arch/powerpc/platforms/4xx/msi.c
+++ /dev/null
@@ -1,281 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * Adding PCI-E MSI support for PPC4XX SoCs.
- *
- * Copyright (c) 2010, Applied Micro Circuits Corporation
- * Authors:	Tirumala R Marri <tmarri@apm.com>
- *		Feng Kan <fkan@apm.com>
- */
-
-#include <linux/irq.h>
-#include <linux/pci.h>
-#include <linux/msi.h>
-#include <linux/of_platform.h>
-#include <linux/interrupt.h>
-#include <linux/export.h>
-#include <linux/kernel.h>
-#include <asm/prom.h>
-#include <asm/hw_irq.h>
-#include <asm/ppc-pci.h>
-#include <asm/dcr.h>
-#include <asm/dcr-regs.h>
-#include <asm/msi_bitmap.h>
-
-#define PEIH_TERMADH	0x00
-#define PEIH_TERMADL	0x08
-#define PEIH_MSIED	0x10
-#define PEIH_MSIMK	0x18
-#define PEIH_MSIASS	0x20
-#define PEIH_FLUSH0	0x30
-#define PEIH_FLUSH1	0x38
-#define PEIH_CNTRST	0x48
-
-static int msi_irqs;
-
-struct ppc4xx_msi {
-	u32 msi_addr_lo;
-	u32 msi_addr_hi;
-	void __iomem *msi_regs;
-	int *msi_virqs;
-	struct msi_bitmap bitmap;
-	struct device_node *msi_dev;
-};
-
-static struct ppc4xx_msi ppc4xx_msi;
-
-static int ppc4xx_msi_init_allocator(struct platform_device *dev,
-		struct ppc4xx_msi *msi_data)
-{
-	int err;
-
-	err = msi_bitmap_alloc(&msi_data->bitmap, msi_irqs,
-			      dev->dev.of_node);
-	if (err)
-		return err;
-
-	err = msi_bitmap_reserve_dt_hwirqs(&msi_data->bitmap);
-	if (err < 0) {
-		msi_bitmap_free(&msi_data->bitmap);
-		return err;
-	}
-
-	return 0;
-}
-
-static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	int int_no = -ENOMEM;
-	unsigned int virq;
-	struct msi_msg msg;
-	struct msi_desc *entry;
-	struct ppc4xx_msi *msi_data = &ppc4xx_msi;
-
-	dev_dbg(&dev->dev, "PCIE-MSI:%s called. vec %x type %d\n",
-		__func__, nvec, type);
-	if (type == PCI_CAP_ID_MSIX)
-		pr_debug("ppc4xx msi: MSI-X untested, trying anyway.\n");
-
-	msi_data->msi_virqs = kmalloc_array(msi_irqs, sizeof(int), GFP_KERNEL);
-	if (!msi_data->msi_virqs)
-		return -ENOMEM;
-
-	for_each_pci_msi_entry(entry, dev) {
-		int_no = msi_bitmap_alloc_hwirqs(&msi_data->bitmap, 1);
-		if (int_no >= 0)
-			break;
-		if (int_no < 0) {
-			pr_debug("%s: fail allocating msi interrupt\n",
-					__func__);
-		}
-		virq = irq_of_parse_and_map(msi_data->msi_dev, int_no);
-		if (!virq) {
-			dev_err(&dev->dev, "%s: fail mapping irq\n", __func__);
-			msi_bitmap_free_hwirqs(&msi_data->bitmap, int_no, 1);
-			return -ENOSPC;
-		}
-		dev_dbg(&dev->dev, "%s: virq = %d\n", __func__, virq);
-
-		/* Setup msi address space */
-		msg.address_hi = msi_data->msi_addr_hi;
-		msg.address_lo = msi_data->msi_addr_lo;
-
-		irq_set_msi_desc(virq, entry);
-		msg.data = int_no;
-		pci_write_msi_msg(virq, &msg);
-	}
-	return 0;
-}
-
-void ppc4xx_teardown_msi_irqs(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-	struct ppc4xx_msi *msi_data = &ppc4xx_msi;
-	irq_hw_number_t hwirq;
-
-	dev_dbg(&dev->dev, "PCIE-MSI: tearing down msi irqs\n");
-
-	for_each_pci_msi_entry(entry, dev) {
-		if (!entry->irq)
-			continue;
-		hwirq = virq_to_hw(entry->irq);
-		irq_set_msi_desc(entry->irq, NULL);
-		irq_dispose_mapping(entry->irq);
-		msi_bitmap_free_hwirqs(&msi_data->bitmap, hwirq, 1);
-	}
-}
-
-static int ppc4xx_setup_pcieh_hw(struct platform_device *dev,
-				 struct resource res, struct ppc4xx_msi *msi)
-{
-	const u32 *msi_data;
-	const u32 *msi_mask;
-	const u32 *sdr_addr;
-	dma_addr_t msi_phys;
-	void *msi_virt;
-	int err;
-
-	sdr_addr = of_get_property(dev->dev.of_node, "sdr-base", NULL);
-	if (!sdr_addr)
-		return -EINVAL;
-
-	msi_data = of_get_property(dev->dev.of_node, "msi-data", NULL);
-	if (!msi_data)
-		return -EINVAL;
-
-	msi_mask = of_get_property(dev->dev.of_node, "msi-mask", NULL);
-	if (!msi_mask)
-		return -EINVAL;
-
-	msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
-	if (!msi->msi_dev)
-		return -ENODEV;
-
-	msi->msi_regs = of_iomap(msi->msi_dev, 0);
-	if (!msi->msi_regs) {
-		dev_err(&dev->dev, "of_iomap failed\n");
-		err = -ENOMEM;
-		goto node_put;
-	}
-	dev_dbg(&dev->dev, "PCIE-MSI: msi register mapped 0x%x 0x%x\n",
-		(u32) (msi->msi_regs + PEIH_TERMADH), (u32) (msi->msi_regs));
-
-	msi_virt = dma_alloc_coherent(&dev->dev, 64, &msi_phys, GFP_KERNEL);
-	if (!msi_virt) {
-		err = -ENOMEM;
-		goto iounmap;
-	}
-	msi->msi_addr_hi = upper_32_bits(msi_phys);
-	msi->msi_addr_lo = lower_32_bits(msi_phys & 0xffffffff);
-	dev_dbg(&dev->dev, "PCIE-MSI: msi address high 0x%x, low 0x%x\n",
-		msi->msi_addr_hi, msi->msi_addr_lo);
-
-	mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start));	/*HIGH addr */
-	mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start));	/* Low addr */
-
-	/* Progam the Interrupt handler Termination addr registers */
-	out_be32(msi->msi_regs + PEIH_TERMADH, msi->msi_addr_hi);
-	out_be32(msi->msi_regs + PEIH_TERMADL, msi->msi_addr_lo);
-
-	/* Program MSI Expected data and Mask bits */
-	out_be32(msi->msi_regs + PEIH_MSIED, *msi_data);
-	out_be32(msi->msi_regs + PEIH_MSIMK, *msi_mask);
-
-	dma_free_coherent(&dev->dev, 64, msi_virt, msi_phys);
-
-	return 0;
-
-iounmap:
-	iounmap(msi->msi_regs);
-node_put:
-	of_node_put(msi->msi_dev);
-	return err;
-}
-
-static int ppc4xx_of_msi_remove(struct platform_device *dev)
-{
-	struct ppc4xx_msi *msi = dev->dev.platform_data;
-	int i;
-	int virq;
-
-	for (i = 0; i < msi_irqs; i++) {
-		virq = msi->msi_virqs[i];
-		if (virq)
-			irq_dispose_mapping(virq);
-	}
-
-	if (msi->bitmap.bitmap)
-		msi_bitmap_free(&msi->bitmap);
-	iounmap(msi->msi_regs);
-	of_node_put(msi->msi_dev);
-
-	return 0;
-}
-
-static int ppc4xx_msi_probe(struct platform_device *dev)
-{
-	struct ppc4xx_msi *msi;
-	struct resource res;
-	int err = 0;
-	struct pci_controller *phb;
-
-	dev_dbg(&dev->dev, "PCIE-MSI: Setting up MSI support...\n");
-
-	msi = devm_kzalloc(&dev->dev, sizeof(*msi), GFP_KERNEL);
-	if (!msi)
-		return -ENOMEM;
-	dev->dev.platform_data = msi;
-
-	/* Get MSI ranges */
-	err = of_address_to_resource(dev->dev.of_node, 0, &res);
-	if (err) {
-		dev_err(&dev->dev, "%pOF resource error!\n", dev->dev.of_node);
-		return err;
-	}
-
-	msi_irqs = of_irq_count(dev->dev.of_node);
-	if (!msi_irqs)
-		return -ENODEV;
-
-	err = ppc4xx_setup_pcieh_hw(dev, res, msi);
-	if (err)
-		return err;
-
-	err = ppc4xx_msi_init_allocator(dev, msi);
-	if (err) {
-		dev_err(&dev->dev, "Error allocating MSI bitmap\n");
-		goto error_out;
-	}
-	ppc4xx_msi = *msi;
-
-	list_for_each_entry(phb, &hose_list, list_node) {
-		phb->controller_ops.setup_msi_irqs = ppc4xx_setup_msi_irqs;
-		phb->controller_ops.teardown_msi_irqs = ppc4xx_teardown_msi_irqs;
-	}
-	return 0;
-
-error_out:
-	ppc4xx_of_msi_remove(dev);
-	return err;
-}
-static const struct of_device_id ppc4xx_msi_ids[] = {
-	{
-		.compatible = "amcc,ppc4xx-msi",
-	},
-	{}
-};
-static struct platform_driver ppc4xx_msi_driver = {
-	.probe = ppc4xx_msi_probe,
-	.remove = ppc4xx_of_msi_remove,
-	.driver = {
-		   .name = "ppc4xx-msi",
-		   .of_match_table = ppc4xx_msi_ids,
-		   },
-
-};
-
-static __init int ppc4xx_msi_init(void)
-{
-	return platform_driver_register(&ppc4xx_msi_driver);
-}
-
-subsys_initcall(ppc4xx_msi_init);
--- a/arch/powerpc/sysdev/Kconfig
+++ b/arch/powerpc/sysdev/Kconfig
@@ -12,17 +12,11 @@ config PPC4xx_HSTA_MSI
 	depends on PCI_MSI
 	depends on PCI && 4xx
 
-config PPC4xx_MSI
-	bool
-	depends on PCI_MSI
-	depends on PCI && 4xx
-
 config PPC_MSI_BITMAP
 	bool
 	depends on PCI_MSI
 	default y if MPIC
 	default y if FSL_PCI
-	default y if PPC4xx_MSI
 	default y if PPC_POWERNV
 
 source "arch/powerpc/sysdev/xics/Kconfig"



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239885.415907 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSN-00039U-Tg; Mon, 06 Dec 2021 22:27:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239885.415907; Mon, 06 Dec 2021 22:27:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSN-00038R-QD; Mon, 06 Dec 2021 22:27:35 +0000
Received: by outflank-mailman (input) for mailman id 239885;
 Mon, 06 Dec 2021 22:27:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSM-0001m5-M7
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:34 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b52d865d-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b52d865d-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.157070464@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829653;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TDFYojyJUnT1Pr+HD2qBTTTO8BHHsqWcbvlgAiLi1mo=;
	b=faGOpwdXacJz+kDCBSBkEhVaO4tWIE9P4Qj5ETLfpZZFSN40Jc6KRKvtUjKqzbcgr/ztKa
	qbs3AQMJ5YqDzSZ/LBJnHdYuDtL3UTT2HjTS9uDFx0+ryP9JO6T8QJqki3Nd//oVR/X9VW
	e1FjY69NA0GKaGyYgqvsTrBfJX5lElCMCyT9FX6YoUuOuuEqqOc/GLtzdgl3zj7Vtoiv7E
	DlxF1pyTqCvYRbWG64ZI7oDzx/Ar7iOdm474EVal1taH8l1XMh6ZbffomzLXz0G5zILmHX
	sQC0TNZYbr8j+7dwqKqYgzrivx/aEdj/MXodn28TIjm3ZJ1lp6FCpndDXoNOSQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829653;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TDFYojyJUnT1Pr+HD2qBTTTO8BHHsqWcbvlgAiLi1mo=;
	b=KcSH+DBC8ml3AxFwN340Wlqo3YBI/t/phMRlVFFD4wwY62x/NNn0qh9e3mmURC/L3bKGnm
	CtUH2opZXJZR53Dw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 06/23] PCI/MSI: Make pci_msi_domain_write_msg() static
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:33 +0100 (CET)

There is no point to have this function public as it is set by the PCI core
anyway when a PCI/MSI irqdomain is created.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/irqchip/irq-gic-v2m.c            |    1 -
 drivers/irqchip/irq-gic-v3-its-pci-msi.c |    1 -
 drivers/irqchip/irq-gic-v3-mbi.c         |    1 -
 drivers/pci/msi.c                        |    2 +-
 include/linux/msi.h                      |    1 -
 5 files changed, 1 insertion(+), 5 deletions(-)

--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -88,7 +88,6 @@ static struct irq_chip gicv2m_msi_irq_ch
 	.irq_mask		= gicv2m_mask_msi_irq,
 	.irq_unmask		= gicv2m_unmask_msi_irq,
 	.irq_eoi		= irq_chip_eoi_parent,
-	.irq_write_msi_msg	= pci_msi_domain_write_msg,
 };
 
 static struct msi_domain_info gicv2m_msi_domain_info = {
--- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
+++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
@@ -28,7 +28,6 @@ static struct irq_chip its_msi_irq_chip
 	.irq_unmask		= its_unmask_msi_irq,
 	.irq_mask		= its_mask_msi_irq,
 	.irq_eoi		= irq_chip_eoi_parent,
-	.irq_write_msi_msg	= pci_msi_domain_write_msg,
 };
 
 static int its_pci_msi_vec_count(struct pci_dev *pdev, void *data)
--- a/drivers/irqchip/irq-gic-v3-mbi.c
+++ b/drivers/irqchip/irq-gic-v3-mbi.c
@@ -171,7 +171,6 @@ static struct irq_chip mbi_msi_irq_chip
 	.irq_unmask		= mbi_unmask_msi_irq,
 	.irq_eoi		= irq_chip_eoi_parent,
 	.irq_compose_msi_msg	= mbi_compose_msi_msg,
-	.irq_write_msi_msg	= pci_msi_domain_write_msg,
 };
 
 static struct msi_domain_info mbi_msi_domain_info = {
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1281,7 +1281,7 @@ EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdat
  * @irq_data:	Pointer to interrupt data of the MSI interrupt
  * @msg:	Pointer to the message
  */
-void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
+static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
 {
 	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -455,7 +455,6 @@ void *platform_msi_get_host_data(struct
 #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
 
 #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
-void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg);
 struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
 					     struct msi_domain_info *info,
 					     struct irq_domain *parent);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239883.415884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSL-0002WD-5O; Mon, 06 Dec 2021 22:27:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239883.415884; Mon, 06 Dec 2021 22:27:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSL-0002Vy-13; Mon, 06 Dec 2021 22:27:33 +0000
Received: by outflank-mailman (input) for mailman id 239883;
 Mon, 06 Dec 2021 22:27:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSJ-0001Vt-BP
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:31 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b33473c3-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b33473c3-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210224.041777889@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829650;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=tZSxCAPD1C/72AGbeyH6kqtxyoXqz8oMI6L3bIBgwo8=;
	b=VUkO3W8Pm9/sA/VUkP33Z1m5XdVqjjFScjNp9xzbJHH6VrzKV611tW5ns/aEvdBtDB5hhY
	4sUYsRTR30anXGxzbOb0K9PMdNFmLOz3BtlIbLryJFmRON/QnRUAVR/tUTC6oCBXwHrZNU
	z+uQJjknPy98RzoGlyywBCTzDA5LQQ/GGEJBDUQgMdOGLnUvWgS3MwvOzMBbN3MyH24wyE
	wloaWdPwNovCCcXh3rks0tF7L7gx6H5HzNZzGmXGzeG4yaX/ZJz5jQYq+o9N1e9u0u4iqL
	y3XBSQqFZdf+aTZPjClD1dgm+ky3LS8iWYvusLGtZCCQqQWdojsreK8LMBSkSg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829650;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=tZSxCAPD1C/72AGbeyH6kqtxyoXqz8oMI6L3bIBgwo8=;
	b=kAM4q1j8ks4DVQFHaEciD0kyWWmX1az4hnbSd/G606ypPv2fKA8RKlEiRFpQ/EsaY+4iOs
	9cLVCE7hHJDUqHDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 04/23] genirq/msi: Remove unused domain callbacks
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:29 +0100 (CET)

No users and there is no need to grow them.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20211126223824.322987915@linutronix.de
---
 include/linux/msi.h |   11 ++++-------
 kernel/irq/msi.c    |    5 -----
 2 files changed, 4 insertions(+), 12 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -304,7 +304,6 @@ struct msi_domain_info;
  * @msi_free:		Domain specific function to free a MSI interrupts
  * @msi_check:		Callback for verification of the domain/info/dev data
  * @msi_prepare:	Prepare the allocation of the interrupts in the domain
- * @msi_finish:		Optional callback to finalize the allocation
  * @set_desc:		Set the msi descriptor for an interrupt
  * @handle_error:	Optional error handler if the allocation fails
  * @domain_alloc_irqs:	Optional function to override the default allocation
@@ -312,12 +311,11 @@ struct msi_domain_info;
  * @domain_free_irqs:	Optional function to override the default free
  *			function.
  *
- * @get_hwirq, @msi_init and @msi_free are callbacks used by
- * msi_create_irq_domain() and related interfaces
+ * @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
+ * irqdomain.
  *
- * @msi_check, @msi_prepare, @msi_finish, @set_desc and @handle_error
- * are callbacks used by msi_domain_alloc_irqs() and related
- * interfaces which are based on msi_desc.
+ * @msi_check, @msi_prepare, @handle_error and @set_desc are callbacks used by
+ * msi_domain_alloc/free_irqs().
  *
  * @domain_alloc_irqs, @domain_free_irqs can be used to override the
  * default allocation/free functions (__msi_domain_alloc/free_irqs). This
@@ -351,7 +349,6 @@ struct msi_domain_ops {
 	int		(*msi_prepare)(struct irq_domain *domain,
 				       struct device *dev, int nvec,
 				       msi_alloc_info_t *arg);
-	void		(*msi_finish)(msi_alloc_info_t *arg, int retval);
 	void		(*set_desc)(msi_alloc_info_t *arg,
 				    struct msi_desc *desc);
 	int		(*handle_error)(struct irq_domain *domain,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -562,8 +562,6 @@ int __msi_domain_alloc_irqs(struct irq_d
 			ret = -ENOSPC;
 			if (ops->handle_error)
 				ret = ops->handle_error(domain, desc, ret);
-			if (ops->msi_finish)
-				ops->msi_finish(&arg, ret);
 			return ret;
 		}
 
@@ -573,9 +571,6 @@ int __msi_domain_alloc_irqs(struct irq_d
 		}
 	}
 
-	if (ops->msi_finish)
-		ops->msi_finish(&arg, 0);
-
 	can_reserve = msi_check_reservation_mode(domain, info, dev);
 
 	/*



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239884.415896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSM-0002pp-IC; Mon, 06 Dec 2021 22:27:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239884.415896; Mon, 06 Dec 2021 22:27:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSM-0002pf-Bf; Mon, 06 Dec 2021 22:27:34 +0000
Received: by outflank-mailman (input) for mailman id 239884;
 Mon, 06 Dec 2021 22:27:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSK-0001m5-Qf
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:32 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b426d3e1-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b426d3e1-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.103502021@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829652;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=aL/VIL4bKAOk4G3UXRaDbYDCQCUHomOCFOLYCw7n0T4=;
	b=tdR1Yo1b4L979PReLtRwSr9KoFKCjaxkig8tEe2FBIPXHXjOv7Mc2jnpFy5d5ujcRG9zf2
	YANt+QuUbpnUYaWhnBtSHaKqGvAj3EA/vWxXcC93VD/psiez55uaqQuMXahn3k2wcp7TIs
	dzvgsa3MguKW/H/7qISbFdepvIsonMp+pcJQTxLy0Tq8xqNv4AzIHYrBlQjpabukLMoAQH
	+8WoxFZhtgRRZ0BM+5uKEmfxHrc+cg3hLFITAABCGn+9ztS/P7IusvhBD0BzMAiM5V91it
	NZB9Ix02RBqpBYkaQPqR4J0ny70Kpv7PWUnkultE1cGpFyC/CxWO/mhIGaySJg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829652;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=aL/VIL4bKAOk4G3UXRaDbYDCQCUHomOCFOLYCw7n0T4=;
	b=rM6g+Z9DTE4BADbMORMbZP61UuPqp6XkB7syFu8ZEotroMrF5V2TzTS9qjDZR3MfVEmuj2
	pW0Kwnn6e9i/AjBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 05/23] genirq/msi: Fixup includes
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:31 +0100 (CET)

Remove the kobject.h include from msi.h as it's not required and add a
sysfs.h include to the core code instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |    2 +-
 kernel/irq/msi.c    |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -2,7 +2,7 @@
 #ifndef LINUX_MSI_H
 #define LINUX_MSI_H
 
-#include <linux/kobject.h>
+#include <linux/cpumask.h>
 #include <linux/list.h>
 #include <asm/msi.h>
 
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -14,6 +14,7 @@
 #include <linux/irqdomain.h>
 #include <linux/msi.h>
 #include <linux/slab.h>
+#include <linux/sysfs.h>
 #include <linux/pci.h>
 
 #include "internals.h"



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239889.415946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSW-0004Us-7t; Mon, 06 Dec 2021 22:27:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239889.415946; Mon, 06 Dec 2021 22:27:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSV-0004Sh-PU; Mon, 06 Dec 2021 22:27:43 +0000
Received: by outflank-mailman (input) for mailman id 239889;
 Mon, 06 Dec 2021 22:27:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMST-0001m5-Px
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b913e30c-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b913e30c-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.374863119@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829660;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=APl9OfydjYVzHfUnQOfchIEV6DUtk8GhU1Hvwr0OstY=;
	b=I7IEi0L+SYsfDSo0rBNvc9+796I6o3zdq7OVMexIwSv2Qg/J3DuMrDWj56GAT+Boo2zKWY
	lPQQGx0OP1quMSSVvJxiXTlx+59zueB3m2Y7z0K2rTbEjcD9tkSQ2/9I+B6Y8reVL42CWU
	Au5uQgfxXhlm+2eofjibZJKiqvOMki278TivK9YRJHtnAUNk7fahKQ88jOsEMr/wHipLvx
	FuMg528tPJLsVowcM3ZN2yvRCrjL8B6NPpmw8rMH608UNvUP9BORKc7Gy8r7HYEt+qzY68
	lI6++yXHenMateQm1doyun0emYFs4tmAaQe9XsuTWfqONsfoK1YUSMMxUtwbfQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829660;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=APl9OfydjYVzHfUnQOfchIEV6DUtk8GhU1Hvwr0OstY=;
	b=UhyVywDjms11SmgbcvKZOnCjDFxgYP1hpU/2y5e6tHW5XyF3pBnNcKcOFhNI+i78s38+LL
	LrvfY0KURqUsTyBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 10/23] genirq/msi, treewide: Use a named struct for PCI/MSI
 attributes
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:39 +0100 (CET)

The unnamed struct sucks and is in the way of further cleanups. Stick the
PCI related MSI data into a real data structure and cleanup all users.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: sparclinux@vger.kernel.org
Cc: x86@kernel.org
Cc: xen-devel@lists.xenproject.org
Cc: ath11k@lists.infradead.org
---
 arch/powerpc/platforms/cell/axon_msi.c    |    2 
 arch/powerpc/platforms/powernv/pci-ioda.c |    4 -
 arch/powerpc/platforms/pseries/msi.c      |    6 -
 arch/sparc/kernel/pci_msi.c               |    4 -
 arch/x86/kernel/apic/msi.c                |    2 
 arch/x86/pci/xen.c                        |    6 -
 drivers/net/wireless/ath/ath11k/pci.c     |    2 
 drivers/pci/msi.c                         |  116 +++++++++++++++---------------
 drivers/pci/xen-pcifront.c                |    2 
 include/linux/msi.h                       |   84 ++++++++++-----------
 kernel/irq/msi.c                          |    4 -
 11 files changed, 115 insertions(+), 117 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -212,7 +212,7 @@ static int setup_msi_msg_address(struct
 	entry = first_pci_msi_entry(dev);
 
 	for (; dn; dn = of_get_next_parent(dn)) {
-		if (entry->msi_attrib.is_64) {
+		if (entry->pci.msi_attrib.is_64) {
 			prop = of_get_property(dn, "msi-address-64", &len);
 			if (prop)
 				break;
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -2154,10 +2154,10 @@ static void pnv_msi_compose_msg(struct i
 	int rc;
 
 	rc = __pnv_pci_ioda_msi_setup(phb, pdev, d->hwirq,
-				      entry->msi_attrib.is_64, msg);
+				      entry->pci.msi_attrib.is_64, msg);
 	if (rc)
 		dev_err(&pdev->dev, "Failed to setup %s-bit MSI #%ld : %d\n",
-			entry->msi_attrib.is_64 ? "64" : "32", d->hwirq, rc);
+			entry->pci.msi_attrib.is_64 ? "64" : "32", d->hwirq, rc);
 }
 
 /*
--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -332,7 +332,7 @@ static int check_msix_entries(struct pci
 
 	expected = 0;
 	for_each_pci_msi_entry(entry, pdev) {
-		if (entry->msi_attrib.entry_nr != expected) {
+		if (entry->pci.msi_attrib.entry_nr != expected) {
 			pr_debug("rtas_msi: bad MSI-X entries.\n");
 			return -EINVAL;
 		}
@@ -449,7 +449,7 @@ static int pseries_msi_ops_prepare(struc
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
 	struct msi_desc *desc = first_pci_msi_entry(pdev);
-	int type = desc->msi_attrib.is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
+	int type = desc->pci.msi_attrib.is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
 
 	return rtas_prepare_msi_irqs(pdev, nvec, type, arg);
 }
@@ -580,7 +580,7 @@ static int pseries_irq_domain_alloc(stru
 	int hwirq;
 	int i, ret;
 
-	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->msi_attrib.entry_nr);
+	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->pci.msi_attrib.entry_nr);
 	if (hwirq < 0) {
 		dev_err(&pdev->dev, "Failed to query HW IRQ: %d\n", hwirq);
 		return hwirq;
--- a/arch/sparc/kernel/pci_msi.c
+++ b/arch/sparc/kernel/pci_msi.c
@@ -146,13 +146,13 @@ static int sparc64_setup_msi_irq(unsigne
 	msiqid = pick_msiq(pbm);
 
 	err = ops->msi_setup(pbm, msiqid, msi,
-			     (entry->msi_attrib.is_64 ? 1 : 0));
+			     (entry->pci.msi_attrib.is_64 ? 1 : 0));
 	if (err)
 		goto out_msi_free;
 
 	pbm->msi_irq_table[msi - pbm->msi_first] = *irq_p;
 
-	if (entry->msi_attrib.is_64) {
+	if (entry->pci.msi_attrib.is_64) {
 		msg.address_hi = pbm->msi64_start >> 32;
 		msg.address_lo = pbm->msi64_start & 0xffffffff;
 	} else {
--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -163,7 +163,7 @@ int pci_msi_prepare(struct irq_domain *d
 	struct msi_desc *desc = first_pci_msi_entry(pdev);
 
 	init_irq_alloc_info(arg, NULL);
-	if (desc->msi_attrib.is_msix) {
+	if (desc->pci.msi_attrib.is_msix) {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
 	} else {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -306,7 +306,7 @@ static int xen_initdom_setup_msi_irqs(st
 				return -EINVAL;
 
 			map_irq.table_base = pci_resource_start(dev, bir);
-			map_irq.entry_nr = msidesc->msi_attrib.entry_nr;
+			map_irq.entry_nr = msidesc->pci.msi_attrib.entry_nr;
 		}
 
 		ret = -EINVAL;
@@ -398,7 +398,7 @@ static void xen_pv_teardown_msi_irqs(str
 {
 	struct msi_desc *msidesc = first_pci_msi_entry(dev);
 
-	if (msidesc->msi_attrib.is_msix)
+	if (msidesc->pci.msi_attrib.is_msix)
 		xen_pci_frontend_disable_msix(dev);
 	else
 		xen_pci_frontend_disable_msi(dev);
@@ -414,7 +414,7 @@ static int xen_msi_domain_alloc_irqs(str
 	if (WARN_ON_ONCE(!dev_is_pci(dev)))
 		return -EINVAL;
 
-	if (first_msi_entry(dev)->msi_attrib.is_msix)
+	if (first_msi_entry(dev)->pci.msi_attrib.is_msix)
 		type = PCI_CAP_ID_MSIX;
 	else
 		type = PCI_CAP_ID_MSI;
--- a/drivers/net/wireless/ath/ath11k/pci.c
+++ b/drivers/net/wireless/ath/ath11k/pci.c
@@ -911,7 +911,7 @@ static int ath11k_pci_alloc_msi(struct a
 	}
 
 	ab_pci->msi_ep_base_data = msi_desc->msg.data;
-	if (msi_desc->msi_attrib.is_64)
+	if (msi_desc->pci.msi_attrib.is_64)
 		set_bit(ATH11K_PCI_FLAG_IS_MSI_64, &ab_pci->flags);
 
 	ath11k_dbg(ab, ATH11K_DBG_PCI, "msi base data is %d\n", ab_pci->msi_ep_base_data);
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -138,9 +138,9 @@ void __weak arch_restore_msi_irqs(struct
 static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
 {
 	/* Don't shift by >= width of type */
-	if (desc->msi_attrib.multi_cap >= 5)
+	if (desc->pci.msi_attrib.multi_cap >= 5)
 		return 0xffffffff;
-	return (1 << (1 << desc->msi_attrib.multi_cap)) - 1;
+	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
 }
 
 static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
@@ -148,14 +148,14 @@ static noinline void pci_msi_update_mask
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
 	unsigned long flags;
 
-	if (!desc->msi_attrib.can_mask)
+	if (!desc->pci.msi_attrib.can_mask)
 		return;
 
 	raw_spin_lock_irqsave(lock, flags);
-	desc->msi_mask &= ~clear;
-	desc->msi_mask |= set;
-	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->mask_pos,
-			       desc->msi_mask);
+	desc->pci.msi_mask &= ~clear;
+	desc->pci.msi_mask |= set;
+	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->pci.mask_pos,
+			       desc->pci.msi_mask);
 	raw_spin_unlock_irqrestore(lock, flags);
 }
 
@@ -171,7 +171,7 @@ static inline void pci_msi_unmask(struct
 
 static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
 {
-	return desc->mask_base + desc->msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
+	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
 }
 
 /*
@@ -184,27 +184,27 @@ static void pci_msix_write_vector_ctrl(s
 {
 	void __iomem *desc_addr = pci_msix_desc_addr(desc);
 
-	if (desc->msi_attrib.can_mask)
+	if (desc->pci.msi_attrib.can_mask)
 		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }
 
 static inline void pci_msix_mask(struct msi_desc *desc)
 {
-	desc->msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
-	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
+	desc->pci.msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
+	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
 	/* Flush write to device */
-	readl(desc->mask_base);
+	readl(desc->pci.mask_base);
 }
 
 static inline void pci_msix_unmask(struct msi_desc *desc)
 {
-	desc->msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
-	pci_msix_write_vector_ctrl(desc, desc->msix_ctrl);
+	desc->pci.msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
+	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
 }
 
 static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (desc->msi_attrib.is_msix)
+	if (desc->pci.msi_attrib.is_msix)
 		pci_msix_mask(desc);
 	else
 		pci_msi_mask(desc, mask);
@@ -212,7 +212,7 @@ static void __pci_msi_mask_desc(struct m
 
 static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
 {
-	if (desc->msi_attrib.is_msix)
+	if (desc->pci.msi_attrib.is_msix)
 		pci_msix_unmask(desc);
 	else
 		pci_msi_unmask(desc, mask);
@@ -256,10 +256,10 @@ void __pci_read_msi_msg(struct msi_desc
 
 	BUG_ON(dev->current_state != PCI_D0);
 
-	if (entry->msi_attrib.is_msix) {
+	if (entry->pci.msi_attrib.is_msix) {
 		void __iomem *base = pci_msix_desc_addr(entry);
 
-		if (WARN_ON_ONCE(entry->msi_attrib.is_virtual))
+		if (WARN_ON_ONCE(entry->pci.msi_attrib.is_virtual))
 			return;
 
 		msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR);
@@ -271,7 +271,7 @@ void __pci_read_msi_msg(struct msi_desc
 
 		pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
 				      &msg->address_lo);
-		if (entry->msi_attrib.is_64) {
+		if (entry->pci.msi_attrib.is_64) {
 			pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
 					      &msg->address_hi);
 			pci_read_config_word(dev, pos + PCI_MSI_DATA_64, &data);
@@ -289,12 +289,12 @@ void __pci_write_msi_msg(struct msi_desc
 
 	if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
 		/* Don't touch the hardware now */
-	} else if (entry->msi_attrib.is_msix) {
+	} else if (entry->pci.msi_attrib.is_msix) {
 		void __iomem *base = pci_msix_desc_addr(entry);
-		u32 ctrl = entry->msix_ctrl;
+		u32 ctrl = entry->pci.msix_ctrl;
 		bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
 
-		if (entry->msi_attrib.is_virtual)
+		if (entry->pci.msi_attrib.is_virtual)
 			goto skip;
 
 		/*
@@ -323,12 +323,12 @@ void __pci_write_msi_msg(struct msi_desc
 
 		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
 		msgctl &= ~PCI_MSI_FLAGS_QSIZE;
-		msgctl |= entry->msi_attrib.multiple << 4;
+		msgctl |= entry->pci.msi_attrib.multiple << 4;
 		pci_write_config_word(dev, pos + PCI_MSI_FLAGS, msgctl);
 
 		pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
 				       msg->address_lo);
-		if (entry->msi_attrib.is_64) {
+		if (entry->pci.msi_attrib.is_64) {
 			pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
 					       msg->address_hi);
 			pci_write_config_word(dev, pos + PCI_MSI_DATA_64,
@@ -376,9 +376,9 @@ static void free_msi_irqs(struct pci_dev
 	pci_msi_teardown_msi_irqs(dev);
 
 	list_for_each_entry_safe(entry, tmp, msi_list, list) {
-		if (entry->msi_attrib.is_msix) {
+		if (entry->pci.msi_attrib.is_msix) {
 			if (list_is_last(&entry->list, msi_list))
-				iounmap(entry->mask_base);
+				iounmap(entry->pci.mask_base);
 		}
 
 		list_del(&entry->list);
@@ -420,7 +420,7 @@ static void __pci_restore_msi_state(stru
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
 	pci_msi_update_mask(entry, 0, 0);
 	control &= ~PCI_MSI_FLAGS_QSIZE;
-	control |= (entry->msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
+	control |= (entry->pci.msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
 	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
 }
 
@@ -449,7 +449,7 @@ static void __pci_restore_msix_state(str
 
 	arch_restore_msi_irqs(dev);
 	for_each_pci_msi_entry(entry, dev)
-		pci_msix_write_vector_ctrl(entry, entry->msix_ctrl);
+		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }
@@ -481,24 +481,24 @@ msi_setup_entry(struct pci_dev *dev, int
 	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
 		control |= PCI_MSI_FLAGS_MASKBIT;
 
-	entry->msi_attrib.is_msix	= 0;
-	entry->msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
-	entry->msi_attrib.is_virtual    = 0;
-	entry->msi_attrib.entry_nr	= 0;
-	entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+	entry->pci.msi_attrib.is_msix	= 0;
+	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
+	entry->pci.msi_attrib.is_virtual    = 0;
+	entry->pci.msi_attrib.entry_nr	= 0;
+	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
 					  !!(control & PCI_MSI_FLAGS_MASKBIT);
-	entry->msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
-	entry->msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
-	entry->msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
+	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
+	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
+	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
 
 	if (control & PCI_MSI_FLAGS_64BIT)
-		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
+		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
 	else
-		entry->mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
+		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
 
 	/* Save the initial mask status */
-	if (entry->msi_attrib.can_mask)
-		pci_read_config_dword(dev, entry->mask_pos, &entry->msi_mask);
+	if (entry->pci.msi_attrib.can_mask)
+		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
 
 out:
 	kfree(masks);
@@ -630,26 +630,26 @@ static int msix_setup_entries(struct pci
 			goto out;
 		}
 
-		entry->msi_attrib.is_msix	= 1;
-		entry->msi_attrib.is_64		= 1;
+		entry->pci.msi_attrib.is_msix	= 1;
+		entry->pci.msi_attrib.is_64	= 1;
 
 		if (entries)
-			entry->msi_attrib.entry_nr = entries[i].entry;
+			entry->pci.msi_attrib.entry_nr = entries[i].entry;
 		else
-			entry->msi_attrib.entry_nr = i;
+			entry->pci.msi_attrib.entry_nr = i;
 
-		entry->msi_attrib.is_virtual =
-			entry->msi_attrib.entry_nr >= vec_count;
+		entry->pci.msi_attrib.is_virtual =
+			entry->pci.msi_attrib.entry_nr >= vec_count;
 
-		entry->msi_attrib.can_mask	= !pci_msi_ignore_mask &&
-						  !entry->msi_attrib.is_virtual;
+		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+						  !entry->pci.msi_attrib.is_virtual;
 
-		entry->msi_attrib.default_irq	= dev->irq;
-		entry->mask_base		= base;
+		entry->pci.msi_attrib.default_irq	= dev->irq;
+		entry->pci.mask_base			= base;
 
-		if (entry->msi_attrib.can_mask) {
+		if (entry->pci.msi_attrib.can_mask) {
 			addr = pci_msix_desc_addr(entry);
-			entry->msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
+			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 		}
 
 		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
@@ -874,7 +874,7 @@ static void pci_msi_shutdown(struct pci_
 	pci_msi_unmask(desc, msi_multi_mask(desc));
 
 	/* Restore dev->irq to its default pin-assertion IRQ */
-	dev->irq = desc->msi_attrib.default_irq;
+	dev->irq = desc->pci.msi_attrib.default_irq;
 	pcibios_alloc_irq(dev);
 }
 
@@ -1203,7 +1203,7 @@ int pci_irq_vector(struct pci_dev *dev,
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_attrib.entry_nr == nr)
+			if (entry->pci.msi_attrib.entry_nr == nr)
 				return entry->irq;
 		}
 		WARN_ON_ONCE(1);
@@ -1242,7 +1242,7 @@ const struct cpumask *pci_irq_get_affini
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_attrib.entry_nr == nr)
+			if (entry->pci.msi_attrib.entry_nr == nr)
 				return &entry->affinity->mask;
 		}
 		WARN_ON_ONCE(1);
@@ -1295,14 +1295,14 @@ static irq_hw_number_t pci_msi_domain_ca
 {
 	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
 
-	return (irq_hw_number_t)desc->msi_attrib.entry_nr |
+	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
 		pci_dev_id(dev) << 11 |
 		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
 }
 
 static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
 {
-	return !desc->msi_attrib.is_msix && desc->nvec_used > 1;
+	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
 }
 
 /**
@@ -1326,7 +1326,7 @@ int pci_msi_domain_check_cap(struct irq_
 	if (pci_msi_desc_is_multi_msi(desc) &&
 	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
 		return 1;
-	else if (desc->msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
+	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
 		return -ENOTSUPP;
 
 	return 0;
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -263,7 +263,7 @@ static int pci_frontend_enable_msix(stru
 
 	i = 0;
 	for_each_pci_msi_entry(entry, dev) {
-		op.msix_entries[i].entry = entry->msi_attrib.entry_nr;
+		op.msix_entries[i].entry = entry->pci.msi_attrib.entry_nr;
 		/* Vector is useless at this point. */
 		op.msix_entries[i].vector = -1;
 		i++;
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -69,6 +69,42 @@ typedef void (*irq_write_msi_msg_t)(stru
 				    struct msi_msg *msg);
 
 /**
+ * pci_msi_desc - PCI/MSI specific MSI descriptor data
+ *
+ * @msi_mask:	[PCI MSI]   MSI cached mask bits
+ * @msix_ctrl:	[PCI MSI-X] MSI-X cached per vector control bits
+ * @is_msix:	[PCI MSI/X] True if MSI-X
+ * @multiple:	[PCI MSI/X] log2 num of messages allocated
+ * @multi_cap:	[PCI MSI/X] log2 num of messages supported
+ * @can_mask:	[PCI MSI/X] Masking supported?
+ * @is_64:	[PCI MSI/X] Address size: 0=32bit 1=64bit
+ * @entry_nr:	[PCI MSI/X] Entry which is described by this descriptor
+ * @default_irq:[PCI MSI/X] The default pre-assigned non-MSI irq
+ * @mask_pos:	[PCI MSI]   Mask register position
+ * @mask_base:	[PCI MSI-X] Mask register base address
+ */
+struct pci_msi_desc {
+	union {
+		u32 msi_mask;
+		u32 msix_ctrl;
+	};
+	struct {
+		u8	is_msix		: 1;
+		u8	multiple	: 3;
+		u8	multi_cap	: 3;
+		u8	can_mask	: 1;
+		u8	is_64		: 1;
+		u8	is_virtual	: 1;
+		u16	entry_nr;
+		unsigned default_irq;
+	} msi_attrib;
+	union {
+		u8	mask_pos;
+		void __iomem *mask_base;
+	};
+};
+
+/**
  * platform_msi_desc - Platform device specific msi descriptor data
  * @msi_priv_data:	Pointer to platform private data
  * @msi_index:		The index of the MSI descriptor for multi MSI
@@ -107,17 +143,7 @@ struct ti_sci_inta_msi_desc {
  *			address or data changes
  * @write_msi_msg_data:	Data parameter for the callback.
  *
- * @msi_mask:	[PCI MSI]   MSI cached mask bits
- * @msix_ctrl:	[PCI MSI-X] MSI-X cached per vector control bits
- * @is_msix:	[PCI MSI/X] True if MSI-X
- * @multiple:	[PCI MSI/X] log2 num of messages allocated
- * @multi_cap:	[PCI MSI/X] log2 num of messages supported
- * @maskbit:	[PCI MSI/X] Mask-Pending bit supported?
- * @is_64:	[PCI MSI/X] Address size: 0=32bit 1=64bit
- * @entry_nr:	[PCI MSI/X] Entry which is described by this descriptor
- * @default_irq:[PCI MSI/X] The default pre-assigned non-MSI irq
- * @mask_pos:	[PCI MSI]   Mask register position
- * @mask_base:	[PCI MSI-X] Mask register base address
+ * @pci:	[PCI]	    PCI speficic msi descriptor data
  * @platform:	[platform]  Platform device specific msi descriptor data
  * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
  * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
@@ -138,38 +164,10 @@ struct msi_desc {
 	void *write_msi_msg_data;
 
 	union {
-		/* PCI MSI/X specific data */
-		struct {
-			union {
-				u32 msi_mask;
-				u32 msix_ctrl;
-			};
-			struct {
-				u8	is_msix		: 1;
-				u8	multiple	: 3;
-				u8	multi_cap	: 3;
-				u8	can_mask	: 1;
-				u8	is_64		: 1;
-				u8	is_virtual	: 1;
-				u16	entry_nr;
-				unsigned default_irq;
-			} msi_attrib;
-			union {
-				u8	mask_pos;
-				void __iomem *mask_base;
-			};
-		};
-
-		/*
-		 * Non PCI variants add their data structure here. New
-		 * entries need to use a named structure. We want
-		 * proper name spaces for this. The PCI part is
-		 * anonymous for now as it would require an immediate
-		 * tree wide cleanup.
-		 */
-		struct platform_msi_desc platform;
-		struct fsl_mc_msi_desc fsl_mc;
-		struct ti_sci_inta_msi_desc inta;
+		struct pci_msi_desc		pci;
+		struct platform_msi_desc	platform;
+		struct fsl_mc_msi_desc		fsl_mc;
+		struct ti_sci_inta_msi_desc	inta;
 	};
 };
 
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -91,7 +91,7 @@ static ssize_t msi_mode_show(struct devi
 		return -ENODEV;
 
 	if (dev_is_pci(dev))
-		is_msix = entry->msi_attrib.is_msix;
+		is_msix = entry->pci.msi_attrib.is_msix;
 
 	return sysfs_emit(buf, "%s\n", is_msix ? "msix" : "msi");
 }
@@ -535,7 +535,7 @@ static bool msi_check_reservation_mode(s
 	 * masking and MSI does so when the can_mask attribute is set.
 	 */
 	desc = first_msi_entry(dev);
-	return desc->msi_attrib.is_msix || desc->msi_attrib.can_mask;
+	return desc->pci.msi_attrib.is_msix || desc->pci.msi_attrib.can_mask;
 }
 
 int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239893.415992 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSc-0006I4-Uk; Mon, 06 Dec 2021 22:27:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239893.415992; Mon, 06 Dec 2021 22:27:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSc-0006DR-EH; Mon, 06 Dec 2021 22:27:50 +0000
Received: by outflank-mailman (input) for mailman id 239893;
 Mon, 06 Dec 2021 22:27:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSZ-0001Vt-MY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:47 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bcfaf114-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bcfaf114-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210224.600351129@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829666;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=C4aqXfAyJVKaI/8MMq5VzC8OB/kEeYXdYvUuhO7tMOc=;
	b=o92QiOvGzQZzHfMpzPjv7r4xBNXDoXGJJvsICsdexRSxr3AhYBn+Fzw5huMDLf3tG2MlDP
	WPSsWv+ttwoXNCO+kVRoYtBXd2056cZn+SXvjveHEIGW4wLgMSNBAD+EM1KCcz3isX+VnT
	7oA+S94AQMnlPWXc6OAJe8Vh+beStrB/fVp0eysUbozportvEaGqCfzk+tSiRYaAb9ydmC
	tUqitzzV2rJq9he1vqAIx8of13iw8IY3uTwV+VW+qoDZuhKvoTgvmfg6uyCTUe4lGxMUHD
	D8um59x3FnVAH2aKssNe992rOhVmHhCOdInM7HatkhXksCk91x8Z5YuFrRqVxQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829666;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=C4aqXfAyJVKaI/8MMq5VzC8OB/kEeYXdYvUuhO7tMOc=;
	b=1tAEn67IPG8WXGNZydrODGd+7PMJ5gxXdDqFiaHVsGUGG9TZGgvwu2VK3mH3VYJ+XD3fmr
	KDMRzr5BxWyF64CA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 14/23] PCI/MSI: Make msix_update_entries() smarter
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:46 +0100 (CET)

No need to walk the descriptors and check for each one whether the entries
pointer function argument is NULL. Do it once.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -642,8 +642,8 @@ static void msix_update_entries(struct p
 {
 	struct msi_desc *entry;
 
-	for_each_pci_msi_entry(entry, dev) {
-		if (entries) {
+	if (entries) {
+		for_each_pci_msi_entry(entry, dev) {
 			entries->vector = entry->irq;
 			entries++;
 		}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239891.415966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSY-0005C2-RS; Mon, 06 Dec 2021 22:27:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239891.415966; Mon, 06 Dec 2021 22:27:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSY-0005B4-If; Mon, 06 Dec 2021 22:27:46 +0000
Received: by outflank-mailman (input) for mailman id 239891;
 Mon, 06 Dec 2021 22:27:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSW-0001Vt-MT
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:44 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb039c47-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb039c47-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210224.485668098@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829663;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=72+QGnlfGFYAah1BUmp4cO4oz9eONu1lmUkDHP/6Oes=;
	b=MTZjX5pNCpaLIFSorwc1uUDuJV8DuheJ4/PGRwS1V0RSzJLru3QK+UoDdKktWtJ56DE+pU
	XMpfnvWnX2DR2KWbp528BWcbOq9/jHSo0OnwKIJ8pTjKPXuby1tve6XYSQnjznzx4p1fBU
	w9WdmdFGIspyqZDGRSwYdx6WrLg3PlS+GMjjb4rlRHfSZXzCU3kz76eVMP7TXFSr/bxAqB
	hknvBA5hjCwrysbiAFo8k4a+IMj8BlgkaRUzgsM4eFkl42Z3vu1UzIfASxszOhpin7rnmz
	04sigZF0h+k3QB7F9/sJJGfxNvzCN++bfCAbCCj0/SAXu469vIUDg9AhAd93Ag==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829663;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=72+QGnlfGFYAah1BUmp4cO4oz9eONu1lmUkDHP/6Oes=;
	b=TNvJwf8MfIZ37eFOPxUxrqpZTcApvnb0v/Ziy52Uyn6Q/lFKZMvbhi8K0X/S9Y8AgRN6JC
	cp1HJaq7RkboAqDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org
Subject: [patch V2 12/23] PCI/MSI: Make arch_restore_msi_irqs() less horrible.
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:42 +0100 (CET)

Make arch_restore_msi_irqs() return a boolean which indicates whether the
core code should restore the MSI message or not. Get rid of the indirection
in x86.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: x86@kernel.org
Cc: xen-devel@lists.xenproject.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
---
 arch/s390/pci/pci_irq.c               |    4 +-
 arch/x86/include/asm/x86_init.h       |    6 ---
 arch/x86/include/asm/xen/hypervisor.h |    8 +++++
 arch/x86/kernel/apic/msi.c            |    6 +++
 arch/x86/kernel/x86_init.c            |   12 -------
 arch/x86/pci/xen.c                    |   13 ++++----
 drivers/pci/msi.c                     |   54 +++++++++++-----------------------
 include/linux/msi.h                   |    7 +---
 8 files changed, 45 insertions(+), 65 deletions(-)

--- a/arch/s390/pci/pci_irq.c
+++ b/arch/s390/pci/pci_irq.c
@@ -387,13 +387,13 @@ void arch_teardown_msi_irqs(struct pci_d
 		airq_iv_free(zpci_ibv[0], zdev->msi_first_bit, zdev->msi_nr_irqs);
 }
 
-void arch_restore_msi_irqs(struct pci_dev *pdev)
+bool arch_restore_msi_irqs(struct pci_dev *pdev)
 {
 	struct zpci_dev *zdev = to_zpci(pdev);
 
 	if (!zdev->irqs_registered)
 		zpci_set_irq(zdev);
-	default_restore_msi_irqs(pdev);
+	return true;
 }
 
 static struct airq_struct zpci_airq = {
--- a/arch/x86/include/asm/x86_init.h
+++ b/arch/x86/include/asm/x86_init.h
@@ -289,12 +289,6 @@ struct x86_platform_ops {
 	struct x86_hyper_runtime hyper;
 };
 
-struct pci_dev;
-
-struct x86_msi_ops {
-	void (*restore_msi_irqs)(struct pci_dev *dev);
-};
-
 struct x86_apic_ops {
 	unsigned int	(*io_apic_read)   (unsigned int apic, unsigned int reg);
 	void		(*restore)(void);
--- a/arch/x86/include/asm/xen/hypervisor.h
+++ b/arch/x86/include/asm/xen/hypervisor.h
@@ -57,6 +57,14 @@ static inline bool __init xen_x2apic_par
 }
 #endif
 
+struct pci_dev;
+
+#ifdef CONFIG_XEN_DOM0
+bool xen_initdom_restore_msi(struct pci_dev *dev);
+#else
+static inline bool xen_initdom_restore_msi(struct pci_dev *dev) { return true; }
+#endif
+
 #ifdef CONFIG_HOTPLUG_CPU
 void xen_arch_register_cpu(int num);
 void xen_arch_unregister_cpu(int num);
--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -19,6 +19,7 @@
 #include <asm/hw_irq.h>
 #include <asm/apic.h>
 #include <asm/irq_remapping.h>
+#include <asm/xen/hypervisor.h>
 
 struct irq_domain *x86_pci_msi_default_domain __ro_after_init;
 
@@ -345,3 +346,8 @@ void dmar_free_hwirq(int irq)
 	irq_domain_free_irqs(irq, 1);
 }
 #endif
+
+bool arch_restore_msi_irqs(struct pci_dev *dev)
+{
+	return xen_initdom_restore_msi(dev);
+}
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -145,18 +145,6 @@ struct x86_platform_ops x86_platform __r
 
 EXPORT_SYMBOL_GPL(x86_platform);
 
-#if defined(CONFIG_PCI_MSI)
-struct x86_msi_ops x86_msi __ro_after_init = {
-	.restore_msi_irqs	= default_restore_msi_irqs,
-};
-
-/* MSI arch specific hooks */
-void arch_restore_msi_irqs(struct pci_dev *dev)
-{
-	x86_msi.restore_msi_irqs(dev);
-}
-#endif
-
 struct x86_apic_ops x86_apic_ops __ro_after_init = {
 	.io_apic_read	= native_io_apic_read,
 	.restore	= native_restore_boot_irq_mode,
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -351,10 +351,13 @@ static int xen_initdom_setup_msi_irqs(st
 	return ret;
 }
 
-static void xen_initdom_restore_msi_irqs(struct pci_dev *dev)
+bool xen_initdom_restore_msi(struct pci_dev *dev)
 {
 	int ret = 0;
 
+	if (!xen_initial_domain())
+		return true;
+
 	if (pci_seg_supported) {
 		struct physdev_pci_device restore_ext;
 
@@ -375,10 +378,10 @@ static void xen_initdom_restore_msi_irqs
 		ret = HYPERVISOR_physdev_op(PHYSDEVOP_restore_msi, &restore);
 		WARN(ret && ret != -ENOSYS, "restore_msi -> %d\n", ret);
 	}
+	return false;
 }
 #else /* CONFIG_XEN_PV_DOM0 */
 #define xen_initdom_setup_msi_irqs	NULL
-#define xen_initdom_restore_msi_irqs	NULL
 #endif /* !CONFIG_XEN_PV_DOM0 */
 
 static void xen_teardown_msi_irqs(struct pci_dev *dev)
@@ -466,12 +469,10 @@ static __init struct irq_domain *xen_cre
 static __init void xen_setup_pci_msi(void)
 {
 	if (xen_pv_domain()) {
-		if (xen_initial_domain()) {
+		if (xen_initial_domain())
 			xen_msi_ops.setup_msi_irqs = xen_initdom_setup_msi_irqs;
-			x86_msi.restore_msi_irqs = xen_initdom_restore_msi_irqs;
-		} else {
+		else
 			xen_msi_ops.setup_msi_irqs = xen_setup_msi_irqs;
-		}
 		xen_msi_ops.teardown_msi_irqs = xen_pv_teardown_msi_irqs;
 		pci_msi_ignore_mask = 1;
 	} else if (xen_hvm_domain()) {
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -106,29 +106,6 @@ void __weak arch_teardown_msi_irqs(struc
 }
 #endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
 
-static void default_restore_msi_irq(struct pci_dev *dev, int irq)
-{
-	struct msi_desc *entry;
-
-	entry = NULL;
-	if (dev->msix_enabled) {
-		for_each_pci_msi_entry(entry, dev) {
-			if (irq == entry->irq)
-				break;
-		}
-	} else if (dev->msi_enabled)  {
-		entry = irq_get_msi_desc(irq);
-	}
-
-	if (entry)
-		__pci_write_msi_msg(entry, &entry->msg);
-}
-
-void __weak arch_restore_msi_irqs(struct pci_dev *dev)
-{
-	return default_restore_msi_irqs(dev);
-}
-
 /*
  * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
  * mask all MSI interrupts by clearing the MSI enable bit does not work
@@ -242,14 +219,6 @@ void pci_msi_unmask_irq(struct irq_data
 }
 EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
 
-void default_restore_msi_irqs(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-
-	for_each_pci_msi_entry(entry, dev)
-		default_restore_msi_irq(dev, entry->irq);
-}
-
 void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
 {
 	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
@@ -403,10 +372,19 @@ static void pci_msi_set_enable(struct pc
 	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
 }
 
+/*
+ * Architecture override returns true when the PCI MSI message should be
+ * written by the generic restore function.
+ */
+bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
+{
+	return true;
+}
+
 static void __pci_restore_msi_state(struct pci_dev *dev)
 {
-	u16 control;
 	struct msi_desc *entry;
+	u16 control;
 
 	if (!dev->msi_enabled)
 		return;
@@ -415,7 +393,8 @@ static void __pci_restore_msi_state(stru
 
 	pci_intx_for_msi(dev, 0);
 	pci_msi_set_enable(dev, 0);
-	arch_restore_msi_irqs(dev);
+	if (arch_restore_msi_irqs(dev))
+		__pci_write_msi_msg(entry, &entry->msg);
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
 	pci_msi_update_mask(entry, 0, 0);
@@ -437,6 +416,7 @@ static void pci_msix_clear_and_set_ctrl(
 static void __pci_restore_msix_state(struct pci_dev *dev)
 {
 	struct msi_desc *entry;
+	bool write_msg;
 
 	if (!dev->msix_enabled)
 		return;
@@ -447,9 +427,13 @@ static void __pci_restore_msix_state(str
 	pci_msix_clear_and_set_ctrl(dev, 0,
 				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
 
-	arch_restore_msi_irqs(dev);
-	for_each_pci_msi_entry(entry, dev)
+	write_msg = arch_restore_msi_irqs(dev);
+
+	for_each_pci_msi_entry(entry, dev) {
+		if (write_msg)
+			__pci_write_msi_msg(entry, &entry->msg);
 		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
+	}
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -273,11 +273,10 @@ static inline void arch_teardown_msi_irq
 #endif
 
 /*
- * The restore hooks are still available as they are useful even
- * for fully irq domain based setups. Courtesy to XEN/X86.
+ * The restore hook is still available even for fully irq domain based
+ * setups. Courtesy to XEN/X86.
  */
-void arch_restore_msi_irqs(struct pci_dev *dev);
-void default_restore_msi_irqs(struct pci_dev *dev);
+bool arch_restore_msi_irqs(struct pci_dev *dev);
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239895.416004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSf-00071j-KB; Mon, 06 Dec 2021 22:27:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239895.416004; Mon, 06 Dec 2021 22:27:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSf-0006we-5n; Mon, 06 Dec 2021 22:27:53 +0000
Received: by outflank-mailman (input) for mailman id 239895;
 Mon, 06 Dec 2021 22:27:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSd-0001m5-3J
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:51 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bef6d2c1-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bef6d2c1-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.710137730@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829670;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ib3yuqujnroRqi+hLldSTb0C/KdcxiKhDFhBeAeajh8=;
	b=YKghtY03bcoLP8OvEUv6g9Jjx1TFo+pzmg+zViZrV9C1Zqdyd+udciNW1BVKPTuIL8Z+sh
	VkfSoebHJBGRLhECku0Xcu/1wA6jahAvvipQ9NOJi7sfSqnslLIaiWdUsi6UumMv8Ii0JT
	2DbzczPuytoquIUE4qI7a+Rs+3SZz2k8vJC78RhGv6O3a0yi2pFj1Gt6yYNlPg+9HE8EhD
	OMVLu3Q5kecJhaNaLyTGpaijaksYWeRdazPJXewvgHnUCQUGdmFPOc2DkNnsaNSCejEPc7
	IQlwWECz6/FR1cQY3Dggy4ASx4++0pFep56S/3oZez+mph5GyIICQFrfOQSrhQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829670;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ib3yuqujnroRqi+hLldSTb0C/KdcxiKhDFhBeAeajh8=;
	b=A1eH8lsrzvvUb+UOPZHwegNVeviEvBxF3n2PgKLDm1Kz3CElL95PW6TVkRlKmYp31F7use
	sr1vtn736Uy7EoCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 16/23] PCI/MSI: Split out CONFIG_PCI_MSI independent part
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:49 +0100 (CET)

These functions are required even when CONFIG_PCI_MSI is not set. Move them
to their own file.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/Makefile     |    3 ++-
 drivers/pci/msi/msi.c        |   39 ---------------------------------------
 drivers/pci/msi/pcidev_msi.c |   43 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 45 insertions(+), 40 deletions(-)

--- a/drivers/pci/msi/Makefile
+++ b/drivers/pci/msi/Makefile
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
 #
 # Makefile for the PCI/MSI
-obj-$(CONFIG_PCI)		+= msi.o
+obj-$(CONFIG_PCI)		+= pcidev_msi.o
+obj-$(CONFIG_PCI_MSI)		+= msi.o
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -18,8 +18,6 @@
 
 #include "../pci.h"
 
-#ifdef CONFIG_PCI_MSI
-
 static int pci_msi_enable = 1;
 int pci_msi_ignore_mask;
 
@@ -1493,40 +1491,3 @@ bool pci_dev_has_special_msi_domain(stru
 }
 
 #endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
-#endif /* CONFIG_PCI_MSI */
-
-void pci_msi_init(struct pci_dev *dev)
-{
-	u16 ctrl;
-
-	/*
-	 * Disable the MSI hardware to avoid screaming interrupts
-	 * during boot.  This is the power on reset default so
-	 * usually this should be a noop.
-	 */
-	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
-	if (!dev->msi_cap)
-		return;
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
-	if (ctrl & PCI_MSI_FLAGS_ENABLE)
-		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
-				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
-
-	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
-		dev->no_64bit_msi = 1;
-}
-
-void pci_msix_init(struct pci_dev *dev)
-{
-	u16 ctrl;
-
-	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
-	if (!dev->msix_cap)
-		return;
-
-	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
-	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
-		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
-				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
-}
--- /dev/null
+++ b/drivers/pci/msi/pcidev_msi.c
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * MSI[X} related functions which are available unconditionally.
+ */
+#include "../pci.h"
+
+/*
+ * Disable the MSI[X] hardware to avoid screaming interrupts during boot.
+ * This is the power on reset default so usually this should be a noop.
+ */
+
+void pci_msi_init(struct pci_dev *dev)
+{
+	u16 ctrl;
+
+	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
+	if (!dev->msi_cap)
+		return;
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
+	if (ctrl & PCI_MSI_FLAGS_ENABLE) {
+		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
+				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
+	}
+
+	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
+		dev->no_64bit_msi = 1;
+}
+
+void pci_msix_init(struct pci_dev *dev)
+{
+	u16 ctrl;
+
+	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+	if (!dev->msix_cap)
+		return;
+
+	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
+	if (ctrl & PCI_MSIX_FLAGS_ENABLE) {
+		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
+				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
+	}
+}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239887.415929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMST-000406-P2; Mon, 06 Dec 2021 22:27:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239887.415929; Mon, 06 Dec 2021 22:27:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMST-0003zf-Kh; Mon, 06 Dec 2021 22:27:41 +0000
Received: by outflank-mailman (input) for mailman id 239887;
 Mon, 06 Dec 2021 22:27:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSR-0001m5-Ez
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:39 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b621d662-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b621d662-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.210768199@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829655;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BDAIfQQJ/HYBQlNRSL+3v2qiAdmkDsDIsSFt3VNvN68=;
	b=GUOH6mWh41yMRUMKAp98aOVCT8hYo1MhFqsH8cMnArd7Joaq5tWDId+1tzWGfmFp4MhkDK
	fHIyaV3g98EAAJDH4thajAxgYu0m3cKfigGCoPT2xKRUJOay1yoB6gVJaZ4KQr73+lJIhF
	217Vew7bGgy7Rg6jJWbryS3guIp3T2avsXNZqL5l2fzu6eAEZf94hGHdwrc0sDuVqRRr8F
	YOFSttwR9zQl+lUR33+FUHV/lA4yrN4ussU95RvZHyirqbrl8Swdecf1BIQxTJKV9akSLD
	72+bCTmvb3yxzwtxXQKS+Dp9IUTPEzYeXHcPBKvJp67pMRTXdzTjCaz75gvKWw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829655;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BDAIfQQJ/HYBQlNRSL+3v2qiAdmkDsDIsSFt3VNvN68=;
	b=HGDrJvU5isVeAMd5DGIpUPfL17YjFqAjIDf/BKb6AVkDejEhNeX5X92R0PYs3gYuQD20lS
	ukq3hUeso9wqpYBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 07/23] PCI/MSI: Remove msi_desc_to_pci_sysdata()
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:34 +0100 (CET)

Last user is gone long ago.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi.c   |    8 --------
 include/linux/msi.h |    5 -----
 2 files changed, 13 deletions(-)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1267,14 +1267,6 @@ struct pci_dev *msi_desc_to_pci_dev(stru
 }
 EXPORT_SYMBOL(msi_desc_to_pci_dev);
 
-void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
-{
-	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
-
-	return dev->bus->sysdata;
-}
-EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdata);
-
 #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
 /**
  * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -218,13 +218,8 @@ static inline void msi_desc_set_iommu_co
 	for_each_msi_entry((desc), &(pdev)->dev)
 
 struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc);
-void *msi_desc_to_pci_sysdata(struct msi_desc *desc);
 void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg);
 #else /* CONFIG_PCI_MSI */
-static inline void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
-{
-	return NULL;
-}
 static inline void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
 {
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:27:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:27:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239888.415934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSU-00043p-Gh; Mon, 06 Dec 2021 22:27:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239888.415934; Mon, 06 Dec 2021 22:27:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMSU-00042z-2I; Mon, 06 Dec 2021 22:27:42 +0000
Received: by outflank-mailman (input) for mailman id 239888;
 Mon, 06 Dec 2021 22:27:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSS-0001m5-FI
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:40 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b82347d2-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b82347d2-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.319201379@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829658;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gOhEwOl7pWXAdyfdjPv/xL32Zd5rtVvQRFE5wZzX1CM=;
	b=dvaOjaxxL6xiDQA7FFy4cxQQ/uHU9sUdt6e/yyFwN1tu+bJ1yi46Si+LsK8MUpqWL66GBZ
	2vYuDYX1gMzlWrQlXSNF7Gy5YE1JoRbELnLUr87259Kjgtgb01AkT3/PzG4pDRcVNe6nnu
	ivxMXrLRTAd3saTznKV7mbiAHy2Rtw3hMMQvRO+thrnTc3FA0K+E4ppbPA/2gfw4NYQ+xk
	oJH8E0LDjQDUOmg7euoxTjnOnIPyEBUSb+AO4mByR8WoxcxvvNGBpWjsmNaE7QFybpIRFg
	x8MhqCDCTsZoEj80vUenfUClW3vGGZTwtNcCQ4Iw5T8t8x7oh0OUHc455oO1Ww==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829658;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gOhEwOl7pWXAdyfdjPv/xL32Zd5rtVvQRFE5wZzX1CM=;
	b=jqiplyDoFdSA46RvOetOaqUacacbKtOW+CT5oA5zeEczBM+vXFTNHE6+JVcjlrsieqeQMT
	qjTsGymloYl2PTAw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 09/23] MIPS: Octeon: Use arch_setup_msi_irq()
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:38 +0100 (CET)

The core code provides the same loop code except for the MSI-X reject. Move
that to arch_setup_msi_irq() and remove the duplicated code.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
---
 arch/mips/pci/msi-octeon.c |   32 +++-----------------------------
 1 file changed, 3 insertions(+), 29 deletions(-)

--- a/arch/mips/pci/msi-octeon.c
+++ b/arch/mips/pci/msi-octeon.c
@@ -68,6 +68,9 @@ int arch_setup_msi_irq(struct pci_dev *d
 	u64 search_mask;
 	int index;
 
+	if (desc->pci.msi_attrib.is_msix)
+		return -EINVAL;
+
 	/*
 	 * Read the MSI config to figure out how many IRQs this device
 	 * wants.  Most devices only want 1, which will give
@@ -182,35 +185,6 @@ int arch_setup_msi_irq(struct pci_dev *d
 	return 0;
 }
 
-int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	struct msi_desc *entry;
-	int ret;
-
-	/*
-	 * MSI-X is not supported.
-	 */
-	if (type == PCI_CAP_ID_MSIX)
-		return -EINVAL;
-
-	/*
-	 * If an architecture wants to support multiple MSI, it needs to
-	 * override arch_setup_msi_irqs()
-	 */
-	if (type == PCI_CAP_ID_MSI && nvec > 1)
-		return 1;
-
-	for_each_pci_msi_entry(entry, dev) {
-		ret = arch_setup_msi_irq(dev, entry);
-		if (ret < 0)
-			return ret;
-		if (ret > 0)
-			return -ENOSPC;
-	}
-
-	return 0;
-}
-
 /**
  * Called when a device no longer needs its MSI interrupts. All
  * MSI interrupts for the device are freed.



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239924.416023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbS-0003cE-Kc; Mon, 06 Dec 2021 22:36:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239924.416023; Mon, 06 Dec 2021 22:36:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbS-0003bW-G6; Mon, 06 Dec 2021 22:36:58 +0000
Received: by outflank-mailman (input) for mailman id 239924;
 Mon, 06 Dec 2021 22:36:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSh-0001m5-SA
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:55 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c1d4999a-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c1d4999a-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.871651518@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829675;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=S+W1Q0LZK9qA36CwaGMZKKV+Y38NSAQ6cljplijOq1c=;
	b=Ir8wMJVOR0vRWYRtvVvvwdh8vk+hNLZauyW7VLWKrRT++IgOgmGu+iffTCxfxNnPnp/eUL
	rTyGHuAWLoqtYLFd0zuaiTQla2JtOb0eBIYhLEtEk9jZ3FXwQz4l6Rl7X4EP2BZT/nLmZG
	gB4XgEyUu0cKAWYBqXdGzv1j+4khf3rt8PXLnTT7HslbLMvlblRWmeFO493rPXuzAQNQvD
	pdevv23YcY11nJ5sRpy9ritQyb0MV8xDifB3U1aMs4fGqJo2CjNucLCPr7Kd6QZ00kkwLx
	CpF8pwB2sHyy6TwKDjA1aIW9IsWvP1KTSYgKnNKZ+NMAS6BpK3f7cHa0u/cYAQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829675;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=S+W1Q0LZK9qA36CwaGMZKKV+Y38NSAQ6cljplijOq1c=;
	b=YM/Nr8za192FA3caYGvQ8jFv+3Zicdz432O3rHkigtDdu6sexgOdl0L4qhS98KEbr6kSi1
	mc4fbpLRQSX5C0DA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 19/23] PCI/MSI: Sanitize MSIX table map handling
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:54 +0100 (CET)

Unmapping the MSIX base mapping in the loops which allocate/free MSI
desciptors is daft and in the way of allowing runtime expansion of MSI-X
descriptors.

Store the mapping in struct pci_dev and free it after freeing the MSI-X
descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/msi.c |   18 ++++++++----------
 include/linux/pci.h   |    1 +
 2 files changed, 9 insertions(+), 10 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -241,14 +241,14 @@ static void free_msi_irqs(struct pci_dev
 	pci_msi_teardown_msi_irqs(dev);
 
 	list_for_each_entry_safe(entry, tmp, msi_list, list) {
-		if (entry->pci.msi_attrib.is_msix) {
-			if (list_is_last(&entry->list, msi_list))
-				iounmap(entry->pci.mask_base);
-		}
-
 		list_del(&entry->list);
 		free_msi_entry(entry);
 	}
+
+	if (dev->msix_base) {
+		iounmap(dev->msix_base);
+		dev->msix_base = NULL;
+	}
 }
 
 static void pci_intx_for_msi(struct pci_dev *dev, int enable)
@@ -501,10 +501,6 @@ static int msix_setup_entries(struct pci
 	for (i = 0, curmsk = masks; i < nvec; i++) {
 		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
 		if (!entry) {
-			if (!i)
-				iounmap(base);
-			else
-				free_msi_irqs(dev);
 			/* No enough memory. Don't try again */
 			ret = -ENOMEM;
 			goto out;
@@ -602,12 +598,14 @@ static int msix_capability_init(struct p
 		goto out_disable;
 	}
 
+	dev->msix_base = base;
+
 	/* Ensure that all table entries are masked. */
 	msix_mask_all(base, tsize);
 
 	ret = msix_setup_entries(dev, base, entries, nvec, affd);
 	if (ret)
-		goto out_disable;
+		goto out_free;
 
 	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
 	if (ret)
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -473,6 +473,7 @@ struct pci_dev {
 	u8		ptm_granularity;
 #endif
 #ifdef CONFIG_PCI_MSI
+	void __iomem	*msix_base;
 	const struct attribute_group **msi_irq_groups;
 #endif
 	struct pci_vpd	vpd;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239922.416019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbS-0003Zg-BN; Mon, 06 Dec 2021 22:36:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239922.416019; Mon, 06 Dec 2021 22:36:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbS-0003ZZ-8J; Mon, 06 Dec 2021 22:36:58 +0000
Received: by outflank-mailman (input) for mailman id 239922;
 Mon, 06 Dec 2021 22:36:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSu-0001m5-9V
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:28:08 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5a5259c-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:28:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5a5259c-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210225.101336873@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829681;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=DA21nVmLDiBI7abTCMjgj20KY6xV+oZ7nL3Tb95GpzU=;
	b=tUgqDZDZ/EiCdKplAETvDx9zP2J7lXVbAOyLOoBuYDH6TGhvuPG60E8xxxj2easlDQNPkn
	zTUdmJbnIRjdW2jZn22BV2YC4f0v6JUg4B85PNY0gmnqpQ/sN1zmKIaFOZKwqGTNC8Cwta
	Zuzg0fNd26HEMDHArMjtG0lzJFq888jFDvle1JTBYdcc+inM3sPjBJytAfcyCtrn23O2UA
	KEo+a2AtJrT7M4ZyZw3GWFzmCrk8w7SJ8if/eriSWmpCeXjmWpgB3652GOnCNeZesHt7bK
	srYzZDxpjI6VQFY1vaT/mjtrbyNnxnAjKtFj8+UQL1Hs+wIUbfpLlFZD9d5QMQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829681;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=DA21nVmLDiBI7abTCMjgj20KY6xV+oZ7nL3Tb95GpzU=;
	b=MCrfZbg73639x4t4CYmepEMeEst8qlRnGzxNB/5IvDcEPSsvluAaurSvCLQW1KB8HRZ02F
	1dXwMChHv9TjP5Cw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 23/23] PCI/MSI: Move descriptor counting on allocation fail
 to the legacy code
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:28:00 +0100 (CET)

The irqdomain code already returns the information. Move the loop to the
legacy code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/legacy.c |   20 +++++++++++++++++++-
 drivers/pci/msi/msi.c    |   19 +------------------
 2 files changed, 20 insertions(+), 19 deletions(-)

--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -50,9 +50,27 @@ void __weak arch_teardown_msi_irqs(struc
 	}
 }
 
+static int pci_msi_setup_check_result(struct pci_dev *dev, int type, int ret)
+{
+	struct msi_desc *entry;
+	int avail = 0;
+
+	if (type != PCI_CAP_ID_MSIX || ret >= 0)
+		return ret;
+
+	/* Scan the MSI descriptors for successfully allocated ones. */
+	for_each_pci_msi_entry(entry, dev) {
+		if (entry->irq != 0)
+			avail++;
+	}
+	return avail ? avail : ret;
+}
+
 int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 {
-	return arch_setup_msi_irqs(dev, nvec, type);
+	int ret = arch_setup_msi_irqs(dev, nvec, type);
+
+	return pci_msi_setup_check_result(dev, type, ret);
 }
 
 void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -609,7 +609,7 @@ static int msix_capability_init(struct p
 
 	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
 	if (ret)
-		goto out_avail;
+		goto out_free;
 
 	/* Check if all MSI entries honor device restrictions */
 	ret = msi_verify_entries(dev);
@@ -634,23 +634,6 @@ static int msix_capability_init(struct p
 	pcibios_free_irq(dev);
 	return 0;
 
-out_avail:
-	if (ret < 0) {
-		/*
-		 * If we had some success, report the number of IRQs
-		 * we succeeded in setting up.
-		 */
-		struct msi_desc *entry;
-		int avail = 0;
-
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->irq != 0)
-				avail++;
-		}
-		if (avail != 0)
-			ret = avail;
-	}
-
 out_free:
 	free_msi_irqs(dev);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239927.416042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbZ-0004El-Re; Mon, 06 Dec 2021 22:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239927.416042; Mon, 06 Dec 2021 22:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbZ-0004Ee-OR; Mon, 06 Dec 2021 22:37:05 +0000
Received: by outflank-mailman (input) for mailman id 239927;
 Mon, 06 Dec 2021 22:37:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSh-0001Vt-EF
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:55 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c027f916-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:27:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c027f916-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210224.763574089@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829671;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=yrY1ZB0NumM3iY3b+dL6tdvji5YdLo8YZzow0Pc98K0=;
	b=yogWCLClZ5HawXr86pUvSu27UdiujY09fLCr9qODZ6WHG6tdy1jo4R5oUed+NZBlb4D+aL
	7QpxacnGafJnNFuGA3Qr4uuaCUoNpqcC0RQIn/nv2i/ZqqOPRpDk41N3evYyZcNUIORUqQ
	RmyJmVXQ4SgC9OEaoFrfssQoJ8Xwn+4ZyexyySLnXH1jXW3w7H7gjCvNcp6z/9YZb3iZef
	SnjRI8A4v1jtxW1cvkAQLxfhlEO0mCCMG5y3BXvNH9MRSgIaMFqX4JKVHvpx5vMHBoS0Bb
	XHborQKOUtJXUnqPXT77WiZSbh3UWDmLFWdvo+NEVEOm05/Ol4MBGoFkTWQRhw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829671;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=yrY1ZB0NumM3iY3b+dL6tdvji5YdLo8YZzow0Pc98K0=;
	b=xWk0QhW9rvUKaVhvOUrP23TOY6t2RbQv3eb8/ILfXzb+qQTtu1Dgw8jDLlkSfce65pUPAy
	AUFj7t7KeK1aKUCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 17/23] PCI/MSI: Split out !IRQDOMAIN code
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:51 +0100 (CET)

Split out the non irqdomain code into its own file.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
V2: Add proper includes and fix variable name - Cedric
---
 drivers/pci/msi/Makefile |    5 ++--
 drivers/pci/msi/legacy.c |   52 +++++++++++++++++++++++++++++++++++++++++++++++
 drivers/pci/msi/msi.c    |   46 -----------------------------------------
 3 files changed, 55 insertions(+), 48 deletions(-)

--- a/drivers/pci/msi/Makefile
+++ b/drivers/pci/msi/Makefile
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
 # Makefile for the PCI/MSI
-obj-$(CONFIG_PCI)		+= pcidev_msi.o
-obj-$(CONFIG_PCI_MSI)		+= msi.o
+obj-$(CONFIG_PCI)			+= pcidev_msi.o
+obj-$(CONFIG_PCI_MSI)			+= msi.o
+obj-$(CONFIG_PCI_MSI_ARCH_FALLBACKS)	+= legacy.o
--- /dev/null
+++ b/drivers/pci/msi/legacy.c
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * PCI Message Signaled Interrupt (MSI).
+ *
+ * Legacy architecture specific setup and teardown mechanism.
+ */
+#include <linux/msi.h>
+#include <linux/pci.h>
+
+/* Arch hooks */
+int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
+{
+	return -EINVAL;
+}
+
+void __weak arch_teardown_msi_irq(unsigned int irq)
+{
+}
+
+int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	struct msi_desc *desc;
+	int ret;
+
+	/*
+	 * If an architecture wants to support multiple MSI, it needs to
+	 * override arch_setup_msi_irqs()
+	 */
+	if (type == PCI_CAP_ID_MSI && nvec > 1)
+		return 1;
+
+	for_each_pci_msi_entry(desc, dev) {
+		ret = arch_setup_msi_irq(dev, desc);
+		if (ret)
+			return ret < 0 ? ret : -ENOSPC;
+	}
+
+	return 0;
+}
+
+void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
+{
+	struct msi_desc *desc;
+	int i;
+
+	for_each_pci_msi_entry(desc, dev) {
+		if (desc->irq) {
+			for (i = 0; i < desc->nvec_used; i++)
+				arch_teardown_msi_irq(desc->irq + i);
+		}
+	}
+}
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -50,52 +50,6 @@ static void pci_msi_teardown_msi_irqs(st
 #define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
 #endif
 
-#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
-/* Arch hooks */
-int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
-{
-	return -EINVAL;
-}
-
-void __weak arch_teardown_msi_irq(unsigned int irq)
-{
-}
-
-int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	struct msi_desc *entry;
-	int ret;
-
-	/*
-	 * If an architecture wants to support multiple MSI, it needs to
-	 * override arch_setup_msi_irqs()
-	 */
-	if (type == PCI_CAP_ID_MSI && nvec > 1)
-		return 1;
-
-	for_each_pci_msi_entry(entry, dev) {
-		ret = arch_setup_msi_irq(dev, entry);
-		if (ret < 0)
-			return ret;
-		if (ret > 0)
-			return -ENOSPC;
-	}
-
-	return 0;
-}
-
-void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
-{
-	int i;
-	struct msi_desc *entry;
-
-	for_each_pci_msi_entry(entry, dev)
-		if (entry->irq)
-			for (i = 0; i < entry->nvec_used; i++)
-				arch_teardown_msi_irq(entry->irq + i);
-}
-#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
-
 /*
  * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
  * mask all MSI interrupts by clearing the MSI enable bit does not work



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239929.416053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbj-0004w8-6E; Mon, 06 Dec 2021 22:37:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239929.416053; Mon, 06 Dec 2021 22:37:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbj-0004vy-0n; Mon, 06 Dec 2021 22:37:15 +0000
Received: by outflank-mailman (input) for mailman id 239929;
 Mon, 06 Dec 2021 22:37:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSk-0001m5-4Q
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:58 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2dcfdd6-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2dcfdd6-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.925241961@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829676;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=FXX41Qfq2rmX4Pnl0ZDgGggJiyIMhnsIgHBe+OGHmI0=;
	b=XU5P0R3+ZvbfRzdT7eITdUZpVffQhu3mwMQxHIuYgaoigDHKPoocQDa8qE3Uaf7sAC1A9a
	Js9g6cNcn6mG5wi/DOPiYiYl3E8Zz14cSLHuVeGnH6q1kq55XyN9gRmcVHSh5M702eeuzS
	bamXvbJtwYpQ7EnWUWKX/KSbvsAjwKbfyZz1Ddew/kluJQEYrt+sgElwsfwUoFZGHB3SW5
	JWhsk59n5A4ddQt8nalxZK/oiN+HIb+DfnIB5bCE/+7f4xAhtXvdT/dZztFeYnEkP4j9ik
	qGpniZKbYB7qVDkE7feBPxpsBYMFmfBZX4PgA2J+mwXW3+TPFkwcsLvleDUFdw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829676;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=FXX41Qfq2rmX4Pnl0ZDgGggJiyIMhnsIgHBe+OGHmI0=;
	b=5xLy8ejXtHWFxftIt7uUy/JNMg6lFP0zokUkUY/UbBvVYESVtltZxcFPpywZO0EAeM6axN
	GP3uFRXwCiRvoiAg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 20/23] PCI/MSI: Move msi_lock to struct pci_dev
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:56 +0100 (CET)

It's only required for PCI/MSI. So no point in having it in every struct
device.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: New patch
---
 drivers/base/core.c    |    1 -
 drivers/pci/msi/msi.c  |    2 +-
 drivers/pci/probe.c    |    4 +++-
 include/linux/device.h |    2 --
 include/linux/pci.h    |    1 +
 5 files changed, 5 insertions(+), 5 deletions(-)

--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2875,7 +2875,6 @@ void device_initialize(struct device *de
 	device_pm_init(dev);
 	set_dev_node(dev, NUMA_NO_NODE);
 #ifdef CONFIG_GENERIC_MSI_IRQ
-	raw_spin_lock_init(&dev->msi_lock);
 	INIT_LIST_HEAD(&dev->msi_list);
 #endif
 	INIT_LIST_HEAD(&dev->links.consumers);
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -18,7 +18,7 @@ int pci_msi_ignore_mask;
 
 static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
 {
-	raw_spinlock_t *lock = &desc->dev->msi_lock;
+	raw_spinlock_t *lock = &to_pci_dev(desc->dev)->msi_lock;
 	unsigned long flags;
 
 	if (!desc->pci.msi_attrib.can_mask)
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -2311,7 +2311,9 @@ struct pci_dev *pci_alloc_dev(struct pci
 	INIT_LIST_HEAD(&dev->bus_list);
 	dev->dev.type = &pci_dev_type;
 	dev->bus = pci_bus_get(bus);
-
+#ifdef CONFIG_PCI_MSI
+	raw_spin_lock_init(&dev->msi_lock);
+#endif
 	return dev;
 }
 EXPORT_SYMBOL(pci_alloc_dev);
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -407,7 +407,6 @@ struct dev_links_info {
  * @em_pd:	device's energy model performance domain
  * @pins:	For device pin management.
  *		See Documentation/driver-api/pin-control.rst for details.
- * @msi_lock:	Lock to protect MSI mask cache and mask register
  * @msi_list:	Hosts MSI descriptors
  * @msi_domain: The generic MSI domain this device is using.
  * @numa_node:	NUMA node this device is close to.
@@ -508,7 +507,6 @@ struct device {
 	struct dev_pin_info	*pins;
 #endif
 #ifdef CONFIG_GENERIC_MSI_IRQ
-	raw_spinlock_t		msi_lock;
 	struct list_head	msi_list;
 #endif
 #ifdef CONFIG_DMA_OPS
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -474,6 +474,7 @@ struct pci_dev {
 #endif
 #ifdef CONFIG_PCI_MSI
 	void __iomem	*msix_base;
+	raw_spinlock_t	msi_lock;
 	const struct attribute_group **msi_irq_groups;
 #endif
 	struct pci_vpd	vpd;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239938.416064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbs-0005a1-FJ; Mon, 06 Dec 2021 22:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239938.416064; Mon, 06 Dec 2021 22:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbs-0005Zu-Ao; Mon, 06 Dec 2021 22:37:24 +0000
Received: by outflank-mailman (input) for mailman id 239938;
 Mon, 06 Dec 2021 22:37:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSh-0001m5-44
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:55 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0f299d1-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0f299d1-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.817754783@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829673;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gtmzP0QXcojZTfwh0b3CXIKwtMUd+mwqAeyOUXCCvG4=;
	b=vfpqB1EPtmssuD5id4/VrSZYSiLwnckjq/anGWKx/Xp8WX7t79DcF+2VZPzENWQgNki5uf
	crep/FhLwGx8/MzRGdCmWqkq+m5K5bkju8FHWJQu7RM7r3xfcJKSpdZESCk2X5Y0OXIfhY
	QIjVqsZFDgmvEHFXI0T005yihpkJ94XBQkVEpurEE7Gp1E1MaJd2psFV3shZ2GlaqYKWDC
	oJJ1295cYhxD0luai5sQijbxNshugZRDr/Bp2bTw+8MbpCu4wTdUZLb4lZ2SN0AVueg15j
	tUjKgxHWL4FIDnSFITIIPOlSsvZ5wNZXuqJ6tj8pwN8gDFgXNwo++B8YHz0RQg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829673;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=gtmzP0QXcojZTfwh0b3CXIKwtMUd+mwqAeyOUXCCvG4=;
	b=4082KXHzJsSMf1c0EVxwBcQqrnyiZAe4a8hWndgO8+KXQ211i2rXjv4AYuNbJmZfYV6OiE
	21F2XIZX6iCAYIDw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 18/23] PCI/MSI: Split out irqdomain code
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:52 +0100 (CET)

Move the irqdomain specific code into it's own file.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/Makefile    |    1 
 drivers/pci/msi/irqdomain.c |  279 ++++++++++++++++++++++++++++++++++++++
 drivers/pci/msi/legacy.c    |   13 +
 drivers/pci/msi/msi.c       |  319 +-------------------------------------------
 drivers/pci/msi/msi.h       |   39 +++++
 include/linux/msi.h         |   11 -
 6 files changed, 340 insertions(+), 322 deletions(-)

--- a/drivers/pci/msi/Makefile
+++ b/drivers/pci/msi/Makefile
@@ -3,4 +3,5 @@
 # Makefile for the PCI/MSI
 obj-$(CONFIG_PCI)			+= pcidev_msi.o
 obj-$(CONFIG_PCI_MSI)			+= msi.o
+obj-$(CONFIG_PCI_MSI_IRQ_DOMAIN)	+= irqdomain.o
 obj-$(CONFIG_PCI_MSI_ARCH_FALLBACKS)	+= legacy.o
--- /dev/null
+++ b/drivers/pci/msi/irqdomain.c
@@ -0,0 +1,279 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * PCI Message Signaled Interrupt (MSI) - irqdomain support
+ */
+#include <linux/acpi_iort.h>
+#include <linux/irqdomain.h>
+#include <linux/of_irq.h>
+
+#include "msi.h"
+
+int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	struct irq_domain *domain;
+
+	domain = dev_get_msi_domain(&dev->dev);
+	if (domain && irq_domain_is_hierarchy(domain))
+		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
+
+	return pci_msi_legacy_setup_msi_irqs(dev, nvec, type);
+}
+
+void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
+{
+	struct irq_domain *domain;
+
+	domain = dev_get_msi_domain(&dev->dev);
+	if (domain && irq_domain_is_hierarchy(domain))
+		msi_domain_free_irqs(domain, &dev->dev);
+	else
+		pci_msi_legacy_teardown_msi_irqs(dev);
+}
+
+/**
+ * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
+ * @irq_data:	Pointer to interrupt data of the MSI interrupt
+ * @msg:	Pointer to the message
+ */
+static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
+{
+	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
+
+	/*
+	 * For MSI-X desc->irq is always equal to irq_data->irq. For
+	 * MSI only the first interrupt of MULTI MSI passes the test.
+	 */
+	if (desc->irq == irq_data->irq)
+		__pci_write_msi_msg(desc, msg);
+}
+
+/**
+ * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
+ * @desc:	Pointer to the MSI descriptor
+ *
+ * The ID number is only used within the irqdomain.
+ */
+static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
+{
+	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
+
+	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
+		pci_dev_id(dev) << 11 |
+		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
+}
+
+static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
+{
+	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
+}
+
+/**
+ * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
+ *			      for @dev
+ * @domain:	The interrupt domain to check
+ * @info:	The domain info for verification
+ * @dev:	The device to check
+ *
+ * Returns:
+ *  0 if the functionality is supported
+ *  1 if Multi MSI is requested, but the domain does not support it
+ *  -ENOTSUPP otherwise
+ */
+int pci_msi_domain_check_cap(struct irq_domain *domain,
+			     struct msi_domain_info *info, struct device *dev)
+{
+	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
+
+	/* Special handling to support __pci_enable_msi_range() */
+	if (pci_msi_desc_is_multi_msi(desc) &&
+	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
+		return 1;
+	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
+		return -ENOTSUPP;
+
+	return 0;
+}
+
+static int pci_msi_domain_handle_error(struct irq_domain *domain,
+				       struct msi_desc *desc, int error)
+{
+	/* Special handling to support __pci_enable_msi_range() */
+	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
+		return 1;
+
+	return error;
+}
+
+static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
+				    struct msi_desc *desc)
+{
+	arg->desc = desc;
+	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
+}
+
+static struct msi_domain_ops pci_msi_domain_ops_default = {
+	.set_desc	= pci_msi_domain_set_desc,
+	.msi_check	= pci_msi_domain_check_cap,
+	.handle_error	= pci_msi_domain_handle_error,
+};
+
+static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
+{
+	struct msi_domain_ops *ops = info->ops;
+
+	if (ops == NULL) {
+		info->ops = &pci_msi_domain_ops_default;
+	} else {
+		if (ops->set_desc == NULL)
+			ops->set_desc = pci_msi_domain_set_desc;
+		if (ops->msi_check == NULL)
+			ops->msi_check = pci_msi_domain_check_cap;
+		if (ops->handle_error == NULL)
+			ops->handle_error = pci_msi_domain_handle_error;
+	}
+}
+
+static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
+{
+	struct irq_chip *chip = info->chip;
+
+	BUG_ON(!chip);
+	if (!chip->irq_write_msi_msg)
+		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
+	if (!chip->irq_mask)
+		chip->irq_mask = pci_msi_mask_irq;
+	if (!chip->irq_unmask)
+		chip->irq_unmask = pci_msi_unmask_irq;
+}
+
+/**
+ * pci_msi_create_irq_domain - Create a MSI interrupt domain
+ * @fwnode:	Optional fwnode of the interrupt controller
+ * @info:	MSI domain info
+ * @parent:	Parent irq domain
+ *
+ * Updates the domain and chip ops and creates a MSI interrupt domain.
+ *
+ * Returns:
+ * A domain pointer or NULL in case of failure.
+ */
+struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
+					     struct msi_domain_info *info,
+					     struct irq_domain *parent)
+{
+	struct irq_domain *domain;
+
+	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
+		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
+
+	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
+		pci_msi_domain_update_dom_ops(info);
+	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
+		pci_msi_domain_update_chip_ops(info);
+
+	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
+		info->flags |= MSI_FLAG_MUST_REACTIVATE;
+
+	/* PCI-MSI is oneshot-safe */
+	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
+
+	domain = msi_create_irq_domain(fwnode, info, parent);
+	if (!domain)
+		return NULL;
+
+	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
+	return domain;
+}
+EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
+
+/*
+ * Users of the generic MSI infrastructure expect a device to have a single ID,
+ * so with DMA aliases we have to pick the least-worst compromise. Devices with
+ * DMA phantom functions tend to still emit MSIs from the real function number,
+ * so we ignore those and only consider topological aliases where either the
+ * alias device or RID appears on a different bus number. We also make the
+ * reasonable assumption that bridges are walked in an upstream direction (so
+ * the last one seen wins), and the much braver assumption that the most likely
+ * case is that of PCI->PCIe so we should always use the alias RID. This echoes
+ * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
+ * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
+ * for taking ownership all we can really do is close our eyes and hope...
+ */
+static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
+{
+	u32 *pa = data;
+	u8 bus = PCI_BUS_NUM(*pa);
+
+	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
+		*pa = alias;
+
+	return 0;
+}
+
+/**
+ * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
+ * @domain:	The interrupt domain
+ * @pdev:	The PCI device.
+ *
+ * The RID for a device is formed from the alias, with a firmware
+ * supplied mapping applied
+ *
+ * Returns: The RID.
+ */
+u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
+{
+	struct device_node *of_node;
+	u32 rid = pci_dev_id(pdev);
+
+	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
+
+	of_node = irq_domain_get_of_node(domain);
+	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
+			iort_msi_map_id(&pdev->dev, rid);
+
+	return rid;
+}
+
+/**
+ * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
+ * @pdev:	The PCI device
+ *
+ * Use the firmware data to find a device-specific MSI domain
+ * (i.e. not one that is set as a default).
+ *
+ * Returns: The corresponding MSI domain or NULL if none has been found.
+ */
+struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
+{
+	struct irq_domain *dom;
+	u32 rid = pci_dev_id(pdev);
+
+	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
+	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
+	if (!dom)
+		dom = iort_get_device_domain(&pdev->dev, rid,
+					     DOMAIN_BUS_PCI_MSI);
+	return dom;
+}
+
+/**
+ * pci_dev_has_special_msi_domain - Check whether the device is handled by
+ *				    a non-standard PCI-MSI domain
+ * @pdev:	The PCI device to check.
+ *
+ * Returns: True if the device irqdomain or the bus irqdomain is
+ * non-standard PCI/MSI.
+ */
+bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
+{
+	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
+
+	if (!dom)
+		dom = dev_get_msi_domain(&pdev->bus->dev);
+
+	if (!dom)
+		return true;
+
+	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
+}
--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -4,8 +4,7 @@
  *
  * Legacy architecture specific setup and teardown mechanism.
  */
-#include <linux/msi.h>
-#include <linux/pci.h>
+#include "msi.h"
 
 /* Arch hooks */
 int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
@@ -50,3 +49,13 @@ void __weak arch_teardown_msi_irqs(struc
 		}
 	}
 }
+
+int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	return arch_setup_msi_irqs(dev, nvec, type);
+}
+
+void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
+{
+	arch_teardown_msi_irqs(dev);
+}
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -6,64 +6,16 @@
  * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
  * Copyright (C) 2016 Christoph Hellwig.
  */
-
-#include <linux/acpi_iort.h>
 #include <linux/err.h>
 #include <linux/export.h>
 #include <linux/irq.h>
-#include <linux/irqdomain.h>
-#include <linux/msi.h>
-#include <linux/of_irq.h>
-#include <linux/pci.h>
 
 #include "../pci.h"
+#include "msi.h"
 
 static int pci_msi_enable = 1;
 int pci_msi_ignore_mask;
 
-#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
-
-#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
-static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	struct irq_domain *domain;
-
-	domain = dev_get_msi_domain(&dev->dev);
-	if (domain && irq_domain_is_hierarchy(domain))
-		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
-
-	return arch_setup_msi_irqs(dev, nvec, type);
-}
-
-static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
-{
-	struct irq_domain *domain;
-
-	domain = dev_get_msi_domain(&dev->dev);
-	if (domain && irq_domain_is_hierarchy(domain))
-		msi_domain_free_irqs(domain, &dev->dev);
-	else
-		arch_teardown_msi_irqs(dev);
-}
-#else
-#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
-#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
-#endif
-
-/*
- * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
- * mask all MSI interrupts by clearing the MSI enable bit does not work
- * reliably as devices without an INTx disable bit will then generate a
- * level IRQ which will never be cleared.
- */
-static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
-{
-	/* Don't shift by >= width of type */
-	if (desc->pci.msi_attrib.multi_cap >= 5)
-		return 0xffffffff;
-	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
-}
-
 static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
 {
 	raw_spinlock_t *lock = &desc->dev->msi_lock;
@@ -903,23 +855,6 @@ void pci_disable_msix(struct pci_dev *de
 }
 EXPORT_SYMBOL(pci_disable_msix);
 
-void pci_no_msi(void)
-{
-	pci_msi_enable = 0;
-}
-
-/**
- * pci_msi_enabled - is MSI enabled?
- *
- * Returns true if MSI has not been disabled by the command-line option
- * pci=nomsi.
- **/
-int pci_msi_enabled(void)
-{
-	return pci_msi_enable;
-}
-EXPORT_SYMBOL(pci_msi_enabled);
-
 static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
 				  struct irq_affinity *affd)
 {
@@ -1195,253 +1130,19 @@ struct pci_dev *msi_desc_to_pci_dev(stru
 }
 EXPORT_SYMBOL(msi_desc_to_pci_dev);
 
-#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
-/**
- * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
- * @irq_data:	Pointer to interrupt data of the MSI interrupt
- * @msg:	Pointer to the message
- */
-static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
-{
-	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
-
-	/*
-	 * For MSI-X desc->irq is always equal to irq_data->irq. For
-	 * MSI only the first interrupt of MULTI MSI passes the test.
-	 */
-	if (desc->irq == irq_data->irq)
-		__pci_write_msi_msg(desc, msg);
-}
-
-/**
- * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
- * @desc:	Pointer to the MSI descriptor
- *
- * The ID number is only used within the irqdomain.
- */
-static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
-{
-	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
-
-	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
-		pci_dev_id(dev) << 11 |
-		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
-}
-
-static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
-{
-	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
-}
-
-/**
- * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
- * 			      for @dev
- * @domain:	The interrupt domain to check
- * @info:	The domain info for verification
- * @dev:	The device to check
- *
- * Returns:
- *  0 if the functionality is supported
- *  1 if Multi MSI is requested, but the domain does not support it
- *  -ENOTSUPP otherwise
- */
-int pci_msi_domain_check_cap(struct irq_domain *domain,
-			     struct msi_domain_info *info, struct device *dev)
-{
-	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
-
-	/* Special handling to support __pci_enable_msi_range() */
-	if (pci_msi_desc_is_multi_msi(desc) &&
-	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
-		return 1;
-	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
-		return -ENOTSUPP;
-
-	return 0;
-}
-
-static int pci_msi_domain_handle_error(struct irq_domain *domain,
-				       struct msi_desc *desc, int error)
-{
-	/* Special handling to support __pci_enable_msi_range() */
-	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
-		return 1;
-
-	return error;
-}
-
-static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
-				    struct msi_desc *desc)
-{
-	arg->desc = desc;
-	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
-}
-
-static struct msi_domain_ops pci_msi_domain_ops_default = {
-	.set_desc	= pci_msi_domain_set_desc,
-	.msi_check	= pci_msi_domain_check_cap,
-	.handle_error	= pci_msi_domain_handle_error,
-};
-
-static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
-{
-	struct msi_domain_ops *ops = info->ops;
-
-	if (ops == NULL) {
-		info->ops = &pci_msi_domain_ops_default;
-	} else {
-		if (ops->set_desc == NULL)
-			ops->set_desc = pci_msi_domain_set_desc;
-		if (ops->msi_check == NULL)
-			ops->msi_check = pci_msi_domain_check_cap;
-		if (ops->handle_error == NULL)
-			ops->handle_error = pci_msi_domain_handle_error;
-	}
-}
-
-static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
-{
-	struct irq_chip *chip = info->chip;
-
-	BUG_ON(!chip);
-	if (!chip->irq_write_msi_msg)
-		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
-	if (!chip->irq_mask)
-		chip->irq_mask = pci_msi_mask_irq;
-	if (!chip->irq_unmask)
-		chip->irq_unmask = pci_msi_unmask_irq;
-}
-
-/**
- * pci_msi_create_irq_domain - Create a MSI interrupt domain
- * @fwnode:	Optional fwnode of the interrupt controller
- * @info:	MSI domain info
- * @parent:	Parent irq domain
- *
- * Updates the domain and chip ops and creates a MSI interrupt domain.
- *
- * Returns:
- * A domain pointer or NULL in case of failure.
- */
-struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
-					     struct msi_domain_info *info,
-					     struct irq_domain *parent)
-{
-	struct irq_domain *domain;
-
-	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
-		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
-
-	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
-		pci_msi_domain_update_dom_ops(info);
-	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
-		pci_msi_domain_update_chip_ops(info);
-
-	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
-	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
-		info->flags |= MSI_FLAG_MUST_REACTIVATE;
-
-	/* PCI-MSI is oneshot-safe */
-	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
-
-	domain = msi_create_irq_domain(fwnode, info, parent);
-	if (!domain)
-		return NULL;
-
-	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
-	return domain;
-}
-EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
-
-/*
- * Users of the generic MSI infrastructure expect a device to have a single ID,
- * so with DMA aliases we have to pick the least-worst compromise. Devices with
- * DMA phantom functions tend to still emit MSIs from the real function number,
- * so we ignore those and only consider topological aliases where either the
- * alias device or RID appears on a different bus number. We also make the
- * reasonable assumption that bridges are walked in an upstream direction (so
- * the last one seen wins), and the much braver assumption that the most likely
- * case is that of PCI->PCIe so we should always use the alias RID. This echoes
- * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
- * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
- * for taking ownership all we can really do is close our eyes and hope...
- */
-static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
-{
-	u32 *pa = data;
-	u8 bus = PCI_BUS_NUM(*pa);
-
-	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
-		*pa = alias;
-
-	return 0;
-}
-
-/**
- * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
- * @domain:	The interrupt domain
- * @pdev:	The PCI device.
- *
- * The RID for a device is formed from the alias, with a firmware
- * supplied mapping applied
- *
- * Returns: The RID.
- */
-u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
-{
-	struct device_node *of_node;
-	u32 rid = pci_dev_id(pdev);
-
-	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
-
-	of_node = irq_domain_get_of_node(domain);
-	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
-			iort_msi_map_id(&pdev->dev, rid);
-
-	return rid;
-}
-
-/**
- * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
- * @pdev:	The PCI device
- *
- * Use the firmware data to find a device-specific MSI domain
- * (i.e. not one that is set as a default).
- *
- * Returns: The corresponding MSI domain or NULL if none has been found.
- */
-struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
+void pci_no_msi(void)
 {
-	struct irq_domain *dom;
-	u32 rid = pci_dev_id(pdev);
-
-	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
-	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
-	if (!dom)
-		dom = iort_get_device_domain(&pdev->dev, rid,
-					     DOMAIN_BUS_PCI_MSI);
-	return dom;
+	pci_msi_enable = 0;
 }
 
 /**
- * pci_dev_has_special_msi_domain - Check whether the device is handled by
- *				    a non-standard PCI-MSI domain
- * @pdev:	The PCI device to check.
+ * pci_msi_enabled - is MSI enabled?
  *
- * Returns: True if the device irqdomain or the bus irqdomain is
- * non-standard PCI/MSI.
- */
-bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
+ * Returns true if MSI has not been disabled by the command-line option
+ * pci=nomsi.
+ **/
+int pci_msi_enabled(void)
 {
-	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
-
-	if (!dom)
-		dom = dev_get_msi_domain(&pdev->bus->dev);
-
-	if (!dom)
-		return true;
-
-	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
+	return pci_msi_enable;
 }
-
-#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
+EXPORT_SYMBOL(pci_msi_enabled);
--- /dev/null
+++ b/drivers/pci/msi/msi.h
@@ -0,0 +1,39 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#include <linux/pci.h>
+#include <linux/msi.h>
+
+#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
+
+extern int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
+extern void pci_msi_teardown_msi_irqs(struct pci_dev *dev);
+
+#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
+extern int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
+extern void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev);
+#else
+static inline int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	WARN_ON_ONCE(1);
+	return -ENODEV;
+}
+
+static inline void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
+{
+	WARN_ON_ONCE(1);
+}
+#endif
+
+/*
+ * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
+ * mask all MSI interrupts by clearing the MSI enable bit does not work
+ * reliably as devices without an INTx disable bit will then generate a
+ * level IRQ which will never be cleared.
+ */
+static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
+{
+	/* Don't shift by >= width of type */
+	if (desc->pci.msi_attrib.multi_cap >= 5)
+		return 0xffffffff;
+	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
+}
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -259,17 +259,6 @@ int arch_setup_msi_irq(struct pci_dev *d
 void arch_teardown_msi_irq(unsigned int irq);
 int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
 void arch_teardown_msi_irqs(struct pci_dev *dev);
-#else
-static inline int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	WARN_ON_ONCE(1);
-	return -ENODEV;
-}
-
-static inline void arch_teardown_msi_irqs(struct pci_dev *dev)
-{
-	WARN_ON_ONCE(1);
-}
 #endif
 
 /*



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:37:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239939.416069 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbs-0005d1-RS; Mon, 06 Dec 2021 22:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239939.416069; Mon, 06 Dec 2021 22:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMbs-0005cS-LH; Mon, 06 Dec 2021 22:37:24 +0000
Received: by outflank-mailman (input) for mailman id 239939;
 Mon, 06 Dec 2021 22:37:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSn-0001Vt-Ea
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:28:01 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c4b6ae83-56e3-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:28:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4b6ae83-56e3-11ec-a5e1-b9374ead2679
Message-ID: <20211206210225.046615302@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829679;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Llb+UkCn1EdRNyykmbxfFT74AdLeoQ5WEavNgQJIfNI=;
	b=m/otsXxhhIjzQusJ74eE8x4nGdLq11UjKe/1KMkqIM9y+rVLBafAimp/SstBo/tjgZZJjx
	jUOoA7IpkqUEML50sZTNQci0D7KnLV1MzjX0YjVCHj6Zz7zlYmxqGLCMvPnqkP+avoKD3g
	7U5BFVjR9Hzh1o0t0RWyuvuXMyR9dQNDlfD1uB1foGmdMyJFhSAKleZ0J3XOTQuZnzQ4aP
	a9DnRcqa1Nin6HKz/IOBO4KLJ3RiPbywM+Ky2yqslP6pLupCe3J3mzyQtH5FhiTln6zTV8
	KOeT5CnFn5EmRKWSfUdL/BHH823q5Ikmg75a9L5Qaag5v+7qt1RSQspcMYwX2g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829679;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Llb+UkCn1EdRNyykmbxfFT74AdLeoQ5WEavNgQJIfNI=;
	b=XpUaw5kpy0Mws2HZXd/IbELNsaWgjBLSWCLWagCfUU2JhlssyyFIUBSpX9FsWSY6dhwc6T
	ETc9kRzRw9IdjRCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject:
 [patch V2 22/23] genirq/msi: Handle PCI/MSI allocation fail in core code
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:59 +0100 (CET)

Get rid of yet another irqdomain callback and let the core code return the
already available information of how many descriptors could be allocated.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/irqdomain.c |   13 -------------
 include/linux/msi.h         |    5 +----
 kernel/irq/msi.c            |   29 +++++++++++++++++++++++++----
 3 files changed, 26 insertions(+), 21 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -95,16 +95,6 @@ static int pci_msi_domain_check_cap(stru
 	return 0;
 }
 
-static int pci_msi_domain_handle_error(struct irq_domain *domain,
-				       struct msi_desc *desc, int error)
-{
-	/* Special handling to support __pci_enable_msi_range() */
-	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
-		return 1;
-
-	return error;
-}
-
 static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
 				    struct msi_desc *desc)
 {
@@ -115,7 +105,6 @@ static void pci_msi_domain_set_desc(msi_
 static struct msi_domain_ops pci_msi_domain_ops_default = {
 	.set_desc	= pci_msi_domain_set_desc,
 	.msi_check	= pci_msi_domain_check_cap,
-	.handle_error	= pci_msi_domain_handle_error,
 };
 
 static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
@@ -129,8 +118,6 @@ static void pci_msi_domain_update_dom_op
 			ops->set_desc = pci_msi_domain_set_desc;
 		if (ops->msi_check == NULL)
 			ops->msi_check = pci_msi_domain_check_cap;
-		if (ops->handle_error == NULL)
-			ops->handle_error = pci_msi_domain_handle_error;
 	}
 }
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -286,7 +286,6 @@ struct msi_domain_info;
  * @msi_check:		Callback for verification of the domain/info/dev data
  * @msi_prepare:	Prepare the allocation of the interrupts in the domain
  * @set_desc:		Set the msi descriptor for an interrupt
- * @handle_error:	Optional error handler if the allocation fails
  * @domain_alloc_irqs:	Optional function to override the default allocation
  *			function.
  * @domain_free_irqs:	Optional function to override the default free
@@ -295,7 +294,7 @@ struct msi_domain_info;
  * @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
  * irqdomain.
  *
- * @msi_check, @msi_prepare, @handle_error and @set_desc are callbacks used by
+ * @msi_check, @msi_prepare and @set_desc are callbacks used by
  * msi_domain_alloc/free_irqs().
  *
  * @domain_alloc_irqs, @domain_free_irqs can be used to override the
@@ -332,8 +331,6 @@ struct msi_domain_ops {
 				       msi_alloc_info_t *arg);
 	void		(*set_desc)(msi_alloc_info_t *arg,
 				    struct msi_desc *desc);
-	int		(*handle_error)(struct irq_domain *domain,
-					struct msi_desc *desc, int error);
 	int		(*domain_alloc_irqs)(struct irq_domain *domain,
 					     struct device *dev, int nvec);
 	void		(*domain_free_irqs)(struct irq_domain *domain,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -538,6 +538,27 @@ static bool msi_check_reservation_mode(s
 	return desc->pci.msi_attrib.is_msix || desc->pci.msi_attrib.can_mask;
 }
 
+static int msi_handle_pci_fail(struct irq_domain *domain, struct msi_desc *desc,
+			       int allocated)
+{
+	switch(domain->bus_token) {
+	case DOMAIN_BUS_PCI_MSI:
+	case DOMAIN_BUS_VMD_MSI:
+		if (IS_ENABLED(CONFIG_PCI_MSI))
+			break;
+		fallthrough;
+	default:
+		return -ENOSPC;
+	}
+
+	/* Let a failed PCI multi MSI allocation retry */
+	if (desc->nvec_used > 1)
+		return 1;
+
+	/* If there was a successful allocation let the caller know */
+	return allocated ? allocated : -ENOSPC;
+}
+
 int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 			    int nvec)
 {
@@ -546,6 +567,7 @@ int __msi_domain_alloc_irqs(struct irq_d
 	struct irq_data *irq_data;
 	struct msi_desc *desc;
 	msi_alloc_info_t arg = { };
+	int allocated = 0;
 	int i, ret, virq;
 	bool can_reserve;
 
@@ -560,16 +582,15 @@ int __msi_domain_alloc_irqs(struct irq_d
 					       dev_to_node(dev), &arg, false,
 					       desc->affinity);
 		if (virq < 0) {
-			ret = -ENOSPC;
-			if (ops->handle_error)
-				ret = ops->handle_error(domain, desc, ret);
-			return ret;
+			ret = msi_handle_pci_fail(domain, desc, allocated);
+			goto cleanup;
 		}
 
 		for (i = 0; i < desc->nvec_used; i++) {
 			irq_set_msi_desc_off(virq, i, desc);
 			irq_debugfs_copy_devname(virq + i, dev);
 		}
+		allocated++;
 	}
 
 	can_reserve = msi_check_reservation_mode(domain, info, dev);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:38:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:38:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239979.416086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMcb-0007QK-DQ; Mon, 06 Dec 2021 22:38:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239979.416086; Mon, 06 Dec 2021 22:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMcb-0007QD-AK; Mon, 06 Dec 2021 22:38:09 +0000
Received: by outflank-mailman (input) for mailman id 239979;
 Mon, 06 Dec 2021 22:38:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSl-0001m5-4O
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:59 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c3c3fa73-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3c3fa73-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.980989243@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829678;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=YWBvF5zXcDfRUfEoyBk4Kk35zgLL7tyJ9PWeow343Hs=;
	b=jwThvHARsPXTlMHIlndJwa10LjHcshFU6NoML8SG2JGecBMWy4JPiHuWFnGcP7i4Q1Ibj9
	8/eowhkrx1wKGYm2Yxrw7xrDhLIewEAHBE8layal+21UsPmPoYAdbuy3jJUREs5PCuecye
	7m+VUQ/rPIgBX30eS2stYDrLVHUftcTe2LN/Q1eeUdPqRiMNfed020JM797KQYT7nPIA/z
	TmSwV/cB5rCcOQB4kL1Ge9QBNfhiTLnud2sKQVAEnQK9z3iC+nzZSzw4bFmLKQuIgKUo7a
	vIALLKQRlHw2SJH97tyJGigjR7KCwlJGJTEagLbQtpMSi36ZAkynmCJEolc1UQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829678;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=YWBvF5zXcDfRUfEoyBk4Kk35zgLL7tyJ9PWeow343Hs=;
	b=WWO0wDP12OPjmI9cLbgeixKjE+ylewjJ4EqqGA8strpjub+l5CYlIKtxJmN+Pp2T3jnqE9
	pSxUKy0jh2EVgdBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 21/23] PCI/MSI: Make pci_msi_domain_check_cap() static
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:57 +0100 (CET)

No users outside of that file.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/irqdomain.c |    5 +++--
 include/linux/msi.h         |    2 --
 2 files changed, 3 insertions(+), 4 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -79,8 +79,9 @@ static inline bool pci_msi_desc_is_multi
  *  1 if Multi MSI is requested, but the domain does not support it
  *  -ENOTSUPP otherwise
  */
-int pci_msi_domain_check_cap(struct irq_domain *domain,
-			     struct msi_domain_info *info, struct device *dev)
+static int pci_msi_domain_check_cap(struct irq_domain *domain,
+				    struct msi_domain_info *info,
+				    struct device *dev)
 {
 	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -439,8 +439,6 @@ void *platform_msi_get_host_data(struct
 struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
 					     struct msi_domain_info *info,
 					     struct irq_domain *parent);
-int pci_msi_domain_check_cap(struct irq_domain *domain,
-			     struct msi_domain_info *info, struct device *dev);
 u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev);
 struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev);
 bool pci_dev_has_special_msi_domain(struct pci_dev *pdev);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:38:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.239986.416097 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMcj-0007oI-Mr; Mon, 06 Dec 2021 22:38:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 239986.416097; Mon, 06 Dec 2021 22:38:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMcj-0007o4-Ip; Mon, 06 Dec 2021 22:38:17 +0000
Received: by outflank-mailman (input) for mailman id 239986;
 Mon, 06 Dec 2021 22:38:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMSe-0001m5-2v
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:27:52 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id be536adb-56e3-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:27:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be536adb-56e3-11ec-8a4d-196798b21f7b
Message-ID: <20211206210224.655043033@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638829669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=hpRKFVK8c6sDVWghKmB03eN3IVYFpF158rP8c0DN+zU=;
	b=DD7Z+qzS1P/gjNNk2znBKgd9uRGSqVR88yvssnFC0CZU/afuXistxfer8K0hwXIoB1c4Jn
	PqRrEAglAqx367yBrLe6dup6ML0/Id/g9Ml0/rdwgF1xSYCegVtQCz7W3sUZ0ffbFQ2DJn
	/lj6lp1L1s3O5iAnCOo6SpNl5SAcpT1t5/bUm/1Tuo2g2WeUKVYgK2cFKSl+DAquVOKovj
	6K0NSK5RUuvpJ+E4VaPJ7BMrc3L4ka5XNf7kc+g9QTNbi9fHQ0tRV7tqx7g7xh1c4NYYMw
	q80yD/5r4rTIjRE+pFImF2AtyTutmLOm8jVVOo4zggySWH9XUTdZwWs4NL56mA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638829669;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=hpRKFVK8c6sDVWghKmB03eN3IVYFpF158rP8c0DN+zU=;
	b=J/QydmuG4kUWmq0qp7FRGdfW6TFqRC4+PJUo1op2aZStVi39MK/MNRVQ3vj1evJCECiHKX
	YSFYnk5fQDetOUCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Paul Mackerras <paulus@samba.org>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 linux-mips@vger.kernel.org,
 Kalle Valo <kvalo@codeaurora.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org,
 x86@kernel.org,
 xen-devel@lists.xenproject.org,
 ath11k@lists.infradead.org,
 Wei Liu <wei.liu@kernel.org>,
 linux-hyperv@vger.kernel.org,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Heiko Carstens <hca@linux.ibm.com>
Subject: [patch V2 15/23] PCI/MSI: Move code into a separate directory
References: <20211206210147.872865823@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:27:47 +0100 (CET)

msi.c is getting larger and really could do with a splitup. Move it into
it's own directory to prepare for that.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 Documentation/driver-api/pci/pci.rst |    2 
 drivers/pci/Makefile                 |    3 
 drivers/pci/msi.c                    | 1532 -----------------------------------
 drivers/pci/msi/Makefile             |    4 
 drivers/pci/msi/msi.c                | 1532 +++++++++++++++++++++++++++++++++++
 5 files changed, 1539 insertions(+), 1534 deletions(-)

--- a/Documentation/driver-api/pci/pci.rst
+++ b/Documentation/driver-api/pci/pci.rst
@@ -13,7 +13,7 @@ PCI Support Library
 .. kernel-doc:: drivers/pci/search.c
    :export:
 
-.. kernel-doc:: drivers/pci/msi.c
+.. kernel-doc:: drivers/pci/msi/msi.c
    :export:
 
 .. kernel-doc:: drivers/pci/bus.c
--- a/drivers/pci/Makefile
+++ b/drivers/pci/Makefile
@@ -5,8 +5,9 @@
 obj-$(CONFIG_PCI)		+= access.o bus.o probe.o host-bridge.o \
 				   remove.o pci.o pci-driver.o search.o \
 				   pci-sysfs.o rom.o setup-res.o irq.o vpd.o \
-				   setup-bus.o vc.o mmap.o setup-irq.o msi.o
+				   setup-bus.o vc.o mmap.o setup-irq.o
 
+obj-$(CONFIG_PCI)		+= msi/
 obj-$(CONFIG_PCI)		+= pcie/
 
 ifdef CONFIG_PCI
--- a/drivers/pci/msi.c
+++ /dev/null
@@ -1,1532 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * PCI Message Signaled Interrupt (MSI)
- *
- * Copyright (C) 2003-2004 Intel
- * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
- * Copyright (C) 2016 Christoph Hellwig.
- */
-
-#include <linux/acpi_iort.h>
-#include <linux/err.h>
-#include <linux/export.h>
-#include <linux/irq.h>
-#include <linux/irqdomain.h>
-#include <linux/msi.h>
-#include <linux/of_irq.h>
-#include <linux/pci.h>
-
-#include "pci.h"
-
-#ifdef CONFIG_PCI_MSI
-
-static int pci_msi_enable = 1;
-int pci_msi_ignore_mask;
-
-#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
-
-#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
-static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	struct irq_domain *domain;
-
-	domain = dev_get_msi_domain(&dev->dev);
-	if (domain && irq_domain_is_hierarchy(domain))
-		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
-
-	return arch_setup_msi_irqs(dev, nvec, type);
-}
-
-static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
-{
-	struct irq_domain *domain;
-
-	domain = dev_get_msi_domain(&dev->dev);
-	if (domain && irq_domain_is_hierarchy(domain))
-		msi_domain_free_irqs(domain, &dev->dev);
-	else
-		arch_teardown_msi_irqs(dev);
-}
-#else
-#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
-#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
-#endif
-
-#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
-/* Arch hooks */
-int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
-{
-	return -EINVAL;
-}
-
-void __weak arch_teardown_msi_irq(unsigned int irq)
-{
-}
-
-int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
-{
-	struct msi_desc *entry;
-	int ret;
-
-	/*
-	 * If an architecture wants to support multiple MSI, it needs to
-	 * override arch_setup_msi_irqs()
-	 */
-	if (type == PCI_CAP_ID_MSI && nvec > 1)
-		return 1;
-
-	for_each_pci_msi_entry(entry, dev) {
-		ret = arch_setup_msi_irq(dev, entry);
-		if (ret < 0)
-			return ret;
-		if (ret > 0)
-			return -ENOSPC;
-	}
-
-	return 0;
-}
-
-void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
-{
-	int i;
-	struct msi_desc *entry;
-
-	for_each_pci_msi_entry(entry, dev)
-		if (entry->irq)
-			for (i = 0; i < entry->nvec_used; i++)
-				arch_teardown_msi_irq(entry->irq + i);
-}
-#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
-
-/*
- * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
- * mask all MSI interrupts by clearing the MSI enable bit does not work
- * reliably as devices without an INTx disable bit will then generate a
- * level IRQ which will never be cleared.
- */
-static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
-{
-	/* Don't shift by >= width of type */
-	if (desc->pci.msi_attrib.multi_cap >= 5)
-		return 0xffffffff;
-	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
-}
-
-static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
-{
-	raw_spinlock_t *lock = &desc->dev->msi_lock;
-	unsigned long flags;
-
-	if (!desc->pci.msi_attrib.can_mask)
-		return;
-
-	raw_spin_lock_irqsave(lock, flags);
-	desc->pci.msi_mask &= ~clear;
-	desc->pci.msi_mask |= set;
-	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->pci.mask_pos,
-			       desc->pci.msi_mask);
-	raw_spin_unlock_irqrestore(lock, flags);
-}
-
-static inline void pci_msi_mask(struct msi_desc *desc, u32 mask)
-{
-	pci_msi_update_mask(desc, 0, mask);
-}
-
-static inline void pci_msi_unmask(struct msi_desc *desc, u32 mask)
-{
-	pci_msi_update_mask(desc, mask, 0);
-}
-
-static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
-{
-	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
-}
-
-/*
- * This internal function does not flush PCI writes to the device.  All
- * users must ensure that they read from the device before either assuming
- * that the device state is up to date, or returning out of this file.
- * It does not affect the msi_desc::msix_ctrl cache either. Use with care!
- */
-static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
-{
-	void __iomem *desc_addr = pci_msix_desc_addr(desc);
-
-	if (desc->pci.msi_attrib.can_mask)
-		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
-}
-
-static inline void pci_msix_mask(struct msi_desc *desc)
-{
-	desc->pci.msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
-	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
-	/* Flush write to device */
-	readl(desc->pci.mask_base);
-}
-
-static inline void pci_msix_unmask(struct msi_desc *desc)
-{
-	desc->pci.msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
-	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
-}
-
-static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
-{
-	if (desc->pci.msi_attrib.is_msix)
-		pci_msix_mask(desc);
-	else
-		pci_msi_mask(desc, mask);
-}
-
-static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
-{
-	if (desc->pci.msi_attrib.is_msix)
-		pci_msix_unmask(desc);
-	else
-		pci_msi_unmask(desc, mask);
-}
-
-/**
- * pci_msi_mask_irq - Generic IRQ chip callback to mask PCI/MSI interrupts
- * @data:	pointer to irqdata associated to that interrupt
- */
-void pci_msi_mask_irq(struct irq_data *data)
-{
-	struct msi_desc *desc = irq_data_get_msi_desc(data);
-
-	__pci_msi_mask_desc(desc, BIT(data->irq - desc->irq));
-}
-EXPORT_SYMBOL_GPL(pci_msi_mask_irq);
-
-/**
- * pci_msi_unmask_irq - Generic IRQ chip callback to unmask PCI/MSI interrupts
- * @data:	pointer to irqdata associated to that interrupt
- */
-void pci_msi_unmask_irq(struct irq_data *data)
-{
-	struct msi_desc *desc = irq_data_get_msi_desc(data);
-
-	__pci_msi_unmask_desc(desc, BIT(data->irq - desc->irq));
-}
-EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
-
-void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
-{
-	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
-
-	BUG_ON(dev->current_state != PCI_D0);
-
-	if (entry->pci.msi_attrib.is_msix) {
-		void __iomem *base = pci_msix_desc_addr(entry);
-
-		if (WARN_ON_ONCE(entry->pci.msi_attrib.is_virtual))
-			return;
-
-		msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR);
-		msg->address_hi = readl(base + PCI_MSIX_ENTRY_UPPER_ADDR);
-		msg->data = readl(base + PCI_MSIX_ENTRY_DATA);
-	} else {
-		int pos = dev->msi_cap;
-		u16 data;
-
-		pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
-				      &msg->address_lo);
-		if (entry->pci.msi_attrib.is_64) {
-			pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
-					      &msg->address_hi);
-			pci_read_config_word(dev, pos + PCI_MSI_DATA_64, &data);
-		} else {
-			msg->address_hi = 0;
-			pci_read_config_word(dev, pos + PCI_MSI_DATA_32, &data);
-		}
-		msg->data = data;
-	}
-}
-
-void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
-{
-	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
-
-	if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
-		/* Don't touch the hardware now */
-	} else if (entry->pci.msi_attrib.is_msix) {
-		void __iomem *base = pci_msix_desc_addr(entry);
-		u32 ctrl = entry->pci.msix_ctrl;
-		bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
-
-		if (entry->pci.msi_attrib.is_virtual)
-			goto skip;
-
-		/*
-		 * The specification mandates that the entry is masked
-		 * when the message is modified:
-		 *
-		 * "If software changes the Address or Data value of an
-		 * entry while the entry is unmasked, the result is
-		 * undefined."
-		 */
-		if (unmasked)
-			pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
-
-		writel(msg->address_lo, base + PCI_MSIX_ENTRY_LOWER_ADDR);
-		writel(msg->address_hi, base + PCI_MSIX_ENTRY_UPPER_ADDR);
-		writel(msg->data, base + PCI_MSIX_ENTRY_DATA);
-
-		if (unmasked)
-			pci_msix_write_vector_ctrl(entry, ctrl);
-
-		/* Ensure that the writes are visible in the device */
-		readl(base + PCI_MSIX_ENTRY_DATA);
-	} else {
-		int pos = dev->msi_cap;
-		u16 msgctl;
-
-		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
-		msgctl &= ~PCI_MSI_FLAGS_QSIZE;
-		msgctl |= entry->pci.msi_attrib.multiple << 4;
-		pci_write_config_word(dev, pos + PCI_MSI_FLAGS, msgctl);
-
-		pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
-				       msg->address_lo);
-		if (entry->pci.msi_attrib.is_64) {
-			pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
-					       msg->address_hi);
-			pci_write_config_word(dev, pos + PCI_MSI_DATA_64,
-					      msg->data);
-		} else {
-			pci_write_config_word(dev, pos + PCI_MSI_DATA_32,
-					      msg->data);
-		}
-		/* Ensure that the writes are visible in the device */
-		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
-	}
-
-skip:
-	entry->msg = *msg;
-
-	if (entry->write_msi_msg)
-		entry->write_msi_msg(entry, entry->write_msi_msg_data);
-
-}
-
-void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
-{
-	struct msi_desc *entry = irq_get_msi_desc(irq);
-
-	__pci_write_msi_msg(entry, msg);
-}
-EXPORT_SYMBOL_GPL(pci_write_msi_msg);
-
-static void free_msi_irqs(struct pci_dev *dev)
-{
-	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
-	struct msi_desc *entry, *tmp;
-	int i;
-
-	for_each_pci_msi_entry(entry, dev)
-		if (entry->irq)
-			for (i = 0; i < entry->nvec_used; i++)
-				BUG_ON(irq_has_action(entry->irq + i));
-
-	if (dev->msi_irq_groups) {
-		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
-		dev->msi_irq_groups = NULL;
-	}
-
-	pci_msi_teardown_msi_irqs(dev);
-
-	list_for_each_entry_safe(entry, tmp, msi_list, list) {
-		if (entry->pci.msi_attrib.is_msix) {
-			if (list_is_last(&entry->list, msi_list))
-				iounmap(entry->pci.mask_base);
-		}
-
-		list_del(&entry->list);
-		free_msi_entry(entry);
-	}
-}
-
-static void pci_intx_for_msi(struct pci_dev *dev, int enable)
-{
-	if (!(dev->dev_flags & PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG))
-		pci_intx(dev, enable);
-}
-
-static void pci_msi_set_enable(struct pci_dev *dev, int enable)
-{
-	u16 control;
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	control &= ~PCI_MSI_FLAGS_ENABLE;
-	if (enable)
-		control |= PCI_MSI_FLAGS_ENABLE;
-	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
-}
-
-/*
- * Architecture override returns true when the PCI MSI message should be
- * written by the generic restore function.
- */
-bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
-{
-	return true;
-}
-
-static void __pci_restore_msi_state(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-	u16 control;
-
-	if (!dev->msi_enabled)
-		return;
-
-	entry = irq_get_msi_desc(dev->irq);
-
-	pci_intx_for_msi(dev, 0);
-	pci_msi_set_enable(dev, 0);
-	if (arch_restore_msi_irqs(dev))
-		__pci_write_msi_msg(entry, &entry->msg);
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	pci_msi_update_mask(entry, 0, 0);
-	control &= ~PCI_MSI_FLAGS_QSIZE;
-	control |= (entry->pci.msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
-	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
-}
-
-static void pci_msix_clear_and_set_ctrl(struct pci_dev *dev, u16 clear, u16 set)
-{
-	u16 ctrl;
-
-	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
-	ctrl &= ~clear;
-	ctrl |= set;
-	pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, ctrl);
-}
-
-static void __pci_restore_msix_state(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-	bool write_msg;
-
-	if (!dev->msix_enabled)
-		return;
-	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
-
-	/* route the table */
-	pci_intx_for_msi(dev, 0);
-	pci_msix_clear_and_set_ctrl(dev, 0,
-				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
-
-	write_msg = arch_restore_msi_irqs(dev);
-
-	for_each_pci_msi_entry(entry, dev) {
-		if (write_msg)
-			__pci_write_msi_msg(entry, &entry->msg);
-		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
-	}
-
-	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
-}
-
-void pci_restore_msi_state(struct pci_dev *dev)
-{
-	__pci_restore_msi_state(dev);
-	__pci_restore_msix_state(dev);
-}
-EXPORT_SYMBOL_GPL(pci_restore_msi_state);
-
-static struct msi_desc *
-msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
-{
-	struct irq_affinity_desc *masks = NULL;
-	struct msi_desc *entry;
-	u16 control;
-
-	if (affd)
-		masks = irq_create_affinity_masks(nvec, affd);
-
-	/* MSI Entry Initialization */
-	entry = alloc_msi_entry(&dev->dev, nvec, masks);
-	if (!entry)
-		goto out;
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
-	/* Lies, damned lies, and MSIs */
-	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
-		control |= PCI_MSI_FLAGS_MASKBIT;
-
-	entry->pci.msi_attrib.is_msix	= 0;
-	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
-	entry->pci.msi_attrib.is_virtual    = 0;
-	entry->pci.msi_attrib.entry_nr	= 0;
-	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
-					  !!(control & PCI_MSI_FLAGS_MASKBIT);
-	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
-	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
-	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
-
-	if (control & PCI_MSI_FLAGS_64BIT)
-		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
-	else
-		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
-
-	/* Save the initial mask status */
-	if (entry->pci.msi_attrib.can_mask)
-		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
-
-out:
-	kfree(masks);
-	return entry;
-}
-
-static int msi_verify_entries(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-
-	if (!dev->no_64bit_msi)
-		return 0;
-
-	for_each_pci_msi_entry(entry, dev) {
-		if (entry->msg.address_hi) {
-			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
-				entry->msg.address_hi, entry->msg.address_lo);
-			return -EIO;
-		}
-	}
-	return 0;
-}
-
-/**
- * msi_capability_init - configure device's MSI capability structure
- * @dev: pointer to the pci_dev data structure of MSI device function
- * @nvec: number of interrupts to allocate
- * @affd: description of automatic IRQ affinity assignments (may be %NULL)
- *
- * Setup the MSI capability structure of the device with the requested
- * number of interrupts.  A return value of zero indicates the successful
- * setup of an entry with the new MSI IRQ.  A negative return value indicates
- * an error, and a positive return value indicates the number of interrupts
- * which could have been allocated.
- */
-static int msi_capability_init(struct pci_dev *dev, int nvec,
-			       struct irq_affinity *affd)
-{
-	const struct attribute_group **groups;
-	struct msi_desc *entry;
-	int ret;
-
-	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
-
-	entry = msi_setup_entry(dev, nvec, affd);
-	if (!entry)
-		return -ENOMEM;
-
-	/* All MSIs are unmasked by default; mask them all */
-	pci_msi_mask(entry, msi_multi_mask(entry));
-
-	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
-
-	/* Configure MSI capability structure */
-	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
-	if (ret)
-		goto err;
-
-	ret = msi_verify_entries(dev);
-	if (ret)
-		goto err;
-
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto err;
-	}
-
-	dev->msi_irq_groups = groups;
-
-	/* Set MSI enabled bits	*/
-	pci_intx_for_msi(dev, 0);
-	pci_msi_set_enable(dev, 1);
-	dev->msi_enabled = 1;
-
-	pcibios_free_irq(dev);
-	dev->irq = entry->irq;
-	return 0;
-
-err:
-	pci_msi_unmask(entry, msi_multi_mask(entry));
-	free_msi_irqs(dev);
-	return ret;
-}
-
-static void __iomem *msix_map_region(struct pci_dev *dev,
-				     unsigned int nr_entries)
-{
-	resource_size_t phys_addr;
-	u32 table_offset;
-	unsigned long flags;
-	u8 bir;
-
-	pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,
-			      &table_offset);
-	bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);
-	flags = pci_resource_flags(dev, bir);
-	if (!flags || (flags & IORESOURCE_UNSET))
-		return NULL;
-
-	table_offset &= PCI_MSIX_TABLE_OFFSET;
-	phys_addr = pci_resource_start(dev, bir) + table_offset;
-
-	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
-}
-
-static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
-			      struct msix_entry *entries, int nvec,
-			      struct irq_affinity *affd)
-{
-	struct irq_affinity_desc *curmsk, *masks = NULL;
-	struct msi_desc *entry;
-	void __iomem *addr;
-	int ret, i;
-	int vec_count = pci_msix_vec_count(dev);
-
-	if (affd)
-		masks = irq_create_affinity_masks(nvec, affd);
-
-	for (i = 0, curmsk = masks; i < nvec; i++) {
-		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
-		if (!entry) {
-			if (!i)
-				iounmap(base);
-			else
-				free_msi_irqs(dev);
-			/* No enough memory. Don't try again */
-			ret = -ENOMEM;
-			goto out;
-		}
-
-		entry->pci.msi_attrib.is_msix	= 1;
-		entry->pci.msi_attrib.is_64	= 1;
-
-		if (entries)
-			entry->pci.msi_attrib.entry_nr = entries[i].entry;
-		else
-			entry->pci.msi_attrib.entry_nr = i;
-
-		entry->pci.msi_attrib.is_virtual =
-			entry->pci.msi_attrib.entry_nr >= vec_count;
-
-		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
-						  !entry->pci.msi_attrib.is_virtual;
-
-		entry->pci.msi_attrib.default_irq	= dev->irq;
-		entry->pci.mask_base			= base;
-
-		if (entry->pci.msi_attrib.can_mask) {
-			addr = pci_msix_desc_addr(entry);
-			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
-		}
-
-		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
-		if (masks)
-			curmsk++;
-	}
-	ret = 0;
-out:
-	kfree(masks);
-	return ret;
-}
-
-static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
-{
-	struct msi_desc *entry;
-
-	if (entries) {
-		for_each_pci_msi_entry(entry, dev) {
-			entries->vector = entry->irq;
-			entries++;
-		}
-	}
-}
-
-static void msix_mask_all(void __iomem *base, int tsize)
-{
-	u32 ctrl = PCI_MSIX_ENTRY_CTRL_MASKBIT;
-	int i;
-
-	if (pci_msi_ignore_mask)
-		return;
-
-	for (i = 0; i < tsize; i++, base += PCI_MSIX_ENTRY_SIZE)
-		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
-}
-
-/**
- * msix_capability_init - configure device's MSI-X capability
- * @dev: pointer to the pci_dev data structure of MSI-X device function
- * @entries: pointer to an array of struct msix_entry entries
- * @nvec: number of @entries
- * @affd: Optional pointer to enable automatic affinity assignment
- *
- * Setup the MSI-X capability structure of device function with a
- * single MSI-X IRQ. A return of zero indicates the successful setup of
- * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
- **/
-static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
-				int nvec, struct irq_affinity *affd)
-{
-	const struct attribute_group **groups;
-	void __iomem *base;
-	int ret, tsize;
-	u16 control;
-
-	/*
-	 * Some devices require MSI-X to be enabled before the MSI-X
-	 * registers can be accessed.  Mask all the vectors to prevent
-	 * interrupts coming in before they're fully set up.
-	 */
-	pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
-				    PCI_MSIX_FLAGS_ENABLE);
-
-	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
-	/* Request & Map MSI-X table region */
-	tsize = msix_table_size(control);
-	base = msix_map_region(dev, tsize);
-	if (!base) {
-		ret = -ENOMEM;
-		goto out_disable;
-	}
-
-	/* Ensure that all table entries are masked. */
-	msix_mask_all(base, tsize);
-
-	ret = msix_setup_entries(dev, base, entries, nvec, affd);
-	if (ret)
-		goto out_disable;
-
-	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
-	if (ret)
-		goto out_avail;
-
-	/* Check if all MSI entries honor device restrictions */
-	ret = msi_verify_entries(dev);
-	if (ret)
-		goto out_free;
-
-	msix_update_entries(dev, entries);
-
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto out_free;
-	}
-
-	dev->msi_irq_groups = groups;
-
-	/* Set MSI-X enabled bits and unmask the function */
-	pci_intx_for_msi(dev, 0);
-	dev->msix_enabled = 1;
-	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
-
-	pcibios_free_irq(dev);
-	return 0;
-
-out_avail:
-	if (ret < 0) {
-		/*
-		 * If we had some success, report the number of IRQs
-		 * we succeeded in setting up.
-		 */
-		struct msi_desc *entry;
-		int avail = 0;
-
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->irq != 0)
-				avail++;
-		}
-		if (avail != 0)
-			ret = avail;
-	}
-
-out_free:
-	free_msi_irqs(dev);
-
-out_disable:
-	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
-
-	return ret;
-}
-
-/**
- * pci_msi_supported - check whether MSI may be enabled on a device
- * @dev: pointer to the pci_dev data structure of MSI device function
- * @nvec: how many MSIs have been requested?
- *
- * Look at global flags, the device itself, and its parent buses
- * to determine if MSI/-X are supported for the device. If MSI/-X is
- * supported return 1, else return 0.
- **/
-static int pci_msi_supported(struct pci_dev *dev, int nvec)
-{
-	struct pci_bus *bus;
-
-	/* MSI must be globally enabled and supported by the device */
-	if (!pci_msi_enable)
-		return 0;
-
-	if (!dev || dev->no_msi)
-		return 0;
-
-	/*
-	 * You can't ask to have 0 or less MSIs configured.
-	 *  a) it's stupid ..
-	 *  b) the list manipulation code assumes nvec >= 1.
-	 */
-	if (nvec < 1)
-		return 0;
-
-	/*
-	 * Any bridge which does NOT route MSI transactions from its
-	 * secondary bus to its primary bus must set NO_MSI flag on
-	 * the secondary pci_bus.
-	 *
-	 * The NO_MSI flag can either be set directly by:
-	 * - arch-specific PCI host bus controller drivers (deprecated)
-	 * - quirks for specific PCI bridges
-	 *
-	 * or indirectly by platform-specific PCI host bridge drivers by
-	 * advertising the 'msi_domain' property, which results in
-	 * the NO_MSI flag when no MSI domain is found for this bridge
-	 * at probe time.
-	 */
-	for (bus = dev->bus; bus; bus = bus->parent)
-		if (bus->bus_flags & PCI_BUS_FLAGS_NO_MSI)
-			return 0;
-
-	return 1;
-}
-
-/**
- * pci_msi_vec_count - Return the number of MSI vectors a device can send
- * @dev: device to report about
- *
- * This function returns the number of MSI vectors a device requested via
- * Multiple Message Capable register. It returns a negative errno if the
- * device is not capable sending MSI interrupts. Otherwise, the call succeeds
- * and returns a power of two, up to a maximum of 2^5 (32), according to the
- * MSI specification.
- **/
-int pci_msi_vec_count(struct pci_dev *dev)
-{
-	int ret;
-	u16 msgctl;
-
-	if (!dev->msi_cap)
-		return -EINVAL;
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &msgctl);
-	ret = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
-
-	return ret;
-}
-EXPORT_SYMBOL(pci_msi_vec_count);
-
-static void pci_msi_shutdown(struct pci_dev *dev)
-{
-	struct msi_desc *desc;
-
-	if (!pci_msi_enable || !dev || !dev->msi_enabled)
-		return;
-
-	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
-	desc = first_pci_msi_entry(dev);
-
-	pci_msi_set_enable(dev, 0);
-	pci_intx_for_msi(dev, 1);
-	dev->msi_enabled = 0;
-
-	/* Return the device with MSI unmasked as initial states */
-	pci_msi_unmask(desc, msi_multi_mask(desc));
-
-	/* Restore dev->irq to its default pin-assertion IRQ */
-	dev->irq = desc->pci.msi_attrib.default_irq;
-	pcibios_alloc_irq(dev);
-}
-
-void pci_disable_msi(struct pci_dev *dev)
-{
-	if (!pci_msi_enable || !dev || !dev->msi_enabled)
-		return;
-
-	pci_msi_shutdown(dev);
-	free_msi_irqs(dev);
-}
-EXPORT_SYMBOL(pci_disable_msi);
-
-/**
- * pci_msix_vec_count - return the number of device's MSI-X table entries
- * @dev: pointer to the pci_dev data structure of MSI-X device function
- * This function returns the number of device's MSI-X table entries and
- * therefore the number of MSI-X vectors device is capable of sending.
- * It returns a negative errno if the device is not capable of sending MSI-X
- * interrupts.
- **/
-int pci_msix_vec_count(struct pci_dev *dev)
-{
-	u16 control;
-
-	if (!dev->msix_cap)
-		return -EINVAL;
-
-	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
-	return msix_table_size(control);
-}
-EXPORT_SYMBOL(pci_msix_vec_count);
-
-static int __pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries,
-			     int nvec, struct irq_affinity *affd, int flags)
-{
-	int nr_entries;
-	int i, j;
-
-	if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
-		return -EINVAL;
-
-	nr_entries = pci_msix_vec_count(dev);
-	if (nr_entries < 0)
-		return nr_entries;
-	if (nvec > nr_entries && !(flags & PCI_IRQ_VIRTUAL))
-		return nr_entries;
-
-	if (entries) {
-		/* Check for any invalid entries */
-		for (i = 0; i < nvec; i++) {
-			if (entries[i].entry >= nr_entries)
-				return -EINVAL;		/* invalid entry */
-			for (j = i + 1; j < nvec; j++) {
-				if (entries[i].entry == entries[j].entry)
-					return -EINVAL;	/* duplicate entry */
-			}
-		}
-	}
-
-	/* Check whether driver already requested for MSI IRQ */
-	if (dev->msi_enabled) {
-		pci_info(dev, "can't enable MSI-X (MSI IRQ already assigned)\n");
-		return -EINVAL;
-	}
-	return msix_capability_init(dev, entries, nvec, affd);
-}
-
-static void pci_msix_shutdown(struct pci_dev *dev)
-{
-	struct msi_desc *entry;
-
-	if (!pci_msi_enable || !dev || !dev->msix_enabled)
-		return;
-
-	if (pci_dev_is_disconnected(dev)) {
-		dev->msix_enabled = 0;
-		return;
-	}
-
-	/* Return the device with MSI-X masked as initial states */
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_mask(entry);
-
-	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
-	pci_intx_for_msi(dev, 1);
-	dev->msix_enabled = 0;
-	pcibios_alloc_irq(dev);
-}
-
-void pci_disable_msix(struct pci_dev *dev)
-{
-	if (!pci_msi_enable || !dev || !dev->msix_enabled)
-		return;
-
-	pci_msix_shutdown(dev);
-	free_msi_irqs(dev);
-}
-EXPORT_SYMBOL(pci_disable_msix);
-
-void pci_no_msi(void)
-{
-	pci_msi_enable = 0;
-}
-
-/**
- * pci_msi_enabled - is MSI enabled?
- *
- * Returns true if MSI has not been disabled by the command-line option
- * pci=nomsi.
- **/
-int pci_msi_enabled(void)
-{
-	return pci_msi_enable;
-}
-EXPORT_SYMBOL(pci_msi_enabled);
-
-static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
-				  struct irq_affinity *affd)
-{
-	int nvec;
-	int rc;
-
-	if (!pci_msi_supported(dev, minvec) || dev->current_state != PCI_D0)
-		return -EINVAL;
-
-	/* Check whether driver already requested MSI-X IRQs */
-	if (dev->msix_enabled) {
-		pci_info(dev, "can't enable MSI (MSI-X already enabled)\n");
-		return -EINVAL;
-	}
-
-	if (maxvec < minvec)
-		return -ERANGE;
-
-	if (WARN_ON_ONCE(dev->msi_enabled))
-		return -EINVAL;
-
-	nvec = pci_msi_vec_count(dev);
-	if (nvec < 0)
-		return nvec;
-	if (nvec < minvec)
-		return -ENOSPC;
-
-	if (nvec > maxvec)
-		nvec = maxvec;
-
-	for (;;) {
-		if (affd) {
-			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
-			if (nvec < minvec)
-				return -ENOSPC;
-		}
-
-		rc = msi_capability_init(dev, nvec, affd);
-		if (rc == 0)
-			return nvec;
-
-		if (rc < 0)
-			return rc;
-		if (rc < minvec)
-			return -ENOSPC;
-
-		nvec = rc;
-	}
-}
-
-/* deprecated, don't use */
-int pci_enable_msi(struct pci_dev *dev)
-{
-	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
-	if (rc < 0)
-		return rc;
-	return 0;
-}
-EXPORT_SYMBOL(pci_enable_msi);
-
-static int __pci_enable_msix_range(struct pci_dev *dev,
-				   struct msix_entry *entries, int minvec,
-				   int maxvec, struct irq_affinity *affd,
-				   int flags)
-{
-	int rc, nvec = maxvec;
-
-	if (maxvec < minvec)
-		return -ERANGE;
-
-	if (WARN_ON_ONCE(dev->msix_enabled))
-		return -EINVAL;
-
-	for (;;) {
-		if (affd) {
-			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
-			if (nvec < minvec)
-				return -ENOSPC;
-		}
-
-		rc = __pci_enable_msix(dev, entries, nvec, affd, flags);
-		if (rc == 0)
-			return nvec;
-
-		if (rc < 0)
-			return rc;
-		if (rc < minvec)
-			return -ENOSPC;
-
-		nvec = rc;
-	}
-}
-
-/**
- * pci_enable_msix_range - configure device's MSI-X capability structure
- * @dev: pointer to the pci_dev data structure of MSI-X device function
- * @entries: pointer to an array of MSI-X entries
- * @minvec: minimum number of MSI-X IRQs requested
- * @maxvec: maximum number of MSI-X IRQs requested
- *
- * Setup the MSI-X capability structure of device function with a maximum
- * possible number of interrupts in the range between @minvec and @maxvec
- * upon its software driver call to request for MSI-X mode enabled on its
- * hardware device function. It returns a negative errno if an error occurs.
- * If it succeeds, it returns the actual number of interrupts allocated and
- * indicates the successful configuration of MSI-X capability structure
- * with new allocated MSI-X interrupts.
- **/
-int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
-		int minvec, int maxvec)
-{
-	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
-}
-EXPORT_SYMBOL(pci_enable_msix_range);
-
-/**
- * pci_alloc_irq_vectors_affinity - allocate multiple IRQs for a device
- * @dev:		PCI device to operate on
- * @min_vecs:		minimum number of vectors required (must be >= 1)
- * @max_vecs:		maximum (desired) number of vectors
- * @flags:		flags or quirks for the allocation
- * @affd:		optional description of the affinity requirements
- *
- * Allocate up to @max_vecs interrupt vectors for @dev, using MSI-X or MSI
- * vectors if available, and fall back to a single legacy vector
- * if neither is available.  Return the number of vectors allocated,
- * (which might be smaller than @max_vecs) if successful, or a negative
- * error code on error. If less than @min_vecs interrupt vectors are
- * available for @dev the function will fail with -ENOSPC.
- *
- * To get the Linux IRQ number used for a vector that can be passed to
- * request_irq() use the pci_irq_vector() helper.
- */
-int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
-				   unsigned int max_vecs, unsigned int flags,
-				   struct irq_affinity *affd)
-{
-	struct irq_affinity msi_default_affd = {0};
-	int nvecs = -ENOSPC;
-
-	if (flags & PCI_IRQ_AFFINITY) {
-		if (!affd)
-			affd = &msi_default_affd;
-	} else {
-		if (WARN_ON(affd))
-			affd = NULL;
-	}
-
-	if (flags & PCI_IRQ_MSIX) {
-		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
-						affd, flags);
-		if (nvecs > 0)
-			return nvecs;
-	}
-
-	if (flags & PCI_IRQ_MSI) {
-		nvecs = __pci_enable_msi_range(dev, min_vecs, max_vecs, affd);
-		if (nvecs > 0)
-			return nvecs;
-	}
-
-	/* use legacy IRQ if allowed */
-	if (flags & PCI_IRQ_LEGACY) {
-		if (min_vecs == 1 && dev->irq) {
-			/*
-			 * Invoke the affinity spreading logic to ensure that
-			 * the device driver can adjust queue configuration
-			 * for the single interrupt case.
-			 */
-			if (affd)
-				irq_create_affinity_masks(1, affd);
-			pci_intx(dev, 1);
-			return 1;
-		}
-	}
-
-	return nvecs;
-}
-EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
-
-/**
- * pci_free_irq_vectors - free previously allocated IRQs for a device
- * @dev:		PCI device to operate on
- *
- * Undoes the allocations and enabling in pci_alloc_irq_vectors().
- */
-void pci_free_irq_vectors(struct pci_dev *dev)
-{
-	pci_disable_msix(dev);
-	pci_disable_msi(dev);
-}
-EXPORT_SYMBOL(pci_free_irq_vectors);
-
-/**
- * pci_irq_vector - return Linux IRQ number of a device vector
- * @dev:	PCI device to operate on
- * @nr:		Interrupt vector index (0-based)
- *
- * @nr has the following meanings depending on the interrupt mode:
- *   MSI-X:	The index in the MSI-X vector table
- *   MSI:	The index of the enabled MSI vectors
- *   INTx:	Must be 0
- *
- * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
- */
-int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
-{
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
-
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
-				return entry->irq;
-		}
-		WARN_ON_ONCE(1);
-		return -EINVAL;
-	}
-
-	if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
-
-		if (WARN_ON_ONCE(nr >= entry->nvec_used))
-			return -EINVAL;
-	} else {
-		if (WARN_ON_ONCE(nr > 0))
-			return -EINVAL;
-	}
-
-	return dev->irq + nr;
-}
-EXPORT_SYMBOL(pci_irq_vector);
-
-/**
- * pci_irq_get_affinity - return the affinity of a particular MSI vector
- * @dev:	PCI device to operate on
- * @nr:		device-relative interrupt vector index (0-based).
- *
- * @nr has the following meanings depending on the interrupt mode:
- *   MSI-X:	The index in the MSI-X vector table
- *   MSI:	The index of the enabled MSI vectors
- *   INTx:	Must be 0
- *
- * Return: A cpumask pointer or NULL if @nr is out of range
- */
-const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
-{
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
-
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
-				return &entry->affinity->mask;
-		}
-		WARN_ON_ONCE(1);
-		return NULL;
-	} else if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
-
-		if (WARN_ON_ONCE(!entry || !entry->affinity ||
-				 nr >= entry->nvec_used))
-			return NULL;
-
-		return &entry->affinity[nr].mask;
-	} else {
-		return cpu_possible_mask;
-	}
-}
-EXPORT_SYMBOL(pci_irq_get_affinity);
-
-struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
-{
-	return to_pci_dev(desc->dev);
-}
-EXPORT_SYMBOL(msi_desc_to_pci_dev);
-
-#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
-/**
- * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
- * @irq_data:	Pointer to interrupt data of the MSI interrupt
- * @msg:	Pointer to the message
- */
-static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
-{
-	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
-
-	/*
-	 * For MSI-X desc->irq is always equal to irq_data->irq. For
-	 * MSI only the first interrupt of MULTI MSI passes the test.
-	 */
-	if (desc->irq == irq_data->irq)
-		__pci_write_msi_msg(desc, msg);
-}
-
-/**
- * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
- * @desc:	Pointer to the MSI descriptor
- *
- * The ID number is only used within the irqdomain.
- */
-static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
-{
-	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
-
-	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
-		pci_dev_id(dev) << 11 |
-		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
-}
-
-static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
-{
-	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
-}
-
-/**
- * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
- * 			      for @dev
- * @domain:	The interrupt domain to check
- * @info:	The domain info for verification
- * @dev:	The device to check
- *
- * Returns:
- *  0 if the functionality is supported
- *  1 if Multi MSI is requested, but the domain does not support it
- *  -ENOTSUPP otherwise
- */
-int pci_msi_domain_check_cap(struct irq_domain *domain,
-			     struct msi_domain_info *info, struct device *dev)
-{
-	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
-
-	/* Special handling to support __pci_enable_msi_range() */
-	if (pci_msi_desc_is_multi_msi(desc) &&
-	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
-		return 1;
-	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
-		return -ENOTSUPP;
-
-	return 0;
-}
-
-static int pci_msi_domain_handle_error(struct irq_domain *domain,
-				       struct msi_desc *desc, int error)
-{
-	/* Special handling to support __pci_enable_msi_range() */
-	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
-		return 1;
-
-	return error;
-}
-
-static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
-				    struct msi_desc *desc)
-{
-	arg->desc = desc;
-	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
-}
-
-static struct msi_domain_ops pci_msi_domain_ops_default = {
-	.set_desc	= pci_msi_domain_set_desc,
-	.msi_check	= pci_msi_domain_check_cap,
-	.handle_error	= pci_msi_domain_handle_error,
-};
-
-static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
-{
-	struct msi_domain_ops *ops = info->ops;
-
-	if (ops == NULL) {
-		info->ops = &pci_msi_domain_ops_default;
-	} else {
-		if (ops->set_desc == NULL)
-			ops->set_desc = pci_msi_domain_set_desc;
-		if (ops->msi_check == NULL)
-			ops->msi_check = pci_msi_domain_check_cap;
-		if (ops->handle_error == NULL)
-			ops->handle_error = pci_msi_domain_handle_error;
-	}
-}
-
-static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
-{
-	struct irq_chip *chip = info->chip;
-
-	BUG_ON(!chip);
-	if (!chip->irq_write_msi_msg)
-		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
-	if (!chip->irq_mask)
-		chip->irq_mask = pci_msi_mask_irq;
-	if (!chip->irq_unmask)
-		chip->irq_unmask = pci_msi_unmask_irq;
-}
-
-/**
- * pci_msi_create_irq_domain - Create a MSI interrupt domain
- * @fwnode:	Optional fwnode of the interrupt controller
- * @info:	MSI domain info
- * @parent:	Parent irq domain
- *
- * Updates the domain and chip ops and creates a MSI interrupt domain.
- *
- * Returns:
- * A domain pointer or NULL in case of failure.
- */
-struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
-					     struct msi_domain_info *info,
-					     struct irq_domain *parent)
-{
-	struct irq_domain *domain;
-
-	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
-		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
-
-	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
-		pci_msi_domain_update_dom_ops(info);
-	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
-		pci_msi_domain_update_chip_ops(info);
-
-	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
-	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
-		info->flags |= MSI_FLAG_MUST_REACTIVATE;
-
-	/* PCI-MSI is oneshot-safe */
-	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
-
-	domain = msi_create_irq_domain(fwnode, info, parent);
-	if (!domain)
-		return NULL;
-
-	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
-	return domain;
-}
-EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
-
-/*
- * Users of the generic MSI infrastructure expect a device to have a single ID,
- * so with DMA aliases we have to pick the least-worst compromise. Devices with
- * DMA phantom functions tend to still emit MSIs from the real function number,
- * so we ignore those and only consider topological aliases where either the
- * alias device or RID appears on a different bus number. We also make the
- * reasonable assumption that bridges are walked in an upstream direction (so
- * the last one seen wins), and the much braver assumption that the most likely
- * case is that of PCI->PCIe so we should always use the alias RID. This echoes
- * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
- * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
- * for taking ownership all we can really do is close our eyes and hope...
- */
-static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
-{
-	u32 *pa = data;
-	u8 bus = PCI_BUS_NUM(*pa);
-
-	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
-		*pa = alias;
-
-	return 0;
-}
-
-/**
- * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
- * @domain:	The interrupt domain
- * @pdev:	The PCI device.
- *
- * The RID for a device is formed from the alias, with a firmware
- * supplied mapping applied
- *
- * Returns: The RID.
- */
-u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
-{
-	struct device_node *of_node;
-	u32 rid = pci_dev_id(pdev);
-
-	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
-
-	of_node = irq_domain_get_of_node(domain);
-	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
-			iort_msi_map_id(&pdev->dev, rid);
-
-	return rid;
-}
-
-/**
- * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
- * @pdev:	The PCI device
- *
- * Use the firmware data to find a device-specific MSI domain
- * (i.e. not one that is set as a default).
- *
- * Returns: The corresponding MSI domain or NULL if none has been found.
- */
-struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
-{
-	struct irq_domain *dom;
-	u32 rid = pci_dev_id(pdev);
-
-	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
-	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
-	if (!dom)
-		dom = iort_get_device_domain(&pdev->dev, rid,
-					     DOMAIN_BUS_PCI_MSI);
-	return dom;
-}
-
-/**
- * pci_dev_has_special_msi_domain - Check whether the device is handled by
- *				    a non-standard PCI-MSI domain
- * @pdev:	The PCI device to check.
- *
- * Returns: True if the device irqdomain or the bus irqdomain is
- * non-standard PCI/MSI.
- */
-bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
-{
-	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
-
-	if (!dom)
-		dom = dev_get_msi_domain(&pdev->bus->dev);
-
-	if (!dom)
-		return true;
-
-	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
-}
-
-#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
-#endif /* CONFIG_PCI_MSI */
-
-void pci_msi_init(struct pci_dev *dev)
-{
-	u16 ctrl;
-
-	/*
-	 * Disable the MSI hardware to avoid screaming interrupts
-	 * during boot.  This is the power on reset default so
-	 * usually this should be a noop.
-	 */
-	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
-	if (!dev->msi_cap)
-		return;
-
-	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
-	if (ctrl & PCI_MSI_FLAGS_ENABLE)
-		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
-				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
-
-	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
-		dev->no_64bit_msi = 1;
-}
-
-void pci_msix_init(struct pci_dev *dev)
-{
-	u16 ctrl;
-
-	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
-	if (!dev->msix_cap)
-		return;
-
-	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
-	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
-		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
-				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
-}
--- /dev/null
+++ b/drivers/pci/msi/Makefile
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for the PCI/MSI
+obj-$(CONFIG_PCI)		+= msi.o
--- /dev/null
+++ b/drivers/pci/msi/msi.c
@@ -0,0 +1,1532 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * PCI Message Signaled Interrupt (MSI)
+ *
+ * Copyright (C) 2003-2004 Intel
+ * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
+ * Copyright (C) 2016 Christoph Hellwig.
+ */
+
+#include <linux/acpi_iort.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/irq.h>
+#include <linux/irqdomain.h>
+#include <linux/msi.h>
+#include <linux/of_irq.h>
+#include <linux/pci.h>
+
+#include "../pci.h"
+
+#ifdef CONFIG_PCI_MSI
+
+static int pci_msi_enable = 1;
+int pci_msi_ignore_mask;
+
+#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
+
+#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
+static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	struct irq_domain *domain;
+
+	domain = dev_get_msi_domain(&dev->dev);
+	if (domain && irq_domain_is_hierarchy(domain))
+		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
+
+	return arch_setup_msi_irqs(dev, nvec, type);
+}
+
+static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
+{
+	struct irq_domain *domain;
+
+	domain = dev_get_msi_domain(&dev->dev);
+	if (domain && irq_domain_is_hierarchy(domain))
+		msi_domain_free_irqs(domain, &dev->dev);
+	else
+		arch_teardown_msi_irqs(dev);
+}
+#else
+#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
+#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
+#endif
+
+#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
+/* Arch hooks */
+int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
+{
+	return -EINVAL;
+}
+
+void __weak arch_teardown_msi_irq(unsigned int irq)
+{
+}
+
+int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
+{
+	struct msi_desc *entry;
+	int ret;
+
+	/*
+	 * If an architecture wants to support multiple MSI, it needs to
+	 * override arch_setup_msi_irqs()
+	 */
+	if (type == PCI_CAP_ID_MSI && nvec > 1)
+		return 1;
+
+	for_each_pci_msi_entry(entry, dev) {
+		ret = arch_setup_msi_irq(dev, entry);
+		if (ret < 0)
+			return ret;
+		if (ret > 0)
+			return -ENOSPC;
+	}
+
+	return 0;
+}
+
+void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
+{
+	int i;
+	struct msi_desc *entry;
+
+	for_each_pci_msi_entry(entry, dev)
+		if (entry->irq)
+			for (i = 0; i < entry->nvec_used; i++)
+				arch_teardown_msi_irq(entry->irq + i);
+}
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
+
+/*
+ * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
+ * mask all MSI interrupts by clearing the MSI enable bit does not work
+ * reliably as devices without an INTx disable bit will then generate a
+ * level IRQ which will never be cleared.
+ */
+static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
+{
+	/* Don't shift by >= width of type */
+	if (desc->pci.msi_attrib.multi_cap >= 5)
+		return 0xffffffff;
+	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
+}
+
+static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
+{
+	raw_spinlock_t *lock = &desc->dev->msi_lock;
+	unsigned long flags;
+
+	if (!desc->pci.msi_attrib.can_mask)
+		return;
+
+	raw_spin_lock_irqsave(lock, flags);
+	desc->pci.msi_mask &= ~clear;
+	desc->pci.msi_mask |= set;
+	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->pci.mask_pos,
+			       desc->pci.msi_mask);
+	raw_spin_unlock_irqrestore(lock, flags);
+}
+
+static inline void pci_msi_mask(struct msi_desc *desc, u32 mask)
+{
+	pci_msi_update_mask(desc, 0, mask);
+}
+
+static inline void pci_msi_unmask(struct msi_desc *desc, u32 mask)
+{
+	pci_msi_update_mask(desc, mask, 0);
+}
+
+static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
+{
+	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
+}
+
+/*
+ * This internal function does not flush PCI writes to the device.  All
+ * users must ensure that they read from the device before either assuming
+ * that the device state is up to date, or returning out of this file.
+ * It does not affect the msi_desc::msix_ctrl cache either. Use with care!
+ */
+static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
+{
+	void __iomem *desc_addr = pci_msix_desc_addr(desc);
+
+	if (desc->pci.msi_attrib.can_mask)
+		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
+}
+
+static inline void pci_msix_mask(struct msi_desc *desc)
+{
+	desc->pci.msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
+	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
+	/* Flush write to device */
+	readl(desc->pci.mask_base);
+}
+
+static inline void pci_msix_unmask(struct msi_desc *desc)
+{
+	desc->pci.msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
+	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
+}
+
+static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
+{
+	if (desc->pci.msi_attrib.is_msix)
+		pci_msix_mask(desc);
+	else
+		pci_msi_mask(desc, mask);
+}
+
+static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
+{
+	if (desc->pci.msi_attrib.is_msix)
+		pci_msix_unmask(desc);
+	else
+		pci_msi_unmask(desc, mask);
+}
+
+/**
+ * pci_msi_mask_irq - Generic IRQ chip callback to mask PCI/MSI interrupts
+ * @data:	pointer to irqdata associated to that interrupt
+ */
+void pci_msi_mask_irq(struct irq_data *data)
+{
+	struct msi_desc *desc = irq_data_get_msi_desc(data);
+
+	__pci_msi_mask_desc(desc, BIT(data->irq - desc->irq));
+}
+EXPORT_SYMBOL_GPL(pci_msi_mask_irq);
+
+/**
+ * pci_msi_unmask_irq - Generic IRQ chip callback to unmask PCI/MSI interrupts
+ * @data:	pointer to irqdata associated to that interrupt
+ */
+void pci_msi_unmask_irq(struct irq_data *data)
+{
+	struct msi_desc *desc = irq_data_get_msi_desc(data);
+
+	__pci_msi_unmask_desc(desc, BIT(data->irq - desc->irq));
+}
+EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
+
+void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
+{
+	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
+
+	BUG_ON(dev->current_state != PCI_D0);
+
+	if (entry->pci.msi_attrib.is_msix) {
+		void __iomem *base = pci_msix_desc_addr(entry);
+
+		if (WARN_ON_ONCE(entry->pci.msi_attrib.is_virtual))
+			return;
+
+		msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR);
+		msg->address_hi = readl(base + PCI_MSIX_ENTRY_UPPER_ADDR);
+		msg->data = readl(base + PCI_MSIX_ENTRY_DATA);
+	} else {
+		int pos = dev->msi_cap;
+		u16 data;
+
+		pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
+				      &msg->address_lo);
+		if (entry->pci.msi_attrib.is_64) {
+			pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
+					      &msg->address_hi);
+			pci_read_config_word(dev, pos + PCI_MSI_DATA_64, &data);
+		} else {
+			msg->address_hi = 0;
+			pci_read_config_word(dev, pos + PCI_MSI_DATA_32, &data);
+		}
+		msg->data = data;
+	}
+}
+
+void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
+{
+	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
+
+	if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
+		/* Don't touch the hardware now */
+	} else if (entry->pci.msi_attrib.is_msix) {
+		void __iomem *base = pci_msix_desc_addr(entry);
+		u32 ctrl = entry->pci.msix_ctrl;
+		bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
+
+		if (entry->pci.msi_attrib.is_virtual)
+			goto skip;
+
+		/*
+		 * The specification mandates that the entry is masked
+		 * when the message is modified:
+		 *
+		 * "If software changes the Address or Data value of an
+		 * entry while the entry is unmasked, the result is
+		 * undefined."
+		 */
+		if (unmasked)
+			pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
+
+		writel(msg->address_lo, base + PCI_MSIX_ENTRY_LOWER_ADDR);
+		writel(msg->address_hi, base + PCI_MSIX_ENTRY_UPPER_ADDR);
+		writel(msg->data, base + PCI_MSIX_ENTRY_DATA);
+
+		if (unmasked)
+			pci_msix_write_vector_ctrl(entry, ctrl);
+
+		/* Ensure that the writes are visible in the device */
+		readl(base + PCI_MSIX_ENTRY_DATA);
+	} else {
+		int pos = dev->msi_cap;
+		u16 msgctl;
+
+		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
+		msgctl &= ~PCI_MSI_FLAGS_QSIZE;
+		msgctl |= entry->pci.msi_attrib.multiple << 4;
+		pci_write_config_word(dev, pos + PCI_MSI_FLAGS, msgctl);
+
+		pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
+				       msg->address_lo);
+		if (entry->pci.msi_attrib.is_64) {
+			pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
+					       msg->address_hi);
+			pci_write_config_word(dev, pos + PCI_MSI_DATA_64,
+					      msg->data);
+		} else {
+			pci_write_config_word(dev, pos + PCI_MSI_DATA_32,
+					      msg->data);
+		}
+		/* Ensure that the writes are visible in the device */
+		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
+	}
+
+skip:
+	entry->msg = *msg;
+
+	if (entry->write_msi_msg)
+		entry->write_msi_msg(entry, entry->write_msi_msg_data);
+
+}
+
+void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
+{
+	struct msi_desc *entry = irq_get_msi_desc(irq);
+
+	__pci_write_msi_msg(entry, msg);
+}
+EXPORT_SYMBOL_GPL(pci_write_msi_msg);
+
+static void free_msi_irqs(struct pci_dev *dev)
+{
+	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
+	struct msi_desc *entry, *tmp;
+	int i;
+
+	for_each_pci_msi_entry(entry, dev)
+		if (entry->irq)
+			for (i = 0; i < entry->nvec_used; i++)
+				BUG_ON(irq_has_action(entry->irq + i));
+
+	if (dev->msi_irq_groups) {
+		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
+		dev->msi_irq_groups = NULL;
+	}
+
+	pci_msi_teardown_msi_irqs(dev);
+
+	list_for_each_entry_safe(entry, tmp, msi_list, list) {
+		if (entry->pci.msi_attrib.is_msix) {
+			if (list_is_last(&entry->list, msi_list))
+				iounmap(entry->pci.mask_base);
+		}
+
+		list_del(&entry->list);
+		free_msi_entry(entry);
+	}
+}
+
+static void pci_intx_for_msi(struct pci_dev *dev, int enable)
+{
+	if (!(dev->dev_flags & PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG))
+		pci_intx(dev, enable);
+}
+
+static void pci_msi_set_enable(struct pci_dev *dev, int enable)
+{
+	u16 control;
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
+	control &= ~PCI_MSI_FLAGS_ENABLE;
+	if (enable)
+		control |= PCI_MSI_FLAGS_ENABLE;
+	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
+}
+
+/*
+ * Architecture override returns true when the PCI MSI message should be
+ * written by the generic restore function.
+ */
+bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
+{
+	return true;
+}
+
+static void __pci_restore_msi_state(struct pci_dev *dev)
+{
+	struct msi_desc *entry;
+	u16 control;
+
+	if (!dev->msi_enabled)
+		return;
+
+	entry = irq_get_msi_desc(dev->irq);
+
+	pci_intx_for_msi(dev, 0);
+	pci_msi_set_enable(dev, 0);
+	if (arch_restore_msi_irqs(dev))
+		__pci_write_msi_msg(entry, &entry->msg);
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
+	pci_msi_update_mask(entry, 0, 0);
+	control &= ~PCI_MSI_FLAGS_QSIZE;
+	control |= (entry->pci.msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
+	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
+}
+
+static void pci_msix_clear_and_set_ctrl(struct pci_dev *dev, u16 clear, u16 set)
+{
+	u16 ctrl;
+
+	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
+	ctrl &= ~clear;
+	ctrl |= set;
+	pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, ctrl);
+}
+
+static void __pci_restore_msix_state(struct pci_dev *dev)
+{
+	struct msi_desc *entry;
+	bool write_msg;
+
+	if (!dev->msix_enabled)
+		return;
+	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
+
+	/* route the table */
+	pci_intx_for_msi(dev, 0);
+	pci_msix_clear_and_set_ctrl(dev, 0,
+				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
+
+	write_msg = arch_restore_msi_irqs(dev);
+
+	for_each_pci_msi_entry(entry, dev) {
+		if (write_msg)
+			__pci_write_msi_msg(entry, &entry->msg);
+		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
+	}
+
+	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
+}
+
+void pci_restore_msi_state(struct pci_dev *dev)
+{
+	__pci_restore_msi_state(dev);
+	__pci_restore_msix_state(dev);
+}
+EXPORT_SYMBOL_GPL(pci_restore_msi_state);
+
+static struct msi_desc *
+msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
+{
+	struct irq_affinity_desc *masks = NULL;
+	struct msi_desc *entry;
+	u16 control;
+
+	if (affd)
+		masks = irq_create_affinity_masks(nvec, affd);
+
+	/* MSI Entry Initialization */
+	entry = alloc_msi_entry(&dev->dev, nvec, masks);
+	if (!entry)
+		goto out;
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
+	/* Lies, damned lies, and MSIs */
+	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
+		control |= PCI_MSI_FLAGS_MASKBIT;
+
+	entry->pci.msi_attrib.is_msix	= 0;
+	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
+	entry->pci.msi_attrib.is_virtual    = 0;
+	entry->pci.msi_attrib.entry_nr	= 0;
+	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+					  !!(control & PCI_MSI_FLAGS_MASKBIT);
+	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
+	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
+	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
+
+	if (control & PCI_MSI_FLAGS_64BIT)
+		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
+	else
+		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
+
+	/* Save the initial mask status */
+	if (entry->pci.msi_attrib.can_mask)
+		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
+
+out:
+	kfree(masks);
+	return entry;
+}
+
+static int msi_verify_entries(struct pci_dev *dev)
+{
+	struct msi_desc *entry;
+
+	if (!dev->no_64bit_msi)
+		return 0;
+
+	for_each_pci_msi_entry(entry, dev) {
+		if (entry->msg.address_hi) {
+			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
+				entry->msg.address_hi, entry->msg.address_lo);
+			return -EIO;
+		}
+	}
+	return 0;
+}
+
+/**
+ * msi_capability_init - configure device's MSI capability structure
+ * @dev: pointer to the pci_dev data structure of MSI device function
+ * @nvec: number of interrupts to allocate
+ * @affd: description of automatic IRQ affinity assignments (may be %NULL)
+ *
+ * Setup the MSI capability structure of the device with the requested
+ * number of interrupts.  A return value of zero indicates the successful
+ * setup of an entry with the new MSI IRQ.  A negative return value indicates
+ * an error, and a positive return value indicates the number of interrupts
+ * which could have been allocated.
+ */
+static int msi_capability_init(struct pci_dev *dev, int nvec,
+			       struct irq_affinity *affd)
+{
+	const struct attribute_group **groups;
+	struct msi_desc *entry;
+	int ret;
+
+	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
+
+	entry = msi_setup_entry(dev, nvec, affd);
+	if (!entry)
+		return -ENOMEM;
+
+	/* All MSIs are unmasked by default; mask them all */
+	pci_msi_mask(entry, msi_multi_mask(entry));
+
+	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
+
+	/* Configure MSI capability structure */
+	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
+	if (ret)
+		goto err;
+
+	ret = msi_verify_entries(dev);
+	if (ret)
+		goto err;
+
+	groups = msi_populate_sysfs(&dev->dev);
+	if (IS_ERR(groups)) {
+		ret = PTR_ERR(groups);
+		goto err;
+	}
+
+	dev->msi_irq_groups = groups;
+
+	/* Set MSI enabled bits	*/
+	pci_intx_for_msi(dev, 0);
+	pci_msi_set_enable(dev, 1);
+	dev->msi_enabled = 1;
+
+	pcibios_free_irq(dev);
+	dev->irq = entry->irq;
+	return 0;
+
+err:
+	pci_msi_unmask(entry, msi_multi_mask(entry));
+	free_msi_irqs(dev);
+	return ret;
+}
+
+static void __iomem *msix_map_region(struct pci_dev *dev,
+				     unsigned int nr_entries)
+{
+	resource_size_t phys_addr;
+	u32 table_offset;
+	unsigned long flags;
+	u8 bir;
+
+	pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,
+			      &table_offset);
+	bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);
+	flags = pci_resource_flags(dev, bir);
+	if (!flags || (flags & IORESOURCE_UNSET))
+		return NULL;
+
+	table_offset &= PCI_MSIX_TABLE_OFFSET;
+	phys_addr = pci_resource_start(dev, bir) + table_offset;
+
+	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
+}
+
+static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
+			      struct msix_entry *entries, int nvec,
+			      struct irq_affinity *affd)
+{
+	struct irq_affinity_desc *curmsk, *masks = NULL;
+	struct msi_desc *entry;
+	void __iomem *addr;
+	int ret, i;
+	int vec_count = pci_msix_vec_count(dev);
+
+	if (affd)
+		masks = irq_create_affinity_masks(nvec, affd);
+
+	for (i = 0, curmsk = masks; i < nvec; i++) {
+		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
+		if (!entry) {
+			if (!i)
+				iounmap(base);
+			else
+				free_msi_irqs(dev);
+			/* No enough memory. Don't try again */
+			ret = -ENOMEM;
+			goto out;
+		}
+
+		entry->pci.msi_attrib.is_msix	= 1;
+		entry->pci.msi_attrib.is_64	= 1;
+
+		if (entries)
+			entry->pci.msi_attrib.entry_nr = entries[i].entry;
+		else
+			entry->pci.msi_attrib.entry_nr = i;
+
+		entry->pci.msi_attrib.is_virtual =
+			entry->pci.msi_attrib.entry_nr >= vec_count;
+
+		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
+						  !entry->pci.msi_attrib.is_virtual;
+
+		entry->pci.msi_attrib.default_irq	= dev->irq;
+		entry->pci.mask_base			= base;
+
+		if (entry->pci.msi_attrib.can_mask) {
+			addr = pci_msix_desc_addr(entry);
+			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
+		}
+
+		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
+		if (masks)
+			curmsk++;
+	}
+	ret = 0;
+out:
+	kfree(masks);
+	return ret;
+}
+
+static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
+{
+	struct msi_desc *entry;
+
+	if (entries) {
+		for_each_pci_msi_entry(entry, dev) {
+			entries->vector = entry->irq;
+			entries++;
+		}
+	}
+}
+
+static void msix_mask_all(void __iomem *base, int tsize)
+{
+	u32 ctrl = PCI_MSIX_ENTRY_CTRL_MASKBIT;
+	int i;
+
+	if (pci_msi_ignore_mask)
+		return;
+
+	for (i = 0; i < tsize; i++, base += PCI_MSIX_ENTRY_SIZE)
+		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
+}
+
+/**
+ * msix_capability_init - configure device's MSI-X capability
+ * @dev: pointer to the pci_dev data structure of MSI-X device function
+ * @entries: pointer to an array of struct msix_entry entries
+ * @nvec: number of @entries
+ * @affd: Optional pointer to enable automatic affinity assignment
+ *
+ * Setup the MSI-X capability structure of device function with a
+ * single MSI-X IRQ. A return of zero indicates the successful setup of
+ * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
+ **/
+static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
+				int nvec, struct irq_affinity *affd)
+{
+	const struct attribute_group **groups;
+	void __iomem *base;
+	int ret, tsize;
+	u16 control;
+
+	/*
+	 * Some devices require MSI-X to be enabled before the MSI-X
+	 * registers can be accessed.  Mask all the vectors to prevent
+	 * interrupts coming in before they're fully set up.
+	 */
+	pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
+				    PCI_MSIX_FLAGS_ENABLE);
+
+	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
+	/* Request & Map MSI-X table region */
+	tsize = msix_table_size(control);
+	base = msix_map_region(dev, tsize);
+	if (!base) {
+		ret = -ENOMEM;
+		goto out_disable;
+	}
+
+	/* Ensure that all table entries are masked. */
+	msix_mask_all(base, tsize);
+
+	ret = msix_setup_entries(dev, base, entries, nvec, affd);
+	if (ret)
+		goto out_disable;
+
+	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
+	if (ret)
+		goto out_avail;
+
+	/* Check if all MSI entries honor device restrictions */
+	ret = msi_verify_entries(dev);
+	if (ret)
+		goto out_free;
+
+	msix_update_entries(dev, entries);
+
+	groups = msi_populate_sysfs(&dev->dev);
+	if (IS_ERR(groups)) {
+		ret = PTR_ERR(groups);
+		goto out_free;
+	}
+
+	dev->msi_irq_groups = groups;
+
+	/* Set MSI-X enabled bits and unmask the function */
+	pci_intx_for_msi(dev, 0);
+	dev->msix_enabled = 1;
+	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
+
+	pcibios_free_irq(dev);
+	return 0;
+
+out_avail:
+	if (ret < 0) {
+		/*
+		 * If we had some success, report the number of IRQs
+		 * we succeeded in setting up.
+		 */
+		struct msi_desc *entry;
+		int avail = 0;
+
+		for_each_pci_msi_entry(entry, dev) {
+			if (entry->irq != 0)
+				avail++;
+		}
+		if (avail != 0)
+			ret = avail;
+	}
+
+out_free:
+	free_msi_irqs(dev);
+
+out_disable:
+	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
+
+	return ret;
+}
+
+/**
+ * pci_msi_supported - check whether MSI may be enabled on a device
+ * @dev: pointer to the pci_dev data structure of MSI device function
+ * @nvec: how many MSIs have been requested?
+ *
+ * Look at global flags, the device itself, and its parent buses
+ * to determine if MSI/-X are supported for the device. If MSI/-X is
+ * supported return 1, else return 0.
+ **/
+static int pci_msi_supported(struct pci_dev *dev, int nvec)
+{
+	struct pci_bus *bus;
+
+	/* MSI must be globally enabled and supported by the device */
+	if (!pci_msi_enable)
+		return 0;
+
+	if (!dev || dev->no_msi)
+		return 0;
+
+	/*
+	 * You can't ask to have 0 or less MSIs configured.
+	 *  a) it's stupid ..
+	 *  b) the list manipulation code assumes nvec >= 1.
+	 */
+	if (nvec < 1)
+		return 0;
+
+	/*
+	 * Any bridge which does NOT route MSI transactions from its
+	 * secondary bus to its primary bus must set NO_MSI flag on
+	 * the secondary pci_bus.
+	 *
+	 * The NO_MSI flag can either be set directly by:
+	 * - arch-specific PCI host bus controller drivers (deprecated)
+	 * - quirks for specific PCI bridges
+	 *
+	 * or indirectly by platform-specific PCI host bridge drivers by
+	 * advertising the 'msi_domain' property, which results in
+	 * the NO_MSI flag when no MSI domain is found for this bridge
+	 * at probe time.
+	 */
+	for (bus = dev->bus; bus; bus = bus->parent)
+		if (bus->bus_flags & PCI_BUS_FLAGS_NO_MSI)
+			return 0;
+
+	return 1;
+}
+
+/**
+ * pci_msi_vec_count - Return the number of MSI vectors a device can send
+ * @dev: device to report about
+ *
+ * This function returns the number of MSI vectors a device requested via
+ * Multiple Message Capable register. It returns a negative errno if the
+ * device is not capable sending MSI interrupts. Otherwise, the call succeeds
+ * and returns a power of two, up to a maximum of 2^5 (32), according to the
+ * MSI specification.
+ **/
+int pci_msi_vec_count(struct pci_dev *dev)
+{
+	int ret;
+	u16 msgctl;
+
+	if (!dev->msi_cap)
+		return -EINVAL;
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &msgctl);
+	ret = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
+
+	return ret;
+}
+EXPORT_SYMBOL(pci_msi_vec_count);
+
+static void pci_msi_shutdown(struct pci_dev *dev)
+{
+	struct msi_desc *desc;
+
+	if (!pci_msi_enable || !dev || !dev->msi_enabled)
+		return;
+
+	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
+	desc = first_pci_msi_entry(dev);
+
+	pci_msi_set_enable(dev, 0);
+	pci_intx_for_msi(dev, 1);
+	dev->msi_enabled = 0;
+
+	/* Return the device with MSI unmasked as initial states */
+	pci_msi_unmask(desc, msi_multi_mask(desc));
+
+	/* Restore dev->irq to its default pin-assertion IRQ */
+	dev->irq = desc->pci.msi_attrib.default_irq;
+	pcibios_alloc_irq(dev);
+}
+
+void pci_disable_msi(struct pci_dev *dev)
+{
+	if (!pci_msi_enable || !dev || !dev->msi_enabled)
+		return;
+
+	pci_msi_shutdown(dev);
+	free_msi_irqs(dev);
+}
+EXPORT_SYMBOL(pci_disable_msi);
+
+/**
+ * pci_msix_vec_count - return the number of device's MSI-X table entries
+ * @dev: pointer to the pci_dev data structure of MSI-X device function
+ * This function returns the number of device's MSI-X table entries and
+ * therefore the number of MSI-X vectors device is capable of sending.
+ * It returns a negative errno if the device is not capable of sending MSI-X
+ * interrupts.
+ **/
+int pci_msix_vec_count(struct pci_dev *dev)
+{
+	u16 control;
+
+	if (!dev->msix_cap)
+		return -EINVAL;
+
+	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
+	return msix_table_size(control);
+}
+EXPORT_SYMBOL(pci_msix_vec_count);
+
+static int __pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries,
+			     int nvec, struct irq_affinity *affd, int flags)
+{
+	int nr_entries;
+	int i, j;
+
+	if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
+		return -EINVAL;
+
+	nr_entries = pci_msix_vec_count(dev);
+	if (nr_entries < 0)
+		return nr_entries;
+	if (nvec > nr_entries && !(flags & PCI_IRQ_VIRTUAL))
+		return nr_entries;
+
+	if (entries) {
+		/* Check for any invalid entries */
+		for (i = 0; i < nvec; i++) {
+			if (entries[i].entry >= nr_entries)
+				return -EINVAL;		/* invalid entry */
+			for (j = i + 1; j < nvec; j++) {
+				if (entries[i].entry == entries[j].entry)
+					return -EINVAL;	/* duplicate entry */
+			}
+		}
+	}
+
+	/* Check whether driver already requested for MSI IRQ */
+	if (dev->msi_enabled) {
+		pci_info(dev, "can't enable MSI-X (MSI IRQ already assigned)\n");
+		return -EINVAL;
+	}
+	return msix_capability_init(dev, entries, nvec, affd);
+}
+
+static void pci_msix_shutdown(struct pci_dev *dev)
+{
+	struct msi_desc *entry;
+
+	if (!pci_msi_enable || !dev || !dev->msix_enabled)
+		return;
+
+	if (pci_dev_is_disconnected(dev)) {
+		dev->msix_enabled = 0;
+		return;
+	}
+
+	/* Return the device with MSI-X masked as initial states */
+	for_each_pci_msi_entry(entry, dev)
+		pci_msix_mask(entry);
+
+	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
+	pci_intx_for_msi(dev, 1);
+	dev->msix_enabled = 0;
+	pcibios_alloc_irq(dev);
+}
+
+void pci_disable_msix(struct pci_dev *dev)
+{
+	if (!pci_msi_enable || !dev || !dev->msix_enabled)
+		return;
+
+	pci_msix_shutdown(dev);
+	free_msi_irqs(dev);
+}
+EXPORT_SYMBOL(pci_disable_msix);
+
+void pci_no_msi(void)
+{
+	pci_msi_enable = 0;
+}
+
+/**
+ * pci_msi_enabled - is MSI enabled?
+ *
+ * Returns true if MSI has not been disabled by the command-line option
+ * pci=nomsi.
+ **/
+int pci_msi_enabled(void)
+{
+	return pci_msi_enable;
+}
+EXPORT_SYMBOL(pci_msi_enabled);
+
+static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
+				  struct irq_affinity *affd)
+{
+	int nvec;
+	int rc;
+
+	if (!pci_msi_supported(dev, minvec) || dev->current_state != PCI_D0)
+		return -EINVAL;
+
+	/* Check whether driver already requested MSI-X IRQs */
+	if (dev->msix_enabled) {
+		pci_info(dev, "can't enable MSI (MSI-X already enabled)\n");
+		return -EINVAL;
+	}
+
+	if (maxvec < minvec)
+		return -ERANGE;
+
+	if (WARN_ON_ONCE(dev->msi_enabled))
+		return -EINVAL;
+
+	nvec = pci_msi_vec_count(dev);
+	if (nvec < 0)
+		return nvec;
+	if (nvec < minvec)
+		return -ENOSPC;
+
+	if (nvec > maxvec)
+		nvec = maxvec;
+
+	for (;;) {
+		if (affd) {
+			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
+			if (nvec < minvec)
+				return -ENOSPC;
+		}
+
+		rc = msi_capability_init(dev, nvec, affd);
+		if (rc == 0)
+			return nvec;
+
+		if (rc < 0)
+			return rc;
+		if (rc < minvec)
+			return -ENOSPC;
+
+		nvec = rc;
+	}
+}
+
+/* deprecated, don't use */
+int pci_enable_msi(struct pci_dev *dev)
+{
+	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
+	if (rc < 0)
+		return rc;
+	return 0;
+}
+EXPORT_SYMBOL(pci_enable_msi);
+
+static int __pci_enable_msix_range(struct pci_dev *dev,
+				   struct msix_entry *entries, int minvec,
+				   int maxvec, struct irq_affinity *affd,
+				   int flags)
+{
+	int rc, nvec = maxvec;
+
+	if (maxvec < minvec)
+		return -ERANGE;
+
+	if (WARN_ON_ONCE(dev->msix_enabled))
+		return -EINVAL;
+
+	for (;;) {
+		if (affd) {
+			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
+			if (nvec < minvec)
+				return -ENOSPC;
+		}
+
+		rc = __pci_enable_msix(dev, entries, nvec, affd, flags);
+		if (rc == 0)
+			return nvec;
+
+		if (rc < 0)
+			return rc;
+		if (rc < minvec)
+			return -ENOSPC;
+
+		nvec = rc;
+	}
+}
+
+/**
+ * pci_enable_msix_range - configure device's MSI-X capability structure
+ * @dev: pointer to the pci_dev data structure of MSI-X device function
+ * @entries: pointer to an array of MSI-X entries
+ * @minvec: minimum number of MSI-X IRQs requested
+ * @maxvec: maximum number of MSI-X IRQs requested
+ *
+ * Setup the MSI-X capability structure of device function with a maximum
+ * possible number of interrupts in the range between @minvec and @maxvec
+ * upon its software driver call to request for MSI-X mode enabled on its
+ * hardware device function. It returns a negative errno if an error occurs.
+ * If it succeeds, it returns the actual number of interrupts allocated and
+ * indicates the successful configuration of MSI-X capability structure
+ * with new allocated MSI-X interrupts.
+ **/
+int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
+		int minvec, int maxvec)
+{
+	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
+}
+EXPORT_SYMBOL(pci_enable_msix_range);
+
+/**
+ * pci_alloc_irq_vectors_affinity - allocate multiple IRQs for a device
+ * @dev:		PCI device to operate on
+ * @min_vecs:		minimum number of vectors required (must be >= 1)
+ * @max_vecs:		maximum (desired) number of vectors
+ * @flags:		flags or quirks for the allocation
+ * @affd:		optional description of the affinity requirements
+ *
+ * Allocate up to @max_vecs interrupt vectors for @dev, using MSI-X or MSI
+ * vectors if available, and fall back to a single legacy vector
+ * if neither is available.  Return the number of vectors allocated,
+ * (which might be smaller than @max_vecs) if successful, or a negative
+ * error code on error. If less than @min_vecs interrupt vectors are
+ * available for @dev the function will fail with -ENOSPC.
+ *
+ * To get the Linux IRQ number used for a vector that can be passed to
+ * request_irq() use the pci_irq_vector() helper.
+ */
+int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
+				   unsigned int max_vecs, unsigned int flags,
+				   struct irq_affinity *affd)
+{
+	struct irq_affinity msi_default_affd = {0};
+	int nvecs = -ENOSPC;
+
+	if (flags & PCI_IRQ_AFFINITY) {
+		if (!affd)
+			affd = &msi_default_affd;
+	} else {
+		if (WARN_ON(affd))
+			affd = NULL;
+	}
+
+	if (flags & PCI_IRQ_MSIX) {
+		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
+						affd, flags);
+		if (nvecs > 0)
+			return nvecs;
+	}
+
+	if (flags & PCI_IRQ_MSI) {
+		nvecs = __pci_enable_msi_range(dev, min_vecs, max_vecs, affd);
+		if (nvecs > 0)
+			return nvecs;
+	}
+
+	/* use legacy IRQ if allowed */
+	if (flags & PCI_IRQ_LEGACY) {
+		if (min_vecs == 1 && dev->irq) {
+			/*
+			 * Invoke the affinity spreading logic to ensure that
+			 * the device driver can adjust queue configuration
+			 * for the single interrupt case.
+			 */
+			if (affd)
+				irq_create_affinity_masks(1, affd);
+			pci_intx(dev, 1);
+			return 1;
+		}
+	}
+
+	return nvecs;
+}
+EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
+
+/**
+ * pci_free_irq_vectors - free previously allocated IRQs for a device
+ * @dev:		PCI device to operate on
+ *
+ * Undoes the allocations and enabling in pci_alloc_irq_vectors().
+ */
+void pci_free_irq_vectors(struct pci_dev *dev)
+{
+	pci_disable_msix(dev);
+	pci_disable_msi(dev);
+}
+EXPORT_SYMBOL(pci_free_irq_vectors);
+
+/**
+ * pci_irq_vector - return Linux IRQ number of a device vector
+ * @dev:	PCI device to operate on
+ * @nr:		Interrupt vector index (0-based)
+ *
+ * @nr has the following meanings depending on the interrupt mode:
+ *   MSI-X:	The index in the MSI-X vector table
+ *   MSI:	The index of the enabled MSI vectors
+ *   INTx:	Must be 0
+ *
+ * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
+ */
+int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
+{
+	if (dev->msix_enabled) {
+		struct msi_desc *entry;
+
+		for_each_pci_msi_entry(entry, dev) {
+			if (entry->pci.msi_attrib.entry_nr == nr)
+				return entry->irq;
+		}
+		WARN_ON_ONCE(1);
+		return -EINVAL;
+	}
+
+	if (dev->msi_enabled) {
+		struct msi_desc *entry = first_pci_msi_entry(dev);
+
+		if (WARN_ON_ONCE(nr >= entry->nvec_used))
+			return -EINVAL;
+	} else {
+		if (WARN_ON_ONCE(nr > 0))
+			return -EINVAL;
+	}
+
+	return dev->irq + nr;
+}
+EXPORT_SYMBOL(pci_irq_vector);
+
+/**
+ * pci_irq_get_affinity - return the affinity of a particular MSI vector
+ * @dev:	PCI device to operate on
+ * @nr:		device-relative interrupt vector index (0-based).
+ *
+ * @nr has the following meanings depending on the interrupt mode:
+ *   MSI-X:	The index in the MSI-X vector table
+ *   MSI:	The index of the enabled MSI vectors
+ *   INTx:	Must be 0
+ *
+ * Return: A cpumask pointer or NULL if @nr is out of range
+ */
+const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
+{
+	if (dev->msix_enabled) {
+		struct msi_desc *entry;
+
+		for_each_pci_msi_entry(entry, dev) {
+			if (entry->pci.msi_attrib.entry_nr == nr)
+				return &entry->affinity->mask;
+		}
+		WARN_ON_ONCE(1);
+		return NULL;
+	} else if (dev->msi_enabled) {
+		struct msi_desc *entry = first_pci_msi_entry(dev);
+
+		if (WARN_ON_ONCE(!entry || !entry->affinity ||
+				 nr >= entry->nvec_used))
+			return NULL;
+
+		return &entry->affinity[nr].mask;
+	} else {
+		return cpu_possible_mask;
+	}
+}
+EXPORT_SYMBOL(pci_irq_get_affinity);
+
+struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
+{
+	return to_pci_dev(desc->dev);
+}
+EXPORT_SYMBOL(msi_desc_to_pci_dev);
+
+#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
+/**
+ * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
+ * @irq_data:	Pointer to interrupt data of the MSI interrupt
+ * @msg:	Pointer to the message
+ */
+static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
+{
+	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
+
+	/*
+	 * For MSI-X desc->irq is always equal to irq_data->irq. For
+	 * MSI only the first interrupt of MULTI MSI passes the test.
+	 */
+	if (desc->irq == irq_data->irq)
+		__pci_write_msi_msg(desc, msg);
+}
+
+/**
+ * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
+ * @desc:	Pointer to the MSI descriptor
+ *
+ * The ID number is only used within the irqdomain.
+ */
+static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
+{
+	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
+
+	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
+		pci_dev_id(dev) << 11 |
+		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
+}
+
+static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
+{
+	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
+}
+
+/**
+ * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
+ * 			      for @dev
+ * @domain:	The interrupt domain to check
+ * @info:	The domain info for verification
+ * @dev:	The device to check
+ *
+ * Returns:
+ *  0 if the functionality is supported
+ *  1 if Multi MSI is requested, but the domain does not support it
+ *  -ENOTSUPP otherwise
+ */
+int pci_msi_domain_check_cap(struct irq_domain *domain,
+			     struct msi_domain_info *info, struct device *dev)
+{
+	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
+
+	/* Special handling to support __pci_enable_msi_range() */
+	if (pci_msi_desc_is_multi_msi(desc) &&
+	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
+		return 1;
+	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
+		return -ENOTSUPP;
+
+	return 0;
+}
+
+static int pci_msi_domain_handle_error(struct irq_domain *domain,
+				       struct msi_desc *desc, int error)
+{
+	/* Special handling to support __pci_enable_msi_range() */
+	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
+		return 1;
+
+	return error;
+}
+
+static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
+				    struct msi_desc *desc)
+{
+	arg->desc = desc;
+	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
+}
+
+static struct msi_domain_ops pci_msi_domain_ops_default = {
+	.set_desc	= pci_msi_domain_set_desc,
+	.msi_check	= pci_msi_domain_check_cap,
+	.handle_error	= pci_msi_domain_handle_error,
+};
+
+static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
+{
+	struct msi_domain_ops *ops = info->ops;
+
+	if (ops == NULL) {
+		info->ops = &pci_msi_domain_ops_default;
+	} else {
+		if (ops->set_desc == NULL)
+			ops->set_desc = pci_msi_domain_set_desc;
+		if (ops->msi_check == NULL)
+			ops->msi_check = pci_msi_domain_check_cap;
+		if (ops->handle_error == NULL)
+			ops->handle_error = pci_msi_domain_handle_error;
+	}
+}
+
+static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
+{
+	struct irq_chip *chip = info->chip;
+
+	BUG_ON(!chip);
+	if (!chip->irq_write_msi_msg)
+		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
+	if (!chip->irq_mask)
+		chip->irq_mask = pci_msi_mask_irq;
+	if (!chip->irq_unmask)
+		chip->irq_unmask = pci_msi_unmask_irq;
+}
+
+/**
+ * pci_msi_create_irq_domain - Create a MSI interrupt domain
+ * @fwnode:	Optional fwnode of the interrupt controller
+ * @info:	MSI domain info
+ * @parent:	Parent irq domain
+ *
+ * Updates the domain and chip ops and creates a MSI interrupt domain.
+ *
+ * Returns:
+ * A domain pointer or NULL in case of failure.
+ */
+struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
+					     struct msi_domain_info *info,
+					     struct irq_domain *parent)
+{
+	struct irq_domain *domain;
+
+	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
+		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
+
+	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
+		pci_msi_domain_update_dom_ops(info);
+	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
+		pci_msi_domain_update_chip_ops(info);
+
+	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
+		info->flags |= MSI_FLAG_MUST_REACTIVATE;
+
+	/* PCI-MSI is oneshot-safe */
+	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
+
+	domain = msi_create_irq_domain(fwnode, info, parent);
+	if (!domain)
+		return NULL;
+
+	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
+	return domain;
+}
+EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
+
+/*
+ * Users of the generic MSI infrastructure expect a device to have a single ID,
+ * so with DMA aliases we have to pick the least-worst compromise. Devices with
+ * DMA phantom functions tend to still emit MSIs from the real function number,
+ * so we ignore those and only consider topological aliases where either the
+ * alias device or RID appears on a different bus number. We also make the
+ * reasonable assumption that bridges are walked in an upstream direction (so
+ * the last one seen wins), and the much braver assumption that the most likely
+ * case is that of PCI->PCIe so we should always use the alias RID. This echoes
+ * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
+ * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
+ * for taking ownership all we can really do is close our eyes and hope...
+ */
+static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
+{
+	u32 *pa = data;
+	u8 bus = PCI_BUS_NUM(*pa);
+
+	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
+		*pa = alias;
+
+	return 0;
+}
+
+/**
+ * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
+ * @domain:	The interrupt domain
+ * @pdev:	The PCI device.
+ *
+ * The RID for a device is formed from the alias, with a firmware
+ * supplied mapping applied
+ *
+ * Returns: The RID.
+ */
+u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
+{
+	struct device_node *of_node;
+	u32 rid = pci_dev_id(pdev);
+
+	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
+
+	of_node = irq_domain_get_of_node(domain);
+	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
+			iort_msi_map_id(&pdev->dev, rid);
+
+	return rid;
+}
+
+/**
+ * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
+ * @pdev:	The PCI device
+ *
+ * Use the firmware data to find a device-specific MSI domain
+ * (i.e. not one that is set as a default).
+ *
+ * Returns: The corresponding MSI domain or NULL if none has been found.
+ */
+struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
+{
+	struct irq_domain *dom;
+	u32 rid = pci_dev_id(pdev);
+
+	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
+	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
+	if (!dom)
+		dom = iort_get_device_domain(&pdev->dev, rid,
+					     DOMAIN_BUS_PCI_MSI);
+	return dom;
+}
+
+/**
+ * pci_dev_has_special_msi_domain - Check whether the device is handled by
+ *				    a non-standard PCI-MSI domain
+ * @pdev:	The PCI device to check.
+ *
+ * Returns: True if the device irqdomain or the bus irqdomain is
+ * non-standard PCI/MSI.
+ */
+bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
+{
+	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
+
+	if (!dom)
+		dom = dev_get_msi_domain(&pdev->bus->dev);
+
+	if (!dom)
+		return true;
+
+	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
+}
+
+#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
+#endif /* CONFIG_PCI_MSI */
+
+void pci_msi_init(struct pci_dev *dev)
+{
+	u16 ctrl;
+
+	/*
+	 * Disable the MSI hardware to avoid screaming interrupts
+	 * during boot.  This is the power on reset default so
+	 * usually this should be a noop.
+	 */
+	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
+	if (!dev->msi_cap)
+		return;
+
+	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
+	if (ctrl & PCI_MSI_FLAGS_ENABLE)
+		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
+				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
+
+	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
+		dev->no_64bit_msi = 1;
+}
+
+void pci_msix_init(struct pci_dev *dev)
+{
+	u16 ctrl;
+
+	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
+	if (!dev->msix_cap)
+		return;
+
+	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
+	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
+		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
+				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
+}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:39:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:39:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240003.416108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMdR-0000N2-5T; Mon, 06 Dec 2021 22:39:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240003.416108; Mon, 06 Dec 2021 22:39:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMdR-0000Mv-2O; Mon, 06 Dec 2021 22:39:01 +0000
Received: by outflank-mailman (input) for mailman id 240003;
 Mon, 06 Dec 2021 22:38:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdP-0004ul-Bx
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:38:59 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d3392bf-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:38:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d3392bf-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210437.708862278@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830338;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=E+U4wBNO821PczyA58GFB83d3mrDArDJk9rmH8AmF2s=;
	b=XgzGfONAvccQTF6y8RU+V8re1pgjfR0lBoT/9VUgclQ3JM43YF+JGXabuLcuE1jBlZUbxZ
	r5gKwI4COnVuL+LVNpp1XS8npZu4/QNJr9VKtynI10/IbTRuCAQkQXUebw6D9pyukMNGIO
	65TH/YU0UJ2QhkfOOhzGm4mxl10x80CcYKA+nWGjLBdsH+DHpB1MpfsHDWPgFMzV/cq099
	PCZ+8deN75cxusBqHvU26pqvpvbc7n39A11+hGZnQMhZBMvksO089n4M4L4pcWmOUNvH3y
	KILPk7eSvemFD7lfDWUFwWHw6eDo1wYUFhqaUKtwmztro+ZWYAIPSyWpNdokfA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830338;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=E+U4wBNO821PczyA58GFB83d3mrDArDJk9rmH8AmF2s=;
	b=Asgi9ojEK9C/QpFeOZitUkdaLt+mGz7mKxEdN/+qlo7HJoCr0R42jfwDjz72tdmcwVwwsH
	eQjniczuWGPANGAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 01/36] device: Move MSI related data into a struct
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:38:57 +0100 (CET)

The only unconditional part of MSI data in struct device is the irqdomain
pointer. Everything else can be allocated on demand. Create a data
structure and move the irqdomain pointer into it. The other MSI specific
parts are going to be removed from struct device in later steps.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Will Deacon <will@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: iommu@lists.linux-foundation.org
Cc: dmaengine@vger.kernel.org
---
 drivers/base/platform-msi.c                 |   12 ++++++------
 drivers/dma/ti/k3-udma.c                    |    4 ++--
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |    2 +-
 drivers/irqchip/irq-mvebu-icu.c             |    6 +++---
 drivers/soc/ti/k3-ringacc.c                 |    4 ++--
 drivers/soc/ti/ti_sci_inta_msi.c            |    2 +-
 include/linux/device.h                      |   20 ++++++++++++++------
 7 files changed, 29 insertions(+), 21 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -210,10 +210,10 @@ platform_msi_alloc_priv_data(struct devi
 	 * accordingly (which would impact the max number of MSI
 	 * capable devices).
 	 */
-	if (!dev->msi_domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
+	if (!dev->msi.domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
 		return ERR_PTR(-EINVAL);
 
-	if (dev->msi_domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
+	if (dev->msi.domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
 		dev_err(dev, "Incompatible msi_domain, giving up\n");
 		return ERR_PTR(-EINVAL);
 	}
@@ -269,7 +269,7 @@ int platform_msi_domain_alloc_irqs(struc
 	if (err)
 		goto out_free_priv_data;
 
-	err = msi_domain_alloc_irqs(dev->msi_domain, dev, nvec);
+	err = msi_domain_alloc_irqs(dev->msi.domain, dev, nvec);
 	if (err)
 		goto out_free_desc;
 
@@ -282,7 +282,7 @@ int platform_msi_domain_alloc_irqs(struc
 	return 0;
 
 out_free_irqs:
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
@@ -306,7 +306,7 @@ void platform_msi_domain_free_irqs(struc
 		platform_msi_free_priv_data(desc->platform.msi_priv_data);
 	}
 
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 	platform_msi_free_descs(dev, 0, MAX_DEV_MSIS);
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_free_irqs);
@@ -354,7 +354,7 @@ struct irq_domain *
 		return NULL;
 
 	data->host_data = host_data;
-	domain = irq_domain_create_hierarchy(dev->msi_domain, 0,
+	domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
 					     is_tree ? 0 : nvec,
 					     dev->fwnode, ops, data);
 	if (!domain)
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5279,9 +5279,9 @@ static int udma_probe(struct platform_de
 	if (IS_ERR(ud->ringacc))
 		return PTR_ERR(ud->ringacc);
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_err(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3170,7 +3170,7 @@ static void arm_smmu_setup_msis(struct a
 	if (!(smmu->features & ARM_SMMU_FEAT_MSI))
 		return;
 
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_info(smmu->dev, "msi_domain absent - falling back to wired irqs\n");
 		return;
 	}
--- a/drivers/irqchip/irq-mvebu-icu.c
+++ b/drivers/irqchip/irq-mvebu-icu.c
@@ -314,12 +314,12 @@ static int mvebu_icu_subset_probe(struct
 		msi_data->subset_data = of_device_get_match_data(dev);
 	}
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_PLATFORM_MSI);
-	if (!dev->msi_domain)
+	if (!dev->msi.domain)
 		return -EPROBE_DEFER;
 
-	msi_parent_dn = irq_domain_get_of_node(dev->msi_domain);
+	msi_parent_dn = irq_domain_get_of_node(dev->msi.domain);
 	if (!msi_parent_dn)
 		return -ENODEV;
 
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -1356,9 +1356,9 @@ static int k3_ringacc_init(struct platfo
 	struct resource *res;
 	int ret, i;
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_err(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -140,7 +140,7 @@ EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain
 
 void ti_sci_inta_msi_domain_free_irqs(struct device *dev)
 {
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 	ti_sci_inta_msi_free_descs(dev);
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -372,6 +372,16 @@ struct dev_links_info {
 };
 
 /**
+ * struct dev_msi_info - Device data related to MSI
+ * @domain:	The MSI interrupt domain associated to the device
+ */
+struct dev_msi_info {
+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+	struct irq_domain	*domain;
+#endif
+};
+
+/**
  * struct device - The basic device structure
  * @parent:	The device's "parent" device, the device to which it is attached.
  * 		In most cases, a parent device is some sort of bus or host
@@ -407,8 +417,8 @@ struct dev_links_info {
  * @em_pd:	device's energy model performance domain
  * @pins:	For device pin management.
  *		See Documentation/driver-api/pin-control.rst for details.
+ * @msi:	MSI related data
  * @msi_list:	Hosts MSI descriptors
- * @msi_domain: The generic MSI domain this device is using.
  * @numa_node:	NUMA node this device is close to.
  * @dma_ops:    DMA mapping operations for this device.
  * @dma_mask:	Dma mask (if dma'ble device).
@@ -500,12 +510,10 @@ struct device {
 	struct em_perf_domain	*em_pd;
 #endif
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	struct irq_domain	*msi_domain;
-#endif
 #ifdef CONFIG_PINCTRL
 	struct dev_pin_info	*pins;
 #endif
+	struct dev_msi_info	msi;
 #ifdef CONFIG_GENERIC_MSI_IRQ
 	struct list_head	msi_list;
 #endif
@@ -666,7 +674,7 @@ static inline void set_dev_node(struct d
 static inline struct irq_domain *dev_get_msi_domain(const struct device *dev)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	return dev->msi_domain;
+	return dev->msi.domain;
 #else
 	return NULL;
 #endif
@@ -675,7 +683,7 @@ static inline struct irq_domain *dev_get
 static inline void dev_set_msi_domain(struct device *dev, struct irq_domain *d)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	dev->msi_domain = d;
+	dev->msi.domain = d;
 #endif
 }
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:41:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:41:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240007.416118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMgD-0001pR-Ke; Mon, 06 Dec 2021 22:41:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240007.416118; Mon, 06 Dec 2021 22:41:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMgD-0001pK-Ha; Mon, 06 Dec 2021 22:41:53 +0000
Received: by outflank-mailman (input) for mailman id 240007;
 Mon, 06 Dec 2021 22:41:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nYkR=QX=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1muMgC-0001pE-0t
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:41:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b397eaa1-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:41:50 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 77B0CB815B0;
 Mon,  6 Dec 2021 22:41:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E588FC341C6;
 Mon,  6 Dec 2021 22:41:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b397eaa1-56e5-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638830508;
	bh=ybxb1Cs1iC1zy+8FjGpNML/IjtZYDAOJfwLd5cIiNM4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=sUPQLM+WjPb3DqLvk0wYZmzffZail/VBHfWBCIxTaABkGAir4iou/JeXlSzWCPzGl
	 GJJHjKPhyh94cDbJoRJnLIzGaZn4JN9m2JrqVPI4Oj82nHR7CJeeG66nTLi60a2rao
	 hLusu2s8jRbIqjGLpIV50pKuS9qZubVmwvEWg5pCbgDMMfU6Y9W4A4P0zl+I6/WZP/
	 R6zBBUs4rgZF3FI7Ik8k7aQso2aaiJtrsQFo5Sukk951hFKTQN2wJtUeuvd3JDwahH
	 hxaoGNLyMsvIs7ij6/cMvXr/meSvujGGdHI63j1v6U9D5Tb1b6k6QCHPSuU9X5l8E/
	 XbAs6QoQxsMcQ==
Date: Mon, 6 Dec 2021 14:41:46 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, 
    Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>, 
    Andre Przywara <Andre.Przywara@arm.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    "sstabellini@kernel.org" <sstabellini@kernel.org>, 
    "stefanos@xilinx.com" <stefanos@xilinx.com>, 
    "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>, 
    "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
In-Reply-To: <4315f3f8-4431-3257-dc95-a3089532237b@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112061438300.4091490@ubuntu-linux-20-04-desktop>
References: <20211129191638.19877-1-ayankuma@xilinx.com> <20211130094950.1bf368d6@donnerap.cambridge.arm.com> <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com> <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com> <4315f3f8-4431-3257-dc95-a3089532237b@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 6 Dec 2021, Julien Grall wrote:
> On 01/12/2021 08:41, Bertrand Marquis wrote:
> > Hi Ayan,
> > 
> > > On 30 Nov 2021, at 19:13, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
> > > wrote:
> > > 
> > > Hi Andre,
> > > 
> > > Thanks for your comments. They are useful.
> > > 
> > > On 30/11/2021 09:49, Andre Przywara wrote:
> > > > On Mon, 29 Nov 2021 19:16:38 +0000
> > > > Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> > > > Hi,
> > > > > At the moment, Xen is only handling data abort with valid syndrome
> > > > > (i.e.
> > > > > ISV=0). Unfortunately, this doesn't cover all the instructions a
> > > > > domain
> > > > > could use to access MMIO regions.
> > > > > 
> > > > > For instance, Xilinx baremetal OS will use:
> > > > > 
> > > > >          volatile u32 *LocalAddr = (volatile u32 *)Addr;
> > > > >          *LocalAddr = Value;
> > > > > 
> > > > > This leave the compiler to decide which store instructions to use.
> > > > As mentioned in the other email, this is wrong, if this points to MMIO:
> > > > don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
> > > > an MMIO area, you should not see traps that you cannot handle already.
> > > > So I don't think it's a good idea to use that as an example. And since
> > > > this patch only seems to address this use case, I would doubt its
> > > > usefulness in general.
> > > Yes, I should have fixed the comment.
> > > 
> > > Currently, I am testing with baremetal app which uses inline assembly code
> > > with post indexing instructions, to access the MMIO.
> > > 
> > > ATM, I am testing with 32 bit MMIO only.
> > > 
> > > On the usefulness, I am kind of torn as it is legitimate for post indexing
> > > instructions to be used in an inline-assembly code for accessing MMIO.
> > > However, that may not be something commonly seen.
> > > 
> > > @Stefano/Bertrand/Julien/Volodymyr :- As you are the Arm mantainers, can
> > > you comment if we should have decoding logic or not ?
> > 
> > Andre gave you the official statement from Arm and there is nothing more I
> > can say.
> 
> I think this would be handy for other hypervisor and OS developper to know
> what they can expect when running in a virtualized environment. So would it be
> possible to update the Arm Arm reflecting this statement?
> 
> > I will leave this decision to Stefano and Julien.
> 
> I have had a chat on IRC with Stefano about this. I think the main sticking
> point is the Arm Arm doesn't clearly state those instructions should not be
> used by a virtualized OS on MMIO regions.
> 
> To me, this topic looks similar to the set/way instruction dilemma. They are a
> pain to virtualize (and the Arm Arm clearly hint it) but we had to do it
> because some OSes relied on them.
> 
> I think the main difference is the Arm Arm doesn't hint they should not be
> used (it only says a valid syndrome is not provided) and the implementation
> should hopefully be smaller and self-contained.
> 
> So I would be inclined to allow Xen to decode post-indexing instructions
> (pending the review).

I am of the same opinion.

(FYI in any case we'll also work internally to improve Xilinx baremetal.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240018.416140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002fb-SH; Mon, 06 Dec 2021 22:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240018.416140; Mon, 06 Dec 2021 22:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002dh-MV; Mon, 06 Dec 2021 22:46:57 +0000
Received: by outflank-mailman (input) for mailman id 240018;
 Mon, 06 Dec 2021 22:46:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdh-0004dp-3I
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:17 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 57bd4e38-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 57bd4e38-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.310445889@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830356;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ZBun+BNrncmDCLhUClKwPbgoMa6P/CUfRD8LwyZQrQo=;
	b=VUWn2yBE6rVGlxwZIKOEifvfL36dFtKjNljMPglfHKN+xxitQBAMtTAtm0n/fMScBraHiY
	/kn0cMLirGCtpjHtlNu6I8c5KOnEwnH8uE5F1LUSus/SuXtaxvg5nqovVbrIsFCCMNPulE
	/n2C420oBzql78ADdW2D3ZEOkx3tfhh/UXfQYuWNVZyFQXRhEbFeQQL0kisZ2OX2Idd1zj
	S07xiK3DBX2wJavNmZkz2zbr81t3CwKXgtYv2hSsTo7f/wG5/u/XwsA+eR8dAEzJN78VQQ
	KciOOQf7xq6cUWFDwDnYmpXqJXzgOJtvQ8JpaCynLP2dVHSQGz67KND8VbOd0g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830356;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ZBun+BNrncmDCLhUClKwPbgoMa6P/CUfRD8LwyZQrQo=;
	b=t91sG1vrq5IdTONAWnwCE4d78ykskp/XkoupImVqefTn4q8kXJhdDPsvKRrvYXAgmHRVtB
	ffnB+1ueiPPN+tAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 12/36] platform-msi: Store platform private data pointer in
 msi_device_data
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:15 +0100 (CET)

Storing the platform private data in a MSI descriptor is sloppy at
best. The data belongs to the device and not to the descriptor.
Add a pointer to struct msi_device_data and store the pointer there.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |   79 +++++++++++++++++---------------------------
 include/linux/msi.h         |    4 +-
 2 files changed, 34 insertions(+), 49 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -38,9 +38,7 @@ static DEFINE_IDA(platform_msi_devid_ida
  */
 static irq_hw_number_t platform_msi_calc_hwirq(struct msi_desc *desc)
 {
-	u32 devid;
-
-	devid = desc->platform.msi_priv_data->devid;
+	u32 devid = desc->dev->msi.data->platform_data->devid;
 
 	return (devid << (32 - DEV_ID_SHIFT)) | desc->platform.msi_index;
 }
@@ -85,11 +83,8 @@ static void platform_msi_update_dom_ops(
 static void platform_msi_write_msg(struct irq_data *data, struct msi_msg *msg)
 {
 	struct msi_desc *desc = irq_data_get_msi_desc(data);
-	struct platform_msi_priv_data *priv_data;
-
-	priv_data = desc->platform.msi_priv_data;
 
-	priv_data->write_msg(desc, msg);
+	desc->dev->msi.data->platform_data->write_msg(desc, msg);
 }
 
 static void platform_msi_update_chip_ops(struct msi_domain_info *info)
@@ -126,9 +121,7 @@ static void platform_msi_free_descs(stru
 }
 
 static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
-					     int nvec,
-					     struct platform_msi_priv_data *data)
-
+					     int nvec)
 {
 	struct msi_desc *desc;
 	int i, base = 0;
@@ -144,7 +137,6 @@ static int platform_msi_alloc_descs_with
 		if (!desc)
 			break;
 
-		desc->platform.msi_priv_data = data;
 		desc->platform.msi_index = base + i;
 		desc->irq = virq ? virq + i : 0;
 
@@ -161,11 +153,9 @@ static int platform_msi_alloc_descs_with
 	return 0;
 }
 
-static int platform_msi_alloc_descs(struct device *dev, int nvec,
-				    struct platform_msi_priv_data *data)
-
+static int platform_msi_alloc_descs(struct device *dev, int nvec)
 {
-	return platform_msi_alloc_descs_with_irq(dev, 0, nvec, data);
+	return platform_msi_alloc_descs_with_irq(dev, 0, nvec);
 }
 
 /**
@@ -199,9 +189,8 @@ struct irq_domain *platform_msi_create_i
 	return domain;
 }
 
-static struct platform_msi_priv_data *
-platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec,
-			     irq_write_msi_msg_t write_msi_msg)
+static int platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec,
+					irq_write_msi_msg_t write_msi_msg)
 {
 	struct platform_msi_priv_data *datap;
 	int err;
@@ -213,41 +202,44 @@ platform_msi_alloc_priv_data(struct devi
 	 * capable devices).
 	 */
 	if (!dev->msi.domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 
 	if (dev->msi.domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
 		dev_err(dev, "Incompatible msi_domain, giving up\n");
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 	}
 
 	err = msi_setup_device_data(dev);
 	if (err)
-		return ERR_PTR(err);
+		return err;
 
-	/* Already had a helping of MSI? Greed... */
-	if (!list_empty(dev_to_msi_list(dev)))
-		return ERR_PTR(-EBUSY);
+	/* Already initialized? */
+	if (dev->msi.data->platform_data)
+		return -EBUSY;
 
 	datap = kzalloc(sizeof(*datap), GFP_KERNEL);
 	if (!datap)
-		return ERR_PTR(-ENOMEM);
+		return -ENOMEM;
 
 	datap->devid = ida_simple_get(&platform_msi_devid_ida,
 				      0, 1 << DEV_ID_SHIFT, GFP_KERNEL);
 	if (datap->devid < 0) {
 		err = datap->devid;
 		kfree(datap);
-		return ERR_PTR(err);
+		return err;
 	}
 
 	datap->write_msg = write_msi_msg;
 	datap->dev = dev;
-
-	return datap;
+	dev->msi.data->platform_data = datap;
+	return 0;
 }
 
-static void platform_msi_free_priv_data(struct platform_msi_priv_data *data)
+static void platform_msi_free_priv_data(struct device *dev)
 {
+	struct platform_msi_priv_data *data = dev->msi.data->platform_data;
+
+	dev->msi.data->platform_data = NULL;
 	ida_simple_remove(&platform_msi_devid_ida, data->devid);
 	kfree(data);
 }
@@ -264,14 +256,13 @@ static void platform_msi_free_priv_data(
 int platform_msi_domain_alloc_irqs(struct device *dev, unsigned int nvec,
 				   irq_write_msi_msg_t write_msi_msg)
 {
-	struct platform_msi_priv_data *priv_data;
 	int err;
 
-	priv_data = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
-	if (IS_ERR(priv_data))
-		return PTR_ERR(priv_data);
+	err = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
+	if (err)
+		return err;
 
-	err = platform_msi_alloc_descs(dev, nvec, priv_data);
+	err = platform_msi_alloc_descs(dev, nvec);
 	if (err)
 		goto out_free_priv_data;
 
@@ -284,8 +275,7 @@ int platform_msi_domain_alloc_irqs(struc
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
-	platform_msi_free_priv_data(priv_data);
-
+	platform_msi_free_priv_data(dev);
 	return err;
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_alloc_irqs);
@@ -296,15 +286,9 @@ EXPORT_SYMBOL_GPL(platform_msi_domain_al
  */
 void platform_msi_domain_free_irqs(struct device *dev)
 {
-	if (!list_empty(dev_to_msi_list(dev))) {
-		struct msi_desc *desc;
-
-		desc = first_msi_entry(dev);
-		platform_msi_free_priv_data(desc->platform.msi_priv_data);
-	}
-
 	msi_domain_free_irqs(dev->msi.domain, dev);
 	platform_msi_free_descs(dev, 0, MAX_DEV_MSIS);
+	platform_msi_free_priv_data(dev);
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_free_irqs);
 
@@ -351,10 +335,11 @@ struct irq_domain *
 	struct irq_domain *domain;
 	int err;
 
-	data = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
-	if (IS_ERR(data))
+	err = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
+	if (err)
 		return NULL;
 
+	data = dev->msi.data->platform_data;
 	data->host_data = host_data;
 	domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
 					     is_tree ? 0 : nvec,
@@ -372,7 +357,7 @@ struct irq_domain *
 free_domain:
 	irq_domain_remove(domain);
 free_priv:
-	platform_msi_free_priv_data(data);
+	platform_msi_free_priv_data(dev);
 	return NULL;
 }
 
@@ -420,7 +405,7 @@ int platform_msi_device_domain_alloc(str
 	struct platform_msi_priv_data *data = domain->host_data;
 	int err;
 
-	err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs, data);
+	err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs);
 	if (err)
 		return err;
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -108,11 +108,9 @@ struct pci_msi_desc {
 
 /**
  * platform_msi_desc - Platform device specific msi descriptor data
- * @msi_priv_data:	Pointer to platform private data
  * @msi_index:		The index of the MSI descriptor for multi MSI
  */
 struct platform_msi_desc {
-	struct platform_msi_priv_data	*msi_priv_data;
 	u16				msi_index;
 };
 
@@ -177,10 +175,12 @@ struct msi_desc {
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
  * @attrs:		Pointer to the sysfs attribute group
+ * @platform_data:	Platform-MSI specific data
  */
 struct msi_device_data {
 	unsigned long			properties;
 	const struct attribute_group    **attrs;
+	struct platform_msi_priv_data	*platform_data;
 };
 
 int msi_setup_device_data(struct device *dev);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240015.416130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002Vk-8K; Mon, 06 Dec 2021 22:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240015.416130; Mon, 06 Dec 2021 22:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002Vd-4O; Mon, 06 Dec 2021 22:46:57 +0000
Received: by outflank-mailman (input) for mailman id 240015;
 Mon, 06 Dec 2021 22:46:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdb-0004dp-3K
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:11 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 53ee1db7-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 53ee1db7-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.091930107@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830349;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=n4LO8stu5mGmwD6jOLFnf2l6OMPt5RNuOGZfmjkddmQ=;
	b=rjIxyN8QC2vhOXoTwRPxWIt7XOHd2pV0YIUa3ZKXyy1j8+wg7w2g/XTz0zmH2uz4PtMgwm
	eCuc5ZkFTVuHEUtxljG6Mtx8djpjDWQBR6ZABksN/jDGBPfaitWUY7RV1Ik1BWVPVePWSO
	82sIPeEbwY4zOLlKmNOyo8+AafHaf9XQEuz8ezNbeFbIp0Yq5mV/qMKHKce9Nm/zjTN8CX
	9kdG08nwWQBYYekVlZcVZG8Y2RVLUYCa+T3kWdZ4MfKQrjFc7x2dULMyBAkEEYpjYoW0Ih
	FfaJqqxuFsVbVZhNxGhrQehlWuNAEG+wx7cJ2uo/yeV87VUb3o+GbwBbLatfrQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830349;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=n4LO8stu5mGmwD6jOLFnf2l6OMPt5RNuOGZfmjkddmQ=;
	b=gby6WXMDPaO+J7o/hfTSRCCEJ6lb9LZRxZLQqYPdbxxo8839/QokO3BHWvmD0YNS+w6173
	XQA1G6Lz0DyhgZCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 08/36] PCI/MSI: Let the irq code handle sysfs groups
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:09 +0100 (CET)

Set the domain info flag which makes the core code handle sysfs groups and
put an explicit invocation into the legacy code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/irqdomain.c |    2 +-
 drivers/pci/msi/legacy.c    |    6 +++++-
 drivers/pci/msi/msi.c       |   23 -----------------------
 include/linux/pci.h         |    1 -
 4 files changed, 6 insertions(+), 26 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -159,7 +159,7 @@ struct irq_domain *pci_msi_create_irq_do
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		pci_msi_domain_update_chip_ops(info);
 
-	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS;
 	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
 		info->flags |= MSI_FLAG_MUST_REACTIVATE;
 
--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -70,10 +70,14 @@ int pci_msi_legacy_setup_msi_irqs(struct
 {
 	int ret = arch_setup_msi_irqs(dev, nvec, type);
 
-	return pci_msi_setup_check_result(dev, type, ret);
+	ret = pci_msi_setup_check_result(dev, type, ret);
+	if (!ret)
+		ret = msi_device_populate_sysfs(&dev->dev);
+	return ret;
 }
 
 void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
 {
+	msi_device_destroy_sysfs(&dev->dev);
 	arch_teardown_msi_irqs(dev);
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -233,11 +233,6 @@ static void free_msi_irqs(struct pci_dev
 			for (i = 0; i < entry->nvec_used; i++)
 				BUG_ON(irq_has_action(entry->irq + i));
 
-	if (dev->msi_irq_groups) {
-		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
-		dev->msi_irq_groups = NULL;
-	}
-
 	pci_msi_teardown_msi_irqs(dev);
 
 	list_for_each_entry_safe(entry, tmp, msi_list, list) {
@@ -417,7 +412,6 @@ static int msi_verify_entries(struct pci
 static int msi_capability_init(struct pci_dev *dev, int nvec,
 			       struct irq_affinity *affd)
 {
-	const struct attribute_group **groups;
 	struct msi_desc *entry;
 	int ret;
 
@@ -441,14 +435,6 @@ static int msi_capability_init(struct pc
 	if (ret)
 		goto err;
 
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto err;
-	}
-
-	dev->msi_irq_groups = groups;
-
 	/* Set MSI enabled bits	*/
 	pci_intx_for_msi(dev, 0);
 	pci_msi_set_enable(dev, 1);
@@ -576,7 +562,6 @@ static void msix_mask_all(void __iomem *
 static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
 				int nvec, struct irq_affinity *affd)
 {
-	const struct attribute_group **groups;
 	void __iomem *base;
 	int ret, tsize;
 	u16 control;
@@ -618,14 +603,6 @@ static int msix_capability_init(struct p
 
 	msix_update_entries(dev, entries);
 
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto out_free;
-	}
-
-	dev->msi_irq_groups = groups;
-
 	/* Set MSI-X enabled bits and unmask the function */
 	pci_intx_for_msi(dev, 0);
 	dev->msix_enabled = 1;
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -475,7 +475,6 @@ struct pci_dev {
 #ifdef CONFIG_PCI_MSI
 	void __iomem	*msix_base;
 	raw_spinlock_t	msi_lock;
-	const struct attribute_group **msi_irq_groups;
 #endif
 	struct pci_vpd	vpd;
 #ifdef CONFIG_PCIE_DPC



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240019.416148 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl8-0002k7-5x; Mon, 06 Dec 2021 22:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240019.416148; Mon, 06 Dec 2021 22:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002i0-Ux; Mon, 06 Dec 2021 22:46:57 +0000
Received: by outflank-mailman (input) for mailman id 240019;
 Mon, 06 Dec 2021 22:46:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdv-0004dp-7F
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:31 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 60556fba-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60556fba-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.798385721@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830370;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=QKm5Bkgh66jv1esKyW8TAnHsECmZ82riLvDb0inI4Eg=;
	b=D895zweyz5rbn/kKNt1XSIZZIuu70zOfe8t7aNy6eaPuk9Jq384UyDeqpSVebKzdt73wdz
	bv7oA/8soERWvg0vMVEhhtWvYy4IfPCtuN/t3lSP2LujCACSKlucdnk1rwd2IuGWqJIFD8
	nOVDr0ME8uC+jRHNJzxXbEtkp66jTzTjncgcDGqbqeAttmBFKXBWKcHTEzc0T76+lCvfWa
	MAQDG916FrRq9K4G7NfDRXGR98nTfIVsRZ1vGbWC8yf3qj15N4x8kVyYNA45iti3xk7yDI
	ytFRfME9YaBXfT1xX96SqT4gmdILXf5V3Ng1EWWU6qBlvAGu+w/79e/X7HV6Ow==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830370;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=QKm5Bkgh66jv1esKyW8TAnHsECmZ82riLvDb0inI4Eg=;
	b=sryxMrjcTSIoBdRCnKd98j0nEMOVFGKXsMpQoApejZmYu5+s8j3Ve6PT3Ubr/cO+sp4m5N
	PPEkyZUsYvUJINDg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 21/36] x86/apic/msi: Use device MSI properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:29 +0100 (CET)

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 arch/x86/kernel/apic/msi.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -160,11 +160,8 @@ static struct irq_chip pci_msi_controlle
 int pci_msi_prepare(struct irq_domain *domain, struct device *dev, int nvec,
 		    msi_alloc_info_t *arg)
 {
-	struct pci_dev *pdev = to_pci_dev(dev);
-	struct msi_desc *desc = first_pci_msi_entry(pdev);
-
 	init_irq_alloc_info(arg, NULL);
-	if (desc->pci.msi_attrib.is_msix) {
+	if (msi_device_has_property(dev, MSI_PROP_PCI_MSIX)) {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
 	} else {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240017.416134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002ZF-HD; Mon, 06 Dec 2021 22:46:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240017.416134; Mon, 06 Dec 2021 22:46:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl7-0002Xp-Cq; Mon, 06 Dec 2021 22:46:57 +0000
Received: by outflank-mailman (input) for mailman id 240017;
 Mon, 06 Dec 2021 22:46:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdl-0004dp-Qb
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:21 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5aae3233-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aae3233-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.473077764@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830360;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9ziMvUfbUs4OErmxFVQP8yEpJ5iNmk70DQs7Nw/O3wo=;
	b=Fdu+KKb02jMNQ8o/TXGZyft89tiIFDW9ofAMDUWGRGFpStmY3dLr0eJeBG1DMd//mzikWk
	ZTtI9hqSK0kehxo/5XM/OjuuM6tgTxRGKhPy6Mk6vfu8xSBVRyJJwfRf++F4ttsUbnwtkx
	Y+ZWVM8uxZ7oMyjADIGCnFly1pd5RUQ/fKSrVw3L3NKDy9vkmY8brMTQqpufEt8SMxDwi6
	71rlSLkBVyjtStG6NMcHXkYV8esLw7UE5uj8GwIgIl8HL1s7P1XonXFdfwgsqgUEmat143
	GUndOKS1X/bKnK1ZWnPlLnpK+x7Ki/Fwlyweyb33NrieA9GmMGHnS6dLKCkpLA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830360;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9ziMvUfbUs4OErmxFVQP8yEpJ5iNmk70DQs7Nw/O3wo=;
	b=Yunk42w9+62iIEZTJZNX9m+Oj4qXYK6UASeXhzhHr+9LON/qqQGgf1xIzGOgtedYDopKaj
	19G6J8YzkM/EO5Dw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 15/36] bus: fsl-mc-msi: Use msi_desc::msi_index
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:20 +0100 (CET)

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/bus/fsl-mc/fsl-mc-allocator.c |    2 +-
 drivers/bus/fsl-mc/fsl-mc-msi.c       |    6 +++---
 include/linux/msi.h                   |   10 ----------
 3 files changed, 4 insertions(+), 14 deletions(-)

--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -393,7 +393,7 @@ int fsl_mc_populate_irq_pool(struct fsl_
 	}
 
 	for_each_msi_entry(msi_desc, &mc_bus_dev->dev) {
-		mc_dev_irq = &irq_resources[msi_desc->fsl_mc.msi_index];
+		mc_dev_irq = &irq_resources[msi_desc->msi_index];
 		mc_dev_irq->msi_desc = msi_desc;
 		mc_dev_irq->resource.id = msi_desc->irq;
 	}
--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -29,7 +29,7 @@ static irq_hw_number_t fsl_mc_domain_cal
 	 * Make the base hwirq value for ICID*10000 so it is readable
 	 * as a decimal value in /proc/interrupts.
 	 */
-	return (irq_hw_number_t)(desc->fsl_mc.msi_index + (dev->icid * 10000));
+	return (irq_hw_number_t)(desc->msi_index + (dev->icid * 10000));
 }
 
 static void fsl_mc_msi_set_desc(msi_alloc_info_t *arg,
@@ -122,7 +122,7 @@ static void fsl_mc_msi_write_msg(struct
 	struct fsl_mc_device *mc_bus_dev = to_fsl_mc_device(msi_desc->dev);
 	struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_bus_dev);
 	struct fsl_mc_device_irq *mc_dev_irq =
-		&mc_bus->irq_resources[msi_desc->fsl_mc.msi_index];
+		&mc_bus->irq_resources[msi_desc->msi_index];
 
 	msi_desc->msg = *msg;
 
@@ -235,7 +235,7 @@ static int fsl_mc_msi_alloc_descs(struct
 			goto cleanup_msi_descs;
 		}
 
-		msi_desc->fsl_mc.msi_index = i;
+		msi_desc->msi_index = i;
 		INIT_LIST_HEAD(&msi_desc->list);
 		list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 	}
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -106,14 +106,6 @@ struct pci_msi_desc {
 };
 
 /**
- * fsl_mc_msi_desc - FSL-MC device specific msi descriptor data
- * @msi_index:		The index of the MSI descriptor
- */
-struct fsl_mc_msi_desc {
-	u16				msi_index;
-};
-
-/**
  * ti_sci_inta_msi_desc - TISCI based INTA specific msi descriptor data
  * @dev_index: TISCI device index
  */
@@ -136,7 +128,6 @@ struct ti_sci_inta_msi_desc {
  *
  * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
  * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
  */
 struct msi_desc {
@@ -157,7 +148,6 @@ struct msi_desc {
 	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
-		struct fsl_mc_msi_desc		fsl_mc;
 		struct ti_sci_inta_msi_desc	inta;
 	};
 };



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240020.416156 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl8-0002uE-L7; Mon, 06 Dec 2021 22:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240020.416156; Mon, 06 Dec 2021 22:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMl8-0002of-9r; Mon, 06 Dec 2021 22:46:58 +0000
Received: by outflank-mailman (input) for mailman id 240020;
 Mon, 06 Dec 2021 22:46:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeB-0004dp-BD
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:47 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 69ef761d-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 69ef761d-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.343885841@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830386;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=b+nZ88WC2vD5W5n7RNFx/r8UkB+MFzrqoW9QgVGfhmI=;
	b=iwrgnjkZBMa2IKJv9GR2TqvukXqu2pkFrxVjyoHHECtn4Rc9LgNQQNExFqlLTV68Uz6Uft
	rYPKPMZf2YrALowU0yX92pDkp2jtIINx3wHfcb8bZ+UojtO69Zdu/Im3WAsWvXwGD+ZHu4
	qDASgqvtA67NHfTjtLEz1g6pO7eTFk7owK2I9iBDKOOGOcssFBcvzRkjgZzmyXb5qMTBPv
	/9hacvluJ9Ktt0ExrIUqTyL9ldBv8dy6d9aSw7RMxr+mObk5LqYd35pCb8fqtIxmAz38sL
	HU6D7envfFV+DRskiNV0bGxVZeWLt8SRFz6J6jjRDSR96CoViUYZ64Erl8yMpw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830386;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=b+nZ88WC2vD5W5n7RNFx/r8UkB+MFzrqoW9QgVGfhmI=;
	b=/cbCkUOyxJbsNJMXB3K5nPxHxtl6ty6WuSd175VsB9cZHdXcERW1MvVY/sZjbqrcAZYPTG
	4Qpef42t/or8mfAg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Vinod Koul <vkoul@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 31/36] perf/smmuv3: Use msi_get_virq()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:45 +0100 (CET)

Let the core code fiddle with the MSI descriptor retrieval.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/perf/arm_smmuv3_pmu.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/perf/arm_smmuv3_pmu.c
+++ b/drivers/perf/arm_smmuv3_pmu.c
@@ -684,7 +684,6 @@ static void smmu_pmu_write_msi_msg(struc
 
 static void smmu_pmu_setup_msi(struct smmu_pmu *pmu)
 {
-	struct msi_desc *desc;
 	struct device *dev = pmu->dev;
 	int ret;
 
@@ -701,9 +700,7 @@ static void smmu_pmu_setup_msi(struct sm
 		return;
 	}
 
-	desc = first_msi_entry(dev);
-	if (desc)
-		pmu->irq = desc->irq;
+	pmu->irq = msi_get_virq(dev, 0);
 
 	/* Add callback to free MSIs on teardown */
 	devm_add_action(dev, smmu_pmu_free_msis, dev);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240031.416184 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlY-0005CA-WD; Mon, 06 Dec 2021 22:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240031.416184; Mon, 06 Dec 2021 22:47:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlY-0005C3-TH; Mon, 06 Dec 2021 22:47:24 +0000
Received: by outflank-mailman (input) for mailman id 240031;
 Mon, 06 Dec 2021 22:47:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeE-0004dp-LK
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:50 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6be47ab4-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6be47ab4-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.455293905@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830389;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=D2KO9NgXNtQUAyqtWOzZiACp/P45gmD0I5rs+jvB/0o=;
	b=M3Bm84hHvCtrBNwRLdnOJQ8LhTnimeLoUzb7sFPpUvA1MrTtFmPG7jJY3ez6nb6d75oHYZ
	YItW1zlXrieNeQLVv1mja5y6Nsn7Af4+zqcIRigzRA4z6xxKseElSF8My8ONtxtDcbBMxB
	RU2wu+cjJc5BODY4ZEABMlFzsdpRqvn+y6tmMTQMln8ybzz0/Jyujbt0wVvxd67z54pWat
	P6701ltig/ZapqMzfQrWZq5bDgERLGtqI56xSaxFnAfkS9KMlbEOolAF+wr1giyaioGNXC
	q25gnAKxhbPlgLV44h2qmIWZqF0AC+M+K6BlmaYeIgQ0aE/P4MbJxUspA9jGVg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830389;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=D2KO9NgXNtQUAyqtWOzZiACp/P45gmD0I5rs+jvB/0o=;
	b=dlz4lZgPNqH4tCZ8r0aZLbuaEV9G+vYCQYuS+28ui/Lf3zD0ZPPTaUWTBAlVcJyi4e33Dj
	inujCGHbNZwGyeCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V2 33/36] mailbox: bcm-flexrm-mailbox: Rework MSI interrupt handling
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:49 +0100 (CET)

No point in retrieving the MSI descriptors. Just query the Linux interrupt
number.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/mailbox/bcm-flexrm-mailbox.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1497,7 +1497,6 @@ static int flexrm_mbox_probe(struct plat
 	int index, ret = 0;
 	void __iomem *regs;
 	void __iomem *regs_end;
-	struct msi_desc *desc;
 	struct resource *iomem;
 	struct flexrm_ring *ring;
 	struct flexrm_mbox *mbox;
@@ -1608,10 +1607,8 @@ static int flexrm_mbox_probe(struct plat
 		goto fail_destroy_cmpl_pool;
 
 	/* Save alloced IRQ numbers for each ring */
-	for_each_msi_entry(desc, dev) {
-		ring = &mbox->rings[desc->msi_index];
-		ring->irq = desc->irq;
-	}
+	for (index = 0; index < mbox->num_rings; index++)
+		mbox->rings[index].irq = msi_get_virq(dev, index);
 
 	/* Check availability of debugfs */
 	if (!debugfs_initialized())



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240032.416190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlZ-0005Fx-Cn; Mon, 06 Dec 2021 22:47:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240032.416190; Mon, 06 Dec 2021 22:47:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlZ-0005EQ-4V; Mon, 06 Dec 2021 22:47:25 +0000
Received: by outflank-mailman (input) for mailman id 240032;
 Mon, 06 Dec 2021 22:47:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdk-0004dp-CN
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:20 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59be0317-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59be0317-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.419160862@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830359;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=6EMMNpvyXK75OtHIkqDafkCPKjNT6UjlrUiD6k/V/Kc=;
	b=0z7xCFi/09vRAK0bIazveOxr26GEWEhb+vcWJ0gZbQWEK9Ut/y/r+UU+n0jUtmeUItwok2
	8FGGX6iEwPWPmXC7rY85oXM/8XjhvYhQBAU6xhDN+C37borrNOsEF/j7UqnXLTFNeUNTkt
	wyXImnXaXo+0rFOvuURNfN7ZrCjN8kQgxK22dXadc61KJppUMDy/vuERX2stUTH5IjcgIY
	CzU1zkIlt6lry0dLrmsxP7YvsBZpF36Mc12I5C8ZBcy7YVV2297T1073OywWAyXuFM/6ai
	gp5HPFQAv6ZxL3YvA54sazPuaneFlKhqRxiEyprKK+dRLFS/Hssu2vV315XiOw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830359;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=6EMMNpvyXK75OtHIkqDafkCPKjNT6UjlrUiD6k/V/Kc=;
	b=TGcSLRy94hDV8xdvp8TAIgWTSEQtpXZHPDCy7tgDaxex0jesp8aPKSls8gX7M0+StNJMfG
	II3wNxwVIbxub4Cw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-arm-kernel@lists.infradead.org,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 14/36] platform-msi: Use msi_desc::msi_index
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:18 +0100 (CET)

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: iommu@lists.linux-foundation.org
Cc: dmaengine@vger.kernel.org
---
 drivers/base/platform-msi.c                 |   10 +++++-----
 drivers/dma/qcom/hidma.c                    |    4 ++--
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |    4 ++--
 drivers/mailbox/bcm-flexrm-mailbox.c        |    4 ++--
 include/linux/msi.h                         |   10 ----------
 5 files changed, 11 insertions(+), 21 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -40,7 +40,7 @@ static irq_hw_number_t platform_msi_calc
 {
 	u32 devid = desc->dev->msi.data->platform_data->devid;
 
-	return (devid << (32 - DEV_ID_SHIFT)) | desc->platform.msi_index;
+	return (devid << (32 - DEV_ID_SHIFT)) | desc->msi_index;
 }
 
 static void platform_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *desc)
@@ -112,8 +112,8 @@ static void platform_msi_free_descs(stru
 	struct msi_desc *desc, *tmp;
 
 	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		if (desc->platform.msi_index >= base &&
-		    desc->platform.msi_index < (base + nvec)) {
+		if (desc->msi_index >= base &&
+		    desc->msi_index < (base + nvec)) {
 			list_del(&desc->list);
 			free_msi_entry(desc);
 		}
@@ -129,7 +129,7 @@ static int platform_msi_alloc_descs_with
 	if (!list_empty(dev_to_msi_list(dev))) {
 		desc = list_last_entry(dev_to_msi_list(dev),
 				       struct msi_desc, list);
-		base = desc->platform.msi_index + 1;
+		base = desc->msi_index + 1;
 	}
 
 	for (i = 0; i < nvec; i++) {
@@ -137,7 +137,7 @@ static int platform_msi_alloc_descs_with
 		if (!desc)
 			break;
 
-		desc->platform.msi_index = base + i;
+		desc->msi_index = base + i;
 		desc->irq = virq ? virq + i : 0;
 
 		list_add_tail(&desc->list, dev_to_msi_list(dev));
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -666,7 +666,7 @@ static void hidma_write_msi_msg(struct m
 	struct device *dev = msi_desc_to_dev(desc);
 	struct hidma_dev *dmadev = dev_get_drvdata(dev);
 
-	if (!desc->platform.msi_index) {
+	if (!desc->msi_index) {
 		writel(msg->address_lo, dmadev->dev_evca + 0x118);
 		writel(msg->address_hi, dmadev->dev_evca + 0x11C);
 		writel(msg->data, dmadev->dev_evca + 0x120);
@@ -702,7 +702,7 @@ static int hidma_request_msi(struct hidm
 		return rc;
 
 	for_each_msi_entry(desc, &pdev->dev) {
-		if (!desc->platform.msi_index)
+		if (!desc->msi_index)
 			dmadev->msi_virqbase = desc->irq;
 
 		rc = devm_request_irq(&pdev->dev, desc->irq,
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3142,7 +3142,7 @@ static void arm_smmu_write_msi_msg(struc
 	phys_addr_t doorbell;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct arm_smmu_device *smmu = dev_get_drvdata(dev);
-	phys_addr_t *cfg = arm_smmu_msi_cfg[desc->platform.msi_index];
+	phys_addr_t *cfg = arm_smmu_msi_cfg[desc->msi_index];
 
 	doorbell = (((u64)msg->address_hi) << 32) | msg->address_lo;
 	doorbell &= MSI_CFG0_ADDR_MASK;
@@ -3183,7 +3183,7 @@ static void arm_smmu_setup_msis(struct a
 	}
 
 	for_each_msi_entry(desc, dev) {
-		switch (desc->platform.msi_index) {
+		switch (desc->msi_index) {
 		case EVTQ_MSI_INDEX:
 			smmu->evtq.q.irq = desc->irq;
 			break;
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1484,7 +1484,7 @@ static void flexrm_mbox_msi_write(struct
 {
 	struct device *dev = msi_desc_to_dev(desc);
 	struct flexrm_mbox *mbox = dev_get_drvdata(dev);
-	struct flexrm_ring *ring = &mbox->rings[desc->platform.msi_index];
+	struct flexrm_ring *ring = &mbox->rings[desc->msi_index];
 
 	/* Configure per-Ring MSI registers */
 	writel_relaxed(msg->address_lo, ring->regs + RING_MSI_ADDR_LS);
@@ -1609,7 +1609,7 @@ static int flexrm_mbox_probe(struct plat
 
 	/* Save alloced IRQ numbers for each ring */
 	for_each_msi_entry(desc, dev) {
-		ring = &mbox->rings[desc->platform.msi_index];
+		ring = &mbox->rings[desc->msi_index];
 		ring->irq = desc->irq;
 	}
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -106,14 +106,6 @@ struct pci_msi_desc {
 };
 
 /**
- * platform_msi_desc - Platform device specific msi descriptor data
- * @msi_index:		The index of the MSI descriptor for multi MSI
- */
-struct platform_msi_desc {
-	u16				msi_index;
-};
-
-/**
  * fsl_mc_msi_desc - FSL-MC device specific msi descriptor data
  * @msi_index:		The index of the MSI descriptor
  */
@@ -144,7 +136,6 @@ struct ti_sci_inta_msi_desc {
  *
  * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @platform:	[platform]  Platform device specific msi descriptor data
  * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
  * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
  */
@@ -166,7 +157,6 @@ struct msi_desc {
 	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
-		struct platform_msi_desc	platform;
 		struct fsl_mc_msi_desc		fsl_mc;
 		struct ti_sci_inta_msi_desc	inta;
 	};



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240034.416206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlb-0005me-JF; Mon, 06 Dec 2021 22:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240034.416206; Mon, 06 Dec 2021 22:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlb-0005mT-FO; Mon, 06 Dec 2021 22:47:27 +0000
Received: by outflank-mailman (input) for mailman id 240034;
 Mon, 06 Dec 2021 22:47:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe1-0004dp-UA
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:37 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64510e66-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64510e66-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.021277807@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830376;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OQ0f5KjFgbSgmAVP4hnPtoqFO6q3+Ey9wT8c/Y+fgX8=;
	b=qT4xZpBBQ0W0WAPiWf1zJJDYqrWw+ae2Lg455lzO/6P3dumvTkmmO4OyNNpV7Ehjg/w2fl
	manHJleIsU6+wlUO34qbZ1k6P6+fjxe8BUkOz6OIEK3o0dKzrtvUgPypQwoUUUNIuZDXWM
	jnT7oY4poA/FbJovF4S/oz4eehalct4S0HCuDJJLpJBmvaR5HibVjBTc7GIHDoqZivOfX3
	iNd/9PdHT8ILfKUVyXiifKPtOz1VtZWGnO4Nr1SM+0tOgRkRXdJgokjEVSeB/BR9gvjNQB
	gsA5BgMNnlWPVbKtzFcSx9515yBP8sGdsrFziNqK9jyPrTDomPQd0ggxKPGeng==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830376;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OQ0f5KjFgbSgmAVP4hnPtoqFO6q3+Ey9wT8c/Y+fgX8=;
	b=pP/dPC6PWwsNwzwAXjslgxnuRXxlApMSk05YyUr2uPuStX/4iB4GmcP+0fnXmnf907i7Do
	3vW65Ey/2ZjD8lDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 25/36] PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUS
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:36 +0100 (CET)

Provide a domain info flag which makes the core code check for a contiguous
MSI-X index on allocation. That's simpler than checking it at some other
domain callback in architecture code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/irqdomain.c |   16 ++++++++++++++--
 include/linux/msi.h         |    2 ++
 2 files changed, 16 insertions(+), 2 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -89,9 +89,21 @@ static int pci_msi_domain_check_cap(stru
 	if (pci_msi_desc_is_multi_msi(desc) &&
 	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
 		return 1;
-	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
-		return -ENOTSUPP;
 
+	if (desc->pci.msi_attrib.is_msix) {
+		if (!(info->flags & MSI_FLAG_PCI_MSIX))
+			return -ENOTSUPP;
+
+		if (info->flags & MSI_FLAG_MSIX_CONTIGUOUS) {
+			unsigned int idx = 0;
+
+			/* Check for gaps in the entry indices */
+			for_each_msi_entry(desc, dev) {
+				if (desc->msi_index != idx++)
+					return -ENOTSUPP;
+			}
+		}
+	}
 	return 0;
 }
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -376,6 +376,8 @@ enum {
 	MSI_FLAG_LEVEL_CAPABLE		= (1 << 6),
 	/* Populate sysfs on alloc() and destroy it on free() */
 	MSI_FLAG_DEV_SYSFS		= (1 << 7),
+	/* MSI-X entries must be contiguous */
+	MSI_FLAG_MSIX_CONTIGUOUS	= (1 << 8),
 };
 
 int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240036.416218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlf-0006Fp-SI; Mon, 06 Dec 2021 22:47:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240036.416218; Mon, 06 Dec 2021 22:47:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlf-0006FN-OE; Mon, 06 Dec 2021 22:47:31 +0000
Received: by outflank-mailman (input) for mailman id 240036;
 Mon, 06 Dec 2021 22:47:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdd-0004dp-QI
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:13 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 55d43975-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 55d43975-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.202985003@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830352;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jCIs00AnDFN/pc+q7M02Zi/IVzmHXkQ9Es/hPheHeNQ=;
	b=2rP4FoL+xyNZoK6iUxAgaa7dbsHImJq276/KG1o/LUFvLA49PK6zuyNk2tHd1FnpDZe1pj
	WgNT217qYGl9KImId6YuDBfpl4ZBK6ckoB8TbZMLsur0kqWQXSuJhMtOlnBdevGYhX1so1
	8Q7gMjsFNIwBuKizDqmmZmjndYpH/K+ytUK5m4ZxvFwCFrTtMS+R8nNq2SLXmGgvZj/pil
	01qaTS3PEnGoHQJ4ewsijixErWUYRCdGTAkpCz4KtjK+mgnxe0jAde8P4/OBnU0/FCqJ1W
	PpUdfJU2Bnf4bbA7MBJ16iPuIUHeBltKDUmr5wy0U6SWq4ShpwsliojXtUj6Sg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830352;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jCIs00AnDFN/pc+q7M02Zi/IVzmHXkQ9Es/hPheHeNQ=;
	b=vn0WhJVtza9YwvoVinEXZsAJsCpYbIuH3KXYlJb8+4+vUdUnnJxqCHdsQplJVhDzk/K79b
	+BUN5SUUBhz0gtCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 10/36] genirq/msi: Remove the original sysfs interfaces
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:12 +0100 (CET)

No more users. Refactor the core code accordingly and move the global
interface under CONFIG_PCI_MSI_ARCH_FALLBACKS.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |   29 +++++++---------------------
 kernel/irq/msi.c    |   53 +++++++++++++++++++---------------------------------
 2 files changed, 28 insertions(+), 54 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -246,26 +246,6 @@ void __pci_write_msi_msg(struct msi_desc
 void pci_msi_mask_irq(struct irq_data *data);
 void pci_msi_unmask_irq(struct irq_data *data);
 
-#ifdef CONFIG_SYSFS
-int msi_device_populate_sysfs(struct device *dev);
-void msi_device_destroy_sysfs(struct device *dev);
-
-const struct attribute_group **msi_populate_sysfs(struct device *dev);
-void msi_destroy_sysfs(struct device *dev,
-		       const struct attribute_group **msi_irq_groups);
-#else
-static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
-static inline void msi_device_destroy_sysfs(struct device *dev) { }
-
-static inline const struct attribute_group **msi_populate_sysfs(struct device *dev)
-{
-	return NULL;
-}
-static inline void msi_destroy_sysfs(struct device *dev, const struct attribute_group **msi_irq_groups)
-{
-}
-#endif
-
 /*
  * The arch hooks to setup up msi irqs. Default functions are implemented
  * as weak symbols so that they /can/ be overriden by architecture specific
@@ -279,7 +259,14 @@ int arch_setup_msi_irq(struct pci_dev *d
 void arch_teardown_msi_irq(unsigned int irq);
 int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
 void arch_teardown_msi_irqs(struct pci_dev *dev);
-#endif
+#ifdef CONFIG_SYSFS
+int msi_device_populate_sysfs(struct device *dev);
+void msi_device_destroy_sysfs(struct device *dev);
+#else /* CONFIG_SYSFS */
+static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
+static inline void msi_device_destroy_sysfs(struct device *dev) { }
+#endif /* !CONFIG_SYSFS */
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
 
 /*
  * The restore hook is still available even for fully irq domain based
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -131,12 +131,8 @@ static ssize_t msi_mode_show(struct devi
 /**
  * msi_populate_sysfs - Populate msi_irqs sysfs entries for devices
  * @dev:	The device(PCI, platform etc) who will get sysfs entries
- *
- * Return attribute_group ** so that specific bus MSI can save it to
- * somewhere during initilizing msi irqs. If devices has no MSI irq,
- * return NULL; if it fails to populate sysfs, return ERR_PTR
  */
-const struct attribute_group **msi_populate_sysfs(struct device *dev)
+static const struct attribute_group **msi_populate_sysfs(struct device *dev)
 {
 	const struct attribute_group **msi_irq_groups;
 	struct attribute **msi_attrs, *msi_attr;
@@ -227,41 +223,32 @@ int msi_device_populate_sysfs(struct dev
 }
 
 /**
- * msi_destroy_sysfs - Destroy msi_irqs sysfs entries for devices
- * @dev:		The device(PCI, platform etc) who will remove sysfs entries
- * @msi_irq_groups:	attribute_group for device msi_irqs entries
- */
-void msi_destroy_sysfs(struct device *dev, const struct attribute_group **msi_irq_groups)
-{
-	struct device_attribute *dev_attr;
-	struct attribute **msi_attrs;
-	int count = 0;
-
-	if (msi_irq_groups) {
-		sysfs_remove_groups(&dev->kobj, msi_irq_groups);
-		msi_attrs = msi_irq_groups[0]->attrs;
-		while (msi_attrs[count]) {
-			dev_attr = container_of(msi_attrs[count],
-					struct device_attribute, attr);
-			kfree(dev_attr->attr.name);
-			kfree(dev_attr);
-			++count;
-		}
-		kfree(msi_attrs);
-		kfree(msi_irq_groups[0]);
-		kfree(msi_irq_groups);
-	}
-}
-
-/**
  * msi_device_destroy_sysfs - Destroy msi_irqs sysfs entries for a device
  * @dev:		The device (PCI, platform etc) for which to remove
  *			sysfs entries
  */
 void msi_device_destroy_sysfs(struct device *dev)
 {
-	msi_destroy_sysfs(dev, dev->msi.data->attrs);
+	const struct attribute_group **msi_irq_groups = dev->msi.data->attrs;
+	struct device_attribute *dev_attr;
+	struct attribute **msi_attrs;
+	int count = 0;
+
 	dev->msi.data->attrs = NULL;
+	if (!msi_irq_groups)
+		return;
+
+	sysfs_remove_groups(&dev->kobj, msi_irq_groups);
+	msi_attrs = msi_irq_groups[0]->attrs;
+	while (msi_attrs[count]) {
+		dev_attr = container_of(msi_attrs[count], struct device_attribute, attr);
+		kfree(dev_attr->attr.name);
+		kfree(dev_attr);
+		++count;
+	}
+	kfree(msi_attrs);
+	kfree(msi_irq_groups[0]);
+	kfree(msi_irq_groups);
 }
 #endif
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240039.416228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlp-00076b-AY; Mon, 06 Dec 2021 22:47:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240039.416228; Mon, 06 Dec 2021 22:47:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlp-00076N-6p; Mon, 06 Dec 2021 22:47:41 +0000
Received: by outflank-mailman (input) for mailman id 240039;
 Mon, 06 Dec 2021 22:47:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe9-0004dp-QF
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:45 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 68fbe46e-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 68fbe46e-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.289194020@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830384;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jjYpKlfviGkOs8GJ86qqUCf8iCclgx/MvIgVwsbGrI8=;
	b=CWfcJ/iBUYjrpon8kS2pojeizMcv7c60QxvaLAU5LI7KfIMvLSxmIM/m6bfUaFi/gGyxAb
	PdqO0v+VPjjzILOgrIY49OVkafA0iReKzvL8PY9tzXeT2OhfpAJ4GW6YLu65K/Ld7nLIG0
	dbzZwwZ742NgY9QLmrAZqlDg1SC6c+Vxj66hiQWNzv4d8TaTEE4oqgYxP5G8UX+MQMw73e
	+b6nz9F4GAlHfDc5dR9qnGxMEdL//gXdSMYdGOcVIGZyzLatX6atJs5gbWAUqCzw+Ld7RN
	hETb0rVdGgYiZNsPAYhQE+wSINXC0JxDMrNyubVTne/6jVvmGPHY/Mo/UsX8LQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830384;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jjYpKlfviGkOs8GJ86qqUCf8iCclgx/MvIgVwsbGrI8=;
	b=wbBVA5z+1RlpKAaa5w62yohCfb98XisYXj6A57jf4CV6E6TSRwWAqsQRcXyzzVkM5x3Dtz
	DSeIPQrauDdTp2AA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 dmaengine@vger.kernel.org,
 Vinod Koul <vkoul@kernel.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 30/36] dmaengine: mv_xor_v2: Get rid of msi_desc abuse
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:44 +0100 (CET)

Storing a pointer to the MSI descriptor just to keep track of the Linux
interrupt number is daft. Use msi_get_virq() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/mv_xor_v2.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -149,7 +149,7 @@ struct mv_xor_v2_descriptor {
  * @desc_size: HW descriptor size
  * @npendings: number of pending descriptors (for which tx_submit has
  * @hw_queue_idx: HW queue index
- * @msi_desc: local interrupt descriptor information
+ * @irq: The Linux interrupt number
  * been called, but not yet issue_pending)
  */
 struct mv_xor_v2_device {
@@ -168,7 +168,7 @@ struct mv_xor_v2_device {
 	int desc_size;
 	unsigned int npendings;
 	unsigned int hw_queue_idx;
-	struct msi_desc *msi_desc;
+	unsigned int irq;
 };
 
 /**
@@ -718,7 +718,6 @@ static int mv_xor_v2_probe(struct platfo
 	int i, ret = 0;
 	struct dma_device *dma_dev;
 	struct mv_xor_v2_sw_desc *sw_desc;
-	struct msi_desc *msi_desc;
 
 	BUILD_BUG_ON(sizeof(struct mv_xor_v2_descriptor) !=
 		     MV_XOR_V2_EXT_DESC_SIZE);
@@ -770,14 +769,9 @@ static int mv_xor_v2_probe(struct platfo
 	if (ret)
 		goto disable_clk;
 
-	msi_desc = first_msi_entry(&pdev->dev);
-	if (!msi_desc) {
-		ret = -ENODEV;
-		goto free_msi_irqs;
-	}
-	xor_dev->msi_desc = msi_desc;
+	xor_dev->irq = msi_get_virq(&pdev->dev, 0);
 
-	ret = devm_request_irq(&pdev->dev, msi_desc->irq,
+	ret = devm_request_irq(&pdev->dev, xor_dev->irq,
 			       mv_xor_v2_interrupt_handler, 0,
 			       dev_name(&pdev->dev), xor_dev);
 	if (ret)
@@ -892,7 +886,7 @@ static int mv_xor_v2_remove(struct platf
 			  xor_dev->desc_size * MV_XOR_V2_DESC_NUM,
 			  xor_dev->hw_desq_virt, xor_dev->hw_desq);
 
-	devm_free_irq(&pdev->dev, xor_dev->msi_desc->irq, xor_dev);
+	devm_free_irq(&pdev->dev, xor_dev->irq, xor_dev);
 
 	platform_msi_domain_free_irqs(&pdev->dev);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240040.416234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlp-00079c-Pr; Mon, 06 Dec 2021 22:47:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240040.416234; Mon, 06 Dec 2021 22:47:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlp-00078k-HG; Mon, 06 Dec 2021 22:47:41 +0000
Received: by outflank-mailman (input) for mailman id 240040;
 Mon, 06 Dec 2021 22:47:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe6-0004dp-KE
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 671ac30f-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 671ac30f-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.181331216@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830381;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VrULNCMH+O8xsmxJgHu1VunM7q/HyFmEpUljbWBlO+M=;
	b=1WyUya3l8fZi6fy1zbrOKQrTo97M/mFRNLJk70qGOPb0JPRgzFKQUP3Ap98oq2yIU+W79y
	WmvByYmwToUfcQdjSAd5N46svh0Lkih1RSbg6furNRI0+XUMr1pOBKIX+irSBkIRN609j/
	jgDcnPD7jjQZ/ZAEDMijZa34I3oXKq99mGxdyY7uvZ2xHboD3lTKRVNV1ahRc0v6NJpUyd
	2djS86MgaRG75KvoijVeoRbChYP6OBHa4h+jnI5iBX5I8xLG5cijyFLO/hLr8BePuB5G8D
	EXG5Csvz4BostgHD1hbblseyHYWXy7KyZk0QJOjUNO2iPqUZZX60PIldxOiaQQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830381;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VrULNCMH+O8xsmxJgHu1VunM7q/HyFmEpUljbWBlO+M=;
	b=4SHbAktYMF4p3JfEkG2RuP8fQBgK7GPTe1sN6CDnwn2pN1kMTUy4TffqwybjaftPt18Fji
	W4koD0rufC6aGiCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 28/36] PCI/MSI: Use __msi_get_virq() in pci_get_vector()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:41 +0100 (CET)

Use msi_get_vector() and handle the return value to be compatible.

No functional change intended.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Handle the INTx case directly instead of trying to be overly smart - Marc
---
 drivers/pci/msi/msi.c |   25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -1032,28 +1032,13 @@ EXPORT_SYMBOL(pci_free_irq_vectors);
  */
 int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
 {
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
+	unsigned int irq;
 
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_index == nr)
-				return entry->irq;
-		}
-		WARN_ON_ONCE(1);
-		return -EINVAL;
-	}
+	if (!dev->msi_enabled && !dev->msix_enabled)
+		return !nr ? dev->irq : -EINVAL;
 
-	if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
-
-		if (WARN_ON_ONCE(nr >= entry->nvec_used))
-			return -EINVAL;
-	} else {
-		if (WARN_ON_ONCE(nr > 0))
-			return -EINVAL;
-	}
-
-	return dev->irq + nr;
+	irq = msi_get_virq(&dev->dev, nr);
+	return irq ? irq : -EINVAL;
 }
 EXPORT_SYMBOL(pci_irq_vector);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240041.416241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlq-0007G7-5f; Mon, 06 Dec 2021 22:47:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240041.416241; Mon, 06 Dec 2021 22:47:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlp-0007Ek-Te; Mon, 06 Dec 2021 22:47:41 +0000
Received: by outflank-mailman (input) for mailman id 240041;
 Mon, 06 Dec 2021 22:47:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdc-0004ul-Jt
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:12 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54db4abf-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54db4abf-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.146453385@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830351;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=NDdACHNkETpAg6PVNWE42mBs5Rd33bpzz4k5zrHM7tw=;
	b=vErMpjt+MCZSBS1ICGFQpx4ysNXbGwI+93xws8KfOZfVncryB+KTjslkXPz+B27v8EaHZT
	0Hc5pfViilVyeeiPM+G5xX8YBHj2/SlqdOEdtJyvNVzLD0hXKGtaBjAMQvKGAyOcP5OWm8
	cZUt/UKPbhSBS0DZsLaRMRntX2BWFbl2Dqkd5iUmlbFUyw5dbrKuYFwA7j5HIKO6tE6hM/
	Ulq3WbR/oBGKMKMTG/Ab7aXWiIISpxs0RrF5z4w7VdpbPWgrEPTVj8VT052BuUhjWhtLSN
	+fOMgQuwcu1sxL0cXpwsBnZgKW2ZC+hBiIuczvBS/Jx+NbjXaTC560HQvAnolw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830351;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=NDdACHNkETpAg6PVNWE42mBs5Rd33bpzz4k5zrHM7tw=;
	b=WM5V9C6MO1EBchUpOkknWZtZQWNoaCYH46V0rZmCJD95akbr+ZDoZFYNhOj++9Z/kWQmKb
	rKp4y6urxJvnScBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 09/36] platform-msi: Let the core code handle sysfs groups
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:10 +0100 (CET)

Set the domain info flag and remove the local sysfs code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |   11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -23,7 +23,6 @@
 struct platform_msi_priv_data {
 	struct device			*dev;
 	void				*host_data;
-	const struct attribute_group    **msi_irq_groups;
 	msi_alloc_info_t		arg;
 	irq_write_msi_msg_t		write_msg;
 	int				devid;
@@ -191,6 +190,7 @@ struct irq_domain *platform_msi_create_i
 		platform_msi_update_dom_ops(info);
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		platform_msi_update_chip_ops(info);
+	info->flags |= MSI_FLAG_DEV_SYSFS;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (domain)
@@ -279,16 +279,8 @@ int platform_msi_domain_alloc_irqs(struc
 	if (err)
 		goto out_free_desc;
 
-	priv_data->msi_irq_groups = msi_populate_sysfs(dev);
-	if (IS_ERR(priv_data->msi_irq_groups)) {
-		err = PTR_ERR(priv_data->msi_irq_groups);
-		goto out_free_irqs;
-	}
-
 	return 0;
 
-out_free_irqs:
-	msi_domain_free_irqs(dev->msi.domain, dev);
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
@@ -308,7 +300,6 @@ void platform_msi_domain_free_irqs(struc
 		struct msi_desc *desc;
 
 		desc = first_msi_entry(dev);
-		msi_destroy_sysfs(dev, desc->platform.msi_priv_data->msi_irq_groups);
 		platform_msi_free_priv_data(desc->platform.msi_priv_data);
 	}
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240042.416248 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlq-0007T6-V3; Mon, 06 Dec 2021 22:47:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240042.416248; Mon, 06 Dec 2021 22:47:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlq-0007RE-HR; Mon, 06 Dec 2021 22:47:42 +0000
Received: by outflank-mailman (input) for mailman id 240042;
 Mon, 06 Dec 2021 22:47:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe0-0004dp-2N
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:36 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63391f34-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63391f34-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.967630948@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830375;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=d9Kmjjh/l2UsbXBaFOpNStl1Xv+nLaUCFqLfxPXo1aU=;
	b=I////PKLH9o1EDmwZHCLir1VYzr7pMRrvKfwrj6/sS1RC/sdwMyhGsRmFNUzSjZKOgIMpc
	VuDsl2yS6Ws4hfoyOmeknB/JxMlXVeaa0NqZ95AAgghhBhdjN4FlW0c1g+csVgtA3fWrV2
	0z0AJ2MhOcSyN1lh/bEWW2f4/Fnzp7391CjPfdN7QKcJV8re5bwovln9v5A9x5IVqN9dZu
	+KxgCyciGG6WjKS91laJQv0xqwFi/Vzr/5mDWBV7Szozjeo04YI0ztWH5F/WSflOvd1MN5
	Qh8s2JiJi8LtYXIr6WLsuyGc4NOos6lvsJnEJd/u4laPT49BgQpCcWza6iNv+A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830375;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=d9Kmjjh/l2UsbXBaFOpNStl1Xv+nLaUCFqLfxPXo1aU=;
	b=ko5ujZLeGAKWmq36MQLxqwIEfx3oa0Eho33ca+wdmkjf4VHoT4ARnE0v9JtdIIR3XsdSb+
	xkZQTZQMwaNiZQCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 24/36] powerpc/pseries/msi: Use MSI device properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:34 +0100 (CET)

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 arch/powerpc/platforms/pseries/msi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -447,9 +447,9 @@ static int rtas_prepare_msi_irqs(struct
 static int pseries_msi_ops_prepare(struct irq_domain *domain, struct device *dev,
 				   int nvec, msi_alloc_info_t *arg)
 {
+	bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
+	int type = is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
 	struct pci_dev *pdev = to_pci_dev(dev);
-	struct msi_desc *desc = first_pci_msi_entry(pdev);
-	int type = desc->pci.msi_attrib.is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
 
 	return rtas_prepare_msi_irqs(pdev, nvec, type, arg);
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240043.416254 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlr-0007dM-FU; Mon, 06 Dec 2021 22:47:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240043.416254; Mon, 06 Dec 2021 22:47:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlr-0007Z2-5H; Mon, 06 Dec 2021 22:47:43 +0000
Received: by outflank-mailman (input) for mailman id 240043;
 Mon, 06 Dec 2021 22:47:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdX-0004dp-5k
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:07 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 51ff35cb-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51ff35cb-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210437.984321429@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wtPMGV5PTpz1yqWy70m2nhuRZOAE9ffD5q8PvX2HIIo=;
	b=FWpnEY9/Zjn8PcmvL5gy8OQMtSAgOf2w5Kf3cMg51UELgoNnReATs8yuuH/ZN3gPg+8scB
	cwvQH9VUFWLlCbLQ6PInp2mwIO9QT0iNFBgnt5onIeLiEqkEFBOgdZAz+8cwUWuNKnQJXa
	N5TO8eSKXeP/bhU8bRF6BIcanMCqXhld7Ah/J7ZPfieGVDvzYhRUv9Y1Au4prmsH1nGOaI
	L67Zrex05IDgdCfyf+Te40MDuirDyGTTT8f7/Pbz9AoruyGC+5CDL6LOU9GL2V+Ucf1Vn1
	W+uptRcO9Dq4pewx8SE1u8QdnFhSbUhLofZvB1Y6DUEEB3qtSVgzRPmv/dHMaA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wtPMGV5PTpz1yqWy70m2nhuRZOAE9ffD5q8PvX2HIIo=;
	b=3iJ1sRdxnOfhMeFz/of0Hh7n9fP3JPzTifzOUTZle2NbTuTSk9CyV+KPnDIDd6tDt73mL5
	s3SenUGZDykxIpDw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Will Deacon <will@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 06/36] soc: ti: ti_sci_inta_msi: Allocate MSI device data
 on first use
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:05 +0100 (CET)

Allocate the MSI device data on first invocation of the allocation function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/soc/ti/ti_sci_inta_msi.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -120,6 +120,10 @@ int ti_sci_inta_msi_domain_alloc_irqs(st
 	if (pdev->id < 0)
 		return -ENODEV;
 
+	ret = msi_setup_device_data(dev);
+	if (ret)
+		return ret;
+
 	nvec = ti_sci_inta_msi_alloc_descs(dev, res);
 	if (nvec <= 0)
 		return nvec;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:47:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:47:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240045.416264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMls-0007qk-AF; Mon, 06 Dec 2021 22:47:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240045.416264; Mon, 06 Dec 2021 22:47:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMlr-0007nF-Pn; Mon, 06 Dec 2021 22:47:43 +0000
Received: by outflank-mailman (input) for mailman id 240045;
 Mon, 06 Dec 2021 22:47:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdt-0004dp-Jk
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:29 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f5eef9d-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f5eef9d-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.742297272@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830368;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=W2lCRcP9RIug8p7Jz6C0/K2R924e9P+4OVHLDtbDEY4=;
	b=NAItHuLmL2ZcCfnzc7fXrckrfGRBHJLTQ6z+8GQi+pDtw3TJzWlrZdzM68dhy4eE1OUrN4
	WQpDNI30CiepjXFq3GVRqOgL6lbHugqbiK1cgKeYZQQlmp0QNv6K3/G1f9qICr1H7udj02
	IL3YCTHnXu0Nc9n7X5/vnjZpUzoBt0BVJmug9p6XoFHASymZZCX8NBeLxW7a+KomP2zscN
	Yw4oyjCuV9LJAUYax/vCmkxmlobmILYr9Kaz4DUGkfdOhTY2fy7moleVn4aZ55FimhJjry
	KhYtaopElknezT4DQ1+BGYb8QpKLSmpd8RvSeJ/uyfPSLa3v/+iGr3ib39VvMg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830368;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=W2lCRcP9RIug8p7Jz6C0/K2R924e9P+4OVHLDtbDEY4=;
	b=1Bo7ypMWpOuT+BmW7TSVzw6bj18E4LKNZBSZWEJqZFWNgSmXB22SiYHDMtnKsfQTyHA/Yy
	OLurUGAL5gX1tZAQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:28 +0100 (CET)

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 arch/x86/pci/xen.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -399,9 +399,7 @@ static void xen_teardown_msi_irqs(struct
 
 static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
 {
-	struct msi_desc *msidesc = first_pci_msi_entry(dev);
-
-	if (msidesc->pci.msi_attrib.is_msix)
+	if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
 		xen_pci_frontend_disable_msix(dev);
 	else
 		xen_pci_frontend_disable_msi(dev);
@@ -417,7 +415,7 @@ static int xen_msi_domain_alloc_irqs(str
 	if (WARN_ON_ONCE(!dev_is_pci(dev)))
 		return -EINVAL;
 
-	if (first_msi_entry(dev)->pci.msi_attrib.is_msix)
+	if (msi_device_has_property(dev, MSI_PROP_PCI_MSIX))
 		type = PCI_CAP_ID_MSIX;
 	else
 		type = PCI_CAP_ID_MSI;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240048.416295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm1-0001Be-Pc; Mon, 06 Dec 2021 22:47:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240048.416295; Mon, 06 Dec 2021 22:47:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm1-0001BN-HW; Mon, 06 Dec 2021 22:47:53 +0000
Received: by outflank-mailman (input) for mailman id 240048;
 Mon, 06 Dec 2021 22:47:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdY-0004dp-Rl
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:08 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 52ed6044-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52ed6044-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.038137622@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830347;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=SYbFcr5c7KUWSHju+5I0IZIliBz6/Q8qUXyaiieHdzI=;
	b=QvCNlsxjJjFZJgdde3bGSosu1Zdk5YzAknkSMOft0kqiy9khbJfX0meWwgcleEXmkDpA6Q
	pG/Gt8h3frgjkaLd3ivOghbKjLxFmVn7ZXBj/mBWPosAprC3e9ZHf2CQd0vU4uQ0IX2bE3
	DIcgOht4L7EcSFUc1y8KcKQOXCGCoLvR8+gBUOfdkCyyDoD2dk/RibJIph/TJLoLZ7f837
	ZaxpD6IoMjaAa3AZwL6mF/gFVnlia7coMdHC/mzGWQ3H+AQZsfBC4WUoKRYdhOXhOCt3so
	5Zuawua4YMWcs7mWRz8XfmGZQAu6rLWJuZkYFq9LaGCnoqpDI0WCTFWoz6TTeA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830347;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=SYbFcr5c7KUWSHju+5I0IZIliBz6/Q8qUXyaiieHdzI=;
	b=PCtebedJJL6H3PzvHb4O9yvA3iLADUQUECYtjroor4l+G6aeGCknrkbTtlePQLRiYJQoK7
	PSwmm0rD4obkidBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V2 07/36] genirq/msi: Provide msi_device_populate/destroy_sysfs()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:07 +0100 (CET)

Add new allocation functions which can be activated by domain info
flags. They store the groups pointer in struct msi_device_data.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |    4 ++++
 kernel/irq/msi.c    |   42 ++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 44 insertions(+), 2 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -56,6 +56,8 @@ struct irq_data;
 struct msi_desc;
 struct pci_dev;
 struct platform_msi_priv_data;
+struct attribute_group;
+
 void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 #ifdef CONFIG_GENERIC_MSI_IRQ
 void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
@@ -174,9 +176,11 @@ struct msi_desc {
 /**
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
+ * @attrs:		Pointer to the sysfs attribute group
  */
 struct msi_device_data {
 	unsigned long			properties;
+	const struct attribute_group    **attrs;
 };
 
 int msi_setup_device_data(struct device *dev);
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -213,6 +213,20 @@ const struct attribute_group **msi_popul
 }
 
 /**
+ * msi_device_populate_sysfs - Populate msi_irqs sysfs entries for a device
+ * @dev:	The device (PCI, platform etc) which will get sysfs entries
+ */
+int msi_device_populate_sysfs(struct device *dev)
+{
+	const struct attribute_group **group = msi_populate_sysfs(dev);
+
+	if (IS_ERR(group))
+		return PTR_ERR(group);
+	dev->msi.data->attrs = group;
+	return 0;
+}
+
+/**
  * msi_destroy_sysfs - Destroy msi_irqs sysfs entries for devices
  * @dev:		The device(PCI, platform etc) who will remove sysfs entries
  * @msi_irq_groups:	attribute_group for device msi_irqs entries
@@ -238,6 +252,17 @@ void msi_destroy_sysfs(struct device *de
 		kfree(msi_irq_groups);
 	}
 }
+
+/**
+ * msi_device_destroy_sysfs - Destroy msi_irqs sysfs entries for a device
+ * @dev:		The device (PCI, platform etc) for which to remove
+ *			sysfs entries
+ */
+void msi_device_destroy_sysfs(struct device *dev)
+{
+	msi_destroy_sysfs(dev, dev->msi.data->attrs);
+	dev->msi.data->attrs = NULL;
+}
 #endif
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
@@ -685,8 +710,19 @@ int msi_domain_alloc_irqs(struct irq_dom
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
+	int ret;
 
-	return ops->domain_alloc_irqs(domain, dev, nvec);
+	ret = ops->domain_alloc_irqs(domain, dev, nvec);
+	if (ret)
+		return ret;
+
+	if (!(info->flags & MSI_FLAG_DEV_SYSFS))
+		return 0;
+
+	ret = msi_device_populate_sysfs(dev);
+	if (ret)
+		msi_domain_free_irqs(domain, dev);
+	return ret;
 }
 
 void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
@@ -725,7 +761,9 @@ void msi_domain_free_irqs(struct irq_dom
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
 
-	return ops->domain_free_irqs(domain, dev);
+	if (info->flags & MSI_FLAG_DEV_SYSFS)
+		msi_device_destroy_sysfs(dev);
+	ops->domain_free_irqs(domain, dev);
 }
 
 /**



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240050.416307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm4-0001oK-EI; Mon, 06 Dec 2021 22:47:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240050.416307; Mon, 06 Dec 2021 22:47:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm4-0001o5-5C; Mon, 06 Dec 2021 22:47:56 +0000
Received: by outflank-mailman (input) for mailman id 240050;
 Mon, 06 Dec 2021 22:47:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe4-0004ul-Ue
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:41 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 661cc391-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 661cc391-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210439.128089025@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830380;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=yTGriMSBQw12ZMYwEGW0S48cT2DY3/1yk7kZdgU1pmY=;
	b=abvHkvl7MHes9mfOR9bqibGGIq+vx064Sx/2IoxZNFoXq1/arNYeM7Fbw9vyud2BFpcCyl
	8gYXLi5T6uox7YrF/wkwGrMbOYbu8YeDNLMftUhInxY9rK7K3bLobmPm3i1yFDmDTt3Sz8
	FivfavzedB+NMyNAHZGsBXI5xY3YXl5/y7Z8BJwltsgNA86ygdtVAKJ9/QL9NYaT4aF83x
	FfUbp+918U2Of/Jb3GGCZN/G6A6CFJdtTNeZeidruI3SVzDwS/Wqx5Mwzt5+j9ENoiITfF
	2EmWdlKv5+TyJK4oh9mDVyz937Nyh0L46t/la0gvE9sDn8q0Hx5sEwvmQSn/0g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830380;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=yTGriMSBQw12ZMYwEGW0S48cT2DY3/1yk7kZdgU1pmY=;
	b=1N0K5YuxqLac5NJ0H3KkeMbsgwgxSEc2RhXJyC59uy5mjovjdeMAYcA2crOwpjyQKiRZJy
	VIAHD13n0j3h8SAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 27/36] genirq/msi: Provide interface to retrieve Linux
 interrupt number
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:39 +0100 (CET)

This allows drivers to retrieve the Linux interrupt number instead of
fiddling with MSI descriptors.

msi_get_virq() returns the Linux interrupt number or 0 in case that there
is no entry for the given MSI index.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Simplify the implementation and let PCI deal with the PCI specialities - Marc
---
 include/linux/msi.h |    2 ++
 kernel/irq/msi.c    |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -170,6 +170,8 @@ static inline bool msi_device_has_proper
 static inline void msi_device_set_properties(struct device *dev, unsigned long prop) { }
 #endif
 
+unsigned int msi_get_virq(struct device *dev, unsigned int index);
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi_list)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -129,6 +129,42 @@ int msi_setup_device_data(struct device
 	return 0;
 }
 
+/**
+ * msi_get_virq - Return Linux interrupt number of a MSI interrupt
+ * @dev:	Device to operate on
+ * @index:	MSI interrupt index to look for (0-based)
+ *
+ * Return: The Linux interrupt number on success (> 0), 0 if not found
+ */
+unsigned int msi_get_virq(struct device *dev, unsigned int index)
+{
+	struct msi_desc *desc;
+	bool pcimsi;
+
+	if (!dev->msi.data)
+		return 0;
+
+	pcimsi = msi_device_has_property(dev, MSI_PROP_PCI_MSI);
+
+	for_each_msi_entry(desc, dev) {
+		/* PCI-MSI has only one descriptor for multiple interrupts. */
+		if (pcimsi) {
+			if (desc->irq && index < desc->nvec_used)
+				return desc->irq + index;
+			break;
+		}
+
+		/*
+		 * PCI-MSIX and platform MSI use a descriptor per
+		 * interrupt.
+		 */
+		if (desc->msi_index == index)
+			return desc->irq;
+	}
+	return 0;
+}
+EXPORT_SYMBOL_GPL(msi_get_virq);
+
 #ifdef CONFIG_SYSFS
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240051.416309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm4-0001tZ-QW; Mon, 06 Dec 2021 22:47:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240051.416309; Mon, 06 Dec 2021 22:47:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMm4-0001s6-Hx; Mon, 06 Dec 2021 22:47:56 +0000
Received: by outflank-mailman (input) for mailman id 240051;
 Mon, 06 Dec 2021 22:47:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdO-0004dp-AD
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:38:58 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4c9c16c8-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:38:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c9c16c8-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210307.625116253@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830336;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=tVxkONw1+URUxuo5QL2ocxThr7/mkfa4+qL7IuxO3Uk=;
	b=IBPmwzRmWD5mL6+e7MwJlzRwVEFnyloQOG5U1+MtcbGwWlmr/iX9fTfUI/80/wO154AnhB
	8DYtOoCiUZGZIX7xxJRto86p8RkbCzd/unh1t58dBbsJrwuPqPvrRLRXrT0esBwzHbNsNa
	qwXZqvTJre7RZQfDg4/dTnBaJ4Vn9A0GgekS+1e4Qf5kRU0iK9FpbDyilXUeeC7+VrAfb5
	IxJNcokipuIGvUWHF5lH8dowLW34B6L9V/hmTpeZhSPpHFMlpyl8w1QpGVxHjEjKadyW2W
	7U4rDr3YJC9E75LoEvXhJG05GptEAkSgVKVq9N1KE7tsTr7r8yq+qfSK1FbT+A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830336;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=tVxkONw1+URUxuo5QL2ocxThr7/mkfa4+qL7IuxO3Uk=;
	b=kGhsuXkAAqnqxB8SQ+Z7lY2BC9yD4sp1NOG0tpAY5Yhj/oSfoQ4S3EJ7Pv7mdUHrVMdkTQ
	yUjnayt7pKthTuCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 00/36] genirq/msi, PCI/MSI: Spring cleaning - Part 2
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Date: Mon,  6 Dec 2021 23:38:56 +0100 (CET)

ClRoaXMgaXMgdGhlIHNlY29uZCBwYXJ0IG9mIFtQQ0ldTVNJIHJlZmFjdG9yaW5nIHdoaWNoIGFp
bXMgdG8gcHJvdmlkZSB0aGUKYWJpbGl0eSBvZiBleHBhbmRpbmcgTVNJLVggdmVjdG9ycyBhZnRl
ciBlbmFibGluZyBNU0ktWC4KClRoZSBmaXJzdCBwYXJ0IG9mIHRoaXMgd29yayBjYW4gYmUgZm91
bmQgaGVyZToKCiAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjExMjA2MjEwMTQ3Ljg3
Mjg2NTgyM0BsaW51dHJvbml4LmRlCgpUaGlzIHNlY29uZCBwYXJ0IGhhcyB0aGUgZm9sbG93aW5n
IGltcG9ydGFudCBjaGFuZ2VzOgoKICAgMSkgQ2xlYW51cCBvZiB0aGUgTVNJIHJlbGF0ZWQgZGF0
YSBpbiBzdHJ1Y3QgZGV2aWNlCgogICAgICBzdHJ1Y3QgZGV2aWNlIGNvbnRhaW5zIGF0IHRoZSBt
b21lbnQgdmFyaW91cyBNU0kgcmVsYXRlZCBwYXJ0cy4gU29tZQogICAgICBvZiB0aGVtICh0aGUg
aXJxIGRvbWFpbiBwb2ludGVyKSBjYW5ub3QgYmUgbW92ZWQgb3V0LCBidXQgdGhlIHJlc3QKICAg
ICAgY2FuIGJlIGFsbG9jYXRlZCBvbiBmaXJzdCB1c2UuIFRoaXMgaXMgaW4gcHJlcGFyYXRpb24g
b2YgYWRkaW5nIG1vcmUKICAgICAgcGVyIGRldmljZSBNU0kgZGF0YSBsYXRlciBvbi4KCiAgIDIp
IENvbnNvbGlkYXRpb24gb2Ygc3lzZnMgaGFuZGxpbmcKCiAgICAgIEFzIGEgZmlyc3Qgc3RlcCB0
aGlzIG1vdmVzIHRoZSBzeXNmcyBwb2ludGVyIGZyb20gc3RydWN0IG1zaV9kZXNjCiAgICAgIGlu
dG8gdGhlIG5ldyBwZXIgZGV2aWNlIE1TSSBkYXRhIHN0cnVjdHVyZSB3aGVyZSBpdCBiZWxvbmdz
LgoKICAgICAgTGF0ZXIgY2hhbmdlcyB3aWxsIGNsZWFudXAgdGhpcyBjb2RlIGZ1cnRoZXIsIGJ1
dCB0aGF0J3Mgbm90IHBvc3NpYmxlCiAgICAgIGF0IHRoaXMgcG9pbnQuCgogICAzKSBTdG9yZSBw
ZXIgZGV2aWNlIHByb3BlcnRpZXMgaW4gdGhlIHBlciBkZXZpY2UgTVNJIGRhdGEgdG8gYXZvaWQK
ICAgICAgbG9va2luZyB1cCBNU0kgZGVzY3JpcHRvcnMgYW5kIGFuYWx5c2luZyB0aGVpciBkYXRh
LiBDbGVhbnVwIGFsbAogICAgICByZWxhdGVkIHVzZSBjYXNlcy4KCiAgIDQpIFByb3ZpZGUgYSBm
dW5jdGlvbiB0byByZXRyaWV2ZSB0aGUgTGludXggaW50ZXJydXB0IG51bWJlciBmb3IgYSBnaXZl
bgogICAgICBNU0kgaW5kZXggc2ltaWxhciB0byBwY2lfaXJxX3ZlY3RvcigpIGFuZCBjbGVhbnVw
IGFsbCBvcGVuIGNvZGVkCiAgICAgIHZhcmlhbnRzLgoKVGhpcyBzZWNvbmQgc2VyaWVzIGlzIGJh
c2VkIG9uOgoKICAgICBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9n
aXQvdGdseC9kZXZlbC5naXQgbXNpLXYyLXBhcnQtMQoKYW5kIGFsc28gYXZhaWxhYmxlIGZyb20g
Z2l0OgoKICAgICBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQv
dGdseC9kZXZlbC5naXQgbXNpLXYyLXBhcnQtMgoKRm9yIHRoZSBjdXJpb3VzIHdobyBjYW4ndCB3
YWl0IGZvciB0aGUgbmV4dCBwYXJ0IHRvIGFycml2ZSB0aGUgZnVsbCBzZXJpZXMKaXMgYXZhaWxh
YmxlIHZpYToKCiAgICAgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwv
Z2l0L3RnbHgvZGV2ZWwuZ2l0IG1zaS12Mi1wYXJ0LTMKClYxIG9mIHRoaXMgc2VyaWVzIGNhbiBi
ZSBmb3VuZCBoZXJlOgoKICAgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMTExMjYyMjQx
MDAuMzAzMDQ2NzQ5QGxpbnV0cm9uaXguZGUKCkNoYW5nZXMgdmVyc3VzIFYxOgoKICAtIEZpeCB0
aGUgcGNpX2lycV92ZWN0b3IoKSB0aGlua28gLSBNYXJjCgogIC0gRml4IHRoZSBwb3dlcnBjIGZh
bGxvdXQgLSBDZWRyaWMsIEFuZHkKCiAgLSBBZGRyZXNzZWQgY29kaW5nc3R5bGUvY29tbWVudHMg
ZmVlZGJhY2sgLSBKb25hdGhhbgoKICAtIEFkZGVkIGEgTVNJIHByb3BlcnRpZXMgc2V0dGVyIHRv
IHByZXBhcmUgZm9yIGxhdGVyIGNoYW5nZXMKCiAgLSBDb25maW5lZCB0aGUgZ2xvYmFsIG1zaSpz
eXNmcyBmdW5jdGlvbnMgdG8gbGVnYWN5IGNvZGUKCiAgLSBEcm9wcGVkIHRoZSBNU0kgbG9jayBw
YXRjaCBhcyB0aGUgbG9jayBoYXMgbW92ZWQgdG8gc3RydWN0IHBjaV9kZXYKICAgIGluIFYyIHBh
cnQtMSBub3cKCiAgLSBQaWNrZWQgdXAgUmV2aWV3ZWQvVGVzdGVkL0Fja2VkLWJ5IHRhZ3MgYXMg
YXBwcm9wcmlhdGUKClRoYW5rcywKCgl0Z2x4Ci0tLQogYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9j
ZWxsL2F4b25fbXNpLmMgICAgICAgICAgICAgIHwgICAgNiAKIGFyY2gvcG93ZXJwYy9wbGF0Zm9y
bXMvcHNlcmllcy9tc2kuYyAgICAgICAgICAgICAgICB8ICAgMzkgKy0tLQogYXJjaC94ODYva2Vy
bmVsL2FwaWMvbXNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNSAKIGFyY2gveDg2
L3BjaS94ZW4uYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDggCiBkcml2
ZXJzL2Jhc2UvcGxhdGZvcm0tbXNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMTUyICsr
KysrKystLS0tLS0tLS0KIGRyaXZlcnMvYnVzL2ZzbC1tYy9kcHJjLWRyaXZlci5jICAgICAgICAg
ICAgICAgICAgICB8ICAgIDggCiBkcml2ZXJzL2J1cy9mc2wtbWMvZnNsLW1jLWFsbG9jYXRvci5j
ICAgICAgICAgICAgICAgfCAgICA5IAogZHJpdmVycy9idXMvZnNsLW1jL2ZzbC1tYy1tc2kuYyAg
ICAgICAgICAgICAgICAgICAgIHwgICAyNiArLQogZHJpdmVycy9kbWEvbXZfeG9yX3YyLmMgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiAtCiBkcml2ZXJzL2RtYS9xY29tL2hpZG1h
LmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDQ0ICsrLS0KIGRyaXZlcnMvZG1hL3Rp
L2szLXVkbWEtcHJpdmF0ZS5jICAgICAgICAgICAgICAgICAgICB8ICAgIDYgCiBkcml2ZXJzL2Rt
YS90aS9rMy11ZG1hLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0IC0KIGRyaXZl
cnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMgICAgICAgICB8ICAgMjMgLS0K
IGRyaXZlcnMvaXJxY2hpcC9pcnEtbWJpZ2VuLmMgICAgICAgICAgICAgICAgICAgICAgICB8ICAg
IDQgCiBkcml2ZXJzL2lycWNoaXAvaXJxLW12ZWJ1LWljdS5jICAgICAgICAgICAgICAgICAgICAg
fCAgIDEyIC0KIGRyaXZlcnMvaXJxY2hpcC9pcnEtdGktc2NpLWludGEuYyAgICAgICAgICAgICAg
ICAgICB8ICAgIDIgCiBkcml2ZXJzL21haWxib3gvYmNtLWZsZXhybS1tYWlsYm94LmMgICAgICAg
ICAgICAgICAgfCAgICA5IAogZHJpdmVycy9uZXQvZXRoZXJuZXQvZnJlZXNjYWxlL2RwYWEyL2Rw
YWEyLWV0aC5jICAgIHwgICAgNCAKIGRyaXZlcnMvbmV0L2V0aGVybmV0L2ZyZWVzY2FsZS9kcGFh
Mi9kcGFhMi1wdHAuYyAgICB8ICAgIDQgCiBkcml2ZXJzL25ldC9ldGhlcm5ldC9mcmVlc2NhbGUv
ZHBhYTIvZHBhYTItc3dpdGNoLmMgfCAgICA1IAogZHJpdmVycy9wY2kvbXNpL2lycWRvbWFpbi5j
ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyMCArLQogZHJpdmVycy9wY2kvbXNpL2xlZ2Fj
eS5jICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNiAKIGRyaXZlcnMvcGNpL21zaS9t
c2kuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAxMTggKysrKy0tLS0tLS0tCiBk
cml2ZXJzL3BjaS94ZW4tcGNpZnJvbnQuYyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAy
IAogZHJpdmVycy9wZXJmL2FybV9zbW11djNfcG11LmMgICAgICAgICAgICAgICAgICAgICAgIHwg
ICAgNSAKIGRyaXZlcnMvc29jL2ZzbC9kcGlvL2RwaW8tZHJpdmVyLmMgICAgICAgICAgICAgICAg
ICB8ICAgIDggCiBkcml2ZXJzL3NvYy90aS9rMy1yaW5nYWNjLmMgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAgICA2IAogZHJpdmVycy9zb2MvdGkvdGlfc2NpX2ludGFfbXNpLmMgICAgICAgICAg
ICAgICAgICAgIHwgICAyMiAtLQogZHJpdmVycy92ZmlvL2ZzbC1tYy92ZmlvX2ZzbF9tY19pbnRy
LmMgICAgICAgICAgICAgIHwgICAgNCAKIGluY2x1ZGUvbGludXgvZGV2aWNlLmggICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICB8ICAgMjUgKysKIGluY2x1ZGUvbGludXgvZnNsL21jLmggICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDQgCiBpbmNsdWRlL2xpbnV4L21zaS5oICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMTEyICsrKysrKy0tLS0tLQogaW5jbHVk
ZS9saW51eC9wY2kuaCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMSAKIGlu
Y2x1ZGUvbGludXgvc29jL3RpL3RpX3NjaV9pbnRhX21zaS5oICAgICAgICAgICAgICB8ICAgIDEg
CiBrZXJuZWwvaXJxL21zaS5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg
MTgyICsrKysrKysrKysrKysrKy0tLS0tCiAzNSBmaWxlcyBjaGFuZ2VkLCA0NjQgaW5zZXJ0aW9u
cygrKSwgNDQ4IGRlbGV0aW9ucygtKQo=


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240054.416328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmB-0003CZ-A2; Mon, 06 Dec 2021 22:48:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240054.416328; Mon, 06 Dec 2021 22:48:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmB-0003Bk-1n; Mon, 06 Dec 2021 22:48:03 +0000
Received: by outflank-mailman (input) for mailman id 240054;
 Mon, 06 Dec 2021 22:48:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdU-0004dp-2i
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:04 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 501f4bbd-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 501f4bbd-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210437.875316747@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830343;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=hFdKqxRH3cfzgioYGe6Wt7w61YxBjqbdkXo6merCrrA=;
	b=OMnExLFiyr2l3DaeHBZpbFl2M24cvNzxDNL/9aYSNE94q++59kEmfVGKa5ZlhAe07Fl3uU
	Za2x9mlRaEoMlFL5FR1Yt9/sqLPoYXCMPjqQw4WwMtRTKofDpynBiY6Jl0rxHJOkcMX9dw
	AKh+hNeiRoS63cA7VuiUq+1N62xSAWLbXP1hCjtAIoq1LsEYItH7wAY5tc4nfMbGGtYDuF
	fJU/wntmrOV0pnsKdqs0t3j9Fcc8XuBSCnFkFMGRffuHbe8KbWxBhE+GGbocWvfNjKYz6q
	jHzrIsyfG/fs3wIXw7Tss35KZPRoYyc8DlL6z8BcWhdY+ZDIBEv4mQdQig+Tog==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830343;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=hFdKqxRH3cfzgioYGe6Wt7w61YxBjqbdkXo6merCrrA=;
	b=Wmw1TW9VtGF7GmA2M1BkXP4IXVGQeS/AtXBgcY5867Qr3359clTNz15RIffmYLeD26efTT
	Tn7VoBQPW9R2PTDw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 04/36] platform-msi: Allocate MSI device data on first use
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:02 +0100 (CET)

Allocate the MSI device data on first invocation of the allocation function
for platform MSI private data.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -204,6 +204,8 @@ platform_msi_alloc_priv_data(struct devi
 			     irq_write_msi_msg_t write_msi_msg)
 {
 	struct platform_msi_priv_data *datap;
+	int err;
+
 	/*
 	 * Limit the number of interrupts to 2048 per device. Should we
 	 * need to bump this up, DEV_ID_SHIFT should be adjusted
@@ -218,6 +220,10 @@ platform_msi_alloc_priv_data(struct devi
 		return ERR_PTR(-EINVAL);
 	}
 
+	err = msi_setup_device_data(dev);
+	if (err)
+		return ERR_PTR(err);
+
 	/* Already had a helping of MSI? Greed... */
 	if (!list_empty(dev_to_msi_list(dev)))
 		return ERR_PTR(-EBUSY);
@@ -229,7 +235,7 @@ platform_msi_alloc_priv_data(struct devi
 	datap->devid = ida_simple_get(&platform_msi_devid_ida,
 				      0, 1 << DEV_ID_SHIFT, GFP_KERNEL);
 	if (datap->devid < 0) {
-		int err = datap->devid;
+		err = datap->devid;
 		kfree(datap);
 		return ERR_PTR(err);
 	}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240055.416333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmB-0003Ht-On; Mon, 06 Dec 2021 22:48:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240055.416333; Mon, 06 Dec 2021 22:48:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmB-0003Fk-Fx; Mon, 06 Dec 2021 22:48:03 +0000
Received: by outflank-mailman (input) for mailman id 240055;
 Mon, 06 Dec 2021 22:48:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeD-0004dp-1f
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:49 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6aec87b3-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6aec87b3-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.400844376@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830388;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lGS+IkXmE+9GAo5xc0vZ9k4XzYRWim7AXuJ3Yf4prmo=;
	b=1rdh0uBIjRFPVJb0NRyQpQptlV/IqltLenr45mOonGb1VHJ/Kb/bZxEHCMdNY6i8Rsl3lU
	3LeqeuR5+/TelAqjf8r4Ks6XK/KIFolBHpOGsdFI5iWQZCh4EyUbbBQRP/UsEqSSd34PqQ
	CGWYXx1l3Ha6SI6sGKdzCI+pjUM3G9v435Md6e0/lLQECkoMsR/nFZ+ZQi1wRTh82GNKIa
	VkCD8Ru4e1/yyGWEO+6kuMDv7hVYoHw87sh+R9wOR482T4v06q6RFEL7LzlekMOKFNQ0af
	GGFaLu61fEzOgmHosPLGbKXOzPYbBO79MG2SX62W7byRtHXl19o2mfrKF/oTmA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830388;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lGS+IkXmE+9GAo5xc0vZ9k4XzYRWim7AXuJ3Yf4prmo=;
	b=ePEtkTTGN09IiG05GytAFMd60ZI7x21kGECcBweiIwUP3OufMZOiTYfQXaXuKmiMIqGKKl
	Sec95JNvjvlYv9Bg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 32/36] iommu/arm-smmu-v3: Use msi_get_virq()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:47 +0100 (CET)

Let the core code fiddle with the MSI descriptor retrieval.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |   19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3154,7 +3154,6 @@ static void arm_smmu_write_msi_msg(struc
 
 static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
 {
-	struct msi_desc *desc;
 	int ret, nvec = ARM_SMMU_MAX_MSIS;
 	struct device *dev = smmu->dev;
 
@@ -3182,21 +3181,9 @@ static void arm_smmu_setup_msis(struct a
 		return;
 	}
 
-	for_each_msi_entry(desc, dev) {
-		switch (desc->msi_index) {
-		case EVTQ_MSI_INDEX:
-			smmu->evtq.q.irq = desc->irq;
-			break;
-		case GERROR_MSI_INDEX:
-			smmu->gerr_irq = desc->irq;
-			break;
-		case PRIQ_MSI_INDEX:
-			smmu->priq.q.irq = desc->irq;
-			break;
-		default:	/* Unknown */
-			continue;
-		}
-	}
+	smmu->evtq.q.irq = msi_get_virq(dev, EVTQ_MSI_INDEX);
+	smmu->gerr_irq = msi_get_virq(dev, GERROR_MSI_INDEX);
+	smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX);
 
 	/* Add callback to free MSIs on teardown */
 	devm_add_action(dev, arm_smmu_free_msis, dev);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240057.416338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmC-0003TC-Mh; Mon, 06 Dec 2021 22:48:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240057.416338; Mon, 06 Dec 2021 22:48:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmC-0003Qv-9m; Mon, 06 Dec 2021 22:48:04 +0000
Received: by outflank-mailman (input) for mailman id 240057;
 Mon, 06 Dec 2021 22:48:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdn-0004ul-9H
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:23 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5b957685-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b957685-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.526615164@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830362;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VsZ3njmr5k39jlVPmLqs7fRziJhKxPsmlZLbUp52Qo0=;
	b=os+tglWF/egYWspIL4wIQv925bxi2zSPElA92tuQBrD7wFk0cN9VKJnJ1F5cVRoYomEcUl
	0Nwi6ypZ5bLCO8Xp+8NRLbSh2/2KXNfxU+z/R8/3Sl9wpfUkcYhEPowdYVRJNxP4bEMEcf
	yXqzkRFAU9AuIcncEGW5vSkSXZmkmHfuRMz2pIBqgby+Y+/pHfvhSS8Q5s4zSGz6ts3tWi
	MHrU4C8JAtaPRxed3hYS+/0wzH0swMzavhozh1/MU5r1YwMkKrdjuyPoaE/CPUx2+DjKKt
	I9XNnOJpgdl0ZZjmJTi83nZKTqL+QkvAHCOYZxC5qFC7NGUXxi541gFWoLCWPA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830362;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VsZ3njmr5k39jlVPmLqs7fRziJhKxPsmlZLbUp52Qo0=;
	b=kAcmRTjch2KsIIY9uLwMdt6zt2R0VkyPFXlUzjeehDD+6pOraR8tyKYfOwTcXWf1sZNmwF
	GFzOX1AIemJS5IBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 16/36] soc: ti: ti_sci_inta_msi: Use msi_desc::msi_index
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:21 +0100 (CET)

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/irqchip/irq-ti-sci-inta.c |    2 +-
 drivers/soc/ti/ti_sci_inta_msi.c  |    6 +++---
 include/linux/msi.h               |   16 ++--------------
 3 files changed, 6 insertions(+), 18 deletions(-)

--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -595,7 +595,7 @@ static void ti_sci_inta_msi_set_desc(msi
 	struct platform_device *pdev = to_platform_device(desc->dev);
 
 	arg->desc = desc;
-	arg->hwirq = TO_HWIRQ(pdev->id, desc->inta.dev_index);
+	arg->hwirq = TO_HWIRQ(pdev->id, desc->msi_index);
 }
 
 static struct msi_domain_ops ti_sci_inta_msi_ops = {
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -84,7 +84,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 				return -ENOMEM;
 			}
 
-			msi_desc->inta.dev_index = res->desc[set].start + i;
+			msi_desc->msi_index = res->desc[set].start + i;
 			INIT_LIST_HEAD(&msi_desc->list);
 			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 			count++;
@@ -96,7 +96,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 				return -ENOMEM;
 			}
 
-			msi_desc->inta.dev_index = res->desc[set].start_sec + i;
+			msi_desc->msi_index = res->desc[set].start_sec + i;
 			INIT_LIST_HEAD(&msi_desc->list);
 			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 			count++;
@@ -154,7 +154,7 @@ unsigned int ti_sci_inta_msi_get_virq(st
 	struct msi_desc *desc;
 
 	for_each_msi_entry(desc, dev)
-		if (desc->inta.dev_index == dev_index)
+		if (desc->msi_index == dev_index)
 			return desc->irq;
 
 	return -ENODEV;
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -107,14 +107,6 @@ struct pci_msi_desc {
 };
 
 /**
- * ti_sci_inta_msi_desc - TISCI based INTA specific msi descriptor data
- * @dev_index: TISCI device index
- */
-struct ti_sci_inta_msi_desc {
-	u16	dev_index;
-};
-
-/**
  * struct msi_desc - Descriptor structure for MSI based interrupts
  * @list:	List head for management
  * @irq:	The base interrupt number
@@ -128,8 +120,7 @@ struct ti_sci_inta_msi_desc {
  * @write_msi_msg_data:	Data parameter for the callback.
  *
  * @msi_index:	Index of the msi descriptor
- * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
+ * @pci:	PCI specific msi descriptor data
  */
 struct msi_desc {
 	/* Shared device/bus type independent data */
@@ -147,10 +138,7 @@ struct msi_desc {
 	void *write_msi_msg_data;
 
 	u16				msi_index;
-	union {
-		struct pci_msi_desc		pci;
-		struct ti_sci_inta_msi_desc	inta;
-	};
+	struct pci_msi_desc		pci;
 };
 
 /**



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240059.416346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmD-0003jY-Ld; Mon, 06 Dec 2021 22:48:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240059.416346; Mon, 06 Dec 2021 22:48:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmD-0003fz-7G; Mon, 06 Dec 2021 22:48:05 +0000
Received: by outflank-mailman (input) for mailman id 240059;
 Mon, 06 Dec 2021 22:48:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdp-0004dp-4c
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:25 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c939c48-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c939c48-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.580265315@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830364;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=d/O1r6GWzPTO4w7Ip6GMyRG2CEhIV9xVE+ieJG1DKcg=;
	b=ojdnHRX7W5rr5t8zmgAtdduINYiu4LKRb3r3f6/OIuuJqOuKFEF33Qc9tCsMsxOMo0pAMr
	+F8r1QeeMA3Retx1ntVN28K5Y/qaIG2ty4z3QGRfiEFR3fbRjaJMkSASbM9vuFOi88WUOi
	cXaMl/eX1jDZ3wKGJOzLGGOg1WqpVMBzez8Wmj3NJneHpyyajjZnUpAcnwv8zPlb8YcNu8
	Ssy5JvnHLhCHhaWPdxx7a+2FB8KJeWcIKmTCoFOBzsBi86LvyGP23bonaaNsHOi7gKbRTI
	nm3qWjOzhBoqBAlGzAVg3DiPUVJEUyXoWkQ+d57nQk1qRIHm2dwa34G/YKJv6g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830364;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=d/O1r6GWzPTO4w7Ip6GMyRG2CEhIV9xVE+ieJG1DKcg=;
	b=T1zOukYCtxQdJiZAo+Gofc+myREXHUhmierFTd/vgp5GQnHweACNbBUj0GjNPf7E6FB4Ek
	PtcJrPzi1uxtP2Dg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 17/36] PCI/MSI: Use msi_desc::msi_index
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:23 +0100 (CET)

The usage of msi_desc::pci::entry_nr is confusing at best. It's the index
into the MSI[X] descriptor table.

Use msi_desc::msi_index which is shared between all MSI incarnations
instead of having a PCI specific storage for no value.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 arch/powerpc/platforms/pseries/msi.c |    4 ++--
 arch/x86/pci/xen.c                   |    2 +-
 drivers/pci/msi/irqdomain.c          |    2 +-
 drivers/pci/msi/msi.c                |   20 ++++++++------------
 drivers/pci/xen-pcifront.c           |    2 +-
 include/linux/msi.h                  |    2 --
 6 files changed, 13 insertions(+), 19 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -332,7 +332,7 @@ static int check_msix_entries(struct pci
 
 	expected = 0;
 	for_each_pci_msi_entry(entry, pdev) {
-		if (entry->pci.msi_attrib.entry_nr != expected) {
+		if (entry->msi_index != expected) {
 			pr_debug("rtas_msi: bad MSI-X entries.\n");
 			return -EINVAL;
 		}
@@ -580,7 +580,7 @@ static int pseries_irq_domain_alloc(stru
 	int hwirq;
 	int i, ret;
 
-	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->pci.msi_attrib.entry_nr);
+	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->msi_index);
 	if (hwirq < 0) {
 		dev_err(&pdev->dev, "Failed to query HW IRQ: %d\n", hwirq);
 		return hwirq;
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -306,7 +306,7 @@ static int xen_initdom_setup_msi_irqs(st
 				return -EINVAL;
 
 			map_irq.table_base = pci_resource_start(dev, bir);
-			map_irq.entry_nr = msidesc->pci.msi_attrib.entry_nr;
+			map_irq.entry_nr = msidesc->msi_index;
 		}
 
 		ret = -EINVAL;
--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -57,7 +57,7 @@ static irq_hw_number_t pci_msi_domain_ca
 {
 	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
 
-	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
+	return (irq_hw_number_t)desc->msi_index |
 		pci_dev_id(dev) << 11 |
 		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -44,7 +44,7 @@ static inline void pci_msi_unmask(struct
 
 static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
 {
-	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
+	return desc->pci.mask_base + desc->msi_index * PCI_MSIX_ENTRY_SIZE;
 }
 
 /*
@@ -356,13 +356,10 @@ msi_setup_entry(struct pci_dev *dev, int
 	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
 		control |= PCI_MSI_FLAGS_MASKBIT;
 
-	entry->pci.msi_attrib.is_msix	= 0;
-	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
-	entry->pci.msi_attrib.is_virtual    = 0;
-	entry->pci.msi_attrib.entry_nr	= 0;
+	entry->pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
 	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
 					  !!(control & PCI_MSI_FLAGS_MASKBIT);
-	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
+	entry->pci.msi_attrib.default_irq = dev->irq;
 	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
 	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
 
@@ -496,12 +493,11 @@ static int msix_setup_entries(struct pci
 		entry->pci.msi_attrib.is_64	= 1;
 
 		if (entries)
-			entry->pci.msi_attrib.entry_nr = entries[i].entry;
+			entry->msi_index = entries[i].entry;
 		else
-			entry->pci.msi_attrib.entry_nr = i;
+			entry->msi_index = i;
 
-		entry->pci.msi_attrib.is_virtual =
-			entry->pci.msi_attrib.entry_nr >= vec_count;
+		entry->pci.msi_attrib.is_virtual = entry->msi_index >= vec_count;
 
 		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
 						  !entry->pci.msi_attrib.is_virtual;
@@ -1034,7 +1030,7 @@ int pci_irq_vector(struct pci_dev *dev,
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
+			if (entry->msi_index == nr)
 				return entry->irq;
 		}
 		WARN_ON_ONCE(1);
@@ -1073,7 +1069,7 @@ const struct cpumask *pci_irq_get_affini
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
+			if (entry->msi_index == nr)
 				return &entry->affinity->mask;
 		}
 		WARN_ON_ONCE(1);
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -263,7 +263,7 @@ static int pci_frontend_enable_msix(stru
 
 	i = 0;
 	for_each_pci_msi_entry(entry, dev) {
-		op.msix_entries[i].entry = entry->pci.msi_attrib.entry_nr;
+		op.msix_entries[i].entry = entry->msi_index;
 		/* Vector is useless at this point. */
 		op.msix_entries[i].vector = -1;
 		i++;
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -80,7 +80,6 @@ typedef void (*irq_write_msi_msg_t)(stru
  * @multi_cap:	[PCI MSI/X] log2 num of messages supported
  * @can_mask:	[PCI MSI/X] Masking supported?
  * @is_64:	[PCI MSI/X] Address size: 0=32bit 1=64bit
- * @entry_nr:	[PCI MSI/X] Entry which is described by this descriptor
  * @default_irq:[PCI MSI/X] The default pre-assigned non-MSI irq
  * @mask_pos:	[PCI MSI]   Mask register position
  * @mask_base:	[PCI MSI-X] Mask register base address
@@ -97,7 +96,6 @@ struct pci_msi_desc {
 		u8	can_mask	: 1;
 		u8	is_64		: 1;
 		u8	is_virtual	: 1;
-		u16	entry_nr;
 		unsigned default_irq;
 	} msi_attrib;
 	union {



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240062.416354 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmE-00045T-Ul; Mon, 06 Dec 2021 22:48:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240062.416354; Mon, 06 Dec 2021 22:48:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmE-00040S-GR; Mon, 06 Dec 2021 22:48:06 +0000
Received: by outflank-mailman (input) for mailman id 240062;
 Mon, 06 Dec 2021 22:48:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdj-0004ul-02
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:19 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 590abf77-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 590abf77-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.364897376@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830357;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lfwGVAEBcyklXLRbPUy5y5GselbZO14/n/aq+dgdtbc=;
	b=j5c3qESX9iBdKToldLXBE4mBiWWAKKPkYIDGM4CivqyqRgWtM2cKGyevuhXVf4+HIOVj8Q
	uFcTY3R24ZImom1z6RqeCXCb6yWXrMHG+qyZ+eZqau2JrqWTtlLIKZuaLDpk5+6fWXaVkN
	zlJdKJEEHNFGXgVT+uAychPQsmGEDwINyyH7moxf9SQkQwQT0+n/dnCqgd5Jk3uI4XxsNa
	lVL4PW2MBwfna8zZ7jo8QaeSVwu128+xqM7vH7CSpqxqPyWgl6PBq3bDqOLBbr+/I7iyDD
	DT11PndTjBvCPLPvVluOl7MWdNjWcKhSTv3uGUyJqmuE4tWaIf6I9k52Vih+PQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830357;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lfwGVAEBcyklXLRbPUy5y5GselbZO14/n/aq+dgdtbc=;
	b=JSs01xY7YCRCdnomelvSKAC22yikmnenmgcpV5rsCfrz12HIIi3qNeX/mh2zqXJLNltFEQ
	nnWFosI79rPNqfBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 13/36] genirq/msi: Consolidate MSI descriptor data
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:17 +0100 (CET)

All non PCI/MSI usage variants have data structures in struct msi_desc with
only one member: xxx_index. PCI/MSI has a entry_nr member.

Add a common msi_index member to struct msi_desc so all implementations can
share it which allows further consolidation.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |    2 ++
 1 file changed, 2 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -142,6 +142,7 @@ struct ti_sci_inta_msi_desc {
  *			address or data changes
  * @write_msi_msg_data:	Data parameter for the callback.
  *
+ * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
  * @platform:	[platform]  Platform device specific msi descriptor data
  * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
@@ -162,6 +163,7 @@ struct msi_desc {
 	void (*write_msi_msg)(struct msi_desc *entry, void *data);
 	void *write_msi_msg_data;
 
+	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
 		struct platform_msi_desc	platform;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240066.416382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmJ-0005IV-2Q; Mon, 06 Dec 2021 22:48:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240066.416382; Mon, 06 Dec 2021 22:48:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmI-0005Gr-Jj; Mon, 06 Dec 2021 22:48:10 +0000
Received: by outflank-mailman (input) for mailman id 240066;
 Mon, 06 Dec 2021 22:48:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdS-0004dp-E9
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:02 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f268673-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f268673-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210437.821900680@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830341;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=0YY6FKU+qkJtNIjBHFuT3gGg88xsiW4iB6UKl0AmwtI=;
	b=gtLyx1uI4U5VlfG4MyQBVx6ekZVpiz/hJtSDGpgc8fcJ7gILFMYCCiR3EJjX0IZuhmYVAb
	BmqVgvOEI/y3Ed/3/UBUV5K5RTOB3ECpcaneiJcP0rxT9MeNN5rIyUEo1Pv3PtSgLgUYNU
	dnq47rZGpN2i2WVB6wI9J/C4sxH5DafOFwNhkSyVSLCKzFcjVLCFGVYCd9f3Fs7jeRn/uZ
	aVr2TQH5m9zO7I0AdAJWxXmpqPbrRxHd0TfUKtx3xuAHbr+qFO44ASkG7T7Sr3YEDi7Tfx
	kuTvLv6LTfhAjG2IhnSIRqieTkKEzepT2+1+TsS9Tt+jmrn09EVsc/uIx7spEA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830341;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=0YY6FKU+qkJtNIjBHFuT3gGg88xsiW4iB6UKl0AmwtI=;
	b=PDX2NcH6oMutIhm4blppHnJIu3p645PCE5S/fYPtzhtyjwQnto1muPhBbSVhrwl/rgluuU
	I6amPjh+RiNE+XDw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 03/36] PCI/MSI: Allocate MSI device data on first use
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:00 +0100 (CET)

Allocate MSI device data on first use, i.e. when a PCI driver invokes one
of the PCI/MSI enablement functions.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/msi.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -889,10 +889,12 @@ static int __pci_enable_msi_range(struct
 /* deprecated, don't use */
 int pci_enable_msi(struct pci_dev *dev)
 {
-	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
-	if (rc < 0)
-		return rc;
-	return 0;
+	int rc = msi_setup_device_data(&dev->dev);
+
+	if (!rc)
+		rc = __pci_enable_msi_range(dev, 1, 1, NULL);
+
+	return rc < 0 ? rc : 0;
 }
 EXPORT_SYMBOL(pci_enable_msi);
 
@@ -947,7 +949,11 @@ static int __pci_enable_msix_range(struc
 int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
 		int minvec, int maxvec)
 {
-	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
+	int ret = msi_setup_device_data(&dev->dev);
+
+	if (!ret)
+		ret = __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
+	return ret;
 }
 EXPORT_SYMBOL(pci_enable_msix_range);
 
@@ -974,8 +980,12 @@ int pci_alloc_irq_vectors_affinity(struc
 				   struct irq_affinity *affd)
 {
 	struct irq_affinity msi_default_affd = {0};
+	int ret = msi_setup_device_data(&dev->dev);
 	int nvecs = -ENOSPC;
 
+	if (ret)
+		return ret;
+
 	if (flags & PCI_IRQ_AFFINITY) {
 		if (!affd)
 			affd = &msi_default_affd;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240068.416393 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmP-0006Nz-CT; Mon, 06 Dec 2021 22:48:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240068.416393; Mon, 06 Dec 2021 22:48:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmP-0006NF-88; Mon, 06 Dec 2021 22:48:17 +0000
Received: by outflank-mailman (input) for mailman id 240068;
 Mon, 06 Dec 2021 22:48:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe3-0004ul-A0
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:39 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65269bd2-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65269bd2-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210439.074795958@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830378;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cOZ0U3ouey82JJdJiPY/OdjPVZlxKAZBH84jVxEoqTU=;
	b=wz3TzWYBvl04aCerKYeWR58lfzMKGU0iQIuBeqOL+QMp3fzox5TmpoLeGGdAyjIdRF9we0
	u9yR0O7Qw/bXjizcycQ1gt+G/WeBK/oTI1LUwf2kX7mBg7E4BLQU+LhtJn98G1rHyhAeXN
	uZibzflizAgUufHizJH6rsQmehdTaX7twbvYr5V+KethG1Scbt8X2tNbTw+IA0tYplWXos
	ZwOGv2nZnU5zW+yHNbttX2IEcKFWRwLT0XfzLzZMFn7NfGrUzA3FstQug2ylwpcRUwc/5i
	kvFiRVvXUUkrTAhTuq9cCrdEEKtF1I+UAps11N3QhGaOgS9dJJn2kcoxCDkHWQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830378;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cOZ0U3ouey82JJdJiPY/OdjPVZlxKAZBH84jVxEoqTU=;
	b=hWRF+jAuLUmdTtCJbsFelzhT8GqoJCFIgM9B0HzB2yZ+yr1G/1kR55tWj9RhnBzNSOA67w
	E7/UVXYkvpVaIZCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 26/36] powerpc/pseries/msi: Let core code check for
 contiguous entries
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:37 +0100 (CET)

Set the domain info flag and remove the check.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Remove it completely - Cedric
---
 arch/powerpc/platforms/pseries/msi.c |   33 ++++++++-------------------------
 1 file changed, 8 insertions(+), 25 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -321,27 +321,6 @@ static int msi_quota_for_device(struct p
 	return request;
 }
 
-static int check_msix_entries(struct pci_dev *pdev)
-{
-	struct msi_desc *entry;
-	int expected;
-
-	/* There's no way for us to express to firmware that we want
-	 * a discontiguous, or non-zero based, range of MSI-X entries.
-	 * So we must reject such requests. */
-
-	expected = 0;
-	for_each_pci_msi_entry(entry, pdev) {
-		if (entry->msi_index != expected) {
-			pr_debug("rtas_msi: bad MSI-X entries.\n");
-			return -EINVAL;
-		}
-		expected++;
-	}
-
-	return 0;
-}
-
 static void rtas_hack_32bit_msi_gen2(struct pci_dev *pdev)
 {
 	u32 addr_hi, addr_lo;
@@ -380,9 +359,6 @@ static int rtas_prepare_msi_irqs(struct
 	if (quota && quota < nvec)
 		return quota;
 
-	if (type == PCI_CAP_ID_MSIX && check_msix_entries(pdev))
-		return -EINVAL;
-
 	/*
 	 * Firmware currently refuse any non power of two allocation
 	 * so we round up if the quota will allow it.
@@ -530,9 +506,16 @@ static struct irq_chip pseries_pci_msi_i
 	.irq_write_msi_msg	= pseries_msi_write_msg,
 };
 
+
+/*
+ * Set MSI_FLAG_MSIX_CONTIGUOUS as there is no way to express to
+ * firmware to request a discontiguous or non-zero based range of
+ * MSI-X entries. Core code will reject such setup attempts.
+ */
 static struct msi_domain_info pseries_msi_domain_info = {
 	.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
-		  MSI_FLAG_MULTI_PCI_MSI  | MSI_FLAG_PCI_MSIX),
+		  MSI_FLAG_MULTI_PCI_MSI  | MSI_FLAG_PCI_MSIX |
+		  MSI_FLAG_MSIX_CONTIGUOUS),
 	.ops   = &pseries_pci_msi_domain_ops,
 	.chip  = &pseries_pci_msi_irq_chip,
 };



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240069.416400 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmQ-0006Wy-8z; Mon, 06 Dec 2021 22:48:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240069.416400; Mon, 06 Dec 2021 22:48:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmP-0006UK-Oz; Mon, 06 Dec 2021 22:48:17 +0000
Received: by outflank-mailman (input) for mailman id 240069;
 Mon, 06 Dec 2021 22:48:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeJ-0004dp-Fr
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:55 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ebe2982-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ebe2982-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.616608151@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830394;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=LQ/fEdCb15XlPMORiCBx0zVLCBalBxQN731AvqWpOBo=;
	b=3Tr/OwgWIjMrczL8k1Y7KpZrpQnBzbzk9jNn+YVhicF0q1/EBaWLJA5EQBnAdsN1D0Wulq
	fAFu1JfAhDg12kjnKrY2feAVfczr4B+D+aUKxqRZIoJXfcp1b/l9lDzmvNTqF83GMPtmNg
	O0L6lFFrGJsZpIUFf96nNzXT4R0YcnNglyNnCKK28eg5CfoXrplM1E/O55dg7JVrhTT4Ku
	8OKWXgKy/6DEHxFU+DSvrITn94Q+Iw/VdTagX65qE9U6P1e6EDxwHz+zW2M2yl46BHw3XE
	y5F6c4xy7ygjQQk0fTm74ujfKrEoV6cO6elD5cK86MxFI4yGcgRgty/GSG5jgw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830394;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=LQ/fEdCb15XlPMORiCBx0zVLCBalBxQN731AvqWpOBo=;
	b=MVm0lNeB+aCsPEoi2uRKK0tL8KdeGC0UXyY+t/l2SKc/6bvFzzrRpVEcjpjs9glSsWZ1fc
	khvHgThvvOwd8zBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Sinan Kaya <okaya@kernel.org>,
 dmaengine@vger.kernel.org,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>
Subject: [patch V2 36/36] dmaengine: qcom_hidma: Cleanup MSI handling
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:54 +0100 (CET)

There is no reason to walk the MSI descriptors to retrieve the interrupt
number for a device. Use msi_get_virq() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Sinan Kaya <okaya@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/qcom/hidma.c |   42 ++++++++++++++++++------------------------
 1 file changed, 18 insertions(+), 24 deletions(-)

--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -678,11 +678,13 @@ static void hidma_free_msis(struct hidma
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 	struct device *dev = dmadev->ddev.dev;
-	struct msi_desc *desc;
+	int i, virq;
 
-	/* free allocated MSI interrupts above */
-	for_each_msi_entry(desc, dev)
-		devm_free_irq(dev, desc->irq, &dmadev->lldev);
+	for (i = 0; i < HIDMA_MSI_INTS; i++) {
+		virq = msi_get_virq(dev, i);
+		if (virq)
+			devm_free_irq(dev, virq, &dmadev->lldev);
+	}
 
 	platform_msi_domain_free_irqs(dev);
 #endif
@@ -692,45 +694,37 @@ static int hidma_request_msi(struct hidm
 			     struct platform_device *pdev)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	int rc;
-	struct msi_desc *desc;
-	struct msi_desc *failed_desc = NULL;
+	int rc, i, virq;
 
 	rc = platform_msi_domain_alloc_irqs(&pdev->dev, HIDMA_MSI_INTS,
 					    hidma_write_msi_msg);
 	if (rc)
 		return rc;
 
-	for_each_msi_entry(desc, &pdev->dev) {
-		if (!desc->msi_index)
-			dmadev->msi_virqbase = desc->irq;
-
-		rc = devm_request_irq(&pdev->dev, desc->irq,
+	for (i = 0; i < HIDMA_MSI_INTS; i++) {
+		virq = msi_get_virq(&pdev->dev, i);
+		rc = devm_request_irq(&pdev->dev, virq,
 				       hidma_chirq_handler_msi,
 				       0, "qcom-hidma-msi",
 				       &dmadev->lldev);
-		if (rc) {
-			failed_desc = desc;
+		if (rc)
 			break;
-		}
+		if (!i)
+			dmadev->msi_virqbase = virq;
 	}
 
 	if (rc) {
 		/* free allocated MSI interrupts above */
-		for_each_msi_entry(desc, &pdev->dev) {
-			if (desc == failed_desc)
-				break;
-			devm_free_irq(&pdev->dev, desc->irq,
-				      &dmadev->lldev);
+		for (--i; i >= 0; i--) {
+			virq = msi_get_virq(&pdev->dev, i);
+			devm_free_irq(&pdev->dev, virq, &dmadev->lldev);
 		}
+		dev_warn(&pdev->dev,
+			 "failed to request MSI irq, falling back to wired IRQ\n");
 	} else {
 		/* Add callback to free MSIs on teardown */
 		hidma_ll_setup_irq(dmadev->lldev, true);
-
 	}
-	if (rc)
-		dev_warn(&pdev->dev,
-			 "failed to request MSI irq, falling back to wired IRQ\n");
 	return rc;
 #else
 	return -EINVAL;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240070.416416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmU-0007Xk-8X; Mon, 06 Dec 2021 22:48:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240070.416416; Mon, 06 Dec 2021 22:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmT-0007XL-W4; Mon, 06 Dec 2021 22:48:21 +0000
Received: by outflank-mailman (input) for mailman id 240070;
 Mon, 06 Dec 2021 22:48:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdy-0004dp-En
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:34 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 623c8baa-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 623c8baa-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210438.913603962@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830373;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Ep5zFYMr2dpuKFMI1pf/izOHx/wmIORxQk2vil3OoJI=;
	b=nfZZ3sBOutSvGHqk1sS290DDgjFJGXEhzG9mKo8h3KNUTS21yvque0kvoe6kdy44X6ihqJ
	rlecPnSuBE8kWWqzbTh8ZfS2t/6i87b9mxuCdiQdAWfWgv/FXfDMxOB4hPcENaQevz8X1t
	sfoi2d3W+glPX+uizuVT258ABJFrCCoKMbU990PZvSPJbq47uN//h7RBBdikCbG4VbXTMa
	uzPGLlJ6oqG4Ba1T/Qi10UeHj0+DdaJ0BuryMFaEruZB4DB4ufEmaO0gHVQmA6rDjulOYP
	4odcYLKYN6S0ZLHgH8AU1siZXSl2RCWz6Zdbj85yUeDpTNP4mcveuhP4LXFExg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830373;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Ep5zFYMr2dpuKFMI1pf/izOHx/wmIORxQk2vil3OoJI=;
	b=zIv8vjiKX+sZKy9gbTJ2X4+XfGOmD/O04fsKImX/MjjZGQEs9MDTD7XhFu7ricmc2LeLAj
	jEryKJg6XslL1KCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:33 +0100 (CET)

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Invoke the function with the correct number of arguments - Andy
---
 arch/powerpc/platforms/cell/axon_msi.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -199,7 +199,7 @@ static struct axon_msic *find_msi_transl
 static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
 {
 	struct device_node *dn;
-	struct msi_desc *entry;
+	bool is_64bit;
 	int len;
 	const u32 *prop;
 
@@ -209,10 +209,10 @@ static int setup_msi_msg_address(struct
 		return -ENODEV;
 	}
 
-	entry = first_pci_msi_entry(dev);
+	is_64bit = msi_device_has_property(&dev->dev, MSI_PROP_64BIT);
 
 	for (; dn; dn = of_get_next_parent(dn)) {
-		if (entry->pci.msi_attrib.is_64) {
+		if (is_64bit) {
 			prop = of_get_property(dn, "msi-address-64", &len);
 			if (prop)
 				break;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240071.416422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmV-0007eU-0W; Mon, 06 Dec 2021 22:48:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240071.416422; Mon, 06 Dec 2021 22:48:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmU-0007bN-GK; Mon, 06 Dec 2021 22:48:22 +0000
Received: by outflank-mailman (input) for mailman id 240071;
 Mon, 06 Dec 2021 22:48:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMds-0004ul-2m
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:28 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e790e71-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e790e71-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.688216619@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830367;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rDy+I3ErSIwPbhu7X1CCkhe4PGVkrX5FRQ61OeZYbi0=;
	b=rdxELXqqCUvF6w5maDZkJ1DUVcE8xtOFQuqB//kVE8LutIsp9x7oY88xYjjcJZGehvl20I
	R+i6TJmT/vTW79Nv4ctZJYRheEWHSoWoguFGJMgyW+Y78A4gZheDTRjB7MKWo1i1SNciQv
	MAkGYA8bGBoVVnZcIEV3q2C/xmLuWz4pSytUusJpxR9xdD6KElclS1+2OYVVTkq2CTV5v0
	K7Qk55Cr9KK7t23ybVmifYXu8ldnDmpJ27OX5lTB0ymWjBlgUMjTEseTLZ8Qod83UjgC9D
	tbU/slR0lNW5luPAEZ2uA0pSeOSKTDgFQBd2KUoEvNi5EWLt9sMAqB45SFUrIA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830367;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rDy+I3ErSIwPbhu7X1CCkhe4PGVkrX5FRQ61OeZYbi0=;
	b=tGgA6BqJjARLsTeCWAn17BXxaUG282LmcuxVJy035n8FdUpejfTN0J30/E3k5C2sIwZD1h
	pHsGs8TzGh+VOpBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:26 +0100 (CET)

Store the properties which are interesting for various places so the MSI
descriptor fiddling can be removed.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Use the setter function
---
 drivers/pci/msi/msi.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -244,6 +244,8 @@ static void free_msi_irqs(struct pci_dev
 		iounmap(dev->msix_base);
 		dev->msix_base = NULL;
 	}
+
+	msi_device_set_properties(&dev->dev, 0);
 }
 
 static void pci_intx_for_msi(struct pci_dev *dev, int enable)
@@ -341,6 +343,7 @@ msi_setup_entry(struct pci_dev *dev, int
 {
 	struct irq_affinity_desc *masks = NULL;
 	struct msi_desc *entry;
+	unsigned long prop;
 	u16 control;
 
 	if (affd)
@@ -372,6 +375,10 @@ msi_setup_entry(struct pci_dev *dev, int
 	if (entry->pci.msi_attrib.can_mask)
 		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
 
+	prop = MSI_PROP_PCI_MSI;
+	if (entry->pci.msi_attrib.is_64)
+		prop |= MSI_PROP_64BIT;
+	msi_device_set_properties(&dev->dev, prop);
 out:
 	kfree(masks);
 	return entry;
@@ -514,6 +521,7 @@ static int msix_setup_entries(struct pci
 		if (masks)
 			curmsk++;
 	}
+	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
 	ret = 0;
 out:
 	kfree(masks);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240074.416438 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmZ-0000HR-Fi; Mon, 06 Dec 2021 22:48:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240074.416438; Mon, 06 Dec 2021 22:48:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmZ-0000Gl-5R; Mon, 06 Dec 2021 22:48:27 +0000
Received: by outflank-mailman (input) for mailman id 240074;
 Mon, 06 Dec 2021 22:48:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeG-0004ul-Js
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:52 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6cda91ee-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6cda91ee-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210439.509185723@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830391;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=MAzri/Ik5YcCf7rqaBTMF5Cuwc5gLSC2IVoV+Z98uqM=;
	b=eNkXff63vr2Q2uY7VZzzS51kJWHiTQ8Ei9UuAfkro31+v28y0JL805IOJNrM9zgQjXwOoy
	f3vue31+qcqig9tHhSMJP1WBdK3VXMOJUDpJ6LjA0WjRzWY239DspymZ/Tnb9u5fghtpg7
	f54iz0Hxah6Bj4pFOigwKc9KaA4OzD/m7gKwWpFMx68HQ2ctQNxFO4mIskKlAgGDUd1gcr
	yTZAlBcvZ+Cjf9HdunsVmkmWC+zKZruFEYPSDPQJEE5uZRKrj74qCM7/l6/7urvMtLddEv
	LxZpFzneCrrjny6BHGYZoEHxHces3Orz45z+E2dUnTstoxDQHpfpO7naza31wA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830391;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=MAzri/Ik5YcCf7rqaBTMF5Cuwc5gLSC2IVoV+Z98uqM=;
	b=1h7Xx/9oH8FwYZLNkKeByCn3tZV2xGgre0G22+oZmN+SvXQeds8+8s5wK0++7gL9dxyRy9
	YFyDZVy0EjjXy2Bw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 34/36] bus: fsl-mc: fsl-mc-allocator: Rework MSI handling
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:50 +0100 (CET)

Storing a pointer to the MSI descriptor just to track the Linux interrupt
number is daft. Just store the interrupt number and be done with it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Stuart Yoder <stuyoder@gmail.com>
---
 drivers/bus/fsl-mc/dprc-driver.c                    |    8 ++++----
 drivers/bus/fsl-mc/fsl-mc-allocator.c               |    9 ++-------
 drivers/bus/fsl-mc/fsl-mc-msi.c                     |    6 +++---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c    |    4 ++--
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c    |    4 +---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c |    5 ++---
 drivers/soc/fsl/dpio/dpio-driver.c                  |    8 ++++----
 drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c              |    4 ++--
 include/linux/fsl/mc.h                              |    4 ++--
 9 files changed, 22 insertions(+), 30 deletions(-)

--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -400,7 +400,7 @@ static irqreturn_t dprc_irq0_handler_thr
 	struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
 	struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_dev);
 	struct fsl_mc_io *mc_io = mc_dev->mc_io;
-	struct msi_desc *msi_desc = mc_dev->irqs[0]->msi_desc;
+	int irq = mc_dev->irqs[0]->virq;
 
 	dev_dbg(dev, "DPRC IRQ %d triggered on CPU %u\n",
 		irq_num, smp_processor_id());
@@ -409,7 +409,7 @@ static irqreturn_t dprc_irq0_handler_thr
 		return IRQ_HANDLED;
 
 	mutex_lock(&mc_bus->scan_mutex);
-	if (!msi_desc || msi_desc->irq != (u32)irq_num)
+	if (irq != (u32)irq_num)
 		goto out;
 
 	status = 0;
@@ -521,7 +521,7 @@ static int register_dprc_irq_handler(str
 	 * function that programs the MSI physically in the device
 	 */
 	error = devm_request_threaded_irq(&mc_dev->dev,
-					  irq->msi_desc->irq,
+					  irq->virq,
 					  dprc_irq0_handler,
 					  dprc_irq0_handler_thread,
 					  IRQF_NO_SUSPEND | IRQF_ONESHOT,
@@ -771,7 +771,7 @@ static void dprc_teardown_irq(struct fsl
 
 	(void)disable_dprc_irq(mc_dev);
 
-	devm_free_irq(&mc_dev->dev, irq->msi_desc->irq, &mc_dev->dev);
+	devm_free_irq(&mc_dev->dev, irq->virq, &mc_dev->dev);
 
 	fsl_mc_free_irqs(mc_dev);
 }
--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -350,7 +350,6 @@ int fsl_mc_populate_irq_pool(struct fsl_
 			     unsigned int irq_count)
 {
 	unsigned int i;
-	struct msi_desc *msi_desc;
 	struct fsl_mc_device_irq *irq_resources;
 	struct fsl_mc_device_irq *mc_dev_irq;
 	int error;
@@ -388,16 +387,12 @@ int fsl_mc_populate_irq_pool(struct fsl_
 		mc_dev_irq->resource.type = res_pool->type;
 		mc_dev_irq->resource.data = mc_dev_irq;
 		mc_dev_irq->resource.parent_pool = res_pool;
+		mc_dev_irq->virq = msi_get_virq(&mc_bus_dev->dev, i);
+		mc_dev_irq->resource.id = mc_dev_irq->virq;
 		INIT_LIST_HEAD(&mc_dev_irq->resource.node);
 		list_add_tail(&mc_dev_irq->resource.node, &res_pool->free_list);
 	}
 
-	for_each_msi_entry(msi_desc, &mc_bus_dev->dev) {
-		mc_dev_irq = &irq_resources[msi_desc->msi_index];
-		mc_dev_irq->msi_desc = msi_desc;
-		mc_dev_irq->resource.id = msi_desc->irq;
-	}
-
 	res_pool->max_count = irq_count;
 	res_pool->free_count = irq_count;
 	mc_bus->irq_resources = irq_resources;
--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -58,11 +58,11 @@ static void fsl_mc_msi_update_dom_ops(st
 }
 
 static void __fsl_mc_msi_write_msg(struct fsl_mc_device *mc_bus_dev,
-				   struct fsl_mc_device_irq *mc_dev_irq)
+				   struct fsl_mc_device_irq *mc_dev_irq,
+				   struct msi_desc *msi_desc)
 {
 	int error;
 	struct fsl_mc_device *owner_mc_dev = mc_dev_irq->mc_dev;
-	struct msi_desc *msi_desc = mc_dev_irq->msi_desc;
 	struct dprc_irq_cfg irq_cfg;
 
 	/*
@@ -129,7 +129,7 @@ static void fsl_mc_msi_write_msg(struct
 	/*
 	 * Program the MSI (paddr, value) pair in the device:
 	 */
-	__fsl_mc_msi_write_msg(mc_bus_dev, mc_dev_irq);
+	__fsl_mc_msi_write_msg(mc_bus_dev, mc_dev_irq, msi_desc);
 }
 
 static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -4246,7 +4246,7 @@ static int dpaa2_eth_setup_irqs(struct f
 	}
 
 	irq = ls_dev->irqs[0];
-	err = devm_request_threaded_irq(&ls_dev->dev, irq->msi_desc->irq,
+	err = devm_request_threaded_irq(&ls_dev->dev, irq->virq,
 					NULL, dpni_irq0_handler_thread,
 					IRQF_NO_SUSPEND | IRQF_ONESHOT,
 					dev_name(&ls_dev->dev), &ls_dev->dev);
@@ -4273,7 +4273,7 @@ static int dpaa2_eth_setup_irqs(struct f
 	return 0;
 
 free_irq:
-	devm_free_irq(&ls_dev->dev, irq->msi_desc->irq, &ls_dev->dev);
+	devm_free_irq(&ls_dev->dev, irq->virq, &ls_dev->dev);
 free_mc_irq:
 	fsl_mc_free_irqs(ls_dev);
 
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
@@ -129,7 +129,6 @@ static irqreturn_t dpaa2_ptp_irq_handler
 static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
 {
 	struct device *dev = &mc_dev->dev;
-	struct fsl_mc_device_irq *irq;
 	struct ptp_qoriq *ptp_qoriq;
 	struct device_node *node;
 	void __iomem *base;
@@ -177,8 +176,7 @@ static int dpaa2_ptp_probe(struct fsl_mc
 		goto err_unmap;
 	}
 
-	irq = mc_dev->irqs[0];
-	ptp_qoriq->irq = irq->msi_desc->irq;
+	ptp_qoriq->irq = mc_dev->irqs[0]->virq;
 
 	err = request_threaded_irq(ptp_qoriq->irq, NULL,
 				   dpaa2_ptp_irq_handler_thread,
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
@@ -1553,8 +1553,7 @@ static int dpaa2_switch_setup_irqs(struc
 
 	irq = sw_dev->irqs[DPSW_IRQ_INDEX_IF];
 
-	err = devm_request_threaded_irq(dev, irq->msi_desc->irq,
-					NULL,
+	err = devm_request_threaded_irq(dev, irq->virq, NULL,
 					dpaa2_switch_irq0_handler_thread,
 					IRQF_NO_SUSPEND | IRQF_ONESHOT,
 					dev_name(dev), dev);
@@ -1580,7 +1579,7 @@ static int dpaa2_switch_setup_irqs(struc
 	return 0;
 
 free_devm_irq:
-	devm_free_irq(dev, irq->msi_desc->irq, dev);
+	devm_free_irq(dev, irq->virq, dev);
 free_irq:
 	fsl_mc_free_irqs(sw_dev);
 	return err;
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -88,7 +88,7 @@ static void unregister_dpio_irq_handlers
 	irq = dpio_dev->irqs[0];
 
 	/* clear the affinity hint */
-	irq_set_affinity_hint(irq->msi_desc->irq, NULL);
+	irq_set_affinity_hint(irq->virq, NULL);
 }
 
 static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
@@ -98,7 +98,7 @@ static int register_dpio_irq_handlers(st
 
 	irq = dpio_dev->irqs[0];
 	error = devm_request_irq(&dpio_dev->dev,
-				 irq->msi_desc->irq,
+				 irq->virq,
 				 dpio_irq_handler,
 				 0,
 				 dev_name(&dpio_dev->dev),
@@ -111,10 +111,10 @@ static int register_dpio_irq_handlers(st
 	}
 
 	/* set the affinity hint */
-	if (irq_set_affinity_hint(irq->msi_desc->irq, cpumask_of(cpu)))
+	if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))
 		dev_err(&dpio_dev->dev,
 			"irq_set_affinity failed irq %d cpu %d\n",
-			irq->msi_desc->irq, cpu);
+			irq->virq, cpu);
 
 	return 0;
 }
--- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
+++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
@@ -67,7 +67,7 @@ static int vfio_set_trigger(struct vfio_
 	int hwirq;
 	int ret;
 
-	hwirq = vdev->mc_dev->irqs[index]->msi_desc->irq;
+	hwirq = vdev->mc_dev->irqs[index]->virq;
 	if (irq->trigger) {
 		free_irq(hwirq, irq);
 		kfree(irq->name);
@@ -137,7 +137,7 @@ static int vfio_fsl_mc_set_irq_trigger(s
 		return vfio_set_trigger(vdev, index, fd);
 	}
 
-	hwirq = vdev->mc_dev->irqs[index]->msi_desc->irq;
+	hwirq = vdev->mc_dev->irqs[index]->virq;
 
 	irq = &vdev->mc_irqs[index];
 
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -91,13 +91,13 @@ struct fsl_mc_resource {
 
 /**
  * struct fsl_mc_device_irq - MC object device message-based interrupt
- * @msi_desc: pointer to MSI descriptor allocated by fsl_mc_msi_alloc_descs()
+ * @virq: Linux virtual interrupt number
  * @mc_dev: MC object device that owns this interrupt
  * @dev_irq_index: device-relative IRQ index
  * @resource: MC generic resource associated with the interrupt
  */
 struct fsl_mc_device_irq {
-	struct msi_desc *msi_desc;
+	unsigned int virq;
 	struct fsl_mc_device *mc_dev;
 	u8 dev_irq_index;
 	struct fsl_mc_resource resource;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240077.416446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmb-0000a2-2u; Mon, 06 Dec 2021 22:48:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240077.416446; Mon, 06 Dec 2021 22:48:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMma-0000YB-IL; Mon, 06 Dec 2021 22:48:28 +0000
Received: by outflank-mailman (input) for mailman id 240077;
 Mon, 06 Dec 2021 22:48:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdq-0004ul-Ub
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:27 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5dc0e3b3-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dc0e3b3-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.634566968@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830365;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=22kiva9JQ6H45N/BOYxKJH09o/YfXdpwUv48in1Qe9g=;
	b=nFlB/ZfAFV290eYeaq7YAleaoxlr5J/DYFZ2Nq0+kVCGwKiCDKsS0JHzsD3GRMLXU+qV7j
	fra1pXggf1FZlOZCNMPIxkiO3JccQ5fVaiEY4+wxZ8vfIfEPgFxqSqOEDhxvLBTtU1gzKY
	qsFpt6Tnx+hQcBuljGc2PBclIz+d+ynQZYG+ACQWiOyQUmhPmvu6dr2LKWPRaEB1D1qXsF
	2A0umNkHhXupulP3JfDQWZ0OTfW1qVObZkyPWFJX6TXvls5XDLaIdBIVLG1YsfbYg5gpU0
	8IofU2+b58NPrtDCOWVDCJmuc6BYOXMLrVmDAZ5XjTrebsqoMme+mHo5LfCXtg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830365;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=22kiva9JQ6H45N/BOYxKJH09o/YfXdpwUv48in1Qe9g=;
	b=kZidNZ0rKz6u6g4sF+G5QgHXRDluyP5cIqQcaPX0b7qjkPXhcQchyCEpOUgYZQx5OduRon
	leuupQ2MYvos0eAQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:25 +0100 (CET)

Add a properties field which allows core code to store information for easy
retrieval in order to replace MSI descriptor fiddling.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Add a setter function to prepare for future changes
---
 include/linux/msi.h |   17 +++++++++++++++++
 kernel/irq/msi.c    |   24 ++++++++++++++++++++++++
 2 files changed, 41 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -4,6 +4,7 @@
 
 #include <linux/cpumask.h>
 #include <linux/list.h>
+#include <linux/bits.h>
 #include <asm/msi.h>
 
 /* Dummy shadow structures if an architecture does not define them */
@@ -153,6 +154,22 @@ struct msi_device_data {
 
 int msi_setup_device_data(struct device *dev);
 
+/* MSI device properties */
+#define MSI_PROP_PCI_MSI		BIT(0)
+#define MSI_PROP_PCI_MSIX		BIT(1)
+#define MSI_PROP_64BIT			BIT(2)
+
+#ifdef CONFIG_GENERIC_MSI_IRQ
+bool msi_device_has_property(struct device *dev, unsigned long prop);
+void msi_device_set_properties(struct device *dev, unsigned long prop);
+#else
+static inline bool msi_device_has_property(struct device *dev, unsigned long prop)
+{
+	return false;
+}
+static inline void msi_device_set_properties(struct device *dev, unsigned long prop) { }
+#endif
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi_list)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -60,6 +60,30 @@ void free_msi_entry(struct msi_desc *ent
 	kfree(entry);
 }
 
+/**
+ * msi_device_set_properties - Set device specific MSI properties
+ * @dev:	Pointer to the device which is queried
+ * @prop:	Properties to set
+ */
+void msi_device_set_properties(struct device *dev, unsigned long prop)
+{
+	if (WARN_ON_ONCE(!dev->msi.data))
+		return ;
+	dev->msi.data->properties = 0;
+}
+
+/**
+ * msi_device_has_property - Check whether a device has a specific MSI property
+ * @dev:	Pointer to the device which is queried
+ * @prop:	Property to check for
+ */
+bool msi_device_has_property(struct device *dev, unsigned long prop)
+{
+	if (!dev->msi.data)
+		return false;
+	return !!(dev->msi.data->properties & prop);
+}
+
 void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
 {
 	*msg = entry->msg;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240078.416452 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmc-0000jy-3O; Mon, 06 Dec 2021 22:48:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240078.416452; Mon, 06 Dec 2021 22:48:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmb-0000gi-BJ; Mon, 06 Dec 2021 22:48:29 +0000
Received: by outflank-mailman (input) for mailman id 240078;
 Mon, 06 Dec 2021 22:48:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdw-0004ul-QO
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:32 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61463160-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61463160-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.851954664@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830372;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=w8UYsW5B4OWVVU7pGixKm7WjdRfdeuutiAGe4s0v9p0=;
	b=l6zogudvstk9l44X0viIhkG5kDqO2QITfTC/d6c2h5nF0bmVHp+7r1DJfsG/ZruoVdli7Q
	kfG2O1t6BSdlOTTFXP/352apOTG54Ck2H+zBZ4jRNvEdd2rGhJO3inv3BOHACLTb6TYZyu
	Q2V/5uUE3HP91uVco6VZYdigZWgY+laKfdDo2whpPbLjrNhc593tuDYHH2/thQ4KpWULpj
	/wjedyH/hE0QLxY/I26Q41gMLQnh1YrzDhx33dGkpZvJDGMc/fS1rdZrcqMrn5l6g529kV
	R+aSIlIAQGmAigY/kfdBWMI6uH4TUMx904zSAXJMmBTPK9awJPW1X6qPD+k2lg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830372;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=w8UYsW5B4OWVVU7pGixKm7WjdRfdeuutiAGe4s0v9p0=;
	b=1xxMH04pcreVhZpk3wJ/Fhx5cI4CNMyZzzmHHBHwM2cNv/9cju8D+JoXNUQFM7sNVHTuzl
	IA0azIbovmraB6AA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 22/36] genirq/msi: Use device MSI properties
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:31 +0100 (CET)

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 kernel/irq/msi.c |   17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -122,21 +122,8 @@ int msi_setup_device_data(struct device
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)
 {
-	struct msi_desc *entry;
-	bool is_msix = false;
-	unsigned long irq;
-	int retval;
-
-	retval = kstrtoul(attr->attr.name, 10, &irq);
-	if (retval)
-		return retval;
-
-	entry = irq_get_msi_desc(irq);
-	if (!entry)
-		return -ENODEV;
-
-	if (dev_is_pci(dev))
-		is_msix = entry->pci.msi_attrib.is_msix;
+	/* MSI vs. MSIX is per device not per interrupt */
+	bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
 
 	return sysfs_emit(buf, "%s\n", is_msix ? "msix" : "msi");
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240079.416456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmc-0000w6-VG; Mon, 06 Dec 2021 22:48:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240079.416456; Mon, 06 Dec 2021 22:48:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmc-0000sq-BI; Mon, 06 Dec 2021 22:48:30 +0000
Received: by outflank-mailman (input) for mailman id 240079;
 Mon, 06 Dec 2021 22:48:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMeI-0004dp-09
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:54 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6dc8d4db-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6dc8d4db-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.563159167@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830393;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jHyezEoA6dhB4ZSrBoZ23WpPCkveZt9yuxL9BvGVX8Y=;
	b=fSODZTv6AD7cSUnet1lA0cqP/4dL95Iu7D5l0WKszY8dggFQTtnEV3OUn3y9urhS5lmSRr
	bFPJzjBz3KIY5JStVk2zLspbNKsiDElGLLBtmMeic1y43ALqfA26qf9j9voFO6UYMBcyGo
	xANld6SPj5Tddo7FyTlAhz2h/RnlckwFpyglJv1Mm4P9x3xPdkLLUFYTmBGH0ndCDFXWmn
	+HwZpvPjvn9qzUm1kTQMlIWr5a5R0DwCYqn4UG81FQqEXp0/qvhQ7ci1MdMRGaMY/JzthP
	oh5Q61Ci98kFYJdOLoeMxVLrXNkS7mQiutBs2vw0mQuUoUWq2VaDx8FtqpYpNA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830393;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jHyezEoA6dhB4ZSrBoZ23WpPCkveZt9yuxL9BvGVX8Y=;
	b=ey27UtKMqiE+fXqJWfKK+X9EYyKnROGFcjxs9M1r6hk+PzmcSb+zFvcui9i4NN5/NwzEv9
	ug0Fq3tF+65z+tBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 35/36] soc: ti: ti_sci_inta_msi: Get rid of
 ti_sci_inta_msi_get_virq()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:52 +0100 (CET)

Just use the core function msi_get_virq().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/dma/ti/k3-udma-private.c       |    6 ++----
 drivers/dma/ti/k3-udma.c               |   10 ++++------
 drivers/soc/ti/k3-ringacc.c            |    2 +-
 drivers/soc/ti/ti_sci_inta_msi.c       |   12 ------------
 include/linux/soc/ti/ti_sci_inta_msi.h |    1 -
 5 files changed, 7 insertions(+), 24 deletions(-)

--- a/drivers/dma/ti/k3-udma-private.c
+++ b/drivers/dma/ti/k3-udma-private.c
@@ -168,8 +168,7 @@ int xudma_pktdma_tflow_get_irq(struct ud
 {
 	const struct udma_oes_offsets *oes = &ud->soc_data->oes;
 
-	return ti_sci_inta_msi_get_virq(ud->dev, udma_tflow_id +
-					oes->pktdma_tchan_flow);
+	return msi_get_virq(ud->dev, udma_tflow_id + oes->pktdma_tchan_flow);
 }
 EXPORT_SYMBOL(xudma_pktdma_tflow_get_irq);
 
@@ -177,7 +176,6 @@ int xudma_pktdma_rflow_get_irq(struct ud
 {
 	const struct udma_oes_offsets *oes = &ud->soc_data->oes;
 
-	return ti_sci_inta_msi_get_virq(ud->dev, udma_rflow_id +
-					oes->pktdma_rchan_flow);
+	return msi_get_virq(ud->dev, udma_rflow_id + oes->pktdma_rchan_flow);
 }
 EXPORT_SYMBOL(xudma_pktdma_rflow_get_irq);
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -2313,8 +2313,7 @@ static int udma_alloc_chan_resources(str
 
 	/* Event from UDMA (TR events) only needed for slave TR mode channels */
 	if (is_slave_direction(uc->config.dir) && !uc->config.pkt_mode) {
-		uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
-							    irq_udma_idx);
+		uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
 		if (uc->irq_num_udma <= 0) {
 			dev_err(ud->dev, "Failed to get udma irq (index: %u)\n",
 				irq_udma_idx);
@@ -2486,7 +2485,7 @@ static int bcdma_alloc_chan_resources(st
 		uc->psil_paired = true;
 	}
 
-	uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
+	uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
 	if (uc->irq_num_ring <= 0) {
 		dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
 			irq_ring_idx);
@@ -2503,8 +2502,7 @@ static int bcdma_alloc_chan_resources(st
 
 	/* Event from BCDMA (TR events) only needed for slave channels */
 	if (is_slave_direction(uc->config.dir)) {
-		uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
-							    irq_udma_idx);
+		uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
 		if (uc->irq_num_udma <= 0) {
 			dev_err(ud->dev, "Failed to get bcdma irq (index: %u)\n",
 				irq_udma_idx);
@@ -2672,7 +2670,7 @@ static int pktdma_alloc_chan_resources(s
 
 	uc->psil_paired = true;
 
-	uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
+	uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
 	if (uc->irq_num_ring <= 0) {
 		dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
 			irq_ring_idx);
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -647,7 +647,7 @@ int k3_ringacc_get_ring_irq_num(struct k
 	if (!ring)
 		return -EINVAL;
 
-	irq_num = ti_sci_inta_msi_get_virq(ring->parent->dev, ring->ring_id);
+	irq_num = msi_get_virq(ring->parent->dev, ring->ring_id);
 	if (irq_num <= 0)
 		irq_num = -EINVAL;
 	return irq_num;
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -148,15 +148,3 @@ void ti_sci_inta_msi_domain_free_irqs(st
 	ti_sci_inta_msi_free_descs(dev);
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
-
-unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 dev_index)
-{
-	struct msi_desc *desc;
-
-	for_each_msi_entry(desc, dev)
-		if (desc->msi_index == dev_index)
-			return desc->irq;
-
-	return -ENODEV;
-}
-EXPORT_SYMBOL_GPL(ti_sci_inta_msi_get_virq);
--- a/include/linux/soc/ti/ti_sci_inta_msi.h
+++ b/include/linux/soc/ti/ti_sci_inta_msi.h
@@ -18,6 +18,5 @@ struct irq_domain
 				   struct irq_domain *parent);
 int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
 				      struct ti_sci_resource *res);
-unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 index);
 void ti_sci_inta_msi_domain_free_irqs(struct device *dev);
 #endif /* __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H */



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240080.416471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmg-0001kc-Bl; Mon, 06 Dec 2021 22:48:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240080.416471; Mon, 06 Dec 2021 22:48:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmf-0001fW-Nv; Mon, 06 Dec 2021 22:48:33 +0000
Received: by outflank-mailman (input) for mailman id 240080;
 Mon, 06 Dec 2021 22:48:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMe8-0004dp-4c
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:44 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6804a50d-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6804a50d-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210439.235197701@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830383;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=5qM8oTMdwr/Y2E0GqvCoV+ICoCbtIN+qv9nd5yB9GSs=;
	b=JZUiFd3pdAJSDHq3VUKyD1OasA2Oro+g6/uvV4V1qDl2UvEQOxkAZViWPoRa1NZRu4vrzp
	FSTaStgm9FEmDsBsZ66XQO/bZ/+okt7KGfKcrN/2NbxpxF/R1qyGnY78CRd8GruycHQEVZ
	rkanxCjOU0JZth6BjhfeH6jyiNEl10eM8zmu0QdZv039kX8m7iaUJndnRdzGqDcBs3ZHK5
	fGBt+IglBMNHOnTm6Ak4gC7GTGciTERnIJ7HCpMCN4ClaPBo4nxP6A1orRZulEBjSPWeRe
	UwbpdXn6gbDNBMeTOE1BJabB7epz/u6ZhmrKNcIC5JFZ98DTuQ3Giaf/QufpbQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830383;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=5qM8oTMdwr/Y2E0GqvCoV+ICoCbtIN+qv9nd5yB9GSs=;
	b=m7lB0SchfJa9KJJz6u/QEd1BWWy3oYWAfOm6ycYh04Bv8BpwvZDfPvxc4nUATe4yTmjDlt
	Ejzuwe8vxERhfFCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 29/36] PCI/MSI: Simplify pci_irq_get_affinity()
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:42 +0100 (CET)

Replace open coded MSI descriptor chasing and use the proper accessor
functions instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/msi.c |   26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -1056,26 +1056,20 @@ EXPORT_SYMBOL(pci_irq_vector);
  */
 const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
 {
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
+	int irq = pci_irq_vector(dev, nr);
+	struct msi_desc *desc;
 
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_index == nr)
-				return &entry->affinity->mask;
-		}
-		WARN_ON_ONCE(1);
+	if (WARN_ON_ONCE(irq <= 0))
 		return NULL;
-	} else if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
 
-		if (WARN_ON_ONCE(!entry || !entry->affinity ||
-				 nr >= entry->nvec_used))
-			return NULL;
-
-		return &entry->affinity[nr].mask;
-	} else {
+	desc = irq_get_msi_desc(irq);
+	/* Non-MSI does not have the information handy */
+	if (!desc)
 		return cpu_possible_mask;
-	}
+
+	if (WARN_ON_ONCE(!desc->affinity))
+		return NULL;
+	return &desc->affinity[nr].mask;
 }
 EXPORT_SYMBOL(pci_irq_get_affinity);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240081.416485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmj-0002Vx-Nf; Mon, 06 Dec 2021 22:48:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240081.416485; Mon, 06 Dec 2021 22:48:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmi-0002Tv-TT; Mon, 06 Dec 2021 22:48:36 +0000
Received: by outflank-mailman (input) for mailman id 240081;
 Mon, 06 Dec 2021 22:48:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdQ-0004dp-VY
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:01 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e2cee9c-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e2cee9c-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210437.765721147@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830339;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wQM5iW4MNKpcdi9dGdVnTMQsdSGeyjM7jnIl18Q8ELs=;
	b=UyCbp6UB8oXaLK1RpwkVXT8ignzJqMLX47UjA1Lfes7KwgNfg+vBG3hpQHtS74w8ELPXbk
	UyeG8hxvDJ/f3+AO1t6UYwxv7Gk8O9yOdwJxGJQ40toKRBw9TxEHDC74wwYusmv3hTWiKk
	+ujOkTtZ8uGb3kPPG0DTmedqN3fESHCcPH4wpvA3aKYfsQg5CLAwsVegGAdUaEYmESj6vU
	zmIsPANomUZIbG/iQ6Y+WwFH4rLBiw/xSgGwr2LxrXv8//HUMRa9boqvEycJPLlf2LA5b0
	VCWJY24GkXX+llVlrAawTWrsWXyg0E4JiKWcuoJPPGzv0k7ho/YmbLbNsn+v+w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830339;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wQM5iW4MNKpcdi9dGdVnTMQsdSGeyjM7jnIl18Q8ELs=;
	b=SgwMm+AAzv73GwvSCy8dOHq2xqGDdfd7jI4bHt9FqnigZ/sIF5cc2ZL7LhattCMhARnVVz
	zt1FZBKmhbpsoqCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 02/36] device: Add device::msi_data pointer and struct
 msi_device_data
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:38:59 +0100 (CET)

Create struct msi_device_data and add a pointer of that type to struct
dev_msi_info, which is part of struct device. Provide an allocator function
which can be invoked from the MSI interrupt allocation code pathes.

Add a properties field to the data structure as a first member so the
allocation size is not zero bytes. The field will be uses later on.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/device.h |    5 +++++
 include/linux/msi.h    |   18 ++++++++++++++++++
 kernel/irq/msi.c       |   32 ++++++++++++++++++++++++++++++++
 3 files changed, 55 insertions(+)

--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -45,6 +45,7 @@ struct iommu_ops;
 struct iommu_group;
 struct dev_pin_info;
 struct dev_iommu;
+struct msi_device_data;
 
 /**
  * struct subsys_interface - interfaces to device functions
@@ -374,11 +375,15 @@ struct dev_links_info {
 /**
  * struct dev_msi_info - Device data related to MSI
  * @domain:	The MSI interrupt domain associated to the device
+ * @data:	Pointer to MSI device data
  */
 struct dev_msi_info {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 	struct irq_domain	*domain;
 #endif
+#ifdef CONFIG_GENERIC_MSI_IRQ
+	struct msi_device_data	*data;
+#endif
 };
 
 /**
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -171,6 +171,16 @@ struct msi_desc {
 	};
 };
 
+/**
+ * msi_device_data - MSI per device data
+ * @properties:		MSI properties which are interesting to drivers
+ */
+struct msi_device_data {
+	unsigned long			properties;
+};
+
+int msi_setup_device_data(struct device *dev);
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi_list)
@@ -233,10 +243,16 @@ void pci_msi_mask_irq(struct irq_data *d
 void pci_msi_unmask_irq(struct irq_data *data);
 
 #ifdef CONFIG_SYSFS
+int msi_device_populate_sysfs(struct device *dev);
+void msi_device_destroy_sysfs(struct device *dev);
+
 const struct attribute_group **msi_populate_sysfs(struct device *dev);
 void msi_destroy_sysfs(struct device *dev,
 		       const struct attribute_group **msi_irq_groups);
 #else
+static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
+static inline void msi_device_destroy_sysfs(struct device *dev) { }
+
 static inline const struct attribute_group **msi_populate_sysfs(struct device *dev)
 {
 	return NULL;
@@ -384,6 +400,8 @@ enum {
 	MSI_FLAG_MUST_REACTIVATE	= (1 << 5),
 	/* Is level-triggered capable, using two messages */
 	MSI_FLAG_LEVEL_CAPABLE		= (1 << 6),
+	/* Populate sysfs on alloc() and destroy it on free() */
+	MSI_FLAG_DEV_SYSFS		= (1 << 7),
 };
 
 int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -73,6 +73,38 @@ void get_cached_msi_msg(unsigned int irq
 }
 EXPORT_SYMBOL_GPL(get_cached_msi_msg);
 
+static void msi_device_data_release(struct device *dev, void *res)
+{
+	WARN_ON_ONCE(!list_empty(&dev->msi_list));
+	dev->msi.data = NULL;
+}
+
+/**
+ * msi_setup_device_data - Setup MSI device data
+ * @dev:	Device for which MSI device data should be set up
+ *
+ * Return: 0 on success, appropriate error code otherwise
+ *
+ * This can be called more than once for @dev. If the MSI device data is
+ * already allocated the call succeeds. The allocated memory is
+ * automatically released when the device is destroyed.
+ */
+int msi_setup_device_data(struct device *dev)
+{
+	struct msi_device_data *md;
+
+	if (dev->msi.data)
+		return 0;
+
+	md = devres_alloc(msi_device_data_release, sizeof(*md), GFP_KERNEL);
+	if (!md)
+		return -ENOMEM;
+
+	dev->msi.data = md;
+	devres_add(dev, md);
+	return 0;
+}
+
 #ifdef CONFIG_SYSFS
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:48:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:48:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240089.416504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmp-0003nt-55; Mon, 06 Dec 2021 22:48:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240089.416504; Mon, 06 Dec 2021 22:48:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmo-0003mM-TF; Mon, 06 Dec 2021 22:48:42 +0000
Received: by outflank-mailman (input) for mailman id 240089;
 Mon, 06 Dec 2021 22:48:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdV-0004dp-IO
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:05 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50ffd966-56e5-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:39:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50ffd966-56e5-11ec-a5e1-b9374ead2679
Message-ID: <20211206210437.930931987@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830344;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=11mt+Jmu6lYZoJ/3IBTchhg0X7hNMh7U8hV3wTjzP1I=;
	b=WLNIDDbSqg6ZNF/29e7tH8UwUOFk2EeNDk2aQtKE194+3FZbn2IyTY09FPdPXsFch1rREV
	bHiBikoE+htwWwkZ98+r2iJcJF4BJIfJGORFery8zTsIXXv8qY/BnTAQCzK2Y90vBqaI3i
	pTnJ3/GqqFjSRdcqEcV6r4l3lkJzYXOiTT8eCZJt9SaBE4puAi/BOEPvD8/FfqXQreE7F+
	zb98MZjDll7RPuhru4zU1y+P5n5o/hBbVpi4o+t7lWO62CUbaHDwVzeg3fUxjRX5cIIObF
	NBD1uktE6TzIA7rj6wdUDqx33SyRr/CesaqSYilItbzElrg9eAWo3BSQWhfVmQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830344;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=11mt+Jmu6lYZoJ/3IBTchhg0X7hNMh7U8hV3wTjzP1I=;
	b=055wvAQ36GPmaJY67QdSBCaQUzixTKksKeMT+TcQSXTPqcQgHL6ExaAEjyPzzu0Hdn1N/a
	VkAH9N6Rm2PvfNCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V2 05/36] bus: fsl-mc-msi: Allocate MSI device data on first use
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:04 +0100 (CET)

Allocate the MSI device data on first invocation of the allocation function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/bus/fsl-mc/fsl-mc-msi.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -253,6 +253,14 @@ int fsl_mc_msi_domain_alloc_irqs(struct
 	struct irq_domain *msi_domain;
 	int error;
 
+	msi_domain = dev_get_msi_domain(dev);
+	if (!msi_domain)
+		return -EINVAL;
+
+	error = msi_setup_device_data(dev);
+	if (error)
+		return error;
+
 	if (!list_empty(dev_to_msi_list(dev)))
 		return -EINVAL;
 
@@ -260,12 +268,6 @@ int fsl_mc_msi_domain_alloc_irqs(struct
 	if (error < 0)
 		return error;
 
-	msi_domain = dev_get_msi_domain(dev);
-	if (!msi_domain) {
-		error = -EINVAL;
-		goto cleanup_msi_descs;
-	}
-
 	/*
 	 * NOTE: Calling this function will trigger the invocation of the
 	 * its_fsl_mc_msi_prepare() callback



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:49:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:49:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240094.416514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmw-00053z-JS; Mon, 06 Dec 2021 22:48:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240094.416514; Mon, 06 Dec 2021 22:48:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMmw-00053n-Es; Mon, 06 Dec 2021 22:48:50 +0000
Received: by outflank-mailman (input) for mailman id 240094;
 Mon, 06 Dec 2021 22:48:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMdf-0004ul-Db
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:39:15 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 56c96027-56e5-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:39:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56c96027-56e5-11ec-8a4d-196798b21f7b
Message-ID: <20211206210438.256361987@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638830354;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=8HVYS8zfOFoFasYqyhj4ReqJ6AOUBtsErT7gsuMSP4E=;
	b=nUS2bp6KPZUGO4190qFZaxxBE5h7oZyCRZ4EdGJrg/SlwMsYkbIVKQQ1P11gWr0HhFDNpU
	HnkqhrRf9ECCYnDNr+vAbf/2HQV5S66+yuQb2VvbMfZl2Bd5w10mV5TyXakoeuHqnLeecG
	+7FG4hZbMKYGST9TTrwWoXGDs0Sc6fLixnABW8FDUy0vi61WLgVNPaASOJyVU5vRjgmo4H
	RuiRfz3cXnDQ4n2/3ssR2nnjOpKQ19EDQ7c8fef96PzaE3356/HFx9Nryn9dfHj/zrec5v
	fqLEhe8hxmxCj6qn9esYjwvQzQNrKeIbNxU7Nyo9s34Tp4DLcRDgEsSY3NtEiA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638830354;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=8HVYS8zfOFoFasYqyhj4ReqJ6AOUBtsErT7gsuMSP4E=;
	b=U4Ngne/RH8HTWfWVsWRrbmtfbEDTspGYTScOjm8Th7IzSHbUcSKQCiJJRlEv7zwqKgGBuQ
	jpRr3FP2K0fJJSAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Robin Murphy <robin.murphy@arm.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V2 11/36] platform-msi: Rename functions and clarify comments
References: <20211206210307.625116253@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:39:13 +0100 (CET)

It's hard to distinguish what platform_msi_domain_alloc() and
platform_msi_domain_alloc_irqs() are about. Make the distinction more
explicit and add comments which explain the use cases properly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c     |   36 +++++++++++++++++++++---------------
 drivers/irqchip/irq-mbigen.c    |    4 ++--
 drivers/irqchip/irq-mvebu-icu.c |    6 +++---
 include/linux/msi.h             |    8 ++++----
 4 files changed, 30 insertions(+), 24 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -313,17 +313,18 @@ EXPORT_SYMBOL_GPL(platform_msi_domain_fr
  *                              a platform-msi domain
  * @domain:	The platform-msi domain
  *
- * Returns the private data provided when calling
- * platform_msi_create_device_domain.
+ * Return: The private data provided when calling
+ * platform_msi_create_device_domain().
  */
 void *platform_msi_get_host_data(struct irq_domain *domain)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
+
 	return data->host_data;
 }
 
 /**
- * __platform_msi_create_device_domain - Create a platform-msi domain
+ * __platform_msi_create_device_domain - Create a platform-msi device domain
  *
  * @dev:		The device generating the MSIs
  * @nvec:		The number of MSIs that need to be allocated
@@ -332,7 +333,11 @@ void *platform_msi_get_host_data(struct
  * @ops:		The hierarchy domain operations to use
  * @host_data:		Private data associated to this domain
  *
- * Returns an irqdomain for @nvec interrupts
+ * Return: An irqdomain for @nvec interrupts on success, NULL in case of error.
+ *
+ * This is for interrupt domains which stack on a platform-msi domain
+ * created by platform_msi_create_irq_domain(). @dev->msi.domain points to
+ * that platform-msi domain which is the parent for the new domain.
  */
 struct irq_domain *
 __platform_msi_create_device_domain(struct device *dev,
@@ -372,18 +377,19 @@ struct irq_domain *
 }
 
 /**
- * platform_msi_domain_free - Free interrupts associated with a platform-msi
- *                            domain
+ * platform_msi_device_domain_free - Free interrupts associated with a platform-msi
+ *				     device domain
  *
- * @domain:	The platform-msi domain
+ * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the free operation
  * @nvec:	How many interrupts to free from @virq
  */
-void platform_msi_domain_free(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nvec)
+void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nvec)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
 	struct msi_desc *desc, *tmp;
+
 	for_each_msi_entry_safe(desc, tmp, data->dev) {
 		if (WARN_ON(!desc->irq || desc->nvec_used != 1))
 			return;
@@ -397,10 +403,10 @@ void platform_msi_domain_free(struct irq
 }
 
 /**
- * platform_msi_domain_alloc - Allocate interrupts associated with
- *			       a platform-msi domain
+ * platform_msi_device_domain_alloc - Allocate interrupts associated with
+ *				      a platform-msi device domain
  *
- * @domain:	The platform-msi domain
+ * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the allocate operation
  * @nr_irqs:	How many interrupts to free from @virq
  *
@@ -408,8 +414,8 @@ void platform_msi_domain_free(struct irq
  * with irq_domain_mutex held (which can only be done as part of a
  * top-level interrupt allocation).
  */
-int platform_msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nr_irqs)
+int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nr_irqs)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
 	int err;
@@ -421,7 +427,7 @@ int platform_msi_domain_alloc(struct irq
 	err = msi_domain_populate_irqs(domain->parent, data->dev,
 				       virq, nr_irqs, &data->arg);
 	if (err)
-		platform_msi_domain_free(domain, virq, nr_irqs);
+		platform_msi_device_domain_free(domain, virq, nr_irqs);
 
 	return err;
 }
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -207,7 +207,7 @@ static int mbigen_irq_domain_alloc(struc
 	if (err)
 		return err;
 
-	err = platform_msi_domain_alloc(domain, virq, nr_irqs);
+	err = platform_msi_device_domain_alloc(domain, virq, nr_irqs);
 	if (err)
 		return err;
 
@@ -223,7 +223,7 @@ static int mbigen_irq_domain_alloc(struc
 static void mbigen_irq_domain_free(struct irq_domain *domain, unsigned int virq,
 				   unsigned int nr_irqs)
 {
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 }
 
 static const struct irq_domain_ops mbigen_domain_ops = {
--- a/drivers/irqchip/irq-mvebu-icu.c
+++ b/drivers/irqchip/irq-mvebu-icu.c
@@ -221,7 +221,7 @@ mvebu_icu_irq_domain_alloc(struct irq_do
 		icu_irqd->icu_group = msi_data->subset_data->icu_group;
 	icu_irqd->icu = icu;
 
-	err = platform_msi_domain_alloc(domain, virq, nr_irqs);
+	err = platform_msi_device_domain_alloc(domain, virq, nr_irqs);
 	if (err) {
 		dev_err(icu->dev, "failed to allocate ICU interrupt in parent domain\n");
 		goto free_irqd;
@@ -245,7 +245,7 @@ mvebu_icu_irq_domain_alloc(struct irq_do
 	return 0;
 
 free_msi:
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 free_irqd:
 	kfree(icu_irqd);
 	return err;
@@ -260,7 +260,7 @@ mvebu_icu_irq_domain_free(struct irq_dom
 
 	kfree(icu_irqd);
 
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 }
 
 static const struct irq_domain_ops mvebu_icu_domain_ops = {
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -434,10 +434,10 @@ struct irq_domain *
 #define platform_msi_create_device_tree_domain(dev, nvec, write, ops, data) \
 	__platform_msi_create_device_domain(dev, nvec, true, write, ops, data)
 
-int platform_msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nr_irqs);
-void platform_msi_domain_free(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nvec);
+int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nr_irqs);
+void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nvec);
 void *platform_msi_get_host_data(struct irq_domain *domain);
 #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240124.416525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMp8-0008Ne-8x; Mon, 06 Dec 2021 22:51:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240124.416525; Mon, 06 Dec 2021 22:51:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMp8-0008NX-60; Mon, 06 Dec 2021 22:51:06 +0000
Received: by outflank-mailman (input) for mailman id 240124;
 Mon, 06 Dec 2021 22:51:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMp6-0008NM-Vp
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:04 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fd976516-56e6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd976516-56e6-11ec-a5e1-b9374ead2679
Message-ID: <20211206210600.123171746@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831063;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zuaVjYRhYaXSnxhOlTO3/+R1NRokr9z15QjTY7nAlqg=;
	b=g/R4QSH9IT1htMarbLNdxFDavRX6bJv4OUQ/T0gt4OQTqWZXzTnEFGfVNGY6u3WarVEX0M
	fO4dKL3Nm1idJ1EHNtMX9r3gv7Aa9o3YXnLoyDUhkVhTcL9wyzfCwA4mRP43jrVG1lBrvk
	ufNL0788SoAA7ns5LdioDLX/09NweJXy7JmQK0sepafvaSdQB0dkUuy9APy8Z+ZZpZRmtZ
	UyO27tAZTKgZE/UHN5p4OPkUXcwgOWtBGytrfD/kqC5Kq+IksH7RiH5qUuZ9fR60c7jrom
	Il+EusOQlF4egTWzDwPjnoc5PCnLeWjJc6hprAFpEnNdSv7BoTX/aaA5Ro+wcA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831063;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=zuaVjYRhYaXSnxhOlTO3/+R1NRokr9z15QjTY7nAlqg=;
	b=EiJLBZ0I2k31uIESwAuf3JVleODzfA1PUF4FPIFRUFMUdHiPUHwv8yQK8cFPw5MnxUJoi2
	tEyzCBesXZg681CA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 00/31] genirq/msi, PCI/MSI: Spring cleaning - Part 3
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Date: Mon,  6 Dec 2021 23:51:02 +0100 (CET)

VGhpcyBpcyB0aGUgdGhpcmQgcGFydCBvZiBbUENJXU1TSSByZWZhY3RvcmluZyB3aGljaCBhaW1z
IHRvIHByb3ZpZGUgdGhlCmFiaWxpdHkgb2YgZXhwYW5kaW5nIE1TSS1YIHZlY3RvcnMgYWZ0ZXIg
ZW5hYmxpbmcgTVNJLVguCgpUaGUgZmlyc3QgdHdvIHBhcnRzIG9mIHRoaXMgd29yayBjYW4gYmUg
Zm91bmQgaGVyZToKCiAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjExMjA2MjEwMTQ3
Ljg3Mjg2NTgyM0BsaW51dHJvbml4LmRlCiAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIw
MjExMjA2MjEwMzA3LjYyNTExNjI1M0BsaW51dHJvbml4LmRlCgpUaGlzIHRoaXJkIHBhcnQgaGFz
IHRoZSBmb2xsb3dpbmcgaW1wb3J0YW50IGNoYW5nZXM6CgogICAxKSBBZGQgbG9ja2luZyB0byBw
cm90ZWN0IHRoZSBNU0kgZGVzY3JpcHRvciBzdG9yYWdlCgogICAgICBSaWdodCBub3cgdGhlIE1T
SSBkZXNjcmlwdG9yIHN0b3JhZ2UgKGxpbmtlZCBsaXN0KSBpcyBub3QgcHJvdGVjdGVkCiAgICAg
IGJ5IGFueXRoaW5nIHVuZGVyIHRoZSBhc3N1bXB0aW9uIHRoYXQgdGhlIGxpc3QgaXMgaW5zdGFs
bGVkIGJlZm9yZQogICAgICB1c2UgYW5kIGRlc3Ryb3llZCBhZnRlciB1c2UuIEFzIHRoaXMgaXMg
YWJvdXQgdG8gY2hhbmdlIHRoZXJlIGhhcyB0bwogICAgICBiZSBwcm90ZWN0aW9uCgogICAyKSBB
IG5ldyBzZXQgb2YgaXRlcmF0b3JzIHdoaWNoIGFsbG93IGZpbHRlcmluZyBvbiB0aGUgc3RhdGUg
b2YgdGhlCiAgICAgIGRlc2NyaXB0b3JzIG5hbWVseSB3aGV0aGVyIGEgZGVzY3JpcHRvciBpcyBh
c3NvY2lhdGVkIHRvIGEgTGludXgKICAgICAgaW50ZXJydXB0IG9yIG5vdC4KCiAgICAgIFRoaXMg
Y2xlYW5zIHVwIGEgbG90IG9mIHVzZSBjYXNlcyB3aGljaCBoYXZlIHRvIGRvIHRoaXMgZmlsdGVy
aW5nCiAgICAgIG1hbnVhbGx5LgoKICAgMykgQSBuZXcgc2V0IG9mIE1TSSBkZXNjcmlwdG9yIGFs
bG9jYXRpb24gZnVuY3Rpb25zIHdoaWNoIG1ha2UgdGhlIHVzYWdlCiAgICAgIHNpdGVzIHNpbXBs
ZXIgYW5kIGNvbmZpbmUgdGhlIHN0b3JhZ2UgaGFuZGxpbmcgdG8gdGhlIGNvcmUgY29kZS4KCiAg
ICAgIFRyaXZpYWwgTVNJIGRlc2NyaXB0b3JzIChub24gUENJKSBhcmUgbm93IGFsbG9jYXRlZCBi
eSB0aGUgY29yZSBjb2RlCiAgICAgIGF1dG9tYXRpY2FsbHkgd2hlbiB0aGUgdW5kZXJseWluZyBp
cnEgZG9tYWluIHJlcXVlc3RzIHRoYXQuCgogICA0KSBSZXdvcmsgb2Ygc3lzZnMgaGFuZGxpbmcg
dG8gcHJlcGFyZSBmb3IgZHluYW1pYyBleHRlbnNpb24gb2YgTVNJLVgKCiAgICAgIFRoZSBjdXJy
ZW50IG1lY2hhbmlzbSB3aGljaCBjcmVhdGVzIHRoZSBkaXJlY3RvcnkgYW5kIHRoZSBhdHRyaWJ1
dGVzCiAgICAgIGZvciBhbGwgTVNJIGRlc2NyaXB0b3JzIGluIG9uZSBnbyBpcyBvYnZpb3VzbHkg
bm90IHN1aXRhYmxlIGZvcgogICAgICBkeW5hbWljIGV4dGVuc2lvbi4gVGhlIHJld29yayBzcGxp
dHMgdGhlIGRpcmVjdG9yeSBjcmVhdGlvbiBvdXQgYW5kCiAgICAgIGxldHMgdGhlIE1TSSBpbnRl
cnJ1cHQgYWxsb2NhdGlvbiBjcmVhdGUgdGhlIHBlciBkZXNjcmlwdG9yCiAgICAgIGF0dHJpYnV0
ZXMuCgogICA1KSBDb252ZXJzaW9uIG9mIHRoZSBNU0kgZGVzY3JpcHRvciBzdG9yYWdlIHRvIHhh
cnJheQoKICAgICAgVGhlIGxpbmtlZCBsaXN0IGJhc2VkIHN0b3JhZ2UgaXMgc3Vib3B0aW1hbCBl
dmVuIHdpdGhvdXQgZHluYW1pYwogICAgICBleHBhbnNpb24gYXMgaXQgcmVxdWlyZXMgZnVsbCBs
aXN0IHdhbGtzIHRvIGdldCB0byBhIHNwZWNpZmljCiAgICAgIGRlc2NyaXB0b3IuIFdpdGggZHlu
YW1pYyBleHBhbnNpb24gdGhpcyBnZXRzIGV2ZW4gbW9yZQogICAgICBjb252b2x1dGVkLiBYYXJy
YXkgaXMgd2F5IG1vcmUgc3VpdGFibGUgYW5kIHNpbXBsaWZpZXMgdGhlCiAgICAgIGZpbmFsIGdv
YWwgb2YgZHluYW1pYyBleHBhbnNpb24gb2YgdGhlIE1TSS1YIHNwYWNlLgoKVGhpcyB0aGlyZCBz
ZXJpZXMgaXMgYmFzZWQgb246CgogICAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGlu
dXgva2VybmVsL2dpdC90Z2x4L2RldmVsLmdpdCBtc2ktdjItcGFydC0yCgphbmQgYWxzbyBhdmFp
bGFibGUgZnJvbSBnaXQ6CgogICAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv
a2VybmVsL2dpdC90Z2x4L2RldmVsLmdpdCBtc2ktdjItcGFydC0zCgpWMSBvZiB0aGlzIHNlcmll
cyBjYW4gYmUgZm91bmQgaGVyZToKCiAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjEx
MTI2MjI0MTAwLjMwMzA0Njc0OUBsaW51dHJvbml4LmRlCgpDaGFuZ2VzIHZlcnN1cyBWMToKCiAg
LSBSZW1vdmUgdGhlIGFsbG9jYXRpb24gY291bnRlciBwYXRjaCBhcyBpdCBpcyBub3QgcmVxdWly
ZWQKCiAgLSBGaXggdGhlIHBvd2VycGMgZmFsbG91dCAtIENlZHJpYwoKICAtIEZpeCB0aGUgQ09O
RklHIHR5cG8gLSBOaWtsYXMKCiAgLSBQaWNrZWQgdXAgUmV2aWV3ZWQvVGVzdGVkL0Fja2VkLWJ5
IHRhZ3MgYXMgYXBwcm9wcmlhdGUKCkFzIGEgY29uc2VxdWVuY2Ugb2YgdGhlIGRpc2N1c3Npb24g
dnMuIHRoZSBnZW5lcmFsIGRpcmVjdGlvbiBvZiB0aGVzZQpwYXRjaGVzLCBwYXJ0IDQgaXMgbm90
IGdvaW5nIHRvIGJlIHVwZGF0ZWQgaW4gaXQncyBjdXJyZW50IGZvcm0uCgpUaGUgYXNzdW1wdGlv
biB0aGF0IE1TSVtYXSBhbmQgSU1TIGFyZSBtdXR1YWxseSBleGNsdXNpdmUgYW5kIHRoYXQgSU1T
IGlzCmJhc2ljYWxseSBhbiBleHRlbnNpb24gZm9yIGZpbmVyIGdyYWluZWQgc3BsaXR1cCBvZiB0
aGUgUENJIGRldmljZSBkb2VzIG5vdApob2xkLgoKVGhlcmUgaXMgYSBwbGFuIHRvIHJlZmFjdG9y
IHRoZSBjb2RlIGZ1cnRoZXIgaW4gb3JkZXIgdG8gcHJvdmlkZSB0aGUKZGVzaXJlZCBmdW5jdGlv
bmFsaXR5IG9mIE1TSVtYXS9JTVMgd2hpY2ggd2lsbCBhbHNvIGdhaW4gdGhlIGR5bmFtaWMKZXh0
ZW5zaW9uIG9mIE1TSS1YIHZlY3RvcnM6CgogICAgICBodHRwczovL2xvcmUua2VybmVsLm9yZy9y
Lzg3bzg1djN6bmIuZmZzQHRnbHgKClRoYW5rcywKCgl0Z2x4Ci0tLQogLmNsYW5nLWZvcm1hdCAg
ICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAxIAogYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy80
eHgvaHN0YV9tc2kuYyAgfCAgICA3IAogYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9jZWxsL2F4b25f
bXNpLmMgfCAgICA3IAogYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wYXNlbWkvbXNpLmMgICAgfCAg
ICA5IAogYXJjaC9wb3dlcnBjL3N5c2Rldi9mc2xfbXNpLmMgICAgICAgICAgfCAgICA4IAogYXJj
aC9wb3dlcnBjL3N5c2Rldi9tcGljX3UzbXNpLmMgICAgICAgfCAgICA5IAogYXJjaC9zMzkwL3Bj
aS9wY2lfaXJxLmMgICAgICAgICAgICAgICAgfCAgICA2IAogYXJjaC94ODYvcGNpL3hlbi5jICAg
ICAgICAgICAgICAgICAgICAgfCAgIDE0IAogZHJpdmVycy9iYXNlL2NvcmUuYyAgICAgICAgICAg
ICAgICAgICAgfCAgICAzIAogZHJpdmVycy9iYXNlL3BsYXRmb3JtLW1zaS5jICAgICAgICAgICAg
fCAgMTEwIC0tLS0tCiBkcml2ZXJzL2J1cy9mc2wtbWMvZnNsLW1jLW1zaS5jICAgICAgICB8ICAg
NjEgLS0KIGRyaXZlcnMvbnRiL21zaS5jICAgICAgICAgICAgICAgICAgICAgIHwgICAxOSAKIGRy
aXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWh5cGVydi5jICAgIHwgICAxNSAKIGRyaXZlcnMvcGNp
L21zaS9pcnFkb21haW4uYyAgICAgICAgICAgIHwgICAxMSAKIGRyaXZlcnMvcGNpL21zaS9sZWdh
Y3kuYyAgICAgICAgICAgICAgIHwgICAyMCAKIGRyaXZlcnMvcGNpL21zaS9tc2kuYyAgICAgICAg
ICAgICAgICAgIHwgIDI1OCArKysrKystLS0tLS0KIGRyaXZlcnMvcGNpL3hlbi1wY2lmcm9udC5j
ICAgICAgICAgICAgIHwgICAgMiAKIGRyaXZlcnMvc29jL3RpL3RpX3NjaV9pbnRhX21zaS5jICAg
ICAgIHwgICA3NyArLS0KIGluY2x1ZGUvbGludXgvZGV2aWNlLmggICAgICAgICAgICAgICAgIHwg
ICAgNCAKIGluY2x1ZGUvbGludXgvbXNpLmggICAgICAgICAgICAgICAgICAgIHwgIDEwNyArKyst
LQogaW5jbHVkZS9saW51eC9zb2MvdGkvdGlfc2NpX2ludGFfbXNpLmggfCAgICAxIAoga2VybmVs
L2lycS9tc2kuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgNzAwICsrKysrKysrKysrKysrKysr
KysrKystLS0tLS0tLS0tLQogMjIgZmlsZXMgY2hhbmdlZCwgNzk0IGluc2VydGlvbnMoKyksIDY1
NSBkZWxldGlvbnMoLSkK


From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240128.416569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpE-000163-D9; Mon, 06 Dec 2021 22:51:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240128.416569; Mon, 06 Dec 2021 22:51:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpE-00015o-8M; Mon, 06 Dec 2021 22:51:12 +0000
Received: by outflank-mailman (input) for mailman id 240128;
 Mon, 06 Dec 2021 22:51:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpC-0000Tb-CR
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:10 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00fb6e63-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00fb6e63-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210747.818635078@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831069;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UjZZfvKoc2kPhNBVngaTWsrbW8D3zdRcer4hfxKTjzc=;
	b=rS/EO8twB21iAAUVFAIpH4nGQPEdNtwYlw6G9MjkYhHuxtKNmbK5ZMJX9TRttcLwrXj7z1
	gFEEBwAvXwGUVxq990vVhV7201ZUV1+2BC2R072OqkPznC2WyQVV0xgDlo38VOw7MfpLKm
	Oz2XNssURig/w/DV52O8Lcsd7JbIGQQss/zKlbMePJ3ICfY2gjYXlaeRrh2dTOvZL/UqSQ
	KZ4RDgRcQDGoIuJ8VQpufBpK+eeaPdHAUgmyMkmHOuZU/yDj1/rl9QvTrw+vTipYPCZp3J
	QmAkei2UAmR7iJSCHTcjv3zfu0x2l2brukh3G3nUpOrYg+0ErvUAJEIdjErJYA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831069;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UjZZfvKoc2kPhNBVngaTWsrbW8D3zdRcer4hfxKTjzc=;
	b=wArRHQ+4In2wjoh0ByMPAoexjt0dXwgKpf3J9EL8KthNeOwtDUqYFIdIZPG+AfcP91w7v6
	kNNdIG6InADKKFBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 04/31] genirq/msi: Provide a set of advanced MSI accessors
 and iterators
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:08 +0100 (CET)

In preparation for dynamic handling of MSI-X interrupts provide a new set
of MSI descriptor accessor functions and iterators. They are benefitial per
se as they allow to cleanup quite some code in various MSI domain
implementations.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |   33 +++++++++++++++++
 kernel/irq/msi.c    |   96 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 129 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -141,6 +141,18 @@ struct msi_desc {
 	struct pci_msi_desc		pci;
 };
 
+/*
+ * Filter values for the MSI descriptor iterators and accessor functions.
+ */
+enum msi_desc_filter {
+	/* All descriptors */
+	MSI_DESC_ALL,
+	/* Descriptors which have no interrupt associated */
+	MSI_DESC_NOTASSOCIATED,
+	/* Descriptors which have an interrupt associated */
+	MSI_DESC_ASSOCIATED,
+};
+
 /**
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
@@ -148,6 +160,7 @@ struct msi_desc {
  * @platform_data:	Platform-MSI specific data
  * @list:		List of MSI descriptors associated to the device
  * @mutex:		Mutex protecting the MSI list
+ * @__next:		Cached pointer to the next entry for iterators
  */
 struct msi_device_data {
 	unsigned long			properties;
@@ -155,6 +168,7 @@ struct msi_device_data {
 	struct platform_msi_priv_data	*platform_data;
 	struct list_head		list;
 	struct mutex			mutex;
+	struct msi_desc			*__next;
 };
 
 int msi_setup_device_data(struct device *dev);
@@ -177,6 +191,25 @@ unsigned int msi_get_virq(struct device
 void msi_lock_descs(struct device *dev);
 void msi_unlock_descs(struct device *dev);
 
+struct msi_desc *msi_first_desc(struct device *dev, enum msi_desc_filter filter);
+struct msi_desc *msi_next_desc(struct device *dev, enum msi_desc_filter filter);
+
+/**
+ * msi_for_each_desc - Iterate the MSI descriptors
+ *
+ * @desc:	struct msi_desc pointer used as iterator
+ * @dev:	struct device pointer - device to iterate
+ * @filter:	Filter for descriptor selection
+ *
+ * Notes:
+ *  - The loop must be protected with a msi_lock_descs()/msi_unlock_descs()
+ *    pair.
+ *  - It is safe to remove a retrieved MSI descriptor in the loop.
+ */
+#define msi_for_each_desc(desc, dev, filter)			\
+	for ((desc) = msi_first_desc((dev), (filter)); (desc);	\
+	     (desc) = msi_next_desc((dev), (filter)))
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi.data->list)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -142,10 +142,106 @@ void msi_unlock_descs(struct device *dev
 {
 	if (WARN_ON_ONCE(!dev->msi.data))
 		return;
+	/* Clear the next pointer which was cached by the iterator */
+	dev->msi.data->__next = NULL;
 	mutex_unlock(&dev->msi.data->mutex);
 }
 EXPORT_SYMBOL_GPL(msi_unlock_descs);
 
+static bool msi_desc_match(struct msi_desc *desc, enum msi_desc_filter filter)
+{
+	switch (filter) {
+	case MSI_DESC_ALL:
+		return true;
+	case MSI_DESC_NOTASSOCIATED:
+		return !desc->irq;
+	case MSI_DESC_ASSOCIATED:
+		return !!desc->irq;
+	}
+	WARN_ON_ONCE(1);
+	return false;
+}
+
+static struct msi_desc *msi_find_first_desc(struct device *dev, enum msi_desc_filter filter)
+{
+	struct msi_desc *desc;
+
+	list_for_each_entry(desc, dev_to_msi_list(dev), list) {
+		if (msi_desc_match(desc, filter))
+			return desc;
+	}
+	return NULL;
+}
+
+/**
+ * msi_first_desc - Get the first MSI descriptor of a device
+ * @dev:	Device to operate on
+ * @filter:	Descriptor state filter
+ *
+ * Must be called with the MSI descriptor mutex held, i.e. msi_lock_descs()
+ * must be invoked before the call.
+ *
+ * Return: Pointer to the first MSI descriptor matching the search
+ *	   criteria, NULL if none found.
+ */
+struct msi_desc *msi_first_desc(struct device *dev, enum msi_desc_filter filter)
+{
+	struct msi_desc *desc;
+
+	if (WARN_ON_ONCE(!dev->msi.data))
+		return NULL;
+
+	lockdep_assert_held(&dev->msi.data->mutex);
+
+	desc = msi_find_first_desc(dev, filter);
+	dev->msi.data->__next = desc ? list_next_entry(desc, list) : NULL;
+	return desc;
+}
+EXPORT_SYMBOL_GPL(msi_first_desc);
+
+static struct msi_desc *__msi_next_desc(struct device *dev, enum msi_desc_filter filter,
+					struct msi_desc *from)
+{
+	struct msi_desc *desc = from;
+
+	list_for_each_entry_from(desc, dev_to_msi_list(dev), list) {
+		if (msi_desc_match(desc, filter))
+			return desc;
+	}
+	return NULL;
+}
+
+/**
+ * msi_next_desc - Get the next MSI descriptor of a device
+ * @dev:	Device to operate on
+ *
+ * The first invocation of msi_next_desc() has to be preceeded by a
+ * successful incovation of __msi_first_desc(). Consecutive invocations are
+ * only valid if the previous one was successful. All these operations have
+ * to be done within the same MSI mutex held region.
+ *
+ * Return: Pointer to the next MSI descriptor matching the search
+ *	   criteria, NULL if none found.
+ */
+struct msi_desc *msi_next_desc(struct device *dev, enum msi_desc_filter filter)
+{
+	struct msi_device_data *data = dev->msi.data;
+	struct msi_desc *desc;
+
+	if (WARN_ON_ONCE(!data))
+		return NULL;
+
+	lockdep_assert_held(&data->mutex);
+
+	if (!data->__next)
+		return NULL;
+
+	desc = __msi_next_desc(dev, filter, data->__next);
+	dev->msi.data->__next = desc ? list_next_entry(desc, list) : NULL;
+	return desc;
+}
+EXPORT_SYMBOL_GPL(msi_next_desc);
+
 /**
  * msi_get_virq - Return Linux interrupt number of a MSI interrupt
  * @dev:	Device to operate on



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240125.416537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMp9-0000CQ-HW; Mon, 06 Dec 2021 22:51:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240125.416537; Mon, 06 Dec 2021 22:51:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMp9-0000CH-EF; Mon, 06 Dec 2021 22:51:07 +0000
Received: by outflank-mailman (input) for mailman id 240125;
 Mon, 06 Dec 2021 22:51:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMp7-0008NM-P5
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:05 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fe202d97-56e6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe202d97-56e6-11ec-a5e1-b9374ead2679
Message-ID: <20211206210747.650487479@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831064;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=oGMiasuEUP4gSPR4Np59QOd3p0f+7TdfKQ+z0X714rk=;
	b=AeE2TL7t3Fs/zk2b8u7XU/RPKp0PKDcHb6o1LQsk6FQYiqMSSE2yPSahkMyfBPRnVqIfZl
	vlXmcYajjDHevBFb9P6jtevmccnnf014R8N+Br8323yG4RME1FG5B8OXNPkb1U/20+QWBi
	MaD/0yfxInZIGS33CdbvaP/FEd/zDBH8mYlQUkoJwV4LIIMmboj0jXyeqlIhlhdYqHzgyA
	vpd1JHqPyHhHyzNfAd6nPsuKqh1eAuoQZ1hbeuEGs65xlV0b8bnpNP9n2aJJZq+cxLDR08
	VkIDMxRTkV7+hys3okCFBDhxPdPsZuwT9bJIHx7LO8tRhX4inH48nx/hSou73A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831064;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=oGMiasuEUP4gSPR4Np59QOd3p0f+7TdfKQ+z0X714rk=;
	b=iSZa0c73v4SUkG5gpASXm733/ynX/JyyTEfp92Iferxo/T2tJ4od/37IXabjVXcVUp6/gC
	+/2dhH8Ss0W/NBAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject:
 [patch V2 01/31] genirq/msi: Move descriptor list to struct msi_device_data
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:04 +0100 (CET)

It's only required when MSI is in use.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/core.c    |    3 ---
 include/linux/device.h |    4 ----
 include/linux/msi.h    |    4 +++-
 kernel/irq/msi.c       |    5 ++++-
 4 files changed, 7 insertions(+), 9 deletions(-)

--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2874,9 +2874,6 @@ void device_initialize(struct device *de
 	INIT_LIST_HEAD(&dev->devres_head);
 	device_pm_init(dev);
 	set_dev_node(dev, NUMA_NO_NODE);
-#ifdef CONFIG_GENERIC_MSI_IRQ
-	INIT_LIST_HEAD(&dev->msi_list);
-#endif
 	INIT_LIST_HEAD(&dev->links.consumers);
 	INIT_LIST_HEAD(&dev->links.suppliers);
 	INIT_LIST_HEAD(&dev->links.defer_sync);
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -423,7 +423,6 @@ struct dev_msi_info {
  * @pins:	For device pin management.
  *		See Documentation/driver-api/pin-control.rst for details.
  * @msi:	MSI related data
- * @msi_list:	Hosts MSI descriptors
  * @numa_node:	NUMA node this device is close to.
  * @dma_ops:    DMA mapping operations for this device.
  * @dma_mask:	Dma mask (if dma'ble device).
@@ -519,9 +518,6 @@ struct device {
 	struct dev_pin_info	*pins;
 #endif
 	struct dev_msi_info	msi;
-#ifdef CONFIG_GENERIC_MSI_IRQ
-	struct list_head	msi_list;
-#endif
 #ifdef CONFIG_DMA_OPS
 	const struct dma_map_ops *dma_ops;
 #endif
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -145,11 +145,13 @@ struct msi_desc {
  * @properties:		MSI properties which are interesting to drivers
  * @attrs:		Pointer to the sysfs attribute group
  * @platform_data:	Platform-MSI specific data
+ * @list:		List of MSI descriptors associated to the device
  */
 struct msi_device_data {
 	unsigned long			properties;
 	const struct attribute_group    **attrs;
 	struct platform_msi_priv_data	*platform_data;
+	struct list_head		list;
 };
 
 int msi_setup_device_data(struct device *dev);
@@ -174,7 +176,7 @@ unsigned int msi_get_virq(struct device
 
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
-#define dev_to_msi_list(dev)		(&(dev)->msi_list)
+#define dev_to_msi_list(dev)		(&(dev)->msi.data->list)
 #define first_msi_entry(dev)		\
 	list_first_entry(dev_to_msi_list((dev)), struct msi_desc, list)
 #define for_each_msi_entry(desc, dev)	\
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -99,7 +99,9 @@ EXPORT_SYMBOL_GPL(get_cached_msi_msg);
 
 static void msi_device_data_release(struct device *dev, void *res)
 {
-	WARN_ON_ONCE(!list_empty(&dev->msi_list));
+	struct msi_device_data *md = res;
+
+	WARN_ON_ONCE(!list_empty(&md->list));
 	dev->msi.data = NULL;
 }
 
@@ -124,6 +126,7 @@ int msi_setup_device_data(struct device
 	if (!md)
 		return -ENOMEM;
 
+	INIT_LIST_HEAD(&md->list);
 	dev->msi.data = md;
 	devres_add(dev, md);
 	return 0;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240129.416576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpF-0001Cy-14; Mon, 06 Dec 2021 22:51:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240129.416576; Mon, 06 Dec 2021 22:51:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpE-0001B6-Ri; Mon, 06 Dec 2021 22:51:12 +0000
Received: by outflank-mailman (input) for mailman id 240129;
 Mon, 06 Dec 2021 22:51:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpD-0000Tb-Rn
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:11 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01efee6d-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01efee6d-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210747.873833567@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831071;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UXWSPGXq5vnQLUJp9/NNC9VtOj7oZ//oTBntFTDlckE=;
	b=PgswJKO7WjEq/yzSlO8H3r2ZY7wjGa6pUk3EvaNcKuMrsgVGzpecG5DceC1CGnwjJDfFrd
	NEIcwffhXM1Dh8hkAJqoaBetLrFmrWaiobLhBPB3Si54snueZHcItXS4lJu61yhklX8gL9
	vDjkPpzxc7w5tGUe71tIur9OcFBylBX/nVwXuDYVc4/D/njZPwu1dfzRZIDTvKazX1ctqQ
	qfboBuUucOEcJo4C9YNpUXDsL6irdm9ZTWhNvyVPa3FV7PH/JPmsWkGxQxeoLk+YcMZswH
	LUhmEcQ2lFEnBNmvg7mPfElXx9sYkYIvbB/0MVj3vFz9c+772JnNAXwn11Yomw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831071;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UXWSPGXq5vnQLUJp9/NNC9VtOj7oZ//oTBntFTDlckE=;
	b=t+DO982LnLzdozDveVemoQFAxPU8VVJP7+1gBgv3k94/pKvOyQo4khceqch0cyJeFbU1xs
	cy6hN4KbQT/tk+DA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 05/31] genirq/msi: Provide msi_alloc_msi_desc() and a
 simple allocator
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:10 +0100 (CET)

Provide msi_alloc_msi_desc() which takes a template MSI descriptor for
initializing a newly allocated descriptor. This allows to simplify various
usage sites of alloc_msi_entry() and moves the storage handling into the
core code.

For simple cases where only a linear vector space is required provide
msi_add_simple_msi_descs() which just allocates a linear range of MSI
descriptors and fills msi_desc::msi_index accordingly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |    2 +
 kernel/irq/msi.c    |   59 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -264,6 +264,8 @@ static inline void pci_write_msi_msg(uns
 }
 #endif /* CONFIG_PCI_MSI */
 
+int msi_add_msi_desc(struct device *dev, struct msi_desc *init_desc);
+
 struct msi_desc *alloc_msi_entry(struct device *dev, int nvec,
 				 const struct irq_affinity_desc *affinity);
 void free_msi_entry(struct msi_desc *entry);
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -61,6 +61,65 @@ void free_msi_entry(struct msi_desc *ent
 }
 
 /**
+ * msi_add_msi_desc - Allocate and initialize a MSI descriptor
+ * @dev:	Pointer to the device for which the descriptor is allocated
+ * @init_desc:	Pointer to an MSI descriptor to initialize the new descriptor
+ *
+ * Return: 0 on success or an appropriate failure code.
+ */
+int msi_add_msi_desc(struct device *dev, struct msi_desc *init_desc)
+{
+	struct msi_desc *desc;
+
+	lockdep_assert_held(&dev->msi.data->mutex);
+
+	desc = alloc_msi_entry(dev, init_desc->nvec_used, init_desc->affinity);
+	if (!desc)
+		return -ENOMEM;
+
+	/* Copy the MSI index and type specific data to the new descriptor. */
+	desc->msi_index = init_desc->msi_index;
+	desc->pci = init_desc->pci;
+
+	list_add_tail(&desc->list, &dev->msi.data->list);
+	return 0;
+}
+
+/**
+ * msi_add_simple_msi_descs - Allocate and initialize MSI descriptors
+ * @dev:	Pointer to the device for which the descriptors are allocated
+ * @index:	Index for the first MSI descriptor
+ * @ndesc:	Number of descriptors to allocate
+ *
+ * Return: 0 on success or an appropriate failure code.
+ */
+static int msi_add_simple_msi_descs(struct device *dev, unsigned int index, unsigned int ndesc)
+{
+	struct msi_desc *desc, *tmp;
+	LIST_HEAD(list);
+	unsigned int i;
+
+	lockdep_assert_held(&dev->msi.data->mutex);
+
+	for (i = 0; i < ndesc; i++) {
+		desc = alloc_msi_entry(dev, 1, NULL);
+		if (!desc)
+			goto fail;
+		desc->msi_index = index + i;
+		list_add_tail(&desc->list, &list);
+	}
+	list_splice_tail(&list, &dev->msi.data->list);
+	return 0;
+
+fail:
+	list_for_each_entry_safe(desc, tmp, &list, list) {
+		list_del(&desc->list);
+		free_msi_entry(desc);
+	}
+	return -ENOMEM;
+}
+
+/**
  * msi_device_set_properties - Set device specific MSI properties
  * @dev:	Pointer to the device which is queried
  * @prop:	Properties to set



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240127.416559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpC-0000l2-4X; Mon, 06 Dec 2021 22:51:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240127.416559; Mon, 06 Dec 2021 22:51:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpB-0000js-Vf; Mon, 06 Dec 2021 22:51:09 +0000
Received: by outflank-mailman (input) for mailman id 240127;
 Mon, 06 Dec 2021 22:51:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpB-0000Tb-3Y
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:09 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0014bea5-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:08 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0014bea5-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210747.765371053@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=8alToGL9fYMb4xPGuPdsGAFru/EhSrl8FqKzfYt/JtU=;
	b=gWEfbNzjHgtt1whL7/2Ldvh4oL4jk1evo9k12mpsqw9v8oK0N6JiLmbHM2BwGH5GkvMZ+r
	rA7z/FV+oGQH7D1ssy2wpa3XaN9ajGMAENYZeWjHvjVO9wNjS9xVYlcVw3bu3q8iOAr39y
	lG/9r+Rf0tRk7NZ0cBGPN0+K4Gz2NxGj5rxROcuTCf52xH8U4mmRyFQdmlUT7q/T85JVgw
	/ZG3LY51iCYfB20Dp0XdM0VP70YFPv3YVAcIUtsBdHhiGnGx6I81qkFhgImp2PMgcMs97H
	sZZB+/3dE3pQJDomBHYflaEoXLGGEdfBHmHoekcJiNOEoivZWVQA+MTanxBfdw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831067;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=8alToGL9fYMb4xPGuPdsGAFru/EhSrl8FqKzfYt/JtU=;
	b=gMmqzb5kigzp75WDzIWIKMC5D8xSaRztVQaVOdi8fXblcVRHtmbTPZztIRuhJAxNMr6oMn
	Z9A1ViGU0PFB/7DA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 03/31] genirq/msi: Provide
 msi_domain_alloc/free_irqs_descs_locked()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:07 +0100 (CET)

Usage sites which do allocations of the MSI descriptors before invoking
msi_domain_alloc_irqs() require to lock the MSI decriptors accross the
operation.

Provide entry points which can be called with the MSI mutex held and lock
the mutex in the existing entry points.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |    3 ++
 kernel/irq/msi.c    |   74 ++++++++++++++++++++++++++++++++++++++++------------
 2 files changed, 61 insertions(+), 16 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -399,9 +399,12 @@ struct irq_domain *msi_create_irq_domain
 					 struct irq_domain *parent);
 int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 			    int nvec);
+int msi_domain_alloc_irqs_descs_locked(struct irq_domain *domain, struct device *dev,
+				       int nvec);
 int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 			  int nvec);
 void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev);
+void msi_domain_free_irqs_descs_locked(struct irq_domain *domain, struct device *dev);
 void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev);
 struct msi_domain_info *msi_get_domain_info(struct irq_domain *domain);
 
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -689,10 +689,8 @@ int __msi_domain_alloc_irqs(struct irq_d
 		virq = __irq_domain_alloc_irqs(domain, -1, desc->nvec_used,
 					       dev_to_node(dev), &arg, false,
 					       desc->affinity);
-		if (virq < 0) {
-			ret = msi_handle_pci_fail(domain, desc, allocated);
-			goto cleanup;
-		}
+		if (virq < 0)
+			return msi_handle_pci_fail(domain, desc, allocated);
 
 		for (i = 0; i < desc->nvec_used; i++) {
 			irq_set_msi_desc_off(virq, i, desc);
@@ -726,7 +724,7 @@ int __msi_domain_alloc_irqs(struct irq_d
 		}
 		ret = irq_domain_activate_irq(irq_data, can_reserve);
 		if (ret)
-			goto cleanup;
+			return ret;
 	}
 
 skip_activate:
@@ -741,38 +739,63 @@ int __msi_domain_alloc_irqs(struct irq_d
 		}
 	}
 	return 0;
-
-cleanup:
-	msi_domain_free_irqs(domain, dev);
-	return ret;
 }
 
 /**
- * msi_domain_alloc_irqs - Allocate interrupts from a MSI interrupt domain
+ * msi_domain_alloc_irqs_descs_locked - Allocate interrupts from a MSI interrupt domain
  * @domain:	The domain to allocate from
  * @dev:	Pointer to device struct of the device for which the interrupts
  *		are allocated
  * @nvec:	The number of interrupts to allocate
  *
+ * Must be invoked from within a msi_lock_descs() / msi_unlock_descs()
+ * pair. Use this for MSI irqdomains which implement their own vector
+ * allocation/free.
+ *
  * Return: %0 on success or an error code.
  */
-int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
-			  int nvec)
+int msi_domain_alloc_irqs_descs_locked(struct irq_domain *domain, struct device *dev,
+				       int nvec)
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
 	int ret;
 
+	lockdep_assert_held(&dev->msi.data->mutex);
+
 	ret = ops->domain_alloc_irqs(domain, dev, nvec);
 	if (ret)
-		return ret;
+		goto cleanup;
 
 	if (!(info->flags & MSI_FLAG_DEV_SYSFS))
 		return 0;
 
 	ret = msi_device_populate_sysfs(dev);
 	if (ret)
-		msi_domain_free_irqs(domain, dev);
+		goto cleanup;
+	return 0;
+
+cleanup:
+	msi_domain_free_irqs_descs_locked(domain, dev);
+	return ret;
+}
+
+/**
+ * msi_domain_alloc_irqs - Allocate interrupts from a MSI interrupt domain
+ * @domain:	The domain to allocate from
+ * @dev:	Pointer to device struct of the device for which the interrupts
+ *		are allocated
+ * @nvec:	The number of interrupts to allocate
+ *
+ * Return: %0 on success or an error code.
+ */
+int msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev, int nvec)
+{
+	int ret;
+
+	msi_lock_descs(dev);
+	ret = msi_domain_alloc_irqs_descs_locked(domain, dev, nvec);
+	msi_unlock_descs(dev);
 	return ret;
 }
 
@@ -802,22 +825,41 @@ void __msi_domain_free_irqs(struct irq_d
 }
 
 /**
- * msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain associated to @dev
+ * msi_domain_free_irqs_descs_locked - Free interrupts from a MSI interrupt @domain associated to @dev
  * @domain:	The domain to managing the interrupts
  * @dev:	Pointer to device struct of the device for which the interrupts
  *		are free
+ *
+ * Must be invoked from within a msi_lock_descs() / msi_unlock_descs()
+ * pair. Use this for MSI irqdomains which implement their own vector
+ * allocation.
  */
-void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
+void msi_domain_free_irqs_descs_locked(struct irq_domain *domain, struct device *dev)
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
 
+	lockdep_assert_held(&dev->msi.data->mutex);
+
 	if (info->flags & MSI_FLAG_DEV_SYSFS)
 		msi_device_destroy_sysfs(dev);
 	ops->domain_free_irqs(domain, dev);
 }
 
 /**
+ * msi_domain_free_irqs - Free interrupts from a MSI interrupt @domain associated to @dev
+ * @domain:	The domain to managing the interrupts
+ * @dev:	Pointer to device struct of the device for which the interrupts
+ *		are free
+ */
+void msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
+{
+	msi_lock_descs(dev);
+	msi_domain_free_irqs_descs_locked(domain, dev);
+	msi_unlock_descs(dev);
+}
+
+/**
  * msi_get_domain_info - Get the MSI interrupt domain info for @domain
  * @domain:	The interrupt domain to retrieve data from
  *



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240126.416548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpA-0000Th-QS; Mon, 06 Dec 2021 22:51:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240126.416548; Mon, 06 Dec 2021 22:51:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpA-0000TZ-Md; Mon, 06 Dec 2021 22:51:08 +0000
Received: by outflank-mailman (input) for mailman id 240126;
 Mon, 06 Dec 2021 22:51:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMp9-0008NM-4d
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:07 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff177486-56e6-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff177486-56e6-11ec-a5e1-b9374ead2679
Message-ID: <20211206210747.708877269@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831066;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=bFF1yyGEjmfqWVKF8xO+FdVcOtASH/zVcW6F8m2ztk8=;
	b=h7zs3HhLa0MyUgqB67Ek7aGJd9bFAh+2EBYlLG+sGad3LvLUgcZ6PykeQ5T6eUoxRbF44n
	mkWuFUC/qTyXYPpvhvI+X8dyd8cfKbfMKzDXVLn/46F4zzW6CBXmi+BBfhyf+HjNEeFk2z
	0tlwWIn2KUw0sNQi54kfP7klOY0mavnu974JJFHMh0ScVWu+AaTNKMbWbvZhO3xPn83QKX
	3SfTxO7JJ6v7rvOkZQQmmn2jDyVJPowuI+fb7Z3GIff8R9ihaIBagf102XcP2fDgLFwsoX
	JfWhfpj+4WpCl7P1WgfvAQ8IDuZF8EJFDa7kJxO3HWBybIkTR+XAvrGbpm9saQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831066;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=bFF1yyGEjmfqWVKF8xO+FdVcOtASH/zVcW6F8m2ztk8=;
	b=lffMhZ/bYwE9mvQry1DVLTFG/WrrN+Pe6NDIt4eykcaGDRpNfFjLIhhaQck/87AbjfD7/F
	3/Pb9k654s4J9XDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 02/31] genirq/msi: Add mutex for MSI list protection
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:05 +0100 (CET)

For upcoming runtime extensions of MSI-X interrupts it's required to
protect the MSI descriptor list. Add a mutex to struct msi_device_data and
provide lock/unlock functions.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |    5 +++++
 kernel/irq/msi.c    |   25 +++++++++++++++++++++++++
 2 files changed, 30 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -3,6 +3,7 @@
 #define LINUX_MSI_H
 
 #include <linux/cpumask.h>
+#include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/bits.h>
 #include <asm/msi.h>
@@ -146,12 +147,14 @@ struct msi_desc {
  * @attrs:		Pointer to the sysfs attribute group
  * @platform_data:	Platform-MSI specific data
  * @list:		List of MSI descriptors associated to the device
+ * @mutex:		Mutex protecting the MSI list
  */
 struct msi_device_data {
 	unsigned long			properties;
 	const struct attribute_group    **attrs;
 	struct platform_msi_priv_data	*platform_data;
 	struct list_head		list;
+	struct mutex			mutex;
 };
 
 int msi_setup_device_data(struct device *dev);
@@ -173,6 +176,8 @@ static inline void msi_device_set_proper
 #endif
 
 unsigned int msi_get_virq(struct device *dev, unsigned int index);
+void msi_lock_descs(struct device *dev);
+void msi_unlock_descs(struct device *dev);
 
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -127,12 +127,37 @@ int msi_setup_device_data(struct device
 		return -ENOMEM;
 
 	INIT_LIST_HEAD(&md->list);
+	mutex_init(&md->mutex);
 	dev->msi.data = md;
 	devres_add(dev, md);
 	return 0;
 }
 
 /**
+ * msi_lock_descs - Lock the MSI descriptor storage of a device
+ * @dev:	Device to operate on
+ */
+void msi_lock_descs(struct device *dev)
+{
+	if (WARN_ON_ONCE(!dev->msi.data))
+		return;
+	mutex_lock(&dev->msi.data->mutex);
+}
+EXPORT_SYMBOL_GPL(msi_lock_descs);
+
+/**
+ * msi_unlock_descs - Unlock the MSI descriptor storage of a device
+ * @dev:	Device to operate on
+ */
+void msi_unlock_descs(struct device *dev)
+{
+	if (WARN_ON_ONCE(!dev->msi.data))
+		return;
+	mutex_unlock(&dev->msi.data->mutex);
+}
+EXPORT_SYMBOL_GPL(msi_unlock_descs);
+
+/**
  * msi_get_virq - Return Linux interrupt number of a MSI interrupt
  * @dev:	Device to operate on
  * @index:	MSI interrupt index to look for (0-based)



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240130.416591 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpH-0001lN-91; Mon, 06 Dec 2021 22:51:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240130.416591; Mon, 06 Dec 2021 22:51:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpH-0001l5-4R; Mon, 06 Dec 2021 22:51:15 +0000
Received: by outflank-mailman (input) for mailman id 240130;
 Mon, 06 Dec 2021 22:51:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpF-0008NM-MZ
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:13 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 02ec089b-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02ec089b-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210747.928198636@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831072;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lgiDOOjzWmT9ulLacAOoXHFBFpehQOVNbM8oPjh7uJI=;
	b=TdIBsdwXNmxGvZsdE8IynD3HOB8U7Wrb/UqdQ+GvNDOSd08I3MwwcxNPRPClJ01SkDLP1L
	4hK2i/TwZ5/TPke1DfKNP39c75ekhkt572Oy0eWKxoVGBuTpUERaxhkHQajcmMVwPs4F2j
	KgEry89MKRr9uKXqx6swFdFfRuqizECUYlM71NvXJ53kvbKlEKVqmRacB2t/laaDP4AAzl
	ZQ92fReSVYLZZZ3S6rHYp5BaiAKtOhbuTGaTD7bxy+pDrJLbMtyjzLkdC7x486yPoBcBKi
	SOAUZGPFM/i3WYqQAzx/+0sGwX1a5aavl5DOdgWeDRyNHHGNYq5kEfn/DblFLA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831072;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lgiDOOjzWmT9ulLacAOoXHFBFpehQOVNbM8oPjh7uJI=;
	b=nPmjD1oaeFKvFHQ37D0qKxrMyp5wDKHJQxlK4+cduK178oaAZhecaFAxOfijNZSiQncBDU
	WRkLdzaLUJZa5pCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 06/31] genirq/msi: Provide domain flags to allocate/free
 MSI descriptors automatically
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:12 +0100 (CET)

Provide domain info flags which tell the core to allocate simple
descriptors or to free descriptors when the interrupts are freed and
implement the required functionality.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |   17 +++++++++++++++++
 kernel/irq/msi.c    |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -106,6 +106,8 @@ struct pci_msi_desc {
 	};
 };
 
+#define MSI_MAX_INDEX		((unsigned int)USHRT_MAX)
+
 /**
  * struct msi_desc - Descriptor structure for MSI based interrupts
  * @list:	List head for management
@@ -264,6 +266,17 @@ static inline void pci_write_msi_msg(uns
 #endif /* CONFIG_PCI_MSI */
 
 int msi_add_msi_desc(struct device *dev, struct msi_desc *init_desc);
+void msi_free_msi_descs_range(struct device *dev, enum msi_desc_filter filter,
+			      unsigned int first_index, unsigned int last_index);
+
+/**
+ * msi_free_msi_descs - Free MSI descriptors of a device
+ * @dev:	Device to free the descriptors
+ */
+static inline void msi_free_msi_descs(struct device *dev)
+{
+	msi_free_msi_descs_range(dev, MSI_DESC_ALL, 0, MSI_MAX_INDEX);
+}
 
 struct msi_desc *alloc_msi_entry(struct device *dev, int nvec,
 				 const struct irq_affinity_desc *affinity);
@@ -424,6 +437,10 @@ enum {
 	MSI_FLAG_DEV_SYSFS		= (1 << 7),
 	/* MSI-X entries must be contiguous */
 	MSI_FLAG_MSIX_CONTIGUOUS	= (1 << 8),
+	/* Allocate simple MSI descriptors */
+	MSI_FLAG_ALLOC_SIMPLE_MSI_DESCS	= (1 << 9),
+	/* Free MSI descriptors */
+	MSI_FLAG_FREE_MSI_DESCS		= (1 << 10),
 };
 
 int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -120,6 +120,32 @@ static int msi_add_simple_msi_descs(stru
 }
 
 /**
+ * msi_free_msi_descs_range - Free MSI descriptors of a device
+ * @dev:		Device to free the descriptors
+ * @filter:		Descriptor state filter
+ * @first_index:	Index to start freeing from
+ * @last_index:		Last index to be freed
+ */
+void msi_free_msi_descs_range(struct device *dev, enum msi_desc_filter filter,
+			      unsigned int first_index, unsigned int last_index)
+{
+	struct msi_desc *desc;
+
+	lockdep_assert_held(&dev->msi.data->mutex);
+
+	msi_for_each_desc(desc, dev, filter) {
+		/*
+		 * Stupid for now to handle MSI device domain until the
+		 * storage is switched over to an xarray.
+		 */
+		if (desc->msi_index < first_index || desc->msi_index > last_index)
+			continue;
+		list_del(&desc->list);
+		free_msi_entry(desc);
+	}
+}
+
+/**
  * msi_device_has_property - Check whether a device has a specific MSI property
  * @dev:	Pointer to the device which is queried
  * @prop:	Property to check for
@@ -896,6 +922,16 @@ int __msi_domain_alloc_irqs(struct irq_d
 	return 0;
 }
 
+static int msi_domain_add_simple_msi_descs(struct msi_domain_info *info,
+					   struct device *dev,
+					   unsigned int num_descs)
+{
+	if (!(info->flags & MSI_FLAG_ALLOC_SIMPLE_MSI_DESCS))
+		return 0;
+
+	return msi_add_simple_msi_descs(dev, 0, num_descs);
+}
+
 /**
  * msi_domain_alloc_irqs_descs_locked - Allocate interrupts from a MSI interrupt domain
  * @domain:	The domain to allocate from
@@ -918,6 +954,10 @@ int msi_domain_alloc_irqs_descs_locked(s
 
 	lockdep_assert_held(&dev->msi.data->mutex);
 
+	ret = msi_domain_add_simple_msi_descs(info, dev, nvec);
+	if (ret)
+		return ret;
+
 	ret = ops->domain_alloc_irqs(domain, dev, nvec);
 	if (ret)
 		goto cleanup;
@@ -979,6 +1019,13 @@ void __msi_domain_free_irqs(struct irq_d
 	}
 }
 
+static void msi_domain_free_msi_descs(struct msi_domain_info *info,
+				      struct device *dev)
+{
+	if (info->flags & MSI_FLAG_FREE_MSI_DESCS)
+		msi_free_msi_descs(dev);
+}
+
 /**
  * msi_domain_free_irqs_descs_locked - Free interrupts from a MSI interrupt @domain associated to @dev
  * @domain:	The domain to managing the interrupts
@@ -999,6 +1046,7 @@ void msi_domain_free_irqs_descs_locked(s
 	if (info->flags & MSI_FLAG_DEV_SYSFS)
 		msi_device_destroy_sysfs(dev);
 	ops->domain_free_irqs(domain, dev);
+	msi_domain_free_msi_descs(info, dev);
 }
 
 /**



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240131.416603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpJ-0002A3-LU; Mon, 06 Dec 2021 22:51:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240131.416603; Mon, 06 Dec 2021 22:51:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpJ-00029j-Gv; Mon, 06 Dec 2021 22:51:17 +0000
Received: by outflank-mailman (input) for mailman id 240131;
 Mon, 06 Dec 2021 22:51:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpH-0008NM-CH
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:15 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03da20f1-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03da20f1-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210747.982292705@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831074;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=N57Dw29W0AnjW3yYUBfTixjB36XDU5ZjUD5ThYpSVNo=;
	b=HujDf40wtWORWeA95VGOmTTzSUu5YOsMfqrUsqS0Qa+SDZ1cuY7zqGmhfPR9sseSeS9qhq
	9F75eEazto7VfbHTcpyW27meXr2vpARRT1bFoz+dBE6ArRx6t6ck19NL7Ymu7CL1wfYDwI
	DSfK1E0UgiffsdukN/GAPLshy6SVLDrjORwdvGaH9AQcGQKXnGQlWYkolZga/KLuRwJpDe
	j4JTDC4QnKJhZiGIzCBE2KAUNzMTxV/4QoCLGZTM0bFDCOdlgC6zXINGOmGeJISNup5WmC
	hOt/YxA+Jftsud/kjQaRH5ddCtg9C9/vp0uk5E6EpiNw8u8ni+U9KY/KX2Wqxw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831074;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=N57Dw29W0AnjW3yYUBfTixjB36XDU5ZjUD5ThYpSVNo=;
	b=sDYtE6T1iztsgAKe7keJZDJMSAsoVbAMUie0GNoUoBzr/d0w0cSPJFlMwEb4dAwOCCb11W
	Xxsl+P0gTanJlPDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 07/31] PCI/MSI: Protect MSI operations
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:13 +0100 (CET)

To prepare for dynamic extension of MSI-X vectors, protect the MSI
operations for MSI and MSI-X. This requires to move the invocation of
irq_create_affinity_masks() out of the descriptor lock section to avoid
reverse lock ordering vs. CPU hotplug lock as some callers of the PCI/MSI
allocation interfaces already hold it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi/irqdomain.c |    4 -
 drivers/pci/msi/msi.c       |  120 ++++++++++++++++++++++++++------------------
 2 files changed, 73 insertions(+), 51 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -14,7 +14,7 @@ int pci_msi_setup_msi_irqs(struct pci_de
 
 	domain = dev_get_msi_domain(&dev->dev);
 	if (domain && irq_domain_is_hierarchy(domain))
-		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
+		return msi_domain_alloc_irqs_descs_locked(domain, &dev->dev, nvec);
 
 	return pci_msi_legacy_setup_msi_irqs(dev, nvec, type);
 }
@@ -25,7 +25,7 @@ void pci_msi_teardown_msi_irqs(struct pc
 
 	domain = dev_get_msi_domain(&dev->dev);
 	if (domain && irq_domain_is_hierarchy(domain))
-		msi_domain_free_irqs(domain, &dev->dev);
+		msi_domain_free_irqs_descs_locked(domain, &dev->dev);
 	else
 		pci_msi_legacy_teardown_msi_irqs(dev);
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -322,11 +322,13 @@ static void __pci_restore_msix_state(str
 
 	write_msg = arch_restore_msi_irqs(dev);
 
+	msi_lock_descs(&dev->dev);
 	for_each_pci_msi_entry(entry, dev) {
 		if (write_msg)
 			__pci_write_msi_msg(entry, &entry->msg);
 		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
 	}
+	msi_unlock_descs(&dev->dev);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 }
@@ -339,20 +341,16 @@ void pci_restore_msi_state(struct pci_de
 EXPORT_SYMBOL_GPL(pci_restore_msi_state);
 
 static struct msi_desc *
-msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
+msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity_desc *masks)
 {
-	struct irq_affinity_desc *masks = NULL;
 	struct msi_desc *entry;
 	unsigned long prop;
 	u16 control;
 
-	if (affd)
-		masks = irq_create_affinity_masks(nvec, affd);
-
 	/* MSI Entry Initialization */
 	entry = alloc_msi_entry(&dev->dev, nvec, masks);
 	if (!entry)
-		goto out;
+		return NULL;
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
 	/* Lies, damned lies, and MSIs */
@@ -379,8 +377,7 @@ msi_setup_entry(struct pci_dev *dev, int
 	if (entry->pci.msi_attrib.is_64)
 		prop |= MSI_PROP_64BIT;
 	msi_device_set_properties(&dev->dev, prop);
-out:
-	kfree(masks);
+
 	return entry;
 }
 
@@ -416,14 +413,21 @@ static int msi_verify_entries(struct pci
 static int msi_capability_init(struct pci_dev *dev, int nvec,
 			       struct irq_affinity *affd)
 {
+	struct irq_affinity_desc *masks = NULL;
 	struct msi_desc *entry;
 	int ret;
 
 	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
 
-	entry = msi_setup_entry(dev, nvec, affd);
-	if (!entry)
-		return -ENOMEM;
+	if (affd)
+		masks = irq_create_affinity_masks(nvec, affd);
+
+	msi_lock_descs(&dev->dev);
+	entry = msi_setup_entry(dev, nvec, masks);
+	if (!entry) {
+		ret = -ENOMEM;
+		goto unlock;
+	}
 
 	/* All MSIs are unmasked by default; mask them all */
 	pci_msi_mask(entry, msi_multi_mask(entry));
@@ -446,11 +450,14 @@ static int msi_capability_init(struct pc
 
 	pcibios_free_irq(dev);
 	dev->irq = entry->irq;
-	return 0;
+	goto unlock;
 
 err:
 	pci_msi_unmask(entry, msi_multi_mask(entry));
 	free_msi_irqs(dev);
+unlock:
+	msi_unlock_descs(&dev->dev);
+	kfree(masks);
 	return ret;
 }
 
@@ -477,23 +484,18 @@ static void __iomem *msix_map_region(str
 
 static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
 			      struct msix_entry *entries, int nvec,
-			      struct irq_affinity *affd)
+			      struct irq_affinity_desc *masks)
 {
-	struct irq_affinity_desc *curmsk, *masks = NULL;
+	int i, vec_count = pci_msix_vec_count(dev);
+	struct irq_affinity_desc *curmsk;
 	struct msi_desc *entry;
 	void __iomem *addr;
-	int ret, i;
-	int vec_count = pci_msix_vec_count(dev);
-
-	if (affd)
-		masks = irq_create_affinity_masks(nvec, affd);
 
 	for (i = 0, curmsk = masks; i < nvec; i++) {
 		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
 		if (!entry) {
 			/* No enough memory. Don't try again */
-			ret = -ENOMEM;
-			goto out;
+			return -ENOMEM;
 		}
 
 		entry->pci.msi_attrib.is_msix	= 1;
@@ -522,10 +524,7 @@ static int msix_setup_entries(struct pci
 			curmsk++;
 	}
 	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
-	ret = 0;
-out:
-	kfree(masks);
-	return ret;
+	return 0;
 }
 
 static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
@@ -552,6 +551,41 @@ static void msix_mask_all(void __iomem *
 		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
 }
 
+static int msix_setup_interrupts(struct pci_dev *dev, void __iomem *base,
+				 struct msix_entry *entries, int nvec,
+				 struct irq_affinity *affd)
+{
+	struct irq_affinity_desc *masks = NULL;
+	int ret;
+
+	if (affd)
+		masks = irq_create_affinity_masks(nvec, affd);
+
+	msi_lock_descs(&dev->dev);
+	ret = msix_setup_entries(dev, base, entries, nvec, masks);
+	if (ret)
+		goto out_free;
+
+	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
+	if (ret)
+		goto out_free;
+
+	/* Check if all MSI entries honor device restrictions */
+	ret = msi_verify_entries(dev);
+	if (ret)
+		goto out_free;
+
+	msix_update_entries(dev, entries);
+	goto out_unlock;
+
+out_free:
+	free_msi_irqs(dev);
+out_unlock:
+	msi_unlock_descs(&dev->dev);
+	kfree(masks);
+	return ret;
+}
+
 /**
  * msix_capability_init - configure device's MSI-X capability
  * @dev: pointer to the pci_dev data structure of MSI-X device function
@@ -592,20 +626,9 @@ static int msix_capability_init(struct p
 	/* Ensure that all table entries are masked. */
 	msix_mask_all(base, tsize);
 
-	ret = msix_setup_entries(dev, base, entries, nvec, affd);
+	ret = msix_setup_interrupts(dev, base, entries, nvec, affd);
 	if (ret)
-		goto out_free;
-
-	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
-	if (ret)
-		goto out_free;
-
-	/* Check if all MSI entries honor device restrictions */
-	ret = msi_verify_entries(dev);
-	if (ret)
-		goto out_free;
-
-	msix_update_entries(dev, entries);
+		goto out_disable;
 
 	/* Set MSI-X enabled bits and unmask the function */
 	pci_intx_for_msi(dev, 0);
@@ -615,12 +638,8 @@ static int msix_capability_init(struct p
 	pcibios_free_irq(dev);
 	return 0;
 
-out_free:
-	free_msi_irqs(dev);
-
 out_disable:
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
-
 	return ret;
 }
 
@@ -725,8 +744,10 @@ void pci_disable_msi(struct pci_dev *dev
 	if (!pci_msi_enable || !dev || !dev->msi_enabled)
 		return;
 
+	msi_lock_descs(&dev->dev);
 	pci_msi_shutdown(dev);
 	free_msi_irqs(dev);
+	msi_unlock_descs(&dev->dev);
 }
 EXPORT_SYMBOL(pci_disable_msi);
 
@@ -812,8 +833,10 @@ void pci_disable_msix(struct pci_dev *de
 	if (!pci_msi_enable || !dev || !dev->msix_enabled)
 		return;
 
+	msi_lock_descs(&dev->dev);
 	pci_msix_shutdown(dev);
 	free_msi_irqs(dev);
+	msi_unlock_descs(&dev->dev);
 }
 EXPORT_SYMBOL(pci_disable_msix);
 
@@ -874,7 +897,6 @@ int pci_enable_msi(struct pci_dev *dev)
 
 	if (!rc)
 		rc = __pci_enable_msi_range(dev, 1, 1, NULL);
-
 	return rc < 0 ? rc : 0;
 }
 EXPORT_SYMBOL(pci_enable_msi);
@@ -961,11 +983,7 @@ int pci_alloc_irq_vectors_affinity(struc
 				   struct irq_affinity *affd)
 {
 	struct irq_affinity msi_default_affd = {0};
-	int ret = msi_setup_device_data(&dev->dev);
-	int nvecs = -ENOSPC;
-
-	if (ret)
-		return ret;
+	int ret, nvecs;
 
 	if (flags & PCI_IRQ_AFFINITY) {
 		if (!affd)
@@ -975,6 +993,10 @@ int pci_alloc_irq_vectors_affinity(struc
 			affd = NULL;
 	}
 
+	ret = msi_setup_device_data(&dev->dev);
+	if (ret)
+		return ret;
+
 	if (flags & PCI_IRQ_MSIX) {
 		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
 						affd, flags);
@@ -1003,7 +1025,7 @@ int pci_alloc_irq_vectors_affinity(struc
 		}
 	}
 
-	return nvecs;
+	return -ENOSPC;
 }
 EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240132.416608 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpK-0002F6-JY; Mon, 06 Dec 2021 22:51:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240132.416608; Mon, 06 Dec 2021 22:51:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpK-0002E3-1E; Mon, 06 Dec 2021 22:51:18 +0000
Received: by outflank-mailman (input) for mailman id 240132;
 Mon, 06 Dec 2021 22:51:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpI-0000Tb-Pr
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:16 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04c64123-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04c64123-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.035348646@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831075;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wTyw9UHL4EZzi7S4TLWt2TYeHID6LO8QBUrMwBgaKko=;
	b=qaiiQOG6hspA0WWBALSBlSvuAUcVQYOLZzN7ZDrkzejuG+bNSHKSIfMbE2Wd1ixaQlWWAO
	zEIJUR8RY96fBQLWx9fWQ8h/vQ0Qq0oWqLpAs+8l4/zaKergHOCGrNPXekIUWDGoghHS+r
	z82l1dW2X7Ecrjjm/EpwLO1/Xp87ldCuhP9J5ejkE51ncl5A1Atc/1HSdUGvfyft4w+5do
	DKdOZK6/QLRqlCh4E2a6p/lmcokWrckyBqf48S3xbNDEcxx82z8v3djjRHotQ5AiNg327b
	v7RlOkhhgpfB7hbAVQtYw9IKoYqYoliDAO3vUGZ1hjzHenpwGTQxzumGQahTbQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831075;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=wTyw9UHL4EZzi7S4TLWt2TYeHID6LO8QBUrMwBgaKko=;
	b=BAPpF6XmY1nxJMpCpTyhOlm2QM2DIN8WFk+TyMR4rqcu07MjPTX9VXmHqYek/WTdzmWTr2
	TYWcTWEnF0oaHsAg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 08/31] PCI/MSI: Use msi_add_msi_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:15 +0100 (CET)

Simplify the allocation of MSI descriptors by using msi_add_msi_desc()
which moves the storage handling to core code and prepares for dynamic
extension of the MSI-X vector space.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi/msi.c |  122 ++++++++++++++++++++++++--------------------------
 1 file changed, 59 insertions(+), 63 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -340,45 +340,51 @@ void pci_restore_msi_state(struct pci_de
 }
 EXPORT_SYMBOL_GPL(pci_restore_msi_state);
 
-static struct msi_desc *
-msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity_desc *masks)
+static int msi_setup_msi_desc(struct pci_dev *dev, int nvec,
+			      struct irq_affinity_desc *masks)
 {
-	struct msi_desc *entry;
+	struct msi_desc desc;
 	unsigned long prop;
 	u16 control;
+	int ret;
 
 	/* MSI Entry Initialization */
-	entry = alloc_msi_entry(&dev->dev, nvec, masks);
-	if (!entry)
-		return NULL;
+	memset(&desc, 0, sizeof(desc));
 
 	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
 	/* Lies, damned lies, and MSIs */
 	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
 		control |= PCI_MSI_FLAGS_MASKBIT;
+	/* Respect XEN's mask disabling */
+	if (pci_msi_ignore_mask)
+		control &= ~PCI_MSI_FLAGS_MASKBIT;
 
-	entry->pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
-	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
-					  !!(control & PCI_MSI_FLAGS_MASKBIT);
-	entry->pci.msi_attrib.default_irq = dev->irq;
-	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
-	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
+	desc.nvec_used			= nvec;
+	desc.pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
+	desc.pci.msi_attrib.can_mask	= !!(control & PCI_MSI_FLAGS_MASKBIT);
+	desc.pci.msi_attrib.default_irq	= dev->irq;
+	desc.pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
+	desc.pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
+	desc.affinity			= masks;
 
 	if (control & PCI_MSI_FLAGS_64BIT)
-		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
+		desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
 	else
-		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
+		desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
 
 	/* Save the initial mask status */
-	if (entry->pci.msi_attrib.can_mask)
-		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
+	if (desc.pci.msi_attrib.can_mask)
+		pci_read_config_dword(dev, desc.pci.mask_pos, &desc.pci.msi_mask);
 
-	prop = MSI_PROP_PCI_MSI;
-	if (entry->pci.msi_attrib.is_64)
-		prop |= MSI_PROP_64BIT;
-	msi_device_set_properties(&dev->dev, prop);
+	ret = msi_add_msi_desc(&dev->dev, &desc);
+	if (!ret) {
+		prop = MSI_PROP_PCI_MSI;
+		if (desc.pci.msi_attrib.is_64)
+			prop |= MSI_PROP_64BIT;
+		msi_device_set_properties(&dev->dev, prop);
+	}
 
-	return entry;
+	return ret;
 }
 
 static int msi_verify_entries(struct pci_dev *dev)
@@ -423,17 +429,14 @@ static int msi_capability_init(struct pc
 		masks = irq_create_affinity_masks(nvec, affd);
 
 	msi_lock_descs(&dev->dev);
-	entry = msi_setup_entry(dev, nvec, masks);
-	if (!entry) {
-		ret = -ENOMEM;
+	ret = msi_setup_msi_desc(dev, nvec, masks);
+	if (ret)
 		goto unlock;
-	}
 
 	/* All MSIs are unmasked by default; mask them all */
+	entry = first_pci_msi_entry(dev);
 	pci_msi_mask(entry, msi_multi_mask(entry));
 
-	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
-
 	/* Configure MSI capability structure */
 	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
 	if (ret)
@@ -482,49 +485,40 @@ static void __iomem *msix_map_region(str
 	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
 }
 
-static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
-			      struct msix_entry *entries, int nvec,
-			      struct irq_affinity_desc *masks)
+static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
+				struct msix_entry *entries, int nvec,
+				struct irq_affinity_desc *masks)
 {
-	int i, vec_count = pci_msix_vec_count(dev);
+	int ret = 0, i, vec_count = pci_msix_vec_count(dev);
 	struct irq_affinity_desc *curmsk;
-	struct msi_desc *entry;
+	struct msi_desc desc;
 	void __iomem *addr;
 
-	for (i = 0, curmsk = masks; i < nvec; i++) {
-		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
-		if (!entry) {
-			/* No enough memory. Don't try again */
-			return -ENOMEM;
-		}
-
-		entry->pci.msi_attrib.is_msix	= 1;
-		entry->pci.msi_attrib.is_64	= 1;
-
-		if (entries)
-			entry->msi_index = entries[i].entry;
-		else
-			entry->msi_index = i;
-
-		entry->pci.msi_attrib.is_virtual = entry->msi_index >= vec_count;
-
-		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
-						  !entry->pci.msi_attrib.is_virtual;
-
-		entry->pci.msi_attrib.default_irq	= dev->irq;
-		entry->pci.mask_base			= base;
+	memset(&desc, 0, sizeof(desc));
 
-		if (entry->pci.msi_attrib.can_mask) {
-			addr = pci_msix_desc_addr(entry);
-			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
+	desc.nvec_used			= 1;
+	desc.pci.msi_attrib.is_msix	= 1;
+	desc.pci.msi_attrib.is_64	= 1;
+	desc.pci.msi_attrib.default_irq	= dev->irq;
+	desc.pci.mask_base		= base;
+
+	for (i = 0, curmsk = masks; i < nvec; i++, curmsk++) {
+		desc.msi_index = entries ? entries[i].entry : i;
+		desc.affinity = masks ? curmsk : NULL;
+		desc.pci.msi_attrib.is_virtual = desc.msi_index >= vec_count;
+		desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
+					       !desc.pci.msi_attrib.is_virtual;
+
+		if (!desc.pci.msi_attrib.can_mask) {
+			addr = pci_msix_desc_addr(&desc);
+			desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
 		}
 
-		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
-		if (masks)
-			curmsk++;
+		ret = msi_add_msi_desc(&dev->dev, &desc);
+		if (ret)
+			break;
 	}
-	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
-	return 0;
+	return ret;
 }
 
 static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
@@ -562,10 +556,12 @@ static int msix_setup_interrupts(struct
 		masks = irq_create_affinity_masks(nvec, affd);
 
 	msi_lock_descs(&dev->dev);
-	ret = msix_setup_entries(dev, base, entries, nvec, masks);
+	ret = msix_setup_msi_descs(dev, base, entries, nvec, masks);
 	if (ret)
 		goto out_free;
 
+	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
+
 	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
 	if (ret)
 		goto out_free;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240133.416618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpM-0002ln-SZ; Mon, 06 Dec 2021 22:51:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240133.416618; Mon, 06 Dec 2021 22:51:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpM-0002j4-E8; Mon, 06 Dec 2021 22:51:20 +0000
Received: by outflank-mailman (input) for mailman id 240133;
 Mon, 06 Dec 2021 22:51:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpK-0000Tb-AF
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:18 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 05cb285d-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05cb285d-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.089085131@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831077;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=O192gTv7DVMCmoiFcAQ4tyGbPvViDQQz5Lq/A3dCGdU=;
	b=yAGXeCWb/MLSFOWdyqn+f3X7iRs0IbPpmDQ2LDClgWe2kyw40xFdfg87fcMA3GSkbXdpRp
	P4jKMgelmsbNP+ajv6QuUI/YvPD46YfxdK/tIkaJKr7oJKF88KyOGJA/Eg9ozHpz5UyDs+
	X2UpRnC2ETnBVHswRo5ju3uaspL1Hr8L2VEKC/WMii0ILQ1aJmADFWDY+tKFUqX+W5sS7+
	JLHMYFCndpVQwB1ty7SXBw0CRNc3HOmjKE1mpn3ehsl0bA/07CL8htyJb/5ZrAZjVo5nf7
	BWLZh62Sv60QedOoRKVKKhpCTkQF6rUQzyYh2zRmZFcoScESSB7zYoCJNupn4Q==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831077;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=O192gTv7DVMCmoiFcAQ4tyGbPvViDQQz5Lq/A3dCGdU=;
	b=LOPeM1wwdBLryYGVoFatNH/lCkc91JRDEBARe01ZXRbr1hoNxRJB3rT3CyT0HQcyqz5EUa
	dcAfNimcrSAi4SCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 09/31] PCI/MSI: Let core code free MSI descriptors
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:16 +0100 (CET)

Set the domain info flag which tells the core code to free the MSI
descriptors from msi_domain_free_irqs() and add an explicit call to the
core function into the legacy code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi/irqdomain.c |    3 ++-
 drivers/pci/msi/legacy.c    |    1 +
 drivers/pci/msi/msi.c       |   14 --------------
 3 files changed, 3 insertions(+), 15 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -171,7 +171,8 @@ struct irq_domain *pci_msi_create_irq_do
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		pci_msi_domain_update_chip_ops(info);
 
-	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS;
+	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS |
+		       MSI_FLAG_FREE_MSI_DESCS;
 	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
 		info->flags |= MSI_FLAG_MUST_REACTIVATE;
 
--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -80,4 +80,5 @@ void pci_msi_legacy_teardown_msi_irqs(st
 {
 	msi_device_destroy_sysfs(&dev->dev);
 	arch_teardown_msi_irqs(dev);
+	msi_free_msi_descs(&dev->dev);
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -224,22 +224,8 @@ EXPORT_SYMBOL_GPL(pci_write_msi_msg);
 
 static void free_msi_irqs(struct pci_dev *dev)
 {
-	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
-	struct msi_desc *entry, *tmp;
-	int i;
-
-	for_each_pci_msi_entry(entry, dev)
-		if (entry->irq)
-			for (i = 0; i < entry->nvec_used; i++)
-				BUG_ON(irq_has_action(entry->irq + i));
-
 	pci_msi_teardown_msi_irqs(dev);
 
-	list_for_each_entry_safe(entry, tmp, msi_list, list) {
-		list_del(&entry->list);
-		free_msi_entry(entry);
-	}
-
 	if (dev->msix_base) {
 		iounmap(dev->msix_base);
 		dev->msix_base = NULL;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240137.416634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpP-0003TF-SX; Mon, 06 Dec 2021 22:51:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240137.416634; Mon, 06 Dec 2021 22:51:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpP-0003Rc-6h; Mon, 06 Dec 2021 22:51:23 +0000
Received: by outflank-mailman (input) for mailman id 240137;
 Mon, 06 Dec 2021 22:51:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpM-0000Tb-QW
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:20 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06d2d33a-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06d2d33a-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.142603657@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831079;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9yLJ7MKNr/rEir7S3uoWAbXOrCi2s6fUNKy3QjsOHtE=;
	b=eyFASZgRpw8lE0o1fXQsvjQ2CQdIBsFa3cJZ9/Rc6YHGp7MvmPWlsUHBY4y0y7gY6+P9IW
	RxwHCHFpYYMGKEXum4d/429b/NB7pme2LIvEp3mq7OK3Lb1ZHaKcfH9fUx/dQVTiHmqxg+
	w8LHLHoAVat8DH/9FeSrU5qmLTMTjHpdSGbrpZzoKpy1CbrcftQoIupy4gdqV0+x1SozfM
	h+3oZIpmhDivzgJ4OTmIXj7NkNkfmX8DK68eLNQ2/Rm/FTvFuhqPtmUkPjIIaHrZjyAj0o
	Hiqj6drNNQ3nzm4s8B9gjFltzpg04+tQhVQtbVctm+ZpuzMgL7B/8XwMhgeT3Q==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831079;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9yLJ7MKNr/rEir7S3uoWAbXOrCi2s6fUNKy3QjsOHtE=;
	b=2Id8mqkqv590PcMEfC/XpIBMacxq4FMY45fq0oEDL24TfJdAo5LOGN8tNZw+dAJtBgyL8q
	iy0bBRqNUEy6HEBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 10/31] PCI/MSI: Use msi_on_each_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:18 +0100 (CET)

Use the new iterator functions which pave the way for dynamically extending
MSI-X vectors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi/irqdomain.c |    4 ++--
 drivers/pci/msi/legacy.c    |   19 ++++++++-----------
 drivers/pci/msi/msi.c       |   30 ++++++++++++++----------------
 3 files changed, 24 insertions(+), 29 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -83,7 +83,7 @@ static int pci_msi_domain_check_cap(stru
 				    struct msi_domain_info *info,
 				    struct device *dev)
 {
-	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
+	struct msi_desc *desc = msi_first_desc(dev, MSI_DESC_ALL);
 
 	/* Special handling to support __pci_enable_msi_range() */
 	if (pci_msi_desc_is_multi_msi(desc) &&
@@ -98,7 +98,7 @@ static int pci_msi_domain_check_cap(stru
 			unsigned int idx = 0;
 
 			/* Check for gaps in the entry indices */
-			for_each_msi_entry(desc, dev) {
+			msi_for_each_desc(desc, dev, MSI_DESC_ALL) {
 				if (desc->msi_index != idx++)
 					return -ENOTSUPP;
 			}
--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -28,7 +28,7 @@ int __weak arch_setup_msi_irqs(struct pc
 	if (type == PCI_CAP_ID_MSI && nvec > 1)
 		return 1;
 
-	for_each_pci_msi_entry(desc, dev) {
+	msi_for_each_desc(desc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		ret = arch_setup_msi_irq(dev, desc);
 		if (ret)
 			return ret < 0 ? ret : -ENOSPC;
@@ -42,27 +42,24 @@ void __weak arch_teardown_msi_irqs(struc
 	struct msi_desc *desc;
 	int i;
 
-	for_each_pci_msi_entry(desc, dev) {
-		if (desc->irq) {
-			for (i = 0; i < desc->nvec_used; i++)
-				arch_teardown_msi_irq(desc->irq + i);
-		}
+	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ASSOCIATED) {
+		for (i = 0; i < desc->nvec_used; i++)
+			arch_teardown_msi_irq(desc->irq + i);
 	}
 }
 
 static int pci_msi_setup_check_result(struct pci_dev *dev, int type, int ret)
 {
-	struct msi_desc *entry;
+	struct msi_desc *desc;
 	int avail = 0;
 
 	if (type != PCI_CAP_ID_MSIX || ret >= 0)
 		return ret;
 
 	/* Scan the MSI descriptors for successfully allocated ones. */
-	for_each_pci_msi_entry(entry, dev) {
-		if (entry->irq != 0)
-			avail++;
-	}
+	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ASSOCIATED)
+		avail++;
+
 	return avail ? avail : ret;
 }
 
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -299,7 +299,6 @@ static void __pci_restore_msix_state(str
 
 	if (!dev->msix_enabled)
 		return;
-	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
 
 	/* route the table */
 	pci_intx_for_msi(dev, 0);
@@ -309,7 +308,7 @@ static void __pci_restore_msix_state(str
 	write_msg = arch_restore_msi_irqs(dev);
 
 	msi_lock_descs(&dev->dev);
-	for_each_pci_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
 		if (write_msg)
 			__pci_write_msi_msg(entry, &entry->msg);
 		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
@@ -378,14 +377,14 @@ static int msi_verify_entries(struct pci
 	if (!dev->no_64bit_msi)
 		return 0;
 
-	for_each_pci_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
 		if (entry->msg.address_hi) {
 			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
 				entry->msg.address_hi, entry->msg.address_lo);
-			return -EIO;
+			break;
 		}
 	}
-	return 0;
+	return !entry ? 0 : -EIO;
 }
 
 /**
@@ -418,7 +417,7 @@ static int msi_capability_init(struct pc
 		goto unlock;
 
 	/* All MSIs are unmasked by default; mask them all */
-	entry = first_pci_msi_entry(dev);
+	entry = msi_first_desc(&dev->dev, MSI_DESC_ALL);
 	pci_msi_mask(entry, msi_multi_mask(entry));
 
 	/* Configure MSI capability structure */
@@ -508,11 +507,11 @@ static int msix_setup_msi_descs(struct p
 
 static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
 {
-	struct msi_desc *entry;
+	struct msi_desc *desc;
 
 	if (entries) {
-		for_each_pci_msi_entry(entry, dev) {
-			entries->vector = entry->irq;
+		msi_for_each_desc(desc, &dev->dev, MSI_DESC_ALL) {
+			entries->vector = desc->irq;
 			entries++;
 		}
 	}
@@ -705,15 +704,14 @@ static void pci_msi_shutdown(struct pci_
 	if (!pci_msi_enable || !dev || !dev->msi_enabled)
 		return;
 
-	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
-	desc = first_pci_msi_entry(dev);
-
 	pci_msi_set_enable(dev, 0);
 	pci_intx_for_msi(dev, 1);
 	dev->msi_enabled = 0;
 
 	/* Return the device with MSI unmasked as initial states */
-	pci_msi_unmask(desc, msi_multi_mask(desc));
+	desc = msi_first_desc(&dev->dev, MSI_DESC_ALL);
+	if (!WARN_ON_ONCE(!desc))
+		pci_msi_unmask(desc, msi_multi_mask(desc));
 
 	/* Restore dev->irq to its default pin-assertion IRQ */
 	dev->irq = desc->pci.msi_attrib.default_irq;
@@ -789,7 +787,7 @@ static int __pci_enable_msix(struct pci_
 
 static void pci_msix_shutdown(struct pci_dev *dev)
 {
-	struct msi_desc *entry;
+	struct msi_desc *desc;
 
 	if (!pci_msi_enable || !dev || !dev->msix_enabled)
 		return;
@@ -800,8 +798,8 @@ static void pci_msix_shutdown(struct pci
 	}
 
 	/* Return the device with MSI-X masked as initial states */
-	for_each_pci_msi_entry(entry, dev)
-		pci_msix_mask(entry);
+	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ALL)
+		pci_msix_mask(desc);
 
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
 	pci_intx_for_msi(dev, 1);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240138.416640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpQ-0003cz-PP; Mon, 06 Dec 2021 22:51:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240138.416640; Mon, 06 Dec 2021 22:51:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpQ-0003ZO-1e; Mon, 06 Dec 2021 22:51:24 +0000
Received: by outflank-mailman (input) for mailman id 240138;
 Mon, 06 Dec 2021 22:51:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpN-0000Tb-Qa
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:21 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07c55911-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07c55911-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.198359105@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831080;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=mHgTxiBl9Pg381SuWjuguHHZxZ6bDXurYM8uLZLwzPA=;
	b=BKB85X+Y76cMSyJV8pdeV1lBt8PONMLc3g6vJQjY5TF5snNtC126+QJYm3ZIVMhyl4wdPD
	R0cNDVDb6sx4XiV1XgwDnh7jWGaekehSZkZ01v0oan8MDdAD2tA2SvAT++EXPGl8AWEkKV
	UHZdE4IwHJyuxvUdZdcf74H4VOxkYauhHbPCv7hV7rJoTDig26Edmhbie0zozApc4A6xtM
	bU8oNK5gv//JGnrfK20cHKESEpzwTsOD+UQiDFPc2BKu4WtuDW4eOlfL0o905IXgNQ2x0y
	DBcFAkjCPdMPmGXSiBtXfGvxSLu9cTQ/s8dYFEc+amlV5XqMi6LyFgYZwVXbqA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831080;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=mHgTxiBl9Pg381SuWjuguHHZxZ6bDXurYM8uLZLwzPA=;
	b=p6ikB7Z47CfB9pZ8VBdJ2rKZANFys8tTYPu22ZmoXF+kzUT9a0nWoXxn5DEPaP9nFcZ4bS
	dE9G+kw0csS3zoCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 11/31] x86/pci/xen: Use msi_for_each_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:20 +0100 (CET)

Replace the about to vanish iterators.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/pci/xen.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -184,7 +184,7 @@ static int xen_setup_msi_irqs(struct pci
 	if (ret)
 		goto error;
 	i = 0;
-	for_each_pci_msi_entry(msidesc, dev) {
+	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		irq = xen_bind_pirq_msi_to_irq(dev, msidesc, v[i],
 					       (type == PCI_CAP_ID_MSI) ? nvec : 1,
 					       (type == PCI_CAP_ID_MSIX) ?
@@ -235,7 +235,7 @@ static int xen_hvm_setup_msi_irqs(struct
 	if (type == PCI_CAP_ID_MSI && nvec > 1)
 		return 1;
 
-	for_each_pci_msi_entry(msidesc, dev) {
+	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		pirq = xen_allocate_pirq_msi(dev, msidesc);
 		if (pirq < 0) {
 			irq = -ENODEV;
@@ -270,7 +270,7 @@ static int xen_initdom_setup_msi_irqs(st
 	int ret = 0;
 	struct msi_desc *msidesc;
 
-	for_each_pci_msi_entry(msidesc, dev) {
+	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		struct physdev_map_pirq map_irq;
 		domid_t domid;
 
@@ -389,11 +389,9 @@ static void xen_teardown_msi_irqs(struct
 	struct msi_desc *msidesc;
 	int i;
 
-	for_each_pci_msi_entry(msidesc, dev) {
-		if (msidesc->irq) {
-			for (i = 0; i < msidesc->nvec_used; i++)
-				xen_destroy_irq(msidesc->irq + i);
-		}
+	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_ASSOCIATED) {
+		for (i = 0; i < msidesc->nvec_used; i++)
+			xen_destroy_irq(msidesc->irq + i);
 	}
 }
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:51:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:51:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240143.416658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpU-0004gY-8M; Mon, 06 Dec 2021 22:51:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240143.416658; Mon, 06 Dec 2021 22:51:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMpU-0004fb-2D; Mon, 06 Dec 2021 22:51:28 +0000
Received: by outflank-mailman (input) for mailman id 240143;
 Mon, 06 Dec 2021 22:51:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpS-0008NM-Fc
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:26 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0aa8c2cb-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0aa8c2cb-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210748.359766435@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831085;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Zss9mzfScWFeJ2auPATLVX18AC4Qn1uic4NkiF38xfU=;
	b=QbOlaYLd67illK+RXm69ncvgL9zwen35YS0qk4pw2VmlWKfHuqtlqEHHBm8vTfCpXOVtGC
	/YwYsNN2mahTQwgaL5yHyodmBR4odrjNXlKrzL/KtcBH6KXWAa4V/sWDWnkIubcpUyPHLb
	WSphnGnNUyWJ23dyyU1+ZSv9x7GgoRVYZObpp2cDLcN8+Vd4BcIZ5tJ9Mu3arYQje2EL2W
	yzXoWqEcFaE3Ua/TtvSqE+g/9BboZUtfpvfEwH+AS94IqtD9d3NU2w2eybpzXq9zn1r0w+
	rTmvXHoN/7+UEFzjo2qzKQhqJJY8iJqDqw5N5DZ2ZCTqJli84gAxmaYA1nl4KQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831085;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Zss9mzfScWFeJ2auPATLVX18AC4Qn1uic4NkiF38xfU=;
	b=z/DvlpsspWgWro1GdhpcO0qe0cuCFF8HxhKT/D0ITEBaCrXK2e5haCQ2KBiMQ5WWMYJW+s
	H9AWbWwHjRClppAw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 14/31] powerpc/4xx/hsta: Rework MSI handling
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:25 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/powerpc/platforms/4xx/hsta_msi.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/arch/powerpc/platforms/4xx/hsta_msi.c
+++ b/arch/powerpc/platforms/4xx/hsta_msi.c
@@ -47,7 +47,7 @@ static int hsta_setup_msi_irqs(struct pc
 		return -EINVAL;
 	}
 
-	for_each_pci_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		irq = msi_bitmap_alloc_hwirqs(&ppc4xx_hsta_msi.bmp, 1);
 		if (irq < 0) {
 			pr_debug("%s: Failed to allocate msi interrupt\n",
@@ -105,10 +105,7 @@ static void hsta_teardown_msi_irqs(struc
 	struct msi_desc *entry;
 	int irq;
 
-	for_each_pci_msi_entry(entry, dev) {
-		if (!entry->irq)
-			continue;
-
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ASSOCIATED) {
 		irq = hsta_find_hwirq_offset(entry->irq);
 
 		/* entry->irq should always be in irq_map */



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:57:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240164.416680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMut-00080i-ED; Mon, 06 Dec 2021 22:57:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240164.416680; Mon, 06 Dec 2021 22:57:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMut-00080b-9f; Mon, 06 Dec 2021 22:57:03 +0000
Received: by outflank-mailman (input) for mailman id 240164;
 Mon, 06 Dec 2021 22:57:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpl-0000Tb-3l
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:45 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1533c31e-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1533c31e-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.956731741@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831103;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=h8HF/3BXQf6Dy3Y50LiKzGZ9Bzwn8IQ2u2c/JcHaHXM=;
	b=Vv+9zHCbxuViff0IiLJXdP9VzOlCXZ4rr4E50mmfHxJlolHUDjajFNRoKL2t512mvHq+Hi
	ZNuUKLqVX1kRIYw11fOPMX5K3yC3nRRB2z3zr1YEpzd4XtraYPwJ0Ig8nIUTUBj8B/DHty
	WL72PtGqKgfWtBI0xE1qip4+Z8U6eJ2i/2xHx6NOTKs5Up5cBOAhG8627lx1YsJPoc/s5D
	LHeR/hA9CAfUzhRuJErNC29m6jfPsvyNFa2w+U9idT3dJQWVIezbTmoBMfKuys+Ay17Fou
	5QFPEJpzerHGjzrqO3YZzrZREc3DBba5UABp8YpXaJHqdmliqNrrhPPP49nzsg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831103;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=h8HF/3BXQf6Dy3Y50LiKzGZ9Bzwn8IQ2u2c/JcHaHXM=;
	b=y75Z9VGlYCWE7hUxT9kdHcdNrVI5UvCOdBDbq4EcOkbwPXKNGevtjcpXWbMG68tI02fvJv
	rGRyhCOkBITbGPDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 25/31] platform-msi: Simplify platform device MSI code
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:42 +0100 (CET)

The allocation code is overly complex. It tries to have the MSI index space
packed, which is not working when an interrupt is freed. There is no
requirement for this. The only requirement is that the MSI index is unique.

Move the MSI descriptor allocation into msi_domain_populate_irqs() and use
the Linux interrupt number as MSI index which fulfils the unique
requirement.

This requires to lock the MSI descriptors which makes the lock order
reverse to the regular MSI alloc/free functions vs. the domain
mutex. Assign a seperate lockdep class for these MSI device domains.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/base/platform-msi.c |   88 +++++++++-----------------------------------
 kernel/irq/msi.c            |   45 ++++++++++------------
 2 files changed, 39 insertions(+), 94 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -246,6 +246,8 @@ void *platform_msi_get_host_data(struct
 	return data->host_data;
 }
 
+static struct lock_class_key platform_device_msi_lock_class;
+
 /**
  * __platform_msi_create_device_domain - Create a platform-msi device domain
  *
@@ -278,6 +280,13 @@ struct irq_domain *
 	if (err)
 		return NULL;
 
+	/*
+	 * Use a separate lock class for the MSI descriptor mutex on
+	 * platform MSI device domains because the descriptor mutex nests
+	 * into the domain mutex. See alloc/free below.
+	 */
+	lockdep_set_class(&dev->msi.data->mutex, &platform_device_msi_lock_class);
+
 	data = dev->msi.data->platform_data;
 	data->host_data = host_data;
 	domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
@@ -300,75 +309,23 @@ struct irq_domain *
 	return NULL;
 }
 
-static void platform_msi_free_descs(struct device *dev, int base, int nvec)
-{
-	struct msi_desc *desc, *tmp;
-
-	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		if (desc->msi_index >= base &&
-		    desc->msi_index < (base + nvec)) {
-			list_del(&desc->list);
-			free_msi_entry(desc);
-		}
-	}
-}
-
-static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
-					     int nvec)
-{
-	struct msi_desc *desc;
-	int i, base = 0;
-
-	if (!list_empty(dev_to_msi_list(dev))) {
-		desc = list_last_entry(dev_to_msi_list(dev),
-				       struct msi_desc, list);
-		base = desc->msi_index + 1;
-	}
-
-	for (i = 0; i < nvec; i++) {
-		desc = alloc_msi_entry(dev, 1, NULL);
-		if (!desc)
-			break;
-
-		desc->msi_index = base + i;
-		desc->irq = virq + i;
-
-		list_add_tail(&desc->list, dev_to_msi_list(dev));
-	}
-
-	if (i != nvec) {
-		/* Clean up the mess */
-		platform_msi_free_descs(dev, base, nvec);
-		return -ENOMEM;
-	}
-
-	return 0;
-}
-
 /**
  * platform_msi_device_domain_free - Free interrupts associated with a platform-msi
  *				     device domain
  *
  * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the free operation
- * @nvec:	How many interrupts to free from @virq
+ * @nr_irqs:	How many interrupts to free from @virq
  */
 void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
-				     unsigned int nvec)
+				     unsigned int nr_irqs)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
-	struct msi_desc *desc, *tmp;
 
-	for_each_msi_entry_safe(desc, tmp, data->dev) {
-		if (WARN_ON(!desc->irq || desc->nvec_used != 1))
-			return;
-		if (!(desc->irq >= virq && desc->irq < (virq + nvec)))
-			continue;
-
-		irq_domain_free_irqs_common(domain, desc->irq, 1);
-		list_del(&desc->list);
-		free_msi_entry(desc);
-	}
+	msi_lock_descs(data->dev);
+	irq_domain_free_irqs_common(domain, virq, nr_irqs);
+	msi_free_msi_descs_range(data->dev, MSI_DESC_ALL, virq, virq + nr_irqs - 1);
+	msi_unlock_descs(data->dev);
 }
 
 /**
@@ -377,7 +334,7 @@ void platform_msi_device_domain_free(str
  *
  * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the allocate operation
- * @nr_irqs:	How many interrupts to free from @virq
+ * @nr_irqs:	How many interrupts to allocate from @virq
  *
  * Return 0 on success, or an error code on failure. Must be called
  * with irq_domain_mutex held (which can only be done as part of a
@@ -387,16 +344,7 @@ int platform_msi_device_domain_alloc(str
 				     unsigned int nr_irqs)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
-	int err;
-
-	err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs);
-	if (err)
-		return err;
-
-	err = msi_domain_populate_irqs(domain->parent, data->dev,
-				       virq, nr_irqs, &data->arg);
-	if (err)
-		platform_msi_device_domain_free(domain, virq, nr_irqs);
+	struct device *dev = data->dev;
 
-	return err;
+	return msi_domain_populate_irqs(domain->parent, dev, virq, nr_irqs, &data->arg);
 }
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -748,43 +748,40 @@ int msi_domain_prepare_irqs(struct irq_d
 }
 
 int msi_domain_populate_irqs(struct irq_domain *domain, struct device *dev,
-			     int virq, int nvec, msi_alloc_info_t *arg)
+			     int virq_base, int nvec, msi_alloc_info_t *arg)
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
 	struct msi_desc *desc;
-	int ret = 0;
+	int ret, virq;
 
-	for_each_msi_entry(desc, dev) {
-		/* Don't even try the multi-MSI brain damage. */
-		if (WARN_ON(!desc->irq || desc->nvec_used != 1)) {
-			ret = -EINVAL;
-			break;
+	msi_lock_descs(dev);
+	for (virq = virq_base; virq < virq_base + nvec; virq++) {
+		desc = alloc_msi_entry(dev, 1, NULL);
+		if (!desc) {
+			ret = -ENOMEM;
+			goto fail;
 		}
 
-		if (!(desc->irq >= virq && desc->irq < (virq + nvec)))
-			continue;
+		desc->msi_index = virq;
+		desc->irq = virq;
+		list_add_tail(&desc->list, &dev->msi.data->list);
 
 		ops->set_desc(arg, desc);
-		/* Assumes the domain mutex is held! */
-		ret = irq_domain_alloc_irqs_hierarchy(domain, desc->irq, 1,
-						      arg);
+		ret = irq_domain_alloc_irqs_hierarchy(domain, virq, 1, arg);
 		if (ret)
-			break;
+			goto fail;
 
-		irq_set_msi_desc_off(desc->irq, 0, desc);
-	}
-
-	if (ret) {
-		/* Mop up the damage */
-		for_each_msi_entry(desc, dev) {
-			if (!(desc->irq >= virq && desc->irq < (virq + nvec)))
-				continue;
-
-			irq_domain_free_irqs_common(domain, desc->irq, 1);
-		}
+		irq_set_msi_desc(virq, desc);
 	}
+	msi_unlock_descs(dev);
+	return 0;
 
+fail:
+	for (--virq; virq >= virq_base; virq--)
+		irq_domain_free_irqs_common(domain, virq, 1);
+	msi_free_msi_descs_range(dev, MSI_DESC_ALL, virq_base, virq_base + nvec - 1);
+	msi_unlock_descs(dev);
 	return ret;
 }
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:57:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:57:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240163.416668 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMus-0007kM-5A; Mon, 06 Dec 2021 22:57:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240163.416668; Mon, 06 Dec 2021 22:57:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMus-0007kF-1V; Mon, 06 Dec 2021 22:57:02 +0000
Received: by outflank-mailman (input) for mailman id 240163;
 Mon, 06 Dec 2021 22:57:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpQ-0000Tb-Qa
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:24 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09af890e-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09af890e-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.305656158@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831084;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Llq/xc7jQ8Xd7gII/ZN8QZkMZgTGCYn2L7HFq42V+hA=;
	b=Z2biEVRp+uIYck8r4Ho+V21YXII6yZ5ZRe38dX2SGGbQEilaMhIIBS+2IEq6sPpnqjPpuN
	qQ+spdcJ5hQdQlkQeo3Sqz9NnuylGzktoi8AVjGh8OmbhMV3HvqkWhBhICHjjvKMJu6p0j
	w+EQFpg9MCXMdPidPi+SrM7XNAY9KM+Z5mHiwpamR4rBy1p2Srmgn8bFkkcswG3lq+7drk
	HiZieyWr3molk0V+3zEapZBf+CgVGomuwIRfjNGQyOdMeaey22DpkF7rcH1ZPM2PBZ/94N
	3qbYP+WoVk0EXQnE2KLkhLs4qGHKpDH6bnwaDLh3XA1tzRqm5ls7hq1S54xFhg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831084;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Llq/xc7jQ8Xd7gII/ZN8QZkMZgTGCYn2L7HFq42V+hA=;
	b=fV+NCA62RUR8rO/r5/VENKLtT9TPLmuFCqDiM2Pu6iytwciOqUFqiJGeIQfx53iyI8pjpS
	5T4WtTJIXTp/qeDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 13/31] s390/pci: Rework MSI descriptor walk
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:23 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Niklas Schnelle <schnelle@linux.ibm.com>
Acked-by: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
---
 arch/s390/pci/pci_irq.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/arch/s390/pci/pci_irq.c
+++ b/arch/s390/pci/pci_irq.c
@@ -303,7 +303,7 @@ int arch_setup_msi_irqs(struct pci_dev *
 
 	/* Request MSI interrupts */
 	hwirq = bit;
-	for_each_pci_msi_entry(msi, pdev) {
+	msi_for_each_desc(msi, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
 		rc = -EIO;
 		if (hwirq - bit >= msi_vecs)
 			break;
@@ -362,9 +362,7 @@ void arch_teardown_msi_irqs(struct pci_d
 		return;
 
 	/* Release MSI interrupts */
-	for_each_pci_msi_entry(msi, pdev) {
-		if (!msi->irq)
-			continue;
+	msi_for_each_desc(msi, &pdev->dev, MSI_DESC_ASSOCIATED) {
 		irq_set_msi_desc(msi->irq, NULL);
 		irq_free_desc(msi->irq);
 		msi->msg.address_lo = 0;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:57:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:57:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240172.416691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvA-0000Kg-RI; Mon, 06 Dec 2021 22:57:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240172.416691; Mon, 06 Dec 2021 22:57:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvA-0000KT-Ni; Mon, 06 Dec 2021 22:57:20 +0000
Received: by outflank-mailman (input) for mailman id 240172;
 Mon, 06 Dec 2021 22:57:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpi-0000Tb-KI
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 142d1d70-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 142d1d70-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.903173257@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TGj6QTdrqi/+rBbBw9aAzTJFtE/Dj0UpsCqlfUJ2p/4=;
	b=mVJN1RJZ51UJu4NAt17o9Yjlr69dkjvIBbh4zmID8wsFrx1rJQ7zF8Ma4ZLa1qLO35B4ql
	P7x+C0XkL8ECRkCPU4wA/WZUWiqJz/ZbiwpIBjy/hPxeDt9pIlnbIKUkTqSLhd5WuTbbKu
	KyYwTdc7q8cyCrVA9+PJGFtt/vPypBQj72H0G9p6BchpEikwi52abfJnbw8ycQtj99uVW/
	2+0owMtqhfYky6kH9IkuFLkySe/N8mJ+PdMKPQkGKCG4wDP6Eph23UvpCDUMUBDrvRa8F4
	q3n8EHkiqP/IyL1WHrYUS5lT6gYbpCadqhGNAJGkL+Se8PG0rPRwRwiVmRoL4g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831101;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TGj6QTdrqi/+rBbBw9aAzTJFtE/Dj0UpsCqlfUJ2p/4=;
	b=j5Te8xjGegqRV3djiYUjH5qxiB+uC/0NQXY/fqTJrxKk5j63OatgN4bIs6qcqwCM4937EE
	SKSVFVEZELM6gwDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 24/31] platform-msi: Let core code handle MSI descriptors
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:41 +0100 (CET)

Use the core functionality for platform MSI interrupt domains. The platform
device MSI interrupt domains will be converted in a later step.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/base/platform-msi.c |  112 ++++++++++++++++++--------------------------
 1 file changed, 48 insertions(+), 64 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -107,57 +107,6 @@ static void platform_msi_update_chip_ops
 		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
 }
 
-static void platform_msi_free_descs(struct device *dev, int base, int nvec)
-{
-	struct msi_desc *desc, *tmp;
-
-	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		if (desc->msi_index >= base &&
-		    desc->msi_index < (base + nvec)) {
-			list_del(&desc->list);
-			free_msi_entry(desc);
-		}
-	}
-}
-
-static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
-					     int nvec)
-{
-	struct msi_desc *desc;
-	int i, base = 0;
-
-	if (!list_empty(dev_to_msi_list(dev))) {
-		desc = list_last_entry(dev_to_msi_list(dev),
-				       struct msi_desc, list);
-		base = desc->msi_index + 1;
-	}
-
-	for (i = 0; i < nvec; i++) {
-		desc = alloc_msi_entry(dev, 1, NULL);
-		if (!desc)
-			break;
-
-		desc->msi_index = base + i;
-		desc->irq = virq ? virq + i : 0;
-
-		list_add_tail(&desc->list, dev_to_msi_list(dev));
-	}
-
-	if (i != nvec) {
-		/* Clean up the mess */
-		platform_msi_free_descs(dev, base, nvec);
-
-		return -ENOMEM;
-	}
-
-	return 0;
-}
-
-static int platform_msi_alloc_descs(struct device *dev, int nvec)
-{
-	return platform_msi_alloc_descs_with_irq(dev, 0, nvec);
-}
-
 /**
  * platform_msi_create_irq_domain - Create a platform MSI interrupt domain
  * @fwnode:		Optional fwnode of the interrupt controller
@@ -180,7 +129,8 @@ struct irq_domain *platform_msi_create_i
 		platform_msi_update_dom_ops(info);
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		platform_msi_update_chip_ops(info);
-	info->flags |= MSI_FLAG_DEV_SYSFS;
+	info->flags |= MSI_FLAG_DEV_SYSFS | MSI_FLAG_ALLOC_SIMPLE_MSI_DESCS |
+		       MSI_FLAG_FREE_MSI_DESCS;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (domain)
@@ -262,20 +212,10 @@ int platform_msi_domain_alloc_irqs(struc
 	if (err)
 		return err;
 
-	err = platform_msi_alloc_descs(dev, nvec);
-	if (err)
-		goto out_free_priv_data;
-
 	err = msi_domain_alloc_irqs(dev->msi.domain, dev, nvec);
 	if (err)
-		goto out_free_desc;
-
-	return 0;
+		platform_msi_free_priv_data(dev);
 
-out_free_desc:
-	platform_msi_free_descs(dev, 0, nvec);
-out_free_priv_data:
-	platform_msi_free_priv_data(dev);
 	return err;
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_alloc_irqs);
@@ -287,7 +227,6 @@ EXPORT_SYMBOL_GPL(platform_msi_domain_al
 void platform_msi_domain_free_irqs(struct device *dev)
 {
 	msi_domain_free_irqs(dev->msi.domain, dev);
-	platform_msi_free_descs(dev, 0, MAX_DEV_MSIS);
 	platform_msi_free_priv_data(dev);
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_free_irqs);
@@ -361,6 +300,51 @@ struct irq_domain *
 	return NULL;
 }
 
+static void platform_msi_free_descs(struct device *dev, int base, int nvec)
+{
+	struct msi_desc *desc, *tmp;
+
+	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
+		if (desc->msi_index >= base &&
+		    desc->msi_index < (base + nvec)) {
+			list_del(&desc->list);
+			free_msi_entry(desc);
+		}
+	}
+}
+
+static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
+					     int nvec)
+{
+	struct msi_desc *desc;
+	int i, base = 0;
+
+	if (!list_empty(dev_to_msi_list(dev))) {
+		desc = list_last_entry(dev_to_msi_list(dev),
+				       struct msi_desc, list);
+		base = desc->msi_index + 1;
+	}
+
+	for (i = 0; i < nvec; i++) {
+		desc = alloc_msi_entry(dev, 1, NULL);
+		if (!desc)
+			break;
+
+		desc->msi_index = base + i;
+		desc->irq = virq + i;
+
+		list_add_tail(&desc->list, dev_to_msi_list(dev));
+	}
+
+	if (i != nvec) {
+		/* Clean up the mess */
+		platform_msi_free_descs(dev, base, nvec);
+		return -ENOMEM;
+	}
+
+	return 0;
+}
+
 /**
  * platform_msi_device_domain_free - Free interrupts associated with a platform-msi
  *				     device domain



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:57:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:57:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240178.416702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvM-0000sI-5y; Mon, 06 Dec 2021 22:57:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240178.416702; Mon, 06 Dec 2021 22:57:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvM-0000s2-1s; Mon, 06 Dec 2021 22:57:32 +0000
Received: by outflank-mailman (input) for mailman id 240178;
 Mon, 06 Dec 2021 22:57:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpY-0008NM-TC
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:32 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e759fc0-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e759fc0-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210748.576162169@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831092;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=dSVT/iBVTDrru1VCPsyUkPO+wlN5QYdJblBQDMf4a+Q=;
	b=0jpZykVFahByTSIU6JsiwzTdXSNkC+vbCfHPHRTq2n7vJedXCqMtp3W5ATZZOfJL2KR0MX
	n4vNh+kloXIACVUXHsWH2dUt7VK3tEvLdYhheuFF9ZMLKcmmR6L2VQl1iCYNO1s6z1PFF8
	jw0U7kb2vzASbTW+FOQ1U8udFJGPk/varQ3F3CPyiGqTeEX8eVAgSnWOSTX76j+2zSh5td
	WujebdFoDc1FyLrXJij4UFN0YNlxQCtyP7NbcVC6m9fId0TqDAWIsqJaW6qGkEKuIZFem6
	gl8qJQ1MKobu4mHXeQZp1ZdtswCf+NxSmzr9W4M/L8tTTsbmJOq3kDTb77fb4A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831092;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=dSVT/iBVTDrru1VCPsyUkPO+wlN5QYdJblBQDMf4a+Q=;
	b=IGbmVcMWxjV1H2Iu29zzoB27Vb+RQJgrNOjPNotD60mUs7JmphQZxKcX3YYQSLPF9kkObH
	AhYDGctY83iFEvBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 18/31] powerpc/mpic_u3msi: Use msi_for_each-desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:31 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/powerpc/sysdev/mpic_u3msi.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

--- a/arch/powerpc/sysdev/mpic_u3msi.c
+++ b/arch/powerpc/sysdev/mpic_u3msi.c
@@ -104,17 +104,12 @@ static void u3msi_teardown_msi_irqs(stru
 	struct msi_desc *entry;
 	irq_hw_number_t hwirq;
 
-	for_each_pci_msi_entry(entry, pdev) {
-		if (!entry->irq)
-			continue;
-
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) {
 		hwirq = virq_to_hw(entry->irq);
 		irq_set_msi_desc(entry->irq, NULL);
 		irq_dispose_mapping(entry->irq);
 		msi_bitmap_free_hwirqs(&msi_mpic->msi_bitmap, hwirq, 1);
 	}
-
-	return;
 }
 
 static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
@@ -136,7 +131,7 @@ static int u3msi_setup_msi_irqs(struct p
 		return -ENXIO;
 	}
 
-	for_each_pci_msi_entry(entry, pdev) {
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
 		hwirq = msi_bitmap_alloc_hwirqs(&msi_mpic->msi_bitmap, 1);
 		if (hwirq < 0) {
 			pr_debug("u3msi: failed allocating hwirq\n");



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:58:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:58:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240198.416712 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvw-0001lP-EZ; Mon, 06 Dec 2021 22:58:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240198.416712; Mon, 06 Dec 2021 22:58:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMvw-0001lE-BC; Mon, 06 Dec 2021 22:58:08 +0000
Received: by outflank-mailman (input) for mailman id 240198;
 Mon, 06 Dec 2021 22:58:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpq-0000Tb-AS
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:50 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 18e45087-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18e45087-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210749.170847844@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831109;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=2+Fbb5gke6gcz4AzBnqqKfV1dHcK3QpqxgzZSH+MZMI=;
	b=bnZaUEhfG0UeeW/OOKDxGmdF+k9dZfJqfLbI9vMgjyaRk4pQVpDJMmF6O8axwELAAGN94P
	p8nkQzlotno6/ca+w9GRpiSzpxX+1DUG8j+XUXVWKMENF72x1B7Kr3ckM7/4pZFIuuAsQN
	n25CnfGvbbv10+BIsZ/F//h9i4CPTqlvkFp2TFSqjZgEKEILeaMbxRqfwi3nkZbiqdACeS
	PXGzLAxQV8xxL2vrQ1Ks3CIFzX2K89ilPRPp673s2mSWCSk85T+lAsvL5z147Il7woZdB5
	YBTe5QZQQTRN2OPRctywvDJyf9a66wKsFwcyDxiLA9agKu9A4ymAB5sDLg3kFA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831109;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=2+Fbb5gke6gcz4AzBnqqKfV1dHcK3QpqxgzZSH+MZMI=;
	b=bduvthv5f6fp+NqJVG4WpRyqTxwr2VlM9ta1sybZ8puUSEyUg5NAWfkQQ1zDkusuX8+Nki
	Jb1fWgZhNxTGBIDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject:
 [patch V2 29/31] genirq/msi: Add abuse prevention comment to msi header
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:49 +0100 (CET)

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -2,6 +2,20 @@
 #ifndef LINUX_MSI_H
 #define LINUX_MSI_H
 
+/*
+ * This header file contains MSI data structures and functions which are
+ * only relevant for:
+ *	- Interrupt core code
+ *	- PCI/MSI core code
+ *	- MSI interrupt domain implementations
+ *	- IOMMU, low level VFIO, NTB and other justified exceptions
+ *	  dealing with low level MSI details.
+ *
+ * Regular device drivers have no business with any of these functions and
+ * especially storing MSI descriptor pointers in random code is considered
+ * abuse. The only function which is relevant for drivers is msi_get_virq().
+ */
+
 #include <linux/cpumask.h>
 #include <linux/mutex.h>
 #include <linux/list.h>



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:58:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:58:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240230.416724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMwd-0002Yf-Oq; Mon, 06 Dec 2021 22:58:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240230.416724; Mon, 06 Dec 2021 22:58:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMwd-0002YY-KK; Mon, 06 Dec 2021 22:58:51 +0000
Received: by outflank-mailman (input) for mailman id 240230;
 Mon, 06 Dec 2021 22:58:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpp-0008NM-5b
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:49 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 180a1712-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 180a1712-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210749.117395027@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831108;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UQMeiJXeYiF947FjCPAG7vmRPuGlZ4RmWN1aFBAPWbY=;
	b=j8YDzfjTOVUtw2G4OjF5y06/jFdlYtyKLnuhNrK/bpkLkaTnn4AGZv/jRnvqge83ewT9EZ
	Nwz09wQ3vuJDAxrxrxHq97EhX5xlkbEy8l7ZqB2CE52Smd2nR5hauYUPb70AJfEYW+2m28
	/Ri3ke8al8TQjGRnjGB/dm2AsxUZ9EfKd2HMejOjmKccTj9QrHC9peKnbe8+CVti8ouwJ3
	C1AwktksJnEpHS9BCJsw0vfnuwSS4osKJV69d2y3ByoF2epRfOLHWZBcaL6uLbdG70krcL
	T7hUqEEbHU38REpT8x5KxoTUwUAdy96NvUeCCHoSiy01OTTa4eKEcs4uOXnqKQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831108;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=UQMeiJXeYiF947FjCPAG7vmRPuGlZ4RmWN1aFBAPWbY=;
	b=D+mlv+y+61yJoVZdD/rMHCJo6H0xkNc8ovcUZeqWP8Mth8m+KK95tAht+2fHEV6BMo8mIr
	+btOYd7SZwaNFAAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 28/31] genirq/msi: Mop up old interfaces
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:47 +0100 (CET)

Get rid of the old iterators, alloc/free functions and adjust the core code
accordingly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/msi.h |   15 ---------------
 kernel/irq/msi.c    |   31 +++++++++++++++----------------
 2 files changed, 15 insertions(+), 31 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -214,15 +214,7 @@ struct msi_desc *msi_next_desc(struct de
 	for ((desc) = msi_first_desc((dev), (filter)); (desc);	\
 	     (desc) = msi_next_desc((dev), (filter)))
 
-/* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
-#define dev_to_msi_list(dev)		(&(dev)->msi.data->list)
-#define first_msi_entry(dev)		\
-	list_first_entry(dev_to_msi_list((dev)), struct msi_desc, list)
-#define for_each_msi_entry(desc, dev)	\
-	list_for_each_entry((desc), dev_to_msi_list((dev)), list)
-#define for_each_msi_entry_safe(desc, tmp, dev)	\
-	list_for_each_entry_safe((desc), (tmp), dev_to_msi_list((dev)), list)
 
 #ifdef CONFIG_IRQ_MSI_IOMMU
 static inline const void *msi_desc_get_iommu_cookie(struct msi_desc *desc)
@@ -248,10 +240,6 @@ static inline void msi_desc_set_iommu_co
 #endif
 
 #ifdef CONFIG_PCI_MSI
-#define first_pci_msi_entry(pdev)	first_msi_entry(&(pdev)->dev)
-#define for_each_pci_msi_entry(desc, pdev)	\
-	for_each_msi_entry((desc), &(pdev)->dev)
-
 struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc);
 void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg);
 #else /* CONFIG_PCI_MSI */
@@ -273,9 +261,6 @@ static inline void msi_free_msi_descs(st
 	msi_free_msi_descs_range(dev, MSI_DESC_ALL, 0, MSI_MAX_INDEX);
 }
 
-struct msi_desc *alloc_msi_entry(struct device *dev, int nvec,
-				 const struct irq_affinity_desc *affinity);
-void free_msi_entry(struct msi_desc *entry);
 void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -19,8 +19,10 @@
 
 #include "internals.h"
 
+#define dev_to_msi_list(dev)	(&(dev)->msi.data->list)
+
 /**
- * alloc_msi_entry - Allocate an initialized msi_desc
+ * msi_alloc_desc - Allocate an initialized msi_desc
  * @dev:	Pointer to the device for which this is allocated
  * @nvec:	The number of vectors used in this entry
  * @affinity:	Optional pointer to an affinity mask array size of @nvec
@@ -30,12 +32,11 @@
  *
  * Return: pointer to allocated &msi_desc on success or %NULL on failure
  */
-struct msi_desc *alloc_msi_entry(struct device *dev, int nvec,
-				 const struct irq_affinity_desc *affinity)
+static struct msi_desc *msi_alloc_desc(struct device *dev, int nvec,
+					const struct irq_affinity_desc *affinity)
 {
-	struct msi_desc *desc;
+	struct msi_desc *desc = kzalloc(sizeof(*desc), GFP_KERNEL);
 
-	desc = kzalloc(sizeof(*desc), GFP_KERNEL);
 	if (!desc)
 		return NULL;
 
@@ -43,21 +44,19 @@ struct msi_desc *alloc_msi_entry(struct
 	desc->dev = dev;
 	desc->nvec_used = nvec;
 	if (affinity) {
-		desc->affinity = kmemdup(affinity,
-			nvec * sizeof(*desc->affinity), GFP_KERNEL);
+		desc->affinity = kmemdup(affinity, nvec * sizeof(*desc->affinity), GFP_KERNEL);
 		if (!desc->affinity) {
 			kfree(desc);
 			return NULL;
 		}
 	}
-
 	return desc;
 }
 
-void free_msi_entry(struct msi_desc *entry)
+static void msi_free_desc(struct msi_desc *desc)
 {
-	kfree(entry->affinity);
-	kfree(entry);
+	kfree(desc->affinity);
+	kfree(desc);
 }
 
 /**
@@ -73,7 +72,7 @@ int msi_add_msi_desc(struct device *dev,
 
 	lockdep_assert_held(&dev->msi.data->mutex);
 
-	desc = alloc_msi_entry(dev, init_desc->nvec_used, init_desc->affinity);
+	desc = msi_alloc_desc(dev, init_desc->nvec_used, init_desc->affinity);
 	if (!desc)
 		return -ENOMEM;
 
@@ -102,7 +101,7 @@ static int msi_add_simple_msi_descs(stru
 	lockdep_assert_held(&dev->msi.data->mutex);
 
 	for (i = 0; i < ndesc; i++) {
-		desc = alloc_msi_entry(dev, 1, NULL);
+		desc = msi_alloc_desc(dev, 1, NULL);
 		if (!desc)
 			goto fail;
 		desc->msi_index = index + i;
@@ -114,7 +113,7 @@ static int msi_add_simple_msi_descs(stru
 fail:
 	list_for_each_entry_safe(desc, tmp, &list, list) {
 		list_del(&desc->list);
-		free_msi_entry(desc);
+		msi_free_desc(desc);
 	}
 	return -ENOMEM;
 }
@@ -141,7 +140,7 @@ void msi_free_msi_descs_range(struct dev
 		if (desc->msi_index < first_index || desc->msi_index > last_index)
 			continue;
 		list_del(&desc->list);
-		free_msi_entry(desc);
+		msi_free_desc(desc);
 	}
 }
 
@@ -762,7 +761,7 @@ int msi_domain_populate_irqs(struct irq_
 
 	msi_lock_descs(dev);
 	for (virq = virq_base; virq < virq_base + nvec; virq++) {
-		desc = alloc_msi_entry(dev, 1, NULL);
+		desc = msi_alloc_desc(dev, 1, NULL);
 		if (!desc) {
 			ret = -ENOMEM;
 			goto fail;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:59:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:59:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240239.416735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMwv-00036x-0N; Mon, 06 Dec 2021 22:59:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240239.416735; Mon, 06 Dec 2021 22:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMwu-00036q-TQ; Mon, 06 Dec 2021 22:59:08 +0000
Received: by outflank-mailman (input) for mailman id 240239;
 Mon, 06 Dec 2021 22:59:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpe-0008NM-4q
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:38 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 115b7660-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 115b7660-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210748.737904583@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831096;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=CzqGTYDUie5SurN5/gfV37QSqlTZtJhIqYh57XXY9vc=;
	b=1RPNxtfr5VOlwanCXHzzCGA5Okk7iWaKRIecmxZqcQ6GJ0N+TtqkJB4YBgKir4DpaFIby2
	TRL5d8Yy6CPk4zvOP3IAjf8rBmhgoTlm/L1kch6yeBRZBqQv1tnis78DJISBVkWqedG7kW
	+UF+HoUE+QXVYx2FHqbtaf8jvVW1CIcSK0Lt9gdkhNLog4N5iX/+i0lCCEkRdUsCAH5BS+
	M8Ui7QxFmKA/zA6UsxNXXH9SHexJzn01o7N0bxnreZcIW5uaSDvXRX6Db6sRqabEbx7TII
	t2IyHWZfEGz8M5lT0y6GzRbyCNuKzYCId/ZxJxgQ9wg+WoVlQuVF7cJLPCN54g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831096;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=CzqGTYDUie5SurN5/gfV37QSqlTZtJhIqYh57XXY9vc=;
	b=Jct3bSAMJvPsNwVF2TBaEtc50EznqpM+HcoTb5h9bKmrJfg+EG2SWo9/6tVTtRKQrwReAU
	pte3E9Jf8LXGmsBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject:
 [patch V2 21/31] soc: ti: ti_sci_inta_msi: Rework MSI descriptor allocation
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:36 +0100 (CET)

Protect the allocation properly and use the core allocation and free
mechanism.

No functional change intended.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/soc/ti/ti_sci_inta_msi.c |   71 +++++++++++++--------------------------
 1 file changed, 25 insertions(+), 46 deletions(-)

--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -51,6 +51,7 @@ struct irq_domain *ti_sci_inta_msi_creat
 	struct irq_domain *domain;
 
 	ti_sci_inta_msi_update_chip_ops(info);
+	info->flags |= MSI_FLAG_FREE_MSI_DESCS;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (domain)
@@ -60,50 +61,31 @@ struct irq_domain *ti_sci_inta_msi_creat
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_create_irq_domain);
 
-static void ti_sci_inta_msi_free_descs(struct device *dev)
-{
-	struct msi_desc *desc, *tmp;
-
-	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		list_del(&desc->list);
-		free_msi_entry(desc);
-	}
-}
-
 static int ti_sci_inta_msi_alloc_descs(struct device *dev,
 				       struct ti_sci_resource *res)
 {
-	struct msi_desc *msi_desc;
+	struct msi_desc msi_desc;
 	int set, i, count = 0;
 
+	memset(&msi_desc, 0, sizeof(msi_desc));
+
 	for (set = 0; set < res->sets; set++) {
-		for (i = 0; i < res->desc[set].num; i++) {
-			msi_desc = alloc_msi_entry(dev, 1, NULL);
-			if (!msi_desc) {
-				ti_sci_inta_msi_free_descs(dev);
-				return -ENOMEM;
-			}
-
-			msi_desc->msi_index = res->desc[set].start + i;
-			INIT_LIST_HEAD(&msi_desc->list);
-			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
-			count++;
+		for (i = 0; i < res->desc[set].num; i++, count++) {
+			msi_desc.msi_index = res->desc[set].start + i;
+			if (msi_add_msi_desc(dev, &msi_desc))
+				goto fail;
 		}
-		for (i = 0; i < res->desc[set].num_sec; i++) {
-			msi_desc = alloc_msi_entry(dev, 1, NULL);
-			if (!msi_desc) {
-				ti_sci_inta_msi_free_descs(dev);
-				return -ENOMEM;
-			}
-
-			msi_desc->msi_index = res->desc[set].start_sec + i;
-			INIT_LIST_HEAD(&msi_desc->list);
-			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
-			count++;
+
+		for (i = 0; i < res->desc[set].num_sec; i++, count++) {
+			msi_desc.msi_index = res->desc[set].start_sec + i;
+			if (msi_add_msi_desc(dev, &msi_desc))
+				goto fail;
 		}
 	}
-
 	return count;
+fail:
+	msi_free_msi_descs(dev);
+	return -ENOMEM;
 }
 
 int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
@@ -124,20 +106,18 @@ int ti_sci_inta_msi_domain_alloc_irqs(st
 	if (ret)
 		return ret;
 
+	msi_lock_descs(dev);
 	nvec = ti_sci_inta_msi_alloc_descs(dev, res);
-	if (nvec <= 0)
-		return nvec;
-
-	ret = msi_domain_alloc_irqs(msi_domain, dev, nvec);
-	if (ret) {
-		dev_err(dev, "Failed to allocate IRQs %d\n", ret);
-		goto cleanup;
+	if (nvec <= 0) {
+		ret = nvec;
+		goto unlock;
 	}
 
-	return 0;
-
-cleanup:
-	ti_sci_inta_msi_free_descs(&pdev->dev);
+	ret = msi_domain_alloc_irqs_descs_locked(msi_domain, dev, nvec);
+	if (ret)
+		dev_err(dev, "Failed to allocate IRQs %d\n", ret);
+unlock:
+	msi_unlock_descs(dev);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_alloc_irqs);
@@ -145,6 +125,5 @@ EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain
 void ti_sci_inta_msi_domain_free_irqs(struct device *dev)
 {
 	msi_domain_free_irqs(dev->msi.domain, dev);
-	ti_sci_inta_msi_free_descs(dev);
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 22:59:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 22:59:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240252.416745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMxH-0003sQ-EM; Mon, 06 Dec 2021 22:59:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240252.416745; Mon, 06 Dec 2021 22:59:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMxH-0003sJ-BH; Mon, 06 Dec 2021 22:59:31 +0000
Received: by outflank-mailman (input) for mailman id 240252;
 Mon, 06 Dec 2021 22:59:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpf-0000Tb-94
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:39 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1252291d-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1252291d-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.793119155@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831098;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=GUR2OxklGtF7nIOBqOyJrqx9CLAOqYt69MVFmzr2xdI=;
	b=nn7dEwkEAkvWRKbdApCe1Nm/bB6LC9VNn6X6hBZTCaCIYeYxE+VrS7/Mtl1kphsy8a/Q23
	kjB4YpSOhYoMrj7ErcNmK8M8f0lj0Y59umb1wroZ3CNKfFENgr+n8OkJ6r8b3o/v1b8yXW
	b7ndtXG/q2hCY9j6o4RicdXwGGzUa/M29ROck6jbO2NDHydrPYG9wL2lRiWRf/AFhMUQt1
	iLIG8S61ibfICnkXqLvCZK6jr50bd2s65rfMK1h0boqu09T3/hPzNOypVDSANi0qi3ySMa
	qOn/Tsktc2oYmhtwz6s1KlZz+zosMMfgyON0d7vskLdthwamU1D2s5rhVbATcA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831098;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=GUR2OxklGtF7nIOBqOyJrqx9CLAOqYt69MVFmzr2xdI=;
	b=8CfzsmQ7CNDe0nMTxrF9BsEbKCFk5GvK6bcHAeaT1wkDGjUkuPIqDQJmgOzxewvdhSqDDu
	CQ5LX8F2K+7lXrAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 22/31] soc: ti: ti_sci_inta_msi: Remove
 ti_sci_inta_msi_domain_free_irqs()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:37 +0100 (CET)

The function has no users and is pointless now that the core frees the MSI
descriptors, which means potential users can just use msi_domain_free_irqs().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/soc/ti/ti_sci_inta_msi.c       |    6 ------
 include/linux/soc/ti/ti_sci_inta_msi.h |    1 -
 2 files changed, 7 deletions(-)

--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -121,9 +121,3 @@ int ti_sci_inta_msi_domain_alloc_irqs(st
 	return ret;
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_alloc_irqs);
-
-void ti_sci_inta_msi_domain_free_irqs(struct device *dev)
-{
-	msi_domain_free_irqs(dev->msi.domain, dev);
-}
-EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
--- a/include/linux/soc/ti/ti_sci_inta_msi.h
+++ b/include/linux/soc/ti/ti_sci_inta_msi.h
@@ -18,5 +18,4 @@ struct irq_domain
 				   struct irq_domain *parent);
 int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
 				      struct ti_sci_resource *res);
-void ti_sci_inta_msi_domain_free_irqs(struct device *dev);
 #endif /* __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H */



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:00:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:00:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240280.416756 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyF-0005Xf-Pv; Mon, 06 Dec 2021 23:00:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240280.416756; Mon, 06 Dec 2021 23:00:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyF-0005XT-MZ; Mon, 06 Dec 2021 23:00:31 +0000
Received: by outflank-mailman (input) for mailman id 240280;
 Mon, 06 Dec 2021 23:00:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpU-0000Tb-0G
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:28 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b985621-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b985621-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.414712173@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831087;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=doaEN4PngPF6b3Ms4+nCLub9WRL+cYqg2iUonunceVg=;
	b=mDVbOZFMq2r0fFSal6nGytKiR9N0dKq5PqwK3juP1cFnlgmQUuw4LpkD1Hpm/hkbKZm+u7
	Yea4cNfID7VRix/TmSW0sPFLvyDtgOlkMm7w8ymCcbMXlPLtwak2/32g8dpHmlOP3O/F6G
	jdU4NlHvekujXArGpsBa5yUjWwJ1eEzk2cniYcCq3kZdS9WskWSkWr65L4WuQjer6xqU1f
	Ul5hlmIH9G0tFTvOrZ6TNqwpU2DDuWudK+A/4sOQoKvCebsyPKW3/F+OiN3j2Uvb53neJ1
	tJE6RPkzzdtCxeELmNPrSmNWxRMUlB41D5TaNxMfPsoV84Jl5DW5WZfsZ5VwLQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831087;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=doaEN4PngPF6b3Ms4+nCLub9WRL+cYqg2iUonunceVg=;
	b=edZkzp0cQopCCOVDx2I8Wc5M/D97TZhEVVbeeZnpase12JmLW+w6pTojHaCFf7vSYnKATQ
	gAtXqukltBF2IkBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 15/31] powerpc/cell/axon_msi: Convert to msi_on_each_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:26 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/powerpc/platforms/cell/axon_msi.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -265,7 +265,7 @@ static int axon_msi_setup_msi_irqs(struc
 	if (rc)
 		return rc;
 
-	for_each_pci_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		virq = irq_create_direct_mapping(msic->irq_domain);
 		if (!virq) {
 			dev_warn(&dev->dev,
@@ -288,10 +288,7 @@ static void axon_msi_teardown_msi_irqs(s
 
 	dev_dbg(&dev->dev, "axon_msi: tearing down msi irqs\n");
 
-	for_each_pci_msi_entry(entry, dev) {
-		if (!entry->irq)
-			continue;
-
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ASSOCIATED) {
 		irq_set_msi_desc(entry->irq, NULL);
 		irq_dispose_mapping(entry->irq);
 	}



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:00:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:00:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240282.416768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyO-0005uT-2e; Mon, 06 Dec 2021 23:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240282.416768; Mon, 06 Dec 2021 23:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyN-0005uM-Vm; Mon, 06 Dec 2021 23:00:39 +0000
Received: by outflank-mailman (input) for mailman id 240282;
 Mon, 06 Dec 2021 23:00:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpc-0008NM-4Y
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:36 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10654d0b-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10654d0b-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210748.683004012@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831095;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=s/VOVQMyDYcB6+dcIQa54u5N9xLv27CFi4i5YMxXHXY=;
	b=4smyVig+0kG3Mj5Ff5573pxp5MUbsQE22Dot8kdArwx554E4qvBjgUNwsUFirP6FIXpq/2
	jLneA+N6EazSPge6uWP1/APnqcC/TEJttmN3r4EXFJG0zTQRnbXFshy/BKu3cMk8DYT4TI
	a1LWuN2gtGyLccsm080S5fJ3L4OIiaLJNWRl9xqpeK6tqEuWTOBTcjH6mXifIaF3tB799u
	ykw64cq3FSqDk3968loa4xhNN2kfvB5Ow9lKi8cAP09S0tlG4eZsgu09LMzUDXCW+QStem
	T6+4q+ZhI9z4g6e+lVp0DHz4KnOAJBpwgHEJba+DAXSr453HDRrdudBJq9DUbQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831095;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=s/VOVQMyDYcB6+dcIQa54u5N9xLv27CFi4i5YMxXHXY=;
	b=/dhk0ATnFXvIqHsCnqzQC/b2Yp0LVMLjufNEI55WRSEferFEbY3QW5BRA9ipZqGQCt/Tv0
	yttXqgSSg8GY1rAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [patch V2 20/31] NTB/msi: Convert to msi_on_each_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:34 +0100 (CET)

Replace the about to vanish iterators, make use of the filtering and take
the descriptor lock around the iteration.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Cc: Logan Gunthorpe <logang@deltatee.com>
Cc: Jon Mason <jdmason@kudzu.us>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Allen Hubbe <allenbh@gmail.com>
Cc: linux-ntb@googlegroups.com
---
 drivers/ntb/msi.c |   19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

--- a/drivers/ntb/msi.c
+++ b/drivers/ntb/msi.c
@@ -108,8 +108,10 @@ int ntb_msi_setup_mws(struct ntb_dev *nt
 	if (!ntb->msi)
 		return -EINVAL;
 
-	desc = first_msi_entry(&ntb->pdev->dev);
+	msi_lock_descs(&ntb->pdev->dev);
+	desc = msi_first_desc(&ntb->pdev->dev, MSI_DESC_ASSOCIATED);
 	addr = desc->msg.address_lo + ((uint64_t)desc->msg.address_hi << 32);
+	msi_unlock_descs(&ntb->pdev->dev);
 
 	for (peer = 0; peer < ntb_peer_port_count(ntb); peer++) {
 		peer_widx = ntb_peer_highest_mw_idx(ntb, peer);
@@ -281,13 +283,15 @@ int ntbm_msi_request_threaded_irq(struct
 				  const char *name, void *dev_id,
 				  struct ntb_msi_desc *msi_desc)
 {
+	struct device *dev = &ntb->pdev->dev;
 	struct msi_desc *entry;
 	int ret;
 
 	if (!ntb->msi)
 		return -EINVAL;
 
-	for_each_pci_msi_entry(entry, ntb->pdev) {
+	msi_lock_descs(dev);
+	msi_for_each_desc(entry, dev, MSI_DESC_ASSOCIATED) {
 		if (irq_has_action(entry->irq))
 			continue;
 
@@ -304,14 +308,17 @@ int ntbm_msi_request_threaded_irq(struct
 		ret = ntbm_msi_setup_callback(ntb, entry, msi_desc);
 		if (ret) {
 			devm_free_irq(&ntb->dev, entry->irq, dev_id);
-			return ret;
+			goto unlock;
 		}
 
-
-		return entry->irq;
+		ret = entry->irq;
+		goto unlock;
 	}
+	ret = -ENODEV;
 
-	return -ENODEV;
+unlock:
+	msi_unlock_descs(dev);
+	return ret;
 }
 EXPORT_SYMBOL(ntbm_msi_request_threaded_irq);
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240302.416778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyt-0006n2-Bu; Mon, 06 Dec 2021 23:01:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240302.416778; Mon, 06 Dec 2021 23:01:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyt-0006mv-8u; Mon, 06 Dec 2021 23:01:11 +0000
Received: by outflank-mailman (input) for mailman id 240302;
 Mon, 06 Dec 2021 23:01:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpP-0000Tb-SU
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:23 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 092771e1-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 092771e1-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.251752714@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831082;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=JXvHU/eN0iJfDqMWbOd2UGXYgpl11UY148yTUdaqnAk=;
	b=ukVi5c/T0wAHb0tWABPTJaUJemaPo0rn/ubgZey7RWONU6+1fkTEp8z7nsXym15YfPSOE5
	gnuGJ9tYXfPz/XmKxaGw/rWBKd3wGOGsLUyCa5pt6g4Ho/VHynZ8/8qUrkrrzaKdiUKiFA
	yd7Vz3JZgxduDhmYYHK6QE9T/SuQZan/17wKFT2uBdepAeN0onpzHk7FOnaPQvbNSQJa1u
	fcugKzMmwOWAMJs3UC5IftbkkN1qTj6HFNtFF42kTBKqdsIymhLXws2qmGn3EEYWahrvQZ
	/2BGRgdEm7qxuk081PI2V1XUwse1UmYqbcpvcjMWvU3qKsZ7AolzmuPZFyYsQg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831082;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=JXvHU/eN0iJfDqMWbOd2UGXYgpl11UY148yTUdaqnAk=;
	b=YM0Ywg7edi2ZBxPs7s0TLBjJF3/P4WkZ3tMBbv6SeiU4PPQA1i7E5adkZL6TVwgY/+0w4W
	hrhh523QoFEKpCDg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 12/31] xen/pcifront: Rework MSI handling
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:21 +0100 (CET)

Replace the about to vanish iterators.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/xen-pcifront.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -262,7 +262,7 @@ static int pci_frontend_enable_msix(stru
 	}
 
 	i = 0;
-	for_each_pci_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, &dev->dev, MSI_DESC_NOTASSOCIATED) {
 		op.msix_entries[i].entry = entry->msi_index;
 		/* Vector is useless at this point. */
 		op.msix_entries[i].vector = -1;



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240303.416790 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyu-000740-KX; Mon, 06 Dec 2021 23:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240303.416790; Mon, 06 Dec 2021 23:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMyu-00073f-Gv; Mon, 06 Dec 2021 23:01:12 +0000
Received: by outflank-mailman (input) for mailman id 240303;
 Mon, 06 Dec 2021 23:01:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpX-0008NM-7S
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:31 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0d7ce2ee-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0d7ce2ee-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210748.522641685@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831090;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ir5jZb4IZcCDGObECwlZouR2K23XLyndrt4jAkdV6zI=;
	b=QOZqkE0mJaaNW80XWv33hPs1zpCYzh+3dsqlRwgrP9IFd97NBJwLLY6Dn+msWsXzzo1V16
	10Edu9RH75xmcw/dicGGO+7NkLpNtC1pr8dlGykvnp06LKXMsjiC6lWwl7DQJ89xWx1ROb
	qXNOY3lAEhxYdjctEGjclYuq6TCu81wIS5l5RtBe8UdHMzMEFlBftu4I2a7JDr9hi7R2uD
	BKUCuOavG9T1GADvBsnPWuhPebbgWNM0iLqM7Ttt3qt5zPgDADKpzIs3JEEvaAlU2+4wwH
	Hbb8jxHi0Qz3jTnDtW+odZgtAOgQMSvZ2v67OLqqe6koizHIu8k3Wa1YRvz5Lg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831090;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ir5jZb4IZcCDGObECwlZouR2K23XLyndrt4jAkdV6zI=;
	b=rmBdkPatKzaCW/DyQuCnHCIcksrz3J4ZKrWW0QYtPGJpZFG7lwsct1bXSyTs7E6ooJaZ4l
	dh7biS/tfXnlPlCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 17/31] powerpc/fsl_msi: Use msi_for_each_desc()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:29 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/powerpc/sysdev/fsl_msi.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch/powerpc/sysdev/fsl_msi.c
@@ -125,17 +125,13 @@ static void fsl_teardown_msi_irqs(struct
 	struct fsl_msi *msi_data;
 	irq_hw_number_t hwirq;
 
-	for_each_pci_msi_entry(entry, pdev) {
-		if (!entry->irq)
-			continue;
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) {
 		hwirq = virq_to_hw(entry->irq);
 		msi_data = irq_get_chip_data(entry->irq);
 		irq_set_msi_desc(entry->irq, NULL);
 		irq_dispose_mapping(entry->irq);
 		msi_bitmap_free_hwirqs(&msi_data->bitmap, hwirq, 1);
 	}
-
-	return;
 }
 
 static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq,
@@ -215,7 +211,7 @@ static int fsl_setup_msi_irqs(struct pci
 		}
 	}
 
-	for_each_pci_msi_entry(entry, pdev) {
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
 		/*
 		 * Loop over all the MSI devices until we find one that has an
 		 * available interrupt.



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240311.416800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMz8-0007i6-Tk; Mon, 06 Dec 2021 23:01:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240311.416800; Mon, 06 Dec 2021 23:01:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMz8-0007hw-Qj; Mon, 06 Dec 2021 23:01:26 +0000
Received: by outflank-mailman (input) for mailman id 240311;
 Mon, 06 Dec 2021 23:01:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpm-0000Tb-3r
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:46 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 161aa009-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 161aa009-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210749.010234767@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831104;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ipuCExogsDYfjcIoTIggPfIeuQ7+Ly8nlNeTuzuXIek=;
	b=bZGnWImJMvj7ivrlJ6U2hMxWKZXlmQQ7bpp4PAifkCJo4YeWOJcjVmw95OHOwHrSyA/ptz
	PVZTvnmOilLRrugy/Cyu7Lkb9pmeulbH276306Gzm46ESh6MhwASAZMd/JINrLP7DX/EcW
	9EtGDiFwSHKFW9I+8QUKb/qCHPAzcsyNC3HOBmULNYx/RmHh1M5XJIhWDAad+yzUYg+FaO
	HTJbfsOmSMf6Q4+eMwGo6ht9HqvsjICWXRo4cR5li+x8+cddrtyFL0ouwQXfVbuLym0tr9
	AZwOSgXnfWeYO/S65WVTomLXlNwBELylbogFz1eugsNigDz/FOTaVxrH4stPBw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831104;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ipuCExogsDYfjcIoTIggPfIeuQ7+Ly8nlNeTuzuXIek=;
	b=ipve1PswDehRBnj60SViTpnvl/P3f6xRVDd/TBi4hIisW20v+M18tZGVXDf9uZI25Xz/xk
	FPfjxtxj7Rs+xJDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject:
 [patch V2 26/31] genirq/msi: Make interrupt allocation less convoluted
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:44 +0100 (CET)

There is no real reason to do several loops over the MSI descriptors
instead of just doing one loop. In case of an error everything is undone
anyway so it does not matter whether it's a partial or a full rollback.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 .clang-format       |    1 
 include/linux/msi.h |    6 --
 kernel/irq/msi.c    |  129 +++++++++++++++++++++++++++-------------------------
 3 files changed, 69 insertions(+), 67 deletions(-)

--- a/.clang-format
+++ b/.clang-format
@@ -216,7 +216,6 @@ ExperimentalAutoDetectBinPacking: false
   - 'for_each_migratetype_order'
   - 'for_each_msi_entry'
   - 'for_each_msi_entry_safe'
-  - 'for_each_msi_vector'
   - 'for_each_net'
   - 'for_each_net_continue_reverse'
   - 'for_each_netdev'
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -223,12 +223,6 @@ struct msi_desc *msi_next_desc(struct de
 	list_for_each_entry((desc), dev_to_msi_list((dev)), list)
 #define for_each_msi_entry_safe(desc, tmp, dev)	\
 	list_for_each_entry_safe((desc), (tmp), dev_to_msi_list((dev)), list)
-#define for_each_msi_vector(desc, __irq, dev)				\
-	for_each_msi_entry((desc), (dev))				\
-		if ((desc)->irq)					\
-			for (__irq = (desc)->irq;			\
-			     __irq < ((desc)->irq + (desc)->nvec_used);	\
-			     __irq++)
 
 #ifdef CONFIG_IRQ_MSI_IOMMU
 static inline const void *msi_desc_get_iommu_cookie(struct msi_desc *desc)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -856,23 +856,74 @@ static int msi_handle_pci_fail(struct ir
 	return allocated ? allocated : -ENOSPC;
 }
 
+#define VIRQ_CAN_RESERVE	0x01
+#define VIRQ_ACTIVATE		0x02
+#define VIRQ_NOMASK_QUIRK	0x04
+
+static int msi_init_virq(struct irq_domain *domain, int virq, unsigned int vflags)
+{
+	struct irq_data *irqd = irq_domain_get_irq_data(domain, virq);
+	int ret;
+
+	if (!(vflags & VIRQ_CAN_RESERVE)) {
+		irqd_clr_can_reserve(irqd);
+		if (vflags & VIRQ_NOMASK_QUIRK)
+			irqd_set_msi_nomask_quirk(irqd);
+	}
+
+	if (!(vflags & VIRQ_ACTIVATE))
+		return 0;
+
+	ret = irq_domain_activate_irq(irqd, vflags & VIRQ_CAN_RESERVE);
+	if (ret)
+		return ret;
+	/*
+	 * If the interrupt uses reservation mode, clear the activated bit
+	 * so request_irq() will assign the final vector.
+	 */
+	if (vflags & VIRQ_CAN_RESERVE)
+		irqd_clr_activated(irqd);
+	return 0;
+}
+
 int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
 			    int nvec)
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
-	struct irq_data *irq_data;
-	struct msi_desc *desc;
 	msi_alloc_info_t arg = { };
+	unsigned int vflags = 0;
+	struct msi_desc *desc;
 	int allocated = 0;
 	int i, ret, virq;
-	bool can_reserve;
 
 	ret = msi_domain_prepare_irqs(domain, dev, nvec, &arg);
 	if (ret)
 		return ret;
 
-	for_each_msi_entry(desc, dev) {
+	/*
+	 * This flag is set by the PCI layer as we need to activate
+	 * the MSI entries before the PCI layer enables MSI in the
+	 * card. Otherwise the card latches a random msi message.
+	 */
+	if (info->flags & MSI_FLAG_ACTIVATE_EARLY)
+		vflags |= VIRQ_ACTIVATE;
+
+	/*
+	 * Interrupt can use a reserved vector and will not occupy
+	 * a real device vector until the interrupt is requested.
+	 */
+	if (msi_check_reservation_mode(domain, info, dev)) {
+		vflags |= VIRQ_CAN_RESERVE;
+		/*
+		 * MSI affinity setting requires a special quirk (X86) when
+		 * reservation mode is active.
+		 */
+		if (domain->flags & IRQ_DOMAIN_MSI_NOMASK_QUIRK)
+			vflags |= VIRQ_NOMASK_QUIRK;
+	}
+
+	msi_for_each_desc(desc, dev, MSI_DESC_NOTASSOCIATED) {
 		ops->set_desc(&arg, desc);
 
 		virq = __irq_domain_alloc_irqs(domain, -1, desc->nvec_used,
@@ -884,49 +935,12 @@ int __msi_domain_alloc_irqs(struct irq_d
 		for (i = 0; i < desc->nvec_used; i++) {
 			irq_set_msi_desc_off(virq, i, desc);
 			irq_debugfs_copy_devname(virq + i, dev);
+			ret = msi_init_virq(domain, virq + i, vflags);
+			if (ret)
+				return ret;
 		}
 		allocated++;
 	}
-
-	can_reserve = msi_check_reservation_mode(domain, info, dev);
-
-	/*
-	 * This flag is set by the PCI layer as we need to activate
-	 * the MSI entries before the PCI layer enables MSI in the
-	 * card. Otherwise the card latches a random msi message.
-	 */
-	if (!(info->flags & MSI_FLAG_ACTIVATE_EARLY))
-		goto skip_activate;
-
-	for_each_msi_vector(desc, i, dev) {
-		if (desc->irq == i) {
-			virq = desc->irq;
-			dev_dbg(dev, "irq [%d-%d] for MSI\n",
-				virq, virq + desc->nvec_used - 1);
-		}
-
-		irq_data = irq_domain_get_irq_data(domain, i);
-		if (!can_reserve) {
-			irqd_clr_can_reserve(irq_data);
-			if (domain->flags & IRQ_DOMAIN_MSI_NOMASK_QUIRK)
-				irqd_set_msi_nomask_quirk(irq_data);
-		}
-		ret = irq_domain_activate_irq(irq_data, can_reserve);
-		if (ret)
-			return ret;
-	}
-
-skip_activate:
-	/*
-	 * If these interrupts use reservation mode, clear the activated bit
-	 * so request_irq() will assign the final vector.
-	 */
-	if (can_reserve) {
-		for_each_msi_vector(desc, i, dev) {
-			irq_data = irq_domain_get_irq_data(domain, i);
-			irqd_clr_activated(irq_data);
-		}
-	}
 	return 0;
 }
 
@@ -1004,26 +1018,21 @@ int msi_domain_alloc_irqs(struct irq_dom
 
 void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
 {
-	struct irq_data *irq_data;
+	struct irq_data *irqd;
 	struct msi_desc *desc;
 	int i;
 
-	for_each_msi_vector(desc, i, dev) {
-		irq_data = irq_domain_get_irq_data(domain, i);
-		if (irqd_is_activated(irq_data))
-			irq_domain_deactivate_irq(irq_data);
-	}
-
-	for_each_msi_entry(desc, dev) {
-		/*
-		 * We might have failed to allocate an MSI early
-		 * enough that there is no IRQ associated to this
-		 * entry. If that's the case, don't do anything.
-		 */
-		if (desc->irq) {
-			irq_domain_free_irqs(desc->irq, desc->nvec_used);
-			desc->irq = 0;
+	/* Only handle MSI entries which have an interrupt associated */
+	msi_for_each_desc(desc, dev, MSI_DESC_ASSOCIATED) {
+		/* Make sure all interrupts are deactivated */
+		for (i = 0; i < desc->nvec_used; i++) {
+			irqd = irq_domain_get_irq_data(domain, desc->irq + i);
+			if (irqd && irqd_is_activated(irqd))
+				irq_domain_deactivate_irq(irqd);
 		}
+
+		irq_domain_free_irqs(desc->irq, desc->nvec_used);
+		desc->irq = 0;
 	}
 }
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240313.416812 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzG-0008FU-Bc; Mon, 06 Dec 2021 23:01:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240313.416812; Mon, 06 Dec 2021 23:01:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzG-0008FL-8H; Mon, 06 Dec 2021 23:01:34 +0000
Received: by outflank-mailman (input) for mailman id 240313;
 Mon, 06 Dec 2021 23:01:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpg-0000Tb-Tg
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:41 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 133e5d72-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 133e5d72-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.847219474@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831100;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BUH8kO9WlotKw1Jm4iAVN62jvoEejpolEUEH0KsFyqY=;
	b=tkf6bcVZHT1vI5JwxsngLbDMdnn2lBna/IkgSEZ9qzd3LKYAdX5p3zvNKUebBGpCAM6CJx
	BbKf+B1Qk5UyIKOzpvq++GVC6W6rWHVd0BvjEVOtA/GJvzzu66VcQgk+kGe+ar7QZPe6t0
	/ww5Acp8h5i0qKoObgyWrNfQ08o3c2XWlUN4zltdcbyzTI9jfj1h9knJjj8mYFeNzno8W+
	OrSP+fB66SMGpTT1Y+4sLn8gpfJhkXq6fpNwI1zgA2WGZsdX1ibWLHtxfQAZNPGKhNrNy6
	xmWW8XjfZUQpp7yv/8hWXrYyZavzKNpUoFIYuiefEaNe9+P8ge2U69ebgZMuoA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831100;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BUH8kO9WlotKw1Jm4iAVN62jvoEejpolEUEH0KsFyqY=;
	b=V7ZDB1fDrNysdWEbulYRahYuzwoHAn9aIh3jtzGHZC23V577AVQihnfAkbh0fZTVDbvuIZ
	V36JM4tCqbvyYeAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 23/31] bus: fsl-mc-msi: Simplify MSI descriptor handling
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:39 +0100 (CET)

Let the MSI irq domain code handle descriptor allocation and free.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/bus/fsl-mc/fsl-mc-msi.c |   61 ++--------------------------------------
 1 file changed, 4 insertions(+), 57 deletions(-)

--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -170,6 +170,7 @@ struct irq_domain *fsl_mc_msi_create_irq
 		fsl_mc_msi_update_dom_ops(info);
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		fsl_mc_msi_update_chip_ops(info);
+	info->flags |= MSI_FLAG_ALLOC_SIMPLE_MSI_DESCS | MSI_FLAG_FREE_MSI_DESCS;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (domain)
@@ -210,45 +211,7 @@ struct irq_domain *fsl_mc_find_msi_domai
 	return msi_domain;
 }
 
-static void fsl_mc_msi_free_descs(struct device *dev)
-{
-	struct msi_desc *desc, *tmp;
-
-	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		list_del(&desc->list);
-		free_msi_entry(desc);
-	}
-}
-
-static int fsl_mc_msi_alloc_descs(struct device *dev, unsigned int irq_count)
-
-{
-	unsigned int i;
-	int error;
-	struct msi_desc *msi_desc;
-
-	for (i = 0; i < irq_count; i++) {
-		msi_desc = alloc_msi_entry(dev, 1, NULL);
-		if (!msi_desc) {
-			dev_err(dev, "Failed to allocate msi entry\n");
-			error = -ENOMEM;
-			goto cleanup_msi_descs;
-		}
-
-		msi_desc->msi_index = i;
-		INIT_LIST_HEAD(&msi_desc->list);
-		list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
-	}
-
-	return 0;
-
-cleanup_msi_descs:
-	fsl_mc_msi_free_descs(dev);
-	return error;
-}
-
-int fsl_mc_msi_domain_alloc_irqs(struct device *dev,
-				 unsigned int irq_count)
+int fsl_mc_msi_domain_alloc_irqs(struct device *dev,  unsigned int irq_count)
 {
 	struct irq_domain *msi_domain;
 	int error;
@@ -261,28 +224,17 @@ int fsl_mc_msi_domain_alloc_irqs(struct
 	if (error)
 		return error;
 
-	if (!list_empty(dev_to_msi_list(dev)))
+	if (msi_first_desc(dev, MSI_DESC_ALL))
 		return -EINVAL;
 
-	error = fsl_mc_msi_alloc_descs(dev, irq_count);
-	if (error < 0)
-		return error;
-
 	/*
 	 * NOTE: Calling this function will trigger the invocation of the
 	 * its_fsl_mc_msi_prepare() callback
 	 */
 	error = msi_domain_alloc_irqs(msi_domain, dev, irq_count);
 
-	if (error) {
+	if (error)
 		dev_err(dev, "Failed to allocate IRQs\n");
-		goto cleanup_msi_descs;
-	}
-
-	return 0;
-
-cleanup_msi_descs:
-	fsl_mc_msi_free_descs(dev);
 	return error;
 }
 
@@ -295,9 +247,4 @@ void fsl_mc_msi_domain_free_irqs(struct
 		return;
 
 	msi_domain_free_irqs(msi_domain, dev);
-
-	if (list_empty(dev_to_msi_list(dev)))
-		return;
-
-	fsl_mc_msi_free_descs(dev);
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240314.416822 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzH-00005D-KJ; Mon, 06 Dec 2021 23:01:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240314.416822; Mon, 06 Dec 2021 23:01:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzH-0008Vo-G4; Mon, 06 Dec 2021 23:01:35 +0000
Received: by outflank-mailman (input) for mailman id 240314;
 Mon, 06 Dec 2021 23:01:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpu-0008NM-VZ
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:55 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1ada4390-56e7-11ec-a5e1-b9374ead2679;
 Mon, 06 Dec 2021 23:51:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ada4390-56e7-11ec-a5e1-b9374ead2679
Message-ID: <20211206210749.280627070@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831112;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=MQ7ozWUaiArEmhCoyQn/2rQh7u+RDFLg8h0eBaFBoeM=;
	b=FqX6BU6Xy15N6yO4LSxbc3iOP7XCf2RIJ2CRdfOu6uS0PHmqzfPdLWPEtIbIzLJcixi2NL
	B1lgJmc6cvhd9FQ8awdw4jeTSZ6C34mhtT8In1y7VekoI41jhl48NcUi1TIy4EZ01CjmW7
	/1xCbfIrZkKNBO7t6p/9tuIktb1OGL2N98wb7wzAO8KZZ6KcpV0AwPEYGJ5JoFJFG8cLVB
	eRqZWLWZcMz5fUfvC8GY8XmeHMkfl8NiUixocbVsn3c4HtgCMNMifkHePz7eJd4RPYtClB
	Fj5G3pfg8dF7fC7W6XR5gQRSqOJlnrORs2e9qEDjLDcSlZH2jFJvf0n85A5EZA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831112;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=MQ7ozWUaiArEmhCoyQn/2rQh7u+RDFLg8h0eBaFBoeM=;
	b=l0xw52VdcKzS/pAv9jpd5Zux7erpTrz+FD2gAE/Rd/29hrVoaqt4Eqxop605j/5U68rrAw
	xmr2FK8Kqr8ewsCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 31/31] genirq/msi: Convert storage to xarray
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:52 +0100 (CET)

The current linked list storage for MSI descriptors is suboptimal in
several ways:

  1) Looking up a MSI desciptor requires a O(n) list walk in the worst case

  2) The upcoming support of runtime expansion of MSI-X vectors would need
     to do a full list walk to figure out whether a particular index is
     already associated.

  3) Runtime expansion of sparse allocations is even more complex as the
     current implementation assumes an ordered list (increasing MSI index).

Use an xarray which solves all of the above problems nicely.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 include/linux/msi.h |   13 +---
 kernel/irq/msi.c    |  169 +++++++++++++++++++++++-----------------------------
 2 files changed, 83 insertions(+), 99 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -17,6 +17,7 @@
  */
 
 #include <linux/cpumask.h>
+#include <linux/xarray.h>
 #include <linux/mutex.h>
 #include <linux/list.h>
 #include <linux/bits.h>
@@ -124,7 +125,6 @@ struct pci_msi_desc {
 
 /**
  * struct msi_desc - Descriptor structure for MSI based interrupts
- * @list:	List head for management
  * @irq:	The base interrupt number
  * @nvec_used:	The number of vectors used
  * @dev:	Pointer to the device which uses this descriptor
@@ -141,7 +141,6 @@ struct pci_msi_desc {
  */
 struct msi_desc {
 	/* Shared device/bus type independent data */
-	struct list_head		list;
 	unsigned int			irq;
 	unsigned int			nvec_used;
 	struct device			*dev;
@@ -177,16 +176,16 @@ enum msi_desc_filter {
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
  * @platform_data:	Platform-MSI specific data
- * @list:		List of MSI descriptors associated to the device
- * @mutex:		Mutex protecting the MSI list
- * @__next:		Cached pointer to the next entry for iterators
+ * @mutex:		Mutex protecting the MSI descriptor store
+ * @__store:		Xarray for storing MSI descriptor pointers
+ * @__iter_idx:		Index to search the next entry for iterators
  */
 struct msi_device_data {
 	unsigned long			properties;
 	struct platform_msi_priv_data	*platform_data;
-	struct list_head		list;
 	struct mutex			mutex;
-	struct msi_desc			*__next;
+	struct xarray			__store;
+	unsigned long			__iter_idx;
 };
 
 int msi_setup_device_data(struct device *dev);
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -20,7 +20,6 @@
 #include "internals.h"
 
 static inline int msi_sysfs_create_group(struct device *dev);
-#define dev_to_msi_list(dev)	(&(dev)->msi.data->list)
 
 /**
  * msi_alloc_desc - Allocate an initialized msi_desc
@@ -41,7 +40,6 @@ static struct msi_desc *msi_alloc_desc(s
 	if (!desc)
 		return NULL;
 
-	INIT_LIST_HEAD(&desc->list);
 	desc->dev = dev;
 	desc->nvec_used = nvec;
 	if (affinity) {
@@ -60,6 +58,17 @@ static void msi_free_desc(struct msi_des
 	kfree(desc);
 }
 
+static int msi_insert_desc(struct msi_device_data *md, struct msi_desc *desc, unsigned int index)
+{
+	int ret;
+
+	desc->msi_index = index;
+	ret = xa_insert(&md->__store, index, desc, GFP_KERNEL);
+	if (ret)
+		msi_free_desc(desc);
+	return ret;
+}
+
 /**
  * msi_add_msi_desc - Allocate and initialize a MSI descriptor
  * @dev:	Pointer to the device for which the descriptor is allocated
@@ -77,12 +86,9 @@ int msi_add_msi_desc(struct device *dev,
 	if (!desc)
 		return -ENOMEM;
 
-	/* Copy the MSI index and type specific data to the new descriptor. */
-	desc->msi_index = init_desc->msi_index;
+	/* Copy type specific data to the new descriptor. */
 	desc->pci = init_desc->pci;
-
-	list_add_tail(&desc->list, &dev->msi.data->list);
-	return 0;
+	return msi_insert_desc(dev->msi.data, desc, init_desc->msi_index);
 }
 
 /**
@@ -95,28 +101,41 @@ int msi_add_msi_desc(struct device *dev,
  */
 static int msi_add_simple_msi_descs(struct device *dev, unsigned int index, unsigned int ndesc)
 {
-	struct msi_desc *desc, *tmp;
-	LIST_HEAD(list);
-	unsigned int i;
+	unsigned int idx, last = index + ndesc - 1;
+	struct msi_desc *desc;
+	int ret;
 
 	lockdep_assert_held(&dev->msi.data->mutex);
 
-	for (i = 0; i < ndesc; i++) {
+	for (idx = index; idx <= last; idx++) {
 		desc = msi_alloc_desc(dev, 1, NULL);
 		if (!desc)
+			goto fail_mem;
+		ret = msi_insert_desc(dev->msi.data, desc, idx);
+		if (ret)
 			goto fail;
-		desc->msi_index = index + i;
-		list_add_tail(&desc->list, &list);
 	}
-	list_splice_tail(&list, &dev->msi.data->list);
 	return 0;
 
+fail_mem:
+	ret = -ENOMEM;
 fail:
-	list_for_each_entry_safe(desc, tmp, &list, list) {
-		list_del(&desc->list);
-		msi_free_desc(desc);
+	msi_free_msi_descs_range(dev, MSI_DESC_NOTASSOCIATED, index, last);
+	return ret;
+}
+
+static bool msi_desc_match(struct msi_desc *desc, enum msi_desc_filter filter)
+{
+	switch (filter) {
+	case MSI_DESC_ALL:
+		return true;
+	case MSI_DESC_NOTASSOCIATED:
+		return !desc->irq;
+	case MSI_DESC_ASSOCIATED:
+		return !!desc->irq;
 	}
-	return -ENOMEM;
+	WARN_ON_ONCE(1);
+	return false;
 }
 
 /**
@@ -141,19 +160,17 @@ void msi_device_set_properties(struct de
 void msi_free_msi_descs_range(struct device *dev, enum msi_desc_filter filter,
 			      unsigned int first_index, unsigned int last_index)
 {
+	struct xarray *xa = &dev->msi.data->__store;
 	struct msi_desc *desc;
+	unsigned long idx;
 
 	lockdep_assert_held(&dev->msi.data->mutex);
 
-	msi_for_each_desc(desc, dev, filter) {
-		/*
-		 * Stupid for now to handle MSI device domain until the
-		 * storage is switched over to an xarray.
-		 */
-		if (desc->msi_index < first_index || desc->msi_index > last_index)
-			continue;
-		list_del(&desc->list);
-		msi_free_desc(desc);
+	xa_for_each_range(xa, idx, desc, first_index, last_index) {
+		if (msi_desc_match(desc, filter)) {
+			xa_erase(xa, idx);
+			msi_free_desc(desc);
+		}
 	}
 }
 
@@ -186,7 +203,8 @@ static void msi_device_data_release(stru
 {
 	struct msi_device_data *md = res;
 
-	WARN_ON_ONCE(!list_empty(&md->list));
+	WARN_ON_ONCE(!xa_empty(&md->__store));
+	xa_destroy(&md->__store);
 	dev->msi.data = NULL;
 }
 
@@ -218,7 +236,7 @@ int msi_setup_device_data(struct device
 		return ret;
 	}
 
-	INIT_LIST_HEAD(&md->list);
+	xa_init(&md->__store);
 	mutex_init(&md->mutex);
 	dev->msi.data = md;
 	devres_add(dev, md);
@@ -245,34 +263,21 @@ void msi_unlock_descs(struct device *dev
 {
 	if (WARN_ON_ONCE(!dev->msi.data))
 		return;
-	/* Clear the next pointer which was cached by the iterator */
-	dev->msi.data->__next = NULL;
+	/* Invalidate the index wich was cached by the iterator */
+	dev->msi.data->__iter_idx = MSI_MAX_INDEX;
 	mutex_unlock(&dev->msi.data->mutex);
 }
 EXPORT_SYMBOL_GPL(msi_unlock_descs);
 
-static bool msi_desc_match(struct msi_desc *desc, enum msi_desc_filter filter)
-{
-	switch (filter) {
-	case MSI_DESC_ALL:
-		return true;
-	case MSI_DESC_NOTASSOCIATED:
-		return !desc->irq;
-	case MSI_DESC_ASSOCIATED:
-		return !!desc->irq;
-	}
-	WARN_ON_ONCE(1);
-	return false;
-}
-
-static struct msi_desc *msi_find_first_desc(struct device *dev, enum msi_desc_filter filter)
+static struct msi_desc *msi_find_desc(struct msi_device_data *md, enum msi_desc_filter filter)
 {
 	struct msi_desc *desc;
 
-	list_for_each_entry(desc, dev_to_msi_list(dev), list) {
+	xa_for_each_start(&md->__store, md->__iter_idx, desc, md->__iter_idx) {
 		if (msi_desc_match(desc, filter))
 			return desc;
 	}
+	md->__iter_idx = MSI_MAX_INDEX;
 	return NULL;
 }
 
@@ -289,37 +294,24 @@ static struct msi_desc *msi_find_first_d
  */
 struct msi_desc *msi_first_desc(struct device *dev, enum msi_desc_filter filter)
 {
-	struct msi_desc *desc;
+	struct msi_device_data *md = dev->msi.data;
 
-	if (WARN_ON_ONCE(!dev->msi.data))
+	if (WARN_ON_ONCE(!md))
 		return NULL;
 
-	lockdep_assert_held(&dev->msi.data->mutex);
+	lockdep_assert_held(&md->mutex);
 
-	desc = msi_find_first_desc(dev, filter);
-	dev->msi.data->__next = desc ? list_next_entry(desc, list) : NULL;
-	return desc;
+	md->__iter_idx = 0;
+	return msi_find_desc(md, filter);
 }
 EXPORT_SYMBOL_GPL(msi_first_desc);
 
-static struct msi_desc *__msi_next_desc(struct device *dev, enum msi_desc_filter filter,
-					struct msi_desc *from)
-{
-	struct msi_desc *desc = from;
-
-	list_for_each_entry_from(desc, dev_to_msi_list(dev), list) {
-		if (msi_desc_match(desc, filter))
-			return desc;
-	}
-	return NULL;
-}
-
 /**
  * msi_next_desc - Get the next MSI descriptor of a device
  * @dev:	Device to operate on
  *
  * The first invocation of msi_next_desc() has to be preceeded by a
- * successful incovation of __msi_first_desc(). Consecutive invocations are
+ * successful invocation of __msi_first_desc(). Consecutive invocations are
  * only valid if the previous one was successful. All these operations have
  * to be done within the same MSI mutex held region.
  *
@@ -328,20 +320,18 @@ static struct msi_desc *__msi_next_desc(
  */
 struct msi_desc *msi_next_desc(struct device *dev, enum msi_desc_filter filter)
 {
-	struct msi_device_data *data = dev->msi.data;
-	struct msi_desc *desc;
+	struct msi_device_data *md = dev->msi.data;
 
-	if (WARN_ON_ONCE(!data))
+	if (WARN_ON_ONCE(!md))
 		return NULL;
 
-	lockdep_assert_held(&data->mutex);
+	lockdep_assert_held(&md->mutex);
 
-	if (!data->__next)
+	if (md->__iter_idx >= (unsigned long)MSI_MAX_INDEX)
 		return NULL;
 
-	desc = __msi_next_desc(dev, filter, data->__next);
-	dev->msi.data->__next = desc ? list_next_entry(desc, list) : NULL;
-	return desc;
+	md->__iter_idx++;
+	return msi_find_desc(md, filter);
 }
 EXPORT_SYMBOL_GPL(msi_next_desc);
 
@@ -364,21 +354,18 @@ unsigned int msi_get_virq(struct device
 	pcimsi = msi_device_has_property(dev, MSI_PROP_PCI_MSI);
 
 	msi_lock_descs(dev);
-	msi_for_each_desc(desc, dev, MSI_DESC_ASSOCIATED) {
-		/* PCI-MSI has only one descriptor for multiple interrupts. */
-		if (pcimsi) {
-			if (index < desc->nvec_used)
-				ret = desc->irq + index;
-			break;
-		}
-
+	desc = xa_load(&dev->msi.data->__store, pcimsi ? 0 : index);
+	if (desc && desc->irq) {
 		/*
+		 * PCI-MSI has only one descriptor for multiple interrupts.
 		 * PCI-MSIX and platform MSI use a descriptor per
 		 * interrupt.
 		 */
-		if (desc->msi_index == index) {
+		if (pcimsi) {
+			if (index < desc->nvec_used)
+				ret = desc->irq + index;
+		} else {
 			ret = desc->irq;
-			break;
 		}
 	}
 	msi_unlock_descs(dev);
@@ -759,16 +746,13 @@ int msi_domain_populate_irqs(struct irq_
 	int ret, virq;
 
 	msi_lock_descs(dev);
-	for (virq = virq_base; virq < virq_base + nvec; virq++) {
-		desc = msi_alloc_desc(dev, 1, NULL);
-		if (!desc) {
-			ret = -ENOMEM;
-			goto fail;
-		}
+	ret = msi_add_simple_msi_descs(dev, virq_base, nvec);
+	if (ret)
+		goto unlock;
 
-		desc->msi_index = virq;
+	for (virq = virq_base; virq < virq_base + nvec; virq++) {
+		desc = xa_load(&dev->msi.data->__store, virq);
 		desc->irq = virq;
-		list_add_tail(&desc->list, &dev->msi.data->list);
 
 		ops->set_desc(arg, desc);
 		ret = irq_domain_alloc_irqs_hierarchy(domain, virq, 1, arg);
@@ -784,6 +768,7 @@ int msi_domain_populate_irqs(struct irq_
 	for (--virq; virq >= virq_base; virq--)
 		irq_domain_free_irqs_common(domain, virq, 1);
 	msi_free_msi_descs_range(dev, MSI_DESC_ALL, virq_base, virq_base + nvec - 1);
+unlock:
 	msi_unlock_descs(dev);
 	return ret;
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240328.416834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzU-00010O-TL; Mon, 06 Dec 2021 23:01:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240328.416834; Mon, 06 Dec 2021 23:01:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzU-00010H-Pm; Mon, 06 Dec 2021 23:01:48 +0000
Received: by outflank-mailman (input) for mailman id 240328;
 Mon, 06 Dec 2021 23:01:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpn-0000Tb-71
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:47 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 17075511-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17075511-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210749.063705667@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831106;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9e4EOcKKPduqUhpCF4p+2UUYlWyoniP7lkjFDtpqz3Y=;
	b=Y3Zk3CvhlchISCdf8dHPj4poyVu0qDQ568VEyVaToZAlNEqQi/S1x3gDaMvyVdtKEPlDeK
	gom1c1hZJ0+1FVRsN8FfMivDuckiCDX0hSqJocL2HBHr+t7Yk7CLCWJG34R78+WM0bTybW
	EOCNKInDl7y7WUoj3SW3ApdxCAnHdCzZtMeho1tEAjRiAo+SxRcaihs82O+dYDY7PO3p/+
	XCkyrbnh37tVACqnHEPr1obQxu1CsvWACFBW84i4AJhSO3ZQXkpsI2o/SwVyuSRwP7Bw+h
	6TRWEy6ZzgFoXF8vRrbJTv5ELeNAEME6EyTykOq4Aqm8xgRDNtUCA+FwM1sxvA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831106;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9e4EOcKKPduqUhpCF4p+2UUYlWyoniP7lkjFDtpqz3Y=;
	b=AjrNQMXU7lGzUGrbWNCpXMglJn8ZwBKEcm1/D7OSmkwL48kKIquDrjBmMavN5yx36Y6jdl
	/30zlBFMrb57wTDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 27/31] genirq/msi: Convert to new functions
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:45 +0100 (CET)

Use the new iterator functions and add locking where required.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/irq/msi.c |   23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -348,6 +348,7 @@ EXPORT_SYMBOL_GPL(msi_next_desc);
 unsigned int msi_get_virq(struct device *dev, unsigned int index)
 {
 	struct msi_desc *desc;
+	unsigned int ret = 0;
 	bool pcimsi;
 
 	if (!dev->msi.data)
@@ -355,11 +356,12 @@ unsigned int msi_get_virq(struct device
 
 	pcimsi = msi_device_has_property(dev, MSI_PROP_PCI_MSI);
 
-	for_each_msi_entry(desc, dev) {
+	msi_lock_descs(dev);
+	msi_for_each_desc(desc, dev, MSI_DESC_ASSOCIATED) {
 		/* PCI-MSI has only one descriptor for multiple interrupts. */
 		if (pcimsi) {
-			if (desc->irq && index < desc->nvec_used)
-				return desc->irq + index;
+			if (index < desc->nvec_used)
+				ret = desc->irq + index;
 			break;
 		}
 
@@ -367,10 +369,13 @@ unsigned int msi_get_virq(struct device
 		 * PCI-MSIX and platform MSI use a descriptor per
 		 * interrupt.
 		 */
-		if (desc->msi_index == index)
-			return desc->irq;
+		if (desc->msi_index == index) {
+			ret = desc->irq;
+			break;
+		}
 	}
-	return 0;
+	msi_unlock_descs(dev);
+	return ret;
 }
 EXPORT_SYMBOL_GPL(msi_get_virq);
 
@@ -401,7 +406,7 @@ static const struct attribute_group **ms
 	int i;
 
 	/* Determine how many msi entries we have */
-	for_each_msi_entry(entry, dev)
+	msi_for_each_desc(entry, dev, MSI_DESC_ALL)
 		num_msi += entry->nvec_used;
 	if (!num_msi)
 		return NULL;
@@ -411,7 +416,7 @@ static const struct attribute_group **ms
 	if (!msi_attrs)
 		return ERR_PTR(-ENOMEM);
 
-	for_each_msi_entry(entry, dev) {
+	msi_for_each_desc(entry, dev, MSI_DESC_ALL) {
 		for (i = 0; i < entry->nvec_used; i++) {
 			msi_dev_attr = kzalloc(sizeof(*msi_dev_attr), GFP_KERNEL);
 			if (!msi_dev_attr)
@@ -831,7 +836,7 @@ static bool msi_check_reservation_mode(s
 	 * Checking the first MSI descriptor is sufficient. MSIX supports
 	 * masking and MSI does so when the can_mask attribute is set.
 	 */
-	desc = first_msi_entry(dev);
+	desc = msi_first_desc(dev, MSI_DESC_ALL);
 	return desc->pci.msi_attrib.is_msix || desc->pci.msi_attrib.can_mask;
 }
 



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240329.416838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzV-00013V-8t; Mon, 06 Dec 2021 23:01:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240329.416838; Mon, 06 Dec 2021 23:01:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzV-00012b-2P; Mon, 06 Dec 2021 23:01:49 +0000
Received: by outflank-mailman (input) for mailman id 240329;
 Mon, 06 Dec 2021 23:01:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpV-0000Tb-MH
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:29 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c94c268-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c94c268-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.468512783@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831088;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rqnSsBxgLRUZrf8NprfQGM3zrSARm5hvHEZd8TZTvDo=;
	b=h9HO3s1ktar1QeAbr3otNX0rmxAlcW1iQ88vyJogrIMq41wqZRiE89OLLV+PN6bEroFkHj
	H3ATEdX2zJOFD1nguj09YCLx3R6eZsFH5kdhDX8CpEUlVbN9Ph5FEjF84eTddzqBWNFBR5
	ypH18/7SUa5inaLDA+TTnwmgnQfHDjztdKXryvbI22vPIMfBpBKXAC2LJkU/1W00LDagBQ
	dYuRA0G0MDWP3yUTLdCMVCgSG6GaLDPglC9ZXiTbk+0m9+uvHXPqeyGyRSSfgslep8BueY
	WhdIKyOSOg2ZGorzCHLkcATlyXF92ldijDDv8FlXniMtkwUmZ5qTeqenZ/2niA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831088;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rqnSsBxgLRUZrf8NprfQGM3zrSARm5hvHEZd8TZTvDo=;
	b=w5AdxxaOLU0xPGWEInq++C8OVVfck3vvMYuz0+9mwGNrvA/PCygz8XkOrssgo6p/9Q5c7a
	lsWj5BB4Ewc5fsCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 16/31] powerpc/pasemi/msi: Convert to msi_on_each_dec()
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:28 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/powerpc/platforms/pasemi/msi.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

--- a/arch/powerpc/platforms/pasemi/msi.c
+++ b/arch/powerpc/platforms/pasemi/msi.c
@@ -62,17 +62,12 @@ static void pasemi_msi_teardown_msi_irqs
 
 	pr_debug("pasemi_msi_teardown_msi_irqs, pdev %p\n", pdev);
 
-	for_each_pci_msi_entry(entry, pdev) {
-		if (!entry->irq)
-			continue;
-
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) {
 		hwirq = virq_to_hw(entry->irq);
 		irq_set_msi_desc(entry->irq, NULL);
 		irq_dispose_mapping(entry->irq);
 		msi_bitmap_free_hwirqs(&msi_mpic->msi_bitmap, hwirq, ALLOC_CHUNK);
 	}
-
-	return;
 }
 
 static int pasemi_msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
@@ -90,7 +85,7 @@ static int pasemi_msi_setup_msi_irqs(str
 	msg.address_hi = 0;
 	msg.address_lo = PASEMI_MSI_ADDR;
 
-	for_each_pci_msi_entry(entry, pdev) {
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
 		/* Allocate 16 interrupts for now, since that's the grouping for
 		 * affinity. This can be changed later if it turns out 32 is too
 		 * few MSIs for someone, but restrictions will apply to how the



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240332.416856 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzc-0001yU-OK; Mon, 06 Dec 2021 23:01:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240332.416856; Mon, 06 Dec 2021 23:01:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzc-0001yH-JD; Mon, 06 Dec 2021 23:01:56 +0000
Received: by outflank-mailman (input) for mailman id 240332;
 Mon, 06 Dec 2021 23:01:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMpa-0000Tb-Gz
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:34 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0f7f24eb-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f7f24eb-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210748.629363944@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831093;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=D1PGUTvbMCo12qSm9MpHyC/iszyAeQMlmvbSI9Ov2K8=;
	b=OIuHnFM2jS5ZUe0SyHLHgoh56x995XYR7j7ckxnVHFyMq9YVqLx5a9t7R6BqvGJcZcaO6A
	uDkqvUWmDaLXd5df6DKsGENAsUyR9ns6fPpuB3ewT3eYa6CrvPrMvDjNEQetMWdTgP/4km
	TWJsQGFfTSzyN7kIlObignVRrFXjnRUJcQgs+Gp48BMuLTRV2/edRl2VQg13M0dm0HM0ck
	aA0lQ0BWUcz5u7bD+L6FTh92yeoQG10Ikohf3DfD4kI9VWyyy8rbo+qlz2532D+CBH+355
	/96REP7yWk9EN3WBUxEFYoZEjOoFU3ommstHPOr2HUa2E6F5WjZrHbH9jMwuJw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831093;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=D1PGUTvbMCo12qSm9MpHyC/iszyAeQMlmvbSI9Ov2K8=;
	b=mgYtC98T/bzauSx1TiQZDDuYDNriANJt280pKOzYM/g3ZDfwqajvvSIJS8vq+F48uSDuHu
	cCCQUpVJ/vC2mkDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 19/31] PCI: hv: Rework MSI handling
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:33 +0100 (CET)

Replace the about to vanish iterators and make use of the filtering. Take
the descriptor lock around the iterators.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/controller/pci-hyperv.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -3445,18 +3445,23 @@ static int hv_pci_suspend(struct hv_devi
 
 static int hv_pci_restore_msi_msg(struct pci_dev *pdev, void *arg)
 {
-	struct msi_desc *entry;
 	struct irq_data *irq_data;
+	struct msi_desc *entry;
+	int ret = 0;
 
-	for_each_pci_msi_entry(entry, pdev) {
+	msi_lock_descs(&pdev->dev);
+	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) {
 		irq_data = irq_get_irq_data(entry->irq);
-		if (WARN_ON_ONCE(!irq_data))
-			return -EINVAL;
+		if (WARN_ON_ONCE(!irq_data)) {
+			ret = -EINVAL;
+			break;
+		}
 
 		hv_compose_msi_msg(irq_data, &entry->msg);
 	}
+	msi_unlock_descs(&pdev->dev);
 
-	return 0;
+	return ret;
 }
 
 /*



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:01:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:01:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240336.416867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMzf-0002Lw-1L; Mon, 06 Dec 2021 23:01:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240336.416867; Mon, 06 Dec 2021 23:01:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muMze-0002Lk-TV; Mon, 06 Dec 2021 23:01:58 +0000
Received: by outflank-mailman (input) for mailman id 240336;
 Mon, 06 Dec 2021 23:01:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5qlu=QX=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muMps-0000Tb-B8
 for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 22:51:52 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19ddd904-56e7-11ec-8a4d-196798b21f7b;
 Mon, 06 Dec 2021 23:51:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19ddd904-56e7-11ec-8a4d-196798b21f7b
Message-ID: <20211206210749.224917330@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638831111;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=21WP0HmWXZNG6C0xaMrdmPLK4zT+1q4zI1Oc6dWMW6M=;
	b=e4ohXDN8N3EbP+sROJ9Vc7PD/uaHcghbISezOJ56XaxTiurZIxJTlRHJJkP3swh6sSnDXs
	e7IXRkELCmBqfKF+BOHcCFMQ5IrZuzjToW3xE1Bm4OnYb6N2jSvLQK578eTHhV9LgsOWMm
	eAge6jql/Gi910inDARZYlIaaLy6gdLldduqaU8SnE0JJQb6JDpnW4qZgPvqb4oQOZl1eR
	WYcSU3BL87ixyGnOP+EIsPpctR8dDI1ILzXhZU/OcI3YfCieFqazL6RKk+kHylxS5kSo0s
	GpDqDp3yQezbN2pTs/fbVZXZd39KPh9SIwsUaGtr9PxRNlD//hhSRWnc+WvwgQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638831111;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=21WP0HmWXZNG6C0xaMrdmPLK4zT+1q4zI1Oc6dWMW6M=;
	b=DR0QJ0cMvP6X9yWSUQVTSHjnTfMPJHHtdGpnte6lBofbmRbMre4ig5B947piM8An5fcNhc
	m+ozvwWqr04jKfCQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org,
 Juergen Gross <jgross@suse.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org,
 Heiko Carstens <hca@linux.ibm.com>,
 Christian Borntraeger <borntraeger@de.ibm.com>,
 Logan Gunthorpe <logang@deltatee.com>,
 Jon Mason <jdmason@kudzu.us>,
 Dave Jiang <dave.jiang@intel.com>,
 Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: [patch V2 30/31] genirq/msi: Simplify sysfs handling
References: <20211206210600.123171746@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Mon,  6 Dec 2021 23:51:50 +0100 (CET)

The sysfs handling for MSI is a convoluted maze and it is in the way of
supporting dynamic expansion of the MSI-X vectors because it only supports
a one off bulk population/free of the sysfs entries.

Change it to do:

   1) Creating an empty sysfs attribute group when msi_device_data is
      allocated

   2) Populate the entries when the MSI descriptor is initialized

   3) Free the entries when a MSI descriptor is detached from a Linux
      interrupt.

   4) Provide functions for the legacy non-irqdomain fallback code to
      do a bulk population/free. This code won't support dynamic
      expansion.

This makes the code simpler and reduces the number of allocations as the
empty attribute group can be shared.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 include/linux/msi.h |    8 +-
 kernel/irq/msi.c    |  196 +++++++++++++++++++++++-----------------------------
 2 files changed, 95 insertions(+), 109 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -72,7 +72,7 @@ struct irq_data;
 struct msi_desc;
 struct pci_dev;
 struct platform_msi_priv_data;
-struct attribute_group;
+struct device_attribute;
 
 void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 #ifdef CONFIG_GENERIC_MSI_IRQ
@@ -130,6 +130,7 @@ struct pci_msi_desc {
  * @dev:	Pointer to the device which uses this descriptor
  * @msg:	The last set MSI message cached for reuse
  * @affinity:	Optional pointer to a cpu affinity mask for this descriptor
+ * @sysfs_attr:	Pointer to sysfs device attribute
  *
  * @write_msi_msg:	Callback that may be called when the MSI message
  *			address or data changes
@@ -149,6 +150,9 @@ struct msi_desc {
 #ifdef CONFIG_IRQ_MSI_IOMMU
 	const void			*iommu_cookie;
 #endif
+#ifdef CONFIG_SYSFS
+	struct device_attribute		*sysfs_attrs;
+#endif
 
 	void (*write_msi_msg)(struct msi_desc *entry, void *data);
 	void *write_msi_msg_data;
@@ -172,7 +176,6 @@ enum msi_desc_filter {
 /**
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
- * @attrs:		Pointer to the sysfs attribute group
  * @platform_data:	Platform-MSI specific data
  * @list:		List of MSI descriptors associated to the device
  * @mutex:		Mutex protecting the MSI list
@@ -180,7 +183,6 @@ enum msi_desc_filter {
  */
 struct msi_device_data {
 	unsigned long			properties;
-	const struct attribute_group    **attrs;
 	struct platform_msi_priv_data	*platform_data;
 	struct list_head		list;
 	struct mutex			mutex;
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -19,6 +19,7 @@
 
 #include "internals.h"
 
+static inline int msi_sysfs_create_group(struct device *dev);
 #define dev_to_msi_list(dev)	(&(dev)->msi.data->list)
 
 /**
@@ -202,6 +203,7 @@ static void msi_device_data_release(stru
 int msi_setup_device_data(struct device *dev)
 {
 	struct msi_device_data *md;
+	int ret;
 
 	if (dev->msi.data)
 		return 0;
@@ -210,6 +212,12 @@ int msi_setup_device_data(struct device
 	if (!md)
 		return -ENOMEM;
 
+	ret = msi_sysfs_create_group(dev);
+	if (ret) {
+		devres_free(md);
+		return ret;
+	}
+
 	INIT_LIST_HEAD(&md->list);
 	mutex_init(&md->mutex);
 	dev->msi.data = md;
@@ -379,6 +387,20 @@ unsigned int msi_get_virq(struct device
 EXPORT_SYMBOL_GPL(msi_get_virq);
 
 #ifdef CONFIG_SYSFS
+static struct attribute *msi_dev_attrs[] = {
+	NULL
+};
+
+static const struct attribute_group msi_irqs_group = {
+	.name	= "msi_irqs",
+	.attrs	= msi_dev_attrs,
+};
+
+static inline int msi_sysfs_create_group(struct device *dev)
+{
+	return devm_device_add_group(dev, &msi_irqs_group);
+}
+
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)
 {
@@ -388,97 +410,74 @@ static ssize_t msi_mode_show(struct devi
 	return sysfs_emit(buf, "%s\n", is_msix ? "msix" : "msi");
 }
 
-/**
- * msi_populate_sysfs - Populate msi_irqs sysfs entries for devices
- * @dev:	The device(PCI, platform etc) who will get sysfs entries
- */
-static const struct attribute_group **msi_populate_sysfs(struct device *dev)
+static void msi_sysfs_remove_desc(struct device *dev, struct msi_desc *desc)
 {
-	const struct attribute_group **msi_irq_groups;
-	struct attribute **msi_attrs, *msi_attr;
-	struct device_attribute *msi_dev_attr;
-	struct attribute_group *msi_irq_group;
-	struct msi_desc *entry;
-	int ret = -ENOMEM;
-	int num_msi = 0;
-	int count = 0;
+	struct device_attribute *attrs = desc->sysfs_attrs;
 	int i;
 
-	/* Determine how many msi entries we have */
-	msi_for_each_desc(entry, dev, MSI_DESC_ALL)
-		num_msi += entry->nvec_used;
-	if (!num_msi)
-		return NULL;
+	if (!attrs)
+		return;
 
-	/* Dynamically create the MSI attributes for the device */
-	msi_attrs = kcalloc(num_msi + 1, sizeof(void *), GFP_KERNEL);
-	if (!msi_attrs)
-		return ERR_PTR(-ENOMEM);
-
-	msi_for_each_desc(entry, dev, MSI_DESC_ALL) {
-		for (i = 0; i < entry->nvec_used; i++) {
-			msi_dev_attr = kzalloc(sizeof(*msi_dev_attr), GFP_KERNEL);
-			if (!msi_dev_attr)
-				goto error_attrs;
-			msi_attrs[count] = &msi_dev_attr->attr;
-
-			sysfs_attr_init(&msi_dev_attr->attr);
-			msi_dev_attr->attr.name = kasprintf(GFP_KERNEL, "%d",
-							    entry->irq + i);
-			if (!msi_dev_attr->attr.name)
-				goto error_attrs;
-			msi_dev_attr->attr.mode = 0444;
-			msi_dev_attr->show = msi_mode_show;
-			++count;
-		}
+	desc->sysfs_attrs = NULL;
+	for (i = 0; i < desc->nvec_used; i++) {
+		if (attrs[i].show)
+			sysfs_remove_file_from_group(&dev->kobj, &attrs[i].attr, msi_irqs_group.name);
+		kfree(attrs[i].attr.name);
 	}
+	kfree(attrs);
+}
 
-	msi_irq_group = kzalloc(sizeof(*msi_irq_group), GFP_KERNEL);
-	if (!msi_irq_group)
-		goto error_attrs;
-	msi_irq_group->name = "msi_irqs";
-	msi_irq_group->attrs = msi_attrs;
-
-	msi_irq_groups = kcalloc(2, sizeof(void *), GFP_KERNEL);
-	if (!msi_irq_groups)
-		goto error_irq_group;
-	msi_irq_groups[0] = msi_irq_group;
+static int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc)
+{
+	struct device_attribute *attrs;
+	int ret, i;
 
-	ret = sysfs_create_groups(&dev->kobj, msi_irq_groups);
-	if (ret)
-		goto error_irq_groups;
+	attrs = kcalloc(desc->nvec_used, sizeof(*attrs), GFP_KERNEL);
+	if (!attrs)
+		return -ENOMEM;
+
+	desc->sysfs_attrs = attrs;
+	for (i = 0; i < desc->nvec_used; i++) {
+		sysfs_attr_init(&attrs[i].attr);
+		attrs[i].attr.name = kasprintf(GFP_KERNEL, "%d", desc->irq + i);
+		if (!attrs[i].attr.name) {
+			ret = -ENOMEM;
+			goto fail;
+		}
 
-	return msi_irq_groups;
+		attrs[i].attr.mode = 0444;
+		attrs[i].show = msi_mode_show;
 
-error_irq_groups:
-	kfree(msi_irq_groups);
-error_irq_group:
-	kfree(msi_irq_group);
-error_attrs:
-	count = 0;
-	msi_attr = msi_attrs[count];
-	while (msi_attr) {
-		msi_dev_attr = container_of(msi_attr, struct device_attribute, attr);
-		kfree(msi_attr->name);
-		kfree(msi_dev_attr);
-		++count;
-		msi_attr = msi_attrs[count];
+		ret = sysfs_add_file_to_group(&dev->kobj, &attrs[i].attr, msi_irqs_group.name);
+		if (ret) {
+			attrs[i].show = NULL;
+			goto fail;
+		}
 	}
-	kfree(msi_attrs);
-	return ERR_PTR(ret);
+	return 0;
+
+fail:
+	msi_sysfs_remove_desc(dev, desc);
+	return ret;
 }
 
+#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
 /**
  * msi_device_populate_sysfs - Populate msi_irqs sysfs entries for a device
  * @dev:	The device (PCI, platform etc) which will get sysfs entries
  */
 int msi_device_populate_sysfs(struct device *dev)
 {
-	const struct attribute_group **group = msi_populate_sysfs(dev);
+	struct msi_desc *desc;
+	int ret;
 
-	if (IS_ERR(group))
-		return PTR_ERR(group);
-	dev->msi.data->attrs = group;
+	msi_for_each_desc(desc, dev, MSI_DESC_ASSOCIATED) {
+		if (desc->sysfs_attrs)
+			continue;
+		ret = msi_sysfs_populate_desc(dev, desc);
+		if (ret)
+			return ret;
+	}
 	return 0;
 }
 
@@ -489,28 +488,17 @@ int msi_device_populate_sysfs(struct dev
  */
 void msi_device_destroy_sysfs(struct device *dev)
 {
-	const struct attribute_group **msi_irq_groups = dev->msi.data->attrs;
-	struct device_attribute *dev_attr;
-	struct attribute **msi_attrs;
-	int count = 0;
-
-	dev->msi.data->attrs = NULL;
-	if (!msi_irq_groups)
-		return;
+	struct msi_desc *desc;
 
-	sysfs_remove_groups(&dev->kobj, msi_irq_groups);
-	msi_attrs = msi_irq_groups[0]->attrs;
-	while (msi_attrs[count]) {
-		dev_attr = container_of(msi_attrs[count], struct device_attribute, attr);
-		kfree(dev_attr->attr.name);
-		kfree(dev_attr);
-		++count;
-	}
-	kfree(msi_attrs);
-	kfree(msi_irq_groups[0]);
-	kfree(msi_irq_groups);
+	msi_for_each_desc(desc, dev, MSI_DESC_ALL)
+		msi_sysfs_remove_desc(dev, desc);
 }
-#endif
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACK */
+#else /* CONFIG_SYSFS */
+static inline int msi_sysfs_create_group(struct device *dev) { return 0; }
+static inline int msi_sysfs_populate_desc(struct device *dev, struct msi_desc *desc) { return 0; }
+static inline void msi_sysfs_remove_desc(struct device *dev, struct msi_desc *desc) { }
+#endif /* !CONFIG_SYSFS */
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 static inline void irq_chip_write_msi_msg(struct irq_data *data,
@@ -942,6 +930,12 @@ int __msi_domain_alloc_irqs(struct irq_d
 			ret = msi_init_virq(domain, virq + i, vflags);
 			if (ret)
 				return ret;
+
+			if (info->flags & MSI_FLAG_DEV_SYSFS) {
+				ret = msi_sysfs_populate_desc(dev, desc);
+				if (ret)
+					return ret;
+			}
 		}
 		allocated++;
 	}
@@ -986,18 +980,7 @@ int msi_domain_alloc_irqs_descs_locked(s
 
 	ret = ops->domain_alloc_irqs(domain, dev, nvec);
 	if (ret)
-		goto cleanup;
-
-	if (!(info->flags & MSI_FLAG_DEV_SYSFS))
-		return 0;
-
-	ret = msi_device_populate_sysfs(dev);
-	if (ret)
-		goto cleanup;
-	return 0;
-
-cleanup:
-	msi_domain_free_irqs_descs_locked(domain, dev);
+		msi_domain_free_irqs_descs_locked(domain, dev);
 	return ret;
 }
 
@@ -1022,6 +1005,7 @@ int msi_domain_alloc_irqs(struct irq_dom
 
 void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
 {
+	struct msi_domain_info *info = domain->host_data;
 	struct irq_data *irqd;
 	struct msi_desc *desc;
 	int i;
@@ -1036,6 +1020,8 @@ void __msi_domain_free_irqs(struct irq_d
 		}
 
 		irq_domain_free_irqs(desc->irq, desc->nvec_used);
+		if (info->flags & MSI_FLAG_DEV_SYSFS)
+			msi_sysfs_remove_desc(dev, desc);
 		desc->irq = 0;
 	}
 }
@@ -1064,8 +1050,6 @@ void msi_domain_free_irqs_descs_locked(s
 
 	lockdep_assert_held(&dev->msi.data->mutex);
 
-	if (info->flags & MSI_FLAG_DEV_SYSFS)
-		msi_device_destroy_sysfs(dev);
 	ops->domain_free_irqs(domain, dev);
 	msi_domain_free_msi_descs(info, dev);
 }



From xen-devel-bounces@lists.xenproject.org Mon Dec 06 23:23:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 06 Dec 2021 23:23:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240391.416881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muNK5-0007f4-TX; Mon, 06 Dec 2021 23:23:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240391.416881; Mon, 06 Dec 2021 23:23:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muNK5-0007ex-QT; Mon, 06 Dec 2021 23:23:05 +0000
Received: by outflank-mailman (input) for mailman id 240391;
 Mon, 06 Dec 2021 23:23:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muNK4-0007en-JV; Mon, 06 Dec 2021 23:23:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muNK4-0001DI-Ee; Mon, 06 Dec 2021 23:23:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muNK4-0003RV-7W; Mon, 06 Dec 2021 23:23:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muNK4-0001fy-5E; Mon, 06 Dec 2021 23:23:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tsB0MWFc3neQnKCDgCqGaXbyZUZCXr+uQ46ENV6sGCU=; b=h2cuQhVUxbwsKFiR5eNG70jvyd
	0XfH1nPYuF4Rgp1MHvUNp/F9PRPhDLP3k4/gxAoDS4yW50q+JfHN+hINkjj3nZJWdHbzgjRSdkduP
	eyAwOHjk104JWohuvo/gW+VOh79ZyWQHgPxYqKiK+wbeI2p8ckFF8ntwrQDeHn4zTL+A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167220-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167220: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
X-Osstest-Versions-That:
    xen=f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 06 Dec 2021 23:23:04 +0000

flight 167220 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167220/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1
baseline version:
 xen                  f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb

Last test of basis   167213  2021-12-06 14:01:38 Z    0 days
Testing same since   167220  2021-12-06 19:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <ian.jackson@citrix.com>
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f0abfb5eca..608531a0cc  608531a0cc34a5bc096ccf585e16f182b5ed83e1 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 01:17:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 01:17:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240419.416896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muP6d-00026i-Tb; Tue, 07 Dec 2021 01:17:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240419.416896; Tue, 07 Dec 2021 01:17:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muP6d-00026b-QX; Tue, 07 Dec 2021 01:17:19 +0000
Received: by outflank-mailman (input) for mailman id 240419;
 Tue, 07 Dec 2021 01:17:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muP6c-00025m-6q; Tue, 07 Dec 2021 01:17:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muP6b-0005L4-Sb; Tue, 07 Dec 2021 01:17:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muP6b-0001oU-K5; Tue, 07 Dec 2021 01:17:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muP6b-0007gx-JE; Tue, 07 Dec 2021 01:17:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QvOgFqWxWxrcszJl32JpviX6t3JxAm/4+e3Lq8squOc=; b=oPHTuLUZynxhCiFoI7VQaOo8Lv
	GLf1EHgmUCtzePUP4bf33uSCbsGSiJd+ZdDWzokI+2w/X0m5wJ8wSqjvLpDfMHdOF+MkP/9t70yye
	wWgosn9QXBKkAa5jOGgejrrw7X0Fu21rbMWOtyM0nmlptId/APyx/Ydyj59vhG3oDD2U=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167210-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167210: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
X-Osstest-Versions-That:
    xen=e7f147bf4ac725492962a501da72f5ab6be682db
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 01:17:17 +0000

flight 167210 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167210/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167174 pass in 167210
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 167174 pass in 167210
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167174 pass in 167210
 test-amd64-i386-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 167174

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167174 like 167083
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail in 167174 like 167083
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167119
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167119
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167119
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167119
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167119
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167119
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167119
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167119
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167119
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167119
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167119
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167119
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01
baseline version:
 xen                  e7f147bf4ac725492962a501da72f5ab6be682db

Last test of basis   167119  2021-12-04 23:14:29 Z    2 days
Testing same since   167174  2021-12-06 00:02:29 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ayan Kumar Halder <ayan.kumar.halder@xilinx.com>
  Ayan Kumar Halder <ayankuma@xilinx.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>
  Roger Pau Monne <roger.pau@citrix.com>
  Roger Pau Monné <roger.pau@citrix.com>
  Stewart Hildebrand <stewart.hildebrand@dornerworks.com>
  Tim Deegan <tim@xen.org>
  Vikram Garhwal <fnu.vikram@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         fail    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   e7f147bf4a..ea0c08bc77  ea0c08bc77fe7bd7e4e65c648e17752e91912d01 -> master


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 03:36:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 03:36:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240509.417066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muRGp-0007Wm-Ug; Tue, 07 Dec 2021 03:35:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240509.417066; Tue, 07 Dec 2021 03:35:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muRGp-0007We-PJ; Tue, 07 Dec 2021 03:35:59 +0000
Received: by outflank-mailman (input) for mailman id 240509;
 Tue, 07 Dec 2021 03:35:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muRGo-0007WU-CD; Tue, 07 Dec 2021 03:35:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muRGo-00087S-3m; Tue, 07 Dec 2021 03:35:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muRGn-0004CA-Oc; Tue, 07 Dec 2021 03:35:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muRGn-0006sM-M1; Tue, 07 Dec 2021 03:35:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nDUMfx2nIFhXslHzn7pMwsRyLmGqYfGjGW7hSngEgdc=; b=LxehHm1gMhkI924RHyAi7/Zizg
	+r3aFr637YGvMrODVqU3xTCpHXPKGYlDnDPOPEdNPFyUgmnWrHL2aRZ+nNB2GMLKntyHiQToQqduZ
	ZdeKWs8i/sd08BhpECGgS7CRF1DjfagILqjdZ6wLxj4r47g3Eokkgaw6w2mBzsMKbO1A=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167214-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.12-testing test] 167214: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.12-testing:test-amd64-amd64-xl-qcow2:guest-localmigrate/x10:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.12-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=b9aa1635b38a7bc092d60123b87c545f25db31e4
X-Osstest-Versions-That:
    xen=1442eb9ac448ca43c58bd65dbd82dca0c412c143
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 03:35:57 +0000

flight 167214 xen-4.12-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167214/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qcow2    19 guest-localmigrate/x10       fail  like 166313
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166352
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166352
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166352
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166352
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166352
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166352
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166352
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166352
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166352
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166352
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166352
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166352
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  b9aa1635b38a7bc092d60123b87c545f25db31e4
baseline version:
 xen                  1442eb9ac448ca43c58bd65dbd82dca0c412c143

Last test of basis   166352  2021-11-24 11:21:03 Z   12 days
Testing same since   167214  2021-12-06 15:36:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <ian.jackson@eu.citrix.com>
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    fail    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1442eb9ac4..b9aa1635b3  b9aa1635b38a7bc092d60123b87c545f25db31e4 -> stable-4.12


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:10:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:10:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240534.417080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muUcW-0004lZ-Lm; Tue, 07 Dec 2021 07:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240534.417080; Tue, 07 Dec 2021 07:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muUcW-0004lS-IB; Tue, 07 Dec 2021 07:10:36 +0000
Received: by outflank-mailman (input) for mailman id 240534;
 Tue, 07 Dec 2021 07:10:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1gtX=QY=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muUcV-0004l3-7h
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:10:35 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id c3cecb23-572c-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:10:32 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D60511FB;
 Mon,  6 Dec 2021 23:10:31 -0800 (PST)
Received: from [10.57.4.134] (unknown [10.57.4.134])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 331553F5A1;
 Mon,  6 Dec 2021 23:10:30 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3cecb23-572c-11ec-a5e1-b9374ead2679
Subject: Re: [PATCH] xen/arm: Do not include in the image functions...
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206141923.26757-1-michal.orzel@arm.com>
 <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
 <e149b283-23bd-9d8f-4be4-4a26722f0ed6@arm.com>
 <65035935-935a-f8a9-a797-5d6a1bce4e66@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <abd3beeb-eccb-8c6e-0751-b881efc08d57@arm.com>
Date: Tue, 7 Dec 2021 08:10:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <65035935-935a-f8a9-a797-5d6a1bce4e66@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 06.12.2021 17:40, Julien Grall wrote:
> 
> 
> On 06/12/2021 15:00, Michal Orzel wrote:
>> Hi Julien,
> 
> Hi Michal,
> 
>> On 06.12.2021 15:39, Julien Grall wrote:
>>> Hi Michal,
>>>
>>> On 06/12/2021 14:19, Michal Orzel wrote:
>>>> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
>>>> CONFIG_NEW_VGIC is not set.
>>>>
>>>> enter_hypervisor_from_guest is protecting calls to these functions
>>>> with CONFIG_NEW_VGIC but their definitions and declarations are not > protected. This means that we are including them in the image even
>>>> though we are not making use of them. Fix that.
>>>
>>> While I agree, they are only used by the new vGIC, the implementation of the functions are not. So I don't think they should be protected by CONFIG_NEW_VGIC.
>>>
>>> Actually, I am not convinced they should be protected. But I guess you did that for a reason. Would you be able to clarify what is your reason?
>>>
>>  From what I know + what the commit introducing these fucntions states (b9db96f71a74), the current vGIC does not handle level-triggered vIRQs.
>> The functionality of these functions is only related to new VGIC implementation which can handle level triggered vIRQs.
> 
> This is a known error in the vGIC implementation which should be resolved before this leads to a disaster.

I just thought that if this error is present for such a long time, there are no plans to make current vgic handle level type irqs.
> 
>> So I do not think that these functions are generic and thus I believe they should be protected.
> 
> None of the functions rely on the internal of the new vGIC. In fact, as I wrote above, the current vGIC ought to be able to handle level-trigger interrupt properly.
> 
> They are not called for the current vGIC because there was concern about the performance impact on each trap (see [1]).
> 
> So I think those functions ought to stay compiled in for everyone.
> 
I'm totally ok with that.

> Cheers,
> 
> [1] https://lore.kernel.org/xen-devel/22601816-8235-7891-b634-4af5348a1337@arm.com/
> 
> 
> 
>>> Cheers,
>>>
>>
>> Cheers,
>> Michal
>>
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:21:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:21:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240540.417091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muUnF-0006il-LE; Tue, 07 Dec 2021 07:21:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240540.417091; Tue, 07 Dec 2021 07:21:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muUnF-0006ie-Hj; Tue, 07 Dec 2021 07:21:41 +0000
Received: by outflank-mailman (input) for mailman id 240540;
 Tue, 07 Dec 2021 07:21:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7Lsp=QY=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1muUnF-0006iV-3w
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:21:41 +0000
Received: from 6.mo548.mail-out.ovh.net (6.mo548.mail-out.ovh.net
 [188.165.58.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 51b35e73-572e-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:21:39 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.108.4.240])
 by mo548.mail-out.ovh.net (Postfix) with ESMTPS id C4A4B209B3;
 Tue,  7 Dec 2021 07:21:35 +0000 (UTC)
Received: from kaod.org (37.59.142.102) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec
 2021 08:21:34 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51b35e73-572e-11ec-a5e1-b9374ead2679
Authentication-Results: garm.ovh; auth=pass (GARM-102R004880801b5-1b74-45de-8484-6c3316d6c777,
                    EDCC1E77E28A65BD51DFCD2B92BF934EEA10E5FB) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 82.64.250.170
Message-ID: <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
Date: Tue, 7 Dec 2021 08:21:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never
 worked
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
	<ashok.raj@intel.com>, <linux-pci@vger.kernel.org>, Michael Ellerman
	<mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, <linuxppc-dev@lists.ozlabs.org>,
	Juergen Gross <jgross@suse.com>, Thomas Bogendoerfer
	<tsbogend@alpha.franken.de>, <linux-mips@vger.kernel.org>, Kalle Valo
	<kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<sparclinux@vger.kernel.org>, <x86@kernel.org>,
	<xen-devel@lists.xenproject.org>, <ath11k@lists.infradead.org>, Wei Liu
	<wei.liu@kernel.org>, <linux-hyperv@vger.kernel.org>, Christian Borntraeger
	<borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.872249537@linutronix.de>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <20211206210223.872249537@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [37.59.142.102]
X-ClientProxiedBy: DAG6EX1.mxp5.local (172.16.2.51) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: b516111a-777e-4242-b371-8efd2fe3d9aa
X-Ovh-Tracer-Id: 828380858499042085
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrjeeggddutdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhephffhleegueektdetffdvffeuieeugfekkeelheelteeftdfgtefffeehueegleehnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohephhgtrgeslhhinhhugidrihgsmhdrtghomh

Hello Thomas,

On 12/6/21 23:27, Thomas Gleixner wrote:
> This code is broken since day one. ppc4xx_setup_msi_irqs() has the
> following gems:
> 
>   1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely
>      broken:
>      
>      When the result is greater than or equal 0 (bitmap allocation
>      successful) then the loop terminates and the function returns 0
>      (success) despite not having installed an interrupt.
> 
>      When the result is less than 0 (bitmap allocation fails), it prints an
>      error message and continues to "work" with that error code which would
>      eventually end up in the MSI message data.
> 
>   2) On every invocation the file global pp4xx_msi::msi_virqs bitmap is
>      allocated thereby leaking the previous one.
> 
> IOW, this has never worked and for more than 10 years nobody cared. Remove
> the gunk.
> 
> Fixes: 3fb7933850fa ("powerpc/4xx: Adding PCIe MSI support")

Shouldn't we remove all of it ? including the updates in the device trees
and the Kconfig changes under :

arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
arch/powerpc/platforms/40x/Kconfig:	select PPC4xx_MSI

Thanks,

C.



> Fixes: 247540b03bfc ("powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
>   arch/powerpc/platforms/4xx/Makefile |    1
>   arch/powerpc/platforms/4xx/msi.c    |  281 ------------------------------------
>   arch/powerpc/sysdev/Kconfig         |    6
>   3 files changed, 288 deletions(-)
> 
> --- a/arch/powerpc/platforms/4xx/Makefile
> +++ b/arch/powerpc/platforms/4xx/Makefile
> @@ -3,6 +3,5 @@ obj-y				+= uic.o machine_check.o
>   obj-$(CONFIG_4xx_SOC)		+= soc.o
>   obj-$(CONFIG_PCI)		+= pci.o
>   obj-$(CONFIG_PPC4xx_HSTA_MSI)	+= hsta_msi.o
> -obj-$(CONFIG_PPC4xx_MSI)	+= msi.o
>   obj-$(CONFIG_PPC4xx_CPM)	+= cpm.o
>   obj-$(CONFIG_PPC4xx_GPIO)	+= gpio.o
> --- a/arch/powerpc/platforms/4xx/msi.c
> +++ /dev/null
> @@ -1,281 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0-or-later
> -/*
> - * Adding PCI-E MSI support for PPC4XX SoCs.
> - *
> - * Copyright (c) 2010, Applied Micro Circuits Corporation
> - * Authors:	Tirumala R Marri <tmarri@apm.com>
> - *		Feng Kan <fkan@apm.com>
> - */
> -
> -#include <linux/irq.h>
> -#include <linux/pci.h>
> -#include <linux/msi.h>
> -#include <linux/of_platform.h>
> -#include <linux/interrupt.h>
> -#include <linux/export.h>
> -#include <linux/kernel.h>
> -#include <asm/prom.h>
> -#include <asm/hw_irq.h>
> -#include <asm/ppc-pci.h>
> -#include <asm/dcr.h>
> -#include <asm/dcr-regs.h>
> -#include <asm/msi_bitmap.h>
> -
> -#define PEIH_TERMADH	0x00
> -#define PEIH_TERMADL	0x08
> -#define PEIH_MSIED	0x10
> -#define PEIH_MSIMK	0x18
> -#define PEIH_MSIASS	0x20
> -#define PEIH_FLUSH0	0x30
> -#define PEIH_FLUSH1	0x38
> -#define PEIH_CNTRST	0x48
> -
> -static int msi_irqs;
> -
> -struct ppc4xx_msi {
> -	u32 msi_addr_lo;
> -	u32 msi_addr_hi;
> -	void __iomem *msi_regs;
> -	int *msi_virqs;
> -	struct msi_bitmap bitmap;
> -	struct device_node *msi_dev;
> -};
> -
> -static struct ppc4xx_msi ppc4xx_msi;
> -
> -static int ppc4xx_msi_init_allocator(struct platform_device *dev,
> -		struct ppc4xx_msi *msi_data)
> -{
> -	int err;
> -
> -	err = msi_bitmap_alloc(&msi_data->bitmap, msi_irqs,
> -			      dev->dev.of_node);
> -	if (err)
> -		return err;
> -
> -	err = msi_bitmap_reserve_dt_hwirqs(&msi_data->bitmap);
> -	if (err < 0) {
> -		msi_bitmap_free(&msi_data->bitmap);
> -		return err;
> -	}
> -
> -	return 0;
> -}
> -
> -static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	int int_no = -ENOMEM;
> -	unsigned int virq;
> -	struct msi_msg msg;
> -	struct msi_desc *entry;
> -	struct ppc4xx_msi *msi_data = &ppc4xx_msi;
> -
> -	dev_dbg(&dev->dev, "PCIE-MSI:%s called. vec %x type %d\n",
> -		__func__, nvec, type);
> -	if (type == PCI_CAP_ID_MSIX)
> -		pr_debug("ppc4xx msi: MSI-X untested, trying anyway.\n");
> -
> -	msi_data->msi_virqs = kmalloc_array(msi_irqs, sizeof(int), GFP_KERNEL);
> -	if (!msi_data->msi_virqs)
> -		return -ENOMEM;
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		int_no = msi_bitmap_alloc_hwirqs(&msi_data->bitmap, 1);
> -		if (int_no >= 0)
> -			break;
> -		if (int_no < 0) {
> -			pr_debug("%s: fail allocating msi interrupt\n",
> -					__func__);
> -		}
> -		virq = irq_of_parse_and_map(msi_data->msi_dev, int_no);
> -		if (!virq) {
> -			dev_err(&dev->dev, "%s: fail mapping irq\n", __func__);
> -			msi_bitmap_free_hwirqs(&msi_data->bitmap, int_no, 1);
> -			return -ENOSPC;
> -		}
> -		dev_dbg(&dev->dev, "%s: virq = %d\n", __func__, virq);
> -
> -		/* Setup msi address space */
> -		msg.address_hi = msi_data->msi_addr_hi;
> -		msg.address_lo = msi_data->msi_addr_lo;
> -
> -		irq_set_msi_desc(virq, entry);
> -		msg.data = int_no;
> -		pci_write_msi_msg(virq, &msg);
> -	}
> -	return 0;
> -}
> -
> -void ppc4xx_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -	struct ppc4xx_msi *msi_data = &ppc4xx_msi;
> -	irq_hw_number_t hwirq;
> -
> -	dev_dbg(&dev->dev, "PCIE-MSI: tearing down msi irqs\n");
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		if (!entry->irq)
> -			continue;
> -		hwirq = virq_to_hw(entry->irq);
> -		irq_set_msi_desc(entry->irq, NULL);
> -		irq_dispose_mapping(entry->irq);
> -		msi_bitmap_free_hwirqs(&msi_data->bitmap, hwirq, 1);
> -	}
> -}
> -
> -static int ppc4xx_setup_pcieh_hw(struct platform_device *dev,
> -				 struct resource res, struct ppc4xx_msi *msi)
> -{
> -	const u32 *msi_data;
> -	const u32 *msi_mask;
> -	const u32 *sdr_addr;
> -	dma_addr_t msi_phys;
> -	void *msi_virt;
> -	int err;
> -
> -	sdr_addr = of_get_property(dev->dev.of_node, "sdr-base", NULL);
> -	if (!sdr_addr)
> -		return -EINVAL;
> -
> -	msi_data = of_get_property(dev->dev.of_node, "msi-data", NULL);
> -	if (!msi_data)
> -		return -EINVAL;
> -
> -	msi_mask = of_get_property(dev->dev.of_node, "msi-mask", NULL);
> -	if (!msi_mask)
> -		return -EINVAL;
> -
> -	msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
> -	if (!msi->msi_dev)
> -		return -ENODEV;
> -
> -	msi->msi_regs = of_iomap(msi->msi_dev, 0);
> -	if (!msi->msi_regs) {
> -		dev_err(&dev->dev, "of_iomap failed\n");
> -		err = -ENOMEM;
> -		goto node_put;
> -	}
> -	dev_dbg(&dev->dev, "PCIE-MSI: msi register mapped 0x%x 0x%x\n",
> -		(u32) (msi->msi_regs + PEIH_TERMADH), (u32) (msi->msi_regs));
> -
> -	msi_virt = dma_alloc_coherent(&dev->dev, 64, &msi_phys, GFP_KERNEL);
> -	if (!msi_virt) {
> -		err = -ENOMEM;
> -		goto iounmap;
> -	}
> -	msi->msi_addr_hi = upper_32_bits(msi_phys);
> -	msi->msi_addr_lo = lower_32_bits(msi_phys & 0xffffffff);
> -	dev_dbg(&dev->dev, "PCIE-MSI: msi address high 0x%x, low 0x%x\n",
> -		msi->msi_addr_hi, msi->msi_addr_lo);
> -
> -	mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start));	/*HIGH addr */
> -	mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start));	/* Low addr */
> -
> -	/* Progam the Interrupt handler Termination addr registers */
> -	out_be32(msi->msi_regs + PEIH_TERMADH, msi->msi_addr_hi);
> -	out_be32(msi->msi_regs + PEIH_TERMADL, msi->msi_addr_lo);
> -
> -	/* Program MSI Expected data and Mask bits */
> -	out_be32(msi->msi_regs + PEIH_MSIED, *msi_data);
> -	out_be32(msi->msi_regs + PEIH_MSIMK, *msi_mask);
> -
> -	dma_free_coherent(&dev->dev, 64, msi_virt, msi_phys);
> -
> -	return 0;
> -
> -iounmap:
> -	iounmap(msi->msi_regs);
> -node_put:
> -	of_node_put(msi->msi_dev);
> -	return err;
> -}
> -
> -static int ppc4xx_of_msi_remove(struct platform_device *dev)
> -{
> -	struct ppc4xx_msi *msi = dev->dev.platform_data;
> -	int i;
> -	int virq;
> -
> -	for (i = 0; i < msi_irqs; i++) {
> -		virq = msi->msi_virqs[i];
> -		if (virq)
> -			irq_dispose_mapping(virq);
> -	}
> -
> -	if (msi->bitmap.bitmap)
> -		msi_bitmap_free(&msi->bitmap);
> -	iounmap(msi->msi_regs);
> -	of_node_put(msi->msi_dev);
> -
> -	return 0;
> -}
> -
> -static int ppc4xx_msi_probe(struct platform_device *dev)
> -{
> -	struct ppc4xx_msi *msi;
> -	struct resource res;
> -	int err = 0;
> -	struct pci_controller *phb;
> -
> -	dev_dbg(&dev->dev, "PCIE-MSI: Setting up MSI support...\n");
> -
> -	msi = devm_kzalloc(&dev->dev, sizeof(*msi), GFP_KERNEL);
> -	if (!msi)
> -		return -ENOMEM;
> -	dev->dev.platform_data = msi;
> -
> -	/* Get MSI ranges */
> -	err = of_address_to_resource(dev->dev.of_node, 0, &res);
> -	if (err) {
> -		dev_err(&dev->dev, "%pOF resource error!\n", dev->dev.of_node);
> -		return err;
> -	}
> -
> -	msi_irqs = of_irq_count(dev->dev.of_node);
> -	if (!msi_irqs)
> -		return -ENODEV;
> -
> -	err = ppc4xx_setup_pcieh_hw(dev, res, msi);
> -	if (err)
> -		return err;
> -
> -	err = ppc4xx_msi_init_allocator(dev, msi);
> -	if (err) {
> -		dev_err(&dev->dev, "Error allocating MSI bitmap\n");
> -		goto error_out;
> -	}
> -	ppc4xx_msi = *msi;
> -
> -	list_for_each_entry(phb, &hose_list, list_node) {
> -		phb->controller_ops.setup_msi_irqs = ppc4xx_setup_msi_irqs;
> -		phb->controller_ops.teardown_msi_irqs = ppc4xx_teardown_msi_irqs;
> -	}
> -	return 0;
> -
> -error_out:
> -	ppc4xx_of_msi_remove(dev);
> -	return err;
> -}
> -static const struct of_device_id ppc4xx_msi_ids[] = {
> -	{
> -		.compatible = "amcc,ppc4xx-msi",
> -	},
> -	{}
> -};
> -static struct platform_driver ppc4xx_msi_driver = {
> -	.probe = ppc4xx_msi_probe,
> -	.remove = ppc4xx_of_msi_remove,
> -	.driver = {
> -		   .name = "ppc4xx-msi",
> -		   .of_match_table = ppc4xx_msi_ids,
> -		   },
> -
> -};
> -
> -static __init int ppc4xx_msi_init(void)
> -{
> -	return platform_driver_register(&ppc4xx_msi_driver);
> -}
> -
> -subsys_initcall(ppc4xx_msi_init);
> --- a/arch/powerpc/sysdev/Kconfig
> +++ b/arch/powerpc/sysdev/Kconfig
> @@ -12,17 +12,11 @@ config PPC4xx_HSTA_MSI
>   	depends on PCI_MSI
>   	depends on PCI && 4xx
>   
> -config PPC4xx_MSI
> -	bool
> -	depends on PCI_MSI
> -	depends on PCI && 4xx
> -
>   config PPC_MSI_BITMAP
>   	bool
>   	depends on PCI_MSI
>   	default y if MPIC
>   	default y if FSL_PCI
> -	default y if PPC4xx_MSI
>   	default y if PPC_POWERNV
>   
>   source "arch/powerpc/sysdev/xics/Kconfig"
> 



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:43:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:43:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240547.417102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV7y-0001hj-EI; Tue, 07 Dec 2021 07:43:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240547.417102; Tue, 07 Dec 2021 07:43:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV7y-0001hc-As; Tue, 07 Dec 2021 07:43:06 +0000
Received: by outflank-mailman (input) for mailman id 240547;
 Tue, 07 Dec 2021 07:43:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muV7w-0001hW-RF
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:43:04 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4daba908-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:43:02 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id DBD2CCE19EC;
 Tue,  7 Dec 2021 07:42:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D81AC341C1;
 Tue,  7 Dec 2021 07:42:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4daba908-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638862974;
	bh=2qIgL0JBG4vV/MINd0ETzL6k1r509RSkk45xSKKLJ7I=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=rEqXyxtMWZFlcF8r3yxH1/TtAEbDHBaUwIDAPsv9sHOOC0Rmzi+lrDEkr6FW8lcZr
	 /vMFQ/81Tv7pxgdvjTeFJkR4e1RX4olYyYFOA3hLqZw2/Xn7l2GFzYB4NYCzFkanis
	 14vBaVGOTC4Y8SHo20NGaCX7CBAe2IriKWHo0K/0=
Date: Tue, 7 Dec 2021 08:42:51 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 03/23] genirq/msi: Guard sysfs code
Message-ID: <Ya8Qe7Mol8STLvkd@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.985907940@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210223.985907940@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:28PM +0100, Thomas Gleixner wrote:
> No point in building unused code when CONFIG_SYSFS=n.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:43:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:43:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240548.417113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV84-0001yu-NU; Tue, 07 Dec 2021 07:43:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240548.417113; Tue, 07 Dec 2021 07:43:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV84-0001yh-JU; Tue, 07 Dec 2021 07:43:12 +0000
Received: by outflank-mailman (input) for mailman id 240548;
 Tue, 07 Dec 2021 07:43:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muV83-0001hW-JN
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:43:11 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52d3f1a6-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:43:10 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id F3313CE19FD;
 Tue,  7 Dec 2021 07:43:08 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DDAFC341C3;
 Tue,  7 Dec 2021 07:43:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52d3f1a6-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638862988;
	bh=5v2CYN6Ek/VsBwXBgnA+9vhOyUOpZ4AXtUsFipJFXnk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=JhIwRrB39WEo9ruwJWOuvB7N1crHht5tuI+kItER+b+vuapdVaIC+9lVIKc3Q5VBL
	 YdQQXLyF0FiNYgisXBRtnT2nfSUZlr1Kn5R/E2ykVg2r5rMoqIE2uU7VdjZDWuMWeM
	 5p2s+W7o63jkZoCUkzMytzmIEbC1GuZZxXiH55Kw=
Date: Tue, 7 Dec 2021 08:43:06 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 05/23] genirq/msi: Fixup includes
Message-ID: <Ya8Qim1ROOD/247D@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.103502021@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.103502021@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:31PM +0100, Thomas Gleixner wrote:
> Remove the kobject.h include from msi.h as it's not required and add a
> sysfs.h include to the core code instead.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:43:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:43:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240550.417123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV8M-0002ac-Vh; Tue, 07 Dec 2021 07:43:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240550.417123; Tue, 07 Dec 2021 07:43:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV8M-0002aV-SN; Tue, 07 Dec 2021 07:43:30 +0000
Received: by outflank-mailman (input) for mailman id 240550;
 Tue, 07 Dec 2021 07:43:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muV8L-0001hW-5L
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:43:29 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5df52a75-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:43:28 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 197DDB8168A;
 Tue,  7 Dec 2021 07:43:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BEA8C341C3;
 Tue,  7 Dec 2021 07:43:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5df52a75-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863005;
	bh=hZ6r5RT8PuAvjxr9hFBTJ7OFksPKVnHZGwrS2FMUegk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=aETC4sd7x+h4lI1cwVylig9GmsgU3qpCcUcVwYuTAKDA0yAzfbGTIBItteAOnTGEW
	 zitWvMW09C4KG6fcaLgFeyX4kuVVlu+TwIsyPWkTvkljIe5oZtNN5XPpHkNfbIFXSF
	 qMiniC2oUeuK0/Qf28kg20mXvkLt/BGabUq82pj8=
Date: Tue, 7 Dec 2021 08:43:23 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 08/23] PCI/sysfs: Use pci_irq_vector()
Message-ID: <Ya8Qm8zwHa78SrBK@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.265589103@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.265589103@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:36PM +0100, Thomas Gleixner wrote:
> instead of fiddling with msi descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:43:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:43:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240555.417135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV8b-000382-7g; Tue, 07 Dec 2021 07:43:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240555.417135; Tue, 07 Dec 2021 07:43:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV8b-00037v-4k; Tue, 07 Dec 2021 07:43:45 +0000
Received: by outflank-mailman (input) for mailman id 240555;
 Tue, 07 Dec 2021 07:43:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muV8a-00031l-31
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:43:44 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 660545fd-5731-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:43:43 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 960951FD48;
 Tue,  7 Dec 2021 07:43:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3039A1332F;
 Tue,  7 Dec 2021 07:43:41 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3V7kCa0Qr2EdHwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:43:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 660545fd-5731-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863021; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=DjzkKZ6ZOc+qrv3QctxeeJCnwI6Kv0HZxHvSl3MtdZQ=;
	b=cZZYXGfBlGIrOPA0/ZTbMRx++5umJ0g/1Z23UxPoL+71LODMIXFNLFwQawMXhFRKheg89+
	Zy5+VyCyXD1o8NFI8ZtVXfDKkXz/tgHudspJLawuyXMnov25rY9bRmqTozG2LNyvtHs14u
	LmUNl8/uXG/nE0XcEvPJnTmJoWu57cg=
Subject: Re: [XEN PATCH 04/57] libs: Remove _paths.h from libs ctrl and util.
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-5-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <77ff9aa6-a584-8b43-43a7-e55e80d0e866@suse.com>
Date: Tue, 7 Dec 2021 08:43:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-5-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="fr9w1SMWAubKaXLXcI5qx7aXXw3Qz0Hep"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--fr9w1SMWAubKaXLXcI5qx7aXXw3Qz0Hep
Content-Type: multipart/mixed; boundary="hEKVwdV3T6ayFjuBK4GxBNJXf9S4FMS3T";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <77ff9aa6-a584-8b43-43a7-e55e80d0e866@suse.com>
Subject: Re: [XEN PATCH 04/57] libs: Remove _paths.h from libs ctrl and util.
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-5-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-5-anthony.perard@citrix.com>

--hEKVwdV3T6ayFjuBK4GxBNJXf9S4FMS3T
Content-Type: multipart/mixed;
 boundary="------------554D26BF91084DF753A00C8B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------554D26BF91084DF753A00C8B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> libxenutil doesn't include _paths.h so no need to generate it.
>=20
> libxenctrl doesn't use macros from _paths.h so can be removed.
> Fix libxenguest to include _paths.h properly instead of relying on
> xc_private.h
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------554D26BF91084DF753A00C8B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------554D26BF91084DF753A00C8B--

--hEKVwdV3T6ayFjuBK4GxBNJXf9S4FMS3T--

--fr9w1SMWAubKaXLXcI5qx7aXXw3Qz0Hep
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvEKwFAwAAAAAACgkQsN6d1ii/Ey+J
BAf9HtniCuFYxfecEYo4avnY5thFM1gNNoXZJLlZ9jejTCHzxAl5htOw1+v6XZ1AEXhx6w4yCtgX
9VIekAtG35mJdkLYQ3NVQ2y1Jge7uWUC+k+z4oL9IqUHr1U/RDxH5i3UE379DKN2AKk6d5H85Eoz
c8toS/CA0ObR8nT5nBinF5Hn5WjS75GsjA+HB7wJb3QHYz7noww6kIiK5y8I7mbdLblMc3HCow/b
Hxmi/VYcmv7mUV18S5lweZkemtkZho0QhgAczwPWWGauc+AfK1gfSNmRTO50/HYPNMywuUHvE6/K
0v9RZsGGqRFfEFZMqMx+p0G2K3J5BkkH/VvKh+0xiw==
=Ic4r
-----END PGP SIGNATURE-----

--fr9w1SMWAubKaXLXcI5qx7aXXw3Qz0Hep--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:44:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:44:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240562.417145 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV97-0003s8-Fz; Tue, 07 Dec 2021 07:44:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240562.417145; Tue, 07 Dec 2021 07:44:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV97-0003s1-D2; Tue, 07 Dec 2021 07:44:17 +0000
Received: by outflank-mailman (input) for mailman id 240562;
 Tue, 07 Dec 2021 07:44:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muV96-00031l-6n
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:44:16 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 784b3ebe-5731-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:44:14 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id EC409CE19ED;
 Tue,  7 Dec 2021 07:44:11 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62DD6C341C1;
 Tue,  7 Dec 2021 07:44:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 784b3ebe-5731-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863047;
	bh=Yz0WH2dr1QgSK49CFe7iFQ+XeVnQkWXGdacZietp0hE=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=ubBF0Z2AfejKCYJIZteJrserEv0J9NT01LNRNKJ/KrLN5gKu3YqoZRB1nmERkKkDS
	 kJLnHlpBhYYtt+efX5t4G162exIvYkUrzrZgqARbx50OcrLfiwASrgs5YBjwZXr4hL
	 Jhs1l7eEN7akG3UcGvqXKzHIDcpxgb/0gFN5lhYI=
Date: Tue, 7 Dec 2021 08:44:05 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
	linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 10/23] genirq/msi, treewide: Use a named struct for
 PCI/MSI attributes
Message-ID: <Ya8QxSUKbVEHHSGh@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.374863119@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.374863119@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:39PM +0100, Thomas Gleixner wrote:
> The unnamed struct sucks and is in the way of further cleanups. Stick the
> PCI related MSI data into a real data structure and cleanup all users.
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Acked-by: Kalle Valo <kvalo@codeaurora.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: sparclinux@vger.kernel.org
> Cc: x86@kernel.org
> Cc: xen-devel@lists.xenproject.org
> Cc: ath11k@lists.infradead.org

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:44:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:44:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240565.417157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV9S-0004QI-QV; Tue, 07 Dec 2021 07:44:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240565.417157; Tue, 07 Dec 2021 07:44:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV9S-0004Q9-Mm; Tue, 07 Dec 2021 07:44:38 +0000
Received: by outflank-mailman (input) for mailman id 240565;
 Tue, 07 Dec 2021 07:44:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muV9R-0004OI-Ix
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:44:37 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86960972-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:44:36 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5F04621B3D;
 Tue,  7 Dec 2021 07:44:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 369DB1332F;
 Tue,  7 Dec 2021 07:44:36 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6Z8kDOQQr2FzHwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:44:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86960972-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863076; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=HLIWT6wL6ZlV9a4xrWqQhlxSEpuyzhPTXGaB0uqBD0E=;
	b=JS0UTPGd9wh3ZO7IxWcyfh2sVGEOPtFCzxH3FPORSKGTeYAvtVGUqMteNkBi6plBDNfSaL
	5k8V4Ae5BWhF8Zf3moKEyw2SSn5xMSPV5WsymOrPCgXkLlZDWVyVuXxnTZW7IdjZa5ZYRG
	VOb+6YabB/YKGIDN3B9Qprr/xeod21w=
Subject: Re: [XEN PATCH 05/57] libs: Remove -Iinclude from CFLAGS
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-6-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <42d4564a-fb48-5a14-ee71-019a8b2aaab8@suse.com>
Date: Tue, 7 Dec 2021 08:44:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-6-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="MKaWT0UPGH3fjce4IjE0UprlQEwVhv3x6"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MKaWT0UPGH3fjce4IjE0UprlQEwVhv3x6
Content-Type: multipart/mixed; boundary="iRgjLJOX8qHMbGIsjQG431gJJJ50lmAEJ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <42d4564a-fb48-5a14-ee71-019a8b2aaab8@suse.com>
Subject: Re: [XEN PATCH 05/57] libs: Remove -Iinclude from CFLAGS
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-6-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-6-anthony.perard@citrix.com>

--iRgjLJOX8qHMbGIsjQG431gJJJ50lmAEJ
Content-Type: multipart/mixed;
 boundary="------------15F4C654F9C06472C6741045"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------15F4C654F9C06472C6741045
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> They are no more directory libs/*/include.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------15F4C654F9C06472C6741045
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------15F4C654F9C06472C6741045--

--iRgjLJOX8qHMbGIsjQG431gJJJ50lmAEJ--

--MKaWT0UPGH3fjce4IjE0UprlQEwVhv3x6
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvEOMFAwAAAAAACgkQsN6d1ii/Ey9U
+ggAg8Xotyk7u4QGUMVLGwPcUIRyHpasFm1ZjAm2ZaU/456ayLjcq7jVHBPtLxXGq4zsymbfrygD
EAMV7T6A9qVbnndMoeF46sM74WVQPvLHdF6wtLGEz99PonV5Hhuirm9m3XRPgpSkzPeLpdPs9HOi
DHDpcbvBtOPRPSKSOUWwZIgizpsjv6jIvRYh48ZWGu2jf/etswRmiDOG5j7eD8kZXKfKNbzbxT8m
ZrMptq6e83VsvT9x2Rzvu0IulF12lQgcWUYo2ZeWoTuDWIBHEUUCHa/g8NKz+4PZrgbtb3lK6HU4
x0BWuGjn+J7K3TPIcDl8uwiw/lEztpHvcD4UP0T+Zw==
=KMsW
-----END PGP SIGNATURE-----

--MKaWT0UPGH3fjce4IjE0UprlQEwVhv3x6--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:45:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:45:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240577.417168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV9v-00056V-6o; Tue, 07 Dec 2021 07:45:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240577.417168; Tue, 07 Dec 2021 07:45:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muV9v-00056O-3T; Tue, 07 Dec 2021 07:45:07 +0000
Received: by outflank-mailman (input) for mailman id 240577;
 Tue, 07 Dec 2021 07:45:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muV9t-0004OI-QY
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:45:05 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 96ed034d-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:45:05 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 2DAF9CE19DD;
 Tue,  7 Dec 2021 07:45:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A401C341C3;
 Tue,  7 Dec 2021 07:44:59 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96ed034d-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863100;
	bh=1r1X+ZHiffheVJg5Mf7nrvakcpVQqQbwTurW2S7fT/s=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=l1/QgBFwqoXc2OAqrPg8mXMQvF5rv5z/fNqAHcshOCZgD5tN6DsYDVMKyMum5XpbR
	 tTUmjHxCYxJdHEeYzATtISF27T8l5whlPASeO5DQut4iaiHRSBKvqJ9dh18fp3h8CK
	 xuOWK2ssrIqlzWKMqvooAc5l1otA0m+pE8ZKIdZ4=
Date: Tue, 7 Dec 2021 08:44:57 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 14/23] PCI/MSI: Make msix_update_entries() smarter
Message-ID: <Ya8Q+Q8OnrovJGET@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.600351129@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.600351129@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:46PM +0100, Thomas Gleixner wrote:
> No need to walk the descriptors and check for each one whether the entries
> pointer function argument is NULL. Do it once.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:45:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:45:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240583.417179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVAl-0005ow-Hn; Tue, 07 Dec 2021 07:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240583.417179; Tue, 07 Dec 2021 07:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVAl-0005op-Co; Tue, 07 Dec 2021 07:45:59 +0000
Received: by outflank-mailman (input) for mailman id 240583;
 Tue, 07 Dec 2021 07:45:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVAk-0005oY-0E
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:45:58 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b6513276-5731-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:45:57 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 57B9CB816A7;
 Tue,  7 Dec 2021 07:45:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71F0FC341C3;
 Tue,  7 Dec 2021 07:45:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6513276-5731-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863155;
	bh=gRy6TW9oSvfP7dg3zhkuzychOXyAHsIOP80ZNfLYfos=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=SiqDsJQkbNZ0TkHVyhqD8eHIjknQi5V0JuRjw6ygTj9D2zKPOwQURIy7jo57+w2du
	 ZMCTZHvOwWB7jQV72lXakTsB1GLsVP+TrRykUHY6K5a3U3G0G39PJ3woVfTktTJ7Iv
	 JNlX2AYmusSMwGbHuVxEc8Oqqs3RKuuhG7eHXMdI=
Date: Tue, 7 Dec 2021 08:45:52 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 17/23] PCI/MSI: Split out !IRQDOMAIN code
Message-ID: <Ya8RME4tz+LZD7+h@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.763574089@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.763574089@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:51PM +0100, Thomas Gleixner wrote:
> Split out the non irqdomain code into its own file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:46:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:46:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240590.417190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBX-0006Rl-Qm; Tue, 07 Dec 2021 07:46:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240590.417190; Tue, 07 Dec 2021 07:46:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBX-0006Re-NZ; Tue, 07 Dec 2021 07:46:47 +0000
Received: by outflank-mailman (input) for mailman id 240590;
 Tue, 07 Dec 2021 07:46:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVBW-0005oY-KE
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:46:46 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d39d78fe-5731-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:46:46 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9CE74212C5;
 Tue,  7 Dec 2021 07:46:45 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7789A1332F;
 Tue,  7 Dec 2021 07:46:45 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id icj6G2URr2GfIAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:46:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d39d78fe-5731-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qB7pO5GYusMOqayd1ttmb2183lPbSYEKHbxcy074YYI=;
	b=R7zbKofNYCA36urkba8m9xA/kX1ZInV09POo8uqV5bjleLTx4MEplvdtfcGLNf+FUGjgmO
	bxTNJrAP+2vTGQ6rs+L1IOYTjVG0Yz0NezxaR+saDjfjL4vs1LV3dGeVIGOQZ+7G4N4Q4x
	1+lQexTX8JPnHMlCrLGu+ZcT6oWQ6Ss=
Subject: Re: [XEN PATCH 06/57] libs/libs.mk: Remove generic variable that
 already exist
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-7-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <f27bfa7c-9be2-7aa7-f128-d54bd5b68200@suse.com>
Date: Tue, 7 Dec 2021 08:46:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-7-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="kxHhSqSslr0cMeOwSjxWrYd0VB6vR6I3S"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--kxHhSqSslr0cMeOwSjxWrYd0VB6vR6I3S
Content-Type: multipart/mixed; boundary="fGexgNTI86rnPYFzkFUAxPafmM2wnZLOz";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <f27bfa7c-9be2-7aa7-f128-d54bd5b68200@suse.com>
Subject: Re: [XEN PATCH 06/57] libs/libs.mk: Remove generic variable that
 already exist
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-7-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-7-anthony.perard@citrix.com>

--fGexgNTI86rnPYFzkFUAxPafmM2wnZLOz
Content-Type: multipart/mixed;
 boundary="------------5D165BF679912E5611FACE16"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------5D165BF679912E5611FACE16
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> comma, empty, space are already defined in "Config.mk".
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------5D165BF679912E5611FACE16
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5D165BF679912E5611FACE16--

--fGexgNTI86rnPYFzkFUAxPafmM2wnZLOz--

--kxHhSqSslr0cMeOwSjxWrYd0VB6vR6I3S
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvEWQFAwAAAAAACgkQsN6d1ii/Ey/d
AQf/WcuF7FPnEg7YZGfnLSiREfwsYkn+xajWUOjs/DMSXPmhFb7kU9MWa6SqMMmUHAoXRL7xh+rJ
PFfq8mSnma1mPnhKajMEsYlMVeaZgrlnABYKS2Hxh/kZc7izDM0d1oPLnj3+KWzfdM3EaVogjJc/
xAe77spOCGSTCAQ4XfuJrS8gsY8h/6VwLY6LFv9mqw4i9tMwDOsjZJ2neF84oU2gKNJVgNzEeah7
t30jzzNCpeBIWZGCkv8vRBYraXS7C5XS9m4+MNppMFaopyNJ97G3zmCFaa9PaMhcMK+CccDpuulK
SK6JKxQV3E1fnXx9kVor8LAaO22yhcJdVSOY/UhSBA==
=qwbp
-----END PGP SIGNATURE-----

--kxHhSqSslr0cMeOwSjxWrYd0VB6vR6I3S--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:46:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:46:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240591.417197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBY-0006VI-7s; Tue, 07 Dec 2021 07:46:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240591.417197; Tue, 07 Dec 2021 07:46:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBY-0006Ur-02; Tue, 07 Dec 2021 07:46:48 +0000
Received: by outflank-mailman (input) for mailman id 240591;
 Tue, 07 Dec 2021 07:46:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVBX-0006RR-7t
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:46:47 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d3551e59-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:46:46 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0A8E0B816C2;
 Tue,  7 Dec 2021 07:46:45 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 316F4C341C3;
 Tue,  7 Dec 2021 07:46:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3551e59-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863203;
	bh=XYTXXWRy+9YqYUEnMANtgMz2OiDj8LhJM0fhnz6BZfk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=MG3AiqTQwZNqxKk2vJDV2iPvDHwnIDTDlZbDtWj1PANq3S81yMDYHPPCHBmVaryz7
	 XV4KY7K+917sMh3tQ3NZlb/gP1jjxq/WP+H9oKvY+3iXQJfkC4Jb6xKzFeP5wxol9J
	 2t4bPREpWjYIKSrgRe1fdUC23vxeTGIaXPYH8W6o=
Date: Tue, 7 Dec 2021 08:46:41 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 18/23] PCI/MSI: Split out irqdomain code
Message-ID: <Ya8RYToy04z6lRIx@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.817754783@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.817754783@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:52PM +0100, Thomas Gleixner wrote:
> Move the irqdomain specific code into it's own file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:47:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240596.417212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBx-0007n0-Ed; Tue, 07 Dec 2021 07:47:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240596.417212; Tue, 07 Dec 2021 07:47:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVBx-0007mt-AG; Tue, 07 Dec 2021 07:47:13 +0000
Received: by outflank-mailman (input) for mailman id 240596;
 Tue, 07 Dec 2021 07:47:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVAE-00031l-LW
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:45:26 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a300ee6b-5731-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:45:25 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 5F5CFCE19FC;
 Tue,  7 Dec 2021 07:45:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EE83C341C1;
 Tue,  7 Dec 2021 07:45:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a300ee6b-5731-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863121;
	bh=x8rfoXc6M9OTPg850eW6BmKW89RExZgEThtugpTz+6A=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=d+jxkiN+f3Ne67zNIOcujASWUugViQ8TCbEK7hiYq+U3n+Fahxn1L0f30VN8pbizc
	 hZNBuPiZATbQ+AOim8phsr2YKIPQl8JKLp/83pYydRrndRT/TnSSzHpxTclp34m7lF
	 oxqIgoW6u6pwrjoz/ow2obv1+OJVMNbiDW5DGKmY=
Date: Tue, 7 Dec 2021 08:45:19 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 16/23] PCI/MSI: Split out CONFIG_PCI_MSI independent
 part
Message-ID: <Ya8RD/4MMG8LLzDR@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.710137730@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.710137730@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:49PM +0100, Thomas Gleixner wrote:
> These functions are required even when CONFIG_PCI_MSI is not set. Move them
> to their own file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:47:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240603.417224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVC6-0008Nd-Op; Tue, 07 Dec 2021 07:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240603.417224; Tue, 07 Dec 2021 07:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVC6-0008N9-Id; Tue, 07 Dec 2021 07:47:22 +0000
Received: by outflank-mailman (input) for mailman id 240603;
 Tue, 07 Dec 2021 07:47:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVC5-0006RR-E1
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:47:21 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8857f8b-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:47:20 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 8E5E6B816D5;
 Tue,  7 Dec 2021 07:47:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF933C341C1;
 Tue,  7 Dec 2021 07:47:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8857f8b-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863239;
	bh=S3bXluwk9Tp0/I7fDZuveLkWCavppG21+XUHrjKqzHc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Pb/dyynXP59dAMHIuj0t8HKLgqvn8JROVWdSIIIKJ5NiyoFtkSERH47W84UjiwAXs
	 MWu0388me7wEsfFLd9qgqWiW6piHnLwSP52fOwKGGYOy/OwLdXwUJVoGnJm7L14wxN
	 BPRnkCaul1K9TxSg+lXuERdjdsH74dOh8QaEwz0s=
Date: Tue, 7 Dec 2021 08:47:16 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 20/23] PCI/MSI: Move msi_lock to struct pci_dev
Message-ID: <Ya8RhMylu6OWYNia@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.925241961@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.925241961@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:56PM +0100, Thomas Gleixner wrote:
> It's only required for PCI/MSI. So no point in having it in every struct
> device.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Yes!!!


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>





From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:47:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:47:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240611.417234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVCV-0000kI-Vp; Tue, 07 Dec 2021 07:47:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240611.417234; Tue, 07 Dec 2021 07:47:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVCV-0000k9-SL; Tue, 07 Dec 2021 07:47:47 +0000
Received: by outflank-mailman (input) for mailman id 240611;
 Tue, 07 Dec 2021 07:47:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVCV-0006RR-Ey
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:47:47 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f65b593c-5731-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:47:45 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 69B4DCE1A03;
 Tue,  7 Dec 2021 07:47:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB93BC341C1;
 Tue,  7 Dec 2021 07:47:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f65b593c-5731-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863261;
	bh=GJEc5bHESZynwTkpKatK/sv+Oau05bPz5qOKd1zBMSc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=FLhJjK7rO92G8d3WWjG7tWRQ+BW+rOaBX5Ee1Gl0gD+5ddO+i5XQqu+JCB+cbG68P
	 X06bBa7EJYZKAsQL6qvCO228/ql4ENSodj1f7Q2N+ZvtKwZka/F+1QUWjQmaE+zFif
	 LbTeWJgFzo/EHaecJ068/cqfOkongNyBJMpNwFYI=
Date: Tue, 7 Dec 2021 08:47:39 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 21/23] PCI/MSI: Make pci_msi_domain_check_cap() static
Message-ID: <Ya8Rm/cmS4054OvP@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.980989243@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.980989243@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:57PM +0100, Thomas Gleixner wrote:
> No users outside of that file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:50:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:50:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240619.417245 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVEZ-0001bt-G5; Tue, 07 Dec 2021 07:49:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240619.417245; Tue, 07 Dec 2021 07:49:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVEZ-0001bm-CN; Tue, 07 Dec 2021 07:49:55 +0000
Received: by outflank-mailman (input) for mailman id 240619;
 Tue, 07 Dec 2021 07:49:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVEY-0001bg-9p
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:49:54 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43738bfc-5732-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:49:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 40FAB1FD48;
 Tue,  7 Dec 2021 07:49:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 197D91332F;
 Tue,  7 Dec 2021 07:49:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id MgeoBCESr2GRIQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:49:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43738bfc-5732-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=dZOsCTZQ/ptrmjItkLlqiD3/DUjDOIuqjkJXfsF50w8=;
	b=Jt/FEIJV1dyznscGE3YWWJT/EjBJycyzJWWrV6pcgHRGh2lNDHclIbOb8zgiKm63oMyGcH
	FGhiVKsIEiHKtexJYw6JXJsbPhdchxytCC+tSH1eflVVmKcGFc4826zeIOEzgM2RjilABg
	/FQq/1GFIEVHXUMP36ut/sPKtZ6bhi4=
Subject: Re: [XEN PATCH 08/57] libs/light: Remove non-existing CFLAGS_libxl.o
 var
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-9-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <5c3e35f2-2376-0467-7481-d6d193d945e2@suse.com>
Date: Tue, 7 Dec 2021 08:49:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-9-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="9dpjxNlGVvRcmzGEYrY1AKRpuhwloAZtb"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--9dpjxNlGVvRcmzGEYrY1AKRpuhwloAZtb
Content-Type: multipart/mixed; boundary="DonC9cAuoR4MVctjzqy8sHXZqIf1LCKEZ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <5c3e35f2-2376-0467-7481-d6d193d945e2@suse.com>
Subject: Re: [XEN PATCH 08/57] libs/light: Remove non-existing CFLAGS_libxl.o
 var
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-9-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-9-anthony.perard@citrix.com>

--DonC9cAuoR4MVctjzqy8sHXZqIf1LCKEZ
Content-Type: multipart/mixed;
 boundary="------------9543D1398CEA77F668B80115"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------9543D1398CEA77F668B80115
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> This var was originally $(CFLAGS_$*.o), and probably was copied from
> the generic %.o:%.c rules.
>=20
> Nothing sets CFLAGS_libxl.o, so remove it.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------9543D1398CEA77F668B80115
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9543D1398CEA77F668B80115--

--DonC9cAuoR4MVctjzqy8sHXZqIf1LCKEZ--

--9dpjxNlGVvRcmzGEYrY1AKRpuhwloAZtb
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvEiAFAwAAAAAACgkQsN6d1ii/Ey/5
uQf+OrNjgv0R92ef1F/wxOVeHWpvQ9v8vmyPGSIH6OsDMeZMdBEh6kwMFQ8ZfsAdNEoKr7lUZWWu
SAu9YDDwf+O9J8hxGm82KCPuIT1YVkgDyLM5yavBwYpIlgE07gj0CmvS6ddV2xmYD0HdXcTXqooB
/q8MtD8SbCNX4uqR4df5wup3blYn0X/YQRenefq5+9GSFchoyGol1vkdxMmj5hbCCCa3CPs0N0Yd
ncdZ/h5I+v3DpfVbNwo+wFvi/xWEOpoayKjW4DqAWPu9FVd4AzvMtabBpESQfPggn8anj0UgQVu0
GSXIji+7V0SPz2VTd5MtjeZGEM+EDh/5nt5/66FvCg==
=U9Dz
-----END PGP SIGNATURE-----

--9dpjxNlGVvRcmzGEYrY1AKRpuhwloAZtb--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240625.417255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGZ-0002wL-Rf; Tue, 07 Dec 2021 07:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240625.417255; Tue, 07 Dec 2021 07:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGZ-0002wE-Oq; Tue, 07 Dec 2021 07:51:59 +0000
Received: by outflank-mailman (input) for mailman id 240625;
 Tue, 07 Dec 2021 07:51:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVGY-0002w4-MH
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:51:58 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d932cef-5732-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:51:57 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7AAC8B80E8C;
 Tue,  7 Dec 2021 07:51:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6A69C341C3;
 Tue,  7 Dec 2021 07:51:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d932cef-5732-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863516;
	bh=jJB7V/1FDjCODHYTLlFlS5enXptOdG8ZYS3VC4cWcVw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=vRE24ncYXDsRhhK2eQiUlxP7Y8oQsTsshV3hfVEv8bGtSxchPZ8/SkzPNYE1E38An
	 aOvrifHb/I9rQaWzQ07/d2NwtcfBxBO7tW7Ohdsq63Q2QKH1LNL+bVYpuGXJT676qi
	 Uz/SbFs2qPx/iZd1dSkcACeZlmJJNSFCfEQlT6xo=
Date: Tue, 7 Dec 2021 08:51:53 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 27/36] genirq/msi: Provide interface to retrieve Linux
 interrupt number
Message-ID: <Ya8SmWGiCnt4xTmC@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210439.128089025@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210439.128089025@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:39PM +0100, Thomas Gleixner wrote:
> This allows drivers to retrieve the Linux interrupt number instead of
> fiddling with MSI descriptors.
> 
> msi_get_virq() returns the Linux interrupt number or 0 in case that there
> is no entry for the given MSI index.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240626.417267 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGk-0003Go-5C; Tue, 07 Dec 2021 07:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240626.417267; Tue, 07 Dec 2021 07:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGk-0003Gf-0m; Tue, 07 Dec 2021 07:52:10 +0000
Received: by outflank-mailman (input) for mailman id 240626;
 Tue, 07 Dec 2021 07:52:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVGi-0002w4-E4
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:52:08 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9390bd66-5732-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:52:07 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 88C2AB816D2;
 Tue,  7 Dec 2021 07:52:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91414C341C3;
 Tue,  7 Dec 2021 07:52:06 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9390bd66-5732-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863527;
	bh=tQN7ei8MO5k5ZSrc1wKOamJhApJA81L4p4xiMaAbxCc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=I5VO1ii2U6A2zXtMiP57Uym70Rs4GX4p7a0kYlCwOcJtg+d4e8Y4wK49CiC+T7eOF
	 GGTT5dxj4o5oFna87R8rr33KGlfqxwVKI5Kf41BOdlSMGdnZgXHVqakqawlGMXTHLu
	 z9ZU5j7f67Ry+fGSGK4edcTT/3F1u5K83oupoib0=
Date: Tue, 7 Dec 2021 08:52:04 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 26/36] powerpc/pseries/msi: Let core code check for
 contiguous entries
Message-ID: <Ya8SpNVEKFZnhesH@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210439.074795958@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210439.074795958@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:37PM +0100, Thomas Gleixner wrote:
> Set the domain info flag and remove the check.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240629.417278 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGv-0003oD-F4; Tue, 07 Dec 2021 07:52:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240629.417278; Tue, 07 Dec 2021 07:52:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVGv-0003o4-BJ; Tue, 07 Dec 2021 07:52:21 +0000
Received: by outflank-mailman (input) for mailman id 240629;
 Tue, 07 Dec 2021 07:52:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVGu-0003mG-Dy
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:52:20 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9a47d1bc-5732-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:52:19 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C4F0EB816D8;
 Tue,  7 Dec 2021 07:52:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 780C2C341C3;
 Tue,  7 Dec 2021 07:52:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a47d1bc-5732-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863537;
	bh=YYyYDqi7BKUMM2VLzZGPdlwcQYloLbHu+PMAAmx4vhQ=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Lrf2b5VSroC8kPE/EiMROJoVWuZNxt44LjP49Y2om8BhI+BBXM8o24IwyEFOVAbJ9
	 6DDZrdJtryDpOkn0TScv95xjBYKuAaQom3T6s67hk1FezNRypOhHKdh/ZpWaMaCohx
	 8uO6pfgsd8KtuoUxhX/hHicEdoYvaTBX5V3Rkp40=
Date: Tue, 7 Dec 2021 08:52:14 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties
Message-ID: <Ya8SrlbeCdsN7ujX@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.913603962@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.913603962@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:33PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240631.417289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVH6-0004NC-MV; Tue, 07 Dec 2021 07:52:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240631.417289; Tue, 07 Dec 2021 07:52:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVH6-0004N5-JZ; Tue, 07 Dec 2021 07:52:32 +0000
Received: by outflank-mailman (input) for mailman id 240631;
 Tue, 07 Dec 2021 07:52:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVH5-0002w4-Hw
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:52:31 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a0a2902c-5732-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:52:30 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id E5A4DCE1A02;
 Tue,  7 Dec 2021 07:52:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74FDEC341C6;
 Tue,  7 Dec 2021 07:52:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0a2902c-5732-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863547;
	bh=nCz2eprBDDZQ3hphsrTchcKKsptlZR6ElROa48+S3D0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=THSlYZzdDomIjyopvU5UfNwTG47lpNK4jXGRHhOoFNXwX5+imnG0HcAyKtwYLRR5x
	 nrrwNNGJQmDJIgRHihmrMpGobufnGW2QTi+2XkoTvxG8s0uo8t2HjLG/kOjX2Oo5zw
	 Z8t/Sg2MiIE1W7osNN65DigsH0oO3jivQutxb2t4=
Date: Tue, 7 Dec 2021 08:52:24 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
Message-ID: <Ya8SuMnuZ4I64xLh@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.688216619@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.688216619@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
> Store the properties which are interesting for various places so the MSI
> descriptor fiddling can be removed.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240634.417300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVHF-0004pv-VR; Tue, 07 Dec 2021 07:52:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240634.417300; Tue, 07 Dec 2021 07:52:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVHF-0004pm-Rt; Tue, 07 Dec 2021 07:52:41 +0000
Received: by outflank-mailman (input) for mailman id 240634;
 Tue, 07 Dec 2021 07:52:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVHE-0003mG-Ro
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:52:40 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a63dd72f-5732-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:52:40 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 8CED2CE19EE;
 Tue,  7 Dec 2021 07:52:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD0A3C341C3;
 Tue,  7 Dec 2021 07:52:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a63dd72f-5732-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863556;
	bh=Jns8FcBxHOMLCr3GGZxSwFn/tVekTvZv+guY99+MFfA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=uir65K0ep5aarE9hGxWGsofseR98j+pRbK0DipCNkTuXyP22WiN5q+6IOmnGPiHqp
	 21ycEjIM7uPSj/jO0DE+Wz45fS+mqzxzyHn7SMut1l81Hg0Vgtk5/GVANay5ul6ic5
	 XgEH2RJweuBoMloTOAMFAvNVuE2ntOCRjWj7j69Y=
Date: Tue, 7 Dec 2021 08:52:33 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
Message-ID: <Ya8SwexQA8AEC5XI@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.634566968@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.634566968@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:25PM +0100, Thomas Gleixner wrote:
> Add a properties field which allows core code to store information for easy
> retrieval in order to replace MSI descriptor fiddling.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:52:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:52:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240638.417311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVHQ-0005S9-8S; Tue, 07 Dec 2021 07:52:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240638.417311; Tue, 07 Dec 2021 07:52:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVHQ-0005S0-3S; Tue, 07 Dec 2021 07:52:52 +0000
Received: by outflank-mailman (input) for mailman id 240638;
 Tue, 07 Dec 2021 07:52:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVHO-0002w4-8x
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:52:50 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac8636e6-5732-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:52:49 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 51239B816CE;
 Tue,  7 Dec 2021 07:52:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6456CC341C1;
 Tue,  7 Dec 2021 07:52:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac8636e6-5732-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863568;
	bh=vCZmCfds9fGR8KSqYGfBdedJROQkJKaIyrhFh2LFF/g=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=HtoyV3RRzvoi0PrEYpfpDPeITXhIwQvbjxWqx411JpOHn7PGizTjybev6iCzICEYY
	 x7Ns6xV/QcCyjvP8JXB3nGwo7wrEGnRfcS9iW3/uqjpuUAP24nFL5MSwkRYf5HSMjP
	 n2TcEjgXaACoJgRlEa1cjKloYE1WcawlchFz/aAA=
Date: Tue, 7 Dec 2021 08:52:45 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 28/36] PCI/MSI: Use __msi_get_virq() in
 pci_get_vector()
Message-ID: <Ya8SzYpOcsbItjkU@kroah.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210439.181331216@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210439.181331216@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:41PM +0100, Thomas Gleixner wrote:
> Use msi_get_vector() and handle the return value to be compatible.
> 
> No functional change intended.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:54:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:54:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240653.417322 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVJF-0006ZK-Qi; Tue, 07 Dec 2021 07:54:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240653.417322; Tue, 07 Dec 2021 07:54:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVJF-0006ZD-Lf; Tue, 07 Dec 2021 07:54:45 +0000
Received: by outflank-mailman (input) for mailman id 240653;
 Tue, 07 Dec 2021 07:54:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muVJF-0006Z1-7e; Tue, 07 Dec 2021 07:54:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muVJF-0004eu-1B; Tue, 07 Dec 2021 07:54:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muVJE-0002Gy-LL; Tue, 07 Dec 2021 07:54:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muVJE-0007l8-KZ; Tue, 07 Dec 2021 07:54:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1x1QJNVyjOuvhY3l1AOvv+gLq6B1/cxP3d+AYIqfNrU=; b=PKTOjhaUGAmTBFeMKwA9hyQ0Xj
	wlKxMIZXFWjRkkn+08RMa6rEmNFVqHxGLTj6a+e/e4qDjPl/vy++kW1rnTIFBHYtd3PvsKNDsqzed
	ZUc6rVWU0dTvZ7lV/ri3DR2xTA+1/agIrZYSyDKkrUKjzBUQryYJ58K7b/kgLHEN2gXI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167215-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.13-testing test] 167215: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d0e2c2762b981abd984af66a844ac12d8bf8f813
X-Osstest-Versions-That:
    xen=d3c2319ea1657f31ae3899713afc23789b771c10
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 07:54:44 +0000

flight 167215 xen-4.13-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167215/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166345
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166345
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166345
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166345
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166345
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166345
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166345
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166345
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166345
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166345
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166345
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166345
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d0e2c2762b981abd984af66a844ac12d8bf8f813
baseline version:
 xen                  d3c2319ea1657f31ae3899713afc23789b771c10

Last test of basis   166345  2021-11-24 08:56:39 Z   12 days
Testing same since   167215  2021-12-06 15:36:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <ian.jackson@eu.citrix.com>
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d3c2319ea1..d0e2c2762b  d0e2c2762b981abd984af66a844ac12d8bf8f813 -> stable-4.13


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:57:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240679.417351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLR-0007yi-Fh; Tue, 07 Dec 2021 07:57:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240679.417351; Tue, 07 Dec 2021 07:57:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLR-0007yb-C4; Tue, 07 Dec 2021 07:57:01 +0000
Received: by outflank-mailman (input) for mailman id 240679;
 Tue, 07 Dec 2021 07:56:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVD5-0005oY-3N
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:48:23 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c8f6cd5-5732-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:48:22 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id ADCABCE180E;
 Tue,  7 Dec 2021 07:48:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5387BC341C3;
 Tue,  7 Dec 2021 07:48:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c8f6cd5-5732-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863297;
	bh=987va09/dvP0ztOLf5mXiuObxbrtwLhSB7qczYAr3zc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=uaiDHF8b4ZwfaykbIRoAGImv/wOEYnC2OuRRekPTUvnH7Z+KoDN2eitf1+2jyFZYE
	 RW+eyBwNessu97qSLx5/+QRYN5pKkPpJcIjhEtARHEOXbvL32YiTSQMez2rOnMK2aS
	 hmP2VmZeVihGhwMbl5FyYdeY/dLwK2GtNNuHp+J4=
Date: Tue, 7 Dec 2021 08:48:14 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 22/23] genirq/msi: Handle PCI/MSI allocation fail in
 core code
Message-ID: <Ya8RvhfV2j5i0gwg@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210225.046615302@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210225.046615302@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:59PM +0100, Thomas Gleixner wrote:
> Get rid of yet another irqdomain callback and let the core code return the
> already available information of how many descriptors could be allocated.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:57:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240673.417340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLP-0007de-8P; Tue, 07 Dec 2021 07:56:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240673.417340; Tue, 07 Dec 2021 07:56:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLP-0007dD-54; Tue, 07 Dec 2021 07:56:59 +0000
Received: by outflank-mailman (input) for mailman id 240673;
 Tue, 07 Dec 2021 07:56:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVDO-0005oY-62
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:48:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 189eafe4-5732-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 08:48:41 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D954AB80E8B;
 Tue,  7 Dec 2021 07:48:40 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33958C341C1;
 Tue,  7 Dec 2021 07:48:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 189eafe4-5732-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638863319;
	bh=WhRceJhmzxjby5fPejJ6zCulOVcJWw8H5bLGS/3QcH8=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=SWIJfmNGJimxpVxVrmep8jDL+8fq/9M8tTEfUWTU7yrf8FEhCukCMCNYwcchrGZil
	 KTC2GFjwOHm5Vp8ki83GFWK0/anM//KXBF0T7w4Aubbsae5n/x81pWpLxBWXyc+O0d
	 AKTd3slwt1mIBdgwhnTy90iEA7VRwneYulUqX2fg=
Date: Tue, 7 Dec 2021 08:48:37 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 23/23] PCI/MSI: Move descriptor counting on allocation
 fail to the legacy code
Message-ID: <Ya8R1eosQhOZbj1q@kroah.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210225.101336873@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210225.101336873@linutronix.de>

On Mon, Dec 06, 2021 at 11:28:00PM +0100, Thomas Gleixner wrote:
> The irqdomain code already returns the information. Move the loop to the
> legacy code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:57:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240683.417362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLW-0008On-OH; Tue, 07 Dec 2021 07:57:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240683.417362; Tue, 07 Dec 2021 07:57:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVLW-0008Ob-KR; Tue, 07 Dec 2021 07:57:06 +0000
Received: by outflank-mailman (input) for mailman id 240683;
 Tue, 07 Dec 2021 07:57:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVDV-0006RR-9b
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:48:49 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1c98b8a7-5732-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:48:48 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EBE7E212C5;
 Tue,  7 Dec 2021 07:48:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8F3031332F;
 Tue,  7 Dec 2021 07:48:47 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id LBvXIN8Rr2FJIQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:48:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c98b8a7-5732-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=nbxlWVTlTy3CuV+DpdRPRvJPsvZonY4KAsubykk+HbQ=;
	b=FUkTkALvg+RW5OP++45dZkftgiLcfu1x3C8mTAWoa/3foGVSmrcLOFm+wiAA9ijsRtVllx
	fRo96oJD+rLHKu8VC9Sig5aVkBXcmc4fcHMndW1GicxXP8ZXfJJg7Q4WixTr6sMM8cITVz
	h8vxxRq5cxUhkJ6qxJCAxRdaglLQAts=
Subject: Re: [XEN PATCH 07/57] libs/guest: Drop spurious include in Makefile
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-8-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <bad2963a-b9b6-64d8-8347-e13c164eac0c@suse.com>
Date: Tue, 7 Dec 2021 08:48:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-8-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="ZSBlIWqH9pHYIWv5cUp8RlgFwiqqF0ESA"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ZSBlIWqH9pHYIWv5cUp8RlgFwiqqF0ESA
Content-Type: multipart/mixed; boundary="C5ryym8jAIGG1BTDeDLspWi8imnUGJQFc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <bad2963a-b9b6-64d8-8347-e13c164eac0c@suse.com>
Subject: Re: [XEN PATCH 07/57] libs/guest: Drop spurious include in Makefile
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-8-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-8-anthony.perard@citrix.com>

--C5ryym8jAIGG1BTDeDLspWi8imnUGJQFc
Content-Type: multipart/mixed;
 boundary="------------C6D375DACA46ADB5EC2459FF"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------C6D375DACA46ADB5EC2459FF
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> This include hasn't been useful since e567964a54 (tools: drop ia64
> support).
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------C6D375DACA46ADB5EC2459FF
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C6D375DACA46ADB5EC2459FF--

--C5ryym8jAIGG1BTDeDLspWi8imnUGJQFc--

--ZSBlIWqH9pHYIWv5cUp8RlgFwiqqF0ESA
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvEd4FAwAAAAAACgkQsN6d1ii/Ey+i
6wf+LnosLa372cd4cBHGC2oZVnA0sCzXfLG6nUoYHSXVwYOp7JPRzuCDs3RXePI5X+1Px2TcPDBq
Cj4dlNjHMqMdy1+t7r3cVP8wU4Q22jmJ62y+98rgrh8x/vX6IeyQXmXhQVU3U64Q0e10amCVhlpv
GljA3zrl1Q5z+ZJ4cr1wzujRapbRk9z7CnzaqnxAeFGGQNnf5/dfxhGEUtTFwUL/RHGxx+JiTr/5
bePy1CTFdSFxIQyhOKRwlQiPXHodiZP8SoiRNorIBnhMan5nKsvw0Gw6pBLn8d0bdsJhPc152Ezz
MO6S89bgw4BDqbvR0ZaYPcGY9EEPg32vEcl1JewEGw==
=+H9D
-----END PGP SIGNATURE-----

--ZSBlIWqH9pHYIWv5cUp8RlgFwiqqF0ESA--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 07:59:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 07:59:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240701.417373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVNU-0001ES-BA; Tue, 07 Dec 2021 07:59:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240701.417373; Tue, 07 Dec 2021 07:59:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVNU-0001EL-7f; Tue, 07 Dec 2021 07:59:08 +0000
Received: by outflank-mailman (input) for mailman id 240701;
 Tue, 07 Dec 2021 07:59:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVNT-0001EB-4D
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 07:59:07 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8cdd498d-5733-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 08:59:06 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BC7A821B3D;
 Tue,  7 Dec 2021 07:59:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B11713522;
 Tue,  7 Dec 2021 07:59:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kxkgIEkUr2HSJQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 07:59:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cdd498d-5733-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638863945; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vqB/r5oUC4ihpZvER0VbDmVZUkmONsjM58NHWX694lA=;
	b=ou47FsHz81giHD5zDNCcXYYGVGW2TJjOc8zS70pj1xJ84S609EGzQzJSQGSIz00DJdXTsu
	6A8ybNFIL970SlsczcorcwfvOo3yGxOBgh5oPgow/vDGc8JRq1xjWq1bNJxwOtF5E8Lokg
	OHniMMv81gOxi05LGJcPiX1+i5BY8OA=
Subject: Re: [XEN PATCH 09/57] libs/light: Remove -I.
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-10-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <5f149571-8e09-ad07-39de-476b950d456f@suse.com>
Date: Tue, 7 Dec 2021 08:59:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-10-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="QLj8UwdmYMIhQ1NDf00GmhZnD7EkXVm8z"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--QLj8UwdmYMIhQ1NDf00GmhZnD7EkXVm8z
Content-Type: multipart/mixed; boundary="NBJnpyzQAJmcPByioN5MSPgk0EBPx4LTU";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <5f149571-8e09-ad07-39de-476b950d456f@suse.com>
Subject: Re: [XEN PATCH 09/57] libs/light: Remove -I.
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-10-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-10-anthony.perard@citrix.com>

--NBJnpyzQAJmcPByioN5MSPgk0EBPx4LTU
Content-Type: multipart/mixed;
 boundary="------------A4E095518F8E1772E0332A1D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------A4E095518F8E1772E0332A1D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> There is no need to include current directory.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------A4E095518F8E1772E0332A1D
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------A4E095518F8E1772E0332A1D--

--NBJnpyzQAJmcPByioN5MSPgk0EBPx4LTU--

--QLj8UwdmYMIhQ1NDf00GmhZnD7EkXVm8z
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvFEgFAwAAAAAACgkQsN6d1ii/Ey/i
2Af+MOoUKkgDAgFADk+stgyZZ+kSe/O6Cd1xI2ij66AtKYj6nLbJslYyWeFkfilCdnIPh1NixgEn
VwYR4rEIhKu6qqM9FnQS6vFFSEabk5vI+PP8HY0UCivHrF0hlfTK+/65esSuDdSfCrPzMXsvUSv0
DbX5meD2CFiMwvYsav6RkJ/o46063m6zLBUpdY8PQZCiVOnQZ+T91EBqlq9vVOLb0ewHklF6lD3a
ZWLJ/I7Ivek9Fzx2POAfRDiCTRn7ejwHMdBzmdXIhPU3yFUwyUO7k1EQTXTXKo7GGhhAmNjgKjdv
3zc5NWqyS4MyWZZnY2qUCNeayVQVFctZmjY4OhWlwA==
=9mQA
-----END PGP SIGNATURE-----

--QLj8UwdmYMIhQ1NDf00GmhZnD7EkXVm8z--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:01:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:01:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240711.417384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVPP-000398-1Y; Tue, 07 Dec 2021 08:01:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240711.417384; Tue, 07 Dec 2021 08:01:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVPO-000391-T4; Tue, 07 Dec 2021 08:01:06 +0000
Received: by outflank-mailman (input) for mailman id 240711;
 Tue, 07 Dec 2021 08:01:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVPN-00038r-50
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:01:05 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d347e1d7-5733-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 09:01:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 10C031FD56;
 Tue,  7 Dec 2021 08:01:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA4C313522;
 Tue,  7 Dec 2021 08:01:03 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fG8GNL8Ur2H5JgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 08:01:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d347e1d7-5733-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638864064; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SPemss8Z5knZA1HV4QiwKfixim/dwFLA63AQqyfGVoI=;
	b=dZ+RqYqrXz4elxCq+N3V55oq472xYYpoA8p6qRsEvq31kaqMVp1LaLBuvEUd5TKjpYLyde
	KDj1lE9ZPjqYNHtBr+Vc4BExEaBGESc0W0aJlyNG4DFkDtoec7dAtWuKzFHQUbak1b/b9v
	tJzEFzUZc2mD2RkQn6z8F10HnACRm7k=
Subject: Re: [XEN PATCH 10/57] libs/stat: Remove duplicated CFLAGS from deps
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-11-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <9ac570ff-3575-3489-ff0f-7910326f7686@suse.com>
Date: Tue, 7 Dec 2021 09:01:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-11-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="5tJlVDNnmO3n4W04MwqHZAY9Zh6x7uCos"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--5tJlVDNnmO3n4W04MwqHZAY9Zh6x7uCos
Content-Type: multipart/mixed; boundary="he3M2ASL4dzZIfPXymA2stQtqQWbhheWb";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <9ac570ff-3575-3489-ff0f-7910326f7686@suse.com>
Subject: Re: [XEN PATCH 10/57] libs/stat: Remove duplicated CFLAGS from deps
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-11-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-11-anthony.perard@citrix.com>

--he3M2ASL4dzZIfPXymA2stQtqQWbhheWb
Content-Type: multipart/mixed;
 boundary="------------394C938FE61AEBD151407DCA"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------394C938FE61AEBD151407DCA
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> Those CFLAGS_* are already added in libs.mk via USELIBS_stat.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------394C938FE61AEBD151407DCA
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------394C938FE61AEBD151407DCA--

--he3M2ASL4dzZIfPXymA2stQtqQWbhheWb--

--5tJlVDNnmO3n4W04MwqHZAY9Zh6x7uCos
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvFL8FAwAAAAAACgkQsN6d1ii/Ey9g
2wf/ahZTs/d+cTnSjCsu2kGMR73E+qeMRFZaZpD0ZA0k6yYrXKStwpVNYdMZD2YGG9YU+vZifX9r
C5F1HSG/0IyNqv3Q76mEsXG1aZjC3mY8azWqDCHrD0xPMdvH7bbvv+2T8kqNi3BLm9LIUbFNRQV4
dojBPRoeMwMhLNN0gtveSbcmtxj1dI5RsYHUr6Q5czL7LR5fIUFbNAsMdINiA71a/1nHarUOCsCT
krs0Q7gWq+qnsqdIbdVKB925FBajueBQCoz3Oxqz4J5zNEVkvtacrz+VlHVn7VCxRCpmGiK6mH+x
rYE7R4b5XfR+4OmMm0p/xn3S9GlndH8BGf/svOmk4Q==
=YT1X
-----END PGP SIGNATURE-----

--5tJlVDNnmO3n4W04MwqHZAY9Zh6x7uCos--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:05:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:05:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240717.417395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVTP-0003oR-I3; Tue, 07 Dec 2021 08:05:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240717.417395; Tue, 07 Dec 2021 08:05:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVTP-0003oK-EH; Tue, 07 Dec 2021 08:05:15 +0000
Received: by outflank-mailman (input) for mailman id 240717;
 Tue, 07 Dec 2021 08:05:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muVTN-0003oE-VZ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:05:13 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 679a09d4-5734-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 09:05:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C52F31FD56;
 Tue,  7 Dec 2021 08:05:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 97EAA13522;
 Tue,  7 Dec 2021 08:05:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id P32JI7gVr2EHKQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 08:05:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 679a09d4-5734-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638864312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+jxGhxQE/Hd5nSmdWI96OpIadLCncMAgIKCij1KE+JI=;
	b=QDX29MgDr3PuG/DFg46c/UNA5xsTqbsTylioCh7yJn5/INzd6sSaZINEX7+QT2I/qhUQPc
	3sAYGQI2PTo+k1jdMtfiLnxiRX5D/X6UMSNvyDfnOnSuP42wPh8geYRaXTw8SRIvZbQhv4
	rzrlaHNDa5XxYE2dQ/bbsDTaxfXfww0=
Subject: Re: [XEN PATCH 11/57] libs/store: Remove PKG_CONFIG_REMOVE
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-12-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <5c870d5b-0aed-2722-e186-48a6569750bb@suse.com>
Date: Tue, 7 Dec 2021 09:05:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-12-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="6ZjDyU4CtZXx5AYDPZ7vKoGSGBkeXGg6y"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--6ZjDyU4CtZXx5AYDPZ7vKoGSGBkeXGg6y
Content-Type: multipart/mixed; boundary="tdrNuoOR3EY74bWKJmv9hPPsgQTbIhTaQ";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <5c870d5b-0aed-2722-e186-48a6569750bb@suse.com>
Subject: Re: [XEN PATCH 11/57] libs/store: Remove PKG_CONFIG_REMOVE
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-12-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-12-anthony.perard@citrix.com>

--tdrNuoOR3EY74bWKJmv9hPPsgQTbIhTaQ
Content-Type: multipart/mixed;
 boundary="------------7923D05B1E62B798DEA94772"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------7923D05B1E62B798DEA94772
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:01, Anthony PERARD wrote:
> PKG_CONFIG_REMOVE doesn't do anything anymore. Commit dd33fd2e81
> (tools: split libxenstore into new tools/libs/store directory) had
> reintroduced it without saying why.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------7923D05B1E62B798DEA94772
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7923D05B1E62B798DEA94772--

--tdrNuoOR3EY74bWKJmv9hPPsgQTbIhTaQ--

--6ZjDyU4CtZXx5AYDPZ7vKoGSGBkeXGg6y
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvFbgFAwAAAAAACgkQsN6d1ii/Ey8Q
Dwf+IzkMb7nKhujKEHXHZr1KKyhrswWs4Gp7wcOpXzrK2q1ni6GbuUu+GLwNKlvYJSWcaQAyqrsi
3ctNrZcao3QZhph1EPGZSp0JGa5Q0RbIoi0rlpQt7FXqqKxJolOHzGBUcxQcZz0L5wOB7bk23guQ
qhDiEGxdMgsRpIMuZyyeb2S1igIZ/69E7L26hrinHAE+Lk4bkLy7sCtlhNX9B5qWuJZ+CPDTx49V
9M0P/gXbI0LOixND7SSHyfst5CGDqWCpfS0Y4chHg9cbXKOlzmYcu8lx1gergUvARmIUBztEom60
ru0AavQQz3In/DKzmJvv7LOzNp+9XDTP31F5QQPCiA==
=+Csg
-----END PGP SIGNATURE-----

--6ZjDyU4CtZXx5AYDPZ7vKoGSGBkeXGg6y--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:20:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:20:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240725.417406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVhN-0006TP-Qy; Tue, 07 Dec 2021 08:19:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240725.417406; Tue, 07 Dec 2021 08:19:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVhN-0006TI-NQ; Tue, 07 Dec 2021 08:19:41 +0000
Received: by outflank-mailman (input) for mailman id 240725;
 Tue, 07 Dec 2021 08:19:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tPeo=QY=actia.se=jonas.blixt@srs-se1.protection.inumbo.net>)
 id 1muVhM-0006TC-JD
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:19:40 +0000
Received: from mail.actia.se (mail.actia.se [195.67.112.82])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6bdef06e-5736-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 09:19:39 +0100 (CET)
Received: from S036ANL.actianordic.se (192.168.16.117) by
 S035ANL.actianordic.se (192.168.16.116) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.17; Tue, 7 Dec 2021 09:19:38 +0100
Received: from S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69]) by
 S036ANL.actianordic.se ([fe80::e13e:1feb:4ea6:ec69%3]) with mapi id
 15.01.2375.017; Tue, 7 Dec 2021 09:19:38 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6bdef06e-5736-11ec-a5e1-b9374ead2679
From: Jonas Blixt <jonas.blixt@actia.se>
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: XEN CAN Driver
Thread-Topic: XEN CAN Driver
Thread-Index: AQHX6nupqGV1RK1HBkO11DPjYT8S66wlZuuAgAE7SIA=
Date: Tue, 7 Dec 2021 08:19:37 +0000
Message-ID: <92dbcb2a71fa4c25bfea7e802ad4ab21@actia.se>
References: <5a2d079fe8db41338464381dd2dc9575@actia.se>,<e87175c9-bf55-f79a-a910-b94d69aead86@suse.com>
In-Reply-To: <e87175c9-bf55-f79a-a910-b94d69aead86@suse.com>
Accept-Language: en-US, sv-SE
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.11.250.33]
x-esetresult: clean, is OK
x-esetid: 37303A29832D1F50627165
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

>=A0Is the data being sent/received by the domU put directly onto the
>=A0rings, or is it mapped via grant mappings by dom0?
>
>=A0Are all the requests on the rings of the same size?

The data sent from both domU and dom0 are written directly to the rings
 and all requests/responses (CAN Frames) have the same, fixed, size.

>=A0Are the single requests/responses acknowledged by the other side
>=A0(I guess "yes", as I presume this is what you are referring to as
>=A0"flow control")?

Yes, sending a frame from domU will trigger the interrupt handler in dom0
and similarly the other way around.

Frames originating from the physical interface is bound to a relatively
low baud rate but the other way around is only limited by the performance
of the ring buffers. To cope with this we hade to call 'netif_stop_queue'=20
in the front end driver to stall the applications sending frames.
And when there is space available in the ring 'netif_wake_queue' to
resume.


Jonas=


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:21:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:21:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240733.417417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVjK-0007qh-Bj; Tue, 07 Dec 2021 08:21:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240733.417417; Tue, 07 Dec 2021 08:21:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVjK-0007qa-8Y; Tue, 07 Dec 2021 08:21:42 +0000
Received: by outflank-mailman (input) for mailman id 240733;
 Tue, 07 Dec 2021 08:21:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3MF5=QY=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1muVjJ-0007p1-Dh
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:21:41 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b3f4a901-5736-11ec-8a4d-196798b21f7b;
 Tue, 07 Dec 2021 09:21:40 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 68F12B816BC;
 Tue,  7 Dec 2021 08:21:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81803C341C1;
 Tue,  7 Dec 2021 08:21:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3f4a901-5736-11ec-8a4d-196798b21f7b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1638865298;
	bh=81ezBwi4Gw0OWv//xVC704QCQgMXAEKmUfhLMAXppUw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=TH/YlLooPpA9/mTXfGh27VFDaRdFSa+QDNfFyBbpv2TI9gDuVVtgDUvWY1cEHZ1rw
	 d7NMMCdgS2zwfOsO2TgrsfOv17Gvprfvs8AAsKoH3ogS+Y6KSf6urrDcjPRlGlksm6
	 2hRfNjvRT3+8vBz3JNDvM7STpvhCM+Qz+yAn683U=
Date: Tue, 7 Dec 2021 09:21:35 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 29/31] genirq/msi: Add abuse prevention comment to msi
 header
Message-ID: <Ya8Zj+bADtKEISSP@kroah.com>
References: <20211206210600.123171746@linutronix.de>
 <20211206210749.170847844@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210749.170847844@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:49PM +0100, Thomas Gleixner wrote:
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  include/linux/msi.h |   14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -2,6 +2,20 @@
>  #ifndef LINUX_MSI_H
>  #define LINUX_MSI_H
>  
> +/*
> + * This header file contains MSI data structures and functions which are
> + * only relevant for:
> + *	- Interrupt core code
> + *	- PCI/MSI core code
> + *	- MSI interrupt domain implementations
> + *	- IOMMU, low level VFIO, NTB and other justified exceptions
> + *	  dealing with low level MSI details.
> + *
> + * Regular device drivers have no business with any of these functions and
> + * especially storing MSI descriptor pointers in random code is considered
> + * abuse. The only function which is relevant for drivers is msi_get_virq().
> + */
> +
>  #include <linux/cpumask.h>
>  #include <linux/mutex.h>
>  #include <linux/list.h>
> 

Ah, to be young and idealistic and hope that kernel developers read
comments in header files :)

You might want to add this to the driver-api kernel doc build?

Anyway, looks good to me:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:38:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:38:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240739.417427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVyw-00027S-NK; Tue, 07 Dec 2021 08:37:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240739.417427; Tue, 07 Dec 2021 08:37:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muVyw-00027L-KN; Tue, 07 Dec 2021 08:37:50 +0000
Received: by outflank-mailman (input) for mailman id 240739;
 Tue, 07 Dec 2021 08:37:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1gtX=QY=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muVyv-00027F-GP
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:37:49 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id f4589e73-5738-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 09:37:47 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7AB41042;
 Tue,  7 Dec 2021 00:37:46 -0800 (PST)
Received: from [10.57.4.134] (unknown [10.57.4.134])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7BCF3F73B;
 Tue,  7 Dec 2021 00:37:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4589e73-5738-11ec-a5e1-b9374ead2679
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
Date: Tue, 7 Dec 2021 09:37:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 06.12.2021 16:29, Julien Grall wrote:
> Hi,
> 
> On 06/12/2021 14:20, Michal Orzel wrote:
>> to hypervisor when switching to AArch32 state.
>>
I will change to "from AArch32 state".
>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>> "If the general-purpose register was accessible from AArch32 state the
>> upper 32 bits either become zero, or hold the value that the same
>> architectural register held before any AArch32 execution.
>> The choice between these two options is IMPLEMENTATIONDEFINED"
> 
> Typo: Missing space between IMPLEMENTATION and DEFINED.
> 
Ok.
>>
>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>> needs to be fixed.
> 
> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
> 
I would say:
"
The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
if the command passed as the first argument was clobbered,
"
>>
>> Fix this bug by zeroing the upper 32 bits of these registers on an
>> entry to hypervisor when switching to AArch32 state.
>>
>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>> when not passed.
> 
> Which error do you see otherwise? Is it a compilation error?
> 
Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
So basically in all the places where entry is called with hyp=1.
When taking the current patch and removing default value for compat you will get:
```
entry.S:254: Error: ".endif" without ".if"
entry.S:258: Error: symbol `.if' is already defined
entry.S:258: Error: ".endif" without ".if"
entry.S:262: Error: symbol `.if' is already defined
entry.S:262: Error: ".endif" without ".if"
entry.S:266: Error: symbol `.if' is already defined
entry.S:266: Error: ".endif" without ".if"
entry.S:278: Error: symbol `.if' is already defined
entry.S:278: Error: ".endif" without ".if"
entry.S:292: Error: symbol `.if' is already defined
entry.S:292: Error: ".endif" without ".if"
entry.S:317: Error: symbol `.if' is already defined
entry.S:317: Error: ".endif" without ".if"
```

>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>>   xen/arch/arm/arm64/entry.S | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>> index fc3811ad0a..d364128175 100644
>> --- a/xen/arch/arm/arm64/entry.S
>> +++ b/xen/arch/arm/arm64/entry.S
>> @@ -109,8 +109,16 @@
>>    * If 0, we rely on the on x0/x1 to have been saved at the correct
>>    * position on the stack before.
>>    */
>> -        .macro  entry, hyp, compat, save_x0_x1=1
>> +        .macro  entry, hyp, compat=0, save_x0_x1=1
>>           sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
>> +
>> +        /* Zero the upper 32 bits of the registers when switching to AArch32 */
>> +        .if \compat == 1      /* AArch32 mode */
>> +        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>> +        mov w\nr, w\nr
>> +        .endr
>> +        .endif
> 
> So Jan mentioned, the x0/x1 may have already been saved. So you may need to fetch them from the stack and then clobber the top 32-bit.
> 
So I would do the following:
-fetch x0/x1 from the stack
-clobber them
-store them again on the stack

/*
 * Zero the upper 32 bits of the gp registers when switching
 * from AArch32.
 */
.if \compat == 1      /* AArch32 mode */

/* x0/x1 have already been saved so fetch them to zero top 32 bits */
.if \save_x0_x1 == 0
ldp     x0, x1, [sp], #(UREGS_kernel_sizeof - UREGS_X0)
.endif

.irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
mov w\nr, w\nr
.endr

.if \save_x0_x1 == 0
stp     x0, x1, [sp, #-(UREGS_kernel_sizeof - UREGS_X0)]
.endif

.endif

> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 08:56:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 08:56:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240745.417439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWGM-0004xU-8p; Tue, 07 Dec 2021 08:55:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240745.417439; Tue, 07 Dec 2021 08:55:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWGM-0004xN-5V; Tue, 07 Dec 2021 08:55:50 +0000
Received: by outflank-mailman (input) for mailman id 240745;
 Tue, 07 Dec 2021 08:55:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muWGK-0004xH-NO
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 08:55:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77c02bc5-573b-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 09:55:47 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2056.outbound.protection.outlook.com [104.47.9.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-N3Dg35EiP4-P8AOXeCzMZg-1; Tue, 07 Dec 2021 09:55:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Tue, 7 Dec
 2021 08:55:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 08:55:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0082.eurprd04.prod.outlook.com (2603:10a6:20b:48b::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Tue, 7 Dec 2021 08:55:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77c02bc5-573b-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638867346;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sG7RaZ6A5RZ9DFxA9gRnmm0101p8XWqkOvL8Nx8AOoE=;
	b=XIH10GXhr8BwRVCc37ehnqcwJRIRoSHu9hZ1KTAFss+DSDgBcxXkO2A4OH9724lr0kdrOl
	4QToMaqguS1r2atJw5r4ZyAnOYR228urcFxZ7yCazPipg9Ya7jJJVuaVZO9AbuWvvt5fYu
	BWyPYh8SPW+abqqpSA7qyWwBfvS0GpI=
X-MC-Unique: N3Dg35EiP4-P8AOXeCzMZg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=X0vYvspfsRNOf29ypPGlD1hGWHS2eXKJvtgZve3ddH3hFfwE1IR0XR2RcZ2pcdcyowsXZqI6LjMnJ2AcFS5mog15licAFxdsl7SCep42vLhizSewBXa9EUU9kmGLfm9Wyzo5WvZxO9nF+uti9zq/ZDXP9LDPO30faYbqzl+nIEL6uZVyLa/3H3vwmPtwwNhgV5JP/3Cduw2MpZ8KnYJWnUlabE9IBhA29786bENC39BXgA1v9Nlo/wl3zrGUg1EG/2Z31NXOvx/yTp+AeTR5hNh/xKrBu3cpTjt+4Zl42MTIjrXG6xivO/7q9ICfj0I2H8UG0yr9iNuDBeR0k38Lcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sG7RaZ6A5RZ9DFxA9gRnmm0101p8XWqkOvL8Nx8AOoE=;
 b=nhveXZF6v9NFuHr/WcrlAJBuKYnGAjElqsAyEPVfaAhXCaNFR/ZxuBWte1xQqdbSTffM4E22q4bzaWs9vLqbJKFJqs8qVJp24FhWbKUEQ05d2ALrr3qao+Srk8nc9ZGKfoBmo5YjJ5rypuzymmk90nC6iqyB+F7f5HztafVU+F8ixMPiVoTo0PvDWpV9ZmL04xnKTExbF4zFzDYCD/V9ST9fm4CiusZYt2apwEsJFXpnlDAyZ9ciS3IqCvve7QWR8MwhJLN0dl4YqeaG93ESYjPlcfukpMZBCWYAFYTHW+F2roZqd5XalJZnEy5judawdbpLFjrQtVpEMVRVbgxUTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <faf35da3-2b1f-cf36-21e2-69658be7181c@suse.com>
Date: Tue, 7 Dec 2021 09:55:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Ian Jackson <iwj@xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Julien Grall <julien@xen.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
 <25006.15894.801771.928097@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <25006.15894.801771.928097@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0082.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8fabaea3-112e-433f-dd81-08d9b95f59d2
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5744383225F30EE3262BB065B36E9@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	60sJaNUJrQOcfXTZLlhx750Z5gCHY5BEHlHBQiSONqPByH/2rS0oiEljPiwT9fgcFh8Fx7cZhcFwHfN694F2vNxGk/bC9hVzGAcTmdjdf8EOJ/i+1+Rbq0DZiDLUbbjp3JeeZcLSXPN1zWeuGvGlb6rvHxO06VCsTjV/XaFJTjtJOjMdbcRpO7bu2qraZPuAGyyyE6aHI+2Mbigi/9CPoI6CSMkJS0flyO2vixF6vGEz2gnYaP8KMicByLA4CysZCeydj8dNy3P8Cj/1n5CtM7tYAvstqNrH6jTh1k9ips2K8tjTw3rJEpivoJ2muge+3C+NR9kayhwNYhqRRx2EM5DascmWD7Rm2n6vuXFc+2pXyhzrKsKW+H6lAZNUUG8gR0i4bQ2lDg9X1fk55QX51IP7rMM++yBmLZUtolsqm59n0BMCpNeMBIibpddN9u5KSG1XrNz1blM7YLUkGPI9plgRKeaZuWZvdBhv7+WwI+JpmqzYmbfskBNryG8RPbNpNkyisy6oLU6J5magAl+dqwZVgqH7fxnvX41FFFVvYGrYJrXarTQPTjV27f6tQ/BSpbuYfnzCZGlGY+8pBoVc9SrYL61AAWdhBuX3BtY5mAl13a/gY2QhEYfF0aeFp0o6E8rNxg7tEVCnIOcHVO7IC3JsHI7nljV/q6buLGe3vptZWF1igcSHzheZQ6PjCFX9rKXsjiSb0abjD4X08BG2w1o0JM4cLTFN8FT0L6ANff0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(26005)(6916009)(8936002)(53546011)(2616005)(956004)(508600001)(83380400001)(54906003)(4326008)(6486002)(31686004)(8676002)(66556008)(2906002)(316002)(31696002)(36756003)(186003)(16576012)(38100700002)(66946007)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c29DR3lzUVJQOE15TlBTdDFMWm1uWHV3M3BEMjdQdmlLSm1oems5T3RqcGJQ?=
 =?utf-8?B?b0RwMVUzZUdSbG9ZQkZaQVpURzJTVDlzbjZZY3ZZdzl6MCtUaVhFc3lqSzJm?=
 =?utf-8?B?Tk5BTlQ5L0lVRVVwdjkrRy8wTFhCZzh2aUgreFVhQ21TdUxvRm9jc25WSWcx?=
 =?utf-8?B?bEhuRVZCNHBCd2dOTmtYeGt3dFd1c3NKdlFFbmpkbmJjbVFXTVVUSG4xMlY1?=
 =?utf-8?B?SDJoS3I3RDhGQkJiaVo2LzBpM3pzd0FQZE12S2pFcEU0ZHdtVmx6OExnN0py?=
 =?utf-8?B?SlJMNGhSWTEvZGFxYzFSbE5SbFFLWDFRaVZxY3I0MmpHenZMRUVtNlgwdjRu?=
 =?utf-8?B?YWRjNUlQdzFoWU80Y1Vhb01DTmt1WWs0SmRJcXlGNFhndnZJMTFvSCtyZktZ?=
 =?utf-8?B?WkF1amJndnJGY0ZWTnFId2I3elhRd2FFaHVkamFENDN2VldMejE3c2pOVVhG?=
 =?utf-8?B?YjR1YkQwa0tDYVZ1ZVlYT0g4SlU1djVUOWRDeUMvSGlIWmVqM2xPdHVQcHZy?=
 =?utf-8?B?WFpicUx3eFFkd1krZVNrdjVCRm91Yk9WT3BRd25KWjZlZmt4eHZVODZNTnVs?=
 =?utf-8?B?NHB1enl6UG5ZbVMxRUl5eGxzbFpnSmpqQnpreWJRVCtxZDk4bWlMaWVBVFhl?=
 =?utf-8?B?S3MxT29IYkhxWEdIUFZCc0l4Ukl3Q0pLeEJOZVJTaDdEZTZFWVN2allNL0NE?=
 =?utf-8?B?OGVXV1NFRVpXRWppcmJkTzBjWUJ2eTB4bms0K0IxSEtXbkdiSlRVaUZnVFZm?=
 =?utf-8?B?YWRSdmRROXBLMm1iYkpuNnRPWEZ5MEJBaTNBdXdqOHRjbmQrdkltYnczUzIr?=
 =?utf-8?B?cXdRUWxjVXVEVGJuZ2dheDkvYzJuY1hMU2tvSW44QnVXU0lsOUxOSEMxbXdS?=
 =?utf-8?B?V0hJTlRxVXpKTHhhVFJoSkZqOHpQMEd3d01jalIrKzE3V3N5NXdKdUtONVl1?=
 =?utf-8?B?T1N3TVh1TGZmRGRSaDRoQmwvZ1VscVlMWFAzeHErZDFJN2RITmFvZnlBR3ZW?=
 =?utf-8?B?cjNrQW9JN2Q5Y1BvTDNMcTNMMlJ3RUFhclUrV014ajBSS3Q5a2paQSt0WWlW?=
 =?utf-8?B?M0lVVWdCWEZvOGdUZG5ySDVuSzVHWTN3Ymg0TDZPcit1dU9vQnNCaWMxTlBT?=
 =?utf-8?B?cUExYVYwbUdtWkQzNWJ4cnMrUUpNbmVuaGFCYXpZNVV6a3R2S1FYcHV3aGdM?=
 =?utf-8?B?QzE1RkMvUi9XemhibHFvNFR5dFE1TU1KcTVPSWYwY28zMksxdEZLSG9yeVd1?=
 =?utf-8?B?Z3lnQ01VU2Q4T1lWV3Y4MDRJUWlza2lYSW9BZS9mU2x5cUJENll2TGhjbnF1?=
 =?utf-8?B?bVpJQWRsRSthNGF1MVdLb0V2b2dsKy9iZTVwYUJSRlZHRXNNYmtVRmRhdE9a?=
 =?utf-8?B?TGNzNEp5WWRxUlpkMldYbmowbXZrYU5FK1BKZmhKQ0Y1cjBlQXNSNmdSdXBX?=
 =?utf-8?B?cUdyWUFYaTdZaW9ZSkdyR1cwYlBpTmpwTTRXVDNaSkI0RXVlQjltSnp3OUZX?=
 =?utf-8?B?eFBTUFhMalY4bEVIdWhUdURraERYWENKYi9JNlVNRzF3S3J4anczUUgrWGkz?=
 =?utf-8?B?VW96Q01ocXBNY1lOME5INW1FZlprMUplZHJVMXlWL09TOWpOVVZJQllSblVE?=
 =?utf-8?B?YUdCT0hodmhEQ3NpSDQzMm5IbjhKS2ZlLzhlZEhqMnFwV3Bkb3hEUDVHY1JY?=
 =?utf-8?B?L3hzOWJNV0dvdERBRC9wN3NvMDlMVjVldHhIOWNCRkF3YjZ3QlNCMDJ1TFhU?=
 =?utf-8?B?NDVaNlhuK3NMNXRPYUxTcitZS3RiN1JQbnZSNGJqemx5c0Zzb3NNUXlwS3k3?=
 =?utf-8?B?UDFKeGozYjl6alZnNmhaRkE4ZXo2bXhic2I3S1V4NGFGR3A1eDdZRkYrSlBQ?=
 =?utf-8?B?bFhIeUs3THc4VUV1RHNnamNnWndBS3ltRE9sRTFYODFNbDlQbnVNUDFMUXI5?=
 =?utf-8?B?WlplMG8xVU05SC83QXRpeGtYbFdodFRkZFRiWmwwMG9BZWRJeDdDWUV5Ny9H?=
 =?utf-8?B?RzRSdHVjSGduL3MvcU5vMUx4K1JRSkxxazFOOHA2VTdlRmhvenlWZUxhWjVW?=
 =?utf-8?B?NHpYOFo0Z0FQUUlRQzZ1Mmtjd3BSbVBtamZqVmxpZzhvb0hRYVF2WVhJOW1I?=
 =?utf-8?B?aEpvc1RWNUszNndwMWRBaWJucXVoZ3NZeTN0RTlaTVJVOGpwWkpRdXpYb1gw?=
 =?utf-8?Q?BlH2zhCGS/Zb6OjkDp7IGqI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fabaea3-112e-433f-dd81-08d9b95f59d2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 08:55:43.1987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RzCe3Unour7PCFWWPpTvaNYrFeaQYHjjmMubo0qDmWPqJXVOLIiiN+XuFq3ReZClOdYhjatoB4DwF3Li9fJMEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 06.12.2021 17:45, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>> On 06/12/2021 16:12, Jan Beulich wrote:
>>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>>> going as far as minimally necessary. I therefore wouldn't call this an
>>> "open objection".
>>
>> I believe my objection is still open. I still have have no way to verify 
>> what you did is correct.
> 
> I can't believe this is still outstanding.

Same here, hardly surprising I suppose.

>  I think I understand
> Julien's position, and I agree with what I have understood.
> 
> In particular, I think I understand why Julien feels it necessary to
> make an issue of this.  The Signed-off-by lines are there to help
> provide assurance that we aren't making legal mistakes.  They need to
> be verifiable by a reviewer.  So that means that when a patch's own
> declaration of its origin is "this patch came from Linux commit XYZ"
> then all the S-o-b in that Linux git commit should be retained.
> 
> If the patch came from somewhere else, eg a mailing list post, I think
> it would be OK to say something like "this patch came from lmkl, [url
> to posting], and has since been committed to Linux as [commitid]~".
> In that case the S-o-b should match the mailing list posting, but the
> Xen patch being posted must then be identical to the mailing list
> posting.
> 
> IOW it should be a deterministic process to start with the patch's
> declaration of where it came from (or which sources it came from), and
> verify that 1. the patch really did come from there and 2. all of the
> approriate tags, especially S-o-b, are present.
> 
> By far the easiest way to achieve this is to take the patch from Linux
> git using (eg) git-cherry-pick.  git will automatically DTRT. [1]

It may be the easiest way, and I do understand Julien's replies in this
regard. This doesn't, however, mean that I agree the "easy" aspect
weighs higher than my view on stripping parts which aren't meaningful
in our tree (or, to be precise, which I think aren't meaningful; I will
leave it entirely open that I may be wrong with this).

As to git-cherry-pick: Just like I would have expected, even after
adding Linus'es tree as a remote this doesn't really work, due to the
different tree layouts:

$ git remote add --no-tags linus git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

$ git cherry-pick 83d3c4f22a
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 73569 and retry the command.
error: could not apply 83d3c4f22a36... lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

$ git status
On branch smoke
Your branch is up to date with 'origin/smoke'.

You are currently cherry-picking commit 83d3c4f22a36.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

        deleted by us:   lib/decompress_unxz.c
        deleted by us:   lib/xz/xz_dec_lzma2.c

no changes added to commit (use "git add" and/or "git commit -a")

To adjust for our tree layout, manual intervention is necessary anyway
(unless there's a way to get "inexact rename detection" to actually
recognize the differences). What I take as a basis (git-format-patch
output or anything else) should be entirely up to me, I would say.

> I don't have as strong an opinion about other tags, eg ones indicating
> approval in Linux.  However, I think the overwhelming majority of
> people would think it conventional to transfer all of the tags from
> the original commit even if they are irrelevant in the new context.

Well, clearly I'm not part of this overwhelming majority then: I continue
to think that irrelevant things would better be omitted for clarity.

> I don't understand Jan's position.
> 
> Jan, why are you fighting so hard to delete these tags ?

Counter question: Why are you and Julien fighting so hard for the
retaining of what I consider inapplicable information? But to answer
your question: Just like I consider missing information a problem, I do
also consider meaningless data a problem. Plus of course there's now
the psychological effect resulting from already having invested far
more time here than I think any one of us should have invested: I now
absolutely want to understand whether I have been doing things wrong for
years. As said, me doing what I have done here hasn't been a problem
before.

It's still not clear to me whether I'm doing anything wrong in the first
place - my question as to why these tags are relevant in our trees has
remained unanswered. I've actually taken the time to dig out "Developer's
Certificate of Origin 1.1" - from all I can tell my submission matches (b)
(and that's imo true even for v1, i.e. before re-adding some of the tags
to match the submissions according to mailing list archives, as far as
entries are available).

In this context I'd also like to point out that unlike Linux we don't
normally make use of (c).

> What practical harm does its presence do ?

I did answer this one earlier on as well as above: I consider their
presence inapplicable. There's no severe "harm", but there's also no
reason I know to keep them. Unless I'm told of a reason, I view it as
the submitter's choice to keep or strip such. In fact, if I saw an
import which had such seemingly stray tags, I probably wouldn't insist
on stripping them, but I might question their presence / applicability.

> [1] Jan, I know that you don't use git very much.  I think this is a
> great shame.  I find it perplexing to see how anyone can work without
> it.  The git command line UI is indeed terrible, but by now almost
> everyone has either bitten the bullet of learning it, or adopted one
> of the overlay UI packages that now exist.  (Personally I did learn
> the cli but am starting to forget git cli nonsence since now I do
> almost everything with magit inside emacs.)
> 
> I think the time has long passed when it is reasonable for a key Xen
> developer to ask others to do additional work, or deal with anomalies,
> in order to accomodate an unwillingness to use git.  Obviously we all
> have our own workflows, but git has heavily influenced our shared
> norms (and data formats).  If someone chooses not to use git, they
> must at least be able to pretend.

I appreciate (yet don't share) your view, but primarily I'm afraid I
don't view this rant as relevant in this context. Even if I had found
a way to do the import entirely via git commands, I likely would have
edited the description to strip tags alongside adding my S-o-b (the
latter I understand I could have git do for me). Since git-cherry-pick
didn't work for me here, I also can't tell whether the usual
"(cherry-picked from ...)" that git can be told to add would actually
have identified the different tree, or whether I would have had to add
that to make the referenced hash meaningful.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:04:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:04:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240751.417450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWOr-00070s-57; Tue, 07 Dec 2021 09:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240751.417450; Tue, 07 Dec 2021 09:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWOr-00070l-1f; Tue, 07 Dec 2021 09:04:37 +0000
Received: by outflank-mailman (input) for mailman id 240751;
 Tue, 07 Dec 2021 09:04:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7Lsp=QY=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1muWOp-00070M-EL
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:04:35 +0000
Received: from smtpout1.mo529.mail-out.ovh.net
 (smtpout1.mo529.mail-out.ovh.net [178.32.125.2])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b212f59c-573c-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 10:04:34 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.108.1.10])
 by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 6A935D049F4A;
 Tue,  7 Dec 2021 10:04:32 +0100 (CET)
Received: from kaod.org (37.59.142.106) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec
 2021 10:04:31 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b212f59c-573c-11ec-a5e1-b9374ead2679
Authentication-Results: garm.ovh; auth=pass (GARM-106R0069db82c91-8ffc-40c1-834f-54b27e3d161a,
                    EDCC1E77E28A65BD51DFCD2B92BF934EEA10E5FB) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 82.64.250.170
Message-ID: <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org>
Date: Tue, 7 Dec 2021 10:04:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
	<ashok.raj@intel.com>, <linux-pci@vger.kernel.org>,
	<xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>, <iommu@lists.linux-foundation.org>,
	<dmaengine@vger.kernel.org>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
	<kristo@kernel.org>, <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
	<robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.634566968@linutronix.de>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <20211206210438.634566968@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [37.59.142.106]
X-ClientProxiedBy: DAG7EX1.mxp5.local (172.16.2.61) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: 54d35201-a336-42e9-8bf0-607650fe0e93
X-Ovh-Tracer-Id: 2567051788950997986
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrjeehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepieegvdffkeegfeetuddttddtveduiefhgeduffekiedtkeekteekhfffleevleelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepohhkrgihrgeskhgvrhhnvghlrdhorhhg

Hello Thomas,

On 12/6/21 23:39, Thomas Gleixner wrote:
> Add a properties field which allows core code to store information for easy
> retrieval in order to replace MSI descriptor fiddling.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V2: Add a setter function to prepare for future changes
> ---
>   include/linux/msi.h |   17 +++++++++++++++++
>   kernel/irq/msi.c    |   24 ++++++++++++++++++++++++
>   2 files changed, 41 insertions(+)
> 
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -4,6 +4,7 @@
>   
>   #include <linux/cpumask.h>
>   #include <linux/list.h>
> +#include <linux/bits.h>
>   #include <asm/msi.h>
>   
>   /* Dummy shadow structures if an architecture does not define them */
> @@ -153,6 +154,22 @@ struct msi_device_data {
>   
>   int msi_setup_device_data(struct device *dev);
>   
> +/* MSI device properties */
> +#define MSI_PROP_PCI_MSI		BIT(0)
> +#define MSI_PROP_PCI_MSIX		BIT(1)
> +#define MSI_PROP_64BIT			BIT(2)
> +
> +#ifdef CONFIG_GENERIC_MSI_IRQ
> +bool msi_device_has_property(struct device *dev, unsigned long prop);
> +void msi_device_set_properties(struct device *dev, unsigned long prop);
> +#else
> +static inline bool msi_device_has_property(struct device *dev, unsigned long prop)
> +{
> +	return false;
> +}
> +static inline void msi_device_set_properties(struct device *dev, unsigned long prop) { }
> +#endif
> +
>   /* Helpers to hide struct msi_desc implementation details */
>   #define msi_desc_to_dev(desc)		((desc)->dev)
>   #define dev_to_msi_list(dev)		(&(dev)->msi_list)
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -60,6 +60,30 @@ void free_msi_entry(struct msi_desc *ent
>   	kfree(entry);
>   }
>   
> +/**
> + * msi_device_set_properties - Set device specific MSI properties
> + * @dev:	Pointer to the device which is queried
> + * @prop:	Properties to set
> + */
> +void msi_device_set_properties(struct device *dev, unsigned long prop)
> +{
> +	if (WARN_ON_ONCE(!dev->msi.data))
> +		return ;
> +	dev->msi.data->properties = 0;
It would work better if the prop variable was used instead of 0.

With that fixed,

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> +}
> +
> +/**
> + * msi_device_has_property - Check whether a device has a specific MSI property
> + * @dev:	Pointer to the device which is queried
> + * @prop:	Property to check for
> + */
> +bool msi_device_has_property(struct device *dev, unsigned long prop)
> +{
> +	if (!dev->msi.data)
> +		return false;
> +	return !!(dev->msi.data->properties & prop);
> +}
> +
>   void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
>   {
>   	*msg = entry->msg;
> 



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:06:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:06:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240755.417461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWQH-0007eJ-KO; Tue, 07 Dec 2021 09:06:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240755.417461; Tue, 07 Dec 2021 09:06:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWQH-0007eC-HG; Tue, 07 Dec 2021 09:06:05 +0000
Received: by outflank-mailman (input) for mailman id 240755;
 Tue, 07 Dec 2021 09:06:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XoCv=QY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1muWQG-0007e1-8l
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:06:04 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061f.outbound.protection.outlook.com
 [2a01:111:f400:7d00::61f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e679b9d3-573c-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 10:06:03 +0100 (CET)
Received: from AS9PR07CA0006.eurprd07.prod.outlook.com (2603:10a6:20b:46c::7)
 by AM7PR08MB5429.eurprd08.prod.outlook.com (2603:10a6:20b:107::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Tue, 7 Dec
 2021 09:05:55 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46c:cafe::71) by AS9PR07CA0006.outlook.office365.com
 (2603:10a6:20b:46c::7) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.10 via Frontend
 Transport; Tue, 7 Dec 2021 09:05:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 09:05:55 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Tue, 07 Dec 2021 09:05:54 +0000
Received: from 40c1921baeb0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C40CF705-44DC-4F8E-9927-B4323BF2E7CE.1; 
 Tue, 07 Dec 2021 09:05:38 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40c1921baeb0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 09:05:38 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB6488.eurprd08.prod.outlook.com (2603:10a6:20b:33b::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 7 Dec
 2021 09:05:37 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 09:05:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e679b9d3-573c-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YEVkiamDVoDRwfudyT0jX18QfFxCRyHFQ/tZDB0terA=;
 b=GKctq2/n5J4ecHq9pEB2Apg6Z893HWHOv1uluuWoiB1SIIkhtB8ocqZQxuhYSpPcW9xH8WQXV38NPVeAKyKbKm5uTqV2HbiHeRxDBxx+cCX30A+n1G+AabOUrjww+3T3O/xg9sH+wjd2V3PAFk5MRVGdiDvoRC99mMkexj4F+ew=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4bee03f595b99f2c
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cON0Cetcx0Mq+9Tmm13DCPnrPubDZDiLoALRku2pnEdq50ExgM/oZp7s1rdC/fGMt32rEQqpmUD2c/bZxqQxwSq/Ko/d8/nJbfcA4wl7kCIoo54v7l6NVJIJM7+bc1gypqqnvdODwHv+D7VbiK6soHf0cdOCfJs6+azB05DgTtdH9evYjaHrkKyIAy+c0ZX3qbN8VI9dGPYMRPh4W4C6b8MYbGbljKbHppcPnSmElF8etPiAHEqBGnUSQkPwcIzk4Feub0HB+6p2Unvq8YVebkiGf/WkZa9SKmNgTRo8Th6poIiMVP8KX5aUFdYFg8tmw+a59tF2GJ0Edrh2658ZJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YEVkiamDVoDRwfudyT0jX18QfFxCRyHFQ/tZDB0terA=;
 b=Xko1+Ba5GKrS8im3WvfPdC+tQG6OElKWZ/sREbQqtR7GeTi1tOYMdslRaVuP41qE8XKxmB+e5I8Oxho5/mtmqr0gMA36+4UspfgqRa/GQq43h6IGpu8Wod8LuhNk18ym3mWuqtimo/+Fpra4SAqfr5jXa2EWjlSxlJrYxoLW4Bxz2P8cj47kzw1zI3Xoz1ABV20Y2IkJzBjQ93G52vCeWgRbRXViy+evTp3QhjswF+xh44qTTVPEuzc2cGH0VWU8SwcRmjjIJI93dNiM5yqoGwLtZSnNwtPcWJmYhgzVzMF2uAZHpLnlAUy5ckY2B3dcZvFHvI5fecJgEVC81PhUoQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YEVkiamDVoDRwfudyT0jX18QfFxCRyHFQ/tZDB0terA=;
 b=GKctq2/n5J4ecHq9pEB2Apg6Z893HWHOv1uluuWoiB1SIIkhtB8ocqZQxuhYSpPcW9xH8WQXV38NPVeAKyKbKm5uTqV2HbiHeRxDBxx+cCX30A+n1G+AabOUrjww+3T3O/xg9sH+wjd2V3PAFk5MRVGdiDvoRC99mMkexj4F+ew=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Michal Orzel <Michal.Orzel@arm.com>
CC: Julien Grall <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Thread-Topic: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Thread-Index: AQHX6qyDTBkoC5USbUmFbZl4CKl6k6wllqcAgAEfZ4CAAAfKAA==
Date: Tue, 7 Dec 2021 09:05:36 +0000
Message-ID: <286D9F99-A264-4BED-89FD-8562A1B96133@arm.com>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
In-Reply-To: <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 1dd77c67-7408-4be1-1d71-08d9b960c6be
x-ms-traffictypediagnostic: AS8PR08MB6488:|VE1EUR03FT017:EE_|AM7PR08MB5429:EE_
X-Microsoft-Antispam-PRVS:
	<AM7PR08MB54293B63FC97C244A0C1E9039D6E9@AM7PR08MB5429.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 jPv/9OzLIUV/dTE/LFKO4/81d42l2cpcsubH0gSSG05JUD9XvhTSQpZUIZ94XaiBdwYtnfpgOIHdaYq7RbfgHJU/aSfmnTEZYdEOKXd1m8/DYYivqSrBjn9w2TJi0y8zDpC2T+RTWyN8BHmrEPwkGW7ULj+kfwmtXGo6UIGJf3whXDY0Gbmk2klZzfel1/UdEfDBMIbVhioEe5AyS64Rbd6YUpgMNBqm3PiPNT+ryQQaumGvsuRUxqytS98gkIIKrFQVtsqLXjAYy111sGQPBQ/HP97xuRZdidWUXSIgGw4oglJnypR0llJLnqWOrlLFdACaErKenWFq99f4i+PGmZw/UiI/oqgJGEKlJLloEFw+61ikpLQwofSwpyTVI+W4Oaq2ARpOOzBEVWZJdECQgerqD7WTUIvCU8cfb+7iKdA+NDwOGgjedLSLOwnjv3nbdr+iymH9zTDhsaUJEuorDQWzCcjkAUw9wTV8JdtFobTpf2jR/we+cCorJYknXw5RdQtSeOR3yG2CFP/YTl33gn8u3StebL+BvrAYfx7oGCoxZ7m4tZl1E41tGm9wgMCCPFe5vvpSQzT42HQdn8XcVP39vY3cKe5SMJBniSzNDJ03PIE9RUHalc69iy79kqqaa2jPz/pvbZPU0edIF8urX/hS/rilMSPWCrBePJxigPH4ayR1oVo9vBJpHG4e4cA+geLeYV8hrlYMdiE37V5ctVEeznMvMTJE9Y0GkDa/PtGqsmkx2hD4RYyR+aBWGw5S
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(6506007)(66556008)(71200400001)(66476007)(508600001)(5660300002)(83380400001)(2906002)(53546011)(8936002)(6486002)(8676002)(4326008)(64756008)(316002)(36756003)(54906003)(6512007)(91956017)(122000001)(66946007)(6636002)(86362001)(66446008)(186003)(38070700005)(6862004)(76116006)(2616005)(33656002)(37006003)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AC44F8092712194E9D60263E249C2B00@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6488
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	4903412e-e72e-4495-9830-08d9b960bbdf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	TFgueXYnG/sRXXnO33KvKI1egRELmAIJWDQNdzA2F9UL1QM1yEG7j5y/PUk3fW/b5eVUfSTTXPD+PkLX+nqHjtBuvJVJoWZUWwd4k/UPV5S76MUVa1w/IVClJQoQ79fXU7WGl+HrHr4xxm9Tbc2Qnr6C8T7W6h8EZQfCEqPmCXrl/3UqbnRePFcaEqoKkwllPeKe0qnHOhkGPn24T8Q3d9o8igAvFlQ1G30pnyCmtwwMjQpIpo1LKk9/Ks1xaUkSlhimaYJYAdVFDEQdhfbDxaUVOPo/Thde5MAxqhzVPgO7bRXTbplrokq3TftK8mxgG2hm/iPp9U7RbDvMPIlmzawWcQALh9cAlVU4T51yuX9rjdiEgntsKjG83FbPeC23j66tFmR0gH+4AEW+hhUcp8p85IpV1YkVMzZfbWywBW8qN51GJhspiEc1eoXNS0EIHvomDalFtygTqTt6kFi7TNNv3nKbTUnnsZkw6J/IGqC9YxwvJAw/aNgBph1xjxR+nmF3snBm5rxbZiAWCEvDbRk8rEvXpB7c+cqpH0t35zDMflCf6njcldzTNijkmHOZwJt4BTA4kZrG2QbfUNRpMb7j7J9xxN2NligCqy7eI5OA0cJNcdxziCcu7urWYd1QcLgtH27V83V6e13zKrcAOLcE/d0bB98Bw6ZjzX2gwEMR1O9n4pKDRaojuBJWAAbYrulLDrRJVw/lC+hoaQV1RA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400004)(53546011)(6506007)(47076005)(26005)(186003)(83380400001)(70206006)(508600001)(6512007)(2906002)(6486002)(107886003)(316002)(37006003)(54906003)(6862004)(70586007)(4326008)(81166007)(336012)(356005)(5660300002)(33656002)(8936002)(8676002)(2616005)(86362001)(6636002)(36860700001)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:05:55.0889
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd77c67-7408-4be1-1d71-08d9b960c6be
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5429

Hi Michal,

> On 7 Dec 2021, at 08:37, Michal Orzel <michal.orzel@arm.com> wrote:
>=20
> Hi Julien,
>=20
> On 06.12.2021 16:29, Julien Grall wrote:
>> Hi,
>>=20
>> On 06/12/2021 14:20, Michal Orzel wrote:
>>> to hypervisor when switching to AArch32 state.
>>>=20
> I will change to "from AArch32 state".
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>=20
>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>=20
> Ok.
>>>=20
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed.
>>=20
>> Can you outline why this is a problem and why we need to protect? IIRC, =
the main concern is Xen may misinterpret what the guest requested but we ar=
e not concerned about Xen using wrong value.
>>=20
> I would say:
> "
> The reason why this is a problem is that there are places in Xen where we=
 assume that top 32bits are zero for AArch32 guests.
> If they are not, this can lead to misinterpretation of Xen regarding what=
 the guest requested.
> For example hypercalls returning an error encoded in a signed long like d=
o_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
> if the command passed as the first argument was clobbered,
> "
>>>=20
>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>> entry to hypervisor when switching to AArch32 state.
>>>=20
>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>> when not passed.
>>=20
>> Which error do you see otherwise? Is it a compilation error?
>>=20
> Yes, this is a compilation error. The errors appear at each line when "en=
try" is called without passing value for "compat".
> So basically in all the places where entry is called with hyp=3D1.
> When taking the current patch and removing default value for compat you w=
ill get:
> ```
> entry.S:254: Error: ".endif" without ".if"
> entry.S:258: Error: symbol `.if' is already defined
> entry.S:258: Error: ".endif" without ".if"
> entry.S:262: Error: symbol `.if' is already defined
> entry.S:262: Error: ".endif" without ".if"
> entry.S:266: Error: symbol `.if' is already defined
> entry.S:266: Error: ".endif" without ".if"
> entry.S:278: Error: symbol `.if' is already defined
> entry.S:278: Error: ".endif" without ".if"
> entry.S:292: Error: symbol `.if' is already defined
> entry.S:292: Error: ".endif" without ".if"
> entry.S:317: Error: symbol `.if' is already defined
> entry.S:317: Error: ".endif" without ".if"
> ```
>=20
>>>=20
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> ---
>>>   xen/arch/arm/arm64/entry.S | 10 +++++++++-
>>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>>=20
>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>> index fc3811ad0a..d364128175 100644
>>> --- a/xen/arch/arm/arm64/entry.S
>>> +++ b/xen/arch/arm/arm64/entry.S
>>> @@ -109,8 +109,16 @@
>>>    * If 0, we rely on the on x0/x1 to have been saved at the correct
>>>    * position on the stack before.
>>>    */
>>> -        .macro  entry, hyp, compat, save_x0_x1=3D1
>>> +        .macro  entry, hyp, compat=3D0, save_x0_x1=3D1
>>>           sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP,=
 LR */
>>> +
>>> +        /* Zero the upper 32 bits of the registers when switching to A=
Arch32 */
>>> +        .if \compat =3D=3D 1      /* AArch32 mode */
>>> +        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,2=
1,22,23,24,25,26,27,28,29
>>> +        mov w\nr, w\nr
>>> +        .endr
>>> +        .endif
>>=20
>> So Jan mentioned, the x0/x1 may have already been saved. So you may need=
 to fetch them from the stack and then clobber the top 32-bit.
>>=20
> So I would do the following:
> -fetch x0/x1 from the stack
> -clobber them
> -store them again on the stack
>=20
> /*
> * Zero the upper 32 bits of the gp registers when switching
> * from AArch32.
> */
> .if \compat =3D=3D 1      /* AArch32 mode */
>=20
> /* x0/x1 have already been saved so fetch them to zero top 32 bits */
> .if \save_x0_x1 =3D=3D 0
> ldp     x0, x1, [sp], #(UREGS_kernel_sizeof - UREGS_X0)
> .endif
>=20
> .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,=
25,26,27,28,29
> mov w\nr, w\nr
> .endr
>=20
> .if \save_x0_x1 =3D=3D 0
> stp     x0, x1, [sp, #-(UREGS_kernel_sizeof - UREGS_X0)]
> .endif
>=20
> .endif

This solution looks ok. X0 and x1 when they are used is as scratch register=
 for x1 or using w0 for x0 so it is ok to clean them here and not earlier.

Cheers
Bertrand

>=20
>> Cheers,
>>=20
>=20
> Cheers,
> Michal



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:11:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:11:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240764.417472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWVe-0001DF-8B; Tue, 07 Dec 2021 09:11:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240764.417472; Tue, 07 Dec 2021 09:11:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWVe-0001D8-4K; Tue, 07 Dec 2021 09:11:38 +0000
Received: by outflank-mailman (input) for mailman id 240764;
 Tue, 07 Dec 2021 09:11:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muWVc-0001D2-FU
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:11:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ad10df8a-573d-11ec-a5e1-b9374ead2679;
 Tue, 07 Dec 2021 10:11:35 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2050.outbound.protection.outlook.com [104.47.10.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-TsF6bkWjMcu4G8pBlFDkQw-1; Tue, 07 Dec 2021 10:11:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5597.eurprd04.prod.outlook.com (2603:10a6:803:dd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 09:11:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 09:11:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P194CA0016.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::29) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Tue, 7 Dec 2021 09:11:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad10df8a-573d-11ec-a5e1-b9374ead2679
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638868294;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UPPUUREz0lISL/bigAXGQCVL6O9JLLrIFV40C06te4k=;
	b=Fsl7NbV79OUm19eCuy+krC6g5ZMZM/VHcRLB90NQFQWhbTC7CJUkaza3g1MwUct19lQQYw
	Zh4CSAwaHrthhnyrqPJhJa6s3gnwGRUEGZ0wIhces4ZpkAuCHN2YSVmqvZgGCt0/RKpMsY
	FKsouzVrshXmJq2DCTb2mZHE0iBkthM=
X-MC-Unique: TsF6bkWjMcu4G8pBlFDkQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z1C7FqhUyEAgmcvLck0s138GVaoEbppUqn/UITlENKYMWXOBW86E+piUVX1ZNkcWxOY+3t+r5qZWCTOAAfGD5LxhDh/N8r04FocG9xhX6Npvk30+9Lfe84DWf7Vb71Ahn6sV02jwjJqztXEr5U7g6Cnjl2fOOb5PMQDItb1jbizl/DIcMqaRZXN967myqAExATutnYn7GJGI2+KgR5cLdpBDEWvztSxQTd9hJWEEVGyDoODC8r1zXwM9jSF1biPUR0sidN2O7yVKu8oaAz9fseOfBQbuaOIQUha2Yoe/Ioso+VLVsSpHQbE6FsNyTonPpku5Ko+VMR7kDn5Bc5G5gA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UPPUUREz0lISL/bigAXGQCVL6O9JLLrIFV40C06te4k=;
 b=MYNKDrcqzJJobp6rAtBzhjSeejD01lzv10+craldjSBEUme/H+qGMrfi2O5Nqoeoa0BC6bPV97B3rStYoWFVoYaf4+rDt4YHLNuQlpcBIwv1B70Sn5BF9tio9UnORfTqhuDZ0M9g3I4MnCtkhLRpUlqBfcwPmJsdJnBKusHvfYD7+1M2bp1yrsI+Iop2Axvt5GoGhdkCAxADdJ1xUxq95EO6G7YLDYrCWXY8CTFme99ZGMQ776txoPKZtSoT0F0+hbZchm9Uw62cAhIEkb8wVIkZBGAqx2NHkPt6OVb+nS29JYl1lGVHRtxKr2/+NbcnDUhypfNqOPkz95bi+kudcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
Date: Tue, 7 Dec 2021 10:11:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0016.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c4f8654-be48-41d0-444e-08d9b9618ec6
X-MS-TrafficTypeDiagnostic: VI1PR04MB5597:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55973967D7C94365D072F6D7B36E9@VI1PR04MB5597.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dWcTHfDs/kcyVOgOY47etHOAY8hTuzBYbOYeIWVgi12vYuWsbiNexhjAtmxOiyOhpBkRvfj4IlYgROlqlFEGD55ub9xu/8a2t+uKW0yiwEHCPz2uI+TRC5VX7sjwAcatWw6EVLFqXEjm5KfMrWt0xmX47k2SUs//C0TZviarz6O2TfHoP00W07sdsiRBbN2kLUMIO9XDspKJR9uSZL8gfXK6c0gUqYueOqEHOPVZiNHNrPYbmkAUYAs8qSI2fPQ6cOHsngjXjcyHwHsD/zZt9LNo9UKw2247RNPKpdm8+Hayv0zwazukoS+dd6nGRPWiaNTOxBxCBFO2t0cO6hXjhDGev8yItYCutXfItRm2AfDknLccZyR+7m0A/vTLdkrpjmoY1m8vqySoiF6tpSSxj4zwur3whEnBQFXi0My7AC8wa2ZDSjtNT+NKYigqp3UaNwAUPN+JEuX3k34eYmYodile9E0l4ybb5ctIErXzJstOh/6LoWubxMiPStiY7w2RsxQuCiMBvDH4iYaanbyF/9c7NBnaQBKvQYiXyB4QT9Ht216CeUpVOogNIXsXBGobyGUtxYDQpVMNijaUDI6s8KZvF/a2JYx80e5DYmQdPu+OUVew8r+xBix5ZnDn+gBIN1bXKOJcr8QUUSwQ/FQvs+runZovj2120uRCb2yhgeucdbHBmNxWavaLQP897/HPYtTlahVmz8zgayzZz+0xXKGo2VfeNcTT1PwtQ75oTaxtpV7tIV0GJ9gHcd9fVOEhusEgvrYCFM6TI/ps1toaxgs596d1AZf7qGd/3iiXjkQKpYyz3NexHJh+DEE3C2gQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(53546011)(5660300002)(31686004)(508600001)(186003)(966005)(26005)(6916009)(2906002)(8936002)(36756003)(66946007)(66476007)(54906003)(66556008)(8676002)(86362001)(956004)(2616005)(6486002)(4326008)(38100700002)(16576012)(83380400001)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?anNXNkZObmVMV1JweEU4c013NWsyZFMzY0ZHeGRoMG9sMWZZNDVmdVFKSFM2?=
 =?utf-8?B?UitlZGwyOThPbHlpYWE0dnovSWZuTmhyeDFiK2VwcUl6UmtERTJ5d2hCV0Vz?=
 =?utf-8?B?UU1md2tESzBFRmhOMmcwT1JibkpyTUh6SVdibm84cTN5cDc0VU1kZVk4Yjgv?=
 =?utf-8?B?dE9uMEtzVTNyOHNUaXlicEkycjVtbys1dCswSWJhQnVXQkEvbS9waDQyRHRL?=
 =?utf-8?B?TG1wcFVvaXY5eFlkdnRGNmdCbWJZSEhJaExhU2NzdkVlbXBUN2VxSnMwVHNM?=
 =?utf-8?B?R1lsSUZoSU5DTGhGVXUwSWwxa0tocis0b2RWTlJnc0N6UHAzZnVENlEyc0xF?=
 =?utf-8?B?cFo4d25YdzZQUzA4YkZzMzVXbjlmNG1xRXVvMGswUTd5cjBRQVhVbm1Say9q?=
 =?utf-8?B?dXEwekJsbGJDN0lYdml5SlNwWFp0Mk1OMHFtTE1wVEhYQkx2L0VKQXJ5R0NS?=
 =?utf-8?B?aDhnWTgwZXBqY3hmTWI4NThjdUZzdUdwRjhycWlzQjFxYjU0V1dkMjlqSi9i?=
 =?utf-8?B?NjNxZUtlMWFraXYzT1lteDh1T1hxaHRjY0FWK25qMnA4WnVhRFprMFJaekwx?=
 =?utf-8?B?S1dqTktLRHh6RHhjbm81aDBZUTNRUVQydEd4dUJQWWMrY0Iwc1QydEFnaGJz?=
 =?utf-8?B?L0lKNmkxNnJxM0ZCMHc3UjRhR2ZSTVVndlBseCtsNGN4cFJ5NkRHczVkWTJQ?=
 =?utf-8?B?M0xja0xRdmdvRVkwMVJidVhHaUZuQXpsMi9OVTdpVXNQcVkra3BTVGQ1TTV1?=
 =?utf-8?B?WCtmaFRNUE5oZDdROExSby9BemIzWWF2Ylh6MEZGekJrUDZ4M1dwOGpqWTRj?=
 =?utf-8?B?OCttT1FJTkxHRTVrR0xhTnN4ZzBKNHUrdFR6U2VFVzdSa3cwaElvR05tMGY4?=
 =?utf-8?B?ZStPWmRzYkdKaUtNRVRRSDQwVjVVdXRNbmxVbFU3TGRyVGNxdXRlelZlZTFs?=
 =?utf-8?B?eU1JK2c1OE9WYTZ4Z2tQdVdGR2Z3LzZHNFNGMkVGTVVUMXBlQTkyQW1MTnE2?=
 =?utf-8?B?V1doT2tTL1Fub1ozSTVpTWlTMy9vWVlGNmcwSFdqSi9vN3dxZkZTMTVkTXFr?=
 =?utf-8?B?K21uRzE2SzgwNzYwK3crZDY5TmxpYmtYRjJCSjUrR2l0VmxRMzdpalBGTVZQ?=
 =?utf-8?B?cWFzbGVwZlIrTFpmVWVOT2pLSUQ2K29FWGlndm1jQlBMclVJNVZUTkh1TVl4?=
 =?utf-8?B?QVZGVVFEeld0ZnRZMGdCVEVOVTN0V0pPWU9Pd1c5UUJIRFFweWwzUXl0eitx?=
 =?utf-8?B?QkYwRTBTRVdXT1dwZWJSRk9nMi9rQStFZWhBT2tobmpxMjY4Ym0ycEhhQlhL?=
 =?utf-8?B?SjIwdUtiQ3pDclBlQnkvU2JNQ0FZcGVzekZQa2lZTG91T1NTMTNPeXZYRk5n?=
 =?utf-8?B?d2RzZmt5TENZWVVTaURhWmxuS0ZhTG52ZTNWY0xGTTE5V253Um1SdXZFdVJZ?=
 =?utf-8?B?S0pMTEh0d3pZcXVnRWx5Z0M3R1BLRDlLZmU3eVVvWFZLWEhmSkpGdGtwbzBH?=
 =?utf-8?B?Tm0vWDN1RkUyRGd5a3JtL2JxNi84UUkvVHVUWHd0YWVqYVl4NlNqSmhsY0Uy?=
 =?utf-8?B?VldsV2RkRXAwZ1dvOUF0djVTempCUFdYSWNHRG1CVkV3bGVtUTVJaTM1aWE4?=
 =?utf-8?B?WkM0OTVKdWFKdDdnUGNlVjh6K0FVUDZjV0RpUXFIZVNlU0N1NndQd1cwTlNS?=
 =?utf-8?B?ZTNCdDV3bzhYTFZyaytOT0dSRXoxUEpUelJJYnA4NnpxSlI0RExRbDZoRzBs?=
 =?utf-8?B?RjUvRzlhK2o1WEEvRHdIQWliQ0lLTWlHR1ZyQzZhcXMvalFBYmloZXBTcmEr?=
 =?utf-8?B?aTI0aEkrT01mMlZBYjVxS1ByRmRPNHdnVXQ1b2FlaEZZY08rbFB1b2R3ZzlL?=
 =?utf-8?B?L05PcGFaMzdpRUdiZ3FYMlFmSExwTEE3Y242dm9SQ21GSmJzNHVON0pMT1BN?=
 =?utf-8?B?SnV6MC9YNTdlZDRUbU5wYTRTMXhPS3V6Z01DcWhMQ0lzRWdDSjlQb0EyZ1hG?=
 =?utf-8?B?M0pjRngyRHJtQlhFNUdoWXd6R1c5MnlkZGVBWVNVYjBOdEd2VWcrNkJGREtI?=
 =?utf-8?B?TFN5THZtaCtUeU5sbVhIK2Rxc2JKYUN4NE95MUFNaWxycW8vbWh3V1A4Vy9J?=
 =?utf-8?B?dGhVRFZaNW1wNHNWcFg5Y2xqVGhobTZ3aDlrR1h2NEtHTFRUR2hWYlVERXRV?=
 =?utf-8?Q?nqLzPSc4EGOfnmRtZH+iLdQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c4f8654-be48-41d0-444e-08d9b9618ec6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:11:30.9459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pQwXoYsrhsBbzjOigdskgUlusjhzszptG7bGp13enNmsPu1BMBw41hiK1IJXnCUUvgfuP4U/b9JHUKNfh0Hpiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5597

On 06.12.2021 17:21, Julien Grall wrote:
> Hi Jan,
> 
> On 06/12/2021 16:12, Jan Beulich wrote:
>> On 06.12.2021 17:06, Julien Grall wrote:
>>> On 06/12/2021 15:06, Jan Beulich wrote:
>>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>>> I am not going to ack it but I am also not going to Nack it if another
>>>>> maintainer agrees with your approach.
>>>>
>>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>>> I'm now in a position to put this in with Luca's R-b.
>>>
>>>   From the check-in policy section in MAINTAINERS:
>>>
>>> 4. There must be no "open" objections.
>>>
>>> So I think this cannot be check-in given two maintainers disagree on the
>>> approach. That said, as I wrote earlier my condition for not Nacking is
>>> another maintainer agree with your approach.
>>
>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>> going as far as minimally necessary. I therefore wouldn't call this an
>> "open objection".
> 
> I believe my objection is still open.

I've taken note of this. I'm afraid with the long winded discussion no
other maintainer will provide an ack. Which therefore makes what you said
above effectively a nak anyway. Unless things move in unexpected ways, I
will have to consider this series rejected then.

> I still have have no way to verify 
> what you did is correct.
> 
> For instance, the tags in patch #2 are:
> 
> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
> Reported-by: Yu Sun <yusun2@cisco.com>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Acked-by: Daniel Walker <danielwa@cisco.com>
> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
> 
> The tags in the Linux commit are:
> 
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Reported-by: Yu Sun <yusun2@cisco.com>
> Acked-by: Daniel Walker <danielwa@cisco.com>
> Cc: "Yixia Si (yisi)" <yisi@cisco.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> * The first two matches the original e-mails
> * I couldn't find the 3rd on the ML.

See e.g.

https://yhbt.net/lore/all/20191108202754.GG18744@zorba/t/

(Andrew Morton's reply at the bottom) for where it originates.

> * The Cc could be ignored
> * The signed-off-by are I guess what you call "mechanical"

I would generally retain Reviewed-by when our code is still quite
similar to Linux'es. Acked-by are on the edge of being useful, but as
you can see I did err on the side of keeping it. As said in a number
of places elsewhere, for what I call mechanically added tags I am yet
to be told of their value (or even need) in our tree. Not the least
- as also said in reply to Ian - because we don't usually follow
Linux'es model of flowing patches through several trees, where each
tree owner would apply their S-o-b as per (c) of "Developer's
Certificate of Origin 1.1".

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:16:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:16:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240773.417483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWZv-0001vD-U7; Tue, 07 Dec 2021 09:16:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240773.417483; Tue, 07 Dec 2021 09:16:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWZv-0001v6-QO; Tue, 07 Dec 2021 09:16:03 +0000
Received: by outflank-mailman (input) for mailman id 240773;
 Tue, 07 Dec 2021 09:16:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pUvc=QY=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1muWZt-0001uy-QN
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:16:01 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0603.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::603])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a8536b8-573e-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 10:16:00 +0100 (CET)
Received: from AS9PR06CA0347.eurprd06.prod.outlook.com (2603:10a6:20b:466::33)
 by VI1PR08MB5535.eurprd08.prod.outlook.com (2603:10a6:803:13e::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Tue, 7 Dec
 2021 09:15:56 +0000
Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:466:cafe::61) by AS9PR06CA0347.outlook.office365.com
 (2603:10a6:20b:466::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Tue, 7 Dec 2021 09:15:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 09:15:56 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Tue, 07 Dec 2021 09:15:55 +0000
Received: from ce3a97d7c892.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8DF4D82F-6A7D-41AB-92D0-3D846B9B4C2B.1; 
 Tue, 07 Dec 2021 09:15:50 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ce3a97d7c892.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 09:15:50 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by DB9PR08MB7211.eurprd08.prod.outlook.com (2603:10a6:10:2ce::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 09:15:48 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::f4fd:a3a4:6768:1165]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::f4fd:a3a4:6768:1165%3]) with mapi id 15.20.4690.035; Tue, 7 Dec 2021
 09:15:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a8536b8-573e-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QYocTBF6MFiMYOTCzGEd4qbXTF2WxaglyaDjfZj3tHo=;
 b=fas+XAxuGe/srNfVjgMvfVsPnaCkwZF1/usonLCSYFCYKIqCBzUGb7vFp1Isp1Op1cGp5uBKfqf78rAHo3JZ2brBl6MUN6y+0ovHX8yDOi3Z6o6GewOWDFzgUCDHfw3tLXk6QRlViMy5GVsB6vjP4TXCn5s8HaMag86rbYxVi2k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MqtZKF2ZVM9S34CuKSOVKzLI/uGXrFFP1QUe1QC4cShB5MMJicwjwKzY8rT78jvnvvexZUPCyHXGp0lpTeGzhwm47xK1XBcQ36Yp9bO4wWlVm3nJV8nNkk1wqg2zeD0cazOHHYnb28Lrj2J4RDQrMnOr78J79qprsOXmgk0SyowtXZ5JMaOMu8Ltv1MiLYGrE1rpljMQFT/v7hzKHT75IqgjSStjsw2uNBNqvZTB3jKWMbLyp88Puf49b0C8xuVpHEWZopsjT6gvkfoWsyc/q9P1t50hW6wZfWRpTtoryd/OOVgvnXvemmBQ+Tmb4/P8yz/4/dNrkmeKNBMgUMnE9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QYocTBF6MFiMYOTCzGEd4qbXTF2WxaglyaDjfZj3tHo=;
 b=EXP0o/zdSnofUNf3B0+O7W0RAO2yNp72FIGfWyMosILqxlA6gUHIcqu2ju4yZcrnmqZ2Qn6YQOINhbV/glAdgYPnxt+DTiBJCGsswwhmv8d5tM9KERYviDyPlPV2G5lcdOfMWBAhG/P95bEcin/R/tw5AkF625DUTvV92TZXt0LaIQR9Pqorphe2XVHlwDmoPxx2+1dwmFLvGhUAEwZAPDcZElLhmZ22YKQR1b6zIRcIvjEYAzs2o7q5nvB0MBCIgp0OqUitqCN+aAcZwBZzM0XROwXTecxb0uusYm2an3TDaaPDt/iat83Cabxj8ia/iAXhTI4IskpGVTrJijcpuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QYocTBF6MFiMYOTCzGEd4qbXTF2WxaglyaDjfZj3tHo=;
 b=fas+XAxuGe/srNfVjgMvfVsPnaCkwZF1/usonLCSYFCYKIqCBzUGb7vFp1Isp1Op1cGp5uBKfqf78rAHo3JZ2brBl6MUN6y+0ovHX8yDOi3Z6o6GewOWDFzgUCDHfw3tLXk6QRlViMy5GVsB6vjP4TXCn5s8HaMag86rbYxVi2k=
From: Penny Zheng <Penny.Zheng@arm.com>
To: "julien@xen.org" <julien@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Michal Orzel <Michal.Orzel@arm.com>
Subject: RE: [PATCH v3 01/10] xen: introduce XEN_DOMCTL_CDF_INTERNAL_directmap
Thread-Topic: [PATCH v3 01/10] xen: introduce
 XEN_DOMCTL_CDF_INTERNAL_directmap
Thread-Index: AQHX2qqMLpGJ0kZySkyR2zVz1q+w86wm3Qog
Date: Tue, 7 Dec 2021 09:15:47 +0000
Message-ID:
 <DU2PR08MB7325137A71A2D7277F1A1650F76E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20211116052506.880728-1-penny.zheng@arm.com>
 <20211116052506.880728-2-penny.zheng@arm.com>
In-Reply-To: <20211116052506.880728-2-penny.zheng@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 7D4A81CBC3FC1446886309948C7B021D.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 52ec926f-7bcc-4538-341c-08d9b9622cfa
x-ms-traffictypediagnostic:
	DB9PR08MB7211:EE_|AM5EUR03FT023:EE_|VI1PR08MB5535:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB5535C2630050FBF4D93CECC5F76E9@VI1PR08MB5535.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 UJJ0+lsK7GbMORiS7tCxflpJYjTnDlrt7B1pVzQ/WW31AAOpPxW+XnGf0gfL2KYEAjjUxo8runH6E+XBObfn4XqWfE1RnMkZQMnlfBEEeI57Bm0yoaIb3f+Ch2Xw7pEfxST7DUA88gLASttRNOaZ7Kpy8Ppr8CpvFwaNNPmO/OI1gici/uMskX0VY7IGpMZUIDZqdjkyHCsSGKFR/UwZH9D5UFuldMRnlQ9D7bL/4eY5VTgUQxk3090yhrKz91DcVLMbmRShpcVSkIE2JPvEvWSwgM6oH29KiB3XAmpklHo0wIsjRSCg9e4e1tGZekUoMzKDNcx5w2W5umQ254QKVXDnmrk0RQcoUe5yO2jgbmpHeSwF26OfK/YqyWGXNAMdLBCcvTwyyH6xFaOdrx8lS9vGLHmFyKEsLl3PvgW6cCg8UqR9gthytEG04emL3tDCFVx6dWYDmx8gQU6B037oITD1Cv7cBZG/861ayN3K+XEiQPxoThhV6WrrPJ+TfPpK5uVOB1R+YOFEno7qtg1tEH0BrO4nvBPWGH46C7xuCKdJsxbmCpJR1kdw/p3gJuIpfqc0T3JdxhBIvpxeksr7Ycg/sm+lMWN75mwU4N08/RksEYw0g4EckDO4d9WayRZUQtbi0xXn5IBRWrixDzcQa668uxCvdxulXKRnZcMiJVM/RcjWAGpB9Ue4jelM0Pk/bkREe6x498SfDNW3WnRjq8kuFoIPbhkKqfaarqD1LRwkUUoVbUxWR9MLbeB1g+Jez71ny6Z3YVoA7wpsUfxgYB6mGICtQgmp6bdpT6Na5hp9qEKKu3ei9krTl+XlbbmD
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(508600001)(8936002)(2906002)(9686003)(52536014)(4326008)(66476007)(55016003)(66556008)(64756008)(66946007)(66446008)(76116006)(316002)(110136005)(38100700002)(38070700005)(7696005)(54906003)(86362001)(186003)(122000001)(83380400001)(8676002)(966005)(6506007)(33656002)(53546011)(5660300002)(71200400001)(21314003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7211
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	59d572b5-f53e-40a3-b478-08d9b962281b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	s65SFeW/KYZJbEBzxho42PIJR2v9m2cRkBW9Bw0MOrL1HM8Us1FBJ+Ob2HyTbYlfdG2iv5b3dFxgmePAN+9N/eY08ajEODi9KASJrkpHXkqvM2iLmvfFg6jDiv7lUIg4dkyVupoZApMsmEqfDDX9u3yH20IT3Hdd8VjLIetZPoBvDGgDGWNTCYn/ib+FSwZ4gkVomMpae/qNApdlGeIt8+FW0CvNoZNwBVU7y0jl6nDW11RI0ziYdQCBYnNsWeQVu1U2wEiWdUIh+TLMJOUrYAA6S4fsKy/oeI1dKKDsS1kzmZzEAdRyyvouuNGhFw9XASVAmYwpL3eBrPD+47JLEy1OqFDgua4xcABS19URWYXTREpoEZ3APeA6hoafIiui6wVBirb2BrbjNt7EVTeuknOmH6qQCdz5aVcH+QxIwGlLgrysT3Lk8WpSnPT9LkDeVHpVLEFTEK2pi2v2vxPa4QwyPNOHBw89Dpy0GWu8PSN2O1leMu82Sp6StRSYtX5PuZC0ajVwxUgifLhfcWlNZEZYa35E6OERbgOYxJ8SFySvv7DqOim2N5lUMzqadHUPms/0FE3f7V8zxgdu3YYDKrKEYOAc+DqdO8sv/a1Jxqulb1jx33NKyryF8Aefbv7MCjajCVVYAyEV3Amq0J9zQC1UJuJ+xSzm6eTLIwTHt0DQljZXnhtKoWMM7LLq6ZQYGT+90dfRgGB07DJtXlTQSewNOpcWoNn+5Lb41YECm+lWhQ9Xb6lhsVbqv6GakgjqnuxDBYR/nMkPBujImBwAcG2UVhSgoyl5niz2VT8p2s1guH/ckyaU+FuFxqUr+2dm
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(8676002)(70206006)(70586007)(52536014)(336012)(86362001)(53546011)(55016003)(2906002)(6506007)(356005)(966005)(81166007)(110136005)(82310400004)(316002)(508600001)(5660300002)(8936002)(186003)(26005)(7696005)(83380400001)(4326008)(9686003)(33656002)(36860700001)(47076005)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:15:56.1383
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 52ec926f-7bcc-4538-341c-08d9b9622cfa
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5535

SGkgZ3V5cw0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFBlbm55IFpo
ZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiBTZW50OiBUdWVzZGF5LCBOb3ZlbWJlciAxNiwg
MjAyMSAxOjI1IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4g
Q2M6IG5kIDxuZEBhcm0uY29tPg0KPiBTdWJqZWN0OiBbUEFUQ0ggdjMgMDEvMTBdIHhlbjogaW50
cm9kdWNlDQo+IFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcA0KPiANCj4gRnJvbTog
U3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gDQo+
IFRoaXMgY29tbWl0IGludHJvZHVjZXMgYSBuZXcgYXJtLXNwZWNpZmljIGZsYWcNCj4gWEVOX0RP
TUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwIHRvIHNwZWNpZnkgdGhhdCBhIGRvbWFpbiBzaG91
bGQNCj4gaGF2ZSBpdHMgbWVtb3J5IGRpcmVjdC1tYXAoZ3Vlc3QgcGh5c2ljYWwgYWRkcmVzcyA9
PSBwaHlzaWNhbCBhZGRyZXNzKSBhdA0KPiBkb21haW4gY3JlYXRpb24uDQo+IA0KPiBTaW5jZSB0
aGlzIGZsYWcgaXMgb25seSBhdmFpbGFibGUgZm9yIGRvbWFpbiBjcmVhdGVkIGJ5IFhFTiwgbm90
IGV4cG9zZWQgdG8gdGhlDQo+IHRvb2xzdGFjaywgd2UgbmFtZSBpdCB3aXRoIGV4dHJhICJJTlRF
Uk5BTCIgdG8gZGlzdGluZ3Vpc2ggZnJvbSBvdGhlciBwdWJsaWMNCj4gWEVOX0RPTUNUTF9DREZf
eHh4IGZsYWdzLCBhbmQgYWRkIGNvbW1lbnRzIHRvIHdhcm4gZGV2ZWxvcGVycyBub3QgdG8NCj4g
YWNjaWRlbnRseSB1c2UgaXRzIGJpdGZpZWxkIHdoZW4gaW50cm9kdWNpbmcgbmV3IFhFTl9ET01D
VExfQ0RGX3h4eCBmbGFnLg0KPiANCj4gUmVmaW5lIGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkIHRv
IGNoZWNrIHdoZXRoZXIgdGhlIGZsYWcNCj4gWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0
bWFwIGlzIHNldC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVu
Z0Bhcm0uY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHN0ZWZhbm8u
c3RhYmVsbGluaUB4aWxpbnguY29tPg0KPiAtLS0NCj4gQ0M6IGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20NCj4gQ0M6IGpiZXVsaWNoQHN1c2UuY29tDQo+IENDOiBHZW9yZ2UgRHVubGFwIDxHZW9y
Z2UuRHVubGFwQGV1LmNpdHJpeC5jb20+DQo+IENDOiBJYW4gSmFja3NvbiA8aWFuLmphY2tzb25A
ZXUuY2l0cml4LmNvbT4NCj4gQ0M6IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+IENDOiAiUm9nZXIg
UGF1IE1vbm7DqSIgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiAtLS0NCj4gdjIgY2hhbmdlcw0K
PiAtIHJlbW92ZSB0aGUgaW50cm9kdWNlIG9mIGludGVybmFsIGZsYWcNCj4gLSByZW1vdmUgZmxh
ZyBkaXJlY3RfbWFwIHNpbmNlIHdlIGFscmVhZHkgc3RvcmUgdGhpcyBmbGFnIGluIGQtPm9wdGlv
bnMNCj4gLSBSZWZpbmUgaXNfZG9tYWluX2RpcmVjdF9tYXBwZWQgdG8gY2hlY2sgd2hldGhlciB0
aGUgZmxhZw0KPiBYRU5fRE9NQ1RMX0NERl9kaXJlY3RtYXAgaXMgc2V0DQo+IC0gcmV3b3JkICIx
OjEgZGlyZWN0LW1hcCIgdG8ganVzdCAiZGlyZWN0LW1hcCINCj4gLS0tDQo+IHYzIGNoYW5nZXMN
Cj4gLSBtb3ZlIGZsYWcgYmFjayB0byB4ZW4vaW5jbHVkZS94ZW4vZG9tYWluLmgsIHRvIGxldCBp
dCBiZSBvbmx5IGF2YWlsYWJsZSBmb3INCj4gZG9tYWluIGNyZWF0ZWQgYnkgWEVOLg0KPiAtIG5h
bWUgaXQgd2l0aCBleHRyYSAiSU5URVJOQUwiIGFuZCBhZGQgY29tbWVudHMgdG8gd2FybiBkZXZl
bG9wZXJzIG5vdCB0bw0KPiBhY2NpZGVudGx5IHVzZSBpdHMgYml0ZmllbGQgd2hlbiBpbnRyb2R1
Y2luZyBuZXcgWEVOX0RPTUNUTF9DREZfeHh4IGZsYWcuDQo+IC0gcmVqZWN0IHRoaXMgZmxhZyBp
biB4ODYnZXMgYXJjaF9zYW5pdGlzZV9kb21haW5fY29uZmlnKCkNCj4gLS0tDQo+ICB4ZW4vYXJj
aC9hcm0vZG9tYWluLmMgICAgICAgIHwgMyArKy0NCj4gIHhlbi9hcmNoL2FybS9kb21haW5fYnVp
bGQuYyAgfCA0ICsrKy0NCj4gIHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAgICAgfCA2ICsrKysr
Kw0KPiAgeGVuL2NvbW1vbi9kb21haW4uYyAgICAgICAgICB8IDMgKystDQo+ICB4ZW4vaW5jbHVk
ZS9hc20tYXJtL2RvbWFpbi5oIHwgNCArKy0tDQo+ICB4ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3Rs
LmggIHwgNCArKysrDQo+ICB4ZW4vaW5jbHVkZS94ZW4vZG9tYWluLmggICAgIHwgMyArKysNCj4g
IDcgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkNCj4gDQo+
IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMgYi94ZW4vYXJjaC9hcm0vZG9tYWlu
LmMgaW5kZXgNCj4gOTZlMWIyMzU1MC4uZDc3MjY1YzAzZiAxMDA2NDQNCj4gLS0tIGEveGVuL2Fy
Y2gvYXJtL2RvbWFpbi5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiBAQCAtNjI5
LDcgKzYyOSw4IEBAIGludCBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0DQo+IHhl
bl9kb21jdGxfY3JlYXRlZG9tYWluICpjb25maWcpICB7DQo+ICAgICAgdW5zaWduZWQgaW50IG1h
eF92Y3B1czsNCj4gICAgICB1bnNpZ25lZCBpbnQgZmxhZ3NfcmVxdWlyZWQgPSAoWEVOX0RPTUNU
TF9DREZfaHZtIHwNCj4gWEVOX0RPTUNUTF9DREZfaGFwKTsNCj4gLSAgICB1bnNpZ25lZCBpbnQg
ZmxhZ3Nfb3B0aW9uYWwgPSAoWEVOX0RPTUNUTF9DREZfaW9tbXUgfA0KPiBYRU5fRE9NQ1RMX0NE
Rl92cG11KTsNCj4gKyAgICB1bnNpZ25lZCBpbnQgZmxhZ3Nfb3B0aW9uYWwgPSAoWEVOX0RPTUNU
TF9DREZfaW9tbXUgfA0KPiBYRU5fRE9NQ1RMX0NERl92cG11IHwNCj4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwKTsN
Cj4gDQo+ICAgICAgaWYgKCAoY29uZmlnLT5mbGFncyAmIH5mbGFnc19vcHRpb25hbCkgIT0gZmxh
Z3NfcmVxdWlyZWQgKQ0KPiAgICAgIHsNCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21h
aW5fYnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPiBpbmRleCAxOTQ4N2M3
OWRhLi42NjRjODhlYmU0IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxk
LmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+IEBAIC0zMDg5LDggKzMw
ODksMTAgQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbTAoc3RydWN0IGRvbWFpbiAq
ZCkNCj4gdm9pZCBfX2luaXQgY3JlYXRlX2RvbTAodm9pZCkgIHsNCj4gICAgICBzdHJ1Y3QgZG9t
YWluICpkb20wOw0KPiArICAgIC8qIERPTTAgaGFzIGFsd2F5cyBpdHMgbWVtb3J5IGRpcmVjdC1t
YXAuICovDQo+ICAgICAgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9tYWluIGRvbTBfY2ZnID0g
ew0KPiAtICAgICAgICAuZmxhZ3MgPSBYRU5fRE9NQ1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NE
Rl9oYXAsDQo+ICsgICAgICAgIC5mbGFncyA9IFhFTl9ET01DVExfQ0RGX2h2bSB8IFhFTl9ET01D
VExfQ0RGX2hhcCB8DQo+ICsgICAgICAgICAgICAgICAgIFhFTl9ET01DVExfQ0RGX0lOVEVSTkFM
X2RpcmVjdG1hcCwNCj4gICAgICAgICAgLm1heF9ldnRjaG5fcG9ydCA9IC0xLA0KPiAgICAgICAg
ICAubWF4X2dyYW50X2ZyYW1lcyA9IGdudHRhYl9kb20wX2ZyYW1lcygpLA0KPiAgICAgICAgICAu
bWF4X21hcHRyYWNrX2ZyYW1lcyA9IC0xLA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2Rv
bWFpbi5jIGIveGVuL2FyY2gveDg2L2RvbWFpbi5jIGluZGV4DQo+IGVmMTgxMmRjMTQuLmViYTY1
MDIyMTggMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPiArKysgYi94ZW4v
YXJjaC94ODYvZG9tYWluLmMNCj4gQEAgLTY5Miw2ICs2OTIsMTIgQEAgaW50IGFyY2hfc2FuaXRp
c2VfZG9tYWluX2NvbmZpZyhzdHJ1Y3QNCj4geGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZp
ZykNCj4gICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICAgICAgfQ0KPiANCj4gKyAgICBpZiAo
IGNvbmZpZy0+ZmxhZ3MgJiBYRU5fRE9NQ1RMX0NERl9JTlRFUk5BTF9kaXJlY3RtYXAgKQ0KPiAr
ICAgIHsNCj4gKyAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgImRpcmVjdC1tYXAgY2Fubm90
IGJlIGVuYWJsZWQgeWV0XG4iKTsNCj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ICsgICAg
fQ0KPiArDQo+ICAgICAgcmV0dXJuIDA7DQo+ICB9DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2Nv
bW1vbi9kb21haW4uYyBiL3hlbi9jb21tb24vZG9tYWluLmMgaW5kZXgNCj4gNTZkNDdkZDY2NC4u
MTNhYzU5NTBiYyAxMDA2NDQNCj4gLS0tIGEveGVuL2NvbW1vbi9kb21haW4uYw0KPiArKysgYi94
ZW4vY29tbW9uL2RvbWFpbi5jDQo+IEBAIC00ODYsNyArNDg2LDggQEAgc3RhdGljIGludCBzYW5p
dGlzZV9kb21haW5fY29uZmlnKHN0cnVjdA0KPiB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiAqY29u
ZmlnKQ0KPiAgICAgICAgICAgfihYRU5fRE9NQ1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NERl9o
YXAgfA0KPiAgICAgICAgICAgICBYRU5fRE9NQ1RMX0NERl9zM19pbnRlZ3JpdHkgfCBYRU5fRE9N
Q1RMX0NERl9vb3Nfb2ZmIHwNCj4gICAgICAgICAgICAgWEVOX0RPTUNUTF9DREZfeHNfZG9tYWlu
IHwgWEVOX0RPTUNUTF9DREZfaW9tbXUgfA0KPiAtICAgICAgICAgICBYRU5fRE9NQ1RMX0NERl9u
ZXN0ZWRfdmlydCB8IFhFTl9ET01DVExfQ0RGX3ZwbXUpICkNCj4gKyAgICAgICAgICAgWEVOX0RP
TUNUTF9DREZfbmVzdGVkX3ZpcnQgfCBYRU5fRE9NQ1RMX0NERl92cG11IHwNCj4gKyAgICAgICAg
ICAgWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwKSApDQo+ICAgICAgew0KPiAgICAg
ICAgICBkcHJpbnRrKFhFTkxPR19JTkZPLCAiVW5rbm93biBDREYgZmxhZ3MgJSN4XG4iLCBjb25m
aWctPmZsYWdzKTsNCj4gICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+IGRpZmYgLS1naXQgYS94
ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4u
aA0KPiBpbmRleCA5YjM2NDc1ODdhLi40ZjJjM2YwOWQ0IDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5j
bHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+ICsrKyBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWlu
LmgNCj4gQEAgLTI5LDggKzI5LDggQEAgZW51bSBkb21haW5fdHlwZSB7DQo+ICAjZGVmaW5lIGlz
XzY0Yml0X2RvbWFpbihkKSAoMCkNCj4gICNlbmRpZg0KPiANCj4gLS8qIFRoZSBoYXJkd2FyZSBk
b21haW4gaGFzIGFsd2F5cyBpdHMgbWVtb3J5IGRpcmVjdCBtYXBwZWQuICovIC0jZGVmaW5lDQo+
IGlzX2RvbWFpbl9kaXJlY3RfbWFwcGVkKGQpIGlzX2hhcmR3YXJlX2RvbWFpbihkKQ0KPiArI2Rl
ZmluZSBpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSBcDQo+ICsgICAgICAgIChkLT5vcHRpb25z
ICYgWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwKQ0KPiANCj4gIHN0cnVjdCB2dGlt
ZXIgew0KPiAgICAgIHN0cnVjdCB2Y3B1ICp2Ow0KPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUv
cHVibGljL2RvbWN0bC5oIGIveGVuL2luY2x1ZGUvcHVibGljL2RvbWN0bC5oIGluZGV4DQo+IDFj
MjFkNGRjNzUuLjA1NGU1NDVjOTcgMTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9k
b21jdGwuaA0KPiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3RsLmgNCj4gQEAgLTcyLDYg
KzcyLDEwIEBAIHN0cnVjdCB4ZW5fZG9tY3RsX2NyZWF0ZWRvbWFpbiB7DQo+ICAjZGVmaW5lIFhF
Tl9ET01DVExfQ0RGX25lc3RlZF92aXJ0ICAgICgxVSA8PA0KPiBfWEVOX0RPTUNUTF9DREZfbmVz
dGVkX3ZpcnQpDQo+ICAvKiBTaG91bGQgd2UgZXhwb3NlIHRoZSB2UE1VIHRvIHRoZSBndWVzdD8g
Ki8NCj4gICNkZWZpbmUgWEVOX0RPTUNUTF9DREZfdnBtdSAgICAgICAgICAgKDFVIDw8IDcpDQo+
ICsvKg0KPiArICogQmUgYXdhcmUgdGhhdCBiaXQgOCBoYXMgYWxyZWFkeSBiZWVuIG9jY3VwaWVk
IGJ5IGZsYWcNCj4gKyAqIFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcCwgZGVmaW5l
ZCBpbg0KPiB4ZW4vaW5jbHVkZS94ZW4vZG9tYWluLmguDQo+ICsgKi8NCj4gDQo+ICAvKiBNYXgg
WEVOX0RPTUNUTF9DREZfKiBjb25zdGFudC4gIFVzZWQgZm9yIEFCSSBjaGVja2luZy4gKi8gICNk
ZWZpbmUNCj4gWEVOX0RPTUNUTF9DREZfTUFYIFhFTl9ET01DVExfQ0RGX3ZwbXUgZGlmZiAtLWdp
dA0KPiBhL3hlbi9pbmNsdWRlL3hlbi9kb21haW4uaCBiL3hlbi9pbmNsdWRlL3hlbi9kb21haW4u
aCBpbmRleA0KPiAxNjBjOGRiZGFiLi4yYjllZGZkY2VlIDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5j
bHVkZS94ZW4vZG9tYWluLmgNCj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2RvbWFpbi5oDQo+IEBA
IC0yOCw2ICsyOCw5IEBAIHZvaWQgZ2V0ZG9tYWluaW5mbyhzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1
Y3QNCj4geGVuX2RvbWN0bF9nZXRkb21haW5pbmZvICppbmZvKTsgIHZvaWQgYXJjaF9nZXRfZG9t
YWluX2luZm8oY29uc3Qgc3RydWN0DQo+IGRvbWFpbiAqZCwNCj4gICAgICAgICAgICAgICAgICAg
ICAgICAgICAgc3RydWN0IHhlbl9kb21jdGxfZ2V0ZG9tYWluaW5mbyAqaW5mbyk7DQo+IA0KPiAr
LyogU2hvdWxkIGRvbWFpbiBtZW1vcnkgYmUgZGlyZWN0bHkgbWFwcGVkPyAqLw0KPiArI2RlZmlu
ZSBYRU5fRE9NQ1RMX0NERl9JTlRFUk5BTF9kaXJlY3RtYXAgICAgICAoMVUgPDwgOCkNCj4gKw0K
DQpJIHJ1biBpbnRvIHNvbWUgdHJvdWJsZSB3aXRoIGRlZmluaW5nIHRoaXMgZmxhZyBpbnRlcm5h
bCBpbiB0aGUgbmV3IHNlcmllLg0KDQpMZXQgbWUgZXhwbGFpbiBpbiBkZXRhaWxzIGhlcmU6DQoN
CjEuIEN1cnJlbnRseSBYRU5fRE9NQ1RMX0NERl9NQVggaXMgc2V0IHRvIFhFTl9ET01DVExfQ0RG
X3ZwbXUuDQpTbyB3ZSBjYW4gc2F5IHRoYXQgWEVOX0RPTUNUTF9DREZfTUFYIGtub3dzIHRoYXQg
dGhlcmUgYXJlIDggQ0RGIGZsYWdzKDAgdG8gNykuDQpUaGUgY29ycmVzcG9uZGluZyBvY2FtbCB0
b29sIGhhcyBhIGxpc3Qgb2YgQ0RGIGZsYWdzIGFuZCBjdXJyZW50bHkgaXQga25vd3MgdGhhdCB0
aGVyZSBhcmUgOCBDREYgZmxhZ3M6DQpodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXR3ZWIvP3A9
eGVuLmdpdDthPWJsb2I7Zj10b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWw7aD03NTAzMDMx
ZDhmNjFjMmRiY2Q0YWE4MDM3MzhjODNlMTBkZmI3YmI4O2hiPUhFQUQjbDY0IA0KVGhpcyB0b29s
IHBlcmZvcm1zIGEgY2hlY2sgdG8gc2VlIGlmIHRoZSBYRU5fRE9NQ1RMX0NERl9NQVggaXMgZXF1
YWwgdG8gdGhlIG51bWJlciBvZiBlbnRyaWVzIGluIGRvbWFpbl9jcmVhdGVfZmxhZy4NCg0KMi4g
SGVyZSB3ZSBhcmUgcmVzZXJ2aW5nIGJpdCA4IGZvciBpbnRlcm5hbCBmbGFnIFhFTl9ET01DVExf
Q0RGX0lOVEVSTkFMX2RpcmVjdG1hcC4gQXMgdGhpcyBpcyBpbnRlcm5hbCBmbGFnLA0KSSBkbyBu
b3Qgd2FudCB0byBtb2RpZnkgWEVOX0RPTUNUTF9DREZfTUFYLg0KDQozLiBFdmVyeXRoaW5nIGlz
IHBlcmZlY3QgdW50aWwgc29tZW9uZSB0cmllcyB0byBhZGQgYW5vdGhlciBnbG9iYWwgQ0RGIGZs
YWc6DQoNCiNkZWZpbmUgWEVOX0RPTUNUTF9DREZfbmV4dF9mbGFnICAoMTw8OSkNCiNkZWZpbmUg
WEVOX0RPTUNUTF9DREZfTUFYIFhFTl9ET01DVExfQ0RGX25leHRfZmxhZw0KDQpYRU5fRE9NQ1RM
X0NERl9NQVggc2hvd3MgcmlnaHQgbm93IHRoYXQgdGhlcmUgYXJlIDEwIGZsYWdzIGJ1dCBvY2Ft
bCB0b29sIHNlZXMgb25seSA5Lg0KdGhlbiB3ZSBhcmUgZ2V0dGluZyBidWlsZCBlcnJvci4NCg0K
SG1tLCB3b3VsZCB5b3UgcGxlYXNlIGhlbHAgbWUgZmluZCBhIHdheSB0byBmaXggdGhpcyBkaWxl
bW1hLCB0aHguDQoNCj4gIC8qDQo+ICAgKiBBcmNoLXNwZWNpZmljcy4NCj4gICAqLw0KPiAtLQ0K
PiAyLjI1LjENCg0KQ2hlZXJzLA0KUGVubnkgWmhlbmcNCg0K


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:28:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:28:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240779.417493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWla-0004bQ-3Q; Tue, 07 Dec 2021 09:28:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240779.417493; Tue, 07 Dec 2021 09:28:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWla-0004bJ-04; Tue, 07 Dec 2021 09:28:06 +0000
Received: by outflank-mailman (input) for mailman id 240779;
 Tue, 07 Dec 2021 09:28:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bINN=QY=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1muWlZ-0004bD-86
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:28:05 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062e.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::62e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9633b73-573f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 10:28:02 +0100 (CET)
Received: from DB6PR0301CA0057.eurprd03.prod.outlook.com (2603:10a6:4:54::25)
 by AM0PR08MB4499.eurprd08.prod.outlook.com (2603:10a6:208:140::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 09:27:59 +0000
Received: from DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:54:cafe::d7) by DB6PR0301CA0057.outlook.office365.com
 (2603:10a6:4:54::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Tue, 7 Dec 2021 09:27:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT050.mail.protection.outlook.com (10.152.21.128) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 09:27:59 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Tue, 07 Dec 2021 09:27:59 +0000
Received: from c94bde85efa0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FD41731F-8EF4-4CDC-AF5C-716D632C5386.1; 
 Tue, 07 Dec 2021 09:27:48 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c94bde85efa0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 09:27:48 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PA4PR08MB6064.eurprd08.prod.outlook.com (2603:10a6:102:e2::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Tue, 7 Dec
 2021 09:27:45 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622%5]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 09:27:45 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LNXP265CA0015.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::27) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Tue, 7 Dec 2021 09:27:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9633b73-573f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DS1JBIXpsevkQ65vXMD/Vgu/Q9G+eJmamkv58oh7SEI=;
 b=cu9PjtSSfqUC7iAq5/gKEEHBXS7A1ATvV0lMAGhIHR4CYk1Kl6U8RP5juZ5ahIwfqKkXaSVK8o3eZAs00Mwn5mM0x8eDn+INDI9qZPbBk+Qv5WQdhHUMnmLqcewa2x0Wo+wtCxxEhgmPbaqRv3eP5S1sxWMAso3TvO4eLBd3z94=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 268b296fae4d5ea4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y8BDS7/Weg2hlqgox48g+KC8FjUwnfPmedrYlyotwHqjafuFCu187zDlA6BHAIsW3bHTCGHyf85AC5gTND0h6cYiQKtjoicPxX/NNFniu03eOcDZz5de+6nqxEbODZjOPUj0Hy7INwKx6JKZZBz8lMZQ/f0QzaKFXA89uYONViW9Jd7Hy61jl4M134ZIwP3wkw2pxHwKnuAAfpbEF6tFOgS/GRbUaz8BSn0wnvy4V5Mwua2MWU+S+A0Y1FBGT3QOTlMRz4FOY7vU2T1YyeBkLeOLsbkkktxavPGs+RSg4S4f/LdVWG4UfQI9OcowxJ3kIHr7tUiDZX2B1PCbMD3ppw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DS1JBIXpsevkQ65vXMD/Vgu/Q9G+eJmamkv58oh7SEI=;
 b=BuyzWErVgGqQTwnz5B23MbKzn4DP97oRVVimISjzTH4IE122If3Dm+EcqRH/swfRdzanYkpRnJurMY6ma9X1ORfZv/D+23IQcUkm1MJ1FSCTdlr3ULkA/3aQtSSQIqn79C+K152SE3hsrRkBc61WvvnOBInWMQngo/27yMqYqTu/XP9oSkLcJyQRAu6q9vO7+/AVRuCb0oSjevyw2OcjaAiAfdbAxdjV6PuWy2/zcllJJh6ENNq9In598AM+Cm62rcEa6GB1lLoRwWLjLFhJpSsCXsdMtAPpo3kkSpgtSOTz1QjQG2fzONw+nXueveiAJuUU8RysJWWofY4EKpn1IQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DS1JBIXpsevkQ65vXMD/Vgu/Q9G+eJmamkv58oh7SEI=;
 b=cu9PjtSSfqUC7iAq5/gKEEHBXS7A1ATvV0lMAGhIHR4CYk1Kl6U8RP5juZ5ahIwfqKkXaSVK8o3eZAs00Mwn5mM0x8eDn+INDI9qZPbBk+Qv5WQdhHUMnmLqcewa2x0Wo+wtCxxEhgmPbaqRv3eP5S1sxWMAso3TvO4eLBd3z94=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [RFC PATCH 0/2] Boot time cpupools
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <59e14393-a1fc-5b82-2f6e-5567f218cb3a@suse.com>
Date: Tue, 7 Dec 2021 09:27:43 +0000
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Chen <Wei.Chen@arm.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Dario Faggioli <dfaggioli@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <662C34A2-CCCE-49CC-BA5B-8CC5E24E5DF3@arm.com>
References: <20211117095711.26596-1-luca.fancellu@arm.com>
 <26c01edc-46a9-47eb-0c9d-986b92e02158@xen.org>
 <B20FC780-3E2D-4B4A-BF1D-CF34763D237E@arm.com>
 <d42781c4-b01b-9064-4c90-ff99d960958b@xen.org>
 <1941B2BF-6451-4665-8591-DB14739121A9@arm.com>
 <f744c406-9801-a001-fb8e-90680cebb0c9@xen.org>
 <alpine.DEB.2.22.394.2111171724330.1412361@ubuntu-linux-20-04-desktop>
 <59e14393-a1fc-5b82-2f6e-5567f218cb3a@suse.com>
To: Juergen Gross <jgross@suse.com>,
 Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LNXP265CA0015.GBRP265.PROD.OUTLOOK.COM
 (2603:10a6:600:5e::27) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 7cf176aa-83ae-4c0f-c754-08d9b963dc32
X-MS-TrafficTypeDiagnostic:
	PA4PR08MB6064:EE_|DB5EUR03FT050:EE_|AM0PR08MB4499:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB4499CC5D3DB6065257B6F896E46E9@AM0PR08MB4499.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Ujms3BnoEnS3my+0jUwxF130ofLPC0QE1eQ5X/PF/G36LPqU2RUTLX8s86guPeoKPxwTJlPM1Q+d/C8XT/xnEYmwWX++XHWHAyqbyOHioikrvo3+MXLUUKyJgDmTID49OkWcSLpgZ3/qjwTRjsfm78BGBa7QgOrTHSegpbc7/NngfE2qkAe96NFRFGWbGXr1PgkQRQMRYnbAcL0pSThwOypUlue2aXs0sraRbL+jQ4ImzXPiuPrVu3KGkqAiiijKI1C4nqHKX5yw3C4g/AiVpwPx56DCw2JvRb22dgqUlGJUGaIHSkoFf6zib1FHjUFXlA56kEVe1N6SaBfuLguRdVYlrZNxaXnmXJoWRGHZl8rN6kCh6cAMe4XLSLwxy+RFXDkwogG4wqmsJj4bNcs+qAW4luf6rGRFaK2x2ICbMZtbYsZsPHOnsrpUa/P31ZhJb0JmJUrTO0vNcNJYtXWZ68ZU7+rf8/dSvgGShVHvNsLAvbWfzySu1AQ+ymFXcfKv5zC+Rsuw8+LJt4zCbQr8ED+XgSR2JSytVOsLDqgHcceAx2CYEwGSnn7acJ4qjmpMYPSqBzrJ88pClg17nBtm03n3rH3NaToFPzY9KaUPZ37J+19/TE5qyZhfJLh9QCQ5y6/2jHrvywL0S+pJYCSqDN0FnHajbQhPhZaIPgMD9TgXpn2yOrKqNRLELc3ujxHAoOxEUCCNFAapwF33xdC4qoMFmwH4C8i3YB7lKEf6uVg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(6486002)(4326008)(5660300002)(86362001)(8936002)(44832011)(8676002)(6506007)(52116002)(2616005)(110136005)(956004)(33656002)(2906002)(316002)(26005)(6512007)(66946007)(66476007)(36756003)(66556008)(38100700002)(54906003)(38350700002)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6064
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2de9d51a-f516-453e-279b-08d9b963d382
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	kAQmgTDwua9HP+MO/M3PgXFpnynCl8GEBwnrvO9l9VA7RVt+wr3C/BbYeWJBX3NXf58iDOWJ4RZzYb6XMpkxiOyGkcMK0RHI7cieVpk+loGqjPmrDCFF8v4NZ8FcAihq1qfqeDaJKfbv5JDKEImuUp9QhEnNGzloJV4XHhz6OPgV0bcQdD2frE+scWQDtd3BgYf/dpcecUkWh9m/Ms03hcIFQrxbIIdwA/YDaf0NkX7Hu2+6GwZPEMARqfDqpF3NDUqJr9o7765hAO8bwBaZNALn4IDmuaCZNEfAyEAMMEurqi5RyiiFXKUhdfAnOEbXA8iulLMBeVCAudAoZvZDiOVfAcRVc9STD50t5zlgDObCSsUBdtST85wx3TkeCFYbu52UFiRUIKR/x4LAzpeWZwAdJsDGAHzfRuYnGGdyBEFLs+lkE+GHrMQeDDKFge8+dF9zJQx9sv7v3uBu3HX/9OK+y0TAcbQbjjeWTViuv+m37KPfHjKXLhOAk29HvGzUJu/qyLgwJ5SLw1XLZoxcNy+RDi/9329c1rv+JusX/vPmkgUAn8Ez53s4Jftz+87hOBO8Xg4wJGqelYCX4s+ZKbjZ2nxFUdNcSAZ7chgoW9kHDazThen6Q4gRgbTVJEQsFpmvkw1igvVD8XajdGWYScrFXyOEQnk7S+Av/PACks19RhdrCsNBwFYde8ks4FXhOreXsSSBLo5LhPzI+QJNtg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(33656002)(4326008)(86362001)(6512007)(36860700001)(44832011)(70206006)(70586007)(2616005)(107886003)(956004)(54906003)(336012)(316002)(8936002)(110136005)(6506007)(186003)(356005)(5660300002)(6486002)(81166007)(508600001)(82310400004)(8676002)(2906002)(36756003)(47076005)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:27:59.6852
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cf176aa-83ae-4c0f-c754-08d9b963dc32
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4499

Hi all,

Thank you for all your feedbacks, sorry for the late response. Given the am=
ount of suggestions I=E2=80=99ve been working
on a proposal for the boot time cpupools that I hope could be good for ever=
yone.

The feature will be enabled by CONFIG_BOOT_TIME_CPUPOOLS, so without it eve=
rything is behaving as now.

When the feature is enabled, the code will check the device tree and use in=
formations from there to create the cpupools:

a72_1: cpu@0 {
        compatible =3D "arm,cortex-a72";
        reg =3D <0x0 0x0>;
        device_type =3D "cpu";
        [...]
};

a72_2: cpu@1 {
        compatible =3D "arm,cortex-a72";
        reg =3D <0x0 0x1>;
        device_type =3D "cpu";
        [...]
};

cpu@2 {
        compatible =3D "arm,cortex-a72";
        reg =3D <0x0 0x2>;
        device_type =3D "cpu";
        [...]
};

a53_1: cpu@100 {
        compatible =3D "arm,cortex-a53";
        reg =3D <0x0 0x100>;
        device_type =3D "cpu";
        [...]
};

a53_2: cpu@101 {
        compatible =3D "arm,cortex-a53";
        reg =3D <0x0 0x101>;
        device_type =3D "cpu";
        [...]
};

chosen {

    cpupool_a {
        compatible =3D "xen,cpupool";
        xen,cpupool-id =3D <0>;
        xen,cpupool-cpus =3D <&a72_1 &a72_2>;    =20
    };
    cpupool_b {
        compatible =3D "xen,cpupool";
        xen,cpupool-id =3D <1>;
        xen,cpupool-cpus =3D <&a53_1 &a53_2>;
        xen,cpupool-sched =3D "credit2";
    };
   =20
   [=E2=80=A6]

};

So for every node under chosen with the compatible =E2=80=9Cxen,cpupool=E2=
=80=9D, a cpupool is created (if it doesn=E2=80=99t exists).

Mandatory properties of that node are:=20
 - =E2=80=9Cxen,cpupool-id=E2=80=9D which identifies the id of the pool
 - =E2=80=9Cxen,cpupool-cpus=E2=80=9D which lists the handle of the cpus

Optional property is =E2=80=9Cxen,cpupool-sched=E2=80=9D which is a string =
that identifies the scheduler. A cpupool with identifier
0 (zero) can=E2=80=99t have that property, it will get the default schedule=
r from Xen.

A set of rules are applied:

  1) The cpupool with id 0 is always created, being it listed or not in the=
 DT
  2) The cpupool with id 0 must have at least one cpu, if it doesn=E2=80=99=
t the system will panic.
  3) Every cpu that is not assigned to any cpupool will be automatically as=
signed to the cpupool with id 0=20
      (only cpu that are brought up by Xen)
  4) When a cpu is assigned to a cpupool in the DT, but the cpu is not up, =
the system will panic.

So, given this explanation, the above example will create a system with two=
 cpupool:

 - cpupool with id 0 containing 3 cpu a72 (two are explicitly listed, one w=
as not assigned to any other cpupool)
 - cpupool with id 1 containing 2 cpu a53 (cpus explicitly listed)

Clearly the above example works only if Xen is started using the hmp-unsafe=
=3D1 parameter, otherwise some cpus
won=E2=80=99t be started.


Given the above example, we might be able to have an option like this (=E2=
=80=9Cxen,domain-cpupool-id=E2=80=9D) to assign
dom0less guests to cpupools:

chosen {

    cpupool_a {
        compatible =3D "xen,cpupool";
        xen,cpupool-id =3D <0>;
        xen,cpupool-cpus =3D <&a72_1 &a72_2>;    =20
    };
    cpupool_b {
        compatible =3D "xen,cpupool";
        xen,cpupool-id =3D <1>;
        xen,cpupool-cpus =3D <&a53_1 &a53_2>;
        xen,cpupool-sched =3D "credit2";
    };
   =20
    domU1 {
        #size-cells =3D <0x1>;
        #address-cells =3D <0x1>;
        compatible =3D "xen,domain";
        cpus =3D <0x1>;
        memory =3D <0x0 0xc0000>;
        xen,domain-cpupool-id =3D <1>;            /* Optional */
        vpl011;

        module@0 {
            compatible =3D "multiboot,kernel", "multiboot,module";
            [=E2=80=A6]
        };
    };

};


Any thoughts on this?

Cheers,
Luca




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:28:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:28:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240782.417505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWm6-00059d-GW; Tue, 07 Dec 2021 09:28:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240782.417505; Tue, 07 Dec 2021 09:28:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muWm6-00059W-Cx; Tue, 07 Dec 2021 09:28:38 +0000
Received: by outflank-mailman (input) for mailman id 240782;
 Tue, 07 Dec 2021 09:28:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muWm4-000597-UR
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:28:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c8d2c15-5740-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 10:28:35 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-vxk_XcoNPf2WHUkngk-OEw-1; Tue, 07 Dec 2021 10:28:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6304.eurprd04.prod.outlook.com (2603:10a6:803:fd::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Tue, 7 Dec
 2021 09:28:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 09:28:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:20b:92::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.11 via Frontend Transport; Tue, 7 Dec 2021 09:28:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c8d2c15-5740-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638869314;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=lfcSPe1W1IJzWhvNWEVpuh7t8+DZxBDrBzdcSgNnuys=;
	b=WKo3Fn8k8l4cfFNssYzktU7IG1sviYp09BTYXjQdITTyVt5p2bIn/hPRZq7pHlXzsA+WC6
	oiIksPYDQ8oVXIF2V16HQ0/pAhX7I2F9L3G99tDQwTokgdOXXHEsMJkXS6E0RhVYBsSrrK
	R24gXMsDGfu8B96QbV4RkNQgIxdub04=
X-MC-Unique: vxk_XcoNPf2WHUkngk-OEw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RBgAwGH+erjFAl51lYAhaDXaAXIpPMgRtHxQ8HHSo7Cot4S8/4GOOAE6OA9JtzvD16i3krudw1PXnDSEYdiNoOtF5o6yRRnRJ+wyjQFzb6I2o5Lo/beiqkpvt0XXxKhUhKs/DWtDV97Jt1CnfsKYDBjsQ8F0+4nw2+MfPqERX2xrQpV6pAIGD6VKyo2XOxrpIjnioMFdPtDlCJetoIQXEeUA4M+rPfAo2knJQP3IMssBIhbRpWQ8EFelT1iqB06ezO9P8U1iLrXJHPSy7YnGZbicZkKDGgDSyAqd3IC1zXvlhbdfzhCA6jvdGzxclJ9kweMJyv4IeA/SKscVDdfAEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JiteJttIURtn9v2zxI5oX4XFbu5Jd/LPlFnN4ErCAAs=;
 b=akBFeAw7e0MinXpHAHUWzSUtA9q+HYp9jKrPrFr5pv0fJJVAa0PPs01SrhShzXU/NjYgj0NccY78y1JF6vVBcIXjkcrvwMY3SwwAuBB9xc8tN0wfpn+zJ1BX1ga9+jh4403w5oAazACPWhTknfl9iHnN5pB5PxXEwaGBrXHBx7IAnCvaxscJ2dHlBJwmq3zVc5u7C5uSJZRM6sH5/ekwzcZdRmXnqZAcBh6OpD4tEF7yT7UqIiq5XRipwin2Jh8V0bDRywOGurspzJ67U+IUtwyoIIgh4OzsK1brz0Pu7pj7GHJ3fFkipS6lwie5VzWvqN8PVLP7GiUp2c189dRUfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <50a8c9c3-9d44-1cd3-d456-a78a03835799@suse.com>
Date: Tue, 7 Dec 2021 10:28:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v3 01/10] xen: introduce XEN_DOMCTL_CDF_INTERNAL_directmap
Content-Language: en-US
To: Penny Zheng <Penny.Zheng@arm.com>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Michal Orzel <Michal.Orzel@arm.com>, "julien@xen.org" <julien@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <20211116052506.880728-1-penny.zheng@arm.com>
 <20211116052506.880728-2-penny.zheng@arm.com>
 <DU2PR08MB7325137A71A2D7277F1A1650F76E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <DU2PR08MB7325137A71A2D7277F1A1650F76E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0020.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 97822326-73a5-4dbb-84cf-08d9b963ef3e
X-MS-TrafficTypeDiagnostic: VI1PR04MB6304:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63044BCC594BB552D98A1717B36E9@VI1PR04MB6304.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LnWrOc/waiwiMhMMnB0P6Te9SGz3+6efik7gyp0m3dlkhYfoLMUZGL01MPzF4Tkg+1be0/tUw4VnEZOz7Du1bpTxBxYn4uriYtx6asUxSgyOkT82p2nJR6VnYTpE3XwUKEeRplEK9rk/uhL84sQEYBefI5x5cXBSBfEzXUqQebcfXlY9zZgujLFpyN/z8OOWCuO75Jvxz5gZj6SJSweYlJXEMUpacutjdlX3AEJVXohh2MYwt/jYqbMMf1bj9yZdMJNn9D2yj2Z3PfgUVfA/f24Doe7l1ZhYArZdHDmR0kLRkIcvl8OGplUyDdT8FefCrw3LH11fOw9mCaQ0cREgWSof/n3q6nKQZv74rLkTVZuftf53/WhlXqQ7UZ5SsL85T6H7Sgv5hmAKKcnvWHu4PWBrSfOYmWPaoCwNbRwqzxuYYuVW2dqolNaVpZHYcEZMI3axrYZLMtgsJjv8TJyvfB+1ThslbRldtHMHscUT78wbExbzPVl7e2yyKXb57on/BbhpFHgwO6jb8obG50E1M91AAKsD3w1NWw7COuvOjdgX4BTjZac7DiQg7jvmOUg2Fm42LuQ+wAFpiD99sYZq8739BGcM60MAzfgtbygjnJcf1UH04m5eM0tlZ/x7ZdZ4IkAmDkJO8OXLK21Uk5g/1A5O0v3hAh4QcWdkmGpRhdEPvjI5m09kWRG4tAGBesnLLj6Qcmil8shmpv6c9YGMm/QQoHInf2DA4sKkvTTnbX0D6D6v4PhsDAGULIjN6Bafo77Tk0LA2E26856Vbnc7kxWFFgbNOpkHJ1lmcWntHGQptRvC/jjLAO8WhE3NAZQ8DoBe0A4Xt6RN/MSoFbC8rw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(5660300002)(6486002)(36756003)(31686004)(66556008)(8936002)(31696002)(38100700002)(316002)(16576012)(54906003)(2616005)(86362001)(66476007)(66946007)(956004)(26005)(966005)(4326008)(53546011)(6916009)(2906002)(508600001)(6666004)(186003)(83380400001)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cI6ehfjnwfQtWbYCMhq0ToRKDTq9cFzpHUSc6nKLeeYmpHkxRhkq9qlWshY0?=
 =?us-ascii?Q?LOFW3FYDreoh8FlXszcxnsgyxhdVnKT7+tqMopwQMUjyTKkPkuArx6KjAAd9?=
 =?us-ascii?Q?LIh9HYhs+Lq+R+UhPKrSBmY06bJ25fA38IPnotyGIr1DOdPMNQhYvAqeQ0Nb?=
 =?us-ascii?Q?r6qOXVJs7NfsEzPlw9NJ1HjiPFmFi5H2uzqgfCbsbY13Ilq60hxL58EqG0ct?=
 =?us-ascii?Q?xqqElHF09SkfuFicgYQaqIny0uoZDduUJo0tFG1biy+/gukLVRN+K4xBEA61?=
 =?us-ascii?Q?1rIxguXEOEC3G6p6Js0gdvtux1avdPQ3kQMon1rwtgW/uAYUN8uH3B7VLNx9?=
 =?us-ascii?Q?LoU8DCgzjkkhofyOc+agF8mGgF+whX9TGfg5GUAAjJQEYkm9cBlVUoVIXa+t?=
 =?us-ascii?Q?A+crqS0Hm/ddVvcYDGohHtH3DVgy+cX/mwbpl9KWd5zI8Ph1q4HpyIjl5cek?=
 =?us-ascii?Q?fOraDgFPqHwEBKiUJX6bQA+vn2OPwSLvYr5/B2NZ5NVFtRY1PyeKVmoapdXq?=
 =?us-ascii?Q?6bFCMgKatn1XW0v2xGdElpxbtJ76towHESNQe5YlDtXTXglpqhCjyap0mRHn?=
 =?us-ascii?Q?Lq8rfGB4FSrJQkclD347LJanCwXVF+lKwdpw1ibgB8dhPang8oFD6YdqON+t?=
 =?us-ascii?Q?MLzbDgOfbwa8Y8Z/+vPNhLZKVF4GZK1hIIBB/IfkR+WFI2iLuRHuEStDthiD?=
 =?us-ascii?Q?Lgl8oA8/5rtSOrF0euZ8CNnmNGXW4VHjpag28GKRnNn64xA8/yg7KPfb+k3e?=
 =?us-ascii?Q?XFxYKEskaa3b5xO761UmEfhJvRlafWsWH5bkW/kg7LI3JHsQttpp169Fq9+H?=
 =?us-ascii?Q?xlKftuogbvGtJIvgKXDUt3P3urFXchXbct2PbOEMDtJFUzhnAx5EHD6cb/nD?=
 =?us-ascii?Q?1ZAaCo6WXtTJiz34GR8neeCkxi17MMSiuYYApLxOd6dhf2do8chnO8G6DCY0?=
 =?us-ascii?Q?j4Yiikyr1Mqdms9jGNAs6buxb+p6bHRD9lrs7pLZmMDQepOlkh5rCeiKB6fT?=
 =?us-ascii?Q?pB8+u4no+y/hOIvi9X6ToZc+k3l/n/XKqYnterId6xYzry590nIq/q0EfPcl?=
 =?us-ascii?Q?Dp437X339aBEFaDzGEu5H9dR04YHXEq5oDk7+iACE62yoIQ8v0AKmL/cFchn?=
 =?us-ascii?Q?2+SfjUwuTcxWoJg+tMzJVm8ZaQ8jKUWZY9sgxQQQZn6gyud5xlVPqKcDw6Ri?=
 =?us-ascii?Q?q4idTVITG+foaSWvHeIqhrqWmdGUJuGUWQ7NAaldfMsX48hVVRwz6Keunwa+?=
 =?us-ascii?Q?34NeMTj9dz/VW83eP5fqTsWjwi5m8Yi+h1S6hUsO/etYfA0ZdbHPQ3BrNt47?=
 =?us-ascii?Q?9zDA4AcVNxaCvz9e32hp6VKn0UOWIPNHZCgFmtsdJUD+r6FIlaK0Q0aezn5n?=
 =?us-ascii?Q?v9wxgs7R0m7+ksU32IjNpCxO/YsOGfrdk0Wf0T1/01TsxvE2xeHnkrFIbhgs?=
 =?us-ascii?Q?Iy2HhiVd8viwofQvVKafkawVAtYDe+JFmcid/+3gjOuTOR85iRxiiC2gN3+y?=
 =?us-ascii?Q?YcUYKlCXizCwc3yWAcN40mxqz2m25sv6FndsWg9Y7+tTQtldIohABmwysgm+?=
 =?us-ascii?Q?XE297KPyDudMJqSET2hmVZmS/0sTA/CepMiV/XOlnaGNE+sgoZDzJkv3+Yxp?=
 =?us-ascii?Q?mJjWLCsK2SzkX8rc8rAycKM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97822326-73a5-4dbb-84cf-08d9b963ef3e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:28:31.8517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZbaCD28dTVHJz+rM3Q3pq7BC7Et3GPbdqBwtCD/WhgwctgVgCi1wXPbmrkZkC8JOxiru4QsvOJrmHupCEVr/8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304

On 07.12.2021 10:15, Penny Zheng wrote:
> Hi guys
>=20
>> -----Original Message-----
>> From: Penny Zheng <penny.zheng@arm.com>
>> Sent: Tuesday, November 16, 2021 1:25 PM
>> To: Penny Zheng <Penny.Zheng@arm.com>
>> Cc: nd <nd@arm.com>
>> Subject: [PATCH v3 01/10] xen: introduce
>> XEN_DOMCTL_CDF_INTERNAL_directmap
>>
>> From: Stefano Stabellini <stefano.stabellini@xilinx.com>
>>
>> This commit introduces a new arm-specific flag
>> XEN_DOMCTL_CDF_INTERNAL_directmap to specify that a domain should
>> have its memory direct-map(guest physical address =3D=3D physical addres=
s) at
>> domain creation.
>>
>> Since this flag is only available for domain created by XEN, not exposed=
 to the
>> toolstack, we name it with extra "INTERNAL" to distinguish from other pu=
blic
>> XEN_DOMCTL_CDF_xxx flags, and add comments to warn developers not to
>> accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag=
.
>>
>> Refine is_domain_direct_mapped to check whether the flag
>> XEN_DOMCTL_CDF_INTERNAL_directmap is set.
>>
>> Signed-off-by: Penny Zheng <penny.zheng@arm.com>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
>> ---
>> CC: andrew.cooper3@citrix.com
>> CC: jbeulich@suse.com
>> CC: George Dunlap <George.Dunlap@eu.citrix.com>
>> CC: Ian Jackson <ian.jackson@eu.citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: "Roger Pau Monn=C3=A9" <roger.pau@citrix.com>
>> ---
>> v2 changes
>> - remove the introduce of internal flag
>> - remove flag direct_map since we already store this flag in d->options
>> - Refine is_domain_direct_mapped to check whether the flag
>> XEN_DOMCTL_CDF_directmap is set
>> - reword "1:1 direct-map" to just "direct-map"
>> ---
>> v3 changes
>> - move flag back to xen/include/xen/domain.h, to let it be only availabl=
e for
>> domain created by XEN.
>> - name it with extra "INTERNAL" and add comments to warn developers not =
to
>> accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag=
.
>> - reject this flag in x86'es arch_sanitise_domain_config()
>> ---
>>  xen/arch/arm/domain.c        | 3 ++-
>>  xen/arch/arm/domain_build.c  | 4 +++-
>>  xen/arch/x86/domain.c        | 6 ++++++
>>  xen/common/domain.c          | 3 ++-
>>  xen/include/asm-arm/domain.h | 4 ++--
>>  xen/include/public/domctl.h  | 4 ++++
>>  xen/include/xen/domain.h     | 3 +++
>>  7 files changed, 22 insertions(+), 5 deletions(-)
>>
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index
>> 96e1b23550..d77265c03f 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -629,7 +629,8 @@ int arch_sanitise_domain_config(struct
>> xen_domctl_createdomain *config)  {
>>      unsigned int max_vcpus;
>>      unsigned int flags_required =3D (XEN_DOMCTL_CDF_hvm |
>> XEN_DOMCTL_CDF_hap);
>> -    unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu |
>> XEN_DOMCTL_CDF_vpmu);
>> +    unsigned int flags_optional =3D (XEN_DOMCTL_CDF_iommu |
>> XEN_DOMCTL_CDF_vpmu |
>> +                                   XEN_DOMCTL_CDF_INTERNAL_directmap);
>>
>>      if ( (config->flags & ~flags_optional) !=3D flags_required )
>>      {
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 19487c79da..664c88ebe4 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -3089,8 +3089,10 @@ static int __init construct_dom0(struct domain *d=
)
>> void __init create_dom0(void)  {
>>      struct domain *dom0;
>> +    /* DOM0 has always its memory direct-map. */
>>      struct xen_domctl_createdomain dom0_cfg =3D {
>> -        .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap,
>> +        .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>> +                 XEN_DOMCTL_CDF_INTERNAL_directmap,
>>          .max_evtchn_port =3D -1,
>>          .max_grant_frames =3D gnttab_dom0_frames(),
>>          .max_maptrack_frames =3D -1,
>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index
>> ef1812dc14..eba6502218 100644
>> --- a/xen/arch/x86/domain.c
>> +++ b/xen/arch/x86/domain.c
>> @@ -692,6 +692,12 @@ int arch_sanitise_domain_config(struct
>> xen_domctl_createdomain *config)
>>          return -EINVAL;
>>      }
>>
>> +    if ( config->flags & XEN_DOMCTL_CDF_INTERNAL_directmap )
>> +    {
>> +        dprintk(XENLOG_INFO, "direct-map cannot be enabled yet\n");
>> +        return -EINVAL;
>> +    }
>> +
>>      return 0;
>>  }
>>
>> diff --git a/xen/common/domain.c b/xen/common/domain.c index
>> 56d47dd664..13ac5950bc 100644
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -486,7 +486,8 @@ static int sanitise_domain_config(struct
>> xen_domctl_createdomain *config)
>>           ~(XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap |
>>             XEN_DOMCTL_CDF_s3_integrity | XEN_DOMCTL_CDF_oos_off |
>>             XEN_DOMCTL_CDF_xs_domain | XEN_DOMCTL_CDF_iommu |
>> -           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu) )
>> +           XEN_DOMCTL_CDF_nested_virt | XEN_DOMCTL_CDF_vpmu |
>> +           XEN_DOMCTL_CDF_INTERNAL_directmap) )
>>      {
>>          dprintk(XENLOG_INFO, "Unknown CDF flags %#x\n", config->flags);
>>          return -EINVAL;
>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>> index 9b3647587a..4f2c3f09d4 100644
>> --- a/xen/include/asm-arm/domain.h
>> +++ b/xen/include/asm-arm/domain.h
>> @@ -29,8 +29,8 @@ enum domain_type {
>>  #define is_64bit_domain(d) (0)
>>  #endif
>>
>> -/* The hardware domain has always its memory direct mapped. */ -#define
>> is_domain_direct_mapped(d) is_hardware_domain(d)
>> +#define is_domain_direct_mapped(d) \
>> +        (d->options & XEN_DOMCTL_CDF_INTERNAL_directmap)
>>
>>  struct vtimer {
>>      struct vcpu *v;
>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h i=
ndex
>> 1c21d4dc75..054e545c97 100644
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -72,6 +72,10 @@ struct xen_domctl_createdomain {
>>  #define XEN_DOMCTL_CDF_nested_virt    (1U <<
>> _XEN_DOMCTL_CDF_nested_virt)
>>  /* Should we expose the vPMU to the guest? */
>>  #define XEN_DOMCTL_CDF_vpmu           (1U << 7)
>> +/*
>> + * Be aware that bit 8 has already been occupied by flag
>> + * XEN_DOMCTL_CDF_INTERNAL_directmap, defined in
>> xen/include/xen/domain.h.
>> + */
>>
>>  /* Max XEN_DOMCTL_CDF_* constant.  Used for ABI checking. */  #define
>> XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_vpmu diff --git
>> a/xen/include/xen/domain.h b/xen/include/xen/domain.h index
>> 160c8dbdab..2b9edfdcee 100644
>> --- a/xen/include/xen/domain.h
>> +++ b/xen/include/xen/domain.h
>> @@ -28,6 +28,9 @@ void getdomaininfo(struct domain *d, struct
>> xen_domctl_getdomaininfo *info);  void arch_get_domain_info(const struct
>> domain *d,
>>                            struct xen_domctl_getdomaininfo *info);
>>
>> +/* Should domain memory be directly mapped? */
>> +#define XEN_DOMCTL_CDF_INTERNAL_directmap      (1U << 8)
>> +
>=20
> I run into some trouble with defining this flag internal in the new serie=
.
>=20
> Let me explain in details here:
>=20
> 1. Currently XEN_DOMCTL_CDF_MAX is set to XEN_DOMCTL_CDF_vpmu.
> So we can say that XEN_DOMCTL_CDF_MAX knows that there are 8 CDF flags(0 =
to 7).
> The corresponding ocaml tool has a list of CDF flags and currently it kno=
ws that there are 8 CDF flags:
> https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3Dtools/ocaml/libs=
/xc/xenctrl.ml;h=3D7503031d8f61c2dbcd4aa803738c83e10dfb7bb8;hb=3DHEAD#l64=20
> This tool performs a check to see if the XEN_DOMCTL_CDF_MAX is equal to t=
he number of entries in domain_create_flag.
>=20
> 2. Here we are reserving bit 8 for internal flag XEN_DOMCTL_CDF_INTERNAL_=
directmap. As this is internal flag,
> I do not want to modify XEN_DOMCTL_CDF_MAX.
>=20
> 3. Everything is perfect until someone tries to add another global CDF fl=
ag:
>=20
> #define XEN_DOMCTL_CDF_next_flag  (1<<9)
> #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_next_flag
>=20
> XEN_DOMCTL_CDF_MAX shows right now that there are 10 flags but ocaml tool=
 sees only 9.
> then we are getting build error.
>=20
> Hmm, would you please help me find a way to fix this dilemma, thx.

This was already outlined, but let me do so again: You do _not_ want to
overlay with XEN_DOMCTL_CDF_*. domain_create() already has an internal-
only parameter. That's a "bool" right now and wants extending to an
"unsigned int" covering both the existing "is_priv" (step 1) and your
new "directmap" (step 2). To make visible the relationship, naming the
respective constants CDF_* (with no XEN_DOMCTL_ prefix to represent the
difference) might be appopriate.

Btw, as a result (if that's not the plan already anyway) you then
probably also want to decouple is_domain_direct_mapped() from
is_hardware_domain(), and hence create Dom0 also with the new flag set.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:55:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240794.417516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXCG-00019D-Ms; Tue, 07 Dec 2021 09:55:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240794.417516; Tue, 07 Dec 2021 09:55:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXCG-000196-HG; Tue, 07 Dec 2021 09:55:40 +0000
Received: by outflank-mailman (input) for mailman id 240794;
 Tue, 07 Dec 2021 09:55:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muXCF-000190-6D
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:55:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d3da8ebc-5743-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 10:55:37 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-HdPu2g8gOg6Im6CSo5W4sg-1; Tue, 07 Dec 2021 10:55:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 09:55:34 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 09:55:34 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::12) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Tue, 7 Dec 2021 09:55:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d3da8ebc-5743-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638870936;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Pj/lEd0HsPGhvb13IAIKSMVJynSm0L/NlAWjwyy29PE=;
	b=fsLs9PswpY5AwJK8rOMKBk5FwEHOCwY6aHWCiLEOGU5rdzfSz9Bqui5BVDfZ9Hfilq6r0E
	cGb+0pjMRMqtvX64QyCJPB/RzyBd+xG5d0SV6XhHcOfYtBGyJjYKaWS5RT+6YdODn2emVj
	/oytTOcNHmwmj3wJORWmPnGl9kgyWSE=
X-MC-Unique: HdPu2g8gOg6Im6CSo5W4sg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fs9g4by6A//JyJcsr6/Eg+zfiojOWl51YOB/cVSKhOZlu1MxdIG2UGhaaXfRj6h8CxkR+3RNxplMPExlXIY0mkkDoY6pkO+v2PoZwK8U4hcKBEdz0s3Pp4Cgd2Ze3uFKY0rwaCL01twLQeqWwF4JyzTP1Sy8olSXJgfMFerbLYwxfQKcxxJQLSv9GmhemDmgbwlG+E5DDyE0lhGNzIDWEJMimKUARp6az8BTf+9qgGon/RUtmM8fLBHl9ZyrTOMhEjvU38fEq+46B+l5QaTdHijiS9+iQOdFZn1uR8++dgd5ZnfccVZdKayF2gQ0mpmmcnBnv4p/5srQTV7tDjkd7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0KlHYmbH61dD+K/LUDBrR1FbJ+1p6kbQA6hhQnRTe8s=;
 b=i5aQ82rsOy0wlaP3UEdfmoLwg3W/p8ClqL3ku62AVS2YmhGhGNOhrxFbOEpqiTGm2uv9fNLDy1/uDOehNy383qN1fOlqnXjaUpwm5dj0kE2ZTaSwW7le4Cui854N1kGLzC+NqrDW41SSTv86+PzwOMnsSVULG9fj7s4h2cPswmSHRY5rHmhSlWof2qko2ff1jLXOVhPmvGdS6/5Klcg1igpzO+9trTpv1QsiQSEDuzM+2LyF3AA2xj1EEIMYZVuc6QKgWPUHOfMwkXUA6/CmsjJc6ZYsxPG7+Wbta6ifDVML56MgGfNMhwQwZlTKbAE/G90INa/bPRq9T1goPrlCag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <086feb9a-7d6b-3797-3643-1b4474e4a420@suse.com>
Date: Tue, 7 Dec 2021 10:55:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
CC: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Julien Grall <julien@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0033.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1c::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d13bca8e-fe16-449c-5103-08d9b967b66f
X-MS-TrafficTypeDiagnostic: VI1PR04MB5599:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55994B528B7E83873F3331E9B36E9@VI1PR04MB5599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HDI3WA9ezf+cHfYOFBl8SgFEbq0Ab2nxNqDyDOOdufkvKxaDWsqH4ZfYIv6ZEhbLezMOa+nTt9yUAJTG8nUQp3WM0cNtDOw/s6GBIMLRRe9+jvAqxc6hS+N0R3TRTAvw7tY0xBRxKG+3yBA6oLHS3G0N37gDjQUEq5rw8v49cL9bu1Ys5iLgZDAVxUaLgatxrxIt4g7dzXdHg0kg4SGHIqIN7sYjDhuiWQD9KezujtkjIdwl1SoXJ3X/K+WC2P8WJ1cREP85wF+krAuEG5/ebnNFd2xY8u0q/x2IF6wbhIKsYKomly7gT/JiZ7dAXwtdB9XWho+8vbJEDFeAPBvQKHXT+OpX6SvlgyszDp0ttNxoqXzDxHsYL2p5MeyqnjAUAChvg06me7sRGxBdVgaHLvvcAcc5uSxKguhG+LBoE/Q4RIN8MAlVRre6m6u69lA4smYjWBPVmqi12Gy083wMtwUv+15/sxS3Dez8YLQkrBZVSHtXyMDqyL8FNWOr4ylD99ETHhTHI5S1NyEoeLzK6eTlnJaZVGsMBzo9mubNiNrYtykHol7hza7Pkz/7pgN/DI0Q3+x9Ha3uELY4OGrVLFVSKAcRqjFlKVWHH8Nrqw2GlnyPQUKHpEmdzngaexIcdDnO6uW/icE19OVwLpDYUZrzbSnd4o17yM4RQw/cVKdO/cgvit6bHaSHBhGzy40vhU/3ZTdoJcMsPEPUBwFfPrdUvwe+eOIwOwr+/YvVo5U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(4326008)(508600001)(6916009)(66556008)(66476007)(66946007)(26005)(8676002)(86362001)(5660300002)(186003)(16576012)(2906002)(31686004)(316002)(83380400001)(38100700002)(6486002)(2616005)(36756003)(956004)(54906003)(53546011)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cwAwcfwiGt6Z09OtGa2Rjd0LtGZCnBUHqLloyAOfk14tdXdhp7cp8iWIuLfL?=
 =?us-ascii?Q?oME67i/XfGAZQU3Up6De/M3MqsRYLYtb7X25/XbS0e5wGUn7EhOy/jh1/fkn?=
 =?us-ascii?Q?fbm/VAyWR/ADGyd4Utfyd+BGXZmqE+X51OWQtXIAs1b7MffXG9TgCmGrJTj1?=
 =?us-ascii?Q?VLDoBJwWWbbpUdSPBrIClIfUx6O/9lBBw3xG2J6qHN3zIji5xbLE3kkvb9Dq?=
 =?us-ascii?Q?FJ3t82mickjZdZqxwcLqfmgPlYWZRBJoOQVxvj8z7aYrV4Lb+En3IxQqmXd2?=
 =?us-ascii?Q?mg9tomCRe6/YkuDY0U2fh2rPXIjqILx4K0tXLtO/Y0qRMR+BusKdsmyvIdZ1?=
 =?us-ascii?Q?qGJl9yoUfsg40KlAsXiZXiB7MFQOjGyNGN7gkPmvWTApgJsCdzD7W6JaBH03?=
 =?us-ascii?Q?EDFOydKOvZ0a88A8BZg1zfXrGOAt5K5COUi2+D3Zslb00ljhbokmsDn+CINb?=
 =?us-ascii?Q?cnwQxMnv2DoI+GwwkD/yfRwg9XmM5a7AdRxwwOE4dUrpAfefvbYU9K4B2y6M?=
 =?us-ascii?Q?2bD+v984Nwe8SPBvsbr2tmmMBKaT4hCIeCC4PJY8aThHf3Z9w4oB4UTWFzSZ?=
 =?us-ascii?Q?o3rvFkM7aKOtWu0kcN5U3QhkWoLH3hM9xanTHS2Zb2Bnu/0xUwP5hZZD9aVk?=
 =?us-ascii?Q?IzfJjiOSY4I5t2MPZ9M1WlEYpXAWIDL6RvVXnZtMlLEHXkfvmA6umcYy5ESB?=
 =?us-ascii?Q?kzCPFJ7uVwD/1K+BXmP715NE8pvqhNkBkzLNuGGmByO8q9ZQj5jCHUgb+3d6?=
 =?us-ascii?Q?ici3bl1RUJBfWcUVMImUSQgXY2oDJqvZHnrt93iydTjN3y7uE2SYkMRf8zYa?=
 =?us-ascii?Q?O7nN3vNpGXbWy4np5a4f2/i/yxOabnqQSu0Fe03h0UDToEZrdAGdDp/kHyS5?=
 =?us-ascii?Q?+Su3xyRQHilYRBxL6bSL2I8hGWyq30kWOHR40SpuxPGhA4w3IyJChyklAyfM?=
 =?us-ascii?Q?MvMj+M6pY0pdbHiCf+4W6/UHJtI3hioQ9AiYvMmPOpMSyEHFprUvdjPrIyBR?=
 =?us-ascii?Q?zhG8YqRnYCxsz/QZf4RqP5McQHlJnXGQQNGC3a0eNSWQg/uU1Xo3BuS6eUqG?=
 =?us-ascii?Q?4/iPviGQ8KC9QaBCtgLf282RFy8iV0r1YmUDM0NeINiD5V/XTVigP93FMkhc?=
 =?us-ascii?Q?SRrcdrd3MDqTij6fV+YLjkPguPfxeuTTr6+wbwJF73kDhuZ+Q2ANc4ORLGJq?=
 =?us-ascii?Q?EpMjEZXStE7YN0TTEYE6IL2DxnIHHaWXbH7HYOv61WcPNX9rK+cGHMlbFrV4?=
 =?us-ascii?Q?uOfmiBeURPLsmrzW052PtvwOGw3yTm8WbDnYgXDeBGq9HKi3cRMDDEt3Wi6l?=
 =?us-ascii?Q?c1l4NL7KvqLo4WoSV9pW+5ZJ0FDhoJMcQCebP0J91iDQxjjepd6mAA820VqX?=
 =?us-ascii?Q?mXCJDuRcjxWyu1AUTwvqxATQbwDXAHeXkHJrf0jod44gR7gQOgM/eQGTQBKK?=
 =?us-ascii?Q?aVSIJXfF21fkEAc38dX19TZ2iLncuGstm1j3A8N4FogmWs8j1xw2vn7+Q6x4?=
 =?us-ascii?Q?7diB1t1Z72LmAqTs3uUsTdxolkRVV05v+FGP9BSgf7ogfSoz40uO4GboFSE8?=
 =?us-ascii?Q?QBvHVPInzI5T1yIcP6TG8KTK5GvQlt3OY6zgrd7PRfApb5gfX45XekuPVOkZ?=
 =?us-ascii?Q?qqftl7hA8qMJ5VAhB7YkOTo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d13bca8e-fe16-449c-5103-08d9b967b66f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 09:55:34.5003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MgQz/pHFGeUVgap+IlAY66ZZjwc2+KjH5S3PsM81vUTfp06PQWPtvojHrKsw467K3WPty2E/WMu1mLFhqbAgoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599

On 07.12.2021 09:37, Michal Orzel wrote:
> On 06.12.2021 16:29, Julien Grall wrote:
>> On 06/12/2021 14:20, Michal Orzel wrote:
>>> to hypervisor when switching to AArch32 state.
>>>
> I will change to "from AArch32 state".
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>
>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>
> Ok.
>>>
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed.
>>
>> Can you outline why this is a problem and why we need to protect? IIRC, =
the main concern is Xen may misinterpret what the guest requested but we ar=
e not concerned about Xen using wrong value.
>>
> I would say:
> "
> The reason why this is a problem is that there are places in Xen where we=
 assume that top 32bits are zero for AArch32 guests.
> If they are not, this can lead to misinterpretation of Xen regarding what=
 the guest requested.
> For example hypercalls returning an error encoded in a signed long like d=
o_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
> if the command passed as the first argument was clobbered,
> "
>>>
>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>> entry to hypervisor when switching to AArch32 state.
>>>
>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>> when not passed.
>>
>> Which error do you see otherwise? Is it a compilation error?
>>
> Yes, this is a compilation error. The errors appear at each line when "en=
try" is called without passing value for "compat".
> So basically in all the places where entry is called with hyp=3D1.
> When taking the current patch and removing default value for compat you w=
ill get:
> ```
> entry.S:254: Error: ".endif" without ".if"
> entry.S:258: Error: symbol `.if' is already defined
> entry.S:258: Error: ".endif" without ".if"
> entry.S:262: Error: symbol `.if' is already defined
> entry.S:262: Error: ".endif" without ".if"
> entry.S:266: Error: symbol `.if' is already defined
> entry.S:266: Error: ".endif" without ".if"
> entry.S:278: Error: symbol `.if' is already defined
> entry.S:278: Error: ".endif" without ".if"
> entry.S:292: Error: symbol `.if' is already defined
> entry.S:292: Error: ".endif" without ".if"
> entry.S:317: Error: symbol `.if' is already defined
> entry.S:317: Error: ".endif" without ".if"
> ```

An alternative might be to use

.if 0\compat

>>> --- a/xen/arch/arm/arm64/entry.S
>>> +++ b/xen/arch/arm/arm64/entry.S
>>> @@ -109,8 +109,16 @@
>>> =C2=A0=C2=A0 * If 0, we rely on the on x0/x1 to have been saved at the =
correct
>>> =C2=A0=C2=A0 * position on the stack before.
>>> =C2=A0=C2=A0 */
>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .macro=C2=A0 entry, hyp, co=
mpat, save_x0_x1=3D1
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .macro=C2=A0 entry, hyp, co=
mpat=3D0, save_x0_x1=3D1
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sub=C2=A0=C2=A0=
=C2=A0=C2=A0 sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
>>> +
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Zero the upper 32 bits o=
f the registers when switching to AArch32 */
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .if \compat =3D=3D 1=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 /* AArch32 mode */
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .irp nr,0,1,2,3,4,5,6,7,8,9=
,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mov w\nr, w\nr
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .endr
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 .endif
>>
>> So Jan mentioned, the x0/x1 may have already been saved. So you may need=
 to fetch them from the stack and then clobber the top 32-bit.
>>
> So I would do the following:
> -fetch x0/x1 from the stack
> -clobber them
> -store them again on the stack
>=20
> /*
>  * Zero the upper 32 bits of the gp registers when switching
>  * from AArch32.
>  */
> .if \compat =3D=3D 1      /* AArch32 mode */
>=20
> /* x0/x1 have already been saved so fetch them to zero top 32 bits */
> .if \save_x0_x1 =3D=3D 0
> ldp     x0, x1, [sp], #(UREGS_kernel_sizeof - UREGS_X0)
> .endif
>=20
> .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,=
25,26,27,28,29
> mov w\nr, w\nr
> .endr
>=20
> .if \save_x0_x1 =3D=3D 0
> stp     x0, x1, [sp, #-(UREGS_kernel_sizeof - UREGS_X0)]
> .endif
>=20
> .endif

Wouldn't it be more efficient to store 32 bits of zero each into the
high halves of the respective stack slots? Afaict same code size, but
less memory / cache traffic. Plus it would avoid the latent issue of
a user of the macro actually expecting the two registers to retain
their values across the macro invocation.

I'm also puzzled by the two different memory addressing forms, but I
can easily see that I may be lacking enough Arm knowledge there.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 09:59:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 09:59:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240804.417527 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXGH-0002Rp-A3; Tue, 07 Dec 2021 09:59:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240804.417527; Tue, 07 Dec 2021 09:59:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXGH-0002Ri-6l; Tue, 07 Dec 2021 09:59:49 +0000
Received: by outflank-mailman (input) for mailman id 240804;
 Tue, 07 Dec 2021 09:59:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muXGG-0002Rc-Go
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 09:59:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muXGD-0007Li-6V; Tue, 07 Dec 2021 09:59:45 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muXGC-0001g4-Vc; Tue, 07 Dec 2021 09:59:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HHO3o//8fFJfsWaWC4WJucJEcXt2PuLYyShPGNYYLiE=; b=zxTBAzNUFuqaB6vqA6+QtfrdeY
	nEKdFX+xkn0BUBvRTq8nLi8NePGs0CGvvaIarPBIIMJMnQAw7TUOxIWw9ngHIp7kWcfS7Aie1LV+y
	kp9imHAZ/yjw86DbAIyingZt8fEvaie4GPlQU40cOso/1mrpthzIqOhk+GmBBB7f/NjA=;
Message-ID: <b43c072f-4d4c-a108-2c24-801116e99c3e@xen.org>
Date: Tue, 7 Dec 2021 09:59:41 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
 <9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 07/12/2021 09:11, Jan Beulich wrote:
> On 06.12.2021 17:21, Julien Grall wrote:
>> Hi Jan,
>>
>> On 06/12/2021 16:12, Jan Beulich wrote:
>>> On 06.12.2021 17:06, Julien Grall wrote:
>>>> On 06/12/2021 15:06, Jan Beulich wrote:
>>>>> On 06.12.2021 15:28, Julien Grall wrote:
>>>>>> I am not going to ack it but I am also not going to Nack it if another
>>>>>> maintainer agrees with your approach.
>>>>>
>>>>> FTAOD I'll be giving it a week or so, but unless I get an outright NAK,
>>>>> I'm now in a position to put this in with Luca's R-b.
>>>>
>>>>    From the check-in policy section in MAINTAINERS:
>>>>
>>>> 4. There must be no "open" objections.
>>>>
>>>> So I think this cannot be check-in given two maintainers disagree on the
>>>> approach. That said, as I wrote earlier my condition for not Nacking is
>>>> another maintainer agree with your approach.
>>>
>>> Hmm, I did address both your and Ian's concerns in v2, admittedly by only
>>> going as far as minimally necessary. I therefore wouldn't call this an
>>> "open objection".
>>
>> I believe my objection is still open.
> 
> I've taken note of this. I'm afraid with the long winded discussion no
> other maintainer will provide an ack. Which therefore makes what you said
> above effectively a nak anyway. Unless things move in unexpected ways, I
> will have to consider this series rejected then.

The code is itself is fine. I would be fine to ack them so long I can 
verify the tags you carried.

As I wrote multiple time the easiest way here it to copy/paste them. 
They may be meaningless to you but it is going to save a lot of time for 
me to verify you carried the tags correctly.

But see more below.

>> I still have have no way to verify
>> what you did is correct.
>>
>> For instance, the tags in patch #2 are:
>>
>> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
>> Reported-by: Yu Sun <yusun2@cisco.com>
>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>> Acked-by: Daniel Walker <danielwa@cisco.com>
>> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
>>
>> The tags in the Linux commit are:
>>
>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>> Reported-by: Yu Sun <yusun2@cisco.com>
>> Acked-by: Daniel Walker <danielwa@cisco.com>
>> Cc: "Yixia Si (yisi)" <yisi@cisco.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>
>> * The first two matches the original e-mails
>> * I couldn't find the 3rd on the ML.
> 
> See e.g.
> 
> https://yhbt.net/lore/all/20191108202754.GG18744@zorba/t/
> 
> (Andrew Morton's reply at the bottom) for where it originates.

Ok... So this is taken from a different aggregator. I will have to brush 
by search engine skill then.

> 
>> * The Cc could be ignored
>> * The signed-off-by are I guess what you call "mechanical"
> 
> I would generally retain Reviewed-by when our code is still quite
> similar to Linux'es. Acked-by are on the edge of being useful, but as
> you can see I did err on the side of keeping it. As said in a number
> of places elsewhere, for what I call mechanically added tags I am yet
> to be told of their value (or even need) in our tree.

I think the question is how difficult to do you want to make to the 
other reviewers? I appreciate other (including myself) may have ignored 
the tags in the past. But now that I know you do it as a manual process, 
it makes me a lot more nervous to simply ack such patch without any check.

You seem to be unwilling to simply copy/paste them. So for this series, 
would you be happy if someone else do it for you?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:00:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:00:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240808.417538 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXH9-0003ny-L7; Tue, 07 Dec 2021 10:00:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240808.417538; Tue, 07 Dec 2021 10:00:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXH9-0003nr-GX; Tue, 07 Dec 2021 10:00:43 +0000
Received: by outflank-mailman (input) for mailman id 240808;
 Tue, 07 Dec 2021 10:00:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pUvc=QY=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1muXH8-0003nh-HQ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:00:42 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0613.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::613])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 87d94c39-5744-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:00:40 +0100 (CET)
Received: from DB7PR02CA0034.eurprd02.prod.outlook.com (2603:10a6:10:52::47)
 by PAXPR08MB6527.eurprd08.prod.outlook.com (2603:10a6:102:156::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Tue, 7 Dec
 2021 10:00:37 +0000
Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:52:cafe::64) by DB7PR02CA0034.outlook.office365.com
 (2603:10a6:10:52::47) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Tue, 7 Dec 2021 10:00:37 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 10:00:36 +0000
Received: ("Tessian outbound 1cd1a01725a6:v110");
 Tue, 07 Dec 2021 10:00:36 +0000
Received: from b68cfc9ced1f.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7EA3306B-5A90-4D88-8B8F-DB5274E216E2.1; 
 Tue, 07 Dec 2021 10:00:26 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b68cfc9ced1f.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 10:00:26 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7)
 by DU2PR08MB7288.eurprd08.prod.outlook.com (2603:10a6:10:2d7::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 10:00:24 +0000
Received: from DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::f4fd:a3a4:6768:1165]) by DU2PR08MB7325.eurprd08.prod.outlook.com
 ([fe80::f4fd:a3a4:6768:1165%3]) with mapi id 15.20.4690.035; Tue, 7 Dec 2021
 10:00:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87d94c39-5744-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1U8HZltCjB2Dq0uzD4G48CGrv/LQ+KSpPV4spPrw7oQ=;
 b=YCfP2HCz8uDOO9ZMsjyue9lleHEEHHm0dzd7kl///WcUkiRC+NrhG+XWtp46/yNuhRGIHYT93CWyTHiZRGuLCtDPDMhQCqg3CQHgCQnxxK2CiS+2fVwH11gQwa8O4R3AxbU0QhswhwXSynSgO5mY8S2yx9ilrd/BGo9SkNba9aI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ERQ9KMKTfPYfG9XQ9K9kssW+KiQ31n2EehEhjHKjZtEcx7Kp/KxnR0qxYW/k6Xfcf3U8Gq1dFZe1XPHyw8R0zltWXkPtaECJPxDErN3wNAqS1+a2CFwHRF2cPtQPgI3vU1z0kj/52E7BtXoXajYLzZdN0PAslqlIqcEWsTM5c17fwte3inXaU/27jMeH0wvcTQM/3Uq41HtsiH3qFctdblJFajdsiI8mw9kSszNbhbEHZIRiea0zZWZeSUSeYIGJIL2ZsGAGuprHZKXhC6ZeNppCrLBEjZF94aH9FvK6avN2YvI35I7yz5NaeQ1ud1am/vr5TnHUaP6vTHOZ5HmagQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1U8HZltCjB2Dq0uzD4G48CGrv/LQ+KSpPV4spPrw7oQ=;
 b=ZtZNGDPwJlDPzf7h7hucC+myjYzGEJvGxu/D4m733QLXnvt/Leb8HASAuEedsSM+xtx5jghOyB/DrtV0N5yMh36e07ct5ME8DBLOAtmFNunIyLakB3WvwufuWls0lJChwSfsE9sLyggb8fBrmOvG5vwEUYkM/oJxCrs8j+9AFFCyTYbmIMHmJC5Es1jUD6tAiJRJgK08w9IVf7dJtNe218AA6jgtI09Z1GkbW9qOxI4q1Nusqi4E1OC5e2wtkKsUESVlDQGZxn+fe+g8SdJTTEUC7RWRe29jxhZfis86gj5Shck1RF9RrbexJsipWVcEKVtZoD65eM6irSI2sYJRug==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1U8HZltCjB2Dq0uzD4G48CGrv/LQ+KSpPV4spPrw7oQ=;
 b=YCfP2HCz8uDOO9ZMsjyue9lleHEEHHm0dzd7kl///WcUkiRC+NrhG+XWtp46/yNuhRGIHYT93CWyTHiZRGuLCtDPDMhQCqg3CQHgCQnxxK2CiS+2fVwH11gQwa8O4R3AxbU0QhswhwXSynSgO5mY8S2yx9ilrd/BGo9SkNba9aI=
From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Chen <Wei.Chen@arm.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Michal Orzel <Michal.Orzel@arm.com>, "julien@xen.org" <julien@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v3 01/10] xen: introduce XEN_DOMCTL_CDF_INTERNAL_directmap
Thread-Topic: [PATCH v3 01/10] xen: introduce
 XEN_DOMCTL_CDF_INTERNAL_directmap
Thread-Index: AQHX2qqMLpGJ0kZySkyR2zVz1q+w86wm3QoggAAHMICAAAc0sA==
Date: Tue, 7 Dec 2021 10:00:23 +0000
Message-ID:
 <DU2PR08MB73255F3D863CC5BEA60B8276F76E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
References: <20211116052506.880728-1-penny.zheng@arm.com>
 <20211116052506.880728-2-penny.zheng@arm.com>
 <DU2PR08MB7325137A71A2D7277F1A1650F76E9@DU2PR08MB7325.eurprd08.prod.outlook.com>
 <50a8c9c3-9d44-1cd3-d456-a78a03835799@suse.com>
In-Reply-To: <50a8c9c3-9d44-1cd3-d456-a78a03835799@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 5DEBA532FE7F444894A65E1B0776A65A.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 328549ec-7a37-4850-4e46-08d9b9686ad6
x-ms-traffictypediagnostic:
	DU2PR08MB7288:EE_|DB5EUR03FT057:EE_|PAXPR08MB6527:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB6527DDB00265B4667A0E3940F76E9@PAXPR08MB6527.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 +ncETb+WMAFla0T3MHfIjUD8p8TPuyziGSbPxCpega6l7KjupqJjR75FtSJ6jlnDF+zRFCqcq6ly+Rad0/BeZLPcATD8bV+v9I5dNVaQmm9uhf/ed2zDNiGY2uBKGGOYBnP09LkVXwiGIIBdSP0hOal8g3YCFcP9mnzHQ8R3dl/8oKpbG9hSSCE4YStsu5KRgOPZW0tTG/0FWnaQuefRV5/0oHWWeUeiWpGc3yBt00O2Ek2VsT3d3oycXUi6YPhO/wz0Lax7tYO4z9KgyVwYFXMTc8RppP5TaVU93uXeiW/aCFBNmPNcZtVdWcwLd47J7+omfWdASyXAJmLfNpK44P7enI0XwexzBNmabcunwqvQSk3S7ycFqsPJQNa9D4GGhHdutJSOBGfoUBbGR+NQl6sJM8Pv4S01m2ZbXMV5L0B+h9oZ7dWGfs1EmVzJJ0H3Ikj75V6NpvLgtk+gfVhzYGm4+yaJZgiAdhTtPRh5oXWCTJ1O92A8fh9CHub8/yArcdAy3MQnYPuI4VQHHOCuWWo0FGTcPoFDOmwg2BXAAJTE/bIvk/vl0yKWtg8ZC/FHu1zCF1Cil2K1p4u4nBzVDj/8NgWFKG6NKll2Zdu9e/W6PJ/MY7vTSM37aobQ2SnHr9/opoSrZJi4bRU3RZACpNlb++sU3fCQcdAmi0I2T9G/P8kRSGe8D+nlT3sya/0JljShKmOc8QJql1qysnj3rVZFOsxiXHT/ToawOkq3F1GOlDVMrJZiO9MLcNqd9vpY5bfSuBaWqbgdDzos8vtcgMxJRGmTZBoa1csmp43nQ6iYb0MqNfSzjKEGBH1+b8or
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(966005)(2906002)(76116006)(508600001)(66946007)(8936002)(66476007)(38070700005)(64756008)(54906003)(66446008)(4326008)(71200400001)(66556008)(316002)(186003)(55016003)(33656002)(53546011)(6916009)(9686003)(122000001)(52536014)(83380400001)(38100700002)(6506007)(86362001)(7696005)(26005)(8676002)(21314003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7288
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a62e6e32-cc07-44b0-51c4-08d9b9686329
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XxLbAwlfx7NV6Q5ASyl04BT80R7d8ZzZkDMFP7OQr1iK4yKox/aSwv/poFGWeWCXEoNH8ImvKxdIO8G49S21KzbfeACfv3fV0r5t2+Ni787FC2ebNGx8638k3lVwu7trhoImnWWthzkkLxPDXniVTqvWHxfKTrVtwbH5rqtOE4p0xpolNIVgJVZsXkd2tMBkNHHPjkM9BDatZMOsKQ6B6zjBs6YUjs6rITaoFoLon/G8lH0v0EBOB+izRFxw0LerXGND4/DLc7DoDW9qTgj0/R0ZKuupb6fndvwlM6M/sOw9h/laMfjbD5t/zfoU7Nekg89P1hTTbMtEF6XpV7mBknmKvTfi3Imasbn0WSxkiR9z9J7zjv2Mc8wrH8gHDun+L0d4BbUyIFpHdRPBSg6SYzehXJse9/s+RMxPxvStKHylRWwffh2adKGr0CXuVXiw6u21KOZ7mPej//X7WdtwNy/bn85972EPMLCdg383ix8ME742Ub/OnJv+IKjSoIUaLyizRQgClBZQaYlyoKDl9Eggof6NECwn1j9beKWBvJiNabInumW024O21l3tP8OZP9BP6h2GvGvjjXjPpXNaeMlsp8WT8BPaEIMSK+ABiyn8Aegxf+EdAN+t288b2Vs9vq+w5kroP4eSST3fTkeNI54GL9A1bRPXhLQ/8pAN94zdbYmmixmvmyHkH6kPHsTYIZESriquYWsp6c+Rl0XrIj7FSmVD97qIQyz5GOBu3WtyOAk6SiuE/zoorf8zwDRTUrGQlS7vKgxC6qf03c+auyAvctfJiaIMuCpJSpjVJtJEqfpNK3jDHCSZG/GyAFlS
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(356005)(9686003)(508600001)(33656002)(2906002)(54906003)(52536014)(5660300002)(81166007)(26005)(316002)(966005)(6862004)(86362001)(47076005)(4326008)(186003)(55016003)(83380400001)(53546011)(70586007)(8936002)(70206006)(82310400004)(6506007)(36860700001)(8676002)(7696005)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 10:00:36.9802
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 328549ec-7a37-4850-4e46-08d9b9686ad6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6527

SGkgamFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBUdWVzZGF5LCBEZWNlbWJlciA3LCAyMDIx
IDU6MjggUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzog
V2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFu
ZC5NYXJxdWlzQGFybS5jb20+OyBNaWNoYWwgT3J6ZWwgPE1pY2hhbC5PcnplbEBhcm0uY29tPjsN
Cj4ganVsaWVuQHhlbi5vcmc7IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJq
ZWN0OiBSZTogW1BBVENIIHYzIDAxLzEwXSB4ZW46IGludHJvZHVjZQ0KPiBYRU5fRE9NQ1RMX0NE
Rl9JTlRFUk5BTF9kaXJlY3RtYXANCj4gDQo+IE9uIDA3LjEyLjIwMjEgMTA6MTUsIFBlbm55IFpo
ZW5nIHdyb3RlOg0KPiA+IEhpIGd1eXMNCj4gPg0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut
LS0tLQ0KPiA+PiBGcm9tOiBQZW5ueSBaaGVuZyA8cGVubnkuemhlbmdAYXJtLmNvbT4NCj4gPj4g
U2VudDogVHVlc2RheSwgTm92ZW1iZXIgMTYsIDIwMjEgMToyNSBQTQ0KPiA+PiBUbzogUGVubnkg
WmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+DQo+ID4+IENjOiBuZCA8bmRAYXJtLmNvbT4NCj4g
Pj4gU3ViamVjdDogW1BBVENIIHYzIDAxLzEwXSB4ZW46IGludHJvZHVjZQ0KPiA+PiBYRU5fRE9N
Q1RMX0NERl9JTlRFUk5BTF9kaXJlY3RtYXANCj4gPj4NCj4gPj4gRnJvbTogU3RlZmFubyBTdGFi
ZWxsaW5pIDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT4NCj4gPj4NCj4gPj4gVGhpcyBj
b21taXQgaW50cm9kdWNlcyBhIG5ldyBhcm0tc3BlY2lmaWMgZmxhZw0KPiA+PiBYRU5fRE9NQ1RM
X0NERl9JTlRFUk5BTF9kaXJlY3RtYXAgdG8gc3BlY2lmeSB0aGF0IGEgZG9tYWluIHNob3VsZA0K
PiA+PiBoYXZlIGl0cyBtZW1vcnkgZGlyZWN0LW1hcChndWVzdCBwaHlzaWNhbCBhZGRyZXNzID09
IHBoeXNpY2FsDQo+ID4+IGFkZHJlc3MpIGF0IGRvbWFpbiBjcmVhdGlvbi4NCj4gPj4NCj4gPj4g
U2luY2UgdGhpcyBmbGFnIGlzIG9ubHkgYXZhaWxhYmxlIGZvciBkb21haW4gY3JlYXRlZCBieSBY
RU4sIG5vdA0KPiA+PiBleHBvc2VkIHRvIHRoZSB0b29sc3RhY2ssIHdlIG5hbWUgaXQgd2l0aCBl
eHRyYSAiSU5URVJOQUwiIHRvDQo+ID4+IGRpc3Rpbmd1aXNoIGZyb20gb3RoZXIgcHVibGljIFhF
Tl9ET01DVExfQ0RGX3h4eCBmbGFncywgYW5kIGFkZA0KPiA+PiBjb21tZW50cyB0byB3YXJuIGRl
dmVsb3BlcnMgbm90IHRvIGFjY2lkZW50bHkgdXNlIGl0cyBiaXRmaWVsZCB3aGVuDQo+IGludHJv
ZHVjaW5nIG5ldyBYRU5fRE9NQ1RMX0NERl94eHggZmxhZy4NCj4gPj4NCj4gPj4gUmVmaW5lIGlz
X2RvbWFpbl9kaXJlY3RfbWFwcGVkIHRvIGNoZWNrIHdoZXRoZXIgdGhlIGZsYWcNCj4gPj4gWEVO
X0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwIGlzIHNldC4NCj4gPj4NCj4gPj4gU2lnbmVk
LW9mZi1ieTogUGVubnkgWmhlbmcgPHBlbm55LnpoZW5nQGFybS5jb20+DQo+ID4+IFNpZ25lZC1v
ZmYtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+
DQo+ID4+IC0tLQ0KPiA+PiBDQzogYW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbQ0KPiA+PiBDQzog
amJldWxpY2hAc3VzZS5jb20NCj4gPj4gQ0M6IEdlb3JnZSBEdW5sYXAgPEdlb3JnZS5EdW5sYXBA
ZXUuY2l0cml4LmNvbT4NCj4gPj4gQ0M6IElhbiBKYWNrc29uIDxpYW4uamFja3NvbkBldS5jaXRy
aXguY29tPg0KPiA+PiBDQzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gPj4gQ0M6ICJSb2dlciBQ
YXUgTW9ubsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+ID4+IC0tLQ0KPiA+PiB2MiBjaGFu
Z2VzDQo+ID4+IC0gcmVtb3ZlIHRoZSBpbnRyb2R1Y2Ugb2YgaW50ZXJuYWwgZmxhZw0KPiA+PiAt
IHJlbW92ZSBmbGFnIGRpcmVjdF9tYXAgc2luY2Ugd2UgYWxyZWFkeSBzdG9yZSB0aGlzIGZsYWcg
aW4NCj4gPj4gZC0+b3B0aW9ucw0KPiA+PiAtIFJlZmluZSBpc19kb21haW5fZGlyZWN0X21hcHBl
ZCB0byBjaGVjayB3aGV0aGVyIHRoZSBmbGFnDQo+ID4+IFhFTl9ET01DVExfQ0RGX2RpcmVjdG1h
cCBpcyBzZXQNCj4gPj4gLSByZXdvcmQgIjE6MSBkaXJlY3QtbWFwIiB0byBqdXN0ICJkaXJlY3Qt
bWFwIg0KPiA+PiAtLS0NCj4gPj4gdjMgY2hhbmdlcw0KPiA+PiAtIG1vdmUgZmxhZyBiYWNrIHRv
IHhlbi9pbmNsdWRlL3hlbi9kb21haW4uaCwgdG8gbGV0IGl0IGJlIG9ubHkNCj4gPj4gYXZhaWxh
YmxlIGZvciBkb21haW4gY3JlYXRlZCBieSBYRU4uDQo+ID4+IC0gbmFtZSBpdCB3aXRoIGV4dHJh
ICJJTlRFUk5BTCIgYW5kIGFkZCBjb21tZW50cyB0byB3YXJuIGRldmVsb3BlcnMNCj4gPj4gbm90
IHRvIGFjY2lkZW50bHkgdXNlIGl0cyBiaXRmaWVsZCB3aGVuIGludHJvZHVjaW5nIG5ldw0KPiBY
RU5fRE9NQ1RMX0NERl94eHggZmxhZy4NCj4gPj4gLSByZWplY3QgdGhpcyBmbGFnIGluIHg4Nidl
cyBhcmNoX3Nhbml0aXNlX2RvbWFpbl9jb25maWcoKQ0KPiA+PiAtLS0NCj4gPj4gIHhlbi9hcmNo
L2FybS9kb21haW4uYyAgICAgICAgfCAzICsrLQ0KPiA+PiAgeGVuL2FyY2gvYXJtL2RvbWFpbl9i
dWlsZC5jICB8IDQgKysrLQ0KPiA+PiAgeGVuL2FyY2gveDg2L2RvbWFpbi5jICAgICAgICB8IDYg
KysrKysrDQo+ID4+ICB4ZW4vY29tbW9uL2RvbWFpbi5jICAgICAgICAgIHwgMyArKy0NCj4gPj4g
IHhlbi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmggfCA0ICsrLS0gIHhlbi9pbmNsdWRlL3B1Ymxp
Yy9kb21jdGwuaA0KPiA+PiB8IDQgKysrKw0KPiA+PiAgeGVuL2luY2x1ZGUveGVuL2RvbWFpbi5o
ICAgICB8IDMgKysrDQo+ID4+ICA3IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDUg
ZGVsZXRpb25zKC0pDQo+ID4+DQo+ID4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWlu
LmMgYi94ZW4vYXJjaC9hcm0vZG9tYWluLmMgaW5kZXgNCj4gPj4gOTZlMWIyMzU1MC4uZDc3MjY1
YzAzZiAxMDA2NDQNCj4gPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+ID4+ICsrKyBi
L3hlbi9hcmNoL2FybS9kb21haW4uYw0KPiA+PiBAQCAtNjI5LDcgKzYyOSw4IEBAIGludCBhcmNo
X3Nhbml0aXNlX2RvbWFpbl9jb25maWcoc3RydWN0DQo+ID4+IHhlbl9kb21jdGxfY3JlYXRlZG9t
YWluICpjb25maWcpICB7DQo+ID4+ICAgICAgdW5zaWduZWQgaW50IG1heF92Y3B1czsNCj4gPj4g
ICAgICB1bnNpZ25lZCBpbnQgZmxhZ3NfcmVxdWlyZWQgPSAoWEVOX0RPTUNUTF9DREZfaHZtIHwN
Cj4gPj4gWEVOX0RPTUNUTF9DREZfaGFwKTsNCj4gPj4gLSAgICB1bnNpZ25lZCBpbnQgZmxhZ3Nf
b3B0aW9uYWwgPSAoWEVOX0RPTUNUTF9DREZfaW9tbXUgfA0KPiA+PiBYRU5fRE9NQ1RMX0NERl92
cG11KTsNCj4gPj4gKyAgICB1bnNpZ25lZCBpbnQgZmxhZ3Nfb3B0aW9uYWwgPSAoWEVOX0RPTUNU
TF9DREZfaW9tbXUgfA0KPiA+PiBYRU5fRE9NQ1RMX0NERl92cG11IHwNCj4gPj4gKw0KPiA+PiAr
IFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcCk7DQo+ID4+DQo+ID4+ICAgICAgaWYg
KCAoY29uZmlnLT5mbGFncyAmIH5mbGFnc19vcHRpb25hbCkgIT0gZmxhZ3NfcmVxdWlyZWQgKQ0K
PiA+PiAgICAgIHsNCj4gPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQu
Yw0KPiA+PiBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyBpbmRleCAxOTQ4N2M3OWRhLi42
NjRjODhlYmU0IDEwMDY0NA0KPiA+PiAtLS0gYS94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMN
Cj4gPj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+IEBAIC0zMDg5LDgg
KzMwODksMTAgQEAgc3RhdGljIGludCBfX2luaXQgY29uc3RydWN0X2RvbTAoc3RydWN0IGRvbWFp
bg0KPiA+PiAqZCkgdm9pZCBfX2luaXQgY3JlYXRlX2RvbTAodm9pZCkgIHsNCj4gPj4gICAgICBz
dHJ1Y3QgZG9tYWluICpkb20wOw0KPiA+PiArICAgIC8qIERPTTAgaGFzIGFsd2F5cyBpdHMgbWVt
b3J5IGRpcmVjdC1tYXAuICovDQo+ID4+ICAgICAgc3RydWN0IHhlbl9kb21jdGxfY3JlYXRlZG9t
YWluIGRvbTBfY2ZnID0gew0KPiA+PiAtICAgICAgICAuZmxhZ3MgPSBYRU5fRE9NQ1RMX0NERl9o
dm0gfCBYRU5fRE9NQ1RMX0NERl9oYXAsDQo+ID4+ICsgICAgICAgIC5mbGFncyA9IFhFTl9ET01D
VExfQ0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcCB8DQo+ID4+ICsgICAgICAgICAgICAgICAg
IFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcCwNCj4gPj4gICAgICAgICAgLm1heF9l
dnRjaG5fcG9ydCA9IC0xLA0KPiA+PiAgICAgICAgICAubWF4X2dyYW50X2ZyYW1lcyA9IGdudHRh
Yl9kb20wX2ZyYW1lcygpLA0KPiA+PiAgICAgICAgICAubWF4X21hcHRyYWNrX2ZyYW1lcyA9IC0x
LA0KPiA+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2RvbWFpbi5jIGIveGVuL2FyY2gveDg2
L2RvbWFpbi5jIGluZGV4DQo+ID4+IGVmMTgxMmRjMTQuLmViYTY1MDIyMTggMTAwNjQ0DQo+ID4+
IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYw0KPiA+PiArKysgYi94ZW4vYXJjaC94ODYvZG9t
YWluLmMNCj4gPj4gQEAgLTY5Miw2ICs2OTIsMTIgQEAgaW50IGFyY2hfc2FuaXRpc2VfZG9tYWlu
X2NvbmZpZyhzdHJ1Y3QNCj4gPj4geGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykNCj4g
Pj4gICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4+ICAgICAgfQ0KPiA+Pg0KPiA+PiArICAg
IGlmICggY29uZmlnLT5mbGFncyAmIFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcCAp
DQo+ID4+ICsgICAgew0KPiA+PiArICAgICAgICBkcHJpbnRrKFhFTkxPR19JTkZPLCAiZGlyZWN0
LW1hcCBjYW5ub3QgYmUgZW5hYmxlZCB5ZXRcbiIpOw0KPiA+PiArICAgICAgICByZXR1cm4gLUVJ
TlZBTDsNCj4gPj4gKyAgICB9DQo+ID4+ICsNCj4gPj4gICAgICByZXR1cm4gMDsNCj4gPj4gIH0N
Cj4gPj4NCj4gPj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vZG9tYWluLmMgYi94ZW4vY29tbW9u
L2RvbWFpbi5jIGluZGV4DQo+ID4+IDU2ZDQ3ZGQ2NjQuLjEzYWM1OTUwYmMgMTAwNjQ0DQo+ID4+
IC0tLSBhL3hlbi9jb21tb24vZG9tYWluLmMNCj4gPj4gKysrIGIveGVuL2NvbW1vbi9kb21haW4u
Yw0KPiA+PiBAQCAtNDg2LDcgKzQ4Niw4IEBAIHN0YXRpYyBpbnQgc2FuaXRpc2VfZG9tYWluX2Nv
bmZpZyhzdHJ1Y3QNCj4gPj4geGVuX2RvbWN0bF9jcmVhdGVkb21haW4gKmNvbmZpZykNCj4gPj4g
ICAgICAgICAgIH4oWEVOX0RPTUNUTF9DREZfaHZtIHwgWEVOX0RPTUNUTF9DREZfaGFwIHwNCj4g
Pj4gICAgICAgICAgICAgWEVOX0RPTUNUTF9DREZfczNfaW50ZWdyaXR5IHwgWEVOX0RPTUNUTF9D
REZfb29zX29mZiB8DQo+ID4+ICAgICAgICAgICAgIFhFTl9ET01DVExfQ0RGX3hzX2RvbWFpbiB8
IFhFTl9ET01DVExfQ0RGX2lvbW11IHwNCj4gPj4gLSAgICAgICAgICAgWEVOX0RPTUNUTF9DREZf
bmVzdGVkX3ZpcnQgfCBYRU5fRE9NQ1RMX0NERl92cG11KSApDQo+ID4+ICsgICAgICAgICAgIFhF
Tl9ET01DVExfQ0RGX25lc3RlZF92aXJ0IHwgWEVOX0RPTUNUTF9DREZfdnBtdSB8DQo+ID4+ICsg
ICAgICAgICAgIFhFTl9ET01DVExfQ0RGX0lOVEVSTkFMX2RpcmVjdG1hcCkgKQ0KPiA+PiAgICAg
IHsNCj4gPj4gICAgICAgICAgZHByaW50ayhYRU5MT0dfSU5GTywgIlVua25vd24gQ0RGIGZsYWdz
ICUjeFxuIiwgY29uZmlnLT5mbGFncyk7DQo+ID4+ICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0K
PiA+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPiA+PiBiL3hl
bi9pbmNsdWRlL2FzbS1hcm0vZG9tYWluLmggaW5kZXggOWIzNjQ3NTg3YS4uNGYyYzNmMDlkNCAx
MDA2NDQNCj4gPj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9kb21haW4uaA0KPiA+PiArKysg
Yi94ZW4vaW5jbHVkZS9hc20tYXJtL2RvbWFpbi5oDQo+ID4+IEBAIC0yOSw4ICsyOSw4IEBAIGVu
dW0gZG9tYWluX3R5cGUgew0KPiA+PiAgI2RlZmluZSBpc182NGJpdF9kb21haW4oZCkgKDApDQo+
ID4+ICAjZW5kaWYNCj4gPj4NCj4gPj4gLS8qIFRoZSBoYXJkd2FyZSBkb21haW4gaGFzIGFsd2F5
cyBpdHMgbWVtb3J5IGRpcmVjdCBtYXBwZWQuICovDQo+ID4+IC0jZGVmaW5lDQo+ID4+IGlzX2Rv
bWFpbl9kaXJlY3RfbWFwcGVkKGQpIGlzX2hhcmR3YXJlX2RvbWFpbihkKQ0KPiA+PiArI2RlZmlu
ZSBpc19kb21haW5fZGlyZWN0X21hcHBlZChkKSBcDQo+ID4+ICsgICAgICAgIChkLT5vcHRpb25z
ICYgWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwKQ0KPiA+Pg0KPiA+PiAgc3RydWN0
IHZ0aW1lciB7DQo+ID4+ICAgICAgc3RydWN0IHZjcHUgKnY7DQo+ID4+IGRpZmYgLS1naXQgYS94
ZW4vaW5jbHVkZS9wdWJsaWMvZG9tY3RsLmgNCj4gPj4gYi94ZW4vaW5jbHVkZS9wdWJsaWMvZG9t
Y3RsLmggaW5kZXgNCj4gPj4gMWMyMWQ0ZGM3NS4uMDU0ZTU0NWM5NyAxMDA2NDQNCj4gPj4gLS0t
IGEveGVuL2luY2x1ZGUvcHVibGljL2RvbWN0bC5oDQo+ID4+ICsrKyBiL3hlbi9pbmNsdWRlL3B1
YmxpYy9kb21jdGwuaA0KPiA+PiBAQCAtNzIsNiArNzIsMTAgQEAgc3RydWN0IHhlbl9kb21jdGxf
Y3JlYXRlZG9tYWluIHsNCj4gPj4gICNkZWZpbmUgWEVOX0RPTUNUTF9DREZfbmVzdGVkX3ZpcnQg
ICAgKDFVIDw8DQo+ID4+IF9YRU5fRE9NQ1RMX0NERl9uZXN0ZWRfdmlydCkNCj4gPj4gIC8qIFNo
b3VsZCB3ZSBleHBvc2UgdGhlIHZQTVUgdG8gdGhlIGd1ZXN0PyAqLw0KPiA+PiAgI2RlZmluZSBY
RU5fRE9NQ1RMX0NERl92cG11ICAgICAgICAgICAoMVUgPDwgNykNCj4gPj4gKy8qDQo+ID4+ICsg
KiBCZSBhd2FyZSB0aGF0IGJpdCA4IGhhcyBhbHJlYWR5IGJlZW4gb2NjdXBpZWQgYnkgZmxhZw0K
PiA+PiArICogWEVOX0RPTUNUTF9DREZfSU5URVJOQUxfZGlyZWN0bWFwLCBkZWZpbmVkIGluDQo+
ID4+IHhlbi9pbmNsdWRlL3hlbi9kb21haW4uaC4NCj4gPj4gKyAqLw0KPiA+Pg0KPiA+PiAgLyog
TWF4IFhFTl9ET01DVExfQ0RGXyogY29uc3RhbnQuICBVc2VkIGZvciBBQkkgY2hlY2tpbmcuICov
DQo+ID4+ICNkZWZpbmUgWEVOX0RPTUNUTF9DREZfTUFYIFhFTl9ET01DVExfQ0RGX3ZwbXUgZGlm
ZiAtLWdpdA0KPiA+PiBhL3hlbi9pbmNsdWRlL3hlbi9kb21haW4uaCBiL3hlbi9pbmNsdWRlL3hl
bi9kb21haW4uaCBpbmRleA0KPiA+PiAxNjBjOGRiZGFiLi4yYjllZGZkY2VlIDEwMDY0NA0KPiA+
PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vZG9tYWluLmgNCj4gPj4gKysrIGIveGVuL2luY2x1ZGUv
eGVuL2RvbWFpbi5oDQo+ID4+IEBAIC0yOCw2ICsyOCw5IEBAIHZvaWQgZ2V0ZG9tYWluaW5mbyhz
dHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QNCj4gPj4geGVuX2RvbWN0bF9nZXRkb21haW5pbmZvICpp
bmZvKTsgIHZvaWQgYXJjaF9nZXRfZG9tYWluX2luZm8oY29uc3QNCj4gPj4gc3RydWN0IGRvbWFp
biAqZCwNCj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHhlbl9kb21jdGxf
Z2V0ZG9tYWluaW5mbyAqaW5mbyk7DQo+ID4+DQo+ID4+ICsvKiBTaG91bGQgZG9tYWluIG1lbW9y
eSBiZSBkaXJlY3RseSBtYXBwZWQ/ICovDQo+ID4+ICsjZGVmaW5lIFhFTl9ET01DVExfQ0RGX0lO
VEVSTkFMX2RpcmVjdG1hcCAgICAgICgxVSA8PCA4KQ0KPiA+PiArDQo+ID4NCj4gPiBJIHJ1biBp
bnRvIHNvbWUgdHJvdWJsZSB3aXRoIGRlZmluaW5nIHRoaXMgZmxhZyBpbnRlcm5hbCBpbiB0aGUg
bmV3IHNlcmllLg0KPiA+DQo+ID4gTGV0IG1lIGV4cGxhaW4gaW4gZGV0YWlscyBoZXJlOg0KPiA+
DQo+ID4gMS4gQ3VycmVudGx5IFhFTl9ET01DVExfQ0RGX01BWCBpcyBzZXQgdG8gWEVOX0RPTUNU
TF9DREZfdnBtdS4NCj4gPiBTbyB3ZSBjYW4gc2F5IHRoYXQgWEVOX0RPTUNUTF9DREZfTUFYIGtu
b3dzIHRoYXQgdGhlcmUgYXJlIDggQ0RGDQo+IGZsYWdzKDAgdG8gNykuDQo+ID4gVGhlIGNvcnJl
c3BvbmRpbmcgb2NhbWwgdG9vbCBoYXMgYSBsaXN0IG9mIENERiBmbGFncyBhbmQgY3VycmVudGx5
IGl0IGtub3dzDQo+IHRoYXQgdGhlcmUgYXJlIDggQ0RGIGZsYWdzOg0KPiA+IGh0dHBzOi8veGVu
Yml0cy54ZW4ub3JnL2dpdHdlYi8/cD14ZW4uZ2l0O2E9YmxvYjtmPXRvb2xzL29jYW1sL2xpYnMv
eGMNCj4gPiAveGVuY3RybC5tbDtoPTc1MDMwMzFkOGY2MWMyZGJjZDRhYTgwMzczOGM4M2UxMGRm
YjdiYjg7aGI9SEVBRCNsNjQNCj4gPiBUaGlzIHRvb2wgcGVyZm9ybXMgYSBjaGVjayB0byBzZWUg
aWYgdGhlIFhFTl9ET01DVExfQ0RGX01BWCBpcyBlcXVhbCB0bw0KPiB0aGUgbnVtYmVyIG9mIGVu
dHJpZXMgaW4gZG9tYWluX2NyZWF0ZV9mbGFnLg0KPiA+DQo+ID4gMi4gSGVyZSB3ZSBhcmUgcmVz
ZXJ2aW5nIGJpdCA4IGZvciBpbnRlcm5hbCBmbGFnDQo+ID4gWEVOX0RPTUNUTF9DREZfSU5URVJO
QUxfZGlyZWN0bWFwLiBBcyB0aGlzIGlzIGludGVybmFsIGZsYWcsIEkgZG8gbm90DQo+IHdhbnQg
dG8gbW9kaWZ5IFhFTl9ET01DVExfQ0RGX01BWC4NCj4gPg0KPiA+IDMuIEV2ZXJ5dGhpbmcgaXMg
cGVyZmVjdCB1bnRpbCBzb21lb25lIHRyaWVzIHRvIGFkZCBhbm90aGVyIGdsb2JhbCBDREYgZmxh
ZzoNCj4gPg0KPiA+ICNkZWZpbmUgWEVOX0RPTUNUTF9DREZfbmV4dF9mbGFnICAoMTw8OSkgI2Rl
ZmluZQ0KPiBYRU5fRE9NQ1RMX0NERl9NQVgNCj4gPiBYRU5fRE9NQ1RMX0NERl9uZXh0X2ZsYWcN
Cj4gPg0KPiA+IFhFTl9ET01DVExfQ0RGX01BWCBzaG93cyByaWdodCBub3cgdGhhdCB0aGVyZSBh
cmUgMTAgZmxhZ3MgYnV0IG9jYW1sDQo+IHRvb2wgc2VlcyBvbmx5IDkuDQo+ID4gdGhlbiB3ZSBh
cmUgZ2V0dGluZyBidWlsZCBlcnJvci4NCj4gPg0KPiA+IEhtbSwgd291bGQgeW91IHBsZWFzZSBo
ZWxwIG1lIGZpbmQgYSB3YXkgdG8gZml4IHRoaXMgZGlsZW1tYSwgdGh4Lg0KPiANCj4gVGhpcyB3
YXMgYWxyZWFkeSBvdXRsaW5lZCwgYnV0IGxldCBtZSBkbyBzbyBhZ2FpbjogWW91IGRvIF9ub3Rf
IHdhbnQgdG8NCj4gb3ZlcmxheSB3aXRoIFhFTl9ET01DVExfQ0RGXyouIGRvbWFpbl9jcmVhdGUo
KSBhbHJlYWR5IGhhcyBhbiBpbnRlcm5hbC0NCj4gb25seSBwYXJhbWV0ZXIuIFRoYXQncyBhICJi
b29sIiByaWdodCBub3cgYW5kIHdhbnRzIGV4dGVuZGluZyB0byBhbg0KPiAidW5zaWduZWQgaW50
IiBjb3ZlcmluZyBib3RoIHRoZSBleGlzdGluZyAiaXNfcHJpdiIgKHN0ZXAgMSkgYW5kIHlvdXIg
bmV3DQo+ICJkaXJlY3RtYXAiIChzdGVwIDIpLiBUbyBtYWtlIHZpc2libGUgdGhlIHJlbGF0aW9u
c2hpcCwgbmFtaW5nIHRoZSByZXNwZWN0aXZlDQo+IGNvbnN0YW50cyBDREZfKiAod2l0aCBubyBY
RU5fRE9NQ1RMXyBwcmVmaXggdG8gcmVwcmVzZW50IHRoZQ0KPiBkaWZmZXJlbmNlKSBtaWdodCBi
ZSBhcHBvcHJpYXRlLg0KDQpPaCwgIEkgdW5kZXJzdGFuZCBmaW5hbGx5Li4uDQpXZSBzaGFsbCBj
cmVhdGUgYW5vdGhlciBuZXcgInVuc2lnbmVkIGludCIgQ0RGXyogKHdpdGggbm8gWEVOX0RPTUNU
TF8gcHJlZml4KSB0bw0KY292ZXIgYWxsIGludGVybmFsIGZsYWdzKHByaXYgYW5kIGRpcmVjdC1t
YXApLg0KDQo+IEJ0dywgYXMgYSByZXN1bHQgKGlmIHRoYXQncyBub3QgdGhlIHBsYW4gYWxyZWFk
eSBhbnl3YXkpIHlvdSB0aGVuIHByb2JhYmx5IGFsc28NCj4gd2FudCB0byBkZWNvdXBsZSBpc19k
b21haW5fZGlyZWN0X21hcHBlZCgpIGZyb20gaXNfaGFyZHdhcmVfZG9tYWluKCksDQo+IGFuZCBo
ZW5jZSBjcmVhdGUgRG9tMCBhbHNvIHdpdGggdGhlIG5ldyBmbGFnIHNldC4NCj4gDQo+IEphbg0K
DQo=


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:09:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:09:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240821.417548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXP9-0005E3-HL; Tue, 07 Dec 2021 10:08:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240821.417548; Tue, 07 Dec 2021 10:08:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXP9-0005Dw-EU; Tue, 07 Dec 2021 10:08:59 +0000
Received: by outflank-mailman (input) for mailman id 240821;
 Tue, 07 Dec 2021 10:08:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muXP8-0005Dq-5R
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:08:58 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b070c904-5745-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:08:56 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5C3EA1FD56;
 Tue,  7 Dec 2021 10:08:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1166A13A1F;
 Tue,  7 Dec 2021 10:08:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id t3v8Argyr2H5ZQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 10:08:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b070c904-5745-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638871736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=04B1CytsnorvkHac/LIYdPEXfeGuvxVd7EhddaiASdc=;
	b=Izh9F2P4zMZZXa5CIg2NxLQitWRpsCCf0zs3KSOBV/pO34SDobfSn1UX0PKVejg1iRgojk
	YUjSCZjUpHrQuVCwrxg38+pbFN6JagqHT6MdjyHylofhm1bq9DBjVeudlkyGcppkgj5DrT
	7L+gynXVdL/C7zjjdMVQASZ3czq35X0=
Subject: Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of
 "buildmakevars2header"
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-19-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com>
Date: Tue, 7 Dec 2021 11:08:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-19-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="b7XcoQYtTs90TVheiIWfgBgir1lh08Vlz"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--b7XcoQYtTs90TVheiIWfgBgir1lh08Vlz
Content-Type: multipart/mixed; boundary="MlKqxdE7RxAaRK7pUJfuU63LldxZLThC6";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com>
Subject: Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of
 "buildmakevars2header"
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-19-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-19-anthony.perard@citrix.com>

--MlKqxdE7RxAaRK7pUJfuU63LldxZLThC6
Content-Type: multipart/mixed;
 boundary="------------44DA1E941E0D91E835CBD2D3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------44DA1E941E0D91E835CBD2D3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> This avoid the need to generate the _paths.h header when the
> information is from autoconf anyway.
>=20
> They are no more users of the "buildmakevars2header" macro, so it can
> be removed from "Config.mk".
>=20
> Also removed the extra "-f" flag where "$(RM)" is used (xl/Makefile).
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

The changes for configure should be done in the respective configure.ac
files and then configure can be generated via a call of "autoconf".


Juergen

--------------44DA1E941E0D91E835CBD2D3
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------44DA1E941E0D91E835CBD2D3--

--MlKqxdE7RxAaRK7pUJfuU63LldxZLThC6--

--b7XcoQYtTs90TVheiIWfgBgir1lh08Vlz
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvMrcFAwAAAAAACgkQsN6d1ii/Ey9C
HAf/X8TsPN5o/vU6M0gaBNMBmpTqvOIGzi6cIfAPnSMXNt+qyFtDUnW1Bmb1u9HwZRRst2gP340Z
G1XIpYWg/8Tv6Ltej3aO22jSRDOt8h8YBi2gacY62x1sQi94smPFWLhMshhQW0J2WGCWstkJIimf
IUETeyJb+zXennOtOi5KtSULBKvEO6LAZXBq6Fu5iiNX5lUK9yh8ZhZHw+ZY2SLi4Z73IfLf7X7I
xDsxf66d3EffluBmmUfrURj4OuO+AAh5PL+5bDhQmVflYWFVJdjoSU+QXSEQkR3Djd3jEH3P0Lf9
Iuij574bocAxaekRSf8EDnUF+qE6RduD3TdgnNa8xA==
=h4yK
-----END PGP SIGNATURE-----

--b7XcoQYtTs90TVheiIWfgBgir1lh08Vlz--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:20:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:20:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240827.417559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXZd-0007I1-FJ; Tue, 07 Dec 2021 10:19:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240827.417559; Tue, 07 Dec 2021 10:19:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXZd-0007Hu-CI; Tue, 07 Dec 2021 10:19:49 +0000
Received: by outflank-mailman (input) for mailman id 240827;
 Tue, 07 Dec 2021 10:19:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muXZc-0007Hn-6b
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:19:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33cddee1-5747-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:19:46 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2055.outbound.protection.outlook.com [104.47.10.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-OM5SwhrnPG2bnmAWjBn7Zg-1; Tue, 07 Dec 2021 11:19:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 10:19:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 10:19:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0042.eurprd04.prod.outlook.com (2603:10a6:20b:46a::14) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Tue, 7 Dec 2021 10:19:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33cddee1-5747-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638872386;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JFYr5eFQCOPueSfTXUAt2nrsz3PFVQr6N31Xf2JZny0=;
	b=g0lq3s0hoY3hc5sauO7LFECIi5lSVrANkCVJJUeunQTbyxciwDw+fnxq49J0x4vZodz5EH
	E+7BbiQzCUtCpOYL728L2gqHS8qqWcOcW4i/99nVKZ9ABusXFlZx3DQdC3bixI3Rq8W0PD
	z9zymI+uD5guP90nzAl7M1HsJsSXCuQ=
X-MC-Unique: OM5SwhrnPG2bnmAWjBn7Zg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eD3I/e5Oo0umReDInPeOvq8hN1W+Heo6U2Y190A2/wvhGd8yn288tN6V5q9B1zbD0SWodOjyDu/uqJKaAQpqWgfTx9BPSHu8m6M/rgotVpTAq9yuYH2l4J2BSSiTew8ieAHxTOvDN4bvQTQlcjt9WQL5S8Nvf+IhJzQ57x/elqvoEov15f3P4Bj3etKLZW2WLODkbbzKAEzfwooe+Bwy/tFxJA5VYt+Se5iPr4mvp0XpXl6Zi3podJt4qX7kVd9y87WOr0cSs4Cg/DhY5YYO7h2Z8gDQ53t4QR1aXgNQXn4bu+QGMNvb8iHGoibSizeAAvg9ikecGIflMZhwpUwCDA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JFYr5eFQCOPueSfTXUAt2nrsz3PFVQr6N31Xf2JZny0=;
 b=ePwp/vPBIhgJnLCxyFX3BuvG/Dn9hu27tK6RGQqwF6sIvrLkhqL8qBd+yjX8GZ+I/iODxKzDokpZID4xImuz+fSprTsN8LKsBAUEdnKq0rOI358ndtsTya1dS5m3lOkkGQtzoHYB+HOierc6NbJyDcfCJfrI2nokNn3/Lrh1kYBqn37nw34BGqGUkyEP3WTygynQN64EwSpvq2Z5iXvZsmWe8kC9LBxUkU3RHrRgS6GxKizgRoczpylhODnF+gvS1D9CjnaiYcJm2Nm+JaLGqMcMjTnG0cK3copwF/LukxcVjoz9cF2OR3J0Vubwo+L72sb7vspo2jgZ1tLGulGeHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9bb0ecfd-038d-2671-9929-8f9b37f5ea75@suse.com>
Date: Tue, 7 Dec 2021 11:19:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Ian Jackson <iwj@xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
 <a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
 <9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
 <b43c072f-4d4c-a108-2c24-801116e99c3e@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b43c072f-4d4c-a108-2c24-801116e99c3e@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0042.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fed6cbb0-6a1f-4a06-c1a9-08d9b96b15e0
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038A465D0A4DD4445244678B36E9@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LHRpfeTvxzCyQkf2JSsj8HKwPNxO2yZX66IZQZDQL+o4TBqQr292AquJd5+6NZNmuZ5tWNE8K9vMIsWRljMCnmKKaTm/F6vkM/sfmPyrZSxCpSEKq1Sdgls6g3dUcsPMJp5cm7T1WDDxdAr2tXQld3YKDmr1jnxlbj+HZL1j3u45KL9U+tfCLujPNXxoqgqARzsKsDR5WyzJPu0bFk3fvJtXFurTGFaqXdZVD0SPzShLALXIz7z4PUAl0nVAuCM7TysueLQVtgxiy6ygS/eLcgaBzl3uKungvsQLxroXnPcXodyBLGpvH4rRtO7UUtbOEMz+aECoNetJWEmKxlnW5VS5p0qEsOwrWcy9XJlYE+WrfYKPub6ObBkIuGInHJC3GJ9JcYWYozDMBqZ9vweCIYniueH/9G7/7ISWc+a/RavQUW+EPEnDffbD8VdROesoX852ex3tm9szVHtkWWZz7FDzlgGRIqgVXaTXv7UhLwtcne+IdQx2cxLNm8hcSU9bqbK8Il5yn0YMcT5w9lXYsRjqN2V8wU6oObKd3cBBcU6Bafl1QfWynQ84A2XjimolN+57Y2/mg9Ls1wfjE2TorkI+/tcT81PEX1mPff4aseLzw9FBj9Vsj3Eh3FNgKnnsogRD8jhsK/9VZ9NJrbF5Aatl4gPc+Xk972y++/0r5OEoI/ugwamtmp20MgfaKka8/9ntiFQpjfwB/28rGozq8jVeEoGsksUdU6qlbl4yLp2PfyPIhbr78lGy8jbDA41kmvlPyvKobiN8yuKyggjE5k3XHidzDJ4hpDS79CvFADpJC8lJc7AGo0SRyri8XwzK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(54906003)(31696002)(38100700002)(16576012)(5660300002)(6916009)(36756003)(956004)(316002)(4326008)(2616005)(53546011)(31686004)(86362001)(186003)(83380400001)(26005)(8936002)(6486002)(966005)(66556008)(66476007)(66946007)(8676002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cVNvc1VBbGF3Mk82NHdiTHN3cmkwVTJXVVpxazZxaVVhK0F3eHB5VDc5Ty9P?=
 =?utf-8?B?blZtNWNETkVoWnQ1SWFKUHRRWGhzU1VtTGhDVitKQXM2TEg3aWtmZEFOaS8x?=
 =?utf-8?B?VkxQUC8wb1BoTzZUbURSYzVEOFJlZG1HU1h2UjNrclgrYlNKeVRaNXNkZWta?=
 =?utf-8?B?OXNTN0tqUnFEb24vbHdOVUpHRTVOdzJrUzZxM0NpYUpQVkQ1dXVqSE05S3FD?=
 =?utf-8?B?ek42K2RtUjhhenZONXdEc3RoaVFXeE8xUytWbnVKV2lId015ZlpteFlVWjZh?=
 =?utf-8?B?U0VLRkR2QjBMNHhoc0s0a0JxbURaaDJISHE0Z2h4czVCZDkzQkVMUGwrbGIw?=
 =?utf-8?B?OU9IYkFvY0w4Z3ZTYkFnQzdnRDNRWGhxRzlwRFFwcUFJVWRiZ0xVdzFRLzJH?=
 =?utf-8?B?bnhWWi96S3Y3MmJHMGdFeW9GdEpnR2JJVlJQZVNRd0QxbWJGb0o1ZTVxTkJW?=
 =?utf-8?B?SmVJcXkxQk1MR3VXbGp4YkZFOTVLa1R0Q1VMTk91dUxzaUlOL24wQlNUSUYw?=
 =?utf-8?B?Wms3MWNlRGdYd0hRdndmMHptcmF0S0FKS2Yxai9yVGdPV0dGNnBLd1JTbFI5?=
 =?utf-8?B?MCtNSVBjekcwUmZiOVRNaEgrUkY2cE9zUnZFYVp1SERwa1NlQlpZZ0dhY0lq?=
 =?utf-8?B?QTZqd1NvamkxQStBY29lenowQ3NjUTJ0OHdDaTVsRGJ4cG0xaDVlNWxXSUZ2?=
 =?utf-8?B?b3ZNY2RWQkd6cnZsbktwek0vSXU0RHRjUGxvWkRmdFZXSDJQdXJMQ2s5bStn?=
 =?utf-8?B?RGlRYU5uNVl6WnF6NEVqL1B2MEhlblZNWVdDMzczcGtqRytxNW4vRFJ4bTBB?=
 =?utf-8?B?d2JJY3hqcmdKdW5KMGVxWllqa05XY3dIOW5odDVGSi9qQ05leGR6RkkvV3Nw?=
 =?utf-8?B?dG4xWnMwNjh5Zm1FcGhZV2hlREZRZTYzNGVFNVEzNGt4V2lyVmNZbzNpaHVV?=
 =?utf-8?B?TEMzRkp5UXA4V1hQNVdlUC9DalNJNmNqOHdYU0J4aWx4Q3NLcithSlBVek9O?=
 =?utf-8?B?MVJDbkU5cXZOSkxROVVYdHVvTTQ1NXNSVm52UGdXSTNwemovSWY5dWpmYkdN?=
 =?utf-8?B?NytHbnhDYk14c1ZkdnBadXVJZFZ2Zm55am9IUFpaYnBRQnlvMjk0OTlTMmZI?=
 =?utf-8?B?bXRVN0RMaVk0SklJVko4ZGRyV1l0NWxiRndIaXpwUjNmUy93QUNWRW9tbHBG?=
 =?utf-8?B?VFplUlpERnF2ZGNlQVVvS2JaelluWEh2UVpXMVRVbXlnVFZuUyt4eC9ZWmFY?=
 =?utf-8?B?TVpCSm9YUzFGTk1sN2g4MTg3UENrWDdvdGt2RFJvQVZ0djFVNkZSNUovek5I?=
 =?utf-8?B?bncyblRzVVpUdThtWHMwSGxZbnBkZ0ZWcE9PYkY3bnNQRHlyZlg3eFhGUDRo?=
 =?utf-8?B?YlMxUnExWVptVnhraERKZVZQUXJZUUkzK3FRRzdpMkZFbEwyMW1Oeko3OWcw?=
 =?utf-8?B?bldQczFZcWpoTFNNU0ZCekdFL2R2dTJTT0poek0wcXBjMEU1eHRPTjI0Y0w3?=
 =?utf-8?B?VGRYZ0tsb205WUZhOXVnc1FCZnhwb1lRaGVFejlRL1ZENlRmZzFSZGlFY2N2?=
 =?utf-8?B?Z2NjaithNExoWHhCM084bU5OUlh2UnhpUHNrS2s4MVhlVG85QUlYeVNXazkv?=
 =?utf-8?B?UnVNbGhOSG9DYy9aam9ZRlpreUZOOUZ3Z29ESW01STFuVTdhYTRUTEo4eHNp?=
 =?utf-8?B?S05kVHRONVVSVEh0RDVoR0c5UkNLanNNUFNrak9ndnIrZ2tWZ3VzaXVEUTZW?=
 =?utf-8?B?dXNMZE9BQ3ZIM3U5Rmh1N0xJUmlNOXhOQ0JwUVVyYXRpcjhmUHpvNFVROUQz?=
 =?utf-8?B?c21uRExWYkRRZlF0RnlRMGJ5WkJ6VFBjOEhKdWRCQmVuL1ROVis3OFVaVVR4?=
 =?utf-8?B?TmRGZGU1b05DZzFxRjJWSUtKNmcxdXlMaGt4bG9IbXcwWkhUOEQvZTErTkJv?=
 =?utf-8?B?OEtaMFc5QisveVU4QkhIVFFWaCtCelhqQlcyL2gvNGZtWWlJYVkwZmNTV04r?=
 =?utf-8?B?ckdrM2hSbWtYK3dSeWkySHhFUHcySnUvcU4xWlBrdTM3dEFmMjVNbStpamx3?=
 =?utf-8?B?QitJU3oyUnVCemFtaklPbFgvc3pCNlhrWTRMVEF2U0VFVFdVSjVnbUdaZ2hZ?=
 =?utf-8?B?Y2J1blRVcW9DZEttNTcvWklHZ0N0aFc2eUNoTndjdEdodFpnNktCWU85ODRl?=
 =?utf-8?Q?2uHY1rJeA/cR+OhPMBcQbC0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fed6cbb0-6a1f-4a06-c1a9-08d9b96b15e0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 10:19:43.0795
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0Fj2rDmyUAyShedQb2L3F1VVuqkMTuRqS61KXs68dRF+H5vUS9CSo0ZM0F1pry1UpUyT+qNpLnr4d1qiBMuozA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

On 07.12.2021 10:59, Julien Grall wrote:
> On 07/12/2021 09:11, Jan Beulich wrote:
>> On 06.12.2021 17:21, Julien Grall wrote:
>>> I still have have no way to verify
>>> what you did is correct.
>>>
>>> For instance, the tags in patch #2 are:
>>>
>>> Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org
>>> Reported-by: Yu Sun <yusun2@cisco.com>
>>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>>> Acked-by: Daniel Walker <danielwa@cisco.com>
>>> [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d]
>>>
>>> The tags in the Linux commit are:
>>>
>>> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
>>> Reported-by: Yu Sun <yusun2@cisco.com>
>>> Acked-by: Daniel Walker <danielwa@cisco.com>
>>> Cc: "Yixia Si (yisi)" <yisi@cisco.com>
>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> * The first two matches the original e-mails
>>> * I couldn't find the 3rd on the ML.
>>
>> See e.g.
>>
>> https://yhbt.net/lore/all/20191108202754.GG18744@zorba/t/
>>
>> (Andrew Morton's reply at the bottom) for where it originates.
> 
> Ok... So this is taken from a different aggregator. I will have to brush 
> by search engine skill then.

To be fair, I went hunting for it only when writing the earlier reply.

>>> * The Cc could be ignored
>>> * The signed-off-by are I guess what you call "mechanical"
>>
>> I would generally retain Reviewed-by when our code is still quite
>> similar to Linux'es. Acked-by are on the edge of being useful, but as
>> you can see I did err on the side of keeping it. As said in a number
>> of places elsewhere, for what I call mechanically added tags I am yet
>> to be told of their value (or even need) in our tree.
> 
> I think the question is how difficult to do you want to make to the 
> other reviewers? I appreciate other (including myself) may have ignored 
> the tags in the past. But now that I know you do it as a manual process, 
> it makes me a lot more nervous to simply ack such patch without any check.
> 
> You seem to be unwilling to simply copy/paste them.

I'm unwilling only as long as I don't understand the need for them. As
indicated, while I appreciate your "make verification easier for
reviewers", I assign that at least no higher priority than my desire
to leave out inapplicable data.

> So for this series, would you be happy if someone else do it for you?

I'd be happy for anyone else to start over. I would even ack such a
submission myself. But as long as I'm recorded with S-o-b, I'm afraid
I'm not going to accept re-addition of the tags for no good (as per my
personal view) reason. Otherwise, based on experience, the example of
this series could, in the future, be used to tell me that on an earlier
occasion I (seemingly) did things differently.

As said earlier, if submissions in this form are going to be nak-ed
going forward, and if good reasons (see above) will not be provided
(and hence leeway will not be granted to the submitter) to support this,
then someone else will need to start looking after imports which may be
relevant to us.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:20:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240831.417571 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXaU-00007P-QT; Tue, 07 Dec 2021 10:20:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240831.417571; Tue, 07 Dec 2021 10:20:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXaU-00007I-M7; Tue, 07 Dec 2021 10:20:42 +0000
Received: by outflank-mailman (input) for mailman id 240831;
 Tue, 07 Dec 2021 10:20:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muXaS-0007Hn-Uo
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:20:41 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 536a3601-5747-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:20:39 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 64D391FD2F;
 Tue,  7 Dec 2021 10:20:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FEDB13A1F;
 Tue,  7 Dec 2021 10:20:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iruGCnc1r2GBawAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 10:20:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 536a3601-5747-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638872439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=wq/IHPSUtMmXmS5Tp0chUc2RosTnphPXRdcOUicOUp4=;
	b=gsleBAziQwRBPVcEBlIIDBIoWBd6I6RG71Z+qPCqaCHn8COQKjnjF1eeexdz7YujX5I8Ra
	w+6QAtoete1iJmMGWiwSUrJAQHXoqJLRLlxmzwUVLAlf4CnrU1uRz/C1iZofHuRpOY5LdU
	tO/2UJk0oG9JVir8XnOAGgkToDHINHM=
Subject: Re: [XEN PATCH 19/57] tools/configure.ac: Create ZLIB_LIBS and
 ZLIB_CFLAGS
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-20-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c9ab92a5-d8eb-73e7-b975-d899b1d35018@suse.com>
Date: Tue, 7 Dec 2021 11:20:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-20-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="YP7UvLP4FT2wzf4g9DhzggMs7wIra2eq5"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--YP7UvLP4FT2wzf4g9DhzggMs7wIra2eq5
Content-Type: multipart/mixed; boundary="PUFijDVUlAWBSQC5CisS6wZbLP4zYFhwu";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <c9ab92a5-d8eb-73e7-b975-d899b1d35018@suse.com>
Subject: Re: [XEN PATCH 19/57] tools/configure.ac: Create ZLIB_LIBS and
 ZLIB_CFLAGS
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-20-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-20-anthony.perard@citrix.com>

--PUFijDVUlAWBSQC5CisS6wZbLP4zYFhwu
Content-Type: multipart/mixed;
 boundary="------------BBB0F741959521638DE56086"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------BBB0F741959521638DE56086
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Use both ZLIB_CFLAGS and ZLIB_LIBS instead of cherry-picking flags
> from a single "ZLIB" variable.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------BBB0F741959521638DE56086
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------BBB0F741959521638DE56086--

--PUFijDVUlAWBSQC5CisS6wZbLP4zYFhwu--

--YP7UvLP4FT2wzf4g9DhzggMs7wIra2eq5
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvNXUFAwAAAAAACgkQsN6d1ii/Ey/E
5wf7BUmyO+CdGafjcf2LyxRkcOjfqxgvFpd+k7qhYbMd/9rFf2QhOgf1nGjB1lQs+LsK8JrVrKBz
dbhIKrkdxDXyx4rXM2lV2HYa5y/KZJISNUZZyJidzLveyT0cBIFvEnw34VkEd9QQQ1k1FoKMX7xo
ojZi+eNqwoeVTyNj7M2Y81Q1uj0OlETsCK526ICNWUR2wKRn/R4QkNzRgerzgB+npR4AJbO/YasO
IEGYJI4m6f86My/nG2Vgs/qjlf7UNNTi65GJr/Ze/m+6dSoBYFmcQfQhHGzh/j3LZyx0PA2LJVBm
LO0QebAYaObaB8EMkHrKbxcMNsY3hvDg6pYmMm73Gg==
=z6hl
-----END PGP SIGNATURE-----

--YP7UvLP4FT2wzf4g9DhzggMs7wIra2eq5--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:23:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:23:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240842.417582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXdF-0000sb-C6; Tue, 07 Dec 2021 10:23:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240842.417582; Tue, 07 Dec 2021 10:23:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muXdF-0000sU-8S; Tue, 07 Dec 2021 10:23:33 +0000
Received: by outflank-mailman (input) for mailman id 240842;
 Tue, 07 Dec 2021 10:23:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muXdE-0000sO-Gk
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:23:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9e8160e-5747-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:23:31 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-uHDEd2uLOwOL_BCND-OT1A-1; Tue, 07 Dec 2021 11:23:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 10:23:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 10:23:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0602CA0012.eurprd06.prod.outlook.com (2603:10a6:203:a3::22) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Tue, 7 Dec 2021 10:23:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9e8160e-5747-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638872611;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wmD5CAN7a+Q87nXx5QfYdUxt+z4CIBIAmgn2KW1KldU=;
	b=NMiIAEQTrjYF0g4ukdY7FUwydkp9DoeDz+RMIp8vtyJqchdBWk9LmMKvyH3Fhl5VsJZRxF
	0oiOsgtvCbMW2cQ1N7Ho7pWlN3KgVEe8p7Uy1U6MWsmT3/ifSoyM9oCiflA708YDPNExRq
	QG1IshO2psF96byjYXfDU/IYs5r09xE=
X-MC-Unique: uHDEd2uLOwOL_BCND-OT1A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i44CaEwpVr29YfyIcD5iJfXlYTsGU4KMIRzVlZMECu7VIZLifNXn8fw/KCdKwtGGhphHmiFrdz0gG3neCr6BF1D3Z3/CirezpoPIwjlHDwNSZsaNzIIwzesoHayGd0cAJF8HLyanKaI1HWYSIFHc8kSA3gy3Zew6vnzuTxmwHKNTm9u3lraq7jKGGbdzUfClPv30QOL+6XQwdx/amz0/I3T1mp+kS05Wh4+xfPx9UWRjqDQPD1Fo1vrZlypngcYE+7KpHO0fcTIULwyVfKENysca3fEycFN4ZB3ERxLYxWm+HsLOuIWMvcg7BtEKHTrDnNMIgvJQvx+8zt2xFkZHmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wmD5CAN7a+Q87nXx5QfYdUxt+z4CIBIAmgn2KW1KldU=;
 b=f3hpwDUOpOLkyMhjxWmUJ+MGar8VcHuj6XzPqzgi7sTcELf7AM3+RCGWAd8HK8/vUsQxDIOW5XKJrWGNZcp/rC0zcMzofV7mTTc97I7kfcAaTI3JfWjyhpj5B9VA0EY+DfuKNIqRnl3IrZbFFP9whiE97N/UyluDASCSILMgnRFZ00TVH5h48xJpAmrv8S2KKwpbUywtiRCOVIYBWJ6aavaYYeAb96YRqP+Ky+YqbXBB4Dchv3lrWViOK34b8ZJ0i7rIiQHkaK/UEFXv/2+yHjrqxFnB/QiTMEWBqTRS630EO7eA07mSwmfdmtJsAvADRNwBm6rRC9XYbfpqX+8xcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6b92c237-9ca9-813c-615a-74a2f3e858d3@suse.com>
Date: Tue, 7 Dec 2021 11:23:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 11/47] build: fix enforce unique symbols for recent
 clang version
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-12-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-12-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0602CA0012.eurprd06.prod.outlook.com
 (2603:10a6:203:a3::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fca43cab-1337-45be-2652-08d9b96b9c4c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3936718E9650F1EF60D982D2B36E9@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	itDvDhNt33WDcR9wO5QsGdrYyjpmyzDqdyAPVVh+I4PgGvJErNn8I87cgy0GD7nCww8/u0AuwWNv6UbNAy/I2XZP8SmZGerrcnJdrExUYMghgBi9iTv7YHeqXUT23qnFPjecRdZKgAeHxi05btAJnfdqLphJztiuvUbpGzZrncXOwU0iAV6F0JxmtXrY98Xc0Ca4R4CINsvVqRXb7Us04XnviuK0xnamqxmuLhVvPJHsjn1bC9Mdib6vVxWeGJEfgaUGpVvyUH0RYYATUyWpyTBJp3r/0WlRMr0XsYv3/4nu3TRLLHNfzfgVqN1aea4LQlIP0P9W3V5RQb5c4jnq62LVDjPKBrSNppemtB2FcdlgieElYgaOPUCGBDv6zlf7d5dsni74Na24ftl85te1GNars67Q1dqDKFvtFLgYegDzAWj5K3QoemLKO7y69Okxxd4k+jbLlMHMuuW/l4XZo/DPtiSA1nboAmdmUAPA95kT4nXBv8TIX8H3Dv38bNYLjQ016th1Ai0OegLp/iFcvKBhtschNOLHs5hQufF4ZdG9hkcF8vzQsJk0/CMXeW8e6Flrw2f0EQIV1wMdhMhSY4jvRSz/+2tS/px9vBGtq6hlPTBqha1YETsLC3FD/PaBubZg4tbVcBqDe7lfIRDiG7z0LWRYmHKd0X7wibWXNlORJa2DHkSMP1O1mRIXxYby2+27q6IclC1WSq2BlQYdkMUazVsr0qhk9WL09I44ay4WHfU8lR+fPCdr2rySJqCm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(8676002)(5660300002)(31696002)(2616005)(2906002)(4744005)(54906003)(16576012)(86362001)(316002)(8936002)(956004)(31686004)(508600001)(26005)(66946007)(66476007)(66556008)(6486002)(38100700002)(6916009)(186003)(4326008)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QWJoSFpCc3h6L3UwV2d1aDJhUUZHVXR6Q0hUZDJScmp5TWJGeW1DWFEvWjNU?=
 =?utf-8?B?dUNvbXhCR0duMkNkeGtIM1dHVU1SREMwbmIrZ0luKzM3cWdVbW5jMW5hY1lv?=
 =?utf-8?B?cG12WEVNV3M3cGtmRDBiTzZwUHdpUW10QmljQllmQklOWDZBL3VXM2R5WElH?=
 =?utf-8?B?RkRneVlkUERUR2ZsOGFRcmRJUndTMVhaelllN2t0UDY5dXphVlh4a0VJZmg5?=
 =?utf-8?B?ZW5WcGRxSXBpeS8zNk52WTgvL1pJaC96ZEhpQkFTbm1nbURLc05ZVzUvQWpL?=
 =?utf-8?B?b0Q2dUxZWDRSUzhWU1ZyeVJJV2Z6VE1IUVVndS9TNTR1OThsYUtqUHBiN0J4?=
 =?utf-8?B?YmdDUkZhU016Ykk0TmpRQml1dWI0YWFrcmtvaHg2bWcwbERUYzFySHo1d0V6?=
 =?utf-8?B?MVZZOEcvQmxQUzhVRFZVeUNWa05saXdXem1kak5LbXQ4M05WT1ZnZEh3QVRI?=
 =?utf-8?B?VVp5aFVXK29uYzJqMXFWREJFMTFlSTFhNmdoai9TWVFnTkZLMHlLSnZackFV?=
 =?utf-8?B?RGdNWk1tcGhEL01XZWF1aElZUVY3M1lrenJaNVhHcGVsYWVtRlp6Rm51QjFr?=
 =?utf-8?B?TDVGYkJybzZTNnNnT1JQYVdWaFZEUlo2ZFhwNVVIcmp1WXE0VklEN2J3M0Vz?=
 =?utf-8?B?Z0IrZFYzTWxhTEZQd1lHdmhLdy9mQ0hhcDRCTGZ0U3pDYVBpYlJwZXorc0Rl?=
 =?utf-8?B?OXczM1NIK0lVQkhVU2dtbnpiVGJnOVcwbWtxQkpGR2YwTkJjT1UvT3NoQ3Vv?=
 =?utf-8?B?ekdSR2tMbTYzOUZhZHFiY1JBREgwZWhIMHQxazNuU1ZZbDI2TTR2V09PekJz?=
 =?utf-8?B?SVhyN011NmxOWDVRcFZCM0hER21kcnRwQVZINlY2NUxBNkVBYS9JMWtKMkxW?=
 =?utf-8?B?TG1SaUx3U1N1VzJwa2N0ci9GUzBLR2VXWm5QZFN2RlBsVTR1U0plbTVEL1Za?=
 =?utf-8?B?eHk5QVk1endXL0ErUU9CQkl3V2xzSnc4OHBHNHhIMXIrbXJFaXFiYTIxR1lV?=
 =?utf-8?B?aENiSXVvS280VGlBTEM2OXc5b2g3UDIxQmhsSjRUVmo1L1pDckZnSFdrN0E5?=
 =?utf-8?B?QkdZTGRkOUkvRUZad2hpYzBrNVBDUExVS1hERnI0RE5yUHp4UE9lemltd1VU?=
 =?utf-8?B?VHpBSnlVSVpQQkh2SEpyYnlwR1A5SjliS2oxOG5PcEFBV2xjbGRRN2NybWgr?=
 =?utf-8?B?Ym5YT0ZFeDlpWTNNNXgzRjB1bEl0MlgyY3owdVBNaWVNZVk1Rit6QmVnM3A0?=
 =?utf-8?B?V1BzTmNWK1RaY2ZGOTJrMHlqSFplbHlEYkxIM094bVFZQUgzaktZNFNaTldY?=
 =?utf-8?B?SllhL2pKNlc2WWo1THB4K1ppRmxpcEdlanBQQVE3UXU3Q1ZvZnJoRlF4cFBy?=
 =?utf-8?B?QnVqM0NVV2Nld3RrdlBKUjArZnhzRDZETmlCcjFJNkxUZWtCRlI0aHlsUk1k?=
 =?utf-8?B?QjRJSWkvYjlxaFh3YnVITXNJanFsb21sN1ZQZGpucy8yYXB6Z3RDMTR4cG1z?=
 =?utf-8?B?eG1wQlkyWms4VXMyRGpjMnQzR1BRSEhCVFQrRURQY0tDMnZFNHNsWHlvUVZ6?=
 =?utf-8?B?WmlMSGpLU2wzM3VNT1o0TFdjakpnMkZkd1pLa0FBWVArcmxndEhsZHJEQUFT?=
 =?utf-8?B?QUNsYzJ5UjZKMFM1WEpJYnlEc3cySFJrWVdzMTNKWjh6ZmpUS1lLeXlCZjQz?=
 =?utf-8?B?VWhkajdtamJpbUVVdER2aERNVDE2a3ZBMHlkaXl0VGNqbit3MGFrS0c1MXBy?=
 =?utf-8?B?azU4T2VHc2ZCL1hsUXRLd0FtUG9ScDhYNFBWeFpKYnFLRUU2ZU9KcW5QSTdK?=
 =?utf-8?B?WmdacGpIbjNrUWE3Q1k2Z0drM0RuanpLN2JvMXVDdzVKb21vYUgxRDAyWW1w?=
 =?utf-8?B?QWZiTW1GMER4Z2pSZFlmbXJpVUo4cUJJN2drT1YzVWpKUDRXUmdpNS9IQ0Z0?=
 =?utf-8?B?azJNWERpN2xFdjVBUjVVbGJaaTR4bWVUSit0QU5pdFNpWm8vWlIyYnlNc2tx?=
 =?utf-8?B?dUpuclY2cjF4SlgybHByeTY5NmlXeWNxUXBTL0I0L1JnbVhLdERaRjBYV3lu?=
 =?utf-8?B?Rmh4ZmtGUmovTEVUU1RBMmw4UmlTVHNrblZLUGpGQzVISDBKODgyT2k1VXB0?=
 =?utf-8?B?eUNFejNqSG96TVBXRDBHL0xrWTVLZzZ4NjBBRkhNZjMyRlNOcHRRZkY5YlE4?=
 =?utf-8?Q?+c5KmeIDRkeJ3uRigzDfB20=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fca43cab-1337-45be-2652-08d9b96b9c4c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 10:23:28.5910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f+uJFSqHquF6WAbAyHm0yBId24qkgwDYsubZ/HXJzNdqKIBVppaQ+9Bc0++WYqNWOagmPn5D1jXvkGAqnI3mgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

On 25.11.2021 14:39, Anthony PERARD wrote:
> clang 6.0 and newer behave like gcc in regards for the FILE symbol, so
> only the filename rather than the full path to the source file.
> 
> clang 3.8.1-24 (in our debian:stretch container) and 3.5.0-10
> (in our debian:jessie container) do store the full path to the source
> file in the FILE symbol.
> 
> This means that we also need to check clang version to figure out
> which command we need to use to redefine symbol.
> 
> I don't know which version of clang change behavior, we will guess
> 4.0.

When I did this earlier work, it was clang5 that I used. Which would seem
to mean the change in behavior was in version 6.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:50:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:50:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240856.417592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY2m-00058B-GD; Tue, 07 Dec 2021 10:49:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240856.417592; Tue, 07 Dec 2021 10:49:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY2m-000584-DK; Tue, 07 Dec 2021 10:49:56 +0000
Received: by outflank-mailman (input) for mailman id 240856;
 Tue, 07 Dec 2021 10:49:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sjJF=QY=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muY2l-00057y-GG
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:49:55 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 673c087f-574b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:49:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 673c087f-574b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638874192;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=dZOTDnUdLfWKaFUwyJjhCw0mtKJKNGU167iTIcbV1IQ=;
  b=K+eykWGt6O0X8oxa2hxtd3/LMJvG/zo4sU5moPaM7L1x46GxD+4+bfDL
   KMvoxZlFEpTXoNIWNUMEqmC7lVC3nbehtlxvIB+VFdj3vJh+6VhQt91g+
   y15s1PVINkU66ty3j6TnO0TJeFdHx01GF+6uU7472tXAZZ4CI5kWi44dM
   Q=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: T5iCEImY+o42g468tUjRdtm3LwQkbcQukiAmJgYfm+Zp1E+zKOmLbrnuCr10oedHr8rRh7LY0J
 /lUoGhmkNL5cIHoei0RxdjfpSAisFtfrA72UYqlf/AAacGaJsmghbCjQTxL4kvMDEr71zHEkJj
 a3SHe7PH7GDmKDMbJukiPfDWQSpmNqriTYGVi/Sp8BX/o1huQAD45tfGcWIUmlc3fVLwKpACkA
 caIj69vhTA1cmyYcVTzLzWCS5CGYgQcp6thPpKmEUVBAUtSlR4gvbsjqoJ9UjIvAD8eC3kKy6K
 0kjWvJKsHzbmQes9D1yEvmoJ
X-SBRS: 5.1
X-MesageID: 59827897
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MYJPYKov9veDVqucJ3CCRvX4j2JeBmK+YhIvgKrLsJaIsI4StFCzt
 garIBnTPvzbazTyeNtyao2y/EkOuJfSyoBmGwVspX9nFHtE9JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dnd+4f5fs7Rh2Ncx24DmW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnaTpeQoELO7gocM2bkV+TghML/RJopaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ptJM2U/PUuojxtnF2k5Aa8ipP6T2Cf9eTlnqUu+qq477D2GpOB2+Oe0a4eEEjCQfu1Xg0KZq
 2Tu72n/RBYAO7S3yzCI73atje/nhj7gVcQZE7jQ3uFuqE2ewCoUEhJ+fUCgvfCzh0q6WtReA
 08Z4Cwjqe417kPDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZpatM8s9QtbSc3z
 VLPlNTsbRRur7+9WX+b7q2Trz65JW4SN2BqTSYCUQsC5ciluIwphwjDZtlmGa+xyNbyHFnNL
 yui9XZkwe9J1IhSivv9rQuvby+QSobhdlcF6yjFHU6cyShEOKj4Tr66sFeBxKMVRGqGdWWps
 H8BksmYyekBC5CRiSCAKNkw8KGVC+Wta2OF3wM2d3U133H0oiP4I9gMiN1rDB4xap5sRNP/X
 KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmO2voHAGia24hTmFfK0QfUYXY
 8jzTCpUJSxGYZmLNRLvLwvn7Zclxzol2UTYTo3hwhKs3NK2PSDOGedcbgXWNLhlsstoRTk5F
 P4FaKO3J+h3CrWiMkE7D6ZNRbz1EZTLLc+v8JEGHgJyCgFnBHsgG5fsLUAJIORYc1Buvr6Qp
 BmVAxYAoHKm3CGvAVjaOxhLNeK0Nb4i/C1TAMDZFQvxs5TVSd30t/l3mlpeVeRPydGPOtYoF
 aRYIJvZXawUItkFkhxEBaTAQEVZXEzDrWqz0+CNOVDTprZsGF7E/MHKZAzq+HVcBya7r5Jm8
 bahyhnaUdwIQAE7VJTab/emzlWQu3kBmb0tAxuUc4cLIEi8opJ3LyHRj+MsJ51eIxv02TbHh
 R2dBg0VpLeRrtZtosXJn62Ns6ygD/B6QhhBB2De4LvvbXva82OvzJVuSuGNeTyBBmr49L/7P
 bdezu3mMe1Bl1FP6tIuH7FuxKM4xt3uu74FkVg0QCSVNwymU+oyLGOH0M9Dsrx26oVY4QbmC
 FiS/tR6OKmSPJ+3GlAmOwd4PP+I0usZm2eO4K1tcln6/iJ+4JGOTV5WY0uXkCVYIbZ4bNElz
 OMmtJJE4gCzkEN3YNOPjyQS/GWQNH0QFa4gs8hCUoPsjwMqzHBEYIDdVXCqsM3eNY0UPxl4O
 CKQiYrDm69YlxjLfHcEHHTQ2fZQ2MYVsxdQwV5ef1mEl7IpXBPsMMG9Jdjvcjlo8w==
IronPort-HdrOrdr: A9a23:royln6iaDmF6REHBlAAr5IqEB3BQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59827897"
Date: Tue, 7 Dec 2021 10:49:46 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	"George Dunlap" <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	"Jan Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of
 "buildmakevars2header"
Message-ID: <Ya88SjdSbANPGrcF@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-19-anthony.perard@citrix.com>
 <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com>

On Tue, Dec 07, 2021 at 11:08:55AM +0100, Juergen Gross wrote:
> On 06.12.21 18:02, Anthony PERARD wrote:
> > This avoid the need to generate the _paths.h header when the
> > information is from autoconf anyway.
> > 
> > They are no more users of the "buildmakevars2header" macro, so it can
> > be removed from "Config.mk".
> > 
> > Also removed the extra "-f" flag where "$(RM)" is used (xl/Makefile).
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> 
> The changes for configure should be done in the respective configure.ac
> files and then configure can be generated via a call of "autoconf".

This is what this patch does, via changes in "m4/paths.m4" ;-).
All the respective "configure.ac" have "m4_include([m4/paths.m4])", so
nearly any modification to "paths.m4" will change the generated
"configure" script.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:52:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:52:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240862.417604 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY57-0006UF-U6; Tue, 07 Dec 2021 10:52:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240862.417604; Tue, 07 Dec 2021 10:52:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY57-0006U8-QD; Tue, 07 Dec 2021 10:52:21 +0000
Received: by outflank-mailman (input) for mailman id 240862;
 Tue, 07 Dec 2021 10:52:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=bINN=QY=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1muY56-0006Ty-JV
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:52:20 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::61b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bebf1cc7-574b-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 11:52:18 +0100 (CET)
Received: from AM6P194CA0066.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::43)
 by AM8PR08MB5604.eurprd08.prod.outlook.com (2603:10a6:20b:1d5::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 10:52:16 +0000
Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:84:cafe::2a) by AM6P194CA0066.outlook.office365.com
 (2603:10a6:209:84::43) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend
 Transport; Tue, 7 Dec 2021 10:52:16 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 10:52:15 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Tue, 07 Dec 2021 10:52:15 +0000
Received: from 4bab25662f21.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 58DC2858-795D-41B0-B092-A2F33B02121B.1; 
 Tue, 07 Dec 2021 10:52:07 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4bab25662f21.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 10:52:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6717.eurprd08.prod.outlook.com (2603:10a6:102:131::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 10:52:06 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622%5]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 10:52:06 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO2P123CA0040.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::28) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Tue, 7 Dec 2021 10:52:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bebf1cc7-574b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9SNRZIlkIQfr2XxDNhrlBDHkr/swtumsR7/J+3zcYVU=;
 b=q0M+J/bQadmK/4mE+zNAdAAoYr02QAmJoeoKYI7tmz/Z9pKVPg6+fVphaQf8skqqik4r8sTFEDvFyDNvuWtHABDtONLXtKvvjV0Nehny2WIlLP9JXOT7AlBQ+F801TDM1+7Ij1Ke4R4sCyV+EK2FDoUxbpLe+MLsXgRA0HCBcIQ=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: d21ec180b7ed8a14
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Xao76e67KvxzmA60XxBsM9gatkD7NpbuIzcZjHkZJKUjvhNg39SyQ8ELJjGclFYIqZ8G+xAiV0Ls4UcLWLYiQD/3bNBUR1CqaWGtWzsb1qHBHH52KDbFlCJIzh5KCrXANu1YmZECw3mCDzzxazT4yCF8aPx9f5vfjTc9ToC6gSl7s8g5QJNFOY5SxRR/kV3HeEmT0V4qwNEAFED3EA1YoYQStICAT4yxSOPmI9RPiUZ4TcPmiLctXkAIDIWXqvhVgVEV7iT+00NqfZ9yi6Ac5pW41+ejnLGYUeJJPFWN+ytF7K4izR4u0IUxhAxNy7EwaujBE8Tr9zCREA8kZYPT/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9SNRZIlkIQfr2XxDNhrlBDHkr/swtumsR7/J+3zcYVU=;
 b=OwFfv0h6fFzVn5eaQd6WIrXQwFO/iYR0IIPU82tvRv6d7SS24iizpU+RxBFFDMmptiH7YNwmwTNWF7kZTxg8Q8PhUhNg7sQIkod5OgobO/5twDB1s2IRso/LG5UxFRPTAb9QQWil/NK3D+G7+BOkJYXDzzUXNRbd9N5wBxP1+QbrwbCjINL+18EtUQYHw1e53tkapORKALbEth7ajxsLjcMf6PwR9ArQ5kLioFbviIb6cv/UUGuq+HOscUPYww5gULVKwJCrf2uB9JiWzjlo/IEmb7BP1obiBp7NAjJ+JYobNHIhXwCyJiDwE/4CBj0oFd1LboiulXSEcrJGewi9BQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9SNRZIlkIQfr2XxDNhrlBDHkr/swtumsR7/J+3zcYVU=;
 b=q0M+J/bQadmK/4mE+zNAdAAoYr02QAmJoeoKYI7tmz/Z9pKVPg6+fVphaQf8skqqik4r8sTFEDvFyDNvuWtHABDtONLXtKvvjV0Nehny2WIlLP9JXOT7AlBQ+F801TDM1+7Ij1Ke4R4sCyV+EK2FDoUxbpLe+MLsXgRA0HCBcIQ=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <f439d5c4-aa6c-4066-3941-e497b67aeae1@xen.org>
Date: Tue, 7 Dec 2021 10:52:04 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 bertrand.marquis@arm.com,
 wei.chen@arm.com,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C96E90F4-611E-4765-9627-EDE75A952E10@arm.com>
References: <20211206153730.49791-1-luca.fancellu@arm.com>
 <f439d5c4-aa6c-4066-3941-e497b67aeae1@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO2P123CA0040.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::28)
 To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 2d2b22d2-13ba-4054-2e5f-08d9b96fa1f6
X-MS-TrafficTypeDiagnostic:
	PAXPR08MB6717:EE_|AM5EUR03FT013:EE_|AM8PR08MB5604:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB5604137535D4DD27B1E1FF53E46E9@AM8PR08MB5604.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 h1IslRp1z4/LEe9ctmY6mVFz+5/tGzcM05fIb47eaCVdLHww5Kol7v+RHJGHwPhi2o108+YD8KuYsAqeL6bGjy1ltf/HAeyMoHOck7m2p4NPDIC/GoJv1PSIv88rXnkJnd0JnaTpVkhgAs6tHHWBpED5saVbyzQfVTB/WpzseWWmp/b+pRekpKf9gfvVR/EV+2kxeoas/7/9TQ5vtGLcDrgobBV8T0WG73ksPCUbP11QH4X50XxWIy0dZEDFBpJJzyawhLBbRmb39JtUNf75K+sRS35oJDU3jzXJB9XBvg6pvC83UEibtSvje5yareAM5mVtJCf7mEXGaii7nDw/vAvHq5YOJBWdG8txHkTPG/Po9wRHGuogxfmlUmmdH0fvnjqnWmxUeTZiI+5E05pxOMnHWSeLCvudnXMUsBZqZAGhrXNt9sk/ebdWgW77BLCvVI9oJCFReS47Lbo5kKw/a9dfVApPCUj8RMyQ1KaBNo9pVfvSdD3cw6zk0F05cg9WAqW5A3jeaj8mhwTpcDUUw8L4VytDY7GX25QCjaWQUEEyLnaFCIkA+qc8u+unJl1d0Lnk8QtGjH91NeMTGgEZtju58PLY9VLfkYo2VJT9J+H1m1WNusziuDyY3QcfF8lco9aaKoCsfrunkLHnS8UbGZFjBWGCwsgWycTR2t+Ea98eQyFaqr2oiPbWWz68bxNpCuMRzf8oUQBpRG+BjSWcJO/rfaAwAup18A4EylXAJnqZ+UnQ49M5rdneW4Avoj9L
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(508600001)(6916009)(2906002)(6486002)(8936002)(52116002)(86362001)(66476007)(54906003)(66556008)(66946007)(83380400001)(26005)(186003)(15650500001)(33656002)(5660300002)(6506007)(38350700002)(6512007)(36756003)(316002)(53546011)(38100700002)(4326008)(2616005)(44832011)(956004)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6717
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a349be8c-64bd-4069-9f09-08d9b96f9bf1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U1aFxpQGTV30iDFOlgyS1Wthv9yXKKdanoulYN3EeFyFGfPcUfpTtK5qT8YaMv99N7HjiuR0YEv3s7MY0Tr8Nj9bau9i2Zq8rihz+FEb+TBZ3PiEs2SF2BmUQeCOyJRwlb4+8lEZvbhx0iMGVGUgNQh8PQepBlCN4+W+xS5DddBXxnJCTkTUwg9NPscV3AcuVdXPINlLlhKZiN2ImXSDu/anqxiWeoAUiRxbdwiJ9w/w02R0YBd5wA2ERr33/WOL/DVRtyDX+1DqRw5rOmiuaQ8L7GQv+idfHHnlC+BgZ/c3E9hzlqDsoJGy2duwsBLBG1IaNeEwiWJIKmCOq0TWKzihP9I0MV1J/LFkDknCxrm5ZgvtJVcKiNO+qMxWuoWy4CJxc/YCv06vLMgyy7a1POocRtisRHL4LW5ekfaDzcv/UdBMUNfTkQunXvf1pK1U+v75eN6WbZQmO6X3vhKT7F7IpYOlKlkNA0MA51B7FlhIFxkywFxOEahMAuwy1RXWSURF1U6WT20inU+PyOVxlMofQdBDT5DZntQgU28mYIR80tyM0dKdTemJWgY1++3y5ULCFJeRIHS4TYI82BhOgxH9aVbyihDDFo1Nt8Y3rjtgsiYBWYuO97E0Jgx4h5h2fHHG+DjieuTrRK5JkH9lg5ebgpx1svfP3DxAS/0w+glB6RYrcyYdj2Ouk1wG8sCg8VIBPf12biYU1YNsdTsK3g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(6486002)(316002)(15650500001)(33656002)(36756003)(8936002)(6512007)(44832011)(6862004)(86362001)(956004)(70586007)(81166007)(8676002)(70206006)(6506007)(54906003)(186003)(47076005)(53546011)(107886003)(26005)(2616005)(83380400001)(5660300002)(36860700001)(4326008)(2906002)(82310400004)(508600001)(336012)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 10:52:15.8506
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d2b22d2-13ba-4054-2e5f-08d9b96fa1f6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5604



> On 6 Dec 2021, at 17:05, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 06/12/2021 15:37, Luca Fancellu wrote:
>> Currently the maximum number of memory banks is fixed to
>> 128, but on some new platforms that have a large amount
>> of memory, this value is not enough=20
>=20

Hi Julien,

> Can you provide some information on the setup? Is it using UEFI?

Yes it is a platform with 32gb of ram, I=E2=80=99ve built Xen with ACPI sup=
port and it=E2=80=99s starting using UEFI+ACPI.

>=20
>> and prevents Xen
>> from booting.
>=20
> AFAIK, the restriction should only prevent Xen to use all the memory. If =
that's not the case, then this should be fixed.

The code that it=E2=80=99s failing is this, inside efi_process_memory_map_b=
ootinfo(=E2=80=A6) in the arch/arm/efi/efi-boot.h:

#ifdef CONFIG_ACPI
        else if ( desc_ptr->Type =3D=3D EfiACPIReclaimMemory )
        {
            if ( !meminfo_add_bank(&bootinfo.acpi, desc_ptr) )
            {
                PrintStr(L"Error: All " __stringify(NR_MEM_BANKS)
                          " acpi meminfo mem banks exhausted.\r\n");
                return EFI_LOAD_ERROR;
            }
        }
#endif

>=20
>> Create a Kconfig parameter to set the value, by default
>> 128.
>=20
> I think Xen should be able to boot on any platform with the default confi=
guration. So the value should at least be bumped.
>=20
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  xen/arch/arm/Kconfig        | 8 ++++++++
>>  xen/include/asm-arm/setup.h | 2 +-
>>  2 files changed, 9 insertions(+), 1 deletion(-)
>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>> index ecfa6822e4d3..805e3c417e89 100644
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -25,6 +25,14 @@ menu "Architecture Features"
>>    source "arch/Kconfig"
>>  +config MEM_BANKS
>> +	int "Maximum number of memory banks."
>> +	default "128"
>> +	help
>> +	  Controls the build-time size memory bank array.
>> +	  It is the upper bound of the number of logical entities describing
>> +	  the memory.
>=20
> NR_MEM_BANKS is going to be used by multiple internal structure in Xen (e=
.g. static memory, reserved memory, normal memory). So how could an admin d=
ecide the correct value?
>=20
> In particular for UEFI, we are at the mercy of the firmware that can expo=
se any kind of memory map (that's why we had to increase the original numbe=
r of banks).
>=20
> So maybe it is time for us to move out from a static array and re-think h=
ow we discover the memory.
>=20
> That this is probably going to take some time to get it properly, so
> I would be OK with bumping the value + a config gated UNSUPPORTED.

I can do that.

Cheers,
Luca

>=20
>> +
>>  config ACPI
>>  	bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUP=
PORTED)" if UNSUPPORTED
>>  	depends on ARM_64
>> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
>> index 95da0b7ab9cd..785a8fe81450 100644
>> --- a/xen/include/asm-arm/setup.h
>> +++ b/xen/include/asm-arm/setup.h
>> @@ -6,7 +6,7 @@
>>  #define MIN_FDT_ALIGN 8
>>  #define MAX_FDT_SIZE SZ_2M
>>  -#define NR_MEM_BANKS 128
>> +#define NR_MEM_BANKS CONFIG_MEM_BANKS
>>    #define MAX_MODULES 32 /* Current maximum useful modules */
>> =20
>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:53:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:53:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240867.417615 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6O-00078o-Bv; Tue, 07 Dec 2021 10:53:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240867.417615; Tue, 07 Dec 2021 10:53:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6O-00078h-7e; Tue, 07 Dec 2021 10:53:40 +0000
Received: by outflank-mailman (input) for mailman id 240867;
 Tue, 07 Dec 2021 10:53:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muY6N-00078Z-0M
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:53:39 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee3b61c7-574b-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 11:53:37 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id DC29121B3D;
 Tue,  7 Dec 2021 10:53:36 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9876B13A1F;
 Tue,  7 Dec 2021 10:53:36 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id A4/zIzA9r2EnfAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 10:53:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee3b61c7-574b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638874416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iMU5kFRFW4+mIyjlpwDRmaB93Kkrj4D2KFkdZFHBh+I=;
	b=OVxh46/Of1hKJDvZ3zjFRJKpELSoo6e2w+WERG1jyP90CYYURPdQKr30BGB6+4pBCYavbG
	NrETmzYiBNnPnwxXBxgBrJSDo1EW+8T7FXX8rsvvB+AihNKBaolu61wgxMqE16+m6D3wly
	UYI3k9Ux8Z7JA03KOqWfWzYC9K6HNG0=
Subject: Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of
 "buildmakevars2header"
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Anthony PERARD
 <anthony.perard@gmail.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-19-anthony.perard@citrix.com>
 <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com> <Ya88SjdSbANPGrcF@perard>
From: Juergen Gross <jgross@suse.com>
Message-ID: <1c7d51ee-a3f7-e458-b699-906e50ef57a0@suse.com>
Date: Tue, 7 Dec 2021 11:53:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <Ya88SjdSbANPGrcF@perard>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="iQduExcDZJDa2grjZDDFjdZLwUA2PjwRm"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--iQduExcDZJDa2grjZDDFjdZLwUA2PjwRm
Content-Type: multipart/mixed; boundary="7pKB62OYhZGVVlrXApwTt2DjCrVokXCHz";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Anthony PERARD
 <anthony.perard@gmail.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Message-ID: <1c7d51ee-a3f7-e458-b699-906e50ef57a0@suse.com>
Subject: Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of
 "buildmakevars2header"
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-19-anthony.perard@citrix.com>
 <d9819a32-7a45-f753-0b6d-50e01aacb6a1@suse.com> <Ya88SjdSbANPGrcF@perard>
In-Reply-To: <Ya88SjdSbANPGrcF@perard>

--7pKB62OYhZGVVlrXApwTt2DjCrVokXCHz
Content-Type: multipart/mixed;
 boundary="------------7BAF95EC78BB71DC8159B772"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------7BAF95EC78BB71DC8159B772
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 07.12.21 11:49, Anthony PERARD wrote:
> On Tue, Dec 07, 2021 at 11:08:55AM +0100, Juergen Gross wrote:
>> On 06.12.21 18:02, Anthony PERARD wrote:
>>> This avoid the need to generate the _paths.h header when the
>>> information is from autoconf anyway.
>>>
>>> They are no more users of the "buildmakevars2header" macro, so it can=

>>> be removed from "Config.mk".
>>>
>>> Also removed the extra "-f" flag where "$(RM)" is used (xl/Makefile).=

>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>
>> The changes for configure should be done in the respective configure.a=
c
>> files and then configure can be generated via a call of "autoconf".
>=20
> This is what this patch does, via changes in "m4/paths.m4" ;-).
> All the respective "configure.ac" have "m4_include([m4/paths.m4])", so
> nearly any modification to "paths.m4" will change the generated
> "configure" script.

Oh, I just looked at the modified files and didn't see any *.ac ones.

I was already wondering how you could miss that, especially as you did
it correctly in the next patch. :-)

You can then add my:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------7BAF95EC78BB71DC8159B772
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7BAF95EC78BB71DC8159B772--

--7pKB62OYhZGVVlrXApwTt2DjCrVokXCHz--

--iQduExcDZJDa2grjZDDFjdZLwUA2PjwRm
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvPTAFAwAAAAAACgkQsN6d1ii/Ey/S
4wf/U5RHMU/cjsN6Y/B7gWHHsmVa0B1neCtcTE+p9UganhA+GUtohlcoLFKXInxSBuQ2FKzW11+k
YIZrJr8jlGgtotk2Ts2g2u2j8bqkg0L6Nig3HcWoTDsuBACKl2uRvnHdoVTDJ9Gba7dtYaP5/oTA
D72sa+Vj4kxqtNfz5VVKkK6w9GPiozObal2wKK7FM4w3GR2sKzaGgX4M6q67keLY4sXdjpAO6xyq
m1+73hbp+WtKSAGpj8KpNtilsUNboXRHsTaXQ/uic1dzXVa/XkfjHuZYgmSSVW9rYMoYiaBn/cgV
A7159VNvQ3c6Bb+LJbmkSjHSxsw8QsceiSeQf55a1w==
=UN2i
-----END PGP SIGNATURE-----

--iQduExcDZJDa2grjZDDFjdZLwUA2PjwRm--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:53:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240869.417625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6f-0007bE-KC; Tue, 07 Dec 2021 10:53:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240869.417625; Tue, 07 Dec 2021 10:53:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6f-0007b6-GN; Tue, 07 Dec 2021 10:53:57 +0000
Received: by outflank-mailman (input) for mailman id 240869;
 Tue, 07 Dec 2021 10:53:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WjKu=QY=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muY6e-0007ZY-Nc
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:53:56 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f833264e-574b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:53:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f833264e-574b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638874435;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=D7++fhzoY5NWbD5Y83bEMQFPNo1ym85KhSzs/zIuiyA=;
  b=KMq8qKoGhEuT348bBaBD3sOHdQ6bv1epIGNHTWRiubxFsYFUNpEwPN+H
   Ow68ONU5mr0kVfFdctEb3/IDfODkjRiHdoooxx7cRFzWSeG7pnIrPVGds
   1qCS5EE/exAJg6cGAoWs0sjOAUa/F5ZnidjyMQ+Kgo801sKQPCO4lSvk9
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: dt+gcHzbw+IghTrs6Y9yWDtVdrHZ0IJqqCQqaeELLI4qBa1p96yxj6egxuJL7bJGOtyNpqeMt+
 HXF/LLsI/fW2+c1hu3dngvRPjNqqwsCafgCGiV4dOr9zbUIIqyCk3MxpeWU09Yg+DTGXyccYJd
 KUXeiTA3BSxwgo8WuQA7HniXVfAOJwdylK7H9b6n2pDT2TWuJIMnA/CqQTf85bbwCyvbhn+mR3
 EIE9Mf2uSn6Fh352VK0uBXU9efhA/yzYD7cDq6IJawDrqCYYiUEdkUdpg9f3uVHb8cOmBzvquY
 Qh8P8qVn81GeJRuZn0ewaqvS
X-SBRS: 5.1
X-MesageID: 59828125
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:RZs2naIKuMu/DqCxFE+R6JIlxSXFcZb7ZxGr2PjKsXjdYENS0zMHz
 WcbUD3VOf7fZWH9eI93PY7n/B4OsJXdzt9jG1RlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Eg7xLZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ErsE29
 9dG7qWcbiEgYZ/dvPQsDjRhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gph1poeRKyDD
 yYfQWVXVBj4JDxCBnwoK5IOhuSVpnzVbTIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wh
 EjL4mD4CREyL8GExHyO9XfErv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCssy8NHOVSGLYDxCarw/Xm8iKJNzUpd2sUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZo87SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFRON/Ni2+AswGzARN8wGGxFAbpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmr2qy76I94Iumkiei+F1/ronhezP
 yfuVf55vscPbBNGk4cpC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk3nVKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4vY+liIq
 IgGaJPRo/idOcWnChTqHUcoBQhiBRAG6Vre8KS7r8aPfVhrHn8PEfjUze9zcoBphf0NxOzJ4
 mu8SglTz1+m3S/LLgCDa3ZCbrLzXMkg8SJnbHJ0ZVv4iWI+ZYuP7bsEc8dld7cQ6+E+n+V/S
 OMIepvcD60XGCjH4TkUcbL0sJdmKEawnQuLMif8OGo/cpdsShbn4NjhegezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeIRy+/pJrJir9iu4MD/sNcRiTlCGH0
 wu2AAsDobWfqYEC79SU17uPqJ2kErUiExMCTXXb97u/KQLT4nGnnd1bSO+NcD3QCDH09aGla
 bkHxv3wKqRazlNDso46GLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeaOeAN87SGVIMIBYoM7aY3vYOlziOtfk4LS0WPsOsEGZrhamKAySxtQ==
IronPort-HdrOrdr: A9a23:83Ab7qOB6VbppsBcTvmjsMiBIKoaSvp037Eqv3oedfUzSL3gqy
 nOpoV86faaslYssR0b9exofZPwJE80lqQFhrX5X43SPzUO0VHAROoJgLcKgQeQfxEWntQtrZ
 uIGJIeNDSfNzdHZL7BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59828125"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/3] x86/boot: Drop pte_update_limit from physical relocation logic
Date: Tue, 7 Dec 2021 10:53:37 +0000
Message-ID: <20211207105339.28440-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211207105339.28440-1-andrew.cooper3@citrix.com>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

This check has existed in one form or another since c/s 369bafdb1c1 "xen: Big
changes to x86 start-of-day" in 2007.  Even then, AFAICT, it wasn't necessary
because there was a clean split between the statically created entries (L3 and
higher) and the dynamically created ones (L2 and lower).

Without dissecting the myriad changes over the past 14 years, I'm pretty
certain Xen only booted by accident when l2_xenmap[0] was handled specially
and skipped the pte_update_limit check which would have left it corrupt.

Nevertheless, as of right now, all non-leaf PTEs (the first loop), and all 2M
xenmap leaf mappings (the second loop) need relocating.  They are no unused
mappings in the range, no mappings which will be encountered multiple times,
and it is unlikely that such mappings would be introduced.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/setup.c | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index c8641c227d9a..0492856292cf 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1230,7 +1230,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
             l3_pgentry_t *pl3e;
             l2_pgentry_t *pl2e;
             int i, j, k;
-            unsigned long pte_update_limit;
 
             /* Select relocation address. */
             xen_phys_start = end - reloc_size;
@@ -1238,14 +1237,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
             bootsym(trampoline_xen_phys_start) = xen_phys_start;
 
             /*
-             * No PTEs pointing above this address are candidates for relocation.
-             * Due to possibility of partial overlap of the end of source image
-             * and the beginning of region for destination image some PTEs may
-             * point to addresses in range [e, e + XEN_IMG_OFFSET).
-             */
-            pte_update_limit = PFN_DOWN(e);
-
-            /*
              * Perform relocation to new physical address.
              * Before doing so we must sync static/global data with main memory
              * with a barrier(). After this we must *not* modify static/global
@@ -1267,8 +1258,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                 {
                     /* Not present, 1GB mapping, or already relocated? */
                     if ( !(l3e_get_flags(*pl3e) & _PAGE_PRESENT) ||
-                         (l3e_get_flags(*pl3e) & _PAGE_PSE) ||
-                         (l3e_get_pfn(*pl3e) >= pte_update_limit) )
+                         (l3e_get_flags(*pl3e) & _PAGE_PSE) )
                         continue;
                     *pl3e = l3e_from_intpte(l3e_get_intpte(*pl3e) +
                                             xen_phys_start);
@@ -1277,8 +1267,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                     {
                         /* Not present, PSE, or already relocated? */
                         if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) ||
-                             (l2e_get_flags(*pl2e) & _PAGE_PSE) ||
-                             (l2e_get_pfn(*pl2e) >= pte_update_limit) )
+                             (l2e_get_flags(*pl2e) & _PAGE_PSE) )
                             continue;
                         *pl2e = l2e_from_intpte(l2e_get_intpte(*pl2e) +
                                                 xen_phys_start);
@@ -1291,8 +1280,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
             for ( i = 0; i < L2_PAGETABLE_ENTRIES; i++, pl2e++ )
             {
                 if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) ||
-                     !(l2e_get_flags(*pl2e) & _PAGE_PSE) ||
-                     (l2e_get_pfn(*pl2e) >= pte_update_limit) )
+                     !(l2e_get_flags(*pl2e) & _PAGE_PSE) )
                     continue;
 
                 *pl2e = l2e_from_intpte(l2e_get_intpte(*pl2e) + xen_phys_start);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:53:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240870.417637 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6g-0007sk-U5; Tue, 07 Dec 2021 10:53:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240870.417637; Tue, 07 Dec 2021 10:53:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6g-0007sc-Oi; Tue, 07 Dec 2021 10:53:58 +0000
Received: by outflank-mailman (input) for mailman id 240870;
 Tue, 07 Dec 2021 10:53:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WjKu=QY=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muY6f-0007ZY-Gr
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:53:57 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f840c68d-574b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:53:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f840c68d-574b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638874435;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=aUo9w7NMA0gJRwpoUWuXtmPLfdUrj41MF7NAi5apEPM=;
  b=GsExAMTQ4cNOQqKGMnzD5LLbSIYPrxzp3UFpU7jO/4evCmNvgfWGxakC
   KBXGbkC1D5zrA3YNF/UZqth5O5ynAA6+PnTKOEdW+fUsF/pZtACVtdxQT
   EznM01ej2YmsEum/HfzClkL5U3QCXkdQFNqREM4INhp7ZfmFcMIw4nVMd
   w=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: K5HH7TtBnxror/G2Vpmn5l+DQYHY+lld85s1mk+DyljgLRMN/Csta2bCssmH6EDZ1D5jprrY9D
 r8SKCVf0CHd7IDbWS3ewrDbnnaJjfLFOX3YA9WE9WyIUtegMUCviYNcwB4ZnLWZNkmheRkfodN
 lw9EWevD1Cg6h/pxYCEE4dCRBZitbXwDNMhQHmCQuY1zItZlB8vgiZT2TaC8s7/2UZeZpNyRyQ
 SxdMZGtzSvyTAbsS4b/sDO1h4SGfcgYmprfj+/Hsq+XcR8G1K/B95Hoh2KtpMqyzpAHtE5MtdU
 BLvDVB6x6zJIu3GKmJc2aRHr
X-SBRS: 5.1
X-MesageID: 59450633
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:An7c4qhLDtd61D3LX/aIGtBNX161WRcKZh0ujC45NGQN5FlHY01je
 htvXzuDa63fMWvxedxxa4++/UxVuZLRy4JnTgM+rSA3HyIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Qw3oDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1y6Y3udBgLZpHTmcsPdTh1OgheIKZZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauPO
 5dBN2E0BPjGS1pAfVolKspnpbiDr0n6Y2FV8l6rgKVitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRIDsXKdiewjqt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4LLErtjyS6PLo/Ae2FE4lYxdoSMEtq5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoStQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtQmzARVodt/xory9U
 J8swZf20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LsGEnehkxaJ5YJ1cFh
 XM/XisLu/du0IaCN/crM+pd9ex0pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pNgNcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4DbZbXkEsGD7WlCsQVmKZKRW03wbEALcieg6RqmiSre2KKwUktVK3cx60PYYtgk/gHn+vE5
 CjlCERZ1ED+lTvMLgDTMiJvb7bmXJBeq3MnPHNzYQb0iiZ7OYv/vr0Cc5YXfKU88LAxx/BDU
 PRYKd6LBe5CS2qb9m1FP4X9toFraD+imRmKY3i+eDE6cpM5H17J99bocxHB7i4LCibr58Iyr
 6f5jlHQQIYZRhQkB8HTMar9w1S0tHkbueRzQ0qXfYUDJBSyqNBncnWjgOU2LscALQT46gGbj
 wvGUw0FoeTtopMu9IWbj66zsIr0QfB1GVBXHjeH4O/uZzXa5Geq3aRJTP2MIWLGTGrx9aivO
 bdVwvX7PKFVlVpGqdMhQbNizKZ47Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xLd4MReNJWIJNjhQQwYKwcSZ+ie0e0Zx2vJ5vMvLUSmvCJ68dJri6mJ08VgXMCFEIZIDQ==
IronPort-HdrOrdr: A9a23:e/zODanN99YMCd+BDK2sanFgIwXpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59450633"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 2/3] x86/boot: Drop move_memory() and use memcpy() directly
Date: Tue, 7 Dec 2021 10:53:38 +0000
Message-ID: <20211207105339.28440-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211207105339.28440-1-andrew.cooper3@citrix.com>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

The way move_memory() sets up the virtual mappings means that there are always
two non-overlapping regions.  The virtual layout means that memmove()'s
forward/backwards check doesn't do what the caller intends, as the check ought
to be performed in physical space rather than virtual.

Luckily both callers already provide non-overlapping mappings, so this bug
doesn't manifest, and we can move to memcpy() to avoid a backwards copy.
Backwards rep movs's are typically far slower than forwards copies.

Furthermore, both callers already have suitable directmap mappings.  There is
no need to spend time managing early boot mappings, or chunking the copy
through them.

For the main Xen relocation, we can read out of the virtual mapping that we're
executing on, and write directly into the directmap.  In fact, this removes
one dependency on Xen being "at 0" (the XEN_IMG_OFFSET passed as src) for
relocation to occur.

For the module relocation, just transcribe the move_memory() call into an
equivalent memcpy().

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/setup.c | 58 +++++-----------------------------------------------
 1 file changed, 5 insertions(+), 53 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 0492856292cf..a6ff450daab7 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -413,53 +413,6 @@ void *__init bootstrap_map(const module_t *mod)
     return ret;
 }
 
-static void *__init move_memory(
-    uint64_t dst, uint64_t src, unsigned int size, bool keep)
-{
-    unsigned int blksz = BOOTSTRAP_MAP_LIMIT - BOOTSTRAP_MAP_BASE;
-    unsigned int mask = (1L << L2_PAGETABLE_SHIFT) - 1;
-
-    if ( src + size > BOOTSTRAP_MAP_BASE )
-        blksz >>= 1;
-
-    while ( size )
-    {
-        module_t mod;
-        unsigned int soffs = src & mask;
-        unsigned int doffs = dst & mask;
-        unsigned int sz;
-        void *d, *s;
-
-        mod.mod_start = (src - soffs) >> PAGE_SHIFT;
-        mod.mod_end = soffs + size;
-        if ( mod.mod_end > blksz )
-            mod.mod_end = blksz;
-        sz = mod.mod_end - soffs;
-        s = bootstrap_map(&mod);
-
-        mod.mod_start = (dst - doffs) >> PAGE_SHIFT;
-        mod.mod_end = doffs + size;
-        if ( mod.mod_end > blksz )
-            mod.mod_end = blksz;
-        if ( sz > mod.mod_end - doffs )
-            sz = mod.mod_end - doffs;
-        d = bootstrap_map(&mod);
-
-        memmove(d + doffs, s + soffs, sz);
-
-        dst += sz;
-        src += sz;
-        size -= sz;
-
-        if ( keep )
-            return size ? NULL : d + doffs;
-
-        bootstrap_map(NULL);
-    }
-
-    return NULL;
-}
-
 #undef BOOTSTRAP_MAP_LIMIT
 
 static uint64_t __init consider_modules(
@@ -1243,7 +1196,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
              * data until after we have switched to the relocated pagetables!
              */
             barrier();
-            move_memory(e, XEN_IMG_OFFSET, _end - _start, 1);
+            memcpy(__va(__pa(_start)), _start, _end - _start);
 
             /* Walk idle_pg_table, relocating non-leaf entries. */
             pl4e = __va(__pa(idle_pg_table));
@@ -1300,8 +1253,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                    "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
                 : "memory" );
 
-            bootstrap_map(NULL);
-
             printk("New Xen image base address: %#lx\n", xen_phys_start);
         }
 
@@ -1325,9 +1276,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                  (headroom ||
                   ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) )
             {
-                move_memory(end - size + headroom,
-                            (uint64_t)mod[j].mod_start << PAGE_SHIFT,
-                            mod[j].mod_end, 0);
+                memcpy(__va(end - size + headroom),
+                       __va((uint64_t)mod[j].mod_start << PAGE_SHIFT),
+                       mod[j].mod_end);
+
                 mod[j].mod_start = (end - size) >> PAGE_SHIFT;
                 mod[j].mod_end += headroom;
                 mod[j].reserved = 1;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:54:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:54:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240872.417648 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6j-0008CC-61; Tue, 07 Dec 2021 10:54:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240872.417648; Tue, 07 Dec 2021 10:54:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6j-0008C3-23; Tue, 07 Dec 2021 10:54:01 +0000
Received: by outflank-mailman (input) for mailman id 240872;
 Tue, 07 Dec 2021 10:53:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WjKu=QY=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muY6h-0007ZY-HQ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:53:59 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f8b108c2-574b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:53:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f8b108c2-574b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638874436;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=2byRJ1vQWOMoPBKyrlzx/lrkEkJCwOz+DlgEQq6J/jc=;
  b=VyV2f2N9ZLH9nNctUffWvH/P4cnXSQSPtrpjcmpqz/wXHB2M1AQtheKZ
   MlI9/67fGIj0jb/Yn9hxYMeGYS5YqvDrJlqKLWf1OUwAv76aXYXUYxojg
   hT5Q1xhe83lTSJi9bsksF3nAJPfcv9hCA/LT025gz5tqB+DQpEg0QhWpW
   E=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: SjgV+1EIXTndc5wwZDLnE1QXV7RMPz8J3QzqEXbhPEBvbmfP5ga4M225wi88AV1wP/wjGuP8Wt
 eyl/VU2t2ZsZjbqSHWoOlvg3jklu0fsui37M3R5ddEyNYl5YMndz+fZnpiXt8rbKrhamLxcKrx
 RLFnWdH4fhUkHp6jbex9mzR3vgBc5zOu/F/p2cVwC2VUDyx5gU0ZM1G6iG1kEIPciM0au5kTfW
 X/mARtkZn5nT0h8gS+vFTbwxuAbBlDIkxkGYLSu1aU2SmzcNL5tIVUaJKgiuDPsgYeLWoogJX2
 LN3iRT+sKOZfX21USCJICZoO
X-SBRS: 5.1
X-MesageID: 59384512
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Ao9nA6xoLk0Xwx50ZWB6t+cvwSrEfRIJ4+MujC+fZmUNrF6WrkVTx
 zEbWmmHMqmOYGCjc4t+b423pkwPuJXWy9drGgJprSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wbZm2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9l6w
 9F/lbrrcxUGF5zBwMA/SQh5Mj4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25EVTaqDP
 pBxhTxHMA3sMkFVYHAtVbUcp8Oyv0DaUz9GkQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCnoM/gcNtMTvvirKcs2QDNgDxIYPELabelifCygUqMe/QEE
 V470xsj9YwQ7l2Kb8aoCnVUv0W4lhIbXtNRFcgz5weM1rfY7m6lO4QUctJSQId47ZFrHFTGw
 nfMxoq0XmI37NV5XFrEru/MxQ5eLxT5OoPricUsaQIeq+fur4go5v4kZoYySfXl5jEZ9NyZ/
 txrkMTcr+lC5SLo///ilbwiv95LjsKWJjPZHi2NAgqYAvpRPeZJnbCA51nB9upnJ42EVFSHt
 3Vss5HAt7BeVM/TzHbVHLtl8FSVCxGtamK0vLKSN8N5q2TFF4CLI+i8Hw2S1G82a51ZKFcFk
 WfYuB9L5Y87AZdZRfQfXm5FMOxzlfKIPY28Dpj8N4MSCrAsJF7v1Hw/Pia4gjGy+HXAZIliY
 P93h+73Vi1EYUmmpRLrL9ogPUgDmnpjmDiNHM+jlHxKE9O2PRaodFvMC3PWBshR0U9OiFy9H
 w93O5TYxhNBfvf5ZyWLo4cfIUpTdSowBIzsqtwRfemGe1I0FGYkAv7X4LUgZ406wPgFyraWp
 imwCh1C1V7ypXzbMgHWOHptX6ziAMRkpnUhMC1yYVvxgyo/YZyi5bs0focseeV17/RqyPN5F
 qFXe8iJDvlVZC7A/jARMcv0oIB4LUz5jgOSJSu1JjM4esc4FQDO/9bleCrp9TUPUXXr5Zdv/
 eX421qCE5QZRglkAMLHU96Vzgu87SoHheZ/f0rUOd0PKk/ix5dndn7qhfgtLsBSdRianmmG1
 xybCAszrPXWp9Nn68HAgK2Jotv7E+Z6GUYGTWDX4azvaHvf92unh4RBTPyJbXbWU2atoPeuY
 uBczvfdNvwbnQkV79ogQugzla9utcHyo7J6zxh/GCSZZlumPbpsP32a0JQdraZK3LJY5VO7V
 0/nFgO24llV1BcJyGIsGTc=
IronPort-HdrOrdr: A9a23:HYnqxqnYixU1Awh4s6DFp54SyLnpDfIi3DAbv31ZSRFFG/Fxl6
 iV/cjzsiWE7gr5OUtQ/uxoV5PwIk80maQb3WBzB8bHYOCFghrLEGgK1+KLqFeMdxEWntQtrJ
 uIGJIfNDSfNzZHZL7BkWyFL+o=
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59384512"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/3] x86/boot: Cleanup
Date: Tue, 7 Dec 2021 10:53:36 +0000
Message-ID: <20211207105339.28440-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

More cleanup, following on from the __ro_after_init work.

Andrew Cooper (3):
  x86/boot: Drop pte_update_limit from physical relocation logic
  x86/boot: Drop move_memory() and use memcpy() directly
  x86/boot: Don't double-copy the stack during physical relocation

 xen/arch/x86/setup.c | 105 ++++++++++++---------------------------------------
 1 file changed, 25 insertions(+), 80 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:54:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:54:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240875.417659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6o-0000Bo-L2; Tue, 07 Dec 2021 10:54:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240875.417659; Tue, 07 Dec 2021 10:54:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY6o-0000B6-Gb; Tue, 07 Dec 2021 10:54:06 +0000
Received: by outflank-mailman (input) for mailman id 240875;
 Tue, 07 Dec 2021 10:54:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WjKu=QY=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1muY6n-0007ZY-IQ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:54:05 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd4fab96-574b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 11:54:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd4fab96-574b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638874444;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Fbig8ZrshkFGK596jPWQZGyoDDWpC3fZiJfWDk+IDGU=;
  b=KIcx92tjufdGfKmXRg09ye9cDaVbXR4t9euHnMx3Km4sUGIBh0rlgDdi
   adKEEK8etJZXxl9H9IkaLeSb1rqBSDpSUAEF98nM4H5zXE8J2Rstxc5/D
   NuE2ssFeTMEO2SO7epIeWoRAk8cJOD4d50owB4aJp8o5ApP1ZcS2KkX0R
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: OWEdGLEuOdn8Ms4IOSKYbFVQOki0Azv0nsLgY5gdxuAnngZ4mmE92Lj2m/dnqSkp6smVumcKEK
 /Uafh8pze9xYxI0w8wK6pG8Y1v0uoTmF6vM7iWTBATByQI6grGG4dYBaNZb8/d5EB3HAjVtgjD
 5kaauncSMaQi93aHjUhQda55xmhcz60GJfkKQLYi0oDLYDWhnbi/rFwQHy4tr6MvI3uYOXPHqK
 CqMTlBGFX8oYFJFyYIPfB3lqSl5VEwlKzhnaLTArd5D6TNmW+1aruXIxQCNYjXpOGEAGaY+4R6
 vF2Tsm/DV4MPjFqcPJTjOrpC
X-SBRS: 5.1
X-MesageID: 58948462
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:t2zT2qMjybxlMUfvrR2dkMFynXyQoLVcMsEvi/4bfWQNrUom0zcDx
 2YeDWqBaKmDMWf1ctglboS09BhU6JfSx9c1QQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En5400o8w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozGooPVIl
 uxEiYCtVV87PqOVxeEQdzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgWdh2pASQ6y2i
 8wxSQFfcxH6Oxt0JmgaNbRhlcOvpFWmWmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m66j
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlaAnyE5YoRpGtEm9R3V2KraulucC0wtG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNeZJhKTysDA3CMqsy67DETG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qW/9qyf9I9gKuG0gTKuMDirjUWW2C
 HI/RCsLvMMDVJdURfEfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDJrDwk1DXN8K1vFyRB2+YlmY
 M/zWZ/1UR4yVPQ2pBLrFrx1+eJ6mUgDKZb7GMmTI+KPiuHFOhZ4iN4tbTOzUwzOxP/e/ViOr
 Y8Ab5DiJtc2eLSWXxQ7OLU7dTgiRUXXz7iv8aS7r8aPfVhrHn8PEfjUze9zcoBphf0NxOzJ4
 mu8SglTz1+m3S/LLgCDa3ZCbrLzXMkg8SJnbHJ0ZVv4iWI+ZYuP7bsEc8dld7cQ6+E+n+V/S
 OMIepvcD60XGCjH4TkUcbL0sJdmKEawnQuLMif8OGo/cpdsShbn4NjhegezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeIRy+/pJrJir9iu4MD/sNcRiTlCGH0
 wu2AAsDobWfqYEC79SU17uPqJ2kErUiExMCTXXb97u/KQLT4nGnnd1bSO+NcD3QCDH09aGla
 bkHxv3wKqRazlNDso46GLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeaOeAN87SGVIMIBYoM7aY3vYOlziOtfk4LS0WPsOsEGZrhamKAySxtQ==
IronPort-HdrOrdr: A9a23:54NIH6rPXRN33PNiKsPkMKQaV5oTeYIsimQD101hICG8cqSj+f
 xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM
 NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="58948462"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 3/3] x86/boot: Don't double-copy the stack during physical relocation
Date: Tue, 7 Dec 2021 10:53:39 +0000
Message-ID: <20211207105339.28440-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211207105339.28440-1-andrew.cooper3@citrix.com>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

cpu0_stack is contained within .data, which means the memcpy() already takes a
snapshot at the start of the critical region.

Later, when we switch to the relocated Xen, we do end up losing updates to the
local variables, but that's fine because the only variables we've modified go
out of scope after the printk().  Use this properly to avoid copying the whole
stack (32k) a second time.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

Ever so slightly RFC, as it has only had light testing, but I'm confident in
the reasoning.
---
 xen/arch/x86/setup.c | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index a6ff450daab7..c04c68a09b47 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1183,6 +1183,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
             l3_pgentry_t *pl3e;
             l2_pgentry_t *pl2e;
             int i, j, k;
+            unsigned long tmp;
 
             /* Select relocation address. */
             xen_phys_start = end - reloc_size;
@@ -1193,7 +1194,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
              * Perform relocation to new physical address.
              * Before doing so we must sync static/global data with main memory
              * with a barrier(). After this we must *not* modify static/global
-             * data until after we have switched to the relocated pagetables!
+             * data, or locals that need to survive, until after we have
+             * switched to the relocated pagetables!
              */
             barrier();
             memcpy(__va(__pa(_start)), _start, _end - _start);
@@ -1239,18 +1241,21 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                 *pl2e = l2e_from_intpte(l2e_get_intpte(*pl2e) + xen_phys_start);
             }
 
-            /* Re-sync the stack and then switch to relocated pagetables. */
+            /*
+             * Switch to relocated pagetables.  This also discards updates to
+             * any local variables since the memmove() call above, but that's
+             * fine because we don't use any of them again.
+             */
             asm volatile (
-                "rep movsq        ; " /* re-sync the stack */
-                "movq %%cr4,%%rsi ; "
-                "andb $0x7f,%%sil ; "
-                "movq %%rsi,%%cr4 ; " /* CR4.PGE == 0 */
-                "movq %[pg],%%cr3 ; " /* CR3 == new pagetables */
-                "orb $0x80,%%sil  ; "
-                "movq %%rsi,%%cr4   " /* CR4.PGE == 1 */
-                : "=&S" (i), "=&D" (i), "=&c" (i) /* All outputs discarded. */
-                :  [pg] "r" (__pa(idle_pg_table)), "0" (cpu0_stack),
-                   "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
+                "mov    %%cr4, %[cr4]\n\t"
+                "andb   $~%c[pge], %b[cr4]\n\t"
+                "mov    %[cr4], %%cr4\n\t"     /* CR4.PGE = 0 */
+                "mov    %[cr3], %%cr3\n\t"     /* CR3 = new pagetables */
+                "orb    $%c[pge], %b[cr4]\n\t"
+                "mov    %[cr4], %%cr4\n\t"     /* CR4.PGE = 1 */
+                : [cr4] "=&a" (tmp) /* Could be "r", but "a" makes better asm */
+                : [cr3] "r" (__pa(idle_pg_table)),
+                  [pge] "i" (X86_CR4_PGE)
                 : "memory" );
 
             printk("New Xen image base address: %#lx\n", xen_phys_start);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 10:57:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 10:57:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240895.417669 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY9Y-00020Z-5h; Tue, 07 Dec 2021 10:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240895.417669; Tue, 07 Dec 2021 10:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muY9Y-0001zq-2Z; Tue, 07 Dec 2021 10:56:56 +0000
Received: by outflank-mailman (input) for mailman id 240895;
 Tue, 07 Dec 2021 10:56:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muY7R-00078Z-HJ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 10:54:45 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 164150ec-574c-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 11:54:44 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id AB92E1FD2F;
 Tue,  7 Dec 2021 10:54:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8475513A42;
 Tue,  7 Dec 2021 10:54:44 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Ly8hH3Q9r2GvfAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 10:54:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 164150ec-574c-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638874484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UakNnKF1HSU69BP9LNPjtG6WwED6J8HWrlBYx3uHlPc=;
	b=ccwX2jkocsy08zpLpnmZlobyBdJdYR38QIi/oW680c6OmFEjCWpf5EhEXNaeVoCl+FUl5L
	qBw8fnVs37mIcOswXhSLPFu5YDPgb3H/DOQ5Eu4nlwkBLgkEs3UFIJappN6OzSF9SHuq+r
	fx6pm6LPzRuyQVrj2aGfC+nBQFcH+Qk=
Subject: Re: [XEN PATCH 20/57] tools/Rules.mk: introduce FORCE target
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-21-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <227c5233-b08c-e044-d01a-963ed66f64d7@suse.com>
Date: Tue, 7 Dec 2021 11:54:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-21-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="TthqW0v7lSweTtokZg9qJv0y9fK1qztmd"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--TthqW0v7lSweTtokZg9qJv0y9fK1qztmd
Content-Type: multipart/mixed; boundary="20ijPQX7hzQBuCELIBPJy5VcClrENRNvC";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <227c5233-b08c-e044-d01a-963ed66f64d7@suse.com>
Subject: Re: [XEN PATCH 20/57] tools/Rules.mk: introduce FORCE target
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-21-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-21-anthony.perard@citrix.com>

--20ijPQX7hzQBuCELIBPJy5VcClrENRNvC
Content-Type: multipart/mixed;
 boundary="------------0D9253E91D792674F7DCD6C7"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------0D9253E91D792674F7DCD6C7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> And replace the one defined in libs.mk.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------0D9253E91D792674F7DCD6C7
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0D9253E91D792674F7DCD6C7--

--20ijPQX7hzQBuCELIBPJy5VcClrENRNvC--

--TthqW0v7lSweTtokZg9qJv0y9fK1qztmd
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvPXQFAwAAAAAACgkQsN6d1ii/Ey8t
TQf+I0boPe2pyky2ZbzPPOyuApRUfukErQSLdkwX6xcoSSrywED6B4yyxm9VaLma7oO/o1zEhnGT
IXHBar5P1DnoILP5kwyuP6T616md4b816ox1VR2ZFpDWJKgDuY5REJgoZPH8LnM+Ce5gXTXH9veU
JK6vtNBw9LAtrUtCuW6yjF2gj+4hbxdyulUl7s+PgD1xFY8Yz1bGDch0+y3aDWY/P0EHl4KI75V+
o+voYi0jlLyXoVF3Zm+7AWCHKQ46aVXqUMbmEKOFePg2iTgIkdjicUQ6eZfyv/SPhKyjtTdKXc1N
kHi8MnhPR1xzHvADXs0M73pkJGinLXYpBGRryo+b2A==
=On9n
-----END PGP SIGNATURE-----

--TthqW0v7lSweTtokZg9qJv0y9fK1qztmd--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:05:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:05:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240909.417681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYHU-0003pz-Vl; Tue, 07 Dec 2021 11:05:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240909.417681; Tue, 07 Dec 2021 11:05:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYHU-0003ps-SY; Tue, 07 Dec 2021 11:05:08 +0000
Received: by outflank-mailman (input) for mailman id 240909;
 Tue, 07 Dec 2021 11:05:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sjJF=QY=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muYHT-0003pm-Om
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:05:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87ef0376-574d-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 12:05:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87ef0376-574d-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638875106;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=qnuwmZ0s2+L6Oqn1GJpILqnTqNt4yFWd7OprzsuOPZk=;
  b=XxhoatsbKGkfRwyboNgy+sq4Hzi1wOKynjzFxYsPm86T5pFqLk8hWV1q
   N1duZzP8rTSGFALzeI/xliIQmDeQ7g3BWITXOucEBItGjU/LfcpFjzhZ+
   05NZRDAiPaA+APxRh2yFCJJNtB5y0/CDTd/xMt7mhf+jXpQiBmZ9zAVIZ
   0=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 1BLCXziVWLQjptncfCrmG8Ap6QA6iOTMEtR52BxMX0J8myMhoZz2zMtPcevgSQcfqLLnFzXeWi
 U/E0S41rQzbXZNYpyekPr7OS/+Usk7wsWp8RTnkRirpai6WZBb3DwkcacF7Lq+r0+uTry9hoDp
 m+dJOBOTZii/bu16vtu93mUyymByVJXpHcJGwQDGnE7zNxx4GyixRSqCrxbwPNxFuukBRo2ZTR
 1r6+mVmjlasMC4Alld1P2Jp4deLGBzbsgoKLkAI3JF4nPGTODx6Z/nYfnNTerAeR5bPeuEtZIE
 5NU/iF4E+fIH2ripOzr5zMP+
X-SBRS: 5.1
X-MesageID: 59451336
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:j3qLyq7njwAl1Rqwf9JlGAxRtAHAchMFZxGqfqrLsTDasY5as4F+v
 mBOXjjSPPyOY2P8f9giYITkoUgPvcOEnd8xSgJkpC5hHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdj2tEw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 NlMt7KrcFoQDILzx+gwQhZqOTx4IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gTTKqDP
 pFCN1KDajzrehN3BlUlFKszxue3nXbTdzlX+HWK8P9fD2/7k1UqjemF3MDuUsyHQ4BZk1iVo
 krC/n/lGVcKOdqH0z2H/3mwwOjVkkvTR4Y6BLC+sPlwjzW7xGYeFRkXXluTuuSihwi1XNc3F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc95cEu8U8zjQ85j73FmVK3kLfBRcbsNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbs1oWtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtAAuW8gfB0xbphsldrVj
 Kj741w52XOuFCHyMf8fj3yZVazGMpQM5fy6D6uJP7Kik7B6dROd/TEGWKJj9zuFraTYqolmY
 c3zWZ/1VR4yUP07pBLrF7Z1+eJ6nUgWmDKMLa0XOjz6iNJyklbOEuxbWLZPB8hkhJ65TPL9r
 4wCapDUkkoHC4UToED/qOYuELzDFlBjbbieliCdXrfrztNOFD5zBvnP76kmfoA5za1Zmv2Rp
 iO2W1NCyUq5jnrCcF3YZndmYbLpfJB+sXNkYnB8YQf2gyAuMdS18aMSV5orZr17puZt+uF5E
 qsecMKaD/URFjmeo2YBbYPwpZBJfQiwgV7cJDKsZTUyJsYyRwHA9tL+UBHo8S0CUni+ucck+
 uXy3QLHW5sTAQ9lCZ+OOv6oylqwu1kbmf5zABSUcoUCJh20/dEzeSLrj/IxL8UdEjn5x2OXh
 1SMHBMVhejRuItpotPHsr+J8tWyGOxkE0sEQ2SCteSqNTPX93aIyJNbVLraZijUUW759fnwZ
 ehRyP2gYvQLkEwT7th5Grdvi6k/+8Hut/lRyQE9RCfHaFGiC7VBJHia3JYQ6v0Rl+EB4QbmC
 FiS/tR6OKmSPJK3GVEcEwMpc+Cf2KxGgTLV9/k0fB336SIfEGBriqmO081gUBBgEYY=
IronPort-HdrOrdr: A9a23:03RmA6HD+H9yqixlpLqEi8eALOsnbusQ8zAXPiFKKSC9F/byqy
 nAppkmPHPP4gr5O0tApTn/Asa9qBrnnPZICOIqUYtKMjOJhFeV
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59451336"
Date: Tue, 7 Dec 2021 11:04:56 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 04/47] build: set XEN_BUILD_EFI earlier
Message-ID: <Ya8/2Dc5yEp/ovf/@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-5-anthony.perard@citrix.com>
 <2bffd73c-ce1b-40cf-73b7-f988e69c4f07@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2bffd73c-ce1b-40cf-73b7-f988e69c4f07@suse.com>

On Thu, Dec 02, 2021 at 03:06:54PM +0100, Jan Beulich wrote:
> On 25.11.2021 14:39, Anthony PERARD wrote:
> > +efi-check-o := arch/x86/efi/check.o
> 
> How about making this
> 
> efi-check := arch/x86/efi/check
> 
> That way you wouldn't need to replace the extension in a number of places,
> but simply append the respective one in every place using this.

This change sound fine. I guess it will make reading the code a bit
easier.

> > +export XEN_BUILD_EFI XEN_BUILD_PE MKRELOC
> > +export EFI_LDFLAGS
> > +endif
> 
> Exporting MKRELOC in particular isn't very nice. I wonder whether there
> wouldn't be a way to keep it local to xen/Makefile.

I don't think that's possible. The value of MKRELOC depends on a call
with OBJDUMP which depends on call with LD which depends on a call with
CC. And the call with CC is the one I'm trying to move.

Unless there is a better way to build *.efi, we need to know whether to
use `mkreloc` or not.

I could rename it XEN_MKRELOC. Or if there is another name that could
make sense, that would be fine too, like XEN_BUILD_EFI_NEED_RELOC which
could be a boolean.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:09:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:09:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240918.417691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYLp-00057m-HL; Tue, 07 Dec 2021 11:09:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240918.417691; Tue, 07 Dec 2021 11:09:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYLp-00057f-EH; Tue, 07 Dec 2021 11:09:37 +0000
Received: by outflank-mailman (input) for mailman id 240918;
 Tue, 07 Dec 2021 11:09:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=XoCv=QY=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1muYLn-00057J-Im
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:09:35 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::628])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2837c193-574e-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 12:09:34 +0100 (CET)
Received: from AM6PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:6e::23)
 by AM0PR08MB3249.eurprd08.prod.outlook.com (2603:10a6:208:5d::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Tue, 7 Dec
 2021 11:09:32 +0000
Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:6e:cafe::d9) by AM6PR02CA0010.outlook.office365.com
 (2603:10a6:20b:6e::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend
 Transport; Tue, 7 Dec 2021 11:09:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Tue, 7 Dec 2021 11:09:31 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Tue, 07 Dec 2021 11:09:30 +0000
Received: from ca3d5c1756bb.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 513755DB-74CB-47B6-B770-ED7ACB67EB65.1; 
 Tue, 07 Dec 2021 11:09:24 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca3d5c1756bb.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 07 Dec 2021 11:09:24 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3527.eurprd08.prod.outlook.com (2603:10a6:20b:41::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 11:09:21 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 11:09:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2837c193-574e-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o5W4jhjXE0pUfFxe3bFaW6DhQ/KFCgOnVkFN6av+2vo=;
 b=mXNk5DBwNwYeFOXC0NUAH7NcZoanN3Bjx4AblVmEVNOloYNpeQ5Lgo0iaa7gZkQKHyLlJEcgfXdIGf19fX4QCrtM5dzsV/yIBcSj4o6wScK1BeciJAliY3K8KpShBfZwyaM+4VWU+TB+0F7ZUZsAQGuFHS3cVKMCb4GSLCilmiA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: aadd79e56fcfc2d5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kf90PygAarGevg9PmQUAFTw96wmhQQE8Nw0mcIbQOiZ9oCa2y/FFHJBe4yzvHXab/8H91eAbMJtquZUHuiOm2yHe7YTlUJRMQTiRdyefw7GP/dFRCYiggrEAxijcOnjz9qaZRdKWIMbKR3BMPGXnbmn4DBKQeVdfRu9R0uX7ygz9VOA8sYVOrtVavhzC/0aKtjXrd0dRvY2Yrd8i+1F6TjkyEbp08Bxy4VPVV1VzR27vplhTrcvjve6K0Oxyk3bpRLrI1qXgFayR0Ws1e7lgOEo4fsO1eEzVXaU2/dV/5289b1I1riRwuoYpqSqtMB6ZuZfu+XeqzN6y3ibLX0kLBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o5W4jhjXE0pUfFxe3bFaW6DhQ/KFCgOnVkFN6av+2vo=;
 b=ZDv5wf7TuzUzYD0ScykN54PDW9n9vauMO3myLkTsoLRNDDUaITYoAHaMmMb6EUAWf5knSpR+uQ//FNGM7lwBF5eKN/MzaPqVtV+hDjfX2oS5KZMCsNj2oUH1harnCSUuO5F6Lj7tkYN7Kggs86utMtoR4CF9ghieHnkQzPCOAXfAear6+b3WOIK2ooRCkXNPt91vLoPqiuB2Eng2KE+w3HZQc2TwNFrMbk+Jehdz3pbjdWQ4WtUBD2A6+fKJRkXD9B22LZ+d5JEkuUPJ/H2WQcNcO77Yj7XYhxmgJA7Rjyw3HEoy+W4gInAyTTTN++b+35ntGl/G9xq44BNLDg9gMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o5W4jhjXE0pUfFxe3bFaW6DhQ/KFCgOnVkFN6av+2vo=;
 b=mXNk5DBwNwYeFOXC0NUAH7NcZoanN3Bjx4AblVmEVNOloYNpeQ5Lgo0iaa7gZkQKHyLlJEcgfXdIGf19fX4QCrtM5dzsV/yIBcSj4o6wScK1BeciJAliY3K8KpShBfZwyaM+4VWU+TB+0F7ZUZsAQGuFHS3cVKMCb4GSLCilmiA=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Luca Fancellu <Luca.Fancellu@arm.com>
CC: Julien Grall <julien@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>,
	Wei Chen <Wei.Chen@arm.com>, Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
Thread-Topic: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
Thread-Index: AQHX6rc42wI+YjLuYkGkEA4OiS5od6wlsWWAgAEqHQCAAATSgA==
Date: Tue, 7 Dec 2021 11:09:20 +0000
Message-ID: <A6E7CDAA-E4AD-4AC3-8745-216FDC4DD8BF@arm.com>
References: <20211206153730.49791-1-luca.fancellu@arm.com>
 <f439d5c4-aa6c-4066-3941-e497b67aeae1@xen.org>
 <C96E90F4-611E-4765-9627-EDE75A952E10@arm.com>
In-Reply-To: <C96E90F4-611E-4765-9627-EDE75A952E10@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 6ef98d4d-75e7-43a7-f1ea-08d9b9720b24
x-ms-traffictypediagnostic:
	AM6PR08MB3527:EE_|VE1EUR03FT017:EE_|AM0PR08MB3249:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3249D6642CDE75008EE793FB9D6E9@AM0PR08MB3249.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 hDBJ1w+deii3ozY1ERnBGl6MtH18Jwtt99tvimLgPnu5B4aHHAZdX2FsAvHm0Uk1I1Cpt7g5LNnk7eg4CHsIxjGsL9PTrdXNFJQVuUj/Zl//KqTFKcrpsiTU47d5r8hkMPJv8msRsoqzR7npjsWlx/EqGAvhljK2z9FK6shuDUewpwRCIYBe8dmuUoYiY/tazQNiFs+aG0rz4bgCjRZUodIRSpSpD4NSY1Qm0gVOEXLnag5rodCtHVQG9AQ/ZEIasGxAwT4ydDmZRHa5OMTTcfN6kkqQoUw6quT2miYdeqzz975h8LH/1nQPiYmsQebNqABmINUU9KxbmNE0pkHw2LmEEz9jqUHyr25cbCOn8wOI+iJYoc6vjQer7K1x8uR3+EGDLafH+6bypS2d/YLyGsU/GgfsV3wAfcCY/UQC65xrDnblMB0+3bapehsJFsQXtmn4tsIXZ5yMcQRWA8vMy1jtKf0WnV50/zP6kRT2YkVEZAAsJEbC9OY6PMj7OBQT+X3DAbTcH/UH1v4MwnmCdifondHBX93CqCAC7e371hiiAn2J+T4sXXx0yLXTo1Y4DSwgD1vkN89+BiSE4QVn30aoKDOhmDe7mbIwDWMjbAqDkzb5/fOpl5J/HWf3bcc4dUF/wtMfnctFqkLcNan1wGwmqQlPXYqlQSTJoCpfRPpGffWBpHN3yXouCSP+D4GA4BW3YF+FGr2Gh3HcPQ7jyienG9M4T8kit+cIg6Bng/r9K7OAST+Q/WSmax2b6Tmk
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(8936002)(8676002)(71200400001)(37006003)(38100700002)(4326008)(6486002)(54906003)(15650500001)(6862004)(122000001)(6512007)(33656002)(76116006)(316002)(91956017)(66556008)(508600001)(66446008)(36756003)(66946007)(38070700005)(6506007)(66476007)(64756008)(186003)(2616005)(53546011)(26005)(6636002)(83380400001)(5660300002)(86362001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <34D17E8596C36D48A1755BB8CF11B3CE@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3527
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6f884785-88b9-4d18-4fb2-08d9b97204f2
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AqK+dt4+0+znISaKGKeYw7/7fiLFLocjqThd7YZ9+iWKNLCpdHdceko/Wj3KgzPEarF6vSmehvqs2Rx0WXgmki8UvxNOxzE/Pc4aurEqTRjIo5OWiZRpPDNPF+mdbN0zO3qhbihohAyXgXP2Ay8YytIYWt2mtboUdzVsD0JVuIrP5MKeIyTayQ8bK6VY9+TeKVKbcv9ggYhfMEqUDRldgjdRUfn+qiL9aXkEmaYYATrabPdrl2vzHTaejeNtzkGvR25rL1dUyvZ7HX0ait+6tzoycw/65+0Uk9/Z0hkQXO+ieTMz/nncS/pgxlxi6rxdvlMxkn605z4LpEz1yg82432I860bkaaM7NekQuxyPPZnOFPHrxAA8QolROKfaa7CR6MKoWZtt7uaBOCn5uWV0Dv8WghfoKOK32GMRjH04Jlqch6uLgGb6/StBNY1DJInB30IBqR4ZenSUaaa3rNKM0QmPWzkeUgS76Lhy+2e4WOZxnET6zxKrY5/AhwyW6hTk/fr25ceOWgi11XjaXVv186m42SkOL8fJj2/n6kD3KQ7pRpcGYzKUFb5NgqTiRTw51BH2EMgISqoq2p4rv/7EK7DQYELnk5PwizpEwD5Las/sZU4BzwtXNQtkJ5iga2MdOp9iyjkKG+8pPJmud1z1xhDKtjXskKbLj2kDygreZZpsASusjgMiftoV77vieMEddqEwN9n9/olxUo71EAhwQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36860700001)(2616005)(86362001)(8936002)(336012)(6636002)(186003)(6506007)(5660300002)(6862004)(356005)(107886003)(82310400004)(81166007)(4326008)(83380400001)(53546011)(6486002)(8676002)(15650500001)(37006003)(2906002)(70586007)(33656002)(316002)(26005)(508600001)(54906003)(47076005)(70206006)(6512007)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:09:31.2610
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ef98d4d-75e7-43a7-f1ea-08d9b9720b24
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3249

SGksDQoNCj4gT24gNyBEZWMgMjAyMSwgYXQgMTA6NTIsIEx1Y2EgRmFuY2VsbHUgPEx1Y2EuRmFu
Y2VsbHVAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiA2IERlYyAyMDIxLCBhdCAx
NzowNSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+PiANCj4+IEhpIEx1
Y2EsDQo+PiANCj4+IE9uIDA2LzEyLzIwMjEgMTU6MzcsIEx1Y2EgRmFuY2VsbHUgd3JvdGU6DQo+
Pj4gQ3VycmVudGx5IHRoZSBtYXhpbXVtIG51bWJlciBvZiBtZW1vcnkgYmFua3MgaXMgZml4ZWQg
dG8NCj4+PiAxMjgsIGJ1dCBvbiBzb21lIG5ldyBwbGF0Zm9ybXMgdGhhdCBoYXZlIGEgbGFyZ2Ug
YW1vdW50DQo+Pj4gb2YgbWVtb3J5LCB0aGlzIHZhbHVlIGlzIG5vdCBlbm91Z2ggDQo+PiANCj4g
DQo+IEhpIEp1bGllbiwNCj4gDQo+PiBDYW4geW91IHByb3ZpZGUgc29tZSBpbmZvcm1hdGlvbiBv
biB0aGUgc2V0dXA/IElzIGl0IHVzaW5nIFVFRkk/DQo+IA0KPiBZZXMgaXQgaXMgYSBwbGF0Zm9y
bSB3aXRoIDMyZ2Igb2YgcmFtLCBJ4oCZdmUgYnVpbHQgWGVuIHdpdGggQUNQSSBzdXBwb3J0IGFu
ZCBpdOKAmXMgc3RhcnRpbmcgdXNpbmcgVUVGSStBQ1BJLg0KPiANCj4+IA0KPj4+IGFuZCBwcmV2
ZW50cyBYZW4NCj4+PiBmcm9tIGJvb3RpbmcuDQo+PiANCj4+IEFGQUlLLCB0aGUgcmVzdHJpY3Rp
b24gc2hvdWxkIG9ubHkgcHJldmVudCBYZW4gdG8gdXNlIGFsbCB0aGUgbWVtb3J5LiBJZiB0aGF0
J3Mgbm90IHRoZSBjYXNlLCB0aGVuIHRoaXMgc2hvdWxkIGJlIGZpeGVkLg0KPiANCj4gVGhlIGNv
ZGUgdGhhdCBpdOKAmXMgZmFpbGluZyBpcyB0aGlzLCBpbnNpZGUgZWZpX3Byb2Nlc3NfbWVtb3J5
X21hcF9ib290aW5mbyjigKYpIGluIHRoZSBhcmNoL2FybS9lZmkvZWZpLWJvb3QuaDoNCj4gDQo+
ICNpZmRlZiBDT05GSUdfQUNQSQ0KPiAgICAgICAgZWxzZSBpZiAoIGRlc2NfcHRyLT5UeXBlID09
IEVmaUFDUElSZWNsYWltTWVtb3J5ICkNCj4gICAgICAgIHsNCj4gICAgICAgICAgICBpZiAoICFt
ZW1pbmZvX2FkZF9iYW5rKCZib290aW5mby5hY3BpLCBkZXNjX3B0cikgKQ0KPiAgICAgICAgICAg
IHsNCj4gICAgICAgICAgICAgICAgUHJpbnRTdHIoTCJFcnJvcjogQWxsICIgX19zdHJpbmdpZnko
TlJfTUVNX0JBTktTKQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIiBhY3BpIG1lbWluZm8g
bWVtIGJhbmtzIGV4aGF1c3RlZC5cclxuIik7DQo+ICAgICAgICAgICAgICAgIHJldHVybiBFRklf
TE9BRF9FUlJPUjsNCj4gICAgICAgICAgICB9DQo+ICAgICAgICB9DQo+ICNlbmRpZg0KPiANCj4+
IA0KPj4+IENyZWF0ZSBhIEtjb25maWcgcGFyYW1ldGVyIHRvIHNldCB0aGUgdmFsdWUsIGJ5IGRl
ZmF1bHQNCj4+PiAxMjguDQo+PiANCj4+IEkgdGhpbmsgWGVuIHNob3VsZCBiZSBhYmxlIHRvIGJv
b3Qgb24gYW55IHBsYXRmb3JtIHdpdGggdGhlIGRlZmF1bHQgY29uZmlndXJhdGlvbi4gU28gdGhl
IHZhbHVlIHNob3VsZCBhdCBsZWFzdCBiZSBidW1wZWQuDQo+PiANCj4+PiBTaWduZWQtb2ZmLWJ5
OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQo+Pj4gLS0tDQo+Pj4geGVu
L2FyY2gvYXJtL0tjb25maWcgICAgICAgIHwgOCArKysrKysrKw0KPj4+IHhlbi9pbmNsdWRlL2Fz
bS1hcm0vc2V0dXAuaCB8IDIgKy0NCj4+PiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr
KSwgMSBkZWxldGlvbigtKQ0KPj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBi
L3hlbi9hcmNoL2FybS9LY29uZmlnDQo+Pj4gaW5kZXggZWNmYTY4MjJlNGQzLi44MDVlM2M0MTdl
ODkgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL0tjb25maWcNCj4+PiArKysgYi94ZW4v
YXJjaC9hcm0vS2NvbmZpZw0KPj4+IEBAIC0yNSw2ICsyNSwxNCBAQCBtZW51ICJBcmNoaXRlY3R1
cmUgRmVhdHVyZXMiDQo+Pj4gICBzb3VyY2UgImFyY2gvS2NvbmZpZyINCj4+PiArY29uZmlnIE1F
TV9CQU5LUw0KPj4+ICsJaW50ICJNYXhpbXVtIG51bWJlciBvZiBtZW1vcnkgYmFua3MuIg0KPj4+
ICsJZGVmYXVsdCAiMTI4Ig0KPj4+ICsJaGVscA0KPj4+ICsJICBDb250cm9scyB0aGUgYnVpbGQt
dGltZSBzaXplIG1lbW9yeSBiYW5rIGFycmF5Lg0KPj4+ICsJICBJdCBpcyB0aGUgdXBwZXIgYm91
bmQgb2YgdGhlIG51bWJlciBvZiBsb2dpY2FsIGVudGl0aWVzIGRlc2NyaWJpbmcNCj4+PiArCSAg
dGhlIG1lbW9yeS4NCj4+IA0KPj4gTlJfTUVNX0JBTktTIGlzIGdvaW5nIHRvIGJlIHVzZWQgYnkg
bXVsdGlwbGUgaW50ZXJuYWwgc3RydWN0dXJlIGluIFhlbiAoZS5nLiBzdGF0aWMgbWVtb3J5LCBy
ZXNlcnZlZCBtZW1vcnksIG5vcm1hbCBtZW1vcnkpLiBTbyBob3cgY291bGQgYW4gYWRtaW4gZGVj
aWRlIHRoZSBjb3JyZWN0IHZhbHVlPw0KPj4gDQo+PiBJbiBwYXJ0aWN1bGFyIGZvciBVRUZJLCB3
ZSBhcmUgYXQgdGhlIG1lcmN5IG9mIHRoZSBmaXJtd2FyZSB0aGF0IGNhbiBleHBvc2UgYW55IGtp
bmQgb2YgbWVtb3J5IG1hcCAodGhhdCdzIHdoeSB3ZSBoYWQgdG8gaW5jcmVhc2UgdGhlIG9yaWdp
bmFsIG51bWJlciBvZiBiYW5rcykuDQo+PiANCj4+IFNvIG1heWJlIGl0IGlzIHRpbWUgZm9yIHVz
IHRvIG1vdmUgb3V0IGZyb20gYSBzdGF0aWMgYXJyYXkgYW5kIHJlLXRoaW5rIGhvdyB3ZSBkaXNj
b3ZlciB0aGUgbWVtb3J5Lg0KPj4gDQo+PiBUaGF0IHRoaXMgaXMgcHJvYmFibHkgZ29pbmcgdG8g
dGFrZSBzb21lIHRpbWUgdG8gZ2V0IGl0IHByb3Blcmx5LCBzbw0KPj4gSSB3b3VsZCBiZSBPSyB3
aXRoIGJ1bXBpbmcgdGhlIHZhbHVlICsgYSBjb25maWcgZ2F0ZWQgVU5TVVBQT1JURUQuDQoNCg0K
TG9va2luZyBhdCB3aGF0IHdlIGhhdmUsIHRoZSBtZW1vcnkgaXMgYWN0dWFsbHkgZnJhZ21lbnRl
ZCBieSBBQ1BJIGJ1dCBhIGxvbmcgdGVybSBzb2x1dGlvbiBjb3VsZCBiZSB0byBtYWtlIHRoZSBj
b2RlIGEgbGl0dGxlIGJpdCBtb3JlIHNtYXJ0IGFuZCB0cnkgdG8gbWVyZ2UgdG9nZXRoZXIgYWRq
YWNlbnQgYmFua3MuDQoNCkkgd291bGQgc3VnZ2VzdCB0byBqdXN0IGluY3JlYXNlIHRoZSBleGlz
dGluZyBkZWZpbmUgdG8gMjU2IHRvIGZpeCB0aGUgY3VycmVudCBpc3N1ZSAod2hpY2ggbWlnaHQg
YmUgZW5jb3VudGVyZWQgYnkgYW55Ym9keSB1c2luZyBBQ1BJKSBhbmQgcHV0IGEgY29tbWVudCBp
biB0aGUgY29kZSBmb3Igbm93IHdpdGggYSBUT0RPIGV4cGxhaW5pbmcgd2h5IHdlIGN1cnJlbnRs
eSBuZWVkIHN1Y2ggYSBoaWdoIHZhbHVlIGFuZCB3aGF0IHNob3VsZCBiZSBkb25lIHRvIGZpeCB0
aGlzLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCg0KPiANCj4gSSBjYW4gZG8gdGhhdC4NCj4gDQo+
IENoZWVycywNCj4gTHVjYQ0KPiANCj4+IA0KPj4+ICsNCj4+PiBjb25maWcgQUNQSQ0KPj4+IAli
b29sICJBQ1BJIChBZHZhbmNlZCBDb25maWd1cmF0aW9uIGFuZCBQb3dlciBJbnRlcmZhY2UpIFN1
cHBvcnQgKFVOU1VQUE9SVEVEKSIgaWYgVU5TVVBQT1JURUQNCj4+PiAJZGVwZW5kcyBvbiBBUk1f
NjQNCj4+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oIGIveGVuL2lu
Y2x1ZGUvYXNtLWFybS9zZXR1cC5oDQo+Pj4gaW5kZXggOTVkYTBiN2FiOWNkLi43ODVhOGZlODE0
NTAgMTAwNjQ0DQo+Pj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oDQo+Pj4gKysr
IGIveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oDQo+Pj4gQEAgLTYsNyArNiw3IEBADQo+Pj4g
I2RlZmluZSBNSU5fRkRUX0FMSUdOIDgNCj4+PiAjZGVmaW5lIE1BWF9GRFRfU0laRSBTWl8yTQ0K
Pj4+IC0jZGVmaW5lIE5SX01FTV9CQU5LUyAxMjgNCj4+PiArI2RlZmluZSBOUl9NRU1fQkFOS1Mg
Q09ORklHX01FTV9CQU5LUw0KPj4+ICAgI2RlZmluZSBNQVhfTU9EVUxFUyAzMiAvKiBDdXJyZW50
IG1heGltdW0gdXNlZnVsIG1vZHVsZXMgKi8NCj4+PiANCj4+IA0KPj4gQ2hlZXJzLA0KPj4gDQo+
PiAtLSANCj4+IEp1bGllbiBHcmFsbA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:10:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:10:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240923.417702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYMt-0006Uf-0t; Tue, 07 Dec 2021 11:10:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240923.417702; Tue, 07 Dec 2021 11:10:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYMs-0006UY-U3; Tue, 07 Dec 2021 11:10:42 +0000
Received: by outflank-mailman (input) for mailman id 240923;
 Tue, 07 Dec 2021 11:10:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muYMs-0006UR-HF
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:10:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5039772b-574e-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:10:40 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-ZbzYjggmO5qJV8I_J3Rb_g-1; Tue, 07 Dec 2021 12:10:39 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3534.eurprd04.prod.outlook.com (2603:10a6:803:8::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Tue, 7 Dec
 2021 11:10:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 11:10:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Tue, 7 Dec 2021 11:10:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5039772b-574e-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638875440;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UkGzC1LW1LA9UOGe7ajsRQ7HLHHe0kpj8Wpyyc5+5pM=;
	b=EB4dZy6J6D6x7/UDUaR+wv4Wl/KzmgvWgHa2hGBmGsSXkLYPepNeumZGWlOoOrwl2oFsCW
	e9RDWWQDuIh/BbF2ygUP79p47WM1ZiLP0GWBLXTv3A09yww06Vmdrr0Opvq7RvRexEnwnn
	9f46km9qq90dgAabjWV8hzITOqq/VWM=
X-MC-Unique: ZbzYjggmO5qJV8I_J3Rb_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oBxRv/QA2rnHruMoIJfz7I9jeVoSp0c+jJiy6CBPrrN9Q3pVyU7t5U6vE5rOs1L3ML1xmJjopfGJi3m+khoKKIUhKxge38figIcQmVmtemw4Y6xm30jbW9svXEmQxe9OOkoSnz3/v+DqEMdUzJxwcUhbnw+auCDKtMZlay0IB2H2FTuJflnDuoqZnwCK+jvRvGmZ52K29u2OORsiqynfgXtloIIWfllRfATX1OBYZJyk/zKjO0d0HzqMbEkFKtyMGhECrRn7SB2tLqf1/AL//xivUS7eoqIV+WSN7R+EUAbsUef5Mwsz+NwwUav3De/ECF53JEvlbwShMi2Bf28odg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UkGzC1LW1LA9UOGe7ajsRQ7HLHHe0kpj8Wpyyc5+5pM=;
 b=gCon0ntCMvqJf9j3BfdkY2XZDShVuCC/RbhR9o4RNgwffAuq68cISSZMP9Db5orFBFphILUhk4YZwtbKcs98I4ICUPFfJSvS7+CoOHnhyBGEUDTn95Ky5830jzNplHMD9ALfl1S/Fyn2cImrRvMbsFajWWaR3WlCqeveI2JlIE5xzgHj8qWk2IerIgVDZqty461H59vtgyOc+h8/Td5iomrgOapz5aN6LmWEp60isW2yppsRhawFgtTmdLRWiVByBd/poxpS0JtnYVgiB03+I9jtopMBPGy6zJzwazeA7M9NHPvDRtiO4mHMeIV9mQEhCujQQa7L3wy/OTNaaBtwSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com>
Date: Tue, 7 Dec 2021 12:10:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-13-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2556f73-f6d5-433e-e589-08d9b972323e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3534:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3534F68EEBA96FDCC6AB1D20B36E9@VI1PR0402MB3534.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bRhl8Yg3N1uGKWIJWQyw75wVbhE47dA0PdiNLXTAmmdAG4h6B6Q6OnPoqLHjqHXw7OQL0NUadmGpfDqixLZ3YqUCTye5cRTmuFyac0ya/HooE4r1/+BTatZkCjoh1JvaOi+7nVfdoDyxgA0CUfl5sqkfLZC0vMY2cuSXRDd6fNZgZHuG9P6jVVlCGcH+GqqqrFtDlbwz3/+kcj5TyQLoGp+yXeHqA5+VX4rfSuAii2myXw/vwR53aPf+36/gr+0JqtL5+oB5PsanUonK5C5+qJ5URVqjZdjqkeESCco9md7r3ka9miP3drz41ov9F0UWkaqv4rARkK8jtLE3UM7AtW+KtXPU0OhyzNKqPvByrR1esy4k1crpxWKvNMaZ0+ejhUCzwlTmOzb8Jx8S2C/ztvtmkpOJFlzhhUdJUzOELL6QUXR3GX5HnAdTfpthdOh2Y2zHEXl90XWr/JnrK22Wtqog+EOS8J/MzHTODBCkyYBNSFZKEDFn8TkMLWqhCFp7KFOkL/NCw/ngHlBixMJspnWwgzEEnb1c/6YV2lApoWq5YEdXaVFPByoVbWQ347sK7XeiG3/3z2U8mas/cjvx6dOMz0OpyG08lggol6E1EIZznT1VSGbsDlzrpMdEiMCiFYzsZcxjNiPKh7kZZOsp2h7n4mvfi5/frTj8jUdJBMNLtL/HYpT/j86QMtx+xceyJNfrPVhsPwil0S7+bWzUZgKE3vIEfBha+KRR6k9xfZBzRSYqnKpbzmdKdY0hKZsz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(54906003)(6916009)(66946007)(31696002)(36756003)(16576012)(316002)(2906002)(31686004)(4326008)(66556008)(66476007)(53546011)(2616005)(86362001)(6486002)(26005)(8936002)(38100700002)(8676002)(7416002)(508600001)(5660300002)(186003)(956004)(155303001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzVsUjFKK3lEa2NZbkRTYXJCczFFNlpXT3lCVWhzbGNhdGY0VXcyUGNXTElv?=
 =?utf-8?B?U3pHaHZHeVdPT0JDWGxPcjlSUlhkUEptd00vUU9mRVNldlFSRTVRWEk3TlN4?=
 =?utf-8?B?bzVHSEZTSkJSUTR2bnF0QlM2bnFBcEdLZm52WW93bzRTd3A3UmkxYzVFa01v?=
 =?utf-8?B?TGJPSnp4L3lJQ0tHelVaOHB2SEpzR3J1QmFleGs1aTdORU9OOVZJMWp5Nmxw?=
 =?utf-8?B?VXJ1MEdta0F2UWVsaWp0dUhVVVZlb1BxbUpHU3lDbEc2TmNBekJPL3ByaTUv?=
 =?utf-8?B?bG5FVCtYbEJ6QnNXL0M3ZkxaMUdvSnBpQnMrMnlSUTgwclVlM1BkQmppNjcx?=
 =?utf-8?B?dFA0MGljSndObEhkblROaUR2Zzc1ZnZIeGlHYWZUKzY0dFNwWEg1ZUYvcm80?=
 =?utf-8?B?SmlQTGR2eG9Wem1XaS9oOHROTHBxQzlQTm1xNjViSGN5MVBqdDVpK1JQK1g0?=
 =?utf-8?B?RjNvR2xxSDk4ZTRXeFRweVNSbS9tbjkrSEdpZGhmWEdTVmYrUDNZRlBKZnlu?=
 =?utf-8?B?NFAxOVB4cTZzTVlPcTZZRVpiNUpRdnd3aXV5Rk5nVlZkSDltUGdZL0NSQTM3?=
 =?utf-8?B?SmZjalNZQXNGZ214QTJtVk9zcmFic3Q5THJDMndRb091eE9xY0dwRFNzZUgz?=
 =?utf-8?B?ZmhpRjZ3RHhuQUwyMlZkWTh2elVvUzBCZFM2OFNvN2hVZHE4QXVzdm5YRGI4?=
 =?utf-8?B?SHB1YjdDR1RwZ0hVelBsRUwrTGxGTjhxYjVCMldYNXRHRHBVdjA3QXE0dE1s?=
 =?utf-8?B?Y21nTk5ZMkFOa2FXdmVqWk5aKys0TDRvYjU0aVI1NXJRbWNucFAxS043NTlw?=
 =?utf-8?B?UldHOHdHT29iVlJHQk94Ti9LWDEzYmtBNDhZRG84WnN0UVRwYzlXNk1zVER0?=
 =?utf-8?B?WmNLbDdOY0dQdFNzampPY1JTb2ZGK0Z3MUxqbTEwRXE0dWlLdVBLR2tHQUVV?=
 =?utf-8?B?VTNDUTJqRExHVS9QYXlhdDd2dEQ3aG5nRnF5SytSOGpndWIveWhZK3NyVVRy?=
 =?utf-8?B?T2tVOVdhcEUvVWdhbGRBb0xITGFwNE83ckIxSGd6TmRGOGRONFVqclBURmFY?=
 =?utf-8?B?Nk4wS0dZTklmUlh6ekJVa1FtYjFGSW1Fd2kwS1ZlbWpPd3ZKWjVHWndPMXdq?=
 =?utf-8?B?b0JudUxFd2tTckRSUUkyMnNaejUvYVBwUHNsaENsTXVmMHdGb2FZWFBlbCtE?=
 =?utf-8?B?VEhvR3UxcWQ2MmRiMkY3RWlYc2U0ZVRSQmg1bTQwSkJWcU56Ynp1QXZ5RFhJ?=
 =?utf-8?B?ckNNcVNvZnlsMmljQ1drTlVvY2liLzBZQk1IUUxDS2MyVjhqRGJVZmN2NDVp?=
 =?utf-8?B?dTNWcTM0eXpDYTVEMk8yUU5vREkvN2h2OVV3V0ZDRU5LcUh4SzhxQnBoZjdK?=
 =?utf-8?B?RVNhK21kSHJWb2RLZ0dBcWZLUU1BWFRDUTV3NzdPeGVKNU1xV251R3B5TGpN?=
 =?utf-8?B?S21SOGFML04rbWlFZXRRdnR6eTB3dnJUT0hHbEcwRUYvUHFMOGJQendFekZz?=
 =?utf-8?B?ZVRHZkx3NFRVQVRab2Mvakd4QVo5S1ZINjJ5Vk9kemU5a0F5d3FzODJGZUF3?=
 =?utf-8?B?bjU4TncyaElJRGRCWlV3ZnptWnJ0RFU5VkFKSjBSTnFpTnFDTmpzRkRLTzQr?=
 =?utf-8?B?YnFyT0UyUnVHajAzTnI5V2NURHdkd1NwSTcydWJIQTJQYnNMYXgwUDhTeG5v?=
 =?utf-8?B?bUVhUVRuR0hpbEVLbGpZSzE5Wlh5c3pYdGU5VmdlVm9LWkhqYmFPUlNuOWMv?=
 =?utf-8?B?SzBsRzB3SnBoNkMvbFdjL0xSR2E0RnU2L0RXT0dEdy9VZXprVGF4WDhmYW5l?=
 =?utf-8?B?OEVCY09scGFqY0NMRGsxa2c3RWk1TUNDdGRRYkk2K0RqclZGUFBFZDBBNmJ6?=
 =?utf-8?B?bFVsUWp2d2JWYWxBa201RlU2V25ySWY3QVVSVTBGM2hxS0hXMjdIRHJlQ3VC?=
 =?utf-8?B?eVcrdEJLVmZ6YlhTR20rMHNRb1hsVUYyUmlodERKYmRxY0pzYldjTlVUZkQv?=
 =?utf-8?B?THJvNEVMTkR2KytqNUJhaVZUY1BPdzJEMTV6dnRvM1dQU3pPek1RazBUQzYv?=
 =?utf-8?B?bG1KUTVrVXYrcVY2aXBSV01BTnVWYW85N1F5SngzbHgxd0NneFFjQWF5blM0?=
 =?utf-8?B?VzIwNXpSbEk5UWVqbkZBUUkwTVpMZ2h5S0l5bFhCVE5uRW5qSnoxeWx2cTFV?=
 =?utf-8?Q?OPsySBM4THL5GdD2wHW4snQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2556f73-f6d5-433e-e589-08d9b972323e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:10:37.1458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oyw6rnTlU+ETsLM/nGaQ3tWN+8iJSciF35jZn75LhK73nKvmdJcECnkAX08eOQIHK8XsMriUatAfW9DuS8F87w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3534

On 25.11.2021 14:39, Anthony PERARD wrote:
> A subdirectory is now built by setting "$(obj)" instead of changing
> directory. "$(obj)" should always be set when using "Rules.mk" and
> thus a shortcut "$(build)" is introduced and should be used.
> 
> A new variable "$(need-builtin)" is introduce. It is to be used
> whenever a "built_in.o" is wanted from a subdirectory. "built_in.o"
> isn't the main target anymore, and thus only needs to depends on the
> objects that should be part of "built_in.o".
> 
> Introduce $(srctree) and $(objtree) to replace $(BASEDIR) in cases a
> relative path is better, and $(abs_srctree) and $(abs_objtree) which
> have an absolute path.
> 
> DEPS is updated as the existing macro to deal with it doesn't know
> about $(obj).
> 
> There's some changes in "Rules.mk" which in addition to deal with
> "$(obj)" also make it's looks more like "Makefile.build" from Linux
> v5.12.
> 
> test/Makefile doesn't need special handling in order to build
> everything under test/, Rules.mk will visit test/livepatch via
> $(subdir-y), thus "tests" "all" and "build" target are removed.
> "subtree-force-update" target isn't useful so it is removed as well.
> 
> test/livepatch/Makefile doesn't need default target anymore, Rules.mk
> will build everything in $(extra-y) and thus all *.livepatch.
> 
> Adjust cloc recipe: dependency files generated by CC will now have the
> full path to the source file, so we don't need to prepend the
> subdirectory. This fix some issue with source not been parsed by cloc
> before. Also source from tools/kconfig would be listed with changes in
> this patch so adjust the find command to stop listing the "tools"
> directory and thus kconfig. With a default build of Xen on X86, they
> are a few new files parsed by cloc:
>     arch/x86/x86_64/compat/mm.c
>     arch/x86/x86_64/mm.c
>     common/compat/domain.c
>     common/compat/memory.c
>     common/compat/xlat.c
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Bob Eshleman <bobbyeshleman@gmail.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one nit and a remark:

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -22,6 +22,15 @@ export CHECKPOLICY	?= checkpolicy
>  export BASEDIR := $(CURDIR)
>  export XEN_ROOT := $(BASEDIR)/..
>  
> +abs_objtree := $(CURDIR)
> +abs_srctree := $(CURDIR)

Nit: In line with e.g. obj-y I think these would better be abs-srctree and
abs-objtree.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -80,6 +80,9 @@ endif
>  extra-y += asm-macros.i
>  extra-y += xen.lds
>  
> +# Allows usercopy.c to include itself
> +$(obj)/usercopy.o: CFLAGS-y += -iquote .
> +
>  ifneq ($(CONFIG_HVM),y)
>  $(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label
>  endif
> @@ -129,13 +132,13 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds
>  	$(NM) -pa --format=sysv $(@D)/.$(@F).0 \
>  		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \
>  		>$(@D)/.$(@F).0.S
> -	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y= $(@D)/.$(@F).0.o
> +	$(MAKE) $(build)=$(@D) efi-y= $(@D)/.$(@F).0.o

Hmm, hasn't the efi-y= become unnecessary already by patch 6?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:12:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:12:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240930.417718 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYOF-0007Av-EJ; Tue, 07 Dec 2021 11:12:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240930.417718; Tue, 07 Dec 2021 11:12:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYOF-0007Ao-Ap; Tue, 07 Dec 2021 11:12:07 +0000
Received: by outflank-mailman (input) for mailman id 240930;
 Tue, 07 Dec 2021 11:12:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muYOE-0007Aa-05; Tue, 07 Dec 2021 11:12:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muYOD-0000Lt-O7; Tue, 07 Dec 2021 11:12:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muYOD-0004Ll-Er; Tue, 07 Dec 2021 11:12:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muYOD-00079H-A0; Tue, 07 Dec 2021 11:12:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WroLKLi7ZLUXIHupU5hg0/Q0BkdUUKL6O9zGmNSZ0zI=; b=W9ZHvNuMxXFKHkbPrNReZV+qVj
	MjVCa/6+WQzC2yQz2JOdh4YrjORVG0QVqEUSo45shgsIuyRBBskkHC9U1CXdGT6Cc+lJNTcqahuMV
	d1ZbM72++kINK+5cLikA+rj/VBK4oOagq9GNavXn/nxJLfg2fw8CkuOCcWM5HACKd+LY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167216-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 167216: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c4cf5388652e8434652e30c73aa79635b4253675
X-Osstest-Versions-That:
    xen=9de3671772d5019dab2ba7be7ad1032ad3c9e0f2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 11:12:05 +0000

flight 167216 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167216/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166348
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166348
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166348
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166348
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166348
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166348
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166348
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166348
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166348
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166348
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166348
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166348
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c4cf5388652e8434652e30c73aa79635b4253675
baseline version:
 xen                  9de3671772d5019dab2ba7be7ad1032ad3c9e0f2

Last test of basis   166348  2021-11-24 09:30:51 Z   13 days
Testing same since   167216  2021-12-06 15:36:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <ian.jackson@eu.citrix.com>
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9de3671772..c4cf538865  c4cf5388652e8434652e30c73aa79635b4253675 -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:21:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:21:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240939.417732 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYWr-0000sx-KW; Tue, 07 Dec 2021 11:21:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240939.417732; Tue, 07 Dec 2021 11:21:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYWr-0000sq-G5; Tue, 07 Dec 2021 11:21:01 +0000
Received: by outflank-mailman (input) for mailman id 240939;
 Tue, 07 Dec 2021 11:21:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muYWq-0000sk-9h
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:21:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0b19472-574f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:20:59 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2059.outbound.protection.outlook.com [104.47.10.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-IBuk0WC2PNS8NGP3_MV5HQ-1; Tue, 07 Dec 2021 12:20:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Tue, 7 Dec
 2021 11:20:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 11:20:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:20b:92::46) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Tue, 7 Dec 2021 11:20:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0b19472-574f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638876058;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=w/YG7ewcnOsfEMnvus0ZdTDuCEDNYWF7nyZpk1MfpVc=;
	b=M1UmXQI/mP5qZHeiAlW0sm0GYH4Wc7Diem/iRmMk3DG7CXocewNjFud3jZYz5hNO5ZY0oB
	/B78YU4txERf9iRel1kTYno7zvIAOiKDkyrpyMImxHVXAhcSdLytY9I+T58SSlgX35IQPV
	vWxPRlGbN889G8oltC2Qdj0isbfSrxw=
X-MC-Unique: IBuk0WC2PNS8NGP3_MV5HQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SuarTOkc5BbBxFnF5TGs0LWraclbK+4EBi0AB9homZdtJEku+oPGfS8xfVoEStqK+sYp8tt/SRgpw6tp2bwqJJys/X7hcgEukmUNllCjYMksWQC6MB1RMO1OwZ68fDK4YF25c20aPZgDOAiDYdJIUyWogSPcWy00rXi1rlCcNxCo/wit+DBz6bS3LrNYOf4fElLepkSNGXKXG31h2pFZdMKero5VjmMJx917f1j3/PD+qMcfpacMMiarFuzHMXwnLhuqj9jHDw0IMc98ufxBdXWJGy2LWQxN823tQzTC7gG9R7ut8BNb7Y6LghfsZAEFAgOxnKDGdgZ322/StbtPvg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=w/YG7ewcnOsfEMnvus0ZdTDuCEDNYWF7nyZpk1MfpVc=;
 b=gOB4ouBXTcncykwDIAwrf2Fw6m2KyBZrwj11ruIgbC4BlPmdv+00NHWd7F9er1VApHtV+1flxSGkhFIAhG5e5mdU/S5JJfw7z9Bj79DoFZq1JcUzR36rfCSyQiRmcsrIBFg3+TSr4/qKfcx4Z323C6hkir1T6QGhW0ocnSoWJB0UVCGmElFwGQhDvGw5NG9JpOVnOkoQoz1MGKZZqKRN7ToukiJoWrniUWD0747KRlZxwLC6IBpX0zzz/lXpWsMY/OyNGKhberuoN/c0q1sdHn/IPf+Yc4xdP0hAv9RQYreWfDhXEAiICF17bElwpPqEjcb8dEVaja+asg87om1ivA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5bfb40ab-b50a-2485-b1a7-8d203374b064@suse.com>
Date: Tue, 7 Dec 2021 12:20:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 16/47] xen/tools/kconfig: fix build with
 -Wdeclaration-after-statement
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-17-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-17-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0033.eurprd04.prod.outlook.com
 (2603:10a6:20b:92::46) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9afc120-c006-4334-617a-08d9b973a36b
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6301FA9DAEE53C8B7919CF1DB36E9@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:800;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	cSqN3bIsK+xC1yrBfkLPYK56fyIStNV6Td3C91Cf8ClpGaqIKDS2w/OlPWg9CfeFnK0tUgoh/KGGivDuJgWeW8LWozwrpM5LVIeDEr35tK0p0xyjlh1uoI25h8oRAd/uDHs4gIPV4yLTeFsbsaK29w2mKFCScCCsfs9L53tNEaxYMUIIs9hc3Cjl2BY/gFMz0G52uoEnzss2Ea4tuUge5sdkiqfBpvUBsSFO74gq9AqWKFJfOqPmba8sVG5STNv6CkxzgKMJmmJsHHR9DaQNIwkcHCoslcr8lS+jM/3LGBIlXpUJU03WYSSY8YN8Aa84SiJwJg/sPwKEN0cCZQWV4UOh+0ETyVayEyFN7mvzFYAfIled9JtGUuxnM7vFHJOl+DjfKNk7dtWVG8gF+ufremyxuX2jRuj5NAanBuDQdQ+2eVv2olMKbpytkRInVQ6aGZIT6ku2TeCls+qN+A+ZWoTbJBrLBInN61TTIXXwT1QDNo9l10E4VkUx3iAFt+KV2VeC0NPR0BhZKyAr9FC0lXszU8vLjVvdJRb2X1uK8ai3n6gbYt8Bn+O3ttiN31jYpLHUfQKyAGBMEt1spC9wqGTp1QLlTtbS5kSIAoSDgYiO/nFoFRNaiwjvvxHua4qTPRRvpsddWBZ4uZ5nixVaWkmr0LJmrG89lJndCEUX5bDVNSg/sQw2xwMQRa8GnBDZkZPGbYs5URvV4p6PmdG/fEZA1LlCZym2iODejq3lIoI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(2906002)(36756003)(8936002)(66476007)(86362001)(66556008)(31686004)(38100700002)(316002)(6486002)(2616005)(66946007)(16576012)(956004)(4326008)(5660300002)(8676002)(6916009)(53546011)(186003)(26005)(31696002)(558084003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cS82QmpMNHJMQWFqdU12M1Y3bS9LbER5Ly9oakRkSmcyVXNPOWZDUUFHMkMx?=
 =?utf-8?B?UUp0OEhWYTc2RVBBVFVhUSt2endDRGhreURZSUJSZ0VmRVRWSEpQWEJCazQz?=
 =?utf-8?B?WVFBWGVVUzFlbWtxMTVZeldzRGpCSmN2eTBsNmFSZnlOTnlNOGJUMEpMQ1Z1?=
 =?utf-8?B?bWlBODdGbmJRMVR5bFdlR0ZzNE1yeWE1R3lvUWpyQ1pGZDlPQVlneVIzRFA4?=
 =?utf-8?B?Z1FxemY4MzB4L1B4TVppaDFWWEtPbkFtaElPcWlNc0I1eGtROEZ0bWFsOStl?=
 =?utf-8?B?RElodEs1ckZQUCttRzVVM2IzbWV3S09wamt1VFhEZ1VET05XN05YTzh0Sit1?=
 =?utf-8?B?MjdodzIxQURRdEZRMXZYcExHK0FwMzJqQnp4SmZwb2I1Qk5qTGQwaFJnNzBV?=
 =?utf-8?B?bGtxSDNoei9UMDY4WkxBcXVrY2xFRm9hd3EzZU9zNHFZWTJQbzdyb2MrVnVL?=
 =?utf-8?B?NjVEaFpLZUVCdXU2U2lzcWpabktSblVyUjQ0bDdTUVpGemVoMVpaejVMa21P?=
 =?utf-8?B?aGVPVTBLMG4rUXpRWUZjVU1xS3E3TFB3MGx0dk9CT1VpTmVGLzc3ZWtYQ09l?=
 =?utf-8?B?Q2VrK0R1NkxPd2VmSzJ5cXI2R3M5L2w0QlhLOVBXN2xONE9CNzhQalZVMkoy?=
 =?utf-8?B?WDY3UzFNYTlIMUZZVUcrMDNCZkFjamVuMHJEQ1F1MllYKzNLdFNFTVp0OE5u?=
 =?utf-8?B?eGJtNlFJcE8wdW1pa0pxK0pLNFFoRkxtWnRWa0w0NG92VXVvaXNkV1FFejhn?=
 =?utf-8?B?cmhQNTRIRW5sYURiaGcxajhtcitxelFQSlFyRTIvRDBMQzk2Mi91aHpwa29p?=
 =?utf-8?B?VzJkMWZiTDc4UXpQcEZkZ3pYTWZHSDl2N2dGZGJaQ1BtWitnN3dBWDlTQUN1?=
 =?utf-8?B?d1grNGF4UWQ5MC8rY0pGOEJxd3RPMUtybXllaWFPcjZsOVdqQmpaSURVUTc1?=
 =?utf-8?B?eEVVUGhQNXlBZThKQUswQjFDcVlScElWTGhXd1N0QVBBUXVlVGV5Yk1lRUJQ?=
 =?utf-8?B?QWFSeE9zblQvbVNkVGl4bWRBMkpDVGRQY2R0Z1liOFd2ak92WlRheXBXVmta?=
 =?utf-8?B?TUY4amFPQlJhSFpsUEdPL1BEZGlFRHZaY3JxWGpGSWhLaGxCWXFueWt5K3JL?=
 =?utf-8?B?L1RXT1hqTGFrTkRoL3BvSk1wWWV1aE5wRHZOZUdvdVZvVXpZbDhpM3hQZzdp?=
 =?utf-8?B?SnRlL2RrbHZUT1FEcTdIMGVLRldCdS82TnJVd3hFUlR3aVpEQnRPbEdnSGth?=
 =?utf-8?B?NERvalZPWTFrU1NhTGkwZzU0M0pkaDRCd1BJT3BrYXVETTlKTTRTbS9PVncy?=
 =?utf-8?B?Sm5lU09jZlNob1g3Q2U2bEsrTGxEWlhjTGF1SHRnQmZvMkI5a0FxbVhqN1BW?=
 =?utf-8?B?N1I3Z1gzYkhHODhhRzJyYndaRDlma0NEWEJjN0xWOHFCbW1CUjBJZkJLNWR6?=
 =?utf-8?B?Yi82ckI4T2pHcjBZOTV1eStoNFhUNFZOVGZrd0Q3d2VzTC8zTjExdS9HVXNC?=
 =?utf-8?B?R3EvbTF1dEJMU1R2aVZvTXNkejgvTTdGbVd5Wjh0UVRoQjl4eXBDL2l2UUhh?=
 =?utf-8?B?NUlEdXVkNlcyaXIrWjloT1d6KzVOY1FDUEhYczJLakZwWEpvRUdObGw0dEFv?=
 =?utf-8?B?U0RabVVSQ3dycUdIbHozZHEwRGFOdklzUmRjLy9JbW9QYms2OG9HbVpnYVlL?=
 =?utf-8?B?bUs2ZFdxMk9xUnhNNkxCQVFvRDhpWllQdzJxU0R2Z3NUU3JqU0xkWVExUk9J?=
 =?utf-8?B?bHBkZHFoMTZHUGc0YVZNaVIwSmEzV2ZKYTUvQ3RvczBKcGV0MllVaWZRekdx?=
 =?utf-8?B?N3ZqUzJEZmtUYkhFaS9uOWVrNnQrV0dqQXNGTmMxTW01N0t6ZW5rYUEwZ3dx?=
 =?utf-8?B?c0kwQUVINFN2RzZIeXg1dWl1R3RTN2Z1VzFxdFMySy9iMXNEamVRcThDc2hB?=
 =?utf-8?B?UGNKQUptM0JqdWVNYWR5VTVMTVh6Nm1zUEYyYXpNOFA1ZEpDZzNTM3ZZY04v?=
 =?utf-8?B?R0hTOFNWZ1NKcTZ1SG9CdTkrNENTQVRqQWRYUEdyWU81a3RCd2hqUGJNUXVY?=
 =?utf-8?B?WEtvS0htWmxQUXR1Qm9wM21xdUtEbSsvRlE1RUpyZUFieUo5bitDclRHV2s0?=
 =?utf-8?B?UmtDbCtNdThjZjdEWkR4RUlXN1Vkc3I2NzVXRGJLTFVIZXNEaklwS3krSFBH?=
 =?utf-8?Q?12md5CiRfnYD3c9F+hLb29k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9afc120-c006-4334-617a-08d9b973a36b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:20:56.6305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZeDyCs3XjTebkisRsHvNZuy+TCW8o6gBDRNBqkZzT7KeVeaTG5icY7+eocKWc7zomI/xPISgHPOAuCEoZiffRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 25.11.2021 14:39, Anthony PERARD wrote:
> We are going to start building kconfig with HOSTCFLAGS from Config.mk,
> it has the flag "-Wdeclaration-after-statement".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:21:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:21:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240940.417742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYX1-0001BE-Rp; Tue, 07 Dec 2021 11:21:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240940.417742; Tue, 07 Dec 2021 11:21:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYX1-0001B3-Os; Tue, 07 Dec 2021 11:21:11 +0000
Received: by outflank-mailman (input) for mailman id 240940;
 Tue, 07 Dec 2021 11:21:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muYX0-0000sk-Bo
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:21:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c6c79c8c-574f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:21:09 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id ABF971FD56;
 Tue,  7 Dec 2021 11:21:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78A2D13A5E;
 Tue,  7 Dec 2021 11:21:08 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id qdDoG6RDr2E3CwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 11:21:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6c79c8c-574f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638876068; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=SKH/gl/eZJyB2o5wb/G4woN6S/g8VY8RqDztoYgizkY=;
	b=ArW7xHZQ7R5W7B/Nt/BUZb76gEHQvJNYo4N8EKXXyLZYCq9XcdDs+kZVOtCtx3r3JOrCRr
	FjxyQYdhawWaq2pZL0e09o+vr00Blckrb1Z1yXOWpNuedEnczjUN8HJfbgSrLyOiuiFrCv
	w+/sDLOBVnIpqq5lmQvMgtfN4BEO5Fk=
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c864cd56-3499-510d-04f0-849106fe3acf@suse.com>
Date: Tue, 7 Dec 2021 12:21:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-37-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="SCvHoW1kDReyNTCWCbNRcmt9aQbARbD7q"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--SCvHoW1kDReyNTCWCbNRcmt9aQbARbD7q
Content-Type: multipart/mixed; boundary="izEXKL52Q9k0HvV5fAbcGGqM11NnYYZWq";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>
Message-ID: <c864cd56-3499-510d-04f0-849106fe3acf@suse.com>
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-37-anthony.perard@citrix.com>

--izEXKL52Q9k0HvV5fAbcGGqM11NnYYZWq
Content-Type: multipart/mixed;
 boundary="------------AA8FE5CB4616E1D9F28BE430"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------AA8FE5CB4616E1D9F28BE430
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Regroup *FLAGS together, use $(LDLIBS).
>=20
> Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't
> decribe how to link to a potential libxenstored.so, instead add the
> value to $(LDLIBS) of xenstored.
>=20
> Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).
>=20
> Remove the "-I." from $(CFLAGS), it shouldn't be needed.
>=20
> Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
> in $(CFLAGS) and both aren't used anyway.
>=20
> Rename ALL_TARGETS to TARGETS.
> Only add programmes we want to build in $(TARGETS), not phony-targets
> (replace "clients").
>=20
> Store all `xenstored` objs into $(XENSTORED_OBJS-y).
>=20
> Replace one $< by $^ even if there's only one dependency,
> (xenstore-control).
>=20
> clean: "init-xenstore-domain" isn't built here, so stop trying to
> remove it, remove $(TARGETS).
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------AA8FE5CB4616E1D9F28BE430
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------AA8FE5CB4616E1D9F28BE430--

--izEXKL52Q9k0HvV5fAbcGGqM11NnYYZWq--

--SCvHoW1kDReyNTCWCbNRcmt9aQbARbD7q
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvQ6MFAwAAAAAACgkQsN6d1ii/Ey9O
mAf/bZj9pc3Ece7tyftgKwM3F1ZPmuLAal/K9JOtJQW7qxdpqrnxfKaK02M8CZDnTRBuKl7D/epY
X/UvKvvwqqKE2xp31AJTBcroniVCQrHUbNP3DTUA67hcgSTtXDoYEuX/vlOE8SRnaT9O3WKv/1pK
xviMuXFKAbyXUYVMO2LK7XdakGJOEw841dgB7YPGjMq1x1b24P74RdwamgKsdptT4puSFjYLa0TX
7aZPwF5DOei+xp4eYcI7IQywPeEXxoFEHTUO/v7SvuvnA+EvH5BQxJMvnvYMGr5bvsN7iVJiBu79
ZmGgTOvvs4mAnjpfyNsMm4ha4l+pCWPj/r+vKZpdLg==
=fY6F
-----END PGP SIGNATURE-----

--SCvHoW1kDReyNTCWCbNRcmt9aQbARbD7q--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:24:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:24:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240951.417754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYZt-00026L-CN; Tue, 07 Dec 2021 11:24:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240951.417754; Tue, 07 Dec 2021 11:24:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYZt-00026E-8j; Tue, 07 Dec 2021 11:24:09 +0000
Received: by outflank-mailman (input) for mailman id 240951;
 Tue, 07 Dec 2021 11:24:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sjJF=QY=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muYZr-000268-Sq
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:24:07 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2faa8950-5750-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:24:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2faa8950-5750-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638876246;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=IntWDxNmwzVjFV5s9kyYqX93aucXyxvwnepZDEDAcag=;
  b=dpwKIHkCrEqgXb5FXPFq/vvu5+cZhB8o2z6WyhqmOeG7UwZ/7IuLAAId
   6iRmHLQa+hDp4Begt31cf0pc/XZFEqF3OKDc8fgX450Y4wWu97QJmbLnF
   T6qZFcBIX+IcncldLLqj2JNtyHkZVVSCw8j+i6/pdnSuIhah2EoiBHM+h
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: c+HkDxazBjVl/++AjhAJ8ql8CneRxe0U7oNlZFzeNJ91Vy8xKmji3uYpWNioDHyuPL2jPDF6oI
 GgfjHUl4Nc34XQFtAtVj7aRnoE/MjlRW1R7QnVeYmogFC/rgj+W/e5ynwgvnU4wtDz8XgrPxIf
 5df79F1LroGXjTPVf4bIPFgZ2Bm/2nGc+JxtPsNjr1auFEqIuyNITy0Jx9TRiStGJXw2+WIv03
 /QEmG43ymVIlQeUuqcMUzZ8C7tFm/bn9r0c27/VIVlIr/8dVSRsLUpVSdzgi7QQNo0jMLc0eF2
 yuR8HF634aTwh0d+3xEfVEW6
X-SBRS: 5.1
X-MesageID: 58950530
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:850E96wUiW+8PV2rI056t+edwSrEfRIJ4+MujC+fZmUNrF6WrkUPm
 DZJXGrUO67fNmXyetxzaIi19UhQvJTTzNI3TAs5/yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAuLeNYYH1500s6wbZm2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/t7x
 e1InoWIcgosb5T9lLgtUhZ9Ei4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY25AfQK6DP
 JJxhTxHTTPZYCVvAhQrVJthmt3z22nGciZhkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krd5HjwCBweMN2ZyBKG/2iqi+uJmjn0MKoYGaek7PdsjBuWz3YKFRwNfVKhpL+yjUvWc+xYL
 0sY6y8/t58Y/UagTsT+dxCgqXvCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz
 FDht9HjCCFrsbaVYWmA7brSpjS3UQAXMGsDaCksXQYDpd75r+kbjw3NZsZuFravid/4Ei22x
 CqFxBXSnJ1K05RNjf/iuwma3XT8/fAlUzLZ+C38VG+d6yhgXLWoYt2R2FSH3fdPCYeWGwzpU
 Gc/p+CS6+UHDJeonSOLQfkQELzB28tpIAEwknY0QcB/qm3FF2qLONkJvWogfBsB3tMsIGexO
 CfuVRVtCIi/1ZdARYt+eMqPBssj1sAM/vy1B6mPPrKijnWcHTJrHR2Ch2bMjggBc2B2yMnT3
 Kt3lu72Uh4n5VxPlmbeegvk+eZDKtoC7W3SX4vn6B+szKCTYnWYIZ9cbgDePrlnsvve+FmLm
 zq6Cydt408AONASnwGNqdJDRbz0BSZT6W/KRzx/KbfYf1sO9JAJAP7N27IxE7GJbIwO/tokC
 kqVAxcCoHKm3CWvAVzTNhhLNeO+Nb4i/ClTFXF9Yj6VN40LPN/HAFE3LMBsI9HKNYVLkJZJc
 hXyU5naX6kUFG2Yo291gFuUhNUKSSlHTDmmZ0KNCAXTtbY5H2QlI/foIVni8jcgFC2yuZdsq
 rGszFqDE5ECWx5jHIDdb/f2lwG9un0UmeRTWUrUI4YMJBWwodYycyGh3OUqJ8wsKAnYwmfI3
 QihHhpF9/LGpJU48YeViPnc/ZupCeZ3AmFTA3LfseStLSDf82f6md1AXe+EcCrzTmTx/Kn+N
 +xZw+ulaK8MnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLhJAduLdMy7lVvRqNd
 niOotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Oos5JwW5gi4hkZ4O9qKlHkJpWGFL3hGWKQ7rJAKRoTsj1NzmF1FZJXdDA7w4Y2ONIoQYhV7f
 GfMifqQnalYy2rDb2E3RCrE0udqjJgTvAxHkQ0ZLFOTl9uZ3vI60XW9K9jsoti5Gvmf799OB
 w==
IronPort-HdrOrdr: A9a23:IYAl/Koiv24o6Bzv3Xe4cf8aV5oreYIsimQD101hICG8cqSj+f
 xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U
 4JSdkZNDSaNzlHZKjBjzWFLw==
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="58950530"
Date: Tue, 7 Dec 2021 11:23:47 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [XEN PATCH v8 07/47] build: set ALL_OBJS to main Makefile; move
 prelink.o to main Makefile
Message-ID: <Ya9EQwNETQ6BPlma@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-8-anthony.perard@citrix.com>
 <b4bde105-094d-067a-4657-a7ff041aee4a@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b4bde105-094d-067a-4657-a7ff041aee4a@suse.com>

On Mon, Dec 06, 2021 at 05:52:51PM +0100, Jan Beulich wrote:
> On 25.11.2021 14:39, Anthony PERARD wrote:
> 
> Nit: In the title, do you mean "set ALL_OBJS in main Makefile; ..."?
> 
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -285,8 +285,21 @@ CFLAGS += -flto
> >  LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
> >  endif
> >  
> > +# Note that link order matters!
> > +ALL_OBJS-y                := common/built_in.o
> > +ALL_OBJS-y                += drivers/built_in.o
> > +ALL_OBJS-y                += lib/built_in.o
> > +ALL_OBJS-y                += xsm/built_in.o
> > +ALL_OBJS-y                += arch/$(TARGET_ARCH)/built_in.o
> > +ALL_OBJS-$(CONFIG_CRYPTO) += crypto/built_in.o
> > +
> > +ALL_LIBS-y                := lib/lib.a
> > +
> >  include $(BASEDIR)/arch/$(TARGET_ARCH)/arch.mk
> >  
> > +export ALL_OBJS := $(ALL_OBJS-y)
> > +export ALL_LIBS := $(ALL_LIBS-y)
> 
> Who's the consumer of these exports? I ask because I don't consider the
> names very suitable for exporting, and hence I'd prefer to see their
> scope limited. If e.g. it's only a single make invocation where they
> need propagating, doing so on the command line might be better.

There seems to be only one consumer, "build.mk", and only the last
$(MAKE) call in the recipe "$(TARGET)". So, it's probably fine to set
both on the command line instead of using export. I'll have a look.

> > --- a/xen/arch/arm/Rules.mk
> > +++ b/xen/arch/arm/Rules.mk
> > @@ -0,0 +1,5 @@
> > +# head.o is built by descending into arch/arm/$(TARGET_SUBARCH), depends on the
> > +# part of $(ALL_OBJS) that will eventually recurse into $(TARGET_SUBARCH)/ and
> > +# build head.o
> > +arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o
> > +arch/arm/$(TARGET_SUBARCH)/head.o: ;
> 
> Can't this be a single line:
> 
> arch/arm/$(TARGET_SUBARCH)/head.o: arch/arm/built_in.o ;

Sure.

> > @@ -235,7 +218,7 @@ $(TARGET).efi: FORCE
> >  	echo '$(if $(filter y,$(XEN_BUILD_EFI)),xen.efi generation,EFI support) disabled'
> >  endif
> >  
> > -efi/buildid.o efi/relocs-dummy.o: $(BASEDIR)/arch/x86/efi/built_in.o
> > +# These should already have been rebuilt when building the prerequisite of "prelink.o"
> >  efi/buildid.o efi/relocs-dummy.o: ;
> 
> If the comment is true in all cases, do they really still need an empty
> rule?

Yes. Those two targets are unfortunately a prerequisite of "xen.efi", so
make will look for a rule to make them, and would use %.o:%.c without
this explicit rule.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:24:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240955.417764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYaP-0002dk-Kl; Tue, 07 Dec 2021 11:24:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240955.417764; Tue, 07 Dec 2021 11:24:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYaP-0002dd-Hp; Tue, 07 Dec 2021 11:24:41 +0000
Received: by outflank-mailman (input) for mailman id 240955;
 Tue, 07 Dec 2021 11:24:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muYaO-000268-3X
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:24:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4405bdb9-5750-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:24:39 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-0JTHJWq4McSBtX8HgSJoIw-1; Tue, 07 Dec 2021 12:24:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Tue, 7 Dec
 2021 11:24:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 11:24:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0058.eurprd05.prod.outlook.com (2603:10a6:20b:489::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20 via Frontend
 Transport; Tue, 7 Dec 2021 11:24:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4405bdb9-5750-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638876279;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AV4SpssrYaGyn0sCUuJtrY1jLEs20ZCGEia+x8rkXlI=;
	b=Zi0t8i/DzfIWJ1/VGLXNqPe2hkK513BdBkuVBoNxWXCF7PZijagHF2OH3Y6Sv38QiVLMg2
	Zc8mwNdX8K9xswwmDAJAz2ETMGdvxquH75VM+s+lO4xJyhS8T391GtoHwyr7VaXCFpGEw0
	UwXT73CLn4gIj6t/mN/OCqzuWG9yBa4=
X-MC-Unique: 0JTHJWq4McSBtX8HgSJoIw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JpZ4bMP2bMN0ApBx17sYgzlbBQCHFainUrfkEM48oVn4KHdNxCxZBYcoqXiFPxw7R8K6U/gLgj10qYWlweBO8To3r6+R8+pZyG36//dRtunC3T2Cyy4FJzbBpaOpH3E9qa3bxn3WtMBSBK59jDVaBqCZBjQBP779XtKeKECCQHYDO0h/UG1+VT+SHtmtipgBw0RiOmrW1OAXwufT2GXANso32CmS6wfN4uZiAVvLH6wmZx7ogRUVPHX61fLswN8N2JG4TakNmnbmm4cBaKc1TsaHO64+KeuyMBkQerIZestjr51X4p0/BDdq/vQiETQ0YNIKsE4mKAIIWquk3y2DUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AV4SpssrYaGyn0sCUuJtrY1jLEs20ZCGEia+x8rkXlI=;
 b=euzjQm29jaNEjkEnvlC4290ed8A1deEEkPy+pD225n7+hAkhflvPCUFyu8LydbU4d3i0g4QXexsulii4f2I1XoOoNiTz32N5WJ3r5BHeqvr+CjUA/48/Xlf7J00BvFHtwM7OicwADdwwbgmjqQ0T/bjCB/CiMqHit1nrYoDgJV/EJnKU2OzEFaJSqf3vOtbig6rJH29phrWw8K+Cya5BF4p8W9cogBn6bPV0n3eqkqIztXFW/jZpagH0daF0wshwvNzKW5AhZZzbBuzJrJ8PE1vEnVzBS0OaXFmzyaiQRl0kHsdcddlPVDkTHVjdHUNFTfBGrjJs6HmMkZgGse7Syg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e86a1d1b-0935-63c9-1de6-36fe28f06b77@suse.com>
Date: Tue, 7 Dec 2021 12:24:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 04/47] build: set XEN_BUILD_EFI earlier
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-5-anthony.perard@citrix.com>
 <2bffd73c-ce1b-40cf-73b7-f988e69c4f07@suse.com> <Ya8/2Dc5yEp/ovf/@perard>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ya8/2Dc5yEp/ovf/@perard>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0058.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6c451bcc-6ea8-4752-b3c3-08d9b974266d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57448494874E6B75765922B4B36E9@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	NPjvX1mqui0FV1ZISEm7YMXyRC7o82PnDDFIt5ZoLuo5NQuoZifn4NXaQSaH7GkE2odGNqeTQOhiL8kUgqkXTfVJNtqNn9k7mnYLkvkOKT3gWSowaHCJ4NWHqH8Qu9o5LIOsFmK4o97N4sgxdP9hGlVISPkVTJm3/ToNiRMAhiEdhEsPqV3wj7lkiC219FFVRiUfFFa+YpWeu3wo4YhlDvYcQEl6B+ujfu+mZbx7i7Y4pXgdQxT/i953N1BPgvlXzIHhieoTEzSyEUDjg9B0s6l5hH76tKy514VkHcU0lc2K+bo25ttgy8CkXZWBffQzzrhAizBi9wlJclejn/T4PxuTzaA/0e1RS/yM30oXIzGDrMlIpje4vpAel99j4U/bdtRM9KpHTORNUOPE+7kg8+EOP6w+Jvqq7dc251w4FAGzyuBe43FJWlEmWrUhNxJvkBAzv55gEspHK1JJVQfy2714TzTKD6DlC5pJ9TYzUtoRl/dQahWTTp5sAKm0rVFTf9DuRF4dgeOy0FFTs8x7quEW8I8msQEbWU8g/3mhRuDOD8T3m/DkirIqUPJgE4up5BZuMrWH8Fw4hcZ3nv1Td2hW5tg6+UsYF+Frj36zGcCctN9EUZtowGH+kNGxSyVv1jj0YgYuRI0SH0TiVAPrDZ5ltUkF1r2SrzHAiy4BxM07egYKK4wun9amyyiLcoZSODSkRvwxFG65kSef2u772qJ+bsZchcoHBToqRLF85s+Jt2idniC+3P1w2CaOzDgQ
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(26005)(6916009)(8936002)(53546011)(956004)(508600001)(2616005)(54906003)(6486002)(4326008)(8676002)(2906002)(316002)(4744005)(66556008)(31696002)(31686004)(36756003)(186003)(38100700002)(16576012)(66946007)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzdPR3dFa1lhTENzVytVT2d4NFMxSXFsa3gyYjZYZU14dDduTnFDTEFEQWx4?=
 =?utf-8?B?T0VldDBXemtpK3ZWNHpsWkVUV3F6dVFXYUlYTDdaR3VoT0loK0RDbTFITHlh?=
 =?utf-8?B?djBBeTg2bVBYTzRsTmE1Tm5HS0I2QXdQOThONXVIdmxxSWRQQ3RRN1o3VWhZ?=
 =?utf-8?B?NzJ3bnpPWmtmUTlObWgvaUl2bGJUamxjeS9CaGZORk5pN3BmTHRKV1FuREdY?=
 =?utf-8?B?b2pTZmRqOFcwWDNwaHFaU2RPV24rYlhiaXJqUFY2SFdwUklvL3FYUFlyZ0do?=
 =?utf-8?B?REh2VU5Ma1hyeFNSR2VheG9TVDFGNjZnZnRQY1g0VDlDTmFWaHBGMXJtYlRv?=
 =?utf-8?B?T1p0VUhrQkJaRGp2TGc1endYaUNlanNwcjNoSitkOUZVaG5HdCszSTZNb3Rj?=
 =?utf-8?B?bGdYRDNLK0ptLzBMSlVXeWh2Mm5kRVFvaElHTWhoSmFtenlUeEMwMlJ2WWhJ?=
 =?utf-8?B?QS9NbFhVbGhwMVpJZHppdTA4VEp5bkJOd2MwTXBZOXEyRXBnWk1WV3Nsd0M0?=
 =?utf-8?B?MGhVMDRHMjdYT2JYcEhZM1hxa2Z3SlZVOXpKdkx2bzNPWjFUV0VsRzQwdEJi?=
 =?utf-8?B?T2NxaG96cDF1alBzUnZrYVI4dUhDWU94azFob3AxWHNmeUdTR1N6TDVWVngz?=
 =?utf-8?B?R0V1S3ZodFFEd1E2T3dmaHQvL3ZBM2xPL0YzUnFmWkpCZ1dTME8ralFkR0NY?=
 =?utf-8?B?SnBPeHdmQTBXd1R1UGZYNHl0VEFyZmE4WWZTcVRadHhYMWh3dzBqU3NQb3hK?=
 =?utf-8?B?djEyNHBpSGdGV21PSWpyN2RmWlVoNFplcTl6MVFDTFpVTGpiUFpkM2R3clkz?=
 =?utf-8?B?QzYreEpReXlOQXh0UW9UK2FhZGZVZkRSSzh5K1FzYmsyeUpwL3lYRHJEWUFF?=
 =?utf-8?B?N1IvaU9oeU1SZzZWenBMWFVsQitsWW1tdlVMUjBvaGtTODM3RlNZS0xtR2th?=
 =?utf-8?B?VW5keC9EVnFMQ2QreWt2QTZkQlRmMmxSS1NFa2NTZ2JlaEd3Tk5NYitPWmhB?=
 =?utf-8?B?TGZ6VG02d3lKSjlrODdha0Vhbm4wMmkxK0xuaWllb2pDWXhtM2tYeHBrTWdz?=
 =?utf-8?B?M21IVVBJY2hNY3FVT1g3bHdOTldFWTl0OXdPZDFlMm1hU1BTNVlRRk55UE1S?=
 =?utf-8?B?dzVkQzYwUjc5cDc2UHU5QlZ5NkJPMUFiMU1OcEJpUnF6RFZJTXc3TUhpaGtV?=
 =?utf-8?B?aDdvQzRpa2FZVXAxZW1pNzhJRFIwMWVDRWkxSXdEcDhqR3FsSXROTjdaanhO?=
 =?utf-8?B?Z1NHTy9MV3hpSXlWcWdJNFNyL3pqUkt0ZGdid1N2bnNaY1R4Zm0vOUFwakxz?=
 =?utf-8?B?QVg2aFZieUEydzRRRU1hYVZqd0RrUnpBT3RiYXE5SEJpL3VWdlMySFRuSjUx?=
 =?utf-8?B?NXRtbmJKZlkzMFRzWFZCeUd5VG01eGpReGtwNldRb04zbmtTVGNtWFhaWXhs?=
 =?utf-8?B?VDl4R0VrM2U0Tit6eStoRjZ2Z0hTVFFvOHRyUG4rdmVhZDFBUFpDWWJDU1Z6?=
 =?utf-8?B?U1FXWDRwNmY0LzQ0ZFpXWkdBcVpPb3BLdUxzTmU5UXQzMVI2bVBKVlQveE9H?=
 =?utf-8?B?eWV1Q2pOaisrWUgxV3dUK2ZCclhzNHdkczlnZFRwZDkrdGVxNUtMdlA2Zndi?=
 =?utf-8?B?TzNmelpxOHJTVFJqT3NSeXZENkVoeFhhOXlBYWZUaWZsQ3FYM0pSK0orYmEr?=
 =?utf-8?B?QUlQU1ViRVJEWGM1WFY1dy9SNDlOQnZVNEhvOG00ZkxFU0d0L2YzeDJrSU1N?=
 =?utf-8?B?OTcxUXJqWVN6dm9UYmZJOFN2YVFzQ282bVJrSFY1SjB0V1E0a2NlNXhxbEM5?=
 =?utf-8?B?MWdPU2xvMkhBZGdjYzZIeUFSQllzOCsyamtnMVRKTnpLWmEzYzBLSm9GMnU4?=
 =?utf-8?B?RFRQanluTGlYdkRjeEJVQ3ZTSjQwSHFPSElST2RSZ2ZkOFRUMVg2R2NTNHNR?=
 =?utf-8?B?b3g4aXRKZlc1UExYejRRblRwMG1RR3pHTldJL092MkJMWnJKSUJsaXpSK1JG?=
 =?utf-8?B?cWN0cXFMWE9lNnYxQlVLZjdTR3hnNk1wTlVzT3ljRHRDanE3YnRObXIzZnZV?=
 =?utf-8?B?OVFMN050M2tML1g1d1lqUmFvMUZTc2V5cVdFT2tSZHp6SDd3QytQOE9zVENF?=
 =?utf-8?B?NTRiM2RYb3ZFSUN1NHMzK0ZxWk02SXYxajBzbVhWSjR5c0NVYjJld2dyZ2pD?=
 =?utf-8?Q?Bqw+fQtiMTDDWXpZ4VBSE3c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c451bcc-6ea8-4752-b3c3-08d9b974266d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:24:36.3073
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fIStp4umCN/dvCkHnfQQS1+yOsbLho5wdLMMSdJOBc6Mm+9kYnODUrpeHrWl6i8Jhd88qtyCZzMAwxp7VEbTLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 07.12.2021 12:04, Anthony PERARD wrote:
> On Thu, Dec 02, 2021 at 03:06:54PM +0100, Jan Beulich wrote:
>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>> +export XEN_BUILD_EFI XEN_BUILD_PE MKRELOC
>>> +export EFI_LDFLAGS
>>> +endif
>>
>> Exporting MKRELOC in particular isn't very nice. I wonder whether there
>> wouldn't be a way to keep it local to xen/Makefile.
> 
> I don't think that's possible. The value of MKRELOC depends on a call
> with OBJDUMP which depends on call with LD which depends on a call with
> CC. And the call with CC is the one I'm trying to move.

Like suggested for another variable elsewhere, besides moving the definition
(which I agree looks difficult to achieve) there's also the option of passing
it on the command line to (presumably) just the single sub-make which
actually means to consume it. It's only the final linking step where it's
needed afaict.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:34:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:34:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240975.417775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYjO-0004rl-Lt; Tue, 07 Dec 2021 11:33:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240975.417775; Tue, 07 Dec 2021 11:33:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYjO-0004re-Ir; Tue, 07 Dec 2021 11:33:58 +0000
Received: by outflank-mailman (input) for mailman id 240975;
 Tue, 07 Dec 2021 11:33:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sjJF=QY=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muYjM-0004rY-LY
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:33:56 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ebe19d4-5751-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:33:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ebe19d4-5751-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638876835;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=n4DyWk46PSHaxgjtXS+uinNibz9uA3IDi75AAOqgJ5k=;
  b=ZIAnsV5pgt6kk4UTQ1Lhd6o9d3SD8IBoMcaFrpk0Fdz5e6CwLrJZg6Cu
   XHt8tXtYveATq9HMyTSAQJSKwTanVeElRhLq7ff/X3rG8/xmaoQvBQ3Vv
   Bt4Lh7qQFvveIBWARx4lwgk3zMkOD72SBkiMBGV+euknSz8PaQAURJ5ip
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JMecT7lzKNVLu3V9t2+51oDmUTHTXK3a4EDfiZodenfTFYZWHNbMz325KtU4bbHaUMn6Xg8pTL
 b+OGqpE7dmq3hVmFl+CwrvomgP14OGnUmCEH2MdRClJPlbQ1NAkP+Lt+GeaTj4G/A4cO6ucpFn
 0Ubbbh+n14UUGCxW7EEYOivY/A42xnLU2iC8LSdH2lyvdNHqTH2GS4IM2PBTlQzlLhOVi4J82H
 5S1wGNQPo8GGFYHc9cbeuaXOpxedG5Tc7UHKLaeB0Y0X4LAYcmMW2cKtEGKYII8ZxYNk5mwB+r
 st9YadJ6BuKZ4k7Dmpq89+tV
X-SBRS: 5.1
X-MesageID: 59387228
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:b59DK69rx3sM7UJ1qTIRDrUDfXmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 DQdDzuAO/aKMzb1KdFyaty19xxX65eAndY2GgJqrXg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh3dYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgr8
 Nh2lLmuTDsRfamUwsdDVAZiGg5HaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0fRqaBP
 ZBJAdZpRDKeM0d/C3c0Mptkh7j4l1TZMB10uWvA8MLb5ECMlVcsgdABKuH9YceWTM9YmkKZo
 GPu/GnjBBwectuFxlKt7XaEluLJ2yThV+o6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIsp6Uv8E2gTvHmQga15nWDu3Y0WsVSO/037hmXzajZ6BrfAXILJhZDddgnuckeVTEsk
 FiTkLvU6SdH6ePPDyjHr/HN8G30aXN9wXI+iTEsFzMI2PjGvoQPtlHLFoxATqmqtNTaIGSlq
 9yVlxQWi7IWhM8N8qy0+1Hbnj6hzqT0oh4JChb/BTz8sF4gDGKxT8nxsAWAs64cRGqMZgDZ5
 CBspiSI0AwZ4XhhfgSpSf5FIrym7u3t3Nb00Q82RMlJG9hAFheekWFsDNNWeBYB3iUsI2aBj
 KrvVeR5vsA7AZdSRfUrC79d8uxzpUQaKfzrV+rPcv1FaYVreQmM8UlGPBDLjzC0zhZ0y/ljZ
 /93lPpA6l5AVsxaIMeeHb9BgdfHOAhgrY8seXwL50v+iufPDJJkYbwELEGPfogEAFCs+23oH
 yJkH5LSkX13CbSmCgGOqNJ7BQ1afBATWMGtw+QKJ7HrH+aTMDx4YxMn6eh6ININcmU8vrqgw
 0xRrWcEkgei3iOedl3RAp2hAZu2NatCQbsAFXREFT6VN7ILOO5DNY8TKMk6e6cJ7utmwaImR
 vUJYZzYUP9OVi7G63IWapyk9N5ucxGihASvOSu5YWdgI848FlKRotK0LBHy8CQuDzassZdsq
 bOXyQ6GE4EIQB5vDZiKZav3nU+xp3UUhMl7Q1DMfotIYEzp/YUzc37xg/Y7LtsiMxLGwjfGh
 Q+aDQ1B/bvGopMv8cmPjqeB9t/7H+x7F0tcPm/a8bfpanWKojv9mddNCb/acyrcWWX4/LSZS
 d9Ul/ysYucamFtqspZnF+o5x6wJ+Nay9aRRyR5pHSuXYg3zWK9gOHSPweJGqrZJmu1CoQKzV
 0+CpotaNLGONJ+3GVIdPlN4POGK1PVSkTjO9/UlZk794XYvrraAVExTOTiKiTBcc+QpYN90n
 795tZ5E8RG7hzorLs2C33Jd+Gm7J3AdV7kq68MBC4jxhwt3klxPbPQw0MMtDE1jvzmUDnQXH
 w==
IronPort-HdrOrdr: A9a23:hn+sQ680YFsSu/J3cwNuk+DYI+orL9Y04lQ7vn2YSXRuHPBws/
 re+MjztCWE7Qr5N0tMpTntAsW9qDbnhPlICOoqTNWftWvd2FdARbsKheCJ/9SjIVycygc079
 YHT0EUMrzN5DZB4vrH3A==
X-IronPort-AV: E=Sophos;i="5.87,293,1631592000"; 
   d="scan'208";a="59387228"
Date: Tue, 7 Dec 2021 11:33:50 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 11/47] build: fix enforce unique symbols for
 recent clang version
Message-ID: <Ya9GnjMXU8YNDP3x@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-12-anthony.perard@citrix.com>
 <6b92c237-9ca9-813c-615a-74a2f3e858d3@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6b92c237-9ca9-813c-615a-74a2f3e858d3@suse.com>

On Tue, Dec 07, 2021 at 11:23:26AM +0100, Jan Beulich wrote:
> On 25.11.2021 14:39, Anthony PERARD wrote:
> > clang 6.0 and newer behave like gcc in regards for the FILE symbol, so
> > only the filename rather than the full path to the source file.
> > 
> > clang 3.8.1-24 (in our debian:stretch container) and 3.5.0-10
> > (in our debian:jessie container) do store the full path to the source
> > file in the FILE symbol.
> > 
> > This means that we also need to check clang version to figure out
> > which command we need to use to redefine symbol.
> > 
> > I don't know which version of clang change behavior, we will guess
> > 4.0.
> 
> When I did this earlier work, it was clang5 that I used. Which would seem
> to mean the change in behavior was in version 6.

Thanks, I forgot this fact. I'll make change in the patch, and replace
the last paragraph of the patch description and add something link this
instead:

    Also, based on commit 81ecb38b83 ("build: provide option to
    disambiguate symbol names"), which were using clang 5, the change of
    behavior likely happened in clang 6.0.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:36:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:36:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240981.417786 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYlc-0005Sx-2E; Tue, 07 Dec 2021 11:36:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240981.417786; Tue, 07 Dec 2021 11:36:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYlb-0005Sq-Vd; Tue, 07 Dec 2021 11:36:15 +0000
Received: by outflank-mailman (input) for mailman id 240981;
 Tue, 07 Dec 2021 11:36:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xxIL=QY=ellerman.id.au=mpe@srs-se1.protection.inumbo.net>)
 id 1muYla-0005Sg-Br
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:36:14 +0000
Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de24b362-5751-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 12:36:11 +0100 (CET)
Received: from authenticated.ozlabs.org (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.ozlabs.org (Postfix) with ESMTPSA id 4J7dXf3dSsz4xYy;
 Tue,  7 Dec 2021 22:36:02 +1100 (AEDT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de24b362-5751-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au;
	s=201909; t=1638876964;
	bh=lTsXMkBa68SdK2mCmwfpSshAWpT0dRMMMq4RDsTmMUc=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=BMwzDWkPEIYhXynBVAirAw4gLvuuvW+w979j7Yqtpl/UPXPORphUfbt+jK+l0pabP
	 GTehyWDzuL/CjvtZ3vJKYoj5rsJPb1bnDWny7P2YlVPjCcML69cHmHBNG0AIDWe7Gz
	 7IRiJMIJ4Kb9b5hGDoNDnHaxCTClNUWIJdKvD1WISOHxae57UeEHW0ELnQ3BY1ByPF
	 1oPzO4gyeKDsiFe+zukx8HTbH7jtndcbjgt+u2Img9ev7FSfwZJM9PLRYWX7kshjFe
	 JBwE+rXxecauzokxEZQ57uU9ynC6VsB3Nd14q1sEiH2ivRH0Hx8EhFL3DwxqA8pymw
	 p3ZiZsIoOoIIQ==
From: Michael Ellerman <mpe@ellerman.id.au>
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, Thomas Gleixner
 <tglx@linutronix.de>,
 LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>, Thomas Bogendoerfer
 <tsbogend@alpha.franken.de>, linux-mips@vger.kernel.org, Kalle Valo
 <kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org, x86@kernel.org,
 xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Wei Liu
 <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org, Christian Borntraeger
 <borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never
 worked
In-Reply-To: <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.872249537@linutronix.de>
 <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
Date: Tue, 07 Dec 2021 22:36:02 +1100
Message-ID: <87ilw0odel.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

C=C3=A9dric Le Goater <clg@kaod.org> writes:
> Hello Thomas,
>
> On 12/6/21 23:27, Thomas Gleixner wrote:
>> This code is broken since day one. ppc4xx_setup_msi_irqs() has the
>> following gems:
>>=20
>>   1) The handling of the result of msi_bitmap_alloc_hwirqs() is complete=
ly
>>      broken:
>>=20=20=20=20=20=20
>>      When the result is greater than or equal 0 (bitmap allocation
>>      successful) then the loop terminates and the function returns 0
>>      (success) despite not having installed an interrupt.
>>=20
>>      When the result is less than 0 (bitmap allocation fails), it prints=
 an
>>      error message and continues to "work" with that error code which wo=
uld
>>      eventually end up in the MSI message data.
>>=20
>>   2) On every invocation the file global pp4xx_msi::msi_virqs bitmap is
>>      allocated thereby leaking the previous one.
>>=20
>> IOW, this has never worked and for more than 10 years nobody cared. Remo=
ve
>> the gunk.
>>=20
>> Fixes: 3fb7933850fa ("powerpc/4xx: Adding PCIe MSI support")
>
> Shouldn't we remove all of it ? including the updates in the device trees
> and the Kconfig changes under :
>
> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
> arch/powerpc/platforms/40x/Kconfig:	select PPC4xx_MSI

This patch should drop those selects I guess. Can you send an
incremental diff for Thomas to squash in?

Removing all the tendrils in various device tree files will probably
require some archaeology, and it should be perfectly safe to leave those
in the tree with the driver gone. So I think we can do that as a
subsequent patch, rather than in this series.

cheers


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:37:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:37:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240985.417798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYmi-0006il-D9; Tue, 07 Dec 2021 11:37:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240985.417798; Tue, 07 Dec 2021 11:37:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muYmi-0006ic-9Z; Tue, 07 Dec 2021 11:37:24 +0000
Received: by outflank-mailman (input) for mailman id 240985;
 Tue, 07 Dec 2021 11:37:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muYmh-0006iM-EL
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:37:23 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0ab7f1f6-5752-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 12:37:22 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-C9fm7nQeOI-h0Avfzz3IjQ-1; Tue, 07 Dec 2021 12:37:20 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2702.eurprd04.prod.outlook.com (2603:10a6:800:b4::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Tue, 7 Dec
 2021 11:37:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 11:37:20 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Tue, 7 Dec 2021 11:37:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ab7f1f6-5752-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638877041;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=AZpKi1AAiUKueAsqNoBd+0b0NR6mJhQN10Qky2HmwjY=;
	b=Wq6BhVb5kTldqe18S0ryB8dfSuMEybO7lLhLLFDAjbFYbWb/RgDiWjoq4uvuHBZ+LSmXdL
	nPe48V58iC9tIqWQ3BPeVzX0vhwXhyQkWGR41ilSNmFQmX6yQPT11e2yX3n9vTKBf4lnOO
	xSyseJJzXiPhIe8k8vzJZB9NlzDpH+w=
X-MC-Unique: C9fm7nQeOI-h0Avfzz3IjQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JQz8AkoUrZ4GQcXGxEoah6frmcZ38gNLVFuWe1KGCwf5oh4AWfUbOdg9Pv0DIYwDD+tja/n5NBuiGyMZ+6FN1P0IMJ1rqAJmyvC49fwZByOEK270f6SbnF2wt6b9kWBS7+yfsGKsRZ1YzQ06QytCs7Rp6Xkao4Fx+Jex87uV5/u0Ur1SUpLVCIU55lG/5G1kFHVbKuiTxzsuX7lMN6PHUhtyVHrbLuZoAfZ3PJp3KNgBdL1RD2swXDxs0ZzaLGJ1TeP3BEEgjZkvSufbQLQEp+TpLTa4TeTHeeCttEpirOBFp0kSkO5PWTZRM5DYpZpacVTcWuQnH0IJ9IXgydN9Wg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AZpKi1AAiUKueAsqNoBd+0b0NR6mJhQN10Qky2HmwjY=;
 b=EvS3+FAKTr5U3E6nha2CRFsBbIxvgAJvZ9wtx8t3e//zbBYt3K7kIPjn3cV8Eq3hNamLdHVpt/OCSuRzknYUjxmCxwR99pnq3/0s7F4wG8zFZCqJc5m8bEZnCszRg42W+i3arvUu6NOztb7ORLjnoQABmwiRZwkjRlOdJZwIE5y0NFzNU6KZIc9QhXc01R7jGmvKAtz3uwQ7bk4gAkSmmyJqChlVI4b8+VIfTlg2OhKVbkC9EGNO3uqLO9jVOq3U05TGDOQ/Dqp/Y5IyITsmbDSClJW+Hx70bgOyG9Tw4OK81Z7AXN3CnTRbYXahWP6+KQ6/noug+G2fhpJAlVLqxw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dc3f5bf2-53f9-7dcd-2be7-f9f953b382cb@suse.com>
Date: Tue, 7 Dec 2021 12:37:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] x86/boot: Drop pte_update_limit from physical
 relocation logic
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211207105339.28440-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2b8b34e7-97b0-430b-ea10-08d9b975ed9b
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2702:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2702FC96238D77FA040E6A87B36E9@VI1PR0402MB2702.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Sj4wx5ZHzwhmmsvJ7Doke5wwxsTJhN8H8dVOW1SKD0oOUgGOubzrMoLK+r7q1ZwugQy63TtJr10G2hUoAHPD9pSaqXcU6mwGZFB5mpuQfq/JfMIieRY/B3cjCCCjCykAbgX4+ZY5YFy57Jv+u56VH4k+y7Qwv7CnI5ecl1MWdZuxk8ooxoKUFje9b1xdp06SC5o0P12kKuVvsy6HD5rj31R7nEowUw3+53KZnU+YGg/Z06wodl06lUYOn3fltkVpF6J8k9XOjdqozNIBRVE9+Pol9839hmLoWp+8YIXHT3ZAak/xnIbQnuG5703s+dhNtCP4xiWW98lwZO5BkBowvdSFeRirhj5HBd3GclAtRMfeWDLOLDZETCG8s4fzhqJmAfGzOHrM+4ajSf7BVDSMPhRihzff1rYEo63is8i1+bP0RZJxL5iJR3s1SRoPGM9cgZf+z9InlgUEL58HZEvUN6f42NGVf6ptu7/xP15AJworqD+oQRy3t/QwPId19ddAVXLBBExgRvjyK0Ceth3D755nDkKWtbZZlZTrr0dRx+fRrHYhc/vhZmbtPcr4dtrqWVv91Rs6IJ+x4TOU6oWDPE6E2j2tnljg3b0IHnGYwy/ra/SAj/GZOz7KcUCvCChHnML6c/mjD01CkQcTn0865jPw79Gt1SwOpx38EcIH6YnNsHVCQv3kjffL+iRIpeKya6h/2qp1HFoBugyN2JZSk5uohOQR3FIjAqyulInUGsw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(8936002)(66556008)(316002)(8676002)(6486002)(6916009)(31696002)(508600001)(54906003)(38100700002)(5660300002)(956004)(31686004)(2906002)(2616005)(53546011)(4326008)(66476007)(66946007)(36756003)(86362001)(186003)(83380400001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZGFmVzZIMHBNTnZTWFZJUWsxZXdFWGw2cnlHUzUrYS9XcmRqT2RvNHFDUHNv?=
 =?utf-8?B?T2EwSUVPVUN5NFNwcjBxRTFPalhONG9vZFUzTlpMbE9zU0RwYlk0c1NobHNw?=
 =?utf-8?B?c2d4V0UzVmp5QU9NeTJRQVBKT0srK0diZFFDcjJHWnYya2hZNDhaZU1aM3Jj?=
 =?utf-8?B?QlRWenlvdUZSZ1J5RUJTMzdGN3ZKVXZRZUNFRzZNa2I3NHJNTVY1dDlpZ25Y?=
 =?utf-8?B?SnFzanpBR3hQbklBUHo5SE5CU2RDOVZ4SStQd3Nad2xXN1pSTFZHbWlJTmFC?=
 =?utf-8?B?THE5cHZUM3lPVCtuU3lRUExoS240eUJsZEN5RWt0K1Q4dHlyVURMejBML0lw?=
 =?utf-8?B?U1V0YS9uSkxQSzBOVzVYSU4zLzk3c2RrT25mRkVDV2M1TmFjd1VGWkFVRC9h?=
 =?utf-8?B?TXAxMXBVYXRxSSs1R0k4ZThkNVJGTzNVWE5wb3hwOStpc2RLV2pqQjdqRDd1?=
 =?utf-8?B?R3pIdjBuKzliTG9tUms2YnhZcU9wVklKd0JOb2lGbkdBRnJ6ZHNwRkVwYVlG?=
 =?utf-8?B?NVVVT3A4MWRVb0V1TGJWdmIrcFlDU0FkaGcyQ1gzVCtMSmxiWXdzOEwzb0ho?=
 =?utf-8?B?aDF4NnJiaEcyZFkySUIrNTRxTkdQZU5Cd0lHT2haSzhSajVHTDFBeUZnVXgy?=
 =?utf-8?B?a1M3UFMrWm5SdnhmZzZvRExYam1RRnRaSk5CSjhzQ1V3RDUvWnRuaFRSQmlt?=
 =?utf-8?B?Y21hMkE2Q2JyUWROT0tVbyt3Y1FkQmFtYUdvVFM5WldQTEhiVm5nMW9kbS9Q?=
 =?utf-8?B?eUNIZ3VXN2VCZnhJZHYreG5ZKzg5Q0NKVEdVRTdCd3pWUU10cnhocGhiN25D?=
 =?utf-8?B?dnp1UEhBbDhZNllHcE8vTXNmbWh0b0EvbnlGYU0rMHBaMTB4aGhhNU0raGpR?=
 =?utf-8?B?L2EvUlRyUGc0VVdhT0RrUUlKR0VGeGM2Q2NZWk9sZkloSHZTTEVOc3BrUW9X?=
 =?utf-8?B?S3Jpby92K1F6UzN2WWdyRzV1c1BJRWhybmlZOEFaWS9IeERwS21NbjlNaHJm?=
 =?utf-8?B?QXg2bWl0U1FBdHdqd1dRT2FpcUJtZGp4NUhnbGdSQys2TjRuU2tPWUljYkZ2?=
 =?utf-8?B?QmdnYitOZyt4YkM3OU5uRVpaWkFMWnB6c25YcjNzZ3AyY094VlpiWDV1a29R?=
 =?utf-8?B?amtXQWdVMFhiM1hySFZCcDgxRVhXWllyVlR2K0gvblp1MFJITlRCVVRlVVp0?=
 =?utf-8?B?MTQzc2J5VUlvSk1qQWQrYityV3NDRzBtQ0JXVElaUm5odjNLbVBJZUVIQ05q?=
 =?utf-8?B?dzlhVE9wa3NiQ2dNSzFsSmZLcCttWDduNVY3d0p3SlozNFdFOUpySjdWOWF2?=
 =?utf-8?B?S2lQbHdmK3ZXcFdwU0lFdkxTMzNGaU5GcmhYQzdxa1FINWZuWm9BWks0enVt?=
 =?utf-8?B?aXcxYUIzTlFTcWx3R0F5RG5STkZGMDlYZEFPR2xCVHQ3clpBTnpxNHBSeGJm?=
 =?utf-8?B?Qm5QeTJHRlNTQmFqMTMrRVpTdS9vbGgxaTdtcWNIZkJnMUhjekF2SVlpaU8z?=
 =?utf-8?B?aHlvTmN3UURPaFY1MEZmWFpJUFhTemdocnlEWk9OT1I3M1VRWmtIMVE5QjlG?=
 =?utf-8?B?VzFjUFNuQzhVRGxjTWdETElBUlBsUzBZMEh4eUFYbGdtQ2dPbUNuUHVtaWpw?=
 =?utf-8?B?R1VIV2didkFNWlBaWGlWUjYveGlXc2pEVHZpMTF1WitLTHV6bUdaNnE3UjBB?=
 =?utf-8?B?T2pQaC9rZXhWTzhzZjh2SmdhYU5kYmpKL1QxVEZvS1BBdngzWFNIUXlSYWZL?=
 =?utf-8?B?TTk2OHpTbThMbHFLLytOVkUvOGpUcjlBVCtLWWVjSG50WXRuVlZFaytqcWRs?=
 =?utf-8?B?d1N1bmV5dFBnR0FsYXczTnl3cXp1aXUwVWgrVjFSaTVCOHJENENNQS9adFM3?=
 =?utf-8?B?WGFtT3pXUkZ2c1NqU0U5bGZESDNQYTBtQTN2VU1lV1NoMXVZeFMzS1ZwcURz?=
 =?utf-8?B?b2h1eEszSFlWMXFSaDFtVTg0Nm5KMzZnQUlrcjJoODJJMEdYZmhrNjFwZ3A3?=
 =?utf-8?B?UVB6U2JTNWp0N00rUVQ5aWdOWStMZXdTK3NYcTRzTEo4RnZKTEJURzZ5TXM1?=
 =?utf-8?B?TmpZMzM2c0pGRkxla2ZpQkI1VXI5Ky9UbWpzWFZKeExOUEVkc3dYay9LcmN3?=
 =?utf-8?B?cEcybngvYk44eTJMMmIyODVRR3ZWaWwyZUQweVdrTmNlK2UwN2NibkI2UEhL?=
 =?utf-8?Q?txhd/Gw+gUIhctysCqowQyE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8b34e7-97b0-430b-ea10-08d9b975ed9b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 11:37:19.9855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: et2J5u4SqqD+iGVyPo+IHQMObt7PT//ZwYlIWwLjiHL0JCx3qOzP4MWXSu7Y5wJcytnWIroKGeTNWqUStzhTCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2702

On 07.12.2021 11:53, Andrew Cooper wrote:
> This check has existed in one form or another since c/s 369bafdb1c1 "xen: Big
> changes to x86 start-of-day" in 2007.  Even then, AFAICT, it wasn't necessary
> because there was a clean split between the statically created entries (L3 and
> higher) and the dynamically created ones (L2 and lower).
> 
> Without dissecting the myriad changes over the past 14 years, I'm pretty
> certain Xen only booted by accident when l2_xenmap[0] was handled specially
> and skipped the pte_update_limit check which would have left it corrupt.
> 
> Nevertheless, as of right now, all non-leaf PTEs (the first loop), and all 2M
> xenmap leaf mappings (the second loop) need relocating.  They are no unused
> mappings in the range, no mappings which will be encountered multiple times,
> and it is unlikely that such mappings would be introduced.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

However, as to the description and ...

> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -1230,7 +1230,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>              l3_pgentry_t *pl3e;
>              l2_pgentry_t *pl2e;
>              int i, j, k;
> -            unsigned long pte_update_limit;
>  
>              /* Select relocation address. */
>              xen_phys_start = end - reloc_size;
> @@ -1238,14 +1237,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>              bootsym(trampoline_xen_phys_start) = xen_phys_start;
>  
>              /*
> -             * No PTEs pointing above this address are candidates for relocation.
> -             * Due to possibility of partial overlap of the end of source image
> -             * and the beginning of region for destination image some PTEs may
> -             * point to addresses in range [e, e + XEN_IMG_OFFSET).
> -             */
> -            pte_update_limit = PFN_DOWN(e);

... considering the comment here: Isn't it 0d31d1680868 ("x86/setup: do
not relocate Xen over current Xen image placement") where need for this
disappeared? Afaict the non-overlap of source and destination is the
crucial factor here, yet your description doesn't mention this aspect at
all. I'd therefore like to ask for an adjustment there.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 11:58:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 11:58:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.240997.417809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZ6B-0001vc-0q; Tue, 07 Dec 2021 11:57:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 240997.417809; Tue, 07 Dec 2021 11:57:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZ6A-0001vV-U0; Tue, 07 Dec 2021 11:57:30 +0000
Received: by outflank-mailman (input) for mailman id 240997;
 Tue, 07 Dec 2021 11:57:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=OKah=QY=epam.com=prvs=2975342c15=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1muZ69-0001ku-3v
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 11:57:29 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d79fbde4-5754-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 12:57:26 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B7Bd3Q1010756;
 Tue, 7 Dec 2021 11:57:24 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2058.outbound.protection.outlook.com [104.47.10.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3ct6x101hr-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 07 Dec 2021 11:57:24 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5555.eurprd03.prod.outlook.com (2603:10a6:208:16d::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Tue, 7 Dec
 2021 11:57:22 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4755.022; Tue, 7 Dec 2021
 11:57:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d79fbde4-5754-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ar7EG6UD5wfpmWeMTL/fP7BdvRH1V8BeB3CV98V3Ae0WPOi8z4uEW3XLr30l+iM6zJcfzNmU6Xe/JvbU9eKGw4Yv76nGokocnRUgKYWrKcuW6u0ZIpnFiUox/rvZ72nYN10GsITrL2STYB/BNePBIWdw76fTIAKx7PKBSziaRM29DUslNn6T3Gf/DG4XryzsmsYwON5eK/vBySOwCcyYVMzOqZ9y0/+IZbDqn2VVp89+f3/LrPF1KHoTvl2mZs72cKrKL9Zrgoom2uYJ+W4C4JiG2RL5w/WVFU83RHlboR6yGKpwL7zsjdCNMuQc44T2FfMc5nOD1zT0aAYxIZYDEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R+uVZrKrMoJQNPYI7pEcBjSwj1UO9ayYaPE3qsnRnV0=;
 b=gU8j1qbnnZiYueGqcpg7ixwHm1u1prXRSEWnVOdN1BJIpnsMHEu7RPuvExzmX/m6DmiiO36pJliiiJuHkyX6XxNuYY8pCI5x9g2vz3shzQcTkAuIf9zlRFyPCYCdv1cU1G1gj/u0GYOQK1dKS9il+kXLdyeb/NWv7P7i81n40XHJ4zsoes+Nmfv3SRTedqdHm8oChJw79bQhDn7JTk0qQxTQ+WHzQjtt/q3LHlUw0V1WWa2rnNU8qZpwpPBr5KsfOicdW8lMT+PPCzkdG0MG3p8gOpeGlgEFftjetHkdhmsNdRweQgR3YoLchEXO4t5KbaDMEHM4G7/9CNkRu6Haog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R+uVZrKrMoJQNPYI7pEcBjSwj1UO9ayYaPE3qsnRnV0=;
 b=V9pzz+AJB6Ox6UJ85IBI3+pHS+B898uWW8bvYwpHJtmQNICdsc8WUkFFep4tXKT+I/6nVJKBgvAoB02ome3T9A8iHN+vnc7Vtyzaq280yDDjX3k3oV+KTCIH9TveaTq8MIcYhmF9X71/bl0+aYG0id076WsqEWYxaaNnuSkJC9IpaXlFVvvPk8LE8q1fzT6ZEPBGHw2u538glH62M+440msNanTHPfUO+1+2eausr57hhA5O1y4eEGf1uiC13u6i/KnNzAwx4n558GEalmfwPyqMJLcj1+1s66jpxj4RYWzWtvnzkJ90svxYVNezbmOf7n8hAg+uruRuTDGk2L3fQw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
        "paul@xen.org"
	<paul@xen.org>
Subject: Re: [PATCH v7 6/7] xen/arm: process pending vPCI map/unmap operations
Thread-Topic: [PATCH v7 6/7] xen/arm: process pending vPCI map/unmap
 operations
Thread-Index: AQHX4QlHq5TbYMxegEi8AUrpiX/8ow==
Date: Tue, 7 Dec 2021 11:57:21 +0000
Message-ID: <be0d06fc-f024-73c3-8b0d-59bc8791312e@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-7-andr2000@gmail.com>
 <9647b586-e325-0d3a-3369-e3b13e45af9d@gmail.com>
In-Reply-To: <9647b586-e325-0d3a-3369-e3b13e45af9d@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 59cbc017-bb30-4873-0fae-08d9b978ba1d
x-ms-traffictypediagnostic: AM0PR03MB5555:EE_
x-microsoft-antispam-prvs: 
 <AM0PR03MB5555309144CDC3079531F1D6E76E9@AM0PR03MB5555.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Xv6ew6+BTuJS7eu2Rj5GhUNROHr0eBR4Xc/MYZjJZUa/a6CgVoosrpcHwT4JypQv+c5GMmpq7/4DYpzvFVbPJXzGTrwEXnB7/6s8a/x+otNptl8VOcwBAyxnb5CNLzSoS8YQwuHETwD/sC2INP5vNyt4tVJVIXG0ipSWFAe09PRiKZ7/4O29lsw6uZ0Qm0a5HbRhjCRcEfriFzB7yEoMxTXNxnMNr61v9WKsDkxbZI+hORST1TMjvmySqVwWVaLQSqp7ESszbJ0J6ekTKxnKZCYQaKUihqT+jksm8AYs4cc8lnY1mCHWoj0E401AYY4FqyLncjUfhPc2L/kfB2JBX1oThgA3C5L5VwHHV2ZSYUhTcXEn/GPkGQbAgfnsWQWrVsOKKhQd3htWV2ZJ88nqWlqkY0qFr/5diRzoeEFEECjgnNCwkyC6QRYFYTVz9lYuOK+TZO9taL0my0Gbxoii5bX/efx+ZcA5rVf3RobSplh7ALF028oPUYBtESSmXopXk69bI6rI2XVLX8n+2k679jG1ji+aeGAudOXvIx/mt6Dthqh+N27tIoxtmgPGNRSOh+yaaRrxD5vpA2+i9m+UcqdoYV+9q9R91J1sx69G6zaOQPlMzpM7aN7nG1O7ViACJb/lZA+ghAZwCuBooDFicVKXR2tBQjK1coaAbrUFWx3nNmMQ5s/ez5TQMIuCZr1jPYcXFIeXfXUA4kVY7i38RgG98TBGxeB92TNP37ro3ffbZRLoJ/QljlCAJJX5cHWB
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(5660300002)(316002)(66446008)(508600001)(31686004)(6506007)(36756003)(66476007)(76116006)(91956017)(122000001)(186003)(64756008)(8936002)(55236004)(66556008)(8676002)(53546011)(54906003)(26005)(2906002)(38070700005)(83380400001)(71200400001)(31696002)(86362001)(2616005)(6486002)(66946007)(6916009)(4326008)(6512007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?a29mbzdSdmpiNEZoZVkyazU2dUtHbjFhVUtCdmh1Zklsc1hvblR1eXNtUEY4?=
 =?utf-8?B?V3BueTNoeHdIRmlHT3AwMUlIajB6UDVRbEhXcEpUcnh5R0hqcHJYZFY0ODk2?=
 =?utf-8?B?OFhVZGMrZnZVSjJ6emJCRFkrS2N2dERld2g2ODIyMVdpYk1PZEJteU5oY0NL?=
 =?utf-8?B?SjNuRXdKTFc3TjJDbXc0NzhvSXJYTnJZd2dTUU1XUmoyVVhReU1iR1F6OC9j?=
 =?utf-8?B?WkRrWHlQRG1VejNDU3dHMnlaemhZVFV0RDA4Wm1DNGdub1VkemdVZTl1Ym9K?=
 =?utf-8?B?YkhmQlpIM1hiUmZBMkc2OTEvckVUOXV6M0lkbEZ0bTFxNHd6TVd6SjUyQnls?=
 =?utf-8?B?Y2JmNWcxQzdiV2I5N3BRSkl5UExwMHJ3MFR3Q2pLRjNBc2NnVGxJT0lJMmp1?=
 =?utf-8?B?bVB1UFRJSVlTVDVFdGRsY0Q5b09VUm9xTUVMU1lDWDBTNmVDY0wveFhEbkl4?=
 =?utf-8?B?M3NxdkhBalVTWnI2S1J1bnFIYW02Q1NmZmlPUzRFRFY2dmdiUkhzTFdJelZC?=
 =?utf-8?B?Ty9zTjUxRHlpcUYyOUpzS041MU1sdDd3ZXZqOU81RVJ5QUFQM1c5K3RJdnhO?=
 =?utf-8?B?VE9uWXpxYlQ0a04xRm8xTW1TK3NUUlc0eWZXSnBZdFlpNlN2d2ZnMU5qUEJs?=
 =?utf-8?B?TGp6eUx2M1c0bmVaSjR3WWUvekNFRVNiT0FKbDdwQW1vZ0pyN2R6aEVMSHB0?=
 =?utf-8?B?d1ZrT0ZKQnM1SS8zUmZrQUovOVFZK1RqbUF2RWVwOGI5Vmd1d0JFbTZXa04y?=
 =?utf-8?B?VXpNdkNkcnpDaDdwbVltNS9GanphRHg2YTJoK2Q5dDhSTHhCdHVjbnpoZkN6?=
 =?utf-8?B?OEttN0FNRHVhZnQyQ3FDYk4wblFSN3pYUkNuM04rNTR2aTEvdW9ZTkhJNHBL?=
 =?utf-8?B?UXNFWldGL1RmWUE2OUgxWC9hV2ZGVzJjQzRsOHlBbndLcUZwR1lhUTRNQ01L?=
 =?utf-8?B?OVVMRVhubmo2T0RmMFFCbG9sdUtKWE5RNnZUZXRyWmVlVjdJODMrVzQyUU1r?=
 =?utf-8?B?T0RRaUFzL29Ja1JDQUJwYU1sQm5lRFFyMkJNdzVsRGxJSnpyb0VmeTZFVkJp?=
 =?utf-8?B?dTUyYTNrZVhZMmF4MHR4cm9SbnB5eDh6YmhDbEZIZ2hkUEpwT3lJMWxFaWlX?=
 =?utf-8?B?RUFURm5UTFBqamNEMjg0MFo1UWx6VTZIMGNsZno2SHNBcE04TlVLUFNydnlp?=
 =?utf-8?B?SEF3TFZpY2hObmpNUzJXSmFlMGhlS05tOWFPYThEOWZSWDYzQkorZGozSGov?=
 =?utf-8?B?L1dFaGlOVkx0TTVGZGwxMU5iRlQyWEhDZ2svazJVNDRsOGxSL2FIWitwQWV0?=
 =?utf-8?B?VHVVTUQxd1NmK3poRjhiTnhJN2RZZTRUTFp3Q0RpUW5CczZ1SklJQUllQmx4?=
 =?utf-8?B?YkNZSExSUmR4U3JRaXI3SkhJejk1ck1BWVRuNjlsa2psM09KeldLRVdkcFR3?=
 =?utf-8?B?VEdmTStJYmp1UTJvSWhrQnQreU1VZVQxckZXNG0vUVExakdhNUtHVnlWcDFq?=
 =?utf-8?B?K2dkdzJ0OEhRem9ISmVCZEFGOUlpa1p5dVpWbURnVkg2c2t4cXg2a0RyOUxl?=
 =?utf-8?B?cy91MDVLSmlPbWVIa1hPaWRCUTNUakZqOTY3U1VQa0M2NVZQSjZocHlsVDI5?=
 =?utf-8?B?UVE3V243L2NPOVVvRjQ3bmgraUxMWWk2SDFTYk5OYnRqK0RCUDJZdEl2YmFS?=
 =?utf-8?B?bTNGQ0wzb1Y4MWpyTzNucjh5MjEwdnhWMUYvQ1BIQWVaLzlzUFBPeDlScHdK?=
 =?utf-8?B?cFFwWlpoOVBITFhHVFlDOGZza0hEbHBaOXVTWVh3czNuMHh3ZDhGR3NwUytU?=
 =?utf-8?B?U00yYVB3Z3YzUkZFUG03eFppSWhIV0dJd3pJNzJXeUNUNExjZWFqL0JhWGNN?=
 =?utf-8?B?Q2Z0dkx1dTlHc29JUFRlbml3eWJjRFE5L2RtMXFqdms0dCt3ZEo4ckYrbGZz?=
 =?utf-8?B?NzU2NHI1ZGpxa0RzU3p0WFZnZW1QZUZyMEFWZmc2aGtoS2I3ZEJtd1RGaUR0?=
 =?utf-8?B?RXFsVlk4WSs2QjV3Zi8yaGlua1FsSDF0aTZnNkFKWXFrOTFSY0dwVmQrQlR5?=
 =?utf-8?B?a1RzS1dEUE03Y01QWEF2V2NXU2FQZEZSdXR1em9pcFFiWXRrVCtQQk1XSVV2?=
 =?utf-8?B?ZXpZcGJxeDlCTmxBeGZPWHAzSCsvTFlxbUcydGZhdVR3Zm52RHdFMWtDbHJm?=
 =?utf-8?B?M3dPby9ZTVJ1bDJWSHpQQ25RSCt3VDFNbXlwN01DRmt2dTN2SUFOaE8wblhL?=
 =?utf-8?B?engxa0JsbUxvNzJXZW1SRVFHQ0xvQkNhemFiYmtMZ0JhbE56cFd5MWNWekZT?=
 =?utf-8?B?Uk9zNHJ4c3pGNkRocnkxcDNucGhqdTlhdnAvaTJLejE5bDdLdnJqZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <33E3C92516B21547827CE9D67DA315EF@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59cbc017-bb30-4873-0fae-08d9b978ba1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2021 11:57:21.8691
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XX325E9csOg5Z/nb4/X/RfeQFPJHXkQMCenC6go8UvsZRVVWe2KCC35bYkknzwMzMTnT6IpY0sBSUkH8sYU81bIoGrJvHQSQEWkojMeuULbhvHEsNkNFJvZgTguXHPCg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5555
X-Proofpoint-ORIG-GUID: QqFuxuJKViYa3ziMlkfxv92aWIwzVazk
X-Proofpoint-GUID: QqFuxuJKViYa3ziMlkfxv92aWIwzVazk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-07_04,2021-12-06_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=709
 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 mlxscore=0
 bulkscore=0 priorityscore=1501 malwarescore=0 clxscore=1015
 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112070069

SGksIEp1bGllbiENCg0KT24gMDMuMTIuMjEgMTg6MTAsIER1cnJhbnQsIFBhdWwgd3JvdGU6DQo+
IE9uIDIzLzExLzIwMjEgMjM6NTksIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4g
RnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVw
YW0uY29tPg0KPj4NCj4+IHZQQ0kgbWF5IG1hcCBhbmQgdW5tYXAgUENJIGRldmljZSBtZW1vcnkg
KEJBUnMpIGJlaW5nIHBhc3NlZCB0aHJvdWdoIHdoaWNoDQo+PiBtYXkgdGFrZSBhIGxvdCBvZiB0
aW1lLiBGb3IgdGhpcyB0aG9zZSBvcGVyYXRpb25zIG1heSBiZSBkZWZlcnJlZCB0byBiZQ0KPj4g
cGVyZm9ybWVkIGxhdGVyLCBzbyB0aGF0IHRoZXkgY2FuIGJlIHNhZmVseSBwcmVlbXB0ZWQuDQo+
Pg0KPj4gQ3VycmVudGx5IHRoaXMgZGVmZXJyZWQgcHJvY2Vzc2luZyBpcyBoYXBwZW5pbmcgaW4g
Y29tbW9uIElPUkVRIGNvZGUNCj4+IHdoaWNoIGRvZXNuJ3Qgc2VlbSB0byBiZSB0aGUgcmlnaHQg
cGxhY2UgZm9yIHg4NiBhbmQgaXMgZXZlbiBtb3JlDQo+PiBkb3VidGZ1bCBiZWNhdXNlIElPUkVR
IG1heSBub3QgYmUgZW5hYmxlZCBmb3IgQXJtIGF0IGFsbC4NCj4+IFNvLCBmb3IgQXJtIHRoZSBw
ZW5kaW5nIHZQQ0kgd29yayBtYXkgaGF2ZSBubyBjaGFuY2UgdG8gYmUgZXhlY3V0ZWQNCj4+IGlm
IHRoZSBwcm9jZXNzaW5nIGlzIGxlZnQgYXMgaXMgaW4gdGhlIGNvbW1vbiBJT1JFUSBjb2RlIG9u
bHkuDQo+PiBGb3IgdGhhdCByZWFzb24gbWFrZSB2UENJIHByb2Nlc3NpbmcgaGFwcGVuIGluIGFy
Y2ggc3BlY2lmaWMgY29kZS4NCj4+DQo+PiBQbGVhc2UgYmUgYXdhcmUgdGhhdCB0aGVyZSBhcmUg
YSBmZXcgb3V0c3RhbmRpbmcgVE9ET3MgYWZmZWN0aW5nIHRoaXMNCj4+IGNvZGUgcGF0aCwgc2Vl
IHhlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmM6bWFwX3JhbmdlIGFuZA0KPj4geGVuL2RyaXZlcnMv
dnBjaS9oZWFkZXIuYzp2cGNpX3Byb2Nlc3NfcGVuZGluZy4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5
OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5j
b20+DQo+PiBbeDg2IHBhcnRdDQo+PiBBY2tlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1
c2UuY29tPg0KPj4gUmV2aWV3ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+
DQo+DQo+IFJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4NCj4NCkRvIHdl
IG5lZWQgYW55dGhpbmcgZWxzZSBmb3IgdGhpcyBwYXRjaD8NCg0KVGhhbmsgeW91LA0KT2xla3Nh
bmRy


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:01:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:01:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241006.417819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZ9e-0003PT-Ql; Tue, 07 Dec 2021 12:01:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241006.417819; Tue, 07 Dec 2021 12:01:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZ9e-0003PM-Np; Tue, 07 Dec 2021 12:01:06 +0000
Received: by outflank-mailman (input) for mailman id 241006;
 Tue, 07 Dec 2021 12:01:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muZ9e-0003PG-AG
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:01:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muZ9e-0001Dj-4D
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:01:06 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muZ9e-0001DR-3L
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:01:06 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muZ9B-0004eE-FL; Tue, 07 Dec 2021 12:00:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=vQ68MVuL/BG3VoJb0R+njWTScNK96Qrt7QoDAgAFj4Q=; b=bWLQpX2xr6nfdVjxjIVn1YCSwB
	rDF/nZQxIegic4untOHx4KR8dL4zumK379F8ctELK0uQoZUwfJyknqmos48sLKoB4K05FzLZ2HSE/
	72OyncUAElHRPybhKaE2OQroDW0xhzkwCbEtVr4Iri4KqowA+MjO1zuuOI3mw5esebJM=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25007.19664.487196.625874@mariner.uk.xensource.com>
Date: Tue, 7 Dec 2021 12:00:16 +0000
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>,
    "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
In-Reply-To: <9bb0ecfd-038d-2671-9929-8f9b37f5ea75@suse.com>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
	<0ed245fa-58a7-a5f6-b82e-48f9ed0b6970@suse.com>
	<a36df6b5-9f55-a199-e8d3-3f6cd58a054d@xen.org>
	<b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
	<0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
	<71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
	<ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
	<c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
	<0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
	<6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
	<bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
	<24992.55453.893877.246946@mariner.uk.xensource.com>
	<2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
	<c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
	<e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
	<53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
	<5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
	<9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
	<9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
	<b43c072f-4d4c-a108-2c24-801116e99c3e@xen.org>
	<9bb0ecfd-038d-2671-9929-8f9b37f5ea75@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
> I'm unwilling only as long as I don't understand the need for them. As
> indicated, while I appreciate your "make verification easier for
> reviewers", I assign that at least no higher priority than my desire
> to leave out inapplicable data.

Are we still talking about Signed-off-by ?

I explained the purpose of Signed-off-by.  It reflects the chain of
custody.  It is true that s-o-b is often added by people with minimal
contribution to the content; I don't think that is relevant.

If the Xen patch was derived from Linux commit XYZ (whether
automatically or manually) then even those minimal S-o-b are
applicable.

> I'd be happy for anyone else to start over. I would even ack such a
> submission myself. But as long as I'm recorded with S-o-b, I'm afraid
> I'm not going to accept re-addition of the tags for no good (as per my
> personal view) reason. Otherwise, based on experience, the example of
> this series could, in the future, be used to tell me that on an earlier
> occasion I (seemingly) did things differently.

S-o-b does not indicate complete approval of the content.  It attests
precisely to the statements in the DCO.  There is nothing irregular
about putting your S-o-b on something you don't entirely agree with.


Stepping back:

In a collaborative project, we must all respect our peers and the
community's decision.  That can mean actively progressing patches that
we personally disagree with, but which the community has decided ought
to be applied. [1]

I appreciate that can be less fun.  But it comes with the territory of
being a leading member of the community.


> As said earlier, if submissions in this form are going to be nak-ed
> going forward, and if good reasons (see above) will not be provided
> (and hence leeway will not be granted to the submitter) to support this,
> then someone else will need to start looking after imports which may be
> relevant to us.

The problem is simply one of verification.  So far there does not seem
to be a positive ack[1] for this patch.  Neither I nor Julien are
nacking it.

AIUI Julien does not want to ack it without being able to check that
all the appropriate s-o-b (and perhaps other tags) are present.  I
think that as the submitter it is really best if you make that easy.


We think the obvious way to make that easy for a reviewer is to just
copy the tags.  But an alternative would be to include, in the commit
message, full details of where the patch came from in (including urls
to mailing list articles) in such a way that a reviewer can see easily
that all the necessary s-o-b are present.


[1] Of course very rarely there might be matters of conscience, where
we have protested but our protest has been overruled by our peers.
But that does not seem to be the case here since you are not giving a
nak.

Ian.

[1] Julien did give one earlier but then wrote "actually" and started
this subthread, so I think Julien has withdrawn his ack.


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:03:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:03:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241018.417831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZCI-0004BN-8s; Tue, 07 Dec 2021 12:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241018.417831; Tue, 07 Dec 2021 12:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZCI-0004BG-5j; Tue, 07 Dec 2021 12:03:50 +0000
Received: by outflank-mailman (input) for mailman id 241018;
 Tue, 07 Dec 2021 12:03:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muZCH-0004BA-0R
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:03:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbcd711b-5755-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 13:03:48 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-XQWZ4olBMqidMtXExXlMnQ-1; Tue, 07 Dec 2021 13:03:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5901.eurprd04.prod.outlook.com (2603:10a6:803:e9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Tue, 7 Dec
 2021 12:03:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 12:03:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0411.eurprd06.prod.outlook.com (2603:10a6:20b:461::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21 via Frontend
 Transport; Tue, 7 Dec 2021 12:03:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbcd711b-5755-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638878627;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xHUAhCeK1kL/kJdsZid52HlaARWOovktGdg7hB6Bpto=;
	b=c9xWQv1oKjrjPPWhwg0ZGDY321r+/iWKStpf8f1+SQF9cBNovEh56ylVCTWylVL1xMBxW0
	91UQdB8fBxHqGwZ0LbZFn6bcyVWJ/seWnvk+CXRO6F2AZ4uw6tUAFeZzNY9Ryu51j40a9C
	7fzgjicuGEABXAVYe7a01stt3OkBL40=
X-MC-Unique: XQWZ4olBMqidMtXExXlMnQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HtqV/VXmU9ObNoycZeqJVmZpGAcHkpxPAkM9uNb0FzKm5DwZLT2VBlm9cCOcBwa1x5BvNj8KOJjKT3Llirvb4Nmya/9y9cp7IiQwcI9zUKQETpzIbmXRDN9QHVyMKMJKsrV8h8o9+8tACningpfO1IPJSw04wPtDKby6pwYbw3/6SYkCfk35sh4nKi1uZCoaPUws1lkF36PGAMEsQgFErPW8oqJKM0Mv/TmSQygehsAj4XFVnlzBVP8YlJLhp0tfkEwN8rXkKb6qPGqJzQ6lEGFysnckIq1rnHEzD9+h3veQ5PL67aopT+W/3YlMM2ME4NbXNawp+qiQspXNOUejQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xHUAhCeK1kL/kJdsZid52HlaARWOovktGdg7hB6Bpto=;
 b=nJfNNnzyGRaDlwhjB/dox+Md1i0ix9UEhidcPdVsP3RgeiNFUTypwb65L+x8nlAH6D03rFDxDdttwMJByf2iPVaY/yx+BwnQcFk0jfcdt6dnhKTcjtOQuir9M9C8L6XW/fBCvTN6xggp/RgPFoyi0FoKAxUlUE8kEjI1yNTGc2jCR9mjsjNBUEnHwnHgR40VI6ChtFm6EOfccdNIErOj237EojjKr/DSKEOp/WrOU1Ej5rGRt4Zh1TDSMuJBuhL4UJZ+L16RJ2wxTTWdvsIbD3dyGCIKN9dl4pHz/JqZBEED3ZUOX4Y6WpHCfwcfdR4tLtPyayWlN9gCud0VYJzA8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <81893ccf-6b94-ddc7-d92b-f254861fe994@suse.com>
Date: Tue, 7 Dec 2021 13:03:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] x86/boot: Drop move_memory() and use memcpy()
 directly
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211207105339.28440-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0411.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 09974890-79e8-43ae-318c-08d9b9799dec
X-MS-TrafficTypeDiagnostic: VI1PR04MB5901:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5901E3E7EF3968D9430EA865B36E9@VI1PR04MB5901.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zwQmS2E2+lKWU3vJsbHHnIN3eliGSagsdgBeZdYgkxDLebPEydroEFD3XcrEYB/PQN1cpZaMxyKHcbeRwtnXSNefriBnNohXRztQm409k7Ik1HpKtS2Wa3rXbpzSVvr8plwUbnrQCc/lFnFNsT6Q+4VCqQgwQhKNZ7r474k4TSQkFCnoO/hupjQ2nHcAESDkulplGqafbEOjNiXeolq0bsrKIdqWD0HaupRO4vLH2ekXHwCuez88si2dq8wlmagvUzJ/RRixyWMe0m2NB8Pbi9/s8DbUjaEEVdBEfXW0YzUfzCqIRonH4wyR0DzA6bApU4FIGK5ENKB3J6XcIXiiYpvodx5U9znzixJFWG2teW38h1yOXBDaUBryrvZVyu787cHp6jVWVpHS09FH8085N9T97KptRrcxhOu/aQ+xL7HtxVdadjiItEcqeXCKmFbfQhbYzKSP1HwBWwe2yKa2pChP3j2hjt67DWUDrLW7UYyD17Qq4rLIHlXvmcNJI3khSfwUh3mJFiebHeO7F5rWJ1oVko06OnjuqaJXCS0AlCcz9YYvQ6bJ0zBtjODaqhjLysE63/v2Oyf87T+vu+ptVP4woHrhNln3owdqcN4gKdUsNGdYamsDNlyKDo2jVV4tdNpDZmh8tEv9OgC+GUjp/7AIy1iKvQQqcKca8wZBifgd1mJZpDyV0iAX2z1Jw2olERTu55Io4TdPOgnyc24CLZKXrw0eP4znV45U4gFutEQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(54906003)(8676002)(2906002)(66556008)(8936002)(86362001)(186003)(31696002)(38100700002)(508600001)(956004)(66476007)(16576012)(316002)(2616005)(4326008)(26005)(6916009)(53546011)(83380400001)(31686004)(6486002)(36756003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Vy9zcDF3Z2pGdjRVWVBxL004MXVGYXcrcStxY3lTYWMxcEIzeEdrcXA4UEFq?=
 =?utf-8?B?TExXUHF2VkNBY1ord1lqa1JPdUdaYTJMV1pSS0pYMlVpQktCKzF0cGtKVEMw?=
 =?utf-8?B?YmJVSGdFbWtNVG1xVFN2N0UwV0FCamtTT0U5eGtGUGZQUmYrOTgxNnA5MHdO?=
 =?utf-8?B?eVJFTk05UzIwNnVJV0RTY0NWNU1rMUlZandHNWlkcE5kYWp3VDY3cG5nSEhs?=
 =?utf-8?B?YkNSNmFEMVRpLzhsRzZ3OCtRVG9BTUVId2lhZC9VVUhMOTFlbFYvVkVXRHM0?=
 =?utf-8?B?RDFiMXRYMHlla3I1Z0piWmp6TWNYbkhEVFdwMzgweW9oVkVpUlZMUzgzUVZS?=
 =?utf-8?B?NHJuSTU0eE5DSFN4aDNpcG9jVVV0MmM3UEF5VzltaVg4OGNMZ09JNE9qUEd3?=
 =?utf-8?B?QVlsK3FjUm1EQTNRUnN6cFBDeE00azZNS2JHcC9GcjlTMVB0OUF5cU1HVHBY?=
 =?utf-8?B?ZEErdVJrcmdNbDNwcjJ3OXRuRFpUcFVDa3RpbU5uUUsyT05mMk5GQ1g5dFNt?=
 =?utf-8?B?SGFYKy9Rd2hvTXdaTmpjZncwck9ibVdkanFxVW5pck1WRFFhUDhIejFteHJP?=
 =?utf-8?B?Q3AwN25OMmdhaEsrdW9ScVpWemFxczdOUnRBY1ZTUm1PSFErdzVMVTlMNWVO?=
 =?utf-8?B?TGtiSjV0akw3ZWtOY01vbXRXb0FsTHI0L3UwZ2ptZ1E3YWZVWkVpY2haSlc1?=
 =?utf-8?B?OU1ZcjVuSWRXcFhKVjllaGZyVkdGMnJPZ1ozTnhvTWhIY3NVQzkrQ0lnZGFX?=
 =?utf-8?B?RHVaMStyMzljMnRTaGtUeWxLSXN5d0lNTFcwZC9ZOG4wZTVGcFVTMktSZWds?=
 =?utf-8?B?RnpReHdpYUJ6M3QvNSszd2l4RVZVRG1EUFI2Nzhzd2ZxcjE2aGxJQXAwQVhU?=
 =?utf-8?B?R3lNWFRNTi9IUmtmcVN5b3MxamZPNTc3R2NyNStsZTNGSEhacitKb1g3WjlW?=
 =?utf-8?B?UHl3UkEvd2xUVDZpWkp1bnVDMnNWbm1lTFJxcjRaRnF5U1ZrNDk1MDJ1eHlZ?=
 =?utf-8?B?UWRqSTdjQ1VUcmF5ZVZQaVJQZDVSMkVxR3Z6c2hEYlFTZlBURHZHRGNPRXd5?=
 =?utf-8?B?alFsdnZqYjVmYk4rcEZFamdoVzRPU0dqUDliRk5NQTgzVmVka0NFRTdDeExC?=
 =?utf-8?B?VkZjTG04N1ZlWDRFQTd0NWZHQTk4WTFtR0hRdnlBY1VRZXEvZytLaytMTWhP?=
 =?utf-8?B?dmJQWnUrcEliZmhpb3NuQk5YVUk2bkw0dFdQSkFaZFlZUFFmMldiTVJsSXVC?=
 =?utf-8?B?anhyejYwR2w2SlZ3eTFaZHhGZkRTZlh2c3VBNUxkWFI3dklHYndoaUJGYWEw?=
 =?utf-8?B?bzBIV1VVWVdZNkFXNmQ3RGkrNXN4RERhMUdidDhrSWJTaTlaRVcxdnJ5eG9h?=
 =?utf-8?B?RWhjUzZ3c2F2cHp1c1BIOGI4Vy8xWkhKWTVrYzlBYjNqSmpnWGxXc1BPaC9k?=
 =?utf-8?B?Z1ZhQzRlYVl6TjVsV25relBYL1Q2ZnRpZldjY3dwU3ZBbTRBdCtyZ1dvSCtK?=
 =?utf-8?B?djRMaHNodWhyQkJFcmFlUWFkb0grcFZCam4yRFN6ZWV5YmtOd2w5OEZBMTZV?=
 =?utf-8?B?d0VXYnRuSlp4czk4RlZuQ1ZUSGpLUk9LOXB6Nno2NW5ZOU41ZmxKcUdWQy8z?=
 =?utf-8?B?Z2pXeEFUclRqMGxROFZLb2M4VXBKTWRQY01xSmdRbEpweExTYURyZ21BN2lW?=
 =?utf-8?B?UE5VNWEvMEMxMktrU0lxVlJGRndSNnA1SFNxNlYxK3M2RzJrZGNHTERpZEtJ?=
 =?utf-8?B?MnRMVnlYaFQraHNJa0N0TWhmN1Nwckh2b0hWUVpxV2NTTEx5MWdIbmVBd2lY?=
 =?utf-8?B?YTBJNEFUM2xJK0tjbFlkYzB5MXQ3d0FTeUNZeE5XazJkVDNNZ3NQWHoxNUEz?=
 =?utf-8?B?d0R2SlN2cjczMmNmSVBTazEyZUt0Z0tML2Z5YWozQ09XUVdiTlZVZ2I0ZG5u?=
 =?utf-8?B?ckZkVnAyM0cveXFPanZxVERnRGFjRU5mQzExZmt5SUp0MXNQUkkrSU5SUGNh?=
 =?utf-8?B?RUNvTmtkK3VUWkg5U09INy9lZHA0Zllnd2ZybnprdTNHeVlMOW1Lbnk4MmNq?=
 =?utf-8?B?NWs2VzdHQTVqaXVsYlFoVGtPREhoVmo0ZjEwazRoejNibHZrV3RicmppZDR0?=
 =?utf-8?B?WVZ6dUwwNitqZ09JYlh4MlQxTWZnZ2tBM2FJelpNWkVINVVyeHNETE9zdmVK?=
 =?utf-8?Q?PdIdvxS8XCfbPuHEH6hbzfs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09974890-79e8-43ae-318c-08d9b9799dec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 12:03:44.2888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FnOfnZWB85ugvzin4EVivBOMUjCjzzhIzXVfkGoBW/i31eIHmfnFqisUPgKu2bfyYEWwkJSiAhxXphwIo19vUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5901

On 07.12.2021 11:53, Andrew Cooper wrote:
> @@ -1243,7 +1196,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>               * data until after we have switched to the relocated pagetables!
>               */
>              barrier();
> -            move_memory(e, XEN_IMG_OFFSET, _end - _start, 1);
> +            memcpy(__va(__pa(_start)), _start, _end - _start);
>  
>              /* Walk idle_pg_table, relocating non-leaf entries. */
>              pl4e = __va(__pa(idle_pg_table));
> @@ -1300,8 +1253,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>                     "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
>                  : "memory" );
>  
> -            bootstrap_map(NULL);
> -
>              printk("New Xen image base address: %#lx\n", xen_phys_start);
>          }

This bootstrap_map() must have been dead code already before, except
for the "keep" argument above needlessly having got passed as 1? Afaict
passing 1 was pointless without using the function's return value.

> @@ -1325,9 +1276,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>                   (headroom ||
>                    ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) )
>              {
> -                move_memory(end - size + headroom,
> -                            (uint64_t)mod[j].mod_start << PAGE_SHIFT,
> -                            mod[j].mod_end, 0);
> +                memcpy(__va(end - size + headroom),
> +                       __va((uint64_t)mod[j].mod_start << PAGE_SHIFT),
> +                       mod[j].mod_end);

I'm not convinced this can be memcpy() - consider_modules() specifically
allows for the current module's source and destination areas to overlap.
See also the comment ahead of its invocation a few lines up from here.

I'm also not convinced we have the source range (fully) direct-mapped at
this point. Only full superpages have been mapped so far, and only those
for the current or higher address E820 entries (plus of course the pre-
built mappings of the space below 1Gb [PREBUILT_MAP_LIMIT]) located
below 4Gb.

As to the 2nd argument - if this can indeed be converted in the first
place, may I suggest to also switch to using pfn_to_paddr()?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:14:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:14:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241031.417841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZMk-0006K3-8Y; Tue, 07 Dec 2021 12:14:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241031.417841; Tue, 07 Dec 2021 12:14:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZMk-0006Jw-5O; Tue, 07 Dec 2021 12:14:38 +0000
Received: by outflank-mailman (input) for mailman id 241031;
 Tue, 07 Dec 2021 12:14:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muZMj-0006JX-5n
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:14:37 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3de84bcb-5757-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 13:14:35 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7FCF121B38;
 Tue,  7 Dec 2021 12:14:35 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 537D913A42;
 Tue,  7 Dec 2021 12:14:35 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OyvTEitQr2GzJQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 12:14:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3de84bcb-5757-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638879275; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bf4+He2VcmAlYBZY1yQQYdYtEy2pg0i+8Yt6LRpqaJM=;
	b=vAhE/IGA0b849GccHnR6c9GYJB3iwzHZaPO+xcBHC2Z/pmTojAxRQy5EP5UmOZuH0GC4WU
	zLxa7GAiOErGANIvtse975q/+RNDdGhM3KGsL3T8vPiy/9+QpP2bpUxL4gBEv+u5R8lspa
	pEqdYPvDPG19PFwXQeqwwz3bNODEMHc=
Subject: Re: [XEN PATCH 39/57] libs: Remove both "libs" and "build" target
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-40-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <76f52851-fa91-0e2f-dc2a-8fef54704176@suse.com>
Date: Tue, 7 Dec 2021 13:14:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-40-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="ITIIn0mJmypSYyRfOm3nIHT6ocnGSOJBB"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ITIIn0mJmypSYyRfOm3nIHT6ocnGSOJBB
Content-Type: multipart/mixed; boundary="aeqRHE5SOP4iDPtYub9b81Y0oQAb62vqv";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <76f52851-fa91-0e2f-dc2a-8fef54704176@suse.com>
Subject: Re: [XEN PATCH 39/57] libs: Remove both "libs" and "build" target
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-40-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-40-anthony.perard@citrix.com>

--aeqRHE5SOP4iDPtYub9b81Y0oQAb62vqv
Content-Type: multipart/mixed;
 boundary="------------C769B62DF5BE6DDDC419536D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------C769B62DF5BE6DDDC419536D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> "libs" is odd and has been introduced without a reason by c7d3afbb44.
> Instead, only use "all".
>=20
> Also remove "build" target as "all" is more appropriate and nothing is
> using "build" in libs/ in the xen.git repo.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------C769B62DF5BE6DDDC419536D
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------C769B62DF5BE6DDDC419536D--

--aeqRHE5SOP4iDPtYub9b81Y0oQAb62vqv--

--ITIIn0mJmypSYyRfOm3nIHT6ocnGSOJBB
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvUCoFAwAAAAAACgkQsN6d1ii/Ey97
hAf/Ug1T7HkQn0VwHNFS4JUeyaB6jHCRXSqXZmOifOPT0z9Yf2IkPBGHX8E15GQaoNskM2yLDTSS
x/0fbypb3/iZUQCHuoRasm8ARLK0+Rj0/UluhfGzRy8BAUF8UpIQxZf0FqL9445L68pU11qsBSGb
EEkeLzAq+7CPN3BrhusZ4NnW7SEiIj6WQzMamnmsteJOX7zLkvS4ToGiqwpceiUFADxZrfzP0EP/
5ur9P4jD3rDkn6ItoE9Y5INSaufFQehtD9QBCZopA38+i84DShJtvM/CHXIRmh7lkpWNawxcn85w
EAZdjW/8lFIHRIrMLxylztlZaOTEXdFVKUSAdvyMww==
=vteV
-----END PGP SIGNATURE-----

--ITIIn0mJmypSYyRfOm3nIHT6ocnGSOJBB--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:17:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:17:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241041.417853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZPS-0007bc-Mx; Tue, 07 Dec 2021 12:17:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241041.417853; Tue, 07 Dec 2021 12:17:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZPS-0007bV-JE; Tue, 07 Dec 2021 12:17:26 +0000
Received: by outflank-mailman (input) for mailman id 241041;
 Tue, 07 Dec 2021 12:17:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muZPR-0007bP-6a
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:17:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a27450cc-5757-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 13:17:24 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 01A0C21B3D;
 Tue,  7 Dec 2021 12:17:24 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A2B1113A42;
 Tue,  7 Dec 2021 12:17:23 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2BiyJNNQr2FeJwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 12:17:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a27450cc-5757-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638879444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=fxyGg2MrI5Rj6EaGs0Qh+qEmyL4s9xxHME6B2cp21bo=;
	b=P+MUu7r3BrZ2zeG21ME+ryCDuoevVwxkAS5gnYFiN4waASsbkvyJMMOcLmDw/krI7llOib
	WB4i9Jv/84Li6b4JVHC9HVdhC8t7Mr2xdwH4bQDqThLiO0Xdl7QpqFXTmm7kPCavvYYTHR
	5H1yN8jwe260RDBo+3BKHohVh+LNo4Y=
Subject: Re: [XEN PATCH 40/57] libs: rename LDUSELIBS to LDLIBS and use it
 instead of APPEND_LDFLAGS
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-41-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <468bb631-f18f-32ac-72ad-1c6943d48221@suse.com>
Date: Tue, 7 Dec 2021 13:17:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-41-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="CpZ6IWaNV1EwE1DbG4JCUoY91XHIp91mE"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CpZ6IWaNV1EwE1DbG4JCUoY91XHIp91mE
Content-Type: multipart/mixed; boundary="z6YThoMwhHTTouIfEvelRUyKMUBa1wejc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <468bb631-f18f-32ac-72ad-1c6943d48221@suse.com>
Subject: Re: [XEN PATCH 40/57] libs: rename LDUSELIBS to LDLIBS and use it
 instead of APPEND_LDFLAGS
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-41-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-41-anthony.perard@citrix.com>

--z6YThoMwhHTTouIfEvelRUyKMUBa1wejc
Content-Type: multipart/mixed;
 boundary="------------5A64C9D54187F261DD290B0B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------5A64C9D54187F261DD290B0B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> LDLIBS is more appropriate and intended to be used to add library
> dependencies. APPEND_LDFLAGS wasn't intended to be changed by the
> build system.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------5A64C9D54187F261DD290B0B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------5A64C9D54187F261DD290B0B--

--z6YThoMwhHTTouIfEvelRUyKMUBa1wejc--

--CpZ6IWaNV1EwE1DbG4JCUoY91XHIp91mE
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvUNIFAwAAAAAACgkQsN6d1ii/Ey/6
Swf/SHmpEVyG0VH23A2sqPAs6vepaj3jg9T2+GHlPLENBRSpfgK1WOD4/BaRYbmZmxNh64rsL8+b
oBY+toxAz3h1UUk7fhvX1zlPngt3TyAnmRxlWus43LPoSacLByvj8GLxpeReS3iuHATc3jg1w+tj
Lv8QdAUQWXaOKW56nmUgQdm4LWV20hS3ztS1/6LrICaPtebLQfEGVhE535SonM1GVehY6N42lYod
hcE3N6qNuve9YgPJUwb/WVDl0veR9QdEDYhAOjSMxNRYjoris1rnfbse44JgahQjwz1Jv4AZ5fs8
7UmPhOWBzmrt6F3OMPuwZ/n0+uK96ybHF8+EVogxHw==
=gtVs
-----END PGP SIGNATURE-----

--CpZ6IWaNV1EwE1DbG4JCUoY91XHIp91mE--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:46:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:46:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241051.417863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZrV-0003hp-3I; Tue, 07 Dec 2021 12:46:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241051.417863; Tue, 07 Dec 2021 12:46:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZrV-0003hi-09; Tue, 07 Dec 2021 12:46:25 +0000
Received: by outflank-mailman (input) for mailman id 241051;
 Tue, 07 Dec 2021 12:46:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuaW=QY=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muZrT-0003hc-Na
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:46:23 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ad2b5d62-575b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 13:46:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ad2b5d62-575b-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638881179;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QKzQcfpFrakF1gaQnErus44+ZE9ndLllCgtGuvnr0lo=;
	b=zkOUIyV/MINXrUxqZ9LTk6Hht+Xmk8q0kbB/5Y19WuZGmYCp1YnKcRHA/Ud2ZzNf0tBhD1
	5ewm51F2t/LbVeitPsQv0NzSQYvxBgYBwS2c0MPgw3mJzPZAZ6q2GBlz1ILLKxM7NY+q56
	y6FO2Jf6F60qKB/xuNibwDIcpP0cREBO9k1rd9lF2bKMpcZfrjSZUCAv611PzYSfI9kaYD
	ozerFcwa3CJXVTsQElTER2+/qf7c08a86zn5ZozkKNQ9QsA7UC2wyWhtESX00QKpP6+lNz
	FelqwJ4Bd7vCMzYyeRjT3d7rSGV/Gz0CUgOyfaKzjKzk1KOF0aTbcueGSTp9SQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638881179;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QKzQcfpFrakF1gaQnErus44+ZE9ndLllCgtGuvnr0lo=;
	b=yZ3GrlUbR1OmCFoNBVL41nwID0yawuJjFK0MUow1uzlkJmWNC0fYtNtLkZbCEAFV92VP56
	kQjuYi/bhsZdtdDA==
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, xen-devel@lists.xenproject.org, Juergen Gross
 <jgross@suse.com>, Niklas Schnelle <schnelle@linux.ibm.com>,
 linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Christian
 Borntraeger <borntraeger@de.ibm.com>, Logan Gunthorpe
 <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>, Dave Jiang
 <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: Re: [patch V2 29/31] genirq/msi: Add abuse prevention comment to
 msi header
In-Reply-To: <Ya8Zj+bADtKEISSP@kroah.com>
References: <20211206210600.123171746@linutronix.de>
 <20211206210749.170847844@linutronix.de> <Ya8Zj+bADtKEISSP@kroah.com>
Date: Tue, 07 Dec 2021 13:46:18 +0100
Message-ID: <87lf0w37mt.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Dec 07 2021 at 09:21, Greg Kroah-Hartman wrote:
> On Mon, Dec 06, 2021 at 11:51:49PM +0100, Thomas Gleixner wrote:
>>  #include <linux/cpumask.h>
>>  #include <linux/mutex.h>
>>  #include <linux/list.h>
>> 
> Ah, to be young and idealistic and hope that kernel developers read
> comments in header files :)

Hope dies last.

> You might want to add this to the driver-api kernel doc build?

When I do the next round of refactoring, I'm going to move the functions
which are available for drivers into a separate header file.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:47:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:47:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241057.417875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZsi-0004vv-DT; Tue, 07 Dec 2021 12:47:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241057.417875; Tue, 07 Dec 2021 12:47:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZsi-0004vo-AB; Tue, 07 Dec 2021 12:47:40 +0000
Received: by outflank-mailman (input) for mailman id 241057;
 Tue, 07 Dec 2021 12:47:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuaW=QY=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muZsh-0003hc-Hl
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:47:39 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dc06defa-575b-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 13:47:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dc06defa-575b-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638881258;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=;
	b=1QK7A5Quf6kWCtw53J7LvMSn21VoC3/a3rTC4N/K9KOL4NOIZguih61ltj5o2xfGP8fosF
	BeQwVchpb12p0y5ddl73SUOzMBu6gIMOsGkxFdl5DJrfmj1Eim1xbeRkUgaFost/P/l1rc
	R2cgY1UjJCMU1gjgvFUxFmbrR1966LIsSNzq5oGXncv5V0Y5vYAuEeLPzjweMxQI48uHLx
	MdMtGCM3OlYqjQpPgR4EUu0q413CYfgQ72I0nJ6osdk/lVoifAMucYRoeBo63dPfAw6clb
	UTcRGoe1SrHcnbJssHPqCjL3MC2C5BTHwEW6fNyn25OsD54B/nKqidN8WpkUhw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638881258;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=rfvMhKPhb1o//czxJpD8hEyO6OfjVQhOJc2oIhKZDZw=;
	b=iWRt10cM8F7Z6E8RZ9a3abFTVEBRiybM6wE8GDhsSLisml9tvmBdzmeYXcqagp5wZeqokg
	ZkJiPjEuHtHx+wCA==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, LKML
 <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok
 Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>, iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
 <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
In-Reply-To: <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.634566968@linutronix.de>
 <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org>
Date: Tue, 07 Dec 2021 13:47:37 +0100
Message-ID: <87ilw037km.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 07 2021 at 10:04, C=C3=A9dric Le Goater wrote:
>> +/**
>> + * msi_device_set_properties - Set device specific MSI properties
>> + * @dev:	Pointer to the device which is queried
>> + * @prop:	Properties to set
>> + */
>> +void msi_device_set_properties(struct device *dev, unsigned long prop)
>> +{
>> +	if (WARN_ON_ONCE(!dev->msi.data))
>> +		return ;
>> +	dev->msi.data->properties =3D 0;
> It would work better if the prop variable was used instead of 0.
>
> With that fixed,

Indeed. Copy & pasta w/o brain usage ...


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 12:53:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 12:53:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241064.417885 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZyX-0006NS-3A; Tue, 07 Dec 2021 12:53:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241064.417885; Tue, 07 Dec 2021 12:53:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muZyW-0006NL-W6; Tue, 07 Dec 2021 12:53:40 +0000
Received: by outflank-mailman (input) for mailman id 241064;
 Tue, 07 Dec 2021 12:53:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuaW=QY=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muZyW-0006NF-88
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 12:53:40 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b26324a0-575c-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 13:53:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b26324a0-575c-11ec-9d12-4777fae47e2b
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638881617;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aNhnkzcLIHS9o6REcIVVTdi6HJHMTMekwoWhR5Os8KA=;
	b=fDdfjoBrqymOl2a+g4MXycXTFQvrRmQZeNf3rg3L6n1PiCtdWcCcmDaVpdvwx1WHZPu2/v
	fJ5y/fl9rqcMBqPDwA5dGahXUq/mN6Rr/ElGbNuccnYfY2zSKXTbzkZQodP7GLSEpFoYdh
	46+uktDwZ2vMiIgjrLAfY7tW6+YkhG+kEnyrqVcu/yhSumZnuVQZSPFDDqkewYdktBX2W1
	E5XHAvsHcg+oePKYbcgXP8R5bFs+hJf3t4yTvMtPo50NBwX80mLh/AIBUE7bofDK/aFu6H
	qtf+AY+yYI2U4AcWEXhnQ22yGPrAzddB3aN+8X6CX1qpB5O1+EGPIoTqDwRh5g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638881617;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aNhnkzcLIHS9o6REcIVVTdi6HJHMTMekwoWhR5Os8KA=;
	b=9LR8QBp7ApgLB6V6Z+0XA4lyUUgGXXJ03ul38aiaIn/PFJSbmKuGwWEzOcLJoDF8z5Se10
	uqB+RdhRp6Pw8iDA==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, LKML
 <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok
 Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>, iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
 <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
In-Reply-To: <87ilw037km.ffs@tglx>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.634566968@linutronix.de>
 <6f06c9f0-1f8f-e467-b0fb-2f9985d5be0d@kaod.org> <87ilw037km.ffs@tglx>
Date: Tue, 07 Dec 2021 13:53:36 +0100
Message-ID: <87fsr437an.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 07 2021 at 13:47, Thomas Gleixner wrote:
> On Tue, Dec 07 2021 at 10:04, C=C3=A9dric Le Goater wrote:
>>> +/**
>>> + * msi_device_set_properties - Set device specific MSI properties
>>> + * @dev:	Pointer to the device which is queried
>>> + * @prop:	Properties to set
>>> + */
>>> +void msi_device_set_properties(struct device *dev, unsigned long prop)
>>> +{
>>> +	if (WARN_ON_ONCE(!dev->msi.data))
>>> +		return ;
>>> +	dev->msi.data->properties =3D 0;
>> It would work better if the prop variable was used instead of 0.
>>
>> With that fixed,
>
> Indeed. Copy & pasta w/o brain usage ...

I've pushed out an incremental fix on top. Will be folded back.

     git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v2-pa=
rt-3-1

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:21:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:21:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241078.417897 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaOX-00033C-89; Tue, 07 Dec 2021 13:20:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241078.417897; Tue, 07 Dec 2021 13:20:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaOX-000335-4z; Tue, 07 Dec 2021 13:20:33 +0000
Received: by outflank-mailman (input) for mailman id 241078;
 Tue, 07 Dec 2021 13:20:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaOV-00032z-UM
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:20:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 732013c4-5760-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:20:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CB5FF1FD56;
 Tue,  7 Dec 2021 13:20:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9995F13A63;
 Tue,  7 Dec 2021 13:20:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 6/JHJJ1fr2HURgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 732013c4-5760-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883229; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=i+nviJexRolV21wub8IbWTVS40+659B2KUTP/FF8XD4=;
	b=IRqe8xNG2lFDSA+aDjVEx5uRAcuGAP1Gh8/ZGOdCsVL3uum/jV7TlU9LWCLyGVqtmKx3yY
	skwFP3CpPj9WSCBZ5BW0VLwqJEkd9teDoow8HQVdDIqROHBlMQusIQB2fO8Pwx2KAT5i3j
	CVG6z4Q7gu2hnHrX3N8oORuwlsFKwhU=
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-42-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH 41/57] libs: Remove need for *installlocal targets
Message-ID: <bc5bc497-d1a0-007a-802f-e411159fb88e@suse.com>
Date: Tue, 7 Dec 2021 14:20:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-42-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="LcgQS0Xl0zyJoxaZ19G7eeelIEzIi8iuv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--LcgQS0Xl0zyJoxaZ19G7eeelIEzIi8iuv
Content-Type: multipart/mixed; boundary="noe57VO5yCsN3TB7G75OF09M96YLmHck7";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <bc5bc497-d1a0-007a-802f-e411159fb88e@suse.com>
Subject: Re: [XEN PATCH 41/57] libs: Remove need for *installlocal targets
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-42-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-42-anthony.perard@citrix.com>

--noe57VO5yCsN3TB7G75OF09M96YLmHck7
Content-Type: multipart/mixed;
 boundary="------------3BB6FBEC9357192216A6F0C2"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------3BB6FBEC9357192216A6F0C2
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> There is no need for an extra "installlocal" target, we can use
> double-colon rules instead.

Doesn't that mean that with the ultimate goal of including all
Makefiles of the tree that all "install" and "uninstall" rules in the
tree will have to be double-colon rules? Citing from the make manual:

   When a target appears in multiple rules, all the rules must be the
   same type: all ordinary, or all double-colon.

>=20
> "install-headers" in "libs/store" was introduced for the same reason
> that "installlocal" exist, so it is replaced as well.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

With above remark I don't see how tools/libs/stat/Makefile can be left
unmodified, as it includes libs.mk and it contains an "intall:" rule.


Juergen

--------------3BB6FBEC9357192216A6F0C2
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3BB6FBEC9357192216A6F0C2--

--noe57VO5yCsN3TB7G75OF09M96YLmHck7--

--LcgQS0Xl0zyJoxaZ19G7eeelIEzIi8iuv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvX50FAwAAAAAACgkQsN6d1ii/Ey8d
IQf9Fcrn0+S6HuOBvR8LxbpVilXLR3gPmd6fFnM0C+cnYC3/4bhUtTCUwtkMP5En7S7wjhRMK9BI
yFfdZ8LFQ24l7FF8guKwA84nmkdTGfrG7VQpIzgOxd3gOP2srwzeP9H+7v8t5K26pKtZt4ikn0BE
rEjsha3C5v36kdXb1LHNKMY+sldBiTCKacFURoFXxUGtqmEB5VGsqFW/Uy6CQ0uBCWrobcDmoC9i
miRKItdprgniPJxmRLVerXcdck0xZdfw9MVGj3aYK9PyWMlx6ZWeW1WCkvDDkJ8p9/PqtMOWiTal
eYgEBX9G3WKDLfxiCJ+gak9i9qXPBx1qQKoZxaittA==
=qu+R
-----END PGP SIGNATURE-----

--LcgQS0Xl0zyJoxaZ19G7eeelIEzIi8iuv--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:22:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:22:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241082.417908 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaPz-0003cO-KD; Tue, 07 Dec 2021 13:22:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241082.417908; Tue, 07 Dec 2021 13:22:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaPz-0003cH-H9; Tue, 07 Dec 2021 13:22:03 +0000
Received: by outflank-mailman (input) for mailman id 241082;
 Tue, 07 Dec 2021 13:22:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaPx-0003c7-LZ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:22:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a8ddb40f-5760-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:22:00 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4D17C218D6;
 Tue,  7 Dec 2021 13:22:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27B9013A63;
 Tue,  7 Dec 2021 13:22:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xJdcCPhfr2F5RwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:22:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a8ddb40f-5760-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883320; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/9UmRT2NcL0UTT/SjF9CeSwcVD7vF9+WF9agbGusyDo=;
	b=bAGs4vgds/VxPPzDVuvO81jskMKcyAZt8viH7ZH8l2XDhAns9Wg0G5VH0hTn2dfKCClHje
	De0U5prvXE298nta4uc9SQrAOOkW1BRwchUMvYL7qDcD2RJ6Qx4rj69eRyXQdXZiMGNdjR
	NoD6soOM2Wt8n4woNptGgQgw+sfBgjo=
Subject: Re: [XEN PATCH 42/57] libs,tools/include: Clean "clean" targets
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-43-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <210e3196-feea-7df5-ce38-cd8789e8af23@suse.com>
Date: Tue, 7 Dec 2021 14:21:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-43-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="94XAOVebDixBlVJJxtrLl5xzl8r7QlfxT"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--94XAOVebDixBlVJJxtrLl5xzl8r7QlfxT
Content-Type: multipart/mixed; boundary="NuuD8cdHKIjMsd0edb73UPFR7ah8RHtlS";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <210e3196-feea-7df5-ce38-cd8789e8af23@suse.com>
Subject: Re: [XEN PATCH 42/57] libs,tools/include: Clean "clean" targets
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-43-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-43-anthony.perard@citrix.com>

--NuuD8cdHKIjMsd0edb73UPFR7ah8RHtlS
Content-Type: multipart/mixed;
 boundary="------------75C4C79D18772802E66F0B95"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------75C4C79D18772802E66F0B95
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> There is no need for an extra "cleanlocal" target, we can use
> double-colon rules instead.
>=20
> Generated headers are now in tools/include/, so remove those file
> there.
>=20
> Remove -f flag as it's already in $(RM).
>=20
> libs.mk:
>    - don't try to remove "*.rpm" anymore.
>=20
> libs/light:
>    - "_paths.*.tmp" isn't created anymore.
>    - clean "libxenlight_test.so" and "libxl_test_*.opic".
>=20
> libs/util:
>    - fix clean of version-script file.
>=20
> include/xen-foreign:
>    - remove __pycache__
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Same remark regarding double-colon rules as for last patch.


Juergen

--------------75C4C79D18772802E66F0B95
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------75C4C79D18772802E66F0B95--

--NuuD8cdHKIjMsd0edb73UPFR7ah8RHtlS--

--94XAOVebDixBlVJJxtrLl5xzl8r7QlfxT
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvX/cFAwAAAAAACgkQsN6d1ii/Ey/P
GAf/S1CoX7b4Pm+0HqVLE041jm6pVxeJdVoe8sHYOkADsb+jMrlCpEqx1u+fJefUfVe9QsEZgEOP
E7NWBpKgvMZAawicg3ZGctD6WE+mLScGk1sOs3dMJ7eNmNJWjCizrttYGjtSxliafcBWc2kT3hEs
cXEfDZ53eiiPaEEXQ0jD0bYhNVsElniOEXKzzQJgVc6RzgGe94UOLnaXLl0zLu+2CqbYKVFj8bNU
9/bpd2sz3iJumdADCRXamNIUDWzK+/BNvNa6LANTzy3AV0I78nFjHQMci4xbZn2BLk4wn7T9ydL8
f2mRxSYdeSdcAY6TEnRiqs+3CxTw8KrILMk+aALCRw==
=EHSU
-----END PGP SIGNATURE-----

--94XAOVebDixBlVJJxtrLl5xzl8r7QlfxT--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:24:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:24:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241091.417919 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaSV-0004LX-6X; Tue, 07 Dec 2021 13:24:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241091.417919; Tue, 07 Dec 2021 13:24:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaSV-0004LQ-2i; Tue, 07 Dec 2021 13:24:39 +0000
Received: by outflank-mailman (input) for mailman id 241091;
 Tue, 07 Dec 2021 13:24:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaST-0004L1-OU
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:24:37 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 04fe7926-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:24:35 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-85-pq0CVYb0N9-a5LHy6DfeXw-1; Tue, 07 Dec 2021 08:24:31 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 35D621B2C981;
 Tue,  7 Dec 2021 13:24:29 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 3765276612;
 Tue,  7 Dec 2021 13:23:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 04fe7926-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883474;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=r2isEaCd6xk+f4LxeTB/xnxK27KBL9Gzn5hEP87ohGk=;
	b=K9Kw4gYbiqKvwaxtXtLmibEbGmcL02Rkgllho55+fvcLfhh1hRquX+6SL7y3Tgf98cGeW2
	worgxb943zmHilFavZldmtgfDOa5eYz8sXDJT5mh6g3STN3VlMLqbd7HXN3bUlLWkJ/2qI
	P8bRcKpwUEQlDQr5h7txQATRYwiBwZc=
X-MC-Unique: pq0CVYb0N9-a5LHy6DfeXw-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 0/6] aio-posix: split poll check from ready handler
Date: Tue,  7 Dec 2021 13:23:30 +0000
Message-Id: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

v3:=0D
- Fixed FUSE export aio_set_fd_handler() call that I missed and double-chec=
ked=0D
  for any other missing call sites using Coccinelle [Rich]=0D
v2:=0D
- Cleaned up unused return values in nvme and virtio-blk [Stefano]=0D
- Documented try_poll_mode() ready_list argument [Stefano]=0D
- Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [S=
tefano]=0D
=0D
The first patch improves AioContext's adaptive polling execution time=0D
measurement. This can result in better performance because the algorithm ma=
kes=0D
better decisions about when to poll versus when to fall back to file descri=
ptor=0D
monitoring.=0D
=0D
The remaining patches unify the virtio-blk and virtio-scsi dataplane and=0D
non-dataplane virtqueue handlers. This became possible because the dataplan=
e=0D
handler function now has the same function signature as the non-dataplane=
=0D
handler function. Stefano Garzarella prompted me to make this refactoring.=
=0D
=0D
Stefan Hajnoczi (6):=0D
  aio-posix: split poll check from ready handler=0D
  virtio: get rid of VirtIOHandleAIOOutput=0D
  virtio-blk: drop unused virtio_blk_handle_vq() return value=0D
  virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane=0D
  virtio: use ->handle_output() instead of ->handle_aio_output()=0D
  virtio: unify dataplane and non-dataplane ->handle_output()=0D
=0D
 include/block/aio.h             |  4 +-=0D
 include/hw/virtio/virtio-blk.h  |  2 +-=0D
 include/hw/virtio/virtio.h      |  5 +-=0D
 util/aio-posix.h                |  1 +=0D
 block/curl.c                    | 11 ++--=0D
 block/export/fuse.c             |  4 +-=0D
 block/io_uring.c                | 19 ++++---=0D
 block/iscsi.c                   |  4 +-=0D
 block/linux-aio.c               | 16 +++---=0D
 block/nfs.c                     |  6 +--=0D
 block/nvme.c                    | 51 ++++++++++++-------=0D
 block/ssh.c                     |  4 +-=0D
 block/win32-aio.c               |  4 +-=0D
 hw/block/dataplane/virtio-blk.c | 16 +-----=0D
 hw/block/virtio-blk.c           | 14 ++----=0D
 hw/scsi/virtio-scsi-dataplane.c | 60 +++-------------------=0D
 hw/scsi/virtio-scsi.c           |  2 +-=0D
 hw/virtio/virtio.c              | 73 +++++++++------------------=0D
 hw/xen/xen-bus.c                |  6 +--=0D
 io/channel-command.c            |  6 ++-=0D
 io/channel-file.c               |  3 +-=0D
 io/channel-socket.c             |  3 +-=0D
 migration/rdma.c                |  8 +--=0D
 tests/unit/test-aio.c           |  4 +-=0D
 util/aio-posix.c                | 89 +++++++++++++++++++++++++--------=0D
 util/aio-win32.c                |  4 +-=0D
 util/async.c                    | 10 +++-=0D
 util/main-loop.c                |  4 +-=0D
 util/qemu-coroutine-io.c        |  5 +-=0D
 util/vhost-user-server.c        | 11 ++--=0D
 30 files changed, 219 insertions(+), 230 deletions(-)=0D
=0D
--=20=0D
2.33.1=0D
=0D



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:24:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:24:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241092.417929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaSf-0004gE-Df; Tue, 07 Dec 2021 13:24:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241092.417929; Tue, 07 Dec 2021 13:24:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaSf-0004g5-AW; Tue, 07 Dec 2021 13:24:49 +0000
Received: by outflank-mailman (input) for mailman id 241092;
 Tue, 07 Dec 2021 13:24:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaSe-0004L1-3k
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:24:48 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c5a7a70-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:24:47 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3055D218A8;
 Tue,  7 Dec 2021 13:24:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C694313A7E;
 Tue,  7 Dec 2021 13:24:46 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PdFSLZ5gr2GpSAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:24:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c5a7a70-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883487; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=K8SLfBZgUQybWaMSjbBaCqA78IE4w8q9SvRV9Qxjrio=;
	b=oortxMNWf6ABqKq6qwXkwGQVo0dKhGShiY0Y4csZ2OL90Px1cUJGI3gLjZLJ1w8rDd3ICt
	6US+yiKPEuKhgqhUPaJk3o5jS6eJfGFFLkL4shqxwycAnFPDa/dIOScbAe8qhvbnOmukTP
	+oH9+Dchhx4QisR7zQ4YR6IurAYs9OY=
Subject: Re: [XEN PATCH 43/57] libs: Rename $(SRCS-y) to $(OBJS-y)
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-44-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2c15da4b-b351-58a4-b9ec-1d819c0799b2@suse.com>
Date: Tue, 7 Dec 2021 14:24:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-44-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="9v6hLDWLp345sAvinzjI4lhCfCfg1On7i"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--9v6hLDWLp345sAvinzjI4lhCfCfg1On7i
Content-Type: multipart/mixed; boundary="d3gdz6SgAvgVXFnxh8amannibRqzOx06d";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <2c15da4b-b351-58a4-b9ec-1d819c0799b2@suse.com>
Subject: Re: [XEN PATCH 43/57] libs: Rename $(SRCS-y) to $(OBJS-y)
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-44-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-44-anthony.perard@citrix.com>

--d3gdz6SgAvgVXFnxh8amannibRqzOx06d
Content-Type: multipart/mixed;
 boundary="------------0935232C5BC3D4E91F661A2B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------0935232C5BC3D4E91F661A2B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> The only thing done thing done with $(SRCS-y) is to replace ".c" by
> ".o". It is more useful to collect which object we want to build as
> make will figure out how to build it and from which source file.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------0935232C5BC3D4E91F661A2B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------0935232C5BC3D4E91F661A2B--

--d3gdz6SgAvgVXFnxh8amannibRqzOx06d--

--9v6hLDWLp345sAvinzjI4lhCfCfg1On7i
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvYJ4FAwAAAAAACgkQsN6d1ii/Ey8L
SAf8D709CFzE0mrLX/ClWcg/HeC9Q0Qd4s6WdbJ2Dd9D/MAFjBk0WwSv2ym2seoCyLYTWt9upDtY
YICXOZVNJD3U88ZxOLq0yqIjeGLfJHeJcCwyvyQfpp72UzSW9gvI1uEF56jayPw3h6TjVE5ySMU2
VUqCRU+gbOct0/B4b389H4PjG8ORse2tZUlA0gtbv3Ym8ACZHBcxJ+UV+M8t5zoYSCC/0gYx7vQr
lM0+2+0u5WjrrRbt/i8gL59KTM8OqbNMWl9ZRMiZxJbPBg+03YW9D7im0Gb3YM2oBYNV2iLj1Avm
zindqIcmGa72lbUVJwteyz3VgZQQcAyGeb06UAlgMw==
=T6Ov
-----END PGP SIGNATURE-----

--9v6hLDWLp345sAvinzjI4lhCfCfg1On7i--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:25:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:25:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241098.417940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTB-0005QN-Ne; Tue, 07 Dec 2021 13:25:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241098.417940; Tue, 07 Dec 2021 13:25:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTB-0005QG-Kl; Tue, 07 Dec 2021 13:25:21 +0000
Received: by outflank-mailman (input) for mailman id 241098;
 Tue, 07 Dec 2021 13:25:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaT9-0005E4-Rm
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:25:19 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1e9b77e2-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:25:19 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-552-TqfKqrq2Mdm55v-G4XcJTg-1; Tue, 07 Dec 2021 08:25:16 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C50E98015B7;
 Tue,  7 Dec 2021 13:25:14 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 5E73F5D9C0;
 Tue,  7 Dec 2021 13:25:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e9b77e2-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883517;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dDOfWfFuM0VbgnCaywJ0wNStjfoINmgW0Wpk8oJ29+M=;
	b=GbEue0UNDjFmNzYoSiHlZK33k5EDD+AZA0NqBIgtIIkgEENWR+s971dBuXyE35pKy7kBH5
	KAMsGGnvshwpoCl79ol6Ny+o2lXWAtvFnfDUKa+f6WGoE3HUtVyCdm1/eXadDg6U3cTnXH
	damqnhL1XveHPTwErtAOglfYfvQt4MM=
X-MC-Unique: TqfKqrq2Mdm55v-G4XcJTg-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 2/6] virtio: get rid of VirtIOHandleAIOOutput
Date: Tue,  7 Dec 2021 13:23:32 +0000
Message-Id: <20211207132336.36627-3-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The virtqueue host notifier API
virtio_queue_aio_set_host_notifier_handler() polls the virtqueue for new
buffers. AioContext previously required a bool progress return value
indicating whether an event was handled or not. This is no longer
necessary because the AioContext polling API has been split into a poll
check function and an event handler function. The event handler is only
run when we know there is work to do, so it doesn't return bool.

The VirtIOHandleAIOOutput function signature is now the same as
VirtIOHandleOutput. Get rid of the bool return value.

Further simplifications will be made for virtio-blk and virtio-scsi in
the next patch.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio.h      |  3 +--
 hw/block/dataplane/virtio-blk.c |  4 ++--
 hw/scsi/virtio-scsi-dataplane.c | 18 ++++++------------
 hw/virtio/virtio.c              | 12 ++++--------
 4 files changed, 13 insertions(+), 24 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 8bab9cfb75..b90095628f 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -175,7 +175,6 @@ void virtio_error(VirtIODevice *vdev, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
 void virtio_device_set_child_bus_name(VirtIODevice *vdev, char *bus_name);
 
 typedef void (*VirtIOHandleOutput)(VirtIODevice *, VirtQueue *);
-typedef bool (*VirtIOHandleAIOOutput)(VirtIODevice *, VirtQueue *);
 
 VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
                             VirtIOHandleOutput handle_output);
@@ -318,7 +317,7 @@ EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq);
 void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled);
 void virtio_queue_host_notifier_read(EventNotifier *n);
 void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-                                                VirtIOHandleAIOOutput handle_output);
+        VirtIOHandleOutput handle_output);
 VirtQueue *virtio_vector_first_queue(VirtIODevice *vdev, uint16_t vector);
 VirtQueue *virtio_vector_next_queue(VirtQueue *vq);
 
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index ee5a5352dc..a2fa407b98 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -154,7 +154,7 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
     g_free(s);
 }
 
-static bool virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
+static void virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
                                                 VirtQueue *vq)
 {
     VirtIOBlock *s = (VirtIOBlock *)vdev;
@@ -162,7 +162,7 @@ static bool virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
     assert(s->dataplane);
     assert(s->dataplane_started);
 
-    return virtio_blk_handle_vq(s, vq);
+    virtio_blk_handle_vq(s, vq);
 }
 
 /* Context: QEMU global mutex held */
diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
index 18eb824c97..76137de67f 100644
--- a/hw/scsi/virtio-scsi-dataplane.c
+++ b/hw/scsi/virtio-scsi-dataplane.c
@@ -49,49 +49,43 @@ void virtio_scsi_dataplane_setup(VirtIOSCSI *s, Error **errp)
     }
 }
 
-static bool virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
                                               VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_cmd_vq(s, vq);
+        virtio_scsi_handle_cmd_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
-static bool virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
                                                VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_ctrl_vq(s, vq);
+        virtio_scsi_handle_ctrl_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
-static bool virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
+static void virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
                                                 VirtQueue *vq)
 {
-    bool progress = false;
     VirtIOSCSI *s = VIRTIO_SCSI(vdev);
 
     virtio_scsi_acquire(s);
     if (!s->dataplane_fenced) {
         assert(s->ctx && s->dataplane_started);
-        progress = virtio_scsi_handle_event_vq(s, vq);
+        virtio_scsi_handle_event_vq(s, vq);
     }
     virtio_scsi_release(s);
-    return progress;
 }
 
 static int virtio_scsi_set_host_notifier(VirtIOSCSI *s, VirtQueue *vq, int n)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 0039e1c74c..c042be3935 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -125,7 +125,7 @@ struct VirtQueue
 
     uint16_t vector;
     VirtIOHandleOutput handle_output;
-    VirtIOHandleAIOOutput handle_aio_output;
+    VirtIOHandleOutput handle_aio_output;
     VirtIODevice *vdev;
     EventNotifier guest_notifier;
     EventNotifier host_notifier;
@@ -2300,22 +2300,18 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int align)
     }
 }
 
-static bool virtio_queue_notify_aio_vq(VirtQueue *vq)
+static void virtio_queue_notify_aio_vq(VirtQueue *vq)
 {
-    bool ret = false;
-
     if (vq->vring.desc && vq->handle_aio_output) {
         VirtIODevice *vdev = vq->vdev;
 
         trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
-        ret = vq->handle_aio_output(vdev, vq);
+        vq->handle_aio_output(vdev, vq);
 
         if (unlikely(vdev->start_on_kick)) {
             virtio_set_started(vdev, true);
         }
     }
-
-    return ret;
 }
 
 static void virtio_queue_notify_vq(VirtQueue *vq)
@@ -3552,7 +3548,7 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
 }
 
 void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-                                                VirtIOHandleAIOOutput handle_output)
+        VirtIOHandleOutput handle_output)
 {
     if (handle_output) {
         vq->handle_aio_output = handle_output;
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:25:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:25:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241099.417951 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTF-0005i2-2J; Tue, 07 Dec 2021 13:25:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241099.417951; Tue, 07 Dec 2021 13:25:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTE-0005hv-UQ; Tue, 07 Dec 2021 13:25:24 +0000
Received: by outflank-mailman (input) for mailman id 241099;
 Tue, 07 Dec 2021 13:25:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaTD-0004L1-Gd
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:25:23 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 20df2204-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:25:22 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-29-5v2E1M36P3K2-fPgHlnIgA-1; Tue, 07 Dec 2021 08:25:18 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7C17A1B2C980;
 Tue,  7 Dec 2021 13:25:16 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 08DE818369;
 Tue,  7 Dec 2021 13:25:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20df2204-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883521;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tv6ZgPeF9JqTqvfrT/Nt5ske7VQh6DKKAYcNLfnUvF0=;
	b=bvbBb+LVwVqgLle+ai235/CUQZ6nKtPJ1gGsUO2yZx1YRR5he2arpu0E+TUHCm1wu9gK9t
	jAG680Siz39JIbKc1a+wD+4s225SesvRPHTxcU+ek+uxjv+7nSVem8kzZbZHOFi0G/ya34
	jz+zj1VBt1InDeFnhGr+Z5StFwe3CVc=
X-MC-Unique: 5v2E1M36P3K2-fPgHlnIgA-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 3/6] virtio-blk: drop unused virtio_blk_handle_vq() return value
Date: Tue,  7 Dec 2021 13:23:33 +0000
Message-Id: <20211207132336.36627-4-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The return value of virtio_blk_handle_vq() is no longer used. Get rid of
it. This is a step towards unifying the dataplane and non-dataplane
virtqueue handler functions.

Prepare virtio_blk_handle_output() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd more
specific. This way it won't trigger when dataplane has already been
started.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio-blk.h |  2 +-
 hw/block/virtio-blk.c          | 14 +++-----------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index 29655a406d..d311c57cca 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -90,7 +90,7 @@ typedef struct MultiReqBuffer {
     bool is_write;
 } MultiReqBuffer;
 
-bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);
+void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq);
 void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh);
 
 #endif
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index f139cd7cc9..82676cdd01 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -767,12 +767,11 @@ static int virtio_blk_handle_request(VirtIOBlockReq *req, MultiReqBuffer *mrb)
     return 0;
 }
 
-bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
+void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
 {
     VirtIOBlockReq *req;
     MultiReqBuffer mrb = {};
     bool suppress_notifications = virtio_queue_get_notification(vq);
-    bool progress = false;
 
     aio_context_acquire(blk_get_aio_context(s->blk));
     blk_io_plug(s->blk);
@@ -783,7 +782,6 @@ bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
         }
 
         while ((req = virtio_blk_get_request(s, vq))) {
-            progress = true;
             if (virtio_blk_handle_request(req, &mrb)) {
                 virtqueue_detach_element(req->vq, &req->elem, 0);
                 virtio_blk_free_request(req);
@@ -802,19 +800,13 @@ bool virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue *vq)
 
     blk_io_unplug(s->blk);
     aio_context_release(blk_get_aio_context(s->blk));
-    return progress;
-}
-
-static void virtio_blk_handle_output_do(VirtIOBlock *s, VirtQueue *vq)
-{
-    virtio_blk_handle_vq(s, vq);
 }
 
 static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
 {
     VirtIOBlock *s = (VirtIOBlock *)vdev;
 
-    if (s->dataplane) {
+    if (s->dataplane && !s->dataplane_started) {
         /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
          * dataplane here instead of waiting for .set_status().
          */
@@ -823,7 +815,7 @@ static void virtio_blk_handle_output(VirtIODevice *vdev, VirtQueue *vq)
             return;
         }
     }
-    virtio_blk_handle_output_do(s, vq);
+    virtio_blk_handle_vq(s, vq);
 }
 
 void virtio_blk_process_queued_requests(VirtIOBlock *s, bool is_bh)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:25:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:25:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241100.417958 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTF-0005ow-Ji; Tue, 07 Dec 2021 13:25:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241100.417958; Tue, 07 Dec 2021 13:25:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTF-0005lZ-Dt; Tue, 07 Dec 2021 13:25:25 +0000
Received: by outflank-mailman (input) for mailman id 241100;
 Tue, 07 Dec 2021 13:25:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaTE-0005E4-De
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:25:24 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 219b590d-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:25:23 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-580-DM0wwHUtMdKzxeYJFKTcpA-1; Tue, 07 Dec 2021 08:25:19 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1414A94DC1;
 Tue,  7 Dec 2021 13:25:18 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A37FF5DF2B;
 Tue,  7 Dec 2021 13:25:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 219b590d-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883522;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/qrMGrCx4V1veFpfg1+YpXhPcgKpzBIeI/WEMjnuXFg=;
	b=QGACm8MVzmylj/KsiehQj6G5b9hc4UesX43BzaIR2TbYdOpDvFGTo3hMlC/+jKo5dcTSzR
	RHLY4TbUos8ICycm9W75F4EwCbDnAJryUvaMltfQFKtHS6EihLWxUhSlpLhqICPdNWaaCx
	o+MkX4x7zganFW17RxE7Xvt+4mTK7Eo=
X-MC-Unique: DM0wwHUtMdKzxeYJFKTcpA-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 4/6] virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane
Date: Tue,  7 Dec 2021 13:23:34 +0000
Message-Id: <20211207132336.36627-5-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Prepare virtio_scsi_handle_cmd() to be used by both dataplane and
non-dataplane by making the condition for starting ioeventfd more
specific. This way it won't trigger when dataplane has already been
started.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/scsi/virtio-scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 51fd09522a..34a968ecfb 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -720,7 +720,7 @@ static void virtio_scsi_handle_cmd(VirtIODevice *vdev, VirtQueue *vq)
     /* use non-QOM casts in the data path */
     VirtIOSCSI *s = (VirtIOSCSI *)vdev;
 
-    if (s->ctx) {
+    if (s->ctx && !s->dataplane_started) {
         virtio_device_start_ioeventfd(vdev);
         if (!s->dataplane_fenced) {
             return;
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:25:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:25:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241101.417964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTG-0005uA-3P; Tue, 07 Dec 2021 13:25:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241101.417964; Tue, 07 Dec 2021 13:25:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaTF-0005sd-Oy; Tue, 07 Dec 2021 13:25:25 +0000
Received: by outflank-mailman (input) for mailman id 241101;
 Tue, 07 Dec 2021 13:25:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaTE-0004L1-GV
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:25:24 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 20936bba-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:25:22 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-164-NQ2AWngvN_SB0LkVuqUr6Q-1; Tue, 07 Dec 2021 08:25:15 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E631100CCC2;
 Tue,  7 Dec 2021 13:25:13 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 7CBEB5F70B;
 Tue,  7 Dec 2021 13:24:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20936bba-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883521;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=v5ZIiRt4KLtGb7deDhjk23bPSS6l6VS3Mmm4xClV2xc=;
	b=GyZzmn4IwhLiNQPpOaRTsT2Jj9J8SehRiGDfPKlAv9rroJM5FIaKXY+iDNkkYr2d6OxDfw
	FuGgM8Rm4cPMktW+cwXxi1F9Fvb969p4ajpFepR8aRfzelbTa+bB6Npx1188TjcV4/moYU
	4E3knRrCzigegm28D5PwTLSoQaYLoe4=
X-MC-Unique: NQ2AWngvN_SB0LkVuqUr6Q-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 1/6] aio-posix: split poll check from ready handler
Date: Tue,  7 Dec 2021 13:23:31 +0000
Message-Id: <20211207132336.36627-2-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Adaptive polling measures the execution time of the polling check plus
handlers called when a polled event becomes ready. Handlers can take a
significant amount of time, making it look like polling was running for
a long time when in fact the event handler was running for a long time.

For example, on Linux the io_submit(2) syscall invoked when a virtio-blk
device's virtqueue becomes ready can take 10s of microseconds. This
can exceed the default polling interval (32 microseconds) and cause
adaptive polling to stop polling.

By excluding the handler's execution time from the polling check we make
the adaptive polling calculation more accurate. As a result, the event
loop now stays in polling mode where previously it would have fallen
back to file descriptor monitoring.

The following data was collected with virtio-blk num-queues=2
event_idx=off using an IOThread. Before:

168k IOPS, IOThread syscalls:

  9837.115 ( 0.020 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 16, iocbpp: 0x7fcb9f937db0)    = 16
  9837.158 ( 0.002 ms): IO iothread1/620155 write(fd: 103, buf: 0x556a2ef71b88, count: 8)                         = 8
  9837.161 ( 0.001 ms): IO iothread1/620155 write(fd: 104, buf: 0x556a2ef71b88, count: 8)                         = 8
  9837.163 ( 0.001 ms): IO iothread1/620155 ppoll(ufds: 0x7fcb90002800, nfds: 4, tsp: 0x7fcb9f1342d0, sigsetsize: 8) = 3
  9837.164 ( 0.001 ms): IO iothread1/620155 read(fd: 107, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.174 ( 0.001 ms): IO iothread1/620155 read(fd: 105, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.176 ( 0.001 ms): IO iothread1/620155 read(fd: 106, buf: 0x7fcb9f939cc0, count: 512)                        = 8
  9837.209 ( 0.035 ms): IO iothread1/620155 io_submit(ctx_id: 140512552468480, nr: 32, iocbpp: 0x7fca7d0cebe0)    = 32

174k IOPS (+3.6%), IOThread syscalls:

  9809.566 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0cdd62be0)    = 32
  9809.625 ( 0.001 ms): IO iothread1/623061 write(fd: 103, buf: 0x5647cfba5f58, count: 8)                         = 8
  9809.627 ( 0.002 ms): IO iothread1/623061 write(fd: 104, buf: 0x5647cfba5f58, count: 8)                         = 8
  9809.663 ( 0.036 ms): IO iothread1/623061 io_submit(ctx_id: 140539805028352, nr: 32, iocbpp: 0x7fd0d0388b50)    = 32

Notice that ppoll(2) and eventfd read(2) syscalls are eliminated because
the IOThread stays in polling mode instead of falling back to file
descriptor monitoring.

As usual, polling is not implemented on Windows so this patch ignores
the new io_poll_read() callback in aio-win32.c.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/block/aio.h      |  4 +-
 util/aio-posix.h         |  1 +
 block/curl.c             | 11 ++---
 block/export/fuse.c      |  4 +-
 block/io_uring.c         | 19 +++++----
 block/iscsi.c            |  4 +-
 block/linux-aio.c        | 16 +++++---
 block/nfs.c              |  6 +--
 block/nvme.c             | 51 +++++++++++++++--------
 block/ssh.c              |  4 +-
 block/win32-aio.c        |  4 +-
 hw/virtio/virtio.c       | 16 +++++---
 hw/xen/xen-bus.c         |  6 +--
 io/channel-command.c     |  6 ++-
 io/channel-file.c        |  3 +-
 io/channel-socket.c      |  3 +-
 migration/rdma.c         |  8 ++--
 tests/unit/test-aio.c    |  4 +-
 util/aio-posix.c         | 89 ++++++++++++++++++++++++++++++----------
 util/aio-win32.c         |  4 +-
 util/async.c             | 10 ++++-
 util/main-loop.c         |  4 +-
 util/qemu-coroutine-io.c |  5 ++-
 util/vhost-user-server.c | 11 ++---
 24 files changed, 191 insertions(+), 102 deletions(-)

diff --git a/include/block/aio.h b/include/block/aio.h
index 47fbe9d81f..5634173b12 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -469,6 +469,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque);
 
 /* Set polling begin/end callbacks for a file descriptor that has already been
@@ -490,7 +491,8 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *notifier,
                             bool is_external,
                             EventNotifierHandler *io_read,
-                            AioPollFn *io_poll);
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready);
 
 /* Set polling begin/end callbacks for an event notifier that has already been
  * registered with aio_set_event_notifier.  Do nothing if the event notifier is
diff --git a/util/aio-posix.h b/util/aio-posix.h
index c80c04506a..7f2c37a684 100644
--- a/util/aio-posix.h
+++ b/util/aio-posix.h
@@ -24,6 +24,7 @@ struct AioHandler {
     IOHandler *io_read;
     IOHandler *io_write;
     AioPollFn *io_poll;
+    IOHandler *io_poll_ready;
     IOHandler *io_poll_begin;
     IOHandler *io_poll_end;
     void *opaque;
diff --git a/block/curl.c b/block/curl.c
index 4a8ae2b269..6a6cd72975 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -125,7 +125,7 @@ static gboolean curl_drop_socket(void *key, void *value, void *opaque)
     BDRVCURLState *s = socket->s;
 
     aio_set_fd_handler(s->aio_context, socket->fd, false,
-                       NULL, NULL, NULL, NULL);
+                       NULL, NULL, NULL, NULL, NULL);
     return true;
 }
 
@@ -173,19 +173,20 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
     switch (action) {
         case CURL_POLL_IN:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               curl_multi_do, NULL, NULL, socket);
+                               curl_multi_do, NULL, NULL, NULL, socket);
             break;
         case CURL_POLL_OUT:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               NULL, curl_multi_do, NULL, socket);
+                               NULL, curl_multi_do, NULL, NULL, socket);
             break;
         case CURL_POLL_INOUT:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               curl_multi_do, curl_multi_do, NULL, socket);
+                               curl_multi_do, curl_multi_do,
+                               NULL, NULL, socket);
             break;
         case CURL_POLL_REMOVE:
             aio_set_fd_handler(s->aio_context, fd, false,
-                               NULL, NULL, NULL, NULL);
+                               NULL, NULL, NULL, NULL, NULL);
             break;
     }
 
diff --git a/block/export/fuse.c b/block/export/fuse.c
index 823c126d23..6710d8aed8 100644
--- a/block/export/fuse.c
+++ b/block/export/fuse.c
@@ -223,7 +223,7 @@ static int setup_fuse_export(FuseExport *exp, const char *mountpoint,
 
     aio_set_fd_handler(exp->common.ctx,
                        fuse_session_fd(exp->fuse_session), true,
-                       read_from_fuse_export, NULL, NULL, exp);
+                       read_from_fuse_export, NULL, NULL, NULL, exp);
     exp->fd_handler_set_up = true;
 
     return 0;
@@ -267,7 +267,7 @@ static void fuse_export_shutdown(BlockExport *blk_exp)
         if (exp->fd_handler_set_up) {
             aio_set_fd_handler(exp->common.ctx,
                                fuse_session_fd(exp->fuse_session), true,
-                               NULL, NULL, NULL, NULL);
+                               NULL, NULL, NULL, NULL, NULL);
             exp->fd_handler_set_up = false;
         }
     }
diff --git a/block/io_uring.c b/block/io_uring.c
index dfa475cc87..782afdb433 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -292,12 +292,14 @@ static bool qemu_luring_poll_cb(void *opaque)
 {
     LuringState *s = opaque;
 
-    if (io_uring_cq_ready(&s->ring)) {
-        luring_process_completions_and_submit(s);
-        return true;
-    }
+    return io_uring_cq_ready(&s->ring);
+}
 
-    return false;
+static void qemu_luring_poll_ready(void *opaque)
+{
+    LuringState *s = opaque;
+
+    luring_process_completions_and_submit(s);
 }
 
 static void ioq_init(LuringQueue *io_q)
@@ -402,8 +404,8 @@ int coroutine_fn luring_co_submit(BlockDriverState *bs, LuringState *s, int fd,
 
 void luring_detach_aio_context(LuringState *s, AioContext *old_context)
 {
-    aio_set_fd_handler(old_context, s->ring.ring_fd, false, NULL, NULL, NULL,
-                       s);
+    aio_set_fd_handler(old_context, s->ring.ring_fd, false,
+                       NULL, NULL, NULL, NULL, s);
     qemu_bh_delete(s->completion_bh);
     s->aio_context = NULL;
 }
@@ -413,7 +415,8 @@ void luring_attach_aio_context(LuringState *s, AioContext *new_context)
     s->aio_context = new_context;
     s->completion_bh = aio_bh_new(new_context, qemu_luring_completion_bh, s);
     aio_set_fd_handler(s->aio_context, s->ring.ring_fd, false,
-                       qemu_luring_completion_cb, NULL, qemu_luring_poll_cb, s);
+                       qemu_luring_completion_cb, NULL,
+                       qemu_luring_poll_cb, qemu_luring_poll_ready, s);
 }
 
 LuringState *luring_init(Error **errp)
diff --git a/block/iscsi.c b/block/iscsi.c
index 57aa07a40d..51f2a5eeaa 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -363,7 +363,7 @@ iscsi_set_events(IscsiLun *iscsilun)
                            false,
                            (ev & POLLIN) ? iscsi_process_read : NULL,
                            (ev & POLLOUT) ? iscsi_process_write : NULL,
-                           NULL,
+                           NULL, NULL,
                            iscsilun);
         iscsilun->events = ev;
     }
@@ -1534,7 +1534,7 @@ static void iscsi_detach_aio_context(BlockDriverState *bs)
     IscsiLun *iscsilun = bs->opaque;
 
     aio_set_fd_handler(iscsilun->aio_context, iscsi_get_fd(iscsilun->iscsi),
-                       false, NULL, NULL, NULL, NULL);
+                       false, NULL, NULL, NULL, NULL, NULL);
     iscsilun->events = 0;
 
     if (iscsilun->nop_timer) {
diff --git a/block/linux-aio.c b/block/linux-aio.c
index f53ae72e21..4c423fcccf 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -263,12 +263,15 @@ static bool qemu_laio_poll_cb(void *opaque)
     LinuxAioState *s = container_of(e, LinuxAioState, e);
     struct io_event *events;
 
-    if (!io_getevents_peek(s->ctx, &events)) {
-        return false;
-    }
+    return io_getevents_peek(s->ctx, &events);
+}
+
+static void qemu_laio_poll_ready(EventNotifier *opaque)
+{
+    EventNotifier *e = opaque;
+    LinuxAioState *s = container_of(e, LinuxAioState, e);
 
     qemu_laio_process_completions_and_submit(s);
-    return true;
 }
 
 static void ioq_init(LaioQueue *io_q)
@@ -427,7 +430,7 @@ int coroutine_fn laio_co_submit(BlockDriverState *bs, LinuxAioState *s, int fd,
 
 void laio_detach_aio_context(LinuxAioState *s, AioContext *old_context)
 {
-    aio_set_event_notifier(old_context, &s->e, false, NULL, NULL);
+    aio_set_event_notifier(old_context, &s->e, false, NULL, NULL, NULL);
     qemu_bh_delete(s->completion_bh);
     s->aio_context = NULL;
 }
@@ -438,7 +441,8 @@ void laio_attach_aio_context(LinuxAioState *s, AioContext *new_context)
     s->completion_bh = aio_bh_new(new_context, qemu_laio_completion_bh, s);
     aio_set_event_notifier(new_context, &s->e, false,
                            qemu_laio_completion_cb,
-                           qemu_laio_poll_cb);
+                           qemu_laio_poll_cb,
+                           qemu_laio_poll_ready);
 }
 
 LinuxAioState *laio_init(Error **errp)
diff --git a/block/nfs.c b/block/nfs.c
index 577aea1d22..444c40b458 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -197,7 +197,7 @@ static void nfs_set_events(NFSClient *client)
                            false,
                            (ev & POLLIN) ? nfs_process_read : NULL,
                            (ev & POLLOUT) ? nfs_process_write : NULL,
-                           NULL, client);
+                           NULL, NULL, client);
 
     }
     client->events = ev;
@@ -372,7 +372,7 @@ static void nfs_detach_aio_context(BlockDriverState *bs)
     NFSClient *client = bs->opaque;
 
     aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context),
-                       false, NULL, NULL, NULL, NULL);
+                       false, NULL, NULL, NULL, NULL, NULL);
     client->events = 0;
 }
 
@@ -390,7 +390,7 @@ static void nfs_client_close(NFSClient *client)
     if (client->context) {
         qemu_mutex_lock(&client->mutex);
         aio_set_fd_handler(client->aio_context, nfs_get_fd(client->context),
-                           false, NULL, NULL, NULL, NULL);
+                           false, NULL, NULL, NULL, NULL, NULL);
         qemu_mutex_unlock(&client->mutex);
         if (client->fh) {
             nfs_close(client->context, client->fh);
diff --git a/block/nvme.c b/block/nvme.c
index e4f336d79c..e3b82e345c 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -604,10 +604,8 @@ out:
     return ret;
 }
 
-static bool nvme_poll_queue(NVMeQueuePair *q)
+static void nvme_poll_queue(NVMeQueuePair *q)
 {
-    bool progress = false;
-
     const size_t cqe_offset = q->cq.head * NVME_CQ_ENTRY_BYTES;
     NvmeCqe *cqe = (NvmeCqe *)&q->cq.queue[cqe_offset];
 
@@ -618,30 +616,23 @@ static bool nvme_poll_queue(NVMeQueuePair *q)
      * cannot race with itself.
      */
     if ((le16_to_cpu(cqe->status) & 0x1) == q->cq_phase) {
-        return false;
+        return;
     }
 
     qemu_mutex_lock(&q->lock);
     while (nvme_process_completion(q)) {
         /* Keep polling */
-        progress = true;
     }
     qemu_mutex_unlock(&q->lock);
-
-    return progress;
 }
 
-static bool nvme_poll_queues(BDRVNVMeState *s)
+static void nvme_poll_queues(BDRVNVMeState *s)
 {
-    bool progress = false;
     int i;
 
     for (i = 0; i < s->queue_count; i++) {
-        if (nvme_poll_queue(s->queues[i])) {
-            progress = true;
-        }
+        nvme_poll_queue(s->queues[i]);
     }
-    return progress;
 }
 
 static void nvme_handle_event(EventNotifier *n)
@@ -702,8 +693,30 @@ static bool nvme_poll_cb(void *opaque)
     EventNotifier *e = opaque;
     BDRVNVMeState *s = container_of(e, BDRVNVMeState,
                                     irq_notifier[MSIX_SHARED_IRQ_IDX]);
+    int i;
 
-    return nvme_poll_queues(s);
+    for (i = 0; i < s->queue_count; i++) {
+        NVMeQueuePair *q = s->queues[i];
+        const size_t cqe_offset = q->cq.head * NVME_CQ_ENTRY_BYTES;
+        NvmeCqe *cqe = (NvmeCqe *)&q->cq.queue[cqe_offset];
+
+        /*
+         * q->lock isn't needed because nvme_process_completion() only runs in
+         * the event loop thread and cannot race with itself.
+         */
+        if ((le16_to_cpu(cqe->status) & 0x1) != q->cq_phase) {
+            return true;
+        }
+    }
+    return false;
+}
+
+static void nvme_poll_ready(EventNotifier *e)
+{
+    BDRVNVMeState *s = container_of(e, BDRVNVMeState,
+                                    irq_notifier[MSIX_SHARED_IRQ_IDX]);
+
+    nvme_poll_queues(s);
 }
 
 static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
@@ -838,7 +851,8 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
     }
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, nvme_handle_event, nvme_poll_cb);
+                           false, nvme_handle_event, nvme_poll_cb,
+                           nvme_poll_ready);
 
     if (!nvme_identify(bs, namespace, errp)) {
         ret = -EIO;
@@ -923,7 +937,7 @@ static void nvme_close(BlockDriverState *bs)
     g_free(s->queues);
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, NULL, NULL);
+                           false, NULL, NULL, NULL);
     event_notifier_cleanup(&s->irq_notifier[MSIX_SHARED_IRQ_IDX]);
     qemu_vfio_pci_unmap_bar(s->vfio, 0, s->bar0_wo_map,
                             0, sizeof(NvmeBar) + NVME_DOORBELL_SIZE);
@@ -1519,7 +1533,7 @@ static void nvme_detach_aio_context(BlockDriverState *bs)
 
     aio_set_event_notifier(bdrv_get_aio_context(bs),
                            &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, NULL, NULL);
+                           false, NULL, NULL, NULL);
 }
 
 static void nvme_attach_aio_context(BlockDriverState *bs,
@@ -1529,7 +1543,8 @@ static void nvme_attach_aio_context(BlockDriverState *bs,
 
     s->aio_context = new_context;
     aio_set_event_notifier(new_context, &s->irq_notifier[MSIX_SHARED_IRQ_IDX],
-                           false, nvme_handle_event, nvme_poll_cb);
+                           false, nvme_handle_event, nvme_poll_cb,
+                           nvme_poll_ready);
 
     for (unsigned i = 0; i < s->queue_count; i++) {
         NVMeQueuePair *q = s->queues[i];
diff --git a/block/ssh.c b/block/ssh.c
index e0fbb4934b..3b5bf34031 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -990,7 +990,7 @@ static void restart_coroutine(void *opaque)
     AioContext *ctx = bdrv_get_aio_context(bs);
 
     trace_ssh_restart_coroutine(restart->co);
-    aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(ctx, s->sock, false, NULL, NULL, NULL, NULL, NULL);
 
     aio_co_wake(restart->co);
 }
@@ -1020,7 +1020,7 @@ static coroutine_fn void co_yield(BDRVSSHState *s, BlockDriverState *bs)
     trace_ssh_co_yield(s->sock, rd_handler, wr_handler);
 
     aio_set_fd_handler(bdrv_get_aio_context(bs), s->sock,
-                       false, rd_handler, wr_handler, NULL, &restart);
+                       false, rd_handler, wr_handler, NULL, NULL, &restart);
     qemu_coroutine_yield();
     trace_ssh_co_yield_back(s->sock);
 }
diff --git a/block/win32-aio.c b/block/win32-aio.c
index b7221a272f..c57e10c997 100644
--- a/block/win32-aio.c
+++ b/block/win32-aio.c
@@ -172,7 +172,7 @@ int win32_aio_attach(QEMUWin32AIOState *aio, HANDLE hfile)
 void win32_aio_detach_aio_context(QEMUWin32AIOState *aio,
                                   AioContext *old_context)
 {
-    aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL);
+    aio_set_event_notifier(old_context, &aio->e, false, NULL, NULL, NULL);
     aio->aio_ctx = NULL;
 }
 
@@ -181,7 +181,7 @@ void win32_aio_attach_aio_context(QEMUWin32AIOState *aio,
 {
     aio->aio_ctx = new_context;
     aio_set_event_notifier(new_context, &aio->e, false,
-                           win32_aio_completion_cb, NULL);
+                           win32_aio_completion_cb, NULL, NULL);
 }
 
 QEMUWin32AIOState *win32_aio_init(void)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index ea7c079fb0..0039e1c74c 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3533,11 +3533,14 @@ static bool virtio_queue_host_notifier_aio_poll(void *opaque)
     EventNotifier *n = opaque;
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
 
-    if (!vq->vring.desc || virtio_queue_empty(vq)) {
-        return false;
-    }
+    return vq->vring.desc && !virtio_queue_empty(vq);
+}
 
-    return virtio_queue_notify_aio_vq(vq);
+static void virtio_queue_host_notifier_aio_poll_ready(EventNotifier *n)
+{
+    VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
+
+    virtio_queue_notify_aio_vq(vq);
 }
 
 static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
@@ -3555,12 +3558,13 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         vq->handle_aio_output = handle_output;
         aio_set_event_notifier(ctx, &vq->host_notifier, true,
                                virtio_queue_host_notifier_aio_read,
-                               virtio_queue_host_notifier_aio_poll);
+                               virtio_queue_host_notifier_aio_poll,
+                               virtio_queue_host_notifier_aio_poll_ready);
         aio_set_event_notifier_poll(ctx, &vq->host_notifier,
                                     virtio_queue_host_notifier_aio_poll_begin,
                                     virtio_queue_host_notifier_aio_poll_end);
     } else {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL);
+        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
         /* Test and clear notifier before after disabling event,
          * in case poll callback didn't have time to run. */
         virtio_queue_host_notifier_aio_read(&vq->host_notifier);
diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
index 416583f130..645a29a5a0 100644
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -1115,11 +1115,11 @@ void xen_device_set_event_channel_context(XenDevice *xendev,
 
     if (channel->ctx)
         aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                           NULL, NULL, NULL, NULL);
+                           NULL, NULL, NULL, NULL, NULL);
 
     channel->ctx = ctx;
     aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                       xen_device_event, NULL, xen_device_poll, channel);
+                       xen_device_event, NULL, xen_device_poll, NULL, channel);
 }
 
 XenEventChannel *xen_device_bind_event_channel(XenDevice *xendev,
@@ -1193,7 +1193,7 @@ void xen_device_unbind_event_channel(XenDevice *xendev,
     QLIST_REMOVE(channel, list);
 
     aio_set_fd_handler(channel->ctx, xenevtchn_fd(channel->xeh), true,
-                       NULL, NULL, NULL, NULL);
+                       NULL, NULL, NULL, NULL, NULL);
 
     if (xenevtchn_unbind(channel->xeh, channel->local_port) < 0) {
         error_setg_errno(errp, errno, "xenevtchn_unbind failed");
diff --git a/io/channel-command.c b/io/channel-command.c
index b2a9e27138..338da73ade 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -346,8 +346,10 @@ static void qio_channel_command_set_aio_fd_handler(QIOChannel *ioc,
                                                    void *opaque)
 {
     QIOChannelCommand *cioc = QIO_CHANNEL_COMMAND(ioc);
-    aio_set_fd_handler(ctx, cioc->readfd, false, io_read, NULL, NULL, opaque);
-    aio_set_fd_handler(ctx, cioc->writefd, false, NULL, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, cioc->readfd, false,
+                       io_read, NULL, NULL, NULL, opaque);
+    aio_set_fd_handler(ctx, cioc->writefd, false,
+                       NULL, io_write, NULL, NULL, opaque);
 }
 
 
diff --git a/io/channel-file.c b/io/channel-file.c
index c4bf799a80..d7cf6d278f 100644
--- a/io/channel-file.c
+++ b/io/channel-file.c
@@ -191,7 +191,8 @@ static void qio_channel_file_set_aio_fd_handler(QIOChannel *ioc,
                                                 void *opaque)
 {
     QIOChannelFile *fioc = QIO_CHANNEL_FILE(ioc);
-    aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, fioc->fd, false, io_read, io_write,
+                       NULL, NULL, opaque);
 }
 
 static GSource *qio_channel_file_create_watch(QIOChannel *ioc,
diff --git a/io/channel-socket.c b/io/channel-socket.c
index 606ec97cf7..459922c874 100644
--- a/io/channel-socket.c
+++ b/io/channel-socket.c
@@ -761,7 +761,8 @@ static void qio_channel_socket_set_aio_fd_handler(QIOChannel *ioc,
                                                   void *opaque)
 {
     QIOChannelSocket *sioc = QIO_CHANNEL_SOCKET(ioc);
-    aio_set_fd_handler(ctx, sioc->fd, false, io_read, io_write, NULL, opaque);
+    aio_set_fd_handler(ctx, sioc->fd, false,
+                       io_read, io_write, NULL, NULL, opaque);
 }
 
 static GSource *qio_channel_socket_create_watch(QIOChannel *ioc,
diff --git a/migration/rdma.c b/migration/rdma.c
index f5d3bbe7e9..c7c7a38487 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3161,14 +3161,14 @@ static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc,
     QIOChannelRDMA *rioc = QIO_CHANNEL_RDMA(ioc);
     if (io_read) {
         aio_set_fd_handler(ctx, rioc->rdmain->recv_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
         aio_set_fd_handler(ctx, rioc->rdmain->send_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
     } else {
         aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
         aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd,
-                           false, io_read, io_write, NULL, opaque);
+                           false, io_read, io_write, NULL, NULL, opaque);
     }
 }
 
diff --git a/tests/unit/test-aio.c b/tests/unit/test-aio.c
index 6feeb9a4a9..178048d2f2 100644
--- a/tests/unit/test-aio.c
+++ b/tests/unit/test-aio.c
@@ -130,7 +130,7 @@ static void *test_acquire_thread(void *opaque)
 static void set_event_notifier(AioContext *ctx, EventNotifier *notifier,
                                EventNotifierHandler *handler)
 {
-    aio_set_event_notifier(ctx, notifier, false, handler, NULL);
+    aio_set_event_notifier(ctx, notifier, false, handler, NULL, NULL);
 }
 
 static void dummy_notifier_read(EventNotifier *n)
@@ -390,7 +390,7 @@ static void test_aio_external_client(void)
     for (i = 1; i < 3; i++) {
         EventNotifierTestData data = { .n = 0, .active = 10, .auto_set = true };
         event_notifier_init(&data.e, false);
-        aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL);
+        aio_set_event_notifier(ctx, &data.e, true, event_ready_cb, NULL, NULL);
         event_notifier_set(&data.e);
         for (j = 0; j < i; j++) {
             aio_disable_external(ctx);
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 2b86777e91..7b9f629218 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -23,6 +23,15 @@
 #include "trace.h"
 #include "aio-posix.h"
 
+/*
+ * G_IO_IN and G_IO_OUT are not appropriate revents values for polling, since
+ * the handler may not need to access the file descriptor. For example, the
+ * handler doesn't need to read from an EventNotifier if it polled a memory
+ * location and a read syscall would be slow. Define our own unique revents
+ * value to indicate that polling determined this AioHandler is ready.
+ */
+#define REVENTS_POLL_READY 0
+
 /* Stop userspace polling on a handler if it isn't active for some time */
 #define POLL_IDLE_INTERVAL_NS (7 * NANOSECONDS_PER_SECOND)
 
@@ -93,6 +102,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque)
 {
     AioHandler *node;
@@ -101,6 +111,10 @@ void aio_set_fd_handler(AioContext *ctx,
     bool deleted = false;
     int poll_disable_change;
 
+    if (io_poll && !io_poll_ready) {
+        io_poll = NULL; /* polling only makes sense if there is a handler */
+    }
+
     qemu_lockcnt_lock(&ctx->list_lock);
 
     node = find_aio_handler(ctx, fd);
@@ -127,6 +141,7 @@ void aio_set_fd_handler(AioContext *ctx,
         new_node->io_read = io_read;
         new_node->io_write = io_write;
         new_node->io_poll = io_poll;
+        new_node->io_poll_ready = io_poll_ready;
         new_node->opaque = opaque;
         new_node->is_external = is_external;
 
@@ -182,10 +197,12 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *notifier,
                             bool is_external,
                             EventNotifierHandler *io_read,
-                            AioPollFn *io_poll)
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready)
 {
     aio_set_fd_handler(ctx, event_notifier_get_fd(notifier), is_external,
-                       (IOHandler *)io_read, NULL, io_poll, notifier);
+                       (IOHandler *)io_read, NULL, io_poll,
+                       (IOHandler *)io_poll_ready, notifier);
 }
 
 void aio_set_event_notifier_poll(AioContext *ctx,
@@ -198,7 +215,8 @@ void aio_set_event_notifier_poll(AioContext *ctx,
                     (IOHandler *)io_poll_end);
 }
 
-static bool poll_set_started(AioContext *ctx, bool started)
+static bool poll_set_started(AioContext *ctx, AioHandlerList *ready_list,
+                             bool started)
 {
     AioHandler *node;
     bool progress = false;
@@ -228,8 +246,9 @@ static bool poll_set_started(AioContext *ctx, bool started)
         }
 
         /* Poll one last time in case ->io_poll_end() raced with the event */
-        if (!started) {
-            progress = node->io_poll(node->opaque) || progress;
+        if (!started && node->io_poll(node->opaque)) {
+            aio_add_ready_handler(ready_list, node, REVENTS_POLL_READY);
+            progress = true;
         }
     }
     qemu_lockcnt_dec(&ctx->list_lock);
@@ -240,8 +259,11 @@ static bool poll_set_started(AioContext *ctx, bool started)
 
 bool aio_prepare(AioContext *ctx)
 {
+    AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list);
+
     /* Poll mode cannot be used with glib's event loop, disable it. */
-    poll_set_started(ctx, false);
+    poll_set_started(ctx, &ready_list, false);
+    /* TODO what to do with this list? */
 
     return false;
 }
@@ -321,6 +343,18 @@ static bool aio_dispatch_handler(AioContext *ctx, AioHandler *node)
         }
         QLIST_INSERT_HEAD(&ctx->poll_aio_handlers, node, node_poll);
     }
+    if (!QLIST_IS_INSERTED(node, node_deleted) &&
+        revents == 0 &&
+        aio_node_check(ctx, node->is_external) &&
+        node->io_poll_ready) {
+        node->io_poll_ready(node->opaque);
+
+        /*
+         * Return early since revents was zero. aio_notify() does not count as
+         * progress.
+         */
+        return node->opaque != &ctx->notifier;
+    }
 
     if (!QLIST_IS_INSERTED(node, node_deleted) &&
         (revents & (G_IO_IN | G_IO_HUP | G_IO_ERR)) &&
@@ -387,6 +421,7 @@ void aio_dispatch(AioContext *ctx)
 }
 
 static bool run_poll_handlers_once(AioContext *ctx,
+                                   AioHandlerList *ready_list,
                                    int64_t now,
                                    int64_t *timeout)
 {
@@ -397,6 +432,8 @@ static bool run_poll_handlers_once(AioContext *ctx,
     QLIST_FOREACH_SAFE(node, &ctx->poll_aio_handlers, node_poll, tmp) {
         if (aio_node_check(ctx, node->is_external) &&
             node->io_poll(node->opaque)) {
+            aio_add_ready_handler(ready_list, node, REVENTS_POLL_READY);
+
             node->poll_idle_timeout = now + POLL_IDLE_INTERVAL_NS;
 
             /*
@@ -420,7 +457,9 @@ static bool fdmon_supports_polling(AioContext *ctx)
     return ctx->fdmon_ops->need_wait != aio_poll_disabled;
 }
 
-static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
+static bool remove_idle_poll_handlers(AioContext *ctx,
+                                      AioHandlerList *ready_list,
+                                      int64_t now)
 {
     AioHandler *node;
     AioHandler *tmp;
@@ -451,7 +490,11 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
                  * Nevermind about re-adding the handler in the rare case where
                  * this causes progress.
                  */
-                progress = node->io_poll(node->opaque) || progress;
+                if (node->io_poll(node->opaque)) {
+                    aio_add_ready_handler(ready_list, node,
+                                          REVENTS_POLL_READY);
+                    progress = true;
+                }
             }
         }
     }
@@ -461,6 +504,7 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
 
 /* run_poll_handlers:
  * @ctx: the AioContext
+ * @ready_list: the list to place ready handlers on
  * @max_ns: maximum time to poll for, in nanoseconds
  *
  * Polls for a given time.
@@ -469,7 +513,8 @@ static bool remove_idle_poll_handlers(AioContext *ctx, int64_t now)
  *
  * Returns: true if progress was made, false otherwise
  */
-static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
+static bool run_poll_handlers(AioContext *ctx, AioHandlerList *ready_list,
+                              int64_t max_ns, int64_t *timeout)
 {
     bool progress;
     int64_t start_time, elapsed_time;
@@ -490,13 +535,15 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
 
     start_time = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
     do {
-        progress = run_poll_handlers_once(ctx, start_time, timeout);
+        progress = run_poll_handlers_once(ctx, ready_list,
+                                          start_time, timeout);
         elapsed_time = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - start_time;
         max_ns = qemu_soonest_timeout(*timeout, max_ns);
         assert(!(max_ns && progress));
     } while (elapsed_time < max_ns && !ctx->fdmon_ops->need_wait(ctx));
 
-    if (remove_idle_poll_handlers(ctx, start_time + elapsed_time)) {
+    if (remove_idle_poll_handlers(ctx, ready_list,
+                                  start_time + elapsed_time)) {
         *timeout = 0;
         progress = true;
     }
@@ -514,6 +561,7 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
 
 /* try_poll_mode:
  * @ctx: the AioContext
+ * @ready_list: list to add handlers that need to be run
  * @timeout: timeout for blocking wait, computed by the caller and updated if
  *    polling succeeds.
  *
@@ -521,7 +569,8 @@ static bool run_poll_handlers(AioContext *ctx, int64_t max_ns, int64_t *timeout)
  *
  * Returns: true if progress was made, false otherwise
  */
-static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
+static bool try_poll_mode(AioContext *ctx, AioHandlerList *ready_list,
+                          int64_t *timeout)
 {
     int64_t max_ns;
 
@@ -531,14 +580,14 @@ static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
 
     max_ns = qemu_soonest_timeout(*timeout, ctx->poll_ns);
     if (max_ns && !ctx->fdmon_ops->need_wait(ctx)) {
-        poll_set_started(ctx, true);
+        poll_set_started(ctx, ready_list, true);
 
-        if (run_poll_handlers(ctx, max_ns, timeout)) {
+        if (run_poll_handlers(ctx, ready_list, max_ns, timeout)) {
             return true;
         }
     }
 
-    if (poll_set_started(ctx, false)) {
+    if (poll_set_started(ctx, ready_list, false)) {
         *timeout = 0;
         return true;
     }
@@ -549,7 +598,6 @@ static bool try_poll_mode(AioContext *ctx, int64_t *timeout)
 bool aio_poll(AioContext *ctx, bool blocking)
 {
     AioHandlerList ready_list = QLIST_HEAD_INITIALIZER(ready_list);
-    int ret = 0;
     bool progress;
     bool use_notify_me;
     int64_t timeout;
@@ -574,7 +622,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
     }
 
     timeout = blocking ? aio_compute_timeout(ctx) : 0;
-    progress = try_poll_mode(ctx, &timeout);
+    progress = try_poll_mode(ctx, &ready_list, &timeout);
     assert(!(timeout && progress));
 
     /*
@@ -604,7 +652,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
      * system call---a single round of run_poll_handlers_once suffices.
      */
     if (timeout || ctx->fdmon_ops->need_wait(ctx)) {
-        ret = ctx->fdmon_ops->wait(ctx, &ready_list, timeout);
+        ctx->fdmon_ops->wait(ctx, &ready_list, timeout);
     }
 
     if (use_notify_me) {
@@ -657,10 +705,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
     }
 
     progress |= aio_bh_poll(ctx);
-
-    if (ret > 0) {
-        progress |= aio_dispatch_ready_handlers(ctx, &ready_list);
-    }
+    progress |= aio_dispatch_ready_handlers(ctx, &ready_list);
 
     aio_free_deleted_handlers(ctx);
 
diff --git a/util/aio-win32.c b/util/aio-win32.c
index d5b09a1193..7aac89df3a 100644
--- a/util/aio-win32.c
+++ b/util/aio-win32.c
@@ -68,6 +68,7 @@ void aio_set_fd_handler(AioContext *ctx,
                         IOHandler *io_read,
                         IOHandler *io_write,
                         AioPollFn *io_poll,
+                        IOHandler *io_poll_ready,
                         void *opaque)
 {
     /* fd is a SOCKET in our case */
@@ -136,7 +137,8 @@ void aio_set_event_notifier(AioContext *ctx,
                             EventNotifier *e,
                             bool is_external,
                             EventNotifierHandler *io_notify,
-                            AioPollFn *io_poll)
+                            AioPollFn *io_poll,
+                            EventNotifierHandler *io_poll_ready)
 {
     AioHandler *node;
 
diff --git a/util/async.c b/util/async.c
index 6f6717a34b..08d25feef5 100644
--- a/util/async.c
+++ b/util/async.c
@@ -362,7 +362,7 @@ aio_ctx_finalize(GSource     *source)
         g_free(bh);
     }
 
-    aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL);
+    aio_set_event_notifier(ctx, &ctx->notifier, false, NULL, NULL, NULL);
     event_notifier_cleanup(&ctx->notifier);
     qemu_rec_mutex_destroy(&ctx->lock);
     qemu_lockcnt_destroy(&ctx->list_lock);
@@ -485,6 +485,11 @@ static bool aio_context_notifier_poll(void *opaque)
     return qatomic_read(&ctx->notified);
 }
 
+static void aio_context_notifier_poll_ready(EventNotifier *e)
+{
+    /* Do nothing, we just wanted to kick the event loop */
+}
+
 static void co_schedule_bh_cb(void *opaque)
 {
     AioContext *ctx = opaque;
@@ -536,7 +541,8 @@ AioContext *aio_context_new(Error **errp)
     aio_set_event_notifier(ctx, &ctx->notifier,
                            false,
                            aio_context_notifier_cb,
-                           aio_context_notifier_poll);
+                           aio_context_notifier_poll,
+                           aio_context_notifier_poll_ready);
 #ifdef CONFIG_LINUX_AIO
     ctx->linux_aio = NULL;
 #endif
diff --git a/util/main-loop.c b/util/main-loop.c
index 06b18b195c..4d5a5b9943 100644
--- a/util/main-loop.c
+++ b/util/main-loop.c
@@ -582,7 +582,7 @@ void qemu_set_fd_handler(int fd,
 {
     iohandler_init();
     aio_set_fd_handler(iohandler_ctx, fd, false,
-                       fd_read, fd_write, NULL, opaque);
+                       fd_read, fd_write, NULL, NULL, opaque);
 }
 
 void event_notifier_set_handler(EventNotifier *e,
@@ -590,5 +590,5 @@ void event_notifier_set_handler(EventNotifier *e,
 {
     iohandler_init();
     aio_set_event_notifier(iohandler_ctx, e, false,
-                           handler, NULL);
+                           handler, NULL, NULL);
 }
diff --git a/util/qemu-coroutine-io.c b/util/qemu-coroutine-io.c
index 5b80bb416f..7f5839cb76 100644
--- a/util/qemu-coroutine-io.c
+++ b/util/qemu-coroutine-io.c
@@ -75,7 +75,8 @@ typedef struct {
 static void fd_coroutine_enter(void *opaque)
 {
     FDYieldUntilData *data = opaque;
-    aio_set_fd_handler(data->ctx, data->fd, false, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(data->ctx, data->fd, false,
+                       NULL, NULL, NULL, NULL, NULL);
     qemu_coroutine_enter(data->co);
 }
 
@@ -88,6 +89,6 @@ void coroutine_fn yield_until_fd_readable(int fd)
     data.co = qemu_coroutine_self();
     data.fd = fd;
     aio_set_fd_handler(
-        data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, &data);
+        data.ctx, fd, false, fd_coroutine_enter, NULL, NULL, NULL, &data);
     qemu_coroutine_yield();
 }
diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
index 783d847a6d..f68287e811 100644
--- a/util/vhost-user-server.c
+++ b/util/vhost-user-server.c
@@ -250,7 +250,7 @@ set_watch(VuDev *vu_dev, int fd, int vu_evt,
         vu_fd_watch->cb = cb;
         qemu_set_nonblock(fd);
         aio_set_fd_handler(server->ioc->ctx, fd, true, kick_handler,
-                           NULL, NULL, vu_fd_watch);
+                           NULL, NULL, NULL, vu_fd_watch);
         vu_fd_watch->vu_dev = vu_dev;
         vu_fd_watch->pvt = pvt;
     }
@@ -270,7 +270,8 @@ static void remove_watch(VuDev *vu_dev, int fd)
     if (!vu_fd_watch) {
         return;
     }
-    aio_set_fd_handler(server->ioc->ctx, fd, true, NULL, NULL, NULL, NULL);
+    aio_set_fd_handler(server->ioc->ctx, fd, true,
+                       NULL, NULL, NULL, NULL, NULL);
 
     QTAILQ_REMOVE(&server->vu_fd_watches, vu_fd_watch, next);
     g_free(vu_fd_watch);
@@ -334,7 +335,7 @@ void vhost_user_server_stop(VuServer *server)
 
         QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
             aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true,
-                               NULL, NULL, NULL, vu_fd_watch);
+                               NULL, NULL, NULL, NULL, vu_fd_watch);
         }
 
         qio_channel_shutdown(server->ioc, QIO_CHANNEL_SHUTDOWN_BOTH, NULL);
@@ -377,7 +378,7 @@ void vhost_user_server_attach_aio_context(VuServer *server, AioContext *ctx)
 
     QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
         aio_set_fd_handler(ctx, vu_fd_watch->fd, true, kick_handler, NULL,
-                           NULL, vu_fd_watch);
+                           NULL, NULL, vu_fd_watch);
     }
 
     aio_co_schedule(ctx, server->co_trip);
@@ -391,7 +392,7 @@ void vhost_user_server_detach_aio_context(VuServer *server)
 
         QTAILQ_FOREACH(vu_fd_watch, &server->vu_fd_watches, next) {
             aio_set_fd_handler(server->ctx, vu_fd_watch->fd, true,
-                               NULL, NULL, NULL, vu_fd_watch);
+                               NULL, NULL, NULL, NULL, vu_fd_watch);
         }
 
         qio_channel_detach_aio_context(server->ioc);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:26:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:26:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241115.417985 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUY-0007wu-NI; Tue, 07 Dec 2021 13:26:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241115.417985; Tue, 07 Dec 2021 13:26:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUY-0007wn-Jb; Tue, 07 Dec 2021 13:26:46 +0000
Received: by outflank-mailman (input) for mailman id 241115;
 Tue, 07 Dec 2021 13:26:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaUX-0007wT-8K
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:26:45 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52060cca-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:26:44 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 05E451FDFE;
 Tue,  7 Dec 2021 13:26:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D54DF13A7E;
 Tue,  7 Dec 2021 13:26:43 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xRbgMhNhr2GOSQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:26:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52060cca-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ytyY5eBpYhBlOfJqOE/DBsfdRmoNqEUOuxaUeUJHLMQ=;
	b=jVIqy3rPBeNhsJFCBp2ZsV+Cft1pWFZ3HEQ2jxrhv1reaCcJylOmE5ZOPFp2vtl08sUMVV
	3dWh2wp4Pg6/sdzEzJDDVneW96C5YuoP5Id06jlreIrt4iSZsq/HSHeM97gK/vmX2t6v6v
	Y07Lp4zWC21X4e0PLsdfjQN00gDsBjI=
Subject: Re: [XEN PATCH 44/57] libs/guest: rename ELF_OBJS to LIBELF_OBJS
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-45-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <4f2a3509-e854-4713-d634-cb4e72d8e112@suse.com>
Date: Tue, 7 Dec 2021 14:26:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-45-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="GArAHF1YXkQfMO78u4z5zZAtW0esg0JJ4"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--GArAHF1YXkQfMO78u4z5zZAtW0esg0JJ4
Content-Type: multipart/mixed; boundary="YjGmOZulIUpphAtPp8HTDkuhPHqX03vsx";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <4f2a3509-e854-4713-d634-cb4e72d8e112@suse.com>
Subject: Re: [XEN PATCH 44/57] libs/guest: rename ELF_OBJS to LIBELF_OBJS
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-45-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-45-anthony.perard@citrix.com>

--YjGmOZulIUpphAtPp8HTDkuhPHqX03vsx
Content-Type: multipart/mixed;
 boundary="------------1CB6C7726BBFB532A874563C"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------1CB6C7726BBFB532A874563C
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> It seems a better name. Latter, we will introduce LIBX86_OBJS to

s/Latter/Later/

> collect lib/x86/* objects.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------1CB6C7726BBFB532A874563C
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------1CB6C7726BBFB532A874563C--

--YjGmOZulIUpphAtPp8HTDkuhPHqX03vsx--

--GArAHF1YXkQfMO78u4z5zZAtW0esg0JJ4
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvYRMFAwAAAAAACgkQsN6d1ii/Ey98
0gf/cJVbjRqGLpahP1ZWUkC8DA11j6MEGzOAZJd1RvZlRABAEyiZzaY4nCLBCbjuelXIjbEXFbis
S2UI3TY6PMjHslimJEF307Yq1u3KJ2ej7lB/p/8Rl5C436CHnAO0FDNolMVu5iE7ZvcDjsFq2EUo
uqB+BCUnsavdHKKFwfB6RvrYuPBK/Bpz1Ro1xAa5zQe9K0UIkklgOrzOyd4Z772QVgkgae+EbU1U
8PZkczyphRmJSeaCutFvc5PwrjgVoRiS7p5FVJYGeNx4fq5s4VqRtTkKNBWJA3MkvccDmCOE0NC5
dJfJGGqFOprR5yAoKLH2RHoOpFXbzi0GfHyAxr8Pgw==
=+2bc
-----END PGP SIGNATURE-----

--GArAHF1YXkQfMO78u4z5zZAtW0esg0JJ4--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241123.417997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUn-0000BQ-34; Tue, 07 Dec 2021 13:27:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241123.417997; Tue, 07 Dec 2021 13:27:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUm-0000Az-T3; Tue, 07 Dec 2021 13:27:00 +0000
Received: by outflank-mailman (input) for mailman id 241123;
 Tue, 07 Dec 2021 13:26:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaTt-0005E4-Lk
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:26:05 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 392e2a41-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:26:03 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-324-onmQLRMcNkWA3brENvW3Tg-1; Tue, 07 Dec 2021 08:25:59 -0500
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90DC2760C0;
 Tue,  7 Dec 2021 13:25:57 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 289EC5DF4F;
 Tue,  7 Dec 2021 13:25:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 392e2a41-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883562;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TIu7p2ZIHoo/ecmt2czm8usZL13K7mxILSf2DegWIyw=;
	b=LYXT0smbu21fZ2h+dHY49HGwTnzRO7jIWV3LkHZxg1KrKqWH9ju71fOAv6Lza43Po4nznY
	mksgNeoNlotSAQw2dZS0ZJ6z+1LiYr/37witxjnxr00057F7Z1sbCTgWu8H4PiQzVbDUhF
	hTNEbkYVk8kPtp837Vw1grXd5/bkvZU=
X-MC-Unique: onmQLRMcNkWA3brENvW3Tg-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 6/6] virtio: unify dataplane and non-dataplane ->handle_output()
Date: Tue,  7 Dec 2021 13:23:36 +0000
Message-Id: <20211207132336.36627-7-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Now that virtio-blk and virtio-scsi are ready, get rid of
the handle_aio_output() callback. It's no longer needed.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 include/hw/virtio/virtio.h      |  4 +--
 hw/block/dataplane/virtio-blk.c | 16 ++--------
 hw/scsi/virtio-scsi-dataplane.c | 54 ++++-----------------------------
 hw/virtio/virtio.c              | 32 +++++++++----------
 4 files changed, 26 insertions(+), 80 deletions(-)

diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index b90095628f..f095637058 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -316,8 +316,8 @@ bool virtio_device_ioeventfd_enabled(VirtIODevice *vdev);
 EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq);
 void virtio_queue_set_host_notifier_enabled(VirtQueue *vq, bool enabled);
 void virtio_queue_host_notifier_read(EventNotifier *n);
-void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-        VirtIOHandleOutput handle_output);
+void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx);
+void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx);
 VirtQueue *virtio_vector_first_queue(VirtIODevice *vdev, uint16_t vector);
 VirtQueue *virtio_vector_next_queue(VirtQueue *vq);
 
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index a2fa407b98..49276e46f2 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -154,17 +154,6 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
     g_free(s);
 }
 
-static void virtio_blk_data_plane_handle_output(VirtIODevice *vdev,
-                                                VirtQueue *vq)
-{
-    VirtIOBlock *s = (VirtIOBlock *)vdev;
-
-    assert(s->dataplane);
-    assert(s->dataplane_started);
-
-    virtio_blk_handle_vq(s, vq);
-}
-
 /* Context: QEMU global mutex held */
 int virtio_blk_data_plane_start(VirtIODevice *vdev)
 {
@@ -258,8 +247,7 @@ int virtio_blk_data_plane_start(VirtIODevice *vdev)
     for (i = 0; i < nvqs; i++) {
         VirtQueue *vq = virtio_get_queue(s->vdev, i);
 
-        virtio_queue_aio_set_host_notifier_handler(vq, s->ctx,
-                virtio_blk_data_plane_handle_output);
+        virtio_queue_aio_attach_host_notifier(vq, s->ctx);
     }
     aio_context_release(s->ctx);
     return 0;
@@ -302,7 +290,7 @@ static void virtio_blk_data_plane_stop_bh(void *opaque)
     for (i = 0; i < s->conf->num_queues; i++) {
         VirtQueue *vq = virtio_get_queue(s->vdev, i);
 
-        virtio_queue_aio_set_host_notifier_handler(vq, s->ctx, NULL);
+        virtio_queue_aio_detach_host_notifier(vq, s->ctx);
     }
 }
 
diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c
index 76137de67f..29575cbaf6 100644
--- a/hw/scsi/virtio-scsi-dataplane.c
+++ b/hw/scsi/virtio-scsi-dataplane.c
@@ -49,45 +49,6 @@ void virtio_scsi_dataplane_setup(VirtIOSCSI *s, Error **errp)
     }
 }
 
-static void virtio_scsi_data_plane_handle_cmd(VirtIODevice *vdev,
-                                              VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_cmd_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
-static void virtio_scsi_data_plane_handle_ctrl(VirtIODevice *vdev,
-                                               VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_ctrl_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
-static void virtio_scsi_data_plane_handle_event(VirtIODevice *vdev,
-                                                VirtQueue *vq)
-{
-    VirtIOSCSI *s = VIRTIO_SCSI(vdev);
-
-    virtio_scsi_acquire(s);
-    if (!s->dataplane_fenced) {
-        assert(s->ctx && s->dataplane_started);
-        virtio_scsi_handle_event_vq(s, vq);
-    }
-    virtio_scsi_release(s);
-}
-
 static int virtio_scsi_set_host_notifier(VirtIOSCSI *s, VirtQueue *vq, int n)
 {
     BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s)));
@@ -112,10 +73,10 @@ static void virtio_scsi_dataplane_stop_bh(void *opaque)
     VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);
     int i;
 
-    virtio_queue_aio_set_host_notifier_handler(vs->ctrl_vq, s->ctx, NULL);
-    virtio_queue_aio_set_host_notifier_handler(vs->event_vq, s->ctx, NULL);
+    virtio_queue_aio_detach_host_notifier(vs->ctrl_vq, s->ctx);
+    virtio_queue_aio_detach_host_notifier(vs->event_vq, s->ctx);
     for (i = 0; i < vs->conf.num_queues; i++) {
-        virtio_queue_aio_set_host_notifier_handler(vs->cmd_vqs[i], s->ctx, NULL);
+        virtio_queue_aio_detach_host_notifier(vs->cmd_vqs[i], s->ctx);
     }
 }
 
@@ -176,14 +137,11 @@ int virtio_scsi_dataplane_start(VirtIODevice *vdev)
     memory_region_transaction_commit();
 
     aio_context_acquire(s->ctx);
-    virtio_queue_aio_set_host_notifier_handler(vs->ctrl_vq, s->ctx,
-                                            virtio_scsi_data_plane_handle_ctrl);
-    virtio_queue_aio_set_host_notifier_handler(vs->event_vq, s->ctx,
-                                           virtio_scsi_data_plane_handle_event);
+    virtio_queue_aio_attach_host_notifier(vs->ctrl_vq, s->ctx);
+    virtio_queue_aio_attach_host_notifier(vs->event_vq, s->ctx);
 
     for (i = 0; i < vs->conf.num_queues; i++) {
-        virtio_queue_aio_set_host_notifier_handler(vs->cmd_vqs[i], s->ctx,
-                                             virtio_scsi_data_plane_handle_cmd);
+        virtio_queue_aio_attach_host_notifier(vs->cmd_vqs[i], s->ctx);
     }
 
     s->dataplane_starting = false;
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index a97a406d3c..ce182a4e57 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -3522,23 +3522,23 @@ static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
     virtio_queue_set_notification(vq, 1);
 }
 
-void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
-        VirtIOHandleOutput handle_output)
+void virtio_queue_aio_attach_host_notifier(VirtQueue *vq, AioContext *ctx)
 {
-    if (handle_output) {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true,
-                               virtio_queue_host_notifier_read,
-                               virtio_queue_host_notifier_aio_poll,
-                               virtio_queue_host_notifier_aio_poll_ready);
-        aio_set_event_notifier_poll(ctx, &vq->host_notifier,
-                                    virtio_queue_host_notifier_aio_poll_begin,
-                                    virtio_queue_host_notifier_aio_poll_end);
-    } else {
-        aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
-        /* Test and clear notifier before after disabling event,
-         * in case poll callback didn't have time to run. */
-        virtio_queue_host_notifier_read(&vq->host_notifier);
-    }
+    aio_set_event_notifier(ctx, &vq->host_notifier, true,
+                           virtio_queue_host_notifier_read,
+                           virtio_queue_host_notifier_aio_poll,
+                           virtio_queue_host_notifier_aio_poll_ready);
+    aio_set_event_notifier_poll(ctx, &vq->host_notifier,
+                                virtio_queue_host_notifier_aio_poll_begin,
+                                virtio_queue_host_notifier_aio_poll_end);
+}
+
+void virtio_queue_aio_detach_host_notifier(VirtQueue *vq, AioContext *ctx)
+{
+    aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
+    /* Test and clear notifier before after disabling event,
+     * in case poll callback didn't have time to run. */
+    virtio_queue_host_notifier_read(&vq->host_notifier);
 }
 
 void virtio_queue_host_notifier_read(EventNotifier *n)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241124.418007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUo-0000WB-B3; Tue, 07 Dec 2021 13:27:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241124.418007; Tue, 07 Dec 2021 13:27:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaUo-0000V9-5Y; Tue, 07 Dec 2021 13:27:02 +0000
Received: by outflank-mailman (input) for mailman id 241124;
 Tue, 07 Dec 2021 13:27:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Kpq=QY=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1muaTr-0005E4-La
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:26:03 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38291668-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:26:01 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-140-THj-iKtlMaqBgcbjuGxKng-1; Tue, 07 Dec 2021 08:25:57 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00A56801AFC;
 Tue,  7 Dec 2021 13:25:56 +0000 (UTC)
Received: from localhost (unknown [10.39.194.90])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 63BF160843;
 Tue,  7 Dec 2021 13:25:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38291668-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1638883560;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nlInce6IWTRh/rB2Z2ehw0FDNveTv4bBVY9vPQnOQcs=;
	b=C5WA5KmJmBD9hIBqzruHVACVORpCqsl5akFJ5zLwnplxHx5dGActfizoWjh2nMqAYjI464
	hZpEVNLcD7u8orrkn1hQNk3dNvNJuob51JKvz+cxrI9gGqdF/dNAsbbui6R0Y1rCSBKKs0
	6qYQUdMzYeeqLUbThS2RwJW0fay60gQ=
X-MC-Unique: THj-iKtlMaqBgcbjuGxKng-1
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Hanna Reitz <hreitz@redhat.com>,
	qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: [PATCH v3 5/6] virtio: use ->handle_output() instead of ->handle_aio_output()
Date: Tue,  7 Dec 2021 13:23:35 +0000
Message-Id: <20211207132336.36627-6-stefanha@redhat.com>
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

The difference between ->handle_output() and ->handle_aio_output() was
that ->handle_aio_output() returned a bool return value indicating
progress. This was needed by the old polling API but now that the bool
return value is gone, the two functions can be unified.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/virtio/virtio.c | 33 +++------------------------------
 1 file changed, 3 insertions(+), 30 deletions(-)

diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index c042be3935..a97a406d3c 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -125,7 +125,6 @@ struct VirtQueue
 
     uint16_t vector;
     VirtIOHandleOutput handle_output;
-    VirtIOHandleOutput handle_aio_output;
     VirtIODevice *vdev;
     EventNotifier guest_notifier;
     EventNotifier host_notifier;
@@ -2300,20 +2299,6 @@ void virtio_queue_set_align(VirtIODevice *vdev, int n, int align)
     }
 }
 
-static void virtio_queue_notify_aio_vq(VirtQueue *vq)
-{
-    if (vq->vring.desc && vq->handle_aio_output) {
-        VirtIODevice *vdev = vq->vdev;
-
-        trace_virtio_queue_notify(vdev, vq - vdev->vq, vq);
-        vq->handle_aio_output(vdev, vq);
-
-        if (unlikely(vdev->start_on_kick)) {
-            virtio_set_started(vdev, true);
-        }
-    }
-}
-
 static void virtio_queue_notify_vq(VirtQueue *vq)
 {
     if (vq->vring.desc && vq->handle_output) {
@@ -2392,7 +2377,6 @@ VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
     vdev->vq[i].vring.num_default = queue_size;
     vdev->vq[i].vring.align = VIRTIO_PCI_VRING_ALIGN;
     vdev->vq[i].handle_output = handle_output;
-    vdev->vq[i].handle_aio_output = NULL;
     vdev->vq[i].used_elems = g_malloc0(sizeof(VirtQueueElement) *
                                        queue_size);
 
@@ -2404,7 +2388,6 @@ void virtio_delete_queue(VirtQueue *vq)
     vq->vring.num = 0;
     vq->vring.num_default = 0;
     vq->handle_output = NULL;
-    vq->handle_aio_output = NULL;
     g_free(vq->used_elems);
     vq->used_elems = NULL;
     virtio_virtqueue_reset_region_cache(vq);
@@ -3509,14 +3492,6 @@ EventNotifier *virtio_queue_get_guest_notifier(VirtQueue *vq)
     return &vq->guest_notifier;
 }
 
-static void virtio_queue_host_notifier_aio_read(EventNotifier *n)
-{
-    VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
-    if (event_notifier_test_and_clear(n)) {
-        virtio_queue_notify_aio_vq(vq);
-    }
-}
-
 static void virtio_queue_host_notifier_aio_poll_begin(EventNotifier *n)
 {
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
@@ -3536,7 +3511,7 @@ static void virtio_queue_host_notifier_aio_poll_ready(EventNotifier *n)
 {
     VirtQueue *vq = container_of(n, VirtQueue, host_notifier);
 
-    virtio_queue_notify_aio_vq(vq);
+    virtio_queue_notify_vq(vq);
 }
 
 static void virtio_queue_host_notifier_aio_poll_end(EventNotifier *n)
@@ -3551,9 +3526,8 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         VirtIOHandleOutput handle_output)
 {
     if (handle_output) {
-        vq->handle_aio_output = handle_output;
         aio_set_event_notifier(ctx, &vq->host_notifier, true,
-                               virtio_queue_host_notifier_aio_read,
+                               virtio_queue_host_notifier_read,
                                virtio_queue_host_notifier_aio_poll,
                                virtio_queue_host_notifier_aio_poll_ready);
         aio_set_event_notifier_poll(ctx, &vq->host_notifier,
@@ -3563,8 +3537,7 @@ void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
         aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL, NULL, NULL);
         /* Test and clear notifier before after disabling event,
          * in case poll callback didn't have time to run. */
-        virtio_queue_host_notifier_aio_read(&vq->host_notifier);
-        vq->handle_aio_output = NULL;
+        virtio_queue_host_notifier_read(&vq->host_notifier);
     }
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:30:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:30:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241142.418019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaXi-0002JU-R6; Tue, 07 Dec 2021 13:30:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241142.418019; Tue, 07 Dec 2021 13:30:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaXi-0002J7-LX; Tue, 07 Dec 2021 13:30:02 +0000
Received: by outflank-mailman (input) for mailman id 241142;
 Tue, 07 Dec 2021 13:30:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaXh-00024S-C9
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:30:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c7016a3d-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:30:00 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4A6AA1FDFE;
 Tue,  7 Dec 2021 13:30:00 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B9E913A7E;
 Tue,  7 Dec 2021 13:30:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jbUzBdhhr2EiSwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:30:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7016a3d-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883800; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=36prU6Ne5X8/6o1kj8MwaiRlzrtCu3ZQpAImGX8Jumk=;
	b=vVdRBGWBk1TwDxheDX47k1OK717gUXCM+U2HYpbQyWb14ASqQDox6GEW2khYZjE4rssd4f
	UfU61ZTK7pX42GwU2bQGknBT/63UPeXDR4uT3Yrk1CV4OMqU0M5WEUd/4WNZoZ/IrL/dfJ
	yb8pxTskPXMct9zYHEcz4Xc5foFt5Ec=
Subject: Re: [XEN PATCH 45/57] libs/guest: rework CFLAGS
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-46-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <a8835cd7-abf1-6972-47be-2ba5cfd118b7@suse.com>
Date: Tue, 7 Dec 2021 14:29:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-46-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="OzZ76xS72a7VcXnTXUAfXaiu45f4kGQSI"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OzZ76xS72a7VcXnTXUAfXaiu45f4kGQSI
Content-Type: multipart/mixed; boundary="xWBnyshziHHRmjPfaSBRfd7PaVgGYagz0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <a8835cd7-abf1-6972-47be-2ba5cfd118b7@suse.com>
Subject: Re: [XEN PATCH 45/57] libs/guest: rework CFLAGS
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-46-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-46-anthony.perard@citrix.com>

--xWBnyshziHHRmjPfaSBRfd7PaVgGYagz0
Content-Type: multipart/mixed;
 boundary="------------63D0AE4215BEBF1E87A189D9"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------63D0AE4215BEBF1E87A189D9
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Remove '-Werror -Wmissing-progress -I./include $(CFLAGS_xeninclude)',
> those flags are already added via "libs.mk".
>=20
> Flag "-I." isn't needed, we just need to fix the #include of
> "xg_core.h" as this header isn't expected to be installed.
>=20
> Make use of "-iquote" instead of '-I' for double-quote included
> headers.
>=20
> Also, regroup the CFLAGS into the same place in the makefile.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------63D0AE4215BEBF1E87A189D9
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------63D0AE4215BEBF1E87A189D9--

--xWBnyshziHHRmjPfaSBRfd7PaVgGYagz0--

--OzZ76xS72a7VcXnTXUAfXaiu45f4kGQSI
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvYdcFAwAAAAAACgkQsN6d1ii/Ey/o
ggf/eHY+nuISGsHJUCyL14slgrZBwsifZ5UysT42g8ciRPPGLRlKDF7dSloueVc57yDAkBAnMdbe
rkBVgeoDAkqvwnzDYb/ll1IAZwxxBLmcBH0JDCYDJUFjHarOtfmYpfAJe6MrY3sQGKM9m3d9rps/
Ba9Mn6sIfUt7TohNSbJMaNA8FP3zdaFPYHum4nhE7U7EoStnKAol6KJKK6nqhE5wGdKuIucilime
MsWC8LqkSBQ1RvPs0hkMmJT0nV6R5ALnKmPHgifSIxAVi4ovjGWv/JS3bMh3w9FlAGsbs2Balk/E
FbCIz35+XTiTyoFhDRU2Ariqkg5CIgzqtSU6tmRUuw==
=3UWU
-----END PGP SIGNATURE-----

--OzZ76xS72a7VcXnTXUAfXaiu45f4kGQSI--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:31:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:31:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241148.418029 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaYf-0003QZ-7u; Tue, 07 Dec 2021 13:31:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241148.418029; Tue, 07 Dec 2021 13:31:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaYf-0003QS-4p; Tue, 07 Dec 2021 13:31:01 +0000
Received: by outflank-mailman (input) for mailman id 241148;
 Tue, 07 Dec 2021 13:30:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muaYd-00024S-OX
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:30:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e9e6f457-5761-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 14:30:59 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D3F391FD56;
 Tue,  7 Dec 2021 13:30:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D52313A7E;
 Tue,  7 Dec 2021 13:30:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 7msxJRJir2G6SwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 13:30:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9e6f457-5761-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638883858; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4DasIqDHCV9c7QzvBBKR1FI4l2yBFFGt1i/wpPFzWWo=;
	b=ftONkVGUG23awLM00niEoH7bz3cjKWVc09lyMzM7iVUp38A75w6ifD7tR77Yj7eOhZquhD
	byY4D6FDFJxPZ5HegEtJXyxbfzZzJhMq1D4X1fwG3UefGs9FraKccV6uZgDegM730KrMfO
	jpOiL7dDO/vHvA67DX2FdAQAQfC6RK4=
Subject: Re: [XEN PATCH 46/57] libs/store: use of -iquote instead of -I
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-47-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <73a03195-ecea-14cb-c2a0-6a6b305b6f6a@suse.com>
Date: Tue, 7 Dec 2021 14:30:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-47-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="clBY8Np9HIRT2jt3GwOqksch5kl8rgVhr"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--clBY8Np9HIRT2jt3GwOqksch5kl8rgVhr
Content-Type: multipart/mixed; boundary="JGninxKVHt0DxFrVkH5cDILXcyk8IzkVA";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <73a03195-ecea-14cb-c2a0-6a6b305b6f6a@suse.com>
Subject: Re: [XEN PATCH 46/57] libs/store: use of -iquote instead of -I
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-47-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-47-anthony.perard@citrix.com>

--JGninxKVHt0DxFrVkH5cDILXcyk8IzkVA
Content-Type: multipart/mixed;
 boundary="------------27107304DC36DA1D097D73DA"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------27107304DC36DA1D097D73DA
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------27107304DC36DA1D097D73DA
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------27107304DC36DA1D097D73DA--

--JGninxKVHt0DxFrVkH5cDILXcyk8IzkVA--

--clBY8Np9HIRT2jt3GwOqksch5kl8rgVhr
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvYhIFAwAAAAAACgkQsN6d1ii/Ey9e
Cwf6A2OSJGU/UmFpvF+oKOdo+Ppp87oHB+DIUaTVzdL40CkQ8VTXNIHCGY4Y0kXPVMz+JIwbxbqv
cxtw5rRN4WaSqN65bbAOZEFrG7QJzAYAtkdD2rcU6ssg+/si5t4l6sJ0i3qC4mnr7uXbCh7wLxba
MtpjFtcGdx4XZ8orudj+qW8WqZgtGUW3/F360TxVYTysEU1kJbgDYLjG8v+uOQ9r1zO2C6DuhXxH
5VR9i9iSY9M9jHfpeanD6eHdmFTJwTKJ1WGboql4yeV5ppemxgh5k07GpKF53pIauQwaUnQBxu3Z
7sgww7agur1q1OTxxxAm3vnAGftZYXu6eIE/6m/zsw==
=yfL/
-----END PGP SIGNATURE-----

--clBY8Np9HIRT2jt3GwOqksch5kl8rgVhr--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 13:31:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 13:31:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241149.418035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaYf-0003UZ-Jt; Tue, 07 Dec 2021 13:31:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241149.418035; Tue, 07 Dec 2021 13:31:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muaYf-0003Sf-CV; Tue, 07 Dec 2021 13:31:01 +0000
Received: by outflank-mailman (input) for mailman id 241149;
 Tue, 07 Dec 2021 13:31:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muaYd-0003PI-Q1
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 13:31:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e995241e-5761-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 14:30:58 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-21-A1R738jOMQi8KBeM5N9ewA-1; Tue, 07 Dec 2021 14:30:57 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 13:30:54 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 13:30:54 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0093.eurprd04.prod.outlook.com (2603:10a6:20b:31e::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.21 via Frontend Transport; Tue, 7 Dec 2021 13:30:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e995241e-5761-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638883858;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yqkppLe7XZC97OCZv/qsjboB2OBINNvMz/0N+T66YgI=;
	b=XMFgLpWv5eMZuC0bPgpLtGZTcrPjhBqcBigEgpALfWktGtCDOJJPEnDGstxxZoEmTqg9RW
	hTp91aOFUY0MwQ6FHne4blNFmoapI2PFg17PAClNhSRxKQyJXUFMxh/6N8qQa3yleqocUf
	I2P5VUW5Ng5wUhUBgnxNKSH74Vflbpw=
X-MC-Unique: A1R738jOMQi8KBeM5N9ewA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DXtl6148wUf3zEXmbXT7+sGljrSJRYoUKwBuuUFX+b+I42AlKYYQjFuDMASTtZs1qq44BO3XhDh4erdmKdi3NZ/KN4ZTVWwoifSSNmP6EpZaCdYeOs6vwY3Av5ggRX7RuTRe8wNedax1nVMnghGhLuxn45koODpOeVdKOEyU11raljCAvMb+Sk50rhhVmniDnNdy786rmf0aF9qvq20UImYZi8nRT+QURafXVkU4nDq4wuPFkmQ2i19bN6QiXTj4Vn/Z4nwau25XRSlGhMeFLUpex+5H2ar3RK1ktCpPTi4MkCQH7iOiyAusQS3ZPoodv+kc21YW3eDB5Sn0JxAyQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yqkppLe7XZC97OCZv/qsjboB2OBINNvMz/0N+T66YgI=;
 b=mNpQ8v3bcizIux+j6mLubRP6D2mNTsiT4mZN+EyKzdIufVpmMbSYD1PqSCcVV6tKmFlvhklMoznwnRGJX+1Y5ILdNsxlBf+pFL2JZOds8IUIhOYSkVkPotMfP7KI4Lj0UGBWoblPdlmXfE6UOXCCz10meKLZtjzNCW44UWSgNlni6PjQBy7PtGnc7mprodp2RW2lE/m8u1GOioDnmF6nqfRhnkgYhOryX9RzaqHc5/LNWrw/tafvw3r+qtjbZS9Zbo05nn3n/cR2S5TIfE4xfKONSq8C69z5QyxewAb8ckF5Z6hwDLpo5rptrLv4ZGqKpPeSNwGR9KIoAFmgU9v4DQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3cc0d2c1-6c11-e6bd-8f0a-ae207a852941@suse.com>
Date: Tue, 7 Dec 2021 14:30:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
Content-Language: en-US
To: Ian Jackson <iwj@xenproject.org>
Cc: Julien Grall <julien@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <f96f014c-057a-80a7-b19d-04d7234d3f64@suse.com>
 <b28ec75a-f5e5-cd3d-12b5-20338c7c88e0@xen.org>
 <0c0e67f3-5e0a-f047-ca09-1cf078e6b094@suse.com>
 <71ef250c-be92-2b2f-0f07-ce32c17d8050@xen.org>
 <ceec5b56-65fc-8bb4-b9e0-1e16aea8c412@suse.com>
 <c2d312c2-c413-4e07-1c0c-8652cab40784@xen.org>
 <0b808ce0-23a2-65ae-dfb3-b167d5565b31@suse.com>
 <6bcd1555-ee0d-dd6d-55ca-0ca0e64c3623@xen.org>
 <bef5ff51-475a-e8c4-83fc-950df4516399@suse.com>
 <24992.55453.893877.246946@mariner.uk.xensource.com>
 <2b4195da-21a8-6c30-27c8-43e943b821a1@suse.com>
 <c3e698ab-afd7-9638-3f7c-c7599908e173@xen.org>
 <e684eeca-a798-9cf1-c8c2-1db2e02bb65c@suse.com>
 <53cd2f84-f011-9c97-a108-fd946535920b@xen.org>
 <5a6ffa5a-6884-57b5-c296-904e9b0b4c78@suse.com>
 <9affccd1-0f74-c58e-ebd4-5a5546ec80b1@xen.org>
 <9c86ae6c-f62b-f54c-b5ad-a776887ae9b6@suse.com>
 <b43c072f-4d4c-a108-2c24-801116e99c3e@xen.org>
 <9bb0ecfd-038d-2671-9929-8f9b37f5ea75@suse.com>
 <25007.19664.487196.625874@mariner.uk.xensource.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <25007.19664.487196.625874@mariner.uk.xensource.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0093.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 114221db-e35a-4641-a2d6-08d9b985cb6b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5743DD2460845CF4BE772225B36E9@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	L4I7XMhO/Y+yh/oVinaVZMsf9ZP9aiUKLEDTk1DqsdtbZJtZuLCczXtDTlkJ/F9GZ4w1AkMH5FKgCQUXyQOemQ/Q87QR7BdNXRShm971vnzyjRZN49AGqxLrKDikwFIVmtj2SzjCv5VfFh6/y7lEgUXXFZnpuma33mMjY6mOxWlqAwOD5V5mervcDBMcxE1SaP5iGQDd85WnbpDDr0FwJK+QU/oETNpg1YlBUAoc5r4GAalv7t7i4t466sdM8n4uWu1abcS6uBRC2+W9goXophLtm23WBWaoxs+b1tDiraoGb6Ci3zADd0iKClwxxWcKsuR80PsFlpI51zEsuOHsOq3eJLO9QEW0xQcB4zK+dSkx/6pO7P8wLtz265qgV2GxKEix2R3jkI2vdXgwY7X7zqhuHW1qawRB1i2L9VpuHgzYCSO3EMvux4jZiO9mtG5LphRllzR2Lf3FsTaX4T3v+u3m2JdWZuE7QnqCPob+/MG2htGIdqCszmCtiPisoqPlLOo+0zCPFSolgTg3uy3eZGuodaVHYmoJaP2syhvoxCgoW+uVAjK+l1pNjmN4Mf9yHy44h8beILkJ3McRXwcgt9+0vyUmfuRzrRDB0lDhb0RpJMHQYYGxTjP1aa3d4j01gEckohvcdyajPd+TFLljcRPKpfDIy2GVjxm6HFj9WGP4dwPHc5ZKLYQKDdQbJFG1r+p0wtY6xRfGdfrV5UuS9y9gFFjWPsncMd5cbiC7UNQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(316002)(16576012)(956004)(86362001)(36756003)(54906003)(53546011)(5660300002)(186003)(2616005)(26005)(38100700002)(6486002)(508600001)(4326008)(83380400001)(6916009)(8936002)(66556008)(66476007)(66946007)(31696002)(8676002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RmdNZml3aWZYSC9JS055Q3V4cDZrNlRXbkY3Yk93QjVDdzR0Sm8rYm1KLzRy?=
 =?utf-8?B?RWl2WkZVVFpNV2VvbG1ZS1VYZUx4V2JLQ1J6T1NJcnVvNG5WZlo0MHMxM2lw?=
 =?utf-8?B?K0JxM2xETGwxaGVZc0VNdDRiQzRwMkFDZlhiSzV2OWNKMXBnYXB0VlZnNFFm?=
 =?utf-8?B?cmZlbVpyd1Ryb0pKaG1HVE5heDF3a09CM2tOeVFoVjlVV21pWmFka2FmK1hY?=
 =?utf-8?B?eE5oM2tERmNrNDBocXVGMlhlNi9jVDR3NXZ4b3FJYnc0c1ZTS3hGdHVnN0lN?=
 =?utf-8?B?cXlTUEhhUEovQ3pMV0tWd0N6UitMdDVPQnNubFRFeWNuak56MG1kNjdpWlkv?=
 =?utf-8?B?eitRZ1VMODlJOVBGT1V3bmlxdGEwQkp0T0V3UjNmdXUvczN0eGpOTEdCVk1t?=
 =?utf-8?B?dS9TMDRqeW1QYlFUKy9ZYWIveml5Z1hpQzZ5NmFIWllVOUpSKzIyaW8vWDlL?=
 =?utf-8?B?elA2aDBXWjBPd25BQTdmQ1RFVlpINlpvZk1Ld2JxTkpSUTE4S0ljekFOS3ox?=
 =?utf-8?B?ZGdMczdIQjRMby9JaGdDTjRyR0toSStIWjZ1UmpKaGNEUXRBRnNOZ1c4OTJ4?=
 =?utf-8?B?RDJhMlU0dTd6YTY2RzVCWllEWlFKU0M3amo5NnEvWWU4M2FTSlVsbnc2akR3?=
 =?utf-8?B?OGJwemU1SmlpVjRKeDNtZG10enQ0ZjBack0wdG96L255MS9ySUE3MEtRT3M2?=
 =?utf-8?B?aFJWUUNuaG9SWkVwS1lQZHVKd0FJMk9ycG52dVBDWWxILys0bkwzdk1mUXdp?=
 =?utf-8?B?SGpNZGcyYlNXZzVoTmwwVGYvZVhIOTVUR2VhWDRPVFBmNWppNFRrUTkzb1gw?=
 =?utf-8?B?UEFaNzNZV1dZV0dCalZFanpOc1FtUVFtUjhONjFRWGtTa1hHU0IxOFhSbnR3?=
 =?utf-8?B?bitoSGNjVy9lMHA1REpmUEdPUnZyWi9MbloxVFZXUGdtT1drQkZLTWsvTEpV?=
 =?utf-8?B?MS9JcXZFWWNNakVvTVR1ejhWNnVHajhya2dtZEl6SlBLZEEwWFUxaXN1MU9W?=
 =?utf-8?B?cDNFUi9hNTA1UlVLQ3g3aGNMeDhtZ0s4MXV3TlVmQ3VMRi9vbmdzOW9KbGVV?=
 =?utf-8?B?TUE1VGhXMDQ5VHptYTFPN0pyd2pIM1g4MEJNT25KcWk0MlpYSmNXRkNBendH?=
 =?utf-8?B?NUZNSVF6bGRUa0ROMlVacFRKWm1RQUN0bzJRU2dzb3FIRjZXUFgxRUx2Z2Fx?=
 =?utf-8?B?S1NrWUNRWFRuQ1lWcXlKMjdaWmNoSjkvQ0RUTzFHUEczbFdrang1YVBrelN3?=
 =?utf-8?B?aWVxTUN0MXdONlhkTWpJeVl0eFVPQ2l3STEzcGlhY1poQThPRldTYkZteUdE?=
 =?utf-8?B?eVBsTmZhWEp3UEQrSzV0U2pYKy9lT1JYdjIrSFJxbWxiVWUxVGxuWllFOVh4?=
 =?utf-8?B?V1ovalhVYnJIVlEyd2ZZNElueXlYT0pXZWJpUXpZdUM1bzhEdmNhYW4zaWJy?=
 =?utf-8?B?VCtlTHEycWpzSTBwd1hZSnN2Y1l0TklLREN5VlZ1d2dKeEZrd0FoTFdxeTd2?=
 =?utf-8?B?Skdudmp5OFFxOW02TmNxMjFLRmF3ZmhnSkhJU1JJeTZjSURpNTVXWTk3b3B5?=
 =?utf-8?B?N1ZSK1lraXREeWdHdkFXOGRBS1B6RlhhR0krYThVaWNERUFuVnZmNjVYU1Bw?=
 =?utf-8?B?c05LQ1RSRG91bUI1Qm1mOU1jcEpocTVZVVhhV2dPTjVtYlBrSWxaNFp3QktL?=
 =?utf-8?B?ckxGNzlCaVF4V2ZibFNDTURpN3dvL3NaZFc1aGNqaWhEZFpidGQ4L1piTjRx?=
 =?utf-8?B?VllUR1IyOVY2dXgyMnZzckt2S1JxdERqT3RzbVBIdkNKYStiVk1yNkVNbjhk?=
 =?utf-8?B?bm5FaE1EMHZiL1NIYzkwYzR6WnA2RmYxNTh1SlpYaGxqNCtTRlFBT3dhemM2?=
 =?utf-8?B?WGVtQ01QaXZ3cys3SG0xVnlJSExuaDgwOTl2RldiOGRWV2pKOTd6T1VTaUFy?=
 =?utf-8?B?TmhqNEYzalhzV3E5cGZzU3NsYW5Jcm5uQzJ6VUI2RHhRRXlnUTBPU0JNQmZU?=
 =?utf-8?B?eXRLbDNrNXpIbEFIWVNNUldCOGxlZTl3cjhyUTgxWW9uMFZkaG82blFsd1Iw?=
 =?utf-8?B?WVY1MENyR0ZReTVjbjZNZEVKQmpTbTh5dUhRTk9LejVYMW8wSVlocDFqY2tS?=
 =?utf-8?B?OFpkeG5BZTJtS01yMXlpTUREeVJRbHFQZEpwY3pielFLYzMrcnMrd2hQcURx?=
 =?utf-8?Q?HZy20vGJyEGkls7dbtx1GvM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 114221db-e35a-4641-a2d6-08d9b985cb6b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 13:30:54.5363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z+YTVlw7Yu13HHQ7fgkpbckt8xxx1bEvEkQPjw9yaJOYmxV37BOuG1HKh8YioBsCJXy7dhg8DVMjReLXYDnuUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

On 07.12.2021 13:00, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/7] xz: add fall-through comments to a switch statement"):
>> I'm unwilling only as long as I don't understand the need for them. As
>> indicated, while I appreciate your "make verification easier for
>> reviewers", I assign that at least no higher priority than my desire
>> to leave out inapplicable data.
> 
> Are we still talking about Signed-off-by ?
> 
> I explained the purpose of Signed-off-by.  It reflects the chain of
> custody.

And I accepted that (without claiming to truly understand things) as
far as the desire to prove all tags goes. Hence the v2 submission. To
me, as can be seen there, that chain of custody includes the original
patch submission, but not the flow through Linux subsystem trees.

>  It is true that s-o-b is often added by people with minimal
> contribution to the content; I don't think that is relevant.
> 
> If the Xen patch was derived from Linux commit XYZ (whether
> automatically or manually) then even those minimal S-o-b are
> applicable.

I'd like to adjust that to "If the Xen patch was claimed to have
been derived from Linux commit XYZ ..." I don't think I've made such
a claim anywhere.

>> I'd be happy for anyone else to start over. I would even ack such a
>> submission myself. But as long as I'm recorded with S-o-b, I'm afraid
>> I'm not going to accept re-addition of the tags for no good (as per my
>> personal view) reason. Otherwise, based on experience, the example of
>> this series could, in the future, be used to tell me that on an earlier
>> occasion I (seemingly) did things differently.
> 
> S-o-b does not indicate complete approval of the content.  It attests
> precisely to the statements in the DCO.  There is nothing irregular
> about putting your S-o-b on something you don't entirely agree with.

Isn't it up to me where I do put my S-o-b under, and where I'd rather
not?

> Stepping back:
> 
> In a collaborative project, we must all respect our peers and the
> community's decision.  That can mean actively progressing patches that
> we personally disagree with, but which the community has decided ought
> to be applied. [1]

The latter part aside (as I don't think I'm standing in the way of
getting these changes in), I don't see any "community decision" here.
What to do (or not) in cases like pulling in changes from elsewhere
is simply not documented anywhere. Hence all I could have gone from
are past examples. (I don't dare to guess what the correct thing to
do was if a change was to be taken from a project not using the S-o-b
model.)

>> As said earlier, if submissions in this form are going to be nak-ed
>> going forward, and if good reasons (see above) will not be provided
>> (and hence leeway will not be granted to the submitter) to support this,
>> then someone else will need to start looking after imports which may be
>> relevant to us.
> 
> The problem is simply one of verification.  So far there does not seem
> to be a positive ack[1] for this patch.  Neither I nor Julien are
> nacking it.

But, as Julien calls it, "open objections" are effectively preventing
the thing from going in. Otherwise Luca's R-b would be enough for the
whole lot to go in.

I did submit v2 with his ack on patch 1, in the belief that a) he didn't
actively withdraw it and b) I did address his concerns there. Earlier
today, seeing the ongoing discussion, I did drop it here (and I'll try
to remember to also reply to this effect to the patch itself).

> AIUI Julien does not want to ack it without being able to check that
> all the appropriate s-o-b (and perhaps other tags) are present.  I
> think that as the submitter it is really best if you make that easy.
> 
> 
> We think the obvious way to make that easy for a reviewer is to just
> copy the tags.  But an alternative would be to include, in the commit
> message, full details of where the patch came from in (including urls
> to mailing list articles) in such a way that a reviewer can see easily
> that all the necessary s-o-b are present.

This alternative is what v2 does: Already in v1 there were links
present to the original submissions, where available. I didn't think
there was any extra wording needed next to the links. v2 merely syncs
the tags with the patch submissions.

> [1] Of course very rarely there might be matters of conscience, where
> we have protested but our protest has been overruled by our peers.
> But that does not seem to be the case here since you are not giving a
> nak.
> 
> Ian.
> 
> [1] Julien did give one earlier but then wrote "actually" and started
> this subthread, so I think Julien has withdrawn his ack.

Well, okay, I didn't read it that way, especially since I did address
his concern there in v2. But as said, I've meanwhile dropped his ack
from there.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:07:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:07:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241179.418051 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mub89-0001yz-C3; Tue, 07 Dec 2021 14:07:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241179.418051; Tue, 07 Dec 2021 14:07:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mub89-0001ys-8V; Tue, 07 Dec 2021 14:07:41 +0000
Received: by outflank-mailman (input) for mailman id 241179;
 Tue, 07 Dec 2021 14:07:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mub87-0001yW-Ok
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:07:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 07ec4cc2-5767-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 15:07:37 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2057.outbound.protection.outlook.com [104.47.6.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-F7jnwBk8OFi--E56T14ycg-1; Tue, 07 Dec 2021 15:07:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5904.eurprd04.prod.outlook.com (2603:10a6:803:e6::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Tue, 7 Dec
 2021 14:07:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 14:07:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0307.eurprd06.prod.outlook.com (2603:10a6:20b:45b::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Tue, 7 Dec 2021 14:07:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07ec4cc2-5767-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638886056;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1TkZZTyddgKp3F0rKfwrnyaI0bxs60mKMKcbUUuIyW8=;
	b=kSewM6Emeg+qYDjhc1EyQS0N6zGGriDNBlZaMAyYDWACQsCaQ7BMDtj/aiWoEMwZanaAqV
	PBFGkBeqHQOjYWssxgEs5+MQC3SoJTBG+mSdWBct/mcPMx+eH5N45ZKX2eqG5i7EOnHvFt
	1fcvMJsLO1sk0V5O/ljccgQLgcqKjY4=
X-MC-Unique: F7jnwBk8OFi--E56T14ycg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nRt6cLxjDNNZsz5lOtRyI/iktbZa6r9WIzrIH35R2+qvYu50/Prmqq5zVhqL8H4O9NSoPoZVFlMqQ5ytjZqxyn7KmByH3kUaYlwGVhaWLm3hLmwU0scgEcM0k+mPTqPBSORZ9BZ6ES9ETjOT3+MOQC3+nbbbUTL3wjaaes7L54H4E+SRk2X4s7LY9xAOiBXtfxe4MGsEiNYiP9er9rFPAqvjSJspIS7FH7COlNBf8SkhLGEdHvcEok3I+euenpG5UVgDTxYzQLp1vid5IvpOA6STbRM5Sup+jV+j/HWvzD8ChDTbwfjBhlvLPiu4uQ8gUDvkAOlSIns5BGWhXUscNg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1TkZZTyddgKp3F0rKfwrnyaI0bxs60mKMKcbUUuIyW8=;
 b=YSuhzGsOvVGPXjRCosF2ZH/7WyoP2u7RtLwMpiUtxl70dYZG3IhXX70V39ohLd0guNFZVpxXq3NgCbA08cXBYpQvwR6Q1lv1Ew8Yk95of8UJcKYtLHU6jx2FYFAwR3YH1uH2OyCT6q1E99Dgm6MA1u7081MX4f0NzU11Li9sXT1meTLoUEXFOXP63umkUASW8GICtMZMqb3N9A9/4/ozdspw7BnPlVrB5mzysABnkcHNCw9XalooGE2Nfkx7Hz1ruzjUEHRbBDA0Pyto5jOIJjP4jMzeZVkrPI6+ssuBbR268bmdQTWR/MjVKi9opC5giBNG+24WVBZc6DmjszRYtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4d89cd09-bcf9-84b2-4635-41d95852ce38@suse.com>
Date: Tue, 7 Dec 2021 15:07:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 3/3] x86/boot: Don't double-copy the stack during physical
 relocation
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211207105339.28440-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0307.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a02d2ab0-00ad-499e-f2db-08d9b98ae9fb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5904:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5904A3A0F439A898C1D3DC0EB36E9@VI1PR04MB5904.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	CeSZei1hnvqmF0MDK+6F3kzBBhV0Tnqy2SslJoY68DIWPWedSK0XXAZpMOZaSAsyj6F1IHYVs/S9VRvIHiHP1MfTdIIA3fmMAe7nXGMdhwTYyC1WihymV2Z9ju9Pvas7LONIU61SNc9w24e1M82NkIDfGhT8itVJoURiyNFTa8QWfFsQ59ncC10kcZB6/aQ3kumfXLW38oW+b+TvrSfPEgJDu7/yFNDDNulfY0PZ+zgrK9l7AvtVnzc0g9FdDx1DOnM4y6CqcLwguIKB3ooMOi3SIlc3UsF3E7Rrn71nyGYuQV49ZNRqO7Mj8DMNzU6537NJij3JXCwNONKCPTmncaGoZ5sSEHpf+PzU5zcWagjWpVWdbzFPM/suaJRT4HFCkkdEp3LfkdlqHDca5qGS727IQj0X7UlIRKDnHIb9HRRQV1JO0/IAEEezYk4ffC7o3ikjItqKnPBXCtNrH4BdJmrJFqlHCP6NxKEcbXal8Smj1RX3gToujikThr8bRM33bOq3m7owuUvxAuR9ODm+F0kCCCCyWzYiKvAicOUlBOqOvRQAOLwvDKomey7Jxm0O51rIJ07RVcfvEjyLD37tXSwF1k7lwkxU7kTDf1wwWtfJD6riSUCZV6i0C3QCmt8I8Obf/Ordht/BqtG9wnAK+2810L+rGbuV6JyFOc90xVsCEIqQs5SYkgGMLcENYyEINW3hWn/1SXVwNf0EsNfB+/ipeX53kGG5iP2EdX22fkM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(316002)(6486002)(66556008)(66476007)(86362001)(6916009)(16576012)(54906003)(956004)(8936002)(31686004)(8676002)(66946007)(2906002)(4326008)(186003)(26005)(508600001)(36756003)(53546011)(5660300002)(38100700002)(31696002)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QVBncmdNL0dGWG00clpaRUNJUXVsSmFMUTZBc0pEVExEMm5QOFE1T0gzcVh4?=
 =?utf-8?B?U0ZlRUZrN1gyL2pKQmJwTkNLdm01Q3pmRmlReDJTbDR3UGViaktPRlJmdlJp?=
 =?utf-8?B?eXc1VHNNcXlJd1VtOVErYmNpTWw1TGx4RnpBWmNJalRCT3ArRVMyWmNFQnFM?=
 =?utf-8?B?RDA1OHQ2V1VySGhYcEVld3ZMazd3Q2czcU9wejFsTWI3cGp1bGFpeEhPZ29p?=
 =?utf-8?B?NTRyVWVXN3dWYzBmRjBFVUh3TC95QnBiZHhaMUJLN054Y01HV2pVYmFRZVBr?=
 =?utf-8?B?MmtaNnYrRzZrdjgrSHJhSUJ1ZUg2QUVpTTR0a291VkJqb0kyQmRJVXRVaUha?=
 =?utf-8?B?RmFsWDNVSmpGaStzYXRGNVAraGNmb2ZCZHNKcEU4YUk5Y09iUjBrYXErK1Q4?=
 =?utf-8?B?U0lwY25OczVWQUtvb28zaWxEVEFYZWFlS3lIOHpFQzJZWm9SeXh0TUtleC9J?=
 =?utf-8?B?QlhIQnFQNCs5TXR6UDd1MkdwTUhCTGpjUmZhUXp4eEJzM1pXWVZUaGxkb2p1?=
 =?utf-8?B?dEl5Y3cxRE9TdU5IYVZlbk9BeHZ4TWZkQkJyTkRxVnhOVVBlK2s5OXJKays4?=
 =?utf-8?B?bkpXSXplcHRIbTMvcWM4OG0yZEN4eThFeG5WREl0UGlQL2s3N1pwcGJmejJj?=
 =?utf-8?B?SnV4bm9CZ3RyOWhFdHBrdUltNjk2Qy9rUmdyR3Y1UEhRMHVISHBjbHAxOUNn?=
 =?utf-8?B?VE8wTFFMNDhjQ0ZKS3ZxVGhHVFE2N2tCSGNhejM5RjVxdGVEZ0ErZDl3enJZ?=
 =?utf-8?B?N1ppUktrbytNRVhjM1JrRkZ5WksxTWRYZHZoQ3QvWUtGeTdEdXp1YkhyUVFj?=
 =?utf-8?B?eWpxVXRBVGRITWhyalpGRHlPL244M3daQ3QxdVkzTysvUU03VUhMd1F2OWNM?=
 =?utf-8?B?NDBvSFlFaDVYTVFrcUNSVnBzWXo1b3p6YnBISkMvUkJRRERieFVWUDAwYUlW?=
 =?utf-8?B?eFQrN1k0U3hROFczYU11YTlSWllubldCY2VKN0VETlZteTVpZjY4SjlLZ29s?=
 =?utf-8?B?M1AxemdueWJ5MlV2TEtwVWg2TTd5akcraGh2c1VoRURCL093RUNGOGtsSEpP?=
 =?utf-8?B?Mm9LS3RGTEhkQWtjdDRTNDIrbEdtTTRuVUg3ak5LRjdjN2Q1RDIzcUFERCtq?=
 =?utf-8?B?QllFU2g3UFAycXVwdnlOVkJoRTJRN2dmc3pDKzlZRXM1V2VOT1FyMmY2V0k2?=
 =?utf-8?B?TG52MXUra1JLOUx4ZEVzemlvMmVhTUJudzZnSFV3d3VXZTNjNzdNNHdJSTZu?=
 =?utf-8?B?WkpwUUJpejQ3c3FFY0dBdlp5QWJab2E2QWxnN0RJbzBaNzF5aHZYOHRTUS9W?=
 =?utf-8?B?bDM1clVTMUhRcERsV2JVZ1hEYjJjclBOTnMwUHBsRDVQSldLejhJeDJEc1FN?=
 =?utf-8?B?TFo0RmZXUThucHZ2cDRvYWhhWTFiSkRiZmoyTmhIcWQ0MXBKeE9CeGl3clJO?=
 =?utf-8?B?b0tMQ1ZMZnZyS1RIOVJkYVpEa2lwTVF0QjdUQ1FFa2ZPOXFWYml3b2x0anRV?=
 =?utf-8?B?N3doa09FakRyTVlEbkd2b1hkOUJDLzNQRHdhUTlmNy9NcWFJSEY0d0o1bmw2?=
 =?utf-8?B?MCtnVlkzQlVSNE9KUzhFcEFadVV1SHpVRU9LWmUrRm1lVG0wSmU3UUxkNTFK?=
 =?utf-8?B?U1R6ZEdsTzYrK0VobE1xck1FWHFQSy9nVThtZFVHbGJ5RWNYYlBhbWpwRGxC?=
 =?utf-8?B?MWJRZ3pRSlJaaThsRlNQZU54RVRKTGhsdW02Qm9qZTdoem5UOC9zU3VKY0hE?=
 =?utf-8?B?L2FaRlM1a3dSRjRIT2NTY3hlek4zeDY4R2dGM2RNWHBjaTlLVHMyOTQwSDFp?=
 =?utf-8?B?QWdlMXo2Y0J2MlJaYnc0VFZyVjBZaUkvRCsyUkdRK3Q2YlRYOCtuUWhOdHNh?=
 =?utf-8?B?MzlZWGlpOGExajQvQmFwdGVKaCtaNXFNc2NTdUEyaFcyeHBHVmxybU81TTJx?=
 =?utf-8?B?dDRCQUZ3aTYyaDI0Mnp5c0NhVU5md1dFNkZsY0dzbEJxR1Jyb0ZKMVBmVm5q?=
 =?utf-8?B?ZWszVnlWSTdsck5hb2duako0NHl5cWw3V2tiTkZGcHRnMGtlYjJmYUNrRWp4?=
 =?utf-8?B?VEJXVHZQUm40dG5MYm02OW5NV2RuVkdzY2FtdTBlaGlLQXJRQlY1R3hlMnFy?=
 =?utf-8?B?cXR1dFNuRmliWmJMcG9BbTVTblltdWtMT25Uc0RzMnhqVnVabVRVL1NNZjM2?=
 =?utf-8?Q?mAG5lQDYIK7sjwFmnO59MsE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a02d2ab0-00ad-499e-f2db-08d9b98ae9fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 14:07:33.2923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NnlW+FqlcXzxNrCJlC/b1vb2SrtH8NpWg2bhVkMyrn9j7SZ3kjt5WCBhBtQbVSxIJi2KmnrHZEYkXgFUmumL3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904

On 07.12.2021 11:53, Andrew Cooper wrote:
> cpu0_stack is contained within .data, which means the memcpy() already takes a
> snapshot at the start of the critical region.
> 
> Later, when we switch to the relocated Xen, we do end up losing updates to the
> local variables,

You word this as if that was the case already before your change, ...

> but that's fine because the only variables we've modified go
> out of scope after the printk().  Use this properly to avoid copying the whole
> stack (32k) a second time.

... not the least because of "Use this properly ...". But aiui this
is only a result of your change, in that you no longer "re-sync the
stack" (as the comment says that you remove).

I can appreciate that copying 32k is too much. Yet I do think that
we're putting ourselves at risk if we rely on local variables going
out of scope which have been updated. Even more so with no comment
next to their declarations making clear that it is imperative for
them to not move to outer scopes. (Seeing e.g. another "i" and "j"
in the outer scope, one might actually be inclined to do so. For
"j" this would, afaict, even work, while "i" collides with the outer
one no matter what.)

You mentioning the printk() - did you consider someone, perhaps just
for debugging purposes, adding uses there of some of these local
variables?

We could limit the copying to just the primary stack(s), for
example. Otoh I'm not convinced trying to save 20k or even 32k of
copied memory is worth it in this boot-time code. There are larger
gains to be had elsewhere - see e.g. my "x86: memcpy() / memset()
(non-)ERMS flavors plus fallout" and "IOMMU: superpage support when
not sharing pagetables" which continue to be pending.

> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -1183,6 +1183,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>              l3_pgentry_t *pl3e;
>              l2_pgentry_t *pl2e;
>              int i, j, k;
> +            unsigned long tmp;
>  
>              /* Select relocation address. */
>              xen_phys_start = end - reloc_size;
> @@ -1193,7 +1194,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>               * Perform relocation to new physical address.
>               * Before doing so we must sync static/global data with main memory
>               * with a barrier(). After this we must *not* modify static/global
> -             * data until after we have switched to the relocated pagetables!
> +             * data, or locals that need to survive, until after we have
> +             * switched to the relocated pagetables!
>               */
>              barrier();
>              memcpy(__va(__pa(_start)), _start, _end - _start);
> @@ -1239,18 +1241,21 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>                  *pl2e = l2e_from_intpte(l2e_get_intpte(*pl2e) + xen_phys_start);
>              }
>  
> -            /* Re-sync the stack and then switch to relocated pagetables. */
> +            /*
> +             * Switch to relocated pagetables.  This also discards updates to
> +             * any local variables since the memmove() call above, but that's
> +             * fine because we don't use any of them again.
> +             */
>              asm volatile (
> -                "rep movsq        ; " /* re-sync the stack */
> -                "movq %%cr4,%%rsi ; "
> -                "andb $0x7f,%%sil ; "
> -                "movq %%rsi,%%cr4 ; " /* CR4.PGE == 0 */
> -                "movq %[pg],%%cr3 ; " /* CR3 == new pagetables */
> -                "orb $0x80,%%sil  ; "
> -                "movq %%rsi,%%cr4   " /* CR4.PGE == 1 */
> -                : "=&S" (i), "=&D" (i), "=&c" (i) /* All outputs discarded. */
> -                :  [pg] "r" (__pa(idle_pg_table)), "0" (cpu0_stack),
> -                   "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
> +                "mov    %%cr4, %[cr4]\n\t"
> +                "andb   $~%c[pge], %b[cr4]\n\t"

Why not simply %[pge] (name subject to improvement) with the value
below becoming ~X86_CR4_PGE (and the constraint becoming "K")?

> +                "mov    %[cr4], %%cr4\n\t"     /* CR4.PGE = 0 */
> +                "mov    %[cr3], %%cr3\n\t"     /* CR3 = new pagetables */
> +                "orb    $%c[pge], %b[cr4]\n\t"

Oh, I see - the constant gets reused here.

Jan

> +                "mov    %[cr4], %%cr4\n\t"     /* CR4.PGE = 1 */
> +                : [cr4] "=&a" (tmp) /* Could be "r", but "a" makes better asm */
> +                : [cr3] "r" (__pa(idle_pg_table)),
> +                  [pge] "i" (X86_CR4_PGE)
>                  : "memory" );
>  
>              printk("New Xen image base address: %#lx\n", xen_phys_start);
> 



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:45:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:45:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241208.418079 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubiw-0000du-NX; Tue, 07 Dec 2021 14:45:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241208.418079; Tue, 07 Dec 2021 14:45:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubiw-0000dn-Kb; Tue, 07 Dec 2021 14:45:42 +0000
Received: by outflank-mailman (input) for mailman id 241208;
 Tue, 07 Dec 2021 14:45:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mubiv-0000dd-QO
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:45:41 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5918d207-576c-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 15:45:40 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 102F02170E;
 Tue,  7 Dec 2021 14:45:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA92313A8C;
 Tue,  7 Dec 2021 14:45:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 3HwINJNzr2HPcQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 14:45:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5918d207-576c-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638888340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=4UKQGIoPvsN+4ZLai38q0MD9ieq/sba1wLW27MFL3L0=;
	b=sW6WlNtA1wb2LI73s/Pz+VoEbNGvC1A5aY8iZI/qGwd0q4lDmPSzZY4kIZLoiZA4zrFUwW
	AdufaW1DAjiBf8BS/A44+gnyqaOwg2qPKuG/HbRdC+MgS7lDIScFbSJqy8ofOKTeBfrjpZ
	4FxYXlEljjP7Ko16SQl+dN+y6fnW1p8=
Subject: Re: [XEN PATCH 47/57] libs/stat: Fix and rework python-bindings build
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-48-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <eccd5cda-2606-90cc-e796-bfe2a7211522@suse.com>
Date: Tue, 7 Dec 2021 15:45:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-48-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="teIz20kXtalrcI5vcJFCxcRTpt4vlq30H"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--teIz20kXtalrcI5vcJFCxcRTpt4vlq30H
Content-Type: multipart/mixed; boundary="QhtOf0l6m749n3ygLivxGXojY2IWaoICg";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <eccd5cda-2606-90cc-e796-bfe2a7211522@suse.com>
Subject: Re: [XEN PATCH 47/57] libs/stat: Fix and rework python-bindings build
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-48-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-48-anthony.perard@citrix.com>

--QhtOf0l6m749n3ygLivxGXojY2IWaoICg
Content-Type: multipart/mixed;
 boundary="------------98398EEC076B90634D5EB02B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------98398EEC076B90634D5EB02B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Fix the dependency on the library, $(SHLIB) variable doesn't exist
> anymore.
>=20
> Rework dependency on the include file, we can let `swig` generate the
> dependency for us with the use of "-M*" flags.
>=20
> The xenstat.h file has moved so we need to fix the include location.
>=20
> Rather than relaying on the VCS to create an empty directory for us,
> we can create one before generating the *.c file for the bindings.
>=20
> Make use of generic variable names to build a shared library from a
> source file: CFLAGS, LDFLAGS, and LDLIBS.
>=20
> Fix python's specific *flags by using python-config, and add them to
> generic flags variables: CFLAGS, LDLIBS.
>=20
> To build a shared library, we need to build the source file with
> "-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
> new tools/libs/stat directory).
>=20
> The source file generated by swig seems to be missing a prototype for
> the "init" function, so we need "-Wno-missing-prototypes" in order to
> build it.
>=20
> Add some targets to .PHONY.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------98398EEC076B90634D5EB02B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------98398EEC076B90634D5EB02B--

--QhtOf0l6m749n3ygLivxGXojY2IWaoICg--

--teIz20kXtalrcI5vcJFCxcRTpt4vlq30H
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvc5MFAwAAAAAACgkQsN6d1ii/Ey9T
Pgf+MHG2AT9t/D5JwZs8B9XOjQEZq523cgM5DP0gsVrC/BbP4i1QnOZK9ogzmza5VvuXyKMqgz/L
oi+NxquJMM8moRG93omlRUBa7jiZLSku/TzY8wqIXpZvumC9E2gb87sYAl8HV/+8h5ddhlCcMKTT
TzBJVlFMYcGoZGJgQihv2XMEZ4o12TQpLv7esyZIaN6CnhqY3Dqlv+boK+Bg2ty5ufD2/lFL2Sou
T7J2YQip2JlCJyaT8/XziUPx5FLng+XBP4g4yxSByvIezdVNSZBCrBIAPi0GB+vgm+GQT4rFe/zj
MnxwtcSlEn5ayqHcD7WvHxAbbublD21BkwU2CZCSRA==
=S1JW
-----END PGP SIGNATURE-----

--teIz20kXtalrcI5vcJFCxcRTpt4vlq30H--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:46:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:46:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241213.418091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubjl-0001FX-2d; Tue, 07 Dec 2021 14:46:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241213.418091; Tue, 07 Dec 2021 14:46:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubjk-0001FQ-V0; Tue, 07 Dec 2021 14:46:32 +0000
Received: by outflank-mailman (input) for mailman id 241213;
 Tue, 07 Dec 2021 14:46:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mubjj-0000dd-Ee
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:46:31 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7700b8fe-576c-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 15:46:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 850551FDFE;
 Tue,  7 Dec 2021 14:46:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 531CB13A8C;
 Tue,  7 Dec 2021 14:46:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id FCQbE8Zzr2E+cgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 14:46:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7700b8fe-576c-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638888390; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=wRY1LBBbpxhY7al533EiPAZr6fx/aeM88mX5czSjq4g=;
	b=YRztkdhpfLm60pTkeqbv/QIu27sdoqB1qyxBJs1ljG2z5VuY+FQ+s11TJPEZe5UmD7PCah
	hmigUFSYZvhGsFnG8U9FP/dOPbeQFZmRLe9UHa1U0xTNqXTAS5QTsuOBLlxvI09tOMPWaC
	gdfmWPPf0mNtWi/uO+467ULuVUEn29U=
Subject: Re: [XEN PATCH 48/57] libs/stat: Fix and rework perl-binding build
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-49-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <d2ee82e3-85e1-78f8-064b-9fd126ec0d4b@suse.com>
Date: Tue, 7 Dec 2021 15:46:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-49-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="vt9JkTyR6PTskuvwx56dJ8hWR5QCxVdcC"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vt9JkTyR6PTskuvwx56dJ8hWR5QCxVdcC
Content-Type: multipart/mixed; boundary="hKyu8wkvRtcUPQlKSgLGEvTW7vTJauSNS";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <d2ee82e3-85e1-78f8-064b-9fd126ec0d4b@suse.com>
Subject: Re: [XEN PATCH 48/57] libs/stat: Fix and rework perl-binding build
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-49-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-49-anthony.perard@citrix.com>

--hKyu8wkvRtcUPQlKSgLGEvTW7vTJauSNS
Content-Type: multipart/mixed;
 boundary="------------6BA80D22831D5933FE86C50D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6BA80D22831D5933FE86C50D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> For PERL_FLAGS, use make's shell rather than a backquote.
>=20
> Rather than relying on the VCS to create an empty directory for us,
> we can create one before generating the *.c file for the bindings.
>=20
> Make use of generic variable names to build a shared library from a
> source file: CFLAGS, LDFLAGS, and LDLIBS.
>=20
> To build a shared library, we need to build the source file with
> "-fPIC", which was drop by 6d0ec05390 (tools: split libxenstat into
> new tools/libs/stat directory).
>=20
> The source file generated by swig seems to be missing many prototype fo=
r
> many functions, so we need "-Wno-missing-prototypes" in order to
> build it. Also, one of the prototype is deemed malformed, so we also
> need "-Wno-strict-prototypes".
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------6BA80D22831D5933FE86C50D
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6BA80D22831D5933FE86C50D--

--hKyu8wkvRtcUPQlKSgLGEvTW7vTJauSNS--

--vt9JkTyR6PTskuvwx56dJ8hWR5QCxVdcC
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvc8UFAwAAAAAACgkQsN6d1ii/Ey/R
LQf/eiGiEiPze8/KAd/oGxIL0pEmNduJwOUH0PrxjGoKXsFV2CZ5uu2+zFeCPLBveLCflWu/1jgP
QobeLYgomi1Ki03x3FTvaKA4enhSCIpmAli+iHCa9TjUrKm8mSgqL1XHT8dBMLicgBDmJyzfTwK7
pQ24BNVr5Lwk0B/KfP1eLYOcpMAW4NnYqWlk+8XeiqY+qtZBsVMwCoPMkqiwIKOarkjg4MNBEvJV
pwJP/HF3llYgL7EBkZqUzuP07EQBFbcTVQEs5TeM8sw88vw+UygpvvHVyotb3Lz5Bw/6VI9CR/u4
qpkZ1nqaxCZrSHDTzdGsW4CzAHg2DOPRrhM6A6FrZw==
=e/aw
-----END PGP SIGNATURE-----

--vt9JkTyR6PTskuvwx56dJ8hWR5QCxVdcC--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:47:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:47:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241223.418102 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubl5-0002Zj-D1; Tue, 07 Dec 2021 14:47:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241223.418102; Tue, 07 Dec 2021 14:47:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubl5-0002Zc-9o; Tue, 07 Dec 2021 14:47:55 +0000
Received: by outflank-mailman (input) for mailman id 241223;
 Tue, 07 Dec 2021 14:47:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mubl3-0002ZQ-OF
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:47:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a7e20825-576c-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 15:47:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 93F442170E;
 Tue,  7 Dec 2021 14:47:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DE6913A8C;
 Tue,  7 Dec 2021 14:47:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id l/WQGRh0r2H6cgAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 14:47:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7e20825-576c-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638888472; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=I1C5nBC8MGHl6ShL6XYBl5AD3w5EJcNZ/gq/an4cIPo=;
	b=hB8muILqQfHM2aOgW0Hs2WG4QGT3UBYuT/LQefatTMTqfSN5feFQqfYijq1mHv+zYbVUq0
	23IeHvgfrKym0MzYZSk3Dw6o2T/s9lo44kvX3/PtWC4wSZzqvuqD3/O+Qky5rF2f0tDDTo
	ekzoaI9AryGSOYNJHYB25rTg5NchWek=
Subject: Re: [XEN PATCH 49/57] libs/toolcore: don't install
 xentoolcore_internal.h anymore
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-50-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <64910248-fc94-9f84-9e50-5d2b885f5f05@suse.com>
Date: Tue, 7 Dec 2021 15:47:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-50-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="SMaOG8hN78KZZYle3Z2fBl5jSjST6P2kl"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--SMaOG8hN78KZZYle3Z2fBl5jSjST6P2kl
Content-Type: multipart/mixed; boundary="P7DyRom2M1DB1UNTzbiWZyk9pPliBlbss";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Message-ID: <64910248-fc94-9f84-9e50-5d2b885f5f05@suse.com>
Subject: Re: [XEN PATCH 49/57] libs/toolcore: don't install
 xentoolcore_internal.h anymore
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-50-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-50-anthony.perard@citrix.com>

--P7DyRom2M1DB1UNTzbiWZyk9pPliBlbss
Content-Type: multipart/mixed;
 boundary="------------9B0C384751A95B7AD87973E3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------9B0C384751A95B7AD87973E3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> With "xentoolcore_internal.h" been in LIBHEADER, it was installed. But
> its dependency "_xentoolcore_list.h" wasn't installed so the header
> couldn't be used anyway.
>=20
> This patch also mean that the rule "headers.chk" doesn't check it
> anymore as well.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------9B0C384751A95B7AD87973E3
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9B0C384751A95B7AD87973E3--

--P7DyRom2M1DB1UNTzbiWZyk9pPliBlbss--

--SMaOG8hN78KZZYle3Z2fBl5jSjST6P2kl
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvdBcFAwAAAAAACgkQsN6d1ii/Ey+Z
lwf/ePYwn2gT/OZEokwFYT1wbE3QjHoWk0q9P/agpG7IErqYaVV9Tz5sGZ+sec7TsjD+9niJC2mm
jNhARsaFeWO6ulbNqulnU4p/Vd2hEHpJDKDccxWRzx6IlCgXe3jG0Hs0NGrdoYQCBN8xepCa6PV6
Xu/h4S9vTUAfk1w2UCt0etWEORQ1HrG7+t7WHEBtXNMWFuDf75qrs4Aj7OwD1r9DmomTdOXRoVuc
LDxP7iwxEdu8kt86FTPxvD0sCZRKdsNMIYRwVN9qlLe+EZkmBljcns7fAO9U2Uf8MkTR97zBk/jb
JJ6kft4RKFEMEIdRytUo2yIoMEYinKLoZFIbcW1Amw==
=lsVS
-----END PGP SIGNATURE-----

--SMaOG8hN78KZZYle3Z2fBl5jSjST6P2kl--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:56:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:56:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241231.418113 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubtV-00042Q-7c; Tue, 07 Dec 2021 14:56:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241231.418113; Tue, 07 Dec 2021 14:56:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubtV-00042J-4c; Tue, 07 Dec 2021 14:56:37 +0000
Received: by outflank-mailman (input) for mailman id 241231;
 Tue, 07 Dec 2021 14:56:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mubtT-00042C-Bt
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:56:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id de99b59e-576d-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 15:56:34 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-j8f-1AkUNwqCnDtcDh1L-A-1; Tue, 07 Dec 2021 15:56:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 14:56:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 14:56:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:20b:46a::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.14 via Frontend Transport; Tue, 7 Dec 2021 14:56:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de99b59e-576d-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638888993;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fesGwMC+sgklS9IYU5JfH8dnwTc+ryP7uhzAVm4VrBM=;
	b=WHp0hhzk99QbHQbSQICfIXPSDrlR8Kr7EdGxs86PEurKc3Do8OED2cov+DUPtoRds+Ks5e
	K5JVvvHBjKvxqoSC/c2ti/HkUwbXeZPBqj9x298nEtHJjVDG7BajLAwu+ovOwR/phZy26n
	iVDlI4Y9KCzPlpqb3xhwTRGa3E8uc6c=
X-MC-Unique: j8f-1AkUNwqCnDtcDh1L-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HFYjWh5OAy7LDAZiSpisK4OdtKiO4uHV8jMFo38pLdyriA759WD3n8zNS1+OKZ8tH4EKQxRciISBV5qBTIWgn1rvPOIHwxQv8yicgAoaoMEcH67S/p4l5zqUDy50fXowllae0zPYev1D3v3BWoPnaVGVk7GTUN5+dQqIuHD981hufQVtzLaJBvUq0VqIWFqOnLutBAm+72C4q3iwmk/4wWQjNkvtoEK1vmTQJTawuRk7swZ7mN3pxc2tPPHq1bGFqHQ0aC4MT1JD01+Oq0OQNdLxrOjOwBIQWoW5SSixIq9hwzIfur8O7mg77w5W/LTaUVpfxlr2sxIy2gNtTkuTRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fesGwMC+sgklS9IYU5JfH8dnwTc+ryP7uhzAVm4VrBM=;
 b=AVN9xqr090pgD+Oori6XMy/Z57VlKPMiu3ClXZbzwa3DGPBSxgD6+gkLCwGxsi4BQqHzSVndkPs/1OmFZjcxfeGLyiPuhueUvSd3MtuOt1URRRvd8HbEWjuQjoe1aegouUeogk1ldjtlkk+iRGUP5LkWAdQVkTSWqI4vTsC1pKCr3Rf+CZeI3O3Gsg20AyEeGaxi3C1GVSqpG+Fsb1i35jXnr1ELklK3JnCpjxWUhw0Ekj+ox2aoxk3JB1YLiP3GUPHLqWm+W8oo9ooDtaMeFFEzALY6BH8QfHjVfVQm1G5SyNmFS9DmIDsIX7eztxbc6fv5i1VoOSlCVOXU+KPfJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1e1e0b13-f77e-acd0-e43f-58efc706ac49@suse.com>
Date: Tue, 7 Dec 2021 15:56:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 1/7] xz: add fall-through comments to a switch
 statement
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <adba1753-4d6b-0ee4-a7c0-42c5ef520b67@suse.com>
 <9666b3cc-d4c7-1a51-3a23-419d16232465@suse.com>
In-Reply-To: <9666b3cc-d4c7-1a51-3a23-419d16232465@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0032.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3322713d-94b2-46e8-44cb-08d9b991c167
X-MS-TrafficTypeDiagnostic: VI1PR04MB4845:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB48450FDDCCB5378EB23B4426B36E9@VI1PR04MB4845.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:196;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	meHr2NnH4X6o1sPFMd9yxJV7UyQn0amjitFkXXvcgHloKKHU6k7FIHX3IhHi56awve+yTlD4WzLnKI/LR4RTAQ0lUFuq25JTZstruUa+Md1kvnc0KZCNhDo9AZt8+TVHMdAhIhahAH5fYMiErCAb+7V4Y+Froachc7DEKst25clMbAjlPeWAp6jHQj5UxEfrTSBX2sa2MeSJjjOSWJskjDIGvK9lxcKML6A/RlKyod8dQzfmeP3cpP272LB9dGUXA1idMahdrhr8tCd2cjJv80tZ/3tutLC86HeOpPK+djIHYJ3LzPnZiWv00dvdWHXVhXxYsj8wZbDIo9Z8n/Lkb/V7REXfAE38XQPZ5n80B3ZXZk615ezg/cdKIl+thWVfKEYmN+g2PsjyS6AIyboY2ywyrJD2OXZrCwQKHF8cqV2uvDtHWz01SCrheYghr9nGBsAzAXVca1dESw4exHdnmglRUnnUVX5JAhvqTr5UrPJdTFBJIF7P+fHjjqB/E1bEx/Ll7x3qFL81lI4sHjX2/9gclRCcvf4zc9dlcJxYx+mSj1u/StooahD/ycMFp7sd6i4sjecRj3+C/441tnGWIqLZ+w8THgJEy+KLARjsZPqb40VNRtlMlBsmQT5Z4nScaPrMcFBUD8Q/WIsG0SNjEnC2Ji47/BORnL9AjRkFtlBnWoFWpF5kptD2wCPx1YmsaHGjPUn7py8kTIIn1vjztX7Eo+Xhvn4yyTGRukS+tEo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(66946007)(66476007)(186003)(66556008)(508600001)(86362001)(5660300002)(6916009)(956004)(31686004)(2616005)(26005)(83380400001)(31696002)(53546011)(2906002)(6486002)(8936002)(8676002)(16576012)(4744005)(316002)(4326008)(54906003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2tnbU9CZEd5aEhWQWtPTlJvTHRNZ0l5QWs3MXVRRVlEVlZZMDhyQjBBK0J5?=
 =?utf-8?B?c1ZQWi9POTZhamRSY3d1cDJJZlk5T2luRW5NUnJjRlNjdjdkUW9xSHpvNTAv?=
 =?utf-8?B?d3lFN0JrZDFmazRxK2o1RmowYXhWK2U2b3YwdjJwU2kyKzlEVmszbjRKd0RK?=
 =?utf-8?B?T1BEWjJUdC96ekhIcGdYYm1COWd4NUx1NFpteWR0dkhNNUhTNHJtK3MxOVNk?=
 =?utf-8?B?NEtHWmdISTZBd1RuZ0dyZE90bnZqOCtPZ214RXA3aHJLMS9VWEVQRDZmQU5t?=
 =?utf-8?B?ZDVIRkRRWmZQM0ZjRlBISFBGRGRwYk56U1hmaFNLRG15R0lWQlFpeGdLWCtL?=
 =?utf-8?B?ZGt1M1lPYnduQmRjVW85bjRxY2ZPVnBTRzZNNjdjaW5McUZXaTcrNk0wdVJL?=
 =?utf-8?B?TFZ3d0VFWGtmeis4anFjL21aWE40ZFNwYk9Qby9oK00vRGJPcFhUTmM1dzBl?=
 =?utf-8?B?K01Ka1BabzdaNG1PR3kvd01IcEFIUE5YaHZWM2FsNVIxZXUzbE40MDNDa0c0?=
 =?utf-8?B?amp3VmllM1ZXbVNOZHNlNEE0ZmI2dEFYNnBGL1RSMmw3SkdYKzdaSlh4eE9r?=
 =?utf-8?B?VkoyTEp5bEU3NFh2ZzZFRzJGUS9Ra1R6bDRiY3U5ZXBsQ1pyVlBiVFJvMUJj?=
 =?utf-8?B?ald3TFFBYTRGZmYvbTNvcUdwb0lBdk9DRXZuQUtONWorZ0pDTEFDaFJ3MWxJ?=
 =?utf-8?B?WUVNZGMzZzdCUHRSMjV4V3BCTXlnYlBka0RLeTUwWXczS09yL0lCTTVLWDZ5?=
 =?utf-8?B?V2dINEppODZGRzJRQmZPdlJCZlcyNGhCdE9jVXpiS3UrSXF3Q0hhU2VxN3Fl?=
 =?utf-8?B?KzVXYlA4Nnc1d0g5ckpPTnNPVldPTEdTMnpEcEU5VDNvcTRuUFlPMmpEcHhI?=
 =?utf-8?B?TU4vS3JiR01mUUY3YkpQd0FTRGpmWVUzUjlIb0lKMzMvdW1FelIyUmVkaCtJ?=
 =?utf-8?B?RHJDQy83bWszNmI1TVFzeHA5R1BtZW1uVjdwcnB2em5EZ0JDOERvL1JTVjN1?=
 =?utf-8?B?aHpBK1NIak1WZVpxWHA1RmhhSWVpMGw3dmJGcmZweG1rcXdnV29xc0FNdUpl?=
 =?utf-8?B?QUlkNFkwd1YyRUUzWWsrSmtHajlQcklxMjh3NEZnTWxiVDRpdlVoQkYzLzhq?=
 =?utf-8?B?a28wT1VlaHJIbnpqczVpdElxbHppWGh3QU92SkprSklBaVljR2NlWUN4UDIr?=
 =?utf-8?B?QXFzT2NSYXRYRnJlb2pTRkgzc0pUQWQ2TXZLbklkWENRampYMjRxNDhEeWhv?=
 =?utf-8?B?allzbUxBWHBXNXFIemowdU15STRPVXorcCtiYmkrZDAvWHYxTTlyV0FlaTYy?=
 =?utf-8?B?amoveUZEN3VzdnBCbTk3ajlTenY1RmZtMTJ5a2hFL1krWmpUZU0zeUZBSG53?=
 =?utf-8?B?OFJsNDE5elNqZzZPS1EwcjVJZFVCNmlEUy9sUktHMjV2UVgvV29aVlNOdHph?=
 =?utf-8?B?bGp1WVY5NDhXcGMwM2lFbGpwc2NnSkgvaGIxZDI2SlhwRlJsNTRpNnlhekpi?=
 =?utf-8?B?QzZ2WDUwNmFnT0x3MVRlLzFlK3oxd3JyL1dUWERubWVUSnltcTJaS1lUd01x?=
 =?utf-8?B?dEt5bTdsRnBVYnpFNElIU3dJYm9sbS81a3Nlekg2U1RUbTVyVmJFZEphUnFT?=
 =?utf-8?B?YlNWQWxvQVdaZStlSmd3L1NsM2FBeFhIWUVJUklqSkNWeVBXei8wcGpteklP?=
 =?utf-8?B?WDRHWUZKaTZ2NmgxS21ISVJoUDl5bTBtcG81QmRJV3N6My9LL050d0hOeTBp?=
 =?utf-8?B?SW92TS8rNERUdnNUUUo0Q3RRQzMrSnVFMWQxWDhiS2ZGS3c3VkthMXJOWVRM?=
 =?utf-8?B?K0F2b252cFFUTW1RQnc5dFlldnVJREJFQ1dpdVU4aTNGMjZhOWtFNmN3ZmY5?=
 =?utf-8?B?ZTZCeFZCSi9pdUJSenRRb1pNN2p6WFNudU1rQzdmeUl1dXdQVlQyOFkxWEpI?=
 =?utf-8?B?aWpya3lSenVyK2RtOGE3VS9aSWd2N01XNXU1VUxCTDZVNlNuRnRvK0FacURL?=
 =?utf-8?B?VmJhNEg4aXE5V0NFTzFYL3R1N1kzNldtQjQ0QitDcmMwdkJpakJ4aFRsOVlN?=
 =?utf-8?B?akJGNmZVMUlZcE92bUxFbDloekRKbVE5RzIxdnRqdnhWN2pQWUhQOVcrT3NM?=
 =?utf-8?B?Z3hsZlRKSnVET3grMDFVUk96VUg5bnc4bDM3R055cnR4NGx6ZEI3SkhVTlh2?=
 =?utf-8?Q?6SpQ0PDoyj0r2dxwqmRU8Yw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3322713d-94b2-46e8-44cb-08d9b991c167
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 14:56:31.7142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rDlo5uRyJ/tY4mzZwdOgWfH+1Km4Jtruc4cv3VKpkYHQCUOErIAFm+EfiY94WEVUWSHBC/Rcr2PoIahQJn6ryw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4845

On 06.12.2021 14:30, Jan Beulich wrote:
> From: Lasse Collin <lasse.collin@tukaani.org>
> 
> It's good style. I was also told that GCC 7 is more strict and might
> give a warning when such comments are missing.
> 
> Suggested-by: Andrei Borzenkov <arvidjaar@gmail.com>
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> [Linux commit: 5a244f48ecbbd03a11eb84819c5c599db81823ee]
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Julien Grall <jgrall@amazon.com>

Because of the ongoing discussion on the respective v1 sub-thread I
have dropped this ack. It was suggested that I may have misunderstood
and it was actually withdrawn.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:57:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:57:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241237.418123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubuB-0005MA-Le; Tue, 07 Dec 2021 14:57:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241237.418123; Tue, 07 Dec 2021 14:57:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubuB-0005M3-IX; Tue, 07 Dec 2021 14:57:19 +0000
Received: by outflank-mailman (input) for mailman id 241237;
 Tue, 07 Dec 2021 14:57:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mubuA-0004eJ-AA
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:57:18 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f888a555-576d-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 15:57:17 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 43D192170E;
 Tue,  7 Dec 2021 14:57:17 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 03EE713A8C;
 Tue,  7 Dec 2021 14:57:16 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IPNCO0x2r2HadwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 14:57:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f888a555-576d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638889037; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TaIH6SGfZCFmVlzrAOuw1mdswCpmvsE0+rBMfpb+6zA=;
	b=eLkWxLe5AZCWoy2RghjJmpoAy9KGEmudnrQtRme6yAFbBZGaCyc7yeiwtDUscNqFsK0i1M
	KACVPMxuCgWdfK+DXHTIa5ZOIuU7WytrEKl7TsGv6/fxC3Hk/ERm3AoIfu3saFKXswF6Yi
	j2un+QB4p/zhgRhiS14N8KaPHzIbpU4=
Subject: Re: [XEN PATCH 54/57] tools/libs: create Makefile.common to be used
 by stubdom build system
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-55-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <82362379-75e7-b1a6-604c-53a313a1c64c@suse.com>
Date: Tue, 7 Dec 2021 15:57:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-55-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="RvDzpKFu3m6eiQveBNSLonHUrIXJjcZ0h"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--RvDzpKFu3m6eiQveBNSLonHUrIXJjcZ0h
Content-Type: multipart/mixed; boundary="Up7doXiWszVUPyZTWLrXviSWFxyrsNkls";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-ID: <82362379-75e7-b1a6-604c-53a313a1c64c@suse.com>
Subject: Re: [XEN PATCH 54/57] tools/libs: create Makefile.common to be used
 by stubdom build system
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-55-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-55-anthony.perard@citrix.com>

--Up7doXiWszVUPyZTWLrXviSWFxyrsNkls
Content-Type: multipart/mixed;
 boundary="------------220D37E4D19C4C76B1EBED24"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------220D37E4D19C4C76B1EBED24
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> This new "Makefile.common" is intended to be used by both tools/ and
> stubdom/ build system without stubdom needed to use tools/ build
> system.
>=20
> It should contain the necessary list of objects and CFLAGS needed to
> build a static library.
>=20
> Change stubdom/ to check Makefile.common, for the linkfarm.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen


--------------220D37E4D19C4C76B1EBED24
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------220D37E4D19C4C76B1EBED24--

--Up7doXiWszVUPyZTWLrXviSWFxyrsNkls--

--RvDzpKFu3m6eiQveBNSLonHUrIXJjcZ0h
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvdkwFAwAAAAAACgkQsN6d1ii/Ey/8
RggAhl0Jh85UqmAGQAIcOU+FdAHPP8Otdl1Mqtzl8sh7J5wQHp3TOy88zxuNJxLHsuxb16FTKGDo
7TdEqVFjuvLTtqaR1gXdr94N0bmFf9EmfuDvN0IYm3tOmQkfvwv9n+NqqcbKHNfRj5fjy6C/XTIE
a+2Vt3/wUfAJcmIqfUiwJ6VHZ5wQ6bN+2cj0mGUBo15d7YHTXxHunqY/MiIxoWJ0skPHiYwfPF+S
PqR55m54Yp8rm0jV96v7SOEdVqrIMb7Ba1djXQK+i0FtrRLgYvMcnjfLCC1aMvyXwQFU4DopBig3
5/YBtYcXmHvoxFxkE0ZsnctN2LZMcJ4DoHqVEwGszQ==
=1bJf
-----END PGP SIGNATURE-----

--RvDzpKFu3m6eiQveBNSLonHUrIXJjcZ0h--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 14:58:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 14:58:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241244.418135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubv8-0005yT-V9; Tue, 07 Dec 2021 14:58:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241244.418135; Tue, 07 Dec 2021 14:58:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mubv8-0005yM-Ry; Tue, 07 Dec 2021 14:58:18 +0000
Received: by outflank-mailman (input) for mailman id 241244;
 Tue, 07 Dec 2021 14:58:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=myTo=QY=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mubv7-0005yC-O6
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 14:58:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1bf10f8e-576e-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 15:58:17 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BDD3D21B39;
 Tue,  7 Dec 2021 14:58:16 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9347313A8C;
 Tue,  7 Dec 2021 14:58:16 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zqvBIoh2r2FjeAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 07 Dec 2021 14:58:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1bf10f8e-576e-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638889096; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=bKu3j0ce9dOeLrgDAnwT6sOdWbOKrvHJhezxYCGMNK8=;
	b=cVUN7d2HY3sna7VFH9wn4dX6QaxElfW8Fgp6orA01uYpbROrKYU34HPBMgdt918PDIviDl
	dLRqxbzE2TG2KmzA2FL9aKY4JA2oHhOfTuR9u4Wy38mXRABgF+QbIxB9ZL/q2B5nWIfI5C
	MPxJ0TWBqye6Mmiphg7nVTt3c3YndfM=
Subject: Re: [XEN PATCH 55/57] tools/xenstore: introduce Makefile.common to be
 used by stubdom
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-56-anthony.perard@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <6b7d4cd5-fcab-c782-61a7-f25b07296693@suse.com>
Date: Tue, 7 Dec 2021 15:58:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-56-anthony.perard@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="mN5wkinfZPPobJ3mmOpETQEDiyB7Mkt7O"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--mN5wkinfZPPobJ3mmOpETQEDiyB7Mkt7O
Content-Type: multipart/mixed; boundary="XtZPuWu2JzGkeIlpP93nOLnxglurSGWEE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-ID: <6b7d4cd5-fcab-c782-61a7-f25b07296693@suse.com>
Subject: Re: [XEN PATCH 55/57] tools/xenstore: introduce Makefile.common to be
 used by stubdom
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-56-anthony.perard@citrix.com>
In-Reply-To: <20211206170241.13165-56-anthony.perard@citrix.com>

--XtZPuWu2JzGkeIlpP93nOLnxglurSGWEE
Content-Type: multipart/mixed;
 boundary="------------3A5E035E680D087F375AF2ED"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------3A5E035E680D087F375AF2ED
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 06.12.21 18:02, Anthony PERARD wrote:
> Also change stubdom to depends on Makefile.common.
>=20
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------3A5E035E680D087F375AF2ED
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------3A5E035E680D087F375AF2ED--

--XtZPuWu2JzGkeIlpP93nOLnxglurSGWEE--

--mN5wkinfZPPobJ3mmOpETQEDiyB7Mkt7O
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGvdogFAwAAAAAACgkQsN6d1ii/Ey+W
fgf+J4pPWC/LNHf2neZXWlbJOM88SRFuo7uMx3k7JHpg0l589T080MVhiz9qGE0U9vK1+z4Cvq9t
FfxsCS91a33dWjmojIHFRmEqnzfolkCF9wh/fzvLaa/7IVQoo34o/bQfiY+SRY4USqaFDyH+MTVN
GPIrZckQzD0fsyBLYm3SdmAvPtiqceTv4WoN4I7a1ckzO/+TRT8YX4t2q3XGGp9cvJxp5c1SZ/Iw
d0NTOdAky4L2rqMxAn+C6Hn3LKKT97LcHcgAw8zJG+F06dyKBh9a3EbJWHE/UgxbHj0lok9T2HvJ
PqDZ2KJx+LhUiIJ6Ih6RiA8hJzKd9pYnQekiUPcmnQ==
=pnTZ
-----END PGP SIGNATURE-----

--mN5wkinfZPPobJ3mmOpETQEDiyB7Mkt7O--


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 15:05:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 15:05:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241251.418146 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muc2L-0007RD-N7; Tue, 07 Dec 2021 15:05:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241251.418146; Tue, 07 Dec 2021 15:05:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muc2L-0007R6-K7; Tue, 07 Dec 2021 15:05:45 +0000
Received: by outflank-mailman (input) for mailman id 241251;
 Tue, 07 Dec 2021 15:05:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muc2K-0007R0-Ar
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 15:05:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muc2D-0004TY-MI; Tue, 07 Dec 2021 15:05:37 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muc2D-0004lC-Dk; Tue, 07 Dec 2021 15:05:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=YroXCPuf1AqdBV+koAfORzRqbBIc7GtCrWVldlQ+0hk=; b=IB8HdLsf+BMwNXVS+nh6aYG+pQ
	KH4arJQiOlTZtnokvtfhpEZNLdgTxBd7/Tlsr/7+N8pV3ZxZjbqSfYRcwby21X6TjFlvjQR/iLNVf
	8CYET3/FSbbJ33pafgr5DXqk15M/4AK/T7POeDnifyuFTlhAMzKWER63jr9TMfNkNdPs=;
Message-ID: <15e7d01f-14b7-e661-65da-993ec2f9cbfe@xen.org>
Date: Tue, 7 Dec 2021 15:05:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Call for agenda items for December 7th Community Call @ 1500 UTC
To: Ashley Weltz <aweltz@linuxfoundation.org>,
 xen-devel@lists.xenproject.org, amit@infradead.org,
 andrew.cooper3@citrix.com, Artem_Mygaiev@epam.com, ash.j.wilding@gmail.com,
 ben@exotanium.io, bobby.eshleman@gmail.com, brendank310@gmail.com,
 brian.woods@xilinx.com, cardoe@cardoe.com, christopher.w.clark@gmail.com,
 Corey Minyard <cminyard@mvista.com>, daniel.kiper@oracle.com,
 deepthi.m@ltts.com, dpsmith@apertussolutions.com, dwmw@amazon.co.uk,
 edgar.iglesias@xilinx.com, Ian.Jackson@citrix.com, insurgo@riseup.net,
 intel-xen@intel.com, Jarvis.Roach@dornerworks.com,
 Jeff.Kubascik@dornerworks.com, jgross@suse.com, john.ji@intel.com,
 kevin.pearson@ortmanconsulting.com, Matt.Spencer@arm.com,
 =?UTF-8?Q?Mirela_Simonovi=c4=87?= <mirela.simonovic@aggios.com>,
 oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com,
 olivier.lambert@vates.fr, pdurrant@amazon.com, persaur@gmail.com,
 piotr.krol@3mdeb.com, Rahul.Singh@arm.com, rianquinn@gmail.com,
 rob.townley@gmail.com, robin.randhawa@arm.com, roger.pau@citrix.com,
 scottwd@gmail.com, sergey.dyasli@citrix.com, sstabellini@kernel.org,
 Stewart.Hildebrand@dornerworks.com, tamas.k.lengyel@gmail.com,
 varadgautam@gmail.com, volodymyr_babchuk@epam.com, wl@xen.org
References: <CADT4066W=fGoiyCTATSM3fZozrS1NYh3aFNtw7BM044ui_RL8Q@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CADT4066W=fGoiyCTATSM3fZozrS1NYh3aFNtw7BM044ui_RL8Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 02/12/2021 20:24, Ashley Weltz wrote:
> Hi everyone,

Hi Ahsley,


> Our next meeting is on Tuesday, December 7th at 1500 UTC.

The calendar invitation is for 4PM UTC. Can you clarify which time is it?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 15:21:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 15:21:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241259.418157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucH3-0002fS-2J; Tue, 07 Dec 2021 15:20:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241259.418157; Tue, 07 Dec 2021 15:20:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucH2-0002fL-VM; Tue, 07 Dec 2021 15:20:56 +0000
Received: by outflank-mailman (input) for mailman id 241259;
 Tue, 07 Dec 2021 15:20:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J7u3=QY=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mucH1-0002fF-80
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 15:20:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4475a7c0-5771-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 16:20:53 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-G8BKt6zxMA24POGB6MUi2Q-1; Tue, 07 Dec 2021 16:20:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Tue, 7 Dec
 2021 15:20:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Tue, 7 Dec 2021
 15:20:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P195CA0063.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::40) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.17 via Frontend Transport; Tue, 7 Dec 2021 15:20:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4475a7c0-5771-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638890453;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XupTZiECmFqLLilaRn6AeO2eE4vjC0wb540O8XZyy90=;
	b=MwuQdG9q57kQLMVNiBDZkwqmF+HCxtlGHMfYw8I8/0IWjlyqrnshv+leXWwvujsbhcs02P
	zD2UWYv07vLYtN51Uh+TNYN/LckBHD2+FnhTOTOmr561j6HCnGuDlSMIQ0+Kv99xdDAVhy
	SAAKis4gy7Bd4Xc9kCOat9I1spjKlAQ=
X-MC-Unique: G8BKt6zxMA24POGB6MUi2Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dfR/GBb5m1uci8eu3wVt1RLG6hDnqVY71HWjouppD7/uKcrs6CPz7BJ78L3ZeMvzXAo+Sw7kkFSIlgHAUip7wLoOfbIKGB29Q6qPNv8ixHjiX6VA5JTBkTxkI025C+2UzhVWLUL4AMNWoVu+zoFtHqjaNCxhiPUmcwwNzRyiLFqyiNKRdB1J20s/7TCSQTRGDuRxvj4m24TIaCBKEdLUgLzhAZcSQtLQBgi5NgNB/pCy47mDk0Ax+cQZkl1T6Iiim5ct8Ag7ai39mFSQGAT6UfCVWSZa29ALWWTL3xTbPLcsOmz1nAn5HTumd/5ymo5bWJNDFjhAgT3ow1gpz6SheA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=k+LzXGuMUIsINIBTh9QaoXw2NcVFk1toHUM38W2fzTE=;
 b=j+nHSiSoyNYQgIplLYnj18VE/Gt40ut5/11Fukw7ewo6MSYwBnu/kmvCZaHkTOykdVKVTXYBoblIFPI04FczVh5WwVseJeZlmugiZx1E7IC6vX42mpe0wT2y7XACZR4zeRPe08zDwsdMDZBs3t3cAXbSaSL3YlwO+YOIc9o1nv1dEXzTM+4ZFveL/WwL/1YuERQzd2oh95O24vCd5WGD1cSIJ4Qi2o14mg4OhWMi4cN9bttQV4v1XGbXIpjKIPhK+xtYyNRDKsAI5CDACB88orbt2Cep/Nc/bgPjuZzkdFCNGb1Wqu/WnWm0uMJ06zbd3+UCOLbstGJK0QTLuizI6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8426f7a7-24b3-d295-bc06-30e1c2c018dd@suse.com>
Date: Tue, 7 Dec 2021 16:20:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: xen: linker symbol mess, and freeing errors
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
References: <115c178b-f0a7-cf6e-3e33-e6aa49b17baf@srcf.net>
CC: xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <115c178b-f0a7-cf6e-3e33-e6aa49b17baf@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6P195CA0063.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:87::40) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 074684ac-65f9-4682-a292-08d9b9952734
X-MS-TrafficTypeDiagnostic: VI1PR04MB7039:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB703973DB918A5E31D2DE0348B36E9@VI1PR04MB7039.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YOFVvSrmpqdDMe+wSvdiIXxmdQSe+qFhKoNBDlAzBwKgNioo9to4Klf5BLHw9vLaRvhn6orK7SR+3hG19B13075xywWVLkNEy19JpkwL8sPKHcHGo56BUE5q7wkcthqjJkbd0CcAisoxB1Ws7T4MxksV8xDhFz3TUTjO3KaK6dx9ZT1slOsYK7+yCt5JCytWryoz0FsLjpcXA/ShU8+AYzhbwJuVodrrVhnKH7O/Os8Bmx3XT0tgcW79eDGVDJyOWh+8brt89L5OrotvunNvst1ZCtGlvh+9170Vb7pgTlx4SnZMTkb6rGxfWOKe5cWPsm7zehlAKm2nCzdX5ZJ8kMBDwFRwBQ+hH7ffuUbJFLp7JTC0xninu+o48k9uDONVbMEVVrXKSlup8mGFqty/7Z+aGp2qQmX1Mlqs7WkI51JX19y8AoZmPNaEZt1YOWDOm6uJVGltxqkjOrccHVbiBrvRcJCUZD7/r+WcOlfUzDie0tJP9SRysxT07qbL9nZLZ1kJKM6ZCkiEAPsP95D6iBNZ5JZlm8GyOfxykweve0hIa5LOl2sOXNs0G/cfp9nzZCDk+Bn2CDl/5wonTyQ28i8ncstUxNEjZhAH5ERDit1yHCVTq3LBGQLAoxK5RUcMZWuOwXPUnRnYuc9UGMfgZyjrupQ1/31SZJIRkKI1J0Y4cJ7TIqXnxU6yH0oEbnT/9vSa/vmZdKue2f4VpwsaiS6DSCbJrKp5YYRwuWiWhRE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(31686004)(8676002)(16576012)(66946007)(6916009)(316002)(508600001)(83380400001)(36756003)(8936002)(53546011)(66476007)(66556008)(38100700002)(2906002)(6486002)(54906003)(86362001)(2616005)(4326008)(186003)(26005)(31696002)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DI29yRKpE2gNl9eEZ6gz9nHVtOnvJAJ5C4FdGLMqmwaE7WmipsHPyxjpEcjD?=
 =?us-ascii?Q?/rxz+JwoZE3d7d5M671Yg/WoHUsxNQdt3ZPU5d2muF18Pe3bc0tlegK6SyXH?=
 =?us-ascii?Q?vfKsixFFPTfFWLYXwOP4YW1p560g/uPLypP5mDzwSxaOXGJctPIO7U0k/LHc?=
 =?us-ascii?Q?RDciSYOrH0OY3xUgKgvpe7uk9raMJlZvskCVDJA3v2P2YdrEE4PrN6oO+O4T?=
 =?us-ascii?Q?NT4qGd1XCqNVlqSy2UBuQx7Yz3khp4aeTmwbXwRoLZYFkbmviS/Lf7UbAGnS?=
 =?us-ascii?Q?Vq9HgoV5SpnnX2g3jWijFE0fZbP55s7L6wXWlHmoj2FT8NwE+2SN0gaHtrkE?=
 =?us-ascii?Q?JWNYbo0OTHn+9BmekZgKP+CSruOLAIMyn3H1Jhd6yLBbSgLdEBqWT3tLfISg?=
 =?us-ascii?Q?OOr0sM6tF2QQOSNohG2G5SHZIy8VyKYqLz+JR1HbOa1uI8JH+7jLSh2e4rve?=
 =?us-ascii?Q?LYzaJ3ccJY5YgyT0QT/C+6YR9Mj2rHxjBgeayDLQ/OIZG6lHk7TCupRU67Rl?=
 =?us-ascii?Q?KdylYEjynwVG/wxnUpqEZTzE8rEadQo8XDNfaVu05OSyQR7uxvOiKQeE4Uo5?=
 =?us-ascii?Q?cMtHvjAzziokv5xGJ6MFELCkM5KE1IxLr0lh9rMAyglsluWTLvsjDgrkfTKK?=
 =?us-ascii?Q?ZGwp84MYcbfqitbolgAwtc5GOGlZ3wRCj8DWTfgosaH+dkl/9ns6pP2qkQPQ?=
 =?us-ascii?Q?0aP2af9tRhBiGB9y6hbzVqPvVVRjRApGIcbDfASUUYwgoBNs4faPXE5L0FeG?=
 =?us-ascii?Q?W1ul1CLvaGyGrvHfcXPf82z1jFjrYPUzMBaPyf86eu2Y/K6fRVTiCHax3Js0?=
 =?us-ascii?Q?PZcgr2dQ5jXDLdZTU58hVqenqZYlRAwa2BlNcQu/F79WxPD0xkBdMm21anly?=
 =?us-ascii?Q?FRqdoggA6D1etnoPwS1UY+IsQF6aq6DgH6+1LYOwbEs5vivlTdQaJ0A/z7IC?=
 =?us-ascii?Q?ChGv67KgcCTgabSXExP5ABOLD1eYlHLB17QV8wLET4KXEogOk6E4Smsf28TZ?=
 =?us-ascii?Q?Ht9T2fmWLPFUQ9fjGUcrRz36fuYwXMpuVapwCudzTxg5DCRwTP3lBRkmm7Ps?=
 =?us-ascii?Q?/OApqaagd37Y6wDvcWjK8gEqWLmlLm/dUcWcelf+8LWxf547nD63NjQVVijv?=
 =?us-ascii?Q?mL8c3sUo8f0rzw0GPQDX/KHiA9YLxReeBxJJuz3HlZSeUL1Rw6mpPOBhudd9?=
 =?us-ascii?Q?GqZzAB6GSgUWbSlhwSXgUKAQzQOxENlhH5cyD1Q0LMSPVDfuBVCjCTd1wsZ6?=
 =?us-ascii?Q?g/WKxfXM0QMTfrJz6jCIK6gFCKvZwiVQ2M8EWGzaiDDu3ZzgebFpuwUDjY8V?=
 =?us-ascii?Q?5Unj4C4qG+EP88XrksRhrdB/la2ToAaOxb5uPfTCNu2fK17/oGo+Zjx6WF9V?=
 =?us-ascii?Q?MPHxZKD8GpNCEVSATJS7r/8grSydZLN98VGIQVJqCPwGW0tTn1TAMg+2nY8B?=
 =?us-ascii?Q?+0pRinYSfHpfnOA2saCKmGIF3qoDE+ZV8453Uy8mzWfGZIg+/1ky7Hi69j7y?=
 =?us-ascii?Q?aGTSHsKAL0Uz3mTWwgHUO1pWcHqUtdOji5fvPocNcTpE2qqmJhYj+WMl67/z?=
 =?us-ascii?Q?TNZCblDIOhEmHvJCaIU+lL0yL/uJwb5tbIUeHsgTNcm97SYqT0ViEEOFjvNz?=
 =?us-ascii?Q?bBDarresTwIPXbCUtlq9GKw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 074684ac-65f9-4682-a292-08d9b9952734
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2021 15:20:51.0231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1SwEoTRC5tJMUwCG/zcCl1YEwujIaZvEHwcqbZcIMDSxhDiSaMRX4vDH26fi4Faovmy07haa2pOIBQidzo+veQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039

On 03.12.2021 14:34, Andrew Cooper wrote:
> Hello,
>=20
> Following the __ro_after_init work, I tried to complete a few pieces of
> cleanup that I'd accrued, and everything has unravelled.
>=20
> On x86, the __2M_* symbols haven't really been 2M aligned since their
> introduction, and the utter mess that was _stext starting at 1M has long
> since been cleared up.=C2=A0 Dropping the 2M prefix reveals that we have =
both
> __init_{start,begin} and identifying that lead to discovering that
>=20
> =C2=A0=C2=A0=C2=A0 /* Destroy Xen's mappings, and reuse the pages. */
> =C2=A0=C2=A0=C2=A0 if ( using_2M_mapping() )
> =C2=A0=C2=A0=C2=A0 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start =3D (unsigned long)&__2M=
_init_start,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 end=C2=A0=C2=A0 =3D (unsigned =
long)&__2M_init_end;
> =C2=A0=C2=A0=C2=A0 }
> =C2=A0=C2=A0=C2=A0 else
> =C2=A0=C2=A0=C2=A0 {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start =3D (unsigned long)&__in=
it_begin;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 end=C2=A0=C2=A0 =3D (unsigned =
long)&__init_end;
> =C2=A0=C2=A0=C2=A0 }
>=20
> is a tautology that nothing is capable of optimising.

Interesting. I would assume it wasn't always that way, but clearly it
is now.

> So I set about trying to simply both x86 and ARM down to a single sets
> of bounding variables, with a requirement that these would be expected
> to be common across all architectures.
>=20
> I'm intending to use __$FOO_{start,end} because we're semi-consistent on
> this already, and get rid of the ones such as _{s,e}$FOO because they're
> unnecessarily obscure, and complicated to read for a compound foo.
>=20
> At this point (as I haven't really started yet), I could be persuaded on
> a different naming scheme if anyone has any strong views.

Imo that scheme is fine. _{s,e}$FOO have always seemed risky in terms
of name clashes / confusion to me, but I've assumed we use them for
being pretty standard and hence recognized by certain tools.

> But that's only the start of the fun.=C2=A0 The is_kernel() predicate is
> broken (or at least problematic) because it covers the init section.=C2=
=A0

I'd say problematic. We may want to have is_active_kernel()
paralleling other is_active_...(); whether a need for is_kernel()
would then remain is to be seen.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 15:42:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 15:42:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241269.418168 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucbS-0006Vv-TE; Tue, 07 Dec 2021 15:42:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241269.418168; Tue, 07 Dec 2021 15:42:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucbS-0006Vo-Q5; Tue, 07 Dec 2021 15:42:02 +0000
Received: by outflank-mailman (input) for mailman id 241269;
 Tue, 07 Dec 2021 15:41:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SK2l=QY=darkstar.site=sakib@srs-se1.protection.inumbo.net>)
 id 1mucai-0006TE-H2
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 15:41:16 +0000
Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 19bd6cfe-5774-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 16:41:12 +0100 (CET)
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id 7E00315323E;
 Tue,  7 Dec 2021 10:41:09 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id 75A7115323D;
 Tue,  7 Dec 2021 10:41:09 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from [192.168.1.116] (unknown [95.67.114.216])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 4AD8A15323C;
 Tue,  7 Dec 2021 10:41:04 -0500 (EST)
 (envelope-from sakib@darkstar.site)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 19bd6cfe-5774-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id
	:date:mime-version:subject:to:cc:references:from:in-reply-to
	:content-type:content-transfer-encoding; s=sasl; bh=MxLjfws1ExEH
	78uYyFOY8YaFqMYfqmITg0X8flIRbLg=; b=rJttXkLvMGFHzhQr5zERoBXy8k5Z
	e3lYCRycIcRA+pIIEYZjW+rbko1FnMToQl2gaBS/arwfqo35Ir66VigdSd77w3A4
	DARp9Ri2t/ru+RuAvEhnA2Vf9JW+z7hKjfY5ZmKEFH/kQOfI60229LgEIRkYxCqq
	+wDjNrs3x1bnnIQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=darkstar.site;
 h=message-id:date:mime-version:subject:to:cc:references:from:in-reply-to:content-type:content-transfer-encoding; s=2016-12.pbsmtp; bh=3w6QSsy0gHdUt/Pm7k9Truu3K0q6CMLJoQxhfuDDjSs=; b=XbuD/q+S6Lr477eDRIkMXZiBSw3AuIIh/RO197tvrY6sEU9+yN4iMuGInJJ8WW3fn9d5DxD/bllZMC/3k4oLERqJBMIkwaxqz2r7jS9R2dmuT4QvC8iIXKSqhyOHMtD58mI7aQNBwhvQlmZ+yDaME57fdSZ/8KrI/wJN/1RK9zE=
Message-ID: <c789cc71-db2d-0735-f007-e93bd23a81a5@darkstar.site>
Date: Tue, 7 Dec 2021 17:40:59 +0200
MIME-Version: 1.0
Subject: Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected devices
Content-Language: en-CA
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Cc: Roman Skakun <rm.skakun@gmail.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Andrii Anisov <andrii_anisov@epam.com>,
 Sergiy Kibrik <sergiy_kibrik@epam.com>
References: <cover.1633106362.git.roman_skakun@epam.com>
 <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com>
 <17547d29-8e15-96f6-2418-5f7ca1c3237d@xen.org>
 <alpine.DEB.2.22.394.2111101306180.440530@ubuntu-linux-20-04-desktop>
From: Sergiy Kibrik <sakib@darkstar.site>
In-Reply-To: <alpine.DEB.2.22.394.2111101306180.440530@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-Pobox-Relay-ID:
 16FBA1BA-5774-11EC-BC76-98D80D944F46-90055647!pb-smtp21.pobox.com
Content-Transfer-Encoding: quoted-printable

hi Stefano, Julien,

On 11/10/21 11:12 =D0=BF=D0=BF, Stefano Stabellini wrote:
> On Mon, 8 Nov 2021, Julien Grall wrote:
[..]
>> A few years ago, I attempted to disable the swiotlb when Xen configure=
d the
>> IOMMU for the device (see [1]). Did you have a chance to go through th=
e
>> thread? In particular, I think Ian Campbell suggestion about creating =
an IOMMU
>> binding is quite interesting.
>>
>> Stefano, what do you think?
>=20
> Yes I think it is a good idea. In fact, thinking more about it, it is
> really the best option. Regardless of the implementation (swiotlb or
> whatever) the device tree description is likely to look similar to the
> description of an IOMMU because it is the common pattern shared by all
> controllers (reset, power, clocks, etc.) so it makes sense to re-use it=
.
>=20
> - there is one controller node (the "IOMMU")
> - there is one property under each device node that is protected,
>    pointing to the controller with a phandle and optional parameters (i=
n
>    the case of IOMMUs it is called "iommus")
>=20

Code in arch_setup_dma_ops() always forces swiotlb for dom0 regardless=20
of any prior IOMMU configuration for the device. So if we are to re-use=20
IOMMU bindings and implement kind of dummy iommu (that merely does=20
direct allocation and mapping) we'll have to check whether device is=20
protected anyway, e.g.:

   diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
   index 49f566ad9acb..6ddef3233095 100644
   --- a/arch/arm/xen/enlighten.c
   +++ b/arch/arm/xen/enlighten.c
   @@ -425,6 +425,10 @@ static int __init xen_pm_init(void)
    }
    late_initcall(xen_pm_init);

   +bool xen_is_device_protected(struct device *dev) {
   +	return dev->dma_ops =3D=3D &dummy_xen_iommu_ops;
   +}

    /* empty stubs */
    void xen_arch_pre_suspend(void) { }


Have I got it right?

  - Sergiy


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 15:50:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 15:50:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241275.418179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucjL-0000Bl-Mc; Tue, 07 Dec 2021 15:50:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241275.418179; Tue, 07 Dec 2021 15:50:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mucjL-0000Be-JU; Tue, 07 Dec 2021 15:50:11 +0000
Received: by outflank-mailman (input) for mailman id 241275;
 Tue, 07 Dec 2021 15:50:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7Lsp=QY=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1mucjK-0000BW-GJ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 15:50:10 +0000
Received: from smtpout2.mo529.mail-out.ovh.net
 (smtpout2.mo529.mail-out.ovh.net [79.137.123.220])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5a69ecd0-5775-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 16:50:08 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.108.4.36])
 by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 876D2D06810E;
 Tue,  7 Dec 2021 16:50:06 +0100 (CET)
Received: from kaod.org (37.59.142.96) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec
 2021 16:50:04 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a69ecd0-5775-11ec-a831-37629979565c
Authentication-Results: garm.ovh; auth=pass (GARM-96R0016d463d06-8f28-4116-8296-36026f977615,
                    D5B34436B48CBBE29FDE786D5871FA4E32D79878) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 86.201.172.254
Message-ID: <27f22e0e-8f84-a6d7-704b-d9eddc642d74@kaod.org>
Date: Tue, 7 Dec 2021 16:50:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never
 worked
Content-Language: en-US
To: Michael Ellerman <mpe@ellerman.id.au>, Thomas Gleixner
	<tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
	<ashok.raj@intel.com>, <linux-pci@vger.kernel.org>, Paul Mackerras
	<paulus@samba.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	<linuxppc-dev@lists.ozlabs.org>, Juergen Gross <jgross@suse.com>, Thomas
 Bogendoerfer <tsbogend@alpha.franken.de>, <linux-mips@vger.kernel.org>, Kalle
 Valo <kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<sparclinux@vger.kernel.org>, <x86@kernel.org>,
	<xen-devel@lists.xenproject.org>, <ath11k@lists.infradead.org>, Wei Liu
	<wei.liu@kernel.org>, <linux-hyperv@vger.kernel.org>, Christian Borntraeger
	<borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.872249537@linutronix.de>
 <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
 <87ilw0odel.fsf@mpe.ellerman.id.au>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <87ilw0odel.fsf@mpe.ellerman.id.au>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [37.59.142.96]
X-ClientProxiedBy: DAG9EX1.mxp5.local (172.16.2.81) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: 3ba07c30-c0fb-4b34-adb9-c7c234a94237
X-Ovh-Tracer-Id: 9416182396562148133
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrjeehgdekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeeigedvffekgeeftedutddttdevudeihfegudffkeeitdekkeetkefhffelveelleenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohephhgtrgeslhhinhhugidrihgsmhdrtghomh

On 12/7/21 12:36, Michael Ellerman wrote:
> Cédric Le Goater <clg@kaod.org> writes:
>> Hello Thomas,
>>
>> On 12/6/21 23:27, Thomas Gleixner wrote:
>>> This code is broken since day one. ppc4xx_setup_msi_irqs() has the
>>> following gems:
>>>
>>>    1) The handling of the result of msi_bitmap_alloc_hwirqs() is completely
>>>       broken:
>>>       
>>>       When the result is greater than or equal 0 (bitmap allocation
>>>       successful) then the loop terminates and the function returns 0
>>>       (success) despite not having installed an interrupt.
>>>
>>>       When the result is less than 0 (bitmap allocation fails), it prints an
>>>       error message and continues to "work" with that error code which would
>>>       eventually end up in the MSI message data.
>>>
>>>    2) On every invocation the file global pp4xx_msi::msi_virqs bitmap is
>>>       allocated thereby leaking the previous one.
>>>
>>> IOW, this has never worked and for more than 10 years nobody cared. Remove
>>> the gunk.
>>>
>>> Fixes: 3fb7933850fa ("powerpc/4xx: Adding PCIe MSI support")
>>
>> Shouldn't we remove all of it ? including the updates in the device trees
>> and the Kconfig changes under :
>>
>> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
>> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
>> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
>> arch/powerpc/platforms/44x/Kconfig:	select PPC4xx_MSI
>> arch/powerpc/platforms/40x/Kconfig:	select PPC4xx_MSI
> 
> This patch should drop those selects I guess. Can you send an
> incremental diff for Thomas to squash in?

Sure.

> Removing all the tendrils in various device tree files will probably
> require some archaeology, and it should be perfectly safe to leave those
> in the tree with the driver gone. So I think we can do that as a
> subsequent patch, rather than in this series.

Here are the changes. Compiled tested with ppc40x and ppc44x defconfigs.

Thanks,

C.

diff --git a/arch/powerpc/boot/dts/bluestone.dts b/arch/powerpc/boot/dts/bluestone.dts
index aa1ae94cd776..6971595319c1 100644
--- a/arch/powerpc/boot/dts/bluestone.dts
+++ b/arch/powerpc/boot/dts/bluestone.dts
@@ -366,30 +366,5 @@ PCIE0: pcie@d00000000 {
  				0x0 0x0 0x0 0x3 &UIC3 0xe 0x4 /* swizzled int C */
  				0x0 0x0 0x0 0x4 &UIC3 0xf 0x4 /* swizzled int D */>;
  		};
-
-		MSI: ppc4xx-msi@C10000000 {
-			compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
-			reg = < 0xC 0x10000000 0x100
-				0xC 0x10000000 0x100>;
-			sdr-base = <0x36C>;
-			msi-data = <0x00004440>;
-			msi-mask = <0x0000ffe0>;
-			interrupts =<0 1 2 3 4 5 6 7>;
-			interrupt-parent = <&MSI>;
-			#interrupt-cells = <1>;
-			#address-cells = <0>;
-			#size-cells = <0>;
-			msi-available-ranges = <0x0 0x100>;
-			interrupt-map = <
-				0 &UIC3 0x18 1
-				1 &UIC3 0x19 1
-				2 &UIC3 0x1A 1
-				3 &UIC3 0x1B 1
-				4 &UIC3 0x1C 1
-				5 &UIC3 0x1D 1
-				6 &UIC3 0x1E 1
-				7 &UIC3 0x1F 1
-			>;
-		};
  	};
  };
diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts
index c5fbb08e0a6e..5db1bff6b23d 100644
--- a/arch/powerpc/boot/dts/canyonlands.dts
+++ b/arch/powerpc/boot/dts/canyonlands.dts
@@ -544,23 +544,5 @@ PCIE1: pcie@d20000000 {
  				0x0 0x0 0x0 0x3 &UIC3 0x12 0x4 /* swizzled int C */
  				0x0 0x0 0x0 0x4 &UIC3 0x13 0x4 /* swizzled int D */>;
  		};
-
-		MSI: ppc4xx-msi@C10000000 {
-			compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
-			reg = < 0xC 0x10000000 0x100>;
-			sdr-base = <0x36C>;
-			msi-data = <0x00000000>;
-			msi-mask = <0x44440000>;
-			interrupt-count = <3>;
-			interrupts = <0 1 2 3>;
-			interrupt-parent = <&UIC3>;
-			#interrupt-cells = <1>;
-			#address-cells = <0>;
-			#size-cells = <0>;
-			interrupt-map = <0 &UIC3 0x18 1
-					1 &UIC3 0x19 1
-					2 &UIC3 0x1A 1
-					3 &UIC3 0x1B 1>;
-		};
  	};
  };
diff --git a/arch/powerpc/boot/dts/katmai.dts b/arch/powerpc/boot/dts/katmai.dts
index a8f353229fb7..4262b2bbd6de 100644
--- a/arch/powerpc/boot/dts/katmai.dts
+++ b/arch/powerpc/boot/dts/katmai.dts
@@ -442,24 +442,6 @@ PCIE2: pcie@d40000000 {
  				0x0 0x0 0x0 0x4 &UIC3 0xb 0x4 /* swizzled int D */>;
  		};
  
-		MSI: ppc4xx-msi@400300000 {
-				compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
-				reg = < 0x4 0x00300000 0x100>;
-				sdr-base = <0x3B0>;
-				msi-data = <0x00000000>;
-				msi-mask = <0x44440000>;
-				interrupt-count = <3>;
-				interrupts =<0 1 2 3>;
-				interrupt-parent = <&UIC0>;
-				#interrupt-cells = <1>;
-				#address-cells = <0>;
-				#size-cells = <0>;
-				interrupt-map = <0 &UIC0 0xC 1
-					1 &UIC0 0x0D 1
-					2 &UIC0 0x0E 1
-					3 &UIC0 0x0F 1>;
-		};
-
  		I2O: i2o@400100000 {
  			compatible = "ibm,i2o-440spe";
  			reg = <0x00000004 0x00100000 0x100>;
diff --git a/arch/powerpc/boot/dts/kilauea.dts b/arch/powerpc/boot/dts/kilauea.dts
index a709fb47a180..c07a7525a72c 100644
--- a/arch/powerpc/boot/dts/kilauea.dts
+++ b/arch/powerpc/boot/dts/kilauea.dts
@@ -403,33 +403,5 @@ PCIE1: pcie@c0000000 {
  				0x0 0x0 0x0 0x3 &UIC2 0xd 0x4 /* swizzled int C */
  				0x0 0x0 0x0 0x4 &UIC2 0xe 0x4 /* swizzled int D */>;
  		};
-
-		MSI: ppc4xx-msi@C10000000 {
-			compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
-			reg = <0xEF620000 0x100>;
-			sdr-base = <0x4B0>;
-			msi-data = <0x00000000>;
-			msi-mask = <0x44440000>;
-			interrupt-count = <12>;
-			interrupts = <0 1 2 3 4 5 6 7 8 9 0xA 0xB 0xC 0xD>;
-			interrupt-parent = <&UIC2>;
-			#interrupt-cells = <1>;
-			#address-cells = <0>;
-			#size-cells = <0>;
-			interrupt-map = <0 &UIC2 0x10 1
-					1 &UIC2 0x11 1
-					2 &UIC2 0x12 1
-					2 &UIC2 0x13 1
-					2 &UIC2 0x14 1
-					2 &UIC2 0x15 1
-					2 &UIC2 0x16 1
-					2 &UIC2 0x17 1
-					2 &UIC2 0x18 1
-					2 &UIC2 0x19 1
-					2 &UIC2 0x1A 1
-					2 &UIC2 0x1B 1
-					2 &UIC2 0x1C 1
-					3 &UIC2 0x1D 1>;
-		};
  	};
  };
diff --git a/arch/powerpc/boot/dts/redwood.dts b/arch/powerpc/boot/dts/redwood.dts
index f38035a1f4a1..3c849e23e5f3 100644
--- a/arch/powerpc/boot/dts/redwood.dts
+++ b/arch/powerpc/boot/dts/redwood.dts
@@ -358,25 +358,6 @@ PCIE2: pcie@d40000000 {
  				0x0 0x0 0x0 0x4 &UIC3 0xb 0x4 /* swizzled int D */>;
  		};
  
-		MSI: ppc4xx-msi@400300000 {
-				compatible = "amcc,ppc4xx-msi", "ppc4xx-msi";
-				reg = < 0x4 0x00300000 0x100
-					0x4 0x00300000 0x100>;
-				sdr-base = <0x3B0>;
-				msi-data = <0x00000000>;
-				msi-mask = <0x44440000>;
-				interrupt-count = <3>;
-				interrupts =<0 1 2 3>;
-				interrupt-parent = <&UIC0>;
-				#interrupt-cells = <1>;
-				#address-cells = <0>;
-				#size-cells = <0>;
-				interrupt-map = <0 &UIC0 0xC 1
-					1 &UIC0 0x0D 1
-					2 &UIC0 0x0E 1
-					3 &UIC0 0x0F 1>;
-		};
-
  	};
  
  
diff --git a/arch/powerpc/platforms/40x/Kconfig b/arch/powerpc/platforms/40x/Kconfig
index e3e5217c9822..614ea6dc994c 100644
--- a/arch/powerpc/platforms/40x/Kconfig
+++ b/arch/powerpc/platforms/40x/Kconfig
@@ -23,7 +23,6 @@ config KILAUEA
  	select PPC4xx_PCI_EXPRESS
  	select FORCE_PCI
  	select PCI_MSI
-	select PPC4xx_MSI
  	help
  	  This option enables support for the AMCC PPC405EX evaluation board.
  
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 83975ef50975..25b80cd558f8 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -23,7 +23,6 @@ config BLUESTONE
  	select APM821xx
  	select FORCE_PCI
  	select PCI_MSI
-	select PPC4xx_MSI
  	select PPC4xx_PCI_EXPRESS
  	select IBM_EMAC_RGMII if IBM_EMAC
  	help
@@ -73,7 +72,6 @@ config KATMAI
  	select FORCE_PCI
  	select PPC4xx_PCI_EXPRESS
  	select PCI_MSI
-	select PPC4xx_MSI
  	help
  	  This option enables support for the AMCC PPC440SPe evaluation board.
  
@@ -115,7 +113,6 @@ config CANYONLANDS
  	select FORCE_PCI
  	select PPC4xx_PCI_EXPRESS
  	select PCI_MSI
-	select PPC4xx_MSI
  	select IBM_EMAC_RGMII if IBM_EMAC
  	select IBM_EMAC_ZMII if IBM_EMAC
  	help
@@ -141,7 +138,6 @@ config REDWOOD
  	select FORCE_PCI
  	select PPC4xx_PCI_EXPRESS
  	select PCI_MSI
-	select PPC4xx_MSI
  	help
  	  This option enables support for the AMCC PPC460SX Redwood board.
  
-- 
2.31.1




From xen-devel-bounces@lists.xenproject.org Tue Dec 07 17:29:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 17:29:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241733.418190 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mueHQ-0005eH-32; Tue, 07 Dec 2021 17:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241733.418190; Tue, 07 Dec 2021 17:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mueHP-0005eA-Ve; Tue, 07 Dec 2021 17:29:27 +0000
Received: by outflank-mailman (input) for mailman id 241733;
 Tue, 07 Dec 2021 17:29:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mueHO-0005e0-N9; Tue, 07 Dec 2021 17:29:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mueHO-0007Qz-FF; Tue, 07 Dec 2021 17:29:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mueHN-0007jo-TQ; Tue, 07 Dec 2021 17:29:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mueHN-0003PY-Rp; Tue, 07 Dec 2021 17:29:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7Czz6nR4PVp4QsuQN/bN/s8JBhZZF6BDbYIGM6nTE/Y=; b=619K5RwrlOJAchXn5FXnSv4CXt
	lLk4J51zHgSPk55lRUgafKTWaDFQb4msJSfJB9ASx240B8mFhK1K5YekFCxZI1U/aAZvkJp+/C1Eo
	972lH7qJkMAtQFCp68sGSiVVVnZvjngxtUjicWOXAIWVDPSlG8ZWg5mXcMKSSy4sm2Rg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167217-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 167217: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c623a84c2a4fda1cd25f5347a6298706218eb5fb
X-Osstest-Versions-That:
    xen=544e547a63175ac6ef7cc29c4f5bda88da024f69
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 17:29:25 +0000

flight 167217 xen-4.15-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167217/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 166387

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166387
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166387
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166387
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166387
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166387
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166387
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166387
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166387
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166387
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166387
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166387
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166387
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  c623a84c2a4fda1cd25f5347a6298706218eb5fb
baseline version:
 xen                  544e547a63175ac6ef7cc29c4f5bda88da024f69

Last test of basis   166387  2021-11-25 09:29:26 Z   12 days
Testing same since   167217  2021-12-06 15:36:51 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <ian.jackson@eu.citrix.com>
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   544e547a63..c623a84c2a  c623a84c2a4fda1cd25f5347a6298706218eb5fb -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 17:42:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 17:42:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241742.418208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mueU1-0008NQ-Eo; Tue, 07 Dec 2021 17:42:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241742.418208; Tue, 07 Dec 2021 17:42:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mueU1-0008NJ-Bg; Tue, 07 Dec 2021 17:42:29 +0000
Received: by outflank-mailman (input) for mailman id 241742;
 Tue, 07 Dec 2021 17:42:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=7Lsp=QY=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1mueU0-0008ND-JG
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 17:42:28 +0000
Received: from smtpout1.mo529.mail-out.ovh.net
 (smtpout1.mo529.mail-out.ovh.net [178.32.125.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0aae1efa-5785-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 18:42:26 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.108.16.17])
 by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 4DC6CD06F169;
 Tue,  7 Dec 2021 18:42:25 +0100 (CET)
Received: from kaod.org (37.59.142.102) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 7 Dec
 2021 18:42:23 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0aae1efa-5785-11ec-a831-37629979565c
Authentication-Results: garm.ovh; auth=pass (GARM-102R0045e25c049-ab10-4875-94b1-6aac2f02c5c1,
                    EDCC1E77E28A65BD51DFCD2B92BF934EEA10E5FB) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 86.201.172.254
Message-ID: <e32237f3-0ff2-cf80-cd99-0b4813d1ed21@kaod.org>
Date: Tue, 7 Dec 2021 18:42:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V2 29/36] PCI/MSI: Simplify pci_irq_get_affinity()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, LKML <linux-kernel@vger.kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
	<ashok.raj@intel.com>, <linux-pci@vger.kernel.org>,
	<xen-devel@lists.xenproject.org>, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>, <iommu@lists.linux-foundation.org>,
	<dmaengine@vger.kernel.org>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
	<kristo@kernel.org>, <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
	<robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
References: <20211206210307.625116253@linutronix.de>
 <20211206210439.235197701@linutronix.de>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <20211206210439.235197701@linutronix.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [37.59.142.102]
X-ClientProxiedBy: DAG5EX1.mxp5.local (172.16.2.41) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: 9a201c60-92f7-40d1-8e65-204b0cf1b1c0
X-Ovh-Tracer-Id: 11313323742435773410
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrjeehgddutdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhephffhleegueektdetffdvffeuieeugfekkeelheelteeftdfgtefffeehueegleehnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutddvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepohhkrgihrgeskhgvrhhnvghlrdhorhhg

Thomas,

On 12/6/21 23:39, Thomas Gleixner wrote:
> Replace open coded MSI descriptor chasing and use the proper accessor
> functions instead.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>   drivers/pci/msi/msi.c |   26 ++++++++++----------------
>   1 file changed, 10 insertions(+), 16 deletions(-)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -1056,26 +1056,20 @@ EXPORT_SYMBOL(pci_irq_vector);
>    */
>   const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>   {
> -	if (dev->msix_enabled) {
> -		struct msi_desc *entry;
> +	int irq = pci_irq_vector(dev, nr);
> +	struct msi_desc *desc;
>   
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->msi_index == nr)
> -				return &entry->affinity->mask;
> -		}
> -		WARN_ON_ONCE(1);
> +	if (WARN_ON_ONCE(irq <= 0))
>   		return NULL;
> -	} else if (dev->msi_enabled) {
> -		struct msi_desc *entry = first_pci_msi_entry(dev);
>   
> -		if (WARN_ON_ONCE(!entry || !entry->affinity ||
> -				 nr >= entry->nvec_used))
> -			return NULL;
> -
> -		return &entry->affinity[nr].mask;
> -	} else {
> +	desc = irq_get_msi_desc(irq);
> +	/* Non-MSI does not have the information handy */
> +	if (!desc)
>   		return cpu_possible_mask;
> -	}
> +
> +	if (WARN_ON_ONCE(!desc->affinity))
> +		return NULL;
> +	return &desc->affinity[nr].mask;
>   }
>   EXPORT_SYMBOL(pci_irq_get_affinity);

This is breaking nvme on pseries but it's probably one of the previous
patches. I haven't figured out what's wrong yet. Here is the oops FYI.

Thanks,

C.

[   32.494536] ------------[ cut here ]------------
[   32.494562] WARNING: CPU: 26 PID: 658 at kernel/irq/chip.c:210 irq_startup+0x1c0/0x1e0
[   32.494575] Modules linked in: ibmvscsi ibmveth scsi_transport_srp bnx2x ipr libata xhci_pci xhci_hcd nvme xts vmx_crypto nvme_core mdio t10_pi libcrc32c dm_mirror dm_region_hash dm_log dm_mod
[   32.494601] CPU: 26 PID: 658 Comm: kworker/26:1H Not tainted 5.16.0-rc4-clg+ #54
[   32.494607] Workqueue: kblockd blk_mq_timeout_work
[   32.494615] NIP:  c000000000206f00 LR: c000000000206df0 CTR: c000000000201570
[   32.494619] REGS: c0000018050f3610 TRAP: 0700   Not tainted  (5.16.0-rc4-clg+)
[   32.494624] MSR:  800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>  CR: 44002288  XER: 00000000
[   32.494636] CFAR: c000000000206e0c IRQMASK: 1
[   32.494636] GPR00: c000000000206df0 c0000018050f38b0 c000000001ca2900 0000000000000800
[   32.494636] GPR04: c000000001ce21b8 0000000000000800 0000000000000800 0000000000000000
[   32.494636] GPR08: 0000000000000000 0000000000000200 0000000000000000 fffffffffffffffd
[   32.494636] GPR12: 0000000000000000 c000001fff7c5880 c00000000018f488 c00000012faaba40
[   32.494636] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000001
[   32.494636] GPR20: 0000000000000000 c0000018050f3c40 c00000000076e110 c00000013ac23678
[   32.494636] GPR24: 000000000000007f 0000000000000100 0000000000000001 c000001805b08000
[   32.494636] GPR28: c000000139b8cc18 0000000000000001 0000000000000001 c000000139b8cc00
[   32.494681] NIP [c000000000206f00] irq_startup+0x1c0/0x1e0
[   32.494686] LR [c000000000206df0] irq_startup+0xb0/0x1e0
[   32.494690] Call Trace:
[   32.494692] [c0000018050f38b0] [c000000000206df0] irq_startup+0xb0/0x1e0 (unreliable)
[   32.494699] [c0000018050f38f0] [c00000000020155c] __enable_irq+0x9c/0xb0
[   32.494705] [c0000018050f3950] [c0000000002015d0] enable_irq+0x60/0xc0
[   32.494710] [c0000018050f39d0] [c008000014a54ae8] nvme_poll_irqdisable+0x80/0xc0 [nvme]
[   32.494719] [c0000018050f3a00] [c008000014a55824] nvme_timeout+0x18c/0x420 [nvme]
[   32.494726] [c0000018050f3ae0] [c00000000076e1b8] blk_mq_check_expired+0xa8/0x130
[   32.494732] [c0000018050f3b10] [c0000000007793e8] bt_iter+0xd8/0x120
[   32.494737] [c0000018050f3b60] [c00000000077a34c] blk_mq_queue_tag_busy_iter+0x25c/0x3f0
[   32.494742] [c0000018050f3c20] [c00000000076ffa4] blk_mq_timeout_work+0x84/0x1a0
[   32.494747] [c0000018050f3c70] [c000000000182a78] process_one_work+0x2a8/0x5a0
[   32.494754] [c0000018050f3d10] [c000000000183468] worker_thread+0xa8/0x610
[   32.494759] [c0000018050f3da0] [c00000000018f634] kthread+0x1b4/0x1c0
[   32.494764] [c0000018050f3e10] [c00000000000cd64] ret_from_kernel_thread+0x5c/0x64
[   32.494769] Instruction dump:
[   32.494773] 60000000 0b030000 38a00000 7f84e378 7fc3f378 4bff9a55 60000000 7fe3fb78
[   32.494781] 4bfffd79 eb810020 7c7e1b78 4bfffe94 <0fe00000> 60000000 60000000 60420000
[   32.494788] ---[ end trace 2a27b87f2b3e7a1f ]---
[   32.494798] nvme nvme0: I/O 192 QID 128 timeout, aborting
[   32.584562] nvme nvme0: Abort status: 0x0
[   62.574526] nvme nvme0: I/O 200 QID 128 timeout, aborting
[   62.574587]  nvme0n1: p1



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 18:59:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 18:59:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241751.418219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mufgG-0001MT-2g; Tue, 07 Dec 2021 18:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241751.418219; Tue, 07 Dec 2021 18:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mufgF-0001MM-Vj; Tue, 07 Dec 2021 18:59:11 +0000
Received: by outflank-mailman (input) for mailman id 241751;
 Tue, 07 Dec 2021 18:59:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mufgF-0001MG-DP
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 18:59:11 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mufgF-0000Vy-2q; Tue, 07 Dec 2021 18:59:11 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mufgE-0007Tv-Sn; Tue, 07 Dec 2021 18:59:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Xnvh+R2aJPzyAtuVCtDfW91EHL4slRZJfk16rHxbuc8=; b=Zr+krmsuQT1SDofqidYd5KEWyV
	NcpnYuOAyABKu5s7iFSE+VY0h/EqpQgFmU5gX5LVd81syamp6s+ErT/1KWW6G24SEoFbKoeuA5m8+
	1jx6aadGyBMJ2b/Wg2EepQfQb7876v449Pq+XnVrMdt8pHZf7Sk1PdMzX58Ts7uj4foQ=;
Message-ID: <f16dab0a-e119-f464-d5de-38bc0d31ff62@xen.org>
Date: Tue, 7 Dec 2021 18:59:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Do not include in the image functions...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206141923.26757-1-michal.orzel@arm.com>
 <61a730e2-fe20-ae74-bf47-a283c5efc717@xen.org>
 <e149b283-23bd-9d8f-4be4-4a26722f0ed6@arm.com>
 <65035935-935a-f8a9-a797-5d6a1bce4e66@xen.org>
 <abd3beeb-eccb-8c6e-0751-b881efc08d57@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <abd3beeb-eccb-8c6e-0751-b881efc08d57@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 07/12/2021 07:10, Michal Orzel wrote:
> On 06.12.2021 17:40, Julien Grall wrote:
>>
>>
>> On 06/12/2021 15:00, Michal Orzel wrote:
>>> Hi Julien,
>>
>> Hi Michal,
>>
>>> On 06.12.2021 15:39, Julien Grall wrote:
>>>> Hi Michal,
>>>>
>>>> On 06/12/2021 14:19, Michal Orzel wrote:
>>>>> vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
>>>>> CONFIG_NEW_VGIC is not set.
>>>>>
>>>>> enter_hypervisor_from_guest is protecting calls to these functions
>>>>> with CONFIG_NEW_VGIC but their definitions and declarations are not > protected. This means that we are including them in the image even
>>>>> though we are not making use of them. Fix that.
>>>>
>>>> While I agree, they are only used by the new vGIC, the implementation of the functions are not. So I don't think they should be protected by CONFIG_NEW_VGIC.
>>>>
>>>> Actually, I am not convinced they should be protected. But I guess you did that for a reason. Would you be able to clarify what is your reason?
>>>>
>>>   From what I know + what the commit introducing these fucntions states (b9db96f71a74), the current vGIC does not handle level-triggered vIRQs.
>>> The functionality of these functions is only related to new VGIC implementation which can handle level triggered vIRQs.
>>
>> This is a known error in the vGIC implementation which should be resolved before this leads to a disaster.
> 
> I just thought that if this error is present for such a long time, there are no plans to make current vgic handle level type irqs.

The error has been present for such a long time because no-one yet 
volunteered to properly fix it. That said, the new vGIC has been an 
attempt to resolve it but the effort kind of died.

It would be nice to revive the effort.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 19:11:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 19:11:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241759.418230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mufsB-0003yJ-4e; Tue, 07 Dec 2021 19:11:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241759.418230; Tue, 07 Dec 2021 19:11:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mufsB-0003yC-1Y; Tue, 07 Dec 2021 19:11:31 +0000
Received: by outflank-mailman (input) for mailman id 241759;
 Tue, 07 Dec 2021 19:11:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mufs9-0003y6-F3
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 19:11:29 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mufs8-0000jn-Ud; Tue, 07 Dec 2021 19:11:28 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mufs8-00007D-Oe; Tue, 07 Dec 2021 19:11:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zHH6DV0eYjfkSBT3G08YnAeelsLQglgCnFPA2flglPc=; b=H1VYOvARb0UVmpc/Y0KxSkG7dI
	J5pXw3wCRX6cq/+LskDI1z6NiC4WcPQGtYq/n4lyE3Ji8hkW2SJAd2CXiUZjH3zKdzJvKA46TkHzV
	vvx54QrE3uJUI9shhz2Tfl99nSB5GKwz3ZuB8MLYB4uXP7iRYJmmCFMKdx68iLKPkeCM=;
Message-ID: <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
Date: Tue, 7 Dec 2021 19:11:26 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 07/12/2021 08:37, Michal Orzel wrote:
> Hi Julien,

Hi,

> On 06.12.2021 16:29, Julien Grall wrote:
>> Hi,
>>
>> On 06/12/2021 14:20, Michal Orzel wrote:
>>> to hypervisor when switching to AArch32 state.
>>>
> I will change to "from AArch32 state".
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>
>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>
> Ok.
>>>
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed.
>>
>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>
> I would say:
> "
> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
> if the command passed as the first argument was clobbered,
> "
>>>
>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>> entry to hypervisor when switching to AArch32 state.
>>>
>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>> when not passed.
>>
>> Which error do you see otherwise? Is it a compilation error?
>>
> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
> So basically in all the places where entry is called with hyp=1.
> When taking the current patch and removing default value for compat you will get:
> ```
> entry.S:254: Error: ".endif" without ".if"
> entry.S:258: Error: symbol `.if' is already defined
> entry.S:258: Error: ".endif" without ".if"
> entry.S:262: Error: symbol `.if' is already defined
> entry.S:262: Error: ".endif" without ".if"
> entry.S:266: Error: symbol `.if' is already defined
> entry.S:266: Error: ".endif" without ".if"
> entry.S:278: Error: symbol `.if' is already defined
> entry.S:278: Error: ".endif" without ".if"
> entry.S:292: Error: symbol `.if' is already defined
> entry.S:292: Error: ".endif" without ".if"
> entry.S:317: Error: symbol `.if' is already defined
> entry.S:317: Error: ".endif" without ".if"
> ```

Thanks for input. I am concerned with your suggested approach (or using 
.if 0\compat as suggested by Jan) because they allow the caller to not 
properly specify compat when hyp=0. The risk here is we may generate the 
wrong entry.

compat should need to be specified when hyp=1 as we will always run in 
aarch64 mode. So could we protect this code with hyp=0?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 19:25:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 19:25:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241767.418241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mug5V-0005s5-Cm; Tue, 07 Dec 2021 19:25:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241767.418241; Tue, 07 Dec 2021 19:25:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mug5V-0005ry-91; Tue, 07 Dec 2021 19:25:17 +0000
Received: by outflank-mailman (input) for mailman id 241767;
 Tue, 07 Dec 2021 19:25:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mug5U-0005rs-2Q
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 19:25:16 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mug5P-0000xk-SM; Tue, 07 Dec 2021 19:25:11 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mug5P-0000pK-L1; Tue, 07 Dec 2021 19:25:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wimSA2WoZnpW6l9b4jWoQriO2mDgiXNKfENifs7vuQI=; b=bu3GJ8s+NTVINCFv2xG1lfXdD3
	7ylcnvyTTfbiGV2GDdxAunZNgxqoItMb9W6GQfYH/PBGMRqVxwxCjHAPjFOrYX2YjErMTjeoT6AmF
	fsMjsn2L/0uhqcbqMWFXyj7tcumRuhtbdPdR+Eu9jg1DVQgvxC0vH975+BFMZB46FPc8=;
Message-ID: <ed24bb81-2905-b50a-bc26-326dd5cbc934@xen.org>
Date: Tue, 7 Dec 2021 19:25:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <086feb9a-7d6b-3797-3643-1b4474e4a420@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <086feb9a-7d6b-3797-3643-1b4474e4a420@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jan,

On 07/12/2021 09:55, Jan Beulich wrote:
>>>> --- a/xen/arch/arm/arm64/entry.S
>>>> +++ b/xen/arch/arm/arm64/entry.S
>>>> @@ -109,8 +109,16 @@
>>>>     * If 0, we rely on the on x0/x1 to have been saved at the correct
>>>>     * position on the stack before.
>>>>     */
>>>> -        .macro  entry, hyp, compat, save_x0_x1=1
>>>> +        .macro  entry, hyp, compat=0, save_x0_x1=1
>>>>            sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
>>>> +
>>>> +        /* Zero the upper 32 bits of the registers when switching to AArch32 */
>>>> +        .if \compat == 1      /* AArch32 mode */
>>>> +        .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>>> +        mov w\nr, w\nr
>>>> +        .endr
>>>> +        .endif
>>>
>>> So Jan mentioned, the x0/x1 may have already been saved. So you may need to fetch them from the stack and then clobber the top 32-bit.
>>>
>> So I would do the following:
>> -fetch x0/x1 from the stack
>> -clobber them
>> -store them again on the stack
>>
>> /*
>>   * Zero the upper 32 bits of the gp registers when switching
>>   * from AArch32.
>>   */
>> .if \compat == 1      /* AArch32 mode */
>>
>> /* x0/x1 have already been saved so fetch them to zero top 32 bits */
>> .if \save_x0_x1 == 0
>> ldp     x0, x1, [sp], #(UREGS_kernel_sizeof - UREGS_X0)
>> .endif
>>
>> .irp nr,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>> mov w\nr, w\nr
>> .endr
>>
>> .if \save_x0_x1 == 0
>> stp     x0, x1, [sp, #-(UREGS_kernel_sizeof - UREGS_X0)]
>> .endif
>>
>> .endif
> 
> Wouldn't it be more efficient to store 32 bits of zero each into the
> high halves of the respective stack slots? Afaict same code size, but
> less memory / cache traffic.

It would indeed be more efficient.

> Plus it would avoid the latent issue of
> a user of the macro actually expecting the two registers to retain
> their values across the macro invocation.

While this is not explicitely written, a caller cannot expect the 
registers to be preserved by this macro.

> 
> I'm also puzzled by the two different memory addressing forms, but I
> can easily see that I may be lacking enough Arm knowledge there.

I agree this is quite puzzling. The first one would update 'sp' after 
loading the register but I don't quite understand why it is necessary.

Assuming the this is happening before the instruction 'sub sp, sp, ...', 
then we should only need to load/store from sp with an offset (i.e. the 
second form).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 19:51:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 19:51:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241776.418251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mugUP-0001iR-Cu; Tue, 07 Dec 2021 19:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241776.418251; Tue, 07 Dec 2021 19:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mugUP-0001iK-9t; Tue, 07 Dec 2021 19:51:01 +0000
Received: by outflank-mailman (input) for mailman id 241776;
 Tue, 07 Dec 2021 19:50:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mugUN-0001iE-Eg
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 19:50:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mugUN-0001NF-5s; Tue, 07 Dec 2021 19:50:59 +0000
Received: from [54.239.6.187] (helo=[10.95.81.235])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mugUM-0002Ab-W2; Tue, 07 Dec 2021 19:50:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HwiU/NtMO6SqQ7Zv8a4/t8OkjeeJTzQ5f4trUOxfoWo=; b=zNZORF5ZZXE5rsC4eljr2O7VKh
	06PN1WqLu4nfjGFNhyOE7OWNRWi0ABWEjcwr0UWzbbSZZ0Lg3HBhbhvbSnXjnRBedS7z49xoZirc9
	9w7xeDK7yLP3WlVF/qT+xbzT4JtLSCzI6ymtzrHvJEoA6bF1V7XNvHn9KlOzgkK20ZY4=;
Message-ID: <8f1c0cec-7f0a-35f6-1157-e23b8a058e6d@xen.org>
Date: Tue, 7 Dec 2021 19:50:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number
To: Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Chen <Wei.Chen@arm.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211206153730.49791-1-luca.fancellu@arm.com>
 <f439d5c4-aa6c-4066-3941-e497b67aeae1@xen.org>
 <C96E90F4-611E-4765-9627-EDE75A952E10@arm.com>
 <A6E7CDAA-E4AD-4AC3-8745-216FDC4DD8BF@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <A6E7CDAA-E4AD-4AC3-8745-216FDC4DD8BF@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Bertrand and Luca,

On 07/12/2021 11:09, Bertrand Marquis wrote:
>> On 7 Dec 2021, at 10:52, Luca Fancellu <Luca.Fancellu@arm.com> wrote:
>>
>>
>>
>>> On 6 Dec 2021, at 17:05, Julien Grall <julien@xen.org> wrote:
>>>
>>> Hi Luca,
>>>
>>> On 06/12/2021 15:37, Luca Fancellu wrote:
>>>> Currently the maximum number of memory banks is fixed to
>>>> 128, but on some new platforms that have a large amount
>>>> of memory, this value is not enough
>>>
>>
>> Hi Julien,
>>
>>> Can you provide some information on the setup? Is it using UEFI?
>>
>> Yes it is a platform with 32gb of ram, I’ve built Xen with ACPI support and it’s starting using UEFI+ACPI.
Thanks! That makes more sense now. Although...

>>
>>>
>>>> and prevents Xen
>>>> from booting.
>>>
>>> AFAIK, the restriction should only prevent Xen to use all the memory. If that's not the case, then this should be fixed.
>>
>> The code that it’s failing is this, inside efi_process_memory_map_bootinfo(…) in the arch/arm/efi/efi-boot.h:
>>
>> #ifdef CONFIG_ACPI
>>         else if ( desc_ptr->Type == EfiACPIReclaimMemory )
>>         {
>>             if ( !meminfo_add_bank(&bootinfo.acpi, desc_ptr) )
>>             {
>>                 PrintStr(L"Error: All " __stringify(NR_MEM_BANKS)
>>                           " acpi meminfo mem banks exhausted.\r\n");
>>                 return EFI_LOAD_ERROR;
>>             }
>>         }
>> #endif

... I was expecting bootinfo.mem to be filled rather than bootinfo.acpi:

             if ( !meminfo_add_bank(&bootinfo.mem, desc_ptr) )
             {
                 PrintStr(L"Warning: All " __stringify(NR_MEM_BANKS)
                           " bootinfo mem banks exhausted.\r\n");
                 break;
             }

It is actually quite surprising that you end up with more than 128 
regions here.

>
>>>
>>>> Create a Kconfig parameter to set the value, by default
>>>> 128.
>>>
>>> I think Xen should be able to boot on any platform with the default configuration. So the value should at least be bumped.
>>>
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>>> ---
>>>> xen/arch/arm/Kconfig        | 8 ++++++++
>>>> xen/include/asm-arm/setup.h | 2 +-
>>>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>>>> index ecfa6822e4d3..805e3c417e89 100644
>>>> --- a/xen/arch/arm/Kconfig
>>>> +++ b/xen/arch/arm/Kconfig
>>>> @@ -25,6 +25,14 @@ menu "Architecture Features"
>>>>    source "arch/Kconfig"
>>>> +config MEM_BANKS
>>>> +	int "Maximum number of memory banks."
>>>> +	default "128"
>>>> +	help
>>>> +	  Controls the build-time size memory bank array.
>>>> +	  It is the upper bound of the number of logical entities describing
>>>> +	  the memory.
>>>
>>> NR_MEM_BANKS is going to be used by multiple internal structure in Xen (e.g. static memory, reserved memory, normal memory). So how could an admin decide the correct value?
>>>
>>> In particular for UEFI, we are at the mercy of the firmware that can expose any kind of memory map (that's why we had to increase the original number of banks).
>>>
>>> So maybe it is time for us to move out from a static array and re-think how we discover the memory.
>>>
>>> That this is probably going to take some time to get it properly, so
>>> I would be OK with bumping the value + a config gated UNSUPPORTED.
> 
> 
> Looking at what we have, the memory is actually fragmented by ACPI but a long term solution could be to make the code a little bit more smart and try to merge together adjacent banks.

That could work, but I think we could get rid of bootinfo.acpi completely.

If I am not mistaken, bootinfo.acpi is only used by Xen to figure out 
how to create the EFI memory map for dom0. So this could be replaced 
with a walk of the UEFI memory map.

Looking at the code, we have already some boiler plate for x86 to pass 
the UEFI memory map from the stub to Xen. They would need need to be 
adjusted for Arm to:

    * Enable ebmalloc() (see TODOs in common/efi/ebmalloc.c)
    * Switch efi_arch_allocate_mmap_buffer() to use ebmalloc()
    * Adjust the pointers (see end of the efi_exit_boot()). I think we 
would want to pass the physical and let the actual Xen to translate to a 
virtual address

> 
> I would suggest to just increase the existing define to 256 to fix the current issue (which might be encountered by anybody using ACPI) and put a comment in the code for now with a TODO explaining why we currently need such a high value and what should be done to fix this.

I am fine with simply bumping the value (the actual array doesn't take a 
lot of space and will be freed after boot).

Long term, I think it would be better if we start to reduce the number 
of bootinfo.mem* and removing any hardcoded size.

When using UEFI, we could replace with the UEFI memory map. For non-UEFI 
DT boot, we would still need to create the memory map by hand to avoid 
walking the DT every time.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 19:55:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 19:55:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241786.418274 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mugZ5-0002Yk-5l; Tue, 07 Dec 2021 19:55:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241786.418274; Tue, 07 Dec 2021 19:55:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mugZ5-0002Yd-2X; Tue, 07 Dec 2021 19:55:51 +0000
Received: by outflank-mailman (input) for mailman id 241786;
 Tue, 07 Dec 2021 19:55:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mugZ4-0002YT-AO; Tue, 07 Dec 2021 19:55:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mugZ4-0001Ss-4M; Tue, 07 Dec 2021 19:55:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mugZ3-0008TL-Np; Tue, 07 Dec 2021 19:55:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mugZ3-0002KO-MV; Tue, 07 Dec 2021 19:55:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=iMaLi5ksgRWMzVMjXJUbULF6kRuXUD+izM5wpxa9JWA=; b=U7Gxtn0qsSA1ZlhQJP2AU0e49j
	hJ0fNN0c97rm+jScW5JGBzSLt7uqFTnm+WSEdyJ9k6FjXdOawGjYIKG+uB/MlvZ1m1TOp4jzozw9r
	YarxuvIFuvagm9f3EMgjUfB6O6Im4DsNApcNAR5ucehj3QVVvWqpKiVZvW4iMOiT8V8Q=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167218-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 167218: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=2dcea9c94c59cf2a9c7ee824a573f7c1b864b5d5
X-Osstest-Versions-That:
    xen=b0b4661fa3cba995e433b94ea569c90f65a3e5fc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 07 Dec 2021 19:55:49 +0000

flight 167218 xen-4.16-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167218/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 166959
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 166959
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 166959
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 166959
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 166959
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 166959
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 166959
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 166959
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 166959
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 166959
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 166959
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 166959
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  2dcea9c94c59cf2a9c7ee824a573f7c1b864b5d5
baseline version:
 xen                  b0b4661fa3cba995e433b94ea569c90f65a3e5fc

Last test of basis   166959  2021-11-30 12:06:43 Z    7 days
Testing same since   167218  2021-12-06 16:06:39 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ian Jackson <iwj@xenproject.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   b0b4661fa3..2dcea9c94c  2dcea9c94c59cf2a9c7ee824a573f7c1b864b5d5 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:42:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:42:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241796.418289 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhIF-00012W-Pf; Tue, 07 Dec 2021 20:42:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241796.418289; Tue, 07 Dec 2021 20:42:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhIF-00012P-MR; Tue, 07 Dec 2021 20:42:31 +0000
Received: by outflank-mailman (input) for mailman id 241796;
 Tue, 07 Dec 2021 20:42:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuaW=QY=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muhIE-00012J-E7
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:42:30 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e978664-579e-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:42:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e978664-579e-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638909743;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8kdDUloupcZ7zsHm8ipSzMG1KhDz+bCCecRfNXSnpkg=;
	b=myOlC5dgE3khI7L8VZJuvb0AqNwW72GyeFELcD1PBbXUtZ68+3HHkLJ6B3AHqyMzsf2WT8
	+ujqWMGHpaY4rsmjld2a82Vj5AIv9LECzrGlZmnD/32El3mdYogpJBXD830FzxpM64lfFA
	4umcD+gxjhc1TVxDz7X7+HSKF/BzRb/G2QPcgdTOuekTL5TVuB7tk2FDJgZvBY12rIApXt
	6/cKg45LVQbCHkJ50Jh/VwMaNydeam+MMtnO87aLsvswM8Dg0b8u1s2wEbGXeG0S5d8b8M
	gpLncVriJOZxdr/S+hNQBS9u1GXShwEAVsplRx5hkczW+cMOAp/ZAeGaDzJRnQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638909743;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8kdDUloupcZ7zsHm8ipSzMG1KhDz+bCCecRfNXSnpkg=;
	b=0V4XVUsOsvnU+9Fv3Fb95pdvdCgo/+dE0Mo+fVtsflMeNE/VXjrD4Tr1l/AitQqcrCl0wJ
	KhJ9aDeINWrmG3AA==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, Michael Ellerman
 <mpe@ellerman.id.au>,
 LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>, Thomas Bogendoerfer
 <tsbogend@alpha.franken.de>, linux-mips@vger.kernel.org, Kalle Valo
 <kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org, x86@kernel.org,
 xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Wei Liu
 <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org, Christian Borntraeger
 <borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never
 worked
In-Reply-To: <27f22e0e-8f84-a6d7-704b-d9eddc642d74@kaod.org>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.872249537@linutronix.de>
 <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
 <87ilw0odel.fsf@mpe.ellerman.id.au>
 <27f22e0e-8f84-a6d7-704b-d9eddc642d74@kaod.org>
Date: Tue, 07 Dec 2021 21:42:22 +0100
Message-ID: <8735n42lld.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Cedric,

On Tue, Dec 07 2021 at 16:50, C=C3=A9dric Le Goater wrote:
> On 12/7/21 12:36, Michael Ellerman wrote:
>>=20
>> This patch should drop those selects I guess. Can you send an
>> incremental diff for Thomas to squash in?
>
> Sure.
>
>> Removing all the tendrils in various device tree files will probably
>> require some archaeology, and it should be perfectly safe to leave those
>> in the tree with the driver gone. So I think we can do that as a
>> subsequent patch, rather than in this series.
>
> Here are the changes. Compiled tested with ppc40x and ppc44x defconfigs.

< Lots of patch skipped />
> @@ -141,7 +138,6 @@ config REDWOOD
>   	select FORCE_PCI
>   	select PPC4xx_PCI_EXPRESS
>   	select PCI_MSI
> -	select PPC4xx_MSI
>   	help
>   	  This option enables support for the AMCC PPC460SX Redwood board.

While that is incremental it certainly is worth a patch on it's
own. Could you add a proper changelog and an SOB please?

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:53:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241802.418300 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhTB-0002tA-RY; Tue, 07 Dec 2021 20:53:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241802.418300; Tue, 07 Dec 2021 20:53:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhTB-0002t3-NP; Tue, 07 Dec 2021 20:53:49 +0000
Received: by outflank-mailman (input) for mailman id 241802;
 Tue, 07 Dec 2021 20:53:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhTA-0002sx-L2
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:53:48 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c44c4a2d-579f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:53:46 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 16831CE1DFE;
 Tue,  7 Dec 2021 20:53:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3E3EC341C1;
 Tue,  7 Dec 2021 20:53:38 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c44c4a2d-579f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910419;
	bh=0olJYQ/vZXxNbmux0Wc5kCG7Q8xmQSGJ4EEGX5/7MKM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=MbREQLAmpD8wPLYpCv9jTSrE00gvmkjU34dG8bCGSdkkOx5lA5r+o1g2zoGSx/C2b
	 YIQIjqV/znJrCTHzH9zLIkNioxbfipIqhqype9Cd76anoG298O5tcN/hAXHTcgJr7E
	 AQhUCxkGye8vXivrflomiTMP5ytmmN4IV5kZwS7+LEBV8ahxK0/RPJjGnSoav8YdLu
	 Le2YSsXdQfJoyXe6klQp9YFPeJz/C9VdAwMAeftNu99ODwCGdjCd6c3CFrixrHlASA
	 bFHldg7thBUs+vtbfN+tcSAWID3FMjm+GzEoLKnTtAPWT54ggSkOvfr4XTjRaQ/uf3
	 5wndBP5xrSsFw==
Date: Tue, 7 Dec 2021 14:53:37 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 02/23] PCI/MSI: Fix
 pci_irq_vector()/pci_irq_get_affinity()
Message-ID: <20211207205337.GA76377@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210223.929792157@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:26PM +0100, Thomas Gleixner wrote:
> pci_irq_vector() and pci_irq_get_affinity() use the list position to find the
> MSI-X descriptor at a given index. That's correct for the normal case where
> the entry number is the same as the list position.
> 
> But it's wrong for cases where MSI-X was allocated with an entries array
> describing sparse entry numbers into the hardware message descriptor
> table. That's inconsistent at best.
> 
> Make it always check the entry number because that's what the zero base
> index really means. This change won't break existing users which use a
> sparse entries array for allocation because these users retrieve the Linux
> interrupt number from the entries array after allocation and none of them
> uses pci_irq_vector() or pci_irq_get_affinity().
> 
> Fixes: aff171641d18 ("PCI: Provide sensible IRQ vector alloc/free routines")
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> V2: Fix typo in subject - Jason
> ---
>  drivers/pci/msi.c |   26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
> 
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -1187,19 +1187,24 @@ EXPORT_SYMBOL(pci_free_irq_vectors);
>  
>  /**
>   * pci_irq_vector - return Linux IRQ number of a device vector
> - * @dev: PCI device to operate on
> - * @nr: device-relative interrupt vector index (0-based).
> + * @dev:	PCI device to operate on
> + * @nr:		Interrupt vector index (0-based)
> + *
> + * @nr has the following meanings depending on the interrupt mode:
> + *   MSI-X:	The index in the MSI-X vector table
> + *   MSI:	The index of the enabled MSI vectors
> + *   INTx:	Must be 0
> + *
> + * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
>   */
>  int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
>  {
>  	if (dev->msix_enabled) {
>  		struct msi_desc *entry;
> -		int i = 0;
>  
>  		for_each_pci_msi_entry(entry, dev) {
> -			if (i == nr)
> +			if (entry->msi_attrib.entry_nr == nr)
>  				return entry->irq;
> -			i++;
>  		}
>  		WARN_ON_ONCE(1);
>  		return -EINVAL;
> @@ -1223,17 +1228,22 @@ EXPORT_SYMBOL(pci_irq_vector);
>   * pci_irq_get_affinity - return the affinity of a particular MSI vector
>   * @dev:	PCI device to operate on
>   * @nr:		device-relative interrupt vector index (0-based).
> + *
> + * @nr has the following meanings depending on the interrupt mode:
> + *   MSI-X:	The index in the MSI-X vector table
> + *   MSI:	The index of the enabled MSI vectors
> + *   INTx:	Must be 0
> + *
> + * Return: A cpumask pointer or NULL if @nr is out of range
>   */
>  const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>  {
>  	if (dev->msix_enabled) {
>  		struct msi_desc *entry;
> -		int i = 0;
>  
>  		for_each_pci_msi_entry(entry, dev) {
> -			if (i == nr)
> +			if (entry->msi_attrib.entry_nr == nr)
>  				return &entry->affinity->mask;
> -			i++;
>  		}
>  		WARN_ON_ONCE(1);
>  		return NULL;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:54:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:54:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241806.418311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhU8-0003V8-9t; Tue, 07 Dec 2021 20:54:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241806.418311; Tue, 07 Dec 2021 20:54:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhU8-0003V1-65; Tue, 07 Dec 2021 20:54:48 +0000
Received: by outflank-mailman (input) for mailman id 241806;
 Tue, 07 Dec 2021 20:54:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhU6-0003Ug-Qm
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:54:46 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8579e5e-579f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:54:45 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A0A5AB81858;
 Tue,  7 Dec 2021 20:54:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E222C341C3;
 Tue,  7 Dec 2021 20:54:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8579e5e-579f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910483;
	bh=2TCFm6oMcOo2j9kU57EKGsnY8fkR6JvmY5FAYrIs66g=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=nsS3jKJ7qQGHDYJB47kov7AVBhzyG091DRuFfOsLF+34ALijihn9KZtlp+GJ6IKE8
	 kwldgAGONyoShIXShWCqK6l38EuYcxpvxsfxzUOfye0qv3FNym4mEgnKFN3S4deZJn
	 MK94vwclzEowmaVdB2cGhf7Z0a7/o3/oMmVUhVyJY2de/L6mR980HgZkZTFIElzJ/+
	 epdz+yWDLvAPCET9jF0AcFlWO/tiWh+A6jWW8FLHS0WZbyvHO0pmCIW6QBNlbIsCJM
	 H+HIHHhPv17Z3oQSzspeU71bWUAG5BFut+e0szyhVsCnMRESKTLgg/mxRT13eAuaiM
	 cbQlCTOqnZvyg==
Date: Tue, 7 Dec 2021 14:54:41 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 06/23] PCI/MSI: Make pci_msi_domain_write_msg() static
Message-ID: <20211207205441.GA76497@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.157070464@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:33PM +0100, Thomas Gleixner wrote:
> There is no point to have this function public as it is set by the PCI core
> anyway when a PCI/MSI irqdomain is created.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>	# PCI

> ---
>  drivers/irqchip/irq-gic-v2m.c            |    1 -
>  drivers/irqchip/irq-gic-v3-its-pci-msi.c |    1 -
>  drivers/irqchip/irq-gic-v3-mbi.c         |    1 -
>  drivers/pci/msi.c                        |    2 +-
>  include/linux/msi.h                      |    1 -
>  5 files changed, 1 insertion(+), 5 deletions(-)
> 
> --- a/drivers/irqchip/irq-gic-v2m.c
> +++ b/drivers/irqchip/irq-gic-v2m.c
> @@ -88,7 +88,6 @@ static struct irq_chip gicv2m_msi_irq_ch
>  	.irq_mask		= gicv2m_mask_msi_irq,
>  	.irq_unmask		= gicv2m_unmask_msi_irq,
>  	.irq_eoi		= irq_chip_eoi_parent,
> -	.irq_write_msi_msg	= pci_msi_domain_write_msg,
>  };
>  
>  static struct msi_domain_info gicv2m_msi_domain_info = {
> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> @@ -28,7 +28,6 @@ static struct irq_chip its_msi_irq_chip
>  	.irq_unmask		= its_unmask_msi_irq,
>  	.irq_mask		= its_mask_msi_irq,
>  	.irq_eoi		= irq_chip_eoi_parent,
> -	.irq_write_msi_msg	= pci_msi_domain_write_msg,
>  };
>  
>  static int its_pci_msi_vec_count(struct pci_dev *pdev, void *data)
> --- a/drivers/irqchip/irq-gic-v3-mbi.c
> +++ b/drivers/irqchip/irq-gic-v3-mbi.c
> @@ -171,7 +171,6 @@ static struct irq_chip mbi_msi_irq_chip
>  	.irq_unmask		= mbi_unmask_msi_irq,
>  	.irq_eoi		= irq_chip_eoi_parent,
>  	.irq_compose_msi_msg	= mbi_compose_msi_msg,
> -	.irq_write_msi_msg	= pci_msi_domain_write_msg,
>  };
>  
>  static struct msi_domain_info mbi_msi_domain_info = {
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -1281,7 +1281,7 @@ EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdat
>   * @irq_data:	Pointer to interrupt data of the MSI interrupt
>   * @msg:	Pointer to the message
>   */
> -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
>  {
>  	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
>  
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -455,7 +455,6 @@ void *platform_msi_get_host_data(struct
>  #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
>  
>  #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> -void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg);
>  struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
>  					     struct msi_domain_info *info,
>  					     struct irq_domain *parent);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:55:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241810.418321 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhUQ-0003zl-I4; Tue, 07 Dec 2021 20:55:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241810.418321; Tue, 07 Dec 2021 20:55:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhUQ-0003zc-Eo; Tue, 07 Dec 2021 20:55:06 +0000
Received: by outflank-mailman (input) for mailman id 241810;
 Tue, 07 Dec 2021 20:55:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhUP-0003Ug-Qe
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:55:05 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f3f85d8f-579f-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:55:04 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id D73F3B81E7F;
 Tue,  7 Dec 2021 20:55:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A28BC341CA;
 Tue,  7 Dec 2021 20:55:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3f85d8f-579f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910503;
	bh=Fa6UchSERsdNVXky6PNS2vCw8nCpV4RsTu7TPsjmB4I=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=dvUfGzkAJKzccQlv0HtPexRzXLWw3+BexhSfcjdhY9OELj9M9shyPr2oxlHYgishh
	 t4D2z7Bdr+ncSq9kKTlJ1eWwQvEyIE70QCOcHPfTkykUuEbmkImTsvOBxAh+YrDT2N
	 e2tXRjJ7AyPRQqOviSDYGDRtTGTym9+e84h6CsKaxpAqC8y47ShWjPbJ5Wc+6tQEDN
	 O+w8x6jcjhb24uXwmpRRwPhRkrIfIv7GvPutd6orOK9sOuf81nkdYTyVSsRwR7X0hy
	 UTGVn2mumg3zTPmrl6DdJIgD9FUL38mTDmd4Yy4CHa5XbrINFDsrU5l0x2T6JYzzJO
	 QyWBUWsq4OuoA==
Date: Tue, 7 Dec 2021 14:55:02 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 07/23] PCI/MSI: Remove msi_desc_to_pci_sysdata()
Message-ID: <20211207205502.GA76553@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.210768199@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:34PM +0100, Thomas Gleixner wrote:
> Last user is gone long ago.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi.c   |    8 --------
>  include/linux/msi.h |    5 -----
>  2 files changed, 13 deletions(-)
> 
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -1267,14 +1267,6 @@ struct pci_dev *msi_desc_to_pci_dev(stru
>  }
>  EXPORT_SYMBOL(msi_desc_to_pci_dev);
>  
> -void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
> -{
> -	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
> -
> -	return dev->bus->sysdata;
> -}
> -EXPORT_SYMBOL_GPL(msi_desc_to_pci_sysdata);
> -
>  #ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
>  /**
>   * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -218,13 +218,8 @@ static inline void msi_desc_set_iommu_co
>  	for_each_msi_entry((desc), &(pdev)->dev)
>  
>  struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc);
> -void *msi_desc_to_pci_sysdata(struct msi_desc *desc);
>  void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg);
>  #else /* CONFIG_PCI_MSI */
> -static inline void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
> -{
> -	return NULL;
> -}
>  static inline void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
>  {
>  }
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:56:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:56:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241820.418333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhVa-0004hI-Rz; Tue, 07 Dec 2021 20:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241820.418333; Tue, 07 Dec 2021 20:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhVa-0004hB-Oo; Tue, 07 Dec 2021 20:56:18 +0000
Received: by outflank-mailman (input) for mailman id 241820;
 Tue, 07 Dec 2021 20:56:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhVZ-0004h1-PE
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:56:17 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1ec150f9-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:56:16 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A22C4B81E7E;
 Tue,  7 Dec 2021 20:56:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06B8EC341C1;
 Tue,  7 Dec 2021 20:56:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1ec150f9-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910575;
	bh=qLik4JFtyxqmSptBayqaCn1r8IHM9yMTUp4uNVorfnk=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=ZuIbLGLfYV/nvLepPIU/oJgGVLR/cUv4fN1TB9jN6qxiqhzWiZXhZIRCqViFXsXX2
	 BupHwnNmoV668bTXaUoUD++cCPB+blzebEwefTUII/C/6Vy7O3vnv9NoEGA/Ji6Owv
	 oPt6EPc+oZmfGxvR4m833Yz/aYsVS5bGsuqgu5ZEDfAHynE853rfjGlPDeDpFGEt3Z
	 R8MZc2PJgawqhxAfrRf/p8uWcDY0ETOixepI3ae+2tW6W36bm3938Zs5e4gyXwU3uL
	 Xg3/BGlYj1tkxDl4i0Ek1cNEw8YRkCMuc4qXgDYFJwb6ISeYQABlWAEk0RIe7vI2Hq
	 f6aHj3PLOAFog==
Date: Tue, 7 Dec 2021 14:56:13 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 08/23] PCI/sysfs: Use pci_irq_vector()
Message-ID: <20211207205613.GA76623@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.265589103@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:36PM +0100, Thomas Gleixner wrote:
> instead of fiddling with msi descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

s/msi/MSI/ above if you have a chance.  Nice cleanup, thanks!

> ---
>  drivers/pci/pci-sysfs.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -62,11 +62,8 @@ static ssize_t irq_show(struct device *d
>  	 * For MSI, show the first MSI IRQ; for all other cases including
>  	 * MSI-X, show the legacy INTx IRQ.
>  	 */
> -	if (pdev->msi_enabled) {
> -		struct msi_desc *desc = first_pci_msi_entry(pdev);
> -
> -		return sysfs_emit(buf, "%u\n", desc->irq);
> -	}
> +	if (pdev->msi_enabled)
> +		return sysfs_emit(buf, "%u\n", pci_irq_vector(pdev, 0));
>  #endif
>  
>  	return sysfs_emit(buf, "%u\n", pdev->irq);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:56:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:56:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241824.418344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhW4-0005Fg-3k; Tue, 07 Dec 2021 20:56:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241824.418344; Tue, 07 Dec 2021 20:56:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhW4-0005FZ-0l; Tue, 07 Dec 2021 20:56:48 +0000
Received: by outflank-mailman (input) for mailman id 241824;
 Tue, 07 Dec 2021 20:56:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhW2-0005FD-2t
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:56:46 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2f2aa3a4-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 21:56:44 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A2E29B81E91;
 Tue,  7 Dec 2021 20:56:43 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82AAEC341D4;
 Tue,  7 Dec 2021 20:56:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f2aa3a4-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910600;
	bh=X61QYWzbqgFgrJlTqRQwH4PzFugFcu0Hpdp1pU5hHmM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=TML4f1uO3yO7J1wXBUU1oQjNt9/b0tQSXkYs2daEjd6lCOMWhRgOOQmmhRvjFabJ3
	 9h4M51LOkpLjoMpzciB7fXRHDXdxUdlhZ3Aemx080ANSrhGUtq9NVnPE9kyq7JreQZ
	 69r46bVEHr3HumIzzDX+mCI5CvOzsce9BFylUxhc0op/FhDozgZd9q7vNUPGRHOKiz
	 0v6FB4uodoDiEkYP4It3XFe2w/ExGM5DEHBBtGIWKGQp3WF3TRfW1TOup7wqcpjylA
	 oKHUl1krlMjN39awAPgFfxZ1ZPXQNfrhVlJOUUJaBUxpnxRoh6ePoBBZEog88alfDM
	 GgmzqmgApIP1Q==
Date: Tue, 7 Dec 2021 14:56:39 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>, x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org
Subject: Re: [patch V2 12/23] PCI/MSI: Make arch_restore_msi_irqs() less
 horrible.
Message-ID: <20211207205639.GA76751@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.485668098@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:42PM +0100, Thomas Gleixner wrote:
> Make arch_restore_msi_irqs() return a boolean which indicates whether the
> core code should restore the MSI message or not. Get rid of the indirection
> in x86.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: x86@kernel.org
> Cc: xen-devel@lists.xenproject.org
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>	# PCI

> ---
>  arch/s390/pci/pci_irq.c               |    4 +-
>  arch/x86/include/asm/x86_init.h       |    6 ---
>  arch/x86/include/asm/xen/hypervisor.h |    8 +++++
>  arch/x86/kernel/apic/msi.c            |    6 +++
>  arch/x86/kernel/x86_init.c            |   12 -------
>  arch/x86/pci/xen.c                    |   13 ++++----
>  drivers/pci/msi.c                     |   54 +++++++++++-----------------------
>  include/linux/msi.h                   |    7 +---
>  8 files changed, 45 insertions(+), 65 deletions(-)
> 
> --- a/arch/s390/pci/pci_irq.c
> +++ b/arch/s390/pci/pci_irq.c
> @@ -387,13 +387,13 @@ void arch_teardown_msi_irqs(struct pci_d
>  		airq_iv_free(zpci_ibv[0], zdev->msi_first_bit, zdev->msi_nr_irqs);
>  }
>  
> -void arch_restore_msi_irqs(struct pci_dev *pdev)
> +bool arch_restore_msi_irqs(struct pci_dev *pdev)
>  {
>  	struct zpci_dev *zdev = to_zpci(pdev);
>  
>  	if (!zdev->irqs_registered)
>  		zpci_set_irq(zdev);
> -	default_restore_msi_irqs(pdev);
> +	return true;
>  }
>  
>  static struct airq_struct zpci_airq = {
> --- a/arch/x86/include/asm/x86_init.h
> +++ b/arch/x86/include/asm/x86_init.h
> @@ -289,12 +289,6 @@ struct x86_platform_ops {
>  	struct x86_hyper_runtime hyper;
>  };
>  
> -struct pci_dev;
> -
> -struct x86_msi_ops {
> -	void (*restore_msi_irqs)(struct pci_dev *dev);
> -};
> -
>  struct x86_apic_ops {
>  	unsigned int	(*io_apic_read)   (unsigned int apic, unsigned int reg);
>  	void		(*restore)(void);
> --- a/arch/x86/include/asm/xen/hypervisor.h
> +++ b/arch/x86/include/asm/xen/hypervisor.h
> @@ -57,6 +57,14 @@ static inline bool __init xen_x2apic_par
>  }
>  #endif
>  
> +struct pci_dev;
> +
> +#ifdef CONFIG_XEN_DOM0
> +bool xen_initdom_restore_msi(struct pci_dev *dev);
> +#else
> +static inline bool xen_initdom_restore_msi(struct pci_dev *dev) { return true; }
> +#endif
> +
>  #ifdef CONFIG_HOTPLUG_CPU
>  void xen_arch_register_cpu(int num);
>  void xen_arch_unregister_cpu(int num);
> --- a/arch/x86/kernel/apic/msi.c
> +++ b/arch/x86/kernel/apic/msi.c
> @@ -19,6 +19,7 @@
>  #include <asm/hw_irq.h>
>  #include <asm/apic.h>
>  #include <asm/irq_remapping.h>
> +#include <asm/xen/hypervisor.h>
>  
>  struct irq_domain *x86_pci_msi_default_domain __ro_after_init;
>  
> @@ -345,3 +346,8 @@ void dmar_free_hwirq(int irq)
>  	irq_domain_free_irqs(irq, 1);
>  }
>  #endif
> +
> +bool arch_restore_msi_irqs(struct pci_dev *dev)
> +{
> +	return xen_initdom_restore_msi(dev);
> +}
> --- a/arch/x86/kernel/x86_init.c
> +++ b/arch/x86/kernel/x86_init.c
> @@ -145,18 +145,6 @@ struct x86_platform_ops x86_platform __r
>  
>  EXPORT_SYMBOL_GPL(x86_platform);
>  
> -#if defined(CONFIG_PCI_MSI)
> -struct x86_msi_ops x86_msi __ro_after_init = {
> -	.restore_msi_irqs	= default_restore_msi_irqs,
> -};
> -
> -/* MSI arch specific hooks */
> -void arch_restore_msi_irqs(struct pci_dev *dev)
> -{
> -	x86_msi.restore_msi_irqs(dev);
> -}
> -#endif
> -
>  struct x86_apic_ops x86_apic_ops __ro_after_init = {
>  	.io_apic_read	= native_io_apic_read,
>  	.restore	= native_restore_boot_irq_mode,
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -351,10 +351,13 @@ static int xen_initdom_setup_msi_irqs(st
>  	return ret;
>  }
>  
> -static void xen_initdom_restore_msi_irqs(struct pci_dev *dev)
> +bool xen_initdom_restore_msi(struct pci_dev *dev)
>  {
>  	int ret = 0;
>  
> +	if (!xen_initial_domain())
> +		return true;
> +
>  	if (pci_seg_supported) {
>  		struct physdev_pci_device restore_ext;
>  
> @@ -375,10 +378,10 @@ static void xen_initdom_restore_msi_irqs
>  		ret = HYPERVISOR_physdev_op(PHYSDEVOP_restore_msi, &restore);
>  		WARN(ret && ret != -ENOSYS, "restore_msi -> %d\n", ret);
>  	}
> +	return false;
>  }
>  #else /* CONFIG_XEN_PV_DOM0 */
>  #define xen_initdom_setup_msi_irqs	NULL
> -#define xen_initdom_restore_msi_irqs	NULL
>  #endif /* !CONFIG_XEN_PV_DOM0 */
>  
>  static void xen_teardown_msi_irqs(struct pci_dev *dev)
> @@ -466,12 +469,10 @@ static __init struct irq_domain *xen_cre
>  static __init void xen_setup_pci_msi(void)
>  {
>  	if (xen_pv_domain()) {
> -		if (xen_initial_domain()) {
> +		if (xen_initial_domain())
>  			xen_msi_ops.setup_msi_irqs = xen_initdom_setup_msi_irqs;
> -			x86_msi.restore_msi_irqs = xen_initdom_restore_msi_irqs;
> -		} else {
> +		else
>  			xen_msi_ops.setup_msi_irqs = xen_setup_msi_irqs;
> -		}
>  		xen_msi_ops.teardown_msi_irqs = xen_pv_teardown_msi_irqs;
>  		pci_msi_ignore_mask = 1;
>  	} else if (xen_hvm_domain()) {
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -106,29 +106,6 @@ void __weak arch_teardown_msi_irqs(struc
>  }
>  #endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
>  
> -static void default_restore_msi_irq(struct pci_dev *dev, int irq)
> -{
> -	struct msi_desc *entry;
> -
> -	entry = NULL;
> -	if (dev->msix_enabled) {
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (irq == entry->irq)
> -				break;
> -		}
> -	} else if (dev->msi_enabled)  {
> -		entry = irq_get_msi_desc(irq);
> -	}
> -
> -	if (entry)
> -		__pci_write_msi_msg(entry, &entry->msg);
> -}
> -
> -void __weak arch_restore_msi_irqs(struct pci_dev *dev)
> -{
> -	return default_restore_msi_irqs(dev);
> -}
> -
>  /*
>   * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
>   * mask all MSI interrupts by clearing the MSI enable bit does not work
> @@ -242,14 +219,6 @@ void pci_msi_unmask_irq(struct irq_data
>  }
>  EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
>  
> -void default_restore_msi_irqs(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -
> -	for_each_pci_msi_entry(entry, dev)
> -		default_restore_msi_irq(dev, entry->irq);
> -}
> -
>  void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
>  {
>  	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
> @@ -403,10 +372,19 @@ static void pci_msi_set_enable(struct pc
>  	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
>  }
>  
> +/*
> + * Architecture override returns true when the PCI MSI message should be
> + * written by the generic restore function.
> + */
> +bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
> +{
> +	return true;
> +}
> +
>  static void __pci_restore_msi_state(struct pci_dev *dev)
>  {
> -	u16 control;
>  	struct msi_desc *entry;
> +	u16 control;
>  
>  	if (!dev->msi_enabled)
>  		return;
> @@ -415,7 +393,8 @@ static void __pci_restore_msi_state(stru
>  
>  	pci_intx_for_msi(dev, 0);
>  	pci_msi_set_enable(dev, 0);
> -	arch_restore_msi_irqs(dev);
> +	if (arch_restore_msi_irqs(dev))
> +		__pci_write_msi_msg(entry, &entry->msg);
>  
>  	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
>  	pci_msi_update_mask(entry, 0, 0);
> @@ -437,6 +416,7 @@ static void pci_msix_clear_and_set_ctrl(
>  static void __pci_restore_msix_state(struct pci_dev *dev)
>  {
>  	struct msi_desc *entry;
> +	bool write_msg;
>  
>  	if (!dev->msix_enabled)
>  		return;
> @@ -447,9 +427,13 @@ static void __pci_restore_msix_state(str
>  	pci_msix_clear_and_set_ctrl(dev, 0,
>  				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
>  
> -	arch_restore_msi_irqs(dev);
> -	for_each_pci_msi_entry(entry, dev)
> +	write_msg = arch_restore_msi_irqs(dev);
> +
> +	for_each_pci_msi_entry(entry, dev) {
> +		if (write_msg)
> +			__pci_write_msi_msg(entry, &entry->msg);
>  		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
> +	}
>  
>  	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
>  }
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -273,11 +273,10 @@ static inline void arch_teardown_msi_irq
>  #endif
>  
>  /*
> - * The restore hooks are still available as they are useful even
> - * for fully irq domain based setups. Courtesy to XEN/X86.
> + * The restore hook is still available even for fully irq domain based
> + * setups. Courtesy to XEN/X86.
>   */
> -void arch_restore_msi_irqs(struct pci_dev *dev);
> -void default_restore_msi_irqs(struct pci_dev *dev);
> +bool arch_restore_msi_irqs(struct pci_dev *dev);
>  
>  #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
>  
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:57:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:57:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241830.418355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhWO-0006CM-DB; Tue, 07 Dec 2021 20:57:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241830.418355; Tue, 07 Dec 2021 20:57:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhWO-0006CD-99; Tue, 07 Dec 2021 20:57:08 +0000
Received: by outflank-mailman (input) for mailman id 241830;
 Tue, 07 Dec 2021 20:57:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhWM-0004h1-Ig
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:57:06 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b9919a8-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:57:04 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id EDE53B81E82;
 Tue,  7 Dec 2021 20:57:04 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43DACC341C1;
 Tue,  7 Dec 2021 20:57:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b9919a8-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910624;
	bh=XrslgRHtCWkizJFdxh4LYx0Ea6YIT+zkeRKUg8jgH50=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=oNWOya01lPJvnE3tH25W+i5fvBukvCWqbSt8o6DALtpqSoHuRmTol41FHNBbcEmwf
	 ndqs+TUJ09ke7BxWb8HjaLc/fY3tO470dZ4Qyno4Wpq5/bEnoEjzOjsbXmUV1qPZIo
	 hVQXatTYM8u7grl3xYsaQbLBxtsdENIZvu9pTIxNja33qod3Ecev9Ir5ev8d5C96pY
	 0IK/7dJ9j/4mbDBL0nO4T+nU7isZp4iut/H/gQt557Of3NPt7vq7/9Jpi+jESYyg4O
	 IkM/M8qlqvOoGLJfagsdSI/guqcNiYtMrzlfaFPpkvCs0s96NJKjtT7Cv9aAODCAWZ
	 Q3dkMDUriYcZA==
Date: Tue, 7 Dec 2021 14:57:03 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 13/23] PCI/MSI: Cleanup include zoo
Message-ID: <20211207205703.GA76805@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.539281124@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:44PM +0100, Thomas Gleixner wrote:
> Get rid of the pile of unneeded includes which accumulated over time.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

Nice, thanks!

> ---
> V2: Address build fail on powerpc - Cedric
> ---
>  drivers/pci/msi.c |   16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
> 
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -7,22 +7,14 @@
>   * Copyright (C) 2016 Christoph Hellwig.
>   */
>  
> +#include <linux/acpi_iort.h>
>  #include <linux/err.h>
> -#include <linux/mm.h>
> -#include <linux/irq.h>
> -#include <linux/interrupt.h>
>  #include <linux/export.h>
> -#include <linux/ioport.h>
> -#include <linux/pci.h>
> -#include <linux/proc_fs.h>
> -#include <linux/msi.h>
> -#include <linux/smp.h>
> -#include <linux/errno.h>
> -#include <linux/io.h>
> -#include <linux/acpi_iort.h>
> -#include <linux/slab.h>
> +#include <linux/irq.h>
>  #include <linux/irqdomain.h>
> +#include <linux/msi.h>
>  #include <linux/of_irq.h>
> +#include <linux/pci.h>
>  
>  #include "pci.h"
>  
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 20:57:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 20:57:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241833.418366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhWd-0006jJ-Nr; Tue, 07 Dec 2021 20:57:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241833.418366; Tue, 07 Dec 2021 20:57:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhWd-0006jC-KH; Tue, 07 Dec 2021 20:57:23 +0000
Received: by outflank-mailman (input) for mailman id 241833;
 Tue, 07 Dec 2021 20:57:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhWc-0005FD-UW
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:57:22 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45fe27ef-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 21:57:22 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0B7F8B81E94;
 Tue,  7 Dec 2021 20:57:22 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58C95C341C8;
 Tue,  7 Dec 2021 20:57:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45fe27ef-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910641;
	bh=p4nzpRhPjzZYY/2joI+5ST1wSIqa+dnFOH02Wt6TY90=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=TBxT84AbL5Gep1COvq7TErtiHgXwTDw0MqC9DWEsU3bt1FgCmBhl92LueC5uhijkJ
	 /AD3uh3vlBBztJBVIuEXGD39HkvRqAw2mmADUNrbGv8igflwAI51FTrrlhOCh7CDjA
	 JipWm7z8+pwAofUYL8YQ4KeHO2uQrmr42qs33txntiRVsX4QM5pQiASWsxcQeT9JnJ
	 Q7nKN6B9u2c3unSau2PIUrC+WNRDmQr0NBXm2YWSOwlW431/1LNllTpk2xQvdwBDWx
	 jRXpt3dwtRz/SnDxd9nv1DqQPFXA2DpbOUl8hDquMhSry+d0h0MDbGrJJ0q+aeDGbe
	 C0zQ+0ViJLMag==
Date: Tue, 7 Dec 2021 14:57:20 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 14/23] PCI/MSI: Make msix_update_entries() smarter
Message-ID: <20211207205720.GA76876@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.600351129@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:46PM +0100, Thomas Gleixner wrote:
> No need to walk the descriptors and check for each one whether the entries
> pointer function argument is NULL. Do it once.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -642,8 +642,8 @@ static void msix_update_entries(struct p
>  {
>  	struct msi_desc *entry;
>  
> -	for_each_pci_msi_entry(entry, dev) {
> -		if (entries) {
> +	if (entries) {
> +		for_each_pci_msi_entry(entry, dev) {
>  			entries->vector = entry->irq;
>  			entries++;
>  		}
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:00:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:00:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241847.418377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhZ2-0007bJ-4O; Tue, 07 Dec 2021 20:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241847.418377; Tue, 07 Dec 2021 20:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhZ2-0007bC-1J; Tue, 07 Dec 2021 20:59:52 +0000
Received: by outflank-mailman (input) for mailman id 241847;
 Tue, 07 Dec 2021 20:59:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhZ1-0007b4-66
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:59:51 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d00bad3-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 21:59:49 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id D16F7CE1E88;
 Tue,  7 Dec 2021 20:59:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B586C341C3;
 Tue,  7 Dec 2021 20:59:43 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d00bad3-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910783;
	bh=6xre4ERQ0zpMI+yMYHqya0Bv8a/uSKKR8JsDZHNhU4A=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=aeRzt8BFGmz8vimH6MrP0wP9SdPtvkbfZq/UmC8CKYYNjJasWIz5f+IDpiLt6A0aT
	 oWaWypdpOk3kLHyjzDsQeYqrHTpd3iZOnTYeKEAmkMHjU7UnfvkxaMuJDeC/Wc2Hzi
	 d/FFX9EV+Kcu4/bql3Cu7G+iZUNrbr932+dfUmbNQpfi4jfYq2+R49cO4nrodAA1Iw
	 jVDW4T13NZ4YjdWrzzbDYPYSCQhY6XlsHmoikp3g+pCtfXWnC49HkD/43doiyns1eo
	 u+nnrBTWk3+O0gdwhnpWHdlUi5r4O8Da5zgFdzOYEWM9P+fQEy+euPyaO0pLLMA4LT
	 ZCokWDHvR/fEg==
Date: Tue, 7 Dec 2021 14:59:42 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 17/23] PCI/MSI: Split out !IRQDOMAIN code
Message-ID: <20211207205942.GA77110@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.763574089@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:51PM +0100, Thomas Gleixner wrote:
> Split out the non irqdomain code into its own file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> V2: Add proper includes and fix variable name - Cedric
> ---
>  drivers/pci/msi/Makefile |    5 ++--
>  drivers/pci/msi/legacy.c |   52 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/pci/msi/msi.c    |   46 -----------------------------------------
>  3 files changed, 55 insertions(+), 48 deletions(-)
> 
> --- a/drivers/pci/msi/Makefile
> +++ b/drivers/pci/msi/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  #
>  # Makefile for the PCI/MSI
> -obj-$(CONFIG_PCI)		+= pcidev_msi.o
> -obj-$(CONFIG_PCI_MSI)		+= msi.o
> +obj-$(CONFIG_PCI)			+= pcidev_msi.o
> +obj-$(CONFIG_PCI_MSI)			+= msi.o
> +obj-$(CONFIG_PCI_MSI_ARCH_FALLBACKS)	+= legacy.o
> --- /dev/null
> +++ b/drivers/pci/msi/legacy.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * PCI Message Signaled Interrupt (MSI).
> + *
> + * Legacy architecture specific setup and teardown mechanism.
> + */
> +#include <linux/msi.h>
> +#include <linux/pci.h>
> +
> +/* Arch hooks */
> +int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
> +{
> +	return -EINVAL;
> +}
> +
> +void __weak arch_teardown_msi_irq(unsigned int irq)
> +{
> +}
> +
> +int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	struct msi_desc *desc;
> +	int ret;
> +
> +	/*
> +	 * If an architecture wants to support multiple MSI, it needs to
> +	 * override arch_setup_msi_irqs()
> +	 */
> +	if (type == PCI_CAP_ID_MSI && nvec > 1)
> +		return 1;
> +
> +	for_each_pci_msi_entry(desc, dev) {
> +		ret = arch_setup_msi_irq(dev, desc);
> +		if (ret)
> +			return ret < 0 ? ret : -ENOSPC;
> +	}
> +
> +	return 0;
> +}
> +
> +void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	struct msi_desc *desc;
> +	int i;
> +
> +	for_each_pci_msi_entry(desc, dev) {
> +		if (desc->irq) {
> +			for (i = 0; i < desc->nvec_used; i++)
> +				arch_teardown_msi_irq(desc->irq + i);
> +		}
> +	}
> +}
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -50,52 +50,6 @@ static void pci_msi_teardown_msi_irqs(st
>  #define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
>  #endif
>  
> -#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
> -/* Arch hooks */
> -int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
> -{
> -	return -EINVAL;
> -}
> -
> -void __weak arch_teardown_msi_irq(unsigned int irq)
> -{
> -}
> -
> -int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	struct msi_desc *entry;
> -	int ret;
> -
> -	/*
> -	 * If an architecture wants to support multiple MSI, it needs to
> -	 * override arch_setup_msi_irqs()
> -	 */
> -	if (type == PCI_CAP_ID_MSI && nvec > 1)
> -		return 1;
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		ret = arch_setup_msi_irq(dev, entry);
> -		if (ret < 0)
> -			return ret;
> -		if (ret > 0)
> -			return -ENOSPC;
> -	}
> -
> -	return 0;
> -}
> -
> -void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	int i;
> -	struct msi_desc *entry;
> -
> -	for_each_pci_msi_entry(entry, dev)
> -		if (entry->irq)
> -			for (i = 0; i < entry->nvec_used; i++)
> -				arch_teardown_msi_irq(entry->irq + i);
> -}
> -#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
> -
>  /*
>   * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
>   * mask all MSI interrupts by clearing the MSI enable bit does not work
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:00:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:00:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241850.418388 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhZL-0000Or-C6; Tue, 07 Dec 2021 21:00:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241850.418388; Tue, 07 Dec 2021 21:00:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhZL-0000Ok-8q; Tue, 07 Dec 2021 21:00:11 +0000
Received: by outflank-mailman (input) for mailman id 241850;
 Tue, 07 Dec 2021 21:00:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhZJ-0007b4-Fl
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:00:09 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a7cbd8be-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:00:07 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id ACF93B81E95;
 Tue,  7 Dec 2021 21:00:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D45B5C341C3;
 Tue,  7 Dec 2021 21:00:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a7cbd8be-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910804;
	bh=RubyEJwz2NHDBLakfGnC7h6evAWGOsLZrxFZJP3Ls1U=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=XVXpVnKYNxaH0KPoflPcaqbYlxkDj0hnIA//RbCZ1xW2uV6Sx1i9RFOCtSx0YPrLo
	 RuzPtF364tuEhKQnrJ6Sdfy647qEFBaMrqpOeUxUcqZ5TW+bOPzWMz/NqPCMtRzvjd
	 25l6Uxd0mmEftdLEDs9XddH8ydG9gCcuNR/SwWSljYP6ysyClvKivTarOQEuQFXoCP
	 TGvIenToBphjgSMyffzWMSr06+7g1IR/6WHi+EgUelhwTAPqMdD1fIca3t/oLUA+p6
	 xKPTcLZ75Ht/OvneW7vDjsjcZP5JX48kdV5cOwjrywUJHaNofmhKHJScNnCD0lGtvy
	 iksPCLvTgE0/w==
Date: Tue, 7 Dec 2021 15:00:02 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 18/23] PCI/MSI: Split out irqdomain code
Message-ID: <20211207210002.GA77165@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.817754783@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:52PM +0100, Thomas Gleixner wrote:
> Move the irqdomain specific code into it's own file.

s/it's/its/

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/Makefile    |    1 
>  drivers/pci/msi/irqdomain.c |  279 ++++++++++++++++++++++++++++++++++++++
>  drivers/pci/msi/legacy.c    |   13 +
>  drivers/pci/msi/msi.c       |  319 +-------------------------------------------
>  drivers/pci/msi/msi.h       |   39 +++++
>  include/linux/msi.h         |   11 -
>  6 files changed, 340 insertions(+), 322 deletions(-)
> 
> --- a/drivers/pci/msi/Makefile
> +++ b/drivers/pci/msi/Makefile
> @@ -3,4 +3,5 @@
>  # Makefile for the PCI/MSI
>  obj-$(CONFIG_PCI)			+= pcidev_msi.o
>  obj-$(CONFIG_PCI_MSI)			+= msi.o
> +obj-$(CONFIG_PCI_MSI_IRQ_DOMAIN)	+= irqdomain.o
>  obj-$(CONFIG_PCI_MSI_ARCH_FALLBACKS)	+= legacy.o
> --- /dev/null
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -0,0 +1,279 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * PCI Message Signaled Interrupt (MSI) - irqdomain support
> + */
> +#include <linux/acpi_iort.h>
> +#include <linux/irqdomain.h>
> +#include <linux/of_irq.h>
> +
> +#include "msi.h"
> +
> +int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	struct irq_domain *domain;
> +
> +	domain = dev_get_msi_domain(&dev->dev);
> +	if (domain && irq_domain_is_hierarchy(domain))
> +		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
> +
> +	return pci_msi_legacy_setup_msi_irqs(dev, nvec, type);
> +}
> +
> +void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	struct irq_domain *domain;
> +
> +	domain = dev_get_msi_domain(&dev->dev);
> +	if (domain && irq_domain_is_hierarchy(domain))
> +		msi_domain_free_irqs(domain, &dev->dev);
> +	else
> +		pci_msi_legacy_teardown_msi_irqs(dev);
> +}
> +
> +/**
> + * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
> + * @irq_data:	Pointer to interrupt data of the MSI interrupt
> + * @msg:	Pointer to the message
> + */
> +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> +{
> +	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
> +
> +	/*
> +	 * For MSI-X desc->irq is always equal to irq_data->irq. For
> +	 * MSI only the first interrupt of MULTI MSI passes the test.
> +	 */
> +	if (desc->irq == irq_data->irq)
> +		__pci_write_msi_msg(desc, msg);
> +}
> +
> +/**
> + * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
> + * @desc:	Pointer to the MSI descriptor
> + *
> + * The ID number is only used within the irqdomain.
> + */
> +static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
> +{
> +	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
> +
> +	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
> +		pci_dev_id(dev) << 11 |
> +		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> +}
> +
> +static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
> +{
> +	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
> +}
> +
> +/**
> + * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
> + *			      for @dev
> + * @domain:	The interrupt domain to check
> + * @info:	The domain info for verification
> + * @dev:	The device to check
> + *
> + * Returns:
> + *  0 if the functionality is supported
> + *  1 if Multi MSI is requested, but the domain does not support it
> + *  -ENOTSUPP otherwise
> + */
> +int pci_msi_domain_check_cap(struct irq_domain *domain,
> +			     struct msi_domain_info *info, struct device *dev)
> +{
> +	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
> +
> +	/* Special handling to support __pci_enable_msi_range() */
> +	if (pci_msi_desc_is_multi_msi(desc) &&
> +	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
> +		return 1;
> +	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
> +		return -ENOTSUPP;
> +
> +	return 0;
> +}
> +
> +static int pci_msi_domain_handle_error(struct irq_domain *domain,
> +				       struct msi_desc *desc, int error)
> +{
> +	/* Special handling to support __pci_enable_msi_range() */
> +	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
> +		return 1;
> +
> +	return error;
> +}
> +
> +static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
> +				    struct msi_desc *desc)
> +{
> +	arg->desc = desc;
> +	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
> +}
> +
> +static struct msi_domain_ops pci_msi_domain_ops_default = {
> +	.set_desc	= pci_msi_domain_set_desc,
> +	.msi_check	= pci_msi_domain_check_cap,
> +	.handle_error	= pci_msi_domain_handle_error,
> +};
> +
> +static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
> +{
> +	struct msi_domain_ops *ops = info->ops;
> +
> +	if (ops == NULL) {
> +		info->ops = &pci_msi_domain_ops_default;
> +	} else {
> +		if (ops->set_desc == NULL)
> +			ops->set_desc = pci_msi_domain_set_desc;
> +		if (ops->msi_check == NULL)
> +			ops->msi_check = pci_msi_domain_check_cap;
> +		if (ops->handle_error == NULL)
> +			ops->handle_error = pci_msi_domain_handle_error;
> +	}
> +}
> +
> +static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
> +{
> +	struct irq_chip *chip = info->chip;
> +
> +	BUG_ON(!chip);
> +	if (!chip->irq_write_msi_msg)
> +		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
> +	if (!chip->irq_mask)
> +		chip->irq_mask = pci_msi_mask_irq;
> +	if (!chip->irq_unmask)
> +		chip->irq_unmask = pci_msi_unmask_irq;
> +}
> +
> +/**
> + * pci_msi_create_irq_domain - Create a MSI interrupt domain
> + * @fwnode:	Optional fwnode of the interrupt controller
> + * @info:	MSI domain info
> + * @parent:	Parent irq domain
> + *
> + * Updates the domain and chip ops and creates a MSI interrupt domain.
> + *
> + * Returns:
> + * A domain pointer or NULL in case of failure.
> + */
> +struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
> +					     struct msi_domain_info *info,
> +					     struct irq_domain *parent)
> +{
> +	struct irq_domain *domain;
> +
> +	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
> +		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
> +
> +	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
> +		pci_msi_domain_update_dom_ops(info);
> +	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
> +		pci_msi_domain_update_chip_ops(info);
> +
> +	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
> +	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
> +		info->flags |= MSI_FLAG_MUST_REACTIVATE;
> +
> +	/* PCI-MSI is oneshot-safe */
> +	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
> +
> +	domain = msi_create_irq_domain(fwnode, info, parent);
> +	if (!domain)
> +		return NULL;
> +
> +	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
> +	return domain;
> +}
> +EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
> +
> +/*
> + * Users of the generic MSI infrastructure expect a device to have a single ID,
> + * so with DMA aliases we have to pick the least-worst compromise. Devices with
> + * DMA phantom functions tend to still emit MSIs from the real function number,
> + * so we ignore those and only consider topological aliases where either the
> + * alias device or RID appears on a different bus number. We also make the
> + * reasonable assumption that bridges are walked in an upstream direction (so
> + * the last one seen wins), and the much braver assumption that the most likely
> + * case is that of PCI->PCIe so we should always use the alias RID. This echoes
> + * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
> + * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
> + * for taking ownership all we can really do is close our eyes and hope...
> + */
> +static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
> +{
> +	u32 *pa = data;
> +	u8 bus = PCI_BUS_NUM(*pa);
> +
> +	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
> +		*pa = alias;
> +
> +	return 0;
> +}
> +
> +/**
> + * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
> + * @domain:	The interrupt domain
> + * @pdev:	The PCI device.
> + *
> + * The RID for a device is formed from the alias, with a firmware
> + * supplied mapping applied
> + *
> + * Returns: The RID.
> + */
> +u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
> +{
> +	struct device_node *of_node;
> +	u32 rid = pci_dev_id(pdev);
> +
> +	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> +
> +	of_node = irq_domain_get_of_node(domain);
> +	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
> +			iort_msi_map_id(&pdev->dev, rid);
> +
> +	return rid;
> +}
> +
> +/**
> + * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
> + * @pdev:	The PCI device
> + *
> + * Use the firmware data to find a device-specific MSI domain
> + * (i.e. not one that is set as a default).
> + *
> + * Returns: The corresponding MSI domain or NULL if none has been found.
> + */
> +struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
> +{
> +	struct irq_domain *dom;
> +	u32 rid = pci_dev_id(pdev);
> +
> +	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> +	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
> +	if (!dom)
> +		dom = iort_get_device_domain(&pdev->dev, rid,
> +					     DOMAIN_BUS_PCI_MSI);
> +	return dom;
> +}
> +
> +/**
> + * pci_dev_has_special_msi_domain - Check whether the device is handled by
> + *				    a non-standard PCI-MSI domain
> + * @pdev:	The PCI device to check.
> + *
> + * Returns: True if the device irqdomain or the bus irqdomain is
> + * non-standard PCI/MSI.
> + */
> +bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
> +{
> +	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
> +
> +	if (!dom)
> +		dom = dev_get_msi_domain(&pdev->bus->dev);
> +
> +	if (!dom)
> +		return true;
> +
> +	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
> +}
> --- a/drivers/pci/msi/legacy.c
> +++ b/drivers/pci/msi/legacy.c
> @@ -4,8 +4,7 @@
>   *
>   * Legacy architecture specific setup and teardown mechanism.
>   */
> -#include <linux/msi.h>
> -#include <linux/pci.h>
> +#include "msi.h"
>  
>  /* Arch hooks */
>  int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
> @@ -50,3 +49,13 @@ void __weak arch_teardown_msi_irqs(struc
>  		}
>  	}
>  }
> +
> +int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	return arch_setup_msi_irqs(dev, nvec, type);
> +}
> +
> +void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	arch_teardown_msi_irqs(dev);
> +}
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -6,64 +6,16 @@
>   * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
>   * Copyright (C) 2016 Christoph Hellwig.
>   */
> -
> -#include <linux/acpi_iort.h>
>  #include <linux/err.h>
>  #include <linux/export.h>
>  #include <linux/irq.h>
> -#include <linux/irqdomain.h>
> -#include <linux/msi.h>
> -#include <linux/of_irq.h>
> -#include <linux/pci.h>
>  
>  #include "../pci.h"
> +#include "msi.h"
>  
>  static int pci_msi_enable = 1;
>  int pci_msi_ignore_mask;
>  
> -#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
> -
> -#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> -static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	struct irq_domain *domain;
> -
> -	domain = dev_get_msi_domain(&dev->dev);
> -	if (domain && irq_domain_is_hierarchy(domain))
> -		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
> -
> -	return arch_setup_msi_irqs(dev, nvec, type);
> -}
> -
> -static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	struct irq_domain *domain;
> -
> -	domain = dev_get_msi_domain(&dev->dev);
> -	if (domain && irq_domain_is_hierarchy(domain))
> -		msi_domain_free_irqs(domain, &dev->dev);
> -	else
> -		arch_teardown_msi_irqs(dev);
> -}
> -#else
> -#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
> -#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
> -#endif
> -
> -/*
> - * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
> - * mask all MSI interrupts by clearing the MSI enable bit does not work
> - * reliably as devices without an INTx disable bit will then generate a
> - * level IRQ which will never be cleared.
> - */
> -static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
> -{
> -	/* Don't shift by >= width of type */
> -	if (desc->pci.msi_attrib.multi_cap >= 5)
> -		return 0xffffffff;
> -	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
> -}
> -
>  static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
>  {
>  	raw_spinlock_t *lock = &desc->dev->msi_lock;
> @@ -903,23 +855,6 @@ void pci_disable_msix(struct pci_dev *de
>  }
>  EXPORT_SYMBOL(pci_disable_msix);
>  
> -void pci_no_msi(void)
> -{
> -	pci_msi_enable = 0;
> -}
> -
> -/**
> - * pci_msi_enabled - is MSI enabled?
> - *
> - * Returns true if MSI has not been disabled by the command-line option
> - * pci=nomsi.
> - **/
> -int pci_msi_enabled(void)
> -{
> -	return pci_msi_enable;
> -}
> -EXPORT_SYMBOL(pci_msi_enabled);
> -
>  static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
>  				  struct irq_affinity *affd)
>  {
> @@ -1195,253 +1130,19 @@ struct pci_dev *msi_desc_to_pci_dev(stru
>  }
>  EXPORT_SYMBOL(msi_desc_to_pci_dev);
>  
> -#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> -/**
> - * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
> - * @irq_data:	Pointer to interrupt data of the MSI interrupt
> - * @msg:	Pointer to the message
> - */
> -static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> -{
> -	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
> -
> -	/*
> -	 * For MSI-X desc->irq is always equal to irq_data->irq. For
> -	 * MSI only the first interrupt of MULTI MSI passes the test.
> -	 */
> -	if (desc->irq == irq_data->irq)
> -		__pci_write_msi_msg(desc, msg);
> -}
> -
> -/**
> - * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
> - * @desc:	Pointer to the MSI descriptor
> - *
> - * The ID number is only used within the irqdomain.
> - */
> -static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
> -{
> -	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
> -
> -	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
> -		pci_dev_id(dev) << 11 |
> -		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> -}
> -
> -static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
> -{
> -	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
> -}
> -
> -/**
> - * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
> - * 			      for @dev
> - * @domain:	The interrupt domain to check
> - * @info:	The domain info for verification
> - * @dev:	The device to check
> - *
> - * Returns:
> - *  0 if the functionality is supported
> - *  1 if Multi MSI is requested, but the domain does not support it
> - *  -ENOTSUPP otherwise
> - */
> -int pci_msi_domain_check_cap(struct irq_domain *domain,
> -			     struct msi_domain_info *info, struct device *dev)
> -{
> -	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
> -
> -	/* Special handling to support __pci_enable_msi_range() */
> -	if (pci_msi_desc_is_multi_msi(desc) &&
> -	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
> -		return 1;
> -	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
> -		return -ENOTSUPP;
> -
> -	return 0;
> -}
> -
> -static int pci_msi_domain_handle_error(struct irq_domain *domain,
> -				       struct msi_desc *desc, int error)
> -{
> -	/* Special handling to support __pci_enable_msi_range() */
> -	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
> -		return 1;
> -
> -	return error;
> -}
> -
> -static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
> -				    struct msi_desc *desc)
> -{
> -	arg->desc = desc;
> -	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
> -}
> -
> -static struct msi_domain_ops pci_msi_domain_ops_default = {
> -	.set_desc	= pci_msi_domain_set_desc,
> -	.msi_check	= pci_msi_domain_check_cap,
> -	.handle_error	= pci_msi_domain_handle_error,
> -};
> -
> -static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
> -{
> -	struct msi_domain_ops *ops = info->ops;
> -
> -	if (ops == NULL) {
> -		info->ops = &pci_msi_domain_ops_default;
> -	} else {
> -		if (ops->set_desc == NULL)
> -			ops->set_desc = pci_msi_domain_set_desc;
> -		if (ops->msi_check == NULL)
> -			ops->msi_check = pci_msi_domain_check_cap;
> -		if (ops->handle_error == NULL)
> -			ops->handle_error = pci_msi_domain_handle_error;
> -	}
> -}
> -
> -static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
> -{
> -	struct irq_chip *chip = info->chip;
> -
> -	BUG_ON(!chip);
> -	if (!chip->irq_write_msi_msg)
> -		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
> -	if (!chip->irq_mask)
> -		chip->irq_mask = pci_msi_mask_irq;
> -	if (!chip->irq_unmask)
> -		chip->irq_unmask = pci_msi_unmask_irq;
> -}
> -
> -/**
> - * pci_msi_create_irq_domain - Create a MSI interrupt domain
> - * @fwnode:	Optional fwnode of the interrupt controller
> - * @info:	MSI domain info
> - * @parent:	Parent irq domain
> - *
> - * Updates the domain and chip ops and creates a MSI interrupt domain.
> - *
> - * Returns:
> - * A domain pointer or NULL in case of failure.
> - */
> -struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
> -					     struct msi_domain_info *info,
> -					     struct irq_domain *parent)
> -{
> -	struct irq_domain *domain;
> -
> -	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
> -		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
> -
> -	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
> -		pci_msi_domain_update_dom_ops(info);
> -	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
> -		pci_msi_domain_update_chip_ops(info);
> -
> -	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
> -	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
> -		info->flags |= MSI_FLAG_MUST_REACTIVATE;
> -
> -	/* PCI-MSI is oneshot-safe */
> -	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
> -
> -	domain = msi_create_irq_domain(fwnode, info, parent);
> -	if (!domain)
> -		return NULL;
> -
> -	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
> -	return domain;
> -}
> -EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
> -
> -/*
> - * Users of the generic MSI infrastructure expect a device to have a single ID,
> - * so with DMA aliases we have to pick the least-worst compromise. Devices with
> - * DMA phantom functions tend to still emit MSIs from the real function number,
> - * so we ignore those and only consider topological aliases where either the
> - * alias device or RID appears on a different bus number. We also make the
> - * reasonable assumption that bridges are walked in an upstream direction (so
> - * the last one seen wins), and the much braver assumption that the most likely
> - * case is that of PCI->PCIe so we should always use the alias RID. This echoes
> - * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
> - * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
> - * for taking ownership all we can really do is close our eyes and hope...
> - */
> -static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
> -{
> -	u32 *pa = data;
> -	u8 bus = PCI_BUS_NUM(*pa);
> -
> -	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
> -		*pa = alias;
> -
> -	return 0;
> -}
> -
> -/**
> - * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
> - * @domain:	The interrupt domain
> - * @pdev:	The PCI device.
> - *
> - * The RID for a device is formed from the alias, with a firmware
> - * supplied mapping applied
> - *
> - * Returns: The RID.
> - */
> -u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
> -{
> -	struct device_node *of_node;
> -	u32 rid = pci_dev_id(pdev);
> -
> -	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> -
> -	of_node = irq_domain_get_of_node(domain);
> -	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
> -			iort_msi_map_id(&pdev->dev, rid);
> -
> -	return rid;
> -}
> -
> -/**
> - * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
> - * @pdev:	The PCI device
> - *
> - * Use the firmware data to find a device-specific MSI domain
> - * (i.e. not one that is set as a default).
> - *
> - * Returns: The corresponding MSI domain or NULL if none has been found.
> - */
> -struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
> +void pci_no_msi(void)
>  {
> -	struct irq_domain *dom;
> -	u32 rid = pci_dev_id(pdev);
> -
> -	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> -	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
> -	if (!dom)
> -		dom = iort_get_device_domain(&pdev->dev, rid,
> -					     DOMAIN_BUS_PCI_MSI);
> -	return dom;
> +	pci_msi_enable = 0;
>  }
>  
>  /**
> - * pci_dev_has_special_msi_domain - Check whether the device is handled by
> - *				    a non-standard PCI-MSI domain
> - * @pdev:	The PCI device to check.
> + * pci_msi_enabled - is MSI enabled?
>   *
> - * Returns: True if the device irqdomain or the bus irqdomain is
> - * non-standard PCI/MSI.
> - */
> -bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
> + * Returns true if MSI has not been disabled by the command-line option
> + * pci=nomsi.
> + **/
> +int pci_msi_enabled(void)
>  {
> -	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
> -
> -	if (!dom)
> -		dom = dev_get_msi_domain(&pdev->bus->dev);
> -
> -	if (!dom)
> -		return true;
> -
> -	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
> +	return pci_msi_enable;
>  }
> -
> -#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
> +EXPORT_SYMBOL(pci_msi_enabled);
> --- /dev/null
> +++ b/drivers/pci/msi/msi.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#include <linux/pci.h>
> +#include <linux/msi.h>
> +
> +#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
> +
> +extern int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
> +extern void pci_msi_teardown_msi_irqs(struct pci_dev *dev);
> +
> +#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
> +extern int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
> +extern void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev);
> +#else
> +static inline int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	WARN_ON_ONCE(1);
> +	return -ENODEV;
> +}
> +
> +static inline void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	WARN_ON_ONCE(1);
> +}
> +#endif
> +
> +/*
> + * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
> + * mask all MSI interrupts by clearing the MSI enable bit does not work
> + * reliably as devices without an INTx disable bit will then generate a
> + * level IRQ which will never be cleared.
> + */
> +static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
> +{
> +	/* Don't shift by >= width of type */
> +	if (desc->pci.msi_attrib.multi_cap >= 5)
> +		return 0xffffffff;
> +	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
> +}
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -259,17 +259,6 @@ int arch_setup_msi_irq(struct pci_dev *d
>  void arch_teardown_msi_irq(unsigned int irq);
>  int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
>  void arch_teardown_msi_irqs(struct pci_dev *dev);
> -#else
> -static inline int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	WARN_ON_ONCE(1);
> -	return -ENODEV;
> -}
> -
> -static inline void arch_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	WARN_ON_ONCE(1);
> -}
>  #endif
>  
>  /*
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:01:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:01:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241857.418399 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhaR-00018j-Qk; Tue, 07 Dec 2021 21:01:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241857.418399; Tue, 07 Dec 2021 21:01:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhaR-00018c-Na; Tue, 07 Dec 2021 21:01:19 +0000
Received: by outflank-mailman (input) for mailman id 241857;
 Tue, 07 Dec 2021 21:01:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhaQ-00014s-4F
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:01:18 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d152ab87-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:01:17 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 68F02CE1E7E;
 Tue,  7 Dec 2021 21:01:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3297C341D8;
 Tue,  7 Dec 2021 21:01:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d152ab87-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910872;
	bh=ybqLZ92i+grI5yfbGrTDeuksmJCOFi+gglGxwe9SamU=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=TMUWYC/mv0B6gIw9DnRHd2zTabDMDtD755n0HABL/tcoqSE7ZcCnd0dDbsDaoGmvK
	 qSODOct9cMbGDUGaQMGz23hZcH9TolzNE91WbMR1Is6JY9P7bOVw1YsTR4FzKBLaf9
	 Le+C7vjuOPwgxJcdSYAXoABWYbIQoh0hnYJqcmKa/wpN/Q1nRm8km9tdJkdCx2jmEX
	 fsf36dBLTPbeG7aB0lTQj2KpKmjk75YkmrWt1HFRo19aRculiS/sfLvaOedfplt04D
	 DN4WnjTjinZPEIZIHd2BJZNhCHE1Yq/9m5G9O6M/Xzerap0qhtoeEABEaeo9Bwqnki
	 GYfTLw7geSrJg==
Date: Tue, 7 Dec 2021 15:01:10 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 19/23] PCI/MSI: Sanitize MSIX table map handling
Message-ID: <20211207210110.GA77246@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.871651518@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:54PM +0100, Thomas Gleixner wrote:
> Unmapping the MSIX base mapping in the loops which allocate/free MSI
> desciptors is daft and in the way of allowing runtime expansion of MSI-X
> descriptors.

s/MSIX/MSI-X/ (subject and first use in commit log)
s/desciptors/descriptors/

> Store the mapping in struct pci_dev and free it after freeing the MSI-X
> descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/msi.c |   18 ++++++++----------
>  include/linux/pci.h   |    1 +
>  2 files changed, 9 insertions(+), 10 deletions(-)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -241,14 +241,14 @@ static void free_msi_irqs(struct pci_dev
>  	pci_msi_teardown_msi_irqs(dev);
>  
>  	list_for_each_entry_safe(entry, tmp, msi_list, list) {
> -		if (entry->pci.msi_attrib.is_msix) {
> -			if (list_is_last(&entry->list, msi_list))
> -				iounmap(entry->pci.mask_base);
> -		}
> -
>  		list_del(&entry->list);
>  		free_msi_entry(entry);
>  	}
> +
> +	if (dev->msix_base) {
> +		iounmap(dev->msix_base);
> +		dev->msix_base = NULL;
> +	}
>  }
>  
>  static void pci_intx_for_msi(struct pci_dev *dev, int enable)
> @@ -501,10 +501,6 @@ static int msix_setup_entries(struct pci
>  	for (i = 0, curmsk = masks; i < nvec; i++) {
>  		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
>  		if (!entry) {
> -			if (!i)
> -				iounmap(base);
> -			else
> -				free_msi_irqs(dev);
>  			/* No enough memory. Don't try again */
>  			ret = -ENOMEM;
>  			goto out;
> @@ -602,12 +598,14 @@ static int msix_capability_init(struct p
>  		goto out_disable;
>  	}
>  
> +	dev->msix_base = base;
> +
>  	/* Ensure that all table entries are masked. */
>  	msix_mask_all(base, tsize);
>  
>  	ret = msix_setup_entries(dev, base, entries, nvec, affd);
>  	if (ret)
> -		goto out_disable;
> +		goto out_free;
>  
>  	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
>  	if (ret)
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -473,6 +473,7 @@ struct pci_dev {
>  	u8		ptm_granularity;
>  #endif
>  #ifdef CONFIG_PCI_MSI
> +	void __iomem	*msix_base;
>  	const struct attribute_group **msi_irq_groups;
>  #endif
>  	struct pci_vpd	vpd;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:01:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241860.418409 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhac-0001Uf-2H; Tue, 07 Dec 2021 21:01:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241860.418409; Tue, 07 Dec 2021 21:01:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhab-0001UY-VE; Tue, 07 Dec 2021 21:01:29 +0000
Received: by outflank-mailman (input) for mailman id 241860;
 Tue, 07 Dec 2021 21:01:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhaa-0001Tg-R6
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:01:28 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d818e1f2-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:01:27 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 98CDFB81E87;
 Tue,  7 Dec 2021 21:01:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDBF1C341C6;
 Tue,  7 Dec 2021 21:01:26 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d818e1f2-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910887;
	bh=KswCIrDmmz+hcDnAj7scewOtghNKAUSvlR/YL46B2y4=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=uu5zBvm54PthoHMlAqMnKRp9In+QOttow33Sbz7fEJ6O739+SKVMNcj0eNux2Q1Fm
	 ClUIhicQb0fbu7dNnC5RUJc8cgV1kAUjfZKalR6pgWyzBP5HyLTWLSqil36RtKbcDM
	 nqVi0ewcV8haHkpihS2wEZ6W406lbkA9hAmoJYBBNhdiTOCAQEDa24Jm2l0Hw6e3ko
	 tU0U/GoEd9YCrvWvapKu9DPDHWTw8UAwhom8fGjgSe6puuiXErpmMgBAhsH2nykktX
	 lzB/yMVW0IXZVQGumZ7IMNW/rs3/0hjKex87BhLox/oRgleVnT9TL1qDc5II4Yygcs
	 8zJbA1ld5WgZg==
Date: Tue, 7 Dec 2021 15:01:25 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 20/23] PCI/MSI: Move msi_lock to struct pci_dev
Message-ID: <20211207210125.GA77339@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.925241961@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:56PM +0100, Thomas Gleixner wrote:
> It's only required for PCI/MSI. So no point in having it in every struct
> device.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> V2: New patch
> ---
>  drivers/base/core.c    |    1 -
>  drivers/pci/msi/msi.c  |    2 +-
>  drivers/pci/probe.c    |    4 +++-
>  include/linux/device.h |    2 --
>  include/linux/pci.h    |    1 +
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2875,7 +2875,6 @@ void device_initialize(struct device *de
>  	device_pm_init(dev);
>  	set_dev_node(dev, NUMA_NO_NODE);
>  #ifdef CONFIG_GENERIC_MSI_IRQ
> -	raw_spin_lock_init(&dev->msi_lock);
>  	INIT_LIST_HEAD(&dev->msi_list);
>  #endif
>  	INIT_LIST_HEAD(&dev->links.consumers);
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -18,7 +18,7 @@ int pci_msi_ignore_mask;
>  
>  static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
>  {
> -	raw_spinlock_t *lock = &desc->dev->msi_lock;
> +	raw_spinlock_t *lock = &to_pci_dev(desc->dev)->msi_lock;
>  	unsigned long flags;
>  
>  	if (!desc->pci.msi_attrib.can_mask)
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -2311,7 +2311,9 @@ struct pci_dev *pci_alloc_dev(struct pci
>  	INIT_LIST_HEAD(&dev->bus_list);
>  	dev->dev.type = &pci_dev_type;
>  	dev->bus = pci_bus_get(bus);
> -
> +#ifdef CONFIG_PCI_MSI
> +	raw_spin_lock_init(&dev->msi_lock);
> +#endif
>  	return dev;
>  }
>  EXPORT_SYMBOL(pci_alloc_dev);
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -407,7 +407,6 @@ struct dev_links_info {
>   * @em_pd:	device's energy model performance domain
>   * @pins:	For device pin management.
>   *		See Documentation/driver-api/pin-control.rst for details.
> - * @msi_lock:	Lock to protect MSI mask cache and mask register
>   * @msi_list:	Hosts MSI descriptors
>   * @msi_domain: The generic MSI domain this device is using.
>   * @numa_node:	NUMA node this device is close to.
> @@ -508,7 +507,6 @@ struct device {
>  	struct dev_pin_info	*pins;
>  #endif
>  #ifdef CONFIG_GENERIC_MSI_IRQ
> -	raw_spinlock_t		msi_lock;
>  	struct list_head	msi_list;
>  #endif
>  #ifdef CONFIG_DMA_OPS
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -474,6 +474,7 @@ struct pci_dev {
>  #endif
>  #ifdef CONFIG_PCI_MSI
>  	void __iomem	*msix_base;
> +	raw_spinlock_t	msi_lock;
>  	const struct attribute_group **msi_irq_groups;
>  #endif
>  	struct pci_vpd	vpd;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:02:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:02:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241869.418421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhb7-0002HD-C5; Tue, 07 Dec 2021 21:02:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241869.418421; Tue, 07 Dec 2021 21:02:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhb7-0002H4-8i; Tue, 07 Dec 2021 21:02:01 +0000
Received: by outflank-mailman (input) for mailman id 241869;
 Tue, 07 Dec 2021 21:01:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhb5-0001Tg-RV
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:01:59 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eac077ff-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:01:58 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id C9098B81E8E;
 Tue,  7 Dec 2021 21:01:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25EABC341C6;
 Tue,  7 Dec 2021 21:01:57 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eac077ff-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910917;
	bh=Xx5Xlrv9sa2u5A/Kpn/Dg/C1KiusFx7+1t0Q3ZaD6H0=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=n8AstkO1bzz/peccJoNv+OV8w4azVbrZfSQZ+C6VrByvWmPCcuA2UoeLK7KF47R8L
	 vZst3jSGZu4YUxnifcSqUb1O35ur9epBYuG/DP/WQ/icPCZjzW/3TXclIKDXlqCJoX
	 tc18Sbi36Aj0D6NsekqSM+82EIrp06HXxtNuS66W7DP7eTGFxuQRp9F7qgu1/oS6Nh
	 EiQZ2fSjwcXjKQPTB0uzie9HLe4wME36g/iRUJWHldf2e/7IFERXGSfGEslP0xR4VZ
	 V4I9BEz7rWwPqwC+sNYmCoDe+CD/nvsXq9LjxicUETpYVVdLu043m0E8HlLj60v+3X
	 HUdygMtqlpOxw==
Date: Tue, 7 Dec 2021 15:01:56 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 21/23] PCI/MSI: Make pci_msi_domain_check_cap() static
Message-ID: <20211207210156.GA77414@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.980989243@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:57PM +0100, Thomas Gleixner wrote:
> No users outside of that file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |    5 +++--
>  include/linux/msi.h         |    2 --
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -79,8 +79,9 @@ static inline bool pci_msi_desc_is_multi
>   *  1 if Multi MSI is requested, but the domain does not support it
>   *  -ENOTSUPP otherwise
>   */
> -int pci_msi_domain_check_cap(struct irq_domain *domain,
> -			     struct msi_domain_info *info, struct device *dev)
> +static int pci_msi_domain_check_cap(struct irq_domain *domain,
> +				    struct msi_domain_info *info,
> +				    struct device *dev)
>  {
>  	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
>  
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -439,8 +439,6 @@ void *platform_msi_get_host_data(struct
>  struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
>  					     struct msi_domain_info *info,
>  					     struct irq_domain *parent);
> -int pci_msi_domain_check_cap(struct irq_domain *domain,
> -			     struct msi_domain_info *info, struct device *dev);
>  u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev);
>  struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev);
>  bool pci_dev_has_special_msi_domain(struct pci_dev *pdev);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:02:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:02:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241874.418432 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhbn-0002sr-Kn; Tue, 07 Dec 2021 21:02:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241874.418432; Tue, 07 Dec 2021 21:02:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhbn-0002sk-HN; Tue, 07 Dec 2021 21:02:43 +0000
Received: by outflank-mailman (input) for mailman id 241874;
 Tue, 07 Dec 2021 21:02:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhbm-0001Tg-4T
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:02:42 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 03ed57c5-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:02:41 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 0ED39B81E85;
 Tue,  7 Dec 2021 21:02:41 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DF0FC341C1;
 Tue,  7 Dec 2021 21:02:39 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03ed57c5-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910959;
	bh=xQoYzuJZBtazlb9l9/rEZFpq4l8ZITO51ml+vNgPc6M=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=e153nty81BUAPS50lzOeG3i/XMpm26Pk8TGxhpDoheH+aGOAhJjiCObFncc/cOH46
	 OXARkgcqJJlGa0F/Bsl/N/Hr8iyx5YBElDJEc4KBNNajc4emj6cdjk7cQoxzm32rM6
	 wS8QDvcYSbelmRSilLFSFpzwM4nEMGo1OciLG1fy1ib0RAXNhpEhAgwC7XOVLwtEMg
	 hUh+UVjgpZDPJcdCSkYndl3E5r7GBkkzKgk8s3NaLe/CmCRfbyieQFOca/oFRIERXj
	 HKyqHP6oyciLgO6YSOX23lsQkoLBX7Z1J+QJANGpc3FC3xvrJLcihkCi836KsOw4gQ
	 4SgZq/E6VBAOQ==
Date: Tue, 7 Dec 2021 15:02:38 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 23/23] PCI/MSI: Move descriptor counting on allocation
 fail to the legacy code
Message-ID: <20211207210238.GA77554@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210225.101336873@linutronix.de>

On Mon, Dec 06, 2021 at 11:28:00PM +0100, Thomas Gleixner wrote:
> The irqdomain code already returns the information. Move the loop to the
> legacy code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/legacy.c |   20 +++++++++++++++++++-
>  drivers/pci/msi/msi.c    |   19 +------------------
>  2 files changed, 20 insertions(+), 19 deletions(-)
> 
> --- a/drivers/pci/msi/legacy.c
> +++ b/drivers/pci/msi/legacy.c
> @@ -50,9 +50,27 @@ void __weak arch_teardown_msi_irqs(struc
>  	}
>  }
>  
> +static int pci_msi_setup_check_result(struct pci_dev *dev, int type, int ret)
> +{
> +	struct msi_desc *entry;
> +	int avail = 0;
> +
> +	if (type != PCI_CAP_ID_MSIX || ret >= 0)
> +		return ret;
> +
> +	/* Scan the MSI descriptors for successfully allocated ones. */
> +	for_each_pci_msi_entry(entry, dev) {
> +		if (entry->irq != 0)
> +			avail++;
> +	}
> +	return avail ? avail : ret;
> +}
> +
>  int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
>  {
> -	return arch_setup_msi_irqs(dev, nvec, type);
> +	int ret = arch_setup_msi_irqs(dev, nvec, type);
> +
> +	return pci_msi_setup_check_result(dev, type, ret);
>  }
>  
>  void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -609,7 +609,7 @@ static int msix_capability_init(struct p
>  
>  	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
>  	if (ret)
> -		goto out_avail;
> +		goto out_free;
>  
>  	/* Check if all MSI entries honor device restrictions */
>  	ret = msi_verify_entries(dev);
> @@ -634,23 +634,6 @@ static int msix_capability_init(struct p
>  	pcibios_free_irq(dev);
>  	return 0;
>  
> -out_avail:
> -	if (ret < 0) {
> -		/*
> -		 * If we had some success, report the number of IRQs
> -		 * we succeeded in setting up.
> -		 */
> -		struct msi_desc *entry;
> -		int avail = 0;
> -
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->irq != 0)
> -				avail++;
> -		}
> -		if (avail != 0)
> -			ret = avail;
> -	}
> -
>  out_free:
>  	free_msi_irqs(dev);
>  
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:03:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:03:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241881.418443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhcs-0003Xp-V0; Tue, 07 Dec 2021 21:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241881.418443; Tue, 07 Dec 2021 21:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhcs-0003Xi-RW; Tue, 07 Dec 2021 21:03:50 +0000
Received: by outflank-mailman (input) for mailman id 241881;
 Tue, 07 Dec 2021 21:03:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhcr-0003XP-RQ
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:03:49 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c4a3ead-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:03:48 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 644DEB81E83;
 Tue,  7 Dec 2021 21:03:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3146C341C3;
 Tue,  7 Dec 2021 21:03:46 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c4a3ead-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911027;
	bh=vdg+fdIoCSHr3OuhnQ0WRPeCcsFTBIQTTd4u0ji8WKw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=BWMnoqb5zI+AmfRiWx3hI7UPFSjiK/sP2RxrS/8pFSfaQGXzC3HU5dj9jSSkTmxbf
	 ycQhxHGG+Fcj7qVvDrSdgVJzP+m2Fjh741SbIXpMXFhrEEquIdcMBPdXl+aCsQmDEI
	 3zeK6GYY3etemeN1yu/6VsPnz0YoMH8zSdcDzIsPZqnlh4gHq48kIVDNWK7rfFTy1S
	 gUW/xdBLJLcAxyL2Qhdnp0jAybfRKhRZLoNsDlD33Kr8AWcXVe4iBXGW98+dAzo2jz
	 rnorth7z8Yvh3+kr56v1pmkD4iYXulFwuR50cFJdivxqVn0FvmmJNz1QRCJTf0dRQk
	 vTu+UFqcSYVkw==
Date: Tue, 7 Dec 2021 15:03:45 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 03/36] PCI/MSI: Allocate MSI device data on first use
Message-ID: <20211207210345.GA77648@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210437.821900680@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:00PM +0100, Thomas Gleixner wrote:
> Allocate MSI device data on first use, i.e. when a PCI driver invokes one
> of the PCI/MSI enablement functions.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/msi.c |   20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -889,10 +889,12 @@ static int __pci_enable_msi_range(struct
>  /* deprecated, don't use */
>  int pci_enable_msi(struct pci_dev *dev)
>  {
> -	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
> -	if (rc < 0)
> -		return rc;
> -	return 0;
> +	int rc = msi_setup_device_data(&dev->dev);
> +
> +	if (!rc)
> +		rc = __pci_enable_msi_range(dev, 1, 1, NULL);
> +
> +	return rc < 0 ? rc : 0;
>  }
>  EXPORT_SYMBOL(pci_enable_msi);
>  
> @@ -947,7 +949,11 @@ static int __pci_enable_msix_range(struc
>  int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
>  		int minvec, int maxvec)
>  {
> -	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
> +	int ret = msi_setup_device_data(&dev->dev);
> +
> +	if (!ret)
> +		ret = __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
> +	return ret;
>  }
>  EXPORT_SYMBOL(pci_enable_msix_range);
>  
> @@ -974,8 +980,12 @@ int pci_alloc_irq_vectors_affinity(struc
>  				   struct irq_affinity *affd)
>  {
>  	struct irq_affinity msi_default_affd = {0};
> +	int ret = msi_setup_device_data(&dev->dev);
>  	int nvecs = -ENOSPC;
>  
> +	if (ret)
> +		return ret;
> +
>  	if (flags & PCI_IRQ_AFFINITY) {
>  		if (!affd)
>  			affd = &msi_default_affd;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:04:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241886.418453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhdP-00046R-7Q; Tue, 07 Dec 2021 21:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241886.418453; Tue, 07 Dec 2021 21:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhdP-00046K-4H; Tue, 07 Dec 2021 21:04:23 +0000
Received: by outflank-mailman (input) for mailman id 241886;
 Tue, 07 Dec 2021 21:04:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhdN-0003Ww-AD
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:04:21 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3ddb28b9-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:04:19 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 0B225CE1E6D;
 Tue,  7 Dec 2021 21:04:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2EFCC341C3;
 Tue,  7 Dec 2021 21:04:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ddb28b9-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911056;
	bh=Xo6O3jGlzOANOmR4B4AaNenI/3W1MbWz8sJEDkoXKaA=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=U244wwsKXfLaRSba10m6gANWp5kb5rrKjuv8gVTFk236rfqvdIer5hktfEtuaXLPq
	 BJ3e6kiGjgdY/544N3aZs5NyCPVUyrijSIV4zfcTm8y+ZSmfE/rUj+EdTDlvhYv6lh
	 6LGuSbitHQ2cBwVEDjbUKzVmrdMZGhbfZZZZyAqNq8+VrLZV2Hbhb0Yx12m1M5hGK0
	 i7S8L5dDlelB4EdCDNKZH9QgFSFwAL3gwNRVDlp95/CQ6bo58UgFcjHZVwlu5rUY4b
	 8JDHSpfF/UG/BKzFhhHH1qVx91UaU9AaWRpxNjJFeZGYwBjD168V/EE2a6WPNO+j76
	 DtG1dxs1QDegA==
Date: Tue, 7 Dec 2021 15:04:14 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 08/36] PCI/MSI: Let the irq code handle sysfs groups
Message-ID: <20211207210414.GA77702@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.091930107@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:09PM +0100, Thomas Gleixner wrote:
> Set the domain info flag which makes the core code handle sysfs groups and
> put an explicit invocation into the legacy code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |    2 +-
>  drivers/pci/msi/legacy.c    |    6 +++++-
>  drivers/pci/msi/msi.c       |   23 -----------------------
>  include/linux/pci.h         |    1 -
>  4 files changed, 6 insertions(+), 26 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -159,7 +159,7 @@ struct irq_domain *pci_msi_create_irq_do
>  	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
>  		pci_msi_domain_update_chip_ops(info);
>  
> -	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
> +	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS;
>  	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
>  		info->flags |= MSI_FLAG_MUST_REACTIVATE;
>  
> --- a/drivers/pci/msi/legacy.c
> +++ b/drivers/pci/msi/legacy.c
> @@ -70,10 +70,14 @@ int pci_msi_legacy_setup_msi_irqs(struct
>  {
>  	int ret = arch_setup_msi_irqs(dev, nvec, type);
>  
> -	return pci_msi_setup_check_result(dev, type, ret);
> +	ret = pci_msi_setup_check_result(dev, type, ret);
> +	if (!ret)
> +		ret = msi_device_populate_sysfs(&dev->dev);
> +	return ret;
>  }
>  
>  void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
>  {
> +	msi_device_destroy_sysfs(&dev->dev);
>  	arch_teardown_msi_irqs(dev);
>  }
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -233,11 +233,6 @@ static void free_msi_irqs(struct pci_dev
>  			for (i = 0; i < entry->nvec_used; i++)
>  				BUG_ON(irq_has_action(entry->irq + i));
>  
> -	if (dev->msi_irq_groups) {
> -		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
> -		dev->msi_irq_groups = NULL;
> -	}
> -
>  	pci_msi_teardown_msi_irqs(dev);
>  
>  	list_for_each_entry_safe(entry, tmp, msi_list, list) {
> @@ -417,7 +412,6 @@ static int msi_verify_entries(struct pci
>  static int msi_capability_init(struct pci_dev *dev, int nvec,
>  			       struct irq_affinity *affd)
>  {
> -	const struct attribute_group **groups;
>  	struct msi_desc *entry;
>  	int ret;
>  
> @@ -441,14 +435,6 @@ static int msi_capability_init(struct pc
>  	if (ret)
>  		goto err;
>  
> -	groups = msi_populate_sysfs(&dev->dev);
> -	if (IS_ERR(groups)) {
> -		ret = PTR_ERR(groups);
> -		goto err;
> -	}
> -
> -	dev->msi_irq_groups = groups;
> -
>  	/* Set MSI enabled bits	*/
>  	pci_intx_for_msi(dev, 0);
>  	pci_msi_set_enable(dev, 1);
> @@ -576,7 +562,6 @@ static void msix_mask_all(void __iomem *
>  static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
>  				int nvec, struct irq_affinity *affd)
>  {
> -	const struct attribute_group **groups;
>  	void __iomem *base;
>  	int ret, tsize;
>  	u16 control;
> @@ -618,14 +603,6 @@ static int msix_capability_init(struct p
>  
>  	msix_update_entries(dev, entries);
>  
> -	groups = msi_populate_sysfs(&dev->dev);
> -	if (IS_ERR(groups)) {
> -		ret = PTR_ERR(groups);
> -		goto out_free;
> -	}
> -
> -	dev->msi_irq_groups = groups;
> -
>  	/* Set MSI-X enabled bits and unmask the function */
>  	pci_intx_for_msi(dev, 0);
>  	dev->msix_enabled = 1;
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -475,7 +475,6 @@ struct pci_dev {
>  #ifdef CONFIG_PCI_MSI
>  	void __iomem	*msix_base;
>  	raw_spinlock_t	msi_lock;
> -	const struct attribute_group **msi_irq_groups;
>  #endif
>  	struct pci_vpd	vpd;
>  #ifdef CONFIG_PCIE_DPC
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:04:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:04:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241891.418465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhdt-0004kf-Kb; Tue, 07 Dec 2021 21:04:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241891.418465; Tue, 07 Dec 2021 21:04:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhdt-0004kY-H6; Tue, 07 Dec 2021 21:04:53 +0000
Received: by outflank-mailman (input) for mailman id 241891;
 Tue, 07 Dec 2021 21:04:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhds-0003XP-5E
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:04:52 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 505a4b3a-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:04:50 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 0352CCE1E73;
 Tue,  7 Dec 2021 21:04:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C900EC341C1;
 Tue,  7 Dec 2021 21:04:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 505a4b3a-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911085;
	bh=4LqouiflKAdNmyzI14DusWvBDIHM7i2qiOmUjncfYKg=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=RQOVer6mBex/l6+4wBSe2LYCuoLmvk9+eU9Tq2oxaGgZR9L9L74vmrqxzeosU0eE9
	 ngdMyHKP5La85fcbVOhVbgSZHUQrTKSV1US2oehAiQe/6Ias9lqhsb5GEJLks5EeEy
	 mo4f+CZ/w2OPEKkKFazbq8XQduz8HU/ObusTgF12SY3kxmUjd5Qdhy+3RSW/AryDfK
	 X+IsdlZQ3kGBXRwHP3LNK6MMH25JOlNXi6N6rhNUEfsXPhpIWtoRZMCU0gdxCCHL/L
	 nDT1H9tx0b73229NJhpwgnECznerrpC0B04ucF3JYsTi7juBMcjAU8xvXnRSBGgYgm
	 WRp7vAKGZDoYw==
Date: Tue, 7 Dec 2021 15:04:43 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 17/36] PCI/MSI: Use msi_desc::msi_index
Message-ID: <20211207210443.GA77781@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.580265315@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:23PM +0100, Thomas Gleixner wrote:
> The usage of msi_desc::pci::entry_nr is confusing at best. It's the index
> into the MSI[X] descriptor table.
> 
> Use msi_desc::msi_index which is shared between all MSI incarnations
> instead of having a PCI specific storage for no value.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  arch/powerpc/platforms/pseries/msi.c |    4 ++--
>  arch/x86/pci/xen.c                   |    2 +-
>  drivers/pci/msi/irqdomain.c          |    2 +-
>  drivers/pci/msi/msi.c                |   20 ++++++++------------
>  drivers/pci/xen-pcifront.c           |    2 +-
>  include/linux/msi.h                  |    2 --
>  6 files changed, 13 insertions(+), 19 deletions(-)
> 
> --- a/arch/powerpc/platforms/pseries/msi.c
> +++ b/arch/powerpc/platforms/pseries/msi.c
> @@ -332,7 +332,7 @@ static int check_msix_entries(struct pci
>  
>  	expected = 0;
>  	for_each_pci_msi_entry(entry, pdev) {
> -		if (entry->pci.msi_attrib.entry_nr != expected) {
> +		if (entry->msi_index != expected) {
>  			pr_debug("rtas_msi: bad MSI-X entries.\n");
>  			return -EINVAL;
>  		}
> @@ -580,7 +580,7 @@ static int pseries_irq_domain_alloc(stru
>  	int hwirq;
>  	int i, ret;
>  
> -	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->pci.msi_attrib.entry_nr);
> +	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->msi_index);
>  	if (hwirq < 0) {
>  		dev_err(&pdev->dev, "Failed to query HW IRQ: %d\n", hwirq);
>  		return hwirq;
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -306,7 +306,7 @@ static int xen_initdom_setup_msi_irqs(st
>  				return -EINVAL;
>  
>  			map_irq.table_base = pci_resource_start(dev, bir);
> -			map_irq.entry_nr = msidesc->pci.msi_attrib.entry_nr;
> +			map_irq.entry_nr = msidesc->msi_index;
>  		}
>  
>  		ret = -EINVAL;
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -57,7 +57,7 @@ static irq_hw_number_t pci_msi_domain_ca
>  {
>  	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
>  
> -	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
> +	return (irq_hw_number_t)desc->msi_index |
>  		pci_dev_id(dev) << 11 |
>  		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
>  }
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -44,7 +44,7 @@ static inline void pci_msi_unmask(struct
>  
>  static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
>  {
> -	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
> +	return desc->pci.mask_base + desc->msi_index * PCI_MSIX_ENTRY_SIZE;
>  }
>  
>  /*
> @@ -356,13 +356,10 @@ msi_setup_entry(struct pci_dev *dev, int
>  	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
>  		control |= PCI_MSI_FLAGS_MASKBIT;
>  
> -	entry->pci.msi_attrib.is_msix	= 0;
> -	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
> -	entry->pci.msi_attrib.is_virtual    = 0;
> -	entry->pci.msi_attrib.entry_nr	= 0;
> +	entry->pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
>  	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>  					  !!(control & PCI_MSI_FLAGS_MASKBIT);
> -	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
> +	entry->pci.msi_attrib.default_irq = dev->irq;
>  	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
>  	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
>  
> @@ -496,12 +493,11 @@ static int msix_setup_entries(struct pci
>  		entry->pci.msi_attrib.is_64	= 1;
>  
>  		if (entries)
> -			entry->pci.msi_attrib.entry_nr = entries[i].entry;
> +			entry->msi_index = entries[i].entry;
>  		else
> -			entry->pci.msi_attrib.entry_nr = i;
> +			entry->msi_index = i;
>  
> -		entry->pci.msi_attrib.is_virtual =
> -			entry->pci.msi_attrib.entry_nr >= vec_count;
> +		entry->pci.msi_attrib.is_virtual = entry->msi_index >= vec_count;
>  
>  		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
>  						  !entry->pci.msi_attrib.is_virtual;
> @@ -1034,7 +1030,7 @@ int pci_irq_vector(struct pci_dev *dev,
>  		struct msi_desc *entry;
>  
>  		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->pci.msi_attrib.entry_nr == nr)
> +			if (entry->msi_index == nr)
>  				return entry->irq;
>  		}
>  		WARN_ON_ONCE(1);
> @@ -1073,7 +1069,7 @@ const struct cpumask *pci_irq_get_affini
>  		struct msi_desc *entry;
>  
>  		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->pci.msi_attrib.entry_nr == nr)
> +			if (entry->msi_index == nr)
>  				return &entry->affinity->mask;
>  		}
>  		WARN_ON_ONCE(1);
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -263,7 +263,7 @@ static int pci_frontend_enable_msix(stru
>  
>  	i = 0;
>  	for_each_pci_msi_entry(entry, dev) {
> -		op.msix_entries[i].entry = entry->pci.msi_attrib.entry_nr;
> +		op.msix_entries[i].entry = entry->msi_index;
>  		/* Vector is useless at this point. */
>  		op.msix_entries[i].vector = -1;
>  		i++;
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -80,7 +80,6 @@ typedef void (*irq_write_msi_msg_t)(stru
>   * @multi_cap:	[PCI MSI/X] log2 num of messages supported
>   * @can_mask:	[PCI MSI/X] Masking supported?
>   * @is_64:	[PCI MSI/X] Address size: 0=32bit 1=64bit
> - * @entry_nr:	[PCI MSI/X] Entry which is described by this descriptor
>   * @default_irq:[PCI MSI/X] The default pre-assigned non-MSI irq
>   * @mask_pos:	[PCI MSI]   Mask register position
>   * @mask_base:	[PCI MSI-X] Mask register base address
> @@ -97,7 +96,6 @@ struct pci_msi_desc {
>  		u8	can_mask	: 1;
>  		u8	is_64		: 1;
>  		u8	is_virtual	: 1;
> -		u16	entry_nr;
>  		unsigned default_irq;
>  	} msi_attrib;
>  	union {
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:05:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:05:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241892.418476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhe7-00058H-T3; Tue, 07 Dec 2021 21:05:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241892.418476; Tue, 07 Dec 2021 21:05:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhe7-00058A-Pj; Tue, 07 Dec 2021 21:05:07 +0000
Received: by outflank-mailman (input) for mailman id 241892;
 Tue, 07 Dec 2021 21:05:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhe6-0003XP-R5
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:05:06 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a6f9367-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:05:06 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id CEB9BB81E89;
 Tue,  7 Dec 2021 21:05:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4744FC341C1;
 Tue,  7 Dec 2021 21:05:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a6f9367-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911104;
	bh=B1uq1LxQ+zV7OmdTOwCRtNnO2jvBQqZ4s4dpqK7FSx0=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=FtAnSeLche3tDfxYR56d58ANFwkYFafEMJxsxNrKfqKSblB85o+rbHYZ0oIIlySDv
	 tsgfTCkxzfo51fNQXVhI9AfB029y60Tf37iykBBNUPrO9avyXhGWg3TNkVZDa3+bLl
	 MKDQoxA+9Eb/eCVob/myMBPCDOUC7Lks1kDQXL/5zr8Jhktfir9G8Gj5qdNVWJyvmY
	 nSUYSnGBdz6NxEsdbnDrce0qOvuWXhcMslMcv0JD/Q3qxC0C9Ez3+52Iiaa26ekY+F
	 2GXwtyHKPUf3jS2KFP70m0i6puvts4TC/fan1RswEtNWghn5k8zw3s0sx0LXHK3Kax
	 bg5UGKj2mjoaA==
Date: Tue, 7 Dec 2021 15:05:03 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
Message-ID: <20211207210503.GA77830@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.688216619@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
> Store the properties which are interesting for various places so the MSI
> descriptor fiddling can be removed.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> V2: Use the setter function
> ---
>  drivers/pci/msi/msi.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -244,6 +244,8 @@ static void free_msi_irqs(struct pci_dev
>  		iounmap(dev->msix_base);
>  		dev->msix_base = NULL;
>  	}
> +
> +	msi_device_set_properties(&dev->dev, 0);
>  }
>  
>  static void pci_intx_for_msi(struct pci_dev *dev, int enable)
> @@ -341,6 +343,7 @@ msi_setup_entry(struct pci_dev *dev, int
>  {
>  	struct irq_affinity_desc *masks = NULL;
>  	struct msi_desc *entry;
> +	unsigned long prop;
>  	u16 control;
>  
>  	if (affd)
> @@ -372,6 +375,10 @@ msi_setup_entry(struct pci_dev *dev, int
>  	if (entry->pci.msi_attrib.can_mask)
>  		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
>  
> +	prop = MSI_PROP_PCI_MSI;
> +	if (entry->pci.msi_attrib.is_64)
> +		prop |= MSI_PROP_64BIT;
> +	msi_device_set_properties(&dev->dev, prop);
>  out:
>  	kfree(masks);
>  	return entry;
> @@ -514,6 +521,7 @@ static int msix_setup_entries(struct pci
>  		if (masks)
>  			curmsk++;
>  	}
> +	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
>  	ret = 0;
>  out:
>  	kfree(masks);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:05:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:05:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241899.418487 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muheS-0005ne-5r; Tue, 07 Dec 2021 21:05:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241899.418487; Tue, 07 Dec 2021 21:05:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muheS-0005nX-2N; Tue, 07 Dec 2021 21:05:28 +0000
Received: by outflank-mailman (input) for mailman id 241899;
 Tue, 07 Dec 2021 21:05:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muheR-0005Sw-06
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:05:27 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66278998-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:05:25 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id A06AFB81E86;
 Tue,  7 Dec 2021 21:05:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C0FC341C3;
 Tue,  7 Dec 2021 21:05:23 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66278998-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911124;
	bh=SSlqi2avER7Dt/gWeQCpUUK2WPs6V3REpcTbyOpLSVo=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=CQtpmV/VopSugovJYtB6rKgOASfGm+plq9ohd+c4gicwGabcfRU6ytOddQjW3Ve3g
	 tNsgaOjeq555aKWCr9jX9ODfSAmC5gTVJ3vse/nmE/bt6EDI8IgNQkIg/STXmf+7zE
	 U64SEr9asqbhWIQiNhiBgpiH/BRtSY7WmUh34L91oWrRiTQR4AmZqrtRLVMJBHFyQ9
	 UasPXsz2PYCPtfItiij1woyf8fHZ+e13Xx+SVxc9GVYIn8V5Hs0PkqB4OagIliTaI+
	 V7FpgXy1X/0HnHOAWVtqEJ1pP+FwItrm6eFFL4yJzWnlD+4qQ//Q8RNQddmclqTqgt
	 UL3+7UtH4ejJw==
Date: Tue, 7 Dec 2021 15:05:22 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 25/36] PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUS
Message-ID: <20211207210522.GA77919@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210439.021277807@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:36PM +0100, Thomas Gleixner wrote:
> Provide a domain info flag which makes the core code check for a contiguous
> MSI-X index on allocation. That's simpler than checking it at some other
> domain callback in architecture code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |   16 ++++++++++++++--
>  include/linux/msi.h         |    2 ++
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -89,9 +89,21 @@ static int pci_msi_domain_check_cap(stru
>  	if (pci_msi_desc_is_multi_msi(desc) &&
>  	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
>  		return 1;
> -	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
> -		return -ENOTSUPP;
>  
> +	if (desc->pci.msi_attrib.is_msix) {
> +		if (!(info->flags & MSI_FLAG_PCI_MSIX))
> +			return -ENOTSUPP;
> +
> +		if (info->flags & MSI_FLAG_MSIX_CONTIGUOUS) {
> +			unsigned int idx = 0;
> +
> +			/* Check for gaps in the entry indices */
> +			for_each_msi_entry(desc, dev) {
> +				if (desc->msi_index != idx++)
> +					return -ENOTSUPP;
> +			}
> +		}
> +	}
>  	return 0;
>  }
>  
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -376,6 +376,8 @@ enum {
>  	MSI_FLAG_LEVEL_CAPABLE		= (1 << 6),
>  	/* Populate sysfs on alloc() and destroy it on free() */
>  	MSI_FLAG_DEV_SYSFS		= (1 << 7),
> +	/* MSI-X entries must be contiguous */
> +	MSI_FLAG_MSIX_CONTIGUOUS	= (1 << 8),
>  };
>  
>  int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:05:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:05:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241906.418497 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muheo-0006Ns-Ej; Tue, 07 Dec 2021 21:05:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241906.418497; Tue, 07 Dec 2021 21:05:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muheo-0006Nl-BS; Tue, 07 Dec 2021 21:05:50 +0000
Received: by outflank-mailman (input) for mailman id 241906;
 Tue, 07 Dec 2021 21:05:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhem-0005Sw-Kh
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:05:48 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 732a5ad8-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:05:47 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 97655B81E8A;
 Tue,  7 Dec 2021 21:05:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E534FC341C1;
 Tue,  7 Dec 2021 21:05:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 732a5ad8-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911146;
	bh=emmb3xsy+H3LBfwGrcgXTk/PL3JNw+p8ei444INyEeo=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=tUHMVIuvSKD4KpV71T2u3HTnNeDdjH94nw6ue1OFelE7L1C2fPpkpG+VJS6EQ7RbL
	 DE4nTrcL4DzJJW3p9KkxJ90aY6WFOuJBcNOz8jNU3ACfHQRdCHhgymSV73nOEduwEV
	 6C7Yc+PJ57lEXe3kC7Fnk7gDayIipgMIIFTSVZY22xFXTXz0GcB0An+vkRX1XJHFeD
	 76cd+8jimETlvZcjXu7IptnZ7ZJ5TZKmn3H2yllAjGpq1LNMQk63AsB8yMhOvkaWG7
	 8Ad9xB75VRw/OAC03WjVlipOwF+92OCz7KOMco287/fqEZgDdhOY94sgRr2WDdSvK3
	 r75m+DCO8+wLg==
Date: Tue, 7 Dec 2021 15:05:44 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 28/36] PCI/MSI: Use __msi_get_virq() in
 pci_get_vector()
Message-ID: <20211207210544.GA77966@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210439.181331216@linutronix.de>

On Mon, Dec 06, 2021 at 11:39:41PM +0100, Thomas Gleixner wrote:
> Use msi_get_vector() and handle the return value to be compatible.
> 
> No functional change intended.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> V2: Handle the INTx case directly instead of trying to be overly smart - Marc
> ---
>  drivers/pci/msi/msi.c |   25 +++++--------------------
>  1 file changed, 5 insertions(+), 20 deletions(-)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -1032,28 +1032,13 @@ EXPORT_SYMBOL(pci_free_irq_vectors);
>   */
>  int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
>  {
> -	if (dev->msix_enabled) {
> -		struct msi_desc *entry;
> +	unsigned int irq;
>  
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->msi_index == nr)
> -				return entry->irq;
> -		}
> -		WARN_ON_ONCE(1);
> -		return -EINVAL;
> -	}
> +	if (!dev->msi_enabled && !dev->msix_enabled)
> +		return !nr ? dev->irq : -EINVAL;
>  
> -	if (dev->msi_enabled) {
> -		struct msi_desc *entry = first_pci_msi_entry(dev);
> -
> -		if (WARN_ON_ONCE(nr >= entry->nvec_used))
> -			return -EINVAL;
> -	} else {
> -		if (WARN_ON_ONCE(nr > 0))
> -			return -EINVAL;
> -	}
> -
> -	return dev->irq + nr;
> +	irq = msi_get_virq(&dev->dev, nr);
> +	return irq ? irq : -EINVAL;
>  }
>  EXPORT_SYMBOL(pci_irq_vector);
>  
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241918.418509 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfs-0007Jn-PZ; Tue, 07 Dec 2021 21:06:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241918.418509; Tue, 07 Dec 2021 21:06:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfs-0007Jg-MK; Tue, 07 Dec 2021 21:06:56 +0000
Received: by outflank-mailman (input) for mailman id 241918;
 Tue, 07 Dec 2021 21:06:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhbW-00014s-R7
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:02:26 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa150cf8-57a0-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:02:25 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id CC27DCE1E21;
 Tue,  7 Dec 2021 21:02:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C4C5C341C3;
 Tue,  7 Dec 2021 21:02:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa150cf8-57a0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910942;
	bh=izWXm95l+uZGERB30ZN7LtrcycoRGE73PbT8Z0h/qQw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=XufeyuxA4HkM8C1emNf201uZTgp+dVqYnNX9ceYmkxirOcGK1GaoHMbJIhyz3E3+D
	 cblky2T1a1/xUWCxvj7lXEc5xpM/dggclpp5CX7k6YatZZnXrjghPJwp9SiEWV/q8O
	 VHUPzss9MvVyzoAJaMBsVgQVwIQWM4SF/FV26sZrL5XAcC2xU1v6GOa1BhFJPeHS5T
	 wvm6bhOMRM9UNs8NKfy77ac0jMKUcnEUjJMGKEcxsgJrKNuqoW7tZRxDuYb0xt7/s7
	 4sSISKBZ3qSg8+5KsVWmnqztHkST9BbG9ZkniYgH9dpNrFmiv0QYea1HSrPMTJm/hB
	 pRBsYEeNdamow==
Date: Tue, 7 Dec 2021 15:02:19 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 22/23] genirq/msi: Handle PCI/MSI allocation fail in
 core code
Message-ID: <20211207210219.GA77501@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210225.046615302@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:59PM +0100, Thomas Gleixner wrote:
> Get rid of yet another irqdomain callback and let the core code return the
> already available information of how many descriptors could be allocated.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>	# PCI

> ---
>  drivers/pci/msi/irqdomain.c |   13 -------------
>  include/linux/msi.h         |    5 +----
>  kernel/irq/msi.c            |   29 +++++++++++++++++++++++++----
>  3 files changed, 26 insertions(+), 21 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -95,16 +95,6 @@ static int pci_msi_domain_check_cap(stru
>  	return 0;
>  }
>  
> -static int pci_msi_domain_handle_error(struct irq_domain *domain,
> -				       struct msi_desc *desc, int error)
> -{
> -	/* Special handling to support __pci_enable_msi_range() */
> -	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
> -		return 1;
> -
> -	return error;
> -}
> -
>  static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
>  				    struct msi_desc *desc)
>  {
> @@ -115,7 +105,6 @@ static void pci_msi_domain_set_desc(msi_
>  static struct msi_domain_ops pci_msi_domain_ops_default = {
>  	.set_desc	= pci_msi_domain_set_desc,
>  	.msi_check	= pci_msi_domain_check_cap,
> -	.handle_error	= pci_msi_domain_handle_error,
>  };
>  
>  static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
> @@ -129,8 +118,6 @@ static void pci_msi_domain_update_dom_op
>  			ops->set_desc = pci_msi_domain_set_desc;
>  		if (ops->msi_check == NULL)
>  			ops->msi_check = pci_msi_domain_check_cap;
> -		if (ops->handle_error == NULL)
> -			ops->handle_error = pci_msi_domain_handle_error;
>  	}
>  }
>  
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -286,7 +286,6 @@ struct msi_domain_info;
>   * @msi_check:		Callback for verification of the domain/info/dev data
>   * @msi_prepare:	Prepare the allocation of the interrupts in the domain
>   * @set_desc:		Set the msi descriptor for an interrupt
> - * @handle_error:	Optional error handler if the allocation fails
>   * @domain_alloc_irqs:	Optional function to override the default allocation
>   *			function.
>   * @domain_free_irqs:	Optional function to override the default free
> @@ -295,7 +294,7 @@ struct msi_domain_info;
>   * @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
>   * irqdomain.
>   *
> - * @msi_check, @msi_prepare, @handle_error and @set_desc are callbacks used by
> + * @msi_check, @msi_prepare and @set_desc are callbacks used by
>   * msi_domain_alloc/free_irqs().
>   *
>   * @domain_alloc_irqs, @domain_free_irqs can be used to override the
> @@ -332,8 +331,6 @@ struct msi_domain_ops {
>  				       msi_alloc_info_t *arg);
>  	void		(*set_desc)(msi_alloc_info_t *arg,
>  				    struct msi_desc *desc);
> -	int		(*handle_error)(struct irq_domain *domain,
> -					struct msi_desc *desc, int error);
>  	int		(*domain_alloc_irqs)(struct irq_domain *domain,
>  					     struct device *dev, int nvec);
>  	void		(*domain_free_irqs)(struct irq_domain *domain,
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -538,6 +538,27 @@ static bool msi_check_reservation_mode(s
>  	return desc->pci.msi_attrib.is_msix || desc->pci.msi_attrib.can_mask;
>  }
>  
> +static int msi_handle_pci_fail(struct irq_domain *domain, struct msi_desc *desc,
> +			       int allocated)
> +{
> +	switch(domain->bus_token) {
> +	case DOMAIN_BUS_PCI_MSI:
> +	case DOMAIN_BUS_VMD_MSI:
> +		if (IS_ENABLED(CONFIG_PCI_MSI))
> +			break;
> +		fallthrough;
> +	default:
> +		return -ENOSPC;
> +	}
> +
> +	/* Let a failed PCI multi MSI allocation retry */
> +	if (desc->nvec_used > 1)
> +		return 1;
> +
> +	/* If there was a successful allocation let the caller know */
> +	return allocated ? allocated : -ENOSPC;
> +}
> +
>  int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
>  			    int nvec)
>  {
> @@ -546,6 +567,7 @@ int __msi_domain_alloc_irqs(struct irq_d
>  	struct irq_data *irq_data;
>  	struct msi_desc *desc;
>  	msi_alloc_info_t arg = { };
> +	int allocated = 0;
>  	int i, ret, virq;
>  	bool can_reserve;
>  
> @@ -560,16 +582,15 @@ int __msi_domain_alloc_irqs(struct irq_d
>  					       dev_to_node(dev), &arg, false,
>  					       desc->affinity);
>  		if (virq < 0) {
> -			ret = -ENOSPC;
> -			if (ops->handle_error)
> -				ret = ops->handle_error(domain, desc, ret);
> -			return ret;
> +			ret = msi_handle_pci_fail(domain, desc, allocated);
> +			goto cleanup;
>  		}
>  
>  		for (i = 0; i < desc->nvec_used; i++) {
>  			irq_set_msi_desc_off(virq, i, desc);
>  			irq_debugfs_copy_devname(virq + i, dev);
>  		}
> +		allocated++;
>  	}
>  
>  	can_reserve = msi_check_reservation_mode(domain, info, dev);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241921.418520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfz-0007l4-4j; Tue, 07 Dec 2021 21:07:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241921.418520; Tue, 07 Dec 2021 21:07:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfz-0007kv-12; Tue, 07 Dec 2021 21:07:03 +0000
Received: by outflank-mailman (input) for mailman id 241921;
 Tue, 07 Dec 2021 21:07:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhXW-0004h1-Mw
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:58:18 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 660c5fe8-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:58:17 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 3FF13B81E92;
 Tue,  7 Dec 2021 20:58:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB4B6C341C3;
 Tue,  7 Dec 2021 20:58:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 660c5fe8-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910692;
	bh=mKk8CFP6CJrrE5nazjOj8lJlCLeQEHsGLEd20u/74iY=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=m6v2l2upjdgPf9w2JTHnTqJo1IQhsUtXrf8F9Vikgt6+Z8JqCK5xTJ6F2LKLBJXQk
	 f1feWsiex81V9M40VjQRY77dpHbpD+YmBN2/r2JsoxH2g2LiC+DUIcON3qHLEuh8Gz
	 NS6nDZmsa9Hrr+xtsG+VdRDrQGZcy670xHqNHikhH4k3q1XX1eLrZK8iiGqA/IMnEQ
	 FGWo8oJA6eAk1Fsb1P04L/6yLfhUvAWrjKF8GwSnqFoyeEQDmyRKL99yFYxSQnHXA8
	 H6M+S6xb4uWxb4Amw+dIX3H7cHFGQYQknXpKDLlndF8FSRGQgNUUZsQJZtz3LOqh0f
	 LsDHp544cDXEg==
Date: Tue, 7 Dec 2021 14:58:10 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 16/23] PCI/MSI: Split out CONFIG_PCI_MSI independent
 part
Message-ID: <20211207205810.GA76983@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.710137730@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:49PM +0100, Thomas Gleixner wrote:
> These functions are required even when CONFIG_PCI_MSI is not set. Move them
> to their own file.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/Makefile     |    3 ++-
>  drivers/pci/msi/msi.c        |   39 ---------------------------------------
>  drivers/pci/msi/pcidev_msi.c |   43 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 45 insertions(+), 40 deletions(-)
> 
> --- a/drivers/pci/msi/Makefile
> +++ b/drivers/pci/msi/Makefile
> @@ -1,4 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
>  #
>  # Makefile for the PCI/MSI
> -obj-$(CONFIG_PCI)		+= msi.o
> +obj-$(CONFIG_PCI)		+= pcidev_msi.o
> +obj-$(CONFIG_PCI_MSI)		+= msi.o
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -18,8 +18,6 @@
>  
>  #include "../pci.h"
>  
> -#ifdef CONFIG_PCI_MSI
> -
>  static int pci_msi_enable = 1;
>  int pci_msi_ignore_mask;
>  
> @@ -1493,40 +1491,3 @@ bool pci_dev_has_special_msi_domain(stru
>  }
>  
>  #endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
> -#endif /* CONFIG_PCI_MSI */
> -
> -void pci_msi_init(struct pci_dev *dev)
> -{
> -	u16 ctrl;
> -
> -	/*
> -	 * Disable the MSI hardware to avoid screaming interrupts
> -	 * during boot.  This is the power on reset default so
> -	 * usually this should be a noop.
> -	 */
> -	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
> -	if (!dev->msi_cap)
> -		return;
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
> -	if (ctrl & PCI_MSI_FLAGS_ENABLE)
> -		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
> -				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
> -
> -	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
> -		dev->no_64bit_msi = 1;
> -}
> -
> -void pci_msix_init(struct pci_dev *dev)
> -{
> -	u16 ctrl;
> -
> -	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
> -	if (!dev->msix_cap)
> -		return;
> -
> -	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> -	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
> -		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
> -				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
> -}
> --- /dev/null
> +++ b/drivers/pci/msi/pcidev_msi.c
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * MSI[X} related functions which are available unconditionally.
> + */
> +#include "../pci.h"
> +
> +/*
> + * Disable the MSI[X] hardware to avoid screaming interrupts during boot.
> + * This is the power on reset default so usually this should be a noop.
> + */
> +
> +void pci_msi_init(struct pci_dev *dev)
> +{
> +	u16 ctrl;
> +
> +	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
> +	if (!dev->msi_cap)
> +		return;
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
> +	if (ctrl & PCI_MSI_FLAGS_ENABLE) {
> +		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
> +				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
> +	}
> +
> +	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
> +		dev->no_64bit_msi = 1;
> +}
> +
> +void pci_msix_init(struct pci_dev *dev)
> +{
> +	u16 ctrl;
> +
> +	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
> +	if (!dev->msix_cap)
> +		return;
> +
> +	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> +	if (ctrl & PCI_MSIX_FLAGS_ENABLE) {
> +		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
> +				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
> +	}
> +}
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241922.418525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfz-0007nn-Hx; Tue, 07 Dec 2021 21:07:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241922.418525; Tue, 07 Dec 2021 21:07:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhfz-0007mp-9k; Tue, 07 Dec 2021 21:07:03 +0000
Received: by outflank-mailman (input) for mailman id 241922;
 Tue, 07 Dec 2021 21:07:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhfy-00079Y-5j
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:07:02 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9edc247a-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:07:01 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 762F5B81E81;
 Tue,  7 Dec 2021 21:07:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD973C341C3;
 Tue,  7 Dec 2021 21:06:58 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9edc247a-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911219;
	bh=X0S57AaQEic+pxrlfm8ArcEsuRWnA6Vver2WI6NT7UE=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=b+Kx6njakVbzOWyGLsFaYWFiGhvp2DFKTtt4gKBalCRZQLUdqOhNHtJaLRIIJnrTR
	 10QAHUN4GHQ/+dGrHvO7jJtRPnKG1+UiTDeIQmjhwyiVBzxaQeM3qsZn0B+2egfXt8
	 q8+o+CY70hRpU6Uzmrqmh38XeTf5fNpU6zC3ElRh6wDtWIZFDlkBKtMrx1iM7rQHT+
	 z123oSu4IcH4STWWCbdV2J7ma5qv5HWALkdcp0ncVVAoH2dHoGKQC6PNOB4pJv2Yz8
	 sERuICmDI2xYtOsRemEYK1pK09KgjArChdAxTHgfl847zqFYRrxXi0STfMD9ZlrWq6
	 y+pAX3UihJJ7w==
Date: Tue, 7 Dec 2021 15:06:57 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 07/31] PCI/MSI: Protect MSI operations
Message-ID: <20211207210657.GA78127@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210747.982292705@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:13PM +0100, Thomas Gleixner wrote:
> To prepare for dynamic extension of MSI-X vectors, protect the MSI
> operations for MSI and MSI-X. This requires to move the invocation of
> irq_create_affinity_masks() out of the descriptor lock section to avoid
> reverse lock ordering vs. CPU hotplug lock as some callers of the PCI/MSI
> allocation interfaces already hold it.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |    4 -
>  drivers/pci/msi/msi.c       |  120 ++++++++++++++++++++++++++------------------
>  2 files changed, 73 insertions(+), 51 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -14,7 +14,7 @@ int pci_msi_setup_msi_irqs(struct pci_de
>  
>  	domain = dev_get_msi_domain(&dev->dev);
>  	if (domain && irq_domain_is_hierarchy(domain))
> -		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
> +		return msi_domain_alloc_irqs_descs_locked(domain, &dev->dev, nvec);
>  
>  	return pci_msi_legacy_setup_msi_irqs(dev, nvec, type);
>  }
> @@ -25,7 +25,7 @@ void pci_msi_teardown_msi_irqs(struct pc
>  
>  	domain = dev_get_msi_domain(&dev->dev);
>  	if (domain && irq_domain_is_hierarchy(domain))
> -		msi_domain_free_irqs(domain, &dev->dev);
> +		msi_domain_free_irqs_descs_locked(domain, &dev->dev);
>  	else
>  		pci_msi_legacy_teardown_msi_irqs(dev);
>  }
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -322,11 +322,13 @@ static void __pci_restore_msix_state(str
>  
>  	write_msg = arch_restore_msi_irqs(dev);
>  
> +	msi_lock_descs(&dev->dev);
>  	for_each_pci_msi_entry(entry, dev) {
>  		if (write_msg)
>  			__pci_write_msi_msg(entry, &entry->msg);
>  		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
>  	}
> +	msi_unlock_descs(&dev->dev);
>  
>  	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
>  }
> @@ -339,20 +341,16 @@ void pci_restore_msi_state(struct pci_de
>  EXPORT_SYMBOL_GPL(pci_restore_msi_state);
>  
>  static struct msi_desc *
> -msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
> +msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity_desc *masks)
>  {
> -	struct irq_affinity_desc *masks = NULL;
>  	struct msi_desc *entry;
>  	unsigned long prop;
>  	u16 control;
>  
> -	if (affd)
> -		masks = irq_create_affinity_masks(nvec, affd);
> -
>  	/* MSI Entry Initialization */
>  	entry = alloc_msi_entry(&dev->dev, nvec, masks);
>  	if (!entry)
> -		goto out;
> +		return NULL;
>  
>  	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
>  	/* Lies, damned lies, and MSIs */
> @@ -379,8 +377,7 @@ msi_setup_entry(struct pci_dev *dev, int
>  	if (entry->pci.msi_attrib.is_64)
>  		prop |= MSI_PROP_64BIT;
>  	msi_device_set_properties(&dev->dev, prop);
> -out:
> -	kfree(masks);
> +
>  	return entry;
>  }
>  
> @@ -416,14 +413,21 @@ static int msi_verify_entries(struct pci
>  static int msi_capability_init(struct pci_dev *dev, int nvec,
>  			       struct irq_affinity *affd)
>  {
> +	struct irq_affinity_desc *masks = NULL;
>  	struct msi_desc *entry;
>  	int ret;
>  
>  	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
>  
> -	entry = msi_setup_entry(dev, nvec, affd);
> -	if (!entry)
> -		return -ENOMEM;
> +	if (affd)
> +		masks = irq_create_affinity_masks(nvec, affd);
> +
> +	msi_lock_descs(&dev->dev);
> +	entry = msi_setup_entry(dev, nvec, masks);
> +	if (!entry) {
> +		ret = -ENOMEM;
> +		goto unlock;
> +	}
>  
>  	/* All MSIs are unmasked by default; mask them all */
>  	pci_msi_mask(entry, msi_multi_mask(entry));
> @@ -446,11 +450,14 @@ static int msi_capability_init(struct pc
>  
>  	pcibios_free_irq(dev);
>  	dev->irq = entry->irq;
> -	return 0;
> +	goto unlock;
>  
>  err:
>  	pci_msi_unmask(entry, msi_multi_mask(entry));
>  	free_msi_irqs(dev);
> +unlock:
> +	msi_unlock_descs(&dev->dev);
> +	kfree(masks);
>  	return ret;
>  }
>  
> @@ -477,23 +484,18 @@ static void __iomem *msix_map_region(str
>  
>  static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
>  			      struct msix_entry *entries, int nvec,
> -			      struct irq_affinity *affd)
> +			      struct irq_affinity_desc *masks)
>  {
> -	struct irq_affinity_desc *curmsk, *masks = NULL;
> +	int i, vec_count = pci_msix_vec_count(dev);
> +	struct irq_affinity_desc *curmsk;
>  	struct msi_desc *entry;
>  	void __iomem *addr;
> -	int ret, i;
> -	int vec_count = pci_msix_vec_count(dev);
> -
> -	if (affd)
> -		masks = irq_create_affinity_masks(nvec, affd);
>  
>  	for (i = 0, curmsk = masks; i < nvec; i++) {
>  		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
>  		if (!entry) {
>  			/* No enough memory. Don't try again */
> -			ret = -ENOMEM;
> -			goto out;
> +			return -ENOMEM;
>  		}
>  
>  		entry->pci.msi_attrib.is_msix	= 1;
> @@ -522,10 +524,7 @@ static int msix_setup_entries(struct pci
>  			curmsk++;
>  	}
>  	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
> -	ret = 0;
> -out:
> -	kfree(masks);
> -	return ret;
> +	return 0;
>  }
>  
>  static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
> @@ -552,6 +551,41 @@ static void msix_mask_all(void __iomem *
>  		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  }
>  
> +static int msix_setup_interrupts(struct pci_dev *dev, void __iomem *base,
> +				 struct msix_entry *entries, int nvec,
> +				 struct irq_affinity *affd)
> +{
> +	struct irq_affinity_desc *masks = NULL;
> +	int ret;
> +
> +	if (affd)
> +		masks = irq_create_affinity_masks(nvec, affd);
> +
> +	msi_lock_descs(&dev->dev);
> +	ret = msix_setup_entries(dev, base, entries, nvec, masks);
> +	if (ret)
> +		goto out_free;
> +
> +	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
> +	if (ret)
> +		goto out_free;
> +
> +	/* Check if all MSI entries honor device restrictions */
> +	ret = msi_verify_entries(dev);
> +	if (ret)
> +		goto out_free;
> +
> +	msix_update_entries(dev, entries);
> +	goto out_unlock;
> +
> +out_free:
> +	free_msi_irqs(dev);
> +out_unlock:
> +	msi_unlock_descs(&dev->dev);
> +	kfree(masks);
> +	return ret;
> +}
> +
>  /**
>   * msix_capability_init - configure device's MSI-X capability
>   * @dev: pointer to the pci_dev data structure of MSI-X device function
> @@ -592,20 +626,9 @@ static int msix_capability_init(struct p
>  	/* Ensure that all table entries are masked. */
>  	msix_mask_all(base, tsize);
>  
> -	ret = msix_setup_entries(dev, base, entries, nvec, affd);
> +	ret = msix_setup_interrupts(dev, base, entries, nvec, affd);
>  	if (ret)
> -		goto out_free;
> -
> -	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
> -	if (ret)
> -		goto out_free;
> -
> -	/* Check if all MSI entries honor device restrictions */
> -	ret = msi_verify_entries(dev);
> -	if (ret)
> -		goto out_free;
> -
> -	msix_update_entries(dev, entries);
> +		goto out_disable;
>  
>  	/* Set MSI-X enabled bits and unmask the function */
>  	pci_intx_for_msi(dev, 0);
> @@ -615,12 +638,8 @@ static int msix_capability_init(struct p
>  	pcibios_free_irq(dev);
>  	return 0;
>  
> -out_free:
> -	free_msi_irqs(dev);
> -
>  out_disable:
>  	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
> -
>  	return ret;
>  }
>  
> @@ -725,8 +744,10 @@ void pci_disable_msi(struct pci_dev *dev
>  	if (!pci_msi_enable || !dev || !dev->msi_enabled)
>  		return;
>  
> +	msi_lock_descs(&dev->dev);
>  	pci_msi_shutdown(dev);
>  	free_msi_irqs(dev);
> +	msi_unlock_descs(&dev->dev);
>  }
>  EXPORT_SYMBOL(pci_disable_msi);
>  
> @@ -812,8 +833,10 @@ void pci_disable_msix(struct pci_dev *de
>  	if (!pci_msi_enable || !dev || !dev->msix_enabled)
>  		return;
>  
> +	msi_lock_descs(&dev->dev);
>  	pci_msix_shutdown(dev);
>  	free_msi_irqs(dev);
> +	msi_unlock_descs(&dev->dev);
>  }
>  EXPORT_SYMBOL(pci_disable_msix);
>  
> @@ -874,7 +897,6 @@ int pci_enable_msi(struct pci_dev *dev)
>  
>  	if (!rc)
>  		rc = __pci_enable_msi_range(dev, 1, 1, NULL);
> -
>  	return rc < 0 ? rc : 0;
>  }
>  EXPORT_SYMBOL(pci_enable_msi);
> @@ -961,11 +983,7 @@ int pci_alloc_irq_vectors_affinity(struc
>  				   struct irq_affinity *affd)
>  {
>  	struct irq_affinity msi_default_affd = {0};
> -	int ret = msi_setup_device_data(&dev->dev);
> -	int nvecs = -ENOSPC;
> -
> -	if (ret)
> -		return ret;
> +	int ret, nvecs;
>  
>  	if (flags & PCI_IRQ_AFFINITY) {
>  		if (!affd)
> @@ -975,6 +993,10 @@ int pci_alloc_irq_vectors_affinity(struc
>  			affd = NULL;
>  	}
>  
> +	ret = msi_setup_device_data(&dev->dev);
> +	if (ret)
> +		return ret;
> +
>  	if (flags & PCI_IRQ_MSIX) {
>  		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
>  						affd, flags);
> @@ -1003,7 +1025,7 @@ int pci_alloc_irq_vectors_affinity(struc
>  		}
>  	}
>  
> -	return nvecs;
> +	return -ENOSPC;
>  }
>  EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
>  
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241924.418539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhg0-0008FN-Ng; Tue, 07 Dec 2021 21:07:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241924.418539; Tue, 07 Dec 2021 21:07:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhg0-0008EI-JM; Tue, 07 Dec 2021 21:07:04 +0000
Received: by outflank-mailman (input) for mailman id 241924;
 Tue, 07 Dec 2021 21:07:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhXE-0004h1-DR
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 20:58:00 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 599fd773-57a0-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 21:57:56 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 6822ECE1D53;
 Tue,  7 Dec 2021 20:57:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7849C341C1;
 Tue,  7 Dec 2021 20:57:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 599fd773-57a0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638910672;
	bh=edIdzyli493Wb7puiTp9Hn49k2Bhb8B9ntYVuGOKo5E=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=p04vCNjn9zNUe2wQvDzhF2Blal3leG8ltdJY0h2t7VeE11W+qu0wAOGo/zcSt4w2m
	 /gjZj4M4F2nLUDUmN/ZP+r8Iob1nWQ3w4aG7V47PpbcpKbm9FY1aYey8HOgUcad82j
	 a4KtxBuvz3L3iR02BRZXFkbR1NAsKg883PzDliwy1vr6Nsst86tCAqHmHvJzmlyxVO
	 EZuOEjKSdKB/Tb1dME1mvqfCGrVOTUEYOOtPRhZIf6fvXK3F4Ml3GSYcgOJYwEk+qc
	 /Fkp69/E6HU4LqL8LQWxmkgtywLozFqDYI/YVBPpmYQnEp46aLbXAAf4jtxVXIjbju
	 2LW21h2KPk9Kw==
Date: Tue, 7 Dec 2021 14:57:50 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 15/23] PCI/MSI: Move code into a separate directory
Message-ID: <20211207205750.GA76930@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.655043033@linutronix.de>

On Mon, Dec 06, 2021 at 11:27:47PM +0100, Thomas Gleixner wrote:
> msi.c is getting larger and really could do with a splitup. Move it into
> it's own directory to prepare for that.

s/it's/its/

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  Documentation/driver-api/pci/pci.rst |    2 
>  drivers/pci/Makefile                 |    3 
>  drivers/pci/msi.c                    | 1532 -----------------------------------
>  drivers/pci/msi/Makefile             |    4 
>  drivers/pci/msi/msi.c                | 1532 +++++++++++++++++++++++++++++++++++
>  5 files changed, 1539 insertions(+), 1534 deletions(-)
> 
> --- a/Documentation/driver-api/pci/pci.rst
> +++ b/Documentation/driver-api/pci/pci.rst
> @@ -13,7 +13,7 @@ PCI Support Library
>  .. kernel-doc:: drivers/pci/search.c
>     :export:
>  
> -.. kernel-doc:: drivers/pci/msi.c
> +.. kernel-doc:: drivers/pci/msi/msi.c
>     :export:
>  
>  .. kernel-doc:: drivers/pci/bus.c
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -5,8 +5,9 @@
>  obj-$(CONFIG_PCI)		+= access.o bus.o probe.o host-bridge.o \
>  				   remove.o pci.o pci-driver.o search.o \
>  				   pci-sysfs.o rom.o setup-res.o irq.o vpd.o \
> -				   setup-bus.o vc.o mmap.o setup-irq.o msi.o
> +				   setup-bus.o vc.o mmap.o setup-irq.o
>  
> +obj-$(CONFIG_PCI)		+= msi/
>  obj-$(CONFIG_PCI)		+= pcie/
>  
>  ifdef CONFIG_PCI
> --- a/drivers/pci/msi.c
> +++ /dev/null
> @@ -1,1532 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/*
> - * PCI Message Signaled Interrupt (MSI)
> - *
> - * Copyright (C) 2003-2004 Intel
> - * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
> - * Copyright (C) 2016 Christoph Hellwig.
> - */
> -
> -#include <linux/acpi_iort.h>
> -#include <linux/err.h>
> -#include <linux/export.h>
> -#include <linux/irq.h>
> -#include <linux/irqdomain.h>
> -#include <linux/msi.h>
> -#include <linux/of_irq.h>
> -#include <linux/pci.h>
> -
> -#include "pci.h"
> -
> -#ifdef CONFIG_PCI_MSI
> -
> -static int pci_msi_enable = 1;
> -int pci_msi_ignore_mask;
> -
> -#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
> -
> -#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> -static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	struct irq_domain *domain;
> -
> -	domain = dev_get_msi_domain(&dev->dev);
> -	if (domain && irq_domain_is_hierarchy(domain))
> -		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
> -
> -	return arch_setup_msi_irqs(dev, nvec, type);
> -}
> -
> -static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	struct irq_domain *domain;
> -
> -	domain = dev_get_msi_domain(&dev->dev);
> -	if (domain && irq_domain_is_hierarchy(domain))
> -		msi_domain_free_irqs(domain, &dev->dev);
> -	else
> -		arch_teardown_msi_irqs(dev);
> -}
> -#else
> -#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
> -#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
> -#endif
> -
> -#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
> -/* Arch hooks */
> -int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
> -{
> -	return -EINVAL;
> -}
> -
> -void __weak arch_teardown_msi_irq(unsigned int irq)
> -{
> -}
> -
> -int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -	struct msi_desc *entry;
> -	int ret;
> -
> -	/*
> -	 * If an architecture wants to support multiple MSI, it needs to
> -	 * override arch_setup_msi_irqs()
> -	 */
> -	if (type == PCI_CAP_ID_MSI && nvec > 1)
> -		return 1;
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		ret = arch_setup_msi_irq(dev, entry);
> -		if (ret < 0)
> -			return ret;
> -		if (ret > 0)
> -			return -ENOSPC;
> -	}
> -
> -	return 0;
> -}
> -
> -void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
> -{
> -	int i;
> -	struct msi_desc *entry;
> -
> -	for_each_pci_msi_entry(entry, dev)
> -		if (entry->irq)
> -			for (i = 0; i < entry->nvec_used; i++)
> -				arch_teardown_msi_irq(entry->irq + i);
> -}
> -#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
> -
> -/*
> - * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
> - * mask all MSI interrupts by clearing the MSI enable bit does not work
> - * reliably as devices without an INTx disable bit will then generate a
> - * level IRQ which will never be cleared.
> - */
> -static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
> -{
> -	/* Don't shift by >= width of type */
> -	if (desc->pci.msi_attrib.multi_cap >= 5)
> -		return 0xffffffff;
> -	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
> -}
> -
> -static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
> -{
> -	raw_spinlock_t *lock = &desc->dev->msi_lock;
> -	unsigned long flags;
> -
> -	if (!desc->pci.msi_attrib.can_mask)
> -		return;
> -
> -	raw_spin_lock_irqsave(lock, flags);
> -	desc->pci.msi_mask &= ~clear;
> -	desc->pci.msi_mask |= set;
> -	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->pci.mask_pos,
> -			       desc->pci.msi_mask);
> -	raw_spin_unlock_irqrestore(lock, flags);
> -}
> -
> -static inline void pci_msi_mask(struct msi_desc *desc, u32 mask)
> -{
> -	pci_msi_update_mask(desc, 0, mask);
> -}
> -
> -static inline void pci_msi_unmask(struct msi_desc *desc, u32 mask)
> -{
> -	pci_msi_update_mask(desc, mask, 0);
> -}
> -
> -static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
> -{
> -	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
> -}
> -
> -/*
> - * This internal function does not flush PCI writes to the device.  All
> - * users must ensure that they read from the device before either assuming
> - * that the device state is up to date, or returning out of this file.
> - * It does not affect the msi_desc::msix_ctrl cache either. Use with care!
> - */
> -static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
> -{
> -	void __iomem *desc_addr = pci_msix_desc_addr(desc);
> -
> -	if (desc->pci.msi_attrib.can_mask)
> -		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> -}
> -
> -static inline void pci_msix_mask(struct msi_desc *desc)
> -{
> -	desc->pci.msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
> -	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
> -	/* Flush write to device */
> -	readl(desc->pci.mask_base);
> -}
> -
> -static inline void pci_msix_unmask(struct msi_desc *desc)
> -{
> -	desc->pci.msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
> -	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
> -}
> -
> -static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
> -{
> -	if (desc->pci.msi_attrib.is_msix)
> -		pci_msix_mask(desc);
> -	else
> -		pci_msi_mask(desc, mask);
> -}
> -
> -static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
> -{
> -	if (desc->pci.msi_attrib.is_msix)
> -		pci_msix_unmask(desc);
> -	else
> -		pci_msi_unmask(desc, mask);
> -}
> -
> -/**
> - * pci_msi_mask_irq - Generic IRQ chip callback to mask PCI/MSI interrupts
> - * @data:	pointer to irqdata associated to that interrupt
> - */
> -void pci_msi_mask_irq(struct irq_data *data)
> -{
> -	struct msi_desc *desc = irq_data_get_msi_desc(data);
> -
> -	__pci_msi_mask_desc(desc, BIT(data->irq - desc->irq));
> -}
> -EXPORT_SYMBOL_GPL(pci_msi_mask_irq);
> -
> -/**
> - * pci_msi_unmask_irq - Generic IRQ chip callback to unmask PCI/MSI interrupts
> - * @data:	pointer to irqdata associated to that interrupt
> - */
> -void pci_msi_unmask_irq(struct irq_data *data)
> -{
> -	struct msi_desc *desc = irq_data_get_msi_desc(data);
> -
> -	__pci_msi_unmask_desc(desc, BIT(data->irq - desc->irq));
> -}
> -EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
> -
> -void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
> -{
> -	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
> -
> -	BUG_ON(dev->current_state != PCI_D0);
> -
> -	if (entry->pci.msi_attrib.is_msix) {
> -		void __iomem *base = pci_msix_desc_addr(entry);
> -
> -		if (WARN_ON_ONCE(entry->pci.msi_attrib.is_virtual))
> -			return;
> -
> -		msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR);
> -		msg->address_hi = readl(base + PCI_MSIX_ENTRY_UPPER_ADDR);
> -		msg->data = readl(base + PCI_MSIX_ENTRY_DATA);
> -	} else {
> -		int pos = dev->msi_cap;
> -		u16 data;
> -
> -		pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
> -				      &msg->address_lo);
> -		if (entry->pci.msi_attrib.is_64) {
> -			pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
> -					      &msg->address_hi);
> -			pci_read_config_word(dev, pos + PCI_MSI_DATA_64, &data);
> -		} else {
> -			msg->address_hi = 0;
> -			pci_read_config_word(dev, pos + PCI_MSI_DATA_32, &data);
> -		}
> -		msg->data = data;
> -	}
> -}
> -
> -void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
> -{
> -	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
> -
> -	if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
> -		/* Don't touch the hardware now */
> -	} else if (entry->pci.msi_attrib.is_msix) {
> -		void __iomem *base = pci_msix_desc_addr(entry);
> -		u32 ctrl = entry->pci.msix_ctrl;
> -		bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
> -
> -		if (entry->pci.msi_attrib.is_virtual)
> -			goto skip;
> -
> -		/*
> -		 * The specification mandates that the entry is masked
> -		 * when the message is modified:
> -		 *
> -		 * "If software changes the Address or Data value of an
> -		 * entry while the entry is unmasked, the result is
> -		 * undefined."
> -		 */
> -		if (unmasked)
> -			pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
> -
> -		writel(msg->address_lo, base + PCI_MSIX_ENTRY_LOWER_ADDR);
> -		writel(msg->address_hi, base + PCI_MSIX_ENTRY_UPPER_ADDR);
> -		writel(msg->data, base + PCI_MSIX_ENTRY_DATA);
> -
> -		if (unmasked)
> -			pci_msix_write_vector_ctrl(entry, ctrl);
> -
> -		/* Ensure that the writes are visible in the device */
> -		readl(base + PCI_MSIX_ENTRY_DATA);
> -	} else {
> -		int pos = dev->msi_cap;
> -		u16 msgctl;
> -
> -		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
> -		msgctl &= ~PCI_MSI_FLAGS_QSIZE;
> -		msgctl |= entry->pci.msi_attrib.multiple << 4;
> -		pci_write_config_word(dev, pos + PCI_MSI_FLAGS, msgctl);
> -
> -		pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
> -				       msg->address_lo);
> -		if (entry->pci.msi_attrib.is_64) {
> -			pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
> -					       msg->address_hi);
> -			pci_write_config_word(dev, pos + PCI_MSI_DATA_64,
> -					      msg->data);
> -		} else {
> -			pci_write_config_word(dev, pos + PCI_MSI_DATA_32,
> -					      msg->data);
> -		}
> -		/* Ensure that the writes are visible in the device */
> -		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
> -	}
> -
> -skip:
> -	entry->msg = *msg;
> -
> -	if (entry->write_msi_msg)
> -		entry->write_msi_msg(entry, entry->write_msi_msg_data);
> -
> -}
> -
> -void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
> -{
> -	struct msi_desc *entry = irq_get_msi_desc(irq);
> -
> -	__pci_write_msi_msg(entry, msg);
> -}
> -EXPORT_SYMBOL_GPL(pci_write_msi_msg);
> -
> -static void free_msi_irqs(struct pci_dev *dev)
> -{
> -	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
> -	struct msi_desc *entry, *tmp;
> -	int i;
> -
> -	for_each_pci_msi_entry(entry, dev)
> -		if (entry->irq)
> -			for (i = 0; i < entry->nvec_used; i++)
> -				BUG_ON(irq_has_action(entry->irq + i));
> -
> -	if (dev->msi_irq_groups) {
> -		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
> -		dev->msi_irq_groups = NULL;
> -	}
> -
> -	pci_msi_teardown_msi_irqs(dev);
> -
> -	list_for_each_entry_safe(entry, tmp, msi_list, list) {
> -		if (entry->pci.msi_attrib.is_msix) {
> -			if (list_is_last(&entry->list, msi_list))
> -				iounmap(entry->pci.mask_base);
> -		}
> -
> -		list_del(&entry->list);
> -		free_msi_entry(entry);
> -	}
> -}
> -
> -static void pci_intx_for_msi(struct pci_dev *dev, int enable)
> -{
> -	if (!(dev->dev_flags & PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG))
> -		pci_intx(dev, enable);
> -}
> -
> -static void pci_msi_set_enable(struct pci_dev *dev, int enable)
> -{
> -	u16 control;
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> -	control &= ~PCI_MSI_FLAGS_ENABLE;
> -	if (enable)
> -		control |= PCI_MSI_FLAGS_ENABLE;
> -	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
> -}
> -
> -/*
> - * Architecture override returns true when the PCI MSI message should be
> - * written by the generic restore function.
> - */
> -bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
> -{
> -	return true;
> -}
> -
> -static void __pci_restore_msi_state(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -	u16 control;
> -
> -	if (!dev->msi_enabled)
> -		return;
> -
> -	entry = irq_get_msi_desc(dev->irq);
> -
> -	pci_intx_for_msi(dev, 0);
> -	pci_msi_set_enable(dev, 0);
> -	if (arch_restore_msi_irqs(dev))
> -		__pci_write_msi_msg(entry, &entry->msg);
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> -	pci_msi_update_mask(entry, 0, 0);
> -	control &= ~PCI_MSI_FLAGS_QSIZE;
> -	control |= (entry->pci.msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
> -	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
> -}
> -
> -static void pci_msix_clear_and_set_ctrl(struct pci_dev *dev, u16 clear, u16 set)
> -{
> -	u16 ctrl;
> -
> -	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> -	ctrl &= ~clear;
> -	ctrl |= set;
> -	pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, ctrl);
> -}
> -
> -static void __pci_restore_msix_state(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -	bool write_msg;
> -
> -	if (!dev->msix_enabled)
> -		return;
> -	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
> -
> -	/* route the table */
> -	pci_intx_for_msi(dev, 0);
> -	pci_msix_clear_and_set_ctrl(dev, 0,
> -				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
> -
> -	write_msg = arch_restore_msi_irqs(dev);
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		if (write_msg)
> -			__pci_write_msi_msg(entry, &entry->msg);
> -		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
> -	}
> -
> -	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
> -}
> -
> -void pci_restore_msi_state(struct pci_dev *dev)
> -{
> -	__pci_restore_msi_state(dev);
> -	__pci_restore_msix_state(dev);
> -}
> -EXPORT_SYMBOL_GPL(pci_restore_msi_state);
> -
> -static struct msi_desc *
> -msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
> -{
> -	struct irq_affinity_desc *masks = NULL;
> -	struct msi_desc *entry;
> -	u16 control;
> -
> -	if (affd)
> -		masks = irq_create_affinity_masks(nvec, affd);
> -
> -	/* MSI Entry Initialization */
> -	entry = alloc_msi_entry(&dev->dev, nvec, masks);
> -	if (!entry)
> -		goto out;
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> -	/* Lies, damned lies, and MSIs */
> -	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
> -		control |= PCI_MSI_FLAGS_MASKBIT;
> -
> -	entry->pci.msi_attrib.is_msix	= 0;
> -	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
> -	entry->pci.msi_attrib.is_virtual    = 0;
> -	entry->pci.msi_attrib.entry_nr	= 0;
> -	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> -					  !!(control & PCI_MSI_FLAGS_MASKBIT);
> -	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
> -	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
> -	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
> -
> -	if (control & PCI_MSI_FLAGS_64BIT)
> -		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
> -	else
> -		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
> -
> -	/* Save the initial mask status */
> -	if (entry->pci.msi_attrib.can_mask)
> -		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
> -
> -out:
> -	kfree(masks);
> -	return entry;
> -}
> -
> -static int msi_verify_entries(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -
> -	if (!dev->no_64bit_msi)
> -		return 0;
> -
> -	for_each_pci_msi_entry(entry, dev) {
> -		if (entry->msg.address_hi) {
> -			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
> -				entry->msg.address_hi, entry->msg.address_lo);
> -			return -EIO;
> -		}
> -	}
> -	return 0;
> -}
> -
> -/**
> - * msi_capability_init - configure device's MSI capability structure
> - * @dev: pointer to the pci_dev data structure of MSI device function
> - * @nvec: number of interrupts to allocate
> - * @affd: description of automatic IRQ affinity assignments (may be %NULL)
> - *
> - * Setup the MSI capability structure of the device with the requested
> - * number of interrupts.  A return value of zero indicates the successful
> - * setup of an entry with the new MSI IRQ.  A negative return value indicates
> - * an error, and a positive return value indicates the number of interrupts
> - * which could have been allocated.
> - */
> -static int msi_capability_init(struct pci_dev *dev, int nvec,
> -			       struct irq_affinity *affd)
> -{
> -	const struct attribute_group **groups;
> -	struct msi_desc *entry;
> -	int ret;
> -
> -	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
> -
> -	entry = msi_setup_entry(dev, nvec, affd);
> -	if (!entry)
> -		return -ENOMEM;
> -
> -	/* All MSIs are unmasked by default; mask them all */
> -	pci_msi_mask(entry, msi_multi_mask(entry));
> -
> -	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> -
> -	/* Configure MSI capability structure */
> -	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
> -	if (ret)
> -		goto err;
> -
> -	ret = msi_verify_entries(dev);
> -	if (ret)
> -		goto err;
> -
> -	groups = msi_populate_sysfs(&dev->dev);
> -	if (IS_ERR(groups)) {
> -		ret = PTR_ERR(groups);
> -		goto err;
> -	}
> -
> -	dev->msi_irq_groups = groups;
> -
> -	/* Set MSI enabled bits	*/
> -	pci_intx_for_msi(dev, 0);
> -	pci_msi_set_enable(dev, 1);
> -	dev->msi_enabled = 1;
> -
> -	pcibios_free_irq(dev);
> -	dev->irq = entry->irq;
> -	return 0;
> -
> -err:
> -	pci_msi_unmask(entry, msi_multi_mask(entry));
> -	free_msi_irqs(dev);
> -	return ret;
> -}
> -
> -static void __iomem *msix_map_region(struct pci_dev *dev,
> -				     unsigned int nr_entries)
> -{
> -	resource_size_t phys_addr;
> -	u32 table_offset;
> -	unsigned long flags;
> -	u8 bir;
> -
> -	pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,
> -			      &table_offset);
> -	bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);
> -	flags = pci_resource_flags(dev, bir);
> -	if (!flags || (flags & IORESOURCE_UNSET))
> -		return NULL;
> -
> -	table_offset &= PCI_MSIX_TABLE_OFFSET;
> -	phys_addr = pci_resource_start(dev, bir) + table_offset;
> -
> -	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
> -}
> -
> -static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
> -			      struct msix_entry *entries, int nvec,
> -			      struct irq_affinity *affd)
> -{
> -	struct irq_affinity_desc *curmsk, *masks = NULL;
> -	struct msi_desc *entry;
> -	void __iomem *addr;
> -	int ret, i;
> -	int vec_count = pci_msix_vec_count(dev);
> -
> -	if (affd)
> -		masks = irq_create_affinity_masks(nvec, affd);
> -
> -	for (i = 0, curmsk = masks; i < nvec; i++) {
> -		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
> -		if (!entry) {
> -			if (!i)
> -				iounmap(base);
> -			else
> -				free_msi_irqs(dev);
> -			/* No enough memory. Don't try again */
> -			ret = -ENOMEM;
> -			goto out;
> -		}
> -
> -		entry->pci.msi_attrib.is_msix	= 1;
> -		entry->pci.msi_attrib.is_64	= 1;
> -
> -		if (entries)
> -			entry->pci.msi_attrib.entry_nr = entries[i].entry;
> -		else
> -			entry->pci.msi_attrib.entry_nr = i;
> -
> -		entry->pci.msi_attrib.is_virtual =
> -			entry->pci.msi_attrib.entry_nr >= vec_count;
> -
> -		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> -						  !entry->pci.msi_attrib.is_virtual;
> -
> -		entry->pci.msi_attrib.default_irq	= dev->irq;
> -		entry->pci.mask_base			= base;
> -
> -		if (entry->pci.msi_attrib.can_mask) {
> -			addr = pci_msix_desc_addr(entry);
> -			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> -		}
> -
> -		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> -		if (masks)
> -			curmsk++;
> -	}
> -	ret = 0;
> -out:
> -	kfree(masks);
> -	return ret;
> -}
> -
> -static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
> -{
> -	struct msi_desc *entry;
> -
> -	if (entries) {
> -		for_each_pci_msi_entry(entry, dev) {
> -			entries->vector = entry->irq;
> -			entries++;
> -		}
> -	}
> -}
> -
> -static void msix_mask_all(void __iomem *base, int tsize)
> -{
> -	u32 ctrl = PCI_MSIX_ENTRY_CTRL_MASKBIT;
> -	int i;
> -
> -	if (pci_msi_ignore_mask)
> -		return;
> -
> -	for (i = 0; i < tsize; i++, base += PCI_MSIX_ENTRY_SIZE)
> -		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
> -}
> -
> -/**
> - * msix_capability_init - configure device's MSI-X capability
> - * @dev: pointer to the pci_dev data structure of MSI-X device function
> - * @entries: pointer to an array of struct msix_entry entries
> - * @nvec: number of @entries
> - * @affd: Optional pointer to enable automatic affinity assignment
> - *
> - * Setup the MSI-X capability structure of device function with a
> - * single MSI-X IRQ. A return of zero indicates the successful setup of
> - * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
> - **/
> -static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
> -				int nvec, struct irq_affinity *affd)
> -{
> -	const struct attribute_group **groups;
> -	void __iomem *base;
> -	int ret, tsize;
> -	u16 control;
> -
> -	/*
> -	 * Some devices require MSI-X to be enabled before the MSI-X
> -	 * registers can be accessed.  Mask all the vectors to prevent
> -	 * interrupts coming in before they're fully set up.
> -	 */
> -	pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
> -				    PCI_MSIX_FLAGS_ENABLE);
> -
> -	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
> -	/* Request & Map MSI-X table region */
> -	tsize = msix_table_size(control);
> -	base = msix_map_region(dev, tsize);
> -	if (!base) {
> -		ret = -ENOMEM;
> -		goto out_disable;
> -	}
> -
> -	/* Ensure that all table entries are masked. */
> -	msix_mask_all(base, tsize);
> -
> -	ret = msix_setup_entries(dev, base, entries, nvec, affd);
> -	if (ret)
> -		goto out_disable;
> -
> -	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
> -	if (ret)
> -		goto out_avail;
> -
> -	/* Check if all MSI entries honor device restrictions */
> -	ret = msi_verify_entries(dev);
> -	if (ret)
> -		goto out_free;
> -
> -	msix_update_entries(dev, entries);
> -
> -	groups = msi_populate_sysfs(&dev->dev);
> -	if (IS_ERR(groups)) {
> -		ret = PTR_ERR(groups);
> -		goto out_free;
> -	}
> -
> -	dev->msi_irq_groups = groups;
> -
> -	/* Set MSI-X enabled bits and unmask the function */
> -	pci_intx_for_msi(dev, 0);
> -	dev->msix_enabled = 1;
> -	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
> -
> -	pcibios_free_irq(dev);
> -	return 0;
> -
> -out_avail:
> -	if (ret < 0) {
> -		/*
> -		 * If we had some success, report the number of IRQs
> -		 * we succeeded in setting up.
> -		 */
> -		struct msi_desc *entry;
> -		int avail = 0;
> -
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->irq != 0)
> -				avail++;
> -		}
> -		if (avail != 0)
> -			ret = avail;
> -	}
> -
> -out_free:
> -	free_msi_irqs(dev);
> -
> -out_disable:
> -	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
> -
> -	return ret;
> -}
> -
> -/**
> - * pci_msi_supported - check whether MSI may be enabled on a device
> - * @dev: pointer to the pci_dev data structure of MSI device function
> - * @nvec: how many MSIs have been requested?
> - *
> - * Look at global flags, the device itself, and its parent buses
> - * to determine if MSI/-X are supported for the device. If MSI/-X is
> - * supported return 1, else return 0.
> - **/
> -static int pci_msi_supported(struct pci_dev *dev, int nvec)
> -{
> -	struct pci_bus *bus;
> -
> -	/* MSI must be globally enabled and supported by the device */
> -	if (!pci_msi_enable)
> -		return 0;
> -
> -	if (!dev || dev->no_msi)
> -		return 0;
> -
> -	/*
> -	 * You can't ask to have 0 or less MSIs configured.
> -	 *  a) it's stupid ..
> -	 *  b) the list manipulation code assumes nvec >= 1.
> -	 */
> -	if (nvec < 1)
> -		return 0;
> -
> -	/*
> -	 * Any bridge which does NOT route MSI transactions from its
> -	 * secondary bus to its primary bus must set NO_MSI flag on
> -	 * the secondary pci_bus.
> -	 *
> -	 * The NO_MSI flag can either be set directly by:
> -	 * - arch-specific PCI host bus controller drivers (deprecated)
> -	 * - quirks for specific PCI bridges
> -	 *
> -	 * or indirectly by platform-specific PCI host bridge drivers by
> -	 * advertising the 'msi_domain' property, which results in
> -	 * the NO_MSI flag when no MSI domain is found for this bridge
> -	 * at probe time.
> -	 */
> -	for (bus = dev->bus; bus; bus = bus->parent)
> -		if (bus->bus_flags & PCI_BUS_FLAGS_NO_MSI)
> -			return 0;
> -
> -	return 1;
> -}
> -
> -/**
> - * pci_msi_vec_count - Return the number of MSI vectors a device can send
> - * @dev: device to report about
> - *
> - * This function returns the number of MSI vectors a device requested via
> - * Multiple Message Capable register. It returns a negative errno if the
> - * device is not capable sending MSI interrupts. Otherwise, the call succeeds
> - * and returns a power of two, up to a maximum of 2^5 (32), according to the
> - * MSI specification.
> - **/
> -int pci_msi_vec_count(struct pci_dev *dev)
> -{
> -	int ret;
> -	u16 msgctl;
> -
> -	if (!dev->msi_cap)
> -		return -EINVAL;
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &msgctl);
> -	ret = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
> -
> -	return ret;
> -}
> -EXPORT_SYMBOL(pci_msi_vec_count);
> -
> -static void pci_msi_shutdown(struct pci_dev *dev)
> -{
> -	struct msi_desc *desc;
> -
> -	if (!pci_msi_enable || !dev || !dev->msi_enabled)
> -		return;
> -
> -	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
> -	desc = first_pci_msi_entry(dev);
> -
> -	pci_msi_set_enable(dev, 0);
> -	pci_intx_for_msi(dev, 1);
> -	dev->msi_enabled = 0;
> -
> -	/* Return the device with MSI unmasked as initial states */
> -	pci_msi_unmask(desc, msi_multi_mask(desc));
> -
> -	/* Restore dev->irq to its default pin-assertion IRQ */
> -	dev->irq = desc->pci.msi_attrib.default_irq;
> -	pcibios_alloc_irq(dev);
> -}
> -
> -void pci_disable_msi(struct pci_dev *dev)
> -{
> -	if (!pci_msi_enable || !dev || !dev->msi_enabled)
> -		return;
> -
> -	pci_msi_shutdown(dev);
> -	free_msi_irqs(dev);
> -}
> -EXPORT_SYMBOL(pci_disable_msi);
> -
> -/**
> - * pci_msix_vec_count - return the number of device's MSI-X table entries
> - * @dev: pointer to the pci_dev data structure of MSI-X device function
> - * This function returns the number of device's MSI-X table entries and
> - * therefore the number of MSI-X vectors device is capable of sending.
> - * It returns a negative errno if the device is not capable of sending MSI-X
> - * interrupts.
> - **/
> -int pci_msix_vec_count(struct pci_dev *dev)
> -{
> -	u16 control;
> -
> -	if (!dev->msix_cap)
> -		return -EINVAL;
> -
> -	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
> -	return msix_table_size(control);
> -}
> -EXPORT_SYMBOL(pci_msix_vec_count);
> -
> -static int __pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries,
> -			     int nvec, struct irq_affinity *affd, int flags)
> -{
> -	int nr_entries;
> -	int i, j;
> -
> -	if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
> -		return -EINVAL;
> -
> -	nr_entries = pci_msix_vec_count(dev);
> -	if (nr_entries < 0)
> -		return nr_entries;
> -	if (nvec > nr_entries && !(flags & PCI_IRQ_VIRTUAL))
> -		return nr_entries;
> -
> -	if (entries) {
> -		/* Check for any invalid entries */
> -		for (i = 0; i < nvec; i++) {
> -			if (entries[i].entry >= nr_entries)
> -				return -EINVAL;		/* invalid entry */
> -			for (j = i + 1; j < nvec; j++) {
> -				if (entries[i].entry == entries[j].entry)
> -					return -EINVAL;	/* duplicate entry */
> -			}
> -		}
> -	}
> -
> -	/* Check whether driver already requested for MSI IRQ */
> -	if (dev->msi_enabled) {
> -		pci_info(dev, "can't enable MSI-X (MSI IRQ already assigned)\n");
> -		return -EINVAL;
> -	}
> -	return msix_capability_init(dev, entries, nvec, affd);
> -}
> -
> -static void pci_msix_shutdown(struct pci_dev *dev)
> -{
> -	struct msi_desc *entry;
> -
> -	if (!pci_msi_enable || !dev || !dev->msix_enabled)
> -		return;
> -
> -	if (pci_dev_is_disconnected(dev)) {
> -		dev->msix_enabled = 0;
> -		return;
> -	}
> -
> -	/* Return the device with MSI-X masked as initial states */
> -	for_each_pci_msi_entry(entry, dev)
> -		pci_msix_mask(entry);
> -
> -	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
> -	pci_intx_for_msi(dev, 1);
> -	dev->msix_enabled = 0;
> -	pcibios_alloc_irq(dev);
> -}
> -
> -void pci_disable_msix(struct pci_dev *dev)
> -{
> -	if (!pci_msi_enable || !dev || !dev->msix_enabled)
> -		return;
> -
> -	pci_msix_shutdown(dev);
> -	free_msi_irqs(dev);
> -}
> -EXPORT_SYMBOL(pci_disable_msix);
> -
> -void pci_no_msi(void)
> -{
> -	pci_msi_enable = 0;
> -}
> -
> -/**
> - * pci_msi_enabled - is MSI enabled?
> - *
> - * Returns true if MSI has not been disabled by the command-line option
> - * pci=nomsi.
> - **/
> -int pci_msi_enabled(void)
> -{
> -	return pci_msi_enable;
> -}
> -EXPORT_SYMBOL(pci_msi_enabled);
> -
> -static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
> -				  struct irq_affinity *affd)
> -{
> -	int nvec;
> -	int rc;
> -
> -	if (!pci_msi_supported(dev, minvec) || dev->current_state != PCI_D0)
> -		return -EINVAL;
> -
> -	/* Check whether driver already requested MSI-X IRQs */
> -	if (dev->msix_enabled) {
> -		pci_info(dev, "can't enable MSI (MSI-X already enabled)\n");
> -		return -EINVAL;
> -	}
> -
> -	if (maxvec < minvec)
> -		return -ERANGE;
> -
> -	if (WARN_ON_ONCE(dev->msi_enabled))
> -		return -EINVAL;
> -
> -	nvec = pci_msi_vec_count(dev);
> -	if (nvec < 0)
> -		return nvec;
> -	if (nvec < minvec)
> -		return -ENOSPC;
> -
> -	if (nvec > maxvec)
> -		nvec = maxvec;
> -
> -	for (;;) {
> -		if (affd) {
> -			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
> -			if (nvec < minvec)
> -				return -ENOSPC;
> -		}
> -
> -		rc = msi_capability_init(dev, nvec, affd);
> -		if (rc == 0)
> -			return nvec;
> -
> -		if (rc < 0)
> -			return rc;
> -		if (rc < minvec)
> -			return -ENOSPC;
> -
> -		nvec = rc;
> -	}
> -}
> -
> -/* deprecated, don't use */
> -int pci_enable_msi(struct pci_dev *dev)
> -{
> -	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
> -	if (rc < 0)
> -		return rc;
> -	return 0;
> -}
> -EXPORT_SYMBOL(pci_enable_msi);
> -
> -static int __pci_enable_msix_range(struct pci_dev *dev,
> -				   struct msix_entry *entries, int minvec,
> -				   int maxvec, struct irq_affinity *affd,
> -				   int flags)
> -{
> -	int rc, nvec = maxvec;
> -
> -	if (maxvec < minvec)
> -		return -ERANGE;
> -
> -	if (WARN_ON_ONCE(dev->msix_enabled))
> -		return -EINVAL;
> -
> -	for (;;) {
> -		if (affd) {
> -			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
> -			if (nvec < minvec)
> -				return -ENOSPC;
> -		}
> -
> -		rc = __pci_enable_msix(dev, entries, nvec, affd, flags);
> -		if (rc == 0)
> -			return nvec;
> -
> -		if (rc < 0)
> -			return rc;
> -		if (rc < minvec)
> -			return -ENOSPC;
> -
> -		nvec = rc;
> -	}
> -}
> -
> -/**
> - * pci_enable_msix_range - configure device's MSI-X capability structure
> - * @dev: pointer to the pci_dev data structure of MSI-X device function
> - * @entries: pointer to an array of MSI-X entries
> - * @minvec: minimum number of MSI-X IRQs requested
> - * @maxvec: maximum number of MSI-X IRQs requested
> - *
> - * Setup the MSI-X capability structure of device function with a maximum
> - * possible number of interrupts in the range between @minvec and @maxvec
> - * upon its software driver call to request for MSI-X mode enabled on its
> - * hardware device function. It returns a negative errno if an error occurs.
> - * If it succeeds, it returns the actual number of interrupts allocated and
> - * indicates the successful configuration of MSI-X capability structure
> - * with new allocated MSI-X interrupts.
> - **/
> -int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
> -		int minvec, int maxvec)
> -{
> -	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
> -}
> -EXPORT_SYMBOL(pci_enable_msix_range);
> -
> -/**
> - * pci_alloc_irq_vectors_affinity - allocate multiple IRQs for a device
> - * @dev:		PCI device to operate on
> - * @min_vecs:		minimum number of vectors required (must be >= 1)
> - * @max_vecs:		maximum (desired) number of vectors
> - * @flags:		flags or quirks for the allocation
> - * @affd:		optional description of the affinity requirements
> - *
> - * Allocate up to @max_vecs interrupt vectors for @dev, using MSI-X or MSI
> - * vectors if available, and fall back to a single legacy vector
> - * if neither is available.  Return the number of vectors allocated,
> - * (which might be smaller than @max_vecs) if successful, or a negative
> - * error code on error. If less than @min_vecs interrupt vectors are
> - * available for @dev the function will fail with -ENOSPC.
> - *
> - * To get the Linux IRQ number used for a vector that can be passed to
> - * request_irq() use the pci_irq_vector() helper.
> - */
> -int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
> -				   unsigned int max_vecs, unsigned int flags,
> -				   struct irq_affinity *affd)
> -{
> -	struct irq_affinity msi_default_affd = {0};
> -	int nvecs = -ENOSPC;
> -
> -	if (flags & PCI_IRQ_AFFINITY) {
> -		if (!affd)
> -			affd = &msi_default_affd;
> -	} else {
> -		if (WARN_ON(affd))
> -			affd = NULL;
> -	}
> -
> -	if (flags & PCI_IRQ_MSIX) {
> -		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
> -						affd, flags);
> -		if (nvecs > 0)
> -			return nvecs;
> -	}
> -
> -	if (flags & PCI_IRQ_MSI) {
> -		nvecs = __pci_enable_msi_range(dev, min_vecs, max_vecs, affd);
> -		if (nvecs > 0)
> -			return nvecs;
> -	}
> -
> -	/* use legacy IRQ if allowed */
> -	if (flags & PCI_IRQ_LEGACY) {
> -		if (min_vecs == 1 && dev->irq) {
> -			/*
> -			 * Invoke the affinity spreading logic to ensure that
> -			 * the device driver can adjust queue configuration
> -			 * for the single interrupt case.
> -			 */
> -			if (affd)
> -				irq_create_affinity_masks(1, affd);
> -			pci_intx(dev, 1);
> -			return 1;
> -		}
> -	}
> -
> -	return nvecs;
> -}
> -EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
> -
> -/**
> - * pci_free_irq_vectors - free previously allocated IRQs for a device
> - * @dev:		PCI device to operate on
> - *
> - * Undoes the allocations and enabling in pci_alloc_irq_vectors().
> - */
> -void pci_free_irq_vectors(struct pci_dev *dev)
> -{
> -	pci_disable_msix(dev);
> -	pci_disable_msi(dev);
> -}
> -EXPORT_SYMBOL(pci_free_irq_vectors);
> -
> -/**
> - * pci_irq_vector - return Linux IRQ number of a device vector
> - * @dev:	PCI device to operate on
> - * @nr:		Interrupt vector index (0-based)
> - *
> - * @nr has the following meanings depending on the interrupt mode:
> - *   MSI-X:	The index in the MSI-X vector table
> - *   MSI:	The index of the enabled MSI vectors
> - *   INTx:	Must be 0
> - *
> - * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
> - */
> -int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
> -{
> -	if (dev->msix_enabled) {
> -		struct msi_desc *entry;
> -
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->pci.msi_attrib.entry_nr == nr)
> -				return entry->irq;
> -		}
> -		WARN_ON_ONCE(1);
> -		return -EINVAL;
> -	}
> -
> -	if (dev->msi_enabled) {
> -		struct msi_desc *entry = first_pci_msi_entry(dev);
> -
> -		if (WARN_ON_ONCE(nr >= entry->nvec_used))
> -			return -EINVAL;
> -	} else {
> -		if (WARN_ON_ONCE(nr > 0))
> -			return -EINVAL;
> -	}
> -
> -	return dev->irq + nr;
> -}
> -EXPORT_SYMBOL(pci_irq_vector);
> -
> -/**
> - * pci_irq_get_affinity - return the affinity of a particular MSI vector
> - * @dev:	PCI device to operate on
> - * @nr:		device-relative interrupt vector index (0-based).
> - *
> - * @nr has the following meanings depending on the interrupt mode:
> - *   MSI-X:	The index in the MSI-X vector table
> - *   MSI:	The index of the enabled MSI vectors
> - *   INTx:	Must be 0
> - *
> - * Return: A cpumask pointer or NULL if @nr is out of range
> - */
> -const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
> -{
> -	if (dev->msix_enabled) {
> -		struct msi_desc *entry;
> -
> -		for_each_pci_msi_entry(entry, dev) {
> -			if (entry->pci.msi_attrib.entry_nr == nr)
> -				return &entry->affinity->mask;
> -		}
> -		WARN_ON_ONCE(1);
> -		return NULL;
> -	} else if (dev->msi_enabled) {
> -		struct msi_desc *entry = first_pci_msi_entry(dev);
> -
> -		if (WARN_ON_ONCE(!entry || !entry->affinity ||
> -				 nr >= entry->nvec_used))
> -			return NULL;
> -
> -		return &entry->affinity[nr].mask;
> -	} else {
> -		return cpu_possible_mask;
> -	}
> -}
> -EXPORT_SYMBOL(pci_irq_get_affinity);
> -
> -struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
> -{
> -	return to_pci_dev(desc->dev);
> -}
> -EXPORT_SYMBOL(msi_desc_to_pci_dev);
> -
> -#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> -/**
> - * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
> - * @irq_data:	Pointer to interrupt data of the MSI interrupt
> - * @msg:	Pointer to the message
> - */
> -static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> -{
> -	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
> -
> -	/*
> -	 * For MSI-X desc->irq is always equal to irq_data->irq. For
> -	 * MSI only the first interrupt of MULTI MSI passes the test.
> -	 */
> -	if (desc->irq == irq_data->irq)
> -		__pci_write_msi_msg(desc, msg);
> -}
> -
> -/**
> - * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
> - * @desc:	Pointer to the MSI descriptor
> - *
> - * The ID number is only used within the irqdomain.
> - */
> -static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
> -{
> -	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
> -
> -	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
> -		pci_dev_id(dev) << 11 |
> -		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> -}
> -
> -static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
> -{
> -	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
> -}
> -
> -/**
> - * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
> - * 			      for @dev
> - * @domain:	The interrupt domain to check
> - * @info:	The domain info for verification
> - * @dev:	The device to check
> - *
> - * Returns:
> - *  0 if the functionality is supported
> - *  1 if Multi MSI is requested, but the domain does not support it
> - *  -ENOTSUPP otherwise
> - */
> -int pci_msi_domain_check_cap(struct irq_domain *domain,
> -			     struct msi_domain_info *info, struct device *dev)
> -{
> -	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
> -
> -	/* Special handling to support __pci_enable_msi_range() */
> -	if (pci_msi_desc_is_multi_msi(desc) &&
> -	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
> -		return 1;
> -	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
> -		return -ENOTSUPP;
> -
> -	return 0;
> -}
> -
> -static int pci_msi_domain_handle_error(struct irq_domain *domain,
> -				       struct msi_desc *desc, int error)
> -{
> -	/* Special handling to support __pci_enable_msi_range() */
> -	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
> -		return 1;
> -
> -	return error;
> -}
> -
> -static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
> -				    struct msi_desc *desc)
> -{
> -	arg->desc = desc;
> -	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
> -}
> -
> -static struct msi_domain_ops pci_msi_domain_ops_default = {
> -	.set_desc	= pci_msi_domain_set_desc,
> -	.msi_check	= pci_msi_domain_check_cap,
> -	.handle_error	= pci_msi_domain_handle_error,
> -};
> -
> -static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
> -{
> -	struct msi_domain_ops *ops = info->ops;
> -
> -	if (ops == NULL) {
> -		info->ops = &pci_msi_domain_ops_default;
> -	} else {
> -		if (ops->set_desc == NULL)
> -			ops->set_desc = pci_msi_domain_set_desc;
> -		if (ops->msi_check == NULL)
> -			ops->msi_check = pci_msi_domain_check_cap;
> -		if (ops->handle_error == NULL)
> -			ops->handle_error = pci_msi_domain_handle_error;
> -	}
> -}
> -
> -static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
> -{
> -	struct irq_chip *chip = info->chip;
> -
> -	BUG_ON(!chip);
> -	if (!chip->irq_write_msi_msg)
> -		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
> -	if (!chip->irq_mask)
> -		chip->irq_mask = pci_msi_mask_irq;
> -	if (!chip->irq_unmask)
> -		chip->irq_unmask = pci_msi_unmask_irq;
> -}
> -
> -/**
> - * pci_msi_create_irq_domain - Create a MSI interrupt domain
> - * @fwnode:	Optional fwnode of the interrupt controller
> - * @info:	MSI domain info
> - * @parent:	Parent irq domain
> - *
> - * Updates the domain and chip ops and creates a MSI interrupt domain.
> - *
> - * Returns:
> - * A domain pointer or NULL in case of failure.
> - */
> -struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
> -					     struct msi_domain_info *info,
> -					     struct irq_domain *parent)
> -{
> -	struct irq_domain *domain;
> -
> -	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
> -		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
> -
> -	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
> -		pci_msi_domain_update_dom_ops(info);
> -	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
> -		pci_msi_domain_update_chip_ops(info);
> -
> -	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
> -	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
> -		info->flags |= MSI_FLAG_MUST_REACTIVATE;
> -
> -	/* PCI-MSI is oneshot-safe */
> -	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
> -
> -	domain = msi_create_irq_domain(fwnode, info, parent);
> -	if (!domain)
> -		return NULL;
> -
> -	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
> -	return domain;
> -}
> -EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
> -
> -/*
> - * Users of the generic MSI infrastructure expect a device to have a single ID,
> - * so with DMA aliases we have to pick the least-worst compromise. Devices with
> - * DMA phantom functions tend to still emit MSIs from the real function number,
> - * so we ignore those and only consider topological aliases where either the
> - * alias device or RID appears on a different bus number. We also make the
> - * reasonable assumption that bridges are walked in an upstream direction (so
> - * the last one seen wins), and the much braver assumption that the most likely
> - * case is that of PCI->PCIe so we should always use the alias RID. This echoes
> - * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
> - * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
> - * for taking ownership all we can really do is close our eyes and hope...
> - */
> -static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
> -{
> -	u32 *pa = data;
> -	u8 bus = PCI_BUS_NUM(*pa);
> -
> -	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
> -		*pa = alias;
> -
> -	return 0;
> -}
> -
> -/**
> - * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
> - * @domain:	The interrupt domain
> - * @pdev:	The PCI device.
> - *
> - * The RID for a device is formed from the alias, with a firmware
> - * supplied mapping applied
> - *
> - * Returns: The RID.
> - */
> -u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
> -{
> -	struct device_node *of_node;
> -	u32 rid = pci_dev_id(pdev);
> -
> -	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> -
> -	of_node = irq_domain_get_of_node(domain);
> -	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
> -			iort_msi_map_id(&pdev->dev, rid);
> -
> -	return rid;
> -}
> -
> -/**
> - * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
> - * @pdev:	The PCI device
> - *
> - * Use the firmware data to find a device-specific MSI domain
> - * (i.e. not one that is set as a default).
> - *
> - * Returns: The corresponding MSI domain or NULL if none has been found.
> - */
> -struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
> -{
> -	struct irq_domain *dom;
> -	u32 rid = pci_dev_id(pdev);
> -
> -	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> -	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
> -	if (!dom)
> -		dom = iort_get_device_domain(&pdev->dev, rid,
> -					     DOMAIN_BUS_PCI_MSI);
> -	return dom;
> -}
> -
> -/**
> - * pci_dev_has_special_msi_domain - Check whether the device is handled by
> - *				    a non-standard PCI-MSI domain
> - * @pdev:	The PCI device to check.
> - *
> - * Returns: True if the device irqdomain or the bus irqdomain is
> - * non-standard PCI/MSI.
> - */
> -bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
> -{
> -	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
> -
> -	if (!dom)
> -		dom = dev_get_msi_domain(&pdev->bus->dev);
> -
> -	if (!dom)
> -		return true;
> -
> -	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
> -}
> -
> -#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
> -#endif /* CONFIG_PCI_MSI */
> -
> -void pci_msi_init(struct pci_dev *dev)
> -{
> -	u16 ctrl;
> -
> -	/*
> -	 * Disable the MSI hardware to avoid screaming interrupts
> -	 * during boot.  This is the power on reset default so
> -	 * usually this should be a noop.
> -	 */
> -	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
> -	if (!dev->msi_cap)
> -		return;
> -
> -	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
> -	if (ctrl & PCI_MSI_FLAGS_ENABLE)
> -		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
> -				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
> -
> -	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
> -		dev->no_64bit_msi = 1;
> -}
> -
> -void pci_msix_init(struct pci_dev *dev)
> -{
> -	u16 ctrl;
> -
> -	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
> -	if (!dev->msix_cap)
> -		return;
> -
> -	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> -	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
> -		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
> -				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
> -}
> --- /dev/null
> +++ b/drivers/pci/msi/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Makefile for the PCI/MSI
> +obj-$(CONFIG_PCI)		+= msi.o
> --- /dev/null
> +++ b/drivers/pci/msi/msi.c
> @@ -0,0 +1,1532 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * PCI Message Signaled Interrupt (MSI)
> + *
> + * Copyright (C) 2003-2004 Intel
> + * Copyright (C) Tom Long Nguyen (tom.l.nguyen@intel.com)
> + * Copyright (C) 2016 Christoph Hellwig.
> + */
> +
> +#include <linux/acpi_iort.h>
> +#include <linux/err.h>
> +#include <linux/export.h>
> +#include <linux/irq.h>
> +#include <linux/irqdomain.h>
> +#include <linux/msi.h>
> +#include <linux/of_irq.h>
> +#include <linux/pci.h>
> +
> +#include "../pci.h"
> +
> +#ifdef CONFIG_PCI_MSI
> +
> +static int pci_msi_enable = 1;
> +int pci_msi_ignore_mask;
> +
> +#define msix_table_size(flags)	((flags & PCI_MSIX_FLAGS_QSIZE) + 1)
> +
> +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> +static int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	struct irq_domain *domain;
> +
> +	domain = dev_get_msi_domain(&dev->dev);
> +	if (domain && irq_domain_is_hierarchy(domain))
> +		return msi_domain_alloc_irqs(domain, &dev->dev, nvec);
> +
> +	return arch_setup_msi_irqs(dev, nvec, type);
> +}
> +
> +static void pci_msi_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	struct irq_domain *domain;
> +
> +	domain = dev_get_msi_domain(&dev->dev);
> +	if (domain && irq_domain_is_hierarchy(domain))
> +		msi_domain_free_irqs(domain, &dev->dev);
> +	else
> +		arch_teardown_msi_irqs(dev);
> +}
> +#else
> +#define pci_msi_setup_msi_irqs		arch_setup_msi_irqs
> +#define pci_msi_teardown_msi_irqs	arch_teardown_msi_irqs
> +#endif
> +
> +#ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS
> +/* Arch hooks */
> +int __weak arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc)
> +{
> +	return -EINVAL;
> +}
> +
> +void __weak arch_teardown_msi_irq(unsigned int irq)
> +{
> +}
> +
> +int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> +{
> +	struct msi_desc *entry;
> +	int ret;
> +
> +	/*
> +	 * If an architecture wants to support multiple MSI, it needs to
> +	 * override arch_setup_msi_irqs()
> +	 */
> +	if (type == PCI_CAP_ID_MSI && nvec > 1)
> +		return 1;
> +
> +	for_each_pci_msi_entry(entry, dev) {
> +		ret = arch_setup_msi_irq(dev, entry);
> +		if (ret < 0)
> +			return ret;
> +		if (ret > 0)
> +			return -ENOSPC;
> +	}
> +
> +	return 0;
> +}
> +
> +void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
> +{
> +	int i;
> +	struct msi_desc *entry;
> +
> +	for_each_pci_msi_entry(entry, dev)
> +		if (entry->irq)
> +			for (i = 0; i < entry->nvec_used; i++)
> +				arch_teardown_msi_irq(entry->irq + i);
> +}
> +#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
> +
> +/*
> + * PCI 2.3 does not specify mask bits for each MSI interrupt.  Attempting to
> + * mask all MSI interrupts by clearing the MSI enable bit does not work
> + * reliably as devices without an INTx disable bit will then generate a
> + * level IRQ which will never be cleared.
> + */
> +static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
> +{
> +	/* Don't shift by >= width of type */
> +	if (desc->pci.msi_attrib.multi_cap >= 5)
> +		return 0xffffffff;
> +	return (1 << (1 << desc->pci.msi_attrib.multi_cap)) - 1;
> +}
> +
> +static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
> +{
> +	raw_spinlock_t *lock = &desc->dev->msi_lock;
> +	unsigned long flags;
> +
> +	if (!desc->pci.msi_attrib.can_mask)
> +		return;
> +
> +	raw_spin_lock_irqsave(lock, flags);
> +	desc->pci.msi_mask &= ~clear;
> +	desc->pci.msi_mask |= set;
> +	pci_write_config_dword(msi_desc_to_pci_dev(desc), desc->pci.mask_pos,
> +			       desc->pci.msi_mask);
> +	raw_spin_unlock_irqrestore(lock, flags);
> +}
> +
> +static inline void pci_msi_mask(struct msi_desc *desc, u32 mask)
> +{
> +	pci_msi_update_mask(desc, 0, mask);
> +}
> +
> +static inline void pci_msi_unmask(struct msi_desc *desc, u32 mask)
> +{
> +	pci_msi_update_mask(desc, mask, 0);
> +}
> +
> +static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
> +{
> +	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
> +}
> +
> +/*
> + * This internal function does not flush PCI writes to the device.  All
> + * users must ensure that they read from the device before either assuming
> + * that the device state is up to date, or returning out of this file.
> + * It does not affect the msi_desc::msix_ctrl cache either. Use with care!
> + */
> +static void pci_msix_write_vector_ctrl(struct msi_desc *desc, u32 ctrl)
> +{
> +	void __iomem *desc_addr = pci_msix_desc_addr(desc);
> +
> +	if (desc->pci.msi_attrib.can_mask)
> +		writel(ctrl, desc_addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> +}
> +
> +static inline void pci_msix_mask(struct msi_desc *desc)
> +{
> +	desc->pci.msix_ctrl |= PCI_MSIX_ENTRY_CTRL_MASKBIT;
> +	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
> +	/* Flush write to device */
> +	readl(desc->pci.mask_base);
> +}
> +
> +static inline void pci_msix_unmask(struct msi_desc *desc)
> +{
> +	desc->pci.msix_ctrl &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT;
> +	pci_msix_write_vector_ctrl(desc, desc->pci.msix_ctrl);
> +}
> +
> +static void __pci_msi_mask_desc(struct msi_desc *desc, u32 mask)
> +{
> +	if (desc->pci.msi_attrib.is_msix)
> +		pci_msix_mask(desc);
> +	else
> +		pci_msi_mask(desc, mask);
> +}
> +
> +static void __pci_msi_unmask_desc(struct msi_desc *desc, u32 mask)
> +{
> +	if (desc->pci.msi_attrib.is_msix)
> +		pci_msix_unmask(desc);
> +	else
> +		pci_msi_unmask(desc, mask);
> +}
> +
> +/**
> + * pci_msi_mask_irq - Generic IRQ chip callback to mask PCI/MSI interrupts
> + * @data:	pointer to irqdata associated to that interrupt
> + */
> +void pci_msi_mask_irq(struct irq_data *data)
> +{
> +	struct msi_desc *desc = irq_data_get_msi_desc(data);
> +
> +	__pci_msi_mask_desc(desc, BIT(data->irq - desc->irq));
> +}
> +EXPORT_SYMBOL_GPL(pci_msi_mask_irq);
> +
> +/**
> + * pci_msi_unmask_irq - Generic IRQ chip callback to unmask PCI/MSI interrupts
> + * @data:	pointer to irqdata associated to that interrupt
> + */
> +void pci_msi_unmask_irq(struct irq_data *data)
> +{
> +	struct msi_desc *desc = irq_data_get_msi_desc(data);
> +
> +	__pci_msi_unmask_desc(desc, BIT(data->irq - desc->irq));
> +}
> +EXPORT_SYMBOL_GPL(pci_msi_unmask_irq);
> +
> +void __pci_read_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
> +{
> +	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
> +
> +	BUG_ON(dev->current_state != PCI_D0);
> +
> +	if (entry->pci.msi_attrib.is_msix) {
> +		void __iomem *base = pci_msix_desc_addr(entry);
> +
> +		if (WARN_ON_ONCE(entry->pci.msi_attrib.is_virtual))
> +			return;
> +
> +		msg->address_lo = readl(base + PCI_MSIX_ENTRY_LOWER_ADDR);
> +		msg->address_hi = readl(base + PCI_MSIX_ENTRY_UPPER_ADDR);
> +		msg->data = readl(base + PCI_MSIX_ENTRY_DATA);
> +	} else {
> +		int pos = dev->msi_cap;
> +		u16 data;
> +
> +		pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
> +				      &msg->address_lo);
> +		if (entry->pci.msi_attrib.is_64) {
> +			pci_read_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
> +					      &msg->address_hi);
> +			pci_read_config_word(dev, pos + PCI_MSI_DATA_64, &data);
> +		} else {
> +			msg->address_hi = 0;
> +			pci_read_config_word(dev, pos + PCI_MSI_DATA_32, &data);
> +		}
> +		msg->data = data;
> +	}
> +}
> +
> +void __pci_write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
> +{
> +	struct pci_dev *dev = msi_desc_to_pci_dev(entry);
> +
> +	if (dev->current_state != PCI_D0 || pci_dev_is_disconnected(dev)) {
> +		/* Don't touch the hardware now */
> +	} else if (entry->pci.msi_attrib.is_msix) {
> +		void __iomem *base = pci_msix_desc_addr(entry);
> +		u32 ctrl = entry->pci.msix_ctrl;
> +		bool unmasked = !(ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT);
> +
> +		if (entry->pci.msi_attrib.is_virtual)
> +			goto skip;
> +
> +		/*
> +		 * The specification mandates that the entry is masked
> +		 * when the message is modified:
> +		 *
> +		 * "If software changes the Address or Data value of an
> +		 * entry while the entry is unmasked, the result is
> +		 * undefined."
> +		 */
> +		if (unmasked)
> +			pci_msix_write_vector_ctrl(entry, ctrl | PCI_MSIX_ENTRY_CTRL_MASKBIT);
> +
> +		writel(msg->address_lo, base + PCI_MSIX_ENTRY_LOWER_ADDR);
> +		writel(msg->address_hi, base + PCI_MSIX_ENTRY_UPPER_ADDR);
> +		writel(msg->data, base + PCI_MSIX_ENTRY_DATA);
> +
> +		if (unmasked)
> +			pci_msix_write_vector_ctrl(entry, ctrl);
> +
> +		/* Ensure that the writes are visible in the device */
> +		readl(base + PCI_MSIX_ENTRY_DATA);
> +	} else {
> +		int pos = dev->msi_cap;
> +		u16 msgctl;
> +
> +		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
> +		msgctl &= ~PCI_MSI_FLAGS_QSIZE;
> +		msgctl |= entry->pci.msi_attrib.multiple << 4;
> +		pci_write_config_word(dev, pos + PCI_MSI_FLAGS, msgctl);
> +
> +		pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_LO,
> +				       msg->address_lo);
> +		if (entry->pci.msi_attrib.is_64) {
> +			pci_write_config_dword(dev, pos + PCI_MSI_ADDRESS_HI,
> +					       msg->address_hi);
> +			pci_write_config_word(dev, pos + PCI_MSI_DATA_64,
> +					      msg->data);
> +		} else {
> +			pci_write_config_word(dev, pos + PCI_MSI_DATA_32,
> +					      msg->data);
> +		}
> +		/* Ensure that the writes are visible in the device */
> +		pci_read_config_word(dev, pos + PCI_MSI_FLAGS, &msgctl);
> +	}
> +
> +skip:
> +	entry->msg = *msg;
> +
> +	if (entry->write_msi_msg)
> +		entry->write_msi_msg(entry, entry->write_msi_msg_data);
> +
> +}
> +
> +void pci_write_msi_msg(unsigned int irq, struct msi_msg *msg)
> +{
> +	struct msi_desc *entry = irq_get_msi_desc(irq);
> +
> +	__pci_write_msi_msg(entry, msg);
> +}
> +EXPORT_SYMBOL_GPL(pci_write_msi_msg);
> +
> +static void free_msi_irqs(struct pci_dev *dev)
> +{
> +	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
> +	struct msi_desc *entry, *tmp;
> +	int i;
> +
> +	for_each_pci_msi_entry(entry, dev)
> +		if (entry->irq)
> +			for (i = 0; i < entry->nvec_used; i++)
> +				BUG_ON(irq_has_action(entry->irq + i));
> +
> +	if (dev->msi_irq_groups) {
> +		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
> +		dev->msi_irq_groups = NULL;
> +	}
> +
> +	pci_msi_teardown_msi_irqs(dev);
> +
> +	list_for_each_entry_safe(entry, tmp, msi_list, list) {
> +		if (entry->pci.msi_attrib.is_msix) {
> +			if (list_is_last(&entry->list, msi_list))
> +				iounmap(entry->pci.mask_base);
> +		}
> +
> +		list_del(&entry->list);
> +		free_msi_entry(entry);
> +	}
> +}
> +
> +static void pci_intx_for_msi(struct pci_dev *dev, int enable)
> +{
> +	if (!(dev->dev_flags & PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG))
> +		pci_intx(dev, enable);
> +}
> +
> +static void pci_msi_set_enable(struct pci_dev *dev, int enable)
> +{
> +	u16 control;
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> +	control &= ~PCI_MSI_FLAGS_ENABLE;
> +	if (enable)
> +		control |= PCI_MSI_FLAGS_ENABLE;
> +	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
> +}
> +
> +/*
> + * Architecture override returns true when the PCI MSI message should be
> + * written by the generic restore function.
> + */
> +bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
> +{
> +	return true;
> +}
> +
> +static void __pci_restore_msi_state(struct pci_dev *dev)
> +{
> +	struct msi_desc *entry;
> +	u16 control;
> +
> +	if (!dev->msi_enabled)
> +		return;
> +
> +	entry = irq_get_msi_desc(dev->irq);
> +
> +	pci_intx_for_msi(dev, 0);
> +	pci_msi_set_enable(dev, 0);
> +	if (arch_restore_msi_irqs(dev))
> +		__pci_write_msi_msg(entry, &entry->msg);
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> +	pci_msi_update_mask(entry, 0, 0);
> +	control &= ~PCI_MSI_FLAGS_QSIZE;
> +	control |= (entry->pci.msi_attrib.multiple << 4) | PCI_MSI_FLAGS_ENABLE;
> +	pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, control);
> +}
> +
> +static void pci_msix_clear_and_set_ctrl(struct pci_dev *dev, u16 clear, u16 set)
> +{
> +	u16 ctrl;
> +
> +	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> +	ctrl &= ~clear;
> +	ctrl |= set;
> +	pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, ctrl);
> +}
> +
> +static void __pci_restore_msix_state(struct pci_dev *dev)
> +{
> +	struct msi_desc *entry;
> +	bool write_msg;
> +
> +	if (!dev->msix_enabled)
> +		return;
> +	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
> +
> +	/* route the table */
> +	pci_intx_for_msi(dev, 0);
> +	pci_msix_clear_and_set_ctrl(dev, 0,
> +				PCI_MSIX_FLAGS_ENABLE | PCI_MSIX_FLAGS_MASKALL);
> +
> +	write_msg = arch_restore_msi_irqs(dev);
> +
> +	for_each_pci_msi_entry(entry, dev) {
> +		if (write_msg)
> +			__pci_write_msi_msg(entry, &entry->msg);
> +		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
> +	}
> +
> +	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
> +}
> +
> +void pci_restore_msi_state(struct pci_dev *dev)
> +{
> +	__pci_restore_msi_state(dev);
> +	__pci_restore_msix_state(dev);
> +}
> +EXPORT_SYMBOL_GPL(pci_restore_msi_state);
> +
> +static struct msi_desc *
> +msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
> +{
> +	struct irq_affinity_desc *masks = NULL;
> +	struct msi_desc *entry;
> +	u16 control;
> +
> +	if (affd)
> +		masks = irq_create_affinity_masks(nvec, affd);
> +
> +	/* MSI Entry Initialization */
> +	entry = alloc_msi_entry(&dev->dev, nvec, masks);
> +	if (!entry)
> +		goto out;
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
> +	/* Lies, damned lies, and MSIs */
> +	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
> +		control |= PCI_MSI_FLAGS_MASKBIT;
> +
> +	entry->pci.msi_attrib.is_msix	= 0;
> +	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
> +	entry->pci.msi_attrib.is_virtual    = 0;
> +	entry->pci.msi_attrib.entry_nr	= 0;
> +	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> +					  !!(control & PCI_MSI_FLAGS_MASKBIT);
> +	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
> +	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
> +	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
> +
> +	if (control & PCI_MSI_FLAGS_64BIT)
> +		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
> +	else
> +		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
> +
> +	/* Save the initial mask status */
> +	if (entry->pci.msi_attrib.can_mask)
> +		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
> +
> +out:
> +	kfree(masks);
> +	return entry;
> +}
> +
> +static int msi_verify_entries(struct pci_dev *dev)
> +{
> +	struct msi_desc *entry;
> +
> +	if (!dev->no_64bit_msi)
> +		return 0;
> +
> +	for_each_pci_msi_entry(entry, dev) {
> +		if (entry->msg.address_hi) {
> +			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
> +				entry->msg.address_hi, entry->msg.address_lo);
> +			return -EIO;
> +		}
> +	}
> +	return 0;
> +}
> +
> +/**
> + * msi_capability_init - configure device's MSI capability structure
> + * @dev: pointer to the pci_dev data structure of MSI device function
> + * @nvec: number of interrupts to allocate
> + * @affd: description of automatic IRQ affinity assignments (may be %NULL)
> + *
> + * Setup the MSI capability structure of the device with the requested
> + * number of interrupts.  A return value of zero indicates the successful
> + * setup of an entry with the new MSI IRQ.  A negative return value indicates
> + * an error, and a positive return value indicates the number of interrupts
> + * which could have been allocated.
> + */
> +static int msi_capability_init(struct pci_dev *dev, int nvec,
> +			       struct irq_affinity *affd)
> +{
> +	const struct attribute_group **groups;
> +	struct msi_desc *entry;
> +	int ret;
> +
> +	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
> +
> +	entry = msi_setup_entry(dev, nvec, affd);
> +	if (!entry)
> +		return -ENOMEM;
> +
> +	/* All MSIs are unmasked by default; mask them all */
> +	pci_msi_mask(entry, msi_multi_mask(entry));
> +
> +	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> +
> +	/* Configure MSI capability structure */
> +	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
> +	if (ret)
> +		goto err;
> +
> +	ret = msi_verify_entries(dev);
> +	if (ret)
> +		goto err;
> +
> +	groups = msi_populate_sysfs(&dev->dev);
> +	if (IS_ERR(groups)) {
> +		ret = PTR_ERR(groups);
> +		goto err;
> +	}
> +
> +	dev->msi_irq_groups = groups;
> +
> +	/* Set MSI enabled bits	*/
> +	pci_intx_for_msi(dev, 0);
> +	pci_msi_set_enable(dev, 1);
> +	dev->msi_enabled = 1;
> +
> +	pcibios_free_irq(dev);
> +	dev->irq = entry->irq;
> +	return 0;
> +
> +err:
> +	pci_msi_unmask(entry, msi_multi_mask(entry));
> +	free_msi_irqs(dev);
> +	return ret;
> +}
> +
> +static void __iomem *msix_map_region(struct pci_dev *dev,
> +				     unsigned int nr_entries)
> +{
> +	resource_size_t phys_addr;
> +	u32 table_offset;
> +	unsigned long flags;
> +	u8 bir;
> +
> +	pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,
> +			      &table_offset);
> +	bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);
> +	flags = pci_resource_flags(dev, bir);
> +	if (!flags || (flags & IORESOURCE_UNSET))
> +		return NULL;
> +
> +	table_offset &= PCI_MSIX_TABLE_OFFSET;
> +	phys_addr = pci_resource_start(dev, bir) + table_offset;
> +
> +	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
> +}
> +
> +static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
> +			      struct msix_entry *entries, int nvec,
> +			      struct irq_affinity *affd)
> +{
> +	struct irq_affinity_desc *curmsk, *masks = NULL;
> +	struct msi_desc *entry;
> +	void __iomem *addr;
> +	int ret, i;
> +	int vec_count = pci_msix_vec_count(dev);
> +
> +	if (affd)
> +		masks = irq_create_affinity_masks(nvec, affd);
> +
> +	for (i = 0, curmsk = masks; i < nvec; i++) {
> +		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
> +		if (!entry) {
> +			if (!i)
> +				iounmap(base);
> +			else
> +				free_msi_irqs(dev);
> +			/* No enough memory. Don't try again */
> +			ret = -ENOMEM;
> +			goto out;
> +		}
> +
> +		entry->pci.msi_attrib.is_msix	= 1;
> +		entry->pci.msi_attrib.is_64	= 1;
> +
> +		if (entries)
> +			entry->pci.msi_attrib.entry_nr = entries[i].entry;
> +		else
> +			entry->pci.msi_attrib.entry_nr = i;
> +
> +		entry->pci.msi_attrib.is_virtual =
> +			entry->pci.msi_attrib.entry_nr >= vec_count;
> +
> +		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> +						  !entry->pci.msi_attrib.is_virtual;
> +
> +		entry->pci.msi_attrib.default_irq	= dev->irq;
> +		entry->pci.mask_base			= base;
> +
> +		if (entry->pci.msi_attrib.can_mask) {
> +			addr = pci_msix_desc_addr(entry);
> +			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> +		}
> +
> +		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> +		if (masks)
> +			curmsk++;
> +	}
> +	ret = 0;
> +out:
> +	kfree(masks);
> +	return ret;
> +}
> +
> +static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
> +{
> +	struct msi_desc *entry;
> +
> +	if (entries) {
> +		for_each_pci_msi_entry(entry, dev) {
> +			entries->vector = entry->irq;
> +			entries++;
> +		}
> +	}
> +}
> +
> +static void msix_mask_all(void __iomem *base, int tsize)
> +{
> +	u32 ctrl = PCI_MSIX_ENTRY_CTRL_MASKBIT;
> +	int i;
> +
> +	if (pci_msi_ignore_mask)
> +		return;
> +
> +	for (i = 0; i < tsize; i++, base += PCI_MSIX_ENTRY_SIZE)
> +		writel(ctrl, base + PCI_MSIX_ENTRY_VECTOR_CTRL);
> +}
> +
> +/**
> + * msix_capability_init - configure device's MSI-X capability
> + * @dev: pointer to the pci_dev data structure of MSI-X device function
> + * @entries: pointer to an array of struct msix_entry entries
> + * @nvec: number of @entries
> + * @affd: Optional pointer to enable automatic affinity assignment
> + *
> + * Setup the MSI-X capability structure of device function with a
> + * single MSI-X IRQ. A return of zero indicates the successful setup of
> + * requested MSI-X entries with allocated IRQs or non-zero for otherwise.
> + **/
> +static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
> +				int nvec, struct irq_affinity *affd)
> +{
> +	const struct attribute_group **groups;
> +	void __iomem *base;
> +	int ret, tsize;
> +	u16 control;
> +
> +	/*
> +	 * Some devices require MSI-X to be enabled before the MSI-X
> +	 * registers can be accessed.  Mask all the vectors to prevent
> +	 * interrupts coming in before they're fully set up.
> +	 */
> +	pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
> +				    PCI_MSIX_FLAGS_ENABLE);
> +
> +	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
> +	/* Request & Map MSI-X table region */
> +	tsize = msix_table_size(control);
> +	base = msix_map_region(dev, tsize);
> +	if (!base) {
> +		ret = -ENOMEM;
> +		goto out_disable;
> +	}
> +
> +	/* Ensure that all table entries are masked. */
> +	msix_mask_all(base, tsize);
> +
> +	ret = msix_setup_entries(dev, base, entries, nvec, affd);
> +	if (ret)
> +		goto out_disable;
> +
> +	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
> +	if (ret)
> +		goto out_avail;
> +
> +	/* Check if all MSI entries honor device restrictions */
> +	ret = msi_verify_entries(dev);
> +	if (ret)
> +		goto out_free;
> +
> +	msix_update_entries(dev, entries);
> +
> +	groups = msi_populate_sysfs(&dev->dev);
> +	if (IS_ERR(groups)) {
> +		ret = PTR_ERR(groups);
> +		goto out_free;
> +	}
> +
> +	dev->msi_irq_groups = groups;
> +
> +	/* Set MSI-X enabled bits and unmask the function */
> +	pci_intx_for_msi(dev, 0);
> +	dev->msix_enabled = 1;
> +	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
> +
> +	pcibios_free_irq(dev);
> +	return 0;
> +
> +out_avail:
> +	if (ret < 0) {
> +		/*
> +		 * If we had some success, report the number of IRQs
> +		 * we succeeded in setting up.
> +		 */
> +		struct msi_desc *entry;
> +		int avail = 0;
> +
> +		for_each_pci_msi_entry(entry, dev) {
> +			if (entry->irq != 0)
> +				avail++;
> +		}
> +		if (avail != 0)
> +			ret = avail;
> +	}
> +
> +out_free:
> +	free_msi_irqs(dev);
> +
> +out_disable:
> +	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
> +
> +	return ret;
> +}
> +
> +/**
> + * pci_msi_supported - check whether MSI may be enabled on a device
> + * @dev: pointer to the pci_dev data structure of MSI device function
> + * @nvec: how many MSIs have been requested?
> + *
> + * Look at global flags, the device itself, and its parent buses
> + * to determine if MSI/-X are supported for the device. If MSI/-X is
> + * supported return 1, else return 0.
> + **/
> +static int pci_msi_supported(struct pci_dev *dev, int nvec)
> +{
> +	struct pci_bus *bus;
> +
> +	/* MSI must be globally enabled and supported by the device */
> +	if (!pci_msi_enable)
> +		return 0;
> +
> +	if (!dev || dev->no_msi)
> +		return 0;
> +
> +	/*
> +	 * You can't ask to have 0 or less MSIs configured.
> +	 *  a) it's stupid ..
> +	 *  b) the list manipulation code assumes nvec >= 1.
> +	 */
> +	if (nvec < 1)
> +		return 0;
> +
> +	/*
> +	 * Any bridge which does NOT route MSI transactions from its
> +	 * secondary bus to its primary bus must set NO_MSI flag on
> +	 * the secondary pci_bus.
> +	 *
> +	 * The NO_MSI flag can either be set directly by:
> +	 * - arch-specific PCI host bus controller drivers (deprecated)
> +	 * - quirks for specific PCI bridges
> +	 *
> +	 * or indirectly by platform-specific PCI host bridge drivers by
> +	 * advertising the 'msi_domain' property, which results in
> +	 * the NO_MSI flag when no MSI domain is found for this bridge
> +	 * at probe time.
> +	 */
> +	for (bus = dev->bus; bus; bus = bus->parent)
> +		if (bus->bus_flags & PCI_BUS_FLAGS_NO_MSI)
> +			return 0;
> +
> +	return 1;
> +}
> +
> +/**
> + * pci_msi_vec_count - Return the number of MSI vectors a device can send
> + * @dev: device to report about
> + *
> + * This function returns the number of MSI vectors a device requested via
> + * Multiple Message Capable register. It returns a negative errno if the
> + * device is not capable sending MSI interrupts. Otherwise, the call succeeds
> + * and returns a power of two, up to a maximum of 2^5 (32), according to the
> + * MSI specification.
> + **/
> +int pci_msi_vec_count(struct pci_dev *dev)
> +{
> +	int ret;
> +	u16 msgctl;
> +
> +	if (!dev->msi_cap)
> +		return -EINVAL;
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &msgctl);
> +	ret = 1 << ((msgctl & PCI_MSI_FLAGS_QMASK) >> 1);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL(pci_msi_vec_count);
> +
> +static void pci_msi_shutdown(struct pci_dev *dev)
> +{
> +	struct msi_desc *desc;
> +
> +	if (!pci_msi_enable || !dev || !dev->msi_enabled)
> +		return;
> +
> +	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
> +	desc = first_pci_msi_entry(dev);
> +
> +	pci_msi_set_enable(dev, 0);
> +	pci_intx_for_msi(dev, 1);
> +	dev->msi_enabled = 0;
> +
> +	/* Return the device with MSI unmasked as initial states */
> +	pci_msi_unmask(desc, msi_multi_mask(desc));
> +
> +	/* Restore dev->irq to its default pin-assertion IRQ */
> +	dev->irq = desc->pci.msi_attrib.default_irq;
> +	pcibios_alloc_irq(dev);
> +}
> +
> +void pci_disable_msi(struct pci_dev *dev)
> +{
> +	if (!pci_msi_enable || !dev || !dev->msi_enabled)
> +		return;
> +
> +	pci_msi_shutdown(dev);
> +	free_msi_irqs(dev);
> +}
> +EXPORT_SYMBOL(pci_disable_msi);
> +
> +/**
> + * pci_msix_vec_count - return the number of device's MSI-X table entries
> + * @dev: pointer to the pci_dev data structure of MSI-X device function
> + * This function returns the number of device's MSI-X table entries and
> + * therefore the number of MSI-X vectors device is capable of sending.
> + * It returns a negative errno if the device is not capable of sending MSI-X
> + * interrupts.
> + **/
> +int pci_msix_vec_count(struct pci_dev *dev)
> +{
> +	u16 control;
> +
> +	if (!dev->msix_cap)
> +		return -EINVAL;
> +
> +	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
> +	return msix_table_size(control);
> +}
> +EXPORT_SYMBOL(pci_msix_vec_count);
> +
> +static int __pci_enable_msix(struct pci_dev *dev, struct msix_entry *entries,
> +			     int nvec, struct irq_affinity *affd, int flags)
> +{
> +	int nr_entries;
> +	int i, j;
> +
> +	if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
> +		return -EINVAL;
> +
> +	nr_entries = pci_msix_vec_count(dev);
> +	if (nr_entries < 0)
> +		return nr_entries;
> +	if (nvec > nr_entries && !(flags & PCI_IRQ_VIRTUAL))
> +		return nr_entries;
> +
> +	if (entries) {
> +		/* Check for any invalid entries */
> +		for (i = 0; i < nvec; i++) {
> +			if (entries[i].entry >= nr_entries)
> +				return -EINVAL;		/* invalid entry */
> +			for (j = i + 1; j < nvec; j++) {
> +				if (entries[i].entry == entries[j].entry)
> +					return -EINVAL;	/* duplicate entry */
> +			}
> +		}
> +	}
> +
> +	/* Check whether driver already requested for MSI IRQ */
> +	if (dev->msi_enabled) {
> +		pci_info(dev, "can't enable MSI-X (MSI IRQ already assigned)\n");
> +		return -EINVAL;
> +	}
> +	return msix_capability_init(dev, entries, nvec, affd);
> +}
> +
> +static void pci_msix_shutdown(struct pci_dev *dev)
> +{
> +	struct msi_desc *entry;
> +
> +	if (!pci_msi_enable || !dev || !dev->msix_enabled)
> +		return;
> +
> +	if (pci_dev_is_disconnected(dev)) {
> +		dev->msix_enabled = 0;
> +		return;
> +	}
> +
> +	/* Return the device with MSI-X masked as initial states */
> +	for_each_pci_msi_entry(entry, dev)
> +		pci_msix_mask(entry);
> +
> +	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
> +	pci_intx_for_msi(dev, 1);
> +	dev->msix_enabled = 0;
> +	pcibios_alloc_irq(dev);
> +}
> +
> +void pci_disable_msix(struct pci_dev *dev)
> +{
> +	if (!pci_msi_enable || !dev || !dev->msix_enabled)
> +		return;
> +
> +	pci_msix_shutdown(dev);
> +	free_msi_irqs(dev);
> +}
> +EXPORT_SYMBOL(pci_disable_msix);
> +
> +void pci_no_msi(void)
> +{
> +	pci_msi_enable = 0;
> +}
> +
> +/**
> + * pci_msi_enabled - is MSI enabled?
> + *
> + * Returns true if MSI has not been disabled by the command-line option
> + * pci=nomsi.
> + **/
> +int pci_msi_enabled(void)
> +{
> +	return pci_msi_enable;
> +}
> +EXPORT_SYMBOL(pci_msi_enabled);
> +
> +static int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec,
> +				  struct irq_affinity *affd)
> +{
> +	int nvec;
> +	int rc;
> +
> +	if (!pci_msi_supported(dev, minvec) || dev->current_state != PCI_D0)
> +		return -EINVAL;
> +
> +	/* Check whether driver already requested MSI-X IRQs */
> +	if (dev->msix_enabled) {
> +		pci_info(dev, "can't enable MSI (MSI-X already enabled)\n");
> +		return -EINVAL;
> +	}
> +
> +	if (maxvec < minvec)
> +		return -ERANGE;
> +
> +	if (WARN_ON_ONCE(dev->msi_enabled))
> +		return -EINVAL;
> +
> +	nvec = pci_msi_vec_count(dev);
> +	if (nvec < 0)
> +		return nvec;
> +	if (nvec < minvec)
> +		return -ENOSPC;
> +
> +	if (nvec > maxvec)
> +		nvec = maxvec;
> +
> +	for (;;) {
> +		if (affd) {
> +			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
> +			if (nvec < minvec)
> +				return -ENOSPC;
> +		}
> +
> +		rc = msi_capability_init(dev, nvec, affd);
> +		if (rc == 0)
> +			return nvec;
> +
> +		if (rc < 0)
> +			return rc;
> +		if (rc < minvec)
> +			return -ENOSPC;
> +
> +		nvec = rc;
> +	}
> +}
> +
> +/* deprecated, don't use */
> +int pci_enable_msi(struct pci_dev *dev)
> +{
> +	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
> +	if (rc < 0)
> +		return rc;
> +	return 0;
> +}
> +EXPORT_SYMBOL(pci_enable_msi);
> +
> +static int __pci_enable_msix_range(struct pci_dev *dev,
> +				   struct msix_entry *entries, int minvec,
> +				   int maxvec, struct irq_affinity *affd,
> +				   int flags)
> +{
> +	int rc, nvec = maxvec;
> +
> +	if (maxvec < minvec)
> +		return -ERANGE;
> +
> +	if (WARN_ON_ONCE(dev->msix_enabled))
> +		return -EINVAL;
> +
> +	for (;;) {
> +		if (affd) {
> +			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
> +			if (nvec < minvec)
> +				return -ENOSPC;
> +		}
> +
> +		rc = __pci_enable_msix(dev, entries, nvec, affd, flags);
> +		if (rc == 0)
> +			return nvec;
> +
> +		if (rc < 0)
> +			return rc;
> +		if (rc < minvec)
> +			return -ENOSPC;
> +
> +		nvec = rc;
> +	}
> +}
> +
> +/**
> + * pci_enable_msix_range - configure device's MSI-X capability structure
> + * @dev: pointer to the pci_dev data structure of MSI-X device function
> + * @entries: pointer to an array of MSI-X entries
> + * @minvec: minimum number of MSI-X IRQs requested
> + * @maxvec: maximum number of MSI-X IRQs requested
> + *
> + * Setup the MSI-X capability structure of device function with a maximum
> + * possible number of interrupts in the range between @minvec and @maxvec
> + * upon its software driver call to request for MSI-X mode enabled on its
> + * hardware device function. It returns a negative errno if an error occurs.
> + * If it succeeds, it returns the actual number of interrupts allocated and
> + * indicates the successful configuration of MSI-X capability structure
> + * with new allocated MSI-X interrupts.
> + **/
> +int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
> +		int minvec, int maxvec)
> +{
> +	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
> +}
> +EXPORT_SYMBOL(pci_enable_msix_range);
> +
> +/**
> + * pci_alloc_irq_vectors_affinity - allocate multiple IRQs for a device
> + * @dev:		PCI device to operate on
> + * @min_vecs:		minimum number of vectors required (must be >= 1)
> + * @max_vecs:		maximum (desired) number of vectors
> + * @flags:		flags or quirks for the allocation
> + * @affd:		optional description of the affinity requirements
> + *
> + * Allocate up to @max_vecs interrupt vectors for @dev, using MSI-X or MSI
> + * vectors if available, and fall back to a single legacy vector
> + * if neither is available.  Return the number of vectors allocated,
> + * (which might be smaller than @max_vecs) if successful, or a negative
> + * error code on error. If less than @min_vecs interrupt vectors are
> + * available for @dev the function will fail with -ENOSPC.
> + *
> + * To get the Linux IRQ number used for a vector that can be passed to
> + * request_irq() use the pci_irq_vector() helper.
> + */
> +int pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs,
> +				   unsigned int max_vecs, unsigned int flags,
> +				   struct irq_affinity *affd)
> +{
> +	struct irq_affinity msi_default_affd = {0};
> +	int nvecs = -ENOSPC;
> +
> +	if (flags & PCI_IRQ_AFFINITY) {
> +		if (!affd)
> +			affd = &msi_default_affd;
> +	} else {
> +		if (WARN_ON(affd))
> +			affd = NULL;
> +	}
> +
> +	if (flags & PCI_IRQ_MSIX) {
> +		nvecs = __pci_enable_msix_range(dev, NULL, min_vecs, max_vecs,
> +						affd, flags);
> +		if (nvecs > 0)
> +			return nvecs;
> +	}
> +
> +	if (flags & PCI_IRQ_MSI) {
> +		nvecs = __pci_enable_msi_range(dev, min_vecs, max_vecs, affd);
> +		if (nvecs > 0)
> +			return nvecs;
> +	}
> +
> +	/* use legacy IRQ if allowed */
> +	if (flags & PCI_IRQ_LEGACY) {
> +		if (min_vecs == 1 && dev->irq) {
> +			/*
> +			 * Invoke the affinity spreading logic to ensure that
> +			 * the device driver can adjust queue configuration
> +			 * for the single interrupt case.
> +			 */
> +			if (affd)
> +				irq_create_affinity_masks(1, affd);
> +			pci_intx(dev, 1);
> +			return 1;
> +		}
> +	}
> +
> +	return nvecs;
> +}
> +EXPORT_SYMBOL(pci_alloc_irq_vectors_affinity);
> +
> +/**
> + * pci_free_irq_vectors - free previously allocated IRQs for a device
> + * @dev:		PCI device to operate on
> + *
> + * Undoes the allocations and enabling in pci_alloc_irq_vectors().
> + */
> +void pci_free_irq_vectors(struct pci_dev *dev)
> +{
> +	pci_disable_msix(dev);
> +	pci_disable_msi(dev);
> +}
> +EXPORT_SYMBOL(pci_free_irq_vectors);
> +
> +/**
> + * pci_irq_vector - return Linux IRQ number of a device vector
> + * @dev:	PCI device to operate on
> + * @nr:		Interrupt vector index (0-based)
> + *
> + * @nr has the following meanings depending on the interrupt mode:
> + *   MSI-X:	The index in the MSI-X vector table
> + *   MSI:	The index of the enabled MSI vectors
> + *   INTx:	Must be 0
> + *
> + * Return: The Linux interrupt number or -EINVAl if @nr is out of range.
> + */
> +int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
> +{
> +	if (dev->msix_enabled) {
> +		struct msi_desc *entry;
> +
> +		for_each_pci_msi_entry(entry, dev) {
> +			if (entry->pci.msi_attrib.entry_nr == nr)
> +				return entry->irq;
> +		}
> +		WARN_ON_ONCE(1);
> +		return -EINVAL;
> +	}
> +
> +	if (dev->msi_enabled) {
> +		struct msi_desc *entry = first_pci_msi_entry(dev);
> +
> +		if (WARN_ON_ONCE(nr >= entry->nvec_used))
> +			return -EINVAL;
> +	} else {
> +		if (WARN_ON_ONCE(nr > 0))
> +			return -EINVAL;
> +	}
> +
> +	return dev->irq + nr;
> +}
> +EXPORT_SYMBOL(pci_irq_vector);
> +
> +/**
> + * pci_irq_get_affinity - return the affinity of a particular MSI vector
> + * @dev:	PCI device to operate on
> + * @nr:		device-relative interrupt vector index (0-based).
> + *
> + * @nr has the following meanings depending on the interrupt mode:
> + *   MSI-X:	The index in the MSI-X vector table
> + *   MSI:	The index of the enabled MSI vectors
> + *   INTx:	Must be 0
> + *
> + * Return: A cpumask pointer or NULL if @nr is out of range
> + */
> +const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
> +{
> +	if (dev->msix_enabled) {
> +		struct msi_desc *entry;
> +
> +		for_each_pci_msi_entry(entry, dev) {
> +			if (entry->pci.msi_attrib.entry_nr == nr)
> +				return &entry->affinity->mask;
> +		}
> +		WARN_ON_ONCE(1);
> +		return NULL;
> +	} else if (dev->msi_enabled) {
> +		struct msi_desc *entry = first_pci_msi_entry(dev);
> +
> +		if (WARN_ON_ONCE(!entry || !entry->affinity ||
> +				 nr >= entry->nvec_used))
> +			return NULL;
> +
> +		return &entry->affinity[nr].mask;
> +	} else {
> +		return cpu_possible_mask;
> +	}
> +}
> +EXPORT_SYMBOL(pci_irq_get_affinity);
> +
> +struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
> +{
> +	return to_pci_dev(desc->dev);
> +}
> +EXPORT_SYMBOL(msi_desc_to_pci_dev);
> +
> +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> +/**
> + * pci_msi_domain_write_msg - Helper to write MSI message to PCI config space
> + * @irq_data:	Pointer to interrupt data of the MSI interrupt
> + * @msg:	Pointer to the message
> + */
> +static void pci_msi_domain_write_msg(struct irq_data *irq_data, struct msi_msg *msg)
> +{
> +	struct msi_desc *desc = irq_data_get_msi_desc(irq_data);
> +
> +	/*
> +	 * For MSI-X desc->irq is always equal to irq_data->irq. For
> +	 * MSI only the first interrupt of MULTI MSI passes the test.
> +	 */
> +	if (desc->irq == irq_data->irq)
> +		__pci_write_msi_msg(desc, msg);
> +}
> +
> +/**
> + * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source
> + * @desc:	Pointer to the MSI descriptor
> + *
> + * The ID number is only used within the irqdomain.
> + */
> +static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
> +{
> +	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
> +
> +	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
> +		pci_dev_id(dev) << 11 |
> +		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> +}
> +
> +static inline bool pci_msi_desc_is_multi_msi(struct msi_desc *desc)
> +{
> +	return !desc->pci.msi_attrib.is_msix && desc->nvec_used > 1;
> +}
> +
> +/**
> + * pci_msi_domain_check_cap - Verify that @domain supports the capabilities
> + * 			      for @dev
> + * @domain:	The interrupt domain to check
> + * @info:	The domain info for verification
> + * @dev:	The device to check
> + *
> + * Returns:
> + *  0 if the functionality is supported
> + *  1 if Multi MSI is requested, but the domain does not support it
> + *  -ENOTSUPP otherwise
> + */
> +int pci_msi_domain_check_cap(struct irq_domain *domain,
> +			     struct msi_domain_info *info, struct device *dev)
> +{
> +	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
> +
> +	/* Special handling to support __pci_enable_msi_range() */
> +	if (pci_msi_desc_is_multi_msi(desc) &&
> +	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
> +		return 1;
> +	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
> +		return -ENOTSUPP;
> +
> +	return 0;
> +}
> +
> +static int pci_msi_domain_handle_error(struct irq_domain *domain,
> +				       struct msi_desc *desc, int error)
> +{
> +	/* Special handling to support __pci_enable_msi_range() */
> +	if (pci_msi_desc_is_multi_msi(desc) && error == -ENOSPC)
> +		return 1;
> +
> +	return error;
> +}
> +
> +static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,
> +				    struct msi_desc *desc)
> +{
> +	arg->desc = desc;
> +	arg->hwirq = pci_msi_domain_calc_hwirq(desc);
> +}
> +
> +static struct msi_domain_ops pci_msi_domain_ops_default = {
> +	.set_desc	= pci_msi_domain_set_desc,
> +	.msi_check	= pci_msi_domain_check_cap,
> +	.handle_error	= pci_msi_domain_handle_error,
> +};
> +
> +static void pci_msi_domain_update_dom_ops(struct msi_domain_info *info)
> +{
> +	struct msi_domain_ops *ops = info->ops;
> +
> +	if (ops == NULL) {
> +		info->ops = &pci_msi_domain_ops_default;
> +	} else {
> +		if (ops->set_desc == NULL)
> +			ops->set_desc = pci_msi_domain_set_desc;
> +		if (ops->msi_check == NULL)
> +			ops->msi_check = pci_msi_domain_check_cap;
> +		if (ops->handle_error == NULL)
> +			ops->handle_error = pci_msi_domain_handle_error;
> +	}
> +}
> +
> +static void pci_msi_domain_update_chip_ops(struct msi_domain_info *info)
> +{
> +	struct irq_chip *chip = info->chip;
> +
> +	BUG_ON(!chip);
> +	if (!chip->irq_write_msi_msg)
> +		chip->irq_write_msi_msg = pci_msi_domain_write_msg;
> +	if (!chip->irq_mask)
> +		chip->irq_mask = pci_msi_mask_irq;
> +	if (!chip->irq_unmask)
> +		chip->irq_unmask = pci_msi_unmask_irq;
> +}
> +
> +/**
> + * pci_msi_create_irq_domain - Create a MSI interrupt domain
> + * @fwnode:	Optional fwnode of the interrupt controller
> + * @info:	MSI domain info
> + * @parent:	Parent irq domain
> + *
> + * Updates the domain and chip ops and creates a MSI interrupt domain.
> + *
> + * Returns:
> + * A domain pointer or NULL in case of failure.
> + */
> +struct irq_domain *pci_msi_create_irq_domain(struct fwnode_handle *fwnode,
> +					     struct msi_domain_info *info,
> +					     struct irq_domain *parent)
> +{
> +	struct irq_domain *domain;
> +
> +	if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
> +		info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
> +
> +	if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS)
> +		pci_msi_domain_update_dom_ops(info);
> +	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
> +		pci_msi_domain_update_chip_ops(info);
> +
> +	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
> +	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
> +		info->flags |= MSI_FLAG_MUST_REACTIVATE;
> +
> +	/* PCI-MSI is oneshot-safe */
> +	info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
> +
> +	domain = msi_create_irq_domain(fwnode, info, parent);
> +	if (!domain)
> +		return NULL;
> +
> +	irq_domain_update_bus_token(domain, DOMAIN_BUS_PCI_MSI);
> +	return domain;
> +}
> +EXPORT_SYMBOL_GPL(pci_msi_create_irq_domain);
> +
> +/*
> + * Users of the generic MSI infrastructure expect a device to have a single ID,
> + * so with DMA aliases we have to pick the least-worst compromise. Devices with
> + * DMA phantom functions tend to still emit MSIs from the real function number,
> + * so we ignore those and only consider topological aliases where either the
> + * alias device or RID appears on a different bus number. We also make the
> + * reasonable assumption that bridges are walked in an upstream direction (so
> + * the last one seen wins), and the much braver assumption that the most likely
> + * case is that of PCI->PCIe so we should always use the alias RID. This echoes
> + * the logic from intel_irq_remapping's set_msi_sid(), which presumably works
> + * well enough in practice; in the face of the horrible PCIe<->PCI-X conditions
> + * for taking ownership all we can really do is close our eyes and hope...
> + */
> +static int get_msi_id_cb(struct pci_dev *pdev, u16 alias, void *data)
> +{
> +	u32 *pa = data;
> +	u8 bus = PCI_BUS_NUM(*pa);
> +
> +	if (pdev->bus->number != bus || PCI_BUS_NUM(alias) != bus)
> +		*pa = alias;
> +
> +	return 0;
> +}
> +
> +/**
> + * pci_msi_domain_get_msi_rid - Get the MSI requester id (RID)
> + * @domain:	The interrupt domain
> + * @pdev:	The PCI device.
> + *
> + * The RID for a device is formed from the alias, with a firmware
> + * supplied mapping applied
> + *
> + * Returns: The RID.
> + */
> +u32 pci_msi_domain_get_msi_rid(struct irq_domain *domain, struct pci_dev *pdev)
> +{
> +	struct device_node *of_node;
> +	u32 rid = pci_dev_id(pdev);
> +
> +	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> +
> +	of_node = irq_domain_get_of_node(domain);
> +	rid = of_node ? of_msi_map_id(&pdev->dev, of_node, rid) :
> +			iort_msi_map_id(&pdev->dev, rid);
> +
> +	return rid;
> +}
> +
> +/**
> + * pci_msi_get_device_domain - Get the MSI domain for a given PCI device
> + * @pdev:	The PCI device
> + *
> + * Use the firmware data to find a device-specific MSI domain
> + * (i.e. not one that is set as a default).
> + *
> + * Returns: The corresponding MSI domain or NULL if none has been found.
> + */
> +struct irq_domain *pci_msi_get_device_domain(struct pci_dev *pdev)
> +{
> +	struct irq_domain *dom;
> +	u32 rid = pci_dev_id(pdev);
> +
> +	pci_for_each_dma_alias(pdev, get_msi_id_cb, &rid);
> +	dom = of_msi_map_get_device_domain(&pdev->dev, rid, DOMAIN_BUS_PCI_MSI);
> +	if (!dom)
> +		dom = iort_get_device_domain(&pdev->dev, rid,
> +					     DOMAIN_BUS_PCI_MSI);
> +	return dom;
> +}
> +
> +/**
> + * pci_dev_has_special_msi_domain - Check whether the device is handled by
> + *				    a non-standard PCI-MSI domain
> + * @pdev:	The PCI device to check.
> + *
> + * Returns: True if the device irqdomain or the bus irqdomain is
> + * non-standard PCI/MSI.
> + */
> +bool pci_dev_has_special_msi_domain(struct pci_dev *pdev)
> +{
> +	struct irq_domain *dom = dev_get_msi_domain(&pdev->dev);
> +
> +	if (!dom)
> +		dom = dev_get_msi_domain(&pdev->bus->dev);
> +
> +	if (!dom)
> +		return true;
> +
> +	return dom->bus_token != DOMAIN_BUS_PCI_MSI;
> +}
> +
> +#endif /* CONFIG_PCI_MSI_IRQ_DOMAIN */
> +#endif /* CONFIG_PCI_MSI */
> +
> +void pci_msi_init(struct pci_dev *dev)
> +{
> +	u16 ctrl;
> +
> +	/*
> +	 * Disable the MSI hardware to avoid screaming interrupts
> +	 * during boot.  This is the power on reset default so
> +	 * usually this should be a noop.
> +	 */
> +	dev->msi_cap = pci_find_capability(dev, PCI_CAP_ID_MSI);
> +	if (!dev->msi_cap)
> +		return;
> +
> +	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &ctrl);
> +	if (ctrl & PCI_MSI_FLAGS_ENABLE)
> +		pci_write_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS,
> +				      ctrl & ~PCI_MSI_FLAGS_ENABLE);
> +
> +	if (!(ctrl & PCI_MSI_FLAGS_64BIT))
> +		dev->no_64bit_msi = 1;
> +}
> +
> +void pci_msix_init(struct pci_dev *dev)
> +{
> +	u16 ctrl;
> +
> +	dev->msix_cap = pci_find_capability(dev, PCI_CAP_ID_MSIX);
> +	if (!dev->msix_cap)
> +		return;
> +
> +	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &ctrl);
> +	if (ctrl & PCI_MSIX_FLAGS_ENABLE)
> +		pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS,
> +				      ctrl & ~PCI_MSIX_FLAGS_ENABLE);
> +}
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241937.418553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgN-0001Oi-A4; Tue, 07 Dec 2021 21:07:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241937.418553; Tue, 07 Dec 2021 21:07:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgN-0001Ob-74; Tue, 07 Dec 2021 21:07:27 +0000
Received: by outflank-mailman (input) for mailman id 241937;
 Tue, 07 Dec 2021 21:07:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhgM-0000d3-IU
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:07:26 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac75e14c-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:07:24 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 751A6CE1E75;
 Tue,  7 Dec 2021 21:07:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45E93C341C3;
 Tue,  7 Dec 2021 21:07:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac75e14c-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911241;
	bh=l5RPFEn3H/CaaJ67i6H8YMThxBmmtmmB2cHmVmneNBQ=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=Utdeatg9didfUmqmKbQWqCgWNFRnv9ULV295ubYUU37CiRN6LQmpeSPvQ+fA9ofXf
	 7xU7VjbJh0hVseoGqsAAEdVr7FtmfGLuyC6d3J91d66UvJi+5ywsoix9xKyqVQXpsj
	 Hk49O5IVU5tQAt8YTlT1z7CgXtrZSpTeSeovf1NLbsRXlfzahprnhslYYc4RG/beP/
	 vsJe18CxJhHnptlD7IKsQHUXUUCi6UQBk/wooP5HxG8d0U4heYUNqAYnYK7XmCn/JL
	 kMLY/l+6z/rLBuQe+sJRQVlBJFGeeITIj2d4brxSfR8i2kYY9etkJhBEVHkV1Cvnbu
	 IvAWZaQlkBo2w==
Date: Tue, 7 Dec 2021 15:07:20 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 08/31] PCI/MSI: Use msi_add_msi_desc()
Message-ID: <20211207210720.GA78195@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210748.035348646@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:15PM +0100, Thomas Gleixner wrote:
> Simplify the allocation of MSI descriptors by using msi_add_msi_desc()
> which moves the storage handling to core code and prepares for dynamic
> extension of the MSI-X vector space.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/msi.c |  122 ++++++++++++++++++++++++--------------------------
>  1 file changed, 59 insertions(+), 63 deletions(-)
> 
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -340,45 +340,51 @@ void pci_restore_msi_state(struct pci_de
>  }
>  EXPORT_SYMBOL_GPL(pci_restore_msi_state);
>  
> -static struct msi_desc *
> -msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity_desc *masks)
> +static int msi_setup_msi_desc(struct pci_dev *dev, int nvec,
> +			      struct irq_affinity_desc *masks)
>  {
> -	struct msi_desc *entry;
> +	struct msi_desc desc;
>  	unsigned long prop;
>  	u16 control;
> +	int ret;
>  
>  	/* MSI Entry Initialization */
> -	entry = alloc_msi_entry(&dev->dev, nvec, masks);
> -	if (!entry)
> -		return NULL;
> +	memset(&desc, 0, sizeof(desc));
>  
>  	pci_read_config_word(dev, dev->msi_cap + PCI_MSI_FLAGS, &control);
>  	/* Lies, damned lies, and MSIs */
>  	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
>  		control |= PCI_MSI_FLAGS_MASKBIT;
> +	/* Respect XEN's mask disabling */
> +	if (pci_msi_ignore_mask)
> +		control &= ~PCI_MSI_FLAGS_MASKBIT;
>  
> -	entry->pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
> -	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> -					  !!(control & PCI_MSI_FLAGS_MASKBIT);
> -	entry->pci.msi_attrib.default_irq = dev->irq;
> -	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
> -	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
> +	desc.nvec_used			= nvec;
> +	desc.pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
> +	desc.pci.msi_attrib.can_mask	= !!(control & PCI_MSI_FLAGS_MASKBIT);
> +	desc.pci.msi_attrib.default_irq	= dev->irq;
> +	desc.pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
> +	desc.pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
> +	desc.affinity			= masks;
>  
>  	if (control & PCI_MSI_FLAGS_64BIT)
> -		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
> +		desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64;
>  	else
> -		entry->pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
> +		desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;
>  
>  	/* Save the initial mask status */
> -	if (entry->pci.msi_attrib.can_mask)
> -		pci_read_config_dword(dev, entry->pci.mask_pos, &entry->pci.msi_mask);
> +	if (desc.pci.msi_attrib.can_mask)
> +		pci_read_config_dword(dev, desc.pci.mask_pos, &desc.pci.msi_mask);
>  
> -	prop = MSI_PROP_PCI_MSI;
> -	if (entry->pci.msi_attrib.is_64)
> -		prop |= MSI_PROP_64BIT;
> -	msi_device_set_properties(&dev->dev, prop);
> +	ret = msi_add_msi_desc(&dev->dev, &desc);
> +	if (!ret) {
> +		prop = MSI_PROP_PCI_MSI;
> +		if (desc.pci.msi_attrib.is_64)
> +			prop |= MSI_PROP_64BIT;
> +		msi_device_set_properties(&dev->dev, prop);
> +	}
>  
> -	return entry;
> +	return ret;
>  }
>  
>  static int msi_verify_entries(struct pci_dev *dev)
> @@ -423,17 +429,14 @@ static int msi_capability_init(struct pc
>  		masks = irq_create_affinity_masks(nvec, affd);
>  
>  	msi_lock_descs(&dev->dev);
> -	entry = msi_setup_entry(dev, nvec, masks);
> -	if (!entry) {
> -		ret = -ENOMEM;
> +	ret = msi_setup_msi_desc(dev, nvec, masks);
> +	if (ret)
>  		goto unlock;
> -	}
>  
>  	/* All MSIs are unmasked by default; mask them all */
> +	entry = first_pci_msi_entry(dev);
>  	pci_msi_mask(entry, msi_multi_mask(entry));
>  
> -	list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> -
>  	/* Configure MSI capability structure */
>  	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSI);
>  	if (ret)
> @@ -482,49 +485,40 @@ static void __iomem *msix_map_region(str
>  	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
>  }
>  
> -static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
> -			      struct msix_entry *entries, int nvec,
> -			      struct irq_affinity_desc *masks)
> +static int msix_setup_msi_descs(struct pci_dev *dev, void __iomem *base,
> +				struct msix_entry *entries, int nvec,
> +				struct irq_affinity_desc *masks)
>  {
> -	int i, vec_count = pci_msix_vec_count(dev);
> +	int ret = 0, i, vec_count = pci_msix_vec_count(dev);
>  	struct irq_affinity_desc *curmsk;
> -	struct msi_desc *entry;
> +	struct msi_desc desc;
>  	void __iomem *addr;
>  
> -	for (i = 0, curmsk = masks; i < nvec; i++) {
> -		entry = alloc_msi_entry(&dev->dev, 1, curmsk);
> -		if (!entry) {
> -			/* No enough memory. Don't try again */
> -			return -ENOMEM;
> -		}
> -
> -		entry->pci.msi_attrib.is_msix	= 1;
> -		entry->pci.msi_attrib.is_64	= 1;
> -
> -		if (entries)
> -			entry->msi_index = entries[i].entry;
> -		else
> -			entry->msi_index = i;
> -
> -		entry->pci.msi_attrib.is_virtual = entry->msi_index >= vec_count;
> -
> -		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
> -						  !entry->pci.msi_attrib.is_virtual;
> -
> -		entry->pci.msi_attrib.default_irq	= dev->irq;
> -		entry->pci.mask_base			= base;
> +	memset(&desc, 0, sizeof(desc));
>  
> -		if (entry->pci.msi_attrib.can_mask) {
> -			addr = pci_msix_desc_addr(entry);
> -			entry->pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
> +	desc.nvec_used			= 1;
> +	desc.pci.msi_attrib.is_msix	= 1;
> +	desc.pci.msi_attrib.is_64	= 1;
> +	desc.pci.msi_attrib.default_irq	= dev->irq;
> +	desc.pci.mask_base		= base;
> +
> +	for (i = 0, curmsk = masks; i < nvec; i++, curmsk++) {
> +		desc.msi_index = entries ? entries[i].entry : i;
> +		desc.affinity = masks ? curmsk : NULL;
> +		desc.pci.msi_attrib.is_virtual = desc.msi_index >= vec_count;
> +		desc.pci.msi_attrib.can_mask = !pci_msi_ignore_mask &&
> +					       !desc.pci.msi_attrib.is_virtual;
> +
> +		if (!desc.pci.msi_attrib.can_mask) {
> +			addr = pci_msix_desc_addr(&desc);
> +			desc.pci.msix_ctrl = readl(addr + PCI_MSIX_ENTRY_VECTOR_CTRL);
>  		}
>  
> -		list_add_tail(&entry->list, dev_to_msi_list(&dev->dev));
> -		if (masks)
> -			curmsk++;
> +		ret = msi_add_msi_desc(&dev->dev, &desc);
> +		if (ret)
> +			break;
>  	}
> -	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
> -	return 0;
> +	return ret;
>  }
>  
>  static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
> @@ -562,10 +556,12 @@ static int msix_setup_interrupts(struct
>  		masks = irq_create_affinity_masks(nvec, affd);
>  
>  	msi_lock_descs(&dev->dev);
> -	ret = msix_setup_entries(dev, base, entries, nvec, masks);
> +	ret = msix_setup_msi_descs(dev, base, entries, nvec, masks);
>  	if (ret)
>  		goto out_free;
>  
> +	msi_device_set_properties(&dev->dev, MSI_PROP_PCI_MSIX | MSI_PROP_64BIT);
> +
>  	ret = pci_msi_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX);
>  	if (ret)
>  		goto out_free;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241942.418563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgZ-0001tp-I4; Tue, 07 Dec 2021 21:07:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241942.418563; Tue, 07 Dec 2021 21:07:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgZ-0001tg-F9; Tue, 07 Dec 2021 21:07:39 +0000
Received: by outflank-mailman (input) for mailman id 241942;
 Tue, 07 Dec 2021 21:07:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhgY-00079Y-8d
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:07:38 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3dc61ec-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:07:37 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 84C38CE1E71;
 Tue,  7 Dec 2021 21:07:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 581B4C341C1;
 Tue,  7 Dec 2021 21:07:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3dc61ec-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911253;
	bh=rm/dgcDZc26i41jsxR6lRThsXaeA0YmeED/ioZkcqVA=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=BDdTrFkGJqYMJkfZ24oGmCiYwWtwgaeqkDVS5p2+B5BGbBbquzqVbFjKhGA0ixp87
	 rnOFnZ92k4XK4XDydZfkwDbkfCqBPGS0SbpJn+sBIeWcxjTutLZrkk9Ud5DPYG0h8v
	 88ar8YXxyzMmXIQrc1a30nTQH8kMyPf4MsY+bEr3GH1lcDmrgEwrTeoB2rT92+dp9P
	 5zzU60myih/j0KuEzC1En46GwRrs9gKAtcTrgY+aSxFlCu25mkmg6cKbrpO6lKzpiW
	 IyEg6CN8avQj1nYchkGYRODTUlePd5GO54TQBkd++HIZNqGURT8y/MEIEhVKPPMovS
	 yfBSXDw+n4jRw==
Date: Tue, 7 Dec 2021 15:07:32 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 09/31] PCI/MSI: Let core code free MSI descriptors
Message-ID: <20211207210732.GA78249@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210748.089085131@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:16PM +0100, Thomas Gleixner wrote:
> Set the domain info flag which tells the core code to free the MSI
> descriptors from msi_domain_free_irqs() and add an explicit call to the
> core function into the legacy code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |    3 ++-
>  drivers/pci/msi/legacy.c    |    1 +
>  drivers/pci/msi/msi.c       |   14 --------------
>  3 files changed, 3 insertions(+), 15 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -171,7 +171,8 @@ struct irq_domain *pci_msi_create_irq_do
>  	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
>  		pci_msi_domain_update_chip_ops(info);
>  
> -	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS;
> +	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS |
> +		       MSI_FLAG_FREE_MSI_DESCS;
>  	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
>  		info->flags |= MSI_FLAG_MUST_REACTIVATE;
>  
> --- a/drivers/pci/msi/legacy.c
> +++ b/drivers/pci/msi/legacy.c
> @@ -80,4 +80,5 @@ void pci_msi_legacy_teardown_msi_irqs(st
>  {
>  	msi_device_destroy_sysfs(&dev->dev);
>  	arch_teardown_msi_irqs(dev);
> +	msi_free_msi_descs(&dev->dev);
>  }
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -224,22 +224,8 @@ EXPORT_SYMBOL_GPL(pci_write_msi_msg);
>  
>  static void free_msi_irqs(struct pci_dev *dev)
>  {
> -	struct list_head *msi_list = dev_to_msi_list(&dev->dev);
> -	struct msi_desc *entry, *tmp;
> -	int i;
> -
> -	for_each_pci_msi_entry(entry, dev)
> -		if (entry->irq)
> -			for (i = 0; i < entry->nvec_used; i++)
> -				BUG_ON(irq_has_action(entry->irq + i));
> -
>  	pci_msi_teardown_msi_irqs(dev);
>  
> -	list_for_each_entry_safe(entry, tmp, msi_list, list) {
> -		list_del(&entry->list);
> -		free_msi_entry(entry);
> -	}
> -
>  	if (dev->msix_base) {
>  		iounmap(dev->msix_base);
>  		dev->msix_base = NULL;
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:07:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241946.418575 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgk-0002Pr-RB; Tue, 07 Dec 2021 21:07:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241946.418575; Tue, 07 Dec 2021 21:07:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhgk-0002Pg-Nu; Tue, 07 Dec 2021 21:07:50 +0000
Received: by outflank-mailman (input) for mailman id 241946;
 Tue, 07 Dec 2021 21:07:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhgj-00079Y-7G
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:07:49 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb2b647f-57a1-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:07:48 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 094F1B81E81;
 Tue,  7 Dec 2021 21:07:48 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64422C341C6;
 Tue,  7 Dec 2021 21:07:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb2b647f-57a1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911267;
	bh=xbRlMGQiDpgUvYdaI107undae+Qs6TI/rFQZGYFE5ws=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=cBYISP9LVdytikmRCWz5M4AFc9XhUaSKwFOouejXtfcYt9GXqH/J18Ri0AlAVfCkA
	 fFEdRhKoQK8hqdNrGtpslFwGsnrWbBWtJdcJSXCRSfSvRMva7UptH+qmLAHL36/wgB
	 +Q40sXVJlVL90ihJGfnoAIdCwABRwG7avm6Y/HHq0J737ITfdBNjCDAtERV3VxKSCh
	 Kpk/JKFDn8vTxI1V7D+lXbxw1WksGa9HgaoL9jr0UeQSCtHsbCRe1vhzJyKwIbxZ/4
	 hS+da7OrEP2eS4jltiDqyDDcS1blaYaUUZhSPT5uo4+266EV4D3FDy5+LNcn9Fz1U8
	 Tz0Gqs2+y+1nQ==
Date: Tue, 7 Dec 2021 15:07:46 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 10/31] PCI/MSI: Use msi_on_each_desc()
Message-ID: <20211207210746.GA78295@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210748.142603657@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:18PM +0100, Thomas Gleixner wrote:
> Use the new iterator functions which pave the way for dynamically extending
> MSI-X vectors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/msi/irqdomain.c |    4 ++--
>  drivers/pci/msi/legacy.c    |   19 ++++++++-----------
>  drivers/pci/msi/msi.c       |   30 ++++++++++++++----------------
>  3 files changed, 24 insertions(+), 29 deletions(-)
> 
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -83,7 +83,7 @@ static int pci_msi_domain_check_cap(stru
>  				    struct msi_domain_info *info,
>  				    struct device *dev)
>  {
> -	struct msi_desc *desc = first_pci_msi_entry(to_pci_dev(dev));
> +	struct msi_desc *desc = msi_first_desc(dev, MSI_DESC_ALL);
>  
>  	/* Special handling to support __pci_enable_msi_range() */
>  	if (pci_msi_desc_is_multi_msi(desc) &&
> @@ -98,7 +98,7 @@ static int pci_msi_domain_check_cap(stru
>  			unsigned int idx = 0;
>  
>  			/* Check for gaps in the entry indices */
> -			for_each_msi_entry(desc, dev) {
> +			msi_for_each_desc(desc, dev, MSI_DESC_ALL) {
>  				if (desc->msi_index != idx++)
>  					return -ENOTSUPP;
>  			}
> --- a/drivers/pci/msi/legacy.c
> +++ b/drivers/pci/msi/legacy.c
> @@ -28,7 +28,7 @@ int __weak arch_setup_msi_irqs(struct pc
>  	if (type == PCI_CAP_ID_MSI && nvec > 1)
>  		return 1;
>  
> -	for_each_pci_msi_entry(desc, dev) {
> +	msi_for_each_desc(desc, &dev->dev, MSI_DESC_NOTASSOCIATED) {
>  		ret = arch_setup_msi_irq(dev, desc);
>  		if (ret)
>  			return ret < 0 ? ret : -ENOSPC;
> @@ -42,27 +42,24 @@ void __weak arch_teardown_msi_irqs(struc
>  	struct msi_desc *desc;
>  	int i;
>  
> -	for_each_pci_msi_entry(desc, dev) {
> -		if (desc->irq) {
> -			for (i = 0; i < desc->nvec_used; i++)
> -				arch_teardown_msi_irq(desc->irq + i);
> -		}
> +	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ASSOCIATED) {
> +		for (i = 0; i < desc->nvec_used; i++)
> +			arch_teardown_msi_irq(desc->irq + i);
>  	}
>  }
>  
>  static int pci_msi_setup_check_result(struct pci_dev *dev, int type, int ret)
>  {
> -	struct msi_desc *entry;
> +	struct msi_desc *desc;
>  	int avail = 0;
>  
>  	if (type != PCI_CAP_ID_MSIX || ret >= 0)
>  		return ret;
>  
>  	/* Scan the MSI descriptors for successfully allocated ones. */
> -	for_each_pci_msi_entry(entry, dev) {
> -		if (entry->irq != 0)
> -			avail++;
> -	}
> +	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ASSOCIATED)
> +		avail++;
> +
>  	return avail ? avail : ret;
>  }
>  
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -299,7 +299,6 @@ static void __pci_restore_msix_state(str
>  
>  	if (!dev->msix_enabled)
>  		return;
> -	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
>  
>  	/* route the table */
>  	pci_intx_for_msi(dev, 0);
> @@ -309,7 +308,7 @@ static void __pci_restore_msix_state(str
>  	write_msg = arch_restore_msi_irqs(dev);
>  
>  	msi_lock_descs(&dev->dev);
> -	for_each_pci_msi_entry(entry, dev) {
> +	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
>  		if (write_msg)
>  			__pci_write_msi_msg(entry, &entry->msg);
>  		pci_msix_write_vector_ctrl(entry, entry->pci.msix_ctrl);
> @@ -378,14 +377,14 @@ static int msi_verify_entries(struct pci
>  	if (!dev->no_64bit_msi)
>  		return 0;
>  
> -	for_each_pci_msi_entry(entry, dev) {
> +	msi_for_each_desc(entry, &dev->dev, MSI_DESC_ALL) {
>  		if (entry->msg.address_hi) {
>  			pci_err(dev, "arch assigned 64-bit MSI address %#x%08x but device only supports 32 bits\n",
>  				entry->msg.address_hi, entry->msg.address_lo);
> -			return -EIO;
> +			break;
>  		}
>  	}
> -	return 0;
> +	return !entry ? 0 : -EIO;
>  }
>  
>  /**
> @@ -418,7 +417,7 @@ static int msi_capability_init(struct pc
>  		goto unlock;
>  
>  	/* All MSIs are unmasked by default; mask them all */
> -	entry = first_pci_msi_entry(dev);
> +	entry = msi_first_desc(&dev->dev, MSI_DESC_ALL);
>  	pci_msi_mask(entry, msi_multi_mask(entry));
>  
>  	/* Configure MSI capability structure */
> @@ -508,11 +507,11 @@ static int msix_setup_msi_descs(struct p
>  
>  static void msix_update_entries(struct pci_dev *dev, struct msix_entry *entries)
>  {
> -	struct msi_desc *entry;
> +	struct msi_desc *desc;
>  
>  	if (entries) {
> -		for_each_pci_msi_entry(entry, dev) {
> -			entries->vector = entry->irq;
> +		msi_for_each_desc(desc, &dev->dev, MSI_DESC_ALL) {
> +			entries->vector = desc->irq;
>  			entries++;
>  		}
>  	}
> @@ -705,15 +704,14 @@ static void pci_msi_shutdown(struct pci_
>  	if (!pci_msi_enable || !dev || !dev->msi_enabled)
>  		return;
>  
> -	BUG_ON(list_empty(dev_to_msi_list(&dev->dev)));
> -	desc = first_pci_msi_entry(dev);
> -
>  	pci_msi_set_enable(dev, 0);
>  	pci_intx_for_msi(dev, 1);
>  	dev->msi_enabled = 0;
>  
>  	/* Return the device with MSI unmasked as initial states */
> -	pci_msi_unmask(desc, msi_multi_mask(desc));
> +	desc = msi_first_desc(&dev->dev, MSI_DESC_ALL);
> +	if (!WARN_ON_ONCE(!desc))
> +		pci_msi_unmask(desc, msi_multi_mask(desc));
>  
>  	/* Restore dev->irq to its default pin-assertion IRQ */
>  	dev->irq = desc->pci.msi_attrib.default_irq;
> @@ -789,7 +787,7 @@ static int __pci_enable_msix(struct pci_
>  
>  static void pci_msix_shutdown(struct pci_dev *dev)
>  {
> -	struct msi_desc *entry;
> +	struct msi_desc *desc;
>  
>  	if (!pci_msi_enable || !dev || !dev->msix_enabled)
>  		return;
> @@ -800,8 +798,8 @@ static void pci_msix_shutdown(struct pci
>  	}
>  
>  	/* Return the device with MSI-X masked as initial states */
> -	for_each_pci_msi_entry(entry, dev)
> -		pci_msix_mask(entry);
> +	msi_for_each_desc(desc, &dev->dev, MSI_DESC_ALL)
> +		pci_msix_mask(desc);
>  
>  	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
>  	pci_intx_for_msi(dev, 1);
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:17:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:17:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241963.418586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhq6-0004UJ-RJ; Tue, 07 Dec 2021 21:17:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241963.418586; Tue, 07 Dec 2021 21:17:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhq6-0004UC-Mb; Tue, 07 Dec 2021 21:17:30 +0000
Received: by outflank-mailman (input) for mailman id 241963;
 Tue, 07 Dec 2021 21:17:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/XZh=QY=kernel.org=helgaas@srs-se1.protection.inumbo.net>)
 id 1muhh3-0000d3-4e
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:08:09 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c6439ae3-57a1-11ec-a831-37629979565c;
 Tue, 07 Dec 2021 22:08:07 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id DC252CE1E22;
 Tue,  7 Dec 2021 21:08:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8250C341C1;
 Tue,  7 Dec 2021 21:08:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6439ae3-57a1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638911285;
	bh=Un8pVb1ViG+hHJBV0K32UXMvYIETtBkFtRlli7CA0QM=;
	h=Date:From:To:Cc:Subject:In-Reply-To:From;
	b=aCbzd0NEb2pQzyZ0dxCVmc3D7+wht440q0E0LtCH9EBL6AmXweh77FA6vFVv+lovw
	 QxUM8o9yuv91Owv+YX0uqXzLPMe9Xmgrdwsq/Q0XtDXLOgeHXtR/qWyue29zAHe+qn
	 ZNo6fhJJvBTogag2oEBDmFwEwkYMA/6cjrRB9/RvEo/WrLVjhaCtSMKZ3lJBI/ML0e
	 H2WKoiCX7z7ZcvhMozBDewcD4TrkbQVYFGuZQ6IhOk/J97KO7Fn9gfBhXnI6eBTMOi
	 jxz2bdl5MIQY5mZHQt4K9hdDQz+EBL7RNknLIwfMhihldvflaMJpn9QmDetpivNk4I
	 5elH8aZ6ytVgA==
Date: Tue, 7 Dec 2021 15:08:03 -0600
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 19/31] PCI: hv: Rework MSI handling
Message-ID: <20211207210803.GA78366@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210748.629363944@linutronix.de>

On Mon, Dec 06, 2021 at 11:51:33PM +0100, Thomas Gleixner wrote:
> Replace the about to vanish iterators and make use of the filtering. Take
> the descriptor lock around the iterators.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
>  drivers/pci/controller/pci-hyperv.c |   15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -3445,18 +3445,23 @@ static int hv_pci_suspend(struct hv_devi
>  
>  static int hv_pci_restore_msi_msg(struct pci_dev *pdev, void *arg)
>  {
> -	struct msi_desc *entry;
>  	struct irq_data *irq_data;
> +	struct msi_desc *entry;
> +	int ret = 0;
>  
> -	for_each_pci_msi_entry(entry, pdev) {
> +	msi_lock_descs(&pdev->dev);
> +	msi_for_each_desc(entry, &pdev->dev, MSI_DESC_ASSOCIATED) {
>  		irq_data = irq_get_irq_data(entry->irq);
> -		if (WARN_ON_ONCE(!irq_data))
> -			return -EINVAL;
> +		if (WARN_ON_ONCE(!irq_data)) {
> +			ret = -EINVAL;
> +			break;
> +		}
>  
>  		hv_compose_msi_msg(irq_data, &entry->msg);
>  	}
> +	msi_unlock_descs(&pdev->dev);
>  
> -	return 0;
> +	return ret;
>  }
>  
>  /*
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 07 21:19:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 21:19:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241971.418597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhrd-0005PY-6W; Tue, 07 Dec 2021 21:19:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241971.418597; Tue, 07 Dec 2021 21:19:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muhrd-0005PQ-1q; Tue, 07 Dec 2021 21:19:05 +0000
Received: by outflank-mailman (input) for mailman id 241971;
 Tue, 07 Dec 2021 21:19:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=vuaW=QY=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1muhrc-0005PE-2K
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 21:19:04 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4cb5c801-57a3-11ec-9d12-4777fae47e2b;
 Tue, 07 Dec 2021 22:19:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cb5c801-57a3-11ec-9d12-4777fae47e2b
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638911940;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fejqz/bIS5UVVez3Xtjq2jInYaufJY/nLKnDbenyBtw=;
	b=VC5Rvg7jiq8Ikfw+JFC2if6V+C51JARVBdC0uW9vUW0CHLXLMJTCVCws2bKyhUrgzzbYBD
	TspgTWIoCN3z1mpSmBTfGbx4XIbh9GbNDRxSmFXBfJwIBX3j0sw+jnfm/oYCbc43OrEUpM
	SS9tX2diiZM5lYRGla6ljcr7iPYUAT/RJ9qMdqhJZgpVF0sfTve/39i5qs1L2SbKmA26Kk
	RuYaS8IxyMjfJtp5yErMcFm+uepejATF2VudC9wKWykGQzcm11Soqa0vOKrqlwq9Qy2ES/
	hIUI+MznVV8wAM/ESPIdQN7tFRoLJxRc700tRc0QEredDULx8y3xvMEgR1lqVw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638911940;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fejqz/bIS5UVVez3Xtjq2jInYaufJY/nLKnDbenyBtw=;
	b=tpxYQz931aJ9NXdPSYYAooQnjmQcVTU6ncg1A9XfE7ZYmworf/GnMN1rkeaSCd4LIsHO3E
	LsosR2mIUwj5rrDw==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, LKML
 <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Juergen Gross
 <jgross@suse.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Will
 Deacon <will@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder
 <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth
 Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
 linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>, Mark
 Rutland <mark.rutland@arm.com>, Robin Murphy <robin.murphy@arm.com>, Sinan
 Kaya <okaya@kernel.org>, Dan Williams <dan.j.williams@intel.com>,
 Christoph Hellwig <hch@infradead.org>, Keith Busch <kbusch@kernel.org>
Subject: Re: [patch V2 29/36] PCI/MSI: Simplify pci_irq_get_affinity()
In-Reply-To: <e32237f3-0ff2-cf80-cd99-0b4813d1ed21@kaod.org>
References: <20211206210307.625116253@linutronix.de>
 <20211206210439.235197701@linutronix.de>
 <e32237f3-0ff2-cf80-cd99-0b4813d1ed21@kaod.org>
Date: Tue, 07 Dec 2021 22:19:00 +0100
Message-ID: <87zgpc15bv.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Cedric,

On Tue, Dec 07 2021 at 18:42, C=C3=A9dric Le Goater wrote:
>
> This is breaking nvme on pseries but it's probably one of the previous
> patches. I haven't figured out what's wrong yet. Here is the oops FYI.

Hrm.

> [   32.494562] WARNING: CPU: 26 PID: 658 at kernel/irq/chip.c:210 irq_sta=
rtup+0x1c0/0x1e0

This complains about a manual enable_irq() on a managed interrupt.

> [   32.494575] Modules linked in: ibmvscsi ibmveth scsi_transport_srp bnx=
2x ipr libata xhci_pci xhci_hcd nvme xts vmx_crypto nvme_core mdio t10_pi l=
ibcrc32c dm_mirror dm_region_hash dm_log dm_mod
> [   32.494601] CPU: 26 PID: 658 Comm: kworker/26:1H Not tainted 5.16.0-rc=
4-clg+ #54
> [   32.494607] Workqueue: kblockd blk_mq_timeout_work
> [   32.494681] NIP [c000000000206f00] irq_startup+0x1c0/0x1e0
> [   32.494686] LR [c000000000206df0] irq_startup+0xb0/0x1e0
> [   32.494690] Call Trace:
> [   32.494692] [c0000018050f38b0] [c000000000206df0] irq_startup+0xb0/0x1=
e0 (unreliable)
> [   32.494699] [c0000018050f38f0] [c00000000020155c] __enable_irq+0x9c/0x=
b0
> [   32.494705] [c0000018050f3950] [c0000000002015d0] enable_irq+0x60/0xc0
> [   32.494710] [c0000018050f39d0] [c008000014a54ae8] nvme_poll_irqdisable=
+0x80/0xc0 [nvme]
> [   32.494719] [c0000018050f3a00] [c008000014a55824] nvme_timeout+0x18c/0=
x420 [nvme]
> [   32.494726] [c0000018050f3ae0] [c00000000076e1b8] blk_mq_check_expired=
+0xa8/0x130
> [   32.494732] [c0000018050f3b10] [c0000000007793e8] bt_iter+0xd8/0x120
> [   32.494737] [c0000018050f3b60] [c00000000077a34c] blk_mq_queue_tag_bus=
y_iter+0x25c/0x3f0
> [   32.494742] [c0000018050f3c20] [c00000000076ffa4] blk_mq_timeout_work+=
0x84/0x1a0
> [   32.494747] [c0000018050f3c70] [c000000000182a78] process_one_work+0x2=
a8/0x5a0

Confused. I diffed against v1, but could not spot anything except that
properties issue which you found too.

Thanks,

        tglx



From xen-devel-bounces@lists.xenproject.org Tue Dec 07 23:37:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 07 Dec 2021 23:37:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241982.418607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muk1A-0007EA-6I; Tue, 07 Dec 2021 23:37:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241982.418607; Tue, 07 Dec 2021 23:37:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muk1A-0007E3-3C; Tue, 07 Dec 2021 23:37:04 +0000
Received: by outflank-mailman (input) for mailman id 241982;
 Tue, 07 Dec 2021 23:37:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=q3n9=QY=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1muk18-0007Dx-MN
 for xen-devel@lists.xenproject.org; Tue, 07 Dec 2021 23:37:02 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9269ba7c-57b6-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 00:37:00 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 1FEE9CE1C51;
 Tue,  7 Dec 2021 23:36:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA742C341C3;
 Tue,  7 Dec 2021 23:36:54 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9269ba7c-57b6-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638920215;
	bh=FG2SGFwHcUyA+9+/Ri7rTgQT9k2NE3/aM61sY9WDemQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Aok5DLUJj+Jy+u4ZaMwSlbC6ocZ+w7ekCFqJtmvUvFk88u7LuWmPb2RtTfOeKJ+vj
	 74uRJCdnaTNBaLlNCL85DkWQ3ctIxEImPA/IjNSnrAU4RDG3ozJGTMnEH8LqxLCt0t
	 M7L/j8LTAapBoD22PIB7nlv5uIAWuNbF5VX5lLdurPYF2WssIJmXdUM/kpkGsOIoj0
	 hZ1vkRZUR0bho/yrYDQg1m5hNj3V/igTBF+RgOKwwsTFsYZM8XIZVtlil77U/38TKM
	 qYlB/av2z5AFJH8/fB2CHpPVVOY9sAJhxDtFDi9D7dMKcgqpBTPTe1F0x3YU8vBlP+
	 vsA2scHSad/Ww==
Date: Tue, 7 Dec 2021 15:36:53 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V3 4/6] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
In-Reply-To: <c2e8c00a-3856-8330-8e8f-ab8a92e93e47@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2112071506370.4091490@ubuntu-linux-20-04-desktop>
References: <1637787223-21129-1-git-send-email-olekstysh@gmail.com> <1637787223-21129-5-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2111241701240.1412361@ubuntu-linux-20-04-desktop> <c2e8c00a-3856-8330-8e8f-ab8a92e93e47@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1417778164-1638918436=:4091490"
Content-ID: <alpine.DEB.2.22.394.2112071520320.4091490@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1417778164-1638918436=:4091490
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2112071520321.4091490@ubuntu-linux-20-04-desktop>

On Thu, 25 Nov 2021, Oleksandr wrote:
> > > Please note the following:
> > > for V3 arch_xen_unpopulated_init() was moved to init() as was agreed
> > > and gained __init specifier. So the target_resource is initialized there.
> > > 
> > > With current patch series applied if CONFIG_XEN_UNPOPULATED_ALLOC
> > > is enabled:
> > > 
> > > 1. On Arm, under normal circumstances, the xen_alloc_unpopulated_pages()
> > > won't be called “before” arch_xen_unpopulated_init(). It will only be
> > > called "before" when either ACPI is in use or something wrong happened
> > > with DT (and we failed to read xen_grant_frames), so we fallback to
> > > xen_xlate_map_ballooned_pages() in arm/xen/enlighten.c:xen_guest_init(),
> > > please see "arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT"
> > > for details. But in that case, I think, it doesn't matter much whether
> > > xen_alloc_unpopulated_pages() is called "before" of "after"
> > > target_resource
> > > initialization, as we don't have extended regions in place the
> > > target_resource
> > > will remain invalid even after initialization, so
> > > xen_alloc_ballooned_pages()
> > > will be used in both scenarios.
> > > 
> > > 2. On x86, I am not quite sure which modes use unpopulated-alloc (PVH?),
> > > but it looks like xen_alloc_unpopulated_pages() can (and will) be called
> > > “before” arch_xen_unpopulated_init().
> > > At least, I see that xen_xlate_map_ballooned_pages() is called in
> > > x86/xen/grant-table.c:xen_pvh_gnttab_setup(). According to the initcall
> > > levels for both xen_pvh_gnttab_setup() and init() I expect the former
> > > to be called earlier.
> > > If it is true, the sentence in the commit description which mentions
> > > that “behaviour on x86 is not changed” is not precise. I don’t think
> > > it would be correct to fallback to xen_alloc_ballooned_pages() just
> > > because we haven’t initialized target_resource yet (on x86 it is just
> > > assigning it iomem_resource), at least this doesn't look like an expected
> > > behaviour and unlikely would be welcome.
> > > 
> > > I am wondering whether it would be better to move
> > > arch_xen_unpopulated_init()
> > > to a dedicated init() marked with an appropriate initcall level
> > > (early_initcall?)
> > > to make sure it will always be called *before*
> > > xen_xlate_map_ballooned_pages().
> > > What do you think?
> 
>    ... here (#2). Or I really missed something and there wouldn't be an issue?

Yes, I see your point. Yeah, it makes sense to make sure that
drivers/xen/unpopulated-alloc.c:init is executed before
xen_pvh_gnttab_setup.

If we move it to early_initcall, then we end up running it before
xen_guest_init on ARM. But that might be fine: it looks like it should
work OK and would also allow us to execute xen_xlate_map_ballooned_pages
with target_resource already set.

So I'd say go for it :)
--8323329-1417778164-1638918436=:4091490--


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 00:07:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 00:07:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.241989.418619 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mukTt-0003uP-EN; Wed, 08 Dec 2021 00:06:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 241989.418619; Wed, 08 Dec 2021 00:06:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mukTt-0003uI-Aq; Wed, 08 Dec 2021 00:06:45 +0000
Received: by outflank-mailman (input) for mailman id 241989;
 Wed, 08 Dec 2021 00:06:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Aoc2=QZ=linaro.org=mathieu.poirier@srs-se1.protection.inumbo.net>)
 id 1mukTr-0003uC-60
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 00:06:43 +0000
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com
 [2a00:1450:4864:20::531])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b8a81809-57ba-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 01:06:41 +0100 (CET)
Received: by mail-ed1-x531.google.com with SMTP id g14so2333145edb.8
 for <xen-devel@lists.xenproject.org>; Tue, 07 Dec 2021 16:06:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8a81809-57ba-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=07gOr7vYtk1uVvLqelaTBUbdnkVX+qvyUroCmQe9uEs=;
        b=ybvJqGBCzbVa8iw9P4fxFYdhZ3f7pKBt6JOm+hC6q+FWHUqPOT9+rAOGTfMxV1g9L3
         O7+wZUIiIqxP5+4le4lAzdN1EgklwZ75EfUmT5oE4RuGs1e47TzoiKwkf3YWO340nzDd
         EDMCbiKI/AMHXg/GNqcELUj4Dr6Nfm03cILqxC/5h4rtBzbn5LEjVE52CokUEQ32iuDr
         U6newSjbJaFBaUPJTBKkvVd4SpwVjYL9l+llKH/Nqv6T826xGE7Bw6KUAwwhwMfs0TVQ
         XgBiLivJKyOMORt5Wr5wLpdtTx0uoS8sFWCZfAPV3FMlbZh/5wxB4ocYcztCeJ18wXFM
         B6Xg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=07gOr7vYtk1uVvLqelaTBUbdnkVX+qvyUroCmQe9uEs=;
        b=1Hxfefto4sACdecuhm4S92P1FBDE129Fm1G81Ld30++Ef2Iu25cniv/AjaN0s2k47+
         LCTwjxYzfAVwwb5UaPhyok+20/qinQRZoH/FKZ6pOK6dxmercHYY+XAtBZQbTSlLPPJe
         iBNL7JlTBt+7ys/KXxHlDTfWnpuGVPvRbFcLoyFo07AfKtKihvcY3avRa+/gI/LuAaUy
         RHCXk/dn/h7rAe3l8m8F9r4FNvttgmVa9It/XQB+ipMNnLNYBBeKYynIY4SaeyGQKY8N
         6kTq/MsjhXWSUE9JMAGW7j8MHRfxNU48RbZZ0qeoM/9UP4j1Na6ZsZsmLtcebqfzoDxz
         mM5Q==
X-Gm-Message-State: AOAM532eZPxWev+vNQY6re+ARURAiatrUOYMJDXgXcRLz99uHJGGh1L/
	D6LIfi5uJkhdzguUJnai8TEXFAsgKwdU7iP5trwzmiTYcARhdg==
X-Google-Smtp-Source: ABdhPJybNbjzgcHov9auSIHF38le4y3GFmWHye72mxcbHUi3IgaY/nCYUfVTS/ruque/3I7Tci9DO6Ao7g7cGOs2M9s=
X-Received: by 2002:a05:6402:3cd:: with SMTP id t13mr13992587edw.97.1638922001248;
 Tue, 07 Dec 2021 16:06:41 -0800 (PST)
MIME-Version: 1.0
References: <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com>
In-Reply-To: <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com>
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: Tue, 7 Dec 2021 17:06:30 -0700
Message-ID: <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
Subject: Re: Aarch64 stand-alone application for Xen
To: Bertrand Marquis <bertrand.marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

Hi Bertrand,

On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
>
> Hi Mathieu,
>
> > On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >
> > Good day,
> >
> > I am in the process of adding support for aarch64 to the xen-sys
> > crate[1].  The crate currently supports x86_64 and includes a
> > stand-alone "oxerun" application that can be used to validate
> > hypercalls.  My goal is to provide the same functionality on arm64.  I
> > am looking for a stand-alone aarch64 example, something like an "hello
> > world" to help me with the assembler startup code.
>
> We are working on porting XTF to arm64 and already have something running.
> I think it could be a good starting point for you:
> https://github.com/orzelmichal/xtf/tree/arm-devel

Quick one - have you been able to get the "test-arm-64le-example"
application to run?  So far Xen gives me the following error:

(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Unable to copy the kernel in the hwdom memory
(XEN) ****************************************

I wanted to check with you before starting to dig into it.

Thanks,
Mathieu

>
> Regards
> Bertrand
>
> >
> > Many thanks for the consideration,
> > Mathieu
> >
> > [1]. https://crates.io/crates/xen-sys
> >
>


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 04:43:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 04:43:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242005.418633 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muomr-0007yM-Gr; Wed, 08 Dec 2021 04:42:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242005.418633; Wed, 08 Dec 2021 04:42:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muomr-0007xv-9b; Wed, 08 Dec 2021 04:42:37 +0000
Received: by outflank-mailman (input) for mailman id 242005;
 Wed, 08 Dec 2021 04:42:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muomp-0007xl-VY; Wed, 08 Dec 2021 04:42:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muomp-0004ko-Nz; Wed, 08 Dec 2021 04:42:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muomp-0001TS-Ej; Wed, 08 Dec 2021 04:42:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muomp-0003dJ-Dm; Wed, 08 Dec 2021 04:42:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jU2Rga/3H37t7/hjEPG9YPkrrO3j7xk4L/HmWzbJDdQ=; b=fw+7mAxQf1HVZyJkTGiQ/UqMw8
	Z/0zVw4f+liRO/tM7tpJ2VCPF1oI7oBXBSTntvAGmIHneaUcpNIxGlL4ETN6cqBsKDktde3xuuXp/
	jZLa5b6oubonfZUZMIVxCJdKkVYMAexPhTuYok/IyF6MJDulX1NHmcVfA/KF4irWgtjo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167224-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167224: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=31e08a365df4158794c45a36eed04621b7e4165e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 04:42:35 +0000

flight 167224 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167224/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              31e08a365df4158794c45a36eed04621b7e4165e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  516 days
Failing since        151818  2020-07-11 04:18:52 Z  515 days  496 attempts
Testing same since   167224  2021-12-07 04:21:24 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 86662 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 05:22:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 05:22:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242014.418647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupPQ-0005QW-G5; Wed, 08 Dec 2021 05:22:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242014.418647; Wed, 08 Dec 2021 05:22:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupPQ-0005QP-CW; Wed, 08 Dec 2021 05:22:28 +0000
Received: by outflank-mailman (input) for mailman id 242014;
 Wed, 08 Dec 2021 05:22:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CVwg=QZ=cimware.in=skiran@srs-se1.protection.inumbo.net>)
 id 1mupPO-0005QJ-Kb
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 05:22:26 +0000
Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com
 [2607:f8b0:4864:20::d2e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d214910a-57e6-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 06:22:23 +0100 (CET)
Received: by mail-io1-xd2e.google.com with SMTP id e128so1613775iof.1
 for <xen-devel@lists.xenproject.org>; Tue, 07 Dec 2021 21:22:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d214910a-57e6-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=cimware-in.20210112.gappssmtp.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=GykUpFrj2gtXFvfJ/e21Z3bLuFVDRCKreR4jZRRR+iM=;
        b=zzuA/zN7/QVfDxxCWZOKTysI6wxW0EAk+DslNCluLMCwOGS/0cxqs9UslOVvqn2dgt
         ytXmJ+DQuM2BX2vE/nMrVrwMv+6CItR9Mz1/qjEpv6nO3GHYRDm079mtEC+faGUJy3Oo
         d9ZXRyP7DmOaI+ko+qAlvSHH3FRTTs4lzX+HdWbQgPXeKrtl8wgDT4iWxHyWSuA8NHev
         8Siz4QhZOu6HP6ZXmy4xIUHq0oRO5nDAKzqiYvZ74ZMR4FKzfs2CQLmwb3FZB060DMeh
         FoX60pXRt5s5k1HavWfkKjkgPa02Ek98KJnGdojYsAbVbO8pdRWNo4iGIlUuT/uAhS4X
         oOjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=GykUpFrj2gtXFvfJ/e21Z3bLuFVDRCKreR4jZRRR+iM=;
        b=dAEXcPMbFb28QWYjFpsD8JRrGkJeVC1TgaUmKsOcJshr1YwjhkiwTE7m1WPlrf6FIF
         31BV67r/gPr8rIPHjYZ4+3EaCmPs/urEfhJgsnV2mjF+8Y1bBsRH5fzGHJ3UjcFddN8c
         k1HGUQJ1VQjY2DFEXZpEn28XPa7IOdjMVZKnDXqSVJ1to7sKsv1G74h3AK39HnlvO6O+
         xb4o+SuLw81533+HNUaZXM/lJlaa9LWE2bOPh81lMbfItIILoUO4TP+TZpMhNK8ojltF
         ALYt6QLZFwtl8WTytSDogeMaBlOmSBGvAoH8Q5Clu8cSRp+iRTxR/ydZ7itze7WQOv5E
         iAmQ==
X-Gm-Message-State: AOAM530hDSMwzx+HDhXfDEMEbFn76Je4EhV22cgYuEyWZiL+D3k1ZtUC
	fneqfWa1iI+Ln3auMBzRgpWva05zD1UwDcBs76QvaSQN5g==
X-Google-Smtp-Source: ABdhPJxBEMO3IxPO3ulzl+2bm0yMY70WVC5dck3fU83AKvTu10u3vmd9McgA4sEvtjXD+CS3LoijuhnYxoG1t44Wj/Y=
X-Received: by 2002:a05:6638:3a4:: with SMTP id z4mr57254606jap.76.1638940941611;
 Tue, 07 Dec 2021 21:22:21 -0800 (PST)
MIME-Version: 1.0
References: <CAAQMfLr_mWgdM3v=smYZbx+t8zhCP7_aCecDPJLLGRu=MH9E0A@mail.gmail.com>
 <e421fc4b-afde-8bdc-9be0-859523512b9b@suse.com> <CAAQMfLrxpc=6L_mp_EuPq-B+EydrFGaVqb_MiyjELPQYXi0e=g@mail.gmail.com>
In-Reply-To: <CAAQMfLrxpc=6L_mp_EuPq-B+EydrFGaVqb_MiyjELPQYXi0e=g@mail.gmail.com>
From: Sai Kiran Kumar Reddy <skiran@cimware.in>
Date: Wed, 8 Dec 2021 10:52:10 +0530
Message-ID: <CAAQMfLrv_nL_w-VbjSypnY1Ptbe-K_Gq71ovVf5o1nDqwM9cgg@mail.gmail.com>
Subject: Re: Xen on LFS
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="000000000000a205c505d29bac05"

--000000000000a205c505d29bac05
Content-Type: text/plain; charset="UTF-8"

Hi,

I have posted my query in xen-users mailing list one week ago. I was not
able to get any response from the community. Could you please look into it
and help me out here? I am trying to install xen(from source code), on
LInux from Scratch build system. I just want to know the list of xorg
packages, to be installed for Xen.

Thanks in advance for your time and support.

Regards,
Sai Kiran.

On Tue, Nov 30, 2021 at 12:58 PM Sai Kiran Kumar Reddy <skiran@cimware.in>
wrote:

> Ok, thanks for the reply. Will do that.
>
> On Tue, Nov 30, 2021 at 12:52 PM Jan Beulich <jbeulich@suse.com> wrote:
>
>> On 30.11.2021 07:50, Sai Kiran Kumar Reddy wrote:
>> > I am Sai Kiran. I am currently working on installing xen on Linux From
>> > Scratch(LFS) system. One of the dependencies of xen is "xorg" package.
>> This
>> > package is present in Beyond
>> > <https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html> Linux
>> From
>> > Scratch(BLFS) <
>> https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html>
>> > manual. But, there are a lot of packages to be installed. I am not sure
>> if
>> > all these packages are required for Xen. Also, is xorg a must, to build
>> and
>> > install xen?
>> >
>> > Kindly help me out here. Thanks in advance, for the support.
>>
>> Thanks for your interest, but I'm afraid your question isn't fitting
>> xen-devel.
>> Please raise it on xen-users.
>>
>> Jan
>>
>>

--000000000000a205c505d29bac05
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi,</div><div><br></div><div>I have =
posted my query in xen-users mailing list one week ago. I was not able to g=
et any response from the community. Could you please look into it and help =
me out here? I am trying to install xen(from source code), on LInux from Sc=
ratch build system. I just want to know the list of xorg packages, to be in=
stalled for Xen.<br></div><div><br></div><div>Thanks in advance for your ti=
me and support.</div><div><br></div><div>Regards,</div><div>Sai Kiran.<br><=
/div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_a=
ttr">On Tue, Nov 30, 2021 at 12:58 PM Sai Kiran Kumar Reddy &lt;<a href=3D"=
mailto:skiran@cimware.in">skiran@cimware.in</a>&gt; wrote:<br></div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Ok, thanks for =
the reply. Will do that.<br></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Tue, Nov 30, 2021 at 12:52 PM Jan Beulich =
&lt;<a href=3D"mailto:jbeulich@suse.com" target=3D"_blank">jbeulich@suse.co=
m</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
>On 30.11.2021 07:50, Sai Kiran Kumar Reddy wrote:<br>
&gt; I am Sai Kiran. I am currently working on installing xen on Linux From=
<br>
&gt; Scratch(LFS) system. One of the dependencies of xen is &quot;xorg&quot=
; package. This<br>
&gt; package is present in Beyond<br>
&gt; &lt;<a href=3D"https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.=
html" rel=3D"noreferrer" target=3D"_blank">https://www.linuxfromscratch.org=
/blfs/view/svn/x/xorg7.html</a>&gt; Linux From<br>
&gt; Scratch(BLFS) &lt;<a href=3D"https://www.linuxfromscratch.org/blfs/vie=
w/svn/x/xorg7.html" rel=3D"noreferrer" target=3D"_blank">https://www.linuxf=
romscratch.org/blfs/view/svn/x/xorg7.html</a>&gt;<br>
&gt; manual. But, there are a lot of packages to be installed. I am not sur=
e if<br>
&gt; all these packages are required for Xen. Also, is xorg a must, to buil=
d and<br>
&gt; install xen?<br>
&gt; <br>
&gt; Kindly help me out here. Thanks in advance, for the support.<br>
<br>
Thanks for your interest, but I&#39;m afraid your question isn&#39;t fittin=
g xen-devel.<br>
Please raise it on xen-users.<br>
<br>
Jan<br>
<br>
</blockquote></div>
</blockquote></div></div>

--000000000000a205c505d29bac05--


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 05:40:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 05:40:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242023.418658 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupgP-0007iJ-2m; Wed, 08 Dec 2021 05:40:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242023.418658; Wed, 08 Dec 2021 05:40:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupgO-0007iC-V7; Wed, 08 Dec 2021 05:40:00 +0000
Received: by outflank-mailman (input) for mailman id 242023;
 Wed, 08 Dec 2021 05:39:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupgN-0007i2-Re; Wed, 08 Dec 2021 05:39:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupgN-0005y7-IR; Wed, 08 Dec 2021 05:39:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupgN-0003KP-6z; Wed, 08 Dec 2021 05:39:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mupgN-000378-6A; Wed, 08 Dec 2021 05:39:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tccX3g1/9hr7nOKlMjCtchv+xN9nIehuk5+eEec6TsA=; b=6+nHzV5/bKJloSgLuBqlBkMBak
	sSzSexbMOAmnL82RG/WeNctUhjLr6dTrLQO43zaM6UBwVCB1w6frjVwVJbZ0dSlgLlMn0dfu6ml8N
	wGXdTcJrfQ7wp+PAKISuNyrXynJYV6gehIJsr7ENebML+cAh07GKjiLYIaFF8AyxXiLg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167221-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167221: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=2f8eb086732ad1875003101f5324f01c47d7408c
X-Osstest-Versions-That:
    qemuu=99fc08366b06282614daeda989d2fde6ab8a707f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 05:39:59 +0000

flight 167221 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167221/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167121
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167121
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167121
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167121
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167121
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167121
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167121
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167121
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                2f8eb086732ad1875003101f5324f01c47d7408c
baseline version:
 qemuu                99fc08366b06282614daeda989d2fde6ab8a707f

Last test of basis   167121  2021-12-04 23:14:54 Z    3 days
Testing same since   167221  2021-12-06 19:38:13 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Jiaxun Yang <jiaxun.yang@flygoat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   99fc08366b..2f8eb08673  2f8eb086732ad1875003101f5324f01c47d7408c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 05:55:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 05:55:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242031.418672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupvJ-0001rx-Ex; Wed, 08 Dec 2021 05:55:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242031.418672; Wed, 08 Dec 2021 05:55:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mupvJ-0001rq-BH; Wed, 08 Dec 2021 05:55:25 +0000
Received: by outflank-mailman (input) for mailman id 242031;
 Wed, 08 Dec 2021 05:55:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupvI-0001rg-JM; Wed, 08 Dec 2021 05:55:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupvI-0006E1-8U; Wed, 08 Dec 2021 05:55:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mupvH-0003y5-UF; Wed, 08 Dec 2021 05:55:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mupvH-0002aX-Tk; Wed, 08 Dec 2021 05:55:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Pcd5to23q0SdtC6XDDAVNyswszhAjSQR+SqAY9fM6bQ=; b=ePksDO9XrqJrR3mXchKBkWZ6mI
	+LUhNDF1u/ankfBfM5NSRfZ24cEsqfYqMrdHRFd+RaIlH+nNQazeJew6+KjeHliCNJcL8LKfW+xFY
	oYW8hsAfIMwluVcVk8O94Fpgc2ekRk3xSPJHwdohiXwx5Pn7p//WbQ53BBpzHcc+phTQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167222-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167222: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-credit1:guest-start.2:fail:regression
    linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=f80ef9e49fdfbfbc4197711230098b90e6b05a7e
X-Osstest-Versions-That:
    linux=0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 05:55:23 +0000

flight 167222 linux-linus real [real]
flight 167227 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167222/
http://logs.test-lab.xenproject.org/osstest/logs/167227/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-credit1  23 guest-start.2            fail REGR. vs. 167179

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-examine      4 memdisk-try-append       fail REGR. vs. 167179

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167179
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167179
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167179
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167179
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167179
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167179
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167179
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167179
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                f80ef9e49fdfbfbc4197711230098b90e6b05a7e
baseline version:
 linux                0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1

Last test of basis   167179  2021-12-06 04:55:24 Z    2 days
Testing same since   167222  2021-12-06 19:43:33 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Akira Yokosawa <akiyks@gmail.com>
  Andrii Nakryiko <andrii@kernel.org>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Erik Ekman <erik@kryo.se>
  Hans Verkuil <hverkuil@xs4all.nl>
  Joel Colledge <joel.colledge@linbit.com>
  Jonathan Corbet <corbet@lwn.net>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  fail    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit f80ef9e49fdfbfbc4197711230098b90e6b05a7e
Merge: 9d6cf4720203 333b11e541fe
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon Dec 6 10:46:20 2021 -0800

    Merge tag 'docs-5.16-3' of git://git.lwn.net/linux
    
    Pull documentation fixes from Jonathan Corbet:
     "A few important documentation fixes, including breakage that comes
      with v1.0 of the ReadTheDocs theme"
    
    * tag 'docs-5.16-3' of git://git.lwn.net/linux:
      Documentation: Add minimum pahole version
      Documentation/process: fix self reference
      docs: admin-guide/blockdev: Remove digraph of node-states
      docs: conf.py: fix support for Readthedocs v 1.0.0

commit 9d6cf4720203ed4db30855c01876ab4e5be61fd8
Merge: b806bec53881 07fb78a78de4
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon Dec 6 10:22:12 2021 -0800

    Merge tag 'spi-fix-v5.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
    
    Pull spi fix from Mark Brown:
     "Just one trivial update adding a device ID to the DT bindings"
    
    * tag 'spi-fix-v5.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
      spi: spi-rockchip: Add rk3568-spi compatible

commit b806bec53881f493c550107b8455afc7b7900009
Merge: 55a677b256c3 6966df483d7b
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon Dec 6 10:14:12 2021 -0800

    Merge tag 'regulator-fix-v5.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
    
    Pull regulator fix from Mark Brown:
     "Documentation fix for v5.17.
    
      A fix for bitrot in the documentation for protection interrupts that
      crept in as the code was revised during review"
    
    * tag 'regulator-fix-v5.16-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator:
      regulator: Update protection IRQ helper docs

commit 55a677b256c363a0cdcd00781d392abeb6e1c0d1
Merge: 0fcfb00b28c0 1ff2fc02862d
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon Dec 6 10:09:00 2021 -0800

    Merge tag 'efi-urgent-for-v5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi
    
    Pull EFI fix from Ard Biesheuvel:
     "Ensure that the EFI memory map resides in encrypted memory even after
      it has been reallocated"
    
    * tag 'efi-urgent-for-v5.16' of git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi:
      x86/sme: Explicitly map new EFI memmap table as encrypted

commit 1ff2fc02862d52e18fd3daabcfe840ec27e920a8
Author: Tom Lendacky <thomas.lendacky@amd.com>
Date:   Wed Oct 20 13:02:11 2021 -0500

    x86/sme: Explicitly map new EFI memmap table as encrypted
    
    Reserving memory using efi_mem_reserve() calls into the x86
    efi_arch_mem_reserve() function. This function will insert a new EFI
    memory descriptor into the EFI memory map representing the area of
    memory to be reserved and marking it as EFI runtime memory. As part
    of adding this new entry, a new EFI memory map is allocated and mapped.
    The mapping is where a problem can occur. This new memory map is mapped
    using early_memremap() and generally mapped encrypted, unless the new
    memory for the mapping happens to come from an area of memory that is
    marked as EFI_BOOT_SERVICES_DATA memory. In this case, the new memory will
    be mapped unencrypted. However, during replacement of the old memory map,
    efi_mem_type() is disabled, so the new memory map will now be long-term
    mapped encrypted (in efi.memmap), resulting in the map containing invalid
    data and causing the kernel boot to crash.
    
    Since it is known that the area will be mapped encrypted going forward,
    explicitly map the new memory map as encrypted using early_memremap_prot().
    
    Cc: <stable@vger.kernel.org> # 4.14.x
    Fixes: 8f716c9b5feb ("x86/mm: Add support to access boot related data in the clear")
    Link: https://lore.kernel.org/all/ebf1eb2940405438a09d51d121ec0d02c8755558.1634752931.git.thomas.lendacky@amd.com/
    Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
    [ardb: incorporate Kconfig fix by Arnd]
    Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

commit 333b11e541feeb79e7cce31dd5b280ceded388e4
Author: Arnaldo Carvalho de Melo <acme@kernel.org>
Date:   Fri Nov 19 15:56:03 2021 -0300

    Documentation: Add minimum pahole version
    
    A report was made in https://github.com/acmel/dwarves/issues/26 about
    pahole not being listed in the process/changes.rst file as being needed
    for building the kernel, address that.
    
    Link: https://github.com/acmel/dwarves/issues/26
    Acked-by: Andrii Nakryiko <andrii@kernel.org>
    Acked-by: Daniel Borkmann <daniel@iogearbox.net>
    Cc: Alexei Starovoitov <ast@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Link: http://lore.kernel.org/lkml/YZPQ6+u2wTHRfR+W@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Link: https://lore.kernel.org/r/YZfzQ0DvHD5o26Bt@kernel.org
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit aa9b5e0df226edbf1879cb8f17a409cc3fd89c9d
Author: Erik Ekman <erik@kryo.se>
Date:   Fri Nov 19 21:07:58 2021 +0100

    Documentation/process: fix self reference
    
    Instead link to the device tree document with the same name.
    
    Signed-off-by: Erik Ekman <erik@kryo.se>
    Link: https://lore.kernel.org/r/20211119200758.642474-1-erik@kryo.se
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 5c81691bb6461a474ac9d6ad5737c12e8f558a8b
Author: Akira Yokosawa <akiyks@gmail.com>
Date:   Fri Nov 26 13:11:17 2021 +0900

    docs: admin-guide/blockdev: Remove digraph of node-states
    
    While node-states-8.dot has two digraphs, the dot(1) command can
    not properly handle multiple graphs in a DOT file and the
    kernel-doc page at
    
        https://www.kernel.org/doc/html/latest/admin-guide/blockdev/drbd/figures.html
    
    fails to render the graphs.
    
    It turned out that the digraph of node_states can be removed.
    
    Quote from Joel's reflection:
    
        On reflection, the digraph node_states can be removed entirely.
        It is too basic to contain any useful information. In addition
        it references "ioctl_set_state". The ioctl configuration
        interface for DRBD has long been removed. In fact, it was never
        in the upstream version of DRBD.
    
    Remove node_states and rename the DOT file peer_states-8.dot.
    
    Suggested-by: Joel Colledge <joel.colledge@linbit.com>
    Acked-by: Joel Colledge <joel.colledge@linbit.com>
    Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
    Cc: Philipp Reisner <philipp.reisner@linbit.com>
    Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
    Link: https://lore.kernel.org/r/7df04f45-8746-e666-1a9d-a998f1ab1f91@gmail.com
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit d69dab7de208748ddf79143b39d98db55eee9b4a
Author: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Date:   Sat Nov 27 10:14:49 2021 +0100

    docs: conf.py: fix support for Readthedocs v 1.0.0
    
    As described at:
            https://stackoverflow.com/questions/23211695/modifying-content-width-of-the-sphinx-theme-read-the-docs
    
    since Sphinx 1.8, the standard way to setup a custom theme is
    to use html_css_files. While using html_context is OK with RTD
    0.5.2, it doesn't work with 1.0.0, causing the theme to not load,
    producing a very weird html.
    
    Tested with:
            - Sphinx 1.7.9 + sphinx-rtd-theme 0.5.2
            - Sphinx 2.4.4 + sphinx-rtd-theme 0.5.2
            - Sphinx 2.4.4 + sphinx-rtd-theme 1.0.0
            - Sphinx 4.3.0 + sphinx-rtd-theme 1.0.0
    
    Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
    Tested-by: Hans Verkuil <hverkuil@xs4all.nl>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Tested-by: Akira Yokosawa <akiyks@gmail.com>
    Link: https://lore.kernel.org/r/80009f0d17ea0840d81e7e16fff6e7677919fdfc.1638004294.git.mchehab+huawei@kernel.org
    Signed-off-by: Jonathan Corbet <corbet@lwn.net>

commit 07fb78a78de4e67b5d6d5407aeee1250a327a698
Author: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Date:   Fri Nov 26 16:43:42 2021 +0100

    spi: spi-rockchip: Add rk3568-spi compatible
    
    This adds a compatible string for the SPI controller found on
    the RK3566 and RK3568 SoCs.
    
    Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
    Link: https://lore.kernel.org/r/20211126154344.724316-2-frattaroli.nicolas@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>

commit 6966df483d7b5b218aeb0e13e7e334a8fc3c1744
Author: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Date:   Thu Nov 18 13:49:51 2021 +0200

    regulator: Update protection IRQ helper docs
    
    The documentation of IRQ notification helper had still references to
    first RFC implementation which called BUG() while trying to protect the
    hardware. Behaviour was improved as calling the BUG() was not a proper
    solution. Current implementation attempts to call poweroff if handling
    of potentially damaging error notification fails. Update the
    documentation to reflect the actual behaviour.
    
    Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
    Link: https://lore.kernel.org/r/0c9cc4bcf20c3da66fd5a85c97ee4288e5727538.1637233864.git.matti.vaittinen@fi.rohmeurope.com
    Signed-off-by: Mark Brown <broonie@kernel.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 07:08:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 07:08:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242043.418686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mur3f-00035D-1W; Wed, 08 Dec 2021 07:08:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242043.418686; Wed, 08 Dec 2021 07:08:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mur3e-000356-Tw; Wed, 08 Dec 2021 07:08:06 +0000
Received: by outflank-mailman (input) for mailman id 242043;
 Wed, 08 Dec 2021 07:08:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xuKF=QZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mur3d-000350-UP
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 07:08:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95fa9018-57f5-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 08:08:04 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-3-9lSsu06WM9a2rRRjWzTpxw-1; Wed, 08 Dec 2021 08:07:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6173.eurprd04.prod.outlook.com (2603:10a6:803:ff::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec
 2021 07:07:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Wed, 8 Dec 2021
 07:07:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0292.eurprd06.prod.outlook.com (2603:10a6:20b:45a::23) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Wed, 8 Dec 2021 07:07:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95fa9018-57f5-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638947283;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=L8xhJDuukGRfkPNu3aS01j7MNMt5iGb8QYj0Giu0wyk=;
	b=KS84v+4I//LCePc5s91UZSYTpyS4aeUE1K8C2tWVq+trqXXh8L+o9kjqy+nInOR4/68w9S
	SNd1fi5QqnLHQ5f2ua7zKrjQutcTdCRN9CKL3mWZ/pCxODs75/Oh9nbPUJr9dEUqJOZzv1
	FSauhdem4Tw+3sHRRlZZ09pnzcYTFtk=
X-MC-Unique: 9lSsu06WM9a2rRRjWzTpxw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iFumr+fFG4O48CqUiO0j3/Ux5CbgWy3mnYoh3kIK151DBRMdp7sSVfuwrlNcZ9NTq+qoFFSo0WzcL3qbiaekTNUwJEy+D4Yw94vT96zntjyUHr0Im+B4Av+xmoSMFxoq9jrS4lnxyKVUKbXD61M/+02k2/bfaUeuDZk5Ki+EoDRUBRfk+EYP5f5D9qf8TfXjHaPQW2Bf+QzKoYQtJYVO5XF0p0V+8IU6KYlHyL5feJYkbTMRGExnkMEDkUhIFMkfbZiEcht4z26Vs/e6V1zgVW2d+9PNoFrFz6a4VaOR5e2zpJ8JcLHuVuJOeNeCuion9kAVQB7sQvvku3XFedP79g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L8xhJDuukGRfkPNu3aS01j7MNMt5iGb8QYj0Giu0wyk=;
 b=WQWjfMvHfsZ7OEUlbpjet1dqEotoER46p0u1N/cLX+3gw9tK0Y3jdIx6B1oggzghKR4igWjvyu4fwXx5Rrikz2a9eMu11Vj1Rd6hqTdNXPBXK/rmvlHx9A4lIWWZxQ6TI/vwVrGzkLQYyLiVRL2ky3jZJekkRYuZs3KLwmxojhyJ3jBZOZuXSZBQnL2vgI430URC3O5g0RcPY0xM+LfZRUKBbY+3zDFVMREeQGyGdyu6HnQM3I5C2gSAvMLbjaJcfn8PRygZ34iqaSqp4T9mMiuwl7/C8PIBHnXBCrgoLxjmnmO6XH+upDsc6Mk31oFv9PbBXfsdnYIxyQ2SJuJfdA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
Date: Wed, 8 Dec 2021 08:07:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Ian Jackson <iwj@xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] MAINTAINERS: widen Anthony's area
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0292.eurprd06.prod.outlook.com
 (2603:10a6:20b:45a::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fc58719-b4ae-4273-3f0f-08d9ba19761d
X-MS-TrafficTypeDiagnostic: VI1PR04MB6173:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6173BC03AA4B614735E3AA09B36F9@VI1PR04MB6173.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FTCYm4xtUmgepaMljwLcfumXSp/NV1rcAxaZLXFU5RezepHjnhziwanmkmqtLiRrqaY0Flyft7Dj5YMfN2/HfJnDVhu9M557yX7f9XZ0lRSVLVt0pUwkERMe3nRjYnJUX2fw2VVolmm0af1CQiQPeAN55jVkz4B21iJS3qbUT+YcopeZEBG6xccrG/5vOuPXgE5OnXXgBAdqUfl3a5rmHA+/azDv/vXPEac5pPnME/SDxpY7RHG1qSjixF4Z8DAqRGd9ZHyQmu22EmoUq33AilMiQg7MY/JwCjJVApMGmotBAxArBjX5xy+DMLVdFS5EVF9raav1Qa4wS97PdN2Ma0D77jafPelzA5LTwsPuGA0v8/sDUEPwHHUUd4cTvyh73lUpnuiYHp8L/U4+qaIP1CxSJVeIrOBU8mc9lUXQetquSQ/hWk8DN6MWunpdAGjDHTI2puhDdnKpyWqXgBRyE4fWd0N3Fl+0Qy9Cg4V3OZaq5oiRuDddbbS03GYm61YYzH91NC+98UM7nCRgyY/nxLr2hY5hEUVnRZRjuPs+CRjQ25USG5fJK1s1eWUO58G7Htr2pbmTjv0f0JmxmL4+qE+5KDVac+Dj9LoIFHxxSYVSQfQSuJt1WCzLg9nv7oKbJYriUpOMFF2Y6yjaECsjHLVB///EibIEX3fKDP7q3w3spY9cwvEM7WX7Y3TWhpXKbTMD7L8yNrCtY9uJ9I2KBleqxPLA5zliuq/HiqTLEJo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(66946007)(83380400001)(66476007)(36756003)(31696002)(66556008)(5660300002)(26005)(86362001)(6916009)(956004)(186003)(31686004)(2616005)(16576012)(2906002)(6486002)(8676002)(8936002)(316002)(4326008)(54906003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VzRUeUMwL1VWc2xKa25wTVk4TjZaR0NwVm41UmUxZmo1aVhJV3dnZ01Md1dV?=
 =?utf-8?B?cDhFUGVKaHZXcHE0Y3NVNys5OXRZOWZ1bkdkMm95WXlVMitpSjVIMVFpQy90?=
 =?utf-8?B?dHhaRmVSRXlvVFVnS0R6Q1BpVnJvVEVVcE1oYTBCeDg4WVNNYlRpOHpKc1pu?=
 =?utf-8?B?LzVCVzdMbXE4cUFuWjU3Mk1UVmJJaUdCR1pGN2UvNlBUcWtjVHV3Z1VyYlBz?=
 =?utf-8?B?RzhmU1BKK05tSk1HdFp0YzF4MURFdUhDYlBnOEpsOGtXUEJLdk1nd1dDS3Qx?=
 =?utf-8?B?TlZyOUMveHh4TXVNSTNDaTNmQnc1U1lZUUhaS1VkMjVRR3EvTkR2VS8wL1hz?=
 =?utf-8?B?eUk4NXgvRFFJd200b3lXS0Z2b0FBcWNTQUhJNEwvdEpEcUJ0QzQ5Z2xDQWRS?=
 =?utf-8?B?aFVuNXg4VmlDN0JtVWF2OEdRSWtnNTNTSW1hNCthRVFvWjMzbXZRUk4zSXU1?=
 =?utf-8?B?Y0I1ZFhOZGRlYjhkTldVUnVQV216YXZyay9wRWlzUWpqV05tWXRpWlRyQURW?=
 =?utf-8?B?aERpNmZ1aUZKR2tib0ZHcjRVK1VCTzNHVkw0UW5OQnQzUW9MWnhOUVJFNFFy?=
 =?utf-8?B?YjNCdVowaVh5ejFNZTQ5NjZrTHdsdDM4U3JQRTNDMUlsNnNsREdLV0tPYkNX?=
 =?utf-8?B?bFdFRWpCaUNNYlVFMm01eUZZNENWNUlaOEdZSnp0L0tkZStUZEM1SXg3Wlo1?=
 =?utf-8?B?bU5VVDVJMVZsWFF5ZVV6a2RmQWhIOTVqWVBhUWtsdGlYTFBYZDBJc0d1NW5k?=
 =?utf-8?B?RVlzdDQ3QVZMUzNBTDF6TnRrNU91VzRjWTB4Vm9zNGdCbkZaN1V0NEFESXkv?=
 =?utf-8?B?QWV4c1dXY3VKRllHNGRxRGptVnhxMjBXN3R4dzYwZnlQUytWL3RvMEVIbkpu?=
 =?utf-8?B?VkVKeXk4WDhjRG1kYWhlV0JPRkROWTE0a29JS3lKOXc0TDdsakJ3dW11T2Fm?=
 =?utf-8?B?RXJIUUY0ZXdPVHZGMTJJSHdpYzlrWFhTSmszZk1XQ3kwZzFCRHpoeWRFdWxz?=
 =?utf-8?B?aTczSXZ0NDVhSHdFV2ZkVmhlSlBEcFZhQ29Eeld3SmRqdkJSR0dWSkV6RTJp?=
 =?utf-8?B?MVdtdHMxVkN1QXorLzdpYTArS1d4bjRFVkJKUmxHMzFWZ0RsSDB6Y0lDR05H?=
 =?utf-8?B?Vk1RMVpZMk9LMmYyenZ1RmF2clJlYjFhY2lSQVB0eXRiZHFFZkcxd281SkF3?=
 =?utf-8?B?akptWU5iTzZvOFBjUUVzd1I5Vm5Kc3hub09QQzJmbUh5S2UrUGJxbnNYMFla?=
 =?utf-8?B?eEFhd01qVzNIeXBoNVVRaXN2NXZxYkJmeVMyUzRxU1RuMmp4KytETVMvWmxv?=
 =?utf-8?B?aDk0T0I5Ry9hU2RHeU0wem5kVmpWM3BNbjhocVRCa1N4ZjZOeUJlc1Z5cW5B?=
 =?utf-8?B?VmlCZUkrYjhOeDFOK3ZtUmJYYisySWJNeU5kZWtSd3gwSldiZmNIUGJnTk10?=
 =?utf-8?B?cUdXSm5OcWUzQlJUZ25LaVpjMXF3Q3IzV3BVKzhpblo0TjhyRmtXbWxnay8v?=
 =?utf-8?B?dEE3WkZtR25LMUhiMzdvN3VFdEhOZ2gyK2xOTDZkbEc3ckVLbk1rb2F2aFhx?=
 =?utf-8?B?YWFiUW1BYXZSTXB2NmF6SzlxTFVzL3dpN3duWGRReGI5Vlo5YkNJeGtFV3Bp?=
 =?utf-8?B?QWJvSmFUdkVVdHhWR2o5U0t4UXlDZklxZy9zOUN4SFNCMXpFc3FTMWR1a2RC?=
 =?utf-8?B?WHZBblBHZjRQVnl2WE1rWFhGM2JsMXJRZUw4dlBrNUNHL0FpdlN4RFRXRW0y?=
 =?utf-8?B?VHhzZHBpUXZQRlBlNkJOVU52WW5QZU94RDlET0tmSTh3T0Evd0JWT3J1VmtO?=
 =?utf-8?B?YWFSNlpMN3lHa2ZEa2wzQnpvTTFpbEdERHNIRjFMb3hJODErdjJlWk9OdTJJ?=
 =?utf-8?B?eU1Nak5MSUFhNjczSDQ0YlFZQ2VQNVVyd0tQVy93ZmVKQ0gwR0ZIV2J5VE9z?=
 =?utf-8?B?N21qOG1WbVh1WVQ1aWJQMHBwU3FIa2JkZXlUdTJZaVZqSmtZOHhuNzdQWG1O?=
 =?utf-8?B?UGZNTGhxTDFSUzY4dkl4ODVMb25aZG5saE1Wb3A5MVBTTFl2Z3dOdDEyR29w?=
 =?utf-8?B?MlU5QldKRm84dHRkazVkbTJ4dEhkQVZLTWEyZGlNc2lKSmhhUU5RNkZCZFpi?=
 =?utf-8?B?a3JFZWE4cVBJbVA3SUNPT2RHeDJ2aURzMkk3YXNReHljSDcxalI4MG9IazBm?=
 =?utf-8?Q?/uSmyCoTe5E5cGjztyVrnO0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc58719-b4ae-4273-3f0f-08d9ba19761d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 07:07:56.9851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8t7DJKyyzoOGIoAUh1QsuiElaT9dQCBqcSXt+EWkhYDwRD9vlSqyQU0Gmy92nweTL32X7ITLg2IU0z6P+NqKvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6173

As was briefly discussed on the December Community Call, I'd like to
propose to widen Anthony's maintainership to all of tools/. This then
means that the special LIBXENLIGHT entry can go away.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Note that we're still looking for a 2nd maintainer there, considering
that Wei's time is rather limited.

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -375,9 +375,11 @@
 
 LIBS
 M:	Wei Liu <wl@xen.org>
+M:	Anthony PERARD <anthony.perard@citrix.com>
 R:	Juergen Gross <jgross@suse.com>
 S:	Supported
 F:	tools/include/libxenvchan.h
+F:	tools/include/libxl*.h
 F:	tools/include/xencall.h
 F:	tools/include/xenctrl*.h
 F:	tools/include/xendevicemodel.h
@@ -393,15 +395,6 @@
 F:	tools/include/xentoollog.h
 F:	tools/libs/
 
-LIBXENLIGHT
-M:	Wei Liu <wl@xen.org>
-M:	Anthony PERARD <anthony.perard@citrix.com>
-S:	Supported
-F:	tools/include/libxl*.h
-F:	tools/libs/light/
-F:	tools/libs/util/
-F:	tools/xl/
-
 LIVEPATCH
 M:	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
 M:	Ross Lagerwall <ross.lagerwall@citrix.com>
@@ -514,6 +507,7 @@
 
 TOOLSTACK
 M:	Wei Liu <wl@xen.org>
+M:	Anthony PERARD <anthony.perard@citrix.com>
 S:	Supported
 F:	autogen.sh
 F:	config/*.in



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 07:20:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 07:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242049.418697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1murFm-0005dI-6z; Wed, 08 Dec 2021 07:20:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242049.418697; Wed, 08 Dec 2021 07:20:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1murFm-0005dB-2B; Wed, 08 Dec 2021 07:20:38 +0000
Received: by outflank-mailman (input) for mailman id 242049;
 Wed, 08 Dec 2021 07:20:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xuKF=QZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1murFk-0005d5-QI
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 07:20:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5514f200-57f7-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 08:20:34 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-z8LQ6pXPN0quYU2FtdJg_g-1; Wed, 08 Dec 2021 08:20:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Wed, 8 Dec
 2021 07:20:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Wed, 8 Dec 2021
 07:20:31 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0206.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Wed, 8 Dec 2021 07:20:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5514f200-57f7-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638948034;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=l+6ajF4T0Q7XoX6xysx4OUr69jG3xXH61OqGaErEBgw=;
	b=EIkKC/oDR+1xsmnZCbDw5eZ6prjKMG8mMCHNdEZsebrunUbUvmR1xPSzgsZAUBrv2I/kNW
	v3qHKNJugE4yRb44GM9gC/7ySKVmFUg/SvRr+AUlXmN7jXSu6zXI3sLplwzyqv7FDu/Ohr
	2GSLAOCF3IX6Z7qw9S1cLcNy31ldHKg=
X-MC-Unique: z8LQ6pXPN0quYU2FtdJg_g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gkt3okCX77slde6XtFYAvhycEMRsMWY9kJ8riTQNZWy0F7IA1Iufq0GjLOkS3qRRwuNf23U7/Bra7V54DbMo9v0pYCExzz3JCfDCxv/qVgOiqWCADDeJbkheEZXR6p1dsbqREFuJOs6TxDbWpbYJ49ZF7PZxFPbqbanyWd1vUbQLk2goG4BlmDm2lJLBJpODSDLjuRzh9q2SmnNStSDUQ93trzLa9Q9EwAfn/1t2HW+aaZcHtg7VuCZmFAuj+FVKWLWc+gsuxT8e3VymKeoJhJB3g7fQ3tFhlQDHQrXRAgnPSOJw3Qu+HF1gbsJwi3p+rINHd3f/BZJyuRVgahLLDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=l+6ajF4T0Q7XoX6xysx4OUr69jG3xXH61OqGaErEBgw=;
 b=SY0Vv5wEC5pBJHRhr5AmTHVpXnTqOTlizcVernLs8W9xTBNQYKSwARX8DaokfQeSfY+Gbu6UGBajWcooJrEzWD32v5Ql1oS35V7caFSuJZ02zpb7EtRrctU9CJaEnfOSf53Zf0MA2SbWj2vxXtNei76T1YjnnEYPuz4N6I3lS4r39DpU4AAW+gV/NqZIIO2ix9Jm2nzkVgh1eZQXagE/GnI4UDQeVb4DtFcYAOfcB4cKf9JxUS3nCbxND+r7tuce4LRT7KbAmnyP4YIxVyeK5cBnYfq0blHk0eiSFI+YlRUiZ+YWtaWtN8JoLm2ChABX69NEXIxMjWGorBtlxH6gZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
Date: Wed, 8 Dec 2021 08:20:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0206.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 264670ab-a567-4d63-aad7-08d9ba1b376d
X-MS-TrafficTypeDiagnostic: VI1PR04MB2960:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29605201D583B5E88E4FB9E5B36F9@VI1PR04MB2960.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hwYC6K0Egs3wpafN1Y1AhFrT8vqGNn1OAbPQt3jaFJGobvzhH77vplPFgFBe0njvxPJh1HInH9U4k4O8KY+xHv0ajIN6I7WyLxubcyX3FaV229wR1QPMg+K/+jDiLa6owz8vmgjUk8Rn6W21dUGHu2YGpSPiDRLSD5ydaqYnJVFIVp5Yb8E48K4or156Du9FonTQ6/dj2Tbmwg/8b+3tJ3nAczMe+gbEqWiq2Jk9P7nlK8o7ybU1zM1ut9f9zHRvgcR342vS0uH0hv9gCHZqDO044ZtctK4COgFbZ27FCcV9lYDlfG8QB9o+nf4YlIaw+0WJrJE72nPb3c6ctJnD4Pt1TbGCPMcJkUCPfl/vAYe+zR7yBy8K+Eo2i6/R5wmwoDFj3ud26ok6EbPmeO1gqC/fcf/ctCvkFeysMKFuBuQmHA1Z6wMMdKj4P1uu1gQ9BumYPTwgoHmWAhU5/kBNYz0soW//0p2eTmlIp67xYHDCAkiMbaJtUGkJls19NKgz7QiCwlb+5v4/GWfSDujICavMxDn0xQC3Khzpevwv/VYUmFpB4CFVO3krw+a12egSA8qKlQjZhNoZhhgrzcvHI7EilVN1XHMbaXrTtw3jT/x3TkEjjfxpw80cYjr6/MX4qiT5KMQZmLOvj0kveZLodPDpiusr0P4N1tADT9nNcL1L+gRr+kq5qSe0OILd7kXRrFc17u/JayOCsgNhrrWfcBQzAkB5cXdjv0zKOw4dlnrEuew97+GJNdDyj9DnyLoH
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(83380400001)(4326008)(186003)(54906003)(110136005)(956004)(5660300002)(16576012)(86362001)(26005)(8936002)(2906002)(31696002)(2616005)(31686004)(38100700002)(6486002)(66556008)(66476007)(8676002)(316002)(66946007)(508600001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3JPMGtNVVNHbzlJb2hSSXhrRW1MUnhUK05HR3dhbHAwYUZlUWZya3BzeWtI?=
 =?utf-8?B?SEp5VHVaUDRFMzBpZ0hUYjc2WWYrWkFIeVZ0VkFCdEtSbGJhRDg3L3F5ZmVW?=
 =?utf-8?B?aDNkNVc1Z1c5THJweUZEa3pRZEMxaEtCTEZMUUtVS29FUVllOStubndrRmVs?=
 =?utf-8?B?djRWNnVWbDVMckJJMHkrMDNZRFJEdCtxZnhCUjVXNlR4eWU5UUJab0VTR3N0?=
 =?utf-8?B?UjFPdjc4eW9HdTZZd0UrVnU0eVA4ZXlaWDh5RmlGUGNpM3pRYUNuYTYxdzZa?=
 =?utf-8?B?TzNZUkNJcWpkdTZDUWFXOTFtZXVYSzRIWlVBcGI2VVE4cUgvaFJ0Z2ZtYzVF?=
 =?utf-8?B?a0FodURBbFZsaWVhZ2pOdXphUC96UGt1cUMrMFVncWxOUENDbmdYZVhjMmtq?=
 =?utf-8?B?ZTFSNlY4RE44bk0rSVkxbFRBUjRKUUlaU2pXVEFURTdFVysrNEZ4YTcvTDgx?=
 =?utf-8?B?c3E4ZlcwN1hSL2lycHBmaVh5ak4yQ0dWNEx1UC8wSFhsbnorU2ltTVZwL0Iw?=
 =?utf-8?B?Q2xDVHQwUHhObnh5L01MdVdreGFaSG9TVVhSNUU2K0FoVkZmc2puQ29VcEs5?=
 =?utf-8?B?elIwRTJYUTlCcWxucTNNTjZ4SFduS3RIU1JkcmdiSnFxSzVFczdCcTBsQVM1?=
 =?utf-8?B?dWt3VVBucUJYZVNUWmlmZEl3RW9UaGUwSElGRWxjMkYxaFBOK0g0N0kzK1Ju?=
 =?utf-8?B?M3p4dlZ1U3lnUDNoSkN5MmhiZWpPL3lJRElDNkVBNVJQanl5M0dWSWU2ZVVv?=
 =?utf-8?B?VjUxVjNIV0M4MkRKNW5XanlvMnF0RW4wUE1SSnh5VndyMW5QOTVCYjRFQnla?=
 =?utf-8?B?ZGVXMzN0ZFlQS2lqK0J5NjJvV04xeW1iNis3TTVzTjI2ZkNmcFNzQzJ5ajlp?=
 =?utf-8?B?Y1hTTzdNanZ5NjVjejFCOGZJQ0s2SFFJRkRYOXUwSWozUU5aN0JWSXhlT3FI?=
 =?utf-8?B?bFJhaFZMVmNFS2tPc1pBN3dMdmNFc20xSGRSQnBVWXluT1VzR0NCMzFIRTJ4?=
 =?utf-8?B?TlU5cktkUVNOc0hER01sdkdQa3RsTWNzeTQ3QmJIV2xHRDRjb0w3a2lVSlZk?=
 =?utf-8?B?MGtlakVUeGJFWW1RcTAxNy9tSWZVTkdNQTBCK29aVkVmeWFBQS9BVmI4UlYz?=
 =?utf-8?B?VUE1V1BnTzhMOWVSYnlqNGhBUVRkWTdDQ0xrNjBHeW5sM0lJVmNJVGdtVy9w?=
 =?utf-8?B?MHZUMWpsdHBtenJmZmhZR2pIam04RVUvVHlkM2NndjBtN3AyajRBMzBrL3ZP?=
 =?utf-8?B?WEVqdlJsWTFCRGgrLzcwbmYrd3V0Z3JSUENwbTIvMXBORXpFZzJTUVdkVGZr?=
 =?utf-8?B?QjBZeWVxVHhydkgvanRRdHBLTk5sMGFBVDNIMEhqQVNNcWxUZS96b3phUWZo?=
 =?utf-8?B?QWJpNDAyc2t6QTRwME1kaWxyY0p4MnFGOU1YejdSU3F2K1JwZnBYY0hFTm9B?=
 =?utf-8?B?eXBnV3ZNMkhCZWdZMmV3QVJTbW5xU2lab0JUN2RLK0FtVjl2TS9nUGhDbGo2?=
 =?utf-8?B?VFYwOEVLcC9MMlVnSS8vek4zSmltT0hpTjV5d2ZsYVdUNkxzeDJlL1VjNmcz?=
 =?utf-8?B?dC9QaWczTU05MzFyaElxaWp4NTBkQ3MzeXZqNGhYcUZ0YXdyQ1dpZUhEZXhX?=
 =?utf-8?B?ajh2ckF4Wm81b213cGdQaW8wRWo5Mm02NjZoVERBNXRxN2tzMzQ5c0ErWmR3?=
 =?utf-8?B?d0xrMnZuV1VWWGhUTXlpSmZ3SUVHNHJ1VFlpcXR3RnVDejB6cDZNSFpuTDZt?=
 =?utf-8?B?WFdEVXZNWWl0OW0xMHN5U3J5R2NDVU91UTFOY0tCbW92T3JCOGQ3cVE0VjRm?=
 =?utf-8?B?WTQwZ285YjdqL0ZtR3FvR1JURzJKNFNPYjhpYUFJaVRpWWZrTWhPZU1ONE9N?=
 =?utf-8?B?MWFCUVBXa1BBUFkrMkphUnllaHJONExNeEs1ZFJFUmkyMDJjUG03VURZWVYr?=
 =?utf-8?B?K3Q3NFI2T0NPWFFIcHNtY0NPK1pTcklqMzhxOWxvNFVxVnd4OExPM2VYWFNn?=
 =?utf-8?B?QnR3bzdrcU9Bd0djazJyNXZBMThKQmVKc1F1ZEswOEoxRGZ0bFoyaFBaR0Zm?=
 =?utf-8?B?ZjRsbGVSMEhzcE8raGRQZ2VKVWxDczkwVmNOcENGM2Z6M1E3eGtteWZhWm52?=
 =?utf-8?B?VUpnR0kwTkxmWXh3L3FiZGpzbFN5aDl3YXdXL3lnS25hNmZNYWZlM3I4b3kz?=
 =?utf-8?Q?p/7lPbaCi5ftbFpOP+/Hipo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 264670ab-a567-4d63-aad7-08d9ba1b376d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 07:20:30.8492
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lqlF517oqAxRcoh8qn8c3R+UY4CZL5fOdeJY3sNf3361p9kj/xyZfhS4NKBUJuEzJPLeim0pUkW47Jwb3+9DrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960

On 07.12.2021 20:11, Julien Grall wrote:
> 
> 
> On 07/12/2021 08:37, Michal Orzel wrote:
>> Hi Julien,
> 
> Hi,
> 
>> On 06.12.2021 16:29, Julien Grall wrote:
>>> Hi,
>>>
>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>> to hypervisor when switching to AArch32 state.
>>>>
>> I will change to "from AArch32 state".
>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>> "If the general-purpose register was accessible from AArch32 state the
>>>> upper 32 bits either become zero, or hold the value that the same
>>>> architectural register held before any AArch32 execution.
>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>
>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>
>> Ok.
>>>>
>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>> needs to be fixed.
>>>
>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>
>> I would say:
>> "
>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>> if the command passed as the first argument was clobbered,
>> "
>>>>
>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>> entry to hypervisor when switching to AArch32 state.
>>>>
>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>> when not passed.
>>>
>>> Which error do you see otherwise? Is it a compilation error?
>>>
>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>> So basically in all the places where entry is called with hyp=1.
>> When taking the current patch and removing default value for compat you will get:
>> ```
>> entry.S:254: Error: ".endif" without ".if"
>> entry.S:258: Error: symbol `.if' is already defined
>> entry.S:258: Error: ".endif" without ".if"
>> entry.S:262: Error: symbol `.if' is already defined
>> entry.S:262: Error: ".endif" without ".if"
>> entry.S:266: Error: symbol `.if' is already defined
>> entry.S:266: Error: ".endif" without ".if"
>> entry.S:278: Error: symbol `.if' is already defined
>> entry.S:278: Error: ".endif" without ".if"
>> entry.S:292: Error: symbol `.if' is already defined
>> entry.S:292: Error: ".endif" without ".if"
>> entry.S:317: Error: symbol `.if' is already defined
>> entry.S:317: Error: ".endif" without ".if"
>> ```
> 
> Thanks for input. I am concerned with your suggested approach (or using 
> .if 0\compat as suggested by Jan) because they allow the caller to not 
> properly specify compat when hyp=0. The risk here is we may generate the 
> wrong entry.
> 
> compat should need to be specified when hyp=1 as we will always run in 
> aarch64 mode. So could we protect this code with hyp=0?

Since my suggestion was only to avoid the need for specifying a default
for the parameter (which you didn't seem to be happy about), it would
then merely extend to

.if !0\hyp && 0\compat

or something along those lines.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 08:33:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 08:33:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242063.418708 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1musO6-0006sD-QI; Wed, 08 Dec 2021 08:33:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242063.418708; Wed, 08 Dec 2021 08:33:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1musO6-0006s6-MU; Wed, 08 Dec 2021 08:33:18 +0000
Received: by outflank-mailman (input) for mailman id 242063;
 Wed, 08 Dec 2021 08:33:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musO5-0006rw-EW; Wed, 08 Dec 2021 08:33:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musO5-0000zC-5S; Wed, 08 Dec 2021 08:33:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musO4-0003QP-S4; Wed, 08 Dec 2021 08:33:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1musO4-0000zO-Qt; Wed, 08 Dec 2021 08:33:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ughS9xkTeS8xLcGnDCJqmBPYQH93LjfXVHffnYEL21k=; b=3EfEIYjLiWTsrewNTVQSaf2Ii+
	T1TyUO01m1rN6zN5VIrbQhb3/h8AJdfAfTYX4eheuIBtZmwgc8iHxPkngAOJ67ATU7bfsLcMmn35I
	28wRQNoFHwkiocYzHA1mpu4U1VaC+GrAdjirYxscaLa4vm9BGy9LgPHGgf5e0aN2bONE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167226-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167226: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4cc91f26d05496ff2b09038d648f0249c3154193
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 08:33:16 +0000

flight 167226 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167226/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4cc91f26d05496ff2b09038d648f0249c3154193
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  516 days
Failing since        151818  2020-07-11 04:18:52 Z  515 days  497 attempts
Testing same since   167226  2021-12-08 04:46:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 87056 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 08:42:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 08:42:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242072.418722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1musX4-0000J1-Qp; Wed, 08 Dec 2021 08:42:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242072.418722; Wed, 08 Dec 2021 08:42:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1musX4-0000Iu-Np; Wed, 08 Dec 2021 08:42:34 +0000
Received: by outflank-mailman (input) for mailman id 242072;
 Wed, 08 Dec 2021 08:42:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musX3-0000Ik-Jx; Wed, 08 Dec 2021 08:42:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musX3-00019D-Cp; Wed, 08 Dec 2021 08:42:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1musX2-0003oN-Iz; Wed, 08 Dec 2021 08:42:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1musX2-000681-IV; Wed, 08 Dec 2021 08:42:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W5Gv22lpteJhmF8Fk/ewlsVCUwYPbR9GScnlHmN7BTA=; b=aIPTfPFcZ7YH703cLJyPhG8wot
	KCpw5OWDK1/2zAWkL/t3nI0Oeh4oInHcJZeapXqTGqKmzg+Hcxj5+IPdAKWBM28tNWlkl2iNqOQyc
	wO8xxbGViFf4DfjiW608G3P2ITAe/V7AiYjbsmKBZGsKawCr/s687KKQ1Wp+5kf23ZHM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167225-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167225: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7c0ad2c33810ead45b7919f8f8d0e282dae52e71
X-Osstest-Versions-That:
    ovmf=dfafa8e45382939fb5dc78e9d37b97b500a43613
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 08:42:32 +0000

flight 167225 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167225/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7c0ad2c33810ead45b7919f8f8d0e282dae52e71
baseline version:
 ovmf                 dfafa8e45382939fb5dc78e9d37b97b500a43613

Last test of basis   167122  2021-12-04 23:14:58 Z    3 days
Testing same since   167225  2021-12-07 17:43:21 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   dfafa8e453..7c0ad2c338  7c0ad2c33810ead45b7919f8f8d0e282dae52e71 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 08:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 08:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242081.418741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscA-0001Nu-Oo; Wed, 08 Dec 2021 08:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242081.418741; Wed, 08 Dec 2021 08:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscA-0001N7-JB; Wed, 08 Dec 2021 08:47:50 +0000
Received: by outflank-mailman (input) for mailman id 242081;
 Wed, 08 Dec 2021 08:47:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1musc9-0001K2-M0
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 08:47:49 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 851f2b1c-5803-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 09:47:48 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 418F21FD3E;
 Wed,  8 Dec 2021 08:47:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 122CE13BE9;
 Wed,  8 Dec 2021 08:47:48 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UKkcAzRxsGGzdQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 08:47:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 851f2b1c-5803-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638953268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=S6awGi2Fwbno8QaG6NAZfKYFH8aFqnE5sERtOBDmAbA=;
	b=hxJ9yWCE8Yc8x0BugzwO/+upHnZi4yk5OAzREbFkbpMlrE0oIUc6OjwJgD50qbcBzzl8Ii
	kGl8pifEYkWN8NhaTuDtI1ifXedaRLoBouf3P5chq1HOWTBnzeWP+z+0T+lOqKh9SvDMSd
	0c/5LiOYGfgzKIX/ypcnA8XQGk9i3LA=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 2/2] tools: set event channel HVM parameters in libxenguest
Date: Wed,  8 Dec 2021 09:47:45 +0100
Message-Id: <20211208084745.31082-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208084745.31082-1-jgross@suse.com>
References: <20211208084745.31082-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The HVM parameters for pre-allocated event channels should be set in
libxenguest, like it is done for PV guests and for the pre-allocated
ring pages.

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V3:
- replacement for former patch 2 (Andrew Cooper)
---
 tools/libs/guest/xg_dom_x86.c |  6 ++++++
 tools/libs/light/libxl_dom.c  | 15 ++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/tools/libs/guest/xg_dom_x86.c b/tools/libs/guest/xg_dom_x86.c
index b6e75afba2..9328fbf804 100644
--- a/tools/libs/guest/xg_dom_x86.c
+++ b/tools/libs/guest/xg_dom_x86.c
@@ -1866,6 +1866,12 @@ static int bootlate_hvm(struct xc_dom_image *dom)
         munmap(hvm_info_page, PAGE_SIZE);
     }
 
+    if ( xc_hvm_param_set(xch, domid, HVM_PARAM_CONSOLE_EVTCHN,
+                          dom->console_evtchn) ||
+         xc_hvm_param_set(xch, domid, HVM_PARAM_STORE_EVTCHN,
+                          dom->xenstore_evtchn) )
+        return -1;
+
     return 0;
 }
 
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index fe9f760f71..c9c24666cd 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -723,9 +723,8 @@ out:
 
 static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
                                 libxl_domain_build_info *info,
-                                int store_evtchn, unsigned long *store_mfn,
-                                int console_evtchn, unsigned long *console_mfn,
-                                domid_t store_domid, domid_t console_domid)
+                                unsigned long *store_mfn,
+                                unsigned long *console_mfn)
 {
     struct hvm_info_table *va_hvm;
     uint8_t *va_map, sum;
@@ -752,8 +751,6 @@ static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
 
     xc_hvm_param_get(handle, domid, HVM_PARAM_STORE_PFN, &str_mfn);
     xc_hvm_param_get(handle, domid, HVM_PARAM_CONSOLE_PFN, &cons_mfn);
-    xc_hvm_param_set(handle, domid, HVM_PARAM_STORE_EVTCHN, store_evtchn);
-    xc_hvm_param_set(handle, domid, HVM_PARAM_CONSOLE_EVTCHN, console_evtchn);
 
     *store_mfn = str_mfn;
     *console_mfn = cons_mfn;
@@ -1123,7 +1120,9 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid,
     dom->vga_hole_size = device_model ? LIBXL_VGA_HOLE_SIZE : 0;
     dom->device_model = device_model;
     dom->max_vcpus = info->max_vcpus;
+    dom->console_evtchn = state->console_port;
     dom->console_domid = state->console_domid;
+    dom->xenstore_evtchn = state->store_port;
     dom->xenstore_domid = state->store_domid;
 
     rc = libxl__domain_device_construct_rdm(gc, d_config,
@@ -1169,10 +1168,8 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid,
     if (rc != 0)
         goto out;
 
-    rc = hvm_build_set_params(ctx->xch, domid, info, state->store_port,
-                               &state->store_mfn, state->console_port,
-                               &state->console_mfn, state->store_domid,
-                               state->console_domid);
+    rc = hvm_build_set_params(ctx->xch, domid, info, &state->store_mfn,
+                              &state->console_mfn);
     if (rc != 0) {
         LOG(ERROR, "hvm build set params failed");
         goto out;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 08:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 08:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242080.418736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscA-0001KO-F8; Wed, 08 Dec 2021 08:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242080.418736; Wed, 08 Dec 2021 08:47:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscA-0001KH-Ar; Wed, 08 Dec 2021 08:47:50 +0000
Received: by outflank-mailman (input) for mailman id 242080;
 Wed, 08 Dec 2021 08:47:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1musc9-0001K1-E8
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 08:47:49 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 84fb7f72-5803-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 09:47:48 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D7BEF2190C;
 Wed,  8 Dec 2021 08:47:47 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C5BF13BE9;
 Wed,  8 Dec 2021 08:47:47 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zopjJDNxsGGzdQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 08:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84fb7f72-5803-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638953267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=nONTjQtEDZwEnfXvIv2PD1YRqDCnal2EIeR8/qddBCw=;
	b=Uc02aJvS7O4M8f4iGChtJKVL8L5pSWzLaH1hf9FRvV0wEEgwSLKckAtbLD7zR3kKew6Kl7
	FAeaAHUMSiXBe3saskqjrw/0DDUWeDZYIdIV7ufg5KnFxb4+HupFCi6g+cH/LfkNtbIYcB
	ebDNwFiV8RCz+svdfBS1iO8OloRoHwo=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH v3 0/2] tools/helpers: PVH xenstore-stubdom console fixes
Date: Wed,  8 Dec 2021 09:47:43 +0100
Message-Id: <20211208084745.31082-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The console parameters for a PVH Xenstore-stubdom have been missing
or were just wrong.

Juergen Gross (2):
  tools/helpers: fix PVH xenstore-stubdom console parameters
  tools: set event channel HVM parameters in libxenguest

 tools/helpers/init-xenstore-domain.c |  8 +++++---
 tools/libs/guest/xg_dom_x86.c        |  6 ++++++
 tools/libs/light/libxl_dom.c         | 15 ++++++---------
 3 files changed, 17 insertions(+), 12 deletions(-)

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 08:47:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 08:47:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242082.418758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscC-0001q9-1X; Wed, 08 Dec 2021 08:47:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242082.418758; Wed, 08 Dec 2021 08:47:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muscB-0001po-TU; Wed, 08 Dec 2021 08:47:51 +0000
Received: by outflank-mailman (input) for mailman id 242082;
 Wed, 08 Dec 2021 08:47:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muscA-0001K1-7I
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 08:47:50 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8503115e-5803-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 09:47:48 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 0B6352191A;
 Wed,  8 Dec 2021 08:47:48 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D68F813F3B;
 Wed,  8 Dec 2021 08:47:47 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id AOoeMzNxsGGzdQAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 08:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8503115e-5803-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638953268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nT3PojRsjaFLQH8p/xAS/Bo0Edytu7k5yswmTd3p+WU=;
	b=UvBlVWL1x0/G7DJ4GahBrQIUwzTNp7P6vYBL61uj9csWpmzLvAgjU6q1K2PEqq5F7jKpjk
	oeSQqU35zbMmC3i4UhtxsDczk7qjozkgZIJyVfe9Ts6ej+AACj+iJiD6W7ODW0+jds/IH5
	g7UcKdnXiarpssq735mbcS1rfVXJW/Y=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v3 1/2] tools/helpers: fix PVH xenstore-stubdom console parameters
Date: Wed,  8 Dec 2021 09:47:44 +0100
Message-Id: <20211208084745.31082-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208084745.31082-1-jgross@suse.com>
References: <20211208084745.31082-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When using a PVH mode xenstore-stubdom the frame number of the console
should be a PFN instead of a MFN.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
V2:
- rename variable (Andrew Cooper)
---
 tools/helpers/init-xenstore-domain.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c
index b205a79ee6..9457d0251b 100644
--- a/tools/helpers/init-xenstore-domain.c
+++ b/tools/helpers/init-xenstore-domain.c
@@ -30,7 +30,7 @@ static char *param;
 static char *name = "Xenstore";
 static int memory;
 static int maxmem;
-static xen_pfn_t console_mfn;
+static xen_pfn_t console_gfn;
 static xc_evtchn_port_or_error_t console_evtchn;
 
 static struct option options[] = {
@@ -283,7 +283,9 @@ static int build(xc_interface *xch)
     }
 
     rv = 0;
-    console_mfn = xc_dom_p2m(dom, dom->console_pfn);
+    console_gfn = (dom->container_type == XC_DOM_PV_CONTAINER)
+                  ? xc_dom_p2m(dom, dom->console_pfn)
+                  : dom->console_pfn;
 
 err:
     if ( dom )
@@ -528,7 +530,7 @@ int main(int argc, char** argv)
     do_xs_write_dir_node(xsh, fe_path, "tty", "");
     snprintf(buf, 16, "%d", console_evtchn);
     do_xs_write_dir_node(xsh, fe_path, "port", buf);
-    snprintf(buf, 16, "%ld", console_mfn);
+    snprintf(buf, 16, "%ld", console_gfn);
     do_xs_write_dir_node(xsh, fe_path, "ring-ref", buf);
     xs_close(xsh);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 09:56:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 09:56:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242104.418769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mutfy-0002pn-9R; Wed, 08 Dec 2021 09:55:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242104.418769; Wed, 08 Dec 2021 09:55:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mutfy-0002pg-6L; Wed, 08 Dec 2021 09:55:50 +0000
Received: by outflank-mailman (input) for mailman id 242104;
 Wed, 08 Dec 2021 09:55:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mutfx-0002pa-CR
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 09:55:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mutft-0002KR-LI; Wed, 08 Dec 2021 09:55:45 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mutft-0006lm-F6; Wed, 08 Dec 2021 09:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oVcnsqiknoJr2KCk247C8Qv8DBhB7s98VvYWxkyS/Yo=; b=MLhoqLszMDNZWkmOcVDHeOf3Gi
	Y/G01dg+JnAs1EsEVAaJBcP22e3D+rgiX23RR4T7vZzQag9aSFd9j97IRpuX3F99nkSoZub1qxq5m
	tjgUoyEG7biUpI82Zc9io232FQwAKKEUAP0A9ANczJ6ChVyW8RQtDYEc/1BcqO/MEFGA=;
Message-ID: <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
Date: Wed, 8 Dec 2021 09:55:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/12/2021 07:20, Jan Beulich wrote:
> On 07.12.2021 20:11, Julien Grall wrote:
>>
>>
>> On 07/12/2021 08:37, Michal Orzel wrote:
>>> Hi Julien,
>>
>> Hi,
>>
>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>> to hypervisor when switching to AArch32 state.
>>>>>
>>> I will change to "from AArch32 state".
>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>> architectural register held before any AArch32 execution.
>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>
>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>
>>> Ok.
>>>>>
>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>> needs to be fixed.
>>>>
>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>
>>> I would say:
>>> "
>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>> if the command passed as the first argument was clobbered,
>>> "
>>>>>
>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>
>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>> when not passed.
>>>>
>>>> Which error do you see otherwise? Is it a compilation error?
>>>>
>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>> So basically in all the places where entry is called with hyp=1.
>>> When taking the current patch and removing default value for compat you will get:
>>> ```
>>> entry.S:254: Error: ".endif" without ".if"
>>> entry.S:258: Error: symbol `.if' is already defined
>>> entry.S:258: Error: ".endif" without ".if"
>>> entry.S:262: Error: symbol `.if' is already defined
>>> entry.S:262: Error: ".endif" without ".if"
>>> entry.S:266: Error: symbol `.if' is already defined
>>> entry.S:266: Error: ".endif" without ".if"
>>> entry.S:278: Error: symbol `.if' is already defined
>>> entry.S:278: Error: ".endif" without ".if"
>>> entry.S:292: Error: symbol `.if' is already defined
>>> entry.S:292: Error: ".endif" without ".if"
>>> entry.S:317: Error: symbol `.if' is already defined
>>> entry.S:317: Error: ".endif" without ".if"
>>> ```
>>
>> Thanks for input. I am concerned with your suggested approach (or using
>> .if 0\compat as suggested by Jan) because they allow the caller to not
>> properly specify compat when hyp=0. The risk here is we may generate the
>> wrong entry.
>>
>> compat should need to be specified when hyp=1 as we will always run in
>> aarch64 mode. So could we protect this code with hyp=0?
> 
> Since my suggestion was only to avoid the need for specifying a default
> for the parameter (which you didn't seem to be happy about), it would
> then merely extend to
> 
> .if !0\hyp && 0\compat
Isn't it effectively the same as setting a default value?

The reason we seem to get away is because other part of the macro (e.g. 
entry_guest) will need compat to be valid.

But that seems pretty fragile to me. So I would prefer if the new code 
it added within a macro that is only called when hyp==0.

Cheers,

> 
> or something along those lines.
> 
> Jan
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 10:18:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 10:18:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242111.418780 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muu1o-0006Ln-3c; Wed, 08 Dec 2021 10:18:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242111.418780; Wed, 08 Dec 2021 10:18:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muu1n-0006Lg-Vy; Wed, 08 Dec 2021 10:18:23 +0000
Received: by outflank-mailman (input) for mailman id 242111;
 Wed, 08 Dec 2021 10:18:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xuKF=QZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muu1m-0006La-DX
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 10:18:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ae5c47a-5810-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 11:18:21 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-sN2a-SSvMcS_lnweOh-dUA-1; Wed, 08 Dec 2021 11:18:18 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3776.eurprd04.prod.outlook.com (2603:10a6:803:18::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 10:18:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Wed, 8 Dec 2021
 10:18:16 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM7PR02CA0025.eurprd02.prod.outlook.com (2603:10a6:20b:100::35) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14 via Frontend
 Transport; Wed, 8 Dec 2021 10:18:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ae5c47a-5810-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638958700;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Tzi2JpuMSxuilbQc59XDOI02SjQUNWltt/xmhd8YoXc=;
	b=KirQ34leMLE+oYN2IBeQjUMdg1zAF/ynhnz8FmFyRwLkQI8xM2xLgEcp4iRG05YtNgNBSr
	iCvcPCuQ2RmrZTilGOAKishBjgo3/fbqpgdRarJxQ3KNIJi1JGvBp8s4pxlX1SiNSft3vV
	tBeZJbwdCliIYD/os2BmVbAzdfC2NKU=
X-MC-Unique: sN2a-SSvMcS_lnweOh-dUA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XGAntn+QVsxROEh9cl/vJtNSeTjrIyXfZoxbE2HxdU4Y18spU8X3iSkF0Y7AOR88PjKKsQg/vakZNn8q+1x28Vq1vMcDI7U0My3EV46ZTKIJs2vRN2rGEOXC+YlYc+50l2hISToCY/HIDmmNGoXgjPJINajTw7AnpWzWciyHQ4B6e0Rsktqcw8tx3mX5N+TLoBZT85CDHe27cHcv3ZjBToQuUsuSAyyyqv4o4ZPe5XldmZImdT001P89jUStu22pYLJVqbZDu4TkARMRmQMrvl0n5i9mx9mCZc0u/5SqLNTWHiPtIrUTxeIvJYolKvabSQ/tZ2ljEEvglkspdIvsIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Tzi2JpuMSxuilbQc59XDOI02SjQUNWltt/xmhd8YoXc=;
 b=XWqZWuWy1uHLvLCTQvG8G7j+irPhqeGRJukN1WzW9B9+JXzppEgEYdJDesup00HdC2WNP8LpOBbY+Mmx1jkG6bDCksQH2W1TLjAVZgowK3tPFY+wH+WkxpurO1ssvKFQfxPgQ5a+t8UkTw7EYK0S1SA9FT6nzokWmM2K+hLKKFNUore37QTEnCqRpnEREv6+YeWlEVvNV8uEh+rdgX15dqyCvU3pJUbfacc+lG9YHBNjbyl+8sHDgz/Bn4RFZY21JxxgFbwM6Q5cHHzw+tXlgaSE6FsHZDIL+Kms0OEadqBCrip+c15egPycaQri8A95ktpC3gzfOOUWu9b3QFe4Jw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c39427aa-1f72-a0dd-0756-5670b5a8e997@suse.com>
Date: Wed, 8 Dec 2021 11:18:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Michal Orzel <michal.orzel@arm.com>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0025.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 52366092-f735-4e9a-1874-08d9ba340c9f
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3776:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37766625BDFE965BE64FA428B36F9@VI1PR0402MB3776.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GEikfZBC1FXbEnHvFvkSuZtz9n96OxgcRShwq8yvlhOZqDL/aKe5vf8zpx9rRMoTaEfgfTaBKNvn426iEbQYFXfa7O/Yo94H+69K5cV6EIU+3t9ZnsOhD5R5rY8/sfjb0dYOrtgCGqCXLeKNt3HfH6xtLzQgH/hHhACV7fmeFulbswzYuJEJUJq8y5IOaTKVfKuuUaWZipjJUevc9NrsMAZRI4Eo+US1SBo8w2wA4VjhuLkgUcmN2FRgm4bjBUxDVroiR7hrPSx1aBh5iQ7ONRbvS5PC8ZgPLaoIzdWAAp10RlxdKBHC2VWgbZQeRL0K62cvRkSJVL4inteWt7rw//ek/XrAyUtIgR30aCo4LkvEv8xd9t+mj+D21tD5w8+hSb9QCO5L8C9JoF3wYqr543ziBcohka1VHh8NAcqo/4wDf27KRGlRR60HegcPXnfO8EWrqdjXG180uxUqLL/cpf/+E68+eE5ydUUgIjebQvO8YyAzH33nCxE7xezoY0R/CQN4jenp6pWzEbBtyf0xM3pY7VzBrML3S2jlSGtQa5qk2vA0rRiGz7pRZcOIbnnAS8sWnNiRpxJB37SmPl0/4JW3/+0BatQmXAwFUHSgeDaheJXMCzczvAuh1jC6wvAnv/6NBgsBxrAHz3y6cpMoEBuS2P+G7YtMWuukO0pPRo4MgBVSxxr4OLf3f4hxKr7yCG1jOK28Widgp4DD7tGGkEkB1BouGjJfKC0CSxmKZu8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(83380400001)(38100700002)(36756003)(8676002)(4326008)(6486002)(508600001)(956004)(2616005)(6916009)(8936002)(53546011)(31686004)(54906003)(66476007)(5660300002)(66556008)(26005)(316002)(31696002)(186003)(66946007)(16576012)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTZlczZtcXovQU43d2NZTzFFMmZVS0Q3bEFSenZpR2YrZ01UaFVLQ0MyNFNR?=
 =?utf-8?B?QVNhaUNzdnBwcHdTeTlENXc2QTZTODUrNkhKWnNHOFNtUmlVVlhyQUhjTG41?=
 =?utf-8?B?djZ3VS9OSFNqajNRUG5qNWFXRVRGU2JhVGVMd1pCNVRNNXl3YTk5STY3cGpz?=
 =?utf-8?B?dDd3a2FKckFWQU1oQWpneitscHBhcXdnSEwvendRYUFEOGdibEdSdko2T0dU?=
 =?utf-8?B?UkNtbXdESmNxMjMwR1Myb2xKM0dPYjBPYndjd3dGN1VLYXZiWC9sdWZNeGR6?=
 =?utf-8?B?OHl3ODIrdktmQ3VKbVYrNURhM09jRER6NmpxSVF3eWRJV0Zqdys3NFA2T1lx?=
 =?utf-8?B?Wjl2ZUFWS3hDeTM0VWFXMDN2S0l4K2Z0TjVsS1RXMGhKRVpCS3hpeUVhVXBG?=
 =?utf-8?B?Nnc5WjhjbEhuY0Vkby9BVEZRN0c5azg5d2x5akVSK1lMV2pPVHhvbzFkSUlP?=
 =?utf-8?B?MDdJb0Zhd2hLcEh3Q3NkUlVTdk5MUkU1RjZmMm1ZckhkTFhUaGV4aUthY3Bm?=
 =?utf-8?B?TEs3R3FUQU9JdzZncTdZTUZGaXZQSXNFanJ2MXEzWjhlb1BTcm1tVmk4a2RX?=
 =?utf-8?B?bjRsNlp1TEtNYlpOdVBKMDRLdkNhQTE4cExzbmxQNUtIZStDRVF4NUlyRzBy?=
 =?utf-8?B?Y0JnZENQRDkwR1ZITnl6b1dNbStETWJTN0hoTjFhWGFCcU55dlRGK0VObyt2?=
 =?utf-8?B?WTEzL0JKTkpjVE90SFNqalczcHpPek53cnJvU2JtVzJ3Z0dwMENNbkUzQkRB?=
 =?utf-8?B?MW5ES0RRWVN2RW9Hb20rZzVCWXQ3QXdnWExqcTdIemFQNzZid0xZaVJLT1JZ?=
 =?utf-8?B?dHNUM0tYanhsVVU2MzRSbG1PZGpRUlNXZS92Y1FScUl0cksxczVka0pLQ09V?=
 =?utf-8?B?RmtRUU9BZ1ZvQnY2NDdCdkRaMnpZbU9PcERwbXhvOFdZcXVxdzJhZ253SjR3?=
 =?utf-8?B?MzY4cCs3ZW1hbE9XOGJpbWZ2a0pMVWFWWUYzZkkzSXVSb3ZKV3MyS0JVK0t5?=
 =?utf-8?B?YzBhMzhmTTh5U1phZmVkM0E1aCtZeU12b3NFaEMwU1pqU09Vbmdsa3dSZDZZ?=
 =?utf-8?B?QWduV3Q2UVRJdEJ5UnJaTitlTVQ2VjVYdnNYSkd1ZWhVM3BaVXRVMnlwQUp6?=
 =?utf-8?B?S2M1eHZVQ2tuaWpybGk4U3A0N09TY3M4d25XOUVSeE03Y2oxY3VtOG5hMDRl?=
 =?utf-8?B?NTg1cUJsdFhCN1NBbExjVDJ0WFY5QTlNTngrSlY3QUZhV2hUdHdEQk9MbWFz?=
 =?utf-8?B?YXBDVHA4ZVo3U3c5Y294K3VrSWV2V0JWWHorMEZFa3V6aTJGMDEvMDVNSkxI?=
 =?utf-8?B?RzB3aElXcVN5ZVZRdk9FT0E1dnRTMVZRL0E2SEFSRXZXa0pHaDRmNGQxT1N2?=
 =?utf-8?B?Si8xQXhEMjNUQXV1V3hGLzFIbHJ4ejJ5cUFtZXdtOXRGd1BIb2NhdFh6ZkVN?=
 =?utf-8?B?a2hkU3A5RERMSWJoZFhYbUhWSTVQZGJBdjI4ejk3UUp0ZERKelpVY2pJRWg4?=
 =?utf-8?B?bHl5eFk4UlVFZ3dRQU5MSFl3QWVxeGRHUmhSLzU2QXdTaGNqSkpFWGhiZWht?=
 =?utf-8?B?b3VRcnNENEI2UmtXcDZ5SW0zY1NaZnRTSG56alJwUXdteGdDWEJlQnRFbWZu?=
 =?utf-8?B?QkdFdyt3cngxNTZZcU5xbzkrR0FmYzlua3doMHBhUWFpK0RJQVhINzZ1RG5V?=
 =?utf-8?B?cExZVTBhc3JkSGFBWVdCeUlTSVg3VjloREFFSEJoczM3ZDRjRUVKZ01USU1n?=
 =?utf-8?B?N0lNUU1wRGo2c0w1RUJWZDJkMUx3WlY0SGNxeVlxcXFKeThmUXRxSjMxZ2pl?=
 =?utf-8?B?aURTQXdFUjl0ZkhIS1JjMGhyM3FHcXZkQ3M4cGNrQnE5cFRTMDdRNHg4cWYy?=
 =?utf-8?B?bFVXQTJKTmJGRDd3UElIOHJ2cEdKdEdkZGVKOHpNUEdaUlJuVkNhd0ZqWG1o?=
 =?utf-8?B?cUI3L0pJSkxIa3g4VFlRMWRwSCtpU3VVUUhjVU9DOEg4K2FWUmtCRll0Wnor?=
 =?utf-8?B?WnlaR21JNFE5dTdRQVpxb2NVdVdiaWtCVjYxY2o3TnVHRm5JYVAveVJrRjRr?=
 =?utf-8?B?K2xsYkFkY1o4MS9qMU9zV2lNQWx3QWNUbjI1b3BndkIwUTA0ZmRFcWFGekp1?=
 =?utf-8?B?WFhvbXdBN0JsR25MTVJyRDhVYjRTVTRuZXIxTXZnbTJDcURuYlMzVm5lYStL?=
 =?utf-8?Q?o+Kj3Mb76EPFSduo775F6xo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52366092-f735-4e9a-1874-08d9ba340c9f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 10:18:16.4753
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jOMiT7yLJnOumI3JVjNMYk7fSS1rrtJZpIFY/Noen/5x+btnKV4832Moh3o9wsKFgfVqw+iQGcPvhNChSdc2jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3776

On 08.12.2021 10:55, Julien Grall wrote:
> Hi,
> 
> On 08/12/2021 07:20, Jan Beulich wrote:
>> On 07.12.2021 20:11, Julien Grall wrote:
>>>
>>>
>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>> Hi Julien,
>>>
>>> Hi,
>>>
>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>
>>>> I will change to "from AArch32 state".
>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>> architectural register held before any AArch32 execution.
>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>
>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>
>>>> Ok.
>>>>>>
>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>> needs to be fixed.
>>>>>
>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>
>>>> I would say:
>>>> "
>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>> if the command passed as the first argument was clobbered,
>>>> "
>>>>>>
>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>
>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>> when not passed.
>>>>>
>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>
>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>> So basically in all the places where entry is called with hyp=1.
>>>> When taking the current patch and removing default value for compat you will get:
>>>> ```
>>>> entry.S:254: Error: ".endif" without ".if"
>>>> entry.S:258: Error: symbol `.if' is already defined
>>>> entry.S:258: Error: ".endif" without ".if"
>>>> entry.S:262: Error: symbol `.if' is already defined
>>>> entry.S:262: Error: ".endif" without ".if"
>>>> entry.S:266: Error: symbol `.if' is already defined
>>>> entry.S:266: Error: ".endif" without ".if"
>>>> entry.S:278: Error: symbol `.if' is already defined
>>>> entry.S:278: Error: ".endif" without ".if"
>>>> entry.S:292: Error: symbol `.if' is already defined
>>>> entry.S:292: Error: ".endif" without ".if"
>>>> entry.S:317: Error: symbol `.if' is already defined
>>>> entry.S:317: Error: ".endif" without ".if"
>>>> ```
>>>
>>> Thanks for input. I am concerned with your suggested approach (or using
>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>> properly specify compat when hyp=0. The risk here is we may generate the
>>> wrong entry.
>>>
>>> compat should need to be specified when hyp=1 as we will always run in
>>> aarch64 mode. So could we protect this code with hyp=0?
>>
>> Since my suggestion was only to avoid the need for specifying a default
>> for the parameter (which you didn't seem to be happy about), it would
>> then merely extend to
>>
>> .if !0\hyp && 0\compat
> Isn't it effectively the same as setting a default value?

Hmm, yes, it is.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 10:27:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 10:27:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242120.418791 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuAj-0008D1-5G; Wed, 08 Dec 2021 10:27:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242120.418791; Wed, 08 Dec 2021 10:27:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuAj-0008Cu-1I; Wed, 08 Dec 2021 10:27:37 +0000
Received: by outflank-mailman (input) for mailman id 242120;
 Wed, 08 Dec 2021 10:27:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Njo=QZ=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muuAh-0008Cn-LW
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 10:27:35 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 73620e39-5811-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 11:27:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 73620e39-5811-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638959253;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=X/Ex4ED97g+7rU6xAg+N3XAsw9+w8e2m3q43uKD/p7Y=;
  b=UgWvpCOIyksDk7uFltypd4B5XbCHmx5I8JHkAhPtXbuOv013hboycD+Q
   T6s4ox2ukDWzyPEFNPM+0HQ/FdW81OjZ+IXGt3wW8WzN/+PQdnIqzl7lo
   a51Kd2ENHwj+T2/vE5dQAeV0OsabCoMHkTvjnXB2oujhKc9VGLOoEEGDb
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: nYgjo5KYdaHSfwgU8/CxuLfz9384nJItdEBIV/X1diqq/sGa4ZYGusOPspkcJAmSdm1XI8U+oR
 Xl/8yRMBOrAlbT8Os2fIxIWZRILRuUic7SxZfqUsE8/cG2BB+VwGiiMerThyGhzBOiO+kYpSV5
 RAVRV4WHeqRMPoReeHJ+nQWBGBfbZe6ZfnXT5miDmNz+20S30rxrHZgulJJ+Je21Lr65Q4A/qn
 /oiZawLCNs7ET4a8CvtiU7nd9DvI00165sQo5CmUZBEjxk5k1jRtIC/jekBbYJE+cxzDgxADlT
 4YW3n+MzN3Ji181E3O6bW8WH
X-SBRS: None
X-MesageID: 59924594
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2uKBOK98zrAj8fcPTg12DrUDiX6TJUtcMsCJ2f8bNWPcYEJGY0x3x
 mFJXTqHaauMNGD1ftogOori9R4OsJ7Uy4QxHQc9/yg8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhGmeIdA970Ug6wrRh0tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhDk
 tsQjt+AFj4PO5Lsgvo0UwBoNxtXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp0fTKyCO
 ptFAdZpRE/dexNXNgk3MpIdrPiC2CjFXGx99mvA8MLb5ECWlmSdyoPFMcXXUsyHQ91PmUSVr
 X6A+H72ajkFMPSPxDzD9Wij7sfNkjn8Q5k6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfo3jt1z1MsFlZpAOHKfudtLdDz/
 lPWzd7vGxJ1t7iZFSCU+ruO9GvgMikJN24SIyQDSFJdsdXkpYgyiDPJT8piT/Hp3oGkR2moz
 mDYtjU6ipUSkdUPi/ex82fYjm/+vZPOVAM0uFnaBzr38gNjaYe5TIW08lyHv+1YJYOUQwDZ7
 ngJksST9s4UCpSJmHDfSekBBujxtf2ELCfdkRhkGJx4r2ah/HuqfIZx5jBiJRg2bpZYKGGxO
 EKK4FFf/p5eOneufJRbWYPpBpR417XkGPTkSuvQMohEbK9ueVLV5yppf0ORgTzgyRB+jaElN
 J6HWs+wFnJGW79/xT+7SupBg78mwicymTHaSZzhlkn11LOfYDieSKsfMUvIZec8tfvWrALQ+
 tdZFs2L1xQAD7GuPniJqdYefQIQMHw2JZHqsMgGJOeMLz1vFHwlF/KMk6gqfJZonvgNm+rFl
 p1ntpS0FLYraaX7FDi3
IronPort-HdrOrdr: A9a23:XKi6p6myWxsS5V6WJIR+yhY+xOfpDfIu3DAbv31ZSRFFG/Fxl6
 iV/cjz8SWE7wr5OUtQ/exoV5PtfZqxz/FICMwqTNGftWrdyQ6VxeNZnOjfKlTbckWUnINgPO
 VbAspD4bXLfCFHZK3BgDVQfexP/OW6
X-IronPort-AV: E=Sophos;i="5.87,297,1631592000"; 
   d="scan'208";a="59924594"
Date: Wed, 8 Dec 2021 10:27:18 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Ian Jackson <iwj@xenproject.org>, "Wei
 Liu" <wl@xen.org>
Subject: Re: [PATCH] tools/libs/light: set video_mem for PVH guests
Message-ID: <YbCIhtVieJhncfm7@perard>
References: <20211203073058.10980-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211203073058.10980-1-jgross@suse.com>

On Fri, Dec 03, 2021 at 08:30:58AM +0100, Juergen Gross wrote:
> The size of the video memory of PVH guests should be set to 0 in case
> no value has been specified.
> 
> Doing not so will leave it to be -1, resulting in an additional 1 kB
> of RAM being advertised in the memory map (here the output of a PVH
> Mini-OS boot with 16 MB of RAM assigned):
> 
> Memory map:
> 000000000000-0000010003ff: RAM
> 0000feff8000-0000feffffff: Reserved
> 0000fc008000-0000fc00803f: ACPI
> 0000fc000000-0000fc000fff: ACPI
> 0000fc001000-0000fc007fff: ACPI
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 10:28:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 10:28:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242124.418802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuBF-0000FP-E1; Wed, 08 Dec 2021 10:28:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242124.418802; Wed, 08 Dec 2021 10:28:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuBF-0000EL-9c; Wed, 08 Dec 2021 10:28:09 +0000
Received: by outflank-mailman (input) for mailman id 242124;
 Wed, 08 Dec 2021 10:28:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muuBD-0000Dy-Dk; Wed, 08 Dec 2021 10:28:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muuBD-0002xf-9Y; Wed, 08 Dec 2021 10:28:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muuBD-0000tz-1T; Wed, 08 Dec 2021 10:28:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muuBD-0002kU-0z; Wed, 08 Dec 2021 10:28:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=R67uDXZUbeGgS7NGWPzc/zK7yLZyrlKhhkULImYvaVk=; b=VP5PdiChbGTD9QBNL/nPXJHls2
	XonsTR4C+E0/qX1Uvoa+0o4OYxbRDPTZL6S8Acpk+++qhaWO9T70/wHNoFiFNftGkawhLBdXypoJN
	/iYsgLPd80suUl0SBB1N9lALBAhw98Vip/w4YOoFhOMLbjNPU+EgSTCra3e6N6aUNGns=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167232-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167232: all pass - PUSHED
X-Osstest-Versions-This:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
X-Osstest-Versions-That:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 10:28:07 +0000

flight 167232 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167232/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1
baseline version:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01

Last test of basis   167144  2021-12-05 09:18:27 Z    3 days
Testing same since   167232  2021-12-08 09:18:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ian Jackson <ian.jackson@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Tim Deegan <tim@xen.org>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ea0c08bc77..608531a0cc  608531a0cc34a5bc096ccf585e16f182b5ed83e1 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 10:45:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 10:45:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242135.418816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuRK-00030t-Rx; Wed, 08 Dec 2021 10:44:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242135.418816; Wed, 08 Dec 2021 10:44:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuRK-00030m-ON; Wed, 08 Dec 2021 10:44:46 +0000
Received: by outflank-mailman (input) for mailman id 242135;
 Wed, 08 Dec 2021 10:44:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=f9Z0=QZ=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1muuRK-00030c-2m
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 10:44:46 +0000
Received: from smtpout1.mo529.mail-out.ovh.net
 (smtpout1.mo529.mail-out.ovh.net [178.32.125.2])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db1a4ddf-5813-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 11:44:44 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.109.156.35])
 by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 4A0F4D092F09;
 Wed,  8 Dec 2021 11:44:42 +0100 (CET)
Received: from kaod.org (37.59.142.96) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 8 Dec
 2021 11:44:40 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db1a4ddf-5813-11ec-a831-37629979565c
Authentication-Results: garm.ovh; auth=pass (GARM-96R001f5056120-68a4-4c0a-bc06-f617410d6d7e,
                    EB01F339838E5AA67C986A6C3251B49097B81903) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 86.201.172.254
Message-ID: <e92f2bb3-b5e1-c870-8151-3917a789a640@kaod.org>
Date: Wed, 8 Dec 2021 11:44:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V2 01/23] powerpc/4xx: Remove MSI support which never
 worked
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, Michael Ellerman
	<mpe@ellerman.id.au>, LKML <linux-kernel@vger.kernel.org>
CC: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
	<ashok.raj@intel.com>, <linux-pci@vger.kernel.org>, Paul Mackerras
	<paulus@samba.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	<linuxppc-dev@lists.ozlabs.org>, Juergen Gross <jgross@suse.com>, Thomas
 Bogendoerfer <tsbogend@alpha.franken.de>, <linux-mips@vger.kernel.org>, Kalle
 Valo <kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<sparclinux@vger.kernel.org>, <x86@kernel.org>,
	<xen-devel@lists.xenproject.org>, <ath11k@lists.infradead.org>, Wei Liu
	<wei.liu@kernel.org>, <linux-hyperv@vger.kernel.org>, Christian Borntraeger
	<borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210223.872249537@linutronix.de>
 <8d1e9d2b-fbe9-2e15-6df6-03028902791a@kaod.org>
 <87ilw0odel.fsf@mpe.ellerman.id.au>
 <27f22e0e-8f84-a6d7-704b-d9eddc642d74@kaod.org> <8735n42lld.ffs@tglx>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <8735n42lld.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [37.59.142.96]
X-ClientProxiedBy: DAG4EX1.mxp5.local (172.16.2.31) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: d54a9dd7-eba7-4e7f-a7a0-0dc7c43fc796
X-Ovh-Tracer-Id: 10131410315672259365
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrjeekgddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeeuveelvdejteegteefieevfeetffefvddvieekteevleefgeelgfeutedvfedvfeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehhtggrsehlihhnuhigrdhisghmrdgtohhm

On 12/7/21 21:42, Thomas Gleixner wrote:
> Cedric,
> 
> On Tue, Dec 07 2021 at 16:50, Cédric Le Goater wrote:
>> On 12/7/21 12:36, Michael Ellerman wrote:
>>>
>>> This patch should drop those selects I guess. Can you send an
>>> incremental diff for Thomas to squash in?
>>
>> Sure.
>>
>>> Removing all the tendrils in various device tree files will probably
>>> require some archaeology, and it should be perfectly safe to leave those
>>> in the tree with the driver gone. So I think we can do that as a
>>> subsequent patch, rather than in this series.
>>
>> Here are the changes. Compiled tested with ppc40x and ppc44x defconfigs.
> 
> < Lots of patch skipped />
>> @@ -141,7 +138,6 @@ config REDWOOD
>>    	select FORCE_PCI
>>    	select PPC4xx_PCI_EXPRESS
>>    	select PCI_MSI
>> -	select PPC4xx_MSI
>>    	help
>>    	  This option enables support for the AMCC PPC460SX Redwood board.
> 
> While that is incremental it certainly is worth a patch on it's
> own. Could you add a proper changelog and an SOB please?

Here you are.

  https://github.com/legoater/linux/commit/75d2764b11fe8f6d8bf50d60a3feb599ce27b16d

Thanks,

C.


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:08:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:08:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242142.418838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoK-0006ox-1q; Wed, 08 Dec 2021 11:08:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242142.418838; Wed, 08 Dec 2021 11:08:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoJ-0006oq-US; Wed, 08 Dec 2021 11:08:31 +0000
Received: by outflank-mailman (input) for mailman id 242142;
 Wed, 08 Dec 2021 11:08:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoI-0006Yt-MZ
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:30 +0000
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com
 [2607:f8b0:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2c3b62af-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:08:30 +0100 (CET)
Received: by mail-pf1-x431.google.com with SMTP id k64so2122889pfd.11
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:30 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id b10sm2960927pft.179.2021.12.08.03.08.27
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:28 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c3b62af-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=TnQefY0SqcDF3kPq8KJwIjgVaMNVB8DughUGvzU8o18=;
        b=ZkLOIb1g7XpNcLLrO2xyloqg63+eDW8c1N54mOfbRuFF15rJgWz2gE91JKdJydbYqG
         8eL+r+UhBdoKdktkRc6tlgzDzsYJ6NEY/1TBuKklxnRsWEthwhlQQghbv4vM7av0dghG
         YG6zw3TvtD0aPRSriB0gRBQvxZg2vVXXuprrdD3o0j3Qbt2CneEC83iXlxyIWawDUhZw
         D0iIjqE7yyGv7egqdw5VoqBiJosZhNCpE68DlbCNteQlDu4Axl6SfUW4B/3Jil8jexsd
         tyJwF/W/PbqJoQPqUimewZeAPGV5Cx7WcudydaUIl40hyGzVhigr/W2WRHOIV/UiSSyJ
         MqXQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=TnQefY0SqcDF3kPq8KJwIjgVaMNVB8DughUGvzU8o18=;
        b=chaDo3jPeHj8/RyCOEgJ9dczW6Rv5/pEswDAI6O6FfYF41wg6kxr4fGEUXeknvzFAN
         p3jUc9jNqScsTgG++vxbN623aCLcD+NResC8ARmP5F5jnlMJjwiemGWZR0hrIwpyQtsf
         sbdQo/r4aM/Dx8/VFktWDWVEcDocq/q0zB2S5qMXu0oL364XdsxpGM2khQw0Ggmi73+U
         1tVf7/BX7lWoOL1SiLGCt9jLylLl1d6DMmZiSbSVd+ONuGh7CcWcD2w8zDL2cqLKXpsM
         EtY4Wf/UwamfSpCt0SKXbCM/d8eYOzbTAlw/hQG+irYiV+fYetR/zgM88soXS/q0tNgc
         8JOQ==
X-Gm-Message-State: AOAM530YBJ5V32M/Ij18vSwP0dUGogjPXQU1DaSMmLHBLzXczPFzS18G
	tNRKXX7SyaUzMc1tSCAXMX4=
X-Google-Smtp-Source: ABdhPJy9TsqtHV5JdjlSkcLb9NlmtdqMIVu0NVHyePzQqWTpNS604qrVcpVV8sNyEJaBLMfE3D+HqQ==
X-Received: by 2002:a05:6a00:a18:b0:4a7:ef65:ddfb with SMTP id p24-20020a056a000a1800b004a7ef65ddfbmr4953445pfh.17.1638961708633;
        Wed, 08 Dec 2021 03:08:28 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 01/11] x86/entry: Use swapgs and native_iret directly in swapgs_restore_regs_and_return_to_usermode
Date: Wed,  8 Dec 2021 19:08:23 +0800
Message-Id: <20211208110833.65366-2-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

swapgs_restore_regs_and_return_to_usermode() is used in native code
(non-xenpv) only now, so it doesn't need the PV-aware SWAPGS and
INTERRUPT_RETURN.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 97b1f84bb53f..d95a02ecee16 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -608,8 +608,8 @@ SYM_INNER_LABEL(swapgs_restore_regs_and_return_to_usermode, SYM_L_GLOBAL)
 
 	/* Restore RDI. */
 	popq	%rdi
-	SWAPGS
-	INTERRUPT_RETURN
+	swapgs
+	jmp	native_iret
 
 
 SYM_INNER_LABEL(restore_regs_and_return_to_kernel, SYM_L_GLOBAL)
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:08:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:08:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242141.418827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoG-0006Z6-Py; Wed, 08 Dec 2021 11:08:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242141.418827; Wed, 08 Dec 2021 11:08:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoG-0006Yz-MX; Wed, 08 Dec 2021 11:08:28 +0000
Received: by outflank-mailman (input) for mailman id 242141;
 Wed, 08 Dec 2021 11:08:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoF-0006Yt-1s
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:27 +0000
Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com
 [2607:f8b0:4864:20::629])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28fb83f5-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:08:25 +0100 (CET)
Received: by mail-pl1-x629.google.com with SMTP id u11so1313154plf.3
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:24 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id h13sm3072127pfv.37.2021.12.08.03.08.21
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28fb83f5-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Vg9Y2qwD//mZgSKr3fZbhivDw/ZV22tqoORXTECSxD0=;
        b=itA2cU4V+5hxMb7u2gRFEQ1+caoQ2C6iLL4Fv57ZS4wZBzPvuhal8+Wof+IBV2ZzFb
         s2tdy0Tr/vbgqc2MIJigFoYeK2iyBV8JxxmYf5q/00Xg/nJbsoP4kmY/9BaWVuGvv2s2
         lLetMIdPIz5oRvlGXasZrXiq6C5QKp1frYuVwMsgnvETSMhtBF0wwrkQcW9lI86ig/FW
         7cskonVCDC3F55ogBf3ouGCxkQv7EJlkYJYn2787sM5cAs6rdlG8444budASlJXS7phF
         6YHtZaKt41EOOPo+aL15YJjiGRzr7l7dYwx/MybZUEc4N41Rgw7J4UKXwAxZZsXPeNft
         AJhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Vg9Y2qwD//mZgSKr3fZbhivDw/ZV22tqoORXTECSxD0=;
        b=MgxFa3Uam3xwcm6a7cwqA0AET/wJkgBzG8BvVx/GGqTJqdJJwSg4bAnH0KsdP/t4B5
         3a7gnRs/L/Koc7nonqKKmV5xy4Q5KDIuzmA7j7cZLpzP2AzeqaUJLEQMzsE+ZqPDeA8r
         11eupJaCS5+K8wqMY3QdQDi46GTk736W+QFUTqYvlFJLl08sqzTPfR1wh6GRLVR9ko57
         6RgqoG3usKvf9l3Wz8bkH8famzR+K0rCvNVKhmahMgHnjzbbWQujsPLkbwPAUdPfDrgv
         KdUzNhOVZRzGV9wzJkxx3T/mY4f3dk3KzJZDwXL3JbXYg86PEIhkCyKnxAbm2gxfMfY2
         m7bw==
X-Gm-Message-State: AOAM533MKjrf5Hw0KCrqdkECjokk6hkogFB0ABSe7gZsGUvFW29U5Lr6
	UKaLye079hucqRSssVcoxRwrwZLo814=
X-Google-Smtp-Source: ABdhPJyJqUq+r8DKUrbjm4AzKKBjH7UT96ssoju6KRFceh7AParCUM4v9ULbwlHtBmu1m5eyPpa1Ww==
X-Received: by 2002:a17:90a:384d:: with SMTP id l13mr6534667pjf.104.1638961702635;
        Wed, 08 Dec 2021 03:08:22 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>
Subject: [PATCH 00/11] x86/entry: Clean up entry code
Date: Wed,  8 Dec 2021 19:08:22 +0800
Message-Id: <20211208110833.65366-1-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

This patchset moves the stack-switch code to the place where
error_entry() return, distangles error_entry() from XENpv and makes
entry_INT80_compat use idtentry macro.

This patchset is highly related to XENpv, because it does the extra
cleanup to convert SWAPGS to swapgs after major cleanup is done.

After error_entry() is distangled from XENpv, a branch in sync_regs()
is removed to.

Patch 1-10 are picked from the patchset
https://lore.kernel.org/lkml/20211126101209.8613-1-jiangshanlai@gmail.com/
which coverts ASM code to C code.  These patches are prepared for that
purpose.  But this patchset has it own value: it simplifies the stack
switch, avoids leaving the old stack inside a function, and separates
XENpv code with native code without adding new code which can lead to
more cleanups.

Patch 11 is new in this patchset.

Lai Jiangshan (11):
  x86/entry: Use swapgs and native_iret directly in
    swapgs_restore_regs_and_return_to_usermode
  x86/traps: Move pt_regs only in fixup_bad_iret()
  x86/entry: Switch the stack after error_entry() returns
  x86/entry: move PUSH_AND_CLEAR_REGS out of error_entry
  x86/entry: Move cld to the start of idtentry
  x86/entry: Don't call error_entry for XENPV
  x86/entry: Convert SWAPGS to swapgs in error_entry()
  x86/entry: Use idtentry macro for entry_INT80_compat
  x86/entry: Convert SWAPGS to swapgs in entry_SYSENTER_compat()
  x86: Remove the definition of SWAPGS
  x86/entry: Remove the branch in sync_regs()

 arch/x86/entry/entry_64.S        |  65 +++++++++++++------
 arch/x86/entry/entry_64_compat.S | 104 +------------------------------
 arch/x86/include/asm/idtentry.h  |  47 ++++++++++++++
 arch/x86/include/asm/irqflags.h  |   2 -
 arch/x86/include/asm/proto.h     |   4 --
 arch/x86/include/asm/traps.h     |   2 +-
 arch/x86/kernel/traps.c          |  25 ++++----
 7 files changed, 107 insertions(+), 142 deletions(-)

-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242143.418849 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoS-0007Af-AU; Wed, 08 Dec 2021 11:08:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242143.418849; Wed, 08 Dec 2021 11:08:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoS-0007AU-7C; Wed, 08 Dec 2021 11:08:40 +0000
Received: by outflank-mailman (input) for mailman id 242143;
 Wed, 08 Dec 2021 11:08:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoR-0006Yt-4P
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:39 +0000
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com
 [2607:f8b0:4864:20::102a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 312e853b-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:08:38 +0100 (CET)
Received: by mail-pj1-x102a.google.com with SMTP id
 fv9-20020a17090b0e8900b001a6a5ab1392so1816347pjb.1
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:38 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id e29sm2222262pge.17.2021.12.08.03.08.35
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 312e853b-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=v0Rti8J9O/DOw+Q8wf2xojRDpLT8xHVZ9Lxf2e0cKZk=;
        b=PsLrL5Aie1ZtnPQWX5QQBbXXhbTKSUKu0PazbTlH+ol9j3w7v0vsbVraLGwI8/WUBo
         4JFmDJF1Et2cG6j/knBCajQznDaPYEV9uSmcNxrp0vZqTMFNZiS2SDO75XkRhd5Vvo9d
         iLJGeDUeMxGOuQ9nEeBVyRfyOPmkTlLH91yzjTTVSbHnK38Z+QOAMnm5Va2wTSFbnJfJ
         L8u2+h3MCb0UMPsvd3lGAk9BW7XraGPnmMNDp1DmWaALPZBg//tjNUNJfUiPJyE54GZA
         uoM15nO2f6/MMfuxIpBsbi2/4pmj+7Z/2GspSMt57V6sUf7bF36VCpuwxizpG3+DZLvh
         vyew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=v0Rti8J9O/DOw+Q8wf2xojRDpLT8xHVZ9Lxf2e0cKZk=;
        b=7DIQE05OQ3NOvA7HDjZ5uHMzGGX8GfrzSoAhSZ62u+2TBnBQLvlyeYpVfbSoKez/Hg
         S8A7l/SuH8AQ791cJVnyeHS+p81ACg+DHf2qEbnnmnbk3M+mRESX6B2iZXd97xUKFWLS
         vp6Y+XsvSnfr8SF/crtM+UmFMBQfq4hqS64hjnMk2/HAj56d47AVoFsLEeH0IrhYXOt/
         Drwi4u9MR8fHAEATkM2NGmk6PpbWsMA+gU+Q82ZTATpqRLkT/cvhvT03GxAeBfYdyxfk
         AwCF/DMbalLDKY4JmGSee+Sto7PZO47C/hw8giJtLF2Ozo31MUAU5dmU8HlsPJBK8ceT
         ZS2A==
X-Gm-Message-State: AOAM530orrPGkHjtkxVvvKl7imlBM846k6R7JCnGlvVUkB8JKrce2sBk
	99gPXrRxiLauHCIqzjzKffo=
X-Google-Smtp-Source: ABdhPJxpeELdxfo0JipJhaLLz4786jh3lr2fXOrOICnzD3O4qx8UMsz1Z1IGRVnoqDN8NDdQgTJz/g==
X-Received: by 2002:a17:90b:3889:: with SMTP id mu9mr6279578pjb.160.1638961716971;
        Wed, 08 Dec 2021 03:08:36 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Joerg Roedel <jroedel@suse.de>,
	"Chang S. Bae" <chang.seok.bae@intel.com>
Subject: [PATCH 02/11] x86/traps: Move pt_regs only in fixup_bad_iret()
Date: Wed,  8 Dec 2021 19:08:24 +0800
Message-Id: <20211208110833.65366-3-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

fixup_bad_iret() and sync_regs() have similar arguments and do similar
work that copies full or partial pt_regs to a place and switches stack
after return.  They are quite the same, but fixup_bad_iret() not only
copies the pt_regs but also the return address of error_entry() while
sync_regs() copies the pt_regs only and the return address of
error_entry() was preserved and handled in ASM code.

This patch makes fixup_bad_iret() work like sync_regs() and the
handling of the return address of error_entry() is moved in ASM code.

It removes the need to use the struct bad_iret_stack, simplifies
fixup_bad_iret() and makes the ASM error_entry() call fixup_bad_iret()
as the same as calling sync_regs() which adds readability because
the calling patterns are exactly the same.

It is prepared for later patch to do the stack switch after the
error_entry() which simplifies the code further.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S    |  5 ++++-
 arch/x86/include/asm/traps.h |  2 +-
 arch/x86/kernel/traps.c      | 17 ++++++-----------
 3 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index d95a02ecee16..f8faff3ca61e 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -1040,9 +1040,12 @@ SYM_CODE_START_LOCAL(error_entry)
 	 * Pretend that the exception came from user mode: set up pt_regs
 	 * as if we faulted immediately after IRET.
 	 */
-	mov	%rsp, %rdi
+	popq	%r12				/* save return addr in %12 */
+	movq	%rsp, %rdi			/* arg0 = pt_regs pointer */
 	call	fixup_bad_iret
 	mov	%rax, %rsp
+	ENCODE_FRAME_POINTER
+	pushq	%r12
 	jmp	.Lerror_entry_from_usermode_after_swapgs
 SYM_CODE_END(error_entry)
 
diff --git a/arch/x86/include/asm/traps.h b/arch/x86/include/asm/traps.h
index 6221be7cafc3..1cdd7e8bcba7 100644
--- a/arch/x86/include/asm/traps.h
+++ b/arch/x86/include/asm/traps.h
@@ -13,7 +13,7 @@
 #ifdef CONFIG_X86_64
 asmlinkage __visible notrace struct pt_regs *sync_regs(struct pt_regs *eregs);
 asmlinkage __visible notrace
-struct bad_iret_stack *fixup_bad_iret(struct bad_iret_stack *s);
+struct pt_regs *fixup_bad_iret(struct pt_regs *bad_regs);
 void __init trap_init(void);
 asmlinkage __visible noinstr struct pt_regs *vc_switch_off_ist(struct pt_regs *eregs);
 #endif
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index c9d566dcf89a..a6c0bc9ee36f 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -761,13 +761,8 @@ asmlinkage __visible noinstr struct pt_regs *vc_switch_off_ist(struct pt_regs *r
 }
 #endif
 
-struct bad_iret_stack {
-	void *error_entry_ret;
-	struct pt_regs regs;
-};
-
 asmlinkage __visible noinstr
-struct bad_iret_stack *fixup_bad_iret(struct bad_iret_stack *s)
+struct pt_regs *fixup_bad_iret(struct pt_regs *bad_regs)
 {
 	/*
 	 * This is called from entry_64.S early in handling a fault
@@ -777,19 +772,19 @@ struct bad_iret_stack *fixup_bad_iret(struct bad_iret_stack *s)
 	 * just below the IRET frame) and we want to pretend that the
 	 * exception came from the IRET target.
 	 */
-	struct bad_iret_stack tmp, *new_stack =
-		(struct bad_iret_stack *)__this_cpu_read(cpu_tss_rw.x86_tss.sp0) - 1;
+	struct pt_regs tmp, *new_stack =
+		(struct pt_regs *)__this_cpu_read(cpu_tss_rw.x86_tss.sp0) - 1;
 
 	/* Copy the IRET target to the temporary storage. */
-	__memcpy(&tmp.regs.ip, (void *)s->regs.sp, 5*8);
+	__memcpy(&tmp.ip, (void *)bad_regs->sp, 5*8);
 
 	/* Copy the remainder of the stack from the current stack. */
-	__memcpy(&tmp, s, offsetof(struct bad_iret_stack, regs.ip));
+	__memcpy(&tmp, bad_regs, offsetof(struct pt_regs, ip));
 
 	/* Update the entry stack */
 	__memcpy(new_stack, &tmp, sizeof(tmp));
 
-	BUG_ON(!user_mode(&new_stack->regs));
+	BUG_ON(!user_mode(new_stack));
 	return new_stack;
 }
 #endif
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242144.418860 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoX-0007XF-Qg; Wed, 08 Dec 2021 11:08:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242144.418860; Wed, 08 Dec 2021 11:08:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoX-0007X5-LX; Wed, 08 Dec 2021 11:08:45 +0000
Received: by outflank-mailman (input) for mailman id 242144;
 Wed, 08 Dec 2021 11:08:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoW-0006Yt-GP
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:44 +0000
Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com
 [2607:f8b0:4864:20::530])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 346da667-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:08:43 +0100 (CET)
Received: by mail-pg1-x530.google.com with SMTP id r138so1736993pgr.13
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:43 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id a16sm2254924pgm.57.2021.12.08.03.08.41
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 346da667-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=74fcl84eMF3trMMN2JVz1x4AFBWc9HU1GFAGLmUM5eE=;
        b=VKlr4hE6P3/KVxbIhcLJDA0sF52nL0lnTLSlQue1EOi6nOPZmlq7+N6t34Z4nlAn6S
         6NYswFiLZFVt72m7dLmKsXjcv49Tzn4Vfnpcat4WRibMq/7lLfmYUvxqlDrF2qI/vqdA
         5aiicTqsTeo5rZI/iqEDgXPe0X06ShRim5daAufoj+27dBC6vjm3F6QWqdhhrBeccdlx
         vioUF/TKnCwOTAFHjtjXkA2ZHEBTUJBfBC9YS2QXCQak02LJEkZyHt3r3mxI7EG3xklk
         0XSnYu5Z2L1fze0kQgB0lt62j14Jn3CZPbd5zi5beWbTOrpQnWraqlF9nD9BmgP3hxz8
         xxDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=74fcl84eMF3trMMN2JVz1x4AFBWc9HU1GFAGLmUM5eE=;
        b=ETyW2lETc1herkLk/EiUKJV11X5B1Oas8zxXRMNOp4rg5v72qYkew7jPQAOurEcIk2
         BNKwIVNv67+tftEx5pL8/AxngnKxU28po8UGf3rNr+5MuKtE2n/H4bDF/MW8N+ZANr9C
         IZg0ZzRAnm/rWBD/6eIj4PXLnzJe3tJsoQN7VtJQKTkq3xfkrzBz0uBQXjc9dkil27Nk
         z+XprFGkxMg9Bh4CZNsRFY5HG3z8qfo6dKZ18qbMc4DjZHZJpKbMa7UCxG7+DYCAkDfW
         8755+04V/51WSe436gTZXYOi+GDnW0PskJB5YoWCbqKIhCdqhc8tGfFKNljVufuMuZez
         rrdQ==
X-Gm-Message-State: AOAM532JwxB2IizVr4Ix2Ni1OgNKbYk8NJyNo+yBUZZYM/mik4WilOhK
	1+L2IObTvqa50cjIjo8vOEo=
X-Google-Smtp-Source: ABdhPJwdwD0NWVFtmrZKBdCkBw1nVwlMCHpLBoT9j05zLnwJyoppx7uciS4Kg9RdTDjqkCWrZh05WA==
X-Received: by 2002:a63:e43:: with SMTP id 3mr29449478pgo.73.1638961722423;
        Wed, 08 Dec 2021 03:08:42 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 03/11] x86/entry: Switch the stack after error_entry() returns
Date: Wed,  8 Dec 2021 19:08:25 +0800
Message-Id: <20211208110833.65366-4-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

error_entry() calls sync_regs() to settle/copy the pt_regs and switches
the stack directly after sync_regs().  But error_entry() itself is also
a function call, the switching has to handle the return address of it
together, which causes the work complicated and tangly.

Switching to the stack after error_entry() makes the code simpler and
intuitive.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index f8faff3ca61e..6baa7413f7eb 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -323,6 +323,8 @@ SYM_CODE_END(ret_from_fork)
 .macro idtentry_body cfunc has_error_code:req
 
 	call	error_entry
+	movq	%rax, %rsp			/* switch stack settled by sync_regs() */
+	ENCODE_FRAME_POINTER
 	UNWIND_HINT_REGS
 
 	movq	%rsp, %rdi			/* pt_regs pointer into 1st argument*/
@@ -981,14 +983,10 @@ SYM_CODE_START_LOCAL(error_entry)
 	/* We have user CR3.  Change to kernel CR3. */
 	SWITCH_TO_KERNEL_CR3 scratch_reg=%rax
 
+	leaq	8(%rsp), %rdi			/* arg0 = pt_regs pointer */
 .Lerror_entry_from_usermode_after_swapgs:
 	/* Put us onto the real thread stack. */
-	popq	%r12				/* save return addr in %12 */
-	movq	%rsp, %rdi			/* arg0 = pt_regs pointer */
 	call	sync_regs
-	movq	%rax, %rsp			/* switch stack */
-	ENCODE_FRAME_POINTER
-	pushq	%r12
 	ret
 
 	/*
@@ -1020,6 +1018,7 @@ SYM_CODE_START_LOCAL(error_entry)
 	 */
 .Lerror_entry_done_lfence:
 	FENCE_SWAPGS_KERNEL_ENTRY
+	leaq	8(%rsp), %rax			/* return pt_regs pointer */
 	ret
 
 .Lbstep_iret:
@@ -1040,12 +1039,9 @@ SYM_CODE_START_LOCAL(error_entry)
 	 * Pretend that the exception came from user mode: set up pt_regs
 	 * as if we faulted immediately after IRET.
 	 */
-	popq	%r12				/* save return addr in %12 */
-	movq	%rsp, %rdi			/* arg0 = pt_regs pointer */
+	leaq	8(%rsp), %rdi			/* arg0 = pt_regs pointer */
 	call	fixup_bad_iret
-	mov	%rax, %rsp
-	ENCODE_FRAME_POINTER
-	pushq	%r12
+	mov	%rax, %rdi
 	jmp	.Lerror_entry_from_usermode_after_swapgs
 SYM_CODE_END(error_entry)
 
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242148.418870 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuod-0007xR-1B; Wed, 08 Dec 2021 11:08:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242148.418870; Wed, 08 Dec 2021 11:08:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoc-0007xG-UH; Wed, 08 Dec 2021 11:08:50 +0000
Received: by outflank-mailman (input) for mailman id 242148;
 Wed, 08 Dec 2021 11:08:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoc-0007Ud-3S
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:50 +0000
Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com
 [2607:f8b0:4864:20::436])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37c10856-5817-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:08:49 +0100 (CET)
Received: by mail-pf1-x436.google.com with SMTP id r130so2188747pfc.1
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:49 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id p17sm3404857pfh.86.2021.12.08.03.08.47
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:47 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37c10856-5817-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=RcBSE4oPibzeIhyf2Qp5YqTgR/bF+VmAeF/brxTC5FU=;
        b=D0KfkWiPHhKhRJUZdR5kq7I4HpNBJdRwa55sv9BMfhZ3vbJVIPNqKGnE1ONGnrlI34
         2uQvzZB8c1W/Hzmk9lJIBvPuBZIZBDzlhZ6uIuU9VZOKqWnOAHB9aMyyXNK8KcmbcQV/
         bQjVtI9HtkySFmOwWp9onHdlvBxih0vvgFOJHMQjs9U8tAoDeS0Tt29U9Ye6sau5kAxz
         J/DeQH5dwbfQl7bRYn+aIrOkMti5RoJtWalneYj8OgUE/4cpA9PctgdhPmFe30GA+AfV
         HgbSnUq6EfLPRCS7X+q0+QvEnT3ZXqXLMRNwgKgKcUcvvo/VDdu5ix0k/Mo8225S/GHA
         bJ1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=RcBSE4oPibzeIhyf2Qp5YqTgR/bF+VmAeF/brxTC5FU=;
        b=yVkxtcDkw60pEpnnd0QuPE42u9tz9HgBIn7a0JMf/GLEAJwksZge6oNRNwdS0lJvI5
         84BhDOXz2mts7Ej2jfXoq+8QNv3zNP3wmgx1CZd9R7BYCRpcKmtnnMpcLXFZwheN1ff6
         xh01oYtzzRFJ7ChlbMO0B5zA0n4eh7GJBw7QlSax5b9N3QfViLiIosEZXXwTQvdgbDiZ
         S33LrbwVlyb9dSttozh8IZJGXLrHfFiy5ASiWcEAcpQHIWFF4cBxMSeCFmacbu3XGfRa
         jCk705/7qcOMgz1Q/X4himD8Y+BTlA/jH10b/0nAh5s8I71w1yhfi2hsbW6snYi9mT/e
         2tPA==
X-Gm-Message-State: AOAM533c8HwJFY7qXd7coz/XScI2uV6/v+xWtWKxbgULXc3oJfkfthba
	WgHOyAEBjycDZNuQWSQTaOQ=
X-Google-Smtp-Source: ABdhPJwB9xEYc6yaPMgbaAjXzRhRbjCMiDT7xaBXucJ4jA6rNMMEh2pDhUz6bzCHuWkJVnkpO7Wxhg==
X-Received: by 2002:a05:6a00:1a8e:b0:49f:a4a9:8f1e with SMTP id e14-20020a056a001a8e00b0049fa4a98f1emr4890452pfv.67.1638961727985;
        Wed, 08 Dec 2021 03:08:47 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 04/11] x86/entry: move PUSH_AND_CLEAR_REGS out of error_entry
Date: Wed,  8 Dec 2021 19:08:26 +0800
Message-Id: <20211208110833.65366-5-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

Moving PUSH_AND_CLEAR_REGS out of error_entry doesn't change any
functionality.  It will enlarge the size:

size arch/x86/entry/entry_64.o.before:
   text	   data	    bss	    dec	    hex	filename
  17916	    384	      0	  18300	   477c	arch/x86/entry/entry_64.o

size --format=SysV arch/x86/entry/entry_64.o.before:
.entry.text                      5528      0
.orc_unwind                      6456      0
.orc_unwind_ip                   4304      0

size arch/x86/entry/entry_64.o.after:
   text	   data	    bss	    dec	    hex	filename
  26868	    384	      0	  27252	   6a74	arch/x86/entry/entry_64.o

size --format=SysV arch/x86/entry/entry_64.o.after:
.entry.text                      8200      0
.orc_unwind                     10224      0
.orc_unwind_ip                   6816      0

But .entry.text in x86_64 is 2M aligned, enlarging it to 8.2k doesn't
enlarge the final text size.

The tables .orc_unwind[_ip] are enlarged due to it adds many pushes.

It is prepared for not calling error_entry() from XENPV in later patch
and for future converting the whole error_entry into C code.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 6baa7413f7eb..72ceb4b70822 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -322,6 +322,9 @@ SYM_CODE_END(ret_from_fork)
  */
 .macro idtentry_body cfunc has_error_code:req
 
+	PUSH_AND_CLEAR_REGS
+	ENCODE_FRAME_POINTER
+
 	call	error_entry
 	movq	%rax, %rsp			/* switch stack settled by sync_regs() */
 	ENCODE_FRAME_POINTER
@@ -969,8 +972,6 @@ SYM_CODE_END(paranoid_exit)
 SYM_CODE_START_LOCAL(error_entry)
 	UNWIND_HINT_FUNC
 	cld
-	PUSH_AND_CLEAR_REGS save_ret=1
-	ENCODE_FRAME_POINTER 8
 	testb	$3, CS+8(%rsp)
 	jz	.Lerror_kernelspace
 
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242149.418882 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoj-0008NI-E5; Wed, 08 Dec 2021 11:08:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242149.418882; Wed, 08 Dec 2021 11:08:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoj-0008NB-8U; Wed, 08 Dec 2021 11:08:57 +0000
Received: by outflank-mailman (input) for mailman id 242149;
 Wed, 08 Dec 2021 11:08:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuoh-0006Yt-KY
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:08:55 +0000
Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com
 [2607:f8b0:4864:20::42c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b13cd72-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:08:55 +0100 (CET)
Received: by mail-pf1-x42c.google.com with SMTP id x131so2117615pfc.12
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:08:54 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id d3sm3454696pfv.57.2021.12.08.03.08.52
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:53 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b13cd72-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=94qtwsHdBUcVzdr14fQH4QqeaELVSejvb9k+dDp4o2k=;
        b=gdJwJexPSIx1/o0kGlFH/3siK2BWmqN/Qya2wWAwRpJBABJCf7cZVPY1vV9uKphzCM
         wDiL42S9zLojg/9rYkV+8Gcyug0bNkhyprI3HL5IVv6FPdbDYpG0Q+9f1fcLvsLyHqlJ
         6d+3RCpxWxTSvIGQUyD3iKktmbGyZSKRYFR81PlrbYQogKQmi6fZOJTId9b93ecmVF2Q
         eT3UjTw/vZKqvqEL/qGLIrdAM1QDCdiqpnZVGVu3jSXv5teHhN5/T/g/zvUjMZ6G722x
         jjKFxOz0lcm/NslZErC/EI4Yi0rOzfoSzQ5g0N+HuIY4WjIjEBS0MHTo4NO9TZ3LRbFW
         TNpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=94qtwsHdBUcVzdr14fQH4QqeaELVSejvb9k+dDp4o2k=;
        b=Ba7keV8NGEKXsNX4HoGD1ZSQNQWw0OLkR6TS2sZO8Z0KYRMCxSm5Ug3Goqwa0ExRXT
         QZhDEB0L1Y4GIJoV5NpwTD9aGFVvIN7eopFEa6EhitcJHlswX2OGTFrC3e/pmI4NhVdL
         elr3jYrvyVn/5apmJ++5hc4Epk7lxaAE/jhosQ8LYN0D3P61DdEfdyxfzCFxrY/fYZu6
         9XEDFS/3Uv/WTN/ziJeBdKj1wB9PVQkkyVTryAQFMnz9fMeLA+JIXpjNYDsKvTzYmZ79
         RZdmhjlPkryQ12VsFO3j/cXXNDGD8jQjXc+Et1bvQYOIo2zGaZds4hWDDrRpjmUqioSg
         /34w==
X-Gm-Message-State: AOAM533o7E3HBoiYfvbbNMPSPFDNVHglCpBIsE9NzdhQkwf0x9jC98Ms
	45t9WdWIKok6oYiSFOfjxMw=
X-Google-Smtp-Source: ABdhPJzMp2m1CIOe5Z9utqdinpuLznocfHk1h5+AWYqs9CoFg7FElyyIpiFD9TM9L0u194BTWXvhUw==
X-Received: by 2002:a62:8449:0:b0:4ad:56ba:2f1d with SMTP id k70-20020a628449000000b004ad56ba2f1dmr4928492pfd.37.1638961733585;
        Wed, 08 Dec 2021 03:08:53 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 05/11] x86/entry: Move cld to the start of idtentry
Date: Wed,  8 Dec 2021 19:08:27 +0800
Message-Id: <20211208110833.65366-6-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

Make it next to CLAC

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 72ceb4b70822..ee1d4adcdab0 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -356,6 +356,7 @@ SYM_CODE_END(ret_from_fork)
 SYM_CODE_START(\asmsym)
 	UNWIND_HINT_IRET_REGS offset=\has_error_code*8
 	ASM_CLAC
+	cld
 
 	.if \has_error_code == 0
 		pushq	$-1			/* ORIG_RAX: no syscall to restart */
@@ -423,6 +424,7 @@ SYM_CODE_END(\asmsym)
 SYM_CODE_START(\asmsym)
 	UNWIND_HINT_IRET_REGS
 	ASM_CLAC
+	cld
 
 	pushq	$-1			/* ORIG_RAX: no syscall to restart */
 
@@ -478,6 +480,7 @@ SYM_CODE_END(\asmsym)
 SYM_CODE_START(\asmsym)
 	UNWIND_HINT_IRET_REGS
 	ASM_CLAC
+	cld
 
 	/*
 	 * If the entry is from userspace, switch stacks and treat it as
@@ -539,6 +542,7 @@ SYM_CODE_END(\asmsym)
 SYM_CODE_START(\asmsym)
 	UNWIND_HINT_IRET_REGS offset=8
 	ASM_CLAC
+	cld
 
 	/* paranoid_entry returns GS information for paranoid_exit in EBX. */
 	call	paranoid_entry
@@ -853,7 +857,6 @@ SYM_CODE_END(xen_failsafe_callback)
  */
 SYM_CODE_START_LOCAL(paranoid_entry)
 	UNWIND_HINT_FUNC
-	cld
 	PUSH_AND_CLEAR_REGS save_ret=1
 	ENCODE_FRAME_POINTER 8
 
@@ -971,7 +974,6 @@ SYM_CODE_END(paranoid_exit)
  */
 SYM_CODE_START_LOCAL(error_entry)
 	UNWIND_HINT_FUNC
-	cld
 	testb	$3, CS+8(%rsp)
 	jz	.Lerror_kernelspace
 
@@ -1104,6 +1106,7 @@ SYM_CODE_START(asm_exc_nmi)
 	 */
 
 	ASM_CLAC
+	cld
 
 	/* Use %rdx as our temp variable throughout */
 	pushq	%rdx
@@ -1123,7 +1126,6 @@ SYM_CODE_START(asm_exc_nmi)
 	 */
 
 	swapgs
-	cld
 	FENCE_SWAPGS_USER_ENTRY
 	SWITCH_TO_KERNEL_CR3 scratch_reg=%rdx
 	movq	%rsp, %rdx
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242155.418892 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoo-0000V1-Ko; Wed, 08 Dec 2021 11:09:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242155.418892; Wed, 08 Dec 2021 11:09:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuoo-0000Uu-HH; Wed, 08 Dec 2021 11:09:02 +0000
Received: by outflank-mailman (input) for mailman id 242155;
 Wed, 08 Dec 2021 11:09:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuon-0007Ud-0I
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:01 +0000
Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com
 [2607:f8b0:4864:20::42f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3e5084b6-5817-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:09:00 +0100 (CET)
Received: by mail-pf1-x42f.google.com with SMTP id i12so2152989pfd.6
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:00 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id gc22sm5791712pjb.57.2021.12.08.03.08.57
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:08:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3e5084b6-5817-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=GTzYOcv7GXMsuudeRCCVKvQE4p4RTznbhZKVu0xYKUU=;
        b=km30WDN3p/x6O1LN4IM4fy77QF1NVRUPK5sP06Gal6+QGtjqpUUYFI0ArnBEImqtBx
         AuUANxaE5TNvqfzwlIxrjFaBsxfD6p1eT/U6KemlwxP4SBJRnkOXwocKlRobPiXwphiK
         nnKNx8a17oUYe1aBF9xVYjEfT0JHyVlsyWpuNHWRttKft7eHMogyjA4hHEpDixYozui/
         Yp9HWHVmMbUx0pUgEzC7X+43ukc3qPqWPrcwKNA92/m1IkWkKcYC2169qQXVTznVDh9C
         8FdQ3N0QnfLfiyMM1qnRw3/LhI95W2mPf5Ae8J85boc7Vk+qIFVR2qqDY1HLZcu21xTg
         Tx+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=GTzYOcv7GXMsuudeRCCVKvQE4p4RTznbhZKVu0xYKUU=;
        b=ygSohSlCfvG7LQhGRAIs7IFPZ0Ye6C6+oFRnaZVHZCqchFjPO2CI1F7p98Jb5lXGxh
         3y8eCocAKpr3t8duCMdKyOgPLtfGThZ5bJyCkg3tWjsUPUpb+jwI0gXjAMI0y/Ow4XAQ
         3fMejLW6MiidNGJeFiWaPKlVqpi0IC3D5UKSWgphUIcmIYMK1QpBb7ichbS5RWcuUfjR
         aD/lPQzzI+XF0iAmCnl365aYpN4cFPwV9ccUp3ULaC30oQ2JlKt9hgWU+Q4mOcuX0SnP
         HIW9NMzhOkTvQEBSt7Vm15tLtWcRDJ60F1+cO33qH/L3WiotgcEGrfbkHBY39XP79yxw
         VycA==
X-Gm-Message-State: AOAM532kDaHDOUM/0Fewub5NNBSQ8EZujuNIwdNgpHeMZMdQe0o2MchW
	5tYTgVgQLhH8UqxE9FFL2qE=
X-Google-Smtp-Source: ABdhPJyG8RspzExM0YLJHIGBovB6b/ZNv9oPLLxl7bIY/uiUpBpyPdvWlt/3qAb05wwKy/zxp0w/Lw==
X-Received: by 2002:a05:6a00:ad0:b0:4a3:1056:e2ae with SMTP id c16-20020a056a000ad000b004a31056e2aemr4931125pfl.2.1638961739024;
        Wed, 08 Dec 2021 03:08:59 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 06/11] x86/entry: Don't call error_entry for XENPV
Date: Wed,  8 Dec 2021 19:08:28 +0800
Message-Id: <20211208110833.65366-7-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

When in XENPV, it is already in the task stack, and it can't fault
for native_iret() nor native_load_gs_index() since XENPV uses its own
pvops for iret and load_gs_index().  And it doesn't need to switch CR3.
So there is no reason to call error_entry() in XENPV.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index ee1d4adcdab0..383070aa9272 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -325,8 +325,17 @@ SYM_CODE_END(ret_from_fork)
 	PUSH_AND_CLEAR_REGS
 	ENCODE_FRAME_POINTER
 
-	call	error_entry
-	movq	%rax, %rsp			/* switch stack settled by sync_regs() */
+	/*
+	 * Call error_entry and switch stack settled by sync_regs().
+	 *
+	 * When in XENPV, it is already in the task stack, and it can't fault
+	 * for native_iret() nor native_load_gs_index() since XENPV uses its
+	 * own pvops for iret and load_gs_index().  And it doesn't need to
+	 * switch CR3.  So it can skip invoking error_entry().
+	 */
+	ALTERNATIVE "call error_entry; movq %rax, %rsp", \
+		"", X86_FEATURE_XENPV
+
 	ENCODE_FRAME_POINTER
 	UNWIND_HINT_REGS
 
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242159.418904 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuot-0000xE-Uu; Wed, 08 Dec 2021 11:09:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242159.418904; Wed, 08 Dec 2021 11:09:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuot-0000wu-R6; Wed, 08 Dec 2021 11:09:07 +0000
Received: by outflank-mailman (input) for mailman id 242159;
 Wed, 08 Dec 2021 11:09:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muuos-0007Ud-QC
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:06 +0000
Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com
 [2607:f8b0:4864:20::102e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41c645b6-5817-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:09:06 +0100 (CET)
Received: by mail-pj1-x102e.google.com with SMTP id v23so1664666pjr.5
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:06 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id b18sm2455866pjo.31.2021.12.08.03.09.03
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:09:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41c645b6-5817-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=8qfk8rEd7OE7FkctKlJZZ9kD8w0vOU1vAluUq/sa8Oc=;
        b=l7nygggwydXZUAu4zkqtbtTRWY39vFf8FLQk4PTAPrhXI+tzr6CLSDOcbjAIFholoR
         ZflKnIP1dr60YP3ogLki0mS5fzvW2s2sJ5JJjEOnEcnqaWFXcDIqGKfbpVG5umYF7IuV
         XbGokOAZ7qo1h+G1Bfk0/lmfvpWFvQF3DWBtRJl8/CnxVy53GK6huw6txhzHw8osD5Bs
         OMUKn0L37dEZLYVTT7lapANuDqunPxOpcQlA+VF0ffqg433s/FhOPxw6l+uZTJK2URXY
         u7aPuRJNHxAhjbmWX/mle+316jDesbf0dAlNAH5fyU9efV13TpPnGDNyw76aFmOqi4by
         5IXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=8qfk8rEd7OE7FkctKlJZZ9kD8w0vOU1vAluUq/sa8Oc=;
        b=ka+2mO4WD88MS0SWkqc+1akBJgM5vI4yVuTSBn8xAc0mW2HapwnLhPbCgYx/QHxEA3
         sBfXugyl0zl5/FHNQRgnOoYbPwMIOcZkSCpLrHQkw2p3lTfQ4TnHz8bg2IVFHc/FdYr/
         NZQpIx/JDBEdX8i16uG/MkkNQ3AsPyGF68uvOljklHWnSLd61ADthMS8z83jHCwfP+2x
         zBKORXoGBZp6kcH5/T2akQ4EAK7F+jfUoeK71HhxckUES4gUBTb6CMmHP91Srxoy/7A5
         lJ3FvY7/wF9JofwFeYloiS3duKlt9hYBTnrIKIvOBSGLn7pyRmwUHnNGN2QXbS4L/XKb
         Q6yA==
X-Gm-Message-State: AOAM531CPy2KKRI8Y5xjakU+VynmAkQ1tpLT2ixeW8rtHsscp9i3QHk+
	7AdaeeiVGD3gUPsuz5tuTWk=
X-Google-Smtp-Source: ABdhPJyX9L5YCir717yBDgGNa36Bhmc2dDItA2/uZBarVsl66m2fKt+O9ZG0+5iKAc//bNxdDvNjmA==
X-Received: by 2002:a17:90b:612:: with SMTP id gb18mr6498365pjb.0.1638961744681;
        Wed, 08 Dec 2021 03:09:04 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 07/11] x86/entry: Convert SWAPGS to swapgs in error_entry()
Date: Wed,  8 Dec 2021 19:08:29 +0800
Message-Id: <20211208110833.65366-8-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

XENPV doesn't use error_entry() anymore, so the pv-aware SWAPGS can be
changed to native swapgs.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 383070aa9272..6100007fd03f 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -990,7 +990,7 @@ SYM_CODE_START_LOCAL(error_entry)
 	 * We entered from user mode or we're pretending to have entered
 	 * from user mode due to an IRET fault.
 	 */
-	SWAPGS
+	swapgs
 	FENCE_SWAPGS_USER_ENTRY
 	/* We have user CR3.  Change to kernel CR3. */
 	SWITCH_TO_KERNEL_CR3 scratch_reg=%rax
@@ -1022,7 +1022,7 @@ SYM_CODE_START_LOCAL(error_entry)
 	 * gsbase and proceed.  We'll fix up the exception and land in
 	 * .Lgs_change's error handler with kernel gsbase.
 	 */
-	SWAPGS
+	swapgs
 
 	/*
 	 * Issue an LFENCE to prevent GS speculation, regardless of whether it is a
@@ -1043,7 +1043,7 @@ SYM_CODE_START_LOCAL(error_entry)
 	 * We came from an IRET to user mode, so we have user
 	 * gsbase and CR3.  Switch to kernel gsbase and CR3:
 	 */
-	SWAPGS
+	swapgs
 	FENCE_SWAPGS_USER_ENTRY
 	SWITCH_TO_KERNEL_CR3 scratch_reg=%rax
 
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:09:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:09:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242167.418915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muup8-0001uC-8y; Wed, 08 Dec 2021 11:09:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242167.418915; Wed, 08 Dec 2021 11:09:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muup8-0001tu-5c; Wed, 08 Dec 2021 11:09:22 +0000
Received: by outflank-mailman (input) for mailman id 242167;
 Wed, 08 Dec 2021 11:09:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muup7-0007Ud-Dd
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:21 +0000
Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com
 [2607:f8b0:4864:20::1034])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a81ed7d-5817-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:09:20 +0100 (CET)
Received: by mail-pj1-x1034.google.com with SMTP id gt5so1693916pjb.1
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:20 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id s15sm2665417pjs.51.2021.12.08.03.09.18
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:09:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a81ed7d-5817-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=WphTuTVslZby+oDEm50XCSesh2uHM5bzyfp9NXbgOWI=;
        b=htwdJLPu0gbuBqzNfz7sUj3efCTwW2LVgoh7ceQ0BMbkeYhPhXwXqOasG0Bd8RJnve
         XAAXE8iaSVBK6I6+t8twEOP/RHaK4mAkcL91G9J2LxApElT1FlYqrg1s/Gg2QuqLEqAt
         Xp4KqW62Iq1m5547lpOp1SrpBcM3mYOrFm91iX6Fb7OiOY1ScjdTivEC2Oy/lIyYlKLm
         gZAsMcM2ZGf8cfQoKLV6309j6vQq+DLsm0OVA24wlnmsN4Ki2w52UEmZGesy0mkRCwlx
         D6oBpssBTUieU9+0PWVIpucZ1qx6OzKjivCUNTWYSj2ChMJ0rvHeSI5cVlCD5IXjw/IB
         1w0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=WphTuTVslZby+oDEm50XCSesh2uHM5bzyfp9NXbgOWI=;
        b=v37213tr9wswWg62gCLkWID6Mdy3oT1EcZSpZTDzIt3QRa2LujTgOdQsl5pmXPbJwQ
         vV0kKdkhiCwixlGtwq7p9jvnxx5WdBFXs0JhKT7QqiFW89LddJqLBR+SDOlRDaazpt4W
         iJZdSPWMI+K8KpxL4RIvF298JjkbfY0WVOEPoQ1/QZXF1U/lgztS0pHb2O42DEMPs4CO
         ILS7UyFgNZDkYw5RPIDvIFW/8UXItZPkheSb1xJoWYOEuWwIeTpEtfwhfnNmEqvBdxGy
         3VfkQPT+cvhcqlsdCcmcFKR+Dj02plcWi/AQbyKUWUrgmpTnCeivZ5cslYVX9xw7pQKe
         amuQ==
X-Gm-Message-State: AOAM533h+kU09W9yYg6DOD8sBTqkOaWoi2iR7E1G8EiCgDMu+0//uPEX
	L01jru2hHdEr4e4bJplFnyhvCuhiIpQ=
X-Google-Smtp-Source: ABdhPJygiu3o+VoYWbdot6ZOwAuTCklCWFi5NzkjvztY5lMtfZYeyM7huQwfqLtMKHLX/ykwc3TFVw==
X-Received: by 2002:a17:90b:357:: with SMTP id fh23mr6446123pjb.238.1638961759479;
        Wed, 08 Dec 2021 03:09:19 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 09/11] x86/entry: Convert SWAPGS to swapgs in entry_SYSENTER_compat()
Date: Wed,  8 Dec 2021 19:08:31 +0800
Message-Id: <20211208110833.65366-10-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

XENPV has its own entry point for SYSENTER, it doesn't use
entry_SYSENTER_compat.  So the pv-awared SWAPGS can be changed to
swapgs.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64_compat.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index a4fcea0cab14..72e017c3941f 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -49,7 +49,7 @@
 SYM_CODE_START(entry_SYSENTER_compat)
 	UNWIND_HINT_EMPTY
 	/* Interrupts are off on entry. */
-	SWAPGS
+	swapgs
 
 	pushq	%rax
 	SWITCH_TO_KERNEL_CR3 scratch_reg=%rax
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:17:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:17:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242186.418925 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuwY-0004TX-6p; Wed, 08 Dec 2021 11:17:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242186.418925; Wed, 08 Dec 2021 11:17:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuwY-0004TQ-3k; Wed, 08 Dec 2021 11:17:02 +0000
Received: by outflank-mailman (input) for mailman id 242186;
 Wed, 08 Dec 2021 11:17:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muup1-0006Yt-6J
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:15 +0000
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com
 [2607:f8b0:4864:20::435])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 468925f5-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:09:14 +0100 (CET)
Received: by mail-pf1-x435.google.com with SMTP id z6so2145783pfe.7
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:14 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id q10sm3232415pfk.180.2021.12.08.03.09.11
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:09:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 468925f5-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4OSMT+TQw2RUHxNW8atVbB9ZMIOeuqyP7ER0LvB+dp8=;
        b=p9amC8ioLdWqBeAJ4CjkDRZ1SNu2S6IWtNPrQgya84oZpDa9clfN6COADE//h/Kczz
         kQ+fmFgTFQoLYUpO3SxmFlpuPVleUj1yU37SK/cIZ0B+1mzWQP1bXTdmwTYJqBqgidym
         s3Qnw3+ezN8X07/YBXDOFJMTCWVdRYuXNtqsZb9MYstubPgHdxVejo3WZ/+NjwbHXH2U
         8tjQd71AvCYyeR33oziwHtkT65rxg9yzijXFTi0+rKnlPvNRCFSokL+RsxQRBvOrVIrU
         w/GkvVUeb2F4qxGFfEyZK3vg73sGRS4uXqjhQZh5lj5xic5xJsV2YQ+0E79kCZaZeBK8
         qj8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4OSMT+TQw2RUHxNW8atVbB9ZMIOeuqyP7ER0LvB+dp8=;
        b=sLtDYEapG9TOyv52Jjozb9YXPNWpHknkGvwfvv1A0wZ1cP5tuixjH3pDIOpY58yP0n
         nYrYTZkH4IBT9/TO4z+PVxx4T4iy97Agsgsx9dVJVHR4ndOmD1zmLT4+QDs+rQ14UlUT
         zabPop6ORuqpg8surRWM0+6eUdBuw7C4evKFYr2SEA/FqCZf/v7y0NpmG5Rm+60GR7ec
         h7RTMIIYgnoLCy7zOPbB55aad94j0YWu4Blq59dgaVxgQhVPuT8TJWwETsaBLe0eEYfF
         R7Pvime0zRVylUicmKz2SFYUkyqamoc3IILrDiqb2OFqFDUxomqb/OXKTfsRmx3CKg04
         VGog==
X-Gm-Message-State: AOAM5335gThepBertzopR7foo9NJRHRrsm0tCGeISj8R0cRMk78vfoui
	7F/RSNt8jYStAK4etYh8iSU=
X-Google-Smtp-Source: ABdhPJyXGPiRK3kSpyhR6KL61u0teYkSKfkL2XAKTjzosU2gZ8Lz/nBoNiGVciQ2kf7/fPZtckPd8w==
X-Received: by 2002:a63:6a03:: with SMTP id f3mr28895124pgc.618.1638961752671;
        Wed, 08 Dec 2021 03:09:12 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Juergen Gross <jgross@suse.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Joerg Roedel <jroedel@suse.de>,
	"Chang S. Bae" <chang.seok.bae@intel.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: [PATCH 08/11] x86/entry: Use idtentry macro for entry_INT80_compat
Date: Wed,  8 Dec 2021 19:08:30 +0800
Message-Id: <20211208110833.65366-9-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

entry_INT80_compat is identical to idtentry macro except a special
handling for %rax in the prolog.

Add the prolog to idtentry and use idtentry for entry_INT80_compat.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/entry/entry_64.S        |  18 ++++++
 arch/x86/entry/entry_64_compat.S | 102 -------------------------------
 arch/x86/include/asm/idtentry.h  |  47 ++++++++++++++
 arch/x86/include/asm/proto.h     |   4 --
 4 files changed, 65 insertions(+), 106 deletions(-)

diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S
index 6100007fd03f..1fd5efaa99b3 100644
--- a/arch/x86/entry/entry_64.S
+++ b/arch/x86/entry/entry_64.S
@@ -371,6 +371,24 @@ SYM_CODE_START(\asmsym)
 		pushq	$-1			/* ORIG_RAX: no syscall to restart */
 	.endif
 
+	.if \vector == IA32_SYSCALL_VECTOR
+		/*
+		 * User tracing code (ptrace or signal handlers) might assume
+		 * that the saved RAX contains a 32-bit number when we're
+		 * invoking a 32-bit syscall.  Just in case the high bits are
+		 * nonzero, zero-extend the syscall number.  (This could almost
+		 * certainly be deleted with no ill effects.)
+		 */
+		movl	%eax, %eax
+
+		/*
+		 * do_int80_syscall_32() expects regs->orig_ax to be user ax,
+		 * and regs->ax to be $-ENOSYS.
+		 */
+		movq	%rax, (%rsp)
+		movq	$-ENOSYS, %rax
+	.endif
+
 	.if \vector == X86_TRAP_BP
 		/*
 		 * If coming from kernel space, create a 6-word gap to allow the
diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index 0051cf5c792d..a4fcea0cab14 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -311,105 +311,3 @@ sysret32_from_system_call:
 	swapgs
 	sysretl
 SYM_CODE_END(entry_SYSCALL_compat)
-
-/*
- * 32-bit legacy system call entry.
- *
- * 32-bit x86 Linux system calls traditionally used the INT $0x80
- * instruction.  INT $0x80 lands here.
- *
- * This entry point can be used by 32-bit and 64-bit programs to perform
- * 32-bit system calls.  Instances of INT $0x80 can be found inline in
- * various programs and libraries.  It is also used by the vDSO's
- * __kernel_vsyscall fallback for hardware that doesn't support a faster
- * entry method.  Restarted 32-bit system calls also fall back to INT
- * $0x80 regardless of what instruction was originally used to do the
- * system call.
- *
- * This is considered a slow path.  It is not used by most libc
- * implementations on modern hardware except during process startup.
- *
- * Arguments:
- * eax  system call number
- * ebx  arg1
- * ecx  arg2
- * edx  arg3
- * esi  arg4
- * edi  arg5
- * ebp  arg6
- */
-SYM_CODE_START(entry_INT80_compat)
-	UNWIND_HINT_EMPTY
-	/*
-	 * Interrupts are off on entry.
-	 */
-	ASM_CLAC			/* Do this early to minimize exposure */
-	SWAPGS
-
-	/*
-	 * User tracing code (ptrace or signal handlers) might assume that
-	 * the saved RAX contains a 32-bit number when we're invoking a 32-bit
-	 * syscall.  Just in case the high bits are nonzero, zero-extend
-	 * the syscall number.  (This could almost certainly be deleted
-	 * with no ill effects.)
-	 */
-	movl	%eax, %eax
-
-	/* switch to thread stack expects orig_ax and rdi to be pushed */
-	pushq	%rax			/* pt_regs->orig_ax */
-	pushq	%rdi			/* pt_regs->di */
-
-	/* Need to switch before accessing the thread stack. */
-	SWITCH_TO_KERNEL_CR3 scratch_reg=%rdi
-
-	/* In the Xen PV case we already run on the thread stack. */
-	ALTERNATIVE "", "jmp .Lint80_keep_stack", X86_FEATURE_XENPV
-
-	movq	%rsp, %rdi
-	movq	PER_CPU_VAR(cpu_current_top_of_stack), %rsp
-
-	pushq	6*8(%rdi)		/* regs->ss */
-	pushq	5*8(%rdi)		/* regs->rsp */
-	pushq	4*8(%rdi)		/* regs->eflags */
-	pushq	3*8(%rdi)		/* regs->cs */
-	pushq	2*8(%rdi)		/* regs->ip */
-	pushq	1*8(%rdi)		/* regs->orig_ax */
-	pushq	(%rdi)			/* pt_regs->di */
-.Lint80_keep_stack:
-
-	pushq	%rsi			/* pt_regs->si */
-	xorl	%esi, %esi		/* nospec   si */
-	pushq	%rdx			/* pt_regs->dx */
-	xorl	%edx, %edx		/* nospec   dx */
-	pushq	%rcx			/* pt_regs->cx */
-	xorl	%ecx, %ecx		/* nospec   cx */
-	pushq	$-ENOSYS		/* pt_regs->ax */
-	pushq   %r8			/* pt_regs->r8 */
-	xorl	%r8d, %r8d		/* nospec   r8 */
-	pushq   %r9			/* pt_regs->r9 */
-	xorl	%r9d, %r9d		/* nospec   r9 */
-	pushq   %r10			/* pt_regs->r10*/
-	xorl	%r10d, %r10d		/* nospec   r10 */
-	pushq   %r11			/* pt_regs->r11 */
-	xorl	%r11d, %r11d		/* nospec   r11 */
-	pushq   %rbx                    /* pt_regs->rbx */
-	xorl	%ebx, %ebx		/* nospec   rbx */
-	pushq   %rbp                    /* pt_regs->rbp */
-	xorl	%ebp, %ebp		/* nospec   rbp */
-	pushq   %r12                    /* pt_regs->r12 */
-	xorl	%r12d, %r12d		/* nospec   r12 */
-	pushq   %r13                    /* pt_regs->r13 */
-	xorl	%r13d, %r13d		/* nospec   r13 */
-	pushq   %r14                    /* pt_regs->r14 */
-	xorl	%r14d, %r14d		/* nospec   r14 */
-	pushq   %r15                    /* pt_regs->r15 */
-	xorl	%r15d, %r15d		/* nospec   r15 */
-
-	UNWIND_HINT_REGS
-
-	cld
-
-	movq	%rsp, %rdi
-	call	do_int80_syscall_32
-	jmp	swapgs_restore_regs_and_return_to_usermode
-SYM_CODE_END(entry_INT80_compat)
diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
index 1345088e9902..38cb2e0dc2c7 100644
--- a/arch/x86/include/asm/idtentry.h
+++ b/arch/x86/include/asm/idtentry.h
@@ -204,6 +204,20 @@ __visible noinstr void func(struct pt_regs *regs,			\
 									\
 static noinline void __##func(struct pt_regs *regs, u32 vector)
 
+/**
+ * DECLARE_IDTENTRY_IA32_EMULATION - Declare functions for int80
+ * @vector:	Vector number (ignored for C)
+ * @asm_func:	Function name of the entry point
+ * @cfunc:	The C handler called from the ASM entry point (ignored for C)
+ *
+ * Declares two functions:
+ * - The ASM entry point: asm_func
+ * - The XEN PV trap entry point: xen_##asm_func (maybe unused)
+ */
+#define DECLARE_IDTENTRY_IA32_EMULATION(vector, asm_func, cfunc)	\
+	asmlinkage void asm_func(void);					\
+	asmlinkage void xen_##asm_func(void)
+
 /**
  * DECLARE_IDTENTRY_SYSVEC - Declare functions for system vector entry points
  * @vector:	Vector number (ignored for C)
@@ -430,6 +444,35 @@ __visible noinstr void func(struct pt_regs *regs,			\
 #define DECLARE_IDTENTRY_ERRORCODE(vector, func)			\
 	idtentry vector asm_##func func has_error_code=1
 
+/*
+ * 32-bit legacy system call entry.
+ *
+ * 32-bit x86 Linux system calls traditionally used the INT $0x80
+ * instruction.  INT $0x80 lands here.
+ *
+ * This entry point can be used by 32-bit and 64-bit programs to perform
+ * 32-bit system calls.  Instances of INT $0x80 can be found inline in
+ * various programs and libraries.  It is also used by the vDSO's
+ * __kernel_vsyscall fallback for hardware that doesn't support a faster
+ * entry method.  Restarted 32-bit system calls also fall back to INT
+ * $0x80 regardless of what instruction was originally used to do the
+ * system call.
+ *
+ * This is considered a slow path.  It is not used by most libc
+ * implementations on modern hardware except during process startup.
+ *
+ * Arguments:
+ * eax  system call number
+ * ebx  arg1
+ * ecx  arg2
+ * edx  arg3
+ * esi  arg4
+ * edi  arg5
+ * ebp  arg6
+ */
+#define DECLARE_IDTENTRY_IA32_EMULATION(vector, asm_func, cfunc)	\
+	idtentry vector asm_func cfunc has_error_code=0
+
 /* Special case for 32bit IRET 'trap'. Do not emit ASM code */
 #define DECLARE_IDTENTRY_SW(vector, func)
 
@@ -631,6 +674,10 @@ DECLARE_IDTENTRY_IRQ(X86_TRAP_OTHER,	common_interrupt);
 DECLARE_IDTENTRY_IRQ(X86_TRAP_OTHER,	spurious_interrupt);
 #endif
 
+#ifdef CONFIG_IA32_EMULATION
+DECLARE_IDTENTRY_IA32_EMULATION(IA32_SYSCALL_VECTOR,	entry_INT80_compat, do_int80_syscall_32);
+#endif
+
 /* System vector entry points */
 #ifdef CONFIG_X86_LOCAL_APIC
 DECLARE_IDTENTRY_SYSVEC(ERROR_APIC_VECTOR,		sysvec_error_interrupt);
diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h
index feed36d44d04..c4d331fe65ff 100644
--- a/arch/x86/include/asm/proto.h
+++ b/arch/x86/include/asm/proto.h
@@ -28,10 +28,6 @@ void entry_SYSENTER_compat(void);
 void __end_entry_SYSENTER_compat(void);
 void entry_SYSCALL_compat(void);
 void entry_SYSCALL_compat_safe_stack(void);
-void entry_INT80_compat(void);
-#ifdef CONFIG_XEN_PV
-void xen_entry_INT80_compat(void);
-#endif
 #endif
 
 void x86_configure_nx(void);
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:17:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:17:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242194.418937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuwv-000566-GO; Wed, 08 Dec 2021 11:17:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242194.418937; Wed, 08 Dec 2021 11:17:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muuwv-00055z-BT; Wed, 08 Dec 2021 11:17:25 +0000
Received: by outflank-mailman (input) for mailman id 242194;
 Wed, 08 Dec 2021 11:17:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muupK-0006Yt-HI
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:34 +0000
Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com
 [2607:f8b0:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 524ac4a9-5817-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 12:09:33 +0100 (CET)
Received: by mail-pf1-x431.google.com with SMTP id k64so2125210pfd.11
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:33 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id u12sm3355395pfk.71.2021.12.08.03.09.31
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:09:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 524ac4a9-5817-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=2ZAl8F0tOkzqNpxvhUmIBbQ/2XyCnM6LrThKg9k5W8s=;
        b=XewnByTcwGZ5HuWSJOktdkA8rXnpKBKFuSg0cxOJL7s3BdUvTPdODuZfLIDeepUm4V
         +UFNS5kKkZ64h2+SLoku6yR1tR/0A+eaTTMV6wH4OAgYBCykpmcbSC84xrwGT8DK5z6I
         NAwcRUWRE5xi4yleywYOHQ3Z+PAuijS3/ucoUSnX0O8roEEkMd3TMCNQi4/Nee7ynLP8
         YtGzd5gKmnV6H5WeuB2jtnHcA/FdVci05P8W9WFHdMj60WaDi0E67yIn6k7XYkXd2N/Q
         Pkh/hb3+/neA+1fwV3CX98BZZHeeXZYXum/i4O8YUwzfbt+j8AeThm8SubonZeZuOnPu
         cX4w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=2ZAl8F0tOkzqNpxvhUmIBbQ/2XyCnM6LrThKg9k5W8s=;
        b=kv374ynQI0pyIlCOzyxr+5oBLiXE81wJ3bq6fDQEQE8bx4Z7x6/3oe1kXlJLsYNDYH
         vUIH1GBIh5fqLOzVOkz0UTwlcaIHVw0evRpyesZRTBSFnQLJE1xZHgRTadlRKC7jIJx+
         cMg1z2X/Lopglqqs/glVZhs09EcPmonObNrrDoIVC/wmZzlvHQVG135HuzfyirSBouEz
         HVEXQ42nusY3dbeBMQTla0H3PgJALnkotqOOoEOduTG/4H0GVuVGxHPbMxCqAuuAMA4v
         GH9SGvUev2JwlKa31yAIHvHjJszGG5jxKPxeFj2RaaP834byw/5c2r/D/CWSP+Aa853h
         TkRQ==
X-Gm-Message-State: AOAM532T6wvRvpCrork+9Nv2pivEc6XpPv7fCgbQ9/sffqXyXIyQcG7B
	t6ateRPlL9gfTCBOiFxh/M0=
X-Google-Smtp-Source: ABdhPJw1j8OimGYb+Vk6xtTFU75lvQF/n3cAmCvhA4Lo654aq4frrTPh1GDeEbLLUScPSozJ7D8kIA==
X-Received: by 2002:a65:6a0b:: with SMTP id m11mr28632692pgu.372.1638961772554;
        Wed, 08 Dec 2021 03:09:32 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Joerg Roedel <jroedel@suse.de>,
	"Chang S. Bae" <chang.seok.bae@intel.com>
Subject: [PATCH 11/11] x86/entry: Remove the branch in sync_regs()
Date: Wed,  8 Dec 2021 19:08:33 +0800
Message-Id: <20211208110833.65366-12-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

In non-xenpv, the sp0 is the trampoline stack, and sync_regs() is
called on non-xenpv only since error_entry is not called on xenpv, so
the stack must be the trampoline stack or one of the IST stack and the
check in sync_regs() is unneeded.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/kernel/traps.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index a6c0bc9ee36f..63cdb7aedd67 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -708,13 +708,15 @@ DEFINE_IDTENTRY_RAW(exc_int3)
 /*
  * Help handler running on a per-cpu (IST or entry trampoline) stack
  * to switch to the normal thread stack if the interrupted code was in
- * user mode. The actual stack switch is done in entry_64.S
+ * user mode.  The actual stack switch is done in entry_64.S.  It is not
+ * called from XENPV and the caller has ensured it is not on the thread
+ * stack.
  */
 asmlinkage __visible noinstr struct pt_regs *sync_regs(struct pt_regs *eregs)
 {
 	struct pt_regs *regs = (struct pt_regs *)this_cpu_read(cpu_current_top_of_stack) - 1;
-	if (regs != eregs)
-		*regs = *eregs;
+
+	*regs = *eregs;
 	return regs;
 }
 
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:17:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:17:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242199.418948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muux9-0005bK-ON; Wed, 08 Dec 2021 11:17:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242199.418948; Wed, 08 Dec 2021 11:17:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muux9-0005bD-Ji; Wed, 08 Dec 2021 11:17:39 +0000
Received: by outflank-mailman (input) for mailman id 242199;
 Wed, 08 Dec 2021 11:17:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KNkV=QZ=gmail.com=jiangshanlai@srs-se1.protection.inumbo.net>)
 id 1muupE-0007Ud-1V
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:09:28 +0000
Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com
 [2607:f8b0:4864:20::102d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e6e9293-5817-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:09:27 +0100 (CET)
Received: by mail-pj1-x102d.google.com with SMTP id
 gf14-20020a17090ac7ce00b001a7a2a0b5c3so4089251pjb.5
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 03:09:27 -0800 (PST)
Received: from localhost ([47.251.3.230])
 by smtp.gmail.com with ESMTPSA id e4sm2315444pgi.21.2021.12.08.03.09.25
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 03:09:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e6e9293-5817-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=/Kd9tDbqkXgV+uDS+ZN2PkifPpO4nwWCGziDx4Ai290=;
        b=DZBRV+VFT9+KfIlW9vI1YNTWjjSwY9UVdpausVhNvxvTeFCAhQr4BL86f1ZVb5wqYx
         daMm0jsnf1EZop+hPS3Rsl+eU347P7jXAR0P3RT2+WtY7EQ2A2yWN79dg12hx04Hs3DY
         iR2cUpLa4sLw2jps+ZS2rPZ95nG7mTU3J1k/V23q7IYOzjDvAuCF7BShXIc9S6F75RGg
         tKsQ5jKl/9h3kXq8Er5D+XxIEwR7FRorkvKKVlKBNuLRh7xuwrknY5JB9iLYWlgPc5Ip
         brHSmlHdSmwtVh6ZsE/XtTcbGI9NZy6tbBUp6sONJacjKJ0aJI0Wz9IDXReHISQ2qhXx
         46UQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=/Kd9tDbqkXgV+uDS+ZN2PkifPpO4nwWCGziDx4Ai290=;
        b=ckuCa7xf9HC2M7SwH15Lt1z8BgwaooPpW6t1czVAVVQAPj06lA66j/cuEOg0gGDiq8
         qCMu924EbpK4NrVia2+RkulnNLNEmmVlIEhrZE3sfZhfYwHETvXuUEQ7fsRqFV0oXiVz
         Fz60KjtB3aCUkja55SN90v2hrrCWCV0inUl1cN5JkSQbFyUU0Swv5jZbJy1XcC0QJjH7
         NImcJZHjnV58vbz8ejbsIh21dgPHUsDeHcVAlLoTlIKhl2/g6P8MT0Ikj7Ygk5RtYE5A
         KG7LyTTj4NdV5VuZV5vGY69extgE9UzIJPzAAGJwD6uR41GAhlwjxcaCQz6nxrdlRlJX
         ABpQ==
X-Gm-Message-State: AOAM532DNMvkNCHxmy84mqytauBDn5WagnP9SatAoNoe912g8uN6bGNJ
	i1K7Rb/zvkyuFkgLCEvDjW8=
X-Google-Smtp-Source: ABdhPJwtuS/bFQhmnmbhADvj6guciKxV5lk7NvScGFOlc2udq8C8NxlaMojhnh/rnPK9YGSNXl3k8g==
X-Received: by 2002:a17:90a:e00c:: with SMTP id u12mr6251592pjy.139.1638961766047;
        Wed, 08 Dec 2021 03:09:26 -0800 (PST)
From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org,
	xen-devel@lists.xenproject.org,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Juergen Gross <jgross@suse.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: [PATCH 10/11] x86: Remove the definition of SWAPGS
Date: Wed,  8 Dec 2021 19:08:32 +0800
Message-Id: <20211208110833.65366-11-jiangshanlai@gmail.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
In-Reply-To: <20211208110833.65366-1-jiangshanlai@gmail.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Lai Jiangshan <laijs@linux.alibaba.com>

There is no user of the pv-aware SWAPGS anymore.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
 arch/x86/include/asm/irqflags.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/include/asm/irqflags.h b/arch/x86/include/asm/irqflags.h
index 87761396e8cc..ac2e4cc47210 100644
--- a/arch/x86/include/asm/irqflags.h
+++ b/arch/x86/include/asm/irqflags.h
@@ -140,13 +140,11 @@ static __always_inline void arch_local_irq_restore(unsigned long flags)
 #else
 #ifdef CONFIG_X86_64
 #ifdef CONFIG_XEN_PV
-#define SWAPGS	ALTERNATIVE "swapgs", "", X86_FEATURE_XENPV
 #define INTERRUPT_RETURN						\
 	ANNOTATE_RETPOLINE_SAFE;					\
 	ALTERNATIVE_TERNARY("jmp *paravirt_iret(%rip);",		\
 		X86_FEATURE_XENPV, "jmp xen_iret;", "jmp native_iret;")
 #else
-#define SWAPGS	swapgs
 #define INTERRUPT_RETURN	jmp native_iret
 #endif
 #endif
-- 
2.19.1.6.gb485710b



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 11:47:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 11:47:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242216.418959 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvPp-0001oy-4U; Wed, 08 Dec 2021 11:47:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242216.418959; Wed, 08 Dec 2021 11:47:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvPp-0001or-1S; Wed, 08 Dec 2021 11:47:17 +0000
Received: by outflank-mailman (input) for mailman id 242216;
 Wed, 08 Dec 2021 11:47:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=xuKF=QZ=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1muvPn-0001ol-E1
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 11:47:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95787b00-581c-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 12:47:13 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-0ucW3XftNB65WnOuLM1RzQ-1; Wed, 08 Dec 2021 12:47:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec
 2021 11:47:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.023; Wed, 8 Dec 2021
 11:47:10 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::16) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.20 via Frontend Transport; Wed, 8 Dec 2021 11:47:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95787b00-581c-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1638964033;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Ch3fblJtqZjhd2k1FVzLRRy+qIj6nn4X9h22JMOWea0=;
	b=F1kGytxoUkvM+w9RyGQO9pOtqHjKYGXHIXrd4pkwqr0iSFo5i+xWkq3rU+p5+rOpMGaUlZ
	CGa7efBSZe+JwWSD4hFqpCN/tzJPDxFAYzBheUSO/5p2aToCiP9FYpkZyds0nhJL+Jp7Cs
	VmP0FQWrB5N4vS8++2gQx3YS/PwICrk=
X-MC-Unique: 0ucW3XftNB65WnOuLM1RzQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BthPTaIjH1WJR7+Vzqmgg+5kBJZzYo7rE6XmYAxvEKT5gRVYj2qsG97/rUd7f2TKg91NwDEcLl17dT3JkN2bVTtPAub2pDG59nkCSdUHY9w/R+oWigd399ZKpECZZGwtPPnluXZLwTbKuwIzriSCuD+I42lrvJOc+l4Q4HeUxykONUXKKEHyySy2gECJwZATcp30Y+QRC6fPjEgZ2hErpBThQF9O3YgKtprPALMYbCr1VzT/R+IhsA6z5pNiAz/3IqmkWumdTxLtp4MPVdx0m/gdEyW5Y1UO+PAHXvCruWDd76xY5Poa7TmdhWVV/i2jyLrHIBn1z289q0jXc86XTQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ch3fblJtqZjhd2k1FVzLRRy+qIj6nn4X9h22JMOWea0=;
 b=ibdUzomx+yUHfvoakpeTM/FkyRO6fE16y3W9qq+MMm7EKHNaUOOXq0II4eic/hIDVsBl67+SgfenXSLdB0SPm935z1za5PyvzB8pRKdY/pLAT/3fZy/y3Ni3Qnaf5lFIM1y5sCRl3pwe8n/By1RfEeOC1WiTXUmWhIHAaI3dAkNmYhIfnt2htlVmO9IO7NRTBnoMKVZKTp8cvIS3SXcLNyM6otUyz19q0A4/j7x0vlLARUBKr2VGbmj9Cy+rRAGpkZ9pnQ05Z59u+GHVZzi8KFmEAfwrVATRcwCEqaPYkoAjyvyFIqZC/Cf3unIHEkRNX+qc2VJZ733NlmsNlm9iuQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <935688c8-c971-53c7-4c27-f34a841168ec@suse.com>
Date: Wed, 8 Dec 2021 12:47:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: avoid wrong use of all-but-self IPI shorthand
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0006.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5fd009ad-a3ff-44d5-3d03-08d9ba4077f4
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71501D3C6CB37FEDE71CBE92B36F9@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	w49F342N8Qe6RNfsPeNylYgJkvQ+4le7viREfKF0J/9VzoKy6ekNuZ66DKs2zJuIjwAU9sXJFDiMZEAWcqrt0lk9Dpj/i+1pGUcWP3Z/p11VI9p1nv/YaNbcaMc+q2aIk6VFY/RIvkxC3E2LA7GFqhT7qwf1AVUmmz5n9TuZ8oIkD46kL0kmBOIqs4k4ko76qHZUlLMUKSA2JmX2UloG8Z4Md3vnLLm7ybKs655CRW2L0y8UkpyB69xOwIhU19LIE6PvT8M6SEOcbxn8yNZ9ZVbjjFLVu5S2TgmYbicloevOCFvGfPjYgLazPAedgyFPRBcIpVVW/q6Da85X0mEgX2sEgzViSAD/KHS3RuAJ8s8sIIk9dk6GmswBxm6iIw++DN5lmiCUzyGXHaG1A7cdcooTkGz9YO4gRLIpRYU2EqS0BSpRCyUKInM511AHGNNnDIfxN1dEC/r5GxndVreY9nlWBuZqgxTjukFURsy63aWIHL3Xl/E8tjzrbDzjbh+PcaqRRdRzuHXmjSztGi91EsHFuQDcukBtSjcxet3AchJtZ+OKDnCLpsv4pmYGwZQ6f9OYhLfgVijauAyqZtlZ+bQplowoKC626fRMt2WXjh+X0053cMKHiNeyl6a5SuyPXqc0aFNJ6hW0sSQ8teT907s9LdPI+UdJmm/PexUCPQ8CFsffz3w6OWTPHfsBMguVJFMQnTvAIMjqlu+WuamkR0S3XQtQBgCtDmQaYX4EF/g=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(5660300002)(8936002)(2616005)(36756003)(31696002)(4326008)(38100700002)(8676002)(26005)(83380400001)(6916009)(186003)(54906003)(2906002)(66476007)(66556008)(66946007)(316002)(16576012)(31686004)(86362001)(508600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U2RhT0N1OHF2emVNdmV6K0llWDVCaW5ncnd6bnVFR1RvZFdsb0FqNHladkN6?=
 =?utf-8?B?OXFwTzVSQ1dFcjVUNXJ0UDRWYmFpZGhaR1hIc2liNEpsa3lJM29hRlRubEht?=
 =?utf-8?B?OW1KaUxhaXo3MjBHMm4rVW5UczVoWUIvNUFhc3BteXVRK0R0dXpPV3g4dEQ1?=
 =?utf-8?B?WHNkN3cyV3BSdHk2Q05WWkNiZFRmTU1NNE5QczY0T2ZJdkVJWXpSOC90K0NT?=
 =?utf-8?B?aWJPRi8yT1ltR2Rnb3Q5ZjFVODk5TnJrY3c5NldCeTd3bDlvSlFGazZLWEJh?=
 =?utf-8?B?K2tNR256MFNpaW5QSHFscEptenU1cUtEaVBKRUhHbk1BMFlnYm9mRjNLK1Ay?=
 =?utf-8?B?SWtBODdCanh4VGRIQzNUcWw3VGRzZTYwemlNL0gvalJuSTdGRkVHVFZmQngy?=
 =?utf-8?B?dlVzWmdXanI1NGpUek5iQk45bWpFb2dPU043K1BzaCt1Y0laR2h3OGMwVjN2?=
 =?utf-8?B?a1lJMExEc1R0YndVT0lHaGdkZ09lYkk2SmpSUnNsZWdwY1Q0dFo3QkwzQ0Fm?=
 =?utf-8?B?ZEpWd0V2ZnhDd3BqQ3BxeHhpYVVxMXN5L01NU3ZMdVFLeVM3OEx0MnRTaXRM?=
 =?utf-8?B?dldYN2h1UWNPQVQrcG1DUFhldzVEVzBUTkc2eXFMcnJCeFBSYlFKWFJ4UlNq?=
 =?utf-8?B?WnNGKzlraHNLKzB1NXlLV1NNS0JTRVpRRjJ4QitFMjlNMFlDK3lqWHhjSDhs?=
 =?utf-8?B?MnFLL1ZKWVRNOVdVekVQVEt0TnREd3dqcWpsTlEwVFFvVkVtWjljWnljUFMz?=
 =?utf-8?B?cklrQzZnejU4SThKUW1XbUh1YkZKWjhpVWRtQTgrKzFtdWNqU0V3M05EU0dH?=
 =?utf-8?B?ckk2czRyemZzbVlJKzJlVGtNNHU4bzlpSVZaTUFUaC9VUm14dlRpdC9zNHhL?=
 =?utf-8?B?Z2Zud2hOUjlyK1JXQzc1VGxsalRWWXJEYkRvZ01ycHpSUzBUR3owd3o0S2Nu?=
 =?utf-8?B?NWw2N3RqVnhoazh0d2N3MjlYaW1Zckp6KzE2ZEFsaUdFV2NJVmRIOElnekxU?=
 =?utf-8?B?T1o4QUNQdGlDUkhOelU2SnZXNDVYeEZoVk1HUC9mODVQbHdVdFh5UnhqV1pO?=
 =?utf-8?B?V0FYenEwaVVKeEtWa1hweUlYNDMrNzcyMXRZY0tPUHNWL3JWd0NoOXZ3SVdP?=
 =?utf-8?B?Q21XVExhVi94MHJ1SlAvbnJFVlY4bjZhRVpPMXg1cGpDM28rdmk5N29XU3BG?=
 =?utf-8?B?NXhJa2JXd2FuYitDL2tFYlYrY2JmZGFxVmliNzN1b2FsWmEvWHRNVEplRWJ5?=
 =?utf-8?B?eG8rWklDU0RWZ05TRVpuaG1hWEU2aDlqYjR1K1pyT2Rxdmp3cWtuM3JyclU1?=
 =?utf-8?B?ZWIwR2lTem0rMzh0bUtUU0h0N3BDRWlNNFhnU2FKTHNsMXh3Y3JycVVZb1hW?=
 =?utf-8?B?UU9USDVSOFZHWkRrMXpVMWlGNDNDOTM4cWl2QVZGbnFHZTNvV0QyaHMvZk8z?=
 =?utf-8?B?Um1ZWWQvSW9kczVzV294cENSZ1FxYjd3NVU2b3V6ZWhxcXlYTDhYeEF1OWtT?=
 =?utf-8?B?K1pFVVhvS1ovSFpIeEVVb0p1Y1hndFZmWTJrU0o3Z25RWlRMWGpDNllQaVN2?=
 =?utf-8?B?Rmp2ODR2YjVNdlRhbXFhWnREUC9oSEx5eDdRd2lsaVRuamZ0UndiaWpiTWpq?=
 =?utf-8?B?c0xGVGJJek45cGJNSUtvSTZRS1FJNHdmVjNUOUNQVlVIeGJORThkUXdvNWg5?=
 =?utf-8?B?UEJ2WFFFZmNvdHFCYS9hcDJIWGdSajlRM1pzVzhTaDNhYWNnNFBkUWRSSk5V?=
 =?utf-8?B?bU9maWJndHhaSFQvMVFtWlp5UXpRWUxsYkxtU3F5WUtEMDFRVFlPUlMzKzNN?=
 =?utf-8?B?MUVrYmN6Zk9YNUJ1ZENtVXYvSUhUSCs4TXorYitnZ1JTVEpXVzZ6Unp2d2kv?=
 =?utf-8?B?TW1QcEJkMmFGMFVLcUttZnozS2NoTVQ1ajJjZDRKUXo2THZUMUlwWUd5dzVF?=
 =?utf-8?B?T2l3WWJncEJKQ1lSQlV1WklOMURBaWtZL1ZFbUc2bmdqYzMxSE56YkxUN1JL?=
 =?utf-8?B?bkhGUWFBSDk5SUw0ZjNqYVh2MnFxZllSb1BHNXdVVjhVMkpDMUNKUFpUaWc2?=
 =?utf-8?B?enlSTndMWGhiSkExMWFKUTZpaEVKc3FlSHIzTC80Sk1CdEk1aDRVRjZvYlJw?=
 =?utf-8?B?K0E0TllBQmpmRElaWTAwNS80ejUydGl2Qm1WcGNUZ3JQeGZVQ3JYMDFVZHhj?=
 =?utf-8?Q?/8Wpv9u7md9OMLAiAsdBXww=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd009ad-a3ff-44d5-3d03-08d9ba4077f4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 11:47:10.4533
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UtQqG9IjhXxoeau6wZvC+j8ipG6o10FwjeoxPbvl/yUnYszEp2S96LfLvwDXL4e3wiqsPlw9TQnvRhVWbWi4lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

With "nosmp" I did observe a flood of "APIC error on CPU0: 04(04), Send
accept error" log messages on an AMD system. And rightly so - nothing
excludes the use of the shorthand in send_IPI_mask() in this case. Set
"unaccounted_cpus" to "true" also when command line restrictions are the
cause.

Note that PV-shim mode is unaffected by this change, first and foremost
because "nosmp" and "maxcpus=" are ignored in this case.

Fixes: 5500d265a2a8 ("x86/smp: use APIC ALLBUT destination shorthand when possible")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While in "nosmp" mode it's probably benign that we switch to the bigsmp
APIC driver simply because there are more than 8 physical CPUs, I
suppose that's inefficient when "maxcpus=" with a value between 2 and 8
(inclusive) is in use. Question is whether that's worthwhile to find a
solution for.

--- a/xen/arch/x86/mpparse.c
+++ b/xen/arch/x86/mpparse.c
@@ -84,9 +84,14 @@ void __init set_nr_cpu_ids(unsigned int
 	if (!park_offline_cpus)
 		tot_cpus = max_cpus;
 	nr_cpu_ids = min(tot_cpus, NR_CPUS + 0u);
-	if (park_offline_cpus && nr_cpu_ids < num_processors)
-		printk(XENLOG_WARNING "SMP: Cannot bring up %u further CPUs\n",
-		       num_processors - nr_cpu_ids);
+	if (nr_cpu_ids < num_processors)
+	{
+		unaccounted_cpus = true;
+		if (park_offline_cpus)
+			printk(XENLOG_WARNING
+			       "SMP: Cannot bring up %u further CPUs\n",
+			       num_processors - nr_cpu_ids);
+	}
 
 #ifndef nr_cpumask_bits
 	nr_cpumask_bits = ROUNDUP(nr_cpu_ids, BITS_PER_LONG);



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 12:00:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 12:00:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242228.418986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvck-0004gV-Se; Wed, 08 Dec 2021 12:00:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242228.418986; Wed, 08 Dec 2021 12:00:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvck-0004gO-PS; Wed, 08 Dec 2021 12:00:38 +0000
Received: by outflank-mailman (input) for mailman id 242228;
 Wed, 08 Dec 2021 12:00:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muvcj-0004g6-Tv; Wed, 08 Dec 2021 12:00:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muvcj-0004Yn-Ol; Wed, 08 Dec 2021 12:00:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muvcj-000723-BF; Wed, 08 Dec 2021 12:00:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muvcj-0005WG-Am; Wed, 08 Dec 2021 12:00:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eKsuap+QBGXgXD7LgPIoRpPfZwPruKNMkIq/Zge3doc=; b=AaXVWagUxml02gmyoOPWv1JRIj
	/B3i1xTe8mjnbzELT6g8OCgoFMgHGZqDxFtj4o42loaHB2IqifReDulnPjRi92eIa9MakMjX9HEy/
	wWlcjmQB8Y+hqKQFixmzjf5nhacggNWrNeRyhciPecAYb8SH7Byjofp7y2Cb8K196/FY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167223-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167223: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-saverestore:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
X-Osstest-Versions-That:
    xen=ea0c08bc77fe7bd7e4e65c648e17752e91912d01
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 12:00:37 +0000

flight 167223 xen-unstable real [real]
flight 167233 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167223/
http://logs.test-lab.xenproject.org/osstest/logs/167233/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm  17 guest-saverestore   fail pass in 167233-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167210

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167210
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167210
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167210
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167210
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167210
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167210
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167210
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167210
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167210
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167210
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167210
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167210
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1
baseline version:
 xen                  ea0c08bc77fe7bd7e4e65c648e17752e91912d01

Last test of basis   167210  2021-12-06 11:25:36 Z    2 days
Testing same since   167223  2021-12-07 01:40:36 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Ian Jackson <ian.jackson@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Tim Deegan <tim@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   ea0c08bc77..608531a0cc  608531a0cc34a5bc096ccf585e16f182b5ed83e1 -> master


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 12:00:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 12:00:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242232.419008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvd2-00058C-9v; Wed, 08 Dec 2021 12:00:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242232.419008; Wed, 08 Dec 2021 12:00:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muvd2-000584-6j; Wed, 08 Dec 2021 12:00:56 +0000
Received: by outflank-mailman (input) for mailman id 242232;
 Wed, 08 Dec 2021 12:00:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=90lV=QZ=arm.com=andre.przywara@srs-se1.protection.inumbo.net>)
 id 1muvd1-00056B-CO
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 12:00:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 7db73811-581e-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 13:00:52 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 397D91042;
 Wed,  8 Dec 2021 04:00:52 -0800 (PST)
Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com
 [10.121.207.14])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1217D3F73B;
 Wed,  8 Dec 2021 04:00:50 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7db73811-581e-11ec-9d12-4777fae47e2b
Date: Wed, 8 Dec 2021 12:00:48 +0000
From: Andre Przywara <andre.przywara@arm.com>
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>, Ayan Kumar Halder
 <ayan.kumar.halder@xilinx.com>, "xen-devel@lists.xenproject.org"
 <xen-devel@lists.xenproject.org>, "sstabellini@kernel.org"
 <sstabellini@kernel.org>, "stefanos@xilinx.com" <stefanos@xilinx.com>,
 "Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
 "jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [XEN v2] xen/arm64: io: Decode 32-bit ldr/str post-indexing
 instructions
Message-ID: <20211208120048.63fbf49b@donnerap.cambridge.arm.com>
In-Reply-To: <4315f3f8-4431-3257-dc95-a3089532237b@xen.org>
References: <20211129191638.19877-1-ayankuma@xilinx.com>
 <20211130094950.1bf368d6@donnerap.cambridge.arm.com>
 <a69d41f1-7b57-c127-ae73-2de5a581dddd@xilinx.com>
 <D8811539-65F2-4D40-BFEF-CE72EA8E902A@arm.com>
 <4315f3f8-4431-3257-dc95-a3089532237b@xen.org>
Organization: ARM
X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 6 Dec 2021 19:31:06 +0000
Julien Grall <julien@xen.org> wrote:

Hi,

> On 01/12/2021 08:41, Bertrand Marquis wrote:
> > Hi Ayan,
> >   
> >> On 30 Nov 2021, at 19:13, Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> >>
> >> Hi Andre,
> >>
> >> Thanks for your comments. They are useful.
> >>
> >> On 30/11/2021 09:49, Andre Przywara wrote:  
> >>> On Mon, 29 Nov 2021 19:16:38 +0000
> >>> Ayan Kumar Halder <ayan.kumar.halder@xilinx.com> wrote:
> >>> Hi,  
> >>>> At the moment, Xen is only handling data abort with valid syndrome (i.e.
> >>>> ISV=0). Unfortunately, this doesn't cover all the instructions a domain
> >>>> could use to access MMIO regions.
> >>>>
> >>>> For instance, Xilinx baremetal OS will use:
> >>>>
> >>>>          volatile u32 *LocalAddr = (volatile u32 *)Addr;
> >>>>          *LocalAddr = Value;
> >>>>
> >>>> This leave the compiler to decide which store instructions to use.  
> >>> As mentioned in the other email, this is wrong, if this points to MMIO:
> >>> don't let the compiler do MMIO accesses. If a stage 2 fault isn't in
> >>> an MMIO area, you should not see traps that you cannot handle already.
> >>> So I don't think it's a good idea to use that as an example. And since
> >>> this patch only seems to address this use case, I would doubt its
> >>> usefulness in general.  
> >> Yes, I should have fixed the comment.
> >>
> >> Currently, I am testing with baremetal app which uses inline assembly code with post indexing instructions, to access the MMIO.
> >>
> >> ATM, I am testing with 32 bit MMIO only.
> >>
> >> On the usefulness, I am kind of torn as it is legitimate for post indexing instructions to be used in an inline-assembly code for accessing MMIO. However, that may not be something commonly seen.
> >>
> >> @Stefano/Bertrand/Julien/Volodymyr :- As you are the Arm mantainers, can you comment if we should have decoding logic or not ?  
> > 
> > Andre gave you the official statement from Arm and there is nothing more I can say.  
> 
> I think this would be handy for other hypervisor and OS developper to 
> know what they can expect when running in a virtualized environment. So 
> would it be possible to update the Arm Arm reflecting this statement?

I don't think it's within the scope of the ARM ARM to say that. It just
says that "there is no syndrome information", and your mileage may vary in
working around that.

Personally I would say that if you expect your software to work nicely
under a hypervisor, then just avoid those instructions. The Linux kernel
certainly did so.

You can try to do instruction emulation, but doing this right can get
tricky quickly: think about I$/D$ coherency, MMU on or off, etc.

> > I will leave this decision to Stefano and Julien.  
> 
> I have had a chat on IRC with Stefano about this. I think the main 
> sticking point is the Arm Arm doesn't clearly state those instructions 
> should not be used by a virtualized OS on MMIO regions.

I don't understand why the ARM ARM would need to say that. Certainly you
realise that immediately when trying to use them, and apparently it was not
a problem in the last 8ish years of Xen/ARM's existence.

So it's your decision on having the emulation, I personally would only do
it when there is a *good* use case.
And please apply the demanded scrutiny on the review - including all the
corner cases like Rn=Rt, XZR vs. SP (as Jan said) and possibly MMU status.

Cheers,
Andre

> To me, this topic looks similar to the set/way instruction dilemma. They 
> are a pain to virtualize (and the Arm Arm clearly hint it) but we had to 
> do it because some OSes relied on them.
> 
> I think the main difference is the Arm Arm doesn't hint they should not 
> be used (it only says a valid syndrome is not provided) and the 
> implementation should hopefully be smaller and self-contained.
> 
> So I would be inclined to allow Xen to decode post-indexing instructions 
> (pending the review).
> 
> Cheers,
> 



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 12:26:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 12:26:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242246.419022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muw1U-00008v-CZ; Wed, 08 Dec 2021 12:26:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242246.419022; Wed, 08 Dec 2021 12:26:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muw1U-00008o-9c; Wed, 08 Dec 2021 12:26:12 +0000
Received: by outflank-mailman (input) for mailman id 242246;
 Wed, 08 Dec 2021 12:26:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muw1S-00008i-Kk
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 12:26:10 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muw1S-0004yN-IS
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 12:26:10 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <iwj@xenproject.org>) id 1muw1S-0007k6-HQ
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 12:26:10 +0000
Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89)
 (envelope-from <iwj@xenproject.org>)
 id 1muw1J-0000Jm-E2; Wed, 08 Dec 2021 12:26:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date
	:Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From;
	bh=uJXxfR7j8sDohJ2+l/ENoFnAV2xbAa1fCRYOFh+/PQA=; b=nPIglgG7ZCej4kGSdT27Qb6qkm
	TQjoseY+K5T+Gy5UW0LnxTv8KsrcsgQsUzx6V7lYpzEA/n6tPBEGIJNoBH8QDHxLufuwuVTEWyAUV
	H8L1+O9Y9ezCMkyEFcod1Zie161eQLoeSDbFaQGNCiaa8SqPlj0kcMOkNZJSGgrvdI+8=;
From: Ian Jackson <iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <25008.42059.134133.56142@mariner.uk.xensource.com>
Date: Wed, 8 Dec 2021 12:25:47 +0000
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel\@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
    Andrew Cooper <andrew.cooper3@citrix.com>,
    George Dunlap <george.dunlap@citrix.com>,
    Julien Grall <julien@xen.org>,
    Stefano Stabellini <sstabellini@kernel.org>,
    Wei Liu <wl@xen.org>
Subject: Re: [PATCH] MAINTAINERS: widen Anthony's area
In-Reply-To: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
References: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu)

Jan Beulich writes ("[PATCH] MAINTAINERS: widen Anthony's area"):
> As was briefly discussed on the December Community Call, I'd like to
> propose to widen Anthony's maintainership to all of tools/. This then
> means that the special LIBXENLIGHT entry can go away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

FWIW

Acked-by: Ian Jackson <iwj@xenproject.org>

I have full confidence in Anthony here.

Ian.


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 13:43:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 13:43:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242255.419033 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxDx-0002Kq-8q; Wed, 08 Dec 2021 13:43:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242255.419033; Wed, 08 Dec 2021 13:43:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxDx-0002Kj-5x; Wed, 08 Dec 2021 13:43:09 +0000
Received: by outflank-mailman (input) for mailman id 242255;
 Wed, 08 Dec 2021 13:43:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cpXy=QZ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muxDw-0002Kd-GW
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 13:43:08 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c51c6a8d-582c-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 14:43:05 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44972)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muxDs-000n2o-2L (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 08 Dec 2021 13:43:04 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6FB7B1FB51;
 Wed,  8 Dec 2021 13:43:04 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c51c6a8d-582c-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
Date: Wed, 8 Dec 2021 13:43:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
In-Reply-To: <20211208084745.31082-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 08/12/2021 08:47, Juergen Gross wrote:
> The HVM parameters for pre-allocated event channels should be set in
> libxenguest, like it is done for PV guests and for the pre-allocated
> ring pages.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>

I'm not sure that we have the concept of pre-allocated ring pages.

For PV, we have:

    dom->console_pfn = xc_dom_alloc_page(dom, "console");
    if ( dom->console_pfn == INVALID_PFN )
        return -1;
    xc_clear_domain_page(dom->xch, dom->guest_domid,
                         xc_dom_p2m(dom, dom->console_pfn));

and for HVM, we have:

    dom->console_pfn = special_pfn(SPECIALPAGE_CONSOLE);
    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);

With a suitable tweak to the commit message (probably just deleting the
final clause), Reivewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

That said...

> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index fe9f760f71..c9c24666cd 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -723,9 +723,8 @@ out:
>  
>  static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
>                                  libxl_domain_build_info *info,
> -                                int store_evtchn, unsigned long *store_mfn,
> -                                int console_evtchn, unsigned long *console_mfn,
> -                                domid_t store_domid, domid_t console_domid)
> +                                unsigned long *store_mfn,
> +                                unsigned long *console_mfn)
>  {
>      struct hvm_info_table *va_hvm;
>      uint8_t *va_map, sum;
> @@ -752,8 +751,6 @@ static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
>  
>      xc_hvm_param_get(handle, domid, HVM_PARAM_STORE_PFN, &str_mfn);
>      xc_hvm_param_get(handle, domid, HVM_PARAM_CONSOLE_PFN, &cons_mfn);

... these are junk too.  I'm dismayed at how much of the toolstack tries
passing function parameters via HVM_PARAMS.

libxl's HVM path ought to mirror the PV path and, after
libxl__build_dom() is called, just read the values back out:

state->console_mfn = dom->console_pfn;
state->store_mfn = dom->xenstore_pfn;


That then leaves hvm_build_set_params() doing nothing but adjusting the
HVM info table for real HVM guests.  dom->max_vcpus is already present
which covers 2 of the 3 fields, leaving only the ACPI boolean left to pass.

So by passing the ACPI boolean down, we get rid of
hvm_build_set_params() entirely, which seems like a very good move.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 13:46:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 13:46:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242262.419044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxHW-0002wT-Pd; Wed, 08 Dec 2021 13:46:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242262.419044; Wed, 08 Dec 2021 13:46:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxHW-0002wM-M7; Wed, 08 Dec 2021 13:46:50 +0000
Received: by outflank-mailman (input) for mailman id 242262;
 Wed, 08 Dec 2021 13:46:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=V0Nt=QZ=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1muxHU-0002wG-Qw
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 13:46:48 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0614.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::614])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 496d64e1-582d-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 14:46:47 +0100 (CET)
Received: from AM5PR0301CA0025.eurprd03.prod.outlook.com
 (2603:10a6:206:14::38) by AM4PR08MB2900.eurprd08.prod.outlook.com
 (2603:10a6:205:e::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Wed, 8 Dec
 2021 13:46:44 +0000
Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:14:cafe::3) by AM5PR0301CA0025.outlook.office365.com
 (2603:10a6:206:14::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend
 Transport; Wed, 8 Dec 2021 13:46:44 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Wed, 8 Dec 2021 13:46:42 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Wed, 08 Dec 2021 13:46:42 +0000
Received: from 22e22816fbae.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 031EE663-0762-4642-BF53-9A86A1041417.1; 
 Wed, 08 Dec 2021 13:46:27 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 22e22816fbae.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 08 Dec 2021 13:46:27 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM6PR08MB3207.eurprd08.prod.outlook.com (2603:10a6:209:42::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Wed, 8 Dec
 2021 13:46:26 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4778.012; Wed, 8 Dec 2021
 13:46:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 496d64e1-582d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5/fLOhJ8rRPRloLpiFmv5pwlcTPy2Ymt5Bv9DIYvP40=;
 b=xGzSi7zFkaUSihAeXErF4dtTOg5nD13k5GTfdTlqMITc09sGqth25vRyVaL+688qEq8x2relbpFaSaU59IUr0oAaAVNAQlDVVUlc2e2MltRbw5Yn2iVHPrfb0Clmh6tCYwpq4DxP7+/vJ8Iaar5Cj95jc1cSy1PMMSgWFEqLK0M=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 93a9b01d29f25717
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lxls+uMcbMwPuBmOMhyIjb4dVE6YM9LlWYIs/eIdGzzQuKCMaGiSh9HIOx+So0JUhr7f+niVW/xZDnQZ57kORy5/RF/2hmcVGoJ3h8uMki2dEWgwFXuKYBLwIOsJ7pe4ho3oXeh/XWCy+13VSvSOgbTpxlmXbHfNH5826+Y3/ndy0XMWf5tNrdoc12XQqvZn9sUXNqVhfNkUrDTZnkGmf2vO/nzC2jlM5JTDblj4qGrdAXOxXfQYBq+k9xxp9wjAA98A19ahAnx1EBYH5Nlq0LLRnbLuNzdhW1cZJfQNCJjz0HbBK9sNzyYDDE1XXOusT8ZxdssbnZ3suHCutT42nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5/fLOhJ8rRPRloLpiFmv5pwlcTPy2Ymt5Bv9DIYvP40=;
 b=mEPfZ3fnRS9BSWHVTamAGOetEpC9nSvZ9p/CVjMvak3NK8aZoYproCesBP6qePL8rYB5ghAv+tSv1fXtNMxcwXYdHRItey+ZeAnL9j4v2kbN25ZgpQMLISFQQSbsRsURYyqKnLS+sCkcIVqCS5JTySPw8JdD8WsVpIzXynP4tMJlWfmNYERmVXB4JvRix9E52pPwFwFxusTz9xzAYuLXf9MvTB3ck8kYMIjirRioFDMdODuyAoCzWbwW2P6vzBCX5j2zp2EuZVskowT5XTDxtdphTzego8pc4Jl/XO1C55vi6nzGkzIcOtiCgrJwTHOmEjltih4oQVdy0QvEtk83EQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5/fLOhJ8rRPRloLpiFmv5pwlcTPy2Ymt5Bv9DIYvP40=;
 b=xGzSi7zFkaUSihAeXErF4dtTOg5nD13k5GTfdTlqMITc09sGqth25vRyVaL+688qEq8x2relbpFaSaU59IUr0oAaAVNAQlDVVUlc2e2MltRbw5Yn2iVHPrfb0Clmh6tCYwpq4DxP7+/vJ8Iaar5Cj95jc1cSy1PMMSgWFEqLK0M=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Michal
 Orzel <Michal.Orzel@arm.com>
Subject: Re: Aarch64 stand-alone application for Xen
Thread-Topic: Aarch64 stand-alone application for Xen
Thread-Index: AQHX4lBBRwRMWKF0UkKA2OLT1/6XFKwVnPuAgBItSwCAAOUVgA==
Date: Wed, 8 Dec 2021 13:46:26 +0000
Message-ID: <5E51B1B3-9864-4F2F-9C8D-BBC22F7158DB@arm.com>
References:
 <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com>
 <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
In-Reply-To:
 <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 5be199e8-a4ea-4fb8-d0bb-08d9ba512b0e
x-ms-traffictypediagnostic:
	AM6PR08MB3207:EE_|AM5EUR03FT019:EE_|AM4PR08MB2900:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB29006F1AE0E635BBF776D2E09D6F9@AM4PR08MB2900.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 DuUM6VKpNx1b7r9tFrNp3g7ubFpiJVWVOH9qfajOvVRHgpuZN0qSbmyEgASiwEy4zgBay5B/1K5MAlbUP9oEtdU1NkU/zhwYDUKLFfh7jizVEG4zZPJYDY8oOlR1PdWpYIvSlSjHPLEYXTeu/y1fNmlN4+6SdtNnB7tHFxf2/tEX0kJllFLDcA+Wjf5mHd0MSpmMOYU2QhyexaL4ZHrsljqhWKLaXcLjFjiFcFUfm4zq8y1/fw6DbElC7AwXAcKExyu+MvLOwUS8eqcVcI7IKahgjpuqOhWysRm0c2r/DtzVjwRm6znqQu6tmj0MpOb5AAXcgDiS4JvPyPp6HfuEglJkYEDYkMiCmvSyoa1eVYWv9ayPzds7B9pxmqeKp0wpGbgVtJ9vPHWpKofB7Hn7SMoqn/e7ZqjMHu0HIVUEbOdwIc61nIv1//qX1vkFYrVNHHiw8XHByQijugI7V1iW29Uxv2EFBK9S7UyS2ZrgeNcxb2kV1X4HRp3Qxmisu0BmPsgoB2chkjweTmjpELsdYpalJv8XwuLp7oElJh0QWmw08bDb/NQROiHNZu9K9lUYD4aZ1U3mBDegfTs4g08RSfa2x1TjGC6/Rf8eUFUEIJ0IS7v6kxzssBfhp5Lms52fNj1gQYChZns7dw4TjolwmHJvmYmNB3UiKdw6xgJ81jmgcqIeWIaHEjLDVpZHJ7yUv02MCvBzq9YJVfjJB6vcn6n9JRgNUpEfHLXmoPfyklCe7daMfidiUSXY3Dw1EKSLfLlC2KatzVm7sHR69nLwJzLW+UNbBU5cv4W9hPzqSlmiygOTv3oJ2f61x9vcE8hju7Rb40GwatG4vJJP6GqS2gb5E/HOtjNDbjAfCZDxcwc7M8LBNb65RwbAXflR5biD
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(122000001)(8676002)(33656002)(966005)(4326008)(508600001)(86362001)(8936002)(316002)(54906003)(83380400001)(91956017)(6916009)(6486002)(36756003)(76116006)(66446008)(64756008)(66946007)(66476007)(66556008)(5660300002)(6512007)(6506007)(53546011)(26005)(2616005)(71200400001)(2906002)(38070700005)(186003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <006581CB0012B348BDDC4DAE0571BF10@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3207
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c1d231ca-a438-48f4-e933-08d9ba51214f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U6oIxIo14ueXY/Cv0B9D71KB7VLquc04wLBI+vj1ryDoEwIDxBae+zUtTbUybsSFEzUJMt3W6AZ25lks7syXT3sEv4h6BfZSvHJi1k86HkZ2BfpDUuDSZ7V85wUK7+kInzMRyDcprZEwPL8gB8MFcQGbmgwHmlPX34GPpK2Vi5wqtM7Lkzm12KJdWGKElFqWIuOVeEeBd8rg8oSGCjxSds2HrIyNFCzztcjRGHXnWn9D0AvTkVK0cQttnIPwGdrmcQGIshyEOxTGSpEOXpziHohBK975jCEiYQAOcd0oKXBzb4p/m3HnUALsn6hu4TXF7CftUW2kimyxH4ygtRIhkcEwXHizIc3s4r4VX5lRJIFSioq1Ba9MVtKNwRvB2XKs6g6M/rFAwUfj13wbrjrRMdJq62H0jrm0N5qVHH83sMB4nh1/TnUW9wYVslvZadPWGktBsRg3kSXVDzIHfb6Nmc46vvdqbhRwXZs3QLTQ6+J6nRXxaZeF0rGoWGVC0qDuTiwtURZ43tw+DTjrL9pX7I7Scb1u2IaUAp6KTTr6u+ntyAE3S2FT21FVujLzFQQDtDYhPPvryA+fX0lvkVsfUGhj+xzGpl61SeJaR3c4lN4lHAD4RE7UoYWfGUfNCAdiok0GSZjvtt7a5sxMwiVuwD75FdgkCGqLT+cx3ddsuYcF3IsE891GOIGiUHpjFqP6PwuDW9Ko7MUfm2/buaOJpeaJIEdN/mT25+aWYqjGtq0qWxWxP6sXNjmwLCdcDDu3LdpM39wYDB1jbx3MuvUHev0B/ByguKUD9g20+bfxv6uzeT1HAHfcsvVonvTl4zyG8a25oJr0tQAoMqwAndBD2F+YmgIgmTpZGlqn8qcAQWDHJUq5bPm34w/Ez+WCY+WwYrkPzBrwnv0G0ye3M9DWudLaYxBEXJodYL/sJYm0W6s=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(8936002)(54906003)(47076005)(6512007)(186003)(63370400001)(53546011)(63350400001)(82310400004)(316002)(26005)(40460700001)(6506007)(83380400001)(508600001)(86362001)(356005)(6862004)(36756003)(36860700001)(5660300002)(2906002)(70206006)(6486002)(33656002)(4326008)(70586007)(8676002)(2616005)(336012)(966005)(81166007)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 13:46:42.6363
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5be199e8-a4ea-4fb8-d0bb-08d9ba512b0e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2900

Hi Mathieu,

> On 8 Dec 2021, at 00:06, Mathieu Poirier <mathieu.poirier@linaro.org> wro=
te:
>=20
> Hi Bertrand,
>=20
> On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com>=
 wrote:
>>=20
>> Hi Mathieu,
>>=20
>>> On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> =
wrote:
>>>=20
>>> Good day,
>>>=20
>>> I am in the process of adding support for aarch64 to the xen-sys
>>> crate[1].  The crate currently supports x86_64 and includes a
>>> stand-alone "oxerun" application that can be used to validate
>>> hypercalls.  My goal is to provide the same functionality on arm64.  I
>>> am looking for a stand-alone aarch64 example, something like an "hello
>>> world" to help me with the assembler startup code.
>>=20
>> We are working on porting XTF to arm64 and already have something runnin=
g.
>> I think it could be a good starting point for you:
>> https://github.com/orzelmichal/xtf/tree/arm-devel
>=20
> Quick one - have you been able to get the "test-arm-64le-example"
> application to run?

Yes we are running this.

>  So far Xen gives me the following error:
>=20
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Unable to copy the kernel in the hwdom memory
> (XEN) ****************************************
>=20
> I wanted to check with you before starting to dig into it.

Probably a setup issue here.
We are running most of the time XTF as a xen guest but we also check that i=
t works as Dom0.

I added Michal Orzel in copy who is doing all the work on XTF, he will be a=
ble to help you more then me :-)

Do not hesitate to provide more info on your setup and target if you want u=
s to help.

Regards
Bertrand

>=20
> Thanks,
> Mathieu
>=20
>>=20
>> Regards
>> Bertrand
>>=20
>>>=20
>>> Many thanks for the consideration,
>>> Mathieu
>>>=20
>>> [1]. https://crates.io/crates/xen-sys



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 14:01:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 14:01:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242271.419059 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxV7-00064o-0r; Wed, 08 Dec 2021 14:00:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242271.419059; Wed, 08 Dec 2021 14:00:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxV6-00064h-U3; Wed, 08 Dec 2021 14:00:52 +0000
Received: by outflank-mailman (input) for mailman id 242271;
 Wed, 08 Dec 2021 14:00:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cpXy=QZ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muxV5-00064a-R5
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 14:00:51 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3fb6bf28-582f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 15:00:50 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35758)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muxV3-0006PR-7p (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 08 Dec 2021 14:00:49 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 12BBD1FB51;
 Wed,  8 Dec 2021 14:00:49 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fb6bf28-582f-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4176f64e-fdb1-8d23-d226-bde5e473883b@srcf.net>
Date: Wed, 8 Dec 2021 14:00:48 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
References: <20211203073058.10980-1-jgross@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/libs/light: set video_mem for PVH guests
In-Reply-To: <20211203073058.10980-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 07:30, Juergen Gross wrote:
> The size of the video memory of PVH guests should be set to 0 in case
> no value has been specified.
>
> Doing not so will leave it to be -1, resulting in an additional 1 kB
> of RAM being advertised in the memory map (here the output of a PVH
> Mini-OS boot with 16 MB of RAM assigned):
>
> Memory map:
> 000000000000-0000010003ff: RAM
> 0000feff8000-0000feffffff: Reserved
> 0000fc008000-0000fc00803f: ACPI
> 0000fc000000-0000fc000fff: ACPI
> 0000fc001000-0000fc007fff: ACPI

The patch itself is fine, but some further observations based on the
memory map alone.

It is rude to provide an unsorted memory map.

The LAPIC range is required to be reserved by the ACPI spec, missing
here.  Conversely, it's unclear what the reserved region is trying to
describe.

Of the 3 ACPI ranges, one is RSDP (the first 64 bytes), one is the info
block (4k), and one is the ACPI tables themselves.

RSDP really ought to be merged into the same block as the rest of the
ACPI tables.

The info block must not be marked ACPI reclaimable RAM, because it is
referenced by AML inside the DSDT/etc.  This is a very serious issue if
the OS actually exercises its right to reclaim those regions and use
them as RAM.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 14:17:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 14:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242279.419073 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxkX-000830-EN; Wed, 08 Dec 2021 14:16:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242279.419073; Wed, 08 Dec 2021 14:16:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxkX-00082t-BP; Wed, 08 Dec 2021 14:16:49 +0000
Received: by outflank-mailman (input) for mailman id 242279;
 Wed, 08 Dec 2021 14:16:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cpXy=QZ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muxkV-00082n-Dz
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 14:16:47 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 796ea2a0-5831-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 15:16:46 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:41204)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muxkT-000nZO-nO (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 08 Dec 2021 14:16:45 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A88641FBFC;
 Wed,  8 Dec 2021 14:16:44 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 796ea2a0-5831-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <1f06e98d-ab69-09b1-d460-f863827713ec@srcf.net>
Date: Wed, 8 Dec 2021 14:16:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <935688c8-c971-53c7-4c27-f34a841168ec@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86: avoid wrong use of all-but-self IPI shorthand
In-Reply-To: <935688c8-c971-53c7-4c27-f34a841168ec@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 08/12/2021 11:47, Jan Beulich wrote:
> With "nosmp" I did observe a flood of "APIC error on CPU0: 04(04), Send
> accept error" log messages on an AMD system. And rightly so - nothing
> excludes the use of the shorthand in send_IPI_mask() in this case. Set
> "unaccounted_cpus" to "true" also when command line restrictions are the
> cause.
>
> Note that PV-shim mode is unaffected by this change, first and foremost
> because "nosmp" and "maxcpus=" are ignored in this case.
>
> Fixes: 5500d265a2a8 ("x86/smp: use APIC ALLBUT destination shorthand when possible")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
> While in "nosmp" mode it's probably benign that we switch to the bigsmp
> APIC driver simply because there are more than 8 physical CPUs, I
> suppose that's inefficient when "maxcpus=" with a value between 2 and 8
> (inclusive) is in use. Question is whether that's worthwhile to find a
> solution for.

Honestly, the concept of "nosmp" needs deleting.  We inherited it from
Linux and it wasn't terribly appropriate even back then.

Nowadays, even if we happen to boot with 1 cpu, there are normal things
we talk to (the IOMMUs most obviously) which are smp-like.


None of these command line restricted settings can be used in
production, because neither Intel nor AMD support, and both require us
to boot all logical processors.  Everything playing in this area is a
maintenance burden only.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 14:19:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 14:19:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242286.419083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxnU-0000eQ-UB; Wed, 08 Dec 2021 14:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242286.419083; Wed, 08 Dec 2021 14:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxnU-0000eJ-R2; Wed, 08 Dec 2021 14:19:52 +0000
Received: by outflank-mailman (input) for mailman id 242286;
 Wed, 08 Dec 2021 14:19:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5L+7=QZ=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1muxnU-0000eD-6R
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 14:19:52 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e733c3d1-5831-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 15:19:50 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 554BCD6E;
 Wed,  8 Dec 2021 06:19:49 -0800 (PST)
Received: from [10.57.6.53] (unknown [10.57.6.53])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB3313F73B;
 Wed,  8 Dec 2021 06:19:48 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e733c3d1-5831-11ec-9d12-4777fae47e2b
Subject: Re: Aarch64 stand-alone application for Xen
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com>
 <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <074326cc-f910-2cad-be1f-e27480f53b67@arm.com>
Date: Wed, 8 Dec 2021 15:19:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Mathieu,

On 08.12.2021 01:06, Mathieu Poirier wrote:
> Hi Bertrand,
> 
> On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
>>
>> Hi Mathieu,
>>
>>> On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>>>
>>> Good day,
>>>
>>> I am in the process of adding support for aarch64 to the xen-sys
>>> crate[1].  The crate currently supports x86_64 and includes a
>>> stand-alone "oxerun" application that can be used to validate
>>> hypercalls.  My goal is to provide the same functionality on arm64.  I
>>> am looking for a stand-alone aarch64 example, something like an "hello
>>> world" to help me with the assembler startup code.
>>
>> We are working on porting XTF to arm64 and already have something running.
>> I think it could be a good starting point for you:
>> https://github.com/orzelmichal/xtf/tree/arm-devel
> 
> Quick one - have you been able to get the "test-arm-64le-example"
> application to run?  So far Xen gives me the following error:
> 
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Unable to copy the kernel in the hwdom memory
> (XEN) ****************************************
> 
> I wanted to check with you before starting to dig into it.
> 

ICYDK, 64le environment is used to create non-MMU domain in contrast to mmu64le.
It lacks support for PV console and other important features of Xen.
But we are able to run it without any issue.
Please keep in mind that as there is no MMU you need to pay attention to the load address.
By default for non-MMU domain, the address is 0x40000000 which is the correct address if you use XTF as a guest.
If you want to run non-MMU XTF as dom0, you need to specify the correct load address by passing CONFIG_LOAD_ADDRESS=<address>
when invoking make. For example on QEMU it would be CONFIG_LOAD_ADDRESS=0x80000000.

> Thanks,
> Mathieu
> 
>>
>> Regards
>> Bertrand
>>
>>>
>>> Many thanks for the consideration,
>>> Mathieu
>>>
>>> [1]. https://crates.io/crates/xen-sys
>>>
>>
> 
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 14:22:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 14:22:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242295.419094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxpj-00024Y-EJ; Wed, 08 Dec 2021 14:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242295.419094; Wed, 08 Dec 2021 14:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muxpj-00024R-BQ; Wed, 08 Dec 2021 14:22:11 +0000
Received: by outflank-mailman (input) for mailman id 242295;
 Wed, 08 Dec 2021 14:22:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muxpi-00022o-4P
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 14:22:10 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39e5a7f7-5832-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 15:22:09 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 3B2641FD26;
 Wed,  8 Dec 2021 14:22:08 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DFDF013C8B;
 Wed,  8 Dec 2021 14:22:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id UKAJNI6/sGFHLwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 14:22:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39e5a7f7-5832-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638973328; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hMFaj9gEgE407z9I/veihwtXoy45Iq8g3KZeKUBDa1E=;
	b=BJaEvp8Yo2Sk1vPuKoOkw+hQQR/M43H3VdavBX+eXXem3mLgML6iZf2SVlULabqkaGwrFx
	NpmIqF/8v4IOIWzSGtXEPaA/97EfS+YhQKxo3UP51UjFgSu2GxbUjwiaWG9+5MvaI3JVla
	ltrtxNCRLi95C+8pp/hxUUtXrCY07hI=
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
To: Andrew Cooper <amc96@srcf.net>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
From: Juergen Gross <jgross@suse.com>
Message-ID: <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
Date: Wed, 8 Dec 2021 15:22:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="Y3gcQyFZkZRmTfug07j39X2g7sN6yp3bb"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Y3gcQyFZkZRmTfug07j39X2g7sN6yp3bb
Content-Type: multipart/mixed; boundary="QlszJzzRGYOVGEdOfYxcnWSDjKfQX2u2S";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <amc96@srcf.net>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
In-Reply-To: <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>

--QlszJzzRGYOVGEdOfYxcnWSDjKfQX2u2S
Content-Type: multipart/mixed;
 boundary="------------524EBCADA84413BF09202C23"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------524EBCADA84413BF09202C23
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 08.12.21 14:43, Andrew Cooper wrote:
> On 08/12/2021 08:47, Juergen Gross wrote:
>> The HVM parameters for pre-allocated event channels should be set in
>> libxenguest, like it is done for PV guests and for the pre-allocated
>> ring pages.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> I'm not sure that we have the concept of pre-allocated ring pages.
>=20
> For PV, we have:
>=20
>  =C2=A0=C2=A0=C2=A0 dom->console_pfn =3D xc_dom_alloc_page(dom, "consol=
e");
>  =C2=A0=C2=A0=C2=A0 if ( dom->console_pfn =3D=3D INVALID_PFN )
>  =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 return -1;
>  =C2=A0=C2=A0=C2=A0 xc_clear_domain_page(dom->xch, dom->guest_domid,
>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =
xc_dom_p2m(dom, dom->console_pfn));
>=20
> and for HVM, we have:
>=20
>  =C2=A0=C2=A0=C2=A0 dom->console_pfn =3D special_pfn(SPECIALPAGE_CONSOL=
E);
>  =C2=A0=C2=A0=C2=A0 xc_clear_domain_page(dom->xch, dom->guest_domid, do=
m->console_pfn);

Isn't that a pre-allocation? The PFNs are fixed at boot time of the
guest.

>=20
> With a suitable tweak to the commit message (probably just deleting the=

> final clause), Reivewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>=20
> That said...
>=20
>> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom=
=2Ec
>> index fe9f760f71..c9c24666cd 100644
>> --- a/tools/libs/light/libxl_dom.c
>> +++ b/tools/libs/light/libxl_dom.c
>> @@ -723,9 +723,8 @@ out:
>>  =20
>>   static int hvm_build_set_params(xc_interface *handle, uint32_t domid=
,
>>                                   libxl_domain_build_info *info,
>> -                                int store_evtchn, unsigned long *stor=
e_mfn,
>> -                                int console_evtchn, unsigned long *co=
nsole_mfn,
>> -                                domid_t store_domid, domid_t console_=
domid)
>> +                                unsigned long *store_mfn,
>> +                                unsigned long *console_mfn)
>>   {
>>       struct hvm_info_table *va_hvm;
>>       uint8_t *va_map, sum;
>> @@ -752,8 +751,6 @@ static int hvm_build_set_params(xc_interface *hand=
le, uint32_t domid,
>>  =20
>>       xc_hvm_param_get(handle, domid, HVM_PARAM_STORE_PFN, &str_mfn);
>>       xc_hvm_param_get(handle, domid, HVM_PARAM_CONSOLE_PFN, &cons_mfn=
);
>=20
> ... these are junk too.=C2=A0 I'm dismayed at how much of the toolstack=
 tries
> passing function parameters via HVM_PARAMS.
>=20
> libxl's HVM path ought to mirror the PV path and, after
> libxl__build_dom() is called, just read the values back out:
>=20
> state->console_mfn =3D dom->console_pfn;
> state->store_mfn =3D dom->xenstore_pfn;
>=20
>=20
> That then leaves hvm_build_set_params() doing nothing but adjusting the=

> HVM info table for real HVM guests.=C2=A0 dom->max_vcpus is already pre=
sent
> which covers 2 of the 3 fields, leaving only the ACPI boolean left to p=
ass.
>=20
> So by passing the ACPI boolean down, we get rid of
> hvm_build_set_params() entirely, which seems like a very good move.

Yes, this should be in another patch, though.


Juergen

--------------524EBCADA84413BF09202C23
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------524EBCADA84413BF09202C23--

--QlszJzzRGYOVGEdOfYxcnWSDjKfQX2u2S--

--Y3gcQyFZkZRmTfug07j39X2g7sN6yp3bb
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGwv44FAwAAAAAACgkQsN6d1ii/Ey/e
3Qf7Bxog6SFxnITh0NHIL1QtJoAYWIeVwPLyFK/wJ7I17YMhQA6MSnJEe5BAnl34zfrrueIsY4ff
0sE84hR9SCqQUOK2o/Q4M6N9oFT6KXQW95/F+18UU1FMSiSaVw7zEzRi2q8xxTGiBa/B+tScBsKi
nAw6RL4HbDhEOUaCSrRheNnbiBioCw2By5PqxgQltfePVYiGJ3HbiUOgiy6bDDMlxq4NEK/o1WCA
AdTAkHTTOtbGu/3Si239zDD5IzU/1wqMGWswwGRRbfy+GkTmBwJtBixxjhhwKfKh5LA5huvYZ/S2
6hNi3iT6x0ZUEF89vBYMk8m+Jv0h4oV04/qkZR9bkQ==
=s8Gi
-----END PGP SIGNATURE-----

--Y3gcQyFZkZRmTfug07j39X2g7sN6yp3bb--


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:28:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:28:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242302.419106 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muyri-0002Ce-DJ; Wed, 08 Dec 2021 15:28:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242302.419106; Wed, 08 Dec 2021 15:28:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muyri-0002CX-8Z; Wed, 08 Dec 2021 15:28:18 +0000
Received: by outflank-mailman (input) for mailman id 242302;
 Wed, 08 Dec 2021 15:28:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muyrg-0002CN-PU; Wed, 08 Dec 2021 15:28:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muyrg-00088d-GW; Wed, 08 Dec 2021 15:28:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muyrg-0000AV-4p; Wed, 08 Dec 2021 15:28:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muyrg-0007Lm-4B; Wed, 08 Dec 2021 15:28:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=c3FrGWbGH7XF4pxGRsqibYuWporPrukpjgiUJ4QTd0A=; b=X5p/03uWNL+3FvVYrKc7zSpNKN
	iTuZw4lBRcRQfESU8lK5waAHQVPuj5LA+uyXRJlm4SXeqvYVlW+NCvFa/6khq8wGkOQNsongc/ARW
	KiNsh4q954QMIQH5+s3vaS2vr28W9NVrKZyGB0Vk74r8mh6jWPuco6q9d1UjXRAx7sBQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167228-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167228: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=a3607def89f9cd68c1b994e1030527df33aa91d0
X-Osstest-Versions-That:
    qemuu=2f8eb086732ad1875003101f5324f01c47d7408c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 15:28:16 +0000

flight 167228 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167228/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 167221

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167221
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167221
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167221
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167221
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167221
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167221
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167221
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167221
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 qemuu                a3607def89f9cd68c1b994e1030527df33aa91d0
baseline version:
 qemuu                2f8eb086732ad1875003101f5324f01c47d7408c

Last test of basis   167221  2021-12-06 19:38:13 Z    1 days
Testing same since   167228  2021-12-08 05:42:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Damien Hedde <damien.hedde@greensocs.com>
  Mark Mielke <mark.mielke@gmail.com>
  Peter Maydell <peter.maydell@linaro.org>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   2f8eb08673..a3607def89  a3607def89f9cd68c1b994e1030527df33aa91d0 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:29:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:29:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242310.419119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muysw-0002od-Va; Wed, 08 Dec 2021 15:29:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242310.419119; Wed, 08 Dec 2021 15:29:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muysw-0002oW-SZ; Wed, 08 Dec 2021 15:29:34 +0000
Received: by outflank-mailman (input) for mailman id 242310;
 Wed, 08 Dec 2021 15:29:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muysw-0002oQ-BP
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:29:34 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on20616.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::616])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a2de082c-583b-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:29:32 +0100 (CET)
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5127.namprd12.prod.outlook.com (2603:10b6:208:31b::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Wed, 8 Dec
 2021 15:29:28 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:29:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2de082c-583b-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cHrs/kPBvM6uI3pzYjhLLd/43CnFZ0tG7hin+v8VLrRPFgQSQ7xwdJK3xpfYRpfXdEk0mMVs8Aeyy+V897LZo62VX9+Pm1NQP/AErS9t57QHZ/hw7CRNf2MTfa0AK2m5ADpyyJY/UiIBNQc9NmpaToRCubLgNMSFe060ed4f6RVwOSSChjGAnDz94I56syrfGeBJeclZ+5cclTWX7Irb3vwZsrHb09JYif4SdacHkVpswQN2+Sh/ouhCbGEOtCkC63PVeH4YIqWX0XJq5VA5k5nMT8AUCeAjM9CcBqD2MHKNrb6IaRyrPy+GU8esciGQR4GzZZnvsqG/3PXqagsh6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EqIKwXBLinJdRbLsCXtGFLo3LB/oiMwLJPzx1nKQJQw=;
 b=nikdS4aqQd/bQMgGAaoN6ukfZszz2ThAASRdrLXFANqjUriC+GBi9dINRFkj4eThaKbwgLgWTkWTATdD2GVrcQIhEhz4+yjAYZ7c2ECvJH0UJxITZBdh9dRlYMatsewSKkkuvLcKciiiMwXmzH7+5TIJs20VewUMQfp/rR2UiEwLIpkS2p2e6qDJsheJLNbNnEQjatruYkCIKQIyY+ZoYJi9JsXpNnciA/HNtWChPPreNJx/45TRnDUQVrA+IM3sp3Ux6GNvFLcY0OR1uhaAZu9OqplDCSRxYGeh6yzm3ql5XF2gq+/xF9PdRFL22s9uB9gEEIS9yM4Blih5Sef4Rw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EqIKwXBLinJdRbLsCXtGFLo3LB/oiMwLJPzx1nKQJQw=;
 b=spS15JoopGFSv4KyzklfRP7r/1/fjYuQC0XvItGorKGo344ca3Ls/qajExfARxs+10UfJ+QdM4JqdDuyRb6xN+xU8h9FB5nu/5C0fOYQQzQ4HZi8GXtvh6sDxXODLgwKGvI4a5o+8IgyC5BuQx/7e+i5+ww1t22S6Hwmu8Rh6AtOMSs8FWLbou1vTHCRrre5UpFF/JrkccO+39LIpNcxb2dTU6Z5ZtzI2nFXJNAYmPem+nOBB/gvZ0sbfArBteHVd3n7Amj/ZXSSbT/konZrtF2I25EfgI92oNHYal1q+UUmguGlaidUkObUUWj5dpZVvFlKgb00CsY65DwiX5uzrQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:29:25 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	sparclinux@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org, ath11k@lists.infradead.org,
	Wei Liu <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 20/23] PCI/MSI: Move msi_lock to struct pci_dev
Message-ID: <20211208152925.GU6385@nvidia.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.925241961@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210224.925241961@linutronix.de>
X-ClientProxiedBy: SJ0PR13CA0003.namprd13.prod.outlook.com
 (2603:10b6:a03:2c0::8) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f90ec134-269d-4019-2b5c-08d9ba5f85ba
X-MS-TrafficTypeDiagnostic: BL1PR12MB5127:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB51273842AE9FBFD29E22609FC26F9@BL1PR12MB5127.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B3eVpYRpFFYTOU+vvrXBZ+ygMslxmtbo/hVH9fvie1kilzPEcIAdgCRxWgl6HWAfN/6/QzyX7KSKORKOcMDQkl6taLlAuB28200GaHKd419HPSjWCBFZ77PKRIBcuixHzKS4Yxxgnh2PEt/drqdKjJIhlhibXIyFgDioawlBMI/U4tDp1M/Jig7cGT0bn1iOk4r5f4Ec3SiYAh1xkbzjp5Lykm/j2B78ph65wX/R59ZHHk1FcWWnFWXSpx3End6NFtBai9BhOWGdCZDIb2s4vmk8SmodKXEBeqL5uFmAWivxfmx3wjPqC4SkzaKsi6lyOv2teNdHikDaQkN2TbtX8QDLN4kIJLD+KTUYy3BqKI4CTYEHOhrR3zG1lCo2bXDeyT7i6ke9zGGQl9K3LPA1OjAr27Dayf0u+aoZSlg1mmsJ7A47YA0htoC/u+1kGprlMUt8MpIEacGCAMZO5lDA6RXhOPOwc7EY5U5y6vgDDk4p3Z8NxOgsLtsGFdTI4hHYZRaiz1qL3We7RgCJ+u+18Oi/r5wu09zej02zql1QeT4uIV5qqnHUC+FM5NnTb4GGkEAapWrdnQlX78RU7FU7KLcH99lSQKcjZY/PpjCCQ5G0OG2381CiVlVcQpo6k26rUTfDo9AsZj/+ylmK1IxueA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(26005)(6506007)(36756003)(38100700002)(316002)(83380400001)(508600001)(1076003)(8676002)(5660300002)(8936002)(6512007)(4326008)(6486002)(7416002)(66556008)(33656002)(66946007)(86362001)(2906002)(66476007)(2616005)(186003)(6916009)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4qHNKg1WQH+kBtj/dK9f8zuC0IkmRPAm3+jbYJTKYf3Vur1eVMhVVzr2+lwG?=
 =?us-ascii?Q?czumodgEA+8VjQe7oHIEchjD9aOhAgV4/COqKYGIGrexW0TJ4SulZAEsMioE?=
 =?us-ascii?Q?jn+T4A8G8Kskbq/xJOX7Ggu1oHb1z0roPtMDnxgAkzxqQpNQuQcs3iy3cgeS?=
 =?us-ascii?Q?6kiDxYEJYmSw2hkSbOPn9CP73hKIXfRmP1KAzSVCv8/7/apybkKqMjsyoZYt?=
 =?us-ascii?Q?ClOuzt/ewNWAugLjrEFS7NAnRn0T2fxcoTeDNPOhIakFWXYrWXKg7qemOt1L?=
 =?us-ascii?Q?Z8ENKfX8YogRZLvd18s2gC4VzPfarVkIAW066jAPI5tvbkNsTm7TdzhtUoLP?=
 =?us-ascii?Q?5gCJqHREls+EBI+Y7pSzwt9PUBl0edvuN95LEhYMb0ZI+GjDYxLQLY9Kx8AP?=
 =?us-ascii?Q?kBpOfcTQTiEFArtuZ+fhg45mxcrRDdOPofagKG8OUPXXJAnaHcTjfKGrNUZh?=
 =?us-ascii?Q?sxVNOtfl3iNjDOs9WADBtIWvaM9eiyS10KtgUBPit3of4Vw0C+mhuXQYqA+n?=
 =?us-ascii?Q?Xg6o3AZxRLwDS1LO74Ax6zPTa72TqY6c4bV8q+vdUfZIN4/FxmDWY4L6k1Gm?=
 =?us-ascii?Q?ESl3e5ZoZAMWX5xNmi/k6bNEDbKu+Hvxqx42gkkjeL5fJrFNtzQ7/LwH1lMM?=
 =?us-ascii?Q?Hhhd8ZVYNngT4wme7g29/ukeftbxOfMm025p/BDxyw6+VRQ60Qt7I1WVoyHd?=
 =?us-ascii?Q?7hyf75XN6KHNk5bh4LE+SpaI8CIkY/hZ+xgbluduy/bINR0KElraxxGx78rP?=
 =?us-ascii?Q?GGkFVq/dmT+qkSn2W23tjCfEicvwoshnFFzWNpnAYAc7S1eAxhtJk7qKNiJ/?=
 =?us-ascii?Q?wEVZoSM/t/d469Cu47BrH5hOX8RB5mtXpl4RdJds+mvvXv+89XjGLVCyA9nx?=
 =?us-ascii?Q?yhr7943tLsjX0FJbPaDUztHShMMHPCciwxnx9s92+E89cHu5OnRqMtVBTS9i?=
 =?us-ascii?Q?W9/dOZOHhG5//UZOrkFtNvzpcQR7o9Ruo60OTE18DDhCzJrj3N4fwouMtWEo?=
 =?us-ascii?Q?VVOkgxfB3fm2FrGI6BZmCOBVpYQ7HVeY+FNrrdSXtXUBs2ezX1grCbjHaH6Y?=
 =?us-ascii?Q?+gVS7c6AbxlNw+1ZGEK2mBLdhu/lfpNbBh7bHvP/gQFigicFZMlJQC9uJlce?=
 =?us-ascii?Q?hcguvHjxZAcsE1YycbXIWF2BkfnmuaGjVZDULyvAORReXccmz5wPbF5LoVIj?=
 =?us-ascii?Q?sj7gu52idywq5M5wGnFuUzjiwxt7aYqxviKjAevtRCVR6s+iBzyQ1c76mPKd?=
 =?us-ascii?Q?gXcyPtf3qpEpfg2E9yg20NOG1aOmTaMDGBIG1DWwQJQXt92e4EsVkgKb+Zcc?=
 =?us-ascii?Q?JvE0BkcdwAH3l9K5IIzdEpqS91wEG2Msmy+mhkb+MR80Vle8inGplLwEP9R2?=
 =?us-ascii?Q?Ufq3aMvRMmMeqDMGi9UAyqiPs2SQFkdulATIT5Bl6qcI27/g9ByxoE0ozt1B?=
 =?us-ascii?Q?sTRESsqyymdY64s2k9L285cOd2ar3wekv85B0GQ4bMwAJ08hsr3xxUKgFOVI?=
 =?us-ascii?Q?OCQZZJ1OrVxujVpiYFUBz8EVfIAa+0eRNPSingf+iqndZgIWOyptWX2cqDFo?=
 =?us-ascii?Q?2NYb/o05UKkV7cZ+3eY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f90ec134-269d-4019-2b5c-08d9ba5f85ba
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:29:27.9428
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hfMTmdcaHlz/BZrC2JZXCui5mkQVZpKHJFa1nbioq5UXjn3RJ3Zj89JoFzfAoZYd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5127

On Mon, Dec 06, 2021 at 11:27:56PM +0100, Thomas Gleixner wrote:
> It's only required for PCI/MSI. So no point in having it in every struct
> device.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V2: New patch
> ---
>  drivers/base/core.c    |    1 -
>  drivers/pci/msi/msi.c  |    2 +-
>  drivers/pci/probe.c    |    4 +++-
>  include/linux/device.h |    2 --
>  include/linux/pci.h    |    1 +
>  5 files changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
 
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2875,7 +2875,6 @@ void device_initialize(struct device *de
>  	device_pm_init(dev);
>  	set_dev_node(dev, NUMA_NO_NODE);
>  #ifdef CONFIG_GENERIC_MSI_IRQ
> -	raw_spin_lock_init(&dev->msi_lock);
>  	INIT_LIST_HEAD(&dev->msi_list);
>  #endif
>  	INIT_LIST_HEAD(&dev->links.consumers);
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -18,7 +18,7 @@ int pci_msi_ignore_mask;
>  
>  static noinline void pci_msi_update_mask(struct msi_desc *desc, u32 clear, u32 set)
>  {
> -	raw_spinlock_t *lock = &desc->dev->msi_lock;
> +	raw_spinlock_t *lock = &to_pci_dev(desc->dev)->msi_lock;
>  	unsigned long flags;
>  
>  	if (!desc->pci.msi_attrib.can_mask)

It looks like most of the time this is called by an irq_chip, except
for a few special cases list pci_msi_shutdown()

Is this something that should ideally go away someday and use some
lock in the irq_chip - not unlike what we've thought is needed for
IMS?

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:45:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:45:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242321.419131 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muz85-0005Xv-AS; Wed, 08 Dec 2021 15:45:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242321.419131; Wed, 08 Dec 2021 15:45:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muz85-0005Xo-7W; Wed, 08 Dec 2021 15:45:13 +0000
Received: by outflank-mailman (input) for mailman id 242321;
 Wed, 08 Dec 2021 15:45:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muz83-0005Xi-W5
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:45:11 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2060a.outbound.protection.outlook.com
 [2a01:111:f400:7eab::60a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d249c0ca-583d-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:45:10 +0100 (CET)
Received: from BL1PR12MB5301.namprd12.prod.outlook.com (2603:10b6:208:31f::13)
 by BL0PR12MB5508.namprd12.prod.outlook.com (2603:10b6:208:1c1::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec
 2021 15:45:06 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5301.namprd12.prod.outlook.com (2603:10b6:208:31f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 15:45:06 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:45:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d249c0ca-583d-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LTL3jC/soHCZRgpiqGm9Ug+/yvgXqlSiCUtU/n6kCxBojGQWF1vul2ni9HhPEGpjTf3+Gmyluqfvc47ZpBs/BTkkxnvxEvDE5gbAeiFPBXGJCJ/wBrs0IISR8tvzzwqVlRq8kgw0CHG5GA/4GMdBkljzQrn7J71+e+2IGr5Df3W53c4ok41i+HGDbM/zlEoRsBvPsnbeWw5zcstF2OWrkbm3sIptmZj4IJMffj8mUn3g85Da8KoN0j/CpVRQE4ulf4PXcrS0eiTlPi5byZvEorYue+vPRs4iIOo0v6c94ZP0s58AQ7Ihj1pSpZ+rwWwcCuR0HnTKkUJejUIK0hhWRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sHmYS/B98+JED+8Wv+3w810KgqCQ3Nsl3heM6MOFHMY=;
 b=JuFd5s85ipvEr1iVDb/FAwb5mxYKd/ws47f8HNDdMTpxFgs24PtGeiSJObKyOzwCMNyE43Z6e1VICCw5KXC20hLcQU/f1ftbAZg7hQ62B53RYGzHmUwHwXFwNCT0L2MFFNs8x+VQlEEL7dDVuqg9q5B7DfYfxhABaezJGOjt9xcFM5a/Y/DB2qS7z80YBOZ8Th1A/YIE1ms54WRhOx1PS+PJdTgmHxEPASieSvSk/xZ/yMRx8YTEvYub4qwts9DsiwDqYj39WaewKTKYtM1PaDaG7tisGnw1Sq8gQ7p8bUMYv8u1obWIS6dr277qtY78c88quLp0MX+FfPRpZokfFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sHmYS/B98+JED+8Wv+3w810KgqCQ3Nsl3heM6MOFHMY=;
 b=d5rRlYXFKdGNp5gjoAizr6qUuyQ240IxmXy4byrN/NBsSF7kmb7es7rgGhHkq2uw+XMh/4+nRRnpNkK/boGQz2+OzzlVKOf2pp3AbdB2lWcKPIKCm2BI/wEJ2CqlL7fdUHr7QmKolq83aFkqpFn8LNIJO11wnJrvjjVD/UUgiyci0oL76JpRPteNdczVCGkl7Yn73Q9CO2abg3KLv2Y2Z4QPDc2/UKpy0tPxLYx2/676IRbSGUV44DqSaJ8rW6evKbFKJqKVRFrnZBXKxqeVShOIogDr6npaEiHrBb40fem7+aAYXOTr39wrGFYjqiQ9dUE4KecYi8CDK/PRVgm8PQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:45:02 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 21/36] x86/apic/msi: Use device MSI properties
Message-ID: <20211208154502.GV6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.798385721@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.798385721@linutronix.de>
X-ClientProxiedBy: BY5PR03CA0024.namprd03.prod.outlook.com
 (2603:10b6:a03:1e0::34) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7848950a-ea12-4c39-187c-08d9ba61b492
X-MS-TrafficTypeDiagnostic: BL1PR12MB5301:EE_|BL0PR12MB5508:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB53010068C37C4A97DB7CC9F0C26F9@BL1PR12MB5301.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	glWwDnif56mLRPbZ8kUqqsPht1x3doVlpO2gB4WiA/rQ0JmiR7xiLVi+BagkT77Xys7V2LD2ZpHeG34ziXTR9m/w9Kg+tBoHhoDVfKzDP6nZMN39rnDnJp6CbzpXSJ09VQx87j6jXBkVvESbkCjKAZuQDDrAjxukrej4a2Ppc0P7Vz3VwWnDrfoZ5Cftfgipbt1CumCjrHInWilFLhAgv70M98BZBCMJJmuaLUWK82JpJdvrs0MrCREQawGMsL991ws45nwvzSCcOseRTdZYL9T3rUdFlPNJRg/x3zfipl7OZ9shPvzYpJlakMKWaa8v3ukT1Ph4aCYKwE49m/l2ZGm9LWela4IIcFXh/JDfC4DugFRv8xXYFUClYsX5xB6Y9s6V0zVFgSnl0pyGOjEht0ojQ7fl1Pd470SZPDQmygZu9fvs5FNCqTTRIs1BljW7ZHYmWu+adjtPSLhH8o635Zh/BX3PJBP/RDuwoDYbYDxJIWGdaJ1mYKklA7vXkKVAOfmFYy2stVuMcAvZEwDBhmt+rwFjtS5CWx9i5HKza22VfTorwf7xjK8PmqZF7ze6oFUzZ2jyubH+pl6q4bcr0SsZQk1qQsglgvrC6YXc7Jm5k9fQa3ktr/tdi13B9x4K3wlaJgdh2svJYUfEz3jUVw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5301.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(1076003)(316002)(33656002)(2906002)(7416002)(86362001)(186003)(5660300002)(2616005)(8676002)(66556008)(8936002)(66946007)(26005)(66476007)(508600001)(4326008)(6916009)(6506007)(83380400001)(36756003)(6486002)(6512007)(6666004)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ZQlqhYh3++2ZcACxMS8bMJRuANV8tj8QLJhC7SeAXuQ3ILkt2f/fZogf3Xwz?=
 =?us-ascii?Q?pIR2bqPDL1Q66DQiXKrqlHBN3ZUWfr+RpfPyi3CwH8Oo+UQdpazy/ipOQayl?=
 =?us-ascii?Q?zmIZ7TrlcOtBDAgcLaeIEJkDAox1KexnOlGqPKzxPLsGiT2nyDhHWWKlrX+6?=
 =?us-ascii?Q?F1FL3vzo1lvbGPqn2XJLUmzF0WeuDgUTWvXBe+NFNB9WHAOuRX0pVzUxTCy9?=
 =?us-ascii?Q?uFURWq85J/nzBBF8R2mc5VXjo+9pGEV05vn4XEoDiioRXxxI8mXOlmx3fOk3?=
 =?us-ascii?Q?P12y/apAWO7gtBHg21LRkyY/z8DUVJinrIS0N2gSUB+DeeTPMRdvzH3W/B11?=
 =?us-ascii?Q?GMc59swR91PcgKQYzCQgSNxf+GBWcAHpYVyMv6RmM0/pMjJxvMX2/y/kgrYc?=
 =?us-ascii?Q?yHP/w3rxRJo+mAEbT5S2VYqL5b6aXY6+ETLnabvRii1onvyrcM79Sz7NEmUK?=
 =?us-ascii?Q?vrUVXg3rks0OtLieoL545yheMa5qv7b8/wgeeoqO3+FAnoV7JrNpYiL24VPI?=
 =?us-ascii?Q?G7jFNfOC3EcCwXeUUnm72+0kIsf3GBSPpEiB8nCkPa00au3Fbak/MLUXvGlZ?=
 =?us-ascii?Q?Bq/SA4xhMY0tEdeD+DYrijH9rQDXs5MRw7Dl/DI2PlOkHATVG8p+ygg4/9a3?=
 =?us-ascii?Q?nMhMigjoSXMiG7ReueZR1FVMP/oLpxphlfyfkQNHptQH1JKiqI5rq/cK3CTU?=
 =?us-ascii?Q?2wuO9ldJl6+FzECoeAcltTOgfTXhFWskBfR4c3ZmiiB3cj0ti9f2CH0N/f3z?=
 =?us-ascii?Q?QkROYmqjR+7K3PWnzelQ9QoHVzs54F4qsL2UJPuzQeYoX0DPLXrQXses4Jst?=
 =?us-ascii?Q?gArajhYIVhr/9+w02Ovnkdp8mQThsjotXYMI5n5OzLRYkXI7ORYEuQkvKP2e?=
 =?us-ascii?Q?VszthOUscvDZxaiyxpEzZaFGm8lDoAnPwxkOa5MqszALqR0lMX3Xz88TXpVz?=
 =?us-ascii?Q?Hk0BY3o/28HHLITvPj3IV7BJJDIDtZu1iYn+QoLX0UlOfr2daohJeTtdVvtD?=
 =?us-ascii?Q?4Kcbk/YzBPK6uSD9JylOBN2+favHiQzW1E1fY/K2IY2zmDj3n8iqSL74W4sK?=
 =?us-ascii?Q?RJZQltsG+S+M+Dv7nRK55s+O2rBDWmz6dsRceL9SD2MyHARAdX//UUjOrB7j?=
 =?us-ascii?Q?Z2WYLMVQlCmnQ8hfxgmvZBXOYIAaBQ4K504aKJnQQ0tYagMeKTR4PRI6mzI4?=
 =?us-ascii?Q?nzRh3LrzP2h7enG5SbtEP05k1TcEoUQ9uVFWX2ZM2TIPC0rHPj+/pzDRF4Sq?=
 =?us-ascii?Q?T18Njd8gx8xOW9sYJkGXOyS7UlV9uRamnGU+vmZKbMJksZeDnqHyOYO87aAG?=
 =?us-ascii?Q?OHe43in1TnfLkmsJr3xJ199W0bZCHnm9QFrODtW4PM9y8KUYFIEhFh3KR19v?=
 =?us-ascii?Q?OWL/NfPew69SNZACQvxs/RfNGR1pg4/d5f9gl0qchq1GmBAOqFon2ukSPGbn?=
 =?us-ascii?Q?Am18Jk7Gj7oiF6MU9ogoackgLY7rAXsSVaFjjfZgR9Sn/BGRlc1r3v1j3NmJ?=
 =?us-ascii?Q?OdLSVeNYoe3kBOFnBWtwWTNY3lyAICgc2Jxy+BNJRnKcohCZtHAYc07kPRSf?=
 =?us-ascii?Q?+fIwe9ja0to7rnh8ods=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7848950a-ea12-4c39-187c-08d9ba61b492
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:45:05.5723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0RuoZIjeNCCpQ3AakyMBCvnQgaKTQpdCbc4ZqJ4MyQBApVoNRtiLLghWvKPfTXFb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5508

On Mon, Dec 06, 2021 at 11:39:29PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  arch/x86/kernel/apic/msi.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/arch/x86/kernel/apic/msi.c
> +++ b/arch/x86/kernel/apic/msi.c
> @@ -160,11 +160,8 @@ static struct irq_chip pci_msi_controlle
>  int pci_msi_prepare(struct irq_domain *domain, struct device *dev, int nvec,
>  		    msi_alloc_info_t *arg)
>  {
> -	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct msi_desc *desc = first_pci_msi_entry(pdev);
> -
>  	init_irq_alloc_info(arg, NULL);
> -	if (desc->pci.msi_attrib.is_msix) {
> +	if (msi_device_has_property(dev, MSI_PROP_PCI_MSIX)) {
>  		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
>  	} else {
>  		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;
>

Just thought for future

It looks like the only use of this is to link to the irq_remapping
which is only using it to get back to the physical device:

	case X86_IRQ_ALLOC_TYPE_PCI_MSI:
	case X86_IRQ_ALLOC_TYPE_PCI_MSIX:
		set_msi_sid(irte,
			    pci_real_dma_dev(msi_desc_to_pci_dev(info->desc)));

	case X86_IRQ_ALLOC_TYPE_PCI_MSI:
	case X86_IRQ_ALLOC_TYPE_PCI_MSIX:
		return get_device_id(msi_desc_to_dev(info->desc));

And this is super confusing:

static inline int get_device_id(struct device *dev)
{
	int devid;

	if (dev_is_pci(dev))
		devid = get_pci_device_id(dev);
	else
		devid = get_acpihid_device_id(dev, NULL);

	return devid;
}

How does an ACPI device have a *PCI* MSI or MSI-X ??

IMHO this makes more sense written as:

  struct device *origin_device = msi_desc_get_origin_dev(info->desc);

  if (dev_is_pci(origin_device)
      devid = get_pci_device_id(origin_device);
  else if (dev_is_acpi(origin_device))
      devid = get_acpihid_device_id(dev, NULL);

And similar in all places touching X86_IRQ_ALLOC_TYPE_PCI_MSI/X

Like this oddball thing in AMD too:

	} else if (info->type == X86_IRQ_ALLOC_TYPE_PCI_MSI ||
		   info->type == X86_IRQ_ALLOC_TYPE_PCI_MSIX) {
		bool align = (info->type == X86_IRQ_ALLOC_TYPE_PCI_MSI);

		index = alloc_irq_index(devid, nr_irqs, align,
					msi_desc_to_pci_dev(info->desc));
	} else {
		index = alloc_irq_index(devid, nr_irqs, false, NULL);

This should just use a dev and inside alloc_irq_table do the dev_is_pci()
thing to guard the pci_for_each_dma_alias()

Then just call it X86_IRQ_ALLOC_TYPE_DEVICE (ie allocated for a struct device)

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:51:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:51:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242329.419142 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzEC-0007M5-3i; Wed, 08 Dec 2021 15:51:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242329.419142; Wed, 08 Dec 2021 15:51:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzEB-0007Ly-WE; Wed, 08 Dec 2021 15:51:32 +0000
Received: by outflank-mailman (input) for mailman id 242329;
 Wed, 08 Dec 2021 15:51:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muzEA-0007Ls-7i
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:51:30 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2061d.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b2ee6b76-583e-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:51:29 +0100 (CET)
Received: from BL1PR12MB5189.namprd12.prod.outlook.com (2603:10b6:208:308::20)
 by BL1PR12MB5160.namprd12.prod.outlook.com (2603:10b6:208:311::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Wed, 8 Dec
 2021 15:51:21 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5189.namprd12.prod.outlook.com (2603:10b6:208:308::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Wed, 8 Dec
 2021 15:51:20 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:51:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2ee6b76-583e-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kY0G6Zm47GMAJceB2SGeMH4IoTa7S7djXvm0vi1zJH1G1anxJKI2S4kaZyB8iY+2lcjO7O266m2Ibo8vxRkHr+8Cul/fIJRzO7G1TiohAszV+2iwB1x2UGYrjaGZ/cOW67HAP/qcNQuJs8behChEGfxzbDKb2DAfjbP3G1UfHS+ZmVa/ztJHcfU2J4dhSu3q1laoS8GJwbdTa40G625fUplqxzf3k6Q/i7j6yT2JdQTTOvdBPSJIvwlxl7xaX4IyFfKV8S/gibTVkUsauUlXOJua026CuRnDDSfX+0Nqm+JSLrTto7U/7DcP0pULYVWwypesEzbs5JrqzixcNEBs7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=s348dqgICSc7yc8kd+csRUb+Z7Y5Qb2f67t8v+cpqVA=;
 b=Xn7+yNcgsexG4ZNFuUU8o6XmsOMndZaItMfL8fnKmJyB7fMeE6rD4a96TKohqhtyNATFMukfquFeH94d7vWsiPlz27A82XU52K9u45ZQKdd9qReR4BXP4uqXg9fvWia1XAyeEE/rL2q4TvVnVRNY3fY8ZRZuiiGv1T4XMUSAcJ1NfxL+FvnKUgjkd229aeRfOqlluRKciiOeY6Le+6bmwbc8HlQoGoIUl/hR5m53K0LNoSRTobZa3AksD2ReQmkMHJ1P4MgQIiqc3zi+OraVrx+WOmtM5YGKpWw3+40Uf53vDbPI6+EAkZ1vtwpM2KXXA29+TFbw0F15uvoV7LZBbg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=s348dqgICSc7yc8kd+csRUb+Z7Y5Qb2f67t8v+cpqVA=;
 b=SHX6bn5yxH4nBdIdtC6bJRK9LmOS0i6qYvX0aBjWvciekEMDOVvvVYmYU9sUnmwKEkMONMkq7vInjVMJGZouSw+O56OLMhHHblMKexduO+eo2i1V7PT2JoipageT7v/aKK0lzNtTbdLUlvy0wCUXShpFCm/FmvPgnFjo8mXHwqXRt5+eK4cJ8gTYkXgqoK6fV7A9LV48Nz6po6RPw86zJFpHRHJki3noPV09cQjt9F6bHLlzHEOQKmSyQBjr++RG5aH+kgdUmyFktFDIZJ4YMlh3bO+FreHal5lfKlK3ZPvL6wNu9XBTpOrTbDVTy47E6zr7/ihEbM9vTY8MQF6ZsA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:51:18 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 24/36] powerpc/pseries/msi: Use MSI device properties
Message-ID: <20211208155118.GW6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.967630948@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.967630948@linutronix.de>
X-ClientProxiedBy: SJ0PR05CA0164.namprd05.prod.outlook.com
 (2603:10b6:a03:339::19) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 08eec224-a9ff-4738-cd24-08d9ba629428
X-MS-TrafficTypeDiagnostic: BL1PR12MB5189:EE_|BL1PR12MB5160:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB518981CB1F689D384A7513D7C26F9@BL1PR12MB5189.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VCqGL0o0dzwUbbMYtl0SXKEqmDeUvriX9Z+GvFis7dXZPoNLN529CY/pq6f5mmzJFrHU49V1fUpfpnlKvcJo6+9tG4Y8O8g3qWWeP0s/Gs8dSIVPpGHUDKJyA2jjbAhYSgkZMByQOMc+C9RzXtlUhCdRVFb1FWjRDk959zdO+d5Gzup/YpxD3pJd5QGw1RG95fz1X90qiWSnSu6vWaRrQG/Eu5DnXd7x5yL1A+2oMHvpYHzlEnkJkejfzv0vqKqRduI/ux8SmxCMwBaDoWc0XiLh2maLrgNZXKVDiwr4YU5kH2Q0I12MDUuoRTlH2c1h9y93BEgOLuii/0WeNoh1A2qTTC57pZd36lZKfp0HLSzV+DiqqZXjOwJ5uwJFuunvzbee/axYJiC7mwq03S/PwtguNqcUKbC0xGx0SFdY2+/mOobDaYUxw14fFZjNwTN28O+FZp34vY3cHi+qtxvmkwTt1VsyAnxrsOxc4LMwb8e7RLYOGUC6BsW7BXOGLAGwCZsy3GCHnHAsOp08OA1wlUS0iEBk9OnwfwuJ77a8+UJYuv2DGu/O90wI2HfrNWvXcKpnIRF5cAbf7boR/cKcHGxSWuSy6cF8CLK9naQhPjMbT5xpKhVzpI4/Ju1kvLVnCLXo5QjCaAabXqDeVHazsg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5189.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(5660300002)(186003)(8676002)(33656002)(4326008)(8936002)(2616005)(6506007)(508600001)(38100700002)(26005)(6916009)(83380400001)(86362001)(316002)(36756003)(6486002)(4744005)(1076003)(54906003)(6512007)(2906002)(66556008)(66476007)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nY99BlSX7EPurIJ0DhJ4K6f2jifD5yJUaDogsJAS5oVyyJK1VQHwpPYWwfEC?=
 =?us-ascii?Q?yYG3+B2kBS3Y24wHwcM/qPNU98SBtDRURPMmdjlCYuYzL3mk4mOz3irTJa2u?=
 =?us-ascii?Q?yzBv8Nv8jqvEJkzYlHtWmV+70WvJcdJDZdSx0XITebXaZCAK5dfftnrcmNOi?=
 =?us-ascii?Q?/YM4N42f7gZo7cassvjt1dl74hhh/mt0tlYxiuwluD1fgLxzCiJFpZ70vACO?=
 =?us-ascii?Q?zti7j+C2q4zCAcpA5rT7rpZ4QH0HbYqjOefQ4ZC+QGfnDmq4HfBLqERI6Gsd?=
 =?us-ascii?Q?cxKk0yIWll1jJrpeXXofwnm8lELo5ObqBOaQyelhagZwL5C3ag+q8fEwp1gx?=
 =?us-ascii?Q?3ecOG/o7+Gyx3lvA5HgOVriRMBOCl1vA2e1TY5RMGW/gaCaIagp7DDREePCW?=
 =?us-ascii?Q?PMvTgFyveK9hakcH0e0n9U6bwGqwQyC5pvus6FODgXOFc2Dk0dbrNxgbp/SX?=
 =?us-ascii?Q?OGkNOm3pF7Uc+7lO4tGuNZCAHQ6sk5vgT5YZbhfZmSpXL7rw3xzfReyHGjeL?=
 =?us-ascii?Q?7U8lRmExV3KdQJ3nQ0oNRxUdCi2lJqyv4v7x3wQ7AViAS4tkTzrjd5YC4Tyc?=
 =?us-ascii?Q?KV8QECRsyKgluEuZWrPfGA/wZUyA7m/aN3dx3B+jC9h/XbkfdvdHGR0mvHRM?=
 =?us-ascii?Q?kdFggDFIbYeKoJj/0ANwjvm4VgZbRwLlcSiZjquug5ioK33cYTbcz6aEfcbA?=
 =?us-ascii?Q?WWKbXkfoGiPIbOktWJJWtVMaT3Rm0vBdJRJBq+c5BrKMPA9Ha6jWk/wcP/cv?=
 =?us-ascii?Q?lZ7Vtd33/EgfQNYH/RtIiAmssI6NhflU2wbB3PCFftjPOmE52++8IzPfKfqE?=
 =?us-ascii?Q?KllrkM8Tm3Mwb/q7M0dKkJ60/CCt6ufFyhJi9MiqfY8PXDjLsQ0ILXRqErEL?=
 =?us-ascii?Q?x5oCETlb5pvJx8jnpQX8WEDmOVA3jnUQ/Aa5Uvt5eGogk1filUZu2GcpE2mO?=
 =?us-ascii?Q?uts+14sNYh2jHBhAz6g4AeI0JaYV44beFvoRRiOD8HC9vhZX5qrEMN4NefhJ?=
 =?us-ascii?Q?v1FvyqZIfiOjDRuIn7d6BNLlFMwtPoTL2Swg/AdGlcYykKzbho7o9HVbxVX1?=
 =?us-ascii?Q?Vp1ptU4Rcjpk/hMzRkZRlaYG8Ukamyzhpt8QYRFPmnu0TZSYwJLcyssPtC7V?=
 =?us-ascii?Q?KnIAyXz6Vcg6/UG8tUXrcBZEIAE4VpTj6YsTqFCKLEHko3GBa/6UGrU1VdLk?=
 =?us-ascii?Q?zzg/7BB05pnPOVlZJuUJMcKMZRhpt7c+Aju1mJSgI5CwuM/jzt25DkQAN55r?=
 =?us-ascii?Q?E8Nkkk9Y/Fuj5pN3sgeUFlL0XUqSGAFTJyHvStZCmILQqEznIR6QPIs8pNdF?=
 =?us-ascii?Q?At0/9TDLbkUkLRZjs/atuXxzu7TQgKaPjdUi5vpTQveSa0PGRKnndah98WKO?=
 =?us-ascii?Q?YNynFI1u8JcmjZmVOEKkkMx5pTBLx0rYC+HAbFzwCVTyrtK1dfdJPvSki7FE?=
 =?us-ascii?Q?UhUVWsndfNs//1gjdAb5mj4O/pA3tVfjgfatM4H2637f4rPNi8l6/VnLdYXR?=
 =?us-ascii?Q?o9SDnCwJYduoVadyvJjTqaQNxiMH1IGZJTFx5B+ZIJhvJizoc1wlJ6ciypP2?=
 =?us-ascii?Q?cj6VYWZwIyGZr0NhT2Q=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08eec224-a9ff-4738-cd24-08d9ba629428
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:51:20.6617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4LtoikyL2SFNcGJqm9Vjd9iRvQA/N54LSatbf3mvYK8ybnzLr+MKENqYbbBEHszW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5160

On Mon, Dec 06, 2021 at 11:39:34PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>  arch/powerpc/platforms/pseries/msi.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> +++ b/arch/powerpc/platforms/pseries/msi.c
> @@ -447,9 +447,9 @@ static int rtas_prepare_msi_irqs(struct
>  static int pseries_msi_ops_prepare(struct irq_domain *domain, struct device *dev,
>  				   int nvec, msi_alloc_info_t *arg)
>  {
> +	bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
> +	int type = is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
>  	struct pci_dev *pdev = to_pci_dev(dev);

We have the pci_dev here, why not just do something like

   bool is_msix = pdev->msix_enabled;

?

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:53:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:53:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242336.419153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzG0-000820-Ik; Wed, 08 Dec 2021 15:53:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242336.419153; Wed, 08 Dec 2021 15:53:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzG0-00081t-FJ; Wed, 08 Dec 2021 15:53:24 +0000
Received: by outflank-mailman (input) for mailman id 242336;
 Wed, 08 Dec 2021 15:53:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muzFy-00081l-Pt
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:53:22 +0000
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
 (mail-co1nam11on2060d.outbound.protection.outlook.com
 [2a01:111:f400:7eab::60d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f7179af3-583e-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:53:21 +0100 (CET)
Received: from BL1PR12MB5191.namprd12.prod.outlook.com (2603:10b6:208:318::21)
 by BL1PR12MB5112.namprd12.prod.outlook.com (2603:10b6:208:316::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 15:53:18 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5191.namprd12.prod.outlook.com (2603:10b6:208:318::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Wed, 8 Dec
 2021 15:53:17 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:53:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7179af3-583e-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bPoI9M8FsMEfUdP/lJaGkIu9zGmEvn5jCzsN39LhwfCxbZgJ1fhoJvPJEHu7j97fkgrvFL//5sNOwdEl4zoGJ+/b7mAmnuYRgWNWxx7klaBbeBL/hbXuPmW8zxbM7H7tPBln9RQ0dta7CD0ssO8UNSrctBlJdtjjk3A5OLZeltmazrbtb3R1UlXeY3MHcEGgCYm++cs/UceksA2v4Y96m8Ga72pstP0lAzHqG99UMi2Mlo3jqrndJ+wpBP4qBcCWCELFim64e144KLci83eCVe5A8xmJP28diRvmYYhejlbzPNuDurYP3k26LBIgEIciWqyt+ZONrAkvhsffWKscQg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tppcOWK/iYgP5gOW8nSiftuOjDZTY+zjbu0iAuHUUJ8=;
 b=bbMDwzO893FmmO4kkYUe+ti63WC6//Ikg/ovjtzy8S2RwcwARm/C5peLaBlzaSO27VY/JVO28MRnjavwk4+nFG7cUgNOGxeDolFmqUvAN4oyuVz6mzjwl9DYcXw5IFK4g3PDH/0T6pzflt3d7LO0YPnb8Ggwdk+Bca9SDQnj4yysJ4Xvf5XsnbJWt6sogBQAZCoYzmXNQU7juzFWIG5boCInY3ALOJ/XcZALh2SuPzFzBq3H+kja0e3Zc+ShqVOshPt1ghV1PKcIxKbI5rqesggo//a+G+wTxgJL89YW6aoC8PTqyGEdrZgBsvCgJpBnWiE5wdWR22HCSiqnYhudGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tppcOWK/iYgP5gOW8nSiftuOjDZTY+zjbu0iAuHUUJ8=;
 b=rXsM27sXMEqyW23/RKjKbqbdiwHov4gMtJREF9oL60X6SMm3D0AVcU1E9svRyja5EJ2CBZGdyDiFX0ItGs6Gpt4JJOkceyRcMkd8avP/rW9jS8IVR+UHhZQJf8yOGV7ftkFvpSvTGNoeN7Yu+FxAIVkBqWEXzv4dGlcvfOXaK8OC2kI/r9+SrQGhVG1aQZMbCyqXany77Ne/JdoooOMqdjSJHdmr4VyTVD98BjmIzWVovGI9Iq0+YeXqGx519h+L6TM1NN8jEPZZk+IafsVXT27fudRwau3RTCXYnXHunFUViAzh9WLkkCKCpXdITobBTqOan3DpIh/cF+XyFj2HpQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:53:14 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
Message-ID: <20211208155314.GX6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.742297272@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.742297272@linutronix.de>
X-ClientProxiedBy: BY5PR03CA0016.namprd03.prod.outlook.com
 (2603:10b6:a03:1e0::26) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 43f9df46-1668-4fa7-d610-08d9ba62d9a0
X-MS-TrafficTypeDiagnostic: BL1PR12MB5191:EE_|BL1PR12MB5112:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB5191BA1792AA41855E031560C26F9@BL1PR12MB5191.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tfKqL1Eh6gt/aJUT+Jk9Jkog1K+2le7U7i+UM6vEx1fr9oykw5VliXHuas3QP9Ve9+Usy/eQNVTiaZUcLZ4TVwLriCr9hfLczSGhVWdHgXzIJUHwTRd5FDqgkpnZTBZM2Nq/3cQ+PqEQ+d8RKiEMwFP7BXecw9h+jOmt+lUDkNQ2nqVNLIruVwBGC8Tpxhb9BUtAdJOH4cEoASzEGO85AqjF1zjb6As+kRXO+7y2ZU4gxN2438eXPVocvJqZx/0eagKFLo1LqBCi3vDQOzhYQADyN37lvrTi4I5SNG/CQbjOjTOKEzIhgz+cgRa7qZw1PjlbX05TpoEnkY3Qa4LIsXpuAbo3eVNYdS1b6yg8CM2e8clIzYvLH0PKcEI1QSWAcuEWmXScuXmVF8ZEUMS451zzjRnhp4Zb5H0t1I88b1Tndi7R0/6He17yrGyJLfNbokzdMSvlV+/3HLSWynqf+VgdQv/ZHg6/jWM8cZGwXhfICAoEgRuF2aMEGp+CHNjNQJK+XrT/rcIN7yM5u0hihMynIjqNGyoJN9579FIOKc+rk7rFeLgsKHvKM8AGMm0V1e5zz8/z+UKDs6HThvzs2Zg/VdGkBVEWyqEVISjf5UTPZjHedVqIpf5A7O39+fyfL6LfCY/FdK92WMzznvWvZg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5191.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(7416002)(66476007)(1076003)(508600001)(5660300002)(33656002)(6506007)(2616005)(66946007)(6486002)(6512007)(4326008)(83380400001)(6666004)(6916009)(2906002)(38100700002)(316002)(186003)(86362001)(26005)(36756003)(54906003)(8936002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/Mw5OshZas/5yQYnYiSsLmUIdxOR1fNgwqja5eEqlKcr0nIA/i3TKThMtR1Q?=
 =?us-ascii?Q?WoXZ0CIpHgPkHOumqIg9l1/oAskqbB3PdBB3SZyLtfJEnmukwMEJvnkEq1CR?=
 =?us-ascii?Q?C3bUTFDAsZ2y0jySEHfeqM/a2D4KKxs+ML17NUQLbDv6NZ7R7AlsgOVSQ8Lg?=
 =?us-ascii?Q?5LG/69xv1j1961JA8xqrCVuxHhZVuBINKVj1vyRs+4EpIMgzk52YY/c1Xn5P?=
 =?us-ascii?Q?rRmxuZKN8AoDJfO438Zs/OnI3LK2nOCZMvbYqycptFXj8Kwk7ULCXa7iDhMD?=
 =?us-ascii?Q?34fYXg9+8znhFC86q+1Sx5lkil6omRIcRR67WVRml9hNKR758T9dt6kPfY4E?=
 =?us-ascii?Q?ai+3X8A0xaoVQ0fhyZ7QPIzRMm39/tiN1xfITM5RprVXVtCOUWLVzXWBNotg?=
 =?us-ascii?Q?Y/IvPsWEV5/Z3w8ph0CDahTXfUqR2mujkea4s/J4HeoTPB6kkpEFhlMKM+gr?=
 =?us-ascii?Q?wQgolP/LZamlKl2O7grRY1T1OMvKyfjTOxcjAbVmyImLzaEOlUl0ZPwDa7vv?=
 =?us-ascii?Q?4kryUFgzKAT5WyIPCN2k6jPHypRBRsjsjD2ZYKk8/qus9iIS6fhi+OmcCG6g?=
 =?us-ascii?Q?SavVQBwVr/D9el0zPdoeG8WIjUlWq6NCECKujZPAyi3cUjuXCFj+Nzl2M3AO?=
 =?us-ascii?Q?9oBcSolEBMsvEZRrHNSQ5SAwMxDLothgXu2m0rEMbZtp3nLmMocatVzrW5PR?=
 =?us-ascii?Q?Yu4GUVUwX0yTJzeKdnk9YOOn5deH7y5dLf3NaipZvBsgAUpWbkqpOSyckPNS?=
 =?us-ascii?Q?Yw1xmWft0Nj8TntmvEjWmB07C3ocztIIiddtV3cne5egHr3GflcZlkbs/R0a?=
 =?us-ascii?Q?nCBVDdBPVPp6jMcyDujYOW4jLbj6QizOLxd2gl+7PkqZhWS/c8gcFHlv8FcB?=
 =?us-ascii?Q?HaABwIqqawF9q/R0mcjCclIBsrMnHqPooLsg6x7/l6KBt3j0SUE5PjiwZnYt?=
 =?us-ascii?Q?quSM7Te1lFORv6LKJXhsZn4vmxeillY9+vJcvxI3Q0HINXEnPhmL7E6H/CDh?=
 =?us-ascii?Q?i7tg8j1LARChRc0iXmqc2ighQTLVokOQoMZqrTeSvwJUdVX09Y7C/axEeCg7?=
 =?us-ascii?Q?HcubfyXHM9pENNV+bLvJJjgNjVK3G4IHu/87Uz/5Kat/2jXXRNulDQONiZYD?=
 =?us-ascii?Q?qselEeHSjWaetRpPJye1fyVNYfdtyxkUO2xtzrqd4Do0po70T4CJBP/xhswK?=
 =?us-ascii?Q?3gsxlLSVLaNZI6U8liKBVASyrwuCtoOHR0cDLPsMHAAgiIdifzWVbt+juZE/?=
 =?us-ascii?Q?aQ+nCsvX++tQRHez013BLtyE4SCXYwlX6FZpH4VyKe22M4PFfisxqRKhubKu?=
 =?us-ascii?Q?fEVASUrI7jRKiZ26NtbOawaBd+0QmvAKCwnzKKNbtkmCOc2yNss6ZAhxloRv?=
 =?us-ascii?Q?1CCyQTtyu2FmCHe9rLlcb4rS4FkVDbsGC5Erl0niz6/hKcKlhwNPJVtoCYKN?=
 =?us-ascii?Q?1re++Ma3FMzxFP5xKtVLlPiI/ziTDXMpibzr1Z+xk0SpM/FYu4wmK00cZAuv?=
 =?us-ascii?Q?8YmQsIzXh8I4loS6oB/zLRlmgZ0O1xv74YGNGVfQMsxESZpm16Wvw9KZmBKi?=
 =?us-ascii?Q?ri0mUpsX0Qz+0uXqiSc=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43f9df46-1668-4fa7-d610-08d9ba62d9a0
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:53:17.2424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uAH1bFkRGXLOaZGNzvkVMqJgZJFq9xfcEU+d9QzbuL4Om25nvRL111rKzHuRt5b2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5112

On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>  arch/x86/pci/xen.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> +++ b/arch/x86/pci/xen.c
> @@ -399,9 +399,7 @@ static void xen_teardown_msi_irqs(struct
>  
>  static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
>  {
> -	struct msi_desc *msidesc = first_pci_msi_entry(dev);
> -
> -	if (msidesc->pci.msi_attrib.is_msix)
> +	if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
>  		xen_pci_frontend_disable_msix(dev);
>  	else
>  		xen_pci_frontend_disable_msi(dev);

Same remark as for power, we have a pci_dev, so can it be dev->msix_enabled?

> @@ -417,7 +415,7 @@ static int xen_msi_domain_alloc_irqs(str
>  	if (WARN_ON_ONCE(!dev_is_pci(dev)))
>  		return -EINVAL;
>  
> -	if (first_msi_entry(dev)->pci.msi_attrib.is_msix)
> +	if (msi_device_has_property(dev, MSI_PROP_PCI_MSIX))

And this WARNS if it is not a pci_dev, so same

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:54:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:54:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242341.419163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzH1-0000AF-SP; Wed, 08 Dec 2021 15:54:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242341.419163; Wed, 08 Dec 2021 15:54:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzH1-00009y-PR; Wed, 08 Dec 2021 15:54:27 +0000
Received: by outflank-mailman (input) for mailman id 242341;
 Wed, 08 Dec 2021 15:54:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cpXy=QZ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muzH1-00009f-1m
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:54:27 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1deaeec1-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:54:25 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35780)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muzGy-000pjk-8i (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 08 Dec 2021 15:54:24 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6F0AD1FDB6;
 Wed,  8 Dec 2021 15:54:24 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1deaeec1-583f-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
Date: Wed, 8 Dec 2021 15:54:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
 <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
In-Reply-To: <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 08/12/2021 14:22, Juergen Gross wrote:
> On 08.12.21 14:43, Andrew Cooper wrote:
>> On 08/12/2021 08:47, Juergen Gross wrote:
>>> The HVM parameters for pre-allocated event channels should be set in
>>> libxenguest, like it is done for PV guests and for the pre-allocated
>>> ring pages.
>>>
>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>
>> I'm not sure that we have the concept of pre-allocated ring pages.
>>
>> For PV, we have:
>>
>>      dom->console_pfn = xc_dom_alloc_page(dom, "console");
>>      if ( dom->console_pfn == INVALID_PFN )
>>          return -1;
>>      xc_clear_domain_page(dom->xch, dom->guest_domid,
>>                           xc_dom_p2m(dom, dom->console_pfn));
>>
>> and for HVM, we have:
>>
>>      dom->console_pfn = special_pfn(SPECIALPAGE_CONSOLE);
>>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
>
> Isn't that a pre-allocation? The PFNs are fixed at boot time of the
> guest.

Yeah, but "allocated in the library call we're making" is not the same
as "caller has to allocate and pass details in".

I would not class the frames as "pre-allocated" in this context. 
"allocated" sure, so perhaps "just like it is done for PV guests, and
the ring pages that libxenguest allocates" ?

>
>>
>> With a suitable tweak to the commit message (probably just deleting the
>> final clause), Reivewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>
>> That said...
>>
>>> diff --git a/tools/libs/light/libxl_dom.c
>>> b/tools/libs/light/libxl_dom.c
>>> index fe9f760f71..c9c24666cd 100644
>>> --- a/tools/libs/light/libxl_dom.c
>>> +++ b/tools/libs/light/libxl_dom.c
>>> @@ -723,9 +723,8 @@ out:
>>>     static int hvm_build_set_params(xc_interface *handle, uint32_t
>>> domid,
>>>                                   libxl_domain_build_info *info,
>>> -                                int store_evtchn, unsigned long
>>> *store_mfn,
>>> -                                int console_evtchn, unsigned long
>>> *console_mfn,
>>> -                                domid_t store_domid, domid_t
>>> console_domid)
>>> +                                unsigned long *store_mfn,
>>> +                                unsigned long *console_mfn)
>>>   {
>>>       struct hvm_info_table *va_hvm;
>>>       uint8_t *va_map, sum;
>>> @@ -752,8 +751,6 @@ static int hvm_build_set_params(xc_interface
>>> *handle, uint32_t domid,
>>>         xc_hvm_param_get(handle, domid, HVM_PARAM_STORE_PFN, &str_mfn);
>>>       xc_hvm_param_get(handle, domid, HVM_PARAM_CONSOLE_PFN,
>>> &cons_mfn);
>>
>> ... these are junk too.  I'm dismayed at how much of the toolstack tries
>> passing function parameters via HVM_PARAMS.
>>
>> libxl's HVM path ought to mirror the PV path and, after
>> libxl__build_dom() is called, just read the values back out:
>>
>> state->console_mfn = dom->console_pfn;
>> state->store_mfn = dom->xenstore_pfn;
>>
>>
>> That then leaves hvm_build_set_params() doing nothing but adjusting the
>> HVM info table for real HVM guests.  dom->max_vcpus is already present
>> which covers 2 of the 3 fields, leaving only the ACPI boolean left to
>> pass.
>>
>> So by passing the ACPI boolean down, we get rid of
>> hvm_build_set_params() entirely, which seems like a very good move.
>
> Yes, this should be in another patch, though.

Absolutely.  This wasn't a request to merge more changes into this patch.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:54:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:54:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242343.419175 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzHP-0000fg-5L; Wed, 08 Dec 2021 15:54:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242343.419175; Wed, 08 Dec 2021 15:54:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzHP-0000fZ-1R; Wed, 08 Dec 2021 15:54:51 +0000
Received: by outflank-mailman (input) for mailman id 242343;
 Wed, 08 Dec 2021 15:54:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muzHN-00008O-Un
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:54:50 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam12on2060b.outbound.protection.outlook.com
 [2a01:111:f400:fe5a::60b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2b16c51e-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:54:49 +0100 (CET)
Received: from BL1PR12MB5350.namprd12.prod.outlook.com (2603:10b6:208:31d::23)
 by BL1PR12MB5031.namprd12.prod.outlook.com (2603:10b6:208:31a::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 15:54:45 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5350.namprd12.prod.outlook.com (2603:10b6:208:31d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec
 2021 15:54:44 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:54:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b16c51e-583f-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jG4nc7UZ3iiPvfZibLDl6Au68dbmTOy0vRWFjdBjeORUsNkfj2f4xmj25fMQcaPLKxK5Qc08d/kgSqqubJPQ2xL+aUTpRgaktiGDrTEUfYt+YtfFBcbzqB9WY9FvQ9QXcYny5y9HTJ0unN9siYl47sX3bJkeDYfAhdFEruH81hJ70CrAxbGHIcxl6L3hgeR1N7ZaMSe5mJBJkniA/afIoHkV+/lK9u7cQrBR+eRa8qK2GwbrsPTLgdKVsezkouP2MvuuPXY7yUgnOvdh3HbVRVXU+OBebfMj+BVTkVRe90CBhcoBEkZAadTT9aAQOXwDsgPFFkaVu4Vx4L66h2doWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0S9D9HSbenoCsZdgUbSLEczlESblMObwYdCamPqNeJ8=;
 b=PjjDI0xD1HLaoi8LHkIpVahr9daCi4beokar1D/voM7+FZ1YUPmGsacJZp/s8p0fyCV3FVHgqThvQQwNGhk+WAbYungSlRn3NIap/cu5WzZDYQ36yssfTghPfCNmmjyM/oNRL6tAkuVlNhYFIUxwZ9Urv3WkQPpJ1NrDgT9Jyjadw8poapkYTttphDZQ1TcVrRVV4XNWtSQGTPJSV/heIjK+ZASHvFBCMW4m9BngfIXmFR0PHo9/LSG5uuo8jzOxBFkB51Wcs7nY/YTqsJyAopbLYfOIoeKTWKgTubGwVI4zYP4SjYjjReizbotxNHqaueE/Kv9vuVT79XxTVn332A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0S9D9HSbenoCsZdgUbSLEczlESblMObwYdCamPqNeJ8=;
 b=aUQ9m6qe1hMXRyHlx5vWsyc3oZzRYMS8t8yAvtuBuNwUNVd8OeeKiIKtvz64i6NYloNFMcpp/WR+pY6I0xvn+FdyKdMwICVVVBxBnPLDN59ZWKNi4667SBWMd/OgrBzgbtPLf+IYHEncvwdC4ETbjpBto86LKKr3P3e4AVGn8Wvf1zvUcXFTS42UW+1eNQiVyy+jaKDXmPRXtUtFa8SrRE+jOjNPIsBds52DXu0bee1PcioxS5VDX0rqc0Ctwimxlz6RYTv79gXjo71I17D9Fb5dVsgqJNaZ4PyIeajvBJ0DGGS255qGtQEKI/0x+Ab89HA/dI+JpAY1975QweIMkw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:54:42 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 23/36] powerpc/cell/axon_msi: Use MSI device properties
Message-ID: <20211208155442.GY6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.913603962@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.913603962@linutronix.de>
X-ClientProxiedBy: SJ0PR13CA0061.namprd13.prod.outlook.com
 (2603:10b6:a03:2c4::6) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 77e04d19-7845-4e12-165e-08d9ba630dce
X-MS-TrafficTypeDiagnostic: BL1PR12MB5350:EE_|BL1PR12MB5031:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB5350B3C88F1E00FF1E43B09BC26F9@BL1PR12MB5350.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	GS+LISBVHteK4d841oWu9hKYKQM1y6NDJhhOZSs/2MqNgq2WySGYMofcjJatgfH1IfNYwLWx1q/jJmxiL0b5+081jpBOKsqFtyuZaPNlrS3nbnOWBfpmoFvttzqdLqnm2zp6Z24krj8/foxWBDQdG8Bc1BMc7jzZMMbijdIPDUZXKMgloTuhMdy898Kf7gb+TV4JWRMgcrQW6q8zAwZjdCEgUELQQDsF2O3MSuBXumzYNYiSfqTOD2P8WEbzfj90pIj0k6Vcjb9ZFP6ccMvv5esslnYauYanDtx4HAwE0Tw7rndk+X+BaxjaVbTuKocXxIuQj4qxMLwooM4Of+2oPzLN7mCmWp7mfPSJxmpeHYHSiW6oGW2nDjxOn+lNfkOufF8woHPsvmnDAhNkkS3sN7KlIyOsgRLM6K97EJgE05Q1W48yTOwOm6POV1FlSOnpojoxPsXnbnV1R2Eb51b5wZgPofDYGkjHqXgv1Twhqn0ck+3dLYmuCjALr8MTT5a3kwT+d4ClnrXlVG0gCMwiwsOZSVztjEMHsLIjhvOPDGbYHo+19lo3WqGiRsoIoXgg+/n0uOHyDc1pHp+dXbzJV3YJr0s6p4rUlk+2LeS/QwP8llv33W+i2c06aCQ6D7fQy5ia1v7MwHprPWGelAgUVw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5350.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(316002)(6512007)(558084003)(66476007)(6506007)(186003)(8936002)(66946007)(7416002)(54906003)(508600001)(33656002)(1076003)(26005)(4326008)(5660300002)(38100700002)(86362001)(6916009)(36756003)(2616005)(8676002)(6486002)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?nMIbCOUusUhlSao/i/r5Za3Hl4BbRO+/ixs7S7Sbyo2qpr0bfkFiQlTn5Ukp?=
 =?us-ascii?Q?P9Qt4DdTE5PVo3yyhRiGRwhkA68y/LNtU52Fziau3Gl43RxMGaWptIwDIVDI?=
 =?us-ascii?Q?k2WAigMy/+uhzZX00hUDaobg5b3oHxuJ8hohRAV1v2GiLYYtM0ynZnfQQjAB?=
 =?us-ascii?Q?mlQalBjVF9cK2gjSezEAuDeHRMUbYeJ/OAaOGZgbW++PIeAbhw2UI2e0+ZX8?=
 =?us-ascii?Q?xVoUHeZoTP2UCEqqOUZbUEr6SjFkrEELyw8rS772rL5FXDa2XDp1qulBWJWG?=
 =?us-ascii?Q?R+PNZT8sIAdB6sFbvcpQjBq3OIwiZdCFvLe1ElcjRV54q5hOV2cBtmQE+lUn?=
 =?us-ascii?Q?fsXDKKt/C41q8Lv9cn1hw/3jW+fQI7fqzdozXgN1elLr5QiaoItKrB7YJItE?=
 =?us-ascii?Q?n3klZpFCv+p5y7Zker72MVCfRQXWzFXMSWZGJZWpKG7ahQF/OOIa9kc1UlXH?=
 =?us-ascii?Q?C+0irnLb+NSJiTLh8/xTRgufYznCzi4qW8GFn9ACMF+nNqqoRFQdwsJhsrR0?=
 =?us-ascii?Q?/EP6Gq9ufz86gsxSELLy8FLuUt/eo3Dpu6PZTeArAvgu4oPLxgYPgplFYnKG?=
 =?us-ascii?Q?nh9UJuW9aZnQEhPgcWruA5/EpYRuD+7FCTEXEgsmDJmGazfBa39WP+T56tfW?=
 =?us-ascii?Q?zRDWAxxBaWavK0tl/o6lPM27fgXDmntYqlNvEzCssNEyCOxpY3WKpPrnsJ5T?=
 =?us-ascii?Q?pXOJTJoHiP1jwIolm2bNVxgChb6CCxiJb7ZhRtRDUDRxYxdzAEDRV+IKb2qB?=
 =?us-ascii?Q?E/sMcNssiGLgWKB7tWVCc3IUI06cg08cOLUF8m842WhBNP1Z9pMCMD62WUq2?=
 =?us-ascii?Q?GlpIqSnJXfRnEnW+j7flQyCbCtvniyCu3M9X1Hns9xZK5ZUepyoHe3G7Kqfp?=
 =?us-ascii?Q?9PDTI0+z7ad1WLMaHctq2qtP2VO8o/+RNr+D/s4V3GCUYX4lSCp5tHPhnIRt?=
 =?us-ascii?Q?Uvg4HlKUsc/Nd2ywAUPiLeUAusZCygcQ3TZ5FV4vnCq9o2yp3mq9JS/czv7P?=
 =?us-ascii?Q?UeExS7EPn1SNq/toVVFsrJIUHSGTACMS/cs6nd3sqw9d+ClI4hneCyvgoPmh?=
 =?us-ascii?Q?b9tpH/eWfC9xVWCZsROJcNNdAnXmScNfR2pFeE8BRdyccMIWx4h7j7icAjqG?=
 =?us-ascii?Q?nLHhcdCbPo/q0L5SQvBsmFq/FGMvyKWdSEw/ED/5VXGksXQzzNzTta6rJlT9?=
 =?us-ascii?Q?OkpgW4qJC9dywL5uM4P9VisOMDYOyt8KnRx31pd9/ZwtLa+lh8qDbOc31YqY?=
 =?us-ascii?Q?D+GjF782BlTG92LcBSp7oWfgMsWJYtP+8VOS2AWRCOZa5lytxd04bvtYNs6T?=
 =?us-ascii?Q?UkSNUVhhiRF10G3Rlw/JpO4kyzLgf8Ds6NNlhxqVH3uxbgIrgIpJu0AZiGJP?=
 =?us-ascii?Q?t7wVlvw7mrfPuWXtQ1Zof62goARD19menGb2VBfHI5b6L4shE80B63Q9HftX?=
 =?us-ascii?Q?YvR1UKWxtdVpUJ4mEPASzpGNgopUVUgnpvgD7k2HCKWk7X04uXKKFpmUQS3E?=
 =?us-ascii?Q?WVKPedGQ2DNhrVJa0Ai8mExItSbcOB6/bfC00EY5gd4OTc5qND8cFWAlJ9QJ?=
 =?us-ascii?Q?Yvx8MltJjTvXH9tiE6o=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e04d19-7845-4e12-165e-08d9ba630dce
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:54:44.7180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pmTBmT44qbdWtuOamRiWQCTPBIWAzZjS3q0G0peziap0cWI7ghEGY/geYwduYXx4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5031

On Mon, Dec 06, 2021 at 11:39:33PM +0100, Thomas Gleixner wrote:

> @@ -209,10 +209,10 @@ static int setup_msi_msg_address(struct
>  		return -ENODEV;
>  	}
>  
> -	entry = first_pci_msi_entry(dev);
> +	is_64bit = msi_device_has_property(&dev->dev, MSI_PROP_64BIT);

How about  !dev->no_64bit_msi ?

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242361.419244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIn-0002cA-EC; Wed, 08 Dec 2021 15:56:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242361.419244; Wed, 08 Dec 2021 15:56:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIn-0002Yv-2d; Wed, 08 Dec 2021 15:56:17 +0000
Received: by outflank-mailman (input) for mailman id 242361;
 Wed, 08 Dec 2021 15:56:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIk-0001Lz-Gh
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:14 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5dd204a4-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:12 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2133A1FDFC;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6EF513F91;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KBcvN5vVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5dd204a4-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EIALndOIsMPGW+C03aHxK3+A8bGfi8rpQdK0dJq1lXo=;
	b=F2O0KfVMzGi7qjHBRUBkioSWQPYhFfgd35aEJkr92TkQ6A0H9JVickueP2ztqX/JaERtuE
	MaG4C/jsF/KazmVUsNn+VGMd4WEev6wZ0KCfZ7q2tS4mcAQTf5jq9Z5dzpUU4K6G96o9EL
	LuNJxO9oEWcWyOYyGzopF8TYn93V46s=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 08/13] xen/x86: don't use hypercall table for calling compat hypercalls
Date: Wed,  8 Dec 2021 16:56:01 +0100
Message-Id: <20211208155606.20029-9-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today the *_op_compat hypercalls call the modern handler functions by
using the entries from the hypercall table. This is resulting in a
not needed indirect function call which can be avoided by using the
correct handler function directly. This is basically a revert of
commit 1252e282311734 ("86/pv: Export pv_hypercall_table[] rather
than working around it in several ways"), which reasoning no longer
applies, as shim no longer modifies the hypercall table.

The hypercall table can now be made static as there is no external
reference to it any longer.

Commit 834cb8761051f7 ("x86/PV32: fix physdev_op_compat handling")
can be reverted, too, as using the direct call of the correct handler
is already handled fine without that patch.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/compat.c           | 14 ++++----------
 xen/arch/x86/pv/hypercall.c     |  9 ++++++++-
 xen/arch/x86/x86_64/compat.c    |  1 -
 xen/include/asm-x86/hypercall.h |  8 --------
 4 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/xen/arch/x86/compat.c b/xen/arch/x86/compat.c
index 58b202f701..939b449dec 100644
--- a/xen/arch/x86/compat.c
+++ b/xen/arch/x86/compat.c
@@ -17,14 +17,12 @@ typedef long ret_t;
 /* Legacy hypercall (as of 0x00030202). */
 ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 {
-    typeof(do_physdev_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_physdev_op].native;
     struct physdev_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
         return -EFAULT;
 
-    return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+    return do_physdev_op(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
 }
 
 #ifndef COMPAT
@@ -32,14 +30,11 @@ ret_t do_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
 /* Legacy hypercall (as of 0x00030101). */
 long do_sched_op_compat(int cmd, unsigned long arg)
 {
-    typeof(do_sched_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_sched_op].native;
-
     switch ( cmd )
     {
     case SCHEDOP_yield:
     case SCHEDOP_block:
-        return fn(cmd, guest_handle_from_ptr(NULL, void));
+        return do_sched_op(cmd, guest_handle_from_ptr(NULL, void));
 
     case SCHEDOP_shutdown:
         TRACE_3D(TRC_SCHED_SHUTDOWN,
@@ -57,8 +52,6 @@ long do_sched_op_compat(int cmd, unsigned long arg)
 /* Legacy hypercall (as of 0x00030202). */
 long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
 {
-    typeof(do_event_channel_op) *fn =
-        (void *)pv_hypercall_table[__HYPERVISOR_event_channel_op].native;
     struct evtchn_op op;
 
     if ( unlikely(copy_from_guest(&op, uop, 1) != 0) )
@@ -76,7 +69,8 @@ long do_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
     case EVTCHNOP_bind_ipi:
     case EVTCHNOP_bind_vcpu:
     case EVTCHNOP_unmask:
-        return fn(op.cmd, guest_handle_from_ptr(&uop.p->u, void));
+        return do_event_channel_op(op.cmd,
+                                   guest_handle_from_ptr(&uop.p->u, void));
 
     default:
         return -ENOSYS;
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index abe4dd7839..c391d18130 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -27,6 +27,13 @@
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
+typedef struct {
+    hypercall_fn_t *native;
+#ifdef CONFIG_PV32
+    hypercall_fn_t *compat;
+#endif
+} pv_hypercall_table_t;
+
 #ifdef CONFIG_PV32
 #define HYPERCALL(x)                                                \
     [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
@@ -40,7 +47,7 @@
 #define COMPAT_CALL(x) HYPERCALL(x)
 #endif
 
-const pv_hypercall_table_t pv_hypercall_table[] = {
+static const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(set_trap_table),
     HYPERCALL(mmu_update),
     COMPAT_CALL(set_gdt),
diff --git a/xen/arch/x86/x86_64/compat.c b/xen/arch/x86/x86_64/compat.c
index fcbc1cc0d7..0e4c71f2aa 100644
--- a/xen/arch/x86/x86_64/compat.c
+++ b/xen/arch/x86/x86_64/compat.c
@@ -12,7 +12,6 @@ EMIT_FILE;
 #define physdev_op_t                  physdev_op_compat_t
 #define do_physdev_op                 compat_physdev_op
 #define do_physdev_op_compat(x)       compat_physdev_op_compat(_##x)
-#define native                        compat
 
 #define COMPAT
 #define _XEN_GUEST_HANDLE(t) XEN_GUEST_HANDLE(t)
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 2547572ccd..eb2907b5b6 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -21,13 +21,6 @@ typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long, unsigned long,
     unsigned long, unsigned long);
 
-typedef struct {
-    hypercall_fn_t *native;
-#ifdef CONFIG_PV32
-    hypercall_fn_t *compat;
-#endif
-} pv_hypercall_table_t;
-
 typedef struct {
     uint8_t native;
 #ifdef CONFIG_COMPAT
@@ -38,7 +31,6 @@ typedef struct {
 extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
 
 #ifdef CONFIG_PV
-extern const pv_hypercall_table_t pv_hypercall_table[];
 void pv_hypercall(struct cpu_user_regs *regs);
 #endif
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242355.419191 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIi-0001Oi-RW; Wed, 08 Dec 2021 15:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242355.419191; Wed, 08 Dec 2021 15:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIi-0001Nc-Lm; Wed, 08 Dec 2021 15:56:12 +0000
Received: by outflank-mailman (input) for mailman id 242355;
 Wed, 08 Dec 2021 15:56:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIh-0001Lz-Nc
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:11 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c9fec9a-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:10 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1EE312113A;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CBC8913F91;
 Wed,  8 Dec 2021 15:56:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id uMW1MJnVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c9fec9a-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FlS8C8pTHUC6JbtaYLzXhbhXJUoUDmpJnMmf+HYN34I=;
	b=ooH4SqaphRsimhkuvj7/qhy4maS6M2xcLNkXiqUvRfGW+pAgWCs6ZTxPDTt2XYwwzxtCwE
	pueabQML9WkYAXfoBGjVcPG8grZZ6rMUnLwCWHCpdLaBYfuXnF3ShjpYCDkAtDkYTellxA
	Ph5ExecRE1zwLjucV7tcGxE38lh30Po=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code
Date: Wed,  8 Dec 2021 16:55:54 +0100
Message-Id: <20211208155606.20029-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today Arm is using another entry point for the vcpu_op hypercall as
x86, as some of the common sub-ops are not supported on Arm. The Arm
specific handler filetrs out the not supported sub-ops and then calls
the common handler. This leads to the weird call hierarchy:

  do_arm_vcpu_op()
    do_vcpu_op()
      arch_do_vcpu_op()

Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
of above calls can be avoided without restricting any potential
future use of common sub-ops for Arm.

Additionally the single user of HYPERCALL_ARM() can be modified and
HYPERCALL_ARM() can be removed.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/arch/arm/domain.c           | 15 ++++++++-------
 xen/arch/arm/traps.c            |  7 +------
 xen/arch/x86/domain.c           | 11 +++++++----
 xen/arch/x86/x86_64/domain.c    | 16 ++++++++++++----
 xen/common/compat/domain.c      | 14 ++++++--------
 xen/common/domain.c             | 11 ++++-------
 xen/include/asm-arm/hypercall.h |  2 --
 xen/include/asm-x86/hypercall.h |  2 +-
 xen/include/xen/hypercall.h     |  2 +-
 9 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 96e1b23550..691a14277e 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -1074,23 +1074,24 @@ void arch_dump_domain_info(struct domain *d)
 }
 
 
-long do_arm_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
+
     switch ( cmd )
     {
         case VCPUOP_register_vcpu_info:
         case VCPUOP_register_runstate_memory_area:
-            return do_vcpu_op(cmd, vcpuid, arg);
+            return common_vcpu_op(cmd, v, arg);
         default:
             return -EINVAL;
     }
 }
 
-long arch_do_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
-{
-    return -ENOSYS;
-}
-
 void arch_dump_vcpu_info(struct vcpu *v)
 {
     gic_dump_info(v);
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 219ab3c3fb..7abc28848e 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1351,11 +1351,6 @@ typedef struct {
         .nr_args = _nr_args,                                         \
     }
 
-#define HYPERCALL_ARM(_name, _nr_args)                        \
-    [ __HYPERVISOR_ ## _name ] =  {                                  \
-        .fn = (arm_hypercall_fn_t) &do_arm_ ## _name,                \
-        .nr_args = _nr_args,                                         \
-    }
 /*
  * Only use this for hypercalls which were deprecated (i.e. replaced
  * by something else) before Xen on ARM was created, i.e. *not* for
@@ -1386,7 +1381,7 @@ static arm_hypercall_t arm_hypercall_table[] = {
 #endif
     HYPERCALL(multicall, 2),
     HYPERCALL(platform_op, 1),
-    HYPERCALL_ARM(vcpu_op, 3),
+    HYPERCALL(vcpu_op, 3),
     HYPERCALL(vm_assist, 2),
 #ifdef CONFIG_ARGO
     HYPERCALL(argo_op, 5),
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..e1440ec2f5 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1488,11 +1488,14 @@ int arch_vcpu_reset(struct vcpu *v)
     return 0;
 }
 
-long
-arch_do_vcpu_op(
-    int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc = 0;
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
 
     switch ( cmd )
     {
@@ -1544,7 +1547,7 @@ arch_do_vcpu_op(
     }
 
     default:
-        rc = -ENOSYS;
+        rc = common_vcpu_op(cmd, v, arg);
         break;
     }
 
diff --git a/xen/arch/x86/x86_64/domain.c b/xen/arch/x86/x86_64/domain.c
index c46dccc25a..62fe51ee74 100644
--- a/xen/arch/x86/x86_64/domain.c
+++ b/xen/arch/x86/x86_64/domain.c
@@ -13,10 +13,14 @@ CHECK_vcpu_get_physid;
 #undef xen_vcpu_get_physid
 
 int
-arch_compat_vcpu_op(
-    int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
+compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    int rc = -ENOSYS;
+    int rc;
+    struct domain *d = current->domain;
+    struct vcpu *v;
+
+    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
+        return -ENOENT;
 
     switch ( cmd )
     {
@@ -55,7 +59,11 @@ arch_compat_vcpu_op(
     }
 
     case VCPUOP_get_physid:
-        rc = arch_do_vcpu_op(cmd, v, arg);
+        rc = do_vcpu_op(cmd, vcpuid, arg);
+        break;
+
+    default:
+        rc = compat_common_vcpu_op(cmd, v, arg);
         break;
     }
 
diff --git a/xen/common/compat/domain.c b/xen/common/compat/domain.c
index 98b8c15cea..1119534679 100644
--- a/xen/common/compat/domain.c
+++ b/xen/common/compat/domain.c
@@ -38,14 +38,12 @@ CHECK_vcpu_hvm_context;
 
 #endif
 
-int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+int compat_common_vcpu_op(int cmd, struct vcpu *v,
+                          XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    struct domain *d = current->domain;
-    struct vcpu *v;
     int rc = 0;
-
-    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
-        return -ENOENT;
+    struct domain *d = current->domain;
+    unsigned int vcpuid = v->vcpu_id;
 
     switch ( cmd )
     {
@@ -102,7 +100,7 @@ int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) ar
     case VCPUOP_stop_singleshot_timer:
     case VCPUOP_register_vcpu_info:
     case VCPUOP_send_nmi:
-        rc = do_vcpu_op(cmd, vcpuid, arg);
+        rc = common_vcpu_op(cmd, v, arg);
         break;
 
     case VCPUOP_get_runstate_info:
@@ -133,7 +131,7 @@ int compat_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) ar
     }
 
     default:
-        rc = arch_compat_vcpu_op(cmd, v, arg);
+        rc = -ENOSYS;
         break;
     }
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 093bb4403f..5fadd5c196 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -1558,14 +1558,11 @@ int default_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
     return rc;
 }
 
-long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
+long common_vcpu_op(int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
-    struct domain *d = current->domain;
-    struct vcpu *v;
     long rc = 0;
-
-    if ( (v = domain_vcpu(d, vcpuid)) == NULL )
-        return -ENOENT;
+    struct domain *d = current->domain;
+    unsigned int vcpuid = v->vcpu_id;
 
     switch ( cmd )
     {
@@ -1737,7 +1734,7 @@ long do_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg)
     }
 
     default:
-        rc = arch_do_vcpu_op(cmd, v, arg);
+        rc = -ENOSYS;
         break;
     }
 
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index a0c5a31a2f..9fd13c6b2c 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -4,8 +4,6 @@
 #include <public/domctl.h> /* for arch_do_domctl */
 int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-long do_arm_vcpu_op(int cmd, unsigned int vcpuid, XEN_GUEST_HANDLE_PARAM(void) arg);
-
 long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                        XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 5d394d4923..e614f7c78c 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -152,7 +152,7 @@ compat_physdev_op(
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
 extern int
-arch_compat_vcpu_op(
+compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
 extern int compat_mmuext_op(
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 07b10ec230..30558d3c61 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -110,7 +110,7 @@ do_vcpu_op(
 
 struct vcpu;
 extern long
-arch_do_vcpu_op(int cmd,
+common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242354.419186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIi-0001ML-H7; Wed, 08 Dec 2021 15:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242354.419186; Wed, 08 Dec 2021 15:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIi-0001ME-DC; Wed, 08 Dec 2021 15:56:12 +0000
Received: by outflank-mailman (input) for mailman id 242354;
 Wed, 08 Dec 2021 15:56:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIh-0001LM-66
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:11 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c89904e-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:10 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C80A21FD3E;
 Wed,  8 Dec 2021 15:56:09 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7741C13C8E;
 Wed,  8 Dec 2021 15:56:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id PW7OG5nVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c89904e-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=rQV7j0YW8AXR7oZuq5XEnisypq+N6I53xv0CTVE9+3M=;
	b=fiptY8MRyhZZUaImPizpJyybGwmsWQ+BlfeYSgYQ+HwpX+WLMq9CrLLjN82MSFczMNGUxu
	PJ6wIA7lA66VyB4gtQjL+dSj19kosRqmyU/n6Os9apeT9N6BmLU7WKadgW0jA5z6ymdd4u
	WsxH1rzcBfvFDHssuvwplK0w2zhL7ao=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH v3 00/13] xen: drop hypercall function tables
Date: Wed,  8 Dec 2021 16:55:53 +0100
Message-Id: <20211208155606.20029-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In order to avoid indirect function calls on the hypercall path as
much as possible this series is removing the hypercall function tables
and is replacing the hypercall handler calls via the function array
by automatically generated call macros.

Another by-product of generating the call macros is the automatic
generating of the hypercall handler prototypes from the same data base
which is used to generate the macros.

This has the additional advantage of using type safe calls of the
handlers and to ensure related handler (e.g. PV and HVM ones) share
the same prototypes.

A very brief performance test (parallel build of the Xen hypervisor
in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
the performance with the patches applied. The test was performed using
a PV and a PVH guest.

Changes in V2:
- new patches 6, 14, 15
- patch 7: support hypercall priorities for faster code
- comments addressed

Changes in V3:
- patches 1 and 4 removed as already applied
- comments addressed

Juergen Gross (13):
  xen: move do_vcpu_op() to arch specific code
  xen: harmonize return types of hypercall handlers
  xen: don't include asm/hypercall.h from C sources
  xen: include compat/platform.h from hypercall.h
  xen: generate hypercall interface related code
  xen: use generated prototypes for hypercall handlers
  x86/pv-shim: don't modify hypercall table
  xen/x86: don't use hypercall table for calling compat hypercalls
  xen/x86: call hypercall handlers via generated macro
  xen/arm: call hypercall handlers via generated macro
  xen/x86: add hypercall performance counters for hvm, correct pv
  xen: drop calls_to_multicall performance counter
  tools/xenperf: update hypercall names

 .gitignore                               |   1 +
 tools/misc/xenperf.c                     |   5 +
 xen/arch/arm/domain.c                    |  15 +-
 xen/arch/arm/hvm.c                       |   3 +-
 xen/arch/arm/physdev.c                   |   2 +-
 xen/arch/arm/platform_hypercall.c        |   1 +
 xen/arch/arm/traps.c                     | 124 ++-------
 xen/arch/x86/compat.c                    |  14 +-
 xen/arch/x86/cpu/vpmu.c                  |   1 +
 xen/arch/x86/domain.c                    |  11 +-
 xen/arch/x86/domctl.c                    |   4 +-
 xen/arch/x86/hvm/hypercall.c             | 178 ++-----------
 xen/arch/x86/hypercall.c                 |  59 -----
 xen/arch/x86/mm.c                        |   1 -
 xen/arch/x86/mm/paging.c                 |   3 +-
 xen/arch/x86/platform_hypercall.c        |   1 +
 xen/arch/x86/pv/callback.c               |  20 +-
 xen/arch/x86/pv/emul-priv-op.c           |   2 +-
 xen/arch/x86/pv/hypercall.c              | 182 ++-----------
 xen/arch/x86/pv/iret.c                   |   5 +-
 xen/arch/x86/pv/misc-hypercalls.c        |  14 +-
 xen/arch/x86/pv/shim.c                   |  54 ++--
 xen/arch/x86/traps.c                     |   2 +-
 xen/arch/x86/x86_64/compat.c             |   1 -
 xen/arch/x86/x86_64/compat/mm.c          |   1 +
 xen/arch/x86/x86_64/domain.c             |  16 +-
 xen/arch/x86/x86_64/mm.c                 |   2 -
 xen/arch/x86/x86_64/platform_hypercall.c |   3 +-
 xen/common/argo.c                        |  12 +-
 xen/common/compat/domain.c               |  14 +-
 xen/common/compat/grant_table.c          |   1 +
 xen/common/compat/multicall.c            |   2 +-
 xen/common/domain.c                      |  11 +-
 xen/common/event_channel.c               |  10 +
 xen/common/grant_table.c                 |  10 +
 xen/common/kexec.c                       |   6 +-
 xen/common/multicall.c                   |   2 +-
 xen/include/Makefile                     |  13 +
 xen/include/asm-arm/hypercall.h          |   7 +-
 xen/include/asm-x86/hypercall.h          | 205 ++++-----------
 xen/include/asm-x86/paging.h             |   3 -
 xen/include/asm-x86/pv/shim.h            |   3 +
 xen/include/hypercall-defs.c             | 280 ++++++++++++++++++++
 xen/include/xen/hypercall.h              | 184 +------------
 xen/include/xen/perfc_defn.h             |   1 -
 xen/scripts/gen_hypercall.awk            | 314 +++++++++++++++++++++++
 46 files changed, 874 insertions(+), 929 deletions(-)
 create mode 100644 xen/include/hypercall-defs.c
 create mode 100644 xen/scripts/gen_hypercall.awk

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242356.419200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIj-0001cQ-I1; Wed, 08 Dec 2021 15:56:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242356.419200; Wed, 08 Dec 2021 15:56:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIj-0001ZZ-88; Wed, 08 Dec 2021 15:56:13 +0000
Received: by outflank-mailman (input) for mailman id 242356;
 Wed, 08 Dec 2021 15:56:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIi-0001LM-8H
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:12 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cf46439-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:10 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 85A881FD56;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2694F13C8E;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id oNRBCJrVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cf46439-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5RvWk4roYW8A4zrziOmqX0VjX+cRK9Rbg79f3SbZ5HQ=;
	b=aYWl+u2THaZ1bA1oeNVptIpjGPkv1tO5nATYVwVTEG1SwLAL0l1D8mtiM3e78+b/ipZSj8
	QyoyBun/SFXY7t5WlzOeYi2LauyEooS5xmrI/Ms8zvI5s+Dlunm0rQg40Cij8lpBRPTL3G
	gxDpnDZFrHnd+RRAFRx/laevCEYqUM4=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Christopher Clark <christopher.w.clark@gmail.com>
Subject: [PATCH v3 02/13] xen: harmonize return types of hypercall handlers
Date: Wed,  8 Dec 2021 16:55:55 +0100
Message-Id: <20211208155606.20029-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today most hypercall handlers have a return type of long, while the
compat ones return an int. There are a few exceptions from that rule,
however.

Get rid of the exceptions by letting compat handlers always return int
and others always return long.

For the compat hvm case use eax instead of rax for the stored result as
it should have been from the beginning.

Additionally move some prototypes to include/asm-x86/hypercall.h
as they are x86 specific. Move the do_physdev_op() prototype from both
architecture dependant headers to the common one. Move the
compat_platform_op() prototype to the common header.

Switch some non style compliant types (u32, s32, s64) to style compliant
ones.

Rename paging_domctl_continuation() to do_paging_domctl_cont() and add
a matching define for the associated hypercall.

Make do_callback_op() and compat_callback_op() more similar by adding
the const attribute to compat_callback_op()'s 2nd parameter.

Change the type of the cmd parameter for [do|compat]_kexec_op() to
unsigned int, as this is more appropriate for the compat case.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- rework platform_op compat handling (Jan Beulich)
V3:
- remove include of types.h (Jan Beulich)
---
 xen/arch/arm/physdev.c                   |  2 +-
 xen/arch/x86/domctl.c                    |  4 +--
 xen/arch/x86/hvm/hypercall.c             |  8 ++---
 xen/arch/x86/hypercall.c                 |  2 +-
 xen/arch/x86/mm/paging.c                 |  3 +-
 xen/arch/x86/pv/callback.c               | 20 +++++------
 xen/arch/x86/pv/emul-priv-op.c           |  2 +-
 xen/arch/x86/pv/hypercall.c              |  5 +--
 xen/arch/x86/pv/iret.c                   |  4 +--
 xen/arch/x86/pv/misc-hypercalls.c        | 14 +++++---
 xen/arch/x86/x86_64/platform_hypercall.c |  2 +-
 xen/common/argo.c                        | 12 +++----
 xen/common/kexec.c                       |  6 ++--
 xen/include/asm-arm/hypercall.h          |  1 -
 xen/include/asm-x86/hypercall.h          | 43 +++++++++++-------------
 xen/include/asm-x86/paging.h             |  3 --
 xen/include/xen/hypercall.h              | 26 +++++++-------
 17 files changed, 74 insertions(+), 83 deletions(-)

diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c
index f9aa274dda..5a7593fa8f 100644
--- a/xen/arch/arm/physdev.c
+++ b/xen/arch/arm/physdev.c
@@ -11,7 +11,7 @@
 #include <xen/hypercall.h>
 
 
-int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
 #ifdef CONFIG_HAS_PCI
     return pci_physdev_op(cmd, arg);
diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c
index 7d102e0647..b01ea81373 100644
--- a/xen/arch/x86/domctl.c
+++ b/xen/arch/x86/domctl.c
@@ -221,8 +221,8 @@ long arch_do_domctl(
     case XEN_DOMCTL_shadow_op:
         ret = paging_domctl(d, &domctl->u.shadow_op, u_domctl, 0);
         if ( ret == -ERESTART )
-            return hypercall_create_continuation(__HYPERVISOR_arch_1,
-                                                 "h", u_domctl);
+            return hypercall_create_continuation(
+                       __HYPERVISOR_paging_domctl_cont, "h", u_domctl);
         copyback = true;
         break;
 
diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 1f04ffb272..9d3b193bad 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -120,8 +120,6 @@ static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
     [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
                                (hypercall_fn_t *) compat_ ## x }
 
-#define do_arch_1             paging_domctl_continuation
-
 static const struct {
     hypercall_fn_t *native, *compat;
 } hvm_hypercall_table[] = {
@@ -154,11 +152,9 @@ static const struct {
 #ifdef CONFIG_HYPFS
     HYPERCALL(hypfs_op),
 #endif
-    HYPERCALL(arch_1)
+    HYPERCALL(paging_domctl_cont)
 };
 
-#undef do_arch_1
-
 #undef HYPERCALL
 #undef HVM_CALL
 #undef COMPAT_CALL
@@ -296,7 +292,7 @@ int hvm_hypercall(struct cpu_user_regs *regs)
 #endif
 
         curr->hcall_compat = true;
-        regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
 #ifndef NDEBUG
diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c
index 2370d31d3f..07e1a45ef5 100644
--- a/xen/arch/x86/hypercall.c
+++ b/xen/arch/x86/hypercall.c
@@ -75,7 +75,7 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] =
     ARGS(dm_op, 3),
     ARGS(hypfs_op, 5),
     ARGS(mca, 1),
-    ARGS(arch_1, 1),
+    ARGS(paging_domctl_cont, 1),
 };
 
 #undef COMP
diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c
index dd6b2bdf6f..6cc2636bf4 100644
--- a/xen/arch/x86/mm/paging.c
+++ b/xen/arch/x86/mm/paging.c
@@ -21,6 +21,7 @@
 
 #include <xen/init.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <asm/paging.h>
 #include <asm/shadow.h>
 #include <asm/p2m.h>
@@ -756,7 +757,7 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
         return shadow_domctl(d, sc, u_domctl);
 }
 
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
+long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
 {
     struct xen_domctl op;
     struct domain *d;
diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c
index 42a6aa0831..6d60263dbc 100644
--- a/xen/arch/x86/pv/callback.c
+++ b/xen/arch/x86/pv/callback.c
@@ -207,9 +207,9 @@ long do_set_callbacks(unsigned long event_address,
 #include <compat/callback.h>
 #include <compat/nmi.h>
 
-static long compat_register_guest_callback(struct compat_callback_register *reg)
+static int compat_register_guest_callback(struct compat_callback_register *reg)
 {
-    long ret = 0;
+    int ret = 0;
     struct vcpu *curr = current;
 
     fixup_guest_code_selector(curr->domain, reg->address.cs);
@@ -256,10 +256,10 @@ static long compat_register_guest_callback(struct compat_callback_register *reg)
     return ret;
 }
 
-static long compat_unregister_guest_callback(
+static int compat_unregister_guest_callback(
     struct compat_callback_unregister *unreg)
 {
-    long ret;
+    int ret;
 
     switch ( unreg->type )
     {
@@ -283,9 +283,9 @@ static long compat_unregister_guest_callback(
     return ret;
 }
 
-long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
+int compat_callback_op(int cmd, XEN_GUEST_HANDLE(const_void) arg)
 {
-    long ret;
+    int ret;
 
     switch ( cmd )
     {
@@ -321,10 +321,10 @@ long compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg)
     return ret;
 }
 
-long compat_set_callbacks(unsigned long event_selector,
-                          unsigned long event_address,
-                          unsigned long failsafe_selector,
-                          unsigned long failsafe_address)
+int compat_set_callbacks(unsigned long event_selector,
+                         unsigned long event_address,
+                         unsigned long failsafe_selector,
+                         unsigned long failsafe_address)
 {
     struct compat_callback_register event = {
         .type = CALLBACKTYPE_event,
diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
index 8ba65178e9..e0d74365f2 100644
--- a/xen/arch/x86/pv/emul-priv-op.c
+++ b/xen/arch/x86/pv/emul-priv-op.c
@@ -22,12 +22,12 @@
 #include <xen/domain_page.h>
 #include <xen/event.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/iocap.h>
 
 #include <asm/amd.h>
 #include <asm/debugreg.h>
 #include <asm/hpet.h>
-#include <asm/hypercall.h>
 #include <asm/mc146818rtc.h>
 #include <asm/pv/domain.h>
 #include <asm/pv/trace.h>
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 16a77e3a35..7e99dbda34 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -40,8 +40,6 @@
 #define COMPAT_CALL(x) HYPERCALL(x)
 #endif
 
-#define do_arch_1             paging_domctl_continuation
-
 const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(set_trap_table),
     HYPERCALL(mmu_update),
@@ -102,11 +100,10 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
 #endif
     HYPERCALL(mca),
 #ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(arch_1),
+    HYPERCALL(paging_domctl_cont),
 #endif
 };
 
-#undef do_arch_1
 #undef COMPAT_CALL
 #undef HYPERCALL
 
diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c
index 29a2f7cc45..90946c4629 100644
--- a/xen/arch/x86/pv/iret.c
+++ b/xen/arch/x86/pv/iret.c
@@ -48,7 +48,7 @@ static void async_exception_cleanup(struct vcpu *curr)
         curr->arch.async_exception_state(trap).old_mask;
 }
 
-unsigned long do_iret(void)
+long do_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct iret_context iret_saved;
@@ -105,7 +105,7 @@ unsigned long do_iret(void)
 }
 
 #ifdef CONFIG_PV32
-unsigned int compat_iret(void)
+int compat_iret(void)
 {
     struct cpu_user_regs *regs = guest_cpu_user_regs();
     struct vcpu *v = current;
diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c
index 5dade24726..aaaf70eb63 100644
--- a/xen/arch/x86/pv/misc-hypercalls.c
+++ b/xen/arch/x86/pv/misc-hypercalls.c
@@ -28,12 +28,16 @@ long do_set_debugreg(int reg, unsigned long value)
     return set_debugreg(current, reg, value);
 }
 
-unsigned long do_get_debugreg(int reg)
+long do_get_debugreg(int reg)
 {
-    unsigned long val;
-    int res = x86emul_read_dr(reg, &val, NULL);
-
-    return res == X86EMUL_OKAY ? val : -ENODEV;
+    /* Avoid implementation defined behavior casting unsigned long to long. */
+    union {
+        unsigned long val;
+        long ret;
+    } u;
+    int res = x86emul_read_dr(reg, &u.val, NULL);
+
+    return res == X86EMUL_OKAY ? u.ret : -ENODEV;
 }
 
 long do_fpu_taskswitch(int set)
diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index fbba893a47..f84252bac6 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -4,10 +4,10 @@
 
 EMIT_FILE;
 
+#include <xen/hypercall.h>
 #include <xen/lib.h>
 #include <compat/platform.h>
 
-DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 #define xen_platform_op     compat_platform_op
 #define xen_platform_op_t   compat_platform_op_t
 #define do_platform_op(x)   compat_platform_op(_##x)
diff --git a/xen/common/argo.c b/xen/common/argo.c
index eaea7ba888..bf6aac7655 100644
--- a/xen/common/argo.c
+++ b/xen/common/argo.c
@@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
 }
 
 #ifdef CONFIG_COMPAT
-long
-compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
-               XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3,
-               unsigned long arg4)
+int compat_argo_op(unsigned int cmd,
+                   XEN_GUEST_HANDLE_PARAM(void) arg1,
+                   XEN_GUEST_HANDLE_PARAM(void) arg2,
+                   unsigned long arg3, unsigned long arg4)
 {
     struct domain *currd = current->domain;
-    long rc;
+    int rc;
     xen_argo_send_addr_t send_addr;
     xen_argo_iov_t iovs[XEN_ARGO_MAXIOV];
     compat_argo_iov_t compat_iovs[XEN_ARGO_MAXIOV];
@@ -2267,7 +2267,7 @@ compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1,
 
     rc = sendv(currd, &send_addr.src, &send_addr.dst, iovs, niov, arg4);
  out:
-    argo_dprintk("<-compat_argo_op(%u)=%ld\n", cmd, rc);
+    argo_dprintk("<-compat_argo_op(%u)=%d\n", cmd, rc);
 
     return rc;
 }
diff --git a/xen/common/kexec.c b/xen/common/kexec.c
index c63db618a7..d7373233e1 100644
--- a/xen/common/kexec.c
+++ b/xen/common/kexec.c
@@ -1213,7 +1213,7 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) uarg)
     return !!test_bit(bit, &kexec_flags);
 }
 
-static int do_kexec_op_internal(unsigned long op,
+static int do_kexec_op_internal(unsigned int op,
                                 XEN_GUEST_HANDLE_PARAM(void) uarg,
                                 bool_t compat)
 {
@@ -1265,13 +1265,13 @@ static int do_kexec_op_internal(unsigned long op,
     return ret;
 }
 
-long do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+long do_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 0);
 }
 
 #ifdef CONFIG_COMPAT
-int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg)
+int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg)
 {
     return do_kexec_op_internal(op, uarg, 1);
 }
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index 9fd13c6b2c..cadafd76c7 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -2,7 +2,6 @@
 #define __ASM_ARM_HYPERCALL_H__
 
 #include <public/domctl.h> /* for arch_do_domctl */
-int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
 long subarch_do_domctl(struct xen_domctl *domctl, struct domain *d,
                        XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index e614f7c78c..9c0981defd 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -11,6 +11,8 @@
 #include <public/arch-x86/xen-mca.h> /* for do_mca */
 #include <asm/paging.h>
 
+#define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1
+
 typedef unsigned long hypercall_fn_t(
     unsigned long, unsigned long, unsigned long,
     unsigned long, unsigned long);
@@ -88,7 +90,7 @@ do_set_debugreg(
     int reg,
     unsigned long value);
 
-extern unsigned long
+extern long
 do_get_debugreg(
     int reg);
 
@@ -102,17 +104,13 @@ do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc);
 extern long
 do_update_va_mapping(
     unsigned long va,
-    u64 val64,
+    uint64_t val64,
     unsigned long flags);
 
-extern long
-do_physdev_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern long
 do_update_va_mapping_otherdomain(
     unsigned long va,
-    u64 val64,
+    uint64_t val64,
     unsigned long flags,
     domid_t domid);
 
@@ -126,7 +124,7 @@ do_mmuext_op(
 extern long do_callback_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg);
 
-extern unsigned long
+extern long
 do_iret(
     void);
 
@@ -141,16 +139,18 @@ do_set_segment_base(
     unsigned int which,
     unsigned long base);
 
+long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
+long do_xenpmu_op(unsigned int op,
+                  XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
+
+long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+
 #ifdef CONFIG_COMPAT
 
 #include <compat/arch-x86/xen.h>
 #include <compat/physdev.h>
 
-extern int
-compat_physdev_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern int
 compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
@@ -161,17 +161,14 @@ extern int compat_mmuext_op(
     XEN_GUEST_HANDLE_PARAM(uint) pdone,
     unsigned int foreigndom);
 
-extern int compat_platform_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xenpf_op);
-
-extern long compat_callback_op(
-    int cmd, XEN_GUEST_HANDLE(void) arg);
+extern int compat_callback_op(
+    int cmd, XEN_GUEST_HANDLE(const_void) arg);
 
 extern int compat_update_va_mapping(
-    unsigned int va, u32 lo, u32 hi, unsigned int flags);
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags);
 
 extern int compat_update_va_mapping_otherdomain(
-    unsigned int va, u32 lo, u32 hi, unsigned int flags, domid_t domid);
+    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid);
 
 DEFINE_XEN_GUEST_HANDLE(trap_info_compat_t);
 extern int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps);
@@ -180,13 +177,13 @@ extern int compat_set_gdt(
     XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries);
 
 extern int compat_update_descriptor(
-    u32 pa_lo, u32 pa_hi, u32 desc_lo, u32 desc_hi);
+    uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi);
 
-extern unsigned int compat_iret(void);
+extern int compat_iret(void);
 
 extern int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long compat_set_callbacks(
+extern int compat_set_callbacks(
     unsigned long event_selector, unsigned long event_address,
     unsigned long failsafe_selector, unsigned long failsafe_address);
 
diff --git a/xen/include/asm-x86/paging.h b/xen/include/asm-x86/paging.h
index 308f1115dd..9cc5d383a4 100644
--- a/xen/include/asm-x86/paging.h
+++ b/xen/include/asm-x86/paging.h
@@ -234,9 +234,6 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc,
                   XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl,
                   bool_t resuming);
 
-/* Helper hypercall for dealing with continuations. */
-long paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
-
 /* Call when destroying a vcpu/domain */
 void paging_vcpu_teardown(struct vcpu *v);
 int paging_teardown(struct domain *d);
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 30558d3c61..9266bc86e9 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -114,11 +114,6 @@ common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_nmi_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
 extern long
 do_hvm_op(
     unsigned long op,
@@ -126,13 +121,15 @@ do_hvm_op(
 
 extern long
 do_kexec_op(
-    unsigned long op,
+    unsigned int op,
     XEN_GUEST_HANDLE_PARAM(void) uarg);
 
 extern long
 do_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) u_xsm_op);
 
+long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
 #ifdef CONFIG_ARGO
 extern long do_argo_op(
     unsigned int cmd,
@@ -145,9 +142,6 @@ extern long do_argo_op(
 extern long
 do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
-
 extern long
 do_dm_op(
     domid_t domid,
@@ -198,21 +192,27 @@ compat_sched_op(
 
 extern int
 compat_set_timer_op(
-    u32 lo,
-    s32 hi);
+    uint32_t lo,
+    int32_t hi);
 
 extern int compat_xsm_op(
     XEN_GUEST_HANDLE_PARAM(void) op);
 
-extern int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg);
+extern int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg);
 
 DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 extern int compat_multicall(
     XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list,
     uint32_t nr_calls);
 
+int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
+
+typedef struct compat_platform_op compat_platform_op_t;
+DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
+int compat_platform_op(XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
+
 #ifdef CONFIG_ARGO
-extern long compat_argo_op(
+extern int compat_argo_op(
     unsigned int cmd,
     XEN_GUEST_HANDLE_PARAM(void) arg1,
     XEN_GUEST_HANDLE_PARAM(void) arg2,
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242357.419208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIk-0001iP-3q; Wed, 08 Dec 2021 15:56:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242357.419208; Wed, 08 Dec 2021 15:56:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIj-0001gA-Md; Wed, 08 Dec 2021 15:56:13 +0000
Received: by outflank-mailman (input) for mailman id 242357;
 Wed, 08 Dec 2021 15:56:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIi-0001Lz-Ga
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:12 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d38a5f9-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:11 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1519A218A4;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CCF3213C8E;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QFTgMJrVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d38a5f9-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uDgmq3e5kxnaWyOpwcnlt0BHxsMjaRjGQqbPnSZ9GF0=;
	b=stH2mzWlG4CKR9NjdwiHUBQ+EoTU9Vz5DsGuKvtdNthKTam502EsC7Qd8vhmE0ECMBaWE9
	k8+DFhFUVj3fuO0TX0m41q9aap2m4w2qSi8UfMHvZubYPGTjAdbxzvJ6wsEoyqflim+GZl
	7lcaMyXhxFlZddaLyWpTP8tMTFmvapE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 04/13] xen: include compat/platform.h from hypercall.h
Date: Wed,  8 Dec 2021 16:55:57 +0100
Message-Id: <20211208155606.20029-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The definition of compat_platform_op_t is in compat/platform.h
already, so include that file from hypercall.h instead of repeating
the typedef.

This allows to remove the related include statement from
arch/x86/x86_64/platform_hypercall.c.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V3:
- new patch
---
 xen/arch/x86/x86_64/platform_hypercall.c | 1 -
 xen/include/xen/hypercall.h              | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/x86_64/platform_hypercall.c b/xen/arch/x86/x86_64/platform_hypercall.c
index f84252bac6..7631058cce 100644
--- a/xen/arch/x86/x86_64/platform_hypercall.c
+++ b/xen/arch/x86/x86_64/platform_hypercall.c
@@ -6,7 +6,6 @@ EMIT_FILE;
 
 #include <xen/hypercall.h>
 #include <xen/lib.h>
-#include <compat/platform.h>
 
 #define xen_platform_op     compat_platform_op
 #define xen_platform_op_t   compat_platform_op_t
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 9266bc86e9..459172f6a5 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -15,6 +15,9 @@
 #include <public/version.h>
 #include <public/pmu.h>
 #include <public/hvm/dm_op.h>
+#ifdef CONFIG_COMPAT
+#include <compat/platform.h>
+#endif
 #include <asm/hypercall.h>
 #include <xsm/xsm.h>
 
@@ -207,7 +210,6 @@ extern int compat_multicall(
 
 int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-typedef struct compat_platform_op compat_platform_op_t;
 DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
 int compat_platform_op(XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242362.419257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIo-0002p0-Np; Wed, 08 Dec 2021 15:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242362.419257; Wed, 08 Dec 2021 15:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIn-0002mW-Rh; Wed, 08 Dec 2021 15:56:17 +0000
Received: by outflank-mailman (input) for mailman id 242362;
 Wed, 08 Dec 2021 15:56:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIl-0001LM-6n
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:15 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e4440f7-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id D24A3218B5;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A411713C8E;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KEngJpzVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e4440f7-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=dJr8Fztf5T8hrG+mezGu/5MmsW11cX9HygUkaO7iFT0=;
	b=MxPCuDts/lw/W3BQmkzM22HUXyY30mCR7tGlzT6OvNhK+v32RBcn/XQ5fxaD7NNgltGK68
	Rs2Sr2CF6djMdkWUUZGU78oOxgPyKyOkQocT0+4Z9R77TfCFYoCEXCFvwdIz6QfTwxc2Yl
	LiLWg+d2Bmf3Jv4Bj3bSSU9FS13T2aw=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 11/13] xen/x86: add hypercall performance counters for hvm, correct pv
Date: Wed,  8 Dec 2021 16:56:04 +0100
Message-Id: <20211208155606.20029-12-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The HVM hypercall handler is missing incrementing the per hypercall
counters. Add that.

The counters for PV are handled wrong, as they are not using
perf_incra() with the number of the hypercall as index, but are
incrementing the first hypercall entry (set_trap_table) for each
hypercall. Fix that.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hvm/hypercall.c | 2 ++
 xen/arch/x86/pv/hypercall.c  | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 5952172476..37f60238d2 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -200,6 +200,8 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         ioreq_signal_mapcache_invalidate();
     }
 
+    perfc_incra(hypercalls, eax);
+
     return curr->hcall_preempted ? HVM_HCALL_preempted : HVM_HCALL_completed;
 }
 
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index ef92266620..bf64bb41bb 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -102,7 +102,7 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
     if ( curr->hcall_preempted )
         regs->rip -= 2;
 
-    perfc_incr(hypercalls);
+    perfc_incra(hypercalls, eax);
 }
 
 enum mc_disposition pv_do_multicall_call(struct mc_state *state)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242363.419261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIp-0002yO-Iw; Wed, 08 Dec 2021 15:56:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242363.419261; Wed, 08 Dec 2021 15:56:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIo-0002ut-JM; Wed, 08 Dec 2021 15:56:18 +0000
Received: by outflank-mailman (input) for mailman id 242363;
 Wed, 08 Dec 2021 15:56:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIl-0001Lz-Gp
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:15 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d92812d-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:11 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A283B218B0;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6565413C8E;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GKGTF5vVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d92812d-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Z6gh2zcV51PUmntndcjGT7MfpyJvBSFGHJiq128xk6Q=;
	b=VLNfcRrxdHj0gDgfesgcZLN+JVXEv1kxC/MDnVuLTMCwuhPGWhzpyRFFyKpSsMDm2JxtIV
	RdYWPV/dhqC5MG+emgRmR75W13dCETXhysRXh9tTUlxOI5PIpmp2qSI0kyIlIVNeiS3rbS
	Xydz4lHFbWb3z9h0CQF5ncPwkYkzc1E=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 06/13] xen: use generated prototypes for hypercall handlers
Date: Wed,  8 Dec 2021 16:55:59 +0100
Message-Id: <20211208155606.20029-7-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Remove the hypercall handler's prototypes in the related header files
and use the generated ones instead.

Some handlers having been static before need to be made globally
visible.

Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
---
 xen/arch/x86/hvm/hypercall.c    |   6 +-
 xen/include/asm-x86/hypercall.h | 133 ------------------------
 xen/include/xen/hypercall.h     | 178 +-------------------------------
 3 files changed, 5 insertions(+), 312 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 9d3b193bad..85b7a33523 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -31,7 +31,7 @@
 #include <public/hvm/hvm_op.h>
 #include <public/hvm/params.h>
 
-static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     long rc;
 
@@ -51,7 +51,7 @@ static long hvm_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 }
 
 #ifdef CONFIG_GRANT_TABLE
-static long hvm_grant_table_op(
+long hvm_grant_table_op(
     unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop, unsigned int count)
 {
     switch ( cmd )
@@ -77,7 +77,7 @@ static long hvm_grant_table_op(
 }
 #endif
 
-static long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     const struct vcpu *curr = current;
     const struct domain *currd = curr->domain;
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index efe5963ee5..2547572ccd 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -52,104 +52,6 @@ void pv_ring3_init_hypercall_page(void *ptr);
  */
 #define MMU_UPDATE_PREEMPTED          (~(~0U>>1))
 
-extern long
-do_event_channel_op_compat(
-    XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop);
-
-/* Legacy hypercall (as of 0x00030202). */
-extern long do_physdev_op_compat(
-    XEN_GUEST_HANDLE(physdev_op_t) uop);
-
-/* Legacy hypercall (as of 0x00030101). */
-extern long do_sched_op_compat(
-    int cmd, unsigned long arg);
-
-extern long
-do_set_trap_table(
-    XEN_GUEST_HANDLE_PARAM(const_trap_info_t) traps);
-
-extern long
-do_mmu_update(
-    XEN_GUEST_HANDLE_PARAM(mmu_update_t) ureqs,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern long
-do_set_gdt(
-    XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
-    unsigned int entries);
-
-extern long
-do_stack_switch(
-    unsigned long ss,
-    unsigned long esp);
-
-extern long
-do_fpu_taskswitch(
-    int set);
-
-extern long
-do_set_debugreg(
-    int reg,
-    unsigned long value);
-
-extern long
-do_get_debugreg(
-    int reg);
-
-extern long
-do_update_descriptor(
-    uint64_t gaddr, seg_desc_t desc);
-
-extern long
-do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc);
-
-extern long
-do_update_va_mapping(
-    unsigned long va,
-    uint64_t val64,
-    unsigned long flags);
-
-extern long
-do_update_va_mapping_otherdomain(
-    unsigned long va,
-    uint64_t val64,
-    unsigned long flags,
-    domid_t domid);
-
-extern long
-do_mmuext_op(
-    XEN_GUEST_HANDLE_PARAM(mmuext_op_t) uops,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern long do_callback_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg);
-
-extern long
-do_iret(
-    void);
-
-extern long
-do_set_callbacks(
-    unsigned long event_address,
-    unsigned long failsafe_address,
-    unsigned long syscall_address);
-
-extern long
-do_set_segment_base(
-    unsigned int which,
-    unsigned long base);
-
-long do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-long do_xenpmu_op(unsigned int op,
-                  XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg);
-
-long do_paging_domctl_cont(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
-
 #ifdef CONFIG_COMPAT
 
 #include <compat/arch-x86/xen.h>
@@ -159,41 +61,6 @@ extern int
 compat_common_vcpu_op(
     int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern int compat_mmuext_op(
-    XEN_GUEST_HANDLE_PARAM(void) arg,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(uint) pdone,
-    unsigned int foreigndom);
-
-extern int compat_callback_op(
-    int cmd, XEN_GUEST_HANDLE(const_void) arg);
-
-extern int compat_update_va_mapping(
-    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags);
-
-extern int compat_update_va_mapping_otherdomain(
-    unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid);
-
-DEFINE_XEN_GUEST_HANDLE(trap_info_compat_t);
-extern int compat_set_trap_table(XEN_GUEST_HANDLE(trap_info_compat_t) traps);
-
-extern int compat_set_gdt(
-    XEN_GUEST_HANDLE_PARAM(uint) frame_list, unsigned int entries);
-
-extern int compat_update_descriptor(
-    uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi);
-
-extern int compat_iret(void);
-
-extern int compat_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int compat_set_callbacks(
-    unsigned long event_selector, unsigned long event_address,
-    unsigned long failsafe_selector, unsigned long failsafe_address);
-
-DEFINE_XEN_GUEST_HANDLE(physdev_op_compat_t);
-extern int compat_physdev_op_compat(XEN_GUEST_HANDLE(physdev_op_compat_t) uop);
-
 #endif /* CONFIG_COMPAT */
 
 #endif /* __ASM_X86_HYPERCALL_H__ */
diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h
index 459172f6a5..f307dfb597 100644
--- a/xen/include/xen/hypercall.h
+++ b/xen/include/xen/hypercall.h
@@ -21,33 +21,19 @@
 #include <asm/hypercall.h>
 #include <xsm/xsm.h>
 
-extern long
-do_sched_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_domctl(
-    XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
+/* Needs to be after asm/hypercall.h. */
+#include <xen/hypercall-defs.h>
 
 extern long
 arch_do_domctl(
     struct xen_domctl *domctl, struct domain *d,
     XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl);
 
-extern long
-do_sysctl(
-    XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
-
 extern long
 arch_do_sysctl(
     struct xen_sysctl *sysctl,
     XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl);
 
-extern long
-do_platform_op(
-    XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op);
-
 extern long
 pci_physdev_op(
     int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
@@ -65,171 +51,11 @@ pci_physdev_op(
 #define MEMOP_EXTENT_SHIFT 6 /* cmd[:6] == start_extent */
 #define MEMOP_CMD_MASK     ((1 << MEMOP_EXTENT_SHIFT) - 1)
 
-extern long
-do_memory_op(
-    unsigned long cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_multicall(
-    XEN_GUEST_HANDLE_PARAM(multicall_entry_t) call_list,
-    unsigned int nr_calls);
-
-extern long
-do_set_timer_op(
-    s_time_t timeout);
-
-extern long
-do_event_channel_op(
-    int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_xen_version(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_console_io(
-    unsigned int cmd,
-    unsigned int count,
-    XEN_GUEST_HANDLE_PARAM(char) buffer);
-
-extern long
-do_grant_table_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) uop,
-    unsigned int count);
-
-extern long
-do_vm_assist(
-    unsigned int cmd,
-    unsigned int type);
-
-extern long
-do_vcpu_op(
-    int cmd,
-    unsigned int vcpuid,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-struct vcpu;
 extern long
 common_vcpu_op(int cmd,
     struct vcpu *v,
     XEN_GUEST_HANDLE_PARAM(void) arg);
 
-extern long
-do_hvm_op(
-    unsigned long op,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_kexec_op(
-    unsigned int op,
-    XEN_GUEST_HANDLE_PARAM(void) uarg);
-
-extern long
-do_xsm_op(
-    XEN_GUEST_HANDLE_PARAM(void) u_xsm_op);
-
-long do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-#ifdef CONFIG_ARGO
-extern long do_argo_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg1,
-    XEN_GUEST_HANDLE_PARAM(void) arg2,
-    unsigned long arg3,
-    unsigned long arg4);
-#endif
-
-extern long
-do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern long
-do_dm_op(
-    domid_t domid,
-    unsigned int nr_bufs,
-    XEN_GUEST_HANDLE_PARAM(xen_dm_op_buf_t) bufs);
-
-#ifdef CONFIG_HYPFS
-extern long
-do_hypfs_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(const_char) arg1,
-    unsigned long arg2,
-    XEN_GUEST_HANDLE_PARAM(void) arg3,
-    unsigned long arg4);
-#endif
-
-#ifdef CONFIG_COMPAT
-
-extern int
-compat_memory_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_grant_table_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) uop,
-    unsigned int count);
-
-extern int
-compat_vcpu_op(
-    int cmd,
-    unsigned int vcpuid,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_xen_version(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_sched_op(
-    int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg);
-
-extern int
-compat_set_timer_op(
-    uint32_t lo,
-    int32_t hi);
-
-extern int compat_xsm_op(
-    XEN_GUEST_HANDLE_PARAM(void) op);
-
-extern int compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg);
-
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
-extern int compat_multicall(
-    XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list,
-    uint32_t nr_calls);
-
-int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-
-DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t);
-int compat_platform_op(XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op);
-
-#ifdef CONFIG_ARGO
-extern int compat_argo_op(
-    unsigned int cmd,
-    XEN_GUEST_HANDLE_PARAM(void) arg1,
-    XEN_GUEST_HANDLE_PARAM(void) arg2,
-    unsigned long arg3,
-    unsigned long arg4);
-#endif
-
-extern int
-compat_dm_op(
-    domid_t domid,
-    unsigned int nr_bufs,
-    XEN_GUEST_HANDLE_PARAM(void) bufs);
-
-#endif
-
 void arch_get_xen_caps(xen_capabilities_info_t *info);
 
 #endif /* __XEN_HYPERCALL_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242358.419216 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIk-0001xW-V6; Wed, 08 Dec 2021 15:56:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242358.419216; Wed, 08 Dec 2021 15:56:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIk-0001vX-Ho; Wed, 08 Dec 2021 15:56:14 +0000
Received: by outflank-mailman (input) for mailman id 242358;
 Wed, 08 Dec 2021 15:56:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIj-0001LM-6e
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:13 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d14d6db-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:11 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C6EA421891;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F12413F91;
 Wed,  8 Dec 2021 15:56:10 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sDvdHZrVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d14d6db-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OHFpmR9wp02Vyhbj7JkBTr1KG9po1JxW5r7fKYlpm3I=;
	b=rQhIGyAAp5Aau9323oAldUQAEF+l4SEAMX+pUH4PEwbEgJ4Bx8qxp/hwPJeSqfidrcXzhw
	BkbpFzAy49vH0rgOd8MA+RDJX1FHeVB4Vm+mt+FQ2QqNWwPPqqx09oGX/rylxf/hpVJmUP
	vtIPDribGDwlEz08+oiiWYhBA5wxO7U=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Wei Liu <wl@xen.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [PATCH v3 03/13] xen: don't include asm/hypercall.h from C sources
Date: Wed,  8 Dec 2021 16:55:56 +0100
Message-Id: <20211208155606.20029-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of including asm/hypercall.h always use xen/hypercall.h.
Additionally include xen/hypercall.h from all sources containing a
hypercall handler.

This prepares for generating the handlers' prototypes at build time.

Add a guard in asm/hypercall.h to catch direct inclusion.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- remove platform_op hunk (Jan Beulich)
- remove including of xen/hypervisor.h from arch/x86/x86_64/mm.c
  (Jan Beulich)
- fix include order in common/compat/grant_table.c (Jan Beulich)
---
 xen/arch/arm/hvm.c                | 3 +--
 xen/arch/arm/platform_hypercall.c | 1 +
 xen/arch/x86/cpu/vpmu.c           | 1 +
 xen/arch/x86/mm.c                 | 1 -
 xen/arch/x86/platform_hypercall.c | 1 +
 xen/arch/x86/pv/iret.c            | 1 +
 xen/arch/x86/traps.c              | 2 +-
 xen/arch/x86/x86_64/compat/mm.c   | 1 +
 xen/arch/x86/x86_64/mm.c          | 2 --
 xen/common/compat/grant_table.c   | 1 +
 xen/common/compat/multicall.c     | 2 +-
 xen/common/event_channel.c        | 1 +
 xen/common/grant_table.c          | 1 +
 xen/common/multicall.c            | 1 +
 xen/include/asm-arm/hypercall.h   | 4 ++++
 xen/include/asm-x86/hypercall.h   | 4 ++++
 16 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c
index 8951b34086..fc1a52767d 100644
--- a/xen/arch/arm/hvm.c
+++ b/xen/arch/arm/hvm.c
@@ -20,6 +20,7 @@
 #include <xen/lib.h>
 #include <xen/errno.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/sched.h>
 #include <xen/monitor.h>
 
@@ -29,8 +30,6 @@
 #include <public/hvm/params.h>
 #include <public/hvm/hvm_op.h>
 
-#include <asm/hypercall.h>
-
 static int hvm_allow_set_param(const struct domain *d, unsigned int param)
 {
     switch ( param )
diff --git a/xen/arch/arm/platform_hypercall.c b/xen/arch/arm/platform_hypercall.c
index 8efac7ee60..403cc84324 100644
--- a/xen/arch/arm/platform_hypercall.c
+++ b/xen/arch/arm/platform_hypercall.c
@@ -9,6 +9,7 @@
 #include <xen/types.h>
 #include <xen/sched.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/spinlock.h>
 #include <public/platform.h>
 #include <xsm/xsm.h>
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bed..73768b09a7 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -22,6 +22,7 @@
 #include <xen/param.h>
 #include <xen/event.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/sched.h>
 #include <asm/regs.h>
 #include <asm/types.h>
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 4a9ac8d5e6..4a44af7199 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -129,7 +129,6 @@
 #include <asm/ldt.h>
 #include <asm/x86_emulate.h>
 #include <asm/e820.h>
-#include <asm/hypercall.h>
 #include <asm/shared.h>
 #include <asm/mem_sharing.h>
 #include <public/memory.h>
diff --git a/xen/arch/x86/platform_hypercall.c b/xen/arch/x86/platform_hypercall.c
index 284c2dfb9e..08e9ffa104 100644
--- a/xen/arch/x86/platform_hypercall.c
+++ b/xen/arch/x86/platform_hypercall.c
@@ -17,6 +17,7 @@
 #include <xen/console.h>
 #include <xen/iocap.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/acpi.h>
 #include <xen/efi.h>
 #include <xen/cpu.h>
diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c
index 90946c4629..316a23e77e 100644
--- a/xen/arch/x86/pv/iret.c
+++ b/xen/arch/x86/pv/iret.c
@@ -18,6 +18,7 @@
  */
 
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/lib.h>
 #include <xen/sched.h>
 
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 2ddcd95dce..f8bdc57433 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -29,6 +29,7 @@
 #include <xen/lib.h>
 #include <xen/err.h>
 #include <xen/errno.h>
+#include <xen/hypercall.h>
 #include <xen/mm.h>
 #include <xen/param.h>
 #include <xen/console.h>
@@ -70,7 +71,6 @@
 #include <asm/x86_emulate.h>
 #include <asm/traps.h>
 #include <asm/hvm/vpt.h>
-#include <asm/hypercall.h>
 #include <asm/mce.h>
 #include <asm/apic.h>
 #include <asm/mc146818rtc.h>
diff --git a/xen/arch/x86/x86_64/compat/mm.c b/xen/arch/x86/x86_64/compat/mm.c
index 215e96aba0..13dfa94fee 100644
--- a/xen/arch/x86/x86_64/compat/mm.c
+++ b/xen/arch/x86/x86_64/compat/mm.c
@@ -1,4 +1,5 @@
 #include <xen/event.h>
+#include <xen/hypercall.h>
 #include <xen/mem_access.h>
 #include <xen/multicall.h>
 #include <compat/memory.h>
diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index 4f225da81e..3510a5affe 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -25,14 +25,12 @@ EMIT_FILE;
 #include <xen/numa.h>
 #include <xen/nodemask.h>
 #include <xen/guest_access.h>
-#include <xen/hypercall.h>
 #include <xen/mem_access.h>
 #include <asm/current.h>
 #include <asm/asm_defns.h>
 #include <asm/page.h>
 #include <asm/flushtlb.h>
 #include <asm/fixmap.h>
-#include <asm/hypercall.h>
 #include <asm/msr.h>
 #include <asm/pv/domain.h>
 #include <asm/setup.h>
diff --git a/xen/common/compat/grant_table.c b/xen/common/compat/grant_table.c
index ff1d678f01..989fdef65b 100644
--- a/xen/common/compat/grant_table.c
+++ b/xen/common/compat/grant_table.c
@@ -3,6 +3,7 @@
  *
  */
 
+#include <xen/hypercall.h>
 #include <compat/grant_table.h>
 
 #define xen_grant_entry_v1 grant_entry_v1
diff --git a/xen/common/compat/multicall.c b/xen/common/compat/multicall.c
index a0e9918f48..c5982baf76 100644
--- a/xen/common/compat/multicall.c
+++ b/xen/common/compat/multicall.c
@@ -4,6 +4,7 @@
 
 EMIT_FILE;
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 #include <xen/multicall.h>
 #include <xen/trace.h>
@@ -19,7 +20,6 @@ static inline void xlat_multicall_entry(struct mc_state *mcs)
         mcs->compat_call.args[i] = mcs->call.args[i];
 }
 
-DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t);
 #define multicall_entry      compat_multicall_entry
 #define multicall_entry_t    multicall_entry_compat_t
 #define do_multicall_call    compat_multicall_call
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index da88ad141a..12006f592e 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -24,6 +24,7 @@
 #include <xen/iocap.h>
 #include <xen/compat.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/keyhandler.h>
 #include <asm/current.h>
 
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 0262f2c48a..4d8adf7faa 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -33,6 +33,7 @@
 #include <xen/trace.h>
 #include <xen/grant_table.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/domain_page.h>
 #include <xen/iommu.h>
 #include <xen/paging.h>
diff --git a/xen/common/multicall.c b/xen/common/multicall.c
index 5a199ebf8f..7b20717c88 100644
--- a/xen/common/multicall.c
+++ b/xen/common/multicall.c
@@ -9,6 +9,7 @@
 #include <xen/event.h>
 #include <xen/multicall.h>
 #include <xen/guest_access.h>
+#include <xen/hypercall.h>
 #include <xen/perfc.h>
 #include <xen/trace.h>
 #include <asm/current.h>
diff --git a/xen/include/asm-arm/hypercall.h b/xen/include/asm-arm/hypercall.h
index cadafd76c7..ccd26c5184 100644
--- a/xen/include/asm-arm/hypercall.h
+++ b/xen/include/asm-arm/hypercall.h
@@ -1,3 +1,7 @@
+#ifndef __XEN_HYPERCALL_H__
+#error "asm/hypercall.h should not be included directly - include xen/hypercall.h instead"
+#endif
+
 #ifndef __ASM_ARM_HYPERCALL_H__
 #define __ASM_ARM_HYPERCALL_H__
 
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index 9c0981defd..efe5963ee5 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -2,6 +2,10 @@
  * asm-x86/hypercall.h
  */
 
+#ifndef __XEN_HYPERCALL_H__
+#error "asm/hypercall.h should not be included directly - include xen/hypercall.h instead"
+#endif
+
 #ifndef __ASM_X86_HYPERCALL_H__
 #define __ASM_X86_HYPERCALL_H__
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242359.419224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIl-00025n-Ml; Wed, 08 Dec 2021 15:56:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242359.419224; Wed, 08 Dec 2021 15:56:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIl-000232-3V; Wed, 08 Dec 2021 15:56:15 +0000
Received: by outflank-mailman (input) for mailman id 242359;
 Wed, 08 Dec 2021 15:56:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIj-0001Lz-Gh
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:13 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d6abf92-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:11 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5E926218A8;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D28413F91;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4JL1BZvVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d6abf92-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=CIDOpO3po9yKGOWvtAC97v30FOkIvG2d9oKuboxtRX8=;
	b=Ph9JI3yUq1Au13NxX+csiCC697zeHgdkNyiHHkkYcHK3HaerM/GK17jcwRvIbZ8dklQUPM
	mQYuh+I1a9wc7dNRyntf/wv3V8EuOB6ejAcsTpCfPtPyZqvUu0WXBlPTwSech1C8bOsrUg
	8qsgAh1kvK3HD3xqM1znTk9xMBcGr9k=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 05/13] xen: generate hypercall interface related code
Date: Wed,  8 Dec 2021 16:55:58 +0100
Message-Id: <20211208155606.20029-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of repeating similar data multiple times use a single source
file and a generator script for producing prototypes and call sequences
of the hypercalls.

As the script already knows the number of parameters used add generating
a macro for populating an array with the number of parameters per
hypercall.

The priorities for the specific hypercalls are based on two benchamrks
performed in guests (PV and PVH):

- make -j 4 of the Xen hypervisor (resulting in cpu load with lots of
  processes created)
- scp of a large file to the guest (network load)

With a small additional debug patch applied the number of the
different hypercalls in the guest and in dom0 (for looking at backend
activity related hypercalls) were counted while the benchmark in domU
was running:

PV-hypercall    PV-guest build   PV-guest scp    dom0 build     dom0 scp
mmu_update           186175729           2865         20936        33725
stack_switch           1273311          62381        108589       270764
multicall              2182803             50           302          524
update_va_mapping       571868             10            60           80
xen_version              73061            850           859         5432
grant_table_op               0              0         35557       139110
iret                  75673006         484132        268157       757958
vcpu_op                 453037          71199        138224       334988
set_segment_base       1650249          62387        108645       270823
mmuext_op             11225681            188          7239         3426
sched_op                280153         134645         70729       137943
event_channel_op        192327          66204         71409       214191
physdev_op                   0              0          7721         4315
(the dom0 values are for the guest running the build or scp test, so
dom0 acting as backend)

HVM-hypercall   PVH-guest build    PVH-guest scp
vcpu_op                  277684             2324
event_channel_op         350233            57383
(the related dom0 counter values are in the same range as with the test
running in the PV guest)

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- split platform_op for doe and compat prefixes (Jan Beulich)
- add "addline:" directive
- add priorities to handlers (Jan Beulich)
V2.1:
- add missing "delete" statement in awk script
- optimize case of 2 hypercalls with same priority
V2.2:
- avoid asort() function (Michal Orzel)
V3:
- drop "addline:" support, as no longer needed
- enclose call sequence macros in "({ ... })" (Jan Beulich)
- small style adjustment (Jan Beulich)
- move generating to xen/include/Makefile (Anthony PERARD)

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .gitignore                    |   1 +
 xen/include/Makefile          |  13 ++
 xen/include/hypercall-defs.c  | 280 ++++++++++++++++++++++++++++++
 xen/scripts/gen_hypercall.awk | 314 ++++++++++++++++++++++++++++++++++
 4 files changed, 608 insertions(+)
 create mode 100644 xen/include/hypercall-defs.c
 create mode 100644 xen/scripts/gen_hypercall.awk

diff --git a/.gitignore b/.gitignore
index 9513506dd9..753a602e29 100644
--- a/.gitignore
+++ b/.gitignore
@@ -336,6 +336,7 @@ xen/include/public/public
 xen/include/xen/*.new
 xen/include/xen/acm_policy.h
 xen/include/xen/compile.h
+xen/include/xen/hypercall-defs.h
 xen/include/xen/lib/x86/cpuid-autogen.h
 xen/test/livepatch/config.h
 xen/test/livepatch/expect_config.h
diff --git a/xen/include/Makefile b/xen/include/Makefile
index 95daa8a289..43509131b9 100644
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -77,6 +77,18 @@ compat/xlat.h: $(addprefix compat/.xlat/,$(xlat-y)) config/auto.conf Makefile
 	cat $(filter %.h,$^) >$@.new
 	mv -f $@.new $@
 
+quiet_cmd_genhyp = GEN     $@
+define cmd_genhyp
+    awk -f ../scripts/gen_hypercall.awk <$< >$@
+endef
+
+all: xen/hypercall-defs.h
+
+xen/hypercall-defs.h: hypercall-defs.i ../scripts/gen_hypercall.awk FORCE
+	$(call if_changed,genhyp)
+
+targets += xen/hypercall-defs.h
+
 ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
 
 all: headers.chk headers99.chk headers++.chk
@@ -133,4 +145,5 @@ endif
 
 clean::
 	rm -rf compat config generated headers*.chk
+	rm -f xen/hypercall-defs.h hypercall-defs.i
 	rm -f $(BASEDIR)/include/xen/lib/x86/cpuid-autogen.h
diff --git a/xen/include/hypercall-defs.c b/xen/include/hypercall-defs.c
new file mode 100644
index 0000000000..e08b0a343a
--- /dev/null
+++ b/xen/include/hypercall-defs.c
@@ -0,0 +1,280 @@
+/*
+ * Hypercall interface description:
+ * Used by scripts/gen_hypercall.awk to generate hypercall prototypes and call
+ * sequences.
+ *
+ * Syntax is like a prototype, but without return type and without the ";" at
+ * the end. Pointer types will be automatically converted to use the
+ * XEN_GUEST_HANDLE_PARAM() macro. Handlers with no parameters just use a
+ * definition like "fn()".
+ * Hypercall/function names are without the leading "__HYPERVISOR_"/"do_"
+ * strings.
+ *
+ * The return type of a class of prototypes using the same prefix is set via:
+ * rettype: <prefix> <type>
+ * Default return type is "long". A return type for a prefix can be set only
+ * once and it needs to be set before that prefix is being used via the
+ * "prefix:" directive.
+ *
+ * The prefix of the prototypes is set via a line:
+ * prefix: <prefix> ...
+ * Multiple prefixes are possible (restriction see below). Prefixes are without
+ * a trailing "_". The current prefix settings are active until a new "prefix:"
+ * line.
+ *
+ * Caller macros are suffixed with a selectable name via lines like:
+ * caller: <suffix>
+ * When a caller suffix is active, there is only one active prefix allowed.
+ *
+ * With a "defhandle:" line it is possible to add a DEFINE_XEN_GUEST_HANDLE()
+ * to the generated header:
+ * defhandle: <handle-type> [<type>]
+ * Without specifying <type> only a DEFINE_XEN_GUEST_HANDLE(<handle-type>)
+ * will be generated, otherwise it will be a
+ * __DEFINE_XEN_GUEST_HANDLE(<handle-type>, <type>) being generated. Note that
+ * the latter will include the related "const" handle "const_<handle-type>".
+ *
+ * In order to support using coding style compliant pointers in the
+ * prototypes it is possible to add translation entries to generate the correct
+ * handle types:
+ * handle: <handle-type> <type>
+ * This will result in the prototype translation from "<type> *" to
+ * "XEN_GUEST_HANDLE_PARAM(<handle-type>)".
+ *
+ * The hypercall handler calling code will be generated from a final table in
+ * the source file, which is started via the line:
+ * table: <caller> <caller> ...
+ * with the <caller>s specifying the designated caller macro of each column of
+ * the table. Any column of a <caller> not having been set via a "caller:"
+ * line will be ignored.
+ * The first column of the table contains the hypercall/prototype, each
+ * <caller> column contains the prefix for the function to use for that caller.
+ * A function prefix can be annotated with a priority by adding ":<prio>" to it
+ * ("1" being the highest priority, higher numbers mean lower priority, no
+ * priority specified is the lowest priority). The generated code will try to
+ * achieve better performance for calling high priority handlers.
+ * A column not being supported by a <caller> is marked with "-". Lines with all
+ * entries being "-" after removal of inactive <caller> columns are ignored.
+ *
+ * This file is being preprocessed using $(CPP), so #ifdef CONFIG_* conditionals
+ * are possible.
+ */
+
+#ifdef CONFIG_HVM
+#define PREFIX_hvm hvm
+#else
+#define PREFIX_hvm
+#endif
+
+#ifdef CONFIG_COMPAT
+#define PREFIX_compat compat
+rettype: compat int
+#else
+#define PREFIX_compat
+#endif
+
+#ifdef CONFIG_ARM
+#define PREFIX_dep dep
+#else
+#define PREFIX_dep
+#endif
+
+handle: uint unsigned int
+handle: const_void const void
+handle: const_char const char
+
+#ifdef CONFIG_COMPAT
+defhandle: multicall_entry_compat_t
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+defhandle: compat_platform_op_t
+#endif
+#endif
+#ifdef CONFIG_PV32
+defhandle: trap_info_compat_t
+defhandle: physdev_op_compat_t
+#endif
+
+prefix: do PREFIX_hvm PREFIX_compat
+physdev_op(int cmd, void *arg)
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
+grant_table_op(unsigned int cmd, void *uop, unsigned int count)
+#endif
+
+prefix: do PREFIX_hvm
+memory_op(unsigned long cmd, void *arg)
+
+prefix: do PREFIX_compat
+xen_version(int cmd, void *arg)
+vcpu_op(int cmd, unsigned int vcpuid, void *arg)
+sched_op(int cmd, void *arg)
+xsm_op(void *op)
+callback_op(int cmd, const void *arg)
+#ifdef CONFIG_ARGO
+argo_op(unsigned int cmd, void *arg1, void *arg2, unsigned long arg3, unsigned long arg4)
+#endif
+#ifdef CONFIG_KEXEC
+kexec_op(unsigned int op, void *uarg)
+#endif
+#ifdef CONFIG_PV
+iret()
+nmi_op(unsigned int cmd, void *arg)
+#ifdef CONFIG_XENOPROF
+xenoprof_op(int op, void *arg)
+#endif
+#endif /* CONFIG_PV */
+
+#ifdef CONFIG_COMPAT
+prefix: compat
+set_timer_op(uint32_t lo, int32_t hi)
+multicall(multicall_entry_compat_t *call_list, uint32_t nr_calls)
+memory_op(unsigned int cmd, void *arg)
+#ifdef CONFIG_IOREQ_SERVER
+dm_op(domid_t domid, unsigned int nr_bufs, void *bufs)
+#endif
+mmuext_op(void *arg, unsigned int count, uint *pdone, unsigned int foreigndom)
+#ifdef CONFIG_PV32
+set_trap_table(trap_info_compat_t *traps)
+set_gdt(unsigned int *frame_list, unsigned int entries)
+set_callbacks(unsigned long event_selector, unsigned long event_address, unsigned long failsafe_selector, unsigned long failsafe_address)
+update_descriptor(uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi)
+update_va_mapping(unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags)
+physdev_op_compat(physdev_op_compat_t *uop)
+update_va_mapping_otherdomain(unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags, domid_t domid)
+#endif
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+platform_op(compat_platform_op_t *u_xenpf_op)
+#endif
+#endif /* CONFIG_COMPAT */
+
+#if defined(CONFIG_PV) || defined(CONFIG_ARM)
+prefix: do PREFIX_dep
+event_channel_op_compat(evtchn_op_t *uop)
+physdev_op_compat(physdev_op_t *uop)
+/* Legacy hypercall (as of 0x00030101). */
+sched_op_compat(int cmd, unsigned long arg)
+#endif
+
+prefix: do
+set_timer_op(s_time_t timeout)
+console_io(unsigned int cmd, unsigned int count, char *buffer)
+vm_assist(unsigned int cmd, unsigned int type)
+event_channel_op(int cmd, void *arg)
+mmuext_op(mmuext_op_t *uops, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
+multicall(multicall_entry_t *call_list, unsigned int nr_calls)
+#ifdef CONFIG_PV
+mmu_update(mmu_update_t *ureqs, unsigned int count, unsigned int *pdone, unsigned int foreigndom)
+stack_switch(unsigned long ss, unsigned long esp)
+fpu_taskswitch(int set)
+set_debugreg(int reg, unsigned long value)
+get_debugreg(int reg)
+set_segment_base(unsigned int which, unsigned long base)
+mca(xen_mc_t *u_xen_mc)
+set_trap_table(const_trap_info_t *traps)
+set_gdt(xen_ulong_t *frame_list, unsigned int entries)
+set_callbacks(unsigned long event_address, unsigned long failsafe_address, unsigned long syscall_address)
+update_descriptor(uint64_t gaddr, seg_desc_t desc)
+update_va_mapping(unsigned long va, uint64_t val64, unsigned long flags)
+update_va_mapping_otherdomain(unsigned long va, uint64_t val64, unsigned long flags, domid_t domid)
+#endif
+#ifdef CONFIG_IOREQ_SERVER
+dm_op(domid_t domid, unsigned int nr_bufs, xen_dm_op_buf_t *bufs)
+#endif
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+sysctl(xen_sysctl_t *u_sysctl)
+domctl(xen_domctl_t *u_domctl)
+paging_domctl_cont(xen_domctl_t *u_domctl)
+platform_op(xen_platform_op_t *u_xenpf_op)
+#endif
+#ifdef CONFIG_HVM
+hvm_op(unsigned long op, void *arg)
+#endif
+#ifdef CONFIG_HYPFS
+hypfs_op(unsigned int cmd, const char *arg1, unsigned long arg2, void *arg3, unsigned long arg4)
+#endif
+#ifdef CONFIG_X86
+xenpmu_op(unsigned int op, xen_pmu_params_t *arg)
+#endif
+
+#ifdef CONFIG_PV
+caller: pv64
+#ifdef CONFIG_PV32
+caller: pv32
+#endif
+#endif
+#if defined(CONFIG_HVM) && defined(CONFIG_X86)
+caller: hvm64
+#ifdef CONFIG_COMPAT
+caller: hvm32
+#endif
+#endif
+#ifdef CONFIG_ARM
+caller: arm
+#endif
+
+table:                             pv32     pv64     hvm32    hvm64    arm
+set_trap_table                     compat   do       -        -        -
+mmu_update                         do:1     do:1     -        -        -
+set_gdt                            compat   do       -        -        -
+stack_switch                       do:2     do:2     -        -        -
+set_callbacks                      compat   do       -        -        -
+fpu_taskswitch                     do       do       -        -        -
+sched_op_compat                    do       do       -        -        dep
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+platform_op                        compat   do       compat   do       do
+#endif
+set_debugreg                       do       do       -        -        -
+get_debugreg                       do       do       -        -        -
+update_descriptor                  compat   do       -        -        -
+memory_op                          compat   do       hvm      hvm      do
+multicall                          compat:2 do:2     compat   do       do
+update_va_mapping                  compat   do       -        -        -
+set_timer_op                       compat   do       compat   do       -
+event_channel_op_compat            do       do       -        -        dep
+xen_version                        compat   do       compat   do       do
+console_io                         do       do       do       do       do
+physdev_op_compat                  compat   do       -        -        dep
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
+grant_table_op                     compat   do       hvm      hvm      do
+#endif
+vm_assist                          do       do       do       do       do
+update_va_mapping_otherdomain      compat   do       -        -        -
+iret                               compat:1 do:1     -        -        -
+vcpu_op                            compat   do       compat:1 do:1     do
+set_segment_base                   do:2     do:2     -        -        -
+#ifdef CONFIG_PV
+mmuext_op                          compat:2 do:2     compat   do       -
+#endif
+xsm_op                             compat   do       compat   do       do
+nmi_op                             compat   do       -        -        -
+sched_op                           compat   do       compat   do       do
+callback_op                        compat   do       -        -        -
+#ifdef CONFIG_XENOPROF
+xenoprof_op                        compat   do       -        -        -
+#endif
+event_channel_op                   do       do       do:1     do:1     do
+physdev_op                         compat   do       hvm      hvm      do
+#ifdef CONFIG_HVM
+hvm_op                             do       do       do       do       do
+#endif
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+sysctl                             do       do       do       do       do
+domctl                             do       do       do       do       do
+#endif
+#ifdef CONFIG_KEXEC
+kexec_op                           compat   do       -        -        -
+#endif
+tmem_op                            -        -        -        -        -
+#ifdef CONFIG_ARGO
+argo_op                            compat   do       compat   do       do
+#endif
+xenpmu_op                          do       do       do       do       -
+#ifdef CONFIG_IOREQ_SERVER
+dm_op                              compat   do       compat   do       do
+#endif
+#ifdef CONFIG_HYPFS
+hypfs_op                           do       do       do       do       do
+#endif
+mca                                do       do       -        -        -
+#ifndef CONFIG_PV_SHIM_EXCLUSIVE
+paging_domctl_cont                 do       do       do       do       -
+#endif
diff --git a/xen/scripts/gen_hypercall.awk b/xen/scripts/gen_hypercall.awk
new file mode 100644
index 0000000000..34840c514f
--- /dev/null
+++ b/xen/scripts/gen_hypercall.awk
@@ -0,0 +1,314 @@
+# awk script to generate hypercall handler prototypes and a macro for doing
+# the calls of the handlers inside a switch() statement.
+
+BEGIN {
+    printf("/* Generated file, do not edit! */\n\n");
+    e = 0;
+    n = 0;
+    p = 0;
+    nc = 0;
+}
+
+# Issue error to stderr
+function do_err(msg) {
+    print "Error: "msg": "$0 >"/dev/stderr";
+    exit 1;
+}
+
+# Generate handler call
+function do_call(f, p,    i) {
+    printf("            ret = %s_%s(", pre[f, p], fn[f]);
+    for (i = 1; i <= n_args[f]; i++) {
+        if (i > 1)
+            printf(", ");
+        if (ptr[f, i])
+            printf("(XEN_GUEST_HANDLE_PARAM(%s)){ _p(a%d) }", typ[f, i], i);
+        else
+            printf("(%s)(a%d)", typ[f, i], i);
+    }
+    printf("); \\\n");
+}
+
+# Generate case statement for call
+function do_case(f, p) {
+    printf("        case __HYPERVISOR_%s: \\\n", fn[f]);
+    do_call(f, p);
+    printf("            break; \\\n");
+}
+
+# Generate switch statement for calling handlers
+function do_switch(ca, p,    i) {
+    printf("        switch ( num ) \\\n");
+    printf("        { \\\n");
+    for (i = 1; i <= nc; i++)
+        if (call[i] == ca && call_prio[i] == p)
+            do_case(call_fn[i], call_p[i]);
+    printf("        default: \\\n");
+    printf("            ret = -ENOSYS; \\\n");
+    printf("            break; \\\n");
+    printf("        } \\\n");
+}
+
+function rest_of_line(par,    i, val) {
+    val = $(par);
+    for (i = par + 1; i <= NF; i++)
+        val = val " " $(i);
+    return val;
+}
+
+# Handle comments (multi- and single line)
+$1 == "/*" {
+    comment = 1;
+}
+comment == 1 {
+    if ($(NF) == "*/") comment = 0;
+    next;
+}
+
+# Skip preprocessing artefacts
+$1 == "extern" {
+    next;
+}
+/^#/ {
+    next;
+}
+
+# Drop empty lines
+NF == 0 {
+    next;
+}
+
+# Handle "handle:" line
+$1 == "handle:" {
+    if (NF < 3)
+        do_err("\"handle:\" requires at least two parameters");
+    val = rest_of_line(3);
+    xlate[val] = $2;
+    next;
+}
+
+# Handle "defhandle:" line
+$1 == "defhandle:" {
+    if (NF < 2)
+        do_err("\"defhandle:\" requires at least one parameter");
+    e++;
+    if (NF == 2) {
+        emit[e] = sprintf("DEFINE_XEN_GUEST_HANDLE(%s);", $2);
+    } else {
+        val = rest_of_line(3);
+        emit[e] = sprintf("__DEFINE_XEN_GUEST_HANDLE(%s, %s);", $2, val);
+        xlate[val] = $2;
+    }
+    next;
+}
+
+# Handle "rettype:" line
+$1 == "rettype:" {
+    if (NF < 3)
+        do_err("\"rettype:\" requires at least two parameters");
+    if ($2 in rettype)
+        do_err("rettype can be set only once for each prefix");
+    rettype[$2] = rest_of_line(3);
+    next;
+}
+
+# Handle "caller:" line
+$1 == "caller:" {
+    caller[$2] = 1;
+    next;
+}
+
+# Handle "prefix:" line
+$1 == "prefix:" {
+    p = NF - 1;
+    for (i = 2; i <= NF; i++) {
+        prefix[i - 1] = $(i);
+        if (!(prefix[i - 1] in rettype))
+            rettype[prefix[i - 1]] = "long";
+    }
+    next;
+}
+
+# Handle "table:" line
+$1 == "table:" {
+    table = 1;
+    for (i = 2; i <= NF; i++)
+        col[i - 1] = $(i);
+    n_cols = NF - 1;
+    next;
+}
+
+# Handle table definition line
+table == 1 {
+    if (NF != n_cols + 1)
+        do_err("Table definition line has wrong number of fields");
+    for (c = 1; c <= n_cols; c++) {
+        if (caller[col[c]] != 1)
+            continue;
+        if ($(c + 1) == "-")
+            continue;
+        pref = $(c + 1);
+        idx = index(pref, ":");
+        if (idx == 0)
+            prio = 100;
+        else {
+            prio = substr(pref, idx + 1) + 0;
+            pref = substr(pref, 1, idx - 1);
+            if (prio >= 100 || prio < 1)
+                do_err("Priority must be in the range 1..99");
+        }
+        fnd = 0;
+        for (i = 1; i <= n; i++) {
+            if (fn[i] != $1)
+                continue;
+            for (j = 1; j <= n_pre[i]; j++) {
+                if (pre[i, j] == pref) {
+                    prios[col[c], prio]++;
+                    if (prios[col[c], prio] == 1) {
+                        n_prios[col[c]]++;
+                        prio_list[col[c], n_prios[col[c]]] = prio;
+                        prio_mask[col[c], prio] = "(1ULL << __HYPERVISOR_"$1")";
+                    } else
+                        prio_mask[col[c], prio] = prio_mask[col[c], prio] " | (1ULL << __HYPERVISOR_"$1")";
+                    nc++;
+                    call[nc] = col[c];
+                    call_fn[nc] = i;
+                    call_p[nc] = j;
+                    call_prio[nc] = prio;
+                    fnd = 1;
+                }
+            }
+        }
+        if (fnd == 0)
+            do_err("No prototype for prefix/hypercall combination");
+    }
+    next;
+}
+
+# Prototype line
+{
+    bro = index($0, "(");
+    brc = index($0, ")");
+    if (bro < 2 || brc < bro)
+        do_err("No valid prototype line");
+    n++;
+    fn[n] = substr($0, 1, bro - 1);
+    n_pre[n] = p;
+    for (i = 1; i <= p; i++)
+        pre[n, i] = prefix[i];
+    args = substr($0, bro + 1, brc - bro - 1);
+    n_args[n] = split(args, a, ",");
+    if (n_args[n] > 5)
+        do_err("Too many parameters");
+    for (i = 1; i <= n_args[n]; i++) {
+        sub("^ *", "", a[i]);         # Remove leading white space
+        sub(" +", " ", a[i]);         # Replace multiple spaces with single ones
+        sub(" *$", "", a[i]);         # Remove trailing white space
+        ptr[n, i] = index(a[i], "*"); # Is it a pointer type?
+        sub("[*]", "", a[i]);         # Remove "*"
+        if (index(a[i], " ") == 0)
+            do_err("Parameter with no type or no name");
+        typ[n, i] = a[i];
+        sub(" [^ ]+$", "", typ[n, i]);    # Remove parameter name
+        if (ptr[n, i] && (typ[n, i] in xlate))
+            typ[n, i] = xlate[typ[n, i]];
+        arg[n, i] = a[i];
+        sub("^([^ ]+ )+", "", arg[n, i]); # Remove parameter type
+    }
+}
+
+# Generate the output
+END {
+    # Verbatim generated lines
+    for (i = 1; i <= e; i++)
+        printf("%s\n", emit[i]);
+    printf("\n");
+    # Generate prototypes
+    for (i = 1; i <= n; i++) {
+        for (p = 1; p <= n_pre[i]; p++) {
+            printf("%s %s_%s(", rettype[pre[i, p]], pre[i, p], fn[i]);
+            if (n_args[i] == 0)
+                printf("void");
+            else
+                for (j = 1; j <= n_args[i]; j++) {
+                    if (j > 1)
+                        printf(", ");
+                    if (ptr[i, j])
+                        printf("XEN_GUEST_HANDLE_PARAM(%s)", typ[i, j]);
+                    else
+                        printf("%s", typ[i, j]);
+                    printf(" %s", arg[i, j]);
+                }
+            printf(");\n");
+        }
+    }
+    # Generate call sequences and args array contents
+    for (ca in caller) {
+        if (caller[ca] != 1)
+            continue;
+        need_mask = 0;
+        for (pl = 1; pl <= n_prios[ca]; pl++) {
+            for (pll = pl; pll > 1; pll--) {
+                if (prio_list[ca, pl] > p_list[pll - 1])
+                    break;
+                else
+                    p_list[pll] = p_list[pll - 1];
+            }
+            p_list[pll] = prio_list[ca, pl];
+            # If any prio but the default one has more than 1 entry we need "mask"
+            if (p_list[pll] != 100 && prios[ca, p_list[pll]] > 1)
+                need_mask = 1;
+        }
+        printf("\n");
+        printf("#define call_handlers_%s(num, ret, a1, a2, a3, a4, a5) \\\n", ca);
+        printf("({ \\\n");
+        if (need_mask)
+            printf("    uint64_t mask = 1ULL << num; \\\n");
+        printf("    ");
+        for (pl = 1; pl <= n_prios[ca]; pl++) {
+            if (prios[ca, p_list[pl]] > 1) {
+                if (pl < n_prios[ca]) {
+                    printf("    if ( likely(mask & (%s)) ) \\\n", prio_mask[ca, p_list[pl]]);
+                    printf("    { \\\n");
+                }
+                if (prios[ca, p_list[pl]] == 2) {
+                    fnd = 0;
+                    for (i = 1; i <= nc; i++)
+                        if (call[i] == ca && call_prio[i] == p_list[pl]) {
+                            fnd++;
+                            if (fnd == 1)
+                                printf("        if ( num == __HYPERVISOR_%s ) \\\n", fn[call_fn[i]]);
+                            else
+                                printf("        else \\\n");
+                            do_call(call_fn[i], call_p[i]);
+                        }
+                } else {
+                    do_switch(ca, p_list[pl]);
+                }
+                if (pl < n_prios[ca])
+                    printf("    } \\\n");
+            } else {
+                for (i = 1; i <= nc; i++)
+                    if (call[i] == ca && call_prio[i] == p_list[pl]) {
+                        printf("if ( likely(num == __HYPERVISOR_%s) ) \\\n", fn[call_fn[i]]);
+                        do_call(call_fn[i], call_p[i]);
+                    }
+            }
+            if (pl < n_prios[ca] || prios[ca, p_list[pl]] <= 2)
+                printf("    else \\\n");
+        }
+        if (prios[ca, p_list[n_prios[ca]]] <= 2) {
+            printf("\\\n");
+            printf("        ret = -ENOSYS; \\\n");
+        }
+        printf("})\n");
+        delete p_list;
+        printf("\n");
+        printf("#define hypercall_args_%s \\\n", ca);
+        printf("{ \\\n");
+        for (i = 1; i <= nc; i++)
+            if (call[i] == ca)
+                printf("[__HYPERVISOR_%s] = %d, \\\n", fn[call_fn[i]], n_args[call_fn[i]]);
+        printf("}\n");
+    }
+}
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242360.419236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIm-0002OA-Kz; Wed, 08 Dec 2021 15:56:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242360.419236; Wed, 08 Dec 2021 15:56:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIm-0002Ki-7K; Wed, 08 Dec 2021 15:56:16 +0000
Received: by outflank-mailman (input) for mailman id 242360;
 Wed, 08 Dec 2021 15:56:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIk-0001LM-6Y
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:14 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5db621af-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:12 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E0C781FD5B;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A8B8413C8E;
 Wed,  8 Dec 2021 15:56:11 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 4DkdKJvVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5db621af-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nEFyO5REy98yyXsf4CZGnr9ARPg0xXVeuhj3Ow7aEFk=;
	b=LTGeeP9QCTW2+cX+mEPR9joCgQvdR6Blyo2yOC9blPOIQxB2Q3CcgDsBZw7zGzuNrrGbQG
	7+Lgh4j5cJWlpgMYIR944ZV03lxi99EwTOBlgpQOySZ0QgBQa2aWH6JikTNOriff7sLrJl
	ivjLi5ue6NxKgZgFJYX0plwdguR7F0I=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3 07/13] x86/pv-shim: don't modify hypercall table
Date: Wed,  8 Dec 2021 16:56:00 +0100
Message-Id: <20211208155606.20029-8-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.

Change this to call the related functions from the normal handlers
instead when running as shim. The performance implications are not
really relevant, as a normal production hypervisor will not be
configured to support shim mode, so the related calls will be dropped
due to optimization of the compiler.

Note that for the CONFIG_PV_SHIM_EXCLUSIVE case there is a dummy
wrapper do_grant_table_op() needed, as in this case grant_table.c
isn't being built.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- add test for pv_shim to wrappers (Jan Beulich)
- add grant_table_op to hypercall table if CONFIG_PV_SHIM (Jan Beulich)
V3:
- add [un]likely() to pv_shim tests (Jan Beulich)
---
 xen/arch/x86/pv/hypercall.c   |  2 +-
 xen/arch/x86/pv/shim.c        | 54 +++++++++++++++++------------------
 xen/common/event_channel.c    |  9 ++++++
 xen/common/grant_table.c      |  9 ++++++
 xen/include/asm-x86/pv/shim.h |  3 ++
 5 files changed, 49 insertions(+), 28 deletions(-)

diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index 7e99dbda34..abe4dd7839 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -62,7 +62,7 @@ const pv_hypercall_table_t pv_hypercall_table[] = {
     COMPAT_CALL(xen_version),
     HYPERCALL(console_io),
     COMPAT_CALL(physdev_op_compat),
-#ifdef CONFIG_GRANT_TABLE
+#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
     COMPAT_CALL(grant_table_op),
 #endif
     HYPERCALL(vm_assist),
diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c
index d9704121a7..9a4a257d4c 100644
--- a/xen/arch/x86/pv/shim.c
+++ b/xen/arch/x86/pv/shim.c
@@ -56,11 +56,6 @@ static DEFINE_SPINLOCK(balloon_lock);
 
 static struct platform_bad_page __initdata reserved_pages[2];
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg);
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count);
-
 /*
  * By default give the shim 1MB of free memory slack. Some users may wish to
  * tune this constants for better memory utilization. This can be achieved
@@ -203,7 +198,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
                               start_info_t *si)
 {
     bool compat = is_pv_32bit_domain(d);
-    pv_hypercall_table_t *rw_pv_hypercall_table;
     uint64_t param = 0;
     long rc;
 
@@ -249,23 +243,6 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start,
         consoled_set_ring_addr(page);
     }
 
-    /*
-     * Locate pv_hypercall_table[] (usually .rodata) in the directmap (which
-     * is writeable) and insert some shim-specific hypercall handlers.
-     */
-    rw_pv_hypercall_table = __va(__pa(pv_hypercall_table));
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].native =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].native =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-
-#ifdef CONFIG_PV32
-    rw_pv_hypercall_table[__HYPERVISOR_event_channel_op].compat =
-        (hypercall_fn_t *)pv_shim_event_channel_op;
-    rw_pv_hypercall_table[__HYPERVISOR_grant_table_op].compat =
-        (hypercall_fn_t *)pv_shim_grant_table_op;
-#endif
-
     guest = d;
 
     /*
@@ -435,7 +412,7 @@ int pv_shim_shutdown(uint8_t reason)
     return 0;
 }
 
-static long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
+long pv_shim_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     struct domain *d = current->domain;
     struct evtchn_close close;
@@ -683,9 +660,9 @@ void pv_shim_inject_evtchn(unsigned int port)
 # define compat_handle_okay guest_handle_okay
 #endif
 
-static long pv_shim_grant_table_op(unsigned int cmd,
-                                   XEN_GUEST_HANDLE_PARAM(void) uop,
-                                   unsigned int count)
+long pv_shim_grant_table_op(unsigned int cmd,
+                            XEN_GUEST_HANDLE_PARAM(void) uop,
+                            unsigned int count)
 {
     struct domain *d = current->domain;
     long rc = 0;
@@ -845,6 +822,29 @@ static long pv_shim_grant_table_op(unsigned int cmd,
     return rc;
 }
 
+#ifndef CONFIG_GRANT_TABLE
+/* Thin wrapper(s) needed. */
+long do_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                       unsigned int count)
+{
+    if ( likely(!pv_shim) )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+
+#ifdef CONFIG_PV32
+int compat_grant_table_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) uop,
+                          unsigned int count)
+{
+    if ( likely(!pv_shim) )
+        return -ENOSYS;
+
+    return pv_shim_grant_table_op(cmd, uop, count);
+}
+#endif
+#endif
+
 long pv_shim_cpu_up(void *data)
 {
     struct vcpu *v = data;
diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
index 12006f592e..0e4973f800 100644
--- a/xen/common/event_channel.c
+++ b/xen/common/event_channel.c
@@ -32,6 +32,10 @@
 #include <public/event_channel.h>
 #include <xsm/xsm.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 #define ERROR_EXIT(_errno)                                          \
     do {                                                            \
         gdprintk(XENLOG_WARNING,                                    \
@@ -1190,6 +1194,11 @@ long do_event_channel_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
 {
     int rc;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_event_channel_op(cmd, arg);
+#endif
+
     switch ( cmd )
     {
     case EVTCHNOP_alloc_unbound: {
diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 4d8adf7faa..e5641608ad 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -45,6 +45,10 @@
 #include <asm/flushtlb.h>
 #include <asm/guest_atomics.h>
 
+#ifdef CONFIG_PV_SHIM
+#include <asm/guest.h>
+#endif
+
 /* Per-domain grant information. */
 struct grant_table {
     /*
@@ -3543,6 +3547,11 @@ do_grant_table_op(
     long rc;
     unsigned int opaque_in = cmd & GNTTABOP_ARG_MASK, opaque_out = 0;
 
+#ifdef CONFIG_PV_SHIM
+    if ( unlikely(pv_shim) )
+        return pv_shim_grant_table_op(cmd, uop, count);
+#endif
+
     if ( (int)count < 0 )
         return -EINVAL;
 
diff --git a/xen/include/asm-x86/pv/shim.h b/xen/include/asm-x86/pv/shim.h
index 8a91f4f9df..6415f8068e 100644
--- a/xen/include/asm-x86/pv/shim.h
+++ b/xen/include/asm-x86/pv/shim.h
@@ -19,6 +19,7 @@
 #ifndef __X86_PV_SHIM_H__
 #define __X86_PV_SHIM_H__
 
+#include <xen/hypercall.h>
 #include <xen/types.h>
 
 #if defined(CONFIG_PV_SHIM_EXCLUSIVE)
@@ -45,6 +46,8 @@ domid_t get_initial_domain_id(void);
 uint64_t pv_shim_mem(uint64_t avail);
 void pv_shim_fixup_e820(struct e820map *e820);
 const struct platform_bad_page *pv_shim_reserved_pages(unsigned int *size);
+typeof(do_event_channel_op) pv_shim_event_channel_op;
+typeof(do_grant_table_op) pv_shim_grant_table_op;
 
 #else
 
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242364.419272 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIr-0003PK-5B; Wed, 08 Dec 2021 15:56:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242364.419272; Wed, 08 Dec 2021 15:56:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIq-0003HI-D6; Wed, 08 Dec 2021 15:56:20 +0000
Received: by outflank-mailman (input) for mailman id 242364;
 Wed, 08 Dec 2021 15:56:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIm-0001LM-76
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:16 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e2e218c-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 9ED941FE03;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6D3CC13C8E;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id CKp/GZzVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e2e218c-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2n/9xey2IT4ZAnuW1PqFqQUspNgB5vGE/l2Zzlja0vw=;
	b=bkecxq9dHRAdMvoFFLkP2I1NXt3D/CTDUrKNFqqh4EEaPWeBHpHoDAg+8EaIA30+K+TbIq
	ObX3Td6NJRulPGk2ur1aSWeAL7zLqXCnV/iRxLKhJWC8JdNrp1CDvzkm/MRBcK4ThBY/Bp
	Hc3+uxypgu4nVCkdJhdueQTGJHkPZHk=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: [PATCH v3 10/13] xen/arm: call hypercall handlers via generated macro
Date: Wed,  8 Dec 2021 16:56:03 +0100
Message-Id: <20211208155606.20029-11-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a function table use the generated macros for calling
the appropriate hypercall handlers.

This makes the calls of the handlers type safe.

For deprecated hypercalls define stub functions.

Signed-off-by: Juergen Gross <jgross@suse.com>
Tested-by: Michal Orzel <michal.orzel@arm.com>
---
V2:
- make hypercall_args[] const (Jan Beulich)
---
 xen/arch/arm/traps.c | 119 ++++++++++---------------------------------
 1 file changed, 26 insertions(+), 93 deletions(-)

diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 7abc28848e..00af76cf14 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1337,62 +1337,20 @@ static register_t do_deprecated_hypercall(void)
     return -ENOSYS;
 }
 
-typedef register_t (*arm_hypercall_fn_t)(
-    register_t, register_t, register_t, register_t, register_t);
-
-typedef struct {
-    arm_hypercall_fn_t fn;
-    int nr_args;
-} arm_hypercall_t;
-
-#define HYPERCALL(_name, _nr_args)                                   \
-    [ __HYPERVISOR_ ## _name ] =  {                                  \
-        .fn = (arm_hypercall_fn_t) &do_ ## _name,                    \
-        .nr_args = _nr_args,                                         \
-    }
+long dep_sched_op_compat(int cmd, unsigned long arg)
+{
+    return do_deprecated_hypercall();
+}
 
-/*
- * Only use this for hypercalls which were deprecated (i.e. replaced
- * by something else) before Xen on ARM was created, i.e. *not* for
- * hypercalls which are simply not yet used on ARM.
- */
-#define HYPERCALL_DEPRECATED(_name, _nr_args)                   \
-    [ __HYPERVISOR_##_name ] = {                                \
-        .fn = (arm_hypercall_fn_t) &do_deprecated_hypercall,    \
-        .nr_args = _nr_args,                                    \
-    }
+long dep_event_channel_op_compat(XEN_GUEST_HANDLE_PARAM(evtchn_op_t) uop)
+{
+    return do_deprecated_hypercall();
+}
 
-static arm_hypercall_t arm_hypercall_table[] = {
-    HYPERCALL(memory_op, 2),
-    HYPERCALL(domctl, 1),
-    HYPERCALL(sched_op, 2),
-    HYPERCALL_DEPRECATED(sched_op_compat, 2),
-    HYPERCALL(console_io, 3),
-    HYPERCALL(xen_version, 2),
-    HYPERCALL(xsm_op, 1),
-    HYPERCALL(event_channel_op, 2),
-    HYPERCALL_DEPRECATED(event_channel_op_compat, 1),
-    HYPERCALL(physdev_op, 2),
-    HYPERCALL_DEPRECATED(physdev_op_compat, 1),
-    HYPERCALL(sysctl, 2),
-    HYPERCALL(hvm_op, 2),
-#ifdef CONFIG_GRANT_TABLE
-    HYPERCALL(grant_table_op, 3),
-#endif
-    HYPERCALL(multicall, 2),
-    HYPERCALL(platform_op, 1),
-    HYPERCALL(vcpu_op, 3),
-    HYPERCALL(vm_assist, 2),
-#ifdef CONFIG_ARGO
-    HYPERCALL(argo_op, 5),
-#endif
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op, 5),
-#endif
-#ifdef CONFIG_IOREQ_SERVER
-    HYPERCALL(dm_op, 3),
-#endif
-};
+long dep_physdev_op_compat(XEN_GUEST_HANDLE_PARAM(physdev_op_t) uop)
+{
+    return do_deprecated_hypercall();
+}
 
 #ifndef NDEBUG
 static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
@@ -1431,7 +1389,6 @@ static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
 #define HYPERCALL_ARG3(r) (r)->x2
 #define HYPERCALL_ARG4(r) (r)->x3
 #define HYPERCALL_ARG5(r) (r)->x4
-#define HYPERCALL_ARGS(r) (r)->x0, (r)->x1, (r)->x2, (r)->x3, (r)->x4
 #else
 #define HYPERCALL_RESULT_REG(r) (r)->r0
 #define HYPERCALL_ARG1(r) (r)->r0
@@ -1439,52 +1396,40 @@ static void do_debug_trap(struct cpu_user_regs *regs, unsigned int code)
 #define HYPERCALL_ARG3(r) (r)->r2
 #define HYPERCALL_ARG4(r) (r)->r3
 #define HYPERCALL_ARG5(r) (r)->r4
-#define HYPERCALL_ARGS(r) (r)->r0, (r)->r1, (r)->r2, (r)->r3, (r)->r4
 #endif
 
+static const unsigned char hypercall_args[] = hypercall_args_arm;
+
 static void do_trap_hypercall(struct cpu_user_regs *regs, register_t *nr,
                               const union hsr hsr)
 {
-    arm_hypercall_fn_t call = NULL;
     struct vcpu *curr = current;
 
-    BUILD_BUG_ON(NR_hypercalls < ARRAY_SIZE(arm_hypercall_table) );
-
     if ( hsr.iss != XEN_HYPERCALL_TAG )
     {
         gprintk(XENLOG_WARNING, "Invalid HVC imm 0x%x\n", hsr.iss);
         return inject_undef_exception(regs, hsr);
     }
 
-    if ( *nr >= ARRAY_SIZE(arm_hypercall_table) )
-    {
-        perfc_incr(invalid_hypercalls);
-        HYPERCALL_RESULT_REG(regs) = -ENOSYS;
-        return;
-    }
-
     curr->hcall_preempted = false;
 
     perfc_incra(hypercalls, *nr);
-    call = arm_hypercall_table[*nr].fn;
-    if ( call == NULL )
-    {
-        HYPERCALL_RESULT_REG(regs) = -ENOSYS;
-        return;
-    }
 
-    HYPERCALL_RESULT_REG(regs) = call(HYPERCALL_ARGS(regs));
+    call_handlers_arm(*nr, HYPERCALL_RESULT_REG(regs), HYPERCALL_ARG1(regs),
+                      HYPERCALL_ARG2(regs), HYPERCALL_ARG3(regs),
+                      HYPERCALL_ARG4(regs), HYPERCALL_ARG5(regs));
 
 #ifndef NDEBUG
-    if ( !curr->hcall_preempted )
+    if ( !curr->hcall_preempted && HYPERCALL_RESULT_REG(regs) != -ENOSYS )
     {
         /* Deliberately corrupt parameter regs used by this hypercall. */
-        switch ( arm_hypercall_table[*nr].nr_args ) {
+        switch ( hypercall_args[*nr] ) {
         case 5: HYPERCALL_ARG5(regs) = 0xDEADBEEF;
         case 4: HYPERCALL_ARG4(regs) = 0xDEADBEEF;
         case 3: HYPERCALL_ARG3(regs) = 0xDEADBEEF;
         case 2: HYPERCALL_ARG2(regs) = 0xDEADBEEF;
         case 1: /* Don't clobber x0/r0 -- it's the return value */
+        case 0: /* -ENOSYS case */
             break;
         default: BUG();
         }
@@ -1521,7 +1466,10 @@ static bool check_multicall_32bit_clean(struct multicall_entry *multi)
 {
     int i;
 
-    for ( i = 0; i < arm_hypercall_table[multi->op].nr_args; i++ )
+    if ( multi->op >= ARRAY_SIZE(hypercall_args) )
+        return true;
+
+    for ( i = 0; i < hypercall_args[multi->op]; i++ )
     {
         if ( unlikely(multi->args[i] & 0xffffffff00000000ULL) )
         {
@@ -1538,28 +1486,13 @@ static bool check_multicall_32bit_clean(struct multicall_entry *multi)
 enum mc_disposition arch_do_multicall_call(struct mc_state *state)
 {
     struct multicall_entry *multi = &state->call;
-    arm_hypercall_fn_t call = NULL;
-
-    if ( multi->op >= ARRAY_SIZE(arm_hypercall_table) )
-    {
-        multi->result = -ENOSYS;
-        return mc_continue;
-    }
-
-    call = arm_hypercall_table[multi->op].fn;
-    if ( call == NULL )
-    {
-        multi->result = -ENOSYS;
-        return mc_continue;
-    }
 
     if ( is_32bit_domain(current->domain) &&
          !check_multicall_32bit_clean(multi) )
         return mc_continue;
 
-    multi->result = call(multi->args[0], multi->args[1],
-                         multi->args[2], multi->args[3],
-                         multi->args[4]);
+    call_handlers_arm(multi->op, multi->result, multi->args[0], multi->args[1],
+                      multi->args[2], multi->args[3], multi->args[4]);
 
     return likely(!psr_mode_is_user(guest_cpu_user_regs()))
            ? mc_continue : mc_preempt;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242365.419280 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIs-0003hu-JJ; Wed, 08 Dec 2021 15:56:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242365.419280; Wed, 08 Dec 2021 15:56:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIr-0003cp-TF; Wed, 08 Dec 2021 15:56:21 +0000
Received: by outflank-mailman (input) for mailman id 242365;
 Wed, 08 Dec 2021 15:56:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIm-0001Lz-Gx
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:16 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5e67c314-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:56:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1E4241FE0C;
 Wed,  8 Dec 2021 15:56:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D8D4C13C8E;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yLyrM5zVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e67c314-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0EFSnHVw6cnDzHQVQhnjfL6RwtaM6YAZunMTPJmxhog=;
	b=s0EWc156YyrnRi9jWgnsTFzBP5o3+MdaGEu9kmrwqCwH/hnjXqvY0QRWhxDNM5+QM7+GRo
	sypHZRtfN0oTrd4ozI89r3gwDc++ja1iUJpCisduLUj2ggN3Qyp47QxAoek42Co5DE1C9z
	peAvux6CsxhqlY4vz0H38Aif5P46Rx8=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 12/13] xen: drop calls_to_multicall performance counter
Date: Wed,  8 Dec 2021 16:56:05 +0100
Message-Id: <20211208155606.20029-13-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The calls_to_multicall performance counter is basically redundant to
the multicall hypercall counter. The only difference is the counting
of continuation calls, which isn't really that interesting.

Drop the calls_to_multicall performance counter.

Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- new patch
---
 xen/common/multicall.c       | 1 -
 xen/include/xen/perfc_defn.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/xen/common/multicall.c b/xen/common/multicall.c
index 7b20717c88..2e66f9f0c1 100644
--- a/xen/common/multicall.c
+++ b/xen/common/multicall.c
@@ -114,7 +114,6 @@ do_multicall(
     if ( unlikely(disp == mc_preempt) && i < nr_calls )
         goto preempted;
 
-    perfc_incr(calls_to_multicall);
     perfc_add(calls_from_multicall, i);
     mcs->flags = 0;
     return rc;
diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h
index 08b182ccd9..eb6152859e 100644
--- a/xen/include/xen/perfc_defn.h
+++ b/xen/include/xen/perfc_defn.h
@@ -6,7 +6,6 @@
 
 PERFCOUNTER_ARRAY(hypercalls,           "hypercalls", NR_hypercalls)
 
-PERFCOUNTER(calls_to_multicall,         "calls to multicall")
 PERFCOUNTER(calls_from_multicall,       "calls from multicall")
 
 PERFCOUNTER(irqs,                   "#interrupts")
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242366.419296 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIu-00047d-Vh; Wed, 08 Dec 2021 15:56:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242366.419296; Wed, 08 Dec 2021 15:56:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIt-0003y7-I7; Wed, 08 Dec 2021 15:56:23 +0000
Received: by outflank-mailman (input) for mailman id 242366;
 Wed, 08 Dec 2021 15:56:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIn-0001LM-76
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:17 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e8c5538-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 518E22113A;
 Wed,  8 Dec 2021 15:56:13 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 23FF013C8E;
 Wed,  8 Dec 2021 15:56:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wNGTB53VsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e8c5538-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZW7CF/kM5fAK9CnX8HECoM3KdS2qty2F3E2zABI0ze4=;
	b=jm+mLf5mJ6XLyj6H6NUQFb9MiFSpRUc3FjYwvvqh8Wqp5Rp6Rmsmb/vQ6ssFAOSMy5ZOG4
	axriK8aY9HQlQmE06hSb9OrMTu452eZdq7xP0hc+wDkPtAfNa8wZ5eMUB6+Q0A1ewCuUeC
	i6dRxv9WLTAQik70wZyjbts3gPd5FmA=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v3 13/13] tools/xenperf: update hypercall names
Date: Wed,  8 Dec 2021 16:56:06 +0100
Message-Id: <20211208155606.20029-14-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The hypercall names need some update.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- new patch
---
 tools/misc/xenperf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/misc/xenperf.c b/tools/misc/xenperf.c
index a5fbdaa45f..2ad737e661 100644
--- a/tools/misc/xenperf.c
+++ b/tools/misc/xenperf.c
@@ -57,6 +57,11 @@ const char *hypercall_name_table[64] =
     X(sysctl),
     X(domctl),
     X(kexec_op),
+    X(tmem_op),
+    X(argo_op),
+    X(xenpmu_op),
+    X(dm_op),
+    X(hypfs_op),
     X(arch_0),
     X(arch_1),
     X(arch_2),
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:56:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:56:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242367.419307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIy-0004i6-9g; Wed, 08 Dec 2021 15:56:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242367.419307; Wed, 08 Dec 2021 15:56:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzIw-0004a5-L2; Wed, 08 Dec 2021 15:56:26 +0000
Received: by outflank-mailman (input) for mailman id 242367;
 Wed, 08 Dec 2021 15:56:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzIo-0001LM-7D
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:56:18 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e04d5dd-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:56:12 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 66EBF1FE01;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 27CC713C8E;
 Wed,  8 Dec 2021 15:56:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yIiSCJzVsGHIXwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:56:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e04d5dd-583f-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638978972; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3himJFRfurQYBLo8Y8yogcKWRO02wPAeaAXCAVac6Xg=;
	b=lLdE/c7QZmoIhyA8h6+RG3FFOPOtZF/ovaVQf1T6J5AlT+E+NnFbjZq3iGsbP94cIJ/gXM
	LIotb3hC/DQU+FUGCtBenk0buyRL7s5jKy8L9oaAf3yfDgS9O5rt0DaLv0qoNBwxP6t6EL
	16F3wbXlNVG0SRU+mqAKvliOu9oHQzU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH v3 09/13] xen/x86: call hypercall handlers via generated macro
Date: Wed,  8 Dec 2021 16:56:02 +0100
Message-Id: <20211208155606.20029-10-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
References: <20211208155606.20029-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of using a function table use the generated macros for calling
the appropriate hypercall handlers.

This is beneficial to performance and avoids speculation issues.

With calling the handlers using the correct number of parameters now
it is possible to do the parameter register clobbering in the NDEBUG
case after returning from the handler. With the additional generated
data the hard coded hypercall_args_table[] can be replaced by tables
using the generated number of parameters.

Note that this change modifies behavior of clobbering registers in a
minor way: in case a hypercall is returning -ENOSYS (or the unsigned
equivalent thereof) for any reason the parameter registers will no
longer be clobbered. This should be of no real concern, as those cases
ought to be extremely rare and reuse of the registers in those cases
seems rather far fetched.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- make hypercall_args_*[] const (Jan Beulich)
- make clobber_regs*() independent from NDEBUG (Jan Beulich)
- drop "L" suffix for 32-bit register clobber value (Jan Beulich)
V3:
- add array_access_nospec() (Jan Beulich)
- remove local variables in hvm_hypercall() (Andrew Cooper)
---
 xen/arch/x86/hvm/hypercall.c    | 166 +++-------------------------
 xen/arch/x86/hypercall.c        |  59 ----------
 xen/arch/x86/pv/hypercall.c     | 184 +++-----------------------------
 xen/include/asm-x86/hypercall.h |  55 +++++++---
 4 files changed, 76 insertions(+), 388 deletions(-)

diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c
index 85b7a33523..5952172476 100644
--- a/xen/arch/x86/hvm/hypercall.c
+++ b/xen/arch/x86/hvm/hypercall.c
@@ -108,56 +108,10 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
         return compat_physdev_op(cmd, arg);
 }
 
-#define HYPERCALL(x)                                         \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
-                               (hypercall_fn_t *) do_ ## x }
-
-#define HVM_CALL(x)                                          \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) hvm_ ## x, \
-                               (hypercall_fn_t *) hvm_ ## x }
-
-#define COMPAT_CALL(x)                                       \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,  \
-                               (hypercall_fn_t *) compat_ ## x }
-
-static const struct {
-    hypercall_fn_t *native, *compat;
-} hvm_hypercall_table[] = {
-    HVM_CALL(memory_op),
-    COMPAT_CALL(multicall),
-#ifdef CONFIG_GRANT_TABLE
-    HVM_CALL(grant_table_op),
-#endif
-    HYPERCALL(vm_assist),
-    COMPAT_CALL(vcpu_op),
-    HVM_CALL(physdev_op),
-    COMPAT_CALL(xen_version),
-    HYPERCALL(console_io),
-    HYPERCALL(event_channel_op),
-    COMPAT_CALL(sched_op),
-    COMPAT_CALL(set_timer_op),
-    COMPAT_CALL(xsm_op),
-    HYPERCALL(hvm_op),
-    HYPERCALL(sysctl),
-    HYPERCALL(domctl),
-#ifdef CONFIG_ARGO
-    COMPAT_CALL(argo_op),
-#endif
-    COMPAT_CALL(platform_op),
-#ifdef CONFIG_PV
-    COMPAT_CALL(mmuext_op),
-#endif
-    HYPERCALL(xenpmu_op),
-    COMPAT_CALL(dm_op),
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op),
+#ifndef NDEBUG
+static const unsigned char hypercall_args_64[] = hypercall_args_hvm64;
+static const unsigned char hypercall_args_32[] = hypercall_args_hvm32;
 #endif
-    HYPERCALL(paging_domctl_cont)
-};
-
-#undef HYPERCALL
-#undef HVM_CALL
-#undef COMPAT_CALL
 
 int hvm_hypercall(struct cpu_user_regs *regs)
 {
@@ -203,23 +157,6 @@ int hvm_hypercall(struct cpu_user_regs *regs)
         return ret;
     }
 
-    BUILD_BUG_ON(ARRAY_SIZE(hvm_hypercall_table) >
-                 ARRAY_SIZE(hypercall_args_table));
-
-    if ( eax >= ARRAY_SIZE(hvm_hypercall_table) )
-    {
-        regs->rax = -ENOSYS;
-        return HVM_HCALL_completed;
-    }
-
-    eax = array_index_nospec(eax, ARRAY_SIZE(hvm_hypercall_table));
-
-    if ( !hvm_hypercall_table[eax].native )
-    {
-        regs->rax = -ENOSYS;
-        return HVM_HCALL_completed;
-    }
-
     /*
      * Caching is intended for instruction emulation only. Disable it
      * for any accesses by hypercall argument copy-in / copy-out.
@@ -230,85 +167,27 @@ int hvm_hypercall(struct cpu_user_regs *regs)
 
     if ( mode == 8 )
     {
-        unsigned long rdi = regs->rdi;
-        unsigned long rsi = regs->rsi;
-        unsigned long rdx = regs->rdx;
-        unsigned long r10 = regs->r10;
-        unsigned long r8 = regs->r8;
-
         HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%lx, %lx, %lx, %lx, %lx)",
-                    eax, rdi, rsi, rdx, r10, r8);
-
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].native )
-        {
-        case 0: rdi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL;
-        }
-#endif
+                    eax, regs->rdi, regs->rsi, regs->rdx, regs->r10, regs->r8);
 
-        regs->rax = hvm_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
+        call_handlers_hvm64(eax, regs->rax, regs->rdi, regs->rsi, regs->rdx,
+                            regs->r10, regs->r8);
 
-#ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].native )
-            {
-            case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
-            }
-        }
-#endif
+        if ( !curr->hcall_preempted && regs->rax != -ENOSYS )
+            clobber_regs(regs, get_nargs(hypercall_args_64, eax));
     }
     else
     {
-        unsigned int ebx = regs->ebx;
-        unsigned int ecx = regs->ecx;
-        unsigned int edx = regs->edx;
-        unsigned int esi = regs->esi;
-        unsigned int edi = regs->edi;
-
         HVM_DBG_LOG(DBG_LEVEL_HCALL, "hcall%lu(%x, %x, %x, %x, %x)", eax,
-                    ebx, ecx, edx, esi, edi);
-
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].compat )
-        {
-        case 0: ebx = 0xdeadf00d; fallthrough;
-        case 1: ecx = 0xdeadf00d; fallthrough;
-        case 2: edx = 0xdeadf00d; fallthrough;
-        case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d;
-        }
-#endif
+                    regs->ebx, regs->ecx, regs->edx, regs->esi, regs->edi);
 
         curr->hcall_compat = true;
-        regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        call_handlers_hvm32(eax, regs->eax, regs->ebx, regs->ecx, regs->edx,
+                            regs->esi, regs->edi);
         curr->hcall_compat = false;
 
-#ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].compat )
-            {
-            case 5: regs->rdi = 0xdeadf00d; fallthrough;
-            case 4: regs->rsi = 0xdeadf00d; fallthrough;
-            case 3: regs->rdx = 0xdeadf00d; fallthrough;
-            case 2: regs->rcx = 0xdeadf00d; fallthrough;
-            case 1: regs->rbx = 0xdeadf00d;
-            }
-        }
-#endif
+        if ( !curr->hcall_preempted && regs->eax != -ENOSYS )
+            clobber_regs32(regs, get_nargs(hypercall_args_32, eax));
     }
 
     hvmemul_cache_restore(curr, token);
@@ -327,31 +206,20 @@ int hvm_hypercall(struct cpu_user_regs *regs)
 enum mc_disposition hvm_do_multicall_call(struct mc_state *state)
 {
     struct vcpu *curr = current;
-    hypercall_fn_t *func = NULL;
 
     if ( hvm_guest_x86_mode(curr) == 8 )
     {
         struct multicall_entry *call = &state->call;
 
-        if ( call->op < ARRAY_SIZE(hvm_hypercall_table) )
-            func = array_access_nospec(hvm_hypercall_table, call->op).native;
-        if ( func )
-            call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_hvm64(call->op, call->result, call->args[0], call->args[1],
+                            call->args[2], call->args[3], call->args[4]);
     }
     else
     {
         struct compat_multicall_entry *call = &state->compat_call;
 
-        if ( call->op < ARRAY_SIZE(hvm_hypercall_table) )
-            func = array_access_nospec(hvm_hypercall_table, call->op).compat;
-        if ( func )
-            call->result = func(call->args[0], call->args[1], call->args[2],
-                                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_hvm32(call->op, call->result, call->args[0], call->args[1],
+                            call->args[2], call->args[3], call->args[4]);
     }
 
     return !hvm_get_cpl(curr) ? mc_continue : mc_preempt;
diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c
index 07e1a45ef5..6b73cff9b9 100644
--- a/xen/arch/x86/hypercall.c
+++ b/xen/arch/x86/hypercall.c
@@ -22,65 +22,6 @@
 #include <xen/hypercall.h>
 #include <asm/multicall.h>
 
-#ifdef CONFIG_COMPAT
-#define ARGS(x, n)                              \
-    [ __HYPERVISOR_ ## x ] = { n, n }
-#define COMP(x, n, c)                           \
-    [ __HYPERVISOR_ ## x ] = { n, c }
-#else
-#define ARGS(x, n)    [ __HYPERVISOR_ ## x ] = { n }
-#define COMP(x, n, c) ARGS(x, n)
-#endif
-
-const hypercall_args_t hypercall_args_table[NR_hypercalls] =
-{
-    ARGS(set_trap_table, 1),
-    ARGS(mmu_update, 4),
-    ARGS(set_gdt, 2),
-    ARGS(stack_switch, 2),
-    COMP(set_callbacks, 3, 4),
-    ARGS(fpu_taskswitch, 1),
-    ARGS(sched_op_compat, 2),
-    ARGS(platform_op, 1),
-    ARGS(set_debugreg, 2),
-    ARGS(get_debugreg, 1),
-    COMP(update_descriptor, 2, 4),
-    ARGS(memory_op, 2),
-    ARGS(multicall, 2),
-    COMP(update_va_mapping, 3, 4),
-    COMP(set_timer_op, 1, 2),
-    ARGS(event_channel_op_compat, 1),
-    ARGS(xen_version, 2),
-    ARGS(console_io, 3),
-    ARGS(physdev_op_compat, 1),
-    ARGS(grant_table_op, 3),
-    ARGS(vm_assist, 2),
-    COMP(update_va_mapping_otherdomain, 4, 5),
-    ARGS(vcpu_op, 3),
-    COMP(set_segment_base, 2, 0),
-    ARGS(mmuext_op, 4),
-    ARGS(xsm_op, 1),
-    ARGS(nmi_op, 2),
-    ARGS(sched_op, 2),
-    ARGS(callback_op, 2),
-    ARGS(xenoprof_op, 2),
-    ARGS(event_channel_op, 2),
-    ARGS(physdev_op, 2),
-    ARGS(sysctl, 1),
-    ARGS(domctl, 1),
-    ARGS(kexec_op, 2),
-    ARGS(argo_op, 5),
-    ARGS(xenpmu_op, 2),
-    ARGS(hvm_op, 2),
-    ARGS(dm_op, 3),
-    ARGS(hypfs_op, 5),
-    ARGS(mca, 1),
-    ARGS(paging_domctl_cont, 1),
-};
-
-#undef COMP
-#undef ARGS
-
 #define NEXT_ARG(fmt, args)                                                 \
 ({                                                                          \
     unsigned long __arg;                                                    \
diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c
index c391d18130..ef92266620 100644
--- a/xen/arch/x86/pv/hypercall.c
+++ b/xen/arch/x86/pv/hypercall.c
@@ -27,119 +27,22 @@
 #include <asm/multicall.h>
 #include <irq_vectors.h>
 
-typedef struct {
-    hypercall_fn_t *native;
-#ifdef CONFIG_PV32
-    hypercall_fn_t *compat;
-#endif
-} pv_hypercall_table_t;
-
+#ifndef NDEBUG
+static const unsigned char hypercall_args_64[] = hypercall_args_pv64;
 #ifdef CONFIG_PV32
-#define HYPERCALL(x)                                                \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
-                               (hypercall_fn_t *) do_ ## x }
-#define COMPAT_CALL(x)                                              \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x,         \
-                               (hypercall_fn_t *) compat_ ## x }
-#else
-#define HYPERCALL(x)                                                \
-    [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x }
-#define COMPAT_CALL(x) HYPERCALL(x)
-#endif
-
-static const pv_hypercall_table_t pv_hypercall_table[] = {
-    COMPAT_CALL(set_trap_table),
-    HYPERCALL(mmu_update),
-    COMPAT_CALL(set_gdt),
-    HYPERCALL(stack_switch),
-    COMPAT_CALL(set_callbacks),
-    HYPERCALL(fpu_taskswitch),
-    HYPERCALL(sched_op_compat),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    COMPAT_CALL(platform_op),
-#endif
-    HYPERCALL(set_debugreg),
-    HYPERCALL(get_debugreg),
-    COMPAT_CALL(update_descriptor),
-    COMPAT_CALL(memory_op),
-    COMPAT_CALL(multicall),
-    COMPAT_CALL(update_va_mapping),
-    COMPAT_CALL(set_timer_op),
-    HYPERCALL(event_channel_op_compat),
-    COMPAT_CALL(xen_version),
-    HYPERCALL(console_io),
-    COMPAT_CALL(physdev_op_compat),
-#if defined(CONFIG_GRANT_TABLE) || defined(CONFIG_PV_SHIM)
-    COMPAT_CALL(grant_table_op),
-#endif
-    HYPERCALL(vm_assist),
-    COMPAT_CALL(update_va_mapping_otherdomain),
-    COMPAT_CALL(iret),
-    COMPAT_CALL(vcpu_op),
-    HYPERCALL(set_segment_base),
-    COMPAT_CALL(mmuext_op),
-    COMPAT_CALL(xsm_op),
-    COMPAT_CALL(nmi_op),
-    COMPAT_CALL(sched_op),
-    COMPAT_CALL(callback_op),
-#ifdef CONFIG_XENOPROF
-    COMPAT_CALL(xenoprof_op),
-#endif
-    HYPERCALL(event_channel_op),
-    COMPAT_CALL(physdev_op),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(sysctl),
-    HYPERCALL(domctl),
-#endif
-#ifdef CONFIG_KEXEC
-    COMPAT_CALL(kexec_op),
+static const unsigned char hypercall_args_32[] = hypercall_args_pv32;
 #endif
-#ifdef CONFIG_ARGO
-    COMPAT_CALL(argo_op),
 #endif
-    HYPERCALL(xenpmu_op),
-#ifdef CONFIG_HVM
-    HYPERCALL(hvm_op),
-    COMPAT_CALL(dm_op),
-#endif
-#ifdef CONFIG_HYPFS
-    HYPERCALL(hypfs_op),
-#endif
-    HYPERCALL(mca),
-#ifndef CONFIG_PV_SHIM_EXCLUSIVE
-    HYPERCALL(paging_domctl_cont),
-#endif
-};
-
-#undef COMPAT_CALL
-#undef HYPERCALL
 
 /* Forced inline to cause 'compat' to be evaluated at compile time. */
 static void always_inline
 _pv_hypercall(struct cpu_user_regs *regs, bool compat)
 {
     struct vcpu *curr = current;
-    unsigned long eax = compat ? regs->eax : regs->rax;
+    unsigned long eax;
 
     ASSERT(guest_kernel_mode(curr, regs));
 
-    BUILD_BUG_ON(ARRAY_SIZE(pv_hypercall_table) >
-                 ARRAY_SIZE(hypercall_args_table));
-
-    if ( eax >= ARRAY_SIZE(pv_hypercall_table) )
-    {
-        regs->rax = -ENOSYS;
-        return;
-    }
-
-    eax = array_index_nospec(eax, ARRAY_SIZE(pv_hypercall_table));
-
-    if ( !pv_hypercall_table[eax].native )
-    {
-        regs->rax = -ENOSYS;
-        return;
-    }
-
     curr->hcall_preempted = false;
 
     if ( !compat )
@@ -150,17 +53,8 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned long r10 = regs->r10;
         unsigned long r8 = regs->r8;
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].native )
-        {
-        case 0: rdi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 1: rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 2: rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 3: r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-        case 4: r8 = 0xdeadbeefdeadf00dUL;
-        }
-#endif
+        eax = regs->rax;
+
         if ( unlikely(tb_init_done) )
         {
             unsigned long args[5] = { rdi, rsi, rdx, r10, r8 };
@@ -168,22 +62,10 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
             __trace_hypercall(TRC_PV_HYPERCALL_V2, eax, args);
         }
 
-        regs->rax = pv_hypercall_table[eax].native(rdi, rsi, rdx, r10, r8);
+        call_handlers_pv64(eax, regs->rax, rdi, rsi, rdx, r10, r8);
 
-#ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].native )
-            {
-            case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
-            case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
-            }
-        }
-#endif
+        if ( !curr->hcall_preempted && regs->rax != -ENOSYS )
+            clobber_regs(regs, get_nargs(hypercall_args_64, eax));
     }
 #ifdef CONFIG_PV32
     else
@@ -194,17 +76,7 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         unsigned int esi = regs->esi;
         unsigned int edi = regs->edi;
 
-#ifndef NDEBUG
-        /* Deliberately corrupt parameter regs not used by this hypercall. */
-        switch ( hypercall_args_table[eax].compat )
-        {
-        case 0: ebx = 0xdeadf00d; fallthrough;
-        case 1: ecx = 0xdeadf00d; fallthrough;
-        case 2: edx = 0xdeadf00d; fallthrough;
-        case 3: esi = 0xdeadf00d; fallthrough;
-        case 4: edi = 0xdeadf00d;
-        }
-#endif
+        eax = regs->eax;
 
         if ( unlikely(tb_init_done) )
         {
@@ -214,23 +86,11 @@ _pv_hypercall(struct cpu_user_regs *regs, bool compat)
         }
 
         curr->hcall_compat = true;
-        regs->eax = pv_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi);
+        call_handlers_pv32(eax, regs->eax, ebx, ecx, edx, esi, edi);
         curr->hcall_compat = false;
 
-#ifndef NDEBUG
-        if ( !curr->hcall_preempted )
-        {
-            /* Deliberately corrupt parameter regs used by this hypercall. */
-            switch ( hypercall_args_table[eax].compat )
-            {
-            case 5: regs->edi = 0xdeadf00d; fallthrough;
-            case 4: regs->esi = 0xdeadf00d; fallthrough;
-            case 3: regs->edx = 0xdeadf00d; fallthrough;
-            case 2: regs->ecx = 0xdeadf00d; fallthrough;
-            case 1: regs->ebx = 0xdeadf00d;
-            }
-        }
-#endif
+        if ( !curr->hcall_preempted && regs->eax != -ENOSYS )
+            clobber_regs32(regs, get_nargs(hypercall_args_32, eax));
     }
 #endif /* CONFIG_PV32 */
 
@@ -256,13 +116,8 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
         struct compat_multicall_entry *call = &state->compat_call;
 
         op = call->op;
-        if ( (op < ARRAY_SIZE(pv_hypercall_table)) &&
-             pv_hypercall_table[op].compat )
-            call->result = pv_hypercall_table[op].compat(
-                call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_pv32(op, call->result, call->args[0], call->args[1],
+                           call->args[2], call->args[3], call->args[4]);
     }
     else
 #endif
@@ -270,13 +125,8 @@ enum mc_disposition pv_do_multicall_call(struct mc_state *state)
         struct multicall_entry *call = &state->call;
 
         op = call->op;
-        if ( (op < ARRAY_SIZE(pv_hypercall_table)) &&
-             pv_hypercall_table[op].native )
-            call->result = pv_hypercall_table[op].native(
-                call->args[0], call->args[1], call->args[2],
-                call->args[3], call->args[4]);
-        else
-            call->result = -ENOSYS;
+        call_handlers_pv64(op, call->result, call->args[0], call->args[1],
+                           call->args[2], call->args[3], call->args[4]);
     }
 
     return unlikely(op == __HYPERVISOR_iret)
diff --git a/xen/include/asm-x86/hypercall.h b/xen/include/asm-x86/hypercall.h
index eb2907b5b6..2077e28d23 100644
--- a/xen/include/asm-x86/hypercall.h
+++ b/xen/include/asm-x86/hypercall.h
@@ -17,19 +17,6 @@
 
 #define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1
 
-typedef unsigned long hypercall_fn_t(
-    unsigned long, unsigned long, unsigned long,
-    unsigned long, unsigned long);
-
-typedef struct {
-    uint8_t native;
-#ifdef CONFIG_COMPAT
-    uint8_t compat;
-#endif
-} hypercall_args_t;
-
-extern const hypercall_args_t hypercall_args_table[NR_hypercalls];
-
 #ifdef CONFIG_PV
 void pv_hypercall(struct cpu_user_regs *regs);
 #endif
@@ -55,4 +42,46 @@ compat_common_vcpu_op(
 
 #endif /* CONFIG_COMPAT */
 
+#ifndef NDEBUG
+static inline unsigned int _get_nargs(const unsigned char *tbl, unsigned int c)
+{
+    return tbl[c];
+}
+#define get_nargs(t, c) _get_nargs(t, array_index_nospec(c, ARRAY_SIZE(t)))
+#else
+#define get_nargs(tbl, c) 0
+#endif
+
+static inline void clobber_regs(struct cpu_user_regs *regs,
+                                unsigned int nargs)
+{
+#ifndef NDEBUG
+    /* Deliberately corrupt used parameter regs. */
+    switch ( nargs )
+    {
+    case 5: regs->r8  = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 4: regs->r10 = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 3: regs->rdx = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 2: regs->rsi = 0xdeadbeefdeadf00dUL; fallthrough;
+    case 1: regs->rdi = 0xdeadbeefdeadf00dUL;
+    }
+#endif
+}
+
+static inline void clobber_regs32(struct cpu_user_regs *regs,
+                                  unsigned int nargs)
+{
+#ifndef NDEBUG
+    /* Deliberately corrupt used parameter regs. */
+    switch ( nargs )
+    {
+    case 5: regs->edi = 0xdeadf00dU; fallthrough;
+    case 4: regs->esi = 0xdeadf00dU; fallthrough;
+    case 3: regs->edx = 0xdeadf00dU; fallthrough;
+    case 2: regs->ecx = 0xdeadf00dU; fallthrough;
+    case 1: regs->ebx = 0xdeadf00dU;
+    }
+#endif
+}
+
 #endif /* __ASM_X86_HYPERCALL_H__ */
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:57:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:57:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242427.419340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzKM-0001lr-2o; Wed, 08 Dec 2021 15:57:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242427.419340; Wed, 08 Dec 2021 15:57:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzKL-0001lk-Vm; Wed, 08 Dec 2021 15:57:53 +0000
Received: by outflank-mailman (input) for mailman id 242427;
 Wed, 08 Dec 2021 15:57:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=J2Or=QZ=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1muzKK-0001im-O2
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:57:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 99200d72-583f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 16:57:51 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9855D21763;
 Wed,  8 Dec 2021 15:57:51 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1AD1813C8E;
 Wed,  8 Dec 2021 15:57:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Bh17A//VsGGbYAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 08 Dec 2021 15:57:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99200d72-583f-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1638979071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=0ff3PXmoawfeRWKK2+WEoneeOzt3SY6TL0hTUbB6omY=;
	b=u+eAOxbS2bUQq4q9RzYTS/z54CQij0AwivYTHBya0Dx6YqGyNd5KKIptAGMZrp1dDxmL3G
	FLvdFrIBjA1stsv+OsRb/EQsN/SYF10sSbn5C3HE+XS35+jCa/NjMAfcjcHMoQL5v7ABG6
	CEnF5BWTfZQ9nQ4AJUaC+FecU7+vSNs=
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
To: Andrew Cooper <amc96@srcf.net>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
 <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
 <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
From: Juergen Gross <jgross@suse.com>
Message-ID: <efaa6395-f52e-193f-dec7-fc2114e760a5@suse.com>
Date: Wed, 8 Dec 2021 16:57:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="35J2LrcOLET4Xu6rrYPAxEdOZL6caqdqY"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--35J2LrcOLET4Xu6rrYPAxEdOZL6caqdqY
Content-Type: multipart/mixed; boundary="6zR7RmubX32NocimjaP2W7754qagzeVmI";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <amc96@srcf.net>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <efaa6395-f52e-193f-dec7-fc2114e760a5@suse.com>
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
 <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
 <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
In-Reply-To: <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>

--6zR7RmubX32NocimjaP2W7754qagzeVmI
Content-Type: multipart/mixed;
 boundary="------------92EC60AFD1FF8E114417BBEF"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------92EC60AFD1FF8E114417BBEF
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 08.12.21 16:54, Andrew Cooper wrote:
> On 08/12/2021 14:22, Juergen Gross wrote:
>> On 08.12.21 14:43, Andrew Cooper wrote:
>>> On 08/12/2021 08:47, Juergen Gross wrote:
>>>> The HVM parameters for pre-allocated event channels should be set in=

>>>> libxenguest, like it is done for PV guests and for the pre-allocated=

>>>> ring pages.
>>>>
>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> I'm not sure that we have the concept of pre-allocated ring pages.
>>>
>>> For PV, we have:
>>>
>>>  =C2=A0=C2=A0=C2=A0=C2=A0 dom->console_pfn =3D xc_dom_alloc_page(dom,=
 "console");
>>>  =C2=A0=C2=A0=C2=A0=C2=A0 if ( dom->console_pfn =3D=3D INVALID_PFN )
>>>  =C2=A0=C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 return -1;
>>>  =C2=A0=C2=A0=C2=A0=C2=A0 xc_clear_domain_page(dom->xch, dom->guest_d=
omid,
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 xc_dom_p2m(dom, dom->console_pfn));
>>>
>>> and for HVM, we have:
>>>
>>>  =C2=A0=C2=A0=C2=A0=C2=A0 dom->console_pfn =3D special_pfn(SPECIALPAG=
E_CONSOLE);
>>>  =C2=A0=C2=A0=C2=A0=C2=A0 xc_clear_domain_page(dom->xch, dom->guest_d=
omid, dom->console_pfn);
>>
>> Isn't that a pre-allocation? The PFNs are fixed at boot time of the
>> guest.
>=20
> Yeah, but "allocated in the library call we're making" is not the same
> as "caller has to allocate and pass details in".
>=20
> I would not class the frames as "pre-allocated" in this context.
> "allocated" sure, so perhaps "just like it is done for PV guests, and
> the ring pages that libxenguest allocates" ?

Fine with me.

Should I send another round, or can this be changed when committing?


Juergen

--------------92EC60AFD1FF8E114417BBEF
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------92EC60AFD1FF8E114417BBEF--

--6zR7RmubX32NocimjaP2W7754qagzeVmI--

--35J2LrcOLET4Xu6rrYPAxEdOZL6caqdqY
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGw1f4FAwAAAAAACgkQsN6d1ii/Ey86
Vgf/W6MceExo2bXndfi4YAtJNm7e23d+tCzMISX0X2EYuLbzjqNrlH0K/AdwNmi92N9GHbamMGdV
DhFBqWRcKcumt24tQ/4+8aG9MsxAR/hhZxilrPJ5ZfPVtukvt/vd+JUbLR7/rEg0ro5tZn9T0c93
e4k1gnv3b27qjP0cZ2ThN4Es6qwEIXwc7ZFyiDwlENXYtOxXFye6dMLAR4KG5N9g+4P2BpFa9le9
GqpNgA/Zg1d7RBbtf3cDh+b9T7q5mVz6iF6aYhAY7uBMOgD4HwMU4YYZou31ORlzIyqB2SkjSe+w
not6cbl3SnOv3/oc2JcN8cZ1J4xaxpZlY+oUauyohw==
=BTdF
-----END PGP SIGNATURE-----

--35J2LrcOLET4Xu6rrYPAxEdOZL6caqdqY--


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 15:58:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 15:58:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242435.419351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzKr-0002V8-Bf; Wed, 08 Dec 2021 15:58:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242435.419351; Wed, 08 Dec 2021 15:58:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzKr-0002V1-8c; Wed, 08 Dec 2021 15:58:25 +0000
Received: by outflank-mailman (input) for mailman id 242435;
 Wed, 08 Dec 2021 15:58:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=EU5o=QZ=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1muzKq-0002M7-Lg
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 15:58:24 +0000
Received: from NAM12-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam12on20631.outbound.protection.outlook.com
 [2a01:111:f400:fe5b::631])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ab5895e2-583f-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 16:58:23 +0100 (CET)
Received: from BL1PR12MB5269.namprd12.prod.outlook.com (2603:10b6:208:30b::20)
 by BL1PR12MB5351.namprd12.prod.outlook.com (2603:10b6:208:317::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Wed, 8 Dec
 2021 15:58:20 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5269.namprd12.prod.outlook.com (2603:10b6:208:30b::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Wed, 8 Dec
 2021 15:58:19 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Wed, 8 Dec 2021
 15:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab5895e2-583f-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=chndAGNUgD5BvxKKa3jogynbRMZnPmAPmyVxEZZp6IcGyNTtW9wkUoSUHzMMIHuhqRjpJ/vSg4jNkoP4CyUEbUOBenTXf36FvYMYan4BJQ71hPbo4G/UOngLHrbKJrz4kJLiYrS6e9VvPBQ+PFgNzNCqWx5akz7DNRXK8PJikYx9letxuIk6FrSsJTkEybED6lIQJzqW3W93qjm9DCNPEtzBKFq4IVa/n+AW8EWsnmWhrePV0bVmJNVL6aklGpza1eiilzTzGV3+CbpXD1BQ3h34P1j/hcxo9+/3+Gf17Ov4G5QgdxsjbIIYqZ8Q7pRMXfqThGu4iTkqoRZllbjNEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vhhfh1Z4OaRQAiAKVqajt2RcGp0Iv7kNsws6AfW8ZpI=;
 b=Oql9Lrdxw0j7i6nI+IeEjbjtCl+IHI9XXZvlFxODbp2YnmV+OBLRBsR/BI4cQoxN6hB6NrnUXa5mOBRu1e4qGpO61NZ4XhQnOVqvqwP6SVq0bdhZif4vmTlKxC98DjhK+l9zqUcwvn9LdRNhjHfgAmNeLUnMywA6c9xGgrQs3T8zfvL2wsA64JwrSVZyDM/EmpZkhSJyiJ45Qz7psdgzBg9OGvH7Hz9Z7R3m96HkXP3mM0mcj7eO7lnT+BPcU1Tj1OSMJ4pe6NzA+3XjX0qt6eHFVq9JbkPNZgvd0C0mCs1gjtTBRD1Cbm8sWcIarRuG+Dmk9KbBxmqF7J4Nf5PIuw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vhhfh1Z4OaRQAiAKVqajt2RcGp0Iv7kNsws6AfW8ZpI=;
 b=nMh5CiPeaRGaX/3xcOKLjL4+gmOaTyN9J+rYYY6pBEwdDLCgLHHiDC1YiZQR8OUz6m6OsseL7Ho9jtHT5c8mqJAW2doUKMF1oBCS6g25C60JVsVubSpPgPb7G/Wzp+JzVO7tqi4wO7/re5u6YL642u3i2viKc43CuzG0uCUY/J0+riKX9eWNCMsO4zltTsEW6ijMhl55Y0HAFvJ9uXy6QkxBKODMbkDfg0VvaKuolI51BobZDRKyCIjqEVcHBRYaOFntgD58cre4xsHKwfdzGW6Q/NmgDp3duuFp2HI5REi5rGTvIZ1S49M0B2J/MJ6wgvxMVuvUhSZOKhT3O3UEUg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 11:58:16 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Will Deacon <will@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
Message-ID: <20211208155816.GZ6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.688216619@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210438.688216619@linutronix.de>
X-ClientProxiedBy: SJ0PR05CA0049.namprd05.prod.outlook.com
 (2603:10b6:a03:33f::24) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28a579de-45b7-4536-909e-08d9ba638dd0
X-MS-TrafficTypeDiagnostic: BL1PR12MB5269:EE_|BL1PR12MB5351:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB52692E87C2447367C43FE935C26F9@BL1PR12MB5269.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8A6Tqb8bg2+mXXGWrraUraNjt+Dbk+HoakX3aEWnfX58e1AzaV00tQp+0kOxXo6MbMlfHUFse3CgyaL9Y6NWq5XZerzJawx0urbwMgCM/DuLquEWhR0JhzTIuDdLKIyjlYLfacb/bcYXTD+I6/BrqLFw2wl9/UiC8bEKcw41sdVJLEAX6hUsqJHeZHQH43nJ4OCNctXMB/a0pzEJx8bYyJwcWstGzuf53a1/VrtpwA/Ksv2+TNwTjqYlAhdylMQC5/tmVCO1WP/1r+Q7Um33/ZEEtkg+4uvqbyzYiKS67W6OkOfOCFngTg7xPDuWcKhUowMy0aQXvp3WoTHAtK633R4pBQ8q/rcMqhTXNsByN9Up9p8VWhSZQ497W/0F1NeH0zaxSp0c0Ts8nNvNyr/Z3BA07/dLWBbC0/d7XmK3BiEqvzeARQp4g0/eTl9OsxtmL/XSCTvRMp3Zc+wPrpkumA5CNT3cVzigdLqeW9741yUORR0JB3Gb5h+Gm4g4//PVe7tJ2xuNKOoJ544A5cle5kOB2FsD1S2y3shHNJ8sAiWCIGyKq4P+o2G2FTtxbL6QgRRqcdtW/RL3Y9zoOZCcLT2aj4bSoGHavtGjWrzwT9J6/gRAZDwGK7dSptjohhaqJqKBiCYQvxhOiJahzLS7Pg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5269.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(7416002)(508600001)(6512007)(38100700002)(66476007)(6666004)(2616005)(33656002)(4326008)(6486002)(6506007)(26005)(6916009)(66946007)(66556008)(316002)(8676002)(5660300002)(83380400001)(1076003)(54906003)(186003)(2906002)(8936002)(86362001)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+qJJFjN+ab39S6TkbsBWOnrA2Qhu0Lg7bmLz0bRasCyrNSVAZqUoZLH12o/j?=
 =?us-ascii?Q?mwrtjEJf0Xctb7VWN6RaSJ53vsVyLvz1Fy2dia1dSmWRA7CywsiHRgyhsb4b?=
 =?us-ascii?Q?jbR9ifS79g2y8v124mTT6tk6ms6+cFK+Z9zS2T67m79O9DM2FL6wspNmz0eZ?=
 =?us-ascii?Q?4I2qu91XUZRXe2MfipurcsT84ScnfwbpRaFtKn89PE4VxnGxbc/igLU/ouYQ?=
 =?us-ascii?Q?nmx7DVe73HAfxpZMk21wkfA5ohIwmL3UVudBMSsutoFBrsqTcmh7NeoKcAon?=
 =?us-ascii?Q?mG+d0NFiHSD4oxA8MU65HtSGcrz8hctyn03do7ej4RTNVeiHElhRuWgGU/c4?=
 =?us-ascii?Q?BB+QIJ2X6jdO91L0KjIKom1xvPaM/7vkA2xSAGaEmJvjaCQqvNWx7Fbli6Ih?=
 =?us-ascii?Q?eVaQ9+W7SgOtOQywK7zbMol/wvAeV+HHNKl8XPSfWRbnUBzoTQnwrEMK74pe?=
 =?us-ascii?Q?nrqKcMEMy/bB7ricfLzpgCGamVOMGhWkwwhSZHY7WxicAj2dcoOdMgG9fOkR?=
 =?us-ascii?Q?C76ik4/rd84mTeNGFmjq3k+lxFqyFLN9UpHznhtNZQzOdgnNoCEJM9dnDJne?=
 =?us-ascii?Q?GdND7gpDT0RWpO+QPJjFWecVP0FZuc+C9E8OV7QtA/iQVzDb/WKN4tXCGuuA?=
 =?us-ascii?Q?30FtTnyxhcVdsmLqwVS+p5/LK5KLDon04cdNOUOuMPSYsRy2poGtxjsjNnwG?=
 =?us-ascii?Q?F7/RgSW3Xa6gh2W+xiXNiyP2LCS2yMrFQdcf6RTWHj6s90Uge3pWTeMJtmSJ?=
 =?us-ascii?Q?WJUl3lUv44NmZt6HN4foh5a707vA9SrMfND4fKnI55R3LllCG4fy6UTvdVen?=
 =?us-ascii?Q?b86T1q1yHKg7ygoVMz/hflupeWKPqkdgnssoWdfgPgAx2nco/ltxzp+MqO2B?=
 =?us-ascii?Q?wGyH8hubTFZ87EhalIZZfHOZ0ERUun83C6qsZk+iQpm/26+c6z04q47O0fPI?=
 =?us-ascii?Q?b4yezGpgBsOYTa1S5XS6TxVXXqc2w1f07Q5LIskTLxKXiQWUYA3AhEJFd1Cn?=
 =?us-ascii?Q?5iEppfVFqH+wE289Iymmd91AIntcjlcESu1PORIn/Gg9Q/+3sAfHWK96U+9S?=
 =?us-ascii?Q?KNMTt2tDGMZ2xmGlPkfdqN00D8NqmGg2dyWBblDx3v1y8c07A+QSkKvcU2g0?=
 =?us-ascii?Q?wtXqvAFzMYrhdTSc7xDQU8jeLiZ60rNlSlxilRRirigdqDCnnYZAl5RqW0kJ?=
 =?us-ascii?Q?lGRCTiWGgAAwh4xB9NTn7yj9PZXHS4uFXvLsuJbpRdlfBHgUZCKPCnRDlMuy?=
 =?us-ascii?Q?PyScBDWUAM2c3FozhJFemgpfHij5rJDTwGK0UELT5M2/z5sJM+ijo/RCoi2G?=
 =?us-ascii?Q?ndpn6ak6f5e14Bywc8jzVNa9bH7NMLRRgAuJcuWnX7+1q4aynp/q3BMjWNW/?=
 =?us-ascii?Q?vqfX8yojGFkQnfBcnp6mAWSKQ4TCI6AIWf0uS8XOXoGn5fNGe/EEDjou3HQJ?=
 =?us-ascii?Q?I062LqwAc4+sYXt0xjXfw0Eiq1/In/czgSNH4TPbM2RHURw2irHaCDf4Hq12?=
 =?us-ascii?Q?BCLzW1TE6qevIlh9CiTx7pij3hVcw6/O+IbfcW60nwt1k9pOwKguuLBclDMO?=
 =?us-ascii?Q?e72QxSd7SWVGnrL7Zmg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28a579de-45b7-4536-909e-08d9ba638dd0
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2021 15:58:19.4670
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bYAPMq42LAnCm/sVgjoOZU1ZAepIR0bIxzYB/ZUFhj2xhN34MlFNK59fq6POtcTv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5351

On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
> Store the properties which are interesting for various places so the MSI
> descriptor fiddling can be removed.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V2: Use the setter function
> ---
>  drivers/pci/msi/msi.c |    8 ++++++++
>  1 file changed, 8 insertions(+)

I took more time to look at this, to summarize my remarks on the other
patches

I think we don't need properties. The info in the msi_desc can come
from the pci_dev which we have easy access to. This seems overall
clearer

The notable one is the sysfs, but that is probably better handled by
storing a

  const char *sysfs_label

in the dev->msi and emitting that instead of computing it.

Jason


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:02:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:02:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242445.419362 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzOf-0004Vl-T4; Wed, 08 Dec 2021 16:02:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242445.419362; Wed, 08 Dec 2021 16:02:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzOf-0004Ve-OV; Wed, 08 Dec 2021 16:02:21 +0000
Received: by outflank-mailman (input) for mailman id 242445;
 Wed, 08 Dec 2021 16:02:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=cpXy=QZ=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1muzOe-0004VY-Ff
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 16:02:20 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 37c6499c-5840-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 17:02:19 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:51670)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1muzOb-00041E-i0 (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 08 Dec 2021 16:02:17 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 426971FED3;
 Wed,  8 Dec 2021 16:02:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37c6499c-5840-11ec-9d12-4777fae47e2b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4d48cc2f-bea4-c1f4-95ec-4efa6d56b661@srcf.net>
Date: Wed, 8 Dec 2021 16:02:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
 <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
 <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
 <efaa6395-f52e-193f-dec7-fc2114e760a5@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <efaa6395-f52e-193f-dec7-fc2114e760a5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 08/12/2021 15:57, Juergen Gross wrote:
> On 08.12.21 16:54, Andrew Cooper wrote:
>> On 08/12/2021 14:22, Juergen Gross wrote:
>>> On 08.12.21 14:43, Andrew Cooper wrote:
>>>> On 08/12/2021 08:47, Juergen Gross wrote:
>>>>> The HVM parameters for pre-allocated event channels should be set in
>>>>> libxenguest, like it is done for PV guests and for the pre-allocated
>>>>> ring pages.
>>>>>
>>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>
>>>> I'm not sure that we have the concept of pre-allocated ring pages.
>>>>
>>>> For PV, we have:
>>>>
>>>>       dom->console_pfn = xc_dom_alloc_page(dom, "console");
>>>>       if ( dom->console_pfn == INVALID_PFN )
>>>>           return -1;
>>>>       xc_clear_domain_page(dom->xch, dom->guest_domid,
>>>>                            xc_dom_p2m(dom, dom->console_pfn));
>>>>
>>>> and for HVM, we have:
>>>>
>>>>       dom->console_pfn = special_pfn(SPECIALPAGE_CONSOLE);
>>>>       xc_clear_domain_page(dom->xch, dom->guest_domid,
>>>> dom->console_pfn);
>>>
>>> Isn't that a pre-allocation? The PFNs are fixed at boot time of the
>>> guest.
>>
>> Yeah, but "allocated in the library call we're making" is not the same
>> as "caller has to allocate and pass details in".
>>
>> I would not class the frames as "pre-allocated" in this context.
>> "allocated" sure, so perhaps "just like it is done for PV guests, and
>> the ring pages that libxenguest allocates" ?
>
> Fine with me.
>
> Should I send another round, or can this be changed when committing?

Fixed on commit.  No need to resend just for this.

Question is whether Anthony has any view, or whether my R-by is good enough?

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:33:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:33:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242481.419373 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzsV-0000bh-B5; Wed, 08 Dec 2021 16:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242481.419373; Wed, 08 Dec 2021 16:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzsV-0000ba-6z; Wed, 08 Dec 2021 16:33:11 +0000
Received: by outflank-mailman (input) for mailman id 242481;
 Wed, 08 Dec 2021 16:33:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muzsU-0000bQ-8o; Wed, 08 Dec 2021 16:33:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muzsU-0001Sg-5Q; Wed, 08 Dec 2021 16:33:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1muzsT-00048Y-QC; Wed, 08 Dec 2021 16:33:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1muzsT-0005jB-Ph; Wed, 08 Dec 2021 16:33:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Pwq9/SJBwdguW0PI6ewAI6W+n2RJxTNz2gDAM/EuyxY=; b=oT5ahuSjipFPfLjYulDVqnxELB
	LunZ8Dn69QYMgCwKLR7K7vLhEwsoMHFJkP2NHl4Z93zQpzJgPbkMU1ZO14FWOhztMgerO+DaHP0Gy
	NP/Sh4OnPmZJkXQQWhWTtWyqU792r2uOqzkfVKPH/Bi1nsWkufePPW+BqSkx8gfzqTTI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167229-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167229: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2a987e65025e2b79c6d453b78cb5985ac6e5eb26
X-Osstest-Versions-That:
    linux=0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 16:33:09 +0000

flight 167229 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167229/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167179
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167179
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167179
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167179
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167179
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167179
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167179
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167179
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                2a987e65025e2b79c6d453b78cb5985ac6e5eb26
baseline version:
 linux                0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1

Last test of basis   167179  2021-12-06 04:55:24 Z    2 days
Failing since        167222  2021-12-06 19:43:33 Z    1 days    2 attempts
Testing same since   167229  2021-12-08 05:58:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Akira Yokosawa <akiyks@gmail.com>
  Alex Hung <alex.hung@canonical.com>
  Andrii Nakryiko <andrii@kernel.org>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Athira Rajeev <atrajeev@linux.vnet.ibm.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Erik Ekman <erik@kryo.se>
  Fabrizio Bertocci <fabriziobertocci@gmail.com>
  Hans de Goede <hdegoede@redhat.com>
  Hans Verkuil <hverkuil@xs4all.nl>
  Heiko Carstens <hca@linux.ibm.com>
  Ian Rogers <irogers@google.com>
  Jiri Olsa <jolsa@redhat.com>
  Joel Colledge <joel.colledge@linbit.com>
  Jonathan Corbet <corbet@lwn.net>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Matan Ziv-Av <matan@svgalib.org>
  Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
  Song Liu <song@kernel.org>
  Song Liu <songliubraving@fb.com>
  Thomas Richter <tmricht@linux.ibm.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   0fcfb00b28c0..2a987e65025e  2a987e65025e2b79c6d453b78cb5985ac6e5eb26 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:35:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:35:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242489.419387 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzuJ-0001FD-RO; Wed, 08 Dec 2021 16:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242489.419387; Wed, 08 Dec 2021 16:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzuJ-0001F6-O7; Wed, 08 Dec 2021 16:35:03 +0000
Received: by outflank-mailman (input) for mailman id 242489;
 Wed, 08 Dec 2021 16:35:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5Njo=QZ=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1muzuJ-0001Ew-AL
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 16:35:03 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c84643b9-5844-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 17:35:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c84643b9-5844-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1638981300;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=SAEcRaJ2kdxmwIYhezUPLi814xJYgNKU1n+cDfUokiM=;
  b=a0rzSo589vjzRAYS8WPBh7FBLbKbjmKFmYfquJavfd2ixO0sRLBCZ9Kw
   eTHiiAJmiHo/9zd2VfTz+k5UiJZ4LyvzLSNgCYnlyz2dIfkw0BvTzTsze
   wBWyhiaBP3Z6NYKCHrhSRdrTLhxj5fJZC716Kf7pfCt9qwGkUfNdDutNS
   Y=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bziSwNgHQBBIIDuagTTJZMFJwYyY76GJ2QJiduOBEXconJrcS5OcZYDHmyQGB6lLpqoI70ng67
 ShS6x7IJomsZdOhvWC6cs6fTNhvV4eCn/yhsyypsMaD6mcP7MT8zWXN/h0cYtL/niP6+cLT15n
 6z53EnF64OnuyEujbhf91wbiLstQzjxiELa9DszphJMP6u2tTHn0lDE4GU9WhKBtqyJprnOyAw
 eXFmttC0zpR+85zVald4hITS0ClL+bmaVcd24xfCXJ9p6+ZJsMASLeF3nPfgZlbUMcIKTpy+5j
 V9ZqDgUJmlu8sxWA59hP0Y/U
X-SBRS: 5.1
X-MesageID: 59957912
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:/+Yslak1bUKWgwk+zXO3Oojo5gxtIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeXmvUb/yDa2qmKdlwbYzgo0wP75WHnNNrHgY/pCwwRiMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2NY42YTR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PhJnJiSQiMYBY6Wgb8aQURJSxtYDaITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQKePO
 pVIMGAHgBLoWid1YWgdMMIHzMCy32b7aA9HuXONnP9ii4TU5FMoi+W8WDbPQfSLWsd9jkuev
 njB/WnyHlcdLtP34SWB2mKhgKnIhyyTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQ88y8l/PYa71agQJ/7UgHQiHyLpBkHQPJLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO
 kK1c83BKDhGtJ+ebUOm1e2N9jSgZDlNF0kyanpRJeca2OXLrIY2hxPJa99sFq+pk9H4cQ3NL
 yC2QDsW3OtK05NSv0mv1RWe2m/3+MCVJuIgzliPBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV
 1BUypHFvIji4Xxg/RFhodnh/pn1t55p0xWG2DaD+qXNERz0qhZPmqgKv1lDyL9BaJpsRNMQS
 Ba7VfltzJFSJmC2SqR8fpi8Dc8npYC5S4+1B6iPNoQQPskvHONiwM2ITRfBt4wKuBJz+ZzTx
 L/BKZr8ZZrkIfoPIMWKqxc1juZwm3FWKZL7TpHn1RW3uYdyl1bOIYrpxGCmN7hjhIvd+V292
 48Ga6OilkUOOMWjM3K/2dNCcjg3wY0TWMmeRzp/LbXYfGKL2QgJVpfs/F/WU9A/wvkOyL6Xp
 irVt40x4AOXuEAr4D6iMhhLAI4Dl74mxZ7iFSBzb1uuxVY5ZoOjsPUWe5ctJOF1/+1/1/9kC
 fICfpzYUPhITz3G/RUbbIX889M+JEj621rWMnr3eiU7cr5hWxfNpo3ucDzw+XRcFSGwr8Y//
 eGtj1uJXZoZSg1+J8/Kc/bznUiptH0QlbsqDUvFK9VeYmv2941uJ3Cjh/M7OZhUex7C2iGbx
 0CdBhJB/bvBpIo88d/og6GYrtj2T7siTxQCR2SCtOS4LyjX+Gan0LRsaufQcGCPTn7w9YWje
 f5Rk6P2PsoYkQsYqIF7Cbtqk/4zvoO9u79Aww14N3zXdFD3WKh4K3yL0MQT5K1AwrhV5Vm/V
 k6Vo4QIPLyIPIXuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB2H5HMb94EII52
 uNw6scZ5ju2hgcuLtvb3Dtf8H6BLyBYXqgq3n3A7FQHVub/Jol+XKHh
IronPort-HdrOrdr: A9a23:ZYW7HaFK53lv7OXHpLqE7seALOsnbusQ8zAXP0AYc3Jom+ij5q
 STdZMgpHjJYVcqKRQdcL+7VZVoLUmxyXcx2/h2AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp
 uIG5IOceEYZmIasS+V2maFL+o=
X-IronPort-AV: E=Sophos;i="5.88,190,1635220800"; 
   d="scan'208";a="59957912"
Date: Wed, 8 Dec 2021 16:34:54 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>, "Ian
 Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 2/2] tools: set event channel HVM parameters in
 libxenguest
Message-ID: <YbDerlN/E1wFrZKY@perard>
References: <20211208084745.31082-1-jgross@suse.com>
 <20211208084745.31082-3-jgross@suse.com>
 <83920ef7-ae82-01ad-e011-58f39a3b3e12@srcf.net>
 <ad570954-98f6-f345-d965-f664f28a6e7d@suse.com>
 <18497abb-7f3f-1479-636d-edc35b2861ad@srcf.net>
 <efaa6395-f52e-193f-dec7-fc2114e760a5@suse.com>
 <4d48cc2f-bea4-c1f4-95ec-4efa6d56b661@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4d48cc2f-bea4-c1f4-95ec-4efa6d56b661@srcf.net>

On Wed, Dec 08, 2021 at 04:02:17PM +0000, Andrew Cooper wrote:
> On 08/12/2021 15:57, Juergen Gross wrote:
> > On 08.12.21 16:54, Andrew Cooper wrote:
> >> On 08/12/2021 14:22, Juergen Gross wrote:
> >>> On 08.12.21 14:43, Andrew Cooper wrote:
> >>>> On 08/12/2021 08:47, Juergen Gross wrote:
> >>>>> The HVM parameters for pre-allocated event channels should be set in
> >>>>> libxenguest, like it is done for PV guests and for the pre-allocated
> >>>>> ring pages.
> >>>>>
> >>>>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
> >>>>
> >>>> I'm not sure that we have the concept of pre-allocated ring pages.
> >>>>
> >>>> For PV, we have:
> >>>>
> >>>> ����� dom->console_pfn = xc_dom_alloc_page(dom, "console");
> >>>> ����� if ( dom->console_pfn == INVALID_PFN )
> >>>> ��� �� �� return -1;
> >>>> ����� xc_clear_domain_page(dom->xch, dom->guest_domid,
> >>>> �������������������������� xc_dom_p2m(dom, dom->console_pfn));
> >>>>
> >>>> and for HVM, we have:
> >>>>
> >>>> ����� dom->console_pfn = special_pfn(SPECIALPAGE_CONSOLE);
> >>>> ����� xc_clear_domain_page(dom->xch, dom->guest_domid,
> >>>> dom->console_pfn);
> >>>
> >>> Isn't that a pre-allocation? The PFNs are fixed at boot time of the
> >>> guest.
> >>
> >> Yeah, but "allocated in the library call we're making" is not the same
> >> as "caller has to allocate and pass details in".
> >>
> >> I would not class the frames as "pre-allocated" in this context.
> >> "allocated" sure, so perhaps "just like it is done for PV guests, and
> >> the ring pages that libxenguest allocates" ?
> >
> > Fine with me.
> >
> > Should I send another round, or can this be changed when committing?
> 
> Fixed on commit.� No need to resend just for this.
> 
> Question is whether Anthony has any view, or whether my R-by is good enough?

Patch looks good, so:
Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:39:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:39:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242497.419398 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzyO-0002Lf-Cp; Wed, 08 Dec 2021 16:39:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242497.419398; Wed, 08 Dec 2021 16:39:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1muzyO-0002LY-98; Wed, 08 Dec 2021 16:39:16 +0000
Received: by outflank-mailman (input) for mailman id 242497;
 Wed, 08 Dec 2021 16:39:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1muzyN-0002LS-5X
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 16:39:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muzyM-0001Zf-E4; Wed, 08 Dec 2021 16:39:14 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1muzyM-00019g-8f; Wed, 08 Dec 2021 16:39:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=lq+VIYqhSHkwA+dze9flyV6dPJ3HodJ4KerB6l3QmFw=; b=WswzJ6WBsObqlnNzN1koRHW8jf
	538umxnRYBJ6zIhLZxFJ+/l20reIxw3oNvCYpJQjPttXXsRV69Thd4Y8eVb1aaZ7segD7x3qldqku
	ny/xQXS9slaIPEXU8bRIQsTBHALHQf6KZjcC56lHztGix9ZlR2WUS02KA7UUTEzu5RCA=;
Message-ID: <67af462c-34b2-861e-da52-d3ec7e110205@xen.org>
Date: Wed, 8 Dec 2021 16:39:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 6/7] xen/arm: process pending vPCI map/unmap operations
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "paul@xen.org" <paul@xen.org>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-7-andr2000@gmail.com>
 <9647b586-e325-0d3a-3369-e3b13e45af9d@gmail.com>
 <be0d06fc-f024-73c3-8b0d-59bc8791312e@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <be0d06fc-f024-73c3-8b0d-59bc8791312e@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 07/12/2021 11:57, Oleksandr Andrushchenko wrote:
> Hi, Julien!

Hi,

> On 03.12.21 18:10, Durrant, Paul wrote:
>> On 23/11/2021 23:59, Oleksandr Andrushchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> vPCI may map and unmap PCI device memory (BARs) being passed through which
>>> may take a lot of time. For this those operations may be deferred to be
>>> performed later, so that they can be safely preempted.
>>>
>>> Currently this deferred processing is happening in common IOREQ code
>>> which doesn't seem to be the right place for x86 and is even more
>>> doubtful because IOREQ may not be enabled for Arm at all.
>>> So, for Arm the pending vPCI work may have no chance to be executed
>>> if the processing is left as is in the common IOREQ code only.
>>> For that reason make vPCI processing happen in arch specific code.
>>>
>>> Please be aware that there are a few outstanding TODOs affecting this
>>> code path, see xen/drivers/vpci/header.c:map_range and
>>> xen/drivers/vpci/header.c:vpci_process_pending.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>> [x86 part]
>>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>> Reviewed-by: Julien Grall <jgrall@amazon.com>
>>
>> Reviewed-by: Paul Durrant <paul@xen.org>
>>
> Do we need anything else for this patch?

No. I have committed the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:48:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242506.419412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv078-0004Ge-91; Wed, 08 Dec 2021 16:48:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242506.419412; Wed, 08 Dec 2021 16:48:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv078-0004GX-5p; Wed, 08 Dec 2021 16:48:18 +0000
Received: by outflank-mailman (input) for mailman id 242506;
 Wed, 08 Dec 2021 16:48:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mv077-0004GR-8d
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 16:48:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv076-0001jE-9U; Wed, 08 Dec 2021 16:48:16 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv076-0001lh-2L; Wed, 08 Dec 2021 16:48:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=MUFj/aqzThJkfEnYTwDxe07529fFF6HYotU0W7JpW7o=; b=ITfa45j/f3i/mCZ+baaY++5iVu
	aQU9Pu8fctwfMJ/O3rf1LZQDbWcunTvbXsmnB5mQYrfXrfxMZeMeRiOK2TXq9Fs9nnRE8ukwyp1Fh
	g7el3o+9A/Oip5qywfywAwf8kEDjXeUgiyYt95qHzvmK7FltUS5mOvlfwr1UhdLBQKUA=;
Message-ID: <e5a2ca97-8983-9159-6776-5afdeab398a0@xen.org>
Date: Wed, 8 Dec 2021 16:48:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 3/7] xen/arm: setup MMIO range trap handlers for
 hardware domain
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-4-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-4-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> In order for vPCI to work it needs to maintain guest and hardware
> domain's views of the configuration space. For example, BARs and
> COMMAND registers require emulation for guests and the guest view
> of the registers needs to be in sync with the real contents of the
> relevant registers. For that ECAM address space needs to also be
> trapped for the hardware domain, so we need to implement PCI host
> bridge specific callbacks to properly setup MMIO handlers for those
> ranges depending on particular host bridge implementation.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> Since v6:
> - eliminate pci_host_get_num_bridges and make pci_host_iterate_bridges
>    return the count
> - extend comment in domain_vpci_init
> - remove not yet relevant code for num MMIOs and virtual bus topology
> - add extra check for has_vpci in domain_vpci_get_num_mmio_handlers
> - remove code that fixes num MMIOs for guest domain as it doesn't belong
>    to this patch
> Since v5:
> - add vpci_sbdf_from_gpa helper for gpa to SBDF translation
> - take bridge's bus start into account while calculating SBDF
> Since v4:
> - unsigned int for functions working with count
> - gate number of MMIO handlers needed for CONFIG_HAS_PCI_MSI
>    and fix their number, e.g. single handler for PBA and
>    MSI-X tables (Roger)
> - re-work code for assigning MMIO handlers to be simpler
>    and account on the fact that there could multiple host bridges
>    exist for the hwdom
> Since v3:
> - fixed comment formatting
> Since v2:
> - removed unneeded assignment (count = 0)
> - removed unneeded header inclusion
> - update commit message
> Since v1:
>   - Dynamically calculate the number of MMIO handlers required for vPCI
>     and update the total number accordingly
>   - s/clb/cb
>   - Do not introduce a new callback for MMIO handler setup
> ---
>   xen/arch/arm/domain.c              |  2 +
>   xen/arch/arm/pci/pci-host-common.c | 17 +++++++
>   xen/arch/arm/vpci.c                | 79 +++++++++++++++++++++++++++---
>   xen/arch/arm/vpci.h                |  6 +++
>   xen/include/asm-arm/pci.h          |  4 ++
>   5 files changed, 100 insertions(+), 8 deletions(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 96e1b235501d..92a6c509e5c5 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -739,6 +739,8 @@ int arch_domain_create(struct domain *d,
>       if ( (rc = domain_vgic_register(d, &count)) != 0 )
>           goto fail;
>   
> +    count += domain_vpci_get_num_mmio_handlers(d);
> +
>       if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
>           goto fail;
>   
> diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
> index 9653b92b5b2e..18b09d5e6f10 100644
> --- a/xen/arch/arm/pci/pci-host-common.c
> +++ b/xen/arch/arm/pci/pci-host-common.c
> @@ -296,6 +296,23 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
>       return -EINVAL;
>   }
>   
> +int pci_host_iterate_bridges_and_count(struct domain *d,
> +                                       int (*cb)(struct domain *d,
> +                                                 struct pci_host_bridge *bridge))
> +{
> +    struct pci_host_bridge *bridge;
> +    int err, count = 0;

NIT: err is only used within the loop, so I would suggest to move the 
declartion variable inside the loop.

> +
> +    list_for_each_entry( bridge, &pci_host_bridges, node )
> +    {
> +        err = cb(d, bridge);
> +        if ( err )
> +            return err;
> +        count += err;

Something looks wrong here. You check that err is non-zero and bail out. 
So err would be 0 and by extend you would always return 0 in success?

> +    }
> +    return count;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index 23f45386f4b3..ccd998d8dba2 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -16,16 +16,31 @@
>   
>   #include <asm/mmio.h>
>   
> +static pci_sbdf_t vpci_sbdf_from_gpa(const struct pci_host_bridge *bridge,
> +                                     paddr_t gpa)
> +{
> +    pci_sbdf_t sbdf;
> +
> +    if ( bridge )
> +    {
> +        sbdf.sbdf = VPCI_ECAM_BDF(gpa - bridge->cfg->phys_addr);
> +        sbdf.seg = bridge->segment;
> +        sbdf.bus += bridge->cfg->busn_start;
> +    }
> +    else
> +        sbdf.sbdf = VPCI_ECAM_BDF(gpa - GUEST_VPCI_ECAM_BASE);
> +
> +    return sbdf;
> +}
> +
>   static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>                             register_t *r, void *p)
>   {
> -    pci_sbdf_t sbdf;
> +    struct pci_host_bridge *bridge = p;
> +    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa);
>       /* data is needed to prevent a pointer cast on 32bit */
>       unsigned long data;
>   
> -    /* We ignore segment part and always handle segment 0 */
> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
> -
>       if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
>                           1U << info->dabt.size, &data) )
>       {
> @@ -41,10 +56,8 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
>   static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
>                              register_t r, void *p)
>   {
> -    pci_sbdf_t sbdf;
> -
> -    /* We ignore segment part and always handle segment 0 */
> -    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
> +    struct pci_host_bridge *bridge = p;
> +    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa);
>   
>       return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
>                              1U << info->dabt.size, r);
> @@ -55,17 +68,67 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
>       .write = vpci_mmio_write,
>   };
>   
> +static int vpci_setup_mmio_handler_cb(struct domain *d,
> +                                      struct pci_host_bridge *bridge)
> +{
> +    struct pci_config_window *cfg = bridge->cfg;
> +
> +    register_mmio_handler(d, &vpci_mmio_handler,
> +                          cfg->phys_addr, cfg->size, bridge);
> +
> +    /* We have registered a single MMIO handler. */
> +    return 1;
> +}
> +
>   int domain_vpci_init(struct domain *d)
>   {
>       if ( !has_vpci(d) )
>           return 0;
>   
> +    /*
> +     * The hardware domain gets as many MMIOs as required by the
> +     * physical host bridge.
> +     * Guests get the virtual platform layout: one virtual host bridge for now.
> +     */
> +    if ( is_hardware_domain(d) )
> +    {
> +        int count;
> +
> +        count = pci_host_iterate_bridges_and_count(d, vpci_setup_mmio_handler_cb);
> +        if ( count < 0 )
> +            return count;
> +
> +        return 0;

This could be simplified to "return (count < 0) ? count : 0;". Although 
my preference would be to move the guest part in an else.

> +    }
> +
>       register_mmio_handler(d, &vpci_mmio_handler,
>                             GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
>   
>       return 0;
>   }
>   
> +static int vpci_get_num_handlers_cb(struct domain *d,
> +                                    struct pci_host_bridge *bridge)
> +{
> +    /* Each bridge has a single MMIO handler for the configuration space. */
> +    return 1;
> +}
> +
> +unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        int ret = pci_host_iterate_bridges_and_count(d, vpci_get_num_handlers_cb);
> +
> +        return ret < 0 ? 0 : ret;
> +    }
> +
> +    return 0;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
> index d8a7b0e3e802..3c713f3fcdb5 100644
> --- a/xen/arch/arm/vpci.h
> +++ b/xen/arch/arm/vpci.h
> @@ -17,11 +17,17 @@
>   
>   #ifdef CONFIG_HAS_VPCI
>   int domain_vpci_init(struct domain *d);
> +unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d);
>   #else
>   static inline int domain_vpci_init(struct domain *d)
>   {
>       return 0;
>   }
> +
> +static inline unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    return 0;
> +}
>   #endif
>   
>   #endif /* __ARCH_ARM_VPCI_H__ */
> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
> index c20eba643d86..4278d66e5eb9 100644
> --- a/xen/include/asm-arm/pci.h
> +++ b/xen/include/asm-arm/pci.h
> @@ -110,6 +110,10 @@ void arch_pci_init_pdev(struct pci_dev *pdev);
>   
>   int pci_get_new_domain_nr(void);
>   
> +int pci_host_iterate_bridges_and_count(struct domain *d,
> +                                       int (*cb)(struct domain *d,
> +                                                 struct pci_host_bridge *bridge));
> +
>   #else   /*!CONFIG_HAS_PCI*/
>   
>   struct arch_pci_dev { };
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 16:53:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 16:53:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242513.419424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Bz-0005dv-Sb; Wed, 08 Dec 2021 16:53:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242513.419424; Wed, 08 Dec 2021 16:53:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Bz-0005do-OL; Wed, 08 Dec 2021 16:53:19 +0000
Received: by outflank-mailman (input) for mailman id 242513;
 Wed, 08 Dec 2021 16:53:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mv0By-0005di-NG
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 16:53:18 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0Bx-0001oY-IB; Wed, 08 Dec 2021 16:53:17 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0Bx-0004cT-Ba; Wed, 08 Dec 2021 16:53:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=O05kB8Vl7RHOAiMe94cfoJE5/NLlSmmoEh+WONy/5To=; b=PCU8f+LEf7AmShiHv4smzuTJr6
	NnHnfV8KL6ce1hO1vLoUwW+pPv41UUkBEvkAdeGQYVC0P/YBE/Qw9zvHu/jk/UJpI3iYbUj7FPtZp
	2nl8a3RNomSRdP9QjefCE73V7b1dmOiRMmsNF9IKc95QFWTIAGNOZjrXlYSoqaFzXulA=;
Message-ID: <77326c24-9d2a-22ef-00cf-b89f1e70eaaf@xen.org>
Date: Wed, 8 Dec 2021 16:53:14 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host
 bridge
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-5-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-5-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> At the moment, we always allocate an extra 16 slots for IO handlers
> (see MAX_IO_HANDLER). So while adding an IO trap handler for the emulated
> PCI host bridge we are not breaking anything, but we have a latent bug
> as the maximum number of IOs may be exceeded.
> Fix this by explicitly telling that we have an additional IO handler, so it is
> accounted.
> 
> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")

In general, it is better to have the fixes at the beginning of a series. 
So they are relying on less rework and easier to backport (if needed).

In this case, PCI passthrough is still a technical preview so it doesn't 
matter too much.

> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
 >
> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
> index ccd998d8dba2..8e801f275879 100644
> --- a/xen/arch/arm/vpci.c
> +++ b/xen/arch/arm/vpci.c
> @@ -126,7 +126,8 @@ unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
>           return ret < 0 ? 0 : ret;
>       }
>   
> -    return 0;
> +    /* For a single emulated host bridge's configuration space. */

This comment is lacking some context. I would suggest to reword to 
something like:

"For the guests, each host bridge requires one region to cover the 
configuration space. At the moment, we only expose a single host bridge.
"

With that (or a similar comment):

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:00:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242521.419446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Ik-0007lp-V6; Wed, 08 Dec 2021 17:00:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242521.419446; Wed, 08 Dec 2021 17:00:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Ik-0007li-Rn; Wed, 08 Dec 2021 17:00:18 +0000
Received: by outflank-mailman (input) for mailman id 242521;
 Wed, 08 Dec 2021 17:00:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ity+=QZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mv0Ik-0007YL-4C
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:00:18 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5174d5e4-5848-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 18:00:17 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id k37so6876994lfv.3
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 09:00:17 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b14sm302767lfs.174.2021.12.08.09.00.15
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 09:00:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5174d5e4-5848-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=81m5aay7mqcIHbcdPLJDtuGC8d74B9O4SgnireXM5ns=;
        b=hzyD77kPTFC66YBPoae4G3/pYUiXGuzXjN58wQsDPhHzfL31T8VTyzC5v0+kwmRl5P
         orm9pBoax8V/VIx9m7YbANRtMun60PNArlU5ibbnagzv4RX3b5PVL/J/tbPo/Tlwp0Oq
         Vt2Jp8Ng1T2fxl9/+NU2rVteHgdLFqli6fMX09rahqDVkA6WeCtRJu+pi2VEJn3PZ1yr
         vvk05MOWuPhayMOYkDN3UQiTHUyQOD4OsSGmLSkncfvAqo72R440ZphGsKY8GaFFkarj
         P0oY69awUd22tJ87eRorAU9mgMk4AOVBKWzd8Sg3fp3kW9ee7iFxWOKuN6tdxa5a32/N
         n7eA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=81m5aay7mqcIHbcdPLJDtuGC8d74B9O4SgnireXM5ns=;
        b=DqVxua6wAqFtxHO4SQ6k+VUOKBmR0WPdRFGKRSCVk+hFdqlssufLskK+Frr9EaSY61
         MtJe8RlHtkf59z7RJGIFw5wPmfrX4tKokIqafb/qSD4ngYw2wSqZP8M8lgNKJo27Z9FW
         6qYErfZbnXNWEjKnyfEvwyU38sFfWmBJRK/3PVTm6oeYpr59kdp2BxRvLy8PBkFYxWZQ
         XqG456+HzX/BqpUrTKio4xK1KbzmfOEyj814Wum5WUzbwyh/dG/74iWYBkryeiPHQQfa
         dY232hKjYB/mE6Lbvkcwkl4lcu/bzj6/1zTq2hEITwrvNLWNZIblEhQZ8UQ7l900Cgt0
         xjEQ==
X-Gm-Message-State: AOAM531YyfqRuZ+d0/dPLA69mKrcyhpDlUyLMasGQAK2ja24EkMuBPYV
	LVp06oGuke3SScmdj1DGkspQbeuFQF0=
X-Google-Smtp-Source: ABdhPJxfg7yYPHPLVOrdDVKMyGznmP3ycTTFsYf7nAmX+EfDot50U/ibX44L6Sy2BUcFIswNA8UlOw==
X-Received: by 2002:ac2:4e61:: with SMTP id y1mr616845lfs.459.1638982816400;
        Wed, 08 Dec 2021 09:00:16 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien.grall@arm.com>,
	Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: [PATCH V6 2/2] libxl: Introduce basic virtio-mmio support on Arm
Date: Wed,  8 Dec 2021 18:59:44 +0200
Message-Id: <1638982784-14390-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Julien Grall <julien.grall@arm.com>

This patch introduces helpers to allocate Virtio MMIO params
(IRQ and memory region) and create specific device node in
the Guest device-tree with allocated params. In order to deal
with multiple Virtio devices, reserve corresponding ranges.
For now, we reserve 1MB for memory regions and 10 SPIs.

As these helpers should be used for every Virtio device attached
to the Guest, call them for Virtio disk(s).

Please note, with statically allocated Virtio IRQs there is
a risk of a clash with a physical IRQs of passthrough devices.
For the first version, it's fine, but we should consider allocating
the Virtio IRQs automatically. Thankfully, we know in advance which
IRQs will be used for passthrough to be able to choose non-clashed
ones.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Please note, this is a split/cleanup/hardening of Julien's PoC:
"Add support for Guest IO forwarding to a device emulator"

Changes RFC -> V1:
   - was squashed with:
     "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way"
     "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node"
     "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT"
   - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h

Changes V1 -> V2:
   - update the author of a patch

Changes V2 -> V3:
   - no changes

Changes V3 -> V4:
   - no changes

Changes V4 -> V5:
   - split the changes, change the order of the patches
   - drop an extra "virtio" configuration option
   - update patch description
   - use CONTAINER_OF instead of own implementation
   - reserve ranges for Virtio MMIO params and put them
     in correct location
   - create helpers to allocate Virtio MMIO params, add
     corresponding sanity-сhecks
   - add comment why MMIO size 0x200 is chosen
   - update debug print
   - drop Wei's T-b

Changes V5 -> V6:
   - rebase on current staging
---
 tools/libs/light/libxl_arm.c  | 131 +++++++++++++++++++++++++++++++++++++++++-
 xen/include/public/arch-arm.h |   7 +++
 2 files changed, 136 insertions(+), 2 deletions(-)

diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0..d475249 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -8,6 +8,56 @@
 #include <assert.h>
 #include <xen/device_tree_defs.h>
 
+/*
+ * There is no clear requirements for the total size of Virtio MMIO region.
+ * The size of control registers is 0x100 and device-specific configuration
+ * registers starts at the offset 0x100, however it's size depends on the device
+ * and the driver. Pick the biggest known size at the moment to cover most
+ * of the devices (also consider allowing the user to configure the size via
+ * config file for the one not conforming with the proposed value).
+ */
+#define VIRTIO_MMIO_DEV_SIZE   xen_mk_ullong(0x200)
+
+static uint64_t virtio_mmio_base;
+static uint32_t virtio_mmio_irq;
+
+static void init_virtio_mmio_params(void)
+{
+    virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE;
+    virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST;
+}
+
+static uint64_t alloc_virtio_mmio_base(libxl__gc *gc)
+{
+    uint64_t base = virtio_mmio_base;
+
+    /* Make sure we have enough reserved resources */
+    if ((virtio_mmio_base + VIRTIO_MMIO_DEV_SIZE >
+        GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE)) {
+        LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n",
+            virtio_mmio_base);
+        return 0;
+    }
+    virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE;
+
+    return base;
+}
+
+static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc)
+{
+    uint32_t irq = virtio_mmio_irq;
+
+    /* Make sure we have enough reserved resources */
+    if (virtio_mmio_irq > GUEST_VIRTIO_MMIO_SPI_LAST) {
+        LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n",
+            virtio_mmio_irq);
+        return 0;
+    }
+    virtio_mmio_irq++;
+
+    return irq;
+}
+
 static const char *gicv_to_string(libxl_gic_version gic_version)
 {
     switch (gic_version) {
@@ -26,8 +76,8 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
 {
     uint32_t nr_spis = 0;
     unsigned int i;
-    uint32_t vuart_irq;
-    bool vuart_enabled = false;
+    uint32_t vuart_irq, virtio_irq = 0;
+    bool vuart_enabled = false, virtio_enabled = false;
 
     /*
      * If pl011 vuart is enabled then increment the nr_spis to allow allocation
@@ -39,6 +89,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         vuart_enabled = true;
     }
 
+    /*
+     * Virtio MMIO params are non-unique across the whole system and must be
+     * initialized for every new guest.
+     */
+    init_virtio_mmio_params();
+    for (i = 0; i < d_config->num_disks; i++) {
+        libxl_device_disk *disk = &d_config->disks[i];
+
+        if (disk->virtio) {
+            disk->base = alloc_virtio_mmio_base(gc);
+            if (!disk->base)
+                return ERROR_FAIL;
+
+            disk->irq = alloc_virtio_mmio_irq(gc);
+            if (!disk->irq)
+                return ERROR_FAIL;
+
+            if (virtio_irq < disk->irq)
+                virtio_irq = disk->irq;
+            virtio_enabled = true;
+
+            LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64,
+                disk->vdev, disk->irq, disk->base);
+        }
+    }
+
+    if (virtio_enabled)
+        nr_spis += (virtio_irq - 32) + 1;
+
     for (i = 0; i < d_config->b_info.num_irqs; i++) {
         uint32_t irq = d_config->b_info.irqs[i];
         uint32_t spi;
@@ -58,6 +137,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
             return ERROR_FAIL;
         }
 
+        /* The same check as for vpl011 */
+        if (virtio_enabled &&
+           (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) {
+            LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq);
+            return ERROR_FAIL;
+        }
+
         if (irq < 32)
             continue;
 
@@ -787,6 +873,39 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
     return 0;
 }
 
+
+static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
+                                 uint64_t base, uint32_t irq)
+{
+    int res;
+    gic_interrupt intr;
+    /* Placeholder for virtio@ + a 64-bit number + \0 */
+    char buf[24];
+
+    snprintf(buf, sizeof(buf), "virtio@%"PRIx64, base);
+    res = fdt_begin_node(fdt, buf);
+    if (res) return res;
+
+    res = fdt_property_compat(gc, fdt, 1, "virtio,mmio");
+    if (res) return res;
+
+    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                            1, base, VIRTIO_MMIO_DEV_SIZE);
+    if (res) return res;
+
+    set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING);
+    res = fdt_property_interrupts(gc, fdt, &intr, 1);
+    if (res) return res;
+
+    res = fdt_property(fdt, "dma-coherent", NULL, 0);
+    if (res) return res;
+
+    res = fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 static const struct arch_info *get_arch_info(libxl__gc *gc,
                                              const struct xc_dom_image *dom)
 {
@@ -988,6 +1107,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config,
     size_t fdt_size = 0;
     int pfdt_size = 0;
     libxl_domain_build_info *const info = &d_config->b_info;
+    unsigned int i;
 
     const libxl_version_info *vers;
     const struct arch_info *ainfo;
@@ -1094,6 +1214,13 @@ next_resize:
         if (d_config->num_pcidevs)
             FDT( make_vpci_node(gc, fdt, ainfo, dom) );
 
+        for (i = 0; i < d_config->num_disks; i++) {
+            libxl_device_disk *disk = &d_config->disks[i];
+
+            if (disk->virtio)
+                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
+        }
+
         if (pfdt)
             FDT( copy_partial_fdt(gc, fdt, pfdt) );
 
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 94b3151..6dc55df 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -398,6 +398,10 @@ typedef uint64_t xen_callback_t;
 
 /* Physical Address Space */
 
+/* Virtio MMIO mappings */
+#define GUEST_VIRTIO_MMIO_BASE   xen_mk_ullong(0x02000000)
+#define GUEST_VIRTIO_MMIO_SIZE   xen_mk_ullong(0x00100000)
+
 /*
  * vGIC mappings: Only one set of mapping is used by the guest.
  * Therefore they can overlap.
@@ -484,6 +488,9 @@ typedef uint64_t xen_callback_t;
 
 #define GUEST_VPL011_SPI        32
 
+#define GUEST_VIRTIO_MMIO_SPI_FIRST   33
+#define GUEST_VIRTIO_MMIO_SPI_LAST    43
+
 /* PSCI functions */
 #define PSCI_cpu_suspend 0
 #define PSCI_cpu_off     1
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:00:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242522.419457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Io-000847-7X; Wed, 08 Dec 2021 17:00:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242522.419457; Wed, 08 Dec 2021 17:00:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Io-00083s-3d; Wed, 08 Dec 2021 17:00:22 +0000
Received: by outflank-mailman (input) for mailman id 242522;
 Wed, 08 Dec 2021 17:00:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ity+=QZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mv0Im-0007VY-Hn
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:00:21 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5207b0ee-5848-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 18:00:17 +0100 (CET)
Received: by mail-lf1-x12f.google.com with SMTP id t26so6794972lfk.9
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 09:00:17 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b14sm302767lfs.174.2021.12.08.09.00.14
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 09:00:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5207b0ee-5848-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=79MtWotutbGs5yFxW4veFXfVXZZ+l6UR/46H9CMj8rY=;
        b=cotOZQzr87GUQ2gUMD+QRdB5toVLVrY3YUjs0QEkrwzynP7Hovjvnf11oL2ncku7te
         kHNvf3w3RdbgeLYpAf/mFesQFEvcnZiQ8QL9iXpckNbsjwIzfdIEwWUcz9mr5jn0kw2S
         2Or87hL3aGeFPN7oY9YIcnGFp8zb0e8i5zKgzQKpiibhA5CtHmBHzHpALN3OuliW7cnB
         mfO1STi6I0FQ8pcJ7JqHy4E1GetvThR58MR6zB+prIeJ0t3cmFXKpj95zPeBkKr3BWYe
         5fAPGyE4YDQdZoa9ARf/1B4oamS8nkJ6WxIoh2xVzYClxvugUggH5U3faNvGDTgg5Al1
         hu+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=79MtWotutbGs5yFxW4veFXfVXZZ+l6UR/46H9CMj8rY=;
        b=puU2ryMJnpT7aOND4SZ+nuRquByKAB9GIvnJfwCjD0EzG64h1GUg0T6lUS6sPXUhG0
         76GWRCPcngNoLvzwibZmvfZuWM6HqmlE1u2ds/f7UxOJSpjT3AUC5LoEqe+cPCSb1qVY
         dmM0Ipl8tEgEdqkAdTL4F/amnxMRtL2P7ynkVN605WnKWzD7cDnj26CSzRdfEJwoKtB+
         1TBe1gYJADWOup0Q152y3tQK1d+23PFB69KcVdjoaLGgsWqtXc5gJg7aXrPIK3Ma4L0E
         96rV+s4vAN9upOF12U9AdDfk73cF6lDcv4ZwFuhSGvPk02nqKyhIoh4ptNHX4xDU+W0E
         CPAw==
X-Gm-Message-State: AOAM530jW7lXzavCwCnRzGWb9wg5+zahTgr50EtekXyWy9V+6iqp6VC3
	kqVstgfXYjmFTMT7QDsq+G+BxaNTzFU=
X-Google-Smtp-Source: ABdhPJxDatrSspoeJz/KIMgOT7XxyBGqNuf2hlsINqrEmHQj4zg7F+ICePRtoG4IWtn/EruPEfXrzw==
X-Received: by 2002:a05:6512:398b:: with SMTP id j11mr633715lfu.170.1638982815484;
        Wed, 08 Dec 2021 09:00:15 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Date: Wed,  8 Dec 2021 18:59:43 +0200
Message-Id: <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch adds basic support for configuring and assisting virtio-disk
backend (emualator) which is intended to run out of Qemu and could be
run in any domain.
Although the Virtio block device is quite different from traditional
Xen PV block device (vbd) from the toolstack point of view:
 - as the frontend is virtio-blk which is not a Xenbus driver, nothing
   written to Xenstore are fetched by the frontend (the vdev is not
   passed to the frontend)
 - the ring-ref/event-channel are not used for the backend<->frontend
   communication, the proposed IPC for Virtio is IOREQ/DM
it is still a "block device" and ought to be integrated in existing
"disk" handling. So, re-use (and adapt) "disk" parsing/configuration
logic to deal with Virtio devices as well.

Besides introducing new disk backend type (LIBXL_DISK_BACKEND_VIRTIO)
introduce new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model.

In order to inform the toolstack that Virtio disk needs to be used
extend "disk" configuration by introducing new "virtio" flag.
An example of domain configuration:
disk = [ 'backend=DomD, phy:/dev/mmcblk1p3, xvda1, rw, virtio' ]

Please note, this patch is not enough for virtio-disk to work
on Xen (Arm), as for every Virtio device (including disk) we need
to allocate Virtio MMIO params (IRQ and memory region) and pass
them to the backend, also update Guest device-tree. The subsequent
patch will add these missing bits. For the current patch,
the default "irq" and "base" are just written to the Xenstore.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

---
Changes RFC -> V1:
   - no changes

Changes V1 -> V2:
   - rebase according to the new location of libxl_virtio_disk.c

Changes V2 -> V3:
   - no changes

Changes V3 -> V4:
   - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT

Changes V4 -> V5:
   - split the changes, change the order of the patches
   - update patch description
   - don't introduce new "vdisk" configuration option with own parsing logic,
     re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk
   - introduce "virtio" flag and document it's usage
   - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
   - update libxlu_disk_l.[ch]
   - drop num_disks variable/MAX_VIRTIO_DISKS
   - drop Wei's T-b

Changes V5 -> V6:
   - rebase on current staging
   - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
   - update *.gen.go files
---
 docs/man/xl-disk-configuration.5.pod.in   |  27 +
 tools/golang/xenlight/helpers.gen.go      |   6 +
 tools/golang/xenlight/types.gen.go        |   4 +
 tools/include/libxl.h                     |   6 +
 tools/libs/light/libxl_device.c           |  38 +-
 tools/libs/light/libxl_disk.c             |  99 +++-
 tools/libs/light/libxl_types.idl          |   4 +
 tools/libs/light/libxl_types_internal.idl |   1 +
 tools/libs/light/libxl_utils.c            |   2 +
 tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------------
 tools/libs/util/libxlu_disk_l.h           |   2 +-
 tools/libs/util/libxlu_disk_l.l           |   1 +
 tools/xl/xl_block.c                       |  11 +
 13 files changed, 636 insertions(+), 446 deletions(-)

diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in
index 71d0e86..9cc189f 100644
--- a/docs/man/xl-disk-configuration.5.pod.in
+++ b/docs/man/xl-disk-configuration.5.pod.in
@@ -344,8 +344,35 @@ can be used to disable "hole punching" for file based backends which
 were intentionally created non-sparse to avoid fragmentation of the
 file.
 
+=item B<virtio>
+
+=over 4
+
+=item Description
+
+Enables experimental Virtio support for disk
+
+=item Supported values
+
+absent, present
+
+=item Mandatory
+
+No
+
+=item Default value
+
+absent
+
 =back
 
+Besides forcing toolstack to use specific Xen Virtio backend implementation
+(for example, virtio-disk), this also affects the guest's view of the device
+and requires virtio-blk driver to be used.
+Please note, the virtual device (vdev) is not passed to the guest in that case,
+but it still must be specified for the internal purposes.
+
+=back
 
 =head1 COLO Parameters
 
diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go
index b746ff1..787e3ba 100644
--- a/tools/golang/xenlight/helpers.gen.go
+++ b/tools/golang/xenlight/helpers.gen.go
@@ -1751,6 +1751,9 @@ x.DirectIoSafe = bool(xc.direct_io_safe)
 if err := x.DiscardEnable.fromC(&xc.discard_enable);err != nil {
 return fmt.Errorf("converting field DiscardEnable: %v", err)
 }
+x.Virtio = bool(xc.virtio)
+x.Irq = uint32(xc.irq)
+x.Base = uint64(xc.base)
 if err := x.ColoEnable.fromC(&xc.colo_enable);err != nil {
 return fmt.Errorf("converting field ColoEnable: %v", err)
 }
@@ -1788,6 +1791,9 @@ xc.direct_io_safe = C.bool(x.DirectIoSafe)
 if err := x.DiscardEnable.toC(&xc.discard_enable); err != nil {
 return fmt.Errorf("converting field DiscardEnable: %v", err)
 }
+xc.virtio = C.bool(x.Virtio)
+xc.irq = C.uint32_t(x.Irq)
+xc.base = C.uint64_t(x.Base)
 if err := x.ColoEnable.toC(&xc.colo_enable); err != nil {
 return fmt.Errorf("converting field ColoEnable: %v", err)
 }
diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go
index b1e84d5..1d6868a 100644
--- a/tools/golang/xenlight/types.gen.go
+++ b/tools/golang/xenlight/types.gen.go
@@ -99,6 +99,7 @@ DiskBackendUnknown DiskBackend = 0
 DiskBackendPhy DiskBackend = 1
 DiskBackendTap DiskBackend = 2
 DiskBackendQdisk DiskBackend = 3
+DiskBackendVirtio DiskBackend = 4
 )
 
 type NicType int
@@ -643,6 +644,9 @@ Readwrite int
 IsCdrom int
 DirectIoSafe bool
 DiscardEnable Defbool
+Virtio bool
+Irq uint32
+Base uint64
 ColoEnable Defbool
 ColoRestoreEnable Defbool
 ColoHost string
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21..1ea7475 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -528,6 +528,12 @@
 #define LIBXL_HAVE_MAX_GRANT_VERSION 1
 
 /*
+ * LIBXL_HAVE_DEVICE_DISK_VIRTIO indicates that a 'virtio' field
+ * (of boolean type) is present in libxl_device_disk.
+ */
+#define LIBXL_HAVE_DEVICE_DISK_VIRTIO 1
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c
index 36c4e41..7c8cb53 100644
--- a/tools/libs/light/libxl_device.c
+++ b/tools/libs/light/libxl_device.c
@@ -292,6 +292,9 @@ static int disk_try_backend(disk_try_backend_args *a,
     /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or
      * backend on success */
 
+    if (a->disk->virtio && backend != LIBXL_DISK_BACKEND_VIRTIO)
+        goto bad_virtio;
+
     switch (backend) {
     case LIBXL_DISK_BACKEND_PHY:
         if (a->disk->format != LIBXL_DISK_FORMAT_RAW) {
@@ -329,6 +332,29 @@ static int disk_try_backend(disk_try_backend_args *a,
         if (a->disk->script) goto bad_script;
         return backend;
 
+    case LIBXL_DISK_BACKEND_VIRTIO:
+        if (a->disk->format != LIBXL_DISK_FORMAT_RAW)
+            goto bad_format;
+
+        if (a->disk->script)
+            goto bad_script;
+
+        if (libxl_defbool_val(a->disk->colo_enable))
+            goto bad_colo;
+
+        if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) {
+            LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, "
+                       "skipping physical device check", a->disk->vdev);
+            return backend;
+        }
+
+        if (libxl__try_phy_backend(a->stab.st_mode))
+            return backend;
+
+        LOG(DEBUG, "Disk vdev=%s, backend virtio unsuitable as phys path not a "
+                   "block device", a->disk->vdev);
+        return 0;
+
     default:
         LOG(DEBUG, "Disk vdev=%s, backend %d unknown", a->disk->vdev, backend);
         return 0;
@@ -352,6 +378,11 @@ static int disk_try_backend(disk_try_backend_args *a,
     LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with colo",
         a->disk->vdev, libxl_disk_backend_to_string(backend));
     return 0;
+
+ bad_virtio:
+    LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with virtio",
+        a->disk->vdev, libxl_disk_backend_to_string(backend));
+    return 0;
 }
 
 int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path,
@@ -392,7 +423,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
         }
         memset(&a.stab, 0, sizeof(a.stab));
     } else if ((disk->backend == LIBXL_DISK_BACKEND_UNKNOWN ||
-                disk->backend == LIBXL_DISK_BACKEND_PHY) &&
+                disk->backend == LIBXL_DISK_BACKEND_PHY ||
+                disk->backend == LIBXL_DISK_BACKEND_VIRTIO) &&
                disk->backend_domid == LIBXL_TOOLSTACK_DOMID &&
                !disk->script) {
         if (stat(disk->pdev_path, &a.stab)) {
@@ -408,7 +440,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) {
         ok=
             disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?:
             disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?:
-            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP);
+            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?:
+            disk_try_backend(&a, LIBXL_DISK_BACKEND_VIRTIO);
         if (ok)
             LOG(DEBUG, "Disk vdev=%s, using backend %s",
                        disk->vdev,
@@ -441,6 +474,7 @@ char *libxl__device_disk_string_of_backend(libxl_disk_backend backend)
         case LIBXL_DISK_BACKEND_QDISK: return "qdisk";
         case LIBXL_DISK_BACKEND_TAP: return "phy";
         case LIBXL_DISK_BACKEND_PHY: return "phy";
+        case LIBXL_DISK_BACKEND_VIRTIO: return "virtio_disk";
         default: return NULL;
     }
 }
diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c
index 93936d0..912b3f5 100644
--- a/tools/libs/light/libxl_disk.c
+++ b/tools/libs/light/libxl_disk.c
@@ -174,6 +174,16 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid,
         disk->backend = LIBXL_DISK_BACKEND_QDISK;
     }
 
+    /* Force virtio_disk backend for Virtio devices */
+    if (disk->virtio) {
+        if (!(disk->backend == LIBXL_DISK_BACKEND_VIRTIO ||
+              disk->backend == LIBXL_DISK_BACKEND_UNKNOWN)) {
+            LOGD(ERROR, domid, "Backend for Virtio devices on must be virtio_disk");
+            return ERROR_FAIL;
+        }
+        disk->backend = LIBXL_DISK_BACKEND_VIRTIO;
+    }
+
     rc = libxl__device_disk_set_backend(gc, disk);
     return rc;
 }
@@ -204,6 +214,9 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid,
         case LIBXL_DISK_BACKEND_QDISK:
             device->backend_kind = LIBXL__DEVICE_KIND_QDISK;
             break;
+        case LIBXL_DISK_BACKEND_VIRTIO:
+            device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO_DISK;
+            break;
         default:
             LOGD(ERROR, domid, "Unrecognized disk backend type: %d",
                  disk->backend);
@@ -212,7 +225,8 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid,
 
     device->domid = domid;
     device->devid = devid;
-    device->kind  = LIBXL__DEVICE_KIND_VBD;
+    device->kind = disk->backend == LIBXL_DISK_BACKEND_VIRTIO ?
+        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
 
     return 0;
 }
@@ -330,7 +344,17 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid,
 
                 assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD);
                 break;
+            case LIBXL_DISK_BACKEND_VIRTIO:
+                dev = disk->pdev_path;
+
+                flexarray_append(back, "params");
+                flexarray_append(back, dev);
 
+                flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base));
+                flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq));
+
+                assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK);
+                break;
             case LIBXL_DISK_BACKEND_TAP:
                 LOG(ERROR, "blktap is not supported");
                 rc = ERROR_FAIL;
@@ -532,6 +556,26 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path,
     }
     libxl_string_to_backend(ctx, tmp, &(disk->backend));
 
+    if (disk->backend == LIBXL_DISK_BACKEND_VIRTIO) {
+        disk->virtio = true;
+
+        tmp = libxl__xs_read(gc, XBT_NULL,
+                             GCSPRINTF("%s/base", libxl_path));
+        if (!tmp) {
+            LOG(ERROR, "Missing xenstore node %s/base", libxl_path);
+            goto cleanup;
+        }
+        disk->base = strtoul(tmp, NULL, 10);
+
+        tmp = libxl__xs_read(gc, XBT_NULL,
+                             GCSPRINTF("%s/irq", libxl_path));
+        if (!tmp) {
+            LOG(ERROR, "Missing xenstore node %s/irq", libxl_path);
+            goto cleanup;
+        }
+        disk->irq = strtoul(tmp, NULL, 10);
+    }
+
     disk->vdev = xs_read(ctx->xsh, XBT_NULL,
                          GCSPRINTF("%s/dev", libxl_path), &len);
     if (!disk->vdev) {
@@ -575,6 +619,41 @@ cleanup:
     return rc;
 }
 
+static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid,
+                                      char **path)
+{
+    const char *dir;
+    int rc;
+
+    /*
+     * As we don't know exactly what device kind to be used here, guess it
+     * by checking the presence of the corresponding path in Xenstore.
+     * First, try to read path for vbd device (default) and if not exists
+     * read path for virtio_disk device. This will work as long as both Xen PV
+     * and Virtio disk devices are not assigned to the same guest.
+     */
+    *path = GCSPRINTF("%s/device/%s",
+                      libxl__xs_libxl_path(gc, domid),
+                      libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD));
+
+    rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
+    if (rc)
+        return rc;
+
+    if (dir)
+        return 0;
+
+    *path = GCSPRINTF("%s/device/%s",
+                      libxl__xs_libxl_path(gc, domid),
+                      libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK));
+
+    rc = libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
+    if (rc)
+        return rc;
+
+    return 0;
+}
+
 int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
                               const char *vdev, libxl_device_disk *disk)
 {
@@ -588,10 +667,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
 
     libxl_device_disk_init(disk);
 
-    libxl_path = libxl__domain_device_libxl_path(gc, domid, devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+    rc = libxl_device_disk_get_path(gc, domid, &libxl_path);
+    if (rc)
+        return rc;
 
-    rc = libxl__disk_from_xenstore(gc, libxl_path, devid, disk);
+    rc = libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, devid),
+                                   devid, disk);
 
     GC_FREE;
     return rc;
@@ -605,16 +686,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid,
     char *fe_path, *libxl_path;
     char *val;
     int rc;
+    libxl__device_kind kind;
 
     diskinfo->backend = NULL;
 
     diskinfo->devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL);
 
-    /* tap devices entries in xenstore are written as vbd devices. */
+    /* tap devices entries in xenstore are written as vbd/virtio_disk devices. */
+    kind = disk->backend == LIBXL_DISK_BACKEND_VIRTIO ?
+        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
     fe_path = libxl__domain_device_frontend_path(gc, domid, diskinfo->devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+                                                 kind);
     libxl_path = libxl__domain_device_libxl_path(gc, domid, diskinfo->devid,
-                                                 LIBXL__DEVICE_KIND_VBD);
+                                                 kind);
     diskinfo->backend = xs_read(ctx->xsh, XBT_NULL,
                                 GCSPRINTF("%s/backend", libxl_path), NULL);
     if (!diskinfo->backend) {
@@ -1418,6 +1502,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk)
 #define libxl__device_disk_update_devid NULL
 
 DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks,
+    .get_path    = libxl_device_disk_get_path,
     .merge       = libxl_device_disk_merge,
     .dm_needed   = libxl_device_disk_dm_needed,
     .from_xenstore = (device_from_xenstore_fn_t)libxl__disk_from_xenstore,
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
index 2a42da2..31e4a15 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -130,6 +130,7 @@ libxl_disk_backend = Enumeration("disk_backend", [
     (1, "PHY"),
     (2, "TAP"),
     (3, "QDISK"),
+    (4, "VIRTIO"),
     ])
 
 libxl_nic_type = Enumeration("nic_type", [
@@ -704,6 +705,9 @@ libxl_device_disk = Struct("device_disk", [
     ("is_cdrom", integer),
     ("direct_io_safe", bool),
     ("discard_enable", libxl_defbool),
+    ("virtio", bool),
+    ("irq", uint32),
+    ("base", uint64),
     # Note that the COLO configuration settings should be considered unstable.
     # They may change incompatibly in future versions of Xen.
     ("colo_enable", libxl_defbool),
diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl
index 3593e21..8f71980 100644
--- a/tools/libs/light/libxl_types_internal.idl
+++ b/tools/libs/light/libxl_types_internal.idl
@@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [
     (14, "PVCALLS"),
     (15, "VSND"),
     (16, "VINPUT"),
+    (17, "VIRTIO_DISK"),
     ])
 
 libxl__console_backend = Enumeration("console_backend", [
diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c
index 4699c4a..fa406de 100644
--- a/tools/libs/light/libxl_utils.c
+++ b/tools/libs/light/libxl_utils.c
@@ -304,6 +304,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, libxl_disk_backend *backend
         *backend = LIBXL_DISK_BACKEND_TAP;
     } else if (!strcmp(s, "qdisk")) {
         *backend = LIBXL_DISK_BACKEND_QDISK;
+    } else if (!strcmp(s, "virtio_disk")) {
+        *backend = LIBXL_DISK_BACKEND_VIRTIO;
     } else if (!strcmp(s, "tap")) {
         p = strchr(s, ':');
         if (!p) {
diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c
index 32d4b74..7abc699 100644
--- a/tools/libs/util/libxlu_disk_l.c
+++ b/tools/libs/util/libxlu_disk_l.c
@@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner );
 	yyg->yy_hold_char = *yy_cp; \
 	*yy_cp = '\0'; \
 	yyg->yy_c_buf_p = yy_cp;
-#define YY_NUM_RULES 36
-#define YY_END_OF_BUFFER 37
+#define YY_NUM_RULES 37
+#define YY_END_OF_BUFFER 38
 /* This struct is not used in this scanner,
    but its presence is necessary. */
 struct yy_trans_info
@@ -558,74 +558,75 @@ struct yy_trans_info
 	flex_int32_t yy_verify;
 	flex_int32_t yy_nxt;
 	};
-static const flex_int16_t yy_acclist[575] =
+static const flex_int16_t yy_acclist[583] =
     {   0,
-       35,   35,   37,   33,   34,   36, 8193,   33,   34,   36,
-    16385, 8193,   33,   36,16385,   33,   34,   36,   34,   36,
-       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
-       34,   36,   33,   34,   36,   33,   34,   36,   33,   34,
-       36,   33,   34,   36,   33,   34,   36,   33,   34,   36,
-       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
-       34,   36,   33,   34,   36,   33,   34,   36,   35,   36,
-       36,   33,   33, 8193,   33, 8193,   33,16385, 8193,   33,
-     8193,   33,   33, 8224,   33,16416,   33,   33,   33,   33,
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   35,
-     8193,   33, 8193,   33, 8193, 8224,   33, 8224,   33, 8224,
-       23,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
-       33,   33,   33,   33,   33, 8224,   33, 8224,   33, 8224,
-       23,   33,   33,   28, 8224,   33,16416,   33,   33,   15,
-       33,   33,   33,   33,   33,   33,   33,   33,   33, 8217,
-     8224,   33,16409,16416,   33,   33,   31, 8224,   33,16416,
-       33, 8216, 8224,   33,16408,16416,   33,   33, 8219, 8224,
-       33,16411,16416,   33,   33,   33,   33,   33,   28, 8224,
-
-       33,   28, 8224,   33,   28,   33,   28, 8224,   33,    3,
-       33,   15,   33,   33,   33,   33,   33,   30, 8224,   33,
-    16416,   33,   33,   33, 8217, 8224,   33, 8217, 8224,   33,
-     8217,   33, 8217, 8224,   33,   33,   31, 8224,   33,   31,
-     8224,   33,   31,   33,   31, 8224, 8216, 8224,   33, 8216,
-     8224,   33, 8216,   33, 8216, 8224,   33, 8219, 8224,   33,
-     8219, 8224,   33, 8219,   33, 8219, 8224,   33,   33,   10,
-       33,   33,   28, 8224,   33,   28, 8224,   33,   28, 8224,
-       28,   33,   28,   33,    3,   33,   33,   33,   33,   33,
-       33,   33,   30, 8224,   33,   30, 8224,   33,   30,   33,
-
-       30, 8224,   33,   33,   29, 8224,   33,16416, 8217, 8224,
-       33, 8217, 8224,   33, 8217, 8224, 8217,   33, 8217,   33,
-       33,   31, 8224,   33,   31, 8224,   33,   31, 8224,   31,
-       33,   31, 8216, 8224,   33, 8216, 8224,   33, 8216, 8224,
-     8216,   33, 8216,   33, 8219, 8224,   33, 8219, 8224,   33,
-     8219, 8224, 8219,   33, 8219,   33,   33,   10,   23,   10,
-        7,   33,   33,   33,   33,   33,   33,   33,   13,   33,
-       30, 8224,   33,   30, 8224,   33,   30, 8224,   30,   33,
-       30,    2,   33,   29, 8224,   33,   29, 8224,   33,   29,
-       33,   29, 8224,   16,   33,   33,   11,   33,   22,   10,
-
-       10,   23,    7,   23,    7,   33,    8,   33,   33,   33,
-       33,    6,   33,   13,   33,    2,   23,    2,   33,   29,
-     8224,   33,   29, 8224,   33,   29, 8224,   29,   33,   29,
-       16,   33,   33,   11,   23,   11,   26, 8224,   33,16416,
-       22,   23,   22,    7,    7,   23,   33,    8,   23,    8,
-       33,   33,   33,   33,    6,   23,    6,    6,   23,    6,
-       23,   33,    2,    2,   23,   33,   33,   11,   11,   23,
-       26, 8224,   33,   26, 8224,   33,   26,   33,   26, 8224,
-       22,   23,   33,    8,    8,   23,   33,   33,   17,   18,
-        6,    6,   23,    6,    6,   33,   33,   14,   33,   26,
-
-     8224,   33,   26, 8224,   33,   26, 8224,   26,   33,   26,
-       33,   33,   33,   17,   23,   17,   18,   23,   18,    6,
-        6,   33,   33,   14,   33,   20,    9,   19,   17,   17,
-       23,   18,   18,   23,    6,    5,    6,   33,   21,   20,
-       23,   20,    9,   23,    9,   19,   23,   19,    4,    6,
-        5,    6,   33,   21,   23,   21,   20,   20,   23,    9,
-        9,   23,   19,   19,   23,    4,    6,   12,   33,   21,
-       21,   23,   12,   33
+       36,   36,   38,   34,   35,   37, 8193,   34,   35,   37,
+    16385, 8193,   34,   37,16385,   34,   35,   37,   35,   37,
+       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
+       35,   37,   34,   35,   37,   34,   35,   37,   34,   35,
+       37,   34,   35,   37,   34,   35,   37,   34,   35,   37,
+       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
+       35,   37,   34,   35,   37,   34,   35,   37,   36,   37,
+       37,   34,   34, 8193,   34, 8193,   34,16385, 8193,   34,
+     8193,   34,   34, 8225,   34,16417,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+       36, 8193,   34, 8193,   34, 8193, 8225,   34, 8225,   34,
+     8225,   24,   34,   34,   34,   34,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
+       34,   34,   34,   34,   34,   34,   34, 8225,   34, 8225,
+       34, 8225,   24,   34,   34,   29, 8225,   34,16417,   34,
+       34,   16,   34,   34,   34,   34,   34,   34,   34,   34,
+       34, 8218, 8225,   34,16410,16417,   34,   34,   32, 8225,
+       34,16417,   34, 8217, 8225,   34,16409,16417,   34,   34,
+     8220, 8225,   34,16412,16417,   34,   34,   34,   34,   34,
+
+       34,   29, 8225,   34,   29, 8225,   34,   29,   34,   29,
+     8225,   34,    3,   34,   16,   34,   34,   34,   34,   34,
+       31, 8225,   34,16417,   34,   34,   34, 8218, 8225,   34,
+     8218, 8225,   34, 8218,   34, 8218, 8225,   34,   34,   32,
+     8225,   34,   32, 8225,   34,   32,   34,   32, 8225, 8217,
+     8225,   34, 8217, 8225,   34, 8217,   34, 8217, 8225,   34,
+     8220, 8225,   34, 8220, 8225,   34, 8220,   34, 8220, 8225,
+       34,   34,   10,   34,   34,   34,   29, 8225,   34,   29,
+     8225,   34,   29, 8225,   29,   34,   29,   34,    3,   34,
+       34,   34,   34,   34,   34,   34,   31, 8225,   34,   31,
+
+     8225,   34,   31,   34,   31, 8225,   34,   34,   30, 8225,
+       34,16417, 8218, 8225,   34, 8218, 8225,   34, 8218, 8225,
+     8218,   34, 8218,   34,   34,   32, 8225,   34,   32, 8225,
+       34,   32, 8225,   32,   34,   32, 8217, 8225,   34, 8217,
+     8225,   34, 8217, 8225, 8217,   34, 8217,   34, 8220, 8225,
+       34, 8220, 8225,   34, 8220, 8225, 8220,   34, 8220,   34,
+       34,   10,   24,   10,   15,   34,    7,   34,   34,   34,
+       34,   34,   34,   34,   13,   34,   31, 8225,   34,   31,
+     8225,   34,   31, 8225,   31,   34,   31,    2,   34,   30,
+     8225,   34,   30, 8225,   34,   30,   34,   30, 8225,   17,
+
+       34,   34,   11,   34,   23,   10,   10,   24,   15,   34,
+        7,   24,    7,   34,    8,   34,   34,   34,   34,    6,
+       34,   13,   34,    2,   24,    2,   34,   30, 8225,   34,
+       30, 8225,   34,   30, 8225,   30,   34,   30,   17,   34,
+       34,   11,   24,   11,   27, 8225,   34,16417,   23,   24,
+       23,    7,    7,   24,   34,    8,   24,    8,   34,   34,
+       34,   34,    6,   24,    6,    6,   24,    6,   24,   34,
+        2,    2,   24,   34,   34,   11,   11,   24,   27, 8225,
+       34,   27, 8225,   34,   27,   34,   27, 8225,   23,   24,
+       34,    8,    8,   24,   34,   34,   18,   19,    6,    6,
+
+       24,    6,    6,   34,   34,   14,   34,   27, 8225,   34,
+       27, 8225,   34,   27, 8225,   27,   34,   27,   34,   34,
+       34,   18,   24,   18,   19,   24,   19,    6,    6,   34,
+       34,   14,   34,   21,    9,   20,   18,   18,   24,   19,
+       19,   24,    6,    5,    6,   34,   22,   21,   24,   21,
+        9,   24,    9,   20,   24,   20,    4,    6,    5,    6,
+       34,   22,   24,   22,   21,   21,   24,    9,    9,   24,
+       20,   20,   24,    4,    6,   12,   34,   22,   22,   24,
+       12,   34
     } ;
 
-static const flex_int16_t yy_accept[356] =
+static const flex_int16_t yy_accept[362] =
     {   0,
         1,    1,    1,    2,    3,    4,    7,   12,   16,   19,
        21,   24,   27,   30,   33,   36,   39,   42,   45,   48,
@@ -633,39 +634,40 @@ static const flex_int16_t yy_accept[356] =
        74,   76,   79,   81,   82,   83,   84,   87,   87,   88,
        89,   90,   91,   92,   93,   94,   95,   96,   97,   98,
        99,  100,  101,  102,  103,  104,  105,  106,  107,  108,
-      109,  110,  111,  113,  115,  116,  118,  120,  121,  122,
+      109,  110,  111,  112,  114,  116,  117,  119,  121,  122,
       123,  124,  125,  126,  127,  128,  129,  130,  131,  132,
       133,  134,  135,  136,  137,  138,  139,  140,  141,  142,
-      143,  144,  145,  146,  148,  150,  151,  152,  153,  154,
-
-      158,  159,  160,  162,  163,  164,  165,  166,  167,  168,
-      169,  170,  175,  176,  177,  181,  182,  187,  188,  189,
-      194,  195,  196,  197,  198,  199,  202,  205,  207,  209,
-      210,  212,  214,  215,  216,  217,  218,  222,  223,  224,
-      225,  228,  231,  233,  235,  236,  237,  240,  243,  245,
-      247,  250,  253,  255,  257,  258,  261,  264,  266,  268,
-      269,  270,  271,  272,  273,  276,  279,  281,  283,  284,
-      285,  287,  288,  289,  290,  291,  292,  293,  296,  299,
-      301,  303,  304,  305,  309,  312,  315,  317,  319,  320,
-      321,  322,  325,  328,  330,  332,  333,  336,  339,  341,
-
-      343,  344,  345,  348,  351,  353,  355,  356,  357,  358,
-      360,  361,  362,  363,  364,  365,  366,  367,  368,  369,
-      371,  374,  377,  379,  381,  382,  383,  384,  387,  390,
-      392,  394,  396,  397,  398,  399,  400,  401,  403,  405,
-      406,  407,  408,  409,  410,  411,  412,  413,  414,  416,
-      418,  419,  420,  423,  426,  428,  430,  431,  433,  434,
-      436,  437,  441,  443,  444,  445,  447,  448,  450,  451,
-      452,  453,  454,  455,  457,  458,  460,  462,  463,  464,
-      466,  467,  468,  469,  471,  474,  477,  479,  481,  483,
-      484,  485,  487,  488,  489,  490,  491,  492,  494,  495,
-
-      496,  497,  498,  500,  503,  506,  508,  510,  511,  512,
-      513,  514,  516,  517,  519,  520,  521,  522,  523,  524,
-      526,  527,  528,  529,  530,  532,  533,  535,  536,  538,
-      539,  540,  542,  543,  545,  546,  548,  549,  551,  553,
-      554,  556,  557,  558,  560,  561,  563,  564,  566,  568,
-      570,  571,  573,  575,  575
+      143,  144,  145,  146,  147,  148,  150,  152,  153,  154,
+
+      155,  156,  160,  161,  162,  164,  165,  166,  167,  168,
+      169,  170,  171,  172,  177,  178,  179,  183,  184,  189,
+      190,  191,  196,  197,  198,  199,  200,  201,  202,  205,
+      208,  210,  212,  213,  215,  217,  218,  219,  220,  221,
+      225,  226,  227,  228,  231,  234,  236,  238,  239,  240,
+      243,  246,  248,  250,  253,  256,  258,  260,  261,  264,
+      267,  269,  271,  272,  273,  274,  275,  276,  277,  280,
+      283,  285,  287,  288,  289,  291,  292,  293,  294,  295,
+      296,  297,  300,  303,  305,  307,  308,  309,  313,  316,
+      319,  321,  323,  324,  325,  326,  329,  332,  334,  336,
+
+      337,  340,  343,  345,  347,  348,  349,  352,  355,  357,
+      359,  360,  361,  362,  364,  365,  367,  368,  369,  370,
+      371,  372,  373,  374,  375,  377,  380,  383,  385,  387,
+      388,  389,  390,  393,  396,  398,  400,  402,  403,  404,
+      405,  406,  407,  409,  411,  413,  414,  415,  416,  417,
+      418,  419,  420,  421,  422,  424,  426,  427,  428,  431,
+      434,  436,  438,  439,  441,  442,  444,  445,  449,  451,
+      452,  453,  455,  456,  458,  459,  460,  461,  462,  463,
+      465,  466,  468,  470,  471,  472,  474,  475,  476,  477,
+      479,  482,  485,  487,  489,  491,  492,  493,  495,  496,
+
+      497,  498,  499,  500,  502,  503,  504,  505,  506,  508,
+      511,  514,  516,  518,  519,  520,  521,  522,  524,  525,
+      527,  528,  529,  530,  531,  532,  534,  535,  536,  537,
+      538,  540,  541,  543,  544,  546,  547,  548,  550,  551,
+      553,  554,  556,  557,  559,  561,  562,  564,  565,  566,
+      568,  569,  571,  572,  574,  576,  578,  579,  581,  583,
+      583
     } ;
 
 static const YY_CHAR yy_ec[256] =
@@ -708,216 +710,217 @@ static const YY_CHAR yy_meta[35] =
         1,    1,    1,    1
     } ;
 
-static const flex_int16_t yy_base[424] =
+static const flex_int16_t yy_base[430] =
     {   0,
-        0,    0,  901,  900,  902,  897,   33,   36,  905,  905,
-       45,   63,   31,   42,   51,   52,  890,   33,   65,   67,
-       69,   70,  889,   71,  888,   75,    0,  905,  893,  905,
-       91,   94,    0,    0,  103,  886,  112,    0,   89,   98,
-      113,   92,  114,   99,  100,   48,  121,  116,  119,   74,
-      124,  129,  123,  135,  132,  133,  137,  134,  138,  139,
-      141,    0,  155,    0,    0,  164,    0,    0,  849,  142,
-      152,  164,  140,  161,  165,  166,  167,  168,  169,  173,
-      174,  178,  176,  180,  184,  208,  189,  183,  192,  195,
-      215,  191,  193,  223,    0,    0,  905,  208,  204,  236,
-
-      219,  209,  238,  196,  237,  831,  242,  815,  241,  224,
-      243,  261,  244,  259,  277,  266,  286,  250,  288,  298,
-      249,  283,  274,  282,  294,  308,    0,  310,    0,  295,
-      305,  905,  308,  306,  313,  314,  342,  319,  316,  320,
-      331,    0,  349,    0,  342,  344,  356,    0,  358,    0,
-      365,    0,  367,    0,  354,  375,    0,  377,    0,  363,
-      356,  809,  327,  322,  384,    0,    0,    0,    0,  379,
-      905,  382,  384,  386,  390,  372,  392,  403,    0,  410,
-        0,  407,  413,  423,  426,    0,    0,    0,    0,  409,
-      424,  435,    0,    0,    0,    0,  437,    0,    0,    0,
-
-        0,  433,  444,    0,    0,    0,    0,  391,  440,  781,
-      905,  769,  439,  445,  444,  447,  449,  454,  453,  399,
-      464,    0,    0,    0,    0,  757,  465,  476,    0,  478,
-        0,  479,  476,  753,  462,  490,  749,  905,  745,  905,
-      483,  737,  424,  485,  487,  490,  500,  493,  905,  729,
-      905,  502,  518,    0,    0,    0,    0,  905,  498,  721,
-      905,  527,  713,    0,  705,  905,  495,  697,  905,  365,
-      521,  528,  530,  685,  905,  534,  540,  540,  657,  905,
-      537,  542,  650,  905,  553,    0,  557,    0,    0,  551,
-      641,  905,  558,  557,  633,  614,  613,  905,  547,  555,
-
-      563,  565,  569,  584,    0,    0,    0,    0,  583,  570,
-      585,  612,  905,  601,  905,  522,  580,  589,  594,  905,
-      600,  585,  563,  520,  905,  514,  905,  586,  486,  597,
-      480,  441,  905,  416,  905,  345,  905,  334,  905,  601,
-      254,  905,  242,  905,  200,  905,  151,  905,  905,  607,
-       86,  905,  905,  905,  620,  624,  627,  631,  635,  639,
-      643,  647,  651,  655,  659,  663,  667,  671,  675,  679,
-      683,  687,  691,  695,  699,  703,  707,  711,  715,  719,
-      723,  727,  731,  735,  739,  743,  747,  751,  755,  759,
-      763,  767,  771,  775,  779,  783,  787,  791,  795,  799,
-
-      803,  807,  811,  815,  819,  823,  827,  831,  835,  839,
-      843,  847,  851,  855,  859,  863,  867,  871,  875,  879,
-      883,  887,  891
+        0,    0,  912,  911,  913,  908,   33,   36,  916,  916,
+       45,   63,   31,   42,   51,   52,  901,   33,   65,   67,
+       69,   70,  900,   71,  899,   77,    0,  916,  904,  916,
+       93,   96,    0,    0,  105,  897,  114,    0,   91,  100,
+      115,   94,  116,  101,  102,   48,   74,  118,  121,  123,
+       78,  128,  131,  137,  124,  125,  133,  135,  136,  140,
+      142,  141,    0,  163,    0,    0,  166,    0,    0,  902,
+      143,  146,  163,  164,  166,  167,  149,  169,  170,  175,
+      179,  176,  182,  177,  184,  192,  212,  193,  186,  196,
+      187,  219,  201,  150,  199,  227,    0,    0,  916,  209,
+
+      212,  243,  224,  213,  245,  223,  198,  895,  231,  894,
+      244,  230,  243,  261,  255,  259,  279,  266,  288,  275,
+      291,  301,  268,  284,  298,  301,  285,  302,  311,    0,
+      314,    0,  311,  318,  916,  312,  317,  246,  232,  342,
+      320,  325,  323,  349,    0,  351,    0,  344,  349,  360,
+        0,  363,    0,  367,    0,  370,    0,  330,  377,    0,
+      379,    0,  365,  358,  899,  368,  329,  331,  381,    0,
+        0,    0,    0,  381,  916,  383,  385,  387,  391,  397,
+      393,  409,    0,  411,    0,  412,  414,  424,  427,    0,
+        0,    0,    0,  422,  425,  436,    0,    0,    0,    0,
+
+      438,    0,    0,    0,    0,  434,  445,    0,    0,    0,
+        0,  440,  442,  898,  916,  400,  897,  443,  448,  449,
+      451,  453,  458,  457,  413,  469,    0,    0,    0,    0,
+      896,  469,  480,    0,  482,    0,  483,  480,  895,  489,
+      497,  894,  916,  916,  851,  916,  490,  839,  478,  492,
+      494,  497,  507,  501,  916,  823,  916,  509,  525,    0,
+        0,    0,    0,  916,  505,  811,  916,  534,  783,    0,
+      771,  916,  518,  759,  916,  523,  528,  538,  540,  755,
+      916,  511,  540,  549,  751,  916,  544,  547,  747,  916,
+      560,    0,  562,    0,    0,  555,  739,  916,  484,  561,
+
+      731,  723,  715,  916,  449,  566,  564,  566,  576,  578,
+        0,    0,    0,    0,  584,  574,  586,  707,  916,  699,
+      916,  581,  587,  590,  597,  916,  687,  659,  652,  643,
+      916,  635,  916,  597,  616,  599,  614,  604,  916,  600,
+      916,  541,  916,  467,  916,  603,  455,  916,  404,  916,
+      385,  916,  328,  916,  916,  609,  203,  916,  916,  916,
+      622,  626,  629,  633,  637,  641,  645,  649,  653,  657,
+      661,  665,  669,  673,  677,  681,  685,  689,  693,  697,
+      701,  705,  709,  713,  717,  721,  725,  729,  733,  737,
+      741,  745,  749,  753,  757,  761,  765,  769,  773,  777,
+
+      781,  785,  789,  793,  797,  801,  805,  809,  813,  817,
+      821,  825,  829,  833,  837,  841,  845,  849,  853,  857,
+      861,  865,  869,  873,  877,  881,  885,  889,  893
     } ;
 
-static const flex_int16_t yy_def[424] =
+static const flex_int16_t yy_def[430] =
     {   0,
-      354,    1,  355,  355,  354,  356,  357,  357,  354,  354,
-      358,  358,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,   12,   12,   12,   12,   12,  359,  354,  356,  354,
-      360,  357,  361,  361,  362,   12,  356,  363,   12,   12,
+      360,    1,  361,  361,  360,  362,  363,  363,  360,  360,
+      364,  364,   12,   12,   12,   12,   12,   12,   12,   12,
+       12,   12,   12,   12,   12,   12,  365,  360,  362,  360,
+      366,  363,  367,  367,  368,   12,  362,  369,   12,   12,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,  359,  360,  361,  361,  364,  365,  365,  354,   12,
+       12,   12,  365,  366,  367,  367,  370,  371,  371,  360,
        12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,   12,   12,   12,   12,  362,   12,   12,   12,   12,
-       12,   12,   12,  364,  365,  365,  354,   12,   12,  366,
-
-       12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
-       12,  367,   86,   86,  368,   12,  369,   12,   12,  370,
-       12,   12,   12,   12,   12,  371,  372,  366,  372,   12,
-       12,  354,   86,   12,   12,   12,  373,   12,   12,   12,
-      374,  375,  367,  375,   86,   86,  376,  377,  368,  377,
-      378,  379,  369,  379,   12,  380,  381,  370,  381,   12,
-       12,  382,   12,   12,  371,  372,  372,  383,  383,   12,
-      354,   86,   86,   86,   12,   12,   12,  384,  385,  373,
-      385,   12,   12,  386,  374,  375,  375,  387,  387,   86,
-       86,  376,  377,  377,  388,  388,  378,  379,  379,  389,
-
-      389,   12,  380,  381,  381,  390,  390,   12,   12,  391,
-      354,  392,   86,   12,   86,   86,   86,   12,   86,   12,
-      384,  385,  385,  393,  393,  394,   86,  395,  396,  386,
-      396,   86,   86,  397,   12,  398,  391,  354,  399,  354,
-       86,  400,   12,   86,   86,   86,  401,   86,  354,  402,
-      354,   86,  395,  396,  396,  403,  403,  354,   86,  404,
-      354,  405,  406,  406,  399,  354,   86,  407,  354,   12,
-       86,   86,   86,  408,  354,  408,  408,   86,  402,  354,
-       86,   86,  404,  354,  409,  410,  405,  410,  406,   86,
-      407,  354,   12,   86,  411,  412,  408,  354,  408,  408,
-
-       86,   86,   86,  409,  410,  410,  413,  413,   86,   12,
-       86,  414,  354,  415,  354,  408,  408,   86,   86,  354,
-      416,  417,  418,  414,  354,  415,  354,  408,  408,   86,
-      419,  420,  354,  421,  354,  422,  354,  408,  354,   86,
-      423,  354,  420,  354,  421,  354,  422,  354,  354,   86,
-      423,  354,  354,    0,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354
+       12,   12,   12,   12,   12,   12,  368,   12,   12,   12,
+       12,   12,   12,   12,   12,  370,  371,  371,  360,   12,
+
+       12,  372,   12,   12,   12,   12,   12,   12,   12,   12,
+       12,   12,   12,  373,   87,   87,  374,   12,  375,   12,
+       12,  376,   12,   12,   12,   12,   12,   12,  377,  378,
+      372,  378,   12,   12,  360,   87,   12,   12,   12,  379,
+       12,   12,   12,  380,  381,  373,  381,   87,   87,  382,
+      383,  374,  383,  384,  385,  375,  385,   12,  386,  387,
+      376,  387,   12,   12,  388,   12,   12,   12,  377,  378,
+      378,  389,  389,   12,  360,   87,   87,   87,   12,   12,
+       12,  390,  391,  379,  391,   12,   12,  392,  380,  381,
+      381,  393,  393,   87,   87,  382,  383,  383,  394,  394,
+
+      384,  385,  385,  395,  395,   12,  386,  387,  387,  396,
+      396,   12,   12,  397,  360,   12,  398,   87,   12,   87,
+       87,   87,   12,   87,   12,  390,  391,  391,  399,  399,
+      400,   87,  401,  402,  392,  402,   87,   87,  403,   12,
+      404,  397,  360,  360,  405,  360,   87,  406,   12,   87,
+       87,   87,  407,   87,  360,  408,  360,   87,  401,  402,
+      402,  409,  409,  360,   87,  410,  360,  411,  412,  412,
+      405,  360,   87,  413,  360,   12,   87,   87,   87,  414,
+      360,  414,  414,   87,  408,  360,   87,   87,  410,  360,
+      415,  416,  411,  416,  412,   87,  413,  360,   12,   87,
+
+      417,  418,  414,  360,  414,  414,   87,   87,   87,  415,
+      416,  416,  419,  419,   87,   12,   87,  420,  360,  421,
+      360,  414,  414,   87,   87,  360,  422,  423,  424,  420,
+      360,  421,  360,  414,  414,   87,  425,  426,  360,  427,
+      360,  428,  360,  414,  360,   87,  429,  360,  426,  360,
+      427,  360,  428,  360,  360,   87,  429,  360,  360,    0,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360
     } ;
 
-static const flex_int16_t yy_nxt[940] =
+static const flex_int16_t yy_nxt[951] =
     {   0,
         6,    7,    8,    9,    6,    6,    6,    6,   10,   11,
        12,   13,   14,   15,   16,   17,   18,   19,   17,   17,
        17,   17,   20,   17,   21,   22,   23,   24,   25,   17,
        26,   17,   17,   17,   32,   32,   33,   32,   32,   33,
        36,   34,   36,   42,   34,   29,   29,   29,   30,   35,
-       50,   36,   37,   38,   43,   44,   39,   36,   79,   45,
+       50,   36,   37,   38,   43,   44,   39,   36,   80,   45,
        36,   36,   40,   29,   29,   29,   30,   35,   46,   48,
        37,   38,   41,   47,   36,   49,   36,   53,   36,   36,
-       36,   56,   58,   36,   36,   55,   82,   60,   51,  342,
-       54,   61,   52,   29,   64,   32,   32,   33,   36,   65,
-
-       70,   36,   34,   29,   29,   29,   30,   36,   36,   36,
-       29,   38,   66,   66,   66,   67,   66,   71,   74,   66,
-       68,   72,   36,   36,   73,   36,   77,   78,   36,   76,
-       36,   53,   36,   36,   75,   85,   80,   83,   36,   86,
-       84,   36,   36,   36,   36,   81,   36,   36,   36,   36,
-       36,   36,   93,   89,  337,   98,   88,   29,   64,  101,
-       90,   36,   91,   65,   92,   87,   29,   95,   89,   99,
-       36,  100,   96,   36,   36,   36,   36,   36,   36,  106,
-      105,   85,   36,   36,  102,   36,  107,   36,  103,   36,
-      109,  112,   36,   36,  104,  108,  115,  110,   36,  117,
-
-       36,   36,   36,  335,   36,   36,  122,  111,   29,   29,
-       29,   30,  118,   36,  116,   29,   38,   36,   36,  113,
-      114,  119,  120,  123,   36,   29,   95,  121,   36,  134,
-      131,   96,  130,   36,  125,  124,  126,  126,   66,  127,
-      126,  132,  133,  126,  129,  333,   36,   36,  135,  137,
-       36,   36,   36,  140,  139,   35,   35,  352,   36,   36,
-       85,  141,  141,   66,  142,  141,  160,  145,  141,  144,
-       35,   35,   89,  117,  155,   36,  146,  147,  147,   66,
-      148,  147,  162,   36,  147,  150,  151,  151,   66,  152,
-      151,   36,   36,  151,  154,  120,  161,   36,  156,  156,
-
-       66,  157,  156,   36,   36,  156,  159,  164,  171,  163,
-       29,  166,   29,  168,   36,   36,  167,  170,  169,   35,
-       35,  172,   36,   36,  173,   36,  213,  184,   36,   36,
-      175,   36,  174,   29,  186,  212,   36,  349,  183,  187,
-      177,  176,  178,  178,   66,  179,  178,  182,  348,  178,
-      181,   29,  188,   35,   35,   35,   35,  189,   29,  193,
-       29,  195,  190,   36,  194,   36,  196,   29,  198,   29,
-      200,  191,   36,  199,   36,  201,  219,   29,  204,   29,
-      206,   36,  202,  205,  209,  207,   29,  166,   36,  293,
-      208,  214,  167,   35,   35,   35,   35,   35,   35,   36,
-
-       36,   36,  249,  218,  220,   29,  222,  216,   36,  217,
-      235,  223,   29,  224,  215,  226,   36,  227,  225,  346,
-       35,   35,   36,  228,  228,   66,  229,  228,   29,  186,
-      228,  231,  232,   36,  187,  233,   35,   29,  193,   29,
-      198,  234,   36,  194,  344,  199,   29,  204,  236,   36,
-       35,  241,  205,  242,   36,   35,   35,  270,   35,   35,
-       35,   35,  247,   36,   35,   35,   29,  222,  244,  262,
-      248,   36,  223,  243,  245,  246,   35,  252,   29,  254,
-       29,  256,  258,  342,  255,  259,  257,   35,   35,  339,
-       35,   35,   69,  264,   35,   35,   35,   35,   35,   35,
-
-      267,   35,   35,  275,   35,   35,   35,   35,  271,   35,
-       35,  276,  277,   35,   35,  272,  278,  315,  273,  281,
-       29,  254,  290,  313,  282,  275,  255,  285,  285,   66,
-      286,  285,   35,   35,  285,  288,  295,  298,  296,   35,
-       35,   35,   35,  298,  301,  328,  299,  294,   35,   35,
-      275,   35,   35,   35,  303,   29,  305,  300,  275,   29,
-      307,  306,   35,   35,  302,  308,  337,   36,   35,   35,
-      309,  310,  320,  316,   35,   35,   35,   35,  322,   36,
-       35,   35,  317,  275,  319,  311,   29,  305,  335,  275,
-      318,  321,  306,  323,   35,   35,   35,   35,  330,  329,
-
-       35,   35,  331,  333,  327,   35,   35,  338,   35,   35,
-      353,  340,   35,   35,  350,  325,  275,  315,   35,   35,
-       27,   27,   27,   27,   29,   29,   29,   31,   31,   31,
-       31,   36,   36,   36,   36,   62,  313,   62,   62,   63,
-       63,   63,   63,   65,  269,   65,   65,   35,   35,   35,
-       35,   69,   69,  261,   69,   94,   94,   94,   94,   96,
-      251,   96,   96,  128,  128,  128,  128,  143,  143,  143,
-      143,  149,  149,  149,  149,  153,  153,  153,  153,  158,
-      158,  158,  158,  165,  165,  165,  165,  167,  298,  167,
-      167,  180,  180,  180,  180,  185,  185,  185,  185,  187,
-
-      292,  187,  187,  192,  192,  192,  192,  194,  240,  194,
-      194,  197,  197,  197,  197,  199,  289,  199,  199,  203,
-      203,  203,  203,  205,  284,  205,  205,  210,  210,  210,
-      210,  169,  280,  169,  169,  221,  221,  221,  221,  223,
-      269,  223,  223,  230,  230,  230,  230,  189,  266,  189,
-      189,  196,  211,  196,  196,  201,  261,  201,  201,  207,
-      251,  207,  207,  237,  237,  237,  237,  239,  239,  239,
-      239,  225,  240,  225,  225,  250,  250,  250,  250,  253,
-      253,  253,  253,  255,  238,  255,  255,  260,  260,  260,
-      260,  263,  263,  263,  263,  265,  265,  265,  265,  268,
-
-      268,  268,  268,  274,  274,  274,  274,  279,  279,  279,
-      279,  257,  211,  257,  257,  283,  283,  283,  283,  287,
-      287,  287,  287,  264,  138,  264,  264,  291,  291,  291,
-      291,  297,  297,  297,  297,  304,  304,  304,  304,  306,
-      136,  306,  306,  312,  312,  312,  312,  314,  314,  314,
-      314,  308,   97,  308,  308,  324,  324,  324,  324,  326,
-      326,  326,  326,  332,  332,  332,  332,  334,  334,  334,
-      334,  336,  336,  336,  336,  341,  341,  341,  341,  343,
-      343,  343,  343,  345,  345,  345,  345,  347,  347,  347,
-      347,  351,  351,  351,  351,   36,   30,   59,   57,   36,
-
-       30,  354,   28,   28,    5,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354
+       36,   56,   58,   36,   53,   55,   36,   36,   51,   60,
+       54,   84,   52,   61,   62,   29,   65,   32,   32,   33,
+
+       36,   66,   71,   36,   34,   29,   29,   29,   30,   36,
+       36,   36,   29,   38,   67,   67,   67,   68,   67,   72,
+       75,   67,   69,   73,   36,   36,   74,   36,   78,   79,
+       36,   77,   36,   36,   36,   83,   76,   36,   81,   85,
+       36,   87,   36,   86,   36,   36,   36,   82,   89,   36,
+       36,   36,   36,   94,   90,   36,  100,   88,   36,   36,
+       92,   91,   93,  101,   90,   29,   65,   95,   29,   97,
+      102,   66,   36,   36,   98,   36,   36,  106,   36,   36,
+      125,  108,  107,  103,   36,   36,   36,   86,   36,  104,
+      105,   36,  109,   36,  111,   36,   36,  110,  112,  114,
+
+      117,   36,   36,  119,  120,   36,  348,   36,   36,  138,
+       36,  113,   29,   29,   29,   30,  124,  118,   36,   29,
+       38,   36,   36,  115,  116,  121,  122,  126,   36,   29,
+       97,  123,   36,   36,  134,   98,  127,  133,  140,   36,
+       36,   36,  128,  129,  129,   67,  130,  129,  135,  136,
+      129,  132,   36,   36,   36,   36,  137,  142,  181,  143,
+       86,  144,  144,   67,  145,  144,   35,   35,  144,  147,
+       35,   35,   90,  119,  180,   36,  149,   36,  148,  150,
+      150,   67,  151,  150,   36,  163,  150,  153,  154,  154,
+       67,  155,  154,   36,   36,  154,  157,  164,  122,  158,
+
+       36,  159,  159,   67,  160,  159,  165,   36,  159,  162,
+       36,   36,  167,   29,  170,  168,   29,  172,  166,  171,
+       36,  175,  173,   35,   35,  176,   36,   36,  177,   36,
+      188,  343,   36,  174,   36,  218,  178,  217,   36,   36,
+       36,  179,  182,  182,   67,  183,  182,  187,  186,  182,
+      185,   29,  190,   29,  192,   35,   35,  191,  206,  193,
+       35,   35,   29,  197,  194,   29,  199,   36,  198,   29,
+      202,  200,   29,  204,   36,  203,  195,   36,  205,   29,
+      208,   29,  210,   29,  170,  209,  213,  211,  341,  171,
+       36,  216,  212,  219,   35,   35,   35,   35,   35,   35,
+
+       36,  224,   36,  244,  223,  225,   36,  339,  221,   36,
+      222,   29,  227,   29,  229,  220,  255,  228,  232,  230,
+      231,   36,   36,   36,  233,  233,   67,  234,  233,   29,
+      190,  233,  236,   35,   35,  191,  238,   35,   29,  197,
+       29,  202,  239,   36,  198,  237,  203,   29,  208,   36,
+      241,   36,  281,  209,   35,  247,  248,   36,  358,  240,
+       35,   35,   35,   35,   35,   35,  253,   36,   35,   35,
+      355,   29,  227,  250,  254,  322,  249,  228,  251,  252,
+       35,  258,   29,  260,   29,  262,  264,   36,  261,  265,
+      263,   35,   35,   36,   35,   35,  268,  316,   36,   70,
+
+      270,   35,   35,   35,   35,   35,   35,  273,   35,   35,
+      281,  276,   35,   35,  304,  277,   35,   35,  282,  283,
+       35,   35,  278,  305,  284,  279,  287,   29,  260,   35,
+       35,  288,   36,  261,  291,  291,   67,  292,  291,   35,
+       35,  291,  294,  304,  354,  296,  301,  299,  302,   35,
+       35,   35,   35,  307,  300,   35,   35,  306,   35,  309,
+       35,   35,   29,  311,   29,  313,   35,   35,  312,  281,
+      314,  308,   35,   35,  315,   35,   35,   35,   35,  326,
+       29,  311,  328,   36,  281,  325,  312,   35,   35,  317,
+      281,  324,  327,  323,  329,   35,   35,   35,   35,  336,
+
+      281,   35,   35,  352,  334,  337,  335,  350,   35,   35,
+       35,   35,  359,  346,   35,   35,  356,  348,  344,  345,
+       35,   35,   27,   27,   27,   27,   29,   29,   29,   31,
+       31,   31,   31,   36,   36,   36,   36,   63,  321,   63,
+       63,   64,   64,   64,   64,   66,  319,   66,   66,   35,
+       35,   35,   35,   70,   70,  343,   70,   96,   96,   96,
+       96,   98,  341,   98,   98,  131,  131,  131,  131,  146,
+      146,  146,  146,  152,  152,  152,  152,  156,  156,  156,
+      156,  161,  161,  161,  161,  169,  169,  169,  169,  171,
+      339,  171,  171,  184,  184,  184,  184,  189,  189,  189,
+
+      189,  191,  333,  191,  191,  196,  196,  196,  196,  198,
+      331,  198,  198,  201,  201,  201,  201,  203,  281,  203,
+      203,  207,  207,  207,  207,  209,  321,  209,  209,  214,
+      214,  214,  214,  173,  319,  173,  173,  226,  226,  226,
+      226,  228,  275,  228,  228,  235,  235,  235,  235,  193,
+      267,  193,  193,  200,  257,  200,  200,  205,  304,  205,
+      205,  211,  298,  211,  211,  242,  242,  242,  242,  245,
+      245,  245,  245,  230,  246,  230,  230,  256,  256,  256,
+      256,  259,  259,  259,  259,  261,  295,  261,  261,  266,
+      266,  266,  266,  269,  269,  269,  269,  271,  271,  271,
+
+      271,  274,  274,  274,  274,  280,  280,  280,  280,  285,
+      285,  285,  285,  263,  290,  263,  263,  289,  289,  289,
+      289,  293,  293,  293,  293,  270,  286,  270,  270,  297,
+      297,  297,  297,  303,  303,  303,  303,  310,  310,  310,
+      310,  312,  275,  312,  312,  318,  318,  318,  318,  320,
+      320,  320,  320,  314,  272,  314,  314,  330,  330,  330,
+      330,  332,  332,  332,  332,  338,  338,  338,  338,  340,
+      340,  340,  340,  342,  342,  342,  342,  347,  347,  347,
+      347,  349,  349,  349,  349,  351,  351,  351,  351,  353,
+      353,  353,  353,  357,  357,  357,  357,  215,  267,  257,
+
+      246,  243,  215,  141,  139,   99,   36,   30,   59,   57,
+       36,   30,  360,   28,   28,    5,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360
     } ;
 
-static const flex_int16_t yy_chk[940] =
+static const flex_int16_t yy_chk[951] =
     {   0,
         1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
         1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
@@ -927,101 +930,102 @@ static const flex_int16_t yy_chk[940] =
        18,   14,   11,   11,   13,   14,   11,   46,   46,   14,
        15,   16,   11,   12,   12,   12,   12,   12,   14,   16,
        12,   12,   12,   15,   19,   16,   20,   20,   21,   22,
-       24,   22,   24,   50,   26,   21,   50,   26,   19,  351,
-       20,   26,   19,   31,   31,   32,   32,   32,   39,   31,
-
-       39,   42,   32,   35,   35,   35,   35,   40,   44,   45,
-       35,   35,   37,   37,   37,   37,   37,   39,   42,   37,
-       37,   40,   41,   43,   41,   48,   45,   45,   49,   44,
-       47,   47,   53,   51,   43,   53,   48,   51,   52,   54,
-       52,   55,   56,   58,   54,   49,   57,   59,   60,   73,
-       61,   70,   60,   61,  347,   70,   56,   63,   63,   73,
-       58,   71,   59,   63,   59,   55,   66,   66,   57,   71,
-       74,   72,   66,   72,   75,   76,   77,   78,   79,   78,
-       77,   79,   80,   81,   74,   83,   80,   82,   75,   84,
-       82,   85,   88,   85,   76,   81,   87,   83,   87,   89,
-
-       92,   89,   93,  345,   90,  104,   92,   84,   86,   86,
-       86,   86,   90,   99,   88,   86,   86,   98,  102,   86,
-       86,   91,   91,   93,   91,   94,   94,   91,  101,  104,
-      102,   94,  101,  110,   99,   98,  100,  100,  100,  100,
-      100,  103,  103,  100,  100,  343,  105,  103,  105,  107,
-      109,  107,  111,  110,  109,  113,  113,  341,  121,  118,
-      111,  112,  112,  112,  112,  112,  121,  113,  112,  112,
-      114,  114,  116,  116,  118,  116,  114,  115,  115,  115,
-      115,  115,  123,  123,  115,  115,  117,  117,  117,  117,
-      117,  124,  122,  117,  117,  119,  122,  119,  120,  120,
-
-      120,  120,  120,  125,  130,  120,  120,  125,  131,  124,
-      126,  126,  128,  128,  131,  134,  126,  130,  128,  133,
-      133,  133,  135,  136,  133,  139,  164,  140,  138,  140,
-      134,  164,  133,  141,  141,  163,  163,  338,  139,  141,
-      136,  135,  137,  137,  137,  137,  137,  138,  336,  137,
-      137,  143,  143,  145,  145,  146,  146,  143,  147,  147,
-      149,  149,  145,  155,  147,  161,  149,  151,  151,  153,
-      153,  146,  160,  151,  270,  153,  176,  156,  156,  158,
-      158,  176,  155,  156,  161,  158,  165,  165,  170,  270,
-      160,  170,  165,  172,  172,  173,  173,  174,  174,  175,
-
-      208,  177,  220,  175,  177,  178,  178,  173,  220,  174,
-      208,  178,  180,  180,  172,  182,  182,  183,  180,  334,
-      190,  190,  183,  184,  184,  184,  184,  184,  185,  185,
-      184,  184,  190,  243,  185,  191,  191,  192,  192,  197,
-      197,  202,  202,  192,  332,  197,  203,  203,  209,  209,
-      213,  213,  203,  214,  214,  215,  215,  243,  216,  216,
-      217,  217,  218,  218,  219,  219,  221,  221,  215,  235,
-      219,  235,  221,  214,  216,  217,  227,  227,  228,  228,
-      230,  230,  232,  331,  228,  233,  230,  233,  233,  329,
-      232,  232,  236,  236,  241,  241,  244,  244,  245,  245,
-
-      241,  246,  246,  247,  248,  248,  267,  267,  244,  259,
-      259,  247,  247,  252,  252,  245,  248,  326,  246,  252,
-      253,  253,  267,  324,  259,  316,  253,  262,  262,  262,
-      262,  262,  271,  271,  262,  262,  272,  276,  273,  272,
-      272,  273,  273,  277,  278,  316,  276,  271,  281,  281,
-      299,  278,  278,  282,  282,  285,  285,  277,  300,  287,
-      287,  285,  290,  290,  281,  287,  323,  293,  294,  294,
-      290,  293,  303,  299,  301,  301,  302,  302,  310,  310,
-      303,  303,  300,  317,  302,  294,  304,  304,  322,  328,
-      301,  309,  304,  311,  309,  309,  311,  311,  318,  317,
-
-      318,  318,  319,  321,  314,  319,  319,  328,  330,  330,
-      350,  330,  340,  340,  340,  312,  297,  296,  350,  350,
-      355,  355,  355,  355,  356,  356,  356,  357,  357,  357,
-      357,  358,  358,  358,  358,  359,  295,  359,  359,  360,
-      360,  360,  360,  361,  291,  361,  361,  362,  362,  362,
-      362,  363,  363,  283,  363,  364,  364,  364,  364,  365,
-      279,  365,  365,  366,  366,  366,  366,  367,  367,  367,
-      367,  368,  368,  368,  368,  369,  369,  369,  369,  370,
-      370,  370,  370,  371,  371,  371,  371,  372,  274,  372,
-      372,  373,  373,  373,  373,  374,  374,  374,  374,  375,
-
-      268,  375,  375,  376,  376,  376,  376,  377,  265,  377,
-      377,  378,  378,  378,  378,  379,  263,  379,  379,  380,
-      380,  380,  380,  381,  260,  381,  381,  382,  382,  382,
-      382,  383,  250,  383,  383,  384,  384,  384,  384,  385,
-      242,  385,  385,  386,  386,  386,  386,  387,  239,  387,
-      387,  388,  237,  388,  388,  389,  234,  389,  389,  390,
-      226,  390,  390,  391,  391,  391,  391,  392,  392,  392,
-      392,  393,  212,  393,  393,  394,  394,  394,  394,  395,
-      395,  395,  395,  396,  210,  396,  396,  397,  397,  397,
-      397,  398,  398,  398,  398,  399,  399,  399,  399,  400,
-
-      400,  400,  400,  401,  401,  401,  401,  402,  402,  402,
-      402,  403,  162,  403,  403,  404,  404,  404,  404,  405,
-      405,  405,  405,  406,  108,  406,  406,  407,  407,  407,
-      407,  408,  408,  408,  408,  409,  409,  409,  409,  410,
-      106,  410,  410,  411,  411,  411,  411,  412,  412,  412,
-      412,  413,   69,  413,  413,  414,  414,  414,  414,  415,
-      415,  415,  415,  416,  416,  416,  416,  417,  417,  417,
-      417,  418,  418,  418,  418,  419,  419,  419,  419,  420,
-      420,  420,  420,  421,  421,  421,  421,  422,  422,  422,
-      422,  423,  423,  423,  423,   36,   29,   25,   23,   17,
-
-        6,    5,    4,    3,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
-      354,  354,  354,  354,  354,  354,  354,  354,  354
+       24,   22,   24,   47,   47,   21,   26,   51,   19,   26,
+       20,   51,   19,   26,   26,   31,   31,   32,   32,   32,
+
+       39,   31,   39,   42,   32,   35,   35,   35,   35,   40,
+       44,   45,   35,   35,   37,   37,   37,   37,   37,   39,
+       42,   37,   37,   40,   41,   43,   41,   48,   45,   45,
+       49,   44,   50,   55,   56,   50,   43,   52,   48,   52,
+       53,   54,   57,   53,   58,   59,   54,   49,   56,   60,
+       62,   61,   71,   60,   61,   72,   71,   55,   77,   94,
+       59,   58,   59,   72,   57,   64,   64,   62,   67,   67,
+       73,   64,   73,   74,   67,   75,   76,   77,   78,   79,
+       94,   79,   78,   74,   80,   82,   84,   80,   81,   75,
+       76,   83,   81,   85,   83,   89,   91,   82,   84,   86,
+
+       88,   86,   88,   90,   91,   90,  357,  107,   95,  107,
+       93,   85,   87,   87,   87,   87,   93,   89,  100,   87,
+       87,  101,  104,   87,   87,   92,   92,   95,   92,   96,
+       96,   92,  106,  103,  104,   96,  100,  103,  109,  112,
+      109,  139,  101,  102,  102,  102,  102,  102,  105,  105,
+      102,  102,  113,  111,  105,  138,  106,  111,  139,  112,
+      113,  114,  114,  114,  114,  114,  115,  115,  114,  114,
+      116,  116,  118,  118,  138,  118,  116,  123,  115,  117,
+      117,  117,  117,  117,  120,  123,  117,  117,  119,  119,
+      119,  119,  119,  124,  127,  119,  119,  124,  121,  120,
+
+      121,  122,  122,  122,  122,  122,  125,  125,  122,  122,
+      126,  128,  127,  129,  129,  128,  131,  131,  126,  129,
+      133,  134,  131,  136,  136,  136,  137,  134,  136,  141,
+      143,  353,  143,  133,  142,  168,  136,  167,  167,  158,
+      168,  137,  140,  140,  140,  140,  140,  142,  141,  140,
+      140,  144,  144,  146,  146,  148,  148,  144,  158,  146,
+      149,  149,  150,  150,  148,  152,  152,  164,  150,  154,
+      154,  152,  156,  156,  163,  154,  149,  166,  156,  159,
+      159,  161,  161,  169,  169,  159,  164,  161,  351,  169,
+      174,  166,  163,  174,  176,  176,  177,  177,  178,  178,
+
+      179,  180,  181,  216,  179,  181,  180,  349,  177,  216,
+      178,  182,  182,  184,  184,  176,  225,  182,  187,  184,
+      186,  186,  225,  187,  188,  188,  188,  188,  188,  189,
+      189,  188,  188,  194,  194,  189,  195,  195,  196,  196,
+      201,  201,  206,  206,  196,  194,  201,  207,  207,  212,
+      213,  213,  305,  207,  218,  218,  219,  219,  347,  212,
+      220,  220,  221,  221,  222,  222,  223,  223,  224,  224,
+      344,  226,  226,  220,  224,  305,  219,  226,  221,  222,
+      232,  232,  233,  233,  235,  235,  237,  249,  233,  238,
+      235,  238,  238,  299,  237,  237,  240,  299,  240,  241,
+
+      241,  247,  247,  250,  250,  251,  251,  247,  252,  252,
+      253,  249,  254,  254,  282,  250,  265,  265,  253,  253,
+      258,  258,  251,  282,  254,  252,  258,  259,  259,  273,
+      273,  265,  276,  259,  268,  268,  268,  268,  268,  277,
+      277,  268,  268,  283,  342,  273,  278,  276,  279,  278,
+      278,  279,  279,  284,  277,  287,  287,  283,  288,  288,
+      284,  284,  291,  291,  293,  293,  296,  296,  291,  306,
+      293,  287,  300,  300,  296,  307,  307,  308,  308,  309,
+      310,  310,  316,  316,  322,  308,  310,  309,  309,  300,
+      323,  307,  315,  306,  317,  315,  315,  317,  317,  324,
+
+      334,  324,  324,  340,  322,  325,  323,  338,  325,  325,
+      336,  336,  356,  336,  346,  346,  346,  337,  334,  335,
+      356,  356,  361,  361,  361,  361,  362,  362,  362,  363,
+      363,  363,  363,  364,  364,  364,  364,  365,  332,  365,
+      365,  366,  366,  366,  366,  367,  330,  367,  367,  368,
+      368,  368,  368,  369,  369,  329,  369,  370,  370,  370,
+      370,  371,  328,  371,  371,  372,  372,  372,  372,  373,
+      373,  373,  373,  374,  374,  374,  374,  375,  375,  375,
+      375,  376,  376,  376,  376,  377,  377,  377,  377,  378,
+      327,  378,  378,  379,  379,  379,  379,  380,  380,  380,
+
+      380,  381,  320,  381,  381,  382,  382,  382,  382,  383,
+      318,  383,  383,  384,  384,  384,  384,  385,  303,  385,
+      385,  386,  386,  386,  386,  387,  302,  387,  387,  388,
+      388,  388,  388,  389,  301,  389,  389,  390,  390,  390,
+      390,  391,  297,  391,  391,  392,  392,  392,  392,  393,
+      289,  393,  393,  394,  285,  394,  394,  395,  280,  395,
+      395,  396,  274,  396,  396,  397,  397,  397,  397,  398,
+      398,  398,  398,  399,  271,  399,  399,  400,  400,  400,
+      400,  401,  401,  401,  401,  402,  269,  402,  402,  403,
+      403,  403,  403,  404,  404,  404,  404,  405,  405,  405,
+
+      405,  406,  406,  406,  406,  407,  407,  407,  407,  408,
+      408,  408,  408,  409,  266,  409,  409,  410,  410,  410,
+      410,  411,  411,  411,  411,  412,  256,  412,  412,  413,
+      413,  413,  413,  414,  414,  414,  414,  415,  415,  415,
+      415,  416,  248,  416,  416,  417,  417,  417,  417,  418,
+      418,  418,  418,  419,  245,  419,  419,  420,  420,  420,
+      420,  421,  421,  421,  421,  422,  422,  422,  422,  423,
+      423,  423,  423,  424,  424,  424,  424,  425,  425,  425,
+      425,  426,  426,  426,  426,  427,  427,  427,  427,  428,
+      428,  428,  428,  429,  429,  429,  429,  242,  239,  231,
+
+      217,  214,  165,  110,  108,   70,   36,   29,   25,   23,
+       17,    6,    5,    4,    3,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
+      360,  360,  360,  360,  360,  360,  360,  360,  360,  360
     } ;
 
 #define YY_TRAILING_MASK 0x2000
@@ -1199,9 +1203,9 @@ static int vdev_and_devtype(DiskParseContext *dpc, char *str) {
 #undef DPC /* needs to be defined differently the actual lexer */
 #define DPC ((DiskParseContext*)yyextra)
 
-#line 1202 "libxlu_disk_l.c"
+#line 1206 "libxlu_disk_l.c"
 
-#line 1204 "libxlu_disk_l.c"
+#line 1208 "libxlu_disk_l.c"
 
 #define INITIAL 0
 #define LEXERR 1
@@ -1483,7 +1487,7 @@ YY_DECL
 #line 180 "libxlu_disk_l.l"
  /*----- the scanner rules which do the parsing -----*/
 
-#line 1486 "libxlu_disk_l.c"
+#line 1490 "libxlu_disk_l.c"
 
 	while ( /*CONSTCOND*/1 )		/* loops until end-of-file is reached */
 		{
@@ -1515,14 +1519,14 @@ yy_match:
 			while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 				{
 				yy_current_state = (int) yy_def[yy_current_state];
-				if ( yy_current_state >= 355 )
+				if ( yy_current_state >= 361 )
 					yy_c = yy_meta[yy_c];
 				}
 			yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
 			*yyg->yy_state_ptr++ = yy_current_state;
 			++yy_cp;
 			}
-		while ( yy_current_state != 354 );
+		while ( yy_current_state != 360 );
 
 yy_find_action:
 		yy_current_state = *--yyg->yy_state_ptr;
@@ -1648,76 +1652,81 @@ YY_RULE_SETUP
 #line 201 "libxlu_disk_l.l"
 { libxl_defbool_set(&DPC->disk->discard_enable, false); }
 	YY_BREAK
-/* Note that the COLO configuration settings should be considered unstable.
-  * They may change incompatibly in future versions of Xen. */
 case 15:
 YY_RULE_SETUP
-#line 204 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
+#line 202 "libxlu_disk_l.l"
+{ DPC->disk->virtio = 1; }
 	YY_BREAK
+/* Note that the COLO configuration settings should be considered unstable.
+  * They may change incompatibly in future versions of Xen. */
 case 16:
 YY_RULE_SETUP
 #line 205 "libxlu_disk_l.l"
-{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
+{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
 	YY_BREAK
 case 17:
-/* rule 17 can match eol */
 YY_RULE_SETUP
 #line 206 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
+{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
 	YY_BREAK
 case 18:
 /* rule 18 can match eol */
 YY_RULE_SETUP
 #line 207 "libxlu_disk_l.l"
-{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
+{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
 	YY_BREAK
 case 19:
 /* rule 19 can match eol */
 YY_RULE_SETUP
 #line 208 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
+{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
 	YY_BREAK
 case 20:
 /* rule 20 can match eol */
 YY_RULE_SETUP
 #line 209 "libxlu_disk_l.l"
-{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
+{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
 	YY_BREAK
 case 21:
 /* rule 21 can match eol */
 YY_RULE_SETUP
 #line 210 "libxlu_disk_l.l"
+{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
+	YY_BREAK
+case 22:
+/* rule 22 can match eol */
+YY_RULE_SETUP
+#line 211 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); }
 	YY_BREAK
 /* the target magic parameter, eats the rest of the string */
-case 22:
+case 23:
 YY_RULE_SETUP
-#line 214 "libxlu_disk_l.l"
+#line 215 "libxlu_disk_l.l"
 { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); }
 	YY_BREAK
 /* unknown parameters */
-case 23:
-/* rule 23 can match eol */
+case 24:
+/* rule 24 can match eol */
 YY_RULE_SETUP
-#line 218 "libxlu_disk_l.l"
+#line 219 "libxlu_disk_l.l"
 { xlu__disk_err(DPC,yytext,"unknown parameter"); }
 	YY_BREAK
 /* deprecated prefixes */
 /* the "/.*" in these patterns ensures that they count as if they
    * matched the whole string, so these patterns take precedence */
-case 24:
+case 25:
 YY_RULE_SETUP
-#line 225 "libxlu_disk_l.l"
+#line 226 "libxlu_disk_l.l"
 {
                     STRIP(':');
                     DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'");
                     setformat(DPC, yytext);
                  }
 	YY_BREAK
-case 25:
+case 26:
 YY_RULE_SETUP
-#line 231 "libxlu_disk_l.l"
+#line 232 "libxlu_disk_l.l"
 {
                     char *newscript;
                     STRIP(':');
@@ -1731,30 +1740,22 @@ YY_RULE_SETUP
                     free(newscript);
                 }
 	YY_BREAK
-case 26:
+case 27:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
 yyg->yy_c_buf_p = yy_cp = yy_bp + 8;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
-#line 244 "libxlu_disk_l.l"
-{ DPC->had_depr_prefix=1; DEPRECATE(0); }
-	YY_BREAK
-case 27:
-YY_RULE_SETUP
 #line 245 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 28:
-*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
-yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
-YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
 #line 246 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 29:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
-yyg->yy_c_buf_p = yy_cp = yy_bp + 6;
+yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
 #line 247 "libxlu_disk_l.l"
@@ -1762,7 +1763,7 @@ YY_RULE_SETUP
 	YY_BREAK
 case 30:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
-yyg->yy_c_buf_p = yy_cp = yy_bp + 5;
+yyg->yy_c_buf_p = yy_cp = yy_bp + 6;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
 #line 248 "libxlu_disk_l.l"
@@ -1770,26 +1771,34 @@ YY_RULE_SETUP
 	YY_BREAK
 case 31:
 *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
-yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
+yyg->yy_c_buf_p = yy_cp = yy_bp + 5;
 YY_DO_BEFORE_ACTION; /* set up yytext again */
 YY_RULE_SETUP
 #line 249 "libxlu_disk_l.l"
 { DPC->had_depr_prefix=1; DEPRECATE(0); }
 	YY_BREAK
 case 32:
-/* rule 32 can match eol */
+*yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */
+yyg->yy_c_buf_p = yy_cp = yy_bp + 4;
+YY_DO_BEFORE_ACTION; /* set up yytext again */
+YY_RULE_SETUP
+#line 250 "libxlu_disk_l.l"
+{ DPC->had_depr_prefix=1; DEPRECATE(0); }
+	YY_BREAK
+case 33:
+/* rule 33 can match eol */
 YY_RULE_SETUP
-#line 251 "libxlu_disk_l.l"
+#line 252 "libxlu_disk_l.l"
 {
 		  xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix");
 		  return 0;
 		}
 	YY_BREAK
 /* positional parameters */
-case 33:
-/* rule 33 can match eol */
+case 34:
+/* rule 34 can match eol */
 YY_RULE_SETUP
-#line 258 "libxlu_disk_l.l"
+#line 259 "libxlu_disk_l.l"
 {
     STRIP(',');
 
@@ -1816,27 +1825,27 @@ YY_RULE_SETUP
     }
 }
 	YY_BREAK
-case 34:
+case 35:
 YY_RULE_SETUP
-#line 284 "libxlu_disk_l.l"
+#line 285 "libxlu_disk_l.l"
 {
     BEGIN(LEXERR);
     yymore();
 }
 	YY_BREAK
-case 35:
+case 36:
 YY_RULE_SETUP
-#line 288 "libxlu_disk_l.l"
+#line 289 "libxlu_disk_l.l"
 {
     xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0;
 }
 	YY_BREAK
-case 36:
+case 37:
 YY_RULE_SETUP
-#line 291 "libxlu_disk_l.l"
+#line 292 "libxlu_disk_l.l"
 YY_FATAL_ERROR( "flex scanner jammed" );
 	YY_BREAK
-#line 1839 "libxlu_disk_l.c"
+#line 1848 "libxlu_disk_l.c"
 			case YY_STATE_EOF(INITIAL):
 			case YY_STATE_EOF(LEXERR):
 				yyterminate();
@@ -2104,7 +2113,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner)
 		while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 			{
 			yy_current_state = (int) yy_def[yy_current_state];
-			if ( yy_current_state >= 355 )
+			if ( yy_current_state >= 361 )
 				yy_c = yy_meta[yy_c];
 			}
 		yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
@@ -2128,11 +2137,11 @@ static int yy_get_next_buffer (yyscan_t yyscanner)
 	while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state )
 		{
 		yy_current_state = (int) yy_def[yy_current_state];
-		if ( yy_current_state >= 355 )
+		if ( yy_current_state >= 361 )
 			yy_c = yy_meta[yy_c];
 		}
 	yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c];
-	yy_is_jam = (yy_current_state == 354);
+	yy_is_jam = (yy_current_state == 360);
 	if ( ! yy_is_jam )
 		*yyg->yy_state_ptr++ = yy_current_state;
 
@@ -2941,4 +2950,4 @@ void yyfree (void * ptr , yyscan_t yyscanner)
 
 #define YYTABLES_NAME "yytables"
 
-#line 291 "libxlu_disk_l.l"
+#line 292 "libxlu_disk_l.l"
diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h
index 6abeecf..df20fcc 100644
--- a/tools/libs/util/libxlu_disk_l.h
+++ b/tools/libs/util/libxlu_disk_l.h
@@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner);
 #undef yyTABLES_NAME
 #endif
 
-#line 291 "libxlu_disk_l.l"
+#line 292 "libxlu_disk_l.l"
 
 #line 699 "libxlu_disk_l.h"
 #undef xlu__disk_yyIN_HEADER
diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_disk_l.l
index 3bd639a..d68a59c 100644
--- a/tools/libs/util/libxlu_disk_l.l
+++ b/tools/libs/util/libxlu_disk_l.l
@@ -198,6 +198,7 @@ script=[^,]*,?	{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); }
 direct-io-safe,? { DPC->disk->direct_io_safe = 1; }
 discard,?	{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
 no-discard,?	{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
+virtio,?	{ DPC->disk->virtio = 1; }
  /* Note that the COLO configuration settings should be considered unstable.
   * They may change incompatibly in future versions of Xen. */
 colo,?		{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
index 70eed43..50a4d45 100644
--- a/tools/xl/xl_block.c
+++ b/tools/xl/xl_block.c
@@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
         return 0;
     }
 
+    if (disk.virtio) {
+        fprintf(stderr, "block-attach is not supported for Virtio device\n");
+        return 1;
+    }
+
     if (libxl_device_disk_add(ctx, fe_domid, &disk, 0)) {
         fprintf(stderr, "libxl_device_disk_add failed.\n");
         return 1;
@@ -119,6 +124,12 @@ int main_blockdetach(int argc, char **argv)
         fprintf(stderr, "Error: Device %s not connected.\n", argv[optind+1]);
         return 1;
     }
+
+    if (disk.virtio) {
+        fprintf(stderr, "block-detach is not supported for Virtio device\n");
+        return 1;
+    }
+
     rc = !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) :
         libxl_device_disk_destroy(ctx, domid, &disk, 0);
     if (rc) {
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:00:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:00:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242520.419434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Ij-0007Vl-Hg; Wed, 08 Dec 2021 17:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242520.419434; Wed, 08 Dec 2021 17:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0Ij-0007Ve-Ek; Wed, 08 Dec 2021 17:00:17 +0000
Received: by outflank-mailman (input) for mailman id 242520;
 Wed, 08 Dec 2021 17:00:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Ity+=QZ=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mv0Ih-0007VY-ST
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:00:15 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5031040a-5848-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 18:00:14 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id bi37so6842303lfb.5
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 09:00:14 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b14sm302767lfs.174.2021.12.08.09.00.13
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Dec 2021 09:00:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5031040a-5848-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=irpOZlHnLuCFvgvt7pasDPosQACWGgbdRbyKuJ7cmBo=;
        b=iUFu/MHHZhkppZ6XYyd5oYPfhGgHxAnxa2IaMN/epp2c8KCFkUYKgNoAPhRmGHceDx
         rWdvlE2KmDCp37apRa+0zHjU5O5KFljD2ebqbREddWmBFZsfnlEeKqytzYPcPdFkvatl
         mImFZmp3XZYYLqS2TxHlD35FalHWrJLf+KvWeiray5Ywgvo71DlzcfxspdmsULC3xMTO
         iwF+BENmvpwFQK+N6y07+w3NXRrVr5/BkZxA9e1QXhKpUM4Se7DlZlzPAZrBh+W72AhP
         A4HTUmI1wvClpDQi4dqG6ezqsOtdtRGfRZvD3p2E9ufujA7nwaceCvNs7DkyxM5tXu4E
         Lw8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=irpOZlHnLuCFvgvt7pasDPosQACWGgbdRbyKuJ7cmBo=;
        b=0DgZnXH4MwNaJEKk7twAUjLlP54tCvpspsxTFuIAV8Odcvz9ohKvfePVgApZADN5nN
         8vMWshDxkOtWnNFkNCBxTd4rVQW5M6bjm443E6JoOqMHvz9zKm32lCEXAThrdVbw6euo
         yV5Fg050amvn+nawGup7X/U18UIVsTCVBuXUHPoib495Ro04sOr31j43Ynlebi257fFm
         M3pI/EHTSwyWmGbjWU97DjI1+gPzSqmVrmU6FoCjYXHfUb6zRERCtCw3PJ8hoYIpO1Yh
         9BqIRXJXIau+1lribLGWxf+jnksulOAcGrucVn6GqEvakv406JNlA3jZ/9zFMNHsN3Qn
         FuXQ==
X-Gm-Message-State: AOAM5309Wkh/KcGq7cryMb7HAlxDrvxWtW7SD81na0DBEE4kHW8uvtGp
	IyEAAFNovdb+qXJ7tdhjxWqwLi06wjQ=
X-Google-Smtp-Source: ABdhPJwlxYFJf0RDSgS7tzGaKYOttYlxhI41eqlNrorSK+738YWPrW0ZF5DfTMeRs19cG3z9y/cAnA==
X-Received: by 2002:a05:6512:2820:: with SMTP id cf32mr661584lfb.510.1638982814338;
        Wed, 08 Dec 2021 09:00:14 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Nick Rosbrook <rosbrookn@ainfosec.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	=?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>
Subject: [PATCH V6 0/2] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm")
Date: Wed,  8 Dec 2021 18:59:42 +0200
Message-Id: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm.
The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM
support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio
enabling work. You can find previous discussions at [2].

Patch series [3] is based on recent "staging branch"
(608531a0cc34a5bc096ccf585e16f182b5ed83e1 MAINTAINERS: Resign from my maintainership roles)
and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio disk backend [4]
running in Driver domain and unmodified Linux Guest running on existing virtio-blk driver (frontend).
No issues were observed. Guest domain 'reboot/destroy' use-cases work properly.

Any feedback/help would be highly appreciated.

[1] 
https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/
https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/
[2]
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html
https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html
https://lore.kernel.org/xen-devel/1621626361-29076-1-git-send-email-olekstysh@gmail.com/

[3] https://github.com/otyshchenko1/xen/commits/libxl_virtio1
[4] https://github.com/xen-troops/virtio-disk/commits/ioreq_ml3

Julien Grall (1):
  libxl: Introduce basic virtio-mmio support on Arm

Oleksandr Tyshchenko (1):
  libxl: Add support for Virtio disk configuration

 docs/man/xl-disk-configuration.5.pod.in   |  27 +
 tools/golang/xenlight/helpers.gen.go      |   6 +
 tools/golang/xenlight/types.gen.go        |   4 +
 tools/include/libxl.h                     |   6 +
 tools/libs/light/libxl_arm.c              | 131 ++++-
 tools/libs/light/libxl_device.c           |  38 +-
 tools/libs/light/libxl_disk.c             |  99 +++-
 tools/libs/light/libxl_types.idl          |   4 +
 tools/libs/light/libxl_types_internal.idl |   1 +
 tools/libs/light/libxl_utils.c            |   2 +
 tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------------
 tools/libs/util/libxlu_disk_l.h           |   2 +-
 tools/libs/util/libxlu_disk_l.l           |   1 +
 tools/xl/xl_block.c                       |  11 +
 xen/include/public/arch-arm.h             |   7 +
 15 files changed, 772 insertions(+), 448 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:20:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:20:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242545.419468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0cR-0003Yo-4h; Wed, 08 Dec 2021 17:20:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242545.419468; Wed, 08 Dec 2021 17:20:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0cR-0003Yh-1h; Wed, 08 Dec 2021 17:20:39 +0000
Received: by outflank-mailman (input) for mailman id 242545;
 Wed, 08 Dec 2021 17:20:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mv0cP-0003Yb-LQ
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:20:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0cO-0002Ie-NW; Wed, 08 Dec 2021 17:20:36 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0cO-0008PZ-Gf; Wed, 08 Dec 2021 17:20:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=iTfqszxfVCktiQeinUB2CymkWpPoVKlfRn45wj5JphU=; b=cZ6N2oq/5R+vzC71VrGW3WzLZR
	S5jWfsnDI8W11G91nR2iw1TEcZdxaRHT+4vIUVOWQfriKgaIOAicxF2cJgc0hpc56BLjNsnRqJlfz
	klugye5VDaXNqZR9BGV839rW7vXGCHxsdPbGhyvFrnpguBi2/W/PFwpdPPA4BknK2mGo=;
Message-ID: <dc367640-b445-9c47-6d66-9c6a8cdbc85f@xen.org>
Date: Wed, 8 Dec 2021 17:20:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 5/7] xen/arm: do not map PCI ECAM and MMIO space to
 Domain-0's p2m
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-6-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-6-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
> 
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>            at least a definition of non-prefetchable memory. One
>            or both of prefetchable Memory and IO Space may also
>            be provided.
> 
> - reg   : The Configuration Space base address and size, as accessed
>            from the parent bus.  The base address corresponds to
>            the first bus in the "bus-range" property.  If no
>            "bus-range" is specified, this will be bus 0 (the default).
> 
>  From the above none of the memory ranges from the "ranges" property
> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
> 
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>     "rc_dbi": controller configuration registers;
>     "config": PCIe configuration space registers.
> 
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0. This is done by first
> skipping the mappings while traversing the device tree as it is done for
> usual devices and then by calling a dedicated pci_host_bridge_mappings
> function which only maps MMIOs required by the host bridges leaving the
> regions, needed for vPCI traps, unmapped.
> 
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

I haven't committed because it is not clear whether this patch depends 
on earlier patches that are still under review. Can you advise?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:24:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:24:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242551.419478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0fz-0004CI-K5; Wed, 08 Dec 2021 17:24:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242551.419478; Wed, 08 Dec 2021 17:24:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv0fz-0004CB-HF; Wed, 08 Dec 2021 17:24:19 +0000
Received: by outflank-mailman (input) for mailman id 242551;
 Wed, 08 Dec 2021 17:24:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mv0fx-0004By-LR
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:24:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0fw-0002N4-LA; Wed, 08 Dec 2021 17:24:16 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv0fw-0000LT-FA; Wed, 08 Dec 2021 17:24:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OuAPBDev9/Uu9bm2z7JUAGO2V7fL7Ay6vD6bdAgeJGo=; b=55ME+ehw2fgCl0Jx6PV5Kt2NPj
	8L/6asewHDuE/OfMI7mQCYWGqnC+gFfUEluu86Uur2MumPRE9ysL2/nOpNByKKQ/tvTzjG7O5o4TF
	ExqTwGtYgW/ekBNqkS/lyNt03eXsaPe6ZWf6CMlBCdcejRvUv5BHic+Rfy/9lvL4dmSQ=;
Message-ID: <9a6473ba-e8c2-08fb-6391-617e34a6a2a6@xen.org>
Date: Wed, 8 Dec 2021 17:24:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v7 2/7] xen/arm: add pci-domain for disabled devices
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-3-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211124075942.2645445-3-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 24/11/2021 07:59, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> If a PCI host bridge device is present in the device tree, but is
> disabled, then its PCI host bridge driver was not instantiated.
> This results in the failure of the pci_get_host_bridge_segment()
> and the following panic during Xen start:
> 
> (XEN) Device tree generation failed (-22).
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Could not set up DOM0 guest OS
> (XEN) ****************************************
> 
> Fix this by adding "linux,pci-domain" property for all device tree nodes
> which have "pci" device type, so we know which segments will be used by
> the guest for which bridges.
> 
> Fixes: 4cfab4425d39 ("xen/arm: Add linux,pci-domain property for hwdom if not available.")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 17:53:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 17:53:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242559.419489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv17v-0000Cv-Sh; Wed, 08 Dec 2021 17:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242559.419489; Wed, 08 Dec 2021 17:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv17v-0000Co-PX; Wed, 08 Dec 2021 17:53:11 +0000
Received: by outflank-mailman (input) for mailman id 242559;
 Wed, 08 Dec 2021 17:53:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rXGX=QZ=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mv17v-0000Cg-3N
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 17:53:11 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b442a424-584f-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 18:53:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b442a424-584f-11ec-9d12-4777fae47e2b
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638985988;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3VE0nNlLZyDP2MmX/vYQZeWgKNo5Uy6Cr5E5oEyE//0=;
	b=yVnW54g9mJPoCSUF2QVZDU2f/xrPC/IYtzosNqipMCrUE3ublT0WkCXcFyPVrEXNiDojbG
	WW1CUtpK3VyoAq9fSgOMsdsrptfY0amXBwna/GvfaJqkTvsyAVL5hI1SpplK1OmRnxMVrX
	L5hSSsO8qCmLbj+GpNXsAcp58GYvqbj2Cej56RVnAFHSASUWcdaICSkYgNnc4MXsVS22aL
	8yNx41somh4ngRIGaL6Bs8mvddn976wAff7JClugcbIPHTmhPJafFg/+oWVQNEXsavVz8Q
	ECHb4fzOEv458qXYE4Q7kYbod/VikxJKFLy0KA5gkzv0UDl1V1bDcOOf7ps2JA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638985988;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3VE0nNlLZyDP2MmX/vYQZeWgKNo5Uy6Cr5E5oEyE//0=;
	b=tcPpBzNArpjTicF6DwnR6v7vnK+DexgwPINycnkhbizry34b4Yd5f7r99TAQsJpmyDoy7E
	NsIoYzOvgoObEZDg==
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>, iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
 <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 20/36] x86/pci/XEN: Use device MSI properties
In-Reply-To: <20211208155314.GX6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.742297272@linutronix.de>
 <20211208155314.GX6385@nvidia.com>
Date: Wed, 08 Dec 2021 18:53:07 +0100
Message-ID: <877dcf0yrg.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Dec 08 2021 at 11:53, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:
>>  static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
>>  {
>> -	struct msi_desc *msidesc = first_pci_msi_entry(dev);
>> -
>> -	if (msidesc->pci.msi_attrib.is_msix)
>> +	if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
>>  		xen_pci_frontend_disable_msix(dev);
>>  	else
>>  		xen_pci_frontend_disable_msi(dev);
>
> Same remark as for power, we have a pci_dev, so can it be
> dev->msix_enabled?

Yes, let me rework that.


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 18:10:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 18:10:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242564.419501 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv1Oa-0003Qh-DM; Wed, 08 Dec 2021 18:10:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242564.419501; Wed, 08 Dec 2021 18:10:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv1Oa-0003Qa-9d; Wed, 08 Dec 2021 18:10:24 +0000
Received: by outflank-mailman (input) for mailman id 242564;
 Wed, 08 Dec 2021 18:10:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mv1OZ-0003QU-BT
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 18:10:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv1OY-0003Eu-2W; Wed, 08 Dec 2021 18:10:22 +0000
Received: from [54.239.6.189] (helo=[192.168.13.103])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mv1OX-0003S7-Rx; Wed, 08 Dec 2021 18:10:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=de1kNqQAosCqZnXjtvT4iUR9K0c75jRK8GhwDEcLkfY=; b=qhcTMkWpkZzNja3ULI7P+7I0Bj
	OOytoTufAj5o4AYsJrHHawiZaoMb6Ja3FhePc+59OLCoh3xbesAUNvk7raozRFwC2aHePOsLKMR5Q
	4vn8r1r+xdmF5b9kvMVGDldNiafAHR1BJ+CiyUoOWoJfMSjrL1Jb3OQm971g3iJ2EcG4=;
Message-ID: <984732f0-8433-a294-acaf-c4130a2ab341@xen.org>
Date: Wed, 8 Dec 2021 18:10:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] arm/efi: Handle Xen bootargs from both xen.cfg and DT
To: Luca Fancellu <luca.fancellu@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, wei.chen@arm.com,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211206153658.49727-1-luca.fancellu@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211206153658.49727-1-luca.fancellu@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Luca,

On 06/12/2021 15:36, Luca Fancellu wrote:
> Currently the Xen UEFI stub can accept Xen boot arguments from
> the Xen configuration file using the "options=" keyword, but also
> directly from the device tree specifying xen,xen-bootargs
> property.
> 
> When the configuration file is used, device tree boot arguments
> are ignored and overwritten even if the keyword "options=" is
> not used.
> 
> This patch handle this case, if xen,xen-bootargs is found in the
> device tree, it is used for xen boot arguments regardless they
> are specified in the Xen configuration file or not.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
> ---
>   docs/misc/efi.pandoc        | 4 ++++
>   xen/arch/arm/efi/efi-boot.h | 7 +++++++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index abafb3452758..b7d99de87f15 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -249,6 +249,10 @@ UEFI stub for module loading.
>   When adding DomU modules to device tree, also add the property
>   xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
>   Otherwise, Xen will skip the config file and rely on device tree alone.
> +When using the Xen configuration file in conjunction with the device tree, you
> +can specify the Xen boot arguments in the configuration file with the "options="
> +keyword or in the device tree with the "xen,xen-bootargs" property, but be
> +aware that a device tree value has a precedence over the configuration file.

I am not sure I agree with the precedence chosen here. With UEFI 
environment it is a lot easier to update the configuration file over the 
Device-Tree. So this could be used to quickly test a command line before 
updating the Device-Tree.

Also, somewhat unrelated to this patch. Looking at the code, the command 
line is a concatenation of "options=" from the configuration file and 
the extra arguments provided on the command line used to execute the 
UEFI binary.

When using the command line from the Device-Tree, I think it would still 
make sense to append the later because it could allow a user to provide 
a single Device-Tree with extra options on the UEFI command line.

But I think this is a separate subject. So if we are going to go with 
the precedence you suggested, then we should at least clarify in the 
documentation that it will replace both.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 18:44:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 18:44:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242570.419511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv1vm-0007xT-4P; Wed, 08 Dec 2021 18:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242570.419511; Wed, 08 Dec 2021 18:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv1vm-0007xM-1Y; Wed, 08 Dec 2021 18:44:42 +0000
Received: by outflank-mailman (input) for mailman id 242570;
 Wed, 08 Dec 2021 18:44:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv1vk-0007xC-Oz; Wed, 08 Dec 2021 18:44:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv1vk-0003ni-LL; Wed, 08 Dec 2021 18:44:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv1vk-000250-Du; Wed, 08 Dec 2021 18:44:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mv1vk-00063Q-DO; Wed, 08 Dec 2021 18:44:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sEDLtkv9eHqFc2TZipIdwHiJ6yEH7tGmalS8UeiRJ8U=; b=5z3siYUwY3Bn5d/W7cmzobrYTr
	RBLV63n1+G/5hxUSKrFXDDRjmooWcCnrP4QyhYlgkl+q/WEimod3qY+/kBWAuHsEQKYfLOHGWq0fc
	cj229C2HVTkS4Giqt3ULpuzn/QTbZq3ouFqLn7B1xmuvw5mC7Q5YL5MijBT4cM0DTHh0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167231-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167231: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=85a678bf76c5aac2e40255f48ea3209ff95f150a
X-Osstest-Versions-That:
    ovmf=7c0ad2c33810ead45b7919f8f8d0e282dae52e71
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 18:44:40 +0000

flight 167231 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167231/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 85a678bf76c5aac2e40255f48ea3209ff95f150a
baseline version:
 ovmf                 7c0ad2c33810ead45b7919f8f8d0e282dae52e71

Last test of basis   167225  2021-12-07 17:43:21 Z    1 days
Testing same since   167231  2021-12-08 08:45:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaron Li <aaron.li@intel.com>
  Cheng, Gao <gao.cheng@intel.com>
  Feng, Ning <ning.feng@intel.com>
  Gao Cheng <gao.cheng@intel.com>
  Guomin Jiang <guomin.jiang@intel.com>
  Jiang, Guomin <Guomin.Jiang@intel.com>
  Li, Aaron <aaron.li@intel.com>
  Liu, Zhiguang <Zhiguang.Liu@intel.com>
  Michael D Kinney <michael.d.kinney@intel.com>
  Michael Kubacki <michael.kubacki@microsoft.com>
  Ni, Ray <ray.ni@intel.com>
  Ning Feng <ning.feng@intel.com>
  Ray Ni <ray.ni@intel.com>
  Zhiguang Liu <zhiguang.liu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7c0ad2c338..85a678bf76  85a678bf76c5aac2e40255f48ea3209ff95f150a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 18:57:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 18:57:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242577.419526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv27Z-0001QW-9G; Wed, 08 Dec 2021 18:56:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242577.419526; Wed, 08 Dec 2021 18:56:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv27Z-0001QP-5s; Wed, 08 Dec 2021 18:56:53 +0000
Received: by outflank-mailman (input) for mailman id 242577;
 Wed, 08 Dec 2021 18:56:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v8t+=QZ=epam.com=prvs=2976427baf=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mv27Y-0001QJ-24
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 18:56:52 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98cc5c9f-5858-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 19:56:49 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B8InLdn014057;
 Wed, 8 Dec 2021 18:56:45 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cu2ak00kg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 08 Dec 2021 18:56:44 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2657.eurprd03.prod.outlook.com (2603:10a6:200:90::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 18:56:37 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.012; Wed, 8 Dec 2021
 18:56:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98cc5c9f-5858-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LI0pamCOV5GsEbv85ePd9r9BMZUXn3Db35GuLP3gTy2IDi1y96gIR4unpjDRYSorr9NI3FkZoHJN/Z5F9QYQCbeYA2T7gq3QeAu0eZSjxqt20n9fov/9x+lsDoIXN1ZYwElRCcm5AreHnXsACgVAOf6UpgqoAOQkirlrjZJmKi6W2IoZYxu12++UtoEnFE09jClgBkqWliJat9t2BdnwTyvVlIuCxpIwd7hhS1RWXtTBbM+E/AmwM+FzruT+8VpA26NX4gb0aweGafPACjHPZtesIvV6zPU3qYbU/snsL9yOQ7JlNNmCRgdrjEb4eyk2PVa5bdBV+Gv1iucgzzRcQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J58lLNHVuQeVSFZcqVNk7Mt8MWo5KVwJzWtCRrISDAY=;
 b=Av+UHhD+Jp3ScWDGdDHsGspQAdf9srLyDdrkVguGJ+7PVLy3yMeD6ESrtK+z/TcVRjwAvQwMxQGMTmOiyQISlbL69W66NyteRa8mJU2ezH60shUL9ZLP7O9f7cPfc0ewPg+48MhZgoU9QgZTGV1SofcgDNQuXvr5YWT3vdQmPb853TLM6AsbbpXs+M0Q3mzMAXkIhuDkGgGn2XwW4wH5oa0CawegS1YoI6rJkz+uh173jtBSbUF1lgVsz1tqg36HxNiaeh4xg5rO0rNOoafMl57zPEbiT0XRo0xdsKv+CeFUqxj1YjdmGYu6/7k0cunZdxIbdwMCdM/v3DsHa31dmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=J58lLNHVuQeVSFZcqVNk7Mt8MWo5KVwJzWtCRrISDAY=;
 b=DjTNFljPsDFNKDLH6oDJipkzwllSwXmdNda2d+pwmlvP5/UE+YIgygSvhTU+V8FjdCZ4UIlfMjFZIpNQ/5EXC/1TJG4gbo82ZBboJmhjIJmHhvMHVeYWEaGOQ8SlxM8Bgb+3D6oRW195c2ugy/c8i+rU1Fs8l7RyI0pa356BeqfcbH53Zd7nFNCXI54iWjG+Xd5zLYXK5DDqXqJMoqPryhNVWqO83jNKGqkUryzN6srhxrJzKvR2E2qJlO4zx2obEcTmJ18zgtMoKh4xYyj4MPyvG7AMi+XKrZvRRFc6dmsWgpDnWfpbKBd9hHrYFh6gbdVhOyGDpD22Wz96zcudqQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v7 3/7] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v7 3/7] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHX4QlGdrnyiSWEoUKgem/WPhhrCqwo5LSAgAAj3wA=
Date: Wed, 8 Dec 2021 18:56:37 +0000
Message-ID: <64125328-9689-9c17-150e-5123d02ddb17@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-4-andr2000@gmail.com>
 <e5a2ca97-8983-9159-6776-5afdeab398a0@xen.org>
In-Reply-To: <e5a2ca97-8983-9159-6776-5afdeab398a0@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 333ebe59-b428-4e21-131a-08d9ba7c765a
x-ms-traffictypediagnostic: AM4PR0302MB2657:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB2657B135CAE5BC7921AE22ACE76F9@AM4PR0302MB2657.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fN9Tysb8TWQOGr+n4fLOAQfPhb4Irf04etRz9ZMIPRh1qBjMQsK7JSFwdL73lnd4P/l/bBX6BDX2C/EAUi7lsySx/1u1rsBm+1vqEDCP7Usq7irXd6wdsyrtDK2pgBZxpwEbVlurJrwKkpJwMv/XWpUhznc6EpoozZFhwWwqRoTivfV4eKYGG4ktcnC27Odip6q4TjxpgUjvYkWwnk20lc8Dxfilg0rSUVXTPWmPVXGLC+va+JxQuoH3iJlGwlROuYBjqAe9MHVQcdZ+Q9EctrCwQ/hQZwuBFE0U7BYusv7ntNL3oP65LXoIYCzM0uRcilulfiLkhTuJ4f97JgIPBvVeJcmoGvpGb6uDYrWYlP/RQuGHAcsMVLNUmAmi9xdm+FfbKyBfYCmSnqYGALZXZ7GtHaTA5IIAWfNXNd7Z/TYskVV5LRdjGda6k0+W/oD8w3F+49qAkX8Uxi8nQnrppPRjCgQAKd+a4pqd2gvWBJ9QnHby4gUi1D5S95nqeBsmwrGHz9VPD9wk/wAdWFdcevYo9CMq0c2zEsFL1cszMcmjIQ2UaqXov8/VuZfw+u4TLG0X8tPTx6MsJfx5YUVZgKibT05m5F+/50KbiG3IT8rniSwTGx/9R+o2z/cigD78WJNTxpbHN5EVx2atJmHuCIZWVjettZaOrXmeHI3yZsmLkPe1aMcWQ560fK6BEOjOx2/QgdBZa7y5paNxf1PVaAQfRmX0ObWtkEfUrTBEJXkIMu0fSavbwi0EBZpFMYOjGFLgA+xNJh6lI00vDOiQ1pJKF5eeOznvE1tnveMKRDM=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(91956017)(76116006)(186003)(7416002)(122000001)(4326008)(6506007)(26005)(8936002)(38100700002)(508600001)(66476007)(86362001)(66556008)(53546011)(71200400001)(36756003)(66946007)(316002)(2906002)(55236004)(66446008)(107886003)(54906003)(6512007)(64756008)(2616005)(5660300002)(83380400001)(6486002)(8676002)(31686004)(110136005)(31696002)(38070700005)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dUxvMkJIWDVxSW9jckJGN25MY1RKTGlrMWR3V1FaYVBPbDhFa0hkL1JRRzhY?=
 =?utf-8?B?b3ZtdGZTc0lvbmJKQkp0UThGQkhBNGNGcFJ2ZUJCejRnQWRFcktDTnVtbXRj?=
 =?utf-8?B?cWRQdTZYZmJBMFJnTjRnZlZrc1o0dXdVQXFMYkcrUmJmWWVtelowVUpBN2dC?=
 =?utf-8?B?RFdJUFN3M0ZIcXh0SGhlcDRPaWZDc0hEQWg5ejdYbXpXUHVBUS9ldndrRllJ?=
 =?utf-8?B?c3RYWDI0cTV2U3N2c29mR3BnNUxiYWE4Mjg3RnZxeXlwWHBsWUo2Q1lTNEdQ?=
 =?utf-8?B?ZGF0R2h0cjlkdTNWV0l1eFZKanBnUzZkYVZBWVVycXg3Q2M3TjJYY1hqc1Nn?=
 =?utf-8?B?SksxVmNwcXlGNlhxOFNFKzRmc1M1Kzk3S0hCalVrUC9velM4dkcraVB0TmFT?=
 =?utf-8?B?MGNKdG0zaGpIK2R6M1dZaDU5Ulp2QWJ5NnI1bi9yNXNiUHRIUnhrWFdJVkRj?=
 =?utf-8?B?RGp3QjRJcmdqMG1TUVo2U3IvL1o2UzQ2NmEyeTFMbG1WTVdzckVTL3UrUFJh?=
 =?utf-8?B?dHlCWG5DaHRqQlFpK1kwQjdtMXpCeDl4dHB2Vkl5a1JDcnFkSDN3THN2b1RL?=
 =?utf-8?B?QUs2b05OeHU0TVNRODBmNWJvbUVqckNzS1dOTU5xcnJhTi9sZy9GNXJjSis0?=
 =?utf-8?B?SVJkcEtNUWZtMWkyYXFZNGNGYk1XVkxHU0d2M2hieExPVEQ1cmU3djhyQmYx?=
 =?utf-8?B?V1JnYTgzU29MMmZPQUZMZCthQnZlVU4zYXlTa0lqMGNpeFo4SENvTUlpSDdp?=
 =?utf-8?B?Z2V6OFQySmEvRzlMcU5HaUs2dlRYTzZCeTBaeC9ZaGJZUDltRE1JZjRjTXhH?=
 =?utf-8?B?OHEvZ1NCa29NOU5YVzM3dGI0eXE3Z3RCbkkvVDBac0dpNzJVUUlGeVl6Mlpz?=
 =?utf-8?B?cER6NWFaREZkYnRLTnp4WWFmSTlVK1FiaXppSm9xUXJhQTN0MnphVkM0Z29N?=
 =?utf-8?B?NytVcExWdjRBd3pzYVdxcDlKMWduZkVncGd0YU9qcTFKQktLNHF2TVYyeTNW?=
 =?utf-8?B?NkdtMnEyWmJ6Z3VXeGZobHNEUkluNVVrdnVlQldDQm9FOEV6OUsrNVlEU3oz?=
 =?utf-8?B?YnMzNzdhc1FLVjZORnVZeXowY2d4MndHVkxoTHFuVEtPaDNtOUNQdlZhZ0pS?=
 =?utf-8?B?OWluK1NSbVBsd1greU5KeVNJVm5zQTM0M2pHamxiZ3pEK3dwTFhuam5qbm5y?=
 =?utf-8?B?REQ2aSt5Q3pnemkxWVRhQzV3SGYvc2Z3eW11bjhrd21EcElkUUs2WkltUGlT?=
 =?utf-8?B?VFllUFNBUTgxZlZQN3NIeFFNYnFvODVRTFkydjBFRDBxRWl5M2I3a0I4aFUy?=
 =?utf-8?B?Ykw5SjFWdVZieEh4a1Z0NllnTW01Qm12SWt3cG4rU3MxNUwwSVRXeUNIM1Zi?=
 =?utf-8?B?NElyN2o0aE9IS1NwTnVJOU1SanBKY2RQK2VLZDdjNmlrcThRZ3FhTVRGTStZ?=
 =?utf-8?B?bUhHYTdzblZsME9ESlhsdy9jTnAvRDdoN2Q5eUk0SzJpblNJZ2FYeWJUSHg5?=
 =?utf-8?B?ZGtVYU13cDhORkw3K3JiQ3B5NWJXK1BidGRXeXEvQndEbFZ4NkxERHB4dHhr?=
 =?utf-8?B?ZFdHSkxBd0VZNW5TK0FCZU1MbjdkckU4ZFcwVzZaSFdod0IwNVN2ZitqczlN?=
 =?utf-8?B?c3BEK1BaaUczUGxqWVAxK3ROaFpvMGxMSjNUcEMzV3ZXU2dsb2lCazBYWlpJ?=
 =?utf-8?B?UFBuUit3c1NmUmVQL2JxcDROcFI4YWlHRE1SQkFLTEZLc1ZSYUpnTlNSV1Fm?=
 =?utf-8?B?UldWcUZ0TDN1aTk0bGoxLzlVb0NYbnNzUDdsMk8yUEs1T0psU3dSbFN1NlZt?=
 =?utf-8?B?TkdWQVdISnpKRFRrMERKTW5SVVVUTXNnUDVNVEpMQktHQWRQMG84UmxyUU1w?=
 =?utf-8?B?T3EwQWh1TUVMcHVVc1p6emdpbzkwNW5qbU9XN21CNXVFWVkxS1NWK1AzNlMv?=
 =?utf-8?B?QlUrUjl3ZTIyaU1Zak1rbzg1T1dMb3NFbXBIeWd0dW05MlcycENoby82MmZr?=
 =?utf-8?B?RnN4ZGhkaTl6UjZ2NjdEcnpqTW5adElUL1NERmhDWFlLRENaYlJnSVJrd0Nl?=
 =?utf-8?B?QTl6TGo5MEl0QnVQa01URDdoNDF1bE5qZ2NhWVVxQkd1OWRCQm9qN3VyL0lE?=
 =?utf-8?B?RlVxUnJjYWE2dVhici9EUlJvbHJRcTFYQUdwLzZWaHNwenhZc0dpbFRiWXd5?=
 =?utf-8?B?bGp3ckNMUkt6WmFRVWpHVHhHa2JNN0VoNTFxMHZ5cU1qQ1NzZklIeDF0SHRM?=
 =?utf-8?B?Y3hzTGVwT2hwNDBhbHQvS1BNVGtxNnB3d3RVVEpNVEFBb0liR1IyOGNRWVh3?=
 =?utf-8?B?WjVHZWdDcTJtdkNkN3JKWEp4cHFUbFpxSWdOaXBBOXAzV3QxK0srZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <64A383C425A2F64FB3765502AA609145@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 333ebe59-b428-4e21-131a-08d9ba7c765a
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 18:56:37.3191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hJvB9O6l83kFliNTxl3deW7kyogJTyVqvbLtXUG8Ou8/WA9yohmLH1geqimaSbm0DhP4c50KsXtw5acCxf2cr/8gFQiibW/FbM+Ba3xFAx38rvLckUFnK5zqT3OnAgrx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2657
X-Proofpoint-GUID: l7zdHO76jzvH5A8_x-Sn8ijX5X-WUBGX
X-Proofpoint-ORIG-GUID: l7zdHO76jzvH5A8_x-Sn8ijX5X-WUBGX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-08_07,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 bulkscore=0 spamscore=0 lowpriorityscore=0
 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112080107

SGksIEp1bGllbiENCg0KT24gMDguMTIuMjEgMTg6NDgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAyNC8xMS8yMDIxIDA3OjU5LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBJbiBvcmRlciBmb3IgdlBDSSB0byB3
b3JrIGl0IG5lZWRzIHRvIG1haW50YWluIGd1ZXN0IGFuZCBoYXJkd2FyZQ0KPj4gZG9tYWluJ3Mg
dmlld3Mgb2YgdGhlIGNvbmZpZ3VyYXRpb24gc3BhY2UuIEZvciBleGFtcGxlLCBCQVJzIGFuZA0K
Pj4gQ09NTUFORCByZWdpc3RlcnMgcmVxdWlyZSBlbXVsYXRpb24gZm9yIGd1ZXN0cyBhbmQgdGhl
IGd1ZXN0IHZpZXcNCj4+IG9mIHRoZSByZWdpc3RlcnMgbmVlZHMgdG8gYmUgaW4gc3luYyB3aXRo
IHRoZSByZWFsIGNvbnRlbnRzIG9mIHRoZQ0KPj4gcmVsZXZhbnQgcmVnaXN0ZXJzLiBGb3IgdGhh
dCBFQ0FNIGFkZHJlc3Mgc3BhY2UgbmVlZHMgdG8gYWxzbyBiZQ0KPj4gdHJhcHBlZCBmb3IgdGhl
IGhhcmR3YXJlIGRvbWFpbiwgc28gd2UgbmVlZCB0byBpbXBsZW1lbnQgUENJIGhvc3QNCj4+IGJy
aWRnZSBzcGVjaWZpYyBjYWxsYmFja3MgdG8gcHJvcGVybHkgc2V0dXAgTU1JTyBoYW5kbGVycyBm
b3IgdGhvc2UNCj4+IHJhbmdlcyBkZXBlbmRpbmcgb24gcGFydGljdWxhciBob3N0IGJyaWRnZSBp
bXBsZW1lbnRhdGlvbi4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNo
ZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IFNpbmNl
IHY2Og0KPj4gLSBlbGltaW5hdGUgcGNpX2hvc3RfZ2V0X251bV9icmlkZ2VzIGFuZCBtYWtlIHBj
aV9ob3N0X2l0ZXJhdGVfYnJpZGdlcw0KPj4gwqDCoCByZXR1cm4gdGhlIGNvdW50DQo+PiAtIGV4
dGVuZCBjb21tZW50IGluIGRvbWFpbl92cGNpX2luaXQNCj4+IC0gcmVtb3ZlIG5vdCB5ZXQgcmVs
ZXZhbnQgY29kZSBmb3IgbnVtIE1NSU9zIGFuZCB2aXJ0dWFsIGJ1cyB0b3BvbG9neQ0KPj4gLSBh
ZGQgZXh0cmEgY2hlY2sgZm9yIGhhc192cGNpIGluIGRvbWFpbl92cGNpX2dldF9udW1fbW1pb19o
YW5kbGVycw0KPj4gLSByZW1vdmUgY29kZSB0aGF0IGZpeGVzIG51bSBNTUlPcyBmb3IgZ3Vlc3Qg
ZG9tYWluIGFzIGl0IGRvZXNuJ3QgYmVsb25nDQo+PiDCoMKgIHRvIHRoaXMgcGF0Y2gNCj4+IFNp
bmNlIHY1Og0KPj4gLSBhZGQgdnBjaV9zYmRmX2Zyb21fZ3BhIGhlbHBlciBmb3IgZ3BhIHRvIFNC
REYgdHJhbnNsYXRpb24NCj4+IC0gdGFrZSBicmlkZ2UncyBidXMgc3RhcnQgaW50byBhY2NvdW50
IHdoaWxlIGNhbGN1bGF0aW5nIFNCREYNCj4+IFNpbmNlIHY0Og0KPj4gLSB1bnNpZ25lZCBpbnQg
Zm9yIGZ1bmN0aW9ucyB3b3JraW5nIHdpdGggY291bnQNCj4+IC0gZ2F0ZSBudW1iZXIgb2YgTU1J
TyBoYW5kbGVycyBuZWVkZWQgZm9yIENPTkZJR19IQVNfUENJX01TSQ0KPj4gwqDCoCBhbmQgZml4
IHRoZWlyIG51bWJlciwgZS5nLiBzaW5nbGUgaGFuZGxlciBmb3IgUEJBIGFuZA0KPj4gwqDCoCBN
U0ktWCB0YWJsZXMgKFJvZ2VyKQ0KPj4gLSByZS13b3JrIGNvZGUgZm9yIGFzc2lnbmluZyBNTUlP
IGhhbmRsZXJzIHRvIGJlIHNpbXBsZXINCj4+IMKgwqAgYW5kIGFjY291bnQgb24gdGhlIGZhY3Qg
dGhhdCB0aGVyZSBjb3VsZCBtdWx0aXBsZSBob3N0IGJyaWRnZXMNCj4+IMKgwqAgZXhpc3QgZm9y
IHRoZSBod2RvbQ0KPj4gU2luY2UgdjM6DQo+PiAtIGZpeGVkIGNvbW1lbnQgZm9ybWF0dGluZw0K
Pj4gU2luY2UgdjI6DQo+PiAtIHJlbW92ZWQgdW5uZWVkZWQgYXNzaWdubWVudCAoY291bnQgPSAw
KQ0KPj4gLSByZW1vdmVkIHVubmVlZGVkIGhlYWRlciBpbmNsdXNpb24NCj4+IC0gdXBkYXRlIGNv
bW1pdCBtZXNzYWdlDQo+PiBTaW5jZSB2MToNCj4+IMKgIC0gRHluYW1pY2FsbHkgY2FsY3VsYXRl
IHRoZSBudW1iZXIgb2YgTU1JTyBoYW5kbGVycyByZXF1aXJlZCBmb3IgdlBDSQ0KPj4gwqDCoMKg
IGFuZCB1cGRhdGUgdGhlIHRvdGFsIG51bWJlciBhY2NvcmRpbmdseQ0KPj4gwqAgLSBzL2NsYi9j
Yg0KPj4gwqAgLSBEbyBub3QgaW50cm9kdWNlIGEgbmV3IGNhbGxiYWNrIGZvciBNTUlPIGhhbmRs
ZXIgc2V0dXANCj4+IC0tLQ0KPj4gwqAgeGVuL2FyY2gvYXJtL2RvbWFpbi5jwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqAgfMKgIDIgKw0KPj4gwqAgeGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC1j
b21tb24uYyB8IDE3ICsrKysrKysNCj4+IMKgIHhlbi9hcmNoL2FybS92cGNpLmPCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAgfCA3OSArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0N
Cj4+IMKgIHhlbi9hcmNoL2FybS92cGNpLmjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
fMKgIDYgKysrDQo+PiDCoCB4ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5owqDCoMKgwqDCoMKgwqDC
oMKgIHzCoCA0ICsrDQo+PiDCoCA1IGZpbGVzIGNoYW5nZWQsIDEwMCBpbnNlcnRpb25zKCspLCA4
IGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZG9tYWluLmMg
Yi94ZW4vYXJjaC9hcm0vZG9tYWluLmMNCj4+IGluZGV4IDk2ZTFiMjM1NTAxZC4uOTJhNmM1MDll
NWM1IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jDQo+PiArKysgYi94ZW4v
YXJjaC9hcm0vZG9tYWluLmMNCj4+IEBAIC03MzksNiArNzM5LDggQEAgaW50IGFyY2hfZG9tYWlu
X2NyZWF0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPj4gwqDCoMKgwqDCoCBpZiAoIChyYyA9IGRvbWFp
bl92Z2ljX3JlZ2lzdGVyKGQsICZjb3VudCkpICE9IDAgKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKg
IGdvdG8gZmFpbDsNCj4+IMKgICvCoMKgwqAgY291bnQgKz0gZG9tYWluX3ZwY2lfZ2V0X251bV9t
bWlvX2hhbmRsZXJzKGQpOw0KPj4gKw0KPj4gwqDCoMKgwqDCoCBpZiAoIChyYyA9IGRvbWFpbl9p
b19pbml0KGQsIGNvdW50ICsgTUFYX0lPX0hBTkRMRVIpKSAhPSAwICkNCj4+IMKgwqDCoMKgwqDC
oMKgwqDCoCBnb3RvIGZhaWw7DQo+PiDCoCBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3BjaS9w
Y2ktaG9zdC1jb21tb24uYyBiL3hlbi9hcmNoL2FybS9wY2kvcGNpLWhvc3QtY29tbW9uLmMNCj4+
IGluZGV4IDk2NTNiOTJiNWIyZS4uMThiMDlkNWU2ZjEwIDEwMDY0NA0KPj4gLS0tIGEveGVuL2Fy
Y2gvYXJtL3BjaS9wY2ktaG9zdC1jb21tb24uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL3BjaS9w
Y2ktaG9zdC1jb21tb24uYw0KPj4gQEAgLTI5Niw2ICsyOTYsMjMgQEAgaW50IHBjaV9nZXRfaG9z
dF9icmlkZ2Vfc2VnbWVudChjb25zdCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKm5vZGUsDQo+PiDC
oMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOw0KPj4gwqAgfQ0KPj4gwqAgK2ludCBwY2lfaG9zdF9p
dGVyYXRlX2JyaWRnZXNfYW5kX2NvdW50KHN0cnVjdCBkb21haW4gKmQsDQo+PiArwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBpbnQgKCpjYikoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdl
KSkNCj4+ICt7DQo+PiArwqDCoMKgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZTsNCj4+
ICvCoMKgwqAgaW50IGVyciwgY291bnQgPSAwOw0KPg0KPiBOSVQ6IGVyciBpcyBvbmx5IHVzZWQg
d2l0aGluIHRoZSBsb29wLCBzbyBJIHdvdWxkIHN1Z2dlc3QgdG8gbW92ZSB0aGUgZGVjbGFydGlv
biB2YXJpYWJsZSBpbnNpZGUgdGhlIGxvb3AuDQpZZXMsIGFuZCBpdCBiZXR0ZXIgc291bmRzIGlm
IHMvZXJyL3JldA0KPg0KPj4gKw0KPj4gK8KgwqDCoCBsaXN0X2Zvcl9lYWNoX2VudHJ5KCBicmlk
Z2UsICZwY2lfaG9zdF9icmlkZ2VzLCBub2RlICkNCj4+ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKg
wqDCoMKgIGVyciA9IGNiKGQsIGJyaWRnZSk7DQo+PiArwqDCoMKgwqDCoMKgwqAgaWYgKCBlcnIg
KQ0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIGVycjsNCj4+ICvCoMKgwqDCoMKg
wqDCoCBjb3VudCArPSBlcnI7DQo+DQo+IFNvbWV0aGluZyBsb29rcyB3cm9uZyBoZXJlLiBZb3Ug
Y2hlY2sgdGhhdCBlcnIgaXMgbm9uLXplcm8gYW5kIGJhaWwgb3V0LiBTbyBlcnIgd291bGQgYmUg
MCBhbmQgYnkgZXh0ZW5kIHlvdSB3b3VsZCBhbHdheXMgcmV0dXJuIDAgaW4gc3VjY2Vzcz8NCklu
ZGVlZCwgSSBuZWVkICJpZiAoIGVyciA8IDAgKSIgaGVyZQ0KDQo+DQo+PiArwqDCoMKgIH0NCj4+
ICvCoMKgwqAgcmV0dXJuIGNvdW50Ow0KPj4gK30NCj4+ICsNCj4+IMKgIC8qDQo+PiDCoMKgICog
TG9jYWwgdmFyaWFibGVzOg0KPj4gwqDCoCAqIG1vZGU6IEMNCj4+IGRpZmYgLS1naXQgYS94ZW4v
YXJjaC9hcm0vdnBjaS5jIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gaW5kZXggMjNmNDUzODZm
NGIzLi5jY2Q5OThkOGRiYTIgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+
PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBAQCAtMTYsMTYgKzE2LDMxIEBADQo+PiDC
oCDCoCAjaW5jbHVkZSA8YXNtL21taW8uaD4NCj4+IMKgICtzdGF0aWMgcGNpX3NiZGZfdCB2cGNp
X3NiZGZfZnJvbV9ncGEoY29uc3Qgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlLA0KPj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoCBwYWRkcl90IGdwYSkNCj4+ICt7DQo+PiArwqDCoMKgIHBjaV9zYmRm
X3Qgc2JkZjsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCBicmlkZ2UgKQ0KPj4gK8KgwqDCoCB7DQo+
PiArwqDCoMKgwqDCoMKgwqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihncGEgLSBicmlkZ2Ut
PmNmZy0+cGh5c19hZGRyKTsNCj4+ICvCoMKgwqDCoMKgwqDCoCBzYmRmLnNlZyA9IGJyaWRnZS0+
c2VnbWVudDsNCj4+ICvCoMKgwqDCoMKgwqDCoCBzYmRmLmJ1cyArPSBicmlkZ2UtPmNmZy0+YnVz
bl9zdGFydDsNCj4+ICvCoMKgwqAgfQ0KPj4gK8KgwqDCoCBlbHNlDQo+PiArwqDCoMKgwqDCoMKg
wqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihncGEgLSBHVUVTVF9WUENJX0VDQU1fQkFTRSk7
DQo+PiArDQo+PiArwqDCoMKgIHJldHVybiBzYmRmOw0KPj4gK30NCj4+ICsNCj4+IMKgIHN0YXRp
YyBpbnQgdnBjaV9tbWlvX3JlYWQoc3RydWN0IHZjcHUgKnYsIG1taW9faW5mb190ICppbmZvLA0K
Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
IHJlZ2lzdGVyX3QgKnIsIHZvaWQgKnApDQo+PiDCoCB7DQo+PiAtwqDCoMKgIHBjaV9zYmRmX3Qg
c2JkZjsNCj4+ICvCoMKgwqAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlID0gcDsNCj4+
ICvCoMKgwqAgcGNpX3NiZGZfdCBzYmRmID0gdnBjaV9zYmRmX2Zyb21fZ3BhKGJyaWRnZSwgaW5m
by0+Z3BhKTsNCj4+IMKgwqDCoMKgwqAgLyogZGF0YSBpcyBuZWVkZWQgdG8gcHJldmVudCBhIHBv
aW50ZXIgY2FzdCBvbiAzMmJpdCAqLw0KPj4gwqDCoMKgwqDCoCB1bnNpZ25lZCBsb25nIGRhdGE7
DQo+PiDCoCAtwqDCoMKgIC8qIFdlIGlnbm9yZSBzZWdtZW50IHBhcnQgYW5kIGFsd2F5cyBoYW5k
bGUgc2VnbWVudCAwICovDQo+PiAtwqDCoMKgIHNiZGYuc2JkZiA9IFZQQ0lfRUNBTV9CREYoaW5m
by0+Z3BhIC0gR1VFU1RfVlBDSV9FQ0FNX0JBU0UpOw0KPj4gLQ0KPj4gwqDCoMKgwqDCoCBpZiAo
IHZwY2lfZWNhbV9yZWFkKHNiZGYsIEVDQU1fUkVHX09GRlNFVChpbmZvLT5ncGEpLA0KPj4gwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMVUgPDwgaW5m
by0+ZGFidC5zaXplLCAmZGF0YSkgKQ0KPj4gwqDCoMKgwqDCoCB7DQo+PiBAQCAtNDEsMTAgKzU2
LDggQEAgc3RhdGljIGludCB2cGNpX21taW9fcmVhZChzdHJ1Y3QgdmNwdSAqdiwgbW1pb19pbmZv
X3QgKmluZm8sDQo+PiDCoCBzdGF0aWMgaW50IHZwY2lfbW1pb193cml0ZShzdHJ1Y3QgdmNwdSAq
diwgbW1pb19pbmZvX3QgKmluZm8sDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZWdpc3Rlcl90IHIsIHZvaWQgKnApDQo+PiDCoCB7
DQo+PiAtwqDCoMKgIHBjaV9zYmRmX3Qgc2JkZjsNCj4+IC0NCj4+IC3CoMKgwqAgLyogV2UgaWdu
b3JlIHNlZ21lbnQgcGFydCBhbmQgYWx3YXlzIGhhbmRsZSBzZWdtZW50IDAgKi8NCj4+IC3CoMKg
wqAgc2JkZi5zYmRmID0gVlBDSV9FQ0FNX0JERihpbmZvLT5ncGEgLSBHVUVTVF9WUENJX0VDQU1f
QkFTRSk7DQo+PiArwqDCoMKgIHN0cnVjdCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSA9IHA7DQo+
PiArwqDCoMKgIHBjaV9zYmRmX3Qgc2JkZiA9IHZwY2lfc2JkZl9mcm9tX2dwYShicmlkZ2UsIGlu
Zm8tPmdwYSk7DQo+PiDCoCDCoMKgwqDCoMKgIHJldHVybiB2cGNpX2VjYW1fd3JpdGUoc2JkZiwg
RUNBTV9SRUdfT0ZGU0VUKGluZm8tPmdwYSksDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAxVSA8PCBpbmZvLT5kYWJ0LnNpemUsIHIp
Ow0KPj4gQEAgLTU1LDE3ICs2OCw2NyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1taW9faGFuZGxl
cl9vcHMgdnBjaV9tbWlvX2hhbmRsZXIgPSB7DQo+PiDCoMKgwqDCoMKgIC53cml0ZSA9IHZwY2lf
bW1pb193cml0ZSwNCj4+IMKgIH07DQo+PiDCoCArc3RhdGljIGludCB2cGNpX3NldHVwX21taW9f
aGFuZGxlcl9jYihzdHJ1Y3QgZG9tYWluICpkLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVj
dCBwY2lfaG9zdF9icmlkZ2UgKmJyaWRnZSkNCj4+ICt7DQo+PiArwqDCoMKgIHN0cnVjdCBwY2lf
Y29uZmlnX3dpbmRvdyAqY2ZnID0gYnJpZGdlLT5jZmc7DQo+PiArDQo+PiArwqDCoMKgIHJlZ2lz
dGVyX21taW9faGFuZGxlcihkLCAmdnBjaV9tbWlvX2hhbmRsZXIsDQo+PiArwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2ZnLT5waHlzX2FkZHIsIGNm
Zy0+c2l6ZSwgYnJpZGdlKTsNCj4+ICsNCj4+ICvCoMKgwqAgLyogV2UgaGF2ZSByZWdpc3RlcmVk
IGEgc2luZ2xlIE1NSU8gaGFuZGxlci4gKi8NCj4+ICvCoMKgwqAgcmV0dXJuIDE7DQo+PiArfQ0K
Pj4gKw0KPj4gwqAgaW50IGRvbWFpbl92cGNpX2luaXQoc3RydWN0IGRvbWFpbiAqZCkNCj4+IMKg
IHsNCj4+IMKgwqDCoMKgwqAgaWYgKCAhaGFzX3ZwY2koZCkgKQ0KPj4gwqDCoMKgwqDCoMKgwqDC
oMKgIHJldHVybiAwOw0KPj4gwqAgK8KgwqDCoCAvKg0KPj4gK8KgwqDCoMKgICogVGhlIGhhcmR3
YXJlIGRvbWFpbiBnZXRzIGFzIG1hbnkgTU1JT3MgYXMgcmVxdWlyZWQgYnkgdGhlDQo+PiArwqDC
oMKgwqAgKiBwaHlzaWNhbCBob3N0IGJyaWRnZS4NCj4+ICvCoMKgwqDCoCAqIEd1ZXN0cyBnZXQg
dGhlIHZpcnR1YWwgcGxhdGZvcm0gbGF5b3V0OiBvbmUgdmlydHVhbCBob3N0IGJyaWRnZSBmb3Ig
bm93Lg0KPj4gK8KgwqDCoMKgICovDQo+PiArwqDCoMKgIGlmICggaXNfaGFyZHdhcmVfZG9tYWlu
KGQpICkNCj4+ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKgwqDCoMKgIGludCBjb3VudDsNCj4+ICsN
Cj4+ICvCoMKgwqDCoMKgwqDCoCBjb3VudCA9IHBjaV9ob3N0X2l0ZXJhdGVfYnJpZGdlc19hbmRf
Y291bnQoZCwgdnBjaV9zZXR1cF9tbWlvX2hhbmRsZXJfY2IpOw0KPj4gK8KgwqDCoMKgwqDCoMKg
IGlmICggY291bnQgPCAwICkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBjb3Vu
dDsNCj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsNCj4NCj4gVGhpcyBjb3VsZCBi
ZSBzaW1wbGlmaWVkIHRvICJyZXR1cm4gKGNvdW50IDwgMCkgPyBjb3VudCA6IDA7Ii4gQWx0aG91
Z2ggbXkgcHJlZmVyZW5jZSB3b3VsZCBiZSB0byBtb3ZlIHRoZSBndWVzdCBwYXJ0IGluIGFuIGVs
c2UuDQpPaw0KDQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCj4NCj4+ICvCoMKgwqAgfQ0KPj4gKw0K
Pj4gwqDCoMKgwqDCoCByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoZCwgJnZwY2lfbW1pb19oYW5kbGVy
LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgIEdVRVNUX1ZQQ0lfRUNBTV9CQVNFLCBHVUVTVF9WUENJX0VDQU1fU0laRSwgTlVMTCk7DQo+
PiDCoCDCoMKgwqDCoMKgIHJldHVybiAwOw0KPj4gwqAgfQ0KPj4gwqAgK3N0YXRpYyBpbnQgdnBj
aV9nZXRfbnVtX2hhbmRsZXJzX2NiKHN0cnVjdCBkb21haW4gKmQsDQo+PiArwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oCBzdHJ1Y3QgcGNpX2hvc3RfYnJpZGdlICpicmlkZ2UpDQo+PiArew0KPj4gK8KgwqDCoCAvKiBF
YWNoIGJyaWRnZSBoYXMgYSBzaW5nbGUgTU1JTyBoYW5kbGVyIGZvciB0aGUgY29uZmlndXJhdGlv
biBzcGFjZS4gKi8NCj4+ICvCoMKgwqAgcmV0dXJuIDE7DQo+PiArfQ0KPj4gKw0KPj4gK3Vuc2ln
bmVkIGludCBkb21haW5fdnBjaV9nZXRfbnVtX21taW9faGFuZGxlcnMoc3RydWN0IGRvbWFpbiAq
ZCkNCj4+ICt7DQo+PiArwqDCoMKgIGlmICggIWhhc192cGNpKGQpICkNCj4+ICvCoMKgwqDCoMKg
wqDCoCByZXR1cm4gMDsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4o
ZCkgKQ0KPj4gK8KgwqDCoCB7DQo+PiArwqDCoMKgwqDCoMKgwqAgaW50IHJldCA9IHBjaV9ob3N0
X2l0ZXJhdGVfYnJpZGdlc19hbmRfY291bnQoZCwgdnBjaV9nZXRfbnVtX2hhbmRsZXJzX2NiKTsN
Cj4+ICsNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmV0IDwgMCA/IDAgOiByZXQ7DQo+PiAr
wqDCoMKgIH0NCj4+ICsNCj4+ICvCoMKgwqAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4gwqAg
LyoNCj4+IMKgwqAgKiBMb2NhbCB2YXJpYWJsZXM6DQo+PiDCoMKgICogbW9kZTogQw0KPj4gZGlm
ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92cGNpLmggYi94ZW4vYXJjaC9hcm0vdnBjaS5oDQo+PiBp
bmRleCBkOGE3YjBlM2U4MDIuLjNjNzEzZjNmY2RiNSAxMDA2NDQNCj4+IC0tLSBhL3hlbi9hcmNo
L2FybS92cGNpLmgNCj4+ICsrKyBiL3hlbi9hcmNoL2FybS92cGNpLmgNCj4+IEBAIC0xNywxMSAr
MTcsMTcgQEANCj4+IMKgIMKgICNpZmRlZiBDT05GSUdfSEFTX1ZQQ0kNCj4+IMKgIGludCBkb21h
aW5fdnBjaV9pbml0KHN0cnVjdCBkb21haW4gKmQpOw0KPj4gK3Vuc2lnbmVkIGludCBkb21haW5f
dnBjaV9nZXRfbnVtX21taW9faGFuZGxlcnMoc3RydWN0IGRvbWFpbiAqZCk7DQo+PiDCoCAjZWxz
ZQ0KPj4gwqAgc3RhdGljIGlubGluZSBpbnQgZG9tYWluX3ZwY2lfaW5pdChzdHJ1Y3QgZG9tYWlu
ICpkKQ0KPj4gwqAgew0KPj4gwqDCoMKgwqDCoCByZXR1cm4gMDsNCj4+IMKgIH0NCj4+ICsNCj4+
ICtzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBkb21haW5fdnBjaV9nZXRfbnVtX21taW9faGFu
ZGxlcnMoc3RydWN0IGRvbWFpbiAqZCkNCj4+ICt7DQo+PiArwqDCoMKgIHJldHVybiAwOw0KPj4g
K30NCj4+IMKgICNlbmRpZg0KPj4gwqAgwqAgI2VuZGlmIC8qIF9fQVJDSF9BUk1fVlBDSV9IX18g
Ki8NCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oIGIveGVuL2luY2x1
ZGUvYXNtLWFybS9wY2kuaA0KPj4gaW5kZXggYzIwZWJhNjQzZDg2Li40Mjc4ZDY2ZTVlYjkgMTAw
NjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3BjaS5oDQo+PiArKysgYi94ZW4vaW5j
bHVkZS9hc20tYXJtL3BjaS5oDQo+PiBAQCAtMTEwLDYgKzExMCwxMCBAQCB2b2lkIGFyY2hfcGNp
X2luaXRfcGRldihzdHJ1Y3QgcGNpX2RldiAqcGRldik7DQo+PiDCoCDCoCBpbnQgcGNpX2dldF9u
ZXdfZG9tYWluX25yKHZvaWQpOw0KPj4gwqAgK2ludCBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXNf
YW5kX2NvdW50KHN0cnVjdCBkb21haW4gKmQsDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpbnQg
KCpjYikoc3RydWN0IGRvbWFpbiAqZCwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqAgc3RydWN0IHBjaV9ob3N0X2JyaWRnZSAqYnJpZGdlKSk7DQo+PiArDQo+PiDC
oCAjZWxzZcKgwqAgLyohQ09ORklHX0hBU19QQ0kqLw0KPj4gwqAgwqAgc3RydWN0IGFyY2hfcGNp
X2RldiB7IH07DQo+Pg0KPg0KPiBDaGVlcnMsDQo+DQo=


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 18:58:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 18:58:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242582.419537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv28q-0002Vt-ON; Wed, 08 Dec 2021 18:58:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242582.419537; Wed, 08 Dec 2021 18:58:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv28q-0002Vm-KR; Wed, 08 Dec 2021 18:58:12 +0000
Received: by outflank-mailman (input) for mailman id 242582;
 Wed, 08 Dec 2021 18:58:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v8t+=QZ=epam.com=prvs=2976427baf=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mv28p-0002V9-CB
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 18:58:11 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8e041b5-5858-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 19:58:10 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B8IIcHf017591;
 Wed, 8 Dec 2021 18:58:00 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cu1v5r3c7-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 08 Dec 2021 18:57:59 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4756.eurprd03.prod.outlook.com (2603:10a6:208:ce::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Wed, 8 Dec
 2021 18:57:54 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.012; Wed, 8 Dec 2021
 18:57:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8e041b5-5858-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Tm3SnDGL8Iz+bz2RZGeUUOQNEgIyla1pVH/K04IbZTe/K05q+UZUHYC8gRGxgY+GFwkpmpEbmYSaaSJxDvf/qK8/u7nS0vtVQnxcSWebWNsBqqSJUxyLgbJFcMOP1KVnyH+15fw4Vn7ynrRQC9VGGgqoUIDbF+9cPHH5fvikfyoS1d0+jtALWCmCYGMqt05GL7G6rQIBL1FWG1353nskIW/Tu6uzo27/l1WN5HShqVEtI99ZJnvTRKQK7DD6vQulvhMGXU7dxah6QQsG6l0aH20KMEh1bYKkquJRaiLQNrhry1P1JYJX3pewPwJ92DgkIXQ0keMaKJLuwYeQ3IChOg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HtwYOVErdYcnDE29dzp/1xiMaWcfQH+VYOP7Z9qTzPg=;
 b=Xtl2k1xkkVfyzwfyg+sbA8EZa/YXX1Vwb6/4fQVbGj1dCSjqxlm4x2ZoddGd6XCabXwsf1VyZet5RuunI37oXthmPurQQfe8+rWPC9LuOgnrATgX3bEgg3nl6M9zF5eAhPTqMO7BDqq6fUzi33wWZrx7UzS/m/FvaX/jT3BXQ5Ts2k1WhcI7TAV92Pd5iD2WQtcIlNP0Hp9go54ECV93SFtzjDQQPXXbhzUK22kbog0tln8066cySFN2SQZhZsJgfltn/wi3WjJIR7a28eC0O+0YTWPlZ1B7KPNrYo4VLyssJ0Khtc6GoV9rkbLRdxVuSKv8Kp+u363g+KOfGmOoFw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HtwYOVErdYcnDE29dzp/1xiMaWcfQH+VYOP7Z9qTzPg=;
 b=fz5WiMITSSfp58dUgeYcXpfLhL+/Std80BR522mvxN4XLXixUsml1JaM7fbzERPq6SG8x6NU5Vs3KkBT6I7Weql9V0fjgCmL3ts6bJYwfZvesvzJ7Fg81qntrgK3P+ZOmLsBYe9tGOA+2nBEHfLn7ZyvqNS8rZnXHY4x3itGXnh2Uj8Bs/W7/ih+zTgo/eGVDSFnaXoedDjCWu2neSkfNzly0qzRbBVrQccv4cjy2SIHY27V9c/TeUFLDORcpk69O0Z1g0M8TqoN94jGQWDesmYiA3UdYRXJs5yF4EVR21bPuFoc8LBLUJBxgBlFcsSVYP8Wcq5YbE+HaKIyDyrm6Q==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Topic: [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Index: AQHX4QlHTkep1sCXwU6sAzOhbUDnn6wo5hsAgAAi1QA=
Date: Wed, 8 Dec 2021 18:57:54 +0000
Message-ID: <de027721-5240-cf79-b932-4a1e36077e41@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-5-andr2000@gmail.com>
 <77326c24-9d2a-22ef-00cf-b89f1e70eaaf@xen.org>
In-Reply-To: <77326c24-9d2a-22ef-00cf-b89f1e70eaaf@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 258fa729-035e-4b8c-5441-08d9ba7ca48b
x-ms-traffictypediagnostic: AM0PR03MB4756:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB475634B5B65E285178C1A975E76F9@AM0PR03MB4756.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 8wAg4pmHW30YVTEwme4vip0vSxqjPw7XwZH8ZLPMS4gHLb9+xvGdUDtVEZpdhdMB3PPLLpHKkc2WAi0F9qOriS8aQLwj1RHM0CUpqatu9d49Z5SPX8mK+Xmkn/ou+LDznnlBDb3Q10opwbmjtT1TrpwKeWQo3JK9e8pmV/aPYRbycz2rBKXvQJi7JLzi46hmHWzMUCy4/cKRGBtmeGaXOLVLF4Vf8G+DY0F8SA7fE8CaychmbjN5qPFixpy5KywCQyiJAY3omRpz1aTbqfrC9R1SyMneupP1LlWGsEfg/qmDoYnITL/Pmyo7MskUB1AzROWsculBp0PYkLG5qXg1HnmSQ0KMwEM+yvTxUP+GeR8gtitXKylx/uWgawAtJBmlL56vTuq/Tn3A3S+7HwzBySoevYygRHMwoUA2wuUjMbw3SdE6Le8cdTdInAS9hocFBtaH2LPQD2gW6kdXAPBapha1hkuXWZ8u047hbol7UQ70tM84nckBnnMYr+gwiJHtEkApmm89riwBk8AdJypyOVDdFsaU3S+RLLj1ya7cGKtZV7K0KXky2OJggBjahjbDorvZWQ6yeUCxOxv4rweglOIjuU2qboMq9HrvSA/EldObJaZ3jvWxj4y3o4ON4L56SIhgpVIl1ImFQX7fckD2kq4XHDSSd8LIIEqrUmeMcNF5rxQ11k1rlWj1s58EnWSHpb71yOFQ2j/rpvKu+iLe4Gys70Zc51JKDimRT5xG5sA=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(55236004)(26005)(5660300002)(38070700005)(6512007)(122000001)(186003)(107886003)(4326008)(31696002)(508600001)(15650500001)(8936002)(110136005)(66446008)(6506007)(38100700002)(2616005)(86362001)(2906002)(66946007)(83380400001)(53546011)(66476007)(6486002)(31686004)(66556008)(64756008)(54906003)(36756003)(91956017)(7416002)(8676002)(76116006)(71200400001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?TENyQVMwVjFwUGxadmZkZllWK0tSdWllWDRnTEZjU3o3bjEvcTZKTnE5WVZl?=
 =?utf-8?B?YUxkN0hCMUkrYlh6aDhwd2Flc3VFZEk2WXNmUjRDNFIwcGRQOTlMbmk4L2tE?=
 =?utf-8?B?VnFvdnAyZG5jT0RuYkw5UWdyMHZSRTVxNzZyNjJyZFVBVzQxd0hlcTVDdTRY?=
 =?utf-8?B?RCs2c3hzRFhGTDhyQmFJa3cyYXBMYWM0UFZaMzVpdUZNcmdJWWV4ZnhuQ3Vu?=
 =?utf-8?B?cWlleHY2NG5JYk1hN1RNNGlma01HQkZMamlNU1ZWVWN3NUpqOGZ3OE0rY2RK?=
 =?utf-8?B?OXhQTVdIaTh6TitHUnB6RjRVN09yeEh6bHd4MVAybndqM1lTQkFCMi9UZGc0?=
 =?utf-8?B?QnBYY1RqNFFOT3l2QkZqRDZaNHI3NVg3M2Q1ejJ4cEVKWG5PQ1kySjE0OUhB?=
 =?utf-8?B?YysvK1c1SGR4MUNCZzNkU0txK0NOaVRYNzA1RUoycFdybUNNQVhDOHlYV3NC?=
 =?utf-8?B?TVRoblBUQlpOYXNmK09QaU1MQkQ0UUNtOHQ2dWhSOXo4dVVMeEZrZXZ6aXhz?=
 =?utf-8?B?UXFSRVpEY0J1ZTFGMWxEWW9LZlNSaHlOaFhob3V5dmRjUStENDNsWWpkWkJX?=
 =?utf-8?B?bHhPZUlsNjBqZ0NJekxobXVmOGdxNHNjSjlFNUdaRXRZQkczVzNGT2YvblJt?=
 =?utf-8?B?SFREZmRYM1FiZmpydGlBRFR4Vjdrc0NpeHpVbmFkZms1RnFxclB6Y2laV0oy?=
 =?utf-8?B?NUcrK1R5WisvN2NsZFJRK0dNTy9SOHU0RVFxQTFRdjZMVmtkR2NPMTRpczU3?=
 =?utf-8?B?bkFFOHpmWDA2OENHMDB0Z2cyU3VZd2lUYkZJL3JmaUMxd0ZGWlRXRU5zVlh2?=
 =?utf-8?B?MWJjMm9ldUNTdEp1dGsyR0pXTkJ5Y09yOXhnWTJRZzZld1dLQ2ZSUGlkZ2ZN?=
 =?utf-8?B?VFF2dkZWdDVVRmlRcjZEY09ONlU2dURaSzlveUNrVS9JSlhuQW9GRjA3S3du?=
 =?utf-8?B?VXd6dm9FQmM0SHh4YUZWV1JsUW44TVU3d2Q1RFAraktNUmtjcVdXUzFJa3F4?=
 =?utf-8?B?eDdGTXNndEdGek1WQWFwM0NZUVQ5WU15UjlqUVJzRjJGeERKb2dJem91Rjlv?=
 =?utf-8?B?aGl5UUxTYmIvTDRtMW50YjdHVEpDcUQrZDZyWjJTc1ljL0FvTEFnTnhMVVM5?=
 =?utf-8?B?NnlRREh4cCtsU2xKenlUYWRmQjFER3JGT0l6WmErc3pmZEZzNVZrckdkK2RD?=
 =?utf-8?B?U0pPRmc3N2JDaWFlQlFsbU1rOVRkS2tveVFmQzd3S09sZVFHbi9HNlNDN0lj?=
 =?utf-8?B?amlERWVtV2VNZjA3NW5pOTI1K1hUc2ZGUWtoekJrTHNGUnRBTGxURDZUWWNm?=
 =?utf-8?B?UHd1aUUvOTRRRk5MOVYzTlExYkVXcjhONVdYTFRQYXR5YjBDTHpzVjg3cVIy?=
 =?utf-8?B?MjFNQjVFYWZQYVhtVG93bWMySkF4YzlnSFRwMUN6WlVXQnVpNUwvc1dCTGZO?=
 =?utf-8?B?am9vMXR2SExZRzlaTUVGNVd6Y0ZIL2xpVU1ZWGlXUVZFa0t3THgwQ2wvQWwz?=
 =?utf-8?B?N21RL3FSdnF5YVhKNThBWDNmdi9MbXg4N0lUd0p4SjV0bDNmUkNsK0VVR2pt?=
 =?utf-8?B?dGU2bGdLMVJUZWJ4Umx6RmFLZUJaUlU4SngyVGR5cVVlTzJhdVFuaUowb3VG?=
 =?utf-8?B?VW90RDVlR3N0bFhkOFowY01WblZoL1ZPdnM5N1FLUHBqUEp0a0VleFZ1Zjdt?=
 =?utf-8?B?cXZzWUJZZ3FVNmRIL2JXMmtQMmM0T0ZVMWhKUnZWQm1uRnBLVWllMmsxemhZ?=
 =?utf-8?B?QUFKaDZPdkdIRXdpeGtHWUVMZy8zdU9TY3VNWE54M2RuempHNjVGZThnRlZE?=
 =?utf-8?B?Q0NrOUdsS1dYRFRPajRkb0lsa1pZMnI2WUdiaDVMUnZvaXY1MGQyQWRwU0Jq?=
 =?utf-8?B?T01jUmJhV0U5dVB4cS9PbDBiaHhXNzRQd2hzN3pob2tKN0R0WCt2NFdjam5Q?=
 =?utf-8?B?Qmp2WElaMjNvbUJGQ0lCeDdkTnQ2VGRTL2o4TUNZazJyeE5rcENXWGtMSU5L?=
 =?utf-8?B?TzJ6dVcwbnlMTVFob1p5bS9LYXlEMTAxYUxKa01ibUVjZldsRjhnckZKdEVl?=
 =?utf-8?B?eFczY0tVc1pVUFo5S0FQb2gzSFhyQVZDYXpheUNjWVNyQXhzS0Z2cjVXbmRM?=
 =?utf-8?B?NVVMU3VkeWloWXIyUXI3WWxhMjZ1UWw1TGZWamxUSTJYT3ljcHg4Z0FSY1hv?=
 =?utf-8?B?Z1dHUkkxc2JBZTdDYWtjdnRlRjJmM0gweW80SEp0dFdzbndzR0FPczNBdjEz?=
 =?utf-8?B?TmljM2krREt5ZXk3VC9sREw4NUpQOEdPSjQwbTJFN3ZpdjlCMThVeW16dWRp?=
 =?utf-8?B?aGVJUWJtU1E0MmNEQlltUU5FUEV6bXF1NU0ycWtHamI0YmhXK2FBdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <71C9D1384DF44B4585A2C47FC9AE3FB5@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 258fa729-035e-4b8c-5441-08d9ba7ca48b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 18:57:54.8472
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cMYTFgreI+MwBc5CteqixGRWT4kVjppAsbKKatbl2Cc+U/hT6TB4N2Zr9aj6KIGSYZ13dRXzfT7gMa9LpTOOWDNcwqB+Gy1aR7CDjiLHswv8nBmhc+ySXaB93+iqlwC8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4756
X-Proofpoint-ORIG-GUID: ra6JDGHTWjq1gUWF8-45QZzXyvvbN1nt
X-Proofpoint-GUID: ra6JDGHTWjq1gUWF8-45QZzXyvvbN1nt
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-08_07,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0
 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0
 mlxlogscore=932 malwarescore=0 priorityscore=1501 clxscore=1015 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112080107

SGksIEp1bGllbiENCg0KT24gMDguMTIuMjEgMTg6NTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAyNC8xMS8yMDIxIDA3OjU5LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBBdCB0aGUgbW9tZW50LCB3ZSBhbHdh
eXMgYWxsb2NhdGUgYW4gZXh0cmEgMTYgc2xvdHMgZm9yIElPIGhhbmRsZXJzDQo+PiAoc2VlIE1B
WF9JT19IQU5ETEVSKS4gU28gd2hpbGUgYWRkaW5nIGFuIElPIHRyYXAgaGFuZGxlciBmb3IgdGhl
IGVtdWxhdGVkDQo+PiBQQ0kgaG9zdCBicmlkZ2Ugd2UgYXJlIG5vdCBicmVha2luZyBhbnl0aGlu
ZywgYnV0IHdlIGhhdmUgYSBsYXRlbnQgYnVnDQo+PiBhcyB0aGUgbWF4aW11bSBudW1iZXIgb2Yg
SU9zIG1heSBiZSBleGNlZWRlZC4NCj4+IEZpeCB0aGlzIGJ5IGV4cGxpY2l0bHkgdGVsbGluZyB0
aGF0IHdlIGhhdmUgYW4gYWRkaXRpb25hbCBJTyBoYW5kbGVyLCBzbyBpdCBpcw0KPj4gYWNjb3Vu
dGVkLg0KPj4NCj4+IEZpeGVzOiBkNTkxNjhkYzA1YTUgKCJ4ZW4vYXJtOiBFbmFibGUgdGhlIGV4
aXN0aW5nIHg4NiB2aXJ0dWFsIFBDSSBzdXBwb3J0IGZvciBBUk0iKQ0KPg0KPiBJbiBnZW5lcmFs
LCBpdCBpcyBiZXR0ZXIgdG8gaGF2ZSB0aGUgZml4ZXMgYXQgdGhlIGJlZ2lubmluZyBvZiBhIHNl
cmllcy4gU28gdGhleSBhcmUgcmVseWluZyBvbiBsZXNzIHJld29yayBhbmQgZWFzaWVyIHRvIGJh
Y2twb3J0IChpZiBuZWVkZWQpLg0KPg0KPiBJbiB0aGlzIGNhc2UsIFBDSSBwYXNzdGhyb3VnaCBp
cyBzdGlsbCBhIHRlY2huaWNhbCBwcmV2aWV3IHNvIGl0IGRvZXNuJ3QgbWF0dGVyIHRvbyBtdWNo
Lg0KSSBhbSBwbGFubmluZyB0byByZXNlbmQgdGhlIHdob2xlIHNlcmllcywgc28gSSBjYW4gbW92
ZSB0aGlzIHRvIHRoZSBib3R0b20sDQpidXQgaXQgaXMgaW5kZWVkIGRvZXNuJ3QgbWF0dGVyIGF0
IHRoZSBtb21lbnQNCj4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNo
ZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+ID4NCj4+IGRpZmYgLS1n
aXQgYS94ZW4vYXJjaC9hcm0vdnBjaS5jIGIveGVuL2FyY2gvYXJtL3ZwY2kuYw0KPj4gaW5kZXgg
Y2NkOTk4ZDhkYmEyLi44ZTgwMWYyNzU4NzkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0v
dnBjaS5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vdnBjaS5jDQo+PiBAQCAtMTI2LDcgKzEyNiw4
IEBAIHVuc2lnbmVkIGludCBkb21haW5fdnBjaV9nZXRfbnVtX21taW9faGFuZGxlcnMoc3RydWN0
IGRvbWFpbiAqZCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmV0IDwgMCA/IDAgOiBy
ZXQ7DQo+PiDCoMKgwqDCoMKgIH0NCj4+IMKgIC3CoMKgwqAgcmV0dXJuIDA7DQo+PiArwqDCoMKg
IC8qIEZvciBhIHNpbmdsZSBlbXVsYXRlZCBob3N0IGJyaWRnZSdzIGNvbmZpZ3VyYXRpb24gc3Bh
Y2UuICovDQo+DQo+IFRoaXMgY29tbWVudCBpcyBsYWNraW5nIHNvbWUgY29udGV4dC4gSSB3b3Vs
ZCBzdWdnZXN0IHRvIHJld29yZCB0byBzb21ldGhpbmcgbGlrZToNCj4NCj4gIkZvciB0aGUgZ3Vl
c3RzLCBlYWNoIGhvc3QgYnJpZGdlIHJlcXVpcmVzIG9uZSByZWdpb24gdG8gY292ZXIgdGhlIGNv
bmZpZ3VyYXRpb24gc3BhY2UuIEF0IHRoZSBtb21lbnQsIHdlIG9ubHkgZXhwb3NlIGEgc2luZ2xl
IGhvc3QgYnJpZGdlLg0KPiAiDQo+DQpPaywgd2lsbCBjaGFuZ2UNCj4gV2l0aCB0aGF0IChvciBh
IHNpbWlsYXIgY29tbWVudCk6DQo+DQo+IEFja2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh
bWF6b24uY29tPg0KVGhhbmsgeW91LA0KT2xla3NhbmRyDQo+DQo+IENoZWVycywNCj4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 18:59:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 18:59:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242588.419548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv29b-00035b-0w; Wed, 08 Dec 2021 18:58:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242588.419548; Wed, 08 Dec 2021 18:58:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv29a-00035U-Tw; Wed, 08 Dec 2021 18:58:58 +0000
Received: by outflank-mailman (input) for mailman id 242588;
 Wed, 08 Dec 2021 18:58:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v8t+=QZ=epam.com=prvs=2976427baf=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mv29Z-0002V9-J0
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 18:58:57 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e481e91f-5858-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 19:58:56 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B8Id37A015671;
 Wed, 8 Dec 2021 18:58:52 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cu25v81br-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 08 Dec 2021 18:58:52 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4305.eurprd03.prod.outlook.com (2603:10a6:208:c0::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 8 Dec
 2021 18:58:48 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.012; Wed, 8 Dec 2021
 18:58:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e481e91f-5858-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XpK7QYVtz3nUuw1rsHrkHAM/vqNSUQOegP4MEL3PcDzirl6czke93w9JcCIC6gt7oO8kEY42LkyXnHBL2E//Js++FjftJU5HRRb14v4hvgwbPnxY3unZL+TU959K69GVBywg4xj7yXKLBilu32dj7pKg7sWNCS6qUlnmnDNPPtwDYsJKAZmMqx9k6GCk2VrB4X3+UkgLLRFtUxYDDBFHs9wJFH1ChQPLA87VVBp1CJMBOEcpuD9EwgTiOm2hJlBVvZhGeSUx1AoJtrLOfkSxE8S9L6QdG/MOahNfEDrzfTymSdOC+O0yPk+f3o/biVF2nZJfbvQNYfOQqx5T58jqKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OGBO0HXPhnvsCxbxCRm847xG3xpA1974HHfgcE+axLM=;
 b=JJKpNn7JYa5nFDTsaIg/y3v/mJsEuQMyRjhUxJKSoKDbtwmDOrm0JtFOnqGBx1jiM3f80XNofr0wWqqwVJiL8GrVwXBD9rEjECIIjb5FIwH7wOoz02CNtr2WT2cGzbjIt4D5hwwTwfldyWxJDa5/+JtwSbpain3uYMvTirJHfsKGFS/GztqeYTADHjg9kWHK7KdIemZ3utTXsb4xbrunLXuBiyX82uq+qFLgRbsmJl7/iqV8ONQHcl7r6uuVTiU/qlgXz5C+Lmkoly8+w95VD7IlbSXF4uw0fJvRjwiJ/lO7J428L3Gr3DZQvKaBk7lR15UNYcEqNw00l1lr2m6kjg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OGBO0HXPhnvsCxbxCRm847xG3xpA1974HHfgcE+axLM=;
 b=NONV7fgwINkSjk5FghGuKDUOWSiq5/DJusm+8ZoMUm7myY21Ze3ULZoiXZsUPsJA7db/BcFce3INnFlJ9pUiKFm8Ip6gJJ0I7kWIQ3jSKsdkNgXwgTmMxvyE65D+DoTKK8GWE3B97JHhDbG1QXAZMAQ4vbLY1gKF5DllRNC8fMiuTfmjIXMiFgP1arUfh6rrgr0mxV2c1GnpO/JgfCRlfBIqvmMTrK44odXiipyC3PAwF0HPL0t8ZY//smvhaXNBc6evhSLvvselMTcyz+ZQA0sVScamgrFDtAifFOqbPjGhFDEh/qStk/cdqwLLz1bEpLXgYqW/lwuX27bVM0xQlQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v7 5/7] xen/arm: do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v7 5/7] xen/arm: do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHX4QlG/0qanoOdY0qH6GEAgA+cfqwo7b2AgAAbcwA=
Date: Wed, 8 Dec 2021 18:58:48 +0000
Message-ID: <db0106db-f951-048a-20df-7e2fb51e1be2@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-6-andr2000@gmail.com>
 <dc367640-b445-9c47-6d66-9c6a8cdbc85f@xen.org>
In-Reply-To: <dc367640-b445-9c47-6d66-9c6a8cdbc85f@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bcc3d372-8b74-4621-6d8b-08d9ba7cc4c1
x-ms-traffictypediagnostic: AM0PR03MB4305:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB43051E11EA455A14CA72A6CDE76F9@AM0PR03MB4305.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 XMzM+HOmz2ghfoFVIKAwlPDaj3Jr4hIhnXiD4lA9x6cUNTB2/CXpMU1x4YEybIHnKWQtgeO2OPk71nyyO7LjEHjBJZa5O1S3uZtDTU+G0RkqGkPiPCrmKaBLe1mI/2++BOpU0BBjM8vlWjQhTnPjNtKfYXefC9cCoK48nvkmf3UxS+NuRrvNahRgh+3uuXicifyFffB6QU6HJE5yebeDe6aWIBc3uRnbt/mCaHEz5BJmGMvMSMVgA/E6MmvcDyf1qGmorzApqqcyekBTeqG4rE7GUZhC6+pReUHGCLHMMrtxXyFhjP4jyr4yfIHwnP4IfJDOs1FC8z++cN412ZGf6fpvGcJMby7vyMnsoIt+n0Fy5HLOp8t3lC74fhORWsxh6+H1su4TBRnad9WZ/TD3l0OB+PwgLtvqQY0yFXFiwoo+7Mn2u6dlLIDrCL705+UIzldZhI2Gkl5wDOjOuDYgkhNdKmgz8Emhxbx4oDpjq9k5yTajQTB0JVxbrAvcVE5vCyY1sAMndNKXg/LHmvRL9S1EPIORbyKk5Z4AuiZWGPuR4FvOhGC7MRZakb2/yZ/aalqSjgaYtc4TMuFfQLeZNx5dIJCNDytBK2eFzTpZ0tPlh3xY7AsQLm348m6FUel1myaXU1Mi6c8heGKwviwRnJHejDbre5Sh1nXPTNRvC2jgZ2N7hcl1fLFcTLQqG4DPyIfQxRL2F+UYqGI2GytvP9qAiFVSC8unALo+q9CrxARfYenHZJ0mKE5yoq5azw1M7oiMyQEMYP6434i3znBfKayoWYMtTum3+IsMeIchn2d2ukJiEkPixGbw6i/FeyitCGeolO5CeHRMr785CoSGRg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(966005)(8936002)(66446008)(38070700005)(110136005)(76116006)(2906002)(91956017)(66476007)(66556008)(64756008)(54906003)(186003)(316002)(122000001)(86362001)(38100700002)(6512007)(5660300002)(6486002)(31686004)(83380400001)(107886003)(31696002)(36756003)(4326008)(26005)(53546011)(71200400001)(7416002)(6506007)(2616005)(55236004)(8676002)(508600001)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?MC9xcEhqbE1mYThBU1g2a1dyYjRwT0JnM3kvOGpBWXdwNFEzcjZuWmhvVUpx?=
 =?utf-8?B?ZU9lRkpaa2VRNDJwYTcrRmR0c2JLem96WnFxclRwZ1FDNmVONHUyeDRzdE1v?=
 =?utf-8?B?ait5RkxEYkVpZjFXaEh0MFRpNTZzTHZFbmNMWVM0eU5FM2phSlJvNW85MCsv?=
 =?utf-8?B?UGxsUVZNY0o3YzAvTSs0VVduVFBxcUxzdG1JQ0xQcldkQ3dSeDlOc2Y3a0Fz?=
 =?utf-8?B?OEJFVmdodW0raFpSTXJTSUlLQXA2Ky9WZFBpRXQxMFBXc1VOQzhNZTNFVVR5?=
 =?utf-8?B?RkUwTTFKN3hKUVFLN0dFTmdGWFBadTBlQzFhdHN5dzVXWTNmL1lVZjRhQVVv?=
 =?utf-8?B?YlYrT0p0dDc4U1NWY2Q2N2ExSzZBaHY5YVZGWVN4dW9YbmpPaVFzNnZoaTls?=
 =?utf-8?B?N3BESFRrNy82MnpIQ0FMcmg5anVWdVdJTHV3QlhkRTVhUVk4TUtJUzFOSVFM?=
 =?utf-8?B?cWE1d05KZWRETkEzakhqVXVhQVRZWENRdHRoMHZiSXFETjBkWE5SZFRsR0pJ?=
 =?utf-8?B?UnJrL3pGdE83WnVhVGNVVmRJS3czT3AySnNHT21obGEwM3A2L0FDSk9rUWsx?=
 =?utf-8?B?ZmVrYVFtM2RZSGpUeXUwR2hkQWJhVmFDekpveUl4eGhocXlOaXBhMHM1ZmxU?=
 =?utf-8?B?MEtybERnT0daaTBobHFKVnpUMitGR1YwZ0c2UW51U1NyY3VGM3hMdFQrWS80?=
 =?utf-8?B?aUFuS0hheFBuQitxaW9wcGtlbWZmdTcveGNhSzVHeXlGNnFjM1dmQ0RiMnRC?=
 =?utf-8?B?QUhlSVJuS0VHQndYUUlINCtIQUFOYkNTRTRnRGE0bFNuYkU2MmlpNmpuWm5p?=
 =?utf-8?B?Nk8xZkYyRFVjK202UU1xeTBSYi9pSEwybWNidnk3UnJPNElGektmUVBoS2Jv?=
 =?utf-8?B?blRJZ2V5NXd3ck02ZnZQbGdOVFViamo2R1NidnZhYjd1UWVsK1UvK2NqVDl3?=
 =?utf-8?B?bG9BeUszRW4xenZSTjdJUk9FdnVjMCtzMlpGS0tIWHFvejNhd2JoS0NubVZk?=
 =?utf-8?B?N0ZnelZ6RmtXVDRZODdqT3F5eVFEc2lBdlNlRldicDFSV1lGQ1FYNThIb3Jv?=
 =?utf-8?B?K2tIUzE2UmNaRzA5R0pVT09UWlFTQ2dmRnlIUFZzbTU2VWlhd1pkZG9vckZQ?=
 =?utf-8?B?a05yckw1QWQ0RlpzTTRCRDlWVW9BNi9LeXZOeDdPbFUxSWlvMWR5RHhHLzQw?=
 =?utf-8?B?OG8wUVhxNUNYRG9CQWNxN0p0VVdUYkJjQmdOdlhsTWFOVnFtUVV3YnJmdith?=
 =?utf-8?B?ejA2Tk5KMjNpQkVhUmdiTTJhREp3L3l0a1JvWThrMjF5cmtpQUhsMnBvMm1J?=
 =?utf-8?B?dWU3MFhITzVJUVZaVU1CNzVYSFNCVU5wZjd4VFNWNCtSTnFNdi9XNng1UFNz?=
 =?utf-8?B?VmNiQVNDV3BRdUxRdm1Ic0tMd0hqYVZzcktPbWlzOURta0FZbFY3MjZJN0RU?=
 =?utf-8?B?ZEIzbmVVSUFMNkZ3cTZQTXRDU1MyTFNWVWxFNUorZVZpdE5aR3BBR0dyM29M?=
 =?utf-8?B?cjVhd29YeTdYb3dZMlozWjlxUkxpWXp0ckx5bk5tUjVyZUZZbDBIaHNRdzJw?=
 =?utf-8?B?d1lORTRIZHhWeEY5ODgxTzVmSVBsNGhIS29rRHZQNHd4eGJOZ3AyRndWQ1pN?=
 =?utf-8?B?OGpseHJ1d2pLMzFMQmN1Njg2ZnJ0cWhXNCtNa2hKN1FFczNWU1d6dGxQUlE1?=
 =?utf-8?B?Vm1vdThyV2Z6K2tsMUlkL0dycExOY2piSG1wV3dUMGZyK1hJYmdQMjk3SzVV?=
 =?utf-8?B?WHpTb2lwMzF5TFIrNlErTGEvM2kzSEg4dTFrcjZJeG5iaXBXOHd3UGpld28r?=
 =?utf-8?B?WDRkMEpFdmwyaW9Ca3d2b3QzaE05RkR0YmJYUGFVeUx6aktHWUtWcnpnVEMy?=
 =?utf-8?B?M0t0S1A5SUdnL3Mwb09yeWh1dWxjYWdxZVpXOTVDdUEyMUNwa1FRY2doVzR6?=
 =?utf-8?B?WUZudUtnWWd4Y2dKaEE0VFNZV3hLZkI5ZjhJZlN5bVBVREU3QVJaVFRObk1V?=
 =?utf-8?B?TVdua0FBRWk1ZmVpdml0Z1JRTE9yL3lLUlZ5WGNrQ054ZmQ5OXNnSHAvcjJr?=
 =?utf-8?B?bjc2THFCYUJSVGY3cFFWK2RvNjNQbW9oWmFTNlU3eEVKSk80MU9DYjNlNW9p?=
 =?utf-8?B?TTdqWVlDQ1lvV2NVUXhkcUVFNmJBb0hieEJIeXpHR3ZqeGFIS1k4M1JRSzBq?=
 =?utf-8?B?WFJ5N0M0aURhcWpGSUN6NWx2azl0ekQ0NjRIZHgreTQ1cUI1TkdrMHJNVFJY?=
 =?utf-8?B?RXNEczNMODIvNWYwK0dYeFAwcnRWQUlKSVh4cm0zNWljRXVqRXRLTlV1TXpM?=
 =?utf-8?B?dC9vOTN6QXZWVFdiMGp1bDJFWmplQVIzRDdFS0NtRnh5SXk5Q1Zwdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <4C38AA772CD3AA449C2F0BD8F1A07961@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bcc3d372-8b74-4621-6d8b-08d9ba7cc4c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 18:58:48.8732
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v2rrfzl1RLgC63XrEDhC2EX6hi6dPWy/l5flu7SQ9ljdR6fy+xeSpbu8JDs0dtkZugQ1/yf/kBnvwJwj/7ART7YytDUOLJ7t333r8HLwCzXe1FKvJhm66zud70stW18O
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4305
X-Proofpoint-GUID: jEvbaLuU4UwViXQq_utJP0L8xVk1u95r
X-Proofpoint-ORIG-GUID: jEvbaLuU4UwViXQq_utJP0L8xVk1u95r
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-08_07,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 priorityscore=1501
 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112080107

SGksIEp1bGllbiENCg0KT24gMDguMTIuMjEgMTk6MjAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAyNC8xMS8yMDIxIDA3OjU5LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu
ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiBQQ0kgaG9zdCBicmlkZ2VzIGFyZSBz
cGVjaWFsIGRldmljZXMgaW4gdGVybXMgb2YgaW1wbGVtZW50aW5nIFBDSQ0KPj4gcGFzc3Rocm91
Z2guIEFjY29yZGluZyB0byBbMV0gdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gZGVwZW5kcyBv
bg0KPj4gRG9tYWluLTAgdG8gcGVyZm9ybSB0aGUgaW5pdGlhbGl6YXRpb24gb2YgdGhlIHJlbGV2
YW50IFBDSSBob3N0DQo+PiBicmlkZ2UgaGFyZHdhcmUgYW5kIHBlcmZvcm0gUENJIGRldmljZSBl
bnVtZXJhdGlvbi4gSW4gb3JkZXIgdG8NCj4+IGFjaGlldmUgdGhhdCBvbmUgb2YgdGhlIHJlcXVp
cmVkIGNoYW5nZXMgaXMgdG8gbm90IG1hcCBhbGwgdGhlIG1lbW9yeQ0KPj4gcmFuZ2VzIGluIG1h
cF9yYW5nZV90b19kb21haW4gYXMgd2UgdHJhdmVyc2UgdGhlIGRldmljZSB0cmVlIG9uIHN0YXJ0
dXANCj4+IGFuZCBwZXJmb3JtIHNvbWUgYWRkaXRpb25hbCBjaGVja3MgaWYgdGhlIHJhbmdlIG5l
ZWRzIHRvIGJlIG1hcHBlZCB0bw0KPj4gRG9tYWluLTAuDQo+Pg0KPj4gVGhlIGdlbmVyaWMgUENJ
IGhvc3QgY29udHJvbGxlciBkZXZpY2UgdHJlZSBiaW5kaW5nIHNheXMgWzJdOg0KPj4gLSByYW5n
ZXM6IEFzIGRlc2NyaWJlZCBpbiBJRUVFIFN0ZCAxMjc1LTE5OTQsIGJ1dCBtdXN0IHByb3ZpZGUN
Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIGF0IGxlYXN0IGEgZGVmaW5pdGlvbiBvZiBub24tcHJl
ZmV0Y2hhYmxlIG1lbW9yeS4gT25lDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvciBib3RoIG9m
IHByZWZldGNoYWJsZSBNZW1vcnkgYW5kIElPIFNwYWNlIG1heSBhbHNvDQo+PiDCoMKgwqDCoMKg
wqDCoMKgwqDCoCBiZSBwcm92aWRlZC4NCj4+DQo+PiAtIHJlZ8KgwqAgOiBUaGUgQ29uZmlndXJh
dGlvbiBTcGFjZSBiYXNlIGFkZHJlc3MgYW5kIHNpemUsIGFzIGFjY2Vzc2VkDQo+PiDCoMKgwqDC
oMKgwqDCoMKgwqDCoCBmcm9tIHRoZSBwYXJlbnQgYnVzLsKgIFRoZSBiYXNlIGFkZHJlc3MgY29y
cmVzcG9uZHMgdG8NCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRoZSBmaXJzdCBidXMgaW4gdGhl
ICJidXMtcmFuZ2UiIHByb3BlcnR5LsKgIElmIG5vDQo+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCAi
YnVzLXJhbmdlIiBpcyBzcGVjaWZpZWQsIHRoaXMgd2lsbCBiZSBidXMgMCAodGhlIGRlZmF1bHQp
Lg0KPj4NCj4+IMKgRnJvbSB0aGUgYWJvdmUgbm9uZSBvZiB0aGUgbWVtb3J5IHJhbmdlcyBmcm9t
IHRoZSAicmFuZ2VzIiBwcm9wZXJ0eQ0KPj4gbmVlZHMgdG8gYmUgbWFwcGVkIHRvIERvbWFpbi0w
IGF0IHN0YXJ0dXAgYXMgTU1JTyBtYXBwaW5nIGlzIGdvaW5nIHRvDQo+PiBiZSBoYW5kbGVkIGR5
bmFtaWNhbGx5IGJ5IHZQQ0kgYXMgd2UgYXNzaWduIFBDSSBkZXZpY2VzLCBlLmcuIGVhY2gNCj4+
IGRldmljZSBhc3NpZ25lZCB0byBEb21haW4tMC9ndWVzdCB3aWxsIGhhdmUgaXRzIE1NSU9zIG1h
cHBlZC91bm1hcHBlZA0KPj4gYXMgbmVlZGVkIGJ5IFhlbi4NCj4+DQo+PiBUaGUgInJlZyIgcHJv
cGVydHkgY292ZXJzIG5vdCBvbmx5IEVDQU0gc3BhY2UsIGJ1dCBtYXkgYWxzbyBoYXZlIG90aGVy
DQo+PiB0aGVuIHRoZSBjb25maWd1cmF0aW9uIG1lbW9yeSByYW5nZXMgZGVzY3JpYmVkLCBmb3Ig
ZXhhbXBsZSBbM106DQo+PiAtIHJlZzogU2hvdWxkIGNvbnRhaW4gcmNfZGJpLCBjb25maWcgcmVn
aXN0ZXJzIGxvY2F0aW9uIGFuZCBsZW5ndGguDQo+PiAtIHJlZy1uYW1lczogTXVzdCBpbmNsdWRl
IHRoZSBmb2xsb3dpbmcgZW50cmllczoNCj4+IMKgwqDCoCAicmNfZGJpIjogY29udHJvbGxlciBj
b25maWd1cmF0aW9uIHJlZ2lzdGVyczsNCj4+IMKgwqDCoCAiY29uZmlnIjogUENJZSBjb25maWd1
cmF0aW9uIHNwYWNlIHJlZ2lzdGVycy4NCj4+DQo+PiBUaGlzIHBhdGNoIG1ha2VzIGl0IHBvc3Np
YmxlIHRvIG5vdCBtYXAgYWxsIHRoZSByYW5nZXMgZnJvbSB0aGUNCj4+ICJyYW5nZXMiIHByb3Bl
cnR5IGFuZCBhbHNvIEVDQU0gZnJvbSB0aGUgInJlZyIuIEFsbCB0aGUgcmVzdCBmcm9tIHRoZQ0K
Pj4gInJlZyIgcHJvcGVydHkgc3RpbGwgbmVlZHMgdG8gYmUgbWFwcGVkIHRvIERvbWFpbi0wLCBz
byB0aGUgUENJDQo+PiBob3N0IGJyaWRnZSByZW1haW5zIGZ1bmN0aW9uYWwgaW4gRG9tYWluLTAu
IFRoaXMgaXMgZG9uZSBieSBmaXJzdA0KPj4gc2tpcHBpbmcgdGhlIG1hcHBpbmdzIHdoaWxlIHRy
YXZlcnNpbmcgdGhlIGRldmljZSB0cmVlIGFzIGl0IGlzIGRvbmUgZm9yDQo+PiB1c3VhbCBkZXZp
Y2VzIGFuZCB0aGVuIGJ5IGNhbGxpbmcgYSBkZWRpY2F0ZWQgcGNpX2hvc3RfYnJpZGdlX21hcHBp
bmdzDQo+PiBmdW5jdGlvbiB3aGljaCBvbmx5IG1hcHMgTU1JT3MgcmVxdWlyZWQgYnkgdGhlIGhv
c3QgYnJpZGdlcyBsZWF2aW5nIHRoZQ0KPj4gcmVnaW9ucywgbmVlZGVkIGZvciB2UENJIHRyYXBz
LCB1bm1hcHBlZC4NCj4+DQo+PiBbMV0gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNo
aXZlcy9odG1sL3hlbi1kZXZlbC8yMDIwLTA3L21zZzAwNzc3Lmh0bWwNCj4+IFsyXSBodHRwczov
L3d3dy5rZXJuZWwub3JnL2RvYy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp
L2hvc3QtZ2VuZXJpYy1wY2kudHh0DQo+PiBbM10gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2Mv
RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9oaXNpbGljb24tcGNpZS50eHQN
Cj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+DQo+IFJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwg
PGpncmFsbEBhbWF6b24uY29tPg0KPg0KPiBJIGhhdmVuJ3QgY29tbWl0dGVkIGJlY2F1c2UgaXQg
aXMgbm90IGNsZWFyIHdoZXRoZXIgdGhpcyBwYXRjaCBkZXBlbmRzIG9uIGVhcmxpZXIgcGF0Y2hl
cyB0aGF0IGFyZSBzdGlsbCB1bmRlciByZXZpZXcuIENhbiB5b3UgYWR2aXNlPw0KSSB3aWxsIHJl
c2VuZCB0aGUgd2hvbGUgc2VyaWVzIChsZWZ0b3ZlcnMpLCBzbyBubyBuZWVkIHRvIGNvbW1pdCBu
b3cNCg0KVGhhbmsgeW91LA0KT2xla3NhbmRyDQo+DQo+IENoZWVycywNCj4NCg==


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 19:24:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 19:24:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242600.419558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv2Xc-0007FV-8P; Wed, 08 Dec 2021 19:23:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242600.419558; Wed, 08 Dec 2021 19:23:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv2Xc-0007FO-5M; Wed, 08 Dec 2021 19:23:48 +0000
Received: by outflank-mailman (input) for mailman id 242600;
 Wed, 08 Dec 2021 19:23:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv2Xa-0007FD-Vk; Wed, 08 Dec 2021 19:23:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv2Xa-0004Vg-LK; Wed, 08 Dec 2021 19:23:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv2Xa-0003Kr-8T; Wed, 08 Dec 2021 19:23:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mv2Xa-0000RN-7y; Wed, 08 Dec 2021 19:23:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xtNd2uy1zXX1fjl5ICTRLcOSnGrJkfOcblmLb77YINQ=; b=ggjRKlrgvLhv4wIsfi9L/437f+
	bHjdFpy8Qu1sJ8KVurR+0QLFwpKZGWNywu/1eRiJ9Y5uOz5Ce5L1HrcyPng+4uxmzbZV0PBrrtDaU
	M3ROh2fP8eMgFlihmN3XTqIVYlha2E62DpS2gLvuDaK29+aAw06tvqHU330TzbBEXe2k=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167230-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167230: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e3c95128def1c937754a5cdc3d297fa47968e9f6
X-Osstest-Versions-That:
    linux=57899c4e26bf5a02b9b405267a1812f26b9ccce5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 19:23:46 +0000

flight 167230 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167230/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167117
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167117
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167117
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167117
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167117
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167117
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167117
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167117
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167117
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 167117
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167117
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167117
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167117
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e3c95128def1c937754a5cdc3d297fa47968e9f6
baseline version:
 linux                57899c4e26bf5a02b9b405267a1812f26b9ccce5

Last test of basis   167117  2021-12-04 23:13:28 Z    3 days
Testing same since   167230  2021-12-08 08:12:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaro Koskinen <aaro.koskinen@iki.fi>
  Alain Volmat <alain.volmat@foss.st.com>
  Andreas Gruenbacher <agruenba@redhat.com>
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Ard Biesheuvel <ardb@kernel.org>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Arnd Bergmann <arnd@arndb.de>
  Badhri Jagan Sridharan <badhri@google.com>
  Baokun Li <libaokun1@huawei.com>
  Baruch Siach <baruch@tkos.co.il>
  Benjamin Coddington <bcodding@redhat.com>
  Benjamin Poirier <bpoirier@nvidia.com>
  Borislav Petkov <bp@suse.de>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Corey Minyard <cminyard@mvista.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Dietmar Eggemann <dietmar.eggemann@arm.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Dumazet <edumazet@google.com>
  Feng Tang <feng.tang@intel.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Gregory CLEMENT <gregory.clement@bootlin.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Heiko Carstens <hca@linux.ibm.com>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Ian Rogers <irogers@google.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason A. Donenfeld <Jason@zx2c4.com>
  Jay Dolan <jay.dolan@accesio.com>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Joerg Roedel <jroedel@suse.de>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  Jon Hunter <jonathanh@nvidia.com>
  Julian Braha <julianbraha@gmail.com>
  Kalle Valo <kvalo@codeaurora.org>
  Karsten Graul <kgraul@linux.ibm.com>
  Li Zhijian <lizhijian@cn.fujitsu.com>
  Like Xu <likexu@tencent.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  liuguoqiang <liuguoqiang@uniontech.com>
  Luca Coelho <luciano.coelho@intel.com>
  Maciej W. Rozycki <macro@orcam.me.uk>
  Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Mario Limonciello <mario.limonciello@amd.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Max Filippov <jcmvbkbc@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Mike Christie <michael.christie@oracle.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  msizanoen1 <msizanoen@qtmlabs.xyz>
  Niklas Schnelle <schnelle@linux.ibm.com>
  Ole Ernst <olebowle@gmx.com>
  Oleksij Rempel <o.rempel@pengutronix.de>
  Paolo Bonzini <pbonzini@redhat.com>
  Pavankumar Kondeti <quic_pkondeti@quicinc.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Pierre Gondois <Pierre.Gondois@arm.com>
  Qais Yousef <qais.yousef@arm.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Randy Dunlap <rdunlap@infradead.org>
  Rob Clark <robdclark@chromium.org>
  Russell King <rmk+kernel@armlinux.org.uk>
  Santosh Shilimkar <santosh.shilimkar@oracle.com>
  Sasha Levin <sashal@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Slark Xiao <slark_xiao@163.com>
  Stanislaw Gruszka <stf_xl@wp.pl>
  Stephen Boyd <sboyd@kernel.org>
  Stephen Suryaputra <ssuryaextr@gmail.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sven Eckelmann <sven@narfation.org>
  Sven Schuchmann <schuchmann@schleissheimer.de>
  Teng Qi <starmiku1207184332@gmail.com>
  Thomas Gleixner <tglx@linutronix.de>
  Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
  Tony Lu <tonylu@linux.alibaba.com>
  Trond Myklebust <trond.myklebust@hammerspace.com>
  Vasily Gorbik <gor@linux.ibm.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Wang Yugui <wangyugui@e16-tech.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Wen Gu <guwen@linux.alibaba.com>
  William Kucharski <william.kucharski@oracle.com>
  Wolfram Sang <wsa@kernel.org>
  Xing Song <xing.song@mediatek.com>
  Xiongfeng Wang <wangxiongfeng2@huawei.com>
  Zekun Shen <bruceshenzk@gmail.com>
  Zhang Changzhong <zhangchangzhong@huawei.com>
  zhangyue <zhangyue1@kylinos.cn>
  Zhou Qingyang <zhou1615@umn.edu>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   57899c4e26bf..e3c95128def1  e3c95128def1c937754a5cdc3d297fa47968e9f6 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 20:04:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 20:04:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242607.419573 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv3Am-0004ks-EF; Wed, 08 Dec 2021 20:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242607.419573; Wed, 08 Dec 2021 20:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv3Am-0004kl-Az; Wed, 08 Dec 2021 20:04:16 +0000
Received: by outflank-mailman (input) for mailman id 242607;
 Wed, 08 Dec 2021 20:04:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=n09u=QZ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mv3Al-0004kf-RB
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 20:04:15 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02a20b6b-5862-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 21:04:13 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 596F7CE233D;
 Wed,  8 Dec 2021 20:04:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F2DFC00446;
 Wed,  8 Dec 2021 20:04:07 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02a20b6b-5862-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1638993847;
	bh=MIhJ8lZkdDtebo1SC8dEsnZC72impxjCzMMry55F/2M=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=jt2CwxWA5UYViyNnMh2H2roU2XMx6AjwJ1jUllhWvhEqPo7XbCNcDmHWk1O/ORP0l
	 qqSbKCYv5hsiSZ31FnWw/AkqTMsks5McSj07TQWXC3vkmvoLyl49RgiVpkwqy2oUYW
	 dZoMNf5Awj8z/1ayvCOUB1n+C3Ghub10yqAHqUFO1CqD3VmKWJnJfJyU4fWd0ahkD+
	 tPfJNOmeAmzW5NfSiqEonGD7yn3OYHcNS7Ys59kYrs2Zvb2w2LLUDEQ0uXQCS35Td3
	 cHyUnZDp90kdD03znu3C0TNLFCXxi+LyyqkgpTJLaJ4MJucSd0xGvReAz1yXjeHUDp
	 +TkDrT1v8CzKw==
Date: Wed, 8 Dec 2021 12:04:06 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    Ian Jackson <iwj@xenproject.org>
Subject: Re: [PATCH] MAINTAINERS: widen Anthony's area
In-Reply-To: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112081203550.4091490@ubuntu-linux-20-04-desktop>
References: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 8 Dec 2021, Jan Beulich wrote:
> As was briefly discussed on the December Community Call, I'd like to
> propose to widen Anthony's maintainership to all of tools/. This then
> means that the special LIBXENLIGHT entry can go away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Note that we're still looking for a 2nd maintainer there, considering
> that Wei's time is rather limited.
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -375,9 +375,11 @@
>  
>  LIBS
>  M:	Wei Liu <wl@xen.org>
> +M:	Anthony PERARD <anthony.perard@citrix.com>
>  R:	Juergen Gross <jgross@suse.com>
>  S:	Supported
>  F:	tools/include/libxenvchan.h
> +F:	tools/include/libxl*.h
>  F:	tools/include/xencall.h
>  F:	tools/include/xenctrl*.h
>  F:	tools/include/xendevicemodel.h
> @@ -393,15 +395,6 @@
>  F:	tools/include/xentoollog.h
>  F:	tools/libs/
>  
> -LIBXENLIGHT
> -M:	Wei Liu <wl@xen.org>
> -M:	Anthony PERARD <anthony.perard@citrix.com>
> -S:	Supported
> -F:	tools/include/libxl*.h
> -F:	tools/libs/light/
> -F:	tools/libs/util/
> -F:	tools/xl/
> -
>  LIVEPATCH
>  M:	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>  M:	Ross Lagerwall <ross.lagerwall@citrix.com>
> @@ -514,6 +507,7 @@
>  
>  TOOLSTACK
>  M:	Wei Liu <wl@xen.org>
> +M:	Anthony PERARD <anthony.perard@citrix.com>
>  S:	Supported
>  F:	autogen.sh
>  F:	config/*.in
> 


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 20:57:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 20:57:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242613.419586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv3zj-0003dG-4r; Wed, 08 Dec 2021 20:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242613.419586; Wed, 08 Dec 2021 20:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv3zj-0003cl-1W; Wed, 08 Dec 2021 20:56:55 +0000
Received: by outflank-mailman (input) for mailman id 242613;
 Wed, 08 Dec 2021 20:56:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rXGX=QZ=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mv3zi-0003TN-9i
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 20:56:54 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5e89df8d-5869-11ec-a831-37629979565c;
 Wed, 08 Dec 2021 21:56:52 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e89df8d-5869-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1638997011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RI9goYiyaxxlyowVIy50GRXpRhCNUYZrM4r3seD1bKI=;
	b=NIPhL0sgn8M0aJUIi890pmZGlk891yoUSSDMnC4hnbyawxG2Kyh7G1sHH/xsmtSWUM8FfZ
	FyiBCPJVbWpXpFfMUl77mb1l8QqDIF5HigALgdn/RYqTMPCpOHMr0KIFCokDN7aLnrEdks
	8rrnfZKCxcaetGnTQyHUg4mAfEc2N1sxXiIWn5IbWqnhikYmOYt6fknKqXzV7CdqL4P4H4
	8ZS0DFKNdnSGea2HezKm7Hkc6llGKcBl9S+VI9FjnibvCSYHAcSlNTnETtfGbCxdf3f6N4
	HjxoAKj0UnKj8JjZlpBFr0/NMCZQnVLvInv7aT9TCLkwNt6S0nNqOl/aBjfedw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1638997011;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RI9goYiyaxxlyowVIy50GRXpRhCNUYZrM4r3seD1bKI=;
	b=KF19qqsUtSG+rWG9NpEYyzGIEvbq/ti9eoiMayWfd1iK3FYz9roP5HeWY227THj1hSYyZu
	bO4E+0TC1Z5Br/AA==
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>, Michael
 Ellerman <mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>, Thomas Bogendoerfer
 <tsbogend@alpha.franken.de>, linux-mips@vger.kernel.org, Kalle Valo
 <kvalo@codeaurora.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 sparclinux@vger.kernel.org, x86@kernel.org,
 xen-devel@lists.xenproject.org, ath11k@lists.infradead.org, Wei Liu
 <wei.liu@kernel.org>, linux-hyperv@vger.kernel.org, Christian Borntraeger
 <borntraeger@de.ibm.com>, Heiko Carstens <hca@linux.ibm.com>
Subject: Re: [patch V2 20/23] PCI/MSI: Move msi_lock to struct pci_dev
In-Reply-To: <20211208152925.GU6385@nvidia.com>
References: <20211206210147.872865823@linutronix.de>
 <20211206210224.925241961@linutronix.de>
 <20211208152925.GU6385@nvidia.com>
Date: Wed, 08 Dec 2021 21:56:50 +0100
Message-ID: <871r2m24tp.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Dec 08 2021 at 11:29, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:27:56PM +0100, Thomas Gleixner wrote:
>>  	if (!desc->pci.msi_attrib.can_mask)
>
> It looks like most of the time this is called by an irq_chip, except
> for a few special cases list pci_msi_shutdown()
>
> Is this something that should ideally go away someday and use some
> lock in the irq_chip - not unlike what we've thought is needed for
> IMS?

Some day we'll have that yes.


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 21:24:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 21:24:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242620.419598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv4Q3-000832-EJ; Wed, 08 Dec 2021 21:24:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242620.419598; Wed, 08 Dec 2021 21:24:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv4Q3-00082v-B9; Wed, 08 Dec 2021 21:24:07 +0000
Received: by outflank-mailman (input) for mailman id 242620;
 Wed, 08 Dec 2021 21:24:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Aoc2=QZ=linaro.org=mathieu.poirier@srs-se1.protection.inumbo.net>)
 id 1mv4Q2-00082p-6a
 for xen-devel@lists.xenproject.org; Wed, 08 Dec 2021 21:24:06 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2b6277f0-586d-11ec-9d12-4777fae47e2b;
 Wed, 08 Dec 2021 22:24:04 +0100 (CET)
Received: by mail-ed1-x52a.google.com with SMTP id y13so12738539edd.13
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 13:24:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b6277f0-586d-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=JrYOi4lbhFPKxumTZaVTTwLIJ849fzGNHXgMbyyfS7M=;
        b=HCcIq0tXA3gM2D+IjYT55I0ZFL76TjmjvqqbYX6+rArCitKzwncgIE/ggLlrXDp4mA
         vJBjL1UESFH6staSbffun56vUTAE2h0cChvX+GCRxrHis16pqcVl+9Z/D0ggmnvl2Qge
         pBMamdTe7SpT/a118wewxTOEgjGavfzd/UatU9hnluc42fKOlrITXUk84Ye260bo2qP4
         XclNn0dhfiDwa7OA6iRkHGx3cqTAoasGl8aBPS/1KZ625YTWye1vlaLd3I/xWUrG2oMR
         VEUXGM4ULz2sfH2Hx5al7smD70Wya8LVaCtWSIyT9jVLHMEa3SxhIJBPKLXL4SzIeVdn
         ZPAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=JrYOi4lbhFPKxumTZaVTTwLIJ849fzGNHXgMbyyfS7M=;
        b=3lt5NRHSpfekktNRHiRywr3wrFyDO0V1hjP9TVcvae58+b4fy2LXQ/bDs6kQLakC3H
         kQpQmJndc8fWaHf7PDzt16x/HCN6MmEoQvE+o2w6n+2diFSHap+qfkW9qp3MsfhhmOhC
         oR4WTrlye35oRoluw/wEDueLAAE6GVk9zJYAWfVyX/z/Vh71u/SPdj7PMxX7ntYSAIx5
         Cwt5G/4Ks7ejOZQygBtmsNBFaJ7l3ei6V0z6TCIfspbO1dGWvhngd4i/cpTMdxyjYdib
         9BtL8KS1SyiClIAQ8BOqEI1wPk4ln9NOki+yi/5IT7oiSy+cL4N3MJWRjEWFGIaJvXsg
         Q3OQ==
X-Gm-Message-State: AOAM530S83ExpOR+77tkZZbUJj6VeXGuBlrluZqo55YrPcu1EwRuAqTE
	3osK+fwt23mRZeAGHYipg409ydMxmsjOviKAsfXjzo57oTeHyQ==
X-Google-Smtp-Source: ABdhPJyCFGiWRrVY+EcijPysiRmXqBNXoqeJ0A+C7fvjhieuN9s/A/ln6v1NtLksxklWZux95hI/0EXQHudcBJ2L6ic=
X-Received: by 2002:a05:6402:3459:: with SMTP id l25mr23184346edc.137.1638998644034;
 Wed, 08 Dec 2021 13:24:04 -0800 (PST)
MIME-Version: 1.0
References: <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com> <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
 <074326cc-f910-2cad-be1f-e27480f53b67@arm.com>
In-Reply-To: <074326cc-f910-2cad-be1f-e27480f53b67@arm.com>
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: Wed, 8 Dec 2021 14:23:52 -0700
Message-ID: <CANLsYkyF4Mv+MhyKJ-B4-56G=RVu6U3=OAraK5ZtnOx6TaW1UQ@mail.gmail.com>
Subject: Re: Aarch64 stand-alone application for Xen
To: Michal Orzel <michal.orzel@arm.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Wed, 8 Dec 2021 at 07:19, Michal Orzel <michal.orzel@arm.com> wrote:
>
> Hi Mathieu,
>
> On 08.12.2021 01:06, Mathieu Poirier wrote:
> > Hi Bertrand,
> >
> > On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
> >>
> >> Hi Mathieu,
> >>
> >>> On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >>>
> >>> Good day,
> >>>
> >>> I am in the process of adding support for aarch64 to the xen-sys
> >>> crate[1].  The crate currently supports x86_64 and includes a
> >>> stand-alone "oxerun" application that can be used to validate
> >>> hypercalls.  My goal is to provide the same functionality on arm64.  I
> >>> am looking for a stand-alone aarch64 example, something like an "hello
> >>> world" to help me with the assembler startup code.
> >>
> >> We are working on porting XTF to arm64 and already have something running.
> >> I think it could be a good starting point for you:
> >> https://github.com/orzelmichal/xtf/tree/arm-devel
> >
> > Quick one - have you been able to get the "test-arm-64le-example"
> > application to run?  So far Xen gives me the following error:
> >
> > (XEN) ****************************************
> > (XEN) Panic on CPU 0:
> > (XEN) Unable to copy the kernel in the hwdom memory
> > (XEN) ****************************************
> >
> > I wanted to check with you before starting to dig into it.
> >
>
> ICYDK, 64le environment is used to create non-MMU domain in contrast to mmu64le.

Right.

> It lacks support for PV console and other important features of Xen.

I'm good with that - for now all I want is to test hypervisor calls I
developed in Rust.

> But we are able to run it without any issue.
> Please keep in mind that as there is no MMU you need to pay attention to the load address.
> By default for non-MMU domain, the address is 0x40000000 which is the correct address if you use XTF as a guest.

I was trying to boot XTF as dom0 using the default address
(0x40000000), which lead to the output depicted above.

> If you want to run non-MMU XTF as dom0, you need to specify the correct load address by passing CONFIG_LOAD_ADDRESS=<address>
> when invoking make. For example on QEMU it would be CONFIG_LOAD_ADDRESS=0x80000000.
>

When adding the compilation flag "CONFIG_LOAD_ADDRESS=0x80000000" I
get further [1].  For my own education, why is address 0x80000000
required when running a non-MMU XTF as dom0?  Is this a Xen thing?

The application crashes in the loop on line 135 [2] and I am wondering
if it wouldn't be related to the QEMU emulation. My setup is as
follow:

. QEMU startup command [3]
. XTF baseline: "c14f7dd289a4 (xtf: Add arm support into xtf-runner)"
. Xen baseline: "c76cfada1cfa (tools/libacpi: Use 64-byte alignment for FACS)"

Best regards,
Mathieu

[1]. https://pastebin.com/3AVXRGXD
[2]. https://github.com/orzelmichal/xtf/blob/arm-devel/arch/arm/arm64/head.S#L135
[3]. https://pastebin.com/52aVAFha

> > Thanks,
> > Mathieu
> >
> >>
> >> Regards
> >> Bertrand
> >>
> >>>
> >>> Many thanks for the consideration,
> >>> Mathieu
> >>>
> >>> [1]. https://crates.io/crates/xen-sys
> >>>
> >>
> >
> Cheers,
> Michal


From xen-devel-bounces@lists.xenproject.org Wed Dec 08 22:13:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 08 Dec 2021 22:13:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242626.419609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv5BB-0006l4-5d; Wed, 08 Dec 2021 22:12:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242626.419609; Wed, 08 Dec 2021 22:12:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv5BB-0006kx-2W; Wed, 08 Dec 2021 22:12:49 +0000
Received: by outflank-mailman (input) for mailman id 242626;
 Wed, 08 Dec 2021 22:12:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv5BA-0006kn-12; Wed, 08 Dec 2021 22:12:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv5B9-0007P8-SU; Wed, 08 Dec 2021 22:12:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv5B9-0005op-II; Wed, 08 Dec 2021 22:12:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mv5B9-0000t6-Ho; Wed, 08 Dec 2021 22:12:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3XZV+Kss58PhAGVFeNInK0/KnJAl9G4JNBIt5YuggkQ=; b=AkQUFGvt2jTlFc9Xq/hEjpU4y5
	9gglp6erItQW/dnZ247zuIH28Kc4H4utELtZrdcjvH2PxgEP5JQxihMZbbpuH8Zccfjf5SIO9FQzY
	t2Cm/gpZEfgdYzb5l8pJf9O7vNUd9s0zUFPvn6k+Rfe8LymyE2B7rbNHvw8ZrKPj5acE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167235-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167235: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
X-Osstest-Versions-That:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 08 Dec 2021 22:12:47 +0000

flight 167235 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167235/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87
baseline version:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1

Last test of basis   167220  2021-12-06 19:00:28 Z    2 days
Testing same since   167235  2021-12-08 17:03:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   608531a0cc..c62d634cce  c62d634cce8b1507d00a61bfc8168ac42367fe87 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 00:04:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 00:04:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242634.419622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv6v2-0005Wv-8u; Thu, 09 Dec 2021 00:04:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242634.419622; Thu, 09 Dec 2021 00:04:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv6v2-0005Wo-63; Thu, 09 Dec 2021 00:04:16 +0000
Received: by outflank-mailman (input) for mailman id 242634;
 Thu, 09 Dec 2021 00:04:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mv6v0-0005Wh-H9
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 00:04:14 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 897fc6e6-5883-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 01:04:12 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id l7so6452388lja.2
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 16:04:12 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id n14sm376546lfu.285.2021.12.08.16.04.09
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 08 Dec 2021 16:04:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 897fc6e6-5883-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=NwkfgwE4hFBKZOW6AEiviT1UwHpyhZyudjz2jFh5pGs=;
        b=X4vu2guvvme1GenhG1YxA9LNY4p/yipWtN9Kyoc4It4SP0xJ1KI2qumwOEyNJxOXnG
         xx9Sthx5uQTmF6bKpQPYEImtzJbZtBpL5ErzUi4f7OcjqEsMe/gkQXDLX2dEluE6hylE
         IF0MNaKpcZp4f0YgeDdXVjtG6HJkqsd8P8fVrTiYSWtvxILZJDrL5f099w3RbvObkiuS
         GDf7luj1TFhO4VAm7bq8e8sZzd3GzLN46ID/eoOD7TRrcYhyT4SMez+LOt5TgFsSBfYm
         tE4JJgXxiK184TA3/nzom1OShnA+mpRWR1KQFlwkQQ0+YivYT1V0sH5HbTpWWzYjzZvl
         WPxg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=NwkfgwE4hFBKZOW6AEiviT1UwHpyhZyudjz2jFh5pGs=;
        b=TCNslf1GzIInIHMe+JPMl2vl4kiZR5nr2OqZJNDt8AvXK6rmIeXav8q4O9zodGFsV+
         XB3m3iM090KZR+c5XUWOgu4Px8rGraVSI7U5fnvOj4hZsySryxFiYHnp2faTeAg6Ex6P
         cvM/+413DTz//doRc/G1JxD/NZAXEnjkfAzXO3hDqkQdRC761Jj8Z558ADEZcf9IQ9eQ
         RqIvbQpYMm85X9OBzKh1y3F/LinAh9/mcmfzBZPlOCLvGGNE2sLhryLMekwOorHPYk0y
         xTYBY+qRtSzS/K4wJ+dPOTbrso9vuZIdWZ6SUhygdosbAhJw8Y0heynmHb7rYpmfStPk
         XBtQ==
X-Gm-Message-State: AOAM53219lcdW6g2dUlXZ4O1O6sbR06ATFU6Zmo+lMY7o+Bys8+QSBJu
	aTaVJtM2/3R8Pg6Sud8wFVg=
X-Google-Smtp-Source: ABdhPJyk013Xzz0RmSxuRkrQ663IkNcmRsJXkp7HTUtRcNHFgY5U5UOFwTjTh/OcCcBciYUb29C/uw==
X-Received: by 2002:a2e:bc1c:: with SMTP id b28mr2747279ljf.500.1639008250838;
        Wed, 08 Dec 2021 16:04:10 -0800 (PST)
Subject: Re: [PATCH V3 4/6] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Julien Grall <julien@xen.org>
References: <1637787223-21129-1-git-send-email-olekstysh@gmail.com>
 <1637787223-21129-5-git-send-email-olekstysh@gmail.com>
 <alpine.DEB.2.22.394.2111241701240.1412361@ubuntu-linux-20-04-desktop>
 <c2e8c00a-3856-8330-8e8f-ab8a92e93e47@gmail.com>
 <alpine.DEB.2.22.394.2112071506370.4091490@ubuntu-linux-20-04-desktop>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <50997667-7c6c-491d-ff04-11e093fee7f0@gmail.com>
Date: Thu, 9 Dec 2021 02:04:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2112071506370.4091490@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 08.12.21 01:36, Stefano Stabellini wrote:


Hi Stefano

> On Thu, 25 Nov 2021, Oleksandr wrote:
>>>> Please note the following:
>>>> for V3 arch_xen_unpopulated_init() was moved to init() as was agreed
>>>> and gained __init specifier. So the target_resource is initialized there.
>>>>
>>>> With current patch series applied if CONFIG_XEN_UNPOPULATED_ALLOC
>>>> is enabled:
>>>>
>>>> 1. On Arm, under normal circumstances, the xen_alloc_unpopulated_pages()
>>>> won't be called “before” arch_xen_unpopulated_init(). It will only be
>>>> called "before" when either ACPI is in use or something wrong happened
>>>> with DT (and we failed to read xen_grant_frames), so we fallback to
>>>> xen_xlate_map_ballooned_pages() in arm/xen/enlighten.c:xen_guest_init(),
>>>> please see "arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT"
>>>> for details. But in that case, I think, it doesn't matter much whether
>>>> xen_alloc_unpopulated_pages() is called "before" of "after"
>>>> target_resource
>>>> initialization, as we don't have extended regions in place the
>>>> target_resource
>>>> will remain invalid even after initialization, so
>>>> xen_alloc_ballooned_pages()
>>>> will be used in both scenarios.
>>>>
>>>> 2. On x86, I am not quite sure which modes use unpopulated-alloc (PVH?),
>>>> but it looks like xen_alloc_unpopulated_pages() can (and will) be called
>>>> “before” arch_xen_unpopulated_init().
>>>> At least, I see that xen_xlate_map_ballooned_pages() is called in
>>>> x86/xen/grant-table.c:xen_pvh_gnttab_setup(). According to the initcall
>>>> levels for both xen_pvh_gnttab_setup() and init() I expect the former
>>>> to be called earlier.
>>>> If it is true, the sentence in the commit description which mentions
>>>> that “behaviour on x86 is not changed” is not precise. I don’t think
>>>> it would be correct to fallback to xen_alloc_ballooned_pages() just
>>>> because we haven’t initialized target_resource yet (on x86 it is just
>>>> assigning it iomem_resource), at least this doesn't look like an expected
>>>> behaviour and unlikely would be welcome.
>>>>
>>>> I am wondering whether it would be better to move
>>>> arch_xen_unpopulated_init()
>>>> to a dedicated init() marked with an appropriate initcall level
>>>> (early_initcall?)
>>>> to make sure it will always be called *before*
>>>> xen_xlate_map_ballooned_pages().
>>>> What do you think?
>>     ... here (#2). Or I really missed something and there wouldn't be an issue?
> Yes, I see your point. Yeah, it makes sense to make sure that
> drivers/xen/unpopulated-alloc.c:init is executed before
> xen_pvh_gnttab_setup.
>
> If we move it to early_initcall, then we end up running it before
> xen_guest_init on ARM. But that might be fine: it looks like it should
> work OK and would also allow us to execute xen_xlate_map_ballooned_pages
> with target_resource already set.
>
> So I'd say go for it :)


Thank you for the confirmation! In order to be on the safe side, I would 
probably leave drivers/xen/unpopulated-alloc.c:init as is, I mean with 
current subsys initcall level (it expects the extra memory regions to be 
already filled)
and create a separate unpopulated_init() to put 
arch_xen_unpopulated_init() into. Something like the following:

static int __init unpopulated_init(void)
{
     int ret;

     if (!xen_domain())
         return -ENODEV;

     ret = arch_xen_unpopulated_init(&target_resource);
     if (ret) {
         pr_err("xen:unpopulated: Cannot initialize target resource\n");
         target_resource = NULL;
     }

     return ret;
}
early_initcall(unpopulated_init);




-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 00:45:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 00:45:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242640.419634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7Z0-0002uq-DN; Thu, 09 Dec 2021 00:45:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242640.419634; Thu, 09 Dec 2021 00:45:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7Z0-0002uj-AR; Thu, 09 Dec 2021 00:45:34 +0000
Received: by outflank-mailman (input) for mailman id 242640;
 Thu, 09 Dec 2021 00:45:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv7Yz-0002uZ-HB; Thu, 09 Dec 2021 00:45:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv7Yz-00026h-Cz; Thu, 09 Dec 2021 00:45:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mv7Yz-0003ED-0h; Thu, 09 Dec 2021 00:45:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mv7Yz-0001cO-0G; Thu, 09 Dec 2021 00:45:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=e8exR9u2NjxWtgTCF4kkAVoUdhfvlg1klkktKO9jyiU=; b=lS9DnPK4ZrCIvoU9irwNwXi5tF
	fy48/EXgPn2tAEIjeyrw1W96mOYg9VenJCvSCk7dZsrS0z/voizGVrmXAsFpxNXUa3SU+w5pspfs0
	NE90zDyl4l3dT6fHLqhJuyizHSldXfMAEqKiS7r3SyXsNc/4qCozJutKjTMul2TT8DhY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167234-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167234: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-saverestore:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
X-Osstest-Versions-That:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 00:45:33 +0000

flight 167234 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167234/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm 17 guest-saverestore fail in 167223 pass in 167234
 test-armhf-armhf-xl-rtds     14 guest-start                fail pass in 167223
 test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 167223

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 167223 blocked in 167234
 test-armhf-armhf-xl-rtds    15 migrate-support-check fail in 167223 never pass
 test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 167223 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167223
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167223
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167223
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167223
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167223
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167223
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167223
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167223
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167223
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167223
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167223
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167223
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1
baseline version:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1

Last test of basis   167234  2021-12-08 12:04:03 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    fail    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 00:47:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 00:47:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242648.419647 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7aa-0003gY-10; Thu, 09 Dec 2021 00:47:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242648.419647; Thu, 09 Dec 2021 00:47:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7aZ-0003gR-UI; Thu, 09 Dec 2021 00:47:11 +0000
Received: by outflank-mailman (input) for mailman id 242648;
 Thu, 09 Dec 2021 00:47:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P/E5=Q2=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mv7aX-0003gL-Ux
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 00:47:10 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20624.outbound.protection.outlook.com
 [2a01:111:f400:7e88::624])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87db94b7-5889-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 01:47:07 +0100 (CET)
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5302.namprd12.prod.outlook.com (2603:10b6:208:31d::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Thu, 9 Dec
 2021 00:47:04 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Thu, 9 Dec 2021
 00:47:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87db94b7-5889-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XB8JpUYZUqhaaZfsAbnr6nxUMs7K+RhThO3vZH3TETnzKOdeOT2ciFwTHYXEQ8TyfVDWHAvQMk2hAP9Ju3tY8vrydnGi6DB02fimcHDTY2suoc0kMS8+bVevLU7FOLfAmJkUyu5KL36Tq67PQzDNv7XzxNJuwxqFvyLqWPETgzyltsIBuhEJ34FfbkYF6xFNQqv9PJEgr5fTtdFEEoc9LwUikVfReQWTVliAj1mIrDq7hPKj89umv3fj3agFNN3JNda/cHg6M35cf4cCGH9L3N02X6cK7qE6dz8hbxMhxD9YL8bkl1zkjJ8N7hfpquF3W5aPgDf2who7vgJgAyovGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DcTVV+Ei22uQ3QsSYsqc/2t1gTooA2VnriyB6SbTpXA=;
 b=YtTB56kxvnXaCDAppfLG/RddniC7Yo4XLEua/0A4E9NRMzK60v6UacvCASIU03+u0Ez6i39o/JlYiCEMVeb0GujRWm5PFnOIw88Dfsnr4Coz54pDGq4kS2fEanYoDoAs2LYE/7ksyia0P6gb4Rz6hGGBBpE3LzSNqsSHwfvzWQMvRIr9EuKp55i4fwD7SVessVXsQCzGze/Q8fe9KTiTNvGFBuX63MWPSB2LB2dCFh/T5r42wacgY7392MxL0H35M5LUumc9dmzNhgmKQX9FU8IHWwZh+bTXijQi8ec+wSwajOKOB6cdB7ltkCHaC9wRGmevHkSou0qbAy1+hTm5ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DcTVV+Ei22uQ3QsSYsqc/2t1gTooA2VnriyB6SbTpXA=;
 b=F5GCW4kkEFNbA5uo0h4WGmvJscAXmTM6otVGQ6+hbA7+mxbgTnLEnPl6oNvuAMmmaVPzf21JMi3P3+drgOx8ifkxhGFMsVPj/iwzW0iBGWsqbr6+EimzuFCWEgXzje9F3hjchs00M5Knija7L0TZcNqPs8SelHUtdspfXEs+PNqjsTLw0b2iSP+wizO2BvLsakG3wwCxUJse0rT0l/gpux64dgFQudKtVanyHZsQ2hChtBgfhvv7X5o9CL5l9XDZ4zKTtOpGkqTME1rZKefGihhFUNoLwCT14YXI/Pi3UXhdNnEOmm37IjVJ9bWLEBGyOxQ7SkibtmpDv89A+KjtQA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 20:47:02 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 02/31] genirq/msi: Add mutex for MSI list protection
Message-ID: <20211209004702.GL6385@nvidia.com>
References: <20211206210600.123171746@linutronix.de>
 <20211206210747.708877269@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210747.708877269@linutronix.de>
X-ClientProxiedBy: MN2PR17CA0016.namprd17.prod.outlook.com
 (2603:10b6:208:15e::29) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3c14e566-daaf-406c-77a3-08d9baad6afe
X-MS-TrafficTypeDiagnostic: BL1PR12MB5302:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB53026A671AD1BB462EA37021C2709@BL1PR12MB5302.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iZSdN6zaq0rHllMmOHawJEe2xbP54HWpMgxdC47tlUZpX7MXHAZaK4jGl33lz70+c+/Rez18WL3zBe/2RaI+1D3F9L9CICl9k5yGo66TyTdBTvQDLIL47CFFSDHwe0zytJhKh27/T/NDhxdfVNsaeXFg7QT8fWB7k/iV42t1NsK06f3T0PLQQaxKBim6yn11tSIMaQo49lfJr81I0GJ426iVwT+177bRKiCr5ZawDXQGrSSH3dBJJxGbEj8sZkHX5HluFKTXqtwN3eWXweeYMiD9V9FWWhu8ht9H3Uy6ODAOVy6uQMPPgK/IG8LzQw3TXcJNTP4AHJ1gCZTUltzyNQSvfW3+MNJcnvKYV0gaGiJCsi6MCAoCjZ8lLRIiVQME5NcS8N/Y/o9bWnOJPh4Z1pnQPjxoyL5wgeDmQ9bBmnVLbVVFCgOlvCIEl6ijQsZ2UliPMHMH3Q7GerMnYzdXkhEztnWRoBWs3I+PDRrsEv2Hr+CBv6nfNFQeH+GbIub1MxErQPmQ3k7taBsfPNy1PQD6vgyhfpeXDSbWSi9zziopkfplkQsxToQmRsGnJUu8werBG8YbLqw3T+vRd04ArDf7fOuXSl5bbgpM+CfBEg/qOedEh7lsjgRbN8lCv2O0hNaxd8TW6PVdR4lIoPaqZg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(1076003)(33656002)(4744005)(7416002)(8936002)(4326008)(86362001)(83380400001)(8676002)(6486002)(6512007)(2906002)(66556008)(38100700002)(66946007)(66476007)(186003)(2616005)(6506007)(26005)(6916009)(316002)(54906003)(5660300002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IhnJsqHq/qBxb2jYgaHL8ooQrKSsvmcu/5qZaYYSkI20/1gw+Vhgb4bTPq0Q?=
 =?us-ascii?Q?Gf5pePMzGeQ24KGMZBiJpCEJxz/ZIzh1OuGqzUdmXbzstFa69j3LaDxh3+t0?=
 =?us-ascii?Q?vgONaX4CD6WjGj/Fq2q2xAPeOhdWrwNDKAxtkUYGGHtzKJIGw3zhAtdDMtQC?=
 =?us-ascii?Q?eclDzq+d9u2mG1xK7lU8Pxt7sI8eU+SASWJqMBKq5Te1lFe6w4wVohWSvD2N?=
 =?us-ascii?Q?jUGY3+5C9SVj5kIOKVzae0bl5IsxexpreTxiTdnI1kRF9ryqBDn4aTPdkhjD?=
 =?us-ascii?Q?/GhZKFADlqN2s+pGVjsECEftQ6C4c8AHpgbbC5yVha+BBmLAPQ+9qMAtf4H8?=
 =?us-ascii?Q?OAO0e7dC4+3ufqhiPL4fNhOKNeyOcJ5ESolsTUGPeZwz96y7AhLY+/GQISky?=
 =?us-ascii?Q?ccTMEckAUa32KpKtvjDI/Fy7Pl4CX8jCrNhYemgPyScO6sWRBudpEXw9WqQq?=
 =?us-ascii?Q?naK1/qlJnOjdPPkelzQ7G9X1YlZwONYp17EVlHoTkThOxTuEtWWFmNdGp/9O?=
 =?us-ascii?Q?0HacfLg1Um+ONjBNXifqasbG+cH6uZabPuKy/C9b4Adc5e3TnEs8+lSWDEyO?=
 =?us-ascii?Q?XhN0E80UAN3WFCdvvCwiRugmwmSf80FtSClBkptSiKAdjnTFqC5hm0kBPocV?=
 =?us-ascii?Q?03UzVlKbg8F974AJaS7rRwjRwS/Tcrlae6dIIKJtX8+nXi1KRnkzyFuOKUCj?=
 =?us-ascii?Q?HPQt8N0SR/fW1ymFWkOkZcSzCAhjpeSZhqSSsrJDCbx4cPZZzwmHKpuPKfqE?=
 =?us-ascii?Q?Ih8+5bz1qqunPknmpHrkN1KNNHUq8U8HfRzccfwA5FameF4auKSkDj/b2BrX?=
 =?us-ascii?Q?yJ1OhuRLCq1dIZBoQQL1yAN5BvSe+HDYBQLfAOaiSqxRISIAeU9dvaaqKm49?=
 =?us-ascii?Q?90Qd/ouNmreqYUHpyL2BcyInexO3UN7Q9EpqtHOV14rVySvGv86qj7InZtcd?=
 =?us-ascii?Q?t6JmlV8rmAOibM8JWOQOHvIPara1+aniVv/CXrNAGxrG8qMpIEerM8z8raa6?=
 =?us-ascii?Q?JzjXmya4nTNnvlXCciYfR8fXmepXn559k6Dsp+OndWi7EWDNmEqcSvkLP7Ve?=
 =?us-ascii?Q?ExhRvcFxpk9p9Ns5XSmfWf8Lav8kUt14BwGwIw7F0ezZyvLjjG5GBMW2LXCt?=
 =?us-ascii?Q?oD9I6XNdy69x0q/QI/embTs3L+aRC4DiUe2U/s5K4i+euts1oSKoTSVGhMPS?=
 =?us-ascii?Q?2V1NeBNrPVFwvOdTtMaWfpx+F0zyKGUxXLYJs2XGFVqnMyXbG+BIPkatNfmf?=
 =?us-ascii?Q?2wdCgOMRjlOaW1A2tIxYJtzCzrFOnFRnb5ZBRzjNEIT1Kiofyzq20g7wiC0V?=
 =?us-ascii?Q?3iQSmW7V1ujCl31IWixOw4ZpDdjo4pdKB7DLUFLIIf7rzKA5NfdLv6FDwCZL?=
 =?us-ascii?Q?8YdKjB6Lgrxy8GCodikahFQ6QGOXiVabTJ66GvS1H+ZBLuIMTPTHwpyUNswC?=
 =?us-ascii?Q?X6eCipMewdNRSYOXEhggOWegxVpyXupYaZUXhuqidW5JaxOm4MuKS9SKwT8M?=
 =?us-ascii?Q?uxRKJ+eQu/E0AcHd20qNEN03SYShxCbLV3Uo0O4B3M8zXh/mytjtq7OwLeKb?=
 =?us-ascii?Q?ijq7hSUr0nnjSFFapEI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c14e566-daaf-406c-77a3-08d9baad6afe
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 00:47:03.9305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mw9FYEpaoBsAeiwIYYxisGGhScNaHffggJWKK9TqDuFHAggnPKGHyOBgz/wnnSy4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5302

On Mon, Dec 06, 2021 at 11:51:05PM +0100, Thomas Gleixner wrote:
> +++ b/kernel/irq/msi.c
> @@ -127,12 +127,37 @@ int msi_setup_device_data(struct device
>  		return -ENOMEM;
>  
>  	INIT_LIST_HEAD(&md->list);
> +	mutex_init(&md->mutex);
>  	dev->msi.data = md;
>  	devres_add(dev, md);
>  	return 0;
>  }
>  
>  /**
> + * msi_lock_descs - Lock the MSI descriptor storage of a device
> + * @dev:	Device to operate on
> + */
> +void msi_lock_descs(struct device *dev)
> +{
> +	if (WARN_ON_ONCE(!dev->msi.data))
> +		return;

Is this useful? Other places that call msi_lock_descs will continue on and deref
null dev->msi anyhow - is the dump from the WARN_ON that much better
than the oops from the null deref here:

> +	mutex_lock(&dev->msi.data->mutex);

?

Honestly, still a bit unclear on what the community consensus is for
using WARN_ON.

Jason


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 00:59:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 00:59:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242655.419659 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7ma-0005ze-4O; Thu, 09 Dec 2021 00:59:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242655.419659; Thu, 09 Dec 2021 00:59:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7ma-0005zX-1M; Thu, 09 Dec 2021 00:59:36 +0000
Received: by outflank-mailman (input) for mailman id 242655;
 Thu, 09 Dec 2021 00:59:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PYs1=Q2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mv7mY-0005zR-Vm
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 00:59:34 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 44fd490e-588b-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 01:59:33 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AFC80B82269;
 Thu,  9 Dec 2021 00:59:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26C2EC00446;
 Thu,  9 Dec 2021 00:59:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44fd490e-588b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639011570;
	bh=JBRUvmlqtKYO6wmUvlnMnb6NAQ+n15ncBLmNykYGTq0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dSuHHwnCyqSZ83TbfNBdfPANK+Eritcp33WaSlkA1QczlgssS7cWwZ+t4F5Nu6SgV
	 wX4FMJ2s3BwWeULH5+46ezf6G+4IkoezR4TgNj2lF0vSEEknEfs1KqcQFhiPRHfagR
	 pYJD/7oKp78ewx9YbKMGkA8S+HTMVUKj+nD5/UvKFkm1JGajtPjoWRgBxIL9eLCCp2
	 6l/rCq0Ry1TVwCpNN43m+wgLzJ7JgFJLm7GfRnFgBZZpRIFvK/QIP+8aaUPMRT2VzB
	 OTZJPgK5BWVxOKi8jNSuw0fsAkqh9vkldVoAYQ3UBjiXfhWLP48eIFYiKE8ao+H4Zr
	 1J+KYSfFui8Cg==
Date: Wed, 8 Dec 2021 16:59:28 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr <olekstysh@gmail.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V3 4/6] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
In-Reply-To: <50997667-7c6c-491d-ff04-11e093fee7f0@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2112081659090.4091490@ubuntu-linux-20-04-desktop>
References: <1637787223-21129-1-git-send-email-olekstysh@gmail.com> <1637787223-21129-5-git-send-email-olekstysh@gmail.com> <alpine.DEB.2.22.394.2111241701240.1412361@ubuntu-linux-20-04-desktop> <c2e8c00a-3856-8330-8e8f-ab8a92e93e47@gmail.com>
 <alpine.DEB.2.22.394.2112071506370.4091490@ubuntu-linux-20-04-desktop> <50997667-7c6c-491d-ff04-11e093fee7f0@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-157919797-1639011569=:4091490"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-157919797-1639011569=:4091490
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 9 Dec 2021, Oleksandr wrote:
> On 08.12.21 01:36, Stefano Stabellini wrote:
> Hi Stefano
> 
> > On Thu, 25 Nov 2021, Oleksandr wrote:
> > > > > Please note the following:
> > > > > for V3 arch_xen_unpopulated_init() was moved to init() as was agreed
> > > > > and gained __init specifier. So the target_resource is initialized
> > > > > there.
> > > > > 
> > > > > With current patch series applied if CONFIG_XEN_UNPOPULATED_ALLOC
> > > > > is enabled:
> > > > > 
> > > > > 1. On Arm, under normal circumstances, the
> > > > > xen_alloc_unpopulated_pages()
> > > > > won't be called “before” arch_xen_unpopulated_init(). It will only be
> > > > > called "before" when either ACPI is in use or something wrong happened
> > > > > with DT (and we failed to read xen_grant_frames), so we fallback to
> > > > > xen_xlate_map_ballooned_pages() in
> > > > > arm/xen/enlighten.c:xen_guest_init(),
> > > > > please see "arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for
> > > > > DT"
> > > > > for details. But in that case, I think, it doesn't matter much whether
> > > > > xen_alloc_unpopulated_pages() is called "before" of "after"
> > > > > target_resource
> > > > > initialization, as we don't have extended regions in place the
> > > > > target_resource
> > > > > will remain invalid even after initialization, so
> > > > > xen_alloc_ballooned_pages()
> > > > > will be used in both scenarios.
> > > > > 
> > > > > 2. On x86, I am not quite sure which modes use unpopulated-alloc
> > > > > (PVH?),
> > > > > but it looks like xen_alloc_unpopulated_pages() can (and will) be
> > > > > called
> > > > > “before” arch_xen_unpopulated_init().
> > > > > At least, I see that xen_xlate_map_ballooned_pages() is called in
> > > > > x86/xen/grant-table.c:xen_pvh_gnttab_setup(). According to the
> > > > > initcall
> > > > > levels for both xen_pvh_gnttab_setup() and init() I expect the former
> > > > > to be called earlier.
> > > > > If it is true, the sentence in the commit description which mentions
> > > > > that “behaviour on x86 is not changed” is not precise. I don’t think
> > > > > it would be correct to fallback to xen_alloc_ballooned_pages() just
> > > > > because we haven’t initialized target_resource yet (on x86 it is just
> > > > > assigning it iomem_resource), at least this doesn't look like an
> > > > > expected
> > > > > behaviour and unlikely would be welcome.
> > > > > 
> > > > > I am wondering whether it would be better to move
> > > > > arch_xen_unpopulated_init()
> > > > > to a dedicated init() marked with an appropriate initcall level
> > > > > (early_initcall?)
> > > > > to make sure it will always be called *before*
> > > > > xen_xlate_map_ballooned_pages().
> > > > > What do you think?
> > >     ... here (#2). Or I really missed something and there wouldn't be an
> > > issue?
> > Yes, I see your point. Yeah, it makes sense to make sure that
> > drivers/xen/unpopulated-alloc.c:init is executed before
> > xen_pvh_gnttab_setup.
> > 
> > If we move it to early_initcall, then we end up running it before
> > xen_guest_init on ARM. But that might be fine: it looks like it should
> > work OK and would also allow us to execute xen_xlate_map_ballooned_pages
> > with target_resource already set.
> > 
> > So I'd say go for it :)
> 
> 
> Thank you for the confirmation! In order to be on the safe side, I would
> probably leave drivers/xen/unpopulated-alloc.c:init as is, I mean with current
> subsys initcall level (it expects the extra memory regions to be already
> filled)
> and create a separate unpopulated_init() to put arch_xen_unpopulated_init()
> into. Something like the following:
> 
> static int __init unpopulated_init(void)
> {
>     int ret;
> 
>     if (!xen_domain())
>         return -ENODEV;
> 
>     ret = arch_xen_unpopulated_init(&target_resource);
>     if (ret) {
>         pr_err("xen:unpopulated: Cannot initialize target resource\n");
>         target_resource = NULL;
>     }
> 
>     return ret;
> }
> early_initcall(unpopulated_init);

Sounds good
--8323329-157919797-1639011569=:4091490--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 01:01:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 01:01:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242660.419670 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7o8-0008JP-H7; Thu, 09 Dec 2021 01:01:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242660.419670; Thu, 09 Dec 2021 01:01:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mv7o8-0008IW-CD; Thu, 09 Dec 2021 01:01:12 +0000
Received: by outflank-mailman (input) for mailman id 242660;
 Thu, 09 Dec 2021 01:01:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=P/E5=Q2=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mv7o7-0007c6-3S
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 01:01:11 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on2061d.outbound.protection.outlook.com
 [2a01:111:f400:7e89::61d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7b7b110a-588b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 02:01:05 +0100 (CET)
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5336.namprd12.prod.outlook.com (2603:10b6:208:314::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 9 Dec
 2021 01:01:02 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.013; Thu, 9 Dec 2021
 01:01:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7b7b110a-588b-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UvCbd4kDGQut/yGBRZzq4CNcchMR16AtWmODGIpoYhfE6o/cW2HJbyFb1D2avmx0bjTptDPDifkPaz6P+q6vTs2J/3QWzGb4mj81zWrrqUqtO5taBlJQttyMjWsqwPSlrHDvbZBv8823QLHJtL+tzpaCW5OQYEaU5NqaNpSYW8CLzgQIxztaGWImlT9kGn9Uz+GAbKdwGhAEuJ+n+FJ9sSIbIvQ+6Onziq3Q26YZR0Q4xcK22Pyk7eKAiDnUmal8Gg5gUPaw7Kq0ZkdEvCNngCO+61BVGccDSnkctwoE47W5Rm8X20uvcr/HbY+y4Xaap5Yl0Ce0+MTvM0Thp6YzZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KgiVroL99Eb0nfuME/RPoIYITyO9tKbqxVG0UmaTgnI=;
 b=BbxTC4JvtR97/ON/xGxCiUjq9gy2if+iHF35WKBXhw5FDoB/2ZdnLObc9YVwrJJlt+ojH8jzzdiBc8S+7IT4jvX+BBwd+xagRbTGKWe51G652ZmkaCIw1Xzrb/KTmt3uz3XOBzvJS6zaWxfFxvShgxE9jHTwEhfN4jMn6XJ1h+GtmmBc05TFIGN75lgEN+lrvps9cZtFJVSCSB3vaalnIPORtCKC4FHJfJhT+DIIObK10ZrvPLNwFZVeWRpPiuC7fHjOKKgc4amsH4Yl8jeHGSmZPYY3heET1aEHBdTIFJReNDDdBMmoMxx3HmUlxK3KAqZHcpZFy47R/2fE2lConQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KgiVroL99Eb0nfuME/RPoIYITyO9tKbqxVG0UmaTgnI=;
 b=szYOgFrXoNS1Q0eHU0JPXka6BAs/zPzusxtZh2SKA8Ds8Ona9pHGZuAsYMfRbAAyVpin27ERyR3DGBx7T70muSylsWw5ssJapsxVTwejCzMLOWE13r1kWTL2oFlVimRJDeiHvVaJvIUHfyx/iJwcOoyimu3VkdaiJhxwyV230RcEAD4b86FIyNesZR0+ZX+K2gZHBYT1Y7wCRpPNRF1SrMh01p+unK3kEzz6m/M16Hgf50geOIKKxLRo4r6gmoBRqjJTqOB9gVDp1I/ah82wvoVRneIgaasA0eL88yscCLke01+5w4aV3rRT2YpVc/N6v+IWSpNXQuWzIgZKVti+XA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Wed, 8 Dec 2021 21:01:00 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Logan Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>,
	Dave Jiang <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
	linux-ntb@googlegroups.com
Subject: Re: [patch V2 00/31] genirq/msi, PCI/MSI: Spring cleaning - Part 3
Message-ID: <20211209010100.GM6385@nvidia.com>
References: <20211206210600.123171746@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206210600.123171746@linutronix.de>
X-ClientProxiedBy: MN2PR19CA0045.namprd19.prod.outlook.com
 (2603:10b6:208:19b::22) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb2b6e79-f74f-49f0-cb95-08d9baaf5e8c
X-MS-TrafficTypeDiagnostic: BL1PR12MB5336:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB53365CBDAECB06902C026D8AC2709@BL1PR12MB5336.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	e17lyaqu5o5/7p3ntAAj6KuFyP+SAvPCdw1kW0GAKs8hmKhu4dY592nfacJ7yrTk5BrFP9pF0V36OizX+xtF1NtVgZOptQAEZsjh7B3TbkBqx8DXtJAXI79pIy11DZWL4JJKHy6KUVSWDpOwBV7352R6PzvhPA9OB5NjaYgnaGu/tupK+npuXVIT6K2jVfhJhXnTAIATAWyebbCMuo+VryfQWhF3827r0aKkkehAOhWY/CIu8lCy6aei6+I/yxaljhi9hksEMGHkz6Rgb6JmkvSuw3DZzUZk1CRGzn2MMjnTCMmkcUENCwfWD2hZbLAVEOtI3d1AHOgGIlPbuWMrPD4ezMF3BR2ELZHsZ8KRf+2O9t41PkwtWCCC91LW+3lYR+RA6qjmCW2WuDjLCfMDO7R2wC2J61iyF3/enJ8eorhnjmbeV1Esu9QaBSPxm8THCNhOFoH9xnLfIXidpe9q0Z91egFxvQ8yImflH36CZ7mUxisrozqbegiINuD9WIapAVErHy9ghW+oSIzXRxH0/mWDA58eQCFTmwsVcelfB4olk2DujWCDP7IpPX76NAZTR7uSVbXnV/FkBUBg969Et8r6kRcWGne978RAJyQMAEpUZniqIVIh54uQ1Ac97J80Z+W5V8oqbXLVOHU3n2JuVw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2616005)(66476007)(6916009)(2906002)(66946007)(4326008)(186003)(508600001)(6512007)(7416002)(66556008)(6506007)(1076003)(86362001)(38100700002)(33656002)(8936002)(8676002)(26005)(5660300002)(36756003)(4744005)(6486002)(54906003)(316002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?shMDjip6zDxHHhUR5OdRsGXgMFMHRWYs4sZfujZtVozMtzrjzTFPQjyrSIx8?=
 =?us-ascii?Q?omtSDQRdsTFLJ6Mgu2ug1Uz0h6SknWbu8DNfs8kKIHXd0lJH4IxD243tGA9C?=
 =?us-ascii?Q?4on2t4MQ+kL6XRVtdcr08oiJUYIUQp4tipOM3sCo7em07I06sow/1Ox8WixA?=
 =?us-ascii?Q?q6E2Td3wCbKPqw6FxUolKryjva/E85s18fnh7nYGoTl18eiOXm1YHxkSxXuG?=
 =?us-ascii?Q?GmaZ/ebgLDTtj3Aa3K8tIgWZ0NeQ8LSU1tAAWWuEG0C1hkrmd5Oc1vJ5OHxq?=
 =?us-ascii?Q?B12MbFmL/1kWrmhCE4WlxmszHKXkzJ4fpFhu8Cg2bCOLJQfLSvXWDlfyLVr8?=
 =?us-ascii?Q?bqki540ZTeFATnfq2wgPhSS8NHpBD14yJcImYfnOx5KiM0Li4yEVlV5Fv9IE?=
 =?us-ascii?Q?As4OvwVrxaPjfWzA3kIzAwd7SMT31z2TOhHsM+n+C4LacPRtwGHLW1PJf1NZ?=
 =?us-ascii?Q?mzDwBC1cc4ehs7pho0BiYBrqUycXMGcIsscYZPpUOU+nVGC7bQqh74mNKewR?=
 =?us-ascii?Q?vsxC0X5GcSCIhw4fFPuN5fU2RCOgAqsBJoQLgrviRZACjB+K3U72iy3wOdhs?=
 =?us-ascii?Q?N8C+kjU2bAymJlE5XWF+Um5FRcaZ6POCVo6hfecnryXLdFS9FlAspGNrziO5?=
 =?us-ascii?Q?kt0krhbNfUhavl3qbMuIzdM3H0rhf+6yuF8az15oKg3kQvCQzkNxkO5b+yaz?=
 =?us-ascii?Q?kolMo/5mZ0EJNPxq71ZA2pKn6D3gGSpxUZ3uQw3PROJj1x3nWLDimri0/966?=
 =?us-ascii?Q?UbDck4JTjuaNHqtpmKlL19UlhCn7a2R7BqRSmHuKn7/nRFIyOhLGqNrVVCkE?=
 =?us-ascii?Q?6/YXoVAz38p8o8d8/SeKvVjX58TwFmMFuHHAoZNuLQTcHm3Z7d1rFz22qP1I?=
 =?us-ascii?Q?RY+GJNiBjHLJlmtyU71FcLKEiyHHdo0DAt6KzNc538/Re22ZhEeC56Kd8bge?=
 =?us-ascii?Q?BVppaL7E5wSXf2UqHSgVN37oGpN1GUksBAlK8cbdU1alXDSYCq3aUzQ7RG1u?=
 =?us-ascii?Q?Pu7LkZUf2N6ajM5ud6T9c6aKXNEBs4qgBzL5VCgXGlciXa9EYhBbdpeGc/sQ?=
 =?us-ascii?Q?HypMDnmDr35vZcCGnkro56TJLUn2dIq/jEehKJUVHx1oXIGUp8UBpiYMrAmF?=
 =?us-ascii?Q?GT49cRyNB7ivkpviR6IPL+u1ZBvmM09Ts2k2aaomvFgje3mH2TQ5Y64dePxW?=
 =?us-ascii?Q?KFNKx43aywyGFxSGVNSxdAdOn5F+dmbnJa4hM5YxmbJkgTKtHkN2j7+3Dcwg?=
 =?us-ascii?Q?9c3hMi/76nXZbEal5CP8nmGseHAUX0hwpXM632u3E8ObsTuciqkPASfd6uaD?=
 =?us-ascii?Q?/fZTct4PYQXVfX+4gpLfIs8ltipj5tsDxHVyiZLzDWRFIjj1Mqb9SDmLSKkY?=
 =?us-ascii?Q?XWi3HLR7+UjHEfUGkPGVWnDgy/0HZHWoeVksytpNzmXSLOP7jZFj3BA3DZip?=
 =?us-ascii?Q?Kdo9gh7v8rODP8cZfy34t54uZVQAMto9DAj2dqwvBzs3xqo6/ue3k0c7z5nG?=
 =?us-ascii?Q?uT1bUnZyYkoo+joTvN7JabYbZEzdb96Gvjsf5z9r0kBYlnXHsBbw6iOSHT0d?=
 =?us-ascii?Q?zU0DcX2WcswaFrAmk/Y=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb2b6e79-f74f-49f0-cb95-08d9baaf5e8c
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 01:01:02.0307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ac5j/fEW5mAA9d0JCPW6WGG1MEYtFnJRc1YLJlObCO0269ZPl958o0fLCYYWvNi+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5336

On Mon, Dec 06, 2021 at 11:51:02PM +0100, Thomas Gleixner wrote:
> This is the third part of [PCI]MSI refactoring which aims to provide the
> ability of expanding MSI-X vectors after enabling MSI-X.

I read through this and didn't have any substantive remarks

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 06:04:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 06:04:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242668.419681 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvCWj-0008Jc-3z; Thu, 09 Dec 2021 06:03:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242668.419681; Thu, 09 Dec 2021 06:03:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvCWi-0008JU-Tx; Thu, 09 Dec 2021 06:03:32 +0000
Received: by outflank-mailman (input) for mailman id 242668;
 Thu, 09 Dec 2021 06:03:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WAzj=Q2=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1mvCWg-0008JO-Q1
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 06:03:31 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20602.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b996bdb1-58b5-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 07:03:27 +0100 (CET)
Received: from DB6PR0601CA0039.eurprd06.prod.outlook.com (2603:10a6:4:17::25)
 by AS8PR08MB6152.eurprd08.prod.outlook.com (2603:10a6:20b:298::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Thu, 9 Dec
 2021 06:03:24 +0000
Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:17:cafe::54) by DB6PR0601CA0039.outlook.office365.com
 (2603:10a6:4:17::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13 via Frontend
 Transport; Thu, 9 Dec 2021 06:03:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 06:03:24 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Thu, 09 Dec 2021 06:03:24 +0000
Received: from f9209bb38731.3
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 041B3678-C39A-46B7-A2F0-06EB170CB82E.1; 
 Thu, 09 Dec 2021 06:03:18 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9209bb38731.3
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 06:03:18 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com (2603:10a6:803:3d::28)
 by VI1PR08MB3167.eurprd08.prod.outlook.com (2603:10a6:803:47::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 9 Dec
 2021 06:03:16 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::8124:9971:1db2:b704]) by VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::8124:9971:1db2:b704%7]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 06:03:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b996bdb1-58b5-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vdCAXFgHsMOjyszWPKP8rGU4d8W89l5YnT6AcW7WDno=;
 b=3oOJly1jvCDqxY362zjjW6WRcdTcBteZRdbAvkAusXAHxs3pAkYzd6LHM8dbq4LRXpkpGJUd9acCwJhnUfor2WPqdgwJnAho/iRrmX5FTmDVuwgG4Fv2XKoel0Rfd2l+n++7PZTXsbm0T9JXQVmfxeiAQTmOEeTaeDw5b8y0XSc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Mm0YIs8UuPqK6qUp1z/beCOVeCLqmqydjGZH8whbfJhHEcR9s84ogQKeLvJceLnEshS28SijC6D045NEMQTP/JMYkcjMfiJ+rjof8d5dcznHeiYszFI07oeNg1HGhXFfeCwHazSJ0jzcW50lgU77Tmjx8v3B8Ssbzp/7QEjT5sSySr1yL+FrIyOt9FCVHU/YM8NLG6lUtSYrlnOc7GDfTsRjrzWjNyD6eI5al/LM/HM/d4J8WSGFCS5Y3llpYIuk4Yl2eNUdHVSvEEuO/iv/ZVRRVzwso+WifrTKxGdg1Va0Nc8wQ4lrUIoSHZFGbPQ5PQcB+6KQnQ5kcJ+quTxI/Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vdCAXFgHsMOjyszWPKP8rGU4d8W89l5YnT6AcW7WDno=;
 b=Sma2IonGFeh/cCIo+2fbDRBkdXdw3/nWcCw07ijNV6oy2ikt1eQu8HljThchcS5q3Ovt2gY3uabiQKAkM6RiR88elXxoyffmJZOZQnFMDJExgf2H8kjxtHIg4BIzngGUSxqPbK/hwAYYlwqExZN5TFcYMEs412dPJNE5pmtReIAS38w84I7483crCoc7TD4E6v/TcwTEMbPry9gflFCcyYAR0vUiFjKv/fKOcFra7PwGmwVyGZW84hgmm0/bUryNmfyXmtwC4lPGq7vC4Ph7N8RBHbw1/lJ+bbhrhpt9C8EqimSo7pdKzuqh6wNI3UKS/xM2yewxh7311pvR7Gc3qQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vdCAXFgHsMOjyszWPKP8rGU4d8W89l5YnT6AcW7WDno=;
 b=3oOJly1jvCDqxY362zjjW6WRcdTcBteZRdbAvkAusXAHxs3pAkYzd6LHM8dbq4LRXpkpGJUd9acCwJhnUfor2WPqdgwJnAho/iRrmX5FTmDVuwgG4Fv2XKoel0Rfd2l+n++7PZTXsbm0T9JXQVmfxeiAQTmOEeTaeDw5b8y0XSc=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Julien Grall <Julien.Grall@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>
Subject: RE: [PATCH V6 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Topic: [PATCH V6 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Index: AQHX7FUosCx1FrdSC0GOBgwOnMcEG6wpo4aA
Date: Thu, 9 Dec 2021 06:03:14 +0000
Message-ID:
 <VI1PR08MB3056D4987059BCF1B63AD89F92709@VI1PR08MB3056.eurprd08.prod.outlook.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-3-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638982784-14390-3-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: 9BF145D2DD175440BC1F4473C08B0753.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 4295dcfd-944b-45e0-4455-08d9bad99c4a
x-ms-traffictypediagnostic:
	VI1PR08MB3167:EE_|DB5EUR03FT006:EE_|AS8PR08MB6152:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB615285A96D7B1DD1A46EE0AC92709@AS8PR08MB6152.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:1265;OLM:1265;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 KIK5wEL2oOxkUnasKNKjLozjKQCF4W4L/prUGOBYGsivLQt6cXKq/YOuBN5kplZmwMDVZ6IZdvf/gZWCjgtpjIAac5/6FbiicRJmpciy7t505u925zfLK2uNi1f40L0s7tEEZopzrr54dh5Ilo30BNdur5hVtOv76GyB4RDc3qMf2eShy5grufwpEZD8f3CYnGQG1JxuYTQLkDivnsX1Bd/vhSTjj0KZr3xWLTMr3Wz+DvYWdGKRTCSVTa8dUNILPaGQra6daDj5pJ9p8wH3bNGQaxuKVQa/yZ674QGXA76MNlV43QqfOD5CB+t7hLYkHthi4oIIwlfMT4NvJcs5f1hBVgbLGeCc81x9xQnMxjhGFrrV/wb+omc9h9xAbpQKePiWhQpS7dTDOjf446iAqLlUbLa3asqztQ5JSBxTRttIjY6JA5PNcAfBStSRYoRYCiY44UQwSgSMT30bErVcnkm0+Oob1ViZesTs1ZxYXKPgIs3ztBoGxcUZKCt+p5MlDBZ2vrKKUKXASUJupIU2iJLsSC9ZzBowYBxXAg8R67FDTmGLvVfAZ4k0fknNVbTW7kn72JoXtikA3HKKch2/524JykjT+92TrEQZJkVYh07I3TwInoEpaEcT+ZJw1JsY5Dioi/b78G1UiVywm5pwElSl9Yh/TV8QkKJ0sVjcEYhSOcEekIg6B1BdJA+vQ4BIMBv6kGcNtSec17rDo16GcA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3056.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(33656002)(86362001)(76116006)(5660300002)(66446008)(6506007)(54906003)(53546011)(4326008)(508600001)(9686003)(66556008)(71200400001)(64756008)(38070700005)(66476007)(55016003)(52536014)(26005)(2906002)(8676002)(8936002)(122000001)(7696005)(38100700002)(83380400001)(316002)(110136005)(186003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3167
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a30b5501-7bac-4e22-5489-08d9bad99724
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0ZI1aRqCBtiPc9yvok6oAE8dcI86+muC3nimFt/e56ox5hjVv3xduU/Fnn9pOCEWKLHRTtnsYN8Z+WZXyCDg8tOy3XoMxFoHUcTqmleOmLr463chpRgLe3pq8aDHpPkewogqtHfLfZzMA3aHEMU4XmCeAmsluraahwbU5A7c3T3f5sOo/XDHsEqUfVXYIMTQNPMJxXxOr1AmHXXAssDuj23ZwX39R71ZvwPU5xn+wUd5W5XccFDwNJxC+qiuOBUDMofiZkUmb1xt+3NpwerAZ0r7BiFPkWW5a3leOK7k22tUP2v21ctEc9bLN9WfCtZYf2MXT38nS9+TB2qxU3MBKuIzPTkTJquwe9Pu1dAwWqmNqOQLDaD2UOHgXaFXanpf7QGTmOKt3YbOeMlTFac24OuK0/pg0atf6hdBEQzzawuNo7oW9mpIEosx1MsZE2hgnhyIvIlC7lF/3ZwVM4iUo4DCFT62SYqTbTSvdoRYIalAjQvexd7GIfr2Q3dk2RobAEx0aSSm0AaMA7AZaNJ42KC2OPpVFiVnE+MfxBsXRKuneWLA7TJdAYK67rcB8ZpryMfgN76DbOgoWCl2imk9cT13Czvl4OzpPsfKPbfUPs8fvMX9Q3nTJpLwgU6nRZToccmQPn5kUw0nO5aSLe0dzxgGpe7Mh09REynmOgVxBE+QB4i7tIwFmq2wYtSjumNgWUYChDSVnq1nyQfYBEi44u8YP1WfJX2Qch3SESmHEpcm8Qhr5gkL4bmxqLadxX0hUENnZgAMgUisv4DL/NLlhQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(186003)(6506007)(53546011)(36860700001)(336012)(107886003)(81166007)(7696005)(26005)(86362001)(83380400001)(110136005)(54906003)(70586007)(356005)(5660300002)(40460700001)(8676002)(2906002)(52536014)(508600001)(316002)(70206006)(9686003)(47076005)(33656002)(8936002)(55016003)(4326008)(82310400004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 06:03:24.2262
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4295dcfd-944b-45e0-4455-08d9bad99c4a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6152

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWGVuLWRldmVsIDx4ZW4t
ZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+IE9sZWtz
YW5kciBUeXNoY2hlbmtvDQo+IFNlbnQ6IDIwMjHlubQxMuaciDnml6UgMTowMA0KPiBUbzogeGVu
LWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IENjOiBKdWxpZW4gR3JhbGwgPEp1bGllbi5H
cmFsbEBhcm0uY29tPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEFudGhvbnkNCj4gUEVSQVJEIDxh
bnRob255LnBlcmFyZEBjaXRyaXguY29tPjsgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29t
PjsNCj4gU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgSnVsaWVu
IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47DQo+IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJf
QmFiY2h1a0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNA
YXJtLmNvbT47IE9sZWtzYW5kciBUeXNoY2hlbmtvDQo+IDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl
cGFtLmNvbT4NCj4gU3ViamVjdDogW1BBVENIIFY2IDIvMl0gbGlieGw6IEludHJvZHVjZSBiYXNp
YyB2aXJ0aW8tbW1pbyBzdXBwb3J0IG9uIEFybQ0KPiANCj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq
dWxpZW4uZ3JhbGxAYXJtLmNvbT4NCj4gDQo+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBoZWxwZXJz
IHRvIGFsbG9jYXRlIFZpcnRpbyBNTUlPIHBhcmFtcw0KPiAoSVJRIGFuZCBtZW1vcnkgcmVnaW9u
KSBhbmQgY3JlYXRlIHNwZWNpZmljIGRldmljZSBub2RlIGluDQo+IHRoZSBHdWVzdCBkZXZpY2Ut
dHJlZSB3aXRoIGFsbG9jYXRlZCBwYXJhbXMuIEluIG9yZGVyIHRvIGRlYWwNCj4gd2l0aCBtdWx0
aXBsZSBWaXJ0aW8gZGV2aWNlcywgcmVzZXJ2ZSBjb3JyZXNwb25kaW5nIHJhbmdlcy4NCj4gRm9y
IG5vdywgd2UgcmVzZXJ2ZSAxTUIgZm9yIG1lbW9yeSByZWdpb25zIGFuZCAxMCBTUElzLg0KPiAN
Cj4gQXMgdGhlc2UgaGVscGVycyBzaG91bGQgYmUgdXNlZCBmb3IgZXZlcnkgVmlydGlvIGRldmlj
ZSBhdHRhY2hlZA0KPiB0byB0aGUgR3Vlc3QsIGNhbGwgdGhlbSBmb3IgVmlydGlvIGRpc2socyku
DQo+IA0KPiBQbGVhc2Ugbm90ZSwgd2l0aCBzdGF0aWNhbGx5IGFsbG9jYXRlZCBWaXJ0aW8gSVJR
cyB0aGVyZSBpcw0KPiBhIHJpc2sgb2YgYSBjbGFzaCB3aXRoIGEgcGh5c2ljYWwgSVJRcyBvZiBw
YXNzdGhyb3VnaCBkZXZpY2VzLg0KPiBGb3IgdGhlIGZpcnN0IHZlcnNpb24sIGl0J3MgZmluZSwg
YnV0IHdlIHNob3VsZCBjb25zaWRlciBhbGxvY2F0aW5nDQo+IHRoZSBWaXJ0aW8gSVJRcyBhdXRv
bWF0aWNhbGx5LiBUaGFua2Z1bGx5LCB3ZSBrbm93IGluIGFkdmFuY2Ugd2hpY2gNCj4gSVJRcyB3
aWxsIGJlIHVzZWQgZm9yIHBhc3N0aHJvdWdoIHRvIGJlIGFibGUgdG8gY2hvb3NlIG5vbi1jbGFz
aGVkDQo+IG9uZXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGp1bGllbi5n
cmFsbEBhcm0uY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xl
a3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IC0tLQ0KPiBQbGVhc2Ugbm90ZSwgdGhpcyBp
cyBhIHNwbGl0L2NsZWFudXAvaGFyZGVuaW5nIG9mIEp1bGllbidzIFBvQzoNCj4gIkFkZCBzdXBw
b3J0IGZvciBHdWVzdCBJTyBmb3J3YXJkaW5nIHRvIGEgZGV2aWNlIGVtdWxhdG9yIg0KPiANCj4g
Q2hhbmdlcyBSRkMgLT4gVjE6DQo+ICAgIC0gd2FzIHNxdWFzaGVkIHdpdGg6DQo+ICAgICAgIltS
RkMgUEFUQ0ggVjEgMDkvMTJdIGxpYnhsOiBIYW5kbGUgdmlydGlvLW1taW8gaXJxIGluIG1vcmUg
Y29ycmVjdCB3YXkiDQo+ICAgICAgIltSRkMgUEFUQ0ggVjEgMTEvMTJdIGxpYnhsOiBJbnNlcnQg
ImRtYS1jb2hlcmVudCIgcHJvcGVydHkgaW50byB2aXJ0aW8tDQo+IG1taW8gZGV2aWNlIG5vZGUi
DQo+ICAgICAgIltSRkMgUEFUQ0ggVjEgMTIvMTJdIGxpYnhsOiBGaXggZHVwbGljYXRlIG1lbW9y
eSBub2RlIGluIERUIg0KPiAgICAtIG1vdmUgVmlydElPIE1NSU8gI2RlZmluZS1zIHRvIHhlbi9p
bmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+IA0KPiBDaGFuZ2VzIFYxIC0+IFYyOg0KPiAgICAt
IHVwZGF0ZSB0aGUgYXV0aG9yIG9mIGEgcGF0Y2gNCj4gDQo+IENoYW5nZXMgVjIgLT4gVjM6DQo+
ICAgIC0gbm8gY2hhbmdlcw0KPiANCj4gQ2hhbmdlcyBWMyAtPiBWNDoNCj4gICAgLSBubyBjaGFu
Z2VzDQo+IA0KPiBDaGFuZ2VzIFY0IC0+IFY1Og0KPiAgICAtIHNwbGl0IHRoZSBjaGFuZ2VzLCBj
aGFuZ2UgdGhlIG9yZGVyIG9mIHRoZSBwYXRjaGVzDQo+ICAgIC0gZHJvcCBhbiBleHRyYSAidmly
dGlvIiBjb25maWd1cmF0aW9uIG9wdGlvbg0KPiAgICAtIHVwZGF0ZSBwYXRjaCBkZXNjcmlwdGlv
bg0KPiAgICAtIHVzZSBDT05UQUlORVJfT0YgaW5zdGVhZCBvZiBvd24gaW1wbGVtZW50YXRpb24N
Cj4gICAgLSByZXNlcnZlIHJhbmdlcyBmb3IgVmlydGlvIE1NSU8gcGFyYW1zIGFuZCBwdXQgdGhl
bQ0KPiAgICAgIGluIGNvcnJlY3QgbG9jYXRpb24NCj4gICAgLSBjcmVhdGUgaGVscGVycyB0byBh
bGxvY2F0ZSBWaXJ0aW8gTU1JTyBwYXJhbXMsIGFkZA0KPiAgICAgIGNvcnJlc3BvbmRpbmcgc2Fu
aXR5LdGBaGVja3MNCj4gICAgLSBhZGQgY29tbWVudCB3aHkgTU1JTyBzaXplIDB4MjAwIGlzIGNo
b3Nlbg0KPiAgICAtIHVwZGF0ZSBkZWJ1ZyBwcmludA0KPiAgICAtIGRyb3AgV2VpJ3MgVC1iDQo+
IA0KPiBDaGFuZ2VzIFY1IC0+IFY2Og0KPiAgICAtIHJlYmFzZSBvbiBjdXJyZW50IHN0YWdpbmcN
Cj4gLS0tDQo+ICB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5jICB8IDEzMQ0KPiArKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4gIHhlbi9pbmNsdWRlL3B1Ymxp
Yy9hcmNoLWFybS5oIHwgICA3ICsrKw0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMzYgaW5zZXJ0aW9u
cygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0
L2xpYnhsX2FybS5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9hcm0uYw0KPiBpbmRleCBlZWYx
ZGUwLi5kNDc1MjQ5IDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2FybS5j
DQo+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4gQEAgLTgsNiArOCw1NiBA
QA0KPiAgI2luY2x1ZGUgPGFzc2VydC5oPg0KPiAgI2luY2x1ZGUgPHhlbi9kZXZpY2VfdHJlZV9k
ZWZzLmg+DQo+IA0KPiArLyoNCj4gKyAqIFRoZXJlIGlzIG5vIGNsZWFyIHJlcXVpcmVtZW50cyBm
b3IgdGhlIHRvdGFsIHNpemUgb2YgVmlydGlvIE1NSU8gcmVnaW9uLg0KPiArICogVGhlIHNpemUg
b2YgY29udHJvbCByZWdpc3RlcnMgaXMgMHgxMDAgYW5kIGRldmljZS1zcGVjaWZpYyBjb25maWd1
cmF0aW9uDQo+ICsgKiByZWdpc3RlcnMgc3RhcnRzIGF0IHRoZSBvZmZzZXQgMHgxMDAsIGhvd2V2
ZXIgaXQncyBzaXplIGRlcGVuZHMgb24gdGhlDQo+IGRldmljZQ0KPiArICogYW5kIHRoZSBkcml2
ZXIuIFBpY2sgdGhlIGJpZ2dlc3Qga25vd24gc2l6ZSBhdCB0aGUgbW9tZW50IHRvIGNvdmVyIG1v
c3QNCj4gKyAqIG9mIHRoZSBkZXZpY2VzIChhbHNvIGNvbnNpZGVyIGFsbG93aW5nIHRoZSB1c2Vy
IHRvIGNvbmZpZ3VyZSB0aGUgc2l6ZSB2aWENCj4gKyAqIGNvbmZpZyBmaWxlIGZvciB0aGUgb25l
IG5vdCBjb25mb3JtaW5nIHdpdGggdGhlIHByb3Bvc2VkIHZhbHVlKS4NCj4gKyAqLw0KPiArI2Rl
ZmluZSBWSVJUSU9fTU1JT19ERVZfU0laRSAgIHhlbl9ta191bGxvbmcoMHgyMDApDQo+ICsNCj4g
K3N0YXRpYyB1aW50NjRfdCB2aXJ0aW9fbW1pb19iYXNlOw0KPiArc3RhdGljIHVpbnQzMl90IHZp
cnRpb19tbWlvX2lycTsNCj4gKw0KPiArc3RhdGljIHZvaWQgaW5pdF92aXJ0aW9fbW1pb19wYXJh
bXModm9pZCkNCj4gK3sNCj4gKyAgICB2aXJ0aW9fbW1pb19iYXNlID0gR1VFU1RfVklSVElPX01N
SU9fQkFTRTsNCj4gKyAgICB2aXJ0aW9fbW1pb19pcnEgPSBHVUVTVF9WSVJUSU9fTU1JT19TUElf
RklSU1Q7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyB1aW50NjRfdCBhbGxvY192aXJ0aW9fbW1pb19i
YXNlKGxpYnhsX19nYyAqZ2MpDQo+ICt7DQo+ICsgICAgdWludDY0X3QgYmFzZSA9IHZpcnRpb19t
bWlvX2Jhc2U7DQo+ICsNCj4gKyAgICAvKiBNYWtlIHN1cmUgd2UgaGF2ZSBlbm91Z2ggcmVzZXJ2
ZWQgcmVzb3VyY2VzICovDQo+ICsgICAgaWYgKCh2aXJ0aW9fbW1pb19iYXNlICsgVklSVElPX01N
SU9fREVWX1NJWkUgPg0KPiArICAgICAgICBHVUVTVF9WSVJUSU9fTU1JT19CQVNFICsgR1VFU1Rf
VklSVElPX01NSU9fU0laRSkpIHsNCj4gKyAgICAgICAgTE9HKEVSUk9SLCAiUmFuIG91dCBvZiBy
ZXNlcnZlZCByYW5nZSBmb3IgVmlydGlvIE1NSU8gQkFTRQ0KPiAweCUiUFJJeDY0IlxuIiwNCj4g
KyAgICAgICAgICAgIHZpcnRpb19tbWlvX2Jhc2UpOw0KPiArICAgICAgICByZXR1cm4gMDsNCj4g
KyAgICB9DQo+ICsgICAgdmlydGlvX21taW9fYmFzZSArPSBWSVJUSU9fTU1JT19ERVZfU0laRTsN
Cj4gKw0KPiArICAgIHJldHVybiBiYXNlOw0KPiArfQ0KPiArDQo+ICtzdGF0aWMgdWludDMyX3Qg
YWxsb2NfdmlydGlvX21taW9faXJxKGxpYnhsX19nYyAqZ2MpDQo+ICt7DQo+ICsgICAgdWludDMy
X3QgaXJxID0gdmlydGlvX21taW9faXJxOw0KPiArDQo+ICsgICAgLyogTWFrZSBzdXJlIHdlIGhh
dmUgZW5vdWdoIHJlc2VydmVkIHJlc291cmNlcyAqLw0KPiArICAgIGlmICh2aXJ0aW9fbW1pb19p
cnEgPiBHVUVTVF9WSVJUSU9fTU1JT19TUElfTEFTVCkgew0KPiArICAgICAgICBMT0coRVJST1Is
ICJSYW4gb3V0IG9mIHJlc2VydmVkIHJhbmdlIGZvciBWaXJ0aW8gTU1JTyBJUlEgJXVcbiIsDQo+
ICsgICAgICAgICAgICB2aXJ0aW9fbW1pb19pcnEpOw0KPiArICAgICAgICByZXR1cm4gMDsNCj4g
KyAgICB9DQo+ICsgICAgdmlydGlvX21taW9faXJxKys7DQo+ICsNCj4gKyAgICByZXR1cm4gaXJx
Ow0KPiArfQ0KPiArDQo+ICBzdGF0aWMgY29uc3QgY2hhciAqZ2ljdl90b19zdHJpbmcobGlieGxf
Z2ljX3ZlcnNpb24gZ2ljX3ZlcnNpb24pDQo+ICB7DQo+ICAgICAgc3dpdGNoIChnaWNfdmVyc2lv
bikgew0KPiBAQCAtMjYsOCArNzYsOCBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX3ByZXBhcmVf
Y29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICB7DQo+ICAgICAgdWludDMyX3QgbnJfc3BpcyA9IDA7
DQo+ICAgICAgdW5zaWduZWQgaW50IGk7DQo+IC0gICAgdWludDMyX3QgdnVhcnRfaXJxOw0KPiAt
ICAgIGJvb2wgdnVhcnRfZW5hYmxlZCA9IGZhbHNlOw0KPiArICAgIHVpbnQzMl90IHZ1YXJ0X2ly
cSwgdmlydGlvX2lycSA9IDA7DQo+ICsgICAgYm9vbCB2dWFydF9lbmFibGVkID0gZmFsc2UsIHZp
cnRpb19lbmFibGVkID0gZmFsc2U7DQo+IA0KPiAgICAgIC8qDQo+ICAgICAgICogSWYgcGwwMTEg
dnVhcnQgaXMgZW5hYmxlZCB0aGVuIGluY3JlbWVudCB0aGUgbnJfc3BpcyB0byBhbGxvdyBhbGxv
Y2F0aW9uDQo+IEBAIC0zOSw2ICs4OSwzNSBAQCBpbnQgbGlieGxfX2FyY2hfZG9tYWluX3ByZXBh
cmVfY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICAgICAgICAgIHZ1YXJ0X2VuYWJsZWQgPSB0cnVl
Ow0KPiAgICAgIH0NCj4gDQo+ICsgICAgLyoNCj4gKyAgICAgKiBWaXJ0aW8gTU1JTyBwYXJhbXMg
YXJlIG5vbi11bmlxdWUgYWNyb3NzIHRoZSB3aG9sZSBzeXN0ZW0gYW5kDQo+IG11c3QgYmUNCj4g
KyAgICAgKiBpbml0aWFsaXplZCBmb3IgZXZlcnkgbmV3IGd1ZXN0Lg0KPiArICAgICAqLw0KPiAr
ICAgIGluaXRfdmlydGlvX21taW9fcGFyYW1zKCk7DQo+ICsgICAgZm9yIChpID0gMDsgaSA8IGRf
Y29uZmlnLT5udW1fZGlza3M7IGkrKykgew0KPiArICAgICAgICBsaWJ4bF9kZXZpY2VfZGlzayAq
ZGlzayA9ICZkX2NvbmZpZy0+ZGlza3NbaV07DQo+ICsNCj4gKyAgICAgICAgaWYgKGRpc2stPnZp
cnRpbykgew0KPiArICAgICAgICAgICAgZGlzay0+YmFzZSA9IGFsbG9jX3ZpcnRpb19tbWlvX2Jh
c2UoZ2MpOw0KPiArICAgICAgICAgICAgaWYgKCFkaXNrLT5iYXNlKQ0KPiArICAgICAgICAgICAg
ICAgIHJldHVybiBFUlJPUl9GQUlMOw0KPiArDQo+ICsgICAgICAgICAgICBkaXNrLT5pcnEgPSBh
bGxvY192aXJ0aW9fbW1pb19pcnEoZ2MpOw0KPiArICAgICAgICAgICAgaWYgKCFkaXNrLT5pcnEp
DQo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7DQo+ICsNCj4gKyAgICAgICAg
ICAgIGlmICh2aXJ0aW9faXJxIDwgZGlzay0+aXJxKQ0KPiArICAgICAgICAgICAgICAgIHZpcnRp
b19pcnEgPSBkaXNrLT5pcnE7DQo+ICsgICAgICAgICAgICB2aXJ0aW9fZW5hYmxlZCA9IHRydWU7
DQo+ICsNCj4gKyAgICAgICAgICAgIExPRyhERUJVRywgIkFsbG9jYXRlIFZpcnRpbyBNTUlPIHBh
cmFtcyBmb3IgVmRldiAlczogSVJRICV1DQo+IEJBU0UgMHglIlBSSXg2NCwNCj4gKyAgICAgICAg
ICAgICAgICBkaXNrLT52ZGV2LCBkaXNrLT5pcnEsIGRpc2stPmJhc2UpOw0KPiArICAgICAgICB9
DQo+ICsgICAgfQ0KPiArDQo+ICsgICAgaWYgKHZpcnRpb19lbmFibGVkKQ0KPiArICAgICAgICBu
cl9zcGlzICs9ICh2aXJ0aW9faXJxIC0gMzIpICsgMTsNCj4gKw0KPiAgICAgIGZvciAoaSA9IDA7
IGkgPCBkX2NvbmZpZy0+Yl9pbmZvLm51bV9pcnFzOyBpKyspIHsNCj4gICAgICAgICAgdWludDMy
X3QgaXJxID0gZF9jb25maWctPmJfaW5mby5pcnFzW2ldOw0KPiAgICAgICAgICB1aW50MzJfdCBz
cGk7DQo+IEBAIC01OCw2ICsxMzcsMTMgQEAgaW50IGxpYnhsX19hcmNoX2RvbWFpbl9wcmVwYXJl
X2NvbmZpZyhsaWJ4bF9fZ2MgKmdjLA0KPiAgICAgICAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7
DQo+ICAgICAgICAgIH0NCj4gDQo+ICsgICAgICAgIC8qIFRoZSBzYW1lIGNoZWNrIGFzIGZvciB2
cGwwMTEgKi8NCj4gKyAgICAgICAgaWYgKHZpcnRpb19lbmFibGVkICYmDQo+ICsgICAgICAgICAg
IChpcnEgPj0gR1VFU1RfVklSVElPX01NSU9fU1BJX0ZJUlNUICYmIGlycSA8PSB2aXJ0aW9faXJx
KSkgew0KPiArICAgICAgICAgICAgTE9HKEVSUk9SLCAiUGh5c2ljYWwgSVJRICV1IGNvbmZsaWN0
aW5nIHdpdGggVmlydGlvIE1NSU8gSVJRDQo+IHJhbmdlXG4iLCBpcnEpOw0KPiArICAgICAgICAg
ICAgcmV0dXJuIEVSUk9SX0ZBSUw7DQo+ICsgICAgICAgIH0NCj4gKw0KPiAgICAgICAgICBpZiAo
aXJxIDwgMzIpDQo+ICAgICAgICAgICAgICBjb250aW51ZTsNCj4gDQo+IEBAIC03ODcsNiArODcz
LDM5IEBAIHN0YXRpYyBpbnQgbWFrZV92cGNpX25vZGUobGlieGxfX2djICpnYywgdm9pZCAqZmR0
LA0KPiAgICAgIHJldHVybiAwOw0KPiAgfQ0KPiANCj4gKw0KPiArc3RhdGljIGludCBtYWtlX3Zp
cnRpb19tbWlvX25vZGUobGlieGxfX2djICpnYywgdm9pZCAqZmR0LA0KPiArICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgYmFzZSwgdWludDMyX3QgaXJxKQ0KPiArew0K
PiArICAgIGludCByZXM7DQo+ICsgICAgZ2ljX2ludGVycnVwdCBpbnRyOw0KPiArICAgIC8qIFBs
YWNlaG9sZGVyIGZvciB2aXJ0aW9AICsgYSA2NC1iaXQgbnVtYmVyICsgXDAgKi8NCj4gKyAgICBj
aGFyIGJ1ZlsyNF07DQo+ICsNCj4gKyAgICBzbnByaW50ZihidWYsIHNpemVvZihidWYpLCAidmly
dGlvQCUiUFJJeDY0LCBiYXNlKTsNCj4gKyAgICByZXMgPSBmZHRfYmVnaW5fbm9kZShmZHQsIGJ1
Zik7DQo+ICsgICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4gKw0KPiArICAgIHJlcyA9IGZkdF9w
cm9wZXJ0eV9jb21wYXQoZ2MsIGZkdCwgMSwgInZpcnRpbyxtbWlvIik7DQo+ICsgICAgaWYgKHJl
cykgcmV0dXJuIHJlczsNCj4gKw0KPiArICAgIHJlcyA9IGZkdF9wcm9wZXJ0eV9yZWdzKGdjLCBm
ZHQsIEdVRVNUX1JPT1RfQUREUkVTU19DRUxMUywNCj4gR1VFU1RfUk9PVF9TSVpFX0NFTExTLA0K
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEsIGJhc2UsIFZJUlRJT19NTUlPX0RFVl9T
SVpFKTsNCj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVzOw0KPiArDQo+ICsgICAgc2V0X2ludGVy
cnVwdChpbnRyLCBpcnEsIDB4ZiwgRFRfSVJRX1RZUEVfRURHRV9SSVNJTkcpOw0KPiArICAgIHJl
cyA9IGZkdF9wcm9wZXJ0eV9pbnRlcnJ1cHRzKGdjLCBmZHQsICZpbnRyLCAxKTsNCj4gKyAgICBp
ZiAocmVzKSByZXR1cm4gcmVzOw0KPiArDQo+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5KGZkdCwg
ImRtYS1jb2hlcmVudCIsIE5VTEwsIDApOw0KPiArICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+
ICsNCj4gKyAgICByZXMgPSBmZHRfZW5kX25vZGUoZmR0KTsNCj4gKyAgICBpZiAocmVzKSByZXR1
cm4gcmVzOw0KPiArDQo+ICsgICAgcmV0dXJuIDA7DQo+ICt9DQo+ICsNCj4gIHN0YXRpYyBjb25z
dCBzdHJ1Y3QgYXJjaF9pbmZvICpnZXRfYXJjaF9pbmZvKGxpYnhsX19nYyAqZ2MsDQo+ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgeGNf
ZG9tX2ltYWdlICpkb20pDQo+ICB7DQo+IEBAIC05ODgsNiArMTEwNyw3IEBAIHN0YXRpYyBpbnQg
bGlieGxfX3ByZXBhcmVfZHRiKGxpYnhsX19nYyAqZ2MsDQo+IGxpYnhsX2RvbWFpbl9jb25maWcg
KmRfY29uZmlnLA0KPiAgICAgIHNpemVfdCBmZHRfc2l6ZSA9IDA7DQo+ICAgICAgaW50IHBmZHRf
c2l6ZSA9IDA7DQo+ICAgICAgbGlieGxfZG9tYWluX2J1aWxkX2luZm8gKmNvbnN0IGluZm8gPSAm
ZF9jb25maWctPmJfaW5mbzsNCj4gKyAgICB1bnNpZ25lZCBpbnQgaTsNCj4gDQo+ICAgICAgY29u
c3QgbGlieGxfdmVyc2lvbl9pbmZvICp2ZXJzOw0KPiAgICAgIGNvbnN0IHN0cnVjdCBhcmNoX2lu
Zm8gKmFpbmZvOw0KPiBAQCAtMTA5NCw2ICsxMjE0LDEzIEBAIG5leHRfcmVzaXplOg0KPiAgICAg
ICAgICBpZiAoZF9jb25maWctPm51bV9wY2lkZXZzKQ0KPiAgICAgICAgICAgICAgRkRUKCBtYWtl
X3ZwY2lfbm9kZShnYywgZmR0LCBhaW5mbywgZG9tKSApOw0KPiANCj4gKyAgICAgICAgZm9yIChp
ID0gMDsgaSA8IGRfY29uZmlnLT5udW1fZGlza3M7IGkrKykgew0KPiArICAgICAgICAgICAgbGli
eGxfZGV2aWNlX2Rpc2sgKmRpc2sgPSAmZF9jb25maWctPmRpc2tzW2ldOw0KPiArDQo+ICsgICAg
ICAgICAgICBpZiAoZGlzay0+dmlydGlvKQ0KPiArICAgICAgICAgICAgICAgIEZEVCggbWFrZV92
aXJ0aW9fbW1pb19ub2RlKGdjLCBmZHQsIGRpc2stPmJhc2UsIGRpc2stPmlycSkgKTsNCj4gKyAg
ICAgICAgfQ0KPiArDQo+ICAgICAgICAgIGlmIChwZmR0KQ0KPiAgICAgICAgICAgICAgRkRUKCBj
b3B5X3BhcnRpYWxfZmR0KGdjLCBmZHQsIHBmZHQpICk7DQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVu
L2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0u
aA0KPiBpbmRleCA5NGIzMTUxLi42ZGM1NWRmIDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS9w
dWJsaWMvYXJjaC1hcm0uaA0KPiArKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaA0K
PiBAQCAtMzk4LDYgKzM5OCwxMCBAQCB0eXBlZGVmIHVpbnQ2NF90IHhlbl9jYWxsYmFja190Ow0K
PiANCj4gIC8qIFBoeXNpY2FsIEFkZHJlc3MgU3BhY2UgKi8NCj4gDQo+ICsvKiBWaXJ0aW8gTU1J
TyBtYXBwaW5ncyAqLw0KPiArI2RlZmluZSBHVUVTVF9WSVJUSU9fTU1JT19CQVNFICAgeGVuX21r
X3VsbG9uZygweDAyMDAwMDAwKQ0KPiArI2RlZmluZSBHVUVTVF9WSVJUSU9fTU1JT19TSVpFICAg
eGVuX21rX3VsbG9uZygweDAwMTAwMDAwKQ0KPiArDQo+ICAvKg0KPiAgICogdkdJQyBtYXBwaW5n
czogT25seSBvbmUgc2V0IG9mIG1hcHBpbmcgaXMgdXNlZCBieSB0aGUgZ3Vlc3QuDQo+ICAgKiBU
aGVyZWZvcmUgdGhleSBjYW4gb3ZlcmxhcC4NCj4gQEAgLTQ4NCw2ICs0ODgsOSBAQCB0eXBlZGVm
IHVpbnQ2NF90IHhlbl9jYWxsYmFja190Ow0KPiANCj4gICNkZWZpbmUgR1VFU1RfVlBMMDExX1NQ
SSAgICAgICAgMzINCj4gDQo+ICsjZGVmaW5lIEdVRVNUX1ZJUlRJT19NTUlPX1NQSV9GSVJTVCAg
IDMzDQo+ICsjZGVmaW5lIEdVRVNUX1ZJUlRJT19NTUlPX1NQSV9MQVNUICAgIDQzDQo+ICsNCj4g
IC8qIFBTQ0kgZnVuY3Rpb25zICovDQo+ICAjZGVmaW5lIFBTQ0lfY3B1X3N1c3BlbmQgMA0KPiAg
I2RlZmluZSBQU0NJX2NwdV9vZmYgICAgIDENCj4gLS0NCj4gMi43LjQNCj4gDQoNCltKaWFtZWkg
WGllXSANCkl0IHdvcmtzIGZpbmUgYXMgYmVmb3JlLg0KDQpUZXN0ZWQtYnk6IEppYW1laSBYaWUg
PEppYW1laS54aWVAYXJtLmNvbT4NCg0KQmVzdCB3aXNoZXMNCkppYW1laSBYaWUNCg0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 06:21:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 06:21:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242675.419691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvCoB-00038O-Ni; Thu, 09 Dec 2021 06:21:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242675.419691; Thu, 09 Dec 2021 06:21:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvCoB-00038H-Kp; Thu, 09 Dec 2021 06:21:35 +0000
Received: by outflank-mailman (input) for mailman id 242675;
 Thu, 09 Dec 2021 06:21:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvCoA-000386-2e; Thu, 09 Dec 2021 06:21:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvCo9-0002I0-KF; Thu, 09 Dec 2021 06:21:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvCo9-0000st-9r; Thu, 09 Dec 2021 06:21:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvCo9-0005uY-7i; Thu, 09 Dec 2021 06:21:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GTQ6mi4YltHrAZF2/IeHYkIWoPFSBidNLMRF8A8IwEQ=; b=ZCe/tIghvTrH5OLxe1S7iAryNv
	DgnKpkZ5LVclS6Yy41Q7rWvEvkgWfaSzRzCnsk8mY9g44azKVPPShUeVIxmgARleRB8LElczZBwRb
	JoQyGN9RTN5K0+6baGR5rsJPoVPraUDjEuM77WOAflL1spgziPfaE/7GneaESWi3K7OM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167237-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167237: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7b2831000894f3091cac633e61d9bcf3661cc44b
X-Osstest-Versions-That:
    ovmf=85a678bf76c5aac2e40255f48ea3209ff95f150a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 06:21:33 +0000

flight 167237 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167237/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7b2831000894f3091cac633e61d9bcf3661cc44b
baseline version:
 ovmf                 85a678bf76c5aac2e40255f48ea3209ff95f150a

Last test of basis   167231  2021-12-08 08:45:35 Z    0 days
Testing same since   167237  2021-12-09 01:10:49 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jiang, Xiaolu <Xiaolu.Jiang@intel.com>
  Xiaolu Jiang <xiaolu.jiang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   85a678bf76..7b28310008  7b2831000894f3091cac633e61d9bcf3661cc44b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 06:35:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 06:35:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242682.419706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvD1R-00057e-07; Thu, 09 Dec 2021 06:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242682.419706; Thu, 09 Dec 2021 06:35:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvD1Q-00057X-S2; Thu, 09 Dec 2021 06:35:16 +0000
Received: by outflank-mailman (input) for mailman id 242682;
 Thu, 09 Dec 2021 06:35:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qm81=Q2=arm.com=Henry.Wang@srs-se1.protection.inumbo.net>)
 id 1mvD1P-00057R-Cq
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 06:35:15 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2060a.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::60a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 281644a9-58ba-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 07:35:13 +0100 (CET)
Received: from DB6PR0501CA0025.eurprd05.prod.outlook.com (2603:10a6:4:67::11)
 by GV1PR08MB7329.eurprd08.prod.outlook.com (2603:10a6:150:1c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19; Thu, 9 Dec
 2021 06:35:06 +0000
Received: from DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:67:cafe::c7) by DB6PR0501CA0025.outlook.office365.com
 (2603:10a6:4:67::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Thu, 9 Dec 2021 06:35:06 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT025.mail.protection.outlook.com (10.152.20.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 06:35:05 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Thu, 09 Dec 2021 06:35:05 +0000
Received: from eabc2ce09baa.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 476834EB-92B0-49D0-91FF-71751F5B9B34.1; 
 Thu, 09 Dec 2021 06:34:59 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eabc2ce09baa.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 06:34:59 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8)
 by PAXPR08MB6943.eurprd08.prod.outlook.com (2603:10a6:102:135::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Thu, 9 Dec
 2021 06:34:57 +0000
Received: from PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::99cd:3d3b:4670:7413]) by PA4PR08MB6253.eurprd08.prod.outlook.com
 ([fe80::99cd:3d3b:4670:7413%5]) with mapi id 15.20.4778.013; Thu, 9 Dec 2021
 06:34:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 281644a9-58ba-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fMXSeHiFxkBI/tUs0uRWbNjp7s1B6jHptdm1d0wrwXo=;
 b=oYsYOxXA8hq5zUSXrLqQF9PQ9I+CRBLiM+f79XGvU+t7aQPQVQowfmkj33Ddf6R6XRxGJnvAjL2w3o+KJLlTYDDO3qJemR/oui7GcTQTdtGh/G3Eh70ouz4dVXmDRyRvfAOWY7Wez94AlWS4qtnWgslBfThPISLfypiu5YU7QwU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UENoAlvbW7Rvw7B2RQEDCXXSOrwPptYhZpA58lcANNJ9iMZhFPIgP0m5F5duqSOL8RqnS2qAMywZ4VOLYqebhFKMf4i5tzbPAaCmKfm0GtN1jdBIRtpOG26sjzG3oF7maeqzfT1j68w7NJSqxNmOiLEezMFbibqxUUns91U1X32SFXdDpDNjjZU31mI+toACicvkib7SP5drFANrf3B7n7dM+W6pm5Z0sDVmciKqhud4uXJSyEWyak5fS3ZP8fAUEe/TYjjPg0BMFVlrTMDSgXuv89oFDghq2LPCRvQ2Ka+kuhsTLEEiDNbJrduGOaSqNntKfUiZWDpS6toV+KBoQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fMXSeHiFxkBI/tUs0uRWbNjp7s1B6jHptdm1d0wrwXo=;
 b=TOznYA0ABUcIhjYH//UMDsXOBUoc0TlO3IZhcr3LkjmIcItJNS8zm0u1hAr5CdihFNJPdmEsgv3TnWbaDtL4iqOLjeDO6zj9khB9xMAbXXptLVtmwlcADysXMxr8rw29pLy3eqYRYoWIp+pRluLgeQSGBctzsiWs8LnsnE3Zi5+LcyEImcKV/kIiP1evoedb8EYeS/HUwJ4U65v1FSefxkAZ4ThOlnVj776Zgmz2+hsniDU235uYpypYYZAzkcmaaTqC8DHB0DR0Aq3JC6jWX+DAoCL8OgxQC/wIVE25GfOn1AXlUbYXtS8ZxNSYEhW1J8IGtO1qc2BaUlEOxCqThQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fMXSeHiFxkBI/tUs0uRWbNjp7s1B6jHptdm1d0wrwXo=;
 b=oYsYOxXA8hq5zUSXrLqQF9PQ9I+CRBLiM+f79XGvU+t7aQPQVQowfmkj33Ddf6R6XRxGJnvAjL2w3o+KJLlTYDDO3qJemR/oui7GcTQTdtGh/G3Eh70ouz4dVXmDRyRvfAOWY7Wez94AlWS4qtnWgslBfThPISLfypiu5YU7QwU=
From: Henry Wang <Henry.Wang@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Julien Grall <Julien.Grall@arm.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Stefano
 Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>
Subject: RE: [PATCH V6 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Topic: [PATCH V6 2/2] libxl: Introduce basic virtio-mmio support on Arm
Thread-Index: AQHX7FUn0czI/NY3iEeAQwXmMstuq6wptMyg
Date: Thu, 9 Dec 2021 06:34:56 +0000
Message-ID:
 <PA4PR08MB62534DEB59CBA2105EF9448392709@PA4PR08MB6253.eurprd08.prod.outlook.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-3-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638982784-14390-3-git-send-email-olekstysh@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: EE8BE45EF1990746A95019775AE84D86.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 3e11f65f-7fd7-43bf-a3ee-08d9bade09a5
x-ms-traffictypediagnostic:
	PAXPR08MB6943:EE_|DB5EUR03FT025:EE_|GV1PR08MB7329:EE_
X-Microsoft-Antispam-PRVS:
	<GV1PR08MB7329E2C6C8CA953DF00DB69292709@GV1PR08MB7329.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:454;OLM:454;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 vGUIqyZhWpoXepPKyZwONbnRX6/plof1J28gX/RJRSs2NpJiamaa97q54CIXqtrlwcOJBhOLXXE1eyK0ej7TuNjnVmyXHD9WAF9TJrEeDQQxNhhoQ+Rdti412SUR9uXdq9PJ7IDF2k7cmNo+xAZLNi30CPRiN+6y4RRkXiVPNgtltqT5jfeRThJC6Q5dS9mVBV17nZYk1dffxj3XTRu1OllxtUbEVaScHqXy7w1LdNh4Chd019jXg4LACrecEwNaMXlf/WgkNxYGUN9gdCMYisRBKC+zPsoztCnVTLXwlz9vk6BatGodGSgy+jCK5y/ViYf6IfZ9uDBzKBFlgD2EmJCr9zwVc1nqZOwLpqLk15SvXPxBEDyuGqmLEj92QjaDzGs770vU8ReVZRSQIWRQhiq9YfcKrQ9P5RjZNAybtO1MvELsubfV7b5B3y5AKczi2sCgCIo0mPD7H5SqKYoxMXO5TTeQc1dbcx5cyO80Fi5ItDoPMSOoSddElyp0BzopXpbrhPtt1TaDGE1jn7NHUQyqAJcfaJ2yPybPr58fQ6zErGlNMGoQs6eTAFEc9CoGiCAXDOKtbg8HWl83xFSP2ZkjHAYY8Gdp+NEgz+JySVV2nEMXzQibBvXvlq15AZ+dgauBB8wkZ1OXsDn4KeAoDCpVr85eOP1wJWFGlrZkAPhxHqSJNApEoXMUa+fw0BtTtvwsbryPktcWFCt5NIsUHA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(33656002)(38100700002)(9686003)(508600001)(2906002)(83380400001)(4326008)(38070700005)(122000001)(86362001)(8676002)(66556008)(7696005)(110136005)(76116006)(8936002)(6506007)(53546011)(26005)(316002)(52536014)(5660300002)(54906003)(71200400001)(66946007)(66476007)(64756008)(66446008)(55016003);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6943
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	3d091c94-9441-4e6a-701b-08d9bade048a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AyFwRjwUphOrcjFsixwUTaaqDGpkIqt/Xl9jepfR25LrRXKQ4XgY1MjO1+3UqCjzycWXn8zymZoPcFWbFDFuEdApjpH4MVmXA0j1h+5OJ5ufGL57zYI40vHNctK189RRq1MEulPDlKVSk9E1M56FB2RY3ZTUmPpctU0khVRUb9dWJepE1dcWPNLIT1fM5f08cMcWticcZlEOpW7YhLsmq3SSmJQtf4e6R2RwBuCGKTVsygK3aN1ueTVaQ2dkS02/kDg/CJEjsLNDlTIevCVBvzuuvK6va4JvNU2A5gSsdrG0mR3jFXMndee0UazILJzGThCNywAR11MFr6r1/9Nf33bqKnZu/kA923HtcYAcv4fnFBayLqvS/yWVu6+jWbY80qUGIqj4rMD9YOaR2J2w3cG22BuKxZMX7sIbJw4KebYuf7BF550rJdvvMoD0O3OMPjEEe0akKR7/LIPAiYguQ0wgFCxAEGA/tCX1EQSmIYDGw/5orngHVlxvJy/1H+8q91uD4Sd/JUbSNg0R5iDAK5T6n9G3P0uJa6DPZysxdEkuw68+pudkINhYsctVvA+z9NHQ6p1arEzEJo0g9+CaMPN5x8LQUSaBqZxRJTBB+fmRzUOu+D947l98NwhWxGBXzmwhlzmVLKI33cZzbKNVFKtOVR5Ad8DtLflRw7KLSKtl5+PS08dwc9RY1Y0XkeobfqwZJjW4gqEjin3nSoP03OevmgUzETfJQHuBzKMmbyK2KhbunMSESHxylnjqAjyASAMSNWOJBwAvDlHCVcCDNA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(356005)(40460700001)(186003)(82310400004)(36860700001)(107886003)(316002)(9686003)(52536014)(70206006)(81166007)(70586007)(86362001)(336012)(83380400001)(508600001)(26005)(53546011)(6506007)(55016003)(8936002)(2906002)(47076005)(4326008)(5660300002)(8676002)(54906003)(33656002)(110136005)(7696005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 06:35:05.6902
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e11f65f-7fd7-43bf-a3ee-08d9bade09a5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7329

SGkgT2xla3NhbmRyLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhl
bi1kZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFs
ZiBPZg0KPiBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiBTZW50OiBUaHVyc2RheSwgRGVjZW1iZXIg
OSwgMjAyMSAxOjAwIEFNDQo+IFRvOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4g
Q2M6IEp1bGllbiBHcmFsbCA8SnVsaWVuLkdyYWxsQGFybS5jb20+OyBXZWkgTGl1IDx3bEB4ZW4u
b3JnPjsgQW50aG9ueQ0KPiBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+OyBKdWVy
Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ow0KPiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi
ZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsNCj4gVm9s
b2R5bXlyIEJhYmNodWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgQmVydHJhbmQgTWFy
cXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgT2xla3NhbmRyIFR5c2hjaGVua28N
Cj4gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBbUEFUQ0ggVjYg
Mi8yXSBsaWJ4bDogSW50cm9kdWNlIGJhc2ljIHZpcnRpby1tbWlvIHN1cHBvcnQgb24gQXJtDQo+
IA0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0uY29tPg0KPiANCj4gVGhp
cyBwYXRjaCBpbnRyb2R1Y2VzIGhlbHBlcnMgdG8gYWxsb2NhdGUgVmlydGlvIE1NSU8gcGFyYW1z
DQo+IChJUlEgYW5kIG1lbW9yeSByZWdpb24pIGFuZCBjcmVhdGUgc3BlY2lmaWMgZGV2aWNlIG5v
ZGUgaW4NCj4gdGhlIEd1ZXN0IGRldmljZS10cmVlIHdpdGggYWxsb2NhdGVkIHBhcmFtcy4gSW4g
b3JkZXIgdG8gZGVhbA0KPiB3aXRoIG11bHRpcGxlIFZpcnRpbyBkZXZpY2VzLCByZXNlcnZlIGNv
cnJlc3BvbmRpbmcgcmFuZ2VzLg0KPiBGb3Igbm93LCB3ZSByZXNlcnZlIDFNQiBmb3IgbWVtb3J5
IHJlZ2lvbnMgYW5kIDEwIFNQSXMuDQo+IA0KPiBBcyB0aGVzZSBoZWxwZXJzIHNob3VsZCBiZSB1
c2VkIGZvciBldmVyeSBWaXJ0aW8gZGV2aWNlIGF0dGFjaGVkDQo+IHRvIHRoZSBHdWVzdCwgY2Fs
bCB0aGVtIGZvciBWaXJ0aW8gZGlzayhzKS4NCj4gDQo+IFBsZWFzZSBub3RlLCB3aXRoIHN0YXRp
Y2FsbHkgYWxsb2NhdGVkIFZpcnRpbyBJUlFzIHRoZXJlIGlzDQo+IGEgcmlzayBvZiBhIGNsYXNo
IHdpdGggYSBwaHlzaWNhbCBJUlFzIG9mIHBhc3N0aHJvdWdoIGRldmljZXMuDQo+IEZvciB0aGUg
Zmlyc3QgdmVyc2lvbiwgaXQncyBmaW5lLCBidXQgd2Ugc2hvdWxkIGNvbnNpZGVyIGFsbG9jYXRp
bmcNCj4gdGhlIFZpcnRpbyBJUlFzIGF1dG9tYXRpY2FsbHkuIFRoYW5rZnVsbHksIHdlIGtub3cg
aW4gYWR2YW5jZSB3aGljaA0KPiBJUlFzIHdpbGwgYmUgdXNlZCBmb3IgcGFzc3Rocm91Z2ggdG8g
YmUgYWJsZSB0byBjaG9vc2Ugbm9uLWNsYXNoZWQNCj4gb25lcy4NCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+DQo+IFNpZ25lZC1vZmYtYnk6
IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4g
LS0tDQo+IFBsZWFzZSBub3RlLCB0aGlzIGlzIGEgc3BsaXQvY2xlYW51cC9oYXJkZW5pbmcgb2Yg
SnVsaWVuJ3MgUG9DOg0KPiAiQWRkIHN1cHBvcnQgZm9yIEd1ZXN0IElPIGZvcndhcmRpbmcgdG8g
YSBkZXZpY2UgZW11bGF0b3IiDQo+IA0KPiBDaGFuZ2VzIFJGQyAtPiBWMToNCj4gICAgLSB3YXMg
c3F1YXNoZWQgd2l0aDoNCj4gICAgICAiW1JGQyBQQVRDSCBWMSAwOS8xMl0gbGlieGw6IEhhbmRs
ZSB2aXJ0aW8tbW1pbyBpcnEgaW4gbW9yZSBjb3JyZWN0IHdheSINCj4gICAgICAiW1JGQyBQQVRD
SCBWMSAxMS8xMl0gbGlieGw6IEluc2VydCAiZG1hLWNvaGVyZW50IiBwcm9wZXJ0eSBpbnRvIHZp
cnRpby0NCj4gbW1pbyBkZXZpY2Ugbm9kZSINCj4gICAgICAiW1JGQyBQQVRDSCBWMSAxMi8xMl0g
bGlieGw6IEZpeCBkdXBsaWNhdGUgbWVtb3J5IG5vZGUgaW4gRFQiDQo+ICAgIC0gbW92ZSBWaXJ0
SU8gTU1JTyAjZGVmaW5lLXMgdG8geGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmgNCj4gDQo+
IENoYW5nZXMgVjEgLT4gVjI6DQo+ICAgIC0gdXBkYXRlIHRoZSBhdXRob3Igb2YgYSBwYXRjaA0K
PiANCj4gQ2hhbmdlcyBWMiAtPiBWMzoNCj4gICAgLSBubyBjaGFuZ2VzDQo+IA0KPiBDaGFuZ2Vz
IFYzIC0+IFY0Og0KPiAgICAtIG5vIGNoYW5nZXMNCj4gDQo+IENoYW5nZXMgVjQgLT4gVjU6DQo+
ICAgIC0gc3BsaXQgdGhlIGNoYW5nZXMsIGNoYW5nZSB0aGUgb3JkZXIgb2YgdGhlIHBhdGNoZXMN
Cj4gICAgLSBkcm9wIGFuIGV4dHJhICJ2aXJ0aW8iIGNvbmZpZ3VyYXRpb24gb3B0aW9uDQo+ICAg
IC0gdXBkYXRlIHBhdGNoIGRlc2NyaXB0aW9uDQo+ICAgIC0gdXNlIENPTlRBSU5FUl9PRiBpbnN0
ZWFkIG9mIG93biBpbXBsZW1lbnRhdGlvbg0KPiAgICAtIHJlc2VydmUgcmFuZ2VzIGZvciBWaXJ0
aW8gTU1JTyBwYXJhbXMgYW5kIHB1dCB0aGVtDQo+ICAgICAgaW4gY29ycmVjdCBsb2NhdGlvbg0K
PiAgICAtIGNyZWF0ZSBoZWxwZXJzIHRvIGFsbG9jYXRlIFZpcnRpbyBNTUlPIHBhcmFtcywgYWRk
DQo+ICAgICAgY29ycmVzcG9uZGluZyBzYW5pdHkt0YFoZWNrcw0KPiAgICAtIGFkZCBjb21tZW50
IHdoeSBNTUlPIHNpemUgMHgyMDAgaXMgY2hvc2VuDQo+ICAgIC0gdXBkYXRlIGRlYnVnIHByaW50
DQo+ICAgIC0gZHJvcCBXZWkncyBULWINCj4gDQo+IENoYW5nZXMgVjUgLT4gVjY6DQo+ICAgIC0g
cmViYXNlIG9uIGN1cnJlbnQgc3RhZ2luZw0KPiAtLS0NCj4gIHRvb2xzL2xpYnMvbGlnaHQvbGli
eGxfYXJtLmMgIHwgMTMxDQo+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrLQ0KPiAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggfCAgIDcgKysrDQo+ICAyIGZp
bGVzIGNoYW5nZWQsIDEzNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlm
ZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMgYi90b29scy9saWJzL2xpZ2h0
L2xpYnhsX2FybS5jDQo+IGluZGV4IGVlZjFkZTAuLmQ0NzUyNDkgMTAwNjQ0DQo+IC0tLSBhL3Rv
b2xzL2xpYnMvbGlnaHQvbGlieGxfYXJtLmMNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4
bF9hcm0uYw0KPiBAQCAtOCw2ICs4LDU2IEBADQo+ICAjaW5jbHVkZSA8YXNzZXJ0Lmg+DQo+ICAj
aW5jbHVkZSA8eGVuL2RldmljZV90cmVlX2RlZnMuaD4NCj4gDQo+ICsvKg0KPiArICogVGhlcmUg
aXMgbm8gY2xlYXIgcmVxdWlyZW1lbnRzIGZvciB0aGUgdG90YWwgc2l6ZSBvZiBWaXJ0aW8gTU1J
TyByZWdpb24uDQo+ICsgKiBUaGUgc2l6ZSBvZiBjb250cm9sIHJlZ2lzdGVycyBpcyAweDEwMCBh
bmQgZGV2aWNlLXNwZWNpZmljIGNvbmZpZ3VyYXRpb24NCj4gKyAqIHJlZ2lzdGVycyBzdGFydHMg
YXQgdGhlIG9mZnNldCAweDEwMCwgaG93ZXZlciBpdCdzIHNpemUgZGVwZW5kcyBvbiB0aGUNCj4g
ZGV2aWNlDQo+ICsgKiBhbmQgdGhlIGRyaXZlci4gUGljayB0aGUgYmlnZ2VzdCBrbm93biBzaXpl
IGF0IHRoZSBtb21lbnQgdG8gY292ZXIgbW9zdA0KPiArICogb2YgdGhlIGRldmljZXMgKGFsc28g
Y29uc2lkZXIgYWxsb3dpbmcgdGhlIHVzZXIgdG8gY29uZmlndXJlIHRoZSBzaXplIHZpYQ0KPiAr
ICogY29uZmlnIGZpbGUgZm9yIHRoZSBvbmUgbm90IGNvbmZvcm1pbmcgd2l0aCB0aGUgcHJvcG9z
ZWQgdmFsdWUpLg0KPiArICovDQo+ICsjZGVmaW5lIFZJUlRJT19NTUlPX0RFVl9TSVpFICAgeGVu
X21rX3VsbG9uZygweDIwMCkNCj4gKw0KPiArc3RhdGljIHVpbnQ2NF90IHZpcnRpb19tbWlvX2Jh
c2U7DQo+ICtzdGF0aWMgdWludDMyX3QgdmlydGlvX21taW9faXJxOw0KPiArDQo+ICtzdGF0aWMg
dm9pZCBpbml0X3ZpcnRpb19tbWlvX3BhcmFtcyh2b2lkKQ0KPiArew0KPiArICAgIHZpcnRpb19t
bWlvX2Jhc2UgPSBHVUVTVF9WSVJUSU9fTU1JT19CQVNFOw0KPiArICAgIHZpcnRpb19tbWlvX2ly
cSA9IEdVRVNUX1ZJUlRJT19NTUlPX1NQSV9GSVJTVDsNCj4gK30NCj4gKw0KPiArc3RhdGljIHVp
bnQ2NF90IGFsbG9jX3ZpcnRpb19tbWlvX2Jhc2UobGlieGxfX2djICpnYykNCj4gK3sNCj4gKyAg
ICB1aW50NjRfdCBiYXNlID0gdmlydGlvX21taW9fYmFzZTsNCj4gKw0KPiArICAgIC8qIE1ha2Ug
c3VyZSB3ZSBoYXZlIGVub3VnaCByZXNlcnZlZCByZXNvdXJjZXMgKi8NCj4gKyAgICBpZiAoKHZp
cnRpb19tbWlvX2Jhc2UgKyBWSVJUSU9fTU1JT19ERVZfU0laRSA+DQo+ICsgICAgICAgIEdVRVNU
X1ZJUlRJT19NTUlPX0JBU0UgKyBHVUVTVF9WSVJUSU9fTU1JT19TSVpFKSkgew0KPiArICAgICAg
ICBMT0coRVJST1IsICJSYW4gb3V0IG9mIHJlc2VydmVkIHJhbmdlIGZvciBWaXJ0aW8gTU1JTyBC
QVNFDQo+IDB4JSJQUkl4NjQiXG4iLA0KPiArICAgICAgICAgICAgdmlydGlvX21taW9fYmFzZSk7
DQo+ICsgICAgICAgIHJldHVybiAwOw0KPiArICAgIH0NCj4gKyAgICB2aXJ0aW9fbW1pb19iYXNl
ICs9IFZJUlRJT19NTUlPX0RFVl9TSVpFOw0KPiArDQo+ICsgICAgcmV0dXJuIGJhc2U7DQo+ICt9
DQo+ICsNCj4gK3N0YXRpYyB1aW50MzJfdCBhbGxvY192aXJ0aW9fbW1pb19pcnEobGlieGxfX2dj
ICpnYykNCj4gK3sNCj4gKyAgICB1aW50MzJfdCBpcnEgPSB2aXJ0aW9fbW1pb19pcnE7DQo+ICsN
Cj4gKyAgICAvKiBNYWtlIHN1cmUgd2UgaGF2ZSBlbm91Z2ggcmVzZXJ2ZWQgcmVzb3VyY2VzICov
DQo+ICsgICAgaWYgKHZpcnRpb19tbWlvX2lycSA+IEdVRVNUX1ZJUlRJT19NTUlPX1NQSV9MQVNU
KSB7DQo+ICsgICAgICAgIExPRyhFUlJPUiwgIlJhbiBvdXQgb2YgcmVzZXJ2ZWQgcmFuZ2UgZm9y
IFZpcnRpbyBNTUlPIElSUSAldVxuIiwNCj4gKyAgICAgICAgICAgIHZpcnRpb19tbWlvX2lycSk7
DQo+ICsgICAgICAgIHJldHVybiAwOw0KPiArICAgIH0NCj4gKyAgICB2aXJ0aW9fbW1pb19pcnEr
KzsNCj4gKw0KPiArICAgIHJldHVybiBpcnE7DQo+ICt9DQo+ICsNCj4gIHN0YXRpYyBjb25zdCBj
aGFyICpnaWN2X3RvX3N0cmluZyhsaWJ4bF9naWNfdmVyc2lvbiBnaWNfdmVyc2lvbikNCj4gIHsN
Cj4gICAgICBzd2l0Y2ggKGdpY192ZXJzaW9uKSB7DQo+IEBAIC0yNiw4ICs3Niw4IEBAIGludCBs
aWJ4bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWcobGlieGxfX2djICpnYywNCj4gIHsNCj4g
ICAgICB1aW50MzJfdCBucl9zcGlzID0gMDsNCj4gICAgICB1bnNpZ25lZCBpbnQgaTsNCj4gLSAg
ICB1aW50MzJfdCB2dWFydF9pcnE7DQo+IC0gICAgYm9vbCB2dWFydF9lbmFibGVkID0gZmFsc2U7
DQo+ICsgICAgdWludDMyX3QgdnVhcnRfaXJxLCB2aXJ0aW9faXJxID0gMDsNCj4gKyAgICBib29s
IHZ1YXJ0X2VuYWJsZWQgPSBmYWxzZSwgdmlydGlvX2VuYWJsZWQgPSBmYWxzZTsNCj4gDQo+ICAg
ICAgLyoNCj4gICAgICAgKiBJZiBwbDAxMSB2dWFydCBpcyBlbmFibGVkIHRoZW4gaW5jcmVtZW50
IHRoZSBucl9zcGlzIHRvIGFsbG93IGFsbG9jYXRpb24NCj4gQEAgLTM5LDYgKzg5LDM1IEBAIGlu
dCBsaWJ4bF9fYXJjaF9kb21haW5fcHJlcGFyZV9jb25maWcobGlieGxfX2djICpnYywNCj4gICAg
ICAgICAgdnVhcnRfZW5hYmxlZCA9IHRydWU7DQo+ICAgICAgfQ0KPiANCj4gKyAgICAvKg0KPiAr
ICAgICAqIFZpcnRpbyBNTUlPIHBhcmFtcyBhcmUgbm9uLXVuaXF1ZSBhY3Jvc3MgdGhlIHdob2xl
IHN5c3RlbSBhbmQNCj4gbXVzdCBiZQ0KPiArICAgICAqIGluaXRpYWxpemVkIGZvciBldmVyeSBu
ZXcgZ3Vlc3QuDQo+ICsgICAgICovDQo+ICsgICAgaW5pdF92aXJ0aW9fbW1pb19wYXJhbXMoKTsN
Cj4gKyAgICBmb3IgKGkgPSAwOyBpIDwgZF9jb25maWctPm51bV9kaXNrczsgaSsrKSB7DQo+ICsg
ICAgICAgIGxpYnhsX2RldmljZV9kaXNrICpkaXNrID0gJmRfY29uZmlnLT5kaXNrc1tpXTsNCj4g
Kw0KPiArICAgICAgICBpZiAoZGlzay0+dmlydGlvKSB7DQo+ICsgICAgICAgICAgICBkaXNrLT5i
YXNlID0gYWxsb2NfdmlydGlvX21taW9fYmFzZShnYyk7DQo+ICsgICAgICAgICAgICBpZiAoIWRp
c2stPmJhc2UpDQo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIEVSUk9SX0ZBSUw7DQo+ICsNCj4g
KyAgICAgICAgICAgIGRpc2stPmlycSA9IGFsbG9jX3ZpcnRpb19tbWlvX2lycShnYyk7DQo+ICsg
ICAgICAgICAgICBpZiAoIWRpc2stPmlycSkNCj4gKyAgICAgICAgICAgICAgICByZXR1cm4gRVJS
T1JfRkFJTDsNCj4gKw0KPiArICAgICAgICAgICAgaWYgKHZpcnRpb19pcnEgPCBkaXNrLT5pcnEp
DQo+ICsgICAgICAgICAgICAgICAgdmlydGlvX2lycSA9IGRpc2stPmlycTsNCj4gKyAgICAgICAg
ICAgIHZpcnRpb19lbmFibGVkID0gdHJ1ZTsNCj4gKw0KPiArICAgICAgICAgICAgTE9HKERFQlVH
LCAiQWxsb2NhdGUgVmlydGlvIE1NSU8gcGFyYW1zIGZvciBWZGV2ICVzOiBJUlEgJXUNCj4gQkFT
RSAweCUiUFJJeDY0LA0KPiArICAgICAgICAgICAgICAgIGRpc2stPnZkZXYsIGRpc2stPmlycSwg
ZGlzay0+YmFzZSk7DQo+ICsgICAgICAgIH0NCj4gKyAgICB9DQo+ICsNCj4gKyAgICBpZiAodmly
dGlvX2VuYWJsZWQpDQo+ICsgICAgICAgIG5yX3NwaXMgKz0gKHZpcnRpb19pcnEgLSAzMikgKyAx
Ow0KPiArDQo+ICAgICAgZm9yIChpID0gMDsgaSA8IGRfY29uZmlnLT5iX2luZm8ubnVtX2lycXM7
IGkrKykgew0KPiAgICAgICAgICB1aW50MzJfdCBpcnEgPSBkX2NvbmZpZy0+Yl9pbmZvLmlycXNb
aV07DQo+ICAgICAgICAgIHVpbnQzMl90IHNwaTsNCj4gQEAgLTU4LDYgKzEzNywxMyBAQCBpbnQg
bGlieGxfX2FyY2hfZG9tYWluX3ByZXBhcmVfY29uZmlnKGxpYnhsX19nYyAqZ2MsDQo+ICAgICAg
ICAgICAgICByZXR1cm4gRVJST1JfRkFJTDsNCj4gICAgICAgICAgfQ0KPiANCj4gKyAgICAgICAg
LyogVGhlIHNhbWUgY2hlY2sgYXMgZm9yIHZwbDAxMSAqLw0KPiArICAgICAgICBpZiAodmlydGlv
X2VuYWJsZWQgJiYNCj4gKyAgICAgICAgICAgKGlycSA+PSBHVUVTVF9WSVJUSU9fTU1JT19TUElf
RklSU1QgJiYgaXJxIDw9IHZpcnRpb19pcnEpKSB7DQo+ICsgICAgICAgICAgICBMT0coRVJST1Is
ICJQaHlzaWNhbCBJUlEgJXUgY29uZmxpY3Rpbmcgd2l0aCBWaXJ0aW8gTU1JTyBJUlENCj4gcmFu
Z2VcbiIsIGlycSk7DQo+ICsgICAgICAgICAgICByZXR1cm4gRVJST1JfRkFJTDsNCj4gKyAgICAg
ICAgfQ0KPiArDQo+ICAgICAgICAgIGlmIChpcnEgPCAzMikNCj4gICAgICAgICAgICAgIGNvbnRp
bnVlOw0KPiANCj4gQEAgLTc4Nyw2ICs4NzMsMzkgQEAgc3RhdGljIGludCBtYWtlX3ZwY2lfbm9k
ZShsaWJ4bF9fZ2MgKmdjLCB2b2lkICpmZHQsDQo+ICAgICAgcmV0dXJuIDA7DQo+ICB9DQo+IA0K
PiArDQo+ICtzdGF0aWMgaW50IG1ha2VfdmlydGlvX21taW9fbm9kZShsaWJ4bF9fZ2MgKmdjLCB2
b2lkICpmZHQsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCBi
YXNlLCB1aW50MzJfdCBpcnEpDQo+ICt7DQo+ICsgICAgaW50IHJlczsNCj4gKyAgICBnaWNfaW50
ZXJydXB0IGludHI7DQo+ICsgICAgLyogUGxhY2Vob2xkZXIgZm9yIHZpcnRpb0AgKyBhIDY0LWJp
dCBudW1iZXIgKyBcMCAqLw0KPiArICAgIGNoYXIgYnVmWzI0XTsNCj4gKw0KPiArICAgIHNucHJp
bnRmKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJ2aXJ0aW9AJSJQUkl4NjQsIGJhc2UpOw0KPiArICAgIHJl
cyA9IGZkdF9iZWdpbl9ub2RlKGZkdCwgYnVmKTsNCj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVz
Ow0KPiArDQo+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X2NvbXBhdChnYywgZmR0LCAxLCAidmly
dGlvLG1taW8iKTsNCj4gKyAgICBpZiAocmVzKSByZXR1cm4gcmVzOw0KPiArDQo+ICsgICAgcmVz
ID0gZmR0X3Byb3BlcnR5X3JlZ3MoZ2MsIGZkdCwgR1VFU1RfUk9PVF9BRERSRVNTX0NFTExTLA0K
PiBHVUVTVF9ST09UX1NJWkVfQ0VMTFMsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
MSwgYmFzZSwgVklSVElPX01NSU9fREVWX1NJWkUpOw0KPiArICAgIGlmIChyZXMpIHJldHVybiBy
ZXM7DQo+ICsNCj4gKyAgICBzZXRfaW50ZXJydXB0KGludHIsIGlycSwgMHhmLCBEVF9JUlFfVFlQ
RV9FREdFX1JJU0lORyk7DQo+ICsgICAgcmVzID0gZmR0X3Byb3BlcnR5X2ludGVycnVwdHMoZ2Ms
IGZkdCwgJmludHIsIDEpOw0KPiArICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+ICsNCj4gKyAg
ICByZXMgPSBmZHRfcHJvcGVydHkoZmR0LCAiZG1hLWNvaGVyZW50IiwgTlVMTCwgMCk7DQo+ICsg
ICAgaWYgKHJlcykgcmV0dXJuIHJlczsNCj4gKw0KPiArICAgIHJlcyA9IGZkdF9lbmRfbm9kZShm
ZHQpOw0KPiArICAgIGlmIChyZXMpIHJldHVybiByZXM7DQo+ICsNCj4gKyAgICByZXR1cm4gMDsN
Cj4gK30NCj4gKw0KPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBhcmNoX2luZm8gKmdldF9hcmNoX2lu
Zm8obGlieGxfX2djICpnYywNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIGNvbnN0IHN0cnVjdCB4Y19kb21faW1hZ2UgKmRvbSkNCj4gIHsNCj4gQEAgLTk4
OCw2ICsxMTA3LDcgQEAgc3RhdGljIGludCBsaWJ4bF9fcHJlcGFyZV9kdGIobGlieGxfX2djICpn
YywNCj4gbGlieGxfZG9tYWluX2NvbmZpZyAqZF9jb25maWcsDQo+ICAgICAgc2l6ZV90IGZkdF9z
aXplID0gMDsNCj4gICAgICBpbnQgcGZkdF9zaXplID0gMDsNCj4gICAgICBsaWJ4bF9kb21haW5f
YnVpbGRfaW5mbyAqY29uc3QgaW5mbyA9ICZkX2NvbmZpZy0+Yl9pbmZvOw0KPiArICAgIHVuc2ln
bmVkIGludCBpOw0KPiANCj4gICAgICBjb25zdCBsaWJ4bF92ZXJzaW9uX2luZm8gKnZlcnM7DQo+
ICAgICAgY29uc3Qgc3RydWN0IGFyY2hfaW5mbyAqYWluZm87DQo+IEBAIC0xMDk0LDYgKzEyMTQs
MTMgQEAgbmV4dF9yZXNpemU6DQo+ICAgICAgICAgIGlmIChkX2NvbmZpZy0+bnVtX3BjaWRldnMp
DQo+ICAgICAgICAgICAgICBGRFQoIG1ha2VfdnBjaV9ub2RlKGdjLCBmZHQsIGFpbmZvLCBkb20p
ICk7DQo+IA0KPiArICAgICAgICBmb3IgKGkgPSAwOyBpIDwgZF9jb25maWctPm51bV9kaXNrczsg
aSsrKSB7DQo+ICsgICAgICAgICAgICBsaWJ4bF9kZXZpY2VfZGlzayAqZGlzayA9ICZkX2NvbmZp
Zy0+ZGlza3NbaV07DQo+ICsNCj4gKyAgICAgICAgICAgIGlmIChkaXNrLT52aXJ0aW8pDQo+ICsg
ICAgICAgICAgICAgICAgRkRUKCBtYWtlX3ZpcnRpb19tbWlvX25vZGUoZ2MsIGZkdCwgZGlzay0+
YmFzZSwgZGlzay0+aXJxKSApOw0KPiArICAgICAgICB9DQo+ICsNCj4gICAgICAgICAgaWYgKHBm
ZHQpDQo+ICAgICAgICAgICAgICBGRFQoIGNvcHlfcGFydGlhbF9mZHQoZ2MsIGZkdCwgcGZkdCkg
KTsNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMvYXJjaC1hcm0uaCBiL3hl
bi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+IGluZGV4IDk0YjMxNTEuLjZkYzU1ZGYgMTAw
NjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+ICsrKyBiL3hlbi9p
bmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+IEBAIC0zOTgsNiArMzk4LDEwIEBAIHR5cGVkZWYg
dWludDY0X3QgeGVuX2NhbGxiYWNrX3Q7DQo+IA0KPiAgLyogUGh5c2ljYWwgQWRkcmVzcyBTcGFj
ZSAqLw0KPiANCj4gKy8qIFZpcnRpbyBNTUlPIG1hcHBpbmdzICovDQo+ICsjZGVmaW5lIEdVRVNU
X1ZJUlRJT19NTUlPX0JBU0UgICB4ZW5fbWtfdWxsb25nKDB4MDIwMDAwMDApDQo+ICsjZGVmaW5l
IEdVRVNUX1ZJUlRJT19NTUlPX1NJWkUgICB4ZW5fbWtfdWxsb25nKDB4MDAxMDAwMDApDQo+ICsN
Cj4gIC8qDQo+ICAgKiB2R0lDIG1hcHBpbmdzOiBPbmx5IG9uZSBzZXQgb2YgbWFwcGluZyBpcyB1
c2VkIGJ5IHRoZSBndWVzdC4NCj4gICAqIFRoZXJlZm9yZSB0aGV5IGNhbiBvdmVybGFwLg0KPiBA
QCAtNDg0LDYgKzQ4OCw5IEBAIHR5cGVkZWYgdWludDY0X3QgeGVuX2NhbGxiYWNrX3Q7DQo+IA0K
PiAgI2RlZmluZSBHVUVTVF9WUEwwMTFfU1BJICAgICAgICAzMg0KPiANCj4gKyNkZWZpbmUgR1VF
U1RfVklSVElPX01NSU9fU1BJX0ZJUlNUICAgMzMNCj4gKyNkZWZpbmUgR1VFU1RfVklSVElPX01N
SU9fU1BJX0xBU1QgICAgNDMNCj4gKw0KPiAgLyogUFNDSSBmdW5jdGlvbnMgKi8NCj4gICNkZWZp
bmUgUFNDSV9jcHVfc3VzcGVuZCAwDQo+ICAjZGVmaW5lIFBTQ0lfY3B1X29mZiAgICAgMQ0KPiAt
LQ0KPiAyLjcuNA0KPiANCg0KUmV2aWV3ZWQtYnk6IEhlbnJ5IFdhbmcgPEhlbnJ5LldhbmdAYXJt
LmNvbT4NCg0KS2luZCByZWdhcmRzLA0KDQpIZW5yeQ0K


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 06:50:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 06:50:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242688.419717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDGI-0008H5-As; Thu, 09 Dec 2021 06:50:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242688.419717; Thu, 09 Dec 2021 06:50:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDGI-0008Gy-7U; Thu, 09 Dec 2021 06:50:38 +0000
Received: by outflank-mailman (input) for mailman id 242688;
 Thu, 09 Dec 2021 06:50:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=WAzj=Q2=arm.com=Jiamei.Xie@srs-se1.protection.inumbo.net>)
 id 1mvDGF-0008Gs-Tm
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 06:50:36 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0628.outbound.protection.outlook.com
 [2a01:111:f400:fe1e::628])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4d622732-58bc-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 07:50:32 +0100 (CET)
Received: from DB8PR06CA0028.eurprd06.prod.outlook.com (2603:10a6:10:100::41)
 by HE1PR0801MB1978.eurprd08.prod.outlook.com (2603:10a6:3:52::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 9 Dec
 2021 06:50:28 +0000
Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:100:cafe::93) by DB8PR06CA0028.outlook.office365.com
 (2603:10a6:10:100::41) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13 via Frontend
 Transport; Thu, 9 Dec 2021 06:50:28 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Thu, 9 Dec 2021 06:50:28 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Thu, 09 Dec 2021 06:50:28 +0000
Received: from a3f1d3e18a30.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 8FDED004-3F5E-4643-9CEB-4C82FCE74C56.1; 
 Thu, 09 Dec 2021 06:50:18 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a3f1d3e18a30.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 06:50:18 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com (2603:10a6:803:3d::28)
 by VI1PR0802MB2477.eurprd08.prod.outlook.com (2603:10a6:800:ba::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Thu, 9 Dec
 2021 06:50:14 +0000
Received: from VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::8124:9971:1db2:b704]) by VI1PR08MB3056.eurprd08.prod.outlook.com
 ([fe80::8124:9971:1db2:b704%7]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 06:50:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d622732-58bc-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QgSYQWqiwaZ7mNK6iTbE/ns1VSxz1/YUQ0zuGCgYHSQ=;
 b=7o5xozI9pH4wO7VlD2lfwezFFQyn5aHh52mTSZmgF6isItooAJ6GuH5b1qDY30YJvbvTJOUEyoVVI3Tibjlzld4xUMsHlf4upVES4MgS82S5vIdC4iyNUZFDfWSfYktfyjFw+F9fw0+78ogiBAXpolvTsp0e8Q1PQmztcXUQEX0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KqF755BE8CX/FJEpL6FQ634esIcLAZz6u7krtlzYQ10VYTeaMQLOcfENsAxFOkWj7K8yEMA7EFmsh0FBWssOO51F1rtnW4fW+13K+daK9HCH38CmhGGv5k+o3HImbjRgz24akXnAKi3oZAhQ1axZlrPNR4Mao7MrYGiDG/BeAtTi0dFzdAelVOoc2SnnQZxqqmfxyYvECLu4+SAOEOBE/c9sG7o9Ym6DOmAKQ5p8Uee/7dH646K6WTbAPZrE32I20lllqzG41soBWjFGsrbKWjlYwiGfLhfkkJbL5RjAbqP7tLg1PlNJBvBQB8p8e5eQsAzDxMEUOm73Z9ovdyYLbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QgSYQWqiwaZ7mNK6iTbE/ns1VSxz1/YUQ0zuGCgYHSQ=;
 b=H7Nspf4o5SrwMWLNQK6GtsdEXibHuEqDqgIDPPogS6QwMDEsZHqsYC8J5i0pKKL4tYCVT9yAl9+J3z+kJfOJScKdk6h964HuA/X8v8m7UOAVPRb9KG74etMWIVcAR1X5TlDXujSF/UGuQ/Wzm5jbIqZwrRJAb6BycdV1SWaiHEEE/J/F9ac/X6cpvW1eVzP/ObBWZat+tfGFIEQnjv4uA5VpC58yzNlA7WrtNdBY1LhxY3+JYqGcdTYFoa2dZyHjDcwi+tE1jlE0nkDZDxRYVCJotHv0Ahzl/3fduwIA1HD0FEk+FlhkceEySht9xyoPPX8bY1FtyueNdQrWdnO+1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QgSYQWqiwaZ7mNK6iTbE/ns1VSxz1/YUQ0zuGCgYHSQ=;
 b=7o5xozI9pH4wO7VlD2lfwezFFQyn5aHh52mTSZmgF6isItooAJ6GuH5b1qDY30YJvbvTJOUEyoVVI3Tibjlzld4xUMsHlf4upVES4MgS82S5vIdC4iyNUZFDfWSfYktfyjFw+F9fw0+78ogiBAXpolvTsp0e8Q1PQmztcXUQEX0=
From: Jiamei Xie <Jiamei.Xie@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
	<rosbrookn@ainfosec.com>, Anthony PERARD <anthony.perard@citrix.com>, Juergen
 Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Julien
 Grall <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: RE: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Thread-Topic: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Thread-Index: AQHX7FUvpAP29Ikygk2AvgN46q9B56wpuTkw
Date: Thu, 9 Dec 2021 06:50:13 +0000
Message-ID:
 <VI1PR08MB3056365510C828BDED52C37B92709@VI1PR08MB3056.eurprd08.prod.outlook.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: CE7933A3165BCA47847925B94C78C979.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: eec4dfc1-3833-4e56-277d-08d9bae02fbc
x-ms-traffictypediagnostic:
	VI1PR0802MB2477:EE_|DB5EUR03FT056:EE_|HE1PR0801MB1978:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR0801MB1978C82CAD3DB06590B8F5E492709@HE1PR0801MB1978.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:2089;OLM:2089;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 VTHkBePCximGvZO6mNk6Xcbg8PxXMOjVT19cCFgxQhcLPU8gF5+7VNJoeMC1JK1y/Yy4ZaaO+zXS7Pa9qLAcIdIL+L4cKyTpJCxAPLY2KzFgXFK7FaR36sryY1YvgC0iIILWQyaJqCa8myYzioTKkhiPFSg8N1JbgbBUyT/TxthnSp+cENUjVtTCzNDHCCtgfzGXpwqF1cul40Azk0+mzto+d3MvCAedt8jHzZf27Cnj3aUDX4ltTW/e1ifof2DHxOUGyr/aMrUhnHp3YQK+TpT2E9FEm73EcsjgeAafcyYUtQ/0Rs8kFptmDWPmwGqw4FF5QswNJeXfcHNt+TybG3wFMrQaIaXztaR6BbFBP7kThAfKcwgcyyydGTmT04GJBZebB5OB6R4I1aMwB8trc8MWa2wc+jQ2RfGae8o8Af5f3eemIqToxohEqlBbnMtRYariZ2HVRdS8b0MLX2JNq/4dyDJW5RzRcBsg5Uv/xQoDmyWAxfSPxeNmnsPEZrojoKQee9bnBUYkOD1/1DbT0e99607+c9BCMfFVsBERg09q7BVUpH+P4yKywSySdNoLxnbQrO1L9CrWNLEXF7BQvA+YD6/Ck2g+zeTkfJub3vQZPO59JE6Y9UKnsdlK09FREFy6VkFs8ZCT/X4Cf3q1YbTtwwAMbw+lEH5P9wksHhg2GufFWQpRZ33XsN58PbJ6n41mWNuXBkQ+9icsF1IA6A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3056.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(64756008)(66446008)(6506007)(66556008)(66946007)(76116006)(66476007)(53546011)(7416002)(5660300002)(83380400001)(7696005)(71200400001)(4326008)(52536014)(38070700005)(30864003)(33656002)(86362001)(9686003)(2906002)(508600001)(186003)(26005)(38100700002)(122000001)(54906003)(110136005)(8936002)(316002)(55016003)(8676002)(579004)(559001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2477
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7dc64360-15fd-4933-030a-08d9bae0273a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	3xmRbj4iOzPxTaoh+pRpfRUBN3GRWnlst6DP7WNtsfFDn7FB4fKTPgjYN4Cyhms8VdoV3/dMJY6Nx0dUKYfJR2LeR1gjeoEfzJL9M8JBwJVqQKyelMUgK10yorCant/DOpEh8AI78G5n7UX9pnsOmxB8IxXVtIGsFU5fCXIWl99IJI2Uar/18flPkXnFkscbUS/AMAJkROl13oz8b9DUDVXXroRw0EKbFwwreXFDsKjxtSHTUtpK/lx4utDEoSshWK5lUr2iDyu6VcQ4sRTscNrEi31O5yweEzCsQnTa6WVMfrKsUbFMPQc46mbCKLxmMHDbslOy3063G30eyNGJwf1cMUgk2OACjGHX3JQ00LE6qmtIYXHJXysRCUAs4mGLysvoFWvCloWbVujzfHR1j0IqDXW4C+XRfEYt4G49B/3UXQdwZTmkD/tsch13jRypVztWHJ84SMAjGi+m3Xs/u7cvAnz7OkzjWWq9g3EmLuMKdfw86h+whr9Y9htOg2x1bXfThqHI+SqPxJp7mUIO30geoIsw60jWCrClyBw/pf81uPL2AWM4J7iDTXvKATs9ZL8loLIRArDo7HqSMl3F0SqnFa+p3dss5GolWUTZ8ybdv18bGpYOml2r02sr/1kFSaGlPCoomdO6A6jSLLwOOQNBokek5H71Qeda7Varch2NH+1EcjwKm6GhXJewtqpOAAi8nzgbXCWfJTneuN2WMjHa5LwpOo4Ff19mLwN2CXc3sAhE46adiMWprSdZWl5ViXSOJlSW0gsCozdYMqf8nA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(316002)(8936002)(110136005)(36860700001)(55016003)(53546011)(81166007)(54906003)(9686003)(70206006)(508600001)(5660300002)(4326008)(30864003)(70586007)(2906002)(52536014)(82310400004)(47076005)(8676002)(83380400001)(26005)(7696005)(336012)(356005)(186003)(6506007)(33656002)(40460700001)(86362001)(579004)(559001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 06:50:28.5780
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: eec4dfc1-3833-4e56-277d-08d9bae02fbc
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1978



> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Oleksandr Tyshchenko
> Sent: 2021=1B$BG/=1B(B12=1B$B7n=1B(B9=1B$BF|=1B(B 1:00
> To: xen-devel@lists.xenproject.org
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>; Wei Liu
> <wl@xen.org>; George Dunlap <george.dunlap@citrix.com>; Nick Rosbrook
> <rosbrookn@ainfosec.com>; Anthony PERARD <anthony.perard@citrix.com>;
> Juergen Gross <jgross@suse.com>; Stefano Stabellini
> <sstabellini@kernel.org>; Julien Grall <julien@xen.org>; Volodymyr Babchu=
k
> <Volodymyr_Babchuk@epam.com>; Bertrand Marquis
> <Bertrand.Marquis@arm.com>
> Subject: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> This patch adds basic support for configuring and assisting virtio-disk
> backend (emualator) which is intended to run out of Qemu and could be
> run in any domain.
> Although the Virtio block device is quite different from traditional
> Xen PV block device (vbd) from the toolstack point of view:
>  - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>    written to Xenstore are fetched by the frontend (the vdev is not
>    passed to the frontend)
>  - the ring-ref/event-channel are not used for the backend<->frontend
>    communication, the proposed IPC for Virtio is IOREQ/DM
> it is still a "block device" and ought to be integrated in existing
> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
> logic to deal with Virtio devices as well.
>=20
> Besides introducing new disk backend type (LIBXL_DISK_BACKEND_VIRTIO)
> introduce new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model.
>=20
> In order to inform the toolstack that Virtio disk needs to be used
> extend "disk" configuration by introducing new "virtio" flag.
> An example of domain configuration:
> disk =3D [ 'backend=3DDomD, phy:/dev/mmcblk1p3, xvda1, rw, virtio' ]
>=20
> Please note, this patch is not enough for virtio-disk to work
> on Xen (Arm), as for every Virtio device (including disk) we need
> to allocate Virtio MMIO params (IRQ and memory region) and pass
> them to the backend, also update Guest device-tree. The subsequent
> patch will add these missing bits. For the current patch,
> the default "irq" and "base" are just written to the Xenstore.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> ---
> Changes RFC -> V1:
>    - no changes
>=20
> Changes V1 -> V2:
>    - rebase according to the new location of libxl_virtio_disk.c
>=20
> Changes V2 -> V3:
>    - no changes
>=20
> Changes V3 -> V4:
>    - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT
>=20
> Changes V4 -> V5:
>    - split the changes, change the order of the patches
>    - update patch description
>    - don't introduce new "vdisk" configuration option with own parsing lo=
gic,
>      re-use Xen PV block "disk" parsing/configuration logic for the virti=
o-disk
>    - introduce "virtio" flag and document it's usage
>    - add LIBXL_HAVE_DEVICE_DISK_VIRTIO
>    - update libxlu_disk_l.[ch]
>    - drop num_disks variable/MAX_VIRTIO_DISKS
>    - drop Wei's T-b
>=20
> Changes V5 -> V6:
>    - rebase on current staging
>    - use "%"PRIu64 instead of %lu for disk->base in device_disk_add()
>    - update *.gen.go files
> ---
>  docs/man/xl-disk-configuration.5.pod.in   |  27 +
>  tools/golang/xenlight/helpers.gen.go      |   6 +
>  tools/golang/xenlight/types.gen.go        |   4 +
>  tools/include/libxl.h                     |   6 +
>  tools/libs/light/libxl_device.c           |  38 +-
>  tools/libs/light/libxl_disk.c             |  99 +++-
>  tools/libs/light/libxl_types.idl          |   4 +
>  tools/libs/light/libxl_types_internal.idl |   1 +
>  tools/libs/light/libxl_utils.c            |   2 +
>  tools/libs/util/libxlu_disk_l.c           | 881 +++++++++++++++---------=
------
>  tools/libs/util/libxlu_disk_l.h           |   2 +-
>  tools/libs/util/libxlu_disk_l.l           |   1 +
>  tools/xl/xl_block.c                       |  11 +
>  13 files changed, 636 insertions(+), 446 deletions(-)
>=20
> diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-
> configuration.5.pod.in
> index 71d0e86..9cc189f 100644
> --- a/docs/man/xl-disk-configuration.5.pod.in
> +++ b/docs/man/xl-disk-configuration.5.pod.in
> @@ -344,8 +344,35 @@ can be used to disable "hole punching" for file
> based backends which
>  were intentionally created non-sparse to avoid fragmentation of the
>  file.
>=20
> +=3Ditem B<virtio>
> +
> +=3Dover 4
> +
> +=3Ditem Description
> +
> +Enables experimental Virtio support for disk
> +
> +=3Ditem Supported values
> +
> +absent, present
> +
> +=3Ditem Mandatory
> +
> +No
> +
> +=3Ditem Default value
> +
> +absent
> +
>  =3Dback
>=20
> +Besides forcing toolstack to use specific Xen Virtio backend implementat=
ion
> +(for example, virtio-disk), this also affects the guest's view of the de=
vice
> +and requires virtio-blk driver to be used.
> +Please note, the virtual device (vdev) is not passed to the guest in tha=
t case,
> +but it still must be specified for the internal purposes.
> +
> +=3Dback
>=20
>  =3Dhead1 COLO Parameters
>=20
> diff --git a/tools/golang/xenlight/helpers.gen.go
> b/tools/golang/xenlight/helpers.gen.go
> index b746ff1..787e3ba 100644
> --- a/tools/golang/xenlight/helpers.gen.go
> +++ b/tools/golang/xenlight/helpers.gen.go
> @@ -1751,6 +1751,9 @@ x.DirectIoSafe =3D bool(xc.direct_io_safe)
>  if err :=3D x.DiscardEnable.fromC(&xc.discard_enable);err !=3D nil {
>  return fmt.Errorf("converting field DiscardEnable: %v", err)
>  }
> +x.Virtio =3D bool(xc.virtio)
> +x.Irq =3D uint32(xc.irq)
> +x.Base =3D uint64(xc.base)
>  if err :=3D x.ColoEnable.fromC(&xc.colo_enable);err !=3D nil {
>  return fmt.Errorf("converting field ColoEnable: %v", err)
>  }
> @@ -1788,6 +1791,9 @@ xc.direct_io_safe =3D C.bool(x.DirectIoSafe)
>  if err :=3D x.DiscardEnable.toC(&xc.discard_enable); err !=3D nil {
>  return fmt.Errorf("converting field DiscardEnable: %v", err)
>  }
> +xc.virtio =3D C.bool(x.Virtio)
> +xc.irq =3D C.uint32_t(x.Irq)
> +xc.base =3D C.uint64_t(x.Base)
>  if err :=3D x.ColoEnable.toC(&xc.colo_enable); err !=3D nil {
>  return fmt.Errorf("converting field ColoEnable: %v", err)
>  }
> diff --git a/tools/golang/xenlight/types.gen.go
> b/tools/golang/xenlight/types.gen.go
> index b1e84d5..1d6868a 100644
> --- a/tools/golang/xenlight/types.gen.go
> +++ b/tools/golang/xenlight/types.gen.go
> @@ -99,6 +99,7 @@ DiskBackendUnknown DiskBackend =3D 0
>  DiskBackendPhy DiskBackend =3D 1
>  DiskBackendTap DiskBackend =3D 2
>  DiskBackendQdisk DiskBackend =3D 3
> +DiskBackendVirtio DiskBackend =3D 4
>  )
>=20
>  type NicType int
> @@ -643,6 +644,9 @@ Readwrite int
>  IsCdrom int
>  DirectIoSafe bool
>  DiscardEnable Defbool
> +Virtio bool
> +Irq uint32
> +Base uint64
>  ColoEnable Defbool
>  ColoRestoreEnable Defbool
>  ColoHost string
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 2bbbd21..1ea7475 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -528,6 +528,12 @@
>  #define LIBXL_HAVE_MAX_GRANT_VERSION 1
>=20
>  /*
> + * LIBXL_HAVE_DEVICE_DISK_VIRTIO indicates that a 'virtio' field
> + * (of boolean type) is present in libxl_device_disk.
> + */
> +#define LIBXL_HAVE_DEVICE_DISK_VIRTIO 1
> +
> +/*
>   * libxl ABI compatibility
>   *
>   * The only guarantee which libxl makes regarding ABI compatibility
> diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_dev=
ice.c
> index 36c4e41..7c8cb53 100644
> --- a/tools/libs/light/libxl_device.c
> +++ b/tools/libs/light/libxl_device.c
> @@ -292,6 +292,9 @@ static int disk_try_backend(disk_try_backend_args *a,
>      /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or
>       * backend on success */
>=20
> +    if (a->disk->virtio && backend !=3D LIBXL_DISK_BACKEND_VIRTIO)
> +        goto bad_virtio;
> +
>      switch (backend) {
>      case LIBXL_DISK_BACKEND_PHY:
>          if (a->disk->format !=3D LIBXL_DISK_FORMAT_RAW) {
> @@ -329,6 +332,29 @@ static int disk_try_backend(disk_try_backend_args
> *a,
>          if (a->disk->script) goto bad_script;
>          return backend;
>=20
> +    case LIBXL_DISK_BACKEND_VIRTIO:
> +        if (a->disk->format !=3D LIBXL_DISK_FORMAT_RAW)
> +            goto bad_format;
> +
> +        if (a->disk->script)
> +            goto bad_script;
> +
> +        if (libxl_defbool_val(a->disk->colo_enable))
> +            goto bad_colo;
> +
> +        if (a->disk->backend_domid !=3D LIBXL_TOOLSTACK_DOMID) {
> +            LOG(DEBUG, "Disk vdev=3D%s, is using a storage driver domain=
, "
> +                       "skipping physical device check", a->disk->vdev);
> +            return backend;
> +        }
> +
> +        if (libxl__try_phy_backend(a->stab.st_mode))
> +            return backend;
> +
> +        LOG(DEBUG, "Disk vdev=3D%s, backend virtio unsuitable as phys pa=
th not
> a "
> +                   "block device", a->disk->vdev);
> +        return 0;
> +
>      default:
>          LOG(DEBUG, "Disk vdev=3D%s, backend %d unknown", a->disk->vdev,
> backend);
>          return 0;
> @@ -352,6 +378,11 @@ static int disk_try_backend(disk_try_backend_args
> *a,
>      LOG(DEBUG, "Disk vdev=3D%s, backend %s not compatible with colo",
>          a->disk->vdev, libxl_disk_backend_to_string(backend));
>      return 0;
> +
> + bad_virtio:
> +    LOG(DEBUG, "Disk vdev=3D%s, backend %s not compatible with virtio",
> +        a->disk->vdev, libxl_disk_backend_to_string(backend));
> +    return 0;
>  }
>=20
>  int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path,
> @@ -392,7 +423,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc,
> libxl_device_disk *disk) {
>          }
>          memset(&a.stab, 0, sizeof(a.stab));
>      } else if ((disk->backend =3D=3D LIBXL_DISK_BACKEND_UNKNOWN ||
> -                disk->backend =3D=3D LIBXL_DISK_BACKEND_PHY) &&
> +                disk->backend =3D=3D LIBXL_DISK_BACKEND_PHY ||
> +                disk->backend =3D=3D LIBXL_DISK_BACKEND_VIRTIO) &&
>                 disk->backend_domid =3D=3D LIBXL_TOOLSTACK_DOMID &&
>                 !disk->script) {
>          if (stat(disk->pdev_path, &a.stab)) {
> @@ -408,7 +440,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc,
> libxl_device_disk *disk) {
>          ok=3D
>              disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?:
>              disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?:
> -            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP);
> +            disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?:
> +            disk_try_backend(&a, LIBXL_DISK_BACKEND_VIRTIO);
>          if (ok)
>              LOG(DEBUG, "Disk vdev=3D%s, using backend %s",
>                         disk->vdev,
> @@ -441,6 +474,7 @@ char
> *libxl__device_disk_string_of_backend(libxl_disk_backend backend)
>          case LIBXL_DISK_BACKEND_QDISK: return "qdisk";
>          case LIBXL_DISK_BACKEND_TAP: return "phy";
>          case LIBXL_DISK_BACKEND_PHY: return "phy";
> +        case LIBXL_DISK_BACKEND_VIRTIO: return "virtio_disk";
>          default: return NULL;
>      }
>  }
> diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.=
c
> index 93936d0..912b3f5 100644
> --- a/tools/libs/light/libxl_disk.c
> +++ b/tools/libs/light/libxl_disk.c
> @@ -174,6 +174,16 @@ static int libxl__device_disk_setdefault(libxl__gc *=
gc,
> uint32_t domid,
>          disk->backend =3D LIBXL_DISK_BACKEND_QDISK;
>      }
>=20
> +    /* Force virtio_disk backend for Virtio devices */
> +    if (disk->virtio) {
> +        if (!(disk->backend =3D=3D LIBXL_DISK_BACKEND_VIRTIO ||
> +              disk->backend =3D=3D LIBXL_DISK_BACKEND_UNKNOWN)) {
> +            LOGD(ERROR, domid, "Backend for Virtio devices on must be
> virtio_disk");
> +            return ERROR_FAIL;
> +        }
> +        disk->backend =3D LIBXL_DISK_BACKEND_VIRTIO;
> +    }
> +
>      rc =3D libxl__device_disk_set_backend(gc, disk);
>      return rc;
>  }
> @@ -204,6 +214,9 @@ static int libxl__device_from_disk(libxl__gc *gc,
> uint32_t domid,
>          case LIBXL_DISK_BACKEND_QDISK:
>              device->backend_kind =3D LIBXL__DEVICE_KIND_QDISK;
>              break;
> +        case LIBXL_DISK_BACKEND_VIRTIO:
> +            device->backend_kind =3D LIBXL__DEVICE_KIND_VIRTIO_DISK;
> +            break;
>          default:
>              LOGD(ERROR, domid, "Unrecognized disk backend type: %d",
>                   disk->backend);
> @@ -212,7 +225,8 @@ static int libxl__device_from_disk(libxl__gc *gc,
> uint32_t domid,
>=20
>      device->domid =3D domid;
>      device->devid =3D devid;
> -    device->kind  =3D LIBXL__DEVICE_KIND_VBD;
> +    device->kind =3D disk->backend =3D=3D LIBXL_DISK_BACKEND_VIRTIO ?
> +        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
>=20
>      return 0;
>  }
> @@ -330,7 +344,17 @@ static void device_disk_add(libxl__egc *egc,
> uint32_t domid,
>=20
>                  assert(device->backend_kind =3D=3D LIBXL__DEVICE_KIND_VB=
D);
>                  break;
> +            case LIBXL_DISK_BACKEND_VIRTIO:
> +                dev =3D disk->pdev_path;
> +
> +                flexarray_append(back, "params");
> +                flexarray_append(back, dev);
>=20
> +                flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64,=
 disk-
> >base));
> +                flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk-=
>irq));
> +
> +                assert(device->backend_kind =3D=3D
> LIBXL__DEVICE_KIND_VIRTIO_DISK);
> +                break;
>              case LIBXL_DISK_BACKEND_TAP:
>                  LOG(ERROR, "blktap is not supported");
>                  rc =3D ERROR_FAIL;
> @@ -532,6 +556,26 @@ static int libxl__disk_from_xenstore(libxl__gc *gc,
> const char *libxl_path,
>      }
>      libxl_string_to_backend(ctx, tmp, &(disk->backend));
>=20
> +    if (disk->backend =3D=3D LIBXL_DISK_BACKEND_VIRTIO) {
> +        disk->virtio =3D true;
> +
> +        tmp =3D libxl__xs_read(gc, XBT_NULL,
> +                             GCSPRINTF("%s/base", libxl_path));
> +        if (!tmp) {
> +            LOG(ERROR, "Missing xenstore node %s/base", libxl_path);
> +            goto cleanup;
> +        }
> +        disk->base =3D strtoul(tmp, NULL, 10);
> +
> +        tmp =3D libxl__xs_read(gc, XBT_NULL,
> +                             GCSPRINTF("%s/irq", libxl_path));
> +        if (!tmp) {
> +            LOG(ERROR, "Missing xenstore node %s/irq", libxl_path);
> +            goto cleanup;
> +        }
> +        disk->irq =3D strtoul(tmp, NULL, 10);
> +    }
> +
>      disk->vdev =3D xs_read(ctx->xsh, XBT_NULL,
>                           GCSPRINTF("%s/dev", libxl_path), &len);
>      if (!disk->vdev) {
> @@ -575,6 +619,41 @@ cleanup:
>      return rc;
>  }
>=20
> +static int libxl_device_disk_get_path(libxl__gc *gc, uint32_t domid,
> +                                      char **path)
> +{
> +    const char *dir;
> +    int rc;
> +
> +    /*
> +     * As we don't know exactly what device kind to be used here, guess =
it
> +     * by checking the presence of the corresponding path in Xenstore.
> +     * First, try to read path for vbd device (default) and if not exist=
s
> +     * read path for virtio_disk device. This will work as long as both =
Xen PV
> +     * and Virtio disk devices are not assigned to the same guest.
> +     */
> +    *path =3D GCSPRINTF("%s/device/%s",
> +                      libxl__xs_libxl_path(gc, domid),
> +                      libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VB=
D));
> +
> +    rc =3D libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
> +    if (rc)
> +        return rc;
> +
> +    if (dir)
> +        return 0;
> +
> +    *path =3D GCSPRINTF("%s/device/%s",
> +                      libxl__xs_libxl_path(gc, domid),
> +
> libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK));
> +
> +    rc =3D libxl__xs_read_checked(gc, XBT_NULL, *path, &dir);
> +    if (rc)
> +        return rc;
> +
> +    return 0;
> +}
> +
>  int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid,
>                                const char *vdev, libxl_device_disk *disk)
>  {
> @@ -588,10 +667,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx,
> uint32_t domid,
>=20
>      libxl_device_disk_init(disk);
>=20
> -    libxl_path =3D libxl__domain_device_libxl_path(gc, domid, devid,
> -                                                 LIBXL__DEVICE_KIND_VBD)=
;
> +    rc =3D libxl_device_disk_get_path(gc, domid, &libxl_path);
> +    if (rc)
> +        return rc;
>=20
> -    rc =3D libxl__disk_from_xenstore(gc, libxl_path, devid, disk);
> +    rc =3D libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, =
devid),
> +                                   devid, disk);
>=20
>      GC_FREE;
>      return rc;
> @@ -605,16 +686,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx,
> uint32_t domid,
>      char *fe_path, *libxl_path;
>      char *val;
>      int rc;
> +    libxl__device_kind kind;
>=20
>      diskinfo->backend =3D NULL;
>=20
>      diskinfo->devid =3D libxl__device_disk_dev_number(disk->vdev, NULL, =
NULL);
>=20
> -    /* tap devices entries in xenstore are written as vbd devices. */
> +    /* tap devices entries in xenstore are written as vbd/virtio_disk de=
vices.
> */
> +    kind =3D disk->backend =3D=3D LIBXL_DISK_BACKEND_VIRTIO ?
> +        LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD;
>      fe_path =3D libxl__domain_device_frontend_path(gc, domid, diskinfo-
> >devid,
> -                                                 LIBXL__DEVICE_KIND_VBD)=
;
> +                                                 kind);
>      libxl_path =3D libxl__domain_device_libxl_path(gc, domid, diskinfo->=
devid,
> -                                                 LIBXL__DEVICE_KIND_VBD)=
;
> +                                                 kind);
>      diskinfo->backend =3D xs_read(ctx->xsh, XBT_NULL,
>                                  GCSPRINTF("%s/backend", libxl_path), NUL=
L);
>      if (!diskinfo->backend) {
> @@ -1418,6 +1502,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk)
>  #define libxl__device_disk_update_devid NULL
>=20
>  DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks,
> +    .get_path    =3D libxl_device_disk_get_path,
>      .merge       =3D libxl_device_disk_merge,
>      .dm_needed   =3D libxl_device_disk_dm_needed,
>      .from_xenstore =3D (device_from_xenstore_fn_t)libxl__disk_from_xenst=
ore,
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty=
pes.idl
> index 2a42da2..31e4a15 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -130,6 +130,7 @@ libxl_disk_backend =3D Enumeration("disk_backend", [
>      (1, "PHY"),
>      (2, "TAP"),
>      (3, "QDISK"),
> +    (4, "VIRTIO"),
>      ])
>=20
>  libxl_nic_type =3D Enumeration("nic_type", [
> @@ -704,6 +705,9 @@ libxl_device_disk =3D Struct("device_disk", [
>      ("is_cdrom", integer),
>      ("direct_io_safe", bool),
>      ("discard_enable", libxl_defbool),
> +    ("virtio", bool),
> +    ("irq", uint32),
> +    ("base", uint64),
>      # Note that the COLO configuration settings should be considered uns=
table.
>      # They may change incompatibly in future versions of Xen.
>      ("colo_enable", libxl_defbool),
> diff --git a/tools/libs/light/libxl_types_internal.idl
> b/tools/libs/light/libxl_types_internal.idl
> index 3593e21..8f71980 100644
> --- a/tools/libs/light/libxl_types_internal.idl
> +++ b/tools/libs/light/libxl_types_internal.idl
> @@ -32,6 +32,7 @@ libxl__device_kind =3D Enumeration("device_kind", [
>      (14, "PVCALLS"),
>      (15, "VSND"),
>      (16, "VINPUT"),
> +    (17, "VIRTIO_DISK"),
>      ])
>=20
>  libxl__console_backend =3D Enumeration("console_backend", [
> diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_util=
s.c
> index 4699c4a..fa406de 100644
> --- a/tools/libs/light/libxl_utils.c
> +++ b/tools/libs/light/libxl_utils.c
> @@ -304,6 +304,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s,
> libxl_disk_backend *backend
>          *backend =3D LIBXL_DISK_BACKEND_TAP;
>      } else if (!strcmp(s, "qdisk")) {
>          *backend =3D LIBXL_DISK_BACKEND_QDISK;
> +    } else if (!strcmp(s, "virtio_disk")) {
> +        *backend =3D LIBXL_DISK_BACKEND_VIRTIO;
>      } else if (!strcmp(s, "tap")) {
>          p =3D strchr(s, ':');
>          if (!p) {
> diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_dis=
k_l.c
> index 32d4b74..7abc699 100644
> --- a/tools/libs/util/libxlu_disk_l.c
> +++ b/tools/libs/util/libxlu_disk_l.c
> @@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char*
> msg , yyscan_t yyscanner );
>  	yyg->yy_hold_char =3D *yy_cp; \
>  	*yy_cp =3D '\0'; \
>  	yyg->yy_c_buf_p =3D yy_cp;
> -#define YY_NUM_RULES 36
> -#define YY_END_OF_BUFFER 37
> +#define YY_NUM_RULES 37
> +#define YY_END_OF_BUFFER 38
>  /* This struct is not used in this scanner,
>     but its presence is necessary. */
>  struct yy_trans_info
> @@ -558,74 +558,75 @@ struct yy_trans_info
>  	flex_int32_t yy_verify;
>  	flex_int32_t yy_nxt;
>  	};
> -static const flex_int16_t yy_acclist[575] =3D
> +static const flex_int16_t yy_acclist[583] =3D
>      {   0,
> -       35,   35,   37,   33,   34,   36, 8193,   33,   34,   36,
> -    16385, 8193,   33,   36,16385,   33,   34,   36,   34,   36,
> -       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
> -       34,   36,   33,   34,   36,   33,   34,   36,   33,   34,
> -       36,   33,   34,   36,   33,   34,   36,   33,   34,   36,
> -       33,   34,   36,   33,   34,   36,   33,   34,   36,   33,
> -       34,   36,   33,   34,   36,   33,   34,   36,   35,   36,
> -       36,   33,   33, 8193,   33, 8193,   33,16385, 8193,   33,
> -     8193,   33,   33, 8224,   33,16416,   33,   33,   33,   33,
> -       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
> -
> -       33,   33,   33,   33,   33,   33,   33,   33,   33,   35,
> -     8193,   33, 8193,   33, 8193, 8224,   33, 8224,   33, 8224,
> -       23,   33,   33,   33,   33,   33,   33,   33,   33,   33,
> -       33,   33,   33,   33,   33,   33,   33,   33,   33,   33,
> -       33,   33,   33,   33,   33, 8224,   33, 8224,   33, 8224,
> -       23,   33,   33,   28, 8224,   33,16416,   33,   33,   15,
> -       33,   33,   33,   33,   33,   33,   33,   33,   33, 8217,
> -     8224,   33,16409,16416,   33,   33,   31, 8224,   33,16416,
> -       33, 8216, 8224,   33,16408,16416,   33,   33, 8219, 8224,
> -       33,16411,16416,   33,   33,   33,   33,   33,   28, 8224,
> -
> -       33,   28, 8224,   33,   28,   33,   28, 8224,   33,    3,
> -       33,   15,   33,   33,   33,   33,   33,   30, 8224,   33,
> -    16416,   33,   33,   33, 8217, 8224,   33, 8217, 8224,   33,
> -     8217,   33, 8217, 8224,   33,   33,   31, 8224,   33,   31,
> -     8224,   33,   31,   33,   31, 8224, 8216, 8224,   33, 8216,
> -     8224,   33, 8216,   33, 8216, 8224,   33, 8219, 8224,   33,
> -     8219, 8224,   33, 8219,   33, 8219, 8224,   33,   33,   10,
> -       33,   33,   28, 8224,   33,   28, 8224,   33,   28, 8224,
> -       28,   33,   28,   33,    3,   33,   33,   33,   33,   33,
> -       33,   33,   30, 8224,   33,   30, 8224,   33,   30,   33,
> -
> -       30, 8224,   33,   33,   29, 8224,   33,16416, 8217, 8224,
> -       33, 8217, 8224,   33, 8217, 8224, 8217,   33, 8217,   33,
> -       33,   31, 8224,   33,   31, 8224,   33,   31, 8224,   31,
> -       33,   31, 8216, 8224,   33, 8216, 8224,   33, 8216, 8224,
> -     8216,   33, 8216,   33, 8219, 8224,   33, 8219, 8224,   33,
> -     8219, 8224, 8219,   33, 8219,   33,   33,   10,   23,   10,
> -        7,   33,   33,   33,   33,   33,   33,   33,   13,   33,
> -       30, 8224,   33,   30, 8224,   33,   30, 8224,   30,   33,
> -       30,    2,   33,   29, 8224,   33,   29, 8224,   33,   29,
> -       33,   29, 8224,   16,   33,   33,   11,   33,   22,   10,
> -
> -       10,   23,    7,   23,    7,   33,    8,   33,   33,   33,
> -       33,    6,   33,   13,   33,    2,   23,    2,   33,   29,
> -     8224,   33,   29, 8224,   33,   29, 8224,   29,   33,   29,
> -       16,   33,   33,   11,   23,   11,   26, 8224,   33,16416,
> -       22,   23,   22,    7,    7,   23,   33,    8,   23,    8,
> -       33,   33,   33,   33,    6,   23,    6,    6,   23,    6,
> -       23,   33,    2,    2,   23,   33,   33,   11,   11,   23,
> -       26, 8224,   33,   26, 8224,   33,   26,   33,   26, 8224,
> -       22,   23,   33,    8,    8,   23,   33,   33,   17,   18,
> -        6,    6,   23,    6,    6,   33,   33,   14,   33,   26,
> -
> -     8224,   33,   26, 8224,   33,   26, 8224,   26,   33,   26,
> -       33,   33,   33,   17,   23,   17,   18,   23,   18,    6,
> -        6,   33,   33,   14,   33,   20,    9,   19,   17,   17,
> -       23,   18,   18,   23,    6,    5,    6,   33,   21,   20,
> -       23,   20,    9,   23,    9,   19,   23,   19,    4,    6,
> -        5,    6,   33,   21,   23,   21,   20,   20,   23,    9,
> -        9,   23,   19,   19,   23,    4,    6,   12,   33,   21,
> -       21,   23,   12,   33
> +       36,   36,   38,   34,   35,   37, 8193,   34,   35,   37,
> +    16385, 8193,   34,   37,16385,   34,   35,   37,   35,   37,
> +       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
> +       35,   37,   34,   35,   37,   34,   35,   37,   34,   35,
> +       37,   34,   35,   37,   34,   35,   37,   34,   35,   37,
> +       34,   35,   37,   34,   35,   37,   34,   35,   37,   34,
> +       35,   37,   34,   35,   37,   34,   35,   37,   36,   37,
> +       37,   34,   34, 8193,   34, 8193,   34,16385, 8193,   34,
> +     8193,   34,   34, 8225,   34,16417,   34,   34,   34,   34,
> +       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
> +
> +       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
> +       36, 8193,   34, 8193,   34, 8193, 8225,   34, 8225,   34,
> +     8225,   24,   34,   34,   34,   34,   34,   34,   34,   34,
> +       34,   34,   34,   34,   34,   34,   34,   34,   34,   34,
> +       34,   34,   34,   34,   34,   34,   34, 8225,   34, 8225,
> +       34, 8225,   24,   34,   34,   29, 8225,   34,16417,   34,
> +       34,   16,   34,   34,   34,   34,   34,   34,   34,   34,
> +       34, 8218, 8225,   34,16410,16417,   34,   34,   32, 8225,
> +       34,16417,   34, 8217, 8225,   34,16409,16417,   34,   34,
> +     8220, 8225,   34,16412,16417,   34,   34,   34,   34,   34,
> +
> +       34,   29, 8225,   34,   29, 8225,   34,   29,   34,   29,
> +     8225,   34,    3,   34,   16,   34,   34,   34,   34,   34,
> +       31, 8225,   34,16417,   34,   34,   34, 8218, 8225,   34,
> +     8218, 8225,   34, 8218,   34, 8218, 8225,   34,   34,   32,
> +     8225,   34,   32, 8225,   34,   32,   34,   32, 8225, 8217,
> +     8225,   34, 8217, 8225,   34, 8217,   34, 8217, 8225,   34,
> +     8220, 8225,   34, 8220, 8225,   34, 8220,   34, 8220, 8225,
> +       34,   34,   10,   34,   34,   34,   29, 8225,   34,   29,
> +     8225,   34,   29, 8225,   29,   34,   29,   34,    3,   34,
> +       34,   34,   34,   34,   34,   34,   31, 8225,   34,   31,
> +
> +     8225,   34,   31,   34,   31, 8225,   34,   34,   30, 8225,
> +       34,16417, 8218, 8225,   34, 8218, 8225,   34, 8218, 8225,
> +     8218,   34, 8218,   34,   34,   32, 8225,   34,   32, 8225,
> +       34,   32, 8225,   32,   34,   32, 8217, 8225,   34, 8217,
> +     8225,   34, 8217, 8225, 8217,   34, 8217,   34, 8220, 8225,
> +       34, 8220, 8225,   34, 8220, 8225, 8220,   34, 8220,   34,
> +       34,   10,   24,   10,   15,   34,    7,   34,   34,   34,
> +       34,   34,   34,   34,   13,   34,   31, 8225,   34,   31,
> +     8225,   34,   31, 8225,   31,   34,   31,    2,   34,   30,
> +     8225,   34,   30, 8225,   34,   30,   34,   30, 8225,   17,
> +
> +       34,   34,   11,   34,   23,   10,   10,   24,   15,   34,
> +        7,   24,    7,   34,    8,   34,   34,   34,   34,    6,
> +       34,   13,   34,    2,   24,    2,   34,   30, 8225,   34,
> +       30, 8225,   34,   30, 8225,   30,   34,   30,   17,   34,
> +       34,   11,   24,   11,   27, 8225,   34,16417,   23,   24,
> +       23,    7,    7,   24,   34,    8,   24,    8,   34,   34,
> +       34,   34,    6,   24,    6,    6,   24,    6,   24,   34,
> +        2,    2,   24,   34,   34,   11,   11,   24,   27, 8225,
> +       34,   27, 8225,   34,   27,   34,   27, 8225,   23,   24,
> +       34,    8,    8,   24,   34,   34,   18,   19,    6,    6,
> +
> +       24,    6,    6,   34,   34,   14,   34,   27, 8225,   34,
> +       27, 8225,   34,   27, 8225,   27,   34,   27,   34,   34,
> +       34,   18,   24,   18,   19,   24,   19,    6,    6,   34,
> +       34,   14,   34,   21,    9,   20,   18,   18,   24,   19,
> +       19,   24,    6,    5,    6,   34,   22,   21,   24,   21,
> +        9,   24,    9,   20,   24,   20,    4,    6,    5,    6,
> +       34,   22,   24,   22,   21,   21,   24,    9,    9,   24,
> +       20,   20,   24,    4,    6,   12,   34,   22,   22,   24,
> +       12,   34
>      } ;
>=20
> -static const flex_int16_t yy_accept[356] =3D
> +static const flex_int16_t yy_accept[362] =3D
>      {   0,
>          1,    1,    1,    2,    3,    4,    7,   12,   16,   19,
>         21,   24,   27,   30,   33,   36,   39,   42,   45,   48,
> @@ -633,39 +634,40 @@ static const flex_int16_t yy_accept[356] =3D
>         74,   76,   79,   81,   82,   83,   84,   87,   87,   88,
>         89,   90,   91,   92,   93,   94,   95,   96,   97,   98,
>         99,  100,  101,  102,  103,  104,  105,  106,  107,  108,
> -      109,  110,  111,  113,  115,  116,  118,  120,  121,  122,
> +      109,  110,  111,  112,  114,  116,  117,  119,  121,  122,
>        123,  124,  125,  126,  127,  128,  129,  130,  131,  132,
>        133,  134,  135,  136,  137,  138,  139,  140,  141,  142,
> -      143,  144,  145,  146,  148,  150,  151,  152,  153,  154,
> -
> -      158,  159,  160,  162,  163,  164,  165,  166,  167,  168,
> -      169,  170,  175,  176,  177,  181,  182,  187,  188,  189,
> -      194,  195,  196,  197,  198,  199,  202,  205,  207,  209,
> -      210,  212,  214,  215,  216,  217,  218,  222,  223,  224,
> -      225,  228,  231,  233,  235,  236,  237,  240,  243,  245,
> -      247,  250,  253,  255,  257,  258,  261,  264,  266,  268,
> -      269,  270,  271,  272,  273,  276,  279,  281,  283,  284,
> -      285,  287,  288,  289,  290,  291,  292,  293,  296,  299,
> -      301,  303,  304,  305,  309,  312,  315,  317,  319,  320,
> -      321,  322,  325,  328,  330,  332,  333,  336,  339,  341,
> -
> -      343,  344,  345,  348,  351,  353,  355,  356,  357,  358,
> -      360,  361,  362,  363,  364,  365,  366,  367,  368,  369,
> -      371,  374,  377,  379,  381,  382,  383,  384,  387,  390,
> -      392,  394,  396,  397,  398,  399,  400,  401,  403,  405,
> -      406,  407,  408,  409,  410,  411,  412,  413,  414,  416,
> -      418,  419,  420,  423,  426,  428,  430,  431,  433,  434,
> -      436,  437,  441,  443,  444,  445,  447,  448,  450,  451,
> -      452,  453,  454,  455,  457,  458,  460,  462,  463,  464,
> -      466,  467,  468,  469,  471,  474,  477,  479,  481,  483,
> -      484,  485,  487,  488,  489,  490,  491,  492,  494,  495,
> -
> -      496,  497,  498,  500,  503,  506,  508,  510,  511,  512,
> -      513,  514,  516,  517,  519,  520,  521,  522,  523,  524,
> -      526,  527,  528,  529,  530,  532,  533,  535,  536,  538,
> -      539,  540,  542,  543,  545,  546,  548,  549,  551,  553,
> -      554,  556,  557,  558,  560,  561,  563,  564,  566,  568,
> -      570,  571,  573,  575,  575
> +      143,  144,  145,  146,  147,  148,  150,  152,  153,  154,
> +
> +      155,  156,  160,  161,  162,  164,  165,  166,  167,  168,
> +      169,  170,  171,  172,  177,  178,  179,  183,  184,  189,
> +      190,  191,  196,  197,  198,  199,  200,  201,  202,  205,
> +      208,  210,  212,  213,  215,  217,  218,  219,  220,  221,
> +      225,  226,  227,  228,  231,  234,  236,  238,  239,  240,
> +      243,  246,  248,  250,  253,  256,  258,  260,  261,  264,
> +      267,  269,  271,  272,  273,  274,  275,  276,  277,  280,
> +      283,  285,  287,  288,  289,  291,  292,  293,  294,  295,
> +      296,  297,  300,  303,  305,  307,  308,  309,  313,  316,
> +      319,  321,  323,  324,  325,  326,  329,  332,  334,  336,
> +
> +      337,  340,  343,  345,  347,  348,  349,  352,  355,  357,
> +      359,  360,  361,  362,  364,  365,  367,  368,  369,  370,
> +      371,  372,  373,  374,  375,  377,  380,  383,  385,  387,
> +      388,  389,  390,  393,  396,  398,  400,  402,  403,  404,
> +      405,  406,  407,  409,  411,  413,  414,  415,  416,  417,
> +      418,  419,  420,  421,  422,  424,  426,  427,  428,  431,
> +      434,  436,  438,  439,  441,  442,  444,  445,  449,  451,
> +      452,  453,  455,  456,  458,  459,  460,  461,  462,  463,
> +      465,  466,  468,  470,  471,  472,  474,  475,  476,  477,
> +      479,  482,  485,  487,  489,  491,  492,  493,  495,  496,
> +
> +      497,  498,  499,  500,  502,  503,  504,  505,  506,  508,
> +      511,  514,  516,  518,  519,  520,  521,  522,  524,  525,
> +      527,  528,  529,  530,  531,  532,  534,  535,  536,  537,
> +      538,  540,  541,  543,  544,  546,  547,  548,  550,  551,
> +      553,  554,  556,  557,  559,  561,  562,  564,  565,  566,
> +      568,  569,  571,  572,  574,  576,  578,  579,  581,  583,
> +      583
>      } ;
>=20
>  static const YY_CHAR yy_ec[256] =3D
> @@ -708,216 +710,217 @@ static const YY_CHAR yy_meta[35] =3D
>          1,    1,    1,    1
>      } ;
>=20
> -static const flex_int16_t yy_base[424] =3D
> +static const flex_int16_t yy_base[430] =3D
>      {   0,
> -        0,    0,  901,  900,  902,  897,   33,   36,  905,  905,
> -       45,   63,   31,   42,   51,   52,  890,   33,   65,   67,
> -       69,   70,  889,   71,  888,   75,    0,  905,  893,  905,
> -       91,   94,    0,    0,  103,  886,  112,    0,   89,   98,
> -      113,   92,  114,   99,  100,   48,  121,  116,  119,   74,
> -      124,  129,  123,  135,  132,  133,  137,  134,  138,  139,
> -      141,    0,  155,    0,    0,  164,    0,    0,  849,  142,
> -      152,  164,  140,  161,  165,  166,  167,  168,  169,  173,
> -      174,  178,  176,  180,  184,  208,  189,  183,  192,  195,
> -      215,  191,  193,  223,    0,    0,  905,  208,  204,  236,
> -
> -      219,  209,  238,  196,  237,  831,  242,  815,  241,  224,
> -      243,  261,  244,  259,  277,  266,  286,  250,  288,  298,
> -      249,  283,  274,  282,  294,  308,    0,  310,    0,  295,
> -      305,  905,  308,  306,  313,  314,  342,  319,  316,  320,
> -      331,    0,  349,    0,  342,  344,  356,    0,  358,    0,
> -      365,    0,  367,    0,  354,  375,    0,  377,    0,  363,
> -      356,  809,  327,  322,  384,    0,    0,    0,    0,  379,
> -      905,  382,  384,  386,  390,  372,  392,  403,    0,  410,
> -        0,  407,  413,  423,  426,    0,    0,    0,    0,  409,
> -      424,  435,    0,    0,    0,    0,  437,    0,    0,    0,
> -
> -        0,  433,  444,    0,    0,    0,    0,  391,  440,  781,
> -      905,  769,  439,  445,  444,  447,  449,  454,  453,  399,
> -      464,    0,    0,    0,    0,  757,  465,  476,    0,  478,
> -        0,  479,  476,  753,  462,  490,  749,  905,  745,  905,
> -      483,  737,  424,  485,  487,  490,  500,  493,  905,  729,
> -      905,  502,  518,    0,    0,    0,    0,  905,  498,  721,
> -      905,  527,  713,    0,  705,  905,  495,  697,  905,  365,
> -      521,  528,  530,  685,  905,  534,  540,  540,  657,  905,
> -      537,  542,  650,  905,  553,    0,  557,    0,    0,  551,
> -      641,  905,  558,  557,  633,  614,  613,  905,  547,  555,
> -
> -      563,  565,  569,  584,    0,    0,    0,    0,  583,  570,
> -      585,  612,  905,  601,  905,  522,  580,  589,  594,  905,
> -      600,  585,  563,  520,  905,  514,  905,  586,  486,  597,
> -      480,  441,  905,  416,  905,  345,  905,  334,  905,  601,
> -      254,  905,  242,  905,  200,  905,  151,  905,  905,  607,
> -       86,  905,  905,  905,  620,  624,  627,  631,  635,  639,
> -      643,  647,  651,  655,  659,  663,  667,  671,  675,  679,
> -      683,  687,  691,  695,  699,  703,  707,  711,  715,  719,
> -      723,  727,  731,  735,  739,  743,  747,  751,  755,  759,
> -      763,  767,  771,  775,  779,  783,  787,  791,  795,  799,
> -
> -      803,  807,  811,  815,  819,  823,  827,  831,  835,  839,
> -      843,  847,  851,  855,  859,  863,  867,  871,  875,  879,
> -      883,  887,  891
> +        0,    0,  912,  911,  913,  908,   33,   36,  916,  916,
> +       45,   63,   31,   42,   51,   52,  901,   33,   65,   67,
> +       69,   70,  900,   71,  899,   77,    0,  916,  904,  916,
> +       93,   96,    0,    0,  105,  897,  114,    0,   91,  100,
> +      115,   94,  116,  101,  102,   48,   74,  118,  121,  123,
> +       78,  128,  131,  137,  124,  125,  133,  135,  136,  140,
> +      142,  141,    0,  163,    0,    0,  166,    0,    0,  902,
> +      143,  146,  163,  164,  166,  167,  149,  169,  170,  175,
> +      179,  176,  182,  177,  184,  192,  212,  193,  186,  196,
> +      187,  219,  201,  150,  199,  227,    0,    0,  916,  209,
> +
> +      212,  243,  224,  213,  245,  223,  198,  895,  231,  894,
> +      244,  230,  243,  261,  255,  259,  279,  266,  288,  275,
> +      291,  301,  268,  284,  298,  301,  285,  302,  311,    0,
> +      314,    0,  311,  318,  916,  312,  317,  246,  232,  342,
> +      320,  325,  323,  349,    0,  351,    0,  344,  349,  360,
> +        0,  363,    0,  367,    0,  370,    0,  330,  377,    0,
> +      379,    0,  365,  358,  899,  368,  329,  331,  381,    0,
> +        0,    0,    0,  381,  916,  383,  385,  387,  391,  397,
> +      393,  409,    0,  411,    0,  412,  414,  424,  427,    0,
> +        0,    0,    0,  422,  425,  436,    0,    0,    0,    0,
> +
> +      438,    0,    0,    0,    0,  434,  445,    0,    0,    0,
> +        0,  440,  442,  898,  916,  400,  897,  443,  448,  449,
> +      451,  453,  458,  457,  413,  469,    0,    0,    0,    0,
> +      896,  469,  480,    0,  482,    0,  483,  480,  895,  489,
> +      497,  894,  916,  916,  851,  916,  490,  839,  478,  492,
> +      494,  497,  507,  501,  916,  823,  916,  509,  525,    0,
> +        0,    0,    0,  916,  505,  811,  916,  534,  783,    0,
> +      771,  916,  518,  759,  916,  523,  528,  538,  540,  755,
> +      916,  511,  540,  549,  751,  916,  544,  547,  747,  916,
> +      560,    0,  562,    0,    0,  555,  739,  916,  484,  561,
> +
> +      731,  723,  715,  916,  449,  566,  564,  566,  576,  578,
> +        0,    0,    0,    0,  584,  574,  586,  707,  916,  699,
> +      916,  581,  587,  590,  597,  916,  687,  659,  652,  643,
> +      916,  635,  916,  597,  616,  599,  614,  604,  916,  600,
> +      916,  541,  916,  467,  916,  603,  455,  916,  404,  916,
> +      385,  916,  328,  916,  916,  609,  203,  916,  916,  916,
> +      622,  626,  629,  633,  637,  641,  645,  649,  653,  657,
> +      661,  665,  669,  673,  677,  681,  685,  689,  693,  697,
> +      701,  705,  709,  713,  717,  721,  725,  729,  733,  737,
> +      741,  745,  749,  753,  757,  761,  765,  769,  773,  777,
> +
> +      781,  785,  789,  793,  797,  801,  805,  809,  813,  817,
> +      821,  825,  829,  833,  837,  841,  845,  849,  853,  857,
> +      861,  865,  869,  873,  877,  881,  885,  889,  893
>      } ;
>=20
> -static const flex_int16_t yy_def[424] =3D
> +static const flex_int16_t yy_def[430] =3D
>      {   0,
> -      354,    1,  355,  355,  354,  356,  357,  357,  354,  354,
> -      358,  358,   12,   12,   12,   12,   12,   12,   12,   12,
> -       12,   12,   12,   12,   12,   12,  359,  354,  356,  354,
> -      360,  357,  361,  361,  362,   12,  356,  363,   12,   12,
> +      360,    1,  361,  361,  360,  362,  363,  363,  360,  360,
> +      364,  364,   12,   12,   12,   12,   12,   12,   12,   12,
> +       12,   12,   12,   12,   12,   12,  365,  360,  362,  360,
> +      366,  363,  367,  367,  368,   12,  362,  369,   12,   12,
>         12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
>         12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
> -       12,  359,  360,  361,  361,  364,  365,  365,  354,   12,
> +       12,   12,  365,  366,  367,  367,  370,  371,  371,  360,
>         12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
> -       12,   12,   12,   12,   12,  362,   12,   12,   12,   12,
> -       12,   12,   12,  364,  365,  365,  354,   12,   12,  366,
> -
> -       12,   12,   12,   12,   12,   12,   12,   12,   12,   12,
> -       12,  367,   86,   86,  368,   12,  369,   12,   12,  370,
> -       12,   12,   12,   12,   12,  371,  372,  366,  372,   12,
> -       12,  354,   86,   12,   12,   12,  373,   12,   12,   12,
> -      374,  375,  367,  375,   86,   86,  376,  377,  368,  377,
> -      378,  379,  369,  379,   12,  380,  381,  370,  381,   12,
> -       12,  382,   12,   12,  371,  372,  372,  383,  383,   12,
> -      354,   86,   86,   86,   12,   12,   12,  384,  385,  373,
> -      385,   12,   12,  386,  374,  375,  375,  387,  387,   86,
> -       86,  376,  377,  377,  388,  388,  378,  379,  379,  389,
> -
> -      389,   12,  380,  381,  381,  390,  390,   12,   12,  391,
> -      354,  392,   86,   12,   86,   86,   86,   12,   86,   12,
> -      384,  385,  385,  393,  393,  394,   86,  395,  396,  386,
> -      396,   86,   86,  397,   12,  398,  391,  354,  399,  354,
> -       86,  400,   12,   86,   86,   86,  401,   86,  354,  402,
> -      354,   86,  395,  396,  396,  403,  403,  354,   86,  404,
> -      354,  405,  406,  406,  399,  354,   86,  407,  354,   12,
> -       86,   86,   86,  408,  354,  408,  408,   86,  402,  354,
> -       86,   86,  404,  354,  409,  410,  405,  410,  406,   86,
> -      407,  354,   12,   86,  411,  412,  408,  354,  408,  408,
> -
> -       86,   86,   86,  409,  410,  410,  413,  413,   86,   12,
> -       86,  414,  354,  415,  354,  408,  408,   86,   86,  354,
> -      416,  417,  418,  414,  354,  415,  354,  408,  408,   86,
> -      419,  420,  354,  421,  354,  422,  354,  408,  354,   86,
> -      423,  354,  420,  354,  421,  354,  422,  354,  354,   86,
> -      423,  354,  354,    0,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354
> +       12,   12,   12,   12,   12,   12,  368,   12,   12,   12,
> +       12,   12,   12,   12,   12,  370,  371,  371,  360,   12,
> +
> +       12,  372,   12,   12,   12,   12,   12,   12,   12,   12,
> +       12,   12,   12,  373,   87,   87,  374,   12,  375,   12,
> +       12,  376,   12,   12,   12,   12,   12,   12,  377,  378,
> +      372,  378,   12,   12,  360,   87,   12,   12,   12,  379,
> +       12,   12,   12,  380,  381,  373,  381,   87,   87,  382,
> +      383,  374,  383,  384,  385,  375,  385,   12,  386,  387,
> +      376,  387,   12,   12,  388,   12,   12,   12,  377,  378,
> +      378,  389,  389,   12,  360,   87,   87,   87,   12,   12,
> +       12,  390,  391,  379,  391,   12,   12,  392,  380,  381,
> +      381,  393,  393,   87,   87,  382,  383,  383,  394,  394,
> +
> +      384,  385,  385,  395,  395,   12,  386,  387,  387,  396,
> +      396,   12,   12,  397,  360,   12,  398,   87,   12,   87,
> +       87,   87,   12,   87,   12,  390,  391,  391,  399,  399,
> +      400,   87,  401,  402,  392,  402,   87,   87,  403,   12,
> +      404,  397,  360,  360,  405,  360,   87,  406,   12,   87,
> +       87,   87,  407,   87,  360,  408,  360,   87,  401,  402,
> +      402,  409,  409,  360,   87,  410,  360,  411,  412,  412,
> +      405,  360,   87,  413,  360,   12,   87,   87,   87,  414,
> +      360,  414,  414,   87,  408,  360,   87,   87,  410,  360,
> +      415,  416,  411,  416,  412,   87,  413,  360,   12,   87,
> +
> +      417,  418,  414,  360,  414,  414,   87,   87,   87,  415,
> +      416,  416,  419,  419,   87,   12,   87,  420,  360,  421,
> +      360,  414,  414,   87,   87,  360,  422,  423,  424,  420,
> +      360,  421,  360,  414,  414,   87,  425,  426,  360,  427,
> +      360,  428,  360,  414,  360,   87,  429,  360,  426,  360,
> +      427,  360,  428,  360,  360,   87,  429,  360,  360,    0,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360
>      } ;
>=20
> -static const flex_int16_t yy_nxt[940] =3D
> +static const flex_int16_t yy_nxt[951] =3D
>      {   0,
>          6,    7,    8,    9,    6,    6,    6,    6,   10,   11,
>         12,   13,   14,   15,   16,   17,   18,   19,   17,   17,
>         17,   17,   20,   17,   21,   22,   23,   24,   25,   17,
>         26,   17,   17,   17,   32,   32,   33,   32,   32,   33,
>         36,   34,   36,   42,   34,   29,   29,   29,   30,   35,
> -       50,   36,   37,   38,   43,   44,   39,   36,   79,   45,
> +       50,   36,   37,   38,   43,   44,   39,   36,   80,   45,
>         36,   36,   40,   29,   29,   29,   30,   35,   46,   48,
>         37,   38,   41,   47,   36,   49,   36,   53,   36,   36,
> -       36,   56,   58,   36,   36,   55,   82,   60,   51,  342,
> -       54,   61,   52,   29,   64,   32,   32,   33,   36,   65,
> -
> -       70,   36,   34,   29,   29,   29,   30,   36,   36,   36,
> -       29,   38,   66,   66,   66,   67,   66,   71,   74,   66,
> -       68,   72,   36,   36,   73,   36,   77,   78,   36,   76,
> -       36,   53,   36,   36,   75,   85,   80,   83,   36,   86,
> -       84,   36,   36,   36,   36,   81,   36,   36,   36,   36,
> -       36,   36,   93,   89,  337,   98,   88,   29,   64,  101,
> -       90,   36,   91,   65,   92,   87,   29,   95,   89,   99,
> -       36,  100,   96,   36,   36,   36,   36,   36,   36,  106,
> -      105,   85,   36,   36,  102,   36,  107,   36,  103,   36,
> -      109,  112,   36,   36,  104,  108,  115,  110,   36,  117,
> -
> -       36,   36,   36,  335,   36,   36,  122,  111,   29,   29,
> -       29,   30,  118,   36,  116,   29,   38,   36,   36,  113,
> -      114,  119,  120,  123,   36,   29,   95,  121,   36,  134,
> -      131,   96,  130,   36,  125,  124,  126,  126,   66,  127,
> -      126,  132,  133,  126,  129,  333,   36,   36,  135,  137,
> -       36,   36,   36,  140,  139,   35,   35,  352,   36,   36,
> -       85,  141,  141,   66,  142,  141,  160,  145,  141,  144,
> -       35,   35,   89,  117,  155,   36,  146,  147,  147,   66,
> -      148,  147,  162,   36,  147,  150,  151,  151,   66,  152,
> -      151,   36,   36,  151,  154,  120,  161,   36,  156,  156,
> -
> -       66,  157,  156,   36,   36,  156,  159,  164,  171,  163,
> -       29,  166,   29,  168,   36,   36,  167,  170,  169,   35,
> -       35,  172,   36,   36,  173,   36,  213,  184,   36,   36,
> -      175,   36,  174,   29,  186,  212,   36,  349,  183,  187,
> -      177,  176,  178,  178,   66,  179,  178,  182,  348,  178,
> -      181,   29,  188,   35,   35,   35,   35,  189,   29,  193,
> -       29,  195,  190,   36,  194,   36,  196,   29,  198,   29,
> -      200,  191,   36,  199,   36,  201,  219,   29,  204,   29,
> -      206,   36,  202,  205,  209,  207,   29,  166,   36,  293,
> -      208,  214,  167,   35,   35,   35,   35,   35,   35,   36,
> -
> -       36,   36,  249,  218,  220,   29,  222,  216,   36,  217,
> -      235,  223,   29,  224,  215,  226,   36,  227,  225,  346,
> -       35,   35,   36,  228,  228,   66,  229,  228,   29,  186,
> -      228,  231,  232,   36,  187,  233,   35,   29,  193,   29,
> -      198,  234,   36,  194,  344,  199,   29,  204,  236,   36,
> -       35,  241,  205,  242,   36,   35,   35,  270,   35,   35,
> -       35,   35,  247,   36,   35,   35,   29,  222,  244,  262,
> -      248,   36,  223,  243,  245,  246,   35,  252,   29,  254,
> -       29,  256,  258,  342,  255,  259,  257,   35,   35,  339,
> -       35,   35,   69,  264,   35,   35,   35,   35,   35,   35,
> -
> -      267,   35,   35,  275,   35,   35,   35,   35,  271,   35,
> -       35,  276,  277,   35,   35,  272,  278,  315,  273,  281,
> -       29,  254,  290,  313,  282,  275,  255,  285,  285,   66,
> -      286,  285,   35,   35,  285,  288,  295,  298,  296,   35,
> -       35,   35,   35,  298,  301,  328,  299,  294,   35,   35,
> -      275,   35,   35,   35,  303,   29,  305,  300,  275,   29,
> -      307,  306,   35,   35,  302,  308,  337,   36,   35,   35,
> -      309,  310,  320,  316,   35,   35,   35,   35,  322,   36,
> -       35,   35,  317,  275,  319,  311,   29,  305,  335,  275,
> -      318,  321,  306,  323,   35,   35,   35,   35,  330,  329,
> -
> -       35,   35,  331,  333,  327,   35,   35,  338,   35,   35,
> -      353,  340,   35,   35,  350,  325,  275,  315,   35,   35,
> -       27,   27,   27,   27,   29,   29,   29,   31,   31,   31,
> -       31,   36,   36,   36,   36,   62,  313,   62,   62,   63,
> -       63,   63,   63,   65,  269,   65,   65,   35,   35,   35,
> -       35,   69,   69,  261,   69,   94,   94,   94,   94,   96,
> -      251,   96,   96,  128,  128,  128,  128,  143,  143,  143,
> -      143,  149,  149,  149,  149,  153,  153,  153,  153,  158,
> -      158,  158,  158,  165,  165,  165,  165,  167,  298,  167,
> -      167,  180,  180,  180,  180,  185,  185,  185,  185,  187,
> -
> -      292,  187,  187,  192,  192,  192,  192,  194,  240,  194,
> -      194,  197,  197,  197,  197,  199,  289,  199,  199,  203,
> -      203,  203,  203,  205,  284,  205,  205,  210,  210,  210,
> -      210,  169,  280,  169,  169,  221,  221,  221,  221,  223,
> -      269,  223,  223,  230,  230,  230,  230,  189,  266,  189,
> -      189,  196,  211,  196,  196,  201,  261,  201,  201,  207,
> -      251,  207,  207,  237,  237,  237,  237,  239,  239,  239,
> -      239,  225,  240,  225,  225,  250,  250,  250,  250,  253,
> -      253,  253,  253,  255,  238,  255,  255,  260,  260,  260,
> -      260,  263,  263,  263,  263,  265,  265,  265,  265,  268,
> -
> -      268,  268,  268,  274,  274,  274,  274,  279,  279,  279,
> -      279,  257,  211,  257,  257,  283,  283,  283,  283,  287,
> -      287,  287,  287,  264,  138,  264,  264,  291,  291,  291,
> -      291,  297,  297,  297,  297,  304,  304,  304,  304,  306,
> -      136,  306,  306,  312,  312,  312,  312,  314,  314,  314,
> -      314,  308,   97,  308,  308,  324,  324,  324,  324,  326,
> -      326,  326,  326,  332,  332,  332,  332,  334,  334,  334,
> -      334,  336,  336,  336,  336,  341,  341,  341,  341,  343,
> -      343,  343,  343,  345,  345,  345,  345,  347,  347,  347,
> -      347,  351,  351,  351,  351,   36,   30,   59,   57,   36,
> -
> -       30,  354,   28,   28,    5,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354
> +       36,   56,   58,   36,   53,   55,   36,   36,   51,   60,
> +       54,   84,   52,   61,   62,   29,   65,   32,   32,   33,
> +
> +       36,   66,   71,   36,   34,   29,   29,   29,   30,   36,
> +       36,   36,   29,   38,   67,   67,   67,   68,   67,   72,
> +       75,   67,   69,   73,   36,   36,   74,   36,   78,   79,
> +       36,   77,   36,   36,   36,   83,   76,   36,   81,   85,
> +       36,   87,   36,   86,   36,   36,   36,   82,   89,   36,
> +       36,   36,   36,   94,   90,   36,  100,   88,   36,   36,
> +       92,   91,   93,  101,   90,   29,   65,   95,   29,   97,
> +      102,   66,   36,   36,   98,   36,   36,  106,   36,   36,
> +      125,  108,  107,  103,   36,   36,   36,   86,   36,  104,
> +      105,   36,  109,   36,  111,   36,   36,  110,  112,  114,
> +
> +      117,   36,   36,  119,  120,   36,  348,   36,   36,  138,
> +       36,  113,   29,   29,   29,   30,  124,  118,   36,   29,
> +       38,   36,   36,  115,  116,  121,  122,  126,   36,   29,
> +       97,  123,   36,   36,  134,   98,  127,  133,  140,   36,
> +       36,   36,  128,  129,  129,   67,  130,  129,  135,  136,
> +      129,  132,   36,   36,   36,   36,  137,  142,  181,  143,
> +       86,  144,  144,   67,  145,  144,   35,   35,  144,  147,
> +       35,   35,   90,  119,  180,   36,  149,   36,  148,  150,
> +      150,   67,  151,  150,   36,  163,  150,  153,  154,  154,
> +       67,  155,  154,   36,   36,  154,  157,  164,  122,  158,
> +
> +       36,  159,  159,   67,  160,  159,  165,   36,  159,  162,
> +       36,   36,  167,   29,  170,  168,   29,  172,  166,  171,
> +       36,  175,  173,   35,   35,  176,   36,   36,  177,   36,
> +      188,  343,   36,  174,   36,  218,  178,  217,   36,   36,
> +       36,  179,  182,  182,   67,  183,  182,  187,  186,  182,
> +      185,   29,  190,   29,  192,   35,   35,  191,  206,  193,
> +       35,   35,   29,  197,  194,   29,  199,   36,  198,   29,
> +      202,  200,   29,  204,   36,  203,  195,   36,  205,   29,
> +      208,   29,  210,   29,  170,  209,  213,  211,  341,  171,
> +       36,  216,  212,  219,   35,   35,   35,   35,   35,   35,
> +
> +       36,  224,   36,  244,  223,  225,   36,  339,  221,   36,
> +      222,   29,  227,   29,  229,  220,  255,  228,  232,  230,
> +      231,   36,   36,   36,  233,  233,   67,  234,  233,   29,
> +      190,  233,  236,   35,   35,  191,  238,   35,   29,  197,
> +       29,  202,  239,   36,  198,  237,  203,   29,  208,   36,
> +      241,   36,  281,  209,   35,  247,  248,   36,  358,  240,
> +       35,   35,   35,   35,   35,   35,  253,   36,   35,   35,
> +      355,   29,  227,  250,  254,  322,  249,  228,  251,  252,
> +       35,  258,   29,  260,   29,  262,  264,   36,  261,  265,
> +      263,   35,   35,   36,   35,   35,  268,  316,   36,   70,
> +
> +      270,   35,   35,   35,   35,   35,   35,  273,   35,   35,
> +      281,  276,   35,   35,  304,  277,   35,   35,  282,  283,
> +       35,   35,  278,  305,  284,  279,  287,   29,  260,   35,
> +       35,  288,   36,  261,  291,  291,   67,  292,  291,   35,
> +       35,  291,  294,  304,  354,  296,  301,  299,  302,   35,
> +       35,   35,   35,  307,  300,   35,   35,  306,   35,  309,
> +       35,   35,   29,  311,   29,  313,   35,   35,  312,  281,
> +      314,  308,   35,   35,  315,   35,   35,   35,   35,  326,
> +       29,  311,  328,   36,  281,  325,  312,   35,   35,  317,
> +      281,  324,  327,  323,  329,   35,   35,   35,   35,  336,
> +
> +      281,   35,   35,  352,  334,  337,  335,  350,   35,   35,
> +       35,   35,  359,  346,   35,   35,  356,  348,  344,  345,
> +       35,   35,   27,   27,   27,   27,   29,   29,   29,   31,
> +       31,   31,   31,   36,   36,   36,   36,   63,  321,   63,
> +       63,   64,   64,   64,   64,   66,  319,   66,   66,   35,
> +       35,   35,   35,   70,   70,  343,   70,   96,   96,   96,
> +       96,   98,  341,   98,   98,  131,  131,  131,  131,  146,
> +      146,  146,  146,  152,  152,  152,  152,  156,  156,  156,
> +      156,  161,  161,  161,  161,  169,  169,  169,  169,  171,
> +      339,  171,  171,  184,  184,  184,  184,  189,  189,  189,
> +
> +      189,  191,  333,  191,  191,  196,  196,  196,  196,  198,
> +      331,  198,  198,  201,  201,  201,  201,  203,  281,  203,
> +      203,  207,  207,  207,  207,  209,  321,  209,  209,  214,
> +      214,  214,  214,  173,  319,  173,  173,  226,  226,  226,
> +      226,  228,  275,  228,  228,  235,  235,  235,  235,  193,
> +      267,  193,  193,  200,  257,  200,  200,  205,  304,  205,
> +      205,  211,  298,  211,  211,  242,  242,  242,  242,  245,
> +      245,  245,  245,  230,  246,  230,  230,  256,  256,  256,
> +      256,  259,  259,  259,  259,  261,  295,  261,  261,  266,
> +      266,  266,  266,  269,  269,  269,  269,  271,  271,  271,
> +
> +      271,  274,  274,  274,  274,  280,  280,  280,  280,  285,
> +      285,  285,  285,  263,  290,  263,  263,  289,  289,  289,
> +      289,  293,  293,  293,  293,  270,  286,  270,  270,  297,
> +      297,  297,  297,  303,  303,  303,  303,  310,  310,  310,
> +      310,  312,  275,  312,  312,  318,  318,  318,  318,  320,
> +      320,  320,  320,  314,  272,  314,  314,  330,  330,  330,
> +      330,  332,  332,  332,  332,  338,  338,  338,  338,  340,
> +      340,  340,  340,  342,  342,  342,  342,  347,  347,  347,
> +      347,  349,  349,  349,  349,  351,  351,  351,  351,  353,
> +      353,  353,  353,  357,  357,  357,  357,  215,  267,  257,
> +
> +      246,  243,  215,  141,  139,   99,   36,   30,   59,   57,
> +       36,   30,  360,   28,   28,    5,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360
>      } ;
>=20
> -static const flex_int16_t yy_chk[940] =3D
> +static const flex_int16_t yy_chk[951] =3D
>      {   0,
>          1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
>          1,    1,    1,    1,    1,    1,    1,    1,    1,    1,
> @@ -927,101 +930,102 @@ static const flex_int16_t yy_chk[940] =3D
>         18,   14,   11,   11,   13,   14,   11,   46,   46,   14,
>         15,   16,   11,   12,   12,   12,   12,   12,   14,   16,
>         12,   12,   12,   15,   19,   16,   20,   20,   21,   22,
> -       24,   22,   24,   50,   26,   21,   50,   26,   19,  351,
> -       20,   26,   19,   31,   31,   32,   32,   32,   39,   31,
> -
> -       39,   42,   32,   35,   35,   35,   35,   40,   44,   45,
> -       35,   35,   37,   37,   37,   37,   37,   39,   42,   37,
> -       37,   40,   41,   43,   41,   48,   45,   45,   49,   44,
> -       47,   47,   53,   51,   43,   53,   48,   51,   52,   54,
> -       52,   55,   56,   58,   54,   49,   57,   59,   60,   73,
> -       61,   70,   60,   61,  347,   70,   56,   63,   63,   73,
> -       58,   71,   59,   63,   59,   55,   66,   66,   57,   71,
> -       74,   72,   66,   72,   75,   76,   77,   78,   79,   78,
> -       77,   79,   80,   81,   74,   83,   80,   82,   75,   84,
> -       82,   85,   88,   85,   76,   81,   87,   83,   87,   89,
> -
> -       92,   89,   93,  345,   90,  104,   92,   84,   86,   86,
> -       86,   86,   90,   99,   88,   86,   86,   98,  102,   86,
> -       86,   91,   91,   93,   91,   94,   94,   91,  101,  104,
> -      102,   94,  101,  110,   99,   98,  100,  100,  100,  100,
> -      100,  103,  103,  100,  100,  343,  105,  103,  105,  107,
> -      109,  107,  111,  110,  109,  113,  113,  341,  121,  118,
> -      111,  112,  112,  112,  112,  112,  121,  113,  112,  112,
> -      114,  114,  116,  116,  118,  116,  114,  115,  115,  115,
> -      115,  115,  123,  123,  115,  115,  117,  117,  117,  117,
> -      117,  124,  122,  117,  117,  119,  122,  119,  120,  120,
> -
> -      120,  120,  120,  125,  130,  120,  120,  125,  131,  124,
> -      126,  126,  128,  128,  131,  134,  126,  130,  128,  133,
> -      133,  133,  135,  136,  133,  139,  164,  140,  138,  140,
> -      134,  164,  133,  141,  141,  163,  163,  338,  139,  141,
> -      136,  135,  137,  137,  137,  137,  137,  138,  336,  137,
> -      137,  143,  143,  145,  145,  146,  146,  143,  147,  147,
> -      149,  149,  145,  155,  147,  161,  149,  151,  151,  153,
> -      153,  146,  160,  151,  270,  153,  176,  156,  156,  158,
> -      158,  176,  155,  156,  161,  158,  165,  165,  170,  270,
> -      160,  170,  165,  172,  172,  173,  173,  174,  174,  175,
> -
> -      208,  177,  220,  175,  177,  178,  178,  173,  220,  174,
> -      208,  178,  180,  180,  172,  182,  182,  183,  180,  334,
> -      190,  190,  183,  184,  184,  184,  184,  184,  185,  185,
> -      184,  184,  190,  243,  185,  191,  191,  192,  192,  197,
> -      197,  202,  202,  192,  332,  197,  203,  203,  209,  209,
> -      213,  213,  203,  214,  214,  215,  215,  243,  216,  216,
> -      217,  217,  218,  218,  219,  219,  221,  221,  215,  235,
> -      219,  235,  221,  214,  216,  217,  227,  227,  228,  228,
> -      230,  230,  232,  331,  228,  233,  230,  233,  233,  329,
> -      232,  232,  236,  236,  241,  241,  244,  244,  245,  245,
> -
> -      241,  246,  246,  247,  248,  248,  267,  267,  244,  259,
> -      259,  247,  247,  252,  252,  245,  248,  326,  246,  252,
> -      253,  253,  267,  324,  259,  316,  253,  262,  262,  262,
> -      262,  262,  271,  271,  262,  262,  272,  276,  273,  272,
> -      272,  273,  273,  277,  278,  316,  276,  271,  281,  281,
> -      299,  278,  278,  282,  282,  285,  285,  277,  300,  287,
> -      287,  285,  290,  290,  281,  287,  323,  293,  294,  294,
> -      290,  293,  303,  299,  301,  301,  302,  302,  310,  310,
> -      303,  303,  300,  317,  302,  294,  304,  304,  322,  328,
> -      301,  309,  304,  311,  309,  309,  311,  311,  318,  317,
> -
> -      318,  318,  319,  321,  314,  319,  319,  328,  330,  330,
> -      350,  330,  340,  340,  340,  312,  297,  296,  350,  350,
> -      355,  355,  355,  355,  356,  356,  356,  357,  357,  357,
> -      357,  358,  358,  358,  358,  359,  295,  359,  359,  360,
> -      360,  360,  360,  361,  291,  361,  361,  362,  362,  362,
> -      362,  363,  363,  283,  363,  364,  364,  364,  364,  365,
> -      279,  365,  365,  366,  366,  366,  366,  367,  367,  367,
> -      367,  368,  368,  368,  368,  369,  369,  369,  369,  370,
> -      370,  370,  370,  371,  371,  371,  371,  372,  274,  372,
> -      372,  373,  373,  373,  373,  374,  374,  374,  374,  375,
> -
> -      268,  375,  375,  376,  376,  376,  376,  377,  265,  377,
> -      377,  378,  378,  378,  378,  379,  263,  379,  379,  380,
> -      380,  380,  380,  381,  260,  381,  381,  382,  382,  382,
> -      382,  383,  250,  383,  383,  384,  384,  384,  384,  385,
> -      242,  385,  385,  386,  386,  386,  386,  387,  239,  387,
> -      387,  388,  237,  388,  388,  389,  234,  389,  389,  390,
> -      226,  390,  390,  391,  391,  391,  391,  392,  392,  392,
> -      392,  393,  212,  393,  393,  394,  394,  394,  394,  395,
> -      395,  395,  395,  396,  210,  396,  396,  397,  397,  397,
> -      397,  398,  398,  398,  398,  399,  399,  399,  399,  400,
> -
> -      400,  400,  400,  401,  401,  401,  401,  402,  402,  402,
> -      402,  403,  162,  403,  403,  404,  404,  404,  404,  405,
> -      405,  405,  405,  406,  108,  406,  406,  407,  407,  407,
> -      407,  408,  408,  408,  408,  409,  409,  409,  409,  410,
> -      106,  410,  410,  411,  411,  411,  411,  412,  412,  412,
> -      412,  413,   69,  413,  413,  414,  414,  414,  414,  415,
> -      415,  415,  415,  416,  416,  416,  416,  417,  417,  417,
> -      417,  418,  418,  418,  418,  419,  419,  419,  419,  420,
> -      420,  420,  420,  421,  421,  421,  421,  422,  422,  422,
> -      422,  423,  423,  423,  423,   36,   29,   25,   23,   17,
> -
> -        6,    5,    4,    3,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354,  354,
> -      354,  354,  354,  354,  354,  354,  354,  354,  354
> +       24,   22,   24,   47,   47,   21,   26,   51,   19,   26,
> +       20,   51,   19,   26,   26,   31,   31,   32,   32,   32,
> +
> +       39,   31,   39,   42,   32,   35,   35,   35,   35,   40,
> +       44,   45,   35,   35,   37,   37,   37,   37,   37,   39,
> +       42,   37,   37,   40,   41,   43,   41,   48,   45,   45,
> +       49,   44,   50,   55,   56,   50,   43,   52,   48,   52,
> +       53,   54,   57,   53,   58,   59,   54,   49,   56,   60,
> +       62,   61,   71,   60,   61,   72,   71,   55,   77,   94,
> +       59,   58,   59,   72,   57,   64,   64,   62,   67,   67,
> +       73,   64,   73,   74,   67,   75,   76,   77,   78,   79,
> +       94,   79,   78,   74,   80,   82,   84,   80,   81,   75,
> +       76,   83,   81,   85,   83,   89,   91,   82,   84,   86,
> +
> +       88,   86,   88,   90,   91,   90,  357,  107,   95,  107,
> +       93,   85,   87,   87,   87,   87,   93,   89,  100,   87,
> +       87,  101,  104,   87,   87,   92,   92,   95,   92,   96,
> +       96,   92,  106,  103,  104,   96,  100,  103,  109,  112,
> +      109,  139,  101,  102,  102,  102,  102,  102,  105,  105,
> +      102,  102,  113,  111,  105,  138,  106,  111,  139,  112,
> +      113,  114,  114,  114,  114,  114,  115,  115,  114,  114,
> +      116,  116,  118,  118,  138,  118,  116,  123,  115,  117,
> +      117,  117,  117,  117,  120,  123,  117,  117,  119,  119,
> +      119,  119,  119,  124,  127,  119,  119,  124,  121,  120,
> +
> +      121,  122,  122,  122,  122,  122,  125,  125,  122,  122,
> +      126,  128,  127,  129,  129,  128,  131,  131,  126,  129,
> +      133,  134,  131,  136,  136,  136,  137,  134,  136,  141,
> +      143,  353,  143,  133,  142,  168,  136,  167,  167,  158,
> +      168,  137,  140,  140,  140,  140,  140,  142,  141,  140,
> +      140,  144,  144,  146,  146,  148,  148,  144,  158,  146,
> +      149,  149,  150,  150,  148,  152,  152,  164,  150,  154,
> +      154,  152,  156,  156,  163,  154,  149,  166,  156,  159,
> +      159,  161,  161,  169,  169,  159,  164,  161,  351,  169,
> +      174,  166,  163,  174,  176,  176,  177,  177,  178,  178,
> +
> +      179,  180,  181,  216,  179,  181,  180,  349,  177,  216,
> +      178,  182,  182,  184,  184,  176,  225,  182,  187,  184,
> +      186,  186,  225,  187,  188,  188,  188,  188,  188,  189,
> +      189,  188,  188,  194,  194,  189,  195,  195,  196,  196,
> +      201,  201,  206,  206,  196,  194,  201,  207,  207,  212,
> +      213,  213,  305,  207,  218,  218,  219,  219,  347,  212,
> +      220,  220,  221,  221,  222,  222,  223,  223,  224,  224,
> +      344,  226,  226,  220,  224,  305,  219,  226,  221,  222,
> +      232,  232,  233,  233,  235,  235,  237,  249,  233,  238,
> +      235,  238,  238,  299,  237,  237,  240,  299,  240,  241,
> +
> +      241,  247,  247,  250,  250,  251,  251,  247,  252,  252,
> +      253,  249,  254,  254,  282,  250,  265,  265,  253,  253,
> +      258,  258,  251,  282,  254,  252,  258,  259,  259,  273,
> +      273,  265,  276,  259,  268,  268,  268,  268,  268,  277,
> +      277,  268,  268,  283,  342,  273,  278,  276,  279,  278,
> +      278,  279,  279,  284,  277,  287,  287,  283,  288,  288,
> +      284,  284,  291,  291,  293,  293,  296,  296,  291,  306,
> +      293,  287,  300,  300,  296,  307,  307,  308,  308,  309,
> +      310,  310,  316,  316,  322,  308,  310,  309,  309,  300,
> +      323,  307,  315,  306,  317,  315,  315,  317,  317,  324,
> +
> +      334,  324,  324,  340,  322,  325,  323,  338,  325,  325,
> +      336,  336,  356,  336,  346,  346,  346,  337,  334,  335,
> +      356,  356,  361,  361,  361,  361,  362,  362,  362,  363,
> +      363,  363,  363,  364,  364,  364,  364,  365,  332,  365,
> +      365,  366,  366,  366,  366,  367,  330,  367,  367,  368,
> +      368,  368,  368,  369,  369,  329,  369,  370,  370,  370,
> +      370,  371,  328,  371,  371,  372,  372,  372,  372,  373,
> +      373,  373,  373,  374,  374,  374,  374,  375,  375,  375,
> +      375,  376,  376,  376,  376,  377,  377,  377,  377,  378,
> +      327,  378,  378,  379,  379,  379,  379,  380,  380,  380,
> +
> +      380,  381,  320,  381,  381,  382,  382,  382,  382,  383,
> +      318,  383,  383,  384,  384,  384,  384,  385,  303,  385,
> +      385,  386,  386,  386,  386,  387,  302,  387,  387,  388,
> +      388,  388,  388,  389,  301,  389,  389,  390,  390,  390,
> +      390,  391,  297,  391,  391,  392,  392,  392,  392,  393,
> +      289,  393,  393,  394,  285,  394,  394,  395,  280,  395,
> +      395,  396,  274,  396,  396,  397,  397,  397,  397,  398,
> +      398,  398,  398,  399,  271,  399,  399,  400,  400,  400,
> +      400,  401,  401,  401,  401,  402,  269,  402,  402,  403,
> +      403,  403,  403,  404,  404,  404,  404,  405,  405,  405,
> +
> +      405,  406,  406,  406,  406,  407,  407,  407,  407,  408,
> +      408,  408,  408,  409,  266,  409,  409,  410,  410,  410,
> +      410,  411,  411,  411,  411,  412,  256,  412,  412,  413,
> +      413,  413,  413,  414,  414,  414,  414,  415,  415,  415,
> +      415,  416,  248,  416,  416,  417,  417,  417,  417,  418,
> +      418,  418,  418,  419,  245,  419,  419,  420,  420,  420,
> +      420,  421,  421,  421,  421,  422,  422,  422,  422,  423,
> +      423,  423,  423,  424,  424,  424,  424,  425,  425,  425,
> +      425,  426,  426,  426,  426,  427,  427,  427,  427,  428,
> +      428,  428,  428,  429,  429,  429,  429,  242,  239,  231,
> +
> +      217,  214,  165,  110,  108,   70,   36,   29,   25,   23,
> +       17,    6,    5,    4,    3,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360,
> +      360,  360,  360,  360,  360,  360,  360,  360,  360,  360
>      } ;
>=20
>  #define YY_TRAILING_MASK 0x2000
> @@ -1199,9 +1203,9 @@ static int vdev_and_devtype(DiskParseContext
> *dpc, char *str) {
>  #undef DPC /* needs to be defined differently the actual lexer */
>  #define DPC ((DiskParseContext*)yyextra)
>=20
> -#line 1202 "libxlu_disk_l.c"
> +#line 1206 "libxlu_disk_l.c"
>=20
> -#line 1204 "libxlu_disk_l.c"
> +#line 1208 "libxlu_disk_l.c"
>=20
>  #define INITIAL 0
>  #define LEXERR 1
> @@ -1483,7 +1487,7 @@ YY_DECL
>  #line 180 "libxlu_disk_l.l"
>   /*----- the scanner rules which do the parsing -----*/
>=20
> -#line 1486 "libxlu_disk_l.c"
> +#line 1490 "libxlu_disk_l.c"
>=20
>  	while ( /*CONSTCOND*/1 )		/* loops until end-of-file is
> reached */
>  		{
> @@ -1515,14 +1519,14 @@ yy_match:
>  			while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D
> yy_current_state )
>  				{
>  				yy_current_state =3D (int)
> yy_def[yy_current_state];
> -				if ( yy_current_state >=3D 355 )
> +				if ( yy_current_state >=3D 361 )
>  					yy_c =3D yy_meta[yy_c];
>  				}
>  			yy_current_state =3D yy_nxt[yy_base[yy_current_state]
> + yy_c];
>  			*yyg->yy_state_ptr++ =3D yy_current_state;
>  			++yy_cp;
>  			}
> -		while ( yy_current_state !=3D 354 );
> +		while ( yy_current_state !=3D 360 );
>=20
>  yy_find_action:
>  		yy_current_state =3D *--yyg->yy_state_ptr;
> @@ -1648,76 +1652,81 @@ YY_RULE_SETUP
>  #line 201 "libxlu_disk_l.l"
>  { libxl_defbool_set(&DPC->disk->discard_enable, false); }
>  	YY_BREAK
> -/* Note that the COLO configuration settings should be considered unstab=
le.
> -  * They may change incompatibly in future versions of Xen. */
>  case 15:
>  YY_RULE_SETUP
> -#line 204 "libxlu_disk_l.l"
> -{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
> +#line 202 "libxlu_disk_l.l"
> +{ DPC->disk->virtio =3D 1; }
>  	YY_BREAK
> +/* Note that the COLO configuration settings should be considered unstab=
le.
> +  * They may change incompatibly in future versions of Xen. */
>  case 16:
>  YY_RULE_SETUP
>  #line 205 "libxlu_disk_l.l"
> -{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
> +{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
>  	YY_BREAK
>  case 17:
> -/* rule 17 can match eol */
>  YY_RULE_SETUP
>  #line 206 "libxlu_disk_l.l"
> -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
> +{ libxl_defbool_set(&DPC->disk->colo_enable, false); }
>  	YY_BREAK
>  case 18:
>  /* rule 18 can match eol */
>  YY_RULE_SETUP
>  #line 207 "libxlu_disk_l.l"
> -{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
> +{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); }
>  	YY_BREAK
>  case 19:
>  /* rule 19 can match eol */
>  YY_RULE_SETUP
>  #line 208 "libxlu_disk_l.l"
> -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
> +{ STRIP(','); setcoloport(DPC, FROMEQUALS); }
>  	YY_BREAK
>  case 20:
>  /* rule 20 can match eol */
>  YY_RULE_SETUP
>  #line 209 "libxlu_disk_l.l"
> -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
> +{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
>  	YY_BREAK
>  case 21:
>  /* rule 21 can match eol */
>  YY_RULE_SETUP
>  #line 210 "libxlu_disk_l.l"
> +{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
> +	YY_BREAK
> +case 22:
> +/* rule 22 can match eol */
> +YY_RULE_SETUP
> +#line 211 "libxlu_disk_l.l"
>  { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); }
>  	YY_BREAK
>  /* the target magic parameter, eats the rest of the string */
> -case 22:
> +case 23:
>  YY_RULE_SETUP
> -#line 214 "libxlu_disk_l.l"
> +#line 215 "libxlu_disk_l.l"
>  { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); }
>  	YY_BREAK
>  /* unknown parameters */
> -case 23:
> -/* rule 23 can match eol */
> +case 24:
> +/* rule 24 can match eol */
>  YY_RULE_SETUP
> -#line 218 "libxlu_disk_l.l"
> +#line 219 "libxlu_disk_l.l"
>  { xlu__disk_err(DPC,yytext,"unknown parameter"); }
>  	YY_BREAK
>  /* deprecated prefixes */
>  /* the "/.*" in these patterns ensures that they count as if they
>     * matched the whole string, so these patterns take precedence */
> -case 24:
> +case 25:
>  YY_RULE_SETUP
> -#line 225 "libxlu_disk_l.l"
> +#line 226 "libxlu_disk_l.l"
>  {
>                      STRIP(':');
>                      DPC->had_depr_prefix=3D1; DEPRECATE("use `[format=3D=
]...,'");
>                      setformat(DPC, yytext);
>                   }
>  	YY_BREAK
> -case 25:
> +case 26:
>  YY_RULE_SETUP
> -#line 231 "libxlu_disk_l.l"
> +#line 232 "libxlu_disk_l.l"
>  {
>                      char *newscript;
>                      STRIP(':');
> @@ -1731,30 +1740,22 @@ YY_RULE_SETUP
>                      free(newscript);
>                  }
>  	YY_BREAK
> -case 26:
> +case 27:
>  *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
>  yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 8;
>  YY_DO_BEFORE_ACTION; /* set up yytext again */
>  YY_RULE_SETUP
> -#line 244 "libxlu_disk_l.l"
> -{ DPC->had_depr_prefix=3D1; DEPRECATE(0); }
> -	YY_BREAK
> -case 27:
> -YY_RULE_SETUP
>  #line 245 "libxlu_disk_l.l"
>  { DPC->had_depr_prefix=3D1; DEPRECATE(0); }
>  	YY_BREAK
>  case 28:
> -*yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
> -yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4;
> -YY_DO_BEFORE_ACTION; /* set up yytext again */
>  YY_RULE_SETUP
>  #line 246 "libxlu_disk_l.l"
>  { DPC->had_depr_prefix=3D1; DEPRECATE(0); }
>  	YY_BREAK
>  case 29:
>  *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
> -yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 6;
> +yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4;
>  YY_DO_BEFORE_ACTION; /* set up yytext again */
>  YY_RULE_SETUP
>  #line 247 "libxlu_disk_l.l"
> @@ -1762,7 +1763,7 @@ YY_RULE_SETUP
>  	YY_BREAK
>  case 30:
>  *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
> -yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 5;
> +yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 6;
>  YY_DO_BEFORE_ACTION; /* set up yytext again */
>  YY_RULE_SETUP
>  #line 248 "libxlu_disk_l.l"
> @@ -1770,26 +1771,34 @@ YY_RULE_SETUP
>  	YY_BREAK
>  case 31:
>  *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
> -yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4;
> +yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 5;
>  YY_DO_BEFORE_ACTION; /* set up yytext again */
>  YY_RULE_SETUP
>  #line 249 "libxlu_disk_l.l"
>  { DPC->had_depr_prefix=3D1; DEPRECATE(0); }
>  	YY_BREAK
>  case 32:
> -/* rule 32 can match eol */
> +*yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */
> +yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4;
> +YY_DO_BEFORE_ACTION; /* set up yytext again */
> +YY_RULE_SETUP
> +#line 250 "libxlu_disk_l.l"
> +{ DPC->had_depr_prefix=3D1; DEPRECATE(0); }
> +	YY_BREAK
> +case 33:
> +/* rule 33 can match eol */
>  YY_RULE_SETUP
> -#line 251 "libxlu_disk_l.l"
> +#line 252 "libxlu_disk_l.l"
>  {
>  		  xlu__disk_err(DPC,yytext,"unknown deprecated disk
> prefix");
>  		  return 0;
>  		}
>  	YY_BREAK
>  /* positional parameters */
> -case 33:
> -/* rule 33 can match eol */
> +case 34:
> +/* rule 34 can match eol */
>  YY_RULE_SETUP
> -#line 258 "libxlu_disk_l.l"
> +#line 259 "libxlu_disk_l.l"
>  {
>      STRIP(',');
>=20
> @@ -1816,27 +1825,27 @@ YY_RULE_SETUP
>      }
>  }
>  	YY_BREAK
> -case 34:
> +case 35:
>  YY_RULE_SETUP
> -#line 284 "libxlu_disk_l.l"
> +#line 285 "libxlu_disk_l.l"
>  {
>      BEGIN(LEXERR);
>      yymore();
>  }
>  	YY_BREAK
> -case 35:
> +case 36:
>  YY_RULE_SETUP
> -#line 288 "libxlu_disk_l.l"
> +#line 289 "libxlu_disk_l.l"
>  {
>      xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0;
>  }
>  	YY_BREAK
> -case 36:
> +case 37:
>  YY_RULE_SETUP
> -#line 291 "libxlu_disk_l.l"
> +#line 292 "libxlu_disk_l.l"
>  YY_FATAL_ERROR( "flex scanner jammed" );
>  	YY_BREAK
> -#line 1839 "libxlu_disk_l.c"
> +#line 1848 "libxlu_disk_l.c"
>  			case YY_STATE_EOF(INITIAL):
>  			case YY_STATE_EOF(LEXERR):
>  				yyterminate();
> @@ -2104,7 +2113,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner)
>  		while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D
> yy_current_state )
>  			{
>  			yy_current_state =3D (int) yy_def[yy_current_state];
> -			if ( yy_current_state >=3D 355 )
> +			if ( yy_current_state >=3D 361 )
>  				yy_c =3D yy_meta[yy_c];
>  			}
>  		yy_current_state =3D yy_nxt[yy_base[yy_current_state] + yy_c];
> @@ -2128,11 +2137,11 @@ static int yy_get_next_buffer (yyscan_t
> yyscanner)
>  	while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D yy_current_state =
)
>  		{
>  		yy_current_state =3D (int) yy_def[yy_current_state];
> -		if ( yy_current_state >=3D 355 )
> +		if ( yy_current_state >=3D 361 )
>  			yy_c =3D yy_meta[yy_c];
>  		}
>  	yy_current_state =3D yy_nxt[yy_base[yy_current_state] + yy_c];
> -	yy_is_jam =3D (yy_current_state =3D=3D 354);
> +	yy_is_jam =3D (yy_current_state =3D=3D 360);
>  	if ( ! yy_is_jam )
>  		*yyg->yy_state_ptr++ =3D yy_current_state;
>=20
> @@ -2941,4 +2950,4 @@ void yyfree (void * ptr , yyscan_t yyscanner)
>=20
>  #define YYTABLES_NAME "yytables"
>=20
> -#line 291 "libxlu_disk_l.l"
> +#line 292 "libxlu_disk_l.l"
> diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_dis=
k_l.h
> index 6abeecf..df20fcc 100644
> --- a/tools/libs/util/libxlu_disk_l.h
> +++ b/tools/libs/util/libxlu_disk_l.h
> @@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner);
>  #undef yyTABLES_NAME
>  #endif
>=20
> -#line 291 "libxlu_disk_l.l"
> +#line 292 "libxlu_disk_l.l"
>=20
>  #line 699 "libxlu_disk_l.h"
>  #undef xlu__disk_yyIN_HEADER
> diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_dis=
k_l.l
> index 3bd639a..d68a59c 100644
> --- a/tools/libs/util/libxlu_disk_l.l
> +++ b/tools/libs/util/libxlu_disk_l.l
> @@ -198,6 +198,7 @@ script=3D[^,]*,?	{ STRIP(','); SAVESTRING("script",
> script, FROMEQUALS); }
>  direct-io-safe,? { DPC->disk->direct_io_safe =3D 1; }
>  discard,?	{ libxl_defbool_set(&DPC->disk->discard_enable, true); }
>  no-discard,?	{ libxl_defbool_set(&DPC->disk->discard_enable, false); }
> +virtio,?	{ DPC->disk->virtio =3D 1; }
>   /* Note that the COLO configuration settings should be considered unsta=
ble.
>    * They may change incompatibly in future versions of Xen. */
>  colo,?		{ libxl_defbool_set(&DPC->disk->colo_enable, true); }
> diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
> index 70eed43..50a4d45 100644
> --- a/tools/xl/xl_block.c
> +++ b/tools/xl/xl_block.c
> @@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
>          return 0;
>      }
>=20
> +    if (disk.virtio) {
> +        fprintf(stderr, "block-attach is not supported for Virtio device=
\n");
> +        return 1;
> +    }
> +
>      if (libxl_device_disk_add(ctx, fe_domid, &disk, 0)) {
>          fprintf(stderr, "libxl_device_disk_add failed.\n");
>          return 1;
> @@ -119,6 +124,12 @@ int main_blockdetach(int argc, char **argv)
>          fprintf(stderr, "Error: Device %s not connected.\n", argv[optind=
+1]);
>          return 1;
>      }
> +
> +    if (disk.virtio) {
> +        fprintf(stderr, "block-detach is not supported for Virtio device=
\n");
> +        return 1;
> +    }
> +
>      rc =3D !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) =
:
>          libxl_device_disk_destroy(ctx, domid, &disk, 0);
>      if (rc) {
> --
> 2.7.4
>=20
[Jiamei Xie]=20
Tested-by: Jiamei Xie <Jiamei.xie@arm.com>

Best wishes
Jiamei Xie




From xen-devel-bounces@lists.xenproject.org Thu Dec 09 06:55:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 06:55:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242696.419728 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDLF-0000YR-4s; Thu, 09 Dec 2021 06:55:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242696.419728; Thu, 09 Dec 2021 06:55:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDLF-0000YK-18; Thu, 09 Dec 2021 06:55:45 +0000
Received: by outflank-mailman (input) for mailman id 242696;
 Thu, 09 Dec 2021 06:55:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mCcN=Q2=epam.com=prvs=2977d6bd4b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mvDLD-0000YE-EJ
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 06:55:43 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 056aaf82-58bd-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 07:55:41 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1B96doIW012941;
 Thu, 9 Dec 2021 06:55:37 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cucb5r2pm-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 09 Dec 2021 06:55:36 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR0302MB3284.eurprd03.prod.outlook.com (2603:10a6:208:c::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 9 Dec
 2021 06:55:34 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.013; Thu, 9 Dec 2021
 06:55:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 056aaf82-58bd-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mtVxHQ3UWFT4+uVfNPCn81xn62gQAxKcE3miofbGIwUbn34IZgnfLSI4sT+GDgmGbSyOow86tkzHxi6Guwf5bsLyPXdrTZGAKYBE+erzcAGPAyeR8vDflOpNRuOaAhKOOlz+5TeJ7hxt63ZAYZ8d9WB7M/QuglFM/RAdH/XRftJhYtoNQO2pbY2vrL4mg36lmZ35spRtl7CpwsfUnb+8IW5g2Y6GkyjmH2lZyhQCeWBeOPylSjNud4zi62zUsC+d74slYhOM46ZPchN+vf2RKb+vfD6Uj6BUVinGkqTogtzfYQ7K4ck6scKuBOGRbZSW+Hg2pVROwK/NDO3rCQ5oUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NBgVJG2gqFhKZwdXigUwjE3s+Wl4y3vToSgqFORTI+Y=;
 b=WUEPmf036c1fbCBJYxuEOX0yvvQlFLGV/u9IRqlIFCnQeakxVq473OaJsMtbAcxRKQf9HRpUH1/btWb8SfN+lM/uYk6ylkBfuVM/Ax0sia7V/YutfxQkhByhhn50OMZyqtiZfBM1js+47BvkWhW/YPuIYd6G4nn6VtsS91jMqsJF6s7lvGFkFFn4ChzM0fryN9WGWwNozeF3KgzWdttP1vnSIzwYvJNuNBnmoOOopkl+DjttNXom491gfGao7NmN0lMzZZacekz9L+PcnnqXZrgpxyyvRSp9OGPG6f7tfP7eiWufPWUpt2ggc3pQHq2Gqo4pAdDL/FtI8+jxRWacSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NBgVJG2gqFhKZwdXigUwjE3s+Wl4y3vToSgqFORTI+Y=;
 b=ddFv65YhxKvUp2uUgxYRIWOuQbkfjeoMRddb4TWgYZrHdCm0L2MVV0QaQ2XZSXAmdoV3nVadS1YMFmLvMdVIFv+rkFZpFn727LHBsvXw1OiXONBZdSAfRAkJgBCt/DR9leUsCn1BHPYiE6Q6WwGQri6hkFt5GuMMpf04t3qjEdXpijhusaMKKnKDKsoPD6FoBqmb0Tf6ZpcVJDvrTCgNCxABfpEwatC+olDkjGQfQgrtIr4gsUVrQKDjxvgZexIpMwliBGQqBpI+kGIsxP6VxgNtXVkJ7rJZEGo860YsWrMJyR62NAQUzDzS2PTVx3S790TCZdvIasjAl9w5C0CQEw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Topic: [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Index: AQHX4QlHTkep1sCXwU6sAzOhbUDnn6wo5hsAgAAi1QCAAMiCgA==
Date: Thu, 9 Dec 2021 06:55:33 +0000
Message-ID: <0adab467-8289-5dc9-2bee-b9f4d5e5fa3e@epam.com>
References: <20211124075942.2645445-1-andr2000@gmail.com>
 <20211124075942.2645445-5-andr2000@gmail.com>
 <77326c24-9d2a-22ef-00cf-b89f1e70eaaf@xen.org>
 <de027721-5240-cf79-b932-4a1e36077e41@epam.com>
In-Reply-To: <de027721-5240-cf79-b932-4a1e36077e41@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4d33964e-ada2-4c3f-0243-08d9bae0e5d8
x-ms-traffictypediagnostic: AM0PR0302MB3284:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR0302MB32842EC4D2A002A08FE6BD6BE7709@AM0PR0302MB3284.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 GCUIiB+KgU7KqLzRyZZ4OqMium+917ryJL8t+na8SZraqTJ4A9HxM3HMv0lFP2pUwlUbQL242pEPmPMNqVVQookIAQooL3e5zcioQO+tecVt+JZygAApQ2a28Zg2CR2uY5icIPwBjltL+F8ewgWOaTMT0SCvFnOm1fHqB7NpjGu9eg1Z+F+RRxpGCK3r4l5pkZ2B2hk5N6QYRZV9+FDhNvmkZShqHpyRTu+Duttab9K2XvRP9jkzlGo3dQ0LjeD7Layap/DuCgoeZc2e8jyK39yvMmCv2aZRlP1ROHa76PbpGg7a6fOA46ej/h+2jI3UFAOylsBITckpdZkI6T0DIQpKobm5cGh3z3Am8RNu0JKIaH5xGkIzlLwEcl9Edt/FZvr0A15zeOz12t1LHcoW4eWhIo48OBqv9TNSwSiMdCW0G7LqY4rBBL4rePHgSP6yxBJTl7nS72fqGUXObY2WopJkBJw0UdPgVVWLJOpc+5go6ROLPxOIcqUOrLuodUpc/wyh89usHVrNmJqdtHiMBPP9csMYhbCaMjVqJjCyQovS47L5UZ3+R01v14HaBFpUefW2WnWPEx5USSKLbiNB/T0707zgpom7sYm7HB5a6FQ1xvpuMNGuAsUa7u1eFFFow9S7Ston3RETN+VCM2vGeu97LhyJxfJQ/6SqqMRvzbrA7isad0pro1VpBAmOCKe9QP4K/SriWdDY76jYOz/6yoOQ1hJgYsqCvRrWlWQI1uwpVgNAnnWI3UNQsteOxBUn
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(36756003)(91956017)(55236004)(8936002)(107886003)(186003)(6506007)(8676002)(26005)(76116006)(4326008)(4744005)(31686004)(2906002)(2616005)(7416002)(5660300002)(38070700005)(54906003)(110136005)(66476007)(66556008)(31696002)(64756008)(316002)(508600001)(66446008)(6486002)(38100700002)(71200400001)(122000001)(83380400001)(86362001)(6512007)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?NFNFK3NDcU4ycCt5TU5OamM3WlRsQzdmdWRUazF5RzhCRjFHbU0wSWRzem5V?=
 =?utf-8?B?enR3eHkvaUxlQW40N1hMSkkrdzRXLzhFeE5IenNmbnkwYk5XcWNkd1Bjdlcz?=
 =?utf-8?B?ZnA5RVE0UFY2RzBmd1RFVnRlUk8wUmt2TVZTb05QQlpJbll5WXZuSTNBVm83?=
 =?utf-8?B?amRFbmlFWXhmeENqMXVMMEgydVhPVzVYWkZndjNzRituc2ZCdkxSdDcrc05H?=
 =?utf-8?B?V3lvZkpXNGhidjNtVm5Kbjg0THpUODNKZmEwV0Y5R2VaZUtWMndnS1lodFEy?=
 =?utf-8?B?RnNRVDJsR2VXZG00cnJ6dzdtNHZNSmx2VExqWk84Vm9NZHRPMVRORGRERHN6?=
 =?utf-8?B?SEtpSWhDZkNPbTRCU2ZMeEQ4Z0tmeFQ1MzI0bHdVU0draG9ENU5NU21PRWds?=
 =?utf-8?B?Wk5uaFc4R3IzeDFvUHA0aUFIZjFuWFoxMmpnOUd4MjhNUTI3MlA1dXVmQ1dO?=
 =?utf-8?B?bUNtSGNUaUxQNWxrbi9uUGFKZjhqQlpvZjdLTWVjQkJ3SUhJMGlrdjdqYjE0?=
 =?utf-8?B?eExpQkhZekVPU2tKeU5zVDNhbkF1dDVxajJqdTFXOEJ0dWhXZTJkemx4OEs1?=
 =?utf-8?B?cFlBZ201cjVuTmo5VUw3bEhZZ3lhZElVVjk1enhzbjhkeElkUUwzbGtscjlL?=
 =?utf-8?B?SDgyWVZzS1pINEY2dGwzdzlIRzBEZ29vVlZCOENmc2g3RXBnemdTQXp1WExa?=
 =?utf-8?B?TTlKYjA0ZmUvcm1Vb0hZajVSVlYrN01SUzNJTEY3MTB5VWxmci9jZDYyNlZU?=
 =?utf-8?B?VDJPelJucUJZSUViZ3dtRGlVLy9Qb2J3eXQ3cFVPOHYzTURKZCtxWUxSYlMr?=
 =?utf-8?B?ZTlMUnB6ZlEySVMxc3lYNDU5aG4rZm5NN0tlbjcycFRvSmVsS0pMMlhRSUVp?=
 =?utf-8?B?RlpjOURtUEFiTFNJVDFCeFIzc1JpbVJtWktuanFVbVJZV1o1NkhaYWgwOXcy?=
 =?utf-8?B?ekduK1RMQlhLbTBvdm9Oc1hWYjNXZ0l6N3V2bmJXVGNVNzBqMHNDd1AwSUY4?=
 =?utf-8?B?NXBXTmtEbTNmSzBYeGtqcWkxN0NwSGErZTByL1orejZqbGR1UTlrZnhXcmJk?=
 =?utf-8?B?Nzcxd21tZzhqSHpSUlZhcjJOYnF2QSsyR1dEVnE2LzRQYW9EK3VoanhzdnFq?=
 =?utf-8?B?WFZiVjdNWEVpeDR1SHBBWnpPQmQ5S2RmeVplWEhuZHBJMUlQT0RaK0ovTEY3?=
 =?utf-8?B?eXR5VExWbGRnYmU0b2liN3pPaG4zeERtZjhMSUx2aFltdmFFWTFtVDhxR0sz?=
 =?utf-8?B?cmZKdmE5RzhNOE92dHQ4M3ZiTkZTaFBSd2paOUdGeVRMZ0hwSUExSlArMHlK?=
 =?utf-8?B?SmhNVzJCRTNCeEFBQzB5U3pjMUdDUEx1L1N3UTBjekR6VlVENlhjNkdWcWEr?=
 =?utf-8?B?SW5NOFkyZmdzd0JPTUJrV2NRUWxBaFIrRDFMNE5wQURBS3JzQXRxVURWSklW?=
 =?utf-8?B?cjZDb2prOE1wVmFubkxGOW1GNnEzVlhGcGd5UFdxWVdwOW5tVC9LZmYwUjZv?=
 =?utf-8?B?YWwvSmR3dmI1NktvK1FtclQ2ZmlSUEV3dzVPRmxNZ3JYK3pIZ1hodlFsUkpi?=
 =?utf-8?B?TXFMc21xdnlwZ0tGZFRDbkpoZ1hPcCtvbDNUMFVlbW8xZkZ1RERmamVLbGlo?=
 =?utf-8?B?UllpU2MvZjBVUzRHaXRjejlqa0svWVJMeS80Q2hmZUtuL09UYlptclB1bndT?=
 =?utf-8?B?VGc0d1ZwS3N2bmNVbVZYWk02b3N6ajhmNVhTeGwyZzNDQ1djaWl1RkpJQ25O?=
 =?utf-8?B?RzFRWWlaTE5SeDJYY1ZaMFBodXR3MXNCTDhVVVJLVkU4aEhmcnVCaHBTSXhG?=
 =?utf-8?B?UXhLYmdJM3d4WW9JK0lZR1NnNzBxUndRSXlmc29xbVpaaWVXdHhLWmtSOFpu?=
 =?utf-8?B?U1IzS0piaVczK1crQ21BL2p0dnF5NjZmaTRmR09QL0RvaS9UR3hFdGZRem9T?=
 =?utf-8?B?OXkxNVRXYXZtOXNGZDcyeDNUMWpBTTdNaGF6Q1JqOFJmL3VpNHVlbytNdFVD?=
 =?utf-8?B?WlJXRzJSc3pZSVQ0SjJvdTFMVEVCaDRZeFoxZkJ6alJnQnBXdDNMNndHclFJ?=
 =?utf-8?B?K0s1Q1Jmb2xPcTdJRUo4cHVPNXdEUlA5Qk9iOUtacVptOVVBbmR5S1ZVdFNC?=
 =?utf-8?B?Z0xhbUl4eHFVS3NUa3lOaTEvNlVvTnF5dllUKzArR1BHQ1kyaHhyWS9MajlD?=
 =?utf-8?B?S01ON0tHTDcrN0V0MHprK1dNSThTSkpGU2gzVGEzRVhxV0RWZW1jaXdsRWRv?=
 =?utf-8?B?MmFNaXhZSGlKU2ZzdUlidVB4eWNPTU1XcU5MdGhBVkxEdWtSQnNPYWxhMUxu?=
 =?utf-8?B?bURSaHVSYjNWSTN1eStNRzdFRm5weVRUcE80UmgxMlV2ODBCYUJnUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6F9E1B915776854B95D6B5D514500DE6@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d33964e-ada2-4c3f-0243-08d9bae0e5d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 06:55:33.9496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vsSzknhxEpo/Bd108yEkqC7+GyWS253zm8r0V5pHUDPIctEBrojt4D7FzlIWr+V/EwW7n3RYty6kuYYCDxtH0qDN9bBu3giuLG8mgggLqUMqaiBEyGsL/ofnpuEO+dGh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0302MB3284
X-Proofpoint-GUID: eo6c4UFu6-BLn6JMJ7MD8zkyA6L-SXGo
X-Proofpoint-ORIG-GUID: eo6c4UFu6-BLn6JMJ7MD8zkyA6L-SXGo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-09_03,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=633 spamscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112090036

SW4gZ2VuZXJhbCwgaXQgaXMgYmV0dGVyIHRvIGhhdmUgdGhlIGZpeGVzIGF0IHRoZSBiZWdpbm5p
bmcgb2YgYSBzZXJpZXMuIFNvIHRoZXkgYXJlIHJlbHlpbmcgb24gbGVzcyByZXdvcmsgYW5kIGVh
c2llciB0byBiYWNrcG9ydCAoaWYgbmVlZGVkKS4NCj4+IEluIHRoaXMgY2FzZSwgUENJIHBhc3N0
aHJvdWdoIGlzIHN0aWxsIGEgdGVjaG5pY2FsIHByZXZpZXcgc28gaXQgZG9lc24ndCBtYXR0ZXIg
dG9vIG11Y2guDQo+IEkgYW0gcGxhbm5pbmcgdG8gcmVzZW5kIHRoZSB3aG9sZSBzZXJpZXMsIHNv
IEkgY2FuIG1vdmUgdGhpcyB0byB0aGUgYm90dG9tLA0KPiBidXQgaXQgaXMgaW5kZWVkIGRvZXNu
J3QgbWF0dGVyIGF0IHRoZSBtb21lbnQNCkkgdHJpZWQgdG8gcmUtb3JkZXIsIGJ1dCB0aGlzIHBh
dGNoIGFscmVhZHkgZGVwZW5kcyBvbiB0aGUgcHJldmlvdXMgaW4gdGhlIHNlcmllcy4NCkl0IG5l
ZWRzIHRvIGJlIGZpeGVkIGluIGEgZGlmZmVyZW50IHdheSB0aGVuIHdoaWNoIHdpbGwgY2hhbmdl
IHRoZSBwYXRjaGVzIGFib3ZlLA0Kc28gSSBsZWF2ZSB0aGlzIHdoZXJlIGl0IGlzLg0KDQpUaGFu
ayB5b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:10:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:10:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242702.419738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDYq-00032M-BD; Thu, 09 Dec 2021 07:09:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242702.419738; Thu, 09 Dec 2021 07:09:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDYq-00032F-8B; Thu, 09 Dec 2021 07:09:48 +0000
Received: by outflank-mailman (input) for mailman id 242702;
 Thu, 09 Dec 2021 07:09:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvDYo-000329-Ez
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:09:46 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc8f2812-58be-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:09:45 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6139B1FD2A;
 Thu,  9 Dec 2021 07:09:44 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29C3413CA2;
 Thu,  9 Dec 2021 07:09:44 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WJtNCLirsWHiKwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 07:09:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc8f2812-58be-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639033784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=4w2OxTiRKF8fsZOTqtPttgBYf/Bbn749xJXtOyx+d9U=;
	b=trKliYJ8P9UO8+iX0lVKnTVcOQjAzLqWUlInY0+XpcLTIbt1Qif6i/tvdzY52OIonhD4lO
	jOAygkGKB3K2siiK8zs/g6+L3tz2oC/jkvOAMq1fmxCiG11hC21A1JT5ClXCupMvOvqQzR
	/p0/kVA6WNjbSh2YzfQUT0/mYkjWl4k=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Roger Pau Monne <roger.pau@citrix.com>,
	Manuel Bouyer <bouyer@antioche.eu.org>,
	Simon Kuenzer <simon.kuenzer@neclab.eu>,
	Paul Durrant <paul@xen.org>
Subject: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
Date: Thu,  9 Dec 2021 08:09:42 +0100
Message-Id: <20211209070942.14469-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today RING_HAS_UNCONSUMED_*() macros are returning the number of
unconsumed requests or responses instead of a boolean as the name of
the macros would imply.

As this "feature" is already being used, rename the macros to
RING_NR_UNCONSUMED_*() and define the RING_HAS_UNCONSUMED_*() macros
by using the new RING_NR_UNCONSUMED_*() macros. In order to avoid
future misuse let RING_HAS_UNCONSUMED_*() optionally really return a
boolean (can be activated by defining RING_HAS_UNCONSUMED_IS_BOOL).

Note that the known misuses need to be switched to the new
RING_NR_UNCONSUMED_*() macros when using this version of ring.h.

Cc: Roger Pau Monne <roger.pau@citrix.com>
Cc: Manuel Bouyer <bouyer@antioche.eu.org>
Cc: Simon Kuenzer <simon.kuenzer@neclab.eu>
Cc: Paul Durrant <paul@xen.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
---
I have checked Xen, Mini-OS, qemu, grub2, OVMF and Linux kernel for
misuses of the RING_HAS_UNCONSUMED_*() macros. There is currently only
one instance in the Linux kernel netback driver. The BSDs, UNIKRAFT
and Windows PV drivers should be checked for misuse, too.
V2: make RING_HAS_UNCONSUMED_*() returning a bool optional (Jan Beulich)
---
 xen/include/public/io/ring.h | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h
index c486c457e0..a7f492db39 100644
--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -208,11 +208,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
     (RING_FREE_REQUESTS(_r) == 0)
 
 /* Test if there are outstanding messages to be processed on a ring. */
-#define RING_HAS_UNCONSUMED_RESPONSES(_r)                               \
+#define RING_NR_UNCONSUMED_RESPONSES(_r)                                \
     ((_r)->sring->rsp_prod - (_r)->rsp_cons)
 
 #ifdef __GNUC__
-#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({                             \
+#define RING_NR_UNCONSUMED_REQUESTS(_r) ({                              \
     unsigned int req = (_r)->sring->req_prod - (_r)->req_cons;          \
     unsigned int rsp = RING_SIZE(_r) -                                  \
         ((_r)->req_cons - (_r)->rsp_prod_pvt);                          \
@@ -220,13 +220,25 @@ typedef struct __name##_back_ring __name##_back_ring_t
 })
 #else
 /* Same as above, but without the nice GCC ({ ... }) syntax. */
-#define RING_HAS_UNCONSUMED_REQUESTS(_r)                                \
+#define RING_NR_UNCONSUMED_REQUESTS(_r)                                 \
     ((((_r)->sring->req_prod - (_r)->req_cons) <                        \
       (RING_SIZE(_r) - ((_r)->req_cons - (_r)->rsp_prod_pvt))) ?        \
      ((_r)->sring->req_prod - (_r)->req_cons) :                         \
      (RING_SIZE(_r) - ((_r)->req_cons - (_r)->rsp_prod_pvt)))
 #endif
 
+#ifdef RING_HAS_UNCONSUMED_IS_BOOL
+/*
+ * These variants should only be used in case no caller is abusing them for
+ * obtaining the number of unconsumed responses/requests.
+ */
+#define RING_HAS_UNCONSUMED_RESPONSES(_r) (!!RING_NR_UNCONSUMED_RESPONSES(_r))
+#define RING_HAS_UNCONSUMED_REQUESTS(_r)  (!!RING_NR_UNCONSUMED_REQUESTS(_r))
+#else
+#define RING_HAS_UNCONSUMED_RESPONSES(_r) RING_NR_UNCONSUMED_RESPONSES(_r)
+#define RING_HAS_UNCONSUMED_REQUESTS(_r)  RING_NR_UNCONSUMED_REQUESTS(_r)
+#endif
+
 /* Direct access to individual ring elements, by index. */
 #define RING_GET_REQUEST(_r, _idx)                                      \
     (&((_r)->sring->ring[((_idx) & (RING_SIZE(_r) - 1))].req))
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:19:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:19:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242708.419749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDhy-0004wr-89; Thu, 09 Dec 2021 07:19:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242708.419749; Thu, 09 Dec 2021 07:19:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDhy-0004wk-4g; Thu, 09 Dec 2021 07:19:14 +0000
Received: by outflank-mailman (input) for mailman id 242708;
 Thu, 09 Dec 2021 07:19:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=sGmr=Q2=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mvDhw-0004wc-BI
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:19:12 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 4d16b7bd-58c0-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:19:10 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2A2213A1;
 Wed,  8 Dec 2021 23:19:08 -0800 (PST)
Received: from [10.57.3.209] (unknown [10.57.3.209])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2622B3F5A1;
 Wed,  8 Dec 2021 23:19:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4d16b7bd-58c0-11ec-9d12-4777fae47e2b
Subject: Re: Aarch64 stand-alone application for Xen
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com>
 <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
 <074326cc-f910-2cad-be1f-e27480f53b67@arm.com>
 <CANLsYkyF4Mv+MhyKJ-B4-56G=RVu6U3=OAraK5ZtnOx6TaW1UQ@mail.gmail.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <877a84bc-b550-a22b-d3ab-1f81b1b78c6f@arm.com>
Date: Thu, 9 Dec 2021 08:19:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CANLsYkyF4Mv+MhyKJ-B4-56G=RVu6U3=OAraK5ZtnOx6TaW1UQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Mathieu,

On 08.12.2021 22:23, Mathieu Poirier wrote:
> On Wed, 8 Dec 2021 at 07:19, Michal Orzel <michal.orzel@arm.com> wrote:
>>
>> Hi Mathieu,
>>
>> On 08.12.2021 01:06, Mathieu Poirier wrote:
>>> Hi Bertrand,
>>>
>>> On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
>>>>
>>>> Hi Mathieu,
>>>>
>>>>> On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>>>>>
>>>>> Good day,
>>>>>
>>>>> I am in the process of adding support for aarch64 to the xen-sys
>>>>> crate[1].  The crate currently supports x86_64 and includes a
>>>>> stand-alone "oxerun" application that can be used to validate
>>>>> hypercalls.  My goal is to provide the same functionality on arm64.  I
>>>>> am looking for a stand-alone aarch64 example, something like an "hello
>>>>> world" to help me with the assembler startup code.
>>>>
>>>> We are working on porting XTF to arm64 and already have something running.
>>>> I think it could be a good starting point for you:
>>>> https://github.com/orzelmichal/xtf/tree/arm-devel
>>>
>>> Quick one - have you been able to get the "test-arm-64le-example"
>>> application to run?  So far Xen gives me the following error:
>>>
>>> (XEN) ****************************************
>>> (XEN) Panic on CPU 0:
>>> (XEN) Unable to copy the kernel in the hwdom memory
>>> (XEN) ****************************************
>>>
>>> I wanted to check with you before starting to dig into it.
>>>
>>
>> ICYDK, 64le environment is used to create non-MMU domain in contrast to mmu64le.
> 
> Right.
> 
>> It lacks support for PV console and other important features of Xen.
> 
> I'm good with that - for now all I want is to test hypervisor calls I
> developed in Rust.
> 
>> But we are able to run it without any issue.
>> Please keep in mind that as there is no MMU you need to pay attention to the load address.
>> By default for non-MMU domain, the address is 0x40000000 which is the correct address if you use XTF as a guest.
> 
> I was trying to boot XTF as dom0 using the default address
> (0x40000000), which lead to the output depicted above.
> 
>> If you want to run non-MMU XTF as dom0, you need to specify the correct load address by passing CONFIG_LOAD_ADDRESS=<address>
>> when invoking make. For example on QEMU it would be CONFIG_LOAD_ADDRESS=0x80000000.
>>
> 
> When adding the compilation flag "CONFIG_LOAD_ADDRESS=0x80000000" I
> get further [1].  For my own education, why is address 0x80000000
> required when running a non-MMU XTF as dom0?  Is this a Xen thing?
> 
> The application crashes in the loop on line 135 [2] and I am wondering
> if it wouldn't be related to the QEMU emulation. My setup is as
> follow:
> 
> . QEMU startup command [3]
> . XTF baseline: "c14f7dd289a4 (xtf: Add arm support into xtf-runner)"
> . Xen baseline: "c76cfada1cfa (tools/libacpi: Use 64-byte alignment for FACS)"
> 
> Best regards,
> Mathieu
> 
> [1]. https://pastebin.com/3AVXRGXD
> [2]. https://github.com/orzelmichal/xtf/blob/arm-devel/arch/arm/arm64/head.S#L135
> [3]. https://pastebin.com/52aVAFha
> 

For the setup you provided just compile XTF with CONFIG_LOAD_ADDRESS=0x60000000.
This will fix your problem.
When using non-MMU dom0, the microkernel must be compiled with the load address that
is within the memory bank allocated by Xen. You can see it in your logs:
(XEN) BANK[0] 0x00000060000000-0x00000080000000 (512MB)

You did not specify dom0_mem parameter, so Xen defaults to 512MB for dom0.
You can see it in your logs:
(XEN) PLEASE SPECIFY dom0_mem PARAMETER - USING 512M FOR NOW

FWICS you are passing Xen command line arguments through -append but i'm not sure it works.
The best way is to use dtb.


>>> Thanks,
>>> Mathieu
>>>
>>>>
>>>> Regards
>>>> Bertrand
>>>>
>>>>>
>>>>> Many thanks for the consideration,
>>>>> Mathieu
>>>>>
>>>>> [1]. https://crates.io/crates/xen-sys
>>>>>
>>>>
>>>
>> Cheers,
>> Michal

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:29:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242716.419783 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrp-0007Nr-S9; Thu, 09 Dec 2021 07:29:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242716.419783; Thu, 09 Dec 2021 07:29:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrp-0007Nk-O1; Thu, 09 Dec 2021 07:29:25 +0000
Received: by outflank-mailman (input) for mailman id 242716;
 Thu, 09 Dec 2021 07:29:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5bTN=Q2=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvDro-00075S-FL
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:29:24 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb0ca4bf-58c1-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:29:23 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id k2so7593624lji.4
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:29:23 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f13sm445069lfe.297.2021.12.08.23.29.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 08 Dec 2021 23:29:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb0ca4bf-58c1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=XUbUdVW/JQJGJv5htHXoALs0/d8a/QR27xFCYV/hVms=;
        b=NB1ofDHv1bCLI5ZycXHpD1vK9WrNa6k4+O7RblnTJJuyEncVfvTRjNfEUQLEmeKNQ7
         nj/4ikMG64nKUYeNSoe7q/uFXiCSLwgXcKLyiEQZuSOpA5YddU/tyzb6Ywcgswu9qfNM
         G5DMVaVZBCbwKpBXus+y/kvhaq5vep8nALBlQ/QSyk+Z97EHJpqynmGVIPl46b6ObAEL
         rAAtqBMW//87W+ZTB/k/WQ3zm+798u1+SXRVV2dsDB9Bx54YHj1gM2Lsbt3JAMPG2O/9
         pUABfV/YAvD/KsmfBj5r7aGqKCYaxf/tTxiOvWZS1xBS5PxPIr4wRxNNkntybNEdeBxn
         IRmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=XUbUdVW/JQJGJv5htHXoALs0/d8a/QR27xFCYV/hVms=;
        b=3+1J898qcJaJuVabMSojTUOP44W5nWJhTt5KVcpc7CCOUHDJB9YHmlUmGPrXIJAnV/
         Jihbut2C4MK9I20FttUUCJPNmri6kXfETOza8+Rx2mL9DhfPscu+RXNaXExjYyfI8AOm
         YkyNgb8GuRa5Y+hdio1g3jh0HKPDKUtVoNWot4l0G0l9PA0sezrw0S4YQVyYmTRiNxEA
         14/iLWdZEEkCfatOEBav1SgocF5ph1grJMh/CL95BT+JtD952FRY+m9OyHi15/yJOGpN
         P0QUzOosbFt5ZE9lD+9PwCSPCFKXb362aLV1dY+4OT+pARo5YkWnOsUPRTDCsHbf3076
         ulbw==
X-Gm-Message-State: AOAM5303MFbnkiG/lfmlDjWawoxyLegKDriUpe02yM2dUhiPdmZR9Cze
	r1kzzVlwohfkZC8jcB6W8VIvqcNGghpPQA==
X-Google-Smtp-Source: ABdhPJx6MjlYrfHHU5UuBUicZWv6in5FppRcK79YaoNIBKz1cXa4FcBu7I4/oIYJgKoaeqGkn7qcWQ==
X-Received: by 2002:a2e:a7c6:: with SMTP id x6mr4561545ljp.328.1639034962642;
        Wed, 08 Dec 2021 23:29:22 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for hardware domain
Date: Thu,  9 Dec 2021 09:29:16 +0200
Message-Id: <20211209072918.460902-3-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211209072918.460902-1-andr2000@gmail.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

In order for vPCI to work it needs to maintain guest and hardware
domain's views of the configuration space. For example, BARs and
COMMAND registers require emulation for guests and the guest view
of the registers needs to be in sync with the real contents of the
relevant registers. For that ECAM address space needs to also be
trapped for the hardware domain, so we need to implement PCI host
bridge specific callbacks to properly setup MMIO handlers for those
ranges depending on particular host bridge implementation.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Since v7:
- move local variable inside the loop in pci_host_iterate_bridges_and_count
  and s/err/ret
- fixed incorrect s/if ( err )/if ( err < 0 )
- moved the guest part in an else in domain_vpci_init
- s/count/ret in domain_vpci_init as it better reflects the use of the
  value
Since v6:
- eliminate pci_host_get_num_bridges and make pci_host_iterate_bridges
  return the count
- extend comment in domain_vpci_init
- remove not yet relevant code for num MMIOs and virtual bus topology
- add extra check for has_vpci in domain_vpci_get_num_mmio_handlers
- remove code that fixes num MMIOs for guest domain as it doesn't belong
  to this patch
Since v5:
- add vpci_sbdf_from_gpa helper for gpa to SBDF translation
- take bridge's bus start into account while calculating SBDF
Since v4:
- unsigned int for functions working with count
- gate number of MMIO handlers needed for CONFIG_HAS_PCI_MSI
  and fix their number, e.g. single handler for PBA and
  MSI-X tables (Roger)
- re-work code for assigning MMIO handlers to be simpler
  and account on the fact that there could multiple host bridges
  exist for the hwdom
Since v3:
- fixed comment formatting
Since v2:
- removed unneeded assignment (count = 0)
- removed unneeded header inclusion
- update commit message
Since v1:
 - Dynamically calculate the number of MMIO handlers required for vPCI
   and update the total number accordingly
 - s/clb/cb
 - Do not introduce a new callback for MMIO handler setup
---
 xen/arch/arm/domain.c              |  2 +
 xen/arch/arm/pci/pci-host-common.c | 19 +++++++
 xen/arch/arm/vpci.c                | 81 ++++++++++++++++++++++++++----
 xen/arch/arm/vpci.h                |  6 +++
 xen/include/asm-arm/pci.h          |  4 ++
 5 files changed, 102 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 96e1b235501d..92a6c509e5c5 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -739,6 +739,8 @@ int arch_domain_create(struct domain *d,
     if ( (rc = domain_vgic_register(d, &count)) != 0 )
         goto fail;
 
+    count += domain_vpci_get_num_mmio_handlers(d);
+
     if ( (rc = domain_io_init(d, count + MAX_IO_HANDLER)) != 0 )
         goto fail;
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 40e779b5d803..84aab371cd9a 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -294,6 +294,25 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+int pci_host_iterate_bridges_and_count(struct domain *d,
+                                       int (*cb)(struct domain *d,
+                                                 struct pci_host_bridge *bridge))
+{
+    struct pci_host_bridge *bridge;
+    int count = 0;
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        int ret;
+
+        ret = cb(d, bridge);
+        if ( ret < 0 )
+            return ret;
+        count += ret;
+    }
+    return count;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 23f45386f4b3..1564448c6c8d 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -16,16 +16,31 @@
 
 #include <asm/mmio.h>
 
+static pci_sbdf_t vpci_sbdf_from_gpa(const struct pci_host_bridge *bridge,
+                                     paddr_t gpa)
+{
+    pci_sbdf_t sbdf;
+
+    if ( bridge )
+    {
+        sbdf.sbdf = VPCI_ECAM_BDF(gpa - bridge->cfg->phys_addr);
+        sbdf.seg = bridge->segment;
+        sbdf.bus += bridge->cfg->busn_start;
+    }
+    else
+        sbdf.sbdf = VPCI_ECAM_BDF(gpa - GUEST_VPCI_ECAM_BASE);
+
+    return sbdf;
+}
+
 static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
                           register_t *r, void *p)
 {
-    pci_sbdf_t sbdf;
+    struct pci_host_bridge *bridge = p;
+    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa);
     /* data is needed to prevent a pointer cast on 32bit */
     unsigned long data;
 
-    /* We ignore segment part and always handle segment 0 */
-    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
-
     if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),
                         1U << info->dabt.size, &data) )
     {
@@ -41,10 +56,8 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,
 static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,
                            register_t r, void *p)
 {
-    pci_sbdf_t sbdf;
-
-    /* We ignore segment part and always handle segment 0 */
-    sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE);
+    struct pci_host_bridge *bridge = p;
+    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa);
 
     return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),
                            1U << info->dabt.size, r);
@@ -55,13 +68,61 @@ static const struct mmio_handler_ops vpci_mmio_handler = {
     .write = vpci_mmio_write,
 };
 
+static int vpci_setup_mmio_handler_cb(struct domain *d,
+                                      struct pci_host_bridge *bridge)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    register_mmio_handler(d, &vpci_mmio_handler,
+                          cfg->phys_addr, cfg->size, bridge);
+
+    /* We have registered a single MMIO handler. */
+    return 1;
+}
+
 int domain_vpci_init(struct domain *d)
 {
     if ( !has_vpci(d) )
         return 0;
 
-    register_mmio_handler(d, &vpci_mmio_handler,
-                          GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+    /*
+     * The hardware domain gets as many MMIOs as required by the
+     * physical host bridge.
+     * Guests get the virtual platform layout: one virtual host bridge for now.
+     */
+    if ( is_hardware_domain(d) )
+    {
+        int ret;
+
+        ret = pci_host_iterate_bridges_and_count(d, vpci_setup_mmio_handler_cb);
+        if ( ret < 0 )
+            return ret;
+    }
+    else
+        register_mmio_handler(d, &vpci_mmio_handler,
+                              GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL);
+
+    return 0;
+}
+
+static int vpci_get_num_handlers_cb(struct domain *d,
+                                    struct pci_host_bridge *bridge)
+{
+    /* Each bridge has a single MMIO handler for the configuration space. */
+    return 1;
+}
+
+unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    if ( !has_vpci(d) )
+        return 0;
+
+    if ( is_hardware_domain(d) )
+    {
+        int ret = pci_host_iterate_bridges_and_count(d, vpci_get_num_handlers_cb);
+
+        return ret < 0 ? 0 : ret;
+    }
 
     return 0;
 }
diff --git a/xen/arch/arm/vpci.h b/xen/arch/arm/vpci.h
index d8a7b0e3e802..3c713f3fcdb5 100644
--- a/xen/arch/arm/vpci.h
+++ b/xen/arch/arm/vpci.h
@@ -17,11 +17,17 @@
 
 #ifdef CONFIG_HAS_VPCI
 int domain_vpci_init(struct domain *d);
+unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d);
 #else
 static inline int domain_vpci_init(struct domain *d)
 {
     return 0;
 }
+
+static inline unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
+{
+    return 0;
+}
 #endif
 
 #endif /* __ARCH_ARM_VPCI_H__ */
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index c313423cdcb2..94f003a07ca2 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -111,6 +111,10 @@ void arch_pci_init_pdev(struct pci_dev *pdev);
 
 int pci_get_new_domain_nr(void);
 
+int pci_host_iterate_bridges_and_count(struct domain *d,
+                                       int (*cb)(struct domain *d,
+                                                 struct pci_host_bridge *bridge));
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:29:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242715.419771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDro-00077U-Io; Thu, 09 Dec 2021 07:29:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242715.419771; Thu, 09 Dec 2021 07:29:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDro-00077M-Eo; Thu, 09 Dec 2021 07:29:24 +0000
Received: by outflank-mailman (input) for mailman id 242715;
 Thu, 09 Dec 2021 07:29:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5bTN=Q2=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvDrn-0006rO-7C
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:29:23 +0000
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com
 [2a00:1450:4864:20::131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba7edfec-58c1-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 08:29:22 +0100 (CET)
Received: by mail-lf1-x131.google.com with SMTP id bu18so10413276lfb.0
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:29:22 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f13sm445069lfe.297.2021.12.08.23.29.20
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 08 Dec 2021 23:29:21 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba7edfec-58c1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=/2Tjqi32B79jJFV5dYcHCJZi26dI5310xuMMTpxHeck=;
        b=XWZJBqluQ3NPKGVk25PLZ7QuEeaH1JDENGEiWOpz6crNOBOsrq8HovLQsDDhqAeml7
         rvlBOyn1z2MypTZRZ52bTX2cTxsAB38TIv/wSrqjgy8KT9qu5/0cpGaObt9buUUyb1tC
         tjpDSnNy9UUOBtweuOaQ0pSNRJkWKTn9e/abTcFVQ55NZirn1scyS789koraHCj5rg8o
         vnKIr45dq84BcPYD/uS/2RwKi2vrTn3hlmV2lffhu5Sj2VwikeCUpg9S7//qDVM/jGwC
         5WTjV9gkaHjzhfnlyp0WVklFwoig82Rv30jUaEyTqkWbnu4DZD6O13MLa8SzYdjOkGZq
         WNXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=/2Tjqi32B79jJFV5dYcHCJZi26dI5310xuMMTpxHeck=;
        b=04nMiJe2JQiPnOmFasZSdyRYgubAP4XAFzafWVLtxVUTFpPxthudhx8VEQUBSRzKDw
         ULyymTeHroskv4FBG2WMjX6VDyD8WeFp3jXf2FniVSxuHvbGWAS3gTqw7T4+kTmBSdI1
         3bbqNlafJyfWiZw91xEAWWFutrudUL8zUUA6sfijq1o3AgP5ho76c/U6CtVVlG/gxcOW
         jA2BMenj5biSIpOM6zVGE+54p92iZdUTgTlSdk0xfRwHiahap/YM7xJbwo65qbyS8CgV
         dVpvv/Vvxq8wiq4toRx8wombykzu6GZSUDjgVGL2Zeuhm2kpZYQ1Ukhw3TI3JgUd9ZwX
         z7cQ==
X-Gm-Message-State: AOAM532WY4mf7vbBO079iTtY7N2x0eHS2mgcbadT3BGraHqUv9TxgN1y
	nrJor5B/9jTgCZRP7jWTeDujfjW5YxQODw==
X-Google-Smtp-Source: ABdhPJz7R3UwMpl1RO5xA5oeeyQIc7DzXdSawwJPV1/vH2zpQkLuZTgviFe6bKKLCwE6gs6Fr1Zg7A==
X-Received: by 2002:a05:6512:159d:: with SMTP id bp29mr4160681lfb.257.1639034961730;
        Wed, 08 Dec 2021 23:29:21 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v8 1/4] xen/arm: add pci-domain for disabled devices
Date: Thu,  9 Dec 2021 09:29:15 +0200
Message-Id: <20211209072918.460902-2-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211209072918.460902-1-andr2000@gmail.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

If a PCI host bridge device is present in the device tree, but is
disabled, then its PCI host bridge driver was not instantiated.
This results in the failure of the pci_get_host_bridge_segment()
and the following panic during Xen start:

(XEN) Device tree generation failed (-22).
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 guest OS
(XEN) ****************************************

Fix this by adding "linux,pci-domain" property for all device tree nodes
which have "pci" device type, so we know which segments will be used by
the guest for which bridges.

Fixes: 4cfab4425d39 ("xen/arm: Add linux,pci-domain property for hwdom if not available.")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
Since v6:
- use use_dt_domains in pci_get_new_domain_nr and return -1 if set
- do not set "linux,pci-domain" if parent device is "pci"
- move the code to a new helper handle_linux_pci_domain (Julien)
New in v6
---
 xen/arch/arm/domain_build.c        | 66 +++++++++++++++++++++++-------
 xen/arch/arm/pci/pci-host-common.c |  8 +++-
 xen/include/asm-arm/pci.h          |  8 ++++
 3 files changed, 66 insertions(+), 16 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d02bacbcd1ed..6c5d22d9be1a 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -654,6 +654,55 @@ static void __init allocate_static_memory(struct domain *d,
 }
 #endif
 
+/*
+ * When PCI passthrough is available we want to keep the
+ * "linux,pci-domain" in sync for every host bridge.
+ *
+ * Xen may not have a driver for all the host bridges. So we have
+ * to write an heuristic to detect whether a device node describes
+ * a host bridge.
+ *
+ * The current heuristic assumes that a device is a host bridge
+ * if the type is "pci" and then parent type is not "pci".
+ */
+static int handle_linux_pci_domain(struct kernel_info *kinfo,
+                                   const struct dt_device_node *node)
+{
+    uint16_t segment;
+    int res;
+
+    if ( !is_pci_passthrough_enabled() )
+        return 0;
+
+    if ( !dt_device_type_is_equal(node, "pci") )
+        return 0;
+
+    if ( node->parent && dt_device_type_is_equal(node->parent, "pci") )
+        return 0;
+
+    if ( dt_find_property(node, "linux,pci-domain", NULL) )
+        return 0;
+
+    /* Allocate and create the linux,pci-domain */
+    res = pci_get_host_bridge_segment(node, &segment);
+    if ( res < 0 )
+    {
+        res = pci_get_new_domain_nr();
+        if ( res < 0 )
+        {
+            printk(XENLOG_DEBUG "Can't assign PCI segment to %s\n",
+                   node->full_name);
+            return -FDT_ERR_NOTFOUND;
+        }
+
+        segment = res;
+        printk(XENLOG_DEBUG "Assigned segment %d to %s\n",
+               segment, node->full_name);
+    }
+
+    return fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment);
+}
+
 static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
                                    const struct dt_device_node *node)
 {
@@ -755,21 +804,10 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             return res;
     }
 
-    if ( is_pci_passthrough_enabled() && dt_device_type_is_equal(node, "pci") )
-    {
-        if ( !dt_find_property(node, "linux,pci-domain", NULL) )
-        {
-            uint16_t segment;
-
-            res = pci_get_host_bridge_segment(node, &segment);
-            if ( res < 0 )
-                return res;
+    res = handle_linux_pci_domain(kinfo, node);
 
-            res = fdt_property_cell(kinfo->fdt, "linux,pci-domain", segment);
-            if ( res )
-                return res;
-        }
-    }
+    if ( res )
+        return res;
 
     /*
      * Override the property "status" to disable the device when it's
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index ae79a0c19b93..40e779b5d803 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -30,6 +30,8 @@ static LIST_HEAD(pci_host_bridges);
 
 static atomic_t domain_nr = ATOMIC_INIT(-1);
 
+static int use_dt_domains = -1;
+
 static inline void __iomem *pci_remap_cfgspace(paddr_t start, size_t len)
 {
     return ioremap_nocache(start, len);
@@ -137,14 +139,16 @@ void pci_add_host_bridge(struct pci_host_bridge *bridge)
     list_add_tail(&bridge->node, &pci_host_bridges);
 }
 
-static int pci_get_new_domain_nr(void)
+int pci_get_new_domain_nr(void)
 {
+    if ( use_dt_domains )
+        return -1;
+
     return atomic_inc_return(&domain_nr);
 }
 
 static int pci_bus_find_domain_nr(struct dt_device_node *dev)
 {
-    static int use_dt_domains = -1;
     int domain;
 
     domain = dt_get_pci_domain_nr(dev);
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 9736d6816da3..c313423cdcb2 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -109,6 +109,8 @@ static always_inline bool is_pci_passthrough_enabled(void)
 
 void arch_pci_init_pdev(struct pci_dev *pdev);
 
+int pci_get_new_domain_nr(void);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
@@ -129,5 +131,11 @@ static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+static inline int pci_get_new_domain_nr(void)
+{
+    ASSERT_UNREACHABLE();
+    return -1;
+}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:29:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242714.419761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrn-0006rb-5l; Thu, 09 Dec 2021 07:29:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242714.419761; Thu, 09 Dec 2021 07:29:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrn-0006rU-2l; Thu, 09 Dec 2021 07:29:23 +0000
Received: by outflank-mailman (input) for mailman id 242714;
 Thu, 09 Dec 2021 07:29:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5bTN=Q2=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvDrm-0006rO-AU
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:29:22 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b9e8389a-58c1-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 08:29:21 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id i63so7603961lji.3
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:29:21 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f13sm445069lfe.297.2021.12.08.23.29.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 08 Dec 2021 23:29:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b9e8389a-58c1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=71jnf3En8LBFx/Mef4yf4b2O8F4/RnDy3EDB+YBJx/w=;
        b=SMBybiqofbMs4uiT2mldWlze+jvmjC2yl52/MxGjk4NyT+Imh2v0CtMoDpRwq/RqgZ
         psz3Kg9u+ArhWH4xUnxSObdTBoBK7rEBbD3kMIQ36g5htdt1pBqr9KLW4B2wueKDWq+K
         8o2/V3Ggn1jjB2w0p0skJtX6yx8Gv9EZNIAjRbnc4fjoLejVTtGj0jH2U+aT+Oz7v+53
         br2ANBZieUhmad+8dZSH+5rPu4ghmCHQVcji6byCBKVaFSAQk8xKBVc0NlhK9dS3BmQC
         oyfdtJboQ/856Bu0BkBCcJWXsLsWsGl2ksNxNW4TA/2pFHz3dKzC8dYm2wDzXXR22NtO
         /6+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=71jnf3En8LBFx/Mef4yf4b2O8F4/RnDy3EDB+YBJx/w=;
        b=TlxGXHLYgWkhYsW45r+s7RWSvUFOoHmHa3qCXEIIaQHFZN/8jijw2CagVgC8mkX6QU
         hUBka2to9hceZDkMuWRBBiSxjb6k6dCOY/Z3L8t90Br2Xta7ZD9DhmMB1uq+aqoN5Smw
         QwLIHmeI6ykXfnA44u750ja4+qX9leL0kR2vGF2VQvDbqBK8hYpZFaCtusJYqOwaG0rl
         ztX1IvPX0LyWy0NLcHS0mOwCxlw2H5+rHQpI7DWZSFMaD36wlr28VyERrkHn7stWb19X
         5ZIrtkz3OW2cWU5U7zDYeczPQ9BiAhGlHQca/uRoUw66EehqK50+96qdmCkqTcqgPKPh
         RMWg==
X-Gm-Message-State: AOAM533xdorIh7uaRUGQ6hgkf2TYdujc7+KMArghn9sgIdC37LL2BGkm
	7G2a9wAWceoRvVnGOzyVbFBSKOYIjMwJmw==
X-Google-Smtp-Source: ABdhPJzXKTAVRsqmGQ3QvIJ4KNgTMRLe5PkFOuhVD/atU6CNXHYal7E+fvMGdNQvIYupefRmI7jx1g==
X-Received: by 2002:a2e:5c5:: with SMTP id 188mr4592336ljf.257.1639034960580;
        Wed, 08 Dec 2021 23:29:20 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v8 0/4] PCI devices passthrough on Arm, part 2
Date: Thu,  9 Dec 2021 09:29:14 +0200
Message-Id: <20211209072918.460902-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Hi, all!

This is an assorted series of patches which aim is to make some further
basis for PCI passthrough on Arm support. The series continues the work
published earlier by Arm [1] and adds new helpers and clears the way for
vPCI changes which will follow.

RFC is at [2], [3]. Design presentation can be found at [4].

I have removed patch
[PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices
as it seems that this needs more time for decision on how to achive
that.

I have also added a new patch
[PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host bridge
with a tiny latent bug fix.

This series contains all the patches which are left un-committed yet.

Thank you,
Oleksandr

[1] https://patchwork.kernel.org/project/xen-devel/list/?series=558681
[2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
[3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
[4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf

Oleksandr Andrushchenko (4):
  xen/arm: add pci-domain for disabled devices
  xen/arm: setup MMIO range trap handlers for hardware domain
  xen/arm: account IO handler for emulated PCI host bridge
  xen/arm: do not map PCI ECAM and MMIO space to Domain-0's p2m

 xen/arch/arm/domain.c              |   2 +
 xen/arch/arm/domain_build.c        | 132 ++++++++++++++++++++---------
 xen/arch/arm/pci/ecam.c            |  14 +++
 xen/arch/arm/pci/pci-host-common.c |  77 ++++++++++++++++-
 xen/arch/arm/pci/pci-host-zynqmp.c |   1 +
 xen/arch/arm/vpci.c                |  85 ++++++++++++++++---
 xen/arch/arm/vpci.h                |   6 ++
 xen/include/asm-arm/pci.h          |  22 +++++
 xen/include/asm-arm/setup.h        |  13 +++
 9 files changed, 298 insertions(+), 54 deletions(-)

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:29:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:29:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242717.419794 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrr-0007et-5f; Thu, 09 Dec 2021 07:29:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242717.419794; Thu, 09 Dec 2021 07:29:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrr-0007em-1e; Thu, 09 Dec 2021 07:29:27 +0000
Received: by outflank-mailman (input) for mailman id 242717;
 Thu, 09 Dec 2021 07:29:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5bTN=Q2=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvDrp-00075S-7C
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:29:25 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbcbace7-58c1-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:29:24 +0100 (CET)
Received: by mail-lj1-x22d.google.com with SMTP id u22so7572069lju.7
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:29:24 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f13sm445069lfe.297.2021.12.08.23.29.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 08 Dec 2021 23:29:23 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbcbace7-58c1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=5zMEfsrDMgGvbxJE8yizewP5LPSer3MoFR6+sMloccU=;
        b=nwSZwsWRKgJcOzhiHDaN4norjoJ1YzrXrGfYBPtNd/KBeTeU55r2WkRIY7FcwfkxEl
         3OdVmMtxVg5KGNCEiLnMMnFY8VPF3fwNuPnrxOLOWS8XTL4Wf14v2uo8XQhwS6aqzD/2
         GDOa8B7wR6BHtyyF7syfE7V0VW0VrR3RdjMd81J9XarQOE49cL4eHleMJgegOwmDO3vJ
         QYCV3mF0yAAg/+rn6bZsllA5vmMEF/ev0MggvvLTGMO2FhZt2eYqouG6sCuclbN5sKIq
         4DpEWLsl8kB/trlQ0zgMTPJN45daqmiY1prZ9pAA4PJuZWw9zqYvG28YCmVaC3PBxmVD
         DZRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=5zMEfsrDMgGvbxJE8yizewP5LPSer3MoFR6+sMloccU=;
        b=KHze6+SPyXlB4YIyB5o/jn10wj2X5M2Ub8l6X9aA1nWoi1cBxochsenX/N/U7Ui/5i
         GruRuDikLs9nbv2xbDcRcZnrUOUamicMrTKZX9z24EHCuzx3niO03Dd/+gEEtIL6HQmw
         6q6/NmXVDq0oegQrYQSBb98XbT4v3X0ZVsAYXeEJFO8aoa7E6085zCTAkcjHauyTeI2z
         bLKwVwEmwidSvu8/g/nHdxmUyt1epVQD+PB3R5wUbnMnIHJ0OFfSEl+qfRhH71gWo5Ml
         vKn+eVRDkFSRFxIrblNc34H9ylS1wbuW/YbXDC3x6SMwhPItmYMr8IKMUOSRK11vlznU
         5YMQ==
X-Gm-Message-State: AOAM533Jit4jLC5xiNhyBJ+XZAo/cUWMyjGA2WS0jADkmkHawiVttnyj
	adz2JFrnPC8nCxTxsAryxzkVpOKBl+0eHg==
X-Google-Smtp-Source: ABdhPJzJNMSzJKdK5Un4XS19D0FwAW7BsnV1snLB/1oEAMUDNtrotAwvFJyvrKGJFjYrYJoKKgtucg==
X-Received: by 2002:a2e:b528:: with SMTP id z8mr4648866ljm.178.1639034963970;
        Wed, 08 Dec 2021 23:29:23 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v8 3/4] xen/arm: account IO handler for emulated PCI host bridge
Date: Thu,  9 Dec 2021 09:29:17 +0200
Message-Id: <20211209072918.460902-4-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211209072918.460902-1-andr2000@gmail.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

At the moment, we always allocate an extra 16 slots for IO handlers
(see MAX_IO_HANDLER). So while adding an IO trap handler for the emulated
PCI host bridge we are not breaking anything, but we have a latent bug
as the maximum number of IOs may be exceeded.
Fix this by explicitly telling that we have an additional IO handler, so it is
accounted.

Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support for ARM")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
Since v7:
- updated comment
New in v7
---
 xen/arch/arm/vpci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c
index 1564448c6c8d..84aaaaebd69d 100644
--- a/xen/arch/arm/vpci.c
+++ b/xen/arch/arm/vpci.c
@@ -124,7 +124,11 @@ unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
         return ret < 0 ? 0 : ret;
     }
 
-    return 0;
+    /*
+     * For guests each host bridge requires one region to cover the
+     * configuration space. At the moment, we only expose a single host bridge.
+     */
+    return 1;
 }
 
 /*
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:29:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:29:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242718.419804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrs-0007wS-Fb; Thu, 09 Dec 2021 07:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242718.419804; Thu, 09 Dec 2021 07:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvDrs-0007vP-BL; Thu, 09 Dec 2021 07:29:28 +0000
Received: by outflank-mailman (input) for mailman id 242718;
 Thu, 09 Dec 2021 07:29:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5bTN=Q2=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvDrq-0006rO-Uf
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:29:27 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc894645-58c1-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 08:29:25 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id i63so7604316lji.3
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:29:25 -0800 (PST)
Received: from localhost.localdomain (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id f13sm445069lfe.297.2021.12.08.23.29.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 08 Dec 2021 23:29:24 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc894645-58c1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=/ito1eEWQVNmkHwpJtruOsgKBqnwBo2/v6MgPdmvbrg=;
        b=Ja/TMZpxrGrQUP+ZSzBbN2hdAOjQtGvOQOUZjEOIhFVo+HC2B+L4GLe59EhkYSiyXP
         164DEgQhjHVgAZh1SUiufYNfjsWAk3Opr3fSJ9adHcZPi3KXWOtgzTW1quV90uSnfUrU
         vssHNeqc81ur9mrPo7cw+c0TySnYaAs3yb67aRHWJ2gszg5TJP4Ch12wDJYmewulpoU6
         POMwcgodrpbfIehEMTR5v7TE2HKUOdWnUpGzTd4z70aGuE1u0Sm4UOe7H9NJrX0dou74
         ECRzMBIoaXCRc3utxW/U5cmYPFTlE3DJT0MQEIaz78ctktm9xIzrxUgfIztxOVZ/QG8u
         xCRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=/ito1eEWQVNmkHwpJtruOsgKBqnwBo2/v6MgPdmvbrg=;
        b=S3cSC9BOv5FmSYjMLtNr5MGmwbPNH1aG8Pkwrgy6PggAkuwy9qWWljFPgM6o4CQwRy
         Sc7CyvC0COIJvhpzLOZ8axblxIvhnchHnfY21s6/2QgF8GiSCE078jvZ7Fn+Rbgd1lgn
         zd0FtQTiCUBn+5ppja+MDGsWkSIwaKCyPN36NidIZn4Dn3vHf3xRfUi9ZTwjZ9zKJzjO
         WAnyvn5keIfF6nZ2ySIKm4SdKOq/RnbsXrlKLgIToCVqX8Ayqzw7eEUhT6QF/c4b01jH
         4z+1lse8NjDNkJqE65c409JYIaZPQimalz/LZoyzR9tdqSANYKn4toyJu7djl93CFt+m
         JuPQ==
X-Gm-Message-State: AOAM532nH8RZWgzz4a83yr4VVxQ2CQ6XHPviInHILn0rwZ5p2ZmpNpBl
	sGUUnudQEEXLpXhxUdNUC2qokHWgpWgf9g==
X-Google-Smtp-Source: ABdhPJyhr8+/Q9+L2OTLKFQw0Llkq/usPvEq6Lv0aWq/Bt1YFEajzpf+AHZRC18mfPCrycLzLfMxZw==
X-Received: by 2002:a2e:a265:: with SMTP id k5mr4489812ljm.527.1639034965083;
        Wed, 08 Dec 2021 23:29:25 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com,
	volodymyr_babchuk@epam.com,
	artem_mygaiev@epam.com,
	bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	Julien Grall <jgrall@amazon.com>
Subject: [PATCH v8 4/4] xen/arm: do not map PCI ECAM and MMIO space to Domain-0's p2m
Date: Thu,  9 Dec 2021 09:29:18 +0200
Message-Id: <20211209072918.460902-5-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211209072918.460902-1-andr2000@gmail.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

PCI host bridges are special devices in terms of implementing PCI
passthrough. According to [1] the current implementation depends on
Domain-0 to perform the initialization of the relevant PCI host
bridge hardware and perform PCI device enumeration. In order to
achieve that one of the required changes is to not map all the memory
ranges in map_range_to_domain as we traverse the device tree on startup
and perform some additional checks if the range needs to be mapped to
Domain-0.

The generic PCI host controller device tree binding says [2]:
- ranges: As described in IEEE Std 1275-1994, but must provide
          at least a definition of non-prefetchable memory. One
          or both of prefetchable Memory and IO Space may also
          be provided.

- reg   : The Configuration Space base address and size, as accessed
          from the parent bus.  The base address corresponds to
          the first bus in the "bus-range" property.  If no
          "bus-range" is specified, this will be bus 0 (the default).

>From the above none of the memory ranges from the "ranges" property
needs to be mapped to Domain-0 at startup as MMIO mapping is going to
be handled dynamically by vPCI as we assign PCI devices, e.g. each
device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
as needed by Xen.

The "reg" property covers not only ECAM space, but may also have other
then the configuration memory ranges described, for example [3]:
- reg: Should contain rc_dbi, config registers location and length.
- reg-names: Must include the following entries:
   "rc_dbi": controller configuration registers;
   "config": PCIe configuration space registers.

This patch makes it possible to not map all the ranges from the
"ranges" property and also ECAM from the "reg". All the rest from the
"reg" property still needs to be mapped to Domain-0, so the PCI
host bridge remains functional in Domain-0. This is done by first
skipping the mappings while traversing the device tree as it is done for
usual devices and then by calling a dedicated pci_host_bridge_mappings
function which only maps MMIOs required by the host bridges leaving the
regions, needed for vPCI traps, unmapped.

[1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777.html
[2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host-generic-pci.txt
[3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisilicon-pcie.txt

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
---
Since v7:
- updates in comments and commit message
Since v5:
- remove some need_mapping local variables
- use own_device in handle_device
- add __init for pci_ecam_need_p2m_hwdom_mapping
- make pci_host_bridge_mappings use p2m_mmio_direct_dev directly
Since v4:
- update skip_mapping comment
- add comment why we need to map interrupts to Dom0
Since v3:
 - pass struct map_range_data to map_dt_irq_to_domain
 - remove redundant check from map_range_to_domain
 - fix handle_device's .skip_mapping
Since v2:
 - removed check in map_range_to_domain for PCI_DEV
   and moved it to handle_device, so the code is
   simpler
 - s/map_pci_bridge/skip_mapping
 - extended comment in pci_host_bridge_mappings
 - minor code restructure in construct_dom0
 - s/.need_p2m_mapping/.need_p2m_hwdom_mapping and related
   callbacks
 - unsigned int i; in pci_host_bridge_mappings
Since v1:
 - Added better description of why and what needs to be mapped into
   Domain-0's p2m and what doesn't
 - Do not do any mappings for PCI devices while traversing the DT
 - Walk all the bridges and make required mappings in one go
---
 xen/arch/arm/domain_build.c        | 66 +++++++++++++++++-------------
 xen/arch/arm/pci/ecam.c            | 14 +++++++
 xen/arch/arm/pci/pci-host-common.c | 50 ++++++++++++++++++++++
 xen/arch/arm/pci/pci-host-zynqmp.c |  1 +
 xen/include/asm-arm/pci.h          | 10 +++++
 xen/include/asm-arm/setup.h        | 13 ++++++
 6 files changed, 126 insertions(+), 28 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6c5d22d9be1a..6931c022a2e8 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -51,12 +51,6 @@ static int __init parse_dom0_mem(const char *s)
 }
 custom_param("dom0_mem", parse_dom0_mem);
 
-struct map_range_data
-{
-    struct domain *d;
-    p2m_type_t p2mt;
-};
-
 /* Override macros from asm/page.h to make them work with mfn_t */
 #undef virt_to_mfn
 #define virt_to_mfn(va) _mfn(__virt_to_mfn(va))
@@ -1720,10 +1714,10 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
                                        const struct dt_irq *dt_irq,
                                        void *data)
 {
-    struct domain *d = data;
+    struct map_range_data *mr_data = data;
+    struct domain *d = mr_data->d;
     unsigned int irq = dt_irq->irq;
     int res;
-    bool need_mapping = !dt_device_for_passthrough(dev);
 
     if ( irq < NR_LOCAL_IRQS )
     {
@@ -1742,18 +1736,16 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev,
         return res;
     }
 
-    res = map_irq_to_domain(d, irq, need_mapping, dt_node_name(dev));
+    res = map_irq_to_domain(d, irq, !mr_data->skip_mapping, dt_node_name(dev));
 
     return 0;
 }
 
-static int __init map_range_to_domain(const struct dt_device_node *dev,
-                                      u64 addr, u64 len,
-                                      void *data)
+int __init map_range_to_domain(const struct dt_device_node *dev,
+                               u64 addr, u64 len, void *data)
 {
     struct map_range_data *mr_data = data;
     struct domain *d = mr_data->d;
-    bool need_mapping = !dt_device_for_passthrough(dev);
     int res;
 
     /*
@@ -1776,7 +1768,7 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
         }
     }
 
-    if ( need_mapping )
+    if ( !mr_data->skip_mapping )
     {
         res = map_regions_p2mt(d,
                                gaddr_to_gfn(addr),
@@ -1805,23 +1797,21 @@ static int __init map_range_to_domain(const struct dt_device_node *dev,
  * then we may need to perform additional mappings in order to make
  * the child resources available to domain 0.
  */
-static int __init map_device_children(struct domain *d,
-                                      const struct dt_device_node *dev,
-                                      p2m_type_t p2mt)
+static int __init map_device_children(const struct dt_device_node *dev,
+                                      struct map_range_data *mr_data)
 {
-    struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
-    int ret;
-
     if ( dt_device_type_is_equal(dev, "pci") )
     {
+        int ret;
+
         dt_dprintk("Mapping children of %s to guest\n",
                    dt_node_full_name(dev));
 
-        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, d);
+        ret = dt_for_each_irq_map(dev, &map_dt_irq_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
 
-        ret = dt_for_each_range(dev, &map_range_to_domain, &mr_data);
+        ret = dt_for_each_range(dev, &map_range_to_domain, mr_data);
         if ( ret < 0 )
             return ret;
     }
@@ -1901,14 +1891,28 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
     unsigned int i;
     int res;
     u64 addr, size;
-    bool need_mapping = !dt_device_for_passthrough(dev);
+    bool own_device = !dt_device_for_passthrough(dev);
+    /*
+     * We want to avoid mapping the MMIO in dom0 for the following cases:
+     *   - The device is owned by dom0 (i.e. it has been flagged for
+     *     passthrough).
+     *   - PCI host bridges with driver in Xen. They will later be mapped by
+     *     pci_host_bridge_mappings().
+     */
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2mt,
+        .skip_mapping = !own_device ||
+                        (is_pci_passthrough_enabled() &&
+                        (device_get_class(dev) == DEVICE_PCI_HOSTBRIDGE))
+    };
 
     naddr = dt_number_of_address(dev);
 
     dt_dprintk("%s passthrough = %d naddr = %u\n",
-               dt_node_full_name(dev), need_mapping, naddr);
+               dt_node_full_name(dev), own_device, naddr);
 
-    if ( need_mapping )
+    if ( own_device )
     {
         dt_dprintk("Check if %s is behind the IOMMU and add it\n",
                    dt_node_full_name(dev));
@@ -1934,14 +1938,13 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
         }
     }
 
-    res = handle_device_interrupts(d, dev, need_mapping);
+    res = handle_device_interrupts(d, dev, own_device);
     if ( res < 0 )
         return res;
 
     /* Give permission and map MMIOs */
     for ( i = 0; i < naddr; i++ )
     {
-        struct map_range_data mr_data = { .d = d, .p2mt = p2mt };
         res = dt_device_get_address(dev, i, &addr, &size);
         if ( res )
         {
@@ -1955,7 +1958,7 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
             return res;
     }
 
-    res = map_device_children(d, dev, p2mt);
+    res = map_device_children(dev, &mr_data);
     if ( res )
         return res;
 
@@ -3114,7 +3117,14 @@ static int __init construct_dom0(struct domain *d)
         return rc;
 
     if ( acpi_disabled )
+    {
         rc = prepare_dtb_hwdom(d, &kinfo);
+        if ( rc < 0 )
+            return rc;
+#ifdef CONFIG_HAS_PCI
+        rc = pci_host_bridge_mappings(d);
+#endif
+    }
     else
         rc = prepare_acpi(d, &kinfo);
 
diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c
index 2855dea213f4..6aeea12a68bf 100644
--- a/xen/arch/arm/pci/ecam.c
+++ b/xen/arch/arm/pci/ecam.c
@@ -40,6 +40,19 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
     return base + (PCI_DEVFN2(sbdf.bdf) << devfn_shift) + where;
 }
 
+bool __init pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                            struct pci_host_bridge *bridge,
+                                            uint64_t addr)
+{
+    struct pci_config_window *cfg = bridge->cfg;
+
+    /*
+     * We do not want ECAM address space to be mapped in Domain-0's p2m,
+     * so we can trap access to it.
+     */
+    return cfg->phys_addr != addr;
+}
+
 /* ECAM ops */
 const struct pci_ecam_ops pci_generic_ecam_ops = {
     .bus_shift  = 20,
@@ -47,6 +60,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c
index 84aab371cd9a..fd8c0f837a6a 100644
--- a/xen/arch/arm/pci/pci-host-common.c
+++ b/xen/arch/arm/pci/pci-host-common.c
@@ -22,6 +22,8 @@
 #include <xen/sched.h>
 #include <xen/vmap.h>
 
+#include <asm/setup.h>
+
 /*
  * List for all the pci host bridges.
  */
@@ -313,6 +315,54 @@ int pci_host_iterate_bridges_and_count(struct domain *d,
     return count;
 }
 
+/*
+ * For each PCI host bridge we need to only map those ranges
+ * which are used by Domain-0 to properly initialize the bridge,
+ * e.g. we do not want to map ECAM configuration space which lives in
+ * "reg" device tree property, but we want to map other regions of
+ * the host bridge. The PCI aperture defined by the "ranges" device
+ * tree property should also be skipped.
+ */
+int __init pci_host_bridge_mappings(struct domain *d)
+{
+    struct pci_host_bridge *bridge;
+    struct map_range_data mr_data = {
+        .d = d,
+        .p2mt = p2m_mmio_direct_dev,
+        .skip_mapping = false
+    };
+
+    list_for_each_entry( bridge, &pci_host_bridges, node )
+    {
+        const struct dt_device_node *dev = bridge->dt_node;
+        unsigned int i;
+
+        for ( i = 0; i < dt_number_of_address(dev); i++ )
+        {
+            uint64_t addr, size;
+            int err;
+
+            err = dt_device_get_address(dev, i, &addr, &size);
+            if ( err )
+            {
+                printk(XENLOG_ERR
+                       "Unable to retrieve address range index=%u for %s\n",
+                       i, dt_node_full_name(dev));
+                return err;
+            }
+
+            if ( bridge->ops->need_p2m_hwdom_mapping(d, bridge, addr) )
+            {
+                err = map_range_to_domain(dev, addr, size, &mr_data);
+                if ( err )
+                    return err;
+            }
+        }
+    }
+
+    return 0;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/arch/arm/pci/pci-host-zynqmp.c b/xen/arch/arm/pci/pci-host-zynqmp.c
index 516982bca833..101edb8593c1 100644
--- a/xen/arch/arm/pci/pci-host-zynqmp.c
+++ b/xen/arch/arm/pci/pci-host-zynqmp.c
@@ -34,6 +34,7 @@ const struct pci_ecam_ops nwl_pcie_ops = {
         .map_bus                = pci_ecam_map_bus,
         .read                   = pci_generic_config_read,
         .write                  = pci_generic_config_write,
+        .need_p2m_hwdom_mapping = pci_ecam_need_p2m_hwdom_mapping,
     }
 };
 
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 94f003a07ca2..7c7449d64fca 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -17,6 +17,8 @@
 
 #ifdef CONFIG_HAS_PCI
 
+#include <asm/p2m.h>
+
 #define pci_to_dev(pcidev) (&(pcidev)->arch.dev)
 
 extern bool pci_passthrough_enabled;
@@ -73,6 +75,9 @@ struct pci_ops {
                 uint32_t reg, uint32_t len, uint32_t *value);
     int (*write)(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                  uint32_t reg, uint32_t len, uint32_t value);
+    bool (*need_p2m_hwdom_mapping)(struct domain *d,
+                                   struct pci_host_bridge *bridge,
+                                   uint64_t addr);
 };
 
 /*
@@ -97,6 +102,9 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf,
                              uint32_t reg, uint32_t len, uint32_t value);
 void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge,
                                pci_sbdf_t sbdf, uint32_t where);
+bool pci_ecam_need_p2m_hwdom_mapping(struct domain *d,
+                                     struct pci_host_bridge *bridge,
+                                     uint64_t addr);
 struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus);
 struct dt_device_node *pci_find_host_bridge_node(struct device *dev);
 int pci_get_host_bridge_segment(const struct dt_device_node *node,
@@ -115,6 +123,8 @@ int pci_host_iterate_bridges_and_count(struct domain *d,
                                        int (*cb)(struct domain *d,
                                                  struct pci_host_bridge *bridge));
 
+int pci_host_bridge_mappings(struct domain *d);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index 95da0b7ab9cd..88d9673db817 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -2,6 +2,8 @@
 #define __ARM_SETUP_H_
 
 #include <public/version.h>
+#include <asm/p2m.h>
+#include <xen/device_tree.h>
 
 #define MIN_FDT_ALIGN 8
 #define MAX_FDT_SIZE SZ_2M
@@ -77,6 +79,14 @@ struct bootinfo {
 #endif
 };
 
+struct map_range_data
+{
+    struct domain *d;
+    p2m_type_t p2mt;
+    /* Set if mapping of the memory ranges must be skipped. */
+    bool skip_mapping;
+};
+
 extern struct bootinfo bootinfo;
 
 extern domid_t max_init_domid;
@@ -124,6 +134,9 @@ void device_tree_get_reg(const __be32 **cell, u32 address_cells,
 u32 device_tree_get_u32(const void *fdt, int node,
                         const char *prop_name, u32 dflt);
 
+int map_range_to_domain(const struct dt_device_node *dev,
+                        u64 addr, u64 len, void *data);
+
 #endif
 /*
  * Local variables:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:42:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:42:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242748.419816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvE4M-0003ba-So; Thu, 09 Dec 2021 07:42:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242748.419816; Thu, 09 Dec 2021 07:42:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvE4M-0003bT-PR; Thu, 09 Dec 2021 07:42:22 +0000
Received: by outflank-mailman (input) for mailman id 242748;
 Thu, 09 Dec 2021 07:42:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvE4L-0003bM-TQ
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:42:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8a616809-58c3-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 08:42:20 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-XjtuEnkwNvSlYP5qrZr7rA-1; Thu, 09 Dec 2021 08:42:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 07:42:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 07:42:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR08CA0034.eurprd08.prod.outlook.com (2603:10a6:20b:c0::22) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 07:42:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8a616809-58c3-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639035740;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oTUPdzdnBXfPKSm8mLG1WkWz9XNaOGoTyoL2AQTo36o=;
	b=Lp/NKTakbkEyX4e6INjuKG0PpieUDBrkKZk4iv9eskb+Ys60iAtwZFj6NBwh3Z+4qTzlXW
	GrQe7d44Jq4BNPbluFETNBbn/sfcwTZO6qYqGDBpPIzueSi3Hjc+VPv5D3BIgF+kIJjtn4
	6/a9gfMbXzGaUsairom2yHLIghitI8Q=
X-MC-Unique: XjtuEnkwNvSlYP5qrZr7rA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IyptaMZyYwdRRjo8CerDLvM5JteCBQw6LRsowUNEQta7CFlFiFMZi948LRVAxeFAEEeuXFqWClOXFCF+t8AdPD3wNo/BC7JcqZOMHJFmkyROBTVfcsL5QFc/DhCsy0XrqBEHepiXMunbVpsO6fSdTo/P7ZDAPU7nAODG4dR7QTgan9L0fedUb+EMr73s2e6NWkQLJvj6Salh3+ABSN5nG8r5c3GIc60EXfq4h7BMWaNVXB+HOxb4raDzUr6dPTLoW7jH+l0T3If37DAVWprxAFOxXbh6FTHqTbLktvQm5oEdeQwouwdX7BfYTP8BLiag63gtSMtE8wZk9oK6pfYgOA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=afy0kI54gIUjviHx00A3H7rP+W4FLZMtjjoh+bwDsJQ=;
 b=ENZndmKYEiFbYFVg5UOGybi3FAODoCqf7I+k1IsddLabKLdgbyn0um3BjDqNt6KUX2aQd1PMvtkuqK7YTc2w7i/y8HIMGGxgv4qGDUQ5znhn0QyZnmrsiMTNv3CZzdXgHQw7iV+iuLLD2VH4txdxpLM4QjyvGgUru/jMMbwDYL5ICnoW4wbQ914pkKrph/EbBAZ+OdUpTIuxh6BMSuPuB1k1oSUs8F2ikKPeQHik8EV4okm7kBHYeylQjd+5dBCdBn/OWkaRgdI/3Z9at6jzYOTSvlurqUq1JCCzVDs1JsBbexLaKmKphHouhK1eXqTlWpkURPwIXNnfUSxr2bXddg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <36495d64-ea6e-3d2e-18b3-ff441e3c835e@suse.com>
Date: Thu, 9 Dec 2021 08:42:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86: avoid wrong use of all-but-self IPI shorthand
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <935688c8-c971-53c7-4c27-f34a841168ec@suse.com>
 <1f06e98d-ab69-09b1-d460-f863827713ec@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <1f06e98d-ab69-09b1-d460-f863827713ec@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0034.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4cdd2671-d30b-4167-9cc7-08d9bae76d08
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB260778B67D11C002393A24F3B3709@VI1PR0401MB2607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fXA+Odeg2wr77Xs2F4PDrl4q6oLB/fgrLykEiHJKVeiJgJhFsFJe5WpqFEdiGk1kwfsPtaZcZ5sTYA/LiR4DddXu8gXkPtdfnr0FVxG0GR/6J6DMwAqVHpgtT/CmBX0bVZBiuukkt/b3AdyYYh6+8VHniDC4A/DGQGjb4tid1Uc9Ni7doYmngU4Gz7dUPWVVnAuX+b+/U180uyPvZkL54JBygp2uU3npGzaS2TEHyAyUsmFolAyRnujm5HBKcrGtfNUrZ/BufJ/RaYgde39DgJ3cWct7rZ+oQgqhBmo0oxkxqy/VYZrbxCtUc0J8GjykAIldls/f2lxgKkHuqV+PvwOspV4V2NafG5nvB2no9OyDVpnqy5/GWVXGTch2z28QjP86cHoREhH9o6NLmrCsg8gf2h0oGb+DXxVtdkw3rqAVvzwnS4g9Kq0hNytd0ZV/7SHgVoXblJOVcVg4Q70ZUbWScJI7qqNBQr5BHAXDMMi1MULDJZgQEojNg4Uv4/sVvRljevH/8y+Y9OINMaZNZw8J8oONaxQFNngHBMXGm6btkMRhomoaRosJtJhGdMBSuXrkDMtJeiObzpJf+iuwjuHtoknWjkSU41xjr2nNlF2CmEoxIPBl0o+EPfG07FQ3UzTbdlvLWy12P6LhfcruoRtT+EnY3va2WQ1lKpDVemjJo3fdMC9mFFzbV1BdnFgEfUC7obi3XtGtdkulz9rpCu1Hgy8jLTBf6mEM1XV2SMk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(36756003)(4326008)(2616005)(6486002)(66556008)(5660300002)(66476007)(8936002)(8676002)(2906002)(53546011)(31686004)(956004)(31696002)(6916009)(86362001)(508600001)(66946007)(26005)(316002)(38100700002)(16576012)(54906003)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hcJGM6W3c1y1qX6K7wH+MRFL9vOVMMTHB5LxZuMBjYxJHxcmmGJ7j8VwDf3p?=
 =?us-ascii?Q?slVmaEMwYEZOy/Q7QDibaZPFrjrSqw3V1BWsNqJAat+kapjNrdT9atagZghj?=
 =?us-ascii?Q?GfPAzWmP7JicynBHjtGySbIaLX7zyfV4/mnbqlWzUtnYIzEWXDnQKMhS2Svi?=
 =?us-ascii?Q?ycLSa2dXTqXtMmn/lQYMe6642SzTMhjLiUbHTBs+nQXmO/OrSgd8XQgMv3vs?=
 =?us-ascii?Q?iDbMSMrUhEL5v5kF/UV+PZpm5MSKhuxxB2R08XtRodSWQcfJj3WZw2qjGNAf?=
 =?us-ascii?Q?0fpKaPJzTnGpzeQnh+cizowf6kpz72OvZVELhcPKCjSZyaUzo/H0dIBO0Adv?=
 =?us-ascii?Q?7tXDZuYvlPQniXxSc3NYQ6dlp3adDQcTXlbbzfjIe3Bl50VPDD+iehP4sQ/t?=
 =?us-ascii?Q?pVJB37vLhJ64Ha5MY3vPjkEO8Nrr06t13VMoIlcHi54M0RkW1cO8Y9UtseyC?=
 =?us-ascii?Q?XGLJZHKlkNqddEGiM2ZMgYs6+frjV2aHUupcDobFae3wV2rkdL5CcWhTRuRU?=
 =?us-ascii?Q?Pki5B8sU7dTV1UrKf14YwNMsSphAu+1XMiSxJxWGGdCWsHUF2h4WTLnvR5ot?=
 =?us-ascii?Q?hml96gkhpvuqQysWK/fEEMElraKB3mvQGW8pn7rYO9urPAn0mTTPdPXZGJr8?=
 =?us-ascii?Q?48sPeyCssxT6Ko2Zk2yNJ1AcliUnH0F0Ew8h64Oc3L/E7BgrVUXpPsEz6L/P?=
 =?us-ascii?Q?UixrGrCXF6Oym7R4e49JvqNHo1jWXT7dEiOCb0wdyfb+f2Pi+6v87hebRKe9?=
 =?us-ascii?Q?/OrC3H+mxdXb3gEhHKsbYyTCoYBLAyzcQyg//AtwbydLDlUE8sbTB1uxfthj?=
 =?us-ascii?Q?v/HwntAQb6T5nmq7zrg5jUfur8/VwiQFB4LAbqGx9SEOq0W/mOMRzVBEuJoW?=
 =?us-ascii?Q?DrssfRagwF31Wa0o75lwWmxzIixkauTZm/CkpzRTh3vypDIk6dXKGKneozuv?=
 =?us-ascii?Q?80jtgBDgETzqHnDhb4J4sgIOqikVAhhvcujTT/sxd4R3/baSmESpUTSPdNUg?=
 =?us-ascii?Q?p4Ggrh0Z+GahNV8WwbK1aPh+0RqK+T+uuIjTxpiU0uVxiZLdYImNxok3fxKs?=
 =?us-ascii?Q?c7uZMW4nxRdH7dTZ4zVuyWPHlhieh4fg40AtWQyn4jrr8efq3f1MEUFOB3T5?=
 =?us-ascii?Q?5FGRNnxcHv1iyEJhdCFZxttoW6pSCAsc2amc4HNupXNkDNckXeCCen78p2X7?=
 =?us-ascii?Q?BJYUQEn0WHa62zQTHbkG+NoqDNkC5Ule49jQ+MbTCZJMyLTxQNLR/Wx6c7Zl?=
 =?us-ascii?Q?GIwgSDqMr5qFJx4nQxuQqppYcWcKyEE+XXfpcQWEyO4aSHECF2ovE9uPvYDk?=
 =?us-ascii?Q?WQUqs2xdoSl+U0DtgrsKbDnmyUUUwxqyWwwU2uVMYXllCOsmZigCTdlEhZrF?=
 =?us-ascii?Q?2bwlLt7noNMg7As8xEwMAiLtUkk18LWUSYveLmEN7rHZtdAbSJU2SOiQyHN+?=
 =?us-ascii?Q?Uc0BkjqNaEof4ktYjzan9Assbjn/UW1PAGXeDONSfP8Wc6hrbORSj9wt1EnA?=
 =?us-ascii?Q?O3cwa8XcaGWeqFYvek0uI7GID7tB+PDLNOOfwY4BI2BXc+wu/cUvBVhDWox6?=
 =?us-ascii?Q?ab6DWT64+mpevfld2ThXdmFkHCNrquHwPmTCScmIYTTzRB1Ib/VRJNvv2eCx?=
 =?us-ascii?Q?BmihunMK+gjINe0zZxAk3fU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cdd2671-d30b-4167-9cc7-08d9bae76d08
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 07:42:18.0807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NfKbOy3EoJkx8Eql8vbR92/3a6iLUOmmGd1Sv+l9vafIVzbCbQqrc532F8/JPuK0EhfyNHZkD6icjgxMSx1+vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607

On 08.12.2021 15:16, Andrew Cooper wrote:
> On 08/12/2021 11:47, Jan Beulich wrote:
>> With "nosmp" I did observe a flood of "APIC error on CPU0: 04(04), Send
>> accept error" log messages on an AMD system. And rightly so - nothing
>> excludes the use of the shorthand in send_IPI_mask() in this case. Set
>> "unaccounted_cpus" to "true" also when command line restrictions are the
>> cause.
>>
>> Note that PV-shim mode is unaffected by this change, first and foremost
>> because "nosmp" and "maxcpus=3D" are ignored in this case.
>>
>> Fixes: 5500d265a2a8 ("x86/smp: use APIC ALLBUT destination shorthand whe=
n possible")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Thanks.

>> ---
>> While in "nosmp" mode it's probably benign that we switch to the bigsmp
>> APIC driver simply because there are more than 8 physical CPUs, I
>> suppose that's inefficient when "maxcpus=3D" with a value between 2 and =
8
>> (inclusive) is in use. Question is whether that's worthwhile to find a
>> solution for.
>=20
> Honestly, the concept of "nosmp" needs deleting.=C2=A0 We inherited it fr=
om
> Linux and it wasn't terribly appropriate even back then.
>=20
> Nowadays, even if we happen to boot with 1 cpu, there are normal things
> we talk to (the IOMMUs most obviously) which are smp-like.
>=20
>=20
> None of these command line restricted settings can be used in
> production, because neither Intel nor AMD support, and both require us
> to boot all logical processors.=C2=A0 Everything playing in this area is =
a
> maintenance burden only.

But you realize that "nosmp" (nowadays at least) is merely a shorthand for
"maxcpus=3D1"? I don't think you mean to suggest to delete that option too?
What we did remove long ago, matching what you say, was CONFIG_SMP.

One aspect of my consideration, which I realize only now, would be that
then we'd have a way to test "flat" mode even on larger systems. This may
be relevant with there being less and less systems with no more than 8
CPUs (threads), and hence that mode probably already hasn't been tested
much.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:46:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:46:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242754.419827 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvE7o-0004GG-CB; Thu, 09 Dec 2021 07:45:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242754.419827; Thu, 09 Dec 2021 07:45:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvE7o-0004G9-8c; Thu, 09 Dec 2021 07:45:56 +0000
Received: by outflank-mailman (input) for mailman id 242754;
 Thu, 09 Dec 2021 07:45:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvE7m-0004G1-Jp
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:45:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0936fc01-58c4-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:45:53 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2057.outbound.protection.outlook.com [104.47.14.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-qUiTNO2BOV6QCWTftWwzsA-2; Thu, 09 Dec 2021 08:45:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5167.eurprd04.prod.outlook.com (2603:10a6:803:5b::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 07:45:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 07:45:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR10CA0011.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::24) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 07:45:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0936fc01-58c4-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639035953;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1oHTvZmps+H1bsjd5GhQPFpG7SLzKm0FF6vDkEGobnQ=;
	b=OvFlQUA1M4iDvT/uqgavf/FMdUunbOH5U91G7oigzjL4D5iOPFhKtsQYxi/JJ/t+nwbLzY
	5nu/L4DMXxyRRC5hIKqsL5O8buDJrVEG87RtZjoGlV6XC95ctc2PKxNJK+wFKp4BB2k/4d
	2WtKM1t3Wc3/GXzhs+M4gqvv/4wZ7Nw=
X-MC-Unique: qUiTNO2BOV6QCWTftWwzsA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bFGx0jciAe20Rll0E1+Td+k2tpuab4TOeN/K2Rerwb8j0s5NS3zVi0S1j649qykSgXq0J9N/iwbBtfoQ62HoEvZGkT1/ULiPd52IbDN8tmo8KCCxHBOCzmcX421DVoXB8PIn6oUDKz+yx94K0mgapcR/zBtkD1uOQg8o5VvKMbe4wICNpnWKQtMai8ny2oE8h9x2GHd3z6Vso1imN7VKo2qSzuxDgd7rDpnrNDTszhBeDCYjw5Kh5nLZBAOKgGAgda4vW7vt2kbF1fyLUoP+i9jA0V5b1H9MsNFcAz79RaOIdk4q637yomFXEjkylkVlZB0ELHGzbF97iNfR9reQUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1oHTvZmps+H1bsjd5GhQPFpG7SLzKm0FF6vDkEGobnQ=;
 b=Mq/MF0HRgkkxNuAk9eCi2j6yiuOKVb9TVdjuDPP8cJiqWI8zikQ55Sh2oW2nBF3GDcwNpl5uNQgIGW0UvAUZXZhr3eUkE80hMrS0Ez8lmImBqKVdIla3IQiUBppdwQ6xJ3Ep8b8sxUIgZqZGOyy7A1xft03Vzu8HgP2nT54rSwOMp06++Qfe05qeBTXrPau7fnRKfGjOk+FNMcTiDOfqRe/5MoRDjF1y+tw0n99waMh9xRxTKT/NHas6KAoven3hG9HcGgfuczjo9ytXP7gEasy2o6W3BI8gHdJCwhcR1c5bd0Ei54oHDQ7a/MtMkJr+D4TiABMQxM9baaHdtD5YTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <20197632-d8fb-a5a5-2a29-9af261adc8e9@suse.com>
Date: Thu, 9 Dec 2021 08:45:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] MAINTAINERS: widen Anthony's area
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Anthony Perard <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Ian Jackson <iwj@xenproject.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
In-Reply-To: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0011.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f06cb3ac-04de-4df1-596b-08d9bae7e9ff
X-MS-TrafficTypeDiagnostic: VI1PR04MB5167:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB516764B09BC8EE49FD6E6B3FB3709@VI1PR04MB5167.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/ObBGjo0TfSRPAFl002tw2qE0gCEQzqutWeGVQar69QTt5Fu3EuzJFGbnCEnPdm78LqqT+bHScxGNbcq0tXtCCcNV10LHUYS/76aQg1avkYMrDs49AR/wntf1kY2DRDN5SLC3I09b+9v+S6zJWgoa/BepxLrTfSGNYKfUFmQqMWPKHBOzyZsVPEYOoITo8oWj7xynzpii9u4MIBvUPTp8xbzBQemnUZPr/57F/MZ41666pf3Yr+uPYDhy6BPrJ2diw5096VHn9WDgCXr5cfcRP+12OidRA2nAkMRclauPQ9iLHlnyltzsNvOzmLS54CPLEVDy737BVCigoqF/uyC+JgGrk3UmzQhkCcz+RQjI2lJYovpSk/zoK1Am31YNFdVPvFBC23emZ6apb3ZM4G+vfWYYBJARpgYL1bTKCvaI4cd4nFoFdzQfFSB0bKUhvywBF+KTDwkY8DVZadJxm5qXEwD2mGyLH2BcERCZdM7l6HV+L+89JcptE8fGcLrmJKmZNhsxvR3hMJeCvKxPJYErKOrOk6sEDCifQO9Tocxz7Ng+7gPJbV/C42+CVMX0WEwFkmR8EjHAc58mNgHXgEOde4lgIcl6nDYKIl8ksQCqSSW4fqJ7fNqGkNssUgoNc6y0fUtn+DD+IWInJ5bwXpLcDjf4whhYxfgWNzlOPJSVdXbAMbV2sLvTiu33McQQ0+PKWzTJlQVLkKO4s5ahV7GW1dZR2DbkJVG6v76Rjy2802+31Mq8VHWnjV9e1Fe2RLk
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(36756003)(6916009)(8676002)(53546011)(6486002)(508600001)(2906002)(83380400001)(66556008)(26005)(186003)(66946007)(4326008)(66476007)(54906003)(8936002)(2616005)(316002)(5660300002)(38100700002)(956004)(31696002)(31686004)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NHVyUHpUNlBvQ0tvNjVMY1pVVlBuRldSQXVFbS9VR3FEZWE1cXhiai9aNy9X?=
 =?utf-8?B?ZHhZbGJBdnVacGpCTzloWmJTZDB0MUVkYTlXWlBMdVFJempzUUNMRzYrVG1O?=
 =?utf-8?B?MmZveTN0VGtRam1lM0tPOU01eHVuVFZRWGM5L3gvY3FDWndyUTYyRDVjbXo5?=
 =?utf-8?B?aUJpY05saHBmWGZPeEJnU0g1UnM0MWEzY0VQTHk4Y2xuV05JRkNiTi8wR082?=
 =?utf-8?B?UWk0cmZaRXNlWVlqT3ltOGxKbXJ1TE44K1RrK2x2cHNsSytBSGRxZ3JmZW13?=
 =?utf-8?B?MWJzLytONEpDS1pnQ20zNUVsV2pBeXo1Y0VRM3AwRm5JenpSUzJDQUFMQ21I?=
 =?utf-8?B?cUZsR0t6WDlFRjNacEFaY2dpY3A3R0J6c1hGbGpjZlloQUY3d0IydHB1MmRq?=
 =?utf-8?B?SDZYSjZsQlFSWlNmeEg0bmtzaUhvQ3g2SG14SldXcWtzc0xvN1BHRlhEdHFZ?=
 =?utf-8?B?bjdXcmJpZ04vQ2RDSmtFZHRIbkE1cDBMZVVRVU1RejVmSkZORzJQaEVFV2d4?=
 =?utf-8?B?bTU1KzdnVHRYclNBTTdKN2JlN250MGptUXdiRm9QZHpvY2wrSGlRL1l2UzRz?=
 =?utf-8?B?Mm1ZbDQ2MmJOc0dyeUZ3L2RmT3dTYUR2Sms5S3RNTWFhOEFodTZERGZueUtw?=
 =?utf-8?B?UHlMRndreFRscFk4eEpXUUE2M1U3b0pzK2FmU2k3Y0dqVlErQ1FvL0NSa3l5?=
 =?utf-8?B?R0Qrc1B1d1ArZmpUcklxNHhsMjZYVXdrMVc0WUJKZUdKNGlUSVJiWk5mc3RL?=
 =?utf-8?B?cW54T2lWZE9WeWZRdHpCUGR6N2ZKc1JMSmVSSWdsSmNzTWRDRVoxaVkva3Ur?=
 =?utf-8?B?QS9CL2kreE5yNHBKT1pxNUVtZFFsb1lxbCtQYWZiMWZVT2RVL1lORTRwa0Ja?=
 =?utf-8?B?VitncG84YmJ6cm1menRtamRJK1ZjUkhXMU5FaVZYS1h3V09KeDZGdE9SU05C?=
 =?utf-8?B?N0JoSGJ1bFAycWVjdWNtbEViczJwTHVJdXY3UEd0Smc2UjBkekk1amVGQlRS?=
 =?utf-8?B?ZTFWelBiNzNielJZWHhGQWE5Tks3Vzd1Zzg5OGRZeWl0Q1Arby9FV1ZOQmh5?=
 =?utf-8?B?djZ6L2t0ckhKcDZCQ0UyS1lydzBEYUkyVEpLTjJmcjY4Q3J6VUZ1NFFMN0hP?=
 =?utf-8?B?T1U3c09pdjV5M25aUHNXY21IbVp3dXBpSEdMNHhTZ2NZUmJIN3hGMUVUdmdL?=
 =?utf-8?B?NmpOc0hKQ2o2Tjg4QlVjRGRxT0I0b2ovcmhPdHBhMEY1SDhodDluaklRdjRs?=
 =?utf-8?B?b1JKQ2kvUkRmWXNWY0VuMEQ3V0xzQnIyb1lpWkFOM3Erd1QyODlnL2dBZTh1?=
 =?utf-8?B?aWVVbEFiRFBzWWFxemRTd24wQzNHbFBTWUpoZUtSWjUzQTAwdW1JRXhDYVJS?=
 =?utf-8?B?NVR6VlI3YkdvMkJQTHNOdjQ2OEpKNzNiSXlpZjN6emFqWWFWTFhaai82VVRt?=
 =?utf-8?B?am9pcGpnV1B1ajdmRy9YL1pRYUdoZm9BcmNrTC93Yno2S3BOOHp3TEdyZGNI?=
 =?utf-8?B?TzFTVnJtRVYyeXI5K1dOTzE3cFNuNFRqd2JDdXJlMTVRM2NQcnJySXkrWlQ4?=
 =?utf-8?B?SytWa2NLRTEwamx1RXBsUy9CeVRLZE8zM21PbEN5SjAwbVRMNlBFVVIzSTZa?=
 =?utf-8?B?MTMrQTg0VE1FQjlJYzhUMmR1aUk1SzhXV0FTUmNXRmpWUUFodkhWd1lxeGpW?=
 =?utf-8?B?WTR4MjBLVXk3NVFzcitxOGszUDNoQjJhZEV3MGVHQnJIM1VTRGlHYklLdGo0?=
 =?utf-8?B?aVJ1VWlyVzBZSkhHZVV0OHljbk5HYVdib0dKRnk2TU9mRHBmWU1MMXBiVEMr?=
 =?utf-8?B?NnBlbEJKdmttSzBqcGVLV3JWQVhhOXlwUE4xT3ljUGQvYXhiK3owNm5WbHNV?=
 =?utf-8?B?cndtQW5GLzg5NGtqWWI4cmUrREtZSGlObnBlTlFxMGNqZUxsMXgyQjJzZTFt?=
 =?utf-8?B?QndmbGhxczBseHVJVjhpV0JJL3hNakVVTHowcFdsYXJHREkwU0NSVVdXNDlo?=
 =?utf-8?B?MWRxYXNnaHllZVd6ajdGYytMV283N3RtYkZDeitEYkdQYy9GQmV6WmVtSkIz?=
 =?utf-8?B?N2xkOS83K01jclFrRTRBVVk1aUFyVmY3aVlaa1AyWDJRRFhIbEpEWEVhMmlh?=
 =?utf-8?B?TWFZZnF6OVN2UllDakF0WTFDRW5YaWRpaSs0MWh0MWU2bkIxR3RKajVmL2Mx?=
 =?utf-8?Q?uGj+SaXhfFrbO9Avlxt70So=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f06cb3ac-04de-4df1-596b-08d9bae7e9ff
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 07:45:47.7272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a7dKh01u6WNeHwJgC9Mq2CXGQRq3/ZI6jtDwwiXz+G7SbY25o1bZ4vUCttVxinykBCNoH8PtzZ4IhbgoOQpwOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5167

Anthony,

On 08.12.2021 08:07, Jan Beulich wrote:
> As was briefly discussed on the December Community Call, I'd like to
> propose to widen Anthony's maintainership to all of tools/. This then
> means that the special LIBXENLIGHT entry can go away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I'm sorry - I realize I failed to Cc you on the submission. Yet to
have an indication of your acceptance, it would be good to have an
ack from you alongside those from Ian and Stefano.

Jan

> ---
> Note that we're still looking for a 2nd maintainer there, considering
> that Wei's time is rather limited.
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -375,9 +375,11 @@
>  
>  LIBS
>  M:	Wei Liu <wl@xen.org>
> +M:	Anthony PERARD <anthony.perard@citrix.com>
>  R:	Juergen Gross <jgross@suse.com>
>  S:	Supported
>  F:	tools/include/libxenvchan.h
> +F:	tools/include/libxl*.h
>  F:	tools/include/xencall.h
>  F:	tools/include/xenctrl*.h
>  F:	tools/include/xendevicemodel.h
> @@ -393,15 +395,6 @@
>  F:	tools/include/xentoollog.h
>  F:	tools/libs/
>  
> -LIBXENLIGHT
> -M:	Wei Liu <wl@xen.org>
> -M:	Anthony PERARD <anthony.perard@citrix.com>
> -S:	Supported
> -F:	tools/include/libxl*.h
> -F:	tools/libs/light/
> -F:	tools/libs/util/
> -F:	tools/xl/
> -
>  LIVEPATCH
>  M:	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>  M:	Ross Lagerwall <ross.lagerwall@citrix.com>
> @@ -514,6 +507,7 @@
>  
>  TOOLSTACK
>  M:	Wei Liu <wl@xen.org>
> +M:	Anthony PERARD <anthony.perard@citrix.com>
>  S:	Supported
>  F:	autogen.sh
>  F:	config/*.in
> 
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 07:50:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 07:50:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242759.419838 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvECJ-0006A3-To; Thu, 09 Dec 2021 07:50:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242759.419838; Thu, 09 Dec 2021 07:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvECJ-00069v-Qe; Thu, 09 Dec 2021 07:50:35 +0000
Received: by outflank-mailman (input) for mailman id 242759;
 Thu, 09 Dec 2021 07:50:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xsbi=Q2=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mvECH-00069p-UO
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 07:50:34 +0000
Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com
 [2a00:1450:4864:20::32d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id afcb0ab0-58c4-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 08:50:33 +0100 (CET)
Received: by mail-wm1-x32d.google.com with SMTP id p18so3447819wmq.5
 for <xen-devel@lists.xenproject.org>; Wed, 08 Dec 2021 23:50:32 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id o4sm6346279wry.80.2021.12.08.23.50.31
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 08 Dec 2021 23:50:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: afcb0ab0-58c4-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=Mb9rhS4NHaU/VS7Z5fHLKjttyLLnplEcywRYUi/Ow44=;
        b=BjFrOAd+UAARpV7A3cVIRmE1hsW6hI1FyfWJ0xJmkZBT8eA2cYuyVsKlwcFv3gX5tO
         jw4pjZ4vtvfKXAlVHrJKrlrTbuI9zm+rwOFRUV/+s+shLwNeLWzSgfyNEIpE7tZl6ZoW
         MWHWlPwkKICobW+RjRUWuQtaqAY4emXdib+ds1PMk3ge0bW7GIHeXUy32zN6ppXMPR/x
         uabQpDI1v/M/QQVRtQ+O6jrHE4bYy1TgW5L0QEAAFcK+tDkIho6hIsIwYRwSVfJrTOvg
         ult7MxWsFDkZezSGk8pfP76JzGQiNIzQNWOv4KGHV8HX6RaH7YVe7QTebPaecu7lFcov
         n9BQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=Mb9rhS4NHaU/VS7Z5fHLKjttyLLnplEcywRYUi/Ow44=;
        b=kcY184FVFuVGL8ZP2wbKUz96bY3O6TA+fYHp0NTHkUxuj3Ts558Ua/C3FqbQAWP/nB
         EzTAVIdbwMIDv3XnlkggnuX7O74I3rILnJxLN/I8p0zEIR+E+o0UJeOxwpXBE6oNbs3E
         EqnjkX3h90Fd7xNkU7FSzEqpZ60SLXcV4A4EjnuZQPuaTczRBkxdQco1vRHDmgLml0Lc
         SVoFYpv4P1gE8TglvKeF9fqUkU1isBpf3KWy7PetFF0DOXUZ980y5LOPsPZdlFAYbhxT
         8kBD2HFKtSgA5MgpTeCiF0FrulKjSAvO30xE9vXXtZzOijZ4nXSG/KGDSzMB/J9uYoxy
         F5AQ==
X-Gm-Message-State: AOAM533X5ycYlDRuHuYUfbU07Q8xpvRY396SenVA649A4bL84tp/ymKe
	5GPn6v/WjEnHIY5ouiMEESk=
X-Google-Smtp-Source: ABdhPJy8G++4wljNS3tZuaZqbtBL8bRCBeRZjBpHxYqtuBQtjb2Kasy7pMGgpj0NktcAXNvg8puPWg==
X-Received: by 2002:a1c:a7c3:: with SMTP id q186mr5354872wme.20.1639036232495;
        Wed, 08 Dec 2021 23:50:32 -0800 (PST)
Message-ID: <baee00d2-78f1-4df1-b9f7-6ab482011f33@gmail.com>
Date: Wed, 8 Dec 2021 23:50:31 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 Manuel Bouyer <bouyer@antioche.eu.org>,
 Simon Kuenzer <simon.kuenzer@neclab.eu>, Paul Durrant <paul@xen.org>
References: <20211209070942.14469-1-jgross@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20211209070942.14469-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 08/12/2021 23:09, Juergen Gross wrote:
> Today RING_HAS_UNCONSUMED_*() macros are returning the number of
> unconsumed requests or responses instead of a boolean as the name of
> the macros would imply.
> 
> As this "feature" is already being used, rename the macros to
> RING_NR_UNCONSUMED_*() and define the RING_HAS_UNCONSUMED_*() macros
> by using the new RING_NR_UNCONSUMED_*() macros. In order to avoid
> future misuse let RING_HAS_UNCONSUMED_*() optionally really return a
> boolean (can be activated by defining RING_HAS_UNCONSUMED_IS_BOOL).
> 
> Note that the known misuses need to be switched to the new
> RING_NR_UNCONSUMED_*() macros when using this version of ring.h.
> 
> Cc: Roger Pau Monne <roger.pau@citrix.com>
> Cc: Manuel Bouyer <bouyer@antioche.eu.org>
> Cc: Simon Kuenzer <simon.kuenzer@neclab.eu>
> Cc: Paul Durrant <paul@xen.org>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> I have checked Xen, Mini-OS, qemu, grub2, OVMF and Linux kernel for
> misuses of the RING_HAS_UNCONSUMED_*() macros. There is currently only
> one instance in the Linux kernel netback driver. The BSDs, UNIKRAFT
> and Windows PV drivers should be checked for misuse, too.
> V2: make RING_HAS_UNCONSUMED_*() returning a bool optional (Jan Beulich)
> ---

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 08:25:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 08:25:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242769.419848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvEjg-0002xB-Oj; Thu, 09 Dec 2021 08:25:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242769.419848; Thu, 09 Dec 2021 08:25:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvEjg-0002x4-LK; Thu, 09 Dec 2021 08:25:04 +0000
Received: by outflank-mailman (input) for mailman id 242769;
 Thu, 09 Dec 2021 08:25:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvEjf-0002wu-3a; Thu, 09 Dec 2021 08:25:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvEje-0004vz-UZ; Thu, 09 Dec 2021 08:25:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvEje-0005OG-MH; Thu, 09 Dec 2021 08:25:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvEje-0000FT-Lp; Thu, 09 Dec 2021 08:25:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ONiIzZsplj6DoiHkSsczJ6qSC0mLQTHouPcL/aWGpGw=; b=K8MaCGUS/X7OlGLhj8pzzboEX2
	i9EE+atPX4hYFARZfjOf2rUGkfV5ka0Okko+wOypFgTU9x21BqMrZXz0f8b9AiOQIXTLb2+W7cwTK
	B/DndA8IbEVWsREzmDbVmrFR0MnFS2p5fOkTpDT08n3mnQlDBSnFjohM6Wm7yvbxPyCA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167239-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167239: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
X-Osstest-Versions-That:
    ovmf=7b2831000894f3091cac633e61d9bcf3661cc44b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 08:25:02 +0000

flight 167239 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167239/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
baseline version:
 ovmf                 7b2831000894f3091cac633e61d9bcf3661cc44b

Last test of basis   167237  2021-12-09 01:10:49 Z    0 days
Testing same since   167239  2021-12-09 06:23:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Huang, Long1 <long1.huang@intel.com>
  jdzhang <jdzhang@zd-tech.com.cn>
  Long1 Huang <long1.huang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7b28310008..c82ab4d8c1  c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 08:44:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 08:44:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242784.419863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvF2D-0006IH-EH; Thu, 09 Dec 2021 08:44:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242784.419863; Thu, 09 Dec 2021 08:44:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvF2D-0006IA-BK; Thu, 09 Dec 2021 08:44:13 +0000
Received: by outflank-mailman (input) for mailman id 242784;
 Thu, 09 Dec 2021 08:44:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvF2B-0006Hz-Hx; Thu, 09 Dec 2021 08:44:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvF2B-0005Fz-Cx; Thu, 09 Dec 2021 08:44:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvF2B-0005oH-2x; Thu, 09 Dec 2021 08:44:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvF2B-0004r8-2R; Thu, 09 Dec 2021 08:44:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Tnob3waLOsXpZ7I0FFoSMN2Utkp950ITIhfUYLeSnqg=; b=mzYksrV1c+9SZmvbGlBnj+57+a
	164YM6o3sTRsVWt6+AhDlwJzMhj9D03jJinxFTt2CJ1wHjqqVjYm5wj83tdp063q9x3L6DMfz1lNY
	YmT54KlEeh5SD/rAQoBtF2zQWH44SMUFgc0P5c5Z8bfQX+db4A959qoaY2aOL0k7XBSw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167238-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167238: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=9fffea73535d2d6c97545e039595feab4e3edc31
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 08:44:11 +0000

flight 167238 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167238/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              9fffea73535d2d6c97545e039595feab4e3edc31
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  517 days
Failing since        151818  2020-07-11 04:18:52 Z  516 days  498 attempts
Testing same since   167238  2021-12-09 04:20:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 87083 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 08:48:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 08:48:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242791.419877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvF63-0007Pr-Vw; Thu, 09 Dec 2021 08:48:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242791.419877; Thu, 09 Dec 2021 08:48:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvF63-0007Pk-SW; Thu, 09 Dec 2021 08:48:11 +0000
Received: by outflank-mailman (input) for mailman id 242791;
 Thu, 09 Dec 2021 08:48:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvF62-0007Pe-OQ
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 08:48:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bc0b2205-58cc-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 09:48:09 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-uHwVgNM-N3S6ZE5bfXsTHQ-1; Thu, 09 Dec 2021 09:48:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 08:48:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 08:48:06 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0402CA0002.eurprd04.prod.outlook.com (2603:10a6:203:90::12) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 08:48:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc0b2205-58cc-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639039689;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=q/wjiQ0J3T6bulvXOwbJPkh8GBjSj7haCrvlH1MsovY=;
	b=fot+Lzz0O5cnNk6v/wKG+4JxR7sy8tJhlCOLNKxc2PoyCoJ32BVjAwOzRGMGLFIPHLjx7Q
	8VhuA9rRYcyMuR0aISSZEGBhSXdTNHG/tJhzdVEoeS2MpW8tAMgrxwLfdjKCDCQgCv6WKb
	mwsEjjKS7fnvMqae7IDuqe66rW/fP64=
X-MC-Unique: uHwVgNM-N3S6ZE5bfXsTHQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=P9eslVOnIQW6zN3j929pbIpWxjMwxqXW/+Fn8lemb47ALam8Bzoc+Ej7QtHmnMjxssIP322vcjoBCs0EEAf6+YQ35nZfXzAWS2M2FfzwQ/Rv+e5EvDiwAoJIUJWytqQqNX+NtmqWsFk8tBTfPeqI8OdDBnCtpg36gN6yOn9pLU/1NEwkGo8cwiArBnNFyMvqhLe9CYQGCk6s8wWDAGRZOv+Ec8jtqPKQP/6GTHoTEJ6Xp0BI+cFTo1tZ2wqnj8DPBedLaBRgaxDHcq43XqQx2L35c5OsQjSTktSudjEG7pd2q4u8VspchIC8CjWH5lSKgJ8bGrr4pU7sXxu3yABdTw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q/wjiQ0J3T6bulvXOwbJPkh8GBjSj7haCrvlH1MsovY=;
 b=OGfoziSVsMXQJxyqwAdLQKpGZBmMSQQUYfjMpJ3TXWTECYGIBjrRyeIyTmVMH7mAjYWiMHYzBXdzApweJdfeB2uYNryMV7uugVgbwB1sN+yY2sRJWEZDcUg62Y06SIVnQA9h9BO7opKWFobSiGm/UK2mnGx76YpvlK4t6lVoYgoMkEzGpNYELYQeV9nrvoLL8qyy7WKcHEGfqsmfR13gC5HL343gfYMuzId3yRnqGgHezXWo/5TcOblyrbc3NVUrgn8qdy4fHhKuvknKdGgg4nCLPH9sQit1xCTncPS7PSMlKx6pr7NSKDu5keCbAWkrXCvV/C5ZfEdv7o4+2559zA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>
Date: Thu, 9 Dec 2021 09:48:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 Manuel Bouyer <bouyer@antioche.eu.org>,
 Simon Kuenzer <simon.kuenzer@neclab.eu>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209070942.14469-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211209070942.14469-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0402CA0002.eurprd04.prod.outlook.com
 (2603:10a6:203:90::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 149ddf9d-2e14-42cd-7e20-08d9baf09e7a
X-MS-TrafficTypeDiagnostic: VI1PR04MB5599:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB559983C138636732E2DA7766B3709@VI1PR04MB5599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tedSnI2K7f23meKH3XT7kVOaksdkLMi/OPg/pgqSsGAZMNBrP5MQmBMJAdFheUCn5Ch2BZ3u5L7TshtiPoYexAdTbC/OvlPfjmHaAPY1rVcWKbeGKQbnYWfcQ8pF7y5XyQs70j/XL/YWA90hlheCW9iB/ZwDxWUJxFIs9RnAe+12pEuw9Da8GBLG7LIRhfZQAptv66r7UuUoMOx3DnopFkYmQlpapw8VpGAkSfApn+D0LFmYGNfAFv0n8VXaJ2CUpxWkGJgje6jp6r4twTFbxkoPPJ1U1GonDqK4MpHIJLxs7/HThXHSP+FXZrUCgW4FMNRgDis+3nrRNLOc6Nt8YRsOmYNlsn1UxTXPcn2gZv+PeXj89iMoxbnnh7vwByjOCeza4N93BlHgyuH3vX0HMoeXVF3SLICEzmVUSDn1HkSm9MVISs23lWKvTWQ2KxfNawKn3iK1AB6zeswqrzylRy5kviBps4TUAjsbq4B1ew3ENgyizQ/rn2fV+sPo77H21HXvcYwvSiFoIbI4uBuI4X3t7BRbZ/yuXnwAXOnb4Nx6Y3CIZm3097Arcg/Br9re+sJ4OEX9Pydm8eaH4v7ylw/A6P/3TqVEiQZhUR74B4/g3WFaToan/+RVBtPm02aeDhRsT+ZdMRiCfH0/L5DA7t87f/WqElGCzuw0Gg6YaLIaVXQGgUyol/mQGQTPrDg2PfPfWPpENiqRZJPkf8SbR+/q/AY9lwPrrHrKesGfSCM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(956004)(6486002)(53546011)(8676002)(83380400001)(5660300002)(31696002)(6636002)(36756003)(2616005)(37006003)(54906003)(8936002)(26005)(66556008)(66946007)(6862004)(316002)(16576012)(508600001)(4326008)(31686004)(2906002)(86362001)(186003)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cDZvdXNKMk5CK1V2Sms0U2h3Nmh5U1UySVNaRkRXVFZxbDNHS2Y3UlQ4b2hW?=
 =?utf-8?B?eWlYOStBRGx4N2M1SFByRTVyYVBIQklteXRrTDZ0QUpTUHU4MlpabisycUZy?=
 =?utf-8?B?ZVJycEpGL2FrNGdocUVHSnB1bzVTM09MUnlVU2pzcWlWUVlxZGRIVnhweUFo?=
 =?utf-8?B?UTIxRks5ME4ydW1NampCcTRhNlRRVnl4WkRhcmJqcnFqMmJiazBvTlRJc0Zw?=
 =?utf-8?B?blNtZUpYZ0JoMGJKSHZ4OGxtRlFqNisvNVRUeGFHZ1k1emxQQXA3L0NsOUR5?=
 =?utf-8?B?NFJmRGp4VGRROVBJY1dHRlRLWXVjYldQejQvak5SeTl5SnhncXhPNHRYbkN5?=
 =?utf-8?B?RDFoVmlQdEZNdG1LWXU2U3JQTVRLT3p5STd5RlN6NEMwNkNNbDB5OHRYN1Bx?=
 =?utf-8?B?ZWg4TnhpbFdQYWN6K213cEdZSlFEdVJBOHlKdnM5SDlsbzRLbUR5czRqc0ly?=
 =?utf-8?B?bmFoTFBsNWM2ejhHUktsTVF1YnZzKzJSUW1Lb1U2VnA0bm9RMW5tdjY4RVYw?=
 =?utf-8?B?ZTBYcFMyejJMSmY0Mkt2VGgyRFBTTnFGQndaYkpRNWFiZWo3ajdNemV3eE9Z?=
 =?utf-8?B?MzArUzdkOVVtY2ZJVmRnSVkxY2YwMktnRWQ4cDlZOGZNeWlLNWhsU0lBUEg5?=
 =?utf-8?B?Q0xwdjIweEEzR2MybW1lR3crTlRWVVM5a0J4N2JCL0NxbzhiUDEwdUVORURl?=
 =?utf-8?B?ZFpDVjRaUUx2S1pCZWdiNnQzWVYrNWxhYVRVQ3JLN0RHKzdjOERPNTljalNY?=
 =?utf-8?B?QUV0VnhJeWE3dStqSXhGOXQ5bkNnTXJXZTFlWmFTL01QRU9ZRldkY1gxNWU4?=
 =?utf-8?B?OW5ad3VxbCsvYm83dnBuNERvNlBxRllXMHh6K3dPL3hOZ0dBOUlFZWRXSVZC?=
 =?utf-8?B?aWxTZjNsNjlHY2tLQjlQc05sVUR2dENkTngrZGprZnFkWTBibFlYaXJsVG1s?=
 =?utf-8?B?S2RUSVVZeFBRcnRrV0hocjg4MW5RNEVSMWVFcDR6OXdTWjV4YWJPdTZEOWM4?=
 =?utf-8?B?ckUwc2U4VGJISzNZOWI1WnpXNlhoZXFBWjF4b3Y3cWFGM2xKVEhsbzJ3d0Er?=
 =?utf-8?B?UG1mczRUZllBUWZNUldobU5jSWV1R2VINjlpWXh2YXNRQ0lMK202S3ltZjNF?=
 =?utf-8?B?Rkd0emF1Rk1aZzN1ejRZT015U0ttV1AvVURFNGtEL2s3UTVKL2NEazFsN3Uy?=
 =?utf-8?B?U2RDZjRkSWx6NGt6MVBiaGpLRHJzN3BPbTBmUkZvdzVwV3NUeXI5bUMwUzQ1?=
 =?utf-8?B?TzlsdStNcFdIRVNzL2d2Ynl5RW9tZlU3TVBnS3Y5MXRaRXg3OGFBUDN4WXds?=
 =?utf-8?B?V2xBblFjYXJKbndBYnJlczFMZyt6d2lGaGJ6NjhhUnRObUp3OGQ2Rkx2a0k4?=
 =?utf-8?B?c2Q5NzVOQWZaSVdJbExvT2pGNGEySFZFRzFpWWF1K1BOSWtCd2piM2NsSk1O?=
 =?utf-8?B?aVhXSGdjK3JaY2VDY295amk4eENoM0ZlZ3pmeG55MEk5VlBPZEpiSVJXYlFL?=
 =?utf-8?B?Q2ZZdTNmVU5oZEdpWGdmQzA0SlRKSm1IM1NFNTFNbnlyb05sM0NtNFlNZXFa?=
 =?utf-8?B?WlRNaERNclRCRU9ITDl5RUlmRWZTZVl2TlhXTFBWY01kb3RzYytiN0l3YnhB?=
 =?utf-8?B?ODRpbGNlUHBiRXNUOFZJYk1UYlNDK1VwV0wyUmNYSnZkTS95NGpaTXFnMGNN?=
 =?utf-8?B?YUZ6YUROK0tFaks2NmxFMnhhL1owNzJvazR4ekRDV1B2bUJ3UHBaaWNaaDlH?=
 =?utf-8?B?TUJpL0xIRUpYYVdxV0xWaHlrM2VzUVJnRUdEU1VydU84VEx5R2YwM0c5MlF2?=
 =?utf-8?B?citOMkI0TW8zMnNGZ0RjbUwvb1lXcDFIRWxZcjYvQmo1NGhMZ1BvQ3JIMHYx?=
 =?utf-8?B?TFBHVllYMm1Oc3ljL3JaQThzZ095VzJLQWtaL1VVZmFRUjF0WGoreVdIc2h6?=
 =?utf-8?B?aVlBUE00RXB4eGdSMnBNUXRQY0JoL0NreW1lQjg4Z1FUYjFkdDdUQStqT1lS?=
 =?utf-8?B?dXBOZTJidUFPVXRpR3BVQ2VrZ3FhcjVnSnBTZUs2bnBwWFpLc256Z1VTcTRX?=
 =?utf-8?B?Rm5Ja1dIUTJSNVYycGNaN3d2R1VtK25lYjV6RWI0eGk4RHVpb2tpemhlWFJD?=
 =?utf-8?B?NDRVbzhMYk1XQVBGL0hKanJKaHlqOTYvenUxRXI2aVZPM0g2N1BNVHBWOHFX?=
 =?utf-8?Q?Eesn8ovOAd1nEF8ha99T6Ho=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 149ddf9d-2e14-42cd-7e20-08d9baf09e7a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 08:48:06.4700
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LIdOzIJCocKMnT2EJKJADYqUlPw/Wszc4dz8/xlbEz+g+cQSXsC7N6plXY1aTIX1rxMbbJsvIOgm7UccVIzhGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599

On 09.12.2021 08:09, Juergen Gross wrote:
> Today RING_HAS_UNCONSUMED_*() macros are returning the number of
> unconsumed requests or responses instead of a boolean as the name of
> the macros would imply.
> 
> As this "feature" is already being used, rename the macros to
> RING_NR_UNCONSUMED_*() and define the RING_HAS_UNCONSUMED_*() macros
> by using the new RING_NR_UNCONSUMED_*() macros. In order to avoid
> future misuse let RING_HAS_UNCONSUMED_*() optionally really return a
> boolean (can be activated by defining RING_HAS_UNCONSUMED_IS_BOOL).
> 
> Note that the known misuses need to be switched to the new
> RING_NR_UNCONSUMED_*() macros when using this version of ring.h.

Is this last statement stale with the introduction of
RING_HAS_UNCONSUMED_IS_BOOL?

> --- a/xen/include/public/io/ring.h
> +++ b/xen/include/public/io/ring.h
> @@ -208,11 +208,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
>      (RING_FREE_REQUESTS(_r) == 0)
>  
>  /* Test if there are outstanding messages to be processed on a ring. */
> -#define RING_HAS_UNCONSUMED_RESPONSES(_r)                               \
> +#define RING_NR_UNCONSUMED_RESPONSES(_r)                                \
>      ((_r)->sring->rsp_prod - (_r)->rsp_cons)
>  
>  #ifdef __GNUC__
> -#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({                             \
> +#define RING_NR_UNCONSUMED_REQUESTS(_r) ({                              \
>      unsigned int req = (_r)->sring->req_prod - (_r)->req_cons;          \
>      unsigned int rsp = RING_SIZE(_r) -                                  \
>          ((_r)->req_cons - (_r)->rsp_prod_pvt);                          \

To answer the "whether" question this was likely good enough. I wonder
though whether the use of (_r)->sring->{rsp,req}_prod doesn't require
further sanitizing of the result as it's now intended to be used as a
count - afaict the returned values could easily be beyond the number of
ring elements when the other end is misbehaving. Or if not bounding
the values here, I would say the comment in context would need
updating / extending, to tell consumers that they may not blindly use
the returned values.

Also imo all new identifiers would better have a XEN_ prefix to avoid
further growing the risk of name space clashes. But I can see how this
would result in inconsistencies with existing names.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 08:54:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 08:54:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242797.419888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFBh-0000Mq-L9; Thu, 09 Dec 2021 08:54:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242797.419888; Thu, 09 Dec 2021 08:54:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFBh-0000Mj-Hp; Thu, 09 Dec 2021 08:54:01 +0000
Received: by outflank-mailman (input) for mailman id 242797;
 Thu, 09 Dec 2021 08:54:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvFBh-0000Ma-0I
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 08:54:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d0710df-58cd-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 09:54:00 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-YIeMfEgPNpKlOH3S7obqeg-1; Thu, 09 Dec 2021 09:53:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 08:53:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 08:53:58 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR0502CA0047.eurprd05.prod.outlook.com (2603:10a6:20b:56::24) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 08:53:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d0710df-58cd-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639040039;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WDCu2pVFLr5823cYs9N69Z8etNH9rKVurMhQP4VSJc4=;
	b=cNklPYW0+t3csg0P2gZHOCj2JfW9UI8hsrC45TfUJZt5i5Hqf1Y1Ce3MBh0yz/TUjhnz45
	Raczx9ygFXgbOwa86QUBwPNZV+0saajYOremhQmS3YIcBjviHceuyk9fY8rMUHHUDMzxBz
	q2yUf7DsX5bJF9bg4XAyMnW525eae/A=
X-MC-Unique: YIeMfEgPNpKlOH3S7obqeg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B1ai2DLRgrmSEqUUoTjFhK2JbbRcUPkRuvjLkRIBgbfrhNFuzdODioM+/TJ1Bma62+6r5rviOuI8HvOOkEiDZhDxRHpyEEFVa4QrwbGc1+xb4AV6Va0T/024EAWpnVGSC4lGvS9nackXXpZCnU851bQB/6CLmHWESys8u2Ds0hhuwu6qEkOe++QuZw5GJBrzF7Fv6tcyvHjsdweF6f7G59zvG99CLF3/Nm63buFyKdzcMjVP8YVZnz6myP9s33BQtoQuwyZQcQ/2gpd6JTP0aXgrhYcHCAz0U8sNjt+K1tc/0js38lc3MTcfdwozIP1Ad8bShb1BU64JAH8b06kc/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WDCu2pVFLr5823cYs9N69Z8etNH9rKVurMhQP4VSJc4=;
 b=GaTklpN7t2dFzgwTmS2PG69zRz969cmyu7U1i9g5ifaH8q2v2Nmw1Lgk+R+hmhtwaPE8TJfflKbotNpD3eZ7rSXldcLqn+hzMPjKofFupJ2MRQYDO4VmZUOZjWXkXR34+6K/vthm6kw9PGG/zTq+h92Dso8z2VHZATdcKaDMgWdfold/0pgsLZDYspAKsouJY775NoymFWunGWMc1N9OI1DMlhZoXMaAgjH6x3HKqbBnmfyTbb9vt0CumBWljsnl8U5wYOTzR6fgs43hDEGzdxos54+q5nYMESPGGZKUXo1DFUmd3WG662rNom7k0ekujoraCFhk35lEq6wfF7Z5qQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <98c1b555-0656-d7b2-0cff-3bed84eb5e88@suse.com>
Date: Thu, 9 Dec 2021 09:53:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] x86/monitor: don't open-code
 hvm_has_set_descriptor_access_exiting()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <925bb889-8048-e275-12e7-a4f5d31fb76d@suse.com>
In-Reply-To: <925bb889-8048-e275-12e7-a4f5d31fb76d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0047.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d566b9d6-9afe-4a27-5984-08d9baf16fd9
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2605580E27F4FACAA0B4F12AB3709@VI1PR0401MB2605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	R19V5zCCU/wwXBLgAiarhnGzM2v5X29+MWxreJfNuzCWQYOWvzO0mLNbyfLz7x4qinpyJZ4XSgps07ZinvuefpLv509M1lIcz9QeEN+6aaKml1FOCCBOf/9IEGvbgt3JyMyp2md0LCqY4yWXGiUMshyFO0iiBzJhQLzbR527mUlCa+LmOCTNyy6bXdxs35T05gk0CT94MUDUv1B2F96LQoY6sCGWRZUZKrVXbbSljiYgBAQjFMFRXKI0jYts2RlaIQSheyfimZPcUN3gM3BzOiQb+4Gs0CHlnWTBblURA/Y/YVNgv5MvqAoz7Lso8FI/qNJEseSUq+VXXWxXX10JJaDO/PDM51fOVbpZ1HK1wLrXMCtUmIRnSqLzE0KxdXMNfnKfKdOdQKn5GJ4tjzdvctY1w0nAc6B+AftHgaCTudchcQsCrBg9rzEIp9vsZmbT40WlVLG12k+PQdp2mlyYlNn98ENxQTj7GbHdgktzmiMRslzYvHWOrO2wY/IwftSOkrM8uPlOhKs7LIVOHUDyJEmusuxY4tteLzhgpfs63NAyS6p+ucZ6kQBqvQYlsitvGN78kR7qe85mZTyA7UncwI2NVLD9w8/CtIHmEk1Vb/q1LlKAGKL+F4fMdh7C2+8Bcyz8jCFc94GEjEYO7pWa73zN/tq9MsBcLHH7I7zhOW8itlu70vhxWmGQ1Iw8+SpZN28jR3nc64z77alcSovVmNtXJFjBJn72KV7jYwh8Hz2bihJsd76WIEZWpkkY4OCo
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(6486002)(508600001)(186003)(54906003)(4326008)(956004)(53546011)(66556008)(38100700002)(66946007)(66476007)(6916009)(2616005)(16576012)(26005)(8676002)(36756003)(2906002)(31696002)(8936002)(86362001)(5660300002)(83380400001)(31686004)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGpFeks2T2MyZ0d4cnoxRFg4Nm4rbTZBd1pUeldzNk1UM21qZmhNRE5yL2F1?=
 =?utf-8?B?OXhqQjlraytKT3FWcGRNdGtZVTdHYzdZSHlFemRxVlVFRXBiRHdXb1BQbjlx?=
 =?utf-8?B?VTJPRlhLU2VWZDFvY0I1TDg0UDlVamFxUWFuT1dxRmZQSTdiV1RKUGRtUCth?=
 =?utf-8?B?NytZZEZHVmNRcnVDNXROR2ptUDF5V3B2bVp5RFJMWEduVEdUaGZldVEzT1Yz?=
 =?utf-8?B?QU5nQ0g3SC9xK3NvaFRWNmlxUEV1ZU5vY2Y1RkhsT1R4dGpqSUQ0ZHo4V2Z6?=
 =?utf-8?B?d3dURkhzWmlvNGZ2bHpacW9vNG02UnVvM2NVWTB0YlVQbHp1My9rVDdWZUlM?=
 =?utf-8?B?T2UvRWYvZWltdDF3VkZVVDRMbEVWYVJHdUdsSGFoQkdSd3lYMlRmaUduVzcz?=
 =?utf-8?B?SFF2YkJZTVAxd1RJSndJTFlVelJaZEhuZXR6RXI2VExTT2Z1bDNRZWhsaUVr?=
 =?utf-8?B?VlE2SnQ3a2M5bUNqRUozTktjS1VVSmpwWitGWjdlRHlvL0ZNVXZpemx4NUlr?=
 =?utf-8?B?MXN2YlVYOGx0RU41cmJndXgyWWVabHFKelp1OGd5Wk0wSW1CZ1d5Qy80dzcy?=
 =?utf-8?B?V2xxZ25UWWNHOHZ2aEJZb28rZ2g0L3ZMY0tmOG4vMzRzYVBwNU1EYlk1M3A2?=
 =?utf-8?B?YlZ6UTN1c1M1RlZyWXVVSjJvelI3Z3BzT3VSQ1Z3Rzh4YVhURnJ5SWhHS0wv?=
 =?utf-8?B?aUZ0UEhpZG4zdUFIVkJtOHE5aVZjLzgzSVh3d0VRL3RidGp1NXhObG5HZkQy?=
 =?utf-8?B?ZkR3SjdaenpZcHRlcUtUamtaeFBKdXEvdHduOWxKMGV0SzREYlNQTEp3TjFh?=
 =?utf-8?B?cmtFZnFNRmhpUWFoTlI0TEFhSS9pd3lCY054SmhEOVlYWGxNY3A2L0lqMWJl?=
 =?utf-8?B?NkJ1ai9iN1lBTDgxTjRmSmZCS3pxa0lWQ2l3Wi9QNTdzb0pBakdpWE9BSTIw?=
 =?utf-8?B?SDIyek9nQXVXVmF1NE9GdTBMdC9RejkvaGVKNmdkM3lxZElNekdrY1FBUUlp?=
 =?utf-8?B?ekVhL1J6REdTQ1JoSHRhOWhPUVM3QTlXcUhIVVB1S2UweU5DQ0NaOXhYZjBi?=
 =?utf-8?B?dlBIQUJORXNnd3hsMmhJSy9oc3pUSHAzTStpeTNwRHdReWJvdHdjTTBkdlQv?=
 =?utf-8?B?cTNOZzkyRFM1eVk3c1BBUVR6cUZ6ME50U2ROU2UySkhQVmV1eGRIUkpEU1Zn?=
 =?utf-8?B?WjNTWkFoWklKR1VzYys0c3J2aFVyVUdZZDlDRjJ4MEFWU2VBakVhNGhMak5n?=
 =?utf-8?B?WS9oTUl5Z3BQSHgvaU5xc3VtTXc3SmhaeVpVbEJqR1IwdDRicHhzNmpJdFZw?=
 =?utf-8?B?MnA1Nng3UlpnMGtBT0I1MHg0MkROQmFIaVM1QVM0bDNvVXhJTWozemIvRHZN?=
 =?utf-8?B?aDc1TGZ3eUJNdTE0dFhERGZzTFhmT2lJcE1iWWZ1bHVid1ZxU0RKZklBQU81?=
 =?utf-8?B?cm9nMjYrK0t6SEh1V29GUHBsQWtodC80eGI1YVo0eUxucG1rUVdDUkRadmxr?=
 =?utf-8?B?enc3TVFXZkVmS09yUEpVQlRTU0dtcXBOZkZrakEyZmwvYmZaSTI0eDBvbzRB?=
 =?utf-8?B?TlBQM3FVRnZMbWQyZHNBajNKYldQMk5aS1hIMWRQQUh4cnM2cW95UDRrSzQ0?=
 =?utf-8?B?K24vSFpTNFphNFhwMnB4VkJRUzZ6MjZzZVpuQlZvRy9kazI2eW1vT096dXZ2?=
 =?utf-8?B?RW9rRzhScWdlbEJHWlUrSGErQlphWDliZTR5NkkvR1lrdWtqMEJWZkhUelZH?=
 =?utf-8?B?ZzRJcnk4UnFLdCs3MVVTOFljd0QrSHVlMnpXa2pGZkZ1VlRhOTdUUHFPYTE2?=
 =?utf-8?B?OUVjT0RYbDZpei9wRDNyYnB4NjlmQ0NRbkVlQVFtSlFxL20yckJvaU5uSnZ2?=
 =?utf-8?B?SnFZTHppZm92SmYyR283Wis1K2RpS2pQTWt5clJvV3o2SllWQUh0UG5ZNzF1?=
 =?utf-8?B?Q3EzOE9nTjBVanloc05Fd3JXdXJ2dWFWN2xWRjFpV0JqT1NENE9lM25JdlR6?=
 =?utf-8?B?aWF6dllmdXY4azY0b0kvQk9vZ2dYbExpdCtlRmZOVlJ4M3ZObnJKM3BvZVRa?=
 =?utf-8?B?YkJUdXdCeDN3UlljaE45Z3dzaEJLaTFlY0lXUU5IWlZFQUM3RmZIRDd0OXoz?=
 =?utf-8?B?TXBtWjVrZmloTjU5QStTc1hyVU01Zy9CbkQ3Lzc2bDB3VWJnQytKSVpKcG4z?=
 =?utf-8?Q?bx1LUWw3Pq6AeiMXDehgOHE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d566b9d6-9afe-4a27-5984-08d9baf16fd9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 08:53:57.8354
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0h2ckoOVQZDzK6U2PiLTka0qf5G7OOgjEw7b2eTIAMZ4He6X+yEs5a6rxMFOAhwYrq3ESrzrbtjd9ZvrjrsDWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605

On 30.11.2021 17:11, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

May I ask for an ack (or otherwise) here please?

Thanks, Jan

> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>          if ( unlikely(old_status == requested_status) )
>              return -EEXIST;
>  
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>              return -EOPNOTSUPP;
>  
>          domain_pause(d);
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:02:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:02:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242808.419914 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJa-0002ev-UM; Thu, 09 Dec 2021 09:02:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242808.419914; Thu, 09 Dec 2021 09:02:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJa-0002em-Qn; Thu, 09 Dec 2021 09:02:10 +0000
Received: by outflank-mailman (input) for mailman id 242808;
 Thu, 09 Dec 2021 09:02:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJZ-0002eQ-OJ; Thu, 09 Dec 2021 09:02:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJZ-0005av-FS; Thu, 09 Dec 2021 09:02:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJZ-0006CU-45; Thu, 09 Dec 2021 09:02:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJZ-0001Dx-3b; Thu, 09 Dec 2021 09:02:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D+n1L+mvAxvT4YPmbZPhEq00sdDO0mWo5Mh/RCh1Lk0=; b=I/6kr2AaqMO1zRN2dkEkz3JHoJ
	T/B1if9dK3yMdfZQzGDps/jCKVhNgA+f2BmsjIaTlUSbnEndhmYXPFl1xYrtsQMeQA6BmG073pYi/
	AmhIJc4nepfg3KAHo+lBeg9tzln47B7MCFAZjg7NWcuBBv5b3hfY8ZtL7cFBA2ANM0LE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167236-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167236: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
X-Osstest-Versions-That:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 09:02:09 +0000

flight 167236 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167236/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167234
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167234
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167234
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167234
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167234
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167234
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167234
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167234
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167234
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167234
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167234
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167234
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87
baseline version:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1

Last test of basis   167234  2021-12-08 12:04:03 Z    0 days
Testing same since   167236  2021-12-09 01:09:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jan Beulich <jbeulich@suse.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   608531a0cc..c62d634cce  c62d634cce8b1507d00a61bfc8168ac42367fe87 -> master


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:02:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:02:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242807.419902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJY-0002Ov-Ku; Thu, 09 Dec 2021 09:02:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242807.419902; Thu, 09 Dec 2021 09:02:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJY-0002Oo-Hr; Thu, 09 Dec 2021 09:02:08 +0000
Received: by outflank-mailman (input) for mailman id 242807;
 Thu, 09 Dec 2021 09:02:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvFJX-0002OS-Mv
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 09:02:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aef227b3-58ce-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 10:02:06 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-e8BKpD9GMJuFf2XarmuA4g-2; Thu, 09 Dec 2021 10:02:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Thu, 9 Dec
 2021 09:02:00 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 09:02:00 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 09:02:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aef227b3-58ce-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639040526;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DGu1CLprgMe9Q5Hwb6tSAmfWu2jafsaNacWPAlqKvyU=;
	b=jq1hXTiEi4YoZ3workPrMXWwsWxkMSi4PKZXkUG4tPB9+NE4V73BeNJPw55lPAnQkGmIPl
	N21u49bAN5Kp7Ssyt6fBkACOyh8GZvcJnoQ8hH2IJwOLG4zi2h8SJOJnBL6bBPDTN3HwBD
	ZJYD3bIJ/B1vmURTYvramRyHD7zURFA=
X-MC-Unique: e8BKpD9GMJuFf2XarmuA4g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iSOCr4FRrPhMeFd+815E7vqdiKrmuIZUT7nJZMPHcXyemeHGA485MVunbVqW+d8wHIYSUWiyZdt+bdclQcxyksRtaqIhM3NCppUEkle7LzuXpQiS21kRr5qsr3nzlO/Dc0hzztHHsMZlB0DAD2aVdEF8SVT7THZgnPVaTmDlmwn6V25xsAYdq7L3wxSx38rfaW++24JDadfX1tmO1y+ofGDCj1OoBxSmMs6yKP94don9Z8a5j08wUPLcWhAIslQTxiRqUlCezjc5qYuqVGjbgdJTye8cm6ovFHG/9PLCZ4B6UeQXkgnLnA0KqjjKr7tcEePdqXRmOQ99dc7w0Jduzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DGu1CLprgMe9Q5Hwb6tSAmfWu2jafsaNacWPAlqKvyU=;
 b=oSpuOlskMfzmBBqGjyTBtpaTL8im5EAls+VcNrOhO/IcfE7lL/EPk1021ezsZj3J/w5jEfjbIYgM7wdbR0lLqGzNRJlGW5qnK55p2ONQuJDFQQJJqTWRmniKJPFajhEVwCKbvtFKEs2MB/dPxCwfvvGsdCHe+yZRhyFKKUfgUVpre+ExaodoizFwIxAZMp4ogyBDLa7F2u2WtoyNdXfmQ0owx1bNzPvgiZvJyEBJF36Pmy/D2OT8vWZTMnb6Vs6A83Up3LfaowBGtVVmqv00mws+79XP3oOTswm2iHFDN7xXbq/lKsWiBB1SQtOe6/kjgtuASeSPTn5KXJHq+dPPhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0108a556-cf03-9402-73ea-be8a358c6fa5@suse.com>
Date: Thu, 9 Dec 2021 10:01:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v3 04/13] xen: include compat/platform.h from hypercall.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-5-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211208155606.20029-5-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1f::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 66555034-fb26-41f2-8bc0-08d9baf28f98
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB43528019D6722860BB5212F1B3709@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/bGICjtga6qHSzyBQyzTwoJH+9B11S9qngZ31a8n4fG7jxwxX3vUsn13quqs7qEujlA0FBHlQt9mm061+X8BkpnVgUy9DK2VWnT9A7xzwNL+Ak7Jh3Y9DaXUG6MhHLoSCdoBe+L8BeazEabxl8vJHnuwJ0mmjaUw/jB2KaMEPBdvuNWcb8YLZfb0EWVIphiL9goL3MsN0hE8SREJbvFo1xq8CC1Rc/LVZkMGXhS6Qost0x5V77TyhStTIeYziQ8PKgfCPDExon5iD1ZhLHg4py4vBWe6f4Oa6uzOc68w+7Rr1Yqv/92sON6pgafQcdDNgaX2Ch964iK8aqEiy2ig/Vg4YX4RtmuuOh3eGDEW3pnldls87bRUDTAgO8M6fPuVAWFZX+Sz91LXz+EQbrXA7hsZwFY6Vs8a8OBvMigX1vxbZEqrIImI7DPuArJm04VucUj1tvTXCfa0ApmfL3YnmcVEWy6t9H0ipOhcojWF13f72ermV7Jc63l7UyIiAERj4jIoFFFBKW9KxIxOvbjZCt/NaTSToAAGwVEGy9qwpUXIY/J1QGn1/Hld5UVb4AO1DSi/B3F6MMyV70xXwrWACfl6CVVj9UmG4JL38VIqiBLkwcMacAv7sZvGad8w5OgKQBSaM3u1iWdMUrTEyYfzx3Wv0gv/yZ79HUkJeoRrU8nDZfpFfnFG/NFxIbVB3dsdJUKI4CobEl6RyWh4uglpJH29C6oXqinekKXYZF7rios=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(26005)(4326008)(54906003)(66556008)(186003)(38100700002)(508600001)(4744005)(86362001)(53546011)(6636002)(956004)(5660300002)(16576012)(31686004)(2616005)(316002)(8936002)(8676002)(2906002)(6486002)(66476007)(31696002)(36756003)(37006003)(6862004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dnljbllEa3JwaGRla0k2SVNXbzh2WmJwdnRIV1hDaWFlWkh0c05yYnpzZHRt?=
 =?utf-8?B?KzhpeE1QTjFXNXBNRU5DVTR6UnlVajY0dFloK21RV3JtWU8yb0d1ZE5YSnIx?=
 =?utf-8?B?Qkc0WHV6eExmMkk1S3NxTU9JM0tOZ3loYjk1NFFORWNzMjhrRXRQaDNvMkhW?=
 =?utf-8?B?S29MdVc3RVMvL3V5UGJYUHdpQW11YTQ1cTJBVnFWUzhjRFl4bUxjM0JaMWdZ?=
 =?utf-8?B?NTFHOTBmeEUvNlRxK245OXE5cXB3TXduVmkrcWc5YUY3NHNzNEUySHpBWWcy?=
 =?utf-8?B?NStkeW01RGhpN0xMUHBZT3pOUlBuUGJwb3FIUHNKRmE4N2hvTHB1SDNUb2xQ?=
 =?utf-8?B?ZHNqb1RxbkFyL1BUcDRxZ0pVQ1ZxeVZrRmk2elEzVWYxeFlUYmlmUzJWbVVV?=
 =?utf-8?B?UmswdjB4SVQ0akNFUXgzUEJ6djVvQWh3WGE5RHRuRE9kb3JCRExJbDNQMnVj?=
 =?utf-8?B?ZmZ3QWdEejdMaFpGWFhZR3FGUEptb0Y3NnhVaXlKaWs2b3JkZTNtL1NQWTY1?=
 =?utf-8?B?Q3d5aWNQOUV2eWNzNTRQNERMUEFxSnBlNm1DUlRPWThWQU9wR0ZQd1l5bFpr?=
 =?utf-8?B?QnFyeGowLzRWQ255MGM2NDhUUlRRSVJ4cENGNmdkL1dRdFpweG9zYk9iVjZW?=
 =?utf-8?B?UjNyRVNUUElXMGtYTXhYU3g4QWl6dUhSeE8wVG9TZkZ0NVdIMHFZZVByWkJ6?=
 =?utf-8?B?OGYrWVBHaHpubGdOUWlTdEE1VXA4N1lKR3ZSTHRSQ0xSSkliSXZKbTNRVjdI?=
 =?utf-8?B?MTFkNE5relRNWURxWFJLOEQzaEcrbFRxSDlzK2srbm85aDdUdVFHMEJyWk9q?=
 =?utf-8?B?RnkyNlBxTkpKOExuQlNUL1BiaU9vZS82ZEdQaXpKay9iMllKaVY0SHVuaVNF?=
 =?utf-8?B?d2RmTVlvdk8xTm9CZHRmYVZ5ZmJqVkFTNGlzR0ZoUkEzZ21iSkhzcjlsRGtK?=
 =?utf-8?B?aGo3emUxSGZEaTlKZE1qUFVYU1Zta2FRQUZDRzcxVVpFdHJWdlljZW9VM05m?=
 =?utf-8?B?YXE1bnVMVEswdnV4L2JidWtXMjhBaDhTUXhXQnkxR1FNaEFPdm9YbGs0RjU0?=
 =?utf-8?B?U09DOFJqbUJXVDFzOFUvLzBYRzZ2eERCZTk1YzJ2cy85NnhNYjh0UTd4OE15?=
 =?utf-8?B?WUEwTDBYTTB5OElQd2JyY2FybG9yWTBRdGVUVVk5bWVDMDdvTW4rb1dLdlQz?=
 =?utf-8?B?cEhIVTgrajNKcEpxNWwvdXE5L2hxSGgxWWhwTnBrMGU5SHBQNWxsaFJtVlhn?=
 =?utf-8?B?T0FmYmVaWktFN1dDOGIvT2UyNzlPS0hEd0drL1dRNG53TTlDa1NNK3dMV1dh?=
 =?utf-8?B?dVlxSzd3K3NUOXRETk8vMlBJUTRmVUpVaUZaY0c2QXN4K1pOQkozanI1a1k2?=
 =?utf-8?B?TEI3RkVBWTgrQ3QwQzVVL2h6UkY2MzJURmhpcUF2V0xiRXhEZEZtRnZ1a2Mw?=
 =?utf-8?B?ZmVSaXU2OHh2T3JvN0lTZjBMRngwMXpJRjE3eFNSekdodUNaSFdvTHFnemVL?=
 =?utf-8?B?dWJpb1VVSjF1RllrcjZ6bUQyZnhWc280dGVWT00yMzAvaFpyUWxMZkY4T1Ax?=
 =?utf-8?B?NE14M09lT2ticU5yL0h0YW1PRXh4dXFSN0RzSUVkOWFEb1pPcWZwYW5sTzFl?=
 =?utf-8?B?cmdLVVpHQ0crRWt0VTZSY3E4bWhFMENxL0UxTGdnenNmUERPWUwydkxRK1lM?=
 =?utf-8?B?VWpOQVlKMGp0bnlhU3Z2TEt2cml0T0FJTFhWcTlSUHRaYVlVSlcxT21VUUk3?=
 =?utf-8?B?ajNPalRLNHVFTTF5WkR4VSs4dW42WW4zdngzSFlVOWpZdUhQL0JBYlhMU3pU?=
 =?utf-8?B?Y0o0YlZXeVJZQk0zQkY2MFdHeXBKRlNEVy82ZE9TblJLOFlOc0lBNVhLTXF0?=
 =?utf-8?B?Y3ZmRkRtdFZqakNGTlUxVThFK0NkUDV4UFJ5MllRbUdqUE9uWHRiVzBvQlBC?=
 =?utf-8?B?Vmd2bXg5ZER4UE9XNWRQY01QdGtLdDVtZ3ZUYnhNZjRHeVYrd3BDUUlXcHFS?=
 =?utf-8?B?WkgwUWx1Rnh6OTJXTUlEMFlJU3FEbjI1NkI0VDNFenhSVnpLajJhT0ljeTE0?=
 =?utf-8?B?SkE0a3BqSmRjYnlYWWYzTVhhSUp0WHpleU1tUFpvQnJYZTJ2VFBlaGpVdWdX?=
 =?utf-8?B?N0pPQS8vdStrbWtldlZxRnNSY0VCZHRTUjF0dXVqY3Nlc3dnalFvaG5xTVgv?=
 =?utf-8?Q?X4DBNvJeR+zU1BzNwW41/E4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66555034-fb26-41f2-8bc0-08d9baf28f98
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 09:02:00.4916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f/aHv5Zf2t6sauevjyqf+f/5ymZfRKwWcHDudkPl0dUB8VYXHahH1rJn9tOCl+YygaJhi0sutQX43axe9qQUzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 08.12.2021 16:55, Juergen Gross wrote:
> The definition of compat_platform_op_t is in compat/platform.h
> already, so include that file from hypercall.h instead of repeating
> the typedef.
> 
> This allows to remove the related include statement from
> arch/x86/x86_64/platform_hypercall.c.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> ---
> V3:
> - new patch

I was actually puzzled by the cover letter stating two already applied
patches when my record said three, yet total patch count having gone
down by just two. Then I came to spot this new patch ...

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:02:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:02:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242816.419928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJz-0003Ls-Hk; Thu, 09 Dec 2021 09:02:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242816.419928; Thu, 09 Dec 2021 09:02:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFJz-0003Ll-E4; Thu, 09 Dec 2021 09:02:35 +0000
Received: by outflank-mailman (input) for mailman id 242816;
 Thu, 09 Dec 2021 09:02:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJy-0003K7-8D; Thu, 09 Dec 2021 09:02:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJy-0005bG-4s; Thu, 09 Dec 2021 09:02:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJx-0006Cr-TN; Thu, 09 Dec 2021 09:02:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvFJx-0001X2-Sv; Thu, 09 Dec 2021 09:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zjAWtxGnD7L4GspfQyFDEenkglPNxtsBqUdQFL9Ce3k=; b=aOVuIF9vpVDJAx1fVM9bOwJz4s
	EXvch/03/OPfEtqJAmMRCzhbtmnc/t/nt/UFNTy03oaAxO8Xa7/hwO+lCvk2P5gXdbrCkrr0RQOQL
	SPd6n9v5O7CchHkOejfvANaX6qNHHrIjLBoipWIHBBLmQRVHtl1ombwzrhxq+5n7uBas=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167240-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167240: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 09:02:33 +0000

flight 167240 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167240/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:06:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:06:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242829.419942 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFNK-0004IB-38; Thu, 09 Dec 2021 09:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242829.419942; Thu, 09 Dec 2021 09:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFNJ-0004I4-V4; Thu, 09 Dec 2021 09:06:01 +0000
Received: by outflank-mailman (input) for mailman id 242829;
 Thu, 09 Dec 2021 09:06:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvFNI-0004Hy-Sr
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 09:06:00 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a0265dc-58cf-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 10:05:59 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-bso-eePvN-WfI-UJn2SW0w-1; Thu, 09 Dec 2021 10:05:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Thu, 9 Dec
 2021 09:05:56 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 09:05:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0050.eurprd05.prod.outlook.com (2603:10a6:20b:489::24) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Thu, 9 Dec 2021 09:05:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a0265dc-58cf-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639040759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=akOXLW2Bc9UpLCUzRX4M3PBmLGRNQU4Ro+R+EJ+ty5Y=;
	b=T2FdVO8okU2G9FZgSp7/GA1sJ8kbBT3IjwM21zEOB9pgb/3h+2E+ks1o1wO/JvHWFlOcEF
	I5QLYqZ1NbhKjhZydlHY95vV+5O66mHYjKGNJOK7ByGsHhARbBql8zK/heHiI3d3JVHSiP
	lKRpKzA5yQhxLMoqGV37k6N47Q+cBhY=
X-MC-Unique: bso-eePvN-WfI-UJn2SW0w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cVq3lBxi5XUD1Ib1cEpKB1w8KuqL3EBisdTJXqUJ5cyq0l54DdLcWgAfBKnHjT+Huo9yZAhjlUZNNRZh8n2AUUji96zeXNMAzqbSSD92CQ1IE4eaPPR+F3topsoYOai4cWtsorDqFHWnUp1BnTTeHLJ1Jjcbj0xqRQ+wyPTiuktoK2hM/L9jJ2gsmKuImcKIwJP4iKhGTst57Ab4P/aoBxIrKSTMFTYwyq0zauXXDlAPRG0SitmokviGweAI6Ts88HW7is5zfBW6+0d9hm8nNR/bPaQQJ2pTBGPDGufN/x1e4ByQ4t9eeNJGNp4W9/ZyFYFH/xNlE/aBgE42h/C1UQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=akOXLW2Bc9UpLCUzRX4M3PBmLGRNQU4Ro+R+EJ+ty5Y=;
 b=WNOCBKQNhLj7/Gmp50Xg1LEGkOi10n6dh1QcCZq3O819c2FaX9TKmAGpJC6cVGPZTJ60lEBuA5Fe0kVgTfzZmVJsdn5fGVz9IVQfjfwEayqpaGwvp3+euVC/0JUhz5SiDaTRIF4wkVbH6ZmN8RZVDY70TNaJ7xCOWSOwlPwtIcOaCD0FaPTQHZmeQmjfi74TOYwWorp9KBlQ42apS9SmoUuU/d2EBkXmP08gvj2gNCM8F86EjqBQdBA9LO5VAr/pXilp3gv4idgOAepqc7YJ20ly3xxoQv23/CFCayJK+slG5qjxKoVmLmwQuf670/IQhhOeJK+dZPJCUf/Su/biVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
Date: Thu, 9 Dec 2021 10:05:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211208155606.20029-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0050.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2704a4a1-5f3e-4beb-5fe8-08d9baf31c55
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB43523930E6BD9E51D3B701AFB3709@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AKlJ9hzVTGA3UcGF5lHwabOix5qWD9SYCnAH4cRponm9Qj9QHVoHMTSuImZxWoOo/MBnFzR4qcaraXfUblNW4qVwnjoKbYTsK6VldjNrKu8bWyvgNrT0lVYKRtAqQ9SGgCbk4VHQ11WnlFb9PqnBLGElhDysuvHEYybM9shtrlppo0cwPQNsj44esW8GZLeW+NhfCXddz4S7BC6WtfYwMuASqdjPM5mDC0CZluUk7EBM/nqxKbN7RyMpUwRQoj9IQ6af3oIdBG5rx/Va/u6on0xBUUjeUcfY/h07Go3i3i7fMLwbiIvp0JyIBDewm+sdo6X+ABPSHKoWMxFwlscGP4rux85JBtFgD1EYYkFbtfEI3g22xDYTjtVrH16LzCW7gXMGRY8hviUejOh8lmZuDMy0YT88AWoA8BFAQFu+v6PgOhicSt3ux+jxq3ys9t3P5qJRVI7aLQZkYTk/Fx4kEYdjz7RoUCgIvOpYKESH+Si70xZughYp+qXd4DzTLafrsKKbEl0AmGsrQUmfBsugjv+XsiZYarwnk2LlMIDiIIOSNLk9AdCxg0trq4xrOj6iMDhb3wsPMkJ903UpfShjIK5BoWQ1Ud9dBHMcgtyIxVhljI6g5z1QuVKY2jv61I+h3VBKFcCWKPm6JsCIednsP7y6aSxgcBMFcUTQiWlJ69EVT8JIFJsOAGaW3GMUABM1L031OtVHbxptOJSXwvRw7AAnqRxrlrw+Jdg4TkmIwfM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(5660300002)(16576012)(31686004)(2616005)(316002)(53546011)(6636002)(31696002)(66476007)(37006003)(6862004)(36756003)(7416002)(8936002)(8676002)(6486002)(2906002)(66556008)(186003)(66946007)(26005)(83380400001)(4326008)(54906003)(86362001)(38100700002)(508600001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dW8yWjR5anNoZFNQenZvOXlsTGlNWXVRQk1Sb3lJT0dLa0dhWml1OURWeWVx?=
 =?utf-8?B?b0VwdkFXdDNaVFl4UUFacHRTM1pWWDF4U3RIOVk5TzBpamZVMHdxVjk0SFRC?=
 =?utf-8?B?Q05MbEdPMFdReitHNDZEOWw5SnlweEFrWllzclNLWjUvZm02VG5Nc3ZoNlJX?=
 =?utf-8?B?US93Q0FQSkdmem9JMXdWZDBDZHdSSkxwR0NXRnV1SVBrTUlYRGdzaHBScUhp?=
 =?utf-8?B?b1psb3NiVncxUmxnZE5qNzJlcGhGamp1Nnp2SkI5cEcyYVVuK3NRQzdKVTlT?=
 =?utf-8?B?d1lJMEJjR3IxWXJIQXEwSG0raUh2L21vSytGTk05WVR6a0JncGxLbERCS3Vt?=
 =?utf-8?B?UE5IbUVHbEJmN3NKMS8xOGpzaXBMWVVmbXVtZkhqTmRzNFNlQkZxZTZ1M0FN?=
 =?utf-8?B?cE9xNGlxbWN6QlZXb2xGcVlhendrcHp0UDBVV1BzbnhzRWZHMTc5UExnL2Jh?=
 =?utf-8?B?VkF0TzZqL0NWVEZpNjFUZUJpc1VYa2xRTVZJVjk1UG02VGptbmlsR2dqRTly?=
 =?utf-8?B?dStMdzQxZE5mNGVEN0p0R0xrRmlrNXFBNzdTVGNXbGVibG10T25FVy9pWEZ2?=
 =?utf-8?B?bEh6U25ob0RGZjc1eW5TREc4a0p2RlJWZURDTzNEbzlEQW1LUzhVcTlKV3pn?=
 =?utf-8?B?RUxrRjV6UElNeVF5K0xIeGt4MzB5ZDNZL3FCTzNNY3lMV3VzRzh2T2dZbzdw?=
 =?utf-8?B?eXZDWCt3TjFoUnMrRzZlbzRQTnh6dnVBTmJvRnFyWEUxQWtTV0hjbDdXYzBN?=
 =?utf-8?B?bXo2QTU1Y2NGYklMWVBzeUdSeGgxamtmMEZWbllGTjdmN1k4Y01jeU1OTTBz?=
 =?utf-8?B?RlVKVzh0MkErbEsxSXB3VzdDMjFUMjNWUG02WGw1RW1hbzZIN0cyRk1IN3E1?=
 =?utf-8?B?U1RINFhQVTROUHpDY01ZRnBnclJNalVZMkZodWlrblEyT3E5eHhoYjlqeVp6?=
 =?utf-8?B?c29Db3R4VlFESm45TXF1SlhES3NmM3k4bGVIM0NqaTY4bXpIUFFMTElQTDcr?=
 =?utf-8?B?VzdtcmtLYzJxVFVmSzZiYVc1LzN0eitNMUwvNElseG1BR2NETzhXTzZNeXFt?=
 =?utf-8?B?dUxKbmVDa2s5OTdWcFhOSkJrS3FwaE5aUUcrSW9qOU8xZkdtdVhmTjZ4djlD?=
 =?utf-8?B?dnI5WHNKMVhLV3FEcDZqS0IzRzhUVGhvdkFZbnpsWDFjZVJKeWZSQTM1ejVt?=
 =?utf-8?B?QUdkOFJySWtXT1Z3cHZPTEJhSjZQcHdaaWJMOVpiMXh3SFBJM3k2VHA0S3A0?=
 =?utf-8?B?S2c4Z2EvQndjekxmMC95Q3Vwam9Lc1VXc2VkZEZQWUVYODVTSk9IcmhMVkZS?=
 =?utf-8?B?d0ZjRS9nVU44VTlQbEdGdUZESHdmSmNlcFl3M1NWdTEyNHNzRm8wckcxaXp5?=
 =?utf-8?B?Q05wZHBmYXVTSGYxUGZ1UnU0dzJjVElSMitNZzN3QWthVjFUZHMzSzMyMUx5?=
 =?utf-8?B?UHhjT205Rk9hSHZVcU1VeXdBNDFmak50bmNWeDVjZjgxUGYzcFNSWFgrMW5w?=
 =?utf-8?B?bVFRa1JSY2FZVC9ZOG1UUnFIL2plbjFvbnNBM21IUUI1ankzUUxNbVhreGJE?=
 =?utf-8?B?N3RwNDdKTHd3NitTNmc2dUI1VXZQUG9BQTRhYzJxRDhWOUdUcEZoY3dlR1RI?=
 =?utf-8?B?YWVDeEs0WHh4T0lhMmQvM085dk5FeGpRL1RMRitzZmR1NlFiTURMcHlua3FD?=
 =?utf-8?B?TFphWkZUN2pWbkdTbmRPcU96WTlJTDczTEpXZ01pRURkTnBCaDB6R1dYRXdN?=
 =?utf-8?B?bUt6SFpDNXZTTk51OHVxbUlORlVmMkNrc1plU1BMNHhNSklmVnFIZzdjTUtw?=
 =?utf-8?B?LzRLMGRNRnJRRDhhbGZNTGZkRDhEeDZCTlpSOGdiL2VIOTExSmpFdllQVHJw?=
 =?utf-8?B?Y0Jtd2c1bmZkRXpnV2RrRXV4S1cwR05sVTFucWFyUFRrWGJEY0szSkg4WjBs?=
 =?utf-8?B?KzlLazB1NSs1TFF5cTFOWmtZRDFlTE5rMEVQREtFS0lCaHlRN1RqYndzVCt6?=
 =?utf-8?B?NU5pT3lrUk1OU1BJZmppeXhwVERPYXhxVGRyWmxqNEVkNm9LTDZlZ1NTWDNH?=
 =?utf-8?B?WUlGM1R0NjB6cmNKMC9TTzBvRUk3b1lkL2RNQ0NqUWE5c3oxQkxxRGJBZTBj?=
 =?utf-8?B?VmRLYWxmK2ZIcHBmODBXTk52SWw2SUlhQzFWbTFKRGxqZWx0aTlZSXBFUDd6?=
 =?utf-8?Q?LeG3Ix1T6bEOHhOjLJXasd4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2704a4a1-5f3e-4beb-5fe8-08d9baf31c55
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 09:05:56.6571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8xZfufzFUFIxlkTarRgzeHqKwtFv3osuArlbbqXXjDxKJEAD+5kVXxLpMUPPPWDMu/dylF3bmc8ZfUelEFtoRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

On 08.12.2021 16:55, Juergen Gross wrote:
> In order to avoid indirect function calls on the hypercall path as
> much as possible this series is removing the hypercall function tables
> and is replacing the hypercall handler calls via the function array
> by automatically generated call macros.
> 
> Another by-product of generating the call macros is the automatic
> generating of the hypercall handler prototypes from the same data base
> which is used to generate the macros.
> 
> This has the additional advantage of using type safe calls of the
> handlers and to ensure related handler (e.g. PV and HVM ones) share
> the same prototypes.
> 
> A very brief performance test (parallel build of the Xen hypervisor
> in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
> the performance with the patches applied. The test was performed using
> a PV and a PVH guest.
> 
> Changes in V2:
> - new patches 6, 14, 15
> - patch 7: support hypercall priorities for faster code
> - comments addressed
> 
> Changes in V3:
> - patches 1 and 4 removed as already applied
> - comments addressed
> 
> Juergen Gross (13):
>   xen: move do_vcpu_op() to arch specific code
>   xen: harmonize return types of hypercall handlers
>   xen: don't include asm/hypercall.h from C sources
>   xen: include compat/platform.h from hypercall.h
>   xen: generate hypercall interface related code
>   xen: use generated prototypes for hypercall handlers
>   x86/pv-shim: don't modify hypercall table
>   xen/x86: don't use hypercall table for calling compat hypercalls
>   xen/x86: call hypercall handlers via generated macro
>   xen/arm: call hypercall handlers via generated macro
>   xen/x86: add hypercall performance counters for hvm, correct pv
>   xen: drop calls_to_multicall performance counter
>   tools/xenperf: update hypercall names

It's not easy to tell which, if any, of the later patches are fully
independent of earlier ones and could go in ahead of those awaiting
further acks. Do you have any suggestion there, or should we wait
until things can be applied in order?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:09:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:09:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242835.419953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFQK-0005R7-GN; Thu, 09 Dec 2021 09:09:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242835.419953; Thu, 09 Dec 2021 09:09:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFQK-0005R0-DI; Thu, 09 Dec 2021 09:09:08 +0000
Received: by outflank-mailman (input) for mailman id 242835;
 Thu, 09 Dec 2021 09:09:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pvl4=Q2=bitdefender.com=aisaila@srs-se1.protection.inumbo.net>)
 id 1mvFQJ-0005Qb-74
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 09:09:07 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0716.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::716])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a862dd46-58cf-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 10:09:05 +0100 (CET)
Received: from VI1PR02MB6126.eurprd02.prod.outlook.com (2603:10a6:800:182::24)
 by VI1PR02MB3215.eurprd02.prod.outlook.com (2603:10a6:802:23::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Thu, 9 Dec
 2021 09:09:02 +0000
Received: from VI1PR02MB6126.eurprd02.prod.outlook.com
 ([fe80::d1bb:db57:bdb8:7a47]) by VI1PR02MB6126.eurprd02.prod.outlook.com
 ([fe80::d1bb:db57:bdb8:7a47%3]) with mapi id 15.20.4755.025; Thu, 9 Dec 2021
 09:09:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a862dd46-58cf-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Zs1J+N7nSQXFh4vpuvFg8TrMYlPgLQtpFeNevHZAsvkUuOpYYdFq2zQrVIDZuGNFCPIOnpJOJIK0lBdMWk3B8lJrCNLL1WR7ZfSHMApKHmw7+rN77MWSGGtu77Y7m2WNKwbcR7HigKp40LlRh8D0rgnpjdRwfWQ3C/x4mB2aMeGrVWvuybwJQPIdV5uDLK7LPRaNei4WlMlLntDMD8msrSLsezpF1l4HbMARxjwjr4kymOvfuf2DjJQJdy1RPOV7NqYSLMdAhZeTnKpaVR9aC59V19GKtQj1s97ixLFNm3hRIQUmIx7MpuUfquiqsyCUQEMA5BcHEdZmkO36+Zfb7Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4QGP/vuZvwRCxBsdJHflUdAsOsqAws43qUT0bTSD5E4=;
 b=TziW0paVBW+Pa0xW5v2PIDaSx7REYp/qaiktg3ynWM/8DwCvXnz4Q8R70jEp5GkYfISyDeQV6GGRNYWHdcglWTrl7x94nE4fYwDoIgyce+a/73N+DB7hz+KO+mRWQl7RZqkBRdGQxFAZzpeFa7AcraZ3BFr5HLc3l0poJCUY0SBMh1U6lYbBQhs0atHC2xTjBBeOzVNTSZigGDFKx4KJFZDBRJ5B/k2W5kq8pFgmrc91zJScC8TPWFjsPp4yIzbN6QdlKf8m0GsliuYO/FP/s5UbDjxX5+BjOK3+bq2u0642LpCCaPBTFE29BeKhERgYPv8IpV9aPfX/74z7dzW/TQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=bitdefender.com; dmarc=pass action=none
 header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bitdefender.onmicrosoft.com; s=selector2-bitdefender-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4QGP/vuZvwRCxBsdJHflUdAsOsqAws43qUT0bTSD5E4=;
 b=w6TjNBw5kmEYKcFX6lyykl9o7w8zqN7KGX0pj00GT7JqMNR7u0bF6ohTHWbf20RE8muaF6+XiuZsXAOSAlqeNKfhD1PYilYwnv15vxKHlz7KZNo97ugABubYE7RWjYDl364Yk8cMn25SZodgXjP/+eJ+UDCHzecaB1l4Lt5KMYg=
From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Tamas K
 Lengyel <tamas@tklengyel.com>, Petre Ovidiu PIRCALABU
	<ppircalabu@bitdefender.com>
Subject: Re: [PATCH] x86/monitor: don't open-code
 hvm_has_set_descriptor_access_exiting()
Thread-Topic: [PATCH] x86/monitor: don't open-code
 hvm_has_set_descriptor_access_exiting()
Thread-Index: AQHX5gUaclLxOWzfx0242LqfvNMvRKwp7MWA
Date: Thu, 9 Dec 2021 09:09:02 +0000
Message-ID: <43CAC5B0-4589-47BF-9F3A-5EF530C1B2BF@bitdefender.com>
References: <925bb889-8048-e275-12e7-a4f5d31fb76d@suse.com>
In-Reply-To: <925bb889-8048-e275-12e7-a4f5d31fb76d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3693.20.0.1.32)
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=bitdefender.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23ceac6c-cc37-4061-85d7-08d9baf38b2b
x-ms-traffictypediagnostic: VI1PR02MB3215:EE_
x-microsoft-antispam-prvs:
 <VI1PR02MB3215B6B244A59C055E51AB60AB709@VI1PR02MB3215.eurprd02.prod.outlook.com>
x-is-junk-enabled: fGZTSsP0qEJE2AIKtlSuFiRRwg9xyHmJ
x-ms-oob-tlc-oobclassifiers: OLM:1107;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 W21GqOzGFR0Bu5I0eDsACCBcUAwuwxdSxM3GVtxX+slWAdGpWqjCGdTX1wAQKvPvNjSryqqHtiqa3PcQJmu4WIVpSlOfWzwuwVuopYgMPvyiEcoRcB8JHzMgTeV7bbqopHskW+7vUxIy0kKgQ7OIQcHnaJwWDL8ks4ZT0sFdVU5+dOqBJ3YZcz0VipxDpcqVLWQFi9WMC0u4/6zTRBBfzrp9MwHhkhlZJ4nK39Qjx5M3KttO/msoxZu03tx9rl66fOeD6yIoqbpUd44SLaMU+TOf7t4wV4Wziuuh/nSX9heYIfdVeJ9sHMa546rb3StFJoa+/DPOxoetkuFmESpM+qxGh5LKrgXxAMIHeO6nagX6maU0kln48zhP/cXAgYrLzbOkg+kJ1X+qKZdepfI09aHx+uNqb73bcREkbQX/s6DVUSKAXyLY64qRAFXl01nWzbxg7q58U3XFnEwUquEax9kIqczxpoXFlIY4/R8ofJuhH0tWmXUDt90qBWgGuYXrxNivSjmhxkps2WEAoXcfyKejD7nfN9IBDM1UuJ1xnTLQhzgp35hojOvV6W/2/aubGICQGl3cYlUJ1zxs1THdtoONQmlPaAnE/7eibxCqUwP9aAZRrdNC9SQOG6czldve0wMnR/eycqHGz3eaLXekZSTG4emfMIqv+YLvs9ydl/anBagRU9RO4QKxhBAXppJFTttVxnWP1Ws3wBv+zbIjalaU54SvsI/huBpm50jBcRA=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR02MB6126.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(498600001)(6512007)(2616005)(26005)(66556008)(64756008)(91956017)(76116006)(66946007)(5660300002)(4326008)(38100700002)(33656002)(66446008)(122000001)(107886003)(36756003)(86362001)(38070700005)(6486002)(186003)(8936002)(6506007)(8676002)(4744005)(71200400001)(53546011)(54906003)(2906002)(83380400001)(6862004)(99936003)(45980500001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?3wDYLKTKztod7rOUlxeosiafslgYUfZIFBnhdZ9R72vRQGz4PVizFfrjpOL4?=
 =?us-ascii?Q?8odyK2gHKaDc3vVqIMEjHA0EKpkWMf3dBNTCKZ9o5OrObPnMYUwR//MXlYtI?=
 =?us-ascii?Q?La7VGyuLTt5KkRC/ALW64KpQfLj5E3Z7o6YgB2U9+s059Us3DazlyVl3P5MO?=
 =?us-ascii?Q?E+dQqUFKPPB9wLHpBfLX/wvdFhSreIejEgJly1GJrNaGYS/SNtAxf4fpMf4d?=
 =?us-ascii?Q?lNk3meOZAN/SZVktwenVQyQBzdgZZkvaEj8GnUteiWt1WLDwy1qUnLL9nqab?=
 =?us-ascii?Q?K9F48pIgI/XVBwbcjCt+QU1rYXCjhdNOSxjiXAk/y0e2P8m86hhdzMuFBr/Z?=
 =?us-ascii?Q?9uO/s1nQOyPi2BFGVqENO7FpgwrizdOwidTe8BeouUMeF/4tGZnhI5qNsfgk?=
 =?us-ascii?Q?PVCgPkoCX0UsvLYAwpdvEYw6FG9zdTtBrYx5qnVG+qjJjksdI5hmmtFqR1ID?=
 =?us-ascii?Q?wOSkmjFDcyhiDgYR/MXHpaM2/RMV6MUbrZ94+6RPo558c1KXwcFTw/ASVK+1?=
 =?us-ascii?Q?h1AFPLutv/3XRbrZ9FwHOOXEC09qCtQThxlFLG1JvtFG3yhiE4VnRk+tKCwh?=
 =?us-ascii?Q?4Or1W3S6T/PjpM4siQdCldg3iLKJxJ/rewqGqPmZ6jtA0PpvHfh7izWv90B+?=
 =?us-ascii?Q?gouJW5G0N7k7Zaq3tN9H6UYAYcXuIk9wJTgfuhhillPeqi6GAiTbb+KD/GRD?=
 =?us-ascii?Q?0GZnVj/nbc3DmePK/m147PVisVRLdrCn8dHWSoBhM/0ijtJXBrPqu4xX8jrE?=
 =?us-ascii?Q?9XQoZdQj3pqtpzt9xU4ANB4VSw++lcnutHCJGTlyejalT9z8aBWD/GK2V4u5?=
 =?us-ascii?Q?OG8FgMqXU4ugn4Hv9i+lJqBeiMoGgF34vxsIKBeiegU7EOij15ozSDN5C9gy?=
 =?us-ascii?Q?nu/y9BcOtWqA6vKzBvTdXcNmS2XOxxFdHBFi5KA4rVuqO0rjkLky7acxNujx?=
 =?us-ascii?Q?eZZKop+IGOb5RP3AFreq6GTnBb1iJVxTa8n6DJCEIAR63E7U2KitzmTjJBzp?=
 =?us-ascii?Q?QOd6gjyxf9Ce2mfJPeiRplUqE/YVlYy1z5Nw+/dv21gQJGNDNtSF8Hr+bhP/?=
 =?us-ascii?Q?WC14z1zoWPtMv5MePBiZs5QT06hLPzmDx6e/Ew+UwLQL7XhzfUxC4KtvJGDt?=
 =?us-ascii?Q?dBrxQnRDJdgLa9lnzfJ7SuRXCjGP6CTyUSCZ/m/C4sau4jHdmeRT03BAaWRQ?=
 =?us-ascii?Q?6fEjj1oo4nKmobjW2u/8IVwfXkSB/zjgfE1K/qmAD2QFGNYgio7RM4bE6nUs?=
 =?us-ascii?Q?mFQFufV9H6LtCBoUmq51eVBvmkZMy6sg0gfB54cTr5XvxbytpDpCflfQx054?=
 =?us-ascii?Q?MgosuwFzY9QpkhQtp1sfsi80DetCLsIqR1lHr2rmKPFB1QsqgQxHH06HHKeh?=
 =?us-ascii?Q?bARGiFomRVUXZMUYGZflEGP6j4EcoM1h/q6P2kNxwrLsshlzuG28bR2Ellf9?=
 =?us-ascii?Q?9nu7TdYTGPFb3CjaI2d0JfNsUX/Kmaznd0iPYkxMW7SZf0c+6lwc5Ye7RqFZ?=
 =?us-ascii?Q?P0x9PRnHTIu6lsl3vYhma17xu+1+7k3oRuT4bhtYsqIVZ+UXXRt3PCSqF/7+?=
 =?us-ascii?Q?lxpntxt9bDh3lB31tuVb4z6pzuL9+xNkViunGELhC8hoqcbq9kehgH20NDin?=
 =?us-ascii?Q?LJAifQfmk2HouT+Z0f+dvf0=3D?=
Content-Type: multipart/signed;
	boundary="Apple-Mail=_E42F8668-614C-45FC-8606-0B8B73121BF0";
	protocol="application/pkcs7-signature";
	micalg=sha-256
MIME-Version: 1.0
X-OriginatorOrg: bitdefender.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB6126.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23ceac6c-cc37-4061-85d7-08d9baf38b2b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2021 09:09:02.2637
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 487baf29-f1da-469a-9221-243f830c36f3
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: comM74L0t2yGDlYzn2VJK2P+KnFA2AgGMB9TQrzwGaRYYy/E5EeBQAFc6ROCeDozXvHtKlaw8lfxodZumxA5Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB3215

--Apple-Mail=_E42F8668-614C-45FC-8606-0B8B73121BF0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On 30 Nov 2021, at 18:11, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> CAUTION: This email originated from outside of our organization. Do =
not click links or open attachments unless you recognize the sender and =
know the content is safe.
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed by: Alexandru Isaila <aisaila@bitdefender.com>
>=20
> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>         if ( unlikely(old_status =3D=3D requested_status) )
>             return -EEXIST;
>=20
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>             return -EOPNOTSUPP;
>=20
>         domain_pause(d);
>=20


--Apple-Mail=_E42F8668-614C-45FC-8606-0B8B73121BF0
Content-Disposition: attachment;
	filename=smime.p7s
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Transfer-Encoding: base64

MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCCCMw
gggfMIIGB6ADAgECAhNQAAJ5AUvsoOMrGKfuAAIAAnkBMA0GCSqGSIb3DQEBCwUAMEsxEzARBgoJ
kiaJk/IsZAEZFgNiaXoxGzAZBgoJkiaJk/IsZAEZFgtiaXRkZWZlbmRlcjEXMBUGA1UEAxMOYml0
ZGVmZW5kZXItQ0EwHhcNMjExMDI5MDg0MTU1WhcNMjIxMDI5MDg0MTU1WjCB4TETMBEGCgmSJomT
8ixkARkWA2JpejEbMBkGCgmSJomT8ixkARkWC2JpdGRlZmVuZGVyMRMwEQYDVQQLEwpCQlUgT2Zm
aWNlMQ4wDAYDVQQLEwVVc2VyczEdMBsGA1UECxMURU5URVJQUklTRSBTT0xVVElPTlMxJjAkBgNV
BAsTHVBST0RVQ1QgTUFOQUdFTUVOVCAtIEJVU0lORVNTMRkwFwYDVQQDExBBbGV4YW5kcnUgSVNB
SUxBMSYwJAYJKoZIhvcNAQkBFhdhaXNhaWxhQGJpdGRlZmVuZGVyLmNvbTCCASIwDQYJKoZIhvcN
AQEBBQADggEPADCCAQoCggEBAMmWwHRKu+U4o5VCEP3K38esc1zHbE+WI3gi8imNnJQcKPJDidU8
bHYNQnX6mFUMjAg0gaydLYbWKgZKYG9D53A9cPgAGDv+xdyD9Kjkscxome1qeywW6bqbPaA5+3PE
Iq7+c8CGEa6Gkw+6pJ5ushwQxsepfMNcB3N7zadcTinLlIoXx2WMCKi7XfqFZXpfrVU5ezDSJ/yx
dKzu7R96+H0uFdgZa6SjKZsJw1cogHw3ZMadxAlWvmYHt4ZvSGR94roAJobOwZCAmgK7GcqRVwpb
EmNWg1/h21o7BKN+Rz1wzBbLNWpe6Fvv0/O7sFAZAq5cnc4PL0zlIZaNqQ3x3LUCAwEAAaOCA2Mw
ggNfMB0GA1UdDgQWBBQi0bYdiCPFYr2gNqXUJA5slfiTFjAfBgNVHSMEGDAWgBSdi+LOCc7doI/g
6xap+dZqQPiyaTCCAREGA1UdHwSCAQgwggEEMIIBAKCB/aCB+oaBuWxkYXA6Ly8vQ049Yml0ZGVm
ZW5kZXItQ0EoMSksQ049ZGMwMSxDTj1DRFAsQ049UHVibGljJTIwS2V5JTIwU2VydmljZXMsQ049
U2VydmljZXMsQ049Q29uZmlndXJhdGlvbixEQz1iaXRkZWZlbmRlcixEQz1iaXo/Y2VydGlmaWNh
dGVSZXZvY2F0aW9uTGlzdD9iYXNlP29iamVjdENsYXNzPWNSTERpc3RyaWJ1dGlvblBvaW50hjxo
dHRwOi8vZGMwMS5iaXRkZWZlbmRlci5iaXovQ2VydEVucm9sbC9iaXRkZWZlbmRlci1DQSgxKS5j
cmwwgcQGCCsGAQUFBwEBBIG3MIG0MIGxBggrBgEFBQcwAoaBpGxkYXA6Ly8vQ049Yml0ZGVmZW5k
ZXItQ0EsQ049QUlBLENOPVB1YmxpYyUyMEtleSUyMFNlcnZpY2VzLENOPVNlcnZpY2VzLENOPUNv
bmZpZ3VyYXRpb24sREM9Yml0ZGVmZW5kZXIsREM9Yml6P2NBQ2VydGlmaWNhdGU/YmFzZT9vYmpl
Y3RDbGFzcz1jZXJ0aWZpY2F0aW9uQXV0aG9yaXR5MA4GA1UdDwEB/wQEAwIFoDA8BgkrBgEEAYI3
FQcELzAtBiUrBgEEAYI3FQiB4LcA2tZhgrGfM4am2G2Ds/tpVITGoRmH9eNMAgFmAgEbMCkGA1Ud
JQQiMCAGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNwoDBDA1BgkrBgEEAYI3FQoEKDAmMAoG
CCsGAQUFBwMCMAoGCCsGAQUFBwMEMAwGCisGAQQBgjcKAwQwSwYDVR0RBEQwQqAnBgorBgEEAYI3
FAIDoBkMF2Fpc2FpbGFAYml0ZGVmZW5kZXIuYml6gRdhaXNhaWxhQGJpdGRlZmVuZGVyLmNvbTBE
BgkqhkiG9w0BCQ8ENzA1MA4GCCqGSIb3DQMCAgIAgDAOBggqhkiG9w0DBAICAIAwBwYFKw4DAgcw
CgYIKoZIhvcNAwcwDQYJKoZIhvcNAQELBQADggIBAEEFQKaTzxua/hT1lzgInDU0MAhZT3pLc3Kq
FwzWIdpqFXlRLePzq/WrF/5fxp2rkOjJwQbVkx0W3Vb11AluFW9mZcN7qpnl5tT9BNTF9pJntgjW
4NOGrmJGGHVZSNQIs7ZgiAyDx7CvSaJBpiPjuCwzsvvueARswatw9GHVlXKAcYbInvkT81APtlwJ
Sj1y9GjyhlGw7tiGkDmqmmK9+CwsL9G5dwtFnVz+TAyRBSOZYus8ZNxBnn8Z7HAXufRQ/h4HRIEj
ucBqj3JIqpjgf+9vOHBDmmaen000RKS//cd7YyBzExPGVvoB0GBcDPUhfxOdmwhZoPlI61eHiI5O
V75lHI3MyWswMbvEi8Z4W6UdW7+m10QEO/aLrFd8dckGp+CYCjbuGglnQT2WaQl2zVkYBJLkqgDX
TojlgAoAMFgEwo8BocURIipgqprymkQ3iUtwnVdlUD1I6Sphkx2IXy9pLb+JQakAnmnWN4OA5QWO
0MbN59wZhu6eVVMUrnCX2KmrO5zf7AA8ioRRIU6AmUnp2J5ZXxVftdagsIiySX3RSO0/Og5uMYIC
DrYPz7UGfMjqqPViW98G0LlsIzNI6Prs6zSrwSbWHbjKC3quJMrQ/EPpTJNbKBwpkZh5fgjgW5w7
JqA0QaQt1gjG6aHtssi+CxMI4dbI8QEdSSnVDALhMYIC4jCCAt4CAQEwYjBLMRMwEQYKCZImiZPy
LGQBGRYDYml6MRswGQYKCZImiZPyLGQBGRYLYml0ZGVmZW5kZXIxFzAVBgNVBAMTDmJpdGRlZmVu
ZGVyLUNBAhNQAAJ5AUvsoOMrGKfuAAIAAnkBMA0GCWCGSAFlAwQCAQUAoIIBUTAYBgkqhkiG9w0B
CQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0yMTEyMDkwOTA5MDFaMC8GCSqGSIb3DQEJ
BDEiBCBrDyyRPHEbUIEys6bLhXoRIcNogjLt9cF54DyxKN8HyDBxBgkrBgEEAYI3EAQxZDBiMEsx
EzARBgoJkiaJk/IsZAEZFgNiaXoxGzAZBgoJkiaJk/IsZAEZFgtiaXRkZWZlbmRlcjEXMBUGA1UE
AxMOYml0ZGVmZW5kZXItQ0ECE1AAAnkBS+yg4ysYp+4AAgACeQEwcwYLKoZIhvcNAQkQAgsxZKBi
MEsxEzARBgoJkiaJk/IsZAEZFgNiaXoxGzAZBgoJkiaJk/IsZAEZFgtiaXRkZWZlbmRlcjEXMBUG
A1UEAxMOYml0ZGVmZW5kZXItQ0ECE1AAAnkBS+yg4ysYp+4AAgACeQEwDQYJKoZIhvcNAQELBQAE
ggEASj0ME/Z4najXWZnxLiGAn7jEMr6daSkWWA+hAcdcYzOpTtpwZqTvUNZ4BdzGYHRTck8yLMLo
M0gkyZsNWz4BRLpru6UvQediFpazJ5/vtjR6zTpv+ltvwxhVdL0jRZsfClA3YHWphKFHOLusllVP
3k+2D1nyhDbE5nQVDR7lt5rr55lM6/kZWoiMPb2MIHgR9DyxTlpFrKdPdCzDbLnJrqji5iJ//Txw
Q0AVpj5DJ1bo7cOpXZvGnF0wPV3nOMuEG8LcKlRfIhEEDuu7gk7UhFGDHWL+IC+nIsqIvTameKNt
QjCFx1BJ1ObQMteKgVLxuDkV8qZQ98CM4D1XaHG9VwAAAAAAAA==

--Apple-Mail=_E42F8668-614C-45FC-8606-0B8B73121BF0--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:10:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:10:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242843.419963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFS2-0006oP-0D; Thu, 09 Dec 2021 09:10:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242843.419963; Thu, 09 Dec 2021 09:10:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvFS1-0006oI-TT; Thu, 09 Dec 2021 09:10:53 +0000
Received: by outflank-mailman (input) for mailman id 242843;
 Thu, 09 Dec 2021 09:10:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvFS0-0006mv-44
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 09:10:52 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e796d1a6-58cf-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 10:10:51 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8D204210FF;
 Thu,  9 Dec 2021 09:10:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 40ACD13CB1;
 Thu,  9 Dec 2021 09:10:50 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Nr0nDhrIsWEEbQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 09:10:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e796d1a6-58cf-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639041050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=O0/q0lcnboL7ga/D2o4Fy+JZSdBjnHljVJtkw7hSPWU=;
	b=SnsqcVogChp8saCKzZYtrFZ+MBghROLLjBFqkybyWz62F0gbU7D8geeXv4NIe1Px2M0xab
	cjc0QF+MEfurxI6Y5GeRVFAnZaAwwniwLt3+TLXU88V49dSfmH2evMxwqCOIAHlusHclX0
	Xycdrj4RUrf9JJp4r1ZcR4vOeEgPA80=
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
 <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
Date: Thu, 9 Dec 2021 10:10:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="FWM2SvzJAbzy4GzBJIY67bVXbSOmymYzJ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--FWM2SvzJAbzy4GzBJIY67bVXbSOmymYzJ
Content-Type: multipart/mixed; boundary="NkC1vCOdIZ4VlLLmVidLph6dSDWCbHhJA";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
Message-ID: <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
References: <20211208155606.20029-1-jgross@suse.com>
 <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
In-Reply-To: <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>

--NkC1vCOdIZ4VlLLmVidLph6dSDWCbHhJA
Content-Type: multipart/mixed;
 boundary="------------8E2CA43E18633AE3B69BB9A3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------8E2CA43E18633AE3B69BB9A3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 10:05, Jan Beulich wrote:
> On 08.12.2021 16:55, Juergen Gross wrote:
>> In order to avoid indirect function calls on the hypercall path as
>> much as possible this series is removing the hypercall function tables=

>> and is replacing the hypercall handler calls via the function array
>> by automatically generated call macros.
>>
>> Another by-product of generating the call macros is the automatic
>> generating of the hypercall handler prototypes from the same data base=

>> which is used to generate the macros.
>>
>> This has the additional advantage of using type safe calls of the
>> handlers and to ensure related handler (e.g. PV and HVM ones) share
>> the same prototypes.
>>
>> A very brief performance test (parallel build of the Xen hypervisor
>> in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
>> the performance with the patches applied. The test was performed using=

>> a PV and a PVH guest.
>>
>> Changes in V2:
>> - new patches 6, 14, 15
>> - patch 7: support hypercall priorities for faster code
>> - comments addressed
>>
>> Changes in V3:
>> - patches 1 and 4 removed as already applied
>> - comments addressed
>>
>> Juergen Gross (13):
>>    xen: move do_vcpu_op() to arch specific code
>>    xen: harmonize return types of hypercall handlers
>>    xen: don't include asm/hypercall.h from C sources
>>    xen: include compat/platform.h from hypercall.h
>>    xen: generate hypercall interface related code
>>    xen: use generated prototypes for hypercall handlers
>>    x86/pv-shim: don't modify hypercall table
>>    xen/x86: don't use hypercall table for calling compat hypercalls
>>    xen/x86: call hypercall handlers via generated macro
>>    xen/arm: call hypercall handlers via generated macro
>>    xen/x86: add hypercall performance counters for hvm, correct pv
>>    xen: drop calls_to_multicall performance counter
>>    tools/xenperf: update hypercall names
>=20
> It's not easy to tell which, if any, of the later patches are fully
> independent of earlier ones and could go in ahead of those awaiting
> further acks. Do you have any suggestion there, or should we wait
> until things can be applied in order?

I think all but the last patch should be applied in order. The last one
obviously can be applied at any time.


Juergen

--------------8E2CA43E18633AE3B69BB9A3
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------8E2CA43E18633AE3B69BB9A3--

--NkC1vCOdIZ4VlLLmVidLph6dSDWCbHhJA--

--FWM2SvzJAbzy4GzBJIY67bVXbSOmymYzJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGxyBgFAwAAAAAACgkQsN6d1ii/Ey+g
TQf7B2W18qR7rZwPW4ff4dlhvhiVk537U0XI0cCEK3YPXmU0HNQORXoQgLBkEiT1m9g7izUPG2fC
9InIGrWcRL/0dqIj8cnPDZsyI8obP+d8XFkbJ4clUXKlZvYnObLIoUA7tqEO51/nnEjVHd8FTIx6
2U5Qj44X59bxAEfzX3AhJZvTiuAGrl2ZmzNOt2Uq67ByBoqmR0/U6YwZPp/6t96le5TrSDKRHVhS
FwpOksqVonkgutcgYTtnSzUVlgq7JlgMskoBy4GAJAqm3CSxX+3w/1HLBdFlE4asM8BGK+6EthRI
zRcFIGW0F3Cj8BJlIoPfuVz5pXd4L2A3dwZ9aOJmRA==
=yA/5
-----END PGP SIGNATURE-----

--FWM2SvzJAbzy4GzBJIY67bVXbSOmymYzJ--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 09:48:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 09:48:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242854.419977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvG1s-0003be-WA; Thu, 09 Dec 2021 09:47:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242854.419977; Thu, 09 Dec 2021 09:47:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvG1s-0003bX-Sx; Thu, 09 Dec 2021 09:47:56 +0000
Received: by outflank-mailman (input) for mailman id 242854;
 Thu, 09 Dec 2021 09:47:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvG1s-0003bQ-7Y
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 09:47:56 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14163591-58d5-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 10:47:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 7ECD4210DD;
 Thu,  9 Dec 2021 09:47:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F3D3C13B2D;
 Thu,  9 Dec 2021 09:47:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Va6vOMjQsWHDFQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 09:47:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14163591-58d5-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639043273; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=1C6zQgjAJeJ96QAqmxMd8NKHmCILXgzUPeajuHhyDyU=;
	b=V9lSMSmLuMTT0snivlo40XUp0WvVbMHpsEOwRKudwnjlGlC1rQct8PhyvL2VVgXlFZwQnQ
	R6QWDaY8l2XAQHr4gdlViMY24qOje3LdZ2t88UslMZ8dfQ/ZdxtpteGWRTztY+Aws+W4x3
	cZVWlD9fNRWZRopa0rtMXJ6lCFShba8=
To: Jan Beulich <jbeulich@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 Manuel Bouyer <bouyer@antioche.eu.org>,
 Simon Kuenzer <simon.kuenzer@neclab.eu>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209070942.14469-1-jgross@suse.com>
 <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
Message-ID: <22ac60e7-7e6c-aa96-f51f-8cfe08b8f62d@suse.com>
Date: Thu, 9 Dec 2021 10:47:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="F1WmOZA2hs68Fkzz9PIwHNjQwxQ4bsWnB"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--F1WmOZA2hs68Fkzz9PIwHNjQwxQ4bsWnB
Content-Type: multipart/mixed; boundary="1FAWMMNHPr9NSI4GtzLxv0XwZpX7nR2qt";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 Manuel Bouyer <bouyer@antioche.eu.org>,
 Simon Kuenzer <simon.kuenzer@neclab.eu>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <22ac60e7-7e6c-aa96-f51f-8cfe08b8f62d@suse.com>
Subject: Re: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
References: <20211209070942.14469-1-jgross@suse.com>
 <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>
In-Reply-To: <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>

--1FAWMMNHPr9NSI4GtzLxv0XwZpX7nR2qt
Content-Type: multipart/mixed;
 boundary="------------FBB0B7555BDE60662B584C43"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FBB0B7555BDE60662B584C43
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 09:48, Jan Beulich wrote:
> On 09.12.2021 08:09, Juergen Gross wrote:
>> Today RING_HAS_UNCONSUMED_*() macros are returning the number of
>> unconsumed requests or responses instead of a boolean as the name of
>> the macros would imply.
>>
>> As this "feature" is already being used, rename the macros to
>> RING_NR_UNCONSUMED_*() and define the RING_HAS_UNCONSUMED_*() macros
>> by using the new RING_NR_UNCONSUMED_*() macros. In order to avoid
>> future misuse let RING_HAS_UNCONSUMED_*() optionally really return a
>> boolean (can be activated by defining RING_HAS_UNCONSUMED_IS_BOOL).
>>
>> Note that the known misuses need to be switched to the new
>> RING_NR_UNCONSUMED_*() macros when using this version of ring.h.
>=20
> Is this last statement stale with the introduction of
> RING_HAS_UNCONSUMED_IS_BOOL?

It should rather be modified like:

   Note that the known misuses need to be switched to the new
   RING_NR_UNCONSUMED_*() macros when using the RING_HAS_UNCONSUMED_*()
   variants returning a boolean value.

>=20
>> --- a/xen/include/public/io/ring.h
>> +++ b/xen/include/public/io/ring.h
>> @@ -208,11 +208,11 @@ typedef struct __name##_back_ring __name##_back_=
ring_t
>>       (RING_FREE_REQUESTS(_r) =3D=3D 0)
>>  =20
>>   /* Test if there are outstanding messages to be processed on a ring.=
 */
>> -#define RING_HAS_UNCONSUMED_RESPONSES(_r)                            =
   \
>> +#define RING_NR_UNCONSUMED_RESPONSES(_r)                             =
   \
>>       ((_r)->sring->rsp_prod - (_r)->rsp_cons)
>>  =20
>>   #ifdef __GNUC__
>> -#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({                          =
   \
>> +#define RING_NR_UNCONSUMED_REQUESTS(_r) ({                           =
   \
>>       unsigned int req =3D (_r)->sring->req_prod - (_r)->req_cons;    =
      \
>>       unsigned int rsp =3D RING_SIZE(_r) -                            =
      \
>>           ((_r)->req_cons - (_r)->rsp_prod_pvt);                      =
    \
>=20
> To answer the "whether" question this was likely good enough. I wonder
> though whether the use of (_r)->sring->{rsp,req}_prod doesn't require
> further sanitizing of the result as it's now intended to be used as a
> count - afaict the returned values could easily be beyond the number of=

> ring elements when the other end is misbehaving. Or if not bounding
> the values here, I would say the comment in context would need
> updating / extending, to tell consumers that they may not blindly use
> the returned values.

I'll modify the comment:

/*
  * Test if there are outstanding messages to be processed on a ring.
  * The answer is based on values writable by the other side, so further
  * processing should fail gracefully in case the return value was wrong.=

  */

> Also imo all new identifiers would better have a XEN_ prefix to avoid
> further growing the risk of name space clashes. But I can see how this
> would result in inconsistencies with existing names.

Yes, I do see the problem.

Would you support switching all the names to the XEN name space and
adding a section like:

#ifndef XEN_RING_NAMESPACE
/* Following for all macros etc. not in the XEN name space today */
#define x XEN_x
#endif


Juergen

--------------FBB0B7555BDE60662B584C43
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FBB0B7555BDE60662B584C43--

--1FAWMMNHPr9NSI4GtzLxv0XwZpX7nR2qt--

--F1WmOZA2hs68Fkzz9PIwHNjQwxQ4bsWnB
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGx0MgFAwAAAAAACgkQsN6d1ii/Ey9d
5wf/Z5mTEFsMO31BJsObip4ExigAhR+NYakGKWVAno6XaKF2nuW6ypeKz+vnmrYATkDGTR2T9Mvm
65rBoEe/ea3zwne2zOgYvmPw+rUEWC3IxW9QdEmksC3bXXHiDVztXpgAsrn5VjDbD65gwzG66c+p
unUNo6x+2Es+cLhKs+x2XqnJjvSTXHjL5iONbw3AE2aSz9mkwSIhW3G1crZN4upGe4KIIoLcLuLr
p4lDwNSzmWqL0SC47t4OVecUc6yzVExYHx3F/i+8D1ZH6N7qStfd5Hp4I8InrKRmK5YAiVUwbjO8
IqCtp/tGSWgUdBMessMe4C1OJtiOmF1mp1UR8y4eUQ==
=cV0v
-----END PGP SIGNATURE-----

--F1WmOZA2hs68Fkzz9PIwHNjQwxQ4bsWnB--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:05:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:05:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242861.419989 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGIA-0006RN-Dw; Thu, 09 Dec 2021 10:04:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242861.419989; Thu, 09 Dec 2021 10:04:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGIA-0006RG-Ag; Thu, 09 Dec 2021 10:04:46 +0000
Received: by outflank-mailman (input) for mailman id 242861;
 Thu, 09 Dec 2021 10:04:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvGI9-0006RA-Dt
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:04:45 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6db65c8e-58d7-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 11:04:44 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-awWb22AFO3yfmADZZ-IWcg-1; Thu, 09 Dec 2021 11:04:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 10:04:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 10:04:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0034.eurprd07.prod.outlook.com (2603:10a6:20b:459::19) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 10:04:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6db65c8e-58d7-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639044282;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IQJolgPx58vBCP3gruV/auBd7uHNx7OWlDec7UmJ8v8=;
	b=Opa5aTov3Cwfdtx1aOzsUfrGfYp67IwvSqwW7dKy13IYzv8chBROIN3t2Ak9Sg8ilMulsE
	VKG2R8iS9Qd0beLCzAw4sJASl+99N8pcBGMg+030puwZ06xHBCvQl6pjCLIywQgB6DO8iA
	byeaFqzrzBmCjmdDguf81Yp1XBT8YYI=
X-MC-Unique: awWb22AFO3yfmADZZ-IWcg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UuVTTgQwCF7OIjZrYAbQR2mQweMVkKIZj6w+IcNcf2E7xnu1jd4hzbIpj4fxcaOZrIEDbzb0nKooC7Hq3gTe7AyQkTeVFo0jWnuFIt1olq/XjqNbRAiNyT3okYYyCjuOQRJt9UyUz0BB5BkdkHfShkUfyWhTOLLpMaH0TK5ILK0Z/tJ5aKuj9vsBM5TgHTQvfH6brJsIKOy53aqWR8Pu3psquYim0DdVFyiGMv0UovtvKkBRtCKV9uU4UEiPQM3QD830LURy/Zfc7KBS0QxyW0bRUXWK6TFV+GnlxehVAn/6bIcRC2nAqrs0+1V+wREqE9UroPPPb+6UBsmQvxv4VQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IQJolgPx58vBCP3gruV/auBd7uHNx7OWlDec7UmJ8v8=;
 b=n8eibC8MytqlfFN9SrGYe9tdvLAy/XUxgDllxb6Os1FrHGukiaE/hvhyeBKl66FH/p15UzPAW3y1NwfdiluQ90prwP9GCWgoEKGCB5K9zVVYx+glqsyaMnDXrjKWfpnyjA/LNSHJ2IL6q8deiHVLGIAcE0wAEKKpNUmkFHpS9fnYgBnnY//oBI0lQTUKnrHpfWWIjFc3Zcp/7NfkFVI2lvRoZ2FqiKlXxEu0fTvJ+kej/FDJXfRbh38Fp9Qcqf/SeFU7Cxx00nLAKOj0i/AawyZGxiABCqzotfOXRzfNm8dJ7EFY2S/b3ORKKlDtRYYuFkG/SFZrqogdPvxVBTLtPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0e664c33-a340-bc97-d561-d96f19afb42a@suse.com>
Date: Thu, 9 Dec 2021 11:04:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 1/2] IOMMU/x86: disallow device assignment to PoD
 guests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Paul Durrant <paul@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Alexandru Isaila <aisaila@bitdefender.com>
References: <8bb92e3f-38b4-16a1-0a45-5f393081f230@suse.com>
 <81a27b5a-99f7-d929-987a-1dcf2433144b@suse.com>
In-Reply-To: <81a27b5a-99f7-d929-987a-1dcf2433144b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0034.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc36f57f-782e-452c-7dd8-08d9bafb5027
X-MS-TrafficTypeDiagnostic: VI1PR04MB6864:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68648B78C76CF1948E703DBFB3709@VI1PR04MB6864.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fO7VFwlxVEODAU5o5aP82JxR8qHZtpOoXb0ibJu48+g5MhFtBDZRnimXpPuF5IPTCaDj3lH/maxRbceZ3XgbHq6yNUn54IBY5FQ7PDQzNw9ZI3d5nsGXGeBISV1FwMX3FAGsaz6frFWYMxPkDswyDadSwHnluIhfpO+uzKo9SedLhZmHi+Zw58gh+W8sUQV0qshqTZlA4Gyj/j2/0YqdkOJWS5ODgNpoXdkCpzrp5T71fPfKQYM/XB9tkrO3Xwk6JxAieEDV9uxp+/jXc5AzCauxfVL7lwW5Xo+59k1OzpNV3MYLH01Uc+Uq1ymYTvYEsFiZ2UWCKxTdbny8FmRQkoXqt6/1icRXdCxxDQqkU7uR/3sqQcEkllbnQ0uTSXPvFqvLL8k2EyeK+jn2lk1+0x5EoNUB4KquV0tzTzb5YkihejJQqq1DiKK7h7kwd1QSsc5N/BVxkzyretk6orTV8Op7+KHdUCz1+bS6sKgKJ84gXTSKIpc7zTnjB7pWAcTQ5ovpiAK7Gc8DxT2LucR8ToA9+slt5v9xWjkpH8+IDqmAJYMia8xNT82DKb8MxvhlvHB080Op8IeaIPDWOGwVaLUdjg6msMp/ibYJu4rO3v6PPG14k6EgOLaxzyA8KJFu5NEQ+eV7kUHfGDkbfu25M1oy+kUDMYXkfovtIjWvdY6ed8pHKO0V2527qizpGE3XDcgL/eHaUmMzMT00I8fx8zly+SNj+EvJeawewDTAeLo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(316002)(16576012)(6916009)(6486002)(4744005)(31696002)(54906003)(5660300002)(4326008)(66556008)(36756003)(2906002)(186003)(53546011)(8936002)(86362001)(26005)(8676002)(956004)(2616005)(66946007)(31686004)(66476007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S1lwTnFZSGJhL2swMWlaRmlJNW5TMUxRQVdiVTA1aDFRYlRZcDRYVGtpWlZx?=
 =?utf-8?B?ZDFITGtQdjBmc0h0eFlhQTdWRUhtSjZaOExRNHZ6c2hhS1BZdGRQVTVKV0Qv?=
 =?utf-8?B?L1g0YmozY2lOUjhoMVBtVHg1UVVTamYyaUFnTlY0a2trbnNVcWVtTGNvVUZx?=
 =?utf-8?B?L1BJOHYxdWFKNnM2ME9ZazdlYlBKWDdBanM5UWhIUTUxc1dzS014K29EK0tL?=
 =?utf-8?B?RGtXUGl4Q2VreTBnWHhkenZJU25KQitTTm16N1U1VVcxcDBlbGltSFpUdVZF?=
 =?utf-8?B?Kzh2UDFjKy9ScklnMzJnSDdxNEtSL2hMWUV4YlB2a0ZzWUx0Y3R1ckluWG50?=
 =?utf-8?B?akZJaS9RekxlcFJrUUh0djFFeldDNVE3b3hSZHBVWVFoVFlYN2Frc1RjeG1n?=
 =?utf-8?B?Y21vQnFpd1Rsb0JyVzlkdng3YVZxUWJKemVjZ01rU2NQdXBycEs2bzJsdDZ4?=
 =?utf-8?B?eHhPNXpMbGNhK2ZNa3Y3T2xUVmY4NUdPT2NlMG10VkxKZHhlamdCU1B2K3Qz?=
 =?utf-8?B?ZUorMGNmR2NkNFFiUHdIZjNzSUVqUGwxT2JrOHJoTlNkTkx0NVZ2Tmxsa3lN?=
 =?utf-8?B?KzhwVE1jemw2SXlhZFo0eCtKTTdscUE2Z3dFbEU4NkE1YTFQU2JxTWdrU0hT?=
 =?utf-8?B?R0d1TzcyTy9saGJjMG10ZVVJSG1TQmlSRnFOd0RDWHBNK3VRbk4zYjNweWQr?=
 =?utf-8?B?UzFRQklGZFBXbExjZTduTW45RkJsQ0o0NFlWWmJJZVh3eWVPdllDeWZQSU03?=
 =?utf-8?B?QitKVVRiRnRSUGpIUWF4RVgrQnM2elBNZEpRN0VWMkFPT0lhNVJaSFFVeThu?=
 =?utf-8?B?bnNVWXZ4MDdZaEVWWlRrRXpRem5PRlYxYk96T0JMcmxORlFFTXZOS1NIa1oy?=
 =?utf-8?B?M1JQZU9NcWtXUmxaT3BhbEdia09qYUw5UVBHVEV0VHppSi9vejhwRHI4RDgy?=
 =?utf-8?B?dUJYZDAyV0ZsRU9VdnlRb2FYd1NuZXNoeDY4bjQ4NE94V3REZEowZUNWakZI?=
 =?utf-8?B?M0d5NmpoZDY3T0VuTVkwSXVOVENDam83Z2lIc0kvWmwvY29qSHV0SXlqbXZE?=
 =?utf-8?B?U1JsTmd3OTBNay81SUQ1dHE1SXY1eWlFUGV3aDVna3dGZ1FWQzFzaHUxQ0xs?=
 =?utf-8?B?aGhlMVFYRVhPZk1xelFFcmNaMTdzNlFqTlRPeEo4Q3J6eTBRaEU3VjRyUnhn?=
 =?utf-8?B?ZmtQcUVwM3pDdENOK3dNNGVFRzhVZEJnM3pseXZPOVl1WUFGQ3pYWWl6SDFR?=
 =?utf-8?B?TTRvcTY5MkhBdG9pRXBINkRaTjZNenRlYTE3UVYzcGsxT2hjU0t0NDVtT3Z5?=
 =?utf-8?B?bGdWT3pKOGoveS9oaWpHOVo1NlFuanRpRXk4WUsrVVJiVFo4alJjTnp2YWFJ?=
 =?utf-8?B?NEMwd1dYc2ZhalhxNWpJeUxSeGY3VHVuYUVEU2xxUmNtMWVVYnZ3N0tYYjJ3?=
 =?utf-8?B?Z2NaT3lLZ2JrZTNRMFdxZ1BqN3V1YUtpcCtDSHhzSXhVSVA3bk82MHRaeXpW?=
 =?utf-8?B?L0F0NWJyWVEzS1FtYUVxSFF0T3l6UGtwemR6QnE4Z2tsMkQrRHlxU2pMdGFB?=
 =?utf-8?B?L1VDRmlYc3dkc092a3BtL1AybzMxbTdpNS9KOWdOMnZhYllzckw0N1ZmZTdR?=
 =?utf-8?B?dWFLazhLOERPekY3TUJOTmNOVE9IUzNIYzlaWDQ1bTNya21NWmY3UFA1bDhJ?=
 =?utf-8?B?cjBpY2xUa2JzNTNjNm1QVkNkcU05UDNGTG5vNFgyVFI3VlRMRFhMNDNQdmZt?=
 =?utf-8?B?akdUZkNSdXYvZlVLR2hSOEVMTzdldHpxMXRkdTdLR1JJSURQbC9qNk9KbXMz?=
 =?utf-8?B?MGVqRndWTWJzdFAwakFlRXBSY0dvTlhOZFhMVkRPQWpSTXBYMU1nZUlQWk5F?=
 =?utf-8?B?dDhVcTA3WEJWelNTNjJMb2s0OEFNQ25WUHZVa2J0eFM5cXdpem9Mc3IwR3BO?=
 =?utf-8?B?TWFUaUd0VnZOdFpFUXdsNjhibE1WZVBrNnFidEpCcEg0dklYdkdETXZuaGtr?=
 =?utf-8?B?dFp4Um15S3RtbzZRQUtPZzhmeCtYeE0wTTRFazB1ZStBSmFzeVN5c3NIU1FS?=
 =?utf-8?B?ZEV3SkJQY3djQ0dDVTF5REdkVys0MFJ5VUZKWlJnQXFPbmNpMzBEbHM0ZEFk?=
 =?utf-8?B?UFBickFFOTFnSGc4VzZpeXk2WXRvSytZQ1paSDlBdkdHU3o1SWphU3NCOVVj?=
 =?utf-8?Q?dIuDpw/tyg4jDXlJco3QOlg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc36f57f-782e-452c-7dd8-08d9bafb5027
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 10:04:39.5967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jPG84+qRQaLVW7t85INq0kmezhmBobVNdY3tzrbzkjNWSEQD1zNdKd0G2FwRcmCZr2XUfvuAAkAf3DuEbHh7iA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864

On 01.12.2021 12:20, Jan Beulich wrote:
> @@ -333,6 +334,9 @@ p2m_pod_set_mem_target(struct domain *d,
>      int ret = 0;
>      unsigned long populated, pod_target;
>  
> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> +        return -ENOTEMPTY;

This breaks toolstack based ballooning of PVH Dom0. While I question
the invocation of set_pod_target in that case, for v3 I'm moving the
check down to near the end of the function.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:16:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:16:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242871.420005 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGTf-0008SQ-Mg; Thu, 09 Dec 2021 10:16:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242871.420005; Thu, 09 Dec 2021 10:16:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGTf-0008SJ-JT; Thu, 09 Dec 2021 10:16:39 +0000
Received: by outflank-mailman (input) for mailman id 242871;
 Thu, 09 Dec 2021 10:16:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=A59D=Q2=redhat.com=sgarzare@srs-se1.protection.inumbo.net>)
 id 1mvGTd-0008SD-Cf
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:16:37 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 168e6522-58d9-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 11:16:36 +0100 (CET)
Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com
 [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-169-43TT07apOyiRV62Y01BGhA-1; Thu, 09 Dec 2021 05:16:33 -0500
Received: by mail-qt1-f198.google.com with SMTP id
 e2-20020ac84142000000b002b4bc4ffc49so8028555qtm.8
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 02:16:33 -0800 (PST)
Received: from steredhat (host-87-21-203-138.retail.telecomitalia.it.
 [87.21.203.138])
 by smtp.gmail.com with ESMTPSA id y18sm3753945qtx.19.2021.12.09.02.16.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 09 Dec 2021 02:16:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 168e6522-58d9-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639044994;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=;
	b=eJ3PPnqGbgDhaOFwlkM/pWlsQIi+recOU/k/PNnRCXZzMyx/m2uDqlH2c4YmJC153IL2IV
	Osh0vpH9yIMFTkPN1Bobj65JcZFSRAKVMJRZseojpDEyUS+J2QuUaMWm/j/RA2z3upqyrX
	rU7B6ID90F2sIjtr8dQd5ubBGymX0xw=
X-MC-Unique: 43TT07apOyiRV62Y01BGhA-1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=skSdkMP3/Z5ledz3SKJURFKwF+2QK06u2MtL2wrAHEA=;
        b=AGUKy0WQ8TLqHn09CNvsKn+TpE9BztbKP+AhEzY/CJ0K/h81UMKg/0LqArTV47buWZ
         w5jiHzavFRSAWxcOa9/Meqdsf5vjGEavp3zm1DbMcmLlWx7lLE5zgvXBbZYGQdC3OXiA
         fXg2Jt9voBbfJvG9a0WCWEqyZkm5aBpRncbaBVVoDsfXiZkxZKxKNAg3keNlNYE4HO3A
         ECZpgqjOBbSVw5dgwArE3DXlNpY/D7NKIbk0A/Nm8dN1IfYuuENFTDmRzbEm4bMSPTRy
         QnXtUb9s2AWOtUWzLpvXfWexYqWN5oh6vUaF0D9ZLwYcWtpVwVhtL6JqlqUAXA29Bacb
         h8CQ==
X-Gm-Message-State: AOAM5338MK6LKovQMI0y2OQDRJHTcrURRsHI87jto767ZNzWYFgShYpt
	6vOoDYebSMNmHwdgin6vVa5s8tBPQ0jrwUfNrJEOELnIQn4/EF179NOy1B/MubMDWjIxSZvaSLi
	ZVBkJJ+pPzqXhhbQO0fKUCPX3aHQ=
X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827160qtw.78.1639044993488;
        Thu, 09 Dec 2021 02:16:33 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxRJ/jy5gwTgSypAPgE1xPC61ttuND6x5A5qbkOiCsntHwUEjX6o68lu/SOhEC/Ll9Ki4cxXQ==
X-Received: by 2002:a05:622a:346:: with SMTP id r6mr15827126qtw.78.1639044993273;
        Thu, 09 Dec 2021 02:16:33 -0800 (PST)
Date: Thu, 9 Dec 2021 11:16:26 +0100
From: Stefano Garzarella <sgarzare@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org,
	Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>, xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler
Message-ID: <20211209101626.t5fkmsnjxwjveb5i@steredhat>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

On Tue, Dec 07, 2021 at 01:23:30PM +0000, Stefan Hajnoczi wrote:
>v3:
>- Fixed FUSE export aio_set_fd_handler() call that I missed and double-checked
>  for any other missing call sites using Coccinelle [Rich]
>v2:
>- Cleaned up unused return values in nvme and virtio-blk [Stefano]
>- Documented try_poll_mode() ready_list argument [Stefano]
>- Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [Stefano]
>
>The first patch improves AioContext's adaptive polling execution time
>measurement. This can result in better performance because the algorithm makes
>better decisions about when to poll versus when to fall back to file descriptor
>monitoring.
>
>The remaining patches unify the virtio-blk and virtio-scsi dataplane and
>non-dataplane virtqueue handlers. This became possible because the dataplane
>handler function now has the same function signature as the non-dataplane
>handler function. Stefano Garzarella prompted me to make this refactoring.

Great clean up! Thanks for doing this, everything LGTM:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:19:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:19:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242877.420017 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGVz-00019J-2t; Thu, 09 Dec 2021 10:19:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242877.420017; Thu, 09 Dec 2021 10:19:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGVy-00019C-VY; Thu, 09 Dec 2021 10:19:02 +0000
Received: by outflank-mailman (input) for mailman id 242877;
 Thu, 09 Dec 2021 10:19:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/Bx=Q2=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mvGVw-00018z-QQ
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:19:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0625.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::625])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6beffbee-58d9-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 11:18:59 +0100 (CET)
Received: from DB6PR07CA0004.eurprd07.prod.outlook.com (2603:10a6:6:2d::14) by
 AM9PR08MB6641.eurprd08.prod.outlook.com (2603:10a6:20b:306::8) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4669.10; Thu, 9 Dec 2021 10:18:55 +0000
Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:2d:cafe::15) by DB6PR07CA0004.outlook.office365.com
 (2603:10a6:6:2d::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend
 Transport; Thu, 9 Dec 2021 10:18:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Thu, 9 Dec 2021 10:18:55 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Thu, 09 Dec 2021 10:18:55 +0000
Received: from f2bde170992b.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 F4A7BDE3-19EF-45F0-82FF-23D4E314EB9C.1; 
 Thu, 09 Dec 2021 10:18:37 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2bde170992b.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 10:18:37 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4968.eurprd08.prod.outlook.com (2603:10a6:20b:e2::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 10:18:35 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%6]) with mapi id 15.20.4734.024; Thu, 9 Dec 2021
 10:18:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6beffbee-58d9-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fnsiNX87ajLgfh6tqi80Bzu92jKM8w5R3UugHDcNgJ8=;
 b=nXEqYUZNsjnowV3UzVT1NwMLUXMPsj+/+dFOzKFapElKIbx9lDG9vwFQ7yoSzzvP1pmYf+8tSpoFTjRd2w51B1a2q+/hhL5tT68QdVGF30wwz5+dNhFwrkWQkxICwia+oUWfi/qWxjn2RIV6Pqs3y63etXdfd93cIDUTJYulw1w=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0a9f50c91b3b225e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ilntKihMDRZZBQpt7wko8V8L/oZ700JJf8MVsYVWCtgRUZIkIH53oWsVSQcUp9lSvxrV8zSTBlvne8nZH1feVqy96Knjd3HVcDZfrG+RChBcYu9M2R6nLlJpvzAHg8Cy9AVs5fvma4hGmbRB06wrYtHODVH+ck2hKyjZing95AWXZMKTgQdo2wWBOwTcwebWF7pZhbOlr94JGTLQTcWGPVxI1/wVNMoIQUCU+WYtI3sfQDHy3DM9B0okWKCfHoOIre1h7yk/royyV8cc1Oqjwr0mpaOQXb0eam5XiNLxOZIFejGPUga0YzHBx9PRyHZ6QQjd1mg9Wfn8xO2bRn7kXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fnsiNX87ajLgfh6tqi80Bzu92jKM8w5R3UugHDcNgJ8=;
 b=UEETZ1JuF2rfktw7wMz/45y8Vs1mdKxU3HOasi9GEE4kTu9zLWRueZOisqRomf5J5UA2SA3s+hJKrQiEQkbJsV0PbEHlYk2nZRY4wV/onVzbml7UM3HZG83+QU6wLTY7tQMn0NhUPDBTT9XpnYq+EYr0EKU/WB6CA92d7oQsXUf9pVsmIWife0M/YSM5r2eSuH0TZXkDAoH59g2QdyNqQTbJ17+5ZMUgVy5S/jZK9NriQQHo+Pbju2+OXUxhIxhWLIsjYO2qp+RL0VnZiezpE+VZdipipBKkg7WxAHiq+OmbWYGVSpnp79nkoblaip6g08l9bxc9v8+5brX0d/Yamw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=fnsiNX87ajLgfh6tqi80Bzu92jKM8w5R3UugHDcNgJ8=;
 b=nXEqYUZNsjnowV3UzVT1NwMLUXMPsj+/+dFOzKFapElKIbx9lDG9vwFQ7yoSzzvP1pmYf+8tSpoFTjRd2w51B1a2q+/hhL5tT68QdVGF30wwz5+dNhFwrkWQkxICwia+oUWfi/qWxjn2RIV6Pqs3y63etXdfd93cIDUTJYulw1w=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "artem_mygaiev@epam.com"
	<artem_mygaiev@epam.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHX7M6C5/TVkloENUKtLtY2iMOfH6wp8qEA
Date: Thu, 9 Dec 2021 10:18:35 +0000
Message-ID: <B1713D3D-77E8-44A1-9AC3-D754269DE50C@arm.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-3-andr2000@gmail.com>
In-Reply-To: <20211209072918.460902-3-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 32df948d-e2c3-4f18-28d7-08d9bafd4e6b
x-ms-traffictypediagnostic: AM6PR08MB4968:EE_|DB5EUR03FT046:EE_|AM9PR08MB6641:
X-Microsoft-Antispam-PRVS:
	<AM9PR08MB66411108805AB984BD72991CFC709@AM9PR08MB6641.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 fUd7gSBRpOfwRjpGrt7x406NdiDErTHq61drZ5t+yaFAbEcnQMWpKEuXKYfeYA3WibU5xd7nKPP1+y6M+1fNKbXxM2J1k4iyhPIbaBAurj1bBfXZmIQXrKKwxfQysqhk6JY2dflpuzV/kqGwQDCf2FhJx1xTfEFBC7Yyy9PqFJCus/SdYLUDHOlA/nOKAu3ChU4AufziNBpqCpKjP/FtsCXGYabVFcCtfbEwmZPFyDg5ZC+ipHyS+/ZRX1CzHIf1d+LNNkT5gMGxoU+Rqp2sX6pA2plZyORVtVYoz623odmna+UgPolFr1IL/7cqN3hYuFhIagm244Yz4Tx5NfpyN9VJNPxR699qIdoUE4JBVLnQs41SgbAuhc6JFfWJIloeLKHwE8TVF9WNsTYeYZydOpGYJPWAPEFQFu4f34ezXVUzfxjyFzLXTUKOQX+qkQ3/jQsPcYdBFQGo+jYD3PWc+s213JgvYxTmPDHvDYEDR+0LdRnRcz3Bt26JpMB2+UFI01p7seHmUFrM3h5u5a6wtFaQ+QyO3WrH8ehe/18vFP7ljQe0pMmW7B6BQ/0UM4yK1j8+iM3cH+9zWxnAdCQ7AzyB0tfVO1AKJ5/+G9DGYyUgU4aFwofvZFZUQ3q9nuJ92j4YveKch2aKc7nDlJb2N42ws+U/KhEAVoT6Y6KcI1DxgQStTLIFEtVOdZHhnaDU9xpkpIWKaV8lJeUjUtnIeTvEKoCpYd3/nvpWkaLuqn0QPTvYwy3ConHJ1Jg54DEb
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(2906002)(54906003)(508600001)(4744005)(6506007)(33656002)(122000001)(83380400001)(86362001)(8676002)(8936002)(66556008)(64756008)(66476007)(66446008)(71200400001)(91956017)(4326008)(53546011)(76116006)(2616005)(6916009)(38070700005)(5660300002)(6486002)(186003)(26005)(38100700002)(36756003)(6512007)(66946007)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D3B6DAE15D9C0547B46328161C028567@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4968
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	97a0f300-7488-48bb-8cab-08d9bafd42a4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SgFoH6jeUgzLfNiah5JWkxC3wjdy2mvNZFkUMAWkyJ7x+veq2TMpnTSLUXz7mnuHjKGrG0l8X7PLu4W5ujMkoNOsDbKaU7hO7b29wypqzROiO0pwTbzSnSU/pTvomeza6GZvdACmk6hLT/ABpzK/cQMK5Ml9KfIcj5fzOQs3GmSOkKjH6vwuiqoQl0Rj/TjGD3xseNXmnno/1cmj0Q/alj3L1tkX0rrDnPotWSmgn1IBVf7h3vPfxvwZuE+2WdE2l/HNdVSI+TF1lOkREhNC4IC/WRUg5vYfGmuiNuxCM5c1wYXxDUiqEV1TtQybvTrZBpt1rzbU8PQMfhrFnhZpHP+SywS+A4YkeKGQVmKaR0RfLLim9pvKKjR5EpxGyXecg1B2whIydEriM1AObNjKzUvRgIxH8cC7nBW9k3fO4/BA1qIPTa/oWuJJsuZksH6xs7w7TwrvOnQJo5CylTMO+r6iCt3lfX8if+hCQAQwiphM7L0hZAwk7rnVB4Wjm6rO0p1JmfefI4FwIfFTbNhXjh/ZLdz9Qkghop6wQkLY9gGBLdjSgtwZWMnoKnE7oEyaqQdeieRTJypoILBx9gjk/bwQ2rBV9eotDVvGnTZAIExvu1qKwRpqsZeV7WCocAf87gr87npN7MxSYxERP/63Zjpm7V5XnqOhzYgvqNQYFxgtfy9LYFqsBq2ph0Rwg0ygy89j4Vicqu25hpN8NaaWbq6Qk7/Ya/8d+LGg0fetsw8tebE0zhf/mwKwJ8S4LReinGk63uwUCNFBh3KbRwyq0A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(26005)(336012)(4744005)(5660300002)(4326008)(86362001)(54906003)(6506007)(2906002)(81166007)(36860700001)(33656002)(40460700001)(47076005)(107886003)(83380400001)(70206006)(356005)(6512007)(508600001)(316002)(8676002)(2616005)(82310400004)(70586007)(6486002)(53546011)(6862004)(8936002)(36756003)(186003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 10:18:55.4693
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 32df948d-e2c3-4f18-28d7-08d9bafd4e6b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6641

Hi Oleksandr,

> On 9 Dec 2021, at 7:29 am, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> In order for vPCI to work it needs to maintain guest and hardware
> domain's views of the configuration space. For example, BARs and
> COMMAND registers require emulation for guests and the guest view
> of the registers needs to be in sync with the real contents of the
> relevant registers. For that ECAM address space needs to also be
> trapped for the hardware domain, so we need to implement PCI host
> bridge specific callbacks to properly setup MMIO handlers for those
> ranges depending on particular host bridge implementation.
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:19:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:19:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242881.420028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGWr-0001hX-Fv; Thu, 09 Dec 2021 10:19:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242881.420028; Thu, 09 Dec 2021 10:19:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGWr-0001hQ-BC; Thu, 09 Dec 2021 10:19:57 +0000
Received: by outflank-mailman (input) for mailman id 242881;
 Thu, 09 Dec 2021 10:19:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/Bx=Q2=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mvGWp-0001b4-VS
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:19:56 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0631.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::631])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8bde6dcf-58d9-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 11:19:55 +0100 (CET)
Received: from AS9PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:20b:48b::17)
 by VE1PR08MB5261.eurprd08.prod.outlook.com (2603:10a6:803:10d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 10:19:33 +0000
Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:48b:cafe::75) by AS9PR04CA0064.outlook.office365.com
 (2603:10a6:20b:48b::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13 via Frontend
 Transport; Thu, 9 Dec 2021 10:19:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.13 via Frontend Transport; Thu, 9 Dec 2021 10:19:32 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Thu, 09 Dec 2021 10:19:32 +0000
Received: from a6112ec6773c.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 1F488A30-E7D8-46E8-932E-48BBA014EB8C.1; 
 Thu, 09 Dec 2021 10:19:13 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a6112ec6773c.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 10:19:13 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3400.eurprd08.prod.outlook.com (2603:10a6:20b:42::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 10:19:09 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%6]) with mapi id 15.20.4734.024; Thu, 9 Dec 2021
 10:19:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bde6dcf-58d9-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+Fx0DkfBS/XCOBZLLXfq5BqjRt8vzRSZdNNmdlW2A5c=;
 b=hOnqqb5ERA31haOnUKdjJHBnIfndfYvSoj3nzD30qQOdQZXDGaufVdjlEAEwjhUjZiU87sygVPk1EFJXdPe91Evlql2HMbUYik7rC5RwpF271UL1qXjIjwca3k6LRIMQU6kUkmYuElybKCWj28aFgbxrH8ftE65lmzZEjEYzxOU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 198b7e5e42d4fd91
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FC/eBq00Ss7CSM6f3IjhOHAkxqGcdDy1xrHkkv3deG3N49B5sEqwYRV2HGFiqXkisHlunMmI1HDW1ITb+Gt4hORg/azf2aGiOqhfN7a6I4dp++pV9v01NaNV+/f2KDbgYxpYA8Kf9WbFa8Eq85EqKxaM6ppyPnEjyCU1W8JTB6avi/+R+VgRtlchDXAVjwLdC8y7FCkv5l6I//uJmNpAz/Ist2uwJFGw7pKFfetEAcZ0bPp2Ya6woNSgL8uBzr72uFXxBDFgTd7y22PXveO6V4fQ+5/qe8cLNmLZVvfZDwFu+zE+cwV2p4knUP96A4w6SbKqhgwrYerA48AIRHgNEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+Fx0DkfBS/XCOBZLLXfq5BqjRt8vzRSZdNNmdlW2A5c=;
 b=LcwkZEJmAVxZcXa6hBIt7Nka1Ck6ujxuhZPj3CM9f2a3BNeRbPxd5/lOAZzLaPJ+9sqfrNNLHyhv6Iuyv7hcl7is9ie4E5ahbZkC+F2mslFqXouqfIh/PtqbSZeOgxLr75k8yQVjwj/Owd5qgvaub1w68p6BN4upNXPFyj+Rth+x6xZVmBlvWWvCOerXTDTo1a4+4L9sPfVrAFPake20txP0QqydstaJPlkLeFh9WjLQoQ+lecRwNP+2zVt77BSIs8rHPlhUGGHYMtNHH93SvuuHT/9gO3607nFeLtZdD7xD8GURNwgW5yPDhu4yEgOZJdW2Wed4O+mdeCcpDZ6kFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=+Fx0DkfBS/XCOBZLLXfq5BqjRt8vzRSZdNNmdlW2A5c=;
 b=hOnqqb5ERA31haOnUKdjJHBnIfndfYvSoj3nzD30qQOdQZXDGaufVdjlEAEwjhUjZiU87sygVPk1EFJXdPe91Evlql2HMbUYik7rC5RwpF271UL1qXjIjwca3k6LRIMQU6kUkmYuElybKCWj28aFgbxrH8ftE65lmzZEjEYzxOU=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "artem_mygaiev@epam.com"
	<artem_mygaiev@epam.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, Julien Grall
	<jgrall@amazon.com>
Subject: Re: [PATCH v8 3/4] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Topic: [PATCH v8 3/4] xen/arm: account IO handler for emulated PCI host
 bridge
Thread-Index: AQHX7M6ZJ84IjlvR+0ihD3B1W/9MVKwp8sqA
Date: Thu, 9 Dec 2021 10:19:09 +0000
Message-ID: <168AEE58-0C22-458A-8D81-C2CB9B7A4758@arm.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-4-andr2000@gmail.com>
In-Reply-To: <20211209072918.460902-4-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 26aed6d3-d6c0-4034-ba0e-08d9bafd647f
x-ms-traffictypediagnostic:
	AM6PR08MB3400:EE_|VE1EUR03FT048:EE_|VE1PR08MB5261:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB5261862AAB2D1ED9FA78419CFC709@VE1PR08MB5261.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Cgi4UySHB59XmivmxRTeI/xg01pXn4ESjvP+EDDMHohTFlsVivV5PfgWwMlKQMUNkfcFONdXIrnxMWx1cGQdnmeUDu+9ZY5/4jQmYpVzo6+umLy88HJ6iRAqpg04MHa3RMyfOpY2HrXjaUrsxEIlo3lYpaV/5c7wKG+gjedjiNqYxJM6HvpkBqT5VCQnLNik83lfGH8N9iyuUkxzkIVoD/wIe8fDpPT1ZZwhXCyQnZnW5vfLFg/0miMDdtJEj0qZ2sBC9TMZ1Izy0v1fNudObuSQTQNFnyCLyV1fygCvaR6xZulX4eDLJRH9KHfds1rEGUS4MmAA5FbYuCz57k5DLp7IDBF4ThvOWE8CFl+j0MD3GNoyuHMeuPjEnStkfGnW01ZaGgoGG5McuDHwZI3CIOBD3gkDznloPMpwJoM85XtWSoZLW37DNp8FP315pTX9WF7ETEcOuxNCaSAMIRu41tYbAxCVAAKWuk6opFApAPng01lc0J3Fwpmk4CZk454ZNO6IfNsax+9ftwvrffZLv6VskP886sdN6DH8lUWWZAxYozY4N5kWqwCwzsHX0muCXwFXcTqOLW36Rx0WSnXwj/XF+AdrgIT0aFeMk6rE/auPzyzTsaYvVE5Bm4fYYfkCcQ+5J0NcqpZ3YIx+2rVcPv8D21JlSWiq6AgOylhEB30kdjfzWMdLARcYpOgRL4w4B4dt/4rRvjq8RZfYagH7FuW/EbjQxjU7h4iZZY+2V9g=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(91956017)(186003)(54906003)(316002)(76116006)(71200400001)(86362001)(15650500001)(122000001)(6512007)(4326008)(66476007)(66556008)(26005)(66946007)(64756008)(508600001)(66446008)(4744005)(2906002)(38100700002)(38070700005)(83380400001)(53546011)(8936002)(6916009)(6486002)(36756003)(8676002)(6506007)(2616005)(33656002)(5660300002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FA8FE055E818AA4791E9E97540A09CC0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3400
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c110983f-d128-4d87-ea87-08d9bafd56e8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sJdtRz9dUtWWpbUYEfoya3NOyApiG1Kb6OARJrAiI/p8PcBM1RyAghj87pVdpHZN5lcayHyfl5D1ADfo9krfu//Q9hukFYoI2alP/2I0+P1viZ42OUTc093qmbHhOzXAVNaqXyumNBGRhP/e8A+Lla7DoYb6fKswGF/9HLjSZiArm0r5gEpxEPsE4ZDErf7Hnm3PdQ2bhuQ0OlaqTG83VJ+1a7Lp41eYhAvgVl4Twtfa17DQrp9YbU5kmhXuxMCr0zmKiS2zceeNVJutu/XyruxLLbyqP3lj/bqaxKRM0JtHLGxs6qDJnH+b/zChs5Aimf66yKhe+rVivFJYFYAquxq1QyQdOnaSC4bUIkJ5WH+9cmxGaR/8k6QpyZsrTNxyXIEzob9mWAMwNOPZACoF9T6eP4bgU1WR6qRp4HbGZOq+Zb/BXNZGPBd7wfGteKb60FJplDLOSuAJ3AGqulupVnFLS5t8/3dNNMotrYr9tVqZk2rWhbH4TOCXLrEywVhSIlrtugvOVpoYMmBMDBZmdNnU+PyG3O+QY72y1LOA6jP8IwWFd7AA0GoT4gMIDF2/MgV1H+o9joT4ehom9iO/BXZ9hoA15MSEobxorWpgkjNYP6wy6N2gPknSpVVkrhHW6t3gXKC+fwGmRk4L+AJm0fNaHvXq+lBw9P2v3q0XOfHKj7eV7lfhLpk4UcRlaCPfkfo4qx+8/hKYgAgl1DGrQEaltv21bOhG71OvU8MS5KQuiep+vMhJuvzOkkeqiclK4GK0dPNx1SDnY1ECpTMfxQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(15650500001)(2906002)(47076005)(5660300002)(36860700001)(70586007)(36756003)(316002)(6506007)(70206006)(186003)(26005)(54906003)(4744005)(53546011)(83380400001)(8936002)(6486002)(336012)(4326008)(6512007)(6862004)(508600001)(8676002)(356005)(81166007)(107886003)(40460700001)(86362001)(2616005)(82310400004)(33656002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 10:19:32.3970
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 26aed6d3-d6c0-4034-ba0e-08d9bafd647f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5261

Hi Oleksandr,

> On 9 Dec 2021, at 7:29 am, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> At the moment, we always allocate an extra 16 slots for IO handlers
> (see MAX_IO_HANDLER). So while adding an IO trap handler for the emulated
> PCI host bridge we are not breaking anything, but we have a latent bug
> as the maximum number of IOs may be exceeded.
> Fix this by explicitly telling that we have an additional IO handler, so =
it is
> accounted.
>=20
> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI suppor=
t for ARM")
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Acked-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:20:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242887.420039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGXQ-00030m-U4; Thu, 09 Dec 2021 10:20:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242887.420039; Thu, 09 Dec 2021 10:20:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGXQ-00030f-Pw; Thu, 09 Dec 2021 10:20:32 +0000
Received: by outflank-mailman (input) for mailman id 242887;
 Thu, 09 Dec 2021 10:20:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=i/Bx=Q2=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mvGXO-0002hL-Ot
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:20:30 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on061d.outbound.protection.outlook.com
 [2a01:111:f400:fe09::61d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1c7821a-58d9-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 11:20:29 +0100 (CET)
Received: from AM6PR08CA0024.eurprd08.prod.outlook.com (2603:10a6:20b:b2::36)
 by PAXPR08MB6655.eurprd08.prod.outlook.com (2603:10a6:102:15d::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Thu, 9 Dec
 2021 10:20:14 +0000
Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:b2:cafe::26) by AM6PR08CA0024.outlook.office365.com
 (2603:10a6:20b:b2::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11 via Frontend
 Transport; Thu, 9 Dec 2021 10:20:14 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Thu, 9 Dec 2021 10:20:13 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Thu, 09 Dec 2021 10:20:13 +0000
Received: from f3985fa16342.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A28806EB-F230-4D09-A2C9-783E02B26BB1.1; 
 Thu, 09 Dec 2021 10:19:58 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3985fa16342.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 09 Dec 2021 10:19:58 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6405.eurprd08.prod.outlook.com (2603:10a6:20b:332::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 10:19:56 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%6]) with mapi id 15.20.4734.024; Thu, 9 Dec 2021
 10:19:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1c7821a-58d9-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WXN8hJWdCy0TM2M9Ap9xBzUjFeqpvMZ2r4ODIIAjWOk=;
 b=pbDg7AoJS6IvhFayjT6RTqcdrws8xka7Vfw8GZgjLi95NWAXSQ6IDALhbLS7YtEFEyffH8DbpUtCzRVJWb89qCNpfL/ZhPdzpyow4nSrXnK3ok88qaCuKI3+f8ueluq5QZapJXUFpDRljNEIc5+zL1oli+/nKnDqP0NIEDgdQ/k=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 749b127b722a2845
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=brtuJCtZE6sUyelrBFQQDnaf1u2SQuMrgo3N3QoWjZvAWWfJapIPDVuLRCYurLv7gyoNwpsSxSplo1jvKQQW/2u33oc3sBO9fWgd3+8Hiih4zyxrFxW4RPWwspCfGXcdUv3C38vPogjklS/K7KuppM1NqFUa+GW+fPw2GQA+7pdX99HZz6N1++zvFxGLwH6vWt4Gc31K+0BjFcOttEQZLMbzmOF0WWTSRb8k57NgkvUhOghQwi4oB7c1XISfA59aGF18UqH6st/ma98qxV8JIWCWvPnDTdexvFr7rfzGJGX+QBEkk5GpalCh5sO3gApPqZHB3LoqLur6E2S7dEIUwA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=WXN8hJWdCy0TM2M9Ap9xBzUjFeqpvMZ2r4ODIIAjWOk=;
 b=m1k/czAmQun2G6TVzDyQqdVc4IbIopQ9GOgVAby2SF7iWNPGHG+en6h0IlxfmEISMlf5m3CjNeyqgtmqkNFdhdPrP0Km8qbHes1tqwVGnmfMxIbKZAjWW95O+4qjoEspcdqxydIkQWH3GBz8X+lbA72rgs0kbwxtyWBhFx0Dk7+/cTmq1bfziggtOhw8QD059/WKHlFmSCDAoI211LmQzyrzVf4gP7AM0EptUR/PGwNodj4SFiD66HKQ6Fo6QIiM0ufxw3qbxeGSTMsLQswdElbQxhofAycosE+DA3OBcvn5pDJpNrKTLZSbRIuBLpdUebBomoLKI4k7fbM25uwOVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=WXN8hJWdCy0TM2M9Ap9xBzUjFeqpvMZ2r4ODIIAjWOk=;
 b=pbDg7AoJS6IvhFayjT6RTqcdrws8xka7Vfw8GZgjLi95NWAXSQ6IDALhbLS7YtEFEyffH8DbpUtCzRVJWb89qCNpfL/ZhPdzpyow4nSrXnK3ok88qaCuKI3+f8ueluq5QZapJXUFpDRljNEIc5+zL1oli+/nKnDqP0NIEDgdQ/k=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, "oleksandr_tyshchenko@epam.com"
	<oleksandr_tyshchenko@epam.com>, "volodymyr_babchuk@epam.com"
	<volodymyr_babchuk@epam.com>, "artem_mygaiev@epam.com"
	<artem_mygaiev@epam.com>, Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>, Julien Grall
	<jgrall@amazon.com>
Subject: Re: [PATCH v8 4/4] xen/arm: do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Topic: [PATCH v8 4/4] xen/arm: do not map PCI ECAM and MMIO space to
 Domain-0's p2m
Thread-Index: AQHX7M6EjMHseeuB70ePU8gARpHGAqwp8wGA
Date: Thu, 9 Dec 2021 10:19:55 +0000
Message-ID: <53D00092-2D4E-4142-91DA-2D49FE58F0B3@arm.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-5-andr2000@gmail.com>
In-Reply-To: <20211209072918.460902-5-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: d04e3f4c-32f0-4dd5-553e-08d9bafd7d2d
x-ms-traffictypediagnostic:
	AS8PR08MB6405:EE_|VE1EUR03FT032:EE_|PAXPR08MB6655:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB665579E9AB10D58FD6B40AAEFC709@PAXPR08MB6655.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0HaM+9xjUg7+T1Tnfoyx5m6FHoAPPf1gwVhQFpW4xKWslBvVxSRdTI4UInJ002WMkvrbBUAcJC/ZvkforAF+DKuqetnQgne3oxVPGg7mAmJw4gMjpxT3R0nHv7Km4yP/rtYbjbFbSNDtrE97YBppirx3C0QHdLujwG5IRUi4smRcUFsEaivdKVh+WlrTv39z7/tg6ZivtNOVBkhcnzblbjLmH9mdkyhKwsI6+bKPRVFymZSxId+vtXX81xKItpVS9fm956V/fgLrftQV0CyeOs4ctxrG9Bnc6LbyhwC9JogbY/e8gYsQpfD3kVGONOeB8BAZS+ec+D/YtbKlyJU5WTv1xxlgKXYuJI+NXmzzDShfGdD3w/kr1lqnYYTijzgfdDMtumU5Vl+8kUhBDvlFFxkhTa0TKhKH1U05hqGKUbBS/4cp8Eykq2BrER3A3OfQdr41zssJHZBcgqVlXEmmfjhJfaq+Qwt25XcSXYLeA2ogtzjR7LH7XS2Sa+ok7wQRhuj/B1jTRQNeav/9RCJIdcHy9dNTfoaNm+LoU3qOGEoB21wFGFslCkYxKWDtpWDO04vq6o6rH3EzzhkupDV+ODnMQx7OxDr95+rzG02sHJcwjjQsoujACQf0fox7FMPYjqNSVasUao/EwhbsipzhPkFUhUZLgk+05Bz/Y4wkoGg5ivaM9BDc+YpMtBV1l9Idoss1f6t43iiUrBtMFOdcTUn0G4dU5qJMQeEHdHi1jLb6cdezyLmgEJ6QRLuNhtCPbWDUg8sJ8CIs3A0qLjoLLXK+/R4c23ClC+0CdRr9x8eAt8YyNEreniFshlya/L1xvbsm0knMzU97DsXuAG1rZghY/Xh2wz0Yqp2Pr6Hjxs8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(316002)(53546011)(26005)(71200400001)(38070700005)(66476007)(66446008)(91956017)(186003)(966005)(36756003)(4326008)(6916009)(508600001)(86362001)(8676002)(8936002)(6486002)(2906002)(5660300002)(6512007)(33656002)(54906003)(83380400001)(76116006)(38100700002)(64756008)(2616005)(66946007)(122000001)(66556008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <59241971179F774790FAD0F9FA2DD7C8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6405
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	86502276-c9cf-4d34-f92f-08d9bafd727f
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	wNQ4u6FNIbsul13vl+JmgwQU8w8v9of719CMZiSzPurxHEZSjw/S9IE0zUhEg1Nhr+D+DQl8FVzL30Z8uBqnHbLKHhWkFZHyfhd0fZRvn6s2anAKz1FfSx6RqFvzwnQrKRLqutbqwlI3tknt7uwbQAara1cXPE7wBDGv/757+ZOBcoEB0Pg7cmqLov3alAYPCHrcwetzW+HuwM5pYWMXQdQMXiJHCH7LMHtBM2HFRgCc4MSHccifMWCJSvTZQTvPeeajJivr5kA7YaQNfhrui9PJsnv8bEbcEY58i7uELK5u35uU6cLO8EJs2HykgjWvZysC3fFJp9xsDRwcLb5JPIsLAUuwB1MXiRRN5GBkXtwtFXqFPt91uaFF8hyhHsa47wwaitcrpDO3fXKKkt60PzXQ6+9zF5SQCR8ANdeck5dpbrCZHy/NEwbuyj1Qd0gquc8H+cVliOWh4niOI5KjWfWZsOJidhnZQ70nEuw7E433oY7JKO+Izc/XaJ5MaTMh8R7snkmG3Q38Blwhcl1G2xTl4GbZIjxm5/FiULDqLdJ1KsQnY28LL7+cbL+C6tAjIAfH8LX+s2yT5SIEUustVdLZdlMTomCFf3hpEXYC47VjrmhMW7jURmayrzkl9Sw8oePSBmPn7Pc/ns/Vu30WWnKQO5xtzxUO9zzHnzkpzOuNMYG+wym4QcJLg4uwJLo5BvA32JZfg6JvXSLXtg2fjAVcKt3hf1wptZoTiWhpv3+AvbptpuFvDwzlMYQHFRUYukFcVMzCMVFGPTw9xNfZG6dlBXWRZ5zLxXcD70eurGkGTSorChZEcbRhSRVsbz+nLkDmzm0D5suwWeRL/fw0dRRyG92OgmbFbJLxPz9ebPYOnYk6gxiCYJJg3nIf54QQlwlWwGj/z0yury/xSwIsWQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(6486002)(4326008)(36756003)(2616005)(54906003)(8936002)(33656002)(107886003)(47076005)(6512007)(6862004)(5660300002)(83380400001)(70586007)(8676002)(2906002)(70206006)(82310400004)(81166007)(40460700001)(53546011)(6506007)(356005)(316002)(336012)(86362001)(966005)(186003)(508600001)(36860700001)(26005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 10:20:13.8001
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d04e3f4c-32f0-4dd5-553e-08d9bafd7d2d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6655

Hi Oleksandr,

> On 9 Dec 2021, at 7:29 am, Oleksandr Andrushchenko <andr2000@gmail.com> w=
rote:
>=20
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> PCI host bridges are special devices in terms of implementing PCI
> passthrough. According to [1] the current implementation depends on
> Domain-0 to perform the initialization of the relevant PCI host
> bridge hardware and perform PCI device enumeration. In order to
> achieve that one of the required changes is to not map all the memory
> ranges in map_range_to_domain as we traverse the device tree on startup
> and perform some additional checks if the range needs to be mapped to
> Domain-0.
>=20
> The generic PCI host controller device tree binding says [2]:
> - ranges: As described in IEEE Std 1275-1994, but must provide
>          at least a definition of non-prefetchable memory. One
>          or both of prefetchable Memory and IO Space may also
>          be provided.
>=20
> - reg   : The Configuration Space base address and size, as accessed
>          from the parent bus.  The base address corresponds to
>          the first bus in the "bus-range" property.  If no
>          "bus-range" is specified, this will be bus 0 (the default).
>=20
> From the above none of the memory ranges from the "ranges" property
> needs to be mapped to Domain-0 at startup as MMIO mapping is going to
> be handled dynamically by vPCI as we assign PCI devices, e.g. each
> device assigned to Domain-0/guest will have its MMIOs mapped/unmapped
> as needed by Xen.
>=20
> The "reg" property covers not only ECAM space, but may also have other
> then the configuration memory ranges described, for example [3]:
> - reg: Should contain rc_dbi, config registers location and length.
> - reg-names: Must include the following entries:
>   "rc_dbi": controller configuration registers;
>   "config": PCIe configuration space registers.
>=20
> This patch makes it possible to not map all the ranges from the
> "ranges" property and also ECAM from the "reg". All the rest from the
> "reg" property still needs to be mapped to Domain-0, so the PCI
> host bridge remains functional in Domain-0. This is done by first
> skipping the mappings while traversing the device tree as it is done for
> usual devices and then by calling a dedicated pci_host_bridge_mappings
> function which only maps MMIOs required by the host bridges leaving the
> regions, needed for vPCI traps, unmapped.
>=20
> [1] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg00777=
.html
> [2] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/host=
-generic-pci.txt
> [3] https://www.kernel.org/doc/Documentation/devicetree/bindings/pci/hisi=
licon-pcie.txt
>=20
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
 =


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:26:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:26:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242897.420049 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGdP-0003mW-Ip; Thu, 09 Dec 2021 10:26:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242897.420049; Thu, 09 Dec 2021 10:26:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGdP-0003mP-Ff; Thu, 09 Dec 2021 10:26:43 +0000
Received: by outflank-mailman (input) for mailman id 242897;
 Thu, 09 Dec 2021 10:26:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvGdO-0003mJ-A7
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:26:42 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7fc4bd2e-58da-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 11:26:41 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-GrTsKIDqN9-y7vhlpdRm0w-1; Thu, 09 Dec 2021 11:26:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4352.eurprd04.prod.outlook.com (2603:10a6:803:4a::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Thu, 9 Dec
 2021 10:26:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 10:26:37 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR05CA0026.eurprd05.prod.outlook.com (2603:10a6:20b:311::31) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 10:26:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7fc4bd2e-58da-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639045601;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Ktr193pS08mX1sljE5M2Ea+ogUG4Xlq9xwDI7AlWsFI=;
	b=QYa++v+B+4pGpeWgfu+YlHCYOUso8Od0BBX+gU9ZQSbcFSkQuERttuwaUuh9hqLu4x2jSi
	V+jniTb055L2M+xmYlKV2TIo+VKVA8eadGZeVj1cjwX97vDGcRb+8i5vvDA9+pSN80Bxrz
	KDxTDAToMys02elKi15449u/6nip1p0=
X-MC-Unique: GrTsKIDqN9-y7vhlpdRm0w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XIozplYWqsEfD/ZPkksusTqqpOF6A/QVPaj5OM6CgIq9ZMsRgESIPCLR6QL5bZMTvgsZZOZmXVvjy4x69jSzqLqXSaa0GbGgvBrdwcIVLzDz0uRPR96XNErnTbm0v8FCZJzwDrm/EQnrAxqu/9wwnHA5JMYQnLMNNXG2K9vcz1r0DusiWYMrFUccsJHxR1uYudGF1zU9BMpEVNVMpinyyWIOC6EEufHbvczyzapLSxY3EZFazUJ4RsrjJDkMBlVLz40HyptzoZodT+UYytlC5FWqxyXgLtlfArZThddv0WUYCgmloGSILbyC2EtItQxd1s7hhH5nfwgP+BgnMheb+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ktr193pS08mX1sljE5M2Ea+ogUG4Xlq9xwDI7AlWsFI=;
 b=ayVp0oLd2XCSx1hR+c38uLTCrVljHY7cs1y7LDkDNdX9KvUia3lo+ItK3qUWIYdMZdTjYq7LZivc1qclz8Ii4IvzDATfOmdE80QNTk+gG0tv5CfAS/rlxnjJLd5DxgPXaVo3g9394Ak1igNxj14yIVGybXpOL30UifpibjP2yqrQl4bCIRnZn2D6/oJDwnDiDHBoNJX/5TOQ/kfBFIKl53ivEj6BPSe3zRS/jtx5Td3V+y7B+afT/XlGj9MSzXHN24ohPcWkCm9yvUS2/eWX5HbFvz5H0N02lCsOC8gw6JuQ4zNdT51bdqcrGwjb7nQ0QpaSq7t8LldZ/eB5i2N4tA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
Date: Thu, 9 Dec 2021 11:26:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0026.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 520b4c84-80c1-46a1-32f0-08d9bafe6191
X-MS-TrafficTypeDiagnostic: VI1PR04MB4352:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4352AB8274A3718AD3BD2DF1B3709@VI1PR04MB4352.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	30cT9jpfQXt3pve5BQPTb4YOpYI+z77zmwk49PzTTolxsAnsJddz4Jk3yiw70W1AXtt6LOpoeGq5wn1CKZU2Jh7YU8Usew8W8K/83qCFP3crWhceZgiJmYpXY6mdIWjFci9lRfCdjuB2fJVQK7fB1WT1VBvawb5xKrfBcXLMlMGQKo+JE+tZ8tkLwe/ogr+GnxXzLxDR7d95weAMFbgRs48NugrluY0ri88hVE54Uw0dqmdEueFDfai3yIrBsVdsYBEGVLE407gPbmAv6SzE0wJYC2W90/+ZFJlXnRHc8lLtxZ7Pt1aUOwQ75s1RyO2jObsdKbt4dZrpsXRh7X31VndYA6z0qWksxCjU3kOAU+y7M+Nv6F/LAZxBLUSl4a35ZmSMdM/2rYOMcyyTOp/L8EB+xr+Y5AexoIYvputgFUbwAWTycWZufwbzvndHgI8CyIMdFNqsHxoOI/OInGybLsIacfIVCkoXt8Q+VeDGxE97StbIUGRPRZljEDhT6RWMa6dm3fR2XTspHSWLritSdH8w1YXIYI7NJetFkfiHuajTb/D5nSQPmlfyLWQTDM125OXU7C1GTRcKYdSrXZpwm5dbqMLs7tMzgn2Qz82VZvak/yyLjm3PYpTy6dTByY9Rte3FKkKO3JDyas7yPdX1WDNDLa6mZSOQz0XlNeY9083/BgG0D+3Q43RDaoK+x9clbvcq2jZvjxjIAtbT+b0fgeB5oUBosIQmm87Ffml+7YUU3Zs23BIxuHJ8t/1l124S
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(26005)(107886003)(54906003)(4326008)(186003)(66556008)(38100700002)(508600001)(6916009)(4744005)(86362001)(956004)(5660300002)(16576012)(2616005)(316002)(31686004)(8936002)(8676002)(6486002)(2906002)(66476007)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OGFaa042U3lHWVJOeFRnRTlkeW9uNzlqbXVGV2JsUXluQk9sUEZWeSttQkRo?=
 =?utf-8?B?NG1UUUFPUi94a0lleGJjWXVMUFc5SGRkaVZNYmlGVXpDRG9ZODhnck8xdTAw?=
 =?utf-8?B?d3NVZnFyNExyc0hPenRQT0h0clFBb2xLVzFuMUxqZUNMNGJ6VEk4eHZHVm0r?=
 =?utf-8?B?SFFrbTFCcUQzeVVFTjFBRnFsSmJKZkplS252RU9vVG9UWW1seWxmYlhlbzVz?=
 =?utf-8?B?a204L2ZhdEhOMlNoWmpDWXFHa2RpQXAwK3Zoa2t6ZHRGRG42NG9raWtOcG45?=
 =?utf-8?B?dTNDbkZ2cVNVOFN6WjFrMjZ0eTFiVE5lVXhOTXFUQVlpVFptT08vVE9SeENy?=
 =?utf-8?B?RmRSeEhqcElKaDVuYnlVRlpoZ0FsSk5Wb2cwZ29NcUd6QWNQc29UUHl4SjBj?=
 =?utf-8?B?dG5HaGdxbWJBamJHTFZjNUdMaWZZS0ZweUJLRVYrQzg4NmpUWE5sS3E2U1c3?=
 =?utf-8?B?aHlQL043eXVzdWhCY2FRMHFhZnhKMUk0MTlnUStUL0x4NlBrMFlaaWRFWGVG?=
 =?utf-8?B?MnJSOWdySUdGamxkWkVQOHd3RjF3Tk1CaU9pQlB3T0R5dzdKWXcwQ0NQRXg2?=
 =?utf-8?B?Tmpmb2dRWE9qd0RsMlJuOVlDcW84a2RZQWk2MllmaWV3V2dHV0RpNHJZT2tz?=
 =?utf-8?B?dmluakhMVFZVU0VZY0VIRTltU084NHdqN0NvdGs2NEk2bTQ4T2NEU3VKajFZ?=
 =?utf-8?B?ZHRYV0I5YUdpZUw4V2xsdm5rWjFTNmdJcXZqMlNoKzVQYUhEYmlzallBcjNh?=
 =?utf-8?B?WXErbjVDaFdVWk1TTVBhV1pQcEJzRDJTSzg1MENXOGZiNjh3ODJPYUFVUHVZ?=
 =?utf-8?B?bXNzL21JdmZmY0paQjFQUGRwWkpKVnBXeFp6MFNWU2VMck53R3JSL21OdXJn?=
 =?utf-8?B?VkNSejRDamk4cWo4N0RoQk9SWkY1M3dLcG9oaWUzcmwrR3c3SHh4dUJueWx2?=
 =?utf-8?B?aEpOV3J5R0ExMkt6OTJWSFE5VDNHZzQ5M0dvU2drTWVqWjlDVmFXcW5FT3hJ?=
 =?utf-8?B?U2hIa1RTaXp3WEJLOXB2b3pYRTcwK1FxUUhBbzRQRElyK0E5ZTBoUjhRa2ZO?=
 =?utf-8?B?WEthakdIUm5CUTRJZnlSZHJsWEFqekE0MjJvcXhSTDFGeUVhcStjU1lpbXZR?=
 =?utf-8?B?aGVYMTJYS2FQTXY4NTRnZGdKZmdDdDR5TmM2WEpwb0tBY3JWeWF1VXdCNVFp?=
 =?utf-8?B?aExFVWlxNnkyTzlmUG9lY3YrM0FYTHYvR0xYRHM1SEk1L1BEQUdJemlVb1Uy?=
 =?utf-8?B?aGhtcm9XK0p0aDBxK1E4eFVMWXh1cjdZQnNCQ0RqSktSeTQwTjJabFhZSHkz?=
 =?utf-8?B?emZmSkxpUFF3UHVyOWlmbmRwblVVR2dYaXVsRVEvem9WZkxURFZxSFNnUk1C?=
 =?utf-8?B?ODRRd284RjFDaUtPNEtzSFZzMW4rUTNqL21wMW1XdVBoZXRhdFhjdmVuaUtF?=
 =?utf-8?B?LzhMMTRhaS8xREpjNTB3NGdqMFNKdVlmd3hmamp2WGpvUDAxdVN0SE9FZUdm?=
 =?utf-8?B?MERSQlptVHplU0QxaUtLdXFvNVlnSklTQ2M5ZDZjZGpCVXdvOFdXS2I5SkJV?=
 =?utf-8?B?VXYzb2dIMXVIK3hBbVJoSzN1S3FwQ2dyOEhic3Y5S2dTQlpSRjZaR0Z5QVdp?=
 =?utf-8?B?TUFtT1hrMURRbGFoU3BQNnZjUlJpN3FvR1AvWE95QWdydkZoYk42TXFsYXVW?=
 =?utf-8?B?VEdpeW9URno3OUhsRE9IL0FZb1JOQjJvVUptWlFNcnkxRzQ3L2VSNlMrajUw?=
 =?utf-8?B?VG9KWmplM3MxOHN5MklBMVpCbW9Wd0RucjBENmsya0EzSnFxQlJTK3ovclhE?=
 =?utf-8?B?ZnpJUHhNelNaUXpvT1pJWHVURkV4azAyKzliMk0rVlNYNVlkTS9kT0JWS2hn?=
 =?utf-8?B?eUJHbzJhTlZYSWtTdTZtaFQ0R21oWjBPNWdydlF6Y3BoV3MxbFR5M2Ewakhn?=
 =?utf-8?B?dkxoM3RqUVVRSVpvYnJVUmU5cmpBRW1TL2ZUbjIwYkF5VTZKeFUvZjRva001?=
 =?utf-8?B?dSthRGpKZGdiYkJPdVd6YnVhWEl0ay81dE9mRjBFMTJvQjhwRisyUWxBS2hT?=
 =?utf-8?B?dEtVZU1NOGgvUzVmME11aTRhN2VVb2FiTXhGZlIzMEpKcldaNUlnLzBKcDVh?=
 =?utf-8?B?MEFEZGJiamZna3hGbnB1T3VpcEJhRk53MmM2RFd1azZIcDFOOWVkK0FwbnRp?=
 =?utf-8?Q?293rNy04ZwcW/9x7+SF/wek=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 520b4c84-80c1-46a1-32f0-08d9bafe6191
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 10:26:37.3329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +QM72ZTxNJK0LEsS09ZDb8sB2jXVbCIGL0ainxU0fiZqedqAxoBUsCXu9G1P8S8BEPxMtfy90fGcDLvIiDi3DQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4352

do_memory_op() supplies return value and has errno set the usual way.
Don't overwrite errno with 1 (aka EPERM on at least Linux).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
An alternative would be to let go of the DPRINTK() and leave errno and
err alone altogether. While the hypervisor side of the hypercall gives
the impression of being able to return positive values as of
637a283f17eb ("PoD: Allow pod_set_cache_target hypercall to be
preempted"), due to the use of "rc >= 0" there, afaict that's not
actually the case. IOW "err" can really only be 0 or -1 here.

--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1231,10 +1231,11 @@ static int xc_domain_pod_target(xc_inter
 
     if ( err < 0 )
     {
+        err = errno;
         DPRINTF("Failed %s_pod_target dom %d\n",
                 (op==XENMEM_set_pod_target)?"set":"get",
                 domid);
-        errno = -err;
+        errno = err;
         err = -1;
     }
     else



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:28:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:28:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242904.420067 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGeg-0004u5-1Y; Thu, 09 Dec 2021 10:28:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242904.420067; Thu, 09 Dec 2021 10:28:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGef-0004ty-SA; Thu, 09 Dec 2021 10:28:01 +0000
Received: by outflank-mailman (input) for mailman id 242904;
 Thu, 09 Dec 2021 10:28:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvGee-0004to-Ui; Thu, 09 Dec 2021 10:28:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvGee-0007A4-PO; Thu, 09 Dec 2021 10:28:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvGee-00088Q-Hb; Thu, 09 Dec 2021 10:28:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvGee-0002WS-H9; Thu, 09 Dec 2021 10:28:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kre5ejus4kmcvAsSSNSxqgvlENgFng+KieVP8QNYJEA=; b=ZvrXY9qlyJSol1VBW1JQxsegXt
	pnOcH5aj6FYD+oZy+GGciPjVDcSjxwH+B18MuZOCUX96ZWYH4VzSQuCepf+50aaoIvJsxB0kOjnHQ
	T9RqFuwR8+sOGlcVTa6Se6CWm9tDgs8eJrKuC9cm3YguHDGvbSp52InepizP//uGelMI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167242-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167242: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 10:28:00 +0000

flight 167242 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167242/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:36:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:36:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242914.420081 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGmX-0006Pb-Ue; Thu, 09 Dec 2021 10:36:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242914.420081; Thu, 09 Dec 2021 10:36:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGmX-0006PU-RV; Thu, 09 Dec 2021 10:36:09 +0000
Received: by outflank-mailman (input) for mailman id 242914;
 Thu, 09 Dec 2021 10:36:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvGmW-0006P8-8V
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:36:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d114c7fe-58db-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 11:36:07 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CA7F41F37E;
 Thu,  9 Dec 2021 10:36:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A438D13B2D;
 Thu,  9 Dec 2021 10:36:06 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id Yyk9JhbcsWFSLwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 10:36:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d114c7fe-58db-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639046166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=a8ig0Ni5obyglCNV2zX81b42VmzXEX0eNIz0MgsoN9A=;
	b=kF6b0mR/mTT93upQhiYil4D5n3AUdHgsbwmgJbX1IDwvz7QIGuIwROQMbcKkpHNw0wlozI
	ZlLD9spUV/cIIR9oA51DZxGiEvgrBcRjIh1NyJqa6NtLPOnjnSh929AyaaB8LS+fv4JDRl
	Llpc/wl8KK/j3l2YL/jzWRNkAWk0Ncc=
Subject: Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
References: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
Date: Thu, 9 Dec 2021 11:36:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1eK3E2tQdgk6Q5Kt5PIiwdayvtU7kwPMD"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1eK3E2tQdgk6Q5Kt5PIiwdayvtU7kwPMD
Content-Type: multipart/mixed; boundary="B9ThKP1Ttrr2hZZG3fgzxySPOaIjQ4OKc";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Message-ID: <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
Subject: Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
References: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
In-Reply-To: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>

--B9ThKP1Ttrr2hZZG3fgzxySPOaIjQ4OKc
Content-Type: multipart/mixed;
 boundary="------------579052A1E89E68BD65E7E24B"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------579052A1E89E68BD65E7E24B
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 11:26, Jan Beulich wrote:
> do_memory_op() supplies return value and has errno set the usual way.
> Don't overwrite errno with 1 (aka EPERM on at least Linux).
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> An alternative would be to let go of the DPRINTK() and leave errno and
> err alone altogether. While the hypervisor side of the hypercall gives
> the impression of being able to return positive values as of
> 637a283f17eb ("PoD: Allow pod_set_cache_target hypercall to be
> preempted"), due to the use of "rc >=3D 0" there, afaict that's not
> actually the case. IOW "err" can really only be 0 or -1 here.
>=20
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -1231,10 +1231,11 @@ static int xc_domain_pod_target(xc_inter
>  =20
>       if ( err < 0 )
>       {
> +        err =3D errno;
>           DPRINTF("Failed %s_pod_target dom %d\n",
>                   (op=3D=3DXENMEM_set_pod_target)?"set":"get",
>                   domid);
> -        errno =3D -err;
> +        errno =3D err;

DPRINTF() won't change errno, so I think you should just drop the line
overwriting errno.


Juergen

--------------579052A1E89E68BD65E7E24B
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------579052A1E89E68BD65E7E24B--

--B9ThKP1Ttrr2hZZG3fgzxySPOaIjQ4OKc--

--1eK3E2tQdgk6Q5Kt5PIiwdayvtU7kwPMD
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGx3BYFAwAAAAAACgkQsN6d1ii/Ey/W
pgf9FIZihgVm/nfXS0pvOiHNwU0SkYi01A5sJ6lTzncjh+rXyFsY8nd8imAUDtgDHiGj2C8D+gJo
xZf4rftbzRHnMAY6qEI3UodOtzTiF+U9MrnktWyPzkU8MyS83V8dGAmBBq8mQIizq2YTNP0/kHT7
45rMwSSibke9olaak6tGo86lZgw9sRFYyc9SCgvk9u8W/F3RUnYGVmPAYQ5XLXPm8zIhMg9nGt+Q
QIX7bIFhqfvB/WcQNlAQXkfr0h3P7CxDjNJG4ogggFUzDrHpCc4FzXejyktP+uhkXdBkCKlIASGa
wVySMf8QRd4160EEGs9sjYHRy8xHqivj9BmD3AdYlw==
=4wRi
-----END PGP SIGNATURE-----

--1eK3E2tQdgk6Q5Kt5PIiwdayvtU7kwPMD--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:41:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:41:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242923.420098 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGrn-0008J9-Lv; Thu, 09 Dec 2021 10:41:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242923.420098; Thu, 09 Dec 2021 10:41:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGrn-0008J2-Gl; Thu, 09 Dec 2021 10:41:35 +0000
Received: by outflank-mailman (input) for mailman id 242923;
 Thu, 09 Dec 2021 10:41:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvGrm-0008Iv-9w
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:41:34 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9376d987-58dc-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 11:41:33 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EF2AE1F37D;
 Thu,  9 Dec 2021 10:41:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C971C13B2D;
 Thu,  9 Dec 2021 10:41:32 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gCT9LlzdsWGVMQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 10:41:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9376d987-58dc-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639046492; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=x8J8pxNxNS3q2xeYoZQ/d6RlkkS5ENguXg6/ooUFECw=;
	b=hYHEwxwRd4VtAdRqf9WzYWhe2F5nANxomQuhjRFTo2IDfrXliHlbDmuIaKDN0kEUejljVa
	m7KkhBrRk1w9R6Hky/wQVPOyCPTupj13Z7AYYcIqTfNNw4dd0jRq3PFKvJqki+2mMjB51L
	nUeE9oqTixXe0QNRwPsTYgJIN6SkhZw=
Subject: Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
References: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
 <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
Message-ID: <d0c46d33-f51d-e9bc-0f4f-8f7d297fd8fc@suse.com>
Date: Thu, 9 Dec 2021 11:41:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="ILKAE6IAlXuDEScMalNLy23iWFhX4Oe5T"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ILKAE6IAlXuDEScMalNLy23iWFhX4Oe5T
Content-Type: multipart/mixed; boundary="Z9XHsk2EFBEpFywuqUjHskKE63n8mOg99";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Message-ID: <d0c46d33-f51d-e9bc-0f4f-8f7d297fd8fc@suse.com>
Subject: Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
References: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
 <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
In-Reply-To: <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>

--Z9XHsk2EFBEpFywuqUjHskKE63n8mOg99
Content-Type: multipart/mixed;
 boundary="------------6045785A24A750DDF2C502E7"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6045785A24A750DDF2C502E7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 11:36, Juergen Gross wrote:
> On 09.12.21 11:26, Jan Beulich wrote:
>> do_memory_op() supplies return value and has errno set the usual way.
>> Don't overwrite errno with 1 (aka EPERM on at least Linux).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> An alternative would be to let go of the DPRINTK() and leave errno and=

>> err alone altogether. While the hypervisor side of the hypercall gives=

>> the impression of being able to return positive values as of
>> 637a283f17eb ("PoD: Allow pod_set_cache_target hypercall to be
>> preempted"), due to the use of "rc >=3D 0" there, afaict that's not
>> actually the case. IOW "err" can really only be 0 or -1 here.
>>
>> --- a/tools/libs/ctrl/xc_domain.c
>> +++ b/tools/libs/ctrl/xc_domain.c
>> @@ -1231,10 +1231,11 @@ static int xc_domain_pod_target(xc_inter
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( err < 0 )
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 err =3D errno;
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DPRINTF("Failed=
 %s_pod_target dom %d\n",
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (op=3D=3DXENMEM_set_pod_target)?"set":"get=
",
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 domid);
>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 errno =3D -err;
>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 errno =3D err;
>=20
> DPRINTF() won't change errno, so I think you should just drop the line
> overwriting errno.

In fact you added the 3rd layer of errno saving here. :-)

DPRINTF() and friends will save errno, and the underlying
xc_report*() functions will do so, too.

Writing a patch to remove the saving at the macro layer...


Juergen

--------------6045785A24A750DDF2C502E7
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6045785A24A750DDF2C502E7--

--Z9XHsk2EFBEpFywuqUjHskKE63n8mOg99--

--ILKAE6IAlXuDEScMalNLy23iWFhX4Oe5T
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGx3VwFAwAAAAAACgkQsN6d1ii/Ey/G
PQf/Qdo6DqKJx+GJ1xiA9vo6ktDJIkBqvNuxxKDBFuDcCSwuQMv/xCkQ7fX34N9k40EJsK1FBH40
XRAz1USaPC+pCxdKiDNDlTiEsv3uVoqfrfDIzqMCx63PLY3NAd5QPKq/GL+zSpVjTHgAeLOlI5Y0
G0d29F957khm7cwZRGa+ZKkFhsRJ9KQG+QQ2xDLdrbYsNzXD7srgQG/RovqjCJCCt2b/awsdDqJn
NT30ANZDXlNEXuimWaBWHp6UpoxICOE30yj0S1MsNRDrElR1QjY51KykNHpz+/LgCi3UhkAZCB/n
57shIZZTm2B6iW4INxmJkU2mcPryc2IZCVLXe8x98A==
=Z/Am
-----END PGP SIGNATURE-----

--ILKAE6IAlXuDEScMalNLy23iWFhX4Oe5T--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 10:47:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 10:47:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242928.420109 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGxM-00012G-9l; Thu, 09 Dec 2021 10:47:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242928.420109; Thu, 09 Dec 2021 10:47:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvGxM-000129-54; Thu, 09 Dec 2021 10:47:20 +0000
Received: by outflank-mailman (input) for mailman id 242928;
 Thu, 09 Dec 2021 10:47:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nMhz=Q2=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mvGxK-00011y-Ta
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 10:47:18 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5f3c4f8f-58dd-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 11:47:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5f3c4f8f-58dd-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639046836;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=NrQInU9jEGMCs/qImw0f7a7AV8AMHpnZdm00kaXJXPI=;
  b=hQg0t8z3W1utzUEFGAZ2PQWqvMeg7whfaDBpMGr5yWaPcFfO3Jaw7QyH
   dwjhrHKs6CqbZ9Hn95L4HlttbmI8KkML6MdMD0KGvY4sk6nZBCIfNuF2Z
   Rtk25qV1sUjUCJ5S6pqX9gD9+gfx/2zLHvquS5sa9BrNQIIUHgZKXWmgY
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: YR3u7vTC5ReZLCjDENB2cJVfzQF/8cttL9lQpXRDs6gvu0TAgbPgIVtSmwaGWJX1Tg+yOcGnsg
 cJcajUKB+lBkAN2ms3jVQIwN1KVUfEKG2E98vR+V/+Lk7sgv9r/WIJtMd5VANhDSAkGBY3gq6C
 7UMhJXKFewEhQbNi1WRMTvLj92kdJnCPMDVm0Z88xDAPFblEZUCpOnkv4fIKbF1tZgImlswoOf
 ryNNsM5s3xRWYjnaPnPR/Bao4wMfUM+v9/zEWLWsUpmoyC1JPt681ECLljk1HVS82oljBUledx
 vj/OJH15lpmup79jrP8Qcby8
X-SBRS: 5.1
X-MesageID: 59623335
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:m8SQ7qoAjQxXRTP00Bxjx0ZvYaZeBmLqYhIvgKrLsJaIsI4StFCzt
 garIBmCbq2JNDP0f990Pt/l8RlQucOHzNRkSFZuritgFilE+JuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24DoW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnby3CjcFPaGdpM8ccCJpEA0mBYtG9IaSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ptHM2E0N0mojxtnJGkRU6MYzfWTv2T7UQ9njW2L9KcF7D2GpOB2+Oe0a4eEEjCQfu1OhVqRr
 G/C+2X/AzkZOcaZxD7D9Wij7sfQmQvrVYRUE6e3ntZrn1+71mEVEAcRV1awvb++kEHWc9BVJ
 lEQ+yEuhbMv70HtRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM0rQT0n0
 HeZktWvAiZg2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fHDp8IDohHDH+pIEY2Ov97ZQQnWw
 zyz+X1Wa6ooseYH0KCy/Fbiij2qp4TUQgNd2jg7Tl5J/SsiOtf7OtXABUzzqK8Zcd3HFgXpU
 G0sxpDGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGptcEdMKS
 BWK0e+02HO0FCH1BZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzyxh9wfBlZ
 83DLZ3E4ZMm5UNPlmXeegvg+eVzmnBWKZ37G/gXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2
 403Cid+8D0GCLeWSnCOqeY7dAlWRVBmVcGeg5EGLYarf1s5cFzN/teMmNvNjaQ+xP8L/goJl
 1ngMnJlJK3X2SeadF7UMy87M9sCn/9X9BoGAMDlBn7ws1BLXGplxPx3m0IfceZ1+ep94+RzS
 vVZKcyMDu4WEmbM+igHbIm7p4tnLUz5iQWLNiujQT4+Y58/GFCZpo66JlPipHsUEy66lcoiu
 Ln8hAnVdoUOGlZ5B8HMZfPxk17o5SoBmPh/VlfjK8VIfBm+65BjLiH816dlI8wFJRjZ6CGd0
 gKaXUURqeXX+tdn+9jVn6GU6YyuFrImTEZdGmDa65ewNDXboTX/kdMRDr7QcGmEBm3u+aika
 eFE9N3GMaUKzARQro5xM7d31qZitdHhkKBXk1Z/F3LRYlX1Vr45eiua3dNCv7Fmz6NCvVfkQ
 VqG/9RXNOnbOM7hF1JNdgMpYv7aiKMRkzjWq/80PF/79Gl8+7/eCRdeOByFiSp8KrppMdx6n
 bd96ZBOswHv2AA3NtumjzxP8zXeJ3MNZKwrq5UGDdK5kQEs0FxDPcTRByKeDEtjsDmQ3p3G+
 gOpuZc=
IronPort-HdrOrdr: A9a23:s0qJx6CRVo9We1vlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.88,192,1635220800"; 
   d="scan'208";a="59623335"
Date: Thu, 9 Dec 2021 10:47:10 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: Re: [PATCH] MAINTAINERS: widen Anthony's area
Message-ID: <YbHerh0yByozO6VM@perard>
References: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e47c7976-dae0-4d45-e0c0-f845e5522f1f@suse.com>

On Wed, Dec 08, 2021 at 08:07:55AM +0100, Jan Beulich wrote:
> As was briefly discussed on the December Community Call, I'd like to
> propose to widen Anthony's maintainership to all of tools/. This then
> means that the special LIBXENLIGHT entry can go away.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:11:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:11:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242937.420126 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHJl-0005A1-32; Thu, 09 Dec 2021 11:10:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242937.420126; Thu, 09 Dec 2021 11:10:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHJk-00059u-VZ; Thu, 09 Dec 2021 11:10:28 +0000
Received: by outflank-mailman (input) for mailman id 242937;
 Thu, 09 Dec 2021 11:10:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvHJj-00059o-Bo
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 11:10:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9c4196f7-58e0-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 12:10:26 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-5Qg9j8aOMkuc16TmDZQ7kg-2; Thu, 09 Dec 2021 12:10:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.25; Thu, 9 Dec
 2021 11:10:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 11:10:21 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0042.eurprd07.prod.outlook.com (2603:10a6:20b:459::29) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 11:10:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9c4196f7-58e0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639048225;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X54giRiEeVSqCcwJGMXkCKCFhoT0fPvEK8qMC8Ck5oQ=;
	b=ZHUisT5Sf9k+nx9MDMdv0QJrZx2DY/VemedKF5s0+T9+LqNDTww8I8x/TBScby7ZjMpEoi
	JDQvT5e/PT0zTZr5sdp5IlaibhoBiSxl9LevUvDO5TqKBWiBKaiSqaR+XvT+0q+JOd/+Pd
	z59HeqR6EnXsp2t11qsA7OJecQnIt2Y=
X-MC-Unique: 5Qg9j8aOMkuc16TmDZQ7kg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UhIy1yG3ePpAP2QHB+3ujL4NeDK5PblpVJ4vSBeZXxgpCKCO6El6HccgYGsJ1IDnGeQX1DkUciiZGf7hbVTP6rff9dhZizm0FP1nnuitxHyIrIW4SN0GVYEFNs5NxIg2JmZlpgnfsn0BIsvo1JpOiEzV8PRq5lZHtEEHGz1hvoT67/DYbsGNp9OGz2O8jykRvCZPZJ9K1OfxSh4IJ4MYvDWNdlqppgw7qRf/FGelG0Y5PT+NGKgTRDbB0dqvSW8upKa2VIz3m3uhjGiBXWL1/o162FP1eNj/eOdKpAXimr+ohcBFBowzven1IMaWaQ1QlaCu1uRO8Z6IRbl8Ry3y8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MuL3XblWkbbUMBp+0ZrcRlp+/YH9/eNJVINVaxU+nzk=;
 b=HRHg+e0Ord8w6As39Vv/zUe7MNIw6agB57Qg7hLLljfd/OARS8jMrZw1xjvCyLIeUx/NbQ6BeU8ubacO9b7Cqix18E54Ul0daMEOYA/Lsvbo43Q3CkLOD8u4pkrFA5JWnzI2FvU+Ht43X+c3Re341moNGddRrWsvkcrm9/GUiwsqEl1xxiekV79NJyJlbWmMN5Dys40AiA74LOFx9La6h/BG2Te7j+1k862oUFTfz1EAgRwbXEMqET8HrlPT76902NuFuqh5FQva4IZRLJ4N+02T6t0l9yJT41Ty+YJ77ghoFWS0BEkD6TK/YgTKUQSHmqv22+RCgAAc6UQQONFmig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <02043b26-ed72-df17-b446-180245b5c9d4@suse.com>
Date: Thu, 9 Dec 2021 12:10:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] libxc: avoid clobbering errno in xc_domain_pod_target()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
CC: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <912e2574-2adf-25cf-498f-86a86f31c30d@suse.com>
 <2d608da3-af66-e836-c720-aa0fa31375cd@suse.com>
 <d0c46d33-f51d-e9bc-0f4f-8f7d297fd8fc@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d0c46d33-f51d-e9bc-0f4f-8f7d297fd8fc@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0042.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 231830f2-51e1-45af-f387-08d9bb047d63
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB353376FC0A4EEE2FFC2A89A2B3709@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FBvG5lMEC21BSBjyTnzEnFUpyjpwGNXaqLyQ8B/xaDqSdrZrwxbGoA8iEtJToM8njQzgFnYivyhajMC2RDa0mKlDq+AJeV88Fy/r3PqC/pCM+/y0hgMGDPvQFApRH3i1w/bEXuDxUdVD4zxUz+BSnN0ktp0OoUdIAG2+de/rKjWV/ie1nff1XCKiYxkc+My6f0rztoS8xqRH63JrulAtSVuGY0nmLB6qvQBF6w5fAVAvYHCYHtiWaboOFzPUVqOYJTENeF+8gGS1hfJMNOmbAWtBsDbSYxIEb5r0oKi3bNYS+AV3xmQtpN0jTYIurgq4vC2GwBRRZBuDCozdOUXYtkRys/AhWf99SflIQT0XzzVZUnnMxNVhdhAe3ua7qllqxabyGEzWVCwt4uHnRnLLGFLwX3IBS2BXTTuHnaAuLTKC8CUJwmAxWsFr7mdMUzsdTHAJMoYo38b6p35OLg8ilV5uxMGOVyIbWYFWWI63CpoGJw9sPg8WCT0iBQkcf5Sz+qtOBsIEQ3roE7MfX0GvGEMCqJCZ206T6y1JbVBf5G5t7tp89WjEXNuUPeJkZQO2X/CUDgom7So9u+kznHt0/jVpkAmzXo8g89mlfNkBl+IVHnl7wS6KzHRqLfOdHo5k3b4lb+KcUq9gx7fbLGeXVfXXQGyRtMiaKPhQseLfz1NQnnUB1j/W8IyZ/FTesvvhAKfSoBJbZY9cANlOyOjUzAPsc5PGnKg99GcKzzcHIiY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(316002)(37006003)(54906003)(36756003)(53546011)(2906002)(31696002)(4326008)(6486002)(66946007)(66556008)(66476007)(508600001)(6862004)(6636002)(5660300002)(8936002)(38100700002)(186003)(956004)(2616005)(26005)(8676002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?cujjbRJOu6GVuLB/NDKhfGH1xtHWPgf3HaVdZGk/0JO5409uJSJdAM/V14IY?=
 =?us-ascii?Q?d70HE5lttTWWVoPoJa8/fkQbkgUzWPXC991YligjmPE72XzLfiZP/pszKyvu?=
 =?us-ascii?Q?7jI/3DnYxIJfF2SozYVMowo9BcxrRQqCmp7pb0PFuSFSQL4vwse3frmUIJNq?=
 =?us-ascii?Q?zwZzeyfg+RtoBebGgaTs7KoeDgDwl1VTniPDuz0sH0bofIn18h7NwsF0LjQa?=
 =?us-ascii?Q?UupX2KyvIQnZB5BiCtpBlGH/fT8pF+GNEosBuJqluDhOY4JMgsc6FGck8wU7?=
 =?us-ascii?Q?jmX7fYG3zsRGCstlDIVbYHFzgYFarssUILYeMsJbeMJsrLJbQsbqJ+kElgPN?=
 =?us-ascii?Q?Q2ID+J+bkhloPY2GeZqx4ALffE9C8KKQQyDeHtf81tyadVmIVp+RmVrH5LDJ?=
 =?us-ascii?Q?q+T+U4Va2jWGQqEyf5XRlxhQJ31jZ3D54mdj3CRvr+rKYI0TvuwhAr9SRkvB?=
 =?us-ascii?Q?d+Y7OdtNpq4UeABG6gqAF7nVZLyxDTTC7tvdMz14nk7rZdT1x4KlcdNbiYvG?=
 =?us-ascii?Q?Pqm5X6N4A47eUxWdLqeV8ATHx+ZldFtdzj/b7y7qqyl9y/Wbd3F8pob5BrMD?=
 =?us-ascii?Q?UDE95HPvXvrG2tBbByIFaXC9oQoO6yXSJrsZSWnitofboKzuUlgfK/w4y+V/?=
 =?us-ascii?Q?hvwISZ7rVKNM73xU48RZr8iEymI8rATHd8SER+eFVnqq+tM8FcDFTfdc3Jt5?=
 =?us-ascii?Q?wuGEBzI2Z3nW5FJCeR3iKBpYBmEJljzjEYUxPG4TFGJ3TzFwP9JX4U6Ovtdq?=
 =?us-ascii?Q?UMU+cRVZSnAiQbUHLHbNfqQmXMC+oy3Upx5O4cOcccyoSpf8q1FIYWRVw1lr?=
 =?us-ascii?Q?BxXpoG8LyRZrFJj0yasaa7dYwGvv7U+0ECKvaQ1PF4LsHr1A+LQb43sSV2gr?=
 =?us-ascii?Q?mrsh+YLX28rWLyarGFxRpcs1KHzb4flnpq1b7yZYxsKPwd5eI7TH37dMaoJa?=
 =?us-ascii?Q?uZNI/z6KrmSqb3Cgbc2ONNJHS4YsR3oINEPBVkitmkN4RQQW8E5nA+Jk9Sc+?=
 =?us-ascii?Q?KP2uOuvrNXtqk+tSzu95ZxBkB07yXJxxihLSLgsS54TTS991Y7aQC59E3qEN?=
 =?us-ascii?Q?765OrQdavYoW50/LYytYlOEj3Fo/phS6DzFmAbmQwdE4HhWFCfBkbUjaRAQs?=
 =?us-ascii?Q?Vm6ZDg5Cn+s96khaM5yHonAdHid+ks5Qs5/3D/XXKoibawfj+sKZiMkM2r2D?=
 =?us-ascii?Q?x93LAM+lz2aQ3Wvi1QL0Oo/RQkkvjIEsCHHxPXQ4sY1jlehgq4IL30mcYKTk?=
 =?us-ascii?Q?JwNWb9AnxZ7zvhhzalI3tNuKsNypoMjivu/+jSowNyiVXBrm42859Nvsad8/?=
 =?us-ascii?Q?oBxSGNekpyji2IZHN8bGcgAD2aCmG8nMIutbudjyjxzOEza++U10qrxwH0wo?=
 =?us-ascii?Q?tNQQP56OQXo/nmQuHigWpd6uaNxF/rTAT7sCFkYAnhdn26W3rIYPxxdx7Sas?=
 =?us-ascii?Q?AZGeFqJi/ncqlBa5flEyO8SGSf5z4vDA55mHLWrOl958Grl5PVLXnPjvr9+z?=
 =?us-ascii?Q?qBtCxeXGt1WWWh4yqD3FtB6Vq7NHM3JMLfIlyCmFS83W+jr+ijzxtsQdPUhE?=
 =?us-ascii?Q?uodK6Z0nFNvScmJGHhx4KfFrAau71cj1SAdylYrvg1YlR0DD8QLkDsVoF9Q0?=
 =?us-ascii?Q?genTLLALmGMFtIcusGsuNm0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 231830f2-51e1-45af-f387-08d9bb047d63
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 11:10:20.9400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E+ilyh24hlcl5id2yVyZR93jTbM+Q+atDw4Le7EXrbBxVbAopU3QHuwxr4sX3wVH5J2bRol/t8w0Z42YW1zAWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 09.12.2021 11:41, Juergen Gross wrote:
> On 09.12.21 11:36, Juergen Gross wrote:
>> On 09.12.21 11:26, Jan Beulich wrote:
>>> do_memory_op() supplies return value and has errno set the usual way.
>>> Don't overwrite errno with 1 (aka EPERM on at least Linux).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>> ---
>>> An alternative would be to let go of the DPRINTK() and leave errno and
>>> err alone altogether. While the hypervisor side of the hypercall gives
>>> the impression of being able to return positive values as of
>>> 637a283f17eb ("PoD: Allow pod_set_cache_target hypercall to be
>>> preempted"), due to the use of "rc >=3D 0" there, afaict that's not
>>> actually the case. IOW "err" can really only be 0 or -1 here.
>>>
>>> --- a/tools/libs/ctrl/xc_domain.c
>>> +++ b/tools/libs/ctrl/xc_domain.c
>>> @@ -1231,10 +1231,11 @@ static int xc_domain_pod_target(xc_inter
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( err < 0 )
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 err =3D errno;
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DPRINTF("Failed =
%s_pod_target dom %d\n",
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (op=3D=3DXENMEM_set_pod_target)?"set":"ge=
t",
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 domid);
>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 errno =3D -err;
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 errno =3D err;
>>
>> DPRINTF() won't change errno, so I think you should just drop the line
>> overwriting errno.
>=20
> In fact you added the 3rd layer of errno saving here. :-)
>=20
> DPRINTF() and friends will save errno, and the underlying
> xc_report*() functions will do so, too.

I guess I should have checked ... Question is then whether setting
"err" to 0 on the "else" path could/should then also be dropped (its
setting to -1 clearly can be, and I already have it that way for v2).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:16:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:16:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242945.420137 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHPl-0005sR-Se; Thu, 09 Dec 2021 11:16:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242945.420137; Thu, 09 Dec 2021 11:16:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHPl-0005sK-Ob; Thu, 09 Dec 2021 11:16:41 +0000
Received: by outflank-mailman (input) for mailman id 242945;
 Thu, 09 Dec 2021 11:16:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvHPk-0005sE-J6
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 11:16:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7a87567f-58e1-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 12:16:39 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-XPS5heOTPyeU_nJIivvqGg-1; Thu, 09 Dec 2021 12:16:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 9 Dec
 2021 11:16:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 11:16:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR05CA0013.eurprd05.prod.outlook.com (2603:10a6:20b:488::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.20 via Frontend Transport; Thu, 9 Dec 2021 11:16:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a87567f-58e1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639048598;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BcEOLFgAyG+3D5ohtnijoJ1iOU8F97z6QoWePlLNKRw=;
	b=LdAHqMpC46US4IObBuvReRmwsa0/BF1T/k42DStp8RlvVX04TW/YsVvOOCyjyOqplSUE5J
	K/n5CdDo7XWVMNFev2QNHo/6UbiwKDx4QAFEvIL6LJgoe7YGrhk2GGVMX8UYvWhDVq8Ljp
	VWj6Sm+kdCskCFpENkkJkZ27vJwGq0U=
X-MC-Unique: XPS5heOTPyeU_nJIivvqGg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gUelqgg1d5d/PePmqDmJM2nVMDlM3C6dTq+F+sQwss8Pgz+NY/+7vkYT0rjog4Uk7DnghKuh6tBSsCpaiPol4VgWRCngpSYrhv+E1UV+vgUkOvUH70X/V1PPIZctcraB+Nx+5cldgJ7UV3VrEeWn2rOeh6Gq+juyVF1uzPVeXpZzyBWG/pItByz+WJMyrtgOLQz+Aj6tgQm7GCUHyQ2liUfNnM/8J273lkbgbpMCsOW36Xa/qEEnfd2SNK22T7roKMpo6QKRwMledMIHa6VJ+q/tpaE073sCewGAdOGraHHxizvgAyujKIEW8cTcN0t2dsIpysubYQzSn6sJDtFPlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BcEOLFgAyG+3D5ohtnijoJ1iOU8F97z6QoWePlLNKRw=;
 b=dKXZOD1pUGQcCA8M4SZdjw1e4zkXEgB+r4Wb51qSTJkTt7Goh5q3n66FFqgY3VP5HBuageXqUCsNBw9eqaOMUUQ5Y0bXHLYU7ZnAc+Q1C3A0+xHHYSMmMYlLkMhCvo2wL7pp63ep1GzmbKdytXsuy13O3WAzv4o8GmUmDR/oQLE8G0v3tCCF5fZCJHV0sxAibjSYH4AGxczfUT1FHzwKfF+Mit3Ap/6I+tm3jL8quI5c1bLsHCQmm7LbFgy7lxY364YCRIZQALdjjfDxAfkwwjUV/sx/5F6KtscecJQoV7N2Bjmkqs8L0+7cg7pArLtgdn6dr5G3YFd2ybzSq+aZlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f7c405e3-9bba-2741-b921-b30fe4164608@suse.com>
Date: Thu, 9 Dec 2021 12:16:32 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] public: add RING_NR_UNCONSUMED_*() macros to ring.h
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
 Manuel Bouyer <bouyer@antioche.eu.org>,
 Simon Kuenzer <simon.kuenzer@neclab.eu>, Paul Durrant <paul@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209070942.14469-1-jgross@suse.com>
 <5ce9cdf6-228e-b4e3-f0bd-f64fb89c03dc@suse.com>
 <22ac60e7-7e6c-aa96-f51f-8cfe08b8f62d@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <22ac60e7-7e6c-aa96-f51f-8cfe08b8f62d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0013.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 30fd4e07-e2c0-401a-4cbd-08d9bb055cdb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5165C00EC440FB872AA9630BB3709@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	43FCE23v7XSUUoBl4E6NNuD2bTDIz8hfBA7CaWyRkwneq3zG6QTss7boEJVJLM2KV2VCzOeENC/DgNMmxfOQ+7vaHfbDFhHUFcm3PtC93R3lnxBtPOr+SwXELQXYJafIbyjDqW1WsQEAAh3NfdZ4OHPFK/XylfvLTssiGVsgejxVeUIw6WcbuUNMcX7Po4QT9Fp846dsdhE5qfQzgGzbs43IcMgDHtURKT0WLN5MFD6kIOrC4/cMm72N7+QR5+4maVfuywrAr0qgC8fPKO08T8iQ+aPQyEwQxmyhlLxV9kENnyBorKFMTfzuxQZXE4M/+OGQnlgUG7rpnjFivXcg3OyaC2VqKufkXyJnAGf00v0B3zAcMZELZeTrw9NV7bncnVBal4h1Afffx/IC9W0CLinBg3dRu8hrgL7EEHcodCqyjSxMA/jaCzisAIX7UIiyCCwYoSompHVrcQbGQSBZR5xlhqyMaYqtL0FGPf82UGMv79E1O0prNuv1CpLwhC//wOhlcacZnEObdzTW/6Ey1cFCsGvn0QbnsKKpDsO5gouvBIgoxIb9UAT6fV/TCXdYjQ+V10yhvRuavAHILmVy9qC8US8V7PZAdh+cnjoWyhmxZBhfIEjjvOhM0elTwxlN0qrawc6bVQoSEZe5j+zDH2D6vYM28x9AQB9ThC0x2bnLN6rUbvVmgXXbAFINXgiBqPhHjksnbKiiAPT8kBBqx5ZIJ/AmDgsdgHnzgGNCREJdi9vdeiR7v4/09qY0CN5M
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(6862004)(38100700002)(4326008)(66556008)(31696002)(83380400001)(26005)(66476007)(66946007)(53546011)(508600001)(956004)(8936002)(54906003)(2906002)(6636002)(37006003)(16576012)(316002)(36756003)(6486002)(31686004)(86362001)(6666004)(186003)(2616005)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L2NtUmJzaDluNWtuRHlJTm9iZVV2Y2taUmlxb1I0OGJId0JrOHZUdXAzT1Za?=
 =?utf-8?B?cWFBc2NSWFhmQXdFbnUwVmFhQ3ZGMTd4bGhFcWlSRWlPTmFaWGFWMUd5MFNu?=
 =?utf-8?B?RndUQU5pSTZiODZ6QzJyME1KUUc1MlgvdU5RWUJFTjBxS1JTdlBrNklmbTZh?=
 =?utf-8?B?ODRteFh1SGg1enNvM0dnWnI1aWUzeThheURSbHFvZGVTNjB2ditMMFJYVzkx?=
 =?utf-8?B?OGxhKzNGeDNCbDdkeGMzcE8wR2pJenorb1Mzd3hEcjR2Lzl4cnhpMVBtUFhm?=
 =?utf-8?B?RGczSU5jNE5FSlhyVUVkTnkxcVNucDBrcE5YQlZMYk5xbGEwS2hIM3lZUUFJ?=
 =?utf-8?B?aFNJT2Y2ZFRNdEpBdHhWZmpnSGM1K3Z4WldpRE0xOEhRYjd3R1hNZXdEZ25Y?=
 =?utf-8?B?U1ViUk5CbnhoSHVGcGFFaEFBdnZ2NG5FeURNbG9nUnZXQkY4dlpQL1N4OHRX?=
 =?utf-8?B?bDJSWnZ3aUp2Szd3Q1RUYUMxL0Y3R1lpaGZhdjEycUlNWmcwWmNJa3dVeW5w?=
 =?utf-8?B?OFBVa1Q0Sjk3NnE5VWNMMXR6ZGV6aDQ2anhQcjhYKzlkVnNZQmZSU0huY2NV?=
 =?utf-8?B?MStibjFDbjZPWUwwdmxzQlpxd0xNbnIxS3IrYVlJd0JqM2dQenltNEZOWUk3?=
 =?utf-8?B?RnlDVVczSldiN24weUlEZkttRURkbU81bFl4MFl5bStFSERwNE9FbnFTNHUv?=
 =?utf-8?B?TjJESEZsd2xxTHJ6ZXNyU0Q1TVYxb0FBZTdTNGVHWEs0d1BOUGo2Wk9mWkVw?=
 =?utf-8?B?ZXVTOWV0cUtyZ2N1VFh5UXlKdE9iNVVBRzNXVGl1N3RpTnp6YUU4NVFMNmo2?=
 =?utf-8?B?WU4zM1BHTnBSYnFSd1RETmFxTVBnZmlWc3FsWmZaZloxOVlEWFc4N0lXRlZE?=
 =?utf-8?B?L3lZU0xXMGMyWEQ5Y2ZNS0tpdHBoRXc1akxOWFZuV3EvMWxGMWNxbEl6U0V0?=
 =?utf-8?B?TWJMWDFMQzhnNFhWbGVXNjBhK3dobTFKQ0J3Qjg4bHpldWRTSXFVMGlCZlQ0?=
 =?utf-8?B?MGdnU2RuYThqV0VZYnVvNnZSNFJORzhQR24wdTVYZFJWaGRXWndqODF3bnZY?=
 =?utf-8?B?WTlkM3kvZ0ZvZ052YlFSNVNqZkdWZWhLVjhCYXdTcm1tQ3MzZ3FuSWxSTkRv?=
 =?utf-8?B?L0VEeTZSZWFUaHNEL1gwTW94RmZ3MldFTS9EZi9SOWt4M20rTWhPK3d5VHpy?=
 =?utf-8?B?Z21Rb1d3THdMNDdMQVZkbytqaDVMVTJBUXRmNFc4dGhEQU41M2plZkRTL0x6?=
 =?utf-8?B?WEhvN2RYZnI5VGhObFp6alZhYldGNGwwR0MvSHBSQllCZlY3dUlsUU1LWFpK?=
 =?utf-8?B?bVhVMWFEeXFYSW1QTWhkb21lYm9xcnJXMmQ2Mm11VHM2VnV0aVhTTlhTUmhO?=
 =?utf-8?B?WHRZdExCYms3V0tGcFl0OWZiWmh4YVIrVmhZbTRiajZibys3eEVBUW9QdUJh?=
 =?utf-8?B?YnM3MG9SWWxkWmdaeHdWWmJVTk52NVhnb2NqaktGZTI4RUdnSS9oSkFOT2FM?=
 =?utf-8?B?OHdyeVFEbzF3YkIwMlYxZVJIZlV6TDlvQnN6bmsxYmdFT3dNaW1rMGtQVFM0?=
 =?utf-8?B?SndSRWFBblJsMUhYSHVSNXFXRytGSFZNMXRJZFIvSVFFY1BleU9OaUdVaTVn?=
 =?utf-8?B?KzUrVTNjb3ZvVzIyYkVtLzU2K3Q3LzZISnhDUTlIQUhJbG14aUg1azJCMFNM?=
 =?utf-8?B?QWRHYWpjRzhEYVowN3J5T0tNdHFaMk1nMEl1aDkvMXhTQjd2LzFyTmE1Nmd4?=
 =?utf-8?B?ZWR1WHpuRjdvWnhSSDUyRUI3b3RPSnR5VUtxOFpuME52L1FzUVY4K3grOXFy?=
 =?utf-8?B?Y0JXbW9zdGRWVXpOOE9uaHBqRXFJbnZIZDZJaXV5Z0lBODJwNlBDaE1nUTgr?=
 =?utf-8?B?cHpUWnp6c2h2QWdNY1FqcW5sNDlPcHRLeDhVbUlxVjR2TE1KVjNoN0IxRnlY?=
 =?utf-8?B?cUFIcGx2Y0JhTnRQNlI5UkQyQ2Zla0daaXU2RXN2Z3oxOFErMk1qUkc2dkhG?=
 =?utf-8?B?Q0VnSWF2bzU4QmpRTW1PcTJKZVRIVW0wYkl2RnFnYXcvcFBvUmt6czlYMS9P?=
 =?utf-8?B?Nkxuek5tNUh1R2JKS3h6Z2xyMWZhRTdMQys1elp1Nm0vMnAxczNXMGhtR0VW?=
 =?utf-8?B?elkrelljN1JoL2gyV2lCNmxZTjFBM09sRnRLcUNycUFROFpqK2k3UGlpdEVD?=
 =?utf-8?Q?eKngpiktTvnONf3P4QSaU/M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30fd4e07-e2c0-401a-4cbd-08d9bb055cdb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 11:16:35.9400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EhxElYmubmN0UUobDoJ/MfHBJbK2Wnr/vez05zKmnncbcBc83k9qSGqFwecwXqC7uAF4fMqANIpTG/5LzNCTpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 09.12.2021 10:47, Juergen Gross wrote:
> On 09.12.21 09:48, Jan Beulich wrote:
>> On 09.12.2021 08:09, Juergen Gross wrote:
>>> Today RING_HAS_UNCONSUMED_*() macros are returning the number of
>>> unconsumed requests or responses instead of a boolean as the name of
>>> the macros would imply.
>>>
>>> As this "feature" is already being used, rename the macros to
>>> RING_NR_UNCONSUMED_*() and define the RING_HAS_UNCONSUMED_*() macros
>>> by using the new RING_NR_UNCONSUMED_*() macros. In order to avoid
>>> future misuse let RING_HAS_UNCONSUMED_*() optionally really return a
>>> boolean (can be activated by defining RING_HAS_UNCONSUMED_IS_BOOL).
>>>
>>> Note that the known misuses need to be switched to the new
>>> RING_NR_UNCONSUMED_*() macros when using this version of ring.h.
>>
>> Is this last statement stale with the introduction of
>> RING_HAS_UNCONSUMED_IS_BOOL?
> 
> It should rather be modified like:
> 
>    Note that the known misuses need to be switched to the new
>    RING_NR_UNCONSUMED_*() macros when using the RING_HAS_UNCONSUMED_*()
>    variants returning a boolean value.
> 
>>
>>> --- a/xen/include/public/io/ring.h
>>> +++ b/xen/include/public/io/ring.h
>>> @@ -208,11 +208,11 @@ typedef struct __name##_back_ring __name##_back_ring_t
>>>       (RING_FREE_REQUESTS(_r) == 0)
>>>   
>>>   /* Test if there are outstanding messages to be processed on a ring. */
>>> -#define RING_HAS_UNCONSUMED_RESPONSES(_r)                               \
>>> +#define RING_NR_UNCONSUMED_RESPONSES(_r)                                \
>>>       ((_r)->sring->rsp_prod - (_r)->rsp_cons)
>>>   
>>>   #ifdef __GNUC__
>>> -#define RING_HAS_UNCONSUMED_REQUESTS(_r) ({                             \
>>> +#define RING_NR_UNCONSUMED_REQUESTS(_r) ({                              \
>>>       unsigned int req = (_r)->sring->req_prod - (_r)->req_cons;          \
>>>       unsigned int rsp = RING_SIZE(_r) -                                  \
>>>           ((_r)->req_cons - (_r)->rsp_prod_pvt);                          \
>>
>> To answer the "whether" question this was likely good enough. I wonder
>> though whether the use of (_r)->sring->{rsp,req}_prod doesn't require
>> further sanitizing of the result as it's now intended to be used as a
>> count - afaict the returned values could easily be beyond the number of
>> ring elements when the other end is misbehaving. Or if not bounding
>> the values here, I would say the comment in context would need
>> updating / extending, to tell consumers that they may not blindly use
>> the returned values.
> 
> I'll modify the comment:
> 
> /*
>   * Test if there are outstanding messages to be processed on a ring.
>   * The answer is based on values writable by the other side, so further
>   * processing should fail gracefully in case the return value was wrong.
>   */

I'd recommend to avoid the word "fail" here. Maybe "... should deal
gracefully with the case ..."?

>> Also imo all new identifiers would better have a XEN_ prefix to avoid
>> further growing the risk of name space clashes. But I can see how this
>> would result in inconsistencies with existing names.
> 
> Yes, I do see the problem.
> 
> Would you support switching all the names to the XEN name space and
> adding a section like:
> 
> #ifndef XEN_RING_NAMESPACE
> /* Following for all macros etc. not in the XEN name space today */
> #define x XEN_x
> #endif

Well, as that's not very neat either, I wouldn't go as far as saying
"support", but I certainly wouldn't object, and I also wouldn't mind
ack-ing such a change.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:26:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:26:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242953.420154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHYj-0007q2-Rj; Thu, 09 Dec 2021 11:25:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242953.420154; Thu, 09 Dec 2021 11:25:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHYj-0007pv-Mz; Thu, 09 Dec 2021 11:25:57 +0000
Received: by outflank-mailman (input) for mailman id 242953;
 Thu, 09 Dec 2021 11:25:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvHYi-0007pp-Dm
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 11:25:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c61e8660-58e2-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 12:25:55 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-Tan-l4GfPiWGABtMAICyow-1; Thu, 09 Dec 2021 12:25:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6669.eurprd04.prod.outlook.com (2603:10a6:803:125::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 11:25:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 11:25:51 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::14) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 11:25:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c61e8660-58e2-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639049155;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=yYqPUZG9XNvIfPJi004ntLCeF1YAfpmQ0Kw9pTrzNNE=;
	b=RNdQ/YbSHieOFn60Twx/8a9ydkLJn51MuTtWqa0v3Hssy+K12CFHqwCnbItyyeOB4qXFfz
	pVclzP/3cM01wzVRMnB5PrHDxEd/XpPqhY27b+no3f/fnCTJUieycg74MBFouOaejEqVDa
	qNpW1QARY9kp/LypA/iz6RCHTmAsKGE=
X-MC-Unique: Tan-l4GfPiWGABtMAICyow-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZFoi8xXDDI8cavi840vwpA9G4/w7YxFH9BFxddpc4RDajIBjUZs9wpaGRrOfrtETv3Pcsx/JI96Q7BmqhaGrphqrs2ANMahoHOytRa5Ruk8yFSPNDdRKDeU0v67EAvjbhU8lsXT+JQ7VlzudjSMjJTG5CfYsNt3zvkV9Xo6QA5ZtHgy2FCUBcZPNxLIW+fll/NHk/AU42JBe0pyDok2jTi1gabYkwC08By5fIp3dn7EkBWpNN9sBAjl93/ncTrvF3RjA01I7ENAcXG3No0fT3TSnkdvMHY+d+efswCQsFuw/0CL68imCNQh/vQZKlNsFUsmGC1bthp04Eumew7DKEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yYqPUZG9XNvIfPJi004ntLCeF1YAfpmQ0Kw9pTrzNNE=;
 b=YLekDiEJd4Xk1EO8muZ6sfL0LpU0O/SrJjJNFfSvIHLNtE1OQGXyiS1i5O7aCcR1XSIINzPvXsx3s0UStou2dJScump5dbH5xH5LkckO7KlNYuQ3ZtrLYnVUC8AI92pOvbMljoS+bFGkIVYxrw7yCBMqIe/PC7JZaduE3dovv0F0Gvku5V4bgXHFPY3P5LowZTtP8DE6Og5jLx4HfN1iiAolcP2B702hUI5U1Q0A8/Q6u+ANowpCeplndigWbXV5ziFJRU94yoQyjha54uO88/iRkA1bdSl3b4V6QxLQshI/H0Vzc/NeOQ66CPTEuT7JFeLEajLsIXgc779Po3lhVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com>
Date: Thu, 9 Dec 2021 12:25:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/2] x86/P2M: allow 2M superpage use for shadowed guests
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f90f8883-93f9-4724-7fac-08d9bb06a7fd
X-MS-TrafficTypeDiagnostic: VE1PR04MB6669:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6669C6D2A820671FDF468032B3709@VE1PR04MB6669.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PZtl1AWiDZxJqjqfIMLe/qfZqDIwZWktj9+be9BQJlr0X/xIC5KUtxjZJTyY27nuXSoToull1rxTc8bUwrFH2FC173VDgQmrsxCzn/uCATU34S4/dMjrdVv/jq1/SXTxvO21YpYI7eaeWPNdYx/VCE+fjbESaIQ3xORfhQdcfdh1RMm+p8ft6OPY5W3gPU+Ex7R69J6siJCGd6I1s7YKf2JkfS9zk6kULDIyRrMd1ujmUMZUDChEeH/27kL9afGNymHqQ9f8zusMISAcQ40b1U7KnB0IeF7E5OE1Umb28QDTy6oe1P64yh2uAjcN1q533/ZCta9qyTdkzCGNg+S0Z8EdH0qgIwcNk9FpBCgiu8Mwl4N/IMume0LFJeQH2yIRyijdCRXaYyYgWPsU2N1k1Xo2P3F8o5U+g2rU+sRuDW8pk8F6tGdqpSJvxEVLtX+GM/Pacqo4Y24Ww2gg9hywLP6ROD5fOgKKJ0P0LVwxkowPH4qSi/GOdObov8Yhe8EJtK0ekyDNxAc0ifCSYCBvb2vhIJjrZMYZpyA6NdSTzecJgaZU3dbVT1gHRguV0sAUjElFQSS2SNY7jUykRiibB4ZO9kR2oXWN01IyUeAG8pDxk0/xHpL56JHl9kzwpoGl7MRdOGluh+f3bcLN8Wqr76XKoYdT1lhQx6z8OvMhfAHFKu1LTENBtX+Qe/+bWsaw/Bk8TEzfsUFMQy2aSrpNsY4TIRRkPNFNxJYVdG66rIpr3YxReWUFGriZ6GJd1wKn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(66556008)(8936002)(26005)(86362001)(956004)(6916009)(66476007)(4326008)(66946007)(6486002)(31696002)(5660300002)(38100700002)(186003)(36756003)(508600001)(2616005)(316002)(8676002)(31686004)(83380400001)(16576012)(558084003)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkFTanhIUU1WdUFSYVU1VEFVcHZhUnFKNE5QaUtpNUoxSkRoQmdUWGp0cFNW?=
 =?utf-8?B?dmhhQUI5ZTdIQlV2YlpaWmxQQkFzWWcrU1JUeGpKQ3NwQjJESUNwMlJoaWRr?=
 =?utf-8?B?RXgwWkdpZERHVlFXaHI0eVZ3am5ZVEJqWFozVTJ4UzY1Nkh6OHM2QnhnUjZz?=
 =?utf-8?B?c1pNWUFkTDg5TU5aZDFKd1FUZEFVR0dsZWFRNVpMamRhMk5DWXVHOTZpYjBZ?=
 =?utf-8?B?TFdwdGNFa01CYWZ5L0d5b21vVzZINmtFR0ZOTGZ3bnNuejJqL2RsdTJQS2dD?=
 =?utf-8?B?OExQZVBLOHhFYnJuUGkvWlJnd1Z3dm9KYkdrSlRjeFlNWjdLVHJyQ041Tkdz?=
 =?utf-8?B?NW5IQ1drb3RYclM1OVdIRFZPZ2FWc0N4NTdEU09McnJwWWEwQUNQS1hvcXRW?=
 =?utf-8?B?UFFCckdEZzVQdVZydURGcUJ6RGlLT2ZLc1lMNnV2aHFuU01iNUErK3ZUb01p?=
 =?utf-8?B?VU5JVTVEM2RCYm53QVZYL1FQMkhwaUliYS8vTE8ra3dnV3ZwNjRjM2VOMWw0?=
 =?utf-8?B?U29iYlNiRTJtYlV6dVFRb3l5UlRXQW1vYktKYXpjaUN4VnJUYnFjRkp6V2Ev?=
 =?utf-8?B?cTFZUENJY1dFNXhORStQSGRCZXlXTEFacTE3NXZNV1FUZlR4MWVGS3hyd3hn?=
 =?utf-8?B?dThya09TbHJsTlRwcDFQVEp3ay9STmJyOXU3aUFUSW9uZUVITG4yMVZwNGxS?=
 =?utf-8?B?ajIrejJ1L1AwQ3ltOFh1a2hLNjRkQ2YwU1ZVeno4NlpBeVhPTk56aTNsYi9P?=
 =?utf-8?B?RVkwUldDd2xJT01WTVZ4RDZrZTFQeFFrZWw3bVN0RnRTVE5LZXdxQ2liMUVM?=
 =?utf-8?B?MUcyYmpHdllOOGxBeW5aOTdXVWd0b0VXS3ZkdzVDUTVXVDhYUEkvVnRZcURR?=
 =?utf-8?B?a1lBbnVjdVNNVXV4dTVwVWsxRE1aeStCeU9ReTJObnNMNFIvZVV6OTE4Wmcy?=
 =?utf-8?B?bU9LdlVmd2FyNVA1eklLajBIOWVWc1FEVnZEN1V6WGRZTWZZK0N1SEM0R2Jz?=
 =?utf-8?B?MTJBcnpXRHVxeWJ2OHBnY3ZjSUJHREx1ZG5kRUtTb0hRN0xjV0ZlQUdUdWZO?=
 =?utf-8?B?UE9tZnVJc2ZhbWRESG5SNUxvYnhVM0QydFdOdW9WT2lIWndncU9TVGVRRW8y?=
 =?utf-8?B?WG9OM3ZERXdNSmk2ZzJ3ckdMZHBYcGVzT2NsVDU3V1J1S2FBbldlZTE4Q2U3?=
 =?utf-8?B?Y1BxT1RJN0R3ZTFTQ0t1OEpndDVDdnVac1p0c01IMlQ3NDVFRHB6V1ZiK2hz?=
 =?utf-8?B?WDJ2cjAycUtlMThNU0FOVWpjMUVlbk9kVHhrcTB6d3g5MDRvV25LWlROYTFP?=
 =?utf-8?B?RjRGVGJHNXlFL1ZkcU9HaW5lN01Zb05TV3AzdWxYbmNkREJNUUtRR1lOMmlv?=
 =?utf-8?B?SlhTTUoza2ZXNm9BcldoZlZiWlN4RFUwUytzb1YrTGpGNGs2SmxSbFRSM2x2?=
 =?utf-8?B?R1cyaFY3S3RBcjllU3V6cmxMOFJGMXd0R1JSK0xZWFRqTzZ3dDRSZ09Gbmw4?=
 =?utf-8?B?R002eFFMczQ4YXpxN1NIQkZBam1FSThacUdMTkhNalppY1BYU2ZCYi8rMjYz?=
 =?utf-8?B?QkgxNUlkR2M2U3pGSUhwVkw4YjRXbFFyV3dVeDNoOHRSOGZIMnJkV3N0VGVI?=
 =?utf-8?B?SVdmY3BBVll4Z3hOZnZ5K1ZoTVZRUkpBUlZkU1puUHlCN3Jqd1o1aEFRc0Nk?=
 =?utf-8?B?dkFJa08xUDVaL09vL0hzMFpHYkN2a2RuRitaVy90NElaR2hpeTJiSEFaNzRh?=
 =?utf-8?B?RkQ2d29NMi91Q09sRkJ1THpvd0ZabUlPZW1nN1cwR2lCTjdZOW9Qb3pSY3Q2?=
 =?utf-8?B?RWpxZG9Pd0U1bUg1NHFSSTV5MnZvb002SUhyUHJtcVFrVE1aOHdUSTgyNkR3?=
 =?utf-8?B?Mk5odklKRDdPL2RrTHhXMzg1Vi9GYS9xSmJaT1RtWlMxakM1a1R1UkdGWlZX?=
 =?utf-8?B?SThoSUFWUVhUMDBOT2tKT3M1UkZwb2JmdHVZL2hiOUFUZmxoaFNZbUIzL2ho?=
 =?utf-8?B?QkFabDYwazlJb0RDQ0hhVTNEazJ1MU5seS9TaFpkQVdTcVgvWlpPc3lURjJ5?=
 =?utf-8?B?NlVUQWlYWjFkd3BRSGFkSTJlMWIyRFMvbzVkaUJyRnVWMXVONVRKNWRFcExX?=
 =?utf-8?B?Z0R3OGFUY25OeWw0TW80ZjVIRkxSVkt4N2gxaDhjdTFBR2ZhZUU0TG1kVEJP?=
 =?utf-8?Q?ddCaUJ5pwoUVI+2x+Pq6apA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f90f8883-93f9-4724-7fac-08d9bb06a7fd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 11:25:51.3921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jb4UsBJOmYb7nkOfkIRw7gEVAVKJD90FfEWpippPW1Lk4h4VUh15Z/0p+WZHxSRJRzPdD4i9o/xc2NPpp/pxbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669

I did notice this anomaly in the context of IOMMU side work.

1: shadow: slightly consolidate sh_unshadow_for_p2m_change()
2: P2M: allow 2M superpage use for shadowed guests

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:27:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:27:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242957.420165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHZe-0008Nd-4U; Thu, 09 Dec 2021 11:26:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242957.420165; Thu, 09 Dec 2021 11:26:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHZe-0008NW-1P; Thu, 09 Dec 2021 11:26:54 +0000
Received: by outflank-mailman (input) for mailman id 242957;
 Thu, 09 Dec 2021 11:26:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvHZc-0008NH-Ch
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 11:26:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e74bb42a-58e2-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 12:26:51 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-xf1sdbNhP6-B94oFNdODZQ-1; Thu, 09 Dec 2021 12:26:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6669.eurprd04.prod.outlook.com (2603:10a6:803:125::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 11:26:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 11:26:48 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::11) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 11:26:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e74bb42a-58e2-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639049210;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=byEU016lID7eSKnqJIKIFTYD83U8No8UvINs5+8b2I4=;
	b=c5RsZaBuGRgHZcu6fMqAfSyFOFEn7k0NkgpH7XlG5+zEmIzdmT79dGfhAzJ0ceoiGjt3qE
	OlnLNdNAKFDr/E/8YWyoW+hCIXPhH3Ww6MC0o7/bAg5p9Ll60XGAQ0abTK/f34E30ejpwu
	IZ1OZSzoAk5fK/EjWUm2PnjJY2aET9w=
X-MC-Unique: xf1sdbNhP6-B94oFNdODZQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=n4GLicznotsbY2j8Cb6G1oVRKHnLZMcrSiRc9zEm7ge9ORZn0T89DxQoCsSRVlsroRH8dVwIWIre+7FHoWzdg8p/B7tTV+R7hqv0bFE8zc54bE636siBYeL9rpULCx5R/GDmwET6qhzv7PHxiw+1jmdeYpml1Wt2KcFABDFoeZ8pJ+wGvb2veQ5EEzV4YoEtx5+w0w/ZORrUw0fq9F0AKGbKE2Dm248jICjzj/KYdgSF1Ymm7P3Ns/9p5GwCMiFo88GH6CocxCQmmNoXIvKT3RUzfmZHUvYPGvZXKRylXF6YrRrhe4KRClqAsKCEovVwJps91vf2yCktwOR0blCN1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=byEU016lID7eSKnqJIKIFTYD83U8No8UvINs5+8b2I4=;
 b=nhiqVwYBVj2wDlt8OHLFgQdr0TJa15Qb8llhfZnIgXz69RxC7XKH19M3E1g9D2bVnEUbHWirQIqsE4fyXif0xF+/6gp3ZhvCXUJBdLiz9JxVUgf26AEbdz57zCdrBmlAnZDVxFYTs1Elra7p8O0llkMUuWolyyJMwd66eM/UsHVFujCFyD8xpHpOleGjrItToEAZLEupF/KBvdackd9kBPRmAC+n241AP+r/TySQfnnIdEG1N9sRjZFZm5omrLng8q/rilxBmhsg73SFhkIBZL9OZpqW9+j2qBwFnP9MnWajdI1jSYpBhPfzcFD2Mos8G4FOn8NAA0N3/oZyaIERZQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <521b39ce-2c2e-967e-ecc7-f66281aee562@suse.com>
Date: Thu, 9 Dec 2021 12:26:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/2] x86/shadow: slightly consolidate
 sh_unshadow_for_p2m_change()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>
References: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com>
In-Reply-To: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0062.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7bdc8952-7bff-4f76-efd8-08d9bb06c9c6
X-MS-TrafficTypeDiagnostic: VE1PR04MB6669:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6669EB48048117AFCD55DB55B3709@VE1PR04MB6669.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3513;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xVdHrffjrGgazC8hY/Wdlbj7pnONfo0zzD0Eow2U4NpM6EWkpIsuFgLRkvSiaE4yGKsolSP3vBIF/xllUvOPq68D2OWP6KWRm9mJLmsAN0W4yEY+bQfHkw8LZOyubnwWYMqbJc7NXOAd2GDOJYb46Lkw+cV6tMBcZAJc6FSnIs9LQo9258gAkvlXlnbZUhttvGdgt3QkiRRVADdMGpqySqpPwPvAFKfUNvVWg9raLcRQRuN1TSRgempU/69sA+8n21LtzfuZLJtGNYXeapWqFE/oKR1rm1Iu7TPG91yS7Ksil0WRg99mr1ea5/NqijZ3ubvUmT3rkxMCOR/HV4W4zHr5ZGDb+fLgjE1abUz5ZkvlIg9e5ltleida26ahyh3sE9rlimSrihtTtJX2tNn9MTyKeHTw0Bxuc/Hw4JC6JOE8xp/V0i4MhRxtXXL3mubS9alDjnUr/SdmVQgmWDVSzXrwunL8PlU3qzJ5HQxujaK26mkdDOZequGse4RyeUm9vYucYCxXSEetaYS2R+pxpiDKo8cBEfkwZyO09s/nfOIAnxoxaUJDEIs9YdwLJ3B3YZsay0jyRClNKkjFvAhba7VEmRQ3j0uCL2TTfr8gVADVgzwDLr7chpuAVJHeIFua6QsDHztCmHS4tVaJ/fmwYtxq92xD6E6hjnUGDB7oD5ccp3dQRIJDJuGm8KZdkzXaEfjFwiaL7ZJBFto9O2cdGS+jXRO4mFXslrplN/0hy6QVOX9vdjToBG6W9/kJAqTNoupdw1N0GFXELc4p3Byzvg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(66556008)(8936002)(26005)(86362001)(956004)(6916009)(66476007)(4326008)(66946007)(6486002)(31696002)(5660300002)(38100700002)(186003)(36756003)(508600001)(2616005)(316002)(8676002)(31686004)(83380400001)(16576012)(54906003)(70780200001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QTN0eTJQVGI1V3JsNFhqR25GMEtFWlFQNmt2N0VqTUhMdW5XZDA2ZGNvNEtL?=
 =?utf-8?B?TkhBK0E0VjlEY3VRRlBRd3pxZDFzNEh3UmFYU2xQd0QvSTlVckFSSXNOY0p2?=
 =?utf-8?B?WEVMSGcrT2F6K0M1eTdpZ2ZySFRsTmNHUFdhUWcrSlZjRUx6dFQ5aGRxdmNx?=
 =?utf-8?B?OUxjYmFKRGZUM2RTM2ZIUkVjeUpVb0pUTUlncFBGdHBoMXE4TDdNMDhxNGp5?=
 =?utf-8?B?OVdKcklJelJOUGU2STA3NStidEs3QXBvU2lmS2JSQnhielRhbEVLRkFVMmVi?=
 =?utf-8?B?SmZsWWE1azBvcS9JS0pTc3Z2aWhDdGlTcjN2RFd5alE0SEVxMGN3TlhGZU40?=
 =?utf-8?B?OGg3bzVkOVdMdktuQTRZazY0T3lvQ0ZrK1FUTTRmNFRjVFF1WEVYNGdEM29J?=
 =?utf-8?B?NTBCbjdoanB6VytjbUQrQ3hNWVRKaXZESlB2RTlQUENJY0tSRXdQUmxNK1dS?=
 =?utf-8?B?UWtVMThtU3ZGUklOd0hVUjAwRlBuMWVKby9vd1VYY214RlV0U1lpdjZwMWx4?=
 =?utf-8?B?KzZETUVpQkJUNEQ4bmF0L3FGaUVkdmFIVklXMXAwM25iTng4SDBSZmhYT3Y1?=
 =?utf-8?B?UzhVbFBjOWxWSndPN1l2YTFSVis3ZGJDZWxjb2xzdjVwVm5vSjUxeXhGQkhz?=
 =?utf-8?B?c2pBaU1LWENHaVlyUWNYcDdEcDB2a3ZCejNCUE9EYWI4bGJCTXpQVXdsMnEx?=
 =?utf-8?B?bTloL2E5NTNpOEptRWdLVklrd1lrenhRdTNQVEEwVGp4V3U1ajJqTCtqVTAv?=
 =?utf-8?B?czlXRlNEbWNuM1AvZnlCYTRtdmRLa3JQZWh6LzM3TDg5U3pDbXJWOU5NV09r?=
 =?utf-8?B?Z1pxNzdQbjhqOVpldm53bllJRG1SSW80ODc1eEFnWU1BNW9XdDZ3Z1U1TEYr?=
 =?utf-8?B?VE5raEVMMDV5eFVqOFZ3eHFzdHcrN3BXTktuVFp4NUZsSDRyUU0rbXcxMC9r?=
 =?utf-8?B?TzFEZUVGdlVFTXdudGdPVWFtSVBMTnNZbDhBRWcvanNDY1NCQUdoMmQ2OGE0?=
 =?utf-8?B?UFF2OEhReGhJNDRGNjl4THRxUUJ0SjBjUlBsSE9Mc0J1LzdQTHFvcFNqUUdo?=
 =?utf-8?B?ZzFlUVVEMDVLZ09LdVV2U25ycDcyNXkzS0NQR3lqMkJJRXRxZHdvZjRBYTRk?=
 =?utf-8?B?YkZUdGJSWGllcnFzSjZyL1BtdEwrWVRiNDZRUmhEaDQ3L3JnNUg3c0ZiR1Ar?=
 =?utf-8?B?MGF6QXZoVTM3RmFua2ZMcVRXZXNweTFseGNBTEVOaDhsbXdXTXhmM2s0MFBn?=
 =?utf-8?B?ZVk4QWJWM3VRZ3BCeVR6MG0zbEdmWHJqbDhhRStyTjlRUTIwSGNzaCtuZ0Nl?=
 =?utf-8?B?WWRzQ0FnVU13di9wTEowdDdmNkRSVmo5OCsrRTZkVXcrRmN5LzJJR3laRTZV?=
 =?utf-8?B?S3JIbzlSa0tMWldsN0N6NURrK0dDTWhxdmRnOU1zNFdGTTlVNm9qb3JHWktW?=
 =?utf-8?B?eGJrV25WUUFQWVh4bGV3ZmdpNWJ3R1l0LzdUUDFKd1dmWmMybEtYRHZtRTlF?=
 =?utf-8?B?ODBzcUhMK09JOHI5TXhiYmt3bjVCRUYwcEl0bGpDMlBuU2piQUU2L3BCcEVH?=
 =?utf-8?B?MDJWNkpVNGdScFdiNGJGdWttZzF0VTBsdlZYVDlKdlZNd21JZ3FhejU3WEZR?=
 =?utf-8?B?MVNnQUs5R2w4Z1ArTm56Tkd3ZjFnU2JWVGJvL0NTS0ZOSHBCc2ZIWUllWnMv?=
 =?utf-8?B?U1J1WERVd3NBVnNOK1JoV1dlMGxlNDFVcmZYZE1jc2ptS2dkR04ybFVlZEpD?=
 =?utf-8?B?RUE0VURKenRLbm1oa2d2eXErdUxzOWY1Q2U3UCtXVlU3UkZhSUVwWG1pMTV4?=
 =?utf-8?B?TzdlSURqZjR3RG5qZWtrNDBWK3p1cjJJTUF5RUtJMWxMY2Y1bHM4bGhYQnhG?=
 =?utf-8?B?eDdCbnI2NXE1eWNPMEV1ZXpieFc2aFRDamFqNnRGREo1N1FJWWpGZFZ2MHda?=
 =?utf-8?B?V2hOSTUrNnVLNjBPYzQ5SWFHVk5abnY3VG85V0ZjdXVxZ1p6UFc2d0s0azha?=
 =?utf-8?B?Q2w0L1h5b3dQQ1dPTkNXVXdhYTQ2d3d3Z05Rd1RkWllkS1llU3lBMWtvMUJI?=
 =?utf-8?B?OHYzRTUrSFc5YzhCTTU3UTBKcGIrNllLYlBLTXBMZmlZTnZ2dHZWckQ4dFhQ?=
 =?utf-8?B?cG1JdXprdWR2cnpCdFBRWXIrTUpqWHlQNEZyZkpFQVVnVmJWUi83R0ZHcWF2?=
 =?utf-8?Q?asxolmAQbRvr4Q5yfatQFmY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bdc8952-7bff-4f76-efd8-08d9bb06c9c6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 11:26:48.1430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EEtHiw2NlqTMGaVYM6uMvBlBAB5M8DSHDcWph0RCWBf2KP/VOLQ7DWtxgm7u8fXurZ07iORh7/Cn0IUe6yNnUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669

In preparation for reactivating the presently dead 2M page path of the
function,
- also deal with the case of replacing an L1 page table all in one go,
- pull common checks out of the switch(). This includes extending a
  _PAGE_PRESENT check to L1 as well, which presumably was deemed
  redundant with p2m_is_valid() || p2m_is_grant(), but I think we are
  better off being explicit in all cases,
- replace a p2m_is_ram() check in the 2M case by an explicit
  _PAGE_PRESENT one, to make more obvious that the subsequent
  l1e_get_mfn() actually retrieves something that is actually an MFN.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/shadow/hvm.c
+++ b/xen/arch/x86/mm/shadow/hvm.c
@@ -801,7 +801,7 @@ static void sh_unshadow_for_p2m_change(s
                                        l1_pgentry_t old, l1_pgentry_t new,
                                        unsigned int level)
 {
-    mfn_t omfn = l1e_get_mfn(old);
+    mfn_t omfn = l1e_get_mfn(old), nmfn;
     unsigned int oflags = l1e_get_flags(old);
     p2m_type_t p2mt = p2m_flags_to_type(oflags);
     bool flush = false;
@@ -813,19 +813,30 @@ static void sh_unshadow_for_p2m_change(s
     if ( unlikely(!d->arch.paging.shadow.total_pages) )
         return;
 
+    /* Only previously present / valid entries need processing. */
+    if ( !(oflags & _PAGE_PRESENT) ||
+         (!p2m_is_valid(p2mt) && !p2m_is_grant(p2mt)) ||
+         !mfn_valid(omfn) )
+        return;
+
+    nmfn = l1e_get_flags(new) & _PAGE_PRESENT ? l1e_get_mfn(new) : INVALID_MFN;
+
     switch ( level )
     {
     default:
         /*
          * The following assertion is to make sure we don't step on 1GB host
-         * page support of HVM guest.
+         * page support of HVM guest. Plus we rely on ->set_entry() to never
+         * get called with orders above PAGE_ORDER_2M, not even to install
+         * non-present entries (which in principle ought to be fine even
+         * without respective large page support).
          */
-        ASSERT(!((oflags & _PAGE_PRESENT) && (oflags & _PAGE_PSE)));
+        ASSERT_UNREACHABLE();
         break;
 
     /* If we're removing an MFN from the p2m, remove it from the shadows too */
     case 1:
-        if ( (p2m_is_valid(p2mt) || p2m_is_grant(p2mt)) && mfn_valid(omfn) )
+        if ( !mfn_eq(nmfn, omfn) )
         {
             sh_remove_all_shadows_and_parents(d, omfn);
             if ( sh_remove_all_mappings(d, omfn, _gfn(gfn)) )
@@ -839,14 +850,9 @@ static void sh_unshadow_for_p2m_change(s
      * scheme, that's OK, but otherwise they must be unshadowed.
      */
     case 2:
-        if ( !(oflags & _PAGE_PRESENT) || !(oflags & _PAGE_PSE) )
-            break;
-
-        if ( p2m_is_valid(p2mt) && mfn_valid(omfn) )
         {
             unsigned int i;
-            mfn_t nmfn = l1e_get_mfn(new);
-            l1_pgentry_t *npte = NULL;
+            l1_pgentry_t *npte = NULL, *opte = NULL;
 
             /* If we're replacing a superpage with a normal L1 page, map it */
             if ( (l1e_get_flags(new) & _PAGE_PRESENT) &&
@@ -854,24 +860,39 @@ static void sh_unshadow_for_p2m_change(s
                  mfn_valid(nmfn) )
                 npte = map_domain_page(nmfn);
 
+            /* If we're replacing a normal L1 page, map it as well. */
+            if ( !(oflags & _PAGE_PSE) )
+                opte = map_domain_page(omfn);
+
             gfn &= ~(L1_PAGETABLE_ENTRIES - 1);
 
             for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ )
             {
-                if ( !npte ||
-                     !p2m_is_ram(p2m_flags_to_type(l1e_get_flags(npte[i]))) ||
-                     !mfn_eq(l1e_get_mfn(npte[i]), omfn) )
+                if ( opte )
+                {
+                    if ( !(l1e_get_flags(opte[i]) & _PAGE_PRESENT) )
+                        continue;
+                    omfn = l1e_get_mfn(opte[i]);
+                }
+
+                if ( npte )
+                    nmfn = l1e_get_flags(npte[i]) & _PAGE_PRESENT
+                           ? l1e_get_mfn(npte[i]) : INVALID_MFN;
+
+                if ( !mfn_eq(nmfn, omfn) )
                 {
                     /* This GFN->MFN mapping has gone away */
                     sh_remove_all_shadows_and_parents(d, omfn);
                     if ( sh_remove_all_mappings(d, omfn, _gfn(gfn + i)) )
                         flush = true;
                 }
+
                 omfn = mfn_add(omfn, 1);
+                nmfn = mfn_add(nmfn, 1);
             }
 
-            if ( npte )
-                unmap_domain_page(npte);
+            unmap_domain_page(opte);
+            unmap_domain_page(npte);
         }
 
         break;



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:27:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:27:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242963.420176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHaO-000153-HK; Thu, 09 Dec 2021 11:27:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242963.420176; Thu, 09 Dec 2021 11:27:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHaO-00014v-E4; Thu, 09 Dec 2021 11:27:40 +0000
Received: by outflank-mailman (input) for mailman id 242963;
 Thu, 09 Dec 2021 11:27:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvHaN-0008NH-1v
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 11:27:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 03846458-58e3-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 12:27:38 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2059.outbound.protection.outlook.com [104.47.6.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-VYKA4X3vO5iA2lAuAVi66A-1; Thu, 09 Dec 2021 12:27:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3118.eurprd04.prod.outlook.com (2603:10a6:802:a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 11:27:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 11:27:35 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0110.eurprd04.prod.outlook.com (2603:10a6:20b:31e::25) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 11:27:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 03846458-58e3-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639049258;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NGYaCIoX8o17jAvi6lqGRSDxKlq7w0w9+/u0S+y8TUY=;
	b=LpmBRYfHE9dlNFkoKCcGzWb/N+7S6PyZBzi4bkAs0oya5psLRT3tHiVjIEBGQcyHFvjYHz
	/rGuQ1XAHDrAJo9kJzytiFuk2qxmSrA2e0Modx6IJ+GMaUUCEKycVxZ3SJxRxX7pQkKkNr
	hI+DJicBNs4IgXpeshVljeEmSh7DXVs=
X-MC-Unique: VYKA4X3vO5iA2lAuAVi66A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PjoAZPmqG+pv6U9nklnjxWqnJzQv52jxnmYNlegPep8wf2uCNO83OThmM07xhTJLw+0KnZWRF0Dkz0IjzB6hpUWmpnaVCYN/UVFgmhJrc0u/TWgCnetrh/tbcQ6dSxwF43MKys4YsxAq6bEIGyhdWoudDqVY6xgiw8TePjB1nMvrpOvTNE81E8aQB1qv/L5NbWbNUAew9rhwfltLmljSJ9fHwbltUqUOVl6JSWHpYSHKXnb83hsbFv3xFA5JnBNEaNpl6QM3LE0E274PJ/dFlJ+eQWmZt+KaPw9jtB4veOYMm873t0mLouBaSCGEjdC467gVPaZZkhYe+bPCwThAIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NGYaCIoX8o17jAvi6lqGRSDxKlq7w0w9+/u0S+y8TUY=;
 b=NdGhAlttJ8jswFnLRbn3/OjniGL76ExAOxLXW+IM8V8k+WWOP6eCqC3pbFM2q5oAOtb06preUTciJa0TVDU/t+GypFRiuiM18ElMo2j1524l/OcIzHWJLnzGNtp65kcBuWCV5TJfgWWB+jPPF223sKRXbahPko/8nMF/GJuwQ6IhpIam/zbObX8joxBfYoNPpa54sWaeQbrdsSVewLmcpIW3C5+6Tc4dqe6BYMWivsYy2GLMt3vHL1HTmBGc7vRIKaoj/Bg1O0NTLGVOCgpER8ZyBb98YtJqKCcOHyt2HPaZKW3oKvmifXbAvTopYjpBjpxYmnLF/T7coGQJI46yCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7a80d08b-edd7-43c8-a7ce-42eb85d6f3be@suse.com>
Date: Thu, 9 Dec 2021 12:27:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Tim Deegan <tim@xen.org>
References: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com>
In-Reply-To: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0110.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 28a7c507-f9e7-47fb-0677-08d9bb06e644
X-MS-TrafficTypeDiagnostic: VI1PR04MB3118:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB311805AAA8CA3E8777AC1946B3709@VI1PR04MB3118.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0Ddf4NkC3WweEEXsO3Now6w19yOLwvZzTdfmecDSZBVidkqKb13RAH5BUex3c/e9MVBxrtnN4a+BlHAy4bBgfUjaBtcEs0o/vnWGCRQU29S1zHJazn5gU4bBJFhxN0sJcRSNB2k27iUo1AWylj02UgobcFoc/5pKJckqRv+EB7uxNhHb2N81KLsizPXhKSaID3Qw6S3Qzf9+ovl7C5I4YUtdjnydxNblttyTAutzzQfIxyVKW0uR3wOqgNgPwOZWLN98+P6pdDezxsYdFy9A50mWy/1dp3eVP7eF5m0q7oTqm1V208Q8Z95F+UR9hZlF3xT51sC9iRTrzx6mhOBYvZIsKVs8HVomVx9Vbin7nbW5Wv59auxPtMNd+/z6UBQZducpy9iXYHDi1XzdBjKD7ND4/XMLmi6yC5yoSRzj1AU19p8SpGbs6Zdb0HdESUv2WnJiF47G9HXaPEKEwuaMy7DAQrzxbAwiagYQ5wNizx9t0Zju9R45lMMwzsUpM3Oiqw6d1GHeAah+zFVM8962p7A67gUGvWDJyAyNUks/Ij4WQ0VJJtfQqK/4CYva1RTzeCGIFDjF4EQRjXUpgoP3GCylCNwvVY0VDsmsdnXcJqCwwizAo7x4D6P28x95w/akeQKWQCqhN9YzgoUVANcCCBFnJcNQNNBWCavZC/ls2QR+sT6aNwov7NTEQXTWhOBwMUx8skDWbJE2pPoOTv5T/ocdZxnvh2g/De6zLOE33B8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(31686004)(31696002)(8936002)(6916009)(86362001)(5660300002)(186003)(36756003)(4326008)(6486002)(54906003)(38100700002)(316002)(2616005)(66476007)(8676002)(26005)(66556008)(16576012)(83380400001)(956004)(66946007)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjcrelZWNUpNUDZUNlpJSE1MbWRRZ3NKK2ZuTUVCSEdrcmR4YVJ4WDJvZzk2?=
 =?utf-8?B?UkRGRWNVdFc0b25Cc0k3R2srbVhmQVh1QnY3OFkwdndKclBYRWFIVHpXRytr?=
 =?utf-8?B?NTNJZDMxNStaK3E4b1lzaktvM2NSQy94bkk2OTU4SzFvWktlcFE2cDJ3SFAv?=
 =?utf-8?B?akxyR1U1Z2ViQW9WUHlVd2pPNjBMemdLakw1K1VnaUJaN0RRTVlCTVVJSlhv?=
 =?utf-8?B?YjZsazQ2enFZS09jY2hET3lvVjMvUEw3bjlGTzJ2SlR0a0RGbGZJZHVBaXlQ?=
 =?utf-8?B?cUlDVUV6S2Vnc3VkcngvcUlzaktENXRGd0NJbm82TWwwUW1JYU1DR012TTBU?=
 =?utf-8?B?WFdrM3FRQVZORXpXQlpCQzl0UE5iY2tTcndvek1ZRkNiUnFPK2VRSHlqZjlV?=
 =?utf-8?B?QUFrSjRDUjRjMUtucENpL3k5KzNrWjVnWlFoV01TNSs0UzJGcUk2ZWpnR2JE?=
 =?utf-8?B?aEd1MTd4TXp4OWsxTGFkUUpUUjlmWndmcXVRMG4yR0dSb0xTN2xVa1JEU3ZT?=
 =?utf-8?B?cjJ6KzJaMER2aGkvMnNUYlBLdDFER3pReFdqdkh2WVI1Vm9sYitLZHVzUXdv?=
 =?utf-8?B?QW56YnZuRWJtT2tqci9ld3JTRUpTVTlkVE1NeDZ5SFdSazdaMndqamoxQUhr?=
 =?utf-8?B?ejU0TEVDWSswUTBHNjg4dDgwRVJ3VmJsSnBRaHlqalc3T0hSQWNXczZ4Lzdv?=
 =?utf-8?B?R3psdC92TkhsNnJRcllFMS9NMGdXMHVGemZENzF5cjFmN3RheUF4YXBkSllt?=
 =?utf-8?B?d2MyWk1yL2tPK05kak9UczlZTFRxQ0c3NVBRV1RMK0pSRThhbVRDeU5mMkFP?=
 =?utf-8?B?LzczNGxhVTNxV042cThsSEJuVWNUc3B2YllUaHMzaVZwUmJkdnA1T2dkQlY5?=
 =?utf-8?B?QlpjdTRZazhjbjl2Wm9IVVI5bklxT25IYnVpRGRob0h1RFFmcHNNT1JkbVV1?=
 =?utf-8?B?cnl0MEVOTlh3T3k5b05qRlhIOE9YbXVkLy9yK3NCR0lwSTdmWHFuSUJoNFk0?=
 =?utf-8?B?TWk3VmJvU0JhQ1VFQVBPSERGV3JYVjRzdE50V3YwMUlBSHNkMFRZZEpWS0NC?=
 =?utf-8?B?ei9tMFVaUURtM0M1TlNXQVY2NmF3QkRyMXhKZ1JuR2lLVnhSZHd1K09JVkQy?=
 =?utf-8?B?MWRJQnNjTE1hVTVmVGlzYXFpdWE2RXJMUnVKbWpLeFRMQVNwZXpLVWZiZXJj?=
 =?utf-8?B?YUpDZklEbkhRRS9saHYrbUNROHg5QURZM0NFYWRiaWlwQVl0cHovRnNwSHVE?=
 =?utf-8?B?R1pVak5TMHZGcTJ4Ti9SK09XRERDeHdXUUhHZW9RejBCR1N2UGcxR3JQOSts?=
 =?utf-8?B?c3RCdmxSVEVSV2NDM0FqU0lWNTVBUU85UmVzSndtRWtDdm96ay9xREhrK3Ey?=
 =?utf-8?B?WFlQSnFHVkZuekFScFZyM0J6MUVxTFVCUkhvcWNsdFVmZDA0U1huRis5aDU2?=
 =?utf-8?B?SCtFS2YrdkszS3oxUDNNM2JIUXhMbmJoL21DS1RydVBHVHNiS0hvcE9WVzk5?=
 =?utf-8?B?bVBscm1CTnU0QUJsYUlraXJxbzY4Z2x3bEtuT3ZaNVA1dWpnNGNPSzlVamRO?=
 =?utf-8?B?cDVON0Vja3BHWEEzajBxK3cvN2pFNjdaWEQwNFJMM0hhdXNuU2hOWG9kSmF1?=
 =?utf-8?B?Wm0rUVBOcXZPd2hodUswYzVwVWVtYVphK3dUeVZZZFBnSHlCS3hUc1ZSNFJV?=
 =?utf-8?B?eDY3YzFVWUdEYjhFWlhqUUJ1UUc1Ni9SMGNVYWtFWUdoT0RBeGZtdU4zWitE?=
 =?utf-8?B?UFJzcmJnR1BQQjAxSnAwMDVpZERyelpsVjJqTlFxRkMzYXRDcGlrcDZpSFg1?=
 =?utf-8?B?cEQ5U1RvbDI5OWoyUE9Fa3VBRit6UkdZL2FSMjNkeUtmNmtpNTlyeVkzTHlP?=
 =?utf-8?B?ZTI4cTB0bEI2Q0NqUTVjVTh0Tlcrcks1NlpWMU9LTnRUbEpzV0pVZW1BRzdw?=
 =?utf-8?B?RU9TSWpGNTdaOGdTQ2I5YzRoRlhHbUszTXphL3I4blNFb21OcVFmV0NBMTE0?=
 =?utf-8?B?ay95aHVpVFFNYlhGWWVpNjQraldDeWV4TGNyK2JqU3lsOWpIVnN6ejlFZmZB?=
 =?utf-8?B?UHNibEhlQlpXZlU1TDVHTHRBVTdJNVFwZStHdlhLek9qcVNmMUROb3BUSXlk?=
 =?utf-8?B?NHZsZFQ5Y2RrSFhjM0pyTzQvSWFhbG96SktSYlk2dU1XQkttanZ0ZXMzM3hB?=
 =?utf-8?Q?hGXgLOdS6ohNguSzHj4+dtU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28a7c507-f9e7-47fb-0677-08d9bb06e644
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 11:27:35.8380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H6tDBhLtaYt1+60rrZ2DFWCECzQsD/OpM4ooXK1xvB36xdUwqZHw1fXuCyLJVMKnCf7C7PhQHHtzE1GPWUMV6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3118

For guests in shadow mode the P2M table gets used only by software. The
only place where it matters whether superpages in the P2M can be dealt
with is sh_unshadow_for_p2m_change(). That function has been capabale of
handling them even before commit 0ca1669871f8a ("P2M: check whether hap
mode is enabled before using 2mb pages") disabled 2M use in this case
for dubious reasons ("potential errors when hap is disabled").

While doing this, move "order" into more narrow scope and replace the
local variable "d" by a new "hap" one.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Strictly speaking "fn_mask" could also be "unsigned int"; I wasn't sure
whether changing that would cause objections.

While at least sh_unshadow_for_p2m_change() presently relies on this
behavior, it is somewhat odd (and inefficient) for p2m_set_entry() to
split even non-present mappings.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -631,28 +631,22 @@ struct page_info *p2m_get_page_from_gfn(
 int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
                   unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma)
 {
-    struct domain *d = p2m->domain;
+    bool hap = hap_enabled(p2m->domain);
     unsigned long todo = 1ul << page_order;
-    unsigned int order;
     int set_rc, rc = 0;
 
     ASSERT(gfn_locked_by_me(p2m, gfn));
 
     while ( todo )
     {
-        if ( hap_enabled(d) )
-        {
-            unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0;
-
-            fn_mask |= gfn_x(gfn) | todo;
-
-            order = (!(fn_mask & ((1ul << PAGE_ORDER_1G) - 1)) &&
-                     hap_has_1gb) ? PAGE_ORDER_1G :
-                    (!(fn_mask & ((1ul << PAGE_ORDER_2M) - 1)) &&
-                     hap_has_2mb) ? PAGE_ORDER_2M : PAGE_ORDER_4K;
-        }
-        else
-            order = 0;
+        unsigned long fn_mask = (!mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0) |
+                                gfn_x(gfn) | todo;
+        unsigned int order = (!(fn_mask & ((1ul << PAGE_ORDER_1G) - 1)) &&
+                              hap && hap_has_1gb)
+                             ? PAGE_ORDER_1G
+                             : (!(fn_mask & ((1ul << PAGE_ORDER_2M) - 1)) &&
+                                (!hap || hap_has_2mb))
+                               ? PAGE_ORDER_2M : PAGE_ORDER_4K;
 
         set_rc = p2m->set_entry(p2m, gfn, mfn, order, p2mt, p2ma, -1);
         if ( set_rc )



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 11:41:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 11:41:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242975.420193 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHnL-0003ug-Qw; Thu, 09 Dec 2021 11:41:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242975.420193; Thu, 09 Dec 2021 11:41:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvHnL-0003uZ-NO; Thu, 09 Dec 2021 11:41:03 +0000
Received: by outflank-mailman (input) for mailman id 242975;
 Thu, 09 Dec 2021 11:41:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvHnK-0003uP-N2; Thu, 09 Dec 2021 11:41:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvHnK-0008Q3-EF; Thu, 09 Dec 2021 11:41:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvHnK-0002c7-6V; Thu, 09 Dec 2021 11:41:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvHnK-00072o-5z; Thu, 09 Dec 2021 11:41:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hc5sSdPtfHBfLs9zA3g6o9i69aaD1H4Eft1pZSB4dEQ=; b=3taw9MB0uz4JOWoPoKDErPnqXR
	rE0hNOlgEjMKRfb4lKeCSKHypvlG/PFwwD7PsjqFVNfIhUbQc63/SNQqEYSwNNbdF8b6s2fbdPGo4
	UIetcJJ8mB7X0eSfe/3+ggL4Ziaeb1FOFTAmrXMR9Tiu5s3UeDH/kELfRCVXRE7LmYbw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167247-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167247: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 11:41:02 +0000

flight 167247 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167247/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 12:09:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 12:09:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242988.420219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvIF6-00080e-Cp; Thu, 09 Dec 2021 12:09:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242988.420219; Thu, 09 Dec 2021 12:09:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvIF6-00080X-9n; Thu, 09 Dec 2021 12:09:44 +0000
Received: by outflank-mailman (input) for mailman id 242988;
 Thu, 09 Dec 2021 12:09:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvIF4-00080R-Nm
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 12:09:42 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e395a771-58e8-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 13:09:41 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 51F261F37F;
 Thu,  9 Dec 2021 12:09:41 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F358413FBE;
 Thu,  9 Dec 2021 12:09:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id rhHpOQTysWEFXAAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 12:09:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e395a771-58e8-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639051781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=HeM2KyDN2ballrXXSN7JrvcKdnc3fj0bhhAax0fif/I=;
	b=qXK8giJBjcuBcEtl2PUj5my+fgPkCQ0ReO34odAQUfD0j5AROEMHha6hT+ozelz97wC0MA
	/BQopoQeHhgNyJ5eB0wgYA6xH8UHbXZjctG6Q5jh/LKkZy4dkVqhBQ+7sXCYeLSaIn9tDm
	E7a2CbOy1wpIezrbUbGqMUjeZ+ON3kg=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: anthony.perard@citrix.com,
	Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] tools/libs/ctrl: Save errno only once in *PRINTF() and *ERROR()
Date: Thu,  9 Dec 2021 13:09:39 +0100
Message-Id: <20211209120939.513-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
saving and restoring errno in order to not modify it. There is no need
to save and restore in those macros, too.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/libs/ctrl/xc_private.h | 32 +++++++++++---------------------
 1 file changed, 11 insertions(+), 21 deletions(-)

diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h
index 2e483590e6..a3fe475c75 100644
--- a/tools/libs/ctrl/xc_private.h
+++ b/tools/libs/ctrl/xc_private.h
@@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
 
 /* anamorphic macros:  struct xc_interface *xch  must be in scope */
 
-#define IPRINTF(_f, _a...)  do { int IPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \
-        errno = IPRINTF_errno; \
-        } while (0)
-#define DPRINTF(_f, _a...) do { int DPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a); \
-        errno = DPRINTF_errno; \
-        } while (0)
-#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); \
-        errno = DBGPRINTF_errno; \
-        } while (0)
-
-#define ERROR(_m, _a...)  do { int ERROR_errno = errno; \
-        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
-        errno = ERROR_errno; \
-        } while (0)
-#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
+#define IPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a)
+#define DPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a)
+#define DBGPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a)
+
+#define ERROR(_m, _a...) \
+        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a )
+#define PERROR(_m, _a...) \
         xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
-        ## _a , errno, xc_strerror(xch, errno)); \
-        errno = PERROR_errno; \
-        } while (0)
+                        ## _a , errno, xc_strerror(xch, errno))
 
 /*
  * HYPERCALL ARGUMENT BUFFERS
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 12:17:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 12:17:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.242994.420230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvIMg-0001Uc-6h; Thu, 09 Dec 2021 12:17:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 242994.420230; Thu, 09 Dec 2021 12:17:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvIMg-0001UV-3S; Thu, 09 Dec 2021 12:17:34 +0000
Received: by outflank-mailman (input) for mailman id 242994;
 Thu, 09 Dec 2021 12:17:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvIMe-0001UP-Sp
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 12:17:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fba7afbe-58e9-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 13:17:31 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-QkVXHt9QMxyHE_MUiuW0OQ-1; Thu, 09 Dec 2021 13:17:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 9 Dec
 2021 12:17:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 12:17:28 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5P194CA0023.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::33) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 12:17:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fba7afbe-58e9-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639052251;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=0wqGv5muiHpfan4IS8sY0yD+VfuN7Aoe8pGuQvcTvdQ=;
	b=ivA2unleC7VAkPs1hTJ9iGA+EUwn2IifhIB+qLs+MgzeCPWf5UIOkxhNfQVOc9wn1/1WeG
	hfFDtddQKMmrESkldD3gAQD3oKUU9bUHYMcxxBf3xF/0yL2TwV6g5KGg29DbyZSVtttmwL
	Td9RIc37NrIK0d+BrO8GhKqU7bDAZYU=
X-MC-Unique: QkVXHt9QMxyHE_MUiuW0OQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jEtnkwv5dNISx9xKP91UMBWDIvPy5Uc9XoTjR7GDbq7EGIhIzRlYBzXAIYQaGTjmhlExf5S8ivX6hme1cnyUA3DJcJNcU3KNdYYfF2yUEbzxIhBn0q+X841jNkoo+XfoKirTOpKY5qLecc8a0y3g31zAXPrMXY6WjbC9EzuCJ/MuH+8P5fNIMMrmtLfX1m4EL34RGH20Ep/SdT2/tgK/MfmOFJU9YaybUoVa79nTwCncUgCrwJMHjXYqcKiIX0o6HtGYCpVp+3ZCSiZRD1zTpqijH4Xlf4HcD++z9uCcEElHog9ENEw3PNwyV4WyKkUBRlyPt2o7VLCSeu5gprjv2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0wqGv5muiHpfan4IS8sY0yD+VfuN7Aoe8pGuQvcTvdQ=;
 b=iLDWTMzNxucrO6QQfictNAI6TWnQchq5kX9EDBMRa/61EyW2b9B6yMzAFIOsVGKCWDT79TzcvSmeRYalWoMpe12Tza9e6Y3k84xvGpdD8ViAkDf7pBaXs8RRON/DVvwGnjsbWCCElW0V9bTrrKG2bvCrHLcM9PqB43dKKBzkrQXqYiVB9ottW2oyyFuV4JwjH29/07e8Fqi6Le5rFIq1zabTcCFXhc3rRKo4F2p9s6fAbSRZdfhAhbqg5BOXILkyhfTjN8kmfyqCQ1OM5x01r9afw7VWw19AYpI3WGLQBWXOBdvhszIW3zY5+32Sb25kpoA3lfJYWgaHFM/ThH0aGA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
Date: Thu, 9 Dec 2021 13:17:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: Paul Durrant <paul@xen.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: attaching device to PV guest broken by your rework of libxl's PCI
 handling?
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0023.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7547a881-d702-4d27-eec6-08d9bb0dde00
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038983C3C003AB92DA1EC73B3709@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	hqTBrv4hL1euisiG+bHzo80IYkV5H2y9QqxVgfKfAD69R7h2RSy8txiWYSuJyW5cR1iqkI8PEouACKiEknEbvBkRXdPJtkgB53JRZWTRfG0kVWQk5Kupyuf/whqlUBCWjMC/B6r+MbnkEPB56Vz3PA+rZiJIn1TOPu83D6uYvv4YjdTyOyx7YkZqz8KPGkV0GYEOjjI5Z9RPIbvATpoCo8nAFg28kcbVb+eShGOtTa24cEBAVrkfLTK993vIaCNtY7GDpu8/7AS5ENpXO1Ulvqf9gREqh3wu1niQYwJc3I3awzm4qiXV8sidkxGGGEZStzxoTfAfNpfawQpzwsjFHlUuma0dyF7nkhxaqYey5I2COH9mKYfSlZsX/ynqTcJL2EAYSkEBlIJ/pvb02KfIJLf2Brm+hbImfmETlVouqS458p312uLO7QZQejcX0rENeAl7BV9G9wFu3M2ru4hPVu3ww/AkZ+AKsFBl0fMXMg2sM1KNIjAqQF+tFrLNBkUGrvI8pgSocrrcu5xyR28XmX1t9e3oAyXYFqLedEx9MsuY+DSf+uLOWbnaEBPLYPX4dRYuXVubvuP2jU80tUZleq+yF4Bs4O/+eX2/u8q2y+yOSDwyFJLjy9cf+lbOmC1Ek3qwVbxbep3oqijpxY0FFxk/9tzpWqZaUghjpIhfHiY0wZ/TsaiMUzH++MBDWCyHUG49+nSdNVUK5kQStrD+G2kIQ0TQZrY75Dqskl6HL9k=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(31696002)(6916009)(16576012)(6666004)(5660300002)(4326008)(54906003)(2906002)(36756003)(2616005)(38100700002)(316002)(66946007)(8676002)(26005)(66556008)(8936002)(186003)(66476007)(31686004)(6486002)(86362001)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ck1kVkFZNkdPSUhQempERW5NRWZqdnh5NzZVaFJLSC84cTNFOTlVbVppbDhw?=
 =?utf-8?B?Z21Ia1Z6Z3pMRjZqNER1SENyVnVVeDUrRXE3em14NTRMY3lDTUhaMVY5cUsx?=
 =?utf-8?B?Q0o5eTV0ZmppT3RzbGtFdHBuQnVVdS9NY1BZTXJxR0NLSGwySzJVVVJHL3BI?=
 =?utf-8?B?c25yTnhjNjBmcHFQY1VKSUliNXdEWVNpNGh0S2ozemlVeXFEUFNicGxGSWty?=
 =?utf-8?B?eDRXN3lVcnBUVjlBNlVhOE94NHowdVVJNENqY3lUd1RCK1h6VGo3QzhTVW9o?=
 =?utf-8?B?ZllBZjV2dzhXUjhFdGFlS2xJSEloY28xeVh6MWNvNW5ZWUlDeHlDMVJYdFh0?=
 =?utf-8?B?a295SE0yMzFtVVlIL2gzSGx0UUIwOGRXUDBsdWlwNVhidldsRG80d041cWda?=
 =?utf-8?B?R1ErKy96Tmdwa3AwTFcwK0hNTzRoWXFzamljMHY4MzRRN1FRb1VDQTJwNjdt?=
 =?utf-8?B?RVcyZy9KcFNERmxNQ2FFLzJlWHpFQ0VPM0FzVEVKRHYzSDg4eGlxblpaZnhr?=
 =?utf-8?B?TWpqT1czNGhjV1FmeEwzMkdxWU1iamloejcwNjU0M0FIK1VTSExxUlZ0TDFh?=
 =?utf-8?B?Z3l5RXg5blNJY252OW1BdVgxMndrN290QmdMREtZV3RxRlZ2dS8zYStpa3VS?=
 =?utf-8?B?Y2EwTHdLM2JraCtwR0dySXFXaDlhSDlWdFpMNlJ0QW1QZytNbG5iTkpTK2Vr?=
 =?utf-8?B?SGRmUXpDRWpBYTlaT0VHbmVBSFNuNEwrNGVxNzdZcVBLSG55Syt6TFlPKzJv?=
 =?utf-8?B?MUprUnBVd2xwWnBTc3hjTjVaOFlkUTI3M1JXa0lETVJNdTlWamJMK2poMkZV?=
 =?utf-8?B?bzY4NklNNXNNT1B4QUhxaUdrRTRUdy9hVG9RRjE5aS9rUXQ1cXh0d3dQTHZa?=
 =?utf-8?B?VHFwaHdtMStoVVlNQ3B0YnF5RVFBNitiY2UvNWt6VEFmR2Z0dEw1OVMrVU8w?=
 =?utf-8?B?K0UwRzJhSEU0LzBSbSttazhmTU9qS1Z6S3UvZk8xWmFpdFU4VDU0OWN5UUd5?=
 =?utf-8?B?NHU1TmxrWmlOb000OUJKeUZVMFBQQk5RYmk4a1hoWGVtM3NKK1Q1Zm5GLzRl?=
 =?utf-8?B?TXBSRUN0ZDNxWEZnN3FXOC9xdWFIZWtwM3drd0NLbklrUEw5NVVKY0pTdmVP?=
 =?utf-8?B?RS9NUHNRU1pqZkJSM0Q0MkZxUjhrOHVwdHNQUUh2amFucTJ2eC9uQWJ0RWZy?=
 =?utf-8?B?Q1RwQzNrT212Qkp4ejJ2VlZUeHltRlZsWGhXc3dHZDFOUy9HMTBVWVBpSktR?=
 =?utf-8?B?N0FlenYvMC9TT2xGUHJSeUlTN1NmL3IrZlBGajV0SVZOeW5aV1Ezc3JUblVV?=
 =?utf-8?B?VENVSnF0Yy9NWFRHSHc4OXUxQm9MSVFzSld6RFlDaTVVMy8zSXpWb0FjYzU4?=
 =?utf-8?B?T2wva1h6Y2RqazQ4UTJ5ek9ZczJYVTdMSjdiZGxEd1M1WEtObDlXSmdGS1pV?=
 =?utf-8?B?NUpOVFBtVkdqTXFpR2o4Mm9xWGRVYzh5Q1FKdzd5YU9mdDZWNGlqdTJGOVFF?=
 =?utf-8?B?dHlWbllzdmdMNVptaTFXK0tmRmg1dnV5cVRkRE1Gd0R3SUEvQXZPcVRZOHJx?=
 =?utf-8?B?d01vSDJoUEU4ekt0RlVjejNEaG12N21Wd043L1lHLzV2YXdnY3pkWFpJMElK?=
 =?utf-8?B?d0dXbTYwVnpRVXFwc08yZGlRdGVCNG9lRUI3VHdwTWxFNmI1c1NTdUZsWEsw?=
 =?utf-8?B?REM5bGdrb2ZEcVl4QzFPbkdJQjhTT3J5ektOSFd0QTFJeHBGdFk4NGlOMk4w?=
 =?utf-8?B?V2ljVzhjcUVQdW0xUHhlcU9sUzdwRmFwZDdzMXRLUmh6UTZ6NE0rOHBEMVZq?=
 =?utf-8?B?MkwyZ0R0cUlyMXo1OGJnM2ZkSHdEWCs4R3FYSWlIQ21IQlMwTi9QWG5nZTZi?=
 =?utf-8?B?L2RQeUpkRUtBdXV6akxSd1lNSGJXZ2oxRUFGbEhWdDJYMGhxbGExb2todVcw?=
 =?utf-8?B?aTVHY1pNYUFUM2JCeVI2YWNpbUpzR1c3MmJ4bEM5M0hDZjVBclpDZ20yZVdX?=
 =?utf-8?B?Y05WK1FqOFRnQ3N5MjlGQ2JteEU2cVZjN0ErMnNZQUg3ZFdBYXE2Yk9uMy90?=
 =?utf-8?B?SVlhVG5hQmgwSUxRRHY4T1VsNGlvK1R6RzVjNVd3VUhuU21sWDVTVU5hT3lZ?=
 =?utf-8?B?VEpOV25rNk8vSU94Q0w5NFVRR3N6TnRHYi93M0tvR2R5d2hHTE91Z0x3OUxH?=
 =?utf-8?Q?LdhuWiz9PTonML0/wIMbSC8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7547a881-d702-4d27-eec6-08d9bb0dde00
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 12:17:28.4876
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PJNfr1CyVGUOB9Cr8+5ljHXhNlzSFCrO5FLM4z9Kd6gvTbg3Ar4N8WYk4qJN7Tv6qrlE2VHC/I/RgO9ksidDNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

Paul,

in 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are
reflected in the config") you've moved down the invocation of
libxl__create_pci_backend() from libxl__device_pci_add_xenstore().
In the PV case, soon after the original invocation place there is

    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
        if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected)) < 0)
            return ERROR_FAIL;
    }

Afaict the only way this wait could succeed is if the backend was
created up front. The lack thereof does, I think, explain a report
we've had:

vh015:~ # xl -vvv pci-attach sles-15-sp4-64-pv-def-net 63:11.4
libxl: debug: libxl_pci.c:1561:libxl_device_pci_add: Domain 18:ao 0x55a517704170: create: how=(nil) callback=(nil) poller=0x55a517704210
libxl: debug: libxl_qmp.c:1921:libxl__ev_qmp_dispose:  ev 0x55a5177047e8
libxl: error: libxl_device.c:1393:libxl__wait_for_backend: Backend /local/domain/0/backend/pci/18/0 does not exist
libxl: error: libxl_pci.c:1779:device_pci_add_done: Domain 18:libxl__device_pci_add failed for PCI device 0:63:11.4 (rc -3)
libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to add device

Since I don't fully understand what that commit as a whole is
doing, and since the specific change in the sequence of operations
also isn't explained in the description (or at least not in a way
for me to recognize the connection), I'm afraid I can't see how a
possible solution to this could look like. The best guess I could
come up with so far is that the code quoted above may also need
moving down, but I can't tell at all whether doing this after the
various other intermediate steps wouldn't be too late. Your input
(or even better a patch) would be highly appreciated.

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 12:58:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 12:58:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243004.420253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ0G-0007bO-Ep; Thu, 09 Dec 2021 12:58:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243004.420253; Thu, 09 Dec 2021 12:58:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ0G-0007bH-Bs; Thu, 09 Dec 2021 12:58:28 +0000
Received: by outflank-mailman (input) for mailman id 243004;
 Thu, 09 Dec 2021 12:58:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yJm+=Q2=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1mvJ0E-0007bB-PL
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 12:58:26 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b25e9f36-58ef-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 13:58:25 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id bu18so11977287lfb.0
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 04:58:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b25e9f36-58ef-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=oJPBo2f3CEADWiji3FOctawMd4KgjhAZ3A/VYvnBXdw=;
        b=FtSZlQoX+uTQpyI2biMDutjC3uNjJYxKaFW6PpWLcNfZ857U7knQoZgHafqtizI4NI
         CyAmk2zQY3jxflmkTA/YQq3uylfmUVhko6IMB6E/IA26Wq60ePO2wL1OapxHpY25M0IU
         oguf6SZWq3v/Q4TqEZy9ksRGMVG1YfdGEDAZu9Z7D9PlffqkvoUcpKeh1svgIONlYsLv
         zRzCDir3fdcZS0Xct5GhY8XZvjH/UMw9PttlJZrjj3WkJ4je999vwkBHwRhd2W5aF1x0
         mUBdhWOrzWc8jAoAWOACf52diYu6ekcdxVmq9ycpNkocOXbXrJPpqdLUeE02XdjPt1hi
         YZng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oJPBo2f3CEADWiji3FOctawMd4KgjhAZ3A/VYvnBXdw=;
        b=xX0aXQYNnNa6/Mou++ZVYgcWlTTTdZeAWaYH6bK3Dg6YbSLb8Icx6V/m9oVT989TwW
         FCCeJQHBzpQVnLzv+KwrFe5QVaRs2UUc3C2yMgcp4H/waQuqym1mSyCXA/buhSzdz/Kf
         0wERziCE/zGv9p2cD0vM3BvnhlfhsCBexjikVnN5tzZj2tUUsJDXy6qFNBxh85oAQqRN
         WGs/3icZFanvUS/PIfE0DI/1mU8ngXCGY2Kk8xWyAm3nZiSq/fxYZwxG4bDqCSZKtym3
         uhLXjTjVq5IGS7ZizBsiQB47NdMTeHU3FW7TyuoQbZdtQKHpCe+mhhrmyzPD6GYwC4/k
         kT7A==
X-Gm-Message-State: AOAM530wWBKUOqs2JGnU/GUOyCXbq3ot9QNGETqO4VGkFkoIX5zpbO/O
	iCfzXD+XmsDEFXvQCnnDoCaqAr1Zt66gFXE56aM=
X-Google-Smtp-Source: ABdhPJxzGD+IMg6HkEfBuX83EFH2So+u3DbTZPoxKyYeBVqzb80Kc8PH5sm+pujfDDJraRHOSuHAg980mMnV3klnXdY=
X-Received: by 2002:a05:6512:3c82:: with SMTP id h2mr5911978lfv.128.1639054705041;
 Thu, 09 Dec 2021 04:58:25 -0800 (PST)
MIME-Version: 1.0
References: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
In-Reply-To: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 9 Dec 2021 07:58:12 -0500
Message-ID: <CAKf6xpuDwV5nv9c3CX+Lo4e+dM=Uo=iv1nmeNtQNObfgD_wChg@mail.gmail.com>
Subject: Re: attaching device to PV guest broken by your rework of libxl's PCI handling?
To: Jan Beulich <jbeulich@suse.com>
Cc: Paul Durrant <paul@xen.org>, Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

Hi,

On Thu, Dec 9, 2021 at 7:18 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Paul,
>
> in 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are
> reflected in the config") you've moved down the invocation of
> libxl__create_pci_backend() from libxl__device_pci_add_xenstore().
> In the PV case, soon after the original invocation place there is
>
>     if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
>         if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected)) < 0)
>             return ERROR_FAIL;
>     }
>
> Afaict the only way this wait could succeed is if the backend was
> created up front. The lack thereof does, I think, explain a report
> we've had:
>
> vh015:~ # xl -vvv pci-attach sles-15-sp4-64-pv-def-net 63:11.4
> libxl: debug: libxl_pci.c:1561:libxl_device_pci_add: Domain 18:ao 0x55a517704170: create: how=(nil) callback=(nil) poller=0x55a517704210
> libxl: debug: libxl_qmp.c:1921:libxl__ev_qmp_dispose:  ev 0x55a5177047e8
> libxl: error: libxl_device.c:1393:libxl__wait_for_backend: Backend /local/domain/0/backend/pci/18/0 does not exist
> libxl: error: libxl_pci.c:1779:device_pci_add_done: Domain 18:libxl__device_pci_add failed for PCI device 0:63:11.4 (rc -3)
> libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to add device
>
> Since I don't fully understand what that commit as a whole is
> doing, and since the specific change in the sequence of operations
> also isn't explained in the description (or at least not in a way
> for me to recognize the connection), I'm afraid I can't see how a
> possible solution to this could look like. The best guess I could
> come up with so far is that the code quoted above may also need
> moving down, but I can't tell at all whether doing this after the
> various other intermediate steps wouldn't be too late. Your input
> (or even better a patch) would be highly appreciated.

My attempt at a fix was this:
https://lore.kernel.org/xen-devel/20210812005700.3159-1-jandryuk@gmail.com/

It was in terms of PCI & stubdom startup , but that is the same as PV
hotplug.  There were questions about further re-work which went
unanswered, but my patch at least restores the old working state.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:06:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:06:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243010.420264 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ7c-0000b4-8c; Thu, 09 Dec 2021 13:06:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243010.420264; Thu, 09 Dec 2021 13:06:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ7c-0000ax-4V; Thu, 09 Dec 2021 13:06:04 +0000
Received: by outflank-mailman (input) for mailman id 243010;
 Thu, 09 Dec 2021 13:06:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xsbi=Q2=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mvJ7a-0000aq-KN
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:06:02 +0000
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com
 [2a00:1450:4864:20::434])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c235390d-58f0-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 14:06:01 +0100 (CET)
Received: by mail-wr1-x434.google.com with SMTP id t9so9586768wrx.7
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 05:06:01 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id k37sm5755667wms.21.2021.12.09.05.06.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 09 Dec 2021 05:06:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c235390d-58f0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=LC8hO528Kw/xQ5K88skCc+CMxlULIAtCChCBikBnpLo=;
        b=pK40YuriLpUlZDGKNg/C0wlMX4fRUBgtIPgCglEokB4hYvozRhF2tLMTISjjBpM15A
         sYLB2tAsrVNbrMfe/03hPtaZlO19oz2Tg1/nqvBuYEICb0m2P665W0m2VmxVBdanPL34
         6iYSx8gP5JbvkNSAPVvUHcrceRGYw2dw8228Nn1p4Ial1kjgChgvVAeCLC1CJJH9pTNi
         HXT1UTVPWBI7fj5+3rUzmP+XhTxjzyEoL9T0Xu1d+7XshxJjTw4bUcVpsfI4Q6LrSYcg
         KrXD3LFhSRDa3Y74TgLuXxDw4L4nnmSI0WWYzCtPzwO7zAcWQlE0sj6pSK+v2Tg5HZbY
         +MFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=LC8hO528Kw/xQ5K88skCc+CMxlULIAtCChCBikBnpLo=;
        b=ztEU7FcitXOrZDDzpUODtXaMSh7h8HdiIwZ8tXtyBvJup9eyktcqeEIyKSPAQVcKbn
         +ZLNI9SYiLmayAKIVwgfquHTUGuF+NnHjDtIgM3UNp40glVXF+Q6EovBpO37GC7PKKZK
         nMdlWz7gKMboaG8BGOsexqbCySreMJ55j8jKskD7DKHXSfyt+PCiaJP5xqHeGdtPei+R
         6Nvez00txufTG7STfnBV/2WkX+xgF5M6A9I5mxRxZ+pMPYjGiRUw20r5/IJxoOUjMTZt
         z9v87RmTWfp4Bq09bUfb9c2SQ1wtvcXJA7lmF1Sm+82y7ZA5x7tGbwEwdbHqdFskhFkE
         v/ng==
X-Gm-Message-State: AOAM530Llxkh3nKzkbeOdbD5T7Wt60WxhgGilJTWIFySqT5Lkyt0Nz/5
	8N3LG+iRah0PXsHpu1GZOOY=
X-Google-Smtp-Source: ABdhPJz6hUnrgVOY+NEaMvUs0zGfXvVM+QkTdbNntvL7JE9muAcVg/ZkHfVhG0faCpVI7jpIoKqcYg==
X-Received: by 2002:a5d:668f:: with SMTP id l15mr6346168wru.182.1639055161239;
        Thu, 09 Dec 2021 05:06:01 -0800 (PST)
Message-ID: <7e535b83-ebae-1a72-f43f-897d80ca9411@gmail.com>
Date: Thu, 9 Dec 2021 05:05:59 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: attaching device to PV guest broken by your rework of libxl's PCI
 handling?
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 09/12/2021 04:17, Jan Beulich wrote:
> Paul,
> 
> in 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are
> reflected in the config") you've moved down the invocation of
> libxl__create_pci_backend() from libxl__device_pci_add_xenstore().
> In the PV case, soon after the original invocation place there is
> 
>      if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
>          if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected)) < 0)
>              return ERROR_FAIL;
>      }
> 
> Afaict the only way this wait could succeed is if the backend was
> created up front. The lack thereof does, I think, explain a report
> we've had:
> 
> vh015:~ # xl -vvv pci-attach sles-15-sp4-64-pv-def-net 63:11.4
> libxl: debug: libxl_pci.c:1561:libxl_device_pci_add: Domain 18:ao 0x55a517704170: create: how=(nil) callback=(nil) poller=0x55a517704210
> libxl: debug: libxl_qmp.c:1921:libxl__ev_qmp_dispose:  ev 0x55a5177047e8
> libxl: error: libxl_device.c:1393:libxl__wait_for_backend: Backend /local/domain/0/backend/pci/18/0 does not exist
> libxl: error: libxl_pci.c:1779:device_pci_add_done: Domain 18:libxl__device_pci_add failed for PCI device 0:63:11.4 (rc -3)
> libxl: error: libxl_device.c:1420:device_addrm_aocomplete: unable to add device
> 

Wow. It must be a year since those patches went in... Most of the 
context has disappeared from my mind.

> Since I don't fully understand what that commit as a whole is
> doing, and since the specific change in the sequence of operations
> also isn't explained in the description (or at least not in a way
> for me to recognize the connection), I'm afraid I can't see how a
> possible solution to this could look like. The best guess I could
> come up with so far is that the code quoted above may also need
> moving down, but I can't tell at all whether doing this after the
> various other intermediate steps wouldn't be too late. Your input
> (or even better a patch) would be highly appreciated.

The commit comment explains the problem that it is trying to fix but I 
agree that it does not call out the new sequence. The issue IIRC was in 
what happened before the call to device_add_domain_config() and what 
happened afterwards. In fixing that I guess I missed this immediate use 
of xenstore.

I *think* the correct fix would be to move the wait into the end of 
libxl__create_pci_backend(), which is where the frontend and backend 
state nodes are now set.

   Paul


> 
> Thanks, Jan
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:08:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:08:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243016.420275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ9j-0001js-KR; Thu, 09 Dec 2021 13:08:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243016.420275; Thu, 09 Dec 2021 13:08:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJ9j-0001jl-H9; Thu, 09 Dec 2021 13:08:15 +0000
Received: by outflank-mailman (input) for mailman id 243016;
 Thu, 09 Dec 2021 13:08:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xsbi=Q2=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mvJ9h-0001jb-VE
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:08:13 +0000
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com
 [2a00:1450:4864:20::331])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 10868c8f-58f1-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 14:08:13 +0100 (CET)
Received: by mail-wm1-x331.google.com with SMTP id i12so4136499wmq.4
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 05:08:13 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id d15sm7760566wri.50.2021.12.09.05.08.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 09 Dec 2021 05:08:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10868c8f-58f1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=EDv5LdRBTHuyI6mwmppUY3/oYgq6Hd4tfClt02EQ6Ts=;
        b=YamEmiJhi5xLaOpJyir9xTnQYBKmqibUGk24dA1vBR6sDdD/PrQW1YdK9QVfCWr394
         RQ9jJPTdogw/ekf0Ot7D8sA2YyKTkjm6qfyjkKSmEkC9b6SUJQc6NGQMG+M15OjrgXU6
         z1ai69sSn0p7jXtM91hwrgp6uf8KcrwnhOPaYmDxRen0TH90SL5EGo1R8yqH3+D7jXPR
         OyUMZgMCGNZsw0HseLsQsB2Ob4UES1Yefg8zaBiUPC3MBm020cBKr1HI1QgsBkb/xTX/
         Vwu26IMtX2feBfHALSVHbZ9lvD/5HV3y9n2rtn/Qae9SjDYCi8bc9802i1W6tc/tcjVs
         skOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=EDv5LdRBTHuyI6mwmppUY3/oYgq6Hd4tfClt02EQ6Ts=;
        b=By8bHUkts1ymgs0yFY0VebZh5cBQys1AfSoN38ZUFHRY4laqJIoDwrejf/EDtczaB4
         0HZPQOQeMP8xATDyNcex93BDsuJTC6xFgDRTUKgU0fzFfJMMzYfZ6uhvvJkIb040ShvI
         BC2Ag8EXQ7e5EgWMsufk6XN92YC2VrsB82b/kTpiJ6nKdotct8uSLSB29WZmd4UoSyh7
         Dy9fN6FodtFF5r498hTvCuBiyWKlrAX5sdJ0Zg0+k81TVxex9LT2WoNiYA1rO9MJXpLX
         JXmKKVrpJx/3W+jy/aqWGPGdZWZPwzNjIBcJeJkXpRcDWvL1aIyGZvwE0P45aUREePzl
         gqyQ==
X-Gm-Message-State: AOAM532dFFZl1USugi+6fmMzmTYCBMIZhls3L6stiIUKHlhbPfQqTpxI
	exqDDv1yQeQvYel6njRDhxc=
X-Google-Smtp-Source: ABdhPJzQpmZ+bp5NSFvZNylbTZHqcc2HAJwv7oNhNj0JWXjhsYKdzmpwdeR9f/9SqB9nTyE7YwZNbg==
X-Received: by 2002:a05:600c:3506:: with SMTP id h6mr7026917wmq.122.1639055292612;
        Thu, 09 Dec 2021 05:08:12 -0800 (PST)
Message-ID: <fff78341-1e35-f245-e1ce-47f0fec9b86b@gmail.com>
Date: Thu, 9 Dec 2021 05:08:11 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: attaching device to PV guest broken by your rework of libxl's PCI
 handling?
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Paul Durrant <paul@xen.org>, Wei Liu <wl@xen.org>,
 Anthony Perard <anthony.perard@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
 <CAKf6xpuDwV5nv9c3CX+Lo4e+dM=Uo=iv1nmeNtQNObfgD_wChg@mail.gmail.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <CAKf6xpuDwV5nv9c3CX+Lo4e+dM=Uo=iv1nmeNtQNObfgD_wChg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 09/12/2021 04:58, Jason Andryuk wrote:
> 
> My attempt at a fix was this:
> https://lore.kernel.org/xen-devel/20210812005700.3159-1-jandryuk@gmail.com/
> 
> It was in terms of PCI & stubdom startup , but that is the same as PV
> hotplug.  There were questions about further re-work which went
> unanswered, but my patch at least restores the old working state.
> 

I guess the question is do we need to wait for 'connected' in any case 
other than initial creation?

   Paul

> Regards,
> Jason
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:26:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:26:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243026.420291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJQs-0004al-Ah; Thu, 09 Dec 2021 13:25:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243026.420291; Thu, 09 Dec 2021 13:25:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJQs-0004ae-7f; Thu, 09 Dec 2021 13:25:58 +0000
Received: by outflank-mailman (input) for mailman id 243026;
 Thu, 09 Dec 2021 13:25:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJQr-0004aU-5c; Thu, 09 Dec 2021 13:25:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJQq-0001kp-WA; Thu, 09 Dec 2021 13:25:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJQq-0008Na-O4; Thu, 09 Dec 2021 13:25:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJQq-00040j-NZ; Thu, 09 Dec 2021 13:25:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=19TBIyzLQunFlaRpRLNc4Qd5WcoqXRgevoASMIKbPNA=; b=oucPITSWyIKi9sO+EtS2gk8fTF
	qVUvTIYwsyG2GezyYNbCoXIae0RQdTV9BHe/AatKYVRict39S3kq/zCSuggqFTc7GgrLTkS+xYVar
	BXOY+Hrw6Eq1aUToJbKlQ9oDDXLGVVTIqDT82UXmQGef3IVNf1lo91sa77Vw7086wjso=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [ovmf bisection] complete build-amd64
Message-Id: <E1mvJQq-00040j-NZ@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 13:25:56 +0000

branch xen-unstable
xenbranch xen-unstable
job build-amd64
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167256/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/167256.bisection-summary --basis-template=167239 --blessings=real,real-bisect,real-retry ovmf build-amd64 xen-build
Searching for failure / basis pass:
 167247 fail [host=himrod1] / 167239 ok.
Failure / basis pass flights: 167247 / 167239
(tree with no url: minios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Basis pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
Generating revisions with ./adhoc-revtuple-generator  https://github.com/tianocore/edk2.git#c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d-06544455d0d460ed18c8582121247bf53292d7e4 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003088b173b0-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#2dd4b9b3f84019668719344b40dba79d681be4\
 1c-2dd4b9b3f84019668719344b40dba79d681be41c git://xenbits.xen.org/xen.git#608531a0cc34a5bc096ccf585e16f182b5ed83e1-c62d634cce8b1507d00a61bfc8168ac42367fe87
Loaded 10001 nodes in revision graph
Searching for test results:
 167239 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167240 fail irrelevant
 167243 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167242 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167244 fail irrelevant
 167245 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167246 pass d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167248 fail f4e3ce5f532860bbcf3a78d38f699dfbff0e1e75 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167249 fail 8eb79b5f4fed31667f27b7ac97b568724fe12496 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167247 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167250 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167251 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167252 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167254 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167255 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167256 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Searching for interesting versions
 Result found: flight 167239 (pass), for basis pass
 For basis failure, parent search stopping at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x5569dac332e0) HASH(0x5569dac56128) HASH(0x5569dac56a28) For basis failure, parent search stopping at d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f\
 84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x5569dac45018) For basis failure, parent search stopping at c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1, results HASH(0x5569dac3e0b0) HASH(0x5569dac39c20) Result found: flight 167242 (fail), for basis failure (at ancestor ~5226)
 Repro found: flight 167243 (pass), for basis pass
 Repro found: flight 167245 (fail), for basis failure
 0 revisions at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
No revisions left to test, checking graph state.
 Result found: flight 167250 (pass), for last pass
 Result found: flight 167251 (fail), for first failure
 Repro found: flight 167252 (pass), for last pass
 Repro found: flight 167254 (fail), for first failure
 Repro found: flight 167255 (pass), for last pass
 Repro found: flight 167256 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167256/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
167256: tolerable ALL FAIL

flight 167256 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/167256/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64                   6 xen-build               fail baseline untested


jobs:
 build-amd64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:28:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:28:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243034.420309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJTW-0005lK-S4; Thu, 09 Dec 2021 13:28:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243034.420309; Thu, 09 Dec 2021 13:28:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJTW-0005lD-OS; Thu, 09 Dec 2021 13:28:42 +0000
Received: by outflank-mailman (input) for mailman id 243034;
 Thu, 09 Dec 2021 13:28:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJTV-0005l3-A3; Thu, 09 Dec 2021 13:28:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJTV-0001oI-4g; Thu, 09 Dec 2021 13:28:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJTU-0008Td-UZ; Thu, 09 Dec 2021 13:28:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJTU-0005dz-U5; Thu, 09 Dec 2021 13:28:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vDFUo/RbZSknJfBDXny7L3r8W8CwbP2usTZXkqFblHU=; b=2AP7kgSBpnAOMmgv5hd8kWlFBh
	nwYQ6OzjD2Z6Rtzz7S64z3zYRtr728VdEkejX0q2rCbjQ0ZLKfbyH+6m9kRsF/FWVj3eY1InrPzV7
	+k3ZqvEf2vcFcbGUEDWcGjAybfmdgSBMrOqADKjriegQZpi+RFpZy9CB3NrQj4bylFFU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167253-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167253: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 13:28:40 +0000

flight 167253 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167253/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:31:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:31:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243041.420323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJWB-00077S-AV; Thu, 09 Dec 2021 13:31:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243041.420323; Thu, 09 Dec 2021 13:31:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJWB-00077L-7H; Thu, 09 Dec 2021 13:31:27 +0000
Received: by outflank-mailman (input) for mailman id 243041;
 Thu, 09 Dec 2021 13:31:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvJW9-00077E-PD
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:31:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4df15d54-58f4-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 14:31:24 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-3imMhHckP0qpmkoH16xDsg-1; Thu, 09 Dec 2021 14:31:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6173.eurprd04.prod.outlook.com (2603:10a6:803:ff::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 13:31:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 13:31:21 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0196.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::21) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 13:31:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4df15d54-58f4-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639056684;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bU1IOlukx2Li3M948d4Bb8tPyrGgtbqzjTe+77Ph5Uc=;
	b=PeFrQ6jbyXJ+x2vjoKSLZp9+yg0SZ5JIyxAV8Tz71XiEOJ/SWgEvGbxtcw9mTZz2WcrTCO
	qZHq9PU880I8UdyHFYAtP0mNG11/bCSlLl5dzHYLVSHzbZWlTFrMfscIqUOcO0Ye4M7rti
	Ec+hAKhNPcl6u/LQwf+HiiTc0vu6vZA=
X-MC-Unique: 3imMhHckP0qpmkoH16xDsg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FDvPk8e5Jm5YNOEk70+8xJoYbJKpRddShD+hLmPTi0cjlXEXLfRKTNhcp93ql2Bh/EfeUlMWRf0an5/KMy8VGsU8c4oMve/AxntPVcTK9WS11RYBKy34LY3OHvhfm5bAFYbxatUJOyPoHBj90NJGZjm3i+RF/4v15NLjV0foZLdSixXvU8nMealDjY+KH+DeWA3jH7twK6EmmWPrlWMOroX44nAK90l9XYlyyr026oDX8QwrUqyfLJnNE5UExPictjpYlBwGg7rAZ98xAcb7yqYwIL55qSBpCHDGpzz96K/O5KFVXcz959kmS2WofsBZzVbcMuBq7XV2arBdPbIM2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bU1IOlukx2Li3M948d4Bb8tPyrGgtbqzjTe+77Ph5Uc=;
 b=Qz9B0VTebjQ4wYWqRAleQ3H+4CeN5e5L+QwAMl2HxRRcwr5oxsqR5CbLU1O1+yTvQMe+H4LBjSkQflE+/H4z2ngKFGZfXsqAjBClLsu4NGJTFTEPrT70NVOkFTXDQTX9IElel3t+F7Kmo80/BwCddcQ17mLoeO7N/TI8dTh1aaATUB87r6fO+O2kybc5GgfL4CwP8lXMmaweg+0So4YcJHvcfUs+QRTSejAjenWYV8cqRQcsZokT6Ey2asN5lPZA1VE4U3Huoqtt2M+WrvuERlqhjrj73Db02ODslsqlMnG1nFUVwjG75R4ynZl9VXwAApT4VkGP8HV95HfZV5dDvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0129a25b-4563-1f54-5419-f1dde8680245@suse.com>
Date: Thu, 9 Dec 2021 14:31:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] tools/libs/ctrl: Save errno only once in *PRINTF() and
 *ERROR()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: anthony.perard@citrix.com, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209120939.513-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211209120939.513-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0196.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7ab2e171-3faf-47d1-b19b-08d9bb18304b
X-MS-TrafficTypeDiagnostic: VI1PR04MB6173:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61736B908FA53D8C1DD327D0B3709@VI1PR04MB6173.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LprxzIgD8Q1b4ekkmAldXlwp1TLkUNcAwwxNYYUZHjEX4u2O7gy4SzCQlKQ+OPtrIxYJknqQ4+4usSPA0w2Vp7lMqjM6y3hFshT6N3bCwj7Iigytm8pLwXuqmUJhmzYVRq4pYVC43r2C4L9fKq26P6KRvSH4z3BAWIBJ0HnjJ1ba1CUXa4xfqdX7jxsb7I9cgQ5X9KvVHUeHinODWMqHpzLtfR3hEMpMQZo5M1LJ2faWCcjyQyyhkNRmVXi1JKSdRsoi38cEKa3VKHgzYGYjwCBj6Aj3sGxAAM4DKbbED/FSXeWK9I7GN/POfk2cPank78rEd8yO/cxmrRs58y0ETrPZ15ONDae4CXcDrpOi4lUcQj9Tq6dqaU/BK8YKDrSe6lAvZaqrfpEOczWc+b0gsP2V0dXGdLi5xSH12JUzDG1zmxrkSzWjsWlKRO5f9PXyOqub2KsopHYdy4ci3ayVYPKAvDevax2n20+9TahZkfjAQrSBF0HgBnuVXVyPgTIblgepM8HTrU0zaz+LeCo/lzbL1FS8XRNWEvqRZXkzvcB0Nbza1qbhi7OkzyTJXP4wuUICSTmbpGDctuRpG1KyMe2PKZ5Tp17ZmgWKY7tC5jXh1eelomKB0KdCS0eZembM8WEq+w+AWKJJlmB79daQp/vFruzHozca0qyQ/99SjISlEdn00Rps5lu/XoaQHiSHRmaiM/K3qLV6rP7TCrcLwmFbej7+aeDWMYkIPUuW48E=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(31696002)(4326008)(2616005)(66946007)(66556008)(6636002)(508600001)(36756003)(26005)(186003)(956004)(66476007)(53546011)(31686004)(16576012)(5660300002)(6486002)(86362001)(8676002)(2906002)(38100700002)(316002)(8936002)(6862004)(37006003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXlKZng0NW9RN0MwaVNIY2xIb2ZzOUlzbFF3ai9DRFFSMmlzeUJjN09nTi9w?=
 =?utf-8?B?SU1BRkQxeFVmajdhWDkxVlpLcUQrMDZFZXl4K2l2L0JnQ0tWNlRkNDVTUEly?=
 =?utf-8?B?eHVZQm1DdlZTUHJCdVkzM1E3S1NySlJsSXZlT2IvbldDSEZOVDhpRFNWb2dh?=
 =?utf-8?B?bVp4ak0wY3EyS05SUVF6cHlMbGNYSWFNTno5NHg3L0ZCT1RpeGJlZVcxa3lw?=
 =?utf-8?B?YWVpMjRCZWY5RlFneTZDcEI0NGx5TjRPSFJJZmxJV0FzV3FzYjRqaWt3Z0s0?=
 =?utf-8?B?VXR3eWMwcWcxalB0UWM1b2Y1YUFsSWFEOHBrVUdUd05FMnFPYytUOERxYWN4?=
 =?utf-8?B?bC9LUllQaWgwaGMzRGo1Rit1bERGVXN6QnYvL05CcG1Uc1U3K1l1dHhUVmdT?=
 =?utf-8?B?VDZrQXRaa2FTQ3A2c25ZQVFlTytOVEkvRE13ejlrdXBVOHZWM1JJMHFlZ3NT?=
 =?utf-8?B?MWdvdkFUOTJsMmo4dkhQVzEvKy9MNnpRQllOQ2wzWnlDaVJNakNVL2VYaFV5?=
 =?utf-8?B?TjE1bUlEQ00wK1IwalpsNzZOTm9kdk1INzBlM0ZXTjQxaVd5Rnd1b3RXenBK?=
 =?utf-8?B?NlJUckdlTW9pQngrMUJ6eG05MDVOMVE3cUtyeXlsVmRDS25YaDZlNGZQRjZE?=
 =?utf-8?B?cDBFMnJiZ2lPVWdQKzZIYjhXRkJVaFdvQk5vZittK3BmY21QaW5lYUlwTWJC?=
 =?utf-8?B?NkZncy85MUlWOEk0QlZYRkxpSUZQanZSN1JTVklCd29IYnJlditEYUZiclRa?=
 =?utf-8?B?aGJpSVJaMDZvbysyRXdLM1FneTUwQzgzMjdWelJ5WEVGb2hZS2xRSDBBOEda?=
 =?utf-8?B?enN5dnhUd2hiM1JYa3FzSzVyM3V1RGFybmE1cTV6bThTM0FDdDVwblZkRjh1?=
 =?utf-8?B?Q3laTEt5eXNSdjhwaU84ZEEzU25WWTZMWGxJL2tuYlY2Y2lPVlR3eWlvK1lB?=
 =?utf-8?B?YzRTL3RqVzRxVmlZRGRzZ09uK0tKcWVadTN2RUtPVmh5cGYvUWpUdXlpMHFK?=
 =?utf-8?B?Q2ZWZDRMU0NBdk9uQmFnYUZmdlJCK1NNUTdhNm44N0t4eERBZ0x4Ui9RMCtK?=
 =?utf-8?B?YTEwYnlSQzhDQytIRldhOFNucWNzd3pES0dCQ1dFYmxFZ1hZditzZ29BRkM4?=
 =?utf-8?B?dWJxNDJNOUJtN0VsMFVLNHlra1VaVklqbWtJb0Uya0lndUhIRDlFSU11RlNo?=
 =?utf-8?B?akdhQk5hWkY0U09GMDlaZmJWckgvTVlIN0ExTTA5cjBkc2VhRStJWDIrazFp?=
 =?utf-8?B?UG5KTnZZMnloUzJldzdSTWRxc0JROFkwOXZsMFVoMmpDSVhqYU9RYlFIU2R4?=
 =?utf-8?B?dU1TekEza0NDN040OWdtTExOYmVWOE13aW9LcHB5MCtJVmthUytiU2ZGcHFw?=
 =?utf-8?B?b2VWc2pXV2NJNzN1Y0QyZVpwam9LYkRERmNaNjNlckZhNDZBQ25ESHROblph?=
 =?utf-8?B?T1A2L3FSS3Q1a1NPaTI0M2EwSllJczAyVVM1TzlXN3RzSFRONVNZeXZXZ2Z0?=
 =?utf-8?B?TmdkS0tEeThaTVhaQXpOa1Urd3ZKV2VsSDNZQWtYQTJxS2p0MmNKTTJFZ1FH?=
 =?utf-8?B?WHZMbVF5YnN0bXRiT29NM25sclkzYUMxVmFDTG44VnJZa1dPNTdBUDFDbXNR?=
 =?utf-8?B?d3h1QjZOczM2ZHUwYTByNnZxcEQ2WENVandtWEJPZ3llVGVRcGVxZHNaUjFr?=
 =?utf-8?B?VGROVlhWYVRWU21RakpjMHlwTzBNcTNRaFhNVUc4cCtjSWxFWFhmQjJheEhv?=
 =?utf-8?B?WWRiRTV6eEVMVUh1cnFSbHA4emQydG9BNjcveUtwaFFZcHdBS3lucEZhUldu?=
 =?utf-8?B?L3hFTTg1a011OUg3QXY5c3E1RHZCcGVqWEo5WlRtYUxON2s4Q0JacC91b2Ur?=
 =?utf-8?B?M3g0Rytza2VpTlp0eG8xcjU4aU1ZTnVzOWJzaTBOdm9kRlpvekUreUdVMExV?=
 =?utf-8?B?b0hRRlgzNGk2VGo3clVDUDBlbDZkaC8raXpZR3ZXTFM4aG1EWFk2aFRLVWls?=
 =?utf-8?B?QzlIbWYrS3kwb3dhL21WVksvMWxpaEJkZ09KZ3kwWngycDNSQVREbjZoZHdS?=
 =?utf-8?B?dHNiTGpMS3FRc01xZDVuODk0dGo3bmtXaEx3UFZCYjRwNUt1NHpBL3VaeG92?=
 =?utf-8?B?SGVqTWdUU2xHamRpVWRYeFRHeERnWFlzcG96RXdsbmM4Z0xGdWtLallZemNC?=
 =?utf-8?Q?ZBY0XTRSBNzXNYQUYlWb7CE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ab2e171-3faf-47d1-b19b-08d9bb18304b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 13:31:21.5810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AWVXtVfdoG5KDIQfK+UgkD2/CdycSxY/OeAY6VZisXqb1DUZjyLYoFusuRt16355D7cP/ZO4VLmu8qg1ZGTOFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6173

On 09.12.2021 13:09, Juergen Gross wrote:
> All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
> saving and restoring errno in order to not modify it. There is no need
> to save and restore in those macros, too.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
Albeit ...

> --- a/tools/libs/ctrl/xc_private.h
> +++ b/tools/libs/ctrl/xc_private.h
> @@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
>  
>  /* anamorphic macros:  struct xc_interface *xch  must be in scope */
>  
> -#define IPRINTF(_f, _a...)  do { int IPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \
> -        errno = IPRINTF_errno; \
> -        } while (0)
> -#define DPRINTF(_f, _a...) do { int DPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a); \
> -        errno = DPRINTF_errno; \
> -        } while (0)
> -#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); \
> -        errno = DBGPRINTF_errno; \
> -        } while (0)
> -
> -#define ERROR(_m, _a...)  do { int ERROR_errno = errno; \
> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
> -        errno = ERROR_errno; \
> -        } while (0)
> -#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
> +#define IPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a)
> +#define DPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a)
> +#define DBGPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a)
> +
> +#define ERROR(_m, _a...) \
> +        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a )
> +#define PERROR(_m, _a...) \
>          xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
> -        ## _a , errno, xc_strerror(xch, errno)); \
> -        errno = PERROR_errno; \
> -        } while (0)
> +                        ## _a , errno, xc_strerror(xch, errno))

... while I realize you only stripped only semicolons and line
continuations, but I would find it quite desirable to also get the
use of blanks straightened at this occasion: In a number of cases
commas aren't followed by blanks and (instead?) sometimes are
preceded by ones. It doesn't seem very likely to me that this
would be intentional.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:32:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:32:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243048.420334 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJXN-0007kZ-Q1; Thu, 09 Dec 2021 13:32:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243048.420334; Thu, 09 Dec 2021 13:32:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJXN-0007kS-Lu; Thu, 09 Dec 2021 13:32:41 +0000
Received: by outflank-mailman (input) for mailman id 243048;
 Thu, 09 Dec 2021 13:32:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvJXM-0007kE-6H
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:32:40 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7a51fbcb-58f4-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 14:32:39 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A7DC5210FD;
 Thu,  9 Dec 2021 13:32:38 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B6B713343;
 Thu,  9 Dec 2021 13:32:38 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id S/WoHHYFsmFjBgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 13:32:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a51fbcb-58f4-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639056758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/PCx5clS83OumSRjV1iCy770FqT+zzftFolon9W6aPg=;
	b=gUVlEEAcByoMornVJfqypqFb5dFjkG7nqqcVV7gN/DBGsJ9LcpxldzyRnKHGFvGPuFr25E
	LZp4/LY3JGdJ4juZI3jpQNHjlgllzJIBrslNmVTJHTCo66k/YeVyEOiwbqowg+Ld9Davsu
	yOLRWNHbDffpERndomd0jRIVp4C0qoc=
Subject: Re: [PATCH] tools/libs/ctrl: Save errno only once in *PRINTF() and
 *ERROR()
To: Jan Beulich <jbeulich@suse.com>
Cc: anthony.perard@citrix.com, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209120939.513-1-jgross@suse.com>
 <0129a25b-4563-1f54-5419-f1dde8680245@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <2e3ca440-200c-69e4-d74b-63e5a865f719@suse.com>
Date: Thu, 9 Dec 2021 14:32:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <0129a25b-4563-1f54-5419-f1dde8680245@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="nSCjXOA1L5Iy9rl3YG1z0D3jQIErsNwgg"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nSCjXOA1L5Iy9rl3YG1z0D3jQIErsNwgg
Content-Type: multipart/mixed; boundary="mZrHutFNvJ29tZYzhAVAeaa32rzXwGNY1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: anthony.perard@citrix.com, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Message-ID: <2e3ca440-200c-69e4-d74b-63e5a865f719@suse.com>
Subject: Re: [PATCH] tools/libs/ctrl: Save errno only once in *PRINTF() and
 *ERROR()
References: <20211209120939.513-1-jgross@suse.com>
 <0129a25b-4563-1f54-5419-f1dde8680245@suse.com>
In-Reply-To: <0129a25b-4563-1f54-5419-f1dde8680245@suse.com>

--mZrHutFNvJ29tZYzhAVAeaa32rzXwGNY1
Content-Type: multipart/mixed;
 boundary="------------96BD223ADCC756DA92601777"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------96BD223ADCC756DA92601777
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 14:31, Jan Beulich wrote:
> On 09.12.2021 13:09, Juergen Gross wrote:
>> All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
>> saving and restoring errno in order to not modify it. There is no need=

>> to save and restore in those macros, too.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> Albeit ...
>=20
>> --- a/tools/libs/ctrl/xc_private.h
>> +++ b/tools/libs/ctrl/xc_private.h
>> @@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
>>  =20
>>   /* anamorphic macros:  struct xc_interface *xch  must be in scope */=

>>  =20
>> -#define IPRINTF(_f, _a...)  do { int IPRINTF_errno =3D errno; \
>> -        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \=

>> -        errno =3D IPRINTF_errno; \
>> -        } while (0)
>> -#define DPRINTF(_f, _a...) do { int DPRINTF_errno =3D errno; \
>> -        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a);=
 \
>> -        errno =3D DPRINTF_errno; \
>> -        } while (0)
>> -#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno =3D errno; \
>> -        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); =
\
>> -        errno =3D DBGPRINTF_errno; \
>> -        } while (0)
>> -
>> -#define ERROR(_m, _a...)  do { int ERROR_errno =3D errno; \
>> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
>> -        errno =3D ERROR_errno; \
>> -        } while (0)
>> -#define PERROR(_m, _a...) do { int PERROR_errno =3D errno; \
>> +#define IPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a)
>> +#define DPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a)
>> +#define DBGPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a)
>> +
>> +#define ERROR(_m, _a...) \
>> +        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a )
>> +#define PERROR(_m, _a...) \
>>           xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d =3D %s)", \
>> -        ## _a , errno, xc_strerror(xch, errno)); \
>> -        errno =3D PERROR_errno; \
>> -        } while (0)
>> +                        ## _a , errno, xc_strerror(xch, errno))
>=20
> ... while I realize you only stripped only semicolons and line
> continuations, but I would find it quite desirable to also get the
> use of blanks straightened at this occasion: In a number of cases
> commas aren't followed by blanks and (instead?) sometimes are
> preceded by ones. It doesn't seem very likely to me that this
> would be intentional.

Let me resend it with proper style corrections.


Juergen

--------------96BD223ADCC756DA92601777
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------96BD223ADCC756DA92601777--

--mZrHutFNvJ29tZYzhAVAeaa32rzXwGNY1--

--nSCjXOA1L5Iy9rl3YG1z0D3jQIErsNwgg
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGyBXUFAwAAAAAACgkQsN6d1ii/Ey/J
Zgf/aBQjocylAbk18PybAQfZ1OpTFPPqxAMkUC9Cfzw7+0jSuTO2WbA4k1qWBGQByOiClDpB/Bqg
z2K8iFkzNSiD8mmTQvsRNHyg41r3QIL9Nep9Dwv8kERjTp021bniZ+Ptf/HHCDdb4y8ybfvjGvtC
pLyk3l6Eps5fpRPZki9IbwcSjYU5tEcCmpciNzQhdEdbjLRA2XhgFoszAfLF7piURGpEXWxcrsl0
UQru1WDDneq2Ze5G8rpl23vgRv6K1Tnozk3PSoOhoH5tfyWTsoftxtwinylkVxQDmImVs46TqzCG
aTHvqZYsTfV0Q/jl5VYytFjtpFTUHS4VVpUyyTeMaA==
=Gctz
-----END PGP SIGNATURE-----

--nSCjXOA1L5Iy9rl3YG1z0D3jQIErsNwgg--


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:34:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:34:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243054.420344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJYj-0008N7-41; Thu, 09 Dec 2021 13:34:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243054.420344; Thu, 09 Dec 2021 13:34:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJYj-0008Mx-12; Thu, 09 Dec 2021 13:34:05 +0000
Received: by outflank-mailman (input) for mailman id 243054;
 Thu, 09 Dec 2021 13:34:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=yJm+=Q2=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1mvJYh-0008Mn-Om
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:34:03 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ac48eff4-58f4-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 14:34:02 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id m12so9016311ljj.6
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 05:34:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac48eff4-58f4-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=O76rkSWVYvT8dqcbYxWXkft11qCzS7vPXfRaeYRgH0o=;
        b=bJuHVu9gaL1Se+1rc82qxSY2NdZFatzJz8gU2uFX1OadNXVJklcPd8TgGPpwCCt/YB
         /v+JfOGdmhpuBefn6kcEyBUBuLrMD3KLU1ITiDHnQXOFQsqwLwGKE07TOCPK+MLx7LyZ
         6dPeUw9yP5bZsXJO4wgqeBByRUIJOoiH52gWnAGXaINrswYjHVLnLwy2ujXpB/qsBPfU
         KBzn95a5ILxWhNCgk+gHt6FQzUCAcEHhSjWO84OgycakLU28tlncD7SkjcDOTkKPbMvi
         zQk14DdGAgAoF9i2uDXptOciQRLibPAbkhY7sFORHpbOm+74BBIE1gFO00wdLFMiIMVq
         hbuw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=O76rkSWVYvT8dqcbYxWXkft11qCzS7vPXfRaeYRgH0o=;
        b=wB3cQPc0yz4AQDD3CZdJWIbapJEb++Z0TzZTl2eUZ5sdawloJNTOqSEDPaO0PhvACN
         oExZc1ClWFdwtN3WnJAR7bKt/t9IWXAsX1Qe6a7G2roqbyCxZhA9UQDQEvH4geYf11ic
         gOc3lOYkeZ7XZXNGLR9P4gisyqar6LDqCdtiExgaV364KND/6+G0tySvrf55ucZZSVXO
         DVH1IYj9N8zPbChtrLFoc7agVBxpQW+yEv9T5H/QoydzjZWeeJsL2r/ErMPZlNV/tQQv
         mZ+TnkMnoTnhpfFL7hXV+lW//g4BjmfWcpfg/XuBgxZxY4CZSMthhi145gKdDsPZ/LrF
         T9Mg==
X-Gm-Message-State: AOAM532AXW0xiO4Ly7pC3+ZFf3VlOkniZF3mSjfxIKKUU2PlVLo8LWNP
	rtAZdVn01pYEdOYU7afEfD/PBgC/YluGyj5aCoE=
X-Google-Smtp-Source: ABdhPJw2Q7UAC7Bybn7lBMlFi19V0gfRtH0qpSwt/WHhNNsoeYTz28c+PsXzif51RGDPVX41lB64B2ZPlhPRQNqP74I=
X-Received: by 2002:a2e:b177:: with SMTP id a23mr6238821ljm.168.1639056842424;
 Thu, 09 Dec 2021 05:34:02 -0800 (PST)
MIME-Version: 1.0
References: <d82be159-c4a4-73a7-9fb5-2128b6925e3d@suse.com>
 <CAKf6xpuDwV5nv9c3CX+Lo4e+dM=Uo=iv1nmeNtQNObfgD_wChg@mail.gmail.com> <fff78341-1e35-f245-e1ce-47f0fec9b86b@gmail.com>
In-Reply-To: <fff78341-1e35-f245-e1ce-47f0fec9b86b@gmail.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Thu, 9 Dec 2021 08:33:50 -0500
Message-ID: <CAKf6xpvoB3fxM-gCcaXeY3vdMNYF5uV+nZUOFUQ+=KZ_59UV=Q@mail.gmail.com>
Subject: Re: attaching device to PV guest broken by your rework of libxl's PCI handling?
To: Paul Durrant <paul@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
	Anthony Perard <anthony.perard@citrix.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, Dec 9, 2021 at 8:08 AM Durrant, Paul <xadimgnik@gmail.com> wrote:
>
> On 09/12/2021 04:58, Jason Andryuk wrote:
> >
> > My attempt at a fix was this:
> > https://lore.kernel.org/xen-devel/20210812005700.3159-1-jandryuk@gmail.com/
> >
> > It was in terms of PCI & stubdom startup , but that is the same as PV
> > hotplug.  There were questions about further re-work which went
> > unanswered, but my patch at least restores the old working state.
> >
>
> I guess the question is do we need to wait for 'connected' in any case
> other than initial creation?

It's the other way around.  When running (not initial creation -
!starting) and there are already entries (num_devs != NULL), we have
to wait for Connected to avoid interfering with Reconfiguring.

Regards,
Jason


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:41:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:41:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243063.420356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJfO-0001tp-Tq; Thu, 09 Dec 2021 13:40:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243063.420356; Thu, 09 Dec 2021 13:40:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJfO-0001ti-Qe; Thu, 09 Dec 2021 13:40:58 +0000
Received: by outflank-mailman (input) for mailman id 243063;
 Thu, 09 Dec 2021 13:40:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3cQP=Q2=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvJfN-0001tc-O5
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:40:57 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2fccbab-58f5-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 14:40:56 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 51D48210FD;
 Thu,  9 Dec 2021 13:40:56 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 26F0F13343;
 Thu,  9 Dec 2021 13:40:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id j09WCGgHsmGyCgAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 09 Dec 2021 13:40:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2fccbab-58f5-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639057256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=YbZDTmvbJsDpQkhk6H8P3268LVh9Xsxbf1w5AhlmObI=;
	b=r+O/hDnR13U0QNwkyS5QRiAYTes+U4BEY78Ve115nBV/9l1NutUHd1QAFKZEnSSCtZvhcU
	y4qHRezYlRDhx9VEhPFBtu2XlBtXOVSlui9TjXonuDPEg5PTJzNkukkwHMfYHFn1nn/7ZI
	vS99sYwla0P+/5KAuLjwf9bychgefNU=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: anthony.perard@citrix.com,
	Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] tools/libs/ctrl: Save errno only once in *PRINTF() and *ERROR()
Date: Thu,  9 Dec 2021 14:40:54 +0100
Message-Id: <20211209134054.20757-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
saving and restoring errno in order to not modify it. There is no need
to save and restore in those macros, too.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
---
V2:
- style corrections (Jan Beulich)
---
 tools/libs/ctrl/xc_private.h | 34 ++++++++++++----------------------
 1 file changed, 12 insertions(+), 22 deletions(-)

diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h
index 2e483590e6..abac9072a0 100644
--- a/tools/libs/ctrl/xc_private.h
+++ b/tools/libs/ctrl/xc_private.h
@@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
 
 /* anamorphic macros:  struct xc_interface *xch  must be in scope */
 
-#define IPRINTF(_f, _a...)  do { int IPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \
-        errno = IPRINTF_errno; \
-        } while (0)
-#define DPRINTF(_f, _a...) do { int DPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a); \
-        errno = DPRINTF_errno; \
-        } while (0)
-#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno = errno; \
-        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); \
-        errno = DBGPRINTF_errno; \
-        } while (0)
-
-#define ERROR(_m, _a...)  do { int ERROR_errno = errno; \
-        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
-        errno = ERROR_errno; \
-        } while (0)
-#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
-        xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
-        ## _a , errno, xc_strerror(xch, errno)); \
-        errno = PERROR_errno; \
-        } while (0)
+#define IPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_INFO, 0, _f, ## _a)
+#define DPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_DETAIL, 0, _f, ## _a)
+#define DBGPRINTF(_f, _a...) \
+        xc_report(xch, xch->error_handler, XTL_DEBUG, 0, _f, ## _a)
+
+#define ERROR(_m, _a...) \
+        xc_report_error(xch, XC_INTERNAL_ERROR, _m, ## _a )
+#define PERROR(_m, _a...) \
+        xc_report_error(xch, XC_INTERNAL_ERROR, _m " (%d = %s)", \
+                        ## _a, errno, xc_strerror(xch, errno))
 
 /*
  * HYPERCALL ARGUMENT BUFFERS
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 13:58:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 13:58:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243069.420366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJwE-0004UA-CI; Thu, 09 Dec 2021 13:58:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243069.420366; Thu, 09 Dec 2021 13:58:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJwE-0004U3-9D; Thu, 09 Dec 2021 13:58:22 +0000
Received: by outflank-mailman (input) for mailman id 243069;
 Thu, 09 Dec 2021 13:58:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvJwC-0004Tx-Vo
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 13:58:20 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvJwB-0002Jt-Pw; Thu, 09 Dec 2021 13:58:19 +0000
Received: from [54.239.6.187] (helo=[192.168.16.79])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvJwB-0000Yb-K0; Thu, 09 Dec 2021 13:58:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jUnuTu7eW3DUwd/XVt79ktjFQBNoQs0RQVL+3L+1F4w=; b=zZjKQKT4wReX25W8kX1CKUVK2G
	sQgRP319HiNFQTc/VaD88+xsYHR2siBphNZ2ttc8nNu3cxPza/l2qg54V6+FYi8mzxgOED3GsKXvx
	KXOQFHRQy5G6weH9CQGznAgmeFzCPYadkI/qeDiWRLY8rzzXEUnHHpf/AuUt4faaWupE=;
Message-ID: <6beb8e27-44ab-3b0b-2a88-7da86a0e99ef@xen.org>
Date: Thu, 9 Dec 2021 13:58:18 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Xen on LFS
To: Sai Kiran Kumar Reddy <skiran@cimware.in>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org
References: <CAAQMfLr_mWgdM3v=smYZbx+t8zhCP7_aCecDPJLLGRu=MH9E0A@mail.gmail.com>
 <e421fc4b-afde-8bdc-9be0-859523512b9b@suse.com>
 <CAAQMfLrxpc=6L_mp_EuPq-B+EydrFGaVqb_MiyjELPQYXi0e=g@mail.gmail.com>
 <CAAQMfLrv_nL_w-VbjSypnY1Ptbe-K_Gq71ovVf5o1nDqwM9cgg@mail.gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <CAAQMfLrv_nL_w-VbjSypnY1Ptbe-K_Gq71ovVf5o1nDqwM9cgg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 08/12/2021 05:22, Sai Kiran Kumar Reddy wrote:
> Hi,

Hi,

> I have posted my query in xen-users mailing list one week ago. I was not 
> able to get any response from the community. Could you please look into 
> it and help me out here? I am trying to install xen(from source code), 
> on LInux from Scratch build system. I just want to know the list of xorg 
> packages, to be installed for Xen.

You might want to check your spam box as there were a few answers to the 
thread ([1], [2]).

Cheers,

[1] 
https://lists.xenproject.org/archives/html/xen-users/2021-12/msg00003.html
[2] 
https://lists.xenproject.org/archives/html/xen-users/2021-12/msg00003.html

> 
> Thanks in advance for your time and support.
> 
> Regards,
> Sai Kiran.
> 
> On Tue, Nov 30, 2021 at 12:58 PM Sai Kiran Kumar Reddy 
> <skiran@cimware.in <mailto:skiran@cimware.in>> wrote:
> 
>     Ok, thanks for the reply. Will do that.
> 
>     On Tue, Nov 30, 2021 at 12:52 PM Jan Beulich <jbeulich@suse.com
>     <mailto:jbeulich@suse.com>> wrote:
> 
>         On 30.11.2021 07:50, Sai Kiran Kumar Reddy wrote:
>          > I am Sai Kiran. I am currently working on installing xen on
>         Linux From
>          > Scratch(LFS) system. One of the dependencies of xen is "xorg"
>         package. This
>          > package is present in Beyond
>          > <https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html
>         <https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html>>
>         Linux From
>          > Scratch(BLFS)
>         <https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html
>         <https://www.linuxfromscratch.org/blfs/view/svn/x/xorg7.html>>
>          > manual. But, there are a lot of packages to be installed. I
>         am not sure if
>          > all these packages are required for Xen. Also, is xorg a
>         must, to build and
>          > install xen?
>          >
>          > Kindly help me out here. Thanks in advance, for the support.
> 
>         Thanks for your interest, but I'm afraid your question isn't
>         fitting xen-devel.
>         Please raise it on xen-users.
> 
>         Jan
> 

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 14:00:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 14:00:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243075.420377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJy2-0005uA-Ox; Thu, 09 Dec 2021 14:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243075.420377; Thu, 09 Dec 2021 14:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvJy2-0005u3-Lu; Thu, 09 Dec 2021 14:00:14 +0000
Received: by outflank-mailman (input) for mailman id 243075;
 Thu, 09 Dec 2021 14:00:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJy0-0005tt-LW; Thu, 09 Dec 2021 14:00:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJxz-0002Rv-Iy; Thu, 09 Dec 2021 14:00:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJxz-00027c-9e; Thu, 09 Dec 2021 14:00:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvJxz-0008Kb-9A; Thu, 09 Dec 2021 14:00:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PmUSq9HbpDOylhUAEB4ogbnDMcG1rjwXpTpVLUt4VOA=; b=gL2h1CERMEEhKtE0v0UctjL1WS
	dnE7rxN+t39JpwnGkWAWCk6DaHYBnvUWeb8LhfBmUwGyHd/+zvZoeocvchC2JZiVam7WgbitmfG9L
	uttUY7JnY8kHwm1EBZ+bMENRkkMAf1zbzPmq8lvDclTaF14WHMmbhd/ejagqijkiOycc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167258-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167258: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 14:00:11 +0000

flight 167258 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167258/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 14:27:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 14:27:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243090.420404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKOA-0001YZ-BH; Thu, 09 Dec 2021 14:27:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243090.420404; Thu, 09 Dec 2021 14:27:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKOA-0001YS-8I; Thu, 09 Dec 2021 14:27:14 +0000
Received: by outflank-mailman (input) for mailman id 243090;
 Thu, 09 Dec 2021 14:27:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mvKO9-0001YM-CM
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 14:27:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mvKO9-0002ts-AV
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 14:27:13 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mvKO9-0002uA-9N
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 14:27:13 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mvKNj-0004px-MZ; Thu, 09 Dec 2021 14:26:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:
	Message-Id:Date:Subject:Cc:To:From;
	bh=7H/vJlCkyRKlmrzk69NkyyOL/b3gdIPsGGusOthjk3E=; b=Xp/S78I75Mke21soVCLWjw9tHq
	eeZGqssot5xwSltVNxA5h1Z5X6tyFY08Gy1d9drNk8fsm0SRnxr5XOF/80JyMaZtPq83Yjkscc/ym
	zcoTRWlzqP+XtUQOmPGDSSGH8jHnAJTDgLJpaJuyLfEnjLBo05yGlxw3vg0e/fjO5hIY=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: iwj@xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] SUPPORT.md, MAINTAINERS: De-support qemu-xen-traditional
Date: Thu,  9 Dec 2021 14:26:40 +0000
Message-Id: <20211209142640.24437-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In 4.16 we changed to not build this by default.  I think it is now
time to explicitly desupport it, completely, in favour of Linux dm
stub domains.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 MAINTAINERS |  2 +-
 SUPPORT.md  | 18 +++++++++---------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e43dc0edce..933579541f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -455,7 +455,7 @@ S:	Supported
 F:	tools/python
 
 QEMU-DM
-S:	Supported
+S:	Obsolete
 T:	git https://xenbits.xenproject.org/git-http/qemu-xen-traditional.git
 
 QEMU UPSTREAM
diff --git a/SUPPORT.md b/SUPPORT.md
index 3a34933c89..b64ebee93b 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -802,17 +802,17 @@ See the section **Blkback** for image formats supported by QEMU.
 ### qemu-xen-traditional ###
 
 The Xen Project provides an old version of qemu with modifications
-which enable use as a device model stub domain.  The old version is
-normally selected by default only in a stub dm configuration, but it
-can be requested explicitly in other configurations, for example in
-`xl` with `device_model_version="QEMU_XEN_TRADITIONAL"`.
+which enable use as a device model stub domain.  This old version is
+not built by default.  Even if it is build, it is normally selected by
+default only in a stub dm configuration, but it can be requested
+explicitly in other configurations, for example in `xl` with
+`device_model_version="QEMU_XEN_TRADITIONAL"`.
 
-    Status, Device Model Stub Domains: Supported, with caveats
-    Status, as host process device model: No security support, not recommended
+When device model stub domains are desired for the additional
+security, we recommend using a device model stub domain consisting of
+a modern qemu and a Linux kernel.
 
-qemu-xen-traditional is security supported only for those available
-devices which are supported for mainstream QEMU (see above), with
-trusted driver domains (see Device Model Stub Domains).
+    Status: Obsolete
 
 ## Virtual Firmware
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 14:35:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 14:35:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243095.420415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKVX-0002yI-4L; Thu, 09 Dec 2021 14:34:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243095.420415; Thu, 09 Dec 2021 14:34:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKVX-0002yB-12; Thu, 09 Dec 2021 14:34:51 +0000
Received: by outflank-mailman (input) for mailman id 243095;
 Thu, 09 Dec 2021 14:34:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvKVV-0002y1-1N; Thu, 09 Dec 2021 14:34:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvKVU-00031O-TW; Thu, 09 Dec 2021 14:34:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvKVU-00042j-LR; Thu, 09 Dec 2021 14:34:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvKVU-00049y-L0; Thu, 09 Dec 2021 14:34:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DYZ5iLgXQLhwskZC7FBcjL65D+FybPyO5sTTJlAqQcE=; b=JFb9oQT8b+Qmjts7b2BrnQD2cJ
	coTAjhsGPut5v4bpVLEp+hugc2S0duBT27IgZ9kZ08ad9nlr0icMDhBLxAh11wxqhwBCfDEnpf+8p
	0Z7bv4hdubYCaGfSmlLzNHHkxyjGfQ5nE8MUU0Iyv7AogrIoJUOnNeIxdEDhYQZm9oyk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167260-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167260: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 14:34:48 +0000

flight 167260 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167260/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 14:51:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 14:51:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243102.420429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKl1-0006Hn-IK; Thu, 09 Dec 2021 14:50:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243102.420429; Thu, 09 Dec 2021 14:50:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKl1-0006Hg-F0; Thu, 09 Dec 2021 14:50:51 +0000
Received: by outflank-mailman (input) for mailman id 243102;
 Thu, 09 Dec 2021 14:50:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvKl0-0006Ha-1V
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 14:50:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6544c76f-58ff-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 15:50:48 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-CffE9WTwOmaK9Uk9yCpKuA-1; Thu, 09 Dec 2021 15:50:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4944.eurprd04.prod.outlook.com (2603:10a6:803:60::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 14:50:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 14:50:44 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9P194CA0028.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::18) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.16 via Frontend Transport; Thu, 9 Dec 2021 14:50:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6544c76f-58ff-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639061448;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0d1plSlWFWoRUgH6Y3v4RbPTTXNogkUNcjowDv6cRhE=;
	b=Jxny0q4tc3EFlmmR/e3chkwer3qrqpTRlwjSa+VqoItXXDF11T96uYt0hREOrah7OnSS10
	/WGKAym7gmStbCGHtfc4llkPeoaD1R41LJdK7elpdgevlLM+mJiXjq/WLr7fvxUBEiW0qw
	tvsg73Rf9Mvn2XwIqt+KTukee0RhuSU=
X-MC-Unique: CffE9WTwOmaK9Uk9yCpKuA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TJjXC/Sxv6lF35B7dI2Q4k9fyCD1jUPOuDcXyw4aqB+s0l5UdEQB6MTS5EDU6m6zFu+YROazBijKSV6KnXlsDQyCxffGGwqbMhQGmYgUWRcOhVRIHz2DDFIJ2cAN7E/i5pdYyHofaO7mEwD93F2FtgRGHjjcKnd/KjqJ0PnmtJBZsZfQdrKAIwufP2q9ruQSPQmtn75yZDMWUt1aGBw8DD5N70wNIcADavgRIFLagGHc90lbXH4Qt0jWzuWUXS64r+5XwVyYGcJHW7CULt4YPdEnljy8XI5NV4Tw20qTSPVGHQa+A28QVQZ1GDudkxWb005hztC9DhJtsIx7ue6okA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0d1plSlWFWoRUgH6Y3v4RbPTTXNogkUNcjowDv6cRhE=;
 b=jIlGuM7V1n6Jo4wk0qLbm+GcUd2nCANC/HdV0eBmdPYBV4OsdcqbwswSpzMMo89/Lt6X6J7jiOcYXaHm4uDp26xq9SVIQkWfumLAmRofmxd3mi7PRAbwUNBLMRTGgo3mJhhk3KY0gRcS8ponKLkhOJQk9qzMkZwZwSNMlquraRTQEC5azNE/uX+t62cayc4WlnPVhZXGuN9ukLHaUPmx1ZTPp3nzdg+VEjaXJHsM8VV8bqfWET4o9o/ZDRKttFbk+XSDQW8Lui5OCSYRSLsRJZ9ekWdvER1mvOFnzVXTgmxqialPwK5p0nIz91RyEPgNom3GmnaLUMJ8hSCb+eyGSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a098fcae-7aaf-b5fc-79fe-acf9922e2cdb@suse.com>
Date: Thu, 9 Dec 2021 15:50:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] tools/libs/ctrl: Save errno only once in *PRINTF() and
 *ERROR()
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: anthony.perard@citrix.com, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209134054.20757-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211209134054.20757-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9P194CA0028.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:20b:46d::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af58e1cf-94b3-416a-b5fa-08d9bb2346fe
X-MS-TrafficTypeDiagnostic: VI1PR04MB4944:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB494429FE5778295DB74B9E55B3709@VI1PR04MB4944.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VUYq7SzOKt9MWhMbwSalr800vxc8nGu2ZtzBrwgU6dRqUmWpSy58a1j7lGTQd9ywKsP1IdjeYoTbbx4IRe5gUcWSXZHRoFgEUoBymJlLr9j4BUW4BaT3dluIEPqokuKCi3wY8eH3cDuNfERC0ImzYK8nToST3CGboneZrpEuuak6eFp1ZB8BJzZsyKfpSGLZ73ugGQZJmN58rQlsFGRvN9r0gv9B8jVbpeycwEPEp6x+ELlW+sU1owA1KA/LqmSbYGbg4C1zv5Wlfo9F5uHttBcp+v0CKUHtMvKyEg4tPeri4RxwioGm+6ilqnznco60tovLEHiV7HtuAhyxj+u7bUjIXAl7GL9EG4FPiFpbXCrv6eOXZNzLHH7NAHyhW9w5zi8FtqLIZs+Vd7Vvt/UomGURpcI+khelH4HiinOy89eGffP+eVs0TsWr6XrqA5xXSG/VLlWPJXIA48JiJWCvYQ+8wt3AK1sIAZHl8SusaCVspE7IGx7BoW4vVeHk2mOKtUtlzuW6mPYW6p17QTNaV0XiojvHTRUUXkMM/zSKFNH5bwuJbQjW8d8O7j0qab4HyexA7DugffnoyRIo+1sYG+IXwF7mJJ7FZQmjaKDm2lYeKfND/7R9lOt1uKMlQPH+HT/bpmHcqfDRJFz7XB3Ijo9e9gN+Za9O/VO45YL86bOjRLiCJQbUVdXgUISavqaiCnZY0WFXQnX5sz+7ZGOh0j0vkJ12v7inArxth2MwpNU=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(53546011)(2906002)(6486002)(31686004)(26005)(36756003)(8676002)(6862004)(31696002)(8936002)(37006003)(6636002)(316002)(16576012)(508600001)(5660300002)(2616005)(66946007)(66476007)(66556008)(86362001)(956004)(83380400001)(4326008)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eXIzM0Nrckx0TEpsUk5jd3k3eTlHdUZMa3dYQkJZS1YvRTJGd1h6dklhdUxk?=
 =?utf-8?B?SldlZ2tDU1lVSmVEdXRhVXFhZTJ3azJlQXkzWFBrQm9MSmVjak9wR0NtOVZp?=
 =?utf-8?B?S2dZYUp4MEhScU5zbkRBenc3N1hWZ0Z2YnYwV2hmekgxNGZBREJHSDR2ZFVS?=
 =?utf-8?B?QjBkZG9uVGhqcmNEQ2xldmdSalBsdURyeGM1NmxDcUlLbGtPWGhWUFBhNWVI?=
 =?utf-8?B?T3BtM0d2TGpuUGQyWW03RkorQVgzaUI4TGNGV1UwdTQxS0RwdmMwams4Tmp4?=
 =?utf-8?B?bGc2R1lIMGJPSEU5aWxDaTZLREU2UkhHNUIvSUpWRENnRVJHT0M2WFNiWXM2?=
 =?utf-8?B?UU52SGY1MEVFNG1hZEFxWDFXRWc0UjlYZUhBUGZSTDViRHRJYlBQbGtwN2lN?=
 =?utf-8?B?VVN3YWxXekE3SDFud0thUWhzWWtzbUp2UTBuMkdoem5UVHdFUUQwcUovNWRa?=
 =?utf-8?B?b2Rtc1o3WEowN1BzY1pBMGJQdzB5cU9hakNzUTYzOFJESy83dmpldS8vZjZo?=
 =?utf-8?B?eHhJdWIxSmtFeU5jelR4aGxaQ3hSWksxL0YweDVjZWFjdUNBdHZGZG1TYzF6?=
 =?utf-8?B?L0ZZZWo5NnZWc240RjJxaTJwV0NJdWpTVFdac0ZNUXFOZ2ZEUlJKdk4zQ0xT?=
 =?utf-8?B?Q3Nnd0QraVg0V1RSenNpS25aeWVsYmFVZDhxT013U1g1YnZQTXVLTDM3eFly?=
 =?utf-8?B?Z0p5UzFHSTVWb2xVMTllWm1SeU1TSUtqcktoUlFUNENkOWFVTGNhMExlSWtk?=
 =?utf-8?B?RHZmUWhQQmt4WmNUdTlsTUNzNGZidExvTHk1VnhBc3RFN2lCZ0pwbDBGeTd5?=
 =?utf-8?B?QzA3aTNhNkpLNFVZc1RKRm9TakxVTU14bi95R2dROEpMellaRTA2c1F1eWFS?=
 =?utf-8?B?YWNVY3BLaXRBWksyVzZJR0VOc1hhQWNrWkxzVW5FSWZLbDVQdFNiT3BRcXB5?=
 =?utf-8?B?WFN4bDlsbHFvdElSNEVaRXlNRGx4TGNwMTdhcDQwcENJNGVEZDJJdG9hTzFC?=
 =?utf-8?B?blpqNkdmb0M0eGJXVXNZODI0MmlKZnRqTEpkMEN0SExoVTRlTk0xUzh4bFRS?=
 =?utf-8?B?a1NEOXZYMFE2TmJFTnpTTm9uSWE1UXdrTmx2anVWYzJmTEt6L0pkRDFqbkxM?=
 =?utf-8?B?L2FwZFJPSEdCSWVZSE1Cb2Z4SWZBOVhWSllzZkFxTEZNUHlTV3lwUk5ISWRi?=
 =?utf-8?B?emIxKzVuMUVTTlRsZmErelQzbkdYRUViR3o0NmE4bE9QYXZHTzFzUFNENmxK?=
 =?utf-8?B?cm1wNFpQeHNZNkE4dWhWdmxvcUZBUU1JM2svaUtqUTk3K2tEN2QvR1lnZUd4?=
 =?utf-8?B?ZWJ3bG5oM2VOZExTdmhFY29iQ2xWRm1UajhOSktiVXJzeWZrRml6Z2Z3c3VS?=
 =?utf-8?B?dWRWWHh6d1Z4NDNvT2VxcjlOM24yRHo5THkyc3BMb3k4V0NpcDhLRUx5WU9z?=
 =?utf-8?B?bDdKMGlPa1RCTWtVWTBmYTJDTmplOXlYZjQvb1JKSCtZaS92TXRxY2F6Vy9Q?=
 =?utf-8?B?ZVk5dEJIT1Q4TDQzWjU5M0JUVFhNTzl3aktpQ0FJbEZZNm5EWTdOQVViWVJx?=
 =?utf-8?B?TldNaHRHRjJRZEFMOGNvMndib2F4TmpPQWNNc25PWDd3Rk9UWkJtcVFXa1Iy?=
 =?utf-8?B?eWVZMFo4TE5zbnNjNjBlSG1EbDUwNCt4V0xDNlhrd0JoRjg4U1YxdVUzY2tZ?=
 =?utf-8?B?WGVvZlNLd2FEWGZuM1lscHVNRUp6RUNZcVg2cC9rYXorOCtmTCs1WmI1b2ZI?=
 =?utf-8?B?ck12dDVwcVBsWm1walpLYUJOYXl6WHRsaUtISE11NHExSHI1aGNQQUw2YzIy?=
 =?utf-8?B?QUljSkwrcExzWXVLRHpTWXpMcFhIbHJZalA4MEtSVHkzVlRtcm1UTjNPQTNJ?=
 =?utf-8?B?M0xPeU9sNzBNWTVRWHdqNVVZZi8wVkRJMWEvWiszSGRneWxISEZCejdMb01l?=
 =?utf-8?B?bGwxYWFHM1pYb1RWQ3l5ZkpoNSttN0hSbWZKWmtaNzJJZy9Ra2F5OThISFZD?=
 =?utf-8?B?bEtVT014TTlVcVpWYlMxaHFqOCtXbTZTckorV1ZvaUoyV2JGa0VHY2pWTlZN?=
 =?utf-8?B?Y3c2Z0wwbmRBenZHMFpKNTlZcmo2WVVFSEdmYmV1Z1ZGUVA1aDVpUGhJaFYr?=
 =?utf-8?B?b1dicHRoMHM3czdGRk5SMkwwZTB1Q1ZHRjBVSnU5MlFKUzNJNVBFUGdBS2Yr?=
 =?utf-8?Q?dX1b0xGr26FSI5bEmu7BZ20=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af58e1cf-94b3-416a-b5fa-08d9bb2346fe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 14:50:44.0112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: amsV4YbgULhe6jszy29cQr3EDj+6WubeXqdMgpIZ1uuj3r0y3a2e+ym8oKQBOT3fJ1cCs93w4IuVWX+PtGOJUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4944

On 09.12.2021 14:40, Juergen Gross wrote:
> All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
> saving and restoring errno in order to not modify it. There is no need
> to save and restore in those macros, too.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> ---
> V2:
> - style corrections (Jan Beulich)

Thanks. Sadly there still is ...

> --- a/tools/libs/ctrl/xc_private.h
> +++ b/tools/libs/ctrl/xc_private.h
> @@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
>  
>  /* anamorphic macros:  struct xc_interface *xch  must be in scope */
>  
> -#define IPRINTF(_f, _a...)  do { int IPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \
> -        errno = IPRINTF_errno; \
> -        } while (0)
> -#define DPRINTF(_f, _a...) do { int DPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a); \
> -        errno = DPRINTF_errno; \
> -        } while (0)
> -#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno = errno; \
> -        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); \
> -        errno = DBGPRINTF_errno; \
> -        } while (0)
> -
> -#define ERROR(_m, _a...)  do { int ERROR_errno = errno; \
> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
> -        errno = ERROR_errno; \
> -        } while (0)
> -#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
> -        ## _a , errno, xc_strerror(xch, errno)); \
> -        errno = PERROR_errno; \
> -        } while (0)
> +#define IPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_INFO, 0, _f, ## _a)
> +#define DPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_DETAIL, 0, _f, ## _a)
> +#define DBGPRINTF(_f, _a...) \
> +        xc_report(xch, xch->error_handler, XTL_DEBUG, 0, _f, ## _a)
> +
> +#define ERROR(_m, _a...) \
> +        xc_report_error(xch, XC_INTERNAL_ERROR, _m, ## _a )

... a stray blank ahead of the closing parenthesis here; I'm sure this
can be taken care of while committing.

Jan

> +#define PERROR(_m, _a...) \
> +        xc_report_error(xch, XC_INTERNAL_ERROR, _m " (%d = %s)", \
> +                        ## _a, errno, xc_strerror(xch, errno))
>  
>  /*
>   * HYPERCALL ARGUMENT BUFFERS
> 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 14:57:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 14:57:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243112.420446 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKr5-0007Wf-AQ; Thu, 09 Dec 2021 14:57:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243112.420446; Thu, 09 Dec 2021 14:57:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvKr5-0007WY-6s; Thu, 09 Dec 2021 14:57:07 +0000
Received: by outflank-mailman (input) for mailman id 243112;
 Thu, 09 Dec 2021 14:57:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UPJR=Q2=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvKr3-0006xe-IH
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 14:57:05 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 44e45722-5900-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 15:57:04 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:35910)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvKr1-000MZK-6l (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 09 Dec 2021 14:57:03 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id DC9DD1FDB9;
 Thu,  9 Dec 2021 14:57:02 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44e45722-5900-11ec-9d12-4777fae47e2b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <6827208b-477d-d960-c0d6-8618eeef9635@srcf.net>
Date: Thu, 9 Dec 2021 14:57:02 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] tools/libs/ctrl: Save errno only once in *PRINTF() and
 *ERROR()
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc: anthony.perard@citrix.com, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211209134054.20757-1-jgross@suse.com>
 <a098fcae-7aaf-b5fc-79fe-acf9922e2cdb@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <a098fcae-7aaf-b5fc-79fe-acf9922e2cdb@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 09/12/2021 14:50, Jan Beulich wrote:
> On 09.12.2021 14:40, Juergen Gross wrote:
>> All *PRINTF() and *ERROR() macros are based on xc_reportv() which is
>> saving and restoring errno in order to not modify it. There is no need
>> to save and restore in those macros, too.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> V2:
>> - style corrections (Jan Beulich)
> Thanks. Sadly there still is ...
>
>> --- a/tools/libs/ctrl/xc_private.h
>> +++ b/tools/libs/ctrl/xc_private.h
>> @@ -122,28 +122,18 @@ void xc_report_progress_step(xc_interface *xch,
>>  
>>  /* anamorphic macros:  struct xc_interface *xch  must be in scope */
>>  
>> -#define IPRINTF(_f, _a...)  do { int IPRINTF_errno = errno; \
>> -        xc_report(xch, xch->error_handler, XTL_INFO,0, _f , ## _a); \
>> -        errno = IPRINTF_errno; \
>> -        } while (0)
>> -#define DPRINTF(_f, _a...) do { int DPRINTF_errno = errno; \
>> -        xc_report(xch, xch->error_handler, XTL_DETAIL,0, _f , ## _a); \
>> -        errno = DPRINTF_errno; \
>> -        } while (0)
>> -#define DBGPRINTF(_f, _a...)  do { int DBGPRINTF_errno = errno; \
>> -        xc_report(xch, xch->error_handler, XTL_DEBUG,0, _f , ## _a); \
>> -        errno = DBGPRINTF_errno; \
>> -        } while (0)
>> -
>> -#define ERROR(_m, _a...)  do { int ERROR_errno = errno; \
>> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m , ## _a ); \
>> -        errno = ERROR_errno; \
>> -        } while (0)
>> -#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
>> -        xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
>> -        ## _a , errno, xc_strerror(xch, errno)); \
>> -        errno = PERROR_errno; \
>> -        } while (0)
>> +#define IPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_INFO, 0, _f, ## _a)
>> +#define DPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_DETAIL, 0, _f, ## _a)
>> +#define DBGPRINTF(_f, _a...) \
>> +        xc_report(xch, xch->error_handler, XTL_DEBUG, 0, _f, ## _a)
>> +
>> +#define ERROR(_m, _a...) \
>> +        xc_report_error(xch, XC_INTERNAL_ERROR, _m, ## _a )
> ... a stray blank ahead of the closing parenthesis here; I'm sure this
> can be taken care of while committing.

Yeah - I'll fix on commit seeing as I'm doing a sweep right now.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 15:14:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 15:14:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243129.420481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvL7q-000291-17; Thu, 09 Dec 2021 15:14:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243129.420481; Thu, 09 Dec 2021 15:14:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvL7p-00028u-Tt; Thu, 09 Dec 2021 15:14:25 +0000
Received: by outflank-mailman (input) for mailman id 243129;
 Thu, 09 Dec 2021 15:14:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvL7o-00028k-KX; Thu, 09 Dec 2021 15:14:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvL7o-0003lM-FG; Thu, 09 Dec 2021 15:14:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvL7o-00054p-8L; Thu, 09 Dec 2021 15:14:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvL7o-0007kR-7R; Thu, 09 Dec 2021 15:14:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7fmGCgJnIH/8f0rGKhX9OGwGrCrkt2E8glXtNy3AEaI=; b=PsVhEocd3liEGYcPXDWjwgbwws
	dYpeUxFcsXPUI4XfgmIREAKuC3I6K8jy16DBESuYfRqzCOZVaC0RJWHJMFDd4TG5/OgMVP6DKQXsK
	efFdhW+Zf/OZFI46DQnXA7x4lw25WssbgXTM91G3Jy9qJCYCtGlN3+FINGJ6mBWzgukU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167262-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167262: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 15:14:24 +0000

flight 167262 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167262/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 15:52:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 15:52:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243147.420519 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLhu-0008PB-5v; Thu, 09 Dec 2021 15:51:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243147.420519; Thu, 09 Dec 2021 15:51:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLhu-0008P4-2Z; Thu, 09 Dec 2021 15:51:42 +0000
Received: by outflank-mailman (input) for mailman id 243147;
 Thu, 09 Dec 2021 15:51:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvLht-0008Ox-79
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 15:51:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e591289b-5907-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 16:51:39 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-vsF7qsYYPTWTouqCZdg8-w-1; Thu, 09 Dec 2021 16:51:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 9 Dec
 2021 15:51:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 15:51:36 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:20b:312::11) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 15:51:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e591289b-5907-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639065099;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=RNM/UWLc/l5RbGVn/70qsROA1FTMSZM+SGN6JaPN9MQ=;
	b=LVJln3x+Ovmiq78Hg6oNXgZyZ0810uBhZmlNOo2RWp5f43+Cc1+SWCaH2emmknElPngz7t
	GmAy/1z5ceydBP5I/KJJsswfn+DZEBP1emeGwEvZY26QUD6SZntDSe2CoxRGGzoP2SA2Ht
	+DI7l5S3/0AQekMevUbUyPdGxvAgWZ4=
X-MC-Unique: vsF7qsYYPTWTouqCZdg8-w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VZVMIK+hMljVL3AjCg4m8GHQEiNChipARSZV1lcldyi2oysxH6Q1Fw98hG8cs1ITfMy0e9nhq17W6P39RF4J1/k0fNdU5icXcv48Z0i1Tm0Wb9iLrWdXeOfDV0uAiMbx9+w78wQXgw3nLYVESLPjwCQDvLF/S3ebLMUsVePvTmOoJYiz7VTE83jKBQ7pFUyiHAQmAmtCTIT6N7peRpYPpuf1cp5GQOjK2vEGwvHaAfYvXxX2p/FzSpfErzKpFn10KCCiBtYsFTMJvbnhcSu9MPaHEX6xsiPLJDtaCMsy2mHkYICw0AiscSA/GErQIk4OW/FBTjn5eIx3L7ACjMZipw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RNM/UWLc/l5RbGVn/70qsROA1FTMSZM+SGN6JaPN9MQ=;
 b=cL2+O9ykeYI98itnKThZney1fCY6/7xx31/2dtQt63YlhlIvzHjhHxT8mdMnGakUGP5eF/QSIdHMwIQCCJo6WkAPnP93kO3m6e6H9uY9FMPTwP/f2S8INPMYqv/52ZV+1VJi3OqPpdG/3cal8U+KSwWe/q0FAcyoBaH2Kv0K2r16E2yScFBoq6mX+/CYVSB73cc2/jC55rDkV87vi7MAFy2Xj6twtC9loUrArf/zCEUnWaTmy1W2x/XtyKKG0dVdr91sZ4j3tChDPikIwJasuuOAsxucxrd6Dvjq49jtL890NdcDEZXkv6MMaiU8KeDahab4AMfS5X6zVTExDeZj1Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
Date: Thu, 9 Dec 2021 16:51:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 0/3] VT-d: macro definition / use tidying
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::11) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 04f058b7-2ed2-4844-eb02-08d9bb2bc7c1
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2445C2B572FA684529439F5BB3709@VI1PR0401MB2445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1468;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OpMRWiPwQ+5Iv5oMUyinPSQk2vWtJRI4CZLzt2CA3tHmN98ir212UXOrm+F0cCph0KGj7uZRWwvKupmFfmiCXNPzGXPmnl0YW1+znpW++on1//BNCayNGzJq58cMS1KYSwkkShWFis/iPf97C1GktNSCYxRI+IwaotAiC2/RO2WhtJU/04RZUqOC+0tm8EVjDf+XLQqIvKHAaGjiwJm1quNkkX0GGgP3xdBDnY/Q8gHYO64Et9wvP22FRUon4VjQS1f8bQJw3pQTffcUWKH4oNh540dJEs52Acg1cQCmJQqwionI7ToUyWJXpx566w0H5LZfqUDkXgDq3YGoN6mnpxM6+U6CQjxhtq2PVMToXGyG9ZNQjfP7nh3NZ2eUKbPLx5d83txVJ+oKRlKUukCJneIPjWs1fHT6JUZOR/OwYTPTn7NfevYNkUl+xCrCTH6RvUdV63PqxA1V28H/nSHowwYeQnKxlKxTEUpK1QsoEryl3klph4NN7lWDohOUIdHDu7F9CHj2BL2EIIZxWMOp1BBdXAxe1RCOO9iQeJU+Rrj6+Ir1v33FL/xX6KuBdlXEpn95Z6gevkYKeOl7KAAsX4+7Ikao/b99e9JpbGteKf6Zn++Iy1iAdYNDJVxeUAs/fJHgNHiKEgd+o95r1avSliw4qm26OGC2nYv2WJLkrFeC1Fn9WQUsonidlDuzcO/L9WoEUzWU2vfaVAZNpVINTVeFXeG6cBEl1RQRsVSD8AE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(66556008)(86362001)(66476007)(6486002)(8936002)(38100700002)(66946007)(8676002)(508600001)(5660300002)(316002)(956004)(31696002)(83380400001)(4326008)(36756003)(2616005)(2906002)(6916009)(186003)(26005)(16576012)(558084003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UExDRHJUNUhQbEczTjU3RGtZbklOZlBNR05xV0FiaHd2VkQ5NkRrSGhPQXJL?=
 =?utf-8?B?Y21GdTJ2UUEzSWdYSHkxVEV6SmlkQnpTMlZFckZwN1RYeFo5U080ZGMxOVRM?=
 =?utf-8?B?elREYmtXajRFYU5yL0FnQzJGOUlidW1zK1RXOXA1aE5HZE8vem1oUEd5MXMx?=
 =?utf-8?B?eHN5WEZxL0g2T3RudlErcEMvMC9yWTc3bU1vRnpSWHVBRTdFRVdVZEQ1d3NW?=
 =?utf-8?B?WDE5VTNtSHNZQlcwYzFpMFV4WFlQWFB0eUNNSXROZFpMajQwY1RCUDA1YU5k?=
 =?utf-8?B?WHhvY2QyWDdja21tdHFRSjRrTTRHRmdEZ1pvKy9COXlaYUNTUFRUSUFJZVZu?=
 =?utf-8?B?aXRFYnIrSXduRmVFSFcwTk56OVpkRHRvd21ZcTJodThSbkE2RzdwaTg5ZGJa?=
 =?utf-8?B?UVlPVlhNeHlXQ2lsNEdXWGJHZCtqYzlsUlg3TnpLRmpFQUZSNGFRSWx5NFl6?=
 =?utf-8?B?OHJSWWxCdHpaZzV4R0VwS000M2tvaURWSFFJVVhFZDBXWHdYQWxiaEhYeEFj?=
 =?utf-8?B?dmpVVnVDSzNsOUVJYUFWalhBdG0rNUxHc2JyVFFVSk9aMHN1azZDQkY5VGlD?=
 =?utf-8?B?T3RDY09pVTZXcnRISWk2YWVOSEUwNnNoREhlQXFaaytScStUSVRmakl0QnJx?=
 =?utf-8?B?cng3elZSMTJCVFpyQmF4UFZmVWc4czEwazRqZW8yUldBcmlEYTlYVDZRT3lL?=
 =?utf-8?B?aUFaZTBDSTVxODlLUllYdXliNHFCRW1VUERIQVYzV2xmbnF4VFpaNXhoMG9G?=
 =?utf-8?B?NVA1Wm5QcWFIRnNNbml0aXpZVXF5YUlUemVhNDFScElXZUtTVm4rVkEzUm4y?=
 =?utf-8?B?amNIcnVOWS8vL012MGFjYVdOZWdHRWRJMVNESXhoK1M2eXE4Ry9leDZjUmRj?=
 =?utf-8?B?c3FzbytuTll1M3EyM0QvZW40S2IzOGJQWTZORzhHcSt1WVV0SHBuMU9RN0tY?=
 =?utf-8?B?Z3dGLzhkWFlETlVwdTUzTHg3MWpYK2szNTVzbUVXZzNveUl0QW5TOVNZdnlW?=
 =?utf-8?B?Mmc5QytpaXJabnR1T1Nwc2V2WHNVU2xrbHRFVUt6Z2hVRjhrb3IzMEg5bHdE?=
 =?utf-8?B?bzk5dHI2S3RxN01HSmJQTmdyaFFQMlhjaDFqamZUOFYzYXN2WVc3YXF5KzRJ?=
 =?utf-8?B?UzE5R2draitwT3JsbXBUSDU5WkxHbzJjVFQwb203N1Jqa3J6THJLQ0ZGOUl6?=
 =?utf-8?B?TG5tck1LMUxXZTlUcW1CUnhqekZoZTZVTWNDbGVWeTJmb09PQldJbXZobnJN?=
 =?utf-8?B?NkhnSUJSN05PZmFqWlpRaU12dUlzbTY5TklUZTBNaXZ2WnRkL2pBQ2dwKzZ6?=
 =?utf-8?B?VGFvZUM1dkRDZGFjRGNnR0IzcHBNQkdFSWphQUFqdkd6SW0rL0lxQUE4Tllx?=
 =?utf-8?B?TldObVVvN1o5bTFObGhjcitvUC8wOTBBcGNySjlMYmtTTW9ZKzRMeThJdVVN?=
 =?utf-8?B?SUNKYWNsNDlzdGtvNkhwdjhEQWswd1lIU29IMysyR0tOd2xaUkJXaXF1SmVQ?=
 =?utf-8?B?aFFiVWNzSGNFWjFROXNOdklkSmhwY2xDTmY2N2t6NUpxWnZzd01JRGx3UEQ1?=
 =?utf-8?B?SFIyUWFuN0kvWVFHRGhhSGFwdjNERmQrbEVUZmVaY2NlWG80L3Y4VGNsQ3BV?=
 =?utf-8?B?dEhFNTR6QVc5ZkcwR21uQmhSMzkyV1FENUhSTEVQRU00Rk1ZSTJ6QmlHWWFB?=
 =?utf-8?B?czVlMjZEVHBjby9obm1TTmR4VW9mTDliVUNmS0luUkRyQ3lXeXRCMk9OWThR?=
 =?utf-8?B?TDR3K0s0QS9kL0g1ZHZZcXE3Y1o5RUpqdVhhYU9aazBtampOVE1yenZzT2FX?=
 =?utf-8?B?Q2xOejJqUkJEUTlxamNNcXorcnpYdXdKN0lRbmk0WW1Ka20vckVsK0pjc1Zr?=
 =?utf-8?B?V1VzMFd3Nk1DeFFXZEk5UE94TGJBUHQxejlyR292dmlQbHI4YVhWNk9JUjJx?=
 =?utf-8?B?M3lHMWoyT01wbHdWWUsvZjV1Y01OaGJtdHppK3JoREpaNlV1dGNyVXBFdW1W?=
 =?utf-8?B?akpLcmFlOWdBSUpDamdGVUIxQVM4WXBFM1NDV1RSM3NwWFFBUmFYc0RtdXFs?=
 =?utf-8?B?eUtyaCtTaVdkMnVSVFFVdk5JdFgvbXN2cWdmR1lIdEVYY0dqT0xxRGdjZG1v?=
 =?utf-8?B?M3VUL25hWHN3ZW1hcy93NlJ6OVRoNjNhdEszbTBxMllWMVhFUmo3dnNvWjc1?=
 =?utf-8?Q?2Ih3IR9vcW4UDvyalbR9liU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04f058b7-2ed2-4844-eb02-08d9bb2bc7c1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:51:36.1147
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uunjh58odMLFHUSB7nE4ZtBwbuGAG9x9p1iXHojw7MbxPGxpnRBudVPrT2gPoaIuu93fILRePd7TQANtZRHTgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445

While putting together patch 1, I've noticed two further aspects to
clean up a little.

1: properly parenthesize a number of macros
2: use DMA_TLB_IVA_ADDR()
3: shorten vtd_flush_{context,iotlb}_reg()

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 15:53:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 15:53:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243151.420530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLjC-0000XY-Hi; Thu, 09 Dec 2021 15:53:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243151.420530; Thu, 09 Dec 2021 15:53:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLjC-0000XR-Du; Thu, 09 Dec 2021 15:53:02 +0000
Received: by outflank-mailman (input) for mailman id 243151;
 Thu, 09 Dec 2021 15:53:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvLjB-0000XI-BT
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 15:53:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15c171bc-5908-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 16:53:00 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-sfbH4OMROmmXt1dQwJ7cWg-1; Thu, 09 Dec 2021 16:52:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 15:52:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 15:52:56 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0051.eurprd07.prod.outlook.com (2603:10a6:20b:459::10) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 15:52:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15c171bc-5908-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639065180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HpW65Eem6U7uyZ5bj6yJ4q2HfmHc5tpxlYyWf42MAXw=;
	b=e2y0O1cdSGBAVpaOijT+O59rRrdJaeLe/SOCxMKX4rjC4qJW5uUaxjQleUsdN5HIUpxoHH
	xbV6py2NHC+4HesHPU61ES9UKVUck45/Crijg6+uiZIL6xYcplZW+SuGY3fxCUw7f7j/pH
	Fqb+B3G5X6cgI17HUfXtf/Ijh7xdZiA=
X-MC-Unique: sfbH4OMROmmXt1dQwJ7cWg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UVNKDARm9WsiHr5WnXqUQPjLdoqyM8Q0xA7ExBSibVNbDsbgvqZ3H5uGivHLxahCTHvsLp3R3mw9jodkY0yOqGpTbAAFBxqGGOnVZkqeVcNaxmwLI5icb0pe8gEAM+lSxm9tJyh5X64xTuPE8C1WcoxmQpKHvEk53oeWc5uxdRCQdx0YIw5EUhkoYAr74YzkXWYNLP1ZK5CGH7CZeaTgeRd9sUGfbDjZKexQw5ueIo0nNJjlkBoQiJCjqmVhgThdlNNGfEsK1wxNmAr+vJIVdPLtjGAZ3sK48hMgzSN+aeX7F+bW/PwpsEWp1EoeP2qltP7GcGR7kNpO9cHCaAwyWQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HpW65Eem6U7uyZ5bj6yJ4q2HfmHc5tpxlYyWf42MAXw=;
 b=EKJx1hQSwM2MnawdLhqPrADtHXvRLoDo16BIPU6ZPckV6MeHh4BvpfSB6GHwLcQbDOylUrVnzb9pWvuDqjMZGZZF+XuMwS66cHHHgvrJjOhMvT5gW3ha4qHhl1lGUX2MM6pBCoHXDJ9maJi6jGpq3x3KDdPP+wXc5I0yZJyel744qUS7XEqN5knH5b1EFVXP4XJF2nuyUHC3BywDdaAxE3tl0GVArFe1vLoVn19zjY67xudCiVYBVtbhRuVX0QBaY//4XaA4c+SRsgqW2JKVXdx0NaZj+2Ckk8comSBTxsBhDmaSNp4KjO7W7iW5E6ysYf7mqoA2I0v2IdFtgFdKjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d0d4c383-d49e-1b04-5276-cf09f2169d5a@suse.com>
Date: Thu, 9 Dec 2021 16:52:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 1/3] VT-d: properly parenthesize a number of macros
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>
References: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
In-Reply-To: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0051.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 346dbaf7-98f5-4989-0cbd-08d9bb2bf7f6
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68613CC955395DDD7668C99DB3709@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:240;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5fnNRPinLH7nEPnGFAN8UBC0+P6B4qFwWA3m51GVowa+Pf1OUAU6EnPyXB03Vdzbvg1orGsUvZjLGlAO3eODlvxqEqTGdhZ5qspsziMtaRT8y+pHq46nln3UKGipjkVwUiHlfH01zJefWwqtn+ixedlcikqgC9uVLYnw+pQfeRjzivzq3neUPhe+jzpCYiW2n5aCYEbhb36d4ZhCdUPwkHLX9ucrC+JLRY8EySOKlOleFZZ998GQcunE23nsZWiC7c7dHXucyTfOIClE3EmQ7FnfooZsutxxajUILdbwRWFqZaTUJhmeaJQTAZn1NOKI8knOir5bgFp5rvTck9dPnZ+q5+mpF+zmAAK80nLX1uIy1NC/MOH/4enu8tfyqAWMkn4kquMmCTrnR1hVeSMQbNu1K/3FF16p12+74uHM11O34sF7umghey0kA7cw9m5v5eMxmQtGF5Cbgif4S4T7wLnmeC18HKWXp7ycXc4jBUN7k5lRnug0z4f0UHoJDbH5LpTKsshHgRy3yKXuIMiXZ5W4tj+BBuZ5h3vizr9qETtt3cH5B+T9xYnFHIjj7rUhX4zc/Ym4CMCwOhyPTH+sW9Bl577pTWPH1k7jlZsYyyT6ygc0ODX478C1mmhNCUmE/Mjl+Kagx8p5gsnBL7CeDhFvR0PZdn1yI4ukOQGfmI0YGnIce/grQxo8sd7BcU+R7n22eGCRjOrHnYKUR8nyehrDeA74lyz90iwSqNqA7LKaGWxIr3cyukajImVPghzM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66476007)(4326008)(66556008)(8676002)(186003)(31686004)(31696002)(5660300002)(2616005)(16576012)(316002)(8936002)(38100700002)(956004)(36756003)(86362001)(2906002)(83380400001)(26005)(508600001)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ektPMENMVXhicjJQYkZoS3dmb2MvcW85RGliNHVpYllwY3NmZGR3NUk1Nm1x?=
 =?utf-8?B?Y1pKUWlMZmVGejZ6OVVkUW5UZlRVcXczRWdMQmxvdnFtMi84Nzd1dWl1YTR1?=
 =?utf-8?B?aUVkbVlPbUFIU2pwUkNPc2VUV0ZLdjZGbkJzNC9rQ3ltY2hNNFl5MkF2V09Y?=
 =?utf-8?B?ZHowdlJmQ2ZWYUFSTjFjSjdwY2o0TzdOLzg5NjZuM0RQZFFFblBCV25wT0U5?=
 =?utf-8?B?RHV6SEFVWnV3dDJZQU1NN0drSmtidFE3UXR1NHZNOHlSNEFkbUp6YTgwRWZG?=
 =?utf-8?B?QnhsS1hPQnpuRVhnaER6NE95dWJkZG1lY3ZJZy84Sk5QUGxIbWI3U3JsRW1L?=
 =?utf-8?B?c3YvOTh4UmF4UFViSkR0N1JybGY2Smg0NEhNTjFlQVdxd3VVdGZNUnA0aE53?=
 =?utf-8?B?UWtsSS9BVGo2UXc4eTVETlpjWXg0bFVGM1g1K0JId1V3bG1VbHFwTWxYb2wz?=
 =?utf-8?B?RjVLV0lBa0V5QnMxcG9lczRRSEpweTJlUXlIYUg0VkVESVFEVit4V1hiRFQ5?=
 =?utf-8?B?azQ5ZVpjeUgwaTdpSE9zK3MwQUxvUERnM201U3JCUnUwYXhPK1RWZEN6d09B?=
 =?utf-8?B?bFZDbzlya0tGaU96aGNFbzNYRkVzWVFhK0U1QytIWE9mampXUGpCUXVTTkxa?=
 =?utf-8?B?bEFSSmpIc0psdTRFbFRraHlmSzdZM1AvTG5YZjhZVk16RTFaZFVna0NDUEh2?=
 =?utf-8?B?RTJoRVR1ZHVOc1RCZnI5OEUyN3ZNUmhhWHM0YklkOEJERUZlNC8rU2tuTW03?=
 =?utf-8?B?cDRVdDdCcFVLa2xXMkpHU2FoaWRtVkcydHB3TXBjY1FEZzE1RXFCVHB3Tkhy?=
 =?utf-8?B?WXdhSWxDb3BxSm5xWWs1SUt0ZlF3eGtXRXFHNGxpb3o1S0dZWHh0d3dpMzlK?=
 =?utf-8?B?WFYrY1RGTFNFZkdteGVhSVNLZkc3QXVWMlVLVlJoS1A0T3ZBRzczTlhKTEha?=
 =?utf-8?B?L3dwUnMvY3ZJa25KNTh1bnM1U0p3MS9kQUQ4N0FGeEx3dFNwT3VpZTZSdXY1?=
 =?utf-8?B?MGZxUDhUVU1JZG56QWZYSzAweFBCUjFqNkJjb0hobGVYdVYyUERsKzJOUS9B?=
 =?utf-8?B?dENoUWdzWDh6RDdhQUk4RDl5aVg5VDh5d1BpajdFNVBmc3czRFZsZUxVY3ZY?=
 =?utf-8?B?SFdqNGs1dzlldXJRYUdic25ia2Y3b1FVN2VXWHcwbnVWYzFkRkMzVmNobFBS?=
 =?utf-8?B?eXBPaWNUR3V4dTNMb0JLVm42TXBycFI0MVJvOXliZFBVSm12SUZSaVZzYkpT?=
 =?utf-8?B?VXNTcmNaQkQxbXNJSENEQytVbk5PYVZ4eW55R0hyVHNrend1OGVHVHVqYkt5?=
 =?utf-8?B?eEYxMkNLU3c2N3liOFpYYnp4M01TWjBmSXlFUjlpdTRsNUhkNjJFK3VxUUNp?=
 =?utf-8?B?NGJmK1QwVUdPeFVBN1pqMlRweGw3dnBHMlVieWZ6Sk1UQnhYb1JyYTNCV2Zs?=
 =?utf-8?B?aldMVUZKVldUR1BiRmhTQ3FuVWsrUWlQUTc3b3FodElIc2VuanBGSXErcmRX?=
 =?utf-8?B?L3I2YXNNTFlySnF0ZnN1dllydVpBaDA4aTAvRlBhTy8zTFNjNS85NDNnbU5L?=
 =?utf-8?B?cVM1RkhJMU1vbElFc29scUk5TEZhd2hGbVR3VUp5VXRmUktoeWxnRFZmSVdW?=
 =?utf-8?B?MHg3Q3BrRE1rMW5kVklWMGhQMlpjSnpGNUZwQ1AxWVhDWmxhK0dXQ085Z2Yr?=
 =?utf-8?B?aTFtalkvWE1zWlRjdUlNOTljZWgvc0dHL2RBMUtXNDhPdzNwak9valdBWTVT?=
 =?utf-8?B?UzF1emFKa3VSaEJUeGJnNWlocGY2UzVSRXJDWVVpUnl6U05ZZGNEUncxNElL?=
 =?utf-8?B?dnh0RDFwczVVcFlVSVZISmN5ZmlSb0I2TU04L29mdmo1SWo5V0FKb1BwUzBy?=
 =?utf-8?B?SVdlSDUrdmtsUmNNdmdob005YmhNZStCUmtZZE1ZWkxzWlhUV3luMVNWLytZ?=
 =?utf-8?B?MGFtUVY0alpYRndPWTBxWm9rSXd2cjBmeEFOOFVRMHdhdjl6OXVTRzkwbWNq?=
 =?utf-8?B?MG1Ca09zNU5JQ3NqaVpKa0RlcUUzVHlUb1VUVUpqRFRaREd1UmM4d1ZPWkc4?=
 =?utf-8?B?RkJsV1pPTjFlNHpzY2t6WlJxMUxrR25oUFluc1lzZThEUDg5ekpWS1IxQkJR?=
 =?utf-8?B?UjRYeFhMQWdlamczVkZJb1RXWEk5RktJMGRtU2J4c2J3TWZya3RVZ2prVDFT?=
 =?utf-8?Q?w+/nnOkpfxq36FeC0C9NMHw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 346dbaf7-98f5-4989-0cbd-08d9bb2bf7f6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:52:56.9280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V1L2T13kwNqR4n8KQPyKqcJvSBIKOBc8bmVHQBHoiutiHvV95ezlJs55iMCOVYwSDlaiKLUYrn/c+gqvHgaxUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

Let's eliminate the risk of any of these macros getting used with more
complex expressions as arguments.

Where touching lines anyway, also
- switch from u64 to uint64_t,
- drop unnecessary parentheses,
- drop pointless 0x prefixes.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -90,14 +90,14 @@
 
 #define ecap_niotlb_iunits(e)    ((((e) >> 24) & 0xff) + 1)
 #define ecap_iotlb_offset(e)     ((((e) >> 8) & 0x3ff) * 16)
-#define ecap_coherent(e)         ((e >> 0) & 0x1)
-#define ecap_queued_inval(e)     ((e >> 1) & 0x1)
-#define ecap_dev_iotlb(e)        ((e >> 2) & 0x1)
-#define ecap_intr_remap(e)       ((e >> 3) & 0x1)
-#define ecap_eim(e)              ((e >> 4) & 0x1)
-#define ecap_cache_hints(e)      ((e >> 5) & 0x1)
-#define ecap_pass_thru(e)        ((e >> 6) & 0x1)
-#define ecap_snp_ctl(e)          ((e >> 7) & 0x1)
+#define ecap_coherent(e)         (((e) >> 0) & 1)
+#define ecap_queued_inval(e)     (((e) >> 1) & 1)
+#define ecap_dev_iotlb(e)        (((e) >> 2) & 1)
+#define ecap_intr_remap(e)       (((e) >> 3) & 1)
+#define ecap_eim(e)              (((e) >> 4) & 1)
+#define ecap_cache_hints(e)      (((e) >> 5) & 1)
+#define ecap_pass_thru(e)        (((e) >> 6) & 1)
+#define ecap_snp_ctl(e)          (((e) >> 7) & 1)
 
 /* IOTLB_REG */
 #define DMA_TLB_FLUSH_GRANU_OFFSET  60
@@ -106,14 +106,14 @@
 #define DMA_TLB_PSI_FLUSH (((u64)3) << 60)
 #define DMA_TLB_IIRG(x) (((x) >> 60) & 7) 
 #define DMA_TLB_IAIG(val) (((val) >> 57) & 7)
-#define DMA_TLB_DID(x) (((u64)(x & 0xffff)) << 32)
+#define DMA_TLB_DID(x) (((uint64_t)((x) & 0xffff)) << 32)
 
 #define DMA_TLB_READ_DRAIN (((u64)1) << 49)
 #define DMA_TLB_WRITE_DRAIN (((u64)1) << 48)
 #define DMA_TLB_IVT (((u64)1) << 63)
 
-#define DMA_TLB_IVA_ADDR(x) ((((u64)x) >> 12) << 12)
-#define DMA_TLB_IVA_HINT(x) ((((u64)x) & 1) << 6)
+#define DMA_TLB_IVA_ADDR(x) (((uint64_t)(x) >> 12) << 12)
+#define DMA_TLB_IVA_HINT(x) (((uint64_t)(x) & 1) << 6)
 
 /* GCMD_REG */
 #define DMA_GCMD_TE     (1u << 31)
@@ -144,11 +144,11 @@
 /* CCMD_REG */
 #define DMA_CCMD_INVL_GRANU_OFFSET  61
 #define DMA_CCMD_ICC   (((u64)1) << 63)
-#define DMA_CCMD_GLOBAL_INVL (((u64)1) << 61)
-#define DMA_CCMD_DOMAIN_INVL (((u64)2) << 61)
-#define DMA_CCMD_DEVICE_INVL (((u64)3) << 61)
+#define DMA_CCMD_GLOBAL_INVL ((uint64_t)1 << DMA_CCMD_INVL_GRANU_OFFSET)
+#define DMA_CCMD_DOMAIN_INVL ((uint64_t)2 << DMA_CCMD_INVL_GRANU_OFFSET)
+#define DMA_CCMD_DEVICE_INVL ((uint64_t)3 << DMA_CCMD_INVL_GRANU_OFFSET)
+#define DMA_CCMD_CIRG(x) (((uint64_t)3 << DMA_CCMD_INVL_GRANU_OFFSET) & (x))
 #define DMA_CCMD_FM(m) (((u64)((m) & 0x3)) << 32)
-#define DMA_CCMD_CIRG(x) ((((u64)3) << 61) & x)
 #define DMA_CCMD_MASK_NOBIT 0
 #define DMA_CCMD_MASK_1BIT 1
 #define DMA_CCMD_MASK_2BIT 2
@@ -156,7 +156,7 @@
 #define DMA_CCMD_SID(s) (((u64)((s) & 0xffff)) << 16)
 #define DMA_CCMD_DID(d) ((u64)((d) & 0xffff))
 
-#define DMA_CCMD_CAIG_MASK(x) (((u64)x) & ((u64) 0x3 << 59))
+#define DMA_CCMD_CAIG_MASK(x) ((uint64_t)(x) & ((uint64_t)3 << 59))
 
 /* FECTL_REG */
 #define DMA_FECTL_IM (1u << 31)
@@ -175,10 +175,10 @@
 
 /* FRCD_REG, 32 bits access */
 #define DMA_FRCD_F (1u << 31)
-#define dma_frcd_type(d) ((d >> 30) & 1)
-#define dma_frcd_fault_reason(c) (c & 0xff)
-#define dma_frcd_source_id(c) (c & 0xffff)
-#define dma_frcd_page_addr(d) (d & (((u64)-1) << 12)) /* low 64 bit */
+#define dma_frcd_type(d) (((d) >> 30) & 1)
+#define dma_frcd_fault_reason(c) ((c) & 0xff)
+#define dma_frcd_source_id(c) ((c) & 0xffff)
+#define dma_frcd_page_addr(d) ((d) & ((uint64_t)-1 << 12)) /* low 64 bit */
 
 /*
  * 0: Present
@@ -233,16 +233,16 @@ struct context_entry {
 #define PTE_NUM            (1 << LEVEL_STRIDE)
 #define level_to_agaw(val) ((val) - 2)
 #define agaw_to_level(val) ((val) + 2)
-#define agaw_to_width(val) (30 + val * LEVEL_STRIDE)
-#define width_to_agaw(w)   ((w - 30)/LEVEL_STRIDE)
-#define level_to_offset_bits(l) (12 + (l - 1) * LEVEL_STRIDE)
+#define agaw_to_width(val) (30 + (val) * LEVEL_STRIDE)
+#define width_to_agaw(w)   (((w) - 30)/LEVEL_STRIDE)
+#define level_to_offset_bits(l) (12 + ((l) - 1) * LEVEL_STRIDE)
 #define address_level_offset(addr, level) \
-            ((addr >> level_to_offset_bits(level)) & LEVEL_MASK)
+            (((addr) >> level_to_offset_bits(level)) & LEVEL_MASK)
 #define offset_level_address(offset, level) \
             ((u64)(offset) << level_to_offset_bits(level))
 #define level_mask(l) (((u64)(-1)) << level_to_offset_bits(l))
 #define level_size(l) (1 << level_to_offset_bits(l))
-#define align_to_level(addr, l) ((addr + level_size(l) - 1) & level_mask(l))
+#define align_to_level(addr, l) (((addr) + level_size(l) - 1) & level_mask(l))
 
 /*
  * 0: readable



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 15:53:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 15:53:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243154.420541 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLjW-000123-QV; Thu, 09 Dec 2021 15:53:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243154.420541; Thu, 09 Dec 2021 15:53:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLjW-00011w-Mm; Thu, 09 Dec 2021 15:53:22 +0000
Received: by outflank-mailman (input) for mailman id 243154;
 Thu, 09 Dec 2021 15:53:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvLjV-0000wM-Es
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 15:53:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21c37606-5908-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 16:53:20 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-IrzcLQ9iN062o6QvFlXcGQ-1; Thu, 09 Dec 2021 16:53:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 15:53:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 15:53:18 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR07CA0053.eurprd07.prod.outlook.com (2603:10a6:20b:459::20) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Thu, 9 Dec 2021 15:53:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21c37606-5908-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639065200;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X1JkCI513jhv/rTO/fuBWeH3kMDCynbS33Cs/DQtrM8=;
	b=SymmC0ViDqsjig9dp2Pgoi5Z1CAfFUig8e8amPEIBBIdS9uuFfyaNffP2MueCcZhlytAlv
	PSSUwrfbr60+CnNorbLB+WJWdrpdEEkALTFMPhGAUUjzGQrmw6qAwN6NjxWbBapWe1TUeI
	KOOQKcO5sqtsmbpd8iZExJPmjHWro48=
X-MC-Unique: IrzcLQ9iN062o6QvFlXcGQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YWZzrmcNsalZKJXAQYMPwSCJZ5CiYj6OPnXG7BJNZrEnMQI6jDUlk8Qb2sGdMPEyNUagJ31HBORHFpwhmSA8jCl2AhApULIWUSkxTckkAnM08uqRIeK4GmKnNi8Eos0hC/IURNDBt8aAKsply2xqMCYqwesSMIZATNkl1S7ExaqyuHe/UvMJz8NNu+bZewOcSeHY0hsbzZps7vrCVTMcz7q9P5/K1p9wtANXxeUDjmI1ZW3Wz/vKzy3/nySQByCxURbms4lfiN7sppe3yh2yu5wCD6KaK0iSH2kT8QBD+98kqxY2I0jN7dhXg6EEwOtG3dpsvgyhgvHukrulxaX91g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X1JkCI513jhv/rTO/fuBWeH3kMDCynbS33Cs/DQtrM8=;
 b=Ip81rRYkgEQNytOYoSTWbR9k+baOfpAT4TFahxt6OgUguOwmdWwfMMTs8ImRxl7iSlT5ddOPP4wctnC25WPuIEYoTbq3nctw5V64PGZ60lO35ErKZZ/cCLpnzs/0ztO9oFcGAHLIDaWYYw4oUtJvXNmXe7OcYKh/HD3kaJS7UnWX+YtZG8QX33Uh+hYakRyrMsJDiGaGfO+EAEfyJZyVnzVLzzp7xfKGfQt+FjSeXrZcI4dS/0SslAxNAN3oAJ2Tf6fB2m9+wAo7wD0OWHs2qcTNkf1dvD/e48NGwtxBr9Vw1a52ts4pq+HFoubcR2BeKHcXCmKa+F5P6mhwNH6B+w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6d8407de-7941-00b7-7607-3b9bf8c5513f@suse.com>
Date: Thu, 9 Dec 2021 16:53:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 2/3] VT-d: use DMA_TLB_IVA_ADDR()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>
References: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
In-Reply-To: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR07CA0053.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 85a771a7-f2ec-4f09-5a71-08d9bb2c04a4
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6861E89952C33FA443215859B3709@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p1H9hjtdr4asnuaXnnAAowK4cp9J5YTyhyeOjjQlNTGDJY+VDlvtQy4Rb17o0rTjqJ+wGlOCWbrsrACoaCrc13U2wXWmBqy0Tm8IgURa2iHVYEtYIU5D8Nqd9/4fZTM/j7A6Gqzqn1Nujr6uIP8iBFAoJoRrpBMlnQXRJtbDRpg/38KnAaG3H5rv5cF3B1NNIjTKVvcXIlmRZPakS7D6jFvlyAbB7sDJ5QzQgSRaeW68bepwnAwl9bPCery7/PxSOq5AAanZ5iPV8y0gBXJ4VZA2qwvowFYs37bqJ7crmq2ueQxquuaJKSGFFy79bgM3K089LiQnqqwDsWrUyjFEXW7yMTLTsU9jVt1T1FXeNezeGop9DLiM4iISCFThLXUm0myFW5shzbZYaQdbgwUrKf2x8oz2ReA3ZcFsMIw0ApIFnpvP/x3GXWXrLlKi/VFcSdvVX+Q068GsNZWdKvpANCFFemC94kaTM6hUTLtszSFWEY9aRMNZD04SBUQ0hYuk5uV7IxWI01AOiOP0wuyDCzGnOQsKkai+KW7DBoneO3YoAwZff0Me5LoQrVyUt/PcWfQZxoSPJBjijutN6LhT8miUnqfLkDbiukF6dlFe367c4ABr6IhMLUDUhLS6xizAbiaF5lNkfYdIGYTlz2RORS+3KUYnNqgi32vAgLesTrQabZL0VOxeVhicyaIzX5Aj5D4kq6RTefgXiBmPI19Xi8Aw2F5R74FRjnyCaPf1eldRktndwiMOmOxPhsZ9y+mm
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66476007)(4326008)(66556008)(8676002)(186003)(31686004)(31696002)(5660300002)(2616005)(16576012)(316002)(8936002)(38100700002)(956004)(36756003)(86362001)(2906002)(83380400001)(26005)(508600001)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UkZLRlNhTXJLUCtEdlNZUThlZUlvQ0c5eGFPQkhreG1neDN4WlFLWE1XOXJh?=
 =?utf-8?B?TEVJWlMvSGsvalE3V2xDZ1BVcFhuem9PM0pvY2ZWZ0QzcXNUay9HZlpFdkFo?=
 =?utf-8?B?VUJSS0ovSTN2cCtjZkorTUNXajJBMUJLMmM1V2lmbncwKzdjSlBudFNnM0F1?=
 =?utf-8?B?WU9tTTBybG02NDRtMzE2NHcwR2ZlUjBtZFZrMHBKaFRQR1Q5MWRySHluWDEz?=
 =?utf-8?B?bU5CZEJxTmZITlpFbjc0MXVhRjRwUGh1MjF0RzBqMWs4NTlkZmFoQWxMQ2tB?=
 =?utf-8?B?NHNsWUxnMzEyY1ozbFoyL25YUXR2OWI5WnpILyszdGo5dTV6czlhSkNuRW5Y?=
 =?utf-8?B?akdZOEZtRzJLZ0V2Y1FFaUdhU0JtWFZNSEcrd1NjS3lrcnBJYnh1REk1NjNM?=
 =?utf-8?B?UTRIU3JNSWw2S0lkWm9Vc2FnaTJLdTQ1TzM5bkh0eGMrQXNnSWRuSGJoalBE?=
 =?utf-8?B?d1cwc0VxbVZjQmVTSS9NT0xpK3JaMldhUkppQ0ZReUt3U1Nib1hiY1ZMU1RS?=
 =?utf-8?B?dWdXZDNBWHVZb21VeHlUQ3k5bklvMVlMN0JIbG5LaVJ0TWw2K1dXLzlYd0pr?=
 =?utf-8?B?VzRBaVlMdU1EWnhrajZQSzlqWkVGYmN1OFFrZmwzOE9VZk1zQlJYSDFFTElp?=
 =?utf-8?B?SWc5UVRqOEt1TUtQbjM4bXhhUWgwOGdBbHExR0hqS0RENmRmak1Zdm85Ykww?=
 =?utf-8?B?T1FpcjdXNVVQMFpYVWtCaEZzUWxwKzQ5YW56Qmc1Y1kzRS9BbnV6ci9KeWcz?=
 =?utf-8?B?MmNqTkNzZWRkUFNRRFNhSUYyQUxvL042dThNUlQwdGg4cUEwM3RWaXlyWUlz?=
 =?utf-8?B?Q2lFN3ZLN2ZZVDRBWGJDTnNhV01QUDY4L0Q4UlN2OHI1eTdEYm5BT21PSDhY?=
 =?utf-8?B?aTREL0hQVkFCNDBpcUJWMHdScjMzOEN2UEgvbTUzalBmdXFyUGtRbXIvRk1Y?=
 =?utf-8?B?VXBPZnQ0WHRVN200aFAwQzdvc0hNNWUzKzUwUjAyRm80RHRMYURNZW5ycVN4?=
 =?utf-8?B?L0h0alNQdzBCWVg2T3Avci9Fb3lJR3R4bm9yQ1ZITGZDbG9EOEc0aEdxUEd1?=
 =?utf-8?B?S1EvQlJoMlMyWmVHa3dVK0tzYzVwb3Y4bTFXVXBlb3hnYkZqWTlwUUZtZ3RZ?=
 =?utf-8?B?OWgxclBmSFpVaE1BN1BCWWZqSkY2WCtKM3dXK3Jnci9ObmY4T2JMQVVHRDVk?=
 =?utf-8?B?MU5hTnRwUW8xWXlhanpFSlR6U3hROGdiNjJoQUpmOGZTbmdrR1RjUkkxSFJE?=
 =?utf-8?B?bGxoVm5GTHRZUDkxM1FRcnY2b0xqcXpJS1hDWkxqZGdlb0NINTFKdDhBSDVF?=
 =?utf-8?B?SE5xQjRHSWQ0ZFpUM1U2N0F3cHBqZStGeUlOZE91SzVDdjBVTnc4ZVY5NW9k?=
 =?utf-8?B?TDE5SldhdThzU0xpMFhxRmJtSHFTcGMwT3YybWhFMWExRHJvdTNTMkx4T0Vo?=
 =?utf-8?B?RWxqVGVMcGNvRDFaS1FadFNNclJaRmFxM1U2c1UrS1VYb2x6cFo4ZW1kK0x6?=
 =?utf-8?B?OTNFcFZZY0h0NDQwMGIyU1pWUGRoYldnOGg5bE9pUkhwaUdycmw2eUJSNGc5?=
 =?utf-8?B?L2x2dlBKY2dBRTdzNzFYTzV2cmxSSk85UHdGWmlPbGVhR2Nzdy8xL0pscGJB?=
 =?utf-8?B?Q01wLzc4dmhaSkdDdVJhZG1zOEhFak9PQ2QzN1lianVLeTM0Q0dkd3FJRUJk?=
 =?utf-8?B?VDV2Z0NjeFJjQWV3NjdjLzl5OXB4Tk5SMyt1NE5pTnZoajJpek5meTBWRklN?=
 =?utf-8?B?UW05RE9oWmdreVN3Yi9yajlwUjkzcEV5MEIyQ1B3VmpIdDdPK09Td1ZQZVhP?=
 =?utf-8?B?STJaQWI3S3FxTUM1WVg5R3pxS1R2Zk5SaXBadldtQ3lVTVVuRUI1RFg0SXVX?=
 =?utf-8?B?OVZEVkRHVjdhaUdoeTdlS1IrQXVQRkVOWWlnZnBtRlp6K1hUVWxaTVVNM0dq?=
 =?utf-8?B?N2kzZ2gzT1kzSzR3RFRCS00wR0NSaEY5WXpoN2pHbjFPOTJlSlQ5elNtK0to?=
 =?utf-8?B?UStWUkdUYW40QkZudkE0MlhBMkRwUklVU0N2MmFWUHV5aHo5NnFTWjdla2Qr?=
 =?utf-8?B?UU9UZW5zbWZKdjlRaFR6cEp4bzljWkNYQ1RzV1BWNG1iZ050ckJMMjRuamov?=
 =?utf-8?B?eWpIQnlxZGhpWGszbFpaVWpNTkRpYzBzd1FUTExlRU1ZQmZzeUE2Wlk2TmUw?=
 =?utf-8?Q?A25OKvgmVYHeXaY6OEIxHyE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85a771a7-f2ec-4f09-5a71-08d9bb2c04a4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:53:18.1820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jrfsm0NeILWuhK7GUzSRX/uNws7Rf5d7WiowxNyhRA2yWODMThHxQP5cwG4eI6s/bJAnpmWqXFL8PxfEcVvyOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

Let's use the macro in the one place it's supposed to be used, and in
favor of then unnecessary manipulations of the address in
iommu_flush_iotlb_psi(): All leaf functions then already deal correctly
with the supplied address.

There also has never been a need to require (i.e. assert for) the
passing in of 4k-aligned addresses - it'll always be the order-sized
range containing the address which gets flushed.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -546,7 +546,8 @@ int vtd_flush_iotlb_reg(struct vtd_iommu
     if ( type == DMA_TLB_PSI_FLUSH )
     {
         /* Note: always flush non-leaf currently. */
-        dmar_writeq(iommu->reg, tlb_offset, size_order | addr);
+        dmar_writeq(iommu->reg, tlb_offset,
+                    size_order | DMA_TLB_IVA_ADDR(addr));
     }
     dmar_writeq(iommu->reg, tlb_offset + 8, val);
 
@@ -606,8 +607,6 @@ static int __must_check iommu_flush_iotl
 {
     int status;
 
-    ASSERT(!(addr & (~PAGE_MASK_4K)));
-
     /* Fallback to domain selective flush if no PSI support */
     if ( !cap_pgsel_inv(iommu->cap) )
         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry,
@@ -618,9 +617,6 @@ static int __must_check iommu_flush_iotl
         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry,
                                      flush_dev_iotlb);
 
-    addr >>= PAGE_SHIFT_4K + order;
-    addr <<= PAGE_SHIFT_4K + order;
-
     /* apply platform specific errata workarounds */
     vtd_ops_preamble_quirk(iommu);
 



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 15:53:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 15:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243161.420552 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLk0-0001fp-7u; Thu, 09 Dec 2021 15:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243161.420552; Thu, 09 Dec 2021 15:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvLk0-0001fi-4l; Thu, 09 Dec 2021 15:53:52 +0000
Received: by outflank-mailman (input) for mailman id 243161;
 Thu, 09 Dec 2021 15:53:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=+Con=Q2=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvLjy-0000XI-QF
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 15:53:51 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 336dd862-5908-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 16:53:50 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-BB98DskpMUW7IVCK5smIrQ-1; Thu, 09 Dec 2021 16:53:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Thu, 9 Dec
 2021 15:53:48 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Thu, 9 Dec 2021
 15:53:47 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR04CA0036.eurprd04.prod.outlook.com (2603:10a6:206:1::49) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.24 via Frontend Transport; Thu, 9 Dec 2021 15:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 336dd862-5908-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639065229;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8gDGJGQ3q/kpTI39nNO6K9uOCAOBK2KpkmRZMpGfFgk=;
	b=dTNl99rnJ9Ryi5rDZrwcwHHBNBCnWFr6IwhJhVbdUVVzacxS1broKmJFBFMNRmIhXrfn5E
	AeXs78FdwQegLtULE6YUCLEHZolaSWmXzh8jLUrIxhc/Wm2stVIwGwSeexVmMdzDIwy60i
	A7bMDWR3y7yUA3Fc99x9lFQdcWzn5ds=
X-MC-Unique: BB98DskpMUW7IVCK5smIrQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UWLzl1zyjuVeYIx2feedc+vlvBNl5RWnqFc9aFH2Xm2/0OarYuQrhFQD0una6cbAQK7F0tPxTK9+la2HV6ZwEtp9szsMYcerNRm02kP6LWGWfY/QowYMeWBTc2TEixukADt36ANU6oVO2EO7BD3skZLX4Qf+moImlAP8gOnFkcNDdtgllfUlDszOQ0ryO3brG87jOWUV3QYFg++Jy95kEG81GrUbvYuJA8ZnP4d/5hmytiIrX7cUp3bJGxC40K3EoQ17i6yhbbcsMjTeANVJR5u392wnwMBEwVQOQZs6X9LR1mnx00n+nV51y88ZWY823mODFWqSKiB6toft3O+fSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8gDGJGQ3q/kpTI39nNO6K9uOCAOBK2KpkmRZMpGfFgk=;
 b=OS78/GKHVSCFKaoFfvtYx4qp2ubPgc9JErZP2NGrwxEO89jE+ByYdHchaNlWAgLpM9iqFK7SJpm7kfo4xvKt+DuQGcwnhPblyH2e2jMf3KwZaQs6hioyf0n4TK8uHnBeSfwBxXXfCbapzyy8utvKU/9I2IEaiPpKq5qj3VlcvrPfInNlkmrJ5uVlDaWKDt6ge68vOjNqoCKRgUahHJpGyAXC6EDVU7WerVoZmYYyZOGOddqeuvO+EQmO9I7v1AECjlR7vGWJHy/9HW7uv3P/pj1o0xtilA8mQv3rqOOm4pbUgAWRsbCNWhdswXUqIbhGbnsjZig/cMgeFJRhduxYFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4d1b5bb2-e5a3-e581-1bc2-9ac7eb61af35@suse.com>
Date: Thu, 9 Dec 2021 16:53:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH 3/3] VT-d: shorten vtd_flush_{context,iotlb}_reg()
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>
References: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
In-Reply-To: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:206:1::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 87bcba05-e96e-4656-069e-08d9bb2c1657
X-MS-TrafficTypeDiagnostic: VI1PR04MB6861:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6861996695E87CABE567D08AB3709@VI1PR04MB6861.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rpLg3uDfwK47yqOk+h8p+ZJN7iEkZl+g+SIjl1Y8RNTgjyh/IFKv57jCWDjDcT75NO71Xu7INOlwiisuwXRe+Osudz+fBPBPql/2xhMhs91XHSi0pkK/up76A5FSUKaJ0QWtRR3+naKy+3nFBVoeePsTI1n8JRIlbpsTcHfpl0GTaVeGlgSqMqQi29CJ4XxzHcML5cMZTaCKZBhiA1EstalQ2bj8zKyIKMjVz6+l0dxZ6KzNQ+4eiHLoYwmO6ewKd7G4I5YHzYMPHD6r/0Goy1wyjibXfbHObueOTTNatOogGVakcgsM+Z2w3ioGfw4V71iLvBw8nhCBXEsJ4Iwpe7bilfs6tVwDuliTwQCmK7i37v0t/CF+WD8YyrpW02g2EEwkeubJ4uomzoWSlA62lGkXUn6U9qK72VrXwyeMpwXM4249n0d2u8EWq+EXOfQa/07WhGq6jAFG+YdZMQLyetotEv5FPIsHqoMMuMgoi/Me22vCUgeR7t6EWOLiK3+3tBtoNVUZac4QiR4R7pcaCQBKbxGUeYG9Qxncd3PuuLBVVGWidfjfEQOuOg9vOYNpeyHf1s4bYuU/izWECSnsjEcngBUvoLd7sPCa6NC/hfLAp/X0o/17E6blF6gRpWqHA42f4W6wJfG+KBiz76nNRiPZdCpMnmcmMlRdZdTarLzgEA3LoSo92MnKCrXKMDIkoeH89FtK4kI+Og5Ys09oyEpN0Wx4tKBZFnHkW5eFIfAJ6SRuMmrE64Z1BwhCGHd5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66476007)(4326008)(66556008)(8676002)(186003)(31686004)(31696002)(5660300002)(2616005)(16576012)(316002)(8936002)(38100700002)(956004)(36756003)(86362001)(2906002)(83380400001)(26005)(508600001)(6916009)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cGxjQUVjcHJlM3RnbTJWQzljZDdpb2ovci8xVVB6NFBrc2ZNMkE1RlAxWmdJ?=
 =?utf-8?B?TVZEZ0NZZFkzSlp3UjVDNHFkY3pqZGgvK1ByYkkyREo1YWRNM05saWFSbG1G?=
 =?utf-8?B?WWtlWlIyTDlPRTErVGVwWFVsWG40YWVDUTBvZUVieG1uR2FQSlIxTUFGMk1V?=
 =?utf-8?B?UGZUUy9aOCtJQUR5K09heUZZRXowVXBabVhrWGw3cERyRzZ1cmVaQmt2elIx?=
 =?utf-8?B?anBkcTVWWXNDY3RFZ00wYVJRd2ZvRk9YUDkvMmYxUE82UTdlTWg0bXpVdFJQ?=
 =?utf-8?B?ZkRwZXZTL0JySHFhMC90OWZ4WDhjRXlHdm9CK2dGUTNXOXJsdWJMQkg4K2lw?=
 =?utf-8?B?cmkwVXZ2UnZMeXV6bGhnTXFaSEZ6aGI4RkJxUHZ0K0x1K3loM2ZsNGtDUDFT?=
 =?utf-8?B?WG4rc0dtRUlzc0IxSGl5VWp2Mmp3bHpQM0NZOTNVV0J6SlYrWnc1c3p2aVg0?=
 =?utf-8?B?TWVJcU5kS2lyR3BQZEhHSmhRQmlCU2ZiT0xBb05DcXBiL0xpekdyZEttV2tL?=
 =?utf-8?B?V1NvTEo1N3dncm54bHNOKzh6T01vOHpOMUI3UXFRb295MVIyZXpSeUdvVC9v?=
 =?utf-8?B?L1hsczMzeWNTQVNRNTZ5RkZEN2dDdUgxaHBrOUl4VFRTWkRQdXFmbkVzYmpv?=
 =?utf-8?B?VnFTc3VCSzNCS0dGdlVUTnFwM2RXSzg5bzdHMzZVaUpBdUY2UHplcXVURk54?=
 =?utf-8?B?T29MNzNmL3hEUmtuOFRDd3VmSXRnTEtpN0I0WEFZaFN6ZjF6b0NWZXFIYktM?=
 =?utf-8?B?eVRjY3UyQVZMR25iSlQwTDVEWnJtZ3ZncG1zU3hIalY2QmNweVpBWVFXdTJm?=
 =?utf-8?B?ZTJoUUxOQzhvbGJQekVlb056MXcvbGtIZUJYOGY1RGQwMWlndmhUSU05dFJB?=
 =?utf-8?B?NUtUQzdiK0lic0hzNHI3d0xrbWR3NjZ1eGVaNjU5Y2EyZGNldldia1VEdW53?=
 =?utf-8?B?SXBxNnlTYTI4aUEyazdMMDQ0d0hWVmZKeTNmVHNVS2hEYmU4aXpxNVhSRTh5?=
 =?utf-8?B?TE8yUG80RWZzYTZpbzlNMzFnTG5odVVMQkRXNDBhSFJWVGJGUFQ5T2FPU1d3?=
 =?utf-8?B?NzgrelZUV1ZUb25ZeHZFcFRnWTV4Sy9PTTNDc0o0TkNUYmE4azRHRi90L2lV?=
 =?utf-8?B?SjhrdFA2QjR2akI4U2t6MmFxQVpPcnFnRGJYSzlmQlJjTUVWQmxUcVFXdnhp?=
 =?utf-8?B?eFV0SkUrYUY2WlptS2NXVTA2WFJ1R1J1VVQ2UFpPSmp2eG5TSGZLVUxXd0lX?=
 =?utf-8?B?b3JDbm4ydldnMENtT05wU011aGYzS1FkQk5EbTYremw4WGN6eVR2cTk3R3hQ?=
 =?utf-8?B?STYrTkY3ZUl5WFpHdWowQTlCekNUMlkrYlF4RHFzelRpTWt4ejl0eHBJaE5r?=
 =?utf-8?B?NmtpSmNsbWdTRmd2OG9KVmxack12ZzZiVTlWaDRHUHY3LzN4dXdURXdxa3I4?=
 =?utf-8?B?NHpHYnkrcjFlNENQWlFna09uNC9zckF4WFNjOGl4OEU3QndKYks0SFJ2R1Z0?=
 =?utf-8?B?dHhhNXdnVXNNekZmbHZIVHRwOWZUT1pTNlNzRjRnZktJd0VMWUN1YlRGKytz?=
 =?utf-8?B?OUNucGVkS3ZOWitZOHpaRHhSeHVRdGRSbTYxUVo3QjRDODM1ZnBKMHk2REZ3?=
 =?utf-8?B?UUNsaUd0cWdUeFE5Z2k4K1oveHZ0T2ZJdytWeWlQZVd5WEkxSEZZNWJEZjJF?=
 =?utf-8?B?NGdqcTE2b0tCTUR0Uk5HWVFoLzRPWGZzY2Q3RzBmamI1dXdid2FnOXdwVExS?=
 =?utf-8?B?dFcrMXBESUVtek5GUy9KNzBXaTJEVXdBclhlUXNPb0ZsZnlXRmdlTEVkOXpO?=
 =?utf-8?B?U2Q5eGcvbTd5NE5mSlF6dWtzUEkxdTl5NHpPYURhRjRjaVFCVy9kVGhrY3JF?=
 =?utf-8?B?SFlnbzhtNWZNN2gyeWJDa1g4R0s2M1NwdXpzY2IxZnorVE4wYmZCMmZISDBl?=
 =?utf-8?B?UjBDeWNIcEVqVXlOZzl3dW5USVhzR0lYY2xrV0d3K0xNemxPNDN5bEhZY1Jm?=
 =?utf-8?B?eDZPVlRvWmJ2T1p4REhFOG5UcHBQdG1BRDYrN2JteDNGVXZUbnhQTjJIemFh?=
 =?utf-8?B?aVBZZDVnZU9uUDY5aTdhaFlYTDJZdzFYS0JudHB2NlZ1RzIwUlpVM3hwUkZy?=
 =?utf-8?B?bmp2LzFTWlVuQTJhY1ZGdVFNQWdsNmJxMVRCeTBuMm13elJocm5uNDRQZGVT?=
 =?utf-8?Q?DTpSxZzzTrDh1rYrcUMyeu8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87bcba05-e96e-4656-069e-08d9bb2c1657
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:53:47.8612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hx1LfhPr1sn/dFGEx0DNiBHa19d6i024n0m7M4i+ZlQLkOC2s8aB/wjufVFRP2jzFmU7m8GhmPWDZBSK7WJW3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861

Their calculations of the value to write to the respective command
register can be partly folded, resulting in almost 100 bytes less code
for these two relatively short functions.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -441,7 +441,6 @@ int vtd_flush_context_reg(struct vtd_iom
                           uint16_t source_id, uint8_t function_mask,
                           uint64_t type, bool flush_non_present_entry)
 {
-    u64 val = 0;
     unsigned long flags;
 
     /*
@@ -462,26 +461,26 @@ int vtd_flush_context_reg(struct vtd_iom
     switch ( type )
     {
     case DMA_CCMD_GLOBAL_INVL:
-        val = DMA_CCMD_GLOBAL_INVL;
-        break;
-    case DMA_CCMD_DOMAIN_INVL:
-        val = DMA_CCMD_DOMAIN_INVL|DMA_CCMD_DID(did);
         break;
+
     case DMA_CCMD_DEVICE_INVL:
-        val = DMA_CCMD_DEVICE_INVL|DMA_CCMD_DID(did)
-            |DMA_CCMD_SID(source_id)|DMA_CCMD_FM(function_mask);
+        type |= DMA_CCMD_SID(source_id) | DMA_CCMD_FM(function_mask);
+        fallthrough;
+    case DMA_CCMD_DOMAIN_INVL:
+        type |= DMA_CCMD_DID(did);
         break;
+
     default:
         BUG();
     }
-    val |= DMA_CCMD_ICC;
+    type |= DMA_CCMD_ICC;
 
     spin_lock_irqsave(&iommu->register_lock, flags);
-    dmar_writeq(iommu->reg, DMAR_CCMD_REG, val);
+    dmar_writeq(iommu->reg, DMAR_CCMD_REG, type);
 
     /* Make sure hardware complete it */
     IOMMU_FLUSH_WAIT("context", iommu, DMAR_CCMD_REG, dmar_readq,
-                     !(val & DMA_CCMD_ICC), val);
+                     !(type & DMA_CCMD_ICC), type);
 
     spin_unlock_irqrestore(&iommu->register_lock, flags);
     /* flush context entry will implicitly flush write buffer */
@@ -510,7 +509,7 @@ int vtd_flush_iotlb_reg(struct vtd_iommu
                         bool flush_non_present_entry, bool flush_dev_iotlb)
 {
     int tlb_offset = ecap_iotlb_offset(iommu->ecap);
-    u64 val = 0;
+    uint64_t val = type | DMA_TLB_IVT;
     unsigned long flags;
 
     /*
@@ -524,14 +523,13 @@ int vtd_flush_iotlb_reg(struct vtd_iommu
     switch ( type )
     {
     case DMA_TLB_GLOBAL_FLUSH:
-        val = DMA_TLB_GLOBAL_FLUSH|DMA_TLB_IVT;
         break;
+
     case DMA_TLB_DSI_FLUSH:
-        val = DMA_TLB_DSI_FLUSH|DMA_TLB_IVT|DMA_TLB_DID(did);
-        break;
     case DMA_TLB_PSI_FLUSH:
-        val = DMA_TLB_PSI_FLUSH|DMA_TLB_IVT|DMA_TLB_DID(did);
+        val |= DMA_TLB_DID(did);
         break;
+
     default:
         BUG();
     }



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 16:23:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 16:23:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243175.420569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMC2-00079K-J8; Thu, 09 Dec 2021 16:22:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243175.420569; Thu, 09 Dec 2021 16:22:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMC2-00079D-GA; Thu, 09 Dec 2021 16:22:50 +0000
Received: by outflank-mailman (input) for mailman id 243175;
 Thu, 09 Dec 2021 16:22:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMC1-000793-B2; Thu, 09 Dec 2021 16:22:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMC1-0005SC-7v; Thu, 09 Dec 2021 16:22:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMC0-0007S3-Vf; Thu, 09 Dec 2021 16:22:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMC0-0001bF-V9; Thu, 09 Dec 2021 16:22:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RGuzs8/yraRuh1mU8N1QCZyecxwtZvbD3NUYksZJJqo=; b=dDPgIf8CKQFuf/3yma1VoLnG9T
	xGXGqmkMZj/bnyrXGKifrbycrwwalYUVU9NIFCrbk87iz5aBnXXMD41gTm/uWVgb345hZjEgT08ah
	8x+EXRjhfKEvoehRrojNfkSyQU7E/XE5fy0/FYh57WyxS0BbrwC9LnPDzResXDfy/aKU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167267-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167267: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 16:22:48 +0000

flight 167267 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167267/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 16:58:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 16:58:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243186.420595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMjW-000471-FM; Thu, 09 Dec 2021 16:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243186.420595; Thu, 09 Dec 2021 16:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMjW-00046u-Bx; Thu, 09 Dec 2021 16:57:26 +0000
Received: by outflank-mailman (input) for mailman id 243186;
 Thu, 09 Dec 2021 16:57:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMjU-00046k-RH; Thu, 09 Dec 2021 16:57:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMjU-00060s-LC; Thu, 09 Dec 2021 16:57:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMjU-0008FL-Ei; Thu, 09 Dec 2021 16:57:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMjU-0003aE-EC; Thu, 09 Dec 2021 16:57:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OLc8i78v275RD+MqLgqO8OnYnajZOSHQRlfmiWsfDKY=; b=A02RGS+nvqn6MySikTRC1xv+t1
	D2hMbR0Odf1vPZ2bie+Ihub8Dehs+vymuYagjquL1MekvkHJ/blPCjCnl0jfems/XXP+Bcn9t6G0y
	T1F3FGebCq5fe7Lif9nNx/nGi5CbuqWYpDdkMYGcEDPutzlGeXL908oXmuaNCZkiE1e8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167241-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167241: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
X-Osstest-Versions-That:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 16:57:24 +0000

flight 167241 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167241/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 167236

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167236
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167236
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167236
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167236
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167236
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167236
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167236
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167236
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167236
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167236
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167236
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167236
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87
baseline version:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87

Last test of basis   167241  2021-12-09 09:04:14 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:03:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:03:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243197.420614 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMox-0005eU-Bj; Thu, 09 Dec 2021 17:03:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243197.420614; Thu, 09 Dec 2021 17:03:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMox-0005eN-8P; Thu, 09 Dec 2021 17:03:03 +0000
Received: by outflank-mailman (input) for mailman id 243197;
 Thu, 09 Dec 2021 17:03:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMow-0005eD-4F; Thu, 09 Dec 2021 17:03:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMov-00068s-Uq; Thu, 09 Dec 2021 17:03:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMov-0008Mq-Ni; Thu, 09 Dec 2021 17:03:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMov-0004LR-NF; Thu, 09 Dec 2021 17:03:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=b/Cef2AmQMw75OaL2kFZvEOHbGSEsxahYwBN0j/0x7E=; b=3tz0vZTvCHjuO4FrPzH5iCvvCY
	hhnd1tQ31jZ0/Se3dDEjzjg1rPi3hl9+E0FAK5O75E0zkJCKpnRHCP2OXUouWF4Wd9DqYJdWfKtJj
	xAxOjSl8TjG0cFke/aBW132BicCVN3aNo1g6gBqPcr6m5fjmA7+P8YWXRrk+Mdex5Rvg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167271-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167271: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 17:03:01 +0000

flight 167271 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167271/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:08:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:08:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243203.420629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMuP-0006rC-VV; Thu, 09 Dec 2021 17:08:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243203.420629; Thu, 09 Dec 2021 17:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMuP-0006r5-SH; Thu, 09 Dec 2021 17:08:41 +0000
Received: by outflank-mailman (input) for mailman id 243203;
 Thu, 09 Dec 2021 17:08:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1UJ8=Q2=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mvMuO-0006qy-Rq
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 17:08:40 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a5dd9fbb-5912-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 18:08:39 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5dd9fbb-5912-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639069718;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=hu1ZqT9o16Vi47eUiutfexlW11uIgdieEQGKeg+w63g=;
  b=TyFPZZZriC4AdzDSXJAxPUECAsaIHqaemS9FbRII/w2xj+70EwjV3bsK
   utblMyF/+AgaMCl9uqck8WRw7o6YqGcjOjOOr0zPjehGl/4zaAGjtnhPK
   6VRcQ8jxM1B3Y4g+cnvqwVMx0iUmDwhjcTy8Y9W236rEZ9NfwiBUfWyFP
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: JQN7InQL5tZa7/jUWkllQ6zF0vj4YgYkHlOGkABVpxqnJtk/q/DQqQxhUQ+aqXIe4z2c81wpcC
 Hce43Qr/eVIiFL0hT7XXD7nYaAT/29NKp81jrBScvnIOrburrMcqS5pRs+IIz6lj+f9iyeeH48
 byNH5IIYXJdef55aoyZwFg2NlhVTueYtLBBHYi1YApIMsVCNlLFjjBMHzzyJxLe+THDFMsfWJ9
 yV9bBLbJjUdJveaCTyw/Vhm5KNLEsNKKBLeKaX1Qr1rnudw7FC4+jbiOoVOz6Bc91EkF7IYDQA
 8y5dMmPPCgenRLllYOs8UyTC
X-SBRS: 5.1
X-MesageID: 59675662
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vJtOAqkantmZbYysx0i+Ekvo5gy9IURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJJCzvQP/aLZWHzfdAibIzl8ksCvJSBzYQxTQRt+CAzESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2NY52YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 Ih35IaNYhkoBJXnvsMDdBV6UA9TbIQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQKeAO
 JdHN2AHgBLoeS1vEGs7FMwHpci1h0bHXxdUh3LEuv9ii4TU5FMoi+W8WDbPQfSISt9ShV2wv
 X/d8iLyBRRyHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0BuABCdAR9gC38oHyxBi+CkpHYBMQQYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qXHb4
 xA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSXzLNABum8kfBsyWirhRdMOS
 BWM0T69GbcJZCf6BUOJS9zZ5zsWIVjISo2+C6G8gitmaZltbg6XlByClmbLt10BZHMEyPllU
 b/CKJ7EJS9DVcxPkWrnL89AgORD7n1vmgvuqWXTkk3PPUy2PyXOF9/o8TKmM4gE0U9ziFmPr
 osEaZLVk043vS+XSnC/zLP/5GsidRATba0aYeQOHgJaCgY5SmwnFdHLxrYtJ95sk6hPz7+a9
 XChQE5IjlH4gCSfewmNb3libpLpXIp+8i1nbXB9Yw7w1ihxe5ur4Ycea4AzIest+tt8wKMmV
 PICYciBXKhCE2yV5zQHYJDhh4V+bxD31xmWNi+obWFnLZ5tTgDE4PH+eQ7r+HVcBya7r5Jm8
 bahyhnaUdwIQAE7VJTab/emzlWQu3kBmb0tAxuUc4cLIEi1qdpkMS38iPMzMvogExSby2vIz
 RuSDDcZufLJ/90//u7WiP3WtIyuCeZ/QBZXRjGJ8basOCDG1WO/2oscAv2QdDXQWW6oqqWvY
 eJZk6P1PPEdxQsYtoN9F/BgzL4k5suprLhfl1w2EHLOZlWtK7VhPnjZgpUf6vwTnudU6VmsR
 0aC2thGIrHYasrqHWkYKBchcuneh+ofnSPf7KhtLUj3jMOtEGFrjamG08GwtRFg
IronPort-HdrOrdr: A9a23:qW6W5K2ysbpTu6ROmX3ARAqjBKQkLtp133Aq2lEZdPRUGvb3qy
 nOpoV96faaslYssR0b9exoW5PwJU80l6QFgrX5VI3KNGKN1VdARLsSiLcKqAeAJ8SRzIFgPN
 9bAspDNOE=
X-IronPort-AV: E=Sophos;i="5.88,193,1635220800"; 
   d="scan'208";a="59675662"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
Date: Thu, 9 Dec 2021 17:07:52 +0000
Message-ID: <20211209170752.20576-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

The values are already available in dom->{console,xenstore}_pfn, just like on
the PV side of things.  No need to ask Xen.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
 tools/libs/light/libxl_dom.c | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index c9c24666cd04..03841243ab47 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -722,13 +722,10 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
 }
 
 static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
-                                libxl_domain_build_info *info,
-                                unsigned long *store_mfn,
-                                unsigned long *console_mfn)
+                                libxl_domain_build_info *info)
 {
     struct hvm_info_table *va_hvm;
     uint8_t *va_map, sum;
-    uint64_t str_mfn, cons_mfn;
     int i;
 
     if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
@@ -749,12 +746,6 @@ static int hvm_build_set_params(xc_interface *handle, uint32_t domid,
         munmap(va_map, XC_PAGE_SIZE);
     }
 
-    xc_hvm_param_get(handle, domid, HVM_PARAM_STORE_PFN, &str_mfn);
-    xc_hvm_param_get(handle, domid, HVM_PARAM_CONSOLE_PFN, &cons_mfn);
-
-    *store_mfn = str_mfn;
-    *console_mfn = cons_mfn;
-
     return 0;
 }
 
@@ -1168,12 +1159,14 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid,
     if (rc != 0)
         goto out;
 
-    rc = hvm_build_set_params(ctx->xch, domid, info, &state->store_mfn,
-                              &state->console_mfn);
+    rc = hvm_build_set_params(ctx->xch, domid, info);
     if (rc != 0) {
         LOG(ERROR, "hvm build set params failed");
         goto out;
     }
+
+    state->console_mfn = dom->console_pfn;
+    state->store_mfn = dom->xenstore_pfn;
     state->vuart_gfn = dom->vuart_gfn;
 
     rc = hvm_build_set_xs_values(gc, domid, dom, info);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:10:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:10:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243207.420640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMvd-0007Qa-9Y; Thu, 09 Dec 2021 17:09:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243207.420640; Thu, 09 Dec 2021 17:09:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvMvd-0007QT-6G; Thu, 09 Dec 2021 17:09:57 +0000
Received: by outflank-mailman (input) for mailman id 243207;
 Thu, 09 Dec 2021 17:09:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMvb-0007QI-VX; Thu, 09 Dec 2021 17:09:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMvb-0006G0-Pp; Thu, 09 Dec 2021 17:09:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMvb-0008VM-Je; Thu, 09 Dec 2021 17:09:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvMvb-00052k-J8; Thu, 09 Dec 2021 17:09:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=7QZDeeRcRMQ/y3I7t3KH/GUH0kKvN5H0WalhVolmWAY=; b=Xbjm0ZLu9nwpE4u5bXAXYTUsJG
	XKYHwZfWC7p8EZI/BCPkoAD0MtjoWPWWDS4g+H4+lJB/WbAJwpMIPhi/vdexqRcoma/0jX5Y8WOoM
	FgRCk0xGHTAfCAfii8Tm7og8tmOMC4NyQHqXot15uHH8zaKSGeuN2+3Ky655NyDiTJZo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [ovmf bisection] complete build-i386-xsm
Message-Id: <E1mvMvb-00052k-J8@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 17:09:55 +0000

branch xen-unstable
xenbranch xen-unstable
job build-i386-xsm
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167273/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386-xsm.xen-build --summary-out=tmp/167273.bisection-summary --basis-template=167239 --blessings=real,real-bisect,real-retry ovmf build-i386-xsm xen-build
Searching for failure / basis pass:
 167271 fail [host=huxelrebe0] / 167239 ok.
Failure / basis pass flights: 167271 / 167239
(tree with no url: minios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Basis pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
Generating revisions with ./adhoc-revtuple-generator  https://github.com/tianocore/edk2.git#c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d-06544455d0d460ed18c8582121247bf53292d7e4 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003088b173b0-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#2dd4b9b3f84019668719344b40dba79d681be4\
 1c-2dd4b9b3f84019668719344b40dba79d681be41c git://xenbits.xen.org/xen.git#608531a0cc34a5bc096ccf585e16f182b5ed83e1-c62d634cce8b1507d00a61bfc8168ac42367fe87
Loaded 10001 nodes in revision graph
Searching for test results:
 167239 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167240 fail irrelevant
 167242 [host=huxelrebe1]
 167247 [host=huxelrebe1]
 167253 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167258 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167257 [host=huxelrebe1]
 167259 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167260 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167261 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167262 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167263 pass d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167264 fail f4e3ce5f532860bbcf3a78d38f699dfbff0e1e75 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167265 fail 8eb79b5f4fed31667f27b7ac97b568724fe12496 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167266 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167268 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167267 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167269 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167270 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167271 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167273 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167272 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Searching for interesting versions
 Result found: flight 167239 (pass), for basis pass
 For basis failure, parent search stopping at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55b0fce3e0c8) HASH(0x55b0fce42d00) HASH(0x55b0fce25450) For basis failure, parent search stopping at d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f\
 84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55b0fce36a08) For basis failure, parent search stopping at c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1, results HASH(0x55b0fce26678) HASH(0x55b0fce2e9c0) Result found: flight 167253 (fail), for basis failure (at ancestor ~5226)
 Repro found: flight 167259 (pass), for basis pass
 Repro found: flight 167260 (fail), for basis failure
 0 revisions at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
No revisions left to test, checking graph state.
 Result found: flight 167266 (pass), for last pass
 Result found: flight 167268 (fail), for first failure
 Repro found: flight 167269 (pass), for last pass
 Repro found: flight 167270 (fail), for first failure
 Repro found: flight 167272 (pass), for last pass
 Repro found: flight 167273 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167273/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Revision graph left in /home/logs/results/bisect/ovmf/build-i386-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
167273: tolerable ALL FAIL

flight 167273 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/167273/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-i386-xsm                6 xen-build               fail baseline untested


jobs:
 build-i386-xsm                                               fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:34:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:34:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243220.420662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNJ6-0003GD-7H; Thu, 09 Dec 2021 17:34:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243220.420662; Thu, 09 Dec 2021 17:34:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNJ6-0003G6-4M; Thu, 09 Dec 2021 17:34:12 +0000
Received: by outflank-mailman (input) for mailman id 243220;
 Thu, 09 Dec 2021 17:34:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UPJR=Q2=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvNJ4-0003G0-6Y
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 17:34:10 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 364207fb-5916-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 18:34:08 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:45166)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvNJ1-000V7U-1K (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 09 Dec 2021 17:34:07 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 0B8541FE08;
 Thu,  9 Dec 2021 17:34:07 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 364207fb-5916-11ec-9d12-4777fae47e2b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <736f40e4-0297-ba7b-abce-c9b67ad8eb31@srcf.net>
Date: Thu, 9 Dec 2021 17:34:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-2-andrew.cooper3@citrix.com>
 <dc3f5bf2-53f9-7dcd-2be7-f9f953b382cb@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 1/3] x86/boot: Drop pte_update_limit from physical
 relocation logic
In-Reply-To: <dc3f5bf2-53f9-7dcd-2be7-f9f953b382cb@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 07/12/2021 11:37, Jan Beulich wrote:
> On 07.12.2021 11:53, Andrew Cooper wrote:
>> This check has existed in one form or another since c/s 369bafdb1c1 "xen: Big
>> changes to x86 start-of-day" in 2007.  Even then, AFAICT, it wasn't necessary
>> because there was a clean split between the statically created entries (L3 and
>> higher) and the dynamically created ones (L2 and lower).
>>
>> Without dissecting the myriad changes over the past 14 years, I'm pretty
>> certain Xen only booted by accident when l2_xenmap[0] was handled specially
>> and skipped the pte_update_limit check which would have left it corrupt.
>>
>> Nevertheless, as of right now, all non-leaf PTEs (the first loop), and all 2M
>> xenmap leaf mappings (the second loop) need relocating.  They are no unused
>> mappings in the range, no mappings which will be encountered multiple times,
>> and it is unlikely that such mappings would be introduced.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> However, as to the description and ...
>
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -1230,7 +1230,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>              l3_pgentry_t *pl3e;
>>              l2_pgentry_t *pl2e;
>>              int i, j, k;
>> -            unsigned long pte_update_limit;
>>  
>>              /* Select relocation address. */
>>              xen_phys_start = end - reloc_size;
>> @@ -1238,14 +1237,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>              bootsym(trampoline_xen_phys_start) = xen_phys_start;
>>  
>>              /*
>> -             * No PTEs pointing above this address are candidates for relocation.
>> -             * Due to possibility of partial overlap of the end of source image
>> -             * and the beginning of region for destination image some PTEs may
>> -             * point to addresses in range [e, e + XEN_IMG_OFFSET).
>> -             */
>> -            pte_update_limit = PFN_DOWN(e);
> ... considering the comment here: Isn't it 0d31d1680868 ("x86/setup: do
> not relocate Xen over current Xen image placement") where need for this
> disappeared? Afaict the non-overlap of source and destination is the
> crucial factor here, yet your description doesn't mention this aspect at
> all. I'd therefore like to ask for an adjustment there.

I don't consider that commit relevant.

There is no circumstance ever where you can relocate Xen with
actually-overlapping ranges, because one way or another, you'd end up
copying non-pagetable data over the live pagetables.

That particular commit was part of trying to make Xen's entry code
relocatable, so the MB2 path could load Xen at somewhere which wasn't 0,
but to this day we still skip any physical relocation if Xen isn't
started at 0.


To the comment specifically, it's actively wrong.

Back when XEN_IMG_OFFSET was 1M, and we had 16M worth of unconditional
mappings, then we could get PTE overlap as described, in the corner case
where we were moving Xen from 0 to anywhere between 4 and 16M physical
(2M physical was in principle a problem, but not an eligible position to
relocate to, given Xen's compile size).

And in that corner case, the logic would "corrupt" various PTEs by not
relocating them.  The PTE coving _start at 1M was special cased ahead of
the 2nd loop (finally fixed last week) and the PTEs mapping beyond _end
were unused which is why nothing actually went wrong.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:53:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:53:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243230.420680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNby-0006jH-Sj; Thu, 09 Dec 2021 17:53:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243230.420680; Thu, 09 Dec 2021 17:53:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNby-0006jA-PD; Thu, 09 Dec 2021 17:53:42 +0000
Received: by outflank-mailman (input) for mailman id 243230;
 Thu, 09 Dec 2021 17:53:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PaQb=Q2=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvNby-0006j4-2O
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 17:53:42 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0d685c7-5918-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 18:53:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0d685c7-5918-11ec-9d12-4777fae47e2b
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639072418;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=f/BG5QfqwWEb1VV/DgxhiFZ4nhZE79+Y1nkN0PAhNpQ=;
	b=kjE+xJbt1HY/8HBJlMzR3KY5f257GXq6wQiCb4ielSBtggUniQ1I3lNNdnraOwg0GEpMfu
	syIRikUXoAagvFD10A7VC8fdLi5KNDe8FVpgjdz238ahh5ThXTk0ftjn4sLjev21WbVmwN
	UdtH1rl6SMpGB3hFuvBYPFDDfZmvU6R1CRdrxcp40TncFcDN6uf+hzRVH9isczKiB43Nqg
	eOi5ptsv0tQWvH/JkuarfQxl1jTA329ul6SL57nsoRBvTSUj8ex83rJhKPX7X7TnTrq8uZ
	kYfRHVatnPWdhfVHrcCL0ZVnQkiJkHbcO3adPxb/1ct6S7VsxFetMxXinWNn4g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639072418;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=f/BG5QfqwWEb1VV/DgxhiFZ4nhZE79+Y1nkN0PAhNpQ=;
	b=W9fJDkfc99g7IIQhAnrz13+8F5imCs058D17+luFpISF83qVBUish7Usu7wFw9FwF+6ZoR
	uTKOefgne5k+wzAQ==
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>, iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
 <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
In-Reply-To: <20211208155816.GZ6385@nvidia.com>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.688216619@linutronix.de>
 <20211208155816.GZ6385@nvidia.com>
Date: Thu, 09 Dec 2021 18:53:37 +0100
Message-ID: <87k0gdzmu6.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Dec 08 2021 at 11:58, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
>> Store the properties which are interesting for various places so the MSI
>> descriptor fiddling can be removed.
>> 
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> V2: Use the setter function
>> ---
>>  drivers/pci/msi/msi.c |    8 ++++++++
>>  1 file changed, 8 insertions(+)
>
> I took more time to look at this, to summarize my remarks on the other
> patches
>
> I think we don't need properties. The info in the msi_desc can come
> from the pci_dev which we have easy access to. This seems overall
> clearer

I fixed that now.

> The notable one is the sysfs, but that is probably better handled by
> storing a
>
>   const char *sysfs_label
>
> in the dev->msi and emitting that instead of computing it.

I just compute is for now via is_pci_dev() and
to_pci_dev()->msi_enabled.

We are still debating to remove the whole thing completely.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 17:57:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 17:57:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243236.420691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNfg-0007t5-Cb; Thu, 09 Dec 2021 17:57:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243236.420691; Thu, 09 Dec 2021 17:57:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvNfg-0007sy-9Q; Thu, 09 Dec 2021 17:57:32 +0000
Received: by outflank-mailman (input) for mailman id 243236;
 Thu, 09 Dec 2021 17:57:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvNff-0007so-6F; Thu, 09 Dec 2021 17:57:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvNff-00072i-0g; Thu, 09 Dec 2021 17:57:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvNfe-00017t-QA; Thu, 09 Dec 2021 17:57:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvNfe-0001Y6-Pc; Thu, 09 Dec 2021 17:57:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HAen+yF5CKYIMjWXyEaD0GCNC2C6xamMkQHONfYpxTw=; b=E/xGIL0mDa344VazmV5ma5Z7Zv
	NoeS2qX0VlLi/m3wdQ6mcYP3cbhA0/bQsQIbLRuBdvabazTT01IkWFPdjx06KPISQuam3xy7pJ9/5
	X3YdMb0bQrIqj81ladEijBQGpXyaBI3k832UNuGGHo+jeMlkVE8dhmAezMnXA0lxcbQ8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167275-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167275: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 17:57:30 +0000

flight 167275 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167275/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 18:30:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 18:30:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243249.420722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvOAf-0004QR-W5; Thu, 09 Dec 2021 18:29:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243249.420722; Thu, 09 Dec 2021 18:29:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvOAf-0004QK-T8; Thu, 09 Dec 2021 18:29:33 +0000
Received: by outflank-mailman (input) for mailman id 243249;
 Thu, 09 Dec 2021 18:29:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOAf-0004QA-5K; Thu, 09 Dec 2021 18:29:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOAe-0007eG-V5; Thu, 09 Dec 2021 18:29:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOAe-0001oQ-N0; Thu, 09 Dec 2021 18:29:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOAe-0001Qu-MX; Thu, 09 Dec 2021 18:29:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GXBg+WCoxwedp5aEs0NRL5oBjQ7yVOSLKpJfFtNNi7c=; b=B2drUwrkZjjhhKBfW5ucZLzCwY
	BE+D2uwsi8MfHmc20v33wakq8mpEI7Hw+iSDU/c7BfvXsJj7E1Q4igzENP6XrncKq9jN+Sb3KyVRx
	sAqy2tNZeKcmxd0p3BV/MUsrsEaq6dpnpOp6Rg2lrpFqMJVm8AnEYnXdem/xOlKavTt0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167279-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167279: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 18:29:32 +0000

flight 167279 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167279/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 19:06:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 19:06:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243260.420748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvOjM-0001fn-SD; Thu, 09 Dec 2021 19:05:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243260.420748; Thu, 09 Dec 2021 19:05:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvOjM-0001fg-P8; Thu, 09 Dec 2021 19:05:24 +0000
Received: by outflank-mailman (input) for mailman id 243260;
 Thu, 09 Dec 2021 19:05:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOjL-0001fW-RW; Thu, 09 Dec 2021 19:05:23 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOjL-0008GE-I2; Thu, 09 Dec 2021 19:05:23 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOjL-0002aI-AT; Thu, 09 Dec 2021 19:05:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvOjL-0002bh-A0; Thu, 09 Dec 2021 19:05:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=pPT3hykvu2EsQfeVP+vvIKY7bfveSbT7Wr759qMmX/M=; b=tGBsMnlhD5arkOj3nsJtsbk1i2
	TYA0yRUE+6P0tV2XGLnQKpFoTYrUbNUS9AWw7hZKJ75gBOvvXYnGpf2ek9bObGMqncQRksmcspcuT
	a/kopxPO7Gb7zV58ckhSZY3fVZ6hJiSHdky3yIFzoSrfOKb+WKYEqh+m2aisHYQN9Uzo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167283-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167283: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 19:05:23 +0000

flight 167283 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167283/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 19:29:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 19:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243268.420762 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvP6J-0005ff-Pv; Thu, 09 Dec 2021 19:29:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243268.420762; Thu, 09 Dec 2021 19:29:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvP6J-0005fY-Ms; Thu, 09 Dec 2021 19:29:07 +0000
Received: by outflank-mailman (input) for mailman id 243268;
 Thu, 09 Dec 2021 19:29:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvP6I-0005fO-HR; Thu, 09 Dec 2021 19:29:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvP6I-0000D4-A2; Thu, 09 Dec 2021 19:29:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvP6I-00036M-1a; Thu, 09 Dec 2021 19:29:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvP6I-00084A-15; Thu, 09 Dec 2021 19:29:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MZoweFmzinvMpqRZ/ndJnZJ6xZ5Sg3m/sY42Ca3C/rM=; b=XOU3/lmAa8krN7VY2nC+hqik4s
	WH7m2nxsX2diHzMl2uL7y7T8xp/2ENWT+nxpOqcaagWKshXvBTKI+lvHZZdpg5t0LsKZuHp7x0uQi
	SW4oYpzLEzS1cydDdmzRlxWxQDInzPa1qcox7asCObWByVEcMIKi2ePHo6R5SZTZ8ddo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167285-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167285: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 19:29:06 +0000

flight 167285 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167285/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 19:59:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 19:59:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243280.420789 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPYu-000288-75; Thu, 09 Dec 2021 19:58:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243280.420789; Thu, 09 Dec 2021 19:58:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPYu-000281-3i; Thu, 09 Dec 2021 19:58:40 +0000
Received: by outflank-mailman (input) for mailman id 243280;
 Thu, 09 Dec 2021 19:58:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=UPJR=Q2=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvPYs-00027t-Of
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 19:58:38 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 64487aa4-592a-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 20:58:36 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:41444)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvPYp-000U5I-mQ (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 09 Dec 2021 19:58:35 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CD08F1FD51;
 Thu,  9 Dec 2021 19:58:34 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64487aa4-592a-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <becdcf55-51fb-0b62-6b34-d5c790b7d238@srcf.net>
Date: Thu, 9 Dec 2021 19:58:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-3-andrew.cooper3@citrix.com>
 <81893ccf-6b94-ddc7-d92b-f254861fe994@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 2/3] x86/boot: Drop move_memory() and use memcpy()
 directly
In-Reply-To: <81893ccf-6b94-ddc7-d92b-f254861fe994@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 07/12/2021 12:03, Jan Beulich wrote:
> On 07.12.2021 11:53, Andrew Cooper wrote:
>> @@ -1243,7 +1196,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>               * data until after we have switched to the relocated pagetables!
>>               */
>>              barrier();
>> -            move_memory(e, XEN_IMG_OFFSET, _end - _start, 1);
>> +            memcpy(__va(__pa(_start)), _start, _end - _start);
>>  
>>              /* Walk idle_pg_table, relocating non-leaf entries. */
>>              pl4e = __va(__pa(idle_pg_table));
>> @@ -1300,8 +1253,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>                     "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
>>                  : "memory" );
>>  
>> -            bootstrap_map(NULL);
>> -
>>              printk("New Xen image base address: %#lx\n", xen_phys_start);
>>          }
> This bootstrap_map() must have been dead code already before, except
> for the "keep" argument above needlessly having got passed as 1? Afaict
> passing 1 was pointless without using the function's return value.

bootstrap_map(NULL) is necessary to zap the constructed mappings, but it
seems like the use of the return address was dropped by c/s 0b76ce20de
"x86/setup: don't relocate the VGA hole" in 2013.

>
>> @@ -1325,9 +1276,10 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>                   (headroom ||
>>                    ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) )
>>              {
>> -                move_memory(end - size + headroom,
>> -                            (uint64_t)mod[j].mod_start << PAGE_SHIFT,
>> -                            mod[j].mod_end, 0);
>> +                memcpy(__va(end - size + headroom),
>> +                       __va((uint64_t)mod[j].mod_start << PAGE_SHIFT),
>> +                       mod[j].mod_end);
> I'm not convinced this can be memcpy() - consider_modules() specifically
> allows for the current module's source and destination areas to overlap.
> See also the comment ahead of its invocation a few lines up from here.

The comment which says:

/* Don't overlap with other modules (or Xen itself). */
end = consider_modules(s, e, size, mod,
                       mbi->mods_count + relocated, j);

?

memmove() in move_memory() is broken, and in fact always results in a
backwards copy, which means that one way or another, overlapping source
and destination doesn't work.

If it was really broken before, then it can be fixed now by using
memmove() here, because using 2 directmap mappings means the
forward/backward check will now work as expected.

> I'm also not convinced we have the source range (fully) direct-mapped at
> this point. Only full superpages have been mapped so far, and only those
> for the current or higher address E820 entries (plus of course the pre-
> built mappings of the space below 1Gb [PREBUILT_MAP_LIMIT]) located
> below 4Gb.

PREBUILT_MAP_LIMIT is 2M, and that's only to cover the fact that we
build l1_directmap[] with the VGA UC range at build time.  I was hoping
to remove it in due course.

As to the other mappings, that is awkward.  Perhaps what we ought to do
is split the loops.  First fill in all 2M superpages into the directmap,
then relocate Xen, at which point we've got plenty of frames to feed
into the allocator, to let us do a second pass filling in non-2M regions.

We can depend on the modules living in RAM regions, but might want to
explicitly confirm.

> As to the 2nd argument - if this can indeed be converted in the first
> place, may I suggest to also switch to using pfn_to_paddr()?

Honestly, that's taking a terrible situation and making it worse.

Calling pfn_to_paddr() on what is logically a paddr_t already ought to
be a compilation error, and the logic which makes this change
deliberately is some of the most nack-worthy logic I've ever come across.

It's very much not ok to have mod_start be a paddr or pfn, and for
mod_end to either be an end or a sized, epending on where you are during
boot.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243312.420922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfo-0005cN-V5; Thu, 09 Dec 2021 20:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243312.420922; Thu, 09 Dec 2021 20:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfo-0005bT-Ny; Thu, 09 Dec 2021 20:05:48 +0000
Received: by outflank-mailman (input) for mailman id 243312;
 Thu, 09 Dec 2021 20:05:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfm-0004Xc-PU
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:46 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 653c11a9-592b-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 21:05:45 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id cf39so2064278lfb.8
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:45 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.44
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 653c11a9-592b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=wUGrgrAhSp00M+b8z9JNtCABbdhrenjEQ9qiU7Kp+fE=;
        b=jWc9wxTYHdqYtFuA3EuCo7h3BpGS363+/BKxA5rQ3cK7v9JSmq+KDfWhMZ5nxffD78
         O+IAzxYsXqzcb4CpKQY3zvXEk3wabMycLoHM9HUVF0hv4sKedWBrOhTj4sxrjCk6OJLh
         2+5G4UMZ/DjD3K/ziMUEaEqkRprnYXh3SXr2zvFaOq/i6MZFzIWUFiC1if1dSuQsK3cB
         CsXMX7/5EaA5BLRTg+uda1C7EO5EitsbsN0mrbjVq2jH/IFyO6W/DXUNmA4Onw0OfyXl
         apoUCgdr6WTP+ko9G865vRawOTkNbQD4tDoeuqB+jjE5fERhUWBrFAtoGThXNyt0eDR1
         UUTA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=wUGrgrAhSp00M+b8z9JNtCABbdhrenjEQ9qiU7Kp+fE=;
        b=IIF4EkZoxbUILk72XBhG9B0mUWQHNUk4th2p5gtXgu3+JA92hjn5YA8/nV1VQEtr5N
         oKAc+7pzZQ5hZ92/P2YjEzypWnxcTJ9vkpUlr4oXwDd1BaPuZS+ZQVmRVDxsIZJvIDu0
         J5Fe8Bm//bfsPdYfYDFDlPjobk8kzN0PZvD0Jff1hvY2ZKTeQb3GA0El1bannE/ctkCP
         zIHvzCD8YJDk/czFZo3/Kx2LC9sGFWQDrSHLydC31RNsK5u8T8QbhwcJ8dooPZAbEeBq
         gT5Wmry+I5B/xoo/bK3FwIj47WR5HbrTGRB1urk0dgRMNZwEYrFUQi5Aa3iip/skdzvH
         nyQQ==
X-Gm-Message-State: AOAM530wZ59Cv7cGiN/1m57t8tDVa+Wow2NfNIvJrbH2Z/vC4FZSwRYa
	mumV6G7eAUjgSqLD5kDToOQN1HNLQOPcAA==
X-Google-Smtp-Source: ABdhPJwxNCCMm538u0QAdLmoN2XRwAivi00DvNgNn4UUQkZeWmYpD/N/YdNzX3nmLM69YRGUxPGnEw==
X-Received: by 2002:a05:6512:3d16:: with SMTP id d22mr7845851lfv.523.1639080345433;
        Thu, 09 Dec 2021 12:05:45 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 4/6] xen/unpopulated-alloc: Add mechanism to use Xen resource
Date: Thu,  9 Dec 2021 22:05:34 +0200
Message-Id: <1639080336-26573-5-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

The main reason of this change is that unpopulated-alloc
code cannot be used in its current form on Arm, but there
is a desire to reuse it to avoid wasting real RAM pages
for the grant/foreign mappings.

The problem is that system "iomem_resource" is used for
the address space allocation, but the really unallocated
space can't be figured out precisely by the domain on Arm
without hypervisor involvement. For example, not all device
I/O regions are known by the time domain starts creating
grant/foreign mappings. And following the advise from
"iomem_resource" we might end up reusing these regions by
a mistake. So, the hypervisor which maintains the P2M for
the domain is in the best position to provide unused regions
of guest physical address space which could be safely used
to create grant/foreign mappings.

Introduce new helper arch_xen_unpopulated_init() which purpose
is to create specific Xen resource based on the memory regions
provided by the hypervisor to be used as unused space for Xen
scratch pages. If arch doesn't define arch_xen_unpopulated_init()
the default "iomem_resource" will be used.

Update the arguments list of allocate_resource() in fill_list()
to always allocate a region from the hotpluggable range
(maximum possible addressable physical memory range for which
the linear mapping could be created). If arch doesn't define
arch_get_mappable_range() the default range (0,-1) will be used.

The behaviour on x86 won't be changed by current patch as both
arch_xen_unpopulated_init() and arch_get_mappable_range()
are not implemented for it.

Also fallback to allocate xenballooned pages (balloon out RAM
pages) if we do not have any suitable resource to work with
(target_resource is invalid) and as the result we won't be able
to provide unpopulated pages on a request.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes RFC -> V2:
   - new patch, instead of
    "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"

Changes V2 -> V3:
   - update patch description and comments in code
   - modify arch_xen_unpopulated_init() to pass target_resource as an argument
     and update default helper to assign iomem_resource to it, also drop
     xen_resource as it will be located in arch code in the future
   - allocate region from hotpluggable range instead of hardcoded range (0,-1)
     in fill_list()
   - use %pR specifier in error message
   - do not call unpopulated_init() at runtime from xen_alloc_unpopulated_pages(),
     drop an extra helper and call arch_xen_unpopulated_init() directly from __init()
   - include linux/ioport.h instead of forward declaration of struct resource
   - replace insert_resource() with request_resource() in fill_list()
   - add __init specifier to arch_xen_unpopulated_init()

Changes V3 -> V4:
   - add Stefano's R-b
   - fix copy-paste error in fill_list(), must be "if (!tmp_res)" instead of
     "if (!res)" in string 66
   - add unpopulated_init() with early initcall level specifically to call
     arch_xen_unpopulated_init()
---
 drivers/xen/unpopulated-alloc.c | 86 +++++++++++++++++++++++++++++++++++++++--
 include/xen/xen.h               |  2 +
 2 files changed, 84 insertions(+), 4 deletions(-)

diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
index a03dc5b..a8b4105 100644
--- a/drivers/xen/unpopulated-alloc.c
+++ b/drivers/xen/unpopulated-alloc.c
@@ -8,6 +8,7 @@
 
 #include <asm/page.h>
 
+#include <xen/balloon.h>
 #include <xen/page.h>
 #include <xen/xen.h>
 
@@ -15,13 +16,29 @@ static DEFINE_MUTEX(list_lock);
 static struct page *page_list;
 static unsigned int list_count;
 
+static struct resource *target_resource;
+
+/*
+ * If arch is not happy with system "iomem_resource" being used for
+ * the region allocation it can provide it's own view by creating specific
+ * Xen resource with unused regions of guest physical address space provided
+ * by the hypervisor.
+ */
+int __weak __init arch_xen_unpopulated_init(struct resource **res)
+{
+	*res = &iomem_resource;
+
+	return 0;
+}
+
 static int fill_list(unsigned int nr_pages)
 {
 	struct dev_pagemap *pgmap;
-	struct resource *res;
+	struct resource *res, *tmp_res = NULL;
 	void *vaddr;
 	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
-	int ret = -ENOMEM;
+	struct range mhp_range;
+	int ret;
 
 	res = kzalloc(sizeof(*res), GFP_KERNEL);
 	if (!res)
@@ -30,14 +47,40 @@ static int fill_list(unsigned int nr_pages)
 	res->name = "Xen scratch";
 	res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
 
-	ret = allocate_resource(&iomem_resource, res,
-				alloc_pages * PAGE_SIZE, 0, -1,
+	mhp_range = mhp_get_pluggable_range(true);
+
+	ret = allocate_resource(target_resource, res,
+				alloc_pages * PAGE_SIZE, mhp_range.start, mhp_range.end,
 				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
 	if (ret < 0) {
 		pr_err("Cannot allocate new IOMEM resource\n");
 		goto err_resource;
 	}
 
+	/*
+	 * Reserve the region previously allocated from Xen resource to avoid
+	 * re-using it by someone else.
+	 */
+	if (target_resource != &iomem_resource) {
+		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
+		if (!tmp_res) {
+			ret = -ENOMEM;
+			goto err_insert;
+		}
+
+		tmp_res->name = res->name;
+		tmp_res->start = res->start;
+		tmp_res->end = res->end;
+		tmp_res->flags = res->flags;
+
+		ret = request_resource(&iomem_resource, tmp_res);
+		if (ret < 0) {
+			pr_err("Cannot request resource %pR (%d)\n", tmp_res, ret);
+			kfree(tmp_res);
+			goto err_insert;
+		}
+	}
+
 	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
 	if (!pgmap) {
 		ret = -ENOMEM;
@@ -95,6 +138,11 @@ static int fill_list(unsigned int nr_pages)
 err_memremap:
 	kfree(pgmap);
 err_pgmap:
+	if (tmp_res) {
+		release_resource(tmp_res);
+		kfree(tmp_res);
+	}
+err_insert:
 	release_resource(res);
 err_resource:
 	kfree(res);
@@ -112,6 +160,14 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 	unsigned int i;
 	int ret = 0;
 
+	/*
+	 * Fallback to default behavior if we do not have any suitable resource
+	 * to allocate required region from and as the result we won't be able to
+	 * construct pages.
+	 */
+	if (!target_resource)
+		return xen_alloc_ballooned_pages(nr_pages, pages);
+
 	mutex_lock(&list_lock);
 	if (list_count < nr_pages) {
 		ret = fill_list(nr_pages - list_count);
@@ -159,6 +215,11 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 {
 	unsigned int i;
 
+	if (!target_resource) {
+		xen_free_ballooned_pages(nr_pages, pages);
+		return;
+	}
+
 	mutex_lock(&list_lock);
 	for (i = 0; i < nr_pages; i++) {
 		pages[i]->zone_device_data = page_list;
@@ -201,3 +262,20 @@ static int __init init(void)
 }
 subsys_initcall(init);
 #endif
+
+static int __init unpopulated_init(void)
+{
+	int ret;
+
+	if (!xen_domain())
+		return -ENODEV;
+
+	ret = arch_xen_unpopulated_init(&target_resource);
+	if (ret) {
+		pr_err("xen:unpopulated: Cannot initialize target resource\n");
+		target_resource = NULL;
+	}
+
+	return ret;
+}
+early_initcall(unpopulated_init);
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 86c5b37..a99bab8 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -55,6 +55,8 @@ extern u64 xen_saved_max_mem_size;
 #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
 int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
+#include <linux/ioport.h>
+int arch_xen_unpopulated_init(struct resource **res);
 #else
 #include <xen/balloon.h>
 static inline int xen_alloc_unpopulated_pages(unsigned int nr_pages,
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243310.420900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfm-00053k-9t; Thu, 09 Dec 2021 20:05:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243310.420900; Thu, 09 Dec 2021 20:05:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfm-00052l-5i; Thu, 09 Dec 2021 20:05:46 +0000
Received: by outflank-mailman (input) for mailman id 243310;
 Thu, 09 Dec 2021 20:05:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfl-0004Xd-7o
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:45 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6416bcb1-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:05:44 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id 207so10646554ljf.10
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:44 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.42
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:42 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6416bcb1-592b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=XoEU3DaXUqalCs6jzwcHq5Z2kR7REX3RsrqKMfGCo2w=;
        b=GlM2t+eQRjThRQMjBZpSdxLnDWzEbjJWVwRDusOaEx3MeX4FketF3biTqFzeEnAVU0
         VhfKGEcuQp52HiEpPpvacBbuQwd87JvMTehJYvdAXf7KeOioUXb3WO3fCLID1qKZ7UBZ
         UTgdjk7vrs0SFE8l7HuLKFHyLrmDTcAD9cNMgKBWyA2U3xnLfBw1azVxQh+7gf79/OoO
         1dQ4RbzOz6pbkTfeB0WK3PC7JrQpMMkPLByBqimCV2s9g1epLNijcmYesEuTP320tf69
         StZYm2luPMAgllAQQSpglOUobSo4Wx1O+YEknSkfIltx1nSkiZfvAJ+J+cQWzBjsQ1vZ
         FzVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=XoEU3DaXUqalCs6jzwcHq5Z2kR7REX3RsrqKMfGCo2w=;
        b=2gsRIBCqHKT/MQJ+AGEqyzsUvN9ndHp/Ghtd1RPgTS7CJGvbWPMBnEnL5xedea/719
         J8sbIBqCBWni2jUjFMkeM9Lxopj49/uxDWNJlyEko8HwAjd6wo7BIDhHfNtC8MQaUBlZ
         ONdGtsObBQnj01OWF+Wd2EU9Jh7qFfyZ4r/byzznVkGvvqGYJOUDDd0IgcJYsaARLKji
         JT5jdqR4irb2XyMmj29cJSZ/8KQnCh7nfujNNOosWzXiMgkDhbJiVML3dGHLh3tYWo46
         E/LyPzijMDwkla9U/6WI4fEldfmrXHoEocPkjjoqDSFJZKjlR9SK0c7kmDzdsMbeVAFK
         hY1Q==
X-Gm-Message-State: AOAM5327OMK+6wQKZFXiuTHSMfhwoXlXrLrJ5x0veBDttf7PMoQS+XI3
	oJYrwS67kITD5znvQ44PRO4A9NSicNvKPw==
X-Google-Smtp-Source: ABdhPJwRwGnN2HYDLn4/ya4vANtMy2LFN1OiYbe33DChi+j/uEDELzNOeHtrWCUSzf5Mr+Zxr7NNrA==
X-Received: by 2002:a2e:8ec7:: with SMTP id e7mr8517097ljl.430.1639080343851;
        Thu, 09 Dec 2021 12:05:43 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 2/6] arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
Date: Thu,  9 Dec 2021 22:05:32 +0200
Message-Id: <1639080336-26573-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Read the start address of the grant table space from DT
(region 0).

This patch mostly restores behaviour before commit 3cf4095d7446
("arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table")
but trying not to break the ACPI support added after that commit.
So the patch touches DT part only and leaves the ACPI part with
xen_xlate_map_ballooned_pages(). Also in order to make a code more
resilient use a fallback to xen_xlate_map_ballooned_pages() if grant
table region wasn't found.

This is a preparation for using Xen extended region feature
where unused regions of guest physical address space (provided
by the hypervisor) will be used to create grant/foreign/whatever
mappings instead of wasting real RAM pages from the domain memory
for establishing these mappings.

The immediate benefit of this change:
- Avoid superpage shattering in Xen P2M when establishing
  stage-2 mapping (GFN <-> MFN) for the grant table space
- Avoid wasting real RAM pages (reducing the amount of memory
  usuable) for mapping grant table space
- The grant table space is always mapped at the exact
  same place (region 0 is reserved for the grant table)

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes RFC -> V2:
   - new patch

Changes V2 -> V3:
   - add __read_mostly specifier to xen_grant_frames
   - retain a fallback to xen_xlate_map_ballooned_pages() if
     xen_grant_frames is invalid
   - process xen_events_irq before xen_grant_frames in
     xen_dt_guest_init()
   - update patch description

Changes V3 -> V4:
   - add Stefano's R-b
   - remove first condition in "if (!acpi_disabled || !xen_grant_frames)"
---
 arch/arm/xen/enlighten.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 7619fbf..49bb675 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -59,6 +59,9 @@ unsigned long xen_released_pages;
 struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS] __initdata;
 
 static __read_mostly unsigned int xen_events_irq;
+static __read_mostly phys_addr_t xen_grant_frames;
+
+#define GRANT_TABLE_INDEX   0
 
 uint32_t xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
@@ -303,6 +306,7 @@ static void __init xen_acpi_guest_init(void)
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
+	struct resource res;
 
 	xen_node = of_find_compatible_node(NULL, NULL, "xen,xen");
 	if (!xen_node) {
@@ -311,13 +315,19 @@ static void __init xen_dt_guest_init(void)
 	}
 
 	xen_events_irq = irq_of_parse_and_map(xen_node, 0);
+
+	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
+		pr_err("Xen grant table region is not found\n");
+		return;
+	}
+	xen_grant_frames = res.start;
 }
 
 static int __init xen_guest_init(void)
 {
 	struct xen_add_to_physmap xatp;
 	struct shared_info *shared_info_page = NULL;
-	int cpu;
+	int rc, cpu;
 
 	if (!xen_domain())
 		return 0;
@@ -370,12 +380,16 @@ static int __init xen_guest_init(void)
 	for_each_possible_cpu(cpu)
 		per_cpu(xen_vcpu_id, cpu) = cpu;
 
-	xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
-	if (xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
-					  &xen_auto_xlat_grant_frames.vaddr,
-					  xen_auto_xlat_grant_frames.count)) {
+	if (!xen_grant_frames) {
+		xen_auto_xlat_grant_frames.count = gnttab_max_grant_frames();
+		rc = xen_xlate_map_ballooned_pages(&xen_auto_xlat_grant_frames.pfn,
+										   &xen_auto_xlat_grant_frames.vaddr,
+										   xen_auto_xlat_grant_frames.count);
+	} else
+		rc = gnttab_setup_auto_xlat_frames(xen_grant_frames);
+	if (rc) {
 		free_percpu(xen_vcpu_info);
-		return -ENOMEM;
+		return rc;
 	}
 	gnttab_init();
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243311.420911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfn-0005LD-I9; Thu, 09 Dec 2021 20:05:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243311.420911; Thu, 09 Dec 2021 20:05:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfn-0005Ka-E2; Thu, 09 Dec 2021 20:05:47 +0000
Received: by outflank-mailman (input) for mailman id 243311;
 Thu, 09 Dec 2021 20:05:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfl-0004Xd-VB
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:45 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 647a245a-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:05:44 +0100 (CET)
Received: by mail-lf1-x135.google.com with SMTP id cf39so2064200lfb.8
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:45 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.43
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:44 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 647a245a-592b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=S5p+2FMTZ9me3f7MgyffrybzDu1cB0H0WkSIssxF4tQ=;
        b=L+12IgIWe9epXxHZEYZ6HgwZbTEbj/L3wLIDxUpfg2E1xfGiWQMCwOe4aBrheOaE0z
         wACfBvNIMkXEf+nya8oleo9e8liD3Up08GRb4Pf37/nVLwjUKrMltKBaKTIRQizuPTHa
         kiB2eeFQVyRO63kGFUo/eHdq51GIFL/uNXEQrwXCo/A+hV/HCtFwDoXNyGsTEKlu6OmK
         enU+r1Tg1ZYL1MEeX5Ui3wMAW53n6E8DRTyEXCbfwpJxJDVvdGA6r445ekgReyO47/KG
         4eMBCsKkqlUsop0XMggtfAv6ao4oSO6uuSiJshxVb2O+ztOTDIWehgeVPb4vaQXzfM9s
         kn+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=S5p+2FMTZ9me3f7MgyffrybzDu1cB0H0WkSIssxF4tQ=;
        b=tFJd13PsjAUFPt9h9emw15BStdFKsoSBlLX3SgRnz8R5jk3L/BVZunpfJDB0OMoZ52
         uRGp501JinsTfqNCKeML3TnKDH20xn9FWRDRG5dHbCmPaJNMX0QgosFLCOwkx/oMWiBS
         4kuuEdif2FuJnRS/cbQg005PPM3H94QhQktb1vkEiI7nlvR7Jx6zk2OxWSpDiZEVtlzC
         rf9q+87Lq3FV0l5vmENgosxSTIE49r1c6EjfADOKuTM0iacpHllDBBhEKducH61B3A69
         smlB2zCy9IRUcur4n/ZwHgAPHcgLqAhTgxk7OTLVSo0GaR6VOyEde8Zsha/ARDSrrwKK
         41Rw==
X-Gm-Message-State: AOAM533wcbM9mrkRB9AY+C0DKt/Kw0XaQ46kVWa394rYNLDW4X23RpYR
	aiqJxr5Vr4CNbfHulZg3vJbpxau82l9+dQ==
X-Google-Smtp-Source: ABdhPJzXmNpIc4USAluGA5qsH7ufiWxU3sy77PqmbLRlZ2c4zMxbHDRyt5AvEYyGUnPsWWW7TFMqdg==
X-Received: by 2002:a05:6512:3052:: with SMTP id b18mr8189605lfb.424.1639080344638;
        Thu, 09 Dec 2021 12:05:44 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 3/6] xen/balloon: Bring alloc(free)_xenballooned_pages helpers back
Date: Thu,  9 Dec 2021 22:05:33 +0200
Message-Id: <1639080336-26573-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch rolls back some of the changes introduced by commit
121f2faca2c0a "xen/balloon: rename alloc/free_xenballooned_pages"
in order to make possible to still allocate xenballooned pages
if CONFIG_XEN_UNPOPULATED_ALLOC is enabled.

On Arm the unpopulated pages will be allocated on top of extended
regions provided by Xen via device-tree (the subsequent patches
will add required bits to support unpopulated-alloc feature on Arm).
The problem is that extended regions feature has been introduced
into Xen quite recently (during 4.16 release cycle). So this
effectively means that Linux must only use unpopulated-alloc on Arm
if it is running on "new Xen" which advertises these regions.
But, it will only be known after parsing the "hypervisor" node
at boot time, so before doing that we cannot assume anything.

In order to keep working if CONFIG_XEN_UNPOPULATED_ALLOC is enabled
and the extended regions are not advertised (Linux is running on
"old Xen", etc) we need the fallback to alloc_xenballooned_pages().

This way we wouldn't reduce the amount of memory usable (wasting
RAM pages) for any of the external mappings anymore (and eliminate
XSA-300) with "new Xen", but would be still functional ballooning
out RAM pages with "old Xen".

Also rename alloc(free)_xenballooned_pages to xen_alloc(free)_ballooned_pages
and make xen_alloc(free)_unpopulated_pages static inline in xen.h
if CONFIG_XEN_UNPOPULATED_ALLOC is disabled.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes V2 -> V3:
   - new patch

Changes V3 -> V4:
   - no changes
---
 drivers/xen/balloon.c | 20 +++++++++-----------
 include/xen/balloon.h |  3 +++
 include/xen/xen.h     | 14 ++++++++++++++
 3 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index ba2ea11..a2c4fc49 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -581,7 +581,6 @@ void balloon_set_new_target(unsigned long target)
 }
 EXPORT_SYMBOL_GPL(balloon_set_new_target);
 
-#ifndef CONFIG_XEN_UNPOPULATED_ALLOC
 static int add_ballooned_pages(unsigned int nr_pages)
 {
 	enum bp_state st;
@@ -610,12 +609,12 @@ static int add_ballooned_pages(unsigned int nr_pages)
 }
 
 /**
- * xen_alloc_unpopulated_pages - get pages that have been ballooned out
+ * xen_alloc_ballooned_pages - get pages that have been ballooned out
  * @nr_pages: Number of pages to get
  * @pages: pages returned
  * @return 0 on success, error otherwise
  */
-int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
+int xen_alloc_ballooned_pages(unsigned int nr_pages, struct page **pages)
 {
 	unsigned int pgno = 0;
 	struct page *page;
@@ -652,23 +651,23 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 	return 0;
  out_undo:
 	mutex_unlock(&balloon_mutex);
-	xen_free_unpopulated_pages(pgno, pages);
+	xen_free_ballooned_pages(pgno, pages);
 	/*
-	 * NB: free_xenballooned_pages will only subtract pgno pages, but since
+	 * NB: xen_free_ballooned_pages will only subtract pgno pages, but since
 	 * target_unpopulated is incremented with nr_pages at the start we need
 	 * to remove the remaining ones also, or accounting will be screwed.
 	 */
 	balloon_stats.target_unpopulated -= nr_pages - pgno;
 	return ret;
 }
-EXPORT_SYMBOL(xen_alloc_unpopulated_pages);
+EXPORT_SYMBOL(xen_alloc_ballooned_pages);
 
 /**
- * xen_free_unpopulated_pages - return pages retrieved with get_ballooned_pages
+ * xen_free_ballooned_pages - return pages retrieved with get_ballooned_pages
  * @nr_pages: Number of pages
  * @pages: pages to return
  */
-void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
+void xen_free_ballooned_pages(unsigned int nr_pages, struct page **pages)
 {
 	unsigned int i;
 
@@ -687,9 +686,9 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
 
 	mutex_unlock(&balloon_mutex);
 }
-EXPORT_SYMBOL(xen_free_unpopulated_pages);
+EXPORT_SYMBOL(xen_free_ballooned_pages);
 
-#if defined(CONFIG_XEN_PV)
+#if defined(CONFIG_XEN_PV) && !defined(CONFIG_XEN_UNPOPULATED_ALLOC)
 static void __init balloon_add_region(unsigned long start_pfn,
 				      unsigned long pages)
 {
@@ -712,7 +711,6 @@ static void __init balloon_add_region(unsigned long start_pfn,
 	balloon_stats.total_pages += extra_pfn_end - start_pfn;
 }
 #endif
-#endif
 
 static int __init balloon_init(void)
 {
diff --git a/include/xen/balloon.h b/include/xen/balloon.h
index e93d4f0..f78a6cc 100644
--- a/include/xen/balloon.h
+++ b/include/xen/balloon.h
@@ -26,6 +26,9 @@ extern struct balloon_stats balloon_stats;
 
 void balloon_set_new_target(unsigned long target);
 
+int xen_alloc_ballooned_pages(unsigned int nr_pages, struct page **pages);
+void xen_free_ballooned_pages(unsigned int nr_pages, struct page **pages);
+
 #ifdef CONFIG_XEN_BALLOON
 void xen_balloon_init(void);
 #else
diff --git a/include/xen/xen.h b/include/xen/xen.h
index 9f031b5..86c5b37 100644
--- a/include/xen/xen.h
+++ b/include/xen/xen.h
@@ -52,7 +52,21 @@ bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
 extern u64 xen_saved_max_mem_size;
 #endif
 
+#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
 int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
 void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
+#else
+#include <xen/balloon.h>
+static inline int xen_alloc_unpopulated_pages(unsigned int nr_pages,
+		struct page **pages)
+{
+	return xen_alloc_ballooned_pages(nr_pages, pages);
+}
+static inline void xen_free_unpopulated_pages(unsigned int nr_pages,
+		struct page **pages)
+{
+	xen_free_ballooned_pages(nr_pages, pages);
+}
+#endif
 
 #endif	/* _XEN_XEN_H */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243313.420927 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfp-0005k3-H0; Thu, 09 Dec 2021 20:05:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243313.420927; Thu, 09 Dec 2021 20:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfp-0005iO-Bq; Thu, 09 Dec 2021 20:05:49 +0000
Received: by outflank-mailman (input) for mailman id 243313;
 Thu, 09 Dec 2021 20:05:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfn-0004Xd-Qu
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:47 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65958a26-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:05:46 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id 13so10634523ljj.11
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:47 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.45
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65958a26-592b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=R0fiIRx1tdommq9IGRl8CoXFpUaCu+zHn93/yFjWte8=;
        b=n2HuGtve4aJvc3nlYM9Dz7ywy3oqNGSu7nskjkeAeor14V/8fpk08jcPSZ721Iao3+
         hHMOlkXylq2GcKZg3j54/qELfoGkt4IfF7Qo67vwRASA0+tSnyQdbhQec0oO094ceoOm
         blC4EkWj08hh9wwV9eu1k0VwdU1YRxQotoEp8vFy3tBbAkM/m6nDspgP8lajWCCPDP9K
         Zs13Y+c8Q6Y45uH5mu1eQ9/7pLVa79Nq73lCQilGu9mxZ35DjtLRdGHH+Ds1TKs2eRZD
         ucoPlVDPHqDj9AbJ58Dnzo818RFf8QdDUDOHSwUBVLZXFXKiK9vJbqHFHGI07odQ0p19
         A/iQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=R0fiIRx1tdommq9IGRl8CoXFpUaCu+zHn93/yFjWte8=;
        b=q9gAhEhJ7TbdJa1pn42Qt0tv9HWo9Il7Uv1NK2/W2bI1XJ7SZIxXcnjccGuIkh2hUK
         ZPM6Jq4nfi9be+Ym2mFwFcHz5qdNFC+98tkK9o3oA42dh/LuZdiWw48MxOXABNI1RkTU
         pNwfejzoOmoXYoiNViIPYvP58Vw/IqVElD+RVKfuB/LcUqOom27WqPNMQZy5rv+DT4cK
         fBCz+rS+spMmN3L4swAZFlBZNIu9cj14nOzzMzVYnzt/yhn8UJd8W09+wkChN3leXsgx
         yCTwDv7srVJ4HdYa0v5pfFTKaBz4O9ftmy+F9KzQFJ7BKNBceacgKk5jGUXvORbDBP2c
         5Gyg==
X-Gm-Message-State: AOAM533Ryp0cvoi4Y2qoAgxVfrPTzyYsqLarp1T4pKiXrfeB/LRph0LB
	sLC0y6TAIQ5Ami6CArM9NVZgWo5oDGyxpA==
X-Google-Smtp-Source: ABdhPJzHrcB9daArwNq3p6osXn8jy3zvVeJEP9xDadJPm3zUWm6zBrzFxOmGFuC7tp0ecBwfSVUZ8g==
X-Received: by 2002:a05:651c:621:: with SMTP id k33mr8233705lje.359.1639080346196;
        Thu, 09 Dec 2021 12:05:46 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 5/6] arm/xen: Read extended regions from DT and init Xen resource
Date: Thu,  9 Dec 2021 22:05:35 +0200
Message-Id: <1639080336-26573-6-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch implements arch_xen_unpopulated_init() on Arm where
the extended regions (if any) are gathered from DT and inserted
into specific Xen resource to be used as unused address space
for Xen scratch pages by unpopulated-alloc code.

The extended region (safe range) is a region of guest physical
address space which is unused and could be safely used to create
grant/foreign mappings instead of wasting real RAM pages from
the domain memory for establishing these mappings.

The extended regions are chosen by the hypervisor at the domain
creation time and advertised to it via "reg" property under
hypervisor node in the guest device-tree. As region 0 is reserved
for grant table space (always present), the indexes for extended
regions are 1...N.

If arch_xen_unpopulated_init() fails for some reason the default
behaviour will be restored (allocate xenballooned pages).

This patch also removes XEN_UNPOPULATED_ALLOC dependency on x86.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
Changes RFC -> V2:
   - new patch, instead of
    "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"

Changes V2 -> V3:
   - update comments in code
   - drop the checks that a region is within the hotpluggable range,
     now the common code takes care of
   - update arch_xen_unpopulated_init() according to interface change,
     move xen_resource here, etc
   - use %pR specifier in error message
   - bait out in arch_xen_unpopulated_init() if !acpi_disabled
   - update checks in second loop in arch_xen_unpopulated_init()
     for the sake of clarity

Changes V3 -> V4:
   - add Stefano's R-b
---
 arch/arm/xen/enlighten.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++
 drivers/xen/Kconfig      |   2 +-
 2 files changed, 107 insertions(+), 1 deletion(-)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 49bb675..ec5b082 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -62,6 +62,7 @@ static __read_mostly unsigned int xen_events_irq;
 static __read_mostly phys_addr_t xen_grant_frames;
 
 #define GRANT_TABLE_INDEX   0
+#define EXT_REGION_INDEX    1
 
 uint32_t xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
@@ -303,6 +304,111 @@ static void __init xen_acpi_guest_init(void)
 #endif
 }
 
+#ifdef CONFIG_XEN_UNPOPULATED_ALLOC
+/*
+ * A type-less specific Xen resource which contains extended regions
+ * (unused regions of guest physical address space provided by the hypervisor).
+ */
+static struct resource xen_resource = {
+	.name = "Xen unused space",
+};
+
+int __init arch_xen_unpopulated_init(struct resource **res)
+{
+	struct device_node *np;
+	struct resource *regs, *tmp_res;
+	uint64_t min_gpaddr = -1, max_gpaddr = 0;
+	unsigned int i, nr_reg = 0;
+	int rc;
+
+	if (!xen_domain())
+		return -ENODEV;
+
+	if (!acpi_disabled)
+		return -ENODEV;
+
+	np = of_find_compatible_node(NULL, NULL, "xen,xen");
+	if (WARN_ON(!np))
+		return -ENODEV;
+
+	/* Skip region 0 which is reserved for grant table space */
+	while (of_get_address(np, nr_reg + EXT_REGION_INDEX, NULL, NULL))
+		nr_reg++;
+
+	if (!nr_reg) {
+		pr_err("No extended regions are found\n");
+		return -EINVAL;
+	}
+
+	regs = kcalloc(nr_reg, sizeof(*regs), GFP_KERNEL);
+	if (!regs)
+		return -ENOMEM;
+
+	/*
+	 * Create resource from extended regions provided by the hypervisor to be
+	 * used as unused address space for Xen scratch pages.
+	 */
+	for (i = 0; i < nr_reg; i++) {
+		rc = of_address_to_resource(np, i + EXT_REGION_INDEX, &regs[i]);
+		if (rc)
+			goto err;
+
+		if (max_gpaddr < regs[i].end)
+			max_gpaddr = regs[i].end;
+		if (min_gpaddr > regs[i].start)
+			min_gpaddr = regs[i].start;
+	}
+
+	xen_resource.start = min_gpaddr;
+	xen_resource.end = max_gpaddr;
+
+	/*
+	 * Mark holes between extended regions as unavailable. The rest of that
+	 * address space will be available for the allocation.
+	 */
+	for (i = 1; i < nr_reg; i++) {
+		resource_size_t start, end;
+
+		/* There is an overlap between regions */
+		if (regs[i - 1].end + 1 > regs[i].start) {
+			rc = -EINVAL;
+			goto err;
+		}
+
+		/* There is no hole between regions */
+		if (regs[i - 1].end + 1 == regs[i].start)
+			continue;
+
+		start = regs[i - 1].end + 1;
+		end = regs[i].start - 1;
+
+		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
+		if (!tmp_res) {
+			rc = -ENOMEM;
+			goto err;
+		}
+
+		tmp_res->name = "Unavailable space";
+		tmp_res->start = start;
+		tmp_res->end = end;
+
+		rc = insert_resource(&xen_resource, tmp_res);
+		if (rc) {
+			pr_err("Cannot insert resource %pR (%d)\n", tmp_res, rc);
+			kfree(tmp_res);
+			goto err;
+		}
+	}
+
+	*res = &xen_resource;
+
+err:
+	kfree(regs);
+
+	return rc;
+}
+#endif
+
 static void __init xen_dt_guest_init(void)
 {
 	struct device_node *xen_node;
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 33e941e..120d32f 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -327,7 +327,7 @@ config XEN_FRONT_PGDIR_SHBUF
 
 config XEN_UNPOPULATED_ALLOC
 	bool "Use unpopulated memory ranges for guest mappings"
-	depends on X86 && ZONE_DEVICE
+	depends on ZONE_DEVICE
 	default XEN_BACKEND || XEN_GNTDEV || XEN_DOM0
 	help
 	  Use unpopulated memory ranges in order to create mappings for guest
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243309.420884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfl-0004bR-32; Thu, 09 Dec 2021 20:05:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243309.420884; Thu, 09 Dec 2021 20:05:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfk-0004aK-TZ; Thu, 09 Dec 2021 20:05:44 +0000
Received: by outflank-mailman (input) for mailman id 243309;
 Thu, 09 Dec 2021 20:05:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfj-0004Xd-Kc
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:43 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 630f33d4-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:05:42 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id k37so14217604lfv.3
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:42 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.41
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 630f33d4-592b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=CS9aK8CojMqdb/AcA3jHRSI+mrWqH9RveIgOpizvY9U=;
        b=nJ6YIRKoVQppvpal4aj4p6po8BZEoe2W0v2EiJOt2lz9DD/MZQz4YOGAFga6byn+PS
         bpoNN7jJzU6n+1ymG3q5nkDMcZyj6qh8VLD5qe9Y82B5S10kXdLAgf8PzlZT01cHKuhA
         JXaYSWqP6JLSTiUSi3EyD3xZ+LiV/d/6rJhFyPL5A2n9Qlamzj6EkCbfiO7uXKvO0fDC
         dDKM/bTNoo7nV/iChOSyPjaEfVz8kw6VsAW++5dxIl2Ed/EHaOmZKJK0QgUPBpIFINJw
         0i+XdqKk7zJC+3HWynXOo7JID118X95q9twABJWbrjnKOuX9i34ZaQ8aTIjd0bmhB/4Y
         F9XA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=CS9aK8CojMqdb/AcA3jHRSI+mrWqH9RveIgOpizvY9U=;
        b=umZOmpncV5DvbBxEb6oHOlz9kOa+EJ59snXEfx5Oy291ItQ2SyfpA4uv77TgZwEYSy
         oIEQMnMakZNaEpl8r62MUXf88K8gTGBHVWCO/OoT235i7fmmzqmJmPXNyrNSJsLAFwyJ
         UUXiT3D5qA9Lpevd7tg9YwG6yTpv1PXK8BIcfcrLTqEq/vAJmyE2lUp8IUFvQ3UyYP/x
         MSqx+3NQ9OowqNvEkRhE3kboMCLfYs3/gfETBU5qREEQ8VDikS3ohNv7AaSr9YfesIVF
         S+/eF1KCXHHbSc3fNVIZj1JPf/fw30/YMs+WupmVeOHOyeiVbUUagxejl1BBvtz99CAh
         YdhA==
X-Gm-Message-State: AOAM531GgODPNySFrr8+i1Qh1byPDdkoJ+9YYe+nAb/zIIXYplTOdTVv
	ohlsDRll3ak3kB0IxTBnh2C9f9oJS+7u4Q==
X-Google-Smtp-Source: ABdhPJxerwr28Tg8c06W+QUK8C5H1O0rKZUkku9U1Odi1NykdsC2f8brvhJBN6XBJ2EuJVFZAjwx2Q==
X-Received: by 2002:a05:6512:2312:: with SMTP id o18mr8160079lfu.333.1639080342265;
        Thu, 09 Dec 2021 12:05:42 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 1/6] xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
Date: Thu,  9 Dec 2021 22:05:31 +0200
Message-Id: <1639080336-26573-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

If memremap_pages() succeeds the range is guaranteed to have proper page
table, there is no need for an additional virt_addr_valid() check.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
Changes RFC -> V2:
   - new patch, instead of
     "[RFC PATCH 1/2] arm64: mm: Make virt_addr_valid to check for pfn_valid again"

Changes V2 -> V3:
   - add Boris' R-b

Changes V3 -> V4:
   - no changes
---
 drivers/xen/unpopulated-alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
index 87e6b7d..a03dc5b 100644
--- a/drivers/xen/unpopulated-alloc.c
+++ b/drivers/xen/unpopulated-alloc.c
@@ -85,7 +85,6 @@ static int fill_list(unsigned int nr_pages)
 	for (i = 0; i < alloc_pages; i++) {
 		struct page *pg = virt_to_page(vaddr + PAGE_SIZE * i);
 
-		BUG_ON(!virt_addr_valid(vaddr + PAGE_SIZE * i));
 		pg->zone_device_data = page_list;
 		page_list = pg;
 		list_count++;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243308.420878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfk-0004Xv-Pm; Thu, 09 Dec 2021 20:05:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243308.420878; Thu, 09 Dec 2021 20:05:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfk-0004Xo-MH; Thu, 09 Dec 2021 20:05:44 +0000
Received: by outflank-mailman (input) for mailman id 243308;
 Thu, 09 Dec 2021 20:05:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfj-0004Xc-4f
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:43 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 630ae164-592b-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 21:05:42 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id u22so10681953lju.7
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:42 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.40
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 630ae164-592b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=vdi+ngDYZ8frSITjIEVRzjOKqqv9jxuC3qoXZDRzY3E=;
        b=POI/206AdEE7Y8xM46ArhvWFzWMc2DNrU+UafFP+UOclIvQYLxk1wmsBw/yyS/2aJq
         S5CpimmLVPKLGv1qeaK8y9ZSZWPbUrwWz0U9F23hBFzZMNnqPiSgGl6i4yrjddpeoM+4
         pCbv8bG+8PORW01axAIL0xFxcCuYd/SxoZ6D83LMnf0JeYB3FzzmLDoqQYGTBLtxMEcP
         AqUoKYkz+sQ323/QBMVXkSS+NhUo2aqU24AfJZE57ACd8ve3kXXj62V6znNiezs+Qw1u
         72Nkmrzzg3J90EBkRxkscukCm+D95/mVkCa9cL3RnL2xd6tVyz3BvuskJvsUpaKNUpzK
         u5Xw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=vdi+ngDYZ8frSITjIEVRzjOKqqv9jxuC3qoXZDRzY3E=;
        b=afqKX/vSVaa+Yr8B89zi46+SZsbbikhrzd98i+S9/Xk2zyVDYs7Aiazw1k4WaLpKkO
         E4DBTDZY+49sZth8yEVjLAp4idDhOqRaf8ax/wa5V53NZq7LYLT7HERiO+0Llz9ZsWZh
         7A0lvQW/lYli78NIXSxQAao4nmwHStJHFaNZ1x/bUDPuSB8UDYPFpnPyriz9o3m68qK7
         dPynYRClc8sPRKo834LqV7+7pCSaZOPUAY3+Y5ixzxzl0TPr7Y5BFRDiSDcsvr8IRuY9
         edEUihwL2eJO3Stx4Oavg1wrfYu30/oNQ7UZwtjx3aH4A3BW8UksWItoPkka6Cf4+NKV
         DMHQ==
X-Gm-Message-State: AOAM531frnjyOTl6NksgE3G6vWnhXrtAC6qqWSWcV9nsEsQ9cM2l4hmp
	EQUSiMmG4wtaUSVb4Kr+QiBk6pIZJ1cq2A==
X-Google-Smtp-Source: ABdhPJxucGuWwfKQW2OEY9Dp9Wft8deEcKtIdgf1+XzoXquMxrrE4dy0sBiatCkpQLtPu/fTSAEpFw==
X-Received: by 2002:a2e:530d:: with SMTP id h13mr8398300ljb.95.1639080341326;
        Thu, 09 Dec 2021 12:05:41 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Julien Grall <julien@xen.org>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Henry Wang <Henry.Wang@arm.com>,
	Kaly Xin <Kaly.Xin@arm.com>,
	Jiamei Xie <Jiamei.Xie@arm.com>
Subject: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges) on Arm
Date: Thu,  9 Dec 2021 22:05:30 +0200
Message-Id: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

You can find the RFC-V3 patch series at [1],[2] and [3].

The corresponding Xen support (for both Dom0 and DomU) is already committed and
is available in mainline Xen since the following commit:
57f87857dc2de452a796d6bad4f476510efd2aba libxl/arm: Add handling of extended regions for DomU

The extended region (safe range) is a region of guest physical address space
which is unused and could be safely used to create grant/foreign mappings instead
of ballooning out real RAM pages to obtain a physical address space for creating
these mappings (which simply results in wasting domain memory and shattering super
pages in P2M table).

The problem is that we cannot follow Linux advise which memory ranges are unused
on Arm as there might be some identity mappings in P2M table (stage 2) the guest is not
aware of or not all device I/O regions might be known (registered) by the time the guest
starts creating grant/foreign mappings. This is why we need some hints from the hypervisor
which knows all details in advance to be able to choose extended regions (which won't
clash with other resources).

The extended regions are chosen at the domain creation time and advertised to it via
"reg" property under hypervisor node in the guest device-tree [4]. As region 0 is reserved
for grant table space (always present), the indexes for extended regions are 1...N.
No device tree bindings update is needed, guest infers the presence of extended regions
from the number of regions in "reg" property.

Please note the following:
- The ACPI case is not covered for now
- patch series was created in a way to retain existing behavior on x86

The patch series is based on v5.16-rc3 and also available at [5], it was fully
tested on Arm64 and only compile tested on x86.

[1] https://lore.kernel.org/all/1627490656-1267-1-git-send-email-olekstysh@gmail.com/
    https://lore.kernel.org/all/1627490656-1267-2-git-send-email-olekstysh@gmail.com/
[2] https://lore.kernel.org/all/1635264312-3796-1-git-send-email-olekstysh@gmail.com/
[3] https://lore.kernel.org/all/1637787223-21129-1-git-send-email-olekstysh@gmail.com/
[4] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=docs/misc/arm/device-tree/guest.txt;hb=refs/heads/master
[5] https://github.com/otyshchenko1/linux/commits/map_opt_ml7

Oleksandr Tyshchenko (6):
  xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
  arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
  xen/balloon: Bring alloc(free)_xenballooned_pages helpers back
  xen/unpopulated-alloc: Add mechanism to use Xen resource
  arm/xen: Read extended regions from DT and init Xen resource
  dt-bindings: xen: Clarify "reg" purpose

 Documentation/devicetree/bindings/arm/xen.txt |  14 +--
 arch/arm/xen/enlighten.c                      | 132 ++++++++++++++++++++++++--
 drivers/xen/Kconfig                           |   2 +-
 drivers/xen/balloon.c                         |  20 ++--
 drivers/xen/unpopulated-alloc.c               |  87 ++++++++++++++++-
 include/xen/balloon.h                         |   3 +
 include/xen/xen.h                             |  16 ++++
 7 files changed, 245 insertions(+), 29 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:05:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:05:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243314.420934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfq-0005pt-3B; Thu, 09 Dec 2021 20:05:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243314.420934; Thu, 09 Dec 2021 20:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPfp-0005p0-OB; Thu, 09 Dec 2021 20:05:49 +0000
Received: by outflank-mailman (input) for mailman id 243314;
 Thu, 09 Dec 2021 20:05:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvPfo-0004Xd-D9
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:05:48 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 65e21947-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:05:47 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id l22so14131942lfg.7
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:05:47 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id o12sm87371lft.134.2021.12.09.12.05.46
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:05:46 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 65e21947-592b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=g9AJiL9uTfpDDMd7SS4C6nAmWL0XZo0V0ZfDFdYmLjY=;
        b=COAXXVLnmQmpr5BGzCN9BcuqWFvHw2ocxZLxo6ryJ5Lhw+xJPSJQG8U5fyMK+rUwSi
         EYiKUFWwRjqcCV5YBfFzHQXgooJ8gBMmNeHvmX/AgiZxPAVXkq9PVW+yvKPlmzOl4aYu
         W2uDd1pXtu8UqzUIkvBXbL2Ch/O5tKOkr88Ei7WEG/HFl30t6yY/I9V2vtZteJYlrLxv
         iWHYSmmfEP5O8RSy/8n2R2GZzIGviX+SR5pmTvEBaL0XRT/AWDwa2km8xegEcMSEcF2l
         kf/OIUNJdOMax5XXVTNReI1Ic72Mf3qeSkVeziNzAaC0ItMUN+asYzsXxndrXbw7kj4E
         Rwbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=g9AJiL9uTfpDDMd7SS4C6nAmWL0XZo0V0ZfDFdYmLjY=;
        b=kwxC+Y06fyr8qJJEaemTlwwXroHsQQ1xisJW6/ckrM6izx9N7ZJ0oKpfVWuoIZ3So0
         LG3tPtxB8dm6LRrZvgna2sJX1fSTzB0HRD6pdYA4g2ZCoRy5MeDSRkaO5VMirWtcuVrp
         9UrkcyPcVtapoBN87xc2tXFujDb5ygL4D1HfGHnhJHn48ulV3YrGuYohPo8Uv5y8cWjX
         ktFzUtZbSxgfIcsfAciDbNSSqtYwW+UZOtXqrmQpRJ3B48YdbPSqu8R9itdRAbRmPP7i
         WZktHzUYM8VzqFnlqC1xEpo9o+dtzlrP5yysc3tuF48rDBmNjAZ17yRbWHvDqE1r2cuF
         x/GQ==
X-Gm-Message-State: AOAM533fPKy5lTXikQskfbvFrkBZ9qyyhdLH9bIucQWzEpvn053goim6
	WmL2aEt112UuKUoLz5vkH0rUDS+5JpIK0g==
X-Google-Smtp-Source: ABdhPJyxDwm4qD0w1ssRjatqaxocOTEkFxXrsK+gDNk3bFfYXhmsC90Kh+C73THhn+OlTC99iNMRWQ==
X-Received: by 2002:a05:6512:ea2:: with SMTP id bi34mr8469336lfb.12.1639080346992;
        Thu, 09 Dec 2021 12:05:46 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
Date: Thu,  9 Dec 2021 22:05:36 +0200
Message-Id: <1639080336-26573-7-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Xen on Arm has gained new support recently to calculate and report
extended regions (unused address space) safe to use for external
mappings. These regions are reported via "reg" property under
"hypervisor" node in the guest device-tree. As region 0 is reserved
for grant table space (always present), the indexes for extended
regions are 1...N.

No device-tree bindings update is needed (except clarifying the text)
as guest infers the presence of extended regions from the number
of regions in "reg" property.

While at it, remove the following sentence:
"This property is unnecessary when booting Dom0 using ACPI."
for "reg" and "interrupts" properties as the initialization is not
done via device-tree "hypervisor" node in that case anyway.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes V2 -> V3:
   - new patch

Changes V3 -> V4:
   - add Stefano's R-b and Rob's A-b
   - remove sentence about ACPI for "reg" and "interrupts"
     properties
---
 Documentation/devicetree/bindings/arm/xen.txt | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt
index db5c56d..61d77ac 100644
--- a/Documentation/devicetree/bindings/arm/xen.txt
+++ b/Documentation/devicetree/bindings/arm/xen.txt
@@ -7,15 +7,17 @@ the following properties:
 	compatible = "xen,xen-<version>", "xen,xen";
   where <version> is the version of the Xen ABI of the platform.
 
-- reg: specifies the base physical address and size of a region in
-  memory where the grant table should be mapped to, using an
-  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
-  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
-  This property is unnecessary when booting Dom0 using ACPI.
+- reg: specifies the base physical address and size of the regions in memory
+  where the special resources should be mapped to, using an HYPERVISOR_memory_op
+  hypercall.
+  Region 0 is reserved for mapping grant table, it must be always present.
+  The memory region is large enough to map the whole grant table (it is larger
+  or equal to gnttab_max_grant_frames()).
+  Regions 1...N are extended regions (unused address space) for mapping foreign
+  GFNs and grants, they might be absent if there is nothing to expose.
 
 - interrupts: the interrupt used by Xen to inject event notifications.
   A GIC node is also required.
-  This property is unnecessary when booting Dom0 using ACPI.
 
 To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
 under /hypervisor with following parameters:
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:07:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:07:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243348.420955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPhO-0000mi-G3; Thu, 09 Dec 2021 20:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243348.420955; Thu, 09 Dec 2021 20:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPhO-0000mb-D1; Thu, 09 Dec 2021 20:07:26 +0000
Received: by outflank-mailman (input) for mailman id 243348;
 Thu, 09 Dec 2021 20:07:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PaQb=Q2=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvPhN-0000mI-Io
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:07:25 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9db73802-592b-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:07:23 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9db73802-592b-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639080439;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=t8vWSJsQ3BPUuA0dl4ZxOCitpzQBCnAQcAG9d/AyszY=;
	b=sHhovCXYznLQvrGNlUrM3WEopSb51XowtYU6ZRg8/yzFTDuzz216Ewv7DolyvFsUKx/1ke
	B5ybiEluLUSMnv6nlypjKB3an/Ik19E8hELGvpGfaVsmyqlgRZ28jDTwg9X2YLdv0WXzyT
	qC8D+iAPLh/KVpR+ate3DDYaz+32FbJXuKAi1Tm3x4JYB4PJdhnn64H+G0JP8NQWxBBKW9
	mGg+435IBYg7crZEFeHp62q1iA+vdQWU3kcVjCOYWzqdyfdsUINMLHQRoPn27ryaaZ5Q87
	tnfir7pXGA6MtmMp/oUILSVBjMo1EPXed/tAn3VW13a5C37FiNh4kwD3IB7i4Q==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639080439;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=t8vWSJsQ3BPUuA0dl4ZxOCitpzQBCnAQcAG9d/AyszY=;
	b=JfqQs3MQSjnfAkz1VIzKG+EbEjFfElIM5AarYArIkvLdqdh5RCIVK40SvG1K0tmOwfjy8O
	tm5NFzpfUpuOaxAQ==
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Niklas Schnelle
 <schnelle@linux.ibm.com>, linux-s390@vger.kernel.org, Heiko Carstens
 <hca@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Logan
 Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>, Dave Jiang
 <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com
Subject: Re: [patch V2 02/31] genirq/msi: Add mutex for MSI list protection
In-Reply-To: <20211209004702.GL6385@nvidia.com>
References: <20211206210600.123171746@linutronix.de>
 <20211206210747.708877269@linutronix.de>
 <20211209004702.GL6385@nvidia.com>
Date: Thu, 09 Dec 2021 21:07:18 +0100
Message-ID: <87bl1pzgnd.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Dec 08 2021 at 20:47, Jason Gunthorpe wrote:
> On Mon, Dec 06, 2021 at 11:51:05PM +0100, Thomas Gleixner wrote:
>> +++ b/kernel/irq/msi.c
>> @@ -127,12 +127,37 @@ int msi_setup_device_data(struct device
>>  		return -ENOMEM;
>>  
>>  	INIT_LIST_HEAD(&md->list);
>> +	mutex_init(&md->mutex);
>>  	dev->msi.data = md;
>>  	devres_add(dev, md);
>>  	return 0;
>>  }
>>  
>>  /**
>> + * msi_lock_descs - Lock the MSI descriptor storage of a device
>> + * @dev:	Device to operate on
>> + */
>> +void msi_lock_descs(struct device *dev)
>> +{
>> +	if (WARN_ON_ONCE(!dev->msi.data))
>> +		return;
>
> Is this useful? Other places that call msi_lock_descs will continue on and deref
> null dev->msi anyhow - is the dump from the WARN_ON that much better
> than the oops from the null deref here:
>
>> +	mutex_lock(&dev->msi.data->mutex);

I put it there for paranoia reasons and forgot to revist it later. In
that case yes, it's of questionable value.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:19:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:19:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243355.420972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPsZ-0002v9-Kv; Thu, 09 Dec 2021 20:18:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243355.420972; Thu, 09 Dec 2021 20:18:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvPsZ-0002v2-HV; Thu, 09 Dec 2021 20:18:59 +0000
Received: by outflank-mailman (input) for mailman id 243355;
 Thu, 09 Dec 2021 20:18:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HnwN=Q2=linaro.org=mathieu.poirier@srs-se1.protection.inumbo.net>)
 id 1mvPsX-0002uw-U7
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:18:58 +0000
Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com
 [2a00:1450:4864:20::533])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c2ee1ec-592d-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:18:56 +0100 (CET)
Received: by mail-ed1-x533.google.com with SMTP id r11so22845247edd.9
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:18:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c2ee1ec-592d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=nGBDKmd1xBPIz31XWadzq8ArnogmXldarGq8hv549d8=;
        b=a73D1SCtqUOt3np9xdZHH/V64JXdb7CE5YMO0STQp+9Wr+IIqJx5sXDXWKLr/Q3EgQ
         iEjEaOMhxeDLxAOgmymMn1d+Q3dErLsaFRXTd4zonC6rvERPZrcsF4CdbYZnOUAkbRgo
         oEHAAP+7Az/wflwLX/WrVghiZ0FsrWFlaLO/is59Z89WSobi6kfmRuBhR0o166KiqvcP
         G9oFhHjQuKsuDkiFC1jRmE/9qrXDjmc9V0KnBIiiMAXFNkDa6WhNnnuLMUr55YZtvZL7
         w16l5yPuBuYdVk9+BnKZk2cEeYWvrYrShv/hkr7INZ5dxYUbTVPW6eH6hrp1UkJ01F0c
         HhuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=nGBDKmd1xBPIz31XWadzq8ArnogmXldarGq8hv549d8=;
        b=rtFBB0zc3Sg16ThT7GUurSGSURYtlQNjYGN7xE+vPYnoVVq5fpAVBrUf6lCHc0WuqD
         XmnR7Yrgnm06yQAW6WedybfOWiYUyhKqMBOfCZl5TOmxEh2qYyBFhKmAFi+KX4FBellP
         wXx0PMB6YgLrICfcZ/Sh09SLmKdTHN1mAorynkv9yFcnIeiL2qA6njnxCE+MefLSBy6b
         0A2fPhzpL7/wRTeXuwd0WvwF5UkcqZRTEOadkxuRX082Imqepe1QupiDBaBXKbc15PIk
         qc21DVgMQ+ZEFyIMNDncDGnvvs9+EZWbrsXlz4ajNQ/1j+CYIHwbtyAkplFWdA9gemlO
         W+MQ==
X-Gm-Message-State: AOAM533ycdvaSgvTxhStZemJfCCidIu8NIsXSON48eGsl9XXJ+QLEsf9
	Cr246PoaR28IHxowy5HtspTzTfCkNK2yBqS5OlZvbxsghAo=
X-Google-Smtp-Source: ABdhPJy00RMAQyUq+H97wg32S5wcAzgYszXxJ162OCHCt/JcFX29SjaU80z88lAXsBYb1PGUyol1VC9D7tHZGhj6Vfk=
X-Received: by 2002:a17:906:6a0a:: with SMTP id qw10mr18246252ejc.547.1639081135334;
 Thu, 09 Dec 2021 12:18:55 -0800 (PST)
MIME-Version: 1.0
References: <CANLsYkzKn7Nkika=KpHtSyi9=FQwS7Wt94Odbg2HuH+1PFUTzA@mail.gmail.com>
 <B34490D7-5FE3-41D4-9792-41E2BD25EF05@arm.com> <CANLsYkywEbLHhxsAJQ8_HPnjdsDXZMO+5-+zbSuqmcUV1Dr4iA@mail.gmail.com>
 <074326cc-f910-2cad-be1f-e27480f53b67@arm.com> <CANLsYkyF4Mv+MhyKJ-B4-56G=RVu6U3=OAraK5ZtnOx6TaW1UQ@mail.gmail.com>
 <877a84bc-b550-a22b-d3ab-1f81b1b78c6f@arm.com>
In-Reply-To: <877a84bc-b550-a22b-d3ab-1f81b1b78c6f@arm.com>
From: Mathieu Poirier <mathieu.poirier@linaro.org>
Date: Thu, 9 Dec 2021 13:18:43 -0700
Message-ID: <CANLsYkwBXa7Gi7cdBSwAWqokNsc7iFanw9RMJAMOxouEghwvcQ@mail.gmail.com>
Subject: Re: Aarch64 stand-alone application for Xen
To: Michal Orzel <michal.orzel@arm.com>
Cc: Bertrand Marquis <bertrand.marquis@arm.com>, 
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, 9 Dec 2021 at 00:19, Michal Orzel <michal.orzel@arm.com> wrote:
>
> Hi Mathieu,
>
> On 08.12.2021 22:23, Mathieu Poirier wrote:
> > On Wed, 8 Dec 2021 at 07:19, Michal Orzel <michal.orzel@arm.com> wrote:
> >>
> >> Hi Mathieu,
> >>
> >> On 08.12.2021 01:06, Mathieu Poirier wrote:
> >>> Hi Bertrand,
> >>>
> >>> On Fri, 26 Nov 2021 at 03:32, Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
> >>>>
> >>>> Hi Mathieu,
> >>>>
> >>>>> On 25 Nov 2021, at 22:59, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >>>>>
> >>>>> Good day,
> >>>>>
> >>>>> I am in the process of adding support for aarch64 to the xen-sys
> >>>>> crate[1].  The crate currently supports x86_64 and includes a
> >>>>> stand-alone "oxerun" application that can be used to validate
> >>>>> hypercalls.  My goal is to provide the same functionality on arm64.  I
> >>>>> am looking for a stand-alone aarch64 example, something like an "hello
> >>>>> world" to help me with the assembler startup code.
> >>>>
> >>>> We are working on porting XTF to arm64 and already have something running.
> >>>> I think it could be a good starting point for you:
> >>>> https://github.com/orzelmichal/xtf/tree/arm-devel
> >>>
> >>> Quick one - have you been able to get the "test-arm-64le-example"
> >>> application to run?  So far Xen gives me the following error:
> >>>
> >>> (XEN) ****************************************
> >>> (XEN) Panic on CPU 0:
> >>> (XEN) Unable to copy the kernel in the hwdom memory
> >>> (XEN) ****************************************
> >>>
> >>> I wanted to check with you before starting to dig into it.
> >>>
> >>
> >> ICYDK, 64le environment is used to create non-MMU domain in contrast to mmu64le.
> >
> > Right.
> >
> >> It lacks support for PV console and other important features of Xen.
> >
> > I'm good with that - for now all I want is to test hypervisor calls I
> > developed in Rust.
> >
> >> But we are able to run it without any issue.
> >> Please keep in mind that as there is no MMU you need to pay attention to the load address.
> >> By default for non-MMU domain, the address is 0x40000000 which is the correct address if you use XTF as a guest.
> >
> > I was trying to boot XTF as dom0 using the default address
> > (0x40000000), which lead to the output depicted above.
> >
> >> If you want to run non-MMU XTF as dom0, you need to specify the correct load address by passing CONFIG_LOAD_ADDRESS=<address>
> >> when invoking make. For example on QEMU it would be CONFIG_LOAD_ADDRESS=0x80000000.
> >>
> >
> > When adding the compilation flag "CONFIG_LOAD_ADDRESS=0x80000000" I
> > get further [1].  For my own education, why is address 0x80000000
> > required when running a non-MMU XTF as dom0?  Is this a Xen thing?
> >
> > The application crashes in the loop on line 135 [2] and I am wondering
> > if it wouldn't be related to the QEMU emulation. My setup is as
> > follow:
> >
> > . QEMU startup command [3]
> > . XTF baseline: "c14f7dd289a4 (xtf: Add arm support into xtf-runner)"
> > . Xen baseline: "c76cfada1cfa (tools/libacpi: Use 64-byte alignment for FACS)"
> >
> > Best regards,
> > Mathieu
> >
> > [1]. https://pastebin.com/3AVXRGXD
> > [2]. https://github.com/orzelmichal/xtf/blob/arm-devel/arch/arm/arm64/head.S#L135
> > [3]. https://pastebin.com/52aVAFha
> >
>
> For the setup you provided just compile XTF with CONFIG_LOAD_ADDRESS=0x60000000.
> This will fix your problem.

It definitely does - I officially owe you a beer.

> When using non-MMU dom0, the microkernel must be compiled with the load address that
> is within the memory bank allocated by Xen. You can see it in your logs:
> (XEN) BANK[0] 0x00000060000000-0x00000080000000 (512MB)
>

Very interesting.

> You did not specify dom0_mem parameter, so Xen defaults to 512MB for dom0.
> You can see it in your logs:
> (XEN) PLEASE SPECIFY dom0_mem PARAMETER - USING 512M FOR NOW
>
> FWICS you are passing Xen command line arguments through -append but i'm not sure it works.
> The best way is to use dtb.
>

Ok.

>
> >>> Thanks,
> >>> Mathieu
> >>>
> >>>>
> >>>> Regards
> >>>> Bertrand
> >>>>
> >>>>>
> >>>>> Many thanks for the consideration,
> >>>>> Mathieu
> >>>>>
> >>>>> [1]. https://crates.io/crates/xen-sys
> >>>>>
> >>>>
> >>>
> >> Cheers,
> >> Michal
>
> Cheers,
> Michal


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:27:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:27:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243362.420982 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQ0o-0004tf-Ev; Thu, 09 Dec 2021 20:27:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243362.420982; Thu, 09 Dec 2021 20:27:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQ0o-0004tY-Bq; Thu, 09 Dec 2021 20:27:30 +0000
Received: by outflank-mailman (input) for mailman id 243362;
 Thu, 09 Dec 2021 20:27:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQ0n-0004tO-9h; Thu, 09 Dec 2021 20:27:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQ0n-0001PA-5D; Thu, 09 Dec 2021 20:27:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQ0m-0004OI-Tm; Thu, 09 Dec 2021 20:27:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQ0m-0002jc-Qp; Thu, 09 Dec 2021 20:27:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AheklSb+f868QI+UsIsu87sJH5WQzMcF3/hdS9yL6pk=; b=KIh0TrzkPCfeYxSUtHkFtzGmFN
	Vck4A80ugSsTJJ6IjC86Iw/emg7VpkhPKnJ4FwRdQEAfHA7OpPTCD0W9JPCJsdmH80v0hSUtfZeEK
	IxAKoVlSK6F2v5rhs5jXStFMmh0X73tujqbEbmRDn2rpBT95K5EFtNHRWB/6xw7kbBrs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167288-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167288: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 20:27:28 +0000

flight 167288 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167288/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 20:51:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 20:51:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243370.420996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQNR-0000jW-G1; Thu, 09 Dec 2021 20:50:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243370.420996; Thu, 09 Dec 2021 20:50:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQNR-0000jP-D6; Thu, 09 Dec 2021 20:50:53 +0000
Received: by outflank-mailman (input) for mailman id 243370;
 Thu, 09 Dec 2021 20:50:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3OcP=Q2=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvQNQ-0000jJ-UU
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 20:50:53 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b223f3ba-5931-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 21:50:52 +0100 (CET)
Received: by mail-lf1-x12e.google.com with SMTP id bi37so14379972lfb.5
 for <xen-devel@lists.xenproject.org>; Thu, 09 Dec 2021 12:50:51 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id k14sm92114ljk.57.2021.12.09.12.50.50
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 09 Dec 2021 12:50:51 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b223f3ba-5931-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=c7rEPVFGeOVQOu8et9RCZV/Fdgh4YwILeYNJTSSEFWw=;
        b=m0NNJ+w8FJDSmroO2qAqhhO++3f/rLWSZf+VFBBdx+srrI8rhnxyIn7wXd3bm7Zlj/
         /oxPGn4pFEC4nADagsD6H+naRPj8bDmeJNSTfGY9WkHLrm0bXkDcOPEWatjzB7hNXKT4
         vXEpLjILxyxyUU1PDwAmO4UK+8wQia9GW1Aoc5IqqmFi7/+2wvYMtVO+u4cQoFRH0aS+
         63/luulRny06i7fpgeQlSGdAQvzpoGUIVVB1tn6Ny+06ms35GbCkl+joQCREg6q3HqlR
         6O/MeeMGRc5KQeaWl6U+CCG/XUoAMdna9/Wc1gVtYpb107kJ+uMeQNu/117I8eIyyL78
         fBRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=c7rEPVFGeOVQOu8et9RCZV/Fdgh4YwILeYNJTSSEFWw=;
        b=zzOT59JVV3FRRgGfyYN9qlji+tlWRcnwzv6o9Dkqd3Yj+AlW6miGhfkdEVf2sPAsgZ
         r6THBT48sPh4TsT6+dCvqdIjMnGFpvDCw8cmsu3F36fwimcJqfTi82lufujYBMstcRjk
         o2A/az7WyMVRzmp6j8qDPc7vkE/eTw2rOiipHRTslKHsmukDkY/aAYOXBmpzHZXh6kCB
         zsuENBPPB9HVIR1Eg4U7Y85I1gxe3dezIJHwTHhpD2DXEqk5de/Wszfp7dEgK8A76lbl
         jPSlXAMdMOzUO8ES/f3IDaXWLu+7tnSGBmD8VmmR4PQFyWKCSEXuaIKHEQ8yaB/MTycy
         fLhA==
X-Gm-Message-State: AOAM532T+xg7wWBg9lslItLGYdsS7eeu/DjnCAF/7w0AYhSieakylqqh
	SnKK1kxIAldr/feDStpSRID7K/asr+YNPQ==
X-Google-Smtp-Source: ABdhPJxeTUkQ2fexeJ93/pViqnDCun/x8scnvVRP+lJM7jL1LBTnWTF/CndpKxNKW3xueVE4Lrfhvw==
X-Received: by 2002:a05:6512:3324:: with SMTP id l4mr7824928lfe.302.1639083051292;
        Thu, 09 Dec 2021 12:50:51 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node
Date: Thu,  9 Dec 2021 22:50:50 +0200
Message-Id: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Remove the following sentence:
"This property is unnecessary when booting Dom0 using ACPI."
for "reg" and "interrupts" properties as the initialization is not
done via device-tree "hypervisor" node in that case anyway.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
 docs/misc/arm/device-tree/guest.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
index c115751..2b974bb 100644
--- a/docs/misc/arm/device-tree/guest.txt
+++ b/docs/misc/arm/device-tree/guest.txt
@@ -15,11 +15,9 @@ the following properties:
   or equal to gnttab_max_grant_frames()).
   Regions 1...N are extended regions (unused address space) for mapping foreign
   GFNs and grants, they might be absent if there is nothing to expose.
-  This property is unnecessary when booting Dom0 using ACPI.
 
 - interrupts: the interrupt used by Xen to inject event notifications.
   A GIC node is also required.
-  This property is unnecessary when booting Dom0 using ACPI.
 
 To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
 under /hypervisor with following parameters:
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 21:02:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 21:02:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243379.421008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQYL-0002mv-Jk; Thu, 09 Dec 2021 21:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243379.421008; Thu, 09 Dec 2021 21:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQYL-0002mo-GJ; Thu, 09 Dec 2021 21:02:09 +0000
Received: by outflank-mailman (input) for mailman id 243379;
 Thu, 09 Dec 2021 21:02:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PaQb=Q2=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvQYK-0002mi-33
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 21:02:08 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 442726d5-5933-11ec-a831-37629979565c;
 Thu, 09 Dec 2021 22:02:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 442726d5-5933-11ec-a831-37629979565c
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639083725;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xxqdvbsXfW9ZTgMmCuXp8YRHSWgAbwtAttb91gr8JjI=;
	b=DOc6YJ2ZnBO/S4LCXZXRmaCbKg4mw4ULShgz8TQVMTQrtnAO2Xt2ML2QqNoyx+YxXUsHJN
	M9Uc19toNCVSDrL0eBe6B+2C6HaFEOtjxR4Vo4wDMaGkR/fPp4Wnk8pCtSmMV+G3zim+uJ
	dTY6cTrRvZdPCszRejdDVRTgiEJq+lNz109fnZuFt1e703qlfscJY8ERwknVxLcHHHkz7A
	wxSoldZRl7kvhteRoNYLnpDjrMlrysFM5RCRJ+id9dYpo1pfWpwST9eeIao0MKlvGxa//1
	fq90+ELl15EUbs0r5Np+mZtUBnTVF1oCbSyBny5RQeJBwFKovf/OUugsxVxS8A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639083725;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=xxqdvbsXfW9ZTgMmCuXp8YRHSWgAbwtAttb91gr8JjI=;
	b=7h0lucwwwhZa1hvXVoxI9ymbY55FLNkqkYChkOSRhqiPlIIQ18VrnDa7PbaNLMd6ZwoxZ+
	K+aavqocs9ZCuaAA==
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Will Deacon <will@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>, iommu@lists.linux-foundation.org,
 dmaengine@vger.kernel.org, Stuart Yoder <stuyoder@gmail.com>, Laurentiu
 Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy
 <robin.murphy@arm.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V2 19/36] PCI/MSI: Store properties in device::msi::data
In-Reply-To: <87k0gdzmu6.ffs@tglx>
References: <20211206210307.625116253@linutronix.de>
 <20211206210438.688216619@linutronix.de>
 <20211208155816.GZ6385@nvidia.com> <87k0gdzmu6.ffs@tglx>
Date: Thu, 09 Dec 2021 22:02:04 +0100
Message-ID: <875yrxze43.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Thu, Dec 09 2021 at 18:53, Thomas Gleixner wrote:
> On Wed, Dec 08 2021 at 11:58, Jason Gunthorpe wrote:
>> On Mon, Dec 06, 2021 at 11:39:26PM +0100, Thomas Gleixner wrote:
>>> Store the properties which are interesting for various places so the MSI
>>> descriptor fiddling can be removed.
>>> 
>>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>>> ---
>>> V2: Use the setter function
>>> ---
>>>  drivers/pci/msi/msi.c |    8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>
>> I took more time to look at this, to summarize my remarks on the other
>> patches
>>
>> I think we don't need properties. The info in the msi_desc can come
>> from the pci_dev which we have easy access to. This seems overall
>> clearer
>
> I fixed that now.

So much for the theory. dev->msi[x]_enabled are set after everything is
set up. Some of the places are part of the setup...

/me goes back to stare


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 21:11:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 21:11:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243385.421019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQhQ-0004nQ-GS; Thu, 09 Dec 2021 21:11:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243385.421019; Thu, 09 Dec 2021 21:11:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQhQ-0004nJ-CM; Thu, 09 Dec 2021 21:11:32 +0000
Received: by outflank-mailman (input) for mailman id 243385;
 Thu, 09 Dec 2021 21:11:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PYs1=Q2=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mvQhP-0004nD-A7
 for xen-devel@lists.xenproject.org; Thu, 09 Dec 2021 21:11:31 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92841e3e-5934-11ec-9d12-4777fae47e2b;
 Thu, 09 Dec 2021 22:11:28 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 0BF01CE288B;
 Thu,  9 Dec 2021 21:11:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 240EEC004DD;
 Thu,  9 Dec 2021 21:11:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92841e3e-5934-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639084281;
	bh=8WpG4OXjQyn6mi5bo4AZx7Url5LvKeKpTOmOYuwuxIs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=iG0BtPFCnrVRufvJ4kKJXdaHV2nEA+R6Q3/9tEgUAqcmXgJA7xvuMf0dT1VOu/NRd
	 ohqSZXxZKUKPzNu9owZcTRk8tU4zYRbYQezKeJ1HL6mXYufelbMj3rG2CmIG96Ycqm
	 XjskG3qjat31uCYVLcdRzfZECYM9MjX2pUpWEi0BPKPHocpcMbEuLN9mYRhwuY+aIq
	 t385ffiuD0WMTcsxE0xI1sRsMqrZOt4QyBcpRCbKPzy6xWY1R+DHwQuNfatOrSHaxy
	 0cH9wgFQuFvBa532xxJfp2cG6bBksZHbKOyKCOaOWT3BFXkodJAQrqWbPTOXufjHx8
	 LCNXsz8UJPgwA==
Date: Thu, 9 Dec 2021 13:11:19 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Subject: Re: [RFC PATCH V3] xen/gnttab: Store frame GFN in struct page_info
 on Arm
In-Reply-To: <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112091309280.4091490@ubuntu-linux-20-04-desktop>
References: <1632425551-18910-1-git-send-email-olekstysh@gmail.com> <863c9a06-f0af-eac1-fb04-e059e4ce0a09@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 25 Nov 2021, Julien Grall wrote:
> For the record, I actually considered whether it is worth to fully implement
> an M2P on Arm. We technically have space in the struct page_info for that.
> However, I don't see it necessary in other place of Xen, so I would prefer to
> keep the space free for other purpose (or event be able to remove it).
> 
> @Stefano, what do you think?

Sorry for the late reply, I am still catching up after my holidays.

I agree with you here.


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 21:26:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 21:26:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243393.421036 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQw3-0006w2-SX; Thu, 09 Dec 2021 21:26:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243393.421036; Thu, 09 Dec 2021 21:26:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvQw3-0006vv-Oh; Thu, 09 Dec 2021 21:26:39 +0000
Received: by outflank-mailman (input) for mailman id 243393;
 Thu, 09 Dec 2021 21:26:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQw2-0006vl-Kz; Thu, 09 Dec 2021 21:26:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQw2-0002aB-DO; Thu, 09 Dec 2021 21:26:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQw2-0007LI-6S; Thu, 09 Dec 2021 21:26:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvQw2-0001tK-5z; Thu, 09 Dec 2021 21:26:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZFHoZeArBZ2ifzRjTYkkmitRGTTysYTop/xbhLWDDo0=; b=WJ2newhRtd71AHUmxo4L2sL0L8
	d6NXQ4f0rhs4HN/viIDMT750oz0RCNfadJIBAHSB+X7XWaETN+jePX4d0nRZI/9oex6wyxJCXQoDP
	9N/LeNbph80MJ5Udk/riOrCSW76HQhmt3h9FGd2zTPbyyC2m7EI/3gISTRopk/XRt5u8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167293-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167293: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 21:26:38 +0000

flight 167293 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167293/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 22:25:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 22:25:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243406.421068 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvRqM-0007hl-Ap; Thu, 09 Dec 2021 22:24:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243406.421068; Thu, 09 Dec 2021 22:24:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvRqM-0007he-5q; Thu, 09 Dec 2021 22:24:50 +0000
Received: by outflank-mailman (input) for mailman id 243406;
 Thu, 09 Dec 2021 22:24:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRqK-0007hS-PP; Thu, 09 Dec 2021 22:24:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRqK-0003kM-K4; Thu, 09 Dec 2021 22:24:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRqK-0001bD-Dk; Thu, 09 Dec 2021 22:24:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRqK-0000tF-DF; Thu, 09 Dec 2021 22:24:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FO24xzXDlD7w5rVzjtf1bgU1mOKlcZP8NR0MJDL2hgo=; b=LiSkbC5M9Di/4aG3ytF8XLK1rB
	bk6QN9jdpA5B2/Fmp+SdmJAn3/ZrD6Vo07ar+9UxkNEQYA1jnhtFe+B3LglrmITpYuLW4788EWYoy
	K3jnfUc8AHtS8gxy8sesBd/rkJYTlZg1isnLUuZ5qW4h05T9TWogD+6G2EBWH117FuAw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167297-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167297: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 22:24:48 +0000

flight 167297 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167297/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 22:29:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 22:29:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243413.421082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvRua-0000UZ-Tv; Thu, 09 Dec 2021 22:29:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243413.421082; Thu, 09 Dec 2021 22:29:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvRua-0000US-PC; Thu, 09 Dec 2021 22:29:12 +0000
Received: by outflank-mailman (input) for mailman id 243413;
 Thu, 09 Dec 2021 22:29:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRua-0000UG-9T; Thu, 09 Dec 2021 22:29:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRua-0003pI-4M; Thu, 09 Dec 2021 22:29:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRuZ-0001lL-U2; Thu, 09 Dec 2021 22:29:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvRuZ-0003Qq-TZ; Thu, 09 Dec 2021 22:29:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=7li+nQPT/SVE8VtyQOVZFhJP/EplTTYLNQx7nFSeoIA=; b=qPVmqstDOfqpFRup5fa4/AYSuL
	1AlpwaqZ25pbxprEyyxnB3JjK6sqB1lxQk0B0PH0gvHNqGx3gHU07cIqQBUDEPSs3SpbYI3Fd3wPF
	+onHX/qh4p7esDfUjkAFTURV3Gx4WCvk0TPfQDKPVVOjsjHeNb/yN962NiOJ9Wv9pAWk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [ovmf bisection] complete build-i386
Message-Id: <E1mvRuZ-0003Qq-TZ@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 22:29:11 +0000

branch xen-unstable
xenbranch xen-unstable
job build-i386
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167298/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386.xen-build --summary-out=tmp/167298.bisection-summary --basis-template=167239 --blessings=real,real-bisect,real-retry ovmf build-i386 xen-build
Searching for failure / basis pass:
 167297 fail [host=huxelrebe1] / 167239 [host=huxelrebe0] 167237 [host=albana0] 167231 [host=albana0] 167225 [host=albana0] 167122 [host=huxelrebe0] 167104 [host=huxelrebe0] 167081 [host=albana0] 166961 [host=albana0] 166951 [host=pinot0] 166949 [host=pinot0] 166826 [host=albana0] 166360 [host=fiano0] 166133 [host=albana1] 166130 [host=huxelrebe0] 166126 ok.
Failure / basis pass flights: 167297 / 166126
(tree with no url: minios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Basis pass 466ebdd2e0919c1538d03cd59833704bd5e1c028 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 64f37cc530f144e53c190c9e8209a51b58fd5c43 e2d0a42381b686451bed3e0e3ab8551f6c2d4090
Generating revisions with ./adhoc-revtuple-generator  https://github.com/tianocore/edk2.git#466ebdd2e0919c1538d03cd59833704bd5e1c028-06544455d0d460ed18c8582121247bf53292d7e4 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003088b173b0-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#64f37cc530f144e53c190c9e8209a51b58fd5c\
 43-2dd4b9b3f84019668719344b40dba79d681be41c git://xenbits.xen.org/xen.git#e2d0a42381b686451bed3e0e3ab8551f6c2d4090-c62d634cce8b1507d00a61bfc8168ac42367fe87
Loaded 12609 nodes in revision graph
Searching for test results:
 167225 [host=albana0]
 167231 [host=albana0]
 167237 [host=albana0]
 167239 [host=huxelrebe0]
 167240 [host=huxelrebe0]
 167242 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167247 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167253 [host=huxelrebe0]
 167258 [host=huxelrebe0]
 167260 [host=huxelrebe0]
 167262 [host=huxelrebe0]
 167081 [host=albana0]
 167103 [host=albana0]
 167104 [host=huxelrebe0]
 167267 [host=huxelrebe0]
 167271 [host=huxelrebe0]
 167274 [host=huxelrebe0]
 167276 [host=huxelrebe0]
 167275 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167277 [host=huxelrebe0]
 167278 pass 466ebdd2e0919c1538d03cd59833704bd5e1c028 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 64f37cc530f144e53c190c9e8209a51b58fd5c43 e2d0a42381b686451bed3e0e3ab8551f6c2d4090
 167280 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167279 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167281 pass dfafa8e45382939fb5dc78e9d37b97b500a43613 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb
 167282 pass 7c7184e201a90a1d2376e615e55e3f4074731468 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167283 [host=huxelrebe0]
 167284 pass e2289d19d871d8016f5d1d07a0084583f7092333 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167285 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167286 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167289 fail f5a6e1bab5d4d9d7bd0d543777290269e6c1a065 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167291 fail 26210f9436d82174fa03d1c43b58a63c2fa2c176 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167288 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167292 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167293 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167294 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167295 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167296 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167297 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167298 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167122 [host=huxelrebe0]
 166126 pass 466ebdd2e0919c1538d03cd59833704bd5e1c028 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 64f37cc530f144e53c190c9e8209a51b58fd5c43 e2d0a42381b686451bed3e0e3ab8551f6c2d4090
 166130 [host=huxelrebe0]
 166133 [host=albana1]
 166826 [host=albana0]
 166360 [host=fiano0]
 166949 [host=pinot0]
 166951 [host=pinot0]
 166961 [host=albana0]
Searching for interesting versions
 Result found: flight 166126 (pass), for basis pass
 For basis failure, parent search stopping at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55a18c22f118) HASH(0x55a18c227de8) HASH(0x55a18c229190) For basis failure, parent search stopping at e2289d19d871d8016f5d1d07a0084583f7092333 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f\
 84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55a18c22b288) For basis failure, parent search stopping at 7c7184e201a90a1d2376e615e55e3f4074731468 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1, results HASH(0x55a18c2280e8) For basis failure, parent search stopping at dfafa8e45382939fb5dc78e9d37b97b500a43613 3d273dd05e51e5a1ffba3d98c7437ee\
 84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c f0abfb5eca6821fb58c09331d0fa3ec97f86e0bb, results HASH(0x55a18c224258) For basis failure, parent search stopping at 466ebdd2e0919c1538d03cd59833704bd5e1c028 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 64f37cc530f144e53c190c9e8209a51b58fd5c43 e2d0a42381b686451bed3e0e3ab8551f6c2d4090, results HASH(0x55a18c219608) HASH(0x55a18c231bc8) Result found: flight 167242 (fail), \
 for basis failure (at ancestor ~5227)
 Repro found: flight 167278 (pass), for basis pass
 Repro found: flight 167279 (fail), for basis failure
 0 revisions at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
No revisions left to test, checking graph state.
 Result found: flight 167286 (pass), for last pass
 Result found: flight 167292 (fail), for first failure
 Repro found: flight 167294 (pass), for last pass
 Repro found: flight 167295 (fail), for first failure
 Repro found: flight 167296 (pass), for last pass
 Repro found: flight 167298 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167298/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

pnmtopng: 187 colors found
Revision graph left in /home/logs/results/bisect/ovmf/build-i386.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
167298: tolerable ALL FAIL

flight 167298 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/167298/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-i386                    6 xen-build               fail baseline untested


jobs:
 build-i386                                                   fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Thu Dec 09 22:59:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 22:59:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243425.421104 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvSNr-0005T0-H0; Thu, 09 Dec 2021 22:59:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243425.421104; Thu, 09 Dec 2021 22:59:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvSNr-0005St-DR; Thu, 09 Dec 2021 22:59:27 +0000
Received: by outflank-mailman (input) for mailman id 243425;
 Thu, 09 Dec 2021 22:59:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvSNp-0005Sj-SG; Thu, 09 Dec 2021 22:59:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvSNp-0004Ji-MH; Thu, 09 Dec 2021 22:59:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvSNp-0002rW-Dz; Thu, 09 Dec 2021 22:59:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvSNp-0008Mp-DW; Thu, 09 Dec 2021 22:59:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=u8/AqyCrw4I/pXObHBsm42bzmoz59lJcFVOKfjDd/Is=; b=L2ESqi+RntGYkkPj51GNH15lIJ
	hx5Fn7xtvMw6oRkZuz9Z94Vu2J8PYCV0+P8E8dlOd/SEqWAH3I0GwPpUGPTh8r/jFQ9qHmPtB9RLp
	L6WI+/nJn6BMsimecwMbJs0noPDSDTKeHSM0EEDr3w+C0fuGtIdLrywCBIVMO01v/C9c=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167300-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167300: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 22:59:25 +0000

flight 167300 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167300/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 09 23:59:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 09 Dec 2021 23:59:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243438.421136 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvTJf-0006LN-7C; Thu, 09 Dec 2021 23:59:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243438.421136; Thu, 09 Dec 2021 23:59:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvTJf-0006LG-3x; Thu, 09 Dec 2021 23:59:11 +0000
Received: by outflank-mailman (input) for mailman id 243438;
 Thu, 09 Dec 2021 23:59:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTJe-0006L6-Gu; Thu, 09 Dec 2021 23:59:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTJe-0005Hx-Dc; Thu, 09 Dec 2021 23:59:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTJe-0004cB-6D; Thu, 09 Dec 2021 23:59:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTJe-0001Qd-5k; Thu, 09 Dec 2021 23:59:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XAabe5mVRomve6cw4M2/gEA4hSxPE53rhgtKC1/a9mc=; b=IXdLbTlokIai2rteUDltaFpFKl
	eusdJMoekEU9RhhnCtZ6qLGGfcJW5eOZR56U7ahzNEJrK4aGA89xzRSIxVUzVWoXXpKYYpdGEzeig
	DvWbeVp5AvqB6EfKpw+hXTuEygiF+9HC6FF5h/b3AClmeWydTg1UY+XagAqIVnagTHRM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167303-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167303: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 09 Dec 2021 23:59:10 +0000

flight 167303 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167303/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 00:29:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 00:29:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243450.421157 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvTmo-0003Sr-5u; Fri, 10 Dec 2021 00:29:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243450.421157; Fri, 10 Dec 2021 00:29:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvTmo-0003Sk-2r; Fri, 10 Dec 2021 00:29:18 +0000
Received: by outflank-mailman (input) for mailman id 243450;
 Fri, 10 Dec 2021 00:29:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTmn-0003SY-Gk; Fri, 10 Dec 2021 00:29:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTmn-0006Px-AW; Fri, 10 Dec 2021 00:29:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTmn-0005HG-4H; Fri, 10 Dec 2021 00:29:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvTmn-0000iQ-3o; Fri, 10 Dec 2021 00:29:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DNlL7MIKm+JOQptmzpdX+kmIoJwD2KUg8OJv2kFcFaE=; b=hSgCHDjezHky/rNQ3GHKp3BbHw
	X5q4yIukHtUirJjbo7QRkyMflYpO3yP7ALn8y1Pag1Eum/Un3VVk68baF71ATq31RSqctA34A5QUA
	9yE/9JB3o+DHzZUUALRRTt7YstWjfmaExnrj9l47QwYJbneP2nwmm6xzmatW4oXJ8a+U=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167306-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167306: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 00:29:17 +0000

flight 167306 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167306/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   19 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 01:09:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 01:09:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243460.421183 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUPT-0003Ol-DB; Fri, 10 Dec 2021 01:09:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243460.421183; Fri, 10 Dec 2021 01:09:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUPT-0003Oe-9q; Fri, 10 Dec 2021 01:09:15 +0000
Received: by outflank-mailman (input) for mailman id 243460;
 Fri, 10 Dec 2021 01:09:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUPS-0003OU-3V; Fri, 10 Dec 2021 01:09:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUPR-0000Ez-U3; Fri, 10 Dec 2021 01:09:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUPR-0006EC-NG; Fri, 10 Dec 2021 01:09:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUPR-0000LK-Mk; Fri, 10 Dec 2021 01:09:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=O/WgSob6pEELn3W7xzY6LIi4ioj4juUjIqXPCxjVp7Y=; b=Ekw+jIgS98G29npAakl0aLiXIa
	3PekyGGsdiIZw+FW+S0COdawI8HvDNOXZK8RVzXxrywvqU5ayxZVWpMPTFfsMLCNey5HECgYJM/vw
	uZDiUEp93tFaIYx6I5YqdWdQepdhBfPV1NyqNbeE5Xoc23o60Hmkup5yCe9RIrSB/Bao=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167290-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167290: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
X-Osstest-Versions-That:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 01:09:13 +0000

flight 167290 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167290/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607
baseline version:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87

Last test of basis   167235  2021-12-08 17:03:05 Z    1 days
Testing same since   167290  2021-12-09 20:01:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c62d634cce..1384d4e1e4  1384d4e1e4ef6e846a1cac54f6d2868d40309607 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 01:14:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 01:14:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243466.421197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUUQ-0004mn-1J; Fri, 10 Dec 2021 01:14:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243466.421197; Fri, 10 Dec 2021 01:14:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUUP-0004mg-Tv; Fri, 10 Dec 2021 01:14:21 +0000
Received: by outflank-mailman (input) for mailman id 243466;
 Fri, 10 Dec 2021 01:14:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YiMI=Q3=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mvUUO-0004ma-Co
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 01:14:20 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7ee37d01-5956-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 02:14:18 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 2AA55CE2990;
 Fri, 10 Dec 2021 01:14:14 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0943C341C6;
 Fri, 10 Dec 2021 01:14:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ee37d01-5956-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639098852;
	bh=XBao+jV96uggzNgtTGEQ9TN0GRJBLJpVgy9fsKh71sk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=KWkwnJqJlXfSIa+LucGujl4Xp+gGcqN2yEl2lDGgpstmkh5XDuyBzu+5fUR4pyD6s
	 wYAocSXE8lyiRQuBSXslCjVjOUlxVosFOe1b6M9cBo3QcmUnGIuq+l4Hqwb1hSGbtP
	 c1XhVxvfxQYhNuk9chA7oCoqVOqewrTElCRqMFRc2TE+3KsohcVscWSo9MmbBrJ/9U
	 XKVWeesI1hJPZJYh+Td9YJRPlC7cB2YmFFaE910FmEV7yBKWKfkBP/eTT8+hXO4Kug
	 q4Vkp67BxhAhcc0Z1aEOCXCpQFr19u9+cOQzAClVtx5Spn3H86bTPh+dwc7WBraIz6
	 5JyBVBCt1AmUA==
Date: Thu, 9 Dec 2021 17:14:11 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under
 "hypervisor" node
In-Reply-To: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2112091714000.4091490@ubuntu-linux-20-04-desktop>
References: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 9 Dec 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Remove the following sentence:
> "This property is unnecessary when booting Dom0 using ACPI."
> for "reg" and "interrupts" properties as the initialization is not
> done via device-tree "hypervisor" node in that case anyway.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  docs/misc/arm/device-tree/guest.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
> index c115751..2b974bb 100644
> --- a/docs/misc/arm/device-tree/guest.txt
> +++ b/docs/misc/arm/device-tree/guest.txt
> @@ -15,11 +15,9 @@ the following properties:
>    or equal to gnttab_max_grant_frames()).
>    Regions 1...N are extended regions (unused address space) for mapping foreign
>    GFNs and grants, they might be absent if there is nothing to expose.
> -  This property is unnecessary when booting Dom0 using ACPI.
>  
>  - interrupts: the interrupt used by Xen to inject event notifications.
>    A GIC node is also required.
> -  This property is unnecessary when booting Dom0 using ACPI.
>  
>  To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
>  under /hypervisor with following parameters:
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 01:19:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 01:19:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243472.421208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUZg-00060s-Lf; Fri, 10 Dec 2021 01:19:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243472.421208; Fri, 10 Dec 2021 01:19:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUZg-00060l-H9; Fri, 10 Dec 2021 01:19:48 +0000
Received: by outflank-mailman (input) for mailman id 243472;
 Fri, 10 Dec 2021 01:19:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YiMI=Q3=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mvUZf-00060f-GR
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 01:19:47 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4248977d-5957-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 02:19:46 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4795FB8273C;
 Fri, 10 Dec 2021 01:19:44 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 490B3C004DD;
 Fri, 10 Dec 2021 01:19:42 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4248977d-5957-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639099183;
	bh=IFigGwU8llVFOWo9j5SLTHKDnhRiAQJVF3W4ZVu+nWE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=s0a7a6BcHfokRWz7x71QwmFziprxpA7/Id3fNMWgSO+tAuWzvD0/DQpsWZ5l1/Lkf
	 diHrCt1etTlqXz3ptTHOp17P7tIjkcoQ7cMxbA9jjhJNRTbTsCGa7PwmwE9eplH3ZC
	 4GkD1so2Kj30ZmJVXxjOQHG85CiZMR+qslDZQ/GSv0tBcPF4QvJpMKofVW5kstOSnK
	 ZHSMKsgicjCbGJW46Fk0PYaH0svJTwJSgZGnbF4CkZCW6uJKlyoPuWMAkdorsmKuWO
	 bc8eFB5yEh3bXmOO1HLbJnalu+FwSn07q0k1RAmXYyv5LpCx3LZMjbD5FZW1JH5P/g
	 v5dskxHkLyIgQ==
Date: Thu, 9 Dec 2021 17:19:41 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
    Juergen Gross <jgross@suse.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V4 4/6] xen/unpopulated-alloc: Add mechanism to use Xen
 resource
In-Reply-To: <1639080336-26573-5-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2112091719150.4091490@ubuntu-linux-20-04-desktop>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com> <1639080336-26573-5-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 9 Dec 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> The main reason of this change is that unpopulated-alloc
> code cannot be used in its current form on Arm, but there
> is a desire to reuse it to avoid wasting real RAM pages
> for the grant/foreign mappings.
> 
> The problem is that system "iomem_resource" is used for
> the address space allocation, but the really unallocated
> space can't be figured out precisely by the domain on Arm
> without hypervisor involvement. For example, not all device
> I/O regions are known by the time domain starts creating
> grant/foreign mappings. And following the advise from
> "iomem_resource" we might end up reusing these regions by
> a mistake. So, the hypervisor which maintains the P2M for
> the domain is in the best position to provide unused regions
> of guest physical address space which could be safely used
> to create grant/foreign mappings.
> 
> Introduce new helper arch_xen_unpopulated_init() which purpose
> is to create specific Xen resource based on the memory regions
> provided by the hypervisor to be used as unused space for Xen
> scratch pages. If arch doesn't define arch_xen_unpopulated_init()
> the default "iomem_resource" will be used.
> 
> Update the arguments list of allocate_resource() in fill_list()
> to always allocate a region from the hotpluggable range
> (maximum possible addressable physical memory range for which
> the linear mapping could be created). If arch doesn't define
> arch_get_mappable_range() the default range (0,-1) will be used.
> 
> The behaviour on x86 won't be changed by current patch as both
> arch_xen_unpopulated_init() and arch_get_mappable_range()
> are not implemented for it.
> 
> Also fallback to allocate xenballooned pages (balloon out RAM
> pages) if we do not have any suitable resource to work with
> (target_resource is invalid) and as the result we won't be able
> to provide unpopulated pages on a request.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Given the changes, I took a second look. The patch looks fine to me.


> ---
> Changes RFC -> V2:
>    - new patch, instead of
>     "[RFC PATCH 2/2] xen/unpopulated-alloc: Query hypervisor to provide unallocated space"
> 
> Changes V2 -> V3:
>    - update patch description and comments in code
>    - modify arch_xen_unpopulated_init() to pass target_resource as an argument
>      and update default helper to assign iomem_resource to it, also drop
>      xen_resource as it will be located in arch code in the future
>    - allocate region from hotpluggable range instead of hardcoded range (0,-1)
>      in fill_list()
>    - use %pR specifier in error message
>    - do not call unpopulated_init() at runtime from xen_alloc_unpopulated_pages(),
>      drop an extra helper and call arch_xen_unpopulated_init() directly from __init()
>    - include linux/ioport.h instead of forward declaration of struct resource
>    - replace insert_resource() with request_resource() in fill_list()
>    - add __init specifier to arch_xen_unpopulated_init()
> 
> Changes V3 -> V4:
>    - add Stefano's R-b
>    - fix copy-paste error in fill_list(), must be "if (!tmp_res)" instead of
>      "if (!res)" in string 66
>    - add unpopulated_init() with early initcall level specifically to call
>      arch_xen_unpopulated_init()
> ---
>  drivers/xen/unpopulated-alloc.c | 86 +++++++++++++++++++++++++++++++++++++++--
>  include/xen/xen.h               |  2 +
>  2 files changed, 84 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/xen/unpopulated-alloc.c b/drivers/xen/unpopulated-alloc.c
> index a03dc5b..a8b4105 100644
> --- a/drivers/xen/unpopulated-alloc.c
> +++ b/drivers/xen/unpopulated-alloc.c
> @@ -8,6 +8,7 @@
>  
>  #include <asm/page.h>
>  
> +#include <xen/balloon.h>
>  #include <xen/page.h>
>  #include <xen/xen.h>
>  
> @@ -15,13 +16,29 @@ static DEFINE_MUTEX(list_lock);
>  static struct page *page_list;
>  static unsigned int list_count;
>  
> +static struct resource *target_resource;
> +
> +/*
> + * If arch is not happy with system "iomem_resource" being used for
> + * the region allocation it can provide it's own view by creating specific
> + * Xen resource with unused regions of guest physical address space provided
> + * by the hypervisor.
> + */
> +int __weak __init arch_xen_unpopulated_init(struct resource **res)
> +{
> +	*res = &iomem_resource;
> +
> +	return 0;
> +}
> +
>  static int fill_list(unsigned int nr_pages)
>  {
>  	struct dev_pagemap *pgmap;
> -	struct resource *res;
> +	struct resource *res, *tmp_res = NULL;
>  	void *vaddr;
>  	unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION);
> -	int ret = -ENOMEM;
> +	struct range mhp_range;
> +	int ret;
>  
>  	res = kzalloc(sizeof(*res), GFP_KERNEL);
>  	if (!res)
> @@ -30,14 +47,40 @@ static int fill_list(unsigned int nr_pages)
>  	res->name = "Xen scratch";
>  	res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
>  
> -	ret = allocate_resource(&iomem_resource, res,
> -				alloc_pages * PAGE_SIZE, 0, -1,
> +	mhp_range = mhp_get_pluggable_range(true);
> +
> +	ret = allocate_resource(target_resource, res,
> +				alloc_pages * PAGE_SIZE, mhp_range.start, mhp_range.end,
>  				PAGES_PER_SECTION * PAGE_SIZE, NULL, NULL);
>  	if (ret < 0) {
>  		pr_err("Cannot allocate new IOMEM resource\n");
>  		goto err_resource;
>  	}
>  
> +	/*
> +	 * Reserve the region previously allocated from Xen resource to avoid
> +	 * re-using it by someone else.
> +	 */
> +	if (target_resource != &iomem_resource) {
> +		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
> +		if (!tmp_res) {
> +			ret = -ENOMEM;
> +			goto err_insert;
> +		}
> +
> +		tmp_res->name = res->name;
> +		tmp_res->start = res->start;
> +		tmp_res->end = res->end;
> +		tmp_res->flags = res->flags;
> +
> +		ret = request_resource(&iomem_resource, tmp_res);
> +		if (ret < 0) {
> +			pr_err("Cannot request resource %pR (%d)\n", tmp_res, ret);
> +			kfree(tmp_res);
> +			goto err_insert;
> +		}
> +	}
> +
>  	pgmap = kzalloc(sizeof(*pgmap), GFP_KERNEL);
>  	if (!pgmap) {
>  		ret = -ENOMEM;
> @@ -95,6 +138,11 @@ static int fill_list(unsigned int nr_pages)
>  err_memremap:
>  	kfree(pgmap);
>  err_pgmap:
> +	if (tmp_res) {
> +		release_resource(tmp_res);
> +		kfree(tmp_res);
> +	}
> +err_insert:
>  	release_resource(res);
>  err_resource:
>  	kfree(res);
> @@ -112,6 +160,14 @@ int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages)
>  	unsigned int i;
>  	int ret = 0;
>  
> +	/*
> +	 * Fallback to default behavior if we do not have any suitable resource
> +	 * to allocate required region from and as the result we won't be able to
> +	 * construct pages.
> +	 */
> +	if (!target_resource)
> +		return xen_alloc_ballooned_pages(nr_pages, pages);
> +
>  	mutex_lock(&list_lock);
>  	if (list_count < nr_pages) {
>  		ret = fill_list(nr_pages - list_count);
> @@ -159,6 +215,11 @@ void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages)
>  {
>  	unsigned int i;
>  
> +	if (!target_resource) {
> +		xen_free_ballooned_pages(nr_pages, pages);
> +		return;
> +	}
> +
>  	mutex_lock(&list_lock);
>  	for (i = 0; i < nr_pages; i++) {
>  		pages[i]->zone_device_data = page_list;
> @@ -201,3 +262,20 @@ static int __init init(void)
>  }
>  subsys_initcall(init);
>  #endif
> +
> +static int __init unpopulated_init(void)
> +{
> +	int ret;
> +
> +	if (!xen_domain())
> +		return -ENODEV;
> +
> +	ret = arch_xen_unpopulated_init(&target_resource);
> +	if (ret) {
> +		pr_err("xen:unpopulated: Cannot initialize target resource\n");
> +		target_resource = NULL;
> +	}
> +
> +	return ret;
> +}
> +early_initcall(unpopulated_init);
> diff --git a/include/xen/xen.h b/include/xen/xen.h
> index 86c5b37..a99bab8 100644
> --- a/include/xen/xen.h
> +++ b/include/xen/xen.h
> @@ -55,6 +55,8 @@ extern u64 xen_saved_max_mem_size;
>  #ifdef CONFIG_XEN_UNPOPULATED_ALLOC
>  int xen_alloc_unpopulated_pages(unsigned int nr_pages, struct page **pages);
>  void xen_free_unpopulated_pages(unsigned int nr_pages, struct page **pages);
> +#include <linux/ioport.h>
> +int arch_xen_unpopulated_init(struct resource **res);
>  #else
>  #include <xen/balloon.h>
>  static inline int xen_alloc_unpopulated_pages(unsigned int nr_pages,
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 01:26:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 01:26:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243479.421225 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUfX-0007TW-FV; Fri, 10 Dec 2021 01:25:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243479.421225; Fri, 10 Dec 2021 01:25:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvUfX-0007TP-CJ; Fri, 10 Dec 2021 01:25:51 +0000
Received: by outflank-mailman (input) for mailman id 243479;
 Fri, 10 Dec 2021 01:25:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUfW-0007TF-0J; Fri, 10 Dec 2021 01:25:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUfV-0000Xc-S8; Fri, 10 Dec 2021 01:25:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUfV-0006Zu-L5; Fri, 10 Dec 2021 01:25:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvUfV-0006L0-Kb; Fri, 10 Dec 2021 01:25:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Itz/ls6/HzngAG0erd1+GTipcw7ZzpV8oeuhHH6WYv4=; b=rxRWXHhsfZMu6KrdvomNNnr1j5
	zAlsqNlTapSXlnlk/BABQiwjmuK0ZnR58GjneITugD8bVhglgm+CJnz6FW2gpNtxJq1sEamajoqlV
	e9oYY9gsCmvc5y+O8NFZxVgAfZyxY4rMaLZIqBvUqA8u7SQVPks0LsuWPC8cIzApeDBA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167309-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167309: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 01:25:49 +0000

flight 167309 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167309/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   20 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 02:04:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 02:04:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243489.421251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvVGp-0005mE-Kw; Fri, 10 Dec 2021 02:04:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243489.421251; Fri, 10 Dec 2021 02:04:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvVGp-0005ln-Ds; Fri, 10 Dec 2021 02:04:23 +0000
Received: by outflank-mailman (input) for mailman id 243489;
 Fri, 10 Dec 2021 02:04:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=YiMI=Q3=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mvVGo-0005lh-E0
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 02:04:22 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7c1650e3-595d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 03:04:20 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 84B8EB82644;
 Fri, 10 Dec 2021 02:04:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2C92C004DD;
 Fri, 10 Dec 2021 02:04:16 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c1650e3-595d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639101857;
	bh=U67NjGy23B7a2CRB6V77fX8dqOD5vv6HfJ+pk6269IU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=F29VQywYB5zc/0gAyrppGD/8PJlSu6CWLF1vgTYDpPWsEl0Ph4MtRWl9jJ5xHMb7H
	 JctlrCYml8V3jN+x/ypB2gW8lRT3EMFBmvuzx0BJvcPUfIA+yrDHTm9z2kuvUqPm5E
	 qLnYx1IaM23kAW72oA7IWgy9w6KjlMz+MdXtSlIxnGvP/ulyrveQwB4Ja25C17RW62
	 bSEHJ10lXrpPvBsyGncY/XMN3kxnBTw+BxMrOqJEfWPmUw0J/AhSU++lGjvLACZ2wb
	 OYnzxOo2oN1XdlA64MPZyB/FfIS4nk70Oy2FAx0ZK1KnAPLQeDrgAlNHNNvTqwieq7
	 9kYO1QEgGi5sA==
Date: Thu, 9 Dec 2021 18:04:15 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Sergiy Kibrik <sakib@darkstar.site>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Roman Skakun <rm.skakun@gmail.com>, xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Andrii Anisov <andrii_anisov@epam.com>, 
    Sergiy Kibrik <sergiy_kibrik@epam.com>
Subject: Re: [RFC 1/1] xen/arm: set iommu property for IOMMU-protected
 devices
In-Reply-To: <c789cc71-db2d-0735-f007-e93bd23a81a5@darkstar.site>
Message-ID: <alpine.DEB.2.22.394.2112091733590.4091490@ubuntu-linux-20-04-desktop>
References: <cover.1633106362.git.roman_skakun@epam.com> <5b101e4e85668bbb18da83044520b0350344f408.1633106362.git.roman_skakun@epam.com> <17547d29-8e15-96f6-2418-5f7ca1c3237d@xen.org> <alpine.DEB.2.22.394.2111101306180.440530@ubuntu-linux-20-04-desktop>
 <c789cc71-db2d-0735-f007-e93bd23a81a5@darkstar.site>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1379446046-1639100300=:4091490"
Content-ID: <alpine.DEB.2.22.394.2112091738250.4091490@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1379446046-1639100300=:4091490
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2112091738251.4091490@ubuntu-linux-20-04-desktop>

On Tue, 7 Dec 2021, Sergiy Kibrik wrote:
> hi Stefano, Julien,
> 
> On 11/10/21 11:12 пп, Stefano Stabellini wrote:
> > On Mon, 8 Nov 2021, Julien Grall wrote:
> [..]
> > > A few years ago, I attempted to disable the swiotlb when Xen configured
> > > the
> > > IOMMU for the device (see [1]). Did you have a chance to go through the
> > > thread? In particular, I think Ian Campbell suggestion about creating an
> > > IOMMU
> > > binding is quite interesting.
> > > 
> > > Stefano, what do you think?
> > 
> > Yes I think it is a good idea. In fact, thinking more about it, it is
> > really the best option. Regardless of the implementation (swiotlb or
> > whatever) the device tree description is likely to look similar to the
> > description of an IOMMU because it is the common pattern shared by all
> > controllers (reset, power, clocks, etc.) so it makes sense to re-use it.
> > 
> > - there is one controller node (the "IOMMU")
> > - there is one property under each device node that is protected,
> >    pointing to the controller with a phandle and optional parameters (in
> >    the case of IOMMUs it is called "iommus")
> > 
> 
> Code in arch_setup_dma_ops() always forces swiotlb for dom0 regardless of any
> prior IOMMU configuration for the device.

Yes. The only exception is cases where XENFEAT_not_direct_mapped is set.


> So if we are to re-use IOMMU bindings and implement kind of dummy
> iommu (that merely does direct allocation and mapping) we'll have to
> check whether device is protected anyway

Yes, the Linux-side implementation wouldn't change very much compared to
what you had in mind, it is just that the device tree part would be
cleaner and more spec compliant.

We would still end up with a property for each to device to specify that
is protected by the IOMMU, it is just that instead of "xen,behind-iommu"
it would be called "iommus" and it would be pointing to a special "fake"
Xen IOMMU node. E.g.:


xen-iommu {
    compatible = "xen,iommu-el2-v1";
    status = "okay";
    #iommu-cells = <0x0>;
};


device@ff00000 {
    compatible = "vendor,device";
    reg = <0xff00000 0x1000>;
    iommus = <&xen-iommu>;
};


I can imagine it could a be problem to try to comply to the internal
iommu API in Linux. The Linux driver for xen-iommu could be tiny. It
doesn't have to implement the Linux iommu API because struct iommu_ops
is massive.

Linux would still have to check for each device if it is protected by
the iommu, but the "iommus" property is parsed automatically by
drivers/of/property.c:of_link_property. It should make the Linux side
easier to implement. of_link_property creates a fwnode "link" between
device@ff00000 and xen-iommu automatically for you, then I think you can
just call fwnode_find_reference to check if device@ff00000 is behind an
IOMMU.



> e.g.:
> 
>   diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
>   index 49f566ad9acb..6ddef3233095 100644
>   --- a/arch/arm/xen/enlighten.c
>   +++ b/arch/arm/xen/enlighten.c
>   @@ -425,6 +425,10 @@ static int __init xen_pm_init(void)
>    }
>    late_initcall(xen_pm_init);
> 
>   +bool xen_is_device_protected(struct device *dev) {
>   +	return dev->dma_ops == &dummy_xen_iommu_ops;
>   +}
> 
>    /* empty stubs */
>    void xen_arch_pre_suspend(void) { }
> 
> 
> Have I got it right?

I don't think I understand this example
--8323329-1379446046-1639100300=:4091490--


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 02:25:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 02:25:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243495.421268 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvVaI-0000rp-4L; Fri, 10 Dec 2021 02:24:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243495.421268; Fri, 10 Dec 2021 02:24:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvVaI-0000ri-0A; Fri, 10 Dec 2021 02:24:30 +0000
Received: by outflank-mailman (input) for mailman id 243495;
 Fri, 10 Dec 2021 02:24:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvVaG-0000rY-2v; Fri, 10 Dec 2021 02:24:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvVaF-00022j-Nw; Fri, 10 Dec 2021 02:24:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvVaF-00084S-Fu; Fri, 10 Dec 2021 02:24:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvVaF-0006sb-FP; Fri, 10 Dec 2021 02:24:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZcaARWtgwMDo6U3f0HAwWY9pd4k2ToF9jC6x49f3IA4=; b=FeyJTzNZA8rwzmC80AEVxShTHR
	u5R81+RW1gdzvWfRu/+aAqI+McPvxkaT1YqSq4nHdcxjjytnv7tq7OEw/ozUZ5Mf+BZS3MSdvNKC/
	wMDjbDRiRIudZPGZli2GBPX20hvWhpgNn8XizH9Fl35YrqY06R8FgCnFadR+ZyQatgXk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167287-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167287: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ded746bfc94398d2ee9de315a187677b207b2004
X-Osstest-Versions-That:
    linux=2a987e65025e2b79c6d453b78cb5985ac6e5eb26
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 02:24:27 +0000

flight 167287 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167287/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167229
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167229
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167229
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167229
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167229
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167229
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167229
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167229
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                ded746bfc94398d2ee9de315a187677b207b2004
baseline version:
 linux                2a987e65025e2b79c6d453b78cb5985ac6e5eb26

Last test of basis   167229  2021-12-08 05:58:09 Z    1 days
Testing same since   167287  2021-12-09 19:40:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Potapenko <glider@google.com>
  Alexei Starovoitov <ast@kernel.org>
  Alok Prasad <palok@marvell.com>
  Ameer Hamza <amhamza.mgc@gmail.com>
  Andrea Mayer <andrea.mayer@uniroma2.it>
  Andrii Nakryiko <andrii@kernel.org>
  Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
  Antoine Tenart <atenart@kernel.org>
  Ariel Elior <aelior@marvell.com>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bindushree P <Bindushree.p@intel.com>
  Björn Töpel <bjorn@kernel.org>
  Brian Silverman <brian.silverman@bluerivertech.com>
  Cai Huoqing <caihuoqing@baidu.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Dave Ertman <david.m.ertman@intel.com>
  David Ahern <dsahern@kernel.org>
  David Howells <dhowells@redhat.com>
  David S. Miller <davem@davemloft.net>
  Davide Caratti <dcaratti@redhat.com>
  Emmanuel Deloget <emmanuel.deloget@eho.link>
  Eric Dumazet <edumazet@google.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
  Guolin Yang <gyang@vmware.com>
  Gurucharan G <gurucharanx.g@intel.com>
  Hans de Goede <hdegoede@redhat.com>
  Herve Codina <herve.codina@bootlin.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  Jani Nikula <jani.nikula@intel.com>
  Jarkko Nikula <jarkko.nikula@linux.intel.com>
  Jeff Layton <jlayton@kernel.org>
  Jeffle Xu <jefflexu@linux.alibaba.com>
  Jesper Dangaard Brouer <brouer@redhat.com>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jianglei Nie <niejianglei2021@163.com>
  Jianguo Wu <wujianguo@chinatelecom.cn>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jimmy Assarsson <extja@kvaser.com>
  Jiri Kosina <jkosina@suse.cz>
  Jiri Pirko <jiri@nvidia.com>
  Joakim Zhang <qiangqing.zhang@nxp.com>
  Johan Almbladh <johan.almbladh@anyfinetworks.com>
  John Fastabend <john.fastabend@gmail.com>
  Jon Hunter <jonathanh@nvidia.com>
  José Expósito <jose.exposito89@gmail.com>
  Julian Wiedmann <jwi@linux.ibm.com>
  Karen Sornek <karen.sornek@intel.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Krzysztof Wilczyński <kw@linux.com>
  Kumar Kartikeya Dwivedi <memxor@gmail.com>
  Kuniyuki Iwashima <kuniyu@amazon.co.jp>
  Lee Jones <lee.jones@linaro.org>
  Li Zhijian <zhijianx.li@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Louis Amas <louis.amas@eho.link>
  M Chetan Kumar <m.chetan.kumar@linux.intel.com>
  Maarten Zanders <maarten.zanders@mind.be>
  Manish Chopra <manishc@marvell.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Martyn Welch <martyn.welch@collabora.com>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Michal Maloszewski <michal.maloszewski@intel.com>
  Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Mitch Williams <mitch.a.williams@intel.com>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
  Norbert Zulinski <norbertx.zulinski@intel.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paul Greenwalt <paul.greenwalt@intel.com>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Chen <peter.chen@kernel.org>
  Petr Machata <petrm@nvidia.com>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Ronak Doshi <doshir@vmware.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Russell King <rmk+kernel@armlinux.org.uk>
  Sandeep Penigalapati <sandeep.penigalapati@intel.com>
  Sasha Levin <sashal@kernel.org>
  Sebastian Andrzej Siewior <bigeasy@linutronix.de>
  SeongJae Park <sj@kernel.org>
  Simon Horman <simon.horman@corigine.com>
  Song Liu <songliubraving@fb.com>
  Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
  Stefano Brivio <sbrivio@redhat.com>
  Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Thomas Weißschuh <linux@weissschuh.net>
  Tony Brelinski <tony.brelinski@intel.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vadim Fedorenko <vfedorenko@novek.ru>
  Vincent Mailhol <mailhol.vincent@wanadoo.fr>
  xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
  Yahui Cao <yahui.cao@intel.com>
  Yanteng Si <siyanteng01@gmail.com>
  Yanteng Si <siyanteng@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2a987e65025e..ded746bfc943  ded746bfc94398d2ee9de315a187677b207b2004 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 03:09:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 03:09:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243504.421288 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvWHs-00081A-VS; Fri, 10 Dec 2021 03:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243504.421288; Fri, 10 Dec 2021 03:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvWHs-000813-SX; Fri, 10 Dec 2021 03:09:32 +0000
Received: by outflank-mailman (input) for mailman id 243504;
 Fri, 10 Dec 2021 03:09:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWHr-00080t-Ob; Fri, 10 Dec 2021 03:09:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWHr-0002oq-G4; Fri, 10 Dec 2021 03:09:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWHr-0001mB-7n; Fri, 10 Dec 2021 03:09:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWHr-00049L-7I; Fri, 10 Dec 2021 03:09:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Mf7oSX3swAVvrxrIHdGTEKZPDiRapfkIhEWufMzyakI=; b=mUmu3Bd3/XxU4ffAQ5ll4VMhoW
	ajvzBSEIkRu+IsMR564aHSEKE1reCyO2qLntHYiIFV2O5j1SYkr0EXN/kyk9tmsZah0alax+SNFIU
	3T6T7Q+PV3Eh4dp4sAn6y8W+URGbMGcYjtOck5lmVtUJG6M6KSyaLKH7I6CbPQrUSWZM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167314-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167314: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 03:09:31 +0000

flight 167314 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167314/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   21 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 03:55:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 03:55:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243521.421320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvWzv-0006q1-Mx; Fri, 10 Dec 2021 03:55:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243521.421320; Fri, 10 Dec 2021 03:55:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvWzv-0006pu-IJ; Fri, 10 Dec 2021 03:55:03 +0000
Received: by outflank-mailman (input) for mailman id 243521;
 Fri, 10 Dec 2021 03:55:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWzu-0006pk-5p; Fri, 10 Dec 2021 03:55:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWzt-0003cA-Vy; Fri, 10 Dec 2021 03:55:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWzt-0003Ak-PR; Fri, 10 Dec 2021 03:55:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvWzt-00031Q-Ow; Fri, 10 Dec 2021 03:55:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8ZXCcIeFuZqpbfHIBB5jVG55jiA0cUXMX3G5yTYR+hM=; b=sajdb+pBCPN5xs92JENEbkNE6z
	7Rovw/IoqfnK5dfv3BP7TJzot6qY3ZTqEfYdPyEca3L0to1n46vJF4jHsAl9uua7K0957p1JGXWbM
	ODXYiXl8tvMEcYisSSnSdjA4HhibZRd6aalCZfACriio/pegbUf7qSXAxBP3yYmv+TgA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167319-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167319: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 03:55:01 +0000

flight 167319 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167319/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   22 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 05:19:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 05:19:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243536.421358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvYIj-0003LW-VM; Fri, 10 Dec 2021 05:18:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243536.421358; Fri, 10 Dec 2021 05:18:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvYIj-0003LP-S8; Fri, 10 Dec 2021 05:18:33 +0000
Received: by outflank-mailman (input) for mailman id 243536;
 Fri, 10 Dec 2021 05:18:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvYIi-0003LC-Qf; Fri, 10 Dec 2021 05:18:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvYIi-0005XU-NG; Fri, 10 Dec 2021 05:18:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvYIi-00073U-Fy; Fri, 10 Dec 2021 05:18:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvYIi-0004Mx-FR; Fri, 10 Dec 2021 05:18:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XfUm1gbd1r0FX7+hMA+Dy/O3BhGliiZr6zjXvtjQ/1A=; b=68v3MzBpUihyjPncPhwDSsr90f
	PEy3Uu3SueFJB8n7TM9nh3uYncoqeMDDqgmxLRrAUkJxil9Yp9/sFqx9y6Gnfdh/hCCXQ+CwEoU8I
	zQHXLb/apiW5JE0Je7+Bzg0K+E0WsNMbitR6VUnmcGWFPRWEEzAbiNlRCRpi6rdEpg70=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167324-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167324: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 05:18:32 +0000

flight 167324 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167324/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    0 days
Testing same since   167240  2021-12-09 08:42:46 Z    0 days   23 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 06:45:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 06:45:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243551.421395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvZdp-00084A-GQ; Fri, 10 Dec 2021 06:44:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243551.421395; Fri, 10 Dec 2021 06:44:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvZdp-000843-DS; Fri, 10 Dec 2021 06:44:25 +0000
Received: by outflank-mailman (input) for mailman id 243551;
 Fri, 10 Dec 2021 06:44:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvZdo-00083t-Ak; Fri, 10 Dec 2021 06:44:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvZdo-00073H-5R; Fri, 10 Dec 2021 06:44:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvZdn-0004ss-VM; Fri, 10 Dec 2021 06:44:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvZdn-0007VC-Ur; Fri, 10 Dec 2021 06:44:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To;
	bh=KL+X/i8cNmtvLqtIXm3ZyQql1KQGGQlImS5ELeko1Nk=; b=CoWA4G6CLXKKftRjDnLtLUFNZj
	sTXYWvCfhgNmybgByXmOrs+ClekWLLi6mFIsFzw5SreRbLiFX7TDdqkftZiG/JZq5Ql/FIU7ZaWmM
	TnCXvL1A+/E2Fwr+qyobya2lSoRObyx2x4tbBq1tmzRDa6aaUS90MR/fYsMvItcFR0EU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Subject: [ovmf bisection] complete build-amd64-xsm
Message-Id: <E1mvZdn-0007VC-Ur@osstest.test-lab.xenproject.org>
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 06:44:23 +0000

branch xen-unstable
xenbranch xen-unstable
job build-amd64-xsm
testid xen-build

Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167333/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64-xsm.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build --summary-out=tmp/167333.bisection-summary --basis-template=167239 --blessings=real,real-bisect,real-retry ovmf build-amd64-xsm xen-build
Searching for failure / basis pass:
 167324 fail [host=himrod1] / 167239 ok.
Failure / basis pass flights: 167324 / 167239
(tree with no url: minios)
Tree: ovmf https://github.com/tianocore/edk2.git
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: seabios git://xenbits.xen.org/osstest/seabios.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Basis pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
Generating revisions with ./adhoc-revtuple-generator  https://github.com/tianocore/edk2.git#c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d-06544455d0d460ed18c8582121247bf53292d7e4 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b6e539830bf45e2d7a6bd86ddfdf003088b173b0-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#2dd4b9b3f84019668719344b40dba79d681be4\
 1c-2dd4b9b3f84019668719344b40dba79d681be41c git://xenbits.xen.org/xen.git#608531a0cc34a5bc096ccf585e16f182b5ed83e1-c62d634cce8b1507d00a61bfc8168ac42367fe87
Loaded 10001 nodes in revision graph
Searching for test results:
 167239 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167240 fail irrelevant
 167242 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167247 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167253 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167258 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167260 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167262 [host=himrod2]
 167267 [host=himrod2]
 167271 [host=himrod2]
 167275 [host=himrod2]
 167279 [host=himrod2]
 167283 [host=himrod2]
 167285 [host=himrod2]
 167288 [host=himrod2]
 167293 [host=himrod2]
 167297 [host=himrod2]
 167299 [host=himrod2]
 167300 [host=himrod2]
 167301 [host=himrod2]
 167302 [host=himrod2]
 167303 [host=himrod2]
 167304 [host=himrod2]
 167305 [host=himrod2]
 167306 [host=himrod2]
 167307 [host=himrod2]
 167308 [host=himrod2]
 167310 [host=himrod2]
 167309 [host=himrod2]
 167311 [host=himrod2]
 167313 [host=himrod2]
 167315 [host=himrod2]
 167316 [host=himrod2]
 167314 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167318 [host=himrod2]
 167320 pass c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1
 167321 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167319 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167322 pass d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167323 fail f4e3ce5f532860bbcf3a78d38f699dfbff0e1e75 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167326 fail 8eb79b5f4fed31667f27b7ac97b568724fe12496 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167327 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167324 fail 06544455d0d460ed18c8582121247bf53292d7e4 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167328 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167329 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167331 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167332 pass d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
 167333 fail 202fb22be6e9100c2ce6329f1b09f885dfdb514a 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
Searching for interesting versions
 Result found: flight 167239 (pass), for basis pass
 For basis failure, parent search stopping at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55c2b1201050) HASH(0x55c2b120a440) HASH(0x55c2b120abc0) For basis failure, parent search stopping at d706f8fec256585de76280d2a1e1aa9550cefe12 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f\
 84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87, results HASH(0x55c2b120e2d0) For basis failure, parent search stopping at c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c 608531a0cc34a5bc096ccf585e16f182b5ed83e1, results HASH(0x55c2b11fa890) HASH(0x55c2b120de50) Result found: flight 167242 (fail), for basis failure (at ancestor ~5226)
 Repro found: flight 167320 (pass), for basis pass
 Repro found: flight 167321 (fail), for basis failure
 0 revisions at d39f8d88ecb31df46e2f95bcc5c20100d1f14681 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 2dd4b9b3f84019668719344b40dba79d681be41c c62d634cce8b1507d00a61bfc8168ac42367fe87
No revisions left to test, checking graph state.
 Result found: flight 167327 (pass), for last pass
 Result found: flight 167328 (fail), for first failure
 Repro found: flight 167329 (pass), for last pass
 Repro found: flight 167331 (fail), for first failure
 Repro found: flight 167332 (pass), for last pass
 Repro found: flight 167333 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  ovmf https://github.com/tianocore/edk2.git
  Bug introduced:  202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Bug not present: d39f8d88ecb31df46e2f95bcc5c20100d1f14681
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167333/


  commit 202fb22be6e9100c2ce6329f1b09f885dfdb514a
  Author: Brijesh Singh <brijesh.singh@amd.com>
  Date:   Thu Dec 9 11:27:46 2021 +0800
  
      OvmfPkg/SecMain: validate the memory used for decompressing Fv
      
      BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
      
      The VMM launch sequence should have pre-validated all the data pages used
      in the Reset vector. The range does not cover the data pages used during
      the SEC phase (mainly PEI and DXE firmware volume decompression memory).
      
      When SEV-SNP is active, the memory must be pre-validated before the access.
      Add support to pre-validate the memory range from SnpSecPreValidatedStart
      to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
      phase.
      
      Cc: Michael Roth <michael.roth@amd.com>
      Cc: James Bottomley <jejb@linux.ibm.com>
      Cc: Min Xu <min.m.xu@intel.com>
      Cc: Jiewen Yao <jiewen.yao@intel.com>
      Cc: Tom Lendacky <thomas.lendacky@amd.com>
      Cc: Jordan Justen <jordan.l.justen@intel.com>
      Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
      Cc: Erdem Aktas <erdemaktas@google.com>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
      Acked-by: Gerd Hoffmann <kraxel@redhat.com>
      Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>

Revision graph left in /home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
167333: tolerable ALL FAIL

flight 167333 ovmf real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/167333/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64-xsm               6 xen-build               fail baseline untested


jobs:
 build-amd64-xsm                                              fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 07:17:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 07:17:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243570.421410 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mva9p-0005Kx-Co; Fri, 10 Dec 2021 07:17:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243570.421410; Fri, 10 Dec 2021 07:17:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mva9p-0005Kq-9T; Fri, 10 Dec 2021 07:17:29 +0000
Received: by outflank-mailman (input) for mailman id 243570;
 Fri, 10 Dec 2021 07:17:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mva9n-0005Kk-3Y
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 07:17:27 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 391a1e09-5989-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 08:17:25 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-sFV3Q1qiPvmvmaI9T__A6w-1; Fri, 10 Dec 2021 08:17:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4941.eurprd04.prod.outlook.com (2603:10a6:803:5a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 07:17:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 07:17:21 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0065.eurprd06.prod.outlook.com (2603:10a6:20b:464::30) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 07:17:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 391a1e09-5989-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639120644;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qTJHBXBYJiKrNOAYivvW1Yd32lTL4XfvIVCkx9TaDgE=;
	b=FG/xubrz7S9VkDwA1KexaO0fdMeaUXZ/lbu9xA7zEH1AZfIXDsJk27SGiJ6DA6dB/NABuk
	n/YviR6aZ884Ii6BlVBOIYilVKryOsVgG6Mcd3LIPv8V0leLZXQ7CukzNhZ3A/FnO5d/Qn
	shUcVEOWiiPkhNromnRkzHnKLxfyd5Q=
X-MC-Unique: sFV3Q1qiPvmvmaI9T__A6w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=C4An3dbcWzZEB32j4bPA7u06yJssm9b5wFmHXWlzpArqxiLX72wxwPxlrydeKU0Dt3CViF4jBwbXm8AWVWlkSc0dFNNeQgyfS58gVBN87qsN5hH0PIoRnK2QL0Y6h5RiEpcMDuhEdA9r/AepyAXaYs0/+rfWC7/xMz8Lra1pqAx04TjyTicF7VX9fuUikflhJuTPzc41urG6CSyi4CSLq2YaeFMdWW9v4jF2nuFhEkrXgP6NZrKouziJYCwhyCSbeNBfdlnmUvKX6kLDIq/Zv6ljBovcmfPN9opE0jOP1DDGAzTbenT3u0wPtMYwJhP5qr2h8GOmoW90Nuh+rIw+0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xYvbAMf7AiU9d3+al0R/spdp5o8vYM6nvrltMMyf4Bk=;
 b=Yg3lfJWynl1ufG+0RhNB69midI/fsk1pQBf3UuwI2iRhdTMkrTrPjobnMQdevNjlij5aiqibenoYglVyVEA/9497hSiCfzwf9b14XkKdeTWgtJfeCTo9nw+/7zZKgM7NURujRQ14FjA2h+pI4NCBUMBlITDFWEjnqXrD1NbBzFB762znqLXRrtTNafsb2+Fxl7JDrPnxTm6llk1WpgO/ysW/Qpyq0sb9k1xPRtnIQ5+C0eciYnWit34qCyhidtOo5S8oliMMHjgJmJwlDGM1LJ8wQpvTbXfp6mzVaoZsonOvcQHJ2nSU/a1gykhnLdwXfeRLpNaOd5zBI81WSEAMMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f522b9df-1ef5-4fa0-7c77-f4b142164df9@suse.com>
Date: Fri, 10 Dec 2021 08:17:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] x86/boot: Drop pte_update_limit from physical
 relocation logic
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-2-andrew.cooper3@citrix.com>
 <dc3f5bf2-53f9-7dcd-2be7-f9f953b382cb@suse.com>
 <736f40e4-0297-ba7b-abce-c9b67ad8eb31@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <736f40e4-0297-ba7b-abce-c9b67ad8eb31@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0065.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 55493465-6447-4e3d-14ef-08d9bbad1b29
X-MS-TrafficTypeDiagnostic: VI1PR04MB4941:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4941BBD4DD4BBB1C9ED66FB8B3719@VI1PR04MB4941.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aHdfs72u/0GWjMwXFeakIfPOyj0jXkVhrexPzP7cJQiLxOXL8NTcgfv3Z0PWLNhe0wqnM20lEJ0yl6k8L3Q04Uy0WQEW64kZfRom8mCFxzZ149uBmQQ/f76cSOu3sZHGTeoLowt6Rs4IoBhPs03WMuPkSXoc67q2eTmw3gKrvmRv5JQoHA7RbHfBb9Fr8qHjIhvow+rwMgAR6DQMraed+2hnntsjfFQc/DiJs8yLD4Fd/6wPHYVl0scD19bsVXf5NUNKz44cgvbvM0JEl4KWyENtc5RGsq0Ow+2r7mX0bWgUoD712VmCdvyrX7bQpDNG9JYsxjxT4J3bSnmEMnmFSTca4NS0GYpb+8bTPJN9Fy6xZeCBnUwDNxdZygKV3lmgX/O91o1x2w5KBq20kWr/3WrhteRSh/oF7tAa6Ug20iiai86SoiHus7sK2A1/Qo+kZ8GuEAnSeNCq7fsGuJBjrmQeMghgIi2cDqZshMo6OWbxDY81OU9KZGg7KwhOqWxytYUalDNwSRr4BLqSye7Ne0LcAchSXtdopedA3beldXLa3TmS3BrR6vr2jZcEh+KuBqo5rh/E+wgH3k7OYWoWagVp39faWYxjqgZftmY2h+rAJ3MJ46YysSiRJ0NS78GVp0LXoqMB8jXMf2vPeR601XtiqSdr54aDBVhSpah7M+eeffls9w0nxqa3d1sbTfNeHJ7acizvGOIxH65n1UlkK3fiz1y9I+IoN3/DSV01s78=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(53546011)(5660300002)(86362001)(26005)(186003)(83380400001)(36756003)(4326008)(31686004)(110136005)(16576012)(66556008)(66946007)(956004)(54906003)(38100700002)(31696002)(6486002)(8676002)(316002)(66476007)(2906002)(2616005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?n0bawmMTyN4TBzm2tXowRTZelBJUV1wRpcLEO7My0MRN+KRJeqMN9iEBIX5h?=
 =?us-ascii?Q?suD+gLgzFad4WMp8n+nBHlOUJ7QWcCUV4YwKkoeRz52P8ecVQ10S6aa9YyRz?=
 =?us-ascii?Q?8Dlc5bKxniYx2Gp3McCJYmirAzGfow2T1SnG5geo64IHmJZkGjUz+GXkw6lH?=
 =?us-ascii?Q?33GurFhaGXCXmarriRCFbmlIWVuld8KAaBzssgE59TaU6HiQinSknaOapsXC?=
 =?us-ascii?Q?Y5AFcF1q4Nj5SuMYUgWE2lBVwJjMieLjbaRcb43mgFXeT0I0G8OoYIyp/oWO?=
 =?us-ascii?Q?D1EMLROGIA927HVmNraUnEl8jnWnRGwL9svqQyXeW6Ue5NcfrnBLwpLIIRhg?=
 =?us-ascii?Q?t6sbQtHMWJ4P/XiftvEpgydRGeNG/w76wHFk7qR32V0lpA16HPEiDIo6SAH7?=
 =?us-ascii?Q?7AvipKq95TDxkDHeFDvmsWCVyc6wf3fHUqkmgzmJBRl250onEOao+mB+q+l+?=
 =?us-ascii?Q?amM2rFYMDTpYY9Ysm+LUaK3nBYGim3E8XdbH3mA8+rDAhrltfseSo5G6TE3z?=
 =?us-ascii?Q?VlLNo6GPOHGf/kDfNwVKzZhN0eGhgytdOU3DRlDcMb/LM4yMXWLAeEaEU+Xz?=
 =?us-ascii?Q?zNijlegECsnj/qIRxIZWJiOEAp1U9CLlbWr/jrzUcOGGFX8kXDYgOSdb83hL?=
 =?us-ascii?Q?xa1OhZt8nZJjsBW13o7zWNBG7N2ev0VTfokTxqX/A/FoNsUvW4fCrcoej7Zm?=
 =?us-ascii?Q?hAGZLW9m72SiwnTw0Uu3rncprDXtD8oC7H/5fFGS/JFcFmrBnUcuIZUaNxN0?=
 =?us-ascii?Q?eSUfGrtPI0wswOPlUSWm2ZahGbQ/Fc5y7mo0iT28kJMlRnz39H/d5HW9Bx3D?=
 =?us-ascii?Q?OifyJRmzSh7nmZHZkkQ8M1zko3a58daGhijSUKGsCoxxMove+jEwUyaTNjHB?=
 =?us-ascii?Q?XLtZ7P9c5fQHueAsIPLbJBvDBv+1T9D1qsC6Bn3h5bIEYfxt+ejCeUZL4fwE?=
 =?us-ascii?Q?aTay4VXzY336hRVjAeU8WJd0HRCGpCAKUOwMcDU11rPw6Q47zDaU5Lk3Rksl?=
 =?us-ascii?Q?MMlZR3oJSnB+H/DkCJbQDowU6ItA1NfEx/2FoslCN5fnY9ZCAdop4wsIw9da?=
 =?us-ascii?Q?DAMPI4VoM9YUkuhXK7v88PC/M98CgzKbxGCCqOgJ9eq0fChUm2oI+AxCyif4?=
 =?us-ascii?Q?8s6gkMdckUOVRJ1MRguqwGNYIuJCSimONb+3Oj3ibEEI+yiV4rLoKKk5nCPW?=
 =?us-ascii?Q?t24WvIUzMlkx2YYZ/ncxZa6d+FJ6aFMTMOSraFYLueGWecH8hcZEjrTAcZwA?=
 =?us-ascii?Q?5kB7zw5YG/N65i2cQ40Eel5Mt9aK2WOWWMiCAJW9WHkNQbKvw8hwOKVxB3pm?=
 =?us-ascii?Q?dbbbF3mBcOTOgOe+xVJx0K+QMwbDfM5h4eFrnO/0ts9AWKRfsclwtCLX7oIG?=
 =?us-ascii?Q?FPp+lLm7v5qLzF+LfNuM5oFDhBSEiBc5q+zNgcZpDcjsP4G8A9YE/cVS3d0p?=
 =?us-ascii?Q?a+qfuyYkh4gQOWNikJt1RX0Dafzv7LAulTSvN+v+Y08WSm0JKW3Ce6Fu761n?=
 =?us-ascii?Q?OkMtJRM2DaCC7rUsWin76UeopZKXuEhNs5HJbC74W/9B1XQexg4Q4rTzTQW8?=
 =?us-ascii?Q?P6OD2M53IM6Oflk87koXOGA8jMWzbQ8L0DNGGNYgXTU6lnhU1gcNZrgKAQQu?=
 =?us-ascii?Q?4oAHocmQ5eZNcfR1LUJ9/QQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55493465-6447-4e3d-14ef-08d9bbad1b29
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 07:17:21.1168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XnYyiEK9EUpoASNMOi4L68sh3fZ9fRgq9HqqBNI18smi90ya2FJ0u36xQXGLKOWu/4dMMIiJWbr7YXL4zZF0qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4941

On 09.12.2021 18:34, Andrew Cooper wrote:
> On 07/12/2021 11:37, Jan Beulich wrote:
>> On 07.12.2021 11:53, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -1230,7 +1230,6 @@ void __init noreturn __start_xen(unsigned long mb=
i_p)
>>>              l3_pgentry_t *pl3e;
>>>              l2_pgentry_t *pl2e;
>>>              int i, j, k;
>>> -            unsigned long pte_update_limit;
>>> =20
>>>              /* Select relocation address. */
>>>              xen_phys_start =3D end - reloc_size;
>>> @@ -1238,14 +1237,6 @@ void __init noreturn __start_xen(unsigned long m=
bi_p)
>>>              bootsym(trampoline_xen_phys_start) =3D xen_phys_start;
>>> =20
>>>              /*
>>> -             * No PTEs pointing above this address are candidates for =
relocation.
>>> -             * Due to possibility of partial overlap of the end of sou=
rce image
>>> -             * and the beginning of region for destination image some =
PTEs may
>>> -             * point to addresses in range [e, e + XEN_IMG_OFFSET).
>>> -             */
>>> -            pte_update_limit =3D PFN_DOWN(e);
>> ... considering the comment here: Isn't it 0d31d1680868 ("x86/setup: do
>> not relocate Xen over current Xen image placement") where need for this
>> disappeared? Afaict the non-overlap of source and destination is the
>> crucial factor here, yet your description doesn't mention this aspect at
>> all. I'd therefore like to ask for an adjustment there.
>=20
> I don't consider that commit relevant.
>=20
> There is no circumstance ever where you can relocate Xen with
> actually-overlapping ranges, because one way or another, you'd end up
> copying non-pagetable data over the live pagetables.

That was fragile, yes. I think I (vaguely!) recall a discussion I had
with Keir about this, with him pointing out that the logic builds upon
all necessary mappings being held in the TLB. If you strictly think
that's not worthwhile to consider or mention, then so be it.

> That particular commit was part of trying to make Xen's entry code
> relocatable, so the MB2 path could load Xen at somewhere which wasn't 0,
> but to this day we still skip any physical relocation if Xen isn't
> started at 0.
>=20
>=20
> To the comment specifically, it's actively wrong.
>=20
> Back when XEN_IMG_OFFSET was 1M, and we had 16M worth of unconditional
> mappings, then we could get PTE overlap as described, in the corner case
> where we were moving Xen from 0 to anywhere between 4 and 16M physical
> (2M physical was in principle a problem, but not an eligible position to
> relocate to, given Xen's compile size).
>=20
> And in that corner case, the logic would "corrupt" various PTEs by not
> relocating them.=C2=A0 The PTE coving _start at 1M was special cased ahea=
d of
> the 2nd loop (finally fixed last week) and the PTEs mapping beyond _end
> were unused which is why nothing actually went wrong.

The latter fact being why I guess you've put "corrupt" in quotes.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 07:35:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 07:35:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243585.421421 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvaR6-0008Dd-T9; Fri, 10 Dec 2021 07:35:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243585.421421; Fri, 10 Dec 2021 07:35:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvaR6-0008DW-Pz; Fri, 10 Dec 2021 07:35:20 +0000
Received: by outflank-mailman (input) for mailman id 243585;
 Fri, 10 Dec 2021 07:35:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvaR5-0008DQ-Ly
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 07:35:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8e83d3a-598b-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 08:35:18 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-Z8L-EvIyOtKSESYPDv70xA-1; Fri, 10 Dec 2021 08:35:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Fri, 10 Dec
 2021 07:35:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 07:35:15 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0014.eurprd05.prod.outlook.com (2603:10a6:203:91::24) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 07:35:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8e83d3a-598b-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639121717;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=xvOfb2mwzj5tVqo3Msu+rs5pD5sEr5fmus0vWBUIRHw=;
	b=NZFl81b9IL4zWrruPa82bOHgSdP8jYS4dk8EzeRzJAyXd316lmXnpBIcZrbASutvkLIuXY
	3TZS4Cf3g+46uHw6KGhpoFNZ97RvGZX7NM+fut8VKqPsUxVXcbKZR7mK7nxwTqBK93nJSM
	rKnAx1RzGRRT257RVd6yKEwWL+TPZ8I=
X-MC-Unique: Z8L-EvIyOtKSESYPDv70xA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lUmqguYYBU23RfXx4mV5iPd/3+FiOaphjjjcmARMQddN9T80gD4CwyB//ucBTSKpbMOdBYM4VBPXpCCAxCdlfneNZMWYA4SjZ5fbEYD4lkwrhJvRfxs8bQdbgWT988o6/l1vIZzL2fFn4FZdZwjLYbJYhjXjbxl+P4WrIkZAUKTi1Jr263LrMrna7JY/D6i2FyaJR9lc13gKJwbeTbegHgm8p5I45vXMVzuZXhTiyrvWiZ5FmyvoFkGe8QNkBcm7HaxuHVPoVG2y9nEfOQlE6ZGo4Yb0kHnAH8DLuhbARTaasL5mzvivaL9jhETy9A4is6e8PrkpE9ZJ0zFyotbegQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=voGRfI4hjarnJNIRTmU5gWi/djIx3fUZDvlLaJuWedM=;
 b=RbAPcFayQe7QKb7Jgvl+qDmVLv41ksF4z4PBiSMLIIrD46XypfqWufmyDICNaaaB4JKDRjZKrVbKxf5GgzSupdhVueRyyuXxg6gJOiWKGVC9BES6njCDwUtvYok9mEVIKT6VPwS1to2aiMAvAeNAQWjywRb960dICWIoQqmxhTOJpIwE4x0JPEpOywvWxqaUMRrpi+ujaCta06L+7rjICfpRMqWA5KmCtqvKkvH0hTzBKdRoqgoKdo0CZ3FKySzJ0wbGFBBCjRVRWVV3yGQilFfH7/RgS0s3Qml18eprl97TrA61grUnut7Gpj2JJLDzmE+EexnjQrlgQqynDLkUow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <61fd577c-2ada-5018-f065-53cf8dcd9efc@suse.com>
Date: Fri, 10 Dec 2021 08:35:14 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] x86/boot: Drop move_memory() and use memcpy()
 directly
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211207105339.28440-1-andrew.cooper3@citrix.com>
 <20211207105339.28440-3-andrew.cooper3@citrix.com>
 <81893ccf-6b94-ddc7-d92b-f254861fe994@suse.com>
 <becdcf55-51fb-0b62-6b34-d5c790b7d238@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <becdcf55-51fb-0b62-6b34-d5c790b7d238@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0502CA0014.eurprd05.prod.outlook.com
 (2603:10a6:203:91::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a11820d-d234-4637-b499-08d9bbaf9bc8
X-MS-TrafficTypeDiagnostic: VI1PR04MB4189:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41898CBA1858360DC9E6C16BB3719@VI1PR04MB4189.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7MNMq76C7+6hG1HYurvwHn/U+RP7Qq5zfLoB4+bewxD7yA7Xh5RjaKSzCdNW+W1hCmZdj6rIOMrNztqzygHb5R7QvsriRC041d8I46olykaSiKuAhg3C3WGJV21gQQmcfUFSlBJD2p5Vk98lOWgJXxLCB71PdowJkYC4XfyEvMY4+EFqJNWmnW2Reja+vZB0pYkjdH4XtJHqPGqV+t3sEoemKchd4wkT1drzjk9i+0XcFdePLgucFn1+fcKQ1HXLpEorCkkp0wKS2QJ3kBwMsfeoMN0b5G3EBL8zdXDMOGbKDkRgEulFw0Hi6CCR4uUmcPYBW4G+V8GOYGG2lWa9SCZx3a7oSKr4JTVAHbGw7LtmJDpUoXKAN/KbZU9n0HTAWFlHYOQ5BsQnK9lBuiFzpRDwvZAuG4wF29QReSUMNP/JQE6UUbySkasSSX66hSxykcWkEgTklGQ+N6IM5+8IDQkNCLIpG7uC7eUNcl0+piwj+VbTNrMah809xrXxu0DTlY3qCpCqZ120/yMR91a5gZpJqahLY9XMKUZbp5Ai0i88oKj9NvbRskIC/l1REuu8dU6yJF9i6ZeE/2w1jJ4vONf+xnxJ1nDVe2yxnaDDDNi98GfT81cX6UOlenJxSqr6s8T44P9gzpbIlKTWpAsKJShCNMKz14gYgdr7c+xq7/vCTFy70SqBmi5Dnj4hHUGRC/NSfhjf0YJL8X71wWqzhKk2WDjD2ND/dnpvJ4F40JYZMoHp1XtTHJtSVugByumX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(36756003)(2616005)(956004)(38100700002)(83380400001)(31696002)(66946007)(66476007)(66556008)(54906003)(110136005)(16576012)(2906002)(8936002)(26005)(316002)(31686004)(53546011)(8676002)(508600001)(86362001)(4326008)(186003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2iSaWr3TL39cmgJcmB9lNLfxOL0nErI9YhVyEp+czidaKmRsf45hxEbDSkwk?=
 =?us-ascii?Q?cv4kLLlsFYsNCof4u/zhIPlKMl5BRH6F6rAl+okN8TiDY4WZ8/7h6upVTkx3?=
 =?us-ascii?Q?dBUKtRSMoocmZKLv7np3tbB5UR4WSkaWv+2lRlAK22WZqKUpCrydnLpxRdLv?=
 =?us-ascii?Q?ErtHy4sUIkvHNZ9UbFyy8/udL+dN8XHyfSDgqgNjihqKwGfPkLa/ZqtABivg?=
 =?us-ascii?Q?4XgciUzYOzjlNE+VMysglCKau2HZAObW2/hyAYTp2cB7eQskvXVXRSc+k0uF?=
 =?us-ascii?Q?1DTahWJ9tvFnUPwsFKfEv7tHi9ghjNR8azfwr6dLdXB46mqkKKDSCAMUUytk?=
 =?us-ascii?Q?pszBh8CqXwsR8Z2v/9LfVEJjBMdioFR68dedAnbmu9AJtJJPEZQtN2PsBU9W?=
 =?us-ascii?Q?cG5JsCh7mgpGGPo7YX8JHcg+2C+Zzon3bOBNc7332orvRiNr2WMQ1Lta0TfJ?=
 =?us-ascii?Q?hz/1HLJ58JBGzBmslkhK8H4TD6g2dNeSnmeEdNWJanyb2LqZkEZbtNA5yQ4W?=
 =?us-ascii?Q?wvzDwKEDo/FAsoGz6wKyb661B7arCqBR6b8ZqSGrPmKTZK6QBESjHDSWElvm?=
 =?us-ascii?Q?9GXdUyYQbuGQ/wLBsfwl3k3qc3c+zFGwJYFmLOzv1h7tcXQhXetG3970EnAV?=
 =?us-ascii?Q?mbm8bDQNxY0mEKvfivjFbpD5iQc6ll98WjRzxiNoCVFGzR10jSrbJUksbrGj?=
 =?us-ascii?Q?epfJw+5Se/dxQZsUwmHqi6Tjf/oy1Npc+2J5HwnYGuLdROFrplVW2AlTJpzd?=
 =?us-ascii?Q?XLSJIjqTM5LIUhNx8y+udF/+k5tBRCHhLkjbKDxoHa2GFFZ+4yhbXsPySW4X?=
 =?us-ascii?Q?zleagUDEfF4pZlZhl8nfds3foLGqtVurKVtCtUPQm9+SwMCAlE1yn7Tqpa2n?=
 =?us-ascii?Q?BTNm6lnd5YO5yGkWbmq2orq1jGor8t0O/lwWvgQkfERSk6hZ9H9yaCbX0adg?=
 =?us-ascii?Q?KzBBNJJ5CvUtcTIXqh7Uua3O2xy94x7wjKowKkVN/hsGH1twxs9yF9aSwUAl?=
 =?us-ascii?Q?uqSCkJrgR20JH8aP6Rm/jBtho8nAV7fWyFZFQWp4swAmMR9eWD2Q2yt5UL33?=
 =?us-ascii?Q?QAdMC9SFSBwj6TUKnhl3AK+tt211qGs0kM+qd4rOtdCxvhLG35L8L0tybSuE?=
 =?us-ascii?Q?xl7FbDjCOoa2XguKrxx9cxrmcFqt1364W9tCNImB1YlJul5g8nqzb0GsTvfh?=
 =?us-ascii?Q?XVXG+Jz+ZLQKTuSB2zYpKS8B9lRvL00VTEIh//LpcP/vrHvNy7+xuBrX48PI?=
 =?us-ascii?Q?hZ0EJQVQJZeg79J6UIfU9sP+3pDEVYTzh/pc6AukJ4kGo87TnMYl/aPX3U2z?=
 =?us-ascii?Q?uBjpaFk5yott3HoSwkNnNSVU3tOlas4ZGc0JV8A7iyvBd3psPRxow7fxpm8l?=
 =?us-ascii?Q?fS3itCV7kSk5+i8Mbf48jFnQuhzqLJBsSqzhGUh0VwWoCBnkzdrBNy1f5SKs?=
 =?us-ascii?Q?hXPDYNG9cZrTnFSLUJkLsgqF4fTisj41o10Nhi2rGHnfTQjvUoE46L4bl+zY?=
 =?us-ascii?Q?XSTGBfwjSehbZgOZBmfpPZbNkLTGT+uCdODmjLTS6H8CFAKqFmpDt1si0zsF?=
 =?us-ascii?Q?aVrzh/dSrT6AFzGwMHkf/64fPwMIK3XeAW9bOJNV5wQWbfNwUF/hX/GiA2lr?=
 =?us-ascii?Q?yVEYj2OpIOXg1truSp0J0Ec=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a11820d-d234-4637-b499-08d9bbaf9bc8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 07:35:15.8197
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zmL86wKKxS7rSSte/IU0Ju6eUFXPqCFi/stvJPki0oqonARWVatu9BLZCPQ3vW9TZB1+cowX1txAf8Dgj9SbgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189

On 09.12.2021 20:58, Andrew Cooper wrote:
> On 07/12/2021 12:03, Jan Beulich wrote:
>> On 07.12.2021 11:53, Andrew Cooper wrote:
>>> @@ -1243,7 +1196,7 @@ void __init noreturn __start_xen(unsigned long mb=
i_p)
>>>               * data until after we have switched to the relocated page=
tables!
>>>               */
>>>              barrier();
>>> -            move_memory(e, XEN_IMG_OFFSET, _end - _start, 1);
>>> +            memcpy(__va(__pa(_start)), _start, _end - _start);
>>> =20
>>>              /* Walk idle_pg_table, relocating non-leaf entries. */
>>>              pl4e =3D __va(__pa(idle_pg_table));
>>> @@ -1300,8 +1253,6 @@ void __init noreturn __start_xen(unsigned long mb=
i_p)
>>>                     "1" (__va(__pa(cpu0_stack))), "2" (STACK_SIZE / 8)
>>>                  : "memory" );
>>> =20
>>> -            bootstrap_map(NULL);
>>> -
>>>              printk("New Xen image base address: %#lx\n", xen_phys_star=
t);
>>>          }
>> This bootstrap_map() must have been dead code already before, except
>> for the "keep" argument above needlessly having got passed as 1? Afaict
>> passing 1 was pointless without using the function's return value.
>=20
> bootstrap_map(NULL) is necessary to zap the constructed mappings, but it
> seems like the use of the return address was dropped by c/s 0b76ce20de
> "x86/setup: don't relocate the VGA hole" in 2013.
>=20
>>
>>> @@ -1325,9 +1276,10 @@ void __init noreturn __start_xen(unsigned long m=
bi_p)
>>>                   (headroom ||
>>>                    ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) )
>>>              {
>>> -                move_memory(end - size + headroom,
>>> -                            (uint64_t)mod[j].mod_start << PAGE_SHIFT,
>>> -                            mod[j].mod_end, 0);
>>> +                memcpy(__va(end - size + headroom),
>>> +                       __va((uint64_t)mod[j].mod_start << PAGE_SHIFT),
>>> +                       mod[j].mod_end);
>> I'm not convinced this can be memcpy() - consider_modules() specifically
>> allows for the current module's source and destination areas to overlap.
>> See also the comment ahead of its invocation a few lines up from here.
>=20
> The comment which says:
>=20
> /* Don't overlap with other modules (or Xen itself). */
> end =3D consider_modules(s, e, size, mod,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mbi->mods_coun=
t + relocated, j);
>=20
> ?

Yes, with the emphasis on "other".

> memmove() in move_memory() is broken, and in fact always results in a
> backwards copy, which means that one way or another, overlapping source
> and destination doesn't work.

We agree on this aspect.

> If it was really broken before, then it can be fixed now by using
> memmove() here, because using 2 directmap mappings means the
> forward/backward check will now work as expected.

Use of memmove() here is what I've been trying to suggest. I'm actually
surprised we've had no reports of breakage, so I will admit I'm not
fully certain that I'm not overlooking some aspect excluding the
potential for any overlap here.

>> I'm also not convinced we have the source range (fully) direct-mapped at
>> this point. Only full superpages have been mapped so far, and only those
>> for the current or higher address E820 entries (plus of course the pre-
>> built mappings of the space below 1Gb [PREBUILT_MAP_LIMIT]) located
>> below 4Gb.
>=20
> PREBUILT_MAP_LIMIT is 2M, and that's only to cover the fact that we
> build l1_directmap[] with the VGA UC range at build time.=C2=A0 I was hop=
ing
> to remove it in due course.
>=20
> As to the other mappings, that is awkward.=C2=A0 Perhaps what we ought to=
 do
> is split the loops.=C2=A0 First fill in all 2M superpages into the direct=
map,
> then relocate Xen, at which point we've got plenty of frames to feed
> into the allocator, to let us do a second pass filling in non-2M regions.

Well, we already have such a split of the loops, just that the 2nd part
occurs later right now. So what you suggest is either moving up that
2nd part or moving down the relocation of the modules. If you're
convinced either of these can be done without breaking anything, this
would indeed seem to be the way to go. I have to admit that I'm not
convinced (yet).

> We can depend on the modules living in RAM regions, but might want to
> explicitly confirm.
>=20
>> As to the 2nd argument - if this can indeed be converted in the first
>> place, may I suggest to also switch to using pfn_to_paddr()?
>=20
> Honestly, that's taking a terrible situation and making it worse.
>=20
> Calling pfn_to_paddr() on what is logically a paddr_t already ought to
> be a compilation error, and the logic which makes this change
> deliberately is some of the most nack-worthy logic I've ever come across.
>=20
> It's very much not ok to have mod_start be a paddr or pfn, and for
> mod_end to either be an end or a sized, epending on where you are during
> boot.

Well, feel free to propose an improvement. Using the modules array
for recording this data seemed better to me at the time than having
a 2nd, almost redundant data object.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 08:59:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 08:59:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243613.421434 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvbk4-0005Pg-Jj; Fri, 10 Dec 2021 08:59:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243613.421434; Fri, 10 Dec 2021 08:59:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvbk4-0005PZ-Gm; Fri, 10 Dec 2021 08:59:00 +0000
Received: by outflank-mailman (input) for mailman id 243613;
 Fri, 10 Dec 2021 08:58:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvbk2-0005PP-TD; Fri, 10 Dec 2021 08:58:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvbk2-0001WG-MS; Fri, 10 Dec 2021 08:58:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvbk2-0003L2-Dk; Fri, 10 Dec 2021 08:58:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvbk2-0008Fn-DF; Fri, 10 Dec 2021 08:58:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MdeEnY+nSI5S48NS9PKgw1w3DyYg5MqdZKxalF2DbmQ=; b=c0T7hkU8lO6vV67CQhY3yqkd9k
	5Y/6BMsZ5HfWXPJ1hAW7wMLqOwOZDnL6Efe1n6Ch3JoHnAgDXdeWYYq+Ydd5VAVz8im6yNY+bj3Ql
	8o8mfo6VKFWjTsSn0aSwtBEJCA0u8bcDzqROm4joV2eeEnoE6429Ftpz5GJ7W4RsdQA8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167330-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167330: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 08:58:58 +0000

flight 167330 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167330/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Testing same since   167240  2021-12-09 08:42:46 Z    1 days   24 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:00:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243619.421449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvblJ-0006mx-3i; Fri, 10 Dec 2021 09:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243619.421449; Fri, 10 Dec 2021 09:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvblI-0006mq-W1; Fri, 10 Dec 2021 09:00:16 +0000
Received: by outflank-mailman (input) for mailman id 243619;
 Fri, 10 Dec 2021 09:00:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvblH-0006mi-Pg
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:00:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvblH-0001Zo-Gr; Fri, 10 Dec 2021 09:00:15 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvblH-0001Ad-Ai; Fri, 10 Dec 2021 09:00:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=51fupHlQ7AG8fcpgeLRn9cvT9ODgKLKSrME4rZEgGNw=; b=NJIl49wBbZhDX/15EwrA8fznY8
	L7Elm9T/5gCefh1TdfhVI8gUcDhNtjiN+771GuKOjFB5ukhgGPU24zSaJp+kNulrXuQ23dxE/+SPO
	CKIkZt4/tsiJJzAOtsZvm+gVPshS4foPf+gzvG5IIOhyAW9kDqOu44kLOzHVvmluGRyI=;
Message-ID: <9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org>
Date: Fri, 10 Dec 2021 09:00:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under
 "hypervisor" node
To: Oleksandr Tyshchenko <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 09/12/2021 20:50, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Remove the following sentence:
> "This property is unnecessary when booting Dom0 using ACPI."
> for "reg" and "interrupts" properties as the initialization is not
> done via device-tree "hypervisor" node in that case anyway.

Why do you think that? On ACPI, the hypervisor node is used to discover 
whether the OS is running on top of Xen (see [1]).

For dom0, Xen will actually create the hypervisor node with the 
compatible property and the uefi bits (see [2]).

The properties "regs" and "interrupts" are not created for ACPI and 
therefore this should be mentioned in the Device-Tree bindings.

> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>   docs/misc/arm/device-tree/guest.txt | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
> index c115751..2b974bb 100644
> --- a/docs/misc/arm/device-tree/guest.txt
> +++ b/docs/misc/arm/device-tree/guest.txt
> @@ -15,11 +15,9 @@ the following properties:
>     or equal to gnttab_max_grant_frames()).
>     Regions 1...N are extended regions (unused address space) for mapping foreign
>     GFNs and grants, they might be absent if there is nothing to expose.
> -  This property is unnecessary when booting Dom0 using ACPI.
>   
>   - interrupts: the interrupt used by Xen to inject event notifications.
>     A GIC node is also required.
> -  This property is unnecessary when booting Dom0 using ACPI.
>   
>   To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
>   under /hypervisor with following parameters:

Cheers,

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/xen/enlighten.c#n253

[2] 
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/acpi/domain_build.c;h=bbdc90f92c003c0c6d0f0b0290a1776336224719;hb=HEAD#l90

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:09:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:09:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243626.421460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvbuH-0008A4-0j; Fri, 10 Dec 2021 09:09:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243626.421460; Fri, 10 Dec 2021 09:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvbuG-00089x-U4; Fri, 10 Dec 2021 09:09:32 +0000
Received: by outflank-mailman (input) for mailman id 243626;
 Fri, 10 Dec 2021 09:09:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvbuG-00089r-41
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:09:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvbuF-0001k0-U0; Fri, 10 Dec 2021 09:09:31 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvbuF-0001kj-Ns; Fri, 10 Dec 2021 09:09:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=XIPmTl0d5WI5yvmsZC68H9GM8X6AE8QmvYsZDuBAoEE=; b=DAsHt0iao8iLhh+rTn9mpAfBR+
	AlLZ/wBMxCdmwsRKyhB2ak8N1Pesu0q5DVqhjJHM6lzepefJrqh3NcuTpZgRMcoeoWoJ6sKYlGCax
	KdArgvFYGwopIskFjLPr2NI+KzYJahIpPds+HfgTUK074fsfdXfkzXCnbyUJKmLpOUdU=;
Message-ID: <669d3f56-13b8-f159-2053-b39f1ba4222f@xen.org>
Date: Fri, 10 Dec 2021 09:09:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
 xen-devel@lists.xenproject.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1639080336-26573-7-git-send-email-olekstysh@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1639080336-26573-7-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 09/12/2021 20:05, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Xen on Arm has gained new support recently to calculate and report
> extended regions (unused address space) safe to use for external
> mappings. These regions are reported via "reg" property under
> "hypervisor" node in the guest device-tree. As region 0 is reserved
> for grant table space (always present), the indexes for extended
> regions are 1...N.
> 
> No device-tree bindings update is needed (except clarifying the text)
> as guest infers the presence of extended regions from the number
> of regions in "reg" property.
> 
> While at it, remove the following sentence:
> "This property is unnecessary when booting Dom0 using ACPI."
> for "reg" and "interrupts" properties as the initialization is not
> done via device-tree "hypervisor" node in that case anyway.
You sent a similar patch for Xen and have already commented there [1] . 
In short, the OS will be using the node to discover whether it is 
running on Xen for both ACPI and DT. The hypervisor node also contain 
the UEFI information for dom0.

Cheers,

[1] 
https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org/T/#t

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:20:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:20:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243631.421471 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvc4m-0002U3-1F; Fri, 10 Dec 2021 09:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243631.421471; Fri, 10 Dec 2021 09:20:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvc4l-0002Tw-UA; Fri, 10 Dec 2021 09:20:23 +0000
Received: by outflank-mailman (input) for mailman id 243631;
 Fri, 10 Dec 2021 09:20:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dYg4=Q3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvc4k-0002Tq-2g
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:20:22 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 658b9d0e-599a-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:20:20 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id cf39so4790584lfb.8
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 01:20:21 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id j20sm253534lfm.136.2021.12.10.01.20.19
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 01:20:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 658b9d0e-599a-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=O4zVFLahCre8SRQUmVJmme9V5fkFHSrE7LdKPl4d58s=;
        b=aWsrKjGxQvnfprrQT84tGmXmB6AOpiF4BYv1soFBVpUHPMd5/cSV8bzhoEfq9yZ2VW
         nNqIW9SXPOz4zPRNtK0Tbhe2Tbxs0TSWpFhvVSSdh5ePLaZe/RO+dDVItNcxYYuQFu8i
         hpoOhTmXOI4q+abTc8DuZp5vdait0G4H8nuaCAfw7CDndnQjAxlk9yOrP6qDq2brEkuk
         PSzZ0SjxSi4lGb6vtnLLYM6aZw4eA29c5WeW0kZIIFDNHjnBQe3VRjrAR9S5VUEWA/oh
         e5dXnbIyJ5iqPWB1sVRonGFIlRm1vCAoghUyveqHakiqcEiyhNYZaaFoizDeNI6YFHvv
         L2cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=O4zVFLahCre8SRQUmVJmme9V5fkFHSrE7LdKPl4d58s=;
        b=xSOFaOyyFIxPGXqsM5Vx5sisrcSSXcnFa6AHnicUKTkpA9DcxVzpLHo9Q9kmBqTtj4
         QPKsywk77jTGmS4tUA4dKorsrvG9g+X623+QmP7/1PuW17eh+YbjCQPvhL3fKr6mdby1
         5+KbEzRQBcgtZ+hHWxchSmUGoQK4iRk2iNE8R9FaL8N8f0Cj9e6F3LmSO8OaN3DiLxuH
         PpA3rzEJv6soYdMPtLQG70anGAuxU618Gawb0YcS6jB8FREz57dIVRsAJ/E76MhJdUc5
         rZnyic7IWNhxutiFYkE7g7UkP29DgrI5bnUx5UZCm3f1ghWe7Whz8OXZemZZUkeq+t/L
         oSNg==
X-Gm-Message-State: AOAM530gmBlAXW8t15UeT7LlqDqFR0Febsu2abgUfSQ1nHYZLRAK822e
	SGxweGSWy5ki+3BrdmmrnP0=
X-Google-Smtp-Source: ABdhPJz66p28hML9WrIlquVkqzllJisH5ltmqgrCAxA9LGX01EGg3RtGyvAMKYpK+3F9cFzecnhGEw==
X-Received: by 2002:a19:614f:: with SMTP id m15mr11279515lfk.187.1639128020526;
        Fri, 10 Dec 2021 01:20:20 -0800 (PST)
Subject: Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under
 "hypervisor" node
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1639083050-31782-1-git-send-email-olekstysh@gmail.com>
 <9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <e243cee9-d97d-2bf6-3a20-62dab544b74d@gmail.com>
Date: Fri, 10 Dec 2021 11:20:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 10.12.21 11:00, Julien Grall wrote:
> Hi Oleksandr,


Hi Julien


>
> On 09/12/2021 20:50, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Remove the following sentence:
>> "This property is unnecessary when booting Dom0 using ACPI."
>> for "reg" and "interrupts" properties as the initialization is not
>> done via device-tree "hypervisor" node in that case anyway.
>
> Why do you think that? On ACPI, the hypervisor node is used to 
> discover whether the OS is running on top of Xen (see [1]).
>
> For dom0, Xen will actually create the hypervisor node with the 
> compatible property and the uefi bits (see [2]).
>
> The properties "regs" and "interrupts" are not created for ACPI and 
> therefore this should be mentioned in the Device-Tree bindings.


You are right. I missed that fact. Current patch is not needed in this case.


>
>
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   docs/misc/arm/device-tree/guest.txt | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/docs/misc/arm/device-tree/guest.txt 
>> b/docs/misc/arm/device-tree/guest.txt
>> index c115751..2b974bb 100644
>> --- a/docs/misc/arm/device-tree/guest.txt
>> +++ b/docs/misc/arm/device-tree/guest.txt
>> @@ -15,11 +15,9 @@ the following properties:
>>     or equal to gnttab_max_grant_frames()).
>>     Regions 1...N are extended regions (unused address space) for 
>> mapping foreign
>>     GFNs and grants, they might be absent if there is nothing to expose.
>> -  This property is unnecessary when booting Dom0 using ACPI.
>>     - interrupts: the interrupt used by Xen to inject event 
>> notifications.
>>     A GIC node is also required.
>> -  This property is unnecessary when booting Dom0 using ACPI.
>>     To support UEFI on Xen ARM virtual platforms, Xen populates the 
>> FDT "uefi" node
>>   under /hypervisor with following parameters:
>
> Cheers,
>
> [1] 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/xen/enlighten.c#n253
>
> [2] 
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/acpi/domain_build.c;h=bbdc90f92c003c0c6d0f0b0290a1776336224719;hb=HEAD#l90
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:28:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:28:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243636.421481 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcCT-0003jN-R1; Fri, 10 Dec 2021 09:28:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243636.421481; Fri, 10 Dec 2021 09:28:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcCT-0003jG-OC; Fri, 10 Dec 2021 09:28:21 +0000
Received: by outflank-mailman (input) for mailman id 243636;
 Fri, 10 Dec 2021 09:28:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=At30=Q3=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvcCT-0003jA-As
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:28:21 +0000
Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com
 [2a00:1450:4864:20::530])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 832ff8fa-599b-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:28:20 +0100 (CET)
Received: by mail-ed1-x530.google.com with SMTP id x10so10627109edd.5
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 01:28:20 -0800 (PST)
Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id u10sm1100969edo.16.2021.12.10.01.28.18
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 10 Dec 2021 01:28:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 832ff8fa-599b-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Wo+kEjPRCNOeRmpc24VwDoZ3sGXxzMQEGIk47myQMF4=;
        b=D25x5s7aOfBvkoF1TAnTBMhjleDypIR/jVNd0p2Z75eSnIZErDAv1fx6EJlzyYEERD
         rWV5T4fMEPDldGHGy4lzjbH3kK0SbORPAwBxvAUGhcNaDSrirLbvpNIXQFsSlrLISZpT
         8EOim2hyYjFNofT0F/PjVWXDxbocKSnhkeWUqI5OyqmPf2t4jS2iSgJ3Mtzqt5Hr1Fpm
         oXJkmh2A/7omfykgSbnPUptdgPB7L2dfxgU0jrKd8c9WMhF2cwUEQg0p7Ikio0NbJu9d
         uKeBFO4Egbg/KQ0sOh+YG+ckeIcBg/bMkIkQpCJxqs5lWNnFvg6wHJ/eSZ4h2OX3+avB
         HkZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=Wo+kEjPRCNOeRmpc24VwDoZ3sGXxzMQEGIk47myQMF4=;
        b=LOgku2zzZnrD8A9xDgiKQ4e19+hSCwzO+LT+RKkydTt1kSVlDPkQ4mmijOHQ9z3Nt7
         N8wB/lFqRc+J0zNCiNBc4X9AMn0U/g6x4dckxFM3g98f9SLT3ji/7SKcW6+OCslGU4DM
         gHsMETNFMsXlbvxwB63GZ8WkMYFRDR5/U9k5xbM+XDXtsG4MuIUQTrTBJXNrfNPSvXU9
         yPxfx3p4eagpozbBmcW+npnwhOGgejyid1dEK0FNL2O95cuEEUw/VgbP4y2/d1fKtuS7
         I8UVpxokFXMfdvx2juluYDXI5r0gv9FNFz2lA9TZLsZaVEk4F5VvEbOvxVEcLOtrLk2D
         SU6A==
X-Gm-Message-State: AOAM531Boc0RJATPs7Agu2UMeDlrx9+VjryXXolYU35LTtxLi6zW0RSe
	KkG1r6FgIOERuC5vFN6TPZY8b8FohHxPWA==
X-Google-Smtp-Source: ABdhPJwcTAzhR9JhHlzlbR4kehZa3+II/LWyggzIRg1fSi6WukM1ZJJNUF2G5HcniWyScx8qbyyG8g==
X-Received: by 2002:a05:6402:1e95:: with SMTP id f21mr38172357edf.139.1639128499650;
        Fri, 10 Dec 2021 01:28:19 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Cc: boris.ostrovsky@oracle.com,
	jgross@suse.com,
	sstabellini@kernel.org,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
	stable@vger.kernel.org
Subject: [PATCH] xen/gntdev: fix unmap notification order
Date: Fri, 10 Dec 2021 11:28:17 +0200
Message-Id: <20211210092817.580718-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

While working with Xen's libxenvchan library I have faced an issue with
unmap notifications sent in wrong order if both UNMAP_NOTIFY_SEND_EVENT
and UNMAP_NOTIFY_CLEAR_BYTE were requested: first we send an event channel
notification and then clear the notification byte which renders in the below
inconsistency (cli_live is the byte which was requested to be cleared on unmap):

[  444.514243] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
libxenvchan_is_open cli_live 1
[  444.515239] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14

Thus it is not possible to reliably implement the checks like
- wait for the notification (UNMAP_NOTIFY_SEND_EVENT)
- check the variable (UNMAP_NOTIFY_CLEAR_BYTE)
because it is possible that the variable gets checked before it is cleared
by the kernel.

To fix that we need to re-order the notifications, so the variable is first
gets cleared and then the event channel notification is sent.
With this fix I can see the correct order of execution:

[   54.522611] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
[   54.537966] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
libxenvchan_is_open cli_live 0

Cc: stable@vger.kernel.org
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 drivers/xen/gntdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index fec1b6537166..59ffea800079 100644
--- a/drivers/xen/gntdev.c
+++ b/drivers/xen/gntdev.c
@@ -250,13 +250,13 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map)
 	if (!refcount_dec_and_test(&map->users))
 		return;
 
+	if (map->pages && !use_ptemod)
+		unmap_grant_pages(map, 0, map->count);
+
 	if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) {
 		notify_remote_via_evtchn(map->notify.event);
 		evtchn_put(map->notify.event);
 	}
-
-	if (map->pages && !use_ptemod)
-		unmap_grant_pages(map, 0, map->count);
 	gntdev_free_map(map);
 }
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:31:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:31:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243640.421493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcF7-00055V-8V; Fri, 10 Dec 2021 09:31:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243640.421493; Fri, 10 Dec 2021 09:31:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcF7-00055O-5L; Fri, 10 Dec 2021 09:31:05 +0000
Received: by outflank-mailman (input) for mailman id 243640;
 Fri, 10 Dec 2021 09:31:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcF5-000559-NM; Fri, 10 Dec 2021 09:31:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcF5-00025t-GB; Fri, 10 Dec 2021 09:31:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcF5-0004Lm-7m; Fri, 10 Dec 2021 09:31:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcF5-0001lD-7H; Fri, 10 Dec 2021 09:31:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wn2W9DrpAMTbtRNpRzZnEqZgGyVpfEpjRXzoYwll2gk=; b=AbSlVEeR4yq/7tkpIp+0JIYFO8
	ZktNqRXqyyo1HOkbZonml+rRKGNk0vqy+WFuGUh8xCupGclv7L28BHEhTNwYGB080XOG4fRrQ287v
	bVc50C21tV0OhSEoNhrKWbJU76+OiDg+fdNiGc/nN955mU4I9xopmtC8jZglBZi/yb+8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167334-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167334: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 09:31:03 +0000

flight 167334 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167334/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Testing same since   167240  2021-12-09 08:42:46 Z    1 days   25 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:32:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:32:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243645.421506 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcGX-0005fk-Lg; Fri, 10 Dec 2021 09:32:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243645.421506; Fri, 10 Dec 2021 09:32:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcGX-0005fd-I8; Fri, 10 Dec 2021 09:32:33 +0000
Received: by outflank-mailman (input) for mailman id 243645;
 Fri, 10 Dec 2021 09:32:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcGV-0005ew-QC
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:32:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 18bf62cf-599c-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:32:30 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-JqxeyDmTPh6tvLUrZfxByQ-1; Fri, 10 Dec 2021 10:32:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Fri, 10 Dec
 2021 09:32:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:32:24 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6P193CA0082.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::23) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 09:32:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18bf62cf-599c-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639128750;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7CeQ6U9qkYLcuHRR0iukM37EAFT/0aM4VwLDK2b7IBI=;
	b=YEIK05pFfgqGO9kbmO/0O2QyubBXZzAEot4M17SVArGB1mcxTcM/ObQ6ydMFx9BSJpcqhg
	iStUhc/uDo6M6BKWziMeKCiz0qjWh79RaOgvrXxwe35QRhRn/6lreUl2OQnE+lVvJlx6Wd
	SieVK04Z3b9ejKYMkRSNR2raLtUIh+c=
X-MC-Unique: JqxeyDmTPh6tvLUrZfxByQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AE1SHNj4Oqca6u05qxy3UNVa6mUwgNIyARdVALjUu1aOhBRTpMkiliwhOcxrHicG7XLtShVJjOUUIbn8p+4A8NrP9oYT2xQpoCTx2IeFLFLV2J9wcsi79/PWfZ3G77S/zI3uIvCn0EE5mWpzVHWLQnyvwvGD4pduUtanDxe8Hm9lKcRhSn3qDunjKxUWf++Q6ioOoz+Y28LSY4TOLO/1tgj0VlBNbAo88iBur7I5DYAk8fpVdHKT3H8Tt0amjsFhACrSuI33GBYje5SjCnDwBSNSJh/SK7e8mPR1Yf45TAWjz991jcaoc0W6LUwDsjNgDwWaDmBM0V+bK3juJ8GB0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=7CeQ6U9qkYLcuHRR0iukM37EAFT/0aM4VwLDK2b7IBI=;
 b=jJ0CfdJz2L59X7lHL9C+GgjZS2J+igHlXn2BY/nCYMKOzK9xM9zPXxhPlg0QWpnnQ0on8ZghIOUlFHO8Aoc1UfvSIlNGen4OxeyVu6UKKQXENXWrFK9EDg6mke+xnZVPrcnvi5bFXYISCykCgPptw0Q4bzRX2siD+99iCj8aoJxo571HtmoaAzCWUvtsjJrve5D2U1iRbtWnhVrIJPEcY9P+HEVnlV6rrrqx6yNqc8ol0lDxQC1sGZpOiD1rnvDkl0U2FlPQUPzUTGgPwwa1kx67sgeAi9CCsm4KFuZ/t+bZtZo6mO8Y+nAzJttTJ/iqXh1NpW5fcJreMayKvBvdxg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3b0f15d3-b3b6-b5f3-8419-71b4d0cf0e28@suse.com>
Date: Fri, 10 Dec 2021 10:32:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Ping: [PATCH] x86/EPT: squash meaningless TLB flush
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
In-Reply-To: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0082.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2380c83-991f-4b2d-6c72-08d9bbbff943
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41905B64B7AF5531F6DB6901B3719@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WPOwDdXKNXdpxYO/iiBgx5zyiAKPdT7bsL4ljZ9AKFzJKJJ+3ECEunk+4sij37leuyV3o4/o+thTQSN//TRHME2g4rZhtAMQxmkt0210oX1HE4nkZSwPu6pTQCAYFUwGuND/0ILaRLvW+d3zCTwcKxOnaBWzcc/Z28gqckIpmMj+yWxO1mAc9uJ2oHgXdPeKaJjZF1wMDXqu976imhiCJBft+uY0eSEFVkXKIZpQ0hbUy80F1PNOGDHkOdB6TxGqe55WMkeO990/TXHYnuF2qdoz07RBpybaRTo91PH0DEdNeusSjXrnGxArjoegOusIXSVX9xPwVlg9tQYSL8URBWuvWJ4S31xyMGmTFuxpbhzrBMHpkyynDKyVZ+2otj7ZitikJTRYTNJL2QWjwFEb7Cc1i3kgYzV2oDO7B2x8UAcarEUZ/gwyF5C/ZkaJcl/8b+zqHEQ+oQX7gwE05mvYyw4+koh1YJf5xRiwgHx1UB7/IKXqNTn5ZUKwVLINPCnso9Fq62FhbGJmLkiS/NLA+9EzXWYV3ZXygcP0hDPehX3IeD5PbGNiSnONba0E1upf3PBaB7gtbzNa0SgYYgCj+uf8OSHuSsy/3bwNOtnQxRsQrTbNZ8wDqjgGvPxkgoQe+qB9S7aS8JdElUKdGc72L3blMK3W2EthjfUEzE3PDo6YUp/Xaxly8rw9xC42RvCFfQknoyAGtRT5T7IjKvAgReYulfLnl15pfCLmiUAnr8A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(6486002)(31686004)(36756003)(8676002)(186003)(31696002)(38100700002)(110136005)(956004)(53546011)(86362001)(316002)(8936002)(16576012)(2906002)(66946007)(4326008)(5660300002)(4744005)(508600001)(66476007)(66556008)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mk5IWi9rWFB2MHl4dFl4Z2NVOTBaWDlkU25oUVRrNkxIMGdIWEJLZWNQVFh1?=
 =?utf-8?B?cDlhcGprR1ZRVmF3RHFxVWJ3STJHMWx6SUdUM0d4aDMvb21UdG1yR2pxeTJ3?=
 =?utf-8?B?encxYWRkT2VzODByN0UzYjFEWnlXZmZDdUh5RnBCOEU2bzVaQTJ2a2x3MGJZ?=
 =?utf-8?B?ZGY5T2NSMlVhQXF1dlhzS040YTdSOHNlbkxyVGlHNFdORmd5d1dBUmFYb1NM?=
 =?utf-8?B?dExIR3VRODNNWVlYMEtMdW8rNFZFWlhXSUJETVY3cTRFaFBwczlyM1cwWFRi?=
 =?utf-8?B?Skk4cFk2akpwUk4xYUhpSUp4Vm9UV0xtTElUc1VydFhxdzNobFJOMTlIRnBK?=
 =?utf-8?B?N3dZaVNlL0xCMUhDL1h4aTNZY1hKaGhrS05rZS9GY2plZmNwMGZlajIxL3lj?=
 =?utf-8?B?em51cnRWdTFFRWk1VVdyRlFLTkRrZnkrdDhKL0xoRW0raXhhTmxwQmJzV1JR?=
 =?utf-8?B?TG90RzdNQlVKOHVFdjdoeldjMzNxMFBxVVpHcCs0ZlVoYWN5bHhBRGFsM1ZZ?=
 =?utf-8?B?ZDRnUkFQeWFEVjUrY0thOUFDMG9CRk9JeFpEUGRNd2tFZGV3U1VFanBlTGlL?=
 =?utf-8?B?MVpqL0VxOWRsQ3dEUzF2R3VoeHczNXF0Z2dpT3hnTmYvRTRmUTBUMFFnTGMz?=
 =?utf-8?B?enJGaWFwSDk1enNPY2dCK3N1NW1jTnFFN2tHVks0WWhxdm1NeW9aUnl0d3NX?=
 =?utf-8?B?V24yVERLcUZSTG1iSUtDeHI2dkU0NVgzZmdRMG9JK2VMa1FjMWhsdkZ6S3Q4?=
 =?utf-8?B?eS9taTIxYmhmMGZlaFRjSTBReXhRL0k2eDNrSStrS0haY1pNWS9ZS3N4blR2?=
 =?utf-8?B?d3k4TjJDOFFLN1JrSkJ6L1JQcEZFSFpIZkpYOTh0eFZmNUIxSEhjcXAwQVAx?=
 =?utf-8?B?N3VSSjBERUFLVmlpYjc3bThPSmFMdWUrckh5T3dmMTZjcEtHOHNQZVpXSjUx?=
 =?utf-8?B?VnlqbUEzQ1pmS2JyYTFSVGdrclZrYkJYcEtYakdDd1NGY3BYbHlnS01SZisz?=
 =?utf-8?B?cE9ZZ3dqVjJMemZOREtkQ2UrVmhSZkVPYUVteHhHSDVvbjljV2hxeThDakgv?=
 =?utf-8?B?cDhJMHg5VFBEeGF5alFjcmNxRC90bmJOYVVLT1RUS2UzNGt0dG1DVVFZOE5a?=
 =?utf-8?B?WnM3b0tBd2tITlBIS1o0VmF3dThoL1JrTHVRY0xzdFpZRERFanNqWnlyc1I0?=
 =?utf-8?B?bXQ3UjMwaTA0ODM4blduK1cxd0hyQzVRN3dDWnk0dTFGL1dRVnl6UGRRVDdh?=
 =?utf-8?B?L0xXQmtpY3pBSHN5SndUaWVWb1pYdUJ2WnRYZTU3c0FIVGRLamxhRnp3K3dJ?=
 =?utf-8?B?RUxJeDFYUkpOMTloMWFPWGo0S2o3VnRtS3oyL2E4bG9Ca3lYdStUVjNmVFZl?=
 =?utf-8?B?K090ejRocjBpVmZDZGszRTNpR0x3TUppTldkU1B0WHRlakQwYzROWHNwb1pW?=
 =?utf-8?B?cGdNV0EvS1diWVdvMUx2NjBCM21rNkJZaW83YXJRVHJmVko1UWgrdEFnZjQ2?=
 =?utf-8?B?bG5rcVFNeE9Ld1JKdCtVQW5mbTFYTXlvVVZ3M0laQlZiYWVhd0U4NS9nTnR1?=
 =?utf-8?B?amNXME5xd0gzemF2clVwQ2Uxbzd6Y0FTWjl3NzR6WUlaRldBRmRuam82QnlO?=
 =?utf-8?B?cE85cU82UXhnUElMM2ROa1JMa0tJb2g1TlNIWVQvMFBSMGMwK0paM0x6RGtI?=
 =?utf-8?B?Q2JKY0dsMVRKQUJrVjhXNTZ6cjlTY0E1TjFiNnN0RmNjVmxEUS9oMmU0RVdV?=
 =?utf-8?B?eU5EQ0VZdElQTEJpWlBkTWt2eWtOYmdQUEE5WjN6amQrZEM5cVRINVQzQUhz?=
 =?utf-8?B?dU8yYXpwOGFCSTFkTGd4eS9tVDlPYU82eWlVMkhHTGdScUp3TnFJSURzQUFO?=
 =?utf-8?B?VU1qSGt2VjRqaEhhclRzZUlsNjh3Q0lOakpMdGZ2WlYvYitoV015aUhoUU0v?=
 =?utf-8?B?aGtrK3Y2UVJvY0xYNy9HYXpLbmZ3cHRUaTViWXk4c2hIRFIyOWloU3JuVkcy?=
 =?utf-8?B?ZDNRb0U0bDRFWDV2UE9taEIrL2pndHNwdGhWSThMMVp5akxhNXo3WFNrbmxZ?=
 =?utf-8?B?WG5YWEZGSUFVaU9VQlVvcVkrRVFlVlI1Q1lhTXVCbnpIK0g5WHdyb2NCNE5l?=
 =?utf-8?B?MjQ5bXNmaVE2cmdSeC9iK0hpMFl6RzZkR09GRk01WTFmNkV1cWxVV3psMGt5?=
 =?utf-8?Q?4B2lFTzAnERReLo95qRGB7A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2380c83-991f-4b2d-6c72-08d9bbbff943
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:32:24.5758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o+KJ0tGhGEUw/Fzoo0EBNg6oKjQTKnaOBmAXYDVJQpP8IHi1/5MYarP+X5c+C18oSqnyxuOu5+K5o352TNPTPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 30.11.2021 17:10, Jan Beulich wrote:
> ept_free_entry() gets called after a flush - if one is necessary in the
> first place - was already issued. That behavior is similar to NPT, which
> also doesn't have any further flush in p2m_free_entry(). (Furthermore,
> the function being recursive, in case of recursiveness way too many
> flushes would have been issued.)
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

May I ask for an ack or otherwise here? From all I can tell I have addressed
Andrew's comment.

Jan

> --- a/xen/arch/x86/mm/p2m-ept.c
> +++ b/xen/arch/x86/mm/p2m-ept.c
> @@ -246,8 +246,7 @@ static void ept_free_entry(struct p2m_do
>              ept_free_entry(p2m, epte + i, level - 1);
>          unmap_domain_page(epte);
>      }
> -    
> -    p2m_tlb_flush_sync(p2m);
> +
>      p2m_free_ptp(p2m, mfn_to_page(_mfn(ept_entry->mfn)));
>  }
>  



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:33:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:33:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243652.421525 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcHF-0006M0-7V; Fri, 10 Dec 2021 09:33:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243652.421525; Fri, 10 Dec 2021 09:33:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcHF-0006Ls-4I; Fri, 10 Dec 2021 09:33:17 +0000
Received: by outflank-mailman (input) for mailman id 243652;
 Fri, 10 Dec 2021 09:33:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dYg4=Q3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mvcHD-0006Fk-2C
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:33:15 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 328c840b-599c-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 10:33:14 +0100 (CET)
Received: by mail-lf1-x12f.google.com with SMTP id k37so17012947lfv.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 01:33:14 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id c13sm254687lfv.293.2021.12.10.01.33.13
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 01:33:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 328c840b-599c-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=1sKsqu13f1fJ8ZVjtTiFIs7M6/v2yiKCto4Y2goIhtY=;
        b=gegr37rT1wvk5/wIHoT3HG7CbFisDJJ4qe7XzDTdtRmUZejW6aDzDd79UpHl8InFNC
         Aav2ZhWN7fwu3X0v/aE89Aw3XSuHOBWjTUXuS08G6a53BhERGxk+ge/9uOOtbkqHNmgb
         MoJZlh7AwjhHDayjdbsuG/3Q0h1neeOtb+eNY+EgK6GT9rHBwt8YAyq6IvVCDr3pO26l
         HAnOi+dsKwsTag1DeO8AbaabSQ2CLSMuvxJeKT04xZCkvOu+Z3PXKa6G9dWDMSK8DId3
         4B3MJliyAYL16Dmvpz/AGxNLYDhl40rwyQIQcyt7MD1w5vB8GcKk1scbGe0WZI0ZOvzP
         XpBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=1sKsqu13f1fJ8ZVjtTiFIs7M6/v2yiKCto4Y2goIhtY=;
        b=w+0fmlsE7AZeVSIM+NECfumoMcz3B5DeJK1iD22n2QGgWEicbgjg5CHClEr7LbeLif
         SSsn79HaP7ktCgj3dlPQavPRk4JQGZPUTR3KClwf3kOIT1Z/lkT9GTRikKUr6eZU3Aa6
         kmYFawGi4++YwWeBuktcA6NPG8rtxkKQmH/HY6iGpT7H5PISeaBB9DC4Lpv/KJ7Yuvqs
         HCGIenSrrbbXj8u4CygJf5e0k/x94qzEFQ8r1HpJP+b58X5qPgLmrCGnnCiH3HaImZsJ
         s6eoPc6VIaNhxWL0FkTTX0nmkIGmYo0aTZLRtgfGsngyAEUDQi9KkRQiuF/+fzxAyMGT
         8ZtA==
X-Gm-Message-State: AOAM53354qkiE2UGx9SLK+UPiGIjBgmNsV9826i41jzzFVrrAcXfK3mJ
	+WkSuMtkID1F/CMWCpJgnFY=
X-Google-Smtp-Source: ABdhPJy0jBvkn2hW116jh/1FKkNOWkwWVSWrraWcHOTZPFv9s8mfwd+5sJqH2upmSWbUncVjhxEwpQ==
X-Received: by 2002:a05:6512:1047:: with SMTP id c7mr11615784lfb.26.1639128794039;
        Fri, 10 Dec 2021 01:33:14 -0800 (PST)
Subject: Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1639080336-26573-7-git-send-email-olekstysh@gmail.com>
 <669d3f56-13b8-f159-2053-b39f1ba4222f@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com>
Date: Fri, 10 Dec 2021 11:33:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <669d3f56-13b8-f159-2053-b39f1ba4222f@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 10.12.21 11:09, Julien Grall wrote:
> Hi Oleksandr,


Hi Julien


>
> On 09/12/2021 20:05, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Xen on Arm has gained new support recently to calculate and report
>> extended regions (unused address space) safe to use for external
>> mappings. These regions are reported via "reg" property under
>> "hypervisor" node in the guest device-tree. As region 0 is reserved
>> for grant table space (always present), the indexes for extended
>> regions are 1...N.
>>
>> No device-tree bindings update is needed (except clarifying the text)
>> as guest infers the presence of extended regions from the number
>> of regions in "reg" property.
>>
>> While at it, remove the following sentence:
>> "This property is unnecessary when booting Dom0 using ACPI."
>> for "reg" and "interrupts" properties as the initialization is not
>> done via device-tree "hypervisor" node in that case anyway.
> You sent a similar patch for Xen and have already commented there [1] 
> . In short, the OS will be using the node to discover whether it is 
> running on Xen for both ACPI and DT. The hypervisor node also contain 
> the UEFI information for dom0.

I agree with your comments. The sentence should remain in this case. 
Thank you for pointing this out.


>
>
> Cheers,
>
> [1] 
> https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org/T/#t
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:38:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:38:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243661.421545 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcM3-0007m4-Ua; Fri, 10 Dec 2021 09:38:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243661.421545; Fri, 10 Dec 2021 09:38:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcM3-0007lx-Qw; Fri, 10 Dec 2021 09:38:15 +0000
Received: by outflank-mailman (input) for mailman id 243661;
 Fri, 10 Dec 2021 09:38:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcM3-0007lr-9y
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:38:15 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e593dc40-599c-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:38:14 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-7-IeUw9UEGPbqqlOVPqBCscA-1; Fri, 10 Dec 2021 10:38:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Fri, 10 Dec
 2021 09:38:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:38:12 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0701CA0006.eurprd07.prod.outlook.com (2603:10a6:203:51::16) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 09:38:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e593dc40-599c-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639129094;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=Zvq73y0dJLjSz+MQ+lx2g5w/pq8BC6asLbuC1uXR9cY=;
	b=O22RN3p97ZihWpX27w97+r8Go33wmLE6O7H13SWAI3o+FXtX5ePOmgSBm41EAXGeO2Uh4+
	S8x3QtdXqyFu7gjqkGtGZSUl2k3yxsNnk1DxL3ti46OyJumoIBPEgtGi2sLrF8JD/zNx2T
	WG47uyt0DGRUJlYpKhx3uFl5oMHsz80=
X-MC-Unique: IeUw9UEGPbqqlOVPqBCscA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZPzIagmE/NK+BgtQwGrLOIsH5skGQxoXlflQySowyJSankJKjKMj5nY3f2uQKyZi4AGPh6lHYSRXcbh1UneuUZX/u8WL+/yL17ow8T8vIuGhf5WR0fsDz9ZUrangchFjA/L75pGevoKBcsBPWhDaFho65Xof8OJH2Eqg98kyEaAif6stwsFyEHBe5h1jQoTPMdv4zKaFN5MSFeGo3ZBhFXRaCfgLCI/g2YILKx9uU5jlGASQ4cvydeDz0JRn3PXkDzP3SihSJxHnad1p9+5op8k5NvbDhVyWnfaqXxhchjFuuSu5HMGIfZw0/8zFgIzWbIDJdKEOP0JClJDHUwuWPg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zvq73y0dJLjSz+MQ+lx2g5w/pq8BC6asLbuC1uXR9cY=;
 b=ZTMni/wNr5Nd39m6YkP2ONrTGRNM2kbylOuIkNPFp4KCRyG29meEWqSXm7yUFt5ePN6DCsSfFkHUAw1JzX35MH+2g3JN5X9LAD44MSgU9ZBgerki4CK6EI7/vODTusXPqWdpF3F4RNe023oKyQdEaO6LIMIf8vbzskVHAVCZBTijG9kr8ZZeflIkY1SFCN+Y1j/iGYslk3Onh2fkNg1sGu87F2ZQhwbbBltuL76TprrsTr8zd/jcaqsbL205HsfnXeKSE7JxnaAWvMtiguFmhabzoQ2Jm+d+IZmiBckZ2xm9UC61+fYukNuxkYvhUXtf9SrrG62pTGyPExaUBjqxWQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
Date: Fri, 10 Dec 2021 10:38:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 0/2] grant table and add-to-physmap adjustments on top of
 XSAs 379 and 384
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0701CA0006.eurprd07.prod.outlook.com
 (2603:10a6:203:51::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fce81fcf-261d-456a-e03b-08d9bbc0c864
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3934621F37F49DFC24D9D2F2B3719@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o5fJCN+wYEqhNBCacxGtfNGvIS8CUfMadmuHodem3fYgl+CVKqgEtbhkwTlGn7Ge+rbDXnH8ERTTViMqIVgmNVClqpiSRUDBa6V4E+T/HmXil2t5BYFgsncS3dZr9pGTksK2rRv7YRB4PjKqE8XDei95K5w8/ipZyGlI5pm+ghVo3iYy5LDd81IwIP9YGsRDhoZGWk40TrA6lT9a438x03sRyLpL/9JD7Gq4DCFDJOvUTeIOxk2xDRItd6VV8HMSj7IpRDmZtoAB8SwziChogq3OMi2j+qexnl++9QXwIVYjCe1ZoQdHSi+VgBUie4rW2vq8gauJa9huz4ScEv6854PzoYs7OrjtIzJnqeXnXFGnHAo80fg6hbmb/XddErIQSlYgjF0bI3itiVyjx/0hs5sLs1F5LWiavF1k3lJ+Qh05Ll4QvSx9YuJCTt0Xw4bLzrQLP6bVvRvM34/AJqsJGHgFuKeIYRcaP2uv9qC/IfXuaj3ZB3QW+yXcxBazo4EWSQ7F7VBTPOd+PEVQFDWU8YV73ojri0471fAAK3KWNWYimjB0kgFNTmtLXNPg0XhCEpUawmQs67vnhDZmjls9rNpwcM6ijmetkXBEp7JYtwqpDDxyc7381BpJiiK9PxZ8dDOriwsp6ncImXhJwIUPj3OvsVT1YCC45eKde8yKGYCgXTnMbznGdjGzkFAn8uUuE0gU3eZ+Whm/1YL/sKF7d8cMuXKHbSzwC6P4w6xtk/msFHUNIQ8VWMhMrV9SWyZ9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(186003)(4326008)(54906003)(86362001)(36756003)(956004)(5660300002)(16576012)(8936002)(508600001)(31686004)(2616005)(2906002)(31696002)(26005)(66946007)(316002)(8676002)(6916009)(38100700002)(6486002)(66476007)(66556008)(558084003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aEovMDRwR0VoQ2FRRjRpRUZPSWdUYUlINklwaUFHK0hiSjViMzJCNy91Unpi?=
 =?utf-8?B?U0U5Qm5SYXQ1Ri9mYkJEVUpJRjk3aHJ3OVZUODJqaWl4alRienZVaFdvM25v?=
 =?utf-8?B?b3NRYlh5Z1UwWGJLbUphQzBLdDlVVHdaNEZrcjlEVU0zYU9jVFl6cGEraEtK?=
 =?utf-8?B?NkRzRmt4cGF1ckREVS9rMEtpdnhhbmNsTEtneUZkc1hGQnBvM1ZhVUw2QzQ4?=
 =?utf-8?B?R3RoVEdaNGhCbWlNZm0rTmMwcER4UllxU21VYTRoeDhEYkk2V0dnaEpZRFNu?=
 =?utf-8?B?OW9VMlVSSTlBV2xITWJ4VXhBWTBUUHBqSndZemE2T2pzMUV2Y2xyRklIQXFh?=
 =?utf-8?B?b0hkNllhV1FQVXprUzQ3VGZDczI1c0xuMk1LN0FnNzBZNlVpd2hsTGkwWTJ0?=
 =?utf-8?B?VGd6Y002V2krNEhmR3l0dWpQVE9YSDlOSis5cFUwbkU0Umk1Y08zaC9yRDZr?=
 =?utf-8?B?bzYweWRpaFk0Yks0SXhPZlR6STVsaDhMQUlGUG1LeHQxdW8rZU1IUGdhMitq?=
 =?utf-8?B?cXFPTnp2My82NlBLUG40WWVXQWNFQXhaVXNHdFRNUStyR0dqTVdUR01ocE90?=
 =?utf-8?B?dzJCQVhzSEVtSllwbDZaRzRsdW5PcWNNaEtYSmo0M0szaSszdndzTkx3c3BO?=
 =?utf-8?B?KzFXT2tpU3FLU1pWSE4rbGxHSFhkL1BSbGZaM25jQTZ5Vm1UWktQRnUvZGRh?=
 =?utf-8?B?SzRhN1c3NFhwalZRQTJDN2xidW43Q0Y2Q3BDRW1acTJjeDd4akE3ZjNPZElO?=
 =?utf-8?B?ZThDZGhnY3BBVS9Wc045NnlFYm1HbVBWN3FUTVVEZEM1K1BJQ1ZsM3BMUEpI?=
 =?utf-8?B?dnZOSVFZdHA0L0w5elNMdmRhYXZCM3lUbmdoeERMRVY2MEUyS0RtU1VBYm5I?=
 =?utf-8?B?c0FLM240WUdyRHFqQjREb0JWV0tiM05sTnNGS1ZPRnRFd3JKMGJrNnlhUTNQ?=
 =?utf-8?B?cU1XaXFYdGpldTBRalNoNTQ3NCt0QVNBWFZ4MUdOVEZqelJmQ3BjN2ExeHdk?=
 =?utf-8?B?THhLWWdkZkZLS01nTk5BVkMvdGhQWDdUODQ3VVM2bmVoclA3b0ZTa08vM0lR?=
 =?utf-8?B?MWNEemVxSTJJMWdGMjh3bnI3VWVXeW1PUzAvdHZUQ09rTVlIbUVTcjFwbS94?=
 =?utf-8?B?ZC9ibGlORk10RzlsZjNKOUV2RTdXSWh5ZDhGMHB4RkN0UDhacWhnOXZNRHkw?=
 =?utf-8?B?TnN2emZoWFdMYlpqUk4yTTBOM3B3bkdha08rbkR4V1NuU2M5YnE4QXpLeStQ?=
 =?utf-8?B?RFh0aGJTOHhSSFVYcS9CbHNXTWRrTEFKOGJ5VDdwcyt5Qmw2cTN5L1YrdVJV?=
 =?utf-8?B?STZjWkEyTFczclBtSUw1QjdDTTkvSGl4eWs4cWRaU1hYbXlLdmptSmZHcUJt?=
 =?utf-8?B?TDRWbW5tSE8wQ2xycElrdFFraDd0UXRZdmVZMFNIa2M4UHFYZUFzVTZxbWdI?=
 =?utf-8?B?TFNObGRsWER6UEpUTlprOU5VbjcxRHk1UndLUFNBVExLZTNXek9BQ3pZc3lk?=
 =?utf-8?B?VEpsMVhZMWhCa3ZKTDRpaEF4dTJwYVhjYjBXZHhJNXJnd096Y2l6S2pGWW02?=
 =?utf-8?B?S2FaejA5WVhmNVdoYXNkZ0xrTW5XT1NsZFpkbDAyRTVBdHVwbit2L24rM3FD?=
 =?utf-8?B?V0dnQ3ZsYnluSHdKUTRBUVRMM0w1MTVGaHpmUzVnbFp3clZ3c2pEMUp1cEJ2?=
 =?utf-8?B?RGtScVNPQUVqaDA5bjJaSGR5cy9nbW9VOE5rRVQvNFQ1OU8rWkZsb3Z0amhR?=
 =?utf-8?B?WHNtZzhjenZhVW84TkF2NW5pYy96OGdOTmhuL1ZTYnA3VVNLeTdTVlBJaHRi?=
 =?utf-8?B?UlhDS3REajNtUjRxd2kySm1HUXBiNEZHQncxZjhBM0NIYmFHUE90RUtsd201?=
 =?utf-8?B?T2I1ekRiekdHVG51V3FQQVdYREszdHh0MkJTNUVJZXZMWHdkeFkrRjl1VHVq?=
 =?utf-8?B?RHE3ZkpNbTAydHJiR2hKNlRnK2crb25sc1ltWjlkOEVGbUpJV0xxc3ZFT2di?=
 =?utf-8?B?TUlNSXlhdUl4bTd3ZFNpYlJJVnRrNVRxblhVU1NzRXhoTG9aSmRYS0hQQnNz?=
 =?utf-8?B?R3R0SkRsT0tlRGp0RXQzTDdtbWdya3BCWVhSZ2RnMVVabEx6ZFZKMUtOS1hI?=
 =?utf-8?B?Q09TRFQ5QTE4VHdZNzh3TWZEZnNLNU0wR3Z0a3p5T09rRFo3bmJram1kRDRN?=
 =?utf-8?Q?2yjS0aX4oV4GJTccrSveCO8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fce81fcf-261d-456a-e03b-08d9bbc0c864
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:38:12.1703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UV8+QIa8NPIE4Qty81jx5e/9Jt/+gf2zFp5C8VRhk3TfdGbTKz9pF6Duz8RLDap9+7Hsubc8BWIUfn7FmI9DBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

The original 1st patch has meanwhile gone in, but the adjustment requested
for patch 2 required a new prereq patch.

1: mm: introduce INVALID_{G,M}FN_RAW
2: memory: XENMEM_add_to_physmap (almost) wrapping checks

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:40:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:40:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243666.421556 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcNn-0000C9-Ak; Fri, 10 Dec 2021 09:40:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243666.421556; Fri, 10 Dec 2021 09:40:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcNn-0000C0-6h; Fri, 10 Dec 2021 09:40:03 +0000
Received: by outflank-mailman (input) for mailman id 243666;
 Fri, 10 Dec 2021 09:40:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcNm-0008SI-Fc
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:40:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2551e253-599d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:40:01 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-GYnaKQCEO5uwIFwvOui8Qw-1; Fri, 10 Dec 2021 10:40:00 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 09:39:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:39:57 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0008.eurprd04.prod.outlook.com (2603:10a6:20b:310::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 10 Dec 2021 09:39:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2551e253-599d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639129201;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nQbHxo+SG7zXc0WpjqfjCW7hun4rktAxwnnAypfq9w8=;
	b=dMWyyVtgdncU1XGXXLA7fHm+RdVecL/Hs2gWc0ahwlRJ310/bf6gxlhziH+XRJKinMvrvX
	b5JD/jl+GyU0+8Jy8U5u0Rdag0UIZCkF1N5L88Pu/oU9IDu+GyBxma9ReefhMkARHTJKzo
	5PnN3/GwR1ZAn5aSniBVa8zOmkkuv7E=
X-MC-Unique: GYnaKQCEO5uwIFwvOui8Qw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jvb9SjtqNm+73m7UPu624dGUJHV7WA7/IaB303mWKvUOi30Umc7B1kmqOk+PiBwLLiZCEHCWU+uinj7YCXlpomw0LgJ7VQ6Tw02NIISYJreJxEjH09xhByWgITZB3NLl2b/RiZKHIXIbohs9OaGlj4I9YjB/82qHGcIByvLUrGRztN25jY92bntC5y9Vq/SCt3z10EpQfqy7qoHsK5WkkiDRgGAM598YO60mH7er71WH3hMvb+KwDP5rcXmf0IZ2UWjJMovclui9u008q2JBIvuM3s1Q6pB3Xo10tkt8QWMwVOBnFR75s9rkABVJHcL94xhI5m9pl3pQTdwou7mLKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nQbHxo+SG7zXc0WpjqfjCW7hun4rktAxwnnAypfq9w8=;
 b=kW1zSbcpjDlW4j9XfeKz6MqmJ48wMeFNz//z5i0qs1ZG9/0DGE8q/XYYgB900CNxoFXEpr6dpY+FG6efjvIduORArLcQLMo/4xzcX82np3AiV3sUAa1RIWztxfqwriCbPGT79wgDausvy5v/bICQgKhkTeZHSb7yM/e7l+W/Z8h78G/Q6s++QgxtWEQD/U2dPeG7G3wrHUBTtkK2xXZZidKgu5xzTMKGhQoflJRSXG7hLHlMFpE43nixnLWti5wzz5xzP8CvJ9AvijbBc92QngaSWb3StTlmRoNvl9T0+zwGuGgcTuM7a/ju5NH9ScXfLA+buH8/wqE9n5oIoB/CwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6d2d29ca-0495-5029-afc8-7248f462db06@suse.com>
Date: Fri, 10 Dec 2021 10:39:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 1/2] mm: introduce INVALID_{G,M}FN_RAW
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
In-Reply-To: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0008.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a661d899-186b-46ff-1ac1-08d9bbc10759
X-MS-TrafficTypeDiagnostic: VI1PR04MB5325:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5325B4824F00A4BC1B8F093AB3719@VI1PR04MB5325.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	tWeAP6AIzSDp16yRsvHgDyp4CZTcacv/7OFE3BrIUggRgeLEg/aXrktR+d1tg0sCbYmGayrsQmSdIBTz/OS0u7pYxe5ICR6vigUn2WWEkhU1A/NuVbtdrJW5B/fWDLpno1Shzu12Z7XmOEr/HHHhqzIVwNzf+QZ6zo8xvjMaaaeRkz022fnday1l3CW0vAUbHP9hG7mCnpv8ni59buST1FuTPWRbPUGvWhfynIkSdz0KqfBRQ2wN8C2mRx6weXEzx2W8Tn5//oHVcYaCWhjvhAIy96bDp14qU9sIe9PvRKosxlaXRibyJ9Zc0GMcDU1Kn3e/tIRZK9tRxgfhs1Y1CwNhLVQMxltwyM47GnRTBeQdfZzQtX8HJ4ENhWNzPSf73jAO+YfrpSoJLsC04gL5JhkU48ATSeGlbmhr7kpgKCL0dXJX3gCY/hyUhuO427q2riOXlJRXtcTDhxfrIAuqiRSUYUDHHD4LByNZ2bEQcgTZe10pBgE0c7b7vmtIyrdT48r8Ggo8m4lD/HLke4VSStPAvnTdFQkHbaGZbElu4Cw1FFtlq6ft1mrYYuo5M/uelagCjVsIorOEJkqvtEyHT+VQndc6Pt2XMExPFvCIdIlcbAjRn1hR1w5jbnonZ4kcvCPxF/f/+UX6BdeBWPwOFPbegJrJVcArnW7+l//L7dpCR91RHooVIXkp/ZGpuwuxpzliHwFxXWYaOT7iqd6o78avtk6YTPvnx/PzBkU0Ffn79K6tgqfNbDqkcubIPNMeHtYX1k5WZNrV51f6vP9BeGWihM52WrR7QURSnLrCH/2gqhx0NxoyUUmvzLbbrSeHWLUtOqZiRYFGrM+6J2pq0A==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(8676002)(8936002)(2616005)(956004)(66556008)(66476007)(31696002)(66946007)(966005)(26005)(508600001)(86362001)(2906002)(186003)(38100700002)(54906003)(6916009)(5660300002)(36756003)(16576012)(316002)(4326008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q0dGK2w2YzZxSDJPSHBlUDRTUU93ci9KNDNtVE9pcjFQQ3oxTlFGcFp0NUs5?=
 =?utf-8?B?V3F5VnozalNnNXcyYUdxZk5MZ2gwbGdGTDRhY2ZMekFSem10UTMwTVd6S0lX?=
 =?utf-8?B?SlhLOUZobTlWUEJnNC9pZ1ozWVZXNzE1aExGR1FDN0x0QkVLcVE4OGtMQ0Fq?=
 =?utf-8?B?eWRlSDRSRGFUSkd4QTVGUFhuSkJBT05kMmUwTnlSQ2Y3cUcxL0RJMHFXL0h6?=
 =?utf-8?B?VUViT1NGN1lMc0pHaVVKNFZWYUl2Nm10N0JvMFo3S0wrZU5MTTRZOVFqaWtY?=
 =?utf-8?B?akZTeE1MTFZxVk94NjltZkZ5dmNvWkd6bmNPU1o0aEFkVThNbDRXTkZud2dS?=
 =?utf-8?B?ZlpLd0lWa1lIcitwdFR0VzFPcjZrbFdpYjc0SVpsd2F6aHZzUW40aTU4SkdQ?=
 =?utf-8?B?YlFwS1g1RDNXRHZWWFBwSUFqUUhBVXkzYnlNS1ZhYndEOUlLZ2htZ09zc0pr?=
 =?utf-8?B?NzA2ZmhiUXRlZzZ0bzdFVDNYVE1XVEZPSlJGYXVDTTBoZlRhTXBLc2JCd29i?=
 =?utf-8?B?VFdqcTJJWFRXWG1FL29vcXFpS3ljVHVINEtNVXc4YU8wZ3FqVTM2L3JIMGdl?=
 =?utf-8?B?dkpFVWl3NkhrVWhKeXBuU3VWS3BEcWxmeEI5bGllSU1KWTR4dTNOaGtMWmFC?=
 =?utf-8?B?Mm5sRzNxT0ZGNFBsM0ZORlprYTJBb1RnYWZpRlRpT0RJaHgxakxrR3pQM1lh?=
 =?utf-8?B?RkdpUWNENDc4eGpkTlAzU2NGNHg1d25tdkMvNGpUTVI2ay80K2wyT3pGVkpW?=
 =?utf-8?B?d1YzOUlTbERJN01MZG4rNEtjbDlRVTRNNlEzTCt5emhNZCtwVGtkMnBWd1pU?=
 =?utf-8?B?cWRLbnBBWWdwaVNFSnpMaU84NE9scUlDc0RDYm4welNCdEZDaGVPN01zY0Z6?=
 =?utf-8?B?a2xIbEtqNzVXbWtjQ1pxZHB5azZEMnVVOTdFVlhoWEdyYWFwY3dERmJlaXI0?=
 =?utf-8?B?K3BkcW5ETytRRXdIaGFjalhiM0Fkd1FYaExEdWU0MmQxK2srMHQ2MkZudlJh?=
 =?utf-8?B?dHljbTBoeTdQa3Q5UFVMbHp3T2ZFL1RMQzVNOXpjcmF5SWt5UWNRcUx5aUJH?=
 =?utf-8?B?dFZxQWU2ODhNblQ1bWZvQUFEMFpsb1IvRWN0S0VoeTRPenNDOGU0QzZFSHF5?=
 =?utf-8?B?Uy9sU2FvN2NsRXFUVG8vUng0YkkxMUR5SmJxdVBrQ05JeTZ3cy9ub2RDaU9q?=
 =?utf-8?B?anJjbmF4L0tVT3VoMDAyb3Z1WUcxSnJIZEF0dUdTb3hwcG1GbHVjTEZiTm1T?=
 =?utf-8?B?QSs1SjIya1oxQi9SRHp0UG9VRXRUOW14bFBWRTRlYlZIdlRPK2JNWWlXUmFW?=
 =?utf-8?B?SGcyQzYxVHFLQWo3NHZYY1RJaHU1dGNIQ1JOUUxTQ3B6b3djenpYUGRmck9q?=
 =?utf-8?B?c2RBVVNyUXhCTEJKbTl2Q1BDbllXMExFSVJpZXFkUnhZQTZnZHpHd0JoMlpX?=
 =?utf-8?B?UVJtVWY1QTh2UU9oZ1E1R0pVUzhDMUtCRXVGWnhMeDVzZVpQQUpmaENWVWFW?=
 =?utf-8?B?L3hxTzRuN3lqZDU2MndkS1RXN05oZy9aRUxEeEowOVgwVHFiVkJEQnhvaFZK?=
 =?utf-8?B?R0tQZEpFUCtvWnNTSmdKZXMzVW1SWEcxVHF3SVljQVB4enFhVE9nd1BLYlox?=
 =?utf-8?B?R0VmbC9CWmVHRk5ya2t1L0tzVExLS25IdjJxUVlCTzhUUGpWcmRIS0Y0dHVY?=
 =?utf-8?B?YVl0WEx4Z1doYnpiWEduckxOWWdZWUpRb0dQT2o5Y1ZtdTJTUWczTmZXSXkx?=
 =?utf-8?B?RmxvUFFLdnowN0k3bFpwWm1MNnN6OVVESVNQZnA5SVdvaXc5Zm9wR242QUVx?=
 =?utf-8?B?bC84a1VkNU1rOVNjcVN2dEYrSFc4OUs1VGdka1phdFFkNFFiZFFtQkNKK0V6?=
 =?utf-8?B?K2IrQkNMNFBZVEJOeFF3aHA5NEJQajVXMFk1YmVGMGFRSWVYWVVxVlMrS0RY?=
 =?utf-8?B?OVUvdXpRZWV4c2ppWm9Vb3RlaTF5UVFySGJDd0ZINGY4QnMzK2ZnbG5WM2Nu?=
 =?utf-8?B?UmlHN2ZkdHRTTXBsREI2MkRSOGlmM0krb2M3ZTQzWnRuTWZsL1NSaEE5NkRl?=
 =?utf-8?B?em5IcHVQOHJvY2hheWcvaGphVlRpU1d3aWtxa0NMOHFkem1LTFNML2JOR3Jv?=
 =?utf-8?B?bFZOR3dVM1c5VzVNZUgxcitIQkhHcGJzdituVU1xVWlxeTFDbkJQMmhCdUpT?=
 =?utf-8?Q?rTftEKnTSAIdkIyIiR7l8Fg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a661d899-186b-46ff-1ac1-08d9bbc10759
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:39:57.6867
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IhuZy7DoPlcfAh9YyfluNT/2Lr6SlHMfDMEpgOLtFMrqXrZUN+Rj7lrr1JUbFX4r9nqAXVzd2yAeVA0wQ8K+MQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325

This allows properly tying together INVALID_{G,M}FN and
INVALID_{G,M}FN_INITIALIZER as well as using the actual values in
compile time constant expressions (or even preprocessor dirctives).

Since INVALID_PFN is unused, and with x86'es paging_mark_pfn_dirty()
being the only user of pfn_t it also doesn't seem likely that new uses
would appear, remove that one at this same occasion.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: New.

--- a/xen/include/xen/mm-frame.h
+++ b/xen/include/xen/mm-frame.h
@@ -6,12 +6,13 @@
 
 TYPE_SAFE(unsigned long, mfn);
 #define PRI_mfn          "05lx"
-#define INVALID_MFN      _mfn(~0UL)
+#define INVALID_MFN_RAW  (~0UL)
+#define INVALID_MFN      _mfn(INVALID_MFN_RAW)
 /*
  * To be used for global variable initialization. This workaround a bug
  * in GCC < 5.0.
  */
-#define INVALID_MFN_INITIALIZER { ~0UL }
+#define INVALID_MFN_INITIALIZER { INVALID_MFN_RAW }
 
 #ifndef mfn_t
 #define mfn_t /* Grep fodder: mfn_t, _mfn() and mfn_x() are defined above */
@@ -44,12 +45,13 @@ static inline bool_t mfn_eq(mfn_t x, mfn
 
 TYPE_SAFE(unsigned long, gfn);
 #define PRI_gfn          "05lx"
-#define INVALID_GFN      _gfn(~0UL)
+#define INVALID_GFN_RAW  (~0UL)
+#define INVALID_GFN      _gfn(INVALID_GFN_RAW)
 /*
  * To be used for global variable initialization. This workaround a bug
  * in GCC < 5.0 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64856
  */
-#define INVALID_GFN_INITIALIZER { ~0UL }
+#define INVALID_GFN_INITIALIZER { INVALID_GFN_RAW }
 
 #ifndef gfn_t
 #define gfn_t /* Grep fodder: gfn_t, _gfn() and gfn_x() are defined above */
@@ -82,7 +84,6 @@ static inline bool_t gfn_eq(gfn_t x, gfn
 
 TYPE_SAFE(unsigned long, pfn);
 #define PRI_pfn          "05lx"
-#define INVALID_PFN      (~0UL)
 
 #ifndef pfn_t
 #define pfn_t /* Grep fodder: pfn_t, _pfn() and pfn_x() are defined above */



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:40:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:40:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243669.421567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcOS-0001F6-IT; Fri, 10 Dec 2021 09:40:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243669.421567; Fri, 10 Dec 2021 09:40:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcOS-0001Ez-FH; Fri, 10 Dec 2021 09:40:44 +0000
Received: by outflank-mailman (input) for mailman id 243669;
 Fri, 10 Dec 2021 09:40:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcOR-0001En-BN
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:40:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3dbb2004-599d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:40:42 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-PlJ-ZA4CPXOzpmKLfSxNUQ-1; Fri, 10 Dec 2021 10:40:41 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6670.eurprd04.prod.outlook.com (2603:10a6:803:120::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 09:40:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:40:39 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:20b:310::17) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 09:40:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3dbb2004-599d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639129242;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/ea6giwOa1Pf9wAAzmwlZGs6GybWSd+Ba6eO/po1jxw=;
	b=SgaH0Y0PmO/r7jp2WU9vPIbdILHgv7Tl3d9Q6MG9x/Q7GAEJZODklLZN0MKlMw7v6RdWMy
	v2VTUnzMoBxj554j9XOKMNMygXjYq3dY5hkOKdB8el1YRVu3P8o4y59YiW3VXQDcNeEfK2
	sbGlhLDXhMaSQ0nuMqOuFEpSUNFIuFE=
X-MC-Unique: PlJ-ZA4CPXOzpmKLfSxNUQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lfDvS4fYyVHJkG/cFhUOlN/AYsyXcZcoMpCEmszGEOHjtWXe/ukgoU0aFcRLrcheRC69nuEHuL3mL20GxZDF63PyYld9yIYRANWZ1hceuyIo+nko7IPfigwTskO2+nVVsWb7QvQo1RglEKywjiC4Dgv8Hng7jib4SGo10RQRK1iMEmg0HC6cb9vpjezvl4BW3M5ctceoqMjczbhS6p9N/Fk0/rc5dF3+sL/fEsnYkXyjAGsQBiEYxqJAGcWA5S3ZoBRznwPIfWVk08YjgYt34pVgFn+kCxM/dmnERBLZFfjP8xyULjIuDyA5MtB92pOSQlSfAGluFt83ok9GnbEnSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/ea6giwOa1Pf9wAAzmwlZGs6GybWSd+Ba6eO/po1jxw=;
 b=Bu2GzTWjo4y9TvZg5/rvkVT9NY7M9phaNVfRu/TdQP5jA0kCOiKGvK4I2CyEqySSZ97NYIqQ1CAls5g6R00YxF+N/z5yYdyx/SRq0T7sPFSu2xPRveZ9A4Fqt4AENfphVofZBAAfC6XLvkqWx+2MtiYbuUEC3ucB9UdmbA5VdW2UyeUXxXIMGGhz3BhgxD8rk1jLnNfhCFxXNTiX6JC2CSxLtaO4Pb+YKrHvqofXEPNCcjaXSFRDITMM1xUsSpt6v0mWNeqDOUWOUOOx8DkCnmHLy9nI04bQrUgeapTIjksX63U82+GrfzynJ/XaLuweCaJ+6MaABVt17fw1ckp4cA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <0b68ff3a-3c82-f800-4d20-17eded13163a@suse.com>
Date: Fri, 10 Dec 2021 10:40:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: [PATCH v2 2/2] memory: XENMEM_add_to_physmap (almost) wrapping checks
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
In-Reply-To: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0012.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 89b85327-3fd4-4e29-42d7-08d9bbc1205d
X-MS-TrafficTypeDiagnostic: VE1PR04MB6670:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6670E75CDF0310A3B50CF5ADB3719@VE1PR04MB6670.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1E+N7cW7yLgAvHI2Ekh3YUXY0BzgZo8wt1ivCYQL8JRrHFcBrypjO/0Ac+jgZ6O0KZV+bCJ6S37TcqsBKEDgUX8xZawXUkbqpiQskIvg2c6BD9w6AMFMVTOKs3j2IjMY179eo85OtMBdur32nq3hkB7lFf+htv0s8PA0TwoxXHIYZbASKtMDHVZYkFFkWYhZe6Z8XmdtzMu2G9O0i2StKUbJiJYqXTAGma46oKeHAWovexUTtw2TZe93KzMfl8FF5SdOfF3r4xu+zH7CeN1FeXqcCXF+W1yEkZG2DqOcmLIHP5nMiYaIxEcJx0OjHDqPTs8nbc2QpZBqHS1yJ4WthxLQyx1d/m80gfVfawHa6HL+wUpnu+zHwowfyu9dDOb5qy6x9Iy6iEYty8YzPG/rtaTLCE4wasCwJyv7UOfQ63mAwDS6PROgmcTffYX7vKr819wKaBzzucXf/2+VNE4RuAQ17OIRcGfGqfXy7J00CT79GCvYYNU04PHMMbDZcb9TWPGYivacQaqni+cY+07O/XazF5klR+8RvdIdADewmO1cO6l0IuGUS2cYR9lHqMko8dbvuP0ext4BiOC9yrnuzB39J/+Ts6tMdFNYIyfUHkOmDhEjx7Gt/pCBriGu+BIm+492HEiRUtK2au4IOZsRIJMN2SbXNX9M7MQNFzuXp+uDum3+ePj7+0ADvz/L4hdan+CREWftpSXb17ErLH0w92mfleTS7zn7qTw4BE9yvtsRdSNfD0kvKVETx3Q4vCgv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(16576012)(31686004)(83380400001)(38100700002)(54906003)(956004)(6486002)(31696002)(6916009)(8936002)(66556008)(2906002)(66476007)(66946007)(86362001)(316002)(4326008)(508600001)(36756003)(5660300002)(8676002)(26005)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MW9DUGt1ZGhyL0psd3d6TDlzTjNlRGpyV2xqb20zbWw0NHBYQzBCWUxxR1JB?=
 =?utf-8?B?Sjg4S0xXUndxdm5wWVNaL05Jam1SaTFONGlGRkNwWWQwYzZaV0U1ejlWd2sy?=
 =?utf-8?B?cXpNQ3lBVjEwbXRpWmk1T29VN0FUdzlZZHR0bVl3a01Ka3dBL2dzM01ueW8w?=
 =?utf-8?B?b0hBeGhSTGUzcStxRUhqOElVTE4wV3RxWTRCSVQ1bXJRNFA0NVB5WWtONk0x?=
 =?utf-8?B?VjFEcVFjUHhlaHFQSW9YdlRlbWVTNXhHWUxkbWpzUzd6Y2liaGNOQWVVRmVt?=
 =?utf-8?B?S0pteEczRVhqa2wxZmZ5WUNIU3ptM2VHUzgza3l3M043VG5UZE5HNEd6WGxZ?=
 =?utf-8?B?UlIxenV0MS9USEs1WTE4bXVFc3hIanBBRWZWNmRSbWdLWlFreUpESFdDdXU3?=
 =?utf-8?B?YWFNUzNhZVVZUlcxN3Nhd3pKYU9Rbkxsd3Jsbm1yb0wvcis0Vmx6WjJvTWVE?=
 =?utf-8?B?K3FHNk5NcEttSHpzRTkrVVdUQzZHOGg2eFRHTGhLUC8vVVh4ejhoQlEvV0Vq?=
 =?utf-8?B?UDd2YkcvMS9remM3K0NHQnFhUDdtNEhMRldwTWNBSTVSRGFZczNxZ0hER29I?=
 =?utf-8?B?OUx6Wmk0Y0RjSUgvN0NXOVZmcEFUUlJLUHNuY1VMMkkxUUFPUHVRYVRpbWJZ?=
 =?utf-8?B?R0VReUhobEVvc1hmdXBxN0crTnphbDBCTndJd0VCWGhTTjJKK1VuWWN1ZWx0?=
 =?utf-8?B?bHUvbGhIeW5IZldMamlDMmx2YkdXOGR4ZXJrSllTQXBUVjRhUWRadzNUTUhF?=
 =?utf-8?B?bmtYUXBva090RWNUdnFVM21YU3JweHFtcXBoUVpZd2pBK3JBY3NIemFGL2lv?=
 =?utf-8?B?NmNvUzZwbFZQZmx4M241eVFmYkJoV1JxZnBTdXdTQThLVVU2M1Y0M3FWNmhs?=
 =?utf-8?B?eDhtcFNYWm9aYkFoRXVPUndwY3ZVaXlKM2tZZVdqUzQrWGkyWDFCOWRFY1ZI?=
 =?utf-8?B?NGkwZkhPM0lCaEtmR0FJMi9HSlkrbm03UUVGbGExWTdpMzE4ek9LejA3T2gy?=
 =?utf-8?B?RXBxcHpSS09iN0M1cndHcVdIVWg4d0VvNVRreVF3VzBvQk1VYWxkMUFOejdh?=
 =?utf-8?B?cTRLN0svTEtoVlZFbjRIbW1FNlo0RHczcFY4cDdJK1J4ZW54c0FtbHFZSUhm?=
 =?utf-8?B?b0pHZFppdHJXNzRUbnJtUitZM1I2QjBqaC9GeW5lZ2pqMXBoNWcrRHhsS0xB?=
 =?utf-8?B?dG9ZWVRFMVdReHZhVitXaDNJTHZURXRDaXpEc2s1TytLbTFRSFZiUkIyU1FI?=
 =?utf-8?B?ZURWdUJEWCtxMWdETHJIZ1dEOURRTTF4Z09zaTYwcWVBbFVkSUN6KzBxcGhW?=
 =?utf-8?B?bFQ5TFdtMWJ1a25DMHQ0NkwzVEgxSVRWcDltdkdJc1hnL3FacklERk0rdVUy?=
 =?utf-8?B?N21UTFpHTU5DdTNSOElSZFdtT0RmOUJYazl0SUVHR0VGOGExUU9PK0hwRkoz?=
 =?utf-8?B?YkNScEdlZFlyd3B4SUFuQ0o4Wm15bWpBRDhFR0lNVDBDUmZVZHV2bDJoTUdK?=
 =?utf-8?B?TDRmSDZoTjk3d2FYYTc5V2VMS0RGQ3FnS0NZdm40K0NLQy9lbHpsa0lOVTZW?=
 =?utf-8?B?WG52dDMxM2NmZXV1TFd2eWVWUG1vekZsTjNtYmM3dlRKODUwQmM0WHFFUXBL?=
 =?utf-8?B?WnB5eXlwdVlFMXFxa25HM0hRcFNRcHdFdkhnYkNzTUw2aWM5a0ZqWnBtQXZ6?=
 =?utf-8?B?eWZkZ1E5b29IRitYWm05U2gxMDJCeDdiS2hwcGEwYUJRWW9Zc21LL1RraGI2?=
 =?utf-8?B?WWpBK0RnSDdaYnVQVkpXN3c5VU1kLyt2TmszYTNybm84T0N6dlJ5cXlrUW01?=
 =?utf-8?B?Y3NWWEd2SC9VYVd4WE9IZUlFa2xYd1k0R0dKYkdGMUtFckFKN1o2V1NKSjB3?=
 =?utf-8?B?NXFZL3MxN01TcjNOVXJkQXFtVHdZSlNNZ0xwc3FDQ21jNWlOVGJBSmc2N0pB?=
 =?utf-8?B?S1NJWncyK3JvczlxdzlSYnBHTndsZlhEdEUxRHVhTHJWaXRLZ01uV3JTVHF5?=
 =?utf-8?B?dW5nd1dKWVBtb05jRk01NGRzam1zeEJ0YmFxL0FNOUQxNFV2YlBmWktadk45?=
 =?utf-8?B?Tno1cDJBNzh5a2ZrYjNFY0E4ZTFGQmZVcDFHLzJEa3JteUFhZEs3azZ1UzVX?=
 =?utf-8?B?M0dBc1dJYng0YjBpaXgwK1M1dW82d3FXZU9EL2cyczl2ckl1VHpwT1pSN1k3?=
 =?utf-8?Q?5so9el1oKx2arbyJnj7rcAM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89b85327-3fd4-4e29-42d7-08d9bbc1205d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:40:39.6600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R2Tn/V4T8uEhYbl9GThh3loAnRBPP6zN2uacdche2V6jd1bBp9QxDGEtlmhQ3tCdDhzOhVbaS5AfUTJh55rvOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670

Determining that behavior is correct (i.e. results in failure) for a
passed in GFN equaling INVALID_GFN is non-trivial. Make this quite a bit
more obvious by checking input in generic code - both for singular
requests to not match the value and for range ones to not pass / wrap
through it.

For Arm similarly make more obvious that no wrapping of MFNs passed
for XENMAPSPACE_dev_mmio and thus to map_dev_mmio_region() can occur:
Drop the "nr" parameter of the function to avoid future callers
appearing which might not themselves check for wrapping. Otherwise
the respective ASSERT() in rangeset_contains_range() could trigger.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Add comment to BUILD_BUG_ON(). Avoid transiently #define-ing _gfn()
    (by way of new prereq patch).

--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1479,7 +1479,7 @@ int xenmem_add_to_physmap_one(
         break;
     }
     case XENMAPSPACE_dev_mmio:
-        rc = map_dev_mmio_region(d, gfn, 1, _mfn(idx));
+        rc = map_dev_mmio_region(d, gfn, _mfn(idx));
         return rc;
 
     default:
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1357,19 +1357,18 @@ int unmap_mmio_regions(struct domain *d,
 
 int map_dev_mmio_region(struct domain *d,
                         gfn_t gfn,
-                        unsigned long nr,
                         mfn_t mfn)
 {
     int res;
 
-    if ( !(nr && iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn) + nr - 1)) )
+    if ( !iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn)) )
         return 0;
 
-    res = p2m_insert_mapping(d, gfn, nr, mfn, p2m_mmio_direct_c);
+    res = p2m_insert_mapping(d, gfn, 1, mfn, p2m_mmio_direct_c);
     if ( res < 0 )
     {
-        printk(XENLOG_G_ERR "Unable to map MFNs [%#"PRI_mfn" - %#"PRI_mfn" in Dom%d\n",
-               mfn_x(mfn), mfn_x(mfn) + nr - 1, d->domain_id);
+        printk(XENLOG_G_ERR "Unable to map MFN %#"PRI_mfn" in %pd\n",
+               mfn_x(mfn), d);
         return res;
     }
 
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -4150,7 +4150,10 @@ int gnttab_map_frame(struct domain *d, u
     bool status = false;
 
     if ( gfn_eq(gfn, INVALID_GFN) )
+    {
+        ASSERT_UNREACHABLE();
         return -EINVAL;
+    }
 
     grant_write_lock(gt);
 
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -832,6 +832,9 @@ int xenmem_add_to_physmap(struct domain
         return -EACCES;
     }
 
+    if ( gfn_eq(_gfn(xatp->gpfn), INVALID_GFN) )
+        return -EINVAL;
+
     if ( xatp->space == XENMAPSPACE_gmfn_foreign )
         extra.foreign_domid = DOMID_INVALID;
 
@@ -842,6 +845,18 @@ int xenmem_add_to_physmap(struct domain
     if ( xatp->size < start )
         return -EILSEQ;
 
+    if ( xatp->gpfn + xatp->size < xatp->gpfn ||
+         xatp->idx + xatp->size < xatp->idx )
+    {
+        /*
+         * Make sure INVALID_GFN is the highest representable value, i.e.
+         * guaranteeing that it won't fall in the middle of the
+         * [xatp->gpfn, xatp->gpfn + xatp->size) range checked above.
+         */
+        BUILD_BUG_ON(INVALID_GFN_RAW + 1);
+        return -EOVERFLOW;
+    }
+
     xatp->idx += start;
     xatp->gpfn += start;
     xatp->size -= start;
@@ -962,6 +977,9 @@ static int xenmem_add_to_physmap_batch(s
                                                extent, 1)) )
             return -EFAULT;
 
+        if ( gfn_eq(_gfn(gpfn), INVALID_GFN) )
+            return -EINVAL;
+
         rc = xenmem_add_to_physmap_one(d, xatpb->space, extra,
                                        idx, _gfn(gpfn));
 
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -297,7 +297,6 @@ int unmap_regions_p2mt(struct domain *d,
 
 int map_dev_mmio_region(struct domain *d,
                         gfn_t gfn,
-                        unsigned long nr,
                         mfn_t mfn);
 
 int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr,



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:40:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:40:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243671.421578 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcOa-0001Zs-UR; Fri, 10 Dec 2021 09:40:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243671.421578; Fri, 10 Dec 2021 09:40:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcOa-0001Zh-QB; Fri, 10 Dec 2021 09:40:52 +0000
Received: by outflank-mailman (input) for mailman id 243671;
 Fri, 10 Dec 2021 09:40:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvcOY-0001En-Ni
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:40:50 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4045abbc-599d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:40:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4045abbc-599d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639129248;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=ypTxCdICQoNxy5RsIr8bp1QL+9ixRXKt+hM8zLxPkqc=;
  b=O82RI0Yvoc3dRVwnv7tVpfJSQtCM5YUZnZovfgL55/2GchNvmiCQDAuJ
   Ml1UPUn6et3BJ51kuWWdrEQll259Wyrp1gGeYRbmkoCmlv8pdRYj2465F
   OD5fW1VM330ulkfCdDI/4Bh8GZwRnx1/odhc6eXHmb1gpQsW8+PnOnoww
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 20nt6s2aK78oGIjHzTiPvgyIC7pGXJpjpf4p35iEQYwj40djTF7oxLWvh8jGEfVP9YWZY8Tirt
 K28kw68m4r/tgjD09K6FZYgvispUX8yOqWcC4UBQh+HnHI8nN0W7+hiKbwR2nO8jncwuBZurYq
 OuYrT8Y8DKNxMf6SnhkOvYw2B0pGIuuGw6to3DYVVqYwYTIX+H+O3HkrVcmMj37pwEOos42C3Y
 2v3GVbzXyS6VgPgbYJwr3bZD1vxN9uD+wgX4TeDF+GRr+V/ER6b/iYCoJ3uvQkUc/UU17kmhPG
 ol1qUk/gipRXeAfdE/Fz2Srx
X-SBRS: 5.1
X-MesageID: 59667623
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:KnjDkqPxpGeFaDDvrR1HkMFynXyQoLVcMsEvi/4bfWQNrUp0gTwDy
 mdNDGqBbquCMWPxf492btvi/EsC75HXx9NrHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s7w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoyyPlopP9
 clijKGpTikWDqP1gcoiXjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/ibu4EHgm1r7ixINa/3T
 YlaNz10Vz7dcQNJEX0bGpU9zc790xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1Kmm6Iq
 2SA+H72ajkYPtGCzTuO8lq3m/TC2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcUj7gjX9JfIzD+kH28qcQ5PUcUIi8IfEGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdRGmoq
 w1muhTSkFn6YSQj86ygtW7KjDu3znQiZl5kv16HNo5JA+4QWWJEW2BKwQSLhRqjBNzAJrVkg
 JTis5LGhAzpJcvS/BFhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43aZdcJmK1P
 heC5Vs5CHpv0J2CN/cfj2WZUZtC8EQdPY69CqC8giRmPPCdizNrDAkxPBXNjggBYWAnkL0lO
 IfzTCpfJS1yNEiT9xLvH711+eZynkgWnDqPLbimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq
 I0BXyZLoj0CONDDjt7/rdROcAtUdCdjXvgbaaV/L4a+H+avI0l4Y9f5yrI9YY112aNTk+bD5
 HamXUFEjlH4gBX6xc+iMxiPsZvjAsRyq2wVJyspMQr60nQve9/3vqwea4E2bf8s8+k6lax4S
 PwMesOhBPVTS2uYp2RBPMel9IEyJg62gQ+uPja+ZGRtdZBXWAGUqMTveRHi9XdSA3Pv59c+u
 bCpyijSXYEHG1Z5FM/TZf/2lwGxsHERlfhcRUzNJtUPKkzg/JIzc376j+MtItFKIhLGn2PI2
 wGTCBYehO/Mv45qr4WZ2fHa99+kSrIsEFBbEm/X6aeNGRPbpmfzk5VdVOuofCzGUD+m8quVe
 ugIner3N+cKnQgWvtMkQapr1683+/Dmu6ReklZ/BHzOYlmmVuFgL32B0ZUdv6FB3OYE6w6/W
 0bJ8dhGI7SZfsjiFQdJdgYia+2C09ASmyXTsqtpcBmruncv8erVS1hWMjmNlDdZfel8P44Sy
 Os8vNIbtl6kgR0wP9fa1i1Z+gxg9JDbv3nLYn3CPLLWtw==
IronPort-HdrOrdr: A9a23:zWgr4atOOdlyHeYU5qlNAj5h7skC7IMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLnAbV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJqpmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O87isIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXsHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa13ackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmP29yV0qp/VWH/ebcHEjaRny9Mw0/U42uondrdUlCvgslLJd1pAZFyHo/I6M0kd
 gsfJ4Y042mdfVmH56VMt1xNvdfOla9Mi4kD1jiVGgPNJt3c04l+KSHq4nc2omRCeg1Jd0J6d
 L8bG8=
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="59667623"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fq71SeUkMIG5r3wh2VAJ8aAUhtmXXVCivspvkM/8V2ALLc1gSHjlIRG301fWB5c2XHthoo250ve/ms6bOkHGJ5EkVlMbtXZaUlcqVx6d/MELTKO00bJ8YorVmG6+yQLJuM4ppFDvsbhOQZDL4Tn5da40HecfmeLh3Ch2BDA2WgEfqXlP7XC/udP5BIbtUGkql10HI9SnazxRQ/bvfxybZLaklhGZs/0icUaf+mXujIsOKPK9ZgjaGwHXfHT9YJzZfmHJOmUTDa4rT/rl+T6R2l1XBnB/prWZzqH6z2CCQecCqMhnOWMYXX+3YoJXyTYs3a6DTuqMMz34Qr3KwucVWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TIyypW6AzLL5gp/yEy22ql5gxDAYqGlkZ9UX1xagXgM=;
 b=QQma8yulTZ5H14tzZy6OaSMVP2mEfUHcZGZVt/hE5Is6cAQ5dxtTqCitS/AoRhwd2Y1NLYsxUs/SObrSpESnshndNhwTK2r3RreYkwBykIkPhcTlJwpCHY9TnWQNKl0sHTwWC+PfF0MyleRr0e8GL1uBHBpQ5yQQIKt3tp2YF0iluI5Q03Lkuapw3FhXABYShkwOWiJhUNNNfHc3DqXnk0HoiK7KbLZ6rHxcnfXMCb9iICD2wiYPie8YYE97/UhAdN/ppsDSMNdRU9kTGhXI1MZ5OuykmJoVOhcutXlL/bmts7Zsc+GHMX2CzwwVhD4s9EB0Yq6kbSU4fCdBG2znnw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TIyypW6AzLL5gp/yEy22ql5gxDAYqGlkZ9UX1xagXgM=;
 b=xG6sn8NG1fmeZhalWRxehpqv0BwBLSXRIkAJG1GVRfnk+1iJsQYQyrsoHXzonAs7awHSAx969zRxOXxcvefk6li1aCa1oZmK0JXZ8zI3AvZkAQyp7aqyzz+54YvVBZ6GBGGoY7inA9Mpd1Oj9EYnapH3EVVOTsGk1dCNB/bcn1Q=
Date: Fri, 10 Dec 2021 10:36:28 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches
Message-ID: <YbMfnFWIlSN+GXH9@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
 <YajTvrZz0xGOR3vT@Air-de-Roger>
 <2a3a0a37-525d-e2aa-b396-b01d97434d56@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2a3a0a37-525d-e2aa-b396-b01d97434d56@suse.com>
X-ClientProxiedBy: AM0PR02CA0211.eurprd02.prod.outlook.com
 (2603:10a6:20b:28f::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63959696-634c-49ff-bfd5-08d9bbc08e8a
X-MS-TrafficTypeDiagnostic: DM6PR03MB4841:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB4841727490CB534E2C7563028F719@DM6PR03MB4841.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nIpOMpHpFapRijrW4nGymNa0KQyneYWotF6HbEd+CTVKh6e5+zBMKGcwbOKH64xrzI0CAO3tD2zT0pkEHNK2UUmk6iUqFGolN0cq8+Vazkzn6eD2uQwKmcAAQWE5VzHlDHINSewbe/PcubHnsuA1BbI5pdyLA6VqywCzuWbC8sQtRH+o0IYxIhX5X3y67NW6hEddpAdBS1vAauMQIUvjIVmOQKyE/1+i6K40zt7/R3nrLS+XLgzuziKJ1AkNwccvQY0BITLfn1avakDKGye3D03c5eEuFqKTyV2qxIWRLKEKnTCYacMb8Y/7rD/5xFrVlqK06AcCPHYj1YtCcwUZNsMlCqlqySoomOu2t24T8LS/RGlpBXRHlDUc63uWY/uv9FnsFXi//Th6ocb9VKNPfu4rGfCpULpPKVE4Y2ysHf7YeHWzLXJVrz/bsAd720miLaSbvD8ZdYWaj3gl4kQPcjNvT+TiCEcBu402a/L5WWpEV9a46Hk5txSORVPqpkGSGhKx5wy+cOcgAIpixvTCEWG+fb+bueLuzhne1uNKDyF3AqG3DWXPYCkFji2LD8BLTrTE6kL5RG63dDkDielBS8EUhlmdakrHGnpD0UtFCYAp8Pd/4d5A7D4OIs2wyDC6QyflHVKqpIllzw/4r4EXztqE7boAdKCPlYlxulZj37HZ1z7tfilAWgHrneRxGt2gCVDsfmn9k0OkZY5KemiIRw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66476007)(186003)(66556008)(86362001)(66946007)(54906003)(4326008)(6666004)(53546011)(8936002)(956004)(26005)(2906002)(508600001)(6496006)(6486002)(5660300002)(33716001)(8676002)(82960400001)(316002)(83380400001)(6916009)(38100700002)(9686003)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekZZTzg1MDVvendCSFlkR2w0R0RPNTZvV3dFNm5QdGtsbVQxSk4rb1VjM1Ra?=
 =?utf-8?B?eEUvYU5LMW1UQkJhN3BOWHFUQXk1ZWlyOWw4RzN4RUVwOUszdVFybUQyTkww?=
 =?utf-8?B?Ui9BZkc4RW4vMXFJVDlOa0JPK3hDc1ZCTFVUcVFRc0FyUnNGUmFTV0ticFFG?=
 =?utf-8?B?OXV6SjE1S1dxNlJIWnExZXF0OFl6bDhQRUFTUTN5YytFU1NFWU9vM0F5MWRu?=
 =?utf-8?B?dTRvZnFCUlo3dHZOUWxrRDVIQnRHbHdyOVZraGVaSWhkNUEybG4wRDhtL25z?=
 =?utf-8?B?UHcrMFgrS1BxaEljL1lOdnhueUVZZE15aDZFZGNkbVNaMC9GamUrNFVvRVNZ?=
 =?utf-8?B?RmFHSStWSE5rTHdtRElWQU9lbVdNeUJ3ZnZhR0xUMVBFYlBVWGhDdDJNaW1L?=
 =?utf-8?B?d2VtL014cCtWVCtlRnFxVmUzTFJkd1JXS0lVMStGZzRmTEsrYVh6TmFVWW5s?=
 =?utf-8?B?cHpsVGRacUZNVFZEcXQzT25GdHNBN0hwSS9XbTMyOWNJQ2twTXVlbkpINTJ5?=
 =?utf-8?B?OVE2NDg4YU1Ud2NtQVlSaW1taVowSU1yNlh4MzNoSVY2dFVQNWxQUi9ZRTBm?=
 =?utf-8?B?Y0tLMlhPMlVCemF0bmd4dEhRWXFkNkY4YUJPMXdPeGNqTlVNNW1VcDRMZlgx?=
 =?utf-8?B?UjQrWDJ5S3RKUi9saUJQTGl4VlVoUEFoTm01SGtvK09IdmVxQkRGYTFiSWZW?=
 =?utf-8?B?NzJraC9jWlpYQnFPa0EvS0prMnNYdXlPdE1ZNy9VZFJUNlJ2MThTTGgvSTBo?=
 =?utf-8?B?REdXQjBqMzlWQzBqYmw3b1NESFNzL1EwMlVCQzJJcWQ2dDZBbitkZkltV3ha?=
 =?utf-8?B?V3liWkd4RFFyK0l2aEJkWVBxTzBqMVpnYU0vSjJMN1hsbTlOSHRDQkEyRFg0?=
 =?utf-8?B?bXg5ZmdiQ1dWTmozOTdMV09vdFlUSWJNb25KZzc4b3oxcWRWL3g2TGFHcDJD?=
 =?utf-8?B?amFGaXpsRGJEeUphclZyWmRtaU9JNzl1YXdINlF4SWJ5VW9VQjRWZDJPc3Vq?=
 =?utf-8?B?MHNxV091MUZVbENta2VOM202cDY3dVNjN2JWeUpvL1NOd1QxSWtPVEZOaTZF?=
 =?utf-8?B?SGtjeHlRbElqMFJBcVcrVFlFcDhVL0hkcWZJNERNMytMdVAxSDQ5RE9PaEhQ?=
 =?utf-8?B?aTIrV2pZeHQ3VVkrWWpuSGp5aElKZ3JOaWQ5N1QzdC9oUURTV3pLTmlUYXVH?=
 =?utf-8?B?QmIySTZvTFNiYUtMc0NoZmVJR3QzMThXMWNsTmdhWFVVZ29wVjY1MkFacVRv?=
 =?utf-8?B?VWY5d1RSa3Y1OC82YnNGOTRmMkJnUis3OUtNdm9nYmkwdWZXRm9iNzhLL01o?=
 =?utf-8?B?ZVBRdEpvb1BqUnhzOWdKU2hhWXo1UmdVV2VMTXFnU1cwNDhDc2V6QXdJL1F3?=
 =?utf-8?B?Q0w2ZHlReFVoMDNGVm9IZ3I4eUw3TThRcnpsa01rOXQ1c28wSDJsd2NwQzBO?=
 =?utf-8?B?S0ZMamtGTEEzdjlLQWdzbDhGL1B4S3VhK1dNMFdVZCtBZzQyM2N3UGI2V1hj?=
 =?utf-8?B?OWZ2WmJwajVOM21DWFpuUFhCRmFNdzZnMEQvQloxYnNLbng4WTR4Qnp2eVRw?=
 =?utf-8?B?TzVqK1MxMjVZbEtVbU5pdWZMZHdsbnhtTDVCelFrRHZHb0UzRFFNNmFJb1BJ?=
 =?utf-8?B?YU9MaTkxNzJaeHRWbmdiOVc5THhubE9PeStQOG5IZHJER2N3TXJNWGI3Ymc3?=
 =?utf-8?B?ZjYwYzRId3M2U1o0R002SmlxMm1kdkFLeE8wNkpRSjdoWlNWeUxaRmlCWXpw?=
 =?utf-8?B?VDJXMXdXLzgrR212alFPb3IvTGVuVHdLOURjZTkxcWxrMEZvNGk5YlBBUDNK?=
 =?utf-8?B?VGExckdtdGF4OFQyNFIyVWpmV0U3ZVZJeXNtU0J4Wi9pbkxRWnRsS09JY0Nq?=
 =?utf-8?B?Yk03SEhBbk9ZS2xDb0J2MDlrZW1kQnBiNnI4QkhtR1JzSlJhRlZITTUzMGRM?=
 =?utf-8?B?K0NlZEV3NEtxc1NnRXZZTlNST09NdlJGRGVBejBKUmZyVUsyK0taTkNDc1ds?=
 =?utf-8?B?eVYva3pmbk1JZnJPQStadU4wZXNXbGVIMXR1dmc3a2MxR1RvajJpS05kZW1t?=
 =?utf-8?B?cHJzTVlaRXpRNldZQVNvckxGR05sd3FiclJTUmE3WVF1eTJ4VXc3R1Rhbm5L?=
 =?utf-8?B?WE1GOGZxSmRxZmppMDV5YWlHOHFyLzMvYWFTMWg2d1kyZUExRXZTcFBXcTNa?=
 =?utf-8?Q?4hGsJIemJrr9L+5z2xY8rEg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 63959696-634c-49ff-bfd5-08d9bbc08e8a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:36:35.0841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vo+PwqUCQLqoiGTaM9BWupiIqfxqN04mvtmJCImJ0Yqo+5xBy/hcHwRe+5sU6GRRrAxyUQPxZWJUsNx4OiSEGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4841
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 01:38:48PM +0100, Jan Beulich wrote:
> On 02.12.2021 15:10, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote:
> >> @@ -689,7 +763,8 @@ int __init dom0_construct_pv(struct doma
> >>          l1tab++;
> >>  
> >>          page = mfn_to_page(_mfn(mfn));
> >> -        if ( !page->u.inuse.type_info &&
> >> +        if ( (!page->u.inuse.type_info ||
> >> +              page->u.inuse.type_info == (PGT_writable_page | PGT_validated)) &&
> > 
> > Would it be clearer to get page for all pages that have a 0 count:
> > !(type_info & PGT_count_mask). Or would that interact badly with page
> > table pages?
> 
> Indeed this wouldn't work with page tables (and I recall having learned
> this the hard way): Prior to mark_pv_pt_pages_rdonly() they all have a
> type refcount of zero. Even if it wasn't for this, I'd prefer to not
> relax the condition here more than necessary.

Right. Page tables will have some types set but a count of 0.

> >> @@ -720,6 +795,17 @@ int __init dom0_construct_pv(struct doma
> >>      /* Pages that are part of page tables must be read only. */
> >>      mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
> >>  
> >> +    /*
> >> +     * This needs to come after all potentially excess
> >> +     * get_page_and_type(..., PGT_writable_page) invocations; see the loop a
> >> +     * few lines further up, where the effect of calling that function in an
> >> +     * earlier loop iteration may get overwritten by a later one.
> >> +     */
> >> +    if ( need_iommu_pt_sync(d) &&
> >> +         iommu_unmap(d, _dfn(PFN_DOWN(mpt_alloc) - nr_pt_pages), nr_pt_pages,
> >> +                     &flush_flags) )
> >> +        BUG();
> > 
> > Wouldn't such unmap better happen as part of changing the types of the
> > pages that become part of the guest page tables?
> 
> Not sure - it's a single call here, but would be a call per page when
> e.g. moved into mark_pv_pt_pages_rdonly().

I see. So this would result in multiple calls when moved, plus all the
involved page shattering and aggregation logic. Overall it would be
less error prone, as the iommu unmap would happen next to the type
change, but I'm not going to insist if you think it's not worth it.
The page table structure pages shouldn't be that many anyway?

> >> @@ -840,22 +928,41 @@ int __init dom0_construct_pv(struct doma
> >>  #endif
> >>      while ( pfn < nr_pages )
> >>      {
> >> -        if ( (page = alloc_chunk(d, nr_pages - domain_tot_pages(d))) == NULL )
> >> +        count = domain_tot_pages(d);
> >> +        if ( (page = alloc_chunk(d, nr_pages - count)) == NULL )
> >>              panic("Not enough RAM for DOM0 reservation\n");
> >> +        mfn = mfn_x(page_to_mfn(page));
> >> +
> >> +        if ( need_iommu_pt_sync(d) )
> >> +        {
> >> +            rc = iommu_map(d, _dfn(mfn), _mfn(mfn), domain_tot_pages(d) - count,
> >> +                           IOMMUF_readable | IOMMUF_writable, &flush_flags);
> >> +            if ( rc )
> >> +                printk(XENLOG_ERR
> >> +                       "pre-mapping MFN %lx (PFN %lx) into IOMMU failed: %d\n",
> >> +                       mfn, pfn, rc);
> >> +        }
> >> +
> >>          while ( pfn < domain_tot_pages(d) )
> >>          {
> >> -            mfn = mfn_x(page_to_mfn(page));
> >> +            if ( !rc )
> >> +                make_pages_writable(page, 1);
> > 
> > There's quite a lot of repetition of the pattern: allocate, iommu_map,
> > set as writable. Would it be possible to abstract this into some
> > kind of helper?
> > 
> > I've realized some of the allocations use alloc_chunk while others use
> > alloc_domheap_pages, so it might require some work.
> 
> Right, I'd leave the allocation part aside for the moment. I had actually
> considered to fold iommu_map() and make_pages_writable() into a common
> helper (or really rename make_pages_writable() and fold iommu_map() into
> there). What I lacked was a reasonable, not overly long name for such a
> function.

I'm not overly good at naming, but I think we need to somehow find a
way to place those together into a single helper.

I would be fine with naming this iommu_memory_{setup,add} or some
such. Marking the pages as writable is a result (or a requirement
might be a better way to express it?) of adding them to the IOMMU.
Would you be OK with one of those names?

> >> @@ -372,16 +372,30 @@ void __hwdom_init arch_iommu_hwdom_init(
> >>                                          perms & IOMMUF_writable ? p2m_access_rw
> >>                                                                  : p2m_access_r,
> >>                                          0);
> >> +        else if ( pfn != start + count || perms != start_perms )
> >> +        {
> >> +        commit:
> >> +            rc = iommu_map(d, _dfn(start), _mfn(start), count,
> >> +                           start_perms, &flush_flags);
> >> +            SWAP(start, pfn);
> >> +            start_perms = perms;
> >> +            count = 1;
> >> +        }
> >>          else
> >> -            rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> >> -                           perms, &flush_flags);
> >> +        {
> >> +            ++count;
> >> +            rc = 0;
> >> +        }
> >>  
> >>          if ( rc )
> >>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
> >>                     d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);
> > 
> > Would be nice to print the count (or end pfn) in case it's a range.
> 
> I can do so if you think it's worth further extra code. I can't use
> "count" here in particular, as that was updated already (in context
> above). The most reasonable change towards this would perhaps be to
> duplicate the printk() into both the "if()" and the "else if()" bodies.

Maybe. The current message gives the impression that a single pfn has
been added and failed, but without printing the range that failed the
message will not be that helpful in diagnosing further issues that
might arise due to the mapping failure.

> > While not something that you have to fix here, the logic here is
> > becoming overly complicated IMO. It might be easier to just put all
> > the ram and reserved regions (or everything < 4G) into a rangeset and
> > then punch holes on it for non guest mappable regions, and finally use
> > rangeset_consume_ranges to iterate and map those. That's likely faster
> > than having to iterate over all pfns on the system, and easier to
> > understand from a logic PoV.
> 
> Maybe; I didn't spend much time on figuring possible ways of
> consolidating some of this.

I can give it a try after your code is merged. I think it's getting a
bit messy.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:43:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:43:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243683.421589 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcQm-0002XL-B3; Fri, 10 Dec 2021 09:43:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243683.421589; Fri, 10 Dec 2021 09:43:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcQm-0002XE-7y; Fri, 10 Dec 2021 09:43:08 +0000
Received: by outflank-mailman (input) for mailman id 243683;
 Fri, 10 Dec 2021 09:43:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcQk-0002X7-V3
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:43:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 935db0e9-599d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:43:06 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2059.outbound.protection.outlook.com [104.47.1.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-23-mrnF4yHTOmCltdqw1w9VHw-1; Fri, 10 Dec 2021 10:43:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2704.eurprd04.prod.outlook.com (2603:10a6:800:b5::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 09:43:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:43:02 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0084.eurprd06.prod.outlook.com (2603:10a6:20b:464::6) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 09:43:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 935db0e9-599d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639129385;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SVKrgVODsMisA7hAdSfCVZF40vsXj/6vK8YDpjrtqLw=;
	b=bfBffmP5FreOaDvkO9EuSKp0TPeI8KZMLKjUVj45yvxTDy7pp4c7+JSVu5HfVJeC6nX+4U
	AGEy1OBXfM/yxJ8Bz9pqfstmncggVSNcOM/J5Z0ft+XPbcvcA3/3Ku+1GO21PUCO15Ua7L
	9c0nveQ8QOdrDb3HfJNBU2EFeCVJFBo=
X-MC-Unique: mrnF4yHTOmCltdqw1w9VHw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZZIJjmVQpvaUZH3h7nMCFjYMcHaUX/6ztmwaciT40EPzrAsSoKA+54ZzV7sRzEDI4wCq9P4ufXracpHEsU0VY6XyiJ5hkiGMzyMuNHN6nPXZyNOjhbU2nvy9A8M6DuyeTCBowBxzN2n5HKBWhUnecg4KluH/eFQPQwQm6upRWJZ/u2E2PKImfVQSfy6rlRvKRJ2oOpeFiIJ6q0RHvjxa7dqQA6jgdH72y6Y5K7LzGC7rkJVrGx7Bw3xgqAChggc4CgTmqPcTGrmQINPfxcvsdwds6XgvODi/85Gug8IhVtIVEaftXek9H5xJDPsI0q/Q8S5V1W7wA3sp0mrspb7TPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SVKrgVODsMisA7hAdSfCVZF40vsXj/6vK8YDpjrtqLw=;
 b=hoWFyrvavFdygNxkQuHCA+7XebhL61ldqNujUUaLIkkHaitcY11x/BTjXqZqS39WuqLRwEtB5MsE464pbLY8vR3Cwtaz4zunBSqrV+nqEZNnGsDbgtceDROOVHvYfP7tIIpUrkDLwjv5pemuh4krIQBif3iVPAs/PQt7mMKz19t752NMgJjLGWDgJ4XMva6hHGthtYKJe52n6q91/jI01kZQx5vuXT2+6YI4a6sHkj2l69EqPaluMKoAlZAM5qaOh9bzuzI39GGC0SxKEKurqnVBwhUMlvpg2PR2Z9MtPN0yY3GWqWFq2/HigXdk7sLrhzPte0194s7j8zHZ4PJo9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <828210f4-852b-22e3-e144-8a353fa4443c@suse.com>
Date: Fri, 10 Dec 2021 10:43:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Ping: [PATCH 0/3] x86: insn-fetch related emulation adjustments
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <paul@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
In-Reply-To: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0084.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ebfed82f-f535-4f9f-a6fc-08d9bbc17543
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2704:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB2704187445B62A1AAF29E03EB3719@VI1PR0402MB2704.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MtYlHyzeifB+S4wSpcZU8NgYUo8HKimregj1JOFRmyeKHbNelJVVjuh1hHRtIfQFRxeEO3Nc+VduAjtZjafIjtf5rgz1kOcE6rIK2y/qcypIvlmrFYPUqYjwFOXgnY6OHqB2jNq9Pn9vuWN77+oTyQpFxluTFmsk0x9sEJhR9Xiu6AD+81ZC3yAPQbxcOWohG2qxE9qwQaP5A4+g0osGzEPonRZ7+KxUIx5hyMJkKvFD7nsdYcfFSQ48DIPrdj859QHFtH+TEctiT4QmOgwwMcmihdckn/fQICre1ILEy5wBYILd7136K2m4qKbhcKHeMP+JiujbelRKl2GLHCZe7DAar0o9soGN6iGH7FyBKD/Ihl6PANZ9XlusaTrlwSMRJX5I5gfbzC7x+WWdi3jMVD1HaPFP/2Ctf01lP3MOpRNeByWcQiBGs/5ybh1MMrU36KKNnxEm3WufTRHw1azgsl+twPjKBNWuj5OyKfxh16y4nCzUWElyVrdduAgV/8QEB1voL+ABpTMDVkz2BoRaL1g9J8541O+XjB64bik3DVkw4G95xqbYqLHk2QoMSBj5bDHgBOAaWbhhFgkS3AWPHW3DKQArzYPGeRpE375FLB5VyirBk6cNltX8AhbbtNAXwcutXQoGVLrKzDQWI2SphtUDqu1KdVjQXz0S4tXNBUufd4rIxjLnsRmu3ip7MPwYK4OdWuoaOYQImuSRwpBadA3fFTeltg4T13IGhiJ11LqtOS8Qm6VwkZSfR6UUPQVh
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(53546011)(508600001)(8936002)(26005)(5660300002)(4744005)(2616005)(956004)(66946007)(8676002)(66556008)(186003)(4326008)(86362001)(31686004)(36756003)(66476007)(6916009)(38100700002)(2906002)(54906003)(316002)(16576012)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R1RQaU1EMWMxTjZIUFFLVlllcnFLZVlpRW9NdUVSRmxqOGhuK0xuZ3JKWS8z?=
 =?utf-8?B?V2d2K3laM0V3OFlDQ1NhQXpzWHFndnRlZ0pkMDdIczRucFA1eFVDVTBBZEc5?=
 =?utf-8?B?MElDcjN4U3J6ZlVCWldpamRNdDBvN3pjY0NETHZxdUMvb1oyUUMra1BFZGFJ?=
 =?utf-8?B?Q1NtSnBFSlh6TVZCeXFPNyswaEp6N3dVbFZwL3RyNTNYK2xxMG41Rm5JRm9V?=
 =?utf-8?B?dzhUUFlvZWkraTNUOFN6dkN4TzdhZzVqWGFxZm1MNXl0SG5odmlkUE43SDBL?=
 =?utf-8?B?Y0RaSnNUeTNReUhzenRrQmpvYzVsYTBzTjZFU1l0UWNJK28zNURGTUF2NkYz?=
 =?utf-8?B?dHluNW1QaEhuMjlwYXJRVW1scmx6MnVQQ0dMVVF6WSs1UUsxRnJoNUY5RU1a?=
 =?utf-8?B?VVRZZ1pXTmtzeEUyN2xqSjhNMmhuUGFMT2ZuNUYvaTR1RERYK2ZhL1dEV1hB?=
 =?utf-8?B?NkNLQ0xpT3p3REIvOVZLZ1Y2RFBhRHdaMllCYmwwRlN0Q2dDbVlHSTJTN3Fs?=
 =?utf-8?B?OFZxcTlLUlAzakg5VmMwRjJwbmRUdTBFeHNLTmVTOWV6SlZvbEdQZ200aFZ0?=
 =?utf-8?B?RnhWTDhES3BwOG5hMU03dFN2KytaOTRmQjg2TzFDYjhwL2tzQkhBUFBJUXZ1?=
 =?utf-8?B?dEg5WU9zVlA2alJkdVlxdXpFZ0J2eEhiWVkyeGVlR1ZyY0k0VzhUR3AwYTl2?=
 =?utf-8?B?QVB0VUlFRXRyYmprMHVWcjYvTGdNeVpTWHd2dUNkM0J3UTFSZWozRGtuNGFF?=
 =?utf-8?B?VStrSncwZlpOTTBEU0tnRkQ1dXQ2SEdmNTZpVG9BTjBrY3RodWtwcHIxS3Fq?=
 =?utf-8?B?aXZ4VHhTU1BpRmNaM0U5Z041aHdNWFpJS014N1MzcVlkWENtZHBqZWxPWFds?=
 =?utf-8?B?V3BSeFRodlpwb3ZRZ1lWYWFlU0dEb1ZEcURGcEVWM1MyR24yVERKRHlNaXlB?=
 =?utf-8?B?bVl2blY1WE9QSWtZNW5IOTZ4Vk9YQnR1RmVsTFhQckthUzN2L0QzV2xSUVRK?=
 =?utf-8?B?Wk5SMWZZSkEvYlp3bmltd29GL3ppZEhESldvd0xwRVFKL1kwOVlHeUdKZG02?=
 =?utf-8?B?MEJoenArbFo0N2lrMXpVMUZkb1RRWjF3MHZDL1JiSTRCNUtLZUVnS0NhTXdJ?=
 =?utf-8?B?Z3lNaUFLbzRXbGZYV3BTK2x6UkZrMzJ5Rkp2SUUyUVo0YVNiSmtoekM1bnlz?=
 =?utf-8?B?VTRseUJBWWJET0dPR3BhS0o3QkRxandtWGVtb2hzakdBNlRleE5BZlV1Z1pI?=
 =?utf-8?B?cTNQeVJNMXVGb0xiamh3SWJQS0dpd0dDMmNsdWpqT2FaNkZQaDlnNUZLOEZD?=
 =?utf-8?B?T1lXdllvM1I0b0FKdWdkNzFoR09va25xR2JnV2JPcnhTdzRpVCtJYldnT3Av?=
 =?utf-8?B?ZUMvMndxYjVudUFCYzliOFllU3B3OEMza1hIYWNUQWpLam9scm1nSk4vRkdB?=
 =?utf-8?B?N3dLK0h1V2g2dnYzc3lXRFBoL1dERVFDWHRMcitLNDBXYm9mTFJmWm9uVHlt?=
 =?utf-8?B?UWdqb2tsK3pmbVhhb0phM210Y1lsRDh1WHVvSXhIZ3lUd29mTFhBN2h4UzhV?=
 =?utf-8?B?ejVRWWdkNElSNGpRTzN6d1dkbzFOWTV6VEtJK0JOQ0hIQzBmUWtsdjdxQmEv?=
 =?utf-8?B?MzdUVHBZSm1EaC9IWkNIaUZ1b0tyTmZvcmdoejl6NkFiN0RiOURaUGhmWEE1?=
 =?utf-8?B?b2FQSGoxaW9OSWcrR29JN3lETC8zYXFaUTQyVER2WEFmdlZRdVM1aEYyb1B3?=
 =?utf-8?B?MDRyK2xxb1h1RjNza3J4REQ1RTl5MjRGOXBWRzR4SVBtMlBrcXVTSmxLNFRX?=
 =?utf-8?B?WE5aZzMrUVhtTENiSHE4Nm1VU1Z1ektSMzlsU1VGeFVESGxNRDA3SkROYkNn?=
 =?utf-8?B?ZkVpYTlnQXhreC85RFR5RVdTazQvQUh5SHg2OThEbEZQRXBKZ01pRzYwSS9v?=
 =?utf-8?B?RUpueHlaZEFGckVqM3gzN2V6VjJnQVZVUlNWSFY5bVVtd1psTkRSQ2dZZ0JC?=
 =?utf-8?B?TzVSYlppZDdiblVEOGs2c1FUMjFELzU4MWhNMjlKM0FZQk5HTzlxN1QyZG53?=
 =?utf-8?B?azNOdUdibmc0YXFUZkFDQWFXeVNIMG9tNisxZnN0UnFVYlJCK3BuM1VoeG1U?=
 =?utf-8?B?UjQwNloxUW1aQlJPOVR4NEtWVGlZbE4wdmVacXVOMXh1blZFU01FV3drQVZN?=
 =?utf-8?Q?HOjGT7bY41yaRXRt6kLW1GQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebfed82f-f535-4f9f-a6fc-08d9bbc17543
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:43:02.2484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L4Ukk71RWOfx5QCv6WZEP0OYVm6jMzYffKCINaPNJcPOqjEa5L/YJ2Gahk5katm5qWwsLm3B9Xwb9ncS13X3mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2704

Paul,

On 03.12.2021 12:18, Jan Beulich wrote:
> Two fixes and some tidying.
> 
> 1: HVM: permit CLFLUSH{,OPT} on execute-only code segments
> 2: HVM: fail virt-to-linear conversion for insn fetches from non-code segments
> 3: emul: drop "seg" parameter from insn_fetch() hook

may I please ask for an ack or otherwise on patches 1 and 3 here?

Thanks, Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:45:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:45:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243688.421599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcTD-0003AU-PL; Fri, 10 Dec 2021 09:45:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243688.421599; Fri, 10 Dec 2021 09:45:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcTD-0003AN-MG; Fri, 10 Dec 2021 09:45:39 +0000
Received: by outflank-mailman (input) for mailman id 243688;
 Fri, 10 Dec 2021 09:45:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvcTC-0003AH-H6
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:45:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed812434-599d-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 10:45:37 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-9YuU4PszPNOjbZdaQiYqQw-1; Fri, 10 Dec 2021 10:44:34 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 09:44:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 09:44:30 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS8P189CA0009.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::19) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 09:44:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed812434-599d-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639129537;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=V6ZVvdHpKOBQ0B2guTFtvy5s9m0PX1YMTarGqu6D8AQ=;
	b=JNXz3ajdDHAV9tT8vkEsdVTH16TTMKE4XYu4higH86vHkVeQyp/Nr8VKubG/sEb5UpgK44
	pW9aK6AR2ml96xzzT8Pd8ll7Bg3BhFtKb/oVOYFTC0kBq34uCq5pG2XVLW56a1gMTsT3m0
	156fVDzQVBlpCQ6jRGni0mHMwCYa4uA=
X-MC-Unique: 9YuU4PszPNOjbZdaQiYqQw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NKoq8INNo0hUNuI8tf3DRE3KocFc1nCNI509CQcZoYtly3pRPvB1T+bunbl/14pfLmmHFmr7kjS6H+KwaTXdAV/y7b7KyoUrGKp5UqfLjVmoA8tWzzDUHXWsvF+6CsgEma7TdwuWDD/RAbKYehVJnCJzUJAdiCIvJvunBorxW+nsZ1r9pUzegRiKW0DAaTer2OUFVYgN66s07ilIOpS1SDgTz+HzNmM4sguML3levHDNPrftEfScjx0eQCPaQPPICF25PF/BHubsbrumMrDS/ksk+aqpS0VXfhqqFWKNTlgOG8nNPce797Mqs8MMHnVebed3bO4qLvcJl/yjJarx8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V6ZVvdHpKOBQ0B2guTFtvy5s9m0PX1YMTarGqu6D8AQ=;
 b=SdOfxe7afJt4NW2aCtJVsIRdK+cckQ4K3jCS7zRwuBihYbTOCIsVk9SsxvqXo58svCFrTv/5hs4z4G0J1flQ8K6FSTpPigYJwm1jY/yZDmNWBy1riFUOckYozzvP5rRu+mhPgm28RoqL/jI6YN1A6HLsX8l5z/aRnAsXDSgEa9xGzktMMlB0SthL9FMykS1cxNLfOTHHlJYGljq7L5nlVKYwwXMZddzVCcIFEZ1fbOBsUMR2Tv4YK10C+EoCGV64dg3RH3SkQsjpLBd4UlndKiAV7AZc4yUBTRuItbDfqQs5wfymU32WpW6s3FPuwiPb/X2FpjK6CBPvasFZJuCvXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <850a3be8-0e84-3bb3-150b-42a6a3a0c7ef@suse.com>
Date: Fri, 10 Dec 2021 10:44:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Ping: [PATCH 2/3] EFI: constify EFI_LOADED_IMAGE * function
 parameters
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
In-Reply-To: <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0009.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 24ca0db1-571f-4db9-228a-08d9bbc1a9fb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5166:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51660D8523F8DF237DF675C5B3719@VI1PR04MB5166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iaVzgZcCQuHsbnuOIbVSgUHQovlmsy1N9bkoDWRkEMbQIQohXxVJnMZHnGSvQazwvX9XUsfHfGOu0OSRtq8qakcIAwHT9I/91rcNwpiICjDM/ZIB80sOgWIt4C7TEserIh/v7frolxCJDdQuE6MW73+HtAVl2PgTaKVmZeshYl8bMitjdDj+ylDUCXQBvRhuUK/mcZPAZLUrJZTVPrPf8HiVCzT7/VL5/Ex7MZPFSondnDzZ14omLR0e1WG4bndjjr3lhFDkqRV7bJ+6dza53ilV2xw/bLAO0BFsiWaqbgly8mdCH8o8EvYoeYAYW8ddhkYrGwuw2osUo+bx7ncNXVrdLWbcVcGfr1mwHUMnJ0oJ1J3+y+ieBJGeh9IYpS1d4x2jKoaUraptI3fKtISvpImhXtM6f5HXdqiBo+JG6diJ0yJYf+bA3UgQL5cuplVIlRGBM8hDW3cFyWu3o9qQR7gnMe/UCPij8l1fl0F4Aic6J5RRBSYYjUkU3jm+mKsWVGPcQCe2v4MmMIv3KXRwbwJa495+HQf3TO52WSDkOdXW5ieyGNPPjsx4jkB1tBxgFljyetPr9N0rqLgZ/9Jw2atGMUtFHTR8P+ClBSZTlg9YNWQy6y1ecruvOiwjLRCmyzrrgYx37HFN3WApOwZ4U0VfTkFCOaAADK+bYOGGW+XoHsxZF5mh58qdLYYURYicKYAo87oIj94rNtLOK2GvDZSI2pDEVytYtJrlWlffri4A7YVlQ+PH2mLXScgMzBXu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(31686004)(5660300002)(66946007)(4326008)(508600001)(38100700002)(66476007)(6486002)(86362001)(956004)(2616005)(53546011)(54906003)(110136005)(186003)(83380400001)(31696002)(316002)(16576012)(4744005)(26005)(2906002)(8676002)(36756003)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZFFLZnY1eEQzK0lwT0FmMmdnRkFLL3k1bVRRKzRoMDA2akJKaElDem1pN0dy?=
 =?utf-8?B?QmVHajRnUFlWTXQvbDV5TmI3YlhNM0tMSDJndzBaTHhWTFFpY214S3RibmVa?=
 =?utf-8?B?ZWxOcXBBSW1xKzNjVmNpR2xjNVp5ZXQwK2hydVFkWkZSWUhlRDFqbFBEZmIv?=
 =?utf-8?B?TFV6VXFyamFvWWZpWkgyNkVIRGYyUlRvdUdpanRxUGJqd2RXNEh1ZE8zT2xE?=
 =?utf-8?B?eFRBUmdwSjMxNzl3cjRwU255RXFuZUVDcXE1OVp1dTNDVUJJdU50alhHOUND?=
 =?utf-8?B?Y250WE1qak05ZHJObkM3MUEvdkNRKzhUWWNKZzYrOURZWWUvdnJCYy85TFdY?=
 =?utf-8?B?UjZPdlFkVmdnRWI1bEdtR2I4VmhnemFVbnBMSkk2akpROEUxQ1ByODNhenVi?=
 =?utf-8?B?ejlVb0JQL1RrZm5qeEt6M3Y5R3JsV21iUWxYSXF2ZlBDVVFNSmNpeWlkckxp?=
 =?utf-8?B?NTQ2MHdWWERCR0hJTW9MMlFzMitLUmxyQjZQUmx4dFU2eDlyQlh1Wlg1UFhS?=
 =?utf-8?B?K3d5dWpxUTVKSit5Qlk2UC9hWnB0Yk9YVGRWejNNcmk0WDZtdGVKQVlsQkda?=
 =?utf-8?B?Mzd5ajVJTjMwZHpQKys2K3dvcVdrdHVhVSt2NUNabmN4RFdPaWsyTzQwZk9U?=
 =?utf-8?B?MnNuYzYyNDhpM2R4RWwrYVZnZUpBS2FFTk5vYU5STG5mSXJaTDZlUkNhWXF2?=
 =?utf-8?B?SHFycDY0dEplWGRJell6dG13RlhMMFpOVHhGdDhRb0IzaTBtWUU1UGVzM2oy?=
 =?utf-8?B?T2pxOEJ6TjcyalhINHpjS2xYTkVSVWJ3TXMzL2E5SUhuYlZhWlo2WDRwbmp2?=
 =?utf-8?B?TUV3RDlJV0J5dGhTYk56Tm9VbE0zZXhUb1A5Y2hMejNLeWhBU1orWStxVHhu?=
 =?utf-8?B?QXVsQkxVR2Y5cXpZN3pVS3hPc045UzM5Q2poeHoreG9XRE5MbE8xcmtnWWpx?=
 =?utf-8?B?aVRqdUtXZUFtZnN1SjkvL0tCM012c0ZqSUE4cTg1enhuRi92eURmSHZCODJi?=
 =?utf-8?B?N1hycGhiaFNVbkhNTUZpYjJ5UEttT05IbzhPVFdLUldLcGdGSXpSS0pGajFP?=
 =?utf-8?B?UTBkR1NIR2MzcUZhTUplNnpsdHkwcEJnd1J4Mi9iQkkxK1FLaFdVejhGN3py?=
 =?utf-8?B?TUZMWjJKbUNDZnM0VUdmT0Fka2VNZXpDNDdPUUkrY3I4YmpYRDRHR3AwSDFr?=
 =?utf-8?B?dkl4S2VoVjZqTEhNSmF1S1QyN0ZyMkdDN25SWmVXUkNBWE5tSGF1MUYxeTly?=
 =?utf-8?B?Mm5qR1Y0bG9rT00ydFdaUlJyUUhnbWdQN3dxY1NoeUdncGx5azNyc0V2N1hn?=
 =?utf-8?B?RHpscE1DRU45WnJZOHNnaUxSQWpvMEVZNjVHbExuTG1BcHRZRmNrQ1VsZ24y?=
 =?utf-8?B?aTZvMDNZQ2dEQk9STHcrQWpYazk4alg3dE5xbFpyVWdCckNwRWkrdC9NRmha?=
 =?utf-8?B?SmJ3b3JhbVZNeURKS2V0MkRVbHRuL2l6K0poazN2QmxDd0ZhUHovN1Z1b0Uv?=
 =?utf-8?B?Ry9YTEUvTlI4ZXN3T0hwSUs4SW82a0syVnZjTHJ2SW5FSjc2aERCSDdTZHFs?=
 =?utf-8?B?V3YyNHI3NlpIOVVmeUl6YWtqYW9SZFpLZjAvTVhubFZFOFFmam0rUmxIei9C?=
 =?utf-8?B?MEYrYkFkd0tOemtDMGNBMlQ0dmJaMVgvRXBiNkZFaHpPeG5WTWh3c20xbDUw?=
 =?utf-8?B?YjQ0RGxiT0l3R2NPNWpueDhQU2t4bFRNa00zMUl5MzZGOEFRajcwQzJzWXFG?=
 =?utf-8?B?WlJLSEN4b01vaWJBZU94bnZtVS9xWFB3aGxOV01xT1ovVGpGL0U3VGpPaFAw?=
 =?utf-8?B?eWl3cE5sTjFERk1TR0hjbW1VSUZkZ0NkY2MzV1l2bFFWalhpL3h5Q01mNmJk?=
 =?utf-8?B?bGFIbjVHTml2R0EvSlRuaG84eDJobVJZY28xN3pLTWM5TzFTcWYyOHZkbHNB?=
 =?utf-8?B?QVdlMTQ4ZnNiT1dqWlc1YnBONStuSlRtRGRscDhOMnpHRmltMFZMWTRQdm9w?=
 =?utf-8?B?UVlpMm5icjQ3VWhBQlVTYVp0L0MxSU1oOTBQNVhreHJCTzdJS2Q1UGUzL2pL?=
 =?utf-8?B?TXJoSFNjVTFFUmVaTXV6SXNUWEowemxSU3lJcnFNTkFhUG05ZUc2SXA4cWRa?=
 =?utf-8?B?Q25tanRab2MvdUwwQ1MxaThuMTNldUVsbTRBQ0d6QVhxNFZZdWpRbDdIWGtj?=
 =?utf-8?Q?EbxzHYX8iWRv7I7T5skFPzg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24ca0db1-571f-4db9-228a-08d9bbc1a9fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 09:44:30.8323
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e9CtYlMYH6OyPks0fulcVC0I5tjD8GhuzlwT318quzInt/B6kGZt2ugG6pEmHy8YeFmXMdgBYy5OTm9H/I7JdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166

On 03.12.2021 11:57, Jan Beulich wrote:
> Instead of altering Arm's forward declarations, drop them. Like
> elsewhere we should limit such to cases where the first use lives ahead
> of the definition.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

May I please ask for an Arm side ack (or otherwise) here?

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:51:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:51:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243698.421625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcYy-0005Un-Tz; Fri, 10 Dec 2021 09:51:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243698.421625; Fri, 10 Dec 2021 09:51:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcYy-0005Ug-QO; Fri, 10 Dec 2021 09:51:36 +0000
Received: by outflank-mailman (input) for mailman id 243698;
 Fri, 10 Dec 2021 09:51:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lrZX=Q3=epam.com=prvs=297895717b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mvcYw-0005R3-7Y
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 09:51:34 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c03fb2cf-599e-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 10:51:31 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BA9O1So025627;
 Fri, 10 Dec 2021 09:51:21 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cv47ur2pe-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 10 Dec 2021 09:51:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3471.eurprd03.prod.outlook.com (2603:10a6:803:1d::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 09:51:18 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.014; Fri, 10 Dec 2021
 09:51:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c03fb2cf-599e-11ec-9d12-4777fae47e2b
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nDnDdxqN4cR9DMsyY3feAV/2btdfq5UWvzuoCWDNLOThfy8oSpyk316bxWnpiBpYyPcUjtj9r1WPOWC1mFuAW6EGBbHxyPKxSL2CRhXigjzqIGJwIc7+jPVgULYojJ6VJydLTfXwtJ5/VVOzBL6Ldm2f8+UKj97b0VdsMrj2CAnbaWwPfdIMAO2CQCruNyKp5Ri4SQ2jamjj2I7DXaRB5Aor0YSdcCkt+bkdnK9kHi5+v6tZY4PU/f91Nwoz73EUW3SI/vV85FRC8JuoK2wRdlpbOf44Iq3XTSYJv5m/riR4yxt+KORysW0442RgLbLXwr3bnf9FsF/WYvsfuDhWEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0YtyXVaVmQsTw/9U7GMIY9aU7kDAx9AnDBuOHanfe3E=;
 b=WM8NAzmDDiWjP6gPh0XjIaxnZNbRIvyAIR5lSZrAwrVuXrmdP+UcZVkgxOITRipzCfek/CHmThK63dTxvTD4h439uDwAGRJJk01mUJSETVlR8LcTMjvq51wfD1yiuAIIsGYPH0nEF/zicgnsLRax9nmXXkp7Oq1Qmj+Re04MQWBlSnoMt/MJr0/0NHb4oJyeXOt/7t7CebmXNnV4y3K+7MUdUKdyV2jtlS08TxpWZZvHMOXWP2DWLhRVVp7c3R+BVR/udfKohGxUeEIIepKczWOE859KEjF8kC6FzFYyaAJ9Ixvg4EaSFzLJ5cZzz3qJ1EChsMqE07Ak1T2Ma7m6yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=0YtyXVaVmQsTw/9U7GMIY9aU7kDAx9AnDBuOHanfe3E=;
 b=Udh74XjkUYAkUnj9WPg+uTrwuM/gBqbkZuxK0BcBv9NRKR7KjHuXP81rXblHN/eK8mQjsBzEaTp+FbqobiWHdG3WQYqnejC6kHfMlKerCT0UztnPwSGsRrVasCdJFmWSVIOvtLpxsrSq3VYTNkcbvlyKAQE8vl86bI/GjhefFKabQynyoYxFCeSqPJM1yqEtBCkAIxFGOqsDFWJ4MlP9d/bLrQBnpuRpPMOOBR5jR3RrAdRpnmQaQk7lRJbTYoyWj75OS/Kmr93dhRlAl92Z+r6D1AAnP3JWzNGqqwJT5t85kTkj9BuhYAutoHBpG2EhYG/d6dvsAvaeNwnMhfMrfw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Julien Grall <julien@xen.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 1/2] mm: introduce INVALID_{G,M}FN_RAW
Thread-Topic: [PATCH v2 1/2] mm: introduce INVALID_{G,M}FN_RAW
Thread-Index: AQHX7at6tuMQwcb1JUe4VSclhAZuZg==
Date: Fri, 10 Dec 2021 09:51:18 +0000
Message-ID: <fc16b259-7c5b-6aca-bb2d-a8d44e9d3c64@epam.com>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
 <6d2d29ca-0495-5029-afc8-7248f462db06@suse.com>
In-Reply-To: <6d2d29ca-0495-5029-afc8-7248f462db06@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2fe04911-6d13-423a-0e08-08d9bbc29d2e
x-ms-traffictypediagnostic: VI1PR0302MB3471:EE_
x-microsoft-antispam-prvs: 
 <VI1PR0302MB3471B014711C5EFCD161574DE7719@VI1PR0302MB3471.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3826;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 IO29z9hrL/1O3VhA2Efis5QxCMt1RcIczgeeAbGKuJQBkATt9nCH47OMCfzdA5hAEiDqSK68La5DCQ6OaW3YSc/K9TZGja28RHouVSXO6BN6kywEzoYaywEYu9wwWBr1JifUvlIe297mPRA07WWHnmFDhmlAMlqVM/034saFRtsRO5qK6dqpff4L2DMvqEuc49g8Y+gM/J4aFMHkSkxkLPAeK5ZP/PaHlzjM9AyIBKtoQOww31JYMr+S77OMBmT+x+gj+T4Qs92FpaSem/F4VX6wHpbjeWyRulZW8rN9dxLVZLfcCVgfACLd1dUgu2gDH7dfU1vwwHmmawrBC7+KgategCWZU0nmlJ+VX3S0w1DKJZSeQkhGMkn8hBNiXy8zAlywX9j/gHTPA7frFO5MFouBYkUHtLPErPKSKG4G1+32QhTZxLbx8dPClKWxGfXIH4oDAWhi71Goue4XvxNRg4ylm7XeVkZ6CDv3jFC80+aQfM5PkkRPyMTXmWJ50N2tUFJwIHNru38d8yh9HKkCyQaXeviekZ6OptHQloQIJwSEeYV48hod79Yxih1LqN/LcOexXMX++fCqrC5Zj7G2unE0X8XJ5wS8qo1uLqAZ8Pw9A1noTjqxHEUWvSra3JrtjT9Ol4sBi0T3w2HoqrfHWA713syg6aJ4s+XmKxOVzbXw+/ET0u3ARtUd4assegFF2iCZZIJ75BNwPnlNUNqtsqMhNaMK2nuLr94XfJLZJx+5iWj3ZVVY234THGQp10fbcTp68WV2o5frHSCJIZrqaIhmJVf5BFMz1nNrAJF7gt6OhBeUQ/heoK+ulDRiH4s/IEO2JwvNFDnyOvJ96FR8JQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(966005)(6506007)(53546011)(55236004)(71200400001)(38070700005)(508600001)(26005)(8936002)(5660300002)(2616005)(91956017)(76116006)(66946007)(66476007)(64756008)(8676002)(66556008)(186003)(4326008)(86362001)(31686004)(36756003)(38100700002)(54906003)(2906002)(110136005)(316002)(6486002)(6512007)(122000001)(66446008)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?ejN6cFBXVGN2THd5MXFCR2VzMWN1aDA3QmVVT1hzbnRCV0xmTVZxK3kycWll?=
 =?utf-8?B?OXdvZ1JYcjJOSlMvZGQyVE1kMFI5cUlIbllnWFp0K3Y4SDYvaDRVbkxSOVlm?=
 =?utf-8?B?YjlNYk9YYkZYcE9ENjhRWVVvSFh2Y0k1NkhzcWhEMDlVMHNhRitvRXROaG9y?=
 =?utf-8?B?Ky81LzdsOEpXUkZTeStuSnBaOGhrVm9MWkZwcmdoYURXSnBYVVhJVXduT2N3?=
 =?utf-8?B?bEZROGdGVjVvTmRONnJOcVJ2ZDdwbFkxZHpFeDcwR2hNSFJvVTVzdDF1eFlQ?=
 =?utf-8?B?dnlUY05SQXRwU3k1NG54ckVxUlBJQ3B2dXZUWUhCK055YmQ5WkVaWlYzdVEr?=
 =?utf-8?B?V2pEeHc5aTJ2WDd0ZGsrVFJ3QUd0MGYza3lOKzhNVW1UeXE1UU50R0s0QXdO?=
 =?utf-8?B?dnkrakJ1cjZWbkp0Zjk2aWdDSlBjdUpFYVlIbWhWbCtsUGdya0JDS0NaY2E0?=
 =?utf-8?B?RXRCTWFtajhUMzdrcmY0QkY1RDJVZlJwNVljdStIb1pzbjZHT2wyOGFydCtY?=
 =?utf-8?B?RGF3SStTZ3I4THdGK1NyZU15OGpxcWc2clRyeGlRUXNsV0FuN3E0Mm1Ja0FG?=
 =?utf-8?B?NGdkSlJsRjBUK2h0ejVlVm5BZmlrQjBBL3dCbzBpSzBQdXViZ0VwTjNlaFBn?=
 =?utf-8?B?VmVjdnN2R2pPbm9GWUtpWFRJSDc0RXRKUUdJVkxVQUp3NmlxZENaN29laTRv?=
 =?utf-8?B?YVNaNHM4ZmN5UFBqMjVUWmdPSGNUK0dUUlZIaUl3T21qbUZRVFRLTTZ3RVJV?=
 =?utf-8?B?SFhPRnR0c0dvQjBWbHhoSWJKTlhvLzZGbHRYbENOUnFTVllkQU1xSGtyaVNQ?=
 =?utf-8?B?QnlUOUhwQ0l6Tys2cEFaSVdtVWUyeUg4UmI1T2lCN0RMdExqRytvR3JDdXp5?=
 =?utf-8?B?MjAzcXVvaGxHUTZIdmhJb1RtSUNZYzZGVFl4QnNTUDl1SXBxTHRJMktHeFRZ?=
 =?utf-8?B?UFlyZ3lLdXJTOUY5VElNU0M3ZTArc1BIT29Tbk1uWVZCTWVSWU5ZMEdCR0hL?=
 =?utf-8?B?azVUbEJKRVlqdStTaWxBb2pFUU84eWlaTERuMUFWc1IxblI0c0dibXYvcVVY?=
 =?utf-8?B?ek1PakdnZlNKTU0rNERrUGdrdVNKeUNESVZUY0s3SHQ2aDRUek56bU4rS1Bs?=
 =?utf-8?B?S1JTY1NPNDI1TUQyVnhKcTEzbE5nRGlZUVRkS3F4anoxMlBpRTQ4elBEYVFM?=
 =?utf-8?B?NkdWbmJkMldQREU0SUQ2bGF1UEJmaUtyd05SZmFGSjVJWHJ4bDlEN0luVmZx?=
 =?utf-8?B?QlhRa2hPMXVHdGtheGFUenBBeDAxZ0ZwajE2aVRYeG12c2w1Ymo1WE5QVUtC?=
 =?utf-8?B?T1hJYnVyN0xaSmFqdmFCZUNSU3NJOXV0cXFJbHpJTlpZcHJYWmdla3QyRlVh?=
 =?utf-8?B?NXJXOFcydkZSRElud09laG9KbTZ5MzNOTWJxNElPKzZmc0h5WHlMRGIxOEVN?=
 =?utf-8?B?eTJHTjFnQTFjekJFckpZUjJ2SWV0S3duZXYzWDI2aVRtWjE1ODRRT1ROZDdH?=
 =?utf-8?B?OFRHcE5EYkRLNUhQdFFpcjMxY1RRUXVwWThKMTBvT2U3aURRUUNzbjNOMHFJ?=
 =?utf-8?B?SWZOcVAxUkw0T2lDeU03cndQMlB6VXBCZzlpWURHdDJvNjE4cGpXZk85aXlr?=
 =?utf-8?B?SHBWRDh2cHBPNnYwUmh5VHB6NStidHVKYkZ0cUVEUEhnZ2R3czlzYWI3SktN?=
 =?utf-8?B?Slo1VmFJQXRyMitTcUNjTW5MVnA5Q2NjQXV2ajF4dEswTEZSOXhRbTEwSkpV?=
 =?utf-8?B?Qyt5VlY2KzhVcFVWTERhZzErbnJyZHlnYjdDQWNBeGNhaWx4QWE3cWRNRTdo?=
 =?utf-8?B?dWtla0NaN0ZhRm5KUU93ZEd1aXNaYzd1YjFEajdKaHZaMHh6S3BreFdnbmdC?=
 =?utf-8?B?bWxXMGVQMHNaRUVOMnp0QnlmWFBvcHBpZzBvU3dRMUFDR1FGMXJ6Wk1IcEpm?=
 =?utf-8?B?VUh5bDNyQ25UVm1rNEtWZ0hhVWNoUmZ0UHc5NG1DZ0lmNkNQRGxBazlQZDhD?=
 =?utf-8?B?OTRpRmEvVW5TTzdOS1ZxL29kSXRCY09FWlFRRGFNZi9EcklaRVRkajNaaXA5?=
 =?utf-8?B?dUZBeEtqaFlTdmpZVEoyWVYrczZuQTZYcTV5STZaUnIvL29Va3BTK2lUTFpE?=
 =?utf-8?B?L2FaT3B2M2hNeE51ellOc24xOVgzd3FVN0oxNkZDUWpHRDhsOEk2cVpuTk85?=
 =?utf-8?B?SmFLQ2poR2JwZjJxdndieW5Vb0FYSU0xQkRSc21VQ21lSTdMRnRlSGtzM0Jq?=
 =?utf-8?B?d2hjMnN5YWFvZy94VzZzeVRTdVlDNTdwaFQ3VVZMQ2VRSkVBL2l0VktGcWtr?=
 =?utf-8?B?cHFDbWEwVFdlRXNqZWpLUitRbHkyaFFJWENtWU9sb2pEN0RMQncxdz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <9C1F01DEC2632F4CA641A9CF87E6871F@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe04911-6d13-423a-0e08-08d9bbc29d2e
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2021 09:51:18.3789
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JshD0NZZo8veglFPR2shNeTtWVZYEuLBKsSBdpTwBCMx0a3Do2P9TnOPWHW7UjncR2kkbba/s8UD7xd5Jub1EF7PiMCs1ymKzq31VtniCmJ+FRT6c9kCmvpwcn3XpuI7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3471
X-Proofpoint-ORIG-GUID: -CrPGnd5cgVB5BESqgHIiT4f5CAd7ML-
X-Proofpoint-GUID: -CrPGnd5cgVB5BESqgHIiT4f5CAd7ML-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-10_03,2021-12-08_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 mlxscore=0
 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0
 mlxlogscore=938 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112100053

SGksIEphbiENCg0KT24gMTAuMTIuMjEgMTE6MzksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBUaGlz
IGFsbG93cyBwcm9wZXJseSB0eWluZyB0b2dldGhlciBJTlZBTElEX3tHLE19Rk4gYW5kDQo+IElO
VkFMSURfe0csTX1GTl9JTklUSUFMSVpFUiBhcyB3ZWxsIGFzIHVzaW5nIHRoZSBhY3R1YWwgdmFs
dWVzIGluDQo+IGNvbXBpbGUgdGltZSBjb25zdGFudCBleHByZXNzaW9ucyAob3IgZXZlbiBwcmVw
cm9jZXNzb3IgZGlyY3RpdmVzKS4NCnMvZGlyY3RpdmVzL2RpcmVjdGl2ZXMNCj4NCj4gU2luY2Ug
SU5WQUxJRF9QRk4gaXMgdW51c2VkLCBhbmQgd2l0aCB4ODYnZXMgcGFnaW5nX21hcmtfcGZuX2Rp
cnR5KCkNCj4gYmVpbmcgdGhlIG9ubHkgdXNlciBvZiBwZm5fdCBpdCBhbHNvIGRvZXNuJ3Qgc2Vl
bSBsaWtlbHkgdGhhdCBuZXcgdXNlcw0KPiB3b3VsZCBhcHBlYXIsIHJlbW92ZSB0aGF0IG9uZSBh
dCB0aGlzIHNhbWUgb2NjYXNpb24uDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxq
YmV1bGljaEBzdXNlLmNvbT4NCldpdGggdGhlIGFib3ZlIG5pdCBmaXhlZDoNClJldmlld2VkLWJ5
OiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5j
b20+DQo+IC0tLQ0KPiB2MjogTmV3Lg0KPg0KPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vbW0tZnJh
bWUuaA0KPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vbW0tZnJhbWUuaA0KPiBAQCAtNiwxMiArNiwx
MyBAQA0KPiAgIA0KPiAgIFRZUEVfU0FGRSh1bnNpZ25lZCBsb25nLCBtZm4pOw0KPiAgICNkZWZp
bmUgUFJJX21mbiAgICAgICAgICAiMDVseCINCj4gLSNkZWZpbmUgSU5WQUxJRF9NRk4gICAgICBf
bWZuKH4wVUwpDQo+ICsjZGVmaW5lIElOVkFMSURfTUZOX1JBVyAgKH4wVUwpDQo+ICsjZGVmaW5l
IElOVkFMSURfTUZOICAgICAgX21mbihJTlZBTElEX01GTl9SQVcpDQo+ICAgLyoNCj4gICAgKiBU
byBiZSB1c2VkIGZvciBnbG9iYWwgdmFyaWFibGUgaW5pdGlhbGl6YXRpb24uIFRoaXMgd29ya2Fy
b3VuZCBhIGJ1Zw0KPiAgICAqIGluIEdDQyA8IDUuMC4NCj4gICAgKi8NCj4gLSNkZWZpbmUgSU5W
QUxJRF9NRk5fSU5JVElBTElaRVIgeyB+MFVMIH0NCj4gKyNkZWZpbmUgSU5WQUxJRF9NRk5fSU5J
VElBTElaRVIgeyBJTlZBTElEX01GTl9SQVcgfQ0KPiAgIA0KPiAgICNpZm5kZWYgbWZuX3QNCj4g
ICAjZGVmaW5lIG1mbl90IC8qIEdyZXAgZm9kZGVyOiBtZm5fdCwgX21mbigpIGFuZCBtZm5feCgp
IGFyZSBkZWZpbmVkIGFib3ZlICovDQo+IEBAIC00NCwxMiArNDUsMTMgQEAgc3RhdGljIGlubGlu
ZSBib29sX3QgbWZuX2VxKG1mbl90IHgsIG1mbg0KPiAgIA0KPiAgIFRZUEVfU0FGRSh1bnNpZ25l
ZCBsb25nLCBnZm4pOw0KPiAgICNkZWZpbmUgUFJJX2dmbiAgICAgICAgICAiMDVseCINCj4gLSNk
ZWZpbmUgSU5WQUxJRF9HRk4gICAgICBfZ2ZuKH4wVUwpDQo+ICsjZGVmaW5lIElOVkFMSURfR0ZO
X1JBVyAgKH4wVUwpDQo+ICsjZGVmaW5lIElOVkFMSURfR0ZOICAgICAgX2dmbihJTlZBTElEX0dG
Tl9SQVcpDQo+ICAgLyoNCj4gICAgKiBUbyBiZSB1c2VkIGZvciBnbG9iYWwgdmFyaWFibGUgaW5p
dGlhbGl6YXRpb24uIFRoaXMgd29ya2Fyb3VuZCBhIGJ1Zw0KPiAgICAqIGluIEdDQyA8IDUuMCBo
dHRwczovL2djYy5nbnUub3JnL2J1Z3ppbGxhL3Nob3dfYnVnLmNnaT9pZD02NDg1Ng0KPiAgICAq
Lw0KPiAtI2RlZmluZSBJTlZBTElEX0dGTl9JTklUSUFMSVpFUiB7IH4wVUwgfQ0KPiArI2RlZmlu
ZSBJTlZBTElEX0dGTl9JTklUSUFMSVpFUiB7IElOVkFMSURfR0ZOX1JBVyB9DQo+ICAgDQo+ICAg
I2lmbmRlZiBnZm5fdA0KPiAgICNkZWZpbmUgZ2ZuX3QgLyogR3JlcCBmb2RkZXI6IGdmbl90LCBf
Z2ZuKCkgYW5kIGdmbl94KCkgYXJlIGRlZmluZWQgYWJvdmUgKi8NCj4gQEAgLTgyLDcgKzg0LDYg
QEAgc3RhdGljIGlubGluZSBib29sX3QgZ2ZuX2VxKGdmbl90IHgsIGdmbg0KPiAgIA0KPiAgIFRZ
UEVfU0FGRSh1bnNpZ25lZCBsb25nLCBwZm4pOw0KPiAgICNkZWZpbmUgUFJJX3BmbiAgICAgICAg
ICAiMDVseCINCj4gLSNkZWZpbmUgSU5WQUxJRF9QRk4gICAgICAofjBVTCkNCj4gICANCj4gICAj
aWZuZGVmIHBmbl90DQo+ICAgI2RlZmluZSBwZm5fdCAvKiBHcmVwIGZvZGRlcjogcGZuX3QsIF9w
Zm4oKSBhbmQgcGZuX3goKSBhcmUgZGVmaW5lZCBhYm92ZSAqLw0KPg0KPg0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:51:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:51:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243696.421611 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcYu-0005DH-Hm; Fri, 10 Dec 2021 09:51:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243696.421611; Fri, 10 Dec 2021 09:51:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcYu-0005DA-EP; Fri, 10 Dec 2021 09:51:32 +0000
Received: by outflank-mailman (input) for mailman id 243696;
 Fri, 10 Dec 2021 09:51:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcYs-0005D0-Qp; Fri, 10 Dec 2021 09:51:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcYs-0002UT-LC; Fri, 10 Dec 2021 09:51:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcYs-0004vF-A3; Fri, 10 Dec 2021 09:51:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcYs-0006qo-9a; Fri, 10 Dec 2021 09:51:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZkDwK6JIk87TOcl1wZB6HpmYRU/2OcnRW/TRhzNuoUo=; b=rMlSMi8YjbKTkSs3whNnZJfpBw
	cCbr/CoYXsLQE2EqpZ9VpkxHnypllRedaayFX0Kcva2fe4hZLgHARywKAd0VGAIks+mOTeJANdL4a
	3GUGO5f7l2MnHQwLHPcW5EY++YreC+3QqQjZDzTYehYvt/1DmMIIRJiw7vwb8gioCVLE=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167312-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167312: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
X-Osstest-Versions-That:
    xen=c62d634cce8b1507d00a61bfc8168ac42367fe87
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 09:51:30 +0000

flight 167312 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167312/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     18 guest-localmigrate       fail REGR. vs. 167241

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167241
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167241
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167241
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167241
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167241
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167241
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167241
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167241
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167241
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167241
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167241
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167241
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607
baseline version:
 xen                  c62d634cce8b1507d00a61bfc8168ac42367fe87

Last test of basis   167241  2021-12-09 09:04:14 Z    1 days
Testing same since   167312  2021-12-10 01:37:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c62d634cce..1384d4e1e4  1384d4e1e4ef6e846a1cac54f6d2868d40309607 -> master


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 09:52:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 09:52:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243706.421636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcZy-0006O5-C9; Fri, 10 Dec 2021 09:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243706.421636; Fri, 10 Dec 2021 09:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcZy-0006Ny-8p; Fri, 10 Dec 2021 09:52:38 +0000
Received: by outflank-mailman (input) for mailman id 243706;
 Fri, 10 Dec 2021 09:52:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcZx-0006Ni-7k; Fri, 10 Dec 2021 09:52:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcZx-0002Wu-3k; Fri, 10 Dec 2021 09:52:37 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcZw-0004xn-Mn; Fri, 10 Dec 2021 09:52:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcZw-00087c-MG; Fri, 10 Dec 2021 09:52:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=olsV44yPIus4ygdwjjc63MtMdNbgjDTPunqI6RLHeN8=; b=Fc1zb94IykXZh8GhjLz0JrrYty
	dyvcy4Xg0Pyh238KYPpWxF89Bw//z3XBLrA2acSMoF7SQCDKJw8EQvwcW5MLI87DfqUgwCIT6Yb5p
	ifsDXltUB8ZCfZk5RflQlALu38DwIblMQ953MjOmRywQ6tt5N1/XHppKv7xEoyY/U4SU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167325-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167325: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=108676c225c8aeb49bbbd5b8e55f7dbfedc71ac0
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 09:52:36 +0000

flight 167325 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167325/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              108676c225c8aeb49bbbd5b8e55f7dbfedc71ac0
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  518 days
Failing since        151818  2020-07-11 04:18:52 Z  517 days  499 attempts
Testing same since   167325  2021-12-10 04:18:54 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 87117 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:08:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:08:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243734.421722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcoh-0001eZ-Ep; Fri, 10 Dec 2021 10:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243734.421722; Fri, 10 Dec 2021 10:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcoh-0001eS-BW; Fri, 10 Dec 2021 10:07:51 +0000
Received: by outflank-mailman (input) for mailman id 243734;
 Fri, 10 Dec 2021 10:07:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvcog-0001eM-Au
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 10:07:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvcod-0002wF-FO; Fri, 10 Dec 2021 10:07:47 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvcod-00060C-8R; Fri, 10 Dec 2021 10:07:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cHGnWzCEBD16LF+5G+GJ3sXkD8iCNz7H7h5y2GxZIEw=; b=sDY6S5yKOwEDAIdJF/sdyxbjLa
	h3p6/wDRLF53q73apGTuKmDWapBBdNxgB8M23vqGrGdXfwGiHyjUV7MWHMN2tXI3OyTcj27rT0z39
	QQKKowURe3sbNd1+9ymSV7XlgQcm57MKPpIOg+vdto/LiqG+mb+QzbfzByWjma2tPm+M=;
Message-ID: <60186223-3b10-7aba-751e-0a3aa2fc29a7@xen.org>
Date: Fri, 10 Dec 2021 10:07:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: Ping: [PATCH 2/3] EFI: constify EFI_LOADED_IMAGE * function
 parameters
To: Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com>
 <d9664972-b0b8-605c-403d-4e2340442cae@suse.com>
 <850a3be8-0e84-3bb3-150b-42a6a3a0c7ef@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <850a3be8-0e84-3bb3-150b-42a6a3a0c7ef@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 10/12/2021 09:44, Jan Beulich wrote:
> On 03.12.2021 11:57, Jan Beulich wrote:
>> Instead of altering Arm's forward declarations, drop them. Like
>> elsewhere we should limit such to cases where the first use lives ahead
>> of the definition.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> May I please ask for an Arm side ack (or otherwise) here?

Sorry I missed that patch. For the full patch:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:14:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:14:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243739.421733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcup-00033y-5u; Fri, 10 Dec 2021 10:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243739.421733; Fri, 10 Dec 2021 10:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvcup-00033r-1X; Fri, 10 Dec 2021 10:14:11 +0000
Received: by outflank-mailman (input) for mailman id 243739;
 Fri, 10 Dec 2021 10:14:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcuo-00033h-7l; Fri, 10 Dec 2021 10:14:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcun-00033V-Vg; Fri, 10 Dec 2021 10:14:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcun-0005Ru-Nn; Fri, 10 Dec 2021 10:14:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvcun-0006gj-NJ; Fri, 10 Dec 2021 10:14:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JlSOGBirp9583NJhHGsMGO8m5EpI6jAEq6LABmF2x1U=; b=oqfLDBqZi1wPkIZY7p/RXPRfji
	KiBFGZ6QoaNh0+x4Fuxv5bSODdbZL8UpUydcTVFX0hn9hiCBx98zQdN7OMXzQRvXUJUZIQ/Tzxv3+
	L3WKL3K0U1RPmAAIJzIU0VeHR2LwOhFaxQ0MvjRDX/rrGjmyk9Uq4jbWK91UVUtitZfk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167335-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167335: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=06544455d0d460ed18c8582121247bf53292d7e4
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 10:14:09 +0000

flight 167335 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167335/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 06544455d0d460ed18c8582121247bf53292d7e4
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Testing same since   167240  2021-12-09 08:42:46 Z    1 days   26 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1042 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:24:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:24:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243745.421746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvd4L-00057D-4i; Fri, 10 Dec 2021 10:24:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243745.421746; Fri, 10 Dec 2021 10:24:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvd4L-000576-1F; Fri, 10 Dec 2021 10:24:01 +0000
Received: by outflank-mailman (input) for mailman id 243745;
 Fri, 10 Dec 2021 10:24:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvd4J-000570-VW
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 10:24:00 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 471d8575-59a3-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 11:23:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 471d8575-59a3-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639131837;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Kd2HoYwBbziqNPpDhxPJEllmvWBaerBUGNRcTkyqyWs=;
  b=bo8VpEVw39wjFF92I5XGHBfPdpyspU71s7sX3u4MwiJbmGe0kgXWYmOj
   sWC/ps4tEZh97T/xDShvEdX8bczU168snYJKqgrYvKZuCzwt/fyAOX4TI
   kwdhsJom6hrnTcyjTDIGlr+17Bgr9V2kxfThvZAM4u6Ya9pYiqPY0/kYh
   k=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: HGusIPi4fDszCd31UddWivVt3nVGatmqjR26qwpTPsT5qFsMG6JSPUzAKsvHpOFuYh9jv0L4oi
 6tLib+QsYP00dQ4vnHPQ4tKzsEVDtaH/1wIsnlsKyxxFsY4JQkRAdNM+BWlCoMu10ay2L8PXcE
 mNZzVTgbTLiTwniFNCANDevIy4Afu3s8d8ErEjhFa9AqPjOUdTWxW9wtR5AfB01xBhv+l3hbsK
 9+bNjrwibPpjtdZbV53rr1K6K8dM7yUvCkW4XcxQV0pSHTVC+tW27DQ4nMBtl3sPsjOS/dxEk9
 MfVLkjTp0woVBHqI+0ZeArwo
X-SBRS: 5.1
X-MesageID: 59717066
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LZd/O6NJflQ24BHvrR17kMFynXyQoLVcMsEvi/4bfWQNrUp30mBWm
 2sXXT/SaPqDMGT0ctlwbN+z/ExSvsLVm9YyQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s7w7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxOsncFui
 4lpiaC1eAAlOPfWm7UZDjANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/ibuoYHhGlu7ixINc3eQ
 OwTeWFlVzvrMyFxBQZKBJcuxt790xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1Fk0Ddq
 m/Y8mDRBhABKMfZ2TeD6mirhOLEgWX8Qo16PL+y++NugVaT7ncOExBQXly+ycRVkWbnBYgZc
 RZNvHNz8+5iryRHU+URQTWehXyVoV1Af+ZsFtw95AfX0KmF51uwUz1soiF6VPQqs8o/RDoP3
 1CPns/0CTEHjIB5WU5x5Z/P82rsZHF9wXsqIHZdEFBbu4WLTJQb00qXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj71hu+aTNT8D2BN1bQ9xawYRGp+ZgPe1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zoC/7It0MvmkveB8B3iM4ldnBO
 he7VeR5vsA7AZdXRfUvP9LZ5zoCk8AM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3a5HXlk4BCbKmOUE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVBCe0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:zQp+OqDG/OiAP1flHeg2sceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHPlOkPQs1NaZLXLbUQ6TQr2KgrGSoQEIdxeOk9K1kJ
 0QD5SWa+eAfGSS7/yKmTVQeuxIqLLskNHK9JfjJjVWPHlXgslbnnlE422gYytLrWd9dP4E/M
 323Ls5m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="59717066"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U3KdZCewbeq6LBW9kOZK5IQiAyhhNiLZUp/kEMZ7CQYqLUKzMMKj/cfsyuYwQKJO41g3QKtbRoprfckNEe4j/Pw/GLZTKyLgl+CaFfuCaLcGgxvTyimXbrTbLeAg9xi/Yk4fxct8FCNy2OyMtmMb8cdfqFD6BiJJlDsD7wwnKIi19a+u3tlo7XrpGfO0fYJb+1T7B2m0XwO3dxSldaPkJxDapdCLwrzzDymjZUOd9FDnUk/pUQ91PMdxdVrBCxWD+90iOWMQLJMsdC9ElZ2A7sX8Dky8IW2lFFG1WoYmbB6KW0H3U9EU7y2r5Ia1MYvNJmbOktnRh7vLzDhkVJeZ8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oS/VCWen5cr9Gyvsjr2HYOhaDpbK9eM/3gDHjqR2rlM=;
 b=VFOBoZQ/lynjE4WMOlDTTs8q2xVVyprBeY8uLa7Xe2LA/m24CKFZ2kLywbORRd8AOJ6Ybwkfa3LT59A/ERpecBGJi8NrrTGDCc9+7jgs6elbYJ7JR3JczwvTpcvuvtr03irEOuGB0T4AagdzDd7/WDjy+7NZNOstE1V0fE/JToAlPz+Uw2+2zyHsQ96W7KaeO9JC80knkps7llpqy+YAzztQVGHgsFXjIYy/7LEt5+BFFGsb6lDjCinj87vagoh0KwqK/qCHI49UK5mmdRHET1++kOY6di6qCD8PZgTsfhbBsQICSsn14geLMhp50TTmtvkoRLW90A4CmGrVG3aPew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=oS/VCWen5cr9Gyvsjr2HYOhaDpbK9eM/3gDHjqR2rlM=;
 b=bJ7a/qxoc70W4Fw7b1JVpwtGeMpXIXQcY53nTQTsc1RieJ1gRyQZCT/Eq1BxmRm/xUAuExYMiHIPXUfG5xZmfsG8MTjvSe5gpI78f7d+zEs5kCsT7rHNO3oo0zpGXIrniyI/GpDR7f3DCLy+VCfVz6YSzCZqVrD/hViQ16RQU+0=
Date: Fri, 10 Dec 2021 11:23:43 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 10/18] AMD/IOMMU: walk trees upon page fault
Message-ID: <YbMqr9jF6aUlTsV5@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <5d4a4cd8-ffb0-951a-c86d-98f659ab8d0b@suse.com>
 <YandfTCG9nkWoyrz@Air-de-Roger>
 <66539595-ded3-b60f-8892-dfb391621a1c@suse.com>
 <b429c9f9-83f4-57e1-010e-59181ec93ce8@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b429c9f9-83f4-57e1-010e-59181ec93ce8@suse.com>
X-ClientProxiedBy: MRXP264CA0028.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac50beae-89cf-4ddb-0d54-08d9bbc727e0
X-MS-TrafficTypeDiagnostic: DM4PR03MB6064:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB606412E26201C9E46618B5DF8F719@DM4PR03MB6064.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: bqOxOLQJL/RmJZ+ATHjlKgxQMFSgfOafYUEvGT5vXS7NQR6lGxIIAQ+aAMLoxsSPCfLSev1ZiHchMhp7Yw4UrIpg0LbezEQr/je6zqZB1RkveyWdtLBGTD35Sb0z8DlYmlGCZMRQ0tZQYPgfuQMzoa4w+AOGZRQYpNV1rsKIeVWlnCRi3ouzJTBpUXUs+ujSS10mwb67K/M7th10SEB+zXKfCSLwPy2NJibaSltJSfl/vTpm1o1qZ8a9O3hIlAuOE1CLRLJygszsQEUOz3HF/wYvREUVTFzvpBgCbqNbyyJQa9IJgJRMaQ2sLRWva0zw4tt7EP/Z9sfjIttkfAvZNLrFg/1VMA1VQUlSkeApc4um5xrMfVQh+wZ0EAlQv/f7XGc3tUz7bdsoKhdJ32cVyz8esQCpN01xsD2rRuvqtae9w7iaSpMqr3TaaBiob0cCE5EFoAkXuTy7H4mTKOfdC6rmI1R0JwtydaCfIAVg9i9E993VcDMMmd8IVx+TYzjuGG2Lpr8HbM011Df7pqNt+G4HKlQyjFIsAquZRxy1NnbO9pIXpDlNjMvuR/zUJ1kJtVkvF9Ns1kpfyjSp8A4EHT4r+ctumzUyu2Tt9UDA86szMZwryUjgPKFA8v62GYtwUcSI0Bu24401wgKDorSJqQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(2906002)(6496006)(38100700002)(6486002)(33716001)(6916009)(5660300002)(9686003)(53546011)(66946007)(86362001)(4326008)(66476007)(66556008)(8676002)(85182001)(316002)(83380400001)(26005)(508600001)(8936002)(186003)(82960400001)(54906003)(6666004)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0RpYXFsd1JkS2JYM2Z3Yy8rNFJUNCtaSGh3Wmk0VlUwRWViT1dGME84aGVM?=
 =?utf-8?B?bjlOdFlINXF6MDJTTFBQU2xTQm1EcVJNSXlyaTlCbFlFQU5BSVYzWFRVQm96?=
 =?utf-8?B?ck9wbTBWQUsvUmNjSlVtRWVPMjJHbDJMSnhQdnJOZkhTWnN0SUp5MXRCUjU5?=
 =?utf-8?B?ZjVKb1gySlpObzEzRU1LR2JvS2szZEhFZXlJTnl3blBwRmQxZGoyYzA1UFRp?=
 =?utf-8?B?SnYwY015Mk81TTVVL1graVNOcmEwNTZpYnRyTW5LMlpRUVg2akFxenBIU0Fa?=
 =?utf-8?B?cFFOUFU3dFVZSmYyWllCOTNrNHFiNmJ5REtaeTU3TGpjSHkvZnZqdXRkNTJy?=
 =?utf-8?B?QlhEK1BNeVJHRjUxaGs5Z3BQWjFDUXU3VUV3UXZURitsa2orZDBUcW5UYVoy?=
 =?utf-8?B?ZXZRLzlPQkdMZnd6RFVxT3YzY0t0TWRlZFJYL0hjTVdFelg5MTRtczRLeWJj?=
 =?utf-8?B?YmZFcUw0NG4zVXczTXVGYlFnb2QzSHVUZDBkaVhqS2hoOGRiYkt2T2hqUVZK?=
 =?utf-8?B?KzAzYkFnL09WQW1EZXZxcDVtcHZJc0FMNkQza2JNaXJzZDBwdllXR1V5UWlR?=
 =?utf-8?B?RzBUNDJkNTUwRU5YTWdqNUo4dG16bTFiMzdZS0RtSkk3Z1c2UEFLVHZ5Rk9j?=
 =?utf-8?B?TllIcnAvNDJmUWFnV2tQcTVQbzcvREY5M3VMZ0YrS2pwMjdjUWpHbS9PVHRO?=
 =?utf-8?B?SnA5VE82MVVnaEZrQ0tKa3U5SjZkclNRblBGa0dibWlyc0M1NSsxN01hamRF?=
 =?utf-8?B?eDRIYmFpZ3UybjBpZHJNemRqdE9TTlc4VXkvMjJWd2gzdEV0MHBnOC82dVQ0?=
 =?utf-8?B?VUR5aGJUVVp3S0laRnpUODVYdWxqaEdrUWNjemtZeVNycFpTK2xBTEtwOTlr?=
 =?utf-8?B?WUZKN1g5QzhIQTNTNGQvemFTY0VMZ1FKNjVOOCtJdVRKQ3llTE5YYVgzVVlV?=
 =?utf-8?B?QU5zWVg4S2gyMFlXNGxHS2Jia0l4VTUyeVl0bEpuTmhCT0loSDRGUWpYNkRO?=
 =?utf-8?B?cDlxMWErUXdENE5TTzVFSmRjZHFScldMcWRqb1RZWmx6Q0ZTSU5XTXgyZjk0?=
 =?utf-8?B?Zk5aeG5hazVJdnFDelhWSkhVcVpkUkxZNHVlRmt6NnpnRmhhWVpDWEt1dlNo?=
 =?utf-8?B?b2JDYWlIaWViNkpxWDZhSGtGUWtlSmJlencrcU5IZlhtc3EvSVFCak12azdG?=
 =?utf-8?B?REtla2J3dlNEZzdhbEJsS2xXNTUwT3pmTlpBY0c3L0VodHM4MkpXQmRkRTdi?=
 =?utf-8?B?MmhYV3dLZ2h6NFFib3NlQWZLK01aZ1Voam8xUVpwYzN4cWZBeERBOHM2bFE3?=
 =?utf-8?B?RXVLdklvQ2NMUXVucFJFWndUS25iMldxWTRSeTJaR2hvNjJrbFRaSVZMSnlL?=
 =?utf-8?B?TW8zSjNwNnVsdTRWVXBQU2kyNTk5Y2hOYnBCNmtlN3cyR1FRR3NuYlFTUG91?=
 =?utf-8?B?Q1hNMkpXTWRlWXJnOUJmT2cvT21pZnp4TDVPSkRBSjJxNmRuaElrL1U5UnBm?=
 =?utf-8?B?L1NNOFVDNlYrUWkyVmFQd2xGa0pucVAxWnJ2NU10U1hYQ1pyT2FPY3U5Qi9I?=
 =?utf-8?B?RUkxNGtJYldKUVBNY2s3WVA4TkUzb1V0QWtJU3hnNmYzN0wyaFlKV2pTd1NI?=
 =?utf-8?B?b1FZRGZIQk9IdEZBb0wxQ3hvcGwwMEpnZ2xvRE9TcDZCdlMra0wvNEZmVmtN?=
 =?utf-8?B?MkgvK256TWZvcDcxZzgxbG0vejdSemJHeXRxazkzWGZib01GV2svVUQ3NDlr?=
 =?utf-8?B?V1dVTjJXYi9vNGswd3FZODQ3aDFVRTc1bitXWkp2SXk2SHQyMkpyWDlPZUxj?=
 =?utf-8?B?TXRIdHhVcXJsVlhWRzlGZjJMRnUwZS9BNzRPZVJsREZvMDgwdUJpZk1mNEVF?=
 =?utf-8?B?cUZ1QmgzVWlMd0tWUHNwTmJXdGFSSmk4c010YW1tckQ3VFV0WWpNUlU3WmlT?=
 =?utf-8?B?Sm9Dbk9zNkRXSktuYkVRTDRVUGplaXh5RFY1dDc1MUw1UEhSV1dBK0VFNllT?=
 =?utf-8?B?UWFhNFlOU3gyZnJUNklGUzkzMlljS25GUWxXZ3UyaG5CbER5MFFzZGNtK2VR?=
 =?utf-8?B?MEM0aEVCMW55LzltNG8wb1JIdUpsbDRDRkVNcitqK3I3TjFjM2tpRlpYa083?=
 =?utf-8?B?eG5NVUtEdDh3R2JpeExNWDVzMUxkejIrTmJKR0QyemhTVGpjNlBuVE5Md01H?=
 =?utf-8?Q?n+V7IEn3j0cafCgJsviebI4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac50beae-89cf-4ddb-0d54-08d9bbc727e0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 10:23:49.3259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gz62jFYnOZUvaLIUaua0cxwrWHfm7Z8oI4yviP7Z1mdbZJhiKUvy+t7tIs91jz8GrCc7MnEdL+QwQw1zSG2ACA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6064
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 10:55:54AM +0100, Jan Beulich wrote:
> On 03.12.2021 10:49, Jan Beulich wrote:
> > On 03.12.2021 10:03, Roger Pau Monné wrote:
> >> On Fri, Sep 24, 2021 at 11:51:15AM +0200, Jan Beulich wrote:
> >>> This is to aid diagnosing issues and largely matches VT-d's behavior.
> >>> Since I'm adding permissions output here as well, take the opportunity
> >>> and also add their displaying to amd_dump_page_table_level().
> >>>
> >>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >>>
> >>> --- a/xen/drivers/passthrough/amd/iommu.h
> >>> +++ b/xen/drivers/passthrough/amd/iommu.h
> >>> @@ -243,6 +243,8 @@ int __must_check amd_iommu_flush_iotlb_p
> >>>                                               unsigned long page_count,
> >>>                                               unsigned int flush_flags);
> >>>  int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
> >>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
> >>> +                             dfn_t dfn);
> >>>  
> >>>  /* device table functions */
> >>>  int get_dma_requestor_id(uint16_t seg, uint16_t bdf);
> >>> --- a/xen/drivers/passthrough/amd/iommu_init.c
> >>> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> >>> @@ -573,6 +573,9 @@ static void parse_event_log_entry(struct
> >>>                 (flags & 0x002) ? " NX" : "",
> >>>                 (flags & 0x001) ? " GN" : "");
> >>>  
> >>> +        if ( iommu_verbose )
> >>> +            amd_iommu_print_entries(iommu, device_id, daddr_to_dfn(addr));
> >>> +
> >>>          for ( bdf = 0; bdf < ivrs_bdf_entries; bdf++ )
> >>>              if ( get_dma_requestor_id(iommu->seg, bdf) == device_id )
> >>>                  pci_check_disable_device(iommu->seg, PCI_BUS(bdf),
> >>> --- a/xen/drivers/passthrough/amd/iommu_map.c
> >>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> >>> @@ -363,6 +363,50 @@ int amd_iommu_unmap_page(struct domain *
> >>>      return 0;
> >>>  }
> >>>  
> >>> +void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
> >>> +                             dfn_t dfn)
> >>> +{
> >>> +    mfn_t pt_mfn;
> >>> +    unsigned int level;
> >>> +    const struct amd_iommu_dte *dt = iommu->dev_table.buffer;
> >>> +
> >>> +    if ( !dt[dev_id].tv )
> >>> +    {
> >>> +        printk("%pp: no root\n", &PCI_SBDF2(iommu->seg, dev_id));
> >>> +        return;
> >>> +    }
> >>> +
> >>> +    pt_mfn = _mfn(dt[dev_id].pt_root);
> >>> +    level = dt[dev_id].paging_mode;
> >>> +    printk("%pp root @ %"PRI_mfn" (%u levels) dfn=%"PRI_dfn"\n",
> >>> +           &PCI_SBDF2(iommu->seg, dev_id), mfn_x(pt_mfn), level, dfn_x(dfn));
> >>> +
> >>> +    while ( level )
> >>> +    {
> >>> +        const union amd_iommu_pte *pt = map_domain_page(pt_mfn);
> >>> +        unsigned int idx = pfn_to_pde_idx(dfn_x(dfn), level);
> >>> +        union amd_iommu_pte pte = pt[idx];
> >>
> >> Don't you need to take a lock here (mapping_lock maybe?) in order to
> >> prevent changes to the IOMMU page tables while walking them?
> > 
> > Generally speaking - yes. But see the description saying "largely
> > matches VT-d's behavior". On VT-d both the IOMMU lock and the mapping
> > lock would need acquiring to be safe (the former could perhaps be
> > dropped early). Likewise here. If I wanted to do so here, I ought to
> > add a prereq patch adjusting the VT-d function. The main "excuse" not
> > to do so is/was probably the size of the series.
> 
> Which in turn would call for {amd,vtd}_dump_page_tables() to gain proper
> locking. Not sure where this would end; these further items are more and
> more unrelated to the actual purpose of this series (whereas I needed the
> patch here anyway for debugging purposes) ...

I think adding a comment regarding the lack of locking due to the
function only being used as a debug aide would help clarify this. I
don't think we support running with iommu debug or verbose modes.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:27:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:27:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243752.421758 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvd7o-0006OT-QQ; Fri, 10 Dec 2021 10:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243752.421758; Fri, 10 Dec 2021 10:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvd7o-0006OM-NI; Fri, 10 Dec 2021 10:27:36 +0000
Received: by outflank-mailman (input) for mailman id 243752;
 Fri, 10 Dec 2021 10:27:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=kbv1=Q3=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1mvd7m-0006OD-Kt
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 10:27:34 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on0627.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::627])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8799b1c-59a3-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 11:27:32 +0100 (CET)
Received: from DB7PR05CA0002.eurprd05.prod.outlook.com (2603:10a6:10:36::15)
 by AM8PR08MB5732.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Fri, 10 Dec
 2021 10:27:29 +0000
Received: from DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:36:cafe::c) by DB7PR05CA0002.outlook.office365.com
 (2603:10a6:10:36::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend
 Transport; Fri, 10 Dec 2021 10:27:29 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT060.mail.protection.outlook.com (10.152.21.231) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 10:27:29 +0000
Received: ("Tessian outbound 1cd1a01725a6:v110");
 Fri, 10 Dec 2021 10:27:28 +0000
Received: from f7557812f8b8.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 41CCE805-A939-4ACE-AE4C-17FFF1C61A4C.1; 
 Fri, 10 Dec 2021 10:27:07 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7557812f8b8.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 10 Dec 2021 10:27:07 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10)
 by PAXPR08MB6893.eurprd08.prod.outlook.com (2603:10a6:102:13f::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Fri, 10 Dec
 2021 10:26:56 +0000
Received: from PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622]) by PAXPR08MB6816.eurprd08.prod.outlook.com
 ([fe80::b9c9:c5dc:15e:b622%5]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 10:26:56 +0000
Received: from smtpclient.apple (82.8.129.65) by
 LO4P123CA0496.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::15) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.21 via Frontend Transport; Fri, 10 Dec 2021 10:26:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8799b1c-59a3-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vSMWwai/sh9sNCKstRZt02G+hTCv/YcrVajAiDcm4UI=;
 b=iWJG4r6Dkm7YOm0Doe6XNg38q4RONAxg4PPQo/DF6hK4aaqcwYQRyExH7/6qnZEWrNj5JswsFCsuQamcAX6TsCcK8D/x9ksrFWLdrwG6Lb3XIET6EUgpeW3Q2MGj5wLYzw7l4Mt0i3NW1TLV+rHPpf42zBZ7tzzS8qohg64HccA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 13fab0b08e7e109e
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=d2a0s0RAQvYf5rcPkgp8n87inNxIr7P1TaoeuTT1jj5aEmsf14IG3adXEZWEAabHvxI1ja+wh6SZE1JBqh7aMjwru0ICGyXA3JBI5nxhVlu8wlXVI77FkkVHyHYE/bB0TaMZbflPeOQasq4OYGVGl8s8qCUmfc1bfaKj+BQclzSQVlau8jj8TtRUKLuHmpMlepCzi4PLe3gIJ0T3itLLmvrcXKYSYVYZNjdG5asomDRy9mW95nY6Fstd39trQXsjRL6DR3EMRU8Fp+GMZZvDBZZkBnBv6JOAGSxnFqJEJGRkFVTzjVKLbJVybf7ME8ilsKTEdTMuFdiOTbI5WjSfng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vSMWwai/sh9sNCKstRZt02G+hTCv/YcrVajAiDcm4UI=;
 b=C574HQzvJw3JowxC6w9s0S5LWI85kS55vAeOyTZYqP7E7cwSx597863T/iSyPa8kdFiI+c4w/d1b2q2aCjYqFBI55lZkjQShKFDj92TdZ1b2xfX+AXXnQ25RkPOXkapJPoT3QNLW5o8+pWgFLB/46HiqCJfVuGJzGfGtJBKEYCINfyj/PaokKWy7s5OtgJdmTGzvVaDOqx4u+8EXmAED4hP4NmNUJ/XrbPGHSkz5VEGjXaOUr5tEWn6Gbhd9UNmk4Oj1iNX6Z5QzRbvUUPZSIvlM7JXSvjT3Zvhfa4zc5uQkrSjTzj/3DaduqO3nb5Owp8+6lM0XCSx8T4678Td6nQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vSMWwai/sh9sNCKstRZt02G+hTCv/YcrVajAiDcm4UI=;
 b=iWJG4r6Dkm7YOm0Doe6XNg38q4RONAxg4PPQo/DF6hK4aaqcwYQRyExH7/6qnZEWrNj5JswsFCsuQamcAX6TsCcK8D/x9ksrFWLdrwG6Lb3XIET6EUgpeW3Q2MGj5wLYzw7l4Mt0i3NW1TLV+rHPpf42zBZ7tzzS8qohg64HccA=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH] arm/efi: Handle Xen bootargs from both xen.cfg and DT
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <984732f0-8433-a294-acaf-c4130a2ab341@xen.org>
Date: Fri, 10 Dec 2021 10:26:49 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Wei Chen <wei.chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E84E06F3-8468-426C-AFE1-DB0E0A49B353@arm.com>
References: <20211206153658.49727-1-luca.fancellu@arm.com>
 <984732f0-8433-a294-acaf-c4130a2ab341@xen.org>
To: Julien Grall <julien@xen.org>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0496.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::15) To PAXPR08MB6816.eurprd08.prod.outlook.com
 (2603:10a6:102:130::10)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: b4cb09b7-2120-413b-17b8-08d9bbc7ab1a
X-MS-TrafficTypeDiagnostic:
	PAXPR08MB6893:EE_|DB5EUR03FT060:EE_|AM8PR08MB5732:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB5732CA945C72A49C6A2350C3E4719@AM8PR08MB5732.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Uz/ufysHHU5xCa4qdHHBCpGvCxNuaNugYpyhWU+u2c4afJrzCRhPxkZZpMktwrZ1BollNL3p/ipougf0s5i6RrPaXiJ3CWZfLxHeAzQfcLxH76oJqC+zLLxRcKiREm8wWObFlVrDcAy9LTW+oucU619Aa6fZ3y/u/8o9mXLKahFC48z0N3AT/X5dBT/yX5IN6oV41Prnf0+IxR/tLOimjwhK0rdf1PKENFg9y7Nb09hKcEdOKUr4I9dKjL7snPcfQ674LuWH9juUeTCqbLL0Trlu4NG3JtV/Em1BEQVSDh9y6XrPFzkb645KloxuNE+1nDh2IZiQF1OGujwnV8VH5OSlvsqbSPn/GN8kkcjCnBi2uCDo95L78HTto/iOutXk21tq1MTRsfa1FMEy3Xkexu7iIHuzaHw3IRLbUBkcOQAZHcRNSQvY2ao3p0nQ5300UhGttujqCihuTmysfGorPOoBQAhCKntrRo7WJxy2RZHG9+4IqvrQQ61bNT9RJNVZzFajFTCEdZhHIgye0Zu//fn2ntUyf6MGCunPy65oPA7U0qgwWkTnI6Ds6Pz8ZRMHmjCri0TtdDgl8p53Quk166IJKa/9juUIwvD7OMvUTOQDgUcHwbOb25rN7B+RJ+40QF+4YOMq6K551oWDImdPBjdkn9oSTCIfNqAl3PGNs6c0oVzlnHeYXcWB+xvpCnwysxhfNpLlYUJXlfECSVhR4Pg/irX1Vvj9SDRHCPhR2dc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(86362001)(6512007)(38100700002)(4326008)(5660300002)(8676002)(66476007)(38350700002)(8936002)(36756003)(6666004)(83380400001)(2906002)(52116002)(186003)(66556008)(66946007)(33656002)(956004)(508600001)(6486002)(2616005)(54906003)(26005)(44832011)(6506007)(53546011)(6916009)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6893
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	54eafc05-90bf-4631-ad55-08d9bbc7974d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	iR+JbMBSv6YuYIjMFaYBOElR4Wse9jbKbEcXv+sYRz7bCE0tM3/pkeXcdBNRaezUjUNzVo7dVOZhqmGkvRL/pU02HsP/luvRJgRdtgnb523it+SCCoy/qVKfaZcOIr2zxe3n136tKxQME0ZvnSvxgakrzq1Otvj0Ly8I6Cg68W5PjI52yQU7yGDwSr6Wffvp2ebN78MD7Bif9e6LY9eX6FiV2Qmnu6IV191MaDa1zfr/a9QW6zOtA9NvsZBUoA1DDqQ20xhZnCF/+pUmalRzUTacMsJzVIC/Lo0inP3MlfAfmGhCV5oDnxjj7+nlLZDJac0QAEl+McJgzYXkw1NftSpuTPwUbt2aS3B3lL3/OjtblCHeToF1kZNAnBKWMOAVUIMurgTFtu7WTt/99pgjqYpoCpYz+g3BdI6B237qTORE4T20lyULWf3i8l7xBW1l2/LZHfWI0GscmUuCXnshcOw6Qw4rXrupj9BELvoGvSTXoc/E8XDjdlHQFBeRM+XnD/2Jd2uZlDN5OeOhCnhhHb+Sl8hI+7vWc/5ijdHx1N1KijCiBOMpOaDdg3/vABlHVE6bVgxebAbK/1B9e4PfPAl9rmRrvyxweNt/exlpCqL450PnqBXpeNl+QVGshUiUO2LHXaf96s4aY8gBSRoncp9+oBsQAta8OzUP5imHrC6gO8c3dmQR3FzTy32JieXQWWBDB2oWEEIxKyvithsom28E6AH0a3EMslJGluWBz779tmCBED46aOEMh1j2mp6ncY6XVE5KpKV/gG75QPJ/3w==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(4326008)(186003)(40460700001)(33656002)(6486002)(107886003)(956004)(5660300002)(2616005)(6862004)(6512007)(70206006)(508600001)(83380400001)(336012)(70586007)(6506007)(26005)(82310400004)(356005)(8676002)(36756003)(53546011)(2906002)(54906003)(316002)(44832011)(6666004)(47076005)(8936002)(81166007)(36860700001)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 10:27:29.3060
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b4cb09b7-2120-413b-17b8-08d9bbc7ab1a
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5732



> On 8 Dec 2021, at 18:10, Julien Grall <julien@xen.org> wrote:
>=20
> Hi Luca,
>=20
> On 06/12/2021 15:36, Luca Fancellu wrote:
>> Currently the Xen UEFI stub can accept Xen boot arguments from
>> the Xen configuration file using the "options=3D" keyword, but also
>> directly from the device tree specifying xen,xen-bootargs
>> property.
>> When the configuration file is used, device tree boot arguments
>> are ignored and overwritten even if the keyword "options=3D" is
>> not used.
>> This patch handle this case, if xen,xen-bootargs is found in the
>> device tree, it is used for xen boot arguments regardless they
>> are specified in the Xen configuration file or not.
>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>> ---
>>  docs/misc/efi.pandoc        | 4 ++++
>>  xen/arch/arm/efi/efi-boot.h | 7 +++++++
>>  2 files changed, 11 insertions(+)
>> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
>> index abafb3452758..b7d99de87f15 100644
>> --- a/docs/misc/efi.pandoc
>> +++ b/docs/misc/efi.pandoc
>> @@ -249,6 +249,10 @@ UEFI stub for module loading.
>>  When adding DomU modules to device tree, also add the property
>>  xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
>>  Otherwise, Xen will skip the config file and rely on device tree alone.
>> +When using the Xen configuration file in conjunction with the device tr=
ee, you
>> +can specify the Xen boot arguments in the configuration file with the "=
options=3D"
>> +keyword or in the device tree with the "xen,xen-bootargs" property, but=
 be
>> +aware that a device tree value has a precedence over the configuration =
file.
>=20
> I am not sure I agree with the precedence chosen here. With UEFI environm=
ent it is a lot easier to update the configuration file over the Device-Tre=
e. So this could be used to quickly test a command line before updating the=
 Device-Tree.
>=20
> Also, somewhat unrelated to this patch. Looking at the code, the command =
line is a concatenation of "options=3D" from the configuration file and the=
 extra arguments provided on the command line used to execute the UEFI bina=
ry.
>=20
> When using the command line from the Device-Tree, I think it would still =
make sense to append the later because it could allow a user to provide a s=
ingle Device-Tree with extra options on the UEFI command line.
>=20
> But I think this is a separate subject. So if we are going to go with the=
 precedence you suggested, then we should at least clarify in the documenta=
tion that it will replace both.

Hi Julien,

Yes I see your point, currently the boot arguments are done in this way <im=
age name> <CFG bootargs> <CMD line bootargs> as you pointed out,

would it be ok in your opinion to check if <CFG bootargs> is specified and =
if it=E2=80=99s not, use the <DT bootargs> instead (if any)?

Cheers,
Luca


>=20
> Cheers,
>=20
> --=20
> Julien Grall



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:30:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:30:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243757.421769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdAY-0007lf-A3; Fri, 10 Dec 2021 10:30:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243757.421769; Fri, 10 Dec 2021 10:30:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdAY-0007lY-6j; Fri, 10 Dec 2021 10:30:26 +0000
Received: by outflank-mailman (input) for mailman id 243757;
 Fri, 10 Dec 2021 10:30:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvdAX-0007lC-HX
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 10:30:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 20c5adf4-59a4-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 11:30:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20c5adf4-59a4-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639132223;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=4evvILQQxNHk5hljZN6n744fATeohvUVR1S0Ov0RlZo=;
  b=gZWI362Th9aWrI93xxxe7aOn+VBLEdDH4J0/6vdnWtxLE/LQi/gGB/tp
   qQ20GbLvKjYu7C8F2A6oLJ6i26qvz7WNZt5eiBvLFyUV5zfqWQORX4AJ+
   XvyuQqlZoxdtxy/ZPL7iNqjXFAmDCqP2mTgq22jx6yxDT9edaWt//vMYD
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PVvDpYKFDm1kKgR9gGdApqbXRld1Z2KZVvHDbTRKu0NJegLud5AnxevKqtXLbwT/DX+cs8WbLY
 5dyEtsSYb3OdZnmJbX10nyVAlgpW3Fw5SPZBjL0UR/zji4Xts2BWwwqNJR62s1peJSdwngjoeL
 oHyIt44QZNTZP7kIBlBCT7jld5qC5AMmoGde5v+OtO9ejIwrm99qiJ5T1BHDKQe5XC3Vz+lNjx
 X49jAN4l4xcMeVIecQH/SJkdUBZjDdeJKfjwwfTTNuSmcYA8pNUd01ZCiswdT8xj86HZbVL/UY
 T1V3J95vnelSR4/y6krx/g9l
X-SBRS: 5.1
X-MesageID: 60118488
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Jktfr68LMxP8flJwalBkDrUDfnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 2cXWT+GOKyJYWTwf951a46w9B9UvZfdndVrTAI/rnw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg2tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgrl
 PZyure+bj4yZI+UsuFDSUNkPgxxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGhG5p1pweTZ4yY
 eIHUyNoYCznbSFjHWoVFZI8xOqrtFTgJmgwRFW9+vNsvjm7IBZK+LrwNpzTc9+DR8RQl26Zo
 H7L+yLyBRRyHN+S1zuDtG6tj+nnnCXnVYZUH7q9ntZoilCOwm0YCDUNSEC25/K+jyaWS99Zb
 kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxRwi
 ny2kPjnIgV06p/NY3fD7O2ogB69bH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE+8CRJjPZ8Dk7SY5MAulRQIe+L7Kl5lHAhRqrBNbIFwLR1
 JTodiX30QzvMX1vvHDdKAnuNOvwjxpgDNE6qQQ3d3XG327yk0NPhagKvFlDyL5Ba67ogwPBb
 k7Joh9275ROJnasZqIfS9vvUJVykvW8S4y0Cqi8gj9yjn5ZLlfvEMZGPxH44owQuBJ0zfFX1
 WmzL65A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eHwI50/P7FZqX1bMEe1tGALXNogRtfrYyC2Io
 4c3H5bbkH13DbyhChQ7BKZOdDjm21BgXsuowyGWH8beSjdb9JYJV6WMnOh/ItM9xMy4VI7gp
 xmAZ6OR83Km7VXvIgSWcHFzLrTpWJd0t3UgOiIwe12v3hAejUyHtc/zrrM7Iusq8vJN1/lxQ
 6VXcsmMGK0XGD/G5y4cfd/2q4k7LEanggeHPiyEZjkjfsE/G1yVq4G8Jga/pjMTCieXtNclp
 +Hy3A3sXpdeFR9pC9zbaazzwgrp72Qdgu97Q2DBPsJXJBf36IFvJiGo1q03LsgAJA/t3Dyf0
 wrKUx4UqfOU+90+8cXThLDCpICsSrMsEk1fFmjdzLC3KSiFoTbznd4eCL6FJGmPWnn19aOuY
 fRu48v9aPBXzkxXt4dcEqpwyf5s7dXYuLIHnB9vG2/Gbgr3B+o4cGWGx8RGqoZE2qRd5VmtQ
 kuK99RXZeeJNcfiHAJDLQYpdL3eh/Qdmz2U5vUpOkTqoiRw+ePfA0lVOhCNjg1bLad0b9x5k
 btw5pZO5lztkAcuP/aHkjtQpjaFIXE3Wqk6so0XXd3wgQ0xx1AeOZHRB0caOn1Uhwmg5qXyH
 gKpuQ==
IronPort-HdrOrdr: A9a23:HRcG3al1KSQ2y70O/ttLXyRFuTLpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="60118488"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ny6rwN5fDpS/zG0cpCpkANHGqiIuuo08BwhSfF3TfbxrPqIWmsVHVfwVkGHmMxmQBVuf2WUHeFP5lOuFUUajEAgMgxUOLNHV8o7ah+PoipTligP1/OKPvh0cZ0c1no8ijA022Tw+I/HW+BnoXQsnEikC7d1FIq2T6EmuQsOXrxh4ScI7VhKXZys74U9zJ7iDDokoQMwZlrRy7Y9GRld9KgmgHhvC11q0+lGV4WNGXEeJqtw/dQA/duOH4vWqnihqb6fP1vC+EMwFkZ8CQtiEgOuzan9de1srRl0ziF+IRvbwguCuJpeqB1m+gZ/16ft0KM8iez/7OQsMr1I+Y3NpQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=efO7i9HM4hQZtTbeIveCTeoOkUZvKrPMC/1No5eKVAY=;
 b=UMyCiLMZYT0HnfJnT4QAG9LXxSyZPWevvBxAomEvFCUuo7n6DwMHfK/USnz05jYs4/l5wT8hCG9BuKIBhujVULQ2fNTM5QfD0yWllcdJSSxLSvTYTax6QwQCxNq77FXVvH2sGHKoIHVVguW2gfRMPbDj+mNMvVQW6y4uZutJk/fjFvtw0n+lM5yeTuG5klWgmFHZ42/b7cKMbFX2llnKmaqJjIo7l3ZGLgFUcsy9k7cfugSuM3OTtHUQDpCjOOb/w4eV8KtgYv3OlchsSpBQ0LoEFZ9GApk7Jnvp9nEAPTPy4GKasiuARUaV6LbSWVTtueQQI1/nBG8RFUTUUJnc+Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=efO7i9HM4hQZtTbeIveCTeoOkUZvKrPMC/1No5eKVAY=;
 b=VQYqC+oYtfa9w1ApiPA7yKBaVGKVwoTp7OVuDb5to8qsKUejR6lol6L5TXY/CMteAsBrz5iO8k/aKC+58wuUamCufltsuTqqfXh2nKPuNOi4NKe5Gst3LGvJ6EeJFYH2gmmw9FyWvnFiJWv+zg2PcxoJ8c4xYLmcPFbcq/RQPTo=
Date: Fri, 10 Dec 2021 11:30:09 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Jun
 Nakajima" <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
Subject: Re: [PATCH] x86/EPT: squash meaningless TLB flush
Message-ID: <YbMsMWC8Y767XnmV@Air-de-Roger>
References: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
X-ClientProxiedBy: MR1P264CA0129.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::17) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d69913e0-0bd1-4407-acc0-08d9bbc80e39
X-MS-TrafficTypeDiagnostic: DM6PR03MB3740:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB37402D6DD8D46D8EEDB2D6308F719@DM6PR03MB3740.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SdL5P2fMCGTTwtXlcJNj7AHHTNVL8NZ/LVuK29OQbDYXjr/dpWO99eiKTZpd1Q45R5aEAXu9UzBy8nBIrw3vDjNZKqyUX0yjg15FjboHMKWGSbo2dEV5mUY8Ad1DYU+giU5MhXamlgm1e2x5TQwDxFBL8/lPPGPPma8Gan55jrjajPJeNWA2I5zWtDz3KcEPteSEqvGwA58M37lYLgSqdSK/TlU7q8dIiCrEo16GCJhl8vCBA/WKOdTqMWvHYrmOSw2LYEZjOHgIJhC1pzJ8gQ8AfkCxBis2RrEHHv2W1Bapn60AQAwaAtO/mhrVOEiTGojtXeeRvjR1Pz8LwhRH83j5Ohu4zqPLGLuf1aPN1AfFjMTKdvOq2/WjZRDVBOe7VA43WA/bmcsdaSIgpcG/oG5ENMWzFNoQo3z7ACyfm3D3S0Oqu/QwzbqEALfo4xSbEuDrxUmBYLIQfznSBO80BYXGOAu51rPwXshTE6fw/eNl6KAFKO5eb4VSJQ122DcwIFQQJlMrVpGg8D7C/MX9z0CStWCIua85tuwevtlACQJlumgI5HjnIOGc8KWnpjst8A6/zHrVAV5aIZY/AAf2MRi3qj5KzSurVIclCym9iUq8DwRg2Wp33+88zeTVHGzr4KepC7x/ZPAeNmF4qGFxow==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(508600001)(38100700002)(26005)(5660300002)(956004)(316002)(8676002)(82960400001)(4744005)(186003)(9686003)(4326008)(6916009)(66556008)(85182001)(86362001)(54906003)(6486002)(6666004)(6496006)(66476007)(8936002)(2906002)(33716001)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUxUWFRHQnNtRmNuZjVULzVhb0ljT1YrU3p5MW8xRFJSN29uS1F1QUcrcjQw?=
 =?utf-8?B?dGE1Sit5MjY2OWdqU2JIbjJnWlJhUUN0YmFzQmkrdnYyb3pPRzNrdkEyTVJO?=
 =?utf-8?B?TG91ZkZhUDJMcXZEYVlaV2JQekh1RHRCZmMxN2EyR0t4b3NvbC9TeE5vczU5?=
 =?utf-8?B?SmRCYXZVWnE2V3Npbks3T0crVnVJejVlNjk1eFVkeVU2endyYk91OGFUZGhU?=
 =?utf-8?B?cmFFZmVycGwrOE5kYlhvN2liRnZGWURKcnFTaUVjNVJjWS9WanJmVzRCRldq?=
 =?utf-8?B?UExma3RLMDBINjAwQ2Q3Y3NTd3EzRXJINlFabG5uNlNxQ0hWT05iK2V2WmxC?=
 =?utf-8?B?c1BDc2IweWpadWpQZ3ZhdWNyQi95QzVEOUpNNEI3dWZKeFI1MnVFeWNLMVNs?=
 =?utf-8?B?TDNFSHlZbS8zMDNSTTRZM3ZtbzBNellTZlFveGhXTy9WeEp5Ry9LUzRTeWNM?=
 =?utf-8?B?K0NnQWFsUDJaZlZudTh2QjVodWpMQlRMNW4rQzRkNnQzczZWdkZId0ZtQmY4?=
 =?utf-8?B?cHZ0cTkwZGFSSytJWW5LMjRCZi9EblhhdjI1ZVRCaDNaYjNRTTc3cS9uOU9T?=
 =?utf-8?B?V1VMellKSFJaU2dUYnNTNGpKb3BWK0ZRZWxVdktrVlhUU0FPWHdJdkVPYk5q?=
 =?utf-8?B?UnpFRm5mbTFIdXQvcFZkTW9YZkU1bnFTUHVCZkpaN29aWGpEeEE1dmtPT0tr?=
 =?utf-8?B?cXA3ZlRjUDF2WklWcjNJVGg3T09wTEZUbnppU28zb1BZMGVBbzNoVk16TUZJ?=
 =?utf-8?B?Vkl0TGVxdHlyWVNVRm1SK3BRejFtRDJyVHpiYWwyYVFFQWROaXRPSCsvRVBw?=
 =?utf-8?B?dzRJQk1ENERtemZOclliUndselRzN01RUnk5TUh4UmZrQmFkZ2YvZGZXVGF5?=
 =?utf-8?B?bTlhektMUWpiQ1R2M0ZxbjN1MWt0OTN6YU13dEdpYmRKK3RXZ0lVYXBJOUE4?=
 =?utf-8?B?YkNzNEdsOCtjdFlvUjZHTzFzTXRKUnZUcGtuZ1NLMW1hYXI1L1RQb1BDRUNZ?=
 =?utf-8?B?SkdNYmUvemo4YVV0THppUUkrbGtvRUV2SDRQc1pjOWk5QWQvOWVtV28rbDRl?=
 =?utf-8?B?eUVWTlJMQ2lGRjNvTENlN25mYUM5Q0sweURNd2xnVFJPdVR3VE94dkRaS0tN?=
 =?utf-8?B?N0lrTk9DU3VUUmtmT0RzaC9qdGdqSFprT3M5TVpNRWVxS1I1Q2ZTbzhTVXNK?=
 =?utf-8?B?VHhIUGFYUTM5Q2p2Vzd4aFkrTzl0YWFicm1OdkVtTi9qSVlxUitNcUZzamJJ?=
 =?utf-8?B?bnhycXBPVUNhenNtdVRHd052TCtwb2xieFRkUGk0b3BGejhBd29QTlVxckJU?=
 =?utf-8?B?SW5yd2Rzc2JHQ3JMVmVkU3hRR1pGSUJSUWNPWEhURlFDcFErY2JlOVNuaGpL?=
 =?utf-8?B?M1pRUTdHZTR4RldvcmFaQ21NMGJXNm1hZ1Uzemluc2ZUN3kxakdHeThGcUVx?=
 =?utf-8?B?eVNGOFlVdmFFQ2l0ekVLYXQvVnNrT0tyRWJRQ0piWE9nRU8xcG40V3JLT3pm?=
 =?utf-8?B?bGltZC8xcDdGZDhFMXhrQXd1cFVCWGxYTWNEQzhyamdCZFI0QytOVWo4aHYy?=
 =?utf-8?B?bHpWU2dvZktOTkRKNERTYnVGYzZyVG1EWW52eldVZDRiU0VWNUQzWjU1dWxj?=
 =?utf-8?B?WnJ6MzZJSDROZ2dRbXd1UmxhZGRRRjBtNFhTVFBESDNzY3FqRVAzMXhUWmRI?=
 =?utf-8?B?b3paOUhNZzRZTUdiVTk5R0JDSnppN0hzNlVqb21MWktoOFVNVGdDaHRwSm1P?=
 =?utf-8?B?SlB5VjZ3MWEzVG9CZExWQWlaSi9IVnN2RkdFVkEwbWFubHNtZ1FOZExpRXBZ?=
 =?utf-8?B?c2RTd1NVc3pxd2ozZTNsUmJMeG5iMHE5c1BPb1pvQ3FlWnFlTk9WQi9pR2w0?=
 =?utf-8?B?YVZud08vc1d4NTl2ZlBhTlpIVUFZZDIrOGlpVWp3WUVHQTBDVi9uR3h1WWFh?=
 =?utf-8?B?QXpYR2U2SXMxUXQyM1VMUXliMkM0aEgzRFF0ZVcrM0tIYzdzT3FjUU9mVFp1?=
 =?utf-8?B?SVRuak1jUXZNeGJpKzV3SUo3UjduVzlibGtabDlab0swTENwOXhUWHFmaFNM?=
 =?utf-8?B?UGVkQzNsdUl5ejhCaTZkT1RHenlJeGhJYnhVTk85cnRXS3RnSnNhWHVVbFhi?=
 =?utf-8?B?Z1R5NE5ORTFsVmlRbDVIRk5zQmlHYTV2VThoNHM5Uks5d0xNbXRmaXRsMERk?=
 =?utf-8?Q?tsMCwn+vQWdp1jiqdOHIVtI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d69913e0-0bd1-4407-acc0-08d9bbc80e39
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 10:30:15.7494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bv71xcQWlzYUYtHWqmEqpUsQtd6XVQdVxMGvrdCUVa7UiAbciCnuE5OhBNSad+Ag6NRAiijj1tYdkUu9RkOEew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3740
X-OriginatorOrg: citrix.com

On Tue, Nov 30, 2021 at 05:10:53PM +0100, Jan Beulich wrote:
> ept_free_entry() gets called after a flush - if one is necessary in the
> first place - was already issued. That behavior is similar to NPT, which
> also doesn't have any further flush in p2m_free_entry(). (Furthermore,
> the function being recursive, in case of recursiveness way too many
> flushes would have been issued.)
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

It's also worth noting that ept_free_entry doesn't modify the p2m
itself - it gets handed an EPT entry to free, which should have been
unhooked from the p2m previously by the caller, so it should be the
responsibility of the caller to perform any flushes.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 10:49:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 10:49:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243762.421780 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdSD-000264-TF; Fri, 10 Dec 2021 10:48:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243762.421780; Fri, 10 Dec 2021 10:48:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdSD-00025x-Pd; Fri, 10 Dec 2021 10:48:41 +0000
Received: by outflank-mailman (input) for mailman id 243762;
 Fri, 10 Dec 2021 10:48:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvdSD-00025n-4k; Fri, 10 Dec 2021 10:48:41 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvdSC-0003e5-Pd; Fri, 10 Dec 2021 10:48:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvdSC-0006NM-E0; Fri, 10 Dec 2021 10:48:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvdSC-0007K5-DV; Fri, 10 Dec 2021 10:48:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=++0zjjTMdCE6pj7JYSIUzvLAo0zSkw4nrt7i5YU0CD4=; b=fHCdaB+ONMzNl01FkqPekJG1SU
	tgHevLNGJG6CG4LKUspQCao2jkUODkXyfCCBqNBruiFAIn7DVB31Fv7yQghVj+QFxBIGvSGVruH6J
	0t8ywWkyouO6rmQIlsTyY6jcIkdjoYnXLj/lh+WesrqrFVKFJoJw3V5RKyHobbsndP28=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167317-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167317: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=c741e49150dbb0c0aebe234389f4aa8b47958fa8
X-Osstest-Versions-That:
    linux=ded746bfc94398d2ee9de315a187677b207b2004
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 10:48:40 +0000

flight 167317 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167317/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167287
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167287
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167287
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167287
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167287
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167287
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167287
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167287
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                c741e49150dbb0c0aebe234389f4aa8b47958fa8
baseline version:
 linux                ded746bfc94398d2ee9de315a187677b207b2004

Last test of basis   167287  2021-12-09 19:40:01 Z    0 days
Testing same since   167317  2021-12-10 02:28:41 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alaa Hleihel <alaa@nvidia.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
  Doug Ledford <dledford@redhat.com>
  Guoqing Jiang <guoqing.jiang@linux.dev>
  Jason Gunthorpe <jgg@nvidia.com>
  Leon Romanovsky <leonro@nvidia.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Shiraz Saleem <shiraz.saleem@intel.com>
  Tatyana Nikolova <tatyana.e.nikolova@intel.com>
  Wenpeng Liang <liangwenpeng@huawei.com>
  Yangyang Li <liyangyang20@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   ded746bfc943..c741e49150db  c741e49150dbb0c0aebe234389f4aa8b47958fa8 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 11:16:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 11:16:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243770.421793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdtA-0006VM-8X; Fri, 10 Dec 2021 11:16:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243770.421793; Fri, 10 Dec 2021 11:16:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvdtA-0006VF-5i; Fri, 10 Dec 2021 11:16:32 +0000
Received: by outflank-mailman (input) for mailman id 243770;
 Fri, 10 Dec 2021 11:16:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XN5i=Q3=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvdt8-0006V9-CN
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 11:16:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9146e15f-59aa-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 12:16:06 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E9E881F387;
 Fri, 10 Dec 2021 11:16:26 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C6E8F13DDE;
 Fri, 10 Dec 2021 11:16:26 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IPA2Lwo3s2G5ZgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 10 Dec 2021 11:16:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9146e15f-59aa-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639134986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=49EiHb9kXDc8bVTLFZJ4RWgndAVfmtdQ5J0Q7JZzUUk=;
	b=BJqpxRm9yVso9axMd1SXLh6aFQiLSr1LQkq5u+hCRfi/eeRDsh0eP3LvtBsi3/tOyYgOYO
	O5LldRG5XTGt2vp2xJ27IPHbPduK50y3FRslZ22pmSBE6dCnhOziGIl7cIJh4B6WIvOHYa
	O7jHnEvvFqjsEVLOsVhoWVoKi15DLWo=
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
Date: Fri, 10 Dec 2021 12:16:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211209170752.20576-1-andrew.cooper3@citrix.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="hIfD4CHQ11qUUxgh7BgVDP8bIuxTp0I2L"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--hIfD4CHQ11qUUxgh7BgVDP8bIuxTp0I2L
Content-Type: multipart/mixed; boundary="iuZEExck0cL5gofZdr5ZroKP1sDTKZEMw";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
In-Reply-To: <20211209170752.20576-1-andrew.cooper3@citrix.com>

--iuZEExck0cL5gofZdr5ZroKP1sDTKZEMw
Content-Type: multipart/mixed;
 boundary="------------D7D5335ABDDF36E378A564DA"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------D7D5335ABDDF36E378A564DA
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 09.12.21 18:07, Andrew Cooper wrote:
> The values are already available in dom->{console,xenstore}_pfn, just l=
ike on
> the PV side of things.  No need to ask Xen.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> ---
>   tools/libs/light/libxl_dom.c | 17 +++++------------
>   1 file changed, 5 insertions(+), 12 deletions(-)
>=20
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.=
c
> index c9c24666cd04..03841243ab47 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -722,13 +722,10 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid=
,
>   }
>  =20
>   static int hvm_build_set_params(xc_interface *handle, uint32_t domid,=

> -                                libxl_domain_build_info *info,
> -                                unsigned long *store_mfn,
> -                                unsigned long *console_mfn)
> +                                libxl_domain_build_info *info)
>   {
>       struct hvm_info_table *va_hvm;
>       uint8_t *va_map, sum;
> -    uint64_t str_mfn, cons_mfn;
>       int i;
>  =20
>       if (info->type =3D=3D LIBXL_DOMAIN_TYPE_HVM) {

What about moving this if () to the only caller and renaming the
function from hvm_build_set_params() to hvm_set_info_table()?


Juergen

--------------D7D5335ABDDF36E378A564DA
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------D7D5335ABDDF36E378A564DA--

--iuZEExck0cL5gofZdr5ZroKP1sDTKZEMw--

--hIfD4CHQ11qUUxgh7BgVDP8bIuxTp0I2L
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGzNwoFAwAAAAAACgkQsN6d1ii/Ey/+
wgf9Hf/08D83ccySqloE+gl5FPPtB3edcLq/icGzorYSx4LdgiDmHNLha42/PMRe+yJNMm2PL1oA
C2coJp3xKxZTEWEBc3iwSpWVXbUnFTHaP3XRGm6bktXb/faDeENw5jl5dhboV1ExL+RoXbBfyjVz
tdbvHeIfj3pBZy3gfo+gjW5FuCw6x0HsQgtF55oO0aKjQvzE7Ksq6fWvNPaPrckNLuLsDje3X95A
4XTrd2HjYHGVlaMp7P7qaL2sv6EU96wC+1wsW/7fNMqstVzG2S5l+FyIT07OCgERio1JEXnH5fvU
/d4mqBqApsa/yZdntU4k5RkZZszN9tpqddIlv7yxcw==
=1F53
-----END PGP SIGNATURE-----

--hIfD4CHQ11qUUxgh7BgVDP8bIuxTp0I2L--


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 11:30:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 11:30:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243779.421804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mve6e-0001XD-Fh; Fri, 10 Dec 2021 11:30:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243779.421804; Fri, 10 Dec 2021 11:30:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mve6e-0001X6-Cq; Fri, 10 Dec 2021 11:30:28 +0000
Received: by outflank-mailman (input) for mailman id 243779;
 Fri, 10 Dec 2021 11:30:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mve6c-0001Ww-R8; Fri, 10 Dec 2021 11:30:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mve6c-0004Kc-K0; Fri, 10 Dec 2021 11:30:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mve6c-0007vw-A0; Fri, 10 Dec 2021 11:30:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mve6c-0002a9-9X; Fri, 10 Dec 2021 11:30:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=z+2pSqdwEr40GCQMir+lu/47H/zcBZ1hyiXKYty//iY=; b=e5lGrxT5iZ+7DWHpxnpdEr4kr4
	IbUU88xW8NCzaYYOIgItjz+Ej9Jh37xzZRxZ1mSQDUtdSJXxILSx7w0F5RNaNN3A0YDMdXWoCuVj5
	fv7+YranWfdQoJ9WNjVjXw/tJxsro0AsDXS0m9KCVWXPfKbqxdrVDGR8T00c8SxcCMAM=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167338-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167338: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 11:30:26 +0000

flight 167338 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167338/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   27 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 11:37:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 11:37:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243785.421819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mveCr-0002Bv-6t; Fri, 10 Dec 2021 11:36:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243785.421819; Fri, 10 Dec 2021 11:36:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mveCr-0002Bo-3O; Fri, 10 Dec 2021 11:36:53 +0000
Received: by outflank-mailman (input) for mailman id 243785;
 Fri, 10 Dec 2021 11:36:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dYg4=Q3=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mveCq-0002Bi-Ft
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 11:36:52 +0000
Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com
 [2a00:1450:4864:20::12a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77acdc35-59ad-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 12:36:51 +0100 (CET)
Received: by mail-lf1-x12a.google.com with SMTP id b1so17418296lfs.13
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 03:36:51 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id i8sm285074lfl.287.2021.12.10.03.36.50
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 10 Dec 2021 03:36:50 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77acdc35-59ad-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=q0EX2c887v+fPFHULPYX+g0HtB41ahOOyTy81jfN7fA=;
        b=QFq3dfEuaC/ZrR9cXElNTzTKqK6fX2+DXYCfLxD1Y9fFygejwQK+MmoAwbRE8J+uOT
         zeS3bSIDwqVavq/FS2H67pebzo4N8j2Px8nUCvx40EmGl6amObvoLXNf7hpJcT333n15
         SmzGx3weO44DWQDIbq4dDvkCKdFM/o4i2eHU5HCEXQ1Bh1hZOshjF+cK20j8Xv7I83O8
         QB9QqLTEy/K3BJcRSgKLRqvQ1bGFrMkYvftxQDZubsW6H0izMf+/mbjN+hAthkKWi+Tg
         fN9x3VjsjO1iDNnQwfbZ5YpGdNwYCqzrxIAYT6ga13p5VY3z61Tq+mmDXiPWI6chDC1B
         9LLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=q0EX2c887v+fPFHULPYX+g0HtB41ahOOyTy81jfN7fA=;
        b=jc+kIMqYD/xFYFwKvfZ41IxdOmV/SGE02Qlbf35jd2pa4eNaPuvXvIaOVnNNbU7BGT
         UZmLXcOBqUOeCcZR/IVy9ym2YXHGQXNDp86JJnrvwdYac7VFHpQ8SS8DooORzeb7yMxA
         W62o/IlfrI2PitO1eGVpRzUIcJffv3wV1dlxn0HwZjBzq6KlI3DZ/xTBDaz8OIOIMP7F
         EEXfDaiSfwUa6ltp58sxyZv8g60e4mVBNXwChc50Hh2C8gW8WO5H9bJpMaOb5oz9ZPdm
         7xtzPJbwEiwTR8suRN7tw6STC/nX9RoOJD243/rCIKqgaaWuatA9GqtQ/5fBsVvAOtQL
         OnFg==
X-Gm-Message-State: AOAM531WduX//t3FIQIdDwvksLyEOlVKsVjq8XuxdWxl7wrOftFnc4/n
	2L2gGuZ38WPsg+y/oz9VW3pO3wpRhzYKCA==
X-Google-Smtp-Source: ABdhPJw5t4mb+80yXTBjzMnq1ZoZI2s9GRnKP6bfIY+UCxPG1pIehe8j8CjKjA9WLpHwTnfsNtCSdA==
X-Received: by 2002:a05:6512:685:: with SMTP id t5mr12006434lfe.84.1639136210663;
        Fri, 10 Dec 2021 03:36:50 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>
Subject: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
Date: Fri, 10 Dec 2021 13:36:41 +0200
Message-Id: <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com>
References: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Xen on Arm has gained new support recently to calculate and report
extended regions (unused address space) safe to use for external
mappings. These regions are reported via "reg" property under
"hypervisor" node in the guest device-tree. As region 0 is reserved
for grant table space (always present), the indexes for extended
regions are 1...N.

No device-tree bindings update is needed (except clarifying the text)
as guest infers the presence of extended regions from the number
of regions in "reg" property.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
Changes V2 -> V3:
   - new patch

Changes V3 -> V4:
   - add Stefano's R-b and Rob's A-b
   - remove sentence about ACPI for "reg" and "interrupts"
     properties

Changes V4 -> V4.1
   - bring the mentioning of ACPI back which, as was pointed out by Julien,
     fits in the context:
     https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org/T/#t
     so technically restore V3 state
   - remove Stefano's R-b and Rob's A-b as I am not 100% sure they are
     happy with that
---
 Documentation/devicetree/bindings/arm/xen.txt | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt
index db5c56d..156fe10b 100644
--- a/Documentation/devicetree/bindings/arm/xen.txt
+++ b/Documentation/devicetree/bindings/arm/xen.txt
@@ -7,10 +7,14 @@ the following properties:
 	compatible = "xen,xen-<version>", "xen,xen";
   where <version> is the version of the Xen ABI of the platform.
 
-- reg: specifies the base physical address and size of a region in
-  memory where the grant table should be mapped to, using an
-  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
-  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
+- reg: specifies the base physical address and size of the regions in memory
+  where the special resources should be mapped to, using an HYPERVISOR_memory_op
+  hypercall.
+  Region 0 is reserved for mapping grant table, it must be always present.
+  The memory region is large enough to map the whole grant table (it is larger
+  or equal to gnttab_max_grant_frames()).
+  Regions 1...N are extended regions (unused address space) for mapping foreign
+  GFNs and grants, they might be absent if there is nothing to expose.
   This property is unnecessary when booting Dom0 using ACPI.
 
 - interrupts: the interrupt used by Xen to inject event notifications.
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 11:41:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 11:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243790.421830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mveHT-0004BF-Or; Fri, 10 Dec 2021 11:41:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243790.421830; Fri, 10 Dec 2021 11:41:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mveHT-0004B8-Ls; Fri, 10 Dec 2021 11:41:39 +0000
Received: by outflank-mailman (input) for mailman id 243790;
 Fri, 10 Dec 2021 11:41:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mveHS-0004B2-6j
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 11:41:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 21b6454b-59ae-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 12:41:36 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2056.outbound.protection.outlook.com [104.47.1.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-6ufrNEEWNj-bf_QcgCYD4g-1; Fri, 10 Dec 2021 12:41:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6671.eurprd04.prod.outlook.com (2603:10a6:803:11f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec
 2021 11:41:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 11:41:33 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:f0::36) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 11:41:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21b6454b-59ae-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639136496;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=kVtSlN6OefiVGXOCVUNHbVK7NUdqjaoDch3sE316kCQ=;
	b=Q8iyUteOp0jzIh/1vy5kbadHuP94DiKgIDNg3eIiPOg+Na5Scui1ib5wqPBlubHz1V4q3N
	fang8kZX5ho9yY7+wG0BiLm1wBf9gTmXgM3NVLSnBG3Ara9IFFzDYvzVPdBZE5XFzq2TIq
	Em/T8onUUyNsFWTGSK/bsNh3Oz1wT24=
X-MC-Unique: 6ufrNEEWNj-bf_QcgCYD4g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ExPz8S9EJCXUR4R2uX6YNq33iuz30po/IqlDQyg99godVvbTUFDwjYzciotTmLvAVsfDr7NzVT777dNurSnelasmz5YauOQ7oMxfnVv/GC1/52zh4NPjsu0fHJ+nA2RihTQRhQ4ZhdG0UyxaKkhz+q5VKiBhH6mixesREXCMq4ehWsLwkTXVteTlhbhxfUfxI96aDsmQu97DL4zbC5/t0LnlonXDiDjn28tu4uC/BDCycgSa+KKGQxDfug/lkcAigjcCtx7kIU+Qv8tAv0YdlnClamec4FZp8WXPyZsSNn0wSGHOIFx+RnixqIUG6T6tS3UyKUpQhR/h6t/wIFKx0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=x89M2zig9DXdn3QqBbLEBv2HMC5p/11NIDL8RS+jL+o=;
 b=dR+ZwBIshvlUV0AHuRP9Bd2oTr+fjMkjScuj0tD6JA5hAKJ/PulLDM4eEDT2KMEK/fsh+yPIiJLVcuxMyOwUuZ2v+d+Z818WQCz8wW1HArml/K+XN6wz/7drkAtV2IQJRAQUA+ZWpE/NT9wLRu0GIHYtHv+QEquoxZn3/QMYhFHVGLPdnTLfCESz3WFU1yf9KfKwD3Ei5sEhZUBB4scVbOPlRr7BA782wZR+50inSNssFSpeZMNWnXQ3cQTkKOG2z6Hs5ZPoYdH1bwPqhgg9vlsxf6QGf4xWkkuaRqTUkqvjA7plfVTQ4JU3B9ZOLu3hLfMM9ngcZ1i8UHxPKr6wmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ad9d298a-62c6-bde1-ea42-698ebd1a7f10@suse.com>
Date: Fri, 10 Dec 2021 12:41:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
 <YajTvrZz0xGOR3vT@Air-de-Roger>
 <2a3a0a37-525d-e2aa-b396-b01d97434d56@suse.com>
 <YbMfnFWIlSN+GXH9@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbMfnFWIlSN+GXH9@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR04CA0059.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::36) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 39e10baa-8037-4d56-d447-08d9bbd203e3
X-MS-TrafficTypeDiagnostic: VE1PR04MB6671:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB66718844F5D888226B792FA8B3719@VE1PR04MB6671.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mGQiz9DWPvaf51sRGxqMtI/Qc2pAtfahZ+t4Wrdb+EQxRPsnQP6BLHuUeO6UdSdMAGuresXLc/ku7NrAunXl2fr4US+S0H5gFecaCnvTU8Y8djuOb8RpPEn3R7RRlvMa6Wt42+n4AuqzrsH6rC3nNcCdFjgtfe8JBSxoYa1Geo+zOubxD1vOv8OKgVZo0ZYx86Wersy3HyktXmF3Ln9g/hyDjxf/Bz4IsIjCv9bl5Qdaf/PZEkc/9i8GXQ0ZYHyZwWRnBNxx2vuYRg+cFWRAp0ao/FW0vIfSm99y6JsHwC4BccpoQVLTozlvlpoquF9nubX4nygfhXZlm5uRpFDXTo7hGyT7UJVzk5nsvgQG2YdUHaLnkATtCWaeUTZ1iMVMQCrtuRQ51y5rMEMLJOaQuyhCevZGljesOMEthmMT7aqKP8WnWirQkuetpsAFMohB5nsww6bnNWGidQ7K+nA2tJlZWAmkbiE9ZzS2clG0h5vrTgzxLdm3Q8S5Eo56KmYPU3RPGgytEDKc/7uERsBAcHh8pnNfkYCYe9YlULIqw0v3/qo9p7JAm/Ibmfju2lkhKtRo9wIgu0yZho2r3XaYrTls+fvKXU88P98jqDncVJA9bOfPShOe9Qq4rDpuCIntrY6nL34444sofLZup8CIfZVgj+ML3CXz5dMRLRnhMmmnCKxWzNYg7dV7fzDrwXo0O1LXVYjYIbQv1b13DQB+z+V5k0yOu2jU4pQVdM/7+RY=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(508600001)(54906003)(186003)(2616005)(6916009)(86362001)(956004)(6486002)(31686004)(38100700002)(16576012)(53546011)(36756003)(66946007)(8936002)(66476007)(66556008)(5660300002)(4326008)(2906002)(316002)(8676002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6OXK/NVMTcfLK6p67asGf4dh3baI3OZSmxJVQMecXonxh7IRB5rgkxCiTxQ8?=
 =?us-ascii?Q?AWx0EmrYz/xAJTT0eRH0fxL9g4G7kKgWQ46rPiOfuk3c2LMH/OVkFhVBqgE8?=
 =?us-ascii?Q?4Z/HteUer3lk8HHYnIzn2eIHIacNX6T5jJtrLqA59+hbZ4nLgBF2K3y/A59q?=
 =?us-ascii?Q?QBlV0QD5FF8XiixeGj7t3Issh9Fmkk0P0l80rvUOEMYHHuWuZvqvao6FwuKi?=
 =?us-ascii?Q?O5z3wsxKVlkK29AD9yG+BtvrjDuS+NqPJp4dvZL6LUbkUqyU1J6gntKCKtd1?=
 =?us-ascii?Q?hd8XCu+mrWY7i/On2fa/rdogOOPhe5XQdkYiTm5dDSi6Yg96y8o+JbWiif2L?=
 =?us-ascii?Q?j4Nr9fwQkSpAheqAP9HMbnBb+jRI/O/DU2rsPmgF8m1fuxo3S4V6KzovxZfd?=
 =?us-ascii?Q?pdrTh6cp547pkSxp95wuoeh9/BAxL6+RoWQ+97AkkqPRYOXn32+f6V6w/xca?=
 =?us-ascii?Q?6BiZaBO15AUzZzrd0fqMTeLVtxpaviPOrG8IhT9xVflbTPy2tfBTOUflc2zz?=
 =?us-ascii?Q?aTV4pGYFDBWAPwCoRBOgTq4AaYWrTce0uImFbeHOhEU0H7uyfudmD2YmP+MS?=
 =?us-ascii?Q?GSy8uJQv7dRzERyVHcspYmawRWL2FUzMkGVTODWOzYdcijLdyUXIGkzOY0d5?=
 =?us-ascii?Q?Qw3FFUCkngF65s4f7OaYknB62fWwINzIQCmV9vQbDB/VARNtQP9r837pUP7C?=
 =?us-ascii?Q?uehtrLmtAuGC2zfc8CENqrV9NGbbA/sRaHBjKXHv/y/Y8x2DZbYO/Jd8sIkU?=
 =?us-ascii?Q?w4kfETWVNoO9E9jGckRPplmWigpM1ePdTr6xw8RC3gkitu0t2YN24EHRqaso?=
 =?us-ascii?Q?doZ9dbVDMcaORs0649M4uhzqBmtLC8XUheWtfnNBxXVEFbydiQ7mhnXEPows?=
 =?us-ascii?Q?PRTV8XFjQEZ9FEg+cBQ8WlbGCxU/rWUx7vks+QyoBaW/xKhJr8ayUPjOZDTy?=
 =?us-ascii?Q?67dcBPpLjgELIec5jQtVU5Koe/Pfo+8imI7S9sB655e5v8np9wZAqvs1qdfh?=
 =?us-ascii?Q?fzaaT3NtNgU0dM3STyuxjotNI9eMxzQFOmCuMqndf05Qt/pWCPSlLPwVDPTh?=
 =?us-ascii?Q?kzgmsQpBXGml+2biiadBsSKIxTLYvX8dh0Wt6txP167jD5r5GZNBEDr+8Ad4?=
 =?us-ascii?Q?tDOkPP9YAlqJSYN7alYik5hCmAnjPpqW1zcKjrvbexOlhJ0DSuK0JULIUbOR?=
 =?us-ascii?Q?1/7ei3bLNUQ3ay9xd5mimB1OUXX6lmlT179p1dULYJWYG2PPJjXcyrlhiHEN?=
 =?us-ascii?Q?SINXix9X67++SD9N+i9Ihy3XdMqoLMnfu73syJh72KGvu1HekW6fx7jgUoBZ?=
 =?us-ascii?Q?Znu8ZVYQ1uu/HTGrdzuGzNiVzNosTnw45So7zQJEuVdupYbKrFkcNZQwXY2R?=
 =?us-ascii?Q?KuPdyNtYA7T0vpfn2POPpnz3d0YAdanjlm28UmuQpr/ibF4yiu83Y8ktluxE?=
 =?us-ascii?Q?yqF1nIHxqcyF8E0m0YRMdZinwm3V24V8ATcKWCW6pquiXD9SjTf5k5CeRxZa?=
 =?us-ascii?Q?ND+KqiR4wZZGRNHwwWhm8wCHCkuctmhtJUOy1QU8V+yDEdUJvgByb/MOGB/x?=
 =?us-ascii?Q?v+ETwl1kp018Mz4a74lZngVyZerpyYdSHIZYanzmF1CKS+uaQ2lu5xvG5IGU?=
 =?us-ascii?Q?Nd59TuXoZEvbosCZsEYOPCc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39e10baa-8037-4d56-d447-08d9bbd203e3
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 11:41:33.3804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ikx0ujIyg9V09piR22GX/iOLFzzybzlbUHbebE9S9NQsO0ktSBAoaEdBH2KlEmuUMdV8UDIUvsr0O+VvG53nIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6671

On 10.12.2021 10:36, Roger Pau Monn=C3=A9 wrote:
> On Fri, Dec 03, 2021 at 01:38:48PM +0100, Jan Beulich wrote:
>> On 02.12.2021 15:10, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote:
>>>> @@ -720,6 +795,17 @@ int __init dom0_construct_pv(struct doma
>>>>      /* Pages that are part of page tables must be read only. */
>>>>      mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
>>>> =20
>>>> +    /*
>>>> +     * This needs to come after all potentially excess
>>>> +     * get_page_and_type(..., PGT_writable_page) invocations; see the=
 loop a
>>>> +     * few lines further up, where the effect of calling that functio=
n in an
>>>> +     * earlier loop iteration may get overwritten by a later one.
>>>> +     */
>>>> +    if ( need_iommu_pt_sync(d) &&
>>>> +         iommu_unmap(d, _dfn(PFN_DOWN(mpt_alloc) - nr_pt_pages), nr_p=
t_pages,
>>>> +                     &flush_flags) )
>>>> +        BUG();
>>>
>>> Wouldn't such unmap better happen as part of changing the types of the
>>> pages that become part of the guest page tables?
>>
>> Not sure - it's a single call here, but would be a call per page when
>> e.g. moved into mark_pv_pt_pages_rdonly().
>=20
> I see. So this would result in multiple calls when moved, plus all the
> involved page shattering and aggregation logic. Overall it would be
> less error prone, as the iommu unmap would happen next to the type
> change, but I'm not going to insist if you think it's not worth it.
> The page table structure pages shouldn't be that many anyway?

Typically it wouldn't be that many, true. I'm not sure about "less
error prone", though: We'd have more problems if the range unmapped
here wasn't properly representing the set of page tables used.

>>>> @@ -840,22 +928,41 @@ int __init dom0_construct_pv(struct doma
>>>>  #endif
>>>>      while ( pfn < nr_pages )
>>>>      {
>>>> -        if ( (page =3D alloc_chunk(d, nr_pages - domain_tot_pages(d))=
) =3D=3D NULL )
>>>> +        count =3D domain_tot_pages(d);
>>>> +        if ( (page =3D alloc_chunk(d, nr_pages - count)) =3D=3D NULL =
)
>>>>              panic("Not enough RAM for DOM0 reservation\n");
>>>> +        mfn =3D mfn_x(page_to_mfn(page));
>>>> +
>>>> +        if ( need_iommu_pt_sync(d) )
>>>> +        {
>>>> +            rc =3D iommu_map(d, _dfn(mfn), _mfn(mfn), domain_tot_page=
s(d) - count,
>>>> +                           IOMMUF_readable | IOMMUF_writable, &flush_=
flags);
>>>> +            if ( rc )
>>>> +                printk(XENLOG_ERR
>>>> +                       "pre-mapping MFN %lx (PFN %lx) into IOMMU fail=
ed: %d\n",
>>>> +                       mfn, pfn, rc);
>>>> +        }
>>>> +
>>>>          while ( pfn < domain_tot_pages(d) )
>>>>          {
>>>> -            mfn =3D mfn_x(page_to_mfn(page));
>>>> +            if ( !rc )
>>>> +                make_pages_writable(page, 1);
>>>
>>> There's quite a lot of repetition of the pattern: allocate, iommu_map,
>>> set as writable. Would it be possible to abstract this into some
>>> kind of helper?
>>>
>>> I've realized some of the allocations use alloc_chunk while others use
>>> alloc_domheap_pages, so it might require some work.
>>
>> Right, I'd leave the allocation part aside for the moment. I had actuall=
y
>> considered to fold iommu_map() and make_pages_writable() into a common
>> helper (or really rename make_pages_writable() and fold iommu_map() into
>> there). What I lacked was a reasonable, not overly long name for such a
>> function.
>=20
> I'm not overly good at naming, but I think we need to somehow find a
> way to place those together into a single helper.
>=20
> I would be fine with naming this iommu_memory_{setup,add} or some
> such. Marking the pages as writable is a result (or a requirement
> might be a better way to express it?) of adding them to the IOMMU.
> Would you be OK with one of those names?

I'll use the suggestion as a basis and see how it ends up looking /
feeling.

>>>> @@ -372,16 +372,30 @@ void __hwdom_init arch_iommu_hwdom_init(
>>>>                                          perms & IOMMUF_writable ? p2m=
_access_rw
>>>>                                                                  : p2m=
_access_r,
>>>>                                          0);
>>>> +        else if ( pfn !=3D start + count || perms !=3D start_perms )
>>>> +        {
>>>> +        commit:
>>>> +            rc =3D iommu_map(d, _dfn(start), _mfn(start), count,
>>>> +                           start_perms, &flush_flags);
>>>> +            SWAP(start, pfn);
>>>> +            start_perms =3D perms;
>>>> +            count =3D 1;
>>>> +        }
>>>>          else
>>>> -            rc =3D iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORD=
ER_4K,
>>>> -                           perms, &flush_flags);
>>>> +        {
>>>> +            ++count;
>>>> +            rc =3D 0;
>>>> +        }
>>>> =20
>>>>          if ( rc )
>>>>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx fai=
led: %d\n",
>>>>                     d, !paging_mode_translate(d) ? "IOMMU " : "", pfn,=
 rc);
>>>
>>> Would be nice to print the count (or end pfn) in case it's a range.
>>
>> I can do so if you think it's worth further extra code. I can't use
>> "count" here in particular, as that was updated already (in context
>> above). The most reasonable change towards this would perhaps be to
>> duplicate the printk() into both the "if()" and the "else if()" bodies.
>=20
> Maybe. The current message gives the impression that a single pfn has
> been added and failed, but without printing the range that failed the
> message will not be that helpful in diagnosing further issues that
> might arise due to the mapping failure.

I guess I'll make the change then. I'm still not really convinced though,
as the presence of the message should be far more concerning than whether
it's a single page or a range. As middle ground, would

             printk(XENLOG_WARNING "%pd: identity %smapping of %lx... faile=
d: %d\n",

be indicative enough of this perhaps not having been just a single page?
Otoh splitting (and moving) the message would allow to drop the separate
paging_mode_translate() check.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:06:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:06:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243798.421840 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvefG-0007r1-10; Fri, 10 Dec 2021 12:06:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243798.421840; Fri, 10 Dec 2021 12:06:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvefF-0007qu-UF; Fri, 10 Dec 2021 12:06:13 +0000
Received: by outflank-mailman (input) for mailman id 243798;
 Fri, 10 Dec 2021 12:06:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvefE-0007qo-4j
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:06:12 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8e6bb6ee-59b1-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 13:06:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8e6bb6ee-59b1-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639137969;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=243BZKrFaEkrzy+pZXedgzHVacNVCR+hmr8K9gkh4wY=;
  b=JiU2EcYr8deRem+FIRhkACLukoP9XLGdPyu7XOevjZH5qknPLOktRrMS
   ZteYjn3MbT1Vd0UlrJCYOkxamBiKiyQWteUcOc/skrcib5qTGO+RiGXJd
   qbYbp5CwtlifSU8upUQysy++fC2Nt7dOkISHA45uCAs2f9JbzRu5SLb3b
   o=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: uB4u1xZIBR1SuyH0JqzIo/Dwe5/8nQCKlRr94cOVAT4NRJW5zWTqR9lh8AhcTF2N+lzLtOm5SH
 HQdLNEDk1EQtDO0TWx1uWp5wESPRCupEkPG/nG/fmg4kAtoCeBLfrAFwV14vvL8jr/yH/3Ijq9
 T5LDOYbt/P0lSFVy/C6zoySapboh4z4cQi8QJTu0/WOhpObgXolY5Z19XSKwp/O3SjyZ3gjNcS
 OYQTHLcJTXhHAn82sWStzkrYAw7FGTBgNwB0z9xO5yvZxm72d/ZxrAXvIvpF7baXXY5KDf3CLW
 b1NnlukQlYBoLbAHSrwpSkeT
X-SBRS: 5.1
X-MesageID: 61793153
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:0QdM5qJJcZzYC0W2FE+RD5IlxSXFcZb7ZxGr2PjKsXjdYENS0WQHn
 2pKXzrSP/yNZ2Xxe4wjO96xp04HvZ6Hy9ZlHlFlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg6w7Zg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Ehetqm
 PAOtKCdVAwYEfPngulATUdhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvIAJh25t3aiiG979R
 sYnORVOai/QSBNkFW0KLcgwt/+n0yyXnzpw9wvO+PtfD3Lo5BR4zbzFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQrWS/pU45GNtsPvAx2S7T4bDZvhjHPz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XFr5e/LiJYsoZ8N0a6
 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vEr5vmuVh6b/PuREDGQ3C94adO51qXHb4
 xA5dzC2trxmMH10vHXlrB8xNL+o/e2ZFzbXnERiGZIsnxz0pSXyJd8NvG8mdRsxWirhRdMPS
 BWL0e+2zMUMVEZGkIctO97hYyjU5faI+SvZugD8MYMVP8kZmP6v9yByf0+At10BY2B3+ZzTz
 ayzKJ72ZV5DUPwP5GPvG481jO96rghjlDi7bc2qkHyaPU+2OSf9pUEtawDVMIjULcqs/W3oz
 jqoH5fQlkgEDrShOnK/HEx6BQliEEXXzKve8qR/XuWCPhBnCCcmDfrQyqkmYItrg+JekeKgw
 513chQwJIPXiSKVJAOURGpkbb+zD59zoWhiZX4nPEqy2mhlaoGqtf9Ne5wydLgh1epi0f8rE
 KVVJ5TeWqxCGmbd5jAQTZjht4g+Jh6lsh2DYni+az8lcp8+GwGQoo34fhHi/TUlBzassZdsu
 KWp0w7WGMJRRwlrAMvMRuioyle94SoUlO5oBhOaKdhPYkT8toNtLnWp3PMwJsgNLzTFxyebi
 FnKUUtJ+7GVrtZsotfThK2Co4O4KMdEHxJXTzvB8LK7FSjG5W7/k4VOZ/mFIGLGX2Tu9aT8O
 egMl6PgMOcKlUphupZnF+o51ro34tbiquMIzglgG3mXPV2nBqk5fyuD1MhL8KZM2qVYqU29X
 UfWootWPrCAOcXEFl8NJVV6MrTfhK9MwjSCv+4oJEja5TNs+OvVWEpfCBCAlShBIeYnK4gi2
 +og5JYb5gHXZsDG6TpaYvS4L1ixE0E=
IronPort-HdrOrdr: A9a23:lHgc7KjaJ5XNaRWXbljSupDrr3BQXz513DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U
 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ISuvkuFDzsaE52Ihz0JdTpzeXcGIjWua6BJcK
 Z1saF81kadkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC
 X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue
 iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a
 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI
 BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq
 D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="61793153"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OD7PkDgLJaMLcHwjRnL/Eaf1fvfMx0BShl1q0FUG1iXjBV9OXyMHIOx1XpI0Inm8kuCw5RBlYmKW0PjDS3vVNpRbxjDSLRcOX0MQosjJkqfKKpXADATijIxi8Zwa9g1CVEq1iNE5ztu+do6C7LWuTZ/Ygvxjktp702amgd+0xpRWQEvl2CamnMsg0pf+xY1Z1fe8/N5vSpNUuXRXtBR4cDsM74ji2YnisnlfS2mkl4xuKA5u/qTsu3gdTvl9FZCvmLAoVsSdp1xoVOh6A0HcnO6/Gj/4LWWAwewy1dZlZOqA5vJAF3UBMxW8lbhUzgu5KghviOUs+ndS6p4AUGt70A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=243BZKrFaEkrzy+pZXedgzHVacNVCR+hmr8K9gkh4wY=;
 b=TuDsrDoDbdsPYjUu2U+lFPs2xYxrnydXnCmP+RaZn4dpiYSGknRswFR7qGCd1o6KxA7X8FnVDM3i+uVmbWxyqOZzuyF+s+vC/hTv9Uank8nvMrAeqH9zCPOCTHYpiQklLm0UAvI+zp1XiwEy5kdKjVQoH0Y1OnQVeCV33x/qfEDQO41AinsG1DsSL2X6ul/aojEMzl4q66NQ5dCT008122Qmbk4X8yLPS/4mWErmeuw8K47Hsw3uH3LkoWEZxXmE6kbAtZPwhkCLxdBlqVg65hzI5KC72QmI0y2PqM9juqbm9f0jtTU03yRPDkJMM/qfh3Q3E9ifyuVAvYDY8VUjPw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=243BZKrFaEkrzy+pZXedgzHVacNVCR+hmr8K9gkh4wY=;
 b=OYsHGiJl0sBy6suzPAw8gjLYh+v8Wy0+bRtwRd+LPb4KTDsBj5jCej2udw6fRZSCebeKTBrUMPYHsO6AxNlQy8rHa9xjiEX44dnOZD30eDa8NnSzCBkokRMQztbjNyIq6U4FcCBTZkmn2vcaMnZQ3YWtZhZbFC7mjNtb55azRDA=
Date: Fri, 10 Dec 2021 13:05:56 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 11/18] AMD/IOMMU: return old PTE from
 {set,clear}_iommu_pte_present()
Message-ID: <YbNCpA1PDtINnn7j@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <33819694-2787-4bd6-1830-6b4eb81cb4a1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <33819694-2787-4bd6-1830-6b4eb81cb4a1@suse.com>
X-ClientProxiedBy: MR2P264CA0116.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:33::32) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2dab30f1-4fc9-476d-5f73-08d9bbd570be
X-MS-TrafficTypeDiagnostic: DM5PR03MB2777:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB277780728259E4525731B9268F719@DM5PR03MB2777.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ruKoJ75JpVTqVc3YrvFlHndas52iB0DeCY1qNHh31vyalBR2UB0aXhmW9sMBsfjXetwLJe5c9jHmSHbutSrYK+TzLVbN/qGIYuHcI3IeNtbbH60KJP4ZnReQDc/NV+Rf0GChdhsB1vBO538hf1Q6TbhKtkmVTN8OzKX3ZEi/puS/7Xh+7y8FG0qPKZ8OcsMERKLSIIxkuE3EFT6cwoCZwzEo7lXpj4mDgcDOaBtv5KRQFqNQmoOJiCjLTMfJ8GwCspY25Ltwp2dy0VEkRI18Mue0MQNQFQaZCZAx1NUOd12VW+FJKewcIuiRiM2nHGjSoQMObDyIsUt0Svj7z0Zkjk9rMLvg+v/K1NsVK12T4Tpy8Um1EfH1AyyBLeFL81P78HiLaOcPMLws+1xFA6nH7YhYwbaVk7pbp+oZKb6K9eSC3XTSraHI3ZbV+55Z7IVPEz2rZ3EXrTJCjuOHI2z8Do+dlyaOwXAO33zRUypYLUkWQ6ScMsWtDtQMf2wJhx4JsO4ZvDgqZ8MNjxxIpMP271GEQs7BSsAWODOkEI7vFPo6+9HgaH/kPamP5Pey75ZpRKFRen58m+b0SXHvxIzfIMYnN7cTI8xjC5cUbu3r1YLRkoHUeyo60HvVhvVj5V9heMvJJ1nKESCM2z67xAnH4w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(38100700002)(316002)(85182001)(4744005)(5660300002)(508600001)(8676002)(8936002)(66556008)(2906002)(6666004)(66476007)(66946007)(9686003)(54906003)(26005)(6496006)(33716001)(6916009)(186003)(4326008)(82960400001)(83380400001)(6486002)(86362001)(956004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1ZXenBJdlNUVXNOblVTU0tIU2NOR3hzTnlMc2ovYisrcWpUdVpUSjA3akNR?=
 =?utf-8?B?eE1IU25pNytIS0NYUGxZYkc1Ky9Vd2NmeGdsaHhzM2p4VFo5Y0duUDVDWVFx?=
 =?utf-8?B?RjRTT3Z6K3c2Ync2MVMxejBWbTRhd0JJVjB5OXZTUDBqdDBLSEg5VUZrbXhs?=
 =?utf-8?B?aGpwa1RRMUE5OE5yMDJ3dmZNY2JvWStoU1JVRy9JQlBnc2Z1Vm5DVlh1QUQv?=
 =?utf-8?B?d3g1MGFLV3JDNVhRbUZVNjArZ05VdFI3RndMb2FhWXZoSXY2emVGeitVWG5v?=
 =?utf-8?B?TXdwUkFoY2M4MHA0UVRyeEJtWEFXM2FDN1lWK3JNdWZwKy9EeFlPdkNDNm9C?=
 =?utf-8?B?N1RBRWxpMy9VVlhUa2xwNVRieGFvTVlCK2YrbzE4ZE1hcW8vRkJnZVFXbW03?=
 =?utf-8?B?MlMrRTdJdWJzcWdGOGVJVWJGRk5rU0s1ekR1NHZWdS9ncExuYll6dnRjM0Uz?=
 =?utf-8?B?STNjQTRwNHlxblpNRmlmRnFWUWg0L3lQS1NOSzNRNnM5UlI4MHhFNmJSOXRo?=
 =?utf-8?B?Z3JiaXo4WWsxbmVZM0RrQi9zUVlrUlU2aWo1VmtVTmdjSHk2NExCSUVqR0Iz?=
 =?utf-8?B?OVpGSnBpKzVFK0lUYVdqV1hTMjU4VThzeGJua3VLV0RXNndWU3FmVWhBNFE1?=
 =?utf-8?B?NEh5YmFlVjRHVmg2MGlDalY1MFZhbkFjU25SK1FWdmZ1SjRUTlVKbjJmR2xa?=
 =?utf-8?B?bVIyUDJMWThDem9FdE9mU3NvckM2SVE5cEtoTmMxT212S1ZVWHV0Q1dzNmYy?=
 =?utf-8?B?NHpaRmF6K2x5dXVBdHdXbDFUbG5DQUpqSWpRRk9XbStPUUYrWUtNV1BwMExy?=
 =?utf-8?B?NTVoRXpDUjhTdXFLNmpVaUF0dVBmSzJpRUt6UExXMGNRV2pqMENleDhULzFw?=
 =?utf-8?B?YkgwaHJNWjJ6RWVnV0t6Q0lPaEFYeWc5ZmtYT00xWHc4UzUrb1pCM1A4MFRp?=
 =?utf-8?B?S1BISzlhL2NTd3FUMTNrc1lPVXcwTm5ZNTBuelE1N3N5SXdLK2VEZEtWSjky?=
 =?utf-8?B?TlRIWjJGVDhNeXdqbDR4T0VXRXFKTWJZamV5SU9UVlZNZlBTRkVZRFlqOWFX?=
 =?utf-8?B?TXBURUV2QmN6ZkJmdTltN25GRy82Y1h6bHkwckZoU2x6cU41QUNUWU5Ob3pP?=
 =?utf-8?B?T3dSWG5EcmRLQ254aFMxYy9NanVwalhSa1Q3NXBxOFVjWTFTRmZMTC9xU055?=
 =?utf-8?B?MFRKeHp5UU1OYVdkK2l1d2hwSjFPWmgxMU9GaXBjeXNvR3BsK1A2UUplSkZj?=
 =?utf-8?B?MnQwa2ZSTW05M2Nrd0FZRVZzblUxL1hzZFRTNWd0dTczL0xIbGh4SGJyeXJJ?=
 =?utf-8?B?YVBiUVVxalpLcDFVVjFaanczTE1OekI3YURlajZSajlHc0VXakgvemZpNzNQ?=
 =?utf-8?B?NmJEUVFtUTk5anRJTVAzWEVYSGFhc1gyZHg4VGgrakxaWktRTWp4cHArMVlN?=
 =?utf-8?B?RkZtZzJjY05XMitYRGh3WVhVTVJLSytqSDMramwydHlhekRZN2taZ0Q5bnd0?=
 =?utf-8?B?VTNaYjNFaG5ZMnFVR2d2emxVcTdoT3RqUHVmVXRQT1k5b1g1c0pRWU8zdXR4?=
 =?utf-8?B?SEpOYnMyditZd1U2RHFXcmR2dEZnWFU3cVhLUmR0bW1HVXZLdkpZdmtLQk1v?=
 =?utf-8?B?MUtzWHJRSDdSTmx4L1BMSUdKR2RJRFM4N2gvRkNCaEltbThzbTJKUldXc1pw?=
 =?utf-8?B?L1YrVjlxUXZVdXAxUmhrRDBqVW9iRVVtdWkzRHZlQ3RDMVZId3pvWTNNNVN3?=
 =?utf-8?B?UmJtcGRJYzJlWVBzVUt0K0JxRnN2NEVwT1B0aXFDTzA5WEhnWTg3eTBacmx0?=
 =?utf-8?B?NVVUTzF1MUxZUW9iNWovbExHSy9LU1F1ZVFhVjFTQWh4bTdYSkh6SU1hcGhh?=
 =?utf-8?B?ckNZcE1xMHU5RGUwR0JvQmowZmZNdklEUXJZdmdsM0hwKzNWeFBxOVlrWVVh?=
 =?utf-8?B?a1F1QkZHWCs0ZGpObjNrV1lLbDlWeTIvajdnYUx4TS9KZEt5UmpaeHljVWJH?=
 =?utf-8?B?VkVEcFMwWFdPY3lXbWQ4NTd1a3BoRVR6SnhPZkdwTWlVdlk5b0w5RG11WTAv?=
 =?utf-8?B?THhJeXMzRGMvRTg3dWlQMUx1cEtUQlAyUzBQZmR3Vkk5Tk5BZjhGQ25OYjR3?=
 =?utf-8?B?M1lScVVoOTluR3hpOXBuckwwUzZEaDQrcUdTdUM0MkZwN25IaEFlTkd3V3lG?=
 =?utf-8?Q?S6kHBMhy+xN4HH4m3crORxY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dab30f1-4fc9-476d-5f73-08d9bbd570be
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 12:06:04.4743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5tN1uIUSslARobcHdDAiNKA03oAVFov1XLHmZ9p2shNrzgeLmO8yMvKnBoaD0JHX0KntL07IezCm9LvQBIqFfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2777
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:51:40AM +0200, Jan Beulich wrote:
> In order to free intermediate page tables when replacing smaller
> mappings by a single larger one callers will need to know the full PTE.
> Flush indicators can be derived from this in the callers (and outside
> the locked regions). First split set_iommu_pte_present() from
> set_iommu_ptes_present(): Only the former needs to return the old PTE,
> while the latter (like also set_iommu_pde_present()) doesn't even need
> to return flush indicators. Then change return types/values and callers
> accordingly.

Without looking at further patches I would say you only care to know
whether the old PTE was present (ie: pr bit set), at which point those
functions could also return a boolean instead of a full PTE?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:35:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:35:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243805.421852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvf7R-0004Oc-CY; Fri, 10 Dec 2021 12:35:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243805.421852; Fri, 10 Dec 2021 12:35:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvf7R-0004OV-9D; Fri, 10 Dec 2021 12:35:21 +0000
Received: by outflank-mailman (input) for mailman id 243805;
 Fri, 10 Dec 2021 12:35:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvf7Q-0004OP-N9
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:35:20 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a1042db5-59b5-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 13:35:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a1042db5-59b5-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639139718;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Rdn+zmvZ51XAp/sMu8W8RvGtHBxl32cTDbJakM2zqPE=;
  b=E14ySr2GYnO3jePu6Z6w+f03lfULbDlT4pqsn1csxGE27S1w+3pKOvUF
   xKpqMLktfZYpx1Hjnd2GUe78jQeSGqP+aZJSGZiNmcJZIF3/t7DhYo2S2
   wT9KdLvttNt2f9TtWI3OdPjtyriogz6s2NSXD99QpMqHhJfixRNWFHN+6
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: IUmUWG1Yo4blDtjrmEJzQArDUjSTR6OtsFve+3JD7R1FXP39wZpp0W8LJcaS8XSLfaeMtEg09R
 hssCb5Lh5IPrQESqtefIiUGPxug4PtWFGA/5ciKezelDNzLGD+K8m+wvgAETucx/+Z2ijc9M5H
 ZXnjPJkV3NYMJy9xLHK+L2+RWl9stBGkRJtQv9rFghbo0qwyRTkLGr+LNbKWAB8InVbc8vSei4
 NEjbAW/CibXH94FVemjgredfd1fUmdviN0BiaNp6CSq7Mcywmk3AUlDxtu+Rqw8jlLFE846f8T
 qrCYN8bGjW4qtayXRdn6M6w2
X-SBRS: 5.1
X-MesageID: 61794647
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:5RizUqALfL0ArBVW/8vkw5YqxClBgxIJ4kV8jS/XYbTApGgmgmZRx
 mFKCz+Ba/yIYGv2eoolad/n8EIF6MXVnYQwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX570Eo7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/2x6rztZtx
 Mlxq8KMVgoqYr30yKcsakwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHfyVtIMGgGhYasZmIKn1O
 41IahZVXDPbWzNlJ21GVLEFg7L97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibdpRtlaVo
 CTB5WuRKhMQOcGbyDGF2mmxneKJliT+MKoCGbv9+vN0jVm7wm0IFAZQRVa9ueO+iEO1R5RYM
 UN8x8Y1hfFsrgrxFIC7BkDm5i7f1vIBZzZOO70RylCL1qbI3xjHOncJTWJRUIxlhfZjEFTGy
 WS1t9/uADVutpicRnSc6qqYoFuOBMQFEYMRTXRaFFVYurEPtKl210uSFYg7TMZZm/WoQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtQizARVodt/xory9U
 J4swZD2AAcmV87lqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkyY55bJGO3O
 B6P4Wu9AaO/2lPwNcebhKrrVKwXIVXIT4y5Bpg4kPIQCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGLq9NOdg5TciBgbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+
 Wq6VFMew1367UAr4y3QApy6QL+wD5t5s1whOikgYQSh13Q5ON7956YDbZonO7Ig8bU7n/JzS
 vAEfeSGA+hOFWubq2hMM8GlodwwbgmviCKPIzGhPGo1cal/SlGb4dTjZAbuqnUDV3Llqcskr
 rS8/QrHWp5fFR96BcPbZav3nVO8tHQQgsxoWE7MLoUBcUng6tEyeSfwkuU2M4cHLhCanmmW0
 AOfABE5o+jRotBqrImV1P7c94rwSrlwBEtXGWXf/I2aDyiC8zrx25JEXcaJYSvZCDH+9pK9a
 LgH1Pr7KvAGwgpH6tIuD7ZxwKsizNLzvLsGnB98FXDGYln3WLNtJn6KgZtGuqFXn+ILvAK3X
 gSE+8VAOKXPM8TgSQZDKA0gZ+WF9PcVhjiNsqhlfBSkvHd6rOidTEFfHxiQkygMfrJ6PbQsz
 folpMNLuRe0jQAnM4regy1Zn4hWwqfsj0nzWkkmPbLW
IronPort-HdrOrdr: A9a23:ZD15lK/RheXfqOpp/m9uk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="61794647"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UCum0UgIS755D20Vayy4Z5Q+A0Kaj1HvhNQAggtuZXQ5nkhX0u7x4wtna4+XkVWx8vgDOvoDN9TXqgsWKvj231oZRyiTSv62nC38mjvYfCGfiH+kBGFl+YjJojni4/TBTnITGwRKy6MVAnrtZb0+89nX24tMADuqutDfYCyTFfYrEKJgbt/i4V6F+N0ij+Nomgyy78vJ280Iiu28dH3u7OGQi7mEsTlwZhB3hnt20vW7Fi31eFrPfAekH0btdiWLO+rYWVVHMw2AbUgTAjVJcAghSFG6DE03MpJtvWnLGGPcuoctk6mmIIbbayImbW57PXqOdwCwbMATWWzY5P0q7A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HNiZ04hkOWOqIXNWIUGrwx3nRSkzSkJgzizKF5BZHc4=;
 b=cYMDMKHJDgegUAyDwBFTDDalvOLt7sPX8bZfH8gaGhfWhQFCFXk8lPpip8ajCs1nXPTkCY3IQGlv190HMJnvO5j2aq6rYUbqlUuSAnk+goKGsPoYg2hAWrjFGuKVsQ6fkTYFtnG1gXTRprFSO0qNc5b9MwU+JDUouSiZ8qQETgJMDapmArDyWzV13QKwR1PK/E+w5LcyO+4unA/l5fZqeMQECG6I51FipEA0jx0Q+P+4/7kIRZOfgc4Ck8cTSkVOmCkO3OJy1C4u+FkiHnfbc1tW+1++OhMGmKk4HRpyd97dYal7HR+m2nozFxf1gL0zYjrYzHldxmOH3jBJMqRCHw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HNiZ04hkOWOqIXNWIUGrwx3nRSkzSkJgzizKF5BZHc4=;
 b=xbXIUzIGAkL98crK/DFL2VXHT+3nmKc0E5tg6kB1OuffVYFUEeJrYC1hvBExT0mriae790zF+CTH+va/fVqidak5uUWyS+22S9nVTA5C0VTBLNzgd+XTGyZuCQnILlBSgm7udOALWXp/RjiqYO1eAjEhHA+CDcuHtl2eQidIaUk=
Date: Fri, 10 Dec 2021 13:35:05 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches
Message-ID: <YbNJeFAxJDpAyi44@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc183d61-f4ed-1cf5-185b-0673c9927892@suse.com>
 <YajTvrZz0xGOR3vT@Air-de-Roger>
 <2a3a0a37-525d-e2aa-b396-b01d97434d56@suse.com>
 <YbMfnFWIlSN+GXH9@Air-de-Roger>
 <ad9d298a-62c6-bde1-ea42-698ebd1a7f10@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ad9d298a-62c6-bde1-ea42-698ebd1a7f10@suse.com>
X-ClientProxiedBy: MR2P264CA0155.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::18) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: af9a9abb-2273-48b4-69a3-08d9bbd98156
X-MS-TrafficTypeDiagnostic: DM6PR03MB4537:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB45377803AAE800BAB1C31E5D8F719@DM6PR03MB4537.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QeQu+qlTKaa30wJWNR4cpoBG7p3kwFebFc2b7TAhIEDuMH/J64LgilXTatlw9Kwi91XZ9wseUWH3nYNf0XMGwH2GrhbSx/9FaQA5luB+Elu7bX2UwVYOXj0jT8TB+p1PdHsSFLpuyg/guw/odOScXKkNJlrsk2d0+E8spKVocxeOBHwVgPDNj2wrMLPgbgmSP7cgyUH96Ucv6lPdaMPgnAsYSzwvgbSgX6NyzKgrYEWH72NeawSDUBX+XDWC2GS71gbNvMAwaKulXZM7k5+laumm4aDqIfZwGQnnAUlJDpbfERKUMlrJQ8Kt0Tl+oHLWPNcigwrEPydSPShhhjvHP887VPjzT2CgFQYOsHsM1jFfnKG6ah7O2+r0g/3io3hd6tQMbF15ykyi2rRj7A/rqR4BpMLdGWVQ+gZYRna393kt3zqeayaV3dG/1MQqp+4YdzpHuDS7hJxapund+nOfgdFFhBCIhoP0tv0L3qVEvj+t4Q5WY4Yig1d37aFVgoC23EpRBPf8K6YFoR4pu3b7Jj21dBZZHUtGSNJbA7Z5WHPTO5za4zvbEvke1RYpk+9BlFYUYUtPVGj2MAEoUblbfWVbD9eB9GRALZWpAa3dHdY0gpFpKS0qCqRlWl+IVybkz7OMji5sA4ZzjKhvgDfORQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6496006)(6666004)(9686003)(86362001)(6916009)(6486002)(2906002)(66946007)(85182001)(66556008)(66476007)(508600001)(5660300002)(316002)(53546011)(33716001)(4326008)(83380400001)(38100700002)(26005)(956004)(82960400001)(54906003)(186003)(8676002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGdmWmZWRDhvR1ZPZXhBdHB4N0dXL1JVaHBqTmpRYmpRbEN6TDZrbEU5VUxK?=
 =?utf-8?B?NC9FaHJyTytsZUVka0d1elhsdWZyUWVFMXVncW1ZOGdla0hEdVA1V25oUjl5?=
 =?utf-8?B?dUdOK2JKZGgzdy95TklMS1l5L3E0cEdtcG4rbHh3bVp0RGp3Z2ZOVFRvMGZt?=
 =?utf-8?B?YlVuWkhQR3JWT3NrOFlRUWNCQ1l1R2xZVVk0Ym12aXZIa3FwUHhiNGdLZXpB?=
 =?utf-8?B?T2VGOTV4YWl0MjdITDJ0SUVwcDgxMXZBRVRiZVhQVXJLNEdPbzl1SmxXUXhs?=
 =?utf-8?B?NUhIOEJ3cVBsQWhITXB0U08xYUVpaGtTeWVOR2ZubkQ0U2xlOE5qckhYNWYz?=
 =?utf-8?B?TmM1RjFmZXMwWlJodEE0Wlh1RlJPOWZkdVBjY3FieHVsNHR5V2JFWjJuMEhN?=
 =?utf-8?B?bE1lSW0zdHVXRjZuakpyR3Z4Tjd5RjNVVFpmMS9PcGtEdnovQ3daMDZYYUZU?=
 =?utf-8?B?SnhaSlFLRDVrVERRMHFHVU1ucmZHNlpKRDJCQ3dvWUxqcUpRZEZzWWhnbTdp?=
 =?utf-8?B?eVVVWUZGMWlPQVptYTZxOEZveGVRL1k5TXlLYzVKNHNRU3U1TGFTK0xzRDBT?=
 =?utf-8?B?Z1VLeXlNbkxLcXZlMUlXekJPS2xmSEdYSkRrMmR3LzRoQjlFYU1aVUhVVUFs?=
 =?utf-8?B?RUhBVlpxMTJuR2RHU01OZnlEM0YxNzczMHRHYVZpOTBSeGE1WkZqN25KMWo3?=
 =?utf-8?B?RTQ3dVBCL3M5MWNZMUNrcVFkQTh3b0xMZlEyQUZHT0JXT2syeFk3alQ5VkZ0?=
 =?utf-8?B?TGVGeEFWeE50dURaUHRaWGpvQmRHclEwdm9WQUNiL0RvMnhrc0FsVktYL3ZC?=
 =?utf-8?B?UXBuY1hBK2N6bGZnKzNVR3hLdmM0SzFseWsrSVJDT2NFa1A5NGlHcFl1Q0t1?=
 =?utf-8?B?ZXJnU0xObDVrRWJrbTgrdXBZTy9RdnpPWlNZMmJRdUt6S2N5aWZJWmhlc2tJ?=
 =?utf-8?B?SlNMOUw0eisxWkxFbE9zYlRDZlNibkVONCs4TkFUUUQxVHQxZnk2MlZidFJh?=
 =?utf-8?B?WkIxdWZCWEZoRk85RzkyOWM4ZmUrTmxDUVBCZW9vazdwUmt1V1JUVzN5bDN4?=
 =?utf-8?B?SG91a1pJNGJDQ1UySC9IU0VBR1JaZDg2b3p1eFZiWUxIQWhPL2l1aGVmYlpw?=
 =?utf-8?B?Um5vd0YxY2U2bTgyeGk4Zi9mM2JLKzErQkJqRS9xeDczNzZ1ZFJyazdWczVR?=
 =?utf-8?B?TzQyaWFEMmlPc3FaSW16RG9ubmgyTnB6N0VBYjdyaFFWR0V1Q3VBNEsrcm13?=
 =?utf-8?B?aTdGeHBweDlmQ2JqYlp6cHN6YTdzdmt6VUk2ZkVBaEZtRFJyOEh1RWY2aVBP?=
 =?utf-8?B?M2V6YjgzRVpHaXpaZHFQQ1dpUzIwUGgvQVBjdnhMSTVoQStOaktEUE42ajNo?=
 =?utf-8?B?bHdrSkhYZ3JWRlZST2tSODRNQVVRWnJqSW1wN3F6eEFjbGIvWGc4UWpQN004?=
 =?utf-8?B?cnBvZm9lTnFwYkNrbkJ1MmlGd1BZTERNVUVQT1k0K1NtdWV4R255a2dpaTM2?=
 =?utf-8?B?TEtGZlp2ZE5iL3d2bGJYT2RQTWNnMDFNZTJnZmpEZ0lpVU5udDdqVVpuLzRs?=
 =?utf-8?B?eEdJT0I3MkkxUjBpR0l6bXR2YlAwL3FreVY4V1dsVDhtMWpYQ3BjR0Q4ZVlr?=
 =?utf-8?B?NXlaV0FqVmMzUFZRR0wvQzNEcDFZQVF2UURteFhpVDhBT0pXd29JcXE3Zm85?=
 =?utf-8?B?UWduMDB5ZklyS3d6ZjZPMmRhTkx3Y1dvejVhbkg0bkVuNmNMZStMeHN5bFpR?=
 =?utf-8?B?ck14MDJGOENnVmtQbjk2SnUrUFhSQzVaeVAzQmhidnU1b2pyVjBFZU03YzRm?=
 =?utf-8?B?d0VyS2laMFhGbHZ0em1iRHBEcUh4ZXAvN1NtYlVwd1NCU1FnRFVrQ01wQ202?=
 =?utf-8?B?WjdIMDNnQlZMUVpUb3lqeTdRUnFUL3UybWlJQVBTZW9MV2x4QkxISkpyTEth?=
 =?utf-8?B?aFg5dFZ5bTFKK1J2ejdUei9mekNtT0N3Wm9ZRVV6bWZOQlpnNGhJK1FaMkFU?=
 =?utf-8?B?MG1Mbng3KzZhTi9uRFZQcHlEQ3g2WmpwZVU0aTJ3T2xmUFhEVDZRUkl4Qkxv?=
 =?utf-8?B?dU1oU2c3dWlaRWpINXlNT1Y2OVlNdGl1Z3BTT3VrN29OUGFOTmRoRXJ0RS9L?=
 =?utf-8?B?MFpSS0xIVWJmNU55dC92OW9TZWtZUGxROVZsaTh2RDlFVjFBSHk1eldMKzV4?=
 =?utf-8?Q?+CLKK9PGTwfk/8qTOT/89mg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: af9a9abb-2273-48b4-69a3-08d9bbd98156
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 12:35:10.3051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IwFaIEweGeTpjqxodURS/IEwRwBM8j3ayJs6eh0LRVgxBa9IIT5j5fTiJp8GCOYG3DUxuJRwItvYQXaEPn7Bkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4537
X-OriginatorOrg: citrix.com

On Fri, Dec 10, 2021 at 12:41:31PM +0100, Jan Beulich wrote:
> On 10.12.2021 10:36, Roger Pau Monné wrote:
> > On Fri, Dec 03, 2021 at 01:38:48PM +0100, Jan Beulich wrote:
> >> On 02.12.2021 15:10, Roger Pau Monné wrote:
> >>> On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote:
> >>>> @@ -720,6 +795,17 @@ int __init dom0_construct_pv(struct doma
> >>>>      /* Pages that are part of page tables must be read only. */
> >>>>      mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages);
> >>>>  
> >>>> +    /*
> >>>> +     * This needs to come after all potentially excess
> >>>> +     * get_page_and_type(..., PGT_writable_page) invocations; see the loop a
> >>>> +     * few lines further up, where the effect of calling that function in an
> >>>> +     * earlier loop iteration may get overwritten by a later one.
> >>>> +     */
> >>>> +    if ( need_iommu_pt_sync(d) &&
> >>>> +         iommu_unmap(d, _dfn(PFN_DOWN(mpt_alloc) - nr_pt_pages), nr_pt_pages,
> >>>> +                     &flush_flags) )
> >>>> +        BUG();
> >>>
> >>> Wouldn't such unmap better happen as part of changing the types of the
> >>> pages that become part of the guest page tables?
> >>
> >> Not sure - it's a single call here, but would be a call per page when
> >> e.g. moved into mark_pv_pt_pages_rdonly().
> > 
> > I see. So this would result in multiple calls when moved, plus all the
> > involved page shattering and aggregation logic. Overall it would be
> > less error prone, as the iommu unmap would happen next to the type
> > change, but I'm not going to insist if you think it's not worth it.
> > The page table structure pages shouldn't be that many anyway?
> 
> Typically it wouldn't be that many, true. I'm not sure about "less
> error prone", though: We'd have more problems if the range unmapped
> here wasn't properly representing the set of page tables used.

I have to admit I'm biased regarding the PV dom0 building code because
I find it utterly hard to follow, so IMO pairing the unmap call with
the code that marks the pages as read-only seemed less error prone and
less likely to go out of sync with regards to future changes.

That said, if you still feel it's better to do it in a block here I
won't argue anymore.

> >>>> @@ -372,16 +372,30 @@ void __hwdom_init arch_iommu_hwdom_init(
> >>>>                                          perms & IOMMUF_writable ? p2m_access_rw
> >>>>                                                                  : p2m_access_r,
> >>>>                                          0);
> >>>> +        else if ( pfn != start + count || perms != start_perms )
> >>>> +        {
> >>>> +        commit:
> >>>> +            rc = iommu_map(d, _dfn(start), _mfn(start), count,
> >>>> +                           start_perms, &flush_flags);
> >>>> +            SWAP(start, pfn);
> >>>> +            start_perms = perms;
> >>>> +            count = 1;
> >>>> +        }
> >>>>          else
> >>>> -            rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K,
> >>>> -                           perms, &flush_flags);
> >>>> +        {
> >>>> +            ++count;
> >>>> +            rc = 0;
> >>>> +        }
> >>>>  
> >>>>          if ( rc )
> >>>>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n",
> >>>>                     d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc);
> >>>
> >>> Would be nice to print the count (or end pfn) in case it's a range.
> >>
> >> I can do so if you think it's worth further extra code. I can't use
> >> "count" here in particular, as that was updated already (in context
> >> above). The most reasonable change towards this would perhaps be to
> >> duplicate the printk() into both the "if()" and the "else if()" bodies.
> > 
> > Maybe. The current message gives the impression that a single pfn has
> > been added and failed, but without printing the range that failed the
> > message will not be that helpful in diagnosing further issues that
> > might arise due to the mapping failure.
> 
> I guess I'll make the change then. I'm still not really convinced though,
> as the presence of the message should be far more concerning than whether
> it's a single page or a range. As middle ground, would
> 
>              printk(XENLOG_WARNING "%pd: identity %smapping of %lx... failed: %d\n",
> 
> be indicative enough of this perhaps not having been just a single page?

Let's go with that last suggestion then.

I would like to attempt to simplify part of the logic here, at which
point it might be easier to print a unified message for both the
translated and non-translated guests.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:35:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:35:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243806.421863 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvf7U-0004eR-LS; Fri, 10 Dec 2021 12:35:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243806.421863; Fri, 10 Dec 2021 12:35:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvf7U-0004eK-HG; Fri, 10 Dec 2021 12:35:24 +0000
Received: by outflank-mailman (input) for mailman id 243806;
 Fri, 10 Dec 2021 12:35:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=At30=Q3=gmail.com=andr2000@srs-se1.protection.inumbo.net>)
 id 1mvf7T-0004e6-Nr
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:35:23 +0000
Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com
 [2a00:1450:4864:20::52a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a3fea0a5-59b5-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 13:35:21 +0100 (CET)
Received: by mail-ed1-x52a.google.com with SMTP id e3so29911726edu.4
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 04:35:21 -0800 (PST)
Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua.
 [176.36.245.220])
 by smtp.gmail.com with ESMTPSA id gs15sm1468183ejc.42.2021.12.10.04.35.19
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 10 Dec 2021 04:35:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a3fea0a5-59b5-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=xohsmkVTc31Uu+TldrPYsMXqYJVGzbIphIyuFhkNC7Y=;
        b=emX9q5Ezq08xPpwJreiA4hQvBUyFBPO88+n+508QrzeGm8Cxsfq3N7qITakeUj2STs
         JlrO/DrlRtk99Fo2tK6hCG9qbMG+Z+Re7Kp4u8RlLDvo1S2W05sbqu6QRE+Je8yQ/gK5
         0uc9Ep/QO5nZMGVIPdgJgKRFo1J4uUTjtd91MRHkbanrkXPqa6Ce2NzqFnBQ0g4X/A8i
         zLhsw5WTdzDQCXkp1JCi5vnWEx6GlupNc8f3NHw4MfZwDFMcf3DdaU7BA8AaAROXUwjD
         VNOw5Fls0dige+JMhxm1lvZu3YIpdKzfYx+LjZVqwgx0tfQ+7bwUxbjLJVo4styybmT8
         2+TA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=xohsmkVTc31Uu+TldrPYsMXqYJVGzbIphIyuFhkNC7Y=;
        b=doX03+HoTAehoZEytGSV0bteD4GxtSIuC1cbn1Q3P0nd0noj0w45aH2GSbejPhJ6p5
         w7xq4EQe3PAnOZ1oXWLfVNRyK5QRGTZ/n0ryVV27VD+YHLJq3xDm+gStqypEe2/l+s7f
         /4p6Ebn8/qoZ4c9oufG9iSeuEMgEB3ZbLt4jpetaEVnBrRCnts7O51WIua/S/w+KP+vU
         DLXtnqsxAamoCt3OY/rSl0gjBV/jdpJd0u8/o96S9Y+1jeDZ7jF/N+8IdkdSlUOwwTDL
         g7eODSNpBHZHzwcw6rQQZ0CS7E5H7PdpMWde7KY9Zyalj+TGj8FC6UpKmVU0vEHavbxs
         mjRg==
X-Gm-Message-State: AOAM533mQp4AebH+OCObnUd8P8JRkdunjoUoSiv4i7Uzu/3s92BxdEhA
	wCl0oi+0cQI/kXdiwiivcKabezCAVBLr3g==
X-Google-Smtp-Source: ABdhPJxEYwesJmFAV5i76T+vHOyzbrmUYWrV+g1DtHvjzqxAfxIyiMXCTSQHZ+fr34QS332mA73uDw==
X-Received: by 2002:a17:906:9756:: with SMTP id o22mr24715522ejy.324.1639139721103;
        Fri, 10 Dec 2021 04:35:21 -0800 (PST)
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: wl@xen.org,
	jgross@suse.com,
	anthony.perard@citrix.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH] tools: remove xenstore entries on vchan server closure
Date: Fri, 10 Dec 2021 14:35:19 +0200
Message-Id: <20211210123519.595163-1-andr2000@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

vchan server creates XenStore entries to advertise its event channel and
ring, but those are not removed after the server quits.
Add additional cleanup step, so those are removed, so clients do not try
to connect to a non-existing server.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
 tools/include/libxenvchan.h |  5 +++++
 tools/libs/vchan/init.c     | 23 +++++++++++++++++++++++
 tools/libs/vchan/io.c       |  4 ++++
 tools/libs/vchan/vchan.h    | 31 +++++++++++++++++++++++++++++++
 4 files changed, 63 insertions(+)
 create mode 100644 tools/libs/vchan/vchan.h

diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h
index d6010b145df2..30cc73cf97e3 100644
--- a/tools/include/libxenvchan.h
+++ b/tools/include/libxenvchan.h
@@ -86,6 +86,11 @@ struct libxenvchan {
 	int blocking:1;
 	/* communication rings */
 	struct libxenvchan_ring read, write;
+	/**
+	 * Base xenstore path for storing ring/event data used by the server
+	 * during cleanup.
+	 * */
+	char *xs_path;
 };
 
 /**
diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c
index c8510e6ce98a..c6b8674ef541 100644
--- a/tools/libs/vchan/init.c
+++ b/tools/libs/vchan/init.c
@@ -46,6 +46,8 @@
 #include <xen/sys/gntdev.h>
 #include <libxenvchan.h>
 
+#include "vchan.h"
+
 #ifndef PAGE_SHIFT
 #define PAGE_SHIFT 12
 #endif
@@ -251,6 +253,10 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base
 	char ref[16];
 	char* domid_str = NULL;
 	xs_transaction_t xs_trans = XBT_NULL;
+
+	// store the base path so we can clean up on server closure
+	ctrl->xs_path = strdup(xs_base);
+
 	xs = xs_open(0);
 	if (!xs)
 		goto fail;
@@ -298,6 +304,23 @@ retry_transaction:
 	return ret;
 }
 
+void close_xs_srv(struct libxenvchan *ctrl)
+{
+	struct xs_handle *xs;
+
+	if (!ctrl->xs_path)
+		return;
+
+	xs = xs_open(0);
+	if (!xs)
+		goto fail;
+
+	xs_rm(xs, XBT_NULL, ctrl->xs_path);
+
+fail:
+	free(ctrl->xs_path);
+}
+
 static int min_order(size_t siz)
 {
 	int rv = PAGE_SHIFT;
diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c
index da303fbc01ca..1f201ad554f2 100644
--- a/tools/libs/vchan/io.c
+++ b/tools/libs/vchan/io.c
@@ -40,6 +40,8 @@
 #include <xenctrl.h>
 #include <libxenvchan.h>
 
+#include "vchan.h"
+
 #ifndef PAGE_SHIFT
 #define PAGE_SHIFT 12
 #endif
@@ -384,5 +386,7 @@ void libxenvchan_close(struct libxenvchan *ctrl)
 		if (ctrl->gnttab)
 			xengnttab_close(ctrl->gnttab);
 	}
+	if (ctrl->is_server)
+		close_xs_srv(ctrl);
 	free(ctrl);
 }
diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h
new file mode 100644
index 000000000000..621016ef42e5
--- /dev/null
+++ b/tools/libs/vchan/vchan.h
@@ -0,0 +1,31 @@
+/**
+ * @file
+ * @section AUTHORS
+ *
+ * Copyright (C) 2021 EPAM Systems Inc.
+ *
+ * @section LICENSE
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2.1 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Lesser General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Lesser General Public
+ *  License along with this library; If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @section DESCRIPTION
+ *
+ *  This file contains common libxenvchan declarations.
+ */
+#ifndef LIBVCHAN_H
+#define LIBVCHAN_H
+
+void close_xs_srv(struct libxenvchan *ctrl);
+
+#endif /* LIBVCHAN_H */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:38:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:38:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243816.421875 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfAT-0006GU-Cr; Fri, 10 Dec 2021 12:38:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243816.421875; Fri, 10 Dec 2021 12:38:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfAT-0006GN-7M; Fri, 10 Dec 2021 12:38:29 +0000
Received: by outflank-mailman (input) for mailman id 243816;
 Fri, 10 Dec 2021 12:38:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfAR-0006GD-EG; Fri, 10 Dec 2021 12:38:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfAR-0005Y3-A8; Fri, 10 Dec 2021 12:38:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfAQ-0003O0-T5; Fri, 10 Dec 2021 12:38:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfAQ-000227-SU; Fri, 10 Dec 2021 12:38:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hKI/w5V9RW4hNwqa2zphCAhCA0e3ZNxJJ1DiurYTPio=; b=6ANWXln+zaM475bW04utxlFozz
	hWtqc7UGsUvStrQq118uX6X9/rhIArjUqSyJHAJzDqXHMt+zZvHP3uXxDiRXCR1rECQjHAlYyg0/E
	u0yQG5TXzWMgym4QouIMQQwr/zhIkUrAN6jp5IpyvCEot8NXaIzMnTrwLLKq1AZhvG2Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167339-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167339: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 12:38:26 +0000

flight 167339 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167339/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   28 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:54:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:54:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243823.421888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfPF-0000jO-KD; Fri, 10 Dec 2021 12:53:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243823.421888; Fri, 10 Dec 2021 12:53:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfPF-0000jH-HC; Fri, 10 Dec 2021 12:53:45 +0000
Received: by outflank-mailman (input) for mailman id 243823;
 Fri, 10 Dec 2021 12:53:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QdnD=Q3=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mvfPE-0000jB-5q
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:53:44 +0000
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com
 [2a00:1450:4864:20::333])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34724459-59b8-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 13:53:43 +0100 (CET)
Received: by mail-wm1-x333.google.com with SMTP id
 j140-20020a1c2392000000b003399ae48f58so8929542wmj.5
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 04:53:43 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id a198sm2828488wmd.42.2021.12.10.04.53.41
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 04:53:42 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34724459-59b8-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=MqqlZyhoYH5VsQ1UfUV9Q7VMIcDmSWkliKoghQ+WXY8=;
        b=Uu2CVBSDDtiqCcV2JZyMktz3kVihFkZvv/BUEELddi5DpBhTb/4hNrWvQAvzJ+QAo5
         ejW1wXV+A8wmEu8g9/vtg+XMgYAmmcb38UyJfm2Tjg7JJCCXTQH9ySSSU0GzmeWxN6D9
         rBCBjS+SH2gilLL2twDogsYUNrzJuvPCEQqQnyuONGw7a6+XQMTPrDTuHP0q1FB5FxuK
         IHw+DxQZMYkxgrRGHN5KZrecWYj8zvRisQ091hVQenGn9kLfPDqvCoCAzz2MHrMgVk2y
         nZxgiQYvJhpZk/7cIhlzWQRNgnlWM32dgcI22UntDuVysv/X/GicCviKzmMfCX/5X6hl
         d7sQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=MqqlZyhoYH5VsQ1UfUV9Q7VMIcDmSWkliKoghQ+WXY8=;
        b=ctD+3oe4caluoWIUcsYcYa5M5Nb2L3tt4PXJSOqjJhBY/6LtyEi/UVBHF2h4S3cRoP
         9xAVoe9BjNjwVOsKDkbgPaykTUGXm9PShKKjLU06jbj3LyqDIDkE0FP+undU2XlXnqRc
         4RGrT9uDRdtFr8seVtwQFULBEcU7WgzApadOok1LHvexmHpAQKMBBe8Ep8WLusxfYwdN
         9U9nx1o7qb9x83F6n3SQ1ohJJCZ9nbiGGqpwJOjMF3npe0IIN4iRV8B429j2KH2z9aG1
         vjbSAMfXXwSj7vYw2Agdthmu7h2+pTfva8TJYFVKzp2Cgl0DE8t0IWhSLsPCQ3YsB3Fl
         GsDg==
X-Gm-Message-State: AOAM531IVcQqMajcEPdhiTNxGXxn9PUXfJgsOEhKnAnvFseHrmtoKQNC
	6iXFMtwA8ORbPzWgtl3rd38=
X-Google-Smtp-Source: ABdhPJxR0IKIiLsfKlqAPZWx5GbQPSBiE57jEJL7d1waZI6PXeWRX1nBF8NjOu0HzHr3xinKsigJIQ==
X-Received: by 2002:a05:600c:3c8a:: with SMTP id bg10mr16451734wmb.106.1639140822539;
        Fri, 10 Dec 2021 04:53:42 -0800 (PST)
Message-ID: <1a32f152-2d87-4227-d316-14f47daf31ac@gmail.com>
Date: Fri, 10 Dec 2021 04:53:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: [PATCH 1/3] x86/HVM: permit CLFLUSH{,OPT} on execute-only code
 segments
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <53d783d7-aa53-f2de-6aa3-bd266f176dfb@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 03/12/2021 03:21, Jan Beulich wrote:
> The SDM explicitly permits this, and since that's sensible behavior
> don't special case AMD (where the PM doesn't explicitly say so).
> 
> Fixes: 52dba7bd0b36 ("x86emul: generalize wbinvd() hook")
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:56:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:56:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243828.421899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfSJ-0001SP-4j; Fri, 10 Dec 2021 12:56:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243828.421899; Fri, 10 Dec 2021 12:56:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfSJ-0001Rx-07; Fri, 10 Dec 2021 12:56:55 +0000
Received: by outflank-mailman (input) for mailman id 243828;
 Fri, 10 Dec 2021 12:56:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QdnD=Q3=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mvfSH-0001KR-PQ
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:56:53 +0000
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com
 [2a00:1450:4864:20::333])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a575a1b3-59b8-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 13:56:52 +0100 (CET)
Received: by mail-wm1-x333.google.com with SMTP id
 p3-20020a05600c1d8300b003334fab53afso8939729wms.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 04:56:52 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id a9sm2568872wrt.66.2021.12.10.04.56.51
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 04:56:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a575a1b3-59b8-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=K1skKFn6ZFJBwrjJmG0QjAN12BDBHj7aa+LG3YPoTjg=;
        b=hMs5QpKsUWFX5UZrNyuGv0yISbJqka9aNypPEqW2MZtmUSzcmb/tWdbOT2hFTo1X5C
         8eMuRl+DjncR5h6PZ6ZfXboO4ZO+jepay/ATI0pac3GzwQQsEDSN0vUNkXIEXMYHXHid
         uqLlt0I4/JPfpdj77dXyL1poJAyioHLnL7QyXinxkSgQ2ND/VQddgUli1PzdO04+fSoB
         P30pTCmzTvQlM69HTFORZcEuSXJZDS3fh28sUassAKB9yNnk81NWH9tAi8yg3DY6kpbf
         cXPomchGQxkhY+sW6cmBrIEDlch1a9Iz/6pF1g8Oa3TdyMfsaO6kzpcolFB3AhVPUpU9
         aWXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=K1skKFn6ZFJBwrjJmG0QjAN12BDBHj7aa+LG3YPoTjg=;
        b=J941TT/hHtE1szlXBKLv+xKSHZ6vVVKrPqS0ReP8Yq6D8IH9R7rQpFjhTwutIDNROC
         VtJJKgro8k9vWMC49aXBB82+bBGr9VPol8n58fok8KOjNQR24o9tBK+7YOr1A5UTmcIG
         YYygqkRwAiANhF9o6py4DWS+aslITnkZLMrK/VNcqLYfuyxCQcKd9DPlquSeLXF4gsTs
         +3ai+wMQBBMiHUDVsVneY5rZOH7LZ8X/n2FYuz0mJjNTPawDGtyTC7+ILqfHj1MInd6p
         WFlTUvVwu+1ghAye6zCRlhbA/swuiZYc6OcVwPoyqOEBdn1VtVAXDjrzumK2fElQcjHo
         DhqQ==
X-Gm-Message-State: AOAM532v56xYfJyy4OZtnNeUoA2dTT6vYHCWRh3YQUqexBup9mZA1ASl
	j7GrzRGyICNMCHy5c+9IEbj5+mLuYwE=
X-Google-Smtp-Source: ABdhPJytSuNJgd7C7fyAmkpeaUfDzmWNskGVxhMkVt1KebCODdV2bsZPzLQJHh/VtebhmPGYh7OFHg==
X-Received: by 2002:a7b:ca4c:: with SMTP id m12mr16669547wml.119.1639141012456;
        Fri, 10 Dec 2021 04:56:52 -0800 (PST)
Message-ID: <06502ceb-6f39-7ea3-f2a4-2e6f52827015@gmail.com>
Date: Fri, 10 Dec 2021 04:56:51 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: [PATCH 3/3] x86emul: drop "seg" parameter from insn_fetch() hook
Content-Language: en-US
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Paul Durrant <paul@xen.org>
References: <10c7b3c0-c64f-3d12-06d3-8c408f7c9f4c@suse.com>
 <53cf0492-e197-d3e6-8898-9e199bbc5399@suse.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <53cf0492-e197-d3e6-8898-9e199bbc5399@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 03/12/2021 03:23, Jan Beulich wrote:
> This is specified (and asserted for in a number of places) to always be
> CS. Passing this as an argument in various places is therefore
> pointless. The price to pay is two simple new functions, with the
> benefit of the PTWR case now gaining a more appropriate error code.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

HVM emulate parts...

Acked-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 12:59:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 12:59:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243835.421910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfUU-0002Zu-Fa; Fri, 10 Dec 2021 12:59:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243835.421910; Fri, 10 Dec 2021 12:59:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfUU-0002Zn-CT; Fri, 10 Dec 2021 12:59:10 +0000
Received: by outflank-mailman (input) for mailman id 243835;
 Fri, 10 Dec 2021 12:59:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvfUS-0002Zh-U3
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 12:59:08 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5e9eaab-59b8-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 13:59:07 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-bfxs38U6MJiTyrfvPVGpAg-1; Fri, 10 Dec 2021 13:59:06 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 10 Dec
 2021 12:59:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 12:59:04 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR06CA0397.eurprd06.prod.outlook.com (2603:10a6:20b:461::8) with Microsoft
 SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 12:59:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5e9eaab-59b8-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639141147;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=txJ9CIfL6k9DXHvkB8HDTO1ZVOUWN3gLCjvnciajTEw=;
	b=m4R47I0ZsRG63SaACb/cQvCD7IZk8KtZ1PL4M/gMEreBUKhpT5sF4C3Yxn+dLzH2mS3TKH
	NZr8VQl05p0/sJWFMeJK5PTne8cCdxsxGsK910FOVaLT7HtKj/SOq+RUxC5aYxuvrO74xC
	FYA6JQAG5SGEhT+evZnsY4BkXJtbu8Y=
X-MC-Unique: bfxs38U6MJiTyrfvPVGpAg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gzhPqqPEswQaApaS1Wxiytlaon6WjrCqHtc4rZ6AohxoRihGTloO6OnWp7udRusZraHhhGaMtrT3RvMb3repyFvV0dBHGDbHpHJ8zgKgxmVXTCrKJkgY4jxHxRuqIBQ1WIG30CkZonBL5wcB+V7nX/jQ4iDoztClOxTah2zs0IfvoX538BC4uYz/Mz3HZgVRc7clmTCXKg6sVwQ1YBK1J5X/KAmP0OOJBTRgHE7eujzSysBrhk/m1YWIMPQElC9GASwbD4xo9vUu0jPdP0yan47y16Sh8YgFBAMDK8Nl31hPISetQpvyLYjUsJeVEE5NVRDn8UtpXM9RJkSX3UdMrQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=H5SQvSUTE08HRX1K3p0iFyW1h91xmLmURncx5MpE4Ms=;
 b=oMJ7MZWyRsboNr4bkej/oaUJr0bptD3VdpvoQ+JmflzfJ07Oi2NGMVg3bOTL1JfiVpsEwycIJje+c2jIdIm2TuzjRCjtUz8QMz+WyhHbxfn+x/avu9IGtB0ofRNHYVbRfiLHwF5NqQGRF+if5CBk4IetoMrhwJfG1uBnq8t24dLoWE2Rpa3G2Pk7BshXezeAKknqPKGSDW1VSNxoDla0h87deT4BGTlKIfx5NCKSUQ5yjZzeZ5Z1Ty8nART5VGtMXjpsPRf4yhdzKOTyNWZl/wZWkuP9oY5mBLQx13IpQDUtrdS19iy2BdeQuO+aBDRHBAYUqvo1eCP2EwPxdXJImg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1fe2b37d-b898-c86e-dd4a-482bff9597db@suse.com>
Date: Fri, 10 Dec 2021 13:59:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 11/18] AMD/IOMMU: return old PTE from
 {set,clear}_iommu_pte_present()
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <33819694-2787-4bd6-1830-6b4eb81cb4a1@suse.com>
 <YbNCpA1PDtINnn7j@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbNCpA1PDtINnn7j@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0397.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9119df1e-c877-4e66-d426-08d9bbdcd830
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33924A253794E3C96332DC67B3719@VI1PR0402MB3392.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LFM3vs6biqu2Y9sgF437areEV0UCvZxroUF9IOZY+LXKAJrwfoVO06QhPiH7eFHlqMnn6NEW7el65WyHy4QKcAHv+ZUSFXm1Q+RVq3/MoVI9ly8bgRufHyyv+4AnDd6jQLmCH5oakDESQjCypY+ZxJyve4JO0144+ced+kVr2nyTxp/JO+PHMgtCEgq+M8A3lvy3uoDpXlUQRPolioM/QnNvuImxGjyc+zMKctsBf+vdaQZgh9CnlEh1a5SKZU16Ycmf2A6rnumbeach196V3ZB8LcRsSmbF2x7C2geuoLfKUJS3IrCAixkgQ/Zt+2hcBF171DX9SAVudvJlumIsAb4+U9WB6Y1V9kqUYZeBxG3eMJumEG9G+UUw/XmrmJ13voKIgvdvX4BALHyhKXRn891YmVnes49wvE6YYhGpaKLUGyEkTllVDFf4lyk102G3O7c2+Y+vXUgBSyqT5nEhx8BDVG1flrWA5ERxw+hAO2so5f43/uSXmXEAt6lLAxWdSz2sLF8DUuNmvinTx3xFPCFq0PxQIsmFyrrhaHDjypf/DB/i7WJp+64EuybWFdVXfLxQne2gU7TvJ2uwR6xVkd+iVQ5zlNNYImGk5ccU99EHZZxLff1Q4tSGSzBVo+fuizn9QVTvaglvD1CPl9d6atllgou2sAV/NIHYVPRNDIybPyYe4oU0+J6ZDslan5L9m2egi6zM3qfu21YCljAuBgP53F641yCnee7MGtIfqYQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(86362001)(31696002)(8676002)(8936002)(5660300002)(6916009)(186003)(26005)(31686004)(66946007)(4326008)(956004)(2616005)(83380400001)(4744005)(54906003)(16576012)(316002)(38100700002)(66476007)(66556008)(36756003)(2906002)(6486002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3RxdKyI9S700hv6QEpGowuxYtipHAB1lWrba34E7zghLzIjmAlUiuUIrb7a7?=
 =?us-ascii?Q?y/ukyVat++896pNxEqAkTrjCqFsMiPg//OubfNO6kbk1u2XoiEkuBP19KIiF?=
 =?us-ascii?Q?x5dsFqVRrK/2kKI0abWiIB5YgIulKCcpoLIWPGluPfHtqf0ixCrXLRw8H/eb?=
 =?us-ascii?Q?0WL74xOLCIw+S4dLYh9JPtMr/RWpglqz67NPupEYYjeduyRcVeNO5Nwg1aIW?=
 =?us-ascii?Q?QwlgGwQ4rWeJ4zt4xCE8iXVBzJGsiuZpVkPeDBteb/tV/mInDiD0StdWW9sQ?=
 =?us-ascii?Q?l4XoktCi5eXRB2NIsYQR3WHVKrjD4c+0eun7RgcCQ6X2HRi8Oe/kV1neurtr?=
 =?us-ascii?Q?l0QUzl4RLpXNyPKUKjjfvy5QYw6n7CPbz3gD7ea5jnoJxcbckNHR+P+Q+gMA?=
 =?us-ascii?Q?XRNYm0/QzfIWwkU7aNwP52Q8nh9JJgdkhoZzacuxRxVlNjqbBPD/j3khsDBi?=
 =?us-ascii?Q?BmPeKdvblk78VXdaVHVqul1er59l1PQyiE9pv2PcqwgxHXnGG2+TONBTeyqJ?=
 =?us-ascii?Q?VurjXWeidClWIJ/PebHtYrP/rbGHvM2tM04MHWxl/bn6EdHenMHhC/irqV35?=
 =?us-ascii?Q?+8UV7gP3axijUxtfb/RDAnEbDazJtoACXkxGdpXTXsPUSchKnWCvH6Ij9CB8?=
 =?us-ascii?Q?V3ZEz7TwP/nLAX8NKbvLqEpNfvYhgJaDUPIXaBJT9/mCfS/UpelXH1hZErqC?=
 =?us-ascii?Q?xdckr6nlM1LwMon1W6nvPooJyT89KMXlmUcS5YPBKQ3207i/DEOsxS1qNzeo?=
 =?us-ascii?Q?hhppkG6Ae+C9jEQv8eYRQRuoQiXV/RPTxs5rCOgwcU0qQEdxkOoyDsc5Yqwq?=
 =?us-ascii?Q?5tJQJ7kuklfaSue3JJ4rDzXleFrmVgvmUv+u26k2OOWAhYqoMojJ2WHBT18e?=
 =?us-ascii?Q?E7zaiCmLc8zk2T9CV5hXaJaL2Ih2znt1H7S+zpySVuwM3uVN0HyLJdb46O+1?=
 =?us-ascii?Q?mzAwoGwKUvlIhK8ZvdEmZw94ugMHKkpThCHsiPCYEeBx/Ie2rDV4jN2FMo+e?=
 =?us-ascii?Q?cROYjHRaSfW7eigGWSmGN0jtIBCHEV4tGi76AkCaigFetiOVWcfK0anfRJYY?=
 =?us-ascii?Q?kzNCtaZZPdZ5T5iFG22eDqylf+6csEywcIqxPlih7nPKuiIH3lgEVaC9W3a+?=
 =?us-ascii?Q?peoN6KeMUB1y7onu5oAxOkZghMz0fgsjLoUetmMZPlRp3DsyA5gict4v0cxB?=
 =?us-ascii?Q?pSHa4XCMz0h6+Fjb6vWGYkCVQ0+MXjhg/+iQzx731c8vqewwgNceGpuJRo9Z?=
 =?us-ascii?Q?w2EI9k5NqBNKRwk/DGyS4JLdVSImAMAaNv26vdGwjUhnQ0a0bXLsurDC/Xkn?=
 =?us-ascii?Q?6jUNHvh1TtUo+KXmtz54/fZ4KNBQCRUQT+dyuZIAK4j6WxKkNaw/jeUZToNS?=
 =?us-ascii?Q?wGQQJFexZqkd9rzSNu5xLQzM2CG5I1eF0b0I7WEQS1hW0Vhch2DH6vatvi6h?=
 =?us-ascii?Q?cJW4IEv1+cNiYUTUiMpraQ53bFfmq9fW+mAXd4jw4Xkhp3za/MBAC7szEg6w?=
 =?us-ascii?Q?0N32U1UFSU5j18vuFjvBEpcFySwRqUc2aabwZh9Rk+w7cayHQ0E50LzDEpJe?=
 =?us-ascii?Q?4djU5q1gJ0Yd0vmiFHi5UhXC/wFA6kBZhyLqFbn1uL9Jzgo3ZJ0nKdxFB+iG?=
 =?us-ascii?Q?0JItiq+mDvTBskP/X+6CaVw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9119df1e-c877-4e66-d426-08d9bbdcd830
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 12:59:04.6152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UHFKfSqDQ4lgCjSTHfX/73UMt18oCz3O/yA1hjS2W8WoJDiKvVQCf25ROS2shajYZzk9cqXOxH+x7APBwWASYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392

On 10.12.2021 13:05, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:51:40AM +0200, Jan Beulich wrote:
>> In order to free intermediate page tables when replacing smaller
>> mappings by a single larger one callers will need to know the full PTE.
>> Flush indicators can be derived from this in the callers (and outside
>> the locked regions). First split set_iommu_pte_present() from
>> set_iommu_ptes_present(): Only the former needs to return the old PTE,
>> while the latter (like also set_iommu_pde_present()) doesn't even need
>> to return flush indicators. Then change return types/values and callers
>> accordingly.
>=20
> Without looking at further patches I would say you only care to know
> whether the old PTE was present (ie: pr bit set), at which point those
> functions could also return a boolean instead of a full PTE?

But looking at further patches will reveal that I then also need the
next_level field from the old PTE (to tell superpages from page tables).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:12:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:12:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243842.421929 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfgu-0005VB-N5; Fri, 10 Dec 2021 13:12:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243842.421929; Fri, 10 Dec 2021 13:12:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfgu-0005V4-K9; Fri, 10 Dec 2021 13:12:00 +0000
Received: by outflank-mailman (input) for mailman id 243842;
 Fri, 10 Dec 2021 13:11:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvfgt-0005Ux-3n
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:11:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0f5c077-59ba-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 14:11:58 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-qqQw9l26MBKMpBmJ721SDw-1; Fri, 10 Dec 2021 14:11:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Fri, 10 Dec
 2021 13:11:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 13:11:55 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AS9PR07CA0013.eurprd07.prod.outlook.com (2603:10a6:20b:46c::10) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 13:11:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0f5c077-59ba-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639141917;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=NIgRq885eRJJwq0chVRIWHi4lkmdLRe+pMw/ZXiNwIY=;
	b=bikHoMlNXKwyXlOJbVQK6JSKg82nGy2K1XXjqTkaCfAdVKi3711bLoZJeenI69s+X4y7Qp
	GxABZFrI8J8FmteD7oM+qSO9daTMYIWTV9S3v9b3LWq/8kx41t7e1pkyxLK/lYJ7Ayn1Ep
	np6zQ2I6fyuhDvft+gEdUOghOPSwo6c=
X-MC-Unique: qqQw9l26MBKMpBmJ721SDw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Au2WrLVUovDiaHq6s75yPHTEWcuTpllDQ6WMRgLObLYEJSdMVIB6aJZzIf06BkPw2/kkv+l48z2X7q3fZglXu1oZdbqGL7g1Ii1xArEFnenS+Km1fqDfo1pIjzE2H3e8zpPG6RlMyrLFXphnCTbRYpNbiEUGjPlpf4KXElWxj6SiEnbSPBGoKQp6U7BtDiJJG0vrJCwi3DbSpAQ7sZaQB/cAPctouZexfSjOn+6731luo4jfzSVoN1TjvH4XpLzrC0GgMs1kEDaLWNu1t4sdzAyiFlUEq2GFc3N11wAauKKuZybdBwzp3qMH5f1Ljxtphf+ClfWLF9gI4rF4kaLJag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NIgRq885eRJJwq0chVRIWHi4lkmdLRe+pMw/ZXiNwIY=;
 b=QulPQKC3rC2rqKUf4pzrNCw773CQLstUS9UM0yGc/QLt/U4MHVfoAZSMmYb+pKGXQ5522d/fNKclhoqVgqMIUYaOL90Qa0DWdBlB3sTS11Sopi4UkfHpf7YySGNlyL8F1jCnlYjqIfGXM7tgBP9N8XbHwJw3708Cy9A+6d7x9/vBhX1mtCNVfv+noOY0RsRm6DSZMIQQHb7k/35Z7EypQT3xr6vWitjwYRosNE5kSadTntZ9Tz7KeebkdKgQvHz1JacJqtCG14T4Qz+lIU/HFkQ1oQMTTywcz94dqFtRmeyqThLi49by/jiOD1rj31ZB1PRwK5l/M+LImmDUeNWb6A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
Date: Fri, 10 Dec 2021 14:11:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2] libxc: avoid clobbering errno in xc_domain_pod_target()
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR07CA0013.eurprd07.prod.outlook.com
 (2603:10a6:20b:46c::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee446aee-c12f-4515-aff7-08d9bbdea358
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2447D84C36ED50CEA8F649BDB3719@VI1PR0401MB2447.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EHqO0khfUijBYrqSTgD4c5KJbdabEiFczjPTuVZxmkKh+QTwGlclwHvjpdEz5KJo205U4M8FYqinrmqGDdj1Efz/KgxsOrhL8f5I+itJ2hiZX9Z7/EOzMF4oKHN4721Ab3b1tOQ7oNKjgSqtMbNeQ3h9GPWDaoM8/0yOjY3xQHezSi8qqG+DMRfhqP5oj6W3iJKj0ZKv7FXDsBXn+E0D1kjOC4HAv6IxL83EMnWZQpeU67YG2yjtGwOWLFlByZVFPv0SRW4fABYmoyPRSeJcLxcsSwJoS1dgjC1KN68vB6gTnVgk5c8Lz4Knqp6NSTbFOS+Dpd+zouq8fDs5HufRDTrltdgd9DMqY7xwwDAcrKWnEMYrzLAK21wf7CFY/wdNmjslqppmCSsUvMltaIIh+xYuPs4VUUK1Diz/7dX55bZRYdt0JyT8UDTIDWkoiozTN67Fp9nj2ICUdbMgOJyUudMbAT4RPXN1LjERwVm8n8zYt2pB8XJ0JbfeprYdbJStbimlM7l7xKTUEkiGShER6PCZVpb4jRccHr6mzwDLMKmw/aH0WzwLL7xahMzDJ19NbLU9si2R9JOTt3lFKbEwsGBr4IR9MXM6ARhY/b3orshciUhUBTzpZjZv+iaKBRE2DjwroSSOr4acEM9C5LmpJOscJyXN/n2J8nIcUJ0QNuVhcsfxFkuP4pFwkGimvUHiiopZB9ge5eVTS80AYRMDvIxBm27fAtudrMi/B0+j20IJxYyXMvZYTBGfP/XtqOWV
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(956004)(36756003)(66476007)(16576012)(316002)(38100700002)(2616005)(66556008)(26005)(8936002)(66946007)(508600001)(31696002)(83380400001)(8676002)(31686004)(107886003)(54906003)(186003)(86362001)(4326008)(2906002)(6916009)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ekhKN2N4VUI5LzVqcHVuZXBqN0hWdk9jS256OGEvRmNwcWdjai9ibDZnLzc4?=
 =?utf-8?B?ekJwZ0w0bE9hQ3B0YXhubFhwbnNyWEo2dGlFelZlbXZ2ektxNmY2R0JQYTFZ?=
 =?utf-8?B?L2lXdVhWTG13UndoN0JZT1QydXRaQ0pWMXZoNjlxYW1VQW5nRDN2dTljdlpJ?=
 =?utf-8?B?VHArbjgwNjRWYlZLNlM2WEJ5TDREczZOc2tMM0VIVkVETmFVYWQ5dnk5K2M3?=
 =?utf-8?B?RjAvbjFaR2FpdVN6aDRNN0hwZnFJWkluZE1XYzNLWHBtSXRNa1NBZVBxNGho?=
 =?utf-8?B?ZHFzaVp4ZDY3YkdLNjRJQ3NxTUhwdkVOcWNGRm8vMHpPUEpiOTlWY0RmY3lu?=
 =?utf-8?B?STRiM0lOblFic3Jxd3NKYWhoWCtNZnJDYm9aVisxbm1xRmg0aFZ4RU9QQndG?=
 =?utf-8?B?UExVd0U1QVVQMjdzSm9McWtTdE1zcVpTVE5NVVYraU16UXZGYVI3SVgraTRD?=
 =?utf-8?B?c2sxZE5va1dXaWVob0FtMnBjRlRmZWp6Y0UySk5IbFF1ODZsUTdaV25WRURS?=
 =?utf-8?B?OXQ0Q09vTDZBS0dGaEJ0a3JZZWhiRnozUmxLTzN0b2V1Sk5MRmZLUXZOVCtk?=
 =?utf-8?B?YlJaZ3Y3YlE0UTFhMmNFV3hhNWZRODNUOE5xQkZLdEVVdjl4UzVzbGZlSkZW?=
 =?utf-8?B?eThVSkY0YVJ1UDNydG0xV2twV2F3aGJMQ25mMHZqajF5K0JPaUd1UmFxMEpW?=
 =?utf-8?B?enVuazRkbHl4RFJyZzUyUXhoN2FtTDRwdHh2VmdlYWNYRVMxQTQvK3JBcXRo?=
 =?utf-8?B?MENpQ0NuVUYySHhmbGFPUVFJbjR2NEtzVWhZTU8wRnZ3a2hFbStkNHJDV3BC?=
 =?utf-8?B?ckpUdkJCTHhTeVlBUjBBUWxyM1h4aXpaUDVqOEFyNHFRQmhFeVl3clVORHVC?=
 =?utf-8?B?a1c0TFhxckVoa0pjM3E5TGU3YUg1bXE1b2R4cE40WFJTd3lsWXpIRXdRd1JY?=
 =?utf-8?B?alpmNG1ucFFCMDFja2YvbHZjNElua1FxVGZqVGxUTkhidWhHTUpkcUh2ZHBj?=
 =?utf-8?B?WXhSL3pac2VuMWVxS254SDlNQUhBRnEwczZuK2s2WVdFcTRPeU91UGNzZURF?=
 =?utf-8?B?OUN6TkMxMGQ0T1RadDAzZ1VKdzFmb0FZd1RlSW0xcDFaQnJHNmJ2c0owR0I4?=
 =?utf-8?B?TkF6aWQreGVQbk0xTkNzV3VUbUpFWHpBTmdHVTBpU1dOSVIxZTVsb2h2Ykhv?=
 =?utf-8?B?OFM0aXJWVGJzVm1ZbHJzWXBLQ3NDQUlwSTdrUUYyYitjSDBoQ3YyZ1Z4QlBp?=
 =?utf-8?B?TS8xRStlVm14LzViNGJYejQ2cjAxSUpweXFGK3A4NWhSSHBhVFN3eUFuY0M2?=
 =?utf-8?B?b2pIalkxK0F3dWtwME9EYUF0Y0Y0SFNSR0NPeHNZZFg5RHYvMkZLMmd5b3VR?=
 =?utf-8?B?aDBBd3JXSTNNQy95SUxQb3FFdkszY1dQNFFjK1EvVVBaTno0QTI3am4rRERz?=
 =?utf-8?B?T3RxZ242VTg4TEx0Q0FpOFlVZVlWWXA2bTdGOFFKWFhnM1UyNEJKanI5aTFO?=
 =?utf-8?B?eWRZcXRVZy9kRUk0TG5IaWd4NHM3bVRySDhYUlY3MU95UFpQNWlGT1ZZeDcv?=
 =?utf-8?B?dFlLYWNaY2JtL2tzZFRXZnNzL1VQenUzMXM4UW1pc0gyWEF6YmJ1Zmp5Ynp6?=
 =?utf-8?B?UzFBbE52c0RSZVYvZDI5c0F6QXNwbEl3SmVwU1JNamRrQnBKdnlYYWlGRHUw?=
 =?utf-8?B?cjlkRnRIODEyenBNbVljYy9RTmc3UW5jM3ZHN3QrWWViaXphTkZWWHYwbkUy?=
 =?utf-8?B?MmQwUmk4OW9iSWtUSkNNeUhrUlRYZ3Q1Ky9scFg5NUsvUVJoQ2htMCtXdWxl?=
 =?utf-8?B?dkp1YlpTRnA1bTBLcVNxaXBkbWoxZnlUK0VuSkRSQURuRHpnN2kzT2pSNmpx?=
 =?utf-8?B?OFI4WDhiRkg0ZDFqeFlTdkNjaDZtV3RwVjVEdW1BcFk3eUlyamFrRkJxcjZF?=
 =?utf-8?B?Wndka2F3QzRVbElMU1RQdmRJczlDdFRvWnJIekhvc3ljK0JGdXp4V1Q4Z0RR?=
 =?utf-8?B?YTFyOHArRTZQVXZRRjM3THVNY09GOC92bjhwTTZjSG14RmJHNlBOdWJNYmpG?=
 =?utf-8?B?Z3gyRGlkVlFGNWRocUpTaG9XbmtzRzlkZS9EN1RHY1d2UkNFTXJEbU51dWo1?=
 =?utf-8?B?dWJvU1hBRnpHb2pyWFh5MldIbVNEMzRnR1orN2JPTEVKTG1WUlc0ZWF0ZW90?=
 =?utf-8?Q?3MlyPASiSXBm1BQqeN0QjrU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee446aee-c12f-4515-aff7-08d9bbdea358
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:11:54.8627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 39yMXKz0QEaFCHC8Bd7Vy9AhA3y5UuSDE/qAlBt7xsvjWU3DxzBBc5hcuqg3P/sxGJ1CwtDxDNhZvS9szApyaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447

do_memory_op() supplies return value and has "errno" set the usual way.
Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
also no reason to overwrite "err".

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
While the hypervisor side of the hypercall gives the impression of being
able to return positive values as of 637a283f17eb ("PoD: Allow
pod_set_cache_target hypercall to be preempted"), due to the use of
"rc >= 0" there, afaict that's not actually the case. IOW "err" can
really only be 0 or -1 here, and hence its setting to zero may also be
worthwhile to drop.
---
v2: Don't save/restore errno, as DPRINTF() already does so.

--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -1230,13 +1230,9 @@ static int xc_domain_pod_target(xc_inter
     err = do_memory_op(xch, op, &pod_target, sizeof(pod_target));
 
     if ( err < 0 )
-    {
         DPRINTF("Failed %s_pod_target dom %d\n",
                 (op==XENMEM_set_pod_target)?"set":"get",
                 domid);
-        errno = -err;
-        err = -1;
-    }
     else
         err = 0;
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:14:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:14:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243849.421940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfjn-0006CR-9M; Fri, 10 Dec 2021 13:14:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243849.421940; Fri, 10 Dec 2021 13:14:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfjn-0006CK-64; Fri, 10 Dec 2021 13:14:59 +0000
Received: by outflank-mailman (input) for mailman id 243849;
 Fri, 10 Dec 2021 13:14:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfjm-0006CA-Pu; Fri, 10 Dec 2021 13:14:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfjm-0006Ac-Lo; Fri, 10 Dec 2021 13:14:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfjm-0005XM-CX; Fri, 10 Dec 2021 13:14:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvfjm-0005kN-C4; Fri, 10 Dec 2021 13:14:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xlCyut9VFJcm6EqdlUdgjQ9Ui5Q0Q6jFNw95LDGZIx4=; b=HMhXohmkJskJG/O95UFgyowxWl
	ZpvWaghXP25YiXKFZtrprduOGRg4wQdCg+ejnTi9G7KvA6RnAChyuAu1d7vyxA3DMqFnNaJa4oeFc
	gBymANsXtue1qIsqPI5owCccOReHDOcKNmAuAFDsEGW10mx4EMPUYVqIn+SbQUSaGvD8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167340-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167340: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 13:14:58 +0000

flight 167340 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167340/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   29 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:26:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:26:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243857.421953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfua-0008LA-9w; Fri, 10 Dec 2021 13:26:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243857.421953; Fri, 10 Dec 2021 13:26:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfua-0008L3-6w; Fri, 10 Dec 2021 13:26:08 +0000
Received: by outflank-mailman (input) for mailman id 243857;
 Fri, 10 Dec 2021 13:26:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XN5i=Q3=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvfuY-0008Kx-Sk
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:26:06 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba24e9d0-59bc-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 14:26:05 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1723C21108;
 Fri, 10 Dec 2021 13:26:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E44EB13E0C;
 Fri, 10 Dec 2021 13:26:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 45LNNWxVs2HtKQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 10 Dec 2021 13:26:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba24e9d0-59bc-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639142765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=met4wKf+jsCwO9lLQ7XgBg9hUPCx8MsC/CKyn3D5ypY=;
	b=WaBLP1Nqfq3uDCaw7wVGxY7Jo0g/ZPxEwFPdc5bCBRnbSfzzISz1aOF8xLH4UfUwxfy55c
	5hxLMMxQZJv8Lqqp1Zma+IEsYMMKRePXL93z/ziljCpYWXB/Av7Z9fC5y9T7gGjsVgCXkx
	jIUaOUeSD2Jd3YsHK4KxfcSxC6V4Axo=
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <9ee8e038-9842-b0cf-f8ce-7922373c3b19@suse.com>
Date: Fri, 10 Dec 2021 14:26:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="RBRPk4ELZeGXeU8q9WVOWqfpe6T5xQ4xf"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--RBRPk4ELZeGXeU8q9WVOWqfpe6T5xQ4xf
Content-Type: multipart/mixed; boundary="LbxenglrxAQmviTa9YbJTKYiaDrKtfza0";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
Message-ID: <9ee8e038-9842-b0cf-f8ce-7922373c3b19@suse.com>
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
In-Reply-To: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>

--LbxenglrxAQmviTa9YbJTKYiaDrKtfza0
Content-Type: multipart/mixed;
 boundary="------------6C15C594C4E6460188438CF5"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6C15C594C4E6460188438CF5
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 10.12.21 14:11, Jan Beulich wrote:
> do_memory_op() supplies return value and has "errno" set the usual way.=

> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
> also no reason to overwrite "err".
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------6C15C594C4E6460188438CF5
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6C15C594C4E6460188438CF5--

--LbxenglrxAQmviTa9YbJTKYiaDrKtfza0--

--RBRPk4ELZeGXeU8q9WVOWqfpe6T5xQ4xf
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGzVWwFAwAAAAAACgkQsN6d1ii/Ey8U
CAf9G20oN9jqJJgpJspPcmtfTGV6wbkbpfX1sqLYD3KQxmBdEcGrvSqWczZdhnkMlBGlirQEgNd8
/IHGdJXW92lax0IYnDpD+ekVmY7e8D6ZZ64kEQAgAwWlsSnIb8OdqSpsijj18Y8ECEuEVMjuIewS
DY/MgfLMLE8jXUKGe/RxEuADbucZyqnYi1v+5TeIMqinZcvpQCa0PzJPA9s5ELouHlhNHuVQZVID
e1SM7OD6mG7jAP0DCKunaOtCLBEHe59U8lOMiZeHlZNXwXgYP/N9uNnDYEpCFWXUUtJeZ8HxoVkw
fjIs8fyE7MGGGFzqDuNXt/IqknmMwMIdI33nOlqHOg==
=s+9O
-----END PGP SIGNATURE-----

--RBRPk4ELZeGXeU8q9WVOWqfpe6T5xQ4xf--


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:30:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:30:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243866.421965 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfyI-0001BU-QR; Fri, 10 Dec 2021 13:29:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243866.421965; Fri, 10 Dec 2021 13:29:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvfyI-0001BN-NO; Fri, 10 Dec 2021 13:29:58 +0000
Received: by outflank-mailman (input) for mailman id 243866;
 Fri, 10 Dec 2021 13:29:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvfyH-0001BH-6w
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:29:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 438b8b0e-59bd-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 14:29:56 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2056.outbound.protection.outlook.com [104.47.8.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-qSQRsdS7NQSXcIJuftErlw-1; Fri, 10 Dec 2021 14:29:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 13:29:53 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 13:29:53 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM6PR01CA0064.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::41) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 13:29:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 438b8b0e-59bd-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639142995;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NY93VtVXiVMr71kjwcRF6uBkuR6eqCnUDvyBMThNlC4=;
	b=N37heJic6OeXPjXROT6QRSWTd0dd6eUFb8L4pPpXQ5m6xQpTru42khDWmUdg2nPtQCaGDy
	vvgFbdjY1nwxwl9KeVrk1dhSxsryMnZt5u/8yAY5TPT6vj3fBl1A9bdOXD/TLaEUteYMhG
	T904ckq8OYzk/Ti5Zna8rUuQWymFnKc=
X-MC-Unique: qSQRsdS7NQSXcIJuftErlw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HMSL8+J/X9QfyKqyNJ3Lr4h2LLivEIduivvvMN5nbngs0omY68eohVMhtsog2JKZGCgFsiyYjevHdTkjTzjwTmvpxqVhZvP6xuUFAtkTDm26K/1aViJ27NUCRn6B0qIg34p++6/ST8eaD9tepTfsQwKMTbHxShHSJtFLKnXAvhUsLgfTftqoCwPzUl2GkazxATIV8UKgFt3wrzgckL1e92BliGTam+LL5Ed4G1Kc6EgDw2C37Yo/aTqd7ZOIQQ/SYaozMifW351cFG29yuPLB1/SZH4d1uAc3c4T/swJDI+ure4C/B4F71sR9Ob7qTXrI4X+feKg876/m6Adjrwhag==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NY93VtVXiVMr71kjwcRF6uBkuR6eqCnUDvyBMThNlC4=;
 b=kVHZ9irS5KtrRpbqyH49tpYBMr6nc6B+2qKhYpfELWmNKujIvxZaLpiB9RvSZXsEZcXSyhL67k1iQ0R+5euY7Rp4iYjqUewp5WepSQwYvAb/azTDypzaBdfIOvUFHUxTlLOhWrC0J5kxppkyeY7Now0lhanX9VmEreyJxh+jccto4ZrtaVteYd0zu2s+wEM0mFyezI/90WndInsXxANcIc4GBYcYwryA3DaDLkJFG7n09mwrAvMKY9y3JEiLtEsX91BoIZgrEjk1tVexP8FqzRtNr1tFTwWQyJkmhWq6HfNV5LNPTf1nwDWREdZbNRsqSubeTPRXFLSs2zO/Lb2Qqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <488943f5-572a-12ea-e74d-7a4baf38a94d@suse.com>
Date: Fri, 10 Dec 2021 14:29:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [XEN PATCH v8 23/47] build: rework "clean" to clean from the root
 dir
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-24-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-24-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR01CA0064.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::41) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 27b521ef-38a0-46a2-ff97-08d9bbe125fe
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB29595DAE3B577C2170DBC261B3719@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x20k57uiyRlSXzhmIOaYCD545Z0S+mc9lWoNkzTCIlK0EiQtnNNFYEQsKNndWV7yhwHmlSM3oaZpVnh85RKakOff/CbVwkIH5Bj6ZzTECKWBFlyfj7V2UDif4ingD9FPd/3EiTRi09eqIVWvulxmv9XJU+MoZ40XJFPqeS4s4PxM9ZZLjje8U1DnTgmvwBEe/u8aycP85Fu0a2rg/PUUNRRCHMiNqUTShFbi1jwvFWzqGdi3aXRore0NOl7iTCLSYC8qjaw+Ql/ybIXa2yO1OB9PJFwWJ4H6sPyEfYlv+alzHN3Pvm9iPqvoKiZzv7tqfl28NJ5wGLHS0h80No6gjHuWEc8G7yoaLYHsIiFSdOl2cu9yC4TiwfURPK1hZA3lQekC/XSyPcsYrI+dOAviVpkb4bryOsDDZAMYfHVJFlqGAyMDsLxhU9SikolZhKk77PwHrzm53oDYPBAVpgb/UEeLge/vWLR4sNgSgzaTr3vj1WfEk9mAzuqN9H1cyyd9JVzHhwLlhNyejoOYh7A5YZ6uOpMF3K779jJTWA1mxlrCGh53DWY0lsZZoEx4y2VBbfBGnxZuHdMMJ8mIuL2KOgK584gqVUk4ldJO1kFvP3TPSwDAvPMs2BdMNS6IpnCsZKRRba9S/MP9pS8U5tCWVwlqO/rJTLNd7Ioc1xVpRp4k59HGfrclbhsZ+gTeOfu6oUKKKmDms6LNsJlO0B2S/g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(38100700002)(6666004)(31696002)(6916009)(6486002)(53546011)(4744005)(66556008)(186003)(2616005)(54906003)(66946007)(66476007)(86362001)(16576012)(31686004)(2906002)(956004)(316002)(36756003)(26005)(508600001)(8676002)(4326008)(7416002)(8936002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TERsOGlCbEUxQVloZ2twa3h4UHpiQUgyM3M2NDd4T08xYTRocXNpamlDSUV2?=
 =?utf-8?B?RTB0bk5Ua1pibGFSTkZuSldYbFhxZzJOVFRrZHFXcnIwK0x3RzlZbXJldDBl?=
 =?utf-8?B?UmlHK2xhUXlZMWNyLzhuR0VNY1FXblFZSEl1TWs0UVZzMmhMdXMxUy8zblRu?=
 =?utf-8?B?K3E3SWlBWGtnWkVONGRNTTA0dXJNeE51dU43ZFpLaXV3R2MybkNQSHYxVkc0?=
 =?utf-8?B?c3E0UWpCdFlCZzlxZms2UU5lS3dweFBLUWVmZE90bVJlam1PdkhTdzBic3ZQ?=
 =?utf-8?B?Y2NjdTU4TGR6Zjl0QTZZcFRtMll2REZkOTRqajdEN2FWVFAyVDFSY0FzVW51?=
 =?utf-8?B?QnRPZWxQalJsWWVodWV4dUhoT240OG9HVFRVWk1jNFg3YnpqY2ozdEUxMHN2?=
 =?utf-8?B?K09ZdkpJSmVoTzk0MnkzNFJGQ2d0Wk4xa2Q1NU54R21EaDQzMlpieEJlWUZq?=
 =?utf-8?B?ZzJ4QksxOGwwYnlheS9UNHBQQVlHZ0xkT29xbC9ROGpwV2FLN1U3RkVOaXo0?=
 =?utf-8?B?aTZiSmkyVjRTVEFyUFJ2K0NYbFAvWU5XY0h4ME9IeWxvSlkwVzQxQ1FneDhQ?=
 =?utf-8?B?TlltK2FZWlFFckFRU29WOUhTUlBrUVhKQ3J3QjVTM3BGbi9OZDBidnQvMkhX?=
 =?utf-8?B?VzdpSzZOdEMzaVhiNWZBaWkxMDM2TUk1bStLcHV6RnJLR1BVWlF3WGxqWWY2?=
 =?utf-8?B?dG1qa0hEKzBOQzJjaUVHYTdKdTd3T1JSV1ZBbER1anI3VU9jUmtraGxUTVNo?=
 =?utf-8?B?QUozWXJoVENyNnoxQWJUdFR1NFNteVZBdmhWam9BUHFjWVBucVVDTmJmK29l?=
 =?utf-8?B?b2MvL0tKeTFGdENZNWJLeE9IYVlDMjdORGR1TTlLc0lnSU1PTlBjWXpGaHYw?=
 =?utf-8?B?MlFJQkt5UUpWdEEwclpic25JM3IzTE5rRERhRXBvOTYzWjkrTzd6c1ZFOEw1?=
 =?utf-8?B?NHA3NWxEZmVXQlhaMEdMVE5CbVVObTExd2EyYjBWaFgxRXFXME94SWRwbmV5?=
 =?utf-8?B?UE0zeVlxVjRwbHVkRmVjYWIvLytLdHhMV1VUOWtHcUdFV2tuR2llQXhzb3BE?=
 =?utf-8?B?b0RKd1FYZDU2YUFJUjZPbDc1aUpTZ3JIRnFQTkkxd1FMcEJOUEpNTjVvZ05M?=
 =?utf-8?B?SEROMFpWRDZyMEpsMS8va3Rwc1JyVjdxWkhkM1o2eitnNzdsclFwV25lZ0Y1?=
 =?utf-8?B?RGpaL3lnUWpSZ1YzUEtveXFDblFPbnJwYTZHNzZmM1BjSUwzWm5Zb0IvS21u?=
 =?utf-8?B?VklsdjQ1dURHZjdESllIdDZ0dVlEQjFkeFVPNVJVZzh3VGZKODBtZzYzYnBP?=
 =?utf-8?B?alo2UG1wZm9oYk5vS0svYU83UEtjbldnWVdvYVBFNE9BMW5KcmVQeWRRbXYx?=
 =?utf-8?B?Z1N3VXBiQTNWY0J4MlRraDJFaXhabHk2ak9xbWJxd3orWHZ2VzM3QkNFampt?=
 =?utf-8?B?bmE3cThmemorOXlNTVFVOGdFRHE3b1lOS2lxaE5PYk91Y05GWDA0NUtkWC9S?=
 =?utf-8?B?bVNRN082N1dIcW5KelhDN01LSEJEc3NDVUo2S2ZmQlNwUHBMTzJsVFN3V3R1?=
 =?utf-8?B?cG9oNDFmcUt1UUMxUVpZQWYvdm5TWEJERzZUdUdyT1RTNWtvcU9SeGMvZnpv?=
 =?utf-8?B?b3JyWHJZZEQ4eG84Um5FOU9KR3BLcld1V1l4V1hpQ3FZNGt2R0x4REZMOXlF?=
 =?utf-8?B?UGFmSVJnNHpVMk1OUGVyNFVqQVJheVJ2L2RxNWErTVlWNlpUNWtDaUJjVFd3?=
 =?utf-8?B?aFRoYllaSDR2WTNNTHJIci9lNlplWjdXTkJrVjRoVzZDNmZLRUVERnlzTWI1?=
 =?utf-8?B?SDIrUEY3cWZuTkh2SDcwdzlnQXVHbWtSOThoWWhXYjY4NUtyQ0pFcnMwY3RQ?=
 =?utf-8?B?TjFoakE1eWdJS05wQTN6ak1NRHRRZW9JcUoyOTVwQmV4ZkpPZVBUR2F3Wk1n?=
 =?utf-8?B?VVdzcExCSnNzQWxERzdUWS92dFVKcjNGc245eGM1RDdEZzdZVXl5UnRtdEt0?=
 =?utf-8?B?ZHZiMDByckVRM2NFb1VuaUJranlUMk9ma1JTcjZXb3hkSGl6Zkx6SlNLYkxt?=
 =?utf-8?B?Y0RYaE0wbHovR3g0b3dOTGVxNmp0SmwxV3hNaEJPTkRoMHpVMWdOQTNoNDdl?=
 =?utf-8?B?bG1kazcrRzlCdUxJblFlM0RIaGxZSHRTRGdZcHUrdkMwNEVIR3oybEpVcElI?=
 =?utf-8?Q?OuabcTFI7T0taLjA+MAJn4k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27b521ef-38a0-46a2-ff97-08d9bbe125fe
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:29:53.0639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hCRh1PmgCtyE7MBRg1xLgLqpZpGW77x0JCU43jMFqDnUIQD/5jETSR+40GWxsAMAdDSF5mDlBJoyS50WuhkEEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

On 25.11.2021 14:39, Anthony PERARD wrote:
> This will allow "clean" to work from an out-of-tree build when
> it will be available.
> 
> Some of the file been removed in current "clean" target aren't added
> to $(clean-files) because they are already listed in $(extra-) or
> $(extra-y).
> 
> Also start to clean files listed in $(targets). This allows to clean
> "common/config_data.S" and "xsm/flask/flask-policy.S" without
> having to list them a second time.
> 
> Also clean files in "arch/x86/boot" from that directory by allowing
> "clean" to descend into the subdir by adding "boot" into $(subdir-).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:49:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:49:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243887.421977 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgHL-0004k0-B3; Fri, 10 Dec 2021 13:49:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243887.421977; Fri, 10 Dec 2021 13:49:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgHL-0004jt-66; Fri, 10 Dec 2021 13:49:39 +0000
Received: by outflank-mailman (input) for mailman id 243887;
 Fri, 10 Dec 2021 13:49:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a5or=Q3=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvgHK-0004jn-4H
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:49:38 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0205a017-59c0-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 14:49:35 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:36070)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvgHG-000xIY-6u (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 10 Dec 2021 13:49:34 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id EA3EC200D8;
 Fri, 10 Dec 2021 13:49:33 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0205a017-59c0-11ec-9d12-4777fae47e2b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>
Date: Fri, 10 Dec 2021 13:49:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
 <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 10/12/2021 11:16, Juergen Gross wrote:
> On 09.12.21 18:07, Andrew Cooper wrote:
>> The values are already available in dom->{console,xenstore}_pfn, just
>> like on
>> the PV side of things.  No need to ask Xen.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Wei Liu <wl@xen.org>
>> CC: Anthony PERARD <anthony.perard@citrix.com>
>> CC: Juergen Gross <jgross@suse.com>
>> ---
>>   tools/libs/light/libxl_dom.c | 17 +++++------------
>>   1 file changed, 5 insertions(+), 12 deletions(-)
>>
>> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
>> index c9c24666cd04..03841243ab47 100644
>> --- a/tools/libs/light/libxl_dom.c
>> +++ b/tools/libs/light/libxl_dom.c
>> @@ -722,13 +722,10 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>>   }
>>     static int hvm_build_set_params(xc_interface *handle, uint32_t
>> domid,
>> -                                libxl_domain_build_info *info,
>> -                                unsigned long *store_mfn,
>> -                                unsigned long *console_mfn)
>> +                                libxl_domain_build_info *info)
>>   {
>>       struct hvm_info_table *va_hvm;
>>       uint8_t *va_map, sum;
>> -    uint64_t str_mfn, cons_mfn;
>>       int i;
>>         if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
>
> What about moving this if () to the only caller and renaming the
> function from hvm_build_set_params() to hvm_set_info_table()?

Because I was hoping to delete it outright in a subsequent patch.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:51:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:51:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243892.421987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgIp-000652-OO; Fri, 10 Dec 2021 13:51:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243892.421987; Fri, 10 Dec 2021 13:51:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgIp-00064v-L2; Fri, 10 Dec 2021 13:51:11 +0000
Received: by outflank-mailman (input) for mailman id 243892;
 Fri, 10 Dec 2021 13:51:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h5au=Q3=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1mvgIo-00064g-2B
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:51:10 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20605.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::605])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 38d2a71f-59c0-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 14:51:07 +0100 (CET)
Received: from AS8PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:20b:312::19)
 by VI1PR08MB4285.eurprd08.prod.outlook.com (2603:10a6:803:f8::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Fri, 10 Dec
 2021 13:51:03 +0000
Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:312:cafe::7a) by AS8PR04CA0044.outlook.office365.com
 (2603:10a6:20b:312::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12 via Frontend
 Transport; Fri, 10 Dec 2021 13:51:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 13:51:02 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Fri, 10 Dec 2021 13:51:01 +0000
Received: from 95de5ab20173.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 A9EE131E-C9E4-47D4-8CC8-5CB0CD52D4F0.1; 
 Fri, 10 Dec 2021 13:50:48 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 95de5ab20173.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 10 Dec 2021 13:50:48 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AS8PR08MB5991.eurprd08.prod.outlook.com (2603:10a6:20b:29f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 13:50:47 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4778.015; Fri, 10 Dec 2021
 13:50:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38d2a71f-59c0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wv8keQ3kUpPKIGej8rfrMI7eQyQ5bUkDwjnga82nFEY=;
 b=amjslSgqP1ho/WpG9Kz9oxfwamUEDhEtyW7RrXOUTQWtWw6nMfHM8MSD0p6ito2kVGiFq8oOuAG1tumct2gyghTeZrjqpmMD9Y9CYlqkPQcXJWUT7qakG4FUNAI8ktA3BJ3+JX9L4SkQebeeOyqXN4O4YOpvPRN+Yj9JNoBz65A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 0d4344fba6ea640f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VdtKy3QcXWtv+9v0oiEA7MX8/nY93/9WmBpM01GB6IEQDXZVNP5UmPUAEQWQ9zh6j0TsLTz9wD+PlW+t9EUQgp5plmj7ZGDeUe2GJBthqS3FDeHzuYVv6hFM+8kBFaIoYtp4vWh+DVSLdXj9/N/WBA8UjNk6r0Ux4QH9Ba6kHEsH/JaBjCbFJv1InAhSpnD4QP0wKQ9ohLTMUeBZsTNe1f0T8I8kJbAOvwoYHClgojgFSxLSnVjITYIAD0ee5bVnLsAmslOvAtkgG2cTEyCfX7vteDN8J9tyZeEyTx1f9LLxoy/D1pliLoVxl8SZtw0tVkIiV8iwieLRbSta3iAhXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Wv8keQ3kUpPKIGej8rfrMI7eQyQ5bUkDwjnga82nFEY=;
 b=ZNhfUEsDFgRdl1DC067pHLfYX99vdQ+1PUiqDgz8boVwezJneeMpHd9geRem1ZOZyVRUG/+XBxlWbKbqXqZNOkh30QO/TBrRucTspdM1KybFgH1gyfu6WKZsiRydHKj8+Np9CRGDzGi8KXsie/EWllkeBPkML0zEoerxpinPqzipSDhqlGveXdvuIBFnmbS/8BpXPzzf+2jKgjgVMawYkpl5smL5kEBVl5BwXMVlGiPykhBURkUuaiGGKvoEa0IH1KaAB4VNxGH/yC1gnuFgjhoaXRMyq2zJn8f0DuER0APnFCzxu7qJASErYFqw9/+KC2G/XwWK+5UWcc3vDcfogA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Wv8keQ3kUpPKIGej8rfrMI7eQyQ5bUkDwjnga82nFEY=;
 b=amjslSgqP1ho/WpG9Kz9oxfwamUEDhEtyW7RrXOUTQWtWw6nMfHM8MSD0p6ito2kVGiFq8oOuAG1tumct2gyghTeZrjqpmMD9Y9CYlqkPQcXJWUT7qakG4FUNAI8ktA3BJ3+JX9L4SkQebeeOyqXN4O4YOpvPRN+Yj9JNoBz65A=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Thread-Topic: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Thread-Index: AQHX7ceTNtjLavE+e0K+in6YCJvpZawrvk0A
Date: Fri, 10 Dec 2021 13:50:47 +0000
Message-ID: <52F30125-172C-4AC8-B3A6-104D7914CDB0@arm.com>
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
In-Reply-To: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: cab0d82a-3d8d-482c-af19-08d9bbe41a9d
x-ms-traffictypediagnostic:
	AS8PR08MB5991:EE_|VE1EUR03FT045:EE_|VI1PR08MB4285:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR08MB428577BFE45DC7A9D43D79D29D719@VI1PR08MB4285.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 rwDv0Tt61R1goaGktU8IaCJvp3k5CoOoBNlEBNQWTDVtv1OGcJzfzS/dIS4/Rial8teBUA/Pw2gVejVOM6y7ZTIetyZBjkiyIfLrxqGyxMQbBSDfjYPkHocynI7aimNfSzB3lvLe9C0K0aXfNf5NwDdjUQgM9aQHw37DnnDIrJs41GFTyqDsUuViUgrc/VZWc690HJujKjc4ZaMQB8gdE25P8dVoJkYYVf20xuMybTslIpPvpk1jtbW66UJQgnlYy4K9nSpT6cByCDfzmNgTqlV8Gq8bVuIDz1v9j2YhXVHJmGENKddyGEQtkxoTzlspVbMXQGuKKC3OAq1TkSSwNnWL+lybDpwi4JW9m2oMBDxTg7l9G6UuwR989AxJacAuxNraIXxJevicJMtjkA07mIHtBzDcU9rUlrcQkkeyoTvQPVgAK/g1AyGZLqxkQgMX0J8X1KULF1KLK3Lfwum5C0l7dr/HZXVRFWqtG7CqwUMznb3RCBLaxzLxxS7VCV+Dm40E5FakQ81+TFh1/hwZ+6MVHko8g2n5Gnx+HGy++N0L9DpfohT42Q9UipJa1HBVDiPY2lVxDlVdWVLnoz+i1mBlxuLjkQwFeWX2D27PcW+XHwcIjaP9fsFI58ifv1Wp4gZbZjcVGRl7ZGUS3/sc8xZUJxpGSMaxqwv/DKqzaIwM7MvB/LesPPU4s9ovR9zaYaoP1svKJ46n+DOarD8wmnLlkcgVrriJB75Y7peMv5ohzVmLdWk36io7UCEcZQ3d
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(2616005)(316002)(508600001)(4326008)(122000001)(38100700002)(71200400001)(54906003)(36756003)(38070700005)(33656002)(8936002)(8676002)(86362001)(6486002)(6916009)(6512007)(5660300002)(2906002)(91956017)(66556008)(66446008)(66476007)(53546011)(64756008)(186003)(66946007)(6506007)(76116006)(26005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DA4EAB052EC5174DA4F5127894F5C618@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5991
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f4075bdc-4e45-486e-62b1-08d9bbe411a9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VbLCDxfr+GbtlCUQuJP5FcjlbSsRPir+VQz0ujhmOVhyp+CA69e4eGPK8EzAlOx0f14dPkt20OsvFXVsOk22tW7ExGZNTU19vbGQImreGAf4x7nSocloVF3JpA8kDOP3+U0OiuEBIVsubayvgkZz/JMqZJvgTYTk0MbHRYVe8K7uV3MD+vRYufCc78JSLG3zD7aCnTbkJR52OLjfNkw0yhiI/dfYB/RnzOffJtTONn9NWPjqMd+GqRC545Hdu7ITKIG1cMgWigyOAkbCmv2K6PmEu1FiwiontkMyYcGlh2iCBuAG3zauAzp8q4ojQBGwvO3218rpWyvoTwhdCVnrlXP4ijYY2ngALrbI8X2CIbo/Iz2gMKb4Sr98xV0UF0s85Yfi8RHmAXm3xOyN5uAyuQXrqjtvIzWcpb+/WiKl/go6qMACj1lfjEocF8NifH0MA/t7dGvmhsC+JfMiMn1CM+GMT1GtEYbI87BxipIQF75TzJXht2gvvRWyDIAqOMwkjDdJ+PMtFDb5gN/JwwyziPuPzkvpzutoSnBk9p+4V9AtMoXXH2nbdAJp/9RFwDmMXhaFOAMpW3kkM6E3X3C5YQUi4/56jQL0RaORYd2tPqCsxGFeztGUpJPWX3CNUf9ty5CMkcA1NdVjsSErgJvs34jRNLy59J4vk4OyoK4bYBcQerdC/PYcw8K89hGIynzIeuc2kOgO/rFzzw5MpNg3ZFB9/KjNXw5VDmSUgAO0lAVmElm3RGAI7Ozn39acjrJlSTjPTBUDdf1NHGAFKITU0A==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(356005)(186003)(83380400001)(6506007)(47076005)(36756003)(316002)(4326008)(81166007)(336012)(6862004)(33656002)(107886003)(54906003)(2906002)(26005)(82310400004)(40460700001)(36860700001)(53546011)(6486002)(70206006)(6512007)(86362001)(2616005)(5660300002)(8936002)(70586007)(508600001)(8676002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:51:02.2177
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cab0d82a-3d8d-482c-af19-08d9bbe41a9d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4285

Hi Jan

> On 10 Dec 2021, at 13:11, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> do_memory_op() supplies return value and has "errno" set the usual way.
> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
> also no reason to overwrite "err".
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

But if err can really only be 0 or -1, I do wonder if the else forcing err =
to 0 could
be removed but I must say I have no idea if do_memory_op could return a val=
ue >0.

Anyway not related to the patch itself.

Cheers
Bertrand

> ---
> While the hypervisor side of the hypercall gives the impression of being
> able to return positive values as of 637a283f17eb ("PoD: Allow
> pod_set_cache_target hypercall to be preempted"), due to the use of
> "rc >=3D 0" there, afaict that's not actually the case. IOW "err" can
> really only be 0 or -1 here, and hence its setting to zero may also be
> worthwhile to drop.
> ---
> v2: Don't save/restore errno, as DPRINTF() already does so.
>=20
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -1230,13 +1230,9 @@ static int xc_domain_pod_target(xc_inter
>     err =3D do_memory_op(xch, op, &pod_target, sizeof(pod_target));
>=20
>     if ( err < 0 )
> -    {
>         DPRINTF("Failed %s_pod_target dom %d\n",
>                 (op=3D=3DXENMEM_set_pod_target)?"set":"get",
>                 domid);
> -        errno =3D -err;
> -        err =3D -1;
> -    }
>     else
>         err =3D 0;
>=20
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:51:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:51:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243896.421998 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgJb-0006eX-2P; Fri, 10 Dec 2021 13:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243896.421998; Fri, 10 Dec 2021 13:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgJa-0006eQ-Uh; Fri, 10 Dec 2021 13:51:58 +0000
Received: by outflank-mailman (input) for mailman id 243896;
 Fri, 10 Dec 2021 13:51:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvgJY-0006eA-Uh
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:51:57 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 546fb092-59c0-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 14:51:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 546fb092-59c0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639144314;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=yI7K06ovLU8YroQeSrEStiLOY41V0BF+kUSjdvB7HuI=;
  b=YUnNqXCsXULQLHghw2AR6D53yQXQK50u16VoTEhtOn5YVlQcoib0W5iQ
   X0c5sS9tzycQNFesbLpeGBPqlQFOTf3fkutUM46UHn1/ZX6jmt3p1LZWu
   eYbSqs5JpUQuFkey06Frp7YchEtDZkBGzNaVSS1EZzhkUsU+GVOfqy3Qq
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: EiiN3/yZYCkNpnUb9YP2yIhPkSfB7LZqdHBO7nhG2YZcU+XF84ryPkivltC50a855ZPggLAHgh
 WdGdNR5FvuAMxsFz1AnzSGqg0X1vTNOmXcfWWwOWDcasxL7Q3dttCFB26DeyjDc75Jrc/TFluN
 PGzZXNU+2vRWZtvptDsvH8oqZrqgS8jesRAd+nyDWVKVUvchpc/INpOFl6Mx1mW54BP92LThtm
 nn132mruXOEqt80n/vrY59SvodH3eKvHP6nWojpLdsZekSgPq0yfd6ktOe2rlBBY4cOO5XtJGk
 FkLSFgBI7y/gbp/KJUihZ542
X-SBRS: 5.1
X-MesageID: 59682315
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Y8Ou8Kix6C8iufOgCjduOxolX161ghcKZh0ujC45NGQN5FlHY01je
 htvD2uBOqyLZDTwLoxzYIW2/E9UsMfRy9BgT1No+C81RSkb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx2YDga++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1d76OoWVYAIpeQ290Tb0VGLipBI6pZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t154eR62HO
 qL1bxIoQz3jSDdpZWs6S746rtq5iGfnLy9X/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru4GDREhwcctuFxlKt8Hihm+vOliPTQ58JGfuz8fsCqE2ewCkfBQMbUXO/oOKlkQiuVtRHM
 UsW9yEy668o+ySWosLVBkPi5iTe51hFBoQWQ7ZSBByxJrT881ymHnhVZyJ7NJ8fuvNqWwEh6
 UGOgIa8bdBwi4G9RXWY/7aSiDq9PykJMGMPDRM5oRs5D8rL+99q0E+WJjp3OOvs14CuR2msq
 9yfhHVm390uYdg3O7JXFLwtqxalvdD3QwE8/W07tUr1v1oiNOZJi2FFgGU3DMqszq7FHjFtX
 1BewqByCdzi67nXzERhp81XQ9mUCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP
 hSC4VwMuMELbSfyBUOSX25XI55ypUQHPY66Ps04k/IUOsQhHON51H8GibGsM5DFzxF3zPBX1
 WazesewF3cKYZmLPxLtL9rxJYQDn3hkrUuKHMiT503+jdK2OS7EIZ9YYQDmRr1os8u5TPD9r
 o832z2ikE4EDoUTo0D/rOYuELz9BSRhWM2t9ZUILrXrz8gPMDhJNsI9CIgJIuRNt69Uiv3J7
 je6XEpZw0D4nnrJNUOBbXULVV8ldcoXQasTMXN+MFC29WIkZIrzvq4Te4FuJess9fB5zO4yR
 P4AIp3SDvNKQzXB2jIccZii89AyKEX13VqDb3i/fTwyX598XAiVqNXqSRTiqXsVBS2tuMpg/
 7D5jlHHQYAOThhJBdrNbK791Eu4uHUQwbogX0bBLtRJVl/r9Yxmd374gvMtepleIhTf3DqKk
 Q2RBE5A9+XKpoY09vjPhLyF8Nj1Q7cvQBICEjCCv7isNCTc8m6y+qN6Ub6FLWLHSWf52KS+f
 uEJnfvyB+IKwQRRuI1mHrc1ka9nv4nzp6VXxxhPFWnQawj5EatpJ3SL0JUdtqBJwbMF6wK6V
 ljWp4tfMLSNfsjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTc2jZAKLZVMZ8+x
 bZzscEb3AWzlx42P4vUlStT7WmNciQNXqhPWkv222M3Zt7HEm1/XKE=
IronPort-HdrOrdr: A9a23:jQdVpaPl8/j+TsBcTyX155DYdb4zR+YMi2TDiHofdfUFSKClfp
 6V8cjztSWUtN4QMEtQ/uxoHJPwO080lKQFmrX5WI3NYOCIghrLEGgP1/qG/9SkIVyCygc/79
 YfT0EdMqyIMbESt6+Ti2PZYrVQseVvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4F6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr1ojegIK5Y1n3X
 nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKve/lQFwhNvqxEchkd
 HKrRtlF8Nv60nJdmXwmhfp0xmI6kdZ11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza
 NixQuixtRqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW3HAbgcYa
 lT5fznlbVrmQvwVQGagoAv+q3hYp0LJGbGfqBY0fbllgS/nxhCvjwlLYIk7zM9HakGOup5Dt
 L/Q9BVfYF1P78rhJ1GdZU8qOuMeyXwqEH3QSqvyWqOLtBzB5uKke+x3IkI
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="59682315"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eiUqKv63CdQneT4EWs4cBIRSDZrU7K/VlAPeuBbN5TJOCUDQjzUX39pShZqX8c20V18Pp0qY3AN5t4MxUn9tdxfxlOftxH7Q3sz0KgeuPRgzz18JUBwjCFEocMmQoccPP1xr5gopuIXOWKGsD4oCXa8p0Arz80I3l/4YadiV0m57vz+JPUyr5MTegq20K8YEibpkpfgAHljDGvbsIWFLRhV2LQkqDkoSMAqrNdQE+x6lQTwlAlTaZ/+OzGwNAsMtp3nwrYyfzoog1ennOIch+IeDuS49xqBPNkcIrTQQ+URyD0sS/dNj9f9Os4zk/kO9tdUYyVxG78kwAbGZGb8MdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j6OTVpimcPuYbvwbTgXb89vt8uWITNd/FZzxmO3+HuM=;
 b=mIPbAmJUEi1h2Q02d9xeRJ4d3VAK3BXpaGmwi8q1NdUfV86cL/NcaGEN+Sermy45j/d/qKe9MAjO1tT4tVxCkVAGCCrLQ62AnGiVcSQ+3ikdhvV+6QUC9XOOb7RX0diG7t0KkErfK96+zRvSba/4crV9xX89x4TowVrWz+oNAK6nKi+B6NK+qOtEYdlmGB0oItYqRE/8PrHpUJwFCrEm4JFe2pkJ44N9tkIOaD7vydafKIVNYT/NtW94MTrVhtVCLA7Vj3JIMlMTspmXhW2kyMyBBcNMsU8pCQ2F18wwFbLMfSxWt8kqj52XcdL/C/6U+cofUcbXewoLmzVNfZwOgQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=j6OTVpimcPuYbvwbTgXb89vt8uWITNd/FZzxmO3+HuM=;
 b=DEeKJvTfWgX643/b9WcVKHZaR1oF1ypuEyXt/66qAhSv2XiS9RfZgGUNYk/Dcqc4fnJ9F2TL82OkxiI30YfgFHv3StSqfQg8t9zDyneqS/qD2/TwFr45DFzovTTw7so5hM5yHoiPxWOCUx43P2fQUYyMotBrpTCuhxil1/JUF30=
Date: Fri, 10 Dec 2021 14:51:37 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Message-ID: <YbNbafZMMbRJxlzs@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f58b5369-3e2d-4956-ae8f-08d9bbe432bf
X-MS-TrafficTypeDiagnostic: DM6PR03MB4684:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB4684E70A2C744F5FD006ACD58F719@DM6PR03MB4684.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rPjGsndIPTJMnIUwhhtvMDSnFIYLxKCXp1z3Aw+VhNmxpx7qogV7ihcOVq+QSORLGxhqSu3or68y6/nfURok2LN4HcaJINLK2T49sxNTyCQIF1vZgVr06eBdgskmcQ13kvlmOnT5EhHKWlFQHt4MiqZcOt02CMEAHF4WlEWyCpe6h+d101WoqFwwaqUcQdtoGBnq3Ui5NdAYTwshpNZxge3fN2qvfXPSqMmv37cVxzIQgZ4J1PwA0O6wwOoWSBDnRohSQ1WEb4wm4T9QY8XalIhoGs3zTH5Bzu/Ayc6Jid39YKiOw97lP1yBJC79qwzoJAxWzyRc0FPadf5KMXEn8WWVvLYhNMf5V9Kt7ECICVOOHAeYR02YamyMfykOpMAyYMifqvPL1jj9gWI6jASovjaVPw1ae2hoDTMuPpYQvB6qNx1vOTWpIQSj8qZGjPjncECfpFdhvPLezix9ZtMRK6Aq8HlxHRQeKq5UufyMMvkJ8KXy33eCt+7nDKPzd2JaH45ZmpG5QksXOVZsJkXNGdxFY5TURujMhELx9CzGnNz7PHqWphFQhgVD6TvQFQMlm5UMpxwg0v4sd6mU/satHql/AAmv/+r7EzeHPC3nIzR1dr+znOugm/AjUy97ZaUYAqojqxURgfYGzZA/qKAD0l/5DrWhI9kGLXS9mMvBCTGYmtMtsYeGcjXSy3VopfvMxc0wGaY7cDOTTE+z2bGFDoT4OEvlokBtajMKYQMlOR0=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(2906002)(66476007)(66556008)(6916009)(6496006)(33716001)(6486002)(54906003)(4326008)(85182001)(956004)(316002)(66946007)(9686003)(6666004)(8936002)(508600001)(186003)(26005)(5660300002)(8676002)(38100700002)(83380400001)(82960400001)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk1kSHNpN0EvTjdjV0Jwd0RFdlhCTmNjSXpKLzJuT3ZTVFZTVENnSnU4emhE?=
 =?utf-8?B?QW1sNVNQNk9IVzhOMVkxRUNWL0ord0VCM1E1VUk2aFlnYW1zTU91bHcwNno3?=
 =?utf-8?B?UGlGcmhMb3draWhEZFVKZXJxclF1a2llTC95N0VZTFppNmhsdHczMmw0NG4y?=
 =?utf-8?B?Uldobmw5L1B6enRjOWNWZHJXV3gxemVKYStSYkxuRk5ndk9HZUhKNXIwTlpv?=
 =?utf-8?B?KytvR1d2SzdhdDZNem1iaVBjWlFDRUhzREtqNzRHb1J3aVljZm9PbHZoZ2hq?=
 =?utf-8?B?RkxLYXhISzVsRkdoUXc4cnU5bHh0WFNnZmJ6UXRQRzhUL1pHT1F0VkVYenZJ?=
 =?utf-8?B?bUNBdkJielhMbkl2VXN4dDdSdU9XR09jcnpsSmtDUnJHUDJhb0FwR2t6aVBC?=
 =?utf-8?B?SW5oUVpJeUZCRjl2eDQrb2NnV2UxUFZNWFVEL2lyVkxPeEtsVzNLa2JES2x5?=
 =?utf-8?B?bkJxR3hEMUNzaWMzMmwzMnpVV1lHaURFZmhaRHJGRnJ2Rld0d2pxRmFBOE5D?=
 =?utf-8?B?MVFoZmhjN3g1TVRzWmpzZjBodjU3bHNDRHJPRk9sL0dRMFF2TTk4MVdRSWpy?=
 =?utf-8?B?MWU5VDFiZG56Q2dJb3g1YTdjVEw1NDJPOXhiU05JWTdjeDVlYTJrUkRqYTA2?=
 =?utf-8?B?RHR2cStaNnhMYloybjhlcEExRXN5eFd3OE03MUpBeGNPbHpXZW5jWjVGeE94?=
 =?utf-8?B?eWcrdEpBeDNndVVGYnQyWFZvU1N6ZGNZYkdxM3BPeklLdWpaYjhVK0w1MWt5?=
 =?utf-8?B?aWM3OG1lMWV0OUtXUXI4bkZQU3RxY1VGOElNbXIzVkpqdXAxYnlTcWg4WExn?=
 =?utf-8?B?cTJpVzRkdGtnZFprazV1K1hFRTB6cmV4THNDa05pRkl5MkwyZ1pYTG9Jd0FC?=
 =?utf-8?B?alJlWk4wOVhvZ2srdzAyYWdldFBXU2syaFkxeXNqNFhqR3BKM0tmYVh2T1JC?=
 =?utf-8?B?amw3V3BDSGRhVk05TStMd0o5MHBFbmJIbm41SnRSNzBzS2t4Y2FvM2JVZTV6?=
 =?utf-8?B?M2x6Y2srUGJudHFneFRGUTB3UW9SUHNRZDM3L3dSUUg5TFJ1cUxWdUM1R05T?=
 =?utf-8?B?TTY0ZElwaUdCK0JNRGhTZTlSZFNnWmFDOFNJdllNOTBwbklmZGNmK3I1K0NB?=
 =?utf-8?B?T0l3bmVubWVRN2hqcDJXQ2pSWkNqWXVDQkwxUGtpMHpuWTVwTkxGbWZpU1V5?=
 =?utf-8?B?Z1RoYkVyYUo3QUVudEZzQTVsckJxcG1za3AxczR4WWVrVEg3MENYSHcyWGZz?=
 =?utf-8?B?U25USWx5SThUWWpFODh1K3BsVU9VUENMTEtUTE1IbjcveVFsb0lpSmMrdmti?=
 =?utf-8?B?YXRHZGZUWjBLUzFHOUlWNHlQRlF2NURTOUtXL0s5d1o1NmhvK0l4bmlRRlI2?=
 =?utf-8?B?M3RiTDNvb3psT0NDbW1OS010cG9Gb0NrbURmSnJMVGd5b29VOVNwWDI0dkhh?=
 =?utf-8?B?YmVYaWszZFFoTTN2L1BjSFdXdWF0SXRSZ2ttaC92WDdzTXpPVFBFbnFuV1NE?=
 =?utf-8?B?alRlczJjVU5LS2dwbHRYSTVtRW5HcWU0SzJVcEowOEFmSjduTGtGcDl2aEw5?=
 =?utf-8?B?WWVpNWZaM1ErSXlJMC9FWTFvYmpCNzU5aEtuZWVpcnNoVzBqUXFXSEZUK0U2?=
 =?utf-8?B?ZUE4VSswSXEyVDRXMTZ4U05YbDg3Z2lwU1RJbEg2Q28xa2JvWUgzbDhLb2VB?=
 =?utf-8?B?M3JsR3ZHRm1JdVVkWlhGQ21IL2RCc2xiamVCK05UdjJTVHVKOVNudVZBS3Bv?=
 =?utf-8?B?SXJVNFZRdm5pWlpwdEVBWldlejlRdkZsZkQrMG1VOEFsOEdsQVlhbUh6azRv?=
 =?utf-8?B?VEpVZUFKSmFEM2tvWWRrcHZGajJnQS9raHZQYnRKM2FvdnRrQy85dmpRTTVJ?=
 =?utf-8?B?d3pBek5aYStVVXhibGtTbWxiTGFQK3VNdm1FRW53eW40cUZaN3dsMmdqZHBT?=
 =?utf-8?B?ZzNDcVd2eXg5OGtqc0J6Y2FWTFh2R0FFRjFMcGQwT2JsZGR3bFFpODg0Tmtx?=
 =?utf-8?B?SlhaU0RjbUNWL0RyQmRoM01QUm1DblpsbURBUFVlWjRlWklBVnNJdWpKY1Yw?=
 =?utf-8?B?Nm4rbk1NU05DY1YycmVWWG1iL0FBMVFRVGt6b29DUEVqN0lhKzVFTnJOdWdt?=
 =?utf-8?B?bnlZN2t6ODJLWTkrclo4N0YvYVlWWWdSbVRTVUdGMStRbkhpQ3g1UXF5UGxZ?=
 =?utf-8?Q?NGJTn8gB47OxLVqCfi85nos=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f58b5369-3e2d-4956-ae8f-08d9bbe432bf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:51:43.2138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yG2gHvzCVk4pR0xyWVWFF80yFtisB+HfaNJwmDMMtNuN1QiX9Ei2lgMrNh38N4WZeAahZNpD2fQLH/xv6/TM0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4684
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
> For vendor specific code to support superpages we need to be able to
> deal with a superpage mapping replacing an intermediate page table (or
> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
> needed to free individual page tables while a domain is still alive.
> Since the freeing needs to be deferred until after a suitable IOTLB
> flush was performed, released page tables get queued for processing by a
> tasklet.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I was considering whether to use a softirq-taklet instead. This would
> have the benefit of avoiding extra scheduling operations, but come with
> the risk of the freeing happening prematurely because of a
> process_pending_softirqs() somewhere.

The main one that comes to mind would be the debug keys and it's usage
of process_pending_softirqs that could interfere with iommu unmaps, so
I guess if only for that reason it's best to run in idle vcpu context.

> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -12,6 +12,7 @@
>   * this program; If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +#include <xen/cpu.h>
>  #include <xen/sched.h>
>  #include <xen/iommu.h>
>  #include <xen/paging.h>
> @@ -463,6 +464,85 @@ struct page_info *iommu_alloc_pgtable(st
>      return pg;
>  }
>  
> +/*
> + * Intermediate page tables which get replaced by large pages may only be
> + * freed after a suitable IOTLB flush. Hence such pages get queued on a
> + * per-CPU list, with a per-CPU tasklet processing the list on the assumption
> + * that the necessary IOTLB flush will have occurred by the time tasklets get
> + * to run. (List and tasklet being per-CPU has the benefit of accesses not
> + * requiring any locking.)
> + */
> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list);
> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet);
> +
> +static void free_queued_pgtables(void *arg)
> +{
> +    struct page_list_head *list = arg;
> +    struct page_info *pg;
> +
> +    while ( (pg = page_list_remove_head(list)) )
> +        free_domheap_page(pg);

Should you add a preempt check here to yield and schedule the tasklet
again, in order to be able to process any pending work?

Maybe just calling process_pending_softirqs would be enough?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:53:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:53:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243904.422008 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgLQ-0007KP-DM; Fri, 10 Dec 2021 13:53:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243904.422008; Fri, 10 Dec 2021 13:53:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgLQ-0007KI-AI; Fri, 10 Dec 2021 13:53:52 +0000
Received: by outflank-mailman (input) for mailman id 243904;
 Fri, 10 Dec 2021 13:53:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvgLP-0007KA-D3
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:53:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 993a043d-59c0-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 14:53:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 993a043d-59c0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639144429;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=K9Pv3Lb/PCZAj4cbvQBpniDqNC4AKgW7KAkYeI7rHQs=;
  b=Vu0qewPeQ4EUck+qza636JXXm9Mxc/gmLj5JfzVHpQPob6F5N1gZG75m
   EEr4i/34+FcTcUpf41YdqJuGwHpenO4ayAeRzkmdpu1Nv7ndhqSKJpLPN
   jK3sobic9aIyBWzRA4mUCkMjn1jqBHcYzlw02tMK5QjgA2HOADUVpIIeU
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lXeu65xEWVYWhBb2Qco1O8YSlS55Hv+TmhIyuepMWtvzXz0Fh+a1QgTxo3IDttJbPBm4TyfUq2
 Fy0qzvI+OOq5kKcIWhmcAQvGsCJEo0xNNe03R/nj8L1PE6RWZPD9dPAzKcYUAPJUYxnv3kZo8F
 FcbrsBkMO1TPKoBu85RV4KCg8sdYvnEWpKT/ISFK6D4XK1LK3c8Ejh4pwY+2HfPpHZANEl3LHp
 JK3Cdt/gzoy+VWbhaUEOE49AfK397sBP7uatonGVtweTPFWFeM5w6KAHe+9kMjNrsNZLvTDB79
 u8090koMyXloTFx8qLezC2KY
X-SBRS: 5.1
X-MesageID: 59242958
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JwGGoa9mDH51O9aWPsviDrUDXnmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 zRKWTjQbKreZ2v3KtEnOYzl9kkA6sPWnIVhHQQ9pXw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg2tYx6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhY6
 /xn74WJSzwVO6DimPxHCSNBSA9xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFjW1s3JETTZ4yY
 eJAZzRtcxX7eiZWFW4SMZwRsMeVniPwJmgwRFW9+vNsvjm7IBZK+KDkLd79atGMA8JPkS6wt
 m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZoilCOwm0YCDUNSEC25/K+jyaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCslz01cYBJKu8B1ASA5KrMuVyjHzMqQWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZos7SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DFjFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBuG4jeBkxY5pcEdMMX
 KM1kVkJjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4AOXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:tCWjiK22TQpZtjZ7H/rTJAqjBShyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhQdPT2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzM4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kDEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 TxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72xeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJlBXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlbhrmGuhHjPkV1RUsZ6RtixZJGbCfqFCgL3b79FupgE486NCr/Zv2kvp9/oGOu95Dq
 r/Q+NVfYp1P70rhJRGdZA8qPuMex/wqC33QRevyHTcZek60iH22tXKCItc3pDfRHVP9up1pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="59242958"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dnwqbyW2+PR2z2y7CTZjQ/Mg6rjCGFmHtnk0h9vkd77GZvdbPpQGQnMY4jj7CccuirUCQhESXu44VfRi2H84+5wHxGs/KYpLjgOTDPVaMtIkMq3kuRu950TnNtGwhwKCECA6P4dJFlCfxtFdgg7zDm+agMzj1lv4C5BMUpV3DgJ9ok9SrrXjiSwhSZyi3DLk2Y/9N7FFh9PXdAyG/nvUAXlE+iP8UuGmExpJ/MxfI1LcJ1hxGG35C+Yt/jAjVB7hCcJZsW2ZHi5b3eiUV/sht7WNdTnzRQJ7VTyMOn6HZrmDdqVIZHuXtfekIq10la2KH/r3jc6RMYNMG785cU7Wbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cKFk9O7qIhJQjZvK2iwmn2evIFBeA8AxkEvFqmx7VMs=;
 b=R14PO487Ao8zzGyt+wEBeUZ9PA0F+SM4kWU/sjg2v3UmUj05C4YQjSkgTPSMmJB2twRVWbhu1/LKW5iOAyDoRofE6b1iDaLUnTQgDmGEVSEolIOH73LswqqnRG6s7QaBQL7OGtdF/PNpFhzyBg2mCJWUtJxbrdUA2V9Tb9x0D4S+GwAdDb3mKhDRSivZ3a/7tcEJI+O10DaFV3fL8mvhT14gs8S1woKPlWEkoIWqywaY6LPpqjz54VcDlq1EBV6YguUI5xOqmpp0kdJNfb8uMKXi3OGtPb5/FoH8yRcJUiTtGy0meVmvh0i9IXE9DMqvxWTSv84j9LAGHMqYyKwnJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cKFk9O7qIhJQjZvK2iwmn2evIFBeA8AxkEvFqmx7VMs=;
 b=mo5liVbs881p7WIb9n7JGtSVLOapm3d5xlJ2PhWzS0nvJah4Kd6wajkffoO1j/ZgxatjStLD6oXdWBMOW5C6moanwEmx2EN7Ps8RPk4SyxCzJThZCp5pvTQ6lxYk62XCVnF68c0T+np1c2uVgClTh/88hfeYtsq2eOxfzK0mr7Q=
Date: Fri, 10 Dec 2021 14:53:38 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 11/18] AMD/IOMMU: return old PTE from
 {set,clear}_iommu_pte_present()
Message-ID: <YbNb4lMN71Lvj/bN@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <33819694-2787-4bd6-1830-6b4eb81cb4a1@suse.com>
 <YbNCpA1PDtINnn7j@Air-de-Roger>
 <1fe2b37d-b898-c86e-dd4a-482bff9597db@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1fe2b37d-b898-c86e-dd4a-482bff9597db@suse.com>
X-ClientProxiedBy: AM3PR07CA0133.eurprd07.prod.outlook.com
 (2603:10a6:207:8::19) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b577eb40-16a3-49f6-f9b8-08d9bbe47a9c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4762:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB47627E7FF93AAD2632C2D3738F719@DM6PR03MB4762.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Uyr/qeNfU3PHi6pgPf6g1qX8Ye5mXCvOGO/+zEEKL3KXkRXrFgzlPHn+gR3/bU/7IoNbV8aSe/XvOCJYlVTC00NBrsZ0uJ/czNrAaH5ZIbHDQNRF3nteZarip6dzQHIMwF/o9Iay9BMjmW2AQOFFSk6SuJIBGqpywgT+lnijzexnYch70kZ+/qeW5B7hYzjUggMmr8em8lfjFSie6nAbD23I+7w3TNFY1EsWe3KcbFjtyTqq4bXY7Zp15daN3WCFWl5WKjzNtmiYawBctS82524BFpj9RD6xcqOBULxGmDfr438tSMy9yf3SqUeelM4jAxWZ3sftEfeLr3LKkvjc14dHNPT6mVpA5nyzdohnQ3Hq9X0TxGkJJMmhUYkrfBjM2mueoyp7HEbaUWA+8Y0ONZ544NhAndPqY/ARcK4Z+l3ZxjY+siZqnENgqSFlU5LEaZAcvfgbfBe/wR5fCKqhV9hdug6D2utYl1R55g8XYzdzmJvbsusQz7Ch5kx+7OJZF8bwLQYVd0TS5qnLN4Y0wH49i6mfLBKJs5fdafD5f3xL2KLWeW83sz+trzLU1Nqzn/DwtZnPkCN28gSHEKRxnNOmia4r9+UjHrvvQx3raTV77KcLmEEoN9eWKgMtk1Bqow/DuQnH64so+2r1Y/OU3Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6916009)(9686003)(6486002)(8936002)(5660300002)(54906003)(26005)(508600001)(85182001)(66556008)(33716001)(66476007)(53546011)(2906002)(316002)(86362001)(38100700002)(83380400001)(186003)(956004)(8676002)(66946007)(82960400001)(4326008)(6496006)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzJ0ZGNoU29zM3VpVWk4c2h3QkViTUlTRFhNeGw3Wkt1MlVNaTJaVStuem8z?=
 =?utf-8?B?VWxFR1dENGFPcW1VVlpYdFJka0pzZ0xEWUZXZEdtbFk0NlJybW5EQldnV1lI?=
 =?utf-8?B?SUprVUsxeUhBQXpSNmZkcXZYWGo4d0MwZS95LzBuaDVFWXBMcmpHRHlUK0F3?=
 =?utf-8?B?eVdNc2JYRmlhWTFkSytGZEVQcHg3RDZPTGd6Z1hrbkIwTWRJRjBMbGRZWkQr?=
 =?utf-8?B?bHVNZzAvNmFvdFA4VGpvTy9qR3ErNTB5RkduREZ3cW5ROFN1TS9sUmZ5anAz?=
 =?utf-8?B?clNvMUxJOVJCTGRvUFZJbWd1T3NiNW1tT2s1UU5UYlFRL3p2cGFKVmRlYXYr?=
 =?utf-8?B?cTh6bWwwcHMrMkVjZ2l4a1JhSW9iemdUZU5Zd1hUaE96aGhRM3NsaFpwU3BN?=
 =?utf-8?B?WU9wTEdEL1BXWlpEMGdDaXpoK1puaUFXQzEvdjdzTmJ2ZFdJWmJqdnY2bmVv?=
 =?utf-8?B?U0tnc1prbnlHTVYxM2x4QnEzbHRGeDJpbUZXV1N2NklWaDJSQWNYcHZEZzFP?=
 =?utf-8?B?R3NvVWw3M3psRWFaY1hMa3pENG9DQXpHd3FaNS9xSTN3VE1wazRuNWFBMkJj?=
 =?utf-8?B?YlhURFhaSVloeGx3cXkwdVo1b1J4d1o1Qi9kTFhpNXl3bkxONDAreFZWYzc5?=
 =?utf-8?B?Z3o5K1BzTURGTWhuMEQxWFhqWUNpb0ZkcHhPcHZoRWVzZFo2QjA5SERPSHNj?=
 =?utf-8?B?bnVoSEZYVGtQaFZDUi8zK2M2MHFzTlpRSVFLWGZHMnRNdUxpQmM0U2JEQ20y?=
 =?utf-8?B?VjF6UWt0VzBBcE94VCtWVWV5ekZTZTN4ZCt1VndYMGpxdWFpN21XQlpvaEkr?=
 =?utf-8?B?UzU5Y0ErWmVlTWtxRWtUTXIyRXNCTkR3bjdoM0t0YnYxcmlMYmRIVnVnRElu?=
 =?utf-8?B?Q1p2azVJSndPcXJ2QXVnNzFaVTgyaEdrQzAzQkhvOTR4eTdOUzEySU1ibVpw?=
 =?utf-8?B?VE40ZElmcStXRHJMekhPNmx4QjJPeGZkd3FsWThwRHhWQTZUYUJFNjhWWjdH?=
 =?utf-8?B?SytmMVRMelc1Qi9FSTNadkRiWDVuZWlla3Z6WjlMVFg2NGdDRitKYXZLbzlR?=
 =?utf-8?B?OWExY0dTMWZMc0VROCtuQUZaZWgzYkRXK2c2VDh1ZTdhMkkxa3FDaXJkN09t?=
 =?utf-8?B?OUJUNVlGWjhOQ3RIWThYVVY2MzdiSW9VLzA1M25vVkphOEpKTmMvY1gwNFRV?=
 =?utf-8?B?blNMbGhSb3FyanJCelNKaGFGNFdTdktWV1R1RE02UitKZTZWZHBYaUR3ZmNS?=
 =?utf-8?B?ZU1jUzljNVVwZUtIM1VlMFNHSmF6MjFSajVicGZnQnlhWU5xeWtGZ2g2bUdC?=
 =?utf-8?B?MXZla3lYdG5LSGlZV2xCVEUwb3BKa3d4dUQwczhpR2V1UHBFaVZobDVGWGpk?=
 =?utf-8?B?SEx6SUNSSExaZDVTVlQ3UUwzbXRtZmYraG1uSnoza0h2RkxtbmVRSDZOTWcw?=
 =?utf-8?B?MW1DMjlacjB3aHBsS0x5V1ZqRG5rc2p1ZjgxM1FvcEZoZjhWeWtHNTFSSm9o?=
 =?utf-8?B?azg4cldOenhiMzJWMVYyb21oWkFKUmthUGl0aWVmR0tGWWYyckVJRVdXak5s?=
 =?utf-8?B?SXMrYkZrZElZV3JrOStmU2JYaVY1OG9qNzVoL2J2VE9RV20xOFZQU0VyVytn?=
 =?utf-8?B?VnB3WDh6djhHbTliZk9FZGFuYm9yYkh6WFhmUVJjZllhdmJxSGd1ZnVhNzk0?=
 =?utf-8?B?eUFKaGp4M29zK0QzODc4RklOdU5tTkdBWFNIUHg0S0o5c05WeVBxaHBValg4?=
 =?utf-8?B?ajV0NmNZMkdWU0htbXFDL1pMRjVWdDMzeXU3eUhoajJiR0tlcEFSYUdJMDBJ?=
 =?utf-8?B?NzQzd1NEaWF0MXhTa1VMUkVablUxSXRMeTRKK0dDb2VtZjdnRUpGV3FrV2JE?=
 =?utf-8?B?cVlwU0xxUndhL1hCQURJcHVXdGNsaTMrZkFBcGpmRitVdUR2TmZqc08yQ2Y3?=
 =?utf-8?B?TTMvQWZoVXZrT1N1MG9BU2ZGQVdMUm9NMU5ZZWREWTBHSE9CV29RUEhSaVRn?=
 =?utf-8?B?SVZRUTRsRVpKY1diZmVUeStuZ0pqQkEwLzdlc1pHOG1kbWtYeUJLMmRNdFZl?=
 =?utf-8?B?QmVkd1pscUtxdk1iZmo0R01GYkQ2ZVBGYThLYjJ0VThyQys3ZUQ5MExDVGMx?=
 =?utf-8?B?enhncjV4eFh5ZkF2UXNmQkVyTWxmcyswSy93TjNzK0VtWTM2RzRaNWRTMWRy?=
 =?utf-8?Q?D8DMZrHt3ddA8SkOMMuYMdc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b577eb40-16a3-49f6-f9b8-08d9bbe47a9c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:53:43.4776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ECpkdlbSLzGnEC2OnpvtmC//ulSDuOIGj53jLX1BrjIex903MP1G2Rh3ffTOiIvX6zwn7QulYc9sQhmzinxCtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4762
X-OriginatorOrg: citrix.com

On Fri, Dec 10, 2021 at 01:59:02PM +0100, Jan Beulich wrote:
> On 10.12.2021 13:05, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:51:40AM +0200, Jan Beulich wrote:
> >> In order to free intermediate page tables when replacing smaller
> >> mappings by a single larger one callers will need to know the full PTE.
> >> Flush indicators can be derived from this in the callers (and outside
> >> the locked regions). First split set_iommu_pte_present() from
> >> set_iommu_ptes_present(): Only the former needs to return the old PTE,
> >> while the latter (like also set_iommu_pde_present()) doesn't even need
> >> to return flush indicators. Then change return types/values and callers
> >> accordingly.
> > 
> > Without looking at further patches I would say you only care to know
> > whether the old PTE was present (ie: pr bit set), at which point those
> > functions could also return a boolean instead of a full PTE?
> 
> But looking at further patches will reveal that I then also need the
> next_level field from the old PTE (to tell superpages from page tables).

Oh, OK. I was expecting something like that.

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I wouldn't mind if you added a note to the commit message that the
full PTE is returned because new callers will require more data.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:54:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:54:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243910.422020 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgMM-0007yj-T6; Fri, 10 Dec 2021 13:54:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243910.422020; Fri, 10 Dec 2021 13:54:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgMM-0007yc-P0; Fri, 10 Dec 2021 13:54:50 +0000
Received: by outflank-mailman (input) for mailman id 243910;
 Fri, 10 Dec 2021 13:54:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvgML-0007yI-Kf
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:54:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bd39a283-59c0-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 14:54:48 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-12-cpB0g7vzPfOOelMY6jrsmw-1; Fri, 10 Dec 2021 14:54:47 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 13:54:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 13:54:43 +0000
Received: from [10.156.60.236] (37.24.206.209) by
 AM5PR0502CA0004.eurprd05.prod.outlook.com (2603:10a6:203:91::14) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 13:54:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bd39a283-59c0-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639144488;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bvQaTh/W4/ZFBNazhXfSywTqj098D6zTo+tO7eNR/ws=;
	b=kyO0qf1wHP8Awx1vUBW9YBRKAYO73cTZZs7xJe7p++tse96SxPUVon+kmy4JsZF5qQuKAt
	aPp9WkBtrKLugjeumL7dsb/CZ5jcGcYJDRi0dnLzS//QYwJKZTxP9cCMCvvNn2KYamsCTj
	3o1Wb3l2GGODUDV370GY90qo8cIa3QA=
X-MC-Unique: cpB0g7vzPfOOelMY6jrsmw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U40sF20vGotss51JPNM6y53Fl5AsddQy6uhRWfkPedtNBgHO6CqOI67eNG2Fr0pXwqeXDNQVt6sPEqJEZXNFh8nqK1X6EWKsIHuwGK0AiXNaGGs7oi7VctYafn1XdN5Tjg1i9iupQXRBqBpBI1j9lldYJ8qfC8tMJuNHLdHMhB+SeqmzkwbH947QaJ33r5Dfk8C6Nr+7RrQI2rmehsE4MVmi/232pYXSD5kJdRBwIX8SSosgNIz8PjTeLuYN4+AcHRTbegGskbTE5gquED8YKlfxLlhZIGKuPJDxBln0OcPIwsTEQxOVgQSL0BV8StnNOBS7S7dNazKGqSwZuVpH+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bvQaTh/W4/ZFBNazhXfSywTqj098D6zTo+tO7eNR/ws=;
 b=HdoxRSo8957hZ6kZ8xVUqnhTahJHkbiFqzXOXxjU3l6LfmqxhBRfZhx+i4VW9J+KmZ+nx311b7qsVXG6QQIgtO2Ef2ml7PXA63ohSoexRxnMkH4NncEs0AGnahDc2VxQPevICf9yiJX3tWiViNLvFyf579QFd/jrWZgxKnH7hb0GbTtUbHZxCv0X/lP83PZ1gnYSc1Sdj/8USlSYx9w8BwcPvfnjJLAVOQaEq8LYcMSYc6yvTwpS9I1nOQzdANu3/4dXUlWLkisirNdpia9Nk+OMOhA8IqGcpV1NzpzFjt+MBW+4FDKrSCNCW3vBsvNOCTttZ+4C2dKbWc3d+soqbA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d23a7603-47c2-43b5-5365-02f437fd46b1@suse.com>
Date: Fri, 10 Dec 2021 14:54:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
 <52F30125-172C-4AC8-B3A6-104D7914CDB0@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <52F30125-172C-4AC8-B3A6-104D7914CDB0@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0004.eurprd05.prod.outlook.com
 (2603:10a6:203:91::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2881e67-a61c-4584-8b62-08d9bbe49e47
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57422AF438DA1AC47FEAFDCCB3719@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+JOPWcxrnKSJ7h+W20eJ6O6id5t/0J7WY8AqIrCFpmV+ipHEoLwKdR4KGbtC/a6k7MbRxfsPr3jON4dBVcqw9elm02f8s8h5/XWtp9+jAL6dBHsLIHQqg+uTGs8+yOwAPKYfBY0bGxiAHD7ADqDT7fiop8Aj9ifB0X1KQwt4dRzp0nnUqRrpB3zn3tK2m2Xkvhif9VykghpnHHaceRrJXfzZRp2vKEgPabbjRiWnRIjrwwASW2YBriNon+iMiPJ6tNJthOeGwxiNNN36gLoyS/KZKU6kPQtXoy6I6eQtx+WZpAb9vZWXxpBUuRK7W8bPVn4D1JwnpGu5QzeMWCbS2FQUMJyrH5HbWjacadpCUVxuax2wGJd4SDCz8iAdvD4UfOhar4Vgce+rH/9mnK/YyVvaIDMfzHSbybbMzODOvp7plBePAE/omgawO9G/szEkowZzIv0bEWB2UATM6lkKZtjwtUw1f0DeVJ2O3Ku3+F1Zq3GNJ9Ls4R9e03jt7QHihM8wq8MF0OWwrTMQQkHFWhW3Lx2xclaqJ/0pWEnxe3dsZ8qxJMUXFddGdTxtye95GyWs0D0hbs1yXxnPPkIgswu4Mf4Xm5ZNtADPPq5c0gaZbEHDSBPGWJ3ePzy9Xeugtwbui1OGH40LXFxdBEoUp8aVnn3jndlJK3QLHY3KMgSRyKsf7CcA9s2vmTLteNLta21Ozzn7ycpnIGMoPoBcowFv1iY/l/vKW7QE/sb3/3fOc+D61oYAijCrhw19mqlc
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(5660300002)(86362001)(8676002)(186003)(6916009)(38100700002)(6486002)(53546011)(6666004)(4326008)(956004)(8936002)(2906002)(2616005)(16576012)(508600001)(316002)(31686004)(36756003)(31696002)(66946007)(54906003)(26005)(66556008)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OEVadDlCMmxueEN1TkNObGZDY0dOdkhzSjJ6UVdNUFVFL3Erb09qa05yS3Bq?=
 =?utf-8?B?aFBGa29wZEQ2UEd4N2RYM21CWVN1T3A3aDQ5Ni9rS1BlcWhtZGF3ZXNIR09J?=
 =?utf-8?B?aHpscnZKM0IyUHUvYmZuU0pYOWszM2lmM2lUQ0M5WmFtR1dKbHE4QkNGL2tS?=
 =?utf-8?B?ZXcyeDl1akl0NE5vRnlnYmdJZFRleitqcWNkMmVUYWFqVDBEOE9xL2p0NlJK?=
 =?utf-8?B?S3N2cVYzYSs3M0pBakcxd01DellHcGY3cThLWFJUaUhuTWxPcWM1bmlnNlNG?=
 =?utf-8?B?VHFDQVlpdzBzbTl3MHdmVXY0QmxUUmJJdWl2RTJPOVAzUFd2OUxuUUd6VVVT?=
 =?utf-8?B?WHRCWnFIZVdFUnVlQWE1Y2llVnljd2czRU45Yk1HMk5YVHFCR1lKSmlSaml1?=
 =?utf-8?B?U0J3cjdVNjBmMFFNbm9vTkZMQzJRamNXQjlxS3dOS2pvYlhwUjhONThVemVr?=
 =?utf-8?B?N3hCbWlJellPVmFEbmVpOHV2R2R3VjM4eVZhQ0FwRkxlcjhsTGcvQlMrTmMy?=
 =?utf-8?B?eVdSWWNNUmFNUWJTRG5xdHQ4YTdFUmpmVks0QTkyODcwZDdmTDYvYWhVRlUx?=
 =?utf-8?B?Uk0wV2RqTkZuK3FwWTd3OFhzdW5pUlVCRzFQbWpTRTZCbVF1d2lvbTZmQ2FC?=
 =?utf-8?B?ZFpYakVScE0xbFo2bVlrVHBFbFZVeXhvUXVVOEV5dENiaVRZSVNBRTNwNmow?=
 =?utf-8?B?aFJrWUlQQkNWUXpBNm5XQ2M5TGtiRTFUaHY0MjNvTlFvbmNJazlrZmFPd2F6?=
 =?utf-8?B?anp0NEFqSkhBSTc4cnVkTytWay9maVRJUjkrZzB2eERuUjczMFlLd2pXMnQz?=
 =?utf-8?B?cStnY3FNaVNYc2h3MVE0dXJGOFBZVmppNnFOMHI0aWNYYTVMd3dUd3VzUjZN?=
 =?utf-8?B?YVBKYndKUXpXNjVzNS9WZFBXeFVRYVE2NkFBQ3lpcVlCMWJ4T1hVcTVlK09l?=
 =?utf-8?B?K3RZSFZNcVlKQ2kxemtxNFcrZ0RqeWRJSG5JQ1AreFQ1clZYR0lFRWJ1eWtk?=
 =?utf-8?B?S216WVZRMGtUSTJ0L0cvOUhMd3l4K1Qra0ZOVGxjTWJqeGFuam5ZZmk2cG9l?=
 =?utf-8?B?NmxVNVgzeGFaZ0RZUDBSNUhoZlJlUW1XYllsN01uTlQzdTh3bDVNUC96bEE0?=
 =?utf-8?B?SkI1djBoSnRNQm5CSU42ZFhXYnJCQ1IzZjAwcVpsaEVjUjVaR1NjdDZ3d09L?=
 =?utf-8?B?WHFIem16ZForSjZiVlVnc2l2R3N1U0JKSndXS1BLYmYxZ1FCaUl0ZVVvenk0?=
 =?utf-8?B?MllwYVRidzNjVzliNFBCWHFOYmNQWnNVeW50RWpmaGJvTVJJUjE2TUxLcVdH?=
 =?utf-8?B?TlhwU1N5Y1FrcWtWanJRNUxSdHlCZDF2K0dXajFJWE14aDJTckZ4UE8vTTR5?=
 =?utf-8?B?akdIb3B5bkdxK2piUjd3WENPL3RJbkpHWnpIcUtUMHpxUkVEdDVFdVNtcGtI?=
 =?utf-8?B?RjVLYlVTVkJLdGFFRmdLK0hCT1YzUG9zLzJFME1nRWc5YVQya3p5YW9Dd2Uw?=
 =?utf-8?B?ODFheFJxRVZCbmpteEpkV3VGdW9QWDgyOGFHUlVnbjhKOEo0L0RiU2h2OHBY?=
 =?utf-8?B?Z0hlSnlTVnY3NFZuTnVJc3h0VVN4RTRIa0hBSXZWZGkvVEhqZUpodllHUmxh?=
 =?utf-8?B?dlNSQUVEcG4rOEFkby9sdVYrUHhhY0ZPbUtUUHVBajdwUVhGUm8raWJyQWsx?=
 =?utf-8?B?alRwdlBJZ3VHTldtZDk0MUdhQjQyTU5lTHJHWjZxaHQ1TUhDbXJncG9Ed1ND?=
 =?utf-8?B?WXdob1hhTktNNGlHT2ZTcWJwRGhya0dVSXVzTDh3ZWF0RHBoaXU3T0lqV3JG?=
 =?utf-8?B?T0xPMUVnVnJLbWhJT2xVSEk4QTNpdWhzRlJvakIxZ3Y2SW9SZmFCSWFwQmw5?=
 =?utf-8?B?N2NRaHF5aVJGSE1PWEFZckgrZmxPbDBOOUg0aGNKTzRtbjA2a25wY1hUTHln?=
 =?utf-8?B?TzRjcmQ3cGcwVWNzZ3N4SWdFOXRhbUgxNiszS0xuR3lZaGJOendTajZEcTZZ?=
 =?utf-8?B?QVZ6Zk8zeXFmVlhJZ2pLaFZEU0dVY25MUStKUmpBWHU2cC8rTjR0anJiekFr?=
 =?utf-8?B?VU5ndHRhK0FqZTIzdkJSa0ttVXpjRDRYS3d6SkhyM1lVZFF5SzVsUzNSTHdn?=
 =?utf-8?B?SHdvU0JVM05YSXFVNS80ckZVQlFvc3ZqSlNPRHVLVVNCdTFtLzZMUE9XUnRX?=
 =?utf-8?Q?L3kpReIikwLu2ODe4AFus5s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2881e67-a61c-4584-8b62-08d9bbe49e47
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:54:43.4450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7HkDXvAmFXv9ae75g6920TfVEQM51i+JsMTbH9jl1Njg4QE1samQo+zccNt3WvvIeg1gl8KEone33cn3VN0udg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 10.12.2021 14:50, Bertrand Marquis wrote:
>> On 10 Dec 2021, at 13:11, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> do_memory_op() supplies return value and has "errno" set the usual way.
>> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
>> also no reason to overwrite "err".
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Thanks.

> But if err can really only be 0 or -1, I do wonder if the else forcing err to 0 could
> be removed but I must say I have no idea if do_memory_op could return a value >0.

Indeed - see ...

>> ---
>> While the hypervisor side of the hypercall gives the impression of being
>> able to return positive values as of 637a283f17eb ("PoD: Allow
>> pod_set_cache_target hypercall to be preempted"), due to the use of
>> "rc >= 0" there, afaict that's not actually the case. IOW "err" can
>> really only be 0 or -1 here, and hence its setting to zero may also be
>> worthwhile to drop.
>> ---

... this.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 13:55:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 13:55:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243911.422031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgMW-0008IY-4U; Fri, 10 Dec 2021 13:55:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243911.422031; Fri, 10 Dec 2021 13:55:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgMW-0008IP-1A; Fri, 10 Dec 2021 13:55:00 +0000
Received: by outflank-mailman (input) for mailman id 243911;
 Fri, 10 Dec 2021 13:54:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h5au=Q3=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1mvgMU-0007xZ-LU
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 13:54:58 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0630.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c2ceb1fe-59c0-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 14:54:58 +0100 (CET)
Received: from AM7PR03CA0019.eurprd03.prod.outlook.com (2603:10a6:20b:130::29)
 by AM8PR08MB5732.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Fri, 10 Dec
 2021 13:54:56 +0000
Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:130:cafe::dd) by AM7PR03CA0019.outlook.office365.com
 (2603:10a6:20b:130::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.17 via Frontend
 Transport; Fri, 10 Dec 2021 13:54:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Fri, 10 Dec 2021 13:54:55 +0000
Received: ("Tessian outbound c61f076cbd30:v110");
 Fri, 10 Dec 2021 13:54:55 +0000
Received: from a94c98eeeee1.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 0EA52B15-7F86-4432-BFCC-22D1E313199E.1; 
 Fri, 10 Dec 2021 13:54:45 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a94c98eeeee1.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 10 Dec 2021 13:54:45 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM5PR0802MB2401.eurprd08.prod.outlook.com (2603:10a6:203:9d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.20; Fri, 10 Dec
 2021 13:54:43 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4778.015; Fri, 10 Dec 2021
 13:54:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2ceb1fe-59c0-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OgUmEoKuPgFly/mXIjTIVDv8sR5DvV82x2TYtZRSKJI=;
 b=85+N2raY0RkGZwE1xjK1ieihV7DmW4YT64oA4PNqG3zFjVycicqdgbamBqB0sBdy6MTttkfJvYvz1q8FWxVeBtuSth0y367gkHFkQYSKIalgl8kIj+E2XgbgxC1oX6TLPX0ajld65W8+d1qKTiiqqAMrrLnxPj2rvBysgnLYz38=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: b894961c9fe67add
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VPROEtATqYUkMrTPh1wZHR9accajIUEyQMMZnqALBMFqfMWjwD/d7yfw92UbYAipU4Z7RCtJWEQbS47vsDYoRQ+H+ityQrgTR4QGZZquA5CBrQZTdRe9aAZ8Bz+S81BDNeVQtXOLaAMRfHxKuwf/QEsNw8cHyWeyFxbtwxcQaSi0ULxcWycuSEy4KnZxpGab0BFoXmfuFoE5kXzfEPA3xhFk65PJMf8HZWkSvIt69IipRDsg2HSlqphOlaBMytNSe1ihe8T5YJ8eEqjuOPrBTJVKgMKRoX3CRHLaFyxL8BmrUp95PONv2x8dl/5nGIkP5r5E1hZ2x1krks0E505R1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OgUmEoKuPgFly/mXIjTIVDv8sR5DvV82x2TYtZRSKJI=;
 b=DUvtEFaR/+622EyzU+9yllBbDXwVjdYAlS3p2KvRayizYWoY0vJiYKB62R9XrervHgSX3p7sHe+LFkCiBEiv2reyTIq+uDEusvGXx6jxEGyH4IpyWojhwjPg7WuXHhl6pkGFMAGpDxUeH2lxJzQW3roHlxJDojOQFJ8mI9vwxiF4+sSw+WIPphFE390nxfZgW+MjR2fOrqXExIhNBkYagZb8Ukt0wBhs7eMuA9CkAjGYlzoBy5dbCMHP5okWZRFjO6TTXm5xOj5x7eWwsrpTxw3+fuB+qgJii3xii7nQ0wrIK/jP5Oh59nq+BpW4kQmlgbuqC4YCfWGbj7slthWqEg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OgUmEoKuPgFly/mXIjTIVDv8sR5DvV82x2TYtZRSKJI=;
 b=85+N2raY0RkGZwE1xjK1ieihV7DmW4YT64oA4PNqG3zFjVycicqdgbamBqB0sBdy6MTttkfJvYvz1q8FWxVeBtuSth0y367gkHFkQYSKIalgl8kIj+E2XgbgxC1oX6TLPX0ajld65W8+d1qKTiiqqAMrrLnxPj2rvBysgnLYz38=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Oleksandr
 Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
Thread-Topic: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
Thread-Index: AQHX7Tg58KQ3i6/mL0iJhWZTO46LzqwrcNWAgAAGoACAACKBgIAAJpCA
Date: Fri, 10 Dec 2021 13:54:43 +0000
Message-ID: <F9B96A75-8DBC-469C-9961-C2CDF11DC5BE@arm.com>
References: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com>
 <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 49a33f71-a549-4fca-ad56-08d9bbe4a5b9
x-ms-traffictypediagnostic:
	AM5PR0802MB2401:EE_|AM5EUR03FT027:EE_|AM8PR08MB5732:EE_
X-Microsoft-Antispam-PRVS:
	<AM8PR08MB573265BF6EF1AE5908F656E79D719@AM8PR08MB5732.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 udNO2H3pgHSVUNwJ7q/bKT03t2ovA/nat9Ec8SXA1yw1nQojsHgmW2wQiAzMUe3vyQyDbT7OBHjkgjVROefW63HZcHx1hWCeMcQf0WzvwMViw/cUmojc2/YogTK1ghuaTNZ+FQIEwff32zboNgGlZnysorMP3zAIO4Yf93bDAg4iu8Pu4b/EkedBTIcQs9bw+/CbHZhdCNUYTFJo3WLDQxhNt6a8AzJIqyv/oheo/v1/f5hCpYaGB5g81/fmUwE43OjCSFqApb4xiQkOCqt3FiIeVdvEkEyqdnlHxUi2PEDAZ6bGzNQZgI21bnom/EJ2Ry8+S2ZPjRiHUOcSUIP+pj8aMwaIA6tWrO3t6JOrQFUSkZONsxZD1j1qXioo/JSJtLDr8bTZ7NpO/KUZIIPb36/XbssaTt2dnvgAc1+xvK1+s3E0GGHWVh5/mp7zZTQA6h+nk3BNXffxwT9X16X4PqLRrLbZbUrTIVKI27PrfRJK4P8dQCZemS6TS5whL7nkEPvGzbTCGYuBCMkJ0sTMAPP98G5ASq7mx1vouUMSTsL53yfWOshgxymAgDV+W+HjN86oO35oZOcdy5hWIdg+9LH+wKbTWSEqZJ5hIIy+9VArTUIhPmGJ4EsjfCdrqburW/Wju4Lh2dMLheabxLgS0zqQMK358jckDbDgGvYdpWMi1GQ0mJX7Jv55qf24DDpuRXduxvNxvSzMnZjPr9bp/zYPwvP3EJCIWwPtavGg/wUZHvU7DUcAAE5EL3hy2n50NFV/tMbPNRA87B/91wy0IxGscpPaMmee0ebKxXYqsK8bEQEbH3f4XbSelGeLRg/fQBqz/dDT59S7mZp3mj0KyQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(71200400001)(38070700005)(83380400001)(508600001)(316002)(5660300002)(38100700002)(66476007)(122000001)(4326008)(6506007)(8936002)(2906002)(64756008)(186003)(76116006)(66556008)(66946007)(6486002)(66446008)(91956017)(6512007)(53546011)(2616005)(33656002)(966005)(6916009)(54906003)(26005)(36756003)(86362001)(8676002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9EF347FE1F15D54CB90464D1CCF4A1E0@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2401
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	18e4facf-b5ba-457b-fb56-08d9bbe49e7a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	srD6NvXL+CRmKBDgUPFR0rgxEV0qBHZKA8UjtCVx4E++JYTBIh1Y3H4hllfzhbmEPELojMPv4VCyCkIzqOVUREAmpfMAdlHnk0GXksfN1ChaRw7e+RwylvGphooWdr69TBEZSkLoU8EaB5FV9QVxlpRsngyto1ayXKKySdY2jXStjoAvxnQED9+MM3giqQeeCYoYSZEsGsQc7Q0FioE8hFNr22PhIDSGzdi7d/nBIQC8ZAfyz4s9Itbw5IMdDDb8ZmRg5fHk/XkgvVeDyxFyI+bc91ykTAR/+C2d2R7+80R4Klzaf6M24+ru/9JkPPr/5oL3bXg5e/EbGu6F9alpj+aBEL2yzhrnZHq/+PMzfL4eFdGoyD/2cWDpGiT7Hc8ZuQp5bVP+Ntuqgbwb3x+gMi2t2dya0hwItzQWDc5kGLwbXulQEBiJieTaJ17kf0NVVFNtGB/4qRz1xXKhNEL7n8DJ3rlQRjRYkF716RktEXyHigT+6lD0K2+wYlzcw0RzLlwHOLvHjeLOcspvMo4qXwJItJocytyVEu+GKrPjDeL5c+Mt0D2EsiiD9VQ6FynHA4gcS/rKbhZ56t40Ey30xN1M9wIGH9GBgIj8p9e8weVplVL3oLKZykhpW9Sczpvcb1rgZfcA2L9yTl5siG5UhCT+FjeD8tQ6oN/7Rp8Fi3q7bYXCPQwuKq0hOr73A5C5/fp8wbcpVoZCAOO2PGsteSikGSf0SoagrI80Se6Z2MH0oxEreEqk4AsvR3S7WUUc49x8adphKTRfEINd426RhjrA6f6C9PI6cglok3Yo9fEWWkye2FrUmJi+Wv7Mj3zXpVt/TAj7NODtphOHIO1NH8lNGI5EzLSoUodqycIXRPG5ooBqDuqm5O2zTU/zehBU
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(4326008)(186003)(40460700001)(33656002)(6486002)(5660300002)(63370400001)(2616005)(6512007)(6862004)(70206006)(508600001)(336012)(6506007)(26005)(82310400004)(966005)(356005)(36756003)(8676002)(70586007)(63350400001)(2906002)(53546011)(316002)(54906003)(47076005)(81166007)(8936002)(83380400001)(36860700001)(86362001)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 13:54:55.6357
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 49a33f71-a549-4fca-ad56-08d9bbe4a5b9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5732

Hi Oleksandr,

> On 10 Dec 2021, at 11:36, Oleksandr Tyshchenko <olekstysh@gmail.com> wrot=
e:
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Xen on Arm has gained new support recently to calculate and report
> extended regions (unused address space) safe to use for external
> mappings. These regions are reported via "reg" property under
> "hypervisor" node in the guest device-tree. As region 0 is reserved
> for grant table space (always present), the indexes for extended
> regions are 1...N.
>=20
> No device-tree bindings update is needed (except clarifying the text)
> as guest infers the presence of extended regions from the number
> of regions in "reg" property.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Changes V2 -> V3:
>   - new patch
>=20
> Changes V3 -> V4:
>   - add Stefano's R-b and Rob's A-b
>   - remove sentence about ACPI for "reg" and "interrupts"
>     properties
>=20
> Changes V4 -> V4.1
>   - bring the mentioning of ACPI back which, as was pointed out by Julien=
,
>     fits in the context:
>     https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f=
6@xen.org/T/#t
>     so technically restore V3 state
>   - remove Stefano's R-b and Rob's A-b as I am not 100% sure they are
>     happy with that
> ---
> Documentation/devicetree/bindings/arm/xen.txt | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentatio=
n/devicetree/bindings/arm/xen.txt
> index db5c56d..156fe10b 100644
> --- a/Documentation/devicetree/bindings/arm/xen.txt
> +++ b/Documentation/devicetree/bindings/arm/xen.txt
> @@ -7,10 +7,14 @@ the following properties:
> 	compatible =3D "xen,xen-<version>", "xen,xen";
>   where <version> is the version of the Xen ABI of the platform.
>=20
> -- reg: specifies the base physical address and size of a region in
> -  memory where the grant table should be mapped to, using an
> -  HYPERVISOR_memory_op hypercall. The memory region is large enough to m=
ap
> -  the whole grant table (it is larger or equal to gnttab_max_grant_frame=
s()).
> +- reg: specifies the base physical address and size of the regions in me=
mory
> +  where the special resources should be mapped to, using an HYPERVISOR_m=
emory_op
> +  hypercall.
> +  Region 0 is reserved for mapping grant table, it must be always presen=
t.
> +  The memory region is large enough to map the whole grant table (it is =
larger
> +  or equal to gnttab_max_grant_frames()).
> +  Regions 1...N are extended regions (unused address space) for mapping =
foreign
> +  GFNs and grants, they might be absent if there is nothing to expose.
>   This property is unnecessary when booting Dom0 using ACPI.
>=20
> - interrupts: the interrupt used by Xen to inject event notifications.
> --=20
> 2.7.4
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:00:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:00:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243923.422042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgRz-0002FC-PI; Fri, 10 Dec 2021 14:00:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243923.422042; Fri, 10 Dec 2021 14:00:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgRz-0002F5-MG; Fri, 10 Dec 2021 14:00:39 +0000
Received: by outflank-mailman (input) for mailman id 243923;
 Fri, 10 Dec 2021 14:00:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=h5au=Q3=arm.com=Bertrand.Marquis@srs-se1.protection.inumbo.net>)
 id 1mvgRx-0002Ez-Lw
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 14:00:37 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20606.outbound.protection.outlook.com
 [2a01:111:f400:7d00::606])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8cab6c34-59c1-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 15:00:37 +0100 (CET)
Received: from AS9PR06CA0415.eurprd06.prod.outlook.com (2603:10a6:20b:461::19)
 by DBBPR08MB4393.eurprd08.prod.outlook.com (2603:10a6:10:c7::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Fri, 10 Dec
 2021 14:00:33 +0000
Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::90) by AS9PR06CA0415.outlook.office365.com
 (2603:10a6:20b:461::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.19 via Frontend
 Transport; Fri, 10 Dec 2021 14:00:33 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.20 via Frontend Transport; Fri, 10 Dec 2021 14:00:31 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Fri, 10 Dec 2021 14:00:31 +0000
Received: from b69a6ea6297a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 810DFF50-1270-4287-A7D7-0EB86FECE950.1; 
 Fri, 10 Dec 2021 14:00:08 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b69a6ea6297a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 10 Dec 2021 14:00:08 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25)
 by AM5PR0802MB2402.eurprd08.prod.outlook.com (2603:10a6:203:a1::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 14:00:06 +0000
Received: from AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d]) by AM6PR08MB3784.eurprd08.prod.outlook.com
 ([fe80::c0c1:d43a:acf3:a59d%4]) with mapi id 15.20.4778.015; Fri, 10 Dec 2021
 14:00:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cab6c34-59c1-11ec-9d12-4777fae47e2b
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r8VcXUS7sdOt5uyX20vcLsKw3rFrqEpG93aATo8RQXM=;
 b=G8ENUtBd/jrOK0AnIQK6TZdT6d+2AW7LsEC7yc0JfJAxl90n8hqbbbv+SsDwNM7iQ5vdZ+ConDLRDZBJx/2t2mErX8Iv9z5duUldfOtHy3bsYVtuWuv7/sxwTtnlUq4PJxijiGOkzmscz+aFKytCoFlv/vFB0IrFKsZF037LbwM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=bestguesspass action=none
 header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 47d53ee55da4dfa4
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EmcK67p91UcB++XIVeJZKXEHH5NToIjzsUwKFsHJEQmWQCEM+5Xdx/03Jrq2AjZdSVn/ccIAm2UtWSI4dnGdrFje6TZXd3D1g4Xk0/K16xPX3ssgX5J3DxrYMvas+5dKdBaY0T5j3zcbvQKOkqYfFqssyjSOXI4rnfYShY2oC3Ro+s6qIc1d4XamygGri50xiwshM/N3OQbRblzYTnwiSWTizk9nXszwrsOa+10w/GIT7iTjaItt5hz3gH1nRUp4fpBC7yDIbn4bcd5yJjIhBYE0LU2CJhYtKcE6nIBoLDM2GESK7eGoaaatVGcQXU9wXi3K75NFWrpVoQJGZ2h18Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r8VcXUS7sdOt5uyX20vcLsKw3rFrqEpG93aATo8RQXM=;
 b=fHlZz+EDOWgqM8cZ1oYO2yWxtVmXe+nHEazcP8zg9n5GEAfe89OuRr4LBamIM3pqAAD6gSWcZ033ioRyRHfPAVUbUopQ8KgVPSOONOABZWuC+FwgxMA7vdYILTj3v4VeCFmcwo1WZntZXRpFinP7lFihD+QN4GjTKGlS3iiVj1Y0my2Hru2CHKZJMbAgDVud7Zrg8Kz+e2aV1lew83jsIfFvJn5Y0l9jJXiq6uqOx7XwxklrbSnUU1gQPYJ0AxXETMc0m7F7HD+sgHUyTS08pt0LjPstsiL/SBiOYxIBYjnK9SnH9YbTW2r3Na8ka4DlNiaFVrxI5jIjavE7iz1UrQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r8VcXUS7sdOt5uyX20vcLsKw3rFrqEpG93aATo8RQXM=;
 b=G8ENUtBd/jrOK0AnIQK6TZdT6d+2AW7LsEC7yc0JfJAxl90n8hqbbbv+SsDwNM7iQ5vdZ+ConDLRDZBJx/2t2mErX8Iv9z5duUldfOtHy3bsYVtuWuv7/sxwTtnlUq4PJxijiGOkzmscz+aFKytCoFlv/vFB0IrFKsZF037LbwM=
From: Bertrand Marquis <Bertrand.Marquis@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Thread-Topic: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Thread-Index: AQHX7ceTNtjLavE+e0K+in6YCJvpZawrvk0AgAABFoCAAAGGAA==
Date: Fri, 10 Dec 2021 14:00:06 +0000
Message-ID: <943FCC51-08E5-49BD-8B24-AB516AE6C76A@arm.com>
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
 <52F30125-172C-4AC8-B3A6-104D7914CDB0@arm.com>
 <d23a7603-47c2-43b5-5365-02f437fd46b1@suse.com>
In-Reply-To: <d23a7603-47c2-43b5-5365-02f437fd46b1@suse.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-mailer: Apple Mail (2.3654.120.0.1.13)
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 7cfa29df-7db8-46a5-5232-08d9bbe56e34
x-ms-traffictypediagnostic:
	AM5PR0802MB2402:EE_|AM5EUR03FT060:EE_|DBBPR08MB4393:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB4393AD17BB5B1855FE1A20E69D719@DBBPR08MB4393.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dxUDZ/mqSIaOZp+LQf/GfBywZ4NmDVUWHZCP78yjIYbEYwP0JkCqH/3BIWtrYj/ceDw1Fb9Un+1MOKzEg04hvlnj8Ai/pximODSjTqOhph69omfTUkG9ehv0mGzSi1GWe0IJb8lx7R/nsb/603BtRiejt9v5kgPg7EN4WGptKCsUpvAf5NpNCEwA61z97LoHm+XNxyuqlD6A3pyt7xPtASVg9OIeLO3SpHQZpyoSj38gJAw37KmId8RquMwUxFPcRUSP4gW9yeyfFzG/STWdAaUblvN+f0jnxwCzSA7rSib2CB0cxvaPRmBx2jGP5GNOFYwg6tXb6MRXK6IiLJ4iH9HyK57BEdQJZM01AhEpQ4jwpJW7RRq5mVneku45ACneH409+bduElLkFJDUhzN2spr3yZKRkCze/XkBVZ6iqNMWtTHRMC9tIuoWhh9vM3qUf6XiSEZ+7gh2uAk39dumNILsMR3RhsOel+P3HGtD37F/btWT1qHwbhsEzzdJ9YEgceDxIYdgyED3Grbfs9l5QxT68B7Sn5tJLcCdJoJmg70sKLV7SDzAz8c1GGnCAhyCpXNiFCRM0/zSaeUx+3UTgyicgg5SHsvdn1OD7+qaC3JqZ59U9XYxUftJV/bNH7R0juQJDF4QuvdNG425vdY1jwYdKfXm7yOlixGTQ8zbAe2jv2RsHf2Z9GsLY6j5Zg8BlbBjUVi+xey0lTFJ4pAgnqOt6KqzxTc3en1weBVF6zdIxgXwFmp7V7rvAGQaq4nF
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(6486002)(186003)(66476007)(36756003)(316002)(508600001)(64756008)(71200400001)(2616005)(26005)(6506007)(53546011)(66556008)(8676002)(66446008)(4326008)(8936002)(66946007)(76116006)(91956017)(86362001)(38070700005)(2906002)(38100700002)(122000001)(6916009)(33656002)(5660300002)(54906003)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <98CABEEB28EB1B499D8219155593753D@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2402
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	aca2aaf6-b512-40d7-9bfb-08d9bbe55f1d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uqvw894f2JH3Avfpkaw4aVWTgPxAin+ZnGNHB4FImHw1A9qv33KtbSostZlFeaBRXm3Ul6541dLXNfGb4ugxe389MQcK6D63J4LG36PS27CJl9mos6FL080YRd9pvLYv76BzAaeJrWqcUJQiFyIMhVqO71cdyFObqMAzjHgg4boOETGhx72LOIZth7bXKq3turrChel+S39O1gaG7HsaznxMFxWl/BcvO8c3BRjbWPSh1jazIzn1zRoPK8EVBE4+NzMvfgdXf9dCZPy+uDs9/5pQFpErfGsWoOLlEz4US1y/4/GurPOLqtgJcvwIAlRF8o6Wuz7bEmF50fzJNLmCJNDRt1hvBbB44RHRuHrQPCJU0GQAuBYRXTen/yDOe0E2cdIEo2PG6LmtOo4+m249+xf3Px0ibN3K4UM/Fd93E57n63+WITewa3GRrD6GfO0w/pJxHOVsaDy6NjYxCm0sK4tHKjKRFDjHOojIOyP6oOKCGSl7yqMx+x2VgQl8tYdk/Ajk3JQk0Wd6nH7dPleldHOZ5CeCR6bxrPB/RQhmQz1T+/Zyc6Lyh4qePIkgrGnWhpTLxoofIC69xMDOsIFKuDxGfdfGFPesE8kPZNRzfZHZr4CULvtjL/J11LiMHcYBKcPpdHDzLNABe6tQcrbMzNsp2Bu655kapCB4zWujSLny3jqMCp+yDBw1QyVpg5aFMRTkJ9GgKYVSDDJ92W7kTjtGGPAr5kMJdzBpHG1RUgr+rrhoNYqJXAIp1mqkYTQkWJxjiqvXV1WYhxVPckZC8Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(70206006)(70586007)(36860700001)(186003)(6506007)(6486002)(26005)(82310400004)(8676002)(33656002)(316002)(6512007)(40460700001)(53546011)(86362001)(508600001)(107886003)(6862004)(5660300002)(36756003)(81166007)(4326008)(54906003)(8936002)(356005)(2906002)(2616005)(336012)(47076005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 14:00:31.9838
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cfa29df-7db8-46a5-5232-08d9bbe56e34
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4393

Hi Jan,

> On 10 Dec 2021, at 13:54, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 10.12.2021 14:50, Bertrand Marquis wrote:
>>> On 10 Dec 2021, at 13:11, Jan Beulich <jbeulich@suse.com> wrote:
>>>=20
>>> do_memory_op() supplies return value and has "errno" set the usual way.
>>> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
>>> also no reason to overwrite "err".
>>>=20
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>=20
> Thanks.
>=20
>> But if err can really only be 0 or -1, I do wonder if the else forcing e=
rr to 0 could
>> be removed but I must say I have no idea if do_memory_op could return a =
value >0.
>=20
> Indeed - see ...
>=20
>>> ---
>>> While the hypervisor side of the hypercall gives the impression of bein=
g
>>> able to return positive values as of 637a283f17eb ("PoD: Allow
>>> pod_set_cache_target hypercall to be preempted"), due to the use of
>>> "rc >=3D 0" there, afaict that's not actually the case. IOW "err" can
>>> really only be 0 or -1 here, and hence its setting to zero may also be
>>> worthwhile to drop.
>>> ---
>=20
> ... this.

So the else should be dropped then, why not doing it and just mentioning it=
 there ?

Bertrand

>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:09:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:09:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243931.422052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvga1-0003cO-OR; Fri, 10 Dec 2021 14:08:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243931.422052; Fri, 10 Dec 2021 14:08:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvga1-0003cH-LR; Fri, 10 Dec 2021 14:08:57 +0000
Received: by outflank-mailman (input) for mailman id 243931;
 Fri, 10 Dec 2021 14:08:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=XN5i=Q3=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mvga1-0003cB-2r
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 14:08:57 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b658818c-59c2-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 15:08:56 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id B34A8210EB;
 Fri, 10 Dec 2021 14:08:55 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7160A13E15;
 Fri, 10 Dec 2021 14:08:55 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YxB2Gndfs2EwPgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 10 Dec 2021 14:08:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b658818c-59c2-11ec-a831-37629979565c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639145335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=R/SnpVNZWJZI6uRNlWBRxtIlUrMOirq33a397sqbAto=;
	b=nzQRS+YmQUnDNC2ShnmjFibscihx6A8kt1B8Rscn1iZmjVsInQEjRN0XLsC8OGon/zeCDj
	oNyZMhuw1RHCty02hwCZmzKH6JqL2HEZ40kbP5M8HaLH7o7J0tSlC5NCWXVNacqqlwiymx
	OgNMw5C8+d6KxOx4d4bDvrM1OkBtLSk=
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
 <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
 <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>
From: Juergen Gross <jgross@suse.com>
Message-ID: <570a65b7-c1e8-9df7-ab63-c49d7a66c1d7@suse.com>
Date: Fri, 10 Dec 2021 15:08:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="5UuzIKPfCNrsPlCJEb65VaLjIw0vuHyFv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--5UuzIKPfCNrsPlCJEb65VaLjIw0vuHyFv
Content-Type: multipart/mixed; boundary="Sr5lyqBjxBx0pbn3TvoIMX8d4iyHJ7i7t";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
Message-ID: <570a65b7-c1e8-9df7-ab63-c49d7a66c1d7@suse.com>
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
 <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
 <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>
In-Reply-To: <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>

--Sr5lyqBjxBx0pbn3TvoIMX8d4iyHJ7i7t
Content-Type: multipart/mixed;
 boundary="------------FEAFA61F84394C49F81238BD"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FEAFA61F84394C49F81238BD
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 10.12.21 14:49, Andrew Cooper wrote:
> On 10/12/2021 11:16, Juergen Gross wrote:
>> On 09.12.21 18:07, Andrew Cooper wrote:
>>> The values are already available in dom->{console,xenstore}_pfn, just=

>>> like on
>>> the PV side of things.=C2=A0 No need to ask Xen.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Wei Liu <wl@xen.org>
>>> CC: Anthony PERARD <anthony.perard@citrix.com>
>>> CC: Juergen Gross <jgross@suse.com>
>>> ---
>>>  =C2=A0 tools/libs/light/libxl_dom.c | 17 +++++------------
>>>  =C2=A0 1 file changed, 5 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_do=
m.c
>>> index c9c24666cd04..03841243ab47 100644
>>> --- a/tools/libs/light/libxl_dom.c
>>> +++ b/tools/libs/light/libxl_dom.c
>>> @@ -722,13 +722,10 @@ int libxl__build_pv(libxl__gc *gc, uint32_t dom=
id,
>>>  =C2=A0 }
>>>  =C2=A0 =C2=A0 static int hvm_build_set_params(xc_interface *handle, =
uint32_t
>>> domid,
>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 libxl_domain_build_info *info,=

>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long *store_mfn,
>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long *console_mfn)
>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 libxl_domain_build_info *info)=

>>>  =C2=A0 {
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct hvm_info_table *va_hvm;
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uint8_t *va_map, sum;
>>> -=C2=A0=C2=A0=C2=A0 uint64_t str_mfn, cons_mfn;
>>>  =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int i;
>>>  =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (info->type =3D=3D LIBXL_DO=
MAIN_TYPE_HVM) {
>>
>> What about moving this if () to the only caller and renaming the
>> function from hvm_build_set_params() to hvm_set_info_table()?
>=20
> Because I was hoping to delete it outright in a subsequent patch.

I'd suggest to either do the renaming or to add that subsequent patch
making this a small series.


Juergen

--------------FEAFA61F84394C49F81238BD
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FEAFA61F84394C49F81238BD--

--Sr5lyqBjxBx0pbn3TvoIMX8d4iyHJ7i7t--

--5UuzIKPfCNrsPlCJEb65VaLjIw0vuHyFv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGzX3YFAwAAAAAACgkQsN6d1ii/Ey88
xgf/TqIDbz6aLqT5UU3+Gz/0PAojlWNkNqI/VbB8bVv+IBmByEKcRPPflmiX5lln9kn7A+7fxOJ5
OgJGj7iCi3UhLONhfzFltquV//hpAyim5HGb2kGy7DSn+H3k9aG00YilozLAMqbRm9FQ9dd81x3N
g5YjfAE9ZGNzoqdDjH1l2BeWMH1OTIln0i9df5JCTz7XYn0QuCj1GJyKMadtYH/1nghoLeQO+IUt
zUCuyHLgs1A/UfA5UpowMs4I0wQJKSMWvU9hoeTFDvCmQiL6V4Q4Tz7Gf8jZJ/kxCmtBqTQV+dTX
1Z+o67VKVyYdVZd4jvpXe/4mvpiBto5/bNctzCvZDQ==
=Qx/I
-----END PGP SIGNATURE-----

--5UuzIKPfCNrsPlCJEb65VaLjIw0vuHyFv--


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:10:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:10:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243936.422063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgbg-0004vQ-3M; Fri, 10 Dec 2021 14:10:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243936.422063; Fri, 10 Dec 2021 14:10:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgbg-0004vJ-0I; Fri, 10 Dec 2021 14:10:40 +0000
Received: by outflank-mailman (input) for mailman id 243936;
 Fri, 10 Dec 2021 14:10:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lrZX=Q3=epam.com=prvs=297895717b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mvgbe-0004uH-P1
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 14:10:39 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f224c620-59c2-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 15:10:37 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BADvGtk028708;
 Fri, 10 Dec 2021 14:10:32 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cv514gwk0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 10 Dec 2021 14:10:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB7489.eurprd03.prod.outlook.com (2603:10a6:20b:272::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Fri, 10 Dec
 2021 14:10:28 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.014; Fri, 10 Dec 2021
 14:10:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f224c620-59c2-11ec-a831-37629979565c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WCnfRY1zBNpRnHAD14NSDROhtnJuXqvpYQi+CT1vbrcOWZ7NOZWNPyorW3BAp35Ejxx4dqluOr440nLgvimWKfWbpHyO6Cy8d5iSECS0GYjNeu8luSqSOh801CdgFKwHzf44V66EsL9GOHgsiqJznoFHTm6BobOOuw/w+zForsLpIDsM+38fnxXe0z5/NaVUVA2oW903v3Q5Y6AwkpBlndJVHR9Gnla6Hm/yAC5dDLc2SC2+xnzUL291bMv4+bt5L7OLnzta/hR/EArADaZnSbEMPWsvmNo6v0XSE0/oBvoJfIn07RDNAoGTqnaB6ZQWBG33wTAK0Amd2Yja76DfEw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LSoCI3dltpLEeJA328S4rqhWi2HKNZDYD9QN7yG2rmM=;
 b=nvL+SqCdYRPVV3HQL+wLONiBDp1KG2KaenTQv1hT2fFtoKz4KCHEKT9/MeJTt0PPVzw6pAWyAu7sYfkkbQM35j3d6Si/+4FJoFgPx+LJx/ReREFlp8ZP4YSIOyTohKZhOZ0xAxSXROEp0Y23CY1ztRY+tkKFMn9IsVxGJdmAV/7NT6NxkbQjTbbsp/iiadfcZ5zCr1q4GVTrITTBew79+cTnocaeg/DoFHh/BFcG1rc+bVTyFMtYbw1P9Vzcfk73fvNEj75JXg7MYK0vUF+4ko0CGMI/XRphKM+m8vhk9d16sZBdnUhqWAgfgAuD+rWfsw8gQoRTdrKVg2yE9nie0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LSoCI3dltpLEeJA328S4rqhWi2HKNZDYD9QN7yG2rmM=;
 b=mZQd6qoGGFgC5/kJwHPMLeKDQA3N2DK6kHlZuYb+93jSV3TCvWIlqys4DMNoKPwDfzr8Z6xCEFvUImZ+1yGXDQg8nncM47CV3geVC3hl3HatDiYY+IwxWwodzLOBidyYSLXuA8y4IrCKygRAR0FMSrMZ5fzE6BpjPqiqftFD5lz8IWnRPZAjr4tfoM66kDKDlQcgYwROJNvN/Aso4DvKXTYXgz0m/kH7kH3CMEkPLjJo7Rbzs0fuYM64aNZZi+Q/6AzhQ+fs+WziLgFTh18MZdlnZP4nBqFCn6u8VbUAbGZkpcjo9sFAKFWgp2+kP8eXgaKoowDPQN1n1RdlWXdciA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Julien Grall <julien@xen.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
Thread-Topic: [PATCH v2 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
Thread-Index: AQHX7c+uYXqxle9/kUKbI3W3gcIfZw==
Date: Fri, 10 Dec 2021 14:10:27 +0000
Message-ID: <612735b2-8af6-782d-35cf-526841109170@epam.com>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
 <0b68ff3a-3c82-f800-4d20-17eded13163a@suse.com>
In-Reply-To: <0b68ff3a-3c82-f800-4d20-17eded13163a@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bd5e35e2-b1b5-434e-8979-08d9bbe6d16c
x-ms-traffictypediagnostic: AM9PR03MB7489:EE_
x-microsoft-antispam-prvs: 
 <AM9PR03MB7489E853407939A15DB3439AE7719@AM9PR03MB7489.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 lWxaSM1OPNTzkJTD/WprdybW6WbRvuj1EwrcArFirBZdpVue+PDiGXDTX+1TXCebY6syxNWKEIaGQHtanEyeunJWYSIYCpw3Nk47+uuzfReHgxpCa8FjAwTEoNzDADyXYLmrE0XtLb3NgY1ePtVqAiwdkvwZ9/0IEXD1mc8reHqHV107pbUrNW+k8Am1KpqTAizMy8Jo4Syik4qwe3T6nrGdlJb8tmxfcyuHwxnBMl7Ikk4AmI/yig/ufeuxtKj9zl59tphyTDb+w4F9x0Jb908vBipozeMPCfqALEx1d84mYu4qtfIi3Btyd/3QmPijHf5OClfE0agHa9pQwmFLQhzDx32q6r4rX2f8OWwmL3rqUoSNVAJKrQ3a+blsYLPzeONdLvOEDIXoHYL4P1RdIn/FGHiZ7SpYisSb/Z/ySuFjQGyDhRtnE5S/49/p3NNoP/FEiWCsAud0dj9sl1K+l4JAS9T/2rLuekcnYJ4Xs7Jn+6blmuHPB8mQNlaq1Nry3v2cVTKCrA+fCnq37gZTkOxRsVkar+oiS52HuHvUK9QLFR7Ra4J28gM1EtjBCxiQA4XT6U7Y3I/B5UxqwFEIzhe0HJmFlxJ8spy7kh0jCnd1p2SwNwz5fCM3PudUZoF+moCMov39rHXqdAhX49Pw1mnvA5hWpvnypKfl0ekZ6EkgaCZgweXCwSUTdT8BMVnHTOb6BKKqtWX2SbNOzolPR7WUNFWL35RJcjlsf+dKHoyfxvB/0qT7upS6mXPU4e3A
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6512007)(31696002)(76116006)(508600001)(66946007)(91956017)(110136005)(86362001)(5660300002)(2906002)(2616005)(122000001)(64756008)(71200400001)(66556008)(66476007)(6486002)(66446008)(38070700005)(186003)(83380400001)(26005)(8676002)(4326008)(31686004)(55236004)(6506007)(53546011)(54906003)(38100700002)(8936002)(36756003)(316002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?N0p5bksyZ1hNclJtbGx4ZkZCdHdYcnNoSU1YL3Z5YTFqSlBvUVNBY1lZaVda?=
 =?utf-8?B?T1BObTByNUFTWldBRG83bmVZYXh1T0lET0VZbzd1RG1EZ2ExR0ppbHlkZ1pX?=
 =?utf-8?B?SFRzSGx6Sy9XRDk3YmFMWWFHWVZxZVRFUDFleGFIbHVmaWZ0Rzdjdk15VzhJ?=
 =?utf-8?B?SXZ4QUNtcjFaKzVxWVVxQXVWcnViRE45SVRSYTJheW9FL0NnUDMzOUZQTFdP?=
 =?utf-8?B?WitRWklPdC9DYTM2ZjhYVk9QWHczRTZzOHFqYmJXMDFucEl3Tlp2eWRRVjh1?=
 =?utf-8?B?eG9Ob0ZVdEJ1d044ZzM4Q1lyR0lXdEVHQVBVbmp2eHJXRGNwclZSMDhaWVVy?=
 =?utf-8?B?WEZQYVlnN3lxaCs5eEpteGlYMmtUMDZwVDg2ZGIzcXFXdVZNWHVIZTBueDB1?=
 =?utf-8?B?WXZ5OWRBU3NPNTRSRE5xWDFmZXk4V3VuVnl4bkZGREFEUkVML1FaYlY0ZWdT?=
 =?utf-8?B?Sk5JeEd4RUxPZ00rMll4R0hURHlsbFN3Z3FnK1l1ckdjYkhaamJya2FlQVcx?=
 =?utf-8?B?TlFwaDl1R3h6QWZ2eEdnaENIdDdpQ2dGTGF2b2hxcHl5bEZYZ1MrUDByaUVK?=
 =?utf-8?B?M1NIKzhzR2pkWjFkQmVEUTF0NEJVSUNvM1hLaDhSckk3ZHlNL0JLOEwwVXI0?=
 =?utf-8?B?blNaOEZYZ2QwM0pVR1BISnd6TXNZT0ZXNTVTclYzQi9hRmhJK3ljTDJRbHBM?=
 =?utf-8?B?dThjOTZxcElEdDAvaDZUdkVuc21sUEpFSEtmNE94MWVpVlNTRm40TUYzTGpo?=
 =?utf-8?B?WlVLdXRVMmFSYXlhZmhJQlJRcnI5YVVnY3Bra3V2dDJtMzNBWTFhN2RmaGQv?=
 =?utf-8?B?aDFoQjkvd1N6YzF0VjZ1WHdEVXMwN01PUU4vZXNTOFNxU0Rld0JRTmJiU0ZQ?=
 =?utf-8?B?ekFES0I0RUt6L1BiUUFmT3VuZ0d0T2Q3dFZOWWVwODdUbUtPd2pnVlIzbjMz?=
 =?utf-8?B?dnVXc1ZYUTJOVnFMMk0rSEhTWDlCY1BqM29LdTk3QkJOcVhBRmpnMVJSQzZG?=
 =?utf-8?B?SDZjMFNRejRyVnY3K0ZUT0prWmZ1VnZBK1U3RjE0bDdCSlFzbUJJejZnMjlt?=
 =?utf-8?B?Q3owQ0hSeS9zb2FXWmdMNk1FenRneUEzWFA0Rmx0Y1JnbXZHWVlVMEVhVzlU?=
 =?utf-8?B?bzIvK3RTV2Z5eEhyUWVSYWJ3V0g5U1RDU3pGTkNENVNhUlFta0dEYVo0QUM2?=
 =?utf-8?B?dDJZN2JqdUxlQ0MvckZtTVdraGxmMHpseDA0V3pYZjc1YWkxeCtta2tzWEV4?=
 =?utf-8?B?MkFBdmYrRGJLMXBvSkd1SzdDOXBwTHF4dWc2dk9lY1R6cUJKQUxsdEFGU3pR?=
 =?utf-8?B?R0hsRUtwczZtcDFjY1lucUtSMTB2VjREQXZ4T05pSk1kblhHTEJKVU13UkZh?=
 =?utf-8?B?QVk1YUx4TzdJa3FhYy91QjIyT0ZEeEhmU3FDZFU4ZndtelR4eVh3UXRFZ3ps?=
 =?utf-8?B?Z3VTMDVXTkI0MjJZdExnVjRrSGhjQnhRTVlTd1FWZHBPQU4vanp3M1hqUW1C?=
 =?utf-8?B?T1Z0Wmx3YkhKa0Qremt4NzR2a0JFbUNJVXNTb3lLRTJ6eE1JdWxkelJlZzB5?=
 =?utf-8?B?czZhdytudWN1WTZsd0IxNUdBTzBLRVdHckZvOEVZL1dPU2VPeTM2YkRVbzNR?=
 =?utf-8?B?dGpOU0lIa1V4eDJibXlNZFc5S0sxdXNtYnRFK0hTS2JIazhYUThhcm1Hd3p5?=
 =?utf-8?B?QjI3Q0EyS1gyVW9yL3pNVHZPNmJDakYzSGoybklzNS9lZmhKRGJPaGJhNWZv?=
 =?utf-8?B?STNNUkw5dElPSUl4RW80MGhaM3ZhTXR0blZyTXloNmlzOEFCcitvRWF0cUdQ?=
 =?utf-8?B?ZlJiaGMxRU9aVldzb1JHdTZQY3plVkduSlluZFdlVVBmZ1d2SERYUEVMYjlI?=
 =?utf-8?B?K1BhNjBHYlJIK3dyOHY0Q29Od3VRUGJpNVhBQjRwU3JxemRHUHd2eFhnVXRm?=
 =?utf-8?B?dGUxSnBDWGs4bjhNL3A0SldpUDFycHFHZnZ6QlFaZEw4eGNHaHI0R0dLdEYv?=
 =?utf-8?B?cUNoeGg3WTZFTnNtTUtPQk9vaTM3L2tia1dicncxVnh0S1pKTm56QVZ4czM1?=
 =?utf-8?B?STVVSGZFUFMrR2ZRL2RFU1RkMVlJQ0YyTXUyaG81UVlkS2I4QlFmMTdaRjVI?=
 =?utf-8?B?Vkk5MTc0NGFmanFCM3lCVzFSQWpEZDdzN1o3Ylpyei9IUllMclFVbmY4NHla?=
 =?utf-8?B?bUFnQXQrWWZFZkx2MVZNWkJUQitBa3RqTEVZSWVMUmczSG5FNlVqZjM4RW9r?=
 =?utf-8?B?blRvUG13eXV5NkNTZnRKaFRhNEtYZ0pzNXgrVXQwYUtaTGk3S1Z3SlkwS244?=
 =?utf-8?B?WFVydUFzSTVnRk54MkRBZDdJY0lLYTRuemdpQnlGQjRmWkFQTmExb1FYOGEw?=
 =?utf-8?Q?maLAajthotMHYsgw=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6825AE57592EC7429D181F6ED9426DA1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd5e35e2-b1b5-434e-8979-08d9bbe6d16c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2021 14:10:27.8809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pBtccic345amm/t2iF8UqVxDsLTE+FH+9ldQ9ytOxJ1AwLO9f6aWdFFzRohCdFAnV63XZ691GKLI5hFKTkMGw0u1E4A3fFGrZ2hBx2BxG0MHn18fByPbGGJ8OR+3zPmC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7489
X-Proofpoint-ORIG-GUID: wnl-E7HRN3vkVZd3HDb9Uvl_pUHxFaZX
X-Proofpoint-GUID: wnl-E7HRN3vkVZd3HDb9Uvl_pUHxFaZX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-10_05,2021-12-10_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015
 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0
 mlxscore=0 bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=953
 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112100081

SGksIEphbiENCg0KT24gMTAuMTIuMjEgMTE6NDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBEZXRl
cm1pbmluZyB0aGF0IGJlaGF2aW9yIGlzIGNvcnJlY3QgKGkuZS4gcmVzdWx0cyBpbiBmYWlsdXJl
KSBmb3IgYQ0KPiBwYXNzZWQgaW4gR0ZOIGVxdWFsaW5nIElOVkFMSURfR0ZOIGlzIG5vbi10cml2
aWFsLiBNYWtlIHRoaXMgcXVpdGUgYSBiaXQNCj4gbW9yZSBvYnZpb3VzIGJ5IGNoZWNraW5nIGlu
cHV0IGluIGdlbmVyaWMgY29kZSAtIGJvdGggZm9yIHNpbmd1bGFyDQo+IHJlcXVlc3RzIHRvIG5v
dCBtYXRjaCB0aGUgdmFsdWUgYW5kIGZvciByYW5nZSBvbmVzIHRvIG5vdCBwYXNzIC8gd3JhcA0K
PiB0aHJvdWdoIGl0Lg0KPg0KPiBGb3IgQXJtIHNpbWlsYXJseSBtYWtlIG1vcmUgb2J2aW91cyB0
aGF0IG5vIHdyYXBwaW5nIG9mIE1GTnMgcGFzc2VkDQo+IGZvciBYRU5NQVBTUEFDRV9kZXZfbW1p
byBhbmQgdGh1cyB0byBtYXBfZGV2X21taW9fcmVnaW9uKCkgY2FuIG9jY3VyOg0KPiBEcm9wIHRo
ZSAibnIiIHBhcmFtZXRlciBvZiB0aGUgZnVuY3Rpb24gdG8gYXZvaWQgZnV0dXJlIGNhbGxlcnMN
Cj4gYXBwZWFyaW5nIHdoaWNoIG1pZ2h0IG5vdCB0aGVtc2VsdmVzIGNoZWNrIGZvciB3cmFwcGlu
Zy4gT3RoZXJ3aXNlDQo+IHRoZSByZXNwZWN0aXZlIEFTU0VSVCgpIGluIHJhbmdlc2V0X2NvbnRh
aW5zX3JhbmdlKCkgY291bGQgdHJpZ2dlci4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxp
Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gdjI6IEFkZCBjb21tZW50IHRvIEJVSUxE
X0JVR19PTigpLiBBdm9pZCB0cmFuc2llbnRseSAjZGVmaW5lLWluZyBfZ2ZuKCkNCj4gICAgICAo
Ynkgd2F5IG9mIG5ldyBwcmVyZXEgcGF0Y2gpLg0KPg0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vbW0u
Yw0KPiArKysgYi94ZW4vYXJjaC9hcm0vbW0uYw0KPiBAQCAtMTQ3OSw3ICsxNDc5LDcgQEAgaW50
IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoDQo+ICAgICAgICAgICBicmVhazsNCj4gICAgICAg
fQ0KPiAgICAgICBjYXNlIFhFTk1BUFNQQUNFX2Rldl9tbWlvOg0KPiAtICAgICAgICByYyA9IG1h
cF9kZXZfbW1pb19yZWdpb24oZCwgZ2ZuLCAxLCBfbWZuKGlkeCkpOw0KPiArICAgICAgICByYyA9
IG1hcF9kZXZfbW1pb19yZWdpb24oZCwgZ2ZuLCBfbWZuKGlkeCkpOw0KVGVjaG5pY2FsbHkgdGhp
cyBpcyBvaywgYnV0IHJlYWRzIG9kZCBub3c6IHRoZSBmdW5jdGlvbiBtYXBzIGEgc2luZ2xlDQpw
YWdlLCBidXQgaXRzIG5hbWUgaGFzICJyZWdpb24iIGluIGl0ICh3aGljaCBtaWdodCBhbHNvIGJl
IG9rLCBlLmcuDQpmb3IgYSByZWdpb24gb2YgYSBzaW5nbGUgcGFnZSkuDQoNCkkgdGhpbmsgaXQg
aXMgd29ydGggZWl0aGVyIGltcGxlbWVudGluZyBmdWxsIG1mbiByYW5nZSBjaGVjayBpbnNpZGUN
Cm1hcF9kZXZfbW1pb19yZWdpb24gb3IgcmVuYW1pbmcgaXQgdG8gc29tZXRoaW5nIGVsc2U6DQp3
aXRoIG1mbiBjaGVjayBtYXBfZGV2X21taW9fcmVnaW9uIHdpbGwgaW5kZWVkIGJlIGFibGUgdG8g
bWFwDQphIHJlZ2lvbiBjb25zaXN0aW5nIG9mIG11bHRpcGxlIHBhZ2VzIGFuZCBwZXJmb3JtIHJl
cXVpcmVkIHZhbGlkYXRpb24uDQoNClRoYW5rIHlvdSwNCk9sZWtzYW5kcg0KPiAgICAgICAgICAg
cmV0dXJuIHJjOw0KPiAgIA0KPiAgICAgICBkZWZhdWx0Og0KPiAtLS0gYS94ZW4vYXJjaC9hcm0v
cDJtLmMNCj4gKysrIGIveGVuL2FyY2gvYXJtL3AybS5jDQo+IEBAIC0xMzU3LDE5ICsxMzU3LDE4
IEBAIGludCB1bm1hcF9tbWlvX3JlZ2lvbnMoc3RydWN0IGRvbWFpbiAqZCwNCj4gICANCj4gICBp
bnQgbWFwX2Rldl9tbWlvX3JlZ2lvbihzdHJ1Y3QgZG9tYWluICpkLA0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgIGdmbl90IGdmbiwNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln
bmVkIGxvbmcgbnIsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuKQ0KPiAg
IHsNCj4gICAgICAgaW50IHJlczsNCj4gICANCj4gLSAgICBpZiAoICEobnIgJiYgaW9tZW1fYWNj
ZXNzX3Blcm1pdHRlZChkLCBtZm5feChtZm4pLCBtZm5feChtZm4pICsgbnIgLSAxKSkgKQ0KPiAr
ICAgIGlmICggIWlvbWVtX2FjY2Vzc19wZXJtaXR0ZWQoZCwgbWZuX3gobWZuKSwgbWZuX3gobWZu
KSkgKQ0KPiAgICAgICAgICAgcmV0dXJuIDA7DQo+ICAgDQo+IC0gICAgcmVzID0gcDJtX2luc2Vy
dF9tYXBwaW5nKGQsIGdmbiwgbnIsIG1mbiwgcDJtX21taW9fZGlyZWN0X2MpOw0KPiArICAgIHJl
cyA9IHAybV9pbnNlcnRfbWFwcGluZyhkLCBnZm4sIDEsIG1mbiwgcDJtX21taW9fZGlyZWN0X2Mp
Ow0KPiAgICAgICBpZiAoIHJlcyA8IDAgKQ0KPiAgICAgICB7DQo+IC0gICAgICAgIHByaW50ayhY
RU5MT0dfR19FUlIgIlVuYWJsZSB0byBtYXAgTUZOcyBbJSMiUFJJX21mbiIgLSAlIyJQUklfbWZu
IiBpbiBEb20lZFxuIiwNCj4gLSAgICAgICAgICAgICAgIG1mbl94KG1mbiksIG1mbl94KG1mbikg
KyBuciAtIDEsIGQtPmRvbWFpbl9pZCk7DQo+ICsgICAgICAgIHByaW50ayhYRU5MT0dfR19FUlIg
IlVuYWJsZSB0byBtYXAgTUZOICUjIlBSSV9tZm4iIGluICVwZFxuIiwNCj4gKyAgICAgICAgICAg
ICAgIG1mbl94KG1mbiksIGQpOw0KPiAgICAgICAgICAgcmV0dXJuIHJlczsNCj4gICAgICAgfQ0K
PiAgIA0KPiAtLS0gYS94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMNCj4gKysrIGIveGVuL2NvbW1v
bi9ncmFudF90YWJsZS5jDQo+IEBAIC00MTUwLDcgKzQxNTAsMTAgQEAgaW50IGdudHRhYl9tYXBf
ZnJhbWUoc3RydWN0IGRvbWFpbiAqZCwgdQ0KPiAgICAgICBib29sIHN0YXR1cyA9IGZhbHNlOw0K
PiAgIA0KPiAgICAgICBpZiAoIGdmbl9lcShnZm4sIElOVkFMSURfR0ZOKSApDQo+ICsgICAgew0K
PiArICAgICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsNCj4gICAgICAgICAgIHJldHVybiAtRUlO
VkFMOw0KPiArICAgIH0NCj4gICANCj4gICAgICAgZ3JhbnRfd3JpdGVfbG9jayhndCk7DQo+ICAg
DQo+IC0tLSBhL3hlbi9jb21tb24vbWVtb3J5LmMNCj4gKysrIGIveGVuL2NvbW1vbi9tZW1vcnku
Yw0KPiBAQCAtODMyLDYgKzgzMiw5IEBAIGludCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXAoc3RydWN0
IGRvbWFpbg0KPiAgICAgICAgICAgcmV0dXJuIC1FQUNDRVM7DQo+ICAgICAgIH0NCj4gICANCj4g
KyAgICBpZiAoIGdmbl9lcShfZ2ZuKHhhdHAtPmdwZm4pLCBJTlZBTElEX0dGTikgKQ0KPiArICAg
ICAgICByZXR1cm4gLUVJTlZBTDsNCj4gKw0KPiAgICAgICBpZiAoIHhhdHAtPnNwYWNlID09IFhF
Tk1BUFNQQUNFX2dtZm5fZm9yZWlnbiApDQo+ICAgICAgICAgICBleHRyYS5mb3JlaWduX2RvbWlk
ID0gRE9NSURfSU5WQUxJRDsNCj4gICANCj4gQEAgLTg0Miw2ICs4NDUsMTggQEAgaW50IHhlbm1l
bV9hZGRfdG9fcGh5c21hcChzdHJ1Y3QgZG9tYWluDQo+ICAgICAgIGlmICggeGF0cC0+c2l6ZSA8
IHN0YXJ0ICkNCj4gICAgICAgICAgIHJldHVybiAtRUlMU0VROw0KPiAgIA0KPiArICAgIGlmICgg
eGF0cC0+Z3BmbiArIHhhdHAtPnNpemUgPCB4YXRwLT5ncGZuIHx8DQo+ICsgICAgICAgICB4YXRw
LT5pZHggKyB4YXRwLT5zaXplIDwgeGF0cC0+aWR4ICkNCj4gKyAgICB7DQo+ICsgICAgICAgIC8q
DQo+ICsgICAgICAgICAqIE1ha2Ugc3VyZSBJTlZBTElEX0dGTiBpcyB0aGUgaGlnaGVzdCByZXBy
ZXNlbnRhYmxlIHZhbHVlLCBpLmUuDQo+ICsgICAgICAgICAqIGd1YXJhbnRlZWluZyB0aGF0IGl0
IHdvbid0IGZhbGwgaW4gdGhlIG1pZGRsZSBvZiB0aGUNCj4gKyAgICAgICAgICogW3hhdHAtPmdw
Zm4sIHhhdHAtPmdwZm4gKyB4YXRwLT5zaXplKSByYW5nZSBjaGVja2VkIGFib3ZlLg0KPiArICAg
ICAgICAgKi8NCj4gKyAgICAgICAgQlVJTERfQlVHX09OKElOVkFMSURfR0ZOX1JBVyArIDEpOw0K
PiArICAgICAgICByZXR1cm4gLUVPVkVSRkxPVzsNCj4gKyAgICB9DQo+ICsNCj4gICAgICAgeGF0
cC0+aWR4ICs9IHN0YXJ0Ow0KPiAgICAgICB4YXRwLT5ncGZuICs9IHN0YXJ0Ow0KPiAgICAgICB4
YXRwLT5zaXplIC09IHN0YXJ0Ow0KPiBAQCAtOTYyLDYgKzk3Nyw5IEBAIHN0YXRpYyBpbnQgeGVu
bWVtX2FkZF90b19waHlzbWFwX2JhdGNoKHMNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIGV4dGVudCwgMSkpICkNCj4gICAgICAgICAgICAgICByZXR1
cm4gLUVGQVVMVDsNCj4gICANCj4gKyAgICAgICAgaWYgKCBnZm5fZXEoX2dmbihncGZuKSwgSU5W
QUxJRF9HRk4pICkNCj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiArDQo+ICAgICAg
ICAgICByYyA9IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoZCwgeGF0cGItPnNwYWNlLCBleHRy
YSwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZHgsIF9nZm4o
Z3BmbikpOw0KPiAgIA0KPiAtLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oDQo+ICsrKyBi
L3hlbi9pbmNsdWRlL2FzbS1hcm0vcDJtLmgNCj4gQEAgLTI5Nyw3ICsyOTcsNiBAQCBpbnQgdW5t
YXBfcmVnaW9uc19wMm10KHN0cnVjdCBkb21haW4gKmQsDQo+ICAgDQo+ICAgaW50IG1hcF9kZXZf
bW1pb19yZWdpb24oc3RydWN0IGRvbWFpbiAqZCwNCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICBnZm5fdCBnZm4sDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIG5y
LA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbik7DQo+ICAgDQo+ICAgaW50
IHAybV9pbnNlcnRfbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkLCBnZm5fdCBzdGFydF9nZm4sIHVu
c2lnbmVkIGxvbmcgbnIsDQo+DQo+DQo=


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:14:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:14:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243941.422075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgfN-0005a8-KE; Fri, 10 Dec 2021 14:14:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243941.422075; Fri, 10 Dec 2021 14:14:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgfN-0005a1-Gm; Fri, 10 Dec 2021 14:14:29 +0000
Received: by outflank-mailman (input) for mailman id 243941;
 Fri, 10 Dec 2021 14:14:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvgfM-0005Zr-Cb; Fri, 10 Dec 2021 14:14:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvgfM-0007I0-72; Fri, 10 Dec 2021 14:14:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvgfL-0007cY-Ri; Fri, 10 Dec 2021 14:14:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvgfL-0007gL-RC; Fri, 10 Dec 2021 14:14:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sxKcqkGMkU/9YQyxiDDEczAJwmOWhUdZ5S/NDC7WOmw=; b=k5kGFBjTVSg7SY7wfUx97Sylxb
	btsu8uD2n9Kjpx1m6aMJXGnT0YeER84vb2T8j354PTZSI3Zf+u5d04oBVVfAc1cr7bCgXRxiP0tJs
	WDf+n9KrDPxbGmxBNY9vyUiZzGQgi2WNrmOVygucnEjCTjBwRKgdKfekBOqfajtI8Oog=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167341-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167341: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 14:14:27 +0000

flight 167341 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167341/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   30 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:20:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:20:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243956.422088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgkw-0007gJ-Gj; Fri, 10 Dec 2021 14:20:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243956.422088; Fri, 10 Dec 2021 14:20:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvgkw-0007gC-Dh; Fri, 10 Dec 2021 14:20:14 +0000
Received: by outflank-mailman (input) for mailman id 243956;
 Fri, 10 Dec 2021 14:20:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a5or=Q3=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvgkv-0007g5-HM
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 14:20:13 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 481872d2-59c4-11ec-a831-37629979565c;
 Fri, 10 Dec 2021 15:20:10 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:41522)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvgkr-0007EV-p0 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 10 Dec 2021 14:20:09 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 67F3C1FDB9;
 Fri, 10 Dec 2021 14:20:09 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 481872d2-59c4-11ec-a831-37629979565c
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <44707bed-ceb3-377b-f2b3-9864b7fa4e97@srcf.net>
Date: Fri, 10 Dec 2021 14:20:09 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-2-andrew.cooper3@citrix.com>
 <69d1b4a3-a042-c2c4-2f59-ea897886ae1d@suse.com>
 <e7f8a52a-5761-88dc-97ff-6c2feca2effb@srcf.net>
 <566dbf20-2881-80ac-eafd-57ac4b217f0f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 01/65] x86: Introduce support for CET-IBT
In-Reply-To: <566dbf20-2881-80ac-eafd-57ac4b217f0f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 29/11/2021 09:21, Jan Beulich wrote:
> On 26.11.2021 16:21, Andrew Cooper wrote:
>> On 26/11/2021 14:10, Jan Beulich wrote:
>>> On 26.11.2021 13:33, Andrew Cooper wrote:
>>>> @@ -124,6 +129,18 @@ config XEN_SHSTK
>>>>  	  When CET-SS is active, 32bit PV guests cannot be used.  Backwards
>>>>  	  compatiblity can be provided via the PV Shim mechanism.
>>>>  
>>>> +config XEN_IBT
>>>> +	bool "Supervisor Indirect Branch Tracking"
>>>> +	depends on HAS_CC_CET_IBT
>>>> +	default y
>>>> +	help
>>>> +	  Control-flow Enforcement Technology (CET) is a set of features in
>>>> +	  hardware designed to combat Return-oriented Programming (ROP, also
>>>> +	  call/jump COP/JOP) attacks.  Indirect Branch Tracking is one CET
>>>> +	  feature designed to provide function pointer protection.
>>>> +
>>>> +	  This option arranges for Xen to use CET-IBT for its own protection.
>>> Shouldn't this depend on BROKEN until it's actually functional?
>> It compiles fine right from now, and making it BROKEN would inhibit
>> bisection through the series.
>>
>> Nothing actually matters until patch 65 turns on MSR_S_CET.ENDBR_EN.
> "Nothing" except that until then the promised extra security isn't
> there.

The series is very likely to be committed in one fell swoop, but even
that aside, it really doesn't matter until 4.17-rc1

As it stands, this is ~65 patches of incremental changes to the binary,
and oughtn't to be 65 nops and a massive switch at the end.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:44:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:44:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243976.422100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvh7o-0002qV-9c; Fri, 10 Dec 2021 14:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243976.422100; Fri, 10 Dec 2021 14:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvh7o-0002qO-4o; Fri, 10 Dec 2021 14:43:52 +0000
Received: by outflank-mailman (input) for mailman id 243976;
 Fri, 10 Dec 2021 14:43:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvh7n-0002qE-9O; Fri, 10 Dec 2021 14:43:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvh7m-0007lm-Vb; Fri, 10 Dec 2021 14:43:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvh7m-0000AW-MI; Fri, 10 Dec 2021 14:43:50 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvh7m-0003By-Lq; Fri, 10 Dec 2021 14:43:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5fGruBeXLjwZIearlRsKx6f4TtYAum/jOJJpT6z9gZI=; b=QLGfX/AXS5XXvC0CLRFBlfyVgy
	qJuPh6dGwZipGmPy13Ja68zoJ3Xk3v8ULJqfJioPEUZ8mQ2gJD+lHJJBYmXhljTUrLq+I8ET5GiFM
	DVEvDd52m8lUIy/XgouDDyHCgREb5hdORPEhykAhXX9Q5ekTUHpzGAo4D7QERiW2hJNc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167337-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167337: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=29e31aaf5d81e57679c2abfe8ffd3851a87042b5
X-Osstest-Versions-That:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 14:43:50 +0000

flight 167337 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167337/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  29e31aaf5d81e57679c2abfe8ffd3851a87042b5
baseline version:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607

Last test of basis   167290  2021-12-09 20:01:35 Z    0 days
Testing same since   167337  2021-12-10 10:00:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1384d4e1e4..29e31aaf5d  29e31aaf5d81e57679c2abfe8ffd3851a87042b5 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:45:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:45:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243980.422114 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvh8p-0003OY-Ij; Fri, 10 Dec 2021 14:44:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243980.422114; Fri, 10 Dec 2021 14:44:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvh8p-0003OR-FG; Fri, 10 Dec 2021 14:44:55 +0000
Received: by outflank-mailman (input) for mailman id 243980;
 Fri, 10 Dec 2021 14:44:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a5or=Q3=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvh8o-0003OH-3N
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 14:44:54 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bbe59301-59c7-11ec-9d12-4777fae47e2b;
 Fri, 10 Dec 2021 15:44:53 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:36080)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvh8k-000JOB-7Q (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 10 Dec 2021 14:44:50 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 072851FBFC;
 Fri, 10 Dec 2021 14:44:50 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bbe59301-59c7-11ec-9d12-4777fae47e2b
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <dac66683-a2b1-e548-9d19-3a0e9a74c5cb@srcf.net>
Date: Fri, 10 Dec 2021 14:44:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-9-andrew.cooper3@citrix.com>
 <bddd9fc4-d442-9272-0fcd-4472c83e36e7@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 08/65] xen: Annotate fnptr targets from acpi_table_parse()
In-Reply-To: <bddd9fc4-d442-9272-0fcd-4472c83e36e7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 08:36, Jan Beulich wrote:
> On 26.11.2021 13:33, Andrew Cooper wrote:
>> --- a/xen/arch/x86/hvm/dom0_build.c
>> +++ b/xen/arch/x86/hvm/dom0_build.c
> Elsewhere in this file we have
>
>         rc = map ?   map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn))
>                  : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn));
>
> which has been in this shape only as of commit e3b418ac4919
> ("x86/pvh-dom0: Remove unnecessary function pointer call from
> modify_identity_mmio()"). Aren't we relying on the compiler not
> transforming this back into the earlier
>
>         rc = (map ? map_mmio_regions : unmap_mmio_regions)
>              (d, _gfn(pfn), nr_pages, _mfn(pfn));
>
> ?

That old code was especially dumb even before retpoline.  See also the
damage caused by c/s 245a320ce2.

Yes, we are relying on the compiler not to do transformations behind our
backs, but it won't of its own accord.

>  And aren't we further relying on the compiler not transforming direct
> calls into indirect ones for other reasons (I recall Microsoft's compiler
> being pretty aggressive about this when the same function was called
> more than once in close succession, it at least certain past versions)?

That sounds like a broken compiler.

There are legal cases where a direct call has to turn into an indirect
one, and that's when we need to traverse more than disp32 distance.

But without going to a larger mcmodel, we'd get linker errors before
that becomes a problem, because R_X86_64_PLT32 relocations can't be
retrofitted into an indirect call at link time.

> Is the widened effect of the annotation intended to also guarantee that
> indirect calls will not be produced by the compiler for any reason when
> the annotation is absent on a targeted function's declaration?

That would be one for the clang and gcc developers.

I don't see a plausible problem here.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 14:59:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 14:59:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.243992.422125 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvhMQ-0006BV-PZ; Fri, 10 Dec 2021 14:58:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 243992.422125; Fri, 10 Dec 2021 14:58:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvhMQ-0006BO-Kq; Fri, 10 Dec 2021 14:58:58 +0000
Received: by outflank-mailman (input) for mailman id 243992;
 Fri, 10 Dec 2021 14:58:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvhMP-0006BE-57; Fri, 10 Dec 2021 14:58:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvhMO-00080r-PV; Fri, 10 Dec 2021 14:58:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvhMO-0000eN-Gn; Fri, 10 Dec 2021 14:58:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvhMO-0000x5-GI; Fri, 10 Dec 2021 14:58:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=B1vvzz5RFZD/WvXuVpxrxpjDKWWIPqSy07/I03KoI4M=; b=ScG7r6e8eqzUqaYTlXBDzxXeWy
	tNlQtOAaFIgBzv6Ze6+tNyLvPqL7rJX4YDtWTbKTZINWkNqQQi5+yMHrSFSsWrF3ALsKuE+sPwdA6
	svkqk1s7e+GPr5aR39Vtgo+65Z2L2uuyiWetN0GV8ZN48/28Jphdrvi7G5RpEC4z2q8w=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167342-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167342: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 14:58:56 +0000

flight 167342 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167342/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   31 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 15:07:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 15:07:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244000.422139 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvhUN-0008Gj-Jl; Fri, 10 Dec 2021 15:07:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244000.422139; Fri, 10 Dec 2021 15:07:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvhUN-0008Gc-Gn; Fri, 10 Dec 2021 15:07:11 +0000
Received: by outflank-mailman (input) for mailman id 244000;
 Fri, 10 Dec 2021 15:07:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o/FQ=Q3=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvhUL-0008GW-Lr
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 15:07:09 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d60d4c9f-59ca-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 16:07:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d60d4c9f-59ca-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639148827;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=e+QBid0dfClaHU4kPXjbkLwl7aP0ZrOhv8nDFh4vOKI=;
  b=PmTsQTZ2mxgVO6SP/rWH8V025qGnHcEiAiuxTeoJbMtf2u3M2QLCp+06
   0r4V3zx9h/jESHB6OVG015Q8t/nxEiVqBaYI5zZCco2ecc3av2/9lDQnA
   P6OWTvDggvZcto4fptdauj9O8D0Tt0z8pUPJAhiUHT/C7Beoff1ZVJlnc
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: A271ZuiUczvl67zjsTHEO9ohmfEqhN3Dj26ivXM0SAie4ALlS7malkGThZCKKwjKvyqJf70Kx1
 hlRhhneRQc8ZOXb3H2M03eAIZwGslIkjAGRrU3s8HoLsPjUsDCJwq+/hFRos2rRHU6zr/HM2MO
 R5g8fyyJQ1shmnWlPfAEVjzwC/T/xU1HYOMYOoYPbplC/RgOQgs7k/6qcg7BydIagrHze8pHCY
 C1qF4a6PIThmVT+okyjHhbyiSFr/DqEKUsYYQNqyEQWYUS8sNugkI2kGyg0royYL2zwXKnl9pt
 m8RxXXEPNKwwa8w8ezTX8m3h
X-SBRS: 5.1
X-MesageID: 61806446
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TKnItK1mNw8xf5tsmfbD5XJ2kn2cJEfYwER7XKvMYLTBsI5bpz1Rn
 DQcDGrXafmPZWf2Lt51YIng8BhQ6pLQmNNjSAVqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn970Es5wrZh2+aEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhlupxk
 O1J7cGMChoHPZD1lLo2QilxHHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6Diu4YIhGls2p4m8fD2T
 vUhNSQsY0X6Zz5WC3IGEYgzhcazmSyqG9FfgA3M/vdmi4TJ9yRzzbzsPdz9atGMA8JPkS6wv
 Xna9m70BhUbMt23yjef9H+owOjVkkvTR4Y6BLC+sPlwjzW7x3MRIA0bU0Ohpvu0gVL4XMhQQ
 2QW8Cczqak59GSwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQy3
 0KNt8PkA3poqrL9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iIgJjkr3So4+LO2ooN7IID2u6
 CG6hSdr0t3/kvU3/6m8+FnGhRelqZ7IUhM5623rY4610u9qTNX7PtL1sDA3+d4Fdd/EFQfZ4
 BDojuDDtLhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iQsJW+Bj
 Kz741o5CHpv0J2CN/cfj2WZUZtC8EQYPY65Ps04l/IXCnSLSCeJ/Tt1eWmb1H33nU4nnMkXY
 MnAIJ7zUCpEUfU7lFJaotvxN5dxnkjSIkuJGvjGI+mPi+LCNBZ5t59bWLdxUgzJxPzd+1iEm
 zquH8CL1w9eQIXDjtr/quYuwaQxBSFjX/je8pUPHsbae1YOMDxxWpf5nOJ6E6Q4zvs9qws91
 izkMqOu4AGk3iOvxMTjQi0LVY4Dqr4j9y9mZnJ1Yg7zs5XhCK72hJoim1IMVeBP3MRozOJuT
 ulDfMOFA/9VTS/A9ShbZp74xLGOvjzx2mpi5gKpP2oyeYBOXQvM9oO2dwfj7nBWXCG2qdE/s
 /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aYcMNOfEjM8ZRxL3CjhPEAPMxRew7IwSGX1
 ljKDE5A9/XNuYI87PLAmbuA89WyC+J7E0cDRzvb4L+6ODP05G2mxYMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpRSyZYU6qB7VsJmi98fNO7qAdlKVEvQaWW
 16U/oUIM7u+J864QkUaIxAob7rf2KhMyCXS9/k8PG7z+DRzoOicSUxXMhSB1H5dIb9yPN93y
 OstopdLuQm2ix5sOdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cHdcchIP2krP
 iSQ1fjLiLlrz0bfd2Y+SCrW1u1HiJVS4B1HwTfu/bhSdgYpUhPv4CBszA==
IronPort-HdrOrdr: A9a23:57I5lalNZoiuF3ca9kD5fXD3zFLpDfPIimdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdeEYbmIK8/oSgjPIaurIqePvmMvD5Za8vgZQpENRGtldBm9Ce3mm+yZNNW977PQCZf
 6hDp0tnUvdRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.88,195,1635220800"; 
   d="scan'208";a="61806446"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F19eNeFCVVOzMqHNbc/kiDsN1e9mruytmJ+7cPTvBGSn29crSEFyhSN6tyy/XttVAa888qGVUARfIUbnyzzLfchTx2cUXDZu8C5JdnmrmqlOU+BNdKKdt1T01A706SOVJAWsHkoM7zyDBcMSU1NNFAQkrMtoUVCspRR5nl90bG8/QSM4hMIyb16ByVivlj942NRARGXnq6ALADosC6dXbfFPsHCEGk2bqYsuh/5zFgzU1t+ntr7oKof1bcrs0PH63O+hj+Hdp085JwBTjiFR5gNOOLImunZo2qaxX8XrWLjL+zHCF5XGdyGDaFQlkPtS6xC8KI8lXhEmGX4Z21GkIQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uDCPmv99RgsOQid8kfkssZfAP/dlCNB1gprSfG0nPq0=;
 b=m2hkrXRBvhSFszCyPc1WDlXLg0GN56CZoGo7UNBvNP2y5zZX/cPB0QNMlT293KYdzaCg0VwB5jBsqFGS1135BtdZHeJD//d0VBOOKyvDBOJMTt2SJd+W7nP4JLKSd8KIWMYXYjZlC7DJX6pPpCiyCA9d8OZxs3/Tv1oWdl/t2tsRL5YJxYU2BoGlkBS2TVMQnzLJ1ro196oMFbv4g/KUjIgqbJobTAIjSsQCFB1+O6/fvJyzO/FazTQMnicuxgRRPZ++soFurOv97CwvWpOZQRsizQDYHckdHDSGaCcRrzCsDNwXXG2cuqA98btZVJ284dBWr7bBwg0cveZcXd353g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uDCPmv99RgsOQid8kfkssZfAP/dlCNB1gprSfG0nPq0=;
 b=QiI0wv308AfstNgH2ZBuT7ocKlortY5qjcBwE2kK8KaFjMDWTzUvp+4Xz57GFeRPz0Uu0XhtINWYLwO1TbQQLj2WGrvQWJ3c1qzC9OIai8CLgHCsXJjc9yXhh2hjabrERcy0KbzpB2vxm3zAGGi1XK5jxQk6IpMio+qt+xtALyA=
Date: Fri, 10 Dec 2021 16:06:44 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Paul
 Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Message-ID: <YbNtBPv1M1lIyEOd@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34409bca-9372-45b1-72da-08d9bbeeb04c
X-MS-TrafficTypeDiagnostic: DM5PR03MB2556:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2556798C8A007B3EEF4C19C88F719@DM5PR03MB2556.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: NBArWivEYo/LT5JWUfvsBLR/QJdSuH9B7GZmIvNoPxYDH71hgyPHtm+C4YYVtDke4wJYcdZ/gGjpAh3ZefWUygPVX8BZgvVNYfbGzwXiEoxe/cZeP4pOhOHJNrTlFO0hY5r/X3Ny+wJglGvsHsaDS58LpDLp935bJ2qrg00JL8oRtF/XIrdmL7uiidaMZqIgFu8lFYpv5jC/9wllA2sjq6xQ6daoRD4FHthTqkZRiUbZEOWD5KfVuF7j5iUIOEG9uzORZJygFdBYceVVYgRiRZJJ4lv8wftCjjBGoeEZW8gpT9HhJ0WsPsbqVEFycyKnhEM0bb6k9uj9Q1hPrOtgC41W442sLkqAEY3rWPRo8OK42cNGSb9luRaQRgmpmULvmmmEYDU9BBtSFwfP8xNbJGMRX58OzwkAu24cSVntn2Cjy3pJ92o4KjYOCpcW0PYB6bGRHO9iq38m7ZVlL3v02p4rAUVtt9xq1dGKroAhL9isaHTnwijZt3bEzLGAynV5FzUeVoeuCTHVnvNGkUINQhO8kLF0tDwECdn19bXPR8RlVw90U6iRxarc9XMLtINUJe3RqcLOHBzpIEBDXUL0M0PFOUo96oWbdQ5ApK+p6/MTApwNPo7fl95XT9tdsWG88k7DnAmKPaZIfmA1odGxuA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(9686003)(86362001)(6666004)(83380400001)(66556008)(6496006)(38100700002)(956004)(4326008)(26005)(82960400001)(6916009)(8936002)(85182001)(508600001)(316002)(2906002)(5660300002)(66476007)(186003)(6486002)(8676002)(66946007)(33716001)(54906003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkxQRWpqeU10bFlCS3lZSDNxbnpTMWJxY0dFbFZFb0psbkNUdjRvdDJZY2NM?=
 =?utf-8?B?TWNjbHcyUzVNMVZBaVUreXFZZnNEcW9LUlByekFObHI1V3VZamNMdXlrOWJ3?=
 =?utf-8?B?dVJaQnhjcmp0YnZMT0hiRlN6Zndqemk1bVhObEkzNkN4WG1PS2padzZGQVRG?=
 =?utf-8?B?KzRDdERaRXgxT3NSVUVNS0hPcVkraDE3TXVFTGNFbzFPT1JzWCtvcjlrZCs4?=
 =?utf-8?B?YlphWU1iQXVpTjh5cUFXK0JPUTFwajlhL01GSUdFSTF4d0JJc3FvU0NRUzBt?=
 =?utf-8?B?QjM4bXJOeHNxVUJLZUlYTld3dWFGM0JaazlDcjU3RTlKbDJGOHdDemNEQWh4?=
 =?utf-8?B?K3hpZGFrbnlRSWp4NFdNS3d3amg1Sk1KWTZNVGlWMVNtSEJpTCtWTUR3aHJ1?=
 =?utf-8?B?cVJmdUJuSjVMU0JkaVJmRzNQTEcvT2FjV1k0Z2tSUzBEYmZsM3BwTEdKeUhH?=
 =?utf-8?B?MFhOTlEweC9VZ2lGVng3empTaHNGZlFzRkdnK2hBWEFxYnFJSEZ1NGdHL2Jk?=
 =?utf-8?B?VWxrcGFpbTA3Z1owMHRpU3BSejBUbFBCb1dIVkVXWXNRWlJNRU1EMHJKZDV3?=
 =?utf-8?B?SHQ0U0JJNHZLNVJOWUkvZEg5V3E0WDlLSTVpQzRETm5oeGJKWlJIZGIrL2lz?=
 =?utf-8?B?bFZYQlB0S0JORHdWQ2U4bE55T1A0L21ucE5KanJYdTl5b0gxZmRLc2gzbEtm?=
 =?utf-8?B?S3MwOTY0Q0tYaHZyQzhWem81T2had1VnTy9yS2RqWTZ6MlBGUXZBWmZTUGN2?=
 =?utf-8?B?VnpHdnZBbURLMEYxZDYrL3VWa2VENmxiVnBYMlN5TTVXZlk5OThoQWdYNHZu?=
 =?utf-8?B?dlk4Zkd1VTNJcmxkbU9DMmdvMXE5STUvbzJ6MGJQcWtBb0pDU2trKzU1ZTFH?=
 =?utf-8?B?YkdUeFJiRFJsRjNjb0M1WFlUaGx1ckQzbUhIL29ZYmxSVlNpQWRwcEFQcHlY?=
 =?utf-8?B?N2I3Q2lwV05lZi9Va3ZkbERZL0FiZjg4aGp0d3E0czl2MTVpUGhnV3Zid0M4?=
 =?utf-8?B?WFJtZ24vWTZzMU9qeWxVajg4S1pSVHAxM1Z6TkwzOXA2L0dZcm8vNnFlU05X?=
 =?utf-8?B?L1lTMzBOcjVrSkpSUU5sZDZmVUVFMk1Rc3lhbTVlbEZodC9YQW50QnVPQUV0?=
 =?utf-8?B?RzNQQ3lEYmNaeVR2b2NLU2h0UlpJWFhZVXlWNHZqclhMRXJJVzdLdktGVDJ4?=
 =?utf-8?B?cXVoaHVyblpMNVpTZVRQbGlmQ2IxT05aZ25tU1g1dmVDeU1WOExVOC9QUDJM?=
 =?utf-8?B?dTg1WnpVcHUvcEw1d21mUG1QLzc3TDdGcmx5ZGIvUVJKa0tJank4NzBHUFp4?=
 =?utf-8?B?SXV2QlJjZ1BuTG80MVFiNWIyTTN1blZQQzd2QlFzc2JkQk1qZ2J1YktNZERW?=
 =?utf-8?B?Qmkxc0hRU2VZYnRxR2JsVjQxNm1wY1ZydWRaUlhPMUsrbmtnSTU2dlMzbFh0?=
 =?utf-8?B?WCtVZHJteGJwRk9JOVZRV3hHK3Qvc2FaMzdENVNsNytXL1kwYmQxajUxVWhS?=
 =?utf-8?B?WmtGLzJVcy83YUNSbHNhUUVrR3NrOUN2aU1vUUQ2UUNHbEQyb1lENDcvSWRl?=
 =?utf-8?B?a0ExT2YyeVVZT000bXN1dkVsSzhNK2V3c3A3ZGFSellNanNGVVE0d1QzQXQz?=
 =?utf-8?B?cVl4QTlDaW5xNlAzZXNIMkNrMWxMYzNHamZCVVNLdnlaMExYYlpTQ2N3QUFt?=
 =?utf-8?B?SzE4SFBlcXdDSXJ4N0pRQWptV3lDcWk3eS9idlp6Rm5tUXZhc0NhZmJqbXBS?=
 =?utf-8?B?VE1DNUViZmx2bTRWUEY2MGROWlY5SzVsVjJtNkd6ekNPVGtWYmNKek00WW1w?=
 =?utf-8?B?cExoZm5ucmFFWjF0YTYyejJmdDdCM0kyV2FRSVJmQ1RBN3gxTWtaaGtxcE9V?=
 =?utf-8?B?MUpqeWFvU3Z4NU5mNHk2Qjc5V1dKKzlUUW04QXhpUHVpb2FvOVlJREU1WXd0?=
 =?utf-8?B?cDBIV3VxaTBnZGpSUkZHcW1DNmhnUyttNHBURk9reURCTUhSNG90RDdOdi9n?=
 =?utf-8?B?akxWTVRkdVlSUzU4My9iS2RYc0xwTmtDVFJtcC83ZmVwM1l2RUJFMDRlbGFI?=
 =?utf-8?B?ZVJQNEllMmRkQ1VPdXNLa0pBOUYvMzlxTmRLNnd4Z2FYTnNTcmsyU1JNNGpw?=
 =?utf-8?B?eFdVcGhNQ2NVSUdyaVQ2N0dmRGp1VVdwWGVkU2RDYmI5cDc0WFc1Q1hQejRn?=
 =?utf-8?Q?jON2HrRrnoT/58036c03Haw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34409bca-9372-45b1-72da-08d9bbeeb04c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 15:06:48.6336
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sDgruFc/7N5zOAS8gh42QNYW4k25392cVB6gyGhN/Y8Ao5RLJcC2OVxoasEkHfgVXdDA1l8EulyQ1SKQOX7KyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2556
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:52:14AM +0200, Jan Beulich wrote:
> No separate feature flags exist which would control availability of
> these; the only restriction is HATS (establishing the maximum number of
> page table levels in general), and even that has a lower bound of 4.
> Thus we can unconditionally announce 2M, 1G, and 512G mappings. (Via
> non-default page sizes the implementation in principle permits arbitrary
> size mappings, but these require multiple identical leaf PTEs to be
> written, which isn't all that different from having to write multiple
> consecutive PTEs with increasing frame numbers. IMO that's therefore
> beneficial only on hardware where suitable TLBs exist; I'm unaware of
> such hardware.)

Also replacing/shattering such non-standard page sizes will require
more logic, so unless there's a performance benefit I would just skip
using them.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I'm not fully sure about allowing 512G mappings: The scheduling-for-
> freeing of intermediate page tables can take quite a while when
> replacing a tree of 4k mappings by a single 512G one. Plus (or otoh)
> there's no present code path via which 512G chunks of memory could be
> allocated (and hence mapped) anyway.

I would limit to 1G, which is what we support for CPU page tables
also.

> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -32,12 +32,13 @@ static unsigned int pfn_to_pde_idx(unsig
>  }
>  
>  static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn,
> -                                                   unsigned long dfn)
> +                                                   unsigned long dfn,
> +                                                   unsigned int level)
>  {
>      union amd_iommu_pte *table, *pte, old;
>  
>      table = map_domain_page(_mfn(l1_mfn));
> -    pte = &table[pfn_to_pde_idx(dfn, 1)];
> +    pte = &table[pfn_to_pde_idx(dfn, level)];
>      old = *pte;
>  
>      write_atomic(&pte->raw, 0);
> @@ -288,10 +289,31 @@ static int iommu_pde_from_dfn(struct dom
>      return 0;
>  }
>  
> +static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int next_level)

Nit: should the last parameter be named level rather than next_level?
AFAICT it's the level of the mfn parameter.

Should we also assert that level (or next_level) is always != 0 for
extra safety?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 15:58:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 15:58:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244020.422150 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mviHK-0007pt-J5; Fri, 10 Dec 2021 15:57:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244020.422150; Fri, 10 Dec 2021 15:57:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mviHK-0007pm-GB; Fri, 10 Dec 2021 15:57:46 +0000
Received: by outflank-mailman (input) for mailman id 244020;
 Fri, 10 Dec 2021 15:57:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mviHJ-0007pc-Fg; Fri, 10 Dec 2021 15:57:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mviHJ-0000aA-1l; Fri, 10 Dec 2021 15:57:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mviHI-0004Mt-QV; Fri, 10 Dec 2021 15:57:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mviHI-0005wO-Q1; Fri, 10 Dec 2021 15:57:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yrOhPqYv0z0gtU4PdfbuxHq4hQoinmCUD0InF40ug58=; b=1T82tL0ics1d1NO87oBE59kyjy
	Zn6AaiUH3oOqeeCW9lKRmd72sA6peS861wvbuaoPKAmKUDsx5Bcuuzsb7ZJh+nj+4oiBfd0PMiFRK
	tDRvQxr2buBOow1aPCtwmBdbeeBB4eKHvCZTaNLYSPcv3oXdIN71dP680X4T5INTrqTw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167344-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167344: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 15:57:44 +0000

flight 167344 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167344/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   32 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 16:19:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 16:19:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244030.422164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvic7-0003V5-B0; Fri, 10 Dec 2021 16:19:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244030.422164; Fri, 10 Dec 2021 16:19:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvic7-0003Uy-7L; Fri, 10 Dec 2021 16:19:15 +0000
Received: by outflank-mailman (input) for mailman id 244030;
 Fri, 10 Dec 2021 16:19:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a5or=Q3=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvic5-0003Us-Tq
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 16:19:13 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7771aec-59d4-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 17:19:12 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:45332)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvic1-0006Cl-06 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 10 Dec 2021 16:19:09 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CFFB0200D8;
 Fri, 10 Dec 2021 16:19:08 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7771aec-59d4-11ec-a74f-db008197e53d
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d50d9964-b80f-d46a-49df-90fe5f29e2d3@srcf.net>
Date: Fri, 10 Dec 2021 16:19:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-64-andrew.cooper3@citrix.com>
 <64b55cdc-484d-5657-e0af-3462ebadd09f@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 63/65] x86/setup: Rework MSR_S_CET handling for CET-IBT
In-Reply-To: <64b55cdc-484d-5657-e0af-3462ebadd09f@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 10:49, Jan Beulich wrote:
> On 26.11.2021 13:34, Andrew Cooper wrote:
>> --- a/xen/arch/x86/acpi/wakeup_prot.S
>> +++ b/xen/arch/x86/acpi/wakeup_prot.S
>> @@ -63,7 +63,24 @@ ENTRY(s3_resume)
>>          pushq   %rax
>>          lretq
>>  1:
>> -#ifdef CONFIG_XEN_SHSTK
>> +#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
>> +        call    xen_msr_s_cet_value
>> +        test    %eax, %eax
>> +        je      .L_cet_done
> Nit: I consider it generally misleading to use JE / JNE (and a few
> other Jcc) with other than CMP-like insns. Only those handle actual
> "relations", whereas e.g. TEST only produces particular flag states,
> so would more consistently be followed by JZ / JNZ in cases like
> this one. But since this is very much a matter of taste, I'm not
> going to insist on a change here.

Fixed.

>
>> +        /* Set up MSR_S_CET. */
>> +        mov     $MSR_S_CET, %ecx
>> +        xor     %edx, %edx
>> +        wrmsr
>> +
>> +        /* Enable CR4.CET. */
>> +        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
>> +        mov     %rcx, %cr4
> Is it valid / safe to enable CR4.CET (with CET_SHSTK_EN already
> active) before ...
>
>> +#if defined(CONFIG_XEN_SHSTK)
>> +        test    $CET_SHSTK_EN, %eax
> (Intermediate remark: Using %al would seem to suffice and be a
> shorter encoding.)

Fixed.

>
>> +        je      .L_cet_done
>> +
>>          /*
>>           * Restoring SSP is a little complicated, because we are intercepting
>>           * an in-use shadow stack.  Write a temporary token under the stack,
>> @@ -71,14 +88,6 @@ ENTRY(s3_resume)
>>           * reset MSR_PL0_SSP to its usual value and pop the temporary token.
>>           */
>>          mov     saved_ssp(%rip), %rdi
>> -        cmpq    $1, %rdi
>> -        je      .L_shstk_done
>> -
>> -        /* Set up MSR_S_CET. */
>> -        mov     $MSR_S_CET, %ecx
>> -        xor     %edx, %edx
>> -        mov     $CET_SHSTK_EN | CET_WRSS_EN, %eax
>> -        wrmsr
>>  
>>          /* Construct the temporary supervisor token under SSP. */
>>          sub     $8, %rdi
>> @@ -90,12 +99,9 @@ ENTRY(s3_resume)
>>          mov     %edi, %eax
>>          wrmsr
>>  
>> -        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in load_system_tables(). */
>> -        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
>> -        mov     %rbx, %cr4
> ... the writing of MSR_PL0_SSP in context here? ISTR some ordering
> issues back at the time when you introduced CET-SS, so I thought I'd
> better ask to be sure.

Yes, it is safe, but the reasons why aren't entirely trivial.

To set up CET-SS, we need to do the following things:

1) CR4.CET=1
2) Configure MSR_S_CET.SHSTK_EN
3) Configure MSR_PL0_SSP pointing at a non-busy supervisor token
4) Configure MSR_ISST_SSP to point at the IST shadow stacks, again with
non-busy tokens
5) execute SETSSBSY to load SSP

The MSRs can be configured whenever, subject to suitable hardware
support.  In both of these cases, we've actually pre-configured the
non-busy supervisor tokens which is why we don't set those up directly. 

Furthermore, we defer setting up MSR_ISST_SSP to when we set up the IDT
and TSS, and that's fine because it doesn't make interrupts/exceptions
any less fatal.

The only hard ordering is that SETSSBSY depends on CR4.CET &&
MSR_S_CET.SHSTK_EN in order to not #UD.

However, between CR4.CET && MSR_S_CET.SHSTK_EN and SETSSBSY, we're
operating with an SSP of 0, meaning that any call/ret/etc are fatal. 
That is why I previously grouped the 3 actions as close to together as
possible.

For the CONFIG_XEN_IBT && !CONFIG_XEN_SHSTK case, we need to set up CR4
and MSR_S_CET only.  This was the only way I could find to lay out the
logic in a half-reasonable way.  It does mean that MSR_PL0_SSP is set up
during the critical call/ret region, but that's the smallest price I
could find to pay.  Anything else would have had more conditionals, and
substantially more #ifdef-ary.


I have put in this:

diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S
index 9178b2e6a039..6a4834f9813a 100644
--- a/xen/arch/x86/boot/x86_64.S
+++ b/xen/arch/x86/boot/x86_64.S
@@ -45,6 +45,8 @@ ENTRY(__high_start)
         mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
         mov     %rcx, %cr4
 
+        /* WARNING! call/ret/etc now fatal (iff SHSTK) until SETSSBSY
loads SSP */
+
 #if defined(CONFIG_XEN_SHSTK)
         test    $CET_SHSTK_EN, %al
         jz      .L_ap_cet_done


which mirrors our Spectre-v2 warning in the entry paths.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 16:30:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 16:30:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244038.422174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvimx-0006I3-AP; Fri, 10 Dec 2021 16:30:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244038.422174; Fri, 10 Dec 2021 16:30:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvimx-0006Hw-7Z; Fri, 10 Dec 2021 16:30:27 +0000
Received: by outflank-mailman (input) for mailman id 244038;
 Fri, 10 Dec 2021 16:30:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvimv-0006Hm-So; Fri, 10 Dec 2021 16:30:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvimv-0001hS-KB; Fri, 10 Dec 2021 16:30:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvimv-0005Pz-BH; Fri, 10 Dec 2021 16:30:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvimv-0007Zp-Am; Fri, 10 Dec 2021 16:30:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JUClfp4qEkpZ/vU2B/XT42+IxRe5C+dx2ybvvMkJeqg=; b=lrtk05jJh0dM5PihzW9ji8EyVb
	qcMOweqzOWywFIe3MDiJPnagXHNMA0pIoq3CbtjNaBU1F9teRcWjxfWizCy3m9vStw4ePqD0hd57d
	1iZc3T3TVKY3WE1fhCuE+JC8ip4HsceN9u7IgS9aiZu7b5sNwT+362oceaA2vU+PP+/0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167345-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167345: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 16:30:25 +0000

flight 167345 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167345/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   33 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 16:41:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 16:41:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244045.422188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvixO-0008MA-BU; Fri, 10 Dec 2021 16:41:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244045.422188; Fri, 10 Dec 2021 16:41:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvixO-0008M3-8P; Fri, 10 Dec 2021 16:41:14 +0000
Received: by outflank-mailman (input) for mailman id 244045;
 Fri, 10 Dec 2021 16:41:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvixN-0008Lx-0D
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 16:41:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa3acf31-59d7-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 17:41:09 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-ouxzjud-P_OIcDVtQciSpQ-1; Fri, 10 Dec 2021 17:41:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.22; Fri, 10 Dec
 2021 16:41:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 16:41:06 +0000
Received: from [IPV6:2003:ca:b712:cc7b:8ccd:cae1:f50d:112d]
 (2003:ca:b712:cc7b:8ccd:cae1:f50d:112d) by
 AM0PR01CA0113.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::18) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 16:41:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa3acf31-59d7-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639154469;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=upBtHwekA+CAUjlFIudIbYncLXTb8CCf5PtlFQsDmlE=;
	b=QCx2CKNj9FxqrNgvgj0JDbgrg+GrdvQTeeQmUtfo5K+/79vv31XlcAtDbjt5TEt+hhtDPE
	CxHBsus/x/ZZHH0TVW7+AppP3vEPL84dfxj14idtJeFlzcGgVDgAHC4opQ4//31uZWkPD1
	dagnBm5eJW/OV5KCeyf4bTZB1U9/CfM=
X-MC-Unique: ouxzjud-P_OIcDVtQciSpQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BI1XsfZ/iRKoMqhWcM5ZYPWIjpzyKcCFsi0FU+lG7dnHVZ/ml84y43nNplUj4TZtTw4/tdihRxkdAtvORZ+9KJPKYS6OPY8/9iimJmblhP3VIL4RW7Q+r6iM26Bj8yGLBd2FD/OpbS0beXsB4s+Enl85/N+rAJaDfvq0nAqXeFGDE8MXkaBw1woIkrApzHu3Eq/YOsfjtOsrp876e/s32/vmawK44H3tlpEGej0T0c+b4AQY+CkwvUDcn3tfrloMtVEpMhT1Uo++zS9AWCfVpq8t6CihnCE1Yvv1NpisJhDdShC95PGq7rXI3lLV+txU+qG9pUC0/UFpSp+SaClZ7g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=upBtHwekA+CAUjlFIudIbYncLXTb8CCf5PtlFQsDmlE=;
 b=AoZbuopvR38qpEulsLjwrkpjnCadfP+rFnIdeXSGNeO43TjIMfcnu/bqQqw2/YSLsrY9V6DUtL0iMRET5Fim/s2BgAzpmNT5qJA42TqrwuNtjMMwcK8eS2UlvjWo+UrLWVhmeCwmTEOIvqX9Ve6hp8OCLcY0pB+BhV/qibVxXYzhlxR0wbQ7/2kAgBVYrgU9mW/Zf52TPo/CKslP7TA18M/CDUwFHc5Orq4VPInmv9Eqvl6h/t9UoWl4LlzqdalHU3U3/RhAdVN7ysBFDUeHXp5FJ/XfAZJ3Jpjw6msCOIC10WJkyUX2KTKqfI8HzReC9f0BapQM9vJU7CExLIMiBg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c042f769-13bf-dbaf-a5a3-fbfd92b24156@suse.com>
Date: Fri, 10 Dec 2021 17:41:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] libxc: avoid clobbering errno in
 xc_domain_pod_target()
Content-Language: en-US
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <ac9ffddc-b102-9876-7a46-345078c3423c@suse.com>
 <52F30125-172C-4AC8-B3A6-104D7914CDB0@arm.com>
 <d23a7603-47c2-43b5-5365-02f437fd46b1@suse.com>
 <943FCC51-08E5-49BD-8B24-AB516AE6C76A@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <943FCC51-08E5-49BD-8B24-AB516AE6C76A@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM0PR01CA0113.eurprd01.prod.exchangelabs.com
 (2603:10a6:208:168::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0743ea33-4d19-41fa-4521-08d9bbfbdc8a
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393451948952993DE0CEEE92B3719@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ankDhtS7vqqX71VRr0xXLpX9CRnfdjMGnWGSVLyV+rXJn5I49AqXRARwKqrVj8v2qKHV+CrzGNKFhPeVQFQA6I320iIvp4pSxd8RDbskn1dZOokcvkrgRbV9el0U28zkvw+cdhSU0U4v60kIFQYdUQ51X8tSW6OHppVYN8xn4oQr0Hsconn5rJ3MVqc+Sskk1718pdR2VcFYeEh/QYs3PXxfdR+QCrTGhHVjCdv5VxTfzvmRCglUrGC9ZgKEk5t3LpOeoG8oQlp55ntxZGJOo4qRv/+JCW+bbvFP7rJo2m9G3cJ2BqO6L+AwTv3ZraSMd2w6IvbuSDSeHot/sMGDOgeE4rlcIT3cmMBnLPNEqz4hiyk2Z06uOCeeZadWHAOo48cg+qlWfPYmQegfWia+qVIZsp7ZI1DuVlrCFXqLwiRqtModYyc/wPxRz7NZGmtoL5H9Lggd9GySjBioFYpwidzTC8q2fUkmBwk7uI16nzc7q3dOw3zf90H64DU8WUpX0+YPBJyaHAVMjarRrkTti5EdrDhcT5MbajWZJsNC4E5Mucigq2BNLxhYkBnCcX4SpDlFytatY2xK8FVn36A++OGMhYIBnz2BPh8A9w7hhGgYOapK6QaKvD0z/7/gEza5c+y4iIW9inAJqW0eiFTmw/pwTi3p1uPoVRroe+71S9nHsqJ3l9399iCMIDhYYfxd1WYHij34/nmst0egCHCBnw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(83380400001)(186003)(53546011)(54906003)(86362001)(36756003)(5660300002)(8936002)(508600001)(2616005)(31686004)(31696002)(107886003)(2906002)(6666004)(8676002)(66946007)(316002)(6916009)(38100700002)(66476007)(66556008)(6486002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Wml3N0d5YzhkZndwMDV0SVoxM3l1enNHYk94SlExOUFkdnZiZFdaSURUbW54?=
 =?utf-8?B?eVdOOU1uSE5DQWJvVUhqSFhsNDAxN3U0NVFuZHVHL0U1M3N3OXNiRWZqWHRx?=
 =?utf-8?B?bHoxcFpvZXZzSFZnbmVyRG9jVEpubGQ5SXhEQ2ltVkJHVlV6K25zSHZOUkFU?=
 =?utf-8?B?SHZXWkZIbjFsREV4UGUweC9MaTBFSXFxd2RSTW50Y21IVVlBOWgxNEx6eUhI?=
 =?utf-8?B?NkphRkhkMkFSeStoblBYbEliQkZBY3B6dGR0ZVJmcFNXZWdhYVB6enRKaGJI?=
 =?utf-8?B?UWhuOHU0Qjl2Y1dxRG9xOUptclYzUk1lNW1kMVdFOXdTbUNrajVQMXlaWktl?=
 =?utf-8?B?Vm5BazRFa0NBZ05IUkF4dzVvNnluS29OZklOS1FJa2RwZDlreEFMaXJPRVZx?=
 =?utf-8?B?RFVtclNxdUJnUFQxRndMTDZPdFVWWDlSaDA0cHF1d1FlMm5XcVhDRXpVbnha?=
 =?utf-8?B?eitOM0JQYUgzS2poTUV1YkRraG9ocWtNcGo4Q0F0bndwaWlsZmE4TjhncHRx?=
 =?utf-8?B?YTRYd1d2L2dYWEZvMGtnVjYySjJmSnYyOGkrQ1F6N09tcUloUWRyb3M1OUxZ?=
 =?utf-8?B?OEpHQ3N4cVNHNzBZZGZMYW54cmFrRjdUeXJOcER0R1kydGxSeTlNYmlKYTdP?=
 =?utf-8?B?TDAxdjNtaHRmVlR4djg2QzJ4MHJMUmFocWpyWUhWbDMrSmpyOFhpL2Vmb21i?=
 =?utf-8?B?Rjk1ZDM2Z2E0ZkF4Ri8xZVltUU9IYjNiMkl4bCsyOW1PTXZBY2tsSmYxVG00?=
 =?utf-8?B?K2VWSXFOMlZ1WFlOL1NFYk8xTUIxSUVDU0dlT0RLMFo3cXVQaDl3T0FOV3VN?=
 =?utf-8?B?VFh2QWFhMFJJUUtaNmZqTUFRREg3MVppL1JIRm9JQWlhc2Z2QlpQcDgreGZ5?=
 =?utf-8?B?VmY5eWl1dFRHOFlnYVMxU3MwdGFZaVpvVlJMdWIwYmI0TFB5Q1gvZlYxTUhu?=
 =?utf-8?B?dTZHbXRVSTh3cHVsUWdnbzVydE96UklMakxMamxNNnZjVEdsd3ZKUmRMOXE3?=
 =?utf-8?B?U0JUUmg4c3g1blcraTZ3L0RXVkh5MHJLaFAzR2I2T3hvemhwNDBDMTMzVHd6?=
 =?utf-8?B?VUtQUVFCNkF5SkdOcEFvYjgvNUFtdnJiMk1pWmlsRDFpczFyV0VQczduUEhy?=
 =?utf-8?B?SWFPRWpjWVNIUTgwZ1I1eC9LVW95MU84Slh6VmlhQjJtUERsbzdqb1JpMlFF?=
 =?utf-8?B?TWc4eDFxbWNQMnNDVUw5eTJEOG5VUXAzUkcxelRrN2xId1JBNTBXVkdtN2d6?=
 =?utf-8?B?OEFyZDBFUjNhN3VJb2J2OVVsU05LYWE4K2kxZGh3K0RHbmhyY1R0eXF6OGor?=
 =?utf-8?B?N1dBZHFSYXhNemNMUmZ5SlNpTlRsWjdPK3ZreFlIMlVzUWZMSXk2RDVYR29n?=
 =?utf-8?B?Yk5zV0poUkdkbHhicnVwOEl1dkE3MklibDdtVDgrSFo3b1g0NmJaL1luanIr?=
 =?utf-8?B?d1B3UjN1cGtLQnJabHBDbldHb2NGTnFVN0ZjcVpxeThwNFR1aFdpYjBWNzNi?=
 =?utf-8?B?SGlXekRKSnh3c0k0V0xFc0RqL1VENHY4SW9XaHJ2cS9TN0d3L1BZYi9qNm5D?=
 =?utf-8?B?OWhCK0ZYT0xsNVhwWEpPOTIyNENwUkhJeHZTTzViekJPQnVVbmZ0QzNNakwz?=
 =?utf-8?B?c1dPM1BvTUk3MGhIZmRXY2szeUZXckdPMEs2L0EwU3prWEx3VTFtbThEbWdJ?=
 =?utf-8?B?UlhybFBkMWo4YjRicXFMQk5qRHNldHMzRTA3Y3FlYjRva1gzV2JvK0NHL3Va?=
 =?utf-8?B?Q2Zob1dmZ3BPNWVCQjloejVXVmllYzNCWUowVCtYOCtJZXpWVmpmejBSa3hV?=
 =?utf-8?B?bXRmY1IvRkxTeERFcUZ0SUJ0Z09aeHNxWHowMlBVK1RNcjR3NitQK0V4OWdW?=
 =?utf-8?B?THczL1YrYnlzYkFvaUl6N0NLWFNoRk5vemVvUVJDZWUrRXBDRVlQOTh4cDhG?=
 =?utf-8?B?cXVYY0pTSWx6TzIva094M2hJakRCTXFEd1huNjRsak05bVpNVU5jby9mMlRW?=
 =?utf-8?B?MWFIMHBlWWJBdURSRVNha1ZVcmxsZnRBdDZRbGxxRE1MVEFHaDJ6NXo3Y2Qz?=
 =?utf-8?B?bWN1c3dPZDgyQVNPaUVZYzZWdTVCcDdxeUNGZlNBdTVYbHVVLzl0T2pFV1NK?=
 =?utf-8?B?a2ZaQTNSTmNWTC82Z2RIakR5T1VrTlNSYURlMTZoc09YSVduUytacnM2VHRz?=
 =?utf-8?B?SnROcEZ1cDAyZGxzU3A2QkRkRXhBbWJqNEpaSS8xb1VXS0NCQ1FUUGlESTRE?=
 =?utf-8?Q?0D6sMeJIRfDTGXgLYhD48IL550wC1tjO47qT5jOaOw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0743ea33-4d19-41fa-4521-08d9bbfbdc8a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 16:41:06.3828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fatjwexOq3Wg/5K79ebURMNggs5sCqJQ47iSwBTicDakM5YcjiekYqyR0c7uYYPGKAlt/gY+CXUhf0HsHSelcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

On 10.12.2021 15:00, Bertrand Marquis wrote:
>> On 10 Dec 2021, at 13:54, Jan Beulich <jbeulich@suse.com> wrote:
>> On 10.12.2021 14:50, Bertrand Marquis wrote:
>>>> On 10 Dec 2021, at 13:11, Jan Beulich <jbeulich@suse.com> wrote:
>>>>
>>>> do_memory_op() supplies return value and has "errno" set the usual way.
>>>> Don't overwrite "errno" with 1 (aka EPERM on at least Linux). There's
>>>> also no reason to overwrite "err".
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>>
>> Thanks.
>>
>>> But if err can really only be 0 or -1, I do wonder if the else forcing err to 0 could
>>> be removed but I must say I have no idea if do_memory_op could return a value >0.
>>
>> Indeed - see ...
>>
>>>> ---
>>>> While the hypervisor side of the hypercall gives the impression of being
>>>> able to return positive values as of 637a283f17eb ("PoD: Allow
>>>> pod_set_cache_target hypercall to be preempted"), due to the use of
>>>> "rc >= 0" there, afaict that's not actually the case. IOW "err" can
>>>> really only be 0 or -1 here, and hence its setting to zero may also be
>>>> worthwhile to drop.
>>>> ---
>>
>> ... this.
> 
> So the else should be dropped then, why not doing it and just mentioning it there ?

Well, I'd like confirmation by a maintainer. There are a few aspects to how
things are done in the tool stack which I'm not always aware of. IOW there
might be reasons to keep things as they are after this variant of the patch.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 16:42:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 16:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244048.422200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mviy5-0000Uv-PF; Fri, 10 Dec 2021 16:41:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244048.422200; Fri, 10 Dec 2021 16:41:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mviy5-0000Uo-M8; Fri, 10 Dec 2021 16:41:57 +0000
Received: by outflank-mailman (input) for mailman id 244048;
 Fri, 10 Dec 2021 16:41:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VqPJ=Q3=gmail.com=robherring2@srs-se1.protection.inumbo.net>)
 id 1mviy4-0008Lx-Bb
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 16:41:56 +0000
Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com
 [209.85.167.178]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15600709-59d8-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 17:41:55 +0100 (CET)
Received: by mail-oi1-f178.google.com with SMTP id bf8so13975674oib.6
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 08:41:55 -0800 (PST)
Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net.
 [66.90.148.213])
 by smtp.gmail.com with ESMTPSA id m12sm600169ots.59.2021.12.10.08.41.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 10 Dec 2021 08:41:53 -0800 (PST)
Received: (nullmailer pid 1495271 invoked by uid 1000);
 Fri, 10 Dec 2021 16:41:52 -0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15600709-59d8-11ec-a74f-db008197e53d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=mzRHekSe+1ItE0g/B1/sdKOqQcFEHI9ComSVVLd1nlI=;
        b=1gzLHr29PTb3bSMTgJIv844ttwEeUPxBfwV9eoJBSp+s/Gt5H75gepD5Oz5cZV1h7M
         f18uvlEgh1SdWT4LKZyhDzw/MQSkYp/kxPKHjvaTvURE+k//wGk5yX2cOQhhqcCXKE9K
         pJlSSOPa1NY94jtsUTHrpofBwXd6aTg5H14rZ9NOvZ8/S7HIQFuRJdFhfuyNIk2033bq
         KHYEj79mkwsRDnNgWIn/9pt5yxJaxRAR+5P7OKKEuoRoLsiShuN/1KHRws0HV0/Ub4IM
         ENF6ZDv9PnwKLLko63etQ9EdsXcN7LWF6nzimRqytDwbnZMVwC7pXmVSeCP8j783g4y6
         /m5A==
X-Gm-Message-State: AOAM533UlerP7w7Mwt5we2j5lRljHkvaJUshRvEmSircnlrgFdyKlPKU
	fWMu9uiw178ujTHnIi8NQA==
X-Google-Smtp-Source: ABdhPJwRv+kMCf78RcI/EgKRH+ISPL3AxEehRdB9Ai5HD06TXa1RnLKZV2R7Cgi/ZzR5zEXSnPJELw==
X-Received: by 2002:a05:6808:649:: with SMTP id z9mr12919308oih.125.1639154514388;
        Fri, 10 Dec 2021 08:41:54 -0800 (PST)
Date: Fri, 10 Dec 2021 10:41:52 -0600
From: Rob Herring <robh@kernel.org>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: devicetree@vger.kernel.org, Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Rob Herring <robh+dt@kernel.org>, xen-devel@lists.xenproject.org, Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
Message-ID: <YbODUP7jnSWffumD@robh.at.kernel.org>
References: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com>
 <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1639136201-27530-1-git-send-email-olekstysh@gmail.com>

On Fri, 10 Dec 2021 13:36:41 +0200, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Xen on Arm has gained new support recently to calculate and report
> extended regions (unused address space) safe to use for external
> mappings. These regions are reported via "reg" property under
> "hypervisor" node in the guest device-tree. As region 0 is reserved
> for grant table space (always present), the indexes for extended
> regions are 1...N.
> 
> No device-tree bindings update is needed (except clarifying the text)
> as guest infers the presence of extended regions from the number
> of regions in "reg" property.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> Changes V2 -> V3:
>    - new patch
> 
> Changes V3 -> V4:
>    - add Stefano's R-b and Rob's A-b
>    - remove sentence about ACPI for "reg" and "interrupts"
>      properties
> 
> Changes V4 -> V4.1
>    - bring the mentioning of ACPI back which, as was pointed out by Julien,
>      fits in the context:
>      https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org/T/#t
>      so technically restore V3 state
>    - remove Stefano's R-b and Rob's A-b as I am not 100% sure they are
>      happy with that
> ---
>  Documentation/devicetree/bindings/arm/xen.txt | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 16:47:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 16:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244060.422211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvj3P-0001qV-Bi; Fri, 10 Dec 2021 16:47:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244060.422211; Fri, 10 Dec 2021 16:47:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvj3P-0001qO-8K; Fri, 10 Dec 2021 16:47:27 +0000
Received: by outflank-mailman (input) for mailman id 244060;
 Fri, 10 Dec 2021 16:47:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=aCrA=Q3=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mvj3O-0001qI-LK
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 16:47:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id da5717a9-59d8-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 17:47:25 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-1-zai0f2OPNsqvYDDia0WxnA-1; Fri, 10 Dec 2021 17:47:24 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Fri, 10 Dec
 2021 16:47:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.024; Fri, 10 Dec 2021
 16:47:21 +0000
Received: from [IPV6:2003:ca:b712:cc7b:8ccd:cae1:f50d:112d]
 (2003:ca:b712:cc7b:8ccd:cae1:f50d:112d) by
 AM5PR0402CA0021.eurprd04.prod.outlook.com (2603:10a6:203:90::31) with
 Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport;
 Fri, 10 Dec 2021 16:47:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: da5717a9-59d8-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639154845;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OoT8J65wdTJrGjWj7O5wKytC5VIw/mqui75K01BWofs=;
	b=aCCqzYkbWY0z3BsuFXCcFStkTZWHL3Zl3HVNN1frVMZuV/tBq8WlvGEGEVvi2I9MFajtuE
	9c8rGo9Kbxb+CwD8e7nT/Ljx/5SkOgKkdXU4gYjobTOEJoGBcfDsmYVVlFTIMNeRAuYgKx
	l+N5ABy5Kkdjldk71RONL9by44QxW2U=
X-MC-Unique: zai0f2OPNsqvYDDia0WxnA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a01D+cUHheCs2ZNGAAMaum/jJfCm0hr/ukjpi36ZCpUpuw7DLGdmW6FWSZW7NpbuFsRTR6ge0zqhEjgvULXD+lhfb0Rl4v4lfVqWLfqBpD06Eg8F11MtJnsUOwpZEnDHlGtgoQHNOONNJi0aQ7wig2Y9fa65I93eriFvuYA31YT6bSw3m2XRWV12THNAVLjmdnu9NxIT4Fn0BxkX6OGotE1WtJm3Zs4bHBlfTF0RT+jLzn6eL4RSB3muzH/jxMJjcg3kfFgAORKYz0FIS3+XLhcGqY8pPrYA55sQdNOojzSUjVY3lZTHDRVcZocje/7cjV5KrR5wKwPLWmy7ShqOhQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=O54XzNz6VIIfsiZ4FsDIUDFLH3VGBKmwPcLZtpPVZuY=;
 b=F0wnHUBtqLzJlfF1DAHhgs+o2Q0fyEa3W9EwxVsNBRS1dpi0ooW8CKg96D2eeYmTPvSuv7bNoyIqxZtI5c1jnzE8xuGS28GE8m6BdkeJmOo5Fvj1mV01NtgZVX4e9nlfXF7/gq03BLKHyYhBkY/isKIbQKkMKXgrItAaURYqFDEF/MbrqT9+tu7dt4VjXm4tgQ/lpkpg9GWz74iXDy+p1apnKpXnJXFW+mt7U3yM4zLRuCH3iZnMkIXm1KmqZxrNDLgoxvLGQFtrYkzFkkpDqdsFVWIvuKTOlDgfxh0h+ye1CfZZkPipu9j2luRlBarTaarQ9vugcjS6YOFr/WgVEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <712b731a-948d-d341-c33b-b8a446ee4b95@suse.com>
Date: Fri, 10 Dec 2021 17:47:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH 63/65] x86/setup: Rework MSR_S_CET handling for CET-IBT
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-64-andrew.cooper3@citrix.com>
 <64b55cdc-484d-5657-e0af-3462ebadd09f@suse.com>
 <d50d9964-b80f-d46a-49df-90fe5f29e2d3@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d50d9964-b80f-d46a-49df-90fe5f29e2d3@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0402CA0021.eurprd04.prod.outlook.com
 (2603:10a6:203:90::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 21e83cfb-496b-460b-fa3b-08d9bbfcbc11
X-MS-TrafficTypeDiagnostic: VI1PR04MB6176:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB61767513870AAFF8F0B6151EB3719@VI1PR04MB6176.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uSLgMWMlYLWwoaWhZOUtuGKr3hByqtfXOvJGDXXeFyGTkbel4RAnz3Y1bp48Q5MijZRZZgR/pqcUHiuRsWpfUgSDYTaAN3ZO+Y/X+PORfJnEOff/4O0YPoY78KXATZadY5/eq0g7IUj6+4osv08zOwKy2fPb97Fi3NtJo2NEimxyl+GCH4S84GPpl7v20cKLk4AI31Wsi9XYq5P42CGPmheM25PVSAHCGdr1FLU0kd7PG1NdF4nQp2zzoDGRbp/VVALjh3o8ZVeAfPnUFlfERn/cx3W3d+UumPc11OiyxVOpp9FTuDtZk2rQJJlSyQXHNXV2fzxxVhlegNATPsr7fUwOkGjG/iVJc9fqMloTi6LbeEA6L6Wrfs5vJJ2nO1oHSyK0mE4l9MF/YWoeOGIcLc3YJ9nNcI5eLiSnJCsQ+ijvb9H8uUvQgeMVzOcmkE3P4rh+Tr4G+Mr7iq+wJY2CtUCIUuRvNYxk+hBMawyjpp5t07n8Ic0SK/hT7qoo8gKHNG6gAipERjDaWTn/Xb1TYvQkvzLbMVufRYm2vxHbPrNelHV8jXvaRxfsCbPZUUqgcCPwjKrimWKNHuVEsm0P81CkAAZgYdVu5bfF3NFnfYo32DoYcYKBpkLMviuU95FE5VCn0eSwIdX8qywzwKI27dka7rX9hO8kkuazVpXzSKN+/4ECj5o9qPP9hauSsgn7l77AA1kqjil8Bs+VSxNvs5BR4lxPVmHtZtaqLlB182hna40O/HMc4NFoUYuAF0dw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(2616005)(316002)(38100700002)(66556008)(66946007)(5660300002)(508600001)(66476007)(86362001)(31696002)(8676002)(6486002)(6666004)(31686004)(186003)(53546011)(8936002)(36756003)(54906003)(83380400001)(2906002)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?hI0abVH3+76wdFqxDLxWQRvDAR9wG89zguxnoeTdql7P3zaeVIWj43CEeMgb?=
 =?us-ascii?Q?O4wq8moVfd/ZFjekNd/KJt9HiCp9V0RWvLIf4VATruRbg03cDJUjzTsAWPHB?=
 =?us-ascii?Q?HOBt5A1Cfu61RfD5J2iY7qoVR+drckNR6eQgPfs0Mo/NPI7oHTM1RZDDO1gG?=
 =?us-ascii?Q?x11IAzTCxDUYxPoRV6MMc52rIGIBWV7B0lrFdfyx7j1f+EHxozBk8NN59UE6?=
 =?us-ascii?Q?acY+bg8gkq5rAk+NAIn9ZClTBjFttQM2nippj+n7Kka9BaKOU9bSghmBExFK?=
 =?us-ascii?Q?v71SrnfvM5VYEUzTZJr7z3qtSJ4mbMaGvdMiEaF0sUCxXYCcD/mc5XBp81RK?=
 =?us-ascii?Q?emPlCpwrQwi0YAd1axAjNoAzBkXqVT9lbj+OjjGwBIg1z8LHE2dleiugZX4Q?=
 =?us-ascii?Q?crActwkiz+liP1KYTeXe0ekrsXJVycYBTSO8YfGMYwOl/5A8I6RjRmZ3Bhu4?=
 =?us-ascii?Q?+at9HNw427c4lm0+AnJ535v2KjgVS7VbaS291xHKVddOOFTpR3lPhXrZ/kF8?=
 =?us-ascii?Q?fJPHVqWss+JIl2xnGz8pnh8USWuYyNBrJ0rBEjomziduF3jkN036mcSlVB8L?=
 =?us-ascii?Q?wIdqt3rY89sT3Q1YImDqu+Skdh4szvoVsplgBxNiqLiY0sKBmK1AufBvB7UU?=
 =?us-ascii?Q?GeugwH0YAXNwKpVJzpWnYHv/zClS683FFh6w/4xxmSnKDjEZBH3lKAYeqp3r?=
 =?us-ascii?Q?jVkojSacbd+ESTv9EU6ptY9fAU6K3ufAkVbMhr/WpfoOzVmtGLWej0MEC/sR?=
 =?us-ascii?Q?l1QUBxWVDbUFGHhHCgkuCsubaZ2CF7HfoqeXGvtLHGENGnZNAjF+FjYZa0pj?=
 =?us-ascii?Q?QAE0rk/dKhbbKSH3CkmcwNz664YQBT84eEDsciYDeujchOwLBk2sojoar5w5?=
 =?us-ascii?Q?/DugvOhl0Wufy9qfqhwPX1wh94gl7pEdPkvsQdUKQT5od2rpeSc+GxMCbzqK?=
 =?us-ascii?Q?1QtyFOz0l7Tf5xgjz2g7Nlc1uSz+IwCYBK5dhN5CbN7P+TkbxkPnZrymAcXv?=
 =?us-ascii?Q?Npmobn7s/jOadOgX9tgmrSJ7zyQjj0zthxN30j17pPlIwMEKiLBhBG6PjxXb?=
 =?us-ascii?Q?RvUoKEW+n56mZzc6GTHKPOeRpm/zH9bsoXae2SE0zwRHbgThqUfg1fns8mvi?=
 =?us-ascii?Q?K9uamp4YUcU8BSfWTx2HgzGFOuhFBVz/0Iy+9E4ZPgnbdYhUGR9wt6TiQTXt?=
 =?us-ascii?Q?lGr8db7seekPsbw74TKumtlrYEKhbBlWCaedrMGMkYmrpgyC8YuJT6TcKICe?=
 =?us-ascii?Q?nH5ts1PzCkcks2SaNd3Y+i2jOgGDjxPhn1hd7pekMQXEH/jAzjoMEk/NBy9g?=
 =?us-ascii?Q?0Y2jjpBOWfjintUrwfpemCnGDWdOFow5IGYxqEC9HG4mu8ZTkzZ1wi3LbHAI?=
 =?us-ascii?Q?mOALZ3yLagjFk0UJjx05++pu2tnANhZ6ug8YUo9/Qt8QIQguKsh30o5uCnqj?=
 =?us-ascii?Q?txdafv/nQjm1bgfHmMEYeU1Su0CrkQe4H+NIAWAVa4QanWOCbCpRamDY58cy?=
 =?us-ascii?Q?3OT0dUi99iwu6u9fTzGYJa1N+SGYRBcXn0ggSfXUcP1YbyRpgqXqZC7RTUsD?=
 =?us-ascii?Q?S6hf7Pxb5CtLMyqRMBGt+ml2w2Dht2FVYc9GNwnZbYn7oC4cm1+BBxrX+ZXJ?=
 =?us-ascii?Q?jqm4u8W0lnv+futKzQ91jrbZ8/R/lv8N3HmJqLJ9Xx7ElKWyJyNIHxl9y0vc?=
 =?us-ascii?Q?AEU0UBJ4IGQd5XtRFGkopRymWkg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21e83cfb-496b-460b-fa3b-08d9bbfcbc11
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2021 16:47:21.2502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lyHq7hQX6QRIVaUNX8hPzQko+2Jlwc76TI8kG48pHhHT/zN+Vnh02mm+O3zGu7O6BvjxjCQYRgn5pIFuYisQuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176

On 10.12.2021 17:19, Andrew Cooper wrote:
> On 06/12/2021 10:49, Jan Beulich wrote:
>> On 26.11.2021 13:34, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/acpi/wakeup_prot.S
>>> +++ b/xen/arch/x86/acpi/wakeup_prot.S
>>> @@ -63,7 +63,24 @@ ENTRY(s3_resume)
>>>          pushq   %rax
>>>          lretq
>>>  1:
>>> -#ifdef CONFIG_XEN_SHSTK
>>> +#if defined(CONFIG_XEN_SHSTK) || defined(CONFIG_XEN_IBT)
>>> +        call    xen_msr_s_cet_value
>>> +        test    %eax, %eax
>>> +        je      .L_cet_done
>> Nit: I consider it generally misleading to use JE / JNE (and a few
>> other Jcc) with other than CMP-like insns. Only those handle actual
>> "relations", whereas e.g. TEST only produces particular flag states,
>> so would more consistently be followed by JZ / JNZ in cases like
>> this one. But since this is very much a matter of taste, I'm not
>> going to insist on a change here.
>=20
> Fixed.
>=20
>>
>>> +        /* Set up MSR_S_CET. */
>>> +        mov     $MSR_S_CET, %ecx
>>> +        xor     %edx, %edx
>>> +        wrmsr
>>> +
>>> +        /* Enable CR4.CET. */
>>> +        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
>>> +        mov     %rcx, %cr4
>> Is it valid / safe to enable CR4.CET (with CET_SHSTK_EN already
>> active) before ...
>>
>>> +#if defined(CONFIG_XEN_SHSTK)
>>> +        test    $CET_SHSTK_EN, %eax
>> (Intermediate remark: Using %al would seem to suffice and be a
>> shorter encoding.)
>=20
> Fixed.
>=20
>>
>>> +        je      .L_cet_done
>>> +
>>>          /*
>>>           * Restoring SSP is a little complicated, because we are inter=
cepting
>>>           * an in-use shadow stack.  Write a temporary token under the =
stack,
>>> @@ -71,14 +88,6 @@ ENTRY(s3_resume)
>>>           * reset MSR_PL0_SSP to its usual value and pop the temporary =
token.
>>>           */
>>>          mov     saved_ssp(%rip), %rdi
>>> -        cmpq    $1, %rdi
>>> -        je      .L_shstk_done
>>> -
>>> -        /* Set up MSR_S_CET. */
>>> -        mov     $MSR_S_CET, %ecx
>>> -        xor     %edx, %edx
>>> -        mov     $CET_SHSTK_EN | CET_WRSS_EN, %eax
>>> -        wrmsr
>>> =20
>>>          /* Construct the temporary supervisor token under SSP. */
>>>          sub     $8, %rdi
>>> @@ -90,12 +99,9 @@ ENTRY(s3_resume)
>>>          mov     %edi, %eax
>>>          wrmsr
>>> =20
>>> -        /* Enable CET.  MSR_INTERRUPT_SSP_TABLE is set up later in loa=
d_system_tables(). */
>>> -        mov     $XEN_MINIMAL_CR4 | X86_CR4_CET, %ebx
>>> -        mov     %rbx, %cr4
>> ... the writing of MSR_PL0_SSP in context here? ISTR some ordering
>> issues back at the time when you introduced CET-SS, so I thought I'd
>> better ask to be sure.
>=20
> Yes, it is safe, but the reasons why aren't entirely trivial.
>=20
> To set up CET-SS, we need to do the following things:
>=20
> 1) CR4.CET=3D1
> 2) Configure MSR_S_CET.SHSTK_EN
> 3) Configure MSR_PL0_SSP pointing at a non-busy supervisor token
> 4) Configure MSR_ISST_SSP to point at the IST shadow stacks, again with
> non-busy tokens
> 5) execute SETSSBSY to load SSP
>=20
> The MSRs can be configured whenever, subject to suitable hardware
> support.=C2=A0 In both of these cases, we've actually pre-configured the
> non-busy supervisor tokens which is why we don't set those up directly.=
=C2=A0
>=20
> Furthermore, we defer setting up MSR_ISST_SSP to when we set up the IDT
> and TSS, and that's fine because it doesn't make interrupts/exceptions
> any less fatal.
>=20
> The only hard ordering is that SETSSBSY depends on CR4.CET &&
> MSR_S_CET.SHSTK_EN in order to not #UD.
>=20
> However, between CR4.CET && MSR_S_CET.SHSTK_EN and SETSSBSY, we're
> operating with an SSP of 0, meaning that any call/ret/etc are fatal.=C2=
=A0
> That is why I previously grouped the 3 actions as close to together as
> possible.
>=20
> For the CONFIG_XEN_IBT && !CONFIG_XEN_SHSTK case, we need to set up CR4
> and MSR_S_CET only.=C2=A0 This was the only way I could find to lay out t=
he
> logic in a half-reasonable way.=C2=A0 It does mean that MSR_PL0_SSP is se=
t up
> during the critical call/ret region, but that's the smallest price I
> could find to pay.=C2=A0 Anything else would have had more conditionals, =
and
> substantially more #ifdef-ary.
>=20
>=20
> I have put in this:
>=20
> diff --git a/xen/arch/x86/boot/x86_64.S b/xen/arch/x86/boot/x86_64.S
> index 9178b2e6a039..6a4834f9813a 100644
> --- a/xen/arch/x86/boot/x86_64.S
> +++ b/xen/arch/x86/boot/x86_64.S
> @@ -45,6 +45,8 @@ ENTRY(__high_start)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mov=C2=A0=C2=A0=C2=A0=C2=
=A0 $XEN_MINIMAL_CR4 | X86_CR4_CET, %ecx
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mov=C2=A0=C2=A0=C2=A0=C2=
=A0 %rcx, %cr4
> =C2=A0
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* WARNING! call/ret/etc now =
fatal (iff SHSTK) until SETSSBSY
> loads SSP */
> +
> =C2=A0#if defined(CONFIG_XEN_SHSTK)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 test=C2=A0=C2=A0=C2=A0 $=
CET_SHSTK_EN, %al
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jz=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 .L_ap_cet_done
>=20
>=20
> which mirrors our Spectre-v2 warning in the entry paths.

Thanks, I think this may end up helpful down the road.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:00:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:00:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244066.422222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjFp-0004hj-GB; Fri, 10 Dec 2021 17:00:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244066.422222; Fri, 10 Dec 2021 17:00:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjFp-0004hc-DD; Fri, 10 Dec 2021 17:00:17 +0000
Received: by outflank-mailman (input) for mailman id 244066;
 Fri, 10 Dec 2021 17:00:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjFn-0004hS-U4; Fri, 10 Dec 2021 17:00:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjFn-0002Ez-LA; Fri, 10 Dec 2021 17:00:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjFn-00066e-DZ; Fri, 10 Dec 2021 17:00:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjFn-0007GH-D5; Fri, 10 Dec 2021 17:00:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LlIH5CARvRUr1fhgEL/C0CclVJ9lsHT43ZmYfPDXVJI=; b=EnuRjisoUbpoPS4ZEZZylCMNMD
	5zqJaDj+042gdUfS8hkI6KKKqjC4rNjl6bYu963bNDho1onOVLQuR2EWVE5fv0zS3OkgmrHn2AsC0
	6PjGrcRcjFjBd09syL/d8Kqb591zA3e1iN9ekUOCwKccEYZFCK79346rlZXYgdJBEINw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167346-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167346: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 17:00:15 +0000

flight 167346 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167346/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   34 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:16:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:16:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244109.422236 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjVG-0006tE-Qe; Fri, 10 Dec 2021 17:16:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244109.422236; Fri, 10 Dec 2021 17:16:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjVG-0006t7-NQ; Fri, 10 Dec 2021 17:16:14 +0000
Received: by outflank-mailman (input) for mailman id 244109;
 Fri, 10 Dec 2021 17:16:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=a5or=Q3=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mvjVF-0006t1-PG
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 17:16:13 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ded68ef4-59dc-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 18:16:12 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:36146)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mvjVC-00059H-87 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 10 Dec 2021 17:16:10 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 54EC1200D8;
 Fri, 10 Dec 2021 17:16:10 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ded68ef4-59dc-11ec-ad7a-b7ef48004f0a
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <23feef0d-2913-69cf-1a1f-59b1e933ad37@srcf.net>
Date: Fri, 10 Dec 2021 17:16:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163830.30151-1-andrew.cooper3@citrix.com>
 <f3a94e22-5136-8cb8-6df5-58899a8bc4a7@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH v1.1 64/65] x86/efi: Disable CET-IBT around Runtime
 Services calls
In-Reply-To: <f3a94e22-5136-8cb8-6df5-58899a8bc4a7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 11:06, Jan Beulich wrote:
> On 26.11.2021 17:38, Andrew Cooper wrote:
>> --- a/xen/arch/x86/efi/stub.c
>> +++ b/xen/arch/x86/efi/stub.c
>> @@ -11,6 +11,8 @@
>>  #include <efi/efidevp.h>
>>  #include <efi/efiapi.h>
>>  
>> +bool __initdata efi_no_cet_ibt;
> I'm having trouble seeing what this is needed for - when this file gets
> built, neither boot.c nor runtime.c will get compiled, and hence there
> should not be any reference to the symbol that needs satisfying.
>
>> @@ -735,6 +736,14 @@ static void __init efi_init(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTabl
>>  
>>      StdOut = SystemTable->ConOut;
>>      StdErr = SystemTable->StdErr ?: StdOut;
>> +
>> +#ifdef CONFIG_X86
> CONFIG_XEN_IBT?
>
>> +    /*
>> +     * Heuristic.  Look under an arbitrary function pointer to see if UEFI was
>> +     * compiled with CET-IBT support.  Experimentally some are not.
>> +     */
>> +    efi_no_cet_ibt = !is_endbr64(efi_rs->GetTime);
> I'm afraid I consider this insufficient. Even if the core EFI was built
> with IBT support, some driver may not have been.

That's not an issue.  Everything is built together in practice.

>  Hence I think there
> needs to be a command line control to force turning off IBT. The only
> question is whether we want to also honor its positive form - that
> would, afaict, be a recipe for a guaranteed crash if used wrongly (and
> it would be meaningless when used on IBT-aware firmware).

It turns out that IBT support is lacking from tianocore, so nothing is
going to support IBT for a good while yet.

https://bugzilla.tianocore.org/show_bug.cgi?id=3726 is the proposed
change to the spec to support this.

In the meantime, I'm just going to blanket disable IBT for RS calls.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:29:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244141.422247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjhY-0001El-4P; Fri, 10 Dec 2021 17:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244141.422247; Fri, 10 Dec 2021 17:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjhY-0001Ee-1P; Fri, 10 Dec 2021 17:28:56 +0000
Received: by outflank-mailman (input) for mailman id 244141;
 Fri, 10 Dec 2021 17:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjhX-0001EU-61; Fri, 10 Dec 2021 17:28:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjhW-0002hI-VG; Fri, 10 Dec 2021 17:28:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjhW-0006pA-Hb; Fri, 10 Dec 2021 17:28:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvjhW-0006vI-H7; Fri, 10 Dec 2021 17:28:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0SiT31L/rosK7w8ZHxJMEw/xa3g6GZRsGxruNLfW9k8=; b=0IVprfyysM6K/niNL/Ua4OFWbu
	ApVYTQRlNvDdV++LHFXrnkdWhAvQGIShA6fXbj76Hz7it7dAcxaA0uzVWtfGP0vpk/a34w3Dla6Yf
	ok/IRb4khQbYFNQ59EjH/KUU8/SJh9eYJMkcbndgIimWsOMbBMDK6NEt7/AKElqTCFwo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167336-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167336: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
X-Osstest-Versions-That:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 17:28:54 +0000

flight 167336 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167336/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10  fail blocked in 167312
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167312
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167312
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167312
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167312
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167312
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167312
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167312
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167312
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167312
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167312
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167312
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167312
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607
baseline version:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607

Last test of basis   167336  2021-12-10 09:54:00 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:35:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:35:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244147.422261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjne-0002d1-Mj; Fri, 10 Dec 2021 17:35:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244147.422261; Fri, 10 Dec 2021 17:35:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvjne-0002cu-Jh; Fri, 10 Dec 2021 17:35:14 +0000
Received: by outflank-mailman (input) for mailman id 244147;
 Fri, 10 Dec 2021 17:35:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvjnd-0002co-JR
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 17:35:13 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvjnb-0002nk-KK; Fri, 10 Dec 2021 17:35:11 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvjnb-000747-DT; Fri, 10 Dec 2021 17:35:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=zgovlK2ID0qdTuKm0DMRoPu3r+zdo5udp66lQV6Z7Tw=; b=PemTjtpoEnWC8cLsW8bKv74TVj
	v6b0GnnJhNNqhw6/g9mskf9+8n6ckonJdkJ/VA2TmuVjPYUvprU5vXtEOVt9TYF+zXxgrA0vTJlmd
	UmCZH0g0JUD7udZGQ07a4KKkl073cMEGBu7c74G0+DUZke8bq2d02dAELc+paEfpslf0=;
Message-ID: <226e66d0-72a6-e106-4daf-a873a0e76add@xen.org>
Date: Fri, 10 Dec 2021 17:35:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] arm/efi: Handle Xen bootargs from both xen.cfg and DT
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <wei.chen@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <20211206153658.49727-1-luca.fancellu@arm.com>
 <984732f0-8433-a294-acaf-c4130a2ab341@xen.org>
 <E84E06F3-8468-426C-AFE1-DB0E0A49B353@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <E84E06F3-8468-426C-AFE1-DB0E0A49B353@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Luca,

On 10/12/2021 10:26, Luca Fancellu wrote:
> 
> 
>> On 8 Dec 2021, at 18:10, Julien Grall <julien@xen.org> wrote:
>>
>> Hi Luca,
>>
>> On 06/12/2021 15:36, Luca Fancellu wrote:
>>> Currently the Xen UEFI stub can accept Xen boot arguments from
>>> the Xen configuration file using the "options=" keyword, but also
>>> directly from the device tree specifying xen,xen-bootargs
>>> property.
>>> When the configuration file is used, device tree boot arguments
>>> are ignored and overwritten even if the keyword "options=" is
>>> not used.
>>> This patch handle this case, if xen,xen-bootargs is found in the
>>> device tree, it is used for xen boot arguments regardless they
>>> are specified in the Xen configuration file or not.
>>> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
>>> ---
>>>   docs/misc/efi.pandoc        | 4 ++++
>>>   xen/arch/arm/efi/efi-boot.h | 7 +++++++
>>>   2 files changed, 11 insertions(+)
>>> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
>>> index abafb3452758..b7d99de87f15 100644
>>> --- a/docs/misc/efi.pandoc
>>> +++ b/docs/misc/efi.pandoc
>>> @@ -249,6 +249,10 @@ UEFI stub for module loading.
>>>   When adding DomU modules to device tree, also add the property
>>>   xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
>>>   Otherwise, Xen will skip the config file and rely on device tree alone.
>>> +When using the Xen configuration file in conjunction with the device tree, you
>>> +can specify the Xen boot arguments in the configuration file with the "options="
>>> +keyword or in the device tree with the "xen,xen-bootargs" property, but be
>>> +aware that a device tree value has a precedence over the configuration file.
>>
>> I am not sure I agree with the precedence chosen here. With UEFI environment it is a lot easier to update the configuration file over the Device-Tree. So this could be used to quickly test a command line before updating the Device-Tree.
>>
>> Also, somewhat unrelated to this patch. Looking at the code, the command line is a concatenation of "options=" from the configuration file and the extra arguments provided on the command line used to execute the UEFI binary.
>>
>> When using the command line from the Device-Tree, I think it would still make sense to append the later because it could allow a user to provide a single Device-Tree with extra options on the UEFI command line.
>>
>> But I think this is a separate subject. So if we are going to go with the precedence you suggested, then we should at least clarify in the documentation that it will replace both.
>
> Yes I see your point, currently the boot arguments are done in this way <image name> <CFG bootargs> <CMD line bootargs> as you pointed out,
> 
> would it be ok in your opinion to check if <CFG bootargs> is specified and if it’s not, use the <DT bootargs> instead (if any)?

I am happy with this approach.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:52:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:52:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244153.422275 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvk4T-00063a-8H; Fri, 10 Dec 2021 17:52:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244153.422275; Fri, 10 Dec 2021 17:52:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvk4T-00063T-4F; Fri, 10 Dec 2021 17:52:37 +0000
Received: by outflank-mailman (input) for mailman id 244153;
 Fri, 10 Dec 2021 17:52:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvk4S-00063N-2a
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 17:52:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvk4R-00037R-NU; Fri, 10 Dec 2021 17:52:35 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvk4R-0008IX-HR; Fri, 10 Dec 2021 17:52:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mFLkAe1BqLOkHYPmQsRDn3d96hBZR/mvshxGtHkWqys=; b=YNMIKuC7/0ijt6uQxWWQR4dFFE
	IKVvuZRKE0EW6jnzOODtAEYn50FSL0TzzxfiLAgXzPgi/QJ9lBtQLhy/YvhF8F+WMMDtPtFHxN8m7
	BwcaCBxyEEu9AawosHtbN8lJdj2uljhFzfA0YAbzetxn7dVYeyKd8bLqVg+2B81NMJVc=;
Message-ID: <78ee3d68-7901-2cfe-b0f1-76239339dc49@xen.org>
Date: Fri, 10 Dec 2021 17:52:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-3-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211209072918.460902-3-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 09/12/2021 07:29, Oleksandr Andrushchenko wrote:
> +unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
> +{
> +    if ( !has_vpci(d) )
> +        return 0;
> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        int ret = pci_host_iterate_bridges_and_count(d, vpci_get_num_handlers_cb);
> +
> +        return ret < 0 ? 0 : ret;

Sorry I only spotted this now. AFAICT, ret is not meant to return ret < 
0 in this case. But if it were then I think it would be wrong to 
continue as nothing happened because the code will likely fall 
over/crash when registering the I/O handlers.

I would document this oddity with

if ( ret < 0 )
{
    ASSERT_UNREACHABLE();
    return 0;
}

I can do the change on commit if the others are happy with it.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 17:55:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 17:55:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244160.422285 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvk6v-0006ju-R0; Fri, 10 Dec 2021 17:55:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244160.422285; Fri, 10 Dec 2021 17:55:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvk6v-0006jn-Nn; Fri, 10 Dec 2021 17:55:09 +0000
Received: by outflank-mailman (input) for mailman id 244160;
 Fri, 10 Dec 2021 17:55:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mvk6u-0006jf-0X
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 17:55:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvk6s-0003A2-Um; Fri, 10 Dec 2021 17:55:06 +0000
Received: from [54.239.6.184] (helo=[192.168.9.67])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mvk6s-00009m-On; Fri, 10 Dec 2021 17:55:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Iajxf5ta7fKeN0+HACku7QAAo95zMRvzTiF6WPwht0I=; b=ldb10Jrdziyw8HqoamDiiR+5c5
	yOLVcp3VAYa7B1KHYXwta7ho86lvfogTZd81k2y2HMNycWVCCZEcQO2TGGYWGTLmlLjvt5pRHldmc
	Mw5Ec4HZxXkT/alZi2yNLWzsQDkMVRXdpyqFzQuWc5UCAEiQkpNCIEfVqLAsKMnYH7PI=;
Message-ID: <19c43763-966d-e336-9282-ff12b1b3b2c6@xen.org>
Date: Fri, 10 Dec 2021 17:55:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v5 02/14] vpci: fix function attributes for
 vpci_process_pending
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com,
 jbeulich@suse.com, andrew.cooper3@citrix.com, george.dunlap@citrix.com,
 paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-3-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125110251.2877218-3-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oleksandr,

On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> vpci_process_pending is defined with different attributes, e.g.
> with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> Fix this by defining both of the definitions with __must_check.
> 
> Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:00:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:00:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244165.422297 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkCC-0000Nm-EB; Fri, 10 Dec 2021 18:00:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244165.422297; Fri, 10 Dec 2021 18:00:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkCC-0000NE-B2; Fri, 10 Dec 2021 18:00:36 +0000
Received: by outflank-mailman (input) for mailman id 244165;
 Fri, 10 Dec 2021 18:00:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkCA-0000N4-D8; Fri, 10 Dec 2021 18:00:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkCA-0003LW-84; Fri, 10 Dec 2021 18:00:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkC9-0007YH-Tj; Fri, 10 Dec 2021 18:00:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkC9-0006RT-TH; Fri, 10 Dec 2021 18:00:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hDS3LvIK/XGiMfjwdOp1HoS8g3+tYhZ2czp8P3mjK0M=; b=LSdznA5LKEEsBX95XAeBYu++S+
	QVSB9LmJEcpa/QL4g6QemK+PJIqQquKmMj2axGlfXaGoCH9vf6hpn/NUd8M/t0UQUJ2VL+XPL/yXp
	EaM0SoUHLuwBT04PQqi+GQvZzBqTK/O3ehEv+lNyhJAxUahUQAbNYwRLfnmzzDv5NfoY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167347-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167347: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 18:00:33 +0000

flight 167347 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167347/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   35 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:03:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:03:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244171.422311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkF9-0000zo-Tb; Fri, 10 Dec 2021 18:03:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244171.422311; Fri, 10 Dec 2021 18:03:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkF9-0000zh-Pc; Fri, 10 Dec 2021 18:03:39 +0000
Received: by outflank-mailman (input) for mailman id 244171;
 Fri, 10 Dec 2021 18:03:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkF8-0000zX-QR; Fri, 10 Dec 2021 18:03:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkF8-0003PH-L4; Fri, 10 Dec 2021 18:03:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkF8-0007d0-Df; Fri, 10 Dec 2021 18:03:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvkF8-0006db-DB; Fri, 10 Dec 2021 18:03:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xBfYl+xnPX57lBX4bfx+42pSgEwzWrctHDRsPnQJSs4=; b=2xg7IwPk9e7KtDzXvQf0B5mJPl
	FL+D2PgVk8CMeAr4cx2nMpXu4BtyfFcfvtE5huhO1gpj66h8HWyc8LK+8MhZDrKIvE0imcMeUOnUt
	z3DkJ+o9KVpZiR0B5Up32IU0sJb/8s/4SL11sGIhZFMAQVUwPXPFjLB5C/ozC/QhK5s4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167343-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167343: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
X-Osstest-Versions-That:
    xen=29e31aaf5d81e57679c2abfe8ffd3851a87042b5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 18:03:38 +0000

flight 167343 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167343/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2
baseline version:
 xen                  29e31aaf5d81e57679c2abfe8ffd3851a87042b5

Last test of basis   167337  2021-12-10 10:00:26 Z    0 days
Testing same since   167343  2021-12-10 15:01:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   29e31aaf5d..df3e1a5efe  df3e1a5efe700a9f59eced801cac73f9fd02a0e2 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:09:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:09:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244177.422325 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkKt-0002GW-Iq; Fri, 10 Dec 2021 18:09:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244177.422325; Fri, 10 Dec 2021 18:09:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkKt-0002GP-FR; Fri, 10 Dec 2021 18:09:35 +0000
Received: by outflank-mailman (input) for mailman id 244177;
 Fri, 10 Dec 2021 18:09:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkKs-0002GJ-5C
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:09:34 +0000
Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com
 [209.85.161.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52f89031-59e4-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:09:32 +0100 (CET)
Received: by mail-oo1-f53.google.com with SMTP id
 e17-20020a4a8291000000b002c5ee0645e7so2597993oog.2
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:09:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52f89031-59e4-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=bnSiIIEAxVbWb5ME0b4EjQTIeMlzMMlMKVBEVEKFmvo=;
        b=SiI7B9dMD8dgT1IefJRykV8jBRr8sgi+BJICE3aAS6zQjZhLcU6+HpzGfQTtJzE1/t
         WflBB9W/asLO5z2cQGn1JavwOH5RhJJYCNusQQmilQE0u/q8UugTMmJ3o2QFDtYj86aX
         CZFt+YdknMQRFqgTIFITdx8f1Z2K+HW2PH8hE6OVM1aqTVM00LP/fhR7b5U96Rdm0XC7
         hgr/hmiWYlsnDof3x173SlD4ZjPWlLXRwOdG/s3M2wsCrYut+C5uNPZR2rk/Q2/Rb8Vm
         oQ2/E11XWBzZ/9uU05DdoBKsoXzFWNlQQ35sOjCgSwfHsn1EIROh1L/vdE4IsiM5Sxej
         Zl+A==
X-Gm-Message-State: AOAM532fV6OSSsolNdW4bil8Adn37bq07mki4PMrRus6NV3T40VRw6O5
	qF+SQXyaq99VBE9/FczV7ULiEnEIc2nvDray6YY=
X-Google-Smtp-Source: ABdhPJylQaHxxBjvxLDdejK26dmax8gF5GO2emXKWarqrtdmHFUWV4Injg4wQQswc1tWUgMSYyPwJPfech+QMe2lThI=
X-Received: by 2002:a05:6820:388:: with SMTP id r8mr9365162ooj.0.1639159771506;
 Fri, 10 Dec 2021 10:09:31 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-8-digetx@gmail.com>
In-Reply-To: <20211126180101.27818-8-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:09:20 +0100
Message-ID: <CAJZ5v0i=zgubEtF5-Wnaqa5FMnfVUdSnEmD11-LAuYCH8ZCwrA@mail.gmail.com>
Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function prototypes
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> There is no need to annotate function prototypes with 'extern', it makes
> code less readable. Remove unnecessary annotations from <reboot.h>.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

I'm not sure that this is really useful.

Personally, I tend to respect the existing conventions like this.

Surely, this change is not required for the rest of the series to work.

> ---
>  include/linux/reboot.h | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> index 7c288013a3ca..b7fa25726323 100644
> --- a/include/linux/reboot.h
> +++ b/include/linux/reboot.h
> @@ -40,36 +40,36 @@ extern int reboot_cpu;
>  extern int reboot_force;
>
>
> -extern int register_reboot_notifier(struct notifier_block *);
> -extern int unregister_reboot_notifier(struct notifier_block *);
> +int register_reboot_notifier(struct notifier_block *);
> +int unregister_reboot_notifier(struct notifier_block *);
>
> -extern int devm_register_reboot_notifier(struct device *, struct notifier_block *);
> +int devm_register_reboot_notifier(struct device *, struct notifier_block *);
>
> -extern int register_restart_handler(struct notifier_block *);
> -extern int unregister_restart_handler(struct notifier_block *);
> -extern void do_kernel_restart(char *cmd);
> +int register_restart_handler(struct notifier_block *);
> +int unregister_restart_handler(struct notifier_block *);
> +void do_kernel_restart(char *cmd);
>
>  /*
>   * Architecture-specific implementations of sys_reboot commands.
>   */
>
> -extern void migrate_to_reboot_cpu(void);
> -extern void machine_restart(char *cmd);
> -extern void machine_halt(void);
> -extern void machine_power_off(void);
> +void migrate_to_reboot_cpu(void);
> +void machine_restart(char *cmd);
> +void machine_halt(void);
> +void machine_power_off(void);
>
> -extern void machine_shutdown(void);
> +void machine_shutdown(void);
>  struct pt_regs;
> -extern void machine_crash_shutdown(struct pt_regs *);
> +void machine_crash_shutdown(struct pt_regs *);
>
>  /*
>   * Architecture independent implementations of sys_reboot commands.
>   */
>
> -extern void kernel_restart_prepare(char *cmd);
> -extern void kernel_restart(char *cmd);
> -extern void kernel_halt(void);
> -extern void kernel_power_off(void);
> +void kernel_restart_prepare(char *cmd);
> +void kernel_restart(char *cmd);
> +void kernel_halt(void);
> +void kernel_power_off(void);
>
>  extern int C_A_D; /* for sysctl */
>  void ctrl_alt_del(void);
> @@ -77,15 +77,15 @@ void ctrl_alt_del(void);
>  #define POWEROFF_CMD_PATH_LEN  256
>  extern char poweroff_cmd[POWEROFF_CMD_PATH_LEN];
>
> -extern void orderly_poweroff(bool force);
> -extern void orderly_reboot(void);
> +void orderly_poweroff(bool force);
> +void orderly_reboot(void);
>  void hw_protection_shutdown(const char *reason, int ms_until_forced);
>
>  /*
>   * Emergency restart, callable from an interrupt handler.
>   */
>
> -extern void emergency_restart(void);
> +void emergency_restart(void);
>  #include <asm/emergency-restart.h>
>
>  #endif /* _LINUX_REBOOT_H */
> --
> 2.33.1
>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:14:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:14:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244182.422335 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkPR-0003dD-4Y; Fri, 10 Dec 2021 18:14:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244182.422335; Fri, 10 Dec 2021 18:14:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkPR-0003d6-1h; Fri, 10 Dec 2021 18:14:17 +0000
Received: by outflank-mailman (input) for mailman id 244182;
 Fri, 10 Dec 2021 18:14:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkPP-0003d0-MM
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:14:15 +0000
Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com
 [209.85.210.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb0390f3-59e4-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:14:14 +0100 (CET)
Received: by mail-ot1-f51.google.com with SMTP id
 w6-20020a9d77c6000000b0055e804fa524so10446883otl.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:14:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb0390f3-59e4-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=RaOuCzlDrEGoU3kCCyjiPh5ZIczFbf2cAVp5IUpr62Q=;
        b=6WMBGMJM/oQ+eRw3ugC826N9vS70l/PeToviKHkTt0fBDWZHVVd9E6vgI3NisS7zYN
         1vQ7HdbilE6qc3A8c4+YA9lRbdE4slRwUUPz46vOpZEoB0JxlDMpwxiYTZ/60Q2vY7Rf
         m37sBNFA5hcdfUyhLTGOHhiQcYM9Eh6wxqxDc/uXjZnTQM3d57ymk8EPNDlch7pVf3dW
         1DO8a1n90O43/pmhhIVpHpRJ0UmsXu7qeX/Uh01Cgwkco0azFJBjFwegtGFjUaA5kiLb
         By0GJWWLVHTWHokRnw4EDgKVOxIaLjKsy++Qnq2au54sW01rULvPSIUiJXPCMvRDGxIz
         DiLg==
X-Gm-Message-State: AOAM533yG+qUk94aLXf5vBdUSdoNQJHFj/eyCd5k6mz/dFOZof1sktnP
	k8nbUjwnO3+elj1TkXRyvFgxqOJtWuKMgoybn64=
X-Google-Smtp-Source: ABdhPJx5VEl25dlL8StyZ7/vR+sIp4uhzbZQ+4jxftcUhgC3Wucypp0Twl9yCOfT1qw70j5+PgOSc5gj4QOVrzsPiE4=
X-Received: by 2002:a9d:4c10:: with SMTP id l16mr12483219otf.198.1639160053505;
 Fri, 10 Dec 2021 10:14:13 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-3-digetx@gmail.com>
In-Reply-To: <20211126180101.27818-3-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:14:02 +0100
Message-ID: <CAJZ5v0gy5M5yYT7k5CY0JtW4MvsgKq4psBEw81UKz=pjGo0xPw@mail.gmail.com>
Subject: Re: [PATCH v4 02/25] notifier: Add blocking_notifier_call_chain_is_empty()
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 26, 2021 at 7:01 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> Add blocking_notifier_call_chain_is_empty() that returns true if call
> chain is empty.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  include/linux/notifier.h |  2 ++
>  kernel/notifier.c        | 14 ++++++++++++++
>  2 files changed, 16 insertions(+)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index 4b80a815b666..924c9d7c8e73 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -173,6 +173,8 @@ int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh,
>  int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
>                 unsigned long val_up, unsigned long val_down, void *v);
>
> +bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh);
> +
>  #define NOTIFY_DONE            0x0000          /* Don't care */
>  #define NOTIFY_OK              0x0001          /* Suits me */
>  #define NOTIFY_STOP_MASK       0x8000          /* Don't call further */
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index b8251dc0bc0f..b20cb7b9b1f0 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -322,6 +322,20 @@ int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
>  }
>  EXPORT_SYMBOL_GPL(blocking_notifier_call_chain);
>
> +/**
> + *     blocking_notifier_call_chain_is_empty - Check whether notifier chain is empty
> + *     @nh: Pointer to head of the blocking notifier chain
> + *
> + *     Checks whether notifier chain is empty.
> + *
> + *     Returns true is notifier chain is empty, false otherwise.
> + */
> +bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
> +{
> +       return !rcu_access_pointer(nh->head);
> +}
> +EXPORT_SYMBOL_GPL(blocking_notifier_call_chain_is_empty);

The check is not reliable (racy) without locking, so I wouldn't export
anything like this to modules.

At least IMO it should be added along with a user.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:16:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:16:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244189.422347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkR8-0004HV-K2; Fri, 10 Dec 2021 18:16:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244189.422347; Fri, 10 Dec 2021 18:16:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkR8-0004HO-Gr; Fri, 10 Dec 2021 18:16:02 +0000
Received: by outflank-mailman (input) for mailman id 244189;
 Fri, 10 Dec 2021 18:16:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvkR7-0004HD-1k
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:16:01 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a27dbed-59e5-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:16:00 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id b40so19502194lfv.10
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:16:00 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id q15sm379095lfp.32.2021.12.10.10.15.57
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 10:15:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a27dbed-59e5-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=bcvtGiLbR5hJWeiVCch89vaOnPBEjfgkGhnDVgGToIE=;
        b=G0qTQ3KGFrwps8qADsCL0qK6agYLp7ivalOB/mF7ukTMqKqODRUNPClBA+tjj958iZ
         zDP5ALcBXKrVg0xx9H2ws3hyb3r6CIVdqsbS/GVCsvrWbnNO0HGlLBE864udH5VLQpzA
         E4ZCGQvWrQ3sm3YxkToWB7AGuZSE/qHZ86M8KsEpcZTMCU4IFoRlulk9U2f7fjt0DgcE
         dievaYp3/3GIUU6nMVScS6FhLqdlOsaTCJ8+eRNM/gp2aIGsGid35kag1Oq9XwyLJEZe
         Lsdj6NoONSIfbrp21Zrfz1ZI08pSDTMKtV8ZG3ySXOqe/j3lBC+KMsiD//GTJ5tyuvfx
         eTTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=bcvtGiLbR5hJWeiVCch89vaOnPBEjfgkGhnDVgGToIE=;
        b=OdTNUWthJ3wcKcxLqaFz/gDZrCQyCZKtsxj5pZf9iIJZ2sBdABmAW/M5vFyQkroeMm
         jtyuJz8xmy6XEcQgVX7Igkt5Ga+zKg/vMqrMRpRhGOLCUuzqXC7jUZhmhGnxwfFbhpcj
         t3X32gBJUmLYRVt0Ps+ajJl6wqkSJ1F02PHlOrKDXl3qGOmTW9AKqVwdO0Pm0yxXbYua
         fKS54cArBppCyruNwx3Q0lrz9z7SUDcmOc1tn0GrbW0nMECkZSFwFgPLM6csSL0S/2Xi
         Tzn2rC8VB/qzo2jxSlMfgcPFBJ7+KlDhHf10LDK5utQ/uBJdW5jAugShsuMqahxdoFOw
         LFHA==
X-Gm-Message-State: AOAM532YaQI/LQgWtHb+qbGP3ft3KnD5rH1T2fpIx/1eQvKn8NVtLBBr
	/xItC+8FZahaQThePsv+tqE=
X-Google-Smtp-Source: ABdhPJwR/4XeF0n78EyaU8daj5gqPU1YI5WhyixXiCZ/1XxnYO6fYoSxPShwkvEp5UZp5BYd303wDQ==
X-Received: by 2002:a05:6512:40b:: with SMTP id u11mr13847699lfk.377.1639160159550;
        Fri, 10 Dec 2021 10:15:59 -0800 (PST)
Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function
 prototypes
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-8-digetx@gmail.com>
 <CAJZ5v0i=zgubEtF5-Wnaqa5FMnfVUdSnEmD11-LAuYCH8ZCwrA@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <acf8289e-6ab8-6eda-ec06-e9044ddd9a92@gmail.com>
Date: Fri, 10 Dec 2021 21:15:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0i=zgubEtF5-Wnaqa5FMnfVUdSnEmD11-LAuYCH8ZCwrA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:09, Rafael J. Wysocki пишет:
> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> There is no need to annotate function prototypes with 'extern', it makes
>> code less readable. Remove unnecessary annotations from <reboot.h>.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> 
> I'm not sure that this is really useful.
> 
> Personally, I tend to respect the existing conventions like this.
> 
> Surely, this change is not required for the rest of the series to work.

Problem that such things start to spread all over the kernel with a
copy-paste approach if there is nobody to clean up the code.

This is not a common convention and sometimes it's getting corrected [1].

[1] https://git.kernel.org/linus/6d7434931


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:19:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:19:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244195.422358 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkUY-0005WP-4T; Fri, 10 Dec 2021 18:19:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244195.422358; Fri, 10 Dec 2021 18:19:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkUY-0005WI-12; Fri, 10 Dec 2021 18:19:34 +0000
Received: by outflank-mailman (input) for mailman id 244195;
 Fri, 10 Dec 2021 18:19:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvkUX-0005WC-GS
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:19:33 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b8c12e3f-59e5-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:19:32 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id d10so19561203lfg.6
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:19:32 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id u16sm379604lfu.42.2021.12.10.10.19.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 10:19:31 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b8c12e3f-59e5-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=EXOlhuwO6PwxX2A+xhcTtBM4hDyUpnAJiexjEXDAvCY=;
        b=AqjAg4O7giyzVdt+tBG9uHdplJtifqxLx/yVu+cgoY6plA3iYDA6wXW+lamp4aSGK0
         JtAw3aPoKL/gydUbbFYOf1pi7KNgtnB7CRHE+MknWMiFR30YU057EAppHMp3RQPfHd8d
         06yVvqsThCCunZ4BRns7COFfMth1pjRjda7taFbydUf0oWJrqvgB05orw4q9ScnuxSKa
         RGrhlOCs187IEnib8HCpTe8JzWEZV9cVroOWHPffKJtOeT7C/Fogm7PG4qgUyWMygMmF
         ds56Fkt5Zck/MXhrzJhxcRgHcy1bwpmNWqyftpmBQa7CL/iiV+9v5OptrusSns2ZXc73
         k16Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=EXOlhuwO6PwxX2A+xhcTtBM4hDyUpnAJiexjEXDAvCY=;
        b=bdnRuRqVi4nq2essqgd7kyakI+CWY9OfZXU23kC2oIUMXU+LAcVbuZYjLCDQyvq0Se
         nHE5UvxDFhalwthjg8/rcY5CkAh9jeGceABCnhh9AlShAZdSC/OLExi97ZTAP453AtH8
         rEfDSkv1NAI19zIIS0yvKBUypj8meN4hE5Y7CzKQg207iGH4R9Sro65YihLwbaiPDRz/
         g9LwphU4bDKsiUEf8O4dg1aq/CJ/hdYnpW/vPxIAT6ijMwmSy1i1iPHlLuBf9nXxw0pw
         P8Qa3HBUqtO4lDhtm9CSDdRlv8otgJWXItkvfFAxTJKnDfX9mPhycmQWW61UJcms7+e1
         nZ3w==
X-Gm-Message-State: AOAM532kGYrwljapUIAkbdT5QPFWEDXBpBgxWYTHgvbe7KTb3lCBtR4a
	MdpoaUTnn838bmr+Qf5+q8U=
X-Google-Smtp-Source: ABdhPJzMrOyS+fXdy9iuUu0OwY3ayky869D80K4hHhkf8whZoWRjpK8Gq06BVfaBtvKTtjzQFmSyrg==
X-Received: by 2002:a05:6512:2603:: with SMTP id bt3mr13366040lfb.202.1639160372149;
        Fri, 10 Dec 2021 10:19:32 -0800 (PST)
Subject: Re: [PATCH v4 02/25] notifier: Add
 blocking_notifier_call_chain_is_empty()
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-3-digetx@gmail.com>
 <CAJZ5v0gy5M5yYT7k5CY0JtW4MvsgKq4psBEw81UKz=pjGo0xPw@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <9307a684-0b0b-0488-75be-7845d9b973a1@gmail.com>
Date: Fri, 10 Dec 2021 21:19:29 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gy5M5yYT7k5CY0JtW4MvsgKq4psBEw81UKz=pjGo0xPw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:14, Rafael J. Wysocki пишет:
> On Fri, Nov 26, 2021 at 7:01 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> Add blocking_notifier_call_chain_is_empty() that returns true if call
>> chain is empty.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  include/linux/notifier.h |  2 ++
>>  kernel/notifier.c        | 14 ++++++++++++++
>>  2 files changed, 16 insertions(+)
>>
>> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
>> index 4b80a815b666..924c9d7c8e73 100644
>> --- a/include/linux/notifier.h
>> +++ b/include/linux/notifier.h
>> @@ -173,6 +173,8 @@ int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh,
>>  int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
>>                 unsigned long val_up, unsigned long val_down, void *v);
>>
>> +bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh);
>> +
>>  #define NOTIFY_DONE            0x0000          /* Don't care */
>>  #define NOTIFY_OK              0x0001          /* Suits me */
>>  #define NOTIFY_STOP_MASK       0x8000          /* Don't call further */
>> diff --git a/kernel/notifier.c b/kernel/notifier.c
>> index b8251dc0bc0f..b20cb7b9b1f0 100644
>> --- a/kernel/notifier.c
>> +++ b/kernel/notifier.c
>> @@ -322,6 +322,20 @@ int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
>>  }
>>  EXPORT_SYMBOL_GPL(blocking_notifier_call_chain);
>>
>> +/**
>> + *     blocking_notifier_call_chain_is_empty - Check whether notifier chain is empty
>> + *     @nh: Pointer to head of the blocking notifier chain
>> + *
>> + *     Checks whether notifier chain is empty.
>> + *
>> + *     Returns true is notifier chain is empty, false otherwise.
>> + */
>> +bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
>> +{
>> +       return !rcu_access_pointer(nh->head);
>> +}
>> +EXPORT_SYMBOL_GPL(blocking_notifier_call_chain_is_empty);
> 
> The check is not reliable (racy) without locking, so I wouldn't export
> anything like this to modules.
> 
> At least IMO it should be added along with a user.
> 

I'll remove the export since it's indeed not obvious how other users may
want to use this function.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:20:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:20:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244197.422369 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkV5-0006l2-EK; Fri, 10 Dec 2021 18:20:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244197.422369; Fri, 10 Dec 2021 18:20:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkV5-0006kv-AZ; Fri, 10 Dec 2021 18:20:07 +0000
Received: by outflank-mailman (input) for mailman id 244197;
 Fri, 10 Dec 2021 18:20:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkV3-0006ev-QV
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:20:05 +0000
Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com
 [209.85.161.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb747a9b-59e5-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:20:04 +0100 (CET)
Received: by mail-oo1-f44.google.com with SMTP id
 w15-20020a4a9d0f000000b002c5cfa80e84so2595243ooj.5
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:20:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb747a9b-59e5-11ec-a74f-db008197e53d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=otNvdkTkoV7wYQ8jKu5rR7dHo6vQCE5BmfrHPdMYTOI=;
        b=4BJDWz75nxCkv1l8VcO9qGsBppwao+2LMCsxohG7tgxn3CCzLMuNtqOE4MGnpt3Kh+
         05v3AQcgUVrJza7s7jG5hD6jON7kumXc3h/IiT6YPYS6D4gXw9p+O0jYzdtDgzR3LfQU
         crVKS6eMhrBhpNJ5zbg8eIZSiXPgfy3opedBVXZiydSTFbeTLeYgP03Uv79TcEsS0nWV
         9ZkWswqpUKb/HPnH8Xhe+40byT8WHxfrSLb/XgF/o409vBncH2ktk0A/awdnTmgqqDN/
         aKYLGoXzSIqTEZb48tOFumpkOiBK5b6a04jo6ViJ2EPFEMNlkE1MwYn85zEYa30lRecB
         XOzA==
X-Gm-Message-State: AOAM531TRMfvvz+ifJY1CSyjQ4vK1k1YI1wKNxFO8goOjGSCijEKcxlX
	JJMI5iPlB759qK7r6LKj1OkPdnT5+p1VgiBCEk8=
X-Google-Smtp-Source: ABdhPJwWhlgSTT1XO9DdsJeGtp3+qj/KLI9CFrQ1iXrm/9qKavB6UGr0uIjkNl6uj3XKEKq2VM+aZTVW+dl+zG+2Q+M=
X-Received: by 2002:a4a:1d82:: with SMTP id 124mr9074671oog.91.1639160403307;
 Fri, 10 Dec 2021 10:20:03 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-4-digetx@gmail.com>
In-Reply-To: <20211126180101.27818-4-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:19:52 +0100
Message-ID: <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com>
Subject: Re: [PATCH v4 03/25] notifier: Add atomic/blocking_notifier_has_unique_priority()
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> Add atomic/blocking_notifier_has_unique_priority() helpers which return
> true if given handler has unique priority.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  include/linux/notifier.h |  5 +++
>  kernel/notifier.c        | 69 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 74 insertions(+)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index 924c9d7c8e73..2c4036f225e1 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -175,6 +175,11 @@ int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
>
>  bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh);
>
> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
> +               struct notifier_block *nb);
> +bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
> +               struct notifier_block *nb);
> +
>  #define NOTIFY_DONE            0x0000          /* Don't care */
>  #define NOTIFY_OK              0x0001          /* Suits me */
>  #define NOTIFY_STOP_MASK       0x8000          /* Don't call further */
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index b20cb7b9b1f0..7a325b742104 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -122,6 +122,19 @@ static int notifier_call_chain_robust(struct notifier_block **nl,
>         return ret;
>  }
>
> +static int notifier_has_unique_priority(struct notifier_block **nl,
> +                                       struct notifier_block *n)
> +{
> +       while (*nl && (*nl)->priority >= n->priority) {
> +               if ((*nl)->priority == n->priority && *nl != n)
> +                       return false;
> +
> +               nl = &((*nl)->next);
> +       }
> +
> +       return true;
> +}
> +
>  /*
>   *     Atomic notifier chain routines.  Registration and unregistration
>   *     use a spinlock, and call_chain is synchronized by RCU (no locks).
> @@ -203,6 +216,30 @@ int atomic_notifier_call_chain(struct atomic_notifier_head *nh,
>  EXPORT_SYMBOL_GPL(atomic_notifier_call_chain);
>  NOKPROBE_SYMBOL(atomic_notifier_call_chain);
>
> +/**
> + *     atomic_notifier_has_unique_priority - Checks whether notifier's priority is unique
> + *     @nh: Pointer to head of the atomic notifier chain
> + *     @n: Entry in notifier chain to check
> + *
> + *     Checks whether there is another notifier in the chain with the same priority.
> + *     Must be called in process context.
> + *
> + *     Returns true if priority is unique, false otherwise.
> + */
> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
> +               struct notifier_block *n)
> +{
> +       unsigned long flags;
> +       bool ret;
> +
> +       spin_lock_irqsave(&nh->lock, flags);
> +       ret = notifier_has_unique_priority(&nh->head, n);
> +       spin_unlock_irqrestore(&nh->lock, flags);

This only works if the caller can prevent new entries from being added
to the list at this point or if the caller knows that they cannot be
added for some reason, but the kerneldoc doesn't mention this
limitation.

> +
> +       return ret;
> +}
> +EXPORT_SYMBOL_GPL(atomic_notifier_has_unique_priority);
> +
>  /*
>   *     Blocking notifier chain routines.  All access to the chain is
>   *     synchronized by an rwsem.
> @@ -336,6 +373,38 @@ bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
>  }
>  EXPORT_SYMBOL_GPL(blocking_notifier_call_chain_is_empty);
>
> +/**
> + *     blocking_notifier_has_unique_priority - Checks whether notifier's priority is unique
> + *     @nh: Pointer to head of the blocking notifier chain
> + *     @n: Entry in notifier chain to check
> + *
> + *     Checks whether there is another notifier in the chain with the same priority.
> + *     Must be called in process context.
> + *
> + *     Returns true if priority is unique, false otherwise.
> + */
> +bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
> +               struct notifier_block *n)
> +{
> +       bool ret;
> +
> +       /*
> +        * This code gets used during boot-up, when task switching is
> +        * not yet working and interrupts must remain disabled. At such
> +        * times we must not call down_read().
> +        */
> +       if (system_state != SYSTEM_BOOTING)

No, please don't do this, it makes the whole thing error-prone.

> +               down_read(&nh->rwsem);
> +
> +       ret = notifier_has_unique_priority(&nh->head, n);
> +
> +       if (system_state != SYSTEM_BOOTING)
> +               up_read(&nh->rwsem);

And still what if a new entry with a non-unique priority is added to
the chain at this point?

> +
> +       return ret;
> +}
> +EXPORT_SYMBOL_GPL(blocking_notifier_has_unique_priority);
> +
>  /*
>   *     Raw notifier chain routines.  There is no protection;
>   *     the caller must provide it.  Use at your own risk!
> --
> 2.33.1
>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:21:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:21:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244204.422379 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkWL-0007Ol-O5; Fri, 10 Dec 2021 18:21:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244204.422379; Fri, 10 Dec 2021 18:21:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkWL-0007Oe-L2; Fri, 10 Dec 2021 18:21:25 +0000
Received: by outflank-mailman (input) for mailman id 244204;
 Fri, 10 Dec 2021 18:21:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkWK-0007OU-3I
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:21:24 +0000
Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com
 [209.85.210.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa604526-59e5-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:21:23 +0100 (CET)
Received: by mail-ot1-f50.google.com with SMTP id
 47-20020a9d0332000000b005798ac20d72so10420096otv.9
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:21:23 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa604526-59e5-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=CGnO4bxnTAqMK/uthYlBDN3+OwLPbg309qxpgobdKxI=;
        b=ksZIEvcpYx33W6T4oWVnODlPjYPbc9kw21gBhLsMkR3d244tlOdMTPp3s8LUBzIcCa
         v6EBL8Np37eCJiz5tHp+8NGOVEzgHgIzDX7idvJzwwX6CzbpCTlKfoJN8w/SNV3nej6J
         MGbsRXXTWa9llJjzs+0sV2PWNA7K4pHw62T6CjGErmnhaGMjRNUiKnT+QziFnwb6MbzQ
         JqTAeJwZrOTew9kAZPkv+5SZzEOr7GfQsPQ3M5nXoeSfbqxXD3aDJI3VLGAwqZDtGzCX
         x/0rte4KdsALwG9aKKLs0LMLvRXCbJV6Fi2XbbvmKQ9LOiqdpVvqC3ZaTl+W5Ly0qst7
         /P6Q==
X-Gm-Message-State: AOAM53172OnmRj/1/Lk9dtf6DQW3NJGC3lCZ/iYLPYrrQd53SoeXDrvM
	px8HjdfKMToF6q0uhTw8nGlOiqDwM+NJ81PePik=
X-Google-Smtp-Source: ABdhPJxyUbegeOKjvJ3CxiHL7dwpj9EzFVDPRUNdKiJGM3d307QrxgUO9bUGZj0EMwemLB2snxZHAeDirffJcqK0rDM=
X-Received: by 2002:a05:6830:1e57:: with SMTP id e23mr12377743otj.16.1639160481982;
 Fri, 10 Dec 2021 10:21:21 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-5-digetx@gmail.com>
In-Reply-To: <20211126180101.27818-5-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:21:11 +0100
Message-ID: <CAJZ5v0h_OfrQ92KqsUdiKAfUrXDT9dPXzq4S=b6zi4k_2cPAjg@mail.gmail.com>
Subject: Re: [PATCH v4 04/25] reboot: Correct typo in a comment
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> Correct s/implemenations/implementations/ in <reboot.h>.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

This patch clearly need not be part of this series.

> ---
>  include/linux/reboot.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/reboot.h b/include/linux/reboot.h
> index af907a3d68d1..7c288013a3ca 100644
> --- a/include/linux/reboot.h
> +++ b/include/linux/reboot.h
> @@ -63,7 +63,7 @@ struct pt_regs;
>  extern void machine_crash_shutdown(struct pt_regs *);
>
>  /*
> - * Architecture independent implemenations of sys_reboot commands.
> + * Architecture independent implementations of sys_reboot commands.
>   */
>
>  extern void kernel_restart_prepare(char *cmd);
> --
> 2.33.1
>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:28:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:28:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244222.422392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkct-0000L5-Kk; Fri, 10 Dec 2021 18:28:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244222.422392; Fri, 10 Dec 2021 18:28:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkct-0000Ky-Fd; Fri, 10 Dec 2021 18:28:11 +0000
Received: by outflank-mailman (input) for mailman id 244222;
 Fri, 10 Dec 2021 18:28:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkcr-0000Ks-H8
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:28:09 +0000
Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com
 [209.85.210.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ebc8ab64-59e6-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:28:08 +0100 (CET)
Received: by mail-ot1-f51.google.com with SMTP id
 u18-20020a9d7212000000b00560cb1dc10bso10437408otj.11
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:28:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ebc8ab64-59e6-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=O1tFpICrUp02/Rz91q5M3zJOsfP+AsepTWSxKHsDYko=;
        b=VeeXJEKiXe8B/fb4Qdz+weDWOq2P1SSQ49Il5Mdbe6nH+PIXM9mSV3zSA1LLmWZr5r
         gEsz8gmuc13Te7qwT82xw+WdXy33goHFXcSATea0KjFx+ciNGXYBCNQ+8Mts2+0kOEmS
         zQg0waEUlvv4DnENdN2WQ4VUiZ7vKiBoQt1fCOhdKnvGOsa9T6FfZuQPdY6NYjKtBSOE
         LGY6i2lva32uRR92eW6r1BEcnpMquxW+iIgJW1/fVMEuztVtAEovdAp7qhRFgybPQXb8
         CZVA1DHqfiU5ynMACqzUGnJ+vWBcXCrhdT2fizkTvjdgYeXuGfR72kGE2/O6AGgppllO
         SNLA==
X-Gm-Message-State: AOAM533FQPgAWpF2O2s5gJwsRzhJ3vFxrNv7l5kJiCkLMcJSNE3Ddac4
	QfPUIfcU+EmWciT+AQIWJlb7MA9Tx+K48dQhmEM=
X-Google-Smtp-Source: ABdhPJyYCS/8s4tkJCG4AWTeWKT+d6o4I/cnaoDS1n1/MlonZY2Ew73o7SGhiWkpQrPntkE0d8ozu+9C4WKQVKYTs8M=
X-Received: by 2002:a9d:4c10:: with SMTP id l16mr12535470otf.198.1639160886984;
 Fri, 10 Dec 2021 10:28:06 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-6-digetx@gmail.com>
 <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl> <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl> <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
In-Reply-To: <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:27:55 +0100
Message-ID: <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority
To: Dmitry Osipenko <digetx@gmail.com>
Cc: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 29.11.2021 03:26, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=B5=D1=
=82:
> > On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote:
> >> 28.11.2021 03:28, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=B5=
=D1=82:
> >>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote:
> >>>> Add sanity check which ensures that there are no two restart handler=
s
> >>>> registered with the same priority. Normally it's a direct sign of a
> >>>> problem if two handlers use the same priority.
> >>>
> >>> The patch doesn't ensure the property that there are no duplicated-pr=
iority
> >>> entries on the chain.
> >>
> >> It's not the exact point of this patch.
> >>
> >>> I'd rather see a atomic_notifier_chain_register_unique() that returns
> >>> -EBUSY or something istead of adding an entry with duplicate priority=
.
> >>> That way it would need only one list traversal unless you want to
> >>> register the duplicate anyway (then you would call the older
> >>> atomic_notifier_chain_register() after reporting the error).
> >>
> >> The point of this patch is to warn developers about the problem that
> >> needs to be fixed. We already have such troubling drivers in mainline.
> >>
> >> It's not critical to register different handlers with a duplicated
> >> priorities, but such cases really need to be corrected. We shouldn't
> >> break users' machines during transition to the new API, meanwhile
> >> developers should take action of fixing theirs drivers.
> >>
> >>> (Or you could return > 0 when a duplicate is registered in
> >>> atomic_notifier_chain_register() if the callers are prepared
> >>> for that. I don't really like this way, though.)
> >>
> >> I had a similar thought at some point before and decided that I'm not =
in
> >> favor of this approach. It's nicer to have a dedicated function that
> >> verifies the uniqueness, IMO.
> >
> > I don't like the part that it traverses the list second time to check
> > the uniqueness. But actually you could avoid that if
> > notifier_chain_register() would always add equal-priority entries in
> > reverse order:
> >
> >  static int notifier_chain_register(struct notifier_block **nl,
> >               struct notifier_block *n)
> >  {
> >       while ((*nl) !=3D NULL) {
> >               if (unlikely((*nl) =3D=3D n)) {
> >                       WARN(1, "double register detected");
> >                       return 0;
> >               }
> > -             if (n->priority > (*nl)->priority)
> > +             if (n->priority >=3D (*nl)->priority)
> >                       break;
> >               nl =3D &((*nl)->next);
> >       }
> >       n->next =3D *nl;
> >       rcu_assign_pointer(*nl, n);
> >       return 0;
> >  }
> >
> > Then the check for uniqueness after adding would be:
> >
> >  WARN(nb->next && nb->priority =3D=3D nb->next->priority);
>
> We can't just change the registration order because invocation order of
> the call chain depends on the registration order

It doesn't if unique priorities are required and isn't that what you want?

> and some of current
> users may rely on that order. I'm pretty sure that changing the order
> will have unfortunate consequences.

Well, the WARN() doesn't help much then.

Either you can make all of the users register with unique priorities,
and then you can make the registration reject non-unique ones, or you
cannot assume them to be unique.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:32:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:32:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244227.422402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkhG-0001iV-4T; Fri, 10 Dec 2021 18:32:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244227.422402; Fri, 10 Dec 2021 18:32:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkhG-0001iO-1V; Fri, 10 Dec 2021 18:32:42 +0000
Received: by outflank-mailman (input) for mailman id 244227;
 Fri, 10 Dec 2021 18:32:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkhE-0001iI-FU
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:32:40 +0000
Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com
 [209.85.210.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8d7e1936-59e7-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:32:39 +0100 (CET)
Received: by mail-ot1-f54.google.com with SMTP id
 v15-20020a9d604f000000b0056cdb373b82so10482431otj.7
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:32:39 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d7e1936-59e7-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=XYFeMefDtygzQHG6cGasFJft83PyhMCvIHgML7JQ1W8=;
        b=GWUFwvt/Uw5U+ek9xO5fZc3BUkwAkF2qhUk/SvNVsh0s0GFQHk59QIydpKDYMMIz1H
         osVr9M9jjDQSQt1sMxuJYkJhwGwkrvw9Z/6FSu4kEmKOg4gLgHgG0aeM9zikHZdiXG7Y
         dPTus7aeEdmK+i3OhA+QqfuJcX5j4dTv9o0RudDHNHDokxSXcgbRDHrYfFezr8arNSiH
         xNvt/hcynw3dIvorTsJ9xYfQc7387aqXyl+vBCu8+BGlKcDw/nKQmIE1W9mFGJw31LHR
         RCV2o336KQhGKCsX4EpWxN+bcW7frU6c61B5uzZ5Ci3spYA4+ut3LxtJfCKBvCenF/DL
         ZVzg==
X-Gm-Message-State: AOAM530xlrVmeC6XOd4W0SfllfxwCyi1E3gTOYM8G9UWe+7dKFRDsm7j
	lk1d8Gk0f0WdlsRKUPRibmFWu6HdphTcDFgiGWw=
X-Google-Smtp-Source: ABdhPJy/ApH2I9ley83OfAtDiEoSWuJBoE9Gqun3QKF0IviB+39TRacgd3bR+5yVv4MXsqS5F4aemy99lcaDR84MB0I=
X-Received: by 2002:a05:6830:348f:: with SMTP id c15mr12642134otu.254.1639161158278;
 Fri, 10 Dec 2021 10:32:38 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-7-digetx@gmail.com>
In-Reply-To: <20211126180101.27818-7-digetx@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:32:27 +0100
Message-ID: <CAJZ5v0ii7tGRDbxw+5GqdyONXvRPznXUqBZd03+pdoAd+pH=JQ@mail.gmail.com>
Subject: Re: [PATCH v4 06/25] reboot: Warn if unregister_restart_handler() fails
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> Emit warning if unregister_restart_handler() fails since it never should
> fail. This will ease further API development by catching mistakes early.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  kernel/reboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index e6659ae329f1..f0e7b9c13f6b 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler);
>   */
>  int unregister_restart_handler(struct notifier_block *nb)
>  {
> -       return atomic_notifier_chain_unregister(&restart_handler_list, nb);
> +       return WARN_ON(atomic_notifier_chain_unregister(&restart_handler_list, nb));

The only reason why it can fail is if the object pointed to by nb is
not in the chain.  Why WARN() about this?  And what about systems with
panic_on_warn set?

>  }
>  EXPORT_SYMBOL(unregister_restart_handler);
>
> --
> 2.33.1
>


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:35:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:35:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244232.422412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkjv-0002LE-If; Fri, 10 Dec 2021 18:35:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244232.422412; Fri, 10 Dec 2021 18:35:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkjv-0002L7-Fb; Fri, 10 Dec 2021 18:35:27 +0000
Received: by outflank-mailman (input) for mailman id 244232;
 Fri, 10 Dec 2021 18:35:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvkju-0002L1-M0
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:35:26 +0000
Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com
 [209.85.167.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f0869579-59e7-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:35:25 +0100 (CET)
Received: by mail-oi1-f172.google.com with SMTP id bf8so14395659oib.6
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:35:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0869579-59e7-11ec-a74f-db008197e53d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=cmWwBA8Prvw8yKg8YllQ7/9D+dqLH//9VzjE/Uy0t0I=;
        b=NALq1uh0Fj4hBS1R5YDqEz59DbyBc6zHGwXFzVs/Snf3Vb8SwSpFXLuw4Vu9jdQ9kU
         vVEPezKuN/Tg4B3FfWbNuNgRj6kH0na/1rAmQ1y3jnxNLetWo6SE2c4Yq7x88iJ/Es9x
         TFc2tfTEtY/JwCemCg0+tfGm+ph1guBnnuPKm9W0NJtaK/Rk2LJLslQtKQToYfoompLw
         Bk1NDGm1yOAc2GLphvTAOMq7i5agB2Y/p8lvjIn0VYlkLfKs3Y9QIb3tbsSa1AhghisC
         yAZ1DpkghMeLJAWvTbdLqTBtG5+JbBq9kyhAD4KinCtbIZj0Q6FxkTy3IsBa7pdJDTFh
         vjBw==
X-Gm-Message-State: AOAM531P+6M5dglZuZgqjWf1Dufroe8Do8tyuadIPcKd5cinbAuSkZko
	Lxo2/fycbjPYycEmR3JIZ2kURpjgqNFg1DXlehw=
X-Google-Smtp-Source: ABdhPJy55tGpIDxF+0NXDym/GuLq/jPswo3lW9bQPH3JZ5naSMZQfeBVB0yUiflqPmuJ6rchV13JR6onKlnNSicDR4M=
X-Received: by 2002:aca:eb0b:: with SMTP id j11mr14005588oih.51.1639161324582;
 Fri, 10 Dec 2021 10:35:24 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-8-digetx@gmail.com>
 <CAJZ5v0i=zgubEtF5-Wnaqa5FMnfVUdSnEmD11-LAuYCH8ZCwrA@mail.gmail.com> <acf8289e-6ab8-6eda-ec06-e9044ddd9a92@gmail.com>
In-Reply-To: <acf8289e-6ab8-6eda-ec06-e9044ddd9a92@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 19:35:13 +0100
Message-ID: <CAJZ5v0gvuteY4EtXWTKmh4-Wt-Z_dPcqfDLwc-ja1uovbV3rpw@mail.gmail.com>
Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function prototypes
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 7:16 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 10.12.2021 21:09, Rafael J. Wysocki =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrot=
e:
> >>
> >> There is no need to annotate function prototypes with 'extern', it mak=
es
> >> code less readable. Remove unnecessary annotations from <reboot.h>.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >
> > I'm not sure that this is really useful.
> >
> > Personally, I tend to respect the existing conventions like this.
> >
> > Surely, this change is not required for the rest of the series to work.
>
> Problem that such things start to spread all over the kernel with a
> copy-paste approach if there is nobody to clean up the code.
>
> This is not a common convention and sometimes it's getting corrected [1].
>
> [1] https://git.kernel.org/linus/6d7434931

In separate patches outside of series adding new features, if one is
so inclined.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:37:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:37:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244237.422424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkmA-0003X9-Vz; Fri, 10 Dec 2021 18:37:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244237.422424; Fri, 10 Dec 2021 18:37:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvkmA-0003X2-Su; Fri, 10 Dec 2021 18:37:46 +0000
Received: by outflank-mailman (input) for mailman id 244237;
 Fri, 10 Dec 2021 18:37:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=lrZX=Q3=epam.com=prvs=297895717b=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mvkm9-0003Ww-Ui
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:37:46 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42e63821-59e8-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:37:44 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BAH6d7o016475;
 Fri, 10 Dec 2021 18:37:31 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cvab3ras4-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 10 Dec 2021 18:37:31 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4145.eurprd03.prod.outlook.com (2603:10a6:208:c9::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 10 Dec
 2021 18:37:21 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.014; Fri, 10 Dec 2021
 18:37:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42e63821-59e8-11ec-a74f-db008197e53d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=O/EWCPTZdlI54PT/IcMdW08sp8FNVpjFWY1WfR9gCSJ9KS710uRT9yqYTknUg1Oh7zX00fXNQEqFwnEnm8YjMT0UrY48w6hAsQsN7cTrM3/DyP/TNXRKiADc9XKbpoU4620RqyF5RDdBJLAwaEEet0mtt+Lr1pTW2njFDoDFuGK7OBP7C+y2wp/0WMxxrkSPIQOyuUoq63TTtFUVcYusCYIPcUwiPgwH5MD5J1TTkXxl27m9V5Fwfn4iqcw7Jat5p/PDizvi1o6S+zTuib7yZLckMpj+rV6Xggq+0Yddxu7wPKjMpaJgzNI+8Un+dAQlvrpfSIThp4ggmWvvcKGLqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qBMrnK8FE5UpZd3amEKKd2tlKe96FYPd0Mksfq8EJRg=;
 b=h2qqwfRidIojbeqJ5GoDDZoeMC8pNqk1C09oFNOrFywt3ZljPqOCY4B1dstXpBqo3jDqc271B1vMHZlJOaJT7OV8nKdgfHlFDOO220bdCjHLzozf1RwxDeOE6rAcj3UElm1zm9VlhaZCEBfKj13anV+JzruGWJ44vjKWZwwJKrtmbu8GCjp+21poFDWEmGwbJ0rU/kajVx/RsWgg7kVuH01suHJ4QEmHwI83PQRo5Ug74dY05Rdn+PgJVxSv3hoJmVWlYZBKxH1zeGh8wLOCnViLnRCI84fV0CDVR/mxJ0FX7xy3wxbv4NFzRutQWkd6hIw2j0lkDcP34Tg0QOz1bA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qBMrnK8FE5UpZd3amEKKd2tlKe96FYPd0Mksfq8EJRg=;
 b=rtK1I6QTweNFrjjtW5yQl7QNx4Pydgj9MJh2/KlylnwpUutB5eSxWAM/+ZmEmsvttWVM5KCO89DGg+cAZfX1I9las81IBL5q6e52+2Jwdg3ET7SxDvwsm/aJDumcW7Y/JHYyFJluwd94l6hkdutUUe3t1dkztFdmAMW2JiWcdpkM8zwmkdzBmnNXKp+nIccZhBZ6H0BKCIhWSD588DduHZsDR0OzLLm3zxT+2em0/fCTHkhBg7ZR3t8l6OLc1xmaKXJiHfJCLK3b9KT6YwqHTL55/ghT3UX1lywu7lAdNksXfqXuVOBgveFkjVMqqJxLSxO/LCnB0FtkLv690b67OQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        Oleksandr Andrushchenko
	<andr2000@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>
Subject: Re: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Topic: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
Thread-Index: AQHX7M6BKfC+NnP8FUmShHJlmPRsZqwsA82AgAAMgoA=
Date: Fri, 10 Dec 2021 18:37:20 +0000
Message-ID: <d58e87db-2be9-e982-b78e-64d72afb59ef@epam.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-3-andr2000@gmail.com>
 <78ee3d68-7901-2cfe-b0f1-76239339dc49@xen.org>
In-Reply-To: <78ee3d68-7901-2cfe-b0f1-76239339dc49@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 851ecf5b-1462-4dc5-57b2-08d9bc0c19fe
x-ms-traffictypediagnostic: AM0PR03MB4145:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB414542FCFD6F1D74165B3F67E7719@AM0PR03MB4145.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 xwYXtF3dWkSySQwNgUmR4qqXImgxSQNq7J8m+2813CS9h/dcQHN+hANs9v4RWcRUptperUBlDckELTDkn3SeNtN3HvifVsDWDCD83jfUC6Nb1rwXlBTcy31qP3sNLtk3/aGjx5u9MZfKPGHWKDwdxDSUvM5NbO6GzMMIwhINtegFIdd7S4xXQXHRF0L8/h5IUaVKjrIANIa2oymjHcTPHkJHmbEHB+OW/iPMqd2ul9H4KiLgeHsXLHlCPpRhmCIpRzYzsGCKc6n4szO8rQJcYHLEETXCnfa61s6I6GPNGfu4DEfn1yE4xE6Aow5WQEbpRsD/KAHUdsJNJ74Qb+po9904o6DLskv40BKSkq7XtR39DYRah+w/tdqqbjhcHsM4IFkovExW4HWFP23WNNp0hkJ3S+D1ncaWPZ/g7HJkA3SuYMzOJ9Uk8T6r4PIHm2NSMETiRqZNay+k/oXRe5PbvciyFKPGX4Tv1f42SRycUFd0FebPZsCMH4GAoqiKuKBU9JH+QGfuLB9M273Wmx4zQK4jq/lqebgN/eZ1GQyL9sqWGorf/K4DxiDZTBCw7qWGgQwPv20FLl+iKS2Vcl0oLhQvabU2tVsU0oAXcZ6MYMCSA4soPGPG40T13BzCFB+J+t64q1jhoO2lpjy1i/JueaZ6hwkyGG5ksQia0ON7B7lFdVJ/oDl2KrJrdkJhdvLd2xgfTqDVnyTn/OOeqwCzVwWd5+QIdfHGRco0nqnhBUw=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(5660300002)(31686004)(54906003)(110136005)(8676002)(55236004)(6512007)(122000001)(316002)(4744005)(508600001)(36756003)(2616005)(38100700002)(86362001)(26005)(31696002)(53546011)(76116006)(4326008)(71200400001)(186003)(66556008)(66446008)(6506007)(64756008)(66476007)(2906002)(8936002)(38070700005)(91956017)(66946007)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?VmwyWGNLaHZ2VzBkQzlIckxybS83Mm81VVo3MUFPb3o1bE1FN25IdEpHWHlq?=
 =?utf-8?B?dnIydnp1ZUlOVlppUUlpeEgyZHNKbDVsVDB5dlhJNTZVVEVMdXVTek1iT3Nz?=
 =?utf-8?B?aUZKeGoxbTNRRlBuWncxVTNEUE8xVFQ2K1BVd1NkR2ZzbWdUbnYrbW03bWQ1?=
 =?utf-8?B?S2dRWFJJMW1wRlcxUjdYMmk4S2J0b011bHQxVnQ3WFhjWHE0cVgzUi94aEhC?=
 =?utf-8?B?RUpMaFEwUjJNbmpaQWpuTldVWm5zUmtKdmltLzNqWmIyWFBwbEdwSk54R0hU?=
 =?utf-8?B?UWhJeDlzREY5RlJPSWd2Q2xWa0RpWGxnWC9qbmI2TzF6clorQlJoZE1YQUZF?=
 =?utf-8?B?UmR2T1lRTzlhMXVoaGJoSXowSXZqUkNYUkhBaTNMNEcrNUtUNTBURDlKZFgz?=
 =?utf-8?B?QXlWVW81eFJGWWFiNVVDWkdtZHJFNlB0YS9nZytIejF2a1VJWlpVVjVNbnk1?=
 =?utf-8?B?dTZqVmlQald6VmdFdDVVVFlsSkFWOVJ3RW8zSXcxRTdDYlpwZEJoRk1QU2wy?=
 =?utf-8?B?R01HWlpaWEdXeS92bEVra00xbVlMVWZxU0lLQzlJNlNocWF0d1plWFM3bmpl?=
 =?utf-8?B?V0Q0ZlZYNGU2SERVUGFlbmhwaGlMK013aHVaYmlNOENLWG5iMjQwS0swbWRp?=
 =?utf-8?B?NE9GaytqS2RNSmFtQUprbXVRSW05Yml3ZXArWkh2dG9CdERXNmNRa29IU3Qz?=
 =?utf-8?B?ZExnVjQxMkRhdnNRMUlYeVM3M0JKc2hKUmd1bFhIdnpPQmExc0NBNzZnRUxw?=
 =?utf-8?B?bHNiU1ExKzBKMWRJaS9yZDNDZEE3NitRK2tqMEdLR0JaQW8wb2Y3Qnk0bFpO?=
 =?utf-8?B?ZkphR1drTVBpaWFkY0JGTXNRbGFQSVVNMEhOTnc0ZHlhazZDdkY2WjE3U3dU?=
 =?utf-8?B?VkRIMEk2MXR5OUg4UDRkKzRXc1RFNlowVzdtNDd3K2dBVDAzYTRhajdoVFNs?=
 =?utf-8?B?cnNCQXhnUysvSHR4UjBtNTh2SWxhQnB2TGsxWFYrdkpZSEZadTd3WGZCMXBr?=
 =?utf-8?B?TUxEb1lxeEJ0dVJjUDhXN3RhQWNCTXRhYUdZR1VMM1NZYlJjVE5Sc2hNRUxQ?=
 =?utf-8?B?UlR3czIrRGtZQUJnWjg2dDMwU1QxQkk3cm9LOVVNU2lWQkdMYjU3UXdPRzhx?=
 =?utf-8?B?NHNKYkZibWcvUmNlTWFPd2QvVDA4SU1VV2Q3WUxmWmpoMTEybmoxdTFqc2Rm?=
 =?utf-8?B?NFk3Z0cxM0o1cWFIUThCMWpGTDdpTUtPS3RtZEpGWTRKa2NPTnYzenJiTyt5?=
 =?utf-8?B?dFB5K1FFWGhRV1NqKy9qWWJ0TkVoT1JITlVvY25ZSFdYdFNIZHdEcTE3WTFB?=
 =?utf-8?B?aW1pOC9vSU1sZmtXTzVydlFMbVg5aktNS3ZkWnBYUUxXK1hlbS9jMVRLN3A1?=
 =?utf-8?B?ZVlFMUVIZ0dLdU1NcktYNko2a0l3NGY0ZHBVbjRjdTk1THRpUDRuaWx5bnhz?=
 =?utf-8?B?MFh4OUpPTFV5ajBMeno5V2w0Y2lNeWZDV0RtUUdMem9nai9wYnYzMDdXUFYx?=
 =?utf-8?B?bFFKNlVldTl1dWMwc0tXUlJjVGdHeEYyQTUvM3g2SXg1cFFhaW1TUHE3QXF0?=
 =?utf-8?B?ZVpMVGdIRzZHQzJjd0NVWkN0ak0rZlkzemM5VjUrbHBCYUZYR0w2YjdxdjZl?=
 =?utf-8?B?RHg3NjFJZ1ZQWjE0QysvdEk0TnZEamxETytWbXJQcG5tWXZ3V3I1OVBWU2RP?=
 =?utf-8?B?ZUpFODY2WS8rcDBGMUpJdmFTcHg3N2xxaHFheUptY091NWN2TUc4V1BDT3hX?=
 =?utf-8?B?aDN6RUxERUtRU09PWDdxSUl4b204ODlhRkU1NDdaTFJFVTVLMWVaUDluVkFh?=
 =?utf-8?B?c0EyU2VZaE1BN3laY1MrSFFYR1QyOVNjd3hkZFlBeWtVMUYrWVpzV0psaXNu?=
 =?utf-8?B?N3pDQ0JlMWUrSlo0djROWWN4NzRIcXN3NDJnVGNEcnIrOWlLbzFwUEdSQkph?=
 =?utf-8?B?cmZoRDUwUTdFMWFhaS9PeENsRmc0ejdHWVFQRHZmOGY1UCtNckNJN2I3RGhk?=
 =?utf-8?B?dHpaU011NVJNVy9KVjZWdm9SQnpEdUNsUkFLc3JXRUNuZmN0UE43Q3lQVEpo?=
 =?utf-8?B?OXB2cEVPZzVkZGF4S0Y1Q0ZGOTBnSjBFRDUzNTBjZEg0L3Z4M1BzM1BrY0lX?=
 =?utf-8?B?OWRiSG5oMklWUC80b2R2eHBQdDBjMzJEZ1liTVJHVGR2aHZzSGhHenRlWUhZ?=
 =?utf-8?B?ZFZhUkl4ODdSeUdqV0hEb2F2bHorcWNTTld3d1MvZm9ERll3UllLMWFuY1Zl?=
 =?utf-8?B?SHFIZ3NTTlRFSXp1b2tyOWZCT0piVFptTlBEQmpCZ1RFcHFFQ0NjVDhlTU5n?=
 =?utf-8?B?TGc3UW84K1oySnZCcWN2SVliQ3RZMFVuMTRTVXFVL2JEa00vNi9RRlBCd2xk?=
 =?utf-8?Q?UVuetBu18jct7TSc=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <FCD36DB339D7B949AA0ADEC034273387@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 851ecf5b-1462-4dc5-57b2-08d9bc0c19fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Dec 2021 18:37:20.9401
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bRGKZ58BkR3JdIw3vKIJCnD3KHd68cRHJfX7jm5Djyl2oyVr4GxECUN5wlIOt4KHaR7l0MFvlzufoJJ5m4XQ2n/YByCrhMU0fACPAmoB9kZUZCV2D8Mk1phcID7Cae65
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4145
X-Proofpoint-GUID: ZKGpcZ39YNEtnsl4oRwNi764N5GwKplN
X-Proofpoint-ORIG-GUID: ZKGpcZ39YNEtnsl4oRwNi764N5GwKplN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-10_07,2021-12-10_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0
 lowpriorityscore=0 bulkscore=0 clxscore=1015 mlxlogscore=914
 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112100103

SGksIEp1bGllbiENCg0KT24gMTAuMTIuMjEgMTk6NTIsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAwOS8xMi8yMDIxIDA3OjI5LCBPbGVrc2FuZHIgQW5kcnVz
aGNoZW5rbyB3cm90ZToNCj4+ICt1bnNpZ25lZCBpbnQgZG9tYWluX3ZwY2lfZ2V0X251bV9tbWlv
X2hhbmRsZXJzKHN0cnVjdCBkb21haW4gKmQpDQo+PiArew0KPj4gK8KgwqDCoCBpZiAoICFoYXNf
dnBjaShkKSApDQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIDA7DQo+PiArDQo+PiArwqDCoMKg
IGlmICggaXNfaGFyZHdhcmVfZG9tYWluKGQpICkNCj4+ICvCoMKgwqAgew0KPj4gK8KgwqDCoMKg
wqDCoMKgIGludCByZXQgPSBwY2lfaG9zdF9pdGVyYXRlX2JyaWRnZXNfYW5kX2NvdW50KGQsIHZw
Y2lfZ2V0X251bV9oYW5kbGVyc19jYik7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJu
IHJldCA8IDAgPyAwIDogcmV0Ow0KPg0KPiBTb3JyeSBJIG9ubHkgc3BvdHRlZCB0aGlzIG5vdy4g
QUZBSUNULCByZXQgaXMgbm90IG1lYW50IHRvIHJldHVybiByZXQgPCAwIGluIHRoaXMgY2FzZS4g
QnV0IGlmIGl0IHdlcmUgdGhlbiBJIHRoaW5rIGl0IHdvdWxkIGJlIHdyb25nIHRvIGNvbnRpbnVl
IGFzIG5vdGhpbmcgaGFwcGVuZWQgYmVjYXVzZSB0aGUgY29kZSB3aWxsIGxpa2VseSBmYWxsIG92
ZXIvY3Jhc2ggd2hlbiByZWdpc3RlcmluZyB0aGUgSS9PIGhhbmRsZXJzLg0KPg0KPiBJIHdvdWxk
IGRvY3VtZW50IHRoaXMgb2RkaXR5IHdpdGgNCj4NCj4gaWYgKCByZXQgPCAwICkNCj4gew0KPiDC
oMKgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KPiDCoMKgIHJldHVybiAwOw0KPiB9DQo+DQo+IEkg
Y2FuIGRvIHRoZSBjaGFuZ2Ugb24gY29tbWl0IGlmIHRoZSBvdGhlcnMgYXJlIGhhcHB5IHdpdGgg
aXQuDQpZZXMsIHBsZWFzZSwgZG8gbWUgYSBmYXZvcg0KPg0KPiBDaGVlcnMsDQo+DQpUaGFuayB5
b3UsDQpPbGVrc2FuZHI=


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:52:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:52:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244249.422435 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl03-00070T-BS; Fri, 10 Dec 2021 18:52:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244249.422435; Fri, 10 Dec 2021 18:52:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl03-00070M-8O; Fri, 10 Dec 2021 18:52:07 +0000
Received: by outflank-mailman (input) for mailman id 244249;
 Fri, 10 Dec 2021 18:52:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvl02-00070B-2q
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:52:06 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4482967b-59ea-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:52:05 +0100 (CET)
Received: by mail-lf1-x12e.google.com with SMTP id c32so19746755lfv.4
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:52:04 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id c21sm387216lfv.29.2021.12.10.10.52.02
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 10:52:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4482967b-59ea-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=j1hvlB2w2BrWNScbCJyLwX4oBGKG9hr6NJqtvFkNM/U=;
        b=DpLCPmMgrOty3y0HrpqopSxxp/qGs/dwG/CgN0apuyA6on28PorJtUybksa6iWzXUQ
         1nC+svp1ZReaFc8Ho69TZxII0UpyuP8U7xwSjZaJzyMIRrgh64VdMWwWLpT7FD5pRO3K
         REVQTxyYOO3tzHZOXPhjO1pz+wC6sFrKKUXdbaxaG08xMkm/2y6DNn/B8j1qrJKM7+bp
         P06T1NhQFOSTeILIcDdZiYIbm1FILYdO04vFRszXD6zy1FhLrwMPIaNrfLI1p4FempaK
         JIbIyvDEnU7xy4tOpOMAsYn+ngt9JZU69+QjylTYb0y426O41rF96XAtvzhN80gJmNuF
         j5Ug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=j1hvlB2w2BrWNScbCJyLwX4oBGKG9hr6NJqtvFkNM/U=;
        b=Sl/nIy8qrVyqJTgO80k04zRpoaVtH27/WjPUfTnAfs2u5MD8Mx5CcQpvPTEmXMEUxg
         p18JAlDZDX3bGra596hSurZUkhJWv564ygjVVHuPIDL1+tCB+E15vyNblEnSOGCbWXtg
         WbQtEl4m9FuowOWqwK/k7IrHawvwo8BR2FCn/lxFvziqiH0RSA6+Oe5EuDM28/WQfemp
         Wlh5g1Yvw0QhJPupKifHwhq1CHpcAwsSQaBRHXKXpk4NzrVZmbKSBeAQsfsPQymE++lp
         VVi+X5yNiUgh8AjJqEHrkv4iNafzz3/dydMDm6ZxSqNpmKH1O4RB1aOECTAa8pOJva9h
         RxpA==
X-Gm-Message-State: AOAM533lw64oXtafa/n1Vq13YW/010781af8rs2rEWWp82CRqI2OYbP9
	Jg9fSAV5qFiDGLLMlQtJ3hE=
X-Google-Smtp-Source: ABdhPJwwyZAuw0wQQ6Dju/0DgEoENSIDq2aqqR4iP7Vldq5bfh8DtMEIrZOS6poEr19ZPeaYgjpDkg==
X-Received: by 2002:ac2:58d9:: with SMTP id u25mr14351127lfo.514.1639162324540;
        Fri, 10 Dec 2021 10:52:04 -0800 (PST)
Subject: Re: [PATCH v4 03/25] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-4-digetx@gmail.com>
 <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <e6ff1cea-a168-1cb0-25c5-fb16c681cf4a@gmail.com>
Date: Fri, 10 Dec 2021 21:52:01 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:19, Rafael J. Wysocki пишет:
...
>> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
>> +               struct notifier_block *n)
>> +{
>> +       unsigned long flags;
>> +       bool ret;
>> +
>> +       spin_lock_irqsave(&nh->lock, flags);
>> +       ret = notifier_has_unique_priority(&nh->head, n);
>> +       spin_unlock_irqrestore(&nh->lock, flags);
> 
> This only works if the caller can prevent new entries from being added
> to the list at this point or if the caller knows that they cannot be
> added for some reason, but the kerneldoc doesn't mention this
> limitation.

I'll update the comment.

..
>> +bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
>> +               struct notifier_block *n)
>> +{
>> +       bool ret;
>> +
>> +       /*
>> +        * This code gets used during boot-up, when task switching is
>> +        * not yet working and interrupts must remain disabled. At such
>> +        * times we must not call down_read().
>> +        */
>> +       if (system_state != SYSTEM_BOOTING)
> 
> No, please don't do this, it makes the whole thing error-prone.

What should I do then?

>> +               down_read(&nh->rwsem);
>> +
>> +       ret = notifier_has_unique_priority(&nh->head, n);
>> +
>> +       if (system_state != SYSTEM_BOOTING)
>> +               up_read(&nh->rwsem);
> 
> And still what if a new entry with a non-unique priority is added to
> the chain at this point?

If entry with a non-unique priority is added after the check, then
obviously it won't be detected. I don't understand the question. These
down/up_read() are the locks that prevent the race, if that's the question.



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:54:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:54:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244254.422445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl2E-0007kc-OA; Fri, 10 Dec 2021 18:54:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244254.422445; Fri, 10 Dec 2021 18:54:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl2E-0007kT-L9; Fri, 10 Dec 2021 18:54:22 +0000
Received: by outflank-mailman (input) for mailman id 244254;
 Fri, 10 Dec 2021 18:54:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvl2D-0007kE-7Q
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:54:21 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95395280-59ea-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 19:54:20 +0100 (CET)
Received: by mail-lf1-x129.google.com with SMTP id l22so19676368lfg.7
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:54:20 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id v15sm390403ljj.5.2021.12.10.10.54.17
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 10:54:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95395280-59ea-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=IKf1m11e2CmLOphgB5tXRwG67Tf75LBrlnq5Vg7yJZw=;
        b=IxhbpvG2CFXB3xmkjVMdWRMntYmHOq8xg7eP7zr/AbSS5vu1B9sdxo5o91nGOD2995
         QQ3KG6tw48EY7IhOrAyb30j6v2PDl8KJF+jKSnPayvNkG1XmqZAU+fLfW7OnlwsZZOnn
         0A9elkL050dIg2mh2nAMxrCkv1StUF1LjCWn+NlhosKjCmIUCMa0MKcmxWQ+/W+IgKI6
         i8CNkkus5bglRUlOxac8XP3LVuSzA40MUvRiA2U0B7IAsHpJ1AsKj9N6snoJl+u70szG
         pZzPqoOnQIc/elfvbeQCxFa9JUiQLy0NMI8wwjD0fM288MJ0ySJSpfHIgwDyPyb7i3mv
         C2Og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=IKf1m11e2CmLOphgB5tXRwG67Tf75LBrlnq5Vg7yJZw=;
        b=fzcYg7Lna60xSy4StUxMNsFpCY9sy8bhlTUC7iBGxrEGj+rB27EU2ZIdP07NsA9k9v
         Xwq7TqW+d4884KSeRFCeuu+PjVTrq6fwSsys1Oaau39J8xcpxUjvhZ0TmQxhITRZ2MxR
         06GP+bSAi0FyOUMa4f2N+ziCu2MNMWZvubCIE7NoSxFpNBLxweDI1D8MSkt3ty6Yapu4
         cMgX8kHOuNYla9F2JcE1oxMthiTS/DlcC6SN6pDUbOS6TBv+YHCtmzNrv4VTmeyRQ0nn
         kW76Cxb8aJoLmF++xCOFtcqQGVuYRon+8wMGFRPgZxmt/b/oMEezjTatJejwWzPxQftE
         PH+w==
X-Gm-Message-State: AOAM530UisyksIoNym8q2k2BFLqXPKjELmsCpdYvedFmDd/xyhm8b73j
	4WmHFlkguUPpKiQaDCse67wNB4rYAaw=
X-Google-Smtp-Source: ABdhPJyNtPZVq+j4jRpVe2vNWn4eVPA/mLyRKU7MjcAV9J6qXLR8NEClMh21SuEPG0vCBnH7Acz/0w==
X-Received: by 2002:ac2:4c4d:: with SMTP id o13mr13668768lfk.196.1639162460068;
        Fri, 10 Dec 2021 10:54:20 -0800 (PST)
Subject: Re: [PATCH v4 06/25] reboot: Warn if unregister_restart_handler()
 fails
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-7-digetx@gmail.com>
 <CAJZ5v0ii7tGRDbxw+5GqdyONXvRPznXUqBZd03+pdoAd+pH=JQ@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <c518ce36-09d2-16a3-cec2-6bab8260e3cf@gmail.com>
Date: Fri, 10 Dec 2021 21:54:17 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0ii7tGRDbxw+5GqdyONXvRPznXUqBZd03+pdoAd+pH=JQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:32, Rafael J. Wysocki пишет:
> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> Emit warning if unregister_restart_handler() fails since it never should
>> fail. This will ease further API development by catching mistakes early.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  kernel/reboot.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>> index e6659ae329f1..f0e7b9c13f6b 100644
>> --- a/kernel/reboot.c
>> +++ b/kernel/reboot.c
>> @@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler);
>>   */
>>  int unregister_restart_handler(struct notifier_block *nb)
>>  {
>> -       return atomic_notifier_chain_unregister(&restart_handler_list, nb);
>> +       return WARN_ON(atomic_notifier_chain_unregister(&restart_handler_list, nb));
> 
> The only reason why it can fail is if the object pointed to by nb is
> not in the chain.

I had exactly this case where object wasn't in the chain due to a bug
and this warning was very helpful.

>  Why WARN() about this?  And what about systems with
> panic_on_warn set?

That warning condition will never happen normally, only when something
is seriously wrong.

Those systems with panic_on_warn will get what was they asked for.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:56:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:56:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244259.422456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl4Q-0008S5-4a; Fri, 10 Dec 2021 18:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244259.422456; Fri, 10 Dec 2021 18:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl4Q-0008Ry-1Y; Fri, 10 Dec 2021 18:56:38 +0000
Received: by outflank-mailman (input) for mailman id 244259;
 Fri, 10 Dec 2021 18:56:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvl4O-0008Rk-VV
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 18:56:37 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e532cd08-59ea-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 19:56:34 +0100 (CET)
Received: by mail-lf1-x12d.google.com with SMTP id m6so7903336lfu.1
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 10:56:34 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id b10sm416126lfj.230.2021.12.10.10.56.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 10:56:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e532cd08-59ea-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=OLTFQmX2Kf2e3cZmLG4jxsS1bq2aSoDXpxl5QnKq9FU=;
        b=lRJVrFA11Fu94g9aC4quIzKTIJBQHb56jvC3UHQRYxQnYMhhiqHXe+HNIaU6izZboH
         h0BDFCIwI4bVAz64DQVVsH0MSKsIo5r3rhYcpSgEs+F8SRLOvGUk6MezYqtprOuHSHY+
         xZjhnDgdSP0x9ihrSMtshGYvbNVvxVMeCabfWJNzXp5+bcL+U+5yCBZgtjUoQy5c5Srk
         XvThuXHF65j6/Qpyivd03hsOvMnXYmDchKWNvnb9km4xj+cql2CnI3JZSdhbiWgBDsX+
         pJV/q1mj1vSBgnFw5Nf3SQ1PcuWrLHkWB0ABMsx7hJcTqhLbY3gqIMN0WZdDvJ/sUnhK
         zo7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=OLTFQmX2Kf2e3cZmLG4jxsS1bq2aSoDXpxl5QnKq9FU=;
        b=ymtNKl+Upu5zptmn5fcB8aIcTubYbEOnd4G1BR1cRNTa9UlL8ZHjjqjJwgD+/jP7KN
         Nvukcn6S3vDpsV7TSNJxQaBZG8fYbcFr/n6PZ9pxXjdpQ/9svTWIbKXHNCuoSYf6zn1O
         GMapBz+X5djIfqQRDv4Qunsf/NGG2fCLTaqaZDQkq8QaQk22A/KWWvuexJiy9dZ4Oavu
         ZM3VAydKnGibeZWyMD7hoPLkEAQWqwQ7h2J3fuLP+nlM0XIxp2PJb/XrzUnbRTKyOwIm
         TMEL2k50wmaTHELRfZUBrzs2FfazYYqrfBoFYhN1ertzGGemGAnYVoOI7XaQ3j3F7N7u
         QEtA==
X-Gm-Message-State: AOAM531tb/vcGKG9AtgGCB4bBoJAsmCQsNdlHOxGSCrUbFFian02sia6
	BTNUCBrcDUAHGB5vvI3NpcM=
X-Google-Smtp-Source: ABdhPJx4BKlEbZ+Eghk+XJYmXdOJaHtYRLuIKsc/RB19AF8hnZocVzO0VkIjSpmfvEqny0BWm7yDgw==
X-Received: by 2002:ac2:5101:: with SMTP id q1mr8849810lfb.319.1639162594092;
        Fri, 10 Dec 2021 10:56:34 -0800 (PST)
Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function
 prototypes
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-8-digetx@gmail.com>
 <CAJZ5v0i=zgubEtF5-Wnaqa5FMnfVUdSnEmD11-LAuYCH8ZCwrA@mail.gmail.com>
 <acf8289e-6ab8-6eda-ec06-e9044ddd9a92@gmail.com>
 <CAJZ5v0gvuteY4EtXWTKmh4-Wt-Z_dPcqfDLwc-ja1uovbV3rpw@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <bafcaa92-5bd1-874c-c5ff-a72ebc98945d@gmail.com>
Date: Fri, 10 Dec 2021 21:56:31 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gvuteY4EtXWTKmh4-Wt-Z_dPcqfDLwc-ja1uovbV3rpw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:35, Rafael J. Wysocki пишет:
> On Fri, Dec 10, 2021 at 7:16 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 10.12.2021 21:09, Rafael J. Wysocki пишет:
>>> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>>>
>>>> There is no need to annotate function prototypes with 'extern', it makes
>>>> code less readable. Remove unnecessary annotations from <reboot.h>.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>>
>>> I'm not sure that this is really useful.
>>>
>>> Personally, I tend to respect the existing conventions like this.
>>>
>>> Surely, this change is not required for the rest of the series to work.
>>
>> Problem that such things start to spread all over the kernel with a
>> copy-paste approach if there is nobody to clean up the code.
>>
>> This is not a common convention and sometimes it's getting corrected [1].
>>
>> [1] https://git.kernel.org/linus/6d7434931
> 
> In separate patches outside of series adding new features, if one is
> so inclined.
> 

Alright, I'll drop this patch then because it can't be done in parallel
without creating the merge conflict. I'll try not to forget to come back
to this later on.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 18:56:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 18:56:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244260.422468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl4k-0000aC-D6; Fri, 10 Dec 2021 18:56:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244260.422468; Fri, 10 Dec 2021 18:56:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvl4k-0000Zl-9Q; Fri, 10 Dec 2021 18:56:58 +0000
Received: by outflank-mailman (input) for mailman id 244260;
 Fri, 10 Dec 2021 18:56:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvl4j-0000V2-9V; Fri, 10 Dec 2021 18:56:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvl4j-0004JY-4B; Fri, 10 Dec 2021 18:56:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvl4i-0000hJ-Nr; Fri, 10 Dec 2021 18:56:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvl4i-0005RA-NM; Fri, 10 Dec 2021 18:56:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=vBKGBf7y2vLOhdlF6kY7qYYKA7ZkGTDTgexG0Jg1SjI=; b=EfDHHL4odiYzJwZMFDLW5ewqOO
	iVQ+U9zmQeB0Vdx8W+cGL/e5B2Vi7xAo7oCrb1S7O3Fet9C3FC+MJfIHvVg11t8r9qUCdTbNMXs/Y
	Y/caDxiyb1jjY4NyiwaBICPtNzZ+kkYwOqSeq3NZGRd1lbbwfyJNtgWxu3Jra/qH+FSg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167349-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167349: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 18:56:56 +0000

flight 167349 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167349/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   36 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:04:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:04:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244270.422483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlC5-0002fO-8h; Fri, 10 Dec 2021 19:04:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244270.422483; Fri, 10 Dec 2021 19:04:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlC5-0002fH-3k; Fri, 10 Dec 2021 19:04:33 +0000
Received: by outflank-mailman (input) for mailman id 244270;
 Fri, 10 Dec 2021 19:04:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvlC4-0002fB-1h
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:04:32 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 011ae5e2-59ec-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:04:30 +0100 (CET)
Received: by mail-lf1-x129.google.com with SMTP id t26so19744144lfk.9
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:04:30 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id k27sm385556ljc.129.2021.12.10.11.04.27
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:04:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 011ae5e2-59ec-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=rvbAWOjnQ4iiK2qTm1VE6lQGOrcjLKyz5OxaYJHSlms=;
        b=TjeoyxCasR5FMVdl/A0tp1mA72HfZpG7IA3P7NymDxwSTTW3+ca77Hp0RW3fNn90V6
         BsHjIyUl7Vlp+L39rylawnkVapGjnUQqVeWKvetFiA7uvJFxyv0GjUpcVXKt0X+55JJr
         xqXdSvj9BdLL7KX3hwRLKx+qpMEtqmR2FUek4bTb6sXBna+eG0YWGMxM64DOjx5RNWe4
         HoiJuPojsDMo1meIr/+QThmv79vJf2KZerbGrOUNNaqfzynbYTAS2muusrYdRhnsIt5A
         B24OARH3dPFHv5rk46GLF+MM2vVZfTdlA9nyGZ9hBzpvwzg8kPFwKLRgebHs+PEO+1Iq
         vobA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=rvbAWOjnQ4iiK2qTm1VE6lQGOrcjLKyz5OxaYJHSlms=;
        b=1viUg1ZqpYcCx70WJmE0OT8+OmPuix22wv7Ch5YKhyM7TNm5CmhyrCHMZzLdUjApJ9
         ebU1Y8q2isAlMqnr6oiCPBmMh3FPYBaAw04d5Xp/OYc3sFHerMpX8DbB0VsYnY6zDmAT
         85dZN3Lr5iNt2QXCHvUF442ZEGxew4pIdUSpfygVIEHnkgwUlIFpCFDHS49+fIQnxN9b
         q2Z71kSJ6uXSrZPXKe2fb3/7wOFNAEWuZFp+U5z7O9dcVfR6DGQAQ7yaEFDw7MzW37Xz
         FaSJC7zMSEb/1peMAaidc4NGJ0cEgZOyUpqiTCY7lIMUBljpOluutJCHXOBohz3NtHSV
         I3pA==
X-Gm-Message-State: AOAM533v1LMOK8NYES/gMQeoBgtfFZJzqeokHH/bSg1AR7Mm4t9P4OaS
	/Vy3fa7DQ9Tc/oiR0ypZtXU=
X-Google-Smtp-Source: ABdhPJyGg6V6axU9mPpKq+4o9ssjbFc0zNzIldal4eICWlLYfWsm94H3hqPTZ3hkXuJwkEExqxjrPg==
X-Received: by 2002:a05:6512:3f84:: with SMTP id x4mr14257818lfa.346.1639163070363;
        Fri, 10 Dec 2021 11:04:30 -0800 (PST)
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated
 priority
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-6-digetx@gmail.com> <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl>
 <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl>
 <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
Date: Fri, 10 Dec 2021 22:04:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 21:27, Rafael J. Wysocki пишет:
> On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 29.11.2021 03:26, Michał Mirosław пишет:
>>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote:
>>>> 28.11.2021 03:28, Michał Mirosław пишет:
>>>>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote:
>>>>>> Add sanity check which ensures that there are no two restart handlers
>>>>>> registered with the same priority. Normally it's a direct sign of a
>>>>>> problem if two handlers use the same priority.
>>>>>
>>>>> The patch doesn't ensure the property that there are no duplicated-priority
>>>>> entries on the chain.
>>>>
>>>> It's not the exact point of this patch.
>>>>
>>>>> I'd rather see a atomic_notifier_chain_register_unique() that returns
>>>>> -EBUSY or something istead of adding an entry with duplicate priority.
>>>>> That way it would need only one list traversal unless you want to
>>>>> register the duplicate anyway (then you would call the older
>>>>> atomic_notifier_chain_register() after reporting the error).
>>>>
>>>> The point of this patch is to warn developers about the problem that
>>>> needs to be fixed. We already have such troubling drivers in mainline.
>>>>
>>>> It's not critical to register different handlers with a duplicated
>>>> priorities, but such cases really need to be corrected. We shouldn't
>>>> break users' machines during transition to the new API, meanwhile
>>>> developers should take action of fixing theirs drivers.
>>>>
>>>>> (Or you could return > 0 when a duplicate is registered in
>>>>> atomic_notifier_chain_register() if the callers are prepared
>>>>> for that. I don't really like this way, though.)
>>>>
>>>> I had a similar thought at some point before and decided that I'm not in
>>>> favor of this approach. It's nicer to have a dedicated function that
>>>> verifies the uniqueness, IMO.
>>>
>>> I don't like the part that it traverses the list second time to check
>>> the uniqueness. But actually you could avoid that if
>>> notifier_chain_register() would always add equal-priority entries in
>>> reverse order:
>>>
>>>  static int notifier_chain_register(struct notifier_block **nl,
>>>               struct notifier_block *n)
>>>  {
>>>       while ((*nl) != NULL) {
>>>               if (unlikely((*nl) == n)) {
>>>                       WARN(1, "double register detected");
>>>                       return 0;
>>>               }
>>> -             if (n->priority > (*nl)->priority)
>>> +             if (n->priority >= (*nl)->priority)
>>>                       break;
>>>               nl = &((*nl)->next);
>>>       }
>>>       n->next = *nl;
>>>       rcu_assign_pointer(*nl, n);
>>>       return 0;
>>>  }
>>>
>>> Then the check for uniqueness after adding would be:
>>>
>>>  WARN(nb->next && nb->priority == nb->next->priority);
>>
>> We can't just change the registration order because invocation order of
>> the call chain depends on the registration order
> 
> It doesn't if unique priorities are required and isn't that what you want?
> 
>> and some of current
>> users may rely on that order. I'm pretty sure that changing the order
>> will have unfortunate consequences.
> 
> Well, the WARN() doesn't help much then.
> 
> Either you can make all of the users register with unique priorities,
> and then you can make the registration reject non-unique ones, or you
> cannot assume them to be unique.

There is no strong requirement for priorities to be unique, the reboot.c
code will work properly.

The potential problem is on the user's side and the warning is intended
to aid the user.

We can make it a strong requirement, but only after converting and
testing all kernel drivers. I'll consider to add patches for that.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:05:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:05:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244275.422493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlDH-0003I5-KL; Fri, 10 Dec 2021 19:05:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244275.422493; Fri, 10 Dec 2021 19:05:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlDH-0003Hy-HE; Fri, 10 Dec 2021 19:05:47 +0000
Received: by outflank-mailman (input) for mailman id 244275;
 Fri, 10 Dec 2021 19:05:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvlDG-0003Hp-7Y
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:05:46 +0000
Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com
 [209.85.167.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d0a3226-59ec-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:05:45 +0100 (CET)
Received: by mail-oi1-f172.google.com with SMTP id s139so14412522oie.13
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:05:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d0a3226-59ec-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=c+Gg3IcBrVO+p3DERDiz2wIK2rZh3JBEUqlmxz2Wt9w=;
        b=jZ6gimX04kWQogSZbFYT/iQs4r1jnOcDdPoME78rdegXAlfy4dcxqjSFXJnUn5B+81
         a9wQqrkPmVQaEOOZSe6JmTnDhq2c5IJAOibE2+qrfWViHyESe2tyOtjJObkGafgEU6bj
         QbjUkeJ2rMuwxp8FUuX1lmkAkM0Nffd3Oh996uiugB6E1TiIadhQ3IEVucfyTtyF6RWo
         1ifis9q+p0VtElgmGoih6QE2OqQMdRQzGokQ4yXGOeKan27qrOClfeNrKMzyqZbqMGMo
         wsprkP2Iu3m64fET3j6JHS+V6Q0fKW1kEvfI5vMl/B67382FWdQz91cP/zgZMKavJ2sh
         C2bQ==
X-Gm-Message-State: AOAM533Z+M0fck8J7k4467+9CDGhez4IRdWza1+BossI5F0Xjc7oYbKN
	ZtSgzEROElbWYkjthnaNJo01DobMbG+EFC0+IMI=
X-Google-Smtp-Source: ABdhPJyFnxvuCdo/SAuZsTrbeFY0ttrM6VIAZMHiyNGyFieUXOlcjM/63kmCFhhj1nwi5THbS12OxkRKZ5ROskKDe+g=
X-Received: by 2002:aca:eb0b:: with SMTP id j11mr14151206oih.51.1639163143930;
 Fri, 10 Dec 2021 11:05:43 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-4-digetx@gmail.com>
 <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com> <e6ff1cea-a168-1cb0-25c5-fb16c681cf4a@gmail.com>
In-Reply-To: <e6ff1cea-a168-1cb0-25c5-fb16c681cf4a@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 20:05:32 +0100
Message-ID: <CAJZ5v0gwnY07vg71_NB8RDWyv84FtMsmx7UTDd8TkUd7vFzc6A@mail.gmail.com>
Subject: Re: [PATCH v4 03/25] notifier: Add atomic/blocking_notifier_has_unique_priority()
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 7:52 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 10.12.2021 21:19, Rafael J. Wysocki =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> ...
> >> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head =
*nh,
> >> +               struct notifier_block *n)
> >> +{
> >> +       unsigned long flags;
> >> +       bool ret;
> >> +
> >> +       spin_lock_irqsave(&nh->lock, flags);
> >> +       ret =3D notifier_has_unique_priority(&nh->head, n);
> >> +       spin_unlock_irqrestore(&nh->lock, flags);
> >
> > This only works if the caller can prevent new entries from being added
> > to the list at this point or if the caller knows that they cannot be
> > added for some reason, but the kerneldoc doesn't mention this
> > limitation.
>
> I'll update the comment.
>
> ..
> >> +bool blocking_notifier_has_unique_priority(struct blocking_notifier_h=
ead *nh,
> >> +               struct notifier_block *n)
> >> +{
> >> +       bool ret;
> >> +
> >> +       /*
> >> +        * This code gets used during boot-up, when task switching is
> >> +        * not yet working and interrupts must remain disabled. At suc=
h
> >> +        * times we must not call down_read().
> >> +        */
> >> +       if (system_state !=3D SYSTEM_BOOTING)
> >
> > No, please don't do this, it makes the whole thing error-prone.
>
> What should I do then?

First of all, do you know of any users who may want to call this
during early initialization?  If so, then why may they want to do
that?

Depending on the above, I would consider adding a special mechanism for the=
m.

> >> +               down_read(&nh->rwsem);
> >> +
> >> +       ret =3D notifier_has_unique_priority(&nh->head, n);
> >> +
> >> +       if (system_state !=3D SYSTEM_BOOTING)
> >> +               up_read(&nh->rwsem);
> >
> > And still what if a new entry with a non-unique priority is added to
> > the chain at this point?
>
> If entry with a non-unique priority is added after the check, then
> obviously it won't be detected.

Why isn't this a problem?

> I don't understand the question. These
> down/up_read() are the locks that prevent the race, if that's the questio=
n.

Not really, they only prevent the race from occurring while
notifier_has_unique_priority() is running.

If anyone depends on this check for correctness, they need to lock the
rwsem, do the check, do the thing depending on the check while holding
the rwsem and then release the rwsem.  Otherwise it is racy.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:08:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244282.422504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlG0-0004WL-48; Fri, 10 Dec 2021 19:08:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244282.422504; Fri, 10 Dec 2021 19:08:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlFz-0004WE-Vy; Fri, 10 Dec 2021 19:08:35 +0000
Received: by outflank-mailman (input) for mailman id 244282;
 Fri, 10 Dec 2021 19:08:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvlFy-0004W8-Rj
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:08:34 +0000
Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com
 [209.85.210.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 919aea1d-59ec-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 20:08:33 +0100 (CET)
Received: by mail-ot1-f45.google.com with SMTP id
 w6-20020a9d77c6000000b0055e804fa524so10591470otl.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:08:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 919aea1d-59ec-11ec-a74f-db008197e53d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=eV+MT/c+cWty36yyN1k88RcKH0yc2be+fuKXycnWnqs=;
        b=COw1oINMypu8v3XS1XuZDe7DsUOUOOs2cpuGLXnG4N53l2ajXBpuKYiGEVZSqZlolf
         6vetkS0MwZQT2TaKh89aJM9qnSPqNsPnWVpFI0lB5W/6ZWLG/0g3JB9uCrWeweDwWGr7
         VVYuppQtnmugAz9uV6WCyZG39NY6mz0a6feP7byxYUoqRxV7ygHDlSvmA54nqVMzCFsr
         PMjYOYRmKosQpd3tIUCiBqCuSgh0lkyXmfWblB2KB7F4mtFDDLNIZBgrJN2nCiVuGR9x
         D20aE9wKdtLwMNciIra7IxGyQ0YdRqjzvfwq2LpQ5iJkjaQ2taKUqp4sK6BZqwfsPkyX
         UhGg==
X-Gm-Message-State: AOAM530F612k4lu1us88XTe1SN2c1/eqJGb/+5Zs9neWE4bLYi0bh3Js
	ZwUEefez4UCPLZQ9xhpl2kURwS73dYUVHkKHuos=
X-Google-Smtp-Source: ABdhPJz3WnXJDp9MR1neaOhkZU7y1rSVa1ldfWi3aUs9lzZU+HiO7VfKdE35iqJJyDqw6NIr5Fwr8foXDpr2Xp5/alg=
X-Received: by 2002:a05:6830:1e57:: with SMTP id e23mr12553404otj.16.1639163312676;
 Fri, 10 Dec 2021 11:08:32 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-7-digetx@gmail.com>
 <CAJZ5v0ii7tGRDbxw+5GqdyONXvRPznXUqBZd03+pdoAd+pH=JQ@mail.gmail.com> <c518ce36-09d2-16a3-cec2-6bab8260e3cf@gmail.com>
In-Reply-To: <c518ce36-09d2-16a3-cec2-6bab8260e3cf@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 20:08:21 +0100
Message-ID: <CAJZ5v0iP_VnNW3ChmdvRFg1gvwvkDGmqtGnf1oVwQxXY303RkQ@mail.gmail.com>
Subject: Re: [PATCH v4 06/25] reboot: Warn if unregister_restart_handler() fails
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, 
	Jonathan Hunter <jonathanh@nvidia.com>, Russell King <linux@armlinux.org.uk>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 7:54 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 10.12.2021 21:32, Rafael J. Wysocki =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrot=
e:
> >>
> >> Emit warning if unregister_restart_handler() fails since it never shou=
ld
> >> fail. This will ease further API development by catching mistakes earl=
y.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >>  kernel/reboot.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/reboot.c b/kernel/reboot.c
> >> index e6659ae329f1..f0e7b9c13f6b 100644
> >> --- a/kernel/reboot.c
> >> +++ b/kernel/reboot.c
> >> @@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler);
> >>   */
> >>  int unregister_restart_handler(struct notifier_block *nb)
> >>  {
> >> -       return atomic_notifier_chain_unregister(&restart_handler_list,=
 nb);
> >> +       return WARN_ON(atomic_notifier_chain_unregister(&restart_handl=
er_list, nb));
> >
> > The only reason why it can fail is if the object pointed to by nb is
> > not in the chain.
>
> I had exactly this case where object wasn't in the chain due to a bug
> and this warning was very helpful.

During the development.  In production it would be rather annoying.

> >  Why WARN() about this?  And what about systems with
> > panic_on_warn set?
>
> That warning condition will never happen normally, only when something
> is seriously wrong.
>
> Those systems with panic_on_warn will get what was they asked for.

They may not be asking for panicking on bugs in the reboot notifier
code, though.  That's what your change is making them panic on.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:14:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:14:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244287.422514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlM0-0005vm-PF; Fri, 10 Dec 2021 19:14:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244287.422514; Fri, 10 Dec 2021 19:14:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlM0-0005vf-MP; Fri, 10 Dec 2021 19:14:48 +0000
Received: by outflank-mailman (input) for mailman id 244287;
 Fri, 10 Dec 2021 19:14:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2dzg=Q3=gmail.com=rjwysocki@srs-se1.protection.inumbo.net>)
 id 1mvlLz-0005vZ-Qq
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:14:47 +0000
Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com
 [209.85.210.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6fcee56f-59ed-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:14:46 +0100 (CET)
Received: by mail-ot1-f49.google.com with SMTP id
 r10-20020a056830080a00b0055c8fd2cebdso10583099ots.6
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:14:46 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6fcee56f-59ed-11ec-ad7a-b7ef48004f0a
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=StDkoZeh1lHUw1DDm/KpSH6johK86ICDiu5dChogaP8=;
        b=159C5XtpJfJKoILvux8vSHcNej1ks74xE85weoPIh2fz2QxG/Hw9yK81rpCVRPnNGY
         DAh9D7z9J34WzGMvlysZUIE5H26qZA3B8dWbDgYo+0U9CvTQgXXOX34crSsTo244SX5i
         x1O35UM2V1ZwU2aKuikoPsMXcV1OBAW6+ejdeYGjZryFy9+vSFV7xM/COkJqEF0NuU9S
         4hPkvLw1YRVxIahbVsu8xBAW2ejB/OdRUQZOWB+ABQtVuywcmThy6op3YWEGKJUWYGEi
         0zFgOj0+zpAuqBqGpCVeNKj0Ou9oY72rZUbxKHjp29/W67EAWKRgz8CXaF2oZBekpiPm
         4eRw==
X-Gm-Message-State: AOAM532Zm2hA16epB2bgaNup+WttDP3Mp8Prs3BUWC4SfLVwDOHG5t0l
	3AVk5WFpeI1oo79FsT37I/ZjUJ270uuHO7KHIlc=
X-Google-Smtp-Source: ABdhPJwI6PbHk846M9cWi0KvS3EvMhQYMsgwdseNjfmW3x73dR5HGBiuvU5f7TYKM/YR00y87Pqhei6Yd6KAs40K6Eo=
X-Received: by 2002:a05:6830:1e57:: with SMTP id e23mr12575530otj.16.1639163685443;
 Fri, 10 Dec 2021 11:14:45 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-6-digetx@gmail.com>
 <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl> <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl> <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com> <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
In-Reply-To: <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 10 Dec 2021 20:14:34 +0100
Message-ID: <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 10.12.2021 21:27, Rafael J. Wysocki =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko <digetx@gmail.com> wro=
te:
> >>
> >> 29.11.2021 03:26, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=B5=
=D1=82:
> >>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote:
> >>>> 28.11.2021 03:28, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=B5=
=D1=82:
> >>>>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote:
> >>>>>> Add sanity check which ensures that there are no two restart handl=
ers
> >>>>>> registered with the same priority. Normally it's a direct sign of =
a
> >>>>>> problem if two handlers use the same priority.
> >>>>>
> >>>>> The patch doesn't ensure the property that there are no duplicated-=
priority
> >>>>> entries on the chain.
> >>>>
> >>>> It's not the exact point of this patch.
> >>>>
> >>>>> I'd rather see a atomic_notifier_chain_register_unique() that retur=
ns
> >>>>> -EBUSY or something istead of adding an entry with duplicate priori=
ty.
> >>>>> That way it would need only one list traversal unless you want to
> >>>>> register the duplicate anyway (then you would call the older
> >>>>> atomic_notifier_chain_register() after reporting the error).
> >>>>
> >>>> The point of this patch is to warn developers about the problem that
> >>>> needs to be fixed. We already have such troubling drivers in mainlin=
e.
> >>>>
> >>>> It's not critical to register different handlers with a duplicated
> >>>> priorities, but such cases really need to be corrected. We shouldn't
> >>>> break users' machines during transition to the new API, meanwhile
> >>>> developers should take action of fixing theirs drivers.
> >>>>
> >>>>> (Or you could return > 0 when a duplicate is registered in
> >>>>> atomic_notifier_chain_register() if the callers are prepared
> >>>>> for that. I don't really like this way, though.)
> >>>>
> >>>> I had a similar thought at some point before and decided that I'm no=
t in
> >>>> favor of this approach. It's nicer to have a dedicated function that
> >>>> verifies the uniqueness, IMO.
> >>>
> >>> I don't like the part that it traverses the list second time to check
> >>> the uniqueness. But actually you could avoid that if
> >>> notifier_chain_register() would always add equal-priority entries in
> >>> reverse order:
> >>>
> >>>  static int notifier_chain_register(struct notifier_block **nl,
> >>>               struct notifier_block *n)
> >>>  {
> >>>       while ((*nl) !=3D NULL) {
> >>>               if (unlikely((*nl) =3D=3D n)) {
> >>>                       WARN(1, "double register detected");
> >>>                       return 0;
> >>>               }
> >>> -             if (n->priority > (*nl)->priority)
> >>> +             if (n->priority >=3D (*nl)->priority)
> >>>                       break;
> >>>               nl =3D &((*nl)->next);
> >>>       }
> >>>       n->next =3D *nl;
> >>>       rcu_assign_pointer(*nl, n);
> >>>       return 0;
> >>>  }
> >>>
> >>> Then the check for uniqueness after adding would be:
> >>>
> >>>  WARN(nb->next && nb->priority =3D=3D nb->next->priority);
> >>
> >> We can't just change the registration order because invocation order o=
f
> >> the call chain depends on the registration order
> >
> > It doesn't if unique priorities are required and isn't that what you wa=
nt?
> >
> >> and some of current
> >> users may rely on that order. I'm pretty sure that changing the order
> >> will have unfortunate consequences.
> >
> > Well, the WARN() doesn't help much then.
> >
> > Either you can make all of the users register with unique priorities,
> > and then you can make the registration reject non-unique ones, or you
> > cannot assume them to be unique.
>
> There is no strong requirement for priorities to be unique, the reboot.c
> code will work properly.

In which case adding the WARN() is not appropriate IMV.

Also I've looked at the existing code and at least in some cases the
order in which the notifiers run doesn't matter.  I'm not sure what
the purpose of this patch is TBH.

> The potential problem is on the user's side and the warning is intended
> to aid the user.

Unless somebody has the panic_on_warn mentioned previously set and
really the user need not understand what the WARN() is about.  IOW,
WARN() helps developers, not users.

> We can make it a strong requirement, but only after converting and
> testing all kernel drivers.

Right.

> I'll consider to add patches for that.

But can you avoid adding more patches to this series?


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:33:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:33:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244296.422526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvleE-0000yN-D2; Fri, 10 Dec 2021 19:33:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244296.422526; Fri, 10 Dec 2021 19:33:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvleE-0000yG-9h; Fri, 10 Dec 2021 19:33:38 +0000
Received: by outflank-mailman (input) for mailman id 244296;
 Fri, 10 Dec 2021 19:33:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvleC-0000y7-Rk
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:33:36 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11107bda-59f0-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:33:35 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id bi37so19884430lfb.5
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:33:35 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id v23sm394184lji.79.2021.12.10.11.33.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:33:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11107bda-59f0-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=f67p7hle6233nGxb6/xc+P0FVeEPFRJiI9iN2B4WT58=;
        b=kS8TNlYiN6vyIeYsSnRv3CIueRF7pdxQ8UZE6mOB14p99gTRdCMFnHOR44Z3ji5MiJ
         D03uWCT5igggIgLk+p2yc39IbVlARk1+JEGaNZDdXQzNupiaX8nvnDwM3tNyc59SP0HR
         COvxv+cjl6P+TY6I1M8f+NUOUD7TJTgjbz/0uJ+yLcxHdNhreTMQklx4JM+7jiYJuUv/
         resLJQRarl+ZtO8U6+PT9CFznfJa6MhK2xrna+jAtgpFDFUXFJ1z/3ZkYUzHdjAlQrRG
         I07USXxffxsEm/0A0PVKkY0duuTB1Y6XKt0r4xjJRFk8H0T/57tNUYmytuaRwqLJ7SMF
         vNYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=f67p7hle6233nGxb6/xc+P0FVeEPFRJiI9iN2B4WT58=;
        b=I865a9U7ZnTzjGODM2JcGKwd82kk6bcJuTAtVxQGCLvDyP2vXmXBzcWLT0vD7fKWMm
         IouqFe25v4k4mRyrOHsTk1hX13sE4PooImr+oo994cr9U9YpW8PxPf179LMiX2Tga6yE
         MnOgYoflHb+iFoPTWWoEpInRZho7SRQio6LqQhmWVvgjumaebwE1FcbFsTELUVo79nPM
         ApMOrodIKDVd4m4bnwupxXsPPGbf256quhqHyNMQUAsKhx/GdJ3jh583alNdpKLEe5R2
         xx+fW0ryTzSUb0fA/DWTehJzwRbMBhfyg8L24K9Jg3ZCpZUDquVn1CRfoRISDekZ7+Tx
         T6KA==
X-Gm-Message-State: AOAM530dbKkXoUMPp/TklmrNHqO52Uvux2ejSlEdhXqD/ZW5y40Ua0KB
	0+fmembDo9chkFkHwtIJOzU=
X-Google-Smtp-Source: ABdhPJw47o96fQpbRseSJ19MnRQSW7xcHQNSX+uqiAcRJr+V49fJkk5gdmPL9j60fMnbKKwiMUD2ZA==
X-Received: by 2002:a05:6512:6e:: with SMTP id i14mr15149045lfo.488.1639164814789;
        Fri, 10 Dec 2021 11:33:34 -0800 (PST)
Subject: Re: [PATCH v4 03/25] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-4-digetx@gmail.com>
 <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com>
 <e6ff1cea-a168-1cb0-25c5-fb16c681cf4a@gmail.com>
 <CAJZ5v0gwnY07vg71_NB8RDWyv84FtMsmx7UTDd8TkUd7vFzc6A@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <fd158245-aa9a-2e48-0145-004f30005a66@gmail.com>
Date: Fri, 10 Dec 2021 22:33:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0gwnY07vg71_NB8RDWyv84FtMsmx7UTDd8TkUd7vFzc6A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:05, Rafael J. Wysocki пишет:
> On Fri, Dec 10, 2021 at 7:52 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 10.12.2021 21:19, Rafael J. Wysocki пишет:
>> ...
>>>> +bool atomic_notifier_has_unique_priority(struct atomic_notifier_head *nh,
>>>> +               struct notifier_block *n)
>>>> +{
>>>> +       unsigned long flags;
>>>> +       bool ret;
>>>> +
>>>> +       spin_lock_irqsave(&nh->lock, flags);
>>>> +       ret = notifier_has_unique_priority(&nh->head, n);
>>>> +       spin_unlock_irqrestore(&nh->lock, flags);
>>>
>>> This only works if the caller can prevent new entries from being added
>>> to the list at this point or if the caller knows that they cannot be
>>> added for some reason, but the kerneldoc doesn't mention this
>>> limitation.
>>
>> I'll update the comment.
>>
>> ..
>>>> +bool blocking_notifier_has_unique_priority(struct blocking_notifier_head *nh,
>>>> +               struct notifier_block *n)
>>>> +{
>>>> +       bool ret;
>>>> +
>>>> +       /*
>>>> +        * This code gets used during boot-up, when task switching is
>>>> +        * not yet working and interrupts must remain disabled. At such
>>>> +        * times we must not call down_read().
>>>> +        */
>>>> +       if (system_state != SYSTEM_BOOTING)
>>>
>>> No, please don't do this, it makes the whole thing error-prone.
>>
>> What should I do then?
> 
> First of all, do you know of any users who may want to call this
> during early initialization?  If so, then why may they want to do
> that?

I'll need to carefully review all those dozens of platform restart
handlers to answer this question.

> Depending on the above, I would consider adding a special mechanism for them.

Please notice that every blocking_notifier_*() function has this
SYSTEM_BOOTING check, it's not my invention. Notifier API needs to be
generic.

>>>> +               down_read(&nh->rwsem);
>>>> +
>>>> +       ret = notifier_has_unique_priority(&nh->head, n);
>>>> +
>>>> +       if (system_state != SYSTEM_BOOTING)
>>>> +               up_read(&nh->rwsem);
>>>
>>> And still what if a new entry with a non-unique priority is added to
>>> the chain at this point?
>>
>> If entry with a non-unique priority is added after the check, then
>> obviously it won't be detected.
> 
> Why isn't this a problem?>> I don't understand the question. These
>> down/up_read() are the locks that prevent the race, if that's the question.
> 
> Not really, they only prevent the race from occurring while
> notifier_has_unique_priority() is running.
> 
> If anyone depends on this check for correctness, they need to lock the
> rwsem, do the check, do the thing depending on the check while holding
> the rwsem and then release the rwsem.  Otherwise it is racy.
> 

It's fine that it's a bit "racy" since in the context of this series. We
always do the check after adding new entry, so it's not a problem.

There are two options:

1. Use blocking_notifier_has_unique_priority() like it's done in this
patchset. Remove it after all drivers are converted to the new API and
add blocking_notifier_chain_register_unique().

2. Add blocking_notifier_chain_register_unique(), but don't let it fail
the registration of non-unique entries until all drivers are converted
to the new API.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:35:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:35:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244301.422537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlfc-0001br-SI; Fri, 10 Dec 2021 19:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244301.422537; Fri, 10 Dec 2021 19:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlfc-0001bk-OG; Fri, 10 Dec 2021 19:35:04 +0000
Received: by outflank-mailman (input) for mailman id 244301;
 Fri, 10 Dec 2021 19:35:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=C28n=Q3=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1mvlfa-0001bc-Uv
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:35:02 +0000
Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com
 [2607:f8b0:4864:20::72c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 440e65e4-59f0-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 20:35:02 +0100 (CET)
Received: by mail-qk1-x72c.google.com with SMTP id 193so8694287qkh.10
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:35:02 -0800 (PST)
Received: from pm2-ws13.praxislan02.com
 (207-172-141-204.s8906.c3-0.slvr-cbr1.lnh-slvr.md.cable.rcncustomer.com.
 [207.172.141.204])
 by smtp.gmail.com with ESMTPSA id t35sm2852504qtc.83.2021.12.10.11.34.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 10 Dec 2021 11:34:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 440e65e4-59f0-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LZvhziiSpOBh0vC8yE04okJeIaA/J/aZR/gPEOPa60s=;
        b=l9mZTiIMsv9n8q8+YgiY4kIREo3bAQxulUzgIHa2t40ufnGDg2z8UJkCmkzaahskq6
         x1Vnjz2feT/YzNwV9GARtqjqyRrrQqN2Ozw6oVfFOg/3NqLSqiRxw/UQBiW+2sef2l2b
         yeBLzW4BTjZ8uehD2+U+q8Rmhm4QauLugTuqjaPZ5YZBknnos0BOpUplMXY7tjtN4mZV
         ZXQBDC6Ph2a76b6Sf7VoC2uWr06KqkDmi+VCNxX6nbEAgTYSN7bnlmx6rtggPYLxZszr
         oH3FdUW5kdUCoqkKOAtZaMXog6V8O1+yGo1PFJRpKK4ATGdUKkC74W7l1DnIFVQPgbp1
         TSPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=LZvhziiSpOBh0vC8yE04okJeIaA/J/aZR/gPEOPa60s=;
        b=qBouFW9OpqgXOWhF9reeU1WGPNjF5xaKH6UdanyXTNUn+xKifBkbDAgChVwoL4kbdp
         VXnTmgQi5DkwvyJ7GEbeuucFX+iapCnf878uyxWQb99pfdd3W1CJGMXiEmRSXJEnnz7h
         F9F6JLL2btw33srOla/mD296n0DGyUMRaKPGTmQNtDHWdEJne4CtbCECJndHB14zFAXq
         x0KmN98BSaSPLb8Nia7YZFfXvFMa6xeU8vgb4e8ujd+XRLussqUZLLscjDYlbO8khb+K
         EA71tRpy72hxmh61vGzV7mzfx+q2xBvSO62w4pHMTHZy9wY4BUyim0fkbi92BFyNciqz
         /BKA==
X-Gm-Message-State: AOAM530c9NsDwhsyufZNt6KA/Nqn0SAGxXnBNjxuYS4LuvWoP0v3Gsu+
	TcBL4hC6/om0GQg1KBHubb8=
X-Google-Smtp-Source: ABdhPJyDLIa5qmEdPeXW6KEgPi25RJENEAYf/YSsFN0Jpk5qmuVTclAyzherT+kcfWSQ7KRIsePfjw==
X-Received: by 2002:a05:620a:e0e:: with SMTP id y14mr21849497qkm.760.1639164900642;
        Fri, 10 Dec 2021 11:35:00 -0800 (PST)
From: Jason Andryuk <jandryuk@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jason Andryuk <jandryuk@gmail.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Paul Durrant <paul@xen.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Eduardo Habkost <eduardo@habkost.net>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	xen-devel@lists.xenproject.org (open list:X86 Xen CPUs)
Subject: [PATCH] xen-hvm: Allow disabling buffer_io_timer
Date: Fri, 10 Dec 2021 14:34:34 -0500
Message-Id: <20211210193434.75566-1-jandryuk@gmail.com>
X-Mailer: git-send-email 2.33.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

commit f37f29d31488 "xen: slightly simplify bufioreq handling" hard
coded setting req.count = 1 during initial field setup before the main
loop.  This missed a subtlety that an early exit from the loop when
there are no ioreqs to process, would have req.count == 0 for the return
value.  handle_buffered_io() would then remove state->buffered_io_timer.
Instead handle_buffered_iopage() is basically always returning true and
handle_buffered_io() always re-setting the timer.

Restore the disabling of the timer by introducing a new handled_ioreq
boolean and use as the return value.  The named variable will more
clearly show the intent of the code.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
 hw/i386/xen/xen-hvm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index 482be95415..cf8e500514 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -1087,10 +1087,11 @@ static void handle_ioreq(XenIOState *state, ioreq_t *req)
     }
 }
 
-static int handle_buffered_iopage(XenIOState *state)
+static bool handle_buffered_iopage(XenIOState *state)
 {
     buffered_iopage_t *buf_page = state->buffered_io_page;
     buf_ioreq_t *buf_req = NULL;
+    bool handled_ioreq = false;
     ioreq_t req;
     int qw;
 
@@ -1144,9 +1145,10 @@ static int handle_buffered_iopage(XenIOState *state)
         assert(!req.data_is_ptr);
 
         qatomic_add(&buf_page->read_pointer, qw + 1);
+        handled_ioreq = true;
     }
 
-    return req.count;
+    return handled_ioreq;
 }
 
 static void handle_buffered_io(void *opaque)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:38:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244310.422548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlid-0002ra-A8; Fri, 10 Dec 2021 19:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244310.422548; Fri, 10 Dec 2021 19:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlid-0002rT-6W; Fri, 10 Dec 2021 19:38:11 +0000
Received: by outflank-mailman (input) for mailman id 244310;
 Fri, 10 Dec 2021 19:38:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvlic-0002rN-Oq
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:38:10 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b493c1c6-59f0-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:38:09 +0100 (CET)
Received: by mail-lj1-x22b.google.com with SMTP id z8so15187730ljz.9
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:38:09 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id g26sm381590ljn.107.2021.12.10.11.38.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:38:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b493c1c6-59f0-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=Vz91z0+ORqGgdBCzgXjvRZ+BnKWf40l2Uiz2VnVlq8k=;
        b=eZMbcUXJM6JFal7aKwXhI/zy2v2hsv6rjyETVziUEcyYhNcg6LAUN09SVbxxTQlCdu
         48ThdZHjH5oN83Vb3L4mJIfoBjma15qEEhMbLCJ9enFQmERgo4lteVUQPAb4Y8JgOjsq
         7ZmOQ7grPhjGYig7dCgOjLZZBHSDH75bpeiQUz0UkPGOU7rsqJhk71e0rLD6TE0flZ2X
         dazEIm86TjOs0vu1kBQHUAQAqwylSJZ01JBHT6WLG7J/LOnVfkO/7b9CPxeuZ6NJ8BMo
         jKCmkVO9SLg4PsHP720p1V12OBYdWJK0lEqLDpCAuJd3HSFk0stATZ42n3vOpzDj4hRW
         GlVQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=Vz91z0+ORqGgdBCzgXjvRZ+BnKWf40l2Uiz2VnVlq8k=;
        b=aEY50D5N8GcxIX9UBwZE0PbzNfO+ConBq9Hg1omvfEL+u4+dVNtgUtvvP7uCZlxPQB
         fMnXcXyEdonK0Foj3+URPlypefSb2DKoDRqgnGwikqSKy1zyM3zQ99hFYROWK0qz9G3u
         9J49+TFIdrsjVRs3fZMsqiHJ186wvDXGbG0YFqlc1aYuAN6nx6D4kLFU1ZdMeNQEuyYh
         e0XVPA+/7EEHGa2bK7e1gznIJsGpNBGaZ6swZqKuSIxjyUY8iMxE5yrNRq2E7s4ffK8N
         ruxBXbIxHXOcD2ip6JYnftt3PlNehJs7gOagrPUIpghXk6JpYhbmOcc2NhZaPke9Z3SQ
         oc/w==
X-Gm-Message-State: AOAM533yIDfN1SbQqhzoXcDepzThgBqmsv/n0YjCWYqoBox8rMQNEiV3
	1BRszYKhADsGd/9dzBnF0Tw=
X-Google-Smtp-Source: ABdhPJwmRMsITckKyfKcY5/bceJH9ZYTPTjj0S432HFHTKbLTU9WPpBsAnrN2ZIngDo5MzFGTcTiYQ==
X-Received: by 2002:a2e:5c46:: with SMTP id q67mr14941958ljb.271.1639165089500;
        Fri, 10 Dec 2021 11:38:09 -0800 (PST)
Subject: Re: [PATCH v4 06/25] reboot: Warn if unregister_restart_handler()
 fails
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-7-digetx@gmail.com>
 <CAJZ5v0ii7tGRDbxw+5GqdyONXvRPznXUqBZd03+pdoAd+pH=JQ@mail.gmail.com>
 <c518ce36-09d2-16a3-cec2-6bab8260e3cf@gmail.com>
 <CAJZ5v0iP_VnNW3ChmdvRFg1gvwvkDGmqtGnf1oVwQxXY303RkQ@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <41415df9-0d08-2944-5cf2-493468e21a22@gmail.com>
Date: Fri, 10 Dec 2021 22:38:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0iP_VnNW3ChmdvRFg1gvwvkDGmqtGnf1oVwQxXY303RkQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:08, Rafael J. Wysocki пишет:
> On Fri, Dec 10, 2021 at 7:54 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 10.12.2021 21:32, Rafael J. Wysocki пишет:
>>> On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>>>
>>>> Emit warning if unregister_restart_handler() fails since it never should
>>>> fail. This will ease further API development by catching mistakes early.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>>> ---
>>>>  kernel/reboot.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>>>> index e6659ae329f1..f0e7b9c13f6b 100644
>>>> --- a/kernel/reboot.c
>>>> +++ b/kernel/reboot.c
>>>> @@ -210,7 +210,7 @@ EXPORT_SYMBOL(register_restart_handler);
>>>>   */
>>>>  int unregister_restart_handler(struct notifier_block *nb)
>>>>  {
>>>> -       return atomic_notifier_chain_unregister(&restart_handler_list, nb);
>>>> +       return WARN_ON(atomic_notifier_chain_unregister(&restart_handler_list, nb));
>>>
>>> The only reason why it can fail is if the object pointed to by nb is
>>> not in the chain.
>>
>> I had exactly this case where object wasn't in the chain due to a bug
>> and this warning was very helpful.
> 
> During the development.  In production it would be rather annoying.
> 
>>>  Why WARN() about this?  And what about systems with
>>> panic_on_warn set?
>>
>> That warning condition will never happen normally, only when something
>> is seriously wrong.
>>
>> Those systems with panic_on_warn will get what was they asked for.
> 
> They may not be asking for panicking on bugs in the reboot notifier
> code, though.  That's what your change is making them panic on.
> 

Alright, I'll drop the warnings and turn the warning about uniqueness
into error or warning message.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:42:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:42:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244315.422559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvln5-0004F7-U2; Fri, 10 Dec 2021 19:42:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244315.422559; Fri, 10 Dec 2021 19:42:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvln5-0004F0-QI; Fri, 10 Dec 2021 19:42:47 +0000
Received: by outflank-mailman (input) for mailman id 244315;
 Fri, 10 Dec 2021 19:42:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvln4-0004Eu-OL
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:42:46 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 58f7eade-59f1-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 20:42:45 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id m12so15227499ljj.6
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:42:45 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id a24sm397890ljd.25.2021.12.10.11.42.43
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:42:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 58f7eade-59f1-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=enFW8kq8VV/q8dA9a71dgatcJTVb3G9Q0VbIAiUg3GI=;
        b=OX0KzgQUdES/90pWlhpcoFWULe5/02wjF+ZN5bPPd3PaEe6K8Rw2QbmG+hYBDryF8r
         t1f6EkNRPieboSxPtviSTR/1V4y4Mr8zIstzUICcEoY48eKM2+0m88Bup+wVJuu+v7rM
         mwIk5EqSpZDyoTDNu1aQivf7cqdLiwt7kJ7MYsCU49jLtqsBENUcVljNfz8djr77JsJw
         nEuxWBBZFJueyYpPkJsYZuSAKA0Qf9vITcyimaXwItLwdGCf5tFbJFT6C3clmEwXp7kg
         1TFGkI4NdX0eDs8czP/NCn+FzZ3eaPKoluKA8KfWOjMbGdEYGco1sgCURxizjwPPW+3Z
         YGiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=enFW8kq8VV/q8dA9a71dgatcJTVb3G9Q0VbIAiUg3GI=;
        b=eHO7zDtpuc36Yp7tRJxLLH/4PMQ2AWipUymu+GY2Ulum0afqXjmA8OMS9VpDkag6Qr
         sDhsRgUKgEgk5ZeiYt6p/lqVAJqQIiOstcSDuiihTgmT2SWKdSrFR28EUyOPDWAUVB8j
         5ht4s9n1I+24Qw3A3QxQftb2Ci7UQDnJEJUeUrlxmt8c+ALFwiCJ8qpvG9bbARwU7WcA
         pLVd7jV0NKvVYUTQ4Ha1L5g9B9gbRcAFtau1h9wX2s+/vZjdddfV4cxwa6gCscawGdPW
         9QX5lUU17LwgAvOYFLzg00BO8LZVaKSuvpigThev4IQX5TOAf/s1hN2/ga1A+fz0mMWJ
         DMFQ==
X-Gm-Message-State: AOAM532hmnOIwHRVCM6eLyEF8lgyrDg/TLQW5uYPOhQEy5we8iP6V1OP
	6IxBIh/kjUpr3keWs+/JY/A=
X-Google-Smtp-Source: ABdhPJw7x5EmEcRpJsG2MrtTa2zjfPAYa0CkU29XHMHibYlDXJBMyWndjSh2p83fU9klfOOOmpp/mQ==
X-Received: by 2002:a2e:9003:: with SMTP id h3mr15096538ljg.68.1639165365371;
        Fri, 10 Dec 2021 11:42:45 -0800 (PST)
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated
 priority
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-6-digetx@gmail.com> <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl>
 <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl>
 <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
 <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
 <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
From: Dmitry Osipenko <digetx@gmail.com>
Message-ID: <45228c88-4d51-591e-5da5-9ec468e71684@gmail.com>
Date: Fri, 10 Dec 2021 22:42:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:14, Rafael J. Wysocki пишет:
> On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 10.12.2021 21:27, Rafael J. Wysocki пишет:
>>> On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>>>
>>>> 29.11.2021 03:26, Michał Mirosław пишет:
>>>>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote:
>>>>>> 28.11.2021 03:28, Michał Mirosław пишет:
>>>>>>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote:
>>>>>>>> Add sanity check which ensures that there are no two restart handlers
>>>>>>>> registered with the same priority. Normally it's a direct sign of a
>>>>>>>> problem if two handlers use the same priority.
>>>>>>>
>>>>>>> The patch doesn't ensure the property that there are no duplicated-priority
>>>>>>> entries on the chain.
>>>>>>
>>>>>> It's not the exact point of this patch.
>>>>>>
>>>>>>> I'd rather see a atomic_notifier_chain_register_unique() that returns
>>>>>>> -EBUSY or something istead of adding an entry with duplicate priority.
>>>>>>> That way it would need only one list traversal unless you want to
>>>>>>> register the duplicate anyway (then you would call the older
>>>>>>> atomic_notifier_chain_register() after reporting the error).
>>>>>>
>>>>>> The point of this patch is to warn developers about the problem that
>>>>>> needs to be fixed. We already have such troubling drivers in mainline.
>>>>>>
>>>>>> It's not critical to register different handlers with a duplicated
>>>>>> priorities, but such cases really need to be corrected. We shouldn't
>>>>>> break users' machines during transition to the new API, meanwhile
>>>>>> developers should take action of fixing theirs drivers.
>>>>>>
>>>>>>> (Or you could return > 0 when a duplicate is registered in
>>>>>>> atomic_notifier_chain_register() if the callers are prepared
>>>>>>> for that. I don't really like this way, though.)
>>>>>>
>>>>>> I had a similar thought at some point before and decided that I'm not in
>>>>>> favor of this approach. It's nicer to have a dedicated function that
>>>>>> verifies the uniqueness, IMO.
>>>>>
>>>>> I don't like the part that it traverses the list second time to check
>>>>> the uniqueness. But actually you could avoid that if
>>>>> notifier_chain_register() would always add equal-priority entries in
>>>>> reverse order:
>>>>>
>>>>>  static int notifier_chain_register(struct notifier_block **nl,
>>>>>               struct notifier_block *n)
>>>>>  {
>>>>>       while ((*nl) != NULL) {
>>>>>               if (unlikely((*nl) == n)) {
>>>>>                       WARN(1, "double register detected");
>>>>>                       return 0;
>>>>>               }
>>>>> -             if (n->priority > (*nl)->priority)
>>>>> +             if (n->priority >= (*nl)->priority)
>>>>>                       break;
>>>>>               nl = &((*nl)->next);
>>>>>       }
>>>>>       n->next = *nl;
>>>>>       rcu_assign_pointer(*nl, n);
>>>>>       return 0;
>>>>>  }
>>>>>
>>>>> Then the check for uniqueness after adding would be:
>>>>>
>>>>>  WARN(nb->next && nb->priority == nb->next->priority);
>>>>
>>>> We can't just change the registration order because invocation order of
>>>> the call chain depends on the registration order
>>>
>>> It doesn't if unique priorities are required and isn't that what you want?
>>>
>>>> and some of current
>>>> users may rely on that order. I'm pretty sure that changing the order
>>>> will have unfortunate consequences.
>>>
>>> Well, the WARN() doesn't help much then.
>>>
>>> Either you can make all of the users register with unique priorities,
>>> and then you can make the registration reject non-unique ones, or you
>>> cannot assume them to be unique.
>>
>> There is no strong requirement for priorities to be unique, the reboot.c
>> code will work properly.
> 
> In which case adding the WARN() is not appropriate IMV.
> 
> Also I've looked at the existing code and at least in some cases the
> order in which the notifiers run doesn't matter.  I'm not sure what
> the purpose of this patch is TBH.

The purpose is to let developer know that driver needs to be corrected.

>> The potential problem is on the user's side and the warning is intended
>> to aid the user.
> 
> Unless somebody has the panic_on_warn mentioned previously set and
> really the user need not understand what the WARN() is about.  IOW,
> WARN() helps developers, not users.
> 
>> We can make it a strong requirement, but only after converting and
>> testing all kernel drivers.
> 
> Right.
> 
>> I'll consider to add patches for that.
> 
> But can you avoid adding more patches to this series?

I won't add more patches since such patches can be added only after
completion of transition to the new API of the whole kernel.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:44:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:44:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244320.422570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlp0-0004rS-AZ; Fri, 10 Dec 2021 19:44:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244320.422570; Fri, 10 Dec 2021 19:44:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlp0-0004rL-7R; Fri, 10 Dec 2021 19:44:46 +0000
Received: by outflank-mailman (input) for mailman id 244320;
 Fri, 10 Dec 2021 19:44:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvloz-0004rF-Dd
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:44:45 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9fc5d669-59f1-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 20:44:44 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id k37so19986358lfv.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:44:44 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id c15sm394938lfb.154.2021.12.10.11.44.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:44:43 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9fc5d669-59f1-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=bghkq/gqakBG3UMA9KtKqv9kgT5Wq1LJh/DaMMP+Buo=;
        b=lFdiyPZK17AYCTV65ZUsvdfciaNUYWPxmzSgJajTwQ07RVOIMn5cd3OMLqgm70DBAO
         sO9a+0M7Ylp7HtPfjlNdELPWJPhFEsL+BBJZhlleZ8ktrzvWgXu2rCggboh+AgCAyR+i
         WdIEhcqPzr+EGbl0oQk36HsGosG8oJ4OqatnVU+rYKpyd3R/jmhh8wJ5nt8gGw45GBZy
         rNd0gesXdm60r4RJ7qNGWsHGKiq3UiUqi5FkpCzhl0LGExdzbir7EPh4UTzIBF/YRE+s
         kyUVKadGSflj2NYa6m+B4vuldmIqJM59VgWObzoRC+XA5qxz4D0b/H+jRuY2tRZWYoPI
         /XGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=bghkq/gqakBG3UMA9KtKqv9kgT5Wq1LJh/DaMMP+Buo=;
        b=EihEzm1uUGl2bdGtMJ9AYmcDyZZWzzl6O3R8tBQkyO7c+GJg5xDIn69Hr1rNxtDt4P
         JsfIDhNB4zWhvsst9ShcLZLua1sdzF+ihNZy3VZC27ZnciB0OaVKxy+9PlEb/gLFUUoE
         3tkoL0kzddnmf4KcVeC2zeEYXu5Nl3EmLnsusAWP2tWzGorYkJE7vIl6UTBMVxlD1uWG
         3QJJAnIkl+7DFhJO5inHdrj6vYVFWlgez1+ViM8KIxlhN8FQrt+bcYTm+S+XTxvkSoIe
         vlPCIx+xev13I/JDRIOL7ON0JAAap6iEVymEAMGv4cL9VECb504jb/M1xucHNTfBDDbO
         89vA==
X-Gm-Message-State: AOAM530A15lot9eHqqhbdhLf1Ycahs66QwH5apcXHkE8tbyyzWpDePfB
	ECE1b/5WFB57l8WiO5c1a2c=
X-Google-Smtp-Source: ABdhPJwdPpKxpD5iCVpMoy0RbhPzj8+6gSmN9/Uu5pMKxteqUazmF0c3BRQXsHXIE6Vu9MIa4P5vrA==
X-Received: by 2002:ac2:4c50:: with SMTP id o16mr14291331lfk.517.1639165484083;
        Fri, 10 Dec 2021 11:44:44 -0800 (PST)
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated
 priority
From: Dmitry Osipenko <digetx@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
 Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-6-digetx@gmail.com> <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl>
 <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl>
 <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
 <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
 <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
 <45228c88-4d51-591e-5da5-9ec468e71684@gmail.com>
Message-ID: <ad6c7d73-e7d3-4901-fd63-ef87eecd39a2@gmail.com>
Date: Fri, 10 Dec 2021 22:44:41 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <45228c88-4d51-591e-5da5-9ec468e71684@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:42, Dmitry Osipenko пишет:
...
>>> There is no strong requirement for priorities to be unique, the reboot.c
>>> code will work properly.
>>
>> In which case adding the WARN() is not appropriate IMV.
>>
>> Also I've looked at the existing code and at least in some cases the
>> order in which the notifiers run doesn't matter.  I'm not sure what
>> the purpose of this patch is TBH.
> 
> The purpose is to let developer know that driver needs to be corrected.
> 
>>> The potential problem is on the user's side and the warning is intended
>>> to aid the user.
>>
>> Unless somebody has the panic_on_warn mentioned previously set and
>> really the user need not understand what the WARN() is about.  IOW,
>> WARN() helps developers, not users.
>>
>>> We can make it a strong requirement, but only after converting and
>>> testing all kernel drivers.
>>
>> Right.
>>
>>> I'll consider to add patches for that.
>>
>> But can you avoid adding more patches to this series?
> 
> I won't add more patches since such patches can be added only after
> completion of transition to the new API of the whole kernel.
> 

Thank you for the review.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 19:50:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 19:50:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244327.422581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvlty-0006C2-1t; Fri, 10 Dec 2021 19:49:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244327.422581; Fri, 10 Dec 2021 19:49:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvltx-0006Bv-Un; Fri, 10 Dec 2021 19:49:53 +0000
Received: by outflank-mailman (input) for mailman id 244327;
 Fri, 10 Dec 2021 19:49:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvltw-0006Bp-1D
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 19:49:52 +0000
Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com
 [2a00:1450:4864:20::135])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 565699e4-59f2-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 20:49:50 +0100 (CET)
Received: by mail-lf1-x135.google.com with SMTP id k37so20007230lfv.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 11:49:50 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id z24sm395757lfh.289.2021.12.10.11.49.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 11:49:49 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 565699e4-59f2-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=8Fx2AxGyl7h70TiPIfAS4vLJoC4O4KHoawTu1bt5PLU=;
        b=V/Owe18bjaHxi/q9LMXS8LNROf16L9DCZYGpExoCj+SNTLCiSQNB3HcPLajV/NP5JE
         39hqIvfIb3bc7xrS2E0EYCC3yAPKzLg7BnA0PumFQ89YOCGyLF9Ipz3BTISejc0ZvQJA
         z5FDAeVaX1e2/Z9TFGOO31SRX4KXbVNvKZ2tbYOwQTeu/RyJ9cs6xalps+Kn8iqrggDL
         HFUryH5SPjqHR6nW0F4ENPTnll1o3uJ7tQu3AMV7MUX+qx7nV3LMFjM06jk+Y2dJ7HtP
         J+zk+OszrogiRw5+RRL4W19jTgJEJXo+L0tNHRiDg9ofDsu8gJQpDKtlXAuJgOp4GYiB
         LSvg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=8Fx2AxGyl7h70TiPIfAS4vLJoC4O4KHoawTu1bt5PLU=;
        b=I1iWMn+/1LD3isNyUc0D7eHene3dSYDtFHdNHJxkLyMRNTcBBr4DFbK4al0sl3GEoP
         +zMTyDUVrSxFYlPruq73oS4PAM7kcWWCz/hS/0n+pWBcTv367VAj341s0ia+ATDwlh/w
         BNE/P5rQYQ2DL7bd7PFpWvJlUB7UULlQBfAxwHpN46Hy4SFUyfMpqZ6TnRs2He67ZiAT
         p4WL5DzLhwD8B0CfkhZeYk1YNuZfPz/j42WQHId3fvCDNDeRd1qbdBwj/IQG/Hngc8Qe
         WdbVSk00O7tcpuNbDWbxuJSt9i6/dTf2M1Q/1aV7bGwwSAUcYxV47pSMC7dwruhmum5a
         MhqQ==
X-Gm-Message-State: AOAM533rHheZ1rE7uQbBcUqF7H5dlko5bJu6Lkfo2H+vkmoj/Qp28dMD
	Ww4dfWoWengpi/BADFxT1nU=
X-Google-Smtp-Source: ABdhPJz32UCAa2RfOn9XCHx2JjAq/5XnkzKJ8mqE0CmU9Bnm8cg96K7fElVvubFW0G/2Bv0vNQ8r/g==
X-Received: by 2002:a05:6512:114a:: with SMTP id m10mr14457333lfg.188.1639165790431;
        Fri, 10 Dec 2021 11:49:50 -0800 (PST)
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated
 priority
From: Dmitry Osipenko <digetx@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
 =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-6-digetx@gmail.com> <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl>
 <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl>
 <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
 <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com>
 <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
 <45228c88-4d51-591e-5da5-9ec468e71684@gmail.com>
 <ad6c7d73-e7d3-4901-fd63-ef87eecd39a2@gmail.com>
Message-ID: <7875d10b-0d9b-ca29-668b-630ea3650fd0@gmail.com>
Date: Fri, 10 Dec 2021 22:49:47 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <ad6c7d73-e7d3-4901-fd63-ef87eecd39a2@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:44, Dmitry Osipenko пишет:
> 10.12.2021 22:42, Dmitry Osipenko пишет:
> ...
>>>> There is no strong requirement for priorities to be unique, the reboot.c
>>>> code will work properly.
>>>
>>> In which case adding the WARN() is not appropriate IMV.
>>>
>>> Also I've looked at the existing code and at least in some cases the
>>> order in which the notifiers run doesn't matter.  I'm not sure what
>>> the purpose of this patch is TBH.
>>
>> The purpose is to let developer know that driver needs to be corrected.
>>
>>>> The potential problem is on the user's side and the warning is intended
>>>> to aid the user.
>>>
>>> Unless somebody has the panic_on_warn mentioned previously set and
>>> really the user need not understand what the WARN() is about.  IOW,
>>> WARN() helps developers, not users.
>>>
>>>> We can make it a strong requirement, but only after converting and
>>>> testing all kernel drivers.
>>>
>>> Right.
>>>
>>>> I'll consider to add patches for that.
>>>
>>> But can you avoid adding more patches to this series?
>>
>> I won't add more patches since such patches can be added only after
>> completion of transition to the new API of the whole kernel.
>>
> 
> Thank you for the review.
> 

I meant you, Rafael, and Michał, just in case :)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 20:07:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 20:07:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244333.422592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvmAu-0001Ju-DR; Fri, 10 Dec 2021 20:07:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244333.422592; Fri, 10 Dec 2021 20:07:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvmAu-0001Jn-AY; Fri, 10 Dec 2021 20:07:24 +0000
Received: by outflank-mailman (input) for mailman id 244333;
 Fri, 10 Dec 2021 20:07:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvmAs-0001Jd-8E; Fri, 10 Dec 2021 20:07:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvmAs-0005do-22; Fri, 10 Dec 2021 20:07:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvmAr-0003lD-Pl; Fri, 10 Dec 2021 20:07:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvmAr-00049V-PD; Fri, 10 Dec 2021 20:07:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zNx/kbH87ZTaC+6rB7yY6YCcuBF4DxzxNNqsMTcoDK8=; b=WXvf1xsysgl5AgqP6wpId82tzz
	jXXLq6oTG9H7SMyWVhbiPs12bERib/k6Si+YaUJcfAIXIga7RPNV8EUlb2o1cF7SXNfbJ6uLdSzdF
	6+Pi3d7/aQFPoZ0Jh8ccyp6ubYc4jfd8O8koN9pXeiNDuCATzNafx+7i5RX+kv3azUGA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167350-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167350: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 20:07:21 +0000

flight 167350 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167350/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 0f1d7477c0a86a31e2edede7d3a3c74087bb6e21
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   37 attempts
Testing same since   167338  2021-12-10 10:40:22 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1070 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 20:16:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 20:16:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244339.422605 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvmJm-0002lr-9d; Fri, 10 Dec 2021 20:16:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244339.422605; Fri, 10 Dec 2021 20:16:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvmJm-0002lk-6a; Fri, 10 Dec 2021 20:16:34 +0000
Received: by outflank-mailman (input) for mailman id 244339;
 Fri, 10 Dec 2021 20:16:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=Lr8x=Q3=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mvmJl-0002le-EM
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 20:16:33 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 110963d7-59f6-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 21:16:32 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id k37so20113907lfv.3
 for <xen-devel@lists.xenproject.org>; Fri, 10 Dec 2021 12:16:32 -0800 (PST)
Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.googlemail.com with ESMTPSA id z23sm409427ljn.23.2021.12.10.12.16.30
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 10 Dec 2021 12:16:31 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 110963d7-59f6-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=3TjXmEXDJ/+bmC4Ps/ax4TtRHBZzHR+/4MLS5Bo5vyY=;
        b=pA5gJzqpb6DuYCThgFEy/8I55Q/DWCaUg3a+PUCGAi7titTHPZavt9HNjzNTaNOdtA
         W9bvYLeTFtb26OuFlSespYNsQjEuRbN74aib6efdQf4sRvk0jZOXEyR7Ry1SlPtvny3V
         dHFm88kS0utx46N/B1V95jCju3EdX/3tioPOW0AUjL07+k8WzDTAaYKBNQJxB0pggImt
         zxKY302IiWihQZ6zPY6n4S1ZYz2akRfe0TTR5ci41YrCJJyH8fb1pqNG9DRsK91AXeR3
         4OlRlbRYehYwacP4ScBqgyVswzojoT/ol0CB6bk5gTERql84YP9I/T1kujCvte5MFcNM
         x95w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=3TjXmEXDJ/+bmC4Ps/ax4TtRHBZzHR+/4MLS5Bo5vyY=;
        b=r8UtpIsI/I5ZI+C1JI7Sy/XXxfwOJtEVEHVwNRVAA1ANl5oV2ja+XEgiAKJidKPTU6
         Z2NwKG3HRJjHIKafmyZiOnq5scD8L+rYaLbo7vhel4Hb+ILaPHO0yPUt0eXJ1/QCmIva
         gFoXlpA69SrANpR/2hy4E9NsTij/KqC8X93TH4OFeRypFtFxsio63U2JHH4AVvxMdCXf
         nRAandTW4IpWnjYWi41FyaooAr9penQjvijXBD4CCJlglIJWWkNjFy6SL500wooTi9rs
         XNduzq2f4q/ggUn0+tkOsQO17jdaN05+n9xqJOy1lmH2Px3tfOwJayKarSeL38X4fNxj
         7iWQ==
X-Gm-Message-State: AOAM532K9N+0ZydxcUAXJaWXweGnM/zCo1GuqCtlyxVQb5PdpsiLwXGR
	R557G/tUCuleP9HUgFm5gGk=
X-Google-Smtp-Source: ABdhPJwE5tZeH/HHL0CnlLb6JayzZfWyUFquo/I1vHYJYjJlUN8IQfec3+fnfy4fMkF6dVQvXojbFQ==
X-Received: by 2002:a05:6512:2292:: with SMTP id f18mr14265704lfu.18.1639167392050;
        Fri, 10 Dec 2021 12:16:32 -0800 (PST)
Subject: Re: [PATCH v4 03/25] notifier: Add
 atomic/blocking_notifier_has_unique_priority()
From: Dmitry Osipenko <digetx@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Russell King
 <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>,
 Geert Uytterhoeven <geert@linux-m68k.org>, Greg Ungerer
 <gerg@linux-m68k.org>, Joshua Thompson <funaho@jurai.org>,
 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Sebastian Reichel <sre@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>,
 Greentime Hu <green.hu@gmail.com>, Vincent Chen <deanbo422@gmail.com>,
 "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
 Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>,
 Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
 Boris Ostrovsky <boris.ostrovsky@oracle.com>, Juergen Gross
 <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
 Len Brown <lenb@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
 Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck
 <linux@roeck-us.net>, Daniel Lezcano <daniel.lezcano@linaro.org>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
 Ulf Hansson <ulf.hansson@linaro.org>, alankao@andestech.com,
 "K . C . Kuen-Chern Lin" <kclin@andestech.com>,
 Linux ARM <linux-arm-kernel@lists.infradead.org>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org,
 linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
 linux-parisc@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
 linux-riscv@lists.infradead.org, Linux-sh list <linux-sh@vger.kernel.org>,
 xen-devel@lists.xenproject.org,
 ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
 Linux PM <linux-pm@vger.kernel.org>,
 linux-tegra <linux-tegra@vger.kernel.org>
References: <20211126180101.27818-1-digetx@gmail.com>
 <20211126180101.27818-4-digetx@gmail.com>
 <CAJZ5v0jTJ3f7oUUR690PGaPJsxA8yzua9XDa8MONBHMzHnDfOQ@mail.gmail.com>
 <e6ff1cea-a168-1cb0-25c5-fb16c681cf4a@gmail.com>
 <CAJZ5v0gwnY07vg71_NB8RDWyv84FtMsmx7UTDd8TkUd7vFzc6A@mail.gmail.com>
 <fd158245-aa9a-2e48-0145-004f30005a66@gmail.com>
Message-ID: <218e67e2-1d8c-5727-3862-8884d74aa63e@gmail.com>
Date: Fri, 10 Dec 2021 23:16:29 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <fd158245-aa9a-2e48-0145-004f30005a66@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

10.12.2021 22:33, Dmitry Osipenko пишет:
>> Not really, they only prevent the race from occurring while
>> notifier_has_unique_priority() is running.
>>
>> If anyone depends on this check for correctness, they need to lock the
>> rwsem, do the check, do the thing depending on the check while holding
>> the rwsem and then release the rwsem.  Otherwise it is racy.
>>
> It's fine that it's a bit "racy" since in the context of this series. We
> always do the check after adding new entry, so it's not a problem.
> 
> There are two options:
> 
> 1. Use blocking_notifier_has_unique_priority() like it's done in this
> patchset. Remove it after all drivers are converted to the new API and
> add blocking_notifier_chain_register_unique().
> 
> 2. Add blocking_notifier_chain_register_unique(), but don't let it fail
> the registration of non-unique entries until all drivers are converted
> to the new API.

There is third, perhaps the best option:

3. Add blocking_notifier_chain_register_unique() and fall back to
blocking_notifier_chain_register() if unique fails, do it until all
drivers are converted to the new API.


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 21:32:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 21:32:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244344.422616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvnVG-0006ci-TY; Fri, 10 Dec 2021 21:32:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244344.422616; Fri, 10 Dec 2021 21:32:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvnVG-0006cb-Qg; Fri, 10 Dec 2021 21:32:30 +0000
Received: by outflank-mailman (input) for mailman id 244344;
 Fri, 10 Dec 2021 21:32:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvnVG-0006cR-20; Fri, 10 Dec 2021 21:32:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvnVF-0007Cv-Qo; Fri, 10 Dec 2021 21:32:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvnVF-0006jt-I0; Fri, 10 Dec 2021 21:32:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvnVF-0006fl-HU; Fri, 10 Dec 2021 21:32:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=LQNgRKU8rAuabSzstuAD7sILOTHvugVxnC5pTxmuBqI=; b=O7qwP6Kt1enpXnGOuQ6xfeXFOR
	XORflHPSqLlPIqvN3lFcz05uwVyaNSaodz8c/LEJEWciWigD0f3Z/rom93OHCdo0hb5oHFUKXONA3
	Tyra937kJaRbOZOGOWgkaHLLq7QZzbjz6xjiM7/2NhevyH1dYJtJiY/jzULdjWy9lXaw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167352-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167352: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 21:32:29 +0000

flight 167352 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167352/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   38 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244353.422646 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE6-0005aL-BN; Fri, 10 Dec 2021 22:18:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244353.422646; Fri, 10 Dec 2021 22:18:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE6-0005Yi-27; Fri, 10 Dec 2021 22:18:50 +0000
Received: by outflank-mailman (input) for mailman id 244353;
 Fri, 10 Dec 2021 22:18:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE4-0005LR-Ot
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:48 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24d8bf03-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:18:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24d8bf03-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.311410967@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174727;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4+wAkdppI+0FsjiVOjRoboRfUoEGu3PdDBK/1dnuCFY=;
	b=ijWPKjClq9DRfiqDCauUOqeI5yYXU3tP5wg1MsLiKOCZqSOsagFln3c4OzFUS8Elgn46kT
	qZIz6lyQXHxfolX96i5XU3cIY+D4MK65b0BisdPtXRaGLKyN22HIG9WMFc+a+Pb5r7Yt/N
	eix//MgfLCsvJT9BqyxVTdFM2ahx+ztKJ8+enXpo3Chemrr7l8l5NLYSQHADKus4XYZZnO
	QmX2SU6sGHvlTDt+nKERO7dywK6hGk9HZOEQsczXKbt2T6kRuRb78llE48vY+tc3PmAP5s
	m+ydYZQD/Zwgx9B4Nu5/uGrHlQvSDdMfqU4QRjzINF5B0nfUQ1l0aHNZvqeKkQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174727;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4+wAkdppI+0FsjiVOjRoboRfUoEGu3PdDBK/1dnuCFY=;
	b=GMWdydzWOH0ZCkNPtZwjkukJHdiZ5ohuNFeG5sc5tFhBJYzUGlpxrb3zsKf8GNmvxEolyK
	fEg7ZZ5yE3oPqGCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 02/35] x86/pci/XEN: Use PCI device property
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:46 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
---
V3: Use pci_dev->msix_enabled.
---
 arch/x86/pci/xen.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -399,9 +399,7 @@ static void xen_teardown_msi_irqs(struct
 
 static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
 {
-	struct msi_desc *msidesc = first_pci_msi_entry(dev);
-
-	if (msidesc->pci.msi_attrib.is_msix)
+	if (dev->msix_enabled)
 		xen_pci_frontend_disable_msix(dev);
 	else
 		xen_pci_frontend_disable_msi(dev);
@@ -417,10 +415,7 @@ static int xen_msi_domain_alloc_irqs(str
 	if (WARN_ON_ONCE(!dev_is_pci(dev)))
 		return -EINVAL;
 
-	if (first_msi_entry(dev)->pci.msi_attrib.is_msix)
-		type = PCI_CAP_ID_MSIX;
-	else
-		type = PCI_CAP_ID_MSI;
+	type = to_pci_dev(dev)->msix_enabled ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
 
 	return xen_msi_ops.setup_msi_irqs(to_pci_dev(dev), nvec, type);
 }



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244355.422674 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE8-0006Oe-Pt; Fri, 10 Dec 2021 22:18:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244355.422674; Fri, 10 Dec 2021 22:18:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE8-0006OQ-MO; Fri, 10 Dec 2021 22:18:52 +0000
Received: by outflank-mailman (input) for mailman id 244355;
 Fri, 10 Dec 2021 22:18:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE6-0005LR-Sd
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:50 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 26b0de2a-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:18:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 26b0de2a-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.434156196@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174730;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VrU+cUwVNt/tRlW4lw+bzWjrRhpWxr0n5kAnta20rq4=;
	b=pE4rQ2ru1rC+MOxwgCFck9hIsKI0LjZICNGNwEw8ze9/meweY1qANt4dgwIHKfQOPC1beg
	yPBns7caG7PjSlQkEoMvTCi/DDid/5ijo+pcU/3ZLIE1LS+qQRJIeuxZj2Mi/GYsUgFxDG
	UfE4buF12pfMJCkH4E7kXOGXF3Tdxoadhmimlb4Oqaa6At4sxsqGTcRd4XwvSUVolW7xT/
	BZ6l4WzdOdHBFzRU8fuHCGeKVTvU3fpMB68bg/XbArySIyUaHyjLg/eiywsouAZhDcRfnk
	7ETqReSwtzm9CpcynGCRQWFvda5xRxitOgtngCsHnX2u5kMmZ6hOfaZO1ylegg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174730;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=VrU+cUwVNt/tRlW4lw+bzWjrRhpWxr0n5kAnta20rq4=;
	b=4a4+C7WhuYdeuyTtWKdNyTdvLDhhfziSubOZ+5mUXlzgk+OuqIM6rjcLPfL3/GtWFOnIFc
	gcXKQZiyuUQutAAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 04/35] genirq/msi: Use PCI device property
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:49 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

to determine whether this is MSI or MSIX instead of consulting MSI
descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V2: Use PCI device property - Jason
---
 kernel/irq/msi.c |   17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -77,21 +77,8 @@ EXPORT_SYMBOL_GPL(get_cached_msi_msg);
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)
 {
-	struct msi_desc *entry;
-	bool is_msix = false;
-	unsigned long irq;
-	int retval;
-
-	retval = kstrtoul(attr->attr.name, 10, &irq);
-	if (retval)
-		return retval;
-
-	entry = irq_get_msi_desc(irq);
-	if (!entry)
-		return -ENODEV;
-
-	if (dev_is_pci(dev))
-		is_msix = entry->pci.msi_attrib.is_msix;
+	/* MSI vs. MSIX is per device not per interrupt */
+	bool is_msix = dev_is_pci(dev) ? to_pci_dev(dev)->msix_enabled : false;
 
 	return sysfs_emit(buf, "%s\n", is_msix ? "msix" : "msi");
 }



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244354.422652 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE6-0005hF-KH; Fri, 10 Dec 2021 22:18:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244354.422652; Fri, 10 Dec 2021 22:18:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE6-0005ey-CP; Fri, 10 Dec 2021 22:18:50 +0000
Received: by outflank-mailman (input) for mailman id 244354;
 Fri, 10 Dec 2021 22:18:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE5-0005LK-DO
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:49 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 25c51161-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 25c51161-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221813.372357371@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jxff/xJv3Qst4ZB5tRChjTLXCWZK8WA2PIPQRiU/rvY=;
	b=0nUrI//widUx8A75bvq7IZvZU0OgOd7DLmm1Zp2ltSlJUJ9r/TrE9oF6ObjsG/CcBOkiYi
	qXw9+h4dQG4uyEMuyKeiBlxL4kElXM0TpMwsf3wmE81Z2stJW+ptloJgs/g6qP6M8dR2QU
	njRyGX3+6rX5xnHULZR7tzFqLrE14gpMsFum/pVWgPlIZ+TpaG54gue+YwCmJ2mvy52BBv
	eJfY6AUb8aIr3HCk56T6i2B/ksAdJHhdmvylSbmQ1UvjRhp/j3IltXf1nTsUbtPgTPyfJ7
	dTv1xOVMJ9eZrRTBBhQoxRXkLcJLQxyY0zHx9KeMYtAVYinBZUzQopdXWot8gQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=jxff/xJv3Qst4ZB5tRChjTLXCWZK8WA2PIPQRiU/rvY=;
	b=vv6Me8N9GQvFvm+KtHhMWgm41j6C3fva9jay/jD8ClFpKD7/3pJq+KAqrq6JZCZO9BTGwf
	CoMF7Kja5mNu2oDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 03/35] x86/apic/msi: Use PCI device MSI property
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:47 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V3: Use pci_dev->msix_enabled - Jason
---
 arch/x86/kernel/apic/msi.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/arch/x86/kernel/apic/msi.c
+++ b/arch/x86/kernel/apic/msi.c
@@ -160,11 +160,8 @@ static struct irq_chip pci_msi_controlle
 int pci_msi_prepare(struct irq_domain *domain, struct device *dev, int nvec,
 		    msi_alloc_info_t *arg)
 {
-	struct pci_dev *pdev = to_pci_dev(dev);
-	struct msi_desc *desc = first_pci_msi_entry(pdev);
-
 	init_irq_alloc_info(arg, NULL);
-	if (desc->pci.msi_attrib.is_msix) {
+	if (to_pci_dev(dev)->msix_enabled) {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSIX;
 	} else {
 		arg->type = X86_IRQ_ALLOC_TYPE_PCI_MSI;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244351.422630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE5-0005Li-BS; Fri, 10 Dec 2021 22:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244351.422630; Fri, 10 Dec 2021 22:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE5-0005Lb-8d; Fri, 10 Dec 2021 22:18:49 +0000
Received: by outflank-mailman (input) for mailman id 244351;
 Fri, 10 Dec 2021 22:18:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE3-0005LK-Dd
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:47 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2401c406-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2401c406-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221813.250049810@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174725;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=LAPO48TeSRvyraOCUaLnLGoqr3cykpYVLg5Q2NPw+tk=;
	b=RVFQBQqAHeoiRwlZ3riRsRVnIL91ZjHAfRJRIp58J8GUnDjLQx7L9kWYIIUbdLwuKR/jwL
	JcJBPfohipM62TDgI++91yG93z8S9yOtP19oQQE8Q8k13Dz0zt5IP/hM5mMrevOXLmlklN
	kWOoGd3So5Fe6OgP0QbWV76D4psb9hl5USqdOyh+D6Aqhblm4cpa5e5Vf78Qu6ZYHkQHTi
	bgYvnB6aYzx+LTLoj46c14I2SP51PPz15FBrvc8JBpekzRO6sF7T8vtiJHTJFweb24goaW
	joW6zxk5fBYith6L0SW2dhYjEXttIyscMDGJDovBvIbb2eL2uBhx9UWrfH/KNw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174725;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=LAPO48TeSRvyraOCUaLnLGoqr3cykpYVLg5Q2NPw+tk=;
	b=W5z8GHgzI4pNn8BJLekDX4e1pfDaOzUgMdqste1q3KO/3rlD+JtPo0I0BMrvt2m3/1G3Vk
	MFABiwOkTOMR3XAQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:44 +0100 (CET)

There are quite some places which retrieve the first MSI descriptor to
evaluate whether the setup is for MSI or MSI-X. That's required because
pci_dev::msi[x]_enabled is only set when the setup completed successfully.

There is no real reason why msi[x]_enabled can't be set at the beginning of
the setup sequence and cleared in case of a failure.

Implement that so the MSI descriptor evaluations can be converted to simple
property queries.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V3: New patch
---
 drivers/pci/msi/msi.c |   23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -421,11 +421,18 @@ static int msi_capability_init(struct pc
 	struct msi_desc *entry;
 	int ret;
 
-	pci_msi_set_enable(dev, 0);	/* Disable MSI during set up */
+	/*
+	 * Disable MSI during setup in the hardware, but mark it enabled
+	 * so that setup code can evaluate it.
+	 */
+	pci_msi_set_enable(dev, 0);
+	dev->msi_enabled = 1;
 
 	entry = msi_setup_entry(dev, nvec, affd);
-	if (!entry)
-		return -ENOMEM;
+	if (!entry) {
+		ret = -ENOMEM;
+		goto fail;
+	}
 
 	/* All MSIs are unmasked by default; mask them all */
 	pci_msi_mask(entry, msi_multi_mask(entry));
@@ -452,7 +459,6 @@ static int msi_capability_init(struct pc
 	/* Set MSI enabled bits	*/
 	pci_intx_for_msi(dev, 0);
 	pci_msi_set_enable(dev, 1);
-	dev->msi_enabled = 1;
 
 	pcibios_free_irq(dev);
 	dev->irq = entry->irq;
@@ -461,6 +467,8 @@ static int msi_capability_init(struct pc
 err:
 	pci_msi_unmask(entry, msi_multi_mask(entry));
 	free_msi_irqs(dev);
+fail:
+	dev->msi_enabled = 0;
 	return ret;
 }
 
@@ -589,6 +597,9 @@ static int msix_capability_init(struct p
 	pci_msix_clear_and_set_ctrl(dev, 0, PCI_MSIX_FLAGS_MASKALL |
 				    PCI_MSIX_FLAGS_ENABLE);
 
+	/* Mark it enabled so setup functions can query it */
+	dev->msix_enabled = 1;
+
 	pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
 	/* Request & Map MSI-X table region */
 	tsize = msix_table_size(control);
@@ -626,9 +637,8 @@ static int msix_capability_init(struct p
 
 	dev->msi_irq_groups = groups;
 
-	/* Set MSI-X enabled bits and unmask the function */
+	/* Disable INTX and unmask MSI-X */
 	pci_intx_for_msi(dev, 0);
-	dev->msix_enabled = 1;
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
 
 	pcibios_free_irq(dev);
@@ -638,6 +648,7 @@ static int msix_capability_init(struct p
 	free_msi_irqs(dev);
 
 out_disable:
+	dev->msix_enabled = 0;
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
 
 	return ret;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244356.422686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEA-0006fo-9n; Fri, 10 Dec 2021 22:18:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244356.422686; Fri, 10 Dec 2021 22:18:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEA-0006eW-20; Fri, 10 Dec 2021 22:18:54 +0000
Received: by outflank-mailman (input) for mailman id 244356;
 Fri, 10 Dec 2021 22:18:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE8-0005LK-GE
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:52 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 279d666a-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 279d666a-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221813.493922179@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174731;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cKJHJ5pvxdQcbJzsUJMGqgFGoQj9I03QbSL7vU1xGJs=;
	b=1jYFlR/s4Fj8fK94IM8CGV2VaLN70VTxWOKgzd9JP93YsuiSkhZnYFY06GM/ck1LqQztP1
	MLFaGOIeCqYoexBgXapeoyYhkU0pOjGlXAPId/ebxaePxjkxMr+yK8v+0hb5X4+5ZG7B1H
	+va0VUPX0Xv4Yu86zDErk4wKNgJjI/W705RdoDtPXV+TGIU1/gfVAaxPimBu0jir0PtNCO
	fOlCra2fXDQuTRaSAH0ZtTlPuz+4kAZXETO59wFrYfdqVEy+3UT6OV5Rro3KejHz+49vks
	CFqN18s6k1HR1ibmPHBMCiufu6FCMC8wl1bZC8BEvjjvQ7GzWILhEocUSrICGA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174731;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cKJHJ5pvxdQcbJzsUJMGqgFGoQj9I03QbSL7vU1xGJs=;
	b=CKltebaN9sJb+/12aypx+vxMoPzMz+hKX+LQCpakacpcX5G/L+sQu6V9DoCJj9DznHwv8C
	jZHW+tYr3PY7biBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:51 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
---
V3: Use pci_dev property - Jason
V2: Invoke the function with the correct number of arguments - Andy
---
 arch/powerpc/platforms/cell/axon_msi.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/arch/powerpc/platforms/cell/axon_msi.c
+++ b/arch/powerpc/platforms/cell/axon_msi.c
@@ -199,7 +199,6 @@ static struct axon_msic *find_msi_transl
 static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
 {
 	struct device_node *dn;
-	struct msi_desc *entry;
 	int len;
 	const u32 *prop;
 
@@ -209,10 +208,8 @@ static int setup_msi_msg_address(struct
 		return -ENODEV;
 	}
 
-	entry = first_pci_msi_entry(dev);
-
 	for (; dn; dn = of_get_next_parent(dn)) {
-		if (entry->pci.msi_attrib.is_64) {
+		if (!dev->no_64bit_msi) {
 			prop = of_get_property(dn, "msi-address-64", &len);
 			if (prop)
 				break;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244357.422696 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEB-0006yD-Nk; Fri, 10 Dec 2021 22:18:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244357.422696; Fri, 10 Dec 2021 22:18:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEB-0006wY-H8; Fri, 10 Dec 2021 22:18:55 +0000
Received: by outflank-mailman (input) for mailman id 244357;
 Fri, 10 Dec 2021 22:18:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE9-0005LR-Ui
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:53 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2884b7df-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:18:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2884b7df-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.556202506@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174733;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4RBIpMLSx9fo7S3MVLgbPP6cYR3euRHVRt1vIjvLV4U=;
	b=eFwbxZ19sBwXOtZfaU9b68cRvDQr8Sc+5tFM8f+F85TqivDCre0VEP725UcXl+uCQNVwKg
	th5/P6pSHGU17/a07xZLVPs/inK96YGN0P8AVWusIBfugZ1VzOQwzILhbCMtpONvc2WXfS
	7tC0gKf8ggCcvGX0cZsFURAzOnX4SWiSiWBvq0yugB0Urkr1RzoMtfW4UBhLOolAcHMWEq
	8H9bNQmYEImVfPDpv7nBqpZqvmsgnsh02b/+ZEunwO9Rs+JWgiGZd954VBu+PM2tDQZVj6
	8gav38VhnHP0iMod6jbXLJ3KUM93DcPae/bJJ76Y8Igr1sJLMglnyFtpTjhkSQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174733;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4RBIpMLSx9fo7S3MVLgbPP6cYR3euRHVRt1vIjvLV4U=;
	b=WYa+NdWlWzJ03zg9xAtS1+YMoE5TJHwS2b+RN+noddeR78xU6q7+ZPKxIZRkWf4y7NHAji
	EqHm91dbXa6KWXAg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Michael Ellerman <mpe@ellerman.id.au>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 06/35] powerpc/pseries/msi: Use PCI device properties
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:52 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
V3: Use pci_dev->msix_enabled - Jason
---
 arch/powerpc/platforms/pseries/msi.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -448,8 +448,7 @@ static int pseries_msi_ops_prepare(struc
 				   int nvec, msi_alloc_info_t *arg)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
-	struct msi_desc *desc = first_pci_msi_entry(pdev);
-	int type = desc->pci.msi_attrib.is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
+	int type = pdev->msix_enabled ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
 
 	return rtas_prepare_msi_irqs(pdev, nvec, type, arg);
 }



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244352.422637 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE5-0005OL-PP; Fri, 10 Dec 2021 22:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244352.422637; Fri, 10 Dec 2021 22:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoE5-0005Ny-H6; Fri, 10 Dec 2021 22:18:49 +0000
Received: by outflank-mailman (input) for mailman id 244352;
 Fri, 10 Dec 2021 22:18:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoE4-0005LK-5k
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:48 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 238aab9a-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 238aab9a-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221642.869015045@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=IBbfy8DUMmeX2/DxJ4bxtqprC0vLuk1jWkG3suZ0PZw=;
	b=qC+ywncigd88uX881G7drnWnPitC8LQEDjIxWICRbmx1CnZuuhH2HOM78Mj73Xd+ZCv0Kb
	ncvkjbnzAtbd+ixrpTmp/mZ4pThJranbywfqMLopOdcOEGpsPc6uk3V8xaldwObLZfsa/F
	EQ9V2dZmFKR1bqfNssiazFt8n3Mf+7q1vPMaTRADEfAyYuxcvDch8l/qTyx/UZYaRnEdfG
	107k2ftTZl52fiKXc5XfVwoW5s/CdJw8zCMdv0ss6LKqyYgeRXX/LiA2+XXHlrLhd7JdKS
	+inOsrufS8ZmeqDmP1k3/yTr0mCeJApmaMV52ZYaBfM4TpXhGFC+GjjHRExr/A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=IBbfy8DUMmeX2/DxJ4bxtqprC0vLuk1jWkG3suZ0PZw=;
	b=5lxdmWfE59j3yHf4IXX2tpXuGGPaN2BKbOiQcB9ippOtvBNy75YsOs7y6x5FiIbDSi4ZaA
	+C6w+xOR5nRMXFBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Date: Fri, 10 Dec 2021 23:18:43 +0100 (CET)

VGhpcyBpcyB0aGUgc2Vjb25kIHBhcnQgb2YgW1BDSV1NU0kgcmVmYWN0b3Jpbmcgd2hpY2ggYWlt
cyB0byBwcm92aWRlIHRoZQphYmlsaXR5IG9mIGV4cGFuZGluZyBNU0ktWCB2ZWN0b3JzIGFmdGVy
IGVuYWJsaW5nIE1TSS1YLgoKVGhpcyBpcyBiYXNlZCBvbiB0aGUgZmlyc3QgcGFydCBvZiB0aGlz
IHdvcmsgd2hpY2ggY2FuIGJlIGZvdW5kIGhlcmU6CgogICAgaHR0cHM6Ly9sb3JlLmtlcm5lbC5v
cmcvci8yMDIxMTIwNjIxMDE0Ny44NzI4NjU4MjNAbGludXRyb25peC5kZQoKYW5kIGhhcyBiZWVu
IGFwcGxpZWQgdG86CgogICAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2Vy
bmVsL2dpdC90aXAvdGlwLmdpdCBpcnEvbXNpCgoKVGhpcyBzZWNvbmQgcGFydCBoYXMgdGhlIGZv
bGxvd2luZyBpbXBvcnRhbnQgY2hhbmdlczoKCiAgIDEpIENsZWFudXAgb2YgdGhlIE1TSSByZWxh
dGVkIGRhdGEgaW4gc3RydWN0IGRldmljZQoKICAgICAgc3RydWN0IGRldmljZSBjb250YWlucyBh
dCB0aGUgbW9tZW50IHZhcmlvdXMgTVNJIHJlbGF0ZWQgcGFydHMuIFNvbWUKICAgICAgb2YgdGhl
bSAodGhlIGlycSBkb21haW4gcG9pbnRlcikgY2Fubm90IGJlIG1vdmVkIG91dCwgYnV0IHRoZSBy
ZXN0CiAgICAgIGNhbiBiZSBhbGxvY2F0ZWQgb24gZmlyc3QgdXNlLiBUaGlzIGlzIGluIHByZXBh
cmF0aW9uIG9mIGFkZGluZyBtb3JlCiAgICAgIHBlciBkZXZpY2UgTVNJIGRhdGEgbGF0ZXIgb24u
CgogICAyKSBDb25zb2xpZGF0aW9uIG9mIHN5c2ZzIGhhbmRsaW5nCgogICAgICBBcyBhIGZpcnN0
IHN0ZXAgdGhpcyBtb3ZlcyB0aGUgc3lzZnMgcG9pbnRlciBmcm9tIHN0cnVjdCBtc2lfZGVzYwog
ICAgICBpbnRvIHRoZSBuZXcgcGVyIGRldmljZSBNU0kgZGF0YSBzdHJ1Y3R1cmUgd2hlcmUgaXQg
YmVsb25ncy4KCiAgICAgIExhdGVyIGNoYW5nZXMgd2lsbCBjbGVhbnVwIHRoaXMgY29kZSBmdXJ0
aGVyLCBidXQgdGhhdCdzIG5vdCBwb3NzaWJsZQogICAgICBhdCB0aGlzIHBvaW50LgoKICAgMykg
VXNlIFBDSSBkZXZpY2UgcHJvcGVydGllcyBpbnN0ZWFkIG9mIGxvb2tpbmcgdXAgTVNJIGRlc2Ny
aXB0b3JzIGFuZAogICAgICBhbmFseXNpbmcgdGhlaXIgZGF0YS4KCiAgIDQpIFByb3ZpZGUgYSBm
dW5jdGlvbiB0byByZXRyaWV2ZSB0aGUgTGludXggaW50ZXJydXB0IG51bWJlciBmb3IgYSBnaXZl
bgogICAgICBNU0kgaW5kZXggc2ltaWxhciB0byBwY2lfaXJxX3ZlY3RvcigpIGFuZCBjbGVhbnVw
IGFsbCBvcGVuIGNvZGVkCiAgICAgIHZhcmlhbnRzLgoKSXQncyBhbHNvIGF2YWlsYWJsZSBmcm9t
IGdpdDoKCiAgICAgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0
L3RnbHgvZGV2ZWwuZ2l0IG1zaS12My1wYXJ0LTIKClBhcnQgMyBvZiB0aGlzIGVmZm9ydCBpcyBh
dmFpbGFibGUgb24gdG9wCgogICAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv
a2VybmVsL2dpdC90Z2x4L2RldmVsLmdpdCBtc2ktdjMtcGFydC0zCgogICAgIFBhcnQgMyBpcyBu
b3QgZ29pbmcgdG8gYmUgcmVwb3N0ZWQgYXMgdGhlcmUgaXMgbm8gY2hhbmdlIHZzLiBWMi4KClYy
IG9mIHBhcnQgMiBjYW4gYmUgZm91bmQgaGVyZToKCiAgICBodHRwczovL2xvcmUua2VybmVsLm9y
Zy9yLzIwMjExMjA2MjEwMzA3LjYyNTExNjI1M0BsaW51dHJvbml4LmRlCgpDaGFuZ2VzIHZlcnN1
cyBWMjoKCiAgLSBVc2UgUENJIGRldmljZSBwcm9wZXJ0aWVzIGluc3RlYWQgb2YgY3JlYXRpbmcg
YSBuZXcgc2V0IC0gSmFzb24KCiAgLSBQaWNrZWQgdXAgUmV2aWV3ZWQvVGVzdGVkL0Fja2VkLWJ5
IHRhZ3MgYXMgYXBwcm9wcmlhdGUKClRoYW5rcywKCgl0Z2x4Ci0tLQogYXJjaC9wb3dlcnBjL3Bs
YXRmb3Jtcy9jZWxsL2F4b25fbXNpLmMgICAgICAgICAgICAgIHwgICAgNSAKIGFyY2gvcG93ZXJw
Yy9wbGF0Zm9ybXMvcHNlcmllcy9tc2kuYyAgICAgICAgICAgICAgICB8ICAgMzggKy0tLQogYXJj
aC94ODYva2VybmVsL2FwaWMvbXNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNSAK
IGFyY2gveDg2L3BjaS94ZW4uYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg
MTEgLQogZHJpdmVycy9iYXNlL3BsYXRmb3JtLW1zaS5jICAgICAgICAgICAgICAgICAgICAgICAg
IHwgIDE1MiArKysrKysrKy0tLS0tLS0tLS0tCiBkcml2ZXJzL2J1cy9mc2wtbWMvZHByYy1kcml2
ZXIuYyAgICAgICAgICAgICAgICAgICAgfCAgICA4IC0KIGRyaXZlcnMvYnVzL2ZzbC1tYy9mc2wt
bWMtYWxsb2NhdG9yLmMgICAgICAgICAgICAgICB8ICAgIDkgLQogZHJpdmVycy9idXMvZnNsLW1j
L2ZzbC1tYy1tc2kuYyAgICAgICAgICAgICAgICAgICAgIHwgICAyNiArLS0KIGRyaXZlcnMvZG1h
L212X3hvcl92Mi5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgLS0KIGRyaXZl
cnMvZG1hL3Fjb20vaGlkbWEuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgNDQgKyst
LS0KIGRyaXZlcnMvZG1hL3RpL2szLXVkbWEtcHJpdmF0ZS5jICAgICAgICAgICAgICAgICAgICB8
ICAgIDYgCiBkcml2ZXJzL2RtYS90aS9rMy11ZG1hLmMgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgfCAgIDE0IC0KIGRyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMg
ICAgICAgICB8ICAgMjMgLS0KIGRyaXZlcnMvaXJxY2hpcC9pcnEtbWJpZ2VuLmMgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgIDQgCiBkcml2ZXJzL2lycWNoaXAvaXJxLW12ZWJ1LWljdS5jICAg
ICAgICAgICAgICAgICAgICAgfCAgIDEyIC0KIGRyaXZlcnMvaXJxY2hpcC9pcnEtdGktc2NpLWlu
dGEuYyAgICAgICAgICAgICAgICAgICB8ICAgIDIgCiBkcml2ZXJzL21haWxib3gvYmNtLWZsZXhy
bS1tYWlsYm94LmMgICAgICAgICAgICAgICAgfCAgICA5IC0KIGRyaXZlcnMvbmV0L2V0aGVybmV0
L2ZyZWVzY2FsZS9kcGFhMi9kcGFhMi1ldGguYyAgICB8ICAgIDQgCiBkcml2ZXJzL25ldC9ldGhl
cm5ldC9mcmVlc2NhbGUvZHBhYTIvZHBhYTItcHRwLmMgICAgfCAgICA0IAogZHJpdmVycy9uZXQv
ZXRoZXJuZXQvZnJlZXNjYWxlL2RwYWEyL2RwYWEyLXN3aXRjaC5jIHwgICAgNSAKIGRyaXZlcnMv
cGNpL21zaS9pcnFkb21haW4uYyAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjAgKysKIGRy
aXZlcnMvcGNpL21zaS9sZWdhY3kuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDYg
CiBkcml2ZXJzL3BjaS9tc2kvbXNpLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg
MTMzICsrKysrKy0tLS0tLS0tLS0KIGRyaXZlcnMvcGNpL3hlbi1wY2lmcm9udC5jICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgIDIgCiBkcml2ZXJzL3BlcmYvYXJtX3NtbXV2M19wbXUuYyAg
ICAgICAgICAgICAgICAgICAgICAgfCAgICA1IAogZHJpdmVycy9zb2MvZnNsL2RwaW8vZHBpby1k
cml2ZXIuYyAgICAgICAgICAgICAgICAgIHwgICAgOCAtCiBkcml2ZXJzL3NvYy90aS9rMy1yaW5n
YWNjLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA2IAogZHJpdmVycy9zb2MvdGkvdGlf
c2NpX2ludGFfbXNpLmMgICAgICAgICAgICAgICAgICAgIHwgICAyMiAtLQogZHJpdmVycy92Zmlv
L2ZzbC1tYy92ZmlvX2ZzbF9tY19pbnRyLmMgICAgICAgICAgICAgIHwgICAgNCAKIGluY2x1ZGUv
bGludXgvZGV2aWNlLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMjUgKystCiBp
bmNsdWRlL2xpbnV4L2ZzbC9tYy5oICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA0
IAogaW5jbHVkZS9saW51eC9tc2kuaCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg
ICA5NSArKysrLS0tLS0tLS0KIGluY2x1ZGUvbGludXgvcGNpLmggICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICB8ICAgIDEgCiBpbmNsdWRlL2xpbnV4L3NvYy90aS90aV9zY2lfaW50YV9t
c2kuaCAgICAgICAgICAgICAgfCAgICAxIAoga2VybmVsL2lycS9tc2kuYyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgIDE1OCArKysrKysrKysrKysrKystLS0tLQogMzUgZmls
ZXMgY2hhbmdlZCwgNDI5IGluc2VydGlvbnMoKyksIDQ1OCBkZWxldGlvbnMoLSkKCg==


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244358.422707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoED-0007KM-Me; Fri, 10 Dec 2021 22:18:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244358.422707; Fri, 10 Dec 2021 22:18:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoED-0007Ji-Eh; Fri, 10 Dec 2021 22:18:57 +0000
Received: by outflank-mailman (input) for mailman id 244358;
 Fri, 10 Dec 2021 22:18:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEB-0005LR-SC
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:56 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2980cb44-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:18:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2980cb44-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.617178827@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174734;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=c/XqPp4te0pGFEO121hhae+RVpBGIyhacVujKOuJMfc=;
	b=c9kLrkEE4SZLzTdO73+YczGJvawG4Gf3p3TUiTiMwo54SU/QEOeY2nx7mZLN9uN6JdMrva
	rjs/bftb9qpy6W5cncJBSTQQzH57vMtE2RJs/pOQte/5cAgqpv801V+Tk5+ZKjxDBWSPka
	aU966ak4VZQfVbIHcgDfWLfkiY5iiJno0fGYqzsPNazKyDctL82sOMpo79N6Hsn4CZByDM
	EC8LIrUHzK2NzKTpO7du4uU4vQTrEuwaK3AAC5Acp1jCxge80UiPnPbkSGjXnORjX63pGO
	DJMHiZOr3/B6zDq6uxlq0XYpf6ESjVsWEEvFs1wQ6cty7jHTVWuos4fJy1e1Qg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174734;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=c/XqPp4te0pGFEO121hhae+RVpBGIyhacVujKOuJMfc=;
	b=r0mvGgHyMEnHD4S+QN87CZIaHBk1HZRFCOJ4fgFQslfgfSFuxSwl3fgnaESHLdEse+PmeN
	wm9h29SwPoz5xODg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 07/35] device: Move MSI related data into a struct
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:54 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

The only unconditional part of MSI data in struct device is the irqdomain
pointer. Everything else can be allocated on demand. Create a data
structure and move the irqdomain pointer into it. The other MSI specific
parts are going to be removed from struct device in later steps.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

---
 drivers/base/platform-msi.c                 |   12 ++++++------
 drivers/dma/ti/k3-udma.c                    |    4 ++--
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |    2 +-
 drivers/irqchip/irq-mvebu-icu.c             |    6 +++---
 drivers/soc/ti/k3-ringacc.c                 |    4 ++--
 drivers/soc/ti/ti_sci_inta_msi.c            |    2 +-
 include/linux/device.h                      |   20 ++++++++++++++------
 7 files changed, 29 insertions(+), 21 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -210,10 +210,10 @@ platform_msi_alloc_priv_data(struct devi
 	 * accordingly (which would impact the max number of MSI
 	 * capable devices).
 	 */
-	if (!dev->msi_domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
+	if (!dev->msi.domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
 		return ERR_PTR(-EINVAL);
 
-	if (dev->msi_domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
+	if (dev->msi.domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
 		dev_err(dev, "Incompatible msi_domain, giving up\n");
 		return ERR_PTR(-EINVAL);
 	}
@@ -269,7 +269,7 @@ int platform_msi_domain_alloc_irqs(struc
 	if (err)
 		goto out_free_priv_data;
 
-	err = msi_domain_alloc_irqs(dev->msi_domain, dev, nvec);
+	err = msi_domain_alloc_irqs(dev->msi.domain, dev, nvec);
 	if (err)
 		goto out_free_desc;
 
@@ -282,7 +282,7 @@ int platform_msi_domain_alloc_irqs(struc
 	return 0;
 
 out_free_irqs:
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
@@ -306,7 +306,7 @@ void platform_msi_domain_free_irqs(struc
 		platform_msi_free_priv_data(desc->platform.msi_priv_data);
 	}
 
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 	platform_msi_free_descs(dev, 0, MAX_DEV_MSIS);
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_free_irqs);
@@ -354,7 +354,7 @@ struct irq_domain *
 		return NULL;
 
 	data->host_data = host_data;
-	domain = irq_domain_create_hierarchy(dev->msi_domain, 0,
+	domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
 					     is_tree ? 0 : nvec,
 					     dev->fwnode, ops, data);
 	if (!domain)
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -5279,9 +5279,9 @@ static int udma_probe(struct platform_de
 	if (IS_ERR(ud->ringacc))
 		return PTR_ERR(ud->ringacc);
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_err(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3170,7 +3170,7 @@ static void arm_smmu_setup_msis(struct a
 	if (!(smmu->features & ARM_SMMU_FEAT_MSI))
 		return;
 
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_info(smmu->dev, "msi_domain absent - falling back to wired irqs\n");
 		return;
 	}
--- a/drivers/irqchip/irq-mvebu-icu.c
+++ b/drivers/irqchip/irq-mvebu-icu.c
@@ -314,12 +314,12 @@ static int mvebu_icu_subset_probe(struct
 		msi_data->subset_data = of_device_get_match_data(dev);
 	}
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_PLATFORM_MSI);
-	if (!dev->msi_domain)
+	if (!dev->msi.domain)
 		return -EPROBE_DEFER;
 
-	msi_parent_dn = irq_domain_get_of_node(dev->msi_domain);
+	msi_parent_dn = irq_domain_get_of_node(dev->msi.domain);
 	if (!msi_parent_dn)
 		return -ENODEV;
 
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -1356,9 +1356,9 @@ static int k3_ringacc_init(struct platfo
 	struct resource *res;
 	int ret, i;
 
-	dev->msi_domain = of_msi_get_domain(dev, dev->of_node,
+	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
-	if (!dev->msi_domain) {
+	if (!dev->msi.domain) {
 		dev_err(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -140,7 +140,7 @@ EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain
 
 void ti_sci_inta_msi_domain_free_irqs(struct device *dev)
 {
-	msi_domain_free_irqs(dev->msi_domain, dev);
+	msi_domain_free_irqs(dev->msi.domain, dev);
 	ti_sci_inta_msi_free_descs(dev);
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -372,6 +372,16 @@ struct dev_links_info {
 };
 
 /**
+ * struct dev_msi_info - Device data related to MSI
+ * @domain:	The MSI interrupt domain associated to the device
+ */
+struct dev_msi_info {
+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+	struct irq_domain	*domain;
+#endif
+};
+
+/**
  * struct device - The basic device structure
  * @parent:	The device's "parent" device, the device to which it is attached.
  * 		In most cases, a parent device is some sort of bus or host
@@ -407,8 +417,8 @@ struct dev_links_info {
  * @em_pd:	device's energy model performance domain
  * @pins:	For device pin management.
  *		See Documentation/driver-api/pin-control.rst for details.
+ * @msi:	MSI related data
  * @msi_list:	Hosts MSI descriptors
- * @msi_domain: The generic MSI domain this device is using.
  * @numa_node:	NUMA node this device is close to.
  * @dma_ops:    DMA mapping operations for this device.
  * @dma_mask:	Dma mask (if dma'ble device).
@@ -500,12 +510,10 @@ struct device {
 	struct em_perf_domain	*em_pd;
 #endif
 
-#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	struct irq_domain	*msi_domain;
-#endif
 #ifdef CONFIG_PINCTRL
 	struct dev_pin_info	*pins;
 #endif
+	struct dev_msi_info	msi;
 #ifdef CONFIG_GENERIC_MSI_IRQ
 	struct list_head	msi_list;
 #endif
@@ -666,7 +674,7 @@ static inline void set_dev_node(struct d
 static inline struct irq_domain *dev_get_msi_domain(const struct device *dev)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	return dev->msi_domain;
+	return dev->msi.domain;
 #else
 	return NULL;
 #endif
@@ -675,7 +683,7 @@ static inline struct irq_domain *dev_get
 static inline void dev_set_msi_domain(struct device *dev, struct irq_domain *d)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	dev->msi_domain = d;
+	dev->msi.domain = d;
 #endif
 }
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:18:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:18:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244359.422717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEF-0007f6-8A; Fri, 10 Dec 2021 22:18:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244359.422717; Fri, 10 Dec 2021 22:18:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEF-0007ef-0A; Fri, 10 Dec 2021 22:18:59 +0000
Received: by outflank-mailman (input) for mailman id 244359;
 Fri, 10 Dec 2021 22:18:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoED-0005LK-9f
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:57 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2a59745b-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2a59745b-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221813.676660809@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174736;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=p0CEuniGVD/vlSD2Fd4mo52TznQAMRoSID0Sm2FVZu8=;
	b=n2s1uJk2XLnn3q/65Q5CrHyLj/4eIkBuDnUXjKfvDdEkXIQAVhgrtNniBJgeNBBeEVK8WP
	3E7ubu/sWhKpoeZLhX9MdGDvwf2AySwJvHs/79xoeFcHBpy5ond56xY09RrcRU4yl65sf2
	On9c13AM0+oKSQXe00/zvf0Ks0BgKdWHVE6bTlsJTFPJjil5KpBKd5ilISnzcjJZ9CMzo9
	g0xxvVb97eNNSaqP/OovaxrVT6K8rOQGOlGcPPac0rbY6spkjNIEyNoM/REkTrWoGYS4fn
	ILtghYvxX3QAIhmr759JmbEMg6QNZ8UfTN3qUoaj7g9gNiuVsRDbOTd7IIzE5Q==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174736;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=p0CEuniGVD/vlSD2Fd4mo52TznQAMRoSID0Sm2FVZu8=;
	b=zhgOEeEWgyS9usG6W9uHpuhsscfbHbM2ZMw8+DHKOUDQaF6OiHOi+rB1GbyoR+ygezP0WN
	J/NyrFyVzR5cUZAA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 08/35] device: Add device:: Msi_data pointer and struct
 msi_device_data
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:55 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Create struct msi_device_data and add a pointer of that type to struct
dev_msi_info, which is part of struct device. Provide an allocator function
which can be invoked from the MSI interrupt allocation code pathes.

Add a properties field to the data structure as a first member so the
allocation size is not zero bytes. The field will be uses later on.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/device.h |    5 +++++
 include/linux/msi.h    |   18 ++++++++++++++++++
 kernel/irq/msi.c       |   32 ++++++++++++++++++++++++++++++++
 3 files changed, 55 insertions(+)

--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -45,6 +45,7 @@ struct iommu_ops;
 struct iommu_group;
 struct dev_pin_info;
 struct dev_iommu;
+struct msi_device_data;
 
 /**
  * struct subsys_interface - interfaces to device functions
@@ -374,11 +375,15 @@ struct dev_links_info {
 /**
  * struct dev_msi_info - Device data related to MSI
  * @domain:	The MSI interrupt domain associated to the device
+ * @data:	Pointer to MSI device data
  */
 struct dev_msi_info {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 	struct irq_domain	*domain;
 #endif
+#ifdef CONFIG_GENERIC_MSI_IRQ
+	struct msi_device_data	*data;
+#endif
 };
 
 /**
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -171,6 +171,16 @@ struct msi_desc {
 	};
 };
 
+/**
+ * msi_device_data - MSI per device data
+ * @properties:		MSI properties which are interesting to drivers
+ */
+struct msi_device_data {
+	unsigned long			properties;
+};
+
+int msi_setup_device_data(struct device *dev);
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi_list)
@@ -233,10 +243,16 @@ void pci_msi_mask_irq(struct irq_data *d
 void pci_msi_unmask_irq(struct irq_data *data);
 
 #ifdef CONFIG_SYSFS
+int msi_device_populate_sysfs(struct device *dev);
+void msi_device_destroy_sysfs(struct device *dev);
+
 const struct attribute_group **msi_populate_sysfs(struct device *dev);
 void msi_destroy_sysfs(struct device *dev,
 		       const struct attribute_group **msi_irq_groups);
 #else
+static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
+static inline void msi_device_destroy_sysfs(struct device *dev) { }
+
 static inline const struct attribute_group **msi_populate_sysfs(struct device *dev)
 {
 	return NULL;
@@ -384,6 +400,8 @@ enum {
 	MSI_FLAG_MUST_REACTIVATE	= (1 << 5),
 	/* Is level-triggered capable, using two messages */
 	MSI_FLAG_LEVEL_CAPABLE		= (1 << 6),
+	/* Populate sysfs on alloc() and destroy it on free() */
+	MSI_FLAG_DEV_SYSFS		= (1 << 7),
 };
 
 int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -73,6 +73,38 @@ void get_cached_msi_msg(unsigned int irq
 }
 EXPORT_SYMBOL_GPL(get_cached_msi_msg);
 
+static void msi_device_data_release(struct device *dev, void *res)
+{
+	WARN_ON_ONCE(!list_empty(&dev->msi_list));
+	dev->msi.data = NULL;
+}
+
+/**
+ * msi_setup_device_data - Setup MSI device data
+ * @dev:	Device for which MSI device data should be set up
+ *
+ * Return: 0 on success, appropriate error code otherwise
+ *
+ * This can be called more than once for @dev. If the MSI device data is
+ * already allocated the call succeeds. The allocated memory is
+ * automatically released when the device is destroyed.
+ */
+int msi_setup_device_data(struct device *dev)
+{
+	struct msi_device_data *md;
+
+	if (dev->msi.data)
+		return 0;
+
+	md = devres_alloc(msi_device_data_release, sizeof(*md), GFP_KERNEL);
+	if (!md)
+		return -ENOMEM;
+
+	dev->msi.data = md;
+	devres_add(dev, md);
+	return 0;
+}
+
 #ifdef CONFIG_SYSFS
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244360.422722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEG-0007lx-28; Fri, 10 Dec 2021 22:19:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244360.422722; Fri, 10 Dec 2021 22:19:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEF-0007kM-OB; Fri, 10 Dec 2021 22:18:59 +0000
Received: by outflank-mailman (input) for mailman id 244360;
 Fri, 10 Dec 2021 22:18:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEE-0005LR-KQ
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:18:58 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2b47f3c4-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:18:58 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2b47f3c4-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.740644351@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174737;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lone/RHMXjlrVHw4SO3cyBPgNXO7SR/kjpngIvo8KXc=;
	b=pLlvWRgJJR/FozuPSZc/p3nSaSDVV9NbBY8rkEojQLKfzboZJPgEZ0QGJxryfOxb5vJXjW
	eBBPB65jIQk9+B1THMlYp0yGqF4rL2yHG62KFDRr14BUWKIF7M20mar760FwMkfrQzvRuP
	frt5N2PJ/xGqaTeQW8wTK+U8KkAFAKd4htcwQHlE2SrL5D3xqkdUSaNO3M42Mz14vtKiDQ
	1TvZXJXtRgeoEBKeHM0ubuCWIcCUGNAV2hTbvSlYDalKpRKK8q1fk2cI4lSaaA29ziMele
	UAn5OHfmJCIJKFGNS3y69IG1bpP8yT509O8M0KnFnRnGtN/0Sp9b4mWVngiMzQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174737;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=lone/RHMXjlrVHw4SO3cyBPgNXO7SR/kjpngIvo8KXc=;
	b=fGZcqe6WqEa09T04QnEG0wFvQt+EXzqvmqvVYXhxq4JPl8Xl8WUjUPXH0+2Own5rPSRrGs
	rNikqidmCczP5lBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 09/35] PCI/MSI: Allocate MSI device data on first use
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:57 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Allocate MSI device data on first use, i.e. when a PCI driver invokes one
of the PCI/MSI enablement functions.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/msi/msi.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -900,10 +900,12 @@ static int __pci_enable_msi_range(struct
 /* deprecated, don't use */
 int pci_enable_msi(struct pci_dev *dev)
 {
-	int rc = __pci_enable_msi_range(dev, 1, 1, NULL);
-	if (rc < 0)
-		return rc;
-	return 0;
+	int rc = msi_setup_device_data(&dev->dev);
+
+	if (!rc)
+		rc = __pci_enable_msi_range(dev, 1, 1, NULL);
+
+	return rc < 0 ? rc : 0;
 }
 EXPORT_SYMBOL(pci_enable_msi);
 
@@ -958,7 +960,11 @@ static int __pci_enable_msix_range(struc
 int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
 		int minvec, int maxvec)
 {
-	return __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
+	int ret = msi_setup_device_data(&dev->dev);
+
+	if (!ret)
+		ret = __pci_enable_msix_range(dev, entries, minvec, maxvec, NULL, 0);
+	return ret;
 }
 EXPORT_SYMBOL(pci_enable_msix_range);
 
@@ -985,8 +991,12 @@ int pci_alloc_irq_vectors_affinity(struc
 				   struct irq_affinity *affd)
 {
 	struct irq_affinity msi_default_affd = {0};
+	int ret = msi_setup_device_data(&dev->dev);
 	int nvecs = -ENOSPC;
 
+	if (ret)
+		return ret;
+
 	if (flags & PCI_IRQ_AFFINITY) {
 		if (!affd)
 			affd = &msi_default_affd;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244361.422739 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEI-0008OD-TR; Fri, 10 Dec 2021 22:19:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244361.422739; Fri, 10 Dec 2021 22:19:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEI-0008Me-DU; Fri, 10 Dec 2021 22:19:02 +0000
Received: by outflank-mailman (input) for mailman id 244361;
 Fri, 10 Dec 2021 22:19:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEG-0005LK-Bl
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:00 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2c47e715-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:18:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2c47e715-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221813.805529729@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174739;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=AIipdYHJdw47YEIR3ibDM4/EuKIZd0bBkHdL069vGOQ=;
	b=j1D2L9Q78IUwnll6n5rxMGVu2mITgI1fie6htejXwkZkBu5vKvBCoSC0hybtM8CIndzeKy
	8FxbvyCsSWDO1Je5QzsKaI/JE7U3VHAG33NrckGM8Jh90EVfjx9LVyCBsKiWw/5ODWbyNU
	kojl0x/4/PVaVVmvviwmUOctKhNCi3chDZvokC+2bV6jT+/MGWHy2QTxSbgq5bJLTS0oc3
	WunwiNoKKzPpL872PSd/7Fh8pFZgVkBASgKwd3jLaDi5pE0MyQTn5hNy8f1JZB6aEnheiK
	IXKzSIcv8qTnf/i+HWAfLXKhChF87Qp+8borfTOdx+L3rIKkbAniU7i2NTkEuA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174739;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=AIipdYHJdw47YEIR3ibDM4/EuKIZd0bBkHdL069vGOQ=;
	b=iR9CZQZxt9DwiDQaI1OMnpL3qc51lhNFwI0XGQkIVGuIAxEp7I6QmDjeueiB5NSx48DEzo
	NTxgjLao7vpldkAw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 10/35] platform-msi: Allocate MSI device data on first use
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:18:58 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Allocate the MSI device data on first invocation of the allocation function
for platform MSI private data.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -204,6 +204,8 @@ platform_msi_alloc_priv_data(struct devi
 			     irq_write_msi_msg_t write_msi_msg)
 {
 	struct platform_msi_priv_data *datap;
+	int err;
+
 	/*
 	 * Limit the number of interrupts to 2048 per device. Should we
 	 * need to bump this up, DEV_ID_SHIFT should be adjusted
@@ -218,6 +220,10 @@ platform_msi_alloc_priv_data(struct devi
 		return ERR_PTR(-EINVAL);
 	}
 
+	err = msi_setup_device_data(dev);
+	if (err)
+		return ERR_PTR(err);
+
 	/* Already had a helping of MSI? Greed... */
 	if (!list_empty(dev_to_msi_list(dev)))
 		return ERR_PTR(-EBUSY);
@@ -229,7 +235,7 @@ platform_msi_alloc_priv_data(struct devi
 	datap->devid = ida_simple_get(&platform_msi_devid_ida,
 				      0, 1 << DEV_ID_SHIFT, GFP_KERNEL);
 	if (datap->devid < 0) {
-		int err = datap->devid;
+		err = datap->devid;
 		kfree(datap);
 		return ERR_PTR(err);
 	}



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244362.422744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEL-0000JT-5D; Fri, 10 Dec 2021 22:19:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244362.422744; Fri, 10 Dec 2021 22:19:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEK-0000Dt-FR; Fri, 10 Dec 2021 22:19:04 +0000
Received: by outflank-mailman (input) for mailman id 244362;
 Fri, 10 Dec 2021 22:19:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEH-0005LR-R2
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:01 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d2ba74f-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d2ba74f-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.867985931@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174740;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Y82OSyHV4tCeBzBC1rgQ8/N8FaTKISWwv/0ho8RVhuc=;
	b=2lSBrqL7tZdnQovckLcRFs+zUPITNEnJXtT+2t/rF3/6USo+oM3rVzWI5tmzBuF8v+fTql
	Y/WOe+crXeCISzmidHrjHzy1/dM/bLhEGF6X78s2KO5zgtoADPazF6hbJHmZc83RIDEZ+U
	S3NcKAlmaR7iXrlw0Wyt7MQ+5GzK/qAHQuSapmDPvqVfsc0Ygv0gok/KxyDWalxpEjwiij
	lOyBs1cQWG/UTyGJS+ODHvhGY9UGVMnlFBi1jRxRIBXX9aHbQyi5XmvGDAjr3NZ0MZ2nHe
	FZdyKYem/VTlhxHFL6icdY/Lr7wgeJS28HmRZY5DnE4kXSdKV/5/4F5fOjnGqw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174740;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=Y82OSyHV4tCeBzBC1rgQ8/N8FaTKISWwv/0ho8RVhuc=;
	b=AmDRzUTHc7jg0q3On78/vfF7TTqillkRcjofWpZD4PcjdOpOL/P4qxmwngleQjhYBtmCNP
	dxdvwJMQPD35dMCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V3 11/35] bus: fsl-mc-msi: Allocate MSI device data on first use
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:00 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Allocate the MSI device data on first invocation of the allocation function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/bus/fsl-mc/fsl-mc-msi.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -253,6 +253,14 @@ int fsl_mc_msi_domain_alloc_irqs(struct
 	struct irq_domain *msi_domain;
 	int error;
 
+	msi_domain = dev_get_msi_domain(dev);
+	if (!msi_domain)
+		return -EINVAL;
+
+	error = msi_setup_device_data(dev);
+	if (error)
+		return error;
+
 	if (!list_empty(dev_to_msi_list(dev)))
 		return -EINVAL;
 
@@ -260,12 +268,6 @@ int fsl_mc_msi_domain_alloc_irqs(struct
 	if (error < 0)
 		return error;
 
-	msi_domain = dev_get_msi_domain(dev);
-	if (!msi_domain) {
-		error = -EINVAL;
-		goto cleanup_msi_descs;
-	}
-
 	/*
 	 * NOTE: Calling this function will trigger the invocation of the
 	 * its_fsl_mc_msi_prepare() callback



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244363.422754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEO-0000qY-1o; Fri, 10 Dec 2021 22:19:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244363.422754; Fri, 10 Dec 2021 22:19:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEM-0000kg-Vl; Fri, 10 Dec 2021 22:19:07 +0000
Received: by outflank-mailman (input) for mailman id 244363;
 Fri, 10 Dec 2021 22:19:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEJ-0005LR-G5
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:03 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2e1a1abd-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e1a1abd-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.928842960@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=QlSfKOBDbr45C76IAsibYWGajwRrbHzT4oR8MTMol6A=;
	b=KpnJbo94PqafiDuB6cPP3ZG9y5TYJIE/BqRjDQ0OMl+P5klfpfRI7MUpyeTBzsKPc5S7kh
	7p3bE4N4UClxyjVm4RQXGQBoUIlrUzhcVfp1xJrqCvGQODcFtaL8VLk9npWo2+QOK7o5tV
	b8D7JRJxi5hLB8IALGYUp00MiCX/ts+z5R21QKQl8nIuInb4hpSIHrSWUplo5op0d61N1y
	RIhRFc5a7u4PREveCUA5ts1KCb929sEyBGYy7dGh0DMVlgqH0fqqZWZBKpVtc2K6Bc9eC1
	SblHiCzRFrs/1DG8/HPJfiG3/K2bxSPCdWYGZWDWrbuFk9vApUEdyDOw8IUSng==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=QlSfKOBDbr45C76IAsibYWGajwRrbHzT4oR8MTMol6A=;
	b=UgAZcMDwKNxLIdU8MxFmR1DNd/e2mpKEkmAj2dgcbgZL095ScwRy/HwPdGnfG/reYRKINs
	E5jUy+5K8dMLKvAQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 12/35] soc: ti: ti_sci_inta_msi: Allocate MSI device data
 on first use
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:01 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Allocate the MSI device data on first invocation of the allocation function.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/soc/ti/ti_sci_inta_msi.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -120,6 +120,10 @@ int ti_sci_inta_msi_domain_alloc_irqs(st
 	if (pdev->id < 0)
 		return -ENODEV;
 
+	ret = msi_setup_device_data(dev);
+	if (ret)
+		return ret;
+
 	nvec = ti_sci_inta_msi_alloc_descs(dev, res);
 	if (nvec <= 0)
 		return nvec;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244364.422761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEP-00017F-RL; Fri, 10 Dec 2021 22:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244364.422761; Fri, 10 Dec 2021 22:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoEO-00011D-GE; Fri, 10 Dec 2021 22:19:08 +0000
Received: by outflank-mailman (input) for mailman id 244364;
 Fri, 10 Dec 2021 22:19:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEL-0005LR-1R
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:05 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2f0af0de-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:04 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2f0af0de-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221813.988659194@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174744;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=oE2eGYCYBsqhTiqWwROCSzBN1PHvDBTxc4ApBbpWErQ=;
	b=Du2AaeyfQ64dP3dBs4P+iX/eFtTtuCyElkywg4oYr94298FnFHpAop9t86vUsn4VVyrVCl
	lGFyPgrvSs0Gr8kuj771Eh/3xQ8clx37P2uIDld9f7h+STIe4QjMB1lNIq8aFa6qmzcjnK
	ay+m0Xlfk66F93sm9gAN9zblzf0wZsVdVR/m5/BXpezRfWcYkI8p02Y74sGyJQfgJA30nA
	rqbyJQqYND31ug87CWMo7Va00A2e5kmACGXuAKhdEYFcuBoXlbaLCxWV3+5wzPYP6RyyPz
	PWzzT0WZAAnVAI5zp20wKtXbAm26pTRbjZaW7zp6VGBl5Re0rxuPRFo21zuz0g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174744;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=oE2eGYCYBsqhTiqWwROCSzBN1PHvDBTxc4ApBbpWErQ=;
	b=CDqZUrLAr3/IbkCTIDZp0THg1iNwgAbMiICWCbxnRLGjU3FnBGAqbCSc84YSFhBleVyNIj
	Oj6FzJ0V6tLDbaAw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V3 13/35] genirq/msi: Provide msi_device_populate/destroy_sysfs()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:03 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Add new allocation functions which can be activated by domain info
flags. They store the groups pointer in struct msi_device_data.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |    4 ++++
 kernel/irq/msi.c    |   42 ++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 44 insertions(+), 2 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -56,6 +56,8 @@ struct irq_data;
 struct msi_desc;
 struct pci_dev;
 struct platform_msi_priv_data;
+struct attribute_group;
+
 void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
 #ifdef CONFIG_GENERIC_MSI_IRQ
 void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
@@ -174,9 +176,11 @@ struct msi_desc {
 /**
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
+ * @attrs:		Pointer to the sysfs attribute group
  */
 struct msi_device_data {
 	unsigned long			properties;
+	const struct attribute_group    **attrs;
 };
 
 int msi_setup_device_data(struct device *dev);
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -200,6 +200,20 @@ const struct attribute_group **msi_popul
 }
 
 /**
+ * msi_device_populate_sysfs - Populate msi_irqs sysfs entries for a device
+ * @dev:	The device (PCI, platform etc) which will get sysfs entries
+ */
+int msi_device_populate_sysfs(struct device *dev)
+{
+	const struct attribute_group **group = msi_populate_sysfs(dev);
+
+	if (IS_ERR(group))
+		return PTR_ERR(group);
+	dev->msi.data->attrs = group;
+	return 0;
+}
+
+/**
  * msi_destroy_sysfs - Destroy msi_irqs sysfs entries for devices
  * @dev:		The device(PCI, platform etc) who will remove sysfs entries
  * @msi_irq_groups:	attribute_group for device msi_irqs entries
@@ -225,6 +239,17 @@ void msi_destroy_sysfs(struct device *de
 		kfree(msi_irq_groups);
 	}
 }
+
+/**
+ * msi_device_destroy_sysfs - Destroy msi_irqs sysfs entries for a device
+ * @dev:		The device (PCI, platform etc) for which to remove
+ *			sysfs entries
+ */
+void msi_device_destroy_sysfs(struct device *dev)
+{
+	msi_destroy_sysfs(dev, dev->msi.data->attrs);
+	dev->msi.data->attrs = NULL;
+}
 #endif
 
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
@@ -672,8 +697,19 @@ int msi_domain_alloc_irqs(struct irq_dom
 {
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
+	int ret;
 
-	return ops->domain_alloc_irqs(domain, dev, nvec);
+	ret = ops->domain_alloc_irqs(domain, dev, nvec);
+	if (ret)
+		return ret;
+
+	if (!(info->flags & MSI_FLAG_DEV_SYSFS))
+		return 0;
+
+	ret = msi_device_populate_sysfs(dev);
+	if (ret)
+		msi_domain_free_irqs(domain, dev);
+	return ret;
 }
 
 void __msi_domain_free_irqs(struct irq_domain *domain, struct device *dev)
@@ -712,7 +748,9 @@ void msi_domain_free_irqs(struct irq_dom
 	struct msi_domain_info *info = domain->host_data;
 	struct msi_domain_ops *ops = info->ops;
 
-	return ops->domain_free_irqs(domain, dev);
+	if (info->flags & MSI_FLAG_DEV_SYSFS)
+		msi_device_destroy_sysfs(dev);
+	ops->domain_free_irqs(domain, dev);
 }
 
 /**



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:19:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:19:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244370.422779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoES-0002CC-Tb; Fri, 10 Dec 2021 22:19:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244370.422779; Fri, 10 Dec 2021 22:19:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoES-00028Q-B9; Fri, 10 Dec 2021 22:19:12 +0000
Received: by outflank-mailman (input) for mailman id 244370;
 Fri, 10 Dec 2021 22:19:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEP-0005LK-PR
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:09 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31cfb521-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31cfb521-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.168362229@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174748;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4+eiQosnG7JBR1uN0KlyRVrLtcLvBVvbMU+2SFmyB+o=;
	b=NSzn6eemNJ0eDNqaqfj0J4J5JGz7K56XnV9MyWe+zf1xqWyQujeFifj1x8v1csqVsCT35t
	QLOBO4/H7MoxkENiZW8/nmowd1Ubo+DfNDjfKXhl2o5H7ToEraGOyHrOB7FSOS+TO5BgjI
	biGY2JzKjzM5QxI7ropVsxtR2M+ZThlJOVZeCGTANbL7LC+fDH/Rtit9AAEpwdrpXdRGHR
	Blu5YEQSuMGWdbfsyAdjgnIWrgZEw9bO0+JWoNyUXqpHlcu5oisXl1DmuSUkUxyIqM/4ph
	QKgY3AFIQW1W1o9UcVgJRHzuXgUs4HLehTHcLW+ol5AfhGFocJkGtZD94o1FWw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174748;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=4+eiQosnG7JBR1uN0KlyRVrLtcLvBVvbMU+2SFmyB+o=;
	b=TTtSvTMz55N3aey6UgmLwPcn+vLffGKKd6RnWhYE43JcPUh8gDb277w95Yidb3WOxXOzkX
	6CrbbZQt5BdYqYDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 16/35] genirq/msi: Remove the original sysfs interfaces
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:08 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

No more users. Refactor the core code accordingly and move the global
interface under CONFIG_PCI_MSI_ARCH_FALLBACKS.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |   29 +++++++---------------------
 kernel/irq/msi.c    |   53 +++++++++++++++++++---------------------------------
 2 files changed, 28 insertions(+), 54 deletions(-)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -246,26 +246,6 @@ void __pci_write_msi_msg(struct msi_desc
 void pci_msi_mask_irq(struct irq_data *data);
 void pci_msi_unmask_irq(struct irq_data *data);
 
-#ifdef CONFIG_SYSFS
-int msi_device_populate_sysfs(struct device *dev);
-void msi_device_destroy_sysfs(struct device *dev);
-
-const struct attribute_group **msi_populate_sysfs(struct device *dev);
-void msi_destroy_sysfs(struct device *dev,
-		       const struct attribute_group **msi_irq_groups);
-#else
-static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
-static inline void msi_device_destroy_sysfs(struct device *dev) { }
-
-static inline const struct attribute_group **msi_populate_sysfs(struct device *dev)
-{
-	return NULL;
-}
-static inline void msi_destroy_sysfs(struct device *dev, const struct attribute_group **msi_irq_groups)
-{
-}
-#endif
-
 /*
  * The arch hooks to setup up msi irqs. Default functions are implemented
  * as weak symbols so that they /can/ be overriden by architecture specific
@@ -279,7 +259,14 @@ int arch_setup_msi_irq(struct pci_dev *d
 void arch_teardown_msi_irq(unsigned int irq);
 int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type);
 void arch_teardown_msi_irqs(struct pci_dev *dev);
-#endif
+#ifdef CONFIG_SYSFS
+int msi_device_populate_sysfs(struct device *dev);
+void msi_device_destroy_sysfs(struct device *dev);
+#else /* CONFIG_SYSFS */
+static inline int msi_device_populate_sysfs(struct device *dev) { return 0; }
+static inline void msi_device_destroy_sysfs(struct device *dev) { }
+#endif /* !CONFIG_SYSFS */
+#endif /* CONFIG_PCI_MSI_ARCH_FALLBACKS */
 
 /*
  * The restore hook is still available even for fully irq domain based
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -118,12 +118,8 @@ static ssize_t msi_mode_show(struct devi
 /**
  * msi_populate_sysfs - Populate msi_irqs sysfs entries for devices
  * @dev:	The device(PCI, platform etc) who will get sysfs entries
- *
- * Return attribute_group ** so that specific bus MSI can save it to
- * somewhere during initilizing msi irqs. If devices has no MSI irq,
- * return NULL; if it fails to populate sysfs, return ERR_PTR
  */
-const struct attribute_group **msi_populate_sysfs(struct device *dev)
+static const struct attribute_group **msi_populate_sysfs(struct device *dev)
 {
 	const struct attribute_group **msi_irq_groups;
 	struct attribute **msi_attrs, *msi_attr;
@@ -214,41 +210,32 @@ int msi_device_populate_sysfs(struct dev
 }
 
 /**
- * msi_destroy_sysfs - Destroy msi_irqs sysfs entries for devices
- * @dev:		The device(PCI, platform etc) who will remove sysfs entries
- * @msi_irq_groups:	attribute_group for device msi_irqs entries
- */
-void msi_destroy_sysfs(struct device *dev, const struct attribute_group **msi_irq_groups)
-{
-	struct device_attribute *dev_attr;
-	struct attribute **msi_attrs;
-	int count = 0;
-
-	if (msi_irq_groups) {
-		sysfs_remove_groups(&dev->kobj, msi_irq_groups);
-		msi_attrs = msi_irq_groups[0]->attrs;
-		while (msi_attrs[count]) {
-			dev_attr = container_of(msi_attrs[count],
-					struct device_attribute, attr);
-			kfree(dev_attr->attr.name);
-			kfree(dev_attr);
-			++count;
-		}
-		kfree(msi_attrs);
-		kfree(msi_irq_groups[0]);
-		kfree(msi_irq_groups);
-	}
-}
-
-/**
  * msi_device_destroy_sysfs - Destroy msi_irqs sysfs entries for a device
  * @dev:		The device (PCI, platform etc) for which to remove
  *			sysfs entries
  */
 void msi_device_destroy_sysfs(struct device *dev)
 {
-	msi_destroy_sysfs(dev, dev->msi.data->attrs);
+	const struct attribute_group **msi_irq_groups = dev->msi.data->attrs;
+	struct device_attribute *dev_attr;
+	struct attribute **msi_attrs;
+	int count = 0;
+
 	dev->msi.data->attrs = NULL;
+	if (!msi_irq_groups)
+		return;
+
+	sysfs_remove_groups(&dev->kobj, msi_irq_groups);
+	msi_attrs = msi_irq_groups[0]->attrs;
+	while (msi_attrs[count]) {
+		dev_attr = container_of(msi_attrs[count], struct device_attribute, attr);
+		kfree(dev_attr->attr.name);
+		kfree(dev_attr);
+		++count;
+	}
+	kfree(msi_attrs);
+	kfree(msi_irq_groups[0]);
+	kfree(msi_irq_groups);
 }
 #endif
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244390.422802 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLw-0006m3-55; Fri, 10 Dec 2021 22:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244390.422802; Fri, 10 Dec 2021 22:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLv-0006lJ-TU; Fri, 10 Dec 2021 22:26:55 +0000
Received: by outflank-mailman (input) for mailman id 244390;
 Fri, 10 Dec 2021 22:26:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEs-0005LR-VE
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:39 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4344e5c7-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:38 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4344e5c7-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221815.329792721@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174778;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=El+H3F4NXV3E+px9T1PJDDlrE0XW8D36UmPAiNafE8w=;
	b=Uy0NC+QniJEawZ4yuuEFtqIMzw9PFLBgpx0HDrRUo2md8XUl4SS73Nl7EfE819E5PtpbVc
	LAz+1cPwMJ/P73wMT+BU/i9qA4amhAWgAueMd0/fC606btT7duSv4NvM14w5Glhzh8MMt6
	Vf8SrpkxfuLKYwgK8ZgtU7FQjNQoMGjZqRjEQAW68HIHWKLNXxWyDiwhGs8MAwuo+Mw6+1
	gNzbkVQZh77bKcaEtUEDOtwWMdTwvsOeTeAuHpf0qQRNTFrf+/FLo1BbMBzYXFZsIbop/R
	ssapnQMEEzj69/QY+0rBqrGI4rNejNtgJBDAT+PK0tQBj3vgRF91DKkGdlcQHg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174778;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=El+H3F4NXV3E+px9T1PJDDlrE0XW8D36UmPAiNafE8w=;
	b=rCtZG1LYH0eCoa6arIPeivQCBnZ/C7/60VDfvadqZFSQ6CFg6eVTEQvW1V/zkV59EqrcH/
	ZMdJiiA2xvl8beBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Sinan Kaya <okaya@kernel.org>,
 dmaengine@vger.kernel.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>
Subject: [patch V3 35/35] dmaengine: qcom_hidma: Cleanup MSI handling
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:37 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

There is no reason to walk the MSI descriptors to retrieve the interrupt
number for a device. Use msi_get_virq() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Sinan Kaya <okaya@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/qcom/hidma.c |   42 ++++++++++++++++++------------------------
 1 file changed, 18 insertions(+), 24 deletions(-)

--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -678,11 +678,13 @@ static void hidma_free_msis(struct hidma
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
 	struct device *dev = dmadev->ddev.dev;
-	struct msi_desc *desc;
+	int i, virq;
 
-	/* free allocated MSI interrupts above */
-	for_each_msi_entry(desc, dev)
-		devm_free_irq(dev, desc->irq, &dmadev->lldev);
+	for (i = 0; i < HIDMA_MSI_INTS; i++) {
+		virq = msi_get_virq(dev, i);
+		if (virq)
+			devm_free_irq(dev, virq, &dmadev->lldev);
+	}
 
 	platform_msi_domain_free_irqs(dev);
 #endif
@@ -692,45 +694,37 @@ static int hidma_request_msi(struct hidm
 			     struct platform_device *pdev)
 {
 #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
-	int rc;
-	struct msi_desc *desc;
-	struct msi_desc *failed_desc = NULL;
+	int rc, i, virq;
 
 	rc = platform_msi_domain_alloc_irqs(&pdev->dev, HIDMA_MSI_INTS,
 					    hidma_write_msi_msg);
 	if (rc)
 		return rc;
 
-	for_each_msi_entry(desc, &pdev->dev) {
-		if (!desc->msi_index)
-			dmadev->msi_virqbase = desc->irq;
-
-		rc = devm_request_irq(&pdev->dev, desc->irq,
+	for (i = 0; i < HIDMA_MSI_INTS; i++) {
+		virq = msi_get_virq(&pdev->dev, i);
+		rc = devm_request_irq(&pdev->dev, virq,
 				       hidma_chirq_handler_msi,
 				       0, "qcom-hidma-msi",
 				       &dmadev->lldev);
-		if (rc) {
-			failed_desc = desc;
+		if (rc)
 			break;
-		}
+		if (!i)
+			dmadev->msi_virqbase = virq;
 	}
 
 	if (rc) {
 		/* free allocated MSI interrupts above */
-		for_each_msi_entry(desc, &pdev->dev) {
-			if (desc == failed_desc)
-				break;
-			devm_free_irq(&pdev->dev, desc->irq,
-				      &dmadev->lldev);
+		for (--i; i >= 0; i--) {
+			virq = msi_get_virq(&pdev->dev, i);
+			devm_free_irq(&pdev->dev, virq, &dmadev->lldev);
 		}
+		dev_warn(&pdev->dev,
+			 "failed to request MSI irq, falling back to wired IRQ\n");
 	} else {
 		/* Add callback to free MSIs on teardown */
 		hidma_ll_setup_irq(dmadev->lldev, true);
-
 	}
-	if (rc)
-		dev_warn(&pdev->dev,
-			 "failed to request MSI irq, falling back to wired IRQ\n");
 	return rc;
 #else
 	return -EINVAL;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244389.422796 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLv-0006iX-Pw; Fri, 10 Dec 2021 22:26:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244389.422796; Fri, 10 Dec 2021 22:26:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLv-0006iQ-LW; Fri, 10 Dec 2021 22:26:55 +0000
Received: by outflank-mailman (input) for mailman id 244389;
 Fri, 10 Dec 2021 22:26:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEP-0005LR-22
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:09 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 30e6d20e-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30e6d20e-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.109408832@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174747;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=/T/lIugtjOnyOk0TOzZkPoZByXefF1LfjuDkNv8axwo=;
	b=2rQSESBNbhKDe4DIdH7ra10NH5N/JvzQQX+r3nrmLIoKqrr9kZeroIW0ldFyNTmeGJFloC
	ISsswuI9KpOlM49GqMXH1uDQDqjLlmAlQoCaIdP7ARZeSM4ju5lyK7EP81ugww1ZARaI0U
	gs8iQLYx9ZSJzL1t8RYEPf2MxfBf9s3ISeJpYwzJfbY1LP66IiQlEYyWZX7TWUuOhSSd+j
	QHxdKtWvMywJW5kM8KxC3ozfxn1n0BTwgqRspa0SYdoFjxiNskgkH3+l7apaPtovsFTCir
	/eDE+8+FyfScKQW4ZXlPNkEBA8QbEEVsBNZpySv69uV9FsqHgFVMgDuCMRqbdQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174747;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=/T/lIugtjOnyOk0TOzZkPoZByXefF1LfjuDkNv8axwo=;
	b=LGRIOOkKk9uMR58nBNuiyz1GmYXNgyyKXlS10xIQmOgbQ/Jkk7kTacYFZo0PvPLyf49QPl
	HjCMGi+rlPtSyrDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 15/35] platform-msi: Let the core code handle sysfs groups
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:06 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Set the domain info flag and remove the local sysfs code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |   11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -23,7 +23,6 @@
 struct platform_msi_priv_data {
 	struct device			*dev;
 	void				*host_data;
-	const struct attribute_group    **msi_irq_groups;
 	msi_alloc_info_t		arg;
 	irq_write_msi_msg_t		write_msg;
 	int				devid;
@@ -191,6 +190,7 @@ struct irq_domain *platform_msi_create_i
 		platform_msi_update_dom_ops(info);
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		platform_msi_update_chip_ops(info);
+	info->flags |= MSI_FLAG_DEV_SYSFS;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (domain)
@@ -279,16 +279,8 @@ int platform_msi_domain_alloc_irqs(struc
 	if (err)
 		goto out_free_desc;
 
-	priv_data->msi_irq_groups = msi_populate_sysfs(dev);
-	if (IS_ERR(priv_data->msi_irq_groups)) {
-		err = PTR_ERR(priv_data->msi_irq_groups);
-		goto out_free_irqs;
-	}
-
 	return 0;
 
-out_free_irqs:
-	msi_domain_free_irqs(dev->msi.domain, dev);
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
@@ -308,7 +300,6 @@ void platform_msi_domain_free_irqs(struc
 		struct msi_desc *desc;
 
 		desc = first_msi_entry(dev);
-		msi_destroy_sysfs(dev, desc->platform.msi_priv_data->msi_irq_groups);
 		platform_msi_free_priv_data(desc->platform.msi_priv_data);
 	}
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244391.422809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLw-0006vN-Ht; Fri, 10 Dec 2021 22:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244391.422809; Fri, 10 Dec 2021 22:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoLw-0006ts-Bf; Fri, 10 Dec 2021 22:26:56 +0000
Received: by outflank-mailman (input) for mailman id 244391;
 Fri, 10 Dec 2021 22:26:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEo-0005LK-CB
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:34 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 408a4894-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:33 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 408a4894-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221815.148331680@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174773;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=1mcUFIyf9ySwp0yGA9BXrnZ9ta7jfneNSCIqf6wYVGk=;
	b=oKS80X/kJKLB8GB+c0SIKmguD/kevr7iZutS3fVTQ+rGCeSum9bn5Q+v1Est6NyleDXcvj
	C2TzfgyjVUEpqtu5aaWZcLjJlLFf0vRy+2ceD1IEYbC6SY7NiYO3pa/K3tveERBEi2lJ+W
	LrV7kcXBnYzWCcxOpkhXAviCnM6+blWD3RE5ejV9PjRrOFaNsJDbWBAt4YGwG4M9YMgqFp
	ixEY9UW4+wZWMAyVzTPe7Ms2nyLA/mEG6RCm8A0SFpOGFd1HIpzokfKB41UHXnSURcCa5O
	ptjXGZ9/US9gmPa1yw0KaJD2RG+xIPdfx7ti5vbGRnDGULGvRIPGUkdJ9s5kLQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174773;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=1mcUFIyf9ySwp0yGA9BXrnZ9ta7jfneNSCIqf6wYVGk=;
	b=7Nl66lpVGonXIzUJuEqPSV3MziV+dwsh1VZ137uXNOy+N9tDDG/1eW2YpLYeL3y+xjSQjH
	DDQUDmuZmfQw0OCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject:
 [patch V3 32/35] mailbox: bcm-flexrm-mailbox: Rework MSI interrupt handling
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:32 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

No point in retrieving the MSI descriptors. Just query the Linux interrupt
number.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>

---
 drivers/mailbox/bcm-flexrm-mailbox.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1497,7 +1497,6 @@ static int flexrm_mbox_probe(struct plat
 	int index, ret = 0;
 	void __iomem *regs;
 	void __iomem *regs_end;
-	struct msi_desc *desc;
 	struct resource *iomem;
 	struct flexrm_ring *ring;
 	struct flexrm_mbox *mbox;
@@ -1608,10 +1607,8 @@ static int flexrm_mbox_probe(struct plat
 		goto fail_destroy_cmpl_pool;
 
 	/* Save alloced IRQ numbers for each ring */
-	for_each_msi_entry(desc, dev) {
-		ring = &mbox->rings[desc->msi_index];
-		ring->irq = desc->irq;
-	}
+	for (index = 0; index < mbox->num_rings; index++)
+		mbox->rings[index].irq = msi_get_virq(dev, index);
 
 	/* Check availability of debugfs */
 	if (!debugfs_initialized())



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244395.422828 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM3-0007lM-Qr; Fri, 10 Dec 2021 22:27:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244395.422828; Fri, 10 Dec 2021 22:27:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM3-0007lB-Mh; Fri, 10 Dec 2021 22:27:03 +0000
Received: by outflank-mailman (input) for mailman id 244395;
 Fri, 10 Dec 2021 22:27:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEj-0005LR-Lj
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:29 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3dc04d11-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3dc04d11-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.970099984@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174768;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=zF6xwEDBnJqDiuzvbqLmsexoc+W+jGd9VwXdVq5BEMI=;
	b=3uRJBXLzDA2NYHvGXAjPESXwPtY4wndvLVMfkxhow+rp/kDN16U4X0C98PwLB5MMnD4tYn
	ZOEGSM2ye4hhzzHTXNKc+wG0/ppoUdhswTzSBop3HHGnldcxLhjnLtQjD+xMmCwf22EUFE
	Q/zKOvjGyNcbqIgKQIsGXYGvefv5FHydeVKH232ubirlNA6T15859yhIKJ3jJ/7StDjYf2
	Oo9QLHN7iSJxzUqL6+fXtAzM9h9rqxwBGkEmlO1cFEBEwCIOcIJDJlbaSJFihp8W7eJp79
	8OeTtwQoaG0Z1HU6FBoYv5812za0uLavtriysEdHJ3Xheg5DIbiHdaTlV7ZxlQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174768;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=zF6xwEDBnJqDiuzvbqLmsexoc+W+jGd9VwXdVq5BEMI=;
	b=jVULDfzUnOD2T8hCESYAAk+sAcevMjadKqHQJ3kXJ4DqJvj5V3VSRLrJFQ9AuMxcORx3I7
	XP2F++Om2JcSHtCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 29/35] dmaengine: mv_xor_v2: Get rid of msi_desc abuse
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:28 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Storing a pointer to the MSI descriptor just to keep track of the Linux
interrupt number is daft. Use msi_get_virq() instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/mv_xor_v2.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -149,7 +149,7 @@ struct mv_xor_v2_descriptor {
  * @desc_size: HW descriptor size
  * @npendings: number of pending descriptors (for which tx_submit has
  * @hw_queue_idx: HW queue index
- * @msi_desc: local interrupt descriptor information
+ * @irq: The Linux interrupt number
  * been called, but not yet issue_pending)
  */
 struct mv_xor_v2_device {
@@ -168,7 +168,7 @@ struct mv_xor_v2_device {
 	int desc_size;
 	unsigned int npendings;
 	unsigned int hw_queue_idx;
-	struct msi_desc *msi_desc;
+	unsigned int irq;
 };
 
 /**
@@ -718,7 +718,6 @@ static int mv_xor_v2_probe(struct platfo
 	int i, ret = 0;
 	struct dma_device *dma_dev;
 	struct mv_xor_v2_sw_desc *sw_desc;
-	struct msi_desc *msi_desc;
 
 	BUILD_BUG_ON(sizeof(struct mv_xor_v2_descriptor) !=
 		     MV_XOR_V2_EXT_DESC_SIZE);
@@ -770,14 +769,9 @@ static int mv_xor_v2_probe(struct platfo
 	if (ret)
 		goto disable_clk;
 
-	msi_desc = first_msi_entry(&pdev->dev);
-	if (!msi_desc) {
-		ret = -ENODEV;
-		goto free_msi_irqs;
-	}
-	xor_dev->msi_desc = msi_desc;
+	xor_dev->irq = msi_get_virq(&pdev->dev, 0);
 
-	ret = devm_request_irq(&pdev->dev, msi_desc->irq,
+	ret = devm_request_irq(&pdev->dev, xor_dev->irq,
 			       mv_xor_v2_interrupt_handler, 0,
 			       dev_name(&pdev->dev), xor_dev);
 	if (ret)
@@ -892,7 +886,7 @@ static int mv_xor_v2_remove(struct platf
 			  xor_dev->desc_size * MV_XOR_V2_DESC_NUM,
 			  xor_dev->hw_desq_virt, xor_dev->hw_desq);
 
-	devm_free_irq(&pdev->dev, xor_dev->msi_desc->irq, xor_dev);
+	devm_free_irq(&pdev->dev, xor_dev->irq, xor_dev);
 
 	platform_msi_domain_free_irqs(&pdev->dev);
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244396.422833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM4-0007oy-5f; Fri, 10 Dec 2021 22:27:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244396.422833; Fri, 10 Dec 2021 22:27:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM4-0007nx-0z; Fri, 10 Dec 2021 22:27:04 +0000
Received: by outflank-mailman (input) for mailman id 244396;
 Fri, 10 Dec 2021 22:27:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEi-0005LR-6J
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:28 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3ce4830c-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3ce4830c-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.900929381@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174767;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rNrzn8yRvXgsVUgYBaKAG8ZHI0uIOQ4IQLNHP2L6pxE=;
	b=nf9eyrsJJrs9ednYCFZjv8J2yY2kMTBnnjDazqRJ511KXpZJf1YcQjdYfXYm2loBQc4e51
	X1migsWpqvkVonHlgKGazqD3LQt1VEi1ONQMXlquZAUbD3bWwtHjKz6uiOhNtYIahCIAun
	mRzaRa8QncWEAJyd2oq1drpHnTqWPT1eKioZJCZmH/BKUQRxgGCPmRRh6EsC/v//nl8sL/
	boRobi4kXbHHVHnVHwhXecrQ/I8Q5OXFyHGRvTUgcBYSHxyXSCbkQ+q/m1CrmiEH4i02FY
	dX0m9VD+WaASxOutJEozXkaEXjuYirVE7txgIlds5ll8afoP9lZT4fq2oH6P3A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174767;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=rNrzn8yRvXgsVUgYBaKAG8ZHI0uIOQ4IQLNHP2L6pxE=;
	b=Cgugbw7jJJgW3jPH6Q3nUfo/m4UVuVoB8e3+XhsPb07BsPv7J7QZZ/uWWrdVpdYtMpcMdt
	NSwEg+9aK1hyY+CQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:26 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Replace open coded MSI descriptor chasing and use the proper accessor
functions instead.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/pci/msi/msi.c |   26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -1061,26 +1061,20 @@ EXPORT_SYMBOL(pci_irq_vector);
  */
 const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
 {
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
+	int irq = pci_irq_vector(dev, nr);
+	struct msi_desc *desc;
 
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_index == nr)
-				return &entry->affinity->mask;
-		}
-		WARN_ON_ONCE(1);
+	if (WARN_ON_ONCE(irq <= 0))
 		return NULL;
-	} else if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
 
-		if (WARN_ON_ONCE(!entry || !entry->affinity ||
-				 nr >= entry->nvec_used))
-			return NULL;
-
-		return &entry->affinity[nr].mask;
-	} else {
+	desc = irq_get_msi_desc(irq);
+	/* Non-MSI does not have the information handy */
+	if (!desc)
 		return cpu_possible_mask;
-	}
+
+	if (WARN_ON_ONCE(!desc->affinity))
+		return NULL;
+	return &desc->affinity[nr].mask;
 }
 EXPORT_SYMBOL(pci_irq_get_affinity);
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244398.422841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM4-0007wk-Ry; Fri, 10 Dec 2021 22:27:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244398.422841; Fri, 10 Dec 2021 22:27:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM4-0007wB-Ho; Fri, 10 Dec 2021 22:27:04 +0000
Received: by outflank-mailman (input) for mailman id 244398;
 Fri, 10 Dec 2021 22:27:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEZ-0005LR-0W
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:19 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 375e1fc8-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 375e1fc8-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.540704224@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174758;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cN4mOxuY7Okg1M+dlth8hthNIkx8L2iGPoOR+S+w+us=;
	b=M1tVjk6yFiMKXjz8z9rtje5UmZy1dz0aDWkX81TwRD2eOEBGMMOd4HQQbrePJuaH6+UMRX
	J8wzTS/tTtQdxXfph9XF969YPmB4Y9GtozG9J4einOdMXxZg3dQjYwxFmbcAJrBgo1kHEs
	PbCl/WQUGX4eNaP010LwWx1i2cL5DMz8+7ISg/FfzlYFm65Wyqm9T6dyF1sj5FioiD3VX+
	3iHK8Lyh2m73JkSmCPZRxgV4hdZQVdwIcMAKKbwxgrB6ifMNHS/T+pXh+isLvhLB4AByf+
	ekRKlayeNgYLRRrhODOIIyqUXowDIwjE4RArqa+pNuDaWoQqOOLWRwNBHeCs1A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174758;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=cN4mOxuY7Okg1M+dlth8hthNIkx8L2iGPoOR+S+w+us=;
	b=zq6e6vgOvTOBpv83YKIBY7AfdQR37XhK0GNGPBYF4MooJaZ9kRON5kPCk5FJ8SFotmH1vC
	0TG1lB8qM5PsBWAg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 22/35] soc: ti: ti_sci_inta_msi: Use msi_desc::msi_index
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:17 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/irqchip/irq-ti-sci-inta.c |    2 +-
 drivers/soc/ti/ti_sci_inta_msi.c  |    6 +++---
 include/linux/msi.h               |   16 ++--------------
 3 files changed, 6 insertions(+), 18 deletions(-)

--- a/drivers/irqchip/irq-ti-sci-inta.c
+++ b/drivers/irqchip/irq-ti-sci-inta.c
@@ -595,7 +595,7 @@ static void ti_sci_inta_msi_set_desc(msi
 	struct platform_device *pdev = to_platform_device(desc->dev);
 
 	arg->desc = desc;
-	arg->hwirq = TO_HWIRQ(pdev->id, desc->inta.dev_index);
+	arg->hwirq = TO_HWIRQ(pdev->id, desc->msi_index);
 }
 
 static struct msi_domain_ops ti_sci_inta_msi_ops = {
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -84,7 +84,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 				return -ENOMEM;
 			}
 
-			msi_desc->inta.dev_index = res->desc[set].start + i;
+			msi_desc->msi_index = res->desc[set].start + i;
 			INIT_LIST_HEAD(&msi_desc->list);
 			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 			count++;
@@ -96,7 +96,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 				return -ENOMEM;
 			}
 
-			msi_desc->inta.dev_index = res->desc[set].start_sec + i;
+			msi_desc->msi_index = res->desc[set].start_sec + i;
 			INIT_LIST_HEAD(&msi_desc->list);
 			list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 			count++;
@@ -154,7 +154,7 @@ unsigned int ti_sci_inta_msi_get_virq(st
 	struct msi_desc *desc;
 
 	for_each_msi_entry(desc, dev)
-		if (desc->inta.dev_index == dev_index)
+		if (desc->msi_index == dev_index)
 			return desc->irq;
 
 	return -ENODEV;
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -107,14 +107,6 @@ struct pci_msi_desc {
 };
 
 /**
- * ti_sci_inta_msi_desc - TISCI based INTA specific msi descriptor data
- * @dev_index: TISCI device index
- */
-struct ti_sci_inta_msi_desc {
-	u16	dev_index;
-};
-
-/**
  * struct msi_desc - Descriptor structure for MSI based interrupts
  * @list:	List head for management
  * @irq:	The base interrupt number
@@ -128,8 +120,7 @@ struct ti_sci_inta_msi_desc {
  * @write_msi_msg_data:	Data parameter for the callback.
  *
  * @msi_index:	Index of the msi descriptor
- * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
+ * @pci:	PCI specific msi descriptor data
  */
 struct msi_desc {
 	/* Shared device/bus type independent data */
@@ -147,10 +138,7 @@ struct msi_desc {
 	void *write_msi_msg_data;
 
 	u16				msi_index;
-	union {
-		struct pci_msi_desc		pci;
-		struct ti_sci_inta_msi_desc	inta;
-	};
+	struct pci_msi_desc		pci;
 };
 
 /**



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244400.422847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM5-00084q-LC; Fri, 10 Dec 2021 22:27:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244400.422847; Fri, 10 Dec 2021 22:27:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM5-00080z-3y; Fri, 10 Dec 2021 22:27:05 +0000
Received: by outflank-mailman (input) for mailman id 244400;
 Fri, 10 Dec 2021 22:27:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEq-0005LK-4f
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:36 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 417503c8-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 417503c8-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221815.207838579@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174774;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9W0PenGJOabQuxHdL2FiXZSFBmG9hO0u6DF+sGaPwsQ=;
	b=FBUn8ueMSvkuKgwtqPtBtR/2nbyMaW5RgnxN6V9NRAVL3aT06KJramowbWbr+ECa5o6EIs
	DXYcl/M/t7wn2Vy46sN5lfBpNABm5lBAMTicbKnpsMSGgN1CSbq9AH2KcDYTIgtpL5T/gg
	Ch/1IE6n3cPEQHHpS5XqkAVZJJ//It0q8gllznZV79lvNKaMo2CTqBpMiaG5k13IDARMTU
	U++JUDGsB1MfnUhSTx34KJzuOScXHOHvLD/bNq35VFk/t5dkD02Rb8ewKOWVWeS2F00NLg
	1ugq6mxz7a/+IzhfYxzJ2XwAnbHBpBGQqr4JfosAxyZTEiW6MlVjw4PuHC+yiA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174774;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=9W0PenGJOabQuxHdL2FiXZSFBmG9hO0u6DF+sGaPwsQ=;
	b=mAKBO9iPA/DwNd5uWhs01QEYd5up3ZunfRyucK5uCYlEOMfTIgFQcEWaz2qGiU58uydKLu
	Lt6Mpqf0D9cspbBw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 33/35] bus: fsl-mc: fsl-mc-allocator: Rework MSI handling
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:34 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Storing a pointer to the MSI descriptor just to track the Linux interrupt
number is daft. Just store the interrupt number and be done with it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/bus/fsl-mc/dprc-driver.c                    |    8 ++++----
 drivers/bus/fsl-mc/fsl-mc-allocator.c               |    9 ++-------
 drivers/bus/fsl-mc/fsl-mc-msi.c                     |    6 +++---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c    |    4 ++--
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c    |    4 +---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c |    5 ++---
 drivers/soc/fsl/dpio/dpio-driver.c                  |    8 ++++----
 drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c              |    4 ++--
 include/linux/fsl/mc.h                              |    4 ++--
 9 files changed, 22 insertions(+), 30 deletions(-)

--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -400,7 +400,7 @@ static irqreturn_t dprc_irq0_handler_thr
 	struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
 	struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_dev);
 	struct fsl_mc_io *mc_io = mc_dev->mc_io;
-	struct msi_desc *msi_desc = mc_dev->irqs[0]->msi_desc;
+	int irq = mc_dev->irqs[0]->virq;
 
 	dev_dbg(dev, "DPRC IRQ %d triggered on CPU %u\n",
 		irq_num, smp_processor_id());
@@ -409,7 +409,7 @@ static irqreturn_t dprc_irq0_handler_thr
 		return IRQ_HANDLED;
 
 	mutex_lock(&mc_bus->scan_mutex);
-	if (!msi_desc || msi_desc->irq != (u32)irq_num)
+	if (irq != (u32)irq_num)
 		goto out;
 
 	status = 0;
@@ -521,7 +521,7 @@ static int register_dprc_irq_handler(str
 	 * function that programs the MSI physically in the device
 	 */
 	error = devm_request_threaded_irq(&mc_dev->dev,
-					  irq->msi_desc->irq,
+					  irq->virq,
 					  dprc_irq0_handler,
 					  dprc_irq0_handler_thread,
 					  IRQF_NO_SUSPEND | IRQF_ONESHOT,
@@ -771,7 +771,7 @@ static void dprc_teardown_irq(struct fsl
 
 	(void)disable_dprc_irq(mc_dev);
 
-	devm_free_irq(&mc_dev->dev, irq->msi_desc->irq, &mc_dev->dev);
+	devm_free_irq(&mc_dev->dev, irq->virq, &mc_dev->dev);
 
 	fsl_mc_free_irqs(mc_dev);
 }
--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -350,7 +350,6 @@ int fsl_mc_populate_irq_pool(struct fsl_
 			     unsigned int irq_count)
 {
 	unsigned int i;
-	struct msi_desc *msi_desc;
 	struct fsl_mc_device_irq *irq_resources;
 	struct fsl_mc_device_irq *mc_dev_irq;
 	int error;
@@ -388,16 +387,12 @@ int fsl_mc_populate_irq_pool(struct fsl_
 		mc_dev_irq->resource.type = res_pool->type;
 		mc_dev_irq->resource.data = mc_dev_irq;
 		mc_dev_irq->resource.parent_pool = res_pool;
+		mc_dev_irq->virq = msi_get_virq(&mc_bus_dev->dev, i);
+		mc_dev_irq->resource.id = mc_dev_irq->virq;
 		INIT_LIST_HEAD(&mc_dev_irq->resource.node);
 		list_add_tail(&mc_dev_irq->resource.node, &res_pool->free_list);
 	}
 
-	for_each_msi_entry(msi_desc, &mc_bus_dev->dev) {
-		mc_dev_irq = &irq_resources[msi_desc->msi_index];
-		mc_dev_irq->msi_desc = msi_desc;
-		mc_dev_irq->resource.id = msi_desc->irq;
-	}
-
 	res_pool->max_count = irq_count;
 	res_pool->free_count = irq_count;
 	mc_bus->irq_resources = irq_resources;
--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -58,11 +58,11 @@ static void fsl_mc_msi_update_dom_ops(st
 }
 
 static void __fsl_mc_msi_write_msg(struct fsl_mc_device *mc_bus_dev,
-				   struct fsl_mc_device_irq *mc_dev_irq)
+				   struct fsl_mc_device_irq *mc_dev_irq,
+				   struct msi_desc *msi_desc)
 {
 	int error;
 	struct fsl_mc_device *owner_mc_dev = mc_dev_irq->mc_dev;
-	struct msi_desc *msi_desc = mc_dev_irq->msi_desc;
 	struct dprc_irq_cfg irq_cfg;
 
 	/*
@@ -129,7 +129,7 @@ static void fsl_mc_msi_write_msg(struct
 	/*
 	 * Program the MSI (paddr, value) pair in the device:
 	 */
-	__fsl_mc_msi_write_msg(mc_bus_dev, mc_dev_irq);
+	__fsl_mc_msi_write_msg(mc_bus_dev, mc_dev_irq, msi_desc);
 }
 
 static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -4246,7 +4246,7 @@ static int dpaa2_eth_setup_irqs(struct f
 	}
 
 	irq = ls_dev->irqs[0];
-	err = devm_request_threaded_irq(&ls_dev->dev, irq->msi_desc->irq,
+	err = devm_request_threaded_irq(&ls_dev->dev, irq->virq,
 					NULL, dpni_irq0_handler_thread,
 					IRQF_NO_SUSPEND | IRQF_ONESHOT,
 					dev_name(&ls_dev->dev), &ls_dev->dev);
@@ -4273,7 +4273,7 @@ static int dpaa2_eth_setup_irqs(struct f
 	return 0;
 
 free_irq:
-	devm_free_irq(&ls_dev->dev, irq->msi_desc->irq, &ls_dev->dev);
+	devm_free_irq(&ls_dev->dev, irq->virq, &ls_dev->dev);
 free_mc_irq:
 	fsl_mc_free_irqs(ls_dev);
 
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c
@@ -129,7 +129,6 @@ static irqreturn_t dpaa2_ptp_irq_handler
 static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
 {
 	struct device *dev = &mc_dev->dev;
-	struct fsl_mc_device_irq *irq;
 	struct ptp_qoriq *ptp_qoriq;
 	struct device_node *node;
 	void __iomem *base;
@@ -177,8 +176,7 @@ static int dpaa2_ptp_probe(struct fsl_mc
 		goto err_unmap;
 	}
 
-	irq = mc_dev->irqs[0];
-	ptp_qoriq->irq = irq->msi_desc->irq;
+	ptp_qoriq->irq = mc_dev->irqs[0]->virq;
 
 	err = request_threaded_irq(ptp_qoriq->irq, NULL,
 				   dpaa2_ptp_irq_handler_thread,
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
@@ -1553,8 +1553,7 @@ static int dpaa2_switch_setup_irqs(struc
 
 	irq = sw_dev->irqs[DPSW_IRQ_INDEX_IF];
 
-	err = devm_request_threaded_irq(dev, irq->msi_desc->irq,
-					NULL,
+	err = devm_request_threaded_irq(dev, irq->virq, NULL,
 					dpaa2_switch_irq0_handler_thread,
 					IRQF_NO_SUSPEND | IRQF_ONESHOT,
 					dev_name(dev), dev);
@@ -1580,7 +1579,7 @@ static int dpaa2_switch_setup_irqs(struc
 	return 0;
 
 free_devm_irq:
-	devm_free_irq(dev, irq->msi_desc->irq, dev);
+	devm_free_irq(dev, irq->virq, dev);
 free_irq:
 	fsl_mc_free_irqs(sw_dev);
 	return err;
--- a/drivers/soc/fsl/dpio/dpio-driver.c
+++ b/drivers/soc/fsl/dpio/dpio-driver.c
@@ -88,7 +88,7 @@ static void unregister_dpio_irq_handlers
 	irq = dpio_dev->irqs[0];
 
 	/* clear the affinity hint */
-	irq_set_affinity_hint(irq->msi_desc->irq, NULL);
+	irq_set_affinity_hint(irq->virq, NULL);
 }
 
 static int register_dpio_irq_handlers(struct fsl_mc_device *dpio_dev, int cpu)
@@ -98,7 +98,7 @@ static int register_dpio_irq_handlers(st
 
 	irq = dpio_dev->irqs[0];
 	error = devm_request_irq(&dpio_dev->dev,
-				 irq->msi_desc->irq,
+				 irq->virq,
 				 dpio_irq_handler,
 				 0,
 				 dev_name(&dpio_dev->dev),
@@ -111,10 +111,10 @@ static int register_dpio_irq_handlers(st
 	}
 
 	/* set the affinity hint */
-	if (irq_set_affinity_hint(irq->msi_desc->irq, cpumask_of(cpu)))
+	if (irq_set_affinity_hint(irq->virq, cpumask_of(cpu)))
 		dev_err(&dpio_dev->dev,
 			"irq_set_affinity failed irq %d cpu %d\n",
-			irq->msi_desc->irq, cpu);
+			irq->virq, cpu);
 
 	return 0;
 }
--- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
+++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
@@ -67,7 +67,7 @@ static int vfio_set_trigger(struct vfio_
 	int hwirq;
 	int ret;
 
-	hwirq = vdev->mc_dev->irqs[index]->msi_desc->irq;
+	hwirq = vdev->mc_dev->irqs[index]->virq;
 	if (irq->trigger) {
 		free_irq(hwirq, irq);
 		kfree(irq->name);
@@ -137,7 +137,7 @@ static int vfio_fsl_mc_set_irq_trigger(s
 		return vfio_set_trigger(vdev, index, fd);
 	}
 
-	hwirq = vdev->mc_dev->irqs[index]->msi_desc->irq;
+	hwirq = vdev->mc_dev->irqs[index]->virq;
 
 	irq = &vdev->mc_irqs[index];
 
--- a/include/linux/fsl/mc.h
+++ b/include/linux/fsl/mc.h
@@ -91,13 +91,13 @@ struct fsl_mc_resource {
 
 /**
  * struct fsl_mc_device_irq - MC object device message-based interrupt
- * @msi_desc: pointer to MSI descriptor allocated by fsl_mc_msi_alloc_descs()
+ * @virq: Linux virtual interrupt number
  * @mc_dev: MC object device that owns this interrupt
  * @dev_irq_index: device-relative IRQ index
  * @resource: MC generic resource associated with the interrupt
  */
 struct fsl_mc_device_irq {
-	struct msi_desc *msi_desc;
+	unsigned int virq;
 	struct fsl_mc_device *mc_dev;
 	u8 dev_irq_index;
 	struct fsl_mc_resource resource;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244406.422873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM9-0000kh-Em; Fri, 10 Dec 2021 22:27:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244406.422873; Fri, 10 Dec 2021 22:27:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoM9-0000kM-9j; Fri, 10 Dec 2021 22:27:09 +0000
Received: by outflank-mailman (input) for mailman id 244406;
 Fri, 10 Dec 2021 22:27:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEf-0005LK-2j
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:25 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b035812-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b035812-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.780824745@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174764;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ZEIc+hYHtGZ+R8Y42PTVzHWVlXMSBVtNMJGsH152424=;
	b=ZnOdjYsyWWWPA45DX/sEP1Hz7/N21g6u4UZdn8c1qyQRQwctj1a4i6BAp20kDLoVrj6D2s
	MbD+ZTo1q9CByKhQo2XRoN4WdhbqsWP8IhvQmO5n4QjDLb4bQeMj+tjt/r7iv7ulqjYgof
	F4ISSFlfQwvH4mj7rI3COb7fhYfIaOuZZwt6hdi7/i1KgHhxe1miuwBC9ALPHJWSgBGtAq
	Hm9GThVygPLyQUzGEUG99ih95uj7Ifn3w+/L6+ojF2urlcLuEKAYpMauAHf1+Mdai5rTl4
	6N8IRoupzCe+vvFuCq6MovD0Voro2Z7OmtZqPzl66KvGCxnWY1NqHMI0nV1/OA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174764;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ZEIc+hYHtGZ+R8Y42PTVzHWVlXMSBVtNMJGsH152424=;
	b=IxahGrtxRlopXsWUYNpTNdhCUtnqonpOEodZ3IuQBz/DFc/KxGCheju7XzPFrWnx3hqpKg
	Kcg6g5cSFSWCRQCA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 26/35] genirq/msi: Provide interface to retrieve Linux
 interrupt number
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:23 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

This allows drivers to retrieve the Linux interrupt number instead of
fiddling with MSI descriptors.

msi_get_virq() returns the Linux interrupt number or 0 in case that there
is no entry for the given MSI index.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
V2: Simplify the implementation and let PCI deal with the PCI specialities - Marc
---
 include/linux/msi.h |    2 ++
 kernel/irq/msi.c    |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -153,6 +153,8 @@ struct msi_device_data {
 
 int msi_setup_device_data(struct device *dev);
 
+unsigned int msi_get_virq(struct device *dev, unsigned int index);
+
 /* Helpers to hide struct msi_desc implementation details */
 #define msi_desc_to_dev(desc)		((desc)->dev)
 #define dev_to_msi_list(dev)		(&(dev)->msi_list)
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -105,6 +105,42 @@ int msi_setup_device_data(struct device
 	return 0;
 }
 
+/**
+ * msi_get_virq - Return Linux interrupt number of a MSI interrupt
+ * @dev:	Device to operate on
+ * @index:	MSI interrupt index to look for (0-based)
+ *
+ * Return: The Linux interrupt number on success (> 0), 0 if not found
+ */
+unsigned int msi_get_virq(struct device *dev, unsigned int index)
+{
+	struct msi_desc *desc;
+	bool pcimsi;
+
+	if (!dev->msi.data)
+		return 0;
+
+	pcimsi = dev_is_pci(dev) ? to_pci_dev(dev)->msi_enabled : false;
+
+	for_each_msi_entry(desc, dev) {
+		/* PCI-MSI has only one descriptor for multiple interrupts. */
+		if (pcimsi) {
+			if (desc->irq && index < desc->nvec_used)
+				return desc->irq + index;
+			break;
+		}
+
+		/*
+		 * PCI-MSIX and platform MSI use a descriptor per
+		 * interrupt.
+		 */
+		if (desc->msi_index == index)
+			return desc->irq;
+	}
+	return 0;
+}
+EXPORT_SYMBOL_GPL(msi_get_virq);
+
 #ifdef CONFIG_SYSFS
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
 			     char *buf)



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244409.422884 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMD-0001ZZ-Uy; Fri, 10 Dec 2021 22:27:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244409.422884; Fri, 10 Dec 2021 22:27:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMD-0001Yw-Nc; Fri, 10 Dec 2021 22:27:13 +0000
Received: by outflank-mailman (input) for mailman id 244409;
 Fri, 10 Dec 2021 22:27:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEa-0005LK-Mb
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:20 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3843ad53-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3843ad53-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.602911509@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=b+8XtuxyybZ0KA3VgHyfihDMNTV0zUMbTk9/Irfc6hY=;
	b=gtlARjzibFYuz9U6kOioIdZU3H2gGpSp0kPlWLZ+kd24cAed+DeClKuntlG4JsCk8zY07y
	q4OBakPfcKBb37uTsVpdl+kZVXjGOM+WiX4QdL4/u+lA1Y9y4dKrhkgw6Uh/7GO9oYoIeQ
	hBP/MraULd3ZVo1Z1K+epp4dalnjedctH041vEGdy4nfhXCKfiR+ROymaThUnkMKuz3NNm
	+JxVPoN3XjujZ5ewmGt2GsfcPEocK7u3J2vLaJA/0r9VgzNM5Jdeq19scuH1VS8ZuEjJ+m
	oWuWlGsHLJmOx4SsTtznS8VRLvxx0mMiiyfP6T1q4JfNvKbl2zPiXclTsVXprA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174759;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=b+8XtuxyybZ0KA3VgHyfihDMNTV0zUMbTk9/Irfc6hY=;
	b=KjbXc7grgijN+0eh8P50UqVENbOnRsxgSHL8UOCByDa/XkHCvECRNHYwFOKg0KvZdAMfCs
	a3nFb07yNOEsfEDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 23/35] PCI/MSI: Use msi_desc::msi_index
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:18 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

The usage of msi_desc::pci::entry_nr is confusing at best. It's the index
into the MSI[X] descriptor table.

Use msi_desc::msi_index which is shared between all MSI incarnations
instead of having a PCI specific storage for no value.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>

---
 arch/powerpc/platforms/pseries/msi.c |    4 ++--
 arch/x86/pci/xen.c                   |    2 +-
 drivers/pci/msi/irqdomain.c          |    2 +-
 drivers/pci/msi/msi.c                |   20 ++++++++------------
 drivers/pci/xen-pcifront.c           |    2 +-
 include/linux/msi.h                  |    2 --
 6 files changed, 13 insertions(+), 19 deletions(-)

--- a/arch/powerpc/platforms/pseries/msi.c
+++ b/arch/powerpc/platforms/pseries/msi.c
@@ -332,7 +332,7 @@ static int check_msix_entries(struct pci
 
 	expected = 0;
 	for_each_pci_msi_entry(entry, pdev) {
-		if (entry->pci.msi_attrib.entry_nr != expected) {
+		if (entry->msi_index != expected) {
 			pr_debug("rtas_msi: bad MSI-X entries.\n");
 			return -EINVAL;
 		}
@@ -579,7 +579,7 @@ static int pseries_irq_domain_alloc(stru
 	int hwirq;
 	int i, ret;
 
-	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->pci.msi_attrib.entry_nr);
+	hwirq = rtas_query_irq_number(pci_get_pdn(pdev), desc->msi_index);
 	if (hwirq < 0) {
 		dev_err(&pdev->dev, "Failed to query HW IRQ: %d\n", hwirq);
 		return hwirq;
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -306,7 +306,7 @@ static int xen_initdom_setup_msi_irqs(st
 				return -EINVAL;
 
 			map_irq.table_base = pci_resource_start(dev, bir);
-			map_irq.entry_nr = msidesc->pci.msi_attrib.entry_nr;
+			map_irq.entry_nr = msidesc->msi_index;
 		}
 
 		ret = -EINVAL;
--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -57,7 +57,7 @@ static irq_hw_number_t pci_msi_domain_ca
 {
 	struct pci_dev *dev = msi_desc_to_pci_dev(desc);
 
-	return (irq_hw_number_t)desc->pci.msi_attrib.entry_nr |
+	return (irq_hw_number_t)desc->msi_index |
 		pci_dev_id(dev) << 11 |
 		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -44,7 +44,7 @@ static inline void pci_msi_unmask(struct
 
 static inline void __iomem *pci_msix_desc_addr(struct msi_desc *desc)
 {
-	return desc->pci.mask_base + desc->pci.msi_attrib.entry_nr * PCI_MSIX_ENTRY_SIZE;
+	return desc->pci.mask_base + desc->msi_index * PCI_MSIX_ENTRY_SIZE;
 }
 
 /*
@@ -356,13 +356,10 @@ msi_setup_entry(struct pci_dev *dev, int
 	if (dev->dev_flags & PCI_DEV_FLAGS_HAS_MSI_MASKING)
 		control |= PCI_MSI_FLAGS_MASKBIT;
 
-	entry->pci.msi_attrib.is_msix	= 0;
-	entry->pci.msi_attrib.is_64		= !!(control & PCI_MSI_FLAGS_64BIT);
-	entry->pci.msi_attrib.is_virtual    = 0;
-	entry->pci.msi_attrib.entry_nr	= 0;
+	entry->pci.msi_attrib.is_64	= !!(control & PCI_MSI_FLAGS_64BIT);
 	entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
 					  !!(control & PCI_MSI_FLAGS_MASKBIT);
-	entry->pci.msi_attrib.default_irq	= dev->irq;	/* Save IOAPIC IRQ */
+	entry->pci.msi_attrib.default_irq = dev->irq;
 	entry->pci.msi_attrib.multi_cap	= (control & PCI_MSI_FLAGS_QMASK) >> 1;
 	entry->pci.msi_attrib.multiple	= ilog2(__roundup_pow_of_two(nvec));
 
@@ -504,12 +501,11 @@ static int msix_setup_entries(struct pci
 		entry->pci.msi_attrib.is_64	= 1;
 
 		if (entries)
-			entry->pci.msi_attrib.entry_nr = entries[i].entry;
+			entry->msi_index = entries[i].entry;
 		else
-			entry->pci.msi_attrib.entry_nr = i;
+			entry->msi_index = i;
 
-		entry->pci.msi_attrib.is_virtual =
-			entry->pci.msi_attrib.entry_nr >= vec_count;
+		entry->pci.msi_attrib.is_virtual = entry->msi_index >= vec_count;
 
 		entry->pci.msi_attrib.can_mask	= !pci_msi_ignore_mask &&
 						  !entry->pci.msi_attrib.is_virtual;
@@ -1045,7 +1041,7 @@ int pci_irq_vector(struct pci_dev *dev,
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
+			if (entry->msi_index == nr)
 				return entry->irq;
 		}
 		WARN_ON_ONCE(1);
@@ -1084,7 +1080,7 @@ const struct cpumask *pci_irq_get_affini
 		struct msi_desc *entry;
 
 		for_each_pci_msi_entry(entry, dev) {
-			if (entry->pci.msi_attrib.entry_nr == nr)
+			if (entry->msi_index == nr)
 				return &entry->affinity->mask;
 		}
 		WARN_ON_ONCE(1);
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -263,7 +263,7 @@ static int pci_frontend_enable_msix(stru
 
 	i = 0;
 	for_each_pci_msi_entry(entry, dev) {
-		op.msix_entries[i].entry = entry->pci.msi_attrib.entry_nr;
+		op.msix_entries[i].entry = entry->msi_index;
 		/* Vector is useless at this point. */
 		op.msix_entries[i].vector = -1;
 		i++;
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -80,7 +80,6 @@ typedef void (*irq_write_msi_msg_t)(stru
  * @multi_cap:	[PCI MSI/X] log2 num of messages supported
  * @can_mask:	[PCI MSI/X] Masking supported?
  * @is_64:	[PCI MSI/X] Address size: 0=32bit 1=64bit
- * @entry_nr:	[PCI MSI/X] Entry which is described by this descriptor
  * @default_irq:[PCI MSI/X] The default pre-assigned non-MSI irq
  * @mask_pos:	[PCI MSI]   Mask register position
  * @mask_base:	[PCI MSI-X] Mask register base address
@@ -97,7 +96,6 @@ struct pci_msi_desc {
 		u8	can_mask	: 1;
 		u8	is_64		: 1;
 		u8	is_virtual	: 1;
-		u16	entry_nr;
 		unsigned default_irq;
 	} msi_attrib;
 	union {



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244410.422888 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoME-0001df-Ef; Fri, 10 Dec 2021 22:27:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244410.422888; Fri, 10 Dec 2021 22:27:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoME-0001bc-6u; Fri, 10 Dec 2021 22:27:14 +0000
Received: by outflank-mailman (input) for mailman id 244410;
 Fri, 10 Dec 2021 22:27:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEl-0005LR-6A
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:31 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3eb4e063-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:30 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3eb4e063-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221815.029143589@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174770;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=CMaNPxPUtZNOsnEqJOn3U6U1kdxY+NtpTLVPr27+/WY=;
	b=EvqlUpO3T7X8KMNp3XgG+e3yhF82NAZ2M5y6A12MWgoIyrud3KHV79CLaa8A1W/w2fMrsQ
	LYeCWIzrB2PJ3nkHOUu99+gQNjYZJ2nFFzgkmK9M5kbS8EACcrcJA5nvulgwqlHBSj67I9
	7YmwEsMKo88h/lp98iq/wfXL323gMi+kAz0R0urtlkaiJW/zIz8Ce8trpP3NPO1/2PY+lX
	62ssC5yso1LV4qheLUYQWhunj7PWO1yoQ9P8kcfNwViTrSnqyFbZ582iS61x+lp+RUbxzA
	au4eXWrrM+ypnyPoZhxSChX9cVpDJ9CjG5TdED8Lqs9M3xLa8OxGU2KQXQHX6g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174770;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=CMaNPxPUtZNOsnEqJOn3U6U1kdxY+NtpTLVPr27+/WY=;
	b=9yuWBpO3xKR5Wa0Z1Ej6Z030dWItOHliibhKuSikOya/v81orWbYN+DXKj1sCuZggh9Ds3
	JoHcOuQq4cA8d/Aw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 30/35] perf/smmuv3: Use msi_get_virq()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:29 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Let the core code fiddle with the MSI descriptor retrieval.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/perf/arm_smmuv3_pmu.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/perf/arm_smmuv3_pmu.c
+++ b/drivers/perf/arm_smmuv3_pmu.c
@@ -684,7 +684,6 @@ static void smmu_pmu_write_msi_msg(struc
 
 static void smmu_pmu_setup_msi(struct smmu_pmu *pmu)
 {
-	struct msi_desc *desc;
 	struct device *dev = pmu->dev;
 	int ret;
 
@@ -701,9 +700,7 @@ static void smmu_pmu_setup_msi(struct sm
 		return;
 	}
 
-	desc = first_msi_entry(dev);
-	if (desc)
-		pmu->irq = desc->irq;
+	pmu->irq = msi_get_virq(dev, 0);
 
 	/* Add callback to free MSIs on teardown */
 	devm_add_action(dev, smmu_pmu_free_msis, dev);



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244412.422894 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMF-0001rO-G1; Fri, 10 Dec 2021 22:27:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244412.422894; Fri, 10 Dec 2021 22:27:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMF-0001pa-44; Fri, 10 Dec 2021 22:27:15 +0000
Received: by outflank-mailman (input) for mailman id 244412;
 Fri, 10 Dec 2021 22:27:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEO-0005LR-20
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:08 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2ffc22eb-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ffc22eb-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.048612053@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174745;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TChehWVkaCDXWslfOqt9SsdG5fg+7v6o6aA6KtRbeHM=;
	b=Z11uvvxgirAW72rICp0vfbanS84UF82Nhb6VQydo25+LJ6YqYAbpXkmM7xdJXeTdznCw1s
	erlLzvS3f8S8X3MqKG6FWkDbzvp7PQ01OSu3pmt6X/fqLdRuw+xf/tSng+pQE/QA3EVuJa
	JvpnsrGVQpSL/3nyMTJIBfAiiT+kUUJ3ssX8tU5sGnGPYjGGWGGM83LFKfBPbHkqRu8STR
	ghiqR/QIHyPv2LwcuKChQWwCEtBFQEHKUTL6+PT9gOax11YdzEWoTVht9qcQ8QqZBnEz6n
	JMmNdgKrS9iGoaCLMEB/xcBcfHGnMd7m6HmEh/Jj9qHhvvs3t2TqzewDPQIdXg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174745;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=TChehWVkaCDXWslfOqt9SsdG5fg+7v6o6aA6KtRbeHM=;
	b=KlfpjkCvcrQosgJ4ChgS7lGyZYuQ96QJI/yz5x/JhIyB7M0oc7AC8htzC3Lr6XT++gnAIE
	k/pOg57H/xU1JEBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 14/35] PCI/MSI: Let the irq code handle sysfs groups
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:05 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Set the domain info flag which makes the core code handle sysfs groups and
put an explicit invocation into the legacy code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/msi/irqdomain.c |    2 +-
 drivers/pci/msi/legacy.c    |    6 +++++-
 drivers/pci/msi/msi.c       |   23 -----------------------
 include/linux/pci.h         |    1 -
 4 files changed, 6 insertions(+), 26 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -159,7 +159,7 @@ struct irq_domain *pci_msi_create_irq_do
 	if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS)
 		pci_msi_domain_update_chip_ops(info);
 
-	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	info->flags |= MSI_FLAG_ACTIVATE_EARLY | MSI_FLAG_DEV_SYSFS;
 	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION_MODE))
 		info->flags |= MSI_FLAG_MUST_REACTIVATE;
 
--- a/drivers/pci/msi/legacy.c
+++ b/drivers/pci/msi/legacy.c
@@ -70,10 +70,14 @@ int pci_msi_legacy_setup_msi_irqs(struct
 {
 	int ret = arch_setup_msi_irqs(dev, nvec, type);
 
-	return pci_msi_setup_check_result(dev, type, ret);
+	ret = pci_msi_setup_check_result(dev, type, ret);
+	if (!ret)
+		ret = msi_device_populate_sysfs(&dev->dev);
+	return ret;
 }
 
 void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev)
 {
+	msi_device_destroy_sysfs(&dev->dev);
 	arch_teardown_msi_irqs(dev);
 }
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -233,11 +233,6 @@ static void free_msi_irqs(struct pci_dev
 			for (i = 0; i < entry->nvec_used; i++)
 				BUG_ON(irq_has_action(entry->irq + i));
 
-	if (dev->msi_irq_groups) {
-		msi_destroy_sysfs(&dev->dev, dev->msi_irq_groups);
-		dev->msi_irq_groups = NULL;
-	}
-
 	pci_msi_teardown_msi_irqs(dev);
 
 	list_for_each_entry_safe(entry, tmp, msi_list, list) {
@@ -417,7 +412,6 @@ static int msi_verify_entries(struct pci
 static int msi_capability_init(struct pci_dev *dev, int nvec,
 			       struct irq_affinity *affd)
 {
-	const struct attribute_group **groups;
 	struct msi_desc *entry;
 	int ret;
 
@@ -448,14 +442,6 @@ static int msi_capability_init(struct pc
 	if (ret)
 		goto err;
 
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto err;
-	}
-
-	dev->msi_irq_groups = groups;
-
 	/* Set MSI enabled bits	*/
 	pci_intx_for_msi(dev, 0);
 	pci_msi_set_enable(dev, 1);
@@ -584,7 +570,6 @@ static void msix_mask_all(void __iomem *
 static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
 				int nvec, struct irq_affinity *affd)
 {
-	const struct attribute_group **groups;
 	void __iomem *base;
 	int ret, tsize;
 	u16 control;
@@ -629,14 +614,6 @@ static int msix_capability_init(struct p
 
 	msix_update_entries(dev, entries);
 
-	groups = msi_populate_sysfs(&dev->dev);
-	if (IS_ERR(groups)) {
-		ret = PTR_ERR(groups);
-		goto out_free;
-	}
-
-	dev->msi_irq_groups = groups;
-
 	/* Disable INTX and unmask MSI-X */
 	pci_intx_for_msi(dev, 0);
 	pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -475,7 +475,6 @@ struct pci_dev {
 #ifdef CONFIG_PCI_MSI
 	void __iomem	*msix_base;
 	raw_spinlock_t	msi_lock;
-	const struct attribute_group **msi_irq_groups;
 #endif
 	struct pci_vpd	vpd;
 #ifdef CONFIG_PCIE_DPC



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244419.422917 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMO-0003g1-10; Fri, 10 Dec 2021 22:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244419.422917; Fri, 10 Dec 2021 22:27:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMN-0003fD-Qr; Fri, 10 Dec 2021 22:27:23 +0000
Received: by outflank-mailman (input) for mailman id 244419;
 Fri, 10 Dec 2021 22:27:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEg-0005LK-IA
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:26 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3bea19be-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3bea19be-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.841243231@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174765;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ja9fbkTMChiYC+RHKTG35XzzVDvmaXMgaMrb6WY3XeQ=;
	b=z6iPEnfVAgwlW1Qbnq1nCFWwA6bNapErKquzAi3fk6aQqeO9o4U4iwQjv+EebRfvLnwN8n
	e63ahKnp4QuQIaqzvffdsynbWgeJGaK4CvS+c+uMgRBceXI7VODqOegmQe3L/CvghbDhuO
	LN91tjaF0S12KexgZs8cR5/oZ2rSgoo7wgdZrtLgJvkHGW3yStep1fiuvR7g41IWJCZNnu
	Rdmmg97HfnTylsxqpzgAYVzZaMeXvWfNQQ5rvNFbwpEWwzgtXnQ4/DZTiIX/XN8OvdQ75p
	NdflsNWb6DcWnXBSu0XhAKL30N7MQvosu7Eo61JG6PvjMi8bgOFzC5eVez11kQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174765;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=ja9fbkTMChiYC+RHKTG35XzzVDvmaXMgaMrb6WY3XeQ=;
	b=ClMHqdNEhBqMOb1sVFaSm0KweWWAEZJCgeJM/hGJMp5ROj9kquAcj3PJfKxxeM3i7GOxBS
	FHUfoC+s+JX7GLDA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 27/35] PCI/MSI: Use __msi_get_virq() in pci_get_vector()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:25 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Use msi_get_vector() and handle the return value to be compatible.

No functional change intended.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
V2: Handle the INTx case directly instead of trying to be overly smart - Marc
---
 drivers/pci/msi/msi.c |   25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -1037,28 +1037,13 @@ EXPORT_SYMBOL(pci_free_irq_vectors);
  */
 int pci_irq_vector(struct pci_dev *dev, unsigned int nr)
 {
-	if (dev->msix_enabled) {
-		struct msi_desc *entry;
+	unsigned int irq;
 
-		for_each_pci_msi_entry(entry, dev) {
-			if (entry->msi_index == nr)
-				return entry->irq;
-		}
-		WARN_ON_ONCE(1);
-		return -EINVAL;
-	}
+	if (!dev->msi_enabled && !dev->msix_enabled)
+		return !nr ? dev->irq : -EINVAL;
 
-	if (dev->msi_enabled) {
-		struct msi_desc *entry = first_pci_msi_entry(dev);
-
-		if (WARN_ON_ONCE(nr >= entry->nvec_used))
-			return -EINVAL;
-	} else {
-		if (WARN_ON_ONCE(nr > 0))
-			return -EINVAL;
-	}
-
-	return dev->irq + nr;
+	irq = msi_get_virq(&dev->dev, nr);
+	return irq ? irq : -EINVAL;
 }
 EXPORT_SYMBOL(pci_irq_vector);
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244424.422926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMP-00042E-Gq; Fri, 10 Dec 2021 22:27:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244424.422926; Fri, 10 Dec 2021 22:27:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMP-00041L-B5; Fri, 10 Dec 2021 22:27:25 +0000
Received: by outflank-mailman (input) for mailman id 244424;
 Fri, 10 Dec 2021 22:27:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEY-0005LK-1S
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:18 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 36690daa-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36690daa-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.477386185@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=dh2RlNUmAwoYjA9eTFF60aCLEohqcxOki/Se5jBNtvk=;
	b=q/pBw8LlYFFFU88TeeIJvEppe38MJYUOaegEt/6+kHbknlFz4hqC28pzkrcpz+rdZBH7Ct
	cpIao/Ojr+R6AhAU4S+g3dU9sxTrWInVNawKyo/5M0hDBcPOzYmXMGvoNYb/E/BRYK8AbE
	Jd5fBAThZII1tD00/tV2qPSz7ri4loVPKk5zdok3KSWYmtyvpbXduRDfB9WvyMuyy2kSKS
	YBUFmgpMtUuwAt8ClNM4DiGIjFsZPR5MwdIozMRpGbXOjm768Nd5uNtLBB7XFbQCr9VMYN
	v44+6amAej3NWNewWJB+7MJ66zDGM2lzzpqGH6JFmH6f765owfcCx2bXaseS0A==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174756;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=dh2RlNUmAwoYjA9eTFF60aCLEohqcxOki/Se5jBNtvk=;
	b=6IVODbVD2gQWqrMzoxlyFeT/FyksUxmc33xNNKlBBReHQFt0yfS0alvLSk8dq213HdtOYU
	U81rzfIpvPjBIhBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 21/35] bus: fsl-mc-msi: Use msi_desc::msi_index
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:15 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Stuart Yoder <stuyoder@gmail.com>
Cc: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
 drivers/bus/fsl-mc/fsl-mc-allocator.c |    2 +-
 drivers/bus/fsl-mc/fsl-mc-msi.c       |    6 +++---
 include/linux/msi.h                   |   10 ----------
 3 files changed, 4 insertions(+), 14 deletions(-)

--- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
+++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
@@ -393,7 +393,7 @@ int fsl_mc_populate_irq_pool(struct fsl_
 	}
 
 	for_each_msi_entry(msi_desc, &mc_bus_dev->dev) {
-		mc_dev_irq = &irq_resources[msi_desc->fsl_mc.msi_index];
+		mc_dev_irq = &irq_resources[msi_desc->msi_index];
 		mc_dev_irq->msi_desc = msi_desc;
 		mc_dev_irq->resource.id = msi_desc->irq;
 	}
--- a/drivers/bus/fsl-mc/fsl-mc-msi.c
+++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
@@ -29,7 +29,7 @@ static irq_hw_number_t fsl_mc_domain_cal
 	 * Make the base hwirq value for ICID*10000 so it is readable
 	 * as a decimal value in /proc/interrupts.
 	 */
-	return (irq_hw_number_t)(desc->fsl_mc.msi_index + (dev->icid * 10000));
+	return (irq_hw_number_t)(desc->msi_index + (dev->icid * 10000));
 }
 
 static void fsl_mc_msi_set_desc(msi_alloc_info_t *arg,
@@ -122,7 +122,7 @@ static void fsl_mc_msi_write_msg(struct
 	struct fsl_mc_device *mc_bus_dev = to_fsl_mc_device(msi_desc->dev);
 	struct fsl_mc_bus *mc_bus = to_fsl_mc_bus(mc_bus_dev);
 	struct fsl_mc_device_irq *mc_dev_irq =
-		&mc_bus->irq_resources[msi_desc->fsl_mc.msi_index];
+		&mc_bus->irq_resources[msi_desc->msi_index];
 
 	msi_desc->msg = *msg;
 
@@ -235,7 +235,7 @@ static int fsl_mc_msi_alloc_descs(struct
 			goto cleanup_msi_descs;
 		}
 
-		msi_desc->fsl_mc.msi_index = i;
+		msi_desc->msi_index = i;
 		INIT_LIST_HEAD(&msi_desc->list);
 		list_add_tail(&msi_desc->list, dev_to_msi_list(dev));
 	}
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -107,14 +107,6 @@ struct pci_msi_desc {
 };
 
 /**
- * fsl_mc_msi_desc - FSL-MC device specific msi descriptor data
- * @msi_index:		The index of the MSI descriptor
- */
-struct fsl_mc_msi_desc {
-	u16				msi_index;
-};
-
-/**
  * ti_sci_inta_msi_desc - TISCI based INTA specific msi descriptor data
  * @dev_index: TISCI device index
  */
@@ -137,7 +129,6 @@ struct ti_sci_inta_msi_desc {
  *
  * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
  * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
  */
 struct msi_desc {
@@ -158,7 +149,6 @@ struct msi_desc {
 	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
-		struct fsl_mc_msi_desc		fsl_mc;
 		struct ti_sci_inta_msi_desc	inta;
 	};
 };



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244425.422937 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMR-0004Ta-2p; Fri, 10 Dec 2021 22:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244425.422937; Fri, 10 Dec 2021 22:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMQ-0004Ss-TM; Fri, 10 Dec 2021 22:27:26 +0000
Received: by outflank-mailman (input) for mailman id 244425;
 Fri, 10 Dec 2021 22:27:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoER-0005LR-FU
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:11 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32cf2fd8-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32cf2fd8-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.228706214@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174750;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=FY9MZMWsXlGRWGpD4j0ndw3rUmZHrgdx/qnJrYogpAU=;
	b=crLRwjpnFmL9vMNtYINDNn4+8OCsKUZw52CQiHwIVumoubywFORkfBtVSxdUwDOiyGUIps
	SdPbjYumbRS7Dk0Tgi6Y/2GEaoHyNf3xM1ST45hNpPG8I++VRH/Xfyu5M6k0jaiAe1DD/j
	kSWc3pDKfWBD5VYIOD6/b3OT2/vGnA+ynRtfJErlglQ56u3evX1lNm6SY5e5ESQpnC06kx
	rO0rwjrjup3yPCpzY0hbURoWkLwMbwYM4SDBwawx9Oq3kMe6iQYCe3zJnMa+fJfxJQperJ
	mHwXN3+qpbrRWvV5MauCMj8j3vkrSrndxScpReORwflYKATV8Hy8vzh3NpTffg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174750;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=FY9MZMWsXlGRWGpD4j0ndw3rUmZHrgdx/qnJrYogpAU=;
	b=KyrVeJ0G9MOl8qF99M67WEg99zQMMH+5HSv5GJnHZovMto8RmqfPLbkbG09zVhDJ2hpCNg
	8MnOzpWo1zDzWXBQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 17/35] platform-msi: Rename functions and clarify comments
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:09 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

It's hard to distinguish what platform_msi_domain_alloc() and
platform_msi_domain_alloc_irqs() are about. Make the distinction more
explicit and add comments which explain the use cases properly.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c     |   36 +++++++++++++++++++++---------------
 drivers/irqchip/irq-mbigen.c    |    4 ++--
 drivers/irqchip/irq-mvebu-icu.c |    6 +++---
 include/linux/msi.h             |    8 ++++----
 4 files changed, 30 insertions(+), 24 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -313,17 +313,18 @@ EXPORT_SYMBOL_GPL(platform_msi_domain_fr
  *                              a platform-msi domain
  * @domain:	The platform-msi domain
  *
- * Returns the private data provided when calling
- * platform_msi_create_device_domain.
+ * Return: The private data provided when calling
+ * platform_msi_create_device_domain().
  */
 void *platform_msi_get_host_data(struct irq_domain *domain)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
+
 	return data->host_data;
 }
 
 /**
- * __platform_msi_create_device_domain - Create a platform-msi domain
+ * __platform_msi_create_device_domain - Create a platform-msi device domain
  *
  * @dev:		The device generating the MSIs
  * @nvec:		The number of MSIs that need to be allocated
@@ -332,7 +333,11 @@ void *platform_msi_get_host_data(struct
  * @ops:		The hierarchy domain operations to use
  * @host_data:		Private data associated to this domain
  *
- * Returns an irqdomain for @nvec interrupts
+ * Return: An irqdomain for @nvec interrupts on success, NULL in case of error.
+ *
+ * This is for interrupt domains which stack on a platform-msi domain
+ * created by platform_msi_create_irq_domain(). @dev->msi.domain points to
+ * that platform-msi domain which is the parent for the new domain.
  */
 struct irq_domain *
 __platform_msi_create_device_domain(struct device *dev,
@@ -372,18 +377,19 @@ struct irq_domain *
 }
 
 /**
- * platform_msi_domain_free - Free interrupts associated with a platform-msi
- *                            domain
+ * platform_msi_device_domain_free - Free interrupts associated with a platform-msi
+ *				     device domain
  *
- * @domain:	The platform-msi domain
+ * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the free operation
  * @nvec:	How many interrupts to free from @virq
  */
-void platform_msi_domain_free(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nvec)
+void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nvec)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
 	struct msi_desc *desc, *tmp;
+
 	for_each_msi_entry_safe(desc, tmp, data->dev) {
 		if (WARN_ON(!desc->irq || desc->nvec_used != 1))
 			return;
@@ -397,10 +403,10 @@ void platform_msi_domain_free(struct irq
 }
 
 /**
- * platform_msi_domain_alloc - Allocate interrupts associated with
- *			       a platform-msi domain
+ * platform_msi_device_domain_alloc - Allocate interrupts associated with
+ *				      a platform-msi device domain
  *
- * @domain:	The platform-msi domain
+ * @domain:	The platform-msi device domain
  * @virq:	The base irq from which to perform the allocate operation
  * @nr_irqs:	How many interrupts to free from @virq
  *
@@ -408,8 +414,8 @@ void platform_msi_domain_free(struct irq
  * with irq_domain_mutex held (which can only be done as part of a
  * top-level interrupt allocation).
  */
-int platform_msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nr_irqs)
+int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nr_irqs)
 {
 	struct platform_msi_priv_data *data = domain->host_data;
 	int err;
@@ -421,7 +427,7 @@ int platform_msi_domain_alloc(struct irq
 	err = msi_domain_populate_irqs(domain->parent, data->dev,
 				       virq, nr_irqs, &data->arg);
 	if (err)
-		platform_msi_domain_free(domain, virq, nr_irqs);
+		platform_msi_device_domain_free(domain, virq, nr_irqs);
 
 	return err;
 }
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -207,7 +207,7 @@ static int mbigen_irq_domain_alloc(struc
 	if (err)
 		return err;
 
-	err = platform_msi_domain_alloc(domain, virq, nr_irqs);
+	err = platform_msi_device_domain_alloc(domain, virq, nr_irqs);
 	if (err)
 		return err;
 
@@ -223,7 +223,7 @@ static int mbigen_irq_domain_alloc(struc
 static void mbigen_irq_domain_free(struct irq_domain *domain, unsigned int virq,
 				   unsigned int nr_irqs)
 {
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 }
 
 static const struct irq_domain_ops mbigen_domain_ops = {
--- a/drivers/irqchip/irq-mvebu-icu.c
+++ b/drivers/irqchip/irq-mvebu-icu.c
@@ -221,7 +221,7 @@ mvebu_icu_irq_domain_alloc(struct irq_do
 		icu_irqd->icu_group = msi_data->subset_data->icu_group;
 	icu_irqd->icu = icu;
 
-	err = platform_msi_domain_alloc(domain, virq, nr_irqs);
+	err = platform_msi_device_domain_alloc(domain, virq, nr_irqs);
 	if (err) {
 		dev_err(icu->dev, "failed to allocate ICU interrupt in parent domain\n");
 		goto free_irqd;
@@ -245,7 +245,7 @@ mvebu_icu_irq_domain_alloc(struct irq_do
 	return 0;
 
 free_msi:
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 free_irqd:
 	kfree(icu_irqd);
 	return err;
@@ -260,7 +260,7 @@ mvebu_icu_irq_domain_free(struct irq_dom
 
 	kfree(icu_irqd);
 
-	platform_msi_domain_free(domain, virq, nr_irqs);
+	platform_msi_device_domain_free(domain, virq, nr_irqs);
 }
 
 static const struct irq_domain_ops mvebu_icu_domain_ops = {
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -434,10 +434,10 @@ struct irq_domain *
 #define platform_msi_create_device_tree_domain(dev, nvec, write, ops, data) \
 	__platform_msi_create_device_domain(dev, nvec, true, write, ops, data)
 
-int platform_msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nr_irqs);
-void platform_msi_domain_free(struct irq_domain *domain, unsigned int virq,
-			      unsigned int nvec);
+int platform_msi_device_domain_alloc(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nr_irqs);
+void platform_msi_device_domain_free(struct irq_domain *domain, unsigned int virq,
+				     unsigned int nvec);
 void *platform_msi_get_host_data(struct irq_domain *domain);
 #endif /* CONFIG_GENERIC_MSI_IRQ_DOMAIN */
 



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244426.422940 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMR-0004bt-Kp; Fri, 10 Dec 2021 22:27:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244426.422940; Fri, 10 Dec 2021 22:27:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMR-0004Zl-Ee; Fri, 10 Dec 2021 22:27:27 +0000
Received: by outflank-mailman (input) for mailman id 244426;
 Fri, 10 Dec 2021 22:27:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEd-0005LR-HP
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:23 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3a1474a6-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:22 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3a1474a6-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221814.720998720@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174762;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  references:references;
	bh=Y/E/KkLUpd9rNPfDA/zqSwkvkNwtu0uG/q7moMbC6t8=;
	b=Q1loFyA5IlQ3aytzC+w8agXNpV+7qVzWLLt7gFAxD1uipRckq4A63ZDFlRGCLHiD1WXBCo
	w0KWYnAWbGzEZr/4SWaOTeEwWKw1e6hopGrKVSpqVp8bGWUD/cv86yFjYBjUcnEWdvHY3D
	rgx+tAv/GXM3Dr6QCsae7PjKT265v4cKhrWCbRIUXyRZCJMPv6JLxGPJrWrAjiLYk/CNRO
	jYnVtNkau0JyAHELKfNmrLSzDJz7ygURO1IyC5xhunTeJMWngrOu1RR1+HfWrbASO2qYnr
	hwv0O1X8uqWQklUq1DIP73U0V3zNDPJE2TlYjxuEWKoOXEF+hR4iuFZes26TAQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174762;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  references:references;
	bh=Y/E/KkLUpd9rNPfDA/zqSwkvkNwtu0uG/q7moMbC6t8=;
	b=6NW6+PSI7SpPEo0Bw1CpABwRumr4UbWMvCiNUQ1PxVZXboG1DTempdK99XRytho0lXor9m
	bf7Awa33UAb9FuCg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 25/35] powerpc/pseries/msi: Let core code check for
 contiguous entries
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Date: Fri, 10 Dec 2021 23:19:22 +0100 (CET)

RnJvbTogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+CgpTZXQgdGhlIGRvbWFp
biBpbmZvIGZsYWcgYW5kIHJlbW92ZSB0aGUgY2hlY2suCgpTaWduZWQtb2ZmLWJ5OiBUaG9tYXMg
R2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4KUmV2aWV3ZWQtYnk6IEdyZWcgS3JvYWgtSGFy
dG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+CkNjOiBNaWNoYWVsIEVsbGVybWFuIDxt
cGVAZWxsZXJtYW4uaWQuYXU+CkNjOiBCZW5qYW1pbiBIZXJyZW5zY2htaWR0IDxiZW5oQGtlcm5l
bC5jcmFzaGluZy5vcmc+CkNjOiAiQ8OpZHJpYyBMZSBHb2F0ZXIiIDxjbGdAa2FvZC5vcmc+CkNj
OiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwoKLS0tClYyOiBSZW1vdmUgaXQgY29tcGxl
dGVseSAtIENlZHJpYwotLS0KIGFyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcHNlcmllcy9tc2kuYyB8
ICAgMzMgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwg
OCBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCi0tLSBhL2FyY2gvcG93ZXJwYy9wbGF0
Zm9ybXMvcHNlcmllcy9tc2kuYworKysgYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3BzZXJpZXMv
bXNpLmMKQEAgLTMyMSwyNyArMzIxLDYgQEAgc3RhdGljIGludCBtc2lfcXVvdGFfZm9yX2Rldmlj
ZShzdHJ1Y3QgcAogCXJldHVybiByZXF1ZXN0OwogfQogCi1zdGF0aWMgaW50IGNoZWNrX21zaXhf
ZW50cmllcyhzdHJ1Y3QgcGNpX2RldiAqcGRldikKLXsKLQlzdHJ1Y3QgbXNpX2Rlc2MgKmVudHJ5
OwotCWludCBleHBlY3RlZDsKLQotCS8qIFRoZXJlJ3Mgbm8gd2F5IGZvciB1cyB0byBleHByZXNz
IHRvIGZpcm13YXJlIHRoYXQgd2Ugd2FudAotCSAqIGEgZGlzY29udGlndW91cywgb3Igbm9uLXpl
cm8gYmFzZWQsIHJhbmdlIG9mIE1TSS1YIGVudHJpZXMuCi0JICogU28gd2UgbXVzdCByZWplY3Qg
c3VjaCByZXF1ZXN0cy4gKi8KLQotCWV4cGVjdGVkID0gMDsKLQlmb3JfZWFjaF9wY2lfbXNpX2Vu
dHJ5KGVudHJ5LCBwZGV2KSB7Ci0JCWlmIChlbnRyeS0+bXNpX2luZGV4ICE9IGV4cGVjdGVkKSB7
Ci0JCQlwcl9kZWJ1ZygicnRhc19tc2k6IGJhZCBNU0ktWCBlbnRyaWVzLlxuIik7Ci0JCQlyZXR1
cm4gLUVJTlZBTDsKLQkJfQotCQlleHBlY3RlZCsrOwotCX0KLQotCXJldHVybiAwOwotfQotCiBz
dGF0aWMgdm9pZCBydGFzX2hhY2tfMzJiaXRfbXNpX2dlbjIoc3RydWN0IHBjaV9kZXYgKnBkZXYp
CiB7CiAJdTMyIGFkZHJfaGksIGFkZHJfbG87CkBAIC0zODAsOSArMzU5LDYgQEAgc3RhdGljIGlu
dCBydGFzX3ByZXBhcmVfbXNpX2lycXMoc3RydWN0CiAJaWYgKHF1b3RhICYmIHF1b3RhIDwgbnZl
YykKIAkJcmV0dXJuIHF1b3RhOwogCi0JaWYgKHR5cGUgPT0gUENJX0NBUF9JRF9NU0lYICYmIGNo
ZWNrX21zaXhfZW50cmllcyhwZGV2KSkKLQkJcmV0dXJuIC1FSU5WQUw7Ci0KIAkvKgogCSAqIEZp
cm13YXJlIGN1cnJlbnRseSByZWZ1c2UgYW55IG5vbiBwb3dlciBvZiB0d28gYWxsb2NhdGlvbgog
CSAqIHNvIHdlIHJvdW5kIHVwIGlmIHRoZSBxdW90YSB3aWxsIGFsbG93IGl0LgpAQCAtNTI5LDkg
KzUwNSwxNiBAQCBzdGF0aWMgc3RydWN0IGlycV9jaGlwIHBzZXJpZXNfcGNpX21zaV9pCiAJLmly
cV93cml0ZV9tc2lfbXNnCT0gcHNlcmllc19tc2lfd3JpdGVfbXNnLAogfTsKIAorCisvKgorICog
U2V0IE1TSV9GTEFHX01TSVhfQ09OVElHVU9VUyBhcyB0aGVyZSBpcyBubyB3YXkgdG8gZXhwcmVz
cyB0bworICogZmlybXdhcmUgdG8gcmVxdWVzdCBhIGRpc2NvbnRpZ3VvdXMgb3Igbm9uLXplcm8g
YmFzZWQgcmFuZ2Ugb2YKKyAqIE1TSS1YIGVudHJpZXMuIENvcmUgY29kZSB3aWxsIHJlamVjdCBz
dWNoIHNldHVwIGF0dGVtcHRzLgorICovCiBzdGF0aWMgc3RydWN0IG1zaV9kb21haW5faW5mbyBw
c2VyaWVzX21zaV9kb21haW5faW5mbyA9IHsKIAkuZmxhZ3MgPSAoTVNJX0ZMQUdfVVNFX0RFRl9E
T01fT1BTIHwgTVNJX0ZMQUdfVVNFX0RFRl9DSElQX09QUyB8Ci0JCSAgTVNJX0ZMQUdfTVVMVElf
UENJX01TSSAgfCBNU0lfRkxBR19QQ0lfTVNJWCksCisJCSAgTVNJX0ZMQUdfTVVMVElfUENJX01T
SSAgfCBNU0lfRkxBR19QQ0lfTVNJWCB8CisJCSAgTVNJX0ZMQUdfTVNJWF9DT05USUdVT1VTKSwK
IAkub3BzICAgPSAmcHNlcmllc19wY2lfbXNpX2RvbWFpbl9vcHMsCiAJLmNoaXAgID0gJnBzZXJp
ZXNfcGNpX21zaV9pcnFfY2hpcCwKIH07Cgo=


From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244427.422960 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMW-0005jF-4U; Fri, 10 Dec 2021 22:27:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244427.422960; Fri, 10 Dec 2021 22:27:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMV-0005i8-U8; Fri, 10 Dec 2021 22:27:31 +0000
Received: by outflank-mailman (input) for mailman id 244427;
 Fri, 10 Dec 2021 22:27:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEX-0005LK-7I
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:17 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 35f551b7-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:15 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35f551b7-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.413638645@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174755;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BJ+aqs3JuUQKsO3BctVmpLd9eqalaNFkDGZVaSssIBc=;
	b=k/FA321vEFQTINsiDiktMyGPAyhH0HOHkZCclSezrG6bfDxcSWJw0pc09HhkATrVcTQ6ri
	hnJjId+gly+fkrlDn4DuEhi3WKCGyjqiHTOcCpB52ZRAbAlk8habGeq2T/0GeNVFzgwAUX
	gBYdqBwe05ZWKm3yEV/1OxDlUqa0cigus0DWgFdbJPJ3vmGOLYue6+Yu0syUb0lGxp8xak
	nCGKDUWTtT6OhnSQVJaIIJbUTVpVhD0RKT+dIybCA5QzlH4gkNx1aOI/cQQwg1kIu/Xa68
	3n73qNCpmi67D9qbeVEYTKMdvPJ/PoUE6K25W1WCB/0MML/YeRi7L9UO6zR/BQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174755;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=BJ+aqs3JuUQKsO3BctVmpLd9eqalaNFkDGZVaSssIBc=;
	b=NFgEqEdfXbDDPrssrqajhRF703gPYTQxCVwQC4iBxAZurkrpMLpoBqiXkuwb3ZKXaHsc93
	9WV1M1CndmpxrRBA==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 20/35] platform-msi: Use msi_desc::msi_index
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:14 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Use the common msi_index member and get rid of the pointless wrapper struct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c                 |   10 +++++-----
 drivers/dma/qcom/hidma.c                    |    4 ++--
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |    4 ++--
 drivers/mailbox/bcm-flexrm-mailbox.c        |    4 ++--
 include/linux/msi.h                         |   10 ----------
 5 files changed, 11 insertions(+), 21 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -40,7 +40,7 @@ static irq_hw_number_t platform_msi_calc
 {
 	u32 devid = desc->dev->msi.data->platform_data->devid;
 
-	return (devid << (32 - DEV_ID_SHIFT)) | desc->platform.msi_index;
+	return (devid << (32 - DEV_ID_SHIFT)) | desc->msi_index;
 }
 
 static void platform_msi_set_desc(msi_alloc_info_t *arg, struct msi_desc *desc)
@@ -112,8 +112,8 @@ static void platform_msi_free_descs(stru
 	struct msi_desc *desc, *tmp;
 
 	list_for_each_entry_safe(desc, tmp, dev_to_msi_list(dev), list) {
-		if (desc->platform.msi_index >= base &&
-		    desc->platform.msi_index < (base + nvec)) {
+		if (desc->msi_index >= base &&
+		    desc->msi_index < (base + nvec)) {
 			list_del(&desc->list);
 			free_msi_entry(desc);
 		}
@@ -129,7 +129,7 @@ static int platform_msi_alloc_descs_with
 	if (!list_empty(dev_to_msi_list(dev))) {
 		desc = list_last_entry(dev_to_msi_list(dev),
 				       struct msi_desc, list);
-		base = desc->platform.msi_index + 1;
+		base = desc->msi_index + 1;
 	}
 
 	for (i = 0; i < nvec; i++) {
@@ -137,7 +137,7 @@ static int platform_msi_alloc_descs_with
 		if (!desc)
 			break;
 
-		desc->platform.msi_index = base + i;
+		desc->msi_index = base + i;
 		desc->irq = virq ? virq + i : 0;
 
 		list_add_tail(&desc->list, dev_to_msi_list(dev));
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -666,7 +666,7 @@ static void hidma_write_msi_msg(struct m
 	struct device *dev = msi_desc_to_dev(desc);
 	struct hidma_dev *dmadev = dev_get_drvdata(dev);
 
-	if (!desc->platform.msi_index) {
+	if (!desc->msi_index) {
 		writel(msg->address_lo, dmadev->dev_evca + 0x118);
 		writel(msg->address_hi, dmadev->dev_evca + 0x11C);
 		writel(msg->data, dmadev->dev_evca + 0x120);
@@ -702,7 +702,7 @@ static int hidma_request_msi(struct hidm
 		return rc;
 
 	for_each_msi_entry(desc, &pdev->dev) {
-		if (!desc->platform.msi_index)
+		if (!desc->msi_index)
 			dmadev->msi_virqbase = desc->irq;
 
 		rc = devm_request_irq(&pdev->dev, desc->irq,
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3142,7 +3142,7 @@ static void arm_smmu_write_msi_msg(struc
 	phys_addr_t doorbell;
 	struct device *dev = msi_desc_to_dev(desc);
 	struct arm_smmu_device *smmu = dev_get_drvdata(dev);
-	phys_addr_t *cfg = arm_smmu_msi_cfg[desc->platform.msi_index];
+	phys_addr_t *cfg = arm_smmu_msi_cfg[desc->msi_index];
 
 	doorbell = (((u64)msg->address_hi) << 32) | msg->address_lo;
 	doorbell &= MSI_CFG0_ADDR_MASK;
@@ -3183,7 +3183,7 @@ static void arm_smmu_setup_msis(struct a
 	}
 
 	for_each_msi_entry(desc, dev) {
-		switch (desc->platform.msi_index) {
+		switch (desc->msi_index) {
 		case EVTQ_MSI_INDEX:
 			smmu->evtq.q.irq = desc->irq;
 			break;
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1484,7 +1484,7 @@ static void flexrm_mbox_msi_write(struct
 {
 	struct device *dev = msi_desc_to_dev(desc);
 	struct flexrm_mbox *mbox = dev_get_drvdata(dev);
-	struct flexrm_ring *ring = &mbox->rings[desc->platform.msi_index];
+	struct flexrm_ring *ring = &mbox->rings[desc->msi_index];
 
 	/* Configure per-Ring MSI registers */
 	writel_relaxed(msg->address_lo, ring->regs + RING_MSI_ADDR_LS);
@@ -1609,7 +1609,7 @@ static int flexrm_mbox_probe(struct plat
 
 	/* Save alloced IRQ numbers for each ring */
 	for_each_msi_entry(desc, dev) {
-		ring = &mbox->rings[desc->platform.msi_index];
+		ring = &mbox->rings[desc->msi_index];
 		ring->irq = desc->irq;
 	}
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -107,14 +107,6 @@ struct pci_msi_desc {
 };
 
 /**
- * platform_msi_desc - Platform device specific msi descriptor data
- * @msi_index:		The index of the MSI descriptor for multi MSI
- */
-struct platform_msi_desc {
-	u16				msi_index;
-};
-
-/**
  * fsl_mc_msi_desc - FSL-MC device specific msi descriptor data
  * @msi_index:		The index of the MSI descriptor
  */
@@ -145,7 +137,6 @@ struct ti_sci_inta_msi_desc {
  *
  * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
- * @platform:	[platform]  Platform device specific msi descriptor data
  * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
  * @inta:	[INTA]	    TISCI based INTA specific msi descriptor data
  */
@@ -167,7 +158,6 @@ struct msi_desc {
 	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
-		struct platform_msi_desc	platform;
 		struct fsl_mc_msi_desc		fsl_mc;
 		struct ti_sci_inta_msi_desc	inta;
 	};



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244434.422972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMY-0006IN-Qr; Fri, 10 Dec 2021 22:27:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244434.422972; Fri, 10 Dec 2021 22:27:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMY-0006I6-Jo; Fri, 10 Dec 2021 22:27:34 +0000
Received: by outflank-mailman (input) for mailman id 244434;
 Fri, 10 Dec 2021 22:27:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEc-0005LK-4p
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:22 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39411ad0-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39411ad0-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.662401116@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=B95vILF4f96+HtIHGYc7a4tJjZ074d989NcBwfF9o/k=;
	b=fIOwaXb6T7YmYbzCNcuFWouRC2zGGXVRlsUgpqqFOIV0PyrJoOnT+aoyDMVKNK2A6krAZI
	XSQeEqbaRaAtK4VvrlqFro0SB1vhErnfxWhzQgwr+qsDk36wQ+eFWHO7jp23E3M3puDi35
	953o11ODU0TeOVEvTYbYoheZAqmksy26rdvmfI7PBx5P15pbca7UNafWBkDO+hECvHFdj9
	Yev9a5GN8EarusWwFqVi4o0AwKm0r+2eGINSSeQt7Q5FKkUK03tvPM0NomazmAYBA/cAga
	y3ObQUixyXi6+XAFUJSYrz1VSQAlbkSi94tipek580Cs/VN2H2S5HEWAnMSsvw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=B95vILF4f96+HtIHGYc7a4tJjZ074d989NcBwfF9o/k=;
	b=Te6lNiwtavfKOApR2IhAxEwWLE9W8Bb3G/p8b6YTrFg+8nzwR06UFSXrmPjpS92tCkMg5/
	Nkw6+1agFZw6IeBg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Bjorn Helgaas <bhelgaas@google.com>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 24/35] PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUS
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:20 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Provide a domain info flag which makes the core code check for a contiguous
MSI-X index on allocation. That's simpler than checking it at some other
domain callback in architecture code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>

---
 drivers/pci/msi/irqdomain.c |   16 ++++++++++++++--
 include/linux/msi.h         |    2 ++
 2 files changed, 16 insertions(+), 2 deletions(-)

--- a/drivers/pci/msi/irqdomain.c
+++ b/drivers/pci/msi/irqdomain.c
@@ -89,9 +89,21 @@ static int pci_msi_domain_check_cap(stru
 	if (pci_msi_desc_is_multi_msi(desc) &&
 	    !(info->flags & MSI_FLAG_MULTI_PCI_MSI))
 		return 1;
-	else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX))
-		return -ENOTSUPP;
 
+	if (desc->pci.msi_attrib.is_msix) {
+		if (!(info->flags & MSI_FLAG_PCI_MSIX))
+			return -ENOTSUPP;
+
+		if (info->flags & MSI_FLAG_MSIX_CONTIGUOUS) {
+			unsigned int idx = 0;
+
+			/* Check for gaps in the entry indices */
+			for_each_msi_entry(desc, dev) {
+				if (desc->msi_index != idx++)
+					return -ENOTSUPP;
+			}
+		}
+	}
 	return 0;
 }
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -361,6 +361,8 @@ enum {
 	MSI_FLAG_LEVEL_CAPABLE		= (1 << 6),
 	/* Populate sysfs on alloc() and destroy it on free() */
 	MSI_FLAG_DEV_SYSFS		= (1 << 7),
+	/* MSI-X entries must be contiguous */
+	MSI_FLAG_MSIX_CONTIGUOUS	= (1 << 8),
 };
 
 int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244435.422981 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMa-0006hR-Eo; Fri, 10 Dec 2021 22:27:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244435.422981; Fri, 10 Dec 2021 22:27:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMa-0006e8-4m; Fri, 10 Dec 2021 22:27:36 +0000
Received: by outflank-mailman (input) for mailman id 244435;
 Fri, 10 Dec 2021 22:27:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEs-0005LK-Cz
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:38 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42df48a3-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42df48a3-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221815.269468319@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174776;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=vWoIYZmWx3H0h9pFUJiUBADTUR4l5NcbszlCZMu1Kwk=;
	b=VY9AhPc6Y86iy9XnKaKC022X5LX2E1Sin0mw6tqrZ3osyzhE+2W7SgnSBOgXimvkWKulED
	l4AuEUnopvI0lV/tgmo9e24Dfo6ML2fTsHk9X0iLcJ22dC2ADIYHepaTVbk5XFH3pO3wRH
	29E4/m4y7LIeWYmEDeaZq0LcdgImdDpC2mfPGC6zarCUVVtau23HzuA1JELcqLNznzIKv/
	EiD8V5EophlaHy5XIW5/kNy//V9j9uzcT0LENNV9cAgIYxQ/RjQU3v+6A+2zr9hQU7S1ZZ
	XsNiTChg6t09pw/yjxLmwIAqVQpTFeYErMOSAEzKecIm846Z0MDkmHqG1chyoQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174776;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=vWoIYZmWx3H0h9pFUJiUBADTUR4l5NcbszlCZMu1Kwk=;
	b=nm4LR+v2Mbj1oO9KG+4c2hdaYxWpH8aXSxojWvNUkbO4swV7whxzoVJADykQyKGVACgArD
	5K9p/ZVSiPs35tCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of
 ti_sci_inta_msi_get_virq()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:35 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Just use the core function msi_get_virq().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/ti/k3-udma-private.c       |    6 ++----
 drivers/dma/ti/k3-udma.c               |   10 ++++------
 drivers/soc/ti/k3-ringacc.c            |    2 +-
 drivers/soc/ti/ti_sci_inta_msi.c       |   12 ------------
 include/linux/soc/ti/ti_sci_inta_msi.h |    1 -
 5 files changed, 7 insertions(+), 24 deletions(-)

--- a/drivers/dma/ti/k3-udma-private.c
+++ b/drivers/dma/ti/k3-udma-private.c
@@ -168,8 +168,7 @@ int xudma_pktdma_tflow_get_irq(struct ud
 {
 	const struct udma_oes_offsets *oes = &ud->soc_data->oes;
 
-	return ti_sci_inta_msi_get_virq(ud->dev, udma_tflow_id +
-					oes->pktdma_tchan_flow);
+	return msi_get_virq(ud->dev, udma_tflow_id + oes->pktdma_tchan_flow);
 }
 EXPORT_SYMBOL(xudma_pktdma_tflow_get_irq);
 
@@ -177,7 +176,6 @@ int xudma_pktdma_rflow_get_irq(struct ud
 {
 	const struct udma_oes_offsets *oes = &ud->soc_data->oes;
 
-	return ti_sci_inta_msi_get_virq(ud->dev, udma_rflow_id +
-					oes->pktdma_rchan_flow);
+	return msi_get_virq(ud->dev, udma_rflow_id + oes->pktdma_rchan_flow);
 }
 EXPORT_SYMBOL(xudma_pktdma_rflow_get_irq);
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -2313,8 +2313,7 @@ static int udma_alloc_chan_resources(str
 
 	/* Event from UDMA (TR events) only needed for slave TR mode channels */
 	if (is_slave_direction(uc->config.dir) && !uc->config.pkt_mode) {
-		uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
-							    irq_udma_idx);
+		uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
 		if (uc->irq_num_udma <= 0) {
 			dev_err(ud->dev, "Failed to get udma irq (index: %u)\n",
 				irq_udma_idx);
@@ -2486,7 +2485,7 @@ static int bcdma_alloc_chan_resources(st
 		uc->psil_paired = true;
 	}
 
-	uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
+	uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
 	if (uc->irq_num_ring <= 0) {
 		dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
 			irq_ring_idx);
@@ -2503,8 +2502,7 @@ static int bcdma_alloc_chan_resources(st
 
 	/* Event from BCDMA (TR events) only needed for slave channels */
 	if (is_slave_direction(uc->config.dir)) {
-		uc->irq_num_udma = ti_sci_inta_msi_get_virq(ud->dev,
-							    irq_udma_idx);
+		uc->irq_num_udma = msi_get_virq(ud->dev, irq_udma_idx);
 		if (uc->irq_num_udma <= 0) {
 			dev_err(ud->dev, "Failed to get bcdma irq (index: %u)\n",
 				irq_udma_idx);
@@ -2672,7 +2670,7 @@ static int pktdma_alloc_chan_resources(s
 
 	uc->psil_paired = true;
 
-	uc->irq_num_ring = ti_sci_inta_msi_get_virq(ud->dev, irq_ring_idx);
+	uc->irq_num_ring = msi_get_virq(ud->dev, irq_ring_idx);
 	if (uc->irq_num_ring <= 0) {
 		dev_err(ud->dev, "Failed to get ring irq (index: %u)\n",
 			irq_ring_idx);
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -647,7 +647,7 @@ int k3_ringacc_get_ring_irq_num(struct k
 	if (!ring)
 		return -EINVAL;
 
-	irq_num = ti_sci_inta_msi_get_virq(ring->parent->dev, ring->ring_id);
+	irq_num = msi_get_virq(ring->parent->dev, ring->ring_id);
 	if (irq_num <= 0)
 		irq_num = -EINVAL;
 	return irq_num;
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -148,15 +148,3 @@ void ti_sci_inta_msi_domain_free_irqs(st
 	ti_sci_inta_msi_free_descs(dev);
 }
 EXPORT_SYMBOL_GPL(ti_sci_inta_msi_domain_free_irqs);
-
-unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 dev_index)
-{
-	struct msi_desc *desc;
-
-	for_each_msi_entry(desc, dev)
-		if (desc->msi_index == dev_index)
-			return desc->irq;
-
-	return -ENODEV;
-}
-EXPORT_SYMBOL_GPL(ti_sci_inta_msi_get_virq);
--- a/include/linux/soc/ti/ti_sci_inta_msi.h
+++ b/include/linux/soc/ti/ti_sci_inta_msi.h
@@ -18,6 +18,5 @@ struct irq_domain
 				   struct irq_domain *parent);
 int ti_sci_inta_msi_domain_alloc_irqs(struct device *dev,
 				      struct ti_sci_resource *res);
-unsigned int ti_sci_inta_msi_get_virq(struct device *dev, u32 index);
 void ti_sci_inta_msi_domain_free_irqs(struct device *dev);
 #endif /* __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H */



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244447.422999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMo-0000An-8r; Fri, 10 Dec 2021 22:27:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244447.422999; Fri, 10 Dec 2021 22:27:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMn-00009L-W3; Fri, 10 Dec 2021 22:27:49 +0000
Received: by outflank-mailman (input) for mailman id 244447;
 Fri, 10 Dec 2021 22:27:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoET-0005LK-0t
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:13 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 33b0f2ed-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:12 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33b0f2ed-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.287680528@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174751;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=zIZczyRlH4Mx4fB5mmlODqe9FKNOKEFU5ncWnwPgL4o=;
	b=A7TX/LnwMZ3WbXEnRoPrDP/wLd2iphxwXGgFB2xNDcix6PjdERSNAqWZP3cDL+ul1e+OgS
	XZwjDctIfCLuV18Dm1hv3qTKEaY6pfv6/JrJwTE0Zi/Mq6iBPgIO6QtvtT1kN6nSLPvNPW
	0u0s7/PZpPkZNxO2RTqbZAkwSRF23scy5J5cf67INwsZCQZA1X62o97PiKxMfxj6o8/GxZ
	aO9H2WxcI08XgbYFKtYRHKYr0lWyDUFfBt68wukumRk/J7k3llF+aqTWeB78Uo5s/n8eAj
	eO0F5f71EAQkycZW2+2rOZR7xc5Gp2SnvBytgZ4S05qo6bkqWTDwARQoLAvwQA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174751;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=zIZczyRlH4Mx4fB5mmlODqe9FKNOKEFU5ncWnwPgL4o=;
	b=/snRPAepbgN6BXoxpR9Y/cwG/pUn2U+BFbd6X9S/kPABlfdlYLuradGw7bcnIwrFcdQcFh
	R0NHGOxeEpedSOCw==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 18/35] platform-msi: Store platform private data pointer in
 msi_device_data
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:11 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Storing the platform private data in a MSI descriptor is sloppy at
best. The data belongs to the device and not to the descriptor.
Add a pointer to struct msi_device_data and store the pointer there.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 drivers/base/platform-msi.c |   79 +++++++++++++++++---------------------------
 include/linux/msi.h         |    4 +-
 2 files changed, 34 insertions(+), 49 deletions(-)

--- a/drivers/base/platform-msi.c
+++ b/drivers/base/platform-msi.c
@@ -38,9 +38,7 @@ static DEFINE_IDA(platform_msi_devid_ida
  */
 static irq_hw_number_t platform_msi_calc_hwirq(struct msi_desc *desc)
 {
-	u32 devid;
-
-	devid = desc->platform.msi_priv_data->devid;
+	u32 devid = desc->dev->msi.data->platform_data->devid;
 
 	return (devid << (32 - DEV_ID_SHIFT)) | desc->platform.msi_index;
 }
@@ -85,11 +83,8 @@ static void platform_msi_update_dom_ops(
 static void platform_msi_write_msg(struct irq_data *data, struct msi_msg *msg)
 {
 	struct msi_desc *desc = irq_data_get_msi_desc(data);
-	struct platform_msi_priv_data *priv_data;
-
-	priv_data = desc->platform.msi_priv_data;
 
-	priv_data->write_msg(desc, msg);
+	desc->dev->msi.data->platform_data->write_msg(desc, msg);
 }
 
 static void platform_msi_update_chip_ops(struct msi_domain_info *info)
@@ -126,9 +121,7 @@ static void platform_msi_free_descs(stru
 }
 
 static int platform_msi_alloc_descs_with_irq(struct device *dev, int virq,
-					     int nvec,
-					     struct platform_msi_priv_data *data)
-
+					     int nvec)
 {
 	struct msi_desc *desc;
 	int i, base = 0;
@@ -144,7 +137,6 @@ static int platform_msi_alloc_descs_with
 		if (!desc)
 			break;
 
-		desc->platform.msi_priv_data = data;
 		desc->platform.msi_index = base + i;
 		desc->irq = virq ? virq + i : 0;
 
@@ -161,11 +153,9 @@ static int platform_msi_alloc_descs_with
 	return 0;
 }
 
-static int platform_msi_alloc_descs(struct device *dev, int nvec,
-				    struct platform_msi_priv_data *data)
-
+static int platform_msi_alloc_descs(struct device *dev, int nvec)
 {
-	return platform_msi_alloc_descs_with_irq(dev, 0, nvec, data);
+	return platform_msi_alloc_descs_with_irq(dev, 0, nvec);
 }
 
 /**
@@ -199,9 +189,8 @@ struct irq_domain *platform_msi_create_i
 	return domain;
 }
 
-static struct platform_msi_priv_data *
-platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec,
-			     irq_write_msi_msg_t write_msi_msg)
+static int platform_msi_alloc_priv_data(struct device *dev, unsigned int nvec,
+					irq_write_msi_msg_t write_msi_msg)
 {
 	struct platform_msi_priv_data *datap;
 	int err;
@@ -213,41 +202,44 @@ platform_msi_alloc_priv_data(struct devi
 	 * capable devices).
 	 */
 	if (!dev->msi.domain || !write_msi_msg || !nvec || nvec > MAX_DEV_MSIS)
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 
 	if (dev->msi.domain->bus_token != DOMAIN_BUS_PLATFORM_MSI) {
 		dev_err(dev, "Incompatible msi_domain, giving up\n");
-		return ERR_PTR(-EINVAL);
+		return -EINVAL;
 	}
 
 	err = msi_setup_device_data(dev);
 	if (err)
-		return ERR_PTR(err);
+		return err;
 
-	/* Already had a helping of MSI? Greed... */
-	if (!list_empty(dev_to_msi_list(dev)))
-		return ERR_PTR(-EBUSY);
+	/* Already initialized? */
+	if (dev->msi.data->platform_data)
+		return -EBUSY;
 
 	datap = kzalloc(sizeof(*datap), GFP_KERNEL);
 	if (!datap)
-		return ERR_PTR(-ENOMEM);
+		return -ENOMEM;
 
 	datap->devid = ida_simple_get(&platform_msi_devid_ida,
 				      0, 1 << DEV_ID_SHIFT, GFP_KERNEL);
 	if (datap->devid < 0) {
 		err = datap->devid;
 		kfree(datap);
-		return ERR_PTR(err);
+		return err;
 	}
 
 	datap->write_msg = write_msi_msg;
 	datap->dev = dev;
-
-	return datap;
+	dev->msi.data->platform_data = datap;
+	return 0;
 }
 
-static void platform_msi_free_priv_data(struct platform_msi_priv_data *data)
+static void platform_msi_free_priv_data(struct device *dev)
 {
+	struct platform_msi_priv_data *data = dev->msi.data->platform_data;
+
+	dev->msi.data->platform_data = NULL;
 	ida_simple_remove(&platform_msi_devid_ida, data->devid);
 	kfree(data);
 }
@@ -264,14 +256,13 @@ static void platform_msi_free_priv_data(
 int platform_msi_domain_alloc_irqs(struct device *dev, unsigned int nvec,
 				   irq_write_msi_msg_t write_msi_msg)
 {
-	struct platform_msi_priv_data *priv_data;
 	int err;
 
-	priv_data = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
-	if (IS_ERR(priv_data))
-		return PTR_ERR(priv_data);
+	err = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
+	if (err)
+		return err;
 
-	err = platform_msi_alloc_descs(dev, nvec, priv_data);
+	err = platform_msi_alloc_descs(dev, nvec);
 	if (err)
 		goto out_free_priv_data;
 
@@ -284,8 +275,7 @@ int platform_msi_domain_alloc_irqs(struc
 out_free_desc:
 	platform_msi_free_descs(dev, 0, nvec);
 out_free_priv_data:
-	platform_msi_free_priv_data(priv_data);
-
+	platform_msi_free_priv_data(dev);
 	return err;
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_alloc_irqs);
@@ -296,15 +286,9 @@ EXPORT_SYMBOL_GPL(platform_msi_domain_al
  */
 void platform_msi_domain_free_irqs(struct device *dev)
 {
-	if (!list_empty(dev_to_msi_list(dev))) {
-		struct msi_desc *desc;
-
-		desc = first_msi_entry(dev);
-		platform_msi_free_priv_data(desc->platform.msi_priv_data);
-	}
-
 	msi_domain_free_irqs(dev->msi.domain, dev);
 	platform_msi_free_descs(dev, 0, MAX_DEV_MSIS);
+	platform_msi_free_priv_data(dev);
 }
 EXPORT_SYMBOL_GPL(platform_msi_domain_free_irqs);
 
@@ -351,10 +335,11 @@ struct irq_domain *
 	struct irq_domain *domain;
 	int err;
 
-	data = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
-	if (IS_ERR(data))
+	err = platform_msi_alloc_priv_data(dev, nvec, write_msi_msg);
+	if (err)
 		return NULL;
 
+	data = dev->msi.data->platform_data;
 	data->host_data = host_data;
 	domain = irq_domain_create_hierarchy(dev->msi.domain, 0,
 					     is_tree ? 0 : nvec,
@@ -372,7 +357,7 @@ struct irq_domain *
 free_domain:
 	irq_domain_remove(domain);
 free_priv:
-	platform_msi_free_priv_data(data);
+	platform_msi_free_priv_data(dev);
 	return NULL;
 }
 
@@ -420,7 +405,7 @@ int platform_msi_device_domain_alloc(str
 	struct platform_msi_priv_data *data = domain->host_data;
 	int err;
 
-	err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs, data);
+	err = platform_msi_alloc_descs_with_irq(data->dev, virq, nr_irqs);
 	if (err)
 		return err;
 
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -108,11 +108,9 @@ struct pci_msi_desc {
 
 /**
  * platform_msi_desc - Platform device specific msi descriptor data
- * @msi_priv_data:	Pointer to platform private data
  * @msi_index:		The index of the MSI descriptor for multi MSI
  */
 struct platform_msi_desc {
-	struct platform_msi_priv_data	*msi_priv_data;
 	u16				msi_index;
 };
 
@@ -177,10 +175,12 @@ struct msi_desc {
  * msi_device_data - MSI per device data
  * @properties:		MSI properties which are interesting to drivers
  * @attrs:		Pointer to the sysfs attribute group
+ * @platform_data:	Platform-MSI specific data
  */
 struct msi_device_data {
 	unsigned long			properties;
 	const struct attribute_group    **attrs;
+	struct platform_msi_priv_data	*platform_data;
 };
 
 int msi_setup_device_data(struct device *dev);



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244446.422994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMn-00005S-Qc; Fri, 10 Dec 2021 22:27:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244446.422994; Fri, 10 Dec 2021 22:27:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMn-00005H-Lx; Fri, 10 Dec 2021 22:27:49 +0000
Received: by outflank-mailman (input) for mailman id 244446;
 Fri, 10 Dec 2021 22:27:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEm-0005LR-P3
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:32 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3fa12211-5a07-11ec-ad7a-b7ef48004f0a;
 Fri, 10 Dec 2021 23:19:32 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3fa12211-5a07-11ec-ad7a-b7ef48004f0a
Message-ID: <20211210221815.089008198@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174771;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=1PKR2Prd+1Li94AkrvejzHYXvOdiS0rHF3AWjJOJ+hY=;
	b=EXT6ZJHiL9WrQC63pWNeqEY7SfF3jIeVCos8i7xIZwHprSzmRcoSNiXrPRfeBGlX/4efFg
	GKBzvkr1hfP/TIvTDbw4CCeW2qNJNT1Mrz8mlT8JOpccmtfR+od0ZQ9AQUNq6SHiF7UA3t
	gC95XdhE8YJZ9o2I7sAZvmGtCHXLa+d9dwdc4G0asxf97pWkhPvcdF3TvGUziuRsuYw+ql
	n5cM46TBOVor1arusxIXF8fp7Wzk5TqiI9gjuel4qNwYdCdafKWtXUXZHfuM6B8FoM+RnC
	Gr+GIxVCgZ+BZGSsHPWLRtVqrhQbLaB0ZKkw3F8DrRN180qyN2lempVXeHraIQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174771;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=1PKR2Prd+1Li94AkrvejzHYXvOdiS0rHF3AWjJOJ+hY=;
	b=Q87ZFBVcPUXRgAfqqpqy/zVPxQ4IgjxdQfabAhW5+cvr8SXGLARh4lgGWZYcuCireCH7xW
	qehr/nAEfvi/OQDg==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Will Deacon <will@kernel.org>,
 Joerg Roedel <joro@8bytes.org>,
 linux-arm-kernel@lists.infradead.org,
 iommu@lists.linux-foundation.org,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 31/35] iommu/arm-smmu-v3: Use msi_get_virq()
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:31 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

Let the core code fiddle with the MSI descriptor retrieval.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Will Deacon <will@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: iommu@lists.linux-foundation.org

---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |   19 +++----------------
 1 file changed, 3 insertions(+), 16 deletions(-)

--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -3154,7 +3154,6 @@ static void arm_smmu_write_msi_msg(struc
 
 static void arm_smmu_setup_msis(struct arm_smmu_device *smmu)
 {
-	struct msi_desc *desc;
 	int ret, nvec = ARM_SMMU_MAX_MSIS;
 	struct device *dev = smmu->dev;
 
@@ -3182,21 +3181,9 @@ static void arm_smmu_setup_msis(struct a
 		return;
 	}
 
-	for_each_msi_entry(desc, dev) {
-		switch (desc->msi_index) {
-		case EVTQ_MSI_INDEX:
-			smmu->evtq.q.irq = desc->irq;
-			break;
-		case GERROR_MSI_INDEX:
-			smmu->gerr_irq = desc->irq;
-			break;
-		case PRIQ_MSI_INDEX:
-			smmu->priq.q.irq = desc->irq;
-			break;
-		default:	/* Unknown */
-			continue;
-		}
-	}
+	smmu->evtq.q.irq = msi_get_virq(dev, EVTQ_MSI_INDEX);
+	smmu->gerr_irq = msi_get_virq(dev, GERROR_MSI_INDEX);
+	smmu->priq.q.irq = msi_get_virq(dev, PRIQ_MSI_INDEX);
 
 	/* Add callback to free MSIs on teardown */
 	devm_add_action(dev, arm_smmu_free_msis, dev);



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 22:27:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 22:27:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244452.423016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMv-0001Bu-Qc; Fri, 10 Dec 2021 22:27:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244452.423016; Fri, 10 Dec 2021 22:27:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvoMv-0001Bc-Ma; Fri, 10 Dec 2021 22:27:57 +0000
Received: by outflank-mailman (input) for mailman id 244452;
 Fri, 10 Dec 2021 22:27:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nm8/=Q3=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mvoEV-0005LK-14
 for xen-devel@lists.xenproject.org; Fri, 10 Dec 2021 22:19:15 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3497537f-5a07-11ec-a74f-db008197e53d;
 Fri, 10 Dec 2021 23:19:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3497537f-5a07-11ec-a74f-db008197e53d
Message-ID: <20211210221814.350967317@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639174753;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OiOpnus/jgb4RvtQJgk+f5PDfD1lWJHYgR9yAXQeu2I=;
	b=GqNHND5vQFfn8YzyhGofKZeaI5YQY13nUcIcEAnApVoYxde41u4gvkSMQaoDkklgWgL6Zk
	wHK3PJ2ZfWbYxMme7FaxL39snJIf0wZL5rHbzsTnJnEy6rOrqOZLuFMip60nKRVfr+lj/W
	BHXCzw1n2FEVbVuPbkWSyTdPAv+7+HaOx4FixB2V+JT0YpatDIYYDU4l+QGR4JfC9ST/QQ
	ngLKa+qq7x59ird4H3MCqjWV28aq/HayJ/tjTE/75JamD316Ym4S0uX+2lXQI9IZaj0SWh
	AKr8ZMfxglw+5yokSrUK5V9ferJK273x0+5I6KMvkrEpEnp1TSxk47w6CwmNQA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639174753;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 references:references; bh=OiOpnus/jgb4RvtQJgk+f5PDfD1lWJHYgR9yAXQeu2I=;
	b=HkiV41WymK0ae47Xnth9tBZ2L/9zjtZHSoLnNC/O478xU6oHNx8HK4b2wxQ3RzFd2wVYMW
	SUUWu6Lvp/P2vTDQ==
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>,
 Alex Williamson <alex.williamson@redhat.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>,
 Megha Dey <megha.dey@intel.com>,
 Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org,
 Cedric Le Goater <clg@kaod.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org,
 Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>,
 Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>,
 Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>,
 Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org,
 Mark Rutland <mark.rutland@arm.com>,
 Will Deacon <will@kernel.org>,
 Robin Murphy <robin.murphy@arm.com>,
 Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org,
 Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: [patch V3 19/35] genirq/msi: Consolidate MSI descriptor data
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Date: Fri, 10 Dec 2021 23:19:12 +0100 (CET)

From: Thomas Gleixner <tglx@linutronix.de>

All non PCI/MSI usage variants have data structures in struct msi_desc with
only one member: xxx_index. PCI/MSI has a entry_nr member.

Add a common msi_index member to struct msi_desc so all implementations can
share it which allows further consolidation.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
---
 include/linux/msi.h |    2 ++
 1 file changed, 2 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -143,6 +143,7 @@ struct ti_sci_inta_msi_desc {
  *			address or data changes
  * @write_msi_msg_data:	Data parameter for the callback.
  *
+ * @msi_index:	Index of the msi descriptor
  * @pci:	[PCI]	    PCI speficic msi descriptor data
  * @platform:	[platform]  Platform device specific msi descriptor data
  * @fsl_mc:	[fsl-mc]    FSL MC device specific msi descriptor data
@@ -163,6 +164,7 @@ struct msi_desc {
 	void (*write_msi_msg)(struct msi_desc *entry, void *data);
 	void *write_msi_msg_data;
 
+	u16				msi_index;
 	union {
 		struct pci_msi_desc		pci;
 		struct platform_msi_desc	platform;



From xen-devel-bounces@lists.xenproject.org Fri Dec 10 23:03:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 10 Dec 2021 23:03:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244586.423026 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvovC-0000IH-Gf; Fri, 10 Dec 2021 23:03:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244586.423026; Fri, 10 Dec 2021 23:03:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvovC-0000IA-DT; Fri, 10 Dec 2021 23:03:22 +0000
Received: by outflank-mailman (input) for mailman id 244586;
 Fri, 10 Dec 2021 23:03:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvovB-0000Hz-O8; Fri, 10 Dec 2021 23:03:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvovB-0000QS-Jf; Fri, 10 Dec 2021 23:03:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvovB-0004R1-Bg; Fri, 10 Dec 2021 23:03:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvovB-0007v4-BC; Fri, 10 Dec 2021 23:03:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WX0B+CvY0zY/cUo5mLLyv5xVO6pLkNrBBdhEJFeQdB0=; b=WkEFzhtJi5hNQ4nFICQbKeFUXu
	Ua0YNQlsIGobSB+pSmiH1g+TIkXbURgQe4Bg6fBa/D9HU5FUF1Do0n0OuoSPTCcC8uKmjGBogx62N
	0IJWLZCIfpQdvfkrud3zAgB1378JItsS3yoSosf9NKsYT3ovFvTqjlOLIaSPntES0I5Q=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167353-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167353: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 10 Dec 2021 23:03:21 +0000

flight 167353 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167353/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   39 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 00:48:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 00:48:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244606.423041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvqY0-0008PV-Mb; Sat, 11 Dec 2021 00:47:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244606.423041; Sat, 11 Dec 2021 00:47:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvqY0-0008PO-JV; Sat, 11 Dec 2021 00:47:32 +0000
Received: by outflank-mailman (input) for mailman id 244606;
 Sat, 11 Dec 2021 00:47:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Vst5=Q4=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1mvqXz-0008PH-5u
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 00:47:31 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e9058ae3-5a1b-11ec-ad7a-b7ef48004f0a;
 Sat, 11 Dec 2021 01:47:27 +0100 (CET)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BANhjFO012859; 
 Sat, 11 Dec 2021 00:47:16 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cve1vgakv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 11 Dec 2021 00:47:16 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BB0kHOe112107;
 Sat, 11 Dec 2021 00:47:15 GMT
Received: from nam12-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44])
 by aserp3020.oracle.com with ESMTP id 3cr05a0614-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Sat, 11 Dec 2021 00:47:14 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2785.namprd10.prod.outlook.com (2603:10b6:208:73::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Sat, 11 Dec
 2021 00:47:12 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4778.016; Sat, 11 Dec 2021
 00:47:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e9058ae3-5a1b-11ec-ad7a-b7ef48004f0a
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=jRRZynkeiDfsyhXjA6TFGTv6xSoyW7P3MlF8MKByi/I=;
 b=n6ET3Fr39FqM6gTpJeT/9+8mpBtXEh0FvCt3I0n3YsVBTpi6ZKCNqXagdzppGtsatMP3
 8mbXDziGp6ZymPWW73Ru+/49l/SWYRfYwJFK/EtuqRrEGo2bhq3WPQSQK5CFDms1z7fE
 xEv/bZdbWVNmNX5i4s17tEELNBx1lwDi7POgX22d2FZJHWMDgHVfcYCAgtVruq6EOSlv
 1GoFRYJQGRj9eFDAsXgjl/BpvVMM9I71tO5X3MAS33JnzRs/0jrrXYeSs+KytI612706
 vozUEkxv6uAhIfuI2EZD0bx4mE1hp7I6vEKiJxLD3JFjyY0zvvsJb35m2FLZ+4cc1fv5 FQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BWGR5o1tdIO9dfUDBvqwSb7++Bk27SwpjF7Vy2nYVVtnSNK7KMOO/80yoZb7oOvn8n181MIRHMrDi/AcqeAd71Ml/EdDhnv1mbak0VBE5OoNe+Wck5x0WlmKru78NucRiA20pMGcnFlrPkX03MYZ3idinrgnhpX6Kw8IVh0rur+H3C7gyMF78iP2G6UwRXgJmIErev70bPcDDzGAS/IpdjOj13PsEK1zkqYwhdQ68Jod2a0vxSMrS6PkvFKaWa+mPgnKjYEFoup2peoF52+NEhYtZeqs/tq5jV9WcijsNenMqA3s1gdAdYckbp9AI5ZsWpuRPBBYnylWDu6JseVcuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=jRRZynkeiDfsyhXjA6TFGTv6xSoyW7P3MlF8MKByi/I=;
 b=Re6LvqsclUT9/jVaZqei0DWNFyxu5i8BhH3wWIVevv7bAqgdn4WQp2oP1dq6bLBEg48w2f5w06VCiJ+bnJx5K+5NE/ztHRfheBZMjIOYjijbzvkr7UdF9x/BWkwvEJbwSJcja+080PEEqC7ppPasuxSlJzrUqMY/P6+nkSOKCmUYV7CoaUxQym109MIFg8gA6ifPlEfBGrUuBqEuSENFAbNW1vYUNiGtLDgN326De94h37l+M+baXIiEi26fFWA1tmITn87S+TSqWTS9nRViJUTqUlfZYnZEe/GxbTklKJAxmA63i0TUQ8MWf2zyoenic6dJTHTNXlHQGmejc7EUTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=jRRZynkeiDfsyhXjA6TFGTv6xSoyW7P3MlF8MKByi/I=;
 b=NBBdWDnVpv9u4lM8EMjGGZDj155q2XKZNMKeyLqoKiXR0O6EHaE/S+otDQ7c7CxBVTYQNP6DTUQGHEG0eIapfYUcsXJioLSvHnqA1RPrrxCnw+80RzF8/oXO8PKWl+UjDMUzzU0quyYM3TAb3ImVP3ABTxGsp17RztXmrESN3H4=
Message-ID: <7d113a50-5efd-d45e-04b9-a29023092518@oracle.com>
Date: Fri, 10 Dec 2021 19:47:06 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH] xen/gntdev: fix unmap notification order
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: jgross@suse.com, sstabellini@kernel.org,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        stable@vger.kernel.org
References: <20211210092817.580718-1-andr2000@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211210092817.580718-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SN4PR0201CA0015.namprd02.prod.outlook.com
 (2603:10b6:803:2b::25) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d8dffe1f-896d-4998-8b1f-08d9bc3fc4d6
X-MS-TrafficTypeDiagnostic: BL0PR10MB2785:EE_
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2785E04155ADECA7099BF23B8A729@BL0PR10MB2785.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	hG21/S96hg0eQZ1/+7Z2osTJvhN4XxjA18oFNal6nwdX2vqpQxTytpwNVIc0VNu+nNveb1blYR5o6EUSoBs4gJDoTI1N/aLdmEoDoQ7zEFrS/s/MOU92GUIR4DT1zp+3Gw+COx5Dyc6KXnp4d8iEDthHgly9MLPII/wjZEp76Haa5Fd/noeCYUU1ItAW4NR4RU2NkrtPYCwFWd2jk5+L5kjAPabBVDEZAzXdNCmQI5+KtrWo+WFGE8QOFCHLLsBCLR+8oJYBbTFoDLzAvdSKcyBd/gqstm26g3PocNhEmSaQCuYXBVYy8wON3wWDJljwV2lV+VGPi8S7kii/3Px4Ud/4a3IzUTXeEmVjJG8NocdI5BUEMTdavR00QlF9w9lq9PIQ1RgrglvhdYCqDoD9QKDIW+gQlY1kE1pAl0FlweCy3CVCHXey5fSIXIT9Y7yQcBLfStounce8+4t2mn8/SAt+AEhiJ8P4uPj75Q1rWC6SuZjcNLIyHyZ59f1KvjduZYVRkP1RUk4TDD7PFnShtRETkWTaReRYvmPqk01+KKFxYgr5nYzJyORBvwlWATcMEgjWnn1XKi2MUR4Rz7OlEurzvK/V235PjKYJyLbVkFGR2v6WjeQOYkDVCdxZfqYPABiPcMdjw+HtDsb/4DmZuO1c2yL5IvHPEXeLUGzV5eFCfnBJgMqnt1QuuFyoITOx6CPJB5cKmOJs+daghon0ZNs296oTMpKiHmdrsQWHHAi4lEimqkOzrl/TJcNh2y/u
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(31686004)(44832011)(2906002)(66476007)(83380400001)(15650500001)(66946007)(8936002)(5660300002)(38100700002)(4326008)(6506007)(53546011)(31696002)(8676002)(316002)(6486002)(6666004)(508600001)(2616005)(6512007)(86362001)(36756003)(186003)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cFMyNHZyc1RQQktFbStsYmxxbWQwRmRTUlhmU1JKbVl1THNraWVWUWdKVFFj?=
 =?utf-8?B?b0RxOGcrSHNkeVBXSjZpeVZSbzR6a1NjODkxb3UwRGErUmdWcmRNMy9GaGNM?=
 =?utf-8?B?alBZckNpNW9EQW9UZ0dlME85cTFaOHYzMFpDTTRpRWwycFNyQTFoUE9KT09h?=
 =?utf-8?B?Z0Q0a0tZeVZUMVFua1ZWRXc0U1JYRUNJdyttZkRDOFdKY012dks3bm45NFFH?=
 =?utf-8?B?bHlZV0E5UGJ4TXpQSzlKODE1NzRNMWZ0NDUwZGprcUV2NTU1MlZTajR2Q0dP?=
 =?utf-8?B?UzZLOXN3WlZ3eU1YSkdkb2xZMGpNb1FGWWZESXJTbmRSME9Xb29LZDhPSWEv?=
 =?utf-8?B?WTN3VXFrUkxnTXk0RDc3bXdkbHA4MDQzU1JmZGQvcThYY0ZsbGJUUmFXTmtw?=
 =?utf-8?B?RlpJYTh1cGlIMHowZTdpRDVEWVExRWJxMW5QNjd5YTNuYkppSG9TeHNNTVNE?=
 =?utf-8?B?TTdsbDRUSk9zSy9ERGl5MUw1QmJsa0pZZFZ4QzlPSG54dkRYNkxsc0hpRUxi?=
 =?utf-8?B?bUVpQnBsWTA2SG93WmUxVUFYWUJnTUNlUzlSa0kxZE83U2tLN2JHbUxUMHgx?=
 =?utf-8?B?RW1EdmpjRTBnZjlUWnhBL1c0VjFVekRCQzY4ZDdtcTJBNHFSd1ZiZ3VpMUIx?=
 =?utf-8?B?NTA1NWdBeUpQY3F4TEQ2aHdhRVJJck14TjR5NHcwUWFvVk9UY3ZSQlRSVE5U?=
 =?utf-8?B?Ky80TUF0cmJMWng2bTY3dXk1TlFJUTNRcHJMdk52bHZJODRyVlpJZEIvWHFF?=
 =?utf-8?B?dCtwbWFweDR6Wi9DMHRwckNYNnJzelNrSmhDOU5ETjVPOUx3dkZNSVd6QXps?=
 =?utf-8?B?Rzhzakc0OW5YYU5vZEl6V2NjcHZiNkxrYkRJTnl5Q0pTTS85ZGFBTk90MnZX?=
 =?utf-8?B?UU9mTnpXWUNZckRId0NKdkNyMUU5MnArNmhNN0xrWGZNWkFtWTZXL0ozTGpJ?=
 =?utf-8?B?R0hMQzlOOEFzbDBKN3pSOUJSbDhlNEtidHU1M1JKZHpRdTgvVFJRWjVlcDQ1?=
 =?utf-8?B?c2Jqc3ZHb2UyWnVrVWxmM3lCMmZIdDNPY1ZqNmZNLy9Pekk0emlGQWpNQkR6?=
 =?utf-8?B?bmQ5WHZFK0Fwd3hscncwamdDMXlmNnQydHhkQWNKRm82eW1xRnovQUROTVN1?=
 =?utf-8?B?eVdPK3dnWXpoSlhMSE1pRjlFWkZVRVQzN1M0blUvU1o3c0hiZDFoZzZFbit0?=
 =?utf-8?B?TTJtSUY4Y3F4aUtHQ3NtVDZVT2hSQUdXdy9STUpHZE5nYWZwMjJqRWFHRFJK?=
 =?utf-8?B?eGZCdnE2SERrVE1NNmRvdkVENWJmY3pCN2x3VVJhMitMYnlLNUhxdHd3bkp0?=
 =?utf-8?B?WUNWR3VtK2VxakhFOHRBK2xjWS9PdkFDVzMxS2ljanQzQk4wNDZ3c2xGc0xE?=
 =?utf-8?B?allETVdQWU9rbHk3NVl1K2NRVk1PeEJ4WmYyQ0RORWl5YVFac1A2a0Z0bWpy?=
 =?utf-8?B?WHBwNHhWZEZ0dHZ1SjJXWmI1RThIWGZBTUdjU0s5bTlNbGVZbXNnL3lSbWVu?=
 =?utf-8?B?YlB5L09keDQrVXF2Y0FuZXdmejZIOFdobk9iVTFJekw2YmdkUTBuUVdDUFI2?=
 =?utf-8?B?QjkwS3VMa1hzNVcwbzR5Z2Q5WGFTTWpMS3Jaem00Q2FiRElWS1hZNm4vNE5u?=
 =?utf-8?B?bTlzeFBIYmRmQmJ2YmZMSEg5Y2J3aHlqVTBxbUw0T1lMQVNGN2x3Y005SFhi?=
 =?utf-8?B?RjhVKzUwUFc0SUdMa0wyVTdjUCt2RmFyZWw1VXlLbTJZRXZXcXlFaDk1ZFpH?=
 =?utf-8?B?T3pkdGY1UFUwbG4wSlEwZlZ1Zlp3QVN4U2VheFZyUHhyVmpsOE9aZ2IvM05Y?=
 =?utf-8?B?Nml2ME41eEdoeitqQmxWUGxVSnVQek0vcUpVY0swa2YvZGU0QUtoeTJZSldL?=
 =?utf-8?B?eWxYVzVMUUVQczlrY0d6K3NuTmpUMExTOHBYSEtGTU83d1A3U0xIZ1hYZldp?=
 =?utf-8?B?VndickdCZ3p0b04wSk5kTHQrLzNPUVMrRmtBQ0FFdEV4YWd5TE5HOFc1SUZJ?=
 =?utf-8?B?eDhJS3VUejYrVGtCbXZvTlFkU3lMRmJEQ0U4T0F2WTYzVkpjRjl2bi8vQ20z?=
 =?utf-8?B?RjVwejVIYk45UG1zejRnWXJnblFQNlF4WGpsVkFRWTIveGNnRENXU1FDS2E2?=
 =?utf-8?B?K0t0SjJFZHZXVHpVSDQ5ZHJEdy94bkJnVnZzSlNWcW1xSlJkRDFPR0JiNlNs?=
 =?utf-8?B?aVdoTWZOZHpBQS9EMnYzM1Z4ZEoydUxySGRIcW1uWkEvQTRXdUVjeHhZTHJz?=
 =?utf-8?Q?ZYQr9kHO+AF7Exd75l8UPi4unPKVEUp6PN6X8nynAM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8dffe1f-896d-4998-8b1f-08d9bc3fc4d6
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 00:47:12.2435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yl9OsHMNy00jvK5+I3EsJWRnA0tmv9LLN1bEseKohsbsmZb7nCGwZZOnvhpj+Az33HuaXGgfEq5ONbiH6jcxxF3e4HLon6V7BoVKKz30xtQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2785
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10194 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0
 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112110002
X-Proofpoint-GUID: TWGs4aqLsOq0i3R41SlAq0tg-krBIW4K
X-Proofpoint-ORIG-GUID: TWGs4aqLsOq0i3R41SlAq0tg-krBIW4K


On 12/10/21 4:28 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> While working with Xen's libxenvchan library I have faced an issue with
> unmap notifications sent in wrong order if both UNMAP_NOTIFY_SEND_EVENT
> and UNMAP_NOTIFY_CLEAR_BYTE were requested: first we send an event channel
> notification and then clear the notification byte which renders in the below
> inconsistency (cli_live is the byte which was requested to be cleared on unmap):
>
> [  444.514243] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 1
> [  444.515239] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
>
> Thus it is not possible to reliably implement the checks like
> - wait for the notification (UNMAP_NOTIFY_SEND_EVENT)
> - check the variable (UNMAP_NOTIFY_CLEAR_BYTE)
> because it is possible that the variable gets checked before it is cleared
> by the kernel.
>
> To fix that we need to re-order the notifications, so the variable is first
> gets cleared and then the event channel notification is sent.
> With this fix I can see the correct order of execution:
>
> [   54.522611] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
> [   54.537966] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 0
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>



Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



From xen-devel-bounces@lists.xenproject.org Sat Dec 11 01:20:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 01:20:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244611.423052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvr3J-00070u-8k; Sat, 11 Dec 2021 01:19:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244611.423052; Sat, 11 Dec 2021 01:19:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvr3J-00070n-5n; Sat, 11 Dec 2021 01:19:53 +0000
Received: by outflank-mailman (input) for mailman id 244611;
 Sat, 11 Dec 2021 01:19:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvr3H-00070d-Td; Sat, 11 Dec 2021 01:19:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvr3H-0004rj-JZ; Sat, 11 Dec 2021 01:19:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvr3H-0003yD-9G; Sat, 11 Dec 2021 01:19:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvr3H-000434-8m; Sat, 11 Dec 2021 01:19:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RjxHMl0NrU1/xCO1qJFkWFLrqdYRbYJ4uDRPrg/xkdo=; b=ZC2nr9/D62OAYroBg1VC2jUL1e
	/yhpMDMLoQePVJcyKpql6WvHqzsLiTehDWfgzkP4GOaWLXq5J1XNDRWeXGLKykiknbGChHC2nuIm1
	8qI0jYdSg+LnsdWogB8W8nfn/oylQB1vYxqTAOSZXud8LMSfyL4m2TA+W4OP4si1SkzI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167354-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167354: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 01:19:51 +0000

flight 167354 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167354/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   40 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 01:59:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 01:59:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244618.423065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvrfV-00053W-Am; Sat, 11 Dec 2021 01:59:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244618.423065; Sat, 11 Dec 2021 01:59:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvrfV-00053P-7r; Sat, 11 Dec 2021 01:59:21 +0000
Received: by outflank-mailman (input) for mailman id 244618;
 Sat, 11 Dec 2021 01:59:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrfT-00053F-NC; Sat, 11 Dec 2021 01:59:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrfS-0005Um-Sq; Sat, 11 Dec 2021 01:59:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrfS-00054O-Ev; Sat, 11 Dec 2021 01:59:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrfS-00089Y-E6; Sat, 11 Dec 2021 01:59:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hlollBn/4B1+P28gQU2IZ84DJ6G5dw9Igt81BzyJ9Zk=; b=dtIgGqtI4kI6sgN2+vdYvYKnTd
	cMi9NdwMXCOWHg7asMGh0b7J1/oSuGzOfJlllPDAa7REeyUUA65TpQvQ279GKiJPfS18l+6fXomfv
	UnzPGuPQ/UAerxo0pGSEubEeSmBh/akXZmbKLBACm8eKio5tuAaCtGnCnkbWWEr8kh+o=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167355-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167355: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 01:59:18 +0000

flight 167355 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167355/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   41 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 02:20:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 02:20:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244625.423080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvrzv-0001Jz-8q; Sat, 11 Dec 2021 02:20:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244625.423080; Sat, 11 Dec 2021 02:20:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvrzv-0001Js-5R; Sat, 11 Dec 2021 02:20:27 +0000
Received: by outflank-mailman (input) for mailman id 244625;
 Sat, 11 Dec 2021 02:20:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrzt-0001Ji-La; Sat, 11 Dec 2021 02:20:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrzt-0006IP-EP; Sat, 11 Dec 2021 02:20:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrzt-0005lE-0s; Sat, 11 Dec 2021 02:20:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvrzt-0004ja-0M; Sat, 11 Dec 2021 02:20:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kja7f1xBXleQVcFiqsN5CVGNVcImHjL/W1Ccwf+f/k8=; b=RnN6A9tp+s58nBmSKh4nUHy6Qt
	o/hO2PNcgTljmV22DfSMMHiuAKy1PAM2AU4sdzfiYkl4w5vJKhwBhP4iqI3Vzj894JaPW2bk5hWJb
	u00VgpjCXcbQDJ59wszhapFAeEOwXpp3GpRWjUuoLkbwdS3FHekb1pFI6vl0DgF19G4Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167348-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167348: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=29e31aaf5d81e57679c2abfe8ffd3851a87042b5
X-Osstest-Versions-That:
    xen=1384d4e1e4ef6e846a1cac54f6d2868d40309607
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 02:20:25 +0000

flight 167348 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167348/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167336
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167336
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167336
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167336
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167336
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167336
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167336
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167336
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167336
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167336
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167336
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167336
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167336
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  29e31aaf5d81e57679c2abfe8ffd3851a87042b5
baseline version:
 xen                  1384d4e1e4ef6e846a1cac54f6d2868d40309607

Last test of basis   167336  2021-12-10 09:54:00 Z    0 days
Testing same since   167348  2021-12-10 17:38:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1384d4e1e4..29e31aaf5d  29e31aaf5d81e57679c2abfe8ffd3851a87042b5 -> master


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 02:34:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 02:34:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244635.423110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvsDA-0003e0-MY; Sat, 11 Dec 2021 02:34:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244635.423110; Sat, 11 Dec 2021 02:34:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvsDA-0003dt-JN; Sat, 11 Dec 2021 02:34:08 +0000
Received: by outflank-mailman (input) for mailman id 244635;
 Sat, 11 Dec 2021 02:34:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvsD9-0003cC-2H; Sat, 11 Dec 2021 02:34:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvsD8-0006Wc-EO; Sat, 11 Dec 2021 02:34:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvsD8-00067k-4u; Sat, 11 Dec 2021 02:34:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvsD8-0002cv-4T; Sat, 11 Dec 2021 02:34:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=yx2rMX2yUtNgd8Gxnj+v2kGbeJQEBB6G5iFM0SJCBbM=; b=wQxjRnFkFmdefLVc6+cIFcSg7j
	OaTK8SlEROgu8tLuvDVc7caaDYmVWdSs5NLwqMhbQbNMH17IC3255PfFYVfQDtbtZ8Vdmb+9Ed44w
	GMAoo4X1nI8WYVfiX3/dnh52Z18wJSkGOGpe4xyoRpg0x3E59LzSEd5gygx8lNSKzibU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167356-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167356: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 02:34:06 +0000

flight 167356 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167356/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   42 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 03:46:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 03:46:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244643.423123 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvtKo-00066E-0p; Sat, 11 Dec 2021 03:46:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244643.423123; Sat, 11 Dec 2021 03:46:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvtKn-000667-U3; Sat, 11 Dec 2021 03:46:05 +0000
Received: by outflank-mailman (input) for mailman id 244643;
 Sat, 11 Dec 2021 03:46:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvtKm-00065x-QO; Sat, 11 Dec 2021 03:46:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvtKm-0007gF-MB; Sat, 11 Dec 2021 03:46:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvtKm-0000BS-DZ; Sat, 11 Dec 2021 03:46:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvtKm-0002MO-D5; Sat, 11 Dec 2021 03:46:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5s0aFtvkO3PN7qiG7Eczf3RJ2w5+XPLGg0DF29Te77g=; b=p5i1pPnAREd3bo+hCsxbXmmduA
	vU3nxbZodRaxEek5+E5kglbpVBrHefdPBTsPAPK5D4RoKkaRV8QtiR6+mRNOnB7jnjyPnB+Ux3+EE
	Q8+cbYGZ51zsf+5AgAHNx2P6LPG7zQDeNya2H0wlTO7RWieDgOinKXzUUn11CI0V9Ct8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167358-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167358: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 03:46:04 +0000

flight 167358 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167358/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   43 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 04:54:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 04:54:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244651.423138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvuON-0000Ky-6W; Sat, 11 Dec 2021 04:53:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244651.423138; Sat, 11 Dec 2021 04:53:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvuON-0000Kr-3X; Sat, 11 Dec 2021 04:53:51 +0000
Received: by outflank-mailman (input) for mailman id 244651;
 Sat, 11 Dec 2021 04:53:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvuOL-0000Kh-S4; Sat, 11 Dec 2021 04:53:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvuOL-0000YH-H2; Sat, 11 Dec 2021 04:53:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvuOL-0003VM-70; Sat, 11 Dec 2021 04:53:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvuOL-0004Te-6T; Sat, 11 Dec 2021 04:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/xcLZ8nEE0NYn7kVEfNhWXH2a5RdoUR0HUtmPWh1stE=; b=HM1jIA3BoKgfxUhU4fpHxeJI/j
	yjhpTLV0wB/ZznYUjw4XuisTa2B/AkWUpFuwSq8/C5oWizbU5RPNZ/ltjIJX6eZh8CFACXNV7LkjD
	UPyvf0sFl7E05ft3tEfnLFSdPWTOPctsQxDabbAG3kWWZ0L6zZCnm7nyRcsiubCoPhxk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167351-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167351: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b8a98b6bf66ae35361e987333233d07241642909
X-Osstest-Versions-That:
    linux=c741e49150dbb0c0aebe234389f4aa8b47958fa8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 04:53:49 +0000

flight 167351 linux-linus real [real]
flight 167359 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167351/
http://logs.test-lab.xenproject.org/osstest/logs/167359/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 167359-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167317
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167317
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167317
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167317
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167317
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167317
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167317
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167317
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                b8a98b6bf66ae35361e987333233d07241642909
baseline version:
 linux                c741e49150dbb0c0aebe234389f4aa8b47958fa8

Last test of basis   167317  2021-12-10 02:28:41 Z    1 days
Testing same since   167351  2021-12-10 20:11:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Young <consult.awy@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Arnd Bergmann <arnd@arndb.de>
  Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
  Bjorn Helgaas <bhelgaas@google.com>
  Charles Keepax <ckeepax@opensource.cirrus.com>
  Christian König <christian.koenig@amd.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dave Airlie <airlied@redhat.com>
  David Heidelberg <david@ixit.cz>
  Geraldo Nascimento <geraldogabriel@gmail.com>
  Hannes Reinecke <hare@suse.de>
  Hui Wang <hui.wang@canonical.com>
  John Harrison <John.C.Harrison@Intel.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Kailang Yang <kailang@realtek.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lionel Landwerlin <lionel.g.landwerlin@intel.com>
  Marc Zyngier <maz@kernel.org>
  Marek Behún <kabel@kernel.org>
  Mark Brown <broonie@kernel.org>
  Matthew Brost <matthew.brost@intel.com>
  Maxime Ripard <maxime@cerno.tech>
  Mikita Lipski <mikita.lipski@amd.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
  Pali Rohár <pali@kernel.org>
  Pavle Kotarac <Pavle.Kotarac@amd.com>
  Raviteja Goud Talla <ravitejax.goud.talla@intel.com>
  Rob Clark <robdclark@chromium.org>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Sameer Pujar <spujar@nvidia.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Ulf Hansson <ulf.hansson@linaro.org>
  Wenbin Mei <wenbin.mei@mediatek.com>
  Werner Sembach <wse@tuxedocomputers.com>
  Wolfram Sang <wsa+renesas@sang-engineering.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c741e49150db..b8a98b6bf66a  b8a98b6bf66ae35361e987333233d07241642909 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 05:26:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 05:26:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244657.423152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvuu0-0005h1-RH; Sat, 11 Dec 2021 05:26:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244657.423152; Sat, 11 Dec 2021 05:26:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvuu0-0005gu-OA; Sat, 11 Dec 2021 05:26:32 +0000
Received: by outflank-mailman (input) for mailman id 244657;
 Sat, 11 Dec 2021 05:26:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvutz-0005gk-Ox; Sat, 11 Dec 2021 05:26:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvutz-0001Nb-Fi; Sat, 11 Dec 2021 05:26:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvutz-0005ah-6g; Sat, 11 Dec 2021 05:26:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvutz-0006uZ-6B; Sat, 11 Dec 2021 05:26:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tcs0tzsH35caarEq5Q0DS9/VWXerPpW03ZChlvnEQac=; b=sAGYqV/vFwDD/dL7pkq7GmhrXG
	NGb2cF4UbtwBATD4LCnSbDP1YjvxQe/GkWQaxtVJZ+3yRH23768U0vNL1/Fos2Hr7OXujyKD5ooiX
	v8LG/jHkr9HO1rPU3ZwnKG0/M+m45z/XfI8IoIinPZ+Ovm3vSL9VHQ4xpHxMxop0QZ2M=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167360-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167360: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 05:26:31 +0000

flight 167360 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167360/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    1 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   44 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 06:31:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 06:31:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.244663.423166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvvuW-00089k-P4; Sat, 11 Dec 2021 06:31:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 244663.423166; Sat, 11 Dec 2021 06:31:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvvuW-00089d-M0; Sat, 11 Dec 2021 06:31:08 +0000
Received: by outflank-mailman (input) for mailman id 244663;
 Sat, 11 Dec 2021 06:31:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvvuU-00089T-Qx; Sat, 11 Dec 2021 06:31:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvvuU-0002Wd-Hh; Sat, 11 Dec 2021 06:31:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvvuU-0002Fp-8h; Sat, 11 Dec 2021 06:31:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvvuU-0008QZ-8D; Sat, 11 Dec 2021 06:31:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uL0KdNXUj9VR0FF5G6BL7lnR5rvwdyB9/c8PRVonZCs=; b=FvSFGiKt97kABKoHXBXNXbXf2J
	5wEdzGKwaYXcE0xpDVf1xXovj6c+bz0iC7nqUA6hNZSjDjYuwUK8Pnp3BtDKBuujLVDquz/htR/AR
	MK/znXC0auf9JHWdC5y4uxeKsWB3Q8qfHER54EaFiwGvJrgxmHI8shWCDTCjVDPHxOLs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167363-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167363: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 06:31:06 +0000

flight 167363 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167363/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   45 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    8 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 08:00:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 08:00:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245169.423179 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxIU-0003xf-Dh; Sat, 11 Dec 2021 07:59:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245169.423179; Sat, 11 Dec 2021 07:59:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxIU-0003xY-AR; Sat, 11 Dec 2021 07:59:58 +0000
Received: by outflank-mailman (input) for mailman id 245169;
 Sat, 11 Dec 2021 07:59:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxIS-0003xO-JG; Sat, 11 Dec 2021 07:59:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxIS-0003wp-F2; Sat, 11 Dec 2021 07:59:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxIS-0007kJ-7G; Sat, 11 Dec 2021 07:59:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxIS-0007HH-6l; Sat, 11 Dec 2021 07:59:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=XmGWrUBoGJPbBWvTG72bKvZHB4lG2ADJbBm/kSJq3c0=; b=3IIoDA3YvL5K7+WZF9HTRWkEvu
	g2nOM0JwbkjkDFgeomuDM1mKHR9zGlM5qYnmqa++AZeI3ae0cgTcgcwgwbyBiQYV3eJLn19p1re4T
	Wq6k0QOjmg6h0kB6Z9q9J9VJBfdQZ+1tZcjo0K2Szks3S58NXpXy8izOYOdST1K0/LMc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167364-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167364: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 07:59:56 +0000

flight 167364 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167364/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    1 days   46 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days    9 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 08:02:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 08:02:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245178.423194 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxKN-0005pX-4W; Sat, 11 Dec 2021 08:01:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245178.423194; Sat, 11 Dec 2021 08:01:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxKN-0005pQ-1X; Sat, 11 Dec 2021 08:01:55 +0000
Received: by outflank-mailman (input) for mailman id 245178;
 Sat, 11 Dec 2021 08:01:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxKL-0005pA-CG; Sat, 11 Dec 2021 08:01:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxKL-0004Ye-91; Sat, 11 Dec 2021 08:01:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxKL-0007pY-2U; Sat, 11 Dec 2021 08:01:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvxKL-0007zA-20; Sat, 11 Dec 2021 08:01:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JWSXiAktFBirlRyo/aE6idgHgfnGmFko/EMscBgGlXs=; b=M0xQZdLF1muZy59FE5NMUDPupn
	myz7mkywjysICdDWPli5kqEGnsOUQJaLTTjHULdoW2J0I2Evl4DOOI4OAcqRhrnVQVkgi4W1DRVZG
	dIUd4LRWKlsazK+jZhvWGkKlchmwv5U6sY/WDLzDe8U0ZAFv6yBclBq3ERAKhXkkZyG4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167361-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167361: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 08:01:53 +0000

flight 167361 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167361/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  519 days
Failing since        151818  2020-07-11 04:18:52 Z  518 days  500 attempts
Testing same since   167361  2021-12-11 04:18:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 88043 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 08:20:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 08:20:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245191.423208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxcb-0000C5-Q1; Sat, 11 Dec 2021 08:20:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245191.423208; Sat, 11 Dec 2021 08:20:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvxcb-0000By-M8; Sat, 11 Dec 2021 08:20:45 +0000
Received: by outflank-mailman (input) for mailman id 245191;
 Sat, 11 Dec 2021 08:20:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=tf3j=Q4=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mvxca-0000Bs-4S
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 08:20:44 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39d59f18-5a5b-11ec-a74f-db008197e53d;
 Sat, 11 Dec 2021 09:20:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39d59f18-5a5b-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639210841;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=wZa3irFgnWDqh0t0q6eQwWpSuJwJVJE9mKaS5+tsXIo=;
  b=KccPioun2kHIy/n5BCvoDEAN4QnV8bjXRb9neIk2MospvOLPEmEQ6y41
   Gs187EkvsDIWHhq3iHiFSTv+3hroqSMWz2/OcrHCe82GL2SUNGEs+50RH
   Ik4H2am5upZ6E7lkbBXyX3gsv2x3bU4OVLP4nO/vxRiaLAS9kySbPCfKR
   0=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: yrTFKejHGsgX7QoGmqyEXb8C4YEjJCNpH/+/OrkuQvGCS8yPD8AgkTKp+ogg2ZtxiBVYMb1LDe
 kRl5UUBCOMzBcT+gZt9qDPdwuNs4p6uHRmBoTsG5+T5nu3y7IOTLF23gsvUeKuKQArZYQS4wVp
 vXqjYJbUO8Vh0UROFF0IKgyvYV9TbUC7KB2qEfDymZRKMi97VpW8jQpX+6IQR9os+YB+fwwWJt
 iIOJHqR09sqhBMbUckg6lPlXfJhuWtmkX+1O3Zye4IF9B8+rUn6f/fGqNzZsKtvKJsbWe2WOtY
 UTerN3jf26ir+ps9OlmKioNY
X-SBRS: 5.1
X-MesageID: 61851991
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Vwuq2KMxtrx3sV3vrR2QkcFynXyQoLVcMsEvi/4bfWQNrUpzhD1Um
 2IYXz3UPv+DM2OjfNgibonjo08Eu8fcn4BgSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s7w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxDRu/A26
 e5WjLC5RFclb/b2wusFQhYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uTtYIBjWZp7ixINdWGZ
 O0TMgA2VQqaPQRJPW8wLYkfvc790xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1XlEuFo
 mPN/0ziHwoXcteYzFKt22iwi+r4uDL0UYMfCpW17vdvxlaUwwQ7DxkbVkCyp/WjvUe4V8hCM
 Ewf+icorq8a+VSiS5/2WBjQiGSNvgMYHcFRFeI6wAiXz+zf5APxLmIJVCJbYdoq8so/XyU31
 0ShlsnsQzdotdW9WX+bs7uZsz62ESwUNnMZIz8JSxMf5Nvuq511iQjAJv5qFqKv1IWtQRn/x
 jmLqG41gLB7pcwW06S2+3jXjjTqoYLGJiYr4QHQUnOg/xlOboevbIy16nDW9f9Fao2eSzGpu
 3wJmNOX6uwUOo2cjyyGQOgLH7aB6u6MNXvXhlsHN4I66z2n9nqnfIZRyDJzPkFkNoADYzCBX
 aPIkVoPvtkJZiLsNPIpJdLqYyg38UT+PfG9ctCTT+FVW7R4eV+LrXpUP0GIzm+4xSDAjpoDE
 ZucdM+tC1MTBqJm0Ce6So8h7FM7+swt7TiNHM6mlnxLxZLbPSfIEuldbDNie8hgtPvcyDg55
 eqzICdjJ/93dOTlKhfa/ocIRbzhBShqXMumwyC7mwPqH+aHJI3DI6OAqV/CU9Y890iwqgsv1
 iviMnK0MHKl2RX6xfyiMxiPko/HU5dltm4cNicxJ1uu0HVLSd/xt/ZGKcFuJOh4qbELIRtIo
 x4tIZroPxiyYm6fp2R1gWfV8uSOiyhHdSrRZnH4MVDTjrZrRhDT+8+MQ+cc3HJmM8ZDjuNn+
 +fI/lqCGfIrHl0+ZO6LOKPH5w7g5hA1xbMtN3Yk1/EOIS0ABqAxcHev5hL2SulRQSj+Ksyyi
 1zLXExG/LaV+OfYMrDh3Mi5kmtgKMMndmJyFGjH97emcy7c+2uo24hbV+iUOzvaUQvJFG+KP
 I25Ftnwb68KmkhkqY15H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFZ3ZOq0yvxJyCLZ6u44IRum6XYvrqaHS0hbIzKFlDdZcOluKIogz
 Op44JwW5gWzhwAEKNGDiiwIpW2AImZZC/cst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP3u0OyFDDfnw/EWn28dBc3Zle6gpXyFIiJkiSnoaXjPEAwxAMoy88SR5Yz0sb3rsra
 HRrLUB8OY6H4yxs2JpYR2mpFgxMWE+Z90j2xwdbnWHVVRD1BGnELWl7MueR5kEJtWlbe2EDr
 r2fzW/kVxfsfd3wgXRuCRI09aS7QIwj7BDGleCmA9+BTsszbjfSi6OzYXYF9kn8CsQriUyb/
 eRn8Y6cs0Eg2fL8d0HjN7Sn6A==
IronPort-HdrOrdr: A9a23:wH1q5alC2DdKh84rpkxiJiRohwjpDfIi3DAbv31ZSRFFG/Fw9v
 rDoB1/73TJYVkqN03I9ervBEDjexPhHO9OgLX5VI3KNGOKhILCFvAA0WKN+UyEJwTOssJbyK
 d8Y+xfJbTLfDxHZB/BkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,197,1635220800"; 
   d="scan'208";a="61851991"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hc9uNwURvMmpyqsrgP7o8ENsgWWk14MenImwr59sBdbF9+iuiGhNyZRHbYsjYEZaI85TQwaI+m0H6FIunR6ddsgoepq2AnvkwRRpn4S6LktAWBFfbSVepC7peaCkJfFnTtb3yG6oneeItu+dQHD2KSJRdnmVIzzQng77iDblkhVoaU58uUUM3VsJaFSznB7ZB/NHgpy6TFY0hrsbn92ogwzWJiF1tIfZDwjBbfd+gbK89JvcgeU70HCJLXLHocClLR7eEGecqkQFz+Xqi9xrxBh60exRJTcCWjb+SPbUJhk5lMC4CPhiRTpzVcI7RpR6H1b6X+nIJ8XBc8K+dOp2hA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qduQJK1aJ/OpYlgPhAQKCDZd348zfSiOpXZtUAoZnbI=;
 b=ZLPlzyvTyHelug5T+xIi8iydxm7Q9dO1Sb8hXABJM0ZgN2HspQ9ulrwUAkTKb/03lTHVcnGlctzG+fzmHIFxmmSJDcR91rPzFsYlbpHB7fgwtctmPfcKIKRbxSTbm8lDTFeaDTq4QRzUzntvWDJTTRjAk9qOzRXch8nRQU7RIrOVF6JptZy5ag3O8LpBUEuzWwl9bCb79F9X9+o3P/BMyibEF+EEeGKcYsK+73cXilwbAk6R19ASfiavYd6y48ZdQQCt7XvhNjfmeXVdHbe8K2JXFJtWICBEfjQJclg8mpA/DratxxQhYSpOzJZHeXJjNE5NAQMbdpbHnX6iq9ZC1A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qduQJK1aJ/OpYlgPhAQKCDZd348zfSiOpXZtUAoZnbI=;
 b=nGQMzMvXomtdv/mQnpkK0UaPoW1Hd+eUwyrCsAwf/dC3p1eBzCH5ClHCx2YcvMy079abj9jxc8uo4JW1MwU0QuQfGu3mHmljChGg8FlYQk/WVTdQiHY8YZLLlNOxM5AXFc1vEj5PIy0I5foQfx3pd4fXdPLULbwih/oISXOc5G4=
Date: Sat, 11 Dec 2021 09:20:22 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr Andrushchenko <andr2000@gmail.com>,
	<xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<oleksandr_tyshchenko@epam.com>, <volodymyr_babchuk@epam.com>,
	<Artem_Mygaiev@epam.com>, <jbeulich@suse.com>, <andrew.cooper3@citrix.com>,
	<george.dunlap@citrix.com>, <paul@xen.org>, <bertrand.marquis@arm.com>,
	<rahul.singh@arm.com>, Oleksandr Andrushchenko
	<oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH v5 02/14] vpci: fix function attributes for
 vpci_process_pending
Message-ID: <YbRfRv3x0lxZvPcw@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-3-andr2000@gmail.com>
 <19c43763-966d-e336-9282-ff12b1b3b2c6@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <19c43763-966d-e336-9282-ff12b1b3b2c6@xen.org>
X-ClientProxiedBy: MR2P264CA0052.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 999c52e2-1d0e-4be9-1c34-08d9bc7f1af2
X-MS-TrafficTypeDiagnostic: DS7PR03MB5525:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB5525EEED46808E74B349022E8F729@DS7PR03MB5525.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6xZ3eLK3FekMSjEKvVJJBunT1UUaOx+2M5zP8MPmZE2iz2hTQGEXO1K4Y4HZFC4KTDfx7c2LxtcurNBc0obdxyt/mg+Xt7Xpx3JNklzWhF5ntUZ1x8jmyOvaCDzTtyFLkiMV/AV8hOV98yLpSsJv0+wmq06peLaIrjMaSFlU2/205IZjqorq4sQuaO+8BUhHDUaeNUAn3s0QB+yMzlB9Y/67zxUMBQ4hx4bTGPXclbkoJz8B2qoYVd1Kr6ywkEAcV5hH5tPccdRdcgnsnbUrRAAhkJ/YuJDDwJIE7/IFod130h7V2wsFRm5nObM5KwCVzCNAM3WyW2GP8WjpM6zk/7pp0DZ7zbR829bQrECnf4uup49UNm5hckdFX1Tn34oNCM8SpilU3vtaYefKn2tZNz9qRyHfuObTi5MeI9LxHCYC2GRxGspQotcjC3vo9AyVbQmJLX3vyJta+LSpKM56cI1p0C2FchI5UV0e8ONfV8IHN2STNnzOtRhLLRorIlEWHBn0ox5nlP4erjEDz2UU9su3ghOf9IG/HdBhBq8pdu1Il7uMju3A1OTbwtvDG/w1kp9NwryS69nFSCCOCH3xmln6J0psrfFpHpp9gJIl2RKwzJQj+r7t5bhi/sIL6FNDR1+zEd/IB/q9m0eB+K1AJw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(316002)(5660300002)(508600001)(33716001)(6916009)(54906003)(4744005)(8676002)(2906002)(66946007)(7416002)(956004)(82960400001)(4326008)(66556008)(6666004)(53546011)(6486002)(6496006)(9686003)(38100700002)(186003)(66476007)(85182001)(26005)(86362001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1E3N3lHb3ZUdlJUNC9XZFV0UUlRNURLZ252cm1MdHhWa2M5dDF4VXVUTWgr?=
 =?utf-8?B?RmdBNGQyeUx5YjZ3eTNQUTlxYmRvM0grNFo3L2pYV1hiSUs2ZnprVm1aKzgw?=
 =?utf-8?B?b0lncC9WK0lNNnZZNW9qNi9HeVFqaVR6NHRyaXJHWGdIeEpaRWRqZ1NLNFdX?=
 =?utf-8?B?RmJFMFo1NUlDVkdzdlAzb3dzZEtJTjNuY2JKVTlzYVdRVnpEZk9FZlVQRnFG?=
 =?utf-8?B?NGZ5MzZzT3ovbEFtcjhGRHRNcVc5NnNPVVdtQlE2Nkh0ZFlhTFN2N1dmMFRP?=
 =?utf-8?B?VTBsQk9STDMveTVSS1BGcUJsdG51RzdNWTd2M3BkTklPV3I2T1pSSUVGNVM1?=
 =?utf-8?B?TUt4WkRJMVBpdGU1V1VZWS95eW8rWjRzOHNVM3c1WUlzY3AwRW9pZlpnQyt0?=
 =?utf-8?B?NGY3ekdSQStiOWpzNEJjNGxTRFZKMDJ5SHhwZGl0a3B2NWY4S09SeWJ1SVRG?=
 =?utf-8?B?RzF3WW1JUUtJTktxZTZtN3prNi9BellmdkpkU1BzUUxxbXVRM2w3ZUZPSDc3?=
 =?utf-8?B?c2dOaGF1djZzeEdiTGdJYVZ3VGhQdEJwM2NFNmVzK2V3dHN5TEwrNi8rNG1n?=
 =?utf-8?B?dk12dlQ1aWwvbDRVU2FSdmVHUnRwSmpXTW44NGtJdzRLYyttajVEdVRodGor?=
 =?utf-8?B?bXhaV3EwdUdpSHVnaWNRemxPWXpndTZCWUEyS1J6TnN2Zk4wT1pmVmVLTjlt?=
 =?utf-8?B?T2kwR0JVSkRyakZ5ZlBnc3lNVCt2QUtVd2E0b3VFN3g4cndRVzZlZ0N6WEFS?=
 =?utf-8?B?MUlWSWllTFliUEpFTHdnMXdOa2tyc3Z2OWs2L0pUaUh6SVBnQkRJUXRPVW9T?=
 =?utf-8?B?eDZ1c0VKazViU3dBZmcvajBNVXFQekhrOWtLRFN6d3ZVOFdnazRFUkkva09W?=
 =?utf-8?B?aW82UkZxaGFwa0ZBZU1aazdCZGRtanRZb1J3a2wzeWVoNUNvcTZNWm9sSE5M?=
 =?utf-8?B?Q1JsTDZsZWNPNW1Kb3gyM3JPVHdQOXZsSkdaUXF3aGQ5dXBJc09HVExvOXlh?=
 =?utf-8?B?dDlsOXNSQ3Y3bUNLV29iTGpBelhMekdJaDZRRzlYbEhXTUtXR3g0STlDelRl?=
 =?utf-8?B?Y0RHUG5vbXlXdHV2ZmM0ZTFKb29xYWE1cTVWN3BCNVdDNzVSRXhjTlR4T1kx?=
 =?utf-8?B?bXk4d3ZwcU9LTlZ3MWFSaHlCUUEzVFRRbUVTZlMwRUVNSElJaGpTUkJJa00x?=
 =?utf-8?B?U0ZlNFd1TWMvVSs0cVBkdGFCM2x5WW9MNEtpOEFpL25pQjQ2QVhXdTBEdUVZ?=
 =?utf-8?B?RExLS1kxb2MyaCs4S2xnUXMzWmw2ejhxSHV2YjB3WUNWbFVTbERsV09YNjlB?=
 =?utf-8?B?VzVBbytraVhuUEhzZmgxcmwzMk9JOHcxR09aOUpkb1hLMmRUQ2l5NytrMlpk?=
 =?utf-8?B?L2l0S3ArSDI0R09PNkp3cEhlNHp0U2VQTDF1VGZyV1l5YkVMKzByVFhXMmNK?=
 =?utf-8?B?ZG1IU1FOd1Rsek5lazBtOFJLS2tON3VQUWl1cEJwRkZNU25VeDM4bEZKQUpp?=
 =?utf-8?B?Q2ZWU2g5T0pJck0xdEFzSFhWVlo5dWgrV2JyUHZsNEV4N3JEZDAxUzhjb3I5?=
 =?utf-8?B?UlRPNnA5elI1dTQwUk82ejBmNkxoWGgxTXkxeENlUGdPZ2RVaTZvTTNLdjRw?=
 =?utf-8?B?c1Vpc3ZnOGxpd0lpVnVvT0l2VFZ1Y3FWSVlqQVZyeExnL05UbHU0ZXI3YURL?=
 =?utf-8?B?TjJrRG56SnNJMmUyUUVxcmh1Z0J4ejByUk9COHluWjltWnZ3bDdiei9BWWgz?=
 =?utf-8?B?TExWV2Fzalk0S0RTSU13NG5wN3FRT3luZTRaVUV2SFBjRlE1UUgycDI0TnVa?=
 =?utf-8?B?YXoyQTVIRitDSWhYODAvUmpvaUN2czZoU2txNWtiK1BkaEZ2MG1uNWdEZ2pU?=
 =?utf-8?B?ZzViQ1U3ZG1oWkhXYjA2anJYNWh5SnZTTFZER3RZOUg4citvSjZKOERFVXFp?=
 =?utf-8?B?TkQ3N1doOEt2Q1c5dG82VnpzR243QjFzYkIwdjQxcUowSlVSWHRCU3ZmUi9L?=
 =?utf-8?B?TC9ReGpsNjhGSkIvRnVmVS9MK1paSmFLY3BwQXdJMHJscWVHVDB2NTlQWkpv?=
 =?utf-8?B?ZkdkdlhNcDhTVHR3NTE3ZmhXekpxN2RZVW9JTUk4ZXFSSU8vRHpuaDZIZXBn?=
 =?utf-8?B?bkZjQ3FybVphN2lYSWNrR3kzakg0RnVWY1gzc1ZDTzZiMjZDblUxYUFmb29X?=
 =?utf-8?Q?5LvnhoehepDVneCW8bQXnkg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 999c52e2-1d0e-4be9-1c34-08d9bc7f1af2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2021 08:20:35.4263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hVnleYFzXrBQqPUkcxXhFNeJoWwodSnoGElUwIE4EnwnhjCf4aHE+YaOZtHAwEHioNSPxvliH00+AmSq93o3SA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5525
X-OriginatorOrg: citrix.com

On Fri, Dec 10, 2021 at 05:55:03PM +0000, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 25/11/2021 11:02, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> > 
> > vpci_process_pending is defined with different attributes, e.g.
> > with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
> > Fix this by defining both of the definitions with __must_check.
> > 
> > Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
> > 
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

I think this can be committed independently of the rest of the
series?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 08:57:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 08:57:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245203.423219 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvyC6-0004RP-P4; Sat, 11 Dec 2021 08:57:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245203.423219; Sat, 11 Dec 2021 08:57:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvyC6-0004RI-Ls; Sat, 11 Dec 2021 08:57:26 +0000
Received: by outflank-mailman (input) for mailman id 245203;
 Sat, 11 Dec 2021 08:57:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CEJF=Q4=epam.com=prvs=2979f4f7e6=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mvyC5-0004RC-Fa
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 08:57:25 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a6a6a8a-5a60-11ec-a74f-db008197e53d;
 Sat, 11 Dec 2021 09:57:23 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BB5x0P3017209;
 Sat, 11 Dec 2021 08:57:18 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cvpaar5x9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Sat, 11 Dec 2021 08:57:17 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by VI1PR0302MB3470.eurprd03.prod.outlook.com (2603:10a6:803:1f::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Sat, 11 Dec
 2021 08:57:12 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%5]) with mapi id 15.20.4778.016; Sat, 11 Dec 2021
 08:57:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a6a6a8a-5a60-11ec-a74f-db008197e53d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aRH+mo9x9rj/pNeLjqEiaYuT2aFdsOaEYF2JQM3lXpE8TNhPBwdYdIAAv0kF4e1IH+ftf3Jx3rmk5Loj1YUgDu+nnPGMBfna7fvxA386KCnjj6z+qd1yKQoYE6DZLRmSpTC3d+LEQQsfOCh8UOC17DXdZatP9nXVoHBVygmWwNg8Q74vmEr/P0g4DSfOknmwWCxtUnlcK513KWAVdMmy8OMU1CMCshKG0tLK4w0bvtWtPBkgDHP1qV2ktHXiuhSSzUYV/GCspPA2vP8uWpfc3VED/A3f1EYL53bNAW1hUU2+YDjmUa6hXDQ3VYaVoUmohkDtwUgWbAFks3D1XP+9Sg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=99nK2sr9zhnAvkiKxB3DoZv/nFevP8TNWfxcbsWK5Uc=;
 b=GrvRRG/nkaEsCtR24HmyjBF1j8eL2uI38TwRWP3N3d2cz/eTiqghOFfQltL09XA3TiFppjmwzIQREqVmyU5qjYXq5pKowjqwqghfN7Oc3Be0SdjOCSS2hRpi5+364tb1wDGwhDvALhmBFWxkINkZUarZaAsDm9bo9GrsiNNHU8f40cJQ3BZCYvwnJ2QWzrFBUtJaLzWBWmdiPy5tdq/goSNr++UQJapfjCq0H/6PKjM2gZ4OhVCT2iM72FvH0E6eMFM1CyNwp0fQ/Uwl1y02V4+JYfKImDlQJNb+pOXc0M1gMWh3CKBprwqS/HvNpha/mP1tplG/Z5q7bRX3icmdrw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=99nK2sr9zhnAvkiKxB3DoZv/nFevP8TNWfxcbsWK5Uc=;
 b=Xbc7WDmSqlTKsQfF7kcpQuAemo5aXC1or/lNwx6+KJgLn0cglPkZJowLqb4CpjEpFB23J+jyxNI9+J9bA5fU5bdt5Q9XwOLOzivVMbwF0njMoWWcPfGRBC1oJf59qsvq61oZ3sPSchU2MjTkCSzfwmfXCgONAUaTA9OXzLPW41vfvNpJzXNJrTGSBMCdMtBcAdudtDlSDI+mwlypTWw75aKffpb1twCocLOwXtqVyPBwJN9ajgpC4EeFweLDDzQxAS49YRh+dO98WETERozguwtmmpseNXXVT+w2IPmsX830V0MiihVExkDV2rYa/+QhLU/pvnArHBqOwSpwtdB3hQ==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Julien Grall
	<julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 02/14] vpci: fix function attributes for
 vpci_process_pending
Thread-Topic: [PATCH v5 02/14] vpci: fix function attributes for
 vpci_process_pending
Thread-Index: AQHX4ewFDAQe3UpzbkCO75DuGK42PKwsGkWAgADxxACAAApIAA==
Date: Sat, 11 Dec 2021 08:57:11 +0000
Message-ID: <9ecf5a52-4fa8-04c7-d0f4-8d08b07fcf90@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-3-andr2000@gmail.com>
 <19c43763-966d-e336-9282-ff12b1b3b2c6@xen.org>
 <YbRfRv3x0lxZvPcw@Air-de-Roger>
In-Reply-To: <YbRfRv3x0lxZvPcw@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fdc0b36e-e0cc-4cb9-d16e-08d9bc84387c
x-ms-traffictypediagnostic: VI1PR0302MB3470:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <VI1PR0302MB347004B9F76C3E577E95106EE7729@VI1PR0302MB3470.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 /a4x7zm/OCqlFv6uIIVYbz/rl2RL/T/3JxCZEtCI9Q082/A1wcGOvG+UavafORckwz92Hxa7lsanBf0v+At4uUHQ03Km4luBkKvh1FF00Z0XSKBUZ4+9SHV6ZGYaGiiTdgVjIQsXUn4gCXjI9NCZYEl0QHaObkK4Ys+u22yR7ceCPsNJu58XTkseK3MQ8yh+BJiv/Men7hA//wEsc+2Z0b4adFC8rRhGLLCvbjROIzvKdFkksjWzYhr34Txnic5fNkF8Igjd+UIT5BAX3TOTZuH3OC0/nBTItuE0K/mefutQ7AeSb7hBZ4xrHUbZXmfnXFUwrkBCPxCeI7W/2qehp0SBd99z8nJvhWVTXhHZpk9NzNcw9r7Q04QLER91bivSZSLWDmGJ08cji4gsr887XPyZd5mca9bgrT3vD0ILTgKzkcbU6s9xbBP58JoZONbpO1287DEqgQzfe2qP7GkpVn0c3bk2BaggiqzEwfxXgIaTtvQNrUgADdTbUF+YUUPWo4tbi9seU1tOpkLsmqzqILN1Krk3gChNncyxwd6JHr3uEFEYyOOb/trJ7mzVZyUHhGidfK++42fm2JePQET/ZhrXzuv0v1Q3kQdH12lPkmH3HLdl1MRSrkqn6IDxVPZx8Teq9RJqHVBjlw7aFpqgtrIUSL+riwBCNbMOqC8eSIdu9n/7EAyp9bSfRV4y68eVoPpHpASaTTqJRya57UfXgCvHxV65kj/QMQ8l+z5JL1AhDE6OsjUB5A0tQQZq+QyX
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31696002)(31686004)(86362001)(66446008)(66556008)(8936002)(8676002)(66476007)(66946007)(76116006)(91956017)(7416002)(508600001)(2906002)(110136005)(54906003)(316002)(64756008)(4744005)(38070700005)(55236004)(26005)(53546011)(6506007)(186003)(6486002)(6512007)(5660300002)(107886003)(71200400001)(36756003)(4326008)(2616005)(122000001)(38100700002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bk5YYkRvbEhJcGJhZndGVWc1bHRJMkViUUJLMEtZemRkK2lDTEVTallvUm1S?=
 =?utf-8?B?KzNMOFBLdlgxRlJMUW0wQ0xGOHEza0w5WHIzVXF6Mkp3dWJ5SEEwaVBLOS9U?=
 =?utf-8?B?TkxJSjNmamhOejd3bUkyTTlaVWovTTZXZU1nL1lCdmFQQ2MrMDgyWk9MS0VK?=
 =?utf-8?B?bElDNElVYXFFQzNTNU1Hd3dvSTY4MmVZOUdoRUNkOXVSL1RKRXVzZk5FSzdh?=
 =?utf-8?B?dzdRS2pYWE1rSkVFaEoyZjJTY3hFcmVUN2ZsVjgvUUNhbEhNLzRSVjY3a1lU?=
 =?utf-8?B?MGVQa1VsSDA1M0NBb3BWLzRpcmN2SmNkbkxCWFdvd2kxSVZaNkdWY2xnTEpU?=
 =?utf-8?B?RTlwTmFDbHFYbzBJUmVpZ2VJQmpHU0tMOUFHUEZqSFJnV0YyVkorWUkzdCtV?=
 =?utf-8?B?cDNWd0NnWkpPWjBnUjhnL3JXZVJvUHgzNjBGekhmRHRwRWladndEc2hPeE14?=
 =?utf-8?B?YjdNV09UU2RaUTk5TmlUK2R5OGdjVVJ5UW1BOUZ2b0Jad0tHZDAzNC81R1Fl?=
 =?utf-8?B?MEZidTBqdGkyK1pYYVhtZTJkc21qeGNUZTZKZmhiblRuTDlneE4zSk05T1l2?=
 =?utf-8?B?b2JkOTFQUFY4QzN5b09zeWZjWUpVSWhaOWhhSGRkQllhcU4ySDBQQUYyNTJq?=
 =?utf-8?B?M3RQZDI0SFhMZEJOdlJyakNaU2hBYjh2bDF0Q01qYkZvOGlEbzNDVjlkbUc2?=
 =?utf-8?B?QzRwS1BteGlJdDVJalM5MDRNMUxOOGVrRnlMM3F6RVkveGlQK1F2R2dMRjZx?=
 =?utf-8?B?b1FzeG9ZV0plRkFzb01SZmw0eEpqWHhmMTViMDFEdlpBaDJDWFA2SEZYSTNL?=
 =?utf-8?B?VWdQTGtGak4wZmJwOCtOM3V2STNOU2ZvMWxBejI5YXd6dm9JRFRTa1k3dlZo?=
 =?utf-8?B?a25MUGJCaTZWQldPa3Z6WU81U1h1eUc4b3N0MzQrQTdqUlpibVp3ZG4rd29C?=
 =?utf-8?B?TWwvOHFkRkpQZkQrYjhCUTdFMkhsSjV4aE0rbnYvejZ5ZHJkQjZvTlhUOVdL?=
 =?utf-8?B?Ny9TdSs0OFFieGdKd0M3akNsK2RBTXNFSVZCbm1vL0xYOEFkaXV6NzI3eDRZ?=
 =?utf-8?B?WTVJb1lHblU4dTZha2VCWjlqR0Q5UHExbzdtRWJiSUNZUmNXWW9OZFBURkow?=
 =?utf-8?B?Znk5cHBOOEhpOTA4UFdYb2JJdzYxN3E1eWd1ZUFYSjJtRkpRVmhzV28xVGpj?=
 =?utf-8?B?eURxdWhKT2M0Z3VzellxeHpFcHBRTi8wRW1VNllvenNORkF6bXNiNXRmODNw?=
 =?utf-8?B?Y1MrZGhNSGt5RWV6K2YxZllDd1ZJMkVQT2lsei9XYVZZeEtVVmZQeGxTQjU4?=
 =?utf-8?B?TThMOFNUa0FhOXE1SjlqZDFuQ3hRZlJ2dXROUjVTbVYxQ2kwVUVuT0Qva0lt?=
 =?utf-8?B?aHRTRnVxN3NFYWhDTC9KRmZxc3hJcjlQbzk1WmpiRVFiU2kvM1RpNGZBbENY?=
 =?utf-8?B?K0pIRDB0cGsvZ1Q3KzFaSFFzRk9qM1NDTnJWZ0QyVm50bnVrQ2VBQjZFTldr?=
 =?utf-8?B?b3prSGJhQlVkMjR0YTNIc0J1VFBjK2tHN01Helhyd0pBR25EMnc4MW51a3lP?=
 =?utf-8?B?TmNqTjFpVFRSbjVPeURoVVRrcGVPUythOXk4MTl0SGNLeERJTTBkNFh6WCtH?=
 =?utf-8?B?azBqc252OU9hK1pDSi9VTXFybUVOTDNNU2hqYUl1ZzRGdlpySlNiSVpMTlhM?=
 =?utf-8?B?TlN1TkRhWFFmUXM4ZTliVFE3ME4xMkZ3WEx6UnV3WldVLzMvVjc3WUZwU01E?=
 =?utf-8?B?WXpYZGRZVHJmaXVqdHlzTVdYamFEL2JRb3ZJaVoxMnltVUp4cWZOWTUrMlE3?=
 =?utf-8?B?bjJ0cXZ5d1VSWXQvWW5xU1BmSjZuNlZtNnFzaGxWcXJqRlRQU3ZreVlGa2N0?=
 =?utf-8?B?cVFqdm4rTTVlczRLZ2ZxZHVFZy9RVU40VURRSm5pd3Q1Q0lUTFNwOTd0SVQ0?=
 =?utf-8?B?STk4MjVVQXhsS0lSRjlaaW5qRWhpc09NNGJob1JibXc3MFoxclVkTTJwdjJI?=
 =?utf-8?B?SFJ6WmZISnRRUHRPbXVqSVFoUENmUk01emNzYUVtV3NQVTA4TWo3Uk1RbGh0?=
 =?utf-8?B?Mm85UmJXQUVhdlNqNWVjY0lHVnFOeFJmYUxnb25WRXdydGtQZFM2VGxSY3Fo?=
 =?utf-8?B?b2JmVzlMTEUyb1V3TllhMUhkSUdpbFM2b2Nha29KcFZpVFVOM1JDK0orbVBF?=
 =?utf-8?B?UkZySTBsZkNjMk5mSkhGTXVvTTNnNWN2cmVPT1hpSUc2UHZQTVRsUnd4QlQr?=
 =?utf-8?B?ZnFFTlkzSW5BWEFpTTZJTDM4ZnR2LzFlbnUrUzNvZS9YVFFtODJrWjd3OG1K?=
 =?utf-8?B?dU1NOGpaR3FTN05MRWRZNzcwYUxUejdSWHpzdXJQYzdJTFJzMHI1VW1Jb2lI?=
 =?utf-8?Q?amWDKEUcOdNMJjD4=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <6BA07D634B607C4C86E13D4567FF2EB4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fdc0b36e-e0cc-4cb9-d16e-08d9bc84387c
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2021 08:57:11.5296
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FjEjb0Xj5mb+SnH7ogjfVTm68OKYGuN9olxHU/e3PlsiuE6opoOvx4pSGSettAuis/ccSgQLhX5xGdXN7Rct/KyGWNRsBBsn28h0X9PMBSq+PnS57zS4h6yyUi8s53mf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0302MB3470
X-Proofpoint-ORIG-GUID: l8NuhSNdVEVUH-ZvjnZnAMYZ1s3kP4Hp
X-Proofpoint-GUID: l8NuhSNdVEVUH-ZvjnZnAMYZ1s3kP4Hp
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-11_03,2021-12-10_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 mlxlogscore=973 spamscore=0 impostorscore=0 mlxscore=0 clxscore=1015
 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0
 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112110047

SGksIFJvZ2VyIQ0KDQpPbiAxMS4xMi4yMSAxMDoyMCwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gRnJpLCBEZWMgMTAsIDIwMjEgYXQgMDU6NTU6MDNQTSArMDAwMCwgSnVsaWVuIEdyYWxs
IHdyb3RlOg0KPj4gSGkgT2xla3NhbmRyLA0KPj4NCj4+IE9uIDI1LzExLzIwMjEgMTE6MDIsIE9s
ZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNo
Y2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pg0KPj4+IHZwY2lf
cHJvY2Vzc19wZW5kaW5nIGlzIGRlZmluZWQgd2l0aCBkaWZmZXJlbnQgYXR0cmlidXRlcywgZS5n
Lg0KPj4+IHdpdGggX19tdXN0X2NoZWNrIGlmIENPTkZJR19IQVNfVlBDSSBlbmFibGVkIGFuZCBu
b3Qgb3RoZXJ3aXNlLg0KPj4+IEZpeCB0aGlzIGJ5IGRlZmluaW5nIGJvdGggb2YgdGhlIGRlZmlu
aXRpb25zIHdpdGggX19tdXN0X2NoZWNrLg0KPj4+DQo+Pj4gRml4ZXM6IDE0NTgzYTU5MDc4MyAo
IjdmYmIwOTZiZjM0NSBrY29uZmlnOiBkb24ndCBzZWxlY3QgVlBDSSBpZiBidWlsZGluZyBhIHNo
aW0tb25seSBiaW5hcnkiKQ0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1
c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gUmV2aWV3ZWQt
Ynk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IFJldmlld2VkLWJ5OiBSb2dl
ciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4NCj4gSSB0aGluayB0aGlzIGNh
biBiZSBjb21taXR0ZWQgaW5kZXBlbmRlbnRseSBvZiB0aGUgcmVzdCBvZiB0aGUNCj4gc2VyaWVz
Pw0KSSB0aGluayBzbw0KPg0KPiBUaGFua3MsIFJvZ2VyLg0KVGhhbmsgeW91LA0KT2xla3NhbmRy


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 09:08:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 09:08:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245212.423230 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvyN5-0006AD-TY; Sat, 11 Dec 2021 09:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245212.423230; Sat, 11 Dec 2021 09:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvyN5-0006A6-QA; Sat, 11 Dec 2021 09:08:47 +0000
Received: by outflank-mailman (input) for mailman id 245212;
 Sat, 11 Dec 2021 09:08:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvyN4-00069w-7u; Sat, 11 Dec 2021 09:08:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvyN4-0005eA-1w; Sat, 11 Dec 2021 09:08:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvyN3-00024R-Pr; Sat, 11 Dec 2021 09:08:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvyN3-0007kK-PO; Sat, 11 Dec 2021 09:08:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0Tt8Oxr73Ki8GloYHbjGa+fhvSD77kK12heDaIKjL5Q=; b=gPVcJzla7viW+P7rMHBWyutgMk
	8s+/Lc9cpggxA4uBGF/Jhqj3Wl++ksoXG0tz0LbzVF40xInm6HP0XdRfmVwx8GX2n+DUURoqy+7eC
	SYbGCEaaw41hUNNsjGgtgmA+Xuj2tMJpuvX8kEBs1zrC9DXHopn7e1Pki9ggLOqNwCKo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167365-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167365: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 09:08:45 +0000

flight 167365 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167365/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   47 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   10 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 09:29:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 09:29:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245223.423243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvygp-0000V5-JD; Sat, 11 Dec 2021 09:29:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245223.423243; Sat, 11 Dec 2021 09:29:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvygp-0000Uy-GF; Sat, 11 Dec 2021 09:29:11 +0000
Received: by outflank-mailman (input) for mailman id 245223;
 Sat, 11 Dec 2021 09:29:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvygo-0000Uo-HV; Sat, 11 Dec 2021 09:29:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvygo-0005xx-Cb; Sat, 11 Dec 2021 09:29:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvygo-0002gu-3C; Sat, 11 Dec 2021 09:29:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvygo-0001BG-2i; Sat, 11 Dec 2021 09:29:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Yb3cdvj9dVMxJZdSwX8zvfeVRWuRonMWYOXybSRQFZs=; b=kMEotApHQkacBR6ILsolJ7HHFT
	RLsOI3z1R3d7z3mZdAi6eNFzOrvb1jgcdFFJQwsB4spX9h1XnFrGb7oOhx6MxuHHpG1nn9xYUn7ay
	JseuV8RMGApJScnunAjtsEjJrlGJ8ziCwCwcrRjnY4UOxJKlpW0RxUpK7bIB6D49s4Lc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167366-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167366: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 09:29:10 +0000

flight 167366 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167366/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   48 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   11 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 10:21:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 10:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245236.423258 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvzUv-0007Mx-Kw; Sat, 11 Dec 2021 10:20:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245236.423258; Sat, 11 Dec 2021 10:20:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvzUv-0007Mq-Hn; Sat, 11 Dec 2021 10:20:57 +0000
Received: by outflank-mailman (input) for mailman id 245236;
 Sat, 11 Dec 2021 10:20:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvzUu-0007Mg-CQ; Sat, 11 Dec 2021 10:20:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvzUu-0006sL-07; Sat, 11 Dec 2021 10:20:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvzUt-00044a-9Z; Sat, 11 Dec 2021 10:20:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvzUt-000836-96; Sat, 11 Dec 2021 10:20:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aKzMXXdJKXg+0Qit5MzLrcnY9jgbBVyYWeqRqklu2Gc=; b=T5HagRo3Bk2dH4MD/dIXK0wVIN
	GuJ2O/sia9Rxt/sSicV0oERcQK1ZRYWxo+k02VvQbLL+XATlZIuwsjEcJbTkW8AhMGxmCsEUZnlhp
	VkVXJQ2CUgpsl8+Wh/t5Vx9WAN80p72bgDQtIU4BjXk6AN8FH4DpYc9z1Dstgdib4YpA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167357-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167357: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
X-Osstest-Versions-That:
    xen=29e31aaf5d81e57679c2abfe8ffd3851a87042b5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 10:20:55 +0000

flight 167357 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167357/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167348
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167348
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167348
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167348
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167348
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167348
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167348
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167348
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167348
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167348
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167348
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167348
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167348
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2
baseline version:
 xen                  29e31aaf5d81e57679c2abfe8ffd3851a87042b5

Last test of basis   167348  2021-12-10 17:38:01 Z    0 days
Testing same since   167357  2021-12-11 02:22:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   29e31aaf5d..df3e1a5efe  df3e1a5efe700a9f59eced801cac73f9fd02a0e2 -> master


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 10:26:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 10:26:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245247.423279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvza8-0008Dq-JI; Sat, 11 Dec 2021 10:26:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245247.423279; Sat, 11 Dec 2021 10:26:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvza8-0008Dj-GI; Sat, 11 Dec 2021 10:26:20 +0000
Received: by outflank-mailman (input) for mailman id 245247;
 Sat, 11 Dec 2021 10:26:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvza7-0008DZ-IM; Sat, 11 Dec 2021 10:26:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvza7-0006yH-Ch; Sat, 11 Dec 2021 10:26:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mvza7-0004DP-4s; Sat, 11 Dec 2021 10:26:19 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mvza7-0003Gs-4O; Sat, 11 Dec 2021 10:26:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=bigB/MR6rUOkpeZ5xRq8mjAETGCXXTGgSzroTlNPzYo=; b=qqE/GJPvNioj/i2y1frzfqi+Jq
	IjOGeBCpmpqaHYQuuDUBTXsMKg10hud6ikGfYJKu8ZsJz4wl40LOdMZSBmr8tIFVflOz6I2rAIL/K
	lyplBfAssW2gcwodOlv1ksIEgpSF57Z8kxyhRaEatcFRfPmN6EWRo63sjQGGf1WvnT6s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167367-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167367: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 10:26:19 +0000

flight 167367 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167367/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   49 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   12 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 10:52:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 10:52:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245257.423294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvzzP-0003ax-Nf; Sat, 11 Dec 2021 10:52:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245257.423294; Sat, 11 Dec 2021 10:52:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mvzzP-0003aq-JI; Sat, 11 Dec 2021 10:52:27 +0000
Received: by outflank-mailman (input) for mailman id 245257;
 Sat, 11 Dec 2021 10:52:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nohm=Q4=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1mvzzO-0003ak-NN
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 10:52:26 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b82a0d8-5a70-11ec-a74f-db008197e53d;
 Sat, 11 Dec 2021 11:52:24 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 055A4CE2F5A;
 Sat, 11 Dec 2021 10:52:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF2CC004DD;
 Sat, 11 Dec 2021 10:52:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b82a0d8-5a70-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1639219936;
	bh=wYn3ADgLYrPQRMceGNbHRArEW/qGU4RTivEh07HgNkQ=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=LAf7FtjgctjlDptzlNxV8fA3znYlVJNDypd8oQHEjx1RtkgLeLO9oxpSgU9GK3SCc
	 z2Wg40TFAAHywhOUN03n3v8rTHjtLCaU0Zd26IKCxh/K1WU9EKzUXOZELH1gHM5jvE
	 aHi5wUh0c0gFevijVyLgi+69QnKhHhM0tojBtX5A=
Date: Sat, 11 Dec 2021 11:52:08 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 03/35] x86/apic/msi: Use PCI device MSI property
Message-ID: <YbSC2GadkARsAIA8@kroah.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.372357371@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.372357371@linutronix.de>

On Fri, Dec 10, 2021 at 11:18:47PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 11:02:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 11:02:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245270.423305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw08n-0005JD-Kj; Sat, 11 Dec 2021 11:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245270.423305; Sat, 11 Dec 2021 11:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw08n-0005J6-Hc; Sat, 11 Dec 2021 11:02:09 +0000
Received: by outflank-mailman (input) for mailman id 245270;
 Sat, 11 Dec 2021 11:02:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw08m-0005Iw-7M; Sat, 11 Dec 2021 11:02:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw08l-0007aD-Tz; Sat, 11 Dec 2021 11:02:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw08l-0005Mv-LV; Sat, 11 Dec 2021 11:02:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw08l-0008O0-L0; Sat, 11 Dec 2021 11:02:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zQ1SYROTjoOPFdbIeX7zyYLrQo53XTKbHsWcI37+Hh4=; b=e6D7bxhMfLns0HLeQIcebQ/N72
	zaxylFrqJn8zWn0yv+I4hwioilKLj93OixP7OEnBmlauNyqRAirY9+hUda2ivJSCYvuW1vnTVSwf5
	5y2ZiQMqe9JktM1/1pnzRNFIH26mAveXh658FCkB2deULTmtmemdbGhxJY6m0f6iJ+Dc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167368-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167368: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 11:02:07 +0000

flight 167368 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167368/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   50 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   13 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 11:30:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 11:30:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245287.423318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw0a2-0000hd-Rg; Sat, 11 Dec 2021 11:30:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245287.423318; Sat, 11 Dec 2021 11:30:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw0a2-0000hW-Og; Sat, 11 Dec 2021 11:30:18 +0000
Received: by outflank-mailman (input) for mailman id 245287;
 Sat, 11 Dec 2021 11:30:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw0a0-0000hM-JY; Sat, 11 Dec 2021 11:30:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw0a0-00081m-D2; Sat, 11 Dec 2021 11:30:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw0a0-0006II-3j; Sat, 11 Dec 2021 11:30:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw0a0-0001xb-3F; Sat, 11 Dec 2021 11:30:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=v9oc8OIZgqdcPm5p5LcOYas1G5WLQk25pwIG2IXm9Kw=; b=aC7ObPtgDfNzx8lTmwty/p7HuR
	nZWM2/wNAiya787KAL9FA/lGprjqJMAq19cmA/+Yvps54o1IZnX1ZREd58uRzOGKmYpg/0dmCko7k
	K3YDAm58X9XUbG9fGen5NPfBrVNO/a/U7Nih02Uk7jwUti/ZESa/nobI6HN3/g4YNHnI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167369-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167369: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 11:30:16 +0000

flight 167369 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167369/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   51 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   14 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 12:06:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 12:06:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245299.423332 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw18i-0004hO-Mq; Sat, 11 Dec 2021 12:06:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245299.423332; Sat, 11 Dec 2021 12:06:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw18i-0004hH-K4; Sat, 11 Dec 2021 12:06:08 +0000
Received: by outflank-mailman (input) for mailman id 245299;
 Sat, 11 Dec 2021 12:06:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw18h-0004h7-KO; Sat, 11 Dec 2021 12:06:07 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw18h-0000BN-E8; Sat, 11 Dec 2021 12:06:07 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw18h-0007M4-6l; Sat, 11 Dec 2021 12:06:07 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw18h-0006ms-6H; Sat, 11 Dec 2021 12:06:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xUriPVFLPmJVOksTG9dzX19a7H2k/cS2zmLzQ3kxPtc=; b=WwVMccDWhMqs+CwfYUbu8AwwcK
	C8AT+K3MUzZ/fjfHdrZukZOpcr5Z1OxpmficIDfpKiAeyJYU2qsBCEEnm6AdAFf8NpOmVPKek5hZX
	clztb+/iSscXSWH73km7eI2L+dpDwXUO3OCMC3l1wU3Qih0yiHU/MEPWXTpubCMWBpWo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167370-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167370: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 12:06:07 +0000

flight 167370 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167370/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   52 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   15 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 12:44:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 12:44:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245311.423347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw1jK-00018A-MZ; Sat, 11 Dec 2021 12:43:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245311.423347; Sat, 11 Dec 2021 12:43:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw1jK-000183-Ig; Sat, 11 Dec 2021 12:43:58 +0000
Received: by outflank-mailman (input) for mailman id 245311;
 Sat, 11 Dec 2021 12:43:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw1jJ-00017t-6Z; Sat, 11 Dec 2021 12:43:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw1jJ-0000nr-0s; Sat, 11 Dec 2021 12:43:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw1jI-0008Sc-NZ; Sat, 11 Dec 2021 12:43:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw1jI-0006uz-N2; Sat, 11 Dec 2021 12:43:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qGWp8Rj9sTes4wTyjmnvCZf0066t+WVdNOfVV9qvPoc=; b=ynM+pGFQ7yBWD3HnvGiF2qw+4r
	vwUFntil7PyvDYLLJQNz1x5CZEv3P7ZLeFHXFPiVCuIW755OSF+fsbY1L9h0FYj06Et+mSC8Ai25+
	exPAyzd8TIU1s0XQjUdcBQEXjcLHQz3/92WLOgIC0dTWSdp9FK1moJoZb73upnkSy2Xo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167371-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167371: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 12:43:56 +0000

flight 167371 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167371/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   53 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   16 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 13:29:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 13:29:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245332.423361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw2RM-0006Ni-3c; Sat, 11 Dec 2021 13:29:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245332.423361; Sat, 11 Dec 2021 13:29:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw2RM-0006Nb-0O; Sat, 11 Dec 2021 13:29:28 +0000
Received: by outflank-mailman (input) for mailman id 245332;
 Sat, 11 Dec 2021 13:29:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2RK-0006Mf-NK; Sat, 11 Dec 2021 13:29:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2RK-0001Yj-Gv; Sat, 11 Dec 2021 13:29:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2RK-000147-45; Sat, 11 Dec 2021 13:29:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2RK-000211-3b; Sat, 11 Dec 2021 13:29:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VBfv41gfV3rTz1xQo1FDPQ+cnFyGo+8exZhqVF5mBgs=; b=GrOuapF5jzeuQ1zscfk1Hq4cQ8
	61J9GTvNodPlYxlcSo+sJfoySfZiI435Wu++z3Bagf1WY+IMQ2fUEnJvzoqS+xWpeqPeOsJ2q/ga6
	81sUAwVBH5igiJYW6UKyExtfUVlJkGzshhpi5k5dDAzKsfRSHU9r7YomuuOB/hio72WY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167373-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167373: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 13:29:26 +0000

flight 167373 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167373/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   54 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   17 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 13:55:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 13:55:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245342.423375 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw2qE-0001UY-2x; Sat, 11 Dec 2021 13:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245342.423375; Sat, 11 Dec 2021 13:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw2qD-0001UR-WF; Sat, 11 Dec 2021 13:55:10 +0000
Received: by outflank-mailman (input) for mailman id 245342;
 Sat, 11 Dec 2021 13:55:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2qD-0001UH-If; Sat, 11 Dec 2021 13:55:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2qD-0001xX-Bd; Sat, 11 Dec 2021 13:55:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2qD-0001ex-2M; Sat, 11 Dec 2021 13:55:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw2qD-0007yE-1q; Sat, 11 Dec 2021 13:55:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1uek8sTD/3TMz8mIZa5B5JfsU7abvrAVqMZYRZn9ssM=; b=UNJGYa1JOV8HokIYZtXZ3wy8gY
	BT7HhdXCJM/Ur8eMWUWkUBwQZXr9nO7BNv5G4Sq9AudWSG1lFiH+0pPq0E5bemUtCC1eeJ3Jjw4vo
	a96Xr7iOW4u/iIYgk/VE/h2jzNQ8fAGpxECFbBEU+Gnw1o81G/LBk+UVBIz8hDmH9qc0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167362-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167362: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:guest-start/debianhvm.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=6f513529296fd4f696afb4354c46508abe646541
X-Osstest-Versions-That:
    linux=b8a98b6bf66ae35361e987333233d07241642909
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 13:55:09 +0000

flight 167362 linux-linus real [real]
flight 167372 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167362/
http://logs.test-lab.xenproject.org/osstest/logs/167372/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-amd64 20 guest-start/debianhvm.repeat fail pass in 167372-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167351
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167351
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167351
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167351
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167351
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167351
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167351
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167351
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                6f513529296fd4f696afb4354c46508abe646541
baseline version:
 linux                b8a98b6bf66ae35361e987333233d07241642909

Last test of basis   167351  2021-12-10 20:11:11 Z    0 days
Testing same since   167362  2021-12-11 04:56:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Sverdlin <alexander.sverdlin@nokia.com>
  Armin Wolf <W_Armin@gmx.de>
  Billy Tsai <billy_tsai@aspeedtech.com>
  Chen Yu <yu.c.chen@intel.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  David Mosberger-Tang <davidm@egauge.net>
  David Sterba <dsterba@suse.com>
  Eric Biggers <ebiggers@google.com>
  Guenter Roeck <linux@roeck-us.net>
  Heiko Carstens <hca@linux.ibm.com>
  J. Bruce Fields <bfields@redhat.com>
  Jiri Olsa <jolsa@kernel.org>
  Jiri Olsa <jolsa@redhat.com>
  Johannes Thumshirn <johannes.thumshirn@wdc.com>
  Josef Bacik <josef@toxicpanda.com>
  Lai Jiangshan <laijs@linux.alibaba.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
  Miaoqian Lin <linmq006@gmail.com>
  Naohiro Aota <naohiro.aota@wdc.com>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paulo Alcantara (SUSE) <pc@cjr.nz>
  Paulo Alcantara <pc@cjr.nz>
  Qu Wenruo <wqu@suse.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Sean Christopherson <seanjc@google.com>
  Steve French <stfrench@microsoft.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Wilken Gottwalt <wilken.gottwalt@posteo.net>
  Xie Yongji <xieyongji@bytedance.com>
  Zev Weiss <zev@bewilderbeest.net>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    fail    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b8a98b6bf66a..6f513529296f  6f513529296fd4f696afb4354c46508abe646541 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 14:39:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 14:39:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245352.423389 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw3WS-0006j4-L5; Sat, 11 Dec 2021 14:38:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245352.423389; Sat, 11 Dec 2021 14:38:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw3WS-0006ix-HX; Sat, 11 Dec 2021 14:38:48 +0000
Received: by outflank-mailman (input) for mailman id 245352;
 Sat, 11 Dec 2021 14:38:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw3WR-0006in-St; Sat, 11 Dec 2021 14:38:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw3WR-0002kg-Jq; Sat, 11 Dec 2021 14:38:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw3WR-0002bb-AW; Sat, 11 Dec 2021 14:38:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw3WR-0006bx-A2; Sat, 11 Dec 2021 14:38:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=BpaYYeN30iSpAmkbEKGsGR/nRvYr6r/mgV3ksszvuOA=; b=2/EwMeVwMWjrzjs8apzgQeRzoh
	FbUPldQxVgRdtlQrM4+4FQAxKHdmR7MGbZ1rGVMW+kIIgGmvm+UjKzh9dc1GzgqxMcAsVSBrzp4ao
	rJw6Y30aJ+DTI+YeLLJVTY+QrEjT1Olxc3r+jZMg3ZBo7dwohK/qwICiFuo0N1c+LFls=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167374-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167374: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 14:38:47 +0000

flight 167374 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167374/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 e81a81e5846edcc4c2e91cf3a39d0ba8c31b687a
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   55 attempts
Testing same since   167352  2021-12-10 20:11:48 Z    0 days   18 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1185 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 15:22:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 15:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245370.423402 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4CL-0003xb-2A; Sat, 11 Dec 2021 15:22:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245370.423402; Sat, 11 Dec 2021 15:22:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4CK-0003xU-VO; Sat, 11 Dec 2021 15:22:04 +0000
Received: by outflank-mailman (input) for mailman id 245370;
 Sat, 11 Dec 2021 15:22:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=koyS=Q4=arndb.de=arnd@srs-se1.protection.inumbo.net>)
 id 1mw4CJ-0003xO-FJ
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 15:22:03 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 15fa73df-5a96-11ec-a74f-db008197e53d;
 Sat, 11 Dec 2021 16:22:00 +0100 (CET)
Received: from mail-wr1-f54.google.com ([209.85.221.54]) by
 mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id
 1M5Q2f-1mvFNi3tcD-001S7t for <xen-devel@lists.xenproject.org>; Sat, 11 Dec
 2021 16:21:59 +0100
Received: by mail-wr1-f54.google.com with SMTP id c4so19692161wrd.9
 for <xen-devel@lists.xenproject.org>; Sat, 11 Dec 2021 07:21:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15fa73df-5a96-11ec-a74f-db008197e53d
X-Gm-Message-State: AOAM531u2iNcAiIsvVkst4qnfDZMSoRWOqqcPGzcoWJTBNWpwceCbdp5
	qOBSzeqoy4ZcDd+MqeALppsZ1Wim5V1LIsEnbE8=
X-Google-Smtp-Source: ABdhPJw71fHmkJDBQfwdVvTsQemVVjs0TdIXte5O3MuH5722pvreNXPnvtVfyYQ4NEpRi0VtDUcmnQ9Z/Qh6+K4QE8c=
X-Received: by 2002:a5d:530e:: with SMTP id e14mr21123035wrv.12.1639236119426;
 Sat, 11 Dec 2021 07:21:59 -0800 (PST)
MIME-Version: 1.0
References: <20211210221642.869015045@linutronix.de> <20211210221813.493922179@linutronix.de>
In-Reply-To: <20211210221813.493922179@linutronix.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sat, 11 Dec 2021 16:21:43 +0100
X-Gmail-Original-Message-ID: <CAK8P3a3U2DSm_DWS+iDkzH14hNMwyOQ77iS=W4HoAyHPh6pqUw@mail.gmail.com>
Message-ID: <CAK8P3a3U2DSm_DWS+iDkzH14hNMwyOQ77iS=W4HoAyHPh6pqUw@mail.gmail.com>
Subject: Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, 
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, 
	Ashok Raj <ashok.raj@intel.com>, linux-pci <linux-pci@vger.kernel.org>, 
	Cedric Le Goater <clg@kaod.org>, Arnd Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, 
	Juergen Gross <jgross@suse.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas <bhelgaas@google.com>, 
	Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, 
	Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, Vinod Koul <vkoul@kernel.org>, 
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, 
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, 
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Jassi Brar <jassisinghbrar@gmail.com>, 
	Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K1:PnjKuyYjy9duBmOnr/Ax1BQCrhXd68/MUs87X0Z/DS6lu2wGj1P
 rkIwLe9REnoT9GoDlt6r98qmBOGtVQCRlzmkXvAFq+QTYErxRQhPhvvj7hV8rQJVZyHNudU
 XhAyhRU6+7G7tk+IW4GOI7MlI5heA1uYu0l7WQ83X2WR5zpQn+E2MNvT6E4VFk5XNg2lRLD
 Cih7dll93+vufBCEvvsjA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:O7bqQV7w8Go=:5Gok6PnW6NZHMMDpHLs6x7
 m1esQUKjl+2t2xugtYbKOOonefOQhh4vdhQyTbhHlZC0q7KjxwiUjBHiVww8mP8dl9AXon3eJ
 WIixOKApM7DPS/fpMpJXWewDqeUr0NwRAHHuncRK1tvY+tzMw6IggQWSkPBwr+eNBjEUSDn7F
 /+yXcBfERPN4Wdd7goZezmUGtj1aer0YlV0Spkb0JuyQns/TdlgZ+Ks0MAcRNlEPYvR/nfAhI
 XeX4bRn3ZF92GRrQvy5N6XHVHFZ+Ml9uIvqPzlqh2hrP0dzTsxV+rknd1VXp13qB8TCTa/k6e
 ZE2pVPjGWCsl47rSkuBz4RNlxXy/HKM0Q4DUQgU9pXIAvcpOB279UtTHfNGnNHVnjuTJ3m7H1
 zaCWEI37vEgkLH7XguQKNNtCor9snfF/7mJizhQ/2qS+5XJpsnvhspSOFObPfujFknRzu567Z
 cHebYm/xhXO56cLG88irnvMhMNSoCXV88GIl5qb73nTKSQx5c6drwEN6kgCAQnrGDLKOkLrID
 7AVotgtmB0uLntyJKd59qTlYPqRfSEv6UzyXQhGS6VNKPkILAHQCFS2RzguPZ6h69C778QLq8
 Ixb6tvDnyXUuVSYmtVc+zKRxsyhxNg4m/ifytFCbDBgqf61Rb/2kQkUuTq3r7xCUGYrca1e65
 SK4DCDJ22ExY4ph++8YGmL3audek8OeX437nPrqBLgAAaGbMWTKtrQ+fW+nm3aNm+kPFuqtUs
 WRc8RZcl8ErFLayQRz8gCe64aqmkS9hwDmoOVLF4foy4/OY1AOcDVt500WJ8tTTWo3daK/yxE
 11r1slbjmYMvOsFrc5KLPInoJle9CSxqn645lHdsezKb03H+Rs=

On Fri, Dec 10, 2021 at 11:18 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> From: Thomas Gleixner <tglx@linutronix.de>
>
> instead of fiddling with MSI descriptors.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---

Acked-by: Arnd Bergmann <arnd@arndb.de>


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 15:22:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 15:22:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245372.423413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4Cn-0004Pz-BU; Sat, 11 Dec 2021 15:22:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245372.423413; Sat, 11 Dec 2021 15:22:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4Cn-0004Ps-8R; Sat, 11 Dec 2021 15:22:33 +0000
Received: by outflank-mailman (input) for mailman id 245372;
 Sat, 11 Dec 2021 15:22:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=koyS=Q4=arndb.de=arnd@srs-se1.protection.inumbo.net>)
 id 1mw4Ck-0003xO-V2
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 15:22:31 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27c844ff-5a96-11ec-a74f-db008197e53d;
 Sat, 11 Dec 2021 16:22:30 +0100 (CET)
Received: from mail-wm1-f43.google.com ([209.85.128.43]) by
 mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis)
 id 1Msqpq-1mgTGP1obI-00tEJR for <xen-devel@lists.xenproject.org>; Sat, 11 Dec
 2021 16:22:29 +0100
Received: by mail-wm1-f43.google.com with SMTP id 133so8956061wme.0
 for <xen-devel@lists.xenproject.org>; Sat, 11 Dec 2021 07:22:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27c844ff-5a96-11ec-a74f-db008197e53d
X-Gm-Message-State: AOAM532gurwP4uzRbhBTK5q/IPwAShcnPGS6DoP34fkj/236fwG4hmUC
	/WIdaw1DkOiuf+Qfj6Y9MCZUdOXVPoTGFaW3V4I=
X-Google-Smtp-Source: ABdhPJyOlfLidEd9162beuC5UM1yFpg2300rafM4JRbY2mJjNOXxVFZo/cAEJoaFFS655TaSoVWjWn5yGpFZ9WnPivI=
X-Received: by 2002:a05:600c:6d2:: with SMTP id b18mr25037494wmn.98.1639236149109;
 Sat, 11 Dec 2021 07:22:29 -0800 (PST)
MIME-Version: 1.0
References: <20211210221642.869015045@linutronix.de> <20211210221813.617178827@linutronix.de>
In-Reply-To: <20211210221813.617178827@linutronix.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sat, 11 Dec 2021 16:22:13 +0100
X-Gmail-Original-Message-ID: <CAK8P3a0SPopq871z7hbeTZbgnpO=cnEz-4Pmi1Ko3SHFTpU-mg@mail.gmail.com>
Message-ID: <CAK8P3a0SPopq871z7hbeTZbgnpO=cnEz-4Pmi1Ko3SHFTpU-mg@mail.gmail.com>
Subject: Re: [patch V3 07/35] device: Move MSI related data into a struct
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, 
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, 
	Ashok Raj <ashok.raj@intel.com>, linux-pci <linux-pci@vger.kernel.org>, 
	Cedric Le Goater <clg@kaod.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Juergen Gross <jgross@suse.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Arnd Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, 
	Bjorn Helgaas <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, 
	Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, 
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, 
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, 
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Jassi Brar <jassisinghbrar@gmail.com>, 
	Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K1:kLhBncfpdlXjXo8Z/i0X8RYODod4emiEurxyvqYPg1zTiPUicuI
 2ep7TgyO1eBjujt/ksqxQLMBfBJhnNZ+mqf3151Wkh3hxdHdrRYJj4LCs1j2il7WSPT6yIL
 rgt8YAl6/Er/EGamTSSlQY6zbZ49AZ5pyBo2//yhRcwsscmqXWuFQr/94AkKd6wQ4t4yQO3
 alIjNrC8qlkXaKzFTimRQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:+iBXNxuGYzw=:KzBY+9E+8FBTea/BqfftdE
 UWwW3jCnnZ5S6cstPl8GjIBMMfIeZATR7cJkPccL9RysaCP5jfROg/T3969zqepvPwcHEQXJq
 U33ZF/zFCREgPdf3M9YYyHUBC4nhSn+0GFCyzuFgmOc+XHiLmy0RI036bXIJTRkUbx+5VBH/B
 SP25XIW5t8eS/jXiWnNEgbyQBKJCBSl+PxtUKCcL5loYkQZzeUaJEy3CiAkbfYZMgw1+ENhY6
 NMNlFtJJhm5g2k1IY5G6dYvMoey2IdKEYqgclh4IFZb0SZ87F/WVtQK685/rhZSzBM3QGk0d8
 kPNhQ5Emk27d+3Recmb2AfyIDwHJ7f6TciJX/BX/PiAFyc6Wz8MFDFy+pNgd4M3r1MqDGwyzs
 UNYqnhYU9DG1jbWCRJ11Aq6b3j05NGMCErrTQ0cDCJPWy05jcetbOs3LgQcdXaIFeemB/C+6t
 i0MdfoWml3WxLYPgDZCuT4PxVZsCdmEQ/Mr3AtkwksqmPpPbSJ8IBpzBqwsEMYiuskQEZilnr
 EQWWA6GGbd9vrkHpftOeV2hUSU5Wl1i2Zksh6J2p42IyAOF7h7bNo3dqPL8vAa08st+oiM/Yo
 itpIpsQUHv9ZehRAukFD0Ts20pib+VVjU7lvFV3JCOa9rZG0EFV5aBzbWXwdvaDGU88jKV2Oy
 gjvjV2kOsGRMb1beYVVxKiXSEBrDk8kk2RnnMypN//yMa8xMjRQBY5McyPsFOUpNrV6wNZ2v1
 gGdz0hARGbQNd2zwQ+NdXcjTZ+f2BvasMDT3J8PQXkLdZhKaknnAfTXUdloh9NIKPcapjk9fS
 JtzgkdOh6uDe2MdBfN/9BkY0V7oNF7PSz9//3ShJ8DVmF5zRmY=

On Fri, Dec 10, 2021 at 11:18 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> From: Thomas Gleixner <tglx@linutronix.de>
>
> The only unconditional part of MSI data in struct device is the irqdomain
> pointer. Everything else can be allocated on demand. Create a data
> structure and move the irqdomain pointer into it. The other MSI specific
> parts are going to be removed from struct device in later steps.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 15:27:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 15:27:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245383.423424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4HH-0005Om-Ti; Sat, 11 Dec 2021 15:27:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245383.423424; Sat, 11 Dec 2021 15:27:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4HH-0005Of-Qk; Sat, 11 Dec 2021 15:27:11 +0000
Received: by outflank-mailman (input) for mailman id 245383;
 Sat, 11 Dec 2021 15:27:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4HG-0005OV-H5; Sat, 11 Dec 2021 15:27:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4HG-0003YU-Bw; Sat, 11 Dec 2021 15:27:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4HG-0003eb-0d; Sat, 11 Dec 2021 15:27:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4HG-00049R-0D; Sat, 11 Dec 2021 15:27:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=5pDkqO7Egst5SEvMdSShn7esRKeDVE2p6R3dsfPde70=; b=FEZ4PkOgZItLncEah1fYgQbPnB
	hAIfsk+rxQhTqoIATbZWJik5ehEyzvt/6IWgyBMqJdQw/w+Vld4s9/uFHPBAu1/8o5M0xyvS/HRK5
	hzZlx5GdJWp4KBWpWTxcK25C/aU4nlVXk2Pn4SSTpcwU3uVTsbDynTLcALi6nbybMVjc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167375-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167375: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=7594c5bfe2d9943aaca73c492dcbf7015bfbf825
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 15:27:10 +0000

flight 167375 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167375/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 7594c5bfe2d9943aaca73c492dcbf7015bfbf825
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   56 attempts
Testing same since   167375  2021-12-11 14:41:38 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Rob Bradford <robert.bradford@intel.com>
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1256 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 15:59:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 15:59:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245392.423439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4m5-0000mu-H5; Sat, 11 Dec 2021 15:59:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245392.423439; Sat, 11 Dec 2021 15:59:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw4m5-0000mn-E2; Sat, 11 Dec 2021 15:59:01 +0000
Received: by outflank-mailman (input) for mailman id 245392;
 Sat, 11 Dec 2021 15:59:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4m4-0000md-Ki; Sat, 11 Dec 2021 15:59:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4m4-000433-C0; Sat, 11 Dec 2021 15:59:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4m4-0004Ky-4C; Sat, 11 Dec 2021 15:59:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw4m4-0003O2-3g; Sat, 11 Dec 2021 15:59:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QYS0mlwVGUyvJdK4tZ0G4WztYsbnu7nUkLvH+P+fhrM=; b=PW6sdUFGkYxwr2G1f1TeLAhc4e
	vB35sDEbL2OFRby/ul7DSh0T2qXdpeLKDM5ziX3REGdwvH+U0FIRJ4awzuhsrjRs/Tz9se0Vm71pi
	4pm8zIHUGCb20c3r6dkq7kvnrza8rmhPgboLDJLrhHXuS4ONXqvW58LmApCabLfqfdWA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167376-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167376: regressions - FAIL
X-Osstest-Failures:
    ovmf:build-amd64:xen-build:fail:regression
    ovmf:build-i386-xsm:xen-build:fail:regression
    ovmf:build-i386:xen-build:fail:regression
    ovmf:build-amd64-xsm:xen-build:fail:regression
    ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking
    ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking
    ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    ovmf=7594c5bfe2d9943aaca73c492dcbf7015bfbf825
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 15:59:00 +0000

flight 167376 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167376/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-amd64                   6 xen-build                fail REGR. vs. 167239
 build-i386-xsm                6 xen-build                fail REGR. vs. 167239
 build-i386                    6 xen-build                fail REGR. vs. 167239
 build-amd64-xsm               6 xen-build                fail REGR. vs. 167239

Tests which did not succeed, but are not blocking:
 build-amd64-libvirt           1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemuu-ovmf-amd64  1 build-check(1)             blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a

version targeted for testing:
 ovmf                 7594c5bfe2d9943aaca73c492dcbf7015bfbf825
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   57 attempts
Testing same since   167375  2021-12-11 14:41:38 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Rob Bradford <robert.bradford@intel.com>
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              fail    
 build-i386-xsm                                               fail    
 build-amd64                                                  fail    
 build-i386                                                   fail    
 build-amd64-libvirt                                          blocked 
 build-i386-libvirt                                           blocked 
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         blocked 
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1256 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 17:27:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 17:27:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245400.423453 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw69W-00031E-0y; Sat, 11 Dec 2021 17:27:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245400.423453; Sat, 11 Dec 2021 17:27:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw69V-000317-Tz; Sat, 11 Dec 2021 17:27:17 +0000
Received: by outflank-mailman (input) for mailman id 245400;
 Sat, 11 Dec 2021 17:27:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=koyS=Q4=arndb.de=arnd@srs-se1.protection.inumbo.net>)
 id 1mw69T-000311-Q6
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 17:27:15 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 935291ae-5aa7-11ec-bf02-3911bdbc85ab;
 Sat, 11 Dec 2021 18:27:14 +0100 (CET)
Received: from mail-wr1-f41.google.com ([209.85.221.41]) by
 mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis)
 id 1MgNxZ-1mKFtY2m7z-00hs5U for <xen-devel@lists.xenproject.org>; Sat, 11 Dec
 2021 18:27:11 +0100
Received: by mail-wr1-f41.google.com with SMTP id d9so20086646wrw.4
 for <xen-devel@lists.xenproject.org>; Sat, 11 Dec 2021 09:27:11 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 935291ae-5aa7-11ec-bf02-3911bdbc85ab
X-Gm-Message-State: AOAM532hbBw60Gq0vqdGX8Z4CrdbK2Y7uLb7RN2n+B1DoBoBXtZB7an+
	Y+fW7OGvFGlryl0NrSi+3qzVee2Vw0UEH9tu1NA=
X-Google-Smtp-Source: ABdhPJydOCBHCBVhL5GrxiQp2LNkO7SO9fSpEb1ktgLdLbaiYOV8bo99cpA+GLEsnha3mdPvOSWLSKg/3Dqg7U73gXw=
X-Received: by 2002:a5d:6902:: with SMTP id t2mr20632629wru.317.1639236258246;
 Sat, 11 Dec 2021 07:24:18 -0800 (PST)
MIME-Version: 1.0
References: <20211210221642.869015045@linutronix.de> <20211210221815.269468319@linutronix.de>
In-Reply-To: <20211210221815.269468319@linutronix.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sat, 11 Dec 2021 16:24:02 +0100
X-Gmail-Original-Message-ID: <CAK8P3a2=LKoe1nw1sZZmxFwAh+54n-Q3cMO3goHEVMQKSVSh+g@mail.gmail.com>
Message-ID: <CAK8P3a2=LKoe1nw1sZZmxFwAh+54n-Q3cMO3goHEVMQKSVSh+g@mail.gmail.com>
Subject: Re: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq()
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, 
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, 
	Ashok Raj <ashok.raj@intel.com>, linux-pci <linux-pci@vger.kernel.org>, 
	Cedric Le Goater <clg@kaod.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Peter Ujfalusi <peter.ujfalusi@gmail.com>, Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, 
	Juergen Gross <jgross@suse.com>, xen-devel <xen-devel@lists.xenproject.org>, 
	Arnd Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, 
	Benjamin Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, 
	Bjorn Helgaas <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, 
	Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, 
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, 
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Jassi Brar <jassisinghbrar@gmail.com>, 
	Sinan Kaya <okaya@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K1:bI5LeAr6NWIRKApNWquEDUEEIUDTCSN/4avtPFtkXHDgx8OONo3
 E1GxdGy0Kf/3zxYIUNVCvGVD5oGierGmGFKt07aDv26t4t8i6O06CxKvX9YCwZ5C/J9Hq/L
 zsTDUFgAVk1SEkIrAYdfh0lvP6vhyRvuh9jMgKi8asgOH8qZ95sUGC1i6gi1j3s6KbdoGyS
 NpAVIUIj9yQqA76CzRVNA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:BD8eTisfwWI=:PP20DiFTcycvvl7AT6YuCn
 50kPMXCKwplltSCEe6DGSx3+WR+cuKhDGjNNKQUa/1zYAVshC8lWo/hG8hw4mBXEJof9kdH4s
 8uLPtsfMJF0eq2RfqsOaSwvMRyfaXfutXuBSGXKYZxFk4WyMIay3xyFn3lBcTQZnJx4nu6xgC
 9w/nxyYNYirvePw1I/e7wZJbY1teCDNhNzu7+8U0kWtTyecgP/wwSsPeC/2H2Ed11NKowzBoz
 LoNOzb2YBgFm6hRVKB6MIpdkflkDpcOeq8Y4f9Ju74r1oc/1YQsCrYM1kVbmppUNld3yNoFZK
 EXLpn6Pl8XqCubfwBSlaK2vOo0Av1rIn1FeCXiTfth4pP4ZzzEP1SuFLop8lcKsB4bfDQr9EM
 c1nzRueqx3Rka4aY69teQ9BBr5nW9CLUTryXptpPoJnnQ9+gdSgbzTcmg2c96D1mD0xJgaHmn
 Glb6bJC6it/ElVIqFood1M1u589TosBzIC1GhALMN55Gr0aDGeb+HsXgXe/Hf044YDEzYQiRh
 1wYLhZFGt72pjfzpR2K/JXZRKRtQKDkXZR91sb8q2XBQTIOhTt7cqUDx+HLWvVGYL/5ri4hiz
 wx9338wQo0w/SOiNsZxBVg+BpsfxWwxIffXDvXy5QhOUf27SHi8JGnbwOH7/CC7RDxhR/p52J
 vp8jUl+Xv58yZY0ed/UtNYBa7NXzok6KymNmFRVokocY+E8sAT3cjT/5BM3wdhYNaXuF1Qwbr
 gHZ7AndAMm+DT0r1MKBloL3qBN1c188ja+DFMnSTu17gSfxXP88JQAk9JLpxLJj+kfnJ0ZNaw
 C1lByh5JJbkNMdJVvcoZYKunDRiQh6UqgwiIEYOGRl6YuStopI=

On Fri, Dec 10, 2021 at 11:19 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Just use the core function msi_get_virq().
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org

Acked-by: Arnd Bergmann <arnd@arndb.de>


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 17:41:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 17:41:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245409.423464 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw6N6-0005Vj-Bj; Sat, 11 Dec 2021 17:41:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245409.423464; Sat, 11 Dec 2021 17:41:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw6N6-0005Vc-8m; Sat, 11 Dec 2021 17:41:20 +0000
Received: by outflank-mailman (input) for mailman id 245409;
 Sat, 11 Dec 2021 17:41:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw6N5-0005VS-Ak; Sat, 11 Dec 2021 17:41:19 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw6N5-0006Ea-2E; Sat, 11 Dec 2021 17:41:19 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mw6N4-0006iH-Nc; Sat, 11 Dec 2021 17:41:18 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mw6N4-0001Mw-NB; Sat, 11 Dec 2021 17:41:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=DgK76rNs0bZAEOoEhy//Fm0Z+qWhLFN9xrHoTrzU8mU=; b=utoegIClBefXPxtNzP6xP4hnjv
	sgaYGQzCFRaDr9/Mf4xlIV3ktNFXn9T8/GDFzyurPmptTKZgvVzBIt5QmMoo4PN8zM9Aoxn4iTABO
	XwgRfwLQeBR0fhJEbG+TLEfc+cbRVWyNhU/TxaGEKmMDZ1KWLZCWTUlpw8dEf2ByjWtc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167377-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167377: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f6df289a1c43f60143bba530a823d3fd2eba6223
X-Osstest-Versions-That:
    ovmf=c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 17:41:18 +0000

flight 167377 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167377/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f6df289a1c43f60143bba530a823d3fd2eba6223
baseline version:
 ovmf                 c82ab4d8c148c4009e0b31d1dd2ea6f7d4aea80d

Last test of basis   167239  2021-12-09 06:23:17 Z    2 days
Failing since        167240  2021-12-09 08:42:46 Z    2 days   58 attempts
Testing same since   167377  2021-12-11 16:10:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Brijesh Singh <brijesh.singh@amd.com>
  Brijesh Singh via groups.io <brijesh.singh=amd.com@groups.io>
  Chris Jones <christopher.jones@arm.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Jason Andryuk <jandryuk@gmail.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Michael Roth <michael.roth@amd.com>
  Philippe Mathieu-Daude <philmd@redhat.com>
  Ray Ni <ray.ni@intel.com>
  Rob Bradford <robert.bradford@intel.com>
  Sebastien Boeuf <sebastien.boeuf@intel.com>
  Tom Lendacky <thomas.lendacky@amd.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c82ab4d8c1..f6df289a1c  f6df289a1c43f60143bba530a823d3fd2eba6223 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 17:57:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 17:57:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245417.423478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw6cP-0007R2-Lo; Sat, 11 Dec 2021 17:57:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245417.423478; Sat, 11 Dec 2021 17:57:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mw6cP-0007Qv-Ia; Sat, 11 Dec 2021 17:57:09 +0000
Received: by outflank-mailman (input) for mailman id 245417;
 Sat, 11 Dec 2021 17:57:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=koyS=Q4=arndb.de=arnd@srs-se1.protection.inumbo.net>)
 id 1mw6cO-0007Qp-Gw
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 17:57:08 +0000
Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c13d36fa-5aab-11ec-bf02-3911bdbc85ab;
 Sat, 11 Dec 2021 18:57:07 +0100 (CET)
Received: from mail-wm1-f44.google.com ([209.85.128.44]) by
 mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis)
 id 1MD9Gh-1mnY1r2A8P-0098CQ for <xen-devel@lists.xenproject.org>; Sat, 11 Dec
 2021 18:57:06 +0100
Received: by mail-wm1-f44.google.com with SMTP id 137so9084321wma.1
 for <xen-devel@lists.xenproject.org>; Sat, 11 Dec 2021 09:57:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c13d36fa-5aab-11ec-bf02-3911bdbc85ab
X-Gm-Message-State: AOAM5329O5eKDI1lZZVzT42mTBuzIhh1IBtSsY90nYIjcSo36t9Ohw8I
	eYavIq0J/5eFiyRYyuYue/cQO7chtBB7H3ZDvwI=
X-Google-Smtp-Source: ABdhPJz9JqWJLeTUfS5IahRcetLl+JbMiIvXpgsv1eGAXoUb1XDPjjtJEfoNcEXB+cjjosPGuUvpUWQic5X/F+X6I8s=
X-Received: by 2002:a1c:1c1:: with SMTP id 184mr24672882wmb.1.1639236184421;
 Sat, 11 Dec 2021 07:23:04 -0800 (PST)
MIME-Version: 1.0
References: <20211210221642.869015045@linutronix.de> <20211210221813.928842960@linutronix.de>
In-Reply-To: <20211210221813.928842960@linutronix.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Sat, 11 Dec 2021 16:22:48 +0100
X-Gmail-Original-Message-ID: <CAK8P3a00M1MGPEwMQpgGJ9-g9-P6e9wo8G1frfVMqJ4bRp1Okg@mail.gmail.com>
Message-ID: <CAK8P3a00M1MGPEwMQpgGJ9-g9-P6e9wo8G1frfVMqJ4bRp1Okg@mail.gmail.com>
Subject: Re: [patch V3 12/35] soc: ti: ti_sci_inta_msi: Allocate MSI device
 data on first use
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, 
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>, 
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, 
	Ashok Raj <ashok.raj@intel.com>, linux-pci <linux-pci@vger.kernel.org>, 
	Cedric Le Goater <clg@kaod.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nishanth Menon <nm@ti.com>, 
	Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, Juergen Gross <jgross@suse.com>, 
	xen-devel <xen-devel@lists.xenproject.org>, Arnd Bergmann <arnd@arndb.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, Bjorn Helgaas <bhelgaas@google.com>, 
	Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, 
	Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, 
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, 
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, 
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>, Jassi Brar <jassisinghbrar@gmail.com>, 
	Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>
Content-Type: text/plain; charset="UTF-8"
X-Provags-ID: V03:K1:ZVbHhN8Os/J46LP4oq57eP7yrPDdhaOA7qwEEi7F/tylCI7rxe5
 EnrK83Pq/2e+GfflNwl/VOCRLw7mOMYww9oe06hVExSTLYH2jsNl4T5sUdNZsh81EnacClx
 poYTlx7t0lj23OT6zknjsV1nBG/0RQfis7S8e4R0KYeM2UzkLz6T5GKijrft7UYDpY13BqG
 2ThEjopVjTwq1rDps9ZJQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:Wpe/1opoQi0=:jZ3Np3vGor0F52HpFaYOAV
 QJGJf3gjoYQ11Dnfk6PmIr04Xjm5+M3/YiJF1MJMLycueKVP0Z0ktrOHZaLVatmN/FMUyasYO
 0o+8F7H35NDTp5R3XZNYPLQ+5HNnAiydS+vs+2Xj0mudtoZ1xeZGuuZYJXc6btyCmXXWBy600
 JaethuIz4bbD3uS3mftahzSh0n8XENT2g792W5cxM2PKe8qvPtQsk/fs1sk6c+yVKxG3JphEw
 hIw20XDXPl8y1OLqJlTqMo/S6S03nBxSF2s9BidTDtHFvcxDiXtPGvpAEtMOvBJrktQhxkdW7
 yNptEh3xgef1oflbx7owlOvSK68bsWL4RuKh+Vlj/E3/IMwARjlKJ0Liev3LHzplgs8cHCjOD
 Eas5LaYlvX256nCAEUPOLPqfXvZRvaIykHShbXYsBFnt+0n+nPp+FRV8zU8FP+rdztClm7b4O
 8DvZcBXrIsiYL2Lu/6v2tL/hwPUFvhFgbB3YeMEX9l2r8icJas0NXK+wxbvXjJ9mrzxHjZ/jN
 /Vzd6FJji1BBBkM2VKk1ulaFoM3P2SLy2F66INRBnWrfOgO/znQfD7kFv/+j7A3bLE+vop3wb
 /ovJOJBopE15UhsxY0U9QVVQhWUlQ5+NtJm3xqTqoeGsmfobyiSxNtJ26lVhTYFZaxUhmuxQ8
 IVSUJhy5KoVHea5R+0oB+jeTAVZLBaifljNN1LdybI8x+qWg9El9QHvVJmQo3EatMt2MjsqpY
 /cmag10O3wQeRtkBIgqYv6DRzrw7HlYq+YOaNFdrX95VCgnZykvJm3BCn730Mye28UL22vxmP
 zc9l6rtvdNhP4G/5jH9R5o0Xyosar/UHFxN/iuPd0XjxkjnRyQ=

On Fri, Dec 10, 2021 at 11:19 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Allocate the MSI device data on first invocation of the allocation function.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org

Acked-by: Arnd Bergmann <arnd@arndb.de>


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 22:20:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 22:20:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245458.423489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwAjO-0002iW-Il; Sat, 11 Dec 2021 22:20:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245458.423489; Sat, 11 Dec 2021 22:20:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwAjO-0002iP-Fa; Sat, 11 Dec 2021 22:20:38 +0000
Received: by outflank-mailman (input) for mailman id 245458;
 Sat, 11 Dec 2021 22:20:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwAjM-0002iF-Sl; Sat, 11 Dec 2021 22:20:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwAjM-0002Uk-Bo; Sat, 11 Dec 2021 22:20:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwAjM-0000CW-0a; Sat, 11 Dec 2021 22:20:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwAjM-0005l9-07; Sat, 11 Dec 2021 22:20:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0/vHAd4nwTEbj26yWoIWRnZi6i3S6BSzwLyO9/X+XFM=; b=nkVSHoipIlWDmuPPvaPzqg9fam
	U9QaVyVbmcchFwjo/q0C5qVAOlFxOC5qwO6Y7U27L+IvJ0i+Bb47hYhhZO6VqtdQUUmFIYtQ0TCYP
	PQa3IA4VNEDqnHYEQEus2e6DichkUhHUKbpktvA6WnICBQV0f97UWZUCdZqaLLMBPxNk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167379-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167379: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=8c06c53b585a7443b1e0e6c0eff45a62d56472cc
X-Osstest-Versions-That:
    ovmf=f6df289a1c43f60143bba530a823d3fd2eba6223
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 22:20:36 +0000

flight 167379 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167379/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 8c06c53b585a7443b1e0e6c0eff45a62d56472cc
baseline version:
 ovmf                 f6df289a1c43f60143bba530a823d3fd2eba6223

Last test of basis   167377  2021-12-11 16:10:19 Z    0 days
Testing same since   167379  2021-12-11 18:11:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  lixianglai <lixianglai@loongson.cn>
  Min Xu <min.m.xu@intel.com>
  xianglai li <lixianglai@loongson.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f6df289a1c..8c06c53b58  8c06c53b585a7443b1e0e6c0eff45a62d56472cc -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:26:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:26:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245464.423503 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwBkX-0001CH-Iu; Sat, 11 Dec 2021 23:25:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245464.423503; Sat, 11 Dec 2021 23:25:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwBkX-0001CA-E5; Sat, 11 Dec 2021 23:25:53 +0000
Received: by outflank-mailman (input) for mailman id 245464;
 Sat, 11 Dec 2021 23:25:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwBkV-0001C0-LD; Sat, 11 Dec 2021 23:25:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwBkV-0003Xl-8w; Sat, 11 Dec 2021 23:25:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwBkU-0001m7-RM; Sat, 11 Dec 2021 23:25:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwBkU-0005yi-Qs; Sat, 11 Dec 2021 23:25:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ke1ODsFyYfJBlCBEiweFjOtPzowncdhE3u8f8Gk5c0w=; b=q5BDP77Xkq2KnQ8KiDWjfaMjnJ
	u4PFs4ciLDSmRW5Hay5H1AVS2+i4++6e79SCcCG0GqlkPMILrMtcOdLXNMUmh8imnkdkPTu9ijinC
	TrPJ3PakKAmNAwSwYV6809pnLrlFIXOo9DNr8n5Fn0LwByKg2+Belo9rbCTu5N989+rc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167378-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167378: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=eccea80be2576dee642bc6cab20f1a242d58a08c
X-Osstest-Versions-That:
    linux=6f513529296fd4f696afb4354c46508abe646541
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 11 Dec 2021 23:25:50 +0000

flight 167378 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167378/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167362

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167362
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167362
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167362
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167362
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167362
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167362
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167362
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167362
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                eccea80be2576dee642bc6cab20f1a242d58a08c
baseline version:
 linux                6f513529296fd4f696afb4354c46508abe646541

Last test of basis   167362  2021-12-11 04:56:36 Z    0 days
Testing same since   167378  2021-12-11 17:39:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Andrew Morton <akpm@linux-foundation.org>
  Baoquan He <bhe@redhat.com>
  Bjorn Andersson <bjorn.andersson@linaro.org>
  Chris Packham <chris.packham@alliedtelesis.co.nz>
  Christoph Hellwig <hch@lst.de>
  Cyril Hrubis <chrubis@suse.cz>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dave Young <dyoung@redhat.com>
  Davidlohr Bueso <dave@stgolabs.net>
  Davidlohr Bueso <dbueso@suse.de>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Drew DeVault <sir@cmpwn.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Geert Uytterhoeven <geert@linux-m68k.org>
  Gerald Schaefer <gerald.schaefer@linux.ibm.com>
  Guo Ren <guoren@linux.alibaba.com>
  Hou Tao <houtao1@huawei.com>
  Jens Axboe <axboe@kernel.dk>
  Johannes Weiner <hannes@cmpxchg.org>
  Keith Busch <kbusch@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Manjong Lee <mj0123.lee@samsung.com>
  Marc Zyngier <maz@kernel.org>
  Markus Hochholdinger <markus@hochholdinger.net>
  Martin Botka <martin.botka@somainline.org>
  Matthew Wilcox (Oracle) <willy@infradead.org>
  Maxim Levitsky <mlevitsk@redhat.com>
  Maxime Bizon <mbizon@freebox.fr>
  Michael S. Tsirkin <mst@redhat.com>
  Miles Chen <miles.chen@mediatek.com>
  Niklas Cassel <niklas.cassel@wdc.com>
  Oleg Nesterov <oleg@redhat.com>
  Oleksandr Natalenko <oleksandr@natalenko.name>
  Pavel Begunkov <asml.silence@gmail.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Rob Herring <robh@kernel.org>
  Roman Gushchin <guro@fb.com>
  Rui Miguel Silva <rmfrfs@gmail.com>
  Ruozhu Li <liruozhu@huawei.com>
  Sagi Grimberg <sagi@grimberg.me>
  SeongJae Park <sj@kernel.org>
  Song Liu <songliubraving@fb.com>
  Stephen Boyd <sboyd@kernel.org>
  Thierry Reding <treding@nvidia.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Vlastimil Babka <vbabka@suse.cz>
  Waiman Long <longman@redhat.com>
  Wolfram Sang <wsa@kernel.org>
  zhangyue <zhangyue1@kylinos.cn>
  Zhenguo Yao <yaozhenguo1@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6f513529296f..eccea80be257  eccea80be2576dee642bc6cab20f1a242d58a08c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:47:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:47:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245473.423516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC5O-0003ym-Fa; Sat, 11 Dec 2021 23:47:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245473.423516; Sat, 11 Dec 2021 23:47:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC5O-0003yf-CM; Sat, 11 Dec 2021 23:47:26 +0000
Received: by outflank-mailman (input) for mailman id 245473;
 Sat, 11 Dec 2021 23:47:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1IHf=Q4=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwC5N-0003yZ-Em
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 23:47:25 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af4ea804-5adc-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 00:47:24 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 7AA033A1;
 Sun, 12 Dec 2021 00:47:21 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id pp0w69gDddZJ; Sun, 12 Dec 2021 00:47:20 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 6EF4A33A;
 Sun, 12 Dec 2021 00:47:20 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwC5G-001qGp-DP;
 Sun, 12 Dec 2021 00:47:18 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af4ea804-5adc-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 00:47:18 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 52/57] stubdom: only build libxen*.a from tools/libs/
Message-ID: <20211211234718.kk4djhy4blhqpdt2@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-53-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206170241.13165-53-anthony.perard@citrix.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: +
X-Spam-Level: *
X-Rspamd-Server: hera
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Queue-Id: 7AA033A1
X-Spamd-Result: default: False [1.90 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 TO_DN_SOME(0.00)[];
	 FREEMAIL_ENVRCPT(0.00)[gmail.com];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 TAGGED_RCPT(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 RCPT_COUNT_FIVE(0.00)[5];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 FREEMAIL_CC(0.00)[lists.xenproject.org,gmail.com,xenproject.org,xen.org];
	 MID_RHS_NOT_FQDN(0.50)[];
	 SUSPICIOUS_RECIPS(1.50)[]

Anthony PERARD, le lun. 06 déc. 2021 17:02:35 +0000, a ecrit:
> Avoid generating *.map files or running headers.chk when all we need
> is the libxen*.a.
> 
> Also, allow force make to check again if libxen*.a needs rebuilt by
> adding a '.PHONY' prerequisite.
> 
> Also, remove DESTDIR= as we don't do installation in this target, so
> the value of DESTDIR doesn't matter.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  stubdom/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index ccfcf5b75f..5fb5dbc341 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -354,8 +354,8 @@ define BUILD_lib
>   .PHONY: libxen$(1) clean-libxen$(1)
>   libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
>   libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
> - libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE)
> -	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) DESTDIR= CONFIG_LIBXC_MINIOS=y -C libs-$$(XEN_TARGET_ARCH)/$(1)
> + libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
> +	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -C $$(@D) $$(@F)
>  
>   clean-libxen$(1):
>  	[ ! -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ] || $$(MAKE) DESTDIR= -C libs-$$(XEN_TARGET_ARCH)/$(1) clean
> -- 
> Anthony PERARD
> 


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:49:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:49:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245477.423528 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC7R-0004jR-Ri; Sat, 11 Dec 2021 23:49:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245477.423528; Sat, 11 Dec 2021 23:49:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC7R-0004jK-Or; Sat, 11 Dec 2021 23:49:33 +0000
Received: by outflank-mailman (input) for mailman id 245477;
 Sat, 11 Dec 2021 23:49:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1IHf=Q4=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwC7Q-0004jC-PX
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 23:49:32 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc65bc67-5adc-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 00:49:31 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 3B34D33A;
 Sun, 12 Dec 2021 00:49:31 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oVQQKpSoptPQ; Sun, 12 Dec 2021 00:49:30 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 04583273;
 Sun, 12 Dec 2021 00:49:29 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwC7N-001qHE-3f;
 Sun, 12 Dec 2021 00:49:29 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc65bc67-5adc-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 00:49:29 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 53/57] stubdom: introduce xenlibs.mk
Message-ID: <20211211234929.3vah2ko7rsk2etk6@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-54-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206170241.13165-54-anthony.perard@citrix.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: +
X-Spam-Level: *
X-Rspamd-Server: hera
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Queue-Id: 3B34D33A
X-Spamd-Result: default: False [1.90 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 TO_DN_SOME(0.00)[];
	 FREEMAIL_ENVRCPT(0.00)[gmail.com];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 TAGGED_RCPT(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 RCPT_COUNT_FIVE(0.00)[5];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 FREEMAIL_CC(0.00)[lists.xenproject.org,gmail.com,xenproject.org,xen.org];
	 MID_RHS_NOT_FQDN(0.50)[];
	 SUSPICIOUS_RECIPS(1.50)[]

Anthony PERARD, le lun. 06 déc. 2021 17:02:36 +0000, a ecrit:
> This new makefile will be used to build libraries that provides
> "Makefile.common".
> 
> At some point, we will be converting Makefile in tools/ to "subdirmk"
> and stubdom build will not be able to use those new makefiles, so we
> will put the necessary information for stubdom to build the xen
> libraries into a new Makefile.common and xenlibs.mk will use it.
> We only need to build static libraries and don't need anything else.
> 
> The check for the presence of "Makefile.common" will go aways once
> there is one for all libraries used by stubdom build.
> 
> Also remove DESTDIR= from "clean" targets, we don't do installation in
> this recipe so the value of DESTDIR doesn't matter.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  stubdom/xenlibs.mk | 13 +++++++++++++
>  stubdom/Makefile   |  9 +++++++--
>  2 files changed, 20 insertions(+), 2 deletions(-)
>  create mode 100644 stubdom/xenlibs.mk
> 
> diff --git a/stubdom/xenlibs.mk b/stubdom/xenlibs.mk
> new file mode 100644
> index 0000000000..5c8742ccf9
> --- /dev/null
> +++ b/stubdom/xenlibs.mk
> @@ -0,0 +1,13 @@
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +include Makefile.common
> +
> +LIBNAME := $(notdir $(CURDIR))
> +FILENAME_$(LIBNAME) ?= xen$(LIBNAME)
> +LIB_FILE_NAME = $(FILENAME_$(LIBNAME))
> +
> +lib$(LIB_FILE_NAME).a: $(OBJS-y)
> +	$(AR) rc $@ $^
> +
> +clean::
> +	rm -f $(OBJS-y) lib$(LIB_FILE_NAME).a
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 5fb5dbc341..fba4c977ef 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -346,6 +346,7 @@ define do_links
>    cd $(dir $@); \
>    ln -sf $(dir $<)include/*.h include/; \
>    ln -sf $(dir $<)*.[ch] .; \
> +  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
>    ln -sf $(dir $<)Makefile .
>    touch $@
>  endef
> @@ -355,10 +356,14 @@ define BUILD_lib
>   libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
>   libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
>   libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
> -	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -C $$(@D) $$(@F)
> +	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
>  
>   clean-libxen$(1):
> -	[ ! -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ] || $$(MAKE) DESTDIR= -C libs-$$(XEN_TARGET_ARCH)/$(1) clean
> +	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
> +	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
> +	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
> +	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
> +	fi
>  
>   libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile
>  	$$(do_links)
> -- 
> Anthony PERARD
> 

-- 
Samuel
<y> update-menus: relocation error: update-menus: symbol _ZNSt9basic_iosIcSt11char_traitsIcEE4initEPSt15basic_streambufIcS1_E, version GLIBCPP_3.2 not defined in file libstdc++.so.5 with link time reference
<y> quoi que ça peut bien vouloir dire ?
<D> N a eu la meme merde
<y> c ça que ça veut dire ? wow, c'est bien crypté :)
 -+- #ens-mim s'entraide -+-


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:51:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:51:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245481.423539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC9B-00065O-8P; Sat, 11 Dec 2021 23:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245481.423539; Sat, 11 Dec 2021 23:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwC9B-00065H-3y; Sat, 11 Dec 2021 23:51:21 +0000
Received: by outflank-mailman (input) for mailman id 245481;
 Sat, 11 Dec 2021 23:51:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1IHf=Q4=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwC9A-00065A-7P
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 23:51:20 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c5a295c-5add-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 00:51:19 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 70F91273;
 Sun, 12 Dec 2021 00:51:18 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id w0dPIWoGwiQj; Sun, 12 Dec 2021 00:51:17 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 68E65181;
 Sun, 12 Dec 2021 00:51:17 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwC96-001qHb-Gr;
 Sun, 12 Dec 2021 00:51:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c5a295c-5add-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 00:51:16 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 56/57] stubdom: build xenstore*-stubdom using new
 Makefile.common
Message-ID: <20211211235116.fzyjg2hcpzdzzr5n@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-57-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206170241.13165-57-anthony.perard@citrix.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: +
X-Spam-Level: *
X-Rspamd-Server: hera
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Queue-Id: 70F91273
X-Spamd-Result: default: False [1.90 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 TO_DN_SOME(0.00)[];
	 FREEMAIL_ENVRCPT(0.00)[gmail.com];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 TAGGED_RCPT(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 RCPT_COUNT_FIVE(0.00)[5];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 FREEMAIL_CC(0.00)[lists.xenproject.org,gmail.com,xenproject.org,xen.org];
	 MID_RHS_NOT_FQDN(0.50)[];
	 SUSPICIOUS_RECIPS(1.50)[]

Anthony PERARD, le lun. 06 déc. 2021 17:02:39 +0000, a ecrit:
> Makefile.common have everything needed by stubdom, when used with
> xenlibs.mk, so we don't need "Makefile" anymore.
> 
> Also, remove DESTDIR for "xenstore" related targets, "xenlibs.mk"
> doesn't use DESTDIR so its value doesn't matter.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  stubdom/Makefile | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 6b804824ba..1fa075b9ad 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -346,8 +346,7 @@ define do_links
>    cd $(dir $@); \
>    ln -sf $(dir $<)include/*.h include/; \
>    ln -sf $(dir $<)*.[ch] .; \
> -  [ -e $(dir $<)Makefile.common ] && ln -sf $(dir $<)Makefile.common . ||:; \
> -  ln -sf $(dir $<)Makefile .
> +  ln -sf $(dir $<)Makefile.common .
>    touch $@
>  endef
>  
> @@ -356,13 +355,11 @@ define BUILD_lib
>   libxen$(1): libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a
>   libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: $$(LIBDEPS_$(1)) $$(LIBDEP_$(1))
>   libs-$$(XEN_TARGET_ARCH)/$(1)/libxen$(1).a: mk-headers-$$(XEN_TARGET_ARCH) $$(NEWLIB_STAMPFILE) .phony
> -	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y $$(if $$(wildcard $$(@D)/Makefile.common),-f $(CURDIR)/xenlibs.mk) -C $$(@D) $$(@F)
> +	CPPFLAGS="$$(TARGET_CPPFLAGS)" CFLAGS="$$(TARGET_CFLAGS)" $$(MAKE) CONFIG_LIBXC_MINIOS=y -f $(CURDIR)/xenlibs.mk -C $$(@D) $$(@F)
>  
>   clean-libxen$(1):
>  	if [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile.common ]; then \
>  	    $$(MAKE) -f $(CURDIR)/xenlibs.mk -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
> -	elif [ -e libs-$$(XEN_TARGET_ARCH)/$(1)/Makefile ]; then \
> -	    $$(MAKE) -C libs-$$(XEN_TARGET_ARCH)/$(1) clean; \
>  	fi
>  
>   libs-$$(XEN_TARGET_ARCH)/$(1)/stamp: $$(XEN_ROOT)/tools/libs/$(1)/Makefile.common
> @@ -494,7 +491,7 @@ xenstore-minios-config.mk: $(CURDIR)/xenstore-minios.cfg
>  
>  .PHONY: xenstore
>  xenstore: $(CROSS_ROOT) xenstore-minios-config.mk
> -	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
> +	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstore-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
>  
>  #############
>  # xenstorepvh
> @@ -505,7 +502,7 @@ xenstorepvh-minios-config.mk: $(CURDIR)/xenstorepvh-minios.cfg
>  
>  .PHONY: xenstorepvh
>  xenstorepvh: $(CROSS_ROOT) xenstorepvh-minios-config.mk
> -	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) DESTDIR= -C $@ xenstored.a CONFIG_STUBDOM=y
> +	CPPFLAGS="$(TARGET_CPPFLAGS) $(shell cat xenstorepvh-minios-config.mk)" CFLAGS="$(TARGET_CFLAGS)" $(MAKE) -f $(CURDIR)/xenlibs.mk -C $@ xenstored.a CONFIG_STUBDOM=y
>  
>  ########
>  # minios
> @@ -657,8 +654,8 @@ clean:
>  	rm -f *-minios-config.mk
>  	rm -fr pkg-config
>  	-[ ! -d ioemu ] || $(MAKE) DESTDIR= -C ioemu clean
> -	-[ ! -d xenstore ] || $(MAKE) DESTDIR= -C xenstore clean
> -	-[ ! -d xenstorepvh ] || $(MAKE) DESTDIR= -C xenstorepvh clean
> +	-[ ! -d xenstore ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstore clean
> +	-[ ! -d xenstorepvh ] || $(MAKE) -f $(CURDIR)/xenlibs.mk -C xenstorepvh clean
>  
>  # clean the cross-compilation result
>  .PHONY: crossclean
> -- 
> Anthony PERARD
> 

-- 
Samuel
Now I know someone out there is going to claim, "Well then, UNIX is intuitive,
because you only need to learn 5000 commands, and then everything else follows
from that! Har har har!"
(Andy Bates in comp.os.linux.misc, on "intuitive interfaces", slightly
defending Macs.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:53:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:53:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245485.423549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCBY-0006gc-KJ; Sat, 11 Dec 2021 23:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245485.423549; Sat, 11 Dec 2021 23:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCBY-0006gV-HN; Sat, 11 Dec 2021 23:53:48 +0000
Received: by outflank-mailman (input) for mailman id 245485;
 Sat, 11 Dec 2021 23:53:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1IHf=Q4=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCBX-0006gP-8k
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 23:53:47 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [2a0c:e300::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 930917c2-5add-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 00:53:46 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id B0C03392;
 Sun, 12 Dec 2021 00:53:43 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id tFpEpRvR65lK; Sun, 12 Dec 2021 00:53:43 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id AFD9C181;
 Sun, 12 Dec 2021 00:53:42 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCBR-001qKM-U2;
 Sun, 12 Dec 2021 00:53:41 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 930917c2-5add-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 00:53:41 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 57/57] stubdom: xenlibs linkfarm, ignore non-regular
 files
Message-ID: <20211211235341.zogxzqinhxoowkxw@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org,
	Anthony PERARD <anthony.perard@gmail.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-58-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206170241.13165-58-anthony.perard@citrix.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: +
X-Spam-Level: *
X-Rspamd-Server: hera
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Queue-Id: B0C03392
X-Spamd-Result: default: False [1.90 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 TO_DN_SOME(0.00)[];
	 FREEMAIL_ENVRCPT(0.00)[gmail.com];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 TAGGED_RCPT(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 RCPT_COUNT_FIVE(0.00)[5];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 FREEMAIL_CC(0.00)[lists.xenproject.org,gmail.com,xenproject.org,xen.org];
	 MID_RHS_NOT_FQDN(0.50)[];
	 SUSPICIOUS_RECIPS(1.50)[]

Anthony PERARD, le lun. 06 déc. 2021 17:02:40 +0000, a ecrit:
> When we will convert tools/ build system, their will be a need to
> replace some use of "vpath". This will done making symbolic links.
> Those symlinks are not wanted by stubdom build system when making a
> linkfarm for the Xen libraries. To avoid them, we will use `find`
> instead of plain shell globbing.
> 
> For example, there will be a link to "xen/lib/x86/cpuid.o" in
> "tools/libs/guest/".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  stubdom/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/stubdom/Makefile b/stubdom/Makefile
> index 1fa075b9ad..b312f710cd 100644
> --- a/stubdom/Makefile
> +++ b/stubdom/Makefile
> @@ -345,7 +345,7 @@ define do_links
>    mkdir -p $(dir $@)include
>    cd $(dir $@); \
>    ln -sf $(dir $<)include/*.h include/; \
> -  ln -sf $(dir $<)*.[ch] .; \
> +  find $(dir $<) -maxdepth 1 -type f -name '*.[ch]' -exec ln -sf {} . \; ; \
>    ln -sf $(dir $<)Makefile.common .
>    touch $@
>  endef
> -- 
> Anthony PERARD
> 

-- 
Samuel
$ du temp.iso 
2,0T    temp.iso
$ ls temp.iso -l
-r-xr-xr-x    1 samy     thibault      16E 2003-03-22 14:44 temp.iso*
 -+- je vous dirai pas la marque de mon disque dur, na :p -+- 


From xen-devel-bounces@lists.xenproject.org Sat Dec 11 23:56:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 11 Dec 2021 23:56:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245491.423565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCEF-0007K5-5A; Sat, 11 Dec 2021 23:56:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245491.423565; Sat, 11 Dec 2021 23:56:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCEF-0007Jf-0V; Sat, 11 Dec 2021 23:56:35 +0000
Received: by outflank-mailman (input) for mailman id 245491;
 Sat, 11 Dec 2021 23:56:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1IHf=Q4=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCED-0007JG-Jk
 for xen-devel@lists.xenproject.org; Sat, 11 Dec 2021 23:56:33 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f61515b0-5add-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 00:56:31 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 466AB28B;
 Sun, 12 Dec 2021 00:56:30 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id fN01haenjv7s; Sun, 12 Dec 2021 00:56:29 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 00D7A1CF;
 Sun, 12 Dec 2021 00:56:28 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCE8-001qNi-88;
 Sun, 12 Dec 2021 00:56:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f61515b0-5add-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 00:56:28 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 01/10] mini-os: split e820 map handling into new source
 file
Message-ID: <20211211235628.kcbzkjl4xnlduu5w@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-2-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-2-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 466AB28B
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:28 +0100, a ecrit:
> Introduce e820.c containing all the E820 memory map handling.
> 
> No functional change.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  Makefile       |   1 +
>  arch/arm/mm.c  |   8 ----
>  arch/x86/mm.c  |  70 +----------------------------
>  e820.c         | 119 +++++++++++++++++++++++++++++++++++++++++++++++++
>  include/e820.h |   6 +++
>  5 files changed, 128 insertions(+), 76 deletions(-)
>  create mode 100644 e820.c
> 
> diff --git a/Makefile b/Makefile
> index 4b76b55..06b60fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,6 +41,7 @@ src-$(CONFIG_TPMFRONT) += tpmfront.c
>  src-$(CONFIG_TPM_TIS) += tpm_tis.c
>  src-$(CONFIG_TPMBACK) += tpmback.c
>  src-y += daytime.c
> +src-y += e820.c
>  src-y += events.c
>  src-$(CONFIG_FBFRONT) += fbfront.c
>  src-y += gntmap.c
> diff --git a/arch/arm/mm.c b/arch/arm/mm.c
> index f806c9f..9068166 100644
> --- a/arch/arm/mm.c
> +++ b/arch/arm/mm.c
> @@ -7,14 +7,6 @@
>  #include <lib.h>
>  
>  uint32_t physical_address_offset;
> -struct e820entry e820_map[1] = {
> -    {
> -        .addr = 0,
> -        .size = ULONG_MAX - 1,
> -        .type = E820_RAM
> -    }
> -};
> -unsigned e820_entries = 1;
>  
>  unsigned long allocate_ondemand(unsigned long n, unsigned long alignment)
>  {
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index 8ba14a5..8df93da 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -64,15 +64,6 @@ extern char stack[];
>  extern void page_walk(unsigned long va);
>  
>  #ifdef CONFIG_PARAVIRT
> -struct e820entry e820_map[1] = {
> -    {
> -        .addr = 0,
> -        .size = ULONG_MAX - 1,
> -        .type = E820_RAM
> -    }
> -};
> -unsigned e820_entries = 1;
> -
>  void arch_mm_preinit(void *p)
>  {
>      start_info_t *si = p;
> @@ -112,25 +103,11 @@ desc_ptr idt_ptr =
>      .base = (unsigned long)&idt,
>  };
>  
> -struct e820entry e820_map[E820_MAX];
> -unsigned e820_entries;
> -
> -static char *e820_types[E820_TYPES] = {
> -    [E820_RAM]      = "RAM",
> -    [E820_RESERVED] = "Reserved",
> -    [E820_ACPI]     = "ACPI",
> -    [E820_NVS]      = "NVS",
> -    [E820_UNUSABLE] = "Unusable",
> -    [E820_PMEM]     = "PMEM"
> -};
> -
>  void arch_mm_preinit(void *p)
>  {
>      long ret;
>      domid_t domid = DOMID_SELF;
> -    struct xen_memory_map memmap;
> -    int i;
> -    unsigned long pfn, max = 0;
> +    unsigned long max;
>  
>      pt_base = page_table_base;
>      first_free_pfn = PFN_UP(to_phys(&_end));
> @@ -142,53 +119,10 @@ void arch_mm_preinit(void *p)
>      }
>      last_free_pfn = ret;
>  
> -    memmap.nr_entries = E820_MAX;
> -    set_xen_guest_handle(memmap.buffer, e820_map);
> -    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
> -    if ( ret < 0 )
> -    {
> -        xprintk("could not get memory map\n");
> -        do_exit();
> -    }
> -    e820_entries = memmap.nr_entries;
> -
> -    for ( i = 0; i < e820_entries; i++ )
> -    {
> -        if ( e820_map[i].type != E820_RAM )
> -            continue;
> -        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> -        if ( pfn > max )
> -            max = pfn;
> -    }
> -
> +    max = e820_get_maxpfn();
>      if ( max < last_free_pfn )
>          last_free_pfn = max;
>  }
> -
> -void arch_print_memmap(void)
> -{
> -    int i;
> -    unsigned long from, to;
> -    char *type;
> -    char buf[12];
> -
> -    printk("Memory map:\n");
> -    for ( i = 0; i < e820_entries; i++ )
> -    {
> -        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
> -        {
> -            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
> -            type = buf;
> -        }
> -        else
> -        {
> -            type = e820_types[e820_map[i].type];
> -        }
> -        from = e820_map[i].addr;
> -        to = from + e820_map[i].size - 1;
> -        printk("%012lx-%012lx: %s\n", from, to, type);
> -    }
> -}
>  #endif
>  
>  /*
> diff --git a/e820.c b/e820.c
> new file mode 100644
> index 0000000..2165280
> --- /dev/null
> +++ b/e820.c
> @@ -0,0 +1,119 @@
> +/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
> + *
> + * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include <mini-os/types.h>
> +#include <mini-os/lib.h>
> +#include <mini-os/console.h>
> +#include <mini-os/os.h>
> +#include <mini-os/posix/limits.h>
> +#include <mini-os/e820.h>
> +#include <xen/memory.h>
> +
> +#ifdef CONFIG_E820_TRIVIAL
> +struct e820entry e820_map[1] = {
> +    {
> +        .addr = 0,
> +        .size = ULONG_MAX - 1,
> +        .type = E820_RAM
> +    }
> +};
> +
> +unsigned e820_entries = 1;
> +
> +static void e820_get_memmap(void)
> +{
> +}
> +
> +#else
> +struct e820entry e820_map[E820_MAX];
> +unsigned e820_entries;
> +
> +static char *e820_types[E820_TYPES] = {
> +    [E820_RAM]      = "RAM",
> +    [E820_RESERVED] = "Reserved",
> +    [E820_ACPI]     = "ACPI",
> +    [E820_NVS]      = "NVS",
> +    [E820_UNUSABLE] = "Unusable",
> +    [E820_PMEM]     = "PMEM"
> +};
> +
> +static void e820_get_memmap(void)
> +{
> +    long ret;
> +    struct xen_memory_map memmap;
> +
> +    memmap.nr_entries = E820_MAX;
> +    set_xen_guest_handle(memmap.buffer, e820_map);
> +    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
> +    if ( ret < 0 )
> +    {
> +        xprintk("could not get memory map\n");
> +        do_exit();
> +    }
> +    e820_entries = memmap.nr_entries;
> +}
> +
> +void arch_print_memmap(void)
> +{
> +    int i;
> +    unsigned long from, to;
> +    char *type;
> +    char buf[12];
> +
> +    printk("Memory map:\n");
> +    for ( i = 0; i < e820_entries; i++ )
> +    {
> +        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
> +        {
> +            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
> +            type = buf;
> +        }
> +        else
> +        {
> +            type = e820_types[e820_map[i].type];
> +        }
> +        from = e820_map[i].addr;
> +        to = from + e820_map[i].size - 1;
> +        printk("%012lx-%012lx: %s\n", from, to, type);
> +    }
> +}
> +#endif
> +
> +unsigned long e820_get_maxpfn(void)
> +{
> +    int i;
> +    unsigned long pfn, max = 0;
> +
> +    e820_get_memmap();
> +
> +    for ( i = 0; i < e820_entries; i++ )
> +    {
> +        if ( e820_map[i].type != E820_RAM )
> +            continue;
> +        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> +        if ( pfn > max )
> +            max = pfn;
> +    }
> +
> +    return max;
> +}
> diff --git a/include/e820.h b/include/e820.h
> index 920551c..af2129f 100644
> --- a/include/e820.h
> +++ b/include/e820.h
> @@ -24,6 +24,10 @@
>  #ifndef __E820_HEADER
>  #define __E820_HEADER
>  
> +#if defined(__arm__) || defined(__aarch64__) || defined(CONFIG_PARAVIRT)
> +#define CONFIG_E820_TRIVIAL
> +#endif
> +
>  /* PC BIOS standard E820 types and structure. */
>  #define E820_RAM          1
>  #define E820_RESERVED     2
> @@ -45,4 +49,6 @@ struct __packed e820entry {
>  extern struct e820entry e820_map[];
>  extern unsigned e820_entries;
>  
> +unsigned long e820_get_maxpfn(void);
> +
>  #endif /*__E820_HEADER*/
> -- 
> 2.26.2
> 

-- 
Samuel
* c is away : cuisine; bouffe
<y> oh, moi je fais plutôt cuisine & bouffe en fait :)
<c> oui c'est vrai, certains font cuisine && bouffe (juste au cas où... ;-))
<y> ( cuisine && bouffe ) || restau
<N> voire ((cuisine && bouffe) || restau) & apéritif
 -+- #ens-mim -+-


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:06:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:06:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245497.423575 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCNP-0001Gf-HZ; Sun, 12 Dec 2021 00:06:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245497.423575; Sun, 12 Dec 2021 00:06:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCNP-0001GY-Ee; Sun, 12 Dec 2021 00:06:03 +0000
Received: by outflank-mailman (input) for mailman id 245497;
 Sun, 12 Dec 2021 00:06:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCNN-0001GN-F9
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:06:01 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 499aabc2-5adf-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 01:06:00 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 9F67C28B;
 Sun, 12 Dec 2021 01:05:59 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 7nCufShTzUxx; Sun, 12 Dec 2021 01:05:59 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 0F223181;
 Sun, 12 Dec 2021 01:05:58 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCNK-001qVD-2Z;
 Sun, 12 Dec 2021 01:05:58 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 499aabc2-5adf-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:05:58 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
Message-ID: <20211212000558.232nzs7k5lklpbym@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-3-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 9F67C28B
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Hello,

Juergen Gross, le lun. 06 déc. 2021 08:23:29 +0100, a ecrit:
> - align the entries to page boundaries

> +    /* Adjust map entries to page boundaries. */
> +    for ( i = 0; i < e820_entries; i++ )
> +    {
> +        end = (e820_map[i].addr + e820_map[i].size + PAGE_SIZE - 1) & PAGE_MASK;
> +        e820_map[i].addr &= PAGE_MASK;
> +        e820_map[i].size = end - e820_map[i].addr;
> +    }

Mmm, what if the previous entry ends after the aligned start?

On real machines that does happen, and you'd rather round up the start
address of usable areas, rather than rounding it down (and conversely
for the end).

> +    /* Sort entries by start address. */
> +    for ( i = 0; i < e820_entries - 1; i++ )
> +    {
> +        if ( e820_map[i].addr > e820_map[i + 1].addr )
> +        {
> +            e820_swap_entries(i, i + 1);
> +            i = -1;
> +        }
> +    }

This looks O(n^3) to me? A bubble sort like this should be fine:

    /* Sort entries by start address. */
    for ( last = e820_entries; last > 1; last-- )
    {
        for ( i = 0; i < last - 1; i++ )
        {
            if ( e820_map[i].addr > e820_map[i + 1].addr )
            {
                e820_swap_entries(i, i + 1);
            }
        }
    }

Samuel


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:15:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:15:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245505.423595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCWp-0002zg-G2; Sun, 12 Dec 2021 00:15:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245505.423595; Sun, 12 Dec 2021 00:15:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCWp-0002zZ-Co; Sun, 12 Dec 2021 00:15:47 +0000
Received: by outflank-mailman (input) for mailman id 245505;
 Sun, 12 Dec 2021 00:15:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCWo-0002xR-JW
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:15:46 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [2a0c:e300::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a5f38cba-5ae0-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 01:15:45 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 1F0F11CF;
 Sun, 12 Dec 2021 01:15:44 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id yWRoFvYdAhqX; Sun, 12 Dec 2021 01:15:43 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 9F1801B8;
 Sun, 12 Dec 2021 01:15:43 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCWk-0024n2-Tk;
 Sun, 12 Dec 2021 01:15:42 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5f38cba-5ae0-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:15:42 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
Message-ID: <20211212001542.qhz7wfdwq7k5ymxr@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-4-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 1F0F11CF
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit:
> -    unsigned long pfn, max = 0;
> +    unsigned long pfns, max = 0;

I'd say rather rename max to start.

>      e820_get_memmap();
>  
> @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
>      {
>          if ( e820_map[i].type != E820_RAM )
>              continue;
> -        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> -        if ( pfn > max )
> -            max = pfn;
> +        pfns = e820_map[i].size >> PAGE_SHIFT;
> +        max = e820_map[i].addr >> PAGE_SHIFT;

since it's it's always the start of the e820 entry.

> +        if ( pages <= pfns )
> +            return max + pages;
> +        pages -= pfns;
> +        max += pfns;

Here we don't need do change max, only pages.

Samuel


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245511.423610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwChC-0004hd-Em; Sun, 12 Dec 2021 00:26:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245511.423610; Sun, 12 Dec 2021 00:26:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwChC-0004hW-BN; Sun, 12 Dec 2021 00:26:30 +0000
Received: by outflank-mailman (input) for mailman id 245511;
 Sun, 12 Dec 2021 00:26:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwChB-0004fO-5h
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:26:29 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 24686e93-5ae2-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 01:26:27 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 8FD6F3DB;
 Sun, 12 Dec 2021 01:26:25 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id NHojSOqlstbh; Sun, 12 Dec 2021 01:26:25 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 0A0CF254;
 Sun, 12 Dec 2021 01:26:24 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCh6-0024s8-3U;
 Sun, 12 Dec 2021 01:26:24 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24686e93-5ae2-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:26:24 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 04/10] mini-os: respect memory map when ballooning up
Message-ID: <20211212002624.fmmebrd5sudcmco4@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-5-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-5-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 8FD6F3DB
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:31 +0100, a ecrit:
> @@ -81,8 +93,11 @@ int balloon_up(unsigned long n_pages)
>      if ( n_pages > N_BALLOON_FRAMES )
>          n_pages = N_BALLOON_FRAMES;
>  
> +    start_pfn = e820_get_maxpfn(nr_mem_pages + 1) - 1;
> +    n_pages = e820_get_max_pages(start_pfn, n_pages);

I'd say call it e820_get_max_contig_pages?

> +unsigned long e820_get_max_pages(unsigned long pfn, unsigned long pages)
> +{
> +    int i;
> +    unsigned long end;
> +
> +    for ( i = 0; i < e820_entries; i++ )
> +    {
> +        if ( e820_map[i].type != E820_RAM ||
> +             (e820_map[i].addr >> PAGE_SHIFT) > pfn )
> +            continue;

"> pfn" looks odd to me? If the start of the e820 entry is already
beyond pfn, we'll never find any other entry. We however do want to skip
entries that have addr+size that is below pfn.

> +        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> +        return ((end - pfn) > pages) ? pages : end - pfn;
> +    }
> +
> +    return 0;
> +}


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:28:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:28:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245515.423625 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCiJ-0005Vd-Qh; Sun, 12 Dec 2021 00:27:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245515.423625; Sun, 12 Dec 2021 00:27:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCiJ-0005VW-NU; Sun, 12 Dec 2021 00:27:39 +0000
Received: by outflank-mailman (input) for mailman id 245515;
 Sun, 12 Dec 2021 00:27:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCiI-0005T8-KS
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:27:38 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e6d91c2-5ae2-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 01:27:36 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 79F633C1;
 Sun, 12 Dec 2021 01:27:36 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id wf_uaIP3FA89; Sun, 12 Dec 2021 01:27:36 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id A8A9828B;
 Sun, 12 Dec 2021 01:27:35 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCiF-0024v2-1q;
 Sun, 12 Dec 2021 01:27:35 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e6d91c2-5ae2-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:27:35 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 05/10] mini-os: don't repeat definition available via
 header file
Message-ID: <20211212002735.um4q6patid5sdhvs@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-6-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-6-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 79F633C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:32 +0100, a ecrit:
> arch/x86/setup.c is repeating the definition of __pte() instead using
> the appropriate header. Fix that.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  arch/x86/setup.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/x86/setup.c b/arch/x86/setup.c
> index 1ec68d3..b27bbed 100644
> --- a/arch/x86/setup.c
> +++ b/arch/x86/setup.c
> @@ -29,6 +29,7 @@
>  #include <mini-os/os.h>
>  #include <mini-os/lib.h> /* for printk, memcpy */
>  #include <mini-os/kernel.h>
> +#include <mini-os/hypervisor.h>
>  #include <xen/xen.h>
>  #include <xen/arch-x86/cpuid.h>
>  #include <xen/arch-x86/hvm/start_info.h>
> @@ -61,13 +62,6 @@ char stack[2*STACK_SIZE];
>  
>  extern char shared_info[PAGE_SIZE];
>  
> -#if defined(__x86_64__)
> -#define __pte(x) ((pte_t) { (x) } )
> -#else
> -#define __pte(x) ({ unsigned long long _x = (x);        \
> -    ((pte_t) {(unsigned long)(_x), (unsigned long)(_x>>32)}); })
> -#endif
> -
>  static inline void fpu_init(void) {
>  	asm volatile("fninit");
>  }
> -- 
> 2.26.2
> 

-- 
Samuel
 jr> J'ai fait.
 Ne bougez pas, l'aide soignante va venir nettoyer.
 -+- FF in GNU - Le vieil homme et la merde -+-


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:37:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245522.423636 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCrb-0007ET-Nz; Sun, 12 Dec 2021 00:37:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245522.423636; Sun, 12 Dec 2021 00:37:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCrb-0007EM-Kf; Sun, 12 Dec 2021 00:37:15 +0000
Received: by outflank-mailman (input) for mailman id 245522;
 Sun, 12 Dec 2021 00:37:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCra-0007EB-Ae
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:37:14 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [2a0c:e300::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a5fcb489-5ae3-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 01:37:13 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 8D9493C1;
 Sun, 12 Dec 2021 01:37:12 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id krA46Fvan94B; Sun, 12 Dec 2021 01:37:12 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 0F1EF229;
 Sun, 12 Dec 2021 01:37:11 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCrX-00251x-5g;
 Sun, 12 Dec 2021 01:37:11 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5fcb489-5ae3-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:37:11 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 06/10] mini-os: add memory map service functions
Message-ID: <20211212003711.l7jsqgbbxjzgl5iv@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-7-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-7-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 8D9493C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:33 +0100, a ecrit:
> +void e820_put_reserved_pfns(unsigned long start_pfn, int pages)
> +{
> +    int i;
> +    unsigned long addr = start_pfn << PAGE_SHIFT;
> +    unsigned long size = (long)pages << PAGE_SHIFT;
> +
> +    for ( i = 0; i < e820_entries && addr < e820_map[i].addr; i++ );

Shouldn't that be addr > e820_map[i].addr + e820_map[i].size?

> +    BUG_ON(i == e820_entries || e820_map[i].type != E820_RESERVED);

We should also BUG_ON e820_map[i].addr > addr (i.e. we didn't find an
entry that contained our address).

> +    if ( addr == e820_map[i].addr )
> +    {
> +        e820_map[i].addr += size;

I'd say BUG_ON here if e820_map[i].size < size.

> +        e820_map[i].size -= size;
> +        if ( e820_map[i].size == 0 )
> +            e820_remove_entry(i);
> +        return;
> +    }
> +
> +    if ( addr + size == e820_map[i].addr + e820_map[i].size )
> +    {
> +        e820_map[i].addr = addr;
> +        e820_map[i].size = size;

? Shouldn't that rather be just

> +        e820_map[i].size -= size;

? (since what we remove is at the end of the area, the start of the area
doesn't change)

> +        return;
> +    }


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:41:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:41:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245529.423655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCvf-0000Gy-DS; Sun, 12 Dec 2021 00:41:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245529.423655; Sun, 12 Dec 2021 00:41:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCvf-0000Gq-AB; Sun, 12 Dec 2021 00:41:27 +0000
Received: by outflank-mailman (input) for mailman id 245529;
 Sun, 12 Dec 2021 00:41:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCvd-0000Ea-PX
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:41:25 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b5f8910-5ae4-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 01:41:24 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 806A23C1;
 Sun, 12 Dec 2021 01:41:23 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id f4QIe0UBnj1B; Sun, 12 Dec 2021 01:41:22 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 411ED1CF;
 Sun, 12 Dec 2021 01:41:22 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCvZ-00255z-GS;
 Sun, 12 Dec 2021 01:41:21 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b5f8910-5ae4-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:41:21 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 07/10] mini-os: move x86 specific gnttab coding into
 arch/x86/gnttab.c
Message-ID: <20211212004121.27tquytcimfd47b5@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-8-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-8-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 806A23C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:34 +0100, a ecrit:
> Having grant table code in arch/x86/mm.c seems wrong. Move it to the
> new file arch/x86/gnttab.c, especially as the amount of code is
> expected to grow further.
> 
> No functional change.

There is the __pte fix that you'd probably want to mention.

> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  arch/x86/gnttab.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++
>  arch/x86/mm.c     | 47 ----------------------------
>  2 files changed, 78 insertions(+), 47 deletions(-)
>  create mode 100644 arch/x86/gnttab.c
> 
> diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
> new file mode 100644
> index 0000000..56e59d7
> --- /dev/null
> +++ b/arch/x86/gnttab.c
> @@ -0,0 +1,78 @@
> +/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
> + *
> + * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include <mini-os/os.h>
> +#include <mini-os/hypervisor.h>
> +#include <mini-os/gnttab.h>
> +#include <mini-os/mm.h>
> +#include <mini-os/types.h>
> +
> +grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
> +{
> +    struct gnttab_setup_table setup;
> +    unsigned long frames[nr_grant_frames];
> +
> +    setup.dom = DOMID_SELF;
> +    setup.nr_frames = nr_grant_frames;
> +    set_xen_guest_handle(setup.frame_list, frames);
> +
> +    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
> +    return map_frames(frames, nr_grant_frames);
> +}
> +
> +void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
> +{
> +#ifdef CONFIG_PARAVIRT
> +    int i;
> +
> +    for ( i = 0; i < nr_grant_frames; i++ )
> +    {
> +        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
> +                __pte(0x0 << PAGE_SHIFT), UVMF_INVLPG);
> +    }
> +#endif
> +    return;
> +}
> +
> +void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
> +{
> +    struct gnttab_setup_table setup;
> +    unsigned long frames[nr_grant_frames];
> +#ifdef CONFIG_PARAVIRT
> +    int i;
> +#endif
> +
> +    setup.dom = DOMID_SELF;
> +    setup.nr_frames = nr_grant_frames;
> +    set_xen_guest_handle(setup.frame_list, frames);
> +
> +    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
> +
> +#ifdef CONFIG_PARAVIRT
> +    for ( i = 0; i < nr_grant_frames; i++ )
> +    {
> +        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
> +                __pte((frames[i] << PAGE_SHIFT) | L1_PROT), UVMF_INVLPG);
> +    }
> +#endif
> +}
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index c30d8bc..220c0b4 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -837,53 +837,6 @@ void arch_init_mm(unsigned long* start_pfn_p, unsigned long* max_pfn_p)
>  #endif
>  }
>  
> -grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
> -{
> -    struct gnttab_setup_table setup;
> -    unsigned long frames[nr_grant_frames];
> -
> -    setup.dom = DOMID_SELF;
> -    setup.nr_frames = nr_grant_frames;
> -    set_xen_guest_handle(setup.frame_list, frames);
> -
> -    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
> -    return map_frames(frames, nr_grant_frames);
> -}
> -
> -void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
> -{
> -#ifdef CONFIG_PARAVIRT
> -    int i;
> -
> -    for (i = 0; i < nr_grant_frames; i++) {
> -        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
> -                (pte_t){0x0<<PAGE_SHIFT}, UVMF_INVLPG);
> -    }
> -#endif
> -    return;
> -}
> -
> -void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
> -{
> -    struct gnttab_setup_table setup;
> -    unsigned long frames[nr_grant_frames];
> -#ifdef CONFIG_PARAVIRT
> -    int i;
> -#endif
> -    setup.dom = DOMID_SELF;
> -    setup.nr_frames = nr_grant_frames;
> -    set_xen_guest_handle(setup.frame_list, frames);
> -
> -    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
> -
> -#ifdef CONFIG_PARAVIRT
> -    for (i = 0; i < nr_grant_frames; i++) {
> -        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
> -                (pte_t){(frames[i] << PAGE_SHIFT) | L1_PROT}, UVMF_INVLPG);
> -    }
> -#endif
> -}
> -
>  unsigned long alloc_virt_kernel(unsigned n_pages)
>  {
>      unsigned long addr;
> -- 
> 2.26.2
> 

-- 
Samuel
War doesn't prove who's right, just who's left.


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:43:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:43:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245537.423670 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCxi-00011Y-13; Sun, 12 Dec 2021 00:43:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245537.423670; Sun, 12 Dec 2021 00:43:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwCxh-00011Q-TE; Sun, 12 Dec 2021 00:43:33 +0000
Received: by outflank-mailman (input) for mailman id 245537;
 Sun, 12 Dec 2021 00:43:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwCxg-0000zD-G8
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:43:32 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 86ef05c4-5ae4-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 01:43:30 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id E12563C1;
 Sun, 12 Dec 2021 01:43:29 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id jN9RwrQgMh7V; Sun, 12 Dec 2021 01:43:29 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id E724D1CF;
 Sun, 12 Dec 2021 01:43:28 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwCxc-00256f-2y;
 Sun, 12 Dec 2021 01:43:28 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 86ef05c4-5ae4-11ec-bf02-3911bdbc85ab
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:43:28 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 08/10] mini-os: add proper pvh grant table handling
Message-ID: <20211212004328.ozyid2zh4fapcnit@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-9-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-9-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: E12563C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:35 +0100, a ecrit:
> Grant table initialization for PVH requires some additional actions
> compared to PV mode. Add those.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  arch/x86/gnttab.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
> index 56e59d7..281c207 100644
> --- a/arch/x86/gnttab.c
> +++ b/arch/x86/gnttab.c
> @@ -22,11 +22,15 @@
>   */
>  
>  #include <mini-os/os.h>
> +#include <mini-os/console.h>
> +#include <mini-os/e820.h>
>  #include <mini-os/hypervisor.h>
>  #include <mini-os/gnttab.h>
>  #include <mini-os/mm.h>
>  #include <mini-os/types.h>
> +#include <xen/memory.h>
>  
> +#ifdef CONFIG_PARAVIRT
>  grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
>  {
>      struct gnttab_setup_table setup;
> @@ -39,6 +43,33 @@ grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
>      HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
>      return map_frames(frames, nr_grant_frames);
>  }
> +#else
> +grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
> +{
> +    int i, rc;
> +    struct xen_add_to_physmap xatp;
> +    unsigned long pfn;
> +    unsigned long frames[nr_grant_frames];
> +
> +    pfn = e820_get_reserved_pfns(nr_grant_frames);
> +    for ( i = 0; i < nr_grant_frames; i++ )
> +    {
> +        xatp.domid = DOMID_SELF;
> +        xatp.idx = i;
> +        xatp.space = XENMAPSPACE_grant_table;
> +        xatp.gpfn = pfn + i;
> +        rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp);
> +        if ( rc )
> +        {
> +            xprintk("could not init grant table\n");
> +            do_exit();
> +        }
> +        frames[i] = pfn + i;
> +    }
> +
> +    return map_frames(frames, nr_grant_frames);
> +}
> +#endif
>  
>  void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
>  {
> -- 
> 2.26.2
> 

-- 
Samuel
 > Il [e2fsck] a bien démarré, mais il m'a rendu la main aussitot en me
 > disant "houlala, c'est pas beau à voir votre truc, je préfèrerai que
 > vous teniez vous même la tronçonneuse" (traduction libre)
 NC in Guide du linuxien pervers : "Bien configurer sa tronçonneuse."


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:51:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:51:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245542.423680 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwD4n-0002gV-Np; Sun, 12 Dec 2021 00:50:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245542.423680; Sun, 12 Dec 2021 00:50:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwD4n-0002gO-Kj; Sun, 12 Dec 2021 00:50:53 +0000
Received: by outflank-mailman (input) for mailman id 245542;
 Sun, 12 Dec 2021 00:50:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwD4m-0002gD-D8
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:50:52 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8cd37ad9-5ae5-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 01:50:50 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 4E27F3C1;
 Sun, 12 Dec 2021 01:50:49 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 4eQWN4mfQbNI; Sun, 12 Dec 2021 01:50:48 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 0107C28B;
 Sun, 12 Dec 2021 01:50:47 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwD4h-0025BJ-50;
 Sun, 12 Dec 2021 01:50:47 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8cd37ad9-5ae5-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:50:47 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 09/10] mini-os: prepare grantmap entry interface for use
 by PVH mode
Message-ID: <20211212005047.ksbjkax2veon2dvl@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-10-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-10-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 4E27F3C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:36 +0100, a ecrit:
> Instead of passing the pointer of a grantmap entry to the
> _gntmap_[un]map_grant_ref() sub-functions use the map pointer and the
> entry index instead. This will be needed for PVH mode usage.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  gntmap.c | 48 +++++++++++++++++++++++-------------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)
> 
> diff --git a/gntmap.c b/gntmap.c
> index f6ab3ad..7ae8fe6 100644
> --- a/gntmap.c
> +++ b/gntmap.c
> @@ -55,36 +55,34 @@ struct gntmap_entry {
>  };
>  
>  static inline int
> -gntmap_entry_used(struct gntmap_entry *entry)
> +gntmap_entry_used(struct gntmap *map, int idx)
>  {
> -    return entry->host_addr != 0;
> +    return map->entries[idx].host_addr != 0;
>  }
>  
> -static struct gntmap_entry*
> -gntmap_find_free_entry(struct gntmap *map)
> +static int gntmap_find_free_entry(struct gntmap *map)
>  {
>      int i;
>  
>      for (i = 0; i < map->nentries; i++) {
> -        if (!gntmap_entry_used(&map->entries[i]))
> -            return &map->entries[i];
> +        if (!gntmap_entry_used(map, i))
> +            return i;
>      }
>  
>      DEBUG("(map=%p): all %d entries full",
>             map, map->nentries);
> -    return NULL;
> +    return -1;
>  }
>  
> -static struct gntmap_entry*
> -gntmap_find_entry(struct gntmap *map, unsigned long addr)
> +static int gntmap_find_entry(struct gntmap *map, unsigned long addr)
>  {
>      int i;
>  
>      for (i = 0; i < map->nentries; i++) {
>          if (map->entries[i].host_addr == addr)
> -            return &map->entries[i];
> +            return i;
>      }
> -    return NULL;
> +    return -1;
>  }
>  
>  int
> @@ -105,12 +103,13 @@ gntmap_set_max_grants(struct gntmap *map, int count)
>  }
>  
>  static int
> -_gntmap_map_grant_ref(struct gntmap_entry *entry, 
> +_gntmap_map_grant_ref(struct gntmap *map, int idx,
>                        unsigned long host_addr,
>                        uint32_t domid,
>                        uint32_t ref,
>                        int writable)
>  {
> +    struct gntmap_entry *entry = map->entries + idx;
>      struct gnttab_map_grant_ref op;
>      int rc;
>  
> @@ -135,8 +134,9 @@ _gntmap_map_grant_ref(struct gntmap_entry *entry,
>  }
>  
>  static int
> -_gntmap_unmap_grant_ref(struct gntmap_entry *entry)
> +_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
>  {
> +    struct gntmap_entry *entry = map->entries + idx;
>      struct gnttab_unmap_grant_ref op;
>      int rc;
>  
> @@ -160,19 +160,19 @@ int
>  gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
>  {
>      int i, rc;
> -    struct gntmap_entry *ent;
> +    int idx;
>  
>      DEBUG("(map=%p, start_address=%lx, count=%d)",
>             map, start_address, count);
>  
>      for (i = 0; i < count; i++) {
> -        ent = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
> -        if (ent == NULL) {
> +        idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
> +        if (idx < 0) {
>              printk("gntmap: tried to munmap unknown page\n");
>              return -EINVAL;
>          }
>  
> -        rc = _gntmap_unmap_grant_ref(ent);
> +        rc = _gntmap_unmap_grant_ref(map, idx);
>          if (rc != 0)
>              return rc;
>      }
> @@ -189,7 +189,7 @@ gntmap_map_grant_refs(struct gntmap *map,
>                        int writable)
>  {
>      unsigned long addr;
> -    struct gntmap_entry *ent;
> +    int idx;
>      int i;
>  
>      DEBUG("(map=%p, count=%" PRIu32 ", "
> @@ -206,9 +206,9 @@ gntmap_map_grant_refs(struct gntmap *map,
>          return NULL;
>  
>      for (i = 0; i < count; i++) {
> -        ent = gntmap_find_free_entry(map);
> -        if (ent == NULL ||
> -            _gntmap_map_grant_ref(ent,
> +        idx = gntmap_find_free_entry(map);
> +        if (idx < 0 ||
> +            _gntmap_map_grant_ref(map, idx,
>                                    addr + PAGE_SIZE * i,
>                                    domids[i * domids_stride],
>                                    refs[i],
> @@ -233,15 +233,13 @@ gntmap_init(struct gntmap *map)
>  void
>  gntmap_fini(struct gntmap *map)
>  {
> -    struct gntmap_entry *ent;
>      int i;
>  
>      DEBUG("(map=%p)", map);
>  
>      for (i = 0; i < map->nentries; i++) {
> -        ent = &map->entries[i];
> -        if (gntmap_entry_used(ent))
> -            (void) _gntmap_unmap_grant_ref(ent);
> +        if (gntmap_entry_used(map, i))
> +            (void) _gntmap_unmap_grant_ref(map, i);
>      }
>  
>      xfree(map->entries);
> -- 
> 2.26.2
> 

-- 
Samuel
<L> pour moi le seul qui est autorisé à fasciser, c moi :-)


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 00:51:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 00:51:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245544.423695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwD4y-00032x-1y; Sun, 12 Dec 2021 00:51:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245544.423695; Sun, 12 Dec 2021 00:51:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwD4x-00032q-V5; Sun, 12 Dec 2021 00:51:03 +0000
Received: by outflank-mailman (input) for mailman id 245544;
 Sun, 12 Dec 2021 00:51:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=afVz=Q5=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwD4x-0002gD-7x
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 00:51:03 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9426cb2d-5ae5-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 01:51:02 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id F26C13C1;
 Sun, 12 Dec 2021 01:51:01 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id uElmtqq-kG3t; Sun, 12 Dec 2021 01:51:01 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 2141928B;
 Sun, 12 Dec 2021 01:51:01 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwD4u-0025BY-DH;
 Sun, 12 Dec 2021 01:51:00 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9426cb2d-5ae5-11ec-a74f-db008197e53d
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Sun, 12 Dec 2021 01:51:00 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 10/10] mini-os: modify grant mappings to work in PVH mode
Message-ID: <20211212005100.gld3gajiwiog54rv@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-11-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211206072337.9517-11-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: F26C13C1
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 06 déc. 2021 08:23:37 +0100, a ecrit:
> For being able to use the grant mapping interface in PVH mode some
> changes are required, as the guest needs to specify a physical address
> in the hypercall interface.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  gntmap.c         | 81 ++++++++++++++++++++++++++++++++++--------------
>  include/gntmap.h |  1 +
>  2 files changed, 59 insertions(+), 23 deletions(-)
> 
> diff --git a/gntmap.c b/gntmap.c
> index 7ae8fe6..126b04f 100644
> --- a/gntmap.c
> +++ b/gntmap.c
> @@ -32,6 +32,7 @@
>  
>  #include <mini-os/os.h>
>  #include <mini-os/lib.h>
> +#include <mini-os/e820.h>
>  #include <mini-os/xmalloc.h>
>  #include <errno.h>
>  #include <xen/grant_table.h>
> @@ -97,11 +98,42 @@ gntmap_set_max_grants(struct gntmap *map, int count)
>      if (map->entries == NULL)
>          return -ENOMEM;
>  
> +#ifndef CONFIG_PARAVIRT
> +    map->start_pfn = e820_get_reserved_pfns(count);
> +#endif
> +
>      memset(map->entries, 0, sizeof(struct gntmap_entry) * count);
>      map->nentries = count;
>      return 0;
>  }
>  
> +static int
> +_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
> +{
> +    struct gntmap_entry *entry = map->entries + idx;
> +    struct gnttab_unmap_grant_ref op;
> +    int rc;
> +
> +#ifdef CONFIG_PARAVIRT
> +    op.host_addr    = (uint64_t) entry->host_addr;
> +#else
> +    op.host_addr    = (uint64_t)(map->start_pfn + idx) << PAGE_SHIFT;
> +#endif
> +    op.dev_bus_addr = 0;
> +    op.handle       = entry->handle;
> +
> +    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
> +    if (rc != 0 || op.status != GNTST_okay) {
> +        printk("GNTTABOP_unmap_grant_ref failed: "
> +               "returned %d, status %" PRId16 "\n",
> +               rc, op.status);
> +        return rc != 0 ? rc : op.status;
> +    }
> +
> +    entry->host_addr = 0;
> +    return 0;
> +}
> +
>  static int
>  _gntmap_map_grant_ref(struct gntmap *map, int idx,
>                        unsigned long host_addr,
> @@ -112,10 +144,17 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
>      struct gntmap_entry *entry = map->entries + idx;
>      struct gnttab_map_grant_ref op;
>      int rc;
> +#ifndef CONFIG_PARAVIRT
> +    unsigned long pfn = map->start_pfn + idx;
> +#endif
>  
>      op.ref = (grant_ref_t) ref;
>      op.dom = (domid_t) domid;
> +#ifdef CONFIG_PARAVIRT
>      op.host_addr = (uint64_t) host_addr;
> +#else
> +    op.host_addr = (uint64_t)pfn << PAGE_SHIFT; 
> +#endif
>      op.flags = GNTMAP_host_map;
>      if (!writable)
>          op.flags |= GNTMAP_readonly;
> @@ -128,31 +167,18 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
>          return rc != 0 ? rc : op.status;
>      }
>  
> -    entry->host_addr = host_addr;
> -    entry->handle = op.handle;
> -    return 0;
> -}
> -
> -static int
> -_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
> -{
> -    struct gntmap_entry *entry = map->entries + idx;
> -    struct gnttab_unmap_grant_ref op;
> -    int rc;
> -
> -    op.host_addr    = (uint64_t) entry->host_addr;
> -    op.dev_bus_addr = 0;
> -    op.handle       = entry->handle;
> -
> -    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
> -    if (rc != 0 || op.status != GNTST_okay) {
> -        printk("GNTTABOP_unmap_grant_ref failed: "
> -               "returned %d, status %" PRId16 "\n",
> -               rc, op.status);
> -        return rc != 0 ? rc : op.status;
> +#ifndef CONFIG_PARAVIRT
> +    rc = do_map_frames(host_addr, &pfn, 1, 0, 0, DOMID_SELF, NULL,
> +                       writable ? L1_PROT : L1_PROT_RO);
> +    if ( rc )
> +    {
> +        _gntmap_unmap_grant_ref(map, idx);
> +        return rc;
>      }
> +#endif
>  
> -    entry->host_addr = 0;
> +    entry->host_addr = host_addr;
> +    entry->handle = op.handle;
>      return 0;
>  }
>  
> @@ -165,6 +191,10 @@ gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
>      DEBUG("(map=%p, start_address=%lx, count=%d)",
>             map, start_address, count);
>  
> +#ifndef CONFIG_PARAVIRT
> +    unmap_frames(start_address, count);
> +#endif
> +
>      for (i = 0; i < count; i++) {
>          idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
>          if (idx < 0) {
> @@ -242,6 +272,11 @@ gntmap_fini(struct gntmap *map)
>              (void) _gntmap_unmap_grant_ref(map, i);
>      }
>  
> +#ifndef CONFIG_PARAVIRT
> +    e820_put_reserved_pfns(map->start_pfn, map->nentries);
> +    map->start_pfn = 0;
> +#endif
> +
>      xfree(map->entries);
>      map->entries = NULL;
>      map->nentries = 0;
> diff --git a/include/gntmap.h b/include/gntmap.h
> index fde53f3..d3d7e88 100644
> --- a/include/gntmap.h
> +++ b/include/gntmap.h
> @@ -10,6 +10,7 @@
>  struct gntmap {
>      int nentries;
>      struct gntmap_entry *entries;
> +    unsigned long start_pfn;
>  };
>  
>  int
> -- 
> 2.26.2
> 

-- 
Samuel
 Yep. Moi j'ai un clavier à une touche. 
 Par contre, ma souris a 102 boutons, c'est pas toujours pratique.
 -+- OG in: Guide du Cabaliste Usenet - Le mulot contre attaque -+-


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 05:47:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 05:47:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245554.423711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwHhN-0004Ho-Ca; Sun, 12 Dec 2021 05:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245554.423711; Sun, 12 Dec 2021 05:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwHhN-0004Hb-5B; Sun, 12 Dec 2021 05:47:01 +0000
Received: by outflank-mailman (input) for mailman id 245554;
 Sun, 12 Dec 2021 03:25:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nb0k=Q5=cdjrlc.com=wangborong@srs-se1.protection.inumbo.net>)
 id 1mwFU2-0005S4-Vs
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 03:25:06 +0000
Received: from smtpbg587.qq.com (smtpbg126.qq.com [106.55.201.22])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 15a073fc-5afb-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 04:25:01 +0100 (CET)
Received: from localhost.localdomain (unknown [182.132.179.213])
 by esmtp6.qq.com (ESMTP) with 
 id ; Sun, 12 Dec 2021 11:24:26 +0800 (CST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 15a073fc-5afb-11ec-bf02-3911bdbc85ab
X-QQ-mid: bizesmtp44t1639279467tpfmb7r9
X-QQ-SSF: 01000000002000D0H000B00A0000000
X-QQ-FEAT: F3yR32iATbjGUty7JOvTDi9n9m+mqQYI+e6hSssoDfBJE9Gd1TVesQbCMo/zT
	XaJoDxOp5Ul78RrkWXckhcOORY64vVS4qzStsNL3hzJL3LMVuIJNV1J3pJipQIrybW8xzxE
	7p+ghhl9NUn7a07iDNvzpo5d1cL0fM6v6Q/125FwcN3+X3jB7Yl27zeBaAXKADvcfOByLrJ
	W8HyHVBHvjzDxfeuSst7SyPhRrOd2kKwMcIXUz3XZrNsVRfzQH3YuaPbgh8R2qb63WFJY3M
	/vjwaqXnzof+3K+A5nfEEXeJDN/ET/+HV0h0P1t25lYBlvzf8kDycHW+Bt8hJk2iZ+tgNGn
	OPcKH6XRVfHOp5f/XEO5bZ6t8JEnIPFAV0cQONr
X-QQ-GoodBg: 0
From: Jason Wang <wangborong@cdjrlc.com>
To: jgross@suse.com
Cc: boris.ostrovsky@oracle.com,
	sstabellini@kernel.org,
	wangborong@cdjrlc.com,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] xen/pciback: fix typo in a comment
Date: Sun, 12 Dec 2021 11:24:08 +0800
Message-Id: <20211212032408.52180-1-wangborong@cdjrlc.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:cdjrlc.com:qybgspam:qybgspam2

The double `the' in the comment in line 163 is repeated. Remove it
from the comment.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 drivers/xen/xen-pciback/pciback_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
index 3fbc21466a93..e38b43b5065e 100644
--- a/drivers/xen/xen-pciback/pciback_ops.c
+++ b/drivers/xen/xen-pciback/pciback_ops.c
@@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *pdev,
 	}
 
 	/* The value the guest needs is actually the IDT vector, not the
-	 * the local domain's IRQ number. */
+	 * local domain's IRQ number. */
 
 	op->value = dev->irq ? xen_pirq_from_irq(dev->irq) : 0;
 
-- 
2.34.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 06:11:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 06:11:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245564.423721 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwI4f-0007rP-5P; Sun, 12 Dec 2021 06:11:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245564.423721; Sun, 12 Dec 2021 06:11:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwI4f-0007rI-2R; Sun, 12 Dec 2021 06:11:05 +0000
Received: by outflank-mailman (input) for mailman id 245564;
 Sun, 12 Dec 2021 06:11:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwI4e-0007r8-5w; Sun, 12 Dec 2021 06:11:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwI4e-00054Z-1f; Sun, 12 Dec 2021 06:11:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwI4d-0002us-Ll; Sun, 12 Dec 2021 06:11:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwI4d-0008Fw-LG; Sun, 12 Dec 2021 06:11:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=87uesd3rwLvdcJ9Yc4ZYbSE6tb10FqLSgVzkL4YK534=; b=PsEAf/mypF7CQJH7Z9iVJkIi8h
	Sc8ORNXZIAY+l85TCdhT6esMlagOz9j0zvF8zU2sV0SjfNGDJnZJ5VI0+jYN8PrjqCOb89lok8QBu
	pL6LVnWlLcoGDxiJ2YhgLUUd6/eEDv7r4+w8XHIJ/5AYOOW4hF4YV532c8vB8aAotRd8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167380-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167380: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=bbdff6d583be718935b613ab2a966cddaadf661f
X-Osstest-Versions-That:
    linux=eccea80be2576dee642bc6cab20f1a242d58a08c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 12 Dec 2021 06:11:03 +0000

flight 167380 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167380/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     18 guest-localmigrate       fail REGR. vs. 167378

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167378
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167378
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167378
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167378
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167378
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167378
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167378
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167378
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                bbdff6d583be718935b613ab2a966cddaadf661f
baseline version:
 linux                eccea80be2576dee642bc6cab20f1a242d58a08c

Last test of basis   167378  2021-12-11 17:39:44 Z    0 days
Testing same since   167380  2021-12-11 23:40:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  German Gomez <german.gomez@arm.com>
  Jiri Olsa <jolsa@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Miaoqian Lin <linmq006@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   eccea80be257..bbdff6d583be  bbdff6d583be718935b613ab2a966cddaadf661f -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 08:03:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 08:03:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245581.423736 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwJoY-0003ux-O7; Sun, 12 Dec 2021 08:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245581.423736; Sun, 12 Dec 2021 08:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwJoY-0003up-Kq; Sun, 12 Dec 2021 08:02:34 +0000
Received: by outflank-mailman (input) for mailman id 245581;
 Sun, 12 Dec 2021 08:02:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwJoW-0003ub-KP; Sun, 12 Dec 2021 08:02:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwJoW-0007Vu-C3; Sun, 12 Dec 2021 08:02:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwJoW-000348-34; Sun, 12 Dec 2021 08:02:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwJoW-000167-2Z; Sun, 12 Dec 2021 08:02:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uiWwkykOZsm43DDkY8+Z+2ly6HMYEu88KmezFEGO9BQ=; b=rSrQl6rm1N3EULeR422qlB5OD+
	hoyMeH/fqlcSRhS24lwNVp2/PpMbFPsDWQosiq9uE3lq9gTIKjhhY84TENb1AChkaoyPhr6fGGGck
	2F//Z0iuJwdrWtWmPkzh4T2Zx0ur+nXSaMfG6ncEZi3TF5RT++t/ME399RTcdkpQtFGA=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167382-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167382: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 12 Dec 2021 08:02:32 +0000

flight 167382 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167382/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  520 days
Failing since        151818  2020-07-11 04:18:52 Z  519 days  501 attempts
Testing same since   167361  2021-12-11 04:18:51 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 88043 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 10:01:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 10:01:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245595.423750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwLfQ-0000Pk-Lr; Sun, 12 Dec 2021 10:01:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245595.423750; Sun, 12 Dec 2021 10:01:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwLfQ-0000Pd-Iq; Sun, 12 Dec 2021 10:01:16 +0000
Received: by outflank-mailman (input) for mailman id 245595;
 Sun, 12 Dec 2021 10:01:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwLfP-0000PT-52; Sun, 12 Dec 2021 10:01:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwLfO-00019k-TV; Sun, 12 Dec 2021 10:01:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwLfO-0008OS-LL; Sun, 12 Dec 2021 10:01:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwLfO-0004Rw-Kt; Sun, 12 Dec 2021 10:01:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GIWCIPB30GSO2ldgEnAtjJ0u4PW1LaS3a1jHOPMRBGY=; b=jVCWsDnoHZ8V3FKlgyXqzNBPGR
	R/KSJrv5LC8a8m5n3JCJJLJBPvQQYBIR5M5hlIJZIAucR01ra0X1s2AUSyxMuWVQl0VzoSgTradjb
	7EX44mfKmZnDeCmUeluZ7W+hVymghqFVZtzfeh2HW6vlN7DxJFuglF1T5U/pL5wlsohQ=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167384-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167384: all pass - PUSHED
X-Osstest-Versions-This:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
X-Osstest-Versions-That:
    xen=608531a0cc34a5bc096ccf585e16f182b5ed83e1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 12 Dec 2021 10:01:14 +0000

flight 167384 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167384/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2
baseline version:
 xen                  608531a0cc34a5bc096ccf585e16f182b5ed83e1

Last test of basis   167232  2021-12-08 09:18:32 Z    4 days
Testing same since   167384  2021-12-12 09:20:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Ian Jackson <iwj@xenproject.org>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   608531a0cc..df3e1a5efe  df3e1a5efe700a9f59eced801cac73f9fd02a0e2 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 11:40:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 11:40:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245618.423763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwNCh-0002Iz-Rv; Sun, 12 Dec 2021 11:39:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245618.423763; Sun, 12 Dec 2021 11:39:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwNCh-0002Is-P1; Sun, 12 Dec 2021 11:39:43 +0000
Received: by outflank-mailman (input) for mailman id 245618;
 Sun, 12 Dec 2021 11:39:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwNCg-0002Ii-3M; Sun, 12 Dec 2021 11:39:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwNCf-0002kf-R7; Sun, 12 Dec 2021 11:39:41 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwNCf-0002mr-E0; Sun, 12 Dec 2021 11:39:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwNCf-0007PF-D8; Sun, 12 Dec 2021 11:39:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zQXUjHazAFioweRQaZAv2ZbX0bIN/d8DmlXM/FqKC7M=; b=WqD60ZgJjfG5Mi4oFOUpmPx+9n
	sl+U4eRAfKKo9SbDuXMvRLwbaOyNMOBUxHk7ol1AXMdgC4Nbxn6UwlrqUfclL1nC068Z0uqe8Tgna
	IBsU7E8Xy777M/5RawwNTDuNDjB9JJ+jNQGKefM3ttLXVkmM994y6VqZKn+4J4lj2y4o=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167381-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167381: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 12 Dec 2021 11:39:41 +0000

flight 167381 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167381/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 167357

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167357
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167357
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167357
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167357
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167357
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167357
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167357
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167357
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167357
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167357
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167357
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167357
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167357
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167381  2021-12-12 01:53:00 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 13:51:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 13:51:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245632.423777 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwPGG-0000Nh-O5; Sun, 12 Dec 2021 13:51:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245632.423777; Sun, 12 Dec 2021 13:51:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwPGG-0000Na-LD; Sun, 12 Dec 2021 13:51:32 +0000
Received: by outflank-mailman (input) for mailman id 245632;
 Sun, 12 Dec 2021 13:51:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwPGF-0000NQ-GG; Sun, 12 Dec 2021 13:51:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwPGF-0004t4-A7; Sun, 12 Dec 2021 13:51:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwPGE-00060C-UR; Sun, 12 Dec 2021 13:51:31 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwPGE-0005P0-Tx; Sun, 12 Dec 2021 13:51:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3GpQpl/iNca4oiZIOQoz+wvHKg10A4l1hi4sw/OhDKY=; b=1VYDlGmy8vvQ6iLwJu5LjLs+vA
	YD0pU60YFKBT0ecc18kdsx28UkrfgNN+HajxJvg7q7qD02Bk9+ddVPj/e3QenOmFMg2ZrHR4/o+Q/
	9dz8o4RuoigQZIluNgOChETMfKp3vmyy2DRnOb8PXAZIOarg+ov0n+Q30fQoIc2dO66o=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167383-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167383: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a763d5a5abd65797aec3dd1bf01fe2ccbec32967
X-Osstest-Versions-That:
    linux=bbdff6d583be718935b613ab2a966cddaadf661f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 12 Dec 2021 13:51:30 +0000

flight 167383 linux-linus real [real]
flight 167385 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167383/
http://logs.test-lab.xenproject.org/osstest/logs/167385/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-credit1   8 xen-boot            fail pass in 167385-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10  fail blocked in 167380
 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 167385 never pass
 test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 167385 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167380
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167380
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167380
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167380
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167380
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167380
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167380
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167380
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                a763d5a5abd65797aec3dd1bf01fe2ccbec32967
baseline version:
 linux                bbdff6d583be718935b613ab2a966cddaadf661f

Last test of basis   167380  2021-12-11 23:40:28 Z    0 days
Testing same since   167383  2021-12-12 06:13:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Darrick J. Wong <djwong@kernel.org>
  Dennis Zhou <dennis@kernel.org>
  Igor Pylypiv <ipylypiv@google.com>
  Jack Wang <jinpu.wang@ionos.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Manish Rangankar <mrangankar@marvell.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Rich Felker <dalias@libc.org>
  Rob Landley <rob@landley.net>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Vladimir Murzin <vladimir.murzin@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   bbdff6d583be..a763d5a5abd6  a763d5a5abd65797aec3dd1bf01fe2ccbec32967 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245684.423792 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Q-0004Bm-Hn; Sun, 12 Dec 2021 21:03:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245684.423792; Sun, 12 Dec 2021 21:03:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Q-0004Bf-Eb; Sun, 12 Dec 2021 21:03:38 +0000
Received: by outflank-mailman (input) for mailman id 245684;
 Sun, 12 Dec 2021 21:03:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0O-0004BS-Ll
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:36 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f80bea00-5b8e-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:34 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id bi37so27479295lfb.5
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:34 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f80bea00-5b8e-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hjwuoJXbPZqya2Ql77uhrL181Upp/BNSFK3UGdZout4=;
        b=ZTR2gUvyc9Jk5H+625D+27T8YU6HUrFsdK+BZyYfXpdNoXxUtwpTyTDUwQwSoWyAeA
         QFmZHgZvzJL+TIWFKVztnITYG7r69wY54DReamkmJrNyC5F8V31YP9UAb7aS604CvcWC
         PpYufCxFX9cI9tGhmFev8cFbV2bIWnqyJ3SdeFqNZY07YSxk3vIjdtuuA8o/q/24/aii
         aobWphT0H7EQjwcoYgFJLbNeNvNuu0lmYffu98yb9vV5FJtExOgOE1T9n9aV4v6f/Z6B
         +Yc6S5rcBcvJ1Z1VB0qAHH/b2xLT7iNMzwo+545QUrJKoxXAoBFxsoFyCoGb5v5oQmAB
         Ozhw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=hjwuoJXbPZqya2Ql77uhrL181Upp/BNSFK3UGdZout4=;
        b=Jx1yWUHD6llR8bRRdSp6n98gBCKOopvtoLRKlncEeYlShMCAb5DYw63+K2dEEEAAvI
         apEUGMuOXSucasUwx0t9mQ0QmU+aHUY6PR7lLi+6dplXXUkRudhqzYnRUNXJ4aCE2M59
         AfPWaz+U3vLA7b9YUf/DIGQSL2vPoHlhEmQAvWXk32ILTypPW3i6HzIHBYQrNC/yjmzD
         6K+nPzFHQJSvlgQfQM+1Y8uRcSgtTNrp000brq7SR9sifpey9mimH1jlrrXhz41AhOQl
         iAs1k3yJJlGJ+Q6uDHVO/sNJhnqGV52HN9rIpbKIlTFS7WSdUt5aE24jsXTNkVWURBZ5
         az7A==
X-Gm-Message-State: AOAM530kFLZT0hlegG878FeCKpozaBd4FND/GzWR712QIdCReI4r+6Fs
	J6GREttsi8bt6hptoPpqvW8=
X-Google-Smtp-Source: ABdhPJzOMSp2mVNpJZWWIsHm+nM6vM9pY+/hpJjTOTmBtHA3G5sqnYRTvIv9wdStJAAqzYHraxEm1w==
X-Received: by 2002:a05:6512:1094:: with SMTP id j20mr24065288lfg.237.1639343014350;
        Sun, 12 Dec 2021 13:03:34 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 00/21] Introduce power-off+restart call chain API
Date: Mon, 13 Dec 2021 00:02:48 +0300
Message-Id: <20211212210309.9851-1-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem
-------

SoC devices require power-off call chaining functionality from kernel.
We have a widely used restart chaining provided by restart notifier API,
but nothing for power-off.

Solution
--------

Introduce new API that provides both restart and power-off call chains.

Why combine restart with power-off? Because drivers often do both.
More practical to have API that provides both under the same roof.

The new API is designed with simplicity and extensibility in mind.
It's built upon the existing restart and reboot APIs. The simplicity
is in new helper functions that are convenient for drivers. The
extensibility is in the design that doesn't hardcode callback
arguments, making easy to add new parameters and remove old.

This is a third attempt to introduce the new API. First was made by
Guenter Roeck back in 2014, second was made by Thierry Reding in 2017.
In fact the work didn't stop and recently arm_pm_restart() was removed
from v5.14 kernel, which was a part of preparatory work started by
Guenter Roeck. I took into account experience and ideas from the
previous attempts, extended and polished them.

Adoption plan
-------------

This patchset introduces the new API. It also converts multiple drivers
and arch code to the new API to demonstrate how it all looks in practice.

The plan is:

1. Merge new API (patches 1-8). This API will co-exist with the old APIs.

2. Convert arch code to do_kernel_power_off() (patches 9-21).

3. Convert drivers and platform code to the new API.

4. Remove obsolete pm_power_off and pm_power_off_prepare variables.

5. Make restart-notifier API private to kernel/reboot.c once no users left.

6. Make uniqueness of the handlers' priority a mandatory requirement.

It's fully implemented here:

[1] https://github.com/grate-driver/linux/commits/sys-off-handler

For now I'm sending only the first 25 base patches out of ~180. It's
preferable to squash 1-2, partially 3 and 4 points of the plan into a
single patchset to ease and speed up applying of the rest of the patches.
Majority of drivers and platform patches depend on the base, hence they
will come later (and per subsystem), once base will land.

All [1] patches are compile-tested. Tegra and x86 ACPI patches are tested
on hardware. The remaining should be covered by unit tests (unpublished).

Results
-------

1. Devices can be powered off properly.

2. Global variables are removed from drivers.

3. Global pm_power_off and pm_power_off_prepare callback variables are
removed once all users are converted to the new API. The latter callback
is removed by patch #25 of this series.

4. Ambiguous call chain ordering is prohibited. See patch #5 which adds
verification of restart handlers priorities, ensuring that they are unique.

Changelog:

v5: - Dropped patches which cleaned up notifier/reboot headers, as was
      requested by Rafael Wysocki.

    - Dropped WARN_ON() from the code, as was requested by Rafael Wysocki.
      Replaced it with pr_err() appropriately.

    - Dropped *_notifier_has_unique_priority() functions and added
      *_notifier_chain_register_unique_prio() instead, as was suggested
      by Michał Mirosław and Rafael Wysocki.

    - Dropped export of blocking_notifier_call_chain_is_empty() symbol,
      as was suggested by Rafael Wysocki.

    - Michał Mirosław suggested that will be better to split up patch
      that adds the new API to ease reviewing, but Rafael Wysocki asked
      not add more patches, so I kept it as a single patch.

    - Added temporary "weak" stub for pm_power_off() which fixes linkage
      failure once symbol is removed from arch/* code. Previously I missed
      this problem because was only compile-testing object files.

v4: - Made a very minor improvement to doc comments, clarifying couple
      default values.

    - Corrected list of emails recipient by adding Linus, Sebastian,
      Philipp and more NDS people. Removed bouncing emails.

    - Added acks that were given to v3.

v3: - Renamed power_handler to sys_off_handler as was suggested by
      Rafael Wysocki.

    - Improved doc-comments as was suggested by Rafael Wysocki. Added more
      doc-comments.

    - Implemented full set of 180 patches which convert whole kernel in
      accordance to the plan, see link [1] above. Slightly adjusted API to
      better suit for the remaining converted drivers.

      * Added unregister_sys_off_handler() that is handy for a couple old
        platform drivers.

      * Dropped devm_register_trivial_restart_handler(), 'simple' variant
        is enough to have.

    - Improved "Add atomic/blocking_notifier_has_unique_priority()" patch,
      as was suggested by Andy Shevchenko. Also replaced down_write() with
      down_read() and factored out common notifier_has_unique_priority().

    - Added stop_chain field to struct restart_data and reboot_prep_data
      after discovering couple drivers wanting that feature.

    - Added acks that were given to v2.

v2: - Replaced standalone power-off call chain demo-API with the combined
      power-off+restart API because this is what drivers want. It's a more
      comprehensive solution.

    - Converted multiple drivers and arch code to the new API. Suggested by
      Andy Shevchenko. I skimmed through the rest of drivers, verifying that
      new API suits them. The rest of the drivers will be converted once we
      will settle on the new API, otherwise will be too many patches here.

    - v2 API doesn't expose notifier to users and require handlers to
      have unique priority. Suggested by Guenter Roeck.

    - v2 API has power-off chaining disabled by default and require
      drivers to explicitly opt-in to the chaining. This preserves old
      behaviour for existing drivers once they are converted to the new
      API.

Dmitry Osipenko (21):
  notifier: Add blocking_notifier_call_chain_is_empty()
  notifier: Add atomic/blocking_notifier_chain_register_unique_prio()
  reboot: Print error message if restart handler has duplicated priority
  kernel: Add combined power-off+restart handler call chain API
  ARM: Use do_kernel_power_off()
  csky: Use do_kernel_power_off()
  riscv: Use do_kernel_power_off()
  arm64: Use do_kernel_power_off()
  parisc: Use do_kernel_power_off()
  xen/x86: Use do_kernel_power_off()
  powerpc: Use do_kernel_power_off()
  m68k: Switch to new sys-off handler API
  sh: Use do_kernel_power_off()
  x86: Use do_kernel_power_off()
  ia64: Use do_kernel_power_off()
  mips: Use do_kernel_power_off()
  nds32: Use do_kernel_power_off()
  memory: emif: Use kernel_can_power_off()
  ACPI: power: Switch to sys-off handler API
  regulator: pfuze100: Use devm_register_sys_off_handler()
  reboot: Remove pm_power_off_prepare()

 arch/arm/kernel/reboot.c               |   4 +-
 arch/arm64/kernel/process.c            |   3 +-
 arch/csky/kernel/power.c               |   6 +-
 arch/ia64/kernel/process.c             |   4 +-
 arch/m68k/emu/natfeat.c                |   3 +-
 arch/m68k/include/asm/machdep.h        |   1 -
 arch/m68k/kernel/process.c             |   5 +-
 arch/m68k/kernel/setup_mm.c            |   1 -
 arch/m68k/kernel/setup_no.c            |   1 -
 arch/m68k/mac/config.c                 |   4 +-
 arch/mips/kernel/reset.c               |   3 +-
 arch/nds32/kernel/process.c            |   3 +-
 arch/parisc/kernel/process.c           |   4 +-
 arch/powerpc/kernel/setup-common.c     |   4 +-
 arch/powerpc/xmon/xmon.c               |   3 +-
 arch/riscv/kernel/reset.c              |  12 +-
 arch/sh/kernel/reboot.c                |   3 +-
 arch/x86/kernel/reboot.c               |   4 +-
 arch/x86/xen/enlighten_pv.c            |   4 +-
 drivers/acpi/sleep.c                   |  25 +-
 drivers/memory/emif.c                  |   2 +-
 drivers/regulator/pfuze100-regulator.c |  38 +-
 include/linux/notifier.h               |   7 +
 include/linux/pm.h                     |   1 -
 include/linux/reboot.h                 | 265 +++++++++++-
 kernel/notifier.c                      | 100 ++++-
 kernel/power/hibernate.c               |   2 +-
 kernel/reboot.c                        | 574 ++++++++++++++++++++++++-
 28 files changed, 968 insertions(+), 118 deletions(-)

-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245689.423842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Z-0005SP-Fe; Sun, 12 Dec 2021 21:03:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245689.423842; Sun, 12 Dec 2021 21:03:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Z-0005PK-AQ; Sun, 12 Dec 2021 21:03:47 +0000
Received: by outflank-mailman (input) for mailman id 245689;
 Sun, 12 Dec 2021 21:03:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0Y-0004MP-0g
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:46 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fe17b737-5b8e-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:45 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id bi37so27479674lfb.5
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:45 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:44 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fe17b737-5b8e-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4G0wXMIRKtQjgiQjhPPTWIJTonbxBMvj833mzQfGVdU=;
        b=UmHNBT8JmdhQ5CXOuzBPrdCFUG3onvjKjyb7BVoTR6PoZ7aY9ImgmoLFJ8cX/YVLss
         FhaRpMyx6UDbgZbpErI6LiS2MWo9dsEpm/Yn/glHgDMltg46AqIFy+ODbJy1mDGnSX6Q
         6hgBQWxhgUXb1w4suJJ3mGjbzzVU8sboZDIyHdE0at2JpjfcocKdBr+3u8eWls6ZdqdV
         vZ4mrsRkvMQH9goBfcYfawa9rTT2nVXUK1e0dhFRpy7O9dgcCyJsMwyOMgChqmTkAYY8
         lrO8FmVaBVXU/jCI9v95z8kMIgVRbHZl7Dj+Y9SNeeNladuYqhNnhCKP7pmJssTLe+hK
         /zfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4G0wXMIRKtQjgiQjhPPTWIJTonbxBMvj833mzQfGVdU=;
        b=ZMPsYMnKcChiRVdUxATpin9ASu7aM3t19PsS+I+5dq8CNdWy8WXjSd5j70oeV1i9X1
         i5m4r//uhuD1CGk6tC5huzOIz0CrS2VyH/IvgnbDgXP9VpcWneaE5m2CVfSkxlyNAGuG
         VS4MoDYTqnTAndgJ1lE28DpHqbNfV3HBi7/TIR+NR6/ly0qV57D0QfnXTHNer0pQ7Hbn
         JvIFhX4gi5vdZWYNzXmf+suJWzRmSZjKid9mhFm5queOReFBqthkIrXflvEQ7N6Cnhmy
         WUecoY/llZhPD42OJxhx+hg6cUe+5QSV3Nf+j++qC/DwtQ3ru0pVpUuaniuVC/k37Y1S
         QHtw==
X-Gm-Message-State: AOAM533wOv9yrzvQy9ZiMamx/Khlm9IR66FXennYVIDB8sjXpieKP/wi
	vcAZOVGjcbPpflUXR8YAjAQ=
X-Google-Smtp-Source: ABdhPJxFbn2GY3BCcnuEIOE5ToL9Wd42NcsVPvWkJ7LxAK1mty5nUWabwI1BhIkHNdC7U+LYga5X9w==
X-Received: by 2002:a05:6512:3f6:: with SMTP id n22mr19160482lfq.501.1639343024602;
        Sun, 12 Dec 2021 13:03:44 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 05/21] ARM: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:53 +0300
Message-Id: <20211212210309.9851-6-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/kernel/reboot.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 3044fcb8d073..2cb943422554 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -116,9 +116,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245690.423858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0b-0005vT-QW; Sun, 12 Dec 2021 21:03:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245690.423858; Sun, 12 Dec 2021 21:03:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0b-0005vB-Mg; Sun, 12 Dec 2021 21:03:49 +0000
Received: by outflank-mailman (input) for mailman id 245690;
 Sun, 12 Dec 2021 21:03:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0Z-0004BS-Mp
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:47 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff3e195b-5b8e-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:47 +0100 (CET)
Received: by mail-lj1-x22d.google.com with SMTP id u22so21070641lju.7
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:47 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.44
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:46 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff3e195b-5b8e-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=WLlXRmIj/zMVA0EiitKjc0V06oQPoMgvuV0WtFcoWEk=;
        b=Z9frmqTKg5aoS2PU9i7y55F1Fktg58Vk2dW1KbQjX3M9u/eaFeNaZynJ32r52oBsf/
         P9f28j0C1WiUodwIjr6XbJsThvC5MCwPgOI/+5M/0VrXYfVzLWQeaRXWUSfPZb+I2BSI
         BQPFKoBwRVjbyBL2TND78RdUJQyDLS7Pkm0fODoqLqGIlWJGn8+AfpkS3xhzwQqXsYu+
         5Y85pgu/pjYqmqy25ZvgQq8EW9Jv0u/pC5H+pGq+qKilGUXE9mzv0sr4iNh3LtrbFN9z
         ktmDNa2rZciKvQCLgGh4sd5oSXRV7GuSIk+wrmiOWBZtTjqy61YULWuD5yCzVtaU2XTm
         +s7w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=WLlXRmIj/zMVA0EiitKjc0V06oQPoMgvuV0WtFcoWEk=;
        b=6VY30nqwbk8dGT/cz7tEzVM4rPSSdMyXcMRxF9DiIVvOOOYw+yDa91m0DswWVnU4Cr
         TMy/uTUJHZAn6kfZsX5i8Ba/X0vQPnlJeDTLXSzYhpjI7btygaYPnxskYA+JWioCMTKK
         ULRZ2COqGvItE3cDMgZBXNHcaJnEqY75EN98lWcf5bXciz461zGwwXbYuBk+bBktcS+X
         SaJ+++xoeRa23tS7xZWL7fRImfeqW00SFDffqOKSefiYeJWDc/mjnyROq6FG5asWhtZg
         XDny/wazwD4oSVXymJ16mXjKabSlX8Czn4mLHbnjSpUJ+kgrrwsAGSL8HVX7U03x0XIg
         Fa4w==
X-Gm-Message-State: AOAM533Lto77tVUXtnmXfLIz8HuOa1Qx9C/IfI7l3n5mESiwZ9l7KGLh
	JQhKdn/WPf3obTZJUl6NC+Y=
X-Google-Smtp-Source: ABdhPJyn4bB+L+dbSeB8tkaNaTLuP+spDExh0AO3PYQ44Uwwg2wXZuKvjQXzPiXg+PdVnR/cyixvqQ==
X-Received: by 2002:a2e:9dcf:: with SMTP id x15mr26933582ljj.432.1639343026612;
        Sun, 12 Dec 2021 13:03:46 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 06/21] csky: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:54 +0300
Message-Id: <20211212210309.9851-7-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Guo Ren <guoren@kernel.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/csky/kernel/power.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c
index 923ee4e381b8..86ee202906f8 100644
--- a/arch/csky/kernel/power.c
+++ b/arch/csky/kernel/power.c
@@ -9,16 +9,14 @@ EXPORT_SYMBOL(pm_power_off);
 void machine_power_off(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
 void machine_halt(void)
 {
 	local_irq_disable();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	asm volatile ("bkpt");
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245687.423825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0V-0004z2-Gd; Sun, 12 Dec 2021 21:03:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245687.423825; Sun, 12 Dec 2021 21:03:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0V-0004yt-DV; Sun, 12 Dec 2021 21:03:43 +0000
Received: by outflank-mailman (input) for mailman id 245687;
 Sun, 12 Dec 2021 21:03:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0T-0004BS-B7
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:41 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb8ff8de-5b8e-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:40 +0100 (CET)
Received: by mail-lj1-x232.google.com with SMTP id i63so21125104lji.3
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:40 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb8ff8de-5b8e-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=SiVmxmlmX7gD18KWJKuTaPa7pNX7A6+5Wut7BQEWlWA=;
        b=qyaqAU+HSKD+HsUBKg5AB4Grj9JsCbr9g/kNEIZtJUYDPkR5w7X3oEBoqbhkveHPA0
         i7WuMCFDqVmy4v4uwmxmKqJQgyKWbZxAuezUxU7vJ7Js6Vv9mGU7AXWM79sgkKDLmhWK
         jFp8UPoUTDTrVPMbjiOZPw0kaHhZEow7vk98bEAvorv4PN2Ae1WrpFauYpbNmt6sURPu
         EHsFzc94IQPacNeM0GpGjXTCkggEJqqfF6pqgsflI/TGqDXRSOm8kaL/erYImjVTvQQe
         TKd1cdir2wKhwb/5hDwmkKqbCAzORiU/FXU4xaDIEAT35buQchr71urUuURu0JjCKmA+
         4E2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=SiVmxmlmX7gD18KWJKuTaPa7pNX7A6+5Wut7BQEWlWA=;
        b=A+Kj8svMQxNEGnEJSVZ9HSMEvBT1g4ryfbHLM/fllXW5MRzcjDJpCD20lIC9HQsdUt
         XZ7nD8HgCCs0dwnCEZlY1uxKlxxvtHiSKiY7q5ITJ4Ikf1BZuNIEi74Y1teMB/OvlCe3
         Pyy+q1wD5pamZzGnEjhmSkmbDWbcjYtaM7l4g3jXEQ1vWfAPKpMGcVDRD4nqLMsFNO+s
         dWWvwdegiifdM/fQCbJTSg/kCo4oTSna0joIcLUn6fVS+IX3BVyDgXUEOLt9cyLGw3uC
         xXg8N2/+Q1zaGOebomIIu8wWnvJObwENFR20HejxjqV0ZOXbedBRhVy+wKZvODLK+pOX
         MXHA==
X-Gm-Message-State: AOAM531ewvfvnFlwo+JmHu2IDnNAJukW7VUGBKc1d7BByrFniml8r28c
	yAOyNZULoN4+GM2BflnzFsU=
X-Google-Smtp-Source: ABdhPJzPB5bwYAfFOn1aDytHDcrWq16AdXdyLAU7ztJCQFx3xpkh7jhCINcDSwIbtlftQmSbgta8Pw==
X-Received: by 2002:a2e:9903:: with SMTP id v3mr25528327lji.143.1639343020440;
        Sun, 12 Dec 2021 13:03:40 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 03/21] reboot: Print error message if restart handler has duplicated priority
Date: Mon, 13 Dec 2021 00:02:51 +0300
Message-Id: <20211212210309.9851-4-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add sanity check which ensures that there are no two restart handlers
registered using the same priority. This requirement will become mandatory
once all drivers will be converted to the new API and such errors will be
fixed.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 kernel/reboot.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/kernel/reboot.c b/kernel/reboot.c
index 6bcc5d6a6572..35f0cde641c1 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -182,6 +182,21 @@ static ATOMIC_NOTIFIER_HEAD(restart_handler_list);
  */
 int register_restart_handler(struct notifier_block *nb)
 {
+	int ret;
+
+	ret = atomic_notifier_chain_register_unique_prio(&restart_handler_list, nb);
+	if (ret != -EBUSY)
+		return ret;
+
+	/*
+	 * Handler must have unique priority. Otherwise call order is
+	 * determined by registration order, which is unreliable.
+	 *
+	 * This requirement will become mandatory once all drivers
+	 * will be converted to use new sys-off API.
+	 */
+	pr_err("failed to register restart handler using unique priority\n");
+
 	return atomic_notifier_chain_register(&restart_handler_list, nb);
 }
 EXPORT_SYMBOL(register_restart_handler);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245686.423809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0T-0004VN-Ar; Sun, 12 Dec 2021 21:03:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245686.423809; Sun, 12 Dec 2021 21:03:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0T-0004Uc-3G; Sun, 12 Dec 2021 21:03:41 +0000
Received: by outflank-mailman (input) for mailman id 245686;
 Sun, 12 Dec 2021 21:03:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0R-0004MP-Sa
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:39 +0000
Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com
 [2a00:1450:4864:20::22f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f956a778-5b8e-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:38 +0100 (CET)
Received: by mail-lj1-x22f.google.com with SMTP id i63so21124975lji.3
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:36 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f956a778-5b8e-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=n3cwwyKh/hwErnoFuV8i3YcIMR9FHZoMKEZSbOKAmdY=;
        b=Ex8lL4mdgUiRHYGoAXofDELzYU2M39Rf62MPEL6+NwhL4DG7f7g8blGnth50zzv9nv
         XtgwZ9AQGnJnLqVio+QWKRb0Z2UFZU13/SlOZ6knhCS8nzv79jUJrhvhvCtb6xbOGhRe
         QCo64//4R6yL9xhgOYc3zcYTNZnDzQezIWCwpso0yHMq6Gqm01cbjFNzL9wdR1IpObJX
         QNX5u0vTw2iIw9GwynLoMaZBVQkfGVwbmM4effBPRqVI72+jfv9/MdqbIDB9jPZ8pJzw
         hYqD/Yu8obJVLM9NSCzZb3jXy2mxfU4mU/jDrUalTCSK4fBVmU6wUB9oiNX1E5nzJKlr
         /TtA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=n3cwwyKh/hwErnoFuV8i3YcIMR9FHZoMKEZSbOKAmdY=;
        b=PzzL4a+a8RVWwOQjJQQpG+yCe0Gl6BNKbRHf+/bF4fKGbyYI+aDo8CkgkEKPBhqIWX
         EMTp75Z/bJYAJb47ga6/rpMasbjU3P9/JALLs0jBmQL77ECGsAAUeRMpPUUBMwlL9gpG
         Y0ShUkJrbZgpg50kai3yJJ65/C1Lau6CFCoBlngyJzBkTnycjrl/KVcqC5lkTZBjWKuY
         CnFFyFjQAzdvdeBn63NGyx55la99MPBTcWvyTcaxe+fT8aKpF3WaDF5zgdCVf1IT5hru
         AERyZ2FOIMk8lipbJHYbgO14nZ/MJAleRpCCP+zNHmOSud5zxxWOcNRsFmBiwCjEQdDT
         AFrQ==
X-Gm-Message-State: AOAM532yjwT0M7NK2tGEShLS28V3omtlUYawjCcsfaOo22dayBJUQG7m
	88RHuQOzBAsJ9+NEkMzSKS8=
X-Google-Smtp-Source: ABdhPJyVUXR8xADdHsxaMm4O/Lfphg0rT3u//x42eqt+aVA8OPTC8ytA0fee16pgBcrKP9uKJF2ykQ==
X-Received: by 2002:a05:651c:514:: with SMTP id o20mr26693103ljp.393.1639343016405;
        Sun, 12 Dec 2021 13:03:36 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 01/21] notifier: Add blocking_notifier_call_chain_is_empty()
Date: Mon, 13 Dec 2021 00:02:49 +0300
Message-Id: <20211212210309.9851-2-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add blocking_notifier_call_chain_is_empty() that returns true if call
chain is empty.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/notifier.h |  2 ++
 kernel/notifier.c        | 13 +++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index 87069b8459af..d4717bc0ab85 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -173,6 +173,8 @@ extern int blocking_notifier_call_chain_robust(struct blocking_notifier_head *nh
 extern int raw_notifier_call_chain_robust(struct raw_notifier_head *nh,
 		unsigned long val_up, unsigned long val_down, void *v);
 
+extern bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh);
+
 #define NOTIFY_DONE		0x0000		/* Don't care */
 #define NOTIFY_OK		0x0001		/* Suits me */
 #define NOTIFY_STOP_MASK	0x8000		/* Don't call further */
diff --git a/kernel/notifier.c b/kernel/notifier.c
index b8251dc0bc0f..e30d24ee88e9 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -322,6 +322,19 @@ int blocking_notifier_call_chain(struct blocking_notifier_head *nh,
 }
 EXPORT_SYMBOL_GPL(blocking_notifier_call_chain);
 
+/**
+ *	blocking_notifier_call_chain_is_empty - Check whether notifier chain is empty
+ *	@nh: Pointer to head of the blocking notifier chain
+ *
+ *	Checks whether notifier chain is empty.
+ *
+ *	Returns true is notifier chain is empty, false otherwise.
+ */
+bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
+{
+	return !rcu_access_pointer(nh->head);
+}
+
 /*
  *	Raw notifier chain routines.  There is no protection;
  *	the caller must provide it.  Use at your own risk!
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245688.423837 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Y-0005JM-Uf; Sun, 12 Dec 2021 21:03:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245688.423837; Sun, 12 Dec 2021 21:03:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0Y-0005JB-NS; Sun, 12 Dec 2021 21:03:46 +0000
Received: by outflank-mailman (input) for mailman id 245688;
 Sun, 12 Dec 2021 21:03:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0X-0004MP-0C
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:45 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fd24a9c6-5b8e-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:43 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id m12so21122597ljj.6
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:43 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:42 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fd24a9c6-5b8e-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=QaJ/7qszLPEY+beo4CxylD+wE2a5oMODuqLEZ/O4D0M=;
        b=Crx6wDN+0vpxSLjzyjDy3S17n1SvpIL+jtEI4xEpTUXKWy5nj7dAjGUwZ8oVGLKol2
         gy67o7q5QvJpYyko9thpNQivbubJ3ZsBAO33JCauzbd5Gkq4wQwArQJ/7wyeLqgJ5Zj0
         icd6G56b7Cq6k89Wj2irCulSyafRkOg/4B8oHAVFt8cjt7aq1UPMul36Fe8l28tbZEIX
         rqusi2YqLj/tO4XxpG1zyRMwvLeZNa2k0rPxRpAjgVy6LeZpQVj7hmZcFVCrJcbSJ72y
         tthxZQevFVg88k0XBO6KvtvTG5LzzNWYZzgywRqNLi1R8NGnIbcrIsR1AVMB/egI5oGd
         PrqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=QaJ/7qszLPEY+beo4CxylD+wE2a5oMODuqLEZ/O4D0M=;
        b=5ByKhCNKT61KwEQiTjcahA4qW6H20OPX1cqmdOdr8tAmGj0kdSqVNruiJQzsNZyn2K
         JH6zhkStm7ZGronUYs67ye71sk1xvG3y3wZcn1bI5hbKWb3zsGC6EZIK0VP9/NY5YVU/
         Mhd3G/0DqPozOpLVO+pcxUGz0ydXWXPOmQ31W5+FY/66C5wy9Om0qXkoy0kihxxBNnlJ
         BTB1mL6ZbOAz7WdzdcwvyaQxIkR1gNh+1tPq3AjqCxlCdrMdEV1jAAyDFINUMRrnzde1
         LxTrTwc69VPJMWDaZFB7wl+uoRZP2eTpV5O15I+Y9m9943U/YST4KHYGquXDIT9+9g6g
         s28w==
X-Gm-Message-State: AOAM530i8+FPJh2q+0qc1/klzdjiEfpNOLdSatohGQQ10PtGks0r/YAC
	VfZykNbvSicjmodOg+tJRJw=
X-Google-Smtp-Source: ABdhPJzRB700Ad2OFWbDxEi2WjXylbQ6RiXgitc2Lkmm2CHoFoG9aZ5KVOnO1fHBkqp/Z5WMiA5jfQ==
X-Received: by 2002:a2e:b545:: with SMTP id a5mr24922900ljn.510.1639343022629;
        Sun, 12 Dec 2021 13:03:42 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 04/21] kernel: Add combined power-off+restart handler call chain API
Date: Mon, 13 Dec 2021 00:02:52 +0300
Message-Id: <20211212210309.9851-5-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

SoC platforms often have multiple ways of how to perform system's
power-off and restart operations. Meanwhile today's kernel is limited to
a single option. Add combined power-off+restart handler call chain API,
which is inspired by the restart API. The new API provides both power-off
and restart functionality.

The old pm_power_off method will be kept around till all users are
converted to the new API.

Current restart API will be replaced by the new unified API since
new API is its superset. The restart functionality of the sys-off handler
API is built upon the existing restart-notifier APIs.

In order to ease conversion to the new API, convenient helpers are added
for the common use-cases. They will reduce amount of boilerplate code and
remove global variables. These helpers preserve old behaviour for cases
where only one power-off handler is expected, this is what all existing
drivers want, and thus, they could be easily converted to the new API.
Users of the new API should explicitly enable power-off chaining by
setting corresponding flag of the power_handler structure.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/reboot.h   | 265 ++++++++++++++++++-
 kernel/power/hibernate.c |   2 +-
 kernel/reboot.c          | 556 ++++++++++++++++++++++++++++++++++++++-
 3 files changed, 815 insertions(+), 8 deletions(-)

diff --git a/include/linux/reboot.h b/include/linux/reboot.h
index af907a3d68d1..c2fa8d63c129 100644
--- a/include/linux/reboot.h
+++ b/include/linux/reboot.h
@@ -8,10 +8,35 @@
 
 struct device;
 
-#define SYS_DOWN	0x0001	/* Notify of system down */
-#define SYS_RESTART	SYS_DOWN
-#define SYS_HALT	0x0002	/* Notify of system halt */
-#define SYS_POWER_OFF	0x0003	/* Notify of system power off */
+enum reboot_prepare_mode {
+	SYS_DOWN = 1,		/* Notify of system down */
+	SYS_RESTART = SYS_DOWN,
+	SYS_HALT,		/* Notify of system halt */
+	SYS_POWER_OFF,		/* Notify of system power off */
+};
+
+/*
+ * Standard restart priority levels. Intended to be set in the
+ * sys_off_handler.restart_priority field.
+ *
+ * Use `RESTART_PRIO_ABC +- prio` style for additional levels.
+ *
+ * RESTART_PRIO_RESERVED:	Falls back to RESTART_PRIO_DEFAULT.
+ *				Drivers may leave priority initialized
+ *				to zero, to auto-set it to the default level.
+ *
+ * RESTART_PRIO_LOW:		Use this for handler of last resort.
+ *
+ * RESTART_PRIO_DEFAULT:	Use this for default/generic handler.
+ *
+ * RESTART_PRIO_HIGH:		Use this if you have multiple handlers and
+ *				this handler has higher priority than the
+ *				default handler.
+ */
+#define RESTART_PRIO_RESERVED		0
+#define RESTART_PRIO_LOW		8
+#define RESTART_PRIO_DEFAULT		128
+#define RESTART_PRIO_HIGH		192
 
 enum reboot_mode {
 	REBOOT_UNDEFINED = -1,
@@ -49,6 +74,237 @@ extern int register_restart_handler(struct notifier_block *);
 extern int unregister_restart_handler(struct notifier_block *);
 extern void do_kernel_restart(char *cmd);
 
+/*
+ * System power-off and restart API.
+ */
+
+/*
+ * Standard power-off priority levels. Intended to be set in the
+ * sys_off_handler.power_off_priority field.
+ *
+ * Use `POWEROFF_PRIO_ABC +- prio` style for additional levels.
+ *
+ * POWEROFF_PRIO_RESERVED:	Falls back to POWEROFF_PRIO_DEFAULT.
+ *				Drivers may leave priority initialized
+ *				to zero, to auto-set it to the default level.
+ *
+ * POWEROFF_PRIO_PLATFORM:	Intended to be used by platform-level handler.
+ *				Has lowest priority since device drivers are
+ *				expected to take over platform handler which
+ *				doesn't allow further callback chaining.
+ *
+ * POWEROFF_PRIO_DEFAULT:	Use this for default/generic handler.
+ *
+ * POWEROFF_PRIO_FIRMWARE:	Use this if handler uses firmware call.
+ *				Has highest priority since firmware is expected
+ *				to know best how to power-off hardware properly.
+ */
+#define POWEROFF_PRIO_RESERVED		0
+#define POWEROFF_PRIO_PLATFORM		1
+#define POWEROFF_PRIO_DEFAULT		128
+#define POWEROFF_PRIO_HIGH		192
+#define POWEROFF_PRIO_FIRMWARE		224
+
+enum poweroff_mode {
+	POWEROFF_NORMAL = 0,
+	POWEROFF_PREPARE,
+};
+
+/**
+ * struct power_off_data - Power-off callback argument
+ *
+ * @cb_data: Callback data.
+ */
+struct power_off_data {
+	void *cb_data;
+};
+
+/**
+ * struct power_off_prep_data - Power-off preparation callback argument
+ *
+ * @cb_data: Callback data.
+ */
+struct power_off_prep_data {
+	void *cb_data;
+};
+
+/**
+ * struct restart_data - Restart callback argument
+ *
+ * @cb_data: Callback data.
+ * @cmd: Restart command string.
+ * @stop_chain: Further lower priority callbacks won't be executed if set to
+ *		true. Can be changed within callback. Default is false.
+ * @mode: Reboot mode ID.
+ */
+struct restart_data {
+	void *cb_data;
+	const char *cmd;
+	bool stop_chain;
+	enum reboot_mode mode;
+};
+
+/**
+ * struct reboot_prep_data - Reboot and shutdown preparation callback argument
+ *
+ * @cb_data: Callback data.
+ * @cmd: Restart command string.
+ * @stop_chain: Further lower priority callbacks won't be executed if set to
+ *		true. Can be changed within callback. Default is false.
+ * @mode: Preparation mode ID.
+ */
+struct reboot_prep_data {
+	void *cb_data;
+	const char *cmd;
+	bool stop_chain;
+	enum reboot_prepare_mode mode;
+};
+
+struct sys_off_handler_private_data {
+	struct notifier_block power_off_nb;
+	struct notifier_block restart_nb;
+	struct notifier_block reboot_nb;
+	void (*platform_power_off_cb)(void);
+	void (*simple_power_off_cb)(void *data);
+	void *simple_power_off_cb_data;
+	bool registered;
+};
+
+/**
+ * struct sys_off_handler - System power-off and restart handler
+ *
+ * @cb_data: Pointer to user's data.
+ *
+ * @power_off_cb: Callback that powers off this machine. Inactive if NULL.
+ *
+ * @power_off_prepare_cb: Power-off preparation callback. All power-off
+ * preparation callbacks are invoked after @reboot_prepare_cb and before
+ * @power_off_cb. Inactive if NULL.
+ *
+ * @power_off_priority: Power-off callback priority, must be unique.
+ * Zero value is reserved and auto-reassigned to POWEROFF_PRIO_DEFAULT.
+ * Inactive if @power_off_cb is NULL.
+ *
+ * @power_off_chaining_allowed: Set to false if callback's execution should
+ * stop when @power_off_cb fails to power off this machine. True if further
+ * lower priority power-off callback should be executed. False is default
+ * value.
+ *
+ * @restart_cb: Callback that reboots this machine. Inactive if NULL.
+ *
+ * @restart_priority: Restart callback priority, must be unique. Zero value
+ * is reserved and auto-reassigned to RESTART_PRIO_DEFAULT. Inactive if
+ * @restart_cb is NULL.
+ *
+ * @restart_chaining_disallowed: Set to true if callback's execution should
+ * stop when @restart_cb fails to restart this machine. False if further
+ * lower priority restart callback should be executed. False is default
+ * value.
+ *
+ * @reboot_prepare_cb: Reboot/shutdown preparation callback. All reboot
+ * preparation callbacks are invoked before @restart_cb or @power_off_cb,
+ * depending on the mode. It's registered with register_reboot_notifier().
+ * The point is to remove boilerplate code from drivers which use this
+ * callback in conjunction with the restart/power-off callbacks.
+ *
+ * @reboot_priority: Reboot/shutdown preparation callback priority, doesn't
+ * need to be unique. Zero is default value. Inactive if @reboot_prepare_cb
+ * is NULL.
+ *
+ * @priv: Internal data. Shouldn't be touched.
+ *
+ * Describes power-off and restart handlers which are invoked by kernel
+ * to power off or restart this machine. Supports prioritized chaining for
+ * both restart and power-off handlers.
+ *
+ * Struct sys_off_handler can be static. Members of this structure must not be
+ * altered while handler is registered.
+ *
+ * Fill the structure members and pass it to @register_sys_off_handler().
+ */
+struct sys_off_handler {
+	void *cb_data;
+
+	void (*power_off_cb)(struct power_off_data *data);
+	void (*power_off_prepare_cb)(struct power_off_prep_data *data);
+	int power_off_priority;
+	bool power_off_chaining_allowed;
+
+	void (*restart_cb)(struct restart_data *data);
+	int restart_priority;
+	bool restart_chaining_disallowed;
+
+	void (*reboot_prepare_cb)(struct reboot_prep_data *data);
+	int reboot_priority;
+
+	const struct sys_off_handler_private_data priv;
+};
+
+int register_sys_off_handler(struct sys_off_handler *handler);
+int unregister_sys_off_handler(struct sys_off_handler *handler);
+
+int devm_register_sys_off_handler(struct device *dev,
+				  struct sys_off_handler *handler);
+
+int devm_register_prioritized_power_off_handler(struct device *dev,
+						int priority,
+						void (*callback)(void *data),
+						void *cb_data);
+
+/**
+ *	devm_register_simple_power_off_handler - Register simple power-off callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed power-off callback with default priority.
+ *	It will be invoked as last step of the power-off sequence. Further
+ *	lower priority callbacks won't be executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+static inline int
+devm_register_simple_power_off_handler(struct device *dev,
+				       void (*callback)(void *data),
+				       void *cb_data)
+{
+	return devm_register_prioritized_power_off_handler(dev,
+							   POWEROFF_PRIO_DEFAULT,
+							   callback, cb_data);
+}
+
+int register_platform_power_off(void (*power_off)(void));
+int unregister_platform_power_off(void (*power_off)(void));
+
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *cb_data);
+
+/**
+ *	devm_register_simple_restart_handler - Register simple restart callback
+ *	@dev: Device that registers callback
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with default priority.
+ *	It will be invoked as a part of the restart sequence. Further
+ *	lower priority callback will be executed if this @callback fails.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+static inline int
+devm_register_simple_restart_handler(struct device *dev,
+				     void (*callback)(struct restart_data *data),
+				     void *cb_data)
+{
+	return devm_register_prioritized_restart_handler(dev,
+							 RESTART_PRIO_DEFAULT,
+							 callback, cb_data);
+}
+
+void do_kernel_power_off(void);
+
 /*
  * Architecture-specific implementations of sys_reboot commands.
  */
@@ -70,6 +326,7 @@ extern void kernel_restart_prepare(char *cmd);
 extern void kernel_restart(char *cmd);
 extern void kernel_halt(void);
 extern void kernel_power_off(void);
+extern bool kernel_can_power_off(void);
 
 extern int C_A_D; /* for sysctl */
 void ctrl_alt_del(void);
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index e6af502c2fd7..aebbdd757fb9 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -666,7 +666,7 @@ static void power_down(void)
 		hibernation_platform_enter();
 		fallthrough;
 	case HIBERNATION_SHUTDOWN:
-		if (pm_power_off)
+		if (kernel_can_power_off())
 			kernel_power_off();
 		break;
 	}
diff --git a/kernel/reboot.c b/kernel/reboot.c
index 35f0cde641c1..3085873a876f 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -296,6 +296,547 @@ void kernel_halt(void)
 }
 EXPORT_SYMBOL_GPL(kernel_halt);
 
+/*
+ *	Notifier list for kernel code which wants to be called
+ *	to power off the system.
+ */
+static BLOCKING_NOTIFIER_HEAD(power_off_handler_list);
+
+/*
+ * Temporary stub that prevents linkage failure while we're in process
+ * of removing all uses of legacy pm_power_off() around the kernel.
+ */
+void __weak (*pm_power_off)(void);
+
+static void dummy_pm_power_off(void)
+{
+	/* temporary stub until pm_power_off() is gone, see more below */
+}
+
+static struct notifier_block *pm_power_off_nb;
+
+/**
+ *	register_power_off_handler - Register function to be called to power off
+ *				     the system
+ *	@nb: Info about handler function to be called
+ *	@nb->priority:	Handler priority. Handlers should follow the
+ *			following guidelines for setting priorities.
+ *			0:	Reserved
+ *			1:	Power-off handler of last resort,
+ *				with limited power-off capabilities
+ *			128:	Default power-off handler; use if no other
+ *				power-off handler is expected to be available,
+ *				and/or if power-off functionality is
+ *				sufficient to power-off the entire system
+ *			255:	Highest priority power-off handler, will
+ *				preempt all other power-off handlers
+ *
+ *	Registers a function with code to be called to power off the
+ *	system.
+ *
+ *	Registered functions will be called as last step of the power-off
+ *	sequence.
+ *
+ *	Registered functions are expected to power off the system immediately.
+ *	If more than one function is registered, the power-off handler priority
+ *	selects which function will be called first.
+ *
+ *	Power-off handlers are expected to be registered from non-architecture
+ *	code, typically from drivers. A typical use case would be a system
+ *	where power-off functionality is provided through a PMIC. Multiple
+ *	power-off handlers may exist; for example, one power-off handler might
+ *	turn off the entire system, while another only turns off part of
+ *	system. In such cases, the power-off handler which only disables part
+ *	of the hardware is expected to register with low priority to ensure
+ *	that it only runs if no other means to power off the system is
+ *	available.
+ *
+ *	Currently always returns zero, as blocking_notifier_chain_register()
+ *	always returns zero.
+ */
+static int register_power_off_handler(struct notifier_block *nb)
+{
+	int ret;
+
+	ret = blocking_notifier_chain_register_unique_prio(&power_off_handler_list, nb);
+	if (ret && ret != -EBUSY)
+		return ret;
+
+	if (!ret)
+		goto set_pm_power_off;
+
+	/*
+	 * Handler must have unique priority. Otherwise call order is
+	 * determined by registration order, which is unreliable.
+	 *
+	 * This requirement will become mandatory once all drivers
+	 * will be converted to use new sys-off API.
+	 */
+	pr_err("failed to register power-off handler using unique priority\n");
+
+	ret = blocking_notifier_chain_register(&power_off_handler_list, nb);
+	if (ret)
+		return ret;
+
+	/*
+	 * Some drivers check whether pm_power_off was already installed.
+	 * Install dummy callback using new API to preserve old behaviour
+	 * for those drivers during period of transition to the new API.
+	 */
+set_pm_power_off:
+	if (!pm_power_off) {
+		pm_power_off = dummy_pm_power_off;
+		pm_power_off_nb = nb;
+	}
+
+	return 0;
+}
+
+static int unregister_power_off_handler(struct notifier_block *nb)
+{
+	if (nb == pm_power_off_nb) {
+		if (pm_power_off == dummy_pm_power_off)
+			pm_power_off = NULL;
+
+		pm_power_off_nb = NULL;
+	}
+
+	return blocking_notifier_chain_unregister(&power_off_handler_list, nb);
+}
+
+static void devm_unregister_power_off_handler(void *data)
+{
+	struct notifier_block *nb = data;
+
+	unregister_power_off_handler(nb);
+}
+
+static int devm_register_power_off_handler(struct device *dev,
+					   struct notifier_block *nb)
+{
+	int err;
+
+	err = register_power_off_handler(nb);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_power_off_handler,
+					nb);
+}
+
+static int sys_off_handler_power_off(struct notifier_block *nb,
+				     unsigned long mode, void *unused)
+{
+	struct power_off_prep_data prep_data = {};
+	struct sys_off_handler_private_data *priv;
+	struct power_off_data data = {};
+	struct sys_off_handler *h;
+	int ret = NOTIFY_DONE;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, power_off_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+	prep_data.cb_data = h->cb_data;
+	data.cb_data = h->cb_data;
+
+	switch (mode) {
+	case POWEROFF_NORMAL:
+		if (h->power_off_cb)
+			h->power_off_cb(&data);
+
+		if (priv->simple_power_off_cb)
+			priv->simple_power_off_cb(priv->simple_power_off_cb_data);
+
+		if (priv->platform_power_off_cb)
+			priv->platform_power_off_cb();
+
+		if (!h->power_off_chaining_allowed)
+			ret = NOTIFY_STOP;
+
+		break;
+
+	case POWEROFF_PREPARE:
+		if (h->power_off_prepare_cb)
+			h->power_off_prepare_cb(&prep_data);
+
+		break;
+
+	default:
+		unreachable();
+	}
+
+	return ret;
+}
+
+static int sys_off_handler_restart(struct notifier_block *nb,
+				   unsigned long mode, void *cmd)
+{
+	struct sys_off_handler_private_data *priv;
+	struct restart_data data = {};
+	struct sys_off_handler *h;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, restart_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+
+	data.stop_chain = h->restart_chaining_disallowed;
+	data.cb_data = h->cb_data;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->restart_cb(&data);
+
+	return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
+}
+
+static int sys_off_handler_reboot(struct notifier_block *nb,
+				  unsigned long mode, void *cmd)
+{
+	struct sys_off_handler_private_data *priv;
+	struct reboot_prep_data data = {};
+	struct sys_off_handler *h;
+
+	priv = container_of(nb, struct sys_off_handler_private_data, reboot_nb);
+	h = container_of(priv, struct sys_off_handler, priv);
+
+	data.cb_data = h->cb_data;
+	data.stop_chain = false;
+	data.mode = mode;
+	data.cmd = cmd;
+
+	h->reboot_prepare_cb(&data);
+
+	return data.stop_chain ? NOTIFY_STOP : NOTIFY_DONE;
+}
+
+static struct sys_off_handler_private_data *
+sys_off_handler_private_data(struct sys_off_handler *handler)
+{
+	return (struct sys_off_handler_private_data *)&handler->priv;
+}
+
+/**
+ *	devm_register_sys_off_handler - Register system power-off/restart handler
+ *	@dev: Device that registers handler
+ *	@handler: System-off handler
+ *
+ *	Registers handler that will be called as last step of the power-off
+ *	and restart sequences.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_sys_off_handler(struct sys_off_handler *handler)
+{
+	struct sys_off_handler_private_data *priv;
+	int err, priority;
+
+	priv = sys_off_handler_private_data(handler);
+
+	/* sanity-check whether handler is registered twice */
+	if (priv->registered)
+		return -EBUSY;
+
+	if (handler->power_off_cb || handler->power_off_prepare_cb) {
+		if (handler->power_off_priority == POWEROFF_PRIO_RESERVED)
+			priority = POWEROFF_PRIO_DEFAULT;
+		else
+			priority = handler->power_off_priority;
+
+		priv->power_off_nb.notifier_call = sys_off_handler_power_off;
+		priv->power_off_nb.priority = priority;
+
+		err = register_power_off_handler(&priv->power_off_nb);
+		if (err)
+			goto reset_sys_off_handler;
+	}
+
+	if (handler->restart_cb) {
+		if (handler->restart_priority == RESTART_PRIO_RESERVED)
+			priority = RESTART_PRIO_DEFAULT;
+		else
+			priority = handler->restart_priority;
+
+		priv->restart_nb.notifier_call = sys_off_handler_restart;
+		priv->restart_nb.priority = priority;
+
+		err = register_restart_handler(&priv->restart_nb);
+		if (err)
+			goto unreg_power_off_handler;
+	}
+
+	if (handler->reboot_prepare_cb) {
+		priv->reboot_nb.notifier_call = sys_off_handler_reboot;
+		priv->reboot_nb.priority = handler->reboot_priority;
+
+		err = register_reboot_notifier(&priv->reboot_nb);
+		if (err)
+			goto unreg_restart_handler;
+	}
+
+	priv->registered = true;
+
+	return 0;
+
+unreg_restart_handler:
+	if (handler->restart_cb)
+		unregister_restart_handler(&priv->restart_nb);
+
+unreg_power_off_handler:
+	if (handler->power_off_cb)
+		unregister_power_off_handler(&priv->power_off_nb);
+
+reset_sys_off_handler:
+	memset(priv, 0, sizeof(*priv));
+
+	return err;
+}
+EXPORT_SYMBOL(register_sys_off_handler);
+
+/**
+ *	unregister_sys_off_handler - Unregister system power-off/restart handler
+ *	@handler: System-off handler
+ *
+ *	Unregisters sys-off handler. Does nothing and returns zero if handler
+ *	is NULL.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int unregister_sys_off_handler(struct sys_off_handler *handler)
+{
+	struct sys_off_handler_private_data *priv;
+	int err = 0;
+
+	if (!handler)
+		return 0;
+
+	priv = sys_off_handler_private_data(handler);
+
+	/* sanity-check whether handler is unregistered twice */
+	if (!priv->registered)
+		return -EINVAL;
+
+	if (handler->reboot_prepare_cb)
+		err |= unregister_reboot_notifier(&priv->reboot_nb);
+
+	if (handler->restart_cb)
+		err |= unregister_restart_handler(&priv->restart_nb);
+
+	if (handler->power_off_cb)
+		err |= unregister_power_off_handler(&priv->power_off_nb);
+
+	memset(priv, 0, sizeof(*priv));
+
+	return err ? -EINVAL : 0;
+}
+EXPORT_SYMBOL(unregister_sys_off_handler);
+
+static void devm_unregister_sys_off_handler(void *data)
+{
+	struct sys_off_handler *handler = data;
+
+	unregister_sys_off_handler(handler);
+}
+
+/**
+ *	devm_register_sys_off_handler - Register system power-off/restart handler
+ *	@dev: Device that registers handler
+ *	@handler: System-off handler
+ *
+ *	Resource-managed variant of register_sys_off_handler().
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_sys_off_handler(struct device *dev,
+				  struct sys_off_handler *handler)
+{
+	int err;
+
+	err = register_sys_off_handler(handler);
+	if (err)
+		return err;
+
+	return devm_add_action_or_reset(dev, devm_unregister_sys_off_handler,
+					handler);
+}
+EXPORT_SYMBOL(devm_register_sys_off_handler);
+
+/**
+ *	devm_register_prioritized_power_off_handler - Register prioritized power-off callback
+ *	@dev: Device that registers callback
+ *	@priority: Callback's priority
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed power-off callback with a given priority.
+ *	It will be called as last step of the power-off sequence. Callbacks
+ *	chaining is disabled, i.e. further lower priority callbacks won't
+ *	be executed if this @callback will fail to execute.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_prioritized_power_off_handler(struct device *dev,
+						int priority,
+						void (*callback)(void *data),
+						void *cb_data)
+{
+	struct sys_off_handler_private_data *priv;
+	struct sys_off_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	if (priority == POWEROFF_PRIO_RESERVED)
+		priority = POWEROFF_PRIO_DEFAULT;
+
+	priv = sys_off_handler_private_data(handler);
+
+	priv->power_off_nb.notifier_call = sys_off_handler_power_off;
+	priv->power_off_nb.priority = priority;
+	priv->simple_power_off_cb_data = cb_data;
+	priv->simple_power_off_cb = callback;
+
+	return devm_register_power_off_handler(dev, &priv->power_off_nb);
+}
+EXPORT_SYMBOL(devm_register_prioritized_power_off_handler);
+
+/**
+ *	devm_register_prioritized_restart_handler - Register prioritized restart callback
+ *	@dev: Device that registers callback
+ *	@priority: Callback's priority
+ *	@callback: Callback function
+ *	@cb_data: Callback's argument
+ *
+ *	Registers resource-managed restart callback with a given priority.
+ *	It will be called as a part of the restart sequence. Callbacks
+ *	chaining is disabled, i.e. further lower priority callbacks won't
+ *	be executed if this @callback will fail to execute.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int devm_register_prioritized_restart_handler(struct device *dev,
+					      int priority,
+					      void (*callback)(struct restart_data *data),
+					      void *cb_data)
+{
+	struct sys_off_handler *handler;
+
+	handler = devm_kzalloc(dev, sizeof(*handler), GFP_KERNEL);
+	if (!handler)
+		return -ENOMEM;
+
+	if (priority == RESTART_PRIO_RESERVED)
+		priority = RESTART_PRIO_DEFAULT;
+
+	handler->restart_priority = priority;
+	handler->restart_cb = callback;
+	handler->cb_data = cb_data;
+
+	return devm_register_sys_off_handler(dev, handler);
+}
+EXPORT_SYMBOL(devm_register_prioritized_restart_handler);
+
+static struct sys_off_handler platform_power_off_handler = {
+	.priv = {
+		.power_off_nb = {
+			.notifier_call = sys_off_handler_power_off,
+			.priority = POWEROFF_PRIO_PLATFORM,
+		},
+	},
+};
+
+static DEFINE_SPINLOCK(platform_power_off_lock);
+
+/**
+ *	register_platform_power_off - Register platform-level power-off callback
+ *	@power_off: Power-off callback
+ *
+ *	Registers power-off callback that will be called as last step
+ *	of the power-off sequence. This callback is expected to be invoked
+ *	for the last resort. Further lower priority callbacks won't be
+ *	executed if @power_off fails. Only one platform power-off callback
+ *	is allowed to be registered at a time.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int register_platform_power_off(void (*power_off)(void))
+{
+	struct sys_off_handler_private_data *priv;
+	int ret = 0;
+
+	priv = sys_off_handler_private_data(&platform_power_off_handler);
+
+	spin_lock(&platform_power_off_lock);
+	if (priv->platform_power_off_cb)
+		ret = -EBUSY;
+	else
+		priv->platform_power_off_cb = power_off;
+	spin_unlock(&platform_power_off_lock);
+
+	if (ret)
+		return ret;
+
+	ret = register_power_off_handler(&priv->power_off_nb);
+	if (ret)
+		priv->platform_power_off_cb = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(register_platform_power_off);
+
+/**
+ *	unregister_platform_power_off - Unregister platform-level power-off callback
+ *	@power_off: Power-off callback
+ *
+ *	Unregisters previously registered platform power-off callback.
+ *
+ *	Returns zero on success, or error code on failure.
+ */
+int unregister_platform_power_off(void (*power_off)(void))
+{
+	struct sys_off_handler_private_data *priv;
+	int ret;
+
+	priv = sys_off_handler_private_data(&platform_power_off_handler);
+
+	if (priv->platform_power_off_cb != power_off)
+		return -EINVAL;
+
+	ret = unregister_power_off_handler(&priv->power_off_nb);
+	priv->platform_power_off_cb = NULL;
+
+	return ret;
+}
+EXPORT_SYMBOL_GPL(unregister_platform_power_off);
+
+/**
+ *	do_kernel_power_off - Execute kernel power-off handler call chain
+ *
+ *	Calls functions registered with register_power_off_handler.
+ *
+ *	Expected to be called as last step of the power-off sequence.
+ *
+ *	Powers off the system immediately if a power-off handler function has
+ *	been registered. Otherwise does nothing.
+ */
+void do_kernel_power_off(void)
+{
+	/* legacy pm_power_off() is unchained and has highest priority */
+	if (pm_power_off && pm_power_off != dummy_pm_power_off)
+		return pm_power_off();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_NORMAL,
+				     NULL);
+}
+
+static void do_kernel_power_off_prepare(void)
+{
+	/* legacy pm_power_off_prepare() is unchained and has highest priority */
+	if (pm_power_off_prepare)
+		return pm_power_off_prepare();
+
+	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
+				     NULL);
+}
+
 /**
  *	kernel_power_off - power_off the system
  *
@@ -304,8 +845,7 @@ EXPORT_SYMBOL_GPL(kernel_halt);
 void kernel_power_off(void)
 {
 	kernel_shutdown_prepare(SYSTEM_POWER_OFF);
-	if (pm_power_off_prepare)
-		pm_power_off_prepare();
+	do_kernel_power_off_prepare();
 	migrate_to_reboot_cpu();
 	syscore_shutdown();
 	pr_emerg("Power down\n");
@@ -314,6 +854,16 @@ void kernel_power_off(void)
 }
 EXPORT_SYMBOL_GPL(kernel_power_off);
 
+bool kernel_can_power_off(void)
+{
+	if (!pm_power_off &&
+	    blocking_notifier_call_chain_is_empty(&power_off_handler_list))
+		return false;
+
+	return true;
+}
+EXPORT_SYMBOL_GPL(kernel_can_power_off);
+
 DEFINE_MUTEX(system_transition_mutex);
 
 /*
@@ -355,7 +905,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
 	/* Instead of trying to make the power_off code look like
 	 * halt when pm_power_off is not set do it the easy way.
 	 */
-	if ((cmd == LINUX_REBOOT_CMD_POWER_OFF) && !pm_power_off)
+	if (cmd == LINUX_REBOOT_CMD_POWER_OFF && !kernel_can_power_off())
 		cmd = LINUX_REBOOT_CMD_HALT;
 
 	mutex_lock(&system_transition_mutex);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245685.423803 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0S-0004Rs-VE; Sun, 12 Dec 2021 21:03:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245685.423803; Sun, 12 Dec 2021 21:03:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0S-0004Rl-RA; Sun, 12 Dec 2021 21:03:40 +0000
Received: by outflank-mailman (input) for mailman id 245685;
 Sun, 12 Dec 2021 21:03:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0R-0004BS-Lm
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:39 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fa65b1db-5b8e-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:38 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id b19so19302924ljr.12
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:38 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:38 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa65b1db-5b8e-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=CYB4TkQOzA3vf/K7WR0AkGT34Ge0Y+0VoaElZGGGZzU=;
        b=YPGRWatSQET2pz+NVqu4ADHfYgaxmP/wWxna6m/lloO4toehydZkLAQeVKfAZnur3U
         ytUl8qCGBZdPLRC2UzNM4AW78JtCd6wM5cGhTywvum741iPm3RcFk7tkhkZidnvbCnJl
         R/4YWy2Kn2XQsZfcdS0OqacDfDDCQ28GjMnqHQTevEBhyfW+vOkmPPci2FrLZRzsEI3D
         rIODFz6+YMOOUk7HX9YcjikZPgA6Qmy3MY8VgfLlwgexSKQyGvZ0zOYmPyq4U9vsPiW2
         gzi0gfD7OcJAbuwERD0Pe26Rs8F2W7VMl8LrFpshwRBhPegOZQws/YUiLfZf5um9S4nw
         C5Tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=CYB4TkQOzA3vf/K7WR0AkGT34Ge0Y+0VoaElZGGGZzU=;
        b=z8RUQHrZLGkIcYJozy36sRlNQ6nK0Uw/Cc+GgrirIiwWZG7aN+Qe61/Dc5+taPWknY
         PQIkiLO7tP5KpsZhUi1J7YskD468bGls0VCsCWfPr8xgOTtKCirfqY2KSaaRcP2gfTVk
         T/1BYDciso8qxcBn4uu/GfibnDRcd0PKKAC7vdtjnd9WlhN4zaKLDToAkZvYEAAUSkLP
         53zjdzl8DyMlGxSRkYtjWL5F8loeB2hOkp5cTzzAwgE6ktcI+SmBQjHvCSecndimBiD3
         vGaFbQ2tJxrpa2l+PkFF7sTGsx1xY6F6nHtyO7CLykrsVu1ZJPlIsa9ATptfAlyUSQek
         PrmQ==
X-Gm-Message-State: AOAM532ZuN/6cPgKNqk1H7gWPS4xWGAVE1FdEKYa8h5SzFE/bWJVUKzm
	XG1ZvpXrGDnIZlI5nEn67Vc=
X-Google-Smtp-Source: ABdhPJzJGi8tVTi5bdKFCxEOnO/KtQERR8PihOgq6tSrXYkNCawTEu3K38hiwfey531aaHgxOHQg5Q==
X-Received: by 2002:a2e:874b:: with SMTP id q11mr26014054ljj.194.1639343018442;
        Sun, 12 Dec 2021 13:03:38 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 02/21] notifier: Add atomic/blocking_notifier_chain_register_unique_prio()
Date: Mon, 13 Dec 2021 00:02:50 +0300
Message-Id: <20211212210309.9851-3-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add variant of atomic/blocking_notifier_chain_register() functions that
doesn't allow to register notifier using a duplicated priority. The -EBUSY
error code is returned in this case by the new API functions.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/notifier.h |  5 +++
 kernel/notifier.c        | 87 +++++++++++++++++++++++++++++++---------
 2 files changed, 73 insertions(+), 19 deletions(-)

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index d4717bc0ab85..ccce26197dd2 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -150,6 +150,11 @@ extern int raw_notifier_chain_register(struct raw_notifier_head *nh,
 extern int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
 		struct notifier_block *nb);
 
+extern int atomic_notifier_chain_register_unique_prio(
+		struct atomic_notifier_head *nh, struct notifier_block *nb);
+extern int blocking_notifier_chain_register_unique_prio(
+		struct blocking_notifier_head *nh, struct notifier_block *nb);
+
 extern int atomic_notifier_chain_unregister(struct atomic_notifier_head *nh,
 		struct notifier_block *nb);
 extern int blocking_notifier_chain_unregister(struct blocking_notifier_head *nh,
diff --git a/kernel/notifier.c b/kernel/notifier.c
index e30d24ee88e9..77e5112ff05b 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -20,7 +20,7 @@ BLOCKING_NOTIFIER_HEAD(reboot_notifier_list);
  */
 
 static int notifier_chain_register(struct notifier_block **nl,
-		struct notifier_block *n)
+		struct notifier_block *n, bool unique_priority)
 {
 	while ((*nl) != NULL) {
 		if (unlikely((*nl) == n)) {
@@ -29,6 +29,8 @@ static int notifier_chain_register(struct notifier_block **nl,
 		}
 		if (n->priority > (*nl)->priority)
 			break;
+		if (n->priority == (*nl)->priority && unique_priority)
+			return -EBUSY;
 		nl = &((*nl)->next);
 	}
 	n->next = *nl;
@@ -143,12 +145,35 @@ int atomic_notifier_chain_register(struct atomic_notifier_head *nh,
 	int ret;
 
 	spin_lock_irqsave(&nh->lock, flags);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, false);
 	spin_unlock_irqrestore(&nh->lock, flags);
 	return ret;
 }
 EXPORT_SYMBOL_GPL(atomic_notifier_chain_register);
 
+/**
+ *	atomic_notifier_chain_register_unique_prio - Add notifier to an atomic notifier chain
+ *	@nh: Pointer to head of the atomic notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to an atomic notifier chain if there is no other
+ *	notifier registered using the same priority.
+ *
+ *	Returns zero on success, -EBUSY otherwise.
+ */
+int atomic_notifier_chain_register_unique_prio(struct atomic_notifier_head *nh,
+					       struct notifier_block *n)
+{
+	unsigned long flags;
+	int ret;
+
+	spin_lock_irqsave(&nh->lock, flags);
+	ret = notifier_chain_register(&nh->head, n, true);
+	spin_unlock_irqrestore(&nh->lock, flags);
+	return ret;
+}
+EXPORT_SYMBOL_GPL(atomic_notifier_chain_register_unique_prio);
+
 /**
  *	atomic_notifier_chain_unregister - Remove notifier from an atomic notifier chain
  *	@nh: Pointer to head of the atomic notifier chain
@@ -208,18 +233,9 @@ NOKPROBE_SYMBOL(atomic_notifier_call_chain);
  *	synchronized by an rwsem.
  */
 
-/**
- *	blocking_notifier_chain_register - Add notifier to a blocking notifier chain
- *	@nh: Pointer to head of the blocking notifier chain
- *	@n: New entry in notifier chain
- *
- *	Adds a notifier to a blocking notifier chain.
- *	Must be called in process context.
- *
- *	Currently always returns zero.
- */
-int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
-		struct notifier_block *n)
+static int __blocking_notifier_chain_register(struct blocking_notifier_head *nh,
+					      struct notifier_block *n,
+					      bool unique_priority)
 {
 	int ret;
 
@@ -229,15 +245,48 @@ int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
 	 * such times we must not call down_write().
 	 */
 	if (unlikely(system_state == SYSTEM_BOOTING))
-		return notifier_chain_register(&nh->head, n);
+		return notifier_chain_register(&nh->head, n, unique_priority);
 
 	down_write(&nh->rwsem);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, unique_priority);
 	up_write(&nh->rwsem);
 	return ret;
 }
+
+/**
+ *	blocking_notifier_chain_register - Add notifier to a blocking notifier chain
+ *	@nh: Pointer to head of the blocking notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to a blocking notifier chain.
+ *	Must be called in process context.
+ *
+ *	Currently always returns zero.
+ */
+int blocking_notifier_chain_register(struct blocking_notifier_head *nh,
+		struct notifier_block *n)
+{
+	return __blocking_notifier_chain_register(nh, n, false);
+}
 EXPORT_SYMBOL_GPL(blocking_notifier_chain_register);
 
+/**
+ *	blocking_notifier_chain_register_unique_prio - Add notifier to a blocking notifier chain
+ *	@nh: Pointer to head of the blocking notifier chain
+ *	@n: New entry in notifier chain
+ *
+ *	Adds a notifier to an blocking notifier chain if there is no other
+ *	notifier registered using the same priority.
+ *
+ *	Returns zero on success, -EBUSY otherwise.
+ */
+int blocking_notifier_chain_register_unique_prio(struct blocking_notifier_head *nh,
+						 struct notifier_block *n)
+{
+	return __blocking_notifier_chain_register(nh, n, true);
+}
+EXPORT_SYMBOL_GPL(blocking_notifier_chain_register_unique_prio);
+
 /**
  *	blocking_notifier_chain_unregister - Remove notifier from a blocking notifier chain
  *	@nh: Pointer to head of the blocking notifier chain
@@ -353,7 +402,7 @@ bool blocking_notifier_call_chain_is_empty(struct blocking_notifier_head *nh)
 int raw_notifier_chain_register(struct raw_notifier_head *nh,
 		struct notifier_block *n)
 {
-	return notifier_chain_register(&nh->head, n);
+	return notifier_chain_register(&nh->head, n, false);
 }
 EXPORT_SYMBOL_GPL(raw_notifier_chain_register);
 
@@ -432,10 +481,10 @@ int srcu_notifier_chain_register(struct srcu_notifier_head *nh,
 	 * such times we must not call mutex_lock().
 	 */
 	if (unlikely(system_state == SYSTEM_BOOTING))
-		return notifier_chain_register(&nh->head, n);
+		return notifier_chain_register(&nh->head, n, false);
 
 	mutex_lock(&nh->mutex);
-	ret = notifier_chain_register(&nh->head, n);
+	ret = notifier_chain_register(&nh->head, n, false);
 	mutex_unlock(&nh->mutex);
 	return ret;
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245691.423869 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0d-0006Cy-6U; Sun, 12 Dec 2021 21:03:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245691.423869; Sun, 12 Dec 2021 21:03:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0d-0006Ce-1o; Sun, 12 Dec 2021 21:03:51 +0000
Received: by outflank-mailman (input) for mailman id 245691;
 Sun, 12 Dec 2021 21:03:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0b-0004BS-Oq
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:49 +0000
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com
 [2a00:1450:4864:20::22e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0075b9d2-5b8f-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:49 +0100 (CET)
Received: by mail-lj1-x22e.google.com with SMTP id 13so21024774ljj.11
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:49 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.46
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:48 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0075b9d2-5b8f-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=hKgqav8a8uS+JOYHQI8KBeK4UU43xCMXoqbNcSGFyUw=;
        b=KUwqX4BEtYi0Tl6FHY2CY8/c97CDNjqMcby3q7qakxzQRe7fXsisnIY/MWhKC0c/of
         zGMKDdImy6NTe9G0A7mThOpcw6K/S+1AR3eVT8uprZ/XHyIT4qyf2Wds12KFazsicm2w
         bCeOnXKrjzFNqWMPd1F+4GYHIWkBe3KzeOKUJ7KCKaBggqii376yhMOZjBlnlQ+uIszq
         o5w0MaH69JTpDhOPa5VxphJ3hllwl22I2McYWQ9jDuw0qGIyBUeZs+8S9NMFTWPSbYZ6
         7nWpNaZC68XoQbuOZZurBgla3U0x2zQDP37QsCnspr/jFi2Zol4uIo+V9XhzwJK0tYnt
         /a9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=hKgqav8a8uS+JOYHQI8KBeK4UU43xCMXoqbNcSGFyUw=;
        b=R7spUkU0sSX7sz6Rq2CDdrn3THh5uWn7IRS+ngCos3auEVWByDHaoiMa9UpJgkB3Ul
         qAU2Q8Lu2P1x6L21G0mx3LqvvFT1mnmiI1ItZKoXeSewF/eiz7nCafigSmu2Ui17UCcu
         cqUnYjr8EigMztu3CK9OFITMhGvX2xsXWm4vOtmbDq7J01LXaNAqt+1GAi3geo4Wwn4s
         O3jgI2MBn15+eZha14sdhFgouSPES9msiNXHqqk1CDEYovc9Jdwg8I1aVpza5KmU8oMu
         8miF0Sldq+x5rdDhb49CEE9WMDTdPKGOhjV1VBoke0DIU/eZohfaZ9kJgbdLaXzhhpJr
         tVFw==
X-Gm-Message-State: AOAM5327lTZdIXWLBebpTgEt5Fym083InvgOpRzgDFAIVoNh+dGpzpKO
	S6FoMYJ2UCYcQK8BwEril4M=
X-Google-Smtp-Source: ABdhPJx8zOHfYkUzyKpEFmy9Fj+BAxzXOZqHBn3tHFlW4guWn1rgQHHNzqejujAnyj7ZOsRsx/6BSA==
X-Received: by 2002:a2e:920a:: with SMTP id k10mr25768511ljg.234.1639343028659;
        Sun, 12 Dec 2021 13:03:48 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 07/21] riscv: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:55 +0300
Message-Id: <20211212210309.9851-8-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Palmer Dabbelt <palmer@dabbelt.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/riscv/kernel/reset.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
index 9c842c41684a..912288572226 100644
--- a/arch/riscv/kernel/reset.c
+++ b/arch/riscv/kernel/reset.c
@@ -23,16 +23,12 @@ void machine_restart(char *cmd)
 
 void machine_halt(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
 
 void machine_power_off(void)
 {
-	if (pm_power_off != NULL)
-		pm_power_off();
-	else
-		default_power_off();
+	do_kernel_power_off();
+	default_power_off();
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245692.423880 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0f-0006db-Lr; Sun, 12 Dec 2021 21:03:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245692.423880; Sun, 12 Dec 2021 21:03:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0f-0006dQ-Gn; Sun, 12 Dec 2021 21:03:53 +0000
Received: by outflank-mailman (input) for mailman id 245692;
 Sun, 12 Dec 2021 21:03:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0d-0004MP-Kt
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:51 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 01b807c3-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:51 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id l7so21133212lja.2
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:51 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:50 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01b807c3-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=NEBfa1fMA+x5w4qEnSCEpCMUhXzxF+K5pq5bQ4oFCgw=;
        b=jKT5aLZfWR0wdy1ZRHa2+F5Hc16ta1np03rkr+cf27BN8zUNhbkEoAuNYpXOIawSIH
         2XymTHuAk1C3VpWmhK4AsE1yb/G2IulrJt3rlG67Vh5DarQrO3/RvtCACcc9q/mrlMzG
         idTBdpttStFv0rFHXoDeMkKrlqiTc6LMJnuQorLtWh4hfdMc2KQqq/SPJGqZAD8cFtP7
         bU0fIoQxCEwyS17dGv1ELgqsYZc+uy4iyxYp9vTtn2S36VrT7egCJ/N2pPTJk/5GCnV0
         wCdVD2AV/3wMZeA5Ef+Z3RwjWWbr7SVUDzZ2VoU/BSE2RRwY2l531P1a/0YVFVmDZNjy
         PILQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=NEBfa1fMA+x5w4qEnSCEpCMUhXzxF+K5pq5bQ4oFCgw=;
        b=avmYD7YkIW48jocCkFkKaHvgA80USRaiX5ctQKErX/NA1LXHy0o+ARjOb1GoBa7yoR
         H4FG863oXhHylJU2qhDtfkiNXf123EMLFHSV+rMBMy3WDZBHihI/w53z0eDm2eXDUeK9
         GzU8KiL5NRN1WHRvOD6Z+FMxNWT9hwLhclk+7Yn+Z/bxGgLaANmLmjCeg6Y0c/TfOLco
         76O3HMGyoRcCWGtMTTkMjZA9W5qsoH8rAYK1O+K1MvjvXavDtaqjanmN74Inmh+t2lfO
         r7UcP2ERfsHZRpRH6WPYOhU4TB0kWrY+6p/q+k1qSSZHkWaDicxrpYu5fvOVbwZW8JPx
         iLkw==
X-Gm-Message-State: AOAM532mIRKjiYosTl7ouLztwcVJHNiJHGmvFkphZRBYE5YHnh/CJzxH
	fI7o+i6QFTO4yQq3gNSwvww=
X-Google-Smtp-Source: ABdhPJxgpZfqxao+vFSyfTfxI+LCB5noXzLgWBaLJYSm65bPEK2lM39NLgbcPLKrE+YWXn5oNC0cUA==
X-Received: by 2002:a2e:a26a:: with SMTP id k10mr25711010ljm.156.1639343030651;
        Sun, 12 Dec 2021 13:03:50 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 08/21] arm64: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:56 +0300
Message-Id: <20211212210309.9851-9-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm64/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index aacf2f5559a8..f8db031afa7d 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -110,8 +110,7 @@ void machine_power_off(void)
 {
 	local_irq_disable();
 	smp_send_stop();
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 /*
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245693.423891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0i-00071E-1W; Sun, 12 Dec 2021 21:03:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245693.423891; Sun, 12 Dec 2021 21:03:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0h-00070o-Rn; Sun, 12 Dec 2021 21:03:55 +0000
Received: by outflank-mailman (input) for mailman id 245693;
 Sun, 12 Dec 2021 21:03:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0f-0004MP-Kq
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:53 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 02e62403-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:53 +0100 (CET)
Received: by mail-lj1-x22a.google.com with SMTP id u22so21070826lju.7
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:53 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 02e62403-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=qRRUcggihxuvvuxXR8avhK/eModbACqCMIG7s3bijm0=;
        b=cwgMkLRmIC5Jc7bTumRtZfdR/utOuYZMGz1d8ygkTHHtVzgzo42XHF3MxCIlHJHEyT
         C7LdLWylZ0pNaMDQhDT13J5l+njgSg9TNbzeMmfiPFReiWjuLN3BPKhAAriju1eHl9cw
         v0xZYrbokM5iV9yDxCHW4tROVpkV6lIWT7CatJGFsO5P7KMEX+3KZoYfdE3quHDnbdkY
         jpj2wUw+3g4R/1VtteNb23NQNkNZ2V1/PAhs7heDgq209kuV3pPkDwgZ1aWLoWFqzEEX
         OFHc08yxalGQachdnm1D3b45tSRQQlH3u/KkV4GShGX8mzd5qIB7iZpCyJ01mJBdqNcV
         pVRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=qRRUcggihxuvvuxXR8avhK/eModbACqCMIG7s3bijm0=;
        b=7teO0EzxwUwkcGe2WDaYCrZtCaXjBP2J7yvtumDkJly1x1WSeqALz+DPPO+NYlBkFo
         SEdRW8iQCtzObEiDLjMo3XxR2s5G4bD8A4tb6J3my0ujPM3OusK0xTHItSFUZSU6Gap0
         NUp/RHQMNBtAo11M2Zw0DxBPkDNAoiHwK4wVL/61nHqzw3Oj3Rq8eQNXpiaN6k6Pjoqw
         O2P+iCcg241LaevvSFeq6oZsgSc+58PwmUpvdeUbasoxTMWmQ2ngfTXOBuW+JwBrN8Se
         bdk+/w2QyFWv1/yIuE5Ro9k8IecfuoK722CP03D+Jpqh5obGAqLKMBrbbg8EGm4Y08qY
         Mh2A==
X-Gm-Message-State: AOAM531e3E4FwF7hmjrAwGk3ujXlZhRmqnjvIBZtQijwv1HQUHsKIDMx
	rE+jwcEK3ayN0t6UJJbvOAI=
X-Google-Smtp-Source: ABdhPJwkugCxrPdxtc+DUdPqlE8VTgsZlj2PXoqJkSrC88l4/tv/AsdhkMaJuxd6V34n0G6eKbJ/hw==
X-Received: by 2002:a05:651c:1790:: with SMTP id bn16mr25960176ljb.475.1639343032645;
        Sun, 12 Dec 2021 13:03:52 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 09/21] parisc: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:57 +0300
Message-Id: <20211212210309.9851-10-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Helge Deller <deller@gmx.de> # parisc
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/parisc/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
index ea3d83b6fb62..928201b1f58f 100644
--- a/arch/parisc/kernel/process.c
+++ b/arch/parisc/kernel/process.c
@@ -26,6 +26,7 @@
 #include <linux/module.h>
 #include <linux/personality.h>
 #include <linux/ptrace.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task.h>
@@ -114,8 +115,7 @@ void machine_power_off(void)
 	pdc_chassis_send_status(PDC_CHASSIS_DIRECT_SHUTDOWN);
 
 	/* ipmi_poweroff may have been installed. */
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 		
 	/* It seems we have no way to power the system off via
 	 * software. The user has to press the button himself. */
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245694.423899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0j-0007P8-Li; Sun, 12 Dec 2021 21:03:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245694.423899; Sun, 12 Dec 2021 21:03:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0j-0007OX-FV; Sun, 12 Dec 2021 21:03:57 +0000
Received: by outflank-mailman (input) for mailman id 245694;
 Sun, 12 Dec 2021 21:03:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0h-0004BS-IN
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:55 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0407653e-5b8f-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:03:54 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id k2so21096976lji.4
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:54 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0407653e-5b8f-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=cQhCUMmxREqlb3fYFdUNP+80Jr1xwOUlupNd5E99mX4=;
        b=kywzoc+Gi7wLNuBk90TEKZW85IC/6URmBmQrI58bAL/QPFhT2prlCmlNeb9T8eY7Ic
         kaAzgc8G/0LgoIzVYO1QktoG7vKpxJJBnuwLoDt+HIA67HN4VctOi7XqEXlw6RTgsmNB
         9ZzMbAWCGvmSWTdelcaOM9EwDKrMUtEbXlVABEMzzEb6IxT5HrFIy/s6X4Z2D3yGz8be
         G89ttBkdlIOUOuEDpB9kv6rMon8ZyAqpnzA7ZSWI952xKubMgQPGXFJ+ne9aWLwQTENu
         ihN9SLyYypvBOVyotduA1RjOzW4Dvoz4sPrRK/VW5mbeHSEzk4q7EP/uMXmylA99SqQI
         TI5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=cQhCUMmxREqlb3fYFdUNP+80Jr1xwOUlupNd5E99mX4=;
        b=7bPwsqBh1lm32stbk2pg3Y4dvqmRRGYOSuHsxO4opHN7D/tGXBI5B7/vzb2D7uxuk3
         mHIVWSEiLTMq7FXJWKa/HEN3HxzBfDbmqKm5ogkmAeNIT47K9+PLBmVDNXgCyDF9t/1w
         WC+xXKnYmdOHuyS3RGkB6kxX2SHrDTwkraYkaoUb+bYk2LaEs2vM/mZkEL38RkReLSsl
         ieEsN/U7kr/S0x/cOpKndc1Q2gPyy0jUCjyqWaciq1BJ037F+23a4xAhZPjtAmzkTbra
         Bs6Jmse4aEy0gB/1W+2epam1cFPztB5cQJj/qFP1m7CbNSAbXbx7qcYFgNJ4OTy7lTnz
         Sduw==
X-Gm-Message-State: AOAM533j670sGz2l0YHKItUORsB8RvzYjEQqvqhNbts/QRGSnh7Hdejd
	Evx/sFeDD9gMXFXA1IPJUZw=
X-Google-Smtp-Source: ABdhPJwPHg+2Pz2/BonOuvJzDEEvGDrSlS58FJbScCfLgCTS8nGeJYv4KFLQDU4sli93Hwi7CmGl0g==
X-Received: by 2002:a2e:a176:: with SMTP id u22mr26407140ljl.116.1639343034642;
        Sun, 12 Dec 2021 13:03:54 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 10/21] xen/x86: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:58 +0300
Message-Id: <20211212210309.9851-11-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/x86/xen/enlighten_pv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
index 5004feb16783..527fa545eb1f 100644
--- a/arch/x86/xen/enlighten_pv.c
+++ b/arch/x86/xen/enlighten_pv.c
@@ -31,6 +31,7 @@
 #include <linux/gfp.h>
 #include <linux/edd.h>
 #include <linux/objtool.h>
+#include <linux/reboot.h>
 
 #include <xen/xen.h>
 #include <xen/events.h>
@@ -1068,8 +1069,7 @@ static void xen_machine_halt(void)
 
 static void xen_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	xen_reboot(SHUTDOWN_poweroff);
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245695.423909 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0l-0007pa-77; Sun, 12 Dec 2021 21:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245695.423909; Sun, 12 Dec 2021 21:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0l-0007oj-2x; Sun, 12 Dec 2021 21:03:59 +0000
Received: by outflank-mailman (input) for mailman id 245695;
 Sun, 12 Dec 2021 21:03:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0j-0004MP-Q8
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:03:57 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 056642a1-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:57 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id k23so21156093lje.1
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:57 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 056642a1-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=SHhUp08VE2ztEefsMlISnf3ubNnW0z005TmsLrFHcW4=;
        b=M4kpDtgNg/HMIKnHemPbZaAlzhr0ntsevGanXWQ4n3yWnl//f+XQDu5U2Ja/bsZBLw
         ZB7lG6HNkYZjH8rldh7wQZsaGJBaC4h0p4AT21fuNpchnkBJWm9NM9UGwpzaKojZCS7y
         bTuVH9eWn0ocvLyPuLVpNAy1ngP0f11Fg78Z4AEVGIk7G8QbthlbgjrYXuLAU498OxT8
         bgCN/dHbI9hpQ/7EtqeytCSL7rK/H+myVWm8Se1R6C2Q4UDGC7MvllRFkeixGbQendIJ
         yK+CRe2KyF+IJR5cBcrAOj9h551rxSL2ZajWGRFkc4kB3fO9UCnd3vhKtJZ1+yX50+HP
         yKJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=SHhUp08VE2ztEefsMlISnf3ubNnW0z005TmsLrFHcW4=;
        b=7BaVt+eWhvNZ+odlwBOuaD10+l5jg3MkMWg9++OGA7NT4g08F7QrTbiZ1c5ieOQq2F
         8dOnC8aAUzhiRTh8/BlSDIUoL4WCmxspY8NQFyZxo+GT39+LqECQhI3FDSv6SEkuX6Cn
         pg9Hf8D4Hz7xzclibzhZ3GV501VOIrzNzLVCZKLby5p63F69GhcgXiKYhfPRk0LhDF1a
         uLvZF2qbe6x0zkhGZxJhXmBJgxEghWUZG04DLqWprZcJXQaVtvVbur6Ys2fU3vfO4XzD
         tfu3GZ5XQrgz8KdWaVZcdT+uOB6gVNKH2UDBN9At+6Mq6R+X1Wh03dqfn5jbZ7uX19YN
         fZbQ==
X-Gm-Message-State: AOAM532dpRNDzy0jDShzXcnuK0huJiWXPF8qvR6P7jkUEWopZI3I/j2p
	RqapMhKbGKnkC4H44RNORQ4=
X-Google-Smtp-Source: ABdhPJz8R3Mq1R/xI8IHeAv3OrqV+OEyi8dYUIUI01foRIKaOY1/e4KcpBxYoYjyrD2YWzDb+CaShQ==
X-Received: by 2002:a2e:bf1e:: with SMTP id c30mr19020669ljr.408.1639343036846;
        Sun, 12 Dec 2021 13:03:56 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 11/21] powerpc: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:02:59 +0300
Message-Id: <20211212210309.9851-12-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/powerpc/kernel/setup-common.c | 4 +---
 arch/powerpc/xmon/xmon.c           | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index f8da937df918..8158e940db81 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -161,9 +161,7 @@ void machine_restart(char *cmd)
 void machine_power_off(void)
 {
 	machine_shutdown();
-	if (pm_power_off)
-		pm_power_off();
-
+	do_kernel_power_off();
 	smp_send_stop();
 	machine_hang();
 }
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 83100c6524cc..759e167704e6 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1243,8 +1243,7 @@ static void bootcmds(void)
 	} else if (cmd == 'h') {
 		ppc_md.halt();
 	} else if (cmd == 'p') {
-		if (pm_power_off)
-			pm_power_off();
+		do_kernel_power_off();
 	}
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245696.423924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0n-0008Um-S1; Sun, 12 Dec 2021 21:04:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245696.423924; Sun, 12 Dec 2021 21:04:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0n-0008UL-Kr; Sun, 12 Dec 2021 21:04:01 +0000
Received: by outflank-mailman (input) for mailman id 245696;
 Sun, 12 Dec 2021 21:04:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0m-0004MP-2J
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:00 +0000
Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com
 [2a00:1450:4864:20::234])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 06a8a1d9-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:03:59 +0100 (CET)
Received: by mail-lj1-x234.google.com with SMTP id bn20so21108649ljb.8
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:03:59 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:03:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06a8a1d9-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=wYDTQaETrXPItP1/JDli7ai+6XwIrQRRYJAIL5Q83WI=;
        b=mytm/DccZ1wzLV8XTmme10BTi4beUxZb3ysJUV5xYL3KUNdI6UIdOg14PI4Xf14XxI
         7c+v89VpWLB0ZUhSuYpai3wHhN1WGcKOGbWxhGz9tr3OzP6swV60YcA1Wv5ZjDbMnKUa
         xazlSiI4jIde5eD9wVDd3hacMA1401SIHTIVPK4datO44ZlP1Doly3s0Wmv47NPuWclC
         2Crdjrp9htA7LHc95eECzQ1s6YjHoLBwAjSAcevyU9K8Sfc578kND8lSRu7vK9feHITf
         xRYypJ8GB6uZ0ZKBDnu+9y0H6KT0THCoLFcjbrxfymTRhYWqXWoS+2dhJR4JAajg0Zvg
         IWnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=wYDTQaETrXPItP1/JDli7ai+6XwIrQRRYJAIL5Q83WI=;
        b=mRY650nPKbN6dCfLvkYPbHJdOInnB2cHwOkO066udMbNt+KuJeJajudEbkwOzUjxtD
         cPBIpEXjeYCm2yRqvaFPVj3wjIcWB8PAj8VVNjXOsBFwuH3NtT/7Xgy3dZ1kO28TyP98
         Y3zKTmCGib60ls2kW1hRSaclolHodPsWHsUYy7uGsiiHwZwTzodyFmUvhHCczrJMV/fl
         7wfHIZMKcOQ/iyHhZSNbGBtwsm/K22xAlZG4kfPmCStQPTKghz0Ivg6qkVmhUTXj/vUk
         q5klIRQz2O5xtVJWsB/QNrYY0KJeVed8Uo8sdKUWNBU5YRYJPsaZq2Y/z0gweoOJdFuJ
         UfHA==
X-Gm-Message-State: AOAM530l6zHzRVmAIn58LyMtWzraE5Dxs8Qlovv3uV5s+CImrjauVLF3
	x3vNAtk2wCfv+a4mZOa8Xqc=
X-Google-Smtp-Source: ABdhPJyb60LD2qugqos2h5QyxI/abab2bR0WoFiHVAsfElgYVMLf1BWWm1ZERTHxaqoQ3zC4K8Hjug==
X-Received: by 2002:a2e:a238:: with SMTP id i24mr25511659ljm.296.1639343038939;
        Sun, 12 Dec 2021 13:03:58 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 12/21] m68k: Switch to new sys-off handler API
Date: Mon, 13 Dec 2021 00:03:00 +0300
Message-Id: <20211212210309.9851-13-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use
register_power_off_handler() that registers power-off handlers and
do_kernel_power_off() that invokes chained power-off handlers. Legacy
pm_power_off() will be removed once all drivers will be converted to
the new power-off API.

Normally arch code should adopt only the do_kernel_power_off() at first,
but m68k is a special case because it uses pm_power_off() "inside out",
i.e. pm_power_off() invokes machine_power_off() [in fact it does nothing],
while it's machine_power_off() that should invoke the pm_power_off(), and
thus, we can't convert platforms to the new API separately. There are only
two platforms changed here, so it's not a big deal.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/m68k/emu/natfeat.c         | 3 ++-
 arch/m68k/include/asm/machdep.h | 1 -
 arch/m68k/kernel/process.c      | 5 ++---
 arch/m68k/kernel/setup_mm.c     | 1 -
 arch/m68k/kernel/setup_no.c     | 1 -
 arch/m68k/mac/config.c          | 4 +++-
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/m68k/emu/natfeat.c b/arch/m68k/emu/natfeat.c
index 71b78ecee75c..b19dc00026d9 100644
--- a/arch/m68k/emu/natfeat.c
+++ b/arch/m68k/emu/natfeat.c
@@ -15,6 +15,7 @@
 #include <linux/string.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/io.h>
 #include <asm/machdep.h>
 #include <asm/natfeat.h>
@@ -90,5 +91,5 @@ void __init nf_init(void)
 	pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16,
 		version & 0xffff);
 
-	mach_power_off = nf_poweroff;
+	register_platform_power_off(nf_poweroff);
 }
diff --git a/arch/m68k/include/asm/machdep.h b/arch/m68k/include/asm/machdep.h
index 8fd80ef1b77e..8d8c3ee2069f 100644
--- a/arch/m68k/include/asm/machdep.h
+++ b/arch/m68k/include/asm/machdep.h
@@ -24,7 +24,6 @@ extern int (*mach_get_rtc_pll)(struct rtc_pll_info *);
 extern int (*mach_set_rtc_pll)(struct rtc_pll_info *);
 extern void (*mach_reset)( void );
 extern void (*mach_halt)( void );
-extern void (*mach_power_off)( void );
 extern unsigned long (*mach_hd_init) (unsigned long, unsigned long);
 extern void (*mach_hd_setup)(char *, int *);
 extern void (*mach_heartbeat) (int);
diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c
index a6030dbaa089..e160a7c57bd3 100644
--- a/arch/m68k/kernel/process.c
+++ b/arch/m68k/kernel/process.c
@@ -67,12 +67,11 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (mach_power_off)
-		mach_power_off();
+	do_kernel_power_off();
 	for (;;);
 }
 
-void (*pm_power_off)(void) = machine_power_off;
+void (*pm_power_off)(void);
 EXPORT_SYMBOL(pm_power_off);
 
 void show_regs(struct pt_regs * regs)
diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
index 49e573b94326..a3ff1342ced7 100644
--- a/arch/m68k/kernel/setup_mm.c
+++ b/arch/m68k/kernel/setup_mm.c
@@ -98,7 +98,6 @@ EXPORT_SYMBOL(mach_get_rtc_pll);
 EXPORT_SYMBOL(mach_set_rtc_pll);
 void (*mach_reset)( void );
 void (*mach_halt)( void );
-void (*mach_power_off)( void );
 #ifdef CONFIG_HEARTBEAT
 void (*mach_heartbeat) (int);
 EXPORT_SYMBOL(mach_heartbeat);
diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 5e4104f07a44..00bf82258233 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -55,7 +55,6 @@ int (*mach_hwclk) (int, struct rtc_time*);
 /* machine dependent reboot functions */
 void (*mach_reset)(void);
 void (*mach_halt)(void);
-void (*mach_power_off)(void);
 
 #ifdef CONFIG_M68000
 #if defined(CONFIG_M68328)
diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index 5d16f9b47aa9..727320dedf08 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -12,6 +12,7 @@
 
 #include <linux/errno.h>
 #include <linux/module.h>
+#include <linux/reboot.h>
 #include <linux/types.h>
 #include <linux/mm.h>
 #include <linux/tty.h>
@@ -139,7 +140,6 @@ void __init config_mac(void)
 	mach_hwclk = mac_hwclk;
 	mach_reset = mac_reset;
 	mach_halt = mac_poweroff;
-	mach_power_off = mac_poweroff;
 #if IS_ENABLED(CONFIG_INPUT_M68K_BEEP)
 	mach_beep = mac_mksound;
 #endif
@@ -159,6 +159,8 @@ void __init config_mac(void)
 
 	if (macintosh_config->ident == MAC_MODEL_IICI)
 		mach_l2_flush = via_l2_flush;
+
+	register_platform_power_off(mac_poweroff);
 }
 
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245697.423935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0q-0000jW-8g; Sun, 12 Dec 2021 21:04:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245697.423935; Sun, 12 Dec 2021 21:04:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0q-0000i8-1Z; Sun, 12 Dec 2021 21:04:04 +0000
Received: by outflank-mailman (input) for mailman id 245697;
 Sun, 12 Dec 2021 21:04:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0n-0004MP-Ql
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:01 +0000
Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com
 [2a00:1450:4864:20::12d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 07cddede-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:01 +0100 (CET)
Received: by mail-lf1-x12d.google.com with SMTP id k37so27531981lfv.3
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:01 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.03.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 07cddede-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=032w538UVpeATjNmIAIpxMVbSRQ+KkFSikcjH52Go7E=;
        b=E9VJGzDO/MjlF9k/luR3Khbhy1NPRGJFu45WGR11yv2Csut15VlFqb3GxfyXiC5K1R
         KoOjuPxJ74P0WBK6P5Rh4Yk8N3YLtFpHfuaNjG/nuh/tfSGU3NqTk9edZfzSNHKBOR8m
         kPzSD7yXn2hiHnOuT2WH4wXsn02tbX247vyP+WAbNdjC41aD7suYMkTSBhHb57suBLzg
         JDCdqG/x0ozFIiafXt1VhOC6hig+lrppFxitm7BNJIhU1ULZzUrjdQMODUqHIbHIv5lc
         HP4HR2RELBXIYyMaOYQnB3LyrgNZPo6J89xd7q/RgqqbviF8jrhJU82mQviA1Jb3TY/T
         AUjg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=032w538UVpeATjNmIAIpxMVbSRQ+KkFSikcjH52Go7E=;
        b=lOqYVzoZqrbYJPXjkkZ9mxfOS/0zrE7dWflhtmQjAiF8M/z48lFi7JwJGG56K7nXYE
         PUQHJR4hYz8H/32+TnrousBSfrZJfFdESQFeKwbmx6ziDVxE9NsT3SOiKeTMT9jZpXER
         sa+7HkUUtpU9JCh0hSLZJtBQFNpTUeu40GKEXRhNjx2adU+Xi16cmCYi89Zkq+nEddIa
         FHzO5M6Y5DpEa0ZQGKLqIHZh5dqH1m1AaluX4xwea6WJXurZjcau/ruicgm2Mnyyyzr4
         nk2S0m/n2emVEftWzEqfR1tOjwtuUnHJwzinsyebK2KmuCTzT+j5B+qiZ1fVaqpd2DX4
         Vglg==
X-Gm-Message-State: AOAM531Lu0UPl7Y3AstgUSfweVRgNKisPBYQWlLRw4qKsezAb6e7hm5U
	414CjozpuY0jY0CR/EhREEI=
X-Google-Smtp-Source: ABdhPJxUkKeqtg/YDWyN+6uH7IPe04t5eV8J/9ZVzn0URaLN05uRJEwSyylEX1JQ9jfzKVs+jpVePw==
X-Received: by 2002:a19:5e59:: with SMTP id z25mr25760424lfi.686.1639343040878;
        Sun, 12 Dec 2021 13:04:00 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 13/21] sh: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:03:01 +0300
Message-Id: <20211212210309.9851-14-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/sh/kernel/reboot.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/sh/kernel/reboot.c b/arch/sh/kernel/reboot.c
index 5c33f036418b..e8eeedc9b182 100644
--- a/arch/sh/kernel/reboot.c
+++ b/arch/sh/kernel/reboot.c
@@ -46,8 +46,7 @@ static void native_machine_shutdown(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 static void native_machine_halt(void)
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:04:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:04:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245702.423946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0u-0001RD-2c; Sun, 12 Dec 2021 21:04:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245702.423946; Sun, 12 Dec 2021 21:04:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW0t-0001Qu-S9; Sun, 12 Dec 2021 21:04:07 +0000
Received: by outflank-mailman (input) for mailman id 245702;
 Sun, 12 Dec 2021 21:04:06 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0r-0004BS-Ri
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:05 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08ed80b2-5b8f-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:04:03 +0100 (CET)
Received: by mail-lj1-x232.google.com with SMTP id l7so21133590lja.2
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:03 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08ed80b2-5b8f-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=fPDqjeCYEjf+DN+kHXgg7jNjsfy3nUCqOTZJ2Nh3G0E=;
        b=TVIdD68VWfHsQ5jfaqSICSZ1qOhZrUFA9mWdz6ePQHL1xqpH2YdGrbEBaLFkC7gIb8
         G5GVUsLpR7P9l8w4HUpnC9ENPDSIvCHlKYXxYDYBXpjfkLcAfFSnbF/TqDYZgNg+yp5d
         Pc9NdSlFwAt6HBoJA0bEg6oNgazZ4MeI6QmLhlMAROr2y9LwyzEcdRy2/Nl8fcUK+gJw
         4Z7GIu+SBSKJVBNrWt7sUDuuqAeIyNHaS//f1hsWBDWkktlu2hisD12FQFYSkR29TAJT
         LH1R9Pot7fCnjrbI8+c1sLGDG1QxcUxmHT1viqhxlbpmcYRwfmC1bTbrrOdOZDH6A81E
         Mb/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=fPDqjeCYEjf+DN+kHXgg7jNjsfy3nUCqOTZJ2Nh3G0E=;
        b=EozWdn/V8uZD09Am5sFoAxTpYuQhwgEnz0zl3o4HUoi6mDdb60/QUhJpnXTNiA5qNO
         bpRe1B1ncOJAwlca2V4hsugLOKlh9PrjhaT8+svFjdHYcXoZE9tNb3J99fu+WdVfqz99
         ZHRA9yVhRE0jCbaEZ+X+Re+KBPoFmlDWXuDOTb6/GHHjD7criBZUOWnThsqxhDYLuauG
         uY3kLKyiPq6pEf8OeOvAMyGmVOPRPM33Jg28cmX+VzvZsnJEZmyz8OiXYO/VWzXtzp9V
         Kjnd3c9+3za9VK6m1qFppbb5TOkUMF4kI+qQxZ5iWjQ+PvOwaYdfayLng4PeLQlCvDgO
         XNDA==
X-Gm-Message-State: AOAM531Qi/+ia+LHYnnHq2TmGEDEQtiWSkIWV5btZ33JiTNyA/2Exibb
	+SQ2XLuf7GIvF5nA6b9UKYQ=
X-Google-Smtp-Source: ABdhPJxIWfLkEULnkeRFIBU63iisgF81a9TeLyav941iTQFUBwsy8Hw5dIc9QJtmQkp/rhphX9SNLQ==
X-Received: by 2002:a2e:9698:: with SMTP id q24mr26147048lji.246.1639343042868;
        Sun, 12 Dec 2021 13:04:02 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 14/21] x86: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:03:02 +0300
Message-Id: <20211212210309.9851-15-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/x86/kernel/reboot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index fa700b46588e..c3636ea4aa71 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -739,10 +739,10 @@ static void native_machine_halt(void)
 
 static void native_machine_power_off(void)
 {
-	if (pm_power_off) {
+	if (kernel_can_power_off()) {
 		if (!reboot_force)
 			machine_shutdown();
-		pm_power_off();
+		do_kernel_power_off();
 	}
 	/* A fallback in case there is no PM info available */
 	tboot_shutdown(TB_SHUTDOWN_HALT);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:07:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:07:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245741.423957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW3f-0004pn-FM; Sun, 12 Dec 2021 21:06:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245741.423957; Sun, 12 Dec 2021 21:06:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW3f-0004pg-CG; Sun, 12 Dec 2021 21:06:59 +0000
Received: by outflank-mailman (input) for mailman id 245741;
 Sun, 12 Dec 2021 21:06:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW13-0004MP-Tq
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:18 +0000
Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com
 [2a00:1450:4864:20::131])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 115e7a09-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:17 +0100 (CET)
Received: by mail-lf1-x131.google.com with SMTP id b40so27417593lfv.10
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:17 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.14
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 115e7a09-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=LnM2oqI/P3qkpx3c1EWtD4sLNI6B6gG/+oTBL+kWCNQ=;
        b=Ti+UtGG8XV6c0zOWqrHGbE59RojWkw4ydpgjMyPnKydCS+/MWggp7Pc9vXP3/dSIcd
         3jnWTMBd8zv/qBtjyyIl9yIZVhT8x6fyMjQXI7luWmrCTc61AVDnaWwsG+mIfuPQO9dB
         vcqOllWLO88CRGpuT6+xXO8ZmzEOzeGTj/s4L1fT4s6+Ybm6rqbTcVdA4UXyNrivjGv5
         UJ6UviXyCjmc4b8nSyi1dpErcal2pEnmBKVfp4o/3mh7A8Qp+zHAUZCcABQgpQssHyoG
         UiW2FFO7QpKrXAOmKzFmfqtuBRyQuxNiF7hVzSScTIX4m9O5uZ05fsLoNM2XxAyyofSA
         atBQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=LnM2oqI/P3qkpx3c1EWtD4sLNI6B6gG/+oTBL+kWCNQ=;
        b=LMFRYoIWTDpTUWtdDv/uvo8Eg4mVOvEoEMZREIqN9vuFxhbRt9r2Gc9292gOb4GxHp
         AydJwCwvAYilfieFA+HbV5fHunl/xINKGKNyYnuMxBCvESewnCaxxsrCS97s3qoSCjoj
         RBpR4GmIuPTMVcZtS2JTmtIKp2ctRDx9LIIYHLK+vxha83MKR15vhPb2uOXTeOz2eBuS
         CQi2ER0yljR/taSCGvKK9X3wf7dp8etrUlEXWpzXb9MDXRe/HPl+KqLeKbyhxb4EZ30X
         rGfb4xlA2fnpZVzIJZhsOtN2WE0SQsHyoj2MN7Y7daOz2oDT0Qeb4uMfrZiiGok+QMd8
         NwxQ==
X-Gm-Message-State: AOAM531GJkMWc+gu11TjVYHF363mYAIwp6E1Fcml+dI8ZZPPdyP62d7Q
	XT8LeHJHDtdQbz9zB6OOVOc=
X-Google-Smtp-Source: ABdhPJzqEv9dTDNrIB5aKtlnsJyeHcmVeske90TevqdWeeks/wIjllK9zuSKBLKrf6g7j5l1fLZDZQ==
X-Received: by 2002:a05:6512:3c9e:: with SMTP id h30mr24792667lfv.212.1639343056911;
        Sun, 12 Dec 2021 13:04:16 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 21/21] reboot: Remove pm_power_off_prepare()
Date: Mon, 13 Dec 2021 00:03:09 +0300
Message-Id: <20211212210309.9851-22-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

All pm_power_off_prepare() users were converted to sys-off handler API.
Remove the obsolete callback.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 include/linux/pm.h |  1 -
 kernel/reboot.c    | 11 -----------
 2 files changed, 12 deletions(-)

diff --git a/include/linux/pm.h b/include/linux/pm.h
index 1d8209c09686..d9bf1426f81e 100644
--- a/include/linux/pm.h
+++ b/include/linux/pm.h
@@ -20,7 +20,6 @@
  * Callbacks for platform drivers to implement.
  */
 extern void (*pm_power_off)(void);
-extern void (*pm_power_off_prepare)(void);
 
 struct device; /* we have a circular dep with device.h */
 #ifdef CONFIG_VT_CONSOLE_SLEEP
diff --git a/kernel/reboot.c b/kernel/reboot.c
index 3085873a876f..2f79d4f7cfaa 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -48,13 +48,6 @@ int reboot_cpu;
 enum reboot_type reboot_type = BOOT_ACPI;
 int reboot_force;
 
-/*
- * If set, this is used for preparing the system to power off.
- */
-
-void (*pm_power_off_prepare)(void);
-EXPORT_SYMBOL_GPL(pm_power_off_prepare);
-
 /**
  *	emergency_restart - reboot the system
  *
@@ -829,10 +822,6 @@ void do_kernel_power_off(void)
 
 static void do_kernel_power_off_prepare(void)
 {
-	/* legacy pm_power_off_prepare() is unchained and has highest priority */
-	if (pm_power_off_prepare)
-		return pm_power_off_prepare();
-
 	blocking_notifier_call_chain(&power_off_handler_list, POWEROFF_PREPARE,
 				     NULL);
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:07:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:07:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245745.423967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW3v-0005Ij-Nq; Sun, 12 Dec 2021 21:07:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245745.423967; Sun, 12 Dec 2021 21:07:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW3v-0005Ic-Kk; Sun, 12 Dec 2021 21:07:15 +0000
Received: by outflank-mailman (input) for mailman id 245745;
 Sun, 12 Dec 2021 21:07:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0w-0004MP-Ra
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:10 +0000
Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com
 [2a00:1450:4864:20::231])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c8b9814-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:09 +0100 (CET)
Received: by mail-lj1-x231.google.com with SMTP id u22so21071342lju.7
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:09 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c8b9814-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IgdEY3brdUGAcbkVUTuopyRaDKQjmT9IOiG4donLZPs=;
        b=pRjCeelZEbxaZGwO+A2aL0XPV/VaH02YaHpKAd9wdI9JEveM57sE60GJ6XNHSn3X7R
         3k3prwg00aYmbn6qrs0hvCC/Qu+NXBudxBQ11zdQ8NwOHe1318/leMZcgjGjBHY51gwa
         7soXg88k1YVhJkGc+TTtq+bVpeCDRCSSMfOlkqSinKAC0bda9LJdWsfx6/W5MHM5/jd9
         DvPUXfjXzCMkaPG3Qy81MLfolhXJsYt+NP13KnN+kkNkRrGfJb6pVBACzy9He8+wQu/l
         eGVwkctUMedEHbT7ecy6K+YGcbliElewyWmMiaaA91DPydKzN7z1nc6/16QB5Y1JZoWn
         FbWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IgdEY3brdUGAcbkVUTuopyRaDKQjmT9IOiG4donLZPs=;
        b=DYvQGhKQEqZlMwqs8+FBeL8W24XZWBHOp3Ug14gJD4LMevqbw5Ko32A5SW5eb2gPPN
         1IWBx0Iy9Hsvq5CGRBu6whjeP0gWDN6aHZDAIjYuWcA+xSHaeUmzrjD25tPUGxVN8aFX
         5/yib/FS72Gbml6rrVUX4gJkOY0uLh1wAb/+VlvpYvP506enWnXNEO5r6kEZ0ppBUjoz
         UtK9+C8S015bEHPS+nNEXyU1r05e6ZQST5pkfwYFEC1pevWRQyvbySBSXGcPj9ZSDr4r
         DbfGMGpWrw7oG2v7feLF6ZwD4hI0GENYVq22evsclbVPK1OTHlSLgaB4GjG0q8FML/VI
         1zrg==
X-Gm-Message-State: AOAM530FAR88qYC7BQlcfTnRWhXe+PVcrweJ+GU7OPK9a7y+mX+zdXK1
	+9lC/AfJxToO6zA0skD+lEo=
X-Google-Smtp-Source: ABdhPJxNW1DwCShpX2NDWOWr5vcKraTuFYIWDWgUXB6EPWJrHuuBITafm/NNerVkSN6nEKqLT69IWQ==
X-Received: by 2002:a05:651c:1548:: with SMTP id y8mr25360872ljp.458.1639343048830;
        Sun, 12 Dec 2021 13:04:08 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 17/21] nds32: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:03:05 +0300
Message-Id: <20211212210309.9851-18-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/nds32/kernel/process.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/nds32/kernel/process.c b/arch/nds32/kernel/process.c
index 49fab9e39cbf..0936dcd7db1b 100644
--- a/arch/nds32/kernel/process.c
+++ b/arch/nds32/kernel/process.c
@@ -54,8 +54,7 @@ EXPORT_SYMBOL(machine_halt);
 
 void machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 }
 
 EXPORT_SYMBOL(machine_power_off);
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:07:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:07:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245746.423979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW42-0005iZ-Vz; Sun, 12 Dec 2021 21:07:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245746.423979; Sun, 12 Dec 2021 21:07:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW42-0005iI-SZ; Sun, 12 Dec 2021 21:07:22 +0000
Received: by outflank-mailman (input) for mailman id 245746;
 Sun, 12 Dec 2021 21:07:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW11-0004MP-TM
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:16 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1022500b-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:15 +0100 (CET)
Received: by mail-lj1-x22b.google.com with SMTP id v15so21170325ljc.0
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:15 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1022500b-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=rkacp5n+z0D4++qm+Vz/WWDd0s3O3Dw6o+6i9hrIfWs=;
        b=e0sgLnYGWIpOhM1Tq0k5rzmw3sXPnMSv9iU+hJCVf1d2qA5Nwls6W/GgRoNwqoAvw1
         tXT4+RbqrP9lew0eQNLLVzr4Tn+/KG9vRK/h96X4lUdOVI3M30MHlygIEFiy7aG9PDpO
         FDB2lByxNjeAeQWlHhuXbfsu9GBOqKvBNAwh3U2Q+VQHIS07A052FUQ8qjiIdASg5Qw+
         bnUyYW2iPbQO/bwcFcC3Y3ZipEfgzZ9AKMiF5jIjxgBowJhAar6aptmeM5855rWbA81O
         OPgm6OMSIQk0izvbI4XDkhUGKMOQBJnNhuVLas8oeZvdOzzR4Cqk4Od9cWRX0+RaAnjM
         j/tQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=rkacp5n+z0D4++qm+Vz/WWDd0s3O3Dw6o+6i9hrIfWs=;
        b=C94m6Rlf6fOHGnirFBH2ZkS9RYttt1DV9QLzgO+xxgWFAWTB8HZIUEfvl+Bg3OYm54
         FR+WQq5XL9GeHBMMja21yt6J2YYIKoUfNo5Yd7xy68l/1wwYTCVv0wV7XqObI/XyTRtj
         PneEU/81RR3V6TPW4cCuqXqOjPhcJoLjy1uKgrRH3maWqLug6pC0U4Y1kzIXAGjgV9vC
         njaTWEz7MH0KUTL09uK5e2ALgl9tlNVJxeiCc2zdnMZWpzZbrJl4JW7JBwUHU7tnVaFK
         +hLq0jBcJpNuFsi+D4jkp2t+V9UzwFnvvS88ay5fbu6J4XmLNZuzbd5uEBr2MjiEdWaJ
         yEcg==
X-Gm-Message-State: AOAM5318a0FzKaFkKdZ/wjkluF8pAkO5IvpLiSoc5TEcXpx7I6qHMBH7
	P1HHUAR0wcEMFvtLKCi5tHs=
X-Google-Smtp-Source: ABdhPJxKA9uwDzy9sxWunFq5w+Qai9KQ5v2gbDC4ae5Qa508HXOmLzyx/bTP66jD881V2IynnIuisQ==
X-Received: by 2002:a2e:a305:: with SMTP id l5mr26154909lje.73.1639343054860;
        Sun, 12 Dec 2021 13:04:14 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 20/21] regulator: pfuze100: Use devm_register_sys_off_handler()
Date: Mon, 13 Dec 2021 00:03:08 +0300
Message-Id: <20211212210309.9851-21-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Use devm_register_sys_off_handler() that replaces global
pm_power_off_prepare variable and allows to register multiple
power-off handlers.

Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/regulator/pfuze100-regulator.c | 38 ++++++++++----------------
 1 file changed, 14 insertions(+), 24 deletions(-)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index d60d7d1b7fa2..2eca8d43a097 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -10,6 +10,7 @@
 #include <linux/of_device.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/platform_device.h>
+#include <linux/reboot.h>
 #include <linux/regulator/driver.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/pfuze100.h>
@@ -76,6 +77,7 @@ struct pfuze_chip {
 	struct pfuze_regulator regulator_descs[PFUZE100_MAX_REGULATOR];
 	struct regulator_dev *regulators[PFUZE100_MAX_REGULATOR];
 	struct pfuze_regulator *pfuze_regulators;
+	struct sys_off_handler sys_off;
 };
 
 static const int pfuze100_swbst[] = {
@@ -569,10 +571,10 @@ static inline struct device_node *match_of_node(int index)
 	return pfuze_matches[index].of_node;
 }
 
-static struct pfuze_chip *syspm_pfuze_chip;
-
-static void pfuze_power_off_prepare(void)
+static void pfuze_power_off_prepare(struct power_off_prep_data *data)
 {
+	struct pfuze_chip *syspm_pfuze_chip = data->cb_data;
+
 	dev_info(syspm_pfuze_chip->dev, "Configure standby mode for power off");
 
 	/* Switch from default mode: APS/APS to APS/Off */
@@ -611,24 +613,23 @@ static void pfuze_power_off_prepare(void)
 
 static int pfuze_power_off_prepare_init(struct pfuze_chip *pfuze_chip)
 {
+	int err;
+
 	if (pfuze_chip->chip_id != PFUZE100) {
 		dev_warn(pfuze_chip->dev, "Requested pm_power_off_prepare handler for not supported chip\n");
 		return -ENODEV;
 	}
 
-	if (pm_power_off_prepare) {
-		dev_warn(pfuze_chip->dev, "pm_power_off_prepare is already registered.\n");
-		return -EBUSY;
-	}
+	pfuze_chip->sys_off.power_off_prepare_cb = pfuze_power_off_prepare;
+	pfuze_chip->sys_off.cb_data = pfuze_chip;
 
-	if (syspm_pfuze_chip) {
-		dev_warn(pfuze_chip->dev, "syspm_pfuze_chip is already set.\n");
-		return -EBUSY;
+	err = devm_register_sys_off_handler(pfuze_chip->dev, &pfuze_chip->sys_off);
+	if (err) {
+		dev_err(pfuze_chip->dev,
+			"failed to register sys-off handler: %d\n", err);
+		return err;
 	}
 
-	syspm_pfuze_chip = pfuze_chip;
-	pm_power_off_prepare = pfuze_power_off_prepare;
-
 	return 0;
 }
 
@@ -837,23 +838,12 @@ static int pfuze100_regulator_probe(struct i2c_client *client,
 	return 0;
 }
 
-static int pfuze100_regulator_remove(struct i2c_client *client)
-{
-	if (syspm_pfuze_chip) {
-		syspm_pfuze_chip = NULL;
-		pm_power_off_prepare = NULL;
-	}
-
-	return 0;
-}
-
 static struct i2c_driver pfuze_driver = {
 	.driver = {
 		.name = "pfuze100-regulator",
 		.of_match_table = pfuze_dt_ids,
 	},
 	.probe = pfuze100_regulator_probe,
-	.remove = pfuze100_regulator_remove,
 };
 module_i2c_driver(pfuze_driver);
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:08:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245755.423990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW4k-0006d6-Bw; Sun, 12 Dec 2021 21:08:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245755.423990; Sun, 12 Dec 2021 21:08:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW4k-0006cz-80; Sun, 12 Dec 2021 21:08:06 +0000
Received: by outflank-mailman (input) for mailman id 245755;
 Sun, 12 Dec 2021 21:08:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0s-0004MP-R6
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:06 +0000
Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com
 [2a00:1450:4864:20::12e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0a26dcfb-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:05 +0100 (CET)
Received: by mail-lf1-x12e.google.com with SMTP id bi37so27480557lfb.5
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:05 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0a26dcfb-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=jIixMSKlDuHM/ROsyXYWDI0GhGtBfDPAGuo/NFEP3H8=;
        b=hrGVAHE56JpFf7T1U0arv4PmuX7CbiQ1yLnbkKYuXMHBz+H3yb3VN2/nIyUDqephff
         QqKz1o3ksHyfMD3DtBk4DYltiAcjPD5RzT6wcBtuIMufZ2IM1Vel7z+a1Exa8MHUOxuI
         Dt4mQ6Vnuxs5g7ALA4qb9IZybJQfrWTEvo8JdYZtrfc8/kHvvuQX3Pn7PZtd57VOGXgj
         0YqHm4SASgoJmXMLGsZ/pIqqXI/HfsjVI1++/o/84XkQkMqRzS2O9gDjhujVp11R8QEK
         S6qzjMGucoD6LjpSZw60nGaKCWanFs77owbTLZZY3Or/CEpJJw8lyGS/ALFLDgBppTYT
         hA9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=jIixMSKlDuHM/ROsyXYWDI0GhGtBfDPAGuo/NFEP3H8=;
        b=N7J2vZ1mb4V3tf5S/M4cvqw217JoIZqHlVIQ3Zq/hbQv5Pdsv0Xne5ozGQZe0iCSav
         nlHWs+YdR+XNw/pJW5qykvT062fHLHffc23HfuLGa5bQdbYTmI4n+c5icCDFNmVvlAot
         6qjYPSLzD01gIOPp7zzBDLCP0phq4YICJ0JnqLeBaLjpsSe8xgj2RNDhTGgdU6uOK2Ra
         pdSi73xKtRpmSf8ksVMKPqtLjo/W4QwUgNZAgXBFrbiEe1lpccOvZ19WiK0y5dWFFlcc
         m6QZXAIExBJoSlWGHsUEyifdb33dslu/Al+SvXm+tm807yQ9Z9wxHMz2H6F5erACblb1
         4ulA==
X-Gm-Message-State: AOAM532wePIPT1UISNTiyPw/qDrODGPsvFXWPrxS92K++NuzpHjRVUdw
	YR5/cXBBmDE2mOj73IN1RGI=
X-Google-Smtp-Source: ABdhPJyGhLtLr0TWgn93QxuZFfYOb4V/87m+HVEQhOkYVUOBLQiR21oi6QbMq+Q/ve+fVLOCMbRPCw==
X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr25740519lfb.677.1639343044820;
        Sun, 12 Dec 2021 13:04:04 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 15/21] ia64: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:03:03 +0300
Message-Id: <20211212210309.9851-16-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/ia64/kernel/process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/ia64/kernel/process.c b/arch/ia64/kernel/process.c
index 834df24a88f1..cee4d7db2143 100644
--- a/arch/ia64/kernel/process.c
+++ b/arch/ia64/kernel/process.c
@@ -19,6 +19,7 @@
 #include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/personality.h>
+#include <linux/reboot.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/hotplug.h>
@@ -599,8 +600,7 @@ machine_halt (void)
 void
 machine_power_off (void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 	machine_halt();
 }
 
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:08:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:08:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245760.424001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5E-0007JI-OI; Sun, 12 Dec 2021 21:08:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245760.424001; Sun, 12 Dec 2021 21:08:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5E-0007J9-KR; Sun, 12 Dec 2021 21:08:36 +0000
Received: by outflank-mailman (input) for mailman id 245760;
 Sun, 12 Dec 2021 21:08:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW10-0004MP-5r
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:14 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0ee48520-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:13 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id bi37so27480851lfb.5
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:13 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0ee48520-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=mfpn4GjmPLTNTnhqDUdqufcuPWBAqiXi1zu9JyEbhbk=;
        b=W//sZogq5DTrQ+VT0kVHAjKsMJjonmiTqPPUjDT4t1ux8CgKvrkOa9X6q03Nt3iZO1
         vK/CUo6x7lvuguglmwFE90u1GLXTECmpRMuaG+fr/E6/qyGV8EkU6v+kDK+V7uptl/wb
         HR4Vmw8wUQIABJOLJFGHdK+fNltSfOyFeExxxDa+sfUUZdkfFyFDhmbRR41HvO1R/q2F
         QgB34LqslNlnmvIz0QFHIdfbw4raMLU07LE3ousDHeswLZ4GtLDTJS47wVIBYkWvvQPk
         nOdfyMtdzf0521x2E8c6ZMEWXW3EHh5oerHQGQm9FvsWNypd0dn/oX5dpjU5q537TqNc
         uvCw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=mfpn4GjmPLTNTnhqDUdqufcuPWBAqiXi1zu9JyEbhbk=;
        b=42c1caMo3I8YY6dTu2gxwdapqh8jlxWcgEQ5ahJwnwzIjTSLMhnbU8EeczQqWELA7y
         9Hqn30KHJaGx8OUC+CilRhpSXufImpapg2/jUX06dm6QAlDporVIB2ks5UqxU3/ocHi/
         NhE6mILhUYx3Zw2oqc9SrABXeeUX33c8aZ/yYD9GbJzpB36oIzmv8JMuPdu7LPp7sSnB
         SgSxrXG+KXwi2rAeomD93YW3FKiK8YEQOh0U+X9iFjUqKLtTTUV8a1W8bIZIL0XzU7jS
         PxQJun499kpgJ8sKIQeYBvBIchE6oELuayf9iAfFlfU3f4piyvtCuNrd/uez9RYY8iPD
         /NAw==
X-Gm-Message-State: AOAM5313E1VFAY056FjjvqVPO8hXJIlk1IU6Ug5zoF4n9dSUmNea160W
	0yXxW8IlmRELxxUkIKf5v6M=
X-Google-Smtp-Source: ABdhPJwCwIZWVbs7nRVgDCTh6EM5kFQafVa6fCQVhsWFKnxKFFWHHHKvo3sGM1T0VAQ3LX+X9OwfMQ==
X-Received: by 2002:ac2:4555:: with SMTP id j21mr25986961lfm.120.1639343052782;
        Sun, 12 Dec 2021 13:04:12 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 19/21] ACPI: power: Switch to sys-off handler API
Date: Mon, 13 Dec 2021 00:03:07 +0300
Message-Id: <20211212210309.9851-20-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Switch to sys-off API that replaces legacy pm_power_off callbacks.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/acpi/sleep.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index eaa47753b758..2e613fddd614 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -47,19 +47,11 @@ static void acpi_sleep_tts_switch(u32 acpi_state)
 	}
 }
 
-static int tts_notify_reboot(struct notifier_block *this,
-			unsigned long code, void *x)
+static void tts_reboot_prepare(struct reboot_prep_data *data)
 {
 	acpi_sleep_tts_switch(ACPI_STATE_S5);
-	return NOTIFY_DONE;
 }
 
-static struct notifier_block tts_notifier = {
-	.notifier_call	= tts_notify_reboot,
-	.next		= NULL,
-	.priority	= 0,
-};
-
 static int acpi_sleep_prepare(u32 acpi_state)
 {
 #ifdef CONFIG_ACPI_SLEEP
@@ -1020,7 +1012,7 @@ static void acpi_sleep_hibernate_setup(void)
 static inline void acpi_sleep_hibernate_setup(void) {}
 #endif /* !CONFIG_HIBERNATION */
 
-static void acpi_power_off_prepare(void)
+static void acpi_power_off_prepare(struct power_off_prep_data *data)
 {
 	/* Prepare to power off the system */
 	acpi_sleep_prepare(ACPI_STATE_S5);
@@ -1028,7 +1020,7 @@ static void acpi_power_off_prepare(void)
 	acpi_os_wait_events_complete();
 }
 
-static void acpi_power_off(void)
+static void acpi_power_off(struct power_off_data *data)
 {
 	/* acpi_sleep_prepare(ACPI_STATE_S5) should have already been called */
 	pr_debug("%s called\n", __func__);
@@ -1036,6 +1028,11 @@ static void acpi_power_off(void)
 	acpi_enter_sleep_state(ACPI_STATE_S5);
 }
 
+static struct sys_off_handler acpi_sys_off_handler = {
+	.power_off_priority = POWEROFF_PRIO_FIRMWARE,
+	.reboot_prepare_cb = tts_reboot_prepare,
+};
+
 int __init acpi_sleep_init(void)
 {
 	char supported[ACPI_S_STATE_COUNT * 3 + 1];
@@ -1052,8 +1049,8 @@ int __init acpi_sleep_init(void)
 
 	if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
 		sleep_states[ACPI_STATE_S5] = 1;
-		pm_power_off_prepare = acpi_power_off_prepare;
-		pm_power_off = acpi_power_off;
+		acpi_sys_off_handler.power_off_cb = acpi_power_off;
+		acpi_sys_off_handler.power_off_prepare_cb = acpi_power_off_prepare;
 	} else {
 		acpi_no_s5 = true;
 	}
@@ -1069,6 +1066,6 @@ int __init acpi_sleep_init(void)
 	 * Register the tts_notifier to reboot notifier list so that the _TTS
 	 * object can also be evaluated when the system enters S5.
 	 */
-	register_reboot_notifier(&tts_notifier);
+	register_sys_off_handler(&acpi_sys_off_handler);
 	return 0;
 }
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:09:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:09:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245767.424012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5f-0007xl-17; Sun, 12 Dec 2021 21:09:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245767.424012; Sun, 12 Dec 2021 21:09:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5e-0007xc-Te; Sun, 12 Dec 2021 21:09:02 +0000
Received: by outflank-mailman (input) for mailman id 245767;
 Sun, 12 Dec 2021 21:09:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0v-0004MP-RM
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:09 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0b56783b-5b8f-11ec-bf02-3911bdbc85ab;
 Sun, 12 Dec 2021 22:04:07 +0100 (CET)
Received: by mail-lj1-x22d.google.com with SMTP id m12so21123359ljj.6
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:07 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b56783b-5b8f-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=Cc0IUGWHitJ0Cooyguk/vAdy9iAEtCRPuqNtfJHYmrA=;
        b=Q/c1xA4uTfURNpesTFDEluAGeukAv0A39h1++QrnHKHB/Wx+jD9uvH8v63QIbUTx/0
         +6rR5eBZFCFfLub5tT4XZSawg+QmuNCEsjrKd9tJnYsJi7NapchhtdTTw5BZoWSvXNqZ
         6qalX/P65Sx1m+OSvepBjdrlXRB10kpIkI8l0kGvB4dwAOxWvQSYyQVUabX2ElBpn+NL
         9XDYXpgHW6Qi4N2A46fFgcC634zKj6WeJBReRhrYc+nPBcEHLfR4bNetpt3CSzMg8EgJ
         8HNfo2NJArfFto2I2XSFuYiZIyXwvuRmtRKx9vRDmnjHIRre5YAsG7Vp/31CfQv6ggAb
         qrCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=Cc0IUGWHitJ0Cooyguk/vAdy9iAEtCRPuqNtfJHYmrA=;
        b=4Olu7pxowGJbL4aA29jOxX/94+fY9FD7t28SgNETA7c9Ugd5L+hh0JzdvoQzzo86PQ
         4bIssSFBCV2jjhrIMbkBTReOlwWkDJ/vluf74CsbSVHb6PAiydPMZ2vXkEdsWBTlrC2g
         8QRdi7zSCaPyj7dhg92tonTM5bZtXV1oLGMEJN589Avr0ziTeTn7MmWoxzz+FGyfCwdI
         h3n7hmdUpKIIPHxI0tms/HcuDIVr98UpaRtmPRDBMP59sYRd5MTzprDiA9mWNHkhDPMF
         pIorzsyp05lhpOudt59phao7361OJu7cqYQOoSyxbrGynyR89ox9pUerpRTzJ0eL7QpC
         T41A==
X-Gm-Message-State: AOAM530SDmtfKnRR0x0fKHP8Dm1nHRCMNZJx+bCWIoEkJJLtnPA/Ddib
	wnY+c4zDEXaGREkvIhkZJxs=
X-Google-Smtp-Source: ABdhPJy9fCaXc17ytJafsM7AkKSnE1Az22GGN1LbVGAjsgQu/yV7EBxctgRg/qU3ELcpWZOjbb6Yyw==
X-Received: by 2002:a2e:a58d:: with SMTP id m13mr26702958ljp.281.1639343046781;
        Sun, 12 Dec 2021 13:04:06 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 16/21] mips: Use do_kernel_power_off()
Date: Mon, 13 Dec 2021 00:03:04 +0300
Message-Id: <20211212210309.9851-17-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Kernel now supports chained power-off handlers. Use do_kernel_power_off()
that invokes chained power-off handlers. It also invokes legacy
pm_power_off() for now, which will be removed once all drivers will
be converted to the new power-off API.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/mips/kernel/reset.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
index 6288780b779e..e7ce07b3e79b 100644
--- a/arch/mips/kernel/reset.c
+++ b/arch/mips/kernel/reset.c
@@ -114,8 +114,7 @@ void machine_halt(void)
 
 void machine_power_off(void)
 {
-	if (pm_power_off)
-		pm_power_off();
+	do_kernel_power_off();
 
 #ifdef CONFIG_SMP
 	preempt_disable();
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Sun Dec 12 21:09:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 12 Dec 2021 21:09:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245770.424023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5l-0008In-89; Sun, 12 Dec 2021 21:09:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245770.424023; Sun, 12 Dec 2021 21:09:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwW5l-0008Ie-4r; Sun, 12 Dec 2021 21:09:09 +0000
Received: by outflank-mailman (input) for mailman id 245770;
 Sun, 12 Dec 2021 21:09:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=lDYB=Q5=gmail.com=digetx@srs-se1.protection.inumbo.net>)
 id 1mwW0x-0004BS-N1
 for xen-devel@lists.xenproject.org; Sun, 12 Dec 2021 21:04:11 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0daadc44-5b8f-11ec-a74f-db008197e53d;
 Sun, 12 Dec 2021 22:04:11 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id k23so21156543lje.1
 for <xen-devel@lists.xenproject.org>; Sun, 12 Dec 2021 13:04:11 -0800 (PST)
Received: from localhost.localdomain (94-29-46-111.dynamic.spd-mgts.ru.
 [94.29.46.111])
 by smtp.gmail.com with ESMTPSA id y4sm1197172ljp.16.2021.12.12.13.04.08
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 12 Dec 2021 13:04:10 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0daadc44-5b8f-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=4OWbCpLiTrW70NMTPpPUNVkhVF3RKPzG5GTofMVph+0=;
        b=KgzHDaKUCbKSzVVjVjmP8+sBh8yyTFGc8g32/L/CqZTtjWU+bl67DHnRCd096H4QyH
         6s4XOaSGluQwDgc+dVmKnqKu1D7kSOhEjlXrEzrtwcZ2Q6khYOCVFkcX7gyuAZCct8/o
         GKaOjDdP1N1PLFZ+aDWpcbp7dkWsptVMtN5cNX5Hej6TAysWP7q7s3LkbwdIKifJDLbq
         DBlq13uFhfg89fXWqsQEKQJP8QIWXrM83lSZp9pz62Oox2A9TL+0X7jecCTLs4sLY0eR
         bZA+EOxHV1IPmvWGQHGHMNaccJSqcUQnYi94Tz8pclaCBQOzvYQS90AbFrJ5VYVBqIZo
         1x1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=4OWbCpLiTrW70NMTPpPUNVkhVF3RKPzG5GTofMVph+0=;
        b=LW+5z/foJ4iHC+qz3gAWNMHgae4BHYflMuE2BgXLmpKljutXBENvAaUbKjvnDmJYde
         1WE6VAWWWxDTNOobd503d101/6SHw9VW7Ht+WVcdCWSWfoVDsCD3VWP1IeU5xjQ0m9BG
         e1evZmO+jT5vug5D+JrngqlNY8q9ctmXCDtGvMILE19EhUOnxIdu9hZb6NNcMIleJzMq
         I/doEQpYc4cAD87AODa2iAlbJd8Jhxf4UkaW2V/pPQ9aTPCzsUZ1ANFwwrisq8I4HPyi
         cpxESBFn6zz3nOmMV+CgaJh2bNR9PXH0GkrPnnr0cKqeQjBml+KWQwKAX3bhmxpYhNO4
         +PTQ==
X-Gm-Message-State: AOAM532MPK9QB9/F1LdLZCz4ajR8S//qpuYHEr48eiGZbh5I67YfUN/e
	39YZPsqt7FAiDYIM/5zWJoo=
X-Google-Smtp-Source: ABdhPJxwwoHkHissmQJung57FYrMejLUuN6r2Ie17E9nwn+nZNJljq8V97ncmJiBjB/DC7TeE+2SdQ==
X-Received: by 2002:a2e:a78e:: with SMTP id c14mr26639117ljf.162.1639343050805;
        Sun, 12 Dec 2021 13:04:10 -0800 (PST)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Russell King <linux@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Guo Ren <guoren@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Greentime Hu <green.hu@gmail.com>,
	Vincent Chen <deanbo422@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	Lee Jones <lee.jones@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	alankao@andestech.com,
	"K . C . Kuen-Chern Lin" <kclin@andestech.com>,
	=?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org,
	linux-ia64@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org,
	linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-riscv@lists.infradead.org,
	linux-sh@vger.kernel.org,
	xen-devel@lists.xenproject.org,
	linux-acpi@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: [PATCH v5 18/21] memory: emif: Use kernel_can_power_off()
Date: Mon, 13 Dec 2021 00:03:06 +0300
Message-Id: <20211212210309.9851-19-digetx@gmail.com>
X-Mailer: git-send-email 2.33.1
In-Reply-To: <20211212210309.9851-1-digetx@gmail.com>
References: <20211212210309.9851-1-digetx@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Replace legacy pm_power_off with kernel_can_power_off() helper that
is aware about chained power-off handlers.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/memory/emif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 762d0c0f0716..cab10d5274a0 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -630,7 +630,7 @@ static irqreturn_t emif_threaded_isr(int irq, void *dev_id)
 		dev_emerg(emif->dev, "SDRAM temperature exceeds operating limit.. Needs shut down!!!\n");
 
 		/* If we have Power OFF ability, use it, else try restarting */
-		if (pm_power_off) {
+		if (kernel_can_power_off()) {
 			kernel_power_off();
 		} else {
 			WARN(1, "FIXME: NO pm_power_off!!! trying restart\n");
-- 
2.33.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 03:15:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 03:15:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245789.424034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwbnv-0008G7-0p; Mon, 13 Dec 2021 03:15:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245789.424034; Mon, 13 Dec 2021 03:15:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwbnu-0008Fz-PJ; Mon, 13 Dec 2021 03:15:06 +0000
Received: by outflank-mailman (input) for mailman id 245789;
 Mon, 13 Dec 2021 03:15:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwbns-0008F1-I9; Mon, 13 Dec 2021 03:15:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwbns-00053S-AV; Mon, 13 Dec 2021 03:15:04 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwbnr-0002zM-Ut; Mon, 13 Dec 2021 03:15:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwbnr-0000ZI-UO; Mon, 13 Dec 2021 03:15:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6GK94q1jxLvE4DREAKhUnBr3oA2kArGlMeBLqvzcuVE=; b=lCdA3W3+X4zAHG1uzB8/u2pCzs
	K2xkk753SYtgmVU9UYdIJiQ8k1521vfDLb9nfIJPsk/bgyDXL+ERcrj7myzb2zgc5FOs9EazYA1Un
	EGv7fGwbG7bsQ77xb6UUO5GcpfXw7uMERIE/pZyBWL20qmUsoHH/6raPrO1m01Si6Cgk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167386-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167386: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=90d9fbc16b691403a80a119d7094528721c03279
X-Osstest-Versions-That:
    linux=a763d5a5abd65797aec3dd1bf01fe2ccbec32967
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 03:15:03 +0000

flight 167386 linux-linus real [real]
flight 167388 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167386/
http://logs.test-lab.xenproject.org/osstest/logs/167388/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-credit1 18 guest-start/debian.repeat fail pass in 167388-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167383
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167383
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167383
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167383
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167383
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167383
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167383
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167383
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167383
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                90d9fbc16b691403a80a119d7094528721c03279
baseline version:
 linux                a763d5a5abd65797aec3dd1bf01fe2ccbec32967

Last test of basis   167383  2021-12-12 06:13:19 Z    0 days
Testing same since   167386  2021-12-12 19:40:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alexey Sheplyakov <asheplyakov@basealt.ru>
  Alyssa Ross <hi@alyssa.is>
  Amelie Delaunay <amelie.delaunay@foss.st.com>
  Billy Tsai <billy_tsai@aspeedtech.com>
  Chen-Yu Tsai <wens@csie.org>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Lezcano <daniel.lezcano@linaro.org>
  Dinh Nguyen <dinguyen@kernel.org>
  Donghyeok Kim <dthex5d@gmail.com>
  Douglas Anderson <dianders@chromium.org>
  Evgeny Boger <boger@wirenboard.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Geert Uytterhoeven <geert+renesas@glider.be>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guo Ren <guoren@linux.alibaba.com>
  Gwendal Grignou <gwendal@chromium.org>
  Hector Martin <marcan@marcan.st>
  Jeya R <jeyr@codeaurora.org>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kalle Valo <kvalo@kernel.org>
  Kelly Devilliv <kelly.devilliv@gmail.com>
  Kister Genesis Jimenez <kister.jimenez@analog.com>
  Lars-Peter Clausen <lars@metafoo.de>
  Liam Beguin <liambeguin@gmail.com>
  Liam Beguin <lvb@xiphos.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Loic Poulain <loic.poulain@linaro.org>
  Lukas Bulwahn <lukas.bulwahn@gmail.com>
  Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  Marc Zyngier <maz@kernel.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Nathan Chancellor <nathan@kernel.org>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Olivier Moysan <olivier.moysan@foss.st.com>
  Pali Rohár <pali@kernel.org>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Peter Zijlstra <peterz@infradead.org>
  Ralph Siemsen <ralph.siemsen@linaro.org>
  Randy Dunlap <rdunlap@infradead.org>
  Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
  Sami Tolvanen <samitolvanen@google.com>
  Shaokun Zhang <zhangshaokun@hisilicon.com>
  Slark Xiao <slark_xiao@163.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Thomas Gleixner <tglx@linutronix.de>
  Tim Chen <tim.c.chen@linux.intel.com>
  Vadim V. Vlasov <vadim.vlasov@elpitech.ru>
  Vinod Koul <vkoul@kernel.org>
  Vladimir Murzin <vladimir.murzin@arm.com>
  Wudi Wang <wangwudi@hisilicon.com>
  Yang Yingliang <yangyingliang@huawei.com>
  Ye Guojin <ye.guojin@zte.com.cn>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  fail    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a763d5a5abd6..90d9fbc16b69  90d9fbc16b691403a80a119d7094528721c03279 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 05:15:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 05:15:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245796.424048 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdfd-0004nw-SN; Mon, 13 Dec 2021 05:14:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245796.424048; Mon, 13 Dec 2021 05:14:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdfd-0004np-Oz; Mon, 13 Dec 2021 05:14:41 +0000
Received: by outflank-mailman (input) for mailman id 245796;
 Mon, 13 Dec 2021 05:14:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6tW/=Q6=kernel.org=vkoul@srs-se1.protection.inumbo.net>)
 id 1mwdfc-0004nj-Hh
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 05:14:40 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f57d3bb-5bd3-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 06:14:37 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 3B0C9CE0DAF;
 Mon, 13 Dec 2021 05:14:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85F64C00446;
 Mon, 13 Dec 2021 05:14:28 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f57d3bb-5bd3-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639372469;
	bh=m+MbzkCsPCJNXsBFySexaUdkbI+fIAKWZPiq+A6GBck=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=pcDQjwCHOz6BSONU5joUW6e60Mu1jAbxQzts0EfFaFm5JmSfwPYHyrXe+as4aLjeM
	 eFJH1OLum6J0MwbxxotL5Ynx/Wl9FSzFLuVcZ/MiaFGyolmZeXYP0aRrzCZjW5ZdJq
	 Yt5fu6OtnruTRf7YSvoSO+XnwngnSyHnpkVidlaQ4C6iMZ9tlspBmToBaYm7+u5kTp
	 56ZJujbc1BVH7oROt6l/x3asZi1J9mKWjGd5xEZzFFEQ0GglJh+ze5/cFl0ltz5OnT
	 HkJi0GnpAKgWw3QDQFyUKxAUiibgYJ1iBPJwPobSVKG5xk0d9X3x2zWgArHsKu4K1+
	 TCjLAS6Yk203w==
Date: Mon, 13 Dec 2021 10:44:25 +0530
From: Vinod Koul <vkoul@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	dmaengine@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 29/35] dmaengine: mv_xor_v2: Get rid of msi_desc abuse
Message-ID: <YbbWsUO6o5ccU5ai@matsya>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.970099984@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221814.970099984@linutronix.de>

On 10-12-21, 23:19, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Storing a pointer to the MSI descriptor just to keep track of the Linux
> interrupt number is daft. Use msi_get_virq() instead.

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 05:15:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 05:15:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245797.424058 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdfs-00057X-4R; Mon, 13 Dec 2021 05:14:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245797.424058; Mon, 13 Dec 2021 05:14:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdfs-00057O-1F; Mon, 13 Dec 2021 05:14:56 +0000
Received: by outflank-mailman (input) for mailman id 245797;
 Mon, 13 Dec 2021 05:14:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6tW/=Q6=kernel.org=vkoul@srs-se1.protection.inumbo.net>)
 id 1mwdfq-0004nj-9r
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 05:14:54 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9ab61144-5bd3-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 06:14:53 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 73F0EB80D7C;
 Mon, 13 Dec 2021 05:14:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58E36C00446;
 Mon, 13 Dec 2021 05:14:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ab61144-5bd3-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639372491;
	bh=zuuGW5+kS2UVDTK9JZgN0rVsKZ9vO7N+ikVVGGhcFus=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=RGfflIEVbOYzZ4L0+ZwdoUg9quAO5nOi9/UXP3Xmr9G9FMvVyrwT7jr3JP9IGaiFL
	 iDr3OkfoB6b8rQrplP3MBZ21trYA1fHZJ/P6K9OgJk7ys8npF3ZR421z8PmAzyK7at
	 mVJOPb6bRTPOptJL+XKRuXrxiPG2olj+FZeiYHjN4ZRoI7C3Src7FeNuQiJmp+bUMG
	 xPtHLVBnuBhLRIQdqXBDutn2NvWHHNDEQKnckdYO0OUOOTJAyaAkyCOddpx7Tk6abA
	 UbXFRd62tmtswrOO2et02MquRCBkv8NhukN03R6Wud8Ms+/tbnOLTtPGic26cUTGyv
	 Al/o3XGCyfNBQ==
Date: Mon, 13 Dec 2021 10:44:47 +0530
From: Vinod Koul <vkoul@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sinan Kaya <okaya@kernel.org>, dmaengine@vger.kernel.org,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>
Subject: Re: [patch V3 35/35] dmaengine: qcom_hidma: Cleanup MSI handling
Message-ID: <YbbWx1LhPEtF/9pp@matsya>
References: <20211210221642.869015045@linutronix.de>
 <20211210221815.329792721@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221815.329792721@linutronix.de>

On 10-12-21, 23:19, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> There is no reason to walk the MSI descriptors to retrieve the interrupt
> number for a device. Use msi_get_virq() instead.

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 05:15:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 05:15:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245800.424070 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdgA-0005jb-Ei; Mon, 13 Dec 2021 05:15:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245800.424070; Mon, 13 Dec 2021 05:15:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwdgA-0005jT-BM; Mon, 13 Dec 2021 05:15:14 +0000
Received: by outflank-mailman (input) for mailman id 245800;
 Mon, 13 Dec 2021 05:15:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6tW/=Q6=kernel.org=vkoul@srs-se1.protection.inumbo.net>)
 id 1mwdg9-0005g1-6P
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 05:15:13 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a512f669-5bd3-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 06:15:11 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 86CBCB80B71;
 Mon, 13 Dec 2021 05:15:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74EBFC341C5;
 Mon, 13 Dec 2021 05:15:08 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a512f669-5bd3-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639372509;
	bh=twArdFoN7hptxwDxuCRLPZ8D1bdEpmpF3bPhs8kTAGw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=l5Fm5uAniw55hjSdbzftitrFAWWz32Vx3VgWE+btKlO63m2/tFA3/bv1QYeZIG+LW
	 vUJdax7Yw6F/Ajk03jA6N9MxJNQFQPNdccFHfKQ4s7/7I4jY8J0ztiEoz3lwDMSrMj
	 Au+niCjhEXCCZiWnPCwZ+FSb9gwqJGQ9s4QAZQG78Tdq3X5hjrvbvRvVE9t2b/uMjy
	 2j0lKrOYwiYfKHJYq9myUv2AWh/KF9zOY6r3L9C4J/YMy2cBf6e8SdfVI0w4eYZVFM
	 ZP39KPOOIDsA+jVKZbJqEWZD1EDrG6T2dKX4uRjCOz2n42IAMyNd4ZGry200oP740A
	 5/0yla012xpJQ==
Date: Mon, 13 Dec 2021 10:45:05 +0530
From: Vinod Koul <vkoul@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	dmaengine@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of
 ti_sci_inta_msi_get_virq()
Message-ID: <YbbW2Ui22OeohXKE@matsya>
References: <20211210221642.869015045@linutronix.de>
 <20211210221815.269468319@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221815.269468319@linutronix.de>

On 10-12-21, 23:19, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Just use the core function msi_get_virq().

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 07:28:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 07:28:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245822.424080 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwfkr-0003Ik-4G; Mon, 13 Dec 2021 07:28:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245822.424080; Mon, 13 Dec 2021 07:28:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwfkr-0003Id-1G; Mon, 13 Dec 2021 07:28:13 +0000
Received: by outflank-mailman (input) for mailman id 245822;
 Mon, 13 Dec 2021 07:28:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwfkq-0003IQ-5K
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 07:28:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39585372-5be6-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 08:28:10 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-6wdYklEcNdeN4HtyD8y-Bg-1; Mon, 13 Dec 2021 08:28:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.25; Mon, 13 Dec
 2021 07:28:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 07:28:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39585372-5be6-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639380490;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tAmoCuDuA4Rpu4CReY46oI835jDUWPsgxCmYXHsXa+o=;
	b=VJj2vsIMi2gRAmjY7ZqumgngiYVWIhT8hNRO7KUhpl5r6DdV4FRY5Cytiz0zHghcPDUemA
	dxcZ27otSNgbMwK4ZeGhGdqHtQepMS/KHcyL+ly6BHqfI3TBcIOQNqH+kM8UYhaxrJdn5j
	GClYA6xKd66/AmqRPO5D3wNwpwQSN4Y=
X-MC-Unique: 6wdYklEcNdeN4HtyD8y-Bg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OiIpISJKBY6AmSiQIXqpjqU9mQPkTJBm9vYhqf3CUe7+fMev0TR2nIL0eCSQzfHdcQQCJ6oRXV0smNF1M6PzpSh62JBuiGdgNZntCwyCCIPZStDMdruZ3irsBplezHvsDPsDuZZaL0iLT7A/teFF6HBIvXgeRSlmmKslXOE/qaJCGlJyH+IKGaEXliz4AI70aGOSFqFMbKeKp/O9Bh0/P76g/RRM1OR3OLmTe7lFhSqTA1wrcST18DApd5zvP6iHhbJxlJvm+kAccOtS5RPI6l/r92sNDn9N84AScI7BrI8+8e0wbK6/lAEQQ7VCs7kX9n1mV4Mh2tCpz5r98uiCGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tAmoCuDuA4Rpu4CReY46oI835jDUWPsgxCmYXHsXa+o=;
 b=EBfoeoHcLlfX9VLm2gMl71/BZMZRMEbnNmXFDzFcO5igNSkoPL28iANJ59WFNHxwgPHfVjkHnbAIU9s7AfGYccWjwhzlu5VRZJirSXGMBUTEc0qKKea3bzlGneEJQDpoJqZq0aoEi9odZhcVRvPvoXcQH0FsSjCK8Isov28h07MCb3OndX34loGKy5tQQdUP98YJiF0SHBqYm3wFroR5OpKIlKXgiDsrrXRQ/jEIF57kyqxmlmnTnYGBG9HPHEH7u9KlgPaogSWUaeUwKAmS7d4AVZsGcamSD2OQXX9c/Ff2KnjBhna8FQbXg9cd0O3+NHaSGiX3qZpi8uq8PqB1vQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <078a2f3d-c188-0a28-6265-dceef41cd6f3@suse.com>
Date: Mon, 13 Dec 2021 08:28:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
 <0b68ff3a-3c82-f800-4d20-17eded13163a@suse.com>
 <612735b2-8af6-782d-35cf-526841109170@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <612735b2-8af6-782d-35cf-526841109170@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0014.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 245fbe6e-3248-44f5-1824-08d9be0a1adf
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533F4792E084AC8CD4DE36BB3749@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	r5+CpwhZSC1h7exntB4wokUdIJYYuN1oB0czD00ruOWZCLk0SDMqbYlOiWU+yzCW4bI3lxJXyb+oi//TpgswiWT9XNuEwsZ7pqmt5VvCIcIxtNJkowacUs2N6ilVMRt2w8d8LKRJNSvG9kpVkwEnTKQW/d/bGdRfERnSFDbF5DdEp4aetXlWrMxrJfBbYVuMsK2D/lt5vSN5AWJpCSoIlkAWBV5rwTqt01+5v3ho+8OIp1YOWF4wT9vFxuSVTlLlWL316U9MLe1jljMEQz90gzVN424aO/iPMMMuii3+UMEqb0ML5LZAJeOkZGSrRUKrdEkdSDDxpbaeTqvnbCCXYQjLJb4+BrIOa4lO+dWGtlOtWfDKfBB/eBKFVJp9lSieJf5/GMcQg70Ks9OaOb2wCUuOdquG5Ii6dA0aO1P7Q/nL2CXEZOqs0ZQbof3aDo8GS3XRNfPBxUWeYMC0+PdJQCMH0acWPaiC0vUgjDt9xQ5B3nWFrOglWRWTnrdB3ciRzF5oHa/HkuRNlpjef1jtDtVLHWMiGfYrp/H7nkA8nDg1U1GiDTXVL0zGLxtHWMpJrtX76mylV5VrRfGDnMXniP+0YxwPU2YEaM2zaefjv62magVp9dfKmWz/UXmEuBr4UG3rgbB63fesQeMOEsJbU3o8Om6eeb2xPNyMxZ7QAS9qeyP7OaT7XpzagOX9yfz5sbN7hl1rRiBAvBNPToRZAcQ2nZID7sh60nUwMnRgHlw=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(8936002)(186003)(66556008)(38100700002)(66946007)(8676002)(53546011)(6506007)(316002)(6486002)(4326008)(31696002)(36756003)(6512007)(31686004)(4744005)(5660300002)(86362001)(26005)(110136005)(2906002)(54906003)(508600001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YllvOVlSMVB4RkNodDhQRHBObmpMTnNHNFpFbm9OcXpLSmFwYzRQdWdZbzlP?=
 =?utf-8?B?K3gwR0V4RW1zanJxVVdlNHh4SnpXTWFHSlZFOHFIREFsOHpRcDN1bmhaK2VM?=
 =?utf-8?B?amNQNWtzZXl6RVJDYUZaNnk3TTBNNDJVRHhoUEdtM3NxWXdXVkJQUFp5cTZU?=
 =?utf-8?B?VzRNRGdQWEgvNGdFMG9LL0pLdGFBeEZvZmcxNTdYd1dmbVUyTmovTXkzTkdL?=
 =?utf-8?B?cnY1Nmk2dXZZc0VsMjIySkdCNUlwQzRWZXk1RmhxcS9wSXlJZFIybEJQdkV2?=
 =?utf-8?B?MHVBRVplVkZGeXNpUVhTMzkyVlBOUE9LbkNFUGRWcTE3NVNIUDNMbkRjS05P?=
 =?utf-8?B?c0d4MEFPdzhCemlzUENRL1hxSGZ5Z1VCV1dadlJEWXN1MlVmOUtaQ3Myb0xs?=
 =?utf-8?B?ejE2WDBBbHZ0RXRrOU0wRVluclZneUJFdHRXWjNsVHJncWwxbWRHZUNLRFBv?=
 =?utf-8?B?N3hweVpLak5ha3Q1MEt5a2U5WFBuNDJFUmZpRForajFPZzlMVHdtb2JQclJa?=
 =?utf-8?B?djdGL1BOWnN6QmcvaXIyWE8xRUFiNFgrVElKMlFVQ1hrd0pNK0N5OGFFN0RS?=
 =?utf-8?B?V1k5M2U3TkxQZFdLKzljZmR0K3BkL2ZJSmJlNlhsZkNoUnNIU2lFRmd4THFo?=
 =?utf-8?B?ZlM3NnFGY0puOE5uM3ZXY0RWOFA5c0RjWGdqWjNmS1J1VUFNTC9QM21JOVZT?=
 =?utf-8?B?R2dNZzFJLzZwNjNnUlZkRDZJeXBZVTd1MldZY2crYThjRkNQdGl3YnRiYnc2?=
 =?utf-8?B?MHNPdWxLUncwYmVGaHJuTHg0clpPYVNrejlyRE85ZmxoUy9jd1AxNDdmNzd2?=
 =?utf-8?B?OTU1Q3lndG41YWpSYXZ3ZTBlME9EczJ5SGdjVkZWdUt3VE1MNFFQaFZLRmFL?=
 =?utf-8?B?SkF0UTdzSThqL2pJQ3JHcDQwcVk3RWYwdzlJYmZsejRlVmxSMDNnZmgzYnMz?=
 =?utf-8?B?Mi9tUVZacVBVei9pNEV4aERKMGZwSlEyT0Z6Zkl2S0hkWGh0TVlSYXFCclJR?=
 =?utf-8?B?T2tzTTNuQXhDUFkvbXUyUFNOK2txVi9tWVBOcjNSUThTQUZ1YWZzRnNVc0xs?=
 =?utf-8?B?WVFGdjYvVWtOTGh0Rkw4S2FMYVdQVVA5TDl2MzV2U2pEaHpkTVpwbzg2ZVl3?=
 =?utf-8?B?TllaL0IwTUJQaFpCL0lwaDhBbHZJcUNvSnJhWERJTmhtay8xMlB3YkxCRFZ3?=
 =?utf-8?B?WXhTVzVOSWlERE1LWkVFa3kraHRDbERreW9EVnlNUU1ENk9hRGttRkhVbVBk?=
 =?utf-8?B?cVNwbENxS0tUelJZMExaT3d6dDVEQ2ZMUDBNdjFmMVVzWHNVTWtJbjdPOFhy?=
 =?utf-8?B?L1ZzZDVOQXc4cW4vZ2JJLzlaRzA3ZEIwRjFpUnRKM1dSVjVuS1d3d0U1Tzha?=
 =?utf-8?B?blQyTUNhZVhzVnpqWmFhVEUzMGlNaFkvazRIcmpsczNCS3hYY3hkZk1xUXR3?=
 =?utf-8?B?OUVLRTNmdHVFREI3dWx5RWtSVjhFc0VmOTZnVEoyQy94aFBFejVreHpPdDcv?=
 =?utf-8?B?aVBYampnd3h4a3V3RUgzSHJOL3hNVmZaeWliVktPS1loZ1gzdnVCc1FpZDBK?=
 =?utf-8?B?RVlHRVJTd0xIaHNDblVrWGk0anZ0amIxaHdXenphNkZETGpINytTRTNPb3RW?=
 =?utf-8?B?RU5NZEdUMzhoU2dXZHp3YTVsOFlBUytaWXlER29ramZra1VwbGVZdGJ2TVdm?=
 =?utf-8?B?OEJqMHh4U282c2puQm1PQ25xM1dtTnZmdDY5RFl1RnBlaFg4MkpHZnJ5cko0?=
 =?utf-8?B?Um1QY0hqRElxQm5ZM1NkdmNYejJpYmxJMXUyTkVLS3NmYlZBbnlqaUxZTXo3?=
 =?utf-8?B?d2dGNDNPcm1nUlFXdFAwak1vUmMreTNRTElIM3pPQkxhYW9PVVkrNno1ZWlE?=
 =?utf-8?B?RmN2VmkzRHllUitXaGZlK2FGa1NXSlF6djhJUHFYS2tXZDZrc0dTbXZhbEgz?=
 =?utf-8?B?NWgvSEUxNFBoVlZMNTVVaU1XMEQwRUtmTHBsRzZsWlpON3ZSMmNkOU9tZng5?=
 =?utf-8?B?clRUamFtNjVNWDQ3Y3QzdndaNG9XaitBTkIxNzl0NXFCYXVqZU1McnVhay9O?=
 =?utf-8?B?clJCa0VadDQwOE5tNUQ0bm01SEhsTWx4N2srSkVSSzdQalU5Y3lpQzgvQmFh?=
 =?utf-8?B?eGhzRmI4RHkrdnRIWkdwUTFDUkhqeHdNcmovc2pRY05Ld2RVaU9pN3ZiRVJP?=
 =?utf-8?Q?EK8T5IygXsSOi5wWbVjpW2U=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 245fbe6e-3248-44f5-1824-08d9be0a1adf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 07:28:06.1133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bYLE7QAe3jVzuGUlAZMQP/slGdu4kT1UjcfDJVhf8g7QfBIbnKwX+iTLw2HPCfoIxI0dj7EtvK00TOvHM+dUPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 10.12.2021 15:10, Oleksandr Andrushchenko wrote:
> On 10.12.21 11:40, Jan Beulich wrote:
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -1479,7 +1479,7 @@ int xenmem_add_to_physmap_one(
>>           break;
>>       }
>>       case XENMAPSPACE_dev_mmio:
>> -        rc = map_dev_mmio_region(d, gfn, 1, _mfn(idx));
>> +        rc = map_dev_mmio_region(d, gfn, _mfn(idx));
> Technically this is ok, but reads odd now: the function maps a single
> page, but its name has "region" in it (which might also be ok, e.g.
> for a region of a single page).
> 
> I think it is worth either implementing full mfn range check inside
> map_dev_mmio_region or renaming it to something else:
> with mfn check map_dev_mmio_region will indeed be able to map
> a region consisting of multiple pages and perform required validation.

Well, I had no maintainer comments on v1 regarding the name. I'd be
happy to rename to e.g. map_dev_mmio_page(), so long as there can be
an agreed upon name before I submit a possible v3. Julien, Stefano?

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 07:32:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 07:32:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245827.424092 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwfof-0004f9-MA; Mon, 13 Dec 2021 07:32:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245827.424092; Mon, 13 Dec 2021 07:32:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwfof-0004f2-J6; Mon, 13 Dec 2021 07:32:09 +0000
Received: by outflank-mailman (input) for mailman id 245827;
 Mon, 13 Dec 2021 07:32:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwfod-0004ew-Q0
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 07:32:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c5f4d6f1-5be6-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 08:32:06 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-z-bm8rxPOpyX3Gx_qo75MQ-2; Mon, 13 Dec 2021 08:32:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3773.eurprd04.prod.outlook.com (2603:10a6:803:1c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Mon, 13 Dec
 2021 07:32:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 07:32:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5f4d6f1-5be6-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639380726;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TIzL6DtSRiTHTvxG3MpCmSUNjQ351sIP7nXdVMcDQRU=;
	b=HMMJmbuj5MVhC/oiqE9sh9IhJYjy9uA+fX6nrD8g8ZFiXYMWxFfvxc2tMiyUr1MDciL3WR
	qKllK5kw3wZSJFiLVPCsbdguEJXp1POvV9FZh71Um48XKfrq6Usrn8qWb4Ok9wYDiA/t0J
	/5wfbVVLMpbb1zzXdGosFuNHJUC5+rA=
X-MC-Unique: z-bm8rxPOpyX3Gx_qo75MQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HuU7snKsG9d6HVzXvxJl8IWpUp+KZO2cgbhc5quK/KFS+8rK25R3Onss9aDCjUogRY86wrwDfi33BeeIvxLztOUNdlM14skFcgEsGRx23EnoYsU/Fqdrl5or0Cj3dSYP1qUNqiUoejZ84wrtjJ7Oz/I0yXpJIn5nQfd97/gnEVg8vLNsvraUlnFvkWAkZzp4cahLA+lEX1HJwE4/e+ZsiewmVnlZoIXc1LBo0eNVLDL+21DjsQGY1CcCAZbKfgyIX0gH4YQKW5P6QRkiG6brlYKqwHzGUQgNEiHtnwZ0cZks7MMt2YapWYllLt09FCwo45c52YKdh61hLNBpgEdDOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TIzL6DtSRiTHTvxG3MpCmSUNjQ351sIP7nXdVMcDQRU=;
 b=PT9UwP2CKT33U6LmiuEed97Ym7Od6qOz+eeZ2NfPtTDI8IHr+Bk/fKjfJwzhYvdn7J8AHRJHXDnkWEMm4pucafZ5l6QUXtxuBmtL0HqOVvq45q/nyg1XZrLvEWooTkcp3TxTHx9k57sY3/C8TNjeg2HKxCZQpuh02FPegk/da+q/HPKxXUlX/NJbGyx2ticE+3//YdVjmKjj05zY7fObDsZgcLzVMtkUFLCJvh/blr6txeeexffPUKoy6EdSd+vp6bVgbvBSQnokIdGneWirktH0eYKDQTAWemjaffri6JRaLUQzV7OrCBbvyiR6MLFn0uonzyv/eNOw4rzwRkm+Bw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <10705d67-b51b-76da-555d-20edf5d5d747@suse.com>
Date: Mon, 13 Dec 2021 08:32:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 01/65] x86: Introduce support for CET-IBT
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-2-andrew.cooper3@citrix.com>
 <69d1b4a3-a042-c2c4-2f59-ea897886ae1d@suse.com>
 <e7f8a52a-5761-88dc-97ff-6c2feca2effb@srcf.net>
 <566dbf20-2881-80ac-eafd-57ac4b217f0f@suse.com>
 <44707bed-ceb3-377b-f2b3-9864b7fa4e97@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <44707bed-ceb3-377b-f2b3-9864b7fa4e97@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0115.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::20) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a0e2097-5ece-425c-6619-08d9be0aa848
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3773:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3773B3600E0ABD2A52A6A65CB3749@VI1PR0402MB3773.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QNW9qxHxIXNsfmaaOU1NkRAGXa3Z0O2O0874zJbwlbwIRyW8jnaVfeU1Tl9koPPJ6w2HKFIFngP7jMzxkm+XrLNT3E4TanrquyLPY9tODSJ5FBljhZoYMJIlsrB4L0VwpE2otxRNtM1avD5qs5uNIfn7fTrDiNfVO1yHJQFimtOgKXSu9HFM3jYoRA/c+4FQCA+z3NUfYTDVyOW2QJzNyB3MjtMlamnS7tVZLESR5oR8fVIk9+MbGhWu1MWDb1afuiS38ke+zKcX/6lKJZbXtdPdoNDvXoFIqQciix5n3IckbtPGxv1DYuqwjTg3M6KoId6+o8oqG4IGxZAoCoj0x9Uhmjam/Ey35rqmpl2hZfpypQ2EY4ruhxz7sq3w88cRDaP6xNW76ybvkXNPrddwRBX8jIwd94ujtJaGZVRlYgMfnYhFaoQhYMGveRbtMdXhAymBV1ia6ze5Xtygvfu40bssYGE6j7rGyn1wK2v4XMx2KVBsqqGmtvB+7XBnbWw+o6Rd/aUGroUUbDAqQxsSjWkPURF4qzGuenOkNdrIpe1u08itqdmFtK0tvKRXtpArThS4LxffYFFeH2yPpgnfHz1xomSzTifuO/fQSc8816eq1AJLI1182KG0H14c6AYO9SWl4rdklypQ/JX8z5eRfSvwLZrxe1B9BDmgY076z6kl9OoKLcdO8vCd7bynwgbeXvrlAeqpMW8t1G6cZL1XBwNhySwQ/M40coUH4+fJsdUBTtpf5NnEGw21KOXIkiLA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(54906003)(83380400001)(6506007)(8676002)(6512007)(31686004)(86362001)(53546011)(2616005)(66556008)(110136005)(508600001)(66476007)(66946007)(38100700002)(186003)(2906002)(36756003)(316002)(5660300002)(6486002)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TGpHT2xrMDBSVzFDamxSTVpsUDBuekVHRTA4dy91MU5iQ2J1K2RSRDBWc3BO?=
 =?utf-8?B?UVUzb1BTVFgzdTI1bmhjRjVQcHBlcUJlOEt6aGJsNG1kMyt1S0ttaGwvMlp4?=
 =?utf-8?B?TkNiMHlESHUrV2o2Z3JTSUxoMDQzQ3lpYlI1ZFhRaWMwdEtjWHFEaTBhaGFv?=
 =?utf-8?B?N0hhWkVXUWRnL3RtbVh0UnJlOUdLU0dBRWxyQVRQczJNM0lJQWlKRC9Lblds?=
 =?utf-8?B?WG1lWWFSNEgzK0RyNU5KUkhLcEU4bEduZ2JMVHdCOGZtSmFMVXpaTWNoVlNY?=
 =?utf-8?B?b0hua1pUZm1jbjdEcFpkTGxMR0VxMkJoRzEyVDFXVG5md0FNS0FVcmxYMm1P?=
 =?utf-8?B?c09jQys5bzJJeWZGbjUveVQ1b0ZUQjg0SDJOaEV0bzFzdUFjZnFNSjhMVXgx?=
 =?utf-8?B?Z1pkR2loamNZQjZvNVM5MUx1bXhmVjhocUloNDVMalRhV3h0UTlob05QMk1p?=
 =?utf-8?B?bU1SNng5UlJsQW55ZUpCN0FtdTluU0IyL3g4OVRwRWtlNDBJeENSVFN6Rm5v?=
 =?utf-8?B?QVZxRHJjOWN3R2JVVmJnaG9ZWHpJTGZOY0c0WGo3WUtYSXZjbFdDc1diTHM3?=
 =?utf-8?B?VFpqMWc2RVFUdTA5Y0QyaE0ybWRtWTZYRmpveVZ1YmkzcEkvM0o4UmxCRGJt?=
 =?utf-8?B?emo1Tm5tdHVtS3hQdlVud2ZsWXpVL2ZkSHpYV3lWejlzaUhqOTJnTXJUZUdD?=
 =?utf-8?B?eDdmdGZrT0UzcEJNSXcxQkxDNHBCVTdJOHBOV2lyUWRIRHdKYlF4Q0phbkVu?=
 =?utf-8?B?dFV0N3JjU2JYY2JmQjNVd3NLaGV5Q1dGTVkzNkZaTkhUNUg4bldBbXkvWUM5?=
 =?utf-8?B?NGNVNVlEc3ViTjVmYVhITGhGNDNYZXQ0bkUyNlZVL3Y0cnVUaHkxeDFmb2Jo?=
 =?utf-8?B?dXFBcnZLd1g2dXgwL1VzUVd4ZE1VY1NNVDgvbVFOd2lpSklqZVNhUHNTcERG?=
 =?utf-8?B?SDlOdnp0dGFOTS9xOXVPR1ZON2kvVzloUmdRSXIzQkhmM3ZOZmpnUW1jb3Nl?=
 =?utf-8?B?ZTc0TUY0MUdSV1MyV2pBQ3hjNy9DVmRzRzdxL08xRUxPTitiZjYyUkVXT0JN?=
 =?utf-8?B?cW1hTG5NNWxFSEtlbmZURjVBVkN6NUkrRWRjbjNXRDdJK3BFU2xreXN5NHp0?=
 =?utf-8?B?S2hIVHhnaGlwUmpHNVM2eDlEVmMvdTgxcXY4YnJTM3BzSnlPWGR2Rkd6MkZk?=
 =?utf-8?B?bHpMczJqVWo5ZjBBQS9yYm1uczB6TWFIN0ZUNjJiNDh0UmpCZndRZUw4b08x?=
 =?utf-8?B?WmttcnF3RU1Ob0t1bVlFRHhVWEdJelV5QThXR3p4ZkFSREtNN0xiVVR2UEZX?=
 =?utf-8?B?WUNLY0V2eXM0VUlNOW1hbzFodjdxYnJLRVJVNExZUGFXRitNOVNMR3ZsT3J2?=
 =?utf-8?B?eU05TEMrQjJSbjN2ZkRnaGZkeHhseEgvUG5oQW16SDU5TGFlZnpGc2NqdTls?=
 =?utf-8?B?eXd0dkZrQ3FGQVpFSll3eGxBSURSVEtmdHhUeGNTNGFESDhHdzJrVG1Tb2JX?=
 =?utf-8?B?akt0UFp1MU9aa1lGUjBtdmwySHdqN2h0RzRZSU00S2cvY0xwcU9veUZlZ1RY?=
 =?utf-8?B?eE55UTNtWlBRTU5lYUtJanpKWTZMZ0R2TUtudS8wdlhPNzFzYUVEMnlVMm5h?=
 =?utf-8?B?ZWx5WndIcVp6YkJ2TU01L2VDY0k5Y1YyT25HYjFCdVRHZUdOZGFkRGt4SVlO?=
 =?utf-8?B?Y3ZDWHdqcXlLckZuN3pCRkxNV0ZzZHlCZTdmOXRad2o1OFg4RnFwY3UxK29L?=
 =?utf-8?B?V011NTNOYmx5R1FlVFltdlRJWGlLdDUydXJQVXA1cThSdGozT1J1dkkydFRn?=
 =?utf-8?B?dXZHZTMzaFFmMlNKYzhmeDZBZE5mVnNMbWpvN3RHRzgrN2twZnRDVFJaSXNO?=
 =?utf-8?B?RDBsVU54T1dzcFVRcVY3d25lZER0YjVzSUIxaTZER1M2em9XVm1tZVVBMkZn?=
 =?utf-8?B?T09KUWhkSXhIRFNWNVowZTJVU1BLWVBaL0l3TjhlQmJadkp5TFdvQkJHcW9O?=
 =?utf-8?B?ZW4wOHpkeXM3NEgvL3p2cHcvUXBHOGhKT2FMV2d6Q20yTWFvTkd3M0RiTkdI?=
 =?utf-8?B?Wll0dm5EdCtQYy9kL1FoVWVRdFVHTjZkb08wend2NHdkK1lwVXYrVW4xWUFh?=
 =?utf-8?B?aTJiem9DWXludE1OWUgrbXN4Q1JueDdBUXRpeE93UzZNY1FkWEdSVy95MXd6?=
 =?utf-8?Q?CDT//POOxR76M8WajLr8Xu4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0e2097-5ece-425c-6619-08d9be0aa848
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 07:32:03.3482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DNVolVwFDBck6WCLkLb7F6YLzi12zvyZdrXr0mMeYzQxLjEYF+SaHz6NQp/t3MluRDjSnZFOdo2uMkQUYzdQMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3773

On 10.12.2021 15:20, Andrew Cooper wrote:
> On 29/11/2021 09:21, Jan Beulich wrote:
>> On 26.11.2021 16:21, Andrew Cooper wrote:
>>> On 26/11/2021 14:10, Jan Beulich wrote:
>>>> On 26.11.2021 13:33, Andrew Cooper wrote:
>>>>> @@ -124,6 +129,18 @@ config XEN_SHSTK
>>>>>  	  When CET-SS is active, 32bit PV guests cannot be used.  Backwards
>>>>>  	  compatiblity can be provided via the PV Shim mechanism.
>>>>>  
>>>>> +config XEN_IBT
>>>>> +	bool "Supervisor Indirect Branch Tracking"
>>>>> +	depends on HAS_CC_CET_IBT
>>>>> +	default y
>>>>> +	help
>>>>> +	  Control-flow Enforcement Technology (CET) is a set of features in
>>>>> +	  hardware designed to combat Return-oriented Programming (ROP, also
>>>>> +	  call/jump COP/JOP) attacks.  Indirect Branch Tracking is one CET
>>>>> +	  feature designed to provide function pointer protection.
>>>>> +
>>>>> +	  This option arranges for Xen to use CET-IBT for its own protection.
>>>> Shouldn't this depend on BROKEN until it's actually functional?
>>> It compiles fine right from now, and making it BROKEN would inhibit
>>> bisection through the series.
>>>
>>> Nothing actually matters until patch 65 turns on MSR_S_CET.ENDBR_EN.
>> "Nothing" except that until then the promised extra security isn't
>> there.
> 
> The series is very likely to be committed in one fell swoop, but even
> that aside, it really doesn't matter until 4.17-rc1
> 
> As it stands, this is ~65 patches of incremental changes to the binary,
> and oughtn't to be 65 nops and a massive switch at the end.

Well, I'm not convinced, but I can live with it being the way you have it.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 07:47:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 07:47:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245857.424121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwg2n-0007Qw-D1; Mon, 13 Dec 2021 07:46:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245857.424121; Mon, 13 Dec 2021 07:46:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwg2n-0007Qp-9w; Mon, 13 Dec 2021 07:46:45 +0000
Received: by outflank-mailman (input) for mailman id 245857;
 Mon, 13 Dec 2021 07:46:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwg2m-0007Qj-0E
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 07:46:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d00953a0-5be8-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 08:46:42 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-WnM68vulNiC01f98cSKu8w-1; Mon, 13 Dec 2021 08:46:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6479.eurprd04.prod.outlook.com (2603:10a6:803:11c::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Mon, 13 Dec
 2021 07:46:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 07:46:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d00953a0-5be8-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639381602;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HO2HJ1Gesjir/O9FT9Du6cXXqL8p+AibTlpxVWjogU4=;
	b=RR3HqgMAHfZAl/mqXAf03x/qPk5QxmAULmfldHiwjoGJeqWgv6/RD1cyywn30NJwJZRoAn
	s6yJD55An4x8Fc74hAZy/Wunz60SEOUHMw+Mx7IUalIAmyfQwKQYKk39lBSq+EvGGpXGYP
	qy6JL6TAJ1+wWogW3or3fBIhYXMfzjU=
X-MC-Unique: WnM68vulNiC01f98cSKu8w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=VT+ucT4SQewdx6SQHlId0gV5x6FDFNuiCuRpcFuLtzXrOBCUC0ynI4ApBvcfXlPhdmbtOzEsJhc197YBa758aZi4rfDESyzBTTb+r8XzT5JVDBc456zBBFfgEPNNXTntd6dFa5MZLF/jft2GOglExGFPv8raUtAE28OOPpknIdOnKoxHwumu2v2YGDcgidwd3VRywOP+QvDzi/0UmvPGe3/jqexFZHWYaNkBXLxHxDORDy/DXoI2I/ldxHKukZ6MGeNzur9ABekcSGPtRStReybX/x7VmN/e4suBr+/6lDnN+SloXAYiEY/pINcd4aHtg7SSK5xEr3HWTaqnPuPBBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e649gei7eQyg68ariLZ7D6yQJEYsBIEInU5nnHRWWWo=;
 b=PC+lbcB0m3WgyyOIq9G8OhCN/2ZqayDZZzjskhcP+nmivnQ8FEdXmy1HP8a5axV4LY+B424Ds0kU2QCzrlg38pQTNHJa1lDGkyGuf7vO+hkcDUlJAYxqbke3pyLUIDmfYEwXRJnHjpE2ZgoLsSGMDSktKtianVDjUDspoLTjVzdg9DrNmGjG+cgB+/2l3nplO5jU2Aq8IyDaN0gmE0HFpHh8y6B+mQ+2lUoZBVWGmtl3G/4cqMrVuO7O8V+1PGjwXTx0/GHn0VBdQl84laGivysCxH+3oetE6iAqAl6ie/6LVUgM570M8rIwomfc67ND67whG54hvBhih3DK/M/YLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e52af4aa-4542-24de-7191-955a4206f5da@suse.com>
Date: Mon, 13 Dec 2021 08:46:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 08/65] xen: Annotate fnptr targets from acpi_table_parse()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126123446.32324-9-andrew.cooper3@citrix.com>
 <bddd9fc4-d442-9272-0fcd-4472c83e36e7@suse.com>
 <dac66683-a2b1-e548-9d19-3a0e9a74c5cb@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <dac66683-a2b1-e548-9d19-3a0e9a74c5cb@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0132.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 91a765df-bd87-4fea-5b79-08d9be0cb237
X-MS-TrafficTypeDiagnostic: VE1PR04MB6479:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB64793DE1B928A1F5786C3B61B3749@VE1PR04MB6479.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X82CKI3B9MkYFdwCOuctGRmr1ZTT5nR2TZ6MajkuIBmm/VE5IB+3ygSFamJnS7XB/XdAWgi8lgnyGJXdrjk2Uq86VBas5OkDRce+rimlH77O+A9VRmRa27irzfLI0h9XySJmraCmcgl+TjyYDUK6v3hZDc3CsPXSONP6BUYv+knkKq7LB9mMZCz5Fsi2ZShbttE3SgOkqoD56jAECsjxVKsJ/8Hcd8DX4i/r9cvL3FPs9kSnBf50mur6rO3h6KRAkn4OA/4TPLsHu9A3Ww7lH78mEOj0r5c981/BtmsbJ6CmR4DRuox7Hrgrmgsf5GsK+aKw6c94KnntQcmeRdi1im3Mo5f5D6PLF/fXSPDuL5hEgCYPDOTHo5z6ccB6hJvng3yIAIJXVnEwDw81Byl5/dLqLVbRHf+o2+bYoAXJ7JLTwboun4qKB1Bxu6sKyoYZ7UQeEBLQ+DyuNadblvEHycZq4shXejE/ostLhWGC94W+7USeQgK2MHBbGanVZD1OdHC8yP4U7JbXikMFnXgknqUQvIMyJlNp7dOrbRNoxrKSkjjSqpv/hM6ld39LWnsnTBsOIKo4r4V7LtFOMuOK62uRE5mA6yNvgT8RzViFYFJKWne1MyLltrypJWCLYf0C70AQbUesqGR/9rM9/pbp9afuNz72irMgbEnYe66Q4JsyiDmSJRqPUp1rjgvgHfFMB3SbLnCJzedx/kKlzTflgbSH4NIZeGmhHf6a+yzw+tQIjlW+lhBSuDWRhvGybgWU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(6512007)(508600001)(38100700002)(45080400002)(2906002)(66946007)(186003)(31696002)(2616005)(36756003)(6666004)(6506007)(26005)(31686004)(5660300002)(86362001)(110136005)(4326008)(83380400001)(53546011)(8676002)(6486002)(316002)(54906003)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?G/pPdJvVijdkeTLkhc4HX3qwGfsMe3uwrjwfwstdO2FwNIn6ShxnXu7qBzf7?=
 =?us-ascii?Q?gyqvYJEVy6jSM4h6F3bZjXqJ5Ll4ED20Tz6nZerJJzLNfI++rvPk9qmPKh3m?=
 =?us-ascii?Q?5g8nQ5FzbxE5DcdL7kdmB5GJo2Kue07tXZvkvP19+d+U3JP9jls/2+8Vnw86?=
 =?us-ascii?Q?ENgob2Ss4bZJQLnzkniSQIFYQlv06yx9KHyPhmmD2CmJjR8IcmvyKByvVkeU?=
 =?us-ascii?Q?UaDYYUnTl47u9wBn/89oSvQwqpz8zxSYO0u1Jw47lH4ftXDnc71ivXmdKlh0?=
 =?us-ascii?Q?mgZV2DaWbmyl1CeORd4NTxHA061LDR3ciKvb20nUyFwb/IObWWiTF8uUiPQz?=
 =?us-ascii?Q?wJc5i4nZEHi4cnTOdtTdC9ju8QBwvc/Cc9DlAXVlEgL733t2KVwNfQXctnJR?=
 =?us-ascii?Q?XY8bs6SuWX+sjWgfe6sp0EOtYhzz4wQRVpYKu7XbaiEj9kgGBvT5Phx24kPc?=
 =?us-ascii?Q?0F7pWsnw08IlrhJZmLk13qZZ2DnqZZ8i9yt2HoIpZ8UxiJ1TCgFajlWddyrI?=
 =?us-ascii?Q?MOJW/nZUCb62pQpi8rlmvBZ9u2RJY8pzOnQ5LRlbZZCjxOckEl/YXS/Mag/h?=
 =?us-ascii?Q?4rr0SstMGf3EunVEVpn5scalolI0qwQiP/Kh+GnYEDnVGI4q6dqRu7tHlJ7z?=
 =?us-ascii?Q?tZZvEtM0lEcSU+VNI3Z5YTWSuJDW9mQ7VHAnzM7PeilT774iH7ISN+7mk/QA?=
 =?us-ascii?Q?aZZYly1uFiyZNJ/RTlfnWbVGQTwJ/yeTk4LjqNxz2KSkfcNtebT+mR3gaZaA?=
 =?us-ascii?Q?okbsSrE52PZY9yq9q638hyqkXh9f61wKiATIA8HEBYqYSRlXyGafDiDIzGn0?=
 =?us-ascii?Q?LHs+wwPc6umYaMp+JqQys0XPsgnqN7uGfdvLRvRkmntU2takXIR5h1X8ofx2?=
 =?us-ascii?Q?J++OOig3WYXHatyCcpGNiDu3b0kt2FfcwA9LAYdszMEh1uBs5KhpgDJnrFNv?=
 =?us-ascii?Q?xVoHqUfZzPyj3YX4T6cbzhalvolf+VlsDju4KoElhbN+PWh8fzvTaqFaJ2Mr?=
 =?us-ascii?Q?MnQX0MCwHjkKEQO7tMFGdlDgu7dk9C4NmkzdNQIfDHqD2niN2zY+ukBYeg2t?=
 =?us-ascii?Q?00GZND9eZGqmO36uY9KpV4xEsHGUID8VRfwtT3IblXcYLFUhUiqNDfydqNJA?=
 =?us-ascii?Q?Dz4E/x0DnXliagTzbmjJZfRcQh94wwQ24y36jXQDDKh4SJgayH+m0o+76Njb?=
 =?us-ascii?Q?SNQJ7JAdE1eM84Ns6tOGAC3SSvIuU0S2PW4w+gFR6+CslA/Bm9bH+TywpwwI?=
 =?us-ascii?Q?sk0uaGQcSile+8Frs9ZtkIXGYnw5TS7F96asv3f2Rz3Lz1HrU5jQdjTIaLcQ?=
 =?us-ascii?Q?r2n15DPrkUPSsE+PNLFVRVlJBPLKN3K3+fl3twpZo2pspUaG2zZ+S8j8WWb4?=
 =?us-ascii?Q?KUUavz1He1UYU+x40FjUbPkoRfDTz/lnmt/VEhIzE2Vgblhu3tTdFH5TOIy8?=
 =?us-ascii?Q?myaa2zJz6zZo80NSjwgjcVsrFkUW6WUDwmEcQWzAoZpIqi6/628ubtgP4Ye/?=
 =?us-ascii?Q?cWws0A3jRinOJDTl2wmJdjRLPvT6EKgHFHnJNg3xfRCFhaF2QZLqqLTwWGAR?=
 =?us-ascii?Q?r2hYpzkrXlv2o8I5LA2dZw6HNRSFNy7JhBEcbQ4vGRfqTABVeFqdjUO9m8L1?=
 =?us-ascii?Q?ZornP/pnNVZCk70Kt9cyYs8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91a765df-bd87-4fea-5b79-08d9be0cb237
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 07:46:39.0222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /guuIFxG/qGdALdrG9a4CHntFTkJYMkwSzYrx9Knzm6RsORgXq6XzCVct9ogj3Tf/roCxY1Z98CUZ6FiK4g5xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479

On 10.12.2021 15:44, Andrew Cooper wrote:
> On 06/12/2021 08:36, Jan Beulich wrote:
>> On 26.11.2021 13:33, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/hvm/dom0_build.c
>>> +++ b/xen/arch/x86/hvm/dom0_build.c
>> Elsewhere in this file we have
>>
>>         rc =3D map ?   map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn=
))
>>                  : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn))=
;
>>
>> which has been in this shape only as of commit e3b418ac4919
>> ("x86/pvh-dom0: Remove unnecessary function pointer call from
>> modify_identity_mmio()"). Aren't we relying on the compiler not
>> transforming this back into the earlier
>>
>>         rc =3D (map ? map_mmio_regions : unmap_mmio_regions)
>>              (d, _gfn(pfn), nr_pages, _mfn(pfn));
>>
>> ?
>=20
> That old code was especially dumb even before retpoline.=C2=A0 See also t=
he
> damage caused by c/s 245a320ce2.

I must be lacking context here - what damage did that one cause again?
Or which subsequent fix of that damage am I overlooking when going
through the further commits on top of that one?

> Yes, we are relying on the compiler not to do transformations behind our
> backs, but it won't of its own accord.
>=20
>>  And aren't we further relying on the compiler not transforming direct
>> calls into indirect ones for other reasons (I recall Microsoft's compile=
r
>> being pretty aggressive about this when the same function was called
>> more than once in close succession, it at least certain past versions)?
>=20
> That sounds like a broken compiler.
>=20
> There are legal cases where a direct call has to turn into an indirect
> one, and that's when we need to traverse more than disp32 distance.

Right, but that's certainly not happing anywhere in (relevant) practice
withing a single compiled binary.

> But without going to a larger mcmodel, we'd get linker errors before
> that becomes a problem, because R_X86_64_PLT32 relocations can't be
> retrofitted into an indirect call at link time.

I guess I don't see a connection to a PLT reloc: There wouldn't be any
if the compiler chose to make an indirect call out of a direct one. It
would be simple PC-relative relocations (generally coming from a RIP-
relative LEA) instead.

Jan

>> Is the widened effect of the annotation intended to also guarantee that
>> indirect calls will not be produced by the compiler for any reason when
>> the annotation is absent on a targeted function's declaration?
>=20
> That would be one for the clang and gcc developers.
>=20
> I don't see a plausible problem here.
>=20
> ~Andrew
>=20



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 07:52:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 07:52:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245864.424132 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwg8A-0000Yr-1L; Mon, 13 Dec 2021 07:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245864.424132; Mon, 13 Dec 2021 07:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwg89-0000Yk-UK; Mon, 13 Dec 2021 07:52:17 +0000
Received: by outflank-mailman (input) for mailman id 245864;
 Mon, 13 Dec 2021 07:52:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwg88-0000Ye-J5
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 07:52:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9640b38f-5be9-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 08:52:15 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-6-6iwzA9ysPA6uf1t8Z9psJQ-1; Mon, 13 Dec 2021 08:52:13 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7149.eurprd04.prod.outlook.com (2603:10a6:800:12e::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Mon, 13 Dec
 2021 07:52:11 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 07:52:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9640b38f-5be9-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639381934;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=a+Wgo2w+TDt+VI0k0EBU73PrKMstWCKSjkUbFME0o8c=;
	b=OSQXMn0EIymvx0YihUkzl4s27hGzbvAExZuU6wKFAqx4E/xH/oull67zUWcFJXoRT4iDZV
	h5YtsDdrODW5zRdTRRzdog+mtrWLe5c68hjYRRl2TDZc9e7xDWzy4jzsl1VnpzBvO0VRKV
	Ne8HM2/GgHyiSdl3rQ2FDdx0Jj+GJXA=
X-MC-Unique: 6iwzA9ysPA6uf1t8Z9psJQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jOS4V29HxAF9tPjIfsVgpJoyzcVCtkH5xatrugzQ3GVxLnnD6diURe+pF7vpAwoGK21rxWFBts46DB6g8Zsqc+R9NtDHk+5pjiXOREoDSllL1S0EYfx7WT52Na11Z/WsoZ8r7ZV12uxIuUob3Vzznxdehg8KBMTPlsYv4o0ogngVFPlqBn/R8D3qU3i7hRbvVRgAOLGN8Wj/OKDTfFEVh027QlW2arOPr9FssO9NFLeTgYziwTuHQgSMnsMxdvdq8cYpFs3SewopCVQphPwuNoPkSLAwxcGhzBNFHuRTo90V3p3eLnAxBGtMp5avBU/nciDy07AjGldqahY0I+YfbQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KnZU/btKpWAQYmo2KWzc9dqlh89wmA+eJZrp4gFS5sY=;
 b=LOAWoU8qPZNu58zuis4G5E5QOcVSi4NgUQf7YrhxsB2JfCr1Vry7RGCclufHV+VMw50bgak+bIpVEHFVH/Z2o2G0GHAT4v0K/qo4TYyDZiOUSQRLOTVW4j3js4n74t13a+N63vDXzoKEeG2kZXaQCAlSoy7SIoE2ZDOl466r1eh7Ikrn69saX9SYamUoyZ7Zblu7MOZNiBQXMpcpBDrXZpGvxJQbyQbPfUtQH1h5G/9nxGT/ttzAaskDuiHtlWJTT8a9wJEEaOqf84zIpo2P71UxxYZdkLXSsT7buOvhQZsznk6ogDZJU+NSESANlHHHCz8wBcqyOz80rxZSPRKg8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <7b416346-1c78-2a93-9eb3-9dd81101de06@suse.com>
Date: Mon, 13 Dec 2021 08:52:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v1.1 64/65] x86/efi: Disable CET-IBT around Runtime
 Services calls
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211126123446.32324-1-andrew.cooper3@citrix.com>
 <20211126163830.30151-1-andrew.cooper3@citrix.com>
 <f3a94e22-5136-8cb8-6df5-58899a8bc4a7@suse.com>
 <23feef0d-2913-69cf-1a1f-59b1e933ad37@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <23feef0d-2913-69cf-1a1f-59b1e933ad37@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR08CA0038.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc743f0b-a3a6-4bbe-94ef-08d9be0d7847
X-MS-TrafficTypeDiagnostic: VI1PR04MB7149:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71491FD07165806551361CC5B3749@VI1PR04MB7149.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pW6dsLOxC3+26Bxki3TCwvVg3FIGkXxRuqDYwZpk12e4a7eHSrI5y1BaRiFl1DDzLoDXhJVkCwAnyepneknDOMBuz5JhoGA9Xg5bI8rhOkeLuhP5zEfQhQ6VYU6pjs8Ai0HZPCzzz2yFiPXulljkMAVPSTRkTQ6um6i7sYfkqnEwPXjIlV92gfGMFEH9OJKP0QhmD3BprReU99QBhMOklj06z7oNiSrj66uKCAvZkG2e36/gSS4ck1nasmxCgY8xGACW6koRByjtmHQIbkgR3zK04x6IlFF89PFNFztUDcqZeRVOAKSNbR49KKsjDWLmM8YIOrG4rE/+x2CI+aMRiWSAYJW4lOB8oBn4HUD0j32TWm0Kakw5Gd9hgz2T6jxauAVSwaMPT5vQjXxaBfbQvD9RmIelUSI2G4i+L+Sqq/86xq+6rS7uBVIGP/ZnkQCBNlC6eS8Wbkf1xvazPUMnng+tQFMaIO2pqwe4vLqNvSoyY0YUzX7HO2LaGnXVwoHQlRZtn/pybUBu1lF5DrTqxQhHxmq5LVFdRPGk2Jf7elqcyvn+GfOyX/5gRQkRaFY/ahV/ygwsHQde31WEvpO8plChfW1LlEeNk/3sD5YWqH4/rJjv5+o0kOr6QzPAAetdyZwX4Ndh5PRZuZqr3rRz/ANmZjEPCR+FPYXAOyd+SfFWNqBKZWGt7v68BqFx7YvSB9//Ou21ONyxl3R708qFalfEzf4mJrpihnOfNtjs33JwMbrUhn7pWSj3mG2yRmdWH9S5QHX5TYHv58Hm1EqdmlLkqabw4Cz/hc6hoVFML1HeLYZ2OdH4q8ebzANQUv0R
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(966005)(2616005)(8936002)(31686004)(36756003)(6486002)(66476007)(31696002)(508600001)(4326008)(38100700002)(53546011)(54906003)(316002)(186003)(2906002)(110136005)(66556008)(26005)(8676002)(6512007)(66946007)(6506007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vSUn8CZ16vau8dI86PHCkUIf6QkrenqigMme2VRe3RE+rdT2r/z82Snk97Mq?=
 =?us-ascii?Q?rdNlVlVBr2pH7oDb+jLx43ac9zRUTYqioHArcoEGq4uNxKKu/Ur1cUTOIm/y?=
 =?us-ascii?Q?r9kdQzQu9qzyfiv6LqCzk210PmgTbxs9em7879ECsdw7iWPBmLOsuULw5DFN?=
 =?us-ascii?Q?LZPGfyk58O5cYb8E26Uj1JzfgrIzdeCbRl0I+rYAeQFmDiwu2ZvveDg1l/Zv?=
 =?us-ascii?Q?KyH48vzQgyR2zb97AyZgAtwXvr06nP6jZqk0zzN3nSAGmEeL1j3yT3zfiNW3?=
 =?us-ascii?Q?YN1+KSa3ar9mrBXfjAHQVb4ORoRJoX4Z4YkusgdNNFp3QjCiMDrC2Y133Fvs?=
 =?us-ascii?Q?9RHrgCoGEqlwhP0+9i9v0iCyDY93kAEXrF+w8C5tsG5ooIJgISwcSB3bgF8S?=
 =?us-ascii?Q?vTyLirBInQLlSa22auQ7YO8E03FiIv33o7h6L/M1a68Tu51IZ9Tb4k8uAnyQ?=
 =?us-ascii?Q?gLdcuKP/JndOLx8vPZLuOEGErvfyRZXGi/poJZ/i/BdYUqmgUHJGzFvMqqsj?=
 =?us-ascii?Q?5sWndLxnM0KvmNnc0So70FDhEQw39SRj9MxocLKJ6pn7hcWw290QRsjZ7v2A?=
 =?us-ascii?Q?SkizTbGlke6kv5a42PloFVDtUZqLhpVQsCHYxFGlBvI/x8dhi4TMhni+NXEx?=
 =?us-ascii?Q?c3LxR12uJ3dxulXXVg+fs9PNZwh5BOQW00go3Ugyvdzkrzbpey0Q9zWQGVLH?=
 =?us-ascii?Q?lq8wyqStNVH7QbOZBq/47oLViFoRFUdbbYQptBMhQMJHUzcieny2PWmUhCiq?=
 =?us-ascii?Q?Epem5C1jVvtP/fCtJ7gev/5KXzt1WmBWD9oGADUhhEOGlPuvyq59Vh4UP8l4?=
 =?us-ascii?Q?pVw1+MKG0n6p+Ed4tc9t6hNq8Tgw7luQ9dvPR9MuGHDxrPab+ooeK2T/2OrR?=
 =?us-ascii?Q?+WiHOpWMQr9TJh1inrhVgomeMEAOfG+++Jxl8SOg0yN2Z9jXPYpELV1Vwh9k?=
 =?us-ascii?Q?5a4gl2XwTmRgIdNezOpX1pqIxnbyllAKv6waR2h9BqxqX1KKbe4zTykce0AD?=
 =?us-ascii?Q?0qsjyZS4r1Bpk8lxKLf8I5VX57p8euraX+bt2wopi6u1CIgXzY1+XJhsnANi?=
 =?us-ascii?Q?7YhP2n4Xj19QMxSPQ8byLh0fgh3jhS95N5XmYCk+mKgdn4URH0FE/9ZFkTwG?=
 =?us-ascii?Q?mxAep8dEejruWIL4HhfHB7wRy82eS8kogaca/wwA7rCUO3S34g7V+7F38/XU?=
 =?us-ascii?Q?CYnYLKUKYxRXznycFyf+3POonVr8zpSrEzUD5X5Av3C/3ton67UiHdRXhs2B?=
 =?us-ascii?Q?5VApfYcPF4yawIB6R4zyK9typQwcN+Kkk6pzsNlZ5wVnt3SRiIvCt3d2cxXD?=
 =?us-ascii?Q?M/Lq95TVkHVITs5Y4juVvdWQFfnJRh20Nqsy8EarCOiyf8f2bzJc5EhfTo+Z?=
 =?us-ascii?Q?FJM2TZKZYEnKT8MYx3CiGGA5EhW36bIKdYxii2KtSKadx33J9Vpl51fxT4ao?=
 =?us-ascii?Q?qet5BZPRynEe2UCJvAKlkd3GNDW82OyAhfhlPuDzuu/PGU6ABaosZ48LZZ2z?=
 =?us-ascii?Q?tWKkbv3c6134RXXUz3u0ge9wBFGfrk0Idyyi8nfqMPe/VElysJybRLl1cDSA?=
 =?us-ascii?Q?X0y9r9AGpauskokMH8PddK7nLkI6Y4Zkygqo06EOTMbwEz//Yrprz+qqiXzn?=
 =?us-ascii?Q?smLwPnvwFTyIGfqAkmsnqkA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc743f0b-a3a6-4bbe-94ef-08d9be0d7847
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 07:52:11.2914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y9IHXeoDo55im/7D/GGeFiI3SDMKIKA+r/8Kr9to1oA/LTF6wSoZqewqjVl+G7hBU/zQz+EivhfJ/rCXkKSdqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149

On 10.12.2021 18:16, Andrew Cooper wrote:
> On 06/12/2021 11:06, Jan Beulich wrote:
>> On 26.11.2021 17:38, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/efi/stub.c
>>> +++ b/xen/arch/x86/efi/stub.c
>>> @@ -11,6 +11,8 @@
>>>  #include <efi/efidevp.h>
>>>  #include <efi/efiapi.h>
>>> =20
>>> +bool __initdata efi_no_cet_ibt;
>> I'm having trouble seeing what this is needed for - when this file gets
>> built, neither boot.c nor runtime.c will get compiled, and hence there
>> should not be any reference to the symbol that needs satisfying.
>>
>>> @@ -735,6 +736,14 @@ static void __init efi_init(EFI_HANDLE ImageHandle=
, EFI_SYSTEM_TABLE *SystemTabl
>>> =20
>>>      StdOut =3D SystemTable->ConOut;
>>>      StdErr =3D SystemTable->StdErr ?: StdOut;
>>> +
>>> +#ifdef CONFIG_X86
>> CONFIG_XEN_IBT?
>>
>>> +    /*
>>> +     * Heuristic.  Look under an arbitrary function pointer to see if =
UEFI was
>>> +     * compiled with CET-IBT support.  Experimentally some are not.
>>> +     */
>>> +    efi_no_cet_ibt =3D !is_endbr64(efi_rs->GetTime);
>> I'm afraid I consider this insufficient. Even if the core EFI was built
>> with IBT support, some driver may not have been.
>=20
> That's not an issue.=C2=A0 Everything is built together in practice.

I'd be willing to take your word on this for everything that comes right
with the firmware. I'd further be willing to accept that there are no
add-in card BIOSes which may get involved. But I highly doubt that what
you say applies to all software which may get loaded ahead of starting
Xen. Such software may very well register hooks with core EFI.

>>  Hence I think there
>> needs to be a command line control to force turning off IBT. The only
>> question is whether we want to also honor its positive form - that
>> would, afaict, be a recipe for a guaranteed crash if used wrongly (and
>> it would be meaningless when used on IBT-aware firmware).
>=20
> It turns out that IBT support is lacking from tianocore, so nothing is
> going to support IBT for a good while yet.
>=20
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D3726 is the proposed
> change to the spec to support this.
>=20
> In the meantime, I'm just going to blanket disable IBT for RS calls.

Yeah, that's going to be okay for the time being.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 08:39:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 08:39:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245877.424144 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwgrH-00065H-TJ; Mon, 13 Dec 2021 08:38:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245877.424144; Mon, 13 Dec 2021 08:38:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwgrH-00065A-O5; Mon, 13 Dec 2021 08:38:55 +0000
Received: by outflank-mailman (input) for mailman id 245877;
 Mon, 13 Dec 2021 08:38:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwgrG-000654-HH
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 08:38:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 195d162e-5bf0-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 09:38:52 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-WjCFY0fpM4i5Bx84zxbZtQ-1; Mon, 13 Dec 2021 09:38:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 08:38:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 08:38:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 195d162e-5bf0-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639384731;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=84A/1vkL4ov7So67BWwr0gB5ZeNVY92WcQ4KCBg0kEg=;
	b=cu0CyMsDzVCs9ZhDnBEp23AoirIYuL1vhtluQkp8H2JbpKklp+5KhsAhkT2uxUuBsCwhkW
	zM8i9UbulLVmndOSKRT2RWOhcFEf4/vYbTEsWbcnU3wvTTSNnUMmQJz5RKs+Nh4ChUXvwo
	G5nhtLlKz5pXrOJC9gMUGNza5xo9yrw=
X-MC-Unique: WjCFY0fpM4i5Bx84zxbZtQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XXAG7pw1d+yaz9qu2mgJ6vz1ndEMIiPgsOVrnOj/Rog4BmFiY6A87mX4YxJc6yNL1X3nG7GAJUcfol7tg6leTfbxxAHCxm4Xc2f+UheQIWqoiXWy2OpBUQHbcxIcLWtCebxENznqxYs5lYzwTAr8jWpr0fToM/QDFz+lyGaq4l5OuSUa76FA0P9O9HfZvAOc/ZEHL03d0jFH0Z5hZyk9hHiHdXzcxigutnmOHzaKkXcIp5gQ/dzpFDRc4qLyEZhKquoMtEX13nrCZTeuw12T0xvJQWWW5i+YRiLoEMHt4JImNzLDsIad6kfSTl8F6AmzyZ/ImvIxmbZxca0MgBgmFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5dxNM6d1NEHtjAWfElhcxBUJSpnLa6yE27FisM8KjQY=;
 b=MQF4++vyTFfpLRrmkHtwalerL8aTMljNPl3+uurw+ymKJPwLMwFITizAy5FB+KeHJXmUojcmSPbbB/jYfwIbZv97teF+3O1BkxQkAZeUtDl1IY1whG3nPIUtFiyPkNnacGZoX+GDVZTqlORM2WDavH9+pGTx5c8+c4oODvjpHuqtzaF4OkYBI4yT9xwTRShcdwlLBggjOSTGx40+gLnpE83a72g7rJbeOFkngP7ffTOTB7VpVDYDSaxy3DuPIYnDt0oHOtKyJS5moO8rf78YPxH8x6jJLRRYdm9RXLjqVQ4AvWrdji+lCS1/TABqZsQtAzRyGt/lnU2mhNZertN6ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <47786373-aa55-d572-3205-38513042cf88@suse.com>
Date: Mon, 13 Dec 2021 09:38:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <c12fccbf-82f4-1259-f69d-a6ad8d78ea15@suse.com>
 <YbNbafZMMbRJxlzs@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbNbafZMMbRJxlzs@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR01CA0046.eurprd01.prod.exchangelabs.com
 (2603:10a6:20b:e0::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eca7b970-2935-48f3-765c-08d9be13fc0b
X-MS-TrafficTypeDiagnostic: VI1PR04MB5600:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5600E7776190C69A06B0BCCDB3749@VI1PR04MB5600.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5ENY0MMZpYGTAl1wGCQRJlGWTP5IPKdwV3PrWyev2Ps//itiQwYwnRZZQO1LXPe6aYsz9Cd1623lzLSvZh1t9a88fTt8B8U4+q0jRoW1ausl5fzh2ykPa8RjShrTWAmkVso37b48mi590PfJSfRSzRAhUZXx7z6i5RPM5tKO+oMfqkSJxfwzHtEZAihJR7Qqb1dvQnJ2/5nA5kIWOoTGh6J1eogBQrogfzgnlqpis+ruB3MGDG+EL+0qE8feVTOQ6gMqlfNAk9O/UgAEaESjhG++eV+TPR9t5GPm8TK3IDMfGZn6PxZ3tQuj7knXGwzd8DIh+tYTyaoCtdWa9TcrXc0jRHkZ6TQLMhyYWPWehqdv4OVAo9KifDXrKOfSDEdwd3NXZSRRjYoptP57evFXwaEMaNcJghrSFa8zEIEVxhWmfKGokvSYmZewseGlpIvkPQf+y/ksJQ/VLRANMn3GwFYlFsGHOsZ746rSlMz6zlYVph9jk/GGDsdkLUwdwucT7cAmeQYPZAqds1IJS5NM2E3zFECB0CH/eGGjwD7M1A5F8P/xxNM1L+mfE9fq08Az0DsDn59VoRed7zvKT21S1TsMMy7OmoxiRcUgvoOYrm7NQOw1hl+Shk+QjvGJNblbh+txoey6kOPgs97Cb1HsngeyWX3EdhyGmJH0jOnx7zv9rCYcrV23FJnD7gnLPGT5Xq1EIR9aCpIL1RRHB6oFSwNNufLa9sYPH3t8ryR2iX0APdWrRgE4KNRLcDG4k3OYGPlNyHHds0/pB7V6LXG1+8w0KF++WbScGuImxnTOD3lNoLaiBVY8Zi5z/630tjqU
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(6666004)(2616005)(38100700002)(8936002)(186003)(86362001)(54906003)(4326008)(2906002)(66946007)(36756003)(5660300002)(66556008)(508600001)(31686004)(8676002)(316002)(6506007)(66476007)(26005)(6916009)(6486002)(53546011)(6512007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MZXfhZ4gWXZeECmy6WMawViODJ1hP66ptXM3dMqH9lrSn+JBBUmFvQpnzO7t?=
 =?us-ascii?Q?9dk5dr7LO8NTmKCGi4uCvwQ269QbO3OSUVUkhBJhZ8W53SB8fUy/a9nv9CYc?=
 =?us-ascii?Q?bLafPsvnPE4UHUInHQtmPNzcUG96fTVkfYSYe3OO5dMEvR+8GPqgoo2cW1uK?=
 =?us-ascii?Q?fcdEqmGn6Ak8Bh+5aNI5mbzhn+nAdrVdqSReY0BvcIQdbUQNmzTgMBCaqhem?=
 =?us-ascii?Q?xnsA1uz9ySjnXOVAPFOy37SkcTbjAY8rGzvJWwmeKvzyuiIAZAcfEN2P+FII?=
 =?us-ascii?Q?lLo0aDbXRF15sWJ0jf58CB4ErbazaZhjcKsV2CDwE1DILSHP1BNyvrXJfcS0?=
 =?us-ascii?Q?+hQTdQxv8qhcvb8Gojh0aoF8A3CbluswgKhx7SY8Jpr4wi4lw6Z5/YkYgmR1?=
 =?us-ascii?Q?7StpvJFhZrJugOovkkCOEoL2B0qT1M8VUGt2b82XY/nTSs7VxXT9JE38p4Wy?=
 =?us-ascii?Q?5AovbmLY0p0f3vQg8vs/yjHgVSS6ACGYSAsmOXyC/2J77sBs8AxVUCIFkySL?=
 =?us-ascii?Q?tx4t6nxMyvjZg+kvDIGHDiNUJlCSgOrbvuRmU5FfjxFOvBL9X+fAGPFQs+Yq?=
 =?us-ascii?Q?AwUW/Si0AKFfItKWEVu53BtVKLjwiV+efcUqdcTcm9+ydzQBnxN+c8YbiJwZ?=
 =?us-ascii?Q?6SK4OGzrsGxWSK1g33+0kcoM7QuBAq5FQ/kfqqrvqS9un2w/y6QXBw4IfCA+?=
 =?us-ascii?Q?TSUtvA0UR1VQIsyxMneGCB8tyPzURQWWQgj1xCoYqq7GRBySBSgPKfMgNOL9?=
 =?us-ascii?Q?YZytNy8yakxnA8greV+6vCrgZ317DbaL+v21JedPfWiNnqEazhw6xrt5v7/C?=
 =?us-ascii?Q?/dAjFZk/+dt5epfKOwyW3zSmaX9Qk1VtHsosUGnF4/zuzor1bdF0eR3/+4Ph?=
 =?us-ascii?Q?TSYopBwh+chak3KI947nqM+qopGdOwX1hAHzXcpBPuOT5l2qjSYFOdf4rugh?=
 =?us-ascii?Q?eat50JCxLpeoODesRbHVC0zX0yRI5Ke7dXtbRp7HIiCi7xT861Jr/emvG1V4?=
 =?us-ascii?Q?8X2GQB2ckBI5r7a7Jrcrl+YJCCQpMu444cmCrHz/D0+2kNTF1eWTZXp7PLEu?=
 =?us-ascii?Q?IgBbCRasuLSV5g9t/OTmsWDHUW3kyAHhb+BIZn4vNxe98QnYwbwbypGcME6E?=
 =?us-ascii?Q?3K5ougzrqocgL5NHyMVLkzXLDEHpOHJXCYA+JJ9bgU+LD3cqEua/iPwb+e1d?=
 =?us-ascii?Q?b9pRfehYNUJ4kiuRxGi3ipVDCAyWYWJDZya1nov/XOukDD3x0lGDPms4N60s?=
 =?us-ascii?Q?MB2LwXZb//qdr607Q+67XL3N8uB/20xuZpVYz2gYaDe3Jlu9iRk2mXNYc+bl?=
 =?us-ascii?Q?P2dLVgrd6axyluQ61QQhWiymUdLArZjAusoyhO013w7jOJQXOEqGwZjFy05b?=
 =?us-ascii?Q?aVFedSvauNnpXBrLW7NYcXdPvmnAl2a2/Zj+FsDBMXmDo51SNjw82fmwJVJy?=
 =?us-ascii?Q?GZbEdON8RmNSnKBnZe8HaTu7FuknkO1/09MKugdaj8PQJ1khzFldfvhxqBrF?=
 =?us-ascii?Q?qBbyn39hBc1QoUahbIGDa715JCCczGkf2YSmigns4LejtV57cwpisebLx8mn?=
 =?us-ascii?Q?Nt8udtFgoVpKtopCXQmGuRZSZO1EBCgS2Uhj5nv+LUoIzcpYVaottNzr5p9g?=
 =?us-ascii?Q?/Y7iizmQZ/MtbTCF40fztkU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eca7b970-2935-48f3-765c-08d9be13fc0b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 08:38:49.3840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JmbxY7i8INr1FG90L5PkUGZJMVzjCq3l+s9it18n//b/VtKzy8iDCmj9WtU3mGXN6tRZmLWPAJajasQmCpHsCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5600

On 10.12.2021 14:51, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote:
>> For vendor specific code to support superpages we need to be able to
>> deal with a superpage mapping replacing an intermediate page table (or
>> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is
>> needed to free individual page tables while a domain is still alive.
>> Since the freeing needs to be deferred until after a suitable IOTLB
>> flush was performed, released page tables get queued for processing by a
>> tasklet.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I was considering whether to use a softirq-taklet instead. This would
>> have the benefit of avoiding extra scheduling operations, but come with
>> the risk of the freeing happening prematurely because of a
>> process_pending_softirqs() somewhere.
>=20
> The main one that comes to mind would be the debug keys and it's usage
> of process_pending_softirqs that could interfere with iommu unmaps, so
> I guess if only for that reason it's best to run in idle vcpu context.

IOW you support the choice made.

>> --- a/xen/drivers/passthrough/x86/iommu.c
>> +++ b/xen/drivers/passthrough/x86/iommu.c
>> @@ -12,6 +12,7 @@
>>   * this program; If not, see <http://www.gnu.org/licenses/>.
>>   */
>> =20
>> +#include <xen/cpu.h>
>>  #include <xen/sched.h>
>>  #include <xen/iommu.h>
>>  #include <xen/paging.h>
>> @@ -463,6 +464,85 @@ struct page_info *iommu_alloc_pgtable(st
>>      return pg;
>>  }
>> =20
>> +/*
>> + * Intermediate page tables which get replaced by large pages may only =
be
>> + * freed after a suitable IOTLB flush. Hence such pages get queued on a
>> + * per-CPU list, with a per-CPU tasklet processing the list on the assu=
mption
>> + * that the necessary IOTLB flush will have occurred by the time taskle=
ts get
>> + * to run. (List and tasklet being per-CPU has the benefit of accesses =
not
>> + * requiring any locking.)
>> + */
>> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list);
>> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet);
>> +
>> +static void free_queued_pgtables(void *arg)
>> +{
>> +    struct page_list_head *list =3D arg;
>> +    struct page_info *pg;
>> +
>> +    while ( (pg =3D page_list_remove_head(list)) )
>> +        free_domheap_page(pg);
>=20
> Should you add a preempt check here to yield and schedule the tasklet
> again, in order to be able to process any pending work?

I did ask myself this question, yes, but ...

> Maybe just calling process_pending_softirqs would be enough?

... I think I didn't consider this as a possible simpler variant (compared
to re-scheduling the tasklet). Let me add such - I agree that this should
be sufficient.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 08:50:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 08:50:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245885.424154 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwh1v-0007lS-01; Mon, 13 Dec 2021 08:49:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245885.424154; Mon, 13 Dec 2021 08:49:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwh1u-0007lL-T9; Mon, 13 Dec 2021 08:49:54 +0000
Received: by outflank-mailman (input) for mailman id 245885;
 Mon, 13 Dec 2021 08:49:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwh1u-0007lE-2d
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 08:49:54 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a344eadc-5bf1-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 09:49:52 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2051.outbound.protection.outlook.com [104.47.1.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-yPuZLpg3M-GtwLBEu2ubUw-1; Mon, 13 Dec 2021 09:49:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5328.eurprd04.prod.outlook.com (2603:10a6:803:59::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 13 Dec
 2021 08:49:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 08:49:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a344eadc-5bf1-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639385392;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=oMEP5QVK22axG4eddfrPgsXtspkPr8gsDXZteRa5uqI=;
	b=GvV6PWhzW08mH2XZHyfREtUXHKLdrJVkLKuawEjehfWLuF82jIRgPAmuOkLEqiHuQ2X4uI
	o2lCnuWDtBJCWQAGYEUPQNMOgeq639tMm/Zg+Za4mXz9mbmqDuf8fPvutx3mIMG4nKenUJ
	FGocenHaoIoBlvYMsSB3mZGT52r3RuI=
X-MC-Unique: yPuZLpg3M-GtwLBEu2ubUw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pdcf1JzdYEcnIwv9ClK2AJfo2GCnzY3FO40uE1lqreiGBZ1IRqk/0AN3mN4+Yj6S/QDUdOhLcETqqsf+tlwPMotTDHR6j915Jx58IxBLB9xybCQveTGnotRzViFa1SJyaC4xTl2PWkcIF40a9aKjW/ixQJFmLdg2OT62OoxMgti0NOwkpfJijxUtYCRXSj4DybdRt7FshlAJLguBrlEHQTxZWdN6DVSVt+IPg5FPX7gBpak9ySfBw9JER2GVDQREpsZbWQi3HzLsNHPG/P7UMCQ8veuojf8cjw2lNBmeSaGNMQ3bEfwlwQ1ohdIaGPrd2YWWhfkILpNj220CJjq9xQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ohJ8t7lloX5sC8D8ws7KI7zCjKwxwysN4U15Zet3tsg=;
 b=XFPQE4u0aUS2fpDTk+Vfsyk48dtkdq00e/v4CH9l8FTIttxTtmEeCTkl2zmLNVPJfX+kkU3Pm2+WnlGObBXfXaX8SmW6l1l+Ys/D180YNwQfzPTrMMcw0JZT6x/+WA1iG/91SdLo9g9z/3PvizoWg0nlnMzFAbFw5kwa7+0sm4KwAZVWw+YGFhSievec8Y9HOy6tzFLnO4WWUzFgyD7sMlApkC+YbQIkpqbom8MZ9X8DwLKgpvqCOLYkZ1ZVFGsELliAIO9yKp7186x4Vm2wouyqPK4jtu2FUve8//ZMkdpbT8Hm7oENQXoAlOgJf882DNWnUzL4CFWPem3wOEhknA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
Date: Mon, 13 Dec 2021 09:49:50 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
 <YbNtBPv1M1lIyEOd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbNtBPv1M1lIyEOd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0082.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: abc3400d-4f96-4bf0-6055-08d9be158589
X-MS-TrafficTypeDiagnostic: VI1PR04MB5328:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB532820F302788607DE646097B3749@VI1PR04MB5328.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	isoyS159sTw9ZPJhsY/Cy4XRLDyMzASkabmjj0PtNNRoHwwV4s9QEUXs/iH5ib0l3cy7a7Fn75KqteDt23I8eBMYIMdUzBTnqUqvelA9ICF7nmNY8ipURtpgabbvpJtDHtyUnu0eN9Rzrl6iKQ/BOOKhq9LluKfw17eAp64CXgcfVICC2PjdBzivAX6tpkj7NQ5KChDuRRVnbsmIAkiDrA74BXwzdEB6RfDKRubosBsvDnJMeAdAviLVqvF/LxRbykcX35W0iLZufH1UI2cOhQ3+GxlQoL1+vVOb25aSal8ZU/RzTRejL3V6f47RcHEWk+MnQraOyISURXgZ5LYAwrvIJIKzLsZKnzarQnTBJlZlUDMq0d+fRb0T8E8oxjp1MPuhEHq7BsLd+Ye3EXPEGvN7mvtskzoWbHzOPdTqhaoVFZv9yGIhZ2Gavyktc2B+2/l5ZduLORObjhsA5iH6xsM8mKsxtsr07taAzfM5tty3JpQlGKtcVe8me65/8q30hYOor2QXK6A/BJ/lwWtbBQkF+nTduJOEq0n6k3ImsNYwIoFZCgY15T3XN+ZSN8GLNHo5kKcbVh8J2nDPBU0MWhFn03VJ2P8VAp87IuNHoewyuGSeRm7HQO4KzQo9BqtuAvM08Chhp7hF7vZuCKyrZIJhulKZ8h37iXjI4yLTudlUV+8kUvVXWE0fyE27Wu7YUIh/X58MnUNj3ft+MQxDVayV/Ti/zuJ9Ht1ITBLizc2aM/TKW9RnuOOpgz5v/oLL
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(31686004)(6512007)(316002)(66476007)(66556008)(2906002)(6506007)(53546011)(2616005)(8936002)(83380400001)(54906003)(6486002)(508600001)(6916009)(186003)(6666004)(5660300002)(86362001)(31696002)(26005)(36756003)(38100700002)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7IHAjBt7XumaeV8yyPyW8BWHQcxNWmtXs/zotD4kCpyYC5XB1eCj5+eUUwny?=
 =?us-ascii?Q?KvG9zHfv7LuwzeCl2z43RGiakuB9wTLkPVh7ysvgUt8EdLLYP5/egCx+tSFp?=
 =?us-ascii?Q?iTYScM5XqXWFYGB1n5/YISnBmr3A71Uiidmi6CQbLKurXzFNRtQrk1Rjb+aG?=
 =?us-ascii?Q?IkciyyG8Pbs+pE1QRpJImxxrnDFujdbFNFzvjRCv2A0z+3UUqtWdoM1kfJ8k?=
 =?us-ascii?Q?wfj5xkBXAPqbC8hW0/iQT0/+bZdA8QU34oEIYl6AZiCywzDtH4dY6PLp+/1P?=
 =?us-ascii?Q?nig7UugboUvwGMEJ+LiOefKkL9kWJeoo1syN3pXwwHjOTDxJnWB1Mn9ILJgW?=
 =?us-ascii?Q?iUL22TzalcTJ4lOC5trfdfuZGnNChyhR8iRmiBTUev6U9gwwVmRdjspc6dw9?=
 =?us-ascii?Q?nEzNusU3bpo1GZ3WWAiz5n6im6KRkVgt94aBqhfMAz0wQPhyQ/sKcTk2Pl0L?=
 =?us-ascii?Q?iMkRGGZxpkmi0r9yp5U/ma4fzvVej2T5yqhbJJk3s0Kv3AI4emnDly6nUoPN?=
 =?us-ascii?Q?nknkyyUqpe3bVmVl6hCsUpox/dhXCzDWjbcRRT/yv0oTcR5vAKo/f1rmVmdP?=
 =?us-ascii?Q?2MybGZCY+2NODjhtHFhUDJXDBqQIBXriSEtfREbcO8pfV5z4wfaz3hFeQFVE?=
 =?us-ascii?Q?ITwwUW8RBmNyjUTP3oUNpzx1iiumI7AWN8A4lZKlq4Lz50b9Bn93mmPCoX4K?=
 =?us-ascii?Q?mA2lOz2zRFxA6IgG6zOQm5sh22sBIEufUZQrtCDSQy1Rc1pT6sKXsuXJwbaD?=
 =?us-ascii?Q?leoULgrT68XHm1n/SNTBUJuW2gWqAIC1BqjlS42bInD0tJrd6rw58rSX/CsG?=
 =?us-ascii?Q?775hcG79PEBgaiLAFdhezsu5C6Z00vtqdEYWRpRWNIqk7oRvd2d/y8mFQgHE?=
 =?us-ascii?Q?Rxn9UxCA9cf+19NLjn1M2tR6LO9Al03YSZN1vj6ZyuGw+iIh+fnCXzbe75x7?=
 =?us-ascii?Q?HDNZHK/AVHy+OoHAn4FWYrLp9VBactVq0xggPTE76DWSR6dNclSeec+tEmDv?=
 =?us-ascii?Q?RswwjsbqpHd8DBVNPQ8PnNbLMkeLDsOZdVrMSih7Vxli/cNX1YFu1a92kyAu?=
 =?us-ascii?Q?hbRXbrY55bHpS+BRScbJLo0acQaHAgFvIA1d4SQ6KWgDi0p7LV8Q4m+8NiH1?=
 =?us-ascii?Q?5StqAajHBRE+BMQfxoi7va5higgbnZxVrjS8z8PlSEYgz4fEUFKkpxXtQ50k?=
 =?us-ascii?Q?nb9wAAA+uTsKLT1UMgewL0aVJOz7opr2n+CzRQqZgNezBUR77s4X17NArDrl?=
 =?us-ascii?Q?8KS0t4w/5EvmZQAjZtaQ3OgPbOCkz34eE5vxgRAx/IhSpQ6LVjLh5JHTgJV1?=
 =?us-ascii?Q?pL7lXTJm75AwCOnld6RU9r59hVV5tn6atlpGvuCRQRQx2lj9DJV8kTxj4uzC?=
 =?us-ascii?Q?66MZIoebLWMdtEYCvZIsmY0pG/jd8vRA2RIQ+QlvEqHIvigX+lA9mqtN8MHS?=
 =?us-ascii?Q?rMdsrCg1NxnIpbxXbwTUqqsd44b6bGcm5C7kEeGm1gksa80uXJwl/VvAf3pZ?=
 =?us-ascii?Q?Wd2UeN4EZEj6/GpHg2mlUIM7ggS6BRJzckVoCaJ0WavlfCR8I+mq23rQSFxp?=
 =?us-ascii?Q?ULSV/K75JpGEaeLRYJLQRHI36Ku72wRSfWL4Y4eF3dnGMeyZMppEJRHKql3W?=
 =?us-ascii?Q?cSReZeT3atZzBf6lR6RnVP8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abc3400d-4f96-4bf0-6055-08d9be158589
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 08:49:49.5208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LpDU5w/tzxOrxGc7PA5sRzVtgcU23iYlgCC57tZiv17WV+DLTdDvMbaKjGwqS3iVfW4KK/5JT+PQVr1waqu+Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5328

On 10.12.2021 16:06, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:52:14AM +0200, Jan Beulich wrote:
>> ---
>> I'm not fully sure about allowing 512G mappings: The scheduling-for-
>> freeing of intermediate page tables can take quite a while when
>> replacing a tree of 4k mappings by a single 512G one. Plus (or otoh)
>> there's no present code path via which 512G chunks of memory could be
>> allocated (and hence mapped) anyway.
>=20
> I would limit to 1G, which is what we support for CPU page tables
> also.

I'm not sure I buy comparing with CPU side support when not sharing
page tables. Not the least with PV in mind.

>> @@ -288,10 +289,31 @@ static int iommu_pde_from_dfn(struct dom
>>      return 0;
>>  }
>> =20
>> +static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int nex=
t_level)
>=20
> Nit: should the last parameter be named level rather than next_level?
> AFAICT it's the level of the mfn parameter.

Yeah, might make sense.

> Should we also assert that level (or next_level) is always !=3D 0 for
> extra safety?

As said elsewhere - if this wasn't a static helper, I'd agree. But all
call sites have respective conditionals around the call. If anything
I'd move those checks into the function (but only if you think that
would improve things, as to me having them at the call sites is more
logical).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 09:24:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 09:24:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245898.424165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhYZ-0002HX-EO; Mon, 13 Dec 2021 09:23:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245898.424165; Mon, 13 Dec 2021 09:23:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhYZ-0002H6-7u; Mon, 13 Dec 2021 09:23:39 +0000
Received: by outflank-mailman (input) for mailman id 245898;
 Mon, 13 Dec 2021 09:23:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=7HxJ=Q6=gmail.com=geert.uytterhoeven@srs-se1.protection.inumbo.net>)
 id 1mwhYY-0002Gy-Ou
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 09:23:38 +0000
Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com
 [209.85.222.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 593aa127-5bf6-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 10:23:36 +0100 (CET)
Received: by mail-ua1-f50.google.com with SMTP id w23so28024565uao.5
 for <xen-devel@lists.xenproject.org>; Mon, 13 Dec 2021 01:23:36 -0800 (PST)
Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com.
 [209.85.222.43])
 by smtp.gmail.com with ESMTPSA id p46sm4070497uad.16.2021.12.13.01.23.34
 for <xen-devel@lists.xenproject.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 13 Dec 2021 01:23:34 -0800 (PST)
Received: by mail-ua1-f43.google.com with SMTP id n6so28071736uak.1
 for <xen-devel@lists.xenproject.org>; Mon, 13 Dec 2021 01:23:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 593aa127-5bf6-11ec-bf02-3911bdbc85ab
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=7JQ6xhDuC8UGs/jm3YR6x8QoCCs8KyehtdxluDCRZKo=;
        b=z3dP0ilTwwNTFIG2zDDB+21srqDYIITV8Xs3OaZSyqIOvGl+EP6vDsiGysk/piDgcC
         2PzZHjLe+2RpQ1+xBRmW9cirXAA7fg/34BXhnwOu/Xe4M0aUMzic2Eh5dA/3vFN+9+/S
         luafk+cA6C25+xupGUSSmpHWnN8Avxfvu7Zzge15TJUl2uB/Yc4Ykibwcc8CfESbllsB
         QcV2SK9RoqodbCSz/+aZOG3WLdvamKlxW3CMdDTjnJ3Nu/fZK+DmMHDGhF///V/3Ksu+
         LZlXFxrqymzSXmLtL/eoNHLd8NqtZst1Tq0lisCVpLbg/7lRtAExiFWZBP3p8WnBw3fM
         X5/w==
X-Gm-Message-State: AOAM533mAiKDx85c2UPzk8dRQIIa/YdspHYK06gsaYEj/VDPx9WnChRZ
	WGNoHG3A0QR3kzO+0LZBtLknA1iUXQ1vxA==
X-Google-Smtp-Source: ABdhPJycpHNND4n/wrsHreJDjBldsE0W9MUNVpaASuXxMopzz2eaxZxHWqASrFhWeEHZZd2Ku6CPMA==
X-Received: by 2002:a67:b917:: with SMTP id q23mr27480169vsn.80.1639387415315;
        Mon, 13 Dec 2021 01:23:35 -0800 (PST)
X-Received: by 2002:a67:c106:: with SMTP id d6mr26074577vsj.77.1639387403608;
 Mon, 13 Dec 2021 01:23:23 -0800 (PST)
MIME-Version: 1.0
References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-6-digetx@gmail.com>
 <YaLNOJTM+lVq+YNS@qmqm.qmqm.pl> <033ddf2a-6223-1a82-ec64-30f17c891f67@gmail.com>
 <YaQeQgbW+CjEdsqG@qmqm.qmqm.pl> <091321ea-4919-0579-88a8-23d05871575d@gmail.com>
 <CAJZ5v0jMvdhfBqjY+V9h_Z6EH1ohuJH+KjuGiOw_Jor1Tnp7vg@mail.gmail.com>
 <45025b2d-4be1-f694-be61-31903795cf5d@gmail.com> <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
In-Reply-To: <CAJZ5v0ieTwnBVjW8R_VTdPFH3yr5AwLc+ZEG5N3KrpTH+j8qZw@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 13 Dec 2021 10:23:12 +0100
X-Gmail-Original-Message-ID: <CAMuHMdXW1bCLkJhC1Jnf2rkS1rBnXsMX=4LMVdXDvMV5HOzrLw@mail.gmail.com>
Message-ID: <CAMuHMdXW1bCLkJhC1Jnf2rkS1rBnXsMX=4LMVdXDvMV5HOzrLw@mail.gmail.com>
Subject: Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Dmitry Osipenko <digetx@gmail.com>, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>, 
	Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, 
	Russell King <linux@armlinux.org.uk>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, Guo Ren <guoren@kernel.org>, Greg Ungerer <gerg@linux-m68k.org>, 
	Joshua Thompson <funaho@jurai.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Sebastian Reichel <sre@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Greentime Hu <green.hu@gmail.com>, 
	Vincent Chen <deanbo422@gmail.com>, 
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Helge Deller <deller@gmx.de>, 
	Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, 
	Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, "the arch/x86 maintainers" <x86@kernel.org>, 
	"H. Peter Anvin" <hpa@zytor.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, 
	Juergen Gross <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>, Len Brown <lenb@kernel.org>, 
	Santosh Shilimkar <ssantosh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>, 
	Andrew Morton <akpm@linux-foundation.org>, Guenter Roeck <linux@roeck-us.net>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, 
	alankao@andestech.com, "K . C . Kuen-Chern Lin" <kclin@andestech.com>, 
	Linux ARM <linux-arm-kernel@lists.infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-csky@vger.kernel.org, 
	linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, 
	linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, 
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-riscv@lists.infradead.org, 
	Linux-sh list <linux-sh@vger.kernel.org>, xen-devel@lists.xenproject.org, 
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, 
	linux-tegra <linux-tegra@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 10, 2021 at 8:14 PM Rafael J. Wysocki <rafael@kernel.org> wrote=
:
> On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko <digetx@gmail.com> wrote:
> > 10.12.2021 21:27, Rafael J. Wysocki =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko <digetx@gmail.com> w=
rote:
> > >> 29.11.2021 03:26, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=B5=
=D1=82:
> > >>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote:
> > >>>> 28.11.2021 03:28, Micha=C5=82 Miros=C5=82aw =D0=BF=D0=B8=D1=88=D0=
=B5=D1=82:
> > >>>>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote:
> > >>>>>> Add sanity check which ensures that there are no two restart han=
dlers
> > >>>>>> registered with the same priority. Normally it's a direct sign o=
f a
> > >>>>>> problem if two handlers use the same priority.
> > >>>>>
> > >>>>> The patch doesn't ensure the property that there are no duplicate=
d-priority
> > >>>>> entries on the chain.
> > >>>>
> > >>>> It's not the exact point of this patch.
> > >>>>
> > >>>>> I'd rather see a atomic_notifier_chain_register_unique() that ret=
urns
> > >>>>> -EBUSY or something istead of adding an entry with duplicate prio=
rity.
> > >>>>> That way it would need only one list traversal unless you want to
> > >>>>> register the duplicate anyway (then you would call the older
> > >>>>> atomic_notifier_chain_register() after reporting the error).
> > >>>>
> > >>>> The point of this patch is to warn developers about the problem th=
at
> > >>>> needs to be fixed. We already have such troubling drivers in mainl=
ine.
> > >>>>
> > >>>> It's not critical to register different handlers with a duplicated
> > >>>> priorities, but such cases really need to be corrected. We shouldn=
't
> > >>>> break users' machines during transition to the new API, meanwhile
> > >>>> developers should take action of fixing theirs drivers.
> > >>>>
> > >>>>> (Or you could return > 0 when a duplicate is registered in
> > >>>>> atomic_notifier_chain_register() if the callers are prepared
> > >>>>> for that. I don't really like this way, though.)
> > >>>>
> > >>>> I had a similar thought at some point before and decided that I'm =
not in
> > >>>> favor of this approach. It's nicer to have a dedicated function th=
at
> > >>>> verifies the uniqueness, IMO.
> > >>>
> > >>> I don't like the part that it traverses the list second time to che=
ck
> > >>> the uniqueness. But actually you could avoid that if
> > >>> notifier_chain_register() would always add equal-priority entries i=
n
> > >>> reverse order:
> > >>>
> > >>>  static int notifier_chain_register(struct notifier_block **nl,
> > >>>               struct notifier_block *n)
> > >>>  {
> > >>>       while ((*nl) !=3D NULL) {
> > >>>               if (unlikely((*nl) =3D=3D n)) {
> > >>>                       WARN(1, "double register detected");
> > >>>                       return 0;
> > >>>               }
> > >>> -             if (n->priority > (*nl)->priority)
> > >>> +             if (n->priority >=3D (*nl)->priority)
> > >>>                       break;
> > >>>               nl =3D &((*nl)->next);
> > >>>       }
> > >>>       n->next =3D *nl;
> > >>>       rcu_assign_pointer(*nl, n);
> > >>>       return 0;
> > >>>  }
> > >>>
> > >>> Then the check for uniqueness after adding would be:
> > >>>
> > >>>  WARN(nb->next && nb->priority =3D=3D nb->next->priority);
> > >>
> > >> We can't just change the registration order because invocation order=
 of
> > >> the call chain depends on the registration order
> > >
> > > It doesn't if unique priorities are required and isn't that what you =
want?
> > >
> > >> and some of current
> > >> users may rely on that order. I'm pretty sure that changing the orde=
r
> > >> will have unfortunate consequences.
> > >
> > > Well, the WARN() doesn't help much then.
> > >
> > > Either you can make all of the users register with unique priorities,
> > > and then you can make the registration reject non-unique ones, or you
> > > cannot assume them to be unique.
> >
> > There is no strong requirement for priorities to be unique, the reboot.=
c
> > code will work properly.
>
> In which case adding the WARN() is not appropriate IMV.
>
> Also I've looked at the existing code and at least in some cases the
> order in which the notifiers run doesn't matter.  I'm not sure what
> the purpose of this patch is TBH.
>
> > The potential problem is on the user's side and the warning is intended
> > to aid the user.
>
> Unless somebody has the panic_on_warn mentioned previously set and
> really the user need not understand what the WARN() is about.  IOW,
> WARN() helps developers, not users.

Do panic_on_warn and reboot_on_panic play well with having a WARN()
in the reboot notifier handling?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 09:46:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 09:46:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245903.424176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhuO-0004wN-5m; Mon, 13 Dec 2021 09:46:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245903.424176; Mon, 13 Dec 2021 09:46:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhuO-0004wG-2m; Mon, 13 Dec 2021 09:46:12 +0000
Received: by outflank-mailman (input) for mailman id 245903;
 Mon, 13 Dec 2021 09:46:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0LF=Q6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mwhuM-0004w6-Vc
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 09:46:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d379ad6-5bf9-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 10:46:06 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d379ad6-5bf9-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639388766;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=0Sq8Zl1Ll3Th3Gv0t2nHSOOwJKe6TJjDdPUIJ7+qFek=;
  b=TpUG4NZWDSX0BFne2BnKM+rqRKVjjYIBrxAO6AKG/aFu/z28Xv+5EBFj
   f99jdlShr5qiMSehbQZoFAyye5yvrMbrCoiYBUmFn3cvtwK7BQzgCT3J3
   esWUaZlLcw7LWCvj8giXlSyqEI85v5ubktY+UQV2zb+r0cYHdu1tukp/0
   s=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: rlsmQixTcEc59mcTlm3rnJrGXfBuUPQT1UWpBkRphYsxrbyBkGB72/V7Jg42+BLuPIYOEnGu/f
 wDTgzCmxqfrfIoOJbFYuq8sqSsmtcJUz2/8JP6eCiKthdAzS0F25Sd2J/PitKmAZ8QfeB5ewOM
 KigecMNXZSvaKmcMLR1/R/mmLxwJK92otVJ07d3viglTA/pIV6DCycUGpd7ju4oTAJBPt9F0zW
 ugmpBilSvAARy1AYcJv2ipWwD5wCPY6W1zyiq1ASz5h9Lz9484Rvv5LoeRozAkWPurNxxD2gw9
 ekd/bDbZA+UX8Y8bt078/Uc2
X-SBRS: 5.1
X-MesageID: 59811934
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:dA2RIateeYSbcoUnj9+YagTU+ufnVMtZMUV32f8akzHdYApBsoF/q
 tZmKWvUOPfbYmTyeI0kbYm39RkDv5bdxtU3HQVp/ntnQylH+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy2IPhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpllrCqRCcZN5P3qukHQTMHMRlRGrdG0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY25EeRK+PP
 JZxhTxHUA/baE1VZHgrOcg3vMz2uFymfA0BgQfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRGQoGPdaSzT6E9HOEheLVmy7/HoUIG9WQ6fpCkFCVgGsJB3U+VES5iem0jFakXNBSI
 FBS/TAhxYAw/kG2Stj2XzWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0
 UWG9/vxDCFrmK2YTzSa7Lj8kN+pEXFLdylYP3ZCFFZbpYm4yG0usv7RZvVPCqOVvtTLIgP92
 SKg8woGqJIJjedegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5
 SFZwJbGsIjiGLnUzHTVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX
 KMxkV4IjHOwFCHzBUOSX25WI551pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE
 c7FKpf3VipKVPk3l2PeqwIhPVgDnH9W+I8ubcqjk0TPPUS2OhZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbec1MOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLNOmyAM0h9C1jZkTB/z+AghAeXGpm149GH7Mfdrg77u1zi/lyS
 vgOYcKbBfpTDD/A/lwggVPV9eSOrTyn2lCDOTSLej86c8IyTgDF4Ia8LADu6DMPHmy8ss5n+
 ++s0QbSQJwiQQV+DZmJNKLzng3p5XVNyvhvW0boI8VIfBm++oZdNCGs3OQ8JNsBKEufy2LCh
 RqWGxoRucLEv5QxrIvSnamBoorwS7l+E0NWEnP197GzMSWGrGOvzZUZCLSDfCzHVXOy86KnP
 L0Hw/b5OfwBvVBLr4sjTOo7kfNgv4Pi/uYIwB5lEXPHa0WQJolhenTWj9NSsqBtx6NCvVfkU
 Ey45dQHa66CP9noEQBNKVN9PPiDz/wdhhLb8e8xfBfh/CZy8beKDRdSMh2LhHAPJbd5Ktp4k
 +IoucpQ4A2jkBs6dN2Bi3kMpWiLK3UBVYQht40bX9C32lZ6lAkabMyOEDLy7bGOd85IYxsjL
 TKjjabfg6hRmxjZeH0pGHmRhedQiPziYvyRIIPu87hRpuf4uw==
IronPort-HdrOrdr: A9a23:QWdcHqMIJDGIK8BcTs+jsMiBIKoaSvp037BL7SxMoHluGfBw+P
 rAoB1273HJYVQqOE3I6OrgBEDoexq1n/NICOIqTNSftWfdyQ6VBbAnwYz+wyDxXw3Sn9QtsZ
 uIqpIOauHNMQ==
X-IronPort-AV: E=Sophos;i="5.88,202,1635220800"; 
   d="scan'208";a="59811934"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FUv1Ke8ECtu2NbVJjm1w4otV8vt516LfU5P2bT4KosKXHCBLqt6J7DyipEqIIA/fJ/Y0WwEEibUrSXYv3fQSgZerDnMY2463uIOgZHdWGtFFkqm6mcfwDMFxdkCuS50OSHFWTCdw5bwwdX9y5wv6VUPEe9/2uojzK+bNvdmoZQH69bO8+xdacQmP6FeYYvdtHRK0siE0JJ745/bqgaa5+H+30c0WsjG3fD3EkzMQKQdVZP910RrWeU+YsjVQOQU+Zr+hQULHw1F0Zvzo7jp/c4ehHNOFxdPM8VYdsFT8mYLn/nvqT9ZssG5Q7V4KUTLkmKiC+v7ELwCOfTkLdVyzww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VhCULhHec/tuhqvDPjk6+vqcrVCSdujL89mIN6CkgDc=;
 b=Gy9PfOckdjMHB3/Rbu/qOAmkVoZoRGze0FeG5zhh9Qm+ZO9UEkoI8+mVItHAx+1GnUK93FcT7HiB169WYNBxSQjRj1rod8LGCkZfUq3yI6/eh/+G3ggT6P9T9kxpxbz2NE4LKqC5VAGtucDCeDjczDnqNHClWVXDjdMtixHqrG/84e9QIJF0JiCJaez3T22At1m6M4K722Whsd9Tv7MfgTAC//WfljO9+QmzAxtA9e6XFghEpMoqQPjzty8FPFMZgCDc7584iJF5Pi9oVYxYkldhj59WvCWSa04P5BZ0g14ka9z3su8VuQa0hv4OO1TmMvnRbu6sgCy4VJOw+wwF5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VhCULhHec/tuhqvDPjk6+vqcrVCSdujL89mIN6CkgDc=;
 b=dT0csxKgu5rlhez6d8xwlxIlkOSDPp5fB/ASDLQQgmVGXqD0Qas1gC+Gc7va7fY6nCY0m8UjS3urdMltoI7geAQsh077cbbtXK4lcMwheSX8JCrdGtv42nD/KvjhcWhQBgBMt3FRpxMrK3d/yUKhgAoDdD7czPH381n82zJHo30=
Date: Mon, 13 Dec 2021 10:45:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Paul
 Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Message-ID: <YbcWVRFFXerNqBPy@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
 <YbNtBPv1M1lIyEOd@Air-de-Roger>
 <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
X-ClientProxiedBy: MR1P264CA0068.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::33) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6aac6334-339d-4be3-c268-08d9be1d5f88
X-MS-TrafficTypeDiagnostic: DM5PR03MB2489:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2489E0A7DF21BC37D6546B798F749@DM5PR03MB2489.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gWraDrqXXd2XSCnoJ7GOMwTYyE/n9DxfGRFmhA98aPLJWg4AU+RSTGZugenUAeNpvkTzRetwB7L76j0WVE0jUghalmI3ZftEAEF4eIdWba8VYIDidjb2z+mbwjvNrcj9m87ecvThvhRu1oDmywjBv9GHdr1cWs3RAyhOpGoUu+82hRW+9NxTBabveFFN3XU9ktJonHU36gTsqF+vwYPKd4aa4ycOcxA8z+5Zm6zC8epvVUxxaHSXHgiVLChvgWoI5SnYWwsxZSS3KZnJtlFJP6G6IkoNTT0ZcCaENeK8/xn/ksVD6Fda9xNslvPv3NfsXIBfWKSBy+FZZXgiDjgq86+4rdLXofvywxGWrp/7K9i4gnXZ7H+per5Oz4xj+y9xIjft6XgOzmMnecRofGwQ5Mmr+HTINueWqHihQ2wTVPzHHU94hkF8jPxbU9wqjHD/vUASOWww1Yb7hOcrHm9GQCOKkjksUKMSGgc111MtgvJHSdtAiX8MSI6sUD2dForsZXU4gZyrSOn8gJOJmPoT1rBdUCDWz1g56dkevT01e+EF+RACz8+n3D+QPNMj4YAdwau20mrov80blUFuWo+2QtyYb43iovU2CjyM2n5SlwnnURc3HQX4D3nTfK7n2awqqJXMlkbW9nbES3wBDQYufw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(54906003)(82960400001)(38100700002)(33716001)(6512007)(85182001)(8936002)(4326008)(2906002)(86362001)(66556008)(5660300002)(26005)(9686003)(508600001)(6486002)(66476007)(66946007)(6916009)(83380400001)(6506007)(53546011)(186003)(316002)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWlMaXdwSDN0bGZScjNiM0VVUlpXd3lsVWxuWmRCVm5DSVZ4RVB5ak5nTWRJ?=
 =?utf-8?B?ejdtYkdwaERSMjU2aEFnU3BCdzhZd3Zjc21leTUzcnU5bFhhb3V0TkJ4WnR0?=
 =?utf-8?B?UU43aCtYTWpnTjMxTUlLYTdXMEZHalp3ZCtHTTFpN3VBZ0huZUJmZ1RwQ1ZF?=
 =?utf-8?B?SXE1ZDFZakphVjVaNldteTZMN0UyZnhSeWFoamdyQTEvYml3WVRYY2crbUlG?=
 =?utf-8?B?cnFwdEJiNnNPamZWY25BTGhNVVJnelFQbFZpQ0plYllrTzkrN0NWeVBKcGUv?=
 =?utf-8?B?cGRDRUx2Uy9SMkIyQ1p0SkpIUS9TbGFFeitEb0h0aWR5VTZhbjBmb1FscjJp?=
 =?utf-8?B?TEJzZURoZzJETVZaQjJHNlo1Q1hOcE5TKzNaU0JHOG44eUtNc2t2cFFpaG5t?=
 =?utf-8?B?MHRRYkhyVG1PTTUzc0FrODE1akRKU29oLys4Tm9ybXJEWHJyeEtiTUtJMXl3?=
 =?utf-8?B?bDNBT0ZRQ0h3NXIvWFpwc0N6MWdtY1RpV1lTWG5qTDYzclBldXVVbkY2MmFa?=
 =?utf-8?B?ZEt1aUMyek84TWJQVnRmK0xMOUQ1RWgyMUo4ZUk3L2phdEF6ZjV4K0hWMmVZ?=
 =?utf-8?B?dVZmb0NQNEM0Zkdkbk96by9BenpoRVpxZUdydEw2dVdRTytxM2FjNUpHMzRz?=
 =?utf-8?B?QWtZM3E0RmVORjZpWGpoRys2Z0NtdnBJK2ZEM1JhK2hVRUpTd1VObW1kYVBP?=
 =?utf-8?B?V0ZvK1E0N1JUV0lyam9icU4wTEx4SnhmRDRrbWRJSjg5dmhra3pRSUFJMzJH?=
 =?utf-8?B?Z3NkMk9PdWFJZWNuTWJsbXJnSHBJbExIWFo1cmlpVUcyK1d3QTE2NHBnRTVr?=
 =?utf-8?B?eHI0SW52ZEZhV3k3NU53b05Rajg5ejN6WGtoYjVwKzlQMU5tSUcwU2tuT0x6?=
 =?utf-8?B?dVpDc3BXS2JrQk50dGlnMmh5TklDUkVaVW9LMWRHOFRIc054T1kwT0t6RStY?=
 =?utf-8?B?a2FXR0x0N08yYnlwNG11c1dNNWhQQTdiU05RRHU0QllHa2FRbGk0blpMQUdQ?=
 =?utf-8?B?WDRmamRNTFRHUUNhN2hUS0tmY2w3Zy8raTdvVHhuOXc4VGJvYUpxaHF0cmFj?=
 =?utf-8?B?SU12YUovQWdNRnR6TVVFclJKVnIvMzJmVW1jWGJxbTNsb21NaDNtc1E0Q01t?=
 =?utf-8?B?Sm5Ta2Z2RDRLZjAxTkRTcndaMmd3SWpKVmgyb0xweW5JV1NRb2FyUXNFRXdW?=
 =?utf-8?B?ZEdYM1FoYVVvdUpvNHVTd282cEVyQURkem9YOWhrL3hZSDY4WUNweWJXSVkr?=
 =?utf-8?B?encyWnZqMlVieVN4VEtEOE1ldGQ5aFdUSzRldTNOVjh4K0FkNEZnVDBQQWxm?=
 =?utf-8?B?T0JRZ1pzVTJhS09FN084OEdNMG4rVWRwRkhmSExTaklMbW9kR1JGUTZ3ekRI?=
 =?utf-8?B?d2pKZmZ5VjZZcGZqTXQ4b1NpMllTUUpqaFd4N09qRnhueFRMNFNkaXBnYkJl?=
 =?utf-8?B?YWZoaTU2VTh4UkVvZmUzWU5vcDNIaCtXazZpS2FCVGhmRzNQak83a3ZCMGZY?=
 =?utf-8?B?UkJQV1BPYjRpRXFZODdMSDJGRkwvMENIQWsvZ0dYekhCQm9HWWg5VWlhTElx?=
 =?utf-8?B?U0pHMjRjZmQ0Nlp1T3I5a3ZhbzZTdVNwUUJIUk1ValNNSFdPMzJlNjNTWFhl?=
 =?utf-8?B?dmlIUEsxV080d2RncFpSU0xKNTJIUU9JN0lYeW1idC92QTM1TmpudmRFeTFP?=
 =?utf-8?B?dnkvV3JjNnMwRUJkRExNV043NHJXY211Ry9KNG5nSEVtSmlEeDFlRHRHNFg2?=
 =?utf-8?B?RVE5N1FOV2VTR2VNTDlJVjhPZ3JvcW5TWkNXaWw4MGZjdWJuRkRJSzNxU08r?=
 =?utf-8?B?V2F1Ynk3dHBQd1RhRHNjM3V1TDk5ZlVZbG5WYTI1SWtMbjlkWTM2UVdHRm1q?=
 =?utf-8?B?S1MrajhGekhJaG1XUGI3WWpWeHVlenBZMG1oMk90T0MzaE9UcXZ4d2dBSjEy?=
 =?utf-8?B?ekxvUlRDWWVJMVZqa0xBM0xQa1VNUkNaWm1vNEg4Y3F0MXZyTWF5c2JYbzgx?=
 =?utf-8?B?ZkJXMXp0ZUl0YnhYbktRWG9EcEZ3VTRtS050alRDbWsrNFpvWnlsUDVjVStF?=
 =?utf-8?B?ODNxcCs0UlN3Z2tLVFUrMVg4blFpbDV4cWlWbXp5dGFScXpxOVVkd2c4UGlq?=
 =?utf-8?B?L25LQmtyQ2JRajB5Wnk2RjBWaWpUN2loNzdVaUlKSjU3QjY5NHVzdnBYTlJj?=
 =?utf-8?Q?Sz9Wg2rp/5WdZSNyaQR47zo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6aac6334-339d-4be3-c268-08d9be1d5f88
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 09:46:01.8122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ohy/XJwTyi6fH83CXNTGYIRltyz/oc5bdYvNZpq4L9BUMoRQb1j7moC52eNJQPVCLC/BHP1CL4ExUC89DAJy8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2489
X-OriginatorOrg: citrix.com

On Mon, Dec 13, 2021 at 09:49:50AM +0100, Jan Beulich wrote:
> On 10.12.2021 16:06, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:52:14AM +0200, Jan Beulich wrote:
> >> ---
> >> I'm not fully sure about allowing 512G mappings: The scheduling-for-
> >> freeing of intermediate page tables can take quite a while when
> >> replacing a tree of 4k mappings by a single 512G one. Plus (or otoh)
> >> there's no present code path via which 512G chunks of memory could be
> >> allocated (and hence mapped) anyway.
> > 
> > I would limit to 1G, which is what we support for CPU page tables
> > also.
> 
> I'm not sure I buy comparing with CPU side support when not sharing
> page tables. Not the least with PV in mind.

Hm, my thinking was that similar reasons that don't allow us to do
512G mappings for the CPU side would also apply to IOMMU. Regardless
of that, given the current way in which replaced page table entries
are freed, I'm not sure it's fine to allow 512G mappings as the
freeing of the possible huge amount of 4K entries could allow guests
to hog a CPU for a long time.

It would be better if we could somehow account this in a per-vCPU way,
kind of similar to what we do with vPCI BAR mappings.

> > Should we also assert that level (or next_level) is always != 0 for
> > extra safety?
> 
> As said elsewhere - if this wasn't a static helper, I'd agree. But all
> call sites have respective conditionals around the call. If anything
> I'd move those checks into the function (but only if you think that
> would improve things, as to me having them at the call sites is more
> logical).

I'm fine to leave the checks in the callers, was just a suggestion in
case we gain new callers that forgot to do the checks themselves.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 09:49:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 09:49:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245911.424187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhx2-0005c4-O9; Mon, 13 Dec 2021 09:48:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245911.424187; Mon, 13 Dec 2021 09:48:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwhx2-0005bx-Kz; Mon, 13 Dec 2021 09:48:56 +0000
Received: by outflank-mailman (input) for mailman id 245911;
 Mon, 13 Dec 2021 09:48:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwhx1-0005bP-1A; Mon, 13 Dec 2021 09:48:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwhx0-0000wO-NV; Mon, 13 Dec 2021 09:48:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwhx0-0006Xr-AE; Mon, 13 Dec 2021 09:48:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwhx0-0008Qp-9m; Mon, 13 Dec 2021 09:48:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=41Qfxc2I7QGMcWoD9AMxYOimxLeHuDHwKZh732GNPy4=; b=bgVZEtc0og//5zBMy/1S70l5Y9
	S2HvJNmmO/FNNXqO3vPWzwRRU1hfiqrGwkLSg3ElCMfYIq/XHy8I6ZjburKM5NYOhhI4/W8LEioZu
	aBxfZMT1AafPBhwg9qnF0+SPn1EQDz+q1+TIu8Ha8b+LZCa625iKe1UWA6K21lOek8rc=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167387-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167387: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 09:48:54 +0000

flight 167387 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167387/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167381
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167381
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167381
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167381
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167381
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167381
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167381
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167381
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167381
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167381
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167381
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167381
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167381
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167387  2021-12-13 01:52:51 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:00:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:00:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245918.424201 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwi8G-0008Ec-MP; Mon, 13 Dec 2021 10:00:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245918.424201; Mon, 13 Dec 2021 10:00:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwi8G-0008EV-JA; Mon, 13 Dec 2021 10:00:32 +0000
Received: by outflank-mailman (input) for mailman id 245918;
 Mon, 13 Dec 2021 10:00:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwi8F-0008EP-8G
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:00:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80e83307-5bfb-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 11:00:30 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-pB12RiAaOwutK9JNJGSg6w-1; Mon, 13 Dec 2021 11:00:28 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Mon, 13 Dec
 2021 10:00:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 10:00:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80e83307-5bfb-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639389629;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=3iNKq8iaWxI3vMYsCQThMcoHbLzsqbieUcAs4lwiZDs=;
	b=cQdjKUvapibaFMUb/UVU/VAgH0JtP++hQzvfVjKlBqk6ebXXttaebLWSlugfDjFOL0sPVE
	zNrGvO8qV2b46yWnyBE+/2YtAiH8GrG892Tnv4Tif/fLXYK+kTFmhaFxbBOCsopuMNJcvB
	QhlWvKz/tps0+xiQIC7GvOrvQF+0MHI=
X-MC-Unique: pB12RiAaOwutK9JNJGSg6w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iwj+sRt3t/HrrDBj+QhwGAcqcQZr1rr1dFDi3Jnqw1kwlUqytwJ24OY1/GEMDd16C32sHrunYhrmGjsOwTmbiGeEaUEnEQ3N7dqPb8CTwqgwP8MwTL/Mose9IQfD6X8qPFbaqaNxARexvUt2DC6U2Wiz5trZOjL/qFz4W2rCvY/BCDeBib+EoMTWw4yMUWcE9oYS2SPDJS0WPYaVm4eTyiHhS9q9tmXJNiP6bxaHonjbwfrH1ceKwxsSo0u8pYHtgU8orbPlwQMSl+L2YR3ZWdnVeB51cUnzz+DyUHjgJkrFdSD//VE0GIiRzuQ6FrBw4TPckarSTox8+rqPGa3arg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9CLfSQg9QbXlvONNL9Vd6HtsIxJegeM+xe1hhehoLuQ=;
 b=isYoFkvI3Khrmqz4jRQY+nt7Bz8wtANbvAFHmTsK2pg4lZye2dRs0Pcy27t6ezsZqieq8JX/ZFGq/uT3eNrHaNYuhPlw3iWXSILiek+UqRqMbBPBPsZZf7seN2iqYlXjQC5SKH4XLb4oSafYjhvytoPPU1REoiwDiM/ZZHqhiEjvVxrmdaWkDoluDb7One7WAoqV1ymukN9/1bey9SX//iBSZT9jAOnoTyRj64xmYuBBUT2QjVKLmPUJ6eSRtcQDC0Zrl7sXxEbt2Klig4dafGP4HiNHYu/NSWRoHUWLQP5eqzD0nTfaXIj8WXvb3kwsLS6FJfnvDmWc64UXq+bD+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b766e6a4-3a28-7cd1-b35d-7bd36e80a552@suse.com>
Date: Mon, 13 Dec 2021 11:00:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
 <YbNtBPv1M1lIyEOd@Air-de-Roger>
 <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
 <YbcWVRFFXerNqBPy@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbcWVRFFXerNqBPy@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR07CA0043.eurprd07.prod.outlook.com
 (2603:10a6:20b:459::12) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a7598954-e10d-4ae5-9193-08d9be1f628b
X-MS-TrafficTypeDiagnostic: VI1PR04MB4191:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4191208647FB78D4F67D3CE4B3749@VI1PR04MB4191.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xAgHfTfGY7DKc3SmW8FuHYrZSxtzUa5jI7RZ5t4Vvs/bD35pf4fQCMIpzb7Vh/3nyCBNQabn0p17qrOCGt2M58V8jJ2hoO1B1IQO/WJzf7eYuMnEQw99kIYWurJjcMDYp70tHNaSIczYTogUX8fafUldVUSj9FSMTLm66U5a4pfx/FLvNrrY7eOhYeHlKSlvaeDhpTRM9j852tkhl3MxpIuFG38mGsAbL8/MVqytqoNJl5UnS9CvVt/Sn9C/QzIIGWu3dNtDayaNtVzHt0F/6BlGx4Lropc+X0q2yeuEIn3jpR12b6kAYsXg+rjYHGzoDUxKFYAJS5UMOTYTSnjA8cHsT5n/g3fB90Pbg8FOD9d4eIW4JS19TCJ+s/pjBmqid3w+i30M7W7oP5YXRQlhbxdOKf/8ciFuFGA6exJ1jMUk1jOPPTnEDUTDhHy24kERbIoqFpAP1a4CVl+cMXFo4wtAcceQ6eXkvaavRBUVwLTFPL+pFNy18u6U881O7HGsk9FJVyLLO3QmL7bYP0Pb9NQK9Fwe6esdbfJmnRPnvSR9hp2dw7sENcdgzdrUm1jk3TaSsHSWIJMGHmnpcDFF4fvd0HWeaSwBPjVm1FXKQqxQxwxlgHV2PwhcBPzGCF9OpEVVllf3p8hJ0Sm4vTt4bcvsGvSyEANLTowEo0y+pDj3kQtyDkMB51QIxOhmZR5jC7zMXXewlmNGG8+cJStqnn+NbvtYEwA+YeCJ4HwiuCQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6512007)(31686004)(86362001)(53546011)(38100700002)(508600001)(5660300002)(66476007)(66556008)(6486002)(8936002)(26005)(6506007)(66946007)(2906002)(36756003)(4326008)(2616005)(316002)(31696002)(54906003)(6916009)(83380400001)(8676002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q09PmuMQceIgus2quzTA4xqOR8nlr5tSRU5fI2KFX29a+tmmqNfWQKVXaLxs?=
 =?us-ascii?Q?8f84rGHSeRocbpsy3+97R2pH1uYehsHTu9AucMPjmRi6tuqAv+O9V53YB3SM?=
 =?us-ascii?Q?iYchb3hYsltubxxymngbT8EO2UYCXUoyy2WpBjeIX3TdtEqpKjNi50L4ad6H?=
 =?us-ascii?Q?ozSm9n439fR4bIDfHHWEJmLX/E1M6pDA+IT77IBOXy1BYFF/eA0gALuvuStH?=
 =?us-ascii?Q?19h3e/aHEGFtNao0FZYnpbHUeQ47xKAhryH5byo+XWycsgzcgUMpNN2CkC45?=
 =?us-ascii?Q?sRn98fTgCckJS5atYAS0Y6hHywZJMzNSzQDSUABlm2SzLGkjXU7iTeRIpwDU?=
 =?us-ascii?Q?RTAyiAnucvd7Q7C0rHvEHzSHcgld6S0CaIYb+PnNNQyCm5bPs5p2EXzMfgjL?=
 =?us-ascii?Q?1Yqt3VqTvj9kf6SxYcTOfdnWtI/vNUeA9c9nJnH5/YuGJJjqQYxyODsodG5U?=
 =?us-ascii?Q?/TxOWJzT/A0YPAz5H/a1LztHMkDmAhgA9Pnle/VXP9GOLFDBd/q4ficdDyqw?=
 =?us-ascii?Q?c3gtchy25D4ZW7KUOaby8jpgefPyVxtAqIf83lR4k8EF3uACY6pI7soVRG6I?=
 =?us-ascii?Q?mtT9BJD8NC20mk2jvXzxvgU6lejmaCf4SKhX0/Z5JV83YNvrEXMEw2606BVu?=
 =?us-ascii?Q?1nIf3nxCb2vYPqxFJ0xMRo9eyEeoWWYTyY+0pr/O7vdwk3eOfO/dtQy5KUKh?=
 =?us-ascii?Q?Jdla/N5yMYHUvotGKDdwrAjF1N7hKzE9Y4d14BVm4AiIic3FtKx6fn6RJ529?=
 =?us-ascii?Q?+9VpFl6sWdLO2zFsU4RQ0cucdRpmXi+gP0RTyq6G+dvgCW5uEeTH7gom9C8h?=
 =?us-ascii?Q?ZffjFmIZ0qwvMgPD725J7dl9Sc5rbrNtytVemMOMINwJ/D1H3fNnLcSzUajZ?=
 =?us-ascii?Q?VEWmz7qm82r0ldOu4NSWhH6vLmulQA046qdJt1YcLM9iJDJIi7KgmjT/hBKj?=
 =?us-ascii?Q?er4Y14lnu9hDdAKROdWKo5OsE+hSpKhuvptaLSTOZNAHOaBdfP7T13iBTDeb?=
 =?us-ascii?Q?ut+MPxLLYIECw8El69LI6TrOuRRToPqmy6XRnr8A6urVe2/r71HHG4W54cd1?=
 =?us-ascii?Q?zksA1J8QrTDk6Mhfeg1vVujVC8YZm6amWgynGJEysEuLtQRgqBMR8g1HQ6oy?=
 =?us-ascii?Q?1PQLZbj/gHlF4RX6wwOX9PLLfiVTS0czE/V0zmO2Kj+tk+k0I1Fc9s2mWG8q?=
 =?us-ascii?Q?0WG4v4qlHfPfUWUz5sQuLaesclDgeBWJvSAhwEZ/cWGSqbQ6yQYQ0uygG1QC?=
 =?us-ascii?Q?/I3mLcCoU7CsYZGFN8WjZsD7dNZ9NdEtCzI02xUMiG98YubtxoYutjKk43Zg?=
 =?us-ascii?Q?rFngU4WIwCvZlBmoNqCAwZpXocJ6N/ncLfnxw9ZRcALITdZFYcd1nshL/nyu?=
 =?us-ascii?Q?SMwjtqU28v2b0HB6lAZAZ4rCnei2J46qLWkA31s6tVcPuLJoyVzCWUaCMYZo?=
 =?us-ascii?Q?lK2H1sEfgUZALkGL6XBBMhexcFOBL3+taecOa97RJLYLN6RHx73o+bY/Pdvl?=
 =?us-ascii?Q?KGbj3sZ4fJoWEDueS+usZ/9sfk6hpy+ZK+aEAHyFJ/Fa0GoXpLn5EnhKebi1?=
 =?us-ascii?Q?/CMEQUXWlbELQ/po9MaFC/RfaB03wN7pc1YOAj44fzjZ3ZbIB4jqbR1tX8wh?=
 =?us-ascii?Q?zGrDDFIXfj8RpZoge+t94S8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7598954-e10d-4ae5-9193-08d9be1f628b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 10:00:25.7452
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OwbSGk/er7crJo2VDgI41F6ls3WCPcYZnB51N1U+kOf7thpAhpFCfdQNO1DfMs59ke41hqLJ79cZq6TkwLvQ/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191

On 13.12.2021 10:45, Roger Pau Monn=C3=A9 wrote:
> On Mon, Dec 13, 2021 at 09:49:50AM +0100, Jan Beulich wrote:
>> On 10.12.2021 16:06, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:52:14AM +0200, Jan Beulich wrote:
>>>> ---
>>>> I'm not fully sure about allowing 512G mappings: The scheduling-for-
>>>> freeing of intermediate page tables can take quite a while when
>>>> replacing a tree of 4k mappings by a single 512G one. Plus (or otoh)
>>>> there's no present code path via which 512G chunks of memory could be
>>>> allocated (and hence mapped) anyway.
>>>
>>> I would limit to 1G, which is what we support for CPU page tables
>>> also.
>>
>> I'm not sure I buy comparing with CPU side support when not sharing
>> page tables. Not the least with PV in mind.
>=20
> Hm, my thinking was that similar reasons that don't allow us to do
> 512G mappings for the CPU side would also apply to IOMMU. Regardless
> of that, given the current way in which replaced page table entries
> are freed, I'm not sure it's fine to allow 512G mappings as the
> freeing of the possible huge amount of 4K entries could allow guests
> to hog a CPU for a long time.

This huge amount can occur only when replacing a hierarchy with
sufficiently many 4k leaves by a single 512G page. Yet there's no
way - afaics - that such an operation can be initiated right now.
That's, as said in the remark, because there's no way to allocate
a 512G chunk of memory in one go. When re-coalescing, the worst
that can happen is one L1 table worth of 4k mappings, one L2
table worth of 2M mappings, and one L3 table worth of 1G mappings.
All other mappings already need to have been superpage ones at the
time of the checking. Hence the total upper bound (for the
enclosing map / unmap) is again primarily determined by there not
being any way to establish 512G mappings.

Actually, thinking about it, there's one path where 512G mappings
could be established, but that's Dom0-reachable only
(XEN_DOMCTL_memory_mapping) and would assume gigantic BARs in a
PCI device. Even if such a device existed, I think we're fine to
assume that Dom0 won't establish such mappings to replace
existing ones, but only ever put them in place when nothing was
mapped in that range yet.

> It would be better if we could somehow account this in a per-vCPU way,
> kind of similar to what we do with vPCI BAR mappings.

But recording them per-vCPU wouldn't make any difference to the
number of pages that could accumulate in a single run. Maybe I'm
missing something in what you're thinking about here ...

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:06:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:06:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245925.424212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiDa-0000Xa-F8; Mon, 13 Dec 2021 10:06:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245925.424212; Mon, 13 Dec 2021 10:06:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiDa-0000XT-Bj; Mon, 13 Dec 2021 10:06:02 +0000
Received: by outflank-mailman (input) for mailman id 245925;
 Mon, 13 Dec 2021 10:06:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EN0M=Q6=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mwiDZ-0000XN-Nh
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:06:01 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 460f7c74-5bfc-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 11:06:00 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id 207so22858025ljf.10
 for <xen-devel@lists.xenproject.org>; Mon, 13 Dec 2021 02:06:00 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id v7sm1429635ljj.45.2021.12.13.02.05.59
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 13 Dec 2021 02:05:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 460f7c74-5bfc-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=3+p/K/dPqEKET7hL3b9ZcXy0P4HrOlPZH162dHBl3b0=;
        b=HuvFh5OaK+Y0d9sQOEx2eg6TGSr5/5JYqu4mG/k3LSNNhxyz1tG0hZ369xcj7xEDKp
         V1coL8VfJv9IXpB+Fq3HIBbR534MpTB9zYRkRibQnCURkpbOiYdaLxI8EA/lTT9MW9GF
         IW8OLQyRLN1n+hr3VCHnPx3p0cruz6cpz9CLoQTs+iM0G0FkdmdYkihBzETMHguXksUD
         QGjZNVSCz5KUyNQGwPOj+d1UMWtFmY5FeG4ajKaOMIHEE2C/LDJ4Q1W6WCHK2npgiTpA
         jc54uozqC19dMtdhdzuidr8lknLk4nUEkq4DuHAjnjcSzyD0hM8umOGWHrLjZ++zEkjA
         opQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=3+p/K/dPqEKET7hL3b9ZcXy0P4HrOlPZH162dHBl3b0=;
        b=0pWPDcesIDJ/SQ5NzFEYUN+u1+gD945nbK1NJw4zxxcuUfnslCorSUY1xCLz8BXPDM
         iyEPOMCSG2XYDdsCQ/UWszUOnaHpk46jSD4EYUSEKT0/E8UxZefom1ot/5P9ctUm1tQD
         5gPN8kXvOMt1cnryrqg+FZcLF4OkVN92Zp4ks2D7rk6rt/rPsJ2kRnfzFzXtJm4wKEc6
         9qg+cIVaTx92017o47X6xNN3viQ0HgZ3rPFmJtwsIaYVqxor1Ih0Y5Tbc6e57ndlipd9
         fhcRFTKezd26ms/lY+wMicuJ+iMWvk99NBT2JAzcqG6tlsokysy/lp7/dIirWiJTYhxT
         TG2g==
X-Gm-Message-State: AOAM531jbHJd2UdTF+SZr2vpFh1FPpTxR8k9aDsk2EBPp4t6Dlv5hLY6
	zMXKkjt0F/97PggQnC4RVAw=
X-Google-Smtp-Source: ABdhPJzFzJtbi8+V0qC6wLsHwWcrVtsavuBz4caLCxxdKOOceWdugE0hZ3Jmu5ed1+EZgQ0OAjhCsg==
X-Received: by 2002:a2e:a696:: with SMTP id q22mr27693493lje.423.1639389960237;
        Mon, 13 Dec 2021 02:06:00 -0800 (PST)
Subject: Re: [PATCH 00/10] Add support for Renesas R-Car S4 IPMMU and other
 misc changes
From: Oleksandr <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Paul Durrant <paul@xen.org>,
 Rahul Singh <rahul.singh@arm.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
Message-ID: <3c3c8641-05f5-56b6-b7b1-6942d6bb5a3d@gmail.com>
Date: Mon, 13 Dec 2021 12:05:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 27.11.21 19:51, Oleksandr Tyshchenko wrote:


Hello all.

Gentle reminder.

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> The R-Car S4 is an automotive System-on-Chip (SoC) for Car Server/Communication
> Gateway and is one of the first products in Renesas’ 4th-generation R-Car Family.
>
> The integrated IOMMU HW is also VMSA-compatible and supports stage 2 translation
> table format, therefore can be used with current R-Car Gen3 driver with slight
> modifications.
>
> In the context of Xen driver the main differences between Gen3 and S4 are
> the following:
>   - HW capacity was enlarged to support up to 16 IPMMU contexts (sets of page table)
>     and up to 64 micro-TLBs per IPMMU device
>   - the memory mapped registers have different bases and offset
>
> The first part (commits #1-6) is a non-verbatim port of Linux upstream commits
> needed to add support for S4 series easily (prereq work).
> The second part (commits #7-8) is based on the code from the Renesas BSP and
> actually introduces support for R-Car S4 IPMMU.
> The third part (commits #9-10) is misc changes I have locally.
>
> The patch series is based on 4.16.0-rc4 branch and also available at [1].
>
> Tested on Renesas Salvator-X board with H3 ES3.0 SoC (Gen3) and Renesas Spider
> board with S4 SoC.
>
> [1] https://github.com/otyshchenko1/xen/commits/s4_ipmmu_ml1
>
> Oleksandr Tyshchenko (10):
>    iommu/ipmmu-vmsa: Remove all unused register definitions
>    iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers
>    iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
>    iommu/ipmmu-vmsa: Add light version of Linux's ipmmu_features
>    iommu/ipmmu-vmsa: Calculate context registers' offset instead of a
>      macro
>    iommu/ipmmu-vmsa: Add utlb_offset_base
>    iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
>    iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
>    iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
>    iommu/arm: Remove code duplication in all IOMMU drivers
>
>   xen/drivers/passthrough/Kconfig          |   6 +-
>   xen/drivers/passthrough/arm/iommu.c      |   7 +
>   xen/drivers/passthrough/arm/ipmmu-vmsa.c | 278 +++++++++++++++++++------------
>   xen/drivers/passthrough/arm/smmu-v3.c    |  10 --
>   xen/drivers/passthrough/arm/smmu.c       |  10 --
>   5 files changed, 178 insertions(+), 133 deletions(-)
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:11:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:11:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245931.424223 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiJ9-00025d-2h; Mon, 13 Dec 2021 10:11:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245931.424223; Mon, 13 Dec 2021 10:11:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiJ8-00025W-Vy; Mon, 13 Dec 2021 10:11:46 +0000
Received: by outflank-mailman (input) for mailman id 245931;
 Mon, 13 Dec 2021 10:11:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mwiJ7-00025Q-Sm
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:11:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mwiJ6-0001Qt-QL; Mon, 13 Dec 2021 10:11:44 +0000
Received: from [54.239.6.185] (helo=[192.168.15.34])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mwiJ6-00043o-Jo; Mon, 13 Dec 2021 10:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=uKcLra/o8CT0XOWJO19vWe6rSYJ2ENpZWqBHwxFGlbs=; b=Aa1HrnaUCU1Xi08hrf5QcXMVjk
	ntEvZhyAHFuo58q2W7IbNJbpr2pVBKLV43O8Xh/7ACQ/1tduqpIe0j0qLti/ZBg8aB0HO8kvA2WDK
	YFmX65YaChmVu3TrQBq2dQr9TalVzBDiyacWZxa7E0eEbiBUtNxwKV9WY6eZj/qNq+GQ=;
Message-ID: <0024265c-e485-8354-361b-9faa36c50a3d@xen.org>
Date: Mon, 13 Dec 2021 10:11:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH 00/10] Add support for Renesas R-Car S4 IPMMU and other
 misc changes
To: Oleksandr <olekstysh@gmail.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Paul Durrant <paul@xen.org>,
 Rahul Singh <rahul.singh@arm.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <3c3c8641-05f5-56b6-b7b1-6942d6bb5a3d@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3c3c8641-05f5-56b6-b7b1-6942d6bb5a3d@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 13/12/2021 10:05, Oleksandr wrote:
> 
> On 27.11.21 19:51, Oleksandr Tyshchenko wrote:
> 
> 
> Hello all.
> 
> Gentle reminder.

This is in my queue of 50+ patches to review. EPAM is the main 
contributor for the IPMMU patches, so can one of your colleagues help to 
review it?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:21:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:21:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245936.424234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiRw-0003Wt-Vv; Mon, 13 Dec 2021 10:20:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245936.424234; Mon, 13 Dec 2021 10:20:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwiRw-0003Wm-Sv; Mon, 13 Dec 2021 10:20:52 +0000
Received: by outflank-mailman (input) for mailman id 245936;
 Mon, 13 Dec 2021 10:20:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwiRw-0003Wc-4K; Mon, 13 Dec 2021 10:20:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwiRv-0001ag-SQ; Mon, 13 Dec 2021 10:20:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwiRv-0007Oq-GM; Mon, 13 Dec 2021 10:20:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwiRv-0000Xz-Fs; Mon, 13 Dec 2021 10:20:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=TG2G+YERBMb9T3DUgnuccLfZlZKrAwPAwrapMKboPgg=; b=N0BaqbaBX8lRFiqb8Xgm0cCVKR
	h0/f9406inRY+9OkjLw9Tnu/zSpJuEhzVeD6yXVzfq1Tz7ApNalDiIv6y3jzOflSVtjY8TT6KNoPJ
	bYQlsnYqr7i7rY6aF7NrHDoYiJrCqyAQWuTAgQ3OtUBoVQJPm7jR68nakB1q02fDhme4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167390-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167390: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 10:20:51 +0000

flight 167390 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167390/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              9402db25f8fa88a68c4b3d5b21a459b66c54ef6e
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  521 days
Failing since        151818  2020-07-11 04:18:52 Z  520 days  502 attempts
Testing same since   167361  2021-12-11 04:18:51 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 88043 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:34:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:34:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245950.424247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwifD-0005NE-A6; Mon, 13 Dec 2021 10:34:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245950.424247; Mon, 13 Dec 2021 10:34:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwifD-0005N7-6s; Mon, 13 Dec 2021 10:34:35 +0000
Received: by outflank-mailman (input) for mailman id 245950;
 Mon, 13 Dec 2021 10:34:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0LF=Q6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mwifB-0005N1-9a
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:34:33 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 40c411da-5c00-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 11:34:31 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40c411da-5c00-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639391671;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OqxaqA2184dpRVjD2g/xcuznDETl3wDT9imEzlS8BGU=;
  b=XA/ERmxcW54Hcd+aZ6LtF7TUCU46+slkywVvr4JrjAGl/Et+uBI+Lv9G
   Ukdr0D972HhplGDLsotMTFA46uaAuy63rIshHLflANo1kw4aFLxLpUjyp
   RCncfq4fNffQ7qGBfBNBr9iFEojNOUYlkfhNDiYVx2fOCp91nvc4L1MqE
   0=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: JTLLZwU4gf0vg6/25RwIaHSvNVFv3M0q3ylJyAf2koJO/l5lHylTGPntU8FbA6uIVs86aN0c0p
 RzqENwYc6PtWnH4X5xVP0DDzSCs0NO8l0YWkA8T/PjRsVBmbNftyue2+5lzLpq8tTKWADUUq25
 ZdrxwzG+8RGwTIDhaU6y2iBFcNvZVsIc16vpAIDu+PQ4hC0UH0WA1VwED2NVAh/o1KpnC4+Tfk
 9mqPzzQ4zZTNizGEtjKUeZQbyz6Bk+RqcuLKEjBobS8LzEMnxCnm93zfUX9bOyFw1pMIsclYsH
 ldMsIsmGyTEEZiZRb4XXbp/z
X-SBRS: 5.1
X-MesageID: 60261815
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xaBb+qIN2t2hjWGMFE+RTJIlxSXFcZb7ZxGr2PjKsXjdYENShjUAn
 zRODT3QPvaLMzCmKIona46z8B5Q78fcnNNkGVdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg6wLZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2qnfRp8
 soV5KfvQCgGJarvl+EibFpHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvYUGhWdp26iiG97OY
 NIfbhhRZy/8elpLH05PVp0/t/iB0yyXnzpw9wvO+PtfD3Lo5A5s1LngNvLFd9rMQt9a9m6Dv
 X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvkXKoCGbv+8eRl6HWS2W47GBAQTUG8o/Sylgi5Qd03A
 04e9zcqrKMy3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebSQjy
 1uhj97vQzt1v9WopWm1r+nO62noYG5McDFENXRsoRY5D8fLg4MXlijQFodYT6eaocbyOj71/
 A/Js31r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1
 JQRs5HGtLhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iQsJGaBj
 Kz741o5CHpv0JyCN/AfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZ3wPpkZ
 cfGLJb3VB727JiLKxLsGI8gPUIDnHhilQs/u7ilp/hY7VZuTCHMEupUWLd/Rus48LmFsG3oH
 yV3bKO3J+FkeLSmOEH/qNdLRXhTdCRTLc2n8qR/K7/YSiI7ST5JNhMk6e54E2CTt/8OzbmgE
 7DUchIw9WcTclWbc1jXMS46N+u0NXu9xFpiVRER0Z+T8yFLSa6k7bsFdotxer8i9ed5yuVzQ
 eVDcMKFasmjgByek9jERZWi/oFkajqxggeCY3isbDQlJsYyTA3V4N70OADo8XBWXCawsMI/p
 Zym1x/aHsVfF1gzUp6OZaL91U61sFgchPl2AxnCLO5MdRi+64NtMSHw0KM6epleNRXZyzKG/
 A+KGhNE9/LVqoo4/YCR16CJpoukCcVkGU9eEzWJ5Lq6L3CCrGGi3ZVBQKCDejWEDDH4/6CrZ
 ON0yfDgMaJYwAYW4tQkS7sylPAw/driobNe3z9IJnSTYgT5EK5kL1mHwdJL6v9HyIhGtFbkQ
 UmI4NRbZ+mEYZu3DF4LKQM5Re2fzvVIyCLK5PE4LUimti96+L2LDRdbMxWW0XEPKbJ0NMUuw
 Ps7ud5Q4Au600J4PtGDhyFS1mKNMn1fDPl36sBEWNfm2lgx11VPQZ3AESunspiAZuJFPlQuP
 jLJ1rHJgK5Rxxaafnc+fZQXMTGxWXjaVMh28WI/
IronPort-HdrOrdr: A9a23:EEwFKq8WTeNutZ4lhTxuk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,202,1635220800"; 
   d="scan'208";a="60261815"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=elIA1hsKJdTAQCkLNe0sJNVsgcHDfAHaTiLZ4WkQWj+x03GPlr2x5NZGCFL2lgjvruuBgAW0GTtfhktdXjNqNOxqit7Dnyhp4kavHyi00xLOI7X1DjRsKBI7aTHapcIPijcBzVaU53jgu/pAKGiuRWol9rNvTqPf7AJni8KLMiryJIYORvKcARAiBW4QnRAHtnnKv5wR4va93qO6wpOwoz2/DPqjlckFBjESfFhvdAC55NmohTnT4OWCWBEl4strpAOR9CN6CoVpQTgrfMzfDaT+vd8CGYsbMM9MQRM2xSTSnhEkIwaDkBzmaFuaeURFmMK5afLXJcb8WSRVYgQZlg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ixro4LAtVI4mPqxdr09iV3FNukiLsVmxf+1HBr/u6/o=;
 b=Fk7dBc/xnn5GJSrX0qnIl8s8E4IZ6tCjY007+57/AYLAs9zvFJsNKlqxqEJOCJ5KRR5lm2xoEY1QBuSwsKRrrBXK8tW8SLC81OF5EZcHurBWA0aa3DuYAsWhERpegkjPJ473ISm3Z0csJdNTdM6y04mUFKSvkBuMrQejcJtOo9jagecqC+NZFFUsPDiRBMdvLV8zWiBnnnRX1a9KAuJzPWAOm2AX7DziJvcQwIyjDKorDp2rxGRq9oco8uM2obmI0HKesIif7QvXpVlakq4djrTzIgyYGI4MC2gZ9IV43YP60uPnDbTjW2piFPhx4G1bB+QyEKXoq/ktdrMvYCcf5g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ixro4LAtVI4mPqxdr09iV3FNukiLsVmxf+1HBr/u6/o=;
 b=NjO7OLf/dsBpdwrQg5GjAOv2Asjg6iX5Tndyv4RrfV1ETx81lgMDmmGIyERzl0V7hVhiEK/OeCTCffHa+kGewr6JlYVQe8Y8RC1v1C1Y7MQ3yO3K7M+7tlqDRdWCV+8BTVq0lkZUMq/Tm9ynTtwZxGNSJLgMWaSzVGys6Jtc6MU=
Date: Mon, 13 Dec 2021 11:33:21 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Paul
 Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, George
 Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien
 Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Message-ID: <YbchcYGImB92onhR@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
 <YbNtBPv1M1lIyEOd@Air-de-Roger>
 <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
 <YbcWVRFFXerNqBPy@Air-de-Roger>
 <b766e6a4-3a28-7cd1-b35d-7bd36e80a552@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b766e6a4-3a28-7cd1-b35d-7bd36e80a552@suse.com>
X-ClientProxiedBy: MR1P264CA0065.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c8bdddd9-bd39-41f1-4826-08d9be23ffb0
X-MS-TrafficTypeDiagnostic: DM6PR03MB5179:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB5179B8C3F762A3AC3A6040538F749@DM6PR03MB5179.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YUMLGyDxYF2rQoQWgXIP/CGHO2XQ0SaTHAhhAnfLLlCC9BrCfogqK6pWRrYRAzhzbVpRZxWrAr3wUT/BslqAU0jhFELHCu89N5hrnkvS2Hl6g9r28AINNSjU6+9YW3RMh047A9McSrCwhEePuF7VO87T4c7aHwDizrK23E5I59x5MpZSBsGBlcfImH2ef77a993uFreZ7ReSDU7hSQqz649qXQm8bOzgflEbGvRd2NIv5dmOp8OaZxXOdDGuyQjDqEpt/FsSQ6W8zD9rvz0VxqMFbqMuxyc8z7shXzX6v8yM64QkjXfr/UOE/28gVH3YVHEfHo44c9nes+JMx1U1zplodi88MyzuzPHESRQZd4PEyA24pikH78vbX9IFo2Fx6uAQYpRuMhpR86o8CeFs9jTuAmn6ks1P8Uko/U7KN+kQZExugCY5VqapSBEue1RJrVWnJKtI/F5tGnSd8vn+JpYDQszAuFGw9M2OFHjg2kuQpc7x1btZWMf2NIsAotajBEXhhqVYrx2fgwnivtWR3V2xHRM1lfi3ktAQMeYqiOYrwrIWCSU2pRhI+qUyuHQWnLSJCilLR8d6uYgzlKIyLy4n/3zWrd7d1x8pUaTk0JBEaQuSClcBhOa9h+fZzX79jPx8H0cWeuXWDTapxqHsxA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66476007)(66556008)(2906002)(53546011)(82960400001)(6506007)(8676002)(6916009)(8936002)(6666004)(66946007)(5660300002)(33716001)(86362001)(26005)(6486002)(38100700002)(186003)(85182001)(9686003)(4326008)(54906003)(83380400001)(508600001)(316002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFU1OUlJZyt1OUJRaENYcSt3OXJqKyswbGdhQmdWOG1kN0tZbm9YbkwyUlY2?=
 =?utf-8?B?RnhBVkRQWlFKNkkxWjk2dmJxTVdlVDFpNEZqcndwbXkvNmxoSUZXUWlrZHQw?=
 =?utf-8?B?VG8rblFOb3E3bElyQ21VaE03WFNWaDR3blJZUk5JNTg5ODhaTG51eCtaNGhQ?=
 =?utf-8?B?K2UrYlBIaTBNaVkvc2psUU4rNzNvc0tTVGYrbk1IeWxEK3o1WWFMSU1CdUFy?=
 =?utf-8?B?UjA2RVAxVGVUQUUvTWxPZUlZMFRKQVRUSHJFamprK3N4cDZISmlQQ0tiZURG?=
 =?utf-8?B?enhUMHBNV1diUVcxeVgyL25lcmpMTzdwZURKWDlPc3J1dWlZTDlyOWV5SWJC?=
 =?utf-8?B?YlB3LzdtWnVTaTlHUFUxbTNNTEpoMXBjRzRKTFQwNlZuZXNYU0FTbzYxbEJw?=
 =?utf-8?B?VE90QlFIZHNSb3UwK0N0UU1aNXJYWjFZbUdGRHlPQmlYYkJVdVdLay9WeDB2?=
 =?utf-8?B?N0pLa3pLN3p6N0lwU2lTSngyVEI0QWxyYlUrZGxNWWNpempkNjdoZ1BsWXJL?=
 =?utf-8?B?SG93Wm1EWEh1ZVNuaVpSQ2VCSkgxT3dzMkNEQWwrTHJTSDlYbjRSSjlONXBi?=
 =?utf-8?B?VGJxR2dSYndqSUxISVg5akgzWjEzWnBZTmhtS2poRXJhY0ROSmc3d2w0Z0pX?=
 =?utf-8?B?YjdTMWlvQ0lZa3V3R1ZuQXg2dWRLam5Ta0cwN0xhU2FaM2lJREtyWmtBN0RQ?=
 =?utf-8?B?QUgvNXk2RzEwQndLV0pnQkhtMWxrZ2dHd3ZBbFZ6Qjd6a2pWQWtUTm1zZng0?=
 =?utf-8?B?OHZVaG94MkdISXNZNndsY1dsL3B5U3hZMmQzMlF2by9Fcjg3ZWtWZUwvZkxW?=
 =?utf-8?B?UXNSZUVqSUdJRjRGVlpqeVIzWERrZGt1eElXM0t3WThhOFgxWGEyTU9ZVjFJ?=
 =?utf-8?B?TEV4M2Nwb2pvTjV1bHJOQUlMbFZ4aHRPeFUweGQ1NHhYSUxQQlBIUXF6WVE5?=
 =?utf-8?B?VnBLZHhXV2JUYzNjZ2xtQkxRMTcwTUVzWUY0TlhYUFQ0S3dqeGtiTHJvMUY5?=
 =?utf-8?B?WG5INGhqRnV2bTkwSmo3WElManZMSEtoVDI0ODNaWEJzOHVxdE5VZ1dmWTBq?=
 =?utf-8?B?UUhYcUEvTnhlbHJ2RG04ZCtQeDV1TkVhQ24rWkxwTjE4K1Z5enl1MXRJT2F3?=
 =?utf-8?B?VVdsa1FDRDk0cGZQY2tTZ3FMRDdmZ1BxR1ArMmhsNDdSK0ZqZi9CMUVJOHJF?=
 =?utf-8?B?d00ydXVDMEVEYWRoS0RHbzVlY25NS1FBY1ZkbjJVYzdaK3E3REx3eVBsT1ZK?=
 =?utf-8?B?ZlU4T3g4ZC9LZmcvVHRhS0JZbkxqL3Z0V2FxNFRCbXhEV0pYUzJHYjdVYVZp?=
 =?utf-8?B?TVl1czkyb0FuMVQ4b3hUcmE4MHRVSmVOZE14RHczekRSNUQ1dVhSU1JBRlYr?=
 =?utf-8?B?U2J1ZDFNUmpTbmJENkRiV2cvRlZTamlwS0tEeGI5c1ZUWEs2YlRSNU13Wi81?=
 =?utf-8?B?NlZ0Rloyc2VBL2k2cWZzWlE5M0U3NGhZY0Q5Y1BwV09PYnA2ODVtNTcwN0NN?=
 =?utf-8?B?eDM2UFRrQndTa0haMDNEcU4zV1NLdkp4cU05MkZTVkRwQ1BKcWM1bVVWT3FC?=
 =?utf-8?B?Q1lpWHJ4cVZEdWRMV3VMWWdyL1RCSXFqa2xiNXV1cEJpNjVYSGVNNDkvRFlX?=
 =?utf-8?B?ZWpVWGU3SEEvT2V2Q0w2eXg1NzdFdGU3blZITVI3Umltbmx3MDI4K0JVOTdp?=
 =?utf-8?B?MXNBUndlVzMwcjliWnAvNXFhclorNUFGTnlHZWhHalhhR0h0Y3E3UXhqYzlT?=
 =?utf-8?B?UGFuR2tHdTFSNE96WDNjR0ZhZUlxbGZvcVZRVlNybU4rQ0NHVkRmS1BDa3dH?=
 =?utf-8?B?dkFuWDhSOU5FdVYzbHEvVWNqTVp0N29LTlNFUlZNYWhpakF6N1g4MUphZGQ3?=
 =?utf-8?B?MVNKQmUwZmVZdnMxWk5ORHRpWkdoaUQ5SHNIcm5GY29MOThHdXRNYllqeS9Q?=
 =?utf-8?B?R0NpaE9XbkpmUmR6U3ZGNU0rMUphMW5zeDRsV3VGQUJtOVZDWXdab2V1TENE?=
 =?utf-8?B?SS9MRGc2eHZVYk9QZVlBdzNmdC9Ec1lkWnpuTG5MTEhBY04razZqSkVTR2Ft?=
 =?utf-8?B?YWw4b1VqQlZLU0trT3gxZDZ1M0FNZXBPalg5QXR1NjJDak84YytvRWFuU2ha?=
 =?utf-8?B?eDVnMHBzQjNaeUU5WG1BNkFWMUV3dVhrK3NHZmtKREIwYzZKQVhscTRYdGsy?=
 =?utf-8?Q?7lqYzVKky/axUvO2UJN4Z00=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8bdddd9-bd39-41f1-4826-08d9be23ffb0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 10:33:27.4204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QggbU5GjV3UYAFHQ+gRyLP87AYQR/lxS/0qGUQo6YLEPaL9UM+sUOFyhwnO94ys0Nsv8iwWZFd8ymPezSm1+Bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5179
X-OriginatorOrg: citrix.com

On Mon, Dec 13, 2021 at 11:00:23AM +0100, Jan Beulich wrote:
> On 13.12.2021 10:45, Roger Pau Monné wrote:
> > On Mon, Dec 13, 2021 at 09:49:50AM +0100, Jan Beulich wrote:
> >> On 10.12.2021 16:06, Roger Pau Monné wrote:
> >>> On Fri, Sep 24, 2021 at 11:52:14AM +0200, Jan Beulich wrote:
> >>>> ---
> >>>> I'm not fully sure about allowing 512G mappings: The scheduling-for-
> >>>> freeing of intermediate page tables can take quite a while when
> >>>> replacing a tree of 4k mappings by a single 512G one. Plus (or otoh)
> >>>> there's no present code path via which 512G chunks of memory could be
> >>>> allocated (and hence mapped) anyway.
> >>>
> >>> I would limit to 1G, which is what we support for CPU page tables
> >>> also.
> >>
> >> I'm not sure I buy comparing with CPU side support when not sharing
> >> page tables. Not the least with PV in mind.
> > 
> > Hm, my thinking was that similar reasons that don't allow us to do
> > 512G mappings for the CPU side would also apply to IOMMU. Regardless
> > of that, given the current way in which replaced page table entries
> > are freed, I'm not sure it's fine to allow 512G mappings as the
> > freeing of the possible huge amount of 4K entries could allow guests
> > to hog a CPU for a long time.
> 
> This huge amount can occur only when replacing a hierarchy with
> sufficiently many 4k leaves by a single 512G page. Yet there's no
> way - afaics - that such an operation can be initiated right now.
> That's, as said in the remark, because there's no way to allocate
> a 512G chunk of memory in one go. When re-coalescing, the worst
> that can happen is one L1 table worth of 4k mappings, one L2
> table worth of 2M mappings, and one L3 table worth of 1G mappings.
> All other mappings already need to have been superpage ones at the
> time of the checking. Hence the total upper bound (for the
> enclosing map / unmap) is again primarily determined by there not
> being any way to establish 512G mappings.
> 
> Actually, thinking about it, there's one path where 512G mappings
> could be established, but that's Dom0-reachable only
> (XEN_DOMCTL_memory_mapping) and would assume gigantic BARs in a
> PCI device. Even if such a device existed, I think we're fine to
> assume that Dom0 won't establish such mappings to replace
> existing ones, but only ever put them in place when nothing was
> mapped in that range yet.
> 
> > It would be better if we could somehow account this in a per-vCPU way,
> > kind of similar to what we do with vPCI BAR mappings.
> 
> But recording them per-vCPU wouldn't make any difference to the
> number of pages that could accumulate in a single run. Maybe I'm
> missing something in what you're thinking about here ...

If Xen somehow did the free in guest vCPU context before resuming
guest execution then you could yield when events are pending and thus
allow other guests to run without hogging the pCPU, and the freeing
would be accounted to vCPU sched slice time.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:35:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:35:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245955.424259 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwigM-0005yL-OM; Mon, 13 Dec 2021 10:35:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245955.424259; Mon, 13 Dec 2021 10:35:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwigM-0005yE-LK; Mon, 13 Dec 2021 10:35:46 +0000
Received: by outflank-mailman (input) for mailman id 245955;
 Mon, 13 Dec 2021 10:35:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwigM-0005y4-1R
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:35:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6d5e8504-5c00-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 11:35:45 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-2o7A6IykP1avATSWLUn8Zw-1; Mon, 13 Dec 2021 11:35:43 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5168.eurprd04.prod.outlook.com (2603:10a6:803:56::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Mon, 13 Dec
 2021 10:35:40 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 10:35:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d5e8504-5c00-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639391744;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=wAEZKMErl5Xu/naz0thxmf6iF/fwuIb9Z/n/UQ4NtQI=;
	b=M1BFl8ERH0ezz76CFUpzveoGB6yReFdDCQNtKQtXSDrLph/qqsLPJ4OjVpMWxNAA92YqAg
	NL2za6TfI4k4wOp4FXRSTaVpueyleOuNu2mXOjg/zb7tgtr4NdZjdunj16aF0z9tOwn8od
	2Hmq/K/OZtdpMkXkxdiYT+VCJx1s7pc=
X-MC-Unique: 2o7A6IykP1avATSWLUn8Zw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QHKERlJBx4aqmXyXCkZ01ZKlq6wQIZJvPWujJ6TD+Hjios0awwOEbElDqpeGw3jgl2LNCW2y3urNq9nUcjOMoA5HQA4MIjVPU+CfZkiVqXxA7gUctMpeWyjWodRZepeM1g8BTI137om3FmYVZinGMvlmJlr/COHT2BN8kXEHNSJ1WBuE/Y2jY1JI17cJS8ugjzMVebopUF9IwOBf/9rYu9PNs3/Wa9vsMRG7fMNJJ0+sno9IPlVd6NSyhDZOgxKv9o19gG2FDs7nhGTv+EGtBJEpyM42K76xZAkf9QnS9WbLk/RxFV2IiaTXU4Op9VyT5E4bqdfxn66GPd3yWH013Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wAEZKMErl5Xu/naz0thxmf6iF/fwuIb9Z/n/UQ4NtQI=;
 b=bs+0Mdxe0ozzEIEO8wmnxtkeJ/GghqaArVxXOqdcJ0je+8xhpG4WlXqdcvcBc8mLmvTucFpIrvsYh+0RgLkVDNZY6JHtCNVX2b695OoFbhexyK1dnM3oq4nwxHs0JVtJBIu9X07fDceiKK6GYSTrZmhtm9GOyyo0yc1nkV1MZAO1u1wyVAoLMPF5zJ+KHZklxqxS0puJDtKT/qhbiISPwN1IPNwoz5VXdcmb34wBNyZ2L9lH7ANg59Vu5AUl2ntpdq/m+Sxnx3ECVzySBQ7JndVsx2Vr1dx+mkpQlFggfAToU9ZW4iqlTSV9zmpNl6n6G6nJK2PaB3W/Pv0UoayBIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c3f1e075-e142-7fc4-e050-89cf3665901c@suse.com>
Date: Mon, 13 Dec 2021 11:35:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
 <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
 <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0045.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3b4b7498-7b84-46c8-0901-08d9be244ebc
X-MS-TrafficTypeDiagnostic: VI1PR04MB5168:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51686B7A1A04A35F98148CB6B3749@VI1PR04MB5168.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	c7pwVWlDa/9DARB4gpgALUT7HboaY1iiXb1hvStaf9ax67Bjhso+bMTPfteeAB1L0nEqb1Jkph5MKRBPrQ0oMhs1PchQzdVgQcinKl/VEeo57R0zbd5qfqZY7ZhTC5JcuKEM/+yAkJLcbsjVyokcFFAvXIWpE/6ZTc/N2MqXGxn2coy+isZ7sNRFUyps8pNQPa1TC4nFlE0li8YrWo3TicepI2W7dCuksWS+zdPKjEZVvA6H9KISE1IT3UbLQ0Xh/aGk5TIry8/t+r8EL7e/EQeblV+8Ypv+AZF5yjBQIC/1ZVtehGqrl1ctW0KTXwzddcTDJWgSvyQFm91QY/W7KPxN5KtlZdURDwoTKPU/gXmzs4uOegrwVRnOax7lZDJfxPdI6OT8sVMREVniGrVP6sFDvBjY7dSleCt79W3NLGcpEYwKWhr2emArQ0UV74doBkLGhGmsLgs69SpKUfrD8hbxwq6aVBExQNvmLgHwAoCXoGeRlvMOfRa9wjzWbXY7unmq/MwqMXfhOv76lrfFwv4ddPFY7mDlqzp3QQcuNJjKwL+cFrqeR8clfwvMABF/y5LzEHYdfPDqvBEUzuI7lrM83Fbg/26lwQNu7f3lEGCBS0AFdd34WSdFAvry97AZHgrlHK6peMOXbRerBVeYBYAFb6vfJROfDCG5Ac3XzckHRIeLIg41ZfWS0850k0WG/iiAot1AbZOnO8wwxgWW5Ac3jMpfzj5ymt4A3Mc7i2pxczx/L1zhVSavb3abaarE
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(83380400001)(36756003)(66556008)(4326008)(2906002)(186003)(66476007)(86362001)(7416002)(6506007)(53546011)(6666004)(8676002)(316002)(31696002)(6862004)(6512007)(54906003)(37006003)(38100700002)(508600001)(6486002)(31686004)(5660300002)(66946007)(8936002)(26005)(6636002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEJrOEtQdkVYc2pkNFNoYStIMlcySHA0cExVa2M1bEtWMEZnS3BCNWJwTXBI?=
 =?utf-8?B?S0RsZENxdE5RUDlWRGk1V2gzYUpQUDdaOHZoT1JQUkRIUFBqQWNTYkZ4OFIv?=
 =?utf-8?B?SlJpdHBlVXQ2ZUdTdStiU1E0OHZzZExBZGwyRlI4bU9FYVdjbmlmT04rVlZm?=
 =?utf-8?B?TUlETTAyMFAvUGJaNDNQN2JrM2FzUHRWU1BtOU1NZHp4VXVOaWdLVEZBM3ZR?=
 =?utf-8?B?OUI3eitjZmJGVVNBbzhkSGVrWnZPcjN2MEZEbFRDUks1TEt4R1FEaVRnczBo?=
 =?utf-8?B?OGI3UHg4L05VOXN1ZkRhaXhwMFVwejlveGp0VkpFZ0ZxTkdaSFVKYjdDZXl2?=
 =?utf-8?B?WVJoWjB5WkswUC9TZCtBa1NUVGVTN2FuTmRpaWszTEpXZ01ScWtIYWNGNGVL?=
 =?utf-8?B?amQ5VFV0ckZDYmcyeVRJUG5JNE93QnZUQzB1Y3J3Rlo5UDgwckROcDE2N2dk?=
 =?utf-8?B?QjlaNE56dFFtTG04SGZkUXJxNXExU0c4TjA4Y2tQYnBtbUdteHlndDl1RjEw?=
 =?utf-8?B?dHFQUGRsOWRscUdTaGdMaVNDbHRlRzMzbWJEOVhIbEFlc20wbUd1RnhITXlp?=
 =?utf-8?B?RVcvRU1KWVA1OHJodHpkVXJjc0IvL2IyYjc1Qm13ZHZzUVl2ZEttNVhWbnMz?=
 =?utf-8?B?UVYrMFpFZ21sZ05hOS8rNm9XZW5KZDBxZWk1UUMvdzVjakhnMnpBUkNDbmlO?=
 =?utf-8?B?d3dFWkVIMGl1bzVCcFZiZWFHS3Z2QmhUeGtxK0VvMFpIb1ZobFJ3TUJPTkI5?=
 =?utf-8?B?R0kxUnJQUEUzWWx0aTl5MlF4VCt4RUlhYi9SODNXME54dDVpelQva2h5cmRj?=
 =?utf-8?B?WE42VE9vaC9vZTVMdi9YTUJ2NnZ6VXpHZ2xSTXdVZk1NQXRtWjZEWkMwS1lx?=
 =?utf-8?B?SWtDb2tVaXV1b0w3LzZvU01DQ005TGVUSlJlSlJHOUNuZmxWdEs2SVNZMkxJ?=
 =?utf-8?B?R0VEN1Q4VDk0aGgwRndNSUY5eVUwVkJiSHhqTUJYYmpYUm41VGZTZ0kwakdG?=
 =?utf-8?B?QmdGd1FnMlN2ZHVvT0tGeTFXNHFiRXBsRVpiSE5RVm5JVVR6NWlyQXNxN3Ju?=
 =?utf-8?B?RDNPb3Q2eEIyYjFObFBOQjVHeitnWHNDUVl2WE05dFBoUmR1d1BCQXJrcmJi?=
 =?utf-8?B?ejV6dG9COFAvcit1dmJpMWhJTXpXcFB4KytBQ1ppTVRLS3Z0bzlxNmE2VzZw?=
 =?utf-8?B?Y0R0QlpUb3ZudEUvdlRaZHQ4L2FwWkZWaTZrV2x4cHVQVG1uZTRFSHVOcGp5?=
 =?utf-8?B?SUhSWW9iKzZUaDVJdE1uYm9qWGhxWFVROHlrTjVqallpM3dFdjBJa0RXYmF1?=
 =?utf-8?B?ZDVsZ1JGK1hUbzg4WXUzUG5WRU9McHNDbE1NZ05JdHN0QndrRTc5SmFHWm9y?=
 =?utf-8?B?QzI2cXpvbEJ4RFZ2ci81SGJwUzQ4U1J6UklId2NTazJkVXgxWUJwNTZ6TG1O?=
 =?utf-8?B?eklGc2VrQk55VmRFTUdidGp4dEdlVDc2anJsUDM2Z3kwalZaK0RrbURnam1H?=
 =?utf-8?B?Sm5qMm9iREM1MlU3SEZhZ3ExMWx1eHVHQXJZbkpOcFRBQjlpazI0NUNIaC81?=
 =?utf-8?B?aGNHMEFiSjZGTGp2eUkrN1gxN3EyYlVvek1XVnJ0cTRLcnp6VE0zZnR6TDVE?=
 =?utf-8?B?eGRrVmVDUjFOVmt0aDFCdm9zVDNUSmhsL1hEeVVseXR6RHRCa1I4SUFHN0Mw?=
 =?utf-8?B?bzN0VmRWamhhUkRWTDd2T2haVHQ3UEdLS29oYVhLSnhWY3hwckFabS9WOG1M?=
 =?utf-8?B?bkV0TXdQK2JwMHlXMG5wbjVxam5GeVBFbDl0cHQ0cjJ0L1ZncklENlY0YUph?=
 =?utf-8?B?MUhsRW5sV0hackY0YmxwUG1IeFhCQWRHY2JEVHNEOFljWC9seTN6S0dpNDJQ?=
 =?utf-8?B?cDR2RVBtNzEvT0RZVE5VbWlkYlNKTHl5QkFVQWMxdEt4SXozZkV5Vzk0S3BO?=
 =?utf-8?B?ay9Db0ZRMjB6V1RTQ0lMRDRiOFN6UC8wNzVwWXNBSWFJZ1NqRnlOUDVkL0tn?=
 =?utf-8?B?ZXpZdzJiRDh4WWN0RmhtYUlOdis2T2trTExUNVNFaFNBbUlSZ2ZyUUY0MkZT?=
 =?utf-8?B?cldJZUpOUkROcGVjMEM3dkdTTnpkMlBrL2hKTlVKek8yUFl0UXk5YmFsRDNa?=
 =?utf-8?B?V2QyVHNyOU9SRWlEb2hvZk85a2hla0htRVNGUlR2VllKcnFXdStwR0wwWWZr?=
 =?utf-8?Q?2g9U1nfXU9yvKDQ2D22LS+s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4b7498-7b84-46c8-0901-08d9be244ebc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 10:35:40.2349
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w6wx0L1hP1ZiwQN9x/7OJlFsWS5tbFi/pi9zDrbsHZJkJlww0I2gcst+ehi1wzMxmY1k/S5rI+zuaZ/d7m0Z3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5168

On 09.12.2021 10:10, Juergen Gross wrote:
> On 09.12.21 10:05, Jan Beulich wrote:
>> On 08.12.2021 16:55, Juergen Gross wrote:
>>> In order to avoid indirect function calls on the hypercall path as
>>> much as possible this series is removing the hypercall function tables
>>> and is replacing the hypercall handler calls via the function array
>>> by automatically generated call macros.
>>>
>>> Another by-product of generating the call macros is the automatic
>>> generating of the hypercall handler prototypes from the same data base
>>> which is used to generate the macros.
>>>
>>> This has the additional advantage of using type safe calls of the
>>> handlers and to ensure related handler (e.g. PV and HVM ones) share
>>> the same prototypes.
>>>
>>> A very brief performance test (parallel build of the Xen hypervisor
>>> in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
>>> the performance with the patches applied. The test was performed using
>>> a PV and a PVH guest.
>>>
>>> Changes in V2:
>>> - new patches 6, 14, 15
>>> - patch 7: support hypercall priorities for faster code
>>> - comments addressed
>>>
>>> Changes in V3:
>>> - patches 1 and 4 removed as already applied
>>> - comments addressed
>>>
>>> Juergen Gross (13):
>>>    xen: move do_vcpu_op() to arch specific code
>>>    xen: harmonize return types of hypercall handlers
>>>    xen: don't include asm/hypercall.h from C sources
>>>    xen: include compat/platform.h from hypercall.h
>>>    xen: generate hypercall interface related code
>>>    xen: use generated prototypes for hypercall handlers
>>>    x86/pv-shim: don't modify hypercall table
>>>    xen/x86: don't use hypercall table for calling compat hypercalls
>>>    xen/x86: call hypercall handlers via generated macro
>>>    xen/arm: call hypercall handlers via generated macro
>>>    xen/x86: add hypercall performance counters for hvm, correct pv
>>>    xen: drop calls_to_multicall performance counter
>>>    tools/xenperf: update hypercall names
>>
>> It's not easy to tell which, if any, of the later patches are fully
>> independent of earlier ones and could go in ahead of those awaiting
>> further acks. Do you have any suggestion there, or should we wait
>> until things can be applied in order?
> 
> I think all but the last patch should be applied in order. The last one
> obviously can be applied at any time.

Hmm, I think 11 and 12 are fine to go ahead as well; I actually need them
for some immediate purpose and hence I did pull them (but nothing else)
into my local tree, without observing issues.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:42:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:42:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245963.424270 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwimI-0007Zm-FM; Mon, 13 Dec 2021 10:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245963.424270; Mon, 13 Dec 2021 10:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwimI-0007Zf-Bh; Mon, 13 Dec 2021 10:41:54 +0000
Received: by outflank-mailman (input) for mailman id 245963;
 Mon, 13 Dec 2021 10:41:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwimH-0007ZZ-H5
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:41:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4894349e-5c01-11ec-bf02-3911bdbc85ab;
 Mon, 13 Dec 2021 11:41:52 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2055.outbound.protection.outlook.com [104.47.1.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-10-dPnismtnNsGmIHMk2X4_rw-1; Mon, 13 Dec 2021 11:41:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 10:41:49 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 10:41:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4894349e-5c01-11ec-bf02-3911bdbc85ab
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639392112;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Gt5Wrpj3bli62eYMBaRyArp6W3jJQ+cMRWxxz5xG4yw=;
	b=n7Y6Groy+nbsdxGkpQ9ArX8j69hiQFLqMbFXSeyprxaCCxbW1GrVHsQe95xXsB0ECxbHAc
	g3IilYR1ggX4eOQXP+/2rpJ651d0f9gM8nPDvkWiaNyOp4sSW3LLMAzSt6020/jMRTOMM0
	SZO2YFUEnuhIABmZ7qqRKNTn2Tbj9Ko=
X-MC-Unique: dPnismtnNsGmIHMk2X4_rw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bDDSrGf1URAFwQ78YiXfp5x8KjedaeXkO894LtP+yk65OZB9X/fdu+h06wtpqGs3RHSXdykJLhOnURLLz7wPLsrHkx6YVWbHyqM8otMosHvLzJN/ZLnlFFiaXeoABbGUyNM8irQ4e9RvNeO7PdOZv2A/HKWs0sI5pHtO2sEBoaxYq1X07S7PSI34UC4r+tB8GLvfk8mHLA27wcm3nRYF7In9W6eum9/ES3xmKiYe6F/JAlTzGCwZ5Fv6eDFsJKI+Ak8c7wW0lf9SfEiCGNaTbKou6seYG75VaBLHZx2FIDu8oAx7d8lictImqDxRys3bP8I/FmG9O8+RWb3jd+cN6w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=J7mJMBykJWmCUntx3UtDwnrciJYkBrAn68YyoT7SlSo=;
 b=EnA+dvV0NT25V6bXo8dGN9t9jl199fX7fd2h76CPpht6TZd4t9pSP941P7ySeaZtskc9GfyO82ZxYAVLje4P08j+qzbn45XilTyDzQoXStWS2Sr7Meo3RV6ADbkhrVxz6xnBjvy+2LZ8fPvoJmnUYb56Npmebj18WvyYzOldfvwjr8m3G0xmmHKZYMJOr7srkaj6PAi2tE51YLvXCWxcNokCiFEOLJwce/ZAD/0Fg/S+HsnAkUUQb6ONv0LA6NaFZiCI56C5YcvtSdIfHIATLhSbOfPG7PWrV5FkO7RGNGZhxPr9dM5SSaljlrjQUTYG29+8sgWO6y+dJYVxT+UHXw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <21694610-178d-42c3-e5db-ee59ad011103@suse.com>
Date: Mon, 13 Dec 2021 11:41:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 12/18] AMD/IOMMU: allow use of superpage mappings
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <cc93398d-982a-edbc-4ddd-b5459cef8f9a@suse.com>
 <YbNtBPv1M1lIyEOd@Air-de-Roger>
 <d472fbb5-95f3-dc6b-8103-e7d76e71290a@suse.com>
 <YbcWVRFFXerNqBPy@Air-de-Roger>
 <b766e6a4-3a28-7cd1-b35d-7bd36e80a552@suse.com>
 <YbchcYGImB92onhR@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbchcYGImB92onhR@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR0202CA0051.eurprd02.prod.outlook.com
 (2603:10a6:20b:3a::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2be56d90-d300-4700-dbd3-08d9be252aaa
X-MS-TrafficTypeDiagnostic: VI1PR04MB6864:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB68646A3421EA6FC900A59F0EB3749@VI1PR04MB6864.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	AW6kcQsoY7ZHNvucdX+vYAL9T45ocKRYyFlZCYT0JAlZsfDJM/Y6O7DLhrvwBOMWExU1o2edTpNNPQzMWkJTehsEm6TtD9t8JA+vPyfna/u9WZ+ZLiS9J+WnRBuyzkxcABC0dM9B83ZcX4Kg1f77i5qfDlneoJIFwNOFELEaZmFrJRW7hBicHqgzOEbqXF9HRDTTrQgNskqcmalrOhQ/hyPWQHk3Yaj0nNyDiQ8B0gxsFok1lCB4xunhGOsy1E9XxtVaoDHCdoVfCtujpWREMmWb7zkRzD+oEb5by5QYguqv3qNNao8GWs9xaJDurX1tkuzjMbF9yRZ2MADVUZK2bZznvp0uXsut54YNtPoJX8xt/XU72ePm1yQJtDU9aR2EzYrOpLSBSQrdRunefX/kXfTVII82wjCwkoWEd3W/O8NwnT9ar9KY/BBgfYH9+ATEFXEVpGLMyNicedfkgrB9yZXhoYjjpC54AnobAIsIqBxKSOSYfzkHEGvdUM5fvxWwLKG/qnJ1T8BSMV4E0kUXhYqYl5joLH3cKNbOer4RK84IUuKTsfPRwKVadRPo9VN/A6AEVd/k3KkTI+1c+gTpYfj4y7Yn3TmOyIPblY+h+Tt8gAle8Zhe81sSVJE4cQffpFrIOINipczLuYG8IwBU1kM4pOQB7TGreSOnOTa/0OQIl+FJ1CI/a6DScH/sRpQpJnG3hZPVYhAMtpl1EskPfvwxTjqviKb+OPSPSPjF8XI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(31696002)(66476007)(66556008)(66946007)(2616005)(6666004)(53546011)(26005)(6506007)(8936002)(31686004)(5660300002)(186003)(6486002)(36756003)(6916009)(38100700002)(6512007)(83380400001)(54906003)(86362001)(316002)(508600001)(4744005)(2906002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?t1nDpQXSDlDLCp8sajN3nwA4/d/s+joqnVZEbw6ra3TfyLr4zlsgO9wjLP3L?=
 =?us-ascii?Q?DlfhwsOg/+PSK4l1u1ltASapDX1BHDyZvI1RPMZoZ0GV2nw72XYdeL0dYzAY?=
 =?us-ascii?Q?jNgwQOTJKH0MU/QKYrD0t2aP2i4grjkNlKJDpVSQOPcdW3VVKf4OuTCu1Ruy?=
 =?us-ascii?Q?E5oVijjpZhFZUn3wlLrOh15By3cg5NaesyxZPkxaPU0cr0rum1qWwL+F5BM0?=
 =?us-ascii?Q?/oDTY1djtKbVE9PngAqYxs1CV+qCXMrNEtaWgSfzJq2vexfjUamiGaDl5Rbo?=
 =?us-ascii?Q?RXbw4DqLyV7sSLEUHwAhFvnEL4uwv5AkEY0tueK1tD8QrmsQhNeGneSyRNMA?=
 =?us-ascii?Q?bsXjfoo6SmT21uDCf9Z7pumQFlyhkd6Ymao5x7herwGRQ69uhV4L3LQMB95Q?=
 =?us-ascii?Q?LxaV8T2skzIij9EJqd0UxtPDZ2N92nw2HPSBPgoWqIN+8X8lN4ZmjqsJqnR1?=
 =?us-ascii?Q?XEU3JGe3rkyVcQ7Sdz67Ej4bpVJS9oefrImaXQvHriuMfJpfW3KaYkmq+9dC?=
 =?us-ascii?Q?jNaj2oF86r2eQthbcqBRuZCkQDIDaC8cj4N4P2pv/lny7h4YVp5YcH6pDErx?=
 =?us-ascii?Q?MzeLB95wE3W6C2mzi0Q5+vUbAYBUkYllKjQEfBPYeFV6rIum0q9vODQTV9L5?=
 =?us-ascii?Q?3TJcDMuRuin+LpFpmNljmSMsBgk0CKHC9vXb2eQo+dm54W7coMfA+RXIGOAb?=
 =?us-ascii?Q?Cef0a5amKfeuf8d0t0m2ENMsZU1EKU+Jzyutm/0JhYas8CZJRuFbnUQUkziT?=
 =?us-ascii?Q?C7rvH0j896PHzR+oF1yoV1sYWqkm1mvHbHn1Fbw/dPqrU3TD24bCQUSOzBBw?=
 =?us-ascii?Q?lbOkkpLX+y+q7Q9kbS259NRNO0+yxPo86MEfTLM+XBZWICJ7Bzuj+oSQj6YD?=
 =?us-ascii?Q?b3OAoK8lQ41i5VuhnlwYwWR77c6HuTOiIxekh+J5K+Atn9yviB8HyNQ7I9fF?=
 =?us-ascii?Q?tMba0sjD+nZATVoph+Ly4bB0RxHWpfPab5NsxIRcnSHbiIi+Ec77gY7ctU9S?=
 =?us-ascii?Q?OLGlalVoOlzkYJkc/W5SBPbf9KdXmqiECvv+c10oDUuYBFavdSSbCVx6lj4B?=
 =?us-ascii?Q?7NIWMxqlE0mLLQFtRBXXFbyGxp3rfdIbxj/bcSHOj5mvUQsfr4Yz9XbiaV75?=
 =?us-ascii?Q?KZHOrVvbNu34MEslMYB+/VsqSfxdIwq4GQc99aALpS9iOmX8OUaObD+vlmhj?=
 =?us-ascii?Q?j76LLCMYHrH0VdWawTyEosW1V6PEGFRBU0evJKm7rtBYdMEnX+o8kxnJAanm?=
 =?us-ascii?Q?+sIE5htFuXUwsUx25KbNgYflCChVQmczkXGjgeVZk9x7pjfg02SewIEn+tzi?=
 =?us-ascii?Q?zgh29eux/zKNyi6s8AL/XxhC/rhcVFCWuEWJni9DmeKcc1cQ4UIYf9CjSHB9?=
 =?us-ascii?Q?ahNeoexw0cfHe/cDzqzLLL08b9O98igblHdXNwVzxHFr/PC8x0PKfJbBxx4o?=
 =?us-ascii?Q?BEOTFgxG6fN+O6nCWc68x+bYSBEkCuulD3/4k8/0LBlaDsjPANlyX+SAun8s?=
 =?us-ascii?Q?/EAealZxRiEcof6++h7qYOJgcqdTVyGhhKe0hj1Df5KGP1QxflCf9xzslpQN?=
 =?us-ascii?Q?GUVnUsyWP364u9PdAqY57UQWNn3qQ8CRaiFDh60Akv/mpG4oNn1/6JB/4DGK?=
 =?us-ascii?Q?tMAWhba9eylcdxUybWjkxZE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2be56d90-d300-4700-dbd3-08d9be252aaa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 10:41:49.0552
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w7D8VOgQo3GYak8S1tyrA6ZlkhRaTEF9JWuNGuikVtEqb+TkzT1z7WOUwNe5W5r5AX5hXZfjlosqyhN7Z6VnSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864

On 13.12.2021 11:33, Roger Pau Monn=C3=A9 wrote:
> On Mon, Dec 13, 2021 at 11:00:23AM +0100, Jan Beulich wrote:
>> On 13.12.2021 10:45, Roger Pau Monn=C3=A9 wrote:
>>> It would be better if we could somehow account this in a per-vCPU way,
>>> kind of similar to what we do with vPCI BAR mappings.
>>
>> But recording them per-vCPU wouldn't make any difference to the
>> number of pages that could accumulate in a single run. Maybe I'm
>> missing something in what you're thinking about here ...
>=20
> If Xen somehow did the free in guest vCPU context before resuming
> guest execution then you could yield when events are pending and thus
> allow other guests to run without hogging the pCPU, and the freeing
> would be accounted to vCPU sched slice time.

That's an interesting thought. Shouldn't be difficult to arrange for
HVM (from {svm,vmx}_vmenter_helper()), but I can't immediately see a
clean way of having the same for PV (short of an ad hoc call out of
assembly code somewhere after test_all_events).

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:48:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:48:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245968.424281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwisA-0008Ed-3Q; Mon, 13 Dec 2021 10:47:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245968.424281; Mon, 13 Dec 2021 10:47:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwisA-0008EW-0R; Mon, 13 Dec 2021 10:47:58 +0000
Received: by outflank-mailman (input) for mailman id 245968;
 Mon, 13 Dec 2021 10:47:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwis8-0008EM-Tu; Mon, 13 Dec 2021 10:47:56 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwis8-00022J-PD; Mon, 13 Dec 2021 10:47:56 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwis8-00088E-EJ; Mon, 13 Dec 2021 10:47:56 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwis8-0008BM-Dt; Mon, 13 Dec 2021 10:47:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vu/fSrG4lfhkBfUEH1MXjS4zl3nwV+SFBMZkZxa+o3U=; b=PQBK0FD+ZL2NPfH6EcNw6/eQnj
	7PRf6Dg3lXI9tYV02nCn1f/kKPgYcKbu+iDvdJtEQH7ATscEkng1SozQ4N8Y8qYgwxpZz4Kq+WY4g
	/lH6jfshr2y8MkN3e1vYBPjxIsvn3RvoQPaDfzH9XX9enMZfRw+CcCbuum3y1aeuuKAg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167389-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167389: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2585cf9dfaaddf00b069673f27bb3f8530e2039c
X-Osstest-Versions-That:
    linux=90d9fbc16b691403a80a119d7094528721c03279
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 10:47:56 +0000

flight 167389 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167389/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167386
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167386
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167386
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167386
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167386
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167386
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167386
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167386
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167386
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                2585cf9dfaaddf00b069673f27bb3f8530e2039c
baseline version:
 linux                90d9fbc16b691403a80a119d7094528721c03279

Last test of basis   167386  2021-12-12 19:40:29 Z    0 days
Testing same since   167389  2021-12-13 03:17:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   90d9fbc16b69..2585cf9dfaad  2585cf9dfaaddf00b069673f27bb3f8530e2039c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 10:48:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 10:48:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245972.424295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwisZ-0000KK-Fa; Mon, 13 Dec 2021 10:48:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245972.424295; Mon, 13 Dec 2021 10:48:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwisZ-0000KD-Cd; Mon, 13 Dec 2021 10:48:23 +0000
Received: by outflank-mailman (input) for mailman id 245972;
 Mon, 13 Dec 2021 10:48:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/ja4=Q6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mwisY-000096-5x
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 10:48:22 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30518394-5c02-11ec-a74f-db008197e53d;
 Mon, 13 Dec 2021 11:48:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id C504D1F3BB;
 Mon, 13 Dec 2021 10:48:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DA5613CE5;
 Mon, 13 Dec 2021 10:48:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id trpAHfQkt2FfRwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 13 Dec 2021 10:48:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30518394-5c02-11ec-a74f-db008197e53d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639392500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=v1YiFDbbZL8I/o3qjFEhE8iDRU/DnB83w3TMAnHNu/I=;
	b=RKaf9VT3vrFvI1v9BokM3fLQ2lxLtcdNoSCMKE15jL2ikpNCAzdV3rwwNNGgWgj7ffkGk9
	1Zb6tEPBQFeMs+e2PcG1fNO4kTYlsX6YUKtqekO/ItpABXly4y4fG79kLRO5mHTe2E54ti
	VLODC7cR+yizjwyBlRdjcfgzQp3ZtUI=
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
 <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
 <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
 <c3f1e075-e142-7fc4-e050-89cf3665901c@suse.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <5643c1b5-2adb-5f46-76cb-8651f5edf7c2@suse.com>
Date: Mon, 13 Dec 2021 11:48:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <c3f1e075-e142-7fc4-e050-89cf3665901c@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="pdlsmhd6EokMq4yvelCNA7Do0uf9e1tU7"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--pdlsmhd6EokMq4yvelCNA7Do0uf9e1tU7
Content-Type: multipart/mixed; boundary="C2fGwQBz63puS1h42K9YaDv3cNXy9ibnf";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 xen-devel@lists.xenproject.org
Message-ID: <5643c1b5-2adb-5f46-76cb-8651f5edf7c2@suse.com>
Subject: Re: [PATCH v3 00/13] xen: drop hypercall function tables
References: <20211208155606.20029-1-jgross@suse.com>
 <b7010028-5a5a-c6ea-fd14-e0d9aa662487@suse.com>
 <4c98984a-6c06-506a-8ee5-ba671cdc4873@suse.com>
 <c3f1e075-e142-7fc4-e050-89cf3665901c@suse.com>
In-Reply-To: <c3f1e075-e142-7fc4-e050-89cf3665901c@suse.com>

--C2fGwQBz63puS1h42K9YaDv3cNXy9ibnf
Content-Type: multipart/mixed;
 boundary="------------52386199200D050C9326B7D7"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------52386199200D050C9326B7D7
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 13.12.21 11:35, Jan Beulich wrote:
> On 09.12.2021 10:10, Juergen Gross wrote:
>> On 09.12.21 10:05, Jan Beulich wrote:
>>> On 08.12.2021 16:55, Juergen Gross wrote:
>>>> In order to avoid indirect function calls on the hypercall path as
>>>> much as possible this series is removing the hypercall function tabl=
es
>>>> and is replacing the hypercall handler calls via the function array
>>>> by automatically generated call macros.
>>>>
>>>> Another by-product of generating the call macros is the automatic
>>>> generating of the hypercall handler prototypes from the same data ba=
se
>>>> which is used to generate the macros.
>>>>
>>>> This has the additional advantage of using type safe calls of the
>>>> handlers and to ensure related handler (e.g. PV and HVM ones) share
>>>> the same prototypes.
>>>>
>>>> A very brief performance test (parallel build of the Xen hypervisor
>>>> in a 6 vcpu guest) showed a very slim improvement (less than 1%) of
>>>> the performance with the patches applied. The test was performed usi=
ng
>>>> a PV and a PVH guest.
>>>>
>>>> Changes in V2:
>>>> - new patches 6, 14, 15
>>>> - patch 7: support hypercall priorities for faster code
>>>> - comments addressed
>>>>
>>>> Changes in V3:
>>>> - patches 1 and 4 removed as already applied
>>>> - comments addressed
>>>>
>>>> Juergen Gross (13):
>>>>     xen: move do_vcpu_op() to arch specific code
>>>>     xen: harmonize return types of hypercall handlers
>>>>     xen: don't include asm/hypercall.h from C sources
>>>>     xen: include compat/platform.h from hypercall.h
>>>>     xen: generate hypercall interface related code
>>>>     xen: use generated prototypes for hypercall handlers
>>>>     x86/pv-shim: don't modify hypercall table
>>>>     xen/x86: don't use hypercall table for calling compat hypercalls=

>>>>     xen/x86: call hypercall handlers via generated macro
>>>>     xen/arm: call hypercall handlers via generated macro
>>>>     xen/x86: add hypercall performance counters for hvm, correct pv
>>>>     xen: drop calls_to_multicall performance counter
>>>>     tools/xenperf: update hypercall names
>>>
>>> It's not easy to tell which, if any, of the later patches are fully
>>> independent of earlier ones and could go in ahead of those awaiting
>>> further acks. Do you have any suggestion there, or should we wait
>>> until things can be applied in order?
>>
>> I think all but the last patch should be applied in order. The last on=
e
>> obviously can be applied at any time.
>=20
> Hmm, I think 11 and 12 are fine to go ahead as well; I actually need th=
em
> for some immediate purpose and hence I did pull them (but nothing else)=

> into my local tree, without observing issues.

Yeah, those should be okay to take.


Juergen


--------------52386199200D050C9326B7D7
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------52386199200D050C9326B7D7--

--C2fGwQBz63puS1h42K9YaDv3cNXy9ibnf--

--pdlsmhd6EokMq4yvelCNA7Do0uf9e1tU7
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG3JPMFAwAAAAAACgkQsN6d1ii/Ey8x
/wf7BLKXr6wnqni0l74KUOPvs+CJjjZ5vBvhl3SK+0WFiWnlm1BzoIhjY9L3W5CM0wxfQ3L56bid
GD0Or9qD+bgAkG/bZAOhv1Ahy48G+Wqz8yFs4/puWi9LMdDhySfHcxyRT2obhaDyVvFVisxF3WZj
kH17+d1IfVUl9dd6JtCGGkoQN5KdYpW5VSvNPkVpAFcDCS6v4pdpZMC4WMgWWnr23PdEqN5U5+qe
zBY7KlPeXrlSrk5cIMP89yi6v97q8HOldHZfuzF0pbcAiB8bEtepdRrVW1oEeY85ry+Hema9cHFE
mHFLeGswi0e1HTn6esHnb01U1Sp1Wm0Y1MgFfAOKdg==
=fZsU
-----END PGP SIGNATURE-----

--pdlsmhd6EokMq4yvelCNA7Do0uf9e1tU7--


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 11:39:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 11:39:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245989.424309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjfA-0006Cn-6r; Mon, 13 Dec 2021 11:38:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245989.424309; Mon, 13 Dec 2021 11:38:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjfA-0006Cg-2g; Mon, 13 Dec 2021 11:38:36 +0000
Received: by outflank-mailman (input) for mailman id 245989;
 Mon, 13 Dec 2021 11:38:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwjf8-0006CW-Sw; Mon, 13 Dec 2021 11:38:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwjf8-0002yS-MN; Mon, 13 Dec 2021 11:38:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwjf8-0000vE-Cs; Mon, 13 Dec 2021 11:38:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwjf8-0000rr-CM; Mon, 13 Dec 2021 11:38:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sKqVqIPdrFfDxsGYLhLKOPNwaAljLI/UWao5d0Pgsuk=; b=wNGJCilCZ7zE5K8Fy8iQx2Giz5
	rj3LL97nBfEZYcH+Ek0ADr2YN2z3pHNC/Fil0TG8gJ1SJsepu9t4vbQdjAhdSWa8G6N7dEaszeZkk
	kCgLPmGVYEn8GciFc8/i+/UFVXqBjtLSZI6tY/dh4SQH+vBz5oOrg47sBl0cRZRk10dI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167391-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167391: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=2686468c437f23e5dbd0a517b04852c3c1f84f39
X-Osstest-Versions-That:
    ovmf=8c06c53b585a7443b1e0e6c0eff45a62d56472cc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 11:38:34 +0000

flight 167391 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167391/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 2686468c437f23e5dbd0a517b04852c3c1f84f39
baseline version:
 ovmf                 8c06c53b585a7443b1e0e6c0eff45a62d56472cc

Last test of basis   167379  2021-12-11 18:11:27 Z    1 days
Testing same since   167391  2021-12-13 09:41:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   8c06c53b58..2686468c43  2686468c437f23e5dbd0a517b04852c3c1f84f39 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 11:39:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 11:39:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.245991.424323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjfC-0006Sz-FB; Mon, 13 Dec 2021 11:38:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 245991.424323; Mon, 13 Dec 2021 11:38:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjfC-0006Sq-Bb; Mon, 13 Dec 2021 11:38:38 +0000
Received: by outflank-mailman (input) for mailman id 245991;
 Mon, 13 Dec 2021 11:38:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EN0M=Q6=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mwjfA-0006Dq-T2
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 11:38:36 +0000
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com
 [2a00:1450:4864:20::22e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 33c19d5f-5c09-11ec-b1ef-a74572bcbcad;
 Mon, 13 Dec 2021 12:38:35 +0100 (CET)
Received: by mail-lj1-x22e.google.com with SMTP id k23so23292459lje.1
 for <xen-devel@lists.xenproject.org>; Mon, 13 Dec 2021 03:38:33 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id f23sm1475635ljg.90.2021.12.13.03.38.32
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Mon, 13 Dec 2021 03:38:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 33c19d5f-5c09-11ec-b1ef-a74572bcbcad
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=sXvHapjS93NaUhHhbE5XKq63oc/+VGXWe8vklnnWKOw=;
        b=ma0UjKKQZNxqT0R1RFKcxJmF7lzJwRJ2/pJMWBUdbs5yTKFTMiQX0WXiDpDTCqyP79
         MO8gShyIYtdiBa0xSxddJg8JbvBd9vsbMt6ZowpOtfIafF5ysCWjPeNNhywZOKCCQwi4
         gYJVN3tGSQEdQ6FS+IgjkB2lEZev9iIAjVXB65XshDD1QBoPitYXkb6Hx94iB9X7klaR
         c3VcSMEvtplsFrJ5LUKhyCN+OqwVeSXhsxD0S+m/PjKMukcEKpw7lEuejtohl++PGlt6
         wUEiL2Ojy4dAC3XY8rPYxTpCKVEpk9H0jKJTpo/2ZrTzBvzBJLOW2O391lo/2eMhBaln
         ebgg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=sXvHapjS93NaUhHhbE5XKq63oc/+VGXWe8vklnnWKOw=;
        b=qFcQr0iJ1Z0eTIeoazWPElX9rP8fjp3DrTGbvc2lEB/KXlcmHWlussTwf5ptX1uagb
         oL1L+wo6991/Lt8Ap+/JoO7WH3azhrZoUrLC/WOCALgLAR8bSlMblepbjW7/zIq9RNzd
         HGpY02m5ILVDnZc9QPlQWujxyrJkghT38ErGD+ywyk2kCQiKOlV7SknxmSyYDrnqIByc
         Muxecrn0C7kuSbYU/2kpPOm4pXKMsrXaYnfHNFF9pB6mYuCpJqDLn+Dk+9P+1zapsPSy
         Ao9OVJLPMTOJCq536uXbeRVw1IOeBd8dSTXnafuqGi+eRx/iBKwnTfIGYVeYi2cEAHZp
         lNpA==
X-Gm-Message-State: AOAM530SA545ELIaSaJ33GSM2KC7jRCzs8nzEwj9tJ7uJPUEsux8sryW
	cj6uYEu6JtqG5LQ++oXvhQ4=
X-Google-Smtp-Source: ABdhPJz/Oyo75Ua15PdhYlpInpjGBIMPv9h0sawBBeyuqvqsMSZ/MpPh4L4AXLbaoyHdbBsKQ8MgyA==
X-Received: by 2002:a2e:b8cc:: with SMTP id s12mr28317095ljp.489.1639395513097;
        Mon, 13 Dec 2021 03:38:33 -0800 (PST)
Subject: Re: [PATCH 00/10] Add support for Renesas R-Car S4 IPMMU and other
 misc changes
To: Julien Grall <julien@xen.org>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Jan Beulich
 <jbeulich@suse.com>, Paul Durrant <paul@xen.org>,
 Rahul Singh <rahul.singh@arm.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <3c3c8641-05f5-56b6-b7b1-6942d6bb5a3d@gmail.com>
 <0024265c-e485-8354-361b-9faa36c50a3d@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <4377a72c-8e6f-9412-59ee-a46bd6648a73@gmail.com>
Date: Mon, 13 Dec 2021 13:38:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0024265c-e485-8354-361b-9faa36c50a3d@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 13.12.21 12:11, Julien Grall wrote:
> Hi,


Hi Julien


>
> On 13/12/2021 10:05, Oleksandr wrote:
>>
>> On 27.11.21 19:51, Oleksandr Tyshchenko wrote:
>>
>>
>> Hello all.
>>
>> Gentle reminder.
>
> This is in my queue of 50+ patches to review. EPAM is the main 
> contributor for the IPMMU patches, so can one of your colleagues help 
> to review it?

I think, yes, it is possible.


>
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 11:49:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 11:49:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246000.424333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjoy-0008OL-Bk; Mon, 13 Dec 2021 11:48:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246000.424333; Mon, 13 Dec 2021 11:48:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjoy-0008OE-8H; Mon, 13 Dec 2021 11:48:44 +0000
Received: by outflank-mailman (input) for mailman id 246000;
 Mon, 13 Dec 2021 11:48:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nKfH=Q6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1mwjox-0008O8-A9
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 11:48:43 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 9dda2c1a-5c0a-11ec-b1ef-a74572bcbcad;
 Mon, 13 Dec 2021 12:48:41 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79E0B6D;
 Mon, 13 Dec 2021 03:48:40 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 932103F793;
 Mon, 13 Dec 2021 03:48:39 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9dda2c1a-5c0a-11ec-b1ef-a74572bcbcad
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: increase memory banks number define value
Date: Mon, 13 Dec 2021 11:48:23 +0000
Message-Id: <20211213114823.25570-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Currently the maximum number of memory banks (NR_MEM_BANKS define)
is fixed to 128, but on some new platforms that have a large amount
of memory, this value is not enough and prevents Xen from booting.

Increase the value to 256.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
 xen/include/asm-arm/setup.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
index 95da0b7ab9cd..07daf160dc57 100644
--- a/xen/include/asm-arm/setup.h
+++ b/xen/include/asm-arm/setup.h
@@ -6,7 +6,7 @@
 #define MIN_FDT_ALIGN 8
 #define MAX_FDT_SIZE SZ_2M
 
-#define NR_MEM_BANKS 128
+#define NR_MEM_BANKS 256
 
 #define MAX_MODULES 32 /* Current maximum useful modules */
 
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 11:49:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 11:49:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246002.424346 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjpL-0000V3-Ll; Mon, 13 Dec 2021 11:49:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246002.424346; Mon, 13 Dec 2021 11:49:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjpL-0000Uv-GI; Mon, 13 Dec 2021 11:49:07 +0000
Received: by outflank-mailman (input) for mailman id 246002;
 Mon, 13 Dec 2021 11:49:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nKfH=Q6=arm.com=luca.fancellu@srs-se1.protection.inumbo.net>)
 id 1mwjpJ-0008O8-Ni
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 11:49:05 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id abf8f7b2-5c0a-11ec-b1ef-a74572bcbcad;
 Mon, 13 Dec 2021 12:49:04 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 364A06D;
 Mon, 13 Dec 2021 03:49:04 -0800 (PST)
Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com
 [10.1.195.16])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9DCE3F793;
 Mon, 13 Dec 2021 03:49:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: abf8f7b2-5c0a-11ec-b1ef-a74572bcbcad
From: Luca Fancellu <luca.fancellu@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	wei.chen@arm.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2] arm/efi: Handle Xen bootargs from both xen.cfg and DT
Date: Mon, 13 Dec 2021 11:48:54 +0000
Message-Id: <20211213114854.25632-1-luca.fancellu@arm.com>
X-Mailer: git-send-email 2.17.1

Currently the Xen UEFI stub can accept Xen boot arguments from
the Xen configuration file using the "options=" keyword, but also
directly from the device tree specifying xen,xen-bootargs
property.

When the configuration file is used, device tree boot arguments
are ignored and overwritten even if the keyword "options=" is
not used.

This patch handle this case, so if the Xen configuration file is not
specifying boot arguments, the device tree boot arguments will be
used, if they are present.

Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
---
v2 changes:
 - Changed logic, now xen cfg bootarg value has precedence over DT
---
 docs/misc/efi.pandoc        |  4 ++++
 xen/arch/arm/efi/efi-boot.h | 15 +++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
index abafb3452758..71fdc316b67b 100644
--- a/docs/misc/efi.pandoc
+++ b/docs/misc/efi.pandoc
@@ -249,6 +249,10 @@ UEFI stub for module loading.
 When adding DomU modules to device tree, also add the property
 xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
 Otherwise, Xen will skip the config file and rely on device tree alone.
+When using the Xen configuration file in conjunction with the device tree, you
+can specify the Xen boot arguments in the configuration file with the "options="
+keyword or in the device tree with the "xen,xen-bootargs" property, but be
+aware that the Xen configuration file value has a precedence over the DT value.
 
 Example 1 of how to boot a true dom0less configuration:
 
diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 4fb345f225c8..ae8627134e5a 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -503,11 +503,26 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name,
 
     if ( cfgfile_options )
     {
+        PrintMessage(L"Using bootargs from Xen configuration file.");
         prop_len += snprintf(buf + prop_len,
                                EFI_PAGE_SIZE - prop_len, " %s", cfgfile_options);
         if ( prop_len >= EFI_PAGE_SIZE )
             blexit(L"FDT string overflow");
     }
+    else
+    {
+        /* Get xen,xen-bootargs in /chosen if it is specified */
+        const char *dt_bootargs_prop = fdt_getprop(fdt, chosen,
+                                                   "xen,xen-bootargs", NULL);
+        if ( dt_bootargs_prop )
+        {
+            PrintMessage(L"Using bootargs from device tree.");
+            prop_len += snprintf(buf + prop_len, EFI_PAGE_SIZE - prop_len,
+                                 " %s", dt_bootargs_prop);
+            if ( prop_len >= EFI_PAGE_SIZE )
+                blexit(L"FDT string overflow");
+        }
+    }
 
     if ( cmdline_options )
     {
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 11:54:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 11:54:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246011.424356 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjuY-00026u-7T; Mon, 13 Dec 2021 11:54:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246011.424356; Mon, 13 Dec 2021 11:54:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwjuY-00026n-3r; Mon, 13 Dec 2021 11:54:30 +0000
Received: by outflank-mailman (input) for mailman id 246011;
 Mon, 13 Dec 2021 11:54:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0LF=Q6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mwjuW-00026h-8Z
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 11:54:28 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a729ddd-5c0b-11ec-b1ef-a74572bcbcad;
 Mon, 13 Dec 2021 12:54:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a729ddd-5c0b-11ec-b1ef-a74572bcbcad
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639396466;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Yj+As1KeYVsp7ZzY87PcF7BnFgTK9iZr5k8q48bwZxc=;
  b=IBQY9urRRixqeEATMdHTSIj8MdEmNdCJkB/Bjkpab22rbU8/78VEFofV
   hmenRnKx0owVatLDNrqXx3g206FbRop4DWVcMEC3vcoFaIVGUBFeqC+Of
   d3wNGfUXDlyoo4jyUULfW+FuLd8JmcHZK5G48pBE9Y6nRo0UZa3H4yEj2
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UdBEoqjDEU86UIvVU6iq0F9U26YPRaON3LotSysxMdat4Fs5Eyh+98tAK6eXwnO3hW4coFQSUi
 wNFeIN5EsQy6D2FVthLwtOMqxUsM/7m60tYHCMmmspHue9yeF6PuIAz0zngtHKXU93cHd8g/JU
 q8/yv5716V1PiYjbejfmB9ITBJx8ja4DFVTYj6q4ppcLyBtCnwVvUNvrkiV4y6cSoy6WbOyQvI
 Ks1oDUN7p6HWU1VHYUNWz2ALF/z0DlMzXRvS6PWjsEgl5JWDltzFDn0MxuoBmnK5nwfMx0DNfw
 KnaCQTTKdqnUVqJBD1/qDYte
X-SBRS: 5.1
X-MesageID: 59868719
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OeitRa6OIcK87A0ZN4G0vQxRtNvAchMFZxGqfqrLsTDasY5as4F+v
 jFLWWDSOK6JZ2D1fI0lbIW+pEsGupeHz99hSQM9/y1kHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Uw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz
 tBor4K1YgsSIaDmnfVMfRxFDjBiFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWZg2JARRKe2i
 8wxVWpAUAjAMj12HWweFq8dpreQt2n8fGgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 mHL4WX/RA0bPdq3yDyZ/3bqjejK9Qv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZHbfk8qsodSQc12
 3WMjoLHACFyoaG8HCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjv3jpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDDtYji7rnXzURhpdnh+5nzuJ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gAv8QPbCb3PfQuC25UNyjN5fK/fekJq9iONoYeCnSPXFHvEN5Sib64gDm2zRlEfVAXM
 paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOvGDFbIGOxtGAbfMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQxQcCVgW8mp85c/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQOqHsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:TFdMdq29DigPwMFnFT0XlQqjBStyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvqRZxRBf7LdEUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PvP+W5gNcNvpcfHHe1Alfii8Q156AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,202,1635220800"; 
   d="scan'208";a="59868719"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ARDvnfxHyjacoLiJLgW9TTSA8gwRALPPTLpDvJtI9m16h3J9kqzgNoS/XG2A8RpVzxyPCFnVBQcRL4NuEuTi/E4YTWSZCHUMfB7ZUtzMsFuQsE7vqXlxtrKppoaxPkuCpjXnOWO2OnU8LXnlgcdy2i25LUjnKK6uggKpFwrcFnM7sP9BhJ6+UQInoDR8+/FT5ravafK5kTjuPXXXTGnqA+t66Z4KSQ78Xmpadgmtyw84SmirbXXSclwgD/zik4cbgWFfIdF8iIE4iTNiEcGMyK0Pz+otitxJtOXJNlfi+QFdhSbozSAHBz5hPlXhxI4RLtLvivtprh15smITv6FEUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GKgfQrXxZQAc0PxZZGbMy6H/JYMU6Jt1L+VZcUzZB/c=;
 b=NRQMyhXZ8VgZXkt9LmhPmRUjGkji7OErVIiE0NN5I1iHwivyficfGRXuIrZm8ZCPB92GxWgWDcLiEbJ8PjUqnKl4Ku+e1L925Paab2VOq1sJXQb4xxtg/a5VwfJBBs8dERtHFirrJxnkyxvQzJVsNgZeU69JsMcAG9efwt7BCBg9mnhnhryFnJivWY+I0yNlyjUoOl2HZWLR0/9aIhI8t+36CKNt8IounPVPe3jbSspzO1TSRmM4Z9zSHQ00Ulhziag/i3ef2PF//Hx3y7ndUmGzdBgc8hwxDrT7t1iri0W1pkUoG8Za8qe5rGsUwrrJjvlUuJU/xZvBKNS1F4tL0Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=GKgfQrXxZQAc0PxZZGbMy6H/JYMU6Jt1L+VZcUzZB/c=;
 b=cd2ZiaXtasOBU7b1FJ/qvw6qEI4yCm+vvVvpd+Yl6Rv/c3n7HvCOkSEy/K9WihWpd0dOoNF1ULnCpdiNh8nywCv+/ERCULE6tjvZQbxgy4JGM8OYKdOPIJDHzRg/yLvZt0LEX/yEtekc57kurIryMaGK4ENyeuJwl1gkYMPzKCM=
Date: Mon, 13 Dec 2021 12:54:15 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 13/18] VT-d: allow use of superpage mappings
Message-ID: <Ybc0Z+EtzQx4CUen@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <df4bfaa9-e708-929d-3c2c-68833dcc2d2f@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <df4bfaa9-e708-929d-3c2c-68833dcc2d2f@suse.com>
X-ClientProxiedBy: FR3P281CA0002.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1d::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fb10be5d-c83c-43dd-12e2-08d9be2f4cb4
X-MS-TrafficTypeDiagnostic: DM6PR03MB4971:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB49713FF51B743580BF9123DF8F749@DM6PR03MB4971.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iKAx13G/4sm5ssj0mStFU6GEcNhaNnjeXA7Eempg5TpxgC+l8h1HTVJlkQZo8p0UCbG/VdCVIox0Nxqpxn9NG0ktMLidcVcLVqnsmimQ1qJVajHjknflF3BXTlV1wXNnf47gmbiYBZY8MQJsv9Kka6pj0uhILAuntntW7qoP9i5QImx13b9lLw+vv5ud8gwA7CsKm/jXXvCbXs/YBAxtKnEP1qq371W7mD/P8NCLky4YMnPXuK54bDH7e7vZD1gIS+/KpwxghFRj4Q+7bGgAQUhLGTuwF2ZWkkID1/uD8H4yOo5McZxw6qEQju2nbQ4yJDWi0BcEE4zd5INDoH9GWw/ah+DN8stRRySRbJnTBhoE9lvat2+qnNbBs/ZdxBpEeVylq/TpX7S+MotcMDYa75JgBHAobiyuUbnxXqs5wQ8i58Q0jC4MoHGbdMeHVdSt7yavMrYCXSPNjXzBHZo2IgKpv6taz7B1opepH+5dfW2V/xB6QhMdbZAtWaMhkJPGmg8dOwaoDV/AOVqNXW1zzOOErkL8suuhLrVrlR6rmvvO5INsyixn6qd0Np1bWqpKBLr1jZ99IiWeVZ+UO5gc8ZTcB1siF7ddFM9R8H8y+7GZfrPspMKc7O8MQJ2CHNt7siGp/9v3A5yOw+GcPi6IZmwFADfrhvznpdqa61CW5In7WFlxjpD6MKolZEuEPpEr
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6486002)(66946007)(8936002)(6666004)(38100700002)(66556008)(85182001)(82960400001)(66476007)(5660300002)(4326008)(6506007)(83380400001)(2906002)(508600001)(26005)(8676002)(33716001)(86362001)(9686003)(186003)(6512007)(6916009)(54906003)(316002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym5aNGQzZy9MSUkxWit5WjRYMzA3MnZSMDZyZkxhTDNhTERqK2k1dEZOUVVp?=
 =?utf-8?B?RGxJVGkxMW5kUXZPRVZwcFNSRzA4MmFFWHFBL3p2dlRZVmxMVWhKZHJpdGpH?=
 =?utf-8?B?UFh1cFhrQmxwd1lEMW1RYmY2Z2M5VVB5a1YvaDRRNzV4NmZwMHZZN005UU9j?=
 =?utf-8?B?SGVRRzhtdW9DSDZYWTk4SWMveG16VzlpOWJ1OXFkdjdycmMvMG1iV21hbE5M?=
 =?utf-8?B?eGhkdUNsRzF4UmNjSXg4SHQ1cnNwcHBuMkRYYnE1YUhJemZCWEdabjE1OWpz?=
 =?utf-8?B?ZCtaYWg4U1lieUtGYldTUmVGSlR4R1prZE5FOWRMcWxVRm4zMFNYa3lqVmZm?=
 =?utf-8?B?aTN5L0UzTUp6RDlvYmdLWVkzK2lBRFVsbFdvNDRZYW93Zm12eXNYclVlMEpv?=
 =?utf-8?B?WUNlNnpKRGplSVVCWGdCOGFDK3IzK2psMDd3c1A2MXkwelpSbEkyTVRoTXl3?=
 =?utf-8?B?QTc0c3VDMjRxSEVGL0hjZXc2cTNXOFZDQVBTa2FaRDJmNjZldFdhRVJ2NFlF?=
 =?utf-8?B?VHNhWDZraTZrRzFwaXE2VDVwQU9iV2pJZDBPeERQQTVzam5EZ1Y2d21IT250?=
 =?utf-8?B?amoyZUdRV1JiZ3IwSEhJeHRXb3g4T1BOQUplZ3BHQUpHVk9PUWd0YlFqWE1u?=
 =?utf-8?B?MnY5R2JuVXJhMHBHdmFTU1hQUktnS3h3VG1reVJtV0F3TnNVWUtVVml3STdF?=
 =?utf-8?B?azJ5S2swWDU3SVVRaGV6VC9GVmxzNkZIMHhiSWM3eXkwL0lGd3pjNHkzZlV6?=
 =?utf-8?B?NmlUL212SnNKZlBRNkdiRXhyZ1FwMEN1TTlqQWFDaHV5Wm96NlZtTUxkOVBT?=
 =?utf-8?B?UEU5ekVtNSttS2pPaGVtU1hINEZtampuTzFVVHZlRWh4czBRZ0s0dFV3WkNl?=
 =?utf-8?B?bDVWQTBucStneTlwT3ZzbkVLU1JYcmQveHlFYTJ3ekdSTU9iRHBXUnNrU3pu?=
 =?utf-8?B?NTJRdVZadE5tYkdjUStBa2FhZzRuYTREK2VhdVo2elkvdXRtRWtXbVJjeHFm?=
 =?utf-8?B?QW9YNm9mR2tyMDVucFprbE82QnZ1Rk9aeE5XN0w0K2NPWUw4RC9lZDlnTS93?=
 =?utf-8?B?aFNhWVV0Ylp5akFZTWNFM0hwUkxyYkFRMWlYckoyK1FqNWFYMEl4QWRvUThE?=
 =?utf-8?B?eGxyVXpZNUwzeFRmc3I3Q05UNUU2eVpNOHZ1MlRwT29QTS9kc0UxUlFqWml6?=
 =?utf-8?B?eERIQU4rM0YzU0ptYmpOSkcyd1E2dk9EWGNwWWxuK2VoNjFWK1dzanFXNFRi?=
 =?utf-8?B?cVZoU2Z6WGdJUmp3M3lxUWRJMEJ6c1ppUXc0clJIeHl3VERtTGthR1BNRTdi?=
 =?utf-8?B?Yk82cVJTenhXZ1lXWFFhSEdpTTF3Q094YWkzNmFQcFVRZWZTNVRac1FnaGZE?=
 =?utf-8?B?ZW50RUc4U0FxblNZNUl6aTVlNjYydGVSdnF1ZFlNQ0xPVnc3L1F6U2tVcC9n?=
 =?utf-8?B?eGYrOThXSGM3eURma05DeWxsekluTlJiT3RleGlzQ1dIRTEzLzB5U1NwVHRQ?=
 =?utf-8?B?dkwwc2VFN2RiSE45R2RhVndQV1ZpR0JWWERKR3gwaXc5Z0VoaW54MzJYeUVU?=
 =?utf-8?B?T0NxTHZlQ3RvcHFzMWFidVZUMkxtVmVtajhBcHVYQm5oaEl5aFNZWFlRTVR2?=
 =?utf-8?B?UGFtK1FaQnNoaitENUVzcElrT1RVOUFsZ3pyd0Z5YnB1bmZXaDFhdnR1Yk1v?=
 =?utf-8?B?Z2cyWnRHWFpNUHVHMmhJcXBWbnJsZ043eS9TTnh5cisyY0h1UUhqeTN6TVBZ?=
 =?utf-8?B?OWFzSVMxSE11S0p5blZneFNoRzR5UlFTU0RjVnhyTVhGb2pSTG5Cd1MwUTg2?=
 =?utf-8?B?NmtwTUtzL0l5eTVsZTB0eHhPOEs4QVlkVWEraUJHUHMyOVdRaG91bXJVcjNk?=
 =?utf-8?B?QnFKMGNPY2dVcW9HNFFXQU5xVmhKTksxQ1pnOWxXVXNaMVp3YjN3STh3WGNp?=
 =?utf-8?B?aHpkaEMzdVo1WlNnbVd4TjF3MTZ2UEpnS29Zc2p0NGJHd2RMK3VuSG1DSC9V?=
 =?utf-8?B?OE1oODRrVEQ0cWRWYlRXZm1ITDdrNnJ6YmFXbElmaHBZcWY1Y1VzUTVrbkl1?=
 =?utf-8?B?QVVjMmNVUXNyYWU4K3lMeUtWV2dqWS9RcUFmZWgzMTRoQkZTZzJZM3laZ3Ry?=
 =?utf-8?B?U1RYdDVUY1dPb29iQzJlQjkxS0F4T2NUTTdFckFpMUtlOGdlamRBeGwyYTJP?=
 =?utf-8?Q?jtdGThS2XNnEYmlRt36/jUc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fb10be5d-c83c-43dd-12e2-08d9be2f4cb4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 11:54:21.2023
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4KL2U5WpfolL7Z/SnEjW1pBGxLX4eSqPZNI5fe5uxpvEzQJaKRjUjBmuGYZFTKwjgjhkeevmPuhm6OWN5KhIxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4971
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:52:47AM +0200, Jan Beulich wrote:
> ... depending on feature availability (and absence of quirks).
> 
> Also make the page table dumping function aware of superpages.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Just some minor nits.

> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -743,18 +743,37 @@ static int __must_check iommu_flush_iotl
>      return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
>  }
>  
> +static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int next_level)

Same comment as the AMD side patch, about naming the parameter just
level.

> @@ -1901,13 +1926,15 @@ static int __must_check intel_iommu_map_
>      }
>  
>      page = (struct dma_pte *)map_vtd_domain_page(pg_maddr);
> -    pte = &page[dfn_x(dfn) & LEVEL_MASK];
> +    pte = &page[address_level_offset(dfn_to_daddr(dfn), level)];
>      old = *pte;
>  
>      dma_set_pte_addr(new, mfn_to_maddr(mfn));
>      dma_set_pte_prot(new,
>                       ((flags & IOMMUF_readable) ? DMA_PTE_READ  : 0) |
>                       ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0));
> +    if ( IOMMUF_order(flags) )

You seem to use level > 1 in other places to check for whether the
entry is intended to be a super-page. Is there any reason to use
IOMMUF_order here instead?


> @@ -2328,6 +2361,11 @@ static int __init vtd_setup(void)
>                 cap_sps_2mb(iommu->cap) ? ", 2MB" : "",
>                 cap_sps_1gb(iommu->cap) ? ", 1GB" : "");
>  
> +        if ( !cap_sps_2mb(iommu->cap) )
> +            large_sizes &= ~PAGE_SIZE_2M;
> +        if ( !cap_sps_1gb(iommu->cap) )
> +            large_sizes &= ~PAGE_SIZE_1G;
> +
>  #ifndef iommu_snoop
>          if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
>              iommu_snoop = false;
> @@ -2399,6 +2437,9 @@ static int __init vtd_setup(void)
>      if ( ret )
>          goto error;
>  
> +    ASSERT(iommu_ops.page_sizes & PAGE_SIZE_4K);

Since you are adding the assert, it might be more complete to check no
other page sizes are set, iommu_ops.page_sizes == PAGE_SIZE_4K?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 12:13:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 12:13:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246024.424366 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwkCb-0004xv-3V; Mon, 13 Dec 2021 12:13:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246024.424366; Mon, 13 Dec 2021 12:13:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwkCb-0004xo-0d; Mon, 13 Dec 2021 12:13:09 +0000
Received: by outflank-mailman (input) for mailman id 246024;
 Mon, 13 Dec 2021 12:13:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/ja4=Q6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mwkCZ-0004xi-JW
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 12:13:07 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 073e9882-5c0e-11ec-b1ef-a74572bcbcad;
 Mon, 13 Dec 2021 13:13:06 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D11D61F3BB;
 Mon, 13 Dec 2021 12:13:05 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8806B13AFF;
 Mon, 13 Dec 2021 12:13:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id C1gDINE4t2GqbQAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 13 Dec 2021 12:13:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 073e9882-5c0e-11ec-b1ef-a74572bcbcad
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639397585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=WX0fSJx4ry5befNHhZXExiuB+xLKEi1j22tOnvthZRY=;
	b=gNjD4ucwL6rgAGeZ5zmq5jvoJQZmsf1y3vmTc3+TTZoCM8Y4hJZHKezptkCiEUg2fWcEag
	d8rsY0v+ldFHDq5+915nvV1iFJ26LOylqFlXb9wz9J0AQ2FH3izfj+XWLMXwvkiF2onPY2
	NMgm9mUbCzWeqtzT3RkiEAP9JsVulYA=
Subject: Re: [PATCH 01/11] x86/entry: Use swapgs and native_iret directly in
 swapgs_restore_regs_and_return_to_usermode
To: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, xen-devel@lists.xenproject.org,
 Lai Jiangshan <laijs@linux.alibaba.com>, Andy Lutomirski <luto@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
 <20211208110833.65366-2-jiangshanlai@gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <0f932791-5c8b-b1b7-1d47-15159f55da10@suse.com>
Date: Mon, 13 Dec 2021 13:13:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211208110833.65366-2-jiangshanlai@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="9EdWxFWZI7ivMAfuAhKX0dW49YWzVpxEB"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--9EdWxFWZI7ivMAfuAhKX0dW49YWzVpxEB
Content-Type: multipart/mixed; boundary="ZZncoA5l2hrXTSZf3ebMCnwy5o43fkHEd";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, xen-devel@lists.xenproject.org,
 Lai Jiangshan <laijs@linux.alibaba.com>, Andy Lutomirski <luto@kernel.org>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>
Message-ID: <0f932791-5c8b-b1b7-1d47-15159f55da10@suse.com>
Subject: Re: [PATCH 01/11] x86/entry: Use swapgs and native_iret directly in
 swapgs_restore_regs_and_return_to_usermode
References: <20211208110833.65366-1-jiangshanlai@gmail.com>
 <20211208110833.65366-2-jiangshanlai@gmail.com>
In-Reply-To: <20211208110833.65366-2-jiangshanlai@gmail.com>

--ZZncoA5l2hrXTSZf3ebMCnwy5o43fkHEd
Content-Type: multipart/mixed;
 boundary="------------75AE9E31D87949C2A1A12A70"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------75AE9E31D87949C2A1A12A70
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 08.12.21 12:08, Lai Jiangshan wrote:
> From: Lai Jiangshan <laijs@linux.alibaba.com>
>=20
> swapgs_restore_regs_and_return_to_usermode() is used in native code
> (non-xenpv) only now, so it doesn't need the PV-aware SWAPGS and
> INTERRUPT_RETURN.
>=20
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------75AE9E31D87949C2A1A12A70
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------75AE9E31D87949C2A1A12A70--

--ZZncoA5l2hrXTSZf3ebMCnwy5o43fkHEd--

--9EdWxFWZI7ivMAfuAhKX0dW49YWzVpxEB
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG3ONEFAwAAAAAACgkQsN6d1ii/Ey+H
Cwf/ZbWklLkwJAqgAJKafaqmJMckw8HFBT3T0ZNO1pI0IkE+qB6Oaq5kZGEbFng4fyNff3Jfia6L
yFRfwrk/kUXcEe1CTrRSBJOaHKoGMfEG7mzjFXzwmrPz11dl2PFM0QgOm1oUTDg+kFsxXBhwwUnT
U+i4O+hntP8ay/4QlHgiuDGzr5HupywGbFF8uWAoXpSrnYBNystCcTlqNhRNCBh5IW0g++rMA6kN
Uzfs2XTmLN5Q19WbPh5WKfvl0UB1u5EnzGEHy1mNwr6iYaFovHM28y5XJjg5aMYqDbjaY+irm969
60V1jeJtxbJr+4pPWPH/mVPkO2rhr/6ROJkVIJIguQ==
=7Q25
-----END PGP SIGNATURE-----

--9EdWxFWZI7ivMAfuAhKX0dW49YWzVpxEB--


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:18:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:18:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246035.424378 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlDK-0003Jm-Kz; Mon, 13 Dec 2021 13:17:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246035.424378; Mon, 13 Dec 2021 13:17:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlDK-0003Jf-Gm; Mon, 13 Dec 2021 13:17:58 +0000
Received: by outflank-mailman (input) for mailman id 246035;
 Mon, 13 Dec 2021 13:17:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwlDJ-0003JF-Dh; Mon, 13 Dec 2021 13:17:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwlDJ-0004ol-76; Mon, 13 Dec 2021 13:17:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwlDI-0003Dt-UD; Mon, 13 Dec 2021 13:17:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwlDI-0000SA-Tk; Mon, 13 Dec 2021 13:17:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ubtvlIEAFX4HoFEXaZZAtwZ0fRDMoFesrK8qcPcQIGA=; b=3fz+cVwuu/1fRGlq9IIypGs8Ey
	cEOd0dZ9jXHB6+BXnU/8ysaz62KtwlkMKx1pXaI5EMH2UqCqIwSC11v08G2BCqZXawG9ewQPYecZz
	mMy6LPZl8jpJZlKdXCeLkj0FeIcZjcoQr5B0ndDpbohXehnRjLTVbtEpSmGg7Tr6dCvU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167392-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167392: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=1203eba58ecfcddf9a9ae164ccf32ca29037af82
X-Osstest-Versions-That:
    ovmf=2686468c437f23e5dbd0a517b04852c3c1f84f39
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 13:17:56 +0000

flight 167392 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167392/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 1203eba58ecfcddf9a9ae164ccf32ca29037af82
baseline version:
 ovmf                 2686468c437f23e5dbd0a517b04852c3c1f84f39

Last test of basis   167391  2021-12-13 09:41:34 Z    0 days
Testing same since   167392  2021-12-13 11:41:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   2686468c43..1203eba58e  1203eba58ecfcddf9a9ae164ccf32ca29037af82 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:38:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:38:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246043.424392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlWT-00063R-7i; Mon, 13 Dec 2021 13:37:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246043.424392; Mon, 13 Dec 2021 13:37:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlWT-00063K-4b; Mon, 13 Dec 2021 13:37:45 +0000
Received: by outflank-mailman (input) for mailman id 246043;
 Mon, 13 Dec 2021 13:37:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlWR-00063C-By
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:37:43 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20612.outbound.protection.outlook.com
 [2a01:111:f400:fe59::612])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d712d2a6-5c19-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 14:37:41 +0100 (CET)
Received: from BL1PR12MB5272.namprd12.prod.outlook.com (2603:10b6:208:319::18)
 by BL1PR12MB5207.namprd12.prod.outlook.com (2603:10b6:208:318::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 13:37:38 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5272.namprd12.prod.outlook.com (2603:10b6:208:319::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Mon, 13 Dec
 2021 13:37:37 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 13:37:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d712d2a6-5c19-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ki5BN33Ic7DMxipuaQkKgWuddBouHcbm9iDqcVZrR56znv0141dDiHveqC2MxsMYUQn6UkM4NoBmSWVFIR1tqVb+4jbwzRMcunlGkw0o504hq2PNdWd4p7pQON7B8ITZl9IsDKWMVDSlDWe317IiwsUe2TYPhc0d2SAwsEfb+Vc2l3m3+iJsvbhTCQdg369sZjv3mWnQbw0VhYWg0NpwOIusTXsOB3s7c663R3oad1clj46XagEeZYigzjHBpl9Rp7fayl+9IhMbPwe658J7UjH8KNpwLMJGar3NOW8SHpC5beufAo6VYJssr8P/qrSXgHPWPKbJ8Ir74qV8h8ei3A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xggFXRr0LsROw2d6Z61nZ7hHVxM38Z13f0KEkB/Uhw4=;
 b=LQI9zQrgi8BymOvVzFpv1YQx4Mn+ONoD7weq7u3udebHW2dqNlHqmwe011BFI0KH0+7JSFapNgMcIQrO3qu5SxyLiTw5xHz4Ahm6kAZqfvKZv+vHs3xdH+Q2IpfoCHQJUkKLbYpmLYlSK9OTkgzCCpudMjeZvvu4EfESI4WQi/2Kmst4Lf+iz2P79hFNWSnAxObHJX2vlOhC3dM0AH5PXb82HrbyWyLiB7QftLIzhrYcOqokCiHICKDjmP0iu6K61mhKT+Z++1u0SXBeQOX0xjk87Vp5S57NUQ+3QAXJ0QcGEFECuWnale2HGWxcGXPwRKDeBjL7Tm/f7dxkAsz73w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xggFXRr0LsROw2d6Z61nZ7hHVxM38Z13f0KEkB/Uhw4=;
 b=ZlSorW0ZAGYSekVtz/5f9u42qg+HPrOHdhQllA8cjTUmTe9SpCiM/zPfJuA5zBlcE8cMql/RhORIjOQJwiZrstDuS6a8ScAr9yGaT0SkKT0xrwIxJTr6rgEjN38rnMh9xdhiBMZhPACsrIJGViVUxkNVOjN8Bjjn/9WAaAL77NOhwMD8MXVdZNxK8lEWNoVtfUw7jbVFhIW1Az7QXDhkzvQDGLrLpNpeQAFWqrmS7yBFq9yo2Ae3ntg6EyMoMVPjLolc+2bRctZyfmKKxOJhBBLGEEVw4+RmEERFCx2QK1PGUWF1ym8uaGSDvgI4S/EmqyRoZBHFBd3CIKN5muA9pA==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 09:37:35 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 01/35] PCI/MSI: Set pci_dev::msi[x]_enabled early
Message-ID: <20211213133735.GU6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.250049810@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.250049810@linutronix.de>
X-ClientProxiedBy: YT3PR01CA0059.CANPRD01.PROD.OUTLOOK.COM
 (2603:10b6:b01:82::6) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6f276fb4-b3b7-4cd0-30db-08d9be3dba1f
X-MS-TrafficTypeDiagnostic: BL1PR12MB5272:EE_|BL1PR12MB5207:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB5272067DA35BD30855DBC8C5C2749@BL1PR12MB5272.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5ZNdlvyKTGTbehIFUDKiA7YcdDH/5E9YKYmkS8atCo5M1+yMncNYjnyXmTrFKfiy9YWTVVTW/J6rrc7RCcDpa50UexR+l7IaZ1EYQf8SVlEDIijCGL+A77atYYSyGk74xu0IuG2BLeBFGf69eAlp7l1g6PTTkVU8ajhVuaiOVe186TaZGIMGIFg+wWCpLwPfzSMOI17nC/TatKdncHABQwX/l27k9Ox+Lmcp9cbyrSe0fC+YFBOCr+pVUbGGYPte94jP0BD2NVxB9fvqHvm8G+yYg4MTQEpzGjOYMNFonH7egb9lAsbpyQMK4FqfW6SROxF0KvqIbPvaQ+30vF/vdtuFIxJE4RORQ0EY1Q7XpoG1UrB2s8f4XkjkCeVjlONRHn844uuIWETBKA1E1iL+77eO/kvj8KMRAlLNhP5CAEJv6uQTigMPh4JtxeQ72wVlNPuQqcPWiWoLDysRVbrraUhcsfLslucBQOYf0eu35zurh1xtBmERNDMzMgw4A8Tb99mKXkPNWgDMtXWzYaOXP2k7e64kR/PHWXPhzE93N14u4xelnWFtJdPuTXeFQZKmBcglOnf9gaYYsaV52t8qrhNADMS59ZU97pqqT9bjrKlwWM6MWFdEXzUP2UcQYN2k7vmep7rpMkMBEMBj0+diTg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5272.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(54906003)(86362001)(4326008)(7406005)(316002)(36756003)(7416002)(83380400001)(508600001)(6512007)(38100700002)(8676002)(2906002)(6486002)(4744005)(1076003)(5660300002)(33656002)(26005)(6506007)(66476007)(186003)(66946007)(2616005)(66556008)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?xdqpvC6oG/g8YjIodR1SC4/6w3DBlwnZJ0pJ5J+9kjCrBJbjmPTloLXFgSWU?=
 =?us-ascii?Q?XTyGOe4aUI29ZZb2KP2+F3Sh9pNDeSADj3XDjmgU3H1PJK8nCcq62n337HBg?=
 =?us-ascii?Q?WVwhCHVZQh51MA1uZ4llaE0WsHXusAe/NpQ0+aQItmefcLUpeJmNHcQ1uVJ/?=
 =?us-ascii?Q?4+7wiFaIh4xyAjp2rpvQj9RodEKiGmwQHDggzJfkqqMFgaX+rI05mcJs/NRc?=
 =?us-ascii?Q?h/St0MWkgpHbX0lkTGw7BUINrpXkhV82undeRCyAW9Mjxhj0RoBj01CZedwv?=
 =?us-ascii?Q?+t2BkL5FcXzFN/nI8wFJfYz+hf9+wWKstPUD089HvAxxcnBKctmp9d7kx551?=
 =?us-ascii?Q?f48DK4/sxFzAkm7QXHvMZ3V3g+33FGbd2fk5jTGFXMr4sdqDEUQW5OzNnNaT?=
 =?us-ascii?Q?r3ianOYaF10GTHCoSbFbFJe7BM0unNiP5IKcYjY5k3r1hiIwelOhi3TqETR3?=
 =?us-ascii?Q?3WP+CaTRaQqpV1rZ/ICh7M56q5w7HC9cLvq2PMJ6hAOCcSEY5acqLz6UtH5c?=
 =?us-ascii?Q?YdXwSKE/oSkd/BN8tnNQsohn3rFthwg+4WCedpXhfY5ZpkwmIk4aJuQIwlqh?=
 =?us-ascii?Q?Y0XZBVP3NVhMEnvMc2GYlm0VF246sGlXHKPFHGGGjEum41Zosyhv/pGsuUD9?=
 =?us-ascii?Q?TbelPO+G2Myz8I98fbyTJO+buyH9jxmmgJR0HrWtRjsLxujZO7JOZ/k3djW5?=
 =?us-ascii?Q?iGb0shFdBAQB8ij/bGpNMEwV9vgT99DskvE5jp6hI+xIH9gxHTj4tMD0qceC?=
 =?us-ascii?Q?VPBguO27ihBmUSFT7KGPZf0A+cUtvzz7bo6d5NMhkJHgXSOCIgfF46jf2Q1I?=
 =?us-ascii?Q?KD9SDpdczWJqDk0sqXY7PZEMDLV/jNVfWrW2YN3uVqGIb5oyMgL8UQ2ZW8Eq?=
 =?us-ascii?Q?RN/+Ac/gQ3z0pl/3FtdIbjXa7v499FzyZQXD6F3XRhbI8TYSK6Sx/a2Bkff3?=
 =?us-ascii?Q?ATQkvEzUPcU13I21IvWl5YE9ZdxHJfnJ3kiZMRqtsqJAIfyro8MIdiMewviH?=
 =?us-ascii?Q?HbDF0eWilAPXOEohUbSUlDoZdrBokj9EKaQdy3sVLrgm/8CnXkAIK1+ZYEmM?=
 =?us-ascii?Q?Dg/qJvd403zZojUiF8yTilXG+aReBDrJMFF0SgmW5IIXyP5MgWN5/T9lpeHN?=
 =?us-ascii?Q?SdNMYIo6n7b4mUF20CfBfVTWWe2z8AaP0qPNRWXe5nOfJGpAQXIzA4fXyZdT?=
 =?us-ascii?Q?74dlnPeVgUC4fP20/lwkM9Pi6eAdar/z2ngarMQ1JOVN2P9LWBEeQ98JLfSg?=
 =?us-ascii?Q?8VdoKOfoopHxnEq10zr5ZH4yjrMKRuic+EVMCjAI19e+2oReOwupEXKKCcx5?=
 =?us-ascii?Q?3CATr5MC0B2E7gSMjzIBczFwGftt99cyP4/o0N1f+9fPYlGRyqS9bXa6DMn2?=
 =?us-ascii?Q?7qBYoIv0rbk5kMvn89z8xAat/3eDb1Cscrl7yNZLCZnOfDZsILYYQDT03gUu?=
 =?us-ascii?Q?DQHY/K2u+hvbI5xkFE4ItRbbN9ofh6jMhrcOkugbPso8ntAqtVF7SOq9FhNR?=
 =?us-ascii?Q?E1RXBy+DpRjwV+b/Ot++hGmUoZr2mobxa3J7lGRd7YSvQzTMZGLdKV2/f34d?=
 =?us-ascii?Q?0EnIyilE+lYn1/BDh/Y=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f276fb4-b3b7-4cd0-30db-08d9be3dba1f
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:37:37.6399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VytknH7paVPjrCWIKp0flqHqBuCf5kFFsxuZNo9G/pTnt4rie8xiU6i3m/jhM/Nc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5207

On Fri, Dec 10, 2021 at 11:18:44PM +0100, Thomas Gleixner wrote:
> There are quite some places which retrieve the first MSI descriptor to
> evaluate whether the setup is for MSI or MSI-X. That's required because
> pci_dev::msi[x]_enabled is only set when the setup completed successfully.
> 
> There is no real reason why msi[x]_enabled can't be set at the beginning of
> the setup sequence and cleared in case of a failure.
> 
> Implement that so the MSI descriptor evaluations can be converted to simple
> property queries.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V3: New patch
> ---
>  drivers/pci/msi/msi.c |   23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:39:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:39:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246052.424406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlYU-0006pM-L0; Mon, 13 Dec 2021 13:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246052.424406; Mon, 13 Dec 2021 13:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlYU-0006pF-I8; Mon, 13 Dec 2021 13:39:50 +0000
Received: by outflank-mailman (input) for mailman id 246052;
 Mon, 13 Dec 2021 13:39:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwlYT-0006p9-Ec
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:39:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 23678a7f-5c1a-11ec-b442-ab1a14567e0c;
 Mon, 13 Dec 2021 14:39:48 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-s4m3lFytPRGeDxfH7qGe1w-1; Mon, 13 Dec 2021 14:39:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5902.eurprd04.prod.outlook.com (2603:10a6:803:ed::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 13:39:45 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 13:39:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23678a7f-5c1a-11ec-b442-ab1a14567e0c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639402787;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=yGzc+VllGjUQmLpJqOMSQPA9XNGozl4JLrugOJqdT0M=;
	b=EbHfTPi3GnMnWj90sGSKwWV2pYOb1b42ukV9gy3a8Ks3tdm7LHYyp7b9ruoYhOe6XhIcMF
	zrTcLprS1ik7lrQAZfFrWrkCyTH8bYkFtQk16VbdtUTMtvDYO0D7PntbY0jMgIdz4FnER1
	Q7qlmg97cEsMmlO+2aLVRkKBlZJY53M=
X-MC-Unique: s4m3lFytPRGeDxfH7qGe1w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i0Ai38ihPVzbNWMJCMB5PmfSQNZCfmGkLqLh4q39OPZljFG+igGU8dtKmDOPrqJCdzPJBrd77/76VDTh5eLQpCpZFIIq0PMYPMzktowF8lkq+xNiyrLeS4/8ydLM1zlA9fXiAmxkA7642qxqz0Umncke6Ictr0FygG1zv5TYUhVyRuWLhXAQpg3Lx4OiUMG8bpZvwd3aU3vhr8ZDWcRM5sA06EgXkz7ITQ/gVYGsfdTv9ZLiVzTgwrwWttJHptNr0MdWaGWJNmpws9xvEuwPoNMKMlAOqEBIjH2d5xJrY9JzkBRgQbyM2giqdpHbODl4Y8MYIR62Bbzg2jXPz6SYuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=L96i7sQ6u5l7fW2KuMVWOD22iIWjEDcGtG5sQoOy31Q=;
 b=GkJWbGqA5fZ+Nmqasd0x64FdJCRQekG5tvvk3tR/k1kg0nOcXscHldkaZbvQGFqr6fdxG7okVAGgboehp1fworNZVwTWu33Hys4jYUC5hG9cm3WahYX2vp78D3/U4gCpJESHzMyjr//yUFJlGTO/ri3dyw1IFvnoGNsKQ9f4Wn89HRj33lDtp+cjDIUtt9uefUP4GNU8xfP2ntqJgqpQUv96CdDSktcrJzbrgfnNhnujhYA3eKHbvHEuP0cND++CiTcdeClR6YICvrhHwhuBKZiTWcOmthsM88IYVsBq0jPD3RXByGeinkcR3CMzqPTzq9KGfaikXkACRdIA9XDMRQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <4e8a4472-8bbb-a2b0-2fef-4ec587f69124@suse.com>
Date: Mon, 13 Dec 2021 14:39:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 13/18] VT-d: allow use of superpage mappings
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <df4bfaa9-e708-929d-3c2c-68833dcc2d2f@suse.com>
 <Ybc0Z+EtzQx4CUen@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ybc0Z+EtzQx4CUen@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0063.eurprd04.prod.outlook.com
 (2603:10a6:20b:48b::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bdc65628-20c7-4691-6592-08d9be3e05fb
X-MS-TrafficTypeDiagnostic: VI1PR04MB5902:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB590245AC86B19D0105C47E75B3749@VI1PR04MB5902.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jV3sSk5LizAC6fUv2IHrTLlvyfVyuNdGi1YthAj+bDl2mRX3ThBZ47PNMiggwAlPi/tmyxxdZItJjsEgesmhrFwFOiYyJIyS+R9ivwjQnjIwMnw8kzBBuSNJy5U2O73Oy5OZaFDmYKcGUTB4n59aQraSQ6fT8H0LVd8SbrMRg5/2S+EkdpEYUSdFoFV4OqARDONagj6WS09cQAT7+oRgJxg6Vex4lV3r+06xJS8rzTsa2MmhwZdRcrsImO32uAt6CKgodWpPsQg+E7DkxpUeRa4/wO+70guo7QQAhhtJf1pwW+/r3Jng4CbfXx0eB7Ejf7d/zw8K6312sq4y7KAjtst1i4/ae091BWzxhFEKlLfTqz9/xLXftZIMj0SsVvkk1fYtYDTQYNaAShPuH87sIyfVZjzvCIM0vuUWgXqPMTzlH2skJZDOoWC/1KpoZILcSeRk10kgT4dY2Q8C5ZBx8H+8QtKzhRTEAZM/e619x4rhUYLKI4s5ROy7mAx3BtsiQ4BbZ1ehuaCBI9Nw7daSgnD/GN7WgT4zt14mn9Maudkch9FZSiD6Xv7W4xnSgL0ues3pWd/PumTARiUE6yGOEUdp9Bovl925VfyV5w6N0MFoezVjOu8e0SOQvPrbNZOOdnY3KaE8BWSkMyIflwWOaJt49tqUwMal+UA578GdrOI8DIq+bOP2gWGuyuL9q9HzjUFhDhtmf5mO8aPHAG0rZs1gczUmkO+fG7s4JUd+coo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66556008)(508600001)(6506007)(6512007)(66476007)(31696002)(4326008)(53546011)(5660300002)(83380400001)(38100700002)(8676002)(26005)(6916009)(186003)(86362001)(2616005)(8936002)(6486002)(31686004)(316002)(54906003)(2906002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?DYjf3dhwU34DawNaLQuTbKGwJ/0K6zh5YDnIdNENrEEVfry9V9PD5RTWdRqP?=
 =?us-ascii?Q?W1+7GzXJIm+dN0JyoCbIxhC24FDMI2/L401P3Kfi3swO53pW7KsVoPreyAWa?=
 =?us-ascii?Q?PAnLxkrk5tRh2JhUDa/MnfKvEozvE1Exz642kbhr5sePMTO1Kxlh35ZaOhjq?=
 =?us-ascii?Q?k30DMiQG0bmKwDNCgl+ZOXVq6pL4IPdgS846iMfTEdZIC+69KpaaA35eEaqI?=
 =?us-ascii?Q?pCA74PSy6tXusEM2G1IBY1gs5a/s0ZNsDKLwgbx+xvhcsOSroDFcQPwJ7+wU?=
 =?us-ascii?Q?QyKJ6dZ4IVfMvvR1hgZcnsxX3kfba5V9wYd/MKBW3xziCXg7Wdxg1Dq7GhDN?=
 =?us-ascii?Q?gYYOg2scjGG0PUD2VYUib/ortURU8D3QcoRsGGhRCLKc0/NhY5r4knn/SRvE?=
 =?us-ascii?Q?+pkwfmeVhgZ+msw8vLNsqgKNgY7IisUSqnkXq0cWtzdiC1ZhSSvlthldcmje?=
 =?us-ascii?Q?XyIgQGsxmHYmaCffe97gZcEnSfxpjk5m8Rp2VKi0ldroEd9zpIIEkmkN5hKf?=
 =?us-ascii?Q?780PUTJ1M0IWaOP+a7lkmXx09afVOs10K3hzhz0SvDhhZc8AZJDDjCVkPr//?=
 =?us-ascii?Q?snOezFlRBF8S/D/9otpG8jU9IRO0n+sm4IqsRMSoYKNpAFO+4u69M+pSxCKq?=
 =?us-ascii?Q?ApvhbQoCAcF48g9XDzYe6Xt9zBnVO+k3wrOwnypQma7eULs4sEVvO/7MrJDh?=
 =?us-ascii?Q?ILTPW09rgXHiBbmplUE+tzpb9WZe+IraRNroz5IjYklAp9xfFzeC1HJS/LzH?=
 =?us-ascii?Q?de7mXhfUt0S4r+ctcvB8wyE5TY5lDcdjeiedp2uzKWDO3KyXIlusrQVjaYu0?=
 =?us-ascii?Q?exeKtDd5+rNU83YtKfIL8JCdGjmcliFHJ4A3bbn+5rV+kDFSN55IBwSfiaLf?=
 =?us-ascii?Q?Ku+S91YA8BXj3D/1+DB1b6vCU8cOLeDK7RMvmTOXBmC2r8OaEqTtCNbnxrDZ?=
 =?us-ascii?Q?bm7zmNSiZz66XQC/YNN4900oWWPXTa5Jpi3YvGm8HxRD9FyI0G9MGw3zjdlA?=
 =?us-ascii?Q?vukHcfv61Vq2qPFaq6wKRYFavSEpREYSKMZwoeH45ZGu3jCaJI8ZJSlYZIG3?=
 =?us-ascii?Q?aCZonTKfyPXk/gtVkvNHPDlKuMMSDUU5nWVVJtNJGEt1S455JkILm5HEz8xt?=
 =?us-ascii?Q?hJRbVlA6N31GPU/SNjz+z/Y50BtmZeHiCk3RGn7LKbSIF2lWJ0olrM4W46iL?=
 =?us-ascii?Q?zMlgKFTItYEZKCGNodppCljtK1Wm1jQQ3P4aLxdS3JNKQbs3B1iKmvkutY69?=
 =?us-ascii?Q?6XZfnK8aS7ahYFRARVqNn/8DESW2XmIAnd4vEWP/dhq7g5EYpoZ/gEfDSpKq?=
 =?us-ascii?Q?NXK3RMKqxR8bWKM2AokDx49j5CsAzsBXyYMQiP8rtaTGp65pRPgHY+bq8vVE?=
 =?us-ascii?Q?3dAxpKgdrYmrrNf7hcecFY7FBZ+uumuxsCuefHZDFK/IjOKvx6Q8S/lsgPql?=
 =?us-ascii?Q?X/+UELwCkEXGT3l8t6/rRMT32jDWSMuF9KqzSaehATZcH5tifO8AskBJIicn?=
 =?us-ascii?Q?PPXehex8nTyc8V2AcnEbr3HQGXNuGeGm9278toRV3sYXnnrvqbXKYCTpRmGe?=
 =?us-ascii?Q?nUAVvBeLF6gSVePwz3rdj5indfBOIesGne7oTzBf+zI8GF92wOaJcxdD8BVf?=
 =?us-ascii?Q?flxAz7o++4RYOZhpVG7bgJw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bdc65628-20c7-4691-6592-08d9be3e05fb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:39:44.9026
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NIhAxPCAcFqZAXDLWWSYW5ymlNVKos5w5IZYc401AXXI0HJBjeGwNIC5REIbAPoQSq6W/jOq0bKJP+sH/KSIGg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5902

On 13.12.2021 12:54, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:52:47AM +0200, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -743,18 +743,37 @@ static int __must_check iommu_flush_iotl
>>      return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
>>  }
>> =20
>> +static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int nex=
t_level)
>=20
> Same comment as the AMD side patch, about naming the parameter just
> level.

Sure, will change.

>> @@ -1901,13 +1926,15 @@ static int __must_check intel_iommu_map_
>>      }
>> =20
>>      page =3D (struct dma_pte *)map_vtd_domain_page(pg_maddr);
>> -    pte =3D &page[dfn_x(dfn) & LEVEL_MASK];
>> +    pte =3D &page[address_level_offset(dfn_to_daddr(dfn), level)];
>>      old =3D *pte;
>> =20
>>      dma_set_pte_addr(new, mfn_to_maddr(mfn));
>>      dma_set_pte_prot(new,
>>                       ((flags & IOMMUF_readable) ? DMA_PTE_READ  : 0) |
>>                       ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0));
>> +    if ( IOMMUF_order(flags) )
>=20
> You seem to use level > 1 in other places to check for whether the
> entry is intended to be a super-page. Is there any reason to use
> IOMMUF_order here instead?

"flags" is the original source of information here, so it seemed more
natural to use it. The following hunk uses "level > 1" to better
match the similar unmap logic as well as AMD code. Maybe I should
change those to also use "flags" (or "order" in the unmap case), as
that would allow re-using the local variable in the new patches in v3
doing the re-coalescing of present superpages (right now I'm using a
second, not very nicely named variable there).

I'll have to think about this some and check whether there are other
issues if I made such a change.

>> @@ -2328,6 +2361,11 @@ static int __init vtd_setup(void)
>>                 cap_sps_2mb(iommu->cap) ? ", 2MB" : "",
>>                 cap_sps_1gb(iommu->cap) ? ", 1GB" : "");
>> =20
>> +        if ( !cap_sps_2mb(iommu->cap) )
>> +            large_sizes &=3D ~PAGE_SIZE_2M;
>> +        if ( !cap_sps_1gb(iommu->cap) )
>> +            large_sizes &=3D ~PAGE_SIZE_1G;
>> +
>>  #ifndef iommu_snoop
>>          if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) )
>>              iommu_snoop =3D false;
>> @@ -2399,6 +2437,9 @@ static int __init vtd_setup(void)
>>      if ( ret )
>>          goto error;
>> =20
>> +    ASSERT(iommu_ops.page_sizes & PAGE_SIZE_4K);
>=20
> Since you are adding the assert, it might be more complete to check no
> other page sizes are set, iommu_ops.page_sizes =3D=3D PAGE_SIZE_4K?

Ah yes, would make sense. Let me change this.

Jan



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:46:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:46:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246061.424416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlfE-0008In-Gt; Mon, 13 Dec 2021 13:46:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246061.424416; Mon, 13 Dec 2021 13:46:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlfE-0008Ig-E2; Mon, 13 Dec 2021 13:46:48 +0000
Received: by outflank-mailman (input) for mailman id 246061;
 Mon, 13 Dec 2021 13:46:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=TJ+9=Q6=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1mwlfC-0008Ia-Qu
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:46:46 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1b982ca4-5c1b-11ec-b442-ab1a14567e0c;
 Mon, 13 Dec 2021 14:46:44 +0100 (CET)
Received: from pps.filterd (m0246632.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BDBRDIG026927; 
 Mon, 13 Dec 2021 13:46:39 GMT
Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cx5ak895h-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 13 Dec 2021 13:46:39 +0000
Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1])
 by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BDDflwA087802;
 Mon, 13 Dec 2021 13:46:38 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109])
 by aserp3030.oracle.com with ESMTP id 3cvj1c9xvc-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Mon, 13 Dec 2021 13:46:38 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB2785.namprd10.prod.outlook.com (2603:10b6:208:73::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Mon, 13 Dec
 2021 13:46:36 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4778.018; Mon, 13 Dec 2021
 13:46:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b982ca4-5c1b-11ec-b442-ab1a14567e0c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=xABObrLcZa46vsqfgUDXjHQL8uUQc1toHRg3k3cX1JQ=;
 b=PARiGgm+UTyImXn162iUmczZCuTWHqG3z/kJavQLoheI+2pNnXUJVir4RdJp64wCUhbO
 KzEaR0m0HS+v4UTwC+ShkTBxC+9RReOrtB/F8Q0ihpubQIw36J7gq08fk2eZak/89IUI
 x57ATxc/6JSbqtX+rtfo0ctt6BaQszZ4kump3o386IKvyvUxB+yVQ66ACf9NpH77tvsx
 p20G0IJQ1J8rRfcoqMLLsHcfamXETFYdqfQxAgXLwuafAJNBZ41kbNOUyTdyKXTGyZWR
 D30pXGny5trx4TqhmPDiMNJlaC9XLODT46i/GdddR9gmUWgKC0ptdg7DRefsvvPp6JGK bA== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Nqaj67qQ1UD7j+dIabI8dgkq9AgjaOIvz4vbLbDkPfIGsuDDjSdDr6wTBKYGinR1pOKT0M1WMD3yJ2HhhPYhtIVtOV0o/yCkmutVvEyDyqYxRszt6/MPyOms1Y5097RxkRSzgyjqglFBZIRWK7b2XINzN/soK0mxYSrwdQGgdxCqR9UiRIk/HiR6HJOazdmfV8gJfOzg62mew2VnzSCElQgHg5j2Qx/CEU2mkDW1u2RaV7rJJP5x9/1wH/RRpnIAgq3rDvFIfmRRZRrjr8G/ubHBuoCyfQlRHSL2fNjPYYs/CUVEuds3Du5n+zXoJmodsX/jFl1FcJ0awy0KXAAPxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xABObrLcZa46vsqfgUDXjHQL8uUQc1toHRg3k3cX1JQ=;
 b=DLk05DlmvY0TCjn8IhcZCfBDK54pLL5ukGBKtCoRdlW4Oq1fOl3zSC8C3xdVVX5s0N8WAZb5CwL5QmDu9zqHzdNUA5zS2MjkDE0hN90O/x/87gHBjF/ZbmlM6dAw0AgOdVvc0TiGQ3iZ3iV1HX/bAIaBvVrM6Mqi5ZP7SXYVGk5CcrB9VhkrfEh1Eare9xdIDPbLyb8haSn/VzSQGQOmQKqnDgTL3v2hW9tGQ9KDDqWxsI/784957Gz3Bm7IT8BPEb1PuNPo+Pa9BBOKPgzCjEppJmD+PuZE4ccM5ujDq2H6+HIkgZXk+JmYggcwGbQNFx2jEeYVU/PwxnqTJu66Vw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xABObrLcZa46vsqfgUDXjHQL8uUQc1toHRg3k3cX1JQ=;
 b=hTJKyOY+1Qnq7UnwEUAYjbcYWgvgyn2MkdHh4kPV2GFPzR6C/TWU5rnjcgvvxFo85QSOb9THi5yDVr+7pvQWiNF8ZgXbMxYYJAQrimlL2WEjPaf79ESc5iVidAj2s5O6ebv2E2XLokKoeeEl9Obs/QqIXU+ky8mpIjneDi4i5C0=
Message-ID: <c59fa2ee-f22e-eff6-8a4e-0f8ac3981f07@oracle.com>
Date: Mon, 13 Dec 2021 08:46:31 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/gntdev: fix unmap notification order
Content-Language: en-US
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: jgross@suse.com, sstabellini@kernel.org,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        stable@vger.kernel.org
References: <20211210092817.580718-1-andr2000@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20211210092817.580718-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9P221CA0023.NAMP221.PROD.OUTLOOK.COM
 (2603:10b6:806:25::28) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d178a71e-a388-45ae-7ada-08d9be3efb79
X-MS-TrafficTypeDiagnostic: BL0PR10MB2785:EE_
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB2785B5CC920B64E6FD6315A48A749@BL0PR10MB2785.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	4mOVuPMskdpuj/ebFYElwyXq9dBPpJ2xZ2SZA7xRHc4Dqk20fyuldM5cQ74Zkz8XetuexS+J5d5W7jQiOoM3VqpOKOgqP5ZMvxQ7IX6vRBS0d9r4/m08jF+SwCnTJYVg76XrNrndNZBtIPbE4ClB+l9ttFlQUqiWK7XlDhYKidvT10zFEhy9KxxLeJeROt3J+uTq7PCBB/Hr6Krvyedasz6+su0GgFSz/0yt+ranZ7OSxl9RuWDGBQALljuZtU0Vfz5a9NUlx3ccofmhhapcUOU//3fgNqiD2igwmRTOXK8OADGEU7YfvYm27zQDNibDbaoWpzPkml7G4R2pXVksTK8+iqn4IN9lmX5DLiHuu6DIF1e3BakKFFQjKrHjS89qKGwynSYu3ogdAFRta67+pTcFRAeDJ4FURhQi4A/oFg8aBVL6i7BouE6LcrSeYAv/cUErPhil8eqVchoE3mtqNISTguhyCz9LX1SGZ+uwq8EMzc1xY00NsR2yVW7Vr5xzUt8hzyqAS1rC8/S0Op/n6SLAnxXeD2lKYi8ZVQgE+0LZqmT1+tbpdeKN3e04g5/hm1uJVmRUukGwsuVltzwjvOp9vCC4tn0e81oaLX4dckqkgCrtxyrZtfVpWFKqYsWxOVUiZNncD5Z54x65s765TzDAwEobYIqYrQwNBOmPIv/91+OvP7neVtx1WrBHB1gKO4Hm+jUjbtLD6DuHGu5WWU9kDlNugveQU7sQFGgIJr6JW4YUBv+RCzO9SDcUleDy
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66556008)(15650500001)(38100700002)(186003)(31686004)(316002)(8676002)(36756003)(66946007)(6486002)(26005)(5660300002)(86362001)(2906002)(6666004)(44832011)(508600001)(8936002)(2616005)(6512007)(31696002)(4326008)(83380400001)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RlJYMjhlUHN2d29UQXFobytpb3F1REVESm5lbk1jUFB2cU8zWkE1TjU2ZzdU?=
 =?utf-8?B?aEhsR0VmbkVrSkpwbUh2ZlhGb3dEUEFmR3lmcjVaTWdHSjB4RXpnck82NTMx?=
 =?utf-8?B?TVpUUG5ranhqNnoyWVBRNzBCR3pmcDZIL0JzeHdqa1VBRE1VVkRmZUZEYXYx?=
 =?utf-8?B?c3lxUFFnRjJLU2VkcSs1QXh0ZXQ2eTkvR3hrMm91OGd3VVl6R1pRSm80ZkNL?=
 =?utf-8?B?aEFMamVwUmhieWtkVjJBUVROMVFOUTMzZ2tndkxUTmRzeDNMaXIzajhEMXJu?=
 =?utf-8?B?R0c3UWt4VVpPMnlISDZ6aHdlV3dtc1VWZlkxYzRaQ0xQNVdCazlrYlY5UnBB?=
 =?utf-8?B?S3J0b1ZlUzdCNE5FVmJhYVFVYVdDOStlU2tHOVpWYlpTUU9iZHpYalgvcmJO?=
 =?utf-8?B?VFlXUmFnbTYyT1ZFblZJRGt3WjRKSWJwSGFIYWNCUFJPaVlRVjlhM0lub3Vm?=
 =?utf-8?B?UVVUaFlwTHVnQUJXNXYxVFBkODZ0M3Nod3BDdFo2enNWYUNLZmU2UEZzUE5k?=
 =?utf-8?B?OWRiWXpzNFRZRWpnYk5jbHNzek0zZUZCdjArWTBiUWdpTHc1Yzl4TUI4N2VC?=
 =?utf-8?B?eHJmY3ZsSkpwSEZwN1gxOGZtT3A3Z0xralBQV1oybVZ2Q1JSNUxOL2J6ZmRk?=
 =?utf-8?B?RjJyRENCNEtvYzE5U3grNnJVQi91SG1ta3I3MTJ2MXpJVE0wT3hqVE1aRnRa?=
 =?utf-8?B?TUhlbDNsVmJaa1l5VmZBOGdYQ2FFbHRPOEdiZEU0WHZReFBsZiszSUxHVkFq?=
 =?utf-8?B?UmpsalYvdE14cTFCNFFXNzVQZDljejZXbUJSaHVsYTVEMEl2OWN3ZnNyVlB4?=
 =?utf-8?B?dDhZTDZZZXpIVk9aZ0lCSHdpQXBQS0UyNG0zUG5oTlYzRWMyeURERzJQT2JX?=
 =?utf-8?B?cjA5T1cyZTROTmljYnlqVlh1OTIyQ1dhV0NmMndYVitGakZGVjhkRmRBT21O?=
 =?utf-8?B?Y2tiOEJxOFZkNVZHZUE5aGIwZ1NyTTBVdWU5dVNVRFg1L3p0OTZoaTZhOGFJ?=
 =?utf-8?B?WU0rOVhZNEU3Qks1UXQxT0VRbGRMY2IrS2NYMHcyRmV6Qkc4bHBUMlBkSHlU?=
 =?utf-8?B?V0VYQXE2WktMQ0hveXhHUEF3TWYvWllsYTFURk91bU9QaFZKNHQzK045LzRx?=
 =?utf-8?B?dUJqclVsd1A2Uko3UmFaaHhiMVd5VzdoekVxb3I4M3NGRmd6cDlxMmdEaFJV?=
 =?utf-8?B?SzJKZ2NNREcyNUwvQkVCNU5NczVaOFNnLzYxZmU1dE94Ti9JRSthRUF0TXhD?=
 =?utf-8?B?eDIzTHQwNkdXVWtLZFFUbDY5d2M1ZTR6TE9IbEw3ZDVJTHZUc0NKRlJtTUR3?=
 =?utf-8?B?bHkzRmJtNlRIbVFpZ0RqekZadGovcTZOMnZ4Yk1JUDlJRER2a0wxL2NSeFdR?=
 =?utf-8?B?aDE2N2tJUlRMUFVmcFZadWpCQU9KT0FhMElUUklLYUhnOXZLa2w4QXNDc2hX?=
 =?utf-8?B?dTlidkszR1ZQMitab05ib1lCTGhDWDhmRVc3U2tNOGs0NXJoTnpCaEpDc0Y4?=
 =?utf-8?B?RFNCbmFlRG9PWmJEUkdvb0tiK1hCd2gxOTh2MXh5L1MxYzNXT2crSXNOOEZB?=
 =?utf-8?B?bkx3QVV4bll1Yi9HTjRZdHFNTHpnRDljTFRxS3JWZmFJYnNnall0RUtuQ0lx?=
 =?utf-8?B?YTlsRHZHd2Npb0Q0UVRTUG9qa1J2ekFXblVsRlhvTWczOVV4SU5objBVMnFS?=
 =?utf-8?B?dkZTMEZSTVdzd2RGVVVFQzdvaU94OHFTMzZPdXQ1Z1hrOHdmRmd2SlRiWEZw?=
 =?utf-8?B?dmtkRjdjVDZYYS9vTElEWSs5NW1DbFFjZGJzencxOFoyaVRCazNhMlBCZFhh?=
 =?utf-8?B?REQwZlBOVS9hRGFRMmhJd2hieVZnc09Wcjl0M0pZdGo5c3R5aWQrM1ZhZjBD?=
 =?utf-8?B?UWFUeVN5RUYxU2p6bjBKUytYQ21RSS80OHkrUFUzSjYxRVpSdUN5UURVQXZT?=
 =?utf-8?B?R0NwcUVhOXVyRkpEemJVNWpUQ0dieGJ1MEQzeGlRY2wwQ3ZFM1A4UFNLS3U1?=
 =?utf-8?B?WXpGK21GMDIyaHp4dGJnS0tiemQvRUx3dXp0UG9pNVErb2Fpb01zYnhWVkNt?=
 =?utf-8?B?ejJscm9XUGZzcGlRVUZvMEc4S1IvR2Z0OXpHMzhTczg3V2VvSkxjVVE2WUNG?=
 =?utf-8?B?bGNQMWJzVmdDNS9vTkZqcGJoQlByMFNOQ0xuM2dHSkVqMGp0MDllZHJXV3VK?=
 =?utf-8?B?bVpFbUN1bER2OGFSdWpiVFlIbXJkWFVZZDdQZms5eUJoL0ZPZjhMVTlwSjRV?=
 =?utf-8?B?dG9mR09xZ0NRY3VSd3Y0bFIrZEtBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d178a71e-a388-45ae-7ada-08d9be3efb79
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:46:36.7680
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bngYBodl0HZeuw984MCyTqmH/Be8PdJ6GlFFMjsy/7wke280LpuPTXa1K+BPyDQBTeXSOVm8Rmj8I1lWlsZazLMKo2yxvcUr9cf/e6d8iOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2785
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10196 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112130087
X-Proofpoint-GUID: 1SbUEeN1LtsQLUajcInKZNXiYA30yCZr
X-Proofpoint-ORIG-GUID: 1SbUEeN1LtsQLUajcInKZNXiYA30yCZr


On 12/10/21 4:28 AM, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> While working with Xen's libxenvchan library I have faced an issue with
> unmap notifications sent in wrong order if both UNMAP_NOTIFY_SEND_EVENT
> and UNMAP_NOTIFY_CLEAR_BYTE were requested: first we send an event channel
> notification and then clear the notification byte which renders in the below
> inconsistency (cli_live is the byte which was requested to be cleared on unmap):
>
> [  444.514243] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 1
> [  444.515239] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
>
> Thus it is not possible to reliably implement the checks like
> - wait for the notification (UNMAP_NOTIFY_SEND_EVENT)
> - check the variable (UNMAP_NOTIFY_CLEAR_BYTE)
> because it is possible that the variable gets checked before it is cleared
> by the kernel.
>
> To fix that we need to re-order the notifications, so the variable is first
> gets cleared and then the event channel notification is sent.
> With this fix I can see the correct order of execution:
>
> [   54.522611] __unmap_grant_pages UNMAP_NOTIFY_CLEAR_BYTE at 14
> [   54.537966] gntdev_put_map UNMAP_NOTIFY_SEND_EVENT map->notify.event 6
> libxenvchan_is_open cli_live 0
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>



Applied to for-linus-5.16c


-boris



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:57:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:57:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246072.424428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlos-0001WI-M6; Mon, 13 Dec 2021 13:56:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246072.424428; Mon, 13 Dec 2021 13:56:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlos-0001WB-JD; Mon, 13 Dec 2021 13:56:46 +0000
Received: by outflank-mailman (input) for mailman id 246072;
 Mon, 13 Dec 2021 13:56:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlor-0001W5-GY
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:56:45 +0000
Received: from NAM12-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam12on20615.outbound.protection.outlook.com
 [2a01:111:f400:fe59::615])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 80ec52d3-5c1c-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 14:56:44 +0100 (CET)
Received: from BL1PR12MB5320.namprd12.prod.outlook.com (2603:10b6:208:314::17)
 by BL0PR12MB5554.namprd12.prod.outlook.com (2603:10b6:208:1cd::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Mon, 13 Dec
 2021 13:56:42 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5320.namprd12.prod.outlook.com (2603:10b6:208:314::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Mon, 13 Dec
 2021 13:56:41 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 13:56:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 80ec52d3-5c1c-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ld0rKPw9tZPYs+r5G5TLA01uesOR88gj2HAnb/t5zkqUQnn6jp55UspIoHbKi0uZy+uR1Eg2qcDCMab8Rg9l/TyMLKna9DV9nBYURnB7K/dAw24dvrSfRlLbYciXuZ+8nnJJbEkO6H3mT90vwi665TM8QGcWBfndPXyapWyrNKKrK+382gC4/jicTa543Pv3dYTAJQ3Lxzoxeev3fPZjXQvb5IY8VmIBc0DjZ2J6jzu/g9A+b4XcVmkglRrLH16S3XD8C6/SnN4XbZI+jihNlrvX1If5Q+vr5oLRyKGE9jRTrDACcydm62bNsp847slknE/mDTt8r6NbaUfK4VFpgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tSehdxNdqx2MtdTA5M2MuLCrmulXs0XzDuCUokkinNU=;
 b=a4zg3vKC450qGa4mfBief73BxT9SuQT7Vh1wPY6pVmCruTw4eDhOauiLidEcAeDpQfk9OZTE5o1Sic9kjCmlHvkVbzMYSA4NFV38VaRCLE725lSMEhIvoy6QzryCryIRKCc7E226eCl0BQYjSs8q72OAzzN7mnLV2HUx3ygGOhqdmy8BCGJQhzOjIbBFi3ICWBuBzpd13PJOUXgb6CWSglcjWF70mHZ08IRppCh2aNB5Q9rDvHqOenuErlBvaeOoYzMThXwIw2frjRnwg174WwqOM2uSqlTUw4RDO5pRf7lvfw4BXI/X85uzi0KAZ7xayebF5ASN/CYPbUPy77btLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tSehdxNdqx2MtdTA5M2MuLCrmulXs0XzDuCUokkinNU=;
 b=fG7MXliXzDVYX0utMHDNe3vk4oW2wFzYpuFQiOeT3Ik5Fwg4hDxiZjCnAVdtkvNZY0pgVlAXmZWITzV/u9HICTDAIOqMxLHfivRkjt1RQdF/Rb7vV1sfjMEDuIv5KfMAOJWLjbH/tW3AEd6ct37nZiXBadl/p1C/Ju/9D+qt8iPHq8J7D4lfSVaAImtFdKb4qV7rO4coWkmN0ze8ybsLlnolEJZAFKdS2FcamAzm6+uqgIPWWx9L9CI+CIBPZTcCMWIlYWP6/5s8hsnEHwFzCC6xnLILBci0hf5CN6IuNmAZfmqOJ9FSbppM+cBmS9J4gHcWkNjPB9ct4X6CgMoW0Q==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 09:56:39 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 02/35] x86/pci/XEN: Use PCI device property
Message-ID: <20211213135639.GV6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.311410967@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.311410967@linutronix.de>
X-ClientProxiedBy: CH2PR19CA0012.namprd19.prod.outlook.com
 (2603:10b6:610:4d::22) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4c4b2b35-d962-406d-512d-08d9be4063bf
X-MS-TrafficTypeDiagnostic: BL1PR12MB5320:EE_|BL0PR12MB5554:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB53209226BB84D421DB84A8B1C2749@BL1PR12MB5320.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:663;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IWe4RjLZTwtKiNuP5MtIWhuAZ3/8aNzaaj2HyHnRf5fS/YcJG7gxWQswTyNylLStRxShl/pH5ign1QSirSmXkVpAFO3aTVEYRovDoOtA4L+o3PCNOgxryhdvr8+c4NddB8uGCUgDQAxq5wUVxvy2+KWIMIXZdPoDDEINj8LLaEa9kJo/mSRV3mdIDBszhuGtvE8FsYVUUlrOgYSEBTuu4y2l+m/zS7sufoSBJjSwcmSyuMr+7eQBKyvQj5ZQCWfFdCEFl7hVahLhfqa/9G6ulafc0R3fJjpWQ7xzNfcXIO8DeG7mGTaT/JVKvbEtxT4oAAGTDbBCNlswu88U/8cUkGsnKt91vlcSpK+iC6Z43zX3PXEW7MWqIgyjTB8GgmgUPAdaiXXQEGNfUx07RpN+Adi10jZBf37OJJUncb+wxhb2nUmblU5hXJT+iVjisyCx9LywMDW0oy6g9Pg7VnHYsyi1e9OMWofgsVJXWxGatrF5WtnvpINVpyTh7HtEOYfo4sUrQmCVUslJZBqeQmDS3UGe8Gp1IxY7sGSNFFXkkE28LxtXtN7gpWYo0NdDG1YxxMPj+5WobMnGBh6cfmV4ijgwAlKrKa/+LCyS8KObm7U73joX6OfLFr9L0QDRku02uIWPJSnULqjZFj0XoUi6tg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(26005)(2616005)(6486002)(7406005)(508600001)(36756003)(83380400001)(6916009)(6512007)(316002)(5660300002)(66556008)(4326008)(4744005)(66946007)(86362001)(186003)(66476007)(54906003)(8936002)(8676002)(2906002)(33656002)(1076003)(6506007)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1n4rmLls89NyHwVi0ELhP/iPBMAGLXsM1ys+DCZUiO88alDNgg8f7iYYuiLW?=
 =?us-ascii?Q?T29FweIozJyVVizS6BS1+cdznNiM+d2pzAfORA2tKNa/W3Cf5g2Z0IYCKYb7?=
 =?us-ascii?Q?768e7ZAdx36XW68AAlkkp1l96G0Jnmh8UexCSb12UJZEsjomfs2tZ8wa7bWL?=
 =?us-ascii?Q?JO5yYnRqngI6tB1E42+ttAfL57jiGOE7++mycEeW40XEl2wiM1C9VDKpuukW?=
 =?us-ascii?Q?wiAdhdKJ95FzvtHRiWdAtDfnCU3XVM9QwlHTl4szBxANi2HTP5YPJzFsrgd2?=
 =?us-ascii?Q?81KfLRQAUEXI7F51Q6sJ2nPRaPdYFymjL31Ge/OaeOz5riuuofa7EwjjacmP?=
 =?us-ascii?Q?FtGuE8cWgr0fz7MXg/mLAsx3DCb3Z3ZkSj3sE28yfjccnmuT86qcKn/et7AC?=
 =?us-ascii?Q?R2fIiOJHf+z/9sNxeAwZsj6sGQ4x22NUO+Mr1rA0Fsvk+S2mr/XCiaNHwKWs?=
 =?us-ascii?Q?vfrYsO90QauqY9t3YZ2H3e2vCRyMF+fwmuiVq0GDOD9t+6UsA5hRbNsbz8TM?=
 =?us-ascii?Q?vv4GKTqKX5Itnx4nE1BuicBNMOsAE6qwE6T8b/2gM5rNqH8Pdv3jg2K/IcMA?=
 =?us-ascii?Q?cdO9eEIX2A2VvpipD+j3VfPG1LuG3CjilxH9cqEyCXrMJ4aGmThvHq0I/kxb?=
 =?us-ascii?Q?BvMDVDKmd+mv7WTuQvLJpyJMYIrA/Tet0ZbMPTd6x//fw+JvghgSKzjqDegz?=
 =?us-ascii?Q?FA0gF7OTI73fUU+J+YlghirK0UFDvwnSmjkEm2zs4nd4mPjdoR6dxVE2q531?=
 =?us-ascii?Q?ScubPtVV9Uvr17xetzr1VaEenSOf6y1+m5BI5ZWYg5QUQ7Et16TMoev4ORxY?=
 =?us-ascii?Q?M19L1xYlqFOIrJ5dv7jVcCbg8shAmr5xrF7iW88Hpwi5PWQhZMAMkWXcgtRy?=
 =?us-ascii?Q?1jbBVNEBIkohBF3tkVX64cDX/MmhYZLUI+RMw2lV1KTDCUzKvWZH0ifUrgq7?=
 =?us-ascii?Q?KosV10xWOHp7M6BeNUcDbIQ89uc6YkZl3sk0bI/3kkUkKI10lxmlY6xuliEb?=
 =?us-ascii?Q?sHrvp+ie1sJp3mFetdGYiBcl7aywpVVk0h7D22Nah9K40v4BeMfMa6U2iRSb?=
 =?us-ascii?Q?ykdjlN7zsnoEjxDVT1zl24kq9ZbcyizQOh7TmJYezdtQbpR4OqmJalQXHwak?=
 =?us-ascii?Q?ia2X64lMS9Q4J7NDTx+7JhGRCfQqPLTgXABdEbyptjBEceZBoTTZOvK/vr8U?=
 =?us-ascii?Q?xg6EHCH/DYOiWEG0L9ojOpAZbPEZhnB8fIsC6LsFzlERXjCvccUPbLAV9s1M?=
 =?us-ascii?Q?W1OtX8gyKUxPyVYjP2paNeG8SRCuK30NXHVtyfJXN47+zy4j6PdcO0f8cV7f?=
 =?us-ascii?Q?fm2ULMWMPq2BYEBGRc9/RttRzX0yTOilyj+/nufS9nnaEN+ZQztapDbB8IAb?=
 =?us-ascii?Q?MQFBUIVwg1bF3r+iDP3tMHmM3aQOPWdL4hGhaaZVyFunYe2auhiC3L+84NC9?=
 =?us-ascii?Q?DyJ0IE5og7lTca4IIU+QSVqDp1z1utOIc0+w9OdQYra16cjV5+3PinfaWfCL?=
 =?us-ascii?Q?099c9Y7wnj6ii++Mi1cHarMyliG9jrHPZrzoXJgtodVssmAZwMgY3WaqtGa1?=
 =?us-ascii?Q?kcoZ6ygcR2W59BZElnY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c4b2b35-d962-406d-512d-08d9be4063bf
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:56:41.3583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gbwMOLVX2pyNkKO7Ti7Ng69tK3CWicOz9MbSuKwTf2fh8sS0f7ikzwXSdnGFz6NS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5554

On Fri, Dec 10, 2021 at 11:18:46PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: xen-devel@lists.xenproject.org
> ---
> V3: Use pci_dev->msix_enabled.
> ---
>  arch/x86/pci/xen.c |    9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:58:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:58:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246077.424439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlqt-00027f-1a; Mon, 13 Dec 2021 13:58:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246077.424439; Mon, 13 Dec 2021 13:58:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlqs-00027Y-Uw; Mon, 13 Dec 2021 13:58:50 +0000
Received: by outflank-mailman (input) for mailman id 246077;
 Mon, 13 Dec 2021 13:58:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SshG=Q6=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1mwlqr-00027Q-MI
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:58:49 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cad679b2-5c1c-11ec-b442-ab1a14567e0c;
 Mon, 13 Dec 2021 14:58:47 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 74B75B80EC1;
 Mon, 13 Dec 2021 13:58:46 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD12CC34601;
 Mon, 13 Dec 2021 13:58:44 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cad679b2-5c1c-11ec-b442-ab1a14567e0c
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1639403925;
	bh=yMuVyc4TVgRet2InLRY+bgIaO+2h9DW64nLLI7Las+0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Bkwud4Z4Makhy+9ZYkFe66k9/JDAvnckgNmbHULq1ycFzFIL7Of5hGfSWm1WDtcfk
	 y2GcLA4riMUt9lyo78RXKGWbBgeEd4qd0YWMCz83/JVYkGVfB9Wal86I7MCdRXBQe8
	 5FtwgpWM99YsYiZ5zl/bg7IgkRhFUNse+WsdDFho=
Date: Mon, 13 Dec 2021 14:58:42 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/3] usb: Introduce Xen pvUSB frontend (xen hcd)
Message-ID: <YbdRkvW/hOH77liY@kroah.com>
References: <20211123132048.5335-1-jgross@suse.com>
 <20211123132048.5335-3-jgross@suse.com>
 <YaoSTnkYyCFXOyvJ@kroah.com>
 <b43c416e-d81a-7d21-5b92-7bc8329bb296@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b43c416e-d81a-7d21-5b92-7bc8329bb296@suse.com>

On Fri, Dec 03, 2021 at 01:50:44PM +0100, Juergen Gross wrote:
> On 03.12.21 13:49, Greg Kroah-Hartman wrote:
> > On Tue, Nov 23, 2021 at 02:20:47PM +0100, Juergen Gross wrote:
> > > Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen
> > > domU to communicate with a USB device assigned to that domU. The
> > > communication is all done via the pvUSB backend in a driver domain
> > > (usually Dom0) which is owner of the physical device.
> > > 
> > > The pvUSB frontend is a USB hcd for a virtual USB host connector.
> > > 
> > > The code is taken from the pvUSB implementation in Xen done by Fujitsu
> > > based on Linux kernel 2.6.18.
> > > 
> > > Changes from the original version are:
> > > - port to upstream kernel
> > > - put all code in just one source file
> > > - move module to appropriate location in kernel tree
> > > - adapt to Linux style guide
> > > - minor code modifications to increase readability
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > ---
> > >   drivers/usb/host/Kconfig   |   11 +
> > >   drivers/usb/host/Makefile  |    1 +
> > >   drivers/usb/host/xen-hcd.c | 1606 ++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 1618 insertions(+)
> > >   create mode 100644 drivers/usb/host/xen-hcd.c
> > 
> > This looks sane to me, but I don't know the HCD interface as well as
> > others on linux-usb do, like Alan Stern.
> > 
> > What tree do you want this to be merged through, my USB one?
> 
> Either that, or I can carry it through the Xen tree.
> 
> Its your choice. :-)

I've grabbed them now, thanks.

greg k-h


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:59:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:59:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246082.424450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlrj-0002qa-Ak; Mon, 13 Dec 2021 13:59:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246082.424450; Mon, 13 Dec 2021 13:59:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlrj-0002qT-7n; Mon, 13 Dec 2021 13:59:43 +0000
Received: by outflank-mailman (input) for mailman id 246082;
 Mon, 13 Dec 2021 13:59:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlri-0002pX-Pp
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:59:42 +0000
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam07on20623.outbound.protection.outlook.com
 [2a01:111:f400:7e83::623])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea7fc9bc-5c1c-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 14:59:42 +0100 (CET)
Received: from BL1PR12MB5205.namprd12.prod.outlook.com (2603:10b6:208:308::17)
 by BL1PR12MB5285.namprd12.prod.outlook.com (2603:10b6:208:31f::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Mon, 13 Dec
 2021 13:59:38 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5205.namprd12.prod.outlook.com (2603:10b6:208:308::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 13:59:38 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 13:59:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea7fc9bc-5c1c-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=f9OlWw2GhPqNSQJC1+7SFURj10H/SaEoeBwPx3U1SbetkJTi3blhTOixg91prXOUvjLsYHZVPO98pCjlDJOydcO71yP6i2Ph17ovsOd1smAhZqs7dU5smeub2XyG+/SHPvAK8JcHg5B7pNFLpH67HQPOYvQu6vEpjpd3aVfnl2Diewvd4R/jhhzzBnGBoNzM8/2gpHIt1BF5SD7V15QuclI1skV7QE16vHW7JTB3iGih+vrwn8IhhkPODHztYQ6gJZ8sRkS+0zJVg88HRM3aCYmKVslzB5ic9HgFkkmOpdb7nc41S08cjB24YGyt8oImWrCgibndNQvh3Db9Dj+28g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4e1muZdaW+9bbvoI9sSBMtzRvLQLs2XEAcTxsebVYDQ=;
 b=hSbBAzdsUSkBO3CRzP9Q10aDYMfCLyEIQufaflrOrkqTgGlLeEIDLM7rI5z7J6ys5WlgSC8ZBmm0uXMz/xcWpNqpdMRz1HHyVPX+KwDoQ15b+OGhfAbx1qQSeX7sK7kkZW2zx+gsQ30Coy0ZgTuU9zYmH9HL7whk2kRTgQ1YufxvraX6BBtdEYkkhcrFLkS1E36aSr+1tQYrKy/WQ4BQOy3Up9BKWwwqm8w8TlVOe049c0j36KCq4HQu8Y/Y/+mZxklP91fBpdSzJpEOmBZoXfvSWH+G9m/+CgZv1uqhKewpYPJ8Yg/D/7CyW8hM2YtyKKjeMiLugNAhZbFwJcnrjg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4e1muZdaW+9bbvoI9sSBMtzRvLQLs2XEAcTxsebVYDQ=;
 b=E54ZAdvk9kS59/3FBj+5nHzSgxOk5tk58o8S8xmIISrWQRh8WMTJ0Ia0w7Ec/gWXbubm+TtjWkoJGbt8VFMyOjFK9hxOuFt5XgzkTxEXz/XxgBzFNKzaRTlOZsEhfYYM0CZjoERIE9wHUc0sT/bc/PMEVVgGlRZLE3odY/9ZJNFQZuotgatxf5dlkNibo2L7U5+3ME9RA9O4jL+YDznK5IgOA8ur9/E82GKLTzWmbBTlzmLo/R8cVDxbr/y9FKMawiQtwl5H/GKlCVBq4Uqr9lUEeb4p6uPzkHZv0uIu9FBAQm/KeCLaB01UtKKFCaFq8jM2I3WY87rpZQvhsY6j9w==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 09:59:20 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 03/35] x86/apic/msi: Use PCI device MSI property
Message-ID: <20211213135920.GW6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.372357371@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.372357371@linutronix.de>
X-ClientProxiedBy: CH2PR18CA0048.namprd18.prod.outlook.com
 (2603:10b6:610:55::28) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 84173fb8-8889-4548-3026-08d9be40cd26
X-MS-TrafficTypeDiagnostic: BL1PR12MB5205:EE_|BL1PR12MB5285:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB520520644BD8D3760CC48A26C2749@BL1PR12MB5205.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:663;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	+So7GSv8f8tJxYve2FpjA+gybcaaPgw8mG47uB1eju1YyNkuV8V2o7nV9N/ZJKW5L6gAssweGQ8FXJXWh8HNkze4Zb5zXZgDcHODqRkyGN9EmeOBhhyARdYukQeCUn3sfElFAseVlMroEfssaw7BnqwhE4TMRkDRP/Ipp8S5xjC5gUSqaA77CB+6OXsdz+2e5QZRmahE3fivNcpQCIe2WdmI2pA4h6mL2VnAVhITS2tAHbi0mM2YJnT0ukHg5u+SvWb57I9Pl2HIW6cFWnHj3yy/0hdaW6ustrDyQtEAX9MppfMXHKzqVb6bSqpOII35IeYaLIEaRNDy3oVbCiuOQ3M7YIqxze5wKPX8SYZaGPkm7ahX3QRC6xLrD2wQT90i4bQXpN29CaCSRBXifSrpLAscLyb+anqXEUbnae1JqOvozG3z5Hcq+gbN7PEhS3VnC88FIWmYKW7ejEkwfiUQ7eb3DASNFkJC+Cxh1EIdCWK8fQTYECOPb2cB1JVprORrQLafeUTrADqEBqy6cBKjs3AJsW4ItNm26CaRWVqVfuHa8+7cOrBB0PcAqOAdiP0XopChOM5WqnBfKbphgY3/SBiDqjxSOdvoTcqWR+l5piwWjJKs2MqGVf/AS1MZNv9zmmAE1Hxu1V2WoQbN2kvUCQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5205.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(6486002)(6512007)(186003)(66476007)(5660300002)(36756003)(316002)(2616005)(6916009)(8936002)(7406005)(66556008)(6666004)(33656002)(66946007)(4744005)(26005)(2906002)(4326008)(86362001)(83380400001)(38100700002)(54906003)(1076003)(508600001)(8676002)(6506007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?A0+pO1xHbTviYxFv6EFUdG7x7speOn4GgTJc2k3gohJ2gi6Hm8T7f50Z2cij?=
 =?us-ascii?Q?PVeZ1E8cJeaY4m+gtWBc8JvhFQZYJZ8gIPTSCTVAF/edp3ZBRhcyOBZvB8go?=
 =?us-ascii?Q?v66ofCwIgEK+lW1nilwLGMK9SFGLWXEUo5vdfLKNcZVMDXvZKaKW82f8ODcb?=
 =?us-ascii?Q?1GgQD4HpXQM+KDptaOPEPBHpBAjLqW2ItIvjAxN29KprQoD00JezJUncGQvz?=
 =?us-ascii?Q?URtmVFapJh+9b2OdVctGvMk6uqXjPKsz9VqK/8lkbQv+p04L/uCxb0iWTZvD?=
 =?us-ascii?Q?SxOqpX7Zx6fBpR0tzWd3mw11abvl93V9lJfLScKNvGSfXPShHD9862tlDr8g?=
 =?us-ascii?Q?00EDMtDAqy6j7LHRnWEcL63wnAYAVrsdJ1w1YoY3mPZWlqOV5KLU4546nPUD?=
 =?us-ascii?Q?oarB4owRLdLHYNcuR5LD8JFIWJPyICR/swhTapmhkPntN6GIOz2NSOm5QSKG?=
 =?us-ascii?Q?0tdyNeO09KZ3cXDvHry2uh++vibJUlcwFzSpD6p2ms8JzZx68bpXGVenqcq7?=
 =?us-ascii?Q?3R3bDarspCRMHh9SsiAiwvKGohN9/YBEP2UP1O65C5+MROPXMuvGBdNek4aG?=
 =?us-ascii?Q?t704aNo+o9GuNVoi/0LpNjW0D85gCqqyC2Ev2pnwv4WTl3T1cTyeP5Lzug6M?=
 =?us-ascii?Q?ACRg8IcqNLdMzrBmdh1z7NVTuQtNkv6FjoCUdaPpxh1AfTqLfID/NlwT6M3g?=
 =?us-ascii?Q?mGENsXy2NIcpYH7XYS1doNihHh8RzWnEC3f8M0RvKFiQSjvW+fH2ppYGDV+N?=
 =?us-ascii?Q?lzRKE31t2pZLw39XMHshr6YfQgIuFm+rs0k2LPXqdco3Igoa1U5n7ipO4np9?=
 =?us-ascii?Q?ESqMEyZKlMoqIHAhUjSc8ZTJb2Q/EeDVXK9QOLa2bhJsVHnBwoWL0M7SbpD4?=
 =?us-ascii?Q?Jty8rYxshTtlbRot7qafDWWgXUM22T1ulZJ/RftsXFgfPFhP29PoWx/3N9Bu?=
 =?us-ascii?Q?5Ww/KsY07dghI19EpyQbRaZlW/nGwPCxI04MbFCzXQqUYkOrPfynThvZ9RNq?=
 =?us-ascii?Q?oC30y9TPAXVOIZoQg/F5ZDQ2Kt6hxAsrcUypSD7IS3qo2ZyxnUJ/tH7Sbzmg?=
 =?us-ascii?Q?5C97dNpm521/Lf0D0eyO/p6A1OiWbYNrnYuJJe9P8Fa3dSxrWlfxXdaENyLJ?=
 =?us-ascii?Q?G2c/A2tAEPetiFi9997XwRGtGrJZrBohhCBPfGnUrotmVCsayFuSbo9a0Omu?=
 =?us-ascii?Q?gECSDv4+d0zLlGzfXWDuzDgQk2+R/gtK3CVSs0F3mRfXAhIZuomkhwWUUOzu?=
 =?us-ascii?Q?vhYQIsKA22sopzSh+coRjz1imWb7plAUAfhfAL0x1h0eQni3w/zeeOm8VUB8?=
 =?us-ascii?Q?bwTSGIhYOv6/OO+Xumaavq3uXruwkVx3/U2KDEvppEFXM8HX62XoGHTg+uuu?=
 =?us-ascii?Q?227+EvHSt0NwPJTkPInxk3FDzDPqffa/7rKchTAoeYqqNAddJuPBCqv6DRTi?=
 =?us-ascii?Q?QinN6YhZbR+fYFEaqQ0ibdJUE4nwxGewjm+m5lYJNRS8mRJaMA6KRUd3uPMX?=
 =?us-ascii?Q?YiY/6fQ9OZ4pGclUWTR/OtwtssP1/CSOyiybiZhhgjjTUcvZj95+ZY5MudyA?=
 =?us-ascii?Q?ewQMl8OSXu+k3Is1qsg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84173fb8-8889-4548-3026-08d9be40cd26
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:59:38.0214
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +xbanXIkeWgWqW/UkwOL67cBY0Ay/mMZIJa2IiPRUtINVksIlOC1BvOemKxiVdU2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5285

On Fri, Dec 10, 2021 at 11:18:47PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V3: Use pci_dev->msix_enabled - Jason
> ---
>  arch/x86/kernel/apic/msi.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 13:59:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 13:59:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246083.424461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlrs-0003Bk-OL; Mon, 13 Dec 2021 13:59:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246083.424461; Mon, 13 Dec 2021 13:59:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlrs-0003Bd-K3; Mon, 13 Dec 2021 13:59:52 +0000
Received: by outflank-mailman (input) for mailman id 246083;
 Mon, 13 Dec 2021 13:59:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlrq-0002pX-Vr
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 13:59:51 +0000
Received: from NAM10-DM6-obe.outbound.protection.outlook.com
 (mail-dm6nam10on20627.outbound.protection.outlook.com
 [2a01:111:f400:7e88::627])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ef7cd618-5c1c-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 14:59:50 +0100 (CET)
Received: from BL1PR12MB5047.namprd12.prod.outlook.com (2603:10b6:208:31a::6)
 by BL1PR12MB5255.namprd12.prod.outlook.com (2603:10b6:208:315::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 13:59:47 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5047.namprd12.prod.outlook.com (2603:10b6:208:31a::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 13:59:46 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 13:59:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef7cd618-5c1c-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FWduDpTPrdlz2F1PQT4xAxJ88pNf4Q3BtFwq2i/Av2HZCKUB/MNLdi5hIWchV728Ga0BBWyMR6eqrUQ4UNN0JtzNjEjoiYF1ao9yPI5PdpbfkE/4bhLVQft/Sho8stKExX9OGZ9fmgcMst95LuqpktSZdj6uu0m4KuJmxlPdi0fRs4h5OTrGb77EnUWcUiTcDfkSLIlCDyEyEfHXMpFQzMisMvK9MRjAvc9t+jNO/i3TRkYqm0v2D2sQO4IpZSg4J5cipFgAtd9nUEwFYhy1A+JudbHVdZEHlBFzES+A6o4H6ZawzD+3Omznt8ynD++3bq64k90XDQMfi0OavPeOcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gkFPlW9TvxlO7m5Ez9bnzEycr+6qecCL+TDV1c0gS80=;
 b=Lm9HLiZiCY8AIxSjn2Is6VPo0aevAnjVKIO0P9/EaADlvCYKqwQh3oEeqiZP5OWSJCpQ4nJzt6YXMHE7JKKcRTsVtfOuoaUFYS46HdGoVIw+FFBN44YB0ov861FJN4vsQYKsMdIb5VXNjNLRZZvLlXQZ+zD8IX5y5g6gMqnwVjXdfscOHnJhd3gXzUHFgjx229V5G8M5yKkN1ULAFCMcQ2g1VNK5P4KJogL6SY3xpEyNSLeKGp+3pu5voAGfppUNV7PCqeJFcw2TdpsHX1slh1hfRJ+mTMNBS7t4LgF1AbTabKWk9dPqZttnEYDKLw6TbO1DoLh8DwR7toqLCWEuAQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=gkFPlW9TvxlO7m5Ez9bnzEycr+6qecCL+TDV1c0gS80=;
 b=lK5g0RwVgVZDA04NQ9WLadJYw+ktHVuHTYgj4FD9wtqZTTbbYBW42dopd0h9bffpHc5HhlpAaM+K+SXL7oYWLGcKOCgzc5eiG5fjYPK8KPYbmMPkh1mMTvAHuiF0ykOQwwbmFYtZRaXOZrqJ2Yvh2M8EhGpCCjZEn4tSenlIFkMFfQT1UQqc/Eq6CNboE/rExRLW8SweOBVCLtcbhQjnRuk2CdUIbD0c+6DFX+UJKCFGw5bJgKsN/BbKoGZAc/vmBvJJB2fgo6XQspuvAxnUW1O6N5K0+bAbDS8eW9E/yap1mPCXqj0mYze/7Dh7SeghbaPHuvgjPPK3Wa2UUGK3/g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 09:59:44 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 04/35] genirq/msi: Use PCI device property
Message-ID: <20211213135944.GX6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.434156196@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.434156196@linutronix.de>
X-ClientProxiedBy: YT3PR01CA0015.CANPRD01.PROD.OUTLOOK.COM
 (2603:10b6:b01:86::24) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b2faabb0-ea2d-404f-acbe-08d9be40d20c
X-MS-TrafficTypeDiagnostic: BL1PR12MB5047:EE_|BL1PR12MB5255:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB504724086171BB12633D5224C2749@BL1PR12MB5047.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1060;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ycHDvDrLkZdfcREf9UVFOZ5gfPMEg2VV1vYmaD0LwMlTdRvspoj00xOu5RbK1EljzErHG70TX7J5q7T1pzEMH97srnif6/79iV+KazbwOUEkAyql5bneWDrbG+qkngI1IPwSGoEmgqHE9CtvF0DbMF/sgzHD2O5mIIa7NmB6fUATaBclGr0DFGp0lIM41bT4AUVFb8XJ66QlIWYN6jl9YmJChXw/t/FoIoO/AjI0DND99qnF3B8L6HaRbdxO8ohdHfcJ8mrsQcu/BDuU7ddtLoSyJLFt5qiR9PSYkhy3yQd7l8ByZ7ll9TCsBZTTJEomVMnV2jqWxDTGnaNPLhw7K2FtExoi1Arj+VUzIdWbDbrQ9TQCRBN6WeLnaSHYKZXB1jiFbQ+wXtCpGnBnJMPVj/9A2MnaeVOaU846mwB+Ns6ogFLkJ8dfpCW6+FFqfDONsC5oLSGDpIZ54/bndPzzMfK8Oh1xClloyzUax2prFgGW1/toOo2hvSe+Mtp7uPsiDArSg6HGRK8+zqu1NN8xDc+sXHHI6oOyJJoCP0untf+P8OlpI9JuE4XvJI8uf+Z1M0xgJdb3mYeaAayTh8mbKm9ETRegMt7EhVOt8kFSqdpZ8NLk5vD4oCseitFKx0k5n2yMIIDh1SN48SHeh15RyQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5047.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(8676002)(66556008)(2616005)(6506007)(66476007)(7416002)(7406005)(54906003)(38100700002)(6512007)(66946007)(2906002)(316002)(186003)(6916009)(26005)(36756003)(508600001)(6486002)(1076003)(5660300002)(86362001)(8936002)(4744005)(33656002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TcWBpSphOyXV13f6ypuuUB4LZ4B4nBshQshtCz52KpTS9IaHuTL/SIU8msOb?=
 =?us-ascii?Q?JpA9QiS2gTxNbbDzMW8uwPC/ydTP5b06rpqUw5vuU+j0kSWTY+gJbwObYYy7?=
 =?us-ascii?Q?uzuRPHHdeblX4/7gyQx9PMPub6H7GxeMBn1Y7VYGiG23FZIzYLQ/dL6QdQJk?=
 =?us-ascii?Q?me5eQeHLeU7cz7Fxpc5VF2vXM5OJAt0iJNVze6tzbLLD4zsiWC9kqHv0zFeC?=
 =?us-ascii?Q?xWORturpoNjUPqUH1gD4jIp4KqnSqJSyguWsia+TP+wj9tDmK7/WyUzuQHyy?=
 =?us-ascii?Q?qvfuEgYuRHU5XHCYAbudqa+76OXo+MNf6rxrLiXdtkxgA7t1E+3g9tVj6w0V?=
 =?us-ascii?Q?oNOZKxncUVq+iENbtLRBsCVrMk5Hb4UCwJtUQmakL+2PKTPIuqiC0rpFA91w?=
 =?us-ascii?Q?F0JF/4/2ZTmR7/6CIR8V74BtaOFEJbb0KSrjkjHdQ2XuZwiDxAhXNo+Tj/Pg?=
 =?us-ascii?Q?1l9F9iCEIam7qWefv+44r+Y2aArT0UiV435/6nKr+WDphsTWTus4JB9IGzLu?=
 =?us-ascii?Q?rnAvqiJg9ZdgyMYO8gEoKa8LcNPUEnKcv1ICsgbc4BldseIM/Ye1xdzpfeep?=
 =?us-ascii?Q?uvxHUSbLmNOdg6UFuUy28kt7NE85lO+Xp5/hHphx4JrzGjeUAoMixDTj5L5k?=
 =?us-ascii?Q?vcAKkyzRcq56Kf0BvuYP96o7jeXDpVoeco9XFe254gmcMlm6bot/SiuGBlug?=
 =?us-ascii?Q?jNxqagoLwDpUBmTWvUpzzjB954QWvGIaoJ3FoZCNNfmoX1gf8ktVeasvBvwJ?=
 =?us-ascii?Q?mgP0R2RyWa2nFKXmT7j/0cqn3Np7fm/gatMKGPuQ7ZyiZCOm0xfL3UC79ls3?=
 =?us-ascii?Q?NbGzi0h2KTaCrnqMOHoKLVDFlIUjDhXtOYT8ljJehpYJIR82/MY027qmWyHZ?=
 =?us-ascii?Q?74bNyBB21Vh4F6DlF1xus9QU54GsBRx6rZNzjszQZkKYvZJ0XchweP8UOVc3?=
 =?us-ascii?Q?tw2WtV2B9ZaOrWFRvUO3FGWo+5S2HyHfEjIR9O2kqX9bYoSENmDt8cvu6nhU?=
 =?us-ascii?Q?2h9XVDoSlorDu4x5FlLqQgbXZLC/LgOSURVxnUw5CxyGKUAfx77GRtPAXJGh?=
 =?us-ascii?Q?vk658EOFIJkfSo6QfiGAnyu8TYF2sx2KxnYoj8l1y7I83R+BS1AkXjD66zGs?=
 =?us-ascii?Q?r6ZmCTWKQYWx0WbkU0seLLvfbRUlZfF4w/v+91nCXqdgttUMESe7HCJTfIsG?=
 =?us-ascii?Q?YIAyc55z5yL8ZE5X4dFfsTDWfIGxq1ykLukMmSsKf7qMhjFMr8qp3b6WhrTc?=
 =?us-ascii?Q?rKK4PmyTfVPGAH1mRP2gz5xbP+o2Lgi8XMosKIXjB/+cXksQ6g4mAgr2gwSm?=
 =?us-ascii?Q?QFY6xFfHmvkpZFv4DJuDd8A7Y2aLOIc9iic60u21jKBVLxPuJnqRrmlkKIwi?=
 =?us-ascii?Q?8vh+l4hD2n3DG4aIuVYptUTktDc0+G9CGeiHGemXDdycoWVU7/hu/CqoSDz2?=
 =?us-ascii?Q?NMwgVUB/hAib3JJp4B6yq+3i1gUH1o39yh2cJMaeQHYHcq+igUJLp7duqEKT?=
 =?us-ascii?Q?33xSD1WdZ3NWkA6G0wej2eAdTk7dNQQY20eQGLmAWzTjrI5Fm4thW+dCXMAp?=
 =?us-ascii?Q?4SURXOMcRLZuJ5xRHRk=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2faabb0-ea2d-404f-acbe-08d9be40d20c
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 13:59:46.3834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kjp9tWRpKzBkBPyQzwWJU5qivgMmVf8b3FNdpQ3LqLAdCJxlLO7cM4LA5XsTTUH6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5255

On Fri, Dec 10, 2021 at 11:18:49PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> to determine whether this is MSI or MSIX instead of consulting MSI
> descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V2: Use PCI device property - Jason
> ---
>  kernel/irq/msi.c |   17 ++---------------
>  1 file changed, 2 insertions(+), 15 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:01:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:01:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246095.424472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwltR-0004uP-4h; Mon, 13 Dec 2021 14:01:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246095.424472; Mon, 13 Dec 2021 14:01:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwltR-0004uI-0u; Mon, 13 Dec 2021 14:01:29 +0000
Received: by outflank-mailman (input) for mailman id 246095;
 Mon, 13 Dec 2021 14:01:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwltP-0004u2-9q
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:01:27 +0000
Received: from NAM10-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam10on20605.outbound.protection.outlook.com
 [2a01:111:f400:7e89::605])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 284f2fc8-5c1d-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 15:01:26 +0100 (CET)
Received: from BL1PR12MB5111.namprd12.prod.outlook.com (2603:10b6:208:31b::12)
 by BL1PR12MB5334.namprd12.prod.outlook.com (2603:10b6:208:31d::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Mon, 13 Dec
 2021 14:01:22 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5111.namprd12.prod.outlook.com (2603:10b6:208:31b::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.15; Mon, 13 Dec
 2021 14:01:21 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 14:01:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 284f2fc8-5c1d-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=evfCkW8fPGkeLhneb633ESMHzmrBn3wPmlk5gxUhc2+FrCf6dhXmrgF+h3EcXsvMsIuzdWiUyfTO1pvnE4xoWEMLjG4det9dXAoAP/YVsoLFSlCP8EUBcJhNwUImDcxrUdwwkC/DjLYusV3TF3vu0Da9uhgbHVRSuF4uMlDZUaPi6d23t+oPccyzVs8ONOxQgId4VJAHXKggYq4iMfO17cZHWcr5EA0Mymt+MU4LX7M4KViNC9U45Hv1akpti0rWHpKRvUkLmxiJWzIjp21XGag89VB8UgF7jMO2qlhfouJbDUbMJkixjnH/qkh5+B/ZM/ZXGbrHPXXVj+4WZpAV8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LlMF/+WtA6YdQsLs5VHo84300JQYQ5QA6EWbVzAk+H8=;
 b=X3pvuNfUcS9URUWvJ0PD2OQGWQIEMBe/0okQLgbpQqIikCC9X4ThWZscJhIiRc9LCUhiUzRFmloYDFWtgYt4RalMxeDe7aIspXqaeAI50KKDUkBwANma9B3B5O9L1tAdcSbmkzIZNNNxxtYy9Lg3YDrFu3g51/auBwSeoz0wMS3tY1oUIzFD2i/X0byK8NbYcjdX1E+/dKXFT0Y4NTKxs2iy46Y1ybVMdmVlY20LSG60Vz/NUm20GpMwrSvqjHDdcxU2FuAL61Kl8lBrkNcKNOQI8s0gSZgcDi4CUL+KW4rWAmkY6JLdeYb1GoXgWJBupT7DgKSckDEGp10v+C4ApQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LlMF/+WtA6YdQsLs5VHo84300JQYQ5QA6EWbVzAk+H8=;
 b=WWNpiL5eNFoki6MoWpF+o5CAwCN68AC81WB/U06W/oe26N3emwtLWGL5o8FrsvXNyF36cKfNxXjGW2yWz5IJcT1L1sulx1dSmbJKCw7CEtTsWpcLl2OQbT2Lh8cpA9go5qeqokk5sbPxoCUnedVzjJ1yflYVZkihMsGOztiRfUSx/Fcwn2P2CzaF/uY/FtRltmR+ZjccHrAAXZgtj5n5s6VeiNkPeOkBDqhOHL78vf+Zwh1shYfeVJYDu3ZqHwhZZpb9Ts/l5MI5rGxqMQMnyIxVyiG9oB+mqECTyLI2ePCsVjxtazwz7a1XVZ676ANTwCN7ajaNevQcygV3duzXmg==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 10:01:19 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>, Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property
Message-ID: <20211213140119.GY6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.493922179@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.493922179@linutronix.de>
X-ClientProxiedBy: YT1PR01CA0039.CANPRD01.PROD.OUTLOOK.COM
 (2603:10b6:b01:2e::8) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 42bf01e5-e98e-4c9a-c2c5-08d9be410aab
X-MS-TrafficTypeDiagnostic: BL1PR12MB5111:EE_|BL1PR12MB5334:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB511104452E38FA5162B1642DC2749@BL1PR12MB5111.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2043;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	HPEY9KlCvUCh5Xbnatfd9ocx8COZ/3g/o58EYyjE5ATTw0SUM+b4MfRTbsSph9dxZHg14CX+PTxC8J2MPbkGQ8DhDyiiKTo4xSPAR7K6c2jc/42y87iCRpiMtrgySSB1HUkn69AeD28+SFzw/VOoWCSPB5L9KL2LgeM/pdLVpGM0uQShQOKsx2ZSXBFLEV+y+EQuloUVemDquCMLCq7hSlxjXXIXIpxY2WMMqfeT7qRNO81qt246o+CVOZofNLpZ1zzfrNS1+rRzIA1EQ8Drf2XBX7SP/58hgpUexA8w+RJzafbbFhO5RSAaWMJoOs3VrtVujRKn+inKQc/8lVpXNBzfeuK0sQR3A7BlJzG2/NcF5GxLAGCiaoSwzVut2FZLD0ItkB6Kzc4RAdDl2pnKAMV6Yr6Bf5n8VkhQJ4JoBxvzEQdKJDfE1naXUfCF7Fe9smTJ2E9pTjt0WVh9OViSwVCVjmhmKdWk0si3E/L3wxGZBwfP8WWemxK/iI0fhJpCU5vsG80ARaKV1Ur6hY5r0OSv6oWdMBkp+3TH0ayHX20cNamabMJf4kQrj2iaThqScWAJ4ZDx7szNUkOflFgXIapT8RaMk2GSagYMyTuWyA+Ez8W5q7TZfXZJI1/wxYB2WkezN5VfxSHtFvwcr4IUmQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5111.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(6512007)(7416002)(8936002)(36756003)(508600001)(7406005)(5660300002)(4326008)(186003)(54906003)(6506007)(33656002)(2906002)(26005)(38100700002)(6916009)(4744005)(83380400001)(2616005)(66476007)(86362001)(66946007)(6486002)(316002)(66556008)(1076003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?MU6qH4cQCAQ7AAhN4pQ1R8xxTCuYJVW7E2Mz0K/YReQL9mmdunGVJQMIReoM?=
 =?us-ascii?Q?G3//ER+U3RiLgpSfCX5krQmbXa+a4T1g/TXUfug32yE8vk1/o3UNuzDhALlA?=
 =?us-ascii?Q?jzL8KP3nXINqqqfBkJcZbF+7Anvj76Yqljocj1yBU/SwrqJTbyAuwBwEXwBH?=
 =?us-ascii?Q?2dzJak/1/iWmgU3t2eT/Fhho5NCthEvpa3xfIv8Iezi4RMRpLqASQie1/U6f?=
 =?us-ascii?Q?8WqWr8XPoPLI+/8gi8bssCAc3gnrkMrLS0YceqRxNVQUr4BiU++RGyAS01fX?=
 =?us-ascii?Q?q5kzLKNbmxm1UBU5JCtpIJCGhHslIzPAn1Nl9k5+q7bGbRHOUSJ2flYICKXt?=
 =?us-ascii?Q?R0QKmJxELGDJ+3mta5/2RYyMeEjXSVbLwS8IlCCM55EdSinNsXP5K8EmYU7y?=
 =?us-ascii?Q?n5HAZhRrMfK08ozWsDnPLKgBBoGsIUbA4ivmaOqHOOOnSXIL5LTVu4+TM+KS?=
 =?us-ascii?Q?0fGtkxU2y0cngXS/LZeMaM+weh1e4QhtNFg9Fo5ub3HRq16EVbBWRZ6gNU9D?=
 =?us-ascii?Q?lGEHAIY3euiZAeo5xwsUqVhvF0iuwmlZ/j5qAFsu+hiecN25dTrt7Hk8prB1?=
 =?us-ascii?Q?TMjNdTDtwBYJGBU8SOwxmgIW93wTosZsoNaIhri6hvgCK3BXwvqrYCNEFJGb?=
 =?us-ascii?Q?dtxGdoXKmaZRPd5fpbSPvTLxzIjqmM+WsuEjsL0Ld/v3g+QZya7v9YoP8gw9?=
 =?us-ascii?Q?8D7+PVRnirCcSvcFmLyRIjSkWNE+YRONRWzl26R/sdKEL6gWP/4lL9KcukCw?=
 =?us-ascii?Q?/gUQHnGnIMiI7oX2k0C5GY4wGJqgGxV+gTJxIcWH+9mcYveyvEyJT8eThi/v?=
 =?us-ascii?Q?X2OWK2TNSE2I2JnFdo0zDvfvtHH9F+iYohQSS2kvK+9hpoNeeYQTld16JjuI?=
 =?us-ascii?Q?uO0vykylzW4drgfatDRsbPmSTOqVKC30K696JyTQLhwWJrrg4IYkq7MGsLdU?=
 =?us-ascii?Q?2rCxm65ye2CP28K9U6cbhTBEMFAN7qYVw5WH2XuT4JHhvgwYiNToiWLs7O1/?=
 =?us-ascii?Q?G70VhrJlMoCmYq7vNBaE8P9mM8pNZ+MNaZxma/LVj61TLShYhOxiHAwf8Kuo?=
 =?us-ascii?Q?/xKR+3+X0+ugfrEFCc2r+TYYG8wZ25Z+KSkBuysjfoZXTW/iZGNh6LIFcji0?=
 =?us-ascii?Q?Qp6fbCFk7nxLjHu2DXmbpdaa5lu3ES72fUv6+ZhZ0gLWu91FFThbSmJ0iQQi?=
 =?us-ascii?Q?ICvARK5kZq/GFB0KyTrt/tCAxjEKDfvLQMzq0Utr0miAr/MBLMK6sx6lx7qy?=
 =?us-ascii?Q?Qpz6fUPW9ocgDAzOy4nml6/Tb9iuly6rDSXRGaExuAvy7P8I+SP4VoetVKCQ?=
 =?us-ascii?Q?jJBKvkz0LqGKhNJOi9If9k7WZKpTp+wBnNjSSl4psJ3Hg92leBfPXk6eNTHP?=
 =?us-ascii?Q?aB9ZUZF8fdO4TMhDlMVh+khaV4wdaEGby0wH/MOwS0fESdVgqb48stg0XEcz?=
 =?us-ascii?Q?Z2WnpgVziI8jKibyVJZZtNues8nWb1y7/Ad6bsruoZYMRqP4/NzTSOQc1xuo?=
 =?us-ascii?Q?D5krg56UtwFAhcQSENR0G5GyJvDacIJFwkCzB4Wo/hgDrVygZdASyHtUcc/h?=
 =?us-ascii?Q?rirqebb2NJn44i5tp08=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42bf01e5-e98e-4c9a-c2c5-08d9be410aab
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:01:21.3003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o0rLzrumUI9mtRFTkDxCUrs/be4HKVEFvJk9/ev6ag+RNwCvz/J/4XFYRZD+TDQ5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5334

On Fri, Dec 10, 2021 at 11:18:51PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> V3: Use pci_dev property - Jason
> V2: Invoke the function with the correct number of arguments - Andy
> ---
>  arch/powerpc/platforms/cell/axon_msi.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:04:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:04:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246101.424482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlwS-0005Zg-JZ; Mon, 13 Dec 2021 14:04:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246101.424482; Mon, 13 Dec 2021 14:04:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlwS-0005ZZ-Gj; Mon, 13 Dec 2021 14:04:36 +0000
Received: by outflank-mailman (input) for mailman id 246101;
 Mon, 13 Dec 2021 14:04:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlwQ-0005ZO-K5
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:04:34 +0000
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam08on20616.outbound.protection.outlook.com
 [2a01:111:f400:7e8c::616])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 97e9839c-5c1d-11ec-b442-ab1a14567e0c;
 Mon, 13 Dec 2021 15:04:33 +0100 (CET)
Received: from BL1PR12MB5048.namprd12.prod.outlook.com (2603:10b6:208:30a::17)
 by BL1PR12MB5063.namprd12.prod.outlook.com (2603:10b6:208:31a::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 14:04:29 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5048.namprd12.prod.outlook.com (2603:10b6:208:30a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22; Mon, 13 Dec
 2021 14:04:29 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 14:04:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97e9839c-5c1d-11ec-b442-ab1a14567e0c
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UJeMf0AdzWz10t5c2AvMM1Qy1mBzi7y6w9yF6YR7W9s7OqoioCPOiOG/F9x6k3Y8D/IJWlvR6o7kfCUdV6BZnXMubc/kgRosZgWRtpEZAJs3SBQFt6Rl1OVSnFM5jPUNgBfdrhywBW9wBYk85cfVWO3B9JLSxNrJqy3lBRqKzAGPL31J74o2HPT3P2oLJiGuIp9YiNA55QzC81zbiesTZvibz3F5tBH+VV0W9U2jsRGvPjEKTu8YMIEKZpMniLnw6bKRDecw/jMYKxrgTJM6m2tETTeQixcolHFBeBEONnDbtUQL4nDk3bORQVC2An9kCB8U+LlwQv+UQT5rQC4V0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sFR2qCBgO35DCCzARlo9F87PegthBCAuSA/4C+N7+3I=;
 b=NfL72K7eN36HpcftECMCu7TLOZyDq4ev/lJSPxStofkbT1H614pn9t3ODoGu2+lN7dUetVhTVt+214RqxtkR+txv5Lu115zYcq1rKfl0W2PK3/gyXFKTeGPP1jiBTyJVzhsK9lLS8Q1xk3LYazgGGxPYZtIY68oWDw0rggdRlQzbg/dercs36OIqCfMEx8a1s/B1Mooq+rMI3hzGG86Trui2YYnNN+Ae/75FaH9nRQ8LYVmKNOrqKBHQ5e6/ISonKo717FAkHWR/XaRka7eRDxi6i7N2zpnDUdxhna+KPkoJte8p2EfLDHiteQc9BAQ3KuomJgZ1eMDyVXU2aUZ2yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sFR2qCBgO35DCCzARlo9F87PegthBCAuSA/4C+N7+3I=;
 b=TXX9Mht1d36cVmT/6hl5jKBzi00it1UcMsA9GMYLR4tyNeOsz+WWqPHOHHQmAPNmO4iuMEXJxTtTA+hZvLC7OErlNlYBKZ51cw9uh+0UxaAkMv69EShaqSEdUkbwjlT3XFvPjyn6cdWQ6tmxBEMt2CpRk2DDPJIAaS2kOQkok26tYsKblmP6lSsUuPLatXcoFy6Uw2MPaui8xyhReddwyiclVkGKEqjNe8/j649Wsfw56T1Gj1Y0EJ3Du+vrXFLjtlRTKLGOvTBScLf1GZqZabDFS6ZhJw4BtXm6pitMLqVHY9cXFuj2abwTbNDMWDpKNGeY+CqjnBm1SZBcy3lv9g==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 10:04:27 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 06/35] powerpc/pseries/msi: Use PCI device properties
Message-ID: <20211213140427.GZ6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.556202506@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221813.556202506@linutronix.de>
X-ClientProxiedBy: CH2PR14CA0036.namprd14.prod.outlook.com
 (2603:10b6:610:56::16) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 98e7e462-cd68-4183-9f08-08d9be417a7f
X-MS-TrafficTypeDiagnostic: BL1PR12MB5048:EE_|BL1PR12MB5063:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB50480FC48CED472F62D2B0C4C2749@BL1PR12MB5048.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Vod+DPCiFPAdYsVFh2/PPcMbts7bAuPrkNT5362HkhU3xCcdE27qtR8MvrIkJ4ZWju/zlX0YTDw5CK8B+KvfpLNcNHjqaZKWG9cwXRuQ5ooo/w+tN1JvorL5tqJdmWZdFACIxs4r0TtlQtNaZkvMrX131Pc9/6fT4PSr1fER11EM5cNNlpegCHznJJ6nIuK+dn/AkJNe3M5i/2fo938X0KYcHtyzrcxCAvIQGtCa1wK9yii/Y0TYVKp9aEar2upyCvscs3N7ylRYNblOdXIarVhrtqaA3kYYsCgLJnBX5Vs2JY11V50noqMm2d7c8SDG7UlEKvmyQ/Vhh0PwJM5bzHSmmn+D3jz/ioZtXVE2hIeN7PaD20eUL/Ev3VkIhe9hjPw9MBocpydMcTklxfep+dwz4zAYveAqWV9HXwexfXaPLyr5eNc22zVOF/doJj7PU7Q8eMMCShwq3eBNFgG/+SvMfmBbrC5QaXWr49B62+nhkL060U1K4qjW/vCvcIPWcGA/aILTliDOxoY7ceH7g5NuiOfjYjNBZGKbHTfAkgds+c0ceBHNX6isOESB3oIwh3g76vv7Oad5TiyUE71IpwPxRz7RasXVmWDC1pSdMU0Q36NCZrWwTpj/5Naj+ciEXPEKZ2GTghov6nn2y/0QMQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5048.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(38100700002)(83380400001)(186003)(54906003)(6512007)(2616005)(66946007)(36756003)(508600001)(6486002)(316002)(86362001)(1076003)(66476007)(2906002)(66556008)(26005)(8936002)(6506007)(7406005)(8676002)(7416002)(6916009)(5660300002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?J5VUedlTPcvI3lTUwuQpw0Y/Y13Y9NuOw40xNlNBrf3hZVU8eLB/ewcBpXin?=
 =?us-ascii?Q?ymPhJHF9SJaRl1e5g0ipxAVcHlf6ZNCVVjLPj2SDOT3BnrGcG/+nVFN0os5n?=
 =?us-ascii?Q?eYJlm/RDQv2tE0BIgnlg9EdSXKqW6V62X7UHQgHl+hWLwMIq9vEIuFpL7lxE?=
 =?us-ascii?Q?mp02noZYdE170szxV67/xeRrGM0ocZW/AbqFhMjsLfGZZ9durphOIkpeZqil?=
 =?us-ascii?Q?tFquVql5n9IurqlV73hZjYHBL7bWlWTi8OgfroZAvzLxmX3fQMKZx94lrplS?=
 =?us-ascii?Q?8mY4pXZHLpIHMJwtrl5T48Popdv/WMdsbMpptrmhIoGSOjdI+SvU3vIaVaR6?=
 =?us-ascii?Q?EtC2UCoCWE5nQbeWzUJMppGb5DYRnHghLGpqtUt2QPP7dB4z1AuaVCmY2siI?=
 =?us-ascii?Q?FpyZ91HC+SWdyMUV0GygkSdCsvSIQh8rEIgMd3vx0rypPrv3EbWvIeVSbSew?=
 =?us-ascii?Q?GfHtt0fcabIEXeKWYvzfoIReLfzBTKh+tRa2coqFDvt2LTYcFpFZ0S+WnNcM?=
 =?us-ascii?Q?+YyWvo7/va6WWu28TphBLLDaC82egcYoM40HPdY+RwP5oLA3D+69RNuaYARP?=
 =?us-ascii?Q?0Y/bmSWZ5yG8dU0I3G8HpmborhZ1AYmaMB95AjUmFKrwjeZ3RvjAF+gJ5ZcP?=
 =?us-ascii?Q?Dzo4UTy2wvX8wNISKJFuGDNDXi5Jg/LhxcZS+NuefFb1KI1xQ8Os8dOgKT1Y?=
 =?us-ascii?Q?Y0FW467uERIq0klB7gEQ4xnDDeKvSHNZRg7UjsG6aGdf9W1JTJeVsJWQB3wO?=
 =?us-ascii?Q?v2/UO3enIbp9B2flFMBHdwrbHj36m9dDWV4TXk4vHEjHGa5Ux0LDkmLHhWMA?=
 =?us-ascii?Q?nn01tWToMMq0c8Ob10vWy3AgkgXcmKcj6NLCvXynsxGsgEeCUGSm4NrZ4DV7?=
 =?us-ascii?Q?3ws3SeX8ahUAvUMdWSXMp8ROKJojUaiEueI0nkBrb7rUCjIww7dTd3i0vPP9?=
 =?us-ascii?Q?s4ozbbQoccXyHr/wZ3raMc9RCwNIzyY1dT5Ny3Pnh3rKRp9y7AagXgomvPDX?=
 =?us-ascii?Q?LmJMLBLXFnnG1OnKu8h+1wbSo9O4/UpcB4KPhTFbYy/OTth4I2nS4oUYvT0a?=
 =?us-ascii?Q?coKArLlMTBgAHBYUAe9dAwTUp0gN6L3Z50oeazYO4VbPHfzlNBuATFeKXDMy?=
 =?us-ascii?Q?5uWBSB2U/t05u3dqGVjemQDYc6sfdP6O+Io45bwZbt75mYQWVCf1WmI4UUI8?=
 =?us-ascii?Q?kHCuiaCwTD5Q8oy+QNO+l2FsM836CoQgCTLcoK4D76F6oBk235KyOJJMDXLS?=
 =?us-ascii?Q?DHwu1nTmI6EpPm/BmDv2LCW7ELg25k8NQttrYxMNo6HpKNU0Vb4br1xln+Gz?=
 =?us-ascii?Q?/awkyiJI/BWt33rrBVBiPl8wHccvXVqsH+0EXgBoHGwh/anKda/YkcXg/i7g?=
 =?us-ascii?Q?u8teW5Y/hZHEz6vBj8r8JC/U/NT3ZZwexlbQcT+hgIoZJbWD5yM5budx8Mm1?=
 =?us-ascii?Q?igAVVQgYnwMmCuFoUQ0M4Fm6/VDiKVvi5hqmTqMPB+ME+cHoam96GwHCv/hB?=
 =?us-ascii?Q?NOKpbZtWBkrBCmV9WFDMHy5SQLrhXLuVwSIprk3fU3VZK0vejVxNoV7+tHK/?=
 =?us-ascii?Q?tkYAAVTj/PR5ASrGwww=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98e7e462-cd68-4183-9f08-08d9be417a7f
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:04:28.9314
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bcZfBQZ+ybB0I2QtMD5KRQT9sCR68eyc1pg9XMS388uv83zLKwHWWsdZZSqLTmnG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063

On Fri, Dec 10, 2021 at 11:18:52PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> instead of fiddling with MSI descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> V3: Use pci_dev->msix_enabled - Jason
> ---
>  arch/powerpc/platforms/pseries/msi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
 
> --- a/arch/powerpc/platforms/pseries/msi.c
> +++ b/arch/powerpc/platforms/pseries/msi.c
> @@ -448,8 +448,7 @@ static int pseries_msi_ops_prepare(struc
>  				   int nvec, msi_alloc_info_t *arg)
>  {
>  	struct pci_dev *pdev = to_pci_dev(dev);
> -	struct msi_desc *desc = first_pci_msi_entry(pdev);
> -	int type = desc->pci.msi_attrib.is_msix ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;
> +	int type = pdev->msix_enabled ? PCI_CAP_ID_MSIX : PCI_CAP_ID_MSI;

Long term it probably makes sense to change the msi_domain_ops so that
it has PCI versions of the ops to use in places like this that hard
assume PCI is the only kind of MSI at all.

If the non-PCI op isn't provided then things like IMS would be denied
- and the PCI op can directly pass in a pci_dev * so we don't have all
these to_pci_devs() in drivers.

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:06:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:06:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246105.424494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlxw-0006Ck-3a; Mon, 13 Dec 2021 14:06:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246105.424494; Mon, 13 Dec 2021 14:06:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwlxw-0006Cd-0W; Mon, 13 Dec 2021 14:06:08 +0000
Received: by outflank-mailman (input) for mailman id 246105;
 Mon, 13 Dec 2021 14:06:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwlxu-0006Bh-Rd
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:06:06 +0000
Received: from NAM04-MW2-obe.outbound.protection.outlook.com
 (mail-mw2nam08on20608.outbound.protection.outlook.com
 [2a01:111:f400:7e8c::608])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cefbae46-5c1d-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 15:06:06 +0100 (CET)
Received: from BL1PR12MB5077.namprd12.prod.outlook.com (2603:10b6:208:310::17)
 by BL1PR12MB5063.namprd12.prod.outlook.com (2603:10b6:208:31a::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 14:06:02 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5077.namprd12.prod.outlook.com (2603:10b6:208:310::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.24; Mon, 13 Dec
 2021 14:06:01 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 14:06:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cefbae46-5c1d-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NNR0osBeJ/xnfcB9OdE/defjMSmy/SNoedJzUTAaPUM7u6z3AmcKSBdUl6tlCi2OY9eCxcv7RNNw5L63mDf+Zwop7FKETRi5Zb/4dHKadsxGgTEOXXrzaMi3vNW5uIWkHrJaK4PhBz0Z3wAOWwf/KeYg6rCWadVExI46xkgMc+0WCdKr/a+F1Ief9u4N+DOQ2QkDYgqdWsfrNM7WGz+75uhwBVMXUFTlWyh8TUEbv53Tg+l3oC9/EnSsNRXVlP0XQ+pUz/tQTFhNK55PcorBwxTCanmQqRT9lhxVuZRKbw/jWr+vHSaaWQL3txTJuXM8twuXNrKP9jz9CuOJ6gAw0A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=proizXdp8kJN21h3QN2ScDg/8vSLfKY+CDRRljhwb5A=;
 b=W+A8usOy3nfr4+ek32xsh2ii4tdyTHNg0P3Utx/3T64x6GxTzafkpejUXQLmZOyDg1m6ZOiccOlU3TI0X5prBXb/usZ+mekH3x2UQ8Af+jcuy2h+K3zRjFgOxL0V/p1pRbvYzlsrWPx076zX5UcoEykFB7kkPMDaZeyBzlp51C1B9UmQF0eqd6t0QP5cUOa0QuH5r/Bl3ixM+dwElUQZDNtvlQz4vG/NA4eofpXVaIySa2QurudnCulcGEC329g45DwKumErldoGoLQguw+EpPco3UX7o+GFuFQl7N36ixO1SWjfCHvwaA7JTRYZbI0Sjxvqy7Nvha0dvbIN2N6t7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=proizXdp8kJN21h3QN2ScDg/8vSLfKY+CDRRljhwb5A=;
 b=PHggXsbSfVtiqgKOEV6AtutxsZY8qeSFdiXA+3/oibd+jnNOYfbDC0bJtvcfnVw/RPGjvse8RCr3jG08idOjRm8ajaJKxH7PJbwAE8dF+frWebgt/WVgoOvodbGahohjFPe8/cBxmAKEg+4cC2VCqQpc6poyA3dEGA6Hjg/aYSQ63ZYt96of1c4uyb/+guPLP7hhyZbzq7J3OLru2YjBeuSAZlE9HBvKkWjcjlGy/kST7gVlfBTScHpNmveIsoCU4ce9TIU4FhKG3r/K4/xFrDvN9ybs1N6FPodHS0dYtpQdwWPdtuPUlMFw1CWZjzA7pWxiG1zFQ5U1VAEF6zGRpw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 10:05:59 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 25/35] powerpc/pseries/msi: Let core code check for
 contiguous entries
Message-ID: <20211213140559.GA6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.720998720@linutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211210221814.720998720@linutronix.de>
X-ClientProxiedBy: YT3PR01CA0054.CANPRD01.PROD.OUTLOOK.COM
 (2603:10b6:b01:82::25) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: da0ded4b-8b89-45fe-905f-08d9be41b1ca
X-MS-TrafficTypeDiagnostic: BL1PR12MB5077:EE_|BL1PR12MB5063:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB5077785CCBF529927B384CFBC2749@BL1PR12MB5077.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1824;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	WJI2TZzOpNBRQYIWGw1WgTy4otpPQndYD+e00WIQIiIC09QJ6PrR+11VINVn2DO7uEPYGpTH1M6j7Lb7SCts6zR0D3E1f6DvK3AHyqBgfcfrdIKFj6RKPFMNgD3sQebyVfT+sKEk+ive1rxkOsgTPThybMq0mx/TlbqBnpTUHbV2nsTuA1ZBhJ5b30ZfNtuagXchhott9xWEyTR+zmWY75LitQLypyAfjwyqMq3lORypBrYtxgCC38qyfLjvY6EenMJB0jvOBxScJWho+PU45YO8bImF+l4Fw81ZfR699tVH+iwQZEpMmgmUH12YdqMBMor0MAigDmpBL2ZTu8YhLVt8PvOtxLJZ7heH6/K2VQH7qjDl+phbJsWC5xRzUhlddJ1LEKMxRF3qs+vv9IbFzmL69ci2nhcmNMW2Pz7OALSInj15DHKbEfeyoCokY4Tgt9j1H8a5bpRO9O+Ir6JC78W5eM/CWRD0OQS9dW6ohXdEGUk0xWQ2kuyR0EaeK1bjDjrENlLqyl0iq8wWKV9kjiubhGBh64CcgpbHJu1Kl97X5bH6hpxp24F0A9k86XdV+dFYDSKDz4VdwirSTMTPZkXEjROqFFvYiU8GoZiqsCpQfBjetfOqIgMH2aHhE/KU+m0ogmEsSnGaRq1kH5ZCKw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5077.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(38100700002)(83380400001)(186003)(54906003)(6512007)(2616005)(66946007)(4744005)(36756003)(508600001)(6486002)(316002)(86362001)(1076003)(66476007)(2906002)(66556008)(26005)(8936002)(6506007)(7406005)(8676002)(7416002)(6916009)(5660300002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WVBnS2Y4ZzczQmpMeGlUaXRzeGxjbGtQUXdMU1NEb3hVNm1JRElhT1lGZWEy?=
 =?utf-8?B?ck4rMFlLRjd2YVRnb3RNeDB0UnY1TmRza2tlM2R1TXVtdnpQSlRpK04zYlVq?=
 =?utf-8?B?S0x3OFlhUkUrV0JzenBVaVprUDBUY0ZYVkNScmc4bUU4ZDUxWkVsTFo4MXh0?=
 =?utf-8?B?ck93RWlhYTMxcXhSQjBOUmNZekRtU0pMeitoY2c2ZXBaaTJOSlA4R0lNNkxU?=
 =?utf-8?B?Nk81VUtxandkQ3FxNUVXYTluY3R0V1hUWFNtbFhIYUc2MGU3c0NXcFh3Ymk0?=
 =?utf-8?B?VUE1NW1kYTgremVlenhtMzY2akY2a1RMd0lsNmZrRWV0SmtHVWl4OE9CUjIv?=
 =?utf-8?B?eEszWHRmbXpVWVFnb0FOMmVlS1BqMXVNK2ltSHpHMkpLWWFCSU5XWENZRkM1?=
 =?utf-8?B?YitQdGNOek5vSUk2Y1ZpcGd1RllyNnpGRERFa3lkQjhqeHRHNTIxdVhMc1lT?=
 =?utf-8?B?QUpZVG9EZGZDU0J5Rm1raW0wUlJ2L3JCNUxRZmJ2YS9FT055VDB2aDVhRDZG?=
 =?utf-8?B?RnhUaG1uSzFTSGcyVzgvUXZNQTd4eVlqQmlxaTlsOFJsc1lZUjBGZDcvSmdS?=
 =?utf-8?B?WnZWamNzN3QvM0JVSFloRUhlbDFBNnk3ZktLd0ZjU1l0WEc2UnU1UmYrNGR3?=
 =?utf-8?B?WXVteHdTMVBHcVFscmpQdG5FSEJRdGVDSkNxNTZtK2hwdmwvYWV6VTM3bnlX?=
 =?utf-8?B?MlNHYnJvUzltWUoxQzZxcGtrN2lDL1B3RSttZjREdStjbHJPWGVoTDJEa1I2?=
 =?utf-8?B?ci9YSW5Zb1Y1NmFwTEtqS3k2VFU5UmdDcWhZTXhhZzV2N29xQlpicm14QlJ5?=
 =?utf-8?B?UDhGRzNlMUxtREx5b1VjMkJkSFNOZzlQZTdSNUVhY2xvNVBqaXpxUFlzN2lO?=
 =?utf-8?B?bDdtN21nTW5XWlV1U2JKeWxuMlAyQllBNnJNeG4vKzVDME0wRElLM3k5Y0xB?=
 =?utf-8?B?ODlQa3VYbHlIVlhmMm5PRVpQd3Q2MEVUbUlVZjVVT29PMFovb3IzdmxETVQx?=
 =?utf-8?B?UlZDZ2VEMmJDakVKWUtWS2xOUWp6aDNwTHJGc09uSE5XekIvdEdHQno0T3Vu?=
 =?utf-8?B?akU2TDRUS2ZmZXNPNW9rYUZrQm1CRHpDYUtydHN4V1h1eXkzWDFzbVZLbGNV?=
 =?utf-8?B?UTI1S0VMNXRmbytXU3ZQTldwQlZ4S0tnRWFWNTlKZkdDUmQ4blRIU05JdkhC?=
 =?utf-8?B?Y0ladHFZeWNZMXdwUnlUZnRnVnQvSmhoNmRNS1JZWURSajQ0WFJyUTZXYXdL?=
 =?utf-8?B?VGtiN1dWY29XQUhMc3pML1p3Q1k1R1JORVVPc3pjTHlrQk4wWkZpYkJSeWJZ?=
 =?utf-8?B?YzBnMXlRaUd0eit3S3o5eGhzS3VZbWdZaDcrOVBGaEhGWlBkVm0rTzB3WjhG?=
 =?utf-8?B?T2h3LzVOUnNrbkZ0YmgwWC9qYUc0Nk01bWJNaFJnQUxVL1M4cWVzakF5VG9l?=
 =?utf-8?B?cHpPWXNEcUdYV3p2WDVyeGY4cXlSZVI2d3VMTktzd0gyY2dvS2NYOWFGSHhi?=
 =?utf-8?B?RnJ5aWptaGRXcXRmTFVpbjVnWFJqYUdoNGdEMWZ6SWxRbWhGODNoSGxsRjN5?=
 =?utf-8?B?Q3dZT1NZalZ4anpVemR3eUpDdWl6UFlvLzlVWXYwM3lQRUNLZGcveVFTL3Vu?=
 =?utf-8?B?WXJUeFFCdWYvTlltak44b2JKTHhtbXdxMk93elIvNDI5cWVOV25pWGdYTEo2?=
 =?utf-8?B?RlNyWXZtRFlERjZCRHo1WXFCYmRidXpkV2pBQ3JSR2hsR0xpV2dDc2ZUQ2Rl?=
 =?utf-8?B?OEQrQldoVGtvWEhJelE2ZDVnY09ITlZxSmRlcXdlQndJbVRiM2RNZGxkeFlQ?=
 =?utf-8?B?UU92NFBBTkI0NjNXVmtmVzZiVFVsbTF5dW9PT1hZK0NZbG1TZW16Y1N2bHNi?=
 =?utf-8?B?dEJzaU5PWFpVOUhqeDRMUjVyZ1A1dHpjODNBZHRkaE5FR0xtMmJsRitOMWJv?=
 =?utf-8?B?U0RyRHA2TC9qUDZpMmJJSmVoSEZHN1ZKMEJlei9nMTA1MjJ4YXlzU0JBajJ0?=
 =?utf-8?B?UWZxaTBZVUw1QnpicEg4WEtDYkZDR0MxSzFybDI4RHVUYUZhQ2pDdU1YZzZT?=
 =?utf-8?B?bTdtSGtybkV4R2UydzZHdEg2N1JxbnlvaEF4WEhtcHF0UGVPUXNMMWMvZ0ln?=
 =?utf-8?Q?mV08=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da0ded4b-8b89-45fe-905f-08d9be41b1ca
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:06:01.6828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40bJpPqRRPF2i5X+mtFiS5EUePG3uz/PEf5FTcFgzDxKXFnevSYh2HV7vx0N1jKh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5063

On Fri, Dec 10, 2021 at 11:19:22PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Set the domain info flag and remove the check.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> 
> ---
> V2: Remove it completely - Cedric
> ---
>  arch/powerpc/platforms/pseries/msi.c |   33 ++++++++-------------------------
>  1 file changed, 8 insertions(+), 25 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason
 


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:23:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:23:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246117.424505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmEF-0000RA-Or; Mon, 13 Dec 2021 14:22:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246117.424505; Mon, 13 Dec 2021 14:22:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmEF-0000R3-Li; Mon, 13 Dec 2021 14:22:59 +0000
Received: by outflank-mailman (input) for mailman id 246117;
 Mon, 13 Dec 2021 14:22:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwmEE-0000Qe-0C
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:22:58 +0000
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1anam02on2061b.outbound.protection.outlook.com
 [2a01:111:f400:7ea9::61b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28bdcb2b-5c20-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 15:22:55 +0100 (CET)
Received: from BL1PR12MB5350.namprd12.prod.outlook.com (2603:10b6:208:31d::23)
 by BL1PR12MB5127.namprd12.prod.outlook.com (2603:10b6:208:31b::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 14:22:51 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5350.namprd12.prod.outlook.com (2603:10b6:208:31d::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 13 Dec
 2021 14:22:50 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 14:22:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28bdcb2b-5c20-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bkm/97cJcKtiN5wM0AE1LG2we381O2MZ/R5ios3b8HJhroi9mmIpiNR9clxZ9h+sliK+3vy5r4KOnwcionVMfXgB/zsROv7hEWuPQpeLIo6EF1oqZpHmcS48YnsxOCFXm7/lPHijcad6Vaf5DcK2//ZpRzyvCKszsUIvCBcCyZKGcF9DZyFY93J0G8crUv05Cvpu35mZed1+NQbWKZ9joZ3nx9NY1SkAs4axAgYrkIZzjHrSCLBTZdQ19F/OJ1BuO6gee4azX4zyt3Mgx26Fh3lhk5cwzdofVsDNEbgKbqLs5b4sdV+tpZWVabaGw1kcoDYFYtN2vl0c3QkJvfz+ZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yK24KfMozkMUMHxi4t/9xmHkQORWks/mpdbKTi8KK0E=;
 b=OL7qjTl+dPlLoYJvA9SGNwHscRx7Hd71VvgaSdNptbCwrC9+1WAdrtsVU0SHG/waJcOLCUwDC2cIJyAtDJyAJSRfyB+/SobJcZZNpwFTnkE9ILGo8de65gbRottbYA0FG07vurN27aWhwOkfRDqRTGC1PBClKLvaSj6RI2236J9YWmJJ43bJGxYK2dN69lgV38C4jHoTfc1y8Uxr2NawqPhxEI4k57cW3kwuGDiMP21iSOgVKxkDEm+IJkS74qSWND9YmnhURO17gnsYQ26O3L3bIHvKb1HWs3eIJOQ1LSkf4LFrefQe3e4Di9Mv/VCuHjVI0eJqqOfHc6X4YeOX4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yK24KfMozkMUMHxi4t/9xmHkQORWks/mpdbKTi8KK0E=;
 b=XO1MLBuYgdCfElpsLqvnvqjoTEiKQTwPXWaLY4cU9oW5OrBNNdEBw0R7+bXOz//a8c2axPjSFPX20qRjDWIaERma275CxfI5JL+YebWWuXQeT8PlsqvPz+m6glHmtF46ZP72tSQXR1EZ8hI7huNwhBz0wPt85v1IEGIG/Nku0zaaz6NHjByyG8THavFHWAkbiVnw6U/MF2LC05HQ60Cu8F511DzgRPpBukRq3IXA9cxs2JmsHONSTpVmRIAF8f23kdsPIJKc2HfSFMykmPllWGXn5UaZgvRc/wtYIljy476QfbaqzjT1IBGD61D/zN9o+WQ7+lHJskBVRMTBNljeXw==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 10:22:48 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 26/35] genirq/msi: Provide interface to retrieve Linux
 interrupt number
Message-ID: <20211213142248.GB6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.780824745@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221814.780824745@linutronix.de>
X-ClientProxiedBy: CH0PR03CA0020.namprd03.prod.outlook.com
 (2603:10b6:610:b0::25) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aa1da8c5-cae6-4fb4-22a6-08d9be440b21
X-MS-TrafficTypeDiagnostic: BL1PR12MB5350:EE_|BL1PR12MB5127:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB5350E370413999F60386C546C2749@BL1PR12MB5350.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	35Tpxl4cHaUSO1IhKQCml92Pwk9LFdtamtoydMjJDziXfMHzuC6KsBPNy5fJS+zDhw2Wlh+IVt9NNhruvoItwT2xBhZoxUVZi1U1GLLsCDZXC57zNd9mbesNaJ8sFf/v5y/YkiceG+ao9Nc8on00GG+Ar0dbzGlI21QZAxu88aMUaEko6VontlldfFSwUU2xtcxddntVzSHihKCatDJrPztWEqDIzwjpNe8W+DbWRjTpsPDWQemS5z9T7A8ROAYp0ReIVPUzfaQ4l81IZoFvmQfx+/jW2htHzza73+yVOdG8+TwCHVFijXWMKTXPAjuNmNvYxj8b9Y0pK0Fk6zLLDLo4ydjIpyrV9RatB4qWaMzW0D1miiiU/OONmwVY+ZMwe9bMBU/5ceqFDvNzV4tM8bPHtEVChQ5kM/AN4XVUA1K52gRxNAXP0DSa0dW3kUkSjbtSuBKdgRvU2pkhUFW/ICzci+a3X7r9W/2cOmkWFvsxijCV5S2/JGaPkZbd4AZ8hSzvLCk3GIR99VXAUFYvvkJCPS4nfVOVgztg0uU3gdlWjqDP2ufN7e23gw7Z6qzCW1J23vFBv9KW/OGOByrSOn0hwzbOU6z3AGRyN9B8IlqGe8OAb/fJtNdLiH+tYVAab68oQWT8QiCTW5IFup+GRw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5350.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(38100700002)(7416002)(1076003)(7406005)(6916009)(8676002)(54906003)(5660300002)(4744005)(6512007)(2906002)(33656002)(8936002)(66946007)(4326008)(6506007)(86362001)(66476007)(316002)(66556008)(36756003)(26005)(508600001)(6486002)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?w07Q7xHudYgP5K3fklSjRYjabRdXPY0DZua12bI9cKqWSiXmAcBTMnnYsiaM?=
 =?us-ascii?Q?awQtxVHYbG91DXomgFe3Y9/s7hWNUfOrJ3WuNwWWmQpiVg+vXZ8eU/vOixUC?=
 =?us-ascii?Q?ve7U9DQI1pcp6RoxBav6IqDnNUs1fVZ8Jh0QzuYD9AD7I2HopxhiHnaMRxx1?=
 =?us-ascii?Q?pNrVBIdsLDGHHOBs1m8hwRm/huMDrCGPvCVyfRBjt/Zujutsfq6ROt0pmjEH?=
 =?us-ascii?Q?nGSmzS+KtGyAucHVkKnNspf5uTOkl8GIFd1rLB/d7EtH3T1Xw+WYsE+q2CSJ?=
 =?us-ascii?Q?kEDfg40P6ZTdiT0mAD+w2IzkCm9I9z+RBUz4zKlrUsJQczQKIcu6DmFyeG1Y?=
 =?us-ascii?Q?HX06i87iGo0wnd5p/fyKi4xGeCcMnfTHlSN2clQ25KZ8FxgNG+vho0LQL8eo?=
 =?us-ascii?Q?Rmyt8VHbhdDRHQjblaqFbSLCggRF6O3hgTa4Hw5MXkE05wOMsEuLxQDSGwwS?=
 =?us-ascii?Q?AJlwijXzTK2eXLcXmnDNGfoXGsh4DnsOfVLadaDIumdSbNoi+h17JNSvea2b?=
 =?us-ascii?Q?ccG7Be2yFXv+nONCC0oFDkNneVJdZwqHDER0CZafmyoW/YXepU3ODAD2bF2J?=
 =?us-ascii?Q?hsOhfF+ZIkL5Z4+4IUUm3YjKG+nwlo0UwSbe6L8S0xGxc4Bfcx6LB5bJyVYl?=
 =?us-ascii?Q?Yf+gK+Q6YQaBtksILIKsktz+kV/rRks7UyPgWi8rjtNa2Ecuhr80vG+vxoVu?=
 =?us-ascii?Q?Iqscg2kv66oCEY/YULaHY2Lb2Xhn4fGGfwph2G6Hs6Rn4b6b2i6I8bP7tRsg?=
 =?us-ascii?Q?dpHi0mEmryWdwfDBOFu4EAM1zWZwec/A3ZZNzkuZEOVR/cexMQftqK4Q91Gg?=
 =?us-ascii?Q?LYVPbXcYvK4aaMSoeBRLkk1V5fvUvbxM0NDnxVCgpdyd6vFravpyHysMEh7k?=
 =?us-ascii?Q?kvRrZsvPK2esmZsBUbcNGrsMSAfCR41XDaKP3plD7WCcvSyv6WkJz4ukScLc?=
 =?us-ascii?Q?3T+xpMJf65nFycz3WyaO/p/D0ItVYV1loLsyuC3pZC7pbwgaLguEH/TLPdnB?=
 =?us-ascii?Q?JNF+2+MK18uPJv54h+Ku51U0yJ0dsENrz68Gb/65uVmuavNhueDY2L1NpPj3?=
 =?us-ascii?Q?B8JkB6fCcUVvgeX+h6uZTYV6IYClvAY+NKHzcuiOuGqqm/6kYyaWbuFpENyU?=
 =?us-ascii?Q?LVHbfjkTAuwW7DUWHgc2xLaVmGlvDijWbC/W6v3kCy65lDq4TNob7qM8mPwb?=
 =?us-ascii?Q?mLNkiV7Ccd/TjFkLJ4wRzv2bRKx/UaXvhz0VYMIy/OywlVzDSetKqhYrLSxt?=
 =?us-ascii?Q?YW4UhuHDX/3tBqTrpiGw8GQt2T+B1YawaqB+CRuPoqIokk1Jwn5yXPka78U2?=
 =?us-ascii?Q?tjNZdmH7d+OnF7qDecmvOBYWp5cHl1LWjPQi0ILdNscRYNjVYwVI+D31fEaA?=
 =?us-ascii?Q?PH5saITWlTEyc/3e146a21NcIl/ScQ80ACXdD9s6KTGqD2J1qhAa6WZ1LzEb?=
 =?us-ascii?Q?up3vk12JMlhambWJ5vc86CPORoIc5WRGtng96lTAMAWNBoshRKAYV8bN9437?=
 =?us-ascii?Q?KXdpyo1hr/CN34v/F8IGsQP1VCLb70RDyGnWuC2jBML+EYnz+vKn5KdWbVgi?=
 =?us-ascii?Q?AnZj6NclHG3QKE79Uw0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aa1da8c5-cae6-4fb4-22a6-08d9be440b21
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:22:50.5744
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JapLzHME14gHzXjZlQNHkEcieJbQiuVCTbkP7m4IxstaQCCH8qZeTkkbUettVX0t
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5127

On Fri, Dec 10, 2021 at 11:19:23PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> This allows drivers to retrieve the Linux interrupt number instead of
> fiddling with MSI descriptors.
> 
> msi_get_virq() returns the Linux interrupt number or 0 in case that there
> is no entry for the given MSI index.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> V2: Simplify the implementation and let PCI deal with the PCI specialities - Marc
> ---
>  include/linux/msi.h |    2 ++
>  kernel/irq/msi.c    |   36 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:23:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:23:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246119.424516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmEk-0000t0-2R; Mon, 13 Dec 2021 14:23:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246119.424516; Mon, 13 Dec 2021 14:23:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmEj-0000st-Ut; Mon, 13 Dec 2021 14:23:29 +0000
Received: by outflank-mailman (input) for mailman id 246119;
 Mon, 13 Dec 2021 14:23:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CKkq=Q6=nvidia.com=jgg@srs-se1.protection.inumbo.net>)
 id 1mwmEi-0000sf-FB
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:23:28 +0000
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2062a.outbound.protection.outlook.com
 [2a01:111:f400:7eae::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b376efa-5c20-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 15:23:26 +0100 (CET)
Received: from BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13)
 by BL0PR12MB5523.namprd12.prod.outlook.com (2603:10b6:208:1ce::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Mon, 13 Dec
 2021 14:23:23 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com (2603:10b6:208:1cb::22)
 by BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Mon, 13 Dec
 2021 14:23:22 +0000
Received: from BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11]) by BL0PR12MB5506.namprd12.prod.outlook.com
 ([fe80::d8be:e4e4:ce53:6d11%7]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 14:23:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b376efa-5c20-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BuHvCSV5d2vACK8wVjcXijViROigYc/lf7KdVhJgHA95goWmYi8VsqjDAV5CpijW3TzQ1rCO6WRhCx/HWwH2ogWQ/4hM1k+YWEb9YhkMLWrsrnPNJR0XlwKz14hnsifQhiddRYava8iRHq9nvrheUTm/hHQ8hIzgspjVU2lYxpYWagubua6lhNf3Z5H+iOjhmkBT/mwjLzV3JHTpKzLzOkIXlluf1per3yuw7KDAcikoz0Etjul8R+RMJi61Sznvp5aP3eCz0RR58tNfv+CcBV+vjXwx1WVrEDFBl6JSO5Q0fXo6b604Ljpt6m6sm0MxjZtdGuVaQ6hIG3lWR2XipQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hcvkLSxUrexFwmEl22G3OBeDexHDcm8N7OZdbKxaJBU=;
 b=bYGmqWd5rWbmzk5GH2+er0/GtFfUUIkkB0ajq1T+RmnPTSmHbiTFwGiWSmtxRFFpEVUrdi75YHsDD9LSu3OwHLCoZo8kwvGYXAxFalja+SZT53zqCEidARBpL7Lms++P2XttBEYbpk3Shxh8ZJXknjx5fO9ZjmJ9zsOhqkYVE40uoHPcYBCWdSbfowX0FC8pdiW36L5IylJE7JiFHHT09r3z8m0D3X3j5Ots6DSX1GCfNZlax406oQ5wf5iF/TJinXxKNIfrxTq2HQAbRDykhXG/R6V5HV3VXJo1VpSjB+f49OuZn0Eve673jR39WNI6EqJBUl0Www1bRU7Nm1n0ZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hcvkLSxUrexFwmEl22G3OBeDexHDcm8N7OZdbKxaJBU=;
 b=bdyG4ZJrDwpVcIaTLObgZApxloyne5u3LUVX49qJisqSyuXnykwi8e0c6fGUGgpib8N1aDh8GeNtK8Ph3tHlhNWBrz7oH0CKEeSr86fojY9WNtIQw5PMeDMq9QfvqWmZ8jwlE+wcaRNX4OqO9fFW55Q0sDWBlNBYKRy99szMNRDFKEr6GqR/18aN+u+sPYvRTQr8GBT4rAGg69ZHTzKl0tRRbiyH1+zLk3wtmSVev1VfZBEDvplB+czEXMyjKec+hZgAgY7H4S0PlWGhBxGLg/9jzPsim5+ZymsjTJ9jjMj+k5IOITCUkt8s0NoNZ2YKODUILX6u5aZ1/3llojyMnQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
Date: Mon, 13 Dec 2021 10:23:19 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Megha Dey <megha.dey@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
	Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 27/35] PCI/MSI: Use __msi_get_virq() in
 pci_get_vector()
Message-ID: <20211213142319.GC6385@nvidia.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.841243231@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221814.841243231@linutronix.de>
X-ClientProxiedBy: YTXPR0101CA0034.CANPRD01.PROD.OUTLOOK.COM
 (2603:10b6:b00::47) To BL0PR12MB5506.namprd12.prod.outlook.com
 (2603:10b6:208:1cb::22)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9113e18-d38a-4d89-55f4-08d9be441e0c
X-MS-TrafficTypeDiagnostic: BL1PR12MB5143:EE_|BL0PR12MB5523:EE_
X-Microsoft-Antispam-PRVS:
 <BL1PR12MB51437D808E60C0DC80DDBDFAC2749@BL1PR12MB5143.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3276;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SiIReGv5ViTNmRUm3GWfQ/6oexO3oFbF+wAE1ske0bIY++8NRNVljaR7Rq0Q4tbhfzIIasTrhjolWthJ34jxaeOIER20SV+dC/JFs29fWOCK+ElO3foLNTacI9c4bsf9d3MdJ+KlbcUDObQHmZb5AU4r2K176/MH6nX7Xnb0pLtUdwIE5JjRV8n7TnZQQ5WOG8/uQQw3BAi110uk3/C+xo/iiBFmF1QchF+HzWMmsoNdR2LfepBjJKp1Nl+b0cOy0UsuJjgJ7Yd0tceNaLPmlwfN6k3vbzlhWdv54a/amVjl1zr9/WPxPFnZKsP82k4Q9KAwtE2TbWh8SABMvL9lKLmDshSwTNgpCXKDqq8ywPg1LibnpvYvmi3ckcruevZJqpTx2IrObzQ8+v9GWZM8up8Xb9+UcqPgz62cyZMJmqED5rWICLH/3FP1i46qkIOh7B61WvGRnP7pm7RqT/gf1RyPrp5EQxXn5If8w1/tkhQHERq+GKP7GldFRzzYfwb42gNR2RVF13z5mTmg64aaWBDMWX5XqZT5AXbPb4MVPfx7sVlGqhQAg/A9NIKyWAxfCkScJgSIlUrqoJknaXgVRpbtrWsHb6FdGBEPNUmy4e545pqzTIPbI3OaMH7GQJIk8qkFQGzF9PFNxAHzwdWIpQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR12MB5143.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(8676002)(8936002)(54906003)(2616005)(186003)(6486002)(6512007)(83380400001)(316002)(7406005)(7416002)(66556008)(6666004)(6916009)(26005)(4744005)(38100700002)(66476007)(4326008)(508600001)(66946007)(5660300002)(33656002)(36756003)(1076003)(86362001)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UdZTbKneE6nGhVTOfihQqiTo1Qt4/yNIfP6Lj5FtBtkuj97TWidSSaO4TLxr?=
 =?us-ascii?Q?bu4POC9xFVAX8UBm9mdW05nSbiy7F4ZhivLsX/eweXPVBe39pfIWuYdk3Vsc?=
 =?us-ascii?Q?v0yrCcknH34HzUGsvF5h1HTCBHgWK/zaC4evj+WNWRI8g44zx/ibqMOmh2cb?=
 =?us-ascii?Q?EsER9bQgPEZdLJKGisWmuADjVT51meMdyX1B1ykqBv3krcJxaJeEGwfPYoOW?=
 =?us-ascii?Q?bxaI1swyppyF51HoxXo6jWc/ArXumWJxPl6xKVescIn5+rp0lTcg9exmDNb/?=
 =?us-ascii?Q?i22cu+3qTPml5EyxBol1LdYZFv5tErJ9+HM2lqysZei+2oCuhkOGp9VuHIfH?=
 =?us-ascii?Q?qUrKEbeN6wA8L37nUeytPUOW4DCPXvVruqn7Bxr0biAiJcA27aWIW1xeaj3A?=
 =?us-ascii?Q?VqBEcTs/lPiilABweeZWiQ1Sez/9gl/64Bbfc5xBLxNr9j8uEQGguACin8iP?=
 =?us-ascii?Q?WGAEjM/vOclCHNY8bq3ObcG6GRLvhW7jtb+2uYJVPYoWhvSzzA0z411PSFBL?=
 =?us-ascii?Q?qDfiTupTvFIZT5Y34vQYeqQ4SmbczYDysFOf929KCHHobmLoQ8BFwIMX+Hb4?=
 =?us-ascii?Q?WNZMPWC++yrHsfZxoMGJFXjCK4b3PoCtb6VlrB4NP38XxojEoLpLiLf5sRD4?=
 =?us-ascii?Q?dEHsa+0pCbz8gOzO63M9QEMvkyLozYkZjVhBJNQ0QktfJBQxiD6CC4BC1PNf?=
 =?us-ascii?Q?nmMhcxXdtTtySEbHsGAL3caVmBmg4vqioyhWLE6/Pv/dvDvjkTlBhXXHCtPP?=
 =?us-ascii?Q?itZUmhtIGzsgSLaNAxmdZyKCuyZ/NbaWK6phedCjfo1/ztIH+NitdwgB+A5T?=
 =?us-ascii?Q?+qKnbcvex4TIcCtaG/zzDBAGQT6gOvwEq4eLKj2J87Dm03QZKnIfIgcWip5F?=
 =?us-ascii?Q?KsUVIVWDSZZCyoOusUDo5NR9n86PgGpB/GWZX8IarGKmUaG73577JTGuWT8+?=
 =?us-ascii?Q?PPwg1M7LWnVIBJernM9U6ZcUvAaeKp3Hszh0ZANacC9fLjyDyhxHrlSkX5/1?=
 =?us-ascii?Q?CtSdpqXTFFqkqmqTBm8S+m47L0PumiedW0tCcAeyo2BJQIaC9kiL3dsmnwEd?=
 =?us-ascii?Q?Z7Cfy+y0qEK0d5dHMIOqatHqWZjpJcFoMyha4qgc6pDuRIi3uZVQi6wwSJdb?=
 =?us-ascii?Q?c641Backr6RtQgg9DmFVTikvzqA1M2APqN3XCaCdfIaS0SVrQFNonXjMfoN1?=
 =?us-ascii?Q?mIZgYmeMEpxE/vksb8SoDiKy1TxfLMAPFldGYLna3SjDvz0TGqmf+BIhI1ZF?=
 =?us-ascii?Q?3PGmjQ5ZQN8ZQxCGLg4X3K2Vtx0+ezehOv3mQ9QV7jluiuuNNx7unZdGZDY/?=
 =?us-ascii?Q?27J8tGwy6lvtDMlORg14xso4hdE/uwAEbHQaYIgFJXvwDQMh8UFfytTB9up2?=
 =?us-ascii?Q?Alsa2UsvMel5kUDx/mgZBJRXqgxhuT0Oq4DPCDSk7ux+gt0ye2YUTJjqCVzC?=
 =?us-ascii?Q?DrBLTQHsDblBEmErZ0uskud4gqc97I3MLeh5QJhIPrq4OW2MvME/HxT5HbNP?=
 =?us-ascii?Q?h9UP+2vEJLOpgcOkSNcRQ5eiBZllrVbPOG9IrzVzzfPBCTS5zXVZOxxzqzA2?=
 =?us-ascii?Q?zfzIVl0PQTpLwbNQl1M=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9113e18-d38a-4d89-55f4-08d9be441e0c
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 14:23:22.2701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q/ECntS8fh8ZLrZFpJFupHNoZTpVITuBmuPCq8r5VPOP+PA6J6entj0tG44juQHF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5523

On Fri, Dec 10, 2021 at 11:19:25PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Use msi_get_vector() and handle the return value to be compatible.
> 
> No functional change intended.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> V2: Handle the INTx case directly instead of trying to be overly smart - Marc
> ---
>  drivers/pci/msi/msi.c |   25 +++++--------------------
>  1 file changed, 5 insertions(+), 20 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:56:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:56:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246145.424547 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmkc-0005ai-6l; Mon, 13 Dec 2021 14:56:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246145.424547; Mon, 13 Dec 2021 14:56:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmkc-0005aY-3V; Mon, 13 Dec 2021 14:56:26 +0000
Received: by outflank-mailman (input) for mailman id 246145;
 Mon, 13 Dec 2021 14:56:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/ja4=Q6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mwmkb-0005YO-EB
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:56:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d65b574a-5c24-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 15:56:23 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 5167921123;
 Mon, 13 Dec 2021 14:56:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2D53313DE2;
 Mon, 13 Dec 2021 14:56:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id l+q1CRZft2FWNwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 13 Dec 2021 14:56:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d65b574a-5c24-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639407382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=j7cVxE04IfsTIEumjoh0h0K2JpqO07CGgJNiGKv+uYU=;
	b=rTwGDY9Uw5nUopNc2mxAT8fkgtxzs1B/+a6gkCcbxVvv6fX0JD/YwJxlI2sBomnSIB3cwX
	MpqMQBL+0u9yDAtWt9av48q3fFqmW3GhSwLF9m14U3nseQb48FiK6jNId1+9O3A+9cIqZQ
	0yfvDtB4AQlvH6rzj/d67Q+GB7eqv9Q=
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
 <20211212000558.232nzs7k5lklpbym@begin>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
Message-ID: <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
Date: Mon, 13 Dec 2021 15:56:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211212000558.232nzs7k5lklpbym@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="IAFzW0f4rRLv6G6aH0YvjuKBDF6qBTSig"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IAFzW0f4rRLv6G6aH0YvjuKBDF6qBTSig
Content-Type: multipart/mixed; boundary="eYeR0dxD77OMlNuDhk2i5UNuo2LM5MmRq";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
 <20211212000558.232nzs7k5lklpbym@begin>
In-Reply-To: <20211212000558.232nzs7k5lklpbym@begin>

--eYeR0dxD77OMlNuDhk2i5UNuo2LM5MmRq
Content-Type: multipart/mixed;
 boundary="------------9740D0F2639D38120BDF7612"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------9740D0F2639D38120BDF7612
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.12.21 01:05, Samuel Thibault wrote:
> Hello,
>=20
> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:29 +0100, a ecrit:
>> - align the entries to page boundaries
>=20
>> +    /* Adjust map entries to page boundaries. */
>> +    for ( i =3D 0; i < e820_entries; i++ )
>> +    {
>> +        end =3D (e820_map[i].addr + e820_map[i].size + PAGE_SIZE - 1)=
 & PAGE_MASK;
>> +        e820_map[i].addr &=3D PAGE_MASK;
>> +        e820_map[i].size =3D end - e820_map[i].addr;
>> +    }
>=20
> Mmm, what if the previous entry ends after the aligned start?
>=20
> On real machines that does happen, and you'd rather round up the start
> address of usable areas, rather than rounding it down (and conversely
> for the end).

I think you are partially right. :-)

Entries for resources managed by Mini-OS (RAM, maybe NVME?) should be
rounded to cover only complete pages (start rounded up, end rounded
down), but all other entries should be rounded to cover the complete
area (start rounded down, end rounded up) in order not to use any
partial used page for e.g. mapping foreign pages.

>=20
>> +    /* Sort entries by start address. */
>> +    for ( i =3D 0; i < e820_entries - 1; i++ )
>> +    {
>> +        if ( e820_map[i].addr > e820_map[i + 1].addr )
>> +        {
>> +            e820_swap_entries(i, i + 1);
>> +            i =3D -1;
>> +        }
>> +    }
>=20
> This looks O(n^3) to me? A bubble sort like this should be fine:
>=20
>      /* Sort entries by start address. */
>      for ( last =3D e820_entries; last > 1; last-- )
>      {
>          for ( i =3D 0; i < last - 1; i++ )
>          {
>              if ( e820_map[i].addr > e820_map[i + 1].addr )
>              {
>                  e820_swap_entries(i, i + 1);
>              }
>          }
>      }

Hmm, depends.

Assuming a rather well sorted map my version is O(n), while yours
is still O(n^2).

In the end it won't matter that much, because a normal map will have
only very few entries (usually 5 before merging consecutive entries).

I'm fine both ways, whatever you prefer.


Juergen

--------------9740D0F2639D38120BDF7612
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9740D0F2639D38120BDF7612--

--eYeR0dxD77OMlNuDhk2i5UNuo2LM5MmRq--

--IAFzW0f4rRLv6G6aH0YvjuKBDF6qBTSig
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG3XxUFAwAAAAAACgkQsN6d1ii/Ey/T
6Af/ffa1ro8nIoFT9rqUrMD4+zE0MDXNfA6ALAGIQgYN2C4K3CaBZQcObHjFxFtlKSuBhOgovOl9
cIpLS/aQHhQ3jw1rlGK5FeY6fc1XPqMq8nXvJbjL07pmpB2bwbFlyqpRttEc+Qsg5eUMtY2OLmMZ
zSTgo2BGFfhplkGkT/79ytvMS8k9Y0SeiNa+J1vVUrX7cN6Tltn/6KwKLxyiYYVL/6ph2bfqItwS
eFHNhHKFEIwOhED+fblcnjhVn3wM2qDzhWn+C79KbDUGOFG42fLRnM6xbFBIa4BgkOq4ZwW5tQUi
1488mBtZbBUliW7xrAfLKm4OEsYB6gVLibI7W99u0A==
=CHAl
-----END PGP SIGNATURE-----

--IAFzW0f4rRLv6G6aH0YvjuKBDF6qBTSig--


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 14:59:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 14:59:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246154.424563 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmn8-0006VV-Mf; Mon, 13 Dec 2021 14:59:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246154.424563; Mon, 13 Dec 2021 14:59:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmn8-0006VO-JT; Mon, 13 Dec 2021 14:59:02 +0000
Received: by outflank-mailman (input) for mailman id 246154;
 Mon, 13 Dec 2021 14:59:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/ja4=Q6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mwmn7-0006So-07
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 14:59:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 339600a0-5c25-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 15:58:59 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id F19AE1F3B9;
 Mon, 13 Dec 2021 14:58:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CBA1413DE2;
 Mon, 13 Dec 2021 14:58:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kGmFL7Jft2F9OAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 13 Dec 2021 14:58:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 339600a0-5c25-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639407538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zurqn5UDxl0JDJcf5v6FfEBfec82sylpyBbRFRa/6YI=;
	b=CxhDNSX8FinoGB1L5cZc/lxKYuF3qhjYRmnVix9nq9ESMVHV7zBvKT1Y/y6aR60zIJUU27
	u0FhlbNKHTk2jXqClGrNKzvRk0XbmYqKpMGxrz87pUSzb4y+SY06P9pQp2uPCkw3WTktxT
	Pbxm4xESdSbGSRe0NAyxP+YLELOc0Dk=
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
From: Juergen Gross <jgross@suse.com>
Message-ID: <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
Date: Mon, 13 Dec 2021 15:58:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211212001542.qhz7wfdwq7k5ymxr@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="5l2iD5t6rMNHYWVMtsa1YRUnFkiq12ncu"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--5l2iD5t6rMNHYWVMtsa1YRUnFkiq12ncu
Content-Type: multipart/mixed; boundary="e3LXZZSMPTqrrIGTauAXG641EU8VjabVd";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
In-Reply-To: <20211212001542.qhz7wfdwq7k5ymxr@begin>

--e3LXZZSMPTqrrIGTauAXG641EU8VjabVd
Content-Type: multipart/mixed;
 boundary="------------268835E92D5168298BA9F1DE"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------268835E92D5168298BA9F1DE
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.12.21 01:15, Samuel Thibault wrote:
> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:30 +0100, a ecrit:
>> -    unsigned long pfn, max =3D 0;
>> +    unsigned long pfns, max =3D 0;
>=20
> I'd say rather rename max to start.
>=20
>>       e820_get_memmap();
>>  =20
>> @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
>>       {
>>           if ( e820_map[i].type !=3D E820_RAM )
>>               continue;
>> -        pfn =3D (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
>> -        if ( pfn > max )
>> -            max =3D pfn;
>> +        pfns =3D e820_map[i].size >> PAGE_SHIFT;
>> +        max =3D e820_map[i].addr >> PAGE_SHIFT;
>=20
> since it's it's always the start of the e820 entry.
>=20
>> +        if ( pages <=3D pfns )
>> +            return max + pages;
>> +        pages -=3D pfns;
>> +        max +=3D pfns;
>=20
> Here we don't need do change max, only pages.

It is needed in case the loop is finished.

And this was the reason for naming it max.


Juergen

--------------268835E92D5168298BA9F1DE
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------268835E92D5168298BA9F1DE--

--e3LXZZSMPTqrrIGTauAXG641EU8VjabVd--

--5l2iD5t6rMNHYWVMtsa1YRUnFkiq12ncu
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG3X7IFAwAAAAAACgkQsN6d1ii/Ey/o
5Af+NX88Uja52iDBy4HAhF+kUjk2NNlsKfBnbQHQn3ZI9aJKdD8CAunZO3UJMUWeAAOdkrRWehHR
k/wIIMkJgxP7AA0autwMaG2jQhNE4sP8uq533wj9P7tz0emuGMe8tNdmUbOyjy1Ha130cNrsf6Ca
oC9nDTq0p9LAJ/T9hfbdYKk52Ip1UUP6ceaRzZEWJFPuLoofekm7Apda3K/KTw2iOZgkc2rUjhEM
bw6dd8FXsHhSBg+Jo3KJA+Ig4PZKItiAQOMS3iy3et+zGKvF1/VTezNHd3CMKgV+H/KhrymIJkbG
XdYG1bsdSTXJikBcYzqegb6HygIZxNx5QjtNBjSXUg==
=0t8/
-----END PGP SIGNATURE-----

--5l2iD5t6rMNHYWVMtsa1YRUnFkiq12ncu--


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 15:04:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 15:04:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246165.424575 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmsR-00086T-Am; Mon, 13 Dec 2021 15:04:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246165.424575; Mon, 13 Dec 2021 15:04:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmsR-00086M-7h; Mon, 13 Dec 2021 15:04:31 +0000
Received: by outflank-mailman (input) for mailman id 246165;
 Mon, 13 Dec 2021 15:04:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0LF=Q6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mwmsP-00086G-Pb
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 15:04:29 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f5b096ab-5c25-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 16:04:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f5b096ab-5c25-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639407867;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=leu83rDoSXRjn4EAFrknbpmEB40yjnyBILmRC+G5cus=;
  b=DrgzGSaYuz5qb51OcG6CrOwAzmTShaMpdoRA0pvAzE3pPM6Twx458aBv
   Jy6eGUZcGS3vQn7MnIUYIaFv7RycosC+hYOPFji5QeWmwipFUFNy366pZ
   v2IjxwVasyP37uWhTlWOcHmGkSqRX+qwupS9+mZONEf7wfsJMcQ4QP0Ye
   g=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Zm1YKzaLKr5snSc/mymHoS4frnN7FuOKjLIK4D9KxX7wvJjJfwsWfn5dqAzfwy74zu49nUEczM
 8JUUKtTdCeAVr+LfAXERWoLxlRIdnEGgCx7saF7gWLFNhZPwF58YmQ8T7rRWOLfj3VOJJsVWqo
 vs1ospLvgGPjYAsfQ4DO41caGenRceoHAmwUZzkWgRQdQNMtQXEJRVzSCTT6TXAoatVvC5MTFo
 +ExpuqU7dGTtap37k3mIFCR1GkgOkn2a2ep4Yoxvu/OkVvB9GKeNLWFcqLX0fhcYHsPVS145bd
 Z0Vrd87iezOmBJOrEiwrDItg
X-SBRS: 5.1
X-MesageID: 59835844
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:NoWE+q2Wjd7PV/FhUvbD5Y93kn2cJEfYwER7XKvMYLTBsI5bpzNUm
 zQbW2DTbvjZY2L1e95yPovl/U4GucDWz9FnG1FppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn970Es5wrVh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhz/Fpl
 tRE6qCLWA44JLPAuugUf14EOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1EnMMsIdOtJIoCknph0SvYHbAtRpWrr6DiuI4Ih2pg2pwm8fD2Y
 eUbYDlIfBH8WhxjGUpOLsJ9tumaiSyqG9FfgA3M/vdmi4TJ9yRv17zqPMvQa8a9T8xflUaFp
 UrL5238RBodMbS30iGZ+3ihguvOmyLTW48IErC8sPlwjzW7/GUTFRlQblq9rvmRg1S7HdlYL
 iQ88Cc0sbI78kDtS9DnRgC5u1aNpBtaUN1Ve8U49QWMx6z88wufQG8eQVZpeNEg8cM7WzEu/
 luIhM/yQyxitqWPTnCQ/avSqim9UQAXJ2IfYS4PTSMe/sLu5oo0i3rnTdt9Eajzktz8Hxnxx
 SyHqG41gLB7pdYCyqGT7V3BxTW2qfD0ohUdv1uNGDj/t0UgOdDjN9fABUXnAehofKeBEFiI4
 0Q/isGP9v4CL52EuGvRabBYdF223MqtPDrZiF9pOpAu8TWx5nKuFbxtDCFCyFRBaZhdJ2KwC
 KPHkUYIvcIIYiP2BUNiS9vpU5xC8ET2KTjyuhk4hPJqa4M5SgKI9ToGiaW4jzG0yxhEfU3S1
 P6mnSeQ4ZQyVP0PINmeHb51PVoXKscWnzy7eHwD5077uYdynVbMIVv/DHOAb/oi8ISPqxjP/
 tBUOqOikksEAbalPnmKrN5IdDjmyETX4ris9KRqmhOreFI6SAnN9dePqV/eR2CVt/sMzbqZl
 p1MckRZ1ED+lRX6xfaiMRhehEfUdc8n9xoTZHV0VX7xgiRLSdv+tM83KspsFZF6pbML8BKBZ
 6RcEyl2Kq8UEWqvFvV0RcSVkbGOgzz331/TZHT8P2BkF3OiLiSQkuLZksLU3HBmJgK8tNcko
 q3m0QXeQJEZQB9lAtqQY/Wqp25dd1BE8A6rd0eXcNRVZmv2941md374gvMtepleIhTf3DqKk
 Q2RBE5A9+XKpoY09vjPhLyF8Nj1Q7cvQBICEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iquYCnARpFXnGdXqxDbZkLiXU1MVDrPQVlLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtflseRf0/i56+raDQH5+BRjUhXwPNqZxPaMk3
 fwl5Jwc5Tugh0d4Kd2BlC1VqTiBdyRST6U9u5gGK4b3kQ53mEpaaJnRByKqspGCb9JAbhsjL
 jOO3feQgr1dwgzJcmYpFGiL1u1Y3MxctBdPxV4EBlKIhtua2aNngEwPqWw6HlZP0xFK8+NvI
 Ww6ZUR6KJKH8ypsmMUeDXunHBtMBUHB90H8o7fTeLY1k6V8urTxEVAA
IronPort-HdrOrdr: A9a23:UCWcwKvemb4DYAbT52gSvs517skC74Mji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCD8qhoPRPAh2Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5nUUtKPpZ0fSKGMB29ffvyChPgHb3GLtBPB5ufke++3F0KjNvaDaDgiqFC36
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,202,1635220800"; 
   d="scan'208";a="59835844"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WOa+jzTdIPidmm/ummHH8SC07leMO0++73hIRd4btnqmf9OEQNfwXxwI/cDQRAcjFFGYR2nfDftVtpRsx6zSofqG92OxbpFPrZvv80Yl01A0sNw984bERJLIF6bPgc6DRoZC1AxknbvOkw3zoVQZ0STp+FDrPDtECybtrSwcolw5zvcVpNpAzJLi8S/j+EhXXtmkAebJUrjVcM73qySTUCJ2DHNbIrXOSkzWxWNUWdQXlsIt1aAAywDmhh9CSX4XWwuBwJ+n9IfiPj4FrzZSy/YihlnWyDNafhYhTdhBQkx83X1fOhBnUqb4IlrZdx2Ew1XoMfu2/ooCX9qU1RPYZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KmoTZP7pdgDxqssA+7fJec2uWa9cA3TctljcGSNgq4U=;
 b=bda9sAbTOX4ikCcahBNKVzjcF6KaIuBjOjpDEMXzqL+aAzQjHOOM1oeAFJFLI7rGD3LQZVYtH44kRLS4hwFhoGHIVu2RsEJpO3LAeJN+bFKzkKx3Jg3atf3GqegRtos/We+uJs/3uFYsW0mfcgyZCVUMxGrfBx9b/xJisrf8EP0qCnq5pLvB+WUjNVEws13R2VTm3N5mGjjtGqd/+d7wm7pQy4wf7CJyQ44n+paZ8Fpzxcv5MKJTDjPrKEFVKO+oOwHEMnOvS6xQSOlorl24Obiggvby10IerJ+37IMtQXIuo0kzeWNSyy7yrc9RbSmEi4yGQrgT6vloYO0oseAFzg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KmoTZP7pdgDxqssA+7fJec2uWa9cA3TctljcGSNgq4U=;
 b=pe03tE1Ha9nUOB05CBW5KtSsNNABZgN9LXj+NGr2z9G2rNqEX8IEqlX25wf0IDlSkZP9ZIdpLrn3q/fL0nbVIjot1NTX0XF8oqlrFX/h3t5OEL6U0YG4nx+oY1UYQYVF4uVAHS7Ggo274w8Fr/mgsjCGh1uFBO/05HV0V6TiXss=
Date: Mon, 13 Dec 2021 16:04:11 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<Rahul.Singh@arm.com>
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Message-ID: <Ybdg6/J6oUf/5hEH@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
X-ClientProxiedBy: MR1P264CA0046.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::28) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3b8755a-6464-4907-ef55-08d9be49d574
X-MS-TrafficTypeDiagnostic: DM5PR03MB2715:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM5PR03MB271549A829646C2E9624475F8F749@DM5PR03MB2715.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CjHIo7+4BhgFDME0WIbos0zgfMPXv1aA3Z2gleVuvZ5zNX33Un5KnAFvbWcWcyqjBBmmENjRNxNxeNxQvEaAU1SMc8tGzr7/CE1nDU0f8LiK91poHJwXQ3fHW7yZyD8CGUka8wTpdR6oAwEIlEWSu4BGmBXn3xxTwezRZZE5+GTvqHzf/VLKbmc740ipUHquGWzRRj8u8nIsXESPrqDWAgpjBhhrY8MFLLK4Wa+v+uu4viE3+EJknUm5Ro7Id2Ic3+m3p3PhO6MeJvP8+iDtGNXJGmuTc0GYKHYYLEFPhn/TniQnWMhDrsHL6edLPSZYk5WEpe714WdS19jPU3+a3etAK5qqrIioZ0f8/1iL4sncrsMSOPZEfeLWrNLRRlvpEJoRd1q5iGx6FvekWGgSdtnBP5zSd57PScYpkeeUyco2+1DFKAmQ9OIM/nbLi3cXdKptpjny4esT2Y1vb0UTT85gR4CXNFAsBU9odH2SM2K3zFASFybW33iwxVe9MOU0PSe2S/TsXVS6JDcx4ZLi3E8EL11lJork46oQN9ETzqpxJNMpEczdGgCx1DLppf6JCvEOFmPv9+N1TxAnGVU7myxOyBElpGlSwuf0/TNayNv2jx9dP6XATVGcNJwjMmZZgoSs9ifcnajLtEpRrlnaSw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66556008)(5660300002)(2906002)(316002)(83380400001)(66946007)(33716001)(6666004)(66476007)(54906003)(4326008)(38100700002)(82960400001)(85182001)(6512007)(86362001)(6486002)(6916009)(26005)(6506007)(9686003)(8936002)(8676002)(508600001)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGY4WkZvTjdsOXp4aW9CdDBLWk5rcXlDeWJPcGxaN2hHZGxJWE8xUHVLcW03?=
 =?utf-8?B?SDRIcmU0RlJqT2dSNkQ2U3RZb2o0SnNTbWN3aERpdTE0RXJobVpnZzRTVGtq?=
 =?utf-8?B?bDdaakN2RW9SOWE3OHF5SklVb0NvUnBpdDVPTTZuMlFVYnYrR0hMVXpzMDYw?=
 =?utf-8?B?d2YyWWpoK3p4Uk9SeHhPSXhrOFBxTDJxYU0ybW9IeGJSNnNLTGpPN3JQbWUv?=
 =?utf-8?B?Z1hLWmxsOXNLTnBUTEovaU5OTW1CRUxOUG1ZT1g3OWt5MENOMVQ2cW1hdExU?=
 =?utf-8?B?eHc0dHFUYXllZzhFU2N2d3pyVEV0aTlma2ZnbFBMT1dLSFdmWVJHOWpPWXNi?=
 =?utf-8?B?dUkzbEtOdVVJYmlRM1JLZFo0UkZhdEhWWm1SR3VNWUV2ckszcDJlQ0hxZkM1?=
 =?utf-8?B?QmRQU2dnUG85NGpGckpCZjVxTzFRZG45YkN0R240cURMZXhrWFJVS1I0MnBu?=
 =?utf-8?B?TkhIVUozd3BzVlJXUjNPR0dyaFpLekpWUU11dHUvdkR1ZGxKMnVyb1JlU0p1?=
 =?utf-8?B?TUk1KzJOS2FDa1YwTE50TUhBSmFWZllXZFJlMXhMM0VYMGJ4WDdGMi9JanZW?=
 =?utf-8?B?dUoyK295bUs0ajA0ZHl6WTF0bWt0MTEzb29IYVg0SkRUUmd3Qmc1eE1nbzZz?=
 =?utf-8?B?RFJRbUE4TEZDSEEvT1V5bllRVXpTSWZBREgxQnVLYTV4bytNaG9jS2dnU2Yy?=
 =?utf-8?B?S0lPRHB3VXlTZkxNMkNCZFM5aTB2Nmk1bjV6VndPN24wclMzdkpHc2lEbkNU?=
 =?utf-8?B?dTRqcGhFSWM1clNrMUJZRmFSVHVtSkxQczhvbEtiVFE4MXBkZkZ6QlBkZXRC?=
 =?utf-8?B?dU1aYmN2S0VuTkVkazY0WjJmeU83M2N3LzJBdGxXckxUZWw2dmVRUkdyeS8y?=
 =?utf-8?B?YlRxbkNucE9tdkY5c3ZRZmpwa0xsK0I3NFE5ZWtHLy9JN0RSc1FNTXArVnJ2?=
 =?utf-8?B?bDRhUzRZRmJzVmtNR3BHanZNQ1FzVU9NS3A2RW52b0lyRk1qSW9BQVFMMHRR?=
 =?utf-8?B?TWlwc3pUcG5GVjJJdnhIR2Y1dkRLb1NvMVJxNXJRcVlKZERrQ2p4dVJnanlL?=
 =?utf-8?B?WEJZMGZDQ3pBeS9tOWFzRER0alVYRWgvR0grSjAwKytnTlhmcGR2My9pb1h2?=
 =?utf-8?B?Mll3Rjd3RVhSV0w3azVROXAvRnZYZ0pzak5OMndoM1dMdXlsNE5TTEl6Witm?=
 =?utf-8?B?UTRoaU13ME9Jc3FVV01nRmRWc3JXN2JDV1c0bUV6dUl1R3MwNHJWcnVJUTRE?=
 =?utf-8?B?eFhHWUhGWDZmRDQ0SG1sR3JKS0E1UGo2UVFYSUdnRDJIQUVHLzBFQmxjODVF?=
 =?utf-8?B?MThZbzkyR2pxZll6Skd0NUtWbkxibUxyZWVnSUFiL0RadFR3Ujl2QXlqZ0Nu?=
 =?utf-8?B?TDlqdGgxdHJ6S3I0ampIR2ZUNTlIRktLbnkrVk16cGFUcXhIWHFsVjJjQWUv?=
 =?utf-8?B?T0FWRlpmaVIyNVBnWWlQL01Mejl1NDBWTU1qZmtFV3Y3NEdEaFhNMjNHdGwv?=
 =?utf-8?B?OCtBak5OSXc1YW9HSHVIbHhmRXpYZGlEYm5UTGNzWHNIa011bEhoRFJ6R3F3?=
 =?utf-8?B?UlM0T1pxUm1HNkRhU0ZWdThQdlFocUs0VzZXRDR5MWIxMU93cnhiSTlsVVdV?=
 =?utf-8?B?OXpaQWZFYWhZQk9XdFJ6OEFRa2p0Q2xQVS9oOTNtYm1TTDUwdGlIakZjN1dG?=
 =?utf-8?B?Ym41UDExYW1OaWJZZDlwR3hXbHVLUFFtY1FqNjBMSkxGZEdkTHJZQy83RzR5?=
 =?utf-8?B?WktVOWFBMjBiY09pL2hKUmQ1R2Ztb081RHlLSVNGZDg1ajVqQzUrWnQwTS96?=
 =?utf-8?B?emRzRldYWXhJd0s3ZHZweEhlM3pBc2JRYURNeVhGSXlHY0RPblN6QnVjUmJZ?=
 =?utf-8?B?Y3NQckFDcW5iZC8rdjdqTWc2RU8xUmJPMmc0eENFMEpwNEpuQU92Uy9iVFNk?=
 =?utf-8?B?WHZIK1o2L0htRXBkT0pjZFcwVkIyc09vSGcybDNPSXlLbThMWDJXd0tHZEdO?=
 =?utf-8?B?MWcyTE9FcDhBWUtEd2pQSUhVR013MU1HdTJ2Q3RGWXVVR0tsK3JlRkdzMEtG?=
 =?utf-8?B?OGp3WC9GOWdDemhFRWJQSk5SSGNsZ0kzWjBMbkppSThoTUhoL2FqUW1qSW15?=
 =?utf-8?B?ejgzZDdCVkVBL2tZaU8wUUtiTHd4QmVpMnlTbXA3M3EvMmhJTFZoN2EvN1Rj?=
 =?utf-8?Q?jfG/BEz6bEv0Ec30tE3Vtn4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d3b8755a-6464-4907-ef55-08d9be49d574
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 15:04:17.6718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1mdxa4X8smygYnu8wtTOjuWbd/8ved9bGvfX3B/D0d6HrWq3Tyyu8CHxLJh/XYO1/tOhjz/oc9DTCa/GKqWQSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2715
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:53:59AM +0200, Jan Beulich wrote:
> Having a separate flush-all hook has always been puzzling me some. We
> will want to be able to force a full flush via accumulated flush flags
> from the map/unmap functions. Introduce a respective new flag and fold
> all flush handling to use the single remaining hook.
> 
> Note that because of the respective comments in SMMU and IPMMU-VMSA
> code, I've folded the two prior hook functions into one. For SMMU-v3,
> which lacks a comment towards incapable hardware, I've left both
> functions in place on the assumption that selective and full flushes
> will eventually want separating.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Just one nit I think.

> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -731,18 +731,21 @@ static int __must_check iommu_flush_iotl
>                                                  unsigned long page_count,
>                                                  unsigned int flush_flags)
>  {
> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> -    ASSERT(flush_flags);
> +    if ( flush_flags & IOMMU_FLUSHF_all )
> +    {
> +        dfn = INVALID_DFN;
> +        page_count = 0;

Don't we expect callers to already pass an invalid dfn and a 0 page
count when doing a full flush?

In the equivalent AMD code you didn't set those for the FLUSHF_all
case.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 15:05:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 15:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246169.424585 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmtP-0000IF-Ns; Mon, 13 Dec 2021 15:05:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246169.424585; Mon, 13 Dec 2021 15:05:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwmtP-0000I8-Kx; Mon, 13 Dec 2021 15:05:31 +0000
Received: by outflank-mailman (input) for mailman id 246169;
 Mon, 13 Dec 2021 15:05:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=/ja4=Q6=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mwmtP-0000I2-4f
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 15:05:31 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1c3cba0d-5c26-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 16:05:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3BBE8210F2;
 Mon, 13 Dec 2021 15:05:29 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B19813DE2;
 Mon, 13 Dec 2021 15:05:29 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iAxvBTlht2FOOwAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 13 Dec 2021 15:05:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c3cba0d-5c26-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639407929; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=43WTY6tloIhb+jp532ffO8lA63mPUVPlnlIrFB+zC54=;
	b=OuA1JUzGIkvlxq6t9LS1DvaihY0uIPZjo0qWbasVxtJf39XovX4PzkaDDccOtPxc3ojCJU
	Z66caCfB9ILqFADQ+mw2UnkUIQP7annmLgHr6youiRpdrt6aIqbGQ0m8utt21nOceE+xbY
	rvbFGvatNFTTrLTa/m/nqmoAKFxLm+w=
Subject: Re: [PATCH 04/10] mini-os: respect memory map when ballooning up
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-5-jgross@suse.com>
 <20211212002624.fmmebrd5sudcmco4@begin>
From: Juergen Gross <jgross@suse.com>
Message-ID: <0b7c86f2-bddd-b650-ed58-7e69e1b1c58e@suse.com>
Date: Mon, 13 Dec 2021 16:05:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211212002624.fmmebrd5sudcmco4@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="1WhaJPULB0DvvgYmQAFFoXOhtEQXABxqT"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1WhaJPULB0DvvgYmQAFFoXOhtEQXABxqT
Content-Type: multipart/mixed; boundary="LYk1sPWTt3gNdeLkHnL5vpHg85ia8zJ0d";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <0b7c86f2-bddd-b650-ed58-7e69e1b1c58e@suse.com>
Subject: Re: [PATCH 04/10] mini-os: respect memory map when ballooning up
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-5-jgross@suse.com>
 <20211212002624.fmmebrd5sudcmco4@begin>
In-Reply-To: <20211212002624.fmmebrd5sudcmco4@begin>

--LYk1sPWTt3gNdeLkHnL5vpHg85ia8zJ0d
Content-Type: multipart/mixed;
 boundary="------------4A99575EED9A2156AA6E4B7A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------4A99575EED9A2156AA6E4B7A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.12.21 01:26, Samuel Thibault wrote:
> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:31 +0100, a ecrit:
>> @@ -81,8 +93,11 @@ int balloon_up(unsigned long n_pages)
>>       if ( n_pages > N_BALLOON_FRAMES )
>>           n_pages =3D N_BALLOON_FRAMES;
>>  =20
>> +    start_pfn =3D e820_get_maxpfn(nr_mem_pages + 1) - 1;
>> +    n_pages =3D e820_get_max_pages(start_pfn, n_pages);
>=20
> I'd say call it e820_get_max_contig_pages?

Fine with me.

>=20
>> +unsigned long e820_get_max_pages(unsigned long pfn, unsigned long pag=
es)
>> +{
>> +    int i;
>> +    unsigned long end;
>> +
>> +    for ( i =3D 0; i < e820_entries; i++ )
>> +    {
>> +        if ( e820_map[i].type !=3D E820_RAM ||
>> +             (e820_map[i].addr >> PAGE_SHIFT) > pfn )
>> +            continue;
>=20
> "> pfn" looks odd to me? If the start of the e820 entry is already
> beyond pfn, we'll never find any other entry. We however do want to ski=
p
> entries that have addr+size that is below pfn.

Oh, you are right.


Juergen

--------------4A99575EED9A2156AA6E4B7A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------4A99575EED9A2156AA6E4B7A--

--LYk1sPWTt3gNdeLkHnL5vpHg85ia8zJ0d--

--1WhaJPULB0DvvgYmQAFFoXOhtEQXABxqT
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG3YTgFAwAAAAAACgkQsN6d1ii/Ey+2
pggAnxeSG75rqOP2q1dPe7mqOcmTzY9k2hJfVUUh9zPznzcxX0Sjul6BAO3CKlxYmlYKNngr4atA
sMK7YfUPWkVKykfSyyh1dKgMisLxtvwo+4jRoyoLU3KYlCizNgAE9zp/8JQRWtlE4p/BCnhgrIKw
l3mn7H+bvh52foABAb5BnAtVRRUEk1DWJ/oPPJv6LA8qCvflFjOKQRbw6PfFGArl2Eh1zV84bUZX
XLqkh0F1W8fgRmUaWey54fqGbQkUtNGL9LWijGuncVsS3mKAu4yut1wnh8vjkK/5SCIE9lx/ECWm
bZzrsjOMiVfMhNXd1LW/ulfWNZF4MfozA+qmw6xIjw==
=Ujo7
-----END PGP SIGNATURE-----

--1WhaJPULB0DvvgYmQAFFoXOhtEQXABxqT--


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 15:13:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 15:13:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246178.424600 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwn0g-00020l-Jb; Mon, 13 Dec 2021 15:13:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246178.424600; Mon, 13 Dec 2021 15:13:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwn0g-00020d-GY; Mon, 13 Dec 2021 15:13:02 +0000
Received: by outflank-mailman (input) for mailman id 246178;
 Mon, 13 Dec 2021 15:13:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=RwxN=Q6=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mwn0f-00020X-8i
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 15:13:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28bf7db9-5c27-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 16:13:00 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-hrdgCM3hP9q8_Ww6dRPQcw-1; Mon, 13 Dec 2021 16:12:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2606.eurprd04.prod.outlook.com (2603:10a6:800:51::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Mon, 13 Dec
 2021 15:12:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.017; Mon, 13 Dec 2021
 15:12:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28bf7db9-5c27-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639408379;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=NepYqSw68L1IRVa08bjwitG1A/t4bjNDpTEkt8BFYlw=;
	b=hXhNpt+Yo2rL4q9b1pt1oc/sOfyh6+BUtOxmiWaqCX7rK0WI1500vVF5vy/qVNWoIAthO4
	poO50caJ52kFnVIEmqfK/WjcIehoDryL1f9BWST8WZjPFJj47Seb6jOBzfUr5yaVe/dsNz
	4i9DnhHvdpSLPw31snMoo+ZZmRXvoHI=
X-MC-Unique: hrdgCM3hP9q8_Ww6dRPQcw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D0LTYVJnXGmRcet1cRVBdWO6PWLuKw2pnI/vau6kvr4VH5yf4CaWvKWB0F1hYjcKHc4fVqwzia0DHjciOb8kU8kP3XJKSbgiqF2kXcxNt1rYaP3X/i2zvKGfg65BfskqYlBavX/yaPrBkvqF9+ITYChGNDxMY5ZUEi7LvtpvOQyi2mp87M86gmQM8AlAXV/vK79PjtQd8Mm+YiRO21QMRKMOuAggYXua3/z0WG+keLjUT/tj0JzB99DG1X379L5AmD//ljC7rWWj7xfW0whyy9dCOHikl5RoKqiUYRR9oOdj+MEigCkW1inUYFhElLVxKNta8JYq7IEwWTvpC+RWUQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NepYqSw68L1IRVa08bjwitG1A/t4bjNDpTEkt8BFYlw=;
 b=LtkRbHp9Qd1pyp7K1ZV43bXmBbSvS8VF2nfuTDRE88zNhPXhS5xhvAML2JH7O5K4C3zUfbX9lC6e0QbPPXdb4MZx8M5PYdTPvgWMlLOHxsTlZ0VYLnYCyYwXj09bEIe7fQqhSKYes9MwbpowFHVGxUc+rVgfec20RViwzYCl00ppEl7SRDaiAWysNVTbugeMVVpGU0adguB9jO7io59GWY3RKnhU3AzK2M+J6zMb6aryUIXtm7G3FnuwhXr7GZa0YwuiPdDSqjnJU+tKCCHCHO5rwS+/ZlfA6QXfAovRbKAZ0uzyMLFsKgtyy/rdJiwGGgihXRM+q5xZRwY/9oaGRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e717897f-980d-ad44-31d9-39f5e7e1c45e@suse.com>
Date: Mon, 13 Dec 2021 16:12:55 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: enable interrupts around dump_execstate()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR03CA0016.eurprd03.prod.outlook.com
 (2603:10a6:20b:130::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc250497-9812-44c4-f8bb-08d9be4b0b54
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2606:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2606910BEAA333F618930649B3749@VI1PR0401MB2606.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IW939SZDP/7KMuQTi51FLcr72QQB1nn3iHyZXgwNodX8rOAHjnohTZr+fqpvEkpV9oboJPHNw5E8B7EG9gAnCdTaLi9p51EBwj82jjfoMfZDOHT6o2AEsUk7lkqJi9gnY96db3BUOvER8bSM37MgIy2rItdmg7NGzJC3ATUgq2QcBEbVtPWIjto0oeMiknrwUg3Oevmh6kAR8sMNCTfulCSFViMcLSjbaIXV5oHhv73jJ5DQ1UHVkYx5c1wSd0nyGGU9PBltUbulEvwRele4g4wJJJDCMy8Tsrop5I7u7TlaXjcLRBZPDrwB3Ell8ZHCLnRvtUIBmn2nB16GptWg3EegqD8m+i9b+6L+wba3ufEFWLOs+gA4ShLmUCNxmubEzWp88BNytZcE+ObH65FEVAoTm3QsDSmLUl5ndrXGK7jfMj5G/NvyYrHDsP/9b3V9oyxDZkKoUKF3LlIg/C/MHylxdu1euzeP5R3/nCPZbjZM6ks++aNop2/6mW8keOTmR2BnFUGvGIZkSozXvLasV3Y+RXIcURw0SCXDY0ZASyRgv8Vt1dMX2YRAr6wF5zlizoh/XeRODuGEbpM2CyptDQmxICZ8m11qNoKhDRFrIR0Ge5pz/tk38BUQNGtsFmVoUAoC3RUrLLUKf9ywN+F8gaUdnk4CIvF3nvKgPlQZgRpqKRE+e3idGfmfB2zZxrWdJFAMGesGr7vtonyJXcoq9jZ2cduqKeLnVV1/+js3iIc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(36756003)(38100700002)(31696002)(5660300002)(4326008)(8676002)(31686004)(6486002)(6512007)(186003)(83380400001)(508600001)(66556008)(66946007)(66476007)(316002)(86362001)(8936002)(26005)(54906003)(6916009)(2906002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjExZXZXWkRETUg1U1F0T1ZLdVdnd1hvMzVWSU50Um9OeWFjQ0NwUDRJTERN?=
 =?utf-8?B?TGlWamF1UGdId0FVK2ZqTmh4TmZjZnFRTUQ2enRoZDFwc0s1Zi91Y0JJUWtU?=
 =?utf-8?B?dkZiejJub2YxblBiYmxuamRQNE8rMC92eS9FSEVsNndTMjQ5Ymx6eGxEUVFp?=
 =?utf-8?B?TkxHY3FLaDh6UFV5ZFdadUhJMWdkNGJMZzNsYVZGK2FLV1loWFlBMldpN2FM?=
 =?utf-8?B?VlgrMjdQeGgwSHVCdXd4TURDYVFBczl0Q0RkVnRERWcrd1Q4UzZZeUc5RDJl?=
 =?utf-8?B?WHc2WlFTR1B5VnN4cFhkeWI5WjFmYjBucDhrMlF2K0UrTlRnditkSnRGMENu?=
 =?utf-8?B?a3lJSzkrcUtiWHhIZjdsM3lsdHFIQXhrelB6QlE1Mys1NjQ3OHY0WlFDWmF3?=
 =?utf-8?B?dVlGenFYZnd5RGxYRGNjODlacloybjh6YjJqNXBnNUluendNenNSTVlaK1Y4?=
 =?utf-8?B?bkZmQkl2OWJSUittZUhTSU5Zand5b3p2cGxnQmVkYTZJdlB4U2M5NHhRRk1q?=
 =?utf-8?B?d3A3YXNtenZ3VW9mbk0xVDBkUnJsTGlpWDR6MkQwVFdKZ2tXUFBxVDdmVngz?=
 =?utf-8?B?d0VMRmw4ZFhDTE5wRFhIMDlkVXFlVkl3STNDLzNyekRXM1pYSDZOZjJ0NzJX?=
 =?utf-8?B?eFBackxtNGRaZUM5eW9wT2Y3ZU5mSmw1Unh0NzBCdnNlTEJQYW1SRmtvZ21y?=
 =?utf-8?B?cWgvblNzSmlNQk5sZHBBakNNWlZaQmRWVjYwMlJ5MTlOenhYM1J6OURIT3lQ?=
 =?utf-8?B?QytYbXpZaE9oTWZFN2F5NVJhMWR1YTVrazJGRVgxdFpiM1c0c2ZLaXdnUjZ1?=
 =?utf-8?B?b003dU1Xb011b2Z6em9lOTE4TEhuSWViaGtWd2htN2EranZ2c1dHSW1MOGRX?=
 =?utf-8?B?d09GSGNQbzhkZFpNUnhMSFZxQWhYdXU2OTZqT3ZYbW1ackZWeFJhNTBrVHdY?=
 =?utf-8?B?dEg1MjFIV3FZb2pwMFlrblRiNTJoMFk5dFM3Mlo1V2NkN3ZEanNKd1dxSS9C?=
 =?utf-8?B?RWJQNVdXazJmNmFHTGJadWdNRWVuQWtpcGNKdVA5MStPSkVPN1FNb0pwMWdX?=
 =?utf-8?B?N1NBa3hRZnRnQzRZTEZEcmZ0R3RwczQ3NG51OEtuQlFuT05zU2swYUxSZFBQ?=
 =?utf-8?B?OU9XaWwrSjNXRGs1dkZHNnhvMFhRaHE3bGY4US94aCt6ZklEbkhSVDdHdkNi?=
 =?utf-8?B?UytlMnBjbVhrNDN4OGl6NlA1Z01KcHNvN1RQako1V0xPZGdiUkgvUlpUZXB3?=
 =?utf-8?B?M2VlYW5aWkZZdnZQc1BVRTE1c053VjgrWGMzaDZhQXFiNXFFdE5uVGFWNitG?=
 =?utf-8?B?bEwwSmJHQTlabWV3MzNjSGYxcWFCNlBZQWVkbmhmYjFLM3MyZ1Jvakp3S3dq?=
 =?utf-8?B?N3d2NnJXdTdKd29hRE43WVVBM25VOEZ1eUhaUkJ4Q0JMNHBFMVRNK2JMbkRn?=
 =?utf-8?B?TWUveVpuQURSQXdDc2hhOTBMS1pLdjNPZGl6c01yM0JkNFMvUmJnV2EzVzFB?=
 =?utf-8?B?TStKZ0JTZ095azNEU3EwSmVFMCtYVHc4c3JxRE9lazV2ZzFIUWVGamNHMW5T?=
 =?utf-8?B?YVYvc3VJVmowWkNwT1hMUGUrOUNETW14QXBMSUthNnhTUHNKVUdMdkttKzVt?=
 =?utf-8?B?aTIweFVxTGJrSjBRb2dZeEFDWDd5QjJDNFZIUzhCUUNTVmdIOThIWDlMekgx?=
 =?utf-8?B?L3JjQzZuMWJEVzhzNkZnRGtpbStOTVVnNGN5SlZsbkd2NlFCd05oSUFQMlN4?=
 =?utf-8?B?TjFtUzk1YjFQY0RCNCt4aGJUWE1hd2J5cW1zNm5rZ0VvU1dtTU0rY1NGY0Za?=
 =?utf-8?B?ODZuRGR2SmxkQkNOQitTeVJxZmVjTHlBU1ZQVVp2VlFZZ2JTNTR6Szg0YW1t?=
 =?utf-8?B?R2MrMzBKVUtvazBrQWRlbWtsZ3lGZnExaEdaOGZZQUxaTVJLbEhvY3Y5ZktF?=
 =?utf-8?B?MHdnODErdTNQRGlzOFFqU1ZBL2FXOGZDNC9XNGZCai8xYU9iMm1hMndvRnVw?=
 =?utf-8?B?SlY0aDZ6UVRBck52eDNDOUNRSFJybEI1MjFUbHFWNUlodmpTZWJjUk5sbHIr?=
 =?utf-8?B?OUlMMW5FNEsxUS82OUtPZmJpQ2NwdVFyVmRvZlRSS3ZtR0ZJKzV0ZzZyZ0Ix?=
 =?utf-8?B?ZjdrMXo1bStycW1WbHlaaTZPNElZdnJiUnFwbWZ0SFlWUGdScWFSbklScGc0?=
 =?utf-8?Q?YfsF9CVB4Ld/QgGtvqn2Zv4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc250497-9812-44c4-f8bb-08d9be4b0b54
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 15:12:57.3257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CUsF/Hte8v+e+7FS28ZkCjmYH2ByRBV0UuSLdfRVNroVvPQ30DPQINjr8kvOaMiXfn9PaNkRhpsT7cLLda8fpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2606

show_hvm_stack() requires interrupts to be enabled to avoids triggering
the consistency check in check_lock() for the p2m lock. To do so in
spurious_interrupt() requires adding reentrancy protection / handling
there.

Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_state()")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The obvious (but imo undesirable) alternative is to suppress the call to
show_hvm_stack() when interrupts are disabled.

--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -1386,22 +1386,40 @@ void smp_send_state_dump(unsigned int cp
  */
 void spurious_interrupt(struct cpu_user_regs *regs)
 {
+    static DEFINE_PER_CPU(unsigned int, recursed);
+    unsigned int cpu = smp_processor_id();
+
     /*
      * Check if this is a vectored interrupt (most likely, as this is probably
      * a request to dump local CPU state or to continue NMI handling).
      * Vectored interrupts are ACKed; spurious interrupts are not.
      */
-    if (apic_isr_read(SPURIOUS_APIC_VECTOR)) {
+    while ( apic_isr_read(SPURIOUS_APIC_VECTOR) )
+    {
         bool is_spurious;
 
+        if ( per_cpu(recursed, cpu)++ )
+            return;
+
         ack_APIC_irq();
         is_spurious = !nmi_check_continuation();
-        if (this_cpu(state_dump_pending)) {
-            this_cpu(state_dump_pending) = false;
+
+        if ( per_cpu(state_dump_pending, cpu) )
+        {
+            per_cpu(state_dump_pending, cpu) = false;
+
+            local_irq_enable();
+
             dump_execstate(regs);
-            is_spurious = false;
+
+            local_irq_disable();
+
+            /* (Ab)use is_spurious to arrange for loop continuation. */
+            is_spurious = per_cpu(recursed, cpu) > 1;
         }
 
+        per_cpu(recursed, cpu) = 0;
+
         if ( !is_spurious )
             return;
     }



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 15:52:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 15:52:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246208.424630 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwncD-0007hV-4i; Mon, 13 Dec 2021 15:51:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246208.424630; Mon, 13 Dec 2021 15:51:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwncC-0007hO-W2; Mon, 13 Dec 2021 15:51:48 +0000
Received: by outflank-mailman (input) for mailman id 246208;
 Mon, 13 Dec 2021 15:51:47 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=E0LF=Q6=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mwncB-0007hI-Kp
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 15:51:47 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 922b16f0-5c2c-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 16:51:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 922b16f0-5c2c-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639410706;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=FVKEPeD0WZRvlkYcWYGtMDmimSlGJxxTn2VKPlnOXq8=;
  b=Htfep2EFeJCJI1uBz6RLYjmNYdoZHd4WhVu8YQhQ8fLNzA46BvQVGfP1
   pbATxDEbGVaMLcE4VHG32ryrJMeq+dGV0oV+USUksL4VtvDSJbE048i4K
   KOsp4JIcozkqmmAV8ovMirkXufITBJ2vFjLQgZ3D2qoVa09O/babt1+xP
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: jrjN9x6CqAywrHgLCyHowJbKTVOEOpCY0auf1MYuibXBhJecWr8u5v80uhVK4lbX5VZIM5LCTB
 hxUVQqOt9tNP0s34HtaE47yAEjckWP5egzU+V7YYvHIaxYlIsW6fsyfC2DZ5QxeiJej615YSyC
 qM07KQWoizBSS5MnxRaLK/gmepdpwGhSLGcOFveNN/LGQnrmK32ZrwkvN0Z670sc5hV8UXPZrj
 YxmSgfJHWZk4b56hohgiHs7nWEpKttBYNGEo9h9YewCH0Y9JmF7N7mDGocUnCZJ3uLQde1Fcs3
 HaoLZfE4t9t5iLDdLmMTu0WA
X-SBRS: 5.1
X-MesageID: 59401221
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VHEalq65db8p5Im4e9HLHgxRtNvAchMFZxGqfqrLsTDasY5as4F+v
 jEXWW7UOf2IZWqhfo1yPYS29xhU6JGHzYdmTApurStgHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Uw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z+
 dt2766IESkQGbTFg9xGWhNiCDhcFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWZs3pkUR6+2i
 8wxVWMoRUzeWRZ1B0YwLY5ix/mUr2KlWmgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 mHL4WX/RA0bPdq3yDyZ/3bqjejK9Qv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZwZud8hvduawUNz
 1aSp4jgDwZ0qZ+8HCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjv3jpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDDtYji7rnXzURhpdnh+5nzuJ643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC
 GeK51gAv8QPbCb3PfQuC25UNyjN5fK/fekJq9iONoYeCnSPXFHvEN5Sib64gDm2zRlEfVAXM
 paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOvGDFbIGOxtGAbfMYgEAFas/Vy9H
 yB3bJDRlX2ykYTWP0HqzGLkBQxQcCVgW8mp85c/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+
 HS8UVVf013xmTvMLgDiV5ypQO+HsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF
 qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+
 ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0
 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N
 +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB
 xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y
 Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
IronPort-HdrOrdr: A9a23:Hv7bvqH6Z20eOyzLpLqFcZHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcV2/hrAV7GZmfbUQSTXeNfBOfZsljd8mjFh5NgPM
 RbAtZD4b/LfCFHZK/BiWHSebZQo+VvsprY/ds2p00dMj2CAJsQiTuRZDzrdnGfE2J9dOYE/d
 enl4F6T33KQwVkUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZuzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDk1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo90fLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplWy2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ggMCjl3ocXTbqmVQGbgoE2q+bcHEjbXy32DnTqg/blkgS/xxtCvg4lLM92pAZ2yHtycegB2w
 3+CNUZqFh5dL5jUUtMPpZxfSKJMB2/ffvtChPaHb21LtBOB5ryw6SHlYndotvaP6A18A==
X-IronPort-AV: E=Sophos;i="5.88,202,1635220800"; 
   d="scan'208";a="59401221"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=D4cTf9F+GuY027waYtED0HPDs7i8zrhuUQZUrKjKFMgZ2+Gn89PjUrubq2D6m4Vn0Uz19117YrKcM1bIAjquFiFCCt6BGoA8tzzOsb5vpEPyiEGN4VbQJyz0fxMZslQzmm7YA9V+bvGCJaS3DZUgRWiEu5FzKtNY03p1NIFB+DCZhHUWvSOgKQTFYlSwvbqV1bGs4Sl/cS4G02C0HbDhgPRk1lZPYum8ClRgpw9iatgOInLg5oQBEWfW3vKUfb1o22NRucJ1oCJ8MpTLbPTz5VjeqaxtSs+tX720OFmzBoyZg5LyfD+wLJ7KKn9fLs8p/BFA0xMPsWvuUry0xx0ciA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VD6L36V87ro49bV4GB8XEnLsmUys6mR5KawDGTsNJ/E=;
 b=npcG3pXHtuzkNvE/H+pwfrodpd26rIlw19oRkp3fiDp6s1Fzzb3LkC44SUX44KwakPTyJFFnMg7+VIH81VVCaIO3Ub2GYZszSLBCeMJ1hFYviqe9LNxvwjn3+CUgpgar51OG/WVzY3HkjJlq5Jg8wvrT1flxnWf+6DjryGrl24T96gp31GyBInbJDe0OWBUhj7P5IVmNkpId0Cs1w0jn4bgoWQR72667OxNOFJ1J1v15Fwn4AVDDkCstdQ4/dJEskwedRJkVTHBJz+6yKfbPQXeGqGqLCsnfK8SqCyjq4RjIJNIFjbo2TwKcpvJ5EHCyDh9kK6ttN+kPzfAJq3oBvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VD6L36V87ro49bV4GB8XEnLsmUys6mR5KawDGTsNJ/E=;
 b=h4l6P72wytkmY1gp6EwmXm2hTEnfZPe8JZsuma1UV/pjzBoF+h1V7Hkul3dSaI0oeIooQmeD4/HtE7uDuU8d+nTOwd2URnu+kZwQ163ZNU2QViwgR8olIX0XLwpXd1ptGY7eBMxjM8YF6spNf7pG8ajdPZEgAFDFIVqtnDxL5KM=
Date: Mon, 13 Dec 2021 16:51:31 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <YbdsAy0huMXBjJe/@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
X-ClientProxiedBy: MRXP264CA0003.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:15::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: caac669c-8126-46b9-ef00-08d9be5074c2
X-MS-TrafficTypeDiagnostic: DS7PR03MB5608:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DS7PR03MB56082E173BA2FEE1C335002F8F749@DS7PR03MB5608.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: sG9sNuNDHOeH0YPb8RNerXG12b3YE6pxOEOL2RtmN4jrBbmrDCsHpOO7ZSC/v+g2f+8bYemrjeynYIo1VpR2emWTi5TOktU9+rPfQfo90oQJHYfLbEWv4NEq/3ncCIjD26lhSPqU3sApjUCxkCIG0sgN6Ng4Gc+hCbWUSp9vAahsATsskJ/Rd5m0xwwkE+Rauplu7fY2dTEEkBye44bxCtCETsTssn5iwCf1ZHKB9gma9oYA6JH+FBTQgLpXpJusu02FzcVi03GP/CLH43wcI6i1zhWYNqbYgjVhr+iWSWLsmvtyFPVH+8p/Wi8Yh1qvkH2XmxlT6kyZfvU1tzoHsZmVcvUGnmYb7HzxJmRKi38CDU+93TWyeuxTFywrqZ1jM8v2jG+ul1dGzKCGKJHFv1vtgwfdQGn5tlRJ2w7ty5mVVNDfAbq7Ek5DkoDc0Y8oVpbU3ilO4AaDgRJPHEE+Un+4ge5WjsDzLSjrM3wmYrJE8aX//rM8exkpFzhM3WGJ4yFi+V/eqe84KDPcbe2/jQw/SvbmzeIJmN0YiHvu1FJWDjmKuV/GKZ0mCEnxJHm8+k0jg4Q6KAd8RTt47CZ1xHk0MASicrU4BUJ/ys4HqXYRekkybvS8Mhsxs1oP68YcIu5EY3Yqo8bSpbF7xN/phQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(4326008)(66476007)(66556008)(66946007)(6666004)(5660300002)(8936002)(26005)(6506007)(6486002)(186003)(38100700002)(6916009)(6512007)(82960400001)(83380400001)(33716001)(86362001)(54906003)(9686003)(316002)(2906002)(85182001)(8676002)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXVFSEJEMEZCaEJaOUV2SDJkWDJKbklHc2hQT2RrRU1ZNGxDZXI3L3ZNcGI4?=
 =?utf-8?B?UDA2VVREN3J5eGpiaUM5ZmZqbmNCSk1lbjZpMU1LaVZsOXNBZkdlVlBjSmkz?=
 =?utf-8?B?NnM1dTVQS2RKUmlUWThkWTBReFk4cWw0dVJhYjhTL0VZSU93OFBJcGNsY0l1?=
 =?utf-8?B?NTJJaThxSnJhV2U3M0pwc0FoNE5uSEJpR3Y4UTArZk9lbHlEdEJoMTV0b29J?=
 =?utf-8?B?RU5XakVsZU5KN1VlcVZpZWdIRE9ENTNPVE12SVBzWkxzNkR1NE9TNldjRTJY?=
 =?utf-8?B?NUhJRzNwVEc5UkZ6RGlJNVd2azMrVE5Cb1RSZUVUZ1oxY3kwMDkwd3RrVldL?=
 =?utf-8?B?cGg4dkpvRnJ6WW5nQnQ0VktVT0ozcEdyM2ZKZ2ZrNWdqVENhU3E0K3IyUGFj?=
 =?utf-8?B?aVlzUFZwWXZDTkJNazllckpRWFZ3N3JTVUlXa0thYkl1YUtOYWUrRkZUeUVx?=
 =?utf-8?B?WnowYUZqRW5RNmRjd0N4dU9LUE5EdWxiYWlEOXJDcHdQRy8wellSS24rUzF0?=
 =?utf-8?B?UVI3NW9UWWZmNjg5VnNlaXphYXVIS3RocXhCUnJkdFFiMGtWU2EyZHJFMHAw?=
 =?utf-8?B?L1lyVGpQdDBKZkQ1QnVENzFmeDVlVEJlNUtRVStzcVBucXVIKzIyMG5pL0VL?=
 =?utf-8?B?V2ZFK0dNSlVaMURFQVB1RTJxZFhKSStVVmNZd3B5N0hSU01UcGtXWWNXTjR5?=
 =?utf-8?B?WGRaZXl1OHQrQWVDWkJuNzg5elduRWNCUmJzL0tQank5WHVQbFJPM241TEV3?=
 =?utf-8?B?czFCQjF5UEdjSDloYitiRmtuNWdWamV4VlE3VFlPSS94YmRLeEJRNUdEZjdV?=
 =?utf-8?B?S3BJZ1IrWUVQRHlTcHpuZGJWVkJ2SVBvV1N2SUFaOXZHdHlmN2dNZy9MODFN?=
 =?utf-8?B?TVFEOVV4WVdRY09YN2xFaWM2MDJiYmdHdkl4d3RFclNCNzZWM1ZUTGZEb3BL?=
 =?utf-8?B?M3hzSFVwQXluTFI3TVNwc3A3aUx3OUhWMWNRb0F0ak5sdXNSMmNra1AvQTdw?=
 =?utf-8?B?NVJodnYzOURmMWNBbmxoZGNGelRFN1J0NER4dUhCS3k1MkFJR0ozTUpDcUwr?=
 =?utf-8?B?WjFCSk9UOVVDQ1V4RGs2Tjd1ODE1YkpYY1piTEpqdWNMcVVZRXAvbnlQTmha?=
 =?utf-8?B?SUlGb2lWOVhtdDBORHpQdnh0NlAzVjM0ZHpBbVlSSW1pUTlJajZKbFF3alYr?=
 =?utf-8?B?WW9rRlRYT2t2M082NEJ6TTVxSHhlaXFLRUdGRkxpdVl3MyttYnpWR0NVTTlh?=
 =?utf-8?B?UTErcnBLL3N6UitvRVQzS3YxVG1LN2JVWU45T3NoN1NMYjV3OGpYSHFVZW53?=
 =?utf-8?B?OXhqK1hLTVNENWJIcUVMblhSd1ZaM252M3NrZlBKOUpxaFRVUG1sNld2bDFZ?=
 =?utf-8?B?czFKMXBOb05VeWdFbEdyZDI4UXBQNWpYSXlDZCtKQmt2VUZXM056TzB1SmZQ?=
 =?utf-8?B?eDZ5ZU9nbkNRWDJiN1k4RDRvU3BONC9INTdrZEQ3QW9HRm45cXhtQUZiMGt3?=
 =?utf-8?B?Z01nQ2FGbWttMUxGbzZOTXVhNzFtc0VSWjRrZVFSY0p5MGg4b2ZyU1Z0YXVB?=
 =?utf-8?B?czIvb2EzQmdUL29NNzNQbjBFUW5WS1NrRVJWeGFYRjVUN2tYQmpidUcyS01J?=
 =?utf-8?B?TTMyV2tLWFlNdlFLUkxJcDVoZXI3bzJ4Nm5XM2U2eW8zR0pmUU02QTlWbnh2?=
 =?utf-8?B?Z3lGZkdiWEhXWFlqWmZ4Yk0vYWpvc0tuUGhGYzk3ODdwSlZsRWhja0J0UGlm?=
 =?utf-8?B?VWVNR1BidDZEeW9zMlRjTkhEWkpZem5rTnpYL2pHNzFQRWI5eHlyMHFic2VK?=
 =?utf-8?B?MmxZNVdvamk3YnozTHlBVWNMcW83a1YrQWtaUy8xUHhsWCt5WTV5RzQ0T2VE?=
 =?utf-8?B?alVMNElyaVdlRnJnMEo2S0Y4UkczeU1PMDNoNjd2QTR3bVNMcGRHV1NRZHVT?=
 =?utf-8?B?NVd2bVRwWnlzakdJWlhsZmR2aVpFaDVGdUozUXNmMGJ0UUZncXpHclkybkdW?=
 =?utf-8?B?TmpJbnI1eEdTMXJFN2hwTFhsWkVLQm04V1hFL0FYM0hOc0RMUjBmV3IxbmV6?=
 =?utf-8?B?dTNDM28vSkpiditoSUx1WTVVNGgzdG1qMElKQXNSdWJxQWpTOVBRcXhIWDhz?=
 =?utf-8?B?ZWJxclEzK0o4ODF5TjFZNEM2OUl6UFM4ZURsVjlyZlhhcHpSK0tDSDkvRE9X?=
 =?utf-8?Q?nosceZvUMbjET8nGE0G54Dk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: caac669c-8126-46b9-ef00-08d9be5074c2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2021 15:51:41.7190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XVNNlqNAAynvIagJDhpcQM9qzK2pRRmV10yb3rvobB5xgJxc5fmQZqXzhtnjuQ8zNyzvQvtk5wdWNLqsMK+ImQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5608
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> Page table are used for two purposes after allocation: They either start
> out all empty, or they get filled to replace a superpage. Subsequently,
> to replace all empty or fully contiguous page tables, contiguous sub-
> regions will be recorded within individual page tables. Install the
> initial set of markers immediately after allocation. Make sure to retain
> these markers when further populating a page table in preparation for it
> to replace a superpage.
> 
> The markers are simply 4-bit fields holding the order value of
> contiguous entries. To demonstrate this, if a page table had just 16
> entries, this would be the initial (fully contiguous) set of markers:
> 
> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
> 
> "Contiguous" here means not only present entries with successively
> increasing MFNs, each one suitably aligned for its slot, but also a
> respective number of all non-present entries.

I'm afraid I'm slightly lost with all this, please bear with me. Is
this just a performance improvement when doing super-page
replacements, or there's more to it?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 15:53:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 15:53:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246214.424641 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwne3-0008MP-IM; Mon, 13 Dec 2021 15:53:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246214.424641; Mon, 13 Dec 2021 15:53:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwne3-0008MI-FQ; Mon, 13 Dec 2021 15:53:43 +0000
Received: by outflank-mailman (input) for mailman id 246214;
 Mon, 13 Dec 2021 15:53:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwne2-0008M8-Ag; Mon, 13 Dec 2021 15:53:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwne2-0007Y9-40; Mon, 13 Dec 2021 15:53:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwne1-0006n7-Qq; Mon, 13 Dec 2021 15:53:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwne1-00022u-QM; Mon, 13 Dec 2021 15:53:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SZWR+qyUVAN9LW8aGQto8oHpCOHGm3UnBN9vi94T8dQ=; b=XNsAwj5tOgwpUVBevnfpFiRmuN
	7y6XkMUVorZjplZ3vWDz0ZsRdfgFucYa6z+qI5A+bDfiJzveC+JTfRb9z5V1f07Rmmwo/GUx45eKR
	afMnWYKdUItBUWr9dL2DjCCTGNdzGtmjFcMtLCJ4pLiHmnAKy1eAY6d/WHJgOR7UA4QY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167393-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167393: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=ec37fd9c1fbc6c14ad3291b415ad6677a022a554
X-Osstest-Versions-That:
    ovmf=1203eba58ecfcddf9a9ae164ccf32ca29037af82
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 15:53:41 +0000

flight 167393 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167393/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 ec37fd9c1fbc6c14ad3291b415ad6677a022a554
baseline version:
 ovmf                 1203eba58ecfcddf9a9ae164ccf32ca29037af82

Last test of basis   167392  2021-12-13 11:41:45 Z    0 days
Testing same since   167393  2021-12-13 13:42:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <Jiewen.yao@intel.com>
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   1203eba58e..ec37fd9c1f  ec37fd9c1fbc6c14ad3291b415ad6677a022a554 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 16:01:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 16:01:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246225.424655 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwnlg-00025S-CS; Mon, 13 Dec 2021 16:01:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246225.424655; Mon, 13 Dec 2021 16:01:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwnlg-00025L-8C; Mon, 13 Dec 2021 16:01:36 +0000
Received: by outflank-mailman (input) for mailman id 246225;
 Mon, 13 Dec 2021 16:01:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nyhA=Q6=redhat.com=stefanha@srs-se1.protection.inumbo.net>)
 id 1mwnle-00025F-Ot
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 16:01:35 +0000
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f0606d78-5c2d-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 17:01:32 +0100 (CET)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-153-sg8h4fjDPAOo2S6CJo_5FA-1; Mon, 13 Dec 2021 11:01:28 -0500
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F30D3102C858;
 Mon, 13 Dec 2021 16:01:25 +0000 (UTC)
Received: from localhost (unknown [10.39.193.244])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 66ED57AB5B;
 Mon, 13 Dec 2021 16:01:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f0606d78-5c2d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1639411291;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ne7qoKfSxVoINZDLm3Ayt6jcoqtbCFcdhO3c1Ja29ko=;
	b=AjlHrdDe0yt9q06yDqQQNWQPiQvvWPYAdgKpWVfhzFWf3xWmimdIuDUm2zzk+KWophgPh4
	MmaJjYLMhjrSQ5ps+9XEej0yRj72LmEDcmN50HasSLNhMcWonpDE5JgyzbT3ZmQjZdhyco
	Ta9dPJ/eGnh5s/xEmFv2LitH3f2He7k=
X-MC-Unique: sg8h4fjDPAOo2S6CJo_5FA-1
Date: Mon, 13 Dec 2021 16:01:23 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= <berrange@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Juan Quintela <quintela@redhat.com>, xen-devel@lists.xenproject.org,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Coiby Xu <Coiby.Xu@gmail.com>,
	"Richard W.M. Jones" <rjones@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Perard <anthony.perard@citrix.com>,
	Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org,
	Fam Zheng <fam@euphon.net>,
	Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= <philmd@redhat.com>,
	Paul Durrant <paul@xen.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Peter Lieven <pl@kamp.de>
Subject: Re: [PATCH v3 0/6] aio-posix: split poll check from ready handler
Message-ID: <YbduUxqibwDie3Vt@stefanha-x1.localdomain>
References: <20211207132336.36627-1-stefanha@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20211207132336.36627-1-stefanha@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Ax/RBNHfth0NNMo5"
Content-Disposition: inline

--Ax/RBNHfth0NNMo5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 07, 2021 at 01:23:30PM +0000, Stefan Hajnoczi wrote:
> v3:
> - Fixed FUSE export aio_set_fd_handler() call that I missed and double-ch=
ecked
>   for any other missing call sites using Coccinelle [Rich]
> v2:
> - Cleaned up unused return values in nvme and virtio-blk [Stefano]
> - Documented try_poll_mode() ready_list argument [Stefano]
> - Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers =
[Stefano]
>=20
> The first patch improves AioContext's adaptive polling execution time
> measurement. This can result in better performance because the algorithm =
makes
> better decisions about when to poll versus when to fall back to file desc=
riptor
> monitoring.
>=20
> The remaining patches unify the virtio-blk and virtio-scsi dataplane and
> non-dataplane virtqueue handlers. This became possible because the datapl=
ane
> handler function now has the same function signature as the non-dataplane
> handler function. Stefano Garzarella prompted me to make this refactoring=
.
>=20
> Stefan Hajnoczi (6):
>   aio-posix: split poll check from ready handler
>   virtio: get rid of VirtIOHandleAIOOutput
>   virtio-blk: drop unused virtio_blk_handle_vq() return value
>   virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane
>   virtio: use ->handle_output() instead of ->handle_aio_output()
>   virtio: unify dataplane and non-dataplane ->handle_output()
>=20
>  include/block/aio.h             |  4 +-
>  include/hw/virtio/virtio-blk.h  |  2 +-
>  include/hw/virtio/virtio.h      |  5 +-
>  util/aio-posix.h                |  1 +
>  block/curl.c                    | 11 ++--
>  block/export/fuse.c             |  4 +-
>  block/io_uring.c                | 19 ++++---
>  block/iscsi.c                   |  4 +-
>  block/linux-aio.c               | 16 +++---
>  block/nfs.c                     |  6 +--
>  block/nvme.c                    | 51 ++++++++++++-------
>  block/ssh.c                     |  4 +-
>  block/win32-aio.c               |  4 +-
>  hw/block/dataplane/virtio-blk.c | 16 +-----
>  hw/block/virtio-blk.c           | 14 ++----
>  hw/scsi/virtio-scsi-dataplane.c | 60 +++-------------------
>  hw/scsi/virtio-scsi.c           |  2 +-
>  hw/virtio/virtio.c              | 73 +++++++++------------------
>  hw/xen/xen-bus.c                |  6 +--
>  io/channel-command.c            |  6 ++-
>  io/channel-file.c               |  3 +-
>  io/channel-socket.c             |  3 +-
>  migration/rdma.c                |  8 +--
>  tests/unit/test-aio.c           |  4 +-
>  util/aio-posix.c                | 89 +++++++++++++++++++++++++--------
>  util/aio-win32.c                |  4 +-
>  util/async.c                    | 10 +++-
>  util/main-loop.c                |  4 +-
>  util/qemu-coroutine-io.c        |  5 +-
>  util/vhost-user-server.c        | 11 ++--
>  30 files changed, 219 insertions(+), 230 deletions(-)
>=20
> --=20
> 2.33.1
>=20
>=20

Thanks, applied to my block-next tree:
https://gitlab.com/stefanha/qemu/commits/block-next

Stefan

--Ax/RBNHfth0NNMo5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmG3blMACgkQnKSrs4Gr
c8iqcgf/dPRV3F1SsSIbqM0FdwEE60A00v6lVdZPUOkO7Q/WKqfO0bMBCh4j7cCt
/SeyrgrCLFH2cACI4jssYC+5EEvzNoxr/PUx3l+verGNr701uvth0z6T5IUkI5b3
r6Mmb+jeKlbW+K1L0AYA5Keo2eHVj9ci4Nt2+uFmXqRXkAwADUDNuYWHmY2IqMNs
T49i5IZyHwxO4wp0gKIA+jSpEvxhaQ8zabGWN+W/P8UtC1ZQ+Scu4fFekTOtV/zv
a4OBp6wfnbbEJ9MNbWFH/YkUSzx4ggq1xSu1kUvszLIQaEQFqBUhBoy9RJFelUnj
ov+bJByWyD5w7tXUU1Z6wdXJkghzJg==
=H9XI
-----END PGP SIGNATURE-----

--Ax/RBNHfth0NNMo5--



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 17:22:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 17:22:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246235.424666 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwp23-0002SB-Ba; Mon, 13 Dec 2021 17:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246235.424666; Mon, 13 Dec 2021 17:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwp23-0002S4-84; Mon, 13 Dec 2021 17:22:35 +0000
Received: by outflank-mailman (input) for mailman id 246235;
 Mon, 13 Dec 2021 17:22:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4QLc=Q6=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mwp22-0002Ry-JZ
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 17:22:34 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 40d311cc-5c39-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 18:22:32 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:46562)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mwp1y-000gsQ-pI (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 13 Dec 2021 17:22:30 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A598720339;
 Mon, 13 Dec 2021 17:22:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 40d311cc-5c39-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <e669d8b0-a971-10b8-5e7b-69520350cc1c@srcf.net>
Date: Mon, 13 Dec 2021 17:22:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
 <0bf3ccd1-7958-e8c6-bb4d-4e319cc567a3@suse.com>
 <6abbbdd6-09f1-0511-ddb5-7c5222658d2a@srcf.net>
 <570a65b7-c1e8-9df7-ab63-c49d7a66c1d7@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
In-Reply-To: <570a65b7-c1e8-9df7-ab63-c49d7a66c1d7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 10/12/2021 14:08, Juergen Gross wrote:
> On 10.12.21 14:49, Andrew Cooper wrote:
>> On 10/12/2021 11:16, Juergen Gross wrote:
>>> On 09.12.21 18:07, Andrew Cooper wrote:
>>>> The values are already available in dom->{console,xenstore}_pfn, just
>>>> like on
>>>> the PV side of things.  No need to ask Xen.
>>>>
>>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>>> ---
>>>> CC: Wei Liu <wl@xen.org>
>>>> CC: Anthony PERARD <anthony.perard@citrix.com>
>>>> CC: Juergen Gross <jgross@suse.com>
>>>> ---
>>>>    tools/libs/light/libxl_dom.c | 17 +++++------------
>>>>    1 file changed, 5 insertions(+), 12 deletions(-)
>>>>
>>>> diff --git a/tools/libs/light/libxl_dom.c
>>>> b/tools/libs/light/libxl_dom.c
>>>> index c9c24666cd04..03841243ab47 100644
>>>> --- a/tools/libs/light/libxl_dom.c
>>>> +++ b/tools/libs/light/libxl_dom.c
>>>> @@ -722,13 +722,10 @@ int libxl__build_pv(libxl__gc *gc, uint32_t
>>>> domid,
>>>>    }
>>>>      static int hvm_build_set_params(xc_interface *handle, uint32_t
>>>> domid,
>>>> -                                libxl_domain_build_info *info,
>>>> -                                unsigned long *store_mfn,
>>>> -                                unsigned long *console_mfn)
>>>> +                                libxl_domain_build_info *info)
>>>>    {
>>>>        struct hvm_info_table *va_hvm;
>>>>        uint8_t *va_map, sum;
>>>> -    uint64_t str_mfn, cons_mfn;
>>>>        int i;
>>>>          if (info->type == LIBXL_DOMAIN_TYPE_HVM) {
>>>
>>> What about moving this if () to the only caller and renaming the
>>> function from hvm_build_set_params() to hvm_set_info_table()?
>>
>> Because I was hoping to delete it outright in a subsequent patch.
>
> I'd suggest to either do the renaming or to add that subsequent patch
> making this a small series.

That's a separate task, which I don't have time to untangle right now.

I don't think it is worth delaying this improvement for a future
only-tangentially-related change.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 17:57:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 17:57:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246241.424676 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwpZI-00067o-Rp; Mon, 13 Dec 2021 17:56:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246241.424676; Mon, 13 Dec 2021 17:56:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwpZI-00067h-Ot; Mon, 13 Dec 2021 17:56:56 +0000
Received: by outflank-mailman (input) for mailman id 246241;
 Mon, 13 Dec 2021 17:56:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VEuh=Q6=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mwpZH-00067b-GH
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 17:56:55 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0c763f82-5c3e-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 18:56:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c763f82-5c3e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639418213;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=uPB7YpPoPl4u2EoLy0oDY1Iff5PRc3LeqyzUtxnE1mU=;
  b=Daj0k4bM3/FTQZ0ecSkIDAMlGCqYPEPazddcJmR3ovf51MN0T2aFfQ72
   MqKecQyN2zJYx4PK7FBYot6D52cfgo/orw5+Zog58xY3t8NXAA7zMEwGH
   G198SA0FA/w4UjGXh0g906cK26FJqjEJ4ebi5JGe2qqT5sKTjbPPsHgtT
   Q=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: KGRUdP2v0oH7P4nMQgfwdFA1S41sBIWHVxMj8DjAfCtxfJRjYlSZOs1sC7awnzdN7DOrH5SEk+
 59U8/kDXRZBa6c/SobQloqS31B60j/xS7Pr4e/gyiEytSO/DnWGtzgjt8cJki3VOYK3YWFAypS
 0ivPodGIlw3w4xwOxrEexzmAjI/dE+IuMGuJMQKAgYuHqv0Y/3CCBReqAdlBHjxyU/X/rgBo2f
 GTm2nqNjFVF3M8l+DOClebYWSwX3+dH9ubqwu0AZJJ1E//sEGjM7yWyKueoqOxnNxNRrbMJaGw
 fsVZX+5IU7DBZfgzzRIRhOfm
X-SBRS: 5.1
X-MesageID: 59855129
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DQdMjqzh9Q2VndxUYot6t+cIwSrEfRIJ4+MujC+fZmUNrF6WrkVWm
 jEfDD2APa6MamrweN4kOoTg8kwDucfVn9NkHAdspSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbdi2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9Nck
 8dxpJqPcyQwLqHAh+cvDAtbDT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25EeQKuHP
 ZtxhTxHNVPKORwQHAktGakizNuHmmvEUQwAkQfAzUYwyzeKl1EguFT3C/LXdcaNXt59hVuDq
 yTN+GGRKg4eHMySz3yC6H3Erv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaDt8l3c
 hJOvHB09O5rqRLtHoKVswCETGCsvTNHSeZBFdIAyxidxqbL4DTGFGsaUWsUADA5j/MeSTsv3
 16PutrmAz1zrbGYIU6gGqeoQSCaYnZMczJbDcMQZU5cuoS4/tlv5v7aZo87SPbdszHjJd3nL
 9lmRgAajq5bs8ME3r7TEbvv02P1/cihouLYC2zqsoOZAuFROdfNi2+AswGzARN8wGGxFAbpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmr2qiX4IdANvWElfS+F1/ronhezP
 yfuVf55vscPbBNGk4cpC25ONyja5fe5Tom0PhwlRtFPfoJwZGe6ENJGPiatM5TWuBF0y8kXY
 M7DGe71VCpyIfk2lFKeGrZGuZd2l39W+I8mbc2ip/hR+eHFPyD9pHZsGAbmU93VG4vY+liIq
 IgGaJPRo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7r8aPfVhrHn8PEfjUze9zcoBphf0NxOzJ4
 mu8SglTz1+m3S/LLgCDa3ZCbrLzXMkg8SJnbHJ0ZVv4iWI+ZYuP7bsEc8dld7cQ6+E+n+V/S
 OMIepvcD60XGCjH4TkUcbL0sJdmKEawnQuLMif8OGo/cpdsShbn4NjhegezpiACAjDu7Zk1o
 qG61xOdSp0GHlwwAMHTYfOp7lWwoXlCx74iAxqWeoFeIRy+/pJrJir9iu4MD/sNcRiTlCGH0
 wu2AAsDobWfqYEC79SU17uPqJ2kErUiExMCTXXb97u/KQLT4nGnnd1bSO+NcD3QCDH09aGla
 bkHxv3wKqRazlNDso46GLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+8LoxayV
 2KO5sJeaOeAN87SGVIMIBYoM7aY3vYOlziOtfk4LS0WPsOsEGZrhamKAySxtQ==
IronPort-HdrOrdr: A9a23:l8dnBahCtI81lCBzDZ5d8cM80nBQXswji2hC6mlwRA09TySZ//
 rBoB17726StN9/YhEdcLy7VJVoIkmskaKdg7NhXotKNTOO0ADDQb2KhbGSpgEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,203,1635220800"; 
   d="scan'208";a="59855129"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, "Anthony
 PERARD" <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: [PATCH] tools/libfsimage: Bump SONAME to 4.17
Date: Mon, 13 Dec 2021 17:56:33 +0000
Message-ID: <20211213175633.30448-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>

This gets forgotten each release.  Any chance we can move libfsimage and/or
libacpi into libs/, where this issue would go away.
---
 tools/libfsimage/common/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
index 24bc90e73e71..54049ebaae86 100644
--- a/tools/libfsimage/common/Makefile
+++ b/tools/libfsimage/common/Makefile
@@ -1,7 +1,7 @@
 XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/libfsimage/Rules.mk
 
-MAJOR = 4.16
+MAJOR = 4.17
 MINOR = 0
 
 LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 18:08:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 18:08:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246254.424688 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwpkN-0007t9-3e; Mon, 13 Dec 2021 18:08:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246254.424688; Mon, 13 Dec 2021 18:08:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwpkM-0007t2-Vk; Mon, 13 Dec 2021 18:08:22 +0000
Received: by outflank-mailman (input) for mailman id 246254;
 Mon, 13 Dec 2021 18:08:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwpkL-0007ss-Ir; Mon, 13 Dec 2021 18:08:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwpkL-0001yh-Bl; Mon, 13 Dec 2021 18:08:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwpkL-0002rv-1n; Mon, 13 Dec 2021 18:08:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwpkL-0005e3-16; Mon, 13 Dec 2021 18:08:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2zVFt9tbieqrp6kmc5nwx7rl1r1KZY6bA/cA3No04+o=; b=6FddPEeKlKH8ha0B5lRizzgLcC
	jegA8TrZng2/1+Dj32zVH5ufW+fKG4mclafRFY665Lx902LmbzXpBCy6Q9yfMcsoPeqHCP4Panqwv
	DtDfyksX7MdRCvjeYkdB72RusC4/AcvYbf0nRJPAHQ9TrSTwSZkklSh7vmltTJrwndsY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167394-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167394: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7a6e6ae9332614d386446d2a73e34b74fe66446f
X-Osstest-Versions-That:
    ovmf=ec37fd9c1fbc6c14ad3291b415ad6677a022a554
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 13 Dec 2021 18:08:21 +0000

flight 167394 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167394/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7a6e6ae9332614d386446d2a73e34b74fe66446f
baseline version:
 ovmf                 ec37fd9c1fbc6c14ad3291b415ad6677a022a554

Last test of basis   167393  2021-12-13 13:42:29 Z    0 days
Testing same since   167394  2021-12-13 16:12:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Gerd Hoffmann <kraxel@redhat.com>
  Rebecca Cran <rebecca@bsdio.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   ec37fd9c1f..7a6e6ae933  7a6e6ae9332614d386446d2a73e34b74fe66446f -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 18:27:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 18:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246260.424702 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwq2H-00024m-P2; Mon, 13 Dec 2021 18:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246260.424702; Mon, 13 Dec 2021 18:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwq2H-00024f-J6; Mon, 13 Dec 2021 18:26:53 +0000
Received: by outflank-mailman (input) for mailman id 246260;
 Mon, 13 Dec 2021 18:26:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=zZ7V=Q6=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mwq2F-00023o-PN
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 18:26:51 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3b8c01fe-5c42-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 19:26:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b8c01fe-5c42-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639420010;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=sPFSPgzm1hHpqrOtJ71FOQQ04gHM4hHM6l1bwJhim8I=;
  b=OlRVZ7/o6DMSytLgSXfofKXCNM4TIU6Lwm0nQEo45aVw0xkXvSnsqY6y
   vI4DONL/QfyX+fGpGz/IZMEsMEGDEgxNskRLrqaiQ/EKKWyfImjgoiLgG
   A7Ga1tLOUM9tnKRaqzOZNW+1c4A2paYJcgrx9mi5YiiAYs58DBNhpbOd9
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: x0E7HybFPDv4L4iSGiXoOt+bdS6Yregvpq4sgt/tBaKaupieEEjCTGio6wb1KD3/t9RPBTQr0k
 D12ufgS0rbulYO1yQ8YRd2xrs/nJr4D1ff4f5N5h+Tj2cgualBoVucCrM6t35KBk/6yhNdvN6z
 hzMCiq2qXAFYF4Bx6L6rKsQqwUSGQ6/20PC15rM1jFkcqXrmgixpvAscMK1ktTl6Mmu5weULeG
 aSuByU/k7uX40xZjdroV8xtM303qJgykbuYhVRfrfRmxD4lDJzvgfTwTtV0M5YXphBhCfOjAF5
 eQF4v62uNH9XNygRnFGstFe0
X-SBRS: 5.1
X-MesageID: 59417079
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:pO6cqKu61UJ+OKLRsfxQzPrW7+fnVGlZMUV32f8akzHdYApBsoF/q
 tZmKTiPO/3fZ2fxfY9zOt/l8hkB7MWDxtIxQQA5qS5nQnxA+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy2IPhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplrJmVTF8XNJz1keExQyN9MRsiMvIe0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6DN
 pZANmIwPXwsZTVDF0w+JswTjN62oXf1L3pos0Cfl6g4tj27IAtZj+G2bYu9lsaxbcdahEGDv
 Urd4n/0RBodMbS31j6t4n+qwOjVkkvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJJFsg/sD+H+5Pd5iqJPE0mdGJON4QP4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud14WtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT1sDA3Dt4ade51q2VtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBu2oidBo0Yp1dEdMMX
 KM0kVkOjKK/wVPwNfMnC25PI5pCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrZFuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 4oFapbRlUwACLaWj+u+2dd7EG3m5EMTXfjew/G7vMbaSua/MG1+WfLX3507fIlpw/ZcmuvSp
 ynvUU5E0lvvw3bALFzSOHxkbbruW7d5rG46YnNwbQr5hSB7bNb99robers2YaIjqL5pw8lrQ
 qRXYM6HGPlOFGjKomxPcZnnoYV+Xx23ngbSbTG9aT0ycsc4FQzE89PpZCX18ywKAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIUzcn7/lP46Jc0IOC7v/DrC2
 lbEGwocqMnMv5QxrIvDi5ebotr7COB5BEdbQTXWtO7kKSnA82O/6oZcS+LULyvFXWb59aj+N
 +VYy/bwbK8OkFpQ6tcuFr9qyeQ15sf1pq8cxQNhRS2ZY1OuA7JmA3+HwcgQ6fEdmu4H4VO7C
 hCV591XGbSVI8e0QlceKT0sYvmHyfxJyCLZ6u44IRmi6SJ6lFZdvZ6+4/VYZPRhEYZI
IronPort-HdrOrdr: A9a23:ocQMpqk0ne/x2KwYiUxB60kgm3TpDfIs3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79
 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
X-IronPort-AV: E=Sophos;i="5.88,203,1635220800"; 
   d="scan'208";a="59417079"
Date: Mon, 13 Dec 2021 18:26:44 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: Re: [PATCH] tools/libfsimage: Bump SONAME to 4.17
Message-ID: <YbeQZM1dbs4OV267@perard>
References: <20211213175633.30448-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211213175633.30448-1-andrew.cooper3@citrix.com>

On Mon, Dec 13, 2021 at 05:56:33PM +0000, Andrew Cooper wrote:
> Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> 
> This gets forgotten each release.  Any chance we can move libfsimage and/or
> libacpi into libs/, where this issue would go away.

libfsimage is a weird kind of library, I don't think it's going to sit
well in libs/, and I don't think moving it just because MAJOR hasn't been
bumped is a good reason...

libacpi isn't a library, not really. It's a collection of source files
designed to be embedded into other programmes.

You know, we could simply replace "4.16" by
    $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
then we can forget libfsimage exist.

Any any case,
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
for this patch, or for using version.sh instead.

> ---
>  tools/libfsimage/common/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
> index 24bc90e73e71..54049ebaae86 100644
> --- a/tools/libfsimage/common/Makefile
> +++ b/tools/libfsimage/common/Makefile
> @@ -1,7 +1,7 @@
>  XEN_ROOT = $(CURDIR)/../../..
>  include $(XEN_ROOT)/tools/libfsimage/Rules.mk
>  
> -MAJOR = 4.16
> +MAJOR = 4.17
>  MINOR = 0
>  
>  LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 18:35:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 18:35:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246269.424713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqAx-0003jZ-PM; Mon, 13 Dec 2021 18:35:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246269.424713; Mon, 13 Dec 2021 18:35:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqAx-0003jS-MV; Mon, 13 Dec 2021 18:35:51 +0000
Received: by outflank-mailman (input) for mailman id 246269;
 Mon, 13 Dec 2021 18:35:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4QLc=Q6=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mwqAw-0003jM-Hj
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 18:35:50 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d865394-5c43-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 19:35:49 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:42894)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mwqAt-000b8T-8g (Exim 4.95) (return-path <amc96@srcf.net>);
 Mon, 13 Dec 2021 18:35:47 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6A7B9204C9;
 Mon, 13 Dec 2021 18:35:47 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d865394-5c43-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a2a8a913-ee28-87fa-5674-9a65bec94c90@srcf.net>
Date: Mon, 13 Dec 2021 18:35:47 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
References: <20211213175633.30448-1-andrew.cooper3@citrix.com>
 <YbeQZM1dbs4OV267@perard>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/libfsimage: Bump SONAME to 4.17
In-Reply-To: <YbeQZM1dbs4OV267@perard>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 13/12/2021 18:26, Anthony PERARD wrote:
> On Mon, Dec 13, 2021 at 05:56:33PM +0000, Andrew Cooper wrote:
>> Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Wei Liu <wl@xen.org>
>> CC: Anthony PERARD <anthony.perard@citrix.com>
>> CC: Juergen Gross <jgross@suse.com>
>>
>> This gets forgotten each release.  Any chance we can move libfsimage and/or
>> libacpi into libs/, where this issue would go away.
> libfsimage is a weird kind of library, I don't think it's going to sit
> well in libs/, and I don't think moving it just because MAJOR hasn't been
> bumped is a good reason...

Honestly, the better reasons is "because it's a library, it ought to
live in libs/ with the rest of them", but yeah, it is weird.  Perhaps
instead we want to tie it to pygrub so people have an easier time of
turning the whole lot off.

>
> libacpi isn't a library, not really. It's a collection of source files
> designed to be embedded into other programmes.

We'd normally call that libacpi.a, and it's perhaps a worthwhile change
to make.

>
> You know, we could simply replace "4.16" by
>     $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
> then we can forget libfsimage exist.
>
> Any any case,
> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
> for this patch, or for using version.sh instead.

Good shout.  I'll double check that

MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)

does the right thing, and commit that version.  One fewer thing to worry
about.

~Andrew


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 18:42:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 18:42:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246275.424723 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqGp-0005Iv-EI; Mon, 13 Dec 2021 18:41:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246275.424723; Mon, 13 Dec 2021 18:41:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqGp-0005Io-Az; Mon, 13 Dec 2021 18:41:55 +0000
Received: by outflank-mailman (input) for mailman id 246275;
 Mon, 13 Dec 2021 18:41:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x6XJ=Q6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mwqGo-0005Hw-Bg
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 18:41:54 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 563677cc-5c44-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 19:41:52 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 08EAB6111F;
 Mon, 13 Dec 2021 18:41:51 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E6E0C34600;
 Mon, 13 Dec 2021 18:41:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 563677cc-5c44-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639420910;
	bh=Sw7xlmG2qmtNlGOEIXu3rGHLUFCTwmkaMYWrFj13BQ8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=D2VwhDpctDjFEDwd/RWvL7dnbEMoJp73jOoWcrmU+JqjFvWJ4cfkE0Ye6aDRQ4w5P
	 76Q1m+8lZeL81eXHQJBrGJf4Ig/eh/lYJMNQ8LOIhcFW6CpxrUXtxPCfp16BII45bT
	 75wi/WUrH9KOLRZyFLixRt4mceUmlVquWbWK7YYAyV6oM8yqoojjQj8HPFgjefd3il
	 a9wFyfv9ox2tYXy+aS45AYnsr+a1roOzWWWPJDTEcadYqZiRMwgqPO7yPBDHKjOgy0
	 IGUViF9NL9t6RF47P6XU1QAzZQleU/QWR65CYEfffrVT9Ltd4k492DrfYuKQdzgj8c
	 zaOb0+QIqZiLQ==
Date: Mon, 13 Dec 2021 10:41:43 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] memory: XENMEM_add_to_physmap (almost) wrapping
 checks
In-Reply-To: <078a2f3d-c188-0a28-6265-dceef41cd6f3@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112131040580.3376@ubuntu-linux-20-04-desktop>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com> <0b68ff3a-3c82-f800-4d20-17eded13163a@suse.com> <612735b2-8af6-782d-35cf-526841109170@epam.com> <078a2f3d-c188-0a28-6265-dceef41cd6f3@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 13 Dec 2021, Jan Beulich wrote:
> On 10.12.2021 15:10, Oleksandr Andrushchenko wrote:
> > On 10.12.21 11:40, Jan Beulich wrote:
> >> --- a/xen/arch/arm/mm.c
> >> +++ b/xen/arch/arm/mm.c
> >> @@ -1479,7 +1479,7 @@ int xenmem_add_to_physmap_one(
> >>           break;
> >>       }
> >>       case XENMAPSPACE_dev_mmio:
> >> -        rc = map_dev_mmio_region(d, gfn, 1, _mfn(idx));
> >> +        rc = map_dev_mmio_region(d, gfn, _mfn(idx));
> > Technically this is ok, but reads odd now: the function maps a single
> > page, but its name has "region" in it (which might also be ok, e.g.
> > for a region of a single page).
> > 
> > I think it is worth either implementing full mfn range check inside
> > map_dev_mmio_region or renaming it to something else:
> > with mfn check map_dev_mmio_region will indeed be able to map
> > a region consisting of multiple pages and perform required validation.
> 
> Well, I had no maintainer comments on v1 regarding the name. I'd be
> happy to rename to e.g. map_dev_mmio_page(), so long as there can be
> an agreed upon name before I submit a possible v3. Julien, Stefano?

I like map_dev_mmio_page


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 19:07:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 19:07:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246280.424735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqfR-00080F-Dp; Mon, 13 Dec 2021 19:07:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246280.424735; Mon, 13 Dec 2021 19:07:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwqfR-000808-AZ; Mon, 13 Dec 2021 19:07:21 +0000
Received: by outflank-mailman (input) for mailman id 246280;
 Mon, 13 Dec 2021 19:07:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VEuh=Q6=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mwqfQ-000802-JU
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 19:07:20 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e3b324e5-5c47-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 20:07:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3b324e5-5c47-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639422438;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=8ru3lFSf84OZ17ioZSPEU1QzbNuOpBrkz3ImK0ue+tw=;
  b=GhrE9rqfBMU4jZf4iC7aj9O/jjSvQVCivMpfu9jRVHyhjj/B58WEA1Qn
   wVHGQjJT6V9+R0lJDoJ85zq8Gu9BCYeYmqEHsSQSXFvBGoI5B+NeCdgkI
   A/CTFIyMzou9JIM3YhJwIvidONCsLaTla5c5hiwcMQ+fkBs7uiiZDUj34
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: KsaWIhNLvGOXcdLd28a8g/6bCkbsDR2v+kjJgEFTL47kuMHiQtrODB8K7N4dp0cWM2xYFCJrB0
 VyzVWtwYDEzeHPNXfsswUc2WxoxKMLeOmJGNkyZQahX5GOOkPe0EQZMzJAEOSNsknCd2mBfw11
 ixmrGBoP4uMM88f8Th1UQOmnkuzqlJGUQ5hZUUQOKFbYLY4t3amBYiTaGEoX81O/uZ7KyVtsCH
 Mv9LVc1J3HIt1easU7bWxOaFKpg2IKNtIXZZ9ICF+Xe1ZpAwcRzOqbQzVKLeq8Ml4c2jl+iI5K
 Ru0Bb81AQCcCcgOB/Y01+Via
X-SBRS: 5.1
X-MesageID: 59420564
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:T40yZ6qdO1XHrH21A4S5cDp4KC1eBmInYhIvgKrLsJaIsI4StFCzt
 garIBnQOf+JMGCkf4h1atjlphwGvcKAx4JhTABqqSk3EHlHoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24HiW1jlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnb+caV8wG4Lcors2Cwl2Si97DKBjpaCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O
 ptFM2IyMkiojxtnGGk0WIlljOWT32T1IwFCpWO2jvs+2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkYO8aY0iGt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4MMEasBio5bruvC3BFkZdQDtwZfl7q5pjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoStQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtAGzARVodt/xory9U
 J8swZf20Qz2JcvR/BFhuc1UdF1T296LMSfHnXlkFIQ7+jKm9haLJN4LsWoleBc0b5ZfIFcFh
 XM/XisLu/du0IaCN/crM+pd9ex0pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pMidcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4DbZbXkEsGD7WlCsQVmKZKRW03wbEALcieg6RqmiSreWKKwUktVK3cx60PYYtgk/gHn+vE5
 CjlCERZ1ED+lTvMLgDTMiJvb7bmXJBeq3MnPHNzYQb0iiZ7OYv/vr0Cc5YXfKU88LAxx/BDU
 PRYKd6LBe5CS2qb9m1FP4X9toFraD+imRmKY3i+eDE6cpM5H17J99bocxHB7i4LCibr58Iyr
 6f5jlHQQIYZRhQkB8HTMar9w1S0tHkbueRzQ0qXfYUDJBSyqNBncnWjgOU2LscALQT46gGbj
 wvGUw0FoeTtopMu9IWbj66zsIr0QfB1GVBXHjeH4O/uZzXa5Geq3aRJTP2MIWLGTGrx9aivO
 bdVwvX7PKFVlVpGqdMhQbNizKZ47Nrzvb5KiA9jGSyTPVisD7phJFiA3NVO6fIRluMI51PuV
 xLd4MReNJWIJNjhQQwYKwcSZ+ie0e0Zx2vJ5vMvLUSmvCJ68dJri6mJ08VgXMCFEIZIDQ==
IronPort-HdrOrdr: A9a23:NcZcC6NIEWjrF8BcTtejsMiBIKoaSvp037Eqv3oedfU1SL3+qy
 nAppQmPHPP5Ar5O0tQ/exoWpPwIk80nKQdieJ6UItKNDOW3VdAR7sC0WKN+VLd8lXFh4xg6Z
 s=
X-IronPort-AV: E=Sophos;i="5.88,203,1635220800"; 
   d="scan'208";a="59420564"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>, Anthony PERARD
	<anthony.perard@citrix.com>
Subject: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell ...)
Date: Mon, 13 Dec 2021 19:04:49 +0000
Message-ID: <20211213190449.4830-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

?= is a deferred assignment.  Switch to an alternative form which lets us use
an immediate assignment.

Before, version.sh gets run anywhere between 46 and 88 times, with 50 on a
`clean`.  After, 6 times, invariant of main rune, and whether it is an
incremental build or not.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Juergen Gross <jgross@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>

The identity transform comes from the docs
https://www.gnu.org/software/make/manual/make.html#Flavors (final paragraph).

Something slightly weird is going on.  Before this, the exact number of hits
that verson.sh gets isn't stable, even when running repeat incremental builds.
I suspect this means we've got a lurking parallel build issue.
---
 tools/libs/libs.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
index dfbbef4080f6..b21e0bf083a0 100644
--- a/tools/libs/libs.mk
+++ b/tools/libs/libs.mk
@@ -6,7 +6,10 @@
 #   MINOR:   minor version of lib (0 if empty)
 
 LIBNAME := $(notdir $(CURDIR))
-MAJOR ?= $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
+
+ifeq ($(origin MAJOR), undefined)
+MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
+endif
 MINOR ?= 0
 
 SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Mon Dec 13 21:19:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 21:19:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246303.424754 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwsj7-0005RO-2Q; Mon, 13 Dec 2021 21:19:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246303.424754; Mon, 13 Dec 2021 21:19:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwsj6-0005Qz-Uq; Mon, 13 Dec 2021 21:19:16 +0000
Received: by outflank-mailman (input) for mailman id 246303;
 Mon, 13 Dec 2021 21:19:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4sGW=Q6=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwsj5-0005QX-Pt
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 21:19:15 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 507b97a9-5c5a-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 22:19:11 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 2B80938A;
 Mon, 13 Dec 2021 22:19:10 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id rsLAX-jPuo-M; Mon, 13 Dec 2021 22:19:09 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 664EF18A;
 Mon, 13 Dec 2021 22:19:09 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwsix-006yxI-AC;
 Mon, 13 Dec 2021 22:19:07 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 507b97a9-5c5a-11ec-85d3-df6b77346a89
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Mon, 13 Dec 2021 22:19:07 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
Message-ID: <20211213211907.lbjjnvayklf7qucb@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
 <20211212000558.232nzs7k5lklpbym@begin>
 <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 2B80938A
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 13 déc. 2021 15:56:21 +0100, a ecrit:
> On 12.12.21 01:05, Samuel Thibault wrote:
> > Hello,
> > 
> > Juergen Gross, le lun. 06 déc. 2021 08:23:29 +0100, a ecrit:
> > > - align the entries to page boundaries
> > 
> > > +    /* Adjust map entries to page boundaries. */
> > > +    for ( i = 0; i < e820_entries; i++ )
> > > +    {
> > > +        end = (e820_map[i].addr + e820_map[i].size + PAGE_SIZE - 1) & PAGE_MASK;
> > > +        e820_map[i].addr &= PAGE_MASK;
> > > +        e820_map[i].size = end - e820_map[i].addr;
> > > +    }
> > 
> > Mmm, what if the previous entry ends after the aligned start?
> > 
> > On real machines that does happen, and you'd rather round up the start
> > address of usable areas, rather than rounding it down (and conversely
> > for the end).
> 
> I think you are partially right. :-)
> 
> Entries for resources managed by Mini-OS (RAM, maybe NVME?) should be
> rounded to cover only complete pages (start rounded up, end rounded
> down), but all other entries should be rounded to cover the complete
> area (start rounded down, end rounded up) in order not to use any
> partial used page for e.g. mapping foreign pages.

Right!

> > > +    /* Sort entries by start address. */
> > > +    for ( i = 0; i < e820_entries - 1; i++ )
> > > +    {
> > > +        if ( e820_map[i].addr > e820_map[i + 1].addr )
> > > +        {
> > > +            e820_swap_entries(i, i + 1);
> > > +            i = -1;
> > > +        }
> > > +    }
> > 
> > This looks O(n^3) to me? A bubble sort like this should be fine:
> > 
> >      /* Sort entries by start address. */
> >      for ( last = e820_entries; last > 1; last-- )
> >      {
> >          for ( i = 0; i < last - 1; i++ )
> >          {
> >              if ( e820_map[i].addr > e820_map[i + 1].addr )
> >              {
> >                  e820_swap_entries(i, i + 1);
> >              }
> >          }
> >      }
> 
> Hmm, depends.
> 
> Assuming a rather well sorted map my version is O(n), while yours
> is still O(n^2).

Right, I was a bit lazy :)

This should be fine:

/* Sort entries by start address. */
for ( i = 1; i < e820_entries; i++ )
    for ( j = i; j > 0 && e820_map[j-1].addr > e820_map[j].addr ) ; j-- )
        e820_swap_entries(j - 1, j);

> I'm fine both ways, whatever you prefer.

I really prefer for loops which don't unexpectedly modify their loop
index, that's much less scary :)

Samuel


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 21:22:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 21:22:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246309.424769 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwslu-0006tE-IQ; Mon, 13 Dec 2021 21:22:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246309.424769; Mon, 13 Dec 2021 21:22:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwslu-0006t7-F8; Mon, 13 Dec 2021 21:22:10 +0000
Received: by outflank-mailman (input) for mailman id 246309;
 Mon, 13 Dec 2021 21:22:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4sGW=Q6=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mwslt-0006qn-TK
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 21:22:09 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ba0c8745-5c5a-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 22:22:08 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id C313538A;
 Mon, 13 Dec 2021 22:22:07 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 9VvTf2Be1UGX; Mon, 13 Dec 2021 22:22:07 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 25AD4229;
 Mon, 13 Dec 2021 22:22:07 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mwslq-006yzC-C0;
 Mon, 13 Dec 2021 22:22:06 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ba0c8745-5c5a-11ec-85d3-df6b77346a89
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Mon, 13 Dec 2021 22:22:06 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
Message-ID: <20211213212206.htg4eykr32x63swk@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
 <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: C313538A
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 13 déc. 2021 15:58:58 +0100, a ecrit:
> On 12.12.21 01:15, Samuel Thibault wrote:
> > Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit:
> > > -    unsigned long pfn, max = 0;
> > > +    unsigned long pfns, max = 0;
> > 
> > I'd say rather rename max to start.
> > 
> > >       e820_get_memmap();
> > > @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
> > >       {
> > >           if ( e820_map[i].type != E820_RAM )
> > >               continue;
> > > -        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> > > -        if ( pfn > max )
> > > -            max = pfn;
> > > +        pfns = e820_map[i].size >> PAGE_SHIFT;
> > > +        max = e820_map[i].addr >> PAGE_SHIFT;
> > 
> > since it's it's always the start of the e820 entry.
> > 
> > > +        if ( pages <= pfns )
> > > +            return max + pages;
> > > +        pages -= pfns;
> > > +        max += pfns;
> > 
> > Here we don't need do change max, only pages.
> 
> It is needed in case the loop is finished.
> 
> And this was the reason for naming it max.

Ah, ok.

At first read the name was confusing me. Perhaps better use two
variables then: start and max, so that we have

start = e820_map[i].addr >> PAGE_SHIFT;
if ( pages <= pfns )
    return start + pages;
pages -= pfns;
max = start + pfns;

Samuel


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 21:38:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 21:38:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246315.424780 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwt1Y-00009u-06; Mon, 13 Dec 2021 21:38:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246315.424780; Mon, 13 Dec 2021 21:38:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwt1X-00009m-Sc; Mon, 13 Dec 2021 21:38:19 +0000
Received: by outflank-mailman (input) for mailman id 246315;
 Mon, 13 Dec 2021 21:38:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x6XJ=Q6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mwt1X-00009g-0Q
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 21:38:19 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fb2be206-5c5c-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 22:38:17 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id B17A3B815C6;
 Mon, 13 Dec 2021 21:38:15 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35315C34600;
 Mon, 13 Dec 2021 21:38:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb2be206-5c5c-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639431494;
	bh=vbVv8bv33hlXicn8w2PRzVbOWmmZ1tS837zrDbSvNlU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=uivK7tmtyhf52O3HplxKIGBWlIOEq9JH9bIF1QAihq+h/icb8T8U8kshDAy/UW3r3
	 03xb/oVHOz4mskz6JrwNBN8zvqLakkjcxiW6m3Xj38/+0zPwWq+e5zIe5c+2PXLHED
	 +utSOm+7zAKS0wZh8elO5zQ6TWWozIVSJhIRohgcqainU6k85xENoDZr6j3gIaIS8Z
	 YWmU/ANyRfXxKhQS6g5Orr6hOx1K6/PLN2LILxG4lwRLMVPkLOCE2AvxF3GmgXL1Rs
	 zMLMklGvtL/U1wPV9PA7ShFO6YX+bY8/acOifWqsO02VXzqkC8VUr28k4pjd6TpLY/
	 WH6SSWVu6zh8Q==
Date: Mon, 13 Dec 2021 13:38:14 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: increase memory banks number define value
In-Reply-To: <20211213114823.25570-1-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2112131337570.3376@ubuntu-linux-20-04-desktop>
References: <20211213114823.25570-1-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 13 Dec 2021, Luca Fancellu wrote:
> Currently the maximum number of memory banks (NR_MEM_BANKS define)
> is fixed to 128, but on some new platforms that have a large amount
> of memory, this value is not enough and prevents Xen from booting.
> 
> Increase the value to 256.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/include/asm-arm/setup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..07daf160dc57 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -6,7 +6,7 @@
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
>  
> -#define NR_MEM_BANKS 128
> +#define NR_MEM_BANKS 256
>  
>  #define MAX_MODULES 32 /* Current maximum useful modules */
>  
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Mon Dec 13 21:48:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 13 Dec 2021 21:48:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246320.424791 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwtBE-0001mc-V7; Mon, 13 Dec 2021 21:48:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246320.424791; Mon, 13 Dec 2021 21:48:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwtBE-0001mV-S5; Mon, 13 Dec 2021 21:48:20 +0000
Received: by outflank-mailman (input) for mailman id 246320;
 Mon, 13 Dec 2021 21:48:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=x6XJ=Q6=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mwtBD-0001mP-N0
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 21:48:19 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61fec5b5-5c5e-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 22:48:18 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 63AE3B816AF;
 Mon, 13 Dec 2021 21:48:14 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C56E7C34601;
 Mon, 13 Dec 2021 21:48:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61fec5b5-5c5e-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639432093;
	bh=1cnD1O/VeCmLflBUi0Sr2SSNlLd75eWhRz2JHZl5nqM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ujjSIJgFSS0OVfXxRZZXuxP1RuaL20zq9LnbVVxJ9WZDn/LlHyuWiaLwb/xpLjeML
	 ii03J+FhQmtEu2N1Fur5O8A6LlyhLG+uKVHYLxoegjhAVLryWSMOHnYwIdDYkcQfST
	 jA311eD09dv2qCXDOnji6uie2AXLBnjGsWlamP2Apra4aYtXOFeyxX2HaZpMTeYk2Y
	 OdQIHVYhc+9teab4Xs6NkXq3YAJf8+BYqWo9dEr1kXU52Novur48ZooMgVrIpduc4S
	 sot8iG8uk42TKjNesvLDoERIb+nKFRCRUSAvXDYTpiZK68Wdefze4zw46MHczTY+Z/
	 lghRAP3jw7QMg==
Date: Mon, 13 Dec 2021 13:48:13 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Luca Fancellu <luca.fancellu@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, wei.chen@arm.com, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH v2] arm/efi: Handle Xen bootargs from both xen.cfg and
 DT
In-Reply-To: <20211213114854.25632-1-luca.fancellu@arm.com>
Message-ID: <alpine.DEB.2.22.394.2112131347300.3376@ubuntu-linux-20-04-desktop>
References: <20211213114854.25632-1-luca.fancellu@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 13 Dec 2021, Luca Fancellu wrote:
> Currently the Xen UEFI stub can accept Xen boot arguments from
> the Xen configuration file using the "options=" keyword, but also
> directly from the device tree specifying xen,xen-bootargs
> property.
> 
> When the configuration file is used, device tree boot arguments
> are ignored and overwritten even if the keyword "options=" is
> not used.
> 
> This patch handle this case, so if the Xen configuration file is not
> specifying boot arguments, the device tree boot arguments will be
> used, if they are present.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> v2 changes:
>  - Changed logic, now xen cfg bootarg value has precedence over DT
> ---
>  docs/misc/efi.pandoc        |  4 ++++
>  xen/arch/arm/efi/efi-boot.h | 15 +++++++++++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index abafb3452758..71fdc316b67b 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -249,6 +249,10 @@ UEFI stub for module loading.
>  When adding DomU modules to device tree, also add the property
>  xen,uefi-cfg-load under chosen for Xen to load the Xen config file.
>  Otherwise, Xen will skip the config file and rely on device tree alone.
> +When using the Xen configuration file in conjunction with the device tree, you
> +can specify the Xen boot arguments in the configuration file with the "options="
> +keyword or in the device tree with the "xen,xen-bootargs" property, but be
> +aware that the Xen configuration file value has a precedence over the DT value.
>  
>  Example 1 of how to boot a true dom0less configuration:
>  
> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
> index 4fb345f225c8..ae8627134e5a 100644
> --- a/xen/arch/arm/efi/efi-boot.h
> +++ b/xen/arch/arm/efi/efi-boot.h
> @@ -503,11 +503,26 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name,
>  
>      if ( cfgfile_options )
>      {
> +        PrintMessage(L"Using bootargs from Xen configuration file.");
>          prop_len += snprintf(buf + prop_len,
>                                 EFI_PAGE_SIZE - prop_len, " %s", cfgfile_options);
>          if ( prop_len >= EFI_PAGE_SIZE )
>              blexit(L"FDT string overflow");
>      }
> +    else
> +    {
> +        /* Get xen,xen-bootargs in /chosen if it is specified */
> +        const char *dt_bootargs_prop = fdt_getprop(fdt, chosen,
> +                                                   "xen,xen-bootargs", NULL);
> +        if ( dt_bootargs_prop )
> +        {
> +            PrintMessage(L"Using bootargs from device tree.");
> +            prop_len += snprintf(buf + prop_len, EFI_PAGE_SIZE - prop_len,
> +                                 " %s", dt_bootargs_prop);
> +            if ( prop_len >= EFI_PAGE_SIZE )
> +                blexit(L"FDT string overflow");
> +        }
> +    }
>  
>      if ( cmdline_options )
>      {
> -- 
> 2.17.1
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 00:34:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 00:34:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246332.424806 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwvks-0003Ng-Na; Tue, 14 Dec 2021 00:33:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246332.424806; Tue, 14 Dec 2021 00:33:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwvks-0003NZ-KN; Tue, 14 Dec 2021 00:33:18 +0000
Received: by outflank-mailman (input) for mailman id 246332;
 Tue, 14 Dec 2021 00:33:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwvkr-0003NP-23; Tue, 14 Dec 2021 00:33:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwvkq-0000a7-LY; Tue, 14 Dec 2021 00:33:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwvkq-0006Tb-DU; Tue, 14 Dec 2021 00:33:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwvkq-0000nB-D1; Tue, 14 Dec 2021 00:33:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=H9rhy+0DcsxuAx+/9XbjKM9FuI/iJy19hfD3LsPj7gw=; b=SHrB1v1I4xwIVxoQHoRI7drURg
	0SgqlrxCeBd9B8c/CSrUFYeJSO7gJR7SN0GJhjhg320L+2uAWqQYfyQfR/R+Wk+02IzgFa1EP/cne
	HwtI7DkbuF9n1FQq1llXGmrh46bvBo9LNIeypKfJBlMukRExnr7bD2HDG0U28z90BPbI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167400-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167400: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 00:33:16 +0000

flight 167400 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167400/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167343  2021-12-10 15:01:44 Z    3 days
Testing same since   167400  2021-12-13 20:00:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   df3e1a5efe..d828caa9ae  d828caa9aeee80c59a35f662f875f6573e9b532f -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 04:08:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 04:08:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246350.424820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwz6i-0002OA-7d; Tue, 14 Dec 2021 04:08:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246350.424820; Tue, 14 Dec 2021 04:08:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mwz6i-0002O3-3t; Tue, 14 Dec 2021 04:08:04 +0000
Received: by outflank-mailman (input) for mailman id 246350;
 Tue, 14 Dec 2021 04:08:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwz6g-0002Nt-Bg; Tue, 14 Dec 2021 04:08:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwz6f-00069K-U4; Tue, 14 Dec 2021 04:08:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mwz6f-0001Da-D1; Tue, 14 Dec 2021 04:08:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mwz6f-0008Nc-CV; Tue, 14 Dec 2021 04:08:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YDyEasyFOlHj2o4OfU4SQuRpl1isEHwc1o0WdLuMSWs=; b=1NIDslQJaS4zSwaDDk/nQYwnfk
	2W3m96qnCFSLTmSK4QXGGepWSN7w4MCN7wk0mLaQCj4b3xsGBFLMUf7+sald+1zz3mMWun65yUokI
	Zn1s3OhxsFLLIdQhswL6q02OitKqnqJJjEIM/Hgs7W25u8219odySqFgdQQNc1Z3diIk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167399-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167399: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=aa50faff4416c869b52dff68a937c84d29e12f4b
X-Osstest-Versions-That:
    linux=2585cf9dfaaddf00b069673f27bb3f8530e2039c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 04:08:01 +0000

flight 167399 linux-linus real [real]
flight 167403 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167399/
http://logs.test-lab.xenproject.org/osstest/logs/167403/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-credit2   8 xen-boot            fail pass in 167403-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 167403 never pass
 test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 167403 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167389
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167389
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167389
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167389
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167389
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167389
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167389
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167389
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167389
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                aa50faff4416c869b52dff68a937c84d29e12f4b
baseline version:
 linux                2585cf9dfaaddf00b069673f27bb3f8530e2039c

Last test of basis   167389  2021-12-13 03:17:19 Z    1 days
Testing same since   167399  2021-12-13 19:39:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Carel Si <beibei.si@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Sergio Paracuellos <sergio.paracuellos@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  fail    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2585cf9dfaad..aa50faff4416  aa50faff4416c869b52dff68a937c84d29e12f4b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 05:11:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 05:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246246.424839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-00020D-7F; Tue, 14 Dec 2021 05:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246246.424839; Tue, 14 Dec 2021 05:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-0001yw-1e; Tue, 14 Dec 2021 05:10:37 +0000
Received: by outflank-mailman (input) for mailman id 246246;
 Mon, 13 Dec 2021 17:58:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YnPn=Q6=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mwpaY-0006fT-4m
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 17:58:14 +0000
Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3b4fff4e-5c3e-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 18:58:12 +0100 (CET)
Received: from fllv0034.itg.ti.com ([10.64.40.246])
 by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHvDFk057657;
 Mon, 13 Dec 2021 11:57:13 -0600
Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25])
 by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BDHvDLj096173
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 13 Dec 2021 11:57:13 -0600
Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE104.ent.ti.com
 (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 13
 Dec 2021 11:57:13 -0600
Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE100.ent.ti.com
 (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Mon, 13 Dec 2021 11:57:13 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHvD5s011601;
 Mon, 13 Dec 2021 11:57:13 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3b4fff4e-5c3e-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639418233;
	bh=9CyMhPc/idrcBzNkExaZ5vJ4o9phUqUECb1RhDx4I4E=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=mHuWgUI/Z9Q9zRgSgPTxkHuzsmgOInjmgLI6oNat8MEl1rVUR+hb8QQszr+XW1ErC
	 PO7AazLDEhdfY/GfqbD/O+rGEywTCE9Fp/6RkHPntLuCvdywuxKrSkNUVfJNoH2r7T
	 EZkIsfSC6RNMlmKII/6L/Xm/5irlLAudxgFQsbTY=
Date: Mon, 13 Dec 2021 11:57:12 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt
	<benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>, Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Will Deacon
	<will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, Joerg Roedel
	<joro@8bytes.org>,
        <iommu@lists.linux-foundation.org>,
        Jassi Brar
	<jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan
 Kaya <okaya@kernel.org>
Subject: Re: [patch V3 22/35] soc: ti: ti_sci_inta_msi: Use
 msi_desc::msi_index
Message-ID: <20211213175712.t5xghmso6q4vpg7n@rifling>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.540704224@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211210221814.540704224@linutronix.de>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 23:19-20211210, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Use the common msi_index member and get rid of the pointless wrapper struct.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-arm-kernel@lists.infradead.org

Acked-by: Nishanth Menon <nm@ti.com>
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 05:11:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 05:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246248.424844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-00022l-FC; Tue, 14 Dec 2021 05:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246248.424844; Tue, 14 Dec 2021 05:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-00021k-8w; Tue, 14 Dec 2021 05:10:37 +0000
Received: by outflank-mailman (input) for mailman id 246248;
 Mon, 13 Dec 2021 17:58:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YnPn=Q6=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mwpaq-0006i1-9C
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 17:58:32 +0000
Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 460959c7-5c3e-11ec-9e60-abaf8a552007;
 Mon, 13 Dec 2021 18:58:29 +0100 (CET)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
 by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHvg60044666;
 Mon, 13 Dec 2021 11:57:43 -0600
Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24])
 by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BDHvgPV120889
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 13 Dec 2021 11:57:42 -0600
Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE103.ent.ti.com
 (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 13
 Dec 2021 11:57:42 -0600
Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE113.ent.ti.com
 (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Mon, 13 Dec 2021 11:57:42 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHvg6L017557;
 Mon, 13 Dec 2021 11:57:42 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 460959c7-5c3e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639418263;
	bh=pGs+7nCpdx7S5XWFe/UO8XALjMbjY1+VfXkPmDrylYE=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=TereNqQsHrOJN5x2htMCys19fN9lF6WIIbjFUj5DyrKhTGgPXKwfNA/gNxTT6+77z
	 JRw2kQu/xJl8fmFScS+cwwxZ07+XG8xXUbwh8Kk8HR+9ArnUZz+3a5U0jiM3or8k0i
	 mUKft05BDVfyOiq0ie7rKisbaUamlftbBRwigjBY=
Date: Mon, 13 Dec 2021 11:57:41 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter Ujfalusi
	<peter.ujfalusi@gmail.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt
	<benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>, Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Mark Rutland
	<mark.rutland@arm.com>, Will Deacon <will@kernel.org>,
        Robin Murphy
	<robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
        <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of
 ti_sci_inta_msi_get_virq()
Message-ID: <20211213175741.yxabloph4dr37dmt@abroad>
References: <20211210221642.869015045@linutronix.de>
 <20211210221815.269468319@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211210221815.269468319@linutronix.de>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 23:19-20211210, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Just use the core function msi_get_virq().
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org

Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 05:11:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 05:11:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246267.424850 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-0002BY-Qg; Tue, 14 Dec 2021 05:10:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246267.424850; Tue, 14 Dec 2021 05:10:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05F-00028R-Iu; Tue, 14 Dec 2021 05:10:37 +0000
Received: by outflank-mailman (input) for mailman id 246267;
 Mon, 13 Dec 2021 18:31:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YnPn=Q6=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mwq6U-0003ez-8e
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 18:31:14 +0000
Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d7c146ac-5c42-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 19:31:12 +0100 (CET)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
 by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BDITweD032784;
 Mon, 13 Dec 2021 12:29:58 -0600
Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34])
 by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BDITwlR038320
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 13 Dec 2021 12:29:58 -0600
Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE113.ent.ti.com
 (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 13
 Dec 2021 12:29:58 -0600
Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE108.ent.ti.com
 (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Mon, 13 Dec 2021 12:29:58 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BDITwZX089938;
 Mon, 13 Dec 2021 12:29:58 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d7c146ac-5c42-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639420199;
	bh=CIwJXsDVc6MpWMxloZbtRdlpLw1Ztan/9G2UzPwMY0E=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=aQr+rT7AbNmri1BYm4glcZYUB4D0/LtbXNn0eGzLe1Xq4LgTziMH/fZw9NMlUSxOJ
	 eUvgRnz/JUOtWmI/LUlydZmqlDtGvShVqc/335BSewifnzHFovUoMb7LUYizCR9g/k
	 /rYDbql0vQTQMlM2Nnxl+1kL4PPvB9mCQmf5UIQI=
Date: Mon, 13 Dec 2021 12:29:58 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Juergen Gross
	<jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann
	<arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin
 Herrenschmidt <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, Mark Rutland
	<mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Message-ID: <20211213182958.ytj4m6gsg35u77cv@detonator>
References: <20211210221642.869015045@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211210221642.869015045@linutronix.de>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 23:18-20211210, Thomas Gleixner wrote:
[...]

> 
> It's also available from git:
> 
>      git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v3-part-2

[...]

> ---
>  drivers/dma/ti/k3-udma-private.c                    |    6 
>  drivers/dma/ti/k3-udma.c                            |   14 -
>  drivers/irqchip/irq-ti-sci-inta.c                   |    2 
>  drivers/soc/ti/k3-ringacc.c                         |    6 
>  drivers/soc/ti/ti_sci_inta_msi.c                    |   22 --
>  include/linux/soc/ti/ti_sci_inta_msi.h              |    1 

Also while testing on TI K3 platforms, I noticed:

msi_device_data_release/msi_device_destroy_sysfs in am64xx-evm / j7200
[1] https://gist.github.com/nmenon/36899c7819681026cfe1ef185fb95f33#file-am64xx-evm-txt-L1018
[2] https://gist.github.com/nmenon/36899c7819681026cfe1ef185fb95f33#file-j7200-evm-txt-L1076

Which is not present in vanilla v5.16-rc4

v5.16-rc4:
https://gist.github.com/nmenon/1aee3f0a7da47d5e9dcb7336b32a70cb

msi-v3-part-2:
https://gist.github.com/nmenon/36899c7819681026cfe1ef185fb95f33

(.config https://gist.github.com/nmenon/ec6f95303828abf16a64022d8e3a269f)

Vs:
next-20211208:
https://gist.github.com/nmenon/f5ca3558bd5c1fbe62dc5ceb420b536e

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 05:11:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 05:11:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246244.424834 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05E-0001wt-U9; Tue, 14 Dec 2021 05:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246244.424834; Tue, 14 Dec 2021 05:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx05E-0001wm-QG; Tue, 14 Dec 2021 05:10:36 +0000
Received: by outflank-mailman (input) for mailman id 246244;
 Mon, 13 Dec 2021 17:58:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=YnPn=Q6=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mwpaP-0006fT-Qd
 for xen-devel@lists.xenproject.org; Mon, 13 Dec 2021 17:58:06 +0000
Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 366a722d-5c3e-11ec-85d3-df6b77346a89;
 Mon, 13 Dec 2021 18:58:03 +0100 (CET)
Received: from fllv0034.itg.ti.com ([10.64.40.246])
 by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHujtF024081;
 Mon, 13 Dec 2021 11:56:45 -0600
Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26])
 by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BDHujCb095191
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 13 Dec 2021 11:56:45 -0600
Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE115.ent.ti.com
 (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 13
 Dec 2021 11:56:45 -0600
Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE112.ent.ti.com
 (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Mon, 13 Dec 2021 11:56:45 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BDHuiov010619;
 Mon, 13 Dec 2021 11:56:44 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 366a722d-5c3e-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639418205;
	bh=a28kR5uLU4CD//Euze4R1opzKiH1O9AJ1Fk3ypys7po=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=peIGlhxdMjC3Tv7BKDuC4dnIJLJD6NNqavyceGxzcMAbairrnjR3yTGhM8fnpSB+o
	 LGnxmZZ+cPdn3cdj2Vh+HIDRSsHJFI5t6VLAnJoolBDO5WfVc3E6rlks1pUGJ4Legj
	 6gdbz27M7Fz8c/olN0n/YrBf2Pb3R5c8bQO/HjxI=
Date: Mon, 13 Dec 2021 11:56:43 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt
	<benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>, Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Will Deacon
	<will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, Joerg Roedel
	<joro@8bytes.org>,
        <iommu@lists.linux-foundation.org>,
        Jassi Brar
	<jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan
 Kaya <okaya@kernel.org>
Subject: Re: [patch V3 12/35] soc: ti: ti_sci_inta_msi: Allocate MSI device
 data on first use
Message-ID: <20211213175643.2gmosys3o4g4hsrb@cursor>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.928842960@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211210221813.928842960@linutronix.de>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 23:19-20211210, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Allocate the MSI device data on first invocation of the allocation function.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Cc: Santosh Shilimkar <ssantosh@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org


Acked-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 06:24:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 06:24:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246376.424881 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1EX-0003Fi-Dw; Tue, 14 Dec 2021 06:24:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246376.424881; Tue, 14 Dec 2021 06:24:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1EX-0003Fb-B6; Tue, 14 Dec 2021 06:24:17 +0000
Received: by outflank-mailman (input) for mailman id 246376;
 Tue, 14 Dec 2021 06:24:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx1EW-0003FR-V1; Tue, 14 Dec 2021 06:24:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx1EW-0000VU-OH; Tue, 14 Dec 2021 06:24:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx1EW-0008R8-C7; Tue, 14 Dec 2021 06:24:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mx1EW-0003gL-BR; Tue, 14 Dec 2021 06:24:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=FQg/Wrbq7IbG+SLgVTCSnf0OJjCMZxwnmE5hhB9pLgg=; b=EfH3OFS9JPDLKI+8v56BBT/Qoe
	ZJva1flGrGElXokxphyfO0AD6fjL13lBsJRv8nqq3FS1l+fkcA2fPDzYh6vDBHBuY8gDAKV9fb4Z5
	KDQMt23ep97A6AtWZ5rl20S4WBF7FNpQVDD+8/DbiWAP5tjQ4Mfn23Q0cSa62IprwpY4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167401-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.16-testing test] 167401: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:xen-boot:fail:heisenbug
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d0d0af67eede560faab58f161d9608a69c779d41
X-Osstest-Versions-That:
    xen=2dcea9c94c59cf2a9c7ee824a573f7c1b864b5d5
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 06:24:16 +0000

flight 167401 xen-4.16-testing real [real]
flight 167406 xen-4.16-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167401/
http://logs.test-lab.xenproject.org/osstest/logs/167406/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-multivcpu  8 xen-boot           fail pass in 167406-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 167406 never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 167406 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167218
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167218
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167218
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167218
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167218
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167218
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167218
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167218
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167218
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167218
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167218
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167218
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d0d0af67eede560faab58f161d9608a69c779d41
baseline version:
 xen                  2dcea9c94c59cf2a9c7ee824a573f7c1b864b5d5

Last test of basis   167218  2021-12-06 16:06:39 Z    7 days
Testing same since   167401  2021-12-13 22:07:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                fail    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   2dcea9c94c..d0d0af67ee  d0d0af67eede560faab58f161d9608a69c779d41 -> stable-4.16


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 06:33:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 06:33:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246384.424896 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1N3-0004u5-FF; Tue, 14 Dec 2021 06:33:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246384.424896; Tue, 14 Dec 2021 06:33:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1N3-0004ty-C7; Tue, 14 Dec 2021 06:33:05 +0000
Received: by outflank-mailman (input) for mailman id 246384;
 Tue, 14 Dec 2021 06:33:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wQP6=Q7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mx1N2-0004tn-3S
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 06:33:04 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0174287-5ca7-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 07:33:02 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 37B8B1F3C3;
 Tue, 14 Dec 2021 06:33:02 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0D7BA13A1E;
 Tue, 14 Dec 2021 06:33:02 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OipvAZ46uGGpYwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 14 Dec 2021 06:33:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0174287-5ca7-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639463582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=zkOKhXkH4pkDY9AKrTFHL8kH6KTPVZJSV4sapU/Y16A=;
	b=KlSc8YUqYzyKyYZtLwIgDuXbf47EAznQqzkkfz90YWThEY/zAWJRbCurDVQgU2ZvfYUgpf
	a+FkdJUtlVlTybP/zap5EkXzZBDqBXUxyNIoWL/nvLMcf+2nhcInWCG0SoZTJcnvJ5u7FZ
	oawzglbUi39z+1xcHXJgDulb/LV1VAY=
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
 <20211212000558.232nzs7k5lklpbym@begin>
 <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
 <20211213211907.lbjjnvayklf7qucb@begin>
From: Juergen Gross <jgross@suse.com>
Message-ID: <45aa9ea7-115e-af76-caf7-80b7d6f31163@suse.com>
Date: Tue, 14 Dec 2021 07:33:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211213211907.lbjjnvayklf7qucb@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="CbYhcGkjwpmxHpKbfaKiDsJjUJm4KHYTy"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CbYhcGkjwpmxHpKbfaKiDsJjUJm4KHYTy
Content-Type: multipart/mixed; boundary="lmMcK3byhWMpLkA5SAnQyF3zTT6EV3wTE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <45aa9ea7-115e-af76-caf7-80b7d6f31163@suse.com>
Subject: Re: [PATCH 02/10] mini-os: sort and sanitize e820 memory map
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-3-jgross@suse.com>
 <20211212000558.232nzs7k5lklpbym@begin>
 <ab1b2e26-65c1-c877-cf88-0df50d38b925@suse.com>
 <20211213211907.lbjjnvayklf7qucb@begin>
In-Reply-To: <20211213211907.lbjjnvayklf7qucb@begin>

--lmMcK3byhWMpLkA5SAnQyF3zTT6EV3wTE
Content-Type: multipart/mixed;
 boundary="------------576DF9A64280D1107F628895"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------576DF9A64280D1107F628895
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 13.12.21 22:19, Samuel Thibault wrote:
> Juergen Gross, le lun. 13 d=C3=A9c. 2021 15:56:21 +0100, a ecrit:
>> On 12.12.21 01:05, Samuel Thibault wrote:
>>> Hello,
>>>
>>> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:29 +0100, a ecrit:
>>>> - align the entries to page boundaries
>>>
>>>> +    /* Adjust map entries to page boundaries. */
>>>> +    for ( i =3D 0; i < e820_entries; i++ )
>>>> +    {
>>>> +        end =3D (e820_map[i].addr + e820_map[i].size + PAGE_SIZE - =
1) & PAGE_MASK;
>>>> +        e820_map[i].addr &=3D PAGE_MASK;
>>>> +        e820_map[i].size =3D end - e820_map[i].addr;
>>>> +    }
>>>
>>> Mmm, what if the previous entry ends after the aligned start?
>>>
>>> On real machines that does happen, and you'd rather round up the star=
t
>>> address of usable areas, rather than rounding it down (and conversely=

>>> for the end).
>>
>> I think you are partially right. :-)
>>
>> Entries for resources managed by Mini-OS (RAM, maybe NVME?) should be
>> rounded to cover only complete pages (start rounded up, end rounded
>> down), but all other entries should be rounded to cover the complete
>> area (start rounded down, end rounded up) in order not to use any
>> partial used page for e.g. mapping foreign pages.
>=20
> Right!
>=20
>>>> +    /* Sort entries by start address. */
>>>> +    for ( i =3D 0; i < e820_entries - 1; i++ )
>>>> +    {
>>>> +        if ( e820_map[i].addr > e820_map[i + 1].addr )
>>>> +        {
>>>> +            e820_swap_entries(i, i + 1);
>>>> +            i =3D -1;
>>>> +        }
>>>> +    }
>>>
>>> This looks O(n^3) to me? A bubble sort like this should be fine:
>>>
>>>       /* Sort entries by start address. */
>>>       for ( last =3D e820_entries; last > 1; last-- )
>>>       {
>>>           for ( i =3D 0; i < last - 1; i++ )
>>>           {
>>>               if ( e820_map[i].addr > e820_map[i + 1].addr )
>>>               {
>>>                   e820_swap_entries(i, i + 1);
>>>               }
>>>           }
>>>       }
>>
>> Hmm, depends.
>>
>> Assuming a rather well sorted map my version is O(n), while yours
>> is still O(n^2).
>=20
> Right, I was a bit lazy :)
>=20
> This should be fine:
>=20
> /* Sort entries by start address. */
> for ( i =3D 1; i < e820_entries; i++ )
>      for ( j =3D i; j > 0 && e820_map[j-1].addr > e820_map[j].addr ) ; =
j-- )
>          e820_swap_entries(j - 1, j);
>=20
>> I'm fine both ways, whatever you prefer.
>=20
> I really prefer for loops which don't unexpectedly modify their loop
> index, that's much less scary :)

Agreed, I'll take your version.


Juergen

--------------576DF9A64280D1107F628895
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------576DF9A64280D1107F628895--

--lmMcK3byhWMpLkA5SAnQyF3zTT6EV3wTE--

--CbYhcGkjwpmxHpKbfaKiDsJjUJm4KHYTy
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG4Op0FAwAAAAAACgkQsN6d1ii/Ey+q
YQf+MkWDkcMx4XqdV9HY4CK+Jlk7nenbn0gSJCE+isOE5i2At+lqk4cEDKOIo7jOal24ycSv5NhJ
cAsEVq/fk9jYSK/19q5Z2vGqjQw/0bdXtkVZC83BuPHrH6VFjCsdgovzg97QpT/wRNgRGS5sHOg8
0ZgNySMEBs9bUzeMbiFaiwtZpaD8yOWgu52HfDNChw94+CtQxAKewbe7KZAmXTi7fnJikQKfNqFY
JxlbvAV0jNCkHu6Y8tx12skm7IDviuTmMxmTS0YY9nIYVPegrgtxyl0300RSGNhoUuF49ruM4U81
CliM9Ov+6AXuXiya/8XwwTBH9BA5CHuuY0pFoIweVw==
=jJ9C
-----END PGP SIGNATURE-----

--CbYhcGkjwpmxHpKbfaKiDsJjUJm4KHYTy--


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 06:36:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 06:36:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246391.424915 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1Pr-0005c9-3k; Tue, 14 Dec 2021 06:35:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246391.424915; Tue, 14 Dec 2021 06:35:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx1Pq-0005ai-VD; Tue, 14 Dec 2021 06:35:58 +0000
Received: by outflank-mailman (input) for mailman id 246391;
 Tue, 14 Dec 2021 06:35:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=wQP6=Q7=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mx1Pp-0005aG-P6
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 06:35:57 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 175d0cab-5ca8-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 07:35:56 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id AA2C61F3C3;
 Tue, 14 Dec 2021 06:35:55 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8126D13A1E;
 Tue, 14 Dec 2021 06:35:55 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id d5SZHUs7uGGNZAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 14 Dec 2021 06:35:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 175d0cab-5ca8-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639463755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=c2zscTZWCfdTnNvE2ycq2IkmlOcYS06khPxhTTuwdj8=;
	b=KqIm74P6gtnRbBc1mgJyFbB+sJxsnlM9IdzCdWz3CfZc5hYBu+GpjoEaThguP0yxq2waGU
	pmYVk298mMlGRNQq4MJSs4KtswGYtW5rybV9A0PVP7B2tv4rwuBTwxaauPEvNoXl9Ii1EZ
	cXMYd9FGA4rBv5H124TNY+snzGWfx/c=
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
 <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
 <20211213212206.htg4eykr32x63swk@begin>
From: Juergen Gross <jgross@suse.com>
Message-ID: <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com>
Date: Tue, 14 Dec 2021 07:35:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211213212206.htg4eykr32x63swk@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="llBbEvctv1ssYaQy46gzgggqDbLQTwPwo"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--llBbEvctv1ssYaQy46gzgggqDbLQTwPwo
Content-Type: multipart/mixed; boundary="EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com>
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
 <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
 <20211213212206.htg4eykr32x63swk@begin>
In-Reply-To: <20211213212206.htg4eykr32x63swk@begin>

--EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua
Content-Type: multipart/mixed;
 boundary="------------347B5882F2F1F0BAC21C4DBE"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------347B5882F2F1F0BAC21C4DBE
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 13.12.21 22:22, Samuel Thibault wrote:
> Juergen Gross, le lun. 13 d=C3=A9c. 2021 15:58:58 +0100, a ecrit:
>> On 12.12.21 01:15, Samuel Thibault wrote:
>>> Juergen Gross, le lun. 06 d=C3=A9c. 2021 08:23:30 +0100, a ecrit:
>>>> -    unsigned long pfn, max =3D 0;
>>>> +    unsigned long pfns, max =3D 0;
>>>
>>> I'd say rather rename max to start.
>>>
>>>>        e820_get_memmap();
>>>> @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
>>>>        {
>>>>            if ( e820_map[i].type !=3D E820_RAM )
>>>>                continue;
>>>> -        pfn =3D (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT=
;
>>>> -        if ( pfn > max )
>>>> -            max =3D pfn;
>>>> +        pfns =3D e820_map[i].size >> PAGE_SHIFT;
>>>> +        max =3D e820_map[i].addr >> PAGE_SHIFT;
>>>
>>> since it's it's always the start of the e820 entry.
>>>
>>>> +        if ( pages <=3D pfns )
>>>> +            return max + pages;
>>>> +        pages -=3D pfns;
>>>> +        max +=3D pfns;
>>>
>>> Here we don't need do change max, only pages.
>>
>> It is needed in case the loop is finished.
>>
>> And this was the reason for naming it max.
>=20
> Ah, ok.
>=20
> At first read the name was confusing me. Perhaps better use two
> variables then: start and max, so that we have
>=20
> start =3D e820_map[i].addr >> PAGE_SHIFT;
> if ( pages <=3D pfns )
>      return start + pages;
> pages -=3D pfns;
> max =3D start + pfns;

Hmm, or I can rename max to start, drop the "max +=3D pfns;" and do a
"return start + pfns;" at the end of the function.


Juergen

--------------347B5882F2F1F0BAC21C4DBE
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------347B5882F2F1F0BAC21C4DBE--

--EjDtrtdBhh5fOOFVQ4C2WCbdOs47GX0ua--

--llBbEvctv1ssYaQy46gzgggqDbLQTwPwo
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG4O0oFAwAAAAAACgkQsN6d1ii/Ey/b
PAf+IWE544eHGTWaSvvHe0MkZgPT+JFOlO5xNTc1nASvtqDWqg4o2F4RkLvdo+xYl6eHrlCLnhHG
ai3rSdYA6PMdU3EVoAzqW/p1xHgG9z1GG3Fpw+/rEVytNaSMyzQFUi9TuPTAsXYkKa0gU5hfBVCb
17UISZtNemtIeCOwl5jhe6o79A3EUXg8m4flZiWWJF+XboF4P3bs8wyXU3R2bCDSaC6jZcxkdE4Q
dljL4TJAxBUHTLs0Iwu09zWoWIxhiyKdVoHeyGQVqThvyGmfw8rCJf9PxgzA02sNgqz1LXEpAgRU
xf3B9wMF8N+Uto2uvLMvVFZjxnaQhsZE7QjTfWcQ5g==
=vFNO
-----END PGP SIGNATURE-----

--llBbEvctv1ssYaQy46gzgggqDbLQTwPwo--


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 07:41:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 07:41:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246401.424926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx2QN-0004ve-VC; Tue, 14 Dec 2021 07:40:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246401.424926; Tue, 14 Dec 2021 07:40:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx2QN-0004vX-SF; Tue, 14 Dec 2021 07:40:35 +0000
Received: by outflank-mailman (input) for mailman id 246401;
 Tue, 14 Dec 2021 07:40:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9n0m=Q7=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mx2QM-0004vM-No
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 07:40:34 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1d8f7fcf-5cb1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 08:40:32 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 1670C32E;
 Tue, 14 Dec 2021 08:40:31 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 5YDjt2mkzHDQ; Tue, 14 Dec 2021 08:40:30 +0100 (CET)
Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 6BC3C230;
 Tue, 14 Dec 2021 08:40:30 +0100 (CET)
Received: from samy by begin with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mx2QI-008b4w-04;
 Tue, 14 Dec 2021 08:40:30 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d8f7fcf-5cb1-11ec-9e60-abaf8a552007
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 14 Dec 2021 08:40:29 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
Message-ID: <20211214074029.5qivn7adgp32nrfj@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211206072337.9517-1-jgross@suse.com>
 <20211206072337.9517-4-jgross@suse.com>
 <20211212001542.qhz7wfdwq7k5ymxr@begin>
 <e44571e4-ba85-06a4-99b2-648d94e9af8c@suse.com>
 <20211213212206.htg4eykr32x63swk@begin>
 <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1a2e80ed-9077-6867-5426-e7e6171feab5@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 1670C32E
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le mar. 14 déc. 2021 07:35:54 +0100, a ecrit:
> On 13.12.21 22:22, Samuel Thibault wrote:
> > Juergen Gross, le lun. 13 déc. 2021 15:58:58 +0100, a ecrit:
> > > On 12.12.21 01:15, Samuel Thibault wrote:
> > > > Juergen Gross, le lun. 06 déc. 2021 08:23:30 +0100, a ecrit:
> > > > > -    unsigned long pfn, max = 0;
> > > > > +    unsigned long pfns, max = 0;
> > > > 
> > > > I'd say rather rename max to start.
> > > > 
> > > > >        e820_get_memmap();
> > > > > @@ -166,9 +166,12 @@ unsigned long e820_get_maxpfn(void)
> > > > >        {
> > > > >            if ( e820_map[i].type != E820_RAM )
> > > > >                continue;
> > > > > -        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> > > > > -        if ( pfn > max )
> > > > > -            max = pfn;
> > > > > +        pfns = e820_map[i].size >> PAGE_SHIFT;
> > > > > +        max = e820_map[i].addr >> PAGE_SHIFT;
> > > > 
> > > > since it's it's always the start of the e820 entry.
> > > > 
> > > > > +        if ( pages <= pfns )
> > > > > +            return max + pages;
> > > > > +        pages -= pfns;
> > > > > +        max += pfns;
> > > > 
> > > > Here we don't need do change max, only pages.
> > > 
> > > It is needed in case the loop is finished.
> > > 
> > > And this was the reason for naming it max.
> > 
> > Ah, ok.
> > 
> > At first read the name was confusing me. Perhaps better use two
> > variables then: start and max, so that we have
> > 
> > start = e820_map[i].addr >> PAGE_SHIFT;
> > if ( pages <= pfns )
> >      return start + pages;
> > pages -= pfns;
> > max = start + pfns;
> 
> Hmm, or I can rename max to start, drop the "max += pfns;" and do a
> "return start + pfns;" at the end of the function.

That could do as well, yes.

Samuel


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 07:50:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 07:50:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246407.424941 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx2ZR-0005r3-Ul; Tue, 14 Dec 2021 07:49:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246407.424941; Tue, 14 Dec 2021 07:49:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx2ZR-0005qw-RN; Tue, 14 Dec 2021 07:49:57 +0000
Received: by outflank-mailman (input) for mailman id 246407;
 Tue, 14 Dec 2021 07:49:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx2ZQ-0005qq-QP
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 07:49:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6d1a9622-5cb2-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 08:49:55 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-34-7eMg2ccLNUa8O9o7ae_FAQ-1; Tue, 14 Dec 2021 08:49:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Tue, 14 Dec
 2021 07:49:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 07:49:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d1a9622-5cb2-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639468194;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=8+oLCtYggJm4G6Tji4xf0/Xj8/spbfK/kmwNCdTV4D4=;
	b=cq5CnsT0regrMbrTNE+bydkLHeR+gXgCsBu8BXV8peCR4BD4GwQliXi2Vu4MvGPalrApQi
	UOQnwUc19aZHPcSQScLlF4zIwda2ERPAlLfBRAHWkAPcFZQIKvnfFxLmP62yuZYyrTj7ug
	Kv+heraELxEM0vpjlmaIX5ISHwMXm8s=
X-MC-Unique: 7eMg2ccLNUa8O9o7ae_FAQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aCBQZ7GDqfVkcCm5dvmsKb5XW/u96h+tEeM9tVgEGv0Oj+2Qx8tXf8+PpsKX1lBtVaOsjARiT99TsWZVlYVtOVLXMOJjg3r6dfF5uyPOZgYNg8gRkaL1x0AJ48pTmBxV0uAWlrl0mu2MiuGtfGHqMAqlhfzfsxDhbELHowc/fUgPL9DgHeGAvbG8r+EQuQIhTNiB7o92MAHijng0cy7ap4jQ8V2fA/CTKlTRF2YMobtF0aUfnjBswVOyg1AJUa9s/MuyD8C/m5ag/aC6hlWjEQJuWfOqusQSgbnCYKj1kzWozFTDVrmwET25NY4LxMKHtjAAfKCE2nu4DjossRrbhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8+oLCtYggJm4G6Tji4xf0/Xj8/spbfK/kmwNCdTV4D4=;
 b=a/lwlEnp1mUyc9MBJUL35IAjRsUgsJZGNBQmEaJCRC5KFLLutAEq333Hk2fNIN7OBdPX5WeCq0xe6ccS0+MUKzJfdP+zTMTU67utvO0KxWHIiXeWv7RGhPqK5Ya5XnHKrU3cJIrXxjjlmqWCFKImcwrgQlN1ltSfIFyG9JNjj9PT8kV+qsQwyq4rAybl2xuXY08NSWLIAVwxk3KykGlm0vNDHHBfvagxULjPuT/NXjUvFTWwGrlayS3ZdMhdD+m66en7jus/3V0BRuTYVomEut8UZCb4amat1MvKUV4NgfNzR/6XbrsixRIZIQ09SKsH6gVLK0OMZsXGf+SrEXk5Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5114ae87-bc0e-3d58-e16e-6d9d2fee0801@suse.com>
Date: Tue, 14 Dec 2021 08:49:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>,
 Stefano Stabellini <stefano@stabellini.net>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] libxl/PCI: defer backend wait upon attaching to PV guest
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM7PR02CA0003.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37747619-7006-4db8-df3f-08d9bed64eb9
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63012DC21F50E1BD3DF431E2B3759@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rYDD0lTYQETvaV210PK/Z5iojtrm0CpsjGJLMkPyfSrZxbetuNIM8U3KbJ2GmTcP51MCtX8y/mQpMUqgamPjri9eVdhX7AG8UJpIoujjPCsLCQ/pS2/uhTrkq++XKGIC7EedgYJJiOFyqWwYu8Zn0rF/tBlEj3qmTrBi7py5+1MQTQtLI9XjDaUJm/e1K61Zw+K976afumGeTHQ/0nLhV0q8m9gj1QAwR+eM6XruRgVkaGn2nhGx4WlOo8WSHKCQeAy/HQhxYcgGkzMQwk5b/iaP3U4esEvN9U0JWMuA3ydw6X95zUxBaWHUf4IKuIBdj+cFsQY+ymGmhjtBoeLkbcSZWTooDWdIKtLsstQiyBvzOkwETzWEPZaRQj8SbWDqgHj0pArPHCOwtZnfVHRoznoToA5nxoKMA/Gs1pCnFU2FZdw8zHBJ/liaP/DRcNvLn7VUWNK9hcAmGVqtAEEvXvCpR3GD/EZ8pUd5Uo9PAJeNgpyouS2WXCbq/XYJ+cBJurLzGw324yJrdHIAXTC1nIAMNQsu/CLldgl5LP2EqUePASM2P3oqBOqsJ6wtDJJvh7A4tJhG1HnP4III5xVSHELk+MbMX43LDuKLhs/sOLSo3con9Yar6z/9776Hi/7VIZB/NQ7jNN80MAZwnBv+/WjKtPEbP9fDmiGsj1WSSaoGrHgNqNWByouy2dorCZSNnizwTvEuutzYsOJ+5SCnNDF70HXOW2kpQaCasEC/yQg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4326008)(6512007)(186003)(8676002)(2906002)(31686004)(2616005)(8936002)(83380400001)(66556008)(31696002)(316002)(5660300002)(508600001)(66476007)(86362001)(6506007)(6486002)(36756003)(54906003)(26005)(66946007)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWRubmpjL0dmdHVWNHpsSUljbzJsWjBUd01jcC8wRmhUd2w5UTZnTkExbkRp?=
 =?utf-8?B?MGVrSjdQdytxSmVQc2ZGeEdlT2RaekFwaGVyTTBCOVpSc2xSZksya1pkOFNv?=
 =?utf-8?B?V1RUR0dhaGNmV0FYMks0eld2ZG93SnZXQ1BBTFZRNTZnek92Nm1ReE0yeEhQ?=
 =?utf-8?B?d0ViT1hReGVEOTkzaDBEd2RidW90RUU0TnpraXdPVis2UkovSzlnT3dlZnhx?=
 =?utf-8?B?K1pIMTdoYlJHSURIR3VGQjkvSCtPQUphMkZadlE3eE9Mc1RGZk1FSkQzYXhW?=
 =?utf-8?B?WWF6dVpkYVNhLy9mQ1FSN3dVcUg5Kzc4eTBBZXEyMWF6aWFhN0NVYnoxenV1?=
 =?utf-8?B?d1hXNGZXNGo3emZUR3hOQ2pRWWhuTnFTOFdjcUVPWkZ5Nng2TDFoWXVPazZT?=
 =?utf-8?B?S0ZwSGNGV2lqSWIrYTY2UzQ5dVA5dzZpTVhmK3U0R0FkbDVWVmwwRUFEZjNY?=
 =?utf-8?B?ZjJFa1hDUW9qRHROZGo3eW1DbVBtQXR2SGYrS2FpU0xQY0FldytadkN0d05I?=
 =?utf-8?B?dlQ1SXFyT093aVl5M0NhRS85OWUvb3RHemZ4LzN3ci9URXZYbjA2ZWlMVUlp?=
 =?utf-8?B?dVdHazRId0VoeEtRcXJSU0NqMWxIS3lmWDFMTklaM1pmeWc2NmNTd3hQWnZt?=
 =?utf-8?B?YW56eDlGYnhncFdvZ1FZSGNVS095SmQ5d1dXc2hTYmhkRGZrZDZxN2JXWWRE?=
 =?utf-8?B?dGRRVDgrRjFuWVlXWVpmYitqajI5WlJDVXBRb0cxK3pXQkdMR0tlQkNkVkYr?=
 =?utf-8?B?Ni81am5xczBtQVduUVBhL1Qvb1JXSVg4OFQrUXUvL1RRalVIREhqdVdJSEpT?=
 =?utf-8?B?VkNoNmY3ODZjY2FJSkZtRnRDbVB4WUxkRlFSd1FKanhZa1F0cEg4SHpaYVlS?=
 =?utf-8?B?WElmbE9jM3JSaGcraFk3dXpXaS9tWndRNjhTRHpoMmJ6RHhpeEdVUlhLV0hW?=
 =?utf-8?B?RlN2TEIrZmdPeEUwWDE3TngweW1DTHFwSjM5Ry9FSWFMb1FoaGVNazBWZ25S?=
 =?utf-8?B?VjBuODY2ZGpsT0haQldKUjhKdXBFWmF6ODJId2tsTEZzSWRDNWVuMkJzRWVX?=
 =?utf-8?B?TGMvSEoraGk2OHJNbFh3blVqQUU0cFJYbFkzb1hZNjVBUUdQZ0o2cjFEVmth?=
 =?utf-8?B?T0JoZitoejN1dnpmMFhRL0xYU2t5UFJJRDVjRjAzVUlWVlQxTncvV094dlRx?=
 =?utf-8?B?MXF3WHpHREtUMThjbzc0UkswaStld0crZjUvNUhtb0pIZmd1bkVXVmliWnZZ?=
 =?utf-8?B?bGFNZlBjL3RmWVJURmdpMFh2emh4TmJ5NFk5TVREN3VtbUJoQ0VJSEdoSG1j?=
 =?utf-8?B?NkhlTFlaNElBa0NaV3hQWCtoWW44VTN2YkE0YXZ3dUlwY0NsWExzMTNObHhO?=
 =?utf-8?B?cml0ekxBazVFZDZtYXBRYytyZlFEQXd4c2Q4QXJJQnlsMnU2TUxmOWI2bzhn?=
 =?utf-8?B?WUFTRGcyUnFqSzYvM1QwbExMNW9iK3lVaE5yU0V3cU1MM1RMRjNKQ2cxRmVy?=
 =?utf-8?B?K3RyQzJ6SENQZTg1cWEvOXR3RWtMRVg3dHgwZTlIVzA1WEY5eDExbzlzZG9a?=
 =?utf-8?B?R3N2eVF5bEtEQWtkcUhMRjBlTGNocDQ2S3ZQNWxRdmVsQ0RoOUhudzQyckVz?=
 =?utf-8?B?Yll1U1RlaVFDZjBzTVF4T3Q0K0ZZWkNuVjIwRkJEUDRwbTNEVURUc1BpRWdS?=
 =?utf-8?B?RUwxcytrK0NsZ3VvTmdnZG9wa1dXTXdxZFR1eTNwalpIZ1NJbGo3ZVVucW16?=
 =?utf-8?B?MFhJZEZ5RmVZRDRnQitOMGZJcSs3RzZURlM5RndjOUREK1RZdXlGYk9JTGhZ?=
 =?utf-8?B?aFlKMTBic3k2bnpPTWdGeUN4dzNUSmlaODF3by9tb2E2bnVoM3pvRDlUNm1V?=
 =?utf-8?B?ZHRmbEhHWFJSTlhtK2RYT0krSlpVMjBWcFV0RUx1cmtWdnNqTGNHRWJCdUsx?=
 =?utf-8?B?KzA3UFp0b0ZaNmhOVkZjbmJGc1l1eTFLSko2MlJEcCthYWlEbzhtR1ZCYmhk?=
 =?utf-8?B?VTJreWg1RjUxb3RjMHpqSGdjTnF5RUZUTzhndURqVFJaQmx0RDhoZDVORTNW?=
 =?utf-8?B?c21JdEpPQmJITmRrREZLZmhmUW8zb1ZQWDRGZVplbndhQ281RDdhRzBVZFJH?=
 =?utf-8?B?S0FFOGdJd0J3d2xhTEVBV1ViRXJhYWxlRkUvdXBJa2VQV2MwYUZGaDE2Y1Fm?=
 =?utf-8?Q?0SvhXxX7mFgZ0WOiH2wrh38=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37747619-7006-4db8-df3f-08d9bed64eb9
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 07:49:50.3858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ILZBAAGXVZoLHs/FLhDWvMy4+nDbIp1Mv7FyGmzBogCk3nbIcnibY3Xq9CAOTxjh83Bc+3lib8SlVMAtOCnDnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

Attempting to wait when the backend hasn't been created yet can't work:
the function will complain "Backend ... does not exist". Move the
waiting past the creation of the backend (and that of other related
nodes), hoping that there are no other dependencies that would now be
broken.

Fixes: 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are reflected in the config")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Just to make it explicit: I have no idea why the waiting is needed in
the first place. It's been there from the very introduction of PCI
passthrough support (commit b0a1af61678b). I therefore can't exclude
that an even better fix would be to simply omit the 2nd hunk here.

--- a/tools/libs/light/libxl_pci.c
+++ b/tools/libs/light/libxl_pci.c
@@ -157,11 +157,6 @@ static int libxl__device_pci_add_xenstor
     if (domtype == LIBXL_DOMAIN_TYPE_INVALID)
         return ERROR_FAIL;
 
-    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
-        if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected)) < 0)
-            return ERROR_FAIL;
-    }
-
     back = flexarray_make(gc, 16, 1);
 
     LOGD(DEBUG, domid, "Adding new pci device to xenstore");
@@ -213,6 +208,9 @@ static int libxl__device_pci_add_xenstor
         if (rc < 0) goto out;
     }
 
+    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV)
+        rc = libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected));
+
 out:
     libxl__xs_transaction_abort(gc, &t);
     if (lock) libxl__unlock_file(lock);



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 08:18:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 08:18:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246419.424952 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx30e-0001Ut-9K; Tue, 14 Dec 2021 08:18:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246419.424952; Tue, 14 Dec 2021 08:18:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx30e-0001Um-61; Tue, 14 Dec 2021 08:18:04 +0000
Received: by outflank-mailman (input) for mailman id 246419;
 Tue, 14 Dec 2021 08:18:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx30c-0001Ug-Ko
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 08:18:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59d6287d-5cb6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 09:18:01 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-vXCM7EHVNoaFqNMoPRoB3g-2; Tue, 14 Dec 2021 09:17:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Tue, 14 Dec
 2021 08:17:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 08:17:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59d6287d-5cb6-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639469880;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1M1jZEk8y/cZ4cSseQogy/PTToa4wa29DPrFL1OXdX0=;
	b=DAXRW3cJJRiv/iR8vl2gNcoeN6T2PJKj/VbsOsZAw5HgLYlGoQYpVLfT0Z/x68+n5FTw3k
	fz+aq1uUl0htG2TpiLLZDbL9jzONGWFePBtl3NsnjdtqFDV6q9aMyvnp3Y7b4PqtD1UJ6B
	Zsbwpo9wsAEPvVpo6VRUH4p57dS7hD4=
X-MC-Unique: vXCM7EHVNoaFqNMoPRoB3g-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZMalv9Vih9Lo+gi0Ir52NYo78yYwniSRvULX7Celnft0r3LTilzuUsFFwjb7YN2a+WjjP4wa5ocSLVR54Lif2srjKKZ9zkNXyUYRD2Lu5//5wdiImb0CjDo89eP9U8lAQffkwVQAR4rnmhGPYFTlsvPF5IW/uTUmoL+En5/l3xGs5f6h2fhXGTjJUiGJkNdhijlx9r3Bdxv2XO0wEAaGOpPDePm4KayEUTWUpajIB2+m2s880gWGkeqm27pQbGdRY0WXgVs9RjxrdduQ36HevCynLWD89IqCFLuQHGyD9/bEHzXdEnagz7CA1bC0wGCmlmXlL46o/8L1LbATrNfu/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1M1jZEk8y/cZ4cSseQogy/PTToa4wa29DPrFL1OXdX0=;
 b=ZoBJviMsbeQ3SRj0X865tVNoWIs3KbFgtXV9/+a6GUN5ZZFb/8OXxH2fbEucWDdTJq5FDoivyf1lZ6G2lO4nv947bjjZQNQ9Zlg5kF9Y+kBo0lpxFh69Fm6LCxbWikpky1xfcfKP6ggJvXdjtgBjQAaTaUwwiQuFsi6q728gLhsvMaVhnsHe5sscPhbbp6LvyZOMjbIhJPLOoRbK6XvElNzJqsCBCcdWmjzYXdV+6TkNBbEZkJaMciiUk7dorQqPjYcLoaD2oy8m29aJQQb1N5JF+/jHBZwPX22VHKP07rmwx/BQyiAus/npRfCOKzTF5W+3ZXGEjF6k7MKO9WBW0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <76367980-c0ff-13c6-4a86-24be90f28f8d@suse.com>
Date: Tue, 14 Dec 2021 09:17:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell
 ...)
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211213190449.4830-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211213190449.4830-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR0502CA0058.eurprd05.prod.outlook.com
 (2603:10a6:20b:56::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 33ea8d61-7e1f-4c89-5cf9-08d9beda3b13
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB295976B20549C9F85F864BC0B3759@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	qZCe7oOGc248AlakioHaWluCRaiP5nblcZgoTpw9cpdKYqz+uJNJG//qm7gs1m88ZiihIzx2isgGX1OKIw18Dlv20M6mqnkbgfJJr3m+Zv4U6/UTmh/WzY6cgE0QY0xOX4hN542dsCjOQzGZAPSCitmu8pi6fflTgIo0PU+I7WNTRkvq2/j1jTdoVfiHMS0gGU7yVRrAwFUuV56IcXVpZVP3dv6ant7zWWqPg7s1aSI5rKyAs0ST4X3Lzc7+T7APs2PUt1DnoN0nfPcorK5bNiMneOIhWZoCJM5QZT944lgV66kcAu1Zs27n1G6WI4elSdBbMA3qf7Q+iTN/y9Z2DRV3hm1FG/lHpqQQ3IhKr6GmMcRr4Q3ER60mjJiw56zL0K9mnKMBVu1UrzF0VH/O1eHpXkqvJOhYZimQ3Xrq5eBrGcHk7IX3lCWM5sI0LPQJ6jAgAFqoIg1Enj/D9hcngF4TEYEdBIQu2OwZDpz7Lv6mYg/BWWFQoTfeTJ49+Sz+vOubRpni+hZt4Rd2wMmG+xiUr32ek+QgjCa9GqBH3/NqKdnTV44SLcH0gZo7wGHuETwASnvHlqlI1eQw5rFpyK7B7Uof5mXoA422BylURRu22KIs6U3gzlPQso7VJqUef2I8eyD942DZmHcQs40v53aauxF9Sxju4PDaYK59c7TJWOhLyCJfHchEfd0slBmgs2kYQQuv3Q75Aa8luCZ5azNuu7fzgpYDCF1AL5vuE4bR93JJK/Ad1mBAZMB9kk6X
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(66946007)(31686004)(508600001)(36756003)(86362001)(54906003)(5660300002)(6506007)(66556008)(2906002)(53546011)(8936002)(6512007)(8676002)(66476007)(38100700002)(4326008)(186003)(31696002)(316002)(6486002)(2616005)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MHNiN0tWK1ZrTDVpOXE3b2h3YXhRVnBTbG5NV3QrZGVBOElTaEVYZTg2ODQw?=
 =?utf-8?B?VWZ4WEdZa2RvSG5WdDBwdnI4dEl3V3ZGSmtGMW5IUmVFeWJXTk1zMmtydHFM?=
 =?utf-8?B?VWs0ZHoybGU4ejBoOHc0VGZmME9yKzBkSzZwRFdtRk4veldRTkJSd003cGo2?=
 =?utf-8?B?SWIvc1JnYm9ZelYzOUZFQ1ZkWFU5L3paa1dXRGtQNkZTS3ZDREVYSlYrTzlM?=
 =?utf-8?B?MUZROXI2cm5ZMHVreVA2WkNEUVpiUjNFZkczb094ZjYyOGhCY3BRUWRsQ2l1?=
 =?utf-8?B?OTRnQ2JtYW1WYTJvWThValdoU3QxcVY0SXRyOVM4TEc0L1FsU21mbmxRazNp?=
 =?utf-8?B?SjBjZXN3eUwzR3RlamZXdUJsdkZKTE1TRDIyaEpVL0czNVF4MGRhSVBLQ1JV?=
 =?utf-8?B?R0orcUtCREkrSDhPM3FnS1JGZTdUY1B1cmxTZWVEUml5eURmcUhwR2FzVjFO?=
 =?utf-8?B?OXV1c1ZJMGtXKzZXb2ZOc1IwTkV4ajJ6K3VSODBHeEliV05ldElvanZ1UjdV?=
 =?utf-8?B?TW1nQTRJNE03dnBWeG10bTNZR0YweUg2UnNjYXVFelhsRndYTDh6Q1kzQU9T?=
 =?utf-8?B?Und2SGd2Q3pQSEhXZ1lHdWZqK3U1R2JsUzQwMklvaFhobjNZZ3c0Y0xWZ0tF?=
 =?utf-8?B?MG93TTEvWUJta1h1dEZlOUpCSFA5Nk1kK2Y3U3VUeEJNUTgwMjhjNTVQVmls?=
 =?utf-8?B?TWxFUWlBT0Q0eiszYWlYRUlnN1RQNkY3MklXcHVzVnp5aHpkOG0zQTNjYmZF?=
 =?utf-8?B?WUtRcXd2a2pYK0ZFY2JXTkM2dGtwVTZKYlVROXh3UTkzcVlkajZ1dWZ1a1ph?=
 =?utf-8?B?NzJLSDArSkwwV29yOXdIZ3RxRFM3NFFNbnJBK3h2MWQwU095NDR6TFMzVEx5?=
 =?utf-8?B?RExWR3hhZmIxaXdTSExyZitoV01uMGVmbHowdVIxWHhwSng5T3NSdVZ4VDdW?=
 =?utf-8?B?SzY5VHBieEdIODFhZmlEdXRKcko1RTcrbmdGTmtZeUg2NGcwWGpOTExkMXNO?=
 =?utf-8?B?TjdpMWJmOUh2Q0RZRHhKUU1kT2VVVVZZNC9HVWV0bGtuU0xhd0tPVjJrRjMv?=
 =?utf-8?B?MDJUSnA3VUFtalNxaHhLOFVhQlhzRVNJakZiWkwxNHQ0NVJYaW1rT2tGcHhw?=
 =?utf-8?B?UnVRNHhlK1R2eFV4cTk5Snp1UWxnbUltazBaVmlCVkpxdWtGTVFxeHFOZHQ5?=
 =?utf-8?B?dkd2c2lla1Y1eU03cTl1cnVsdzdFdUdNYkZZREh5Wk9nWmZYamRPQ2tJRXor?=
 =?utf-8?B?ZzZ5VVN3QWw1Zmt2NmFNcjRzYmdXaUlsRCs5ZDdrRnJoeCtPM2dMN0dxcSs1?=
 =?utf-8?B?V0NCLzBtbXhuR1Awa3VRTm1pTmJ1TmcyTFRQVVBEb0ZKOXJFNkUxSFJnL01J?=
 =?utf-8?B?Z1ZmS0h4SnRWOThDN0hjWmNra1hUZG52TXEyZUo1Vnp1R1RxMkZMT3BBSjdY?=
 =?utf-8?B?NlNXYVBVOTZTL2tyc2xCbTdGajZEMDB6WHl1TkJSejN3TmZ0TkRzRTVaUGZ3?=
 =?utf-8?B?RUhpTGtOenJYYWtDRnRTMlJzYTByRjdQY3AxWVNrdXpzNWRseUFmNnlFSTdY?=
 =?utf-8?B?eWNtdEZnYVhTdzMyVnBSVjhYZ2U5NWFJUUYzazlkUTRybTZRMHJZakE4bnJ1?=
 =?utf-8?B?N2RZaVlGZE42K0FiMVRYVXFqZnVaTC8rdjFIaDJvSU1Ic1ZXQ0lEMWpPenM0?=
 =?utf-8?B?RW1RT012VnkyQldReUdyUE02emlFQ2Z5K3kxYjBZUDVrYzZpSFBZN09KeWt3?=
 =?utf-8?B?UjNnTVhreFFnLzlhdDZzTzhieWRYY2FKekxHUEhRRGxtVDFMVy8wNkR4RlB0?=
 =?utf-8?B?SVgrb2M2MmpkU0dJOU1DQzZoaXNySW1JUERTNGpMVFB0VHdCVDFQWWVDb2tZ?=
 =?utf-8?B?TFRvWUova2ZvZ2IrdzUwZTdocGRHZDhsK1htUzFnTnlQYnFnUVZMRUVXMmhl?=
 =?utf-8?B?b09TUGRDYytGQ285VFUwQ004TG93ZDBiNDY0ZkxvMjNkMkMycFF0VXNkSjky?=
 =?utf-8?B?RzIyNWwxSHZsdkRQQlpxcjhHUmJFM0lEU1I3VDAwVVl4UzdmenN4aGZ5akcv?=
 =?utf-8?B?MW56TzFJZi9oT01scFM5eVVpRGVBQWVEVGRHdGttN1graFQwRjJ0NFdFWjlZ?=
 =?utf-8?B?eEFaMG4wV25NSG03dTNVYng1TkpySC8vNWIydGJUWUpVZDFKdFJleHJTaGZH?=
 =?utf-8?Q?xofPZNyswE4+XUhI81yYjQQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33ea8d61-7e1f-4c89-5cf9-08d9beda3b13
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 08:17:55.4347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7W9gII1rJBdZgohy+OnBKLWDB+UNXjEmL1n55NVxQU/Wv153fkpOgelZ6E9te1MAIf5eg91Ln6D5/4ReibtHfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

On 13.12.2021 20:04, Andrew Cooper wrote:
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -6,7 +6,10 @@
>  #   MINOR:   minor version of lib (0 if empty)
>  
>  LIBNAME := $(notdir $(CURDIR))
> -MAJOR ?= $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
> +
> +ifeq ($(origin MAJOR), undefined)
> +MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
> +endif
>  MINOR ?= 0
>  
>  SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map

Wouldn't it be better to move the "endif" past the setting of MINOR
(which then could use := as well)? Libraries with their own versioning
would imo better specify both rather than relying on getting 0 from
here (which at present none of them does). Would require an
adjustment to the comment at the top of libs.mk, though.

And further, since you're switching to $(origin ...), wouldn't this
be an opportunity to avoid stray inheriting of values from the
environment, by switching to "ifneq ($(origin MAJOR), file)"? Or is
there an intention of allowing such control via the environment
(which would then override the versions for all libraries not
explicitly setting them)? In turn I would then further wonder
whether command line overrides are intended, but I guess people
doing so ought to indeed get what they have asked for (all libraries
versioned identically, assuming both MAJOR and MINOR get defined
that way).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 08:21:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 08:21:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246424.424963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx33x-0002zW-QQ; Tue, 14 Dec 2021 08:21:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246424.424963; Tue, 14 Dec 2021 08:21:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx33x-0002zP-M5; Tue, 14 Dec 2021 08:21:29 +0000
Received: by outflank-mailman (input) for mailman id 246424;
 Tue, 14 Dec 2021 08:21:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx33w-0002zJ-G0
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 08:21:28 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d4f644c2-5cb6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 09:21:27 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-iMTbWgI3OWy0jZRzN9p6kg-1; Tue, 14 Dec 2021 09:21:25 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3775.eurprd04.prod.outlook.com (2603:10a6:803:1a::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 08:21:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 08:21:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d4f644c2-5cb6-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639470086;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=0t/AQ7k5EF/1vmQtiavEWRj7cd1SzdmnnGJDbmiyFCA=;
	b=AVtRDXPZjzSp6JWHDZ6si5ykOEbqa1X5S1lJyO/wjxyjIS4P2AtzWCTdbw3ijVexGrM6jl
	UVCEgPE0aqAQoH14JZC9GLbm4GuoD61b8puBTYGyJ6YiKX7D3kxZXryFDlE3tp5b3cKyJT
	zeAR5ZFL6zsXo+/evVnL//gUgIse7A4=
X-MC-Unique: iMTbWgI3OWy0jZRzN9p6kg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Cq8aTeYdR9F0/YWEhjyD2tEeB4DvnOQ20diVCeaArMP9GtHqg+kU5qCNyqUNbDC7/MZKJXkx6Q2nL9GC+hN0uvVkzpqc5eO9CM0WXNmy8tTku2Xq+l82IDJejMb3YhoMY6j070jA+M3q8XOyBDVrBs1qMYxXjlQe/oYSTODfUXJZ12mh6OzG9HWmhYGk+3bhDR/p1VLlMci+t7b1KddO32UgSoJsDpKmDb6qMXOXa+K201YU4mJGkbZkuymP+sSWvuAX3VRKvuXmDjO7c6qMZ8apt4arj/p26sIhuPaESYwn3RK0rBPUMP6PAGrojQ8qoeLHgUtYtj2JUt+7BSv17Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0t/AQ7k5EF/1vmQtiavEWRj7cd1SzdmnnGJDbmiyFCA=;
 b=hBL8l6bKmpdyUaVh2rtODVxqZg57XUWwJaH0UMWVQ5XoKBeYFf4il6pfTexN1wWv8NCf+S7CX0erng0NxGaw/MwottDI1XsyX2a8/Zgesk/Y/nmrnrDhUqhzwLETT1gDWt3wKuTizru/5FQGapnKkZ9x4nmHohkgvGV41UQBvqqoOm5CYQ9eJjvThMMLGLlhpQEoDB2Abs4eXojQuIwZPZWUy980kMaoQgxGGvWG9q+LyhfBuhNJM53lYKZSZTEJk9CB5I43Nb12ftb4dbcKLWrgINFl+Ha64LEB8ukbXWw84ogdd9qPM8sZ6tse/p8yQ66B/qKHf0dPwLecjxBDNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
Date: Tue, 14 Dec 2021 09:21:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should be
 UC"
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0122.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::27) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 206316f0-98aa-49cc-37d8-08d9bedab75b
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3775:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3775D5627DE236D6AFE3F31CB3759@VI1PR0402MB3775.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1122;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gSL7+JtS3rzXtQmeP2DCT2HGECqKs+u3FVxZx8qccZzlVUZLDYLiioTSfuPoQGzyqfqfPFly9KVBXdg6TzZOSNgGugLQhamcemLg73auXL4R6CRPZ4n3PRxSVS37RuNzU+eTT1pfRqANKSyQJ9UIiRFgHGJNJWINDclawtIB6aT151uhAL3QoJklCgPZoLWm+rrtTVbRnPUoVdyfc9uEIqQlDMN26esTkMruHaQG4zH1jzvGhWPQz2lq69vSPoW53r+53NSYdWDliK9aLxzwf8nDH/iXeuJSEMVUbtW9E5/NuwNQ7Y2VFdwGUv0xanKG6DoCM3Jk/ADE8kv6DJiyMQLxHG4ZdYqS+3XsL2u13c9oQYmuSng+Hi436tzYsg+ubAI6JaLnulBsOSuXwqy5gNTBsQ8nls3+dxoVGkIkVb45pLO1hougx+3xTgiyBpgFeqA7gouHAc/akxDZDYDBMI21by7dXloYT60Uw5N7bnjj4UYgwWaWNqY4IOoBr/FuWfzUdlsN7T4tG8Sv8clM1BD2AlldBVi03Un0k8Xn4xc13NSj2rzmkMrcDS7T1fkUAIV2Le1HeXT4gLjs6DZcB2Fx0Tk4km3nkKNr1Doeji9PyNk5Ar+qveJ4veN9CAzaS5wcs/KUI+pjFJJ2w9zc69vLw5CoWu9otrf78v+go/QR9KMmxbRZpGBTl6odBrQOR77YFzJz/PWJ5NyJfPQHAQO5Ykoy4/MJwnFSAHrG5rfzSlTT9Snag+e5FnTr/+Z9
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(508600001)(66556008)(38100700002)(31696002)(4326008)(6512007)(66476007)(6506007)(8936002)(31686004)(26005)(86362001)(6486002)(8676002)(316002)(5660300002)(6916009)(2616005)(2906002)(186003)(36756003)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MEZ2ZVhDK3k5MFU5dEhkN1VGTlF2UVU3b3pySFZQeHorV0tQbFlzM0hxcmVz?=
 =?utf-8?B?bHNZUUVIUVFuaytpeHN2Qmhla1UvZU05cHM4VGQ4Q1k2eXhMZzR2VW1BT2Rp?=
 =?utf-8?B?Nyt4NnlGZEJjQWIzbFJlcTdydm85NFAwUE9PakduemtDUGR2S2hJbjNiSVNI?=
 =?utf-8?B?cDZJQnJUUGVwRVFHL0x5d0JOVlNVRXl3SnpVVFJmNEthMGJrS3R2elJDTVls?=
 =?utf-8?B?V21GRlRLK1VzcnY5TDN0Tmh2Rk9GMTFEREhtSTROV1NGWEtWakFCZXVEbzFk?=
 =?utf-8?B?dVNOSm55c0l3aHBHSERQZFY2dWpqVTFMMlZVWmFUaDNha2FNOHJaQTRDNTRS?=
 =?utf-8?B?WG5tTG1qWko4V1NOWmR0c3E2VnBuVjlEM3VGRjBYM3B5OVhaOW1ZM0daOHRU?=
 =?utf-8?B?ZUlMRVBtQ3hQRG9HVURxMXZ3b1VMaU9ud1RldzNRNzR5QW1BNzlKalRLQjRQ?=
 =?utf-8?B?bmRmdEdVcDhkZ3hhaHBKTmNGdUg0ZHp1L2orOVpkN2RCSk1CdysvbEVubWIy?=
 =?utf-8?B?NGUyNDd3dGQrM0hWN1Y1TmxQZUpZalkzK0hGdEEyNnVPZHRZMTl6c2VJSU13?=
 =?utf-8?B?MTFQRFIvcXBIbmI4NFNoS1BaYlBGUkkwam8xVHQwSDFmUm5oWENLR05yUnJG?=
 =?utf-8?B?c2JNNGNTRmlHNThYNHdaNEpQOFRFaHMxME82c2NmTElJRlhCNmU4dVh3S2pD?=
 =?utf-8?B?V3EzbGM1QUhxVGJGclIvc3IxZU14T2tjbjlNSmtzdTIzRzNyRFNETCtWRDBl?=
 =?utf-8?B?Q0dKMy9vL1Q5ZHJEWHdqb050a1VDOFE3OGpUUUJLU2Z2bVRtMFpSZTQ0RlVu?=
 =?utf-8?B?NjVkYjdZZHFhSTc4cjYzdnZFUklHQmlWSXJCSGYrQ3JTUGVYTXVmVTBzRmR6?=
 =?utf-8?B?NlZQSkowSDFYcjJERDg1d3kzMmlQcHlHZ0xVSkt1VHloUUx2YzdyVms0MkZ3?=
 =?utf-8?B?QUV3NlROQjlicnU0UHdxRFBmdUhYOEdqZmp6bk9oRHIxd0xKZ1ByTXdrVy9v?=
 =?utf-8?B?c2EzdWs4M0Z4NnQ5NUFsMlZuZFNKSndvQ053VUhZcHFBdkt2bTFsZ0RkQ05R?=
 =?utf-8?B?THA2dTB6bHZtc2JZc2NDYkhjbkpobGhGSFRuUXRuRXhobmhTVVZrZm1Jc0px?=
 =?utf-8?B?SDc4Z1hWRkNReEx3ZnNkRERPb01IOWlJMDlsZzFmU0tPY2ZDb29GdjJaaCto?=
 =?utf-8?B?ODJOR0RMSWhQdlpWY2NtWTd4cTA4NFBMbXAvby9NMTlOY05La0ZwdzZtVkx0?=
 =?utf-8?B?M2FLeE9PUlhwK29tcXNmVU1WeVN0R0JDaXVEZkMvNzdiRlpDSWdDSWlTUytW?=
 =?utf-8?B?UDhKK1VnTHF3bUJVM2Z1eTJ6Z1VjdkpUSWZTdy9GVEY5M2dtWG55WVMyUUl4?=
 =?utf-8?B?dlNnZ3hHZ1pKTDBOeG1nV3JLbXppV3NIZmduY0psR0dmV1lKeXdyQ3R6YUQy?=
 =?utf-8?B?M3dJcHFEOE9zNS9RRDFOVTRiYTJBQm96ZkQ0dFZKV210V1JhODBYZnE5T1Qw?=
 =?utf-8?B?UHNGdFBXL0dBSkFCb2F4OHpYRGlZV1dFODdLZE1seldtaWIvYTEwci9saHZv?=
 =?utf-8?B?RWkweFlqdWcvYVlpd1dPRmxneVVUK3BmcFIvMThydm82ZUJrOVZWZ1FPQjlo?=
 =?utf-8?B?SjR0R09sV21yazUxTkc4VWQ3THlSTm9BTld5ZUtScDR3MUZkSXkyQ1pXZFda?=
 =?utf-8?B?K0Y5UGVDUjdNbUxNME5FMzM3WVVMckxjMFc0UjBKclFSMXdmK2cxU0VrREhz?=
 =?utf-8?B?SUUxS0p4YkZWb3UxejJtZ0Y1Ni8zZEtjd0JyMnE3KzdUaVd0dFV6NXZEVldJ?=
 =?utf-8?B?bUd2b3lGUDdqY0FSUkxYeTEwL1pKQW1TRm9aUXJ3empmak5CWGpYTEJaZjh3?=
 =?utf-8?B?eE8wcUF1b0QvYXdGNi9PTlRKTUo1WWw3cHI5bHcwT0plQlBCdkMzT0pwM3ZY?=
 =?utf-8?B?ckdpSjJ3Ymdkck40MFB1cWtXZFlKUFIxOEtQTFIyWm5EQmFtOFFycG9ySkJV?=
 =?utf-8?B?YkJuZ2JJZEk1UWsyODJYMnVFeXVzZk5NVUpZNXd1a0hLWXgzV3YvRzBKVXF2?=
 =?utf-8?B?ZE81YndkVHpJMlozbS9UY0dURnhjTnp4TUpWa3pLbXR1My9sNVd5QS9EZUxD?=
 =?utf-8?B?VjN0UEVudnVJTTJGUEJNMVlHQkVvU3JvdHg5UTdOaHJyWTU4VlVzakhWS0Vq?=
 =?utf-8?Q?8iduayal3pRgqRFL+f+SEbY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 206316f0-98aa-49cc-37d8-08d9bedab75b
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 08:21:23.9371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HuK6QMpP07rg1AlVJJYHiOp0GfKRz6CfY9S2v+bPmT4CgJX6jxHWa7pxSSxpd8OMviaZIhG9b7+X+zHC8YrgOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775

This reverts commit c22bd567ce22f6ad9bd93318ad0d7fd1c2eadb0d.

While its description is correct from an abstract or real hardware pov,
the range is special inside HVM guests. The range being UC in particular
gets in the way of OVMF, which places itself at [FFE00000,FFFFFFFF].
While this is benign to epte_get_entry_emt() as long as the IOMMU isn't
enabled for a guest, it becomes a very noticable problem otherwise: It
takes about half a minute for OVMF to decompress itself into its
designated address range.

And even beyond OVMF there's no reason to have e.g. the ACPI memory
range marked UC.

Fixes: c22bd567ce22 ("hvmloader: PA range 0xfc000000-0xffffffff should be UC")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/firmware/hvmloader/cacheattr.c
+++ b/tools/firmware/hvmloader/cacheattr.c
@@ -98,12 +98,12 @@ void cacheattr_init(void)
     {
         uint64_t base = pci_mem_start, size;
 
-        for ( i = 0; !(base >> 32) && (i < nr_var_ranges); i++ )
+        for ( i = 0; (base != pci_mem_end) && (i < nr_var_ranges); i++ )
         {
             size = PAGE_SIZE;
             while ( !(base & size) )
                 size <<= 1;
-            while ( ((base + size) < base) || ((base + size - 1) >> 32) )
+            while ( ((base + size) < base) || ((base + size) > pci_mem_end) )
                 size >>= 1;
 
             wrmsr(MSR_MTRRphysBase(i), base);



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 08:24:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 08:24:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246429.424974 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx36m-0003cH-7x; Tue, 14 Dec 2021 08:24:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246429.424974; Tue, 14 Dec 2021 08:24:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx36m-0003cA-4t; Tue, 14 Dec 2021 08:24:24 +0000
Received: by outflank-mailman (input) for mailman id 246429;
 Tue, 14 Dec 2021 08:24:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx36k-0003c4-I9
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 08:24:22 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3c94ebbb-5cb7-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 09:24:21 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2057.outbound.protection.outlook.com [104.47.4.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-ONdkV3cQO2CqBo63pGLUvw-1; Tue, 14 Dec 2021 09:24:19 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3118.eurprd04.prod.outlook.com (2603:10a6:802:a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 08:24:18 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 08:24:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3c94ebbb-5cb7-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639470260;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=tA3Ca+cdZ9g0cAmUaYfoMdLfNdpcUffa6dmArIzDPXg=;
	b=lnA/p7um4RraAlwObm09U0wb8P5pvSFS0jJ+Hx+E0yQXV/kXp/OvGDZ4tpk+QuE9gZCLkB
	CK2z69z7h7iiCHaVXpqjAe2KCV/aNZx43Ses9A1pXzEgdlvEQD3kvGrX14rxxZi6X//w6h
	n41EuwIYjVx84xl2AAKL4j5YPljW3GQ=
X-MC-Unique: ONdkV3cQO2CqBo63pGLUvw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JtEcz9NLhlZwNDqk/88G8OM+jAucnOU3EN9kW7JpAYiujiRANgRGE92ZUIe6hjvBmHk2hrYVuF8yN/0DBKQynT/j3bNnoSRstDdn1uz/ZSBKrixq5rDuwMQJc8zglY5e/5X4w4gOsALlMomd3EazLRxzbAB5uMAZQA56QBh+OviJVdA8Hq0ojRPdklPWbd/Hnf2Saor/9zEmfJ5MnrjRnvUFnMmn5uQMeWNDofhRbNIURmZFNmRSTirSRauh4bT5Vqos7FWwaonXra+cE1wV2swquwsvXdJvUI4Nj3JyvBF+lpwWZ/GWK455O0OE4+bI4xgaAaL6ftajl4KOQgnZFg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tA3Ca+cdZ9g0cAmUaYfoMdLfNdpcUffa6dmArIzDPXg=;
 b=YpJ2uW03BygqdNQbcjM7tSFP1RWlx8ygQORlncGoi4/jtaSWcMmsxSkRKqGLZhuqqzalyGNwOoAwC2rKhw8x4Rn0tx3bkY1nw1TEUXKZiiasjFTx6IgUQ23IZqzUWwVXQtBmTf4bmk+F4lnroEVlZAxdZT9ceoyHpFrl0WJmsZLVInXkPJGjswxJxSjRoCOGr2sT1qVioptDsaNzEZh+d9VACTrBXPq71tre5At9SEbQa7OrvEdOdZf4bUAoKkPTOyjF9m49M17s8KHeDF+bSkLgaZb1DKqmC7tNoAnQ7g4cm0jCzLe263JvjkYIKNwr1nXXQoOf8whtakarJwTlBQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <35cc5395-f88e-f08a-cbaf-5938a508ff29@suse.com>
Date: Tue, 14 Dec 2021 09:24:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] hvmloader: tidy pci_mem_{start,end}
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0050.eurprd05.prod.outlook.com
 (2603:10a6:20b:489::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3805d185-5212-4e6b-ff3b-08d9bedb1f00
X-MS-TrafficTypeDiagnostic: VI1PR04MB3118:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31182AA18C8F711B04BF6A1CB3759@VI1PR04MB3118.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o2T33qaVhW5s2Ee7fJ2o23U/G/XPXKjicDFki24wAl6nr+8BgK0Gyvayzc+EBYbHSXopAovAF7zALoqmCCcY4JsTdm7SRjUs6fI1aqblfTxdP48+Ehc13G5RhAaXZqwlywcogOqcaAf3IkZxTc08+Mm56Rgd34paC7Sxwrsnxr1xLWj//FHwmQ7CCu3hbQI/RflZVVzMoxv8cnHlvbDHLleBrZ9zS6chBEOex9EhG10sW/nlwP5prKXRurnpDgE7DZBzRD2cb5AOS/KQid/8jrt5s6xaMe9Kbw0jLIsvnTK+i896ycqTgwGpxCHvgRHCuKsk8wELdHmGGUiyKxN7C13qQLT754Z6B7pugBUcNJIuvjcNGYdAKR/DSq8mN9A72KeOgCy4sGsQ9y+TllxtUhKiMqukgg56yVXJRTyKDre2hUGghUr7733VoTuXCVOcR+JTsSyxfGqcp4H6w68icZlDDHXxXyU/Vt49nbjicrP83/QV6G92MUHHk0tL6/4QShlzK2LoGIBcphj6qjEHTfmcW/91e+mSQN/RjkuHiMix8Er+cA/B2v3m4nqeqATqefr1zjr3ps6PbH90PSn01HFGOsug2izM3vkxQnQVq2h4kFXNAfJLCWux7Hbtmqh7lnkIK8WyAHncHf8FQsRuKuMVXINL+G3wNopoFP1YKfKZkvPF5qNWRFK59lp5LsXS9kbtZedfh/iYtVevtgpYJDjQgXMKQGbSH73QsZSaBrmhvoTdFpLF7QADNdB7dUvs
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(54906003)(66556008)(26005)(31686004)(66476007)(186003)(66946007)(5660300002)(8936002)(4326008)(6916009)(8676002)(508600001)(6486002)(38100700002)(2616005)(36756003)(6506007)(2906002)(86362001)(31696002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MFliRkZ6RnFjL05CSnlveDNBelpoa1g0VHpRK2E2czVST0NGMjF2YmRoSnRn?=
 =?utf-8?B?anZnVUtzZTdaWTk1Q3ZhVUozdU9pTW1EM2tjVTV5VVcxejFvL0RySmRsM1JD?=
 =?utf-8?B?VllMbU1hd3NOUWhNUHVRYnR5V3E1SDRLekVHemZFUlB1b0poQmVrQUozM0dX?=
 =?utf-8?B?SjFzc1AwQk9iVm1wbFhBOFpTdThrT0o3WlA4S1NtNHpLSU5FdUFCU3hZN29w?=
 =?utf-8?B?T0swVUtCT00wK3F0YnVQd3p2WXhIajBQMzBwMGduWDkzWVpnamxhVDVYVzBs?=
 =?utf-8?B?T2tNNnN4QVFDVEoxZWVUdStxdWJQNDQwb09tbjZyM1BQSkVjeEJhYnZGemtU?=
 =?utf-8?B?MUpQLytZUkt4Tk9qYW1uRzY4bExkY2NaYUorTjFaYnRRdVFud2NnWHM1SHB1?=
 =?utf-8?B?TFdLRm9wVnAyZEJJMHZvd0RuUmtycHpHZVhRRHJlWE1UVmtqOGt4ZEtQSXFS?=
 =?utf-8?B?SlNYUUp4a0Z6L2JGdzl0YlpNYkdyamNnN2tmWjIvVEt4QUdkdE1XNlo5VlY3?=
 =?utf-8?B?WGRiY1NpWVBXVzRsY2JKYXEyN3NrZ3Q0cHRVZ2oxNzJ1MmJLenZwdmNYRGZG?=
 =?utf-8?B?MEtKaDNTRno4K3V2RldZbnR1YXoyK3JLemMzOXRRdGFvditMeFhvZCtnWDNu?=
 =?utf-8?B?d3JnWmVaNFMrTVhUL0FEb2h4Z0R4cTBBZktSVWZBRXZRL2FlcTZ1amVOb21D?=
 =?utf-8?B?ajVjU3JOZVdBbEZFaUduNmdBR1lDRXhZTEUwb2pPamluY0V4UllyTE9MZUh5?=
 =?utf-8?B?bUROVWx1WjF4d2RpR2tuM0YxVVlQQTNqem1EaVhPdklEQmRZNmJjeXkxdm9U?=
 =?utf-8?B?RW9KMS9BNGNpUE9iNEZPa3p1MER4VDNHNU9ZMVNwdklDZkVYSWRJMlFmVUdZ?=
 =?utf-8?B?U0RFYTBhR2h5U3pxQmZWMTlwMmNHS0dCYU1IWVRjRll4Y252VS93cEx1QUVm?=
 =?utf-8?B?N0dkOUZ2eCtvUlBrNkRqRWI5cmJSWnFneTdLUDNtMm04WTJzOGRwd0FyTXQ4?=
 =?utf-8?B?c1ZwOHM3ZTRyaTJhWUlkbkVEL0VpUDB3dFFGOGhsa0tvcVh1d3pqZDZ6dHI0?=
 =?utf-8?B?bFhkUFM3K3BEOUtQTjB4SHh1U1dlWWpRcm85RDlOOFI1SThQMG12aGxOS29C?=
 =?utf-8?B?MmtYV2sycTlGbjJXNmMyZFovYTR2RVlBR0NuaWorUXppZGY2QXZlcUhJWi9v?=
 =?utf-8?B?Wm9kRFRlQVlKVWM2Q09ISDJjZkQ1SWpJanVSYXhGa0toNmhZMzBWYnFEMkR5?=
 =?utf-8?B?d3Z2STlIdTNtQjJCOVR6UlhiS3NQcy8ydXAyMklkWkozbnNxc2R0emlVd2gz?=
 =?utf-8?B?Q3V3TldBRDFZZGM1NkFINXVHRm5XSE1iY3dpR2J4SEo0RkdYbW5qV2x0Y2Ja?=
 =?utf-8?B?czg2YnFhV3lseEtJc3g2c01SbUZYL1MxNFRPVThEaCtTayt3bCtMaTR1ZmN5?=
 =?utf-8?B?YUdSZHRxT21tQUNVQisxS3QrOUtFZGIrc2crQ0MwemRuQ05LUUZCcW5zem9B?=
 =?utf-8?B?T2ZIdlNaQWZMT29ua2hicE4yQ2xLWFppVjNLaHRYdWlPVzNvTHJQYUFISHlZ?=
 =?utf-8?B?aWNuQ3JCbnVybmRid29LeGV0aC94T0VoRkNJRjEvYituT0M4T2NCOXU3aks5?=
 =?utf-8?B?M1R5Tm9RdlVWa0NKODFlT0tudmZoQXkzU1MwSXF5MURLeUtnVXZ0RllCQ2Jh?=
 =?utf-8?B?VkMzODdNQVA0VC8xZkZHUml5WjJ4dUtrR3RVUnNqVXlSMmlYNlFnaVVRYk5i?=
 =?utf-8?B?WmVVWk1LTlkxMTNmVEdQK09xckZGN2NtY2syWHVRRm5NcjF3ZDQxbmJYZ1Mx?=
 =?utf-8?B?eWJnNGRCUHNrbnN3MW1iS0FoZ05TdzFrR0VBK0RVaUJNSW5WYU5hT2xFSmtG?=
 =?utf-8?B?SFFyRGxvcjRJYXdNTWN2dFdubVppYU1mZllkTkEyNmNYMzRpeFRVOU8xRCtx?=
 =?utf-8?B?RFovS21uQkhGVFEwZ2xoR0kzUUNYR3M2K0l4ejNheFBIZ2tjQWpZbHplNVZh?=
 =?utf-8?B?bVNBUWhPSkxCZk1ZWlh3UzNJdkZjZ0M4Mlp1NjNWNkpmb0xJeVB3YVFOMDhL?=
 =?utf-8?B?WHRDaEFUUldMOXVqdHBxKzZSaGpYN2ZmcitaQ05Pa1hsaEtZWnlBVThySzky?=
 =?utf-8?B?RVdscXJXbnloS1FONDV1VGt0NkJZcFRneUlmdURxQmU1WS8rY0MybHVyTE9L?=
 =?utf-8?Q?4FPtFzuXAT0I2TYenns0+YI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3805d185-5212-4e6b-ff3b-08d9bedb1f00
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 08:24:17.8269
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KNJbJ80OI1iF8HiEQvCuzx0QSZYu3D4P0BIfzDSTKPFeKyxKHJCu01/pK9o/EBbf+vg0qjAaHCQgvSH3jaWl3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3118

For one at least pci_mem_start has to be precisely 32 bits wide, so use
uint32_t for both. Otherwise expressions like "pci_mem_start <<= 1"
won't have the intended effect (in their context).

Further since its introduction pci_mem_end was never written to. Mark it
const to make this explicit.

Finally drop PCI_MEM_END: It is used just once and needlessly
disconnected from the other constant (RESERVED_MEMBASE) it needs to
match. Use RESERVED_MEMBASE as initializer of pci_mem_end instead.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/firmware/hvmloader/config.h
+++ b/tools/firmware/hvmloader/config.h
@@ -55,12 +55,10 @@ extern uint8_t ioapic_version;
 #define PCI_ISA_DEVFN       0x08    /* dev 1, fn 0 */
 #define PCI_ISA_IRQ_MASK    0x0c20U /* ISA IRQs 5,10,11 are PCI connected */
 
-/* MMIO hole: Hardcoded defaults, which can be dynamically expanded. */
-#define PCI_MEM_END         0xfc000000
-
 #define ACPI_TIS_HDR_ADDRESS 0xFED40F00UL
 
-extern unsigned long pci_mem_start, pci_mem_end;
+extern uint32_t pci_mem_start;
+extern const uint32_t pci_mem_end;
 extern uint64_t pci_hi_mem_start, pci_hi_mem_end;
 
 extern bool acpi_enabled;
--- a/tools/firmware/hvmloader/pci.c
+++ b/tools/firmware/hvmloader/pci.c
@@ -29,8 +29,8 @@
 #include <xen/hvm/hvm_xs_strings.h>
 #include <xen/hvm/e820.h>
 
-unsigned long pci_mem_start = HVM_BELOW_4G_MMIO_START;
-unsigned long pci_mem_end = PCI_MEM_END;
+uint32_t pci_mem_start = HVM_BELOW_4G_MMIO_START;
+const uint32_t pci_mem_end = RESERVED_MEMBASE;
 uint64_t pci_hi_mem_start = 0, pci_hi_mem_end = 0;
 
 enum virtual_vga virtual_vga = VGA_none;
@@ -329,7 +329,7 @@ void pci_setup(void)
         else
         {
             pci_mem_start = max_ram_below_4g;
-            printf("pci_mem_start=0x%lx (was 0x%x) for mmio_hole_size=%lu\n",
+            printf("pci_mem_start=0x%x (was 0x%x) for mmio_hole_size=0x%lx\n",
                    pci_mem_start, HVM_BELOW_4G_MMIO_START,
                    (long)mmio_hole_size);
         }



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 08:58:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 08:58:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246442.425009 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3cs-0007bW-2u; Tue, 14 Dec 2021 08:57:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246442.425009; Tue, 14 Dec 2021 08:57:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3cr-0007bP-VE; Tue, 14 Dec 2021 08:57:33 +0000
Received: by outflank-mailman (input) for mailman id 246442;
 Tue, 14 Dec 2021 08:57:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx3cq-0007bF-BO
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 08:57:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7e8ab7d9-5cbb-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 09:55:08 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-TPsdisXfMJqnaXt14Gr72A-1; Tue, 14 Dec 2021 09:56:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec
 2021 08:56:47 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 08:56:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7e8ab7d9-5cbb-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639472209;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=f/CK4Xg4r9JkrPu6oWc8+6LnGDSchffmw1nI7kyKrVI=;
	b=cCY2kKSZdzpfqmtZluk0kKtSMEWPlrbTiLl1yxfrCueLZrGsUSJw2vtbV4KdhOuvvt1oAB
	TzabybbgfWIfYIwlxgc2s3u9Y0fS5BnBpVbeCVV/qDBvacBAnvbhBSS/KsjRptN/frtk/C
	A9PrXbTzUKe2QfKWtsaGSPaoAtyMIO0=
X-MC-Unique: TPsdisXfMJqnaXt14Gr72A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N10ZBwrHWFR6boOWgsJ6AQIhAUnzw3in2DqCwwGwXHRZhClOicWLY/HmVRRRnGpPHuhv6EBXO2r/9890iORnswRSDaAj84pCfqVtG4jaE2wLmcDuRGY96tdI9HU1zbcabuSj7gTPssjORMaWdkdVGe/GNWdtWwt8kdPi38NxrjrSlHiTA2KFZQj5gp28e+Gy/KVJErNpvXlCOuKUEr4hFqeFBThvW9sz3ehwpry/JVjyx+/nRA+EylWeDAkUks3lV+AwHhIclyGNzB6/F+lBrDYkNOiXcMax7H15yR9vzzl+nCJQB68pfIbjMY/snuyLOw3pPNIBBDb8x2FV9d+MYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f/CK4Xg4r9JkrPu6oWc8+6LnGDSchffmw1nI7kyKrVI=;
 b=AjtkSy63HjhZnc3D3eLmTpan+L+btVoqRoacDVW67Zh2bvOu/Qkbl5LCg4HZ9Nm9cKD8GxRRkHL2GdFTgsreQHl1GoLMdxtN9hRH4n6xwkdPKt4Iqo3xHUD5Dk0hfS41H8qT59wB9psTY7Ob9eanA61qsvhaJevPaDMAE8nhylcajebRuAq3miHUdo1HE1fyL6KnIguHkqFRqfna1TdO1pw846o6EORY4ul52Rei/gjhVIP3Z/394rJtiok6K3K3RNsgs3n2eG377kpndIc8DHmcyknE5i9EkKNZh4R1GzL+NeSyFMaD8Gg9kMg5tOg5jvIKmjxJY0DvIDxfL51qCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <3ad64836-c1a8-cfc7-388c-6b6510aa7bb4@suse.com>
Date: Tue, 14 Dec 2021 09:56:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 05/13] xen: generate hypercall interface related code
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-6-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211208155606.20029-6-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0081.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc3fdf42-1191-4047-84ed-08d9bedfa89c
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4190AC5F518C0169BC607CE0B3759@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	OQ4F/+y2gEwfgeebsQlpepLxAooyz8P3C6S1Qbpmx/fDUQgWbox1hYokRQiV3SqCnQemz5ES1Mo72q4NMflI4+iOSFCno141I12DB9XUrNicqEd2p/oFJItFLt5ftxQPbKXOg2u3JP8oYy8H4BJIsoTEyBc1iKb1CcTIV2q+1ynVFFE3tMjuNHPQ4CikNG8LoMuiHDNGXId3GHd4HTb6ub/adK4HBFRCqopKyMBMy7tkQ7Lh1KYoNSGpE0uAE5I7YI1utylS+uWFu+oJSWE9825xzavkcfkfhdiIP3AKMsM+qrhuOyPjl4NbnMzVhLLLJOhXqqGy9cmHwECl2Ng6xprrckSeDvWY9jMQjCX0IGSiGWEDlqlYGRGTjGA7+D1t97KNTuYarO7RKuzhxkYIGAWvFgml/Mccnzm8hFDZeodk979xeRxDsW02z+GEVRq24ZNZnKPoiXGChqZf14bWkTqbe11lyzawEW7FxV4+yWhvjn1h/IpGpAPlSecM3fBMRerVCHHdVj7oQX760UdpUh0kzOX+O7zCkTayjHxUXfT/X0rRelNjksHb29ZcilCmj+td15GH8LoQbT8R7scqDmN0YPNjMFGOTQ7JKHDtujdcl8hDxNP/SOU/n8Dr/fYLr3EyafWr/kr7VNDYrxGoMSTDynkDkqLKK5rt99JWTqG9m8hh4iBskAoSw9S8nZR/1nYA52ose1Hn8RWbqc4wQaxS2aohLOlZMo35NOSPIuc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(6512007)(5660300002)(6666004)(66556008)(2616005)(26005)(66946007)(186003)(6636002)(6486002)(36756003)(8676002)(8936002)(83380400001)(508600001)(6506007)(4326008)(31696002)(53546011)(6862004)(316002)(2906002)(37006003)(54906003)(86362001)(40140700001)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UXIyUDl1aXhpckx3Sm9ncGtjRHprQ01VVWdxa240cG96UjBUdmxIQlJUNXhT?=
 =?utf-8?B?SDE0VXlkWEt6aHZxVUlUK05WSDFhb29aNDdwU2FoZjFLWEVFdjdkbnNwL0s3?=
 =?utf-8?B?YkNTQ09Ha0FaRzZtMlBzSXBvV3dJZjFGNnRWdGl2MHNTRzRQYmNkYzk5RzJX?=
 =?utf-8?B?NnJXTGRyYndvSElLR2RldS9wdzVBM2ZxalYzaE5pdTI3QWhGZWZoRFBRNWtX?=
 =?utf-8?B?cEhGUXhXNXBxVkthU1pUSTQ3WExta1pVR0pMYjZTUFFjVzl3b0dkcUY0YmV5?=
 =?utf-8?B?bUJzbnlIVDVuVVZGVW9TVmh6eG9NQnlVYm4zU0gvUG1JbWNFS2M0dzkzUWx4?=
 =?utf-8?B?Y3o5RnMwYnozV1JJVXdFUTRyVzBhU2MrUTVCY0VMVUpnZ2N2Ymplc0IrbE1z?=
 =?utf-8?B?L1pUeUJBdVNCWnFic3lXWGU1UjVSekNNRElsM1FHUG4yaEw5OXNBb2xXR2pB?=
 =?utf-8?B?MTlDRXBrS0NVMlYyeTRwK3JlUkFSM01yRW55UXdtWmpUMkQ4U0Z3blRwaUlE?=
 =?utf-8?B?aDFEandkS2t5WDhjd2IzV1BaVjd5OWo5eXkrMWE5MXNwNlJqK1pZUm1aYjR3?=
 =?utf-8?B?VENWSXZqa3o2eXpjVlNaWHczdTNiVTZKaXYxcFF4S1JoUW0rd3pnS2VkWEh1?=
 =?utf-8?B?VUg0REd6aC9UYllmSE9CYW5uODhENEtLWW1Qc3d4UXB6UWMrWDZQTTJsd2JZ?=
 =?utf-8?B?Q2dFZEsvV244U0cwREQwQ1BqQTJSNHlPU1Y0eURlSUZnOFpxQXp2aEo2TTl6?=
 =?utf-8?B?ZmZtNDVRV01CRU40R0dPNlRObTM1dy9UUk5wL0FaNFJmb0NOMkN6N1JwV1gw?=
 =?utf-8?B?RUpCbmdhMjhOc2xjOVpQS3JjRytzcnUzbzB1SVAvcXdhK1JZT0luS1pDNGxU?=
 =?utf-8?B?QnE3b2hwMHBZOU9MYXR1YkpON01zQWthZFVNQ0k5V3BZNmpHYWZXdnZVK0pm?=
 =?utf-8?B?NVNDa1BZekxmY0pNNDkvQlhTaG1zT0U4dXIzLzZmUDgxNU95MXZTWFdudmVZ?=
 =?utf-8?B?Y0pZc0hWYmVzazZnVkVxMmZHa0hTMmU3U0c4Z2xmRjlONHMvdGhlSG5DZ0Fq?=
 =?utf-8?B?Rk85RDBWNjFSRzBVOVg0N2R1amc4NktlTkxLY2ZJVlYxVmpJVnFUWWQzQ2p2?=
 =?utf-8?B?cFNnTGU1aVhncndlN1dNbkZZNmp4TFI1Ym5ETGVVbi9pLzdxMlFhSVVQcG85?=
 =?utf-8?B?UkFtOVVTZ2VIT0RxSkE2Uk9tUlJaVDZJME9KY0luY2NsTnBBeVExMTNQWWNI?=
 =?utf-8?B?YUZJbG9qSVVwamUxeHBtODdxMjJYSUhxY0xpaEd0UXgyblAzM0pwVWpoWEdX?=
 =?utf-8?B?R3ZjZUhHMW1HeTg4MFEwbERuaGZ0SGpzNVdxVWhnUVhrbDVCU2JzZjJ6cUt5?=
 =?utf-8?B?N29RNTVjRSt6aVcwc1MyOFZVQjNNVFlvaU1CMk9tUjd4ZGluLzQ5Y0Vudnhq?=
 =?utf-8?B?UHNsTk9nZ2dScFFPZERWcXJURCtrYkdnS2JUOWxCbkRyQXhJRFl4ejZjdnY2?=
 =?utf-8?B?dTZXbm9JcVJqZXJkTitrNDl0OFZtdG1EM2FoOHB6YUV6NFpnV0JLWHd5RFlr?=
 =?utf-8?B?a2w2UVFNUGs2elNrajJCUDU0WXl0cjRYbUk4REozNUdjNHQ5L0tzeXJ5WVpU?=
 =?utf-8?B?YWMvaHZYVTFvYWhoMWZ2MzlVdXQ3Y3JpczV2MndaSFBVcGM5WFlkeklQNmky?=
 =?utf-8?B?UXdHaFJnVWlON0VnL1YzSFA5cDBTeUszdjN2RktEOUlyek1ZL3JIVyt6RFNT?=
 =?utf-8?B?UUZyaWh4MThRbG4zYnlaUHlKM3VJelU4YlNjWEt6bDBMNmp4LzZkNkFmNTIy?=
 =?utf-8?B?UWtRb3lHa0lxQ0FmaE5FaDdPWE5qNUJHbGE1SVpZU0hmcDlzS08xWEhCZG9L?=
 =?utf-8?B?MUlXa1FFZFAzQjEvSi8yelRjZ2FMUzJkZlZ1OVo0SjJ6eEJmUFVTaGFmb3BL?=
 =?utf-8?B?Tk9nUXBhUVdrRHFoWGJWdkNaaEI5MDJDNk5ZdWJoYU5lWXFVRm9rM20yZlBs?=
 =?utf-8?B?UURwS3hEWlBaRzVLUW9FcjdVbDdMUmxFUFZmVlJZVCtKMTJGeDBicENpM3l0?=
 =?utf-8?B?YnorOWo0cUYxbk9nTEo1cytTR2liTEdIOVRrRUZpRTFEM2JoWU9JUTZneENQ?=
 =?utf-8?B?UVZ4anczZFZSUkVMdVZQQXF6ZEl5WkFPMzIweHAxNHRQMjRFNHhCaXpYUk9P?=
 =?utf-8?Q?ZyejfxKPuKNhfL744z0UHjE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3fdf42-1191-4047-84ed-08d9bedfa89c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 08:56:46.7798
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ilRxaxfsHqIJ6+NbEpydxe/LpEauA7Pt3RHC4I6PCJWA3at457oT4/ooR80PyVHO4N+gbF3nvSgYafwNcmfl7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 08.12.2021 16:55, Juergen Gross wrote:
> Instead of repeating similar data multiple times use a single source
> file and a generator script for producing prototypes and call sequences
> of the hypercalls.
> 
> As the script already knows the number of parameters used add generating
> a macro for populating an array with the number of parameters per
> hypercall.
> 
> The priorities for the specific hypercalls are based on two benchamrks
> performed in guests (PV and PVH):
> 
> - make -j 4 of the Xen hypervisor (resulting in cpu load with lots of
>   processes created)
> - scp of a large file to the guest (network load)
> 
> With a small additional debug patch applied the number of the
> different hypercalls in the guest and in dom0 (for looking at backend
> activity related hypercalls) were counted while the benchmark in domU
> was running:
> 
> PV-hypercall    PV-guest build   PV-guest scp    dom0 build     dom0 scp
> mmu_update           186175729           2865         20936        33725
> stack_switch           1273311          62381        108589       270764
> multicall              2182803             50           302          524
> update_va_mapping       571868             10            60           80
> xen_version              73061            850           859         5432
> grant_table_op               0              0         35557       139110
> iret                  75673006         484132        268157       757958
> vcpu_op                 453037          71199        138224       334988
> set_segment_base       1650249          62387        108645       270823
> mmuext_op             11225681            188          7239         3426
> sched_op                280153         134645         70729       137943
> event_channel_op        192327          66204         71409       214191
> physdev_op                   0              0          7721         4315
> (the dom0 values are for the guest running the build or scp test, so
> dom0 acting as backend)
> 
> HVM-hypercall   PVH-guest build    PVH-guest scp
> vcpu_op                  277684             2324
> event_channel_op         350233            57383
> (the related dom0 counter values are in the same range as with the test
> running in the PV guest)
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:07:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:07:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246447.425021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3mR-0000oc-3I; Tue, 14 Dec 2021 09:07:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246447.425021; Tue, 14 Dec 2021 09:07:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3mQ-0000oV-UI; Tue, 14 Dec 2021 09:07:26 +0000
Received: by outflank-mailman (input) for mailman id 246447;
 Tue, 14 Dec 2021 09:07:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx3mQ-0000oP-3F
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:07:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 28954da7-5cbd-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:07:05 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-20-vJVJJU29OQqPijsNKKTKbg-1; Tue, 14 Dec 2021 10:06:42 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3390.eurprd04.prod.outlook.com (2603:10a6:803:9::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16; Tue, 14 Dec
 2021 09:06:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:06:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28954da7-5cbd-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639472804;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=7H66UQnWAlZBGEnJvWegVKQ00ZFuA9LYcIhMYt1cYGU=;
	b=DXJ7qX8mGVX/+DtG5y5MUO9uERDyDUa5U3s8jjhmNBwdJ/mK7gX9crO7QPYEWGAz28Ra85
	UEAFF+9xekLexGF3LlWQb3YZdwfhlmKiSLOOvqo2bjiICTzitx0wtPbiy+7eLGBumtvCOL
	Av7MhO8YWtg1tKN8WZN8RgGh1UP5jqQ=
X-MC-Unique: vJVJJU29OQqPijsNKKTKbg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=erNBjw3cmoh7bqg3JG/Emdkzp4AxtcJ+dZ0tnaZM1xPER3oq5s2C7l2VGPRYm8dTMv4zm224w39xfhDdotJTkp5XbW6Aot6qv+k7LGvFp00146Le9p3EN8tWpfZt7tvJ/9BSkrcUJsi47z7Wi9ljK36tFdh/+ocbNMmztJsl49fwhu3om6VHDN1Mr3EzUUR0qg41VKI4eiaH0whjyr14WZqvSwd3A0wmHO238Cyo6SNzNtQujThvbktztb+VMVnvtEzkjhuMJM7lD98lX+XybKgW6ibN11HROezmKf21P2gectU+GskPNrp/OpKzROR+nOQ+mdee/QC8tQPy4Fd54A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OUJO2ATnb/S47w7qGDSgAIqT00NDkfzbeWMH0qFrAzw=;
 b=l+X8iVB4mY4/rQLTTACqewdtkocGAamGfHw7JTrUiB+6j8XMrF2U9vtkC1x/qAq/72/a+lrI7uqKoLJlVf3Xziv2NEqpBUaJT/RtAFAKe5w5+Tq6a6+Yau+S+lckpJBw6LJuvh0FlbS5GHk3A6K145SWuZMKlUG0LeHzr7x+K6xjSdebd5isd2s4VWZg857rL5kyVCdJhp27EVYUYiqJT3LKcDGfBi6oyQ9eBHZ6TSIaD8/hQKhJCpjQ0Q4jI9Zl9ElM1gjpuLPdiUy1fDOn4Hu7L+1iNUz1ol63uhDVPFT3bvQf0fYVw+kKpVpP5PcnnCBVhzFQeYemCUpVJkM72Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <612dc962-229c-f43e-abb3-fd460c1412b0@suse.com>
Date: Tue, 14 Dec 2021 10:06:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
 <Ybdg6/J6oUf/5hEH@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ybdg6/J6oUf/5hEH@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0063.eurprd06.prod.outlook.com
 (2603:10a6:206::28) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 07851677-f927-42fe-0920-08d9bee10a21
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3390:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB33900717DD9B630CF4A165FBB3759@VI1PR0402MB3390.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eDL2BLvT9/7kfXkTHtMBDAZi4ao1VCtF9hdwbbxI8ldycAvjcO+1vcYomNNWws9SmVzpmAUFR63tYyIbmbSSTphFnygZhcqsWjumpsrejaD+e7tq7nulpzi4zjtRi5MHj5vCOQFuRYnmTibdEV5KZMHqMbyoyRXDGlTqNn7sI1cQwqEvSh9CHE7l5JNYm5FT/PCmbUIHrPiRYSYMYJY+3LAGySQvWGTiF0SjhHOlqjwFZ1K7lnaXARjEHPq1Jsp5XFp/KvuSCNv9SaaOWNv0mCeT9U8oqMmeH3gCL2eOFyJ0NJHMKLfb/UXAy5DBg/COnNv50T7o5QbDbs5517wisAKspuxerep46bSSI332FFkIhbxyY9JDEX5W3N12LH83k6xxBFTFPc7GINWfeF+K9IPzYqjl010DGbTiyIVK2Q/oSqFQD51UYetKLjcgcx/rlAj3mJ3UN3A3DXkl2kdSZTT20TuiYks9KRb5UR4GrpkWBALvLxaSMwIz92U8G6MUjAlauqSCCexQX1rWJMOI/M/8RAaIJnnr6/xzKTJC5/v7pcKLtWX4MntDUdiWbN1Nigd9/+ZDQxF/zkhvAZBO7VW+YpDqudj3CcwoyCqlofPNA1mQiIbVWRv370VsJSpV5dX/WAbQiVzTefEIX+TTzWdjN8+lMm+3DKt/7xwHMYxwiZErc0KAE08JSRlg5VE/PzHEhcUsoMBBfGvKw19YcerEizRDW3vNkitmBaDy9rE=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(5660300002)(316002)(4326008)(38100700002)(66946007)(2906002)(54906003)(7416002)(31696002)(6506007)(53546011)(36756003)(83380400001)(31686004)(508600001)(8936002)(6486002)(26005)(6512007)(2616005)(66476007)(66556008)(8676002)(186003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QlNgfe47nDaQlWzAdpCxrdK4zDCtxarDKOhKh4XiNTBYhESGVOA1RS6Undf0?=
 =?us-ascii?Q?tMTOip4RzFF/mZwRkx/HYsALKzZArVevESH+7kxyxydNA99Ke3vDa8fdEmD3?=
 =?us-ascii?Q?ICS35eUZ+zjZeT1MnKiv20y3bcNysR/PYj+A9wPhoGhbO2Em8Oz/K52k66YB?=
 =?us-ascii?Q?9vx9IOIxlhUIDyDYxiUltD24DMTREwK/2Xm/WrARU8zEqw3Mv2PP2IPsI/D4?=
 =?us-ascii?Q?nacwfUfIdqU+7WhqqzW5KOvY97H19147PJbRnVnRdOAq8W59U3bQ3z6FASrw?=
 =?us-ascii?Q?lKa//s1JBMBVmp0nTLCx9FobdO8X6TlyrwRoqp1km6T5PTF5emqu+mm+PeEA?=
 =?us-ascii?Q?ud/KRjST7eXTka4WxERtP3bTRmv9mMyFOTtLa5VgbQWz3CvSVMn1JpjUeuNH?=
 =?us-ascii?Q?QPoKhZl4M8fj9QhpdMAghSWg07fKO+ilrmYRyrMpntanJmlbK2nLfA9wSEWg?=
 =?us-ascii?Q?BCvAXdrF2nZ7sQO0DDyXzQtqIyUsAtAOYy6gsB45CyEjlrnDO8O2EXwlRir/?=
 =?us-ascii?Q?mV0LbZ8yCIkJ7DwwbXMV9JF5LT6GOnZNC0+Dueu1ym5a9UHZMQfotZTl53Sw?=
 =?us-ascii?Q?SeIsIh8uqj5tiOY0/fGqNUYdklTurW5tHwUjBVAD0qOtDIoJE7YWRgiIjiZP?=
 =?us-ascii?Q?Y5zO9hF9DstODhIh79PqwNt8hlusLVIBEHCJLclfECKQXh0ZNaY0f5cRr+IG?=
 =?us-ascii?Q?E9fiU6/eDHy31NNiBT+UKoiCPP6qRXYx8iYS8AuLv2JX+VBAK1KjzpYOn3bg?=
 =?us-ascii?Q?bH3uFTInnYeHojm+onjwLoueBTo/X7OFhbFamKIYt+KTdUPsiZmuJpnSn4GT?=
 =?us-ascii?Q?lP3bxTUC90yq/fyw8vsoiCXXW3DwHawQLnIOf2rqll/6WtRyqo3gfIbUIBeK?=
 =?us-ascii?Q?NBidPEP62dnnMafnNAUaMi8PYU6GVi1WTZfTQSKEy6rnz2UmVZhv2GyfmYOr?=
 =?us-ascii?Q?HYsxjqg1vg0nmqPJ0NNPYyKBlpLZk7r0iwf6ZEtxJXztACdZ1Cj+CbFAuXBB?=
 =?us-ascii?Q?qaSvOYmFoummR/ZzQG/iLiVHxzv9dWrV16ZhUNOO7BcLws/scsCKq+e017fr?=
 =?us-ascii?Q?6x6KVcdD4sb99RQTjIjIB9g6KWXV+T4wGETCqgc6YUYLm2c8ubiKkaMACgXv?=
 =?us-ascii?Q?qlmE0ZZyudO3WUatzKGTq2vwLPzMcjtyvRfDrPod48JSxNatE9862QhEqnAU?=
 =?us-ascii?Q?lv1/xvBY5cAgRNYJT5uxDhXa5hSXq5wBBeLwPmehM+GxjTl97YYofszikXql?=
 =?us-ascii?Q?QmUWZWybOSzYKdVm6R9PBJcJ5VHrNOdaGb5Gz1rblBejBovkL/W4n5fRgQOM?=
 =?us-ascii?Q?4WO3zLXHH1QtbVyDTYcZ9yWscORIa+Pxk39sfb1JNVhXtcyKklUU0QsxTlxF?=
 =?us-ascii?Q?h7uQ/sBOHQnG6j0MCumDpcd8RS0a5NuCHNKjkQhthlJct1R0/y2Zz2zPCZ2r?=
 =?us-ascii?Q?MUtUdGHAXAvCGzc6mmMOEtVa6WLJDer60xPRNduIPNIR1i8QQdMcnzvBQ6IA?=
 =?us-ascii?Q?4YEzAR++CSigYVV/kFufZuVN9rWGZ1GPi+M6eZFFiyPoYGWOgO+Hk5ssR2ae?=
 =?us-ascii?Q?11i5gOr1c05yNaaRzdcmCjFlLDsB3PPXCtKWZPMwKDMU5rDI0VWkZA0kylSx?=
 =?us-ascii?Q?z49J4x4oFH9cgydgUeiO5HA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07851677-f927-42fe-0920-08d9bee10a21
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 09:06:39.7481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iim0enpL/4vTWdIWzk2PWQNuOdIlhffNsNgSNv6bJsLHJpDy3rxcFfYJOo6Z/QFNLzhd8n6JavvjuZkJilDGig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3390

On 13.12.2021 16:04, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:53:59AM +0200, Jan Beulich wrote:
>> Having a separate flush-all hook has always been puzzling me some. We
>> will want to be able to force a full flush via accumulated flush flags
>> from the map/unmap functions. Introduce a respective new flag and fold
>> all flush handling to use the single remaining hook.
>>
>> Note that because of the respective comments in SMMU and IPMMU-VMSA
>> code, I've folded the two prior hook functions into one. For SMMU-v3,
>> which lacks a comment towards incapable hardware, I've left both
>> functions in place on the assumption that selective and full flushes
>> will eventually want separating.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Just one nit I think.
>=20
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -731,18 +731,21 @@ static int __must_check iommu_flush_iotl
>>                                                  unsigned long page_coun=
t,
>>                                                  unsigned int flush_flag=
s)
>>  {
>> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
>> -    ASSERT(flush_flags);
>> +    if ( flush_flags & IOMMU_FLUSHF_all )
>> +    {
>> +        dfn =3D INVALID_DFN;
>> +        page_count =3D 0;
>=20
> Don't we expect callers to already pass an invalid dfn and a 0 page
> count when doing a full flush?

I didn't want to introduce such a requirement. The two arguments should
imo be don't-cares with IOMMU_FLUSHF_all, such that callers handing on
(or accumulating) flags don't need to apply extra care.

> In the equivalent AMD code you didn't set those for the FLUSHF_all
> case.

There's no similar dependency there in AMD code. For VT-d,
iommu_flush_iotlb() needs at least one of the two set this way to
actually do a full-address-space flush. (Which, as an aside, I've
recently learned is supposedly wrong when cap_isoch() returns true. But
that's an orthogonal issue, albeit it may be possible to deal with at
the same time as, down the road, limiting the too aggressive flushing
done by subsequent patches using this new flag.)

I could be talked into setting just page_count to zero here.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:16:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:16:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246454.425031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3uU-0002Mx-Sk; Tue, 14 Dec 2021 09:15:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246454.425031; Tue, 14 Dec 2021 09:15:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3uU-0002Mq-Pi; Tue, 14 Dec 2021 09:15:46 +0000
Received: by outflank-mailman (input) for mailman id 246454;
 Tue, 14 Dec 2021 09:15:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx3uU-0002Mk-34
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:15:46 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 92e31ee6-5cbd-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:09:42 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-8-DSOQbIZyMA6MgJQ8qvuZ3g-1; Tue, 14 Dec 2021 10:15:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3773.eurprd04.prod.outlook.com (2603:10a6:803:1c::27)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Tue, 14 Dec
 2021 09:15:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:15:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92e31ee6-5cbd-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639473341;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=YD4glZCj4drqvstXxR8/NkCaDF2O/dfIVHVwp/Ydyc4=;
	b=Al9TkKtixmcKOvfWeFlNvJecnQcEeYFrCn2jC287b8diZHBWkqgBWbmXjHQtU4Pj+nZqsk
	W2B2U8O9B1LwBR1eiaqDwnJl86uqlRnhgxaWUOUzo7QNga1SwWBtlbJo1fLc/JjJu1SgZ4
	BKWwEu+fmdnASJTiYEvCnvjOX4uIZ/U=
X-MC-Unique: DSOQbIZyMA6MgJQ8qvuZ3g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=avkMExzUrsMZ4Uj0KufpIDOAc/mMyYrDuenZwmcLhNik25YxeGtUzHi9R3Dv3nkcWUFomZRCy/9QtS759lV82V1MXocvAFgNGx1xcGTy78EqQKhyvQqD/LHwQJI9/d+XCLBFnLAOH1WuN0awnfc/RSOdMn1E6A6gfhXHO346N0wxHPVJX2aevibH5M8u5vcaNk9q+zRhW+FzxAHWZBFJluNIN5pOzDXRAfgGKbXrpvswij34xYIM4TgB2I8uhsM62PpsDLGqIbf7xrZTNJoFKQb3nv096jG7an66VS779nrkwBvPe9iSDr8bXmadouhTPYa6oBkWpWhBOPcf4s2vFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wlUCKYbVT2v00ik+CjmWls5ppUwwUQEydRtTRfPPBdA=;
 b=L9dJBhLl3yxiCeg6mYHrF1DLkgf37WO1wYH7zBE/pNDR/S4g8fFXBG9QdTEP8RaZ3R4CsTimfb8Fe15dCkG2ET6QyA/DPzPiIRJbNja3o+lDMkLUvHDKw8Yrub7pIrb9gXwg8DQblBY6JEdach7w2ndudJIl/zQ73wbrgDzteQnU8fC0SbPMGT39x3rGZI0v07ldqM9zXBpWb0IuNOrK87NGTJZezYaMW1vW31V1fa6+ff7gBCv1UwdiiOOBNV9N90sYzz2pZXoC7INO8wR1QQBvRJHdxEjFpTF1Ch5Mr+NHX3JjN0jvk+xGThOew88NyqQySNRgvui2hs9502a/Uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <265f07b5-03e0-a8a1-a665-1fe35436f7a1@suse.com>
Date: Tue, 14 Dec 2021 10:15:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbdsAy0huMXBjJe/@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbdsAy0huMXBjJe/@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0325.eurprd06.prod.outlook.com
 (2603:10a6:20b:45b::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fd08999a-af0a-4923-9979-08d9bee24be2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3773:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37733462C4D68C3C0FE6DB00B3759@VI1PR0402MB3773.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	8Xl6MUZ3upMYpepDoS7EhbwEGHOXUS2g2MRpSRYRsST324Y/ckRX2OUPU8mhvGTIiziaGgPMwTs0urrRmxVrr9fFsIVff7Pe8oq3mOrYGwmMFIlhxyev8fVGOUwuyhfLLBEHB1hW6MUUkEtWCRixYYwmmHcQRBur/tNayb3i/VWw99zggUlaMWLZtmqris6cc3z+ERZJeDh0+f4vfi3pRIIEYtwyHKWsof5v+F6O1OeuYaMv12lo1K3MfoafSNxHQHzkTMFJ4EbXjb3QmzOm2pF2Ia8aSPvqfJeEjkC1haJ/CEpfRTfBYkqL/H9KprLwqRJtTeb8oJ1er48HutFvgu2RQsyCR4cDBOoKI/dVog5GV3X1HwgQdedzO4U80NnHIguHJISFilbF/pPf1LlAwXRjg9GlBbbiJsSfaWz69OV/bkrnTirt6uZcbZPDCl4ywaG73JDdj1gtzTJpXrLDXpvhMCV5REyNZGsifpXO1PZ8sV65w9WON3fyM7Z096cA574sB6Aw3P7Kw8lZ04rsYzEE+hd3YG6DQPLNr2h/i0z7/BkqA6FpPBArKeUxDiGrShcoyHUSHnTtPgidZw/mqf0e7P0Vpt41n/6gMMvnMd9zw+ngzywQAPNrHOwdx5t+UEWgFkw08fpp4Q9xfFgmnDpfkc0uSrpvtB2Ef49xRAA5QlZesrbOk6ZXVqq9drsofuuudgKiaVCMq7rXVSTRlBYZWpTee39sbgVS9+bXcwPoo8a5J5RiWAXjNOJceP4N
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(6506007)(26005)(31696002)(53546011)(6916009)(2616005)(508600001)(4326008)(186003)(83380400001)(86362001)(54906003)(2906002)(8676002)(8936002)(31686004)(38100700002)(6512007)(5660300002)(316002)(6486002)(66946007)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mDNvrWAIWZnkf6jBDRmeoeeG53E05N//5OHGGXShsm9FZpdxH3HGRy3YZejh?=
 =?us-ascii?Q?FfSUcQzTYTcVY7ibPJdVbOoWuvJAjfUL3U4QlmBMWGilM7ilpGvB+N1Ak5zB?=
 =?us-ascii?Q?GpQZejHSwnmyG2i9Bu7x5A5dITdkFIsK6DfbkQzm0V7Mm7ffnmScBOGO/8Q1?=
 =?us-ascii?Q?8YX1Oz1yZegh0L2mJjj6tV7lspUxvdszRZFfEI5KBIEbocwQXqdPJJXRN71b?=
 =?us-ascii?Q?AVHQwCR6apGNPJpb80XT6XPec7ilIj1aq8Kehr9F3uaW2MJ2EwwK/lZcLD6F?=
 =?us-ascii?Q?zclsNALCzp7oQ0fwJyJcm+2LlB11RXFkYCO4Itedmw+kJUYFOxBgzovFUPIZ?=
 =?us-ascii?Q?0lVai7782KBXIUGxMy0q45hooVCdF8lsvV/RGd5c/ngFDN4bL0T2MIWZYUn/?=
 =?us-ascii?Q?XHi/xkJA7o0U3XueO3wsFRskOll6h2whhI/hxQJrxbpg4q9Ug+Ma2pKmf/de?=
 =?us-ascii?Q?fIW1ynNsyVTgoxpnsRMf5jV/Tk1iSSr/rWivGjc9NFiYY+EW7k+cm4GoY8fw?=
 =?us-ascii?Q?XLzQFsKxgOu4R2WbPN1MEQzKaaPEUmrucum+HC6F6YW5WhbX2vD8YuLo+udD?=
 =?us-ascii?Q?eIlbLXeJKANl1X8Fn88ZKupB9jpgABJK0ozetHqIFkxHsj7j2lhCygBqUCPS?=
 =?us-ascii?Q?smrx5Gtpn0kJSz2+Tjmw8X2AI73PQlvfOCKMljZsgy6jktIkFi/3awqDElBV?=
 =?us-ascii?Q?XZ8GYnXJ7LL9K5I2KmhK7dbM5qb0OntkS8lUfKnZQGdK1TiPvD5/22RlCTS+?=
 =?us-ascii?Q?znfLzfXrraSZakOrJk2BOzSIwqOxK722J3egMPqbZsNknEwtesBUlwDiSFwB?=
 =?us-ascii?Q?wr/pzF9qGQpRzJnd/4gYDK1NhqfqUM3Crm1HYDN4QINvvUTyHstJoXgxNfis?=
 =?us-ascii?Q?q8VkJmjJUjiJA7ETNZPhjP9sJNWsLw7Mi7dq+cHkJYZYwcFIdwexALdJdAQy?=
 =?us-ascii?Q?qiUTCrDFohOF0/Yhq4Jtki2CGOJYCxca+qv6bCtwlCoLoLkG9IBHiCmUJ4uq?=
 =?us-ascii?Q?0Did5bxCxrJ/ARM6bc9P3xV3MfgYmoag/xXQWEYkmlUstToflLUC2PzMq2sQ?=
 =?us-ascii?Q?B6PV0tcKT11j7qH6uxiDQOseCNLm9Ovrcm5dutiSD4c0oNPodOH5wl3bEe40?=
 =?us-ascii?Q?dlMA+aVyl8SsAa1KhKICgC0cMzHxujXo4QzL4injE/BRAYXuHezgNdq0SYnX?=
 =?us-ascii?Q?CzWhv16R8pm3t2O08kkpooD4zFrRmby5kXc/jv6gTqBsSYHhzDvnjjjk0072?=
 =?us-ascii?Q?i8Pz7Uco3p2syy2PY1TZyxsh+c5kcvxX4hok0MH3xskryu9GsdtJ28rXYdzF?=
 =?us-ascii?Q?PppQ59ItiKcr1aUffznY66NUZvr9eFqj8TODT8kRzlNPZwjDBWkVVRLN1ATK?=
 =?us-ascii?Q?YfFa0cfjCC2X0sIiYwi8q7csIvXSmMc1n+L0dyv5tzhd0/PlEC3qY3tDtOmX?=
 =?us-ascii?Q?Zok+LFiXkCHARBff1gIvWnLV/Om1IFWPpD2DCMzA6hInenLLIS8LA5v9yVnT?=
 =?us-ascii?Q?D0qR9WuxgLlxGPMQY7qdCJTWhRzdRSEddEbmR1RBFmy16cB4gU3I8UoeFwDY?=
 =?us-ascii?Q?kb6s+cp0YcJhLaSdAl9cdpGnasSXLytiNJK+6KI/2xteznCC31r5VjsbBWrM?=
 =?us-ascii?Q?+4XJhqyyxA9qaPEoeJAs5HI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd08999a-af0a-4923-9979-08d9bee24be2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 09:15:39.5693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QCEwaWui8NFE8uA296gbC62i8GLTRxxfWrdvLxJf/eS0o+scRRnw3t3jFxlud8ltHFq9cdL2ZsKmAtXal3ZHaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3773

On 13.12.2021 16:51, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>> Page table are used for two purposes after allocation: They either start
>> out all empty, or they get filled to replace a superpage. Subsequently,
>> to replace all empty or fully contiguous page tables, contiguous sub-
>> regions will be recorded within individual page tables. Install the
>> initial set of markers immediately after allocation. Make sure to retain
>> these markers when further populating a page table in preparation for it
>> to replace a superpage.
>>
>> The markers are simply 4-bit fields holding the order value of
>> contiguous entries. To demonstrate this, if a page table had just 16
>> entries, this would be the initial (fully contiguous) set of markers:
>>
>> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
>> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
>>
>> "Contiguous" here means not only present entries with successively
>> increasing MFNs, each one suitably aligned for its slot, but also a
>> respective number of all non-present entries.
>=20
> I'm afraid I'm slightly lost with all this, please bear with me. Is
> this just a performance improvement when doing super-page
> replacements, or there's more to it?

What I wanted to strictly avoid is to have to scan entire pages for
contiguity (i.e. on average touching half a page), like e.g.
map_pages_to_xen() and modify_xen_mappings() do. Hence I tried to
find a scheme where for any individual update only a predictably
very limited number of entries need inspecting (some of these then
of course also need updating).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:17:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246461.425041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3wR-00032g-Bj; Tue, 14 Dec 2021 09:17:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246461.425041; Tue, 14 Dec 2021 09:17:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx3wR-00032Z-8k; Tue, 14 Dec 2021 09:17:47 +0000
Received: by outflank-mailman (input) for mailman id 246461;
 Tue, 14 Dec 2021 09:17:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=COgj=Q7=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mx3wP-00032J-Pe
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:17:45 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id b17bfb4d-5cbe-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:17:43 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8B19D6E;
 Tue, 14 Dec 2021 01:17:42 -0800 (PST)
Received: from [10.57.7.67] (unknown [10.57.7.67])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A38C3F5A1;
 Tue, 14 Dec 2021 01:17:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b17bfb4d-5cbe-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
Date: Tue, 14 Dec 2021 10:17:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien, Jan

On 08.12.2021 10:55, Julien Grall wrote:
> Hi,
> 
> On 08/12/2021 07:20, Jan Beulich wrote:
>> On 07.12.2021 20:11, Julien Grall wrote:
>>>
>>>
>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>> Hi Julien,
>>>
>>> Hi,
>>>
>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>
>>>> I will change to "from AArch32 state".
>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>> architectural register held before any AArch32 execution.
>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>
>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>
>>>> Ok.
>>>>>>
>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>> needs to be fixed.
>>>>>
>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>
>>>> I would say:
>>>> "
>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>> if the command passed as the first argument was clobbered,
>>>> "
>>>>>>
>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>
>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>> when not passed.
>>>>>
>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>
>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>> So basically in all the places where entry is called with hyp=1.
>>>> When taking the current patch and removing default value for compat you will get:
>>>> ```
>>>> entry.S:254: Error: ".endif" without ".if"
>>>> entry.S:258: Error: symbol `.if' is already defined
>>>> entry.S:258: Error: ".endif" without ".if"
>>>> entry.S:262: Error: symbol `.if' is already defined
>>>> entry.S:262: Error: ".endif" without ".if"
>>>> entry.S:266: Error: symbol `.if' is already defined
>>>> entry.S:266: Error: ".endif" without ".if"
>>>> entry.S:278: Error: symbol `.if' is already defined
>>>> entry.S:278: Error: ".endif" without ".if"
>>>> entry.S:292: Error: symbol `.if' is already defined
>>>> entry.S:292: Error: ".endif" without ".if"
>>>> entry.S:317: Error: symbol `.if' is already defined
>>>> entry.S:317: Error: ".endif" without ".if"
>>>> ```
>>>
>>> Thanks for input. I am concerned with your suggested approach (or using
>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>> properly specify compat when hyp=0. The risk here is we may generate the
>>> wrong entry.
>>>
>>> compat should need to be specified when hyp=1 as we will always run in
>>> aarch64 mode. So could we protect this code with hyp=0?
>>
>> Since my suggestion was only to avoid the need for specifying a default
>> for the parameter (which you didn't seem to be happy about), it would
>> then merely extend to
>>
>> .if !0\hyp && 0\compat
> Isn't it effectively the same as setting a default value?
> 
> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
> 
> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
> 
So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
> Cheers,
> 
>>
>> or something along those lines.
>>
>> Jan
>>
> 
So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
stp wzr, wzr, [sp #8 * 0]
stp wzr, wzr, [sp #8 * 1]
...

FWIK this would store 0 in the upper addresses. Am I correct?

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:27:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:27:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246467.425053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx460-0004e8-9x; Tue, 14 Dec 2021 09:27:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246467.425053; Tue, 14 Dec 2021 09:27:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx460-0004e1-6o; Tue, 14 Dec 2021 09:27:40 +0000
Received: by outflank-mailman (input) for mailman id 246467;
 Tue, 14 Dec 2021 09:27:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx45y-0004dv-5B
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:27:38 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 376ba4f2-5cbf-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:21:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 376ba4f2-5cbf-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639474055;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Gtfejlvab6fjNI/gB+ZAfl1jj6TGr1w0pix2oxBBehw=;
  b=HMyF6+Wqz9+nZISuTTMh8r8GL5dg7GJ6LS/sNdcdGUMgfdCYHhmOQMkO
   l/kpmj9yqr3yNyV5ui6VJL1h/Db/cxpxlhmyJpU9ajvQOUoespAEL9RmY
   KEeVaZ/RyHrG7YUhO39N369st4FX5jp1lybO3WzIMtQCtwgeS1f4Qv8Mv
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: r7A02iWP1wC0PPOTQJ4K91h43xQhKfVaRRm/bYCjyy2hLqqRsz0aqlPBF5DXWqfyVcf0ONoqhV
 QbuSMqXWRmocFOlQesyNtmFpL1HGz4wWZA5+v7PD9I0pXeyT1SdTg3Rl+lqUuMoavgxQ5+4ewY
 DOikqDLNbJ7MztfQX2PqQtG+2t85fWLyItl2VNLV5IhsIj1G7daGF/HEEl6aiD0WoxBPOk1PLb
 96VC1PLDWGHz0xUOu2cUrKwW4SNtu1Reft4qDVFLDQstDIGlxhU9i4uUqXKzDDLJdNDHmDsEos
 WgbpxcML7bliyEeAU42uXCif
X-SBRS: 5.1
X-MesageID: 60357996
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Qyi6DaItPDZEIy2YFE+RsZMlxSXFcZb7ZxGr2PjKsXjdYENS1jAAm
 GYWDT+Fa6yIazDwedwiPIXg9k5SsMPWyIVrG1ZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg6x7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2usO5vl
 fEKmaWzZjsQNKTFp+ItcyVXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2UvYQFg2Zh2KiiG97cY
 401TR01dyjFTD0XH35GLbQ4mOeR0yyXnzpw9wvO+PtfD3Lo5BJ21L/hId/EYOuATM9enlubj
 m/e9mG/CRYfXPSE0iaM+H+ogu7JnAv4VZgUGbn+8eRl6HWpz2wODFstVF20odGwkEv4UNVaQ
 2Qe9zAyt6E0+AquR8PkQhyjiHeeu1gXXN84O+8n7ACAzILE7gDfAXILJhZRZdpjuMIoSDgC0
 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESofIHIGZCQEZRAY+NSlq4Y25jrMQ8hiFuipj9TzMTD23
 z2O6iM5gt07lccW042r8FaBhCijzqUlVSZsuF+RBDj8qFokOsj1PORE9GQ3895nA7iHE33Gk
 EEHtPSn5ukHMpe9tBCCFbBl8K6S296JNzjVgFhKFpYn9iiw93PLQb288A2SN28ybJ9aJGaBj
 Fv7/FoIucQNZCfCgbpfOtrpU6wXIb7c+cMJvxw+Rv5HedBPeQCO50mCjmbAjjm2wCDAfUzSU
 Kp3kPpA715GWcyLLxLsHo/xNIPHIAhkmgs/orihkHyaPUK2PiL9dFv8GALmghoFxK2Fuh7J1
 N1UKtGHzR5SOMWnPHKGrdRKdQ1UcilrbXwTlyCxXrTcSuaBMDt+Y8I9PJt7I9A190irvrmgE
 o6Btr9wlwOk2CyvxfSiYXF/crL/NauTXlpgVRHAyW2AgiB5Ca72tf93X8JuIdEPqb07pdYpH
 qJtU5jRXZxypsHvpm11gW/V99c5KnxGRGumYkKYXdTIV8I6GlGSpIa7JlCHGetnJnPfiPbSa
 oaIj2vzaZECWx5jHIDRbveuxEm2pn8ThKR5WE6gHzWZUB+EHFFCJ3Ojg/kpDdsLLBmflDKW2
 xzPWUUTpPXXop9z+97M3PjWo4CsGup4P0xbA2iEsurmaXiEpjKukd1aTeKFXTHBT2eoqq+sU
 vpYkqPnO/odkVcU74clS+R3zbgz7sfErqNBylg2B23CalmmU+syInSP0cRVmLdKw7tV5Vm/V
 k6Vo4EIMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBwLbReWiSFbIL9kC68fw
 L8s6JwM9giyqhs2KdLa3CpawHuBcy4bWKI9u5BEXIKy0lg3yktPaID3AzPt5M3dcM1FN0QnL
 2PGhKfGgLgAlEPOf2BqSCrI1OtZw58PpApL3BkJIFHQwojJgfo+3Rtw9zUrT1sKkkUbgrwrY
 mU7ZVdoIaiu/itzgJkRVm+hLAhNGRmF9xGj0FAOjmDYExGlW2GlwLfR4gpREJT1K15hQwU=
IronPort-HdrOrdr: A9a23:OaUj3qEK54VZCsU1pLqFeZHXdLJyesId70hD6qkvc3Jom52j+P
 xGws526faVslYssHFJo6HnBEClewKgyXcT2/hsAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtdD4b7LfChHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH
 LKjfA32QZINE5nI/hSQRI+Lpz+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+qemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lsdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNzN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wqJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tABKnhkjizytSKeGXLzEO9k/seDlHhiXV6UkZoJlB9Tpa+CRF9U1ws67USPF/lq
 352+pT5fdzp/QtHNBA7dE6ML2K41z2MGHx2V2pUCHa/YE8SjnwQs3Mkf8IDN/DQu1+8HJ1ou
 WZbG9l
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="60357996"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=byuhe0ScOb/xX16u8PJ0fIkk/wBkbm+P/lJVcbz4J2+kTl25uZPtcaNMjI4LuLqiGA7vSqJ5OdsRakHBh14QoMeN5HHZn3f962n+vwIjVx/TlM6CdaNOek6Ajcif60INLXkS9cAWRGoHsPM2F3YrzAmDz0xnP0AwUER6KFQ4YkQhP6pJglLoHxUVKP7qAZZdYKmD4sZN52+g1ood2Wa4zUBkb9c97B/aXfi2BsUnW8kAsKM8/VDkqJYx+ZVTXS954K1LVLfJ50y4T8hdeh+Nz4jC+cpYC11UaNdbWLWg5/DY09hxnzJIlhS23SxKa+2FYZ2paEJ48VBETn6I9myO1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EbgA2lJ5pJeptvlrLlwZHmNEZyQEIJL1N2gNhGXwc4A=;
 b=EYOhZ314dLfzgXdL5i6JJkFjagdAYO0kmN2wy4j41ZKPNDon08qhx9V6vahu8kxnQvk2uRaV+WThjMe+hGzBGaz/N5rZQSsP0gfsTRV703EgsUXEcZdSuI7D5JpV9T2ZuhgRcji4z/5uEY7HgRY3mgRsHRelurNPsixuZk5TxIMnPEHu9UxEhK5RcHMffIPtPxN5EhC3LlHVmzPs7OSi4amJUuGnBkWAjN/we0rk1ey5Iop9Za9qN25pdtzz54X22+B48i0cjSxAZajTFDre25Jl1Yy3c7IFBqa77cO5ZRHudcItRBCN9QDvuUKN7+/iiFXxnel64YOAvPMuQQLY2Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=EbgA2lJ5pJeptvlrLlwZHmNEZyQEIJL1N2gNhGXwc4A=;
 b=vYf0/2/CvRqKUelxtFFsQYRtM8u73ITwQcgTHv13lnjN9O2L6u/EwInPA5qALmtB452keeQsNVBGWjMlaCUwAGoB22q4VSr5SDmsShBsMsVKpDu9Uq2of3Mb/0ps5dXNeoBcKIr4uDQ+bmwoRw/wbEIK7IF9KBphEtMLHvTrzvM=
Date: Tue, 14 Dec 2021 10:27:18 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>, Rahul Singh
	<Rahul.Singh@arm.com>
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Message-ID: <YbhjdjeHkFtt+e5h@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
 <Ybdg6/J6oUf/5hEH@Air-de-Roger>
 <612dc962-229c-f43e-abb3-fd460c1412b0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <612dc962-229c-f43e-abb3-fd460c1412b0@suse.com>
X-ClientProxiedBy: MR1P264CA0084.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::7) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b246fbf-ef37-46f2-c141-08d9bee3f345
X-MS-TrafficTypeDiagnostic: DM6PR03MB3673:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB36735355B74A8A71F8EDC04E8F759@DM6PR03MB3673.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lKjs3FL67G81FMUDaBVS3kQwD7klOC96a1uGb29XyLsiLs52w0yRfY+aVAVF32IWC886Rn2gcabfUR07yw23XPbVl73cT0w2FXsKF1LOnSR68v7dPuCyqd+B6SVikCTZmmYcB12rbHmZGKgAkxMNJgC3VG6gJ8zEIpLYueagxC7IHm8wc72T8KJRt1jvAAFlfksq1F3xsxk68ZzjBxrjrcF85aWe6Cwi5AgD5vsVRavZk100uWMX6NtEdAMuAxGGR0xhCYeavn+tUDr4GtJwWCs4DGGhEs9hhaBuVFrchMx4sSA/I67p2VOGMe2QHIBTAVYjWNxnyzWxhiCw2TS6kcOsjiiLadAibexFPTfxovFXSTqsrc4KLOUAVpB1xtTpRIRw2Nn/0xW9tMrLFoP3PBGoIyHR5L95++lUOV8fE/93zFheIo0Ba/SgUv6QgWTqbEZ3X+e4GL47Svuw5hp+CdCW/1r687++qJXsgio0xhEhDa++0C/4iyH5heoBLcydfVDpTJzg3ZNkrJGVBLQ8LOZD4+sKjEkH+yPww/po/BfygSEZ4lDvM1WIKLPLYHMXqznJAaR/nHVzN7PaYcJ+c69PpWg94/cq2+/dJ4GQJgW9prXod0Dbw8AOZogtAOL9yi7ncHho2jmNNGed+nZup3fPNS/+HC9+4QH+gIOWZHuqwF6rkCDz9FrjVDhuCnkelROa6x6UBQ7GmlA9B/uijQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6486002)(8936002)(26005)(4326008)(86362001)(6506007)(85182001)(53546011)(5660300002)(8676002)(186003)(9686003)(6512007)(316002)(6666004)(66556008)(6916009)(508600001)(33716001)(54906003)(66476007)(82960400001)(2906002)(38100700002)(66946007)(83380400001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THhQSmg5clRZVWtxTVRGRlZTVVV3VGFZaEZHcDFqenFYYjdvMjl4WXN4ZWtx?=
 =?utf-8?B?VFZQUXBadjI0UEwySHFlODMwODN4ZWRpbytOck9VTHU1Q0NuRkpWZURBaXhI?=
 =?utf-8?B?ZmwreEJ2RGoxK0dxc29LbVhKQURTRjFlVHdJcWFrWjBCS0FlY3FOZUtVNTds?=
 =?utf-8?B?cndGWkJ1OWJlRmFFNU0zOVRpYjlEVUhyUzhaSGd1WVlHVmJFYTNSejA0Z283?=
 =?utf-8?B?aStoS0IzZWRBWHJnc25rc2NVeHk0ejNrNS8wNDJ1YXVNU3FidE1VbDRJSStX?=
 =?utf-8?B?OVhGTzNhZllZNklDUy9sYnduMlJncWFoQXYxR3JTZ21nMkc5RTRtK3lnTFBk?=
 =?utf-8?B?Wlo3MVFhUS9BNSs4M011WGF3ZFdXenRiekhRU09kZ25IM3ArNG5ZVFdSMUtl?=
 =?utf-8?B?UmxheXVBRU1DcU1JaWxZc0VSVlhYNkJDdFhMSEREL3VSMENGMW56ejJBTndX?=
 =?utf-8?B?dkRJWWtDYktXcGhmbFhyM0NFdnVvekJuL1BENHFmTWtwQnhvdUJFWFI2NE9o?=
 =?utf-8?B?a3E2bGxEMHp4ZENXQ0pGdDd3NXgxQ1RaSkoxYXhBUUE2dUljUm51dnhOVjRl?=
 =?utf-8?B?RTh5Q1Z6UFM5SVpoYmV5L3JOcFhqM29nOVJpVFJNOWVEQ3JPVjVkUmRhR0ln?=
 =?utf-8?B?OG9XczZaQXpFOExqbzFuUHZPNFBiSFoydXdIRGkyS2tHLytIVFdHclE5UE5Z?=
 =?utf-8?B?eUtOQkpSQTN3bVEyOE9QQkgzUXYwbDlHb3htRWo1RU9ZbkRQNDlVandDTDJa?=
 =?utf-8?B?UzVGV2IrelMzRVQrWi8yS0NjNWVDQzc3VDA0R013bFFQalVWV0RMMFQ3QldW?=
 =?utf-8?B?QXhET3JNMVptaEtFWjNKZGRpZUtuQWhiTzcvUDhQczBQbm1vVlJrTGtFM1B2?=
 =?utf-8?B?ckFlY0grTTBTL2tjWnozVG5hVWE2T1hGYkZSN3lOMytNUDVKV01LUlZ5aTUv?=
 =?utf-8?B?anR6N09ON1hITU1Cd3VBVjE3dU0yTk5sNDdSNjAwVURiZEhkelpWL1JiVi9S?=
 =?utf-8?B?blBFb1ZGUklkZ3hCcHFNUjhpSTR0RjBScERVWHJINHMvcVE4c0pqVElDYVpm?=
 =?utf-8?B?WnhRZ0JXNW5wRWxmczI3RXgwSzN0U2g4dDFHSVFZKzY5VEFnWFdjejJGSzNM?=
 =?utf-8?B?QkZqSGt4WGVVY1FGZ0tqWFZZVWhPTWUwM2VPcTZNNWl2ZlJaYzVJMWtOU2lj?=
 =?utf-8?B?Zld6OGNXV09SNU8xTGluN0RBcEEyUUt3aHRCNC9aUmFZa2c2VXBPMTFEelhC?=
 =?utf-8?B?TDcyK1h5NTZPWHp0MnZaamNxb3d5NUFhZE1PY3gxTkNtYS9XUUs2akJSNW1D?=
 =?utf-8?B?MzRiY1J1dndBejlsRVA1MkxEUWNQU25MY09jdStUeG9qREhvbjNpZDZqTjFX?=
 =?utf-8?B?WUg0S3Y3WDVNVFVxL2xiZXRrckpzN0R4OFBNZXU4QXh0S2s5QVM4RHVOYVFB?=
 =?utf-8?B?cWgyMDIvZlNhQ0hUbnY2NjV5SllGWFJiMXJSdFl2WkI0SjFaVmV5V1ZnRFIx?=
 =?utf-8?B?Wk5DZGZ1WEhjVG12SW5hWXZqZGhCUFRFV3piTlowVTM1ZEhNUlFSc0ZwMis1?=
 =?utf-8?B?d2JQYStlempSVlR5cGxGNHg1blFwTng3K2FPQUFBeUN6Vk1VSmFvUFh4bEp3?=
 =?utf-8?B?QkZSMis4NzNjSVlsYm1lVG9kTlVjMnVTY3BCMHM5aGRpRTVLOHM5Y0xTb0dM?=
 =?utf-8?B?d1JiWnRGaWZ0cXhFR3hTQjhGRU5xNlM2eVRBRHJ4YW9sL0d1U25MQ3ExUzJo?=
 =?utf-8?B?eXpVeFdsSVhxdUxYUDJIelI0MXFuRDIvZjRwRmFlVHlpNnhlVHpla2p4emdX?=
 =?utf-8?B?STAyUlZrRmhMRmVBK0g1MThQTVoySkp1dlNRNm1rdXZ0eENxU0RsL1cyNm05?=
 =?utf-8?B?WjZTYURETXAyb3NleUV6bmdCOXJGNWdtczU1K0NoRWIrQWhEb1EzcGhwR2FS?=
 =?utf-8?B?MlZJV2dlMk5pRkk2dXV1amJXVEtjWXZld2VaYUd1dkc0YmtGbG5pNDc5M21v?=
 =?utf-8?B?S3pMa28zU1YvYXRwYVBTRUtDdnRtYnNoekdkSHFDNEF6MHNYbGhTSWplSk5J?=
 =?utf-8?B?aVg5TDlLUWdJWFI3ck1tSW5HWFZuenZxQTBPakJyNFRLMTRtWmgzQngrS3JO?=
 =?utf-8?B?eEg1b3BPYk81Q0tFa01YaFdvbXROTzA4SFVXdThYNlA2emE2TUIzTTFiVFlV?=
 =?utf-8?Q?U7ckMUmGpX1cSq6iJ/jd55Q=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b246fbf-ef37-46f2-c141-08d9bee3f345
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 09:27:30.0194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d/iS7ATYDeAaSbgd6TnfV3jQ0OJFoUPUIjiFznuz2+dlW02CB8ug0S/wYptbRjfR6YAqGLZNda4zAX66kk6m4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 10:06:37AM +0100, Jan Beulich wrote:
> On 13.12.2021 16:04, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:53:59AM +0200, Jan Beulich wrote:
> >> Having a separate flush-all hook has always been puzzling me some. We
> >> will want to be able to force a full flush via accumulated flush flags
> >> from the map/unmap functions. Introduce a respective new flag and fold
> >> all flush handling to use the single remaining hook.
> >>
> >> Note that because of the respective comments in SMMU and IPMMU-VMSA
> >> code, I've folded the two prior hook functions into one. For SMMU-v3,
> >> which lacks a comment towards incapable hardware, I've left both
> >> functions in place on the assumption that selective and full flushes
> >> will eventually want separating.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

> >> --- a/xen/drivers/passthrough/vtd/iommu.c
> >> +++ b/xen/drivers/passthrough/vtd/iommu.c
> >> @@ -731,18 +731,21 @@ static int __must_check iommu_flush_iotl
> >>                                                  unsigned long page_count,
> >>                                                  unsigned int flush_flags)
> >>  {
> >> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> >> -    ASSERT(flush_flags);
> >> +    if ( flush_flags & IOMMU_FLUSHF_all )
> >> +    {
> >> +        dfn = INVALID_DFN;
> >> +        page_count = 0;
> > 
> > Don't we expect callers to already pass an invalid dfn and a 0 page
> > count when doing a full flush?
> 
> I didn't want to introduce such a requirement. The two arguments should
> imo be don't-cares with IOMMU_FLUSHF_all, such that callers handing on
> (or accumulating) flags don't need to apply extra care.
> 
> > In the equivalent AMD code you didn't set those for the FLUSHF_all
> > case.
> 
> There's no similar dependency there in AMD code. For VT-d,
> iommu_flush_iotlb() needs at least one of the two set this way to
> actually do a full-address-space flush. (Which, as an aside, I've
> recently learned is supposedly wrong when cap_isoch() returns true. But
> that's an orthogonal issue, albeit it may be possible to deal with at
> the same time as, down the road, limiting the too aggressive flushing
> done by subsequent patches using this new flag.)

I see. AMD flush helper gets the flags as a parameter (because
the flush all function is a wrapper around the flush pages one), so
there's no need to signal a full flush using the other parameters.

> I could be talked into setting just page_count to zero here.

No, I think it's fine.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:29:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:29:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246473.425064 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx47d-0005NX-Lt; Tue, 14 Dec 2021 09:29:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246473.425064; Tue, 14 Dec 2021 09:29:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx47d-0005NQ-I3; Tue, 14 Dec 2021 09:29:21 +0000
Received: by outflank-mailman (input) for mailman id 246473;
 Tue, 14 Dec 2021 09:29:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx47b-0005NF-CL
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:29:19 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e1be04a-5cc0-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:29:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e1be04a-5cc0-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639474157;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=W8Ompw5YQI2LpVIzSI8Qr3AaasH0F6+6KuonVK3reuA=;
  b=HpcyGkoQiKUfe5b6JKXpT93bO3zBaB9AQcYD7yRDoo9m1zKUiCDglE6u
   od3U/jXmbGA0/jbTg7+6z2/JIYBMjKNgll2DIu4EAwhQ8OdG5OFEK7gjy
   uEMSKZPe7oTHwxBureRqHhKXqHPHGlh2drENkCgVMvrQkzCBgx+xCa6tp
   U=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 2LlqvlCY5w5qpHElsxJGOkpAjcwZg35e+Tpz3x5O2F4YoFwBe1FagfGLTA9VuHonS/1XLwxQ6J
 jVlwtfCLKsaujDH7TMG4KTsiecvMn4oEWlQ5T5c68vFa4z1suJQGoTFgL2kKsz5uSO0lOGHE2Q
 +sFu5rP9sADoCsC29iz56T5nHB6TnsMe0HySfc0YOVwdNBaLcPRxScb3UNU3SZSFvRxzxgP4XC
 Cc+Lpbgs2h/Wt82kDLsH6vYZN1oJsxCBoiNEK0ep0vZThjF23y5FAmj/d1hYkdq7Ch+9ltrVO2
 sgK0Vr0l+IZeoqF5w3chdJy7
X-SBRS: 5.1
X-MesageID: 60358071
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CN7NU6wfhGoNeiJbPO16t+fowSrEfRIJ4+MujC+fZmUNrF6WrkVSx
 zMcWmGPMquPNmDxKt4gOozl8UtTucDWzNFqQFM/ryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbdl2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+1xx
 8V9rcTvdT0oHraVofUGXDUJKAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEAh2pg3p8XdRrYT
 8YzRWp3SDHMWQZSA15OKbY5xtyHmXaqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19jkue4
 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJW6/PN3hFyYxkQIFQYbE1C8pJGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQnX6Lri4EA4VsKewa81i027Hbz1eiLz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpkuXFo4LLUKjsjHi9dgcK
 RiupTN2ubgchNVjO06TrQGe2GLESnQko2cICuTrsoCNslMRiG2NPdXABb3nARBodtnxor6p5
 idspiRmxLpSZaxhbQTUKAn3IJmn5uyeLBrXikN1Ep8q+lyFoiD4LNwKuWkjehg4Yq7onAMFh
 meJ5mu9A7cJYxOXgVJfOdrtW6zGM4C+fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1
 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ6nkgWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z
 uuzwOPWkUgCC7OnPXGMmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl
 kxRkGcBoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E
 KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8
 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1
 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO
 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU
 UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux
 v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
IronPort-HdrOrdr: A9a23:VOx1NassZovqjRa7NznfOifO7skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="60358071"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gQJVrMZZi46j1zQ43hC4fJvYwJqdwmECh96tLH2U3flSUr4QvMimOo75ciNGY8Ev1xLWvfExVycJRrcUsjmHWfXI/Q6felskPdvKsM6ch3VNQZxwvrptRccMdJed0VK9ALMHRhTivJufJvLXwK9rtsqFXgDsJbcSV+MupmKyNGeqZ2lJJmvmF+UZdM5JRCRmLf9ErmoDF1I72aCiuFlxgdrV7hMwRW+RzsguuO1ftlnLw534z0bgNzLjT/D1P23ah+PzE1LAd3v8jhPbTPNCQg/3QyVoexYIi/+oHlcqb6el74IDRFW7kcPHCJqQHpTzHzeZfdg6igR+MXUNWFiC9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FgXEJ/muvv6MRCqI5WLbvWNUsIw2pTZ5Sa76qgTjs3g=;
 b=ObWGhcTUGBFi3knUE+6cr3GvMB5DD0Y0epIWuevSK1jLSFA98og8gV39SfHygszxoD0NOBezpqSBTdpmZIxdEDdJMbjU5L0rMgauaR2HZQPI2FgDGPaiVBuxyq0Wld+axwwtDIVtJBhfS7tuLgYMRUeHR4RTJdGF+Yu6CedocGrkBOgIcR0KQrEbF0JlXlYktYIfcWsKvG2sprgk1eB1u2RLvMg1dsh/ywHgN8+Iezth2we6ACuXvCSmLME65kM8nNrXwwbUnMKDnNgxbMcKkMssEBCPSjBAgVA3olrSySZHuFSvKV8iiEJVUFJ66IySqVObhWCTIn7y2rN4plhInQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FgXEJ/muvv6MRCqI5WLbvWNUsIw2pTZ5Sa76qgTjs3g=;
 b=TFZBzXsj6oM86AvNJ3AM9V787IZsN8WYU1HBxAR6+IPwjE5NqQQehSloiWo600GnF2l1C81v12JWk5cec+qUXhNMPQey0WJX5d1bMSz+YBV92qJ1FlS/f8jL0LHEjTjvS7Ho1owILikAP/0Mm+VkFK7mcwJlPtR72aEjI/Yl400=
Date: Tue, 14 Dec 2021 10:29:05 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5] x86/PVH: permit more physdevop-s to be used by Dom0
Message-ID: <Ybhj4dlwnblDRqfD@Air-de-Roger>
References: <05eeb76d-3aed-f543-f0c0-dcfe4e2bcb6e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <05eeb76d-3aed-f543-f0c0-dcfe4e2bcb6e@suse.com>
X-ClientProxiedBy: MRXP264CA0037.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:14::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ac9ce34b-2b3a-4f88-dc0f-08d9bee43040
X-MS-TrafficTypeDiagnostic: DM6PR03MB3673:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB3673717974C037B2B3762C4F8F759@DM6PR03MB3673.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: s97ZMdsW4usQyX3UI8PMU074xB0KYSLro+jz7qIcmkscL48VnGbgDRTw9lpnl1OMYRhbxdsLq5eVp71b0XRivUUHRnwuikvEY8FcpfP7U9d83vcm21DJZmADpfUeK/Rce//MrQi46bp9lPRdWvM5uYxMZjtEs+qfA2XyneWaTY88st6UIeU7SiJ181kgzw2NgDVA8plk9XLRGPTlv9BUUrswt3IpL/IsRF/5IFJzCzD8uWdQC0PwcG5ImNGJ3bHEze3i/1VCDnIEAIKsyXtFJ+7aqJDylYf6boNoM5WXl72LiTpe6MFf6MC6b6g2PdxoG7D6PrVsCPojT5QYKOpV2c1eiBvboRxPnd4rm9O4b9EWKUBj396DL3u4gTUrcyxgvQJgVhFQqrhLSH/hfTrbFYTVUu5STr+5kBJJv6eUTDWC3N/xNQA7+DUKNwAGrYgSLSiYC9x3aYgucqpoZSw99HeNY5qwREDj03WGrDsn3UWBo5MegP/k3dgdtho8Olqx4jT/KKpa6Roek37Tqu1Zvc3twMIQ1xPGAoiyvewri2tW+xHVXbdRQPMa3eeE8oz64AlnE1aq4Dbr/p2nq529xVJlw6hR7jofMkMGBfbRWalQZihOJXe9Cyvmx1MCbGxUA0iI7tuD0yP2i+DW5CRRmQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(33716001)(508600001)(66476007)(54906003)(6666004)(316002)(66556008)(6916009)(66946007)(83380400001)(82960400001)(2906002)(38100700002)(4326008)(85182001)(6506007)(86362001)(6486002)(8936002)(26005)(186003)(6512007)(9686003)(5660300002)(4744005)(8676002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW83VStpNFFJMkE0Y3R6cHhJbnY0bDFFcmpOUXpqcmlZQUt1L1lDZ2FpU3R3?=
 =?utf-8?B?WHVLVHJmemZKcFQ4bUU0dUlDV1FiVXJ2ZTBzMmJIMjlPd3hhRGFjb2tBWkpU?=
 =?utf-8?B?cjZsMGVhTS9vWHI5M1BwOTRjUllJWnNOKzFaZ2p3UE9qL2xNOVhYMWFJc2NQ?=
 =?utf-8?B?VzdTK3c2eGVhU3pxY2F2S0xXQXlpaDQzOU16ZkdsRWYxcU92QW5WeEFIVU1J?=
 =?utf-8?B?c3VaS1VPK2lqbjQwaHBOSXl5Zk1IZm1PNVpCcHRWSkFIWDVqdjhUTHd4SDFV?=
 =?utf-8?B?NlIrWCtWdjd1MWE2YytRcVJNK0lkbzVlZVMvL1B1c0N1SnFaSWV4MnFMcCt4?=
 =?utf-8?B?cFlGOFJYZjllZkY3WVlHbVIyelRrWkpsNnNWQk8zbVBNazN3cFk3bFpvRHUv?=
 =?utf-8?B?MDFTOFJndWJ6UVk5Y2Y1ZWlzTzlvalNzZis4VkRMWCs4cGJEVDQrT3NNbEJr?=
 =?utf-8?B?T3kzemUvYzQralpHYmR5SUJER0RrTThyUzByMzN6S0RXME8yby9xanplVGk0?=
 =?utf-8?B?cFNFdDZtdFFHTWNrOHpFd0ZwNDE3d0tmdi9iWWorS1BIVCszSStvWjVPb2Yy?=
 =?utf-8?B?UHFscVRlNytzL2w5QjhHRVZCWThMV0kyMEtuMFM4MUp1SkJjQVNaWmxGK2ZN?=
 =?utf-8?B?RFlxQkhGQTFNYjFGZldQNXVITFJLSGR0VXBBKzQvUjVuS3d4UHE5TlVaVW53?=
 =?utf-8?B?Z3BrSVdyT0xreUdqalhCSVhzdGFYckdTc3I4RGlTT0I3dU4yeDJFYjFUNU5W?=
 =?utf-8?B?VnR5VkEzcjh2dHlrZ0x5N3BQUjRNNHpZTE41UHIxcTF2NUZUaE80ejhKWmJ1?=
 =?utf-8?B?NzYzTHdFYmliTjVYVnhKdW1JOVV5am12WUxCdXpTMnNUVHhLTktzQWMyc3RU?=
 =?utf-8?B?ZFl3WnJzZ1ZaMFJ5azJ0Tkt6OG5hMUdpK3NGZGFHVkRsdjZJdU5IQXpOdVBn?=
 =?utf-8?B?MEwwcWZDMWY3aVJUUnkwa3JFdFdMc0JVZDMySzcvUm91V1dUWjkvSC9Vc2JV?=
 =?utf-8?B?cEZaUWx5MVZmb043dHorOXd2TVJzVGNvRFdZRlUyLzM2WUx5bG42THhOeVNK?=
 =?utf-8?B?d0wvS2pndm1PQmZkcTYrZFMxOGFFNFAxY2M1dlFzbVJmcXZJOXA1OEorcE1T?=
 =?utf-8?B?NUlOdS9iaU5tc2pCOGgyUkJiblV5QS9rQlFUa2Q2dHpBQ3ZGN0VDL0dGWHAw?=
 =?utf-8?B?bDJsS1N0ZGhEeDV3bFdtSVRRelhIQVFYdVplWXEzM3lBOHlIbGMrTEV4Q00x?=
 =?utf-8?B?OVpKbk1ReFpiV1lwU0Nva1ZyZnFiYWdtdWJ0OHVRTzU3cS9IZHNMRXVwMFpC?=
 =?utf-8?B?K1dUUUpGQWFuNU0vcGV0SXdiaWtHOFZTYW1JMWdUMTZRdUliNHR3a3RhQnMz?=
 =?utf-8?B?dTR4N2h2N1pRV2VxSitHRFJFQkdKK00vK25EY243QU5IQUZOMXZyNVliVzd2?=
 =?utf-8?B?VUs4STBCSXBhdE96SkR4MnFRU1l2UHNhMGc1ZTIwK3o0cWxEYWViOVhhNGlZ?=
 =?utf-8?B?MHppQmVMQVFvNjcvMnhDc2QwNGpZK0N1VklncUtTRDZsM043VldrNWZhNjU2?=
 =?utf-8?B?c0dQY0UyM0lLalVYa29za0JpRnFnbHd5TGhwSThsRTlrSXNGa01iV2w1RlJv?=
 =?utf-8?B?RC9TRDFINk1xS1JZOGQ5NlFNeXZqRFJQTDhWelRQSGlMWnh0cVNieExJd1VM?=
 =?utf-8?B?a1cwWjFUT241eWZ6eVcxbnBFaWMxWUs0dUZ2SXFqb2dXY1dNTHdLcmhjRFFB?=
 =?utf-8?B?TlZRRlNRdUF1M3RIam93ckZLTVRxTmlvMHdqTU14c0dlc2dTTGN0MEVkQ1Jh?=
 =?utf-8?B?Sks1czhDS0t1YkxlYkdyVndIN3d4amZPR2kvblNVLy9VNW4wWllod0w0V21V?=
 =?utf-8?B?SjM5RGY3WlhLK0VXMnZjckdKOTV3MmU3UWJhK0Rxb2dXb2pPbTFodGx6SnhR?=
 =?utf-8?B?RjF2S1NoZlRONkxLTmxRcnduczBkZXV6UjQ1MnpxVmlmemdFRzFaMmNadUpM?=
 =?utf-8?B?TFA0Tk1NRGZqci9JRktuTzc5YkU0andPYVpqZ0dyZVZyOVJUa2JBOW83Uzc0?=
 =?utf-8?B?WVBFOXVXSTBWcWZmVlljaE5BSDBnbTFSa0VoUXJmQ3B6Q25iVGUrb0IzSjQv?=
 =?utf-8?B?ckpKeGtqVkJ5WXc3alRFNENxMG52V0hXQ1NsZDY5cllNQXlvamhWOFBHVWR1?=
 =?utf-8?Q?Sp0cHhvlL7JxnmkPQcOC7t8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ac9ce34b-2b3a-4f88-dc0f-08d9bee43040
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 09:29:12.2288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i7HHXM2KHPIXfLksdBhalpft0B8mqmnmOTQZA1Bm/yL64hY3wu+FBC1iHh+01/nDXVIVujVPZ1Pv2AnsIKr0wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3673
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 11:28:39AM +0100, Jan Beulich wrote:
> Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
> running in. Permit further PCI related ones (only their modern forms).
> Also include the USB2 debug port operation at this occasion. While
> largely relevant for the latter, drop the has_vpci() part of the
> conditional as redundant with is_hardware_domain(): There's no PVH Dom0
> without vPCI.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246481.425075 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4CC-0006px-BT; Tue, 14 Dec 2021 09:34:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246481.425075; Tue, 14 Dec 2021 09:34:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4CC-0006pq-8J; Tue, 14 Dec 2021 09:34:04 +0000
Received: by outflank-mailman (input) for mailman id 246481;
 Tue, 14 Dec 2021 09:34:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mx4CB-0006pk-1p
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:03 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx4C8-0004Iw-4c; Tue, 14 Dec 2021 09:34:00 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx4C7-0001gX-UW; Tue, 14 Dec 2021 09:34:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=HUg3TZutKppPdPnCm9rZD53RTMlNZz514Vt3W0YSf8M=; b=wNH9jqkwt0wtuGv/D7On03tKPR
	ZHbWyQaGnXSgYTM6zF1ApwvDDhTteXIqIKVVBhXnWuBNIYjzC6B8uEoYlCnIbJ3uR7TcqFS3dB2Bb
	0OTp2iASNyuvC/z8tYkovRyglNB+OeMsfpbTA3CjCq2tu3X2bzYlvO1B4bzxBs2rY2pk=;
Message-ID: <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
Date: Tue, 14 Dec 2021 09:33:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/12/2021 09:17, Michal Orzel wrote:
> Hi Julien, Jan

Hi,

> On 08.12.2021 10:55, Julien Grall wrote:
>> Hi,
>>
>> On 08/12/2021 07:20, Jan Beulich wrote:
>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>
>>>>
>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>> Hi Julien,
>>>>
>>>> Hi,
>>>>
>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>
>>>>> I will change to "from AArch32 state".
>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>> architectural register held before any AArch32 execution.
>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>
>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>
>>>>> Ok.
>>>>>>>
>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>> needs to be fixed.
>>>>>>
>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>
>>>>> I would say:
>>>>> "
>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>> if the command passed as the first argument was clobbered,
>>>>> "
>>>>>>>
>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>
>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>> when not passed.
>>>>>>
>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>
>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>> So basically in all the places where entry is called with hyp=1.
>>>>> When taking the current patch and removing default value for compat you will get:
>>>>> ```
>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>> ```
>>>>
>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>> wrong entry.
>>>>
>>>> compat should need to be specified when hyp=1 as we will always run in
>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>
>>> Since my suggestion was only to avoid the need for specifying a default
>>> for the parameter (which you didn't seem to be happy about), it would
>>> then merely extend to
>>>
>>> .if !0\hyp && 0\compat
>> Isn't it effectively the same as setting a default value?
>>
>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>
>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>
> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?

Yes. This is the only way I could think to avoid making 'compat'optional.

>> Cheers,
>>
>>>
>>> or something along those lines.
>>>
>>> Jan
>>>
>>
> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
> stp wzr, wzr, [sp #8 * 0]
> stp wzr, wzr, [sp #8 * 1]
> ...

I don't think you can use stp here because this would store two 32-bit 
values consecutively. Instead, you would need to use ldr to store one 
32-bit value at the time.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246484.425086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cm-0007NC-La; Tue, 14 Dec 2021 09:34:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246484.425086; Tue, 14 Dec 2021 09:34:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cm-0007N5-HI; Tue, 14 Dec 2021 09:34:40 +0000
Received: by outflank-mailman (input) for mailman id 246484;
 Tue, 14 Dec 2021 09:34:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Ck-0007JG-RD
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:39 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32c13a6e-5cc0-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:28:30 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE943EF004675;
 Tue, 14 Dec 2021 09:34:35 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxraag3uw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:34 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6976.eurprd03.prod.outlook.com (2603:10a6:102:e4::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 09:34:28 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32c13a6e-5cc0-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ioRt2ZPrDGCVT0oIn/POaFjHyH08hqjuqE8K7AQlE9ayLBu4LuBziJZz376LzDE8Jf/ONKzdiMIMZqaUCwPPe3KpaaowHxEyW/TwBmVzfNZECl+gGfxp25p7eUQsMV4DGWMkMOD62Y8o908hjWfBHArknZsY55aTqVxhOWBMOiia74m/3fLaLHpbcShE1MgqddUAPLtoSIPRytg2d4w0NqzWhPZ0HIP1f+UHmOqQZ2gBvz9SM1NUTtGnBsaOKQdicrdZLTQYYbqjDm6j2E1FXf6v87+uYMKJQ7ALvp/Bl7Nt1EljoNaT+KSXdWWMMdeGdG5HbBRaZAezQ2UZTG3nrA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iaUWZPBTg2O+gyl1uMnhO6Ep5oxml8YVCINnTiUgzaw=;
 b=dABaXNHdHUTNEz9oop758mpIX/ug6s88TrCMljKHqgOeyJagwmq0EiZu1okpBIsBQfgKcTB1sA2Ik+Gr2GFJ9ceB/fEXdB9ubPorsIZs78hpEhbvLkd1EF+fAXtZIws6NrN/Q5Ls1BlLyCjA6i8GJ1mAqRcB+WEEv6W+5nTfiJFoUms30IRkCXWtmAtitbuEVyNkvLIs6qzvfIf2dj0a/ugoH61MK/SENrwEcgHWStQI8PDSfSmrHRm4jClLvneyzEBimSWUPUK2IqM3UDNo4dcPkheRn86WdhvCihBKxLXfnCC0Z+toDrvAS8iZCJ2QZ49piq8PBXTKpqHap4K1Mg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=iaUWZPBTg2O+gyl1uMnhO6Ep5oxml8YVCINnTiUgzaw=;
 b=ADKHM96IC1fMqOM8lI/kVaRaXO7mlw5mSQfwMwdLQtvh86W/0dz3lasrfW6+lev+irLXGpGZIupnJUS+AsfS+WZGO1GDUBn0qV5hrvVaW07w/Fu1mWYWH8adH5t2WV2NE/XR73QlwjaDvPdJ2BkVyx/wnrc8Po1EKT8/tZTw39hEbyWF0H7lpmGOLgqNAidTua2zBg3ZiX0+8bG0vl8Hj20KDra/IUlWZpEFslP0Mao3PZsM8jH3gqfnXzEu3fXUwVFMAfbYsYfW9KSL4+TgCsjssQevvFbXBstA4+Fkui8POhRkEn55+Jkru9exjYR0h8/Z+1lSDEkHAaV33VvGZg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, Wei Liu <wl@xen.org>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross <jgross@suse.com>
Subject: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owg==
Date: Tue, 14 Dec 2021 09:34:28 +0000
Message-ID: 
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0f4502bb-2d5e-491a-a663-08d9bee4ed06
x-ms-traffictypediagnostic: PA4PR03MB6976:EE_
x-microsoft-antispam-prvs: 
 <PA4PR03MB69764BCDE36592A8CE2714D3E3759@PA4PR03MB6976.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 cIalWWULnWtDp2xml+AbZba8QPmRDeawiRzkuWRg1Ii115PWr3Cl85ZpuGwHFOOhslcqfAEupzuUG0WxWeOEzth2mmV0jo7jnBUtStORjVIGsMBly7bluZAZr7/6re0i02f5qpBxyHyug79rUAsaSDZHtnj7M3r8/jt0Nm2s8njNe1FhliMnahTD84mM4S+/MUqO/C2yUhxboTDg7xHg67CHixsjRybEEq25sp0vpzDOeyvKeI4Aw21aD6SjXBWrk/G1fLy6IzNh38rQYa1xMV+HIGNIcBNI41s9WY7bAMK5m7lhxKo3IlthLExLrLVuZR6NqA2JHP5JvAHoZzcbq7u643FwGsxqdikk1MnW2+2pFgzYBt78snO6IpoL1l/najT2esrg1aCQQaSeNSdSWPiEP3rYt98QXmWYMeDXK5JlA99yhgHdjyw2z+YCwQrBZjxx+PX9B+DJ7vsG9Hms6g19h9/Xnd0CpxXthTr5fn/19IoWqOg8zQOmHPpjWa5k0DtupRat3gbplqPm9Idw98CoKBmWIFIxB9AkyaizHH2+Y4Ieete6sIO/AwwnUzpN4eKk/9qwyq7WEbkh1kR88RcVjMB3H7vwFJiNH600BIIlC7NFax9Vd7T5OE6aSyntF/k7LMWpvGKAk2xrqonSu71L7AIWEUbiGswTCqJCMM1KBkt+ORgFJ8pXzAfx+nCxT8N6Hnep942uVTreprZ2fw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(64756008)(66556008)(66946007)(26005)(66446008)(76116006)(5660300002)(91956017)(508600001)(86362001)(83380400001)(186003)(6916009)(4326008)(2906002)(6486002)(38070700005)(8936002)(2616005)(36756003)(71200400001)(8676002)(38100700002)(122000001)(6512007)(6506007)(316002)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?eOxrMUCJPjffCraXnBT9TP1oAwa0JFYeXrCeaC+qkGIWuQrmsGKeQ1b7hT?=
 =?iso-8859-1?Q?6M1cJxCIFh//+WnE9T4oQBKLg+lyrDhNepW8KMugwFRtbQ0Mi/kr//ND/X?=
 =?iso-8859-1?Q?+zHvEEMehTXdXwPwCOTstxpI/7/Skd0C4wZIyxlfoE6vrP7/be1WpGn3OI?=
 =?iso-8859-1?Q?ngog3jnBONmPtW4vCDBHrkdDhRsw3lT0Zjz9i6I1Pv8Ti8knmQ88JOy43B?=
 =?iso-8859-1?Q?cHJBBBxXHGU1cpGNBWEmxkDQ7mVCv3XZ7DowVEdyrRwisp+4gitkdFuW3v?=
 =?iso-8859-1?Q?I74HSaz5mk1D0UNgZ1OgX78PjHv3SYyfj52d/a1aCG6FqqHypeOziSKAk3?=
 =?iso-8859-1?Q?pAha94+eFAXtS5kn4Oh9y456D4FqVpk+mexH6ZM5eflr0BdZFlNl2iunGX?=
 =?iso-8859-1?Q?8KSo/Xz/vBEeutdUq9BcwZY2E4kEmxBMy2AJvWF974e+GcRmQ86p1GbCBQ?=
 =?iso-8859-1?Q?bL9CgoF8PkfwJ753pjUWaLw7vKt41ubkzHQ87KXY15wvJlTuLxRjJuYTDa?=
 =?iso-8859-1?Q?7TCV4vTVAB+VtfLHI8eOPIhEMXoLjTraYhqY2NVdv/5HfiiKJwBxawiGja?=
 =?iso-8859-1?Q?PoLSxZk68BFYEubxrRivjddyQD3KOm2Mldkt/Lfl+pPxSDTvjWq+o+KcdT?=
 =?iso-8859-1?Q?lTM2WaYv6n9Ve9Pn9Kw4lixebyV2LWXVJmYooTd6k7zci/nY4IwgmNjxaV?=
 =?iso-8859-1?Q?TTly39djEErUmAqq+dHethEU+B3iI9d7jcrpvgf6PxJX+ikye0bPqvwYvH?=
 =?iso-8859-1?Q?mEkoqEy6kT8wfa3h8R2WEmHYWRKlAm+HoIKq/BAUGcxMWVDxpK8gNFR/D6?=
 =?iso-8859-1?Q?G21WsDeGYH/RM8Fg+kTxJxs3+4E3BeMD7pEf2IcUCZxT5QR3Yqj02+U8IO?=
 =?iso-8859-1?Q?TwrZwzmNsSVJM4XmUWwUjqYRv+AKd+Io03ZvnyxOImOHKRS1KZnJ/PVyk1?=
 =?iso-8859-1?Q?42FT8oNi9vgdi0vMVnP96mX3lbFijcWWh4mbgHCZ+wkqNTFF0oqu7BHr9E?=
 =?iso-8859-1?Q?380Px/2AU6HJlK/TTZ9f+bgAdBmXYYOV6MJAyjFco6BiE0sda1Ev63Dnv9?=
 =?iso-8859-1?Q?eQ2/WpVvY5hQGaImXX5WBu04z4wiv17rLllJzeDhmhOnL4FE/NvdouMPBD?=
 =?iso-8859-1?Q?Q7gxpTrvdi1Ae7ceYuepxZs4e2+6u4FJ26fF5QYNS6dNelwyiKpvgXaBFM?=
 =?iso-8859-1?Q?xd1mTwxA5/q4qSozn9WE/nSzFBugmvEcscZxx6O/IO3NDArrPgctZRhI6K?=
 =?iso-8859-1?Q?kRA7vQw2C82Az3jBjDEbIbz+37Xxe/R+wyR177yj7qPWK0oYByz0Mt15vn?=
 =?iso-8859-1?Q?UR3Q3irPR54M5JvCfX2U7GohwXz6UUj+AgzrKF+vNRHkSShL3O3nUqUuN8?=
 =?iso-8859-1?Q?G8J6HdicUHNTfA+RfGM1zHGKnP4QXS5xmmojJjJ2/koES02VHlobn6ya7M?=
 =?iso-8859-1?Q?JjpE8iHCvlkkuS8sjQ88pTdyXq+QZWOeNaF84zPDBlUB+Tqr/Hm9Ir0MeU?=
 =?iso-8859-1?Q?sn8/+bPVPESCWuIlXzNENJLp7Rsu9ybictygrivlcHptBhUR/6p9GeJ8dJ?=
 =?iso-8859-1?Q?0QB2Gtudj/wTjrtUcodjgYluf74De1g0SdO8Nhjhmrf9ILQtYSTmfqwI/S?=
 =?iso-8859-1?Q?T8gqVJ2Rq+XTaHXeZUQHX8am8wFVxkDH1m04K67215K7v7NR3A7IX1qdT5?=
 =?iso-8859-1?Q?WyLe8eE4K6FzPcSTB1pev8VpCD5AjZyPqR3P7YMv8tk1xt3an0DBcLg5GI?=
 =?iso-8859-1?Q?fqJj458lzwxCZcJji2E6/IECk=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f4502bb-2d5e-491a-a663-08d9bee4ed06
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:28.7467
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r7YxAtrBr9WWk+vi/f6p0876oeSKYUkkyMVot8BKyQm4wFjFqtC+Wd10LtwjYqKSMEMhAOe1rUOCFOL8THi6VPguFrXzB6lcx54nNaKwSKc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6976
X-Proofpoint-ORIG-GUID: R9AhTlzDXLwOEHHLJle-r0h0shZq5sZ4
X-Proofpoint-GUID: R9AhTlzDXLwOEHHLJle-r0h0shZq5sZ4
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0
 priorityscore=1501 suspectscore=0 mlxlogscore=999 spamscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

This enumeration sets SCI type for the domain. Currently there is
two possible options: either 'none' or 'scmi_smc'.

'none' is the default value and it disables SCI support at all.

'scmi_smc' enables access to the Firmware from the domains using SCMI
protocol and SMC as transport.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
 tools/include/libxl.h            |  5 +++++
 tools/libs/light/libxl_types.idl |  6 ++++++
 tools/xl/xl_parse.c              |  9 +++++++++
 4 files changed, 42 insertions(+)

diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
index b98d161398..92d0593875 100644
--- a/docs/man/xl.cfg.5.pod.in
+++ b/docs/man/xl.cfg.5.pod.in
@@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
=20
 =3Dback
=20
+=3Ditem B<sci=3D"STRING">
+
+B<Arm only> Set SCI type for the guest. SCI is System Control Protocol -
+allows domain to manage various functions that are provided by HW platform=
.
+
+=3Dover 4
+
+=3Ditem B<none>
+
+Don't allow guest to use SCI if present on the platform. This is the defau=
lt
+value.
+
+=3Ditem B<scmi_smc>
+
+Enables SCMI-SMC support for the guest. SCMI is System Control Management
+Inferface - allows domain to manage various functions that are provided by=
 HW
+platform, such as clocks, resets and power-domains. Xen will mediate acces=
s to
+clocks, power-domains and resets between Domains and ATF. Disabled by defa=
ult.
+SMC is used as transport.
+
+=3Dback
+
 =3Dback
=20
 =3Dhead2 Paravirtualised (PV) Guest Specific Options
diff --git a/tools/include/libxl.h b/tools/include/libxl.h
index 2bbbd21f0b..30e5aee119 100644
--- a/tools/include/libxl.h
+++ b/tools/include/libxl.h
@@ -278,6 +278,11 @@
  */
 #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
=20
+/*
+ * libxl_domain_build_info has the arch_arm.sci field.
+ */
+#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SCI 1
+
 /*
  * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
  * 'soft reset' for domains and there is 'soft_reset' shutdown reason
diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_type=
s.idl
index 2a42da2f7d..9067b509f4 100644
--- a/tools/libs/light/libxl_types.idl
+++ b/tools/libs/light/libxl_types.idl
@@ -480,6 +480,11 @@ libxl_tee_type =3D Enumeration("tee_type", [
     (1, "optee")
     ], init_val =3D "LIBXL_TEE_TYPE_NONE")
=20
+libxl_sci_type =3D Enumeration("sci_type", [
+    (0, "none"),
+    (1, "scmi_smc")
+    ], init_val =3D "LIBXL_SCI_TYPE_NONE")
+
 libxl_rdm_reserve =3D Struct("rdm_reserve", [
     ("strategy",    libxl_rdm_reserve_strategy),
     ("policy",      libxl_rdm_reserve_policy),
@@ -564,6 +569,7 @@ libxl_domain_build_info =3D Struct("domain_build_info",=
[
     ("apic",             libxl_defbool),
     ("dm_restrict",      libxl_defbool),
     ("tee",              libxl_tee_type),
+    ("sci",              libxl_sci_type),
     ("u", KeyedUnion(None, libxl_domain_type, "type",
                 [("hvm", Struct(None, [("firmware",         string),
                                        ("bios",             libxl_bios_typ=
e),
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
index 117fcdcb2b..c37bf6298b 100644
--- a/tools/xl/xl_parse.c
+++ b/tools/xl/xl_parse.c
@@ -2747,6 +2747,15 @@ skip_usbdev:
         }
     }
=20
+    if (!xlu_cfg_get_string (config, "sci", &buf, 1)) {
+        e =3D libxl_sci_type_from_string(buf, &b_info->sci);
+        if (e) {
+            fprintf(stderr,
+                    "Unknown sci \"%s\" specified\n", buf);
+            exit(-ERROR_FAIL);
+        }
+    }
+
     parse_vkb_list(config, d_config);
=20
     xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246485.425096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cn-0007dT-SF; Tue, 14 Dec 2021 09:34:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246485.425096; Tue, 14 Dec 2021 09:34:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cn-0007dK-PF; Tue, 14 Dec 2021 09:34:41 +0000
Received: by outflank-mailman (input) for mailman id 246485;
 Tue, 14 Dec 2021 09:34:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Cl-0007JG-Ri
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:40 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 32e434a1-5cc0-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:28:30 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE8mV6m004153;
 Tue, 14 Dec 2021 09:34:26 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxr338745-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:26 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6974.eurprd03.prod.outlook.com (2603:10a6:102:e1::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 09:34:18 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32e434a1-5cc0-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Od2Nyu0aD89TjEpf0m02RBV/r5gVXiXD1wQ/PydO0MYlxrZ1PivvUk3jxlZi1GP/r+CfQ5glALF7/U3+kEf8YyJ9JsfCF5ZTAPD8WKoxgi6BlVbajAY30c8/BYwlEykhuczMT9UGiur5vV0rGCGEFpVSMvtOtSfSRLvhO7QJFuGucyCPsXrWFn2ULVE84SEJ0fYBB9d9rRED59xMkaGnWnNIKpoxUA37GnyffZUzESDOF3X6BVFbzYUnBx/zYOAj+pOicp9Q4Ob8rMd1eP4DFclUoSs54X6x01tfuHnY1CdnqLGlerBYdcCECxC6/M7DUu4Or/fq6cpoUDo4Rt6OAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4EqTJdXZja5RAmYmgFwzvD4ulmqLhoeQ2wjok3WMLDY=;
 b=HPVaQJZJmIroGyvzP6dLeQpLx9JdS9MigBnABz9Z8HuxEDWLUAiARuHDvCIgC7uUag0XIE94S8wcJdiC8hfqWRXFD4ODg8rnMqUa3UO/GFCgYVvksrBB3DoWxyNcKBzVAX2PDZ8BKOOdTywF1+rhngSYXaDJSyvkDnKeItEgnNCSJpDOuA5xto8ZCIC0xidxYIMTbBRXNdm1371oJGhbrKlCo4pKyZpJH63ETU0b8+P5MwpOC0QvZOfhXN0+lEHaO40Lt4z6aw5jTJavwrvT6eGjsGlDTm0OjN95efH2vFaN95ONxGBqnTUhaFBxqHfhJx/xdzPSB+PTpQVt/yH8qA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=4EqTJdXZja5RAmYmgFwzvD4ulmqLhoeQ2wjok3WMLDY=;
 b=gJ6E57bQzWbFjPSD3pYW6uEJRwzjwa9f45oLg7hmwUWgLvauxTsdJj+tjMhFvnPoSXTHbGy/s+MD+smwBhnSlpEvPL0AD0hr9DlyANpt/uTSmM42/bNLzHbGmYElV6eFDJi7aEKG7MfStgi+lgXC7IneFTKQr5Vw6KN2kCUULWytsCCmN8lrDmabQRtourY1BVL6D7lNwI3aK5YMgHzHDHwGowsP+YzOVbnkMP9LlNtP+4DZ5CzpCZWZ+7Eqg9QhNvoc3PjdW4EBM+AtkouUzH2m9Bd5QOZZnWYNx/m1N9KfSqOvYlhE95kyfgEbImSGCkeHEzuAlJVM42nDzZ5ugQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: [RFC v1 0/5] Introduce SCI-mediator feature
Thread-Topic: [RFC v1 0/5] Introduce SCI-mediator feature
Thread-Index: AQHX8M3EbPa1dWpku0ybFf1q9+BnxQ==
Date: Tue, 14 Dec 2021 09:34:18 +0000
Message-ID: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f6ae68f5-eef0-4008-bc92-08d9bee4e6c8
x-ms-traffictypediagnostic: PA4PR03MB6974:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6974008DE65CACC2A8AFAB2BE3759@PA4PR03MB6974.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1JWp60UaE7K/XIcnVguQpxfGvRAZ3KIHPBow3z1e3V8SgW7EX/Se+s03vhg4JUmt79ASSxncOcqF2NzXd1RANS+4PW1s97R4rRaQNW/tOQmk7tytER2NhEyywNbiZHaxmrC8VIbAOLoTcOgztsYwyj/dAAJc6JsMOrF9uq+KOZViR2QRZWlKO/BPIty9MFjpKD93+u1fB/MwbvoVvBnPMG8FMNjfvZSSEAVbEsmEfc4Fn7mg2Fjmdo1lWG06/oKpjNqi9unLFcezQiLt7A8H+ALCfvf5OrPDMQgEZXabnqbj9bJf3N0EOwauJOizVrpogeSWUcVhPR2Cxle5t+F/ccbxx8Pc1dQmjLK5046z5PAWQ5qFJJwxxZuLjI7eUqDABjw58n4OfzBta5pUdB2fudsTA/nwYjXiLRnHIiQQW5kWaSsh8d51Pm8HohbIif48kdn80N2k7jgVT5CCUxsZ2H1IciJNtmaoOBrPUfwS2qY0eHt22vApwL6xwV/NYQec6ZMVKLZbFDBadeunzctkozpQdmWVVhkLZzGmjvextuufvrAeNVMyXHzoxjrI43yr2RBAecBG3K4enL1pwrGyAleQqzJHySseWG82eGRC6UJE0HZKQwnlEhcdkOd1CBbZje5uIQXLwxAPybz7Irg08wbGij9fcP+lCq2UA3gRaolMWUlkKHvMDX9qEokuLHek8RDlVwlg7k3Hg4jgZ8+TqQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(66556008)(83380400001)(36756003)(66476007)(316002)(38070700005)(64756008)(54906003)(122000001)(38100700002)(2906002)(91956017)(5660300002)(26005)(6512007)(7416002)(186003)(4326008)(2616005)(71200400001)(8676002)(66946007)(6486002)(6506007)(86362001)(76116006)(6916009)(508600001)(66446008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?fjVDhljBENyp49/IjJxeNFlzhjElWUmcB87jgE4tRmTyPx7aiRWkYmir7V?=
 =?iso-8859-1?Q?8wb/17rVgoRhwJabMW29iIsdLnR34CSiFKZeAek+wIxaFMXkxI0tij1VLE?=
 =?iso-8859-1?Q?iiXsJabxDi6gM9wIx4rEJwLHvcThsvx9SNzTQ8vasOr4F02zYLSgBKu579?=
 =?iso-8859-1?Q?qlzyZ+HRuT1sjz5pQROqBAAzYhaP3zLneXhDmEHIcJ9PmziajmC3OlMdea?=
 =?iso-8859-1?Q?0UedoAdBEVBRzcf4Pdd31SezYYQkSiiF7g5m4PdNELzJzHfe7WkLN1I5Lh?=
 =?iso-8859-1?Q?jS5OUr0L3H4zwSZdDmThvNzx3W9KB6bhZRAgqG4r7xn0I0uwBB0Rwj9xi2?=
 =?iso-8859-1?Q?igSGBLfAu+f7BYFxyQs6mJmnjGZTTYK9EuKx5jTfDW+JCT+ejbiYh5OKgX?=
 =?iso-8859-1?Q?tXUgetkvZ33KjDhxbLP3DQrmxAvagWSF1vLwfHNoEyhNSgWmKzXw11MSGF?=
 =?iso-8859-1?Q?pMMu1W04ZgpoTI+TPAZf8SG7/DnJi6tRuqXalSYUoB6Smyx2uUO3UVkteg?=
 =?iso-8859-1?Q?QSxHGxctGKPYGOzC50/rzicCaB3k6NcUBbh3FU13vTpprp2eIL/UcfaJmh?=
 =?iso-8859-1?Q?/PCsU8EoqDz7DLWr2ZLjFKjJAKFOO4zzogHQELtgGgN3LO8uLNM4PYpASZ?=
 =?iso-8859-1?Q?fAYBeeclbZ75UKytYN+z9TnxjF1oHkmhHS5xs0rmCjha59piExS4KQA4X3?=
 =?iso-8859-1?Q?ps/mwmkZ7tReve882xq9ba2F3Zg58zFV8+hmonF5oCRKYbtjz8AUPNfecJ?=
 =?iso-8859-1?Q?e/IJCxgV0UjFjqwDPtoU5V8HtzLe43c//J3inqxbqA4AzT0pl0i5VeJpjs?=
 =?iso-8859-1?Q?WPOGilFNQmd6z4O2cD3KN0EiWKy+gGoZKV67cngyGO+bLYgc6fmb2Mpqp2?=
 =?iso-8859-1?Q?qk6KnfFNBV8YExVEflKgiJRr8Iqs28+dda+PgSLmDU5HHfhRZ+bsneDNK5?=
 =?iso-8859-1?Q?q76sIsKsi+NXqyCIAKIXubErNFciONXvv5U/WE2d/+zb7vPWz9KE631HGz?=
 =?iso-8859-1?Q?uYLuA4pLrItPLOKlE3QuZfhAk7Q1+Tzh5WEhASdSwqXYQ64+dWPxuOvxsm?=
 =?iso-8859-1?Q?NocZ50gFACJCwrqIWtbXAwELDJpVdnuJfUnjHkLOLfQ7RgpgljfguGNCMV?=
 =?iso-8859-1?Q?bPVclOtv8pUsLXJANhpw7T4az/USyBtad7ckeRYKqGrDGRKbjOxXLxHCBK?=
 =?iso-8859-1?Q?CtScC8b7Y4CSucyQfrjzZlUpVt0krmi6xMSC0n/IMyd7vVQ//nwyJg9A2Z?=
 =?iso-8859-1?Q?q2zyKnbbTSFw7r+oj8GZ0waINNjSHG7HXDgbPbQgVP6JTIcPqqEM0sb9D6?=
 =?iso-8859-1?Q?5lXuXkJqOkiAwypPQqrwJ2zo80cZQL06XmD2JgjsNoxclzIPhDmSvRHENm?=
 =?iso-8859-1?Q?PdGkwxVJfCafC+TbRB6g1l7x3pBUnzuO19iLe+xhz9tmjXkafwDQEvm4gh?=
 =?iso-8859-1?Q?uwo0RnQn/AaO0uOWHfFh4RSio+ktbwbH5AgOEPFbQovaiRyRQypPGGomcV?=
 =?iso-8859-1?Q?2neEPiMbjsEhe4O7KvVwrQPw4bB3TgEFfFiieOkaSlL6g8X4/pcXxP0AWQ?=
 =?iso-8859-1?Q?t5RBzJMYXxZ7U4J0711Tt7EH336Up8XvefKS7Klyo4O9fZWTyfK0V6hFGc?=
 =?iso-8859-1?Q?c1VmpTPgKwyotZxsrogNEm6FRYJE6QYRFYWjmYnJ8EKudvWwq1ggopfEoY?=
 =?iso-8859-1?Q?K5jGWTyeikoPOuaee5t/6mR0M2k/DsdCZFG9Xm6XE11mX6RKzqoOOnLlfW?=
 =?iso-8859-1?Q?PGtoL2d7ojJ/G6V6/lt+bGvYY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6ae68f5-eef0-4008-bc92-08d9bee4e6c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:18.2434
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cBQEdyDaYtoSRnf2lue6Uzk7aL2OhLtFE8FPjJ84pztdp8Vs0T/zkTL3ZfgcYDz9EP3dGRDfDPEWOiKNcIG27mxcisSWUavmlZL+zEOwB74=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6974
X-Proofpoint-ORIG-GUID: rVCIfrHDP6X2UwtYPCTZODOhNVkqlGzz
X-Proofpoint-GUID: rVCIfrHDP6X2UwtYPCTZODOhNVkqlGzz
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0
 bulkscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0
 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

Introducing the feature, called SCI mediator.
It's purpose is to redirect SCMI requests from the domains to firmware
(SCP, ATF etc), which controls the power/clock/resets etc.
The idea is to make SCP firmware (or similar, such as AT-F) responsible for
control power/clock/resets and provide SCMI interface so controls can be sh=
ared
between the Domains.
Originally, we've met a problem, that the devices, shared between different
Domains, can't have an access to HW registers to work with clocks/resets/po=
wer
etc. You have to pass cpg to the Domain, so the devices can access HW direc=
tly.
The solution for this is to move HW controls over power/clock/resets to
SCP firmware and use Linux-kernel SCMI drivers to pass requests to SCP.
Xen is responsible for permissions setting, so Domain can access only to
power/clock/resets which are related to this Domain. Also XEN is the mediat=
or
which redirects SCMI requests, adding agentID so firmware should know the
sender.
SMC is currently used as transport, but this should be configurable.

Here is the high level design:

SCI (System Control Interface) feature can be enabled in xen_config:
> CONFIG_SCI=3Dy
Mediator can be configured:
> CONFIG_SCMI_SMC=3Dy

Currently, only SCMI_SMC mediator is implemented, which using shared memory
region to communicate with firmware and SMC as transport.

Xen scmi should be configured in the device-tree.
Format is the following:
	cpu_scp_shm: scp-shmem@0x53FF0000 {
		compatible =3D "arm,scmi-shmem";
		reg =3D <0x0 0x53FF0000 0x0 0x1000>;
	};

	firmware {
		scmi {
			compatible =3D "arm,scmi-smc";
			arm,smc-id =3D <0x82000002>;
			shmem =3D <&cpu_scp_shm>;
			#address-cells =3D <1>;
			#size-cells =3D <0>;

			scmi_power: protocol@11 {
				reg =3D <0x11>;
				#power-domain-cells =3D <1>;
			};

			scmi_clock: protocol@14 {
				reg =3D <0x14>;
				#clock-cells =3D <1>;
			};

			scmi_reset: protocol@16 {
				reg =3D <0x16>;
				#reset-cells =3D <1>;
			};
		};
	};

Where:
&cpu_scp_shm is the shared memory for scmi buffers;
0x53FF0000, size 0x1000 is the platform specific free address, which provid=
e
space for the communication.
&scmi node, which should be copied to Dom0 device-tree.

Device configured to use scmi:=20
&avb {
	scmi_devid =3D <0>;
	clocks =3D <&scmi_clock 0>;
	power-domains =3D <&scmi_power 0>;
	resets =3D <&scmi_reset 0>;
};

Where:
scmi_devid - id from the firmware, which is assigned for AVB.

During initialization, XEN scans probes the first SCI-mediator driver which=
 has
matching node in the device-tree. If no device-tree was provided, then the
first registered mediator driver should be probed.

DomX should be configured:
Device-tree should include the same nodes, described above.
&cpu_scp_shm should be altered during domain creation. Xen allocates free p=
age
from the memory region, provided in &cpu_scp_shm in XEN device-tree, so eac=
h
domain should have unique page. Nodes &cpu_scp_shm and /firmware/scmi shoul=
d be
copied from partial device-tree to domain device-tree, so kernel can initia=
lize
scmi driver.

SCI mediator can be enabled in dom.cfg the following way:
>sci =3D "scmi_smc"

which sets scmi_smc to be used for the domain.

Oleksii Moisieiev (5):
  xen/arm: add support for Renesas R-Car Gen3 platform
  xen/arm: add generic SCI mediator framework
  xen/arm: introduce SCMI-SMC mediator driver
  tools/arm: add "scmi_smc" option to xl.cfg
  xen/arm: add SCI mediator support for DomUs

 MAINTAINERS                       |   6 +
 docs/man/xl.cfg.5.pod.in          |  22 +
 tools/include/libxl.h             |   5 +
 tools/include/xenctrl.h           |   3 +
 tools/include/xenguest.h          |   2 +
 tools/libs/ctrl/xc_domain.c       |  23 +
 tools/libs/guest/xg_dom_arm.c     |   5 +-
 tools/libs/light/libxl_arm.c      | 122 ++++-
 tools/libs/light/libxl_create.c   |  54 +-
 tools/libs/light/libxl_dom.c      |   1 +
 tools/libs/light/libxl_internal.h |   4 +
 tools/libs/light/libxl_types.idl  |   6 +
 tools/xl/xl_parse.c               |   9 +
 xen/arch/arm/Kconfig              |  10 +
 xen/arch/arm/Makefile             |   1 +
 xen/arch/arm/domain.c             |  24 +
 xen/arch/arm/domain_build.c       |  11 +
 xen/arch/arm/domctl.c             |  15 +
 xen/arch/arm/platforms/Makefile   |   1 +
 xen/arch/arm/platforms/rcar3.c    |  47 ++
 xen/arch/arm/sci/Kconfig          |  10 +
 xen/arch/arm/sci/Makefile         |   2 +
 xen/arch/arm/sci/sci.c            | 128 +++++
 xen/arch/arm/sci/scmi_smc.c       | 795 ++++++++++++++++++++++++++++++
 xen/arch/arm/setup.c              |   1 +
 xen/arch/arm/xen.lds.S            |   7 +
 xen/include/asm-arm/domain.h      |   4 +
 xen/include/asm-arm/sci/sci.h     | 162 ++++++
 xen/include/public/arch-arm.h     |  11 +
 xen/include/public/domctl.h       |   9 +
 30 files changed, 1485 insertions(+), 15 deletions(-)
 create mode 100644 xen/arch/arm/platforms/rcar3.c
 create mode 100644 xen/arch/arm/sci/Kconfig
 create mode 100644 xen/arch/arm/sci/Makefile
 create mode 100644 xen/arch/arm/sci/sci.c
 create mode 100644 xen/arch/arm/sci/scmi_smc.c
 create mode 100644 xen/include/asm-arm/sci/sci.h

--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246486.425103 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Co-0007hE-8t; Tue, 14 Dec 2021 09:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246486.425103; Tue, 14 Dec 2021 09:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Co-0007gx-2K; Tue, 14 Dec 2021 09:34:42 +0000
Received: by outflank-mailman (input) for mailman id 246486;
 Tue, 14 Dec 2021 09:34:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Cm-0007DW-12
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:40 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0dcb6d22-5cc1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:34:38 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE8mV6p004153;
 Tue, 14 Dec 2021 09:34:28 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxr338745-4
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:28 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6974.eurprd03.prod.outlook.com (2603:10a6:102:e1::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 09:34:23 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0dcb6d22-5cc1-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=enrWauorJnK5uwQhrawQwKjBFNAwCBs6TxAishYgWeaMlnWEBK5B88W6GIVukomqyWhA6PGuhEpQ9xRf+25k5UUTfZYGCBTaXIgWyIY+3r6q5smLixy1ngc0uUyXpAeWelNZTEuH0wfG14UAY0rGGckA/SiewfEac5dAt+tFklHb3Hq8MaymFMPZl4Yy67dHFeOEIFxUfW95BB+Ly9WDj00hYHzpDOg0CtBJni8AYWQZFUL18XxuZ0lCzNA323+o0x3Tspd75TU+btS5gOpF/LZkG5TbmsxaHYQZzlMusc9Su/8j2XNAwTlj0oBGEPRoDVrjfRgERjcbXRFmtBuAUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XcQmMVoAC0qvNEyr6vX6HHS2XVbpv968VA/fx82VqSA=;
 b=A+GM2DkHlK4tC1QvsieeSwkile4+UiRqcuyqssKAbgiyPYFwPl/xU80pPbWRHSSir3RjcIxql9uYlGcPNzcL8GfF7oCLAT3cA01k7vO5eHbQMlAf1yyjhqaXaJ109sz2tHGVoWAtqphWaM1Xcwnsw9wlnXbb9hhFOTKWm8CMnZluqJcPZWHNGZX3xjqObUqTFVF5miB9+9GlxV8mbvtSNJYiTjJIZDMwnwMJAXdyBMpDg7sIALxipC1rfy2CLLdx0nnSMEua4TgoWA1fZpQ6apc2IiaLRWFkicVHLNpFjzPiGP38V1QCGNU9Grkl3eP/6SDza+g+EQ15cUqd2yXufA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XcQmMVoAC0qvNEyr6vX6HHS2XVbpv968VA/fx82VqSA=;
 b=SXF9/50mobbK90OgrrmPFBK7zR2GeLLKcdbyfk62yxkgiF55c39Lf1myt+6X9j9IewHBcUtt34GDA3DOqjak9jihlRPLFzZFmSfmCC9rkh9DvMq0Zn1s5cN0ki+Mc4HMX2d2nJ3OEX5Z3H0HwVbppD44OJcTqlI0MQRzKhhfk/bS6hqNrJTun6kVcDA3+XiTQBRktv7jdpaqzIKXUXBJBIy1SNM8drqmeqCHMNGpgM1DtLl9BhtB7sQnY3wctEbekozG6bK35UB9d/mNYW4eTs8syEZ5k5BLQIQAiNdPYzKhxAEcBntkpLLO9uazb557KQRWhhBdSUFDijcWMAuyFQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
Thread-Topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3
 platform
Thread-Index: AQHX8M3HLq8qFfw2eU2jxqbriRiMpQ==
Date: Tue, 14 Dec 2021 09:34:23 +0000
Message-ID: 
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4fc9096e-b8d8-4d87-db44-08d9bee4e9c1
x-ms-traffictypediagnostic: PA4PR03MB6974:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6974C1E1F4F96FD673724441E3759@PA4PR03MB6974.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 zJ6DATxATVzBRUU688EmLQpPBx4j3peZbO3HZcXd1u8PhHywKb1h4zcM+OdF64lEwHsZQ3mCZ+dQHUXV3/CMKf1OJtLatyRBefAurWv3uLxP2gVyY6ofqbPCfZ7UfvDDZld2rs8vfUPkSQBXSbXok3hPHxjY5NRu5seC5EeiZHW3Q1GpPsK9Qacb4w3iGcGBRSqbTu5PA+VtWR2IRXv/XAQAIS79j5TRPjaB2WKdRUnt00XHDLvVOBUFMyPCcz2elZEQ6ITDooV9PVXFxP6YbjtGyMUsMT2ZN1HRoGFSxgSdnFRxyU5cntH14GhERfCpUHzWXaNt6cAxL9sj19+DqAUDuEmdaD7qXlhx9IyxDK5ZGE/4Rdv1Kl8GuivpsxzFsKMFAJt+xLtkjo5LSEp4mZhd8F9zolqg1TtyF+B7/+zWaAXcvh9i43uRPsaEdjSG561a9gKxIxhDdGwYeIy/c03GvBefbF8A55F2L2yBAosDdSzs/O/eYhub6vPyI7CmOVSHUopAVMPP5ULZIbej3UHbfvmIaP1m7d1MK0Z2e6fbDMuNFLdoucqx0hTk9rONd7fs/nw8C93YZOBhPB6jvbOvD8vo0zMsu+hpS754YBmysUjIUkIZz/40TFSP2U3vSN8ong8g8vjbqEfN78iPGj7UVPsFvqsp7QXO3uMmEl4NIiPxJl3gAOVm9QT3nD1Th9orssyAuir4pUZ1jO+KpN1djglmN8/+xZmRiduL3FA=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(66556008)(36756003)(66476007)(316002)(38070700005)(64756008)(54906003)(122000001)(38100700002)(2906002)(91956017)(5660300002)(26005)(6512007)(186003)(4326008)(2616005)(71200400001)(8676002)(66946007)(6486002)(6506007)(86362001)(76116006)(6916009)(508600001)(66446008)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?sWxL27xWjsqJnZALrm+e6UpCnlJ0thLJAe11Qvz3mBjR96mFq4MjB6icJb?=
 =?iso-8859-1?Q?buHxkbH2f5v1+5zdDnEYSDs6Qjg+1znJ6UyYoTXSEw6XDxuMwyXJlPDAGC?=
 =?iso-8859-1?Q?4LM29A01vjed92eQXYwloyQkw2RTtzDuzKnVpffcnscQtRrziruMZPM05L?=
 =?iso-8859-1?Q?B9PMDiE0hdh40JkuRTbvLdJ3ckiD0KT7FR0Slb2r6D9x6S5o08krEDDAsX?=
 =?iso-8859-1?Q?KwVR5XLbTtwlCZVaO0OjJ8iblkJX0xyyoSwQKElzyQdfR3RfXvPQkGlKwW?=
 =?iso-8859-1?Q?2YJtNCXOWwxXbOxDVVXsVIY6y/J4OoeNDL3PAmHsiw18Du0pfG5pcyOPMW?=
 =?iso-8859-1?Q?QZ2n12VrBlsj/JaoOizN4kUwRIAFA+ASZaoemZEc/C+fwxSMChAqfPZwAd?=
 =?iso-8859-1?Q?EWcAfOfPbeCxVs4s0Ib38Q3qqghKxkAIdJwnrC8sWl9IdszeWb3DAxGlok?=
 =?iso-8859-1?Q?lRG2FNz/oCNiB9BmwKkfKXymeZFgZAFHcBELymS7bxA/i2WTYlQsX+8tWE?=
 =?iso-8859-1?Q?kLL8xJgYow+aMKqd8NU9+yBd06Dau1l3i7Sn+KdN1xsLQwhAho6OWNUkPa?=
 =?iso-8859-1?Q?C+snbz7S2/TVMnMY4BW3BqkWEzJaPvRw9c9KVAOisWqiWVFyAbNOm1BXdg?=
 =?iso-8859-1?Q?hqQ0gkz0Z6qjCJaNnSwA6wrYtFwDOLc/g8mkaCCw4vskRqfLnNUpG5uefO?=
 =?iso-8859-1?Q?X2AjPVtTyC7Kgo9VfSenlseEAhn+xhRLfS0oqrJFFZ1tyzwmR56H/8o4Xw?=
 =?iso-8859-1?Q?djq+4lJmyJQ/9l0UyFoFc/fLZBy6T+Y+jc4dt0U6aL7Uch11zs/uKkWn0D?=
 =?iso-8859-1?Q?cRG5psDyaA7WTc1S0EormlhSFkw1R+vQTiwJNmVoW52JaW2544VomDJiN9?=
 =?iso-8859-1?Q?fB0fV3AwwasbiiXkIzyimHyalGddYSiGIcPJEi5+ViQXHkIoh91Fsvqe5c?=
 =?iso-8859-1?Q?QU/8+BVgtK2FRkES8tL/NKXxv+FLEQKVT4+avlYKXFkN+JAbHnGkmTMYbb?=
 =?iso-8859-1?Q?EgA0f/cEra+i1GH9G5zDu2u/NBZXxM20qvJ5TwkC8T5RSQ8Bcq4GdFcD4W?=
 =?iso-8859-1?Q?FsCR6QmnybyFZo2hwbJOTMpGRDRc8tkosYsPiagFbcGWnZHVYV8/sIW8hH?=
 =?iso-8859-1?Q?EFsvm/TYRCuW3H5aDbbBJ2H1nHr4HmcCBK5ARUD2Ogh3LvBEfpX5+GsfZf?=
 =?iso-8859-1?Q?hQINgdbZrSzk68yH6OdJVLjFZsbOuWvoRp+6q37WwwPsX9ee3GuZS+bJ2U?=
 =?iso-8859-1?Q?+ix7m2bKjpkyVAiQsHjonL+Cv/YYG+J7bbKY2wqH+V5wwmPBabqh2WqyNx?=
 =?iso-8859-1?Q?rpcvqQgdW7vWvK6Qs6EhP3d7yQ6Z03jkSaID1rUYU1yDaNiof2SakqqgO2?=
 =?iso-8859-1?Q?IMg5yD+M4khqSTWdOOSxp+ELnJkB18zYele2W3AqUvqjnJSWMNuc6QaEIX?=
 =?iso-8859-1?Q?2pWWAK8kx8b4+rcSqHKmba9b8TObFNiUjXIRDGAr4BcXTegNqr8UkaIxfJ?=
 =?iso-8859-1?Q?9WaaueHHaasa9TklNQNbFTk2Ka0O5Eu8rwqmr+Omj5+bMMN35zDLsosO0b?=
 =?iso-8859-1?Q?ik7oHAbRDDMiwEAnKm0XSqkHI20ytaVMrAXyO4GnzHkZvC6cVR6JFvctpr?=
 =?iso-8859-1?Q?Flm85RFwqmjdoTUSp9BCA8xuRlmkQtnUTLE7IIx1W6y516HSmAP6bU4ppy?=
 =?iso-8859-1?Q?k6KVW9/cckVouW4Q9N17FnI0DBy7JvNluOvCSpqr1cDdqVWWoEk9BTiVSU?=
 =?iso-8859-1?Q?BHbdzOOerBmRE1GyCUwa4RwOw=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc9096e-b8d8-4d87-db44-08d9bee4e9c1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:23.2315
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YshgjBnYaHk/DTSfe6ga5fXofPo0uF1HfaHx1e3gNBtZcHiWRbsLbfp6zvv5pTe7lhxjWPk8QQt3ZJ3cXzgi5e2vtwc7IyTQ8GSbkSLc/mA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6974
X-Proofpoint-ORIG-GUID: ONwttEhYqV61lRlxgB1qmhuOWAZqu6it
X-Proofpoint-GUID: ONwttEhYqV61lRlxgB1qmhuOWAZqu6it
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=945 mlxscore=0
 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0
 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

Implementation includes platform-specific smc handler for rcar3 platform.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 xen/arch/arm/platforms/Makefile |  1 +
 xen/arch/arm/platforms/rcar3.c  | 46 +++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 xen/arch/arm/platforms/rcar3.c

diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makef=
ile
index 8632f4115f..b64c25de6c 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) +=3D exynos5.o
 obj-$(CONFIG_ALL32_PLAT) +=3D midway.o
 obj-$(CONFIG_ALL32_PLAT) +=3D omap5.o
 obj-$(CONFIG_ALL32_PLAT) +=3D rcar2.o
+obj-$(CONFIG_RCAR3) +=3D rcar3.o
 obj-$(CONFIG_ALL64_PLAT) +=3D seattle.o
 obj-$(CONFIG_ALL_PLAT)   +=3D sunxi.o
 obj-$(CONFIG_ALL64_PLAT) +=3D thunderx.o
diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.=
c
new file mode 100644
index 0000000000..d740145c71
--- /dev/null
+++ b/xen/arch/arm/platforms/rcar3.c
@@ -0,0 +1,46 @@
+/*
+ * xen/arch/arm/platforms/rcar3.c
+ *
+ * Renesas R-Car Gen3 specific settings
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021 EPAM Systems
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/platform.h>
+
+static bool rcar3_smc(struct cpu_user_regs *regs)
+{
+    return false;
+}
+
+static const char *const rcar3_dt_compat[] __initconst =3D
+{
+    "renesas,r8a7795",
+    "renesas,r8a7796",
+    NULL
+};
+
+PLATFORM_START(rcar3, "Renesas R-Car Gen3")
+    .compatible =3D rcar3_dt_compat,
+    .smc =3D rcar3_smc
+PLATFORM_END
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246487.425111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Co-0007sx-Rw; Tue, 14 Dec 2021 09:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246487.425111; Tue, 14 Dec 2021 09:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Co-0007p2-L7; Tue, 14 Dec 2021 09:34:42 +0000
Received: by outflank-mailman (input) for mailman id 246487;
 Tue, 14 Dec 2021 09:34:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Cm-0007JG-Ta
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:41 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 341575b3-5cc0-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:28:32 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE943EG004675;
 Tue, 14 Dec 2021 09:34:35 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxraag3uw-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:35 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6976.eurprd03.prod.outlook.com (2603:10a6:102:e4::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 09:34:27 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 341575b3-5cc0-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UwnGUl9bX6i59s6B7qkAKXp2jvEk4m7FzejG+a51nPdxUmLM/UBuMP9Z4IyX3NzazUlxzRvPAm8CsE8l4BrWmg1ZC/s3ine+LIUY5e4ebh2wJ2jawc5NwvluPjX4ZBcrQQ3AwQHmPKTXRLR0CUFA1HYjBzVqE0HgkbwimfbmbDzWS4HubPke9bqMhXvUNKoCp2Sp3V3pgC/MwyvB7vQMJSK0d+9qfXL6xcETr6oxk6IqYKiqEggHDczWqoXFsYb7aXVwDHupBWznBoi+DKqtcjkvLCs0XNr2sUrASSHLyj3nyeJmzcj1ufzpkQRPxjFO4HEDgKN8luqIyxv3Hwbl/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RqDx/qBEgEJtOnIYy1d9FCWR8MG1fPXkQ1whSTJXTl0=;
 b=h5II6aVCW9LhIQ0pcInCCgzIW9lD0XJZ+6e/hPWM5IF7INA5AGmj6HMFZ1G/Kj2c/kqT6WpD7d94pbrxw2NeXtZnSGdqkEyS442DNNbK36HTJCo5ChJ71YBoR63M47dj0a6WpyBvWl63sFtMWQVppsp6JGI4sUD85eD7cJ/PwVjYDuUapESz2WUzs0piisObrveiAZqtZPeIFX8jZvY04rSFAQ/Na4JYL+10AE9wzKJK/2mG268hNdh6ggS91n4f6GrJ9COB8bKvB9r5KCANBmpj0dh1ipWxdz5veDCoUCf+oaB3rHup596GhKfbotFZ5AW/aF/OukbPhAgkNtq2TQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RqDx/qBEgEJtOnIYy1d9FCWR8MG1fPXkQ1whSTJXTl0=;
 b=S2qouYjWnD58sLL8Daum0iLSgcv0bumf18ECt3jQopfj51OJx+IdRDc5l7TDqryrN6YQbT//YHOVX4XY6znp+W72rdS2YgrbLKODk4AdOClSuhfu8aUnXRUmROER+T9N6DWU7PPduBmLAhcjowZzVIUuVKDsjsGFugj9wZq8wO4zL23gKfv6CWVA3MQ67XEUhyRgCynnS5SOgGDFwId4Io8+ZzsnoUzIPGROMSJ88dkja2JLX4bGKHHwdmoH/pP4+/lNzlu8bLxwlb4gIbLXhpyCc+eaQen8ppz4WzElGfi4dyYVb1M6qCU5i/+PlwX0Hs9mSdBRTQfC57s8Bk2oKw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHX8M3JF7Ng56/tV0+8/7pODiaWfA==
Date: Tue, 14 Dec 2021 09:34:27 +0000
Message-ID: 
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ca2bd1b1-d2d6-4e69-31af-08d9bee4ec24
x-ms-traffictypediagnostic: PA4PR03MB6976:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6976A3FC83739D5FC3B491B3E3759@PA4PR03MB6976.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2512;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 QwNPoH92G8HviE3JqVCX0MMKrkRnBlo95OojdFpOxpxXsoVZb7ZxL7H/ygk4JxkgBoRJQ6b5pp1fIajW4hwT9UHWaXRp79JW9o8s8mMhhA0x0q+nOjdP27JF2ydYhvlnMqUuAGsTxxFFpuWIj+bxUtIK4cOU0a/EAkNUkaKoxPPndinnZod7nuM5MGRyKxsPKfYAiMsj3RhBgDmkJAhvPrRmPOQ3aIqG6px0u8lYeXT01LnNuctFRF9s2vcJPXPp8dIFKAwoWg6+Mnud2Nyz1ZEJtpzyXIn5PBKzpZdgv/0ZIfTBFzbWQftJRcsVuGW+iBZnsoku8ckB7tFedt6Qobjgynd5UYrSxiDF9VnpDwV1jt6Ce1lF4Q1KweMX0TeycvHNeCYKhWrCBBtE6xD7vUl0/68atdi1l/fxRd0porCLQUzR3R7fzNKtAhcJFEoXlL5o1OHB/LCfIfebEiqV5CkPNJOhu7E7sh39xzpCguWgkdJ7BkTtlNOTk8cyPJPhyEb/tWGiMz+5TtrS6CZQ11pvAJmFvyksYAOI1rSD2AI6B9uyD1wJgjylvsje4vEQJO9IFNXpwzOge8rLPJa9sUe3hBvsGkGazQ1BtXEAIVCcDNn5GHLz77CilsrZEFiSxkmFrMMWnzCDdY0OplHZQXWFFPz3qVzPqoAJSA89vcYq1bk5OrdUlzaYusbewIdGhz52t/HeTHHV95ll+m/DKHz0umTQN3PPopKikkk58z4=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(64756008)(66556008)(66946007)(26005)(66446008)(76116006)(5660300002)(91956017)(508600001)(86362001)(83380400001)(186003)(30864003)(6916009)(4326008)(2906002)(6486002)(38070700005)(8936002)(2616005)(36756003)(71200400001)(8676002)(38100700002)(122000001)(6512007)(6506007)(316002)(54906003)(2004002)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?ACcJU8qchTVDnGm/rPhClN22iecsD0+V2QbTOgNWdsKL/Cejigh3DRJ3Pv?=
 =?iso-8859-1?Q?XIyAesdLAQ6gDvzH5dsc3M5B09HfVVXVq2T4De2gAktQYjykZS3ouW8P9C?=
 =?iso-8859-1?Q?g3opwMiO8C9wI86nQa1Hsj610D09VQp6u2y41s0868gFLQHoxrar0d+zJ5?=
 =?iso-8859-1?Q?WTMF5SZ2nPwC6ZJar178KTkDgSZomff0FXmx0IUSH81VPkr/S21aECD2gS?=
 =?iso-8859-1?Q?xMbf5JhrxndxZGaWCRXBNYhXRc1pK6twGx160H221H7bhKd0R32MN7+4Fg?=
 =?iso-8859-1?Q?ptuFuud3p1LXL5VjFV8WQijEGSIo2lP2d8TRlbZFthO5JjCzl+PtQpilvB?=
 =?iso-8859-1?Q?GekbmuzL+C/7cw6AJZ4igt4KS7hYDo6NoXWHK7eBEuKNXZ4RhZUR7Bk6jk?=
 =?iso-8859-1?Q?0+an3vCkO2hpJmy5WcKwLv64EN+Mpnb4YfPdc1sRDh2cND/rj3rSnlsjaJ?=
 =?iso-8859-1?Q?RG5N/SgJCO5eTgJYQBsEeedK7iofMmokZIXfQYxLNqqKxzoB7iF2dV8Azz?=
 =?iso-8859-1?Q?ryOAwfxiO7ck/enc79YIGzHWasu/3mZDGJeXg3uFCjYAWG/zWmoHdGTNmV?=
 =?iso-8859-1?Q?JQceO4Ctzor8JEWchAR46xx0zFDGK80GGTjxQxgooIr7wjoszL26clKeem?=
 =?iso-8859-1?Q?n01N+EVJxCKnVHn4iW4y4F1SlXDsDy7IsLIEoEfPBQ153Nn2g+1j41bfrY?=
 =?iso-8859-1?Q?I2OrxFG1wvjWlUFAPurQetQ90BBx/qsTuTkChFxfFOwap/zM7HeKqjWvAW?=
 =?iso-8859-1?Q?4dYXaos5V3w3mRtFxbzUXqIVNNtt9/31c0qvV1SJzoqbFiJg3wNzeJ3iAd?=
 =?iso-8859-1?Q?maRmhLjXfYuF46kVIROqaS4WgF1b+bLKfrymq4xn37XLLRPpvSwlztEtk6?=
 =?iso-8859-1?Q?5mfZ/YI0sGdL3VwvjqrOdOCS1tpRsLnENA97k4M5T8bWQSZH2ViiEvUsRn?=
 =?iso-8859-1?Q?7KWsK9BgWSSfDhxXA+R1KYFQTLoy2PCzAUbJ3AUOBnmJNp43Cz8cBals2S?=
 =?iso-8859-1?Q?xns2rLGKR0mkDpFXA2RWM5KqQc+pgBB2PXNVcGMnOZdk6rQOvOJEUDgdP8?=
 =?iso-8859-1?Q?JhqaJPh9DwV4xCPABe+ivJTdajly+QRnhiDm0SsTKFs/ZJP2o6Jf6P8s7q?=
 =?iso-8859-1?Q?ylNqom3IjOpXVPYj5R1DapIQBQJz2nsCs3nUhvqDgYhDMBGZhhDrK0BFyS?=
 =?iso-8859-1?Q?qYH9U7WWYyyoO721FXhD6nKGI2M6rlnT923RLwhQCSMGTLoxi2KFD7OzJs?=
 =?iso-8859-1?Q?PVeQ34ZQiHcCujPHSJxswAdOdy+8tvTCJbhom4105LCtw2YPidOHyydeT/?=
 =?iso-8859-1?Q?gYh13GT2WevJCQZs2LkNmHC4XsmBXIIg3hDvJ8570DbLV8hjH0O1djQAXs?=
 =?iso-8859-1?Q?+y2IxcCw0sFfUS286qR5uXRI8LWTdrA4ZkB5vRBatX3dBKpEhyipiLKfD/?=
 =?iso-8859-1?Q?D0aWaI6PhWnIWpiPvFqPy71xCiqxYL/cLqu+YlEjMhDDrmSnWEV6CPSb9V?=
 =?iso-8859-1?Q?tVZI4DPpX1+1TTBrNNul3Nu8xbZrtMpJ9ibs78QddRoFB333515WJLxsNe?=
 =?iso-8859-1?Q?pjYS9K0ZYxxCwTU4T2vwpDqNL0WmRspyklpgjw1fzEuyqy7w0ABT5XUm2W?=
 =?iso-8859-1?Q?n7GHZcyoqL/HD/rulG0TPuIKoLfw4L4yY2kVu4tbups7jSnp/NL0XhvYcT?=
 =?iso-8859-1?Q?CEv61RpeMkN3x2y79sW+UVPdhdRy6VPTCNKwtz3ixXKk3JtuaGlJDoB/UN?=
 =?iso-8859-1?Q?MrswuMkvL+lEVJEz9XlcBllJA=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca2bd1b1-d2d6-4e69-31af-08d9bee4ec24
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:27.2470
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: srjvjyhM4KXgTORbS998EPN9Xp8+YAyT1IeXfJ44QFbEe6qaThdp+G2XjhWMoXb460rZLmaCbQlIVi1SLiJl4vZglk82YAM1byWvxiop6NU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6976
X-Proofpoint-ORIG-GUID: bnENPmIRLNVAf6yDf1GfFMAyvJYcr5gA
X-Proofpoint-GUID: bnENPmIRLNVAf6yDf1GfFMAyvJYcr5gA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0
 priorityscore=1501 suspectscore=0 mlxlogscore=999 spamscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

This is the implementation of SCI interface, called SCMI-SMC driver,
which works as the mediator between XEN Domains and Firmware (SCP, ATF etc)=
.
This allows devices from the Domains to work with clocks, resets and
power-domains without access to CPG.

The following features are implemented:
- request SCMI channels from ATF and pass channels to Domains;
- set device permissions for Domains based on the Domain partial
device-tree. Devices with permissions are able to work with clocks,
resets and power-domains via SCMI;
- redirect scmi messages from Domains to ATF.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 xen/arch/arm/Kconfig          |   2 +
 xen/arch/arm/sci/Kconfig      |  10 +
 xen/arch/arm/sci/Makefile     |   1 +
 xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
 xen/include/public/arch-arm.h |   1 +
 5 files changed, 809 insertions(+)
 create mode 100644 xen/arch/arm/sci/Kconfig
 create mode 100644 xen/arch/arm/sci/scmi_smc.c

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 186e1db389..02d96c6cfc 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -114,6 +114,8 @@ config SCI
 	  support. It allows guests to control system resourcess via one of
 	  SCI mediators implemented in XEN.
=20
+source "arch/arm/sci/Kconfig"
+
 endmenu
=20
 menu "ARM errata workaround via the alternative framework"
diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
new file mode 100644
index 0000000000..9563067ddc
--- /dev/null
+++ b/xen/arch/arm/sci/Kconfig
@@ -0,0 +1,10 @@
+config SCMI_SMC
+	bool "Enable SCMI-SMC mediator driver"
+	default n
+	depends on SCI
+	---help---
+
+	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
+	This feature allows drivers from Domains to work with System
+	Controllers (such as power,resets,clock etc.). SCP is used as transport
+	for communication.
diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
index 837dc7492b..67f2611872 100644
--- a/xen/arch/arm/sci/Makefile
+++ b/xen/arch/arm/sci/Makefile
@@ -1 +1,2 @@
 obj-y +=3D sci.o
+obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
new file mode 100644
index 0000000000..2eb01ea82d
--- /dev/null
+++ b/xen/arch/arm/sci/scmi_smc.c
@@ -0,0 +1,795 @@
+/*
+ * xen/arch/arm/sci/scmi_smc.c
+ *
+ * SCMI mediator driver, using SCP as transport.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <asm/sci/sci.h>
+#include <asm/smccc.h>
+#include <asm/io.h>
+#include <xen/bitops.h>
+#include <xen/config.h>
+#include <xen/sched.h>
+#include <xen/device_tree.h>
+#include <xen/iocap.h>
+#include <xen/init.h>
+#include <xen/err.h>
+#include <xen/lib.h>
+#include <xen/list.h>
+#include <xen/mm.h>
+#include <xen/string.h>
+#include <xen/time.h>
+#include <xen/vmap.h>
+
+#define SCMI_BASE_PROTOCOL                  0x10
+#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
+#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
+#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
+#define SCMI_BASE_DISCOVER_AGENT            0x7
+
+/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
+#define SCMI_SUCCESS              0
+#define SCMI_NOT_SUPPORTED      (-1)
+#define SCMI_INVALID_PARAMETERS (-2)
+#define SCMI_DENIED             (-3)
+#define SCMI_NOT_FOUND          (-4)
+#define SCMI_OUT_OF_RANGE       (-5)
+#define SCMI_BUSY               (-6)
+#define SCMI_COMMS_ERROR        (-7)
+#define SCMI_GENERIC_ERROR      (-8)
+#define SCMI_HARDWARE_ERROR     (-9)
+#define SCMI_PROTOCOL_ERROR     (-10)
+
+#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
+
+#define SCMI_SMC_ID                        "arm,smc-id"
+#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
+#define SCMI_SHMEM                         "shmem"
+
+#define HYP_CHANNEL                          0x0
+
+#define HDR_ID                             GENMASK(7,0)
+#define HDR_TYPE                           GENMASK(9, 8)
+#define HDR_PROTO                          GENMASK(17, 10)
+
+/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
+#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
+
+#define FIELD_GET(_mask, _reg)\
+    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
+#define FIELD_PREP(_mask, _val)\
+    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
+
+typedef struct scmi_msg_header {
+    uint8_t id;
+    uint8_t type;
+    uint8_t protocol;
+} scmi_msg_header_t;
+
+typedef struct scmi_perms_tx {
+    uint32_t agent_id;
+    uint32_t device_id;
+    uint32_t flags;
+} scmi_perms_tx_t;
+
+#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
+#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
+
+#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
+
+struct scmi_shared_mem {
+    uint32_t reserved;
+    uint32_t channel_status;
+    uint32_t reserved1[2];
+    uint32_t flags;
+    uint32_t length;
+    uint32_t msg_header;
+    uint8_t msg_payload[];
+};
+
+struct scmi_channel {
+    int chan_id;
+    int agent_id;
+    uint32_t func_id;
+    int domain_id;
+    uint64_t paddr;
+    struct scmi_shared_mem *shmem;
+    spinlock_t lock;
+    struct list_head list;
+};
+
+struct scmi_data {
+    struct list_head channel_list;
+    spinlock_t channel_list_lock;
+    bool initialized;
+    u64 shmem_addr, shmem_size;
+};
+
+static struct scmi_data scmi_data;
+
+/*
+ * pack_scmi_header() - packs and returns 32-bit header
+ *
+ * @hdr: pointer to header containing all the information on message id,
+ *    protocol id and type id.
+ *
+ * Return: 32-bit packed message header to be sent to the platform.
+ */
+static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
+{
+    return FIELD_PREP(HDR_ID, hdr->id) |
+        FIELD_PREP(HDR_TYPE, hdr->type) |
+        FIELD_PREP(HDR_PROTO, hdr->protocol);
+}
+
+/*
+ * unpack_scmi_header() - unpacks and records message and protocol id
+ *
+ * @msg_hdr: 32-bit packed message header sent from the platform
+ * @hdr: pointer to header to fetch message and protocol id.
+ */
+static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t =
*hdr)
+{
+    hdr->id =3D FIELD_GET(HDR_ID, msg_hdr);
+    hdr->type =3D FIELD_GET(HDR_TYPE, msg_hdr);
+    hdr->protocol =3D FIELD_GET(HDR_PROTO, msg_hdr);
+}
+
+static inline int channel_is_free(struct scmi_channel *chan_info)
+{
+    return ( chan_info->shmem->channel_status
+            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
+}
+
+static int send_smc_message(struct scmi_channel *chan_info,
+                            scmi_msg_header_t *hdr, void *data, int len)
+{
+    struct arm_smccc_res resp;
+    int ret;
+
+    printk(XENLOG_DEBUG "scmi: status =3D%d len=3D%d\n",
+           chan_info->shmem->channel_status, len);
+    printk(XENLOG_DEBUG "scmi: header id =3D %d type =3D %d, proto =3D %d\=
n",
+           hdr->id, hdr->type, hdr->protocol);
+
+    ret =3D channel_is_free(chan_info);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    chan_info->shmem->channel_status =3D 0x0;
+    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be set =
*/
+    chan_info->shmem->flags =3D 0x0;
+    chan_info->shmem->length =3D sizeof(chan_info->shmem->msg_header) + le=
n;
+    chan_info->shmem->msg_header =3D pack_scmi_header(hdr);
+
+    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
+           chan_info->shmem);
+    if ( len > 0 && data )
+        memcpy((void *)(chan_info->shmem->msg_payload), data, len);
+
+    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->chan_id=
,
+                  &resp);
+
+    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a0));
+
+    if ( resp.a0 )
+        return -EOPNOTSUPP;
+
+    return 0;
+}
+
+static int check_scmi_status(int scmi_status)
+{
+    if ( scmi_status =3D=3D SCMI_SUCCESS )
+        return 0;
+
+    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
+
+    switch ( scmi_status )
+    {
+    case SCMI_NOT_SUPPORTED:
+        return -EOPNOTSUPP;
+    case SCMI_INVALID_PARAMETERS:
+        return -EINVAL;
+    case SCMI_DENIED:
+        return -EACCES;
+    case SCMI_NOT_FOUND:
+        return -ENOENT;
+    case SCMI_OUT_OF_RANGE:
+        return -ERANGE;
+    case SCMI_BUSY:
+        return -EBUSY;
+    case SCMI_COMMS_ERROR:
+        return -ENOTCONN;
+    case SCMI_GENERIC_ERROR:
+        return -EIO;
+    case SCMI_HARDWARE_ERROR:
+        return -ENXIO;
+    case SCMI_PROTOCOL_ERROR:
+        return -EBADMSG;
+    }
+
+    return -EINVAL;
+}
+
+static int get_smc_response(struct scmi_channel *chan_info,
+                            scmi_msg_header_t *hdr, void *data, int len)
+{
+    int recv_len;
+    int ret;
+
+    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
+
+    ret =3D channel_is_free(chan_info);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    recv_len =3D chan_info->shmem->length - sizeof(chan_info->shmem->msg_h=
eader);
+
+    if ( recv_len < 0 )
+    {
+        printk(XENLOG_ERR
+               "scmi: Wrong size of smc message. Data may be invalid\n");
+        return -EINVAL;
+    }
+
+    if ( recv_len > len )
+    {
+        printk(XENLOG_ERR
+               "scmi: Not enough buffer for message %d, expecting %d\n",
+               recv_len, len);
+        return -EINVAL;
+    }
+
+    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
+
+    if ( recv_len > 0 )
+    {
+        memcpy(data, chan_info->shmem->msg_payload, recv_len);
+    }
+
+    return 0;
+}
+
+static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t *hd=
r, void *tx_data, int tx_size,
+                       void *rx_data, int rx_size)
+{
+    int ret =3D 0;
+
+    if ( !hdr )
+        return -EINVAL;
+
+    spin_lock(&channel->lock);
+
+    ret =3D send_smc_message(channel, hdr, tx_data, tx_size);
+    if ( ret )
+        goto clean;
+
+    ret =3D get_smc_response(channel, hdr, rx_data, rx_size);
+clean:
+    spin_unlock(&channel->lock);
+
+    return ret;
+}
+
+static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
+{
+    struct scmi_channel *curr;
+    bool found =3D false;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry(curr, &scmi_data.channel_list, list)
+        if ( curr->chan_id =3D=3D chan_id )
+        {
+            found =3D true;
+            break;
+        }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+    if ( found )
+        return curr;
+
+    return NULL;
+}
+
+static struct scmi_channel *get_channel_by_domain(uint8_t domain_id)
+{
+    struct scmi_channel *curr;
+    bool found =3D false;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry(curr, &scmi_data.channel_list, list)
+        if ( curr->domain_id =3D=3D domain_id )
+        {
+            found =3D true;
+            break;
+        }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+    if ( found )
+        return curr;
+
+    return NULL;
+}
+
+static struct scmi_channel *aquire_scmi_channel(int domain_id)
+{
+    struct scmi_channel *curr;
+    bool found =3D false;
+
+    ASSERT(domain_id !=3D DOMID_INVALID && domain_id >=3D 0);
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry(curr, &scmi_data.channel_list, list)
+        if ( (curr->domain_id =3D=3D DOMID_INVALID)
+            && (curr->chan_id !=3D HYP_CHANNEL) )
+        {
+            curr->domain_id =3D domain_id;
+            found =3D true;
+            break;
+        }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+    if ( found )
+        return curr;
+
+    return NULL;
+}
+
+static void relinquish_scmi_channel(struct scmi_channel *channel)
+{
+    spin_lock(&scmi_data.channel_list_lock);
+    ASSERT(channel !=3D NULL);
+    channel->domain_id =3D DOMID_INVALID;
+    spin_unlock(&scmi_data.channel_list_lock);
+}
+
+static struct scmi_channel *smc_create_channel(uint8_t chan_id,
+                                               uint32_t func_id, uint64_t =
addr)
+{
+    struct scmi_channel *channel;
+    mfn_t mfn;
+
+    channel =3D get_channel_by_id(chan_id);
+    if ( channel )
+        return ERR_PTR(EEXIST);
+
+    channel =3D xmalloc(struct scmi_channel);
+    if ( !channel )
+        return ERR_PTR(ENOMEM);
+
+    channel->chan_id =3D chan_id;
+    channel->func_id =3D func_id;
+    channel->domain_id =3D DOMID_INVALID;
+    mfn =3D maddr_to_mfn(addr);
+    channel->shmem =3D vmap(&mfn, 1);
+    if ( !channel->shmem )
+    {
+        xfree(channel);
+        return ERR_PTR(ENOMEM);
+    }
+
+    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->shmem)=
;
+    channel->paddr =3D addr;
+    channel->shmem->channel_status =3D SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE;
+    spin_lock_init(&channel->lock);
+    spin_lock(&scmi_data.channel_list_lock);
+    list_add(&channel->list, &scmi_data.channel_list);
+    spin_unlock(&scmi_data.channel_list_lock);
+    return channel;
+}
+
+static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t =
len)
+{
+    return iomem_permit_access(d, paddr_to_pfn(addr),
+                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
+}
+
+static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
+                                     uint64_t len)
+{
+    return iomem_deny_access(d, paddr_to_pfn(addr),
+                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
+}
+
+static int dt_update_domain_range(struct domain *d, uint64_t addr,
+                                  uint64_t size)
+{
+    struct dt_device_node *shmem_node;
+    __be32 *hw_reg;
+    const struct dt_property *pp;
+    uint32_t len;
+
+    shmem_node =3D dt_find_compatible_node(NULL, NULL, "arm,scmi-shmem");
+
+    if ( !shmem_node )
+    {
+        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI_SHM=
EM);
+        return -EINVAL;
+    }
+
+    pp =3D dt_find_property(shmem_node, "reg", &len);
+    if ( !pp )
+    {
+        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem node\n=
");
+        return -ENOENT;
+    }
+
+    hw_reg =3D pp->value;
+    dt_set_range(&hw_reg, shmem_node, addr, size);
+
+    return 0;
+}
+
+static void free_channel_list(void)
+{
+    struct scmi_channel *curr, *_curr;
+
+    spin_lock(&scmi_data.channel_list_lock);
+    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, list)
+    {
+        vunmap(curr->shmem);
+        list_del(&curr->list);
+        xfree(curr);
+    }
+
+    spin_unlock(&scmi_data.channel_list_lock);
+}
+
+static __init bool scmi_probe(struct dt_device_node *scmi_node)
+{
+    struct dt_device_node *shmem_node;
+    int ret, i;
+    struct scmi_channel *channel, *agent_channel;
+    int n_agents;
+    scmi_msg_header_t hdr;
+    struct rx_t {
+        int32_t status;
+        uint32_t attributes;
+    } rx;
+
+    uint32_t func_id;
+
+    ASSERT(scmi_node !=3D NULL);
+
+    INIT_LIST_HEAD(&scmi_data.channel_list);
+    spin_lock_init(&scmi_data.channel_list_lock);
+
+    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
+    {
+        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
+        return false;
+    }
+
+    shmem_node =3D dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);
+    if ( IS_ERR_OR_NULL(shmem_node) )
+    {
+        printk(XENLOG_ERR
+               "scmi: Device tree error, can't parse shmem phandle %ld\n",
+               PTR_ERR(shmem_node));
+        return false;
+    }
+
+    ret =3D dt_device_get_address(shmem_node, 0, &scmi_data.shmem_addr,
+                                &scmi_data.shmem_size);
+    if ( IS_ERR_VALUE(ret) )
+        return false;
+
+    channel =3D smc_create_channel(HYP_CHANNEL, func_id, scmi_data.shmem_a=
ddr);
+    if ( IS_ERR(channel) )
+        return false;
+
+    hdr.id =3D SCMI_BASE_PROTOCOL_ATTIBUTES;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    ret =3D do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
+    if ( ret )
+        goto clean;
+
+    ret =3D check_scmi_status(rx.status);
+    if ( ret )
+        goto clean;
+
+    n_agents =3D FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
+    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
+
+    n_agents =3D (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
+        scmi_data.shmem_size / PAGE_SIZE : n_agents;
+
+    for ( i =3D 1; i < n_agents; i++ )
+    {
+        uint32_t tx_agent_id =3D 0xFFFFFFFF;
+        struct {
+            int32_t status;
+            uint32_t agent_id;
+            char name[16];
+        } da_rx;
+
+        agent_channel =3D smc_create_channel(i, func_id, scmi_data.shmem_a=
ddr +
+                                           i * PAGE_SIZE);
+        if ( IS_ERR(agent_channel) )
+        {
+            ret =3D PTR_ERR(agent_channel);
+            goto clean;
+        }
+
+        hdr.id =3D SCMI_BASE_DISCOVER_AGENT;
+        hdr.type =3D 0;
+        hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+        ret =3D do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
+                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
+        if ( ret )
+            goto clean;
+
+        ret =3D check_scmi_status(da_rx.status);
+        if ( ret )
+            goto clean;
+
+        printk(XENLOG_DEBUG "scmi: status=3D0x%x id=3D0x%x name=3D%s\n",
+                da_rx.status, da_rx.agent_id, da_rx.name);
+
+        agent_channel->agent_id =3D da_rx.agent_id;
+    }
+
+    scmi_data.initialized =3D true;
+    return true;
+
+clean:
+    free_channel_list();
+    return ret =3D=3D 0;
+}
+
+static int scmi_domain_init(struct domain *d)
+{
+    struct scmi_channel *channel;
+    int ret;
+
+    if ( !scmi_data.initialized )
+        return 0;
+
+    channel =3D aquire_scmi_channel(d->domain_id);
+    if ( IS_ERR_OR_NULL(channel) )
+        return -ENOENT;
+
+    printk(XENLOG_INFO "scmi: Aquire SCMI channel id =3D 0x%x , domain_id =
=3D %d"
+           "paddr =3D 0x%lx\n", channel->chan_id, channel->domain_id,
+           channel->paddr);
+
+    if ( is_hardware_domain(d) )
+    {
+        ret =3D map_memory_to_domain(d, scmi_data.shmem_addr,
+                                   scmi_data.shmem_size);
+        if ( IS_ERR_VALUE(ret) )
+            goto error;
+
+        ret =3D dt_update_domain_range(d, channel->paddr, PAGE_SIZE);
+        if ( IS_ERR_VALUE(ret) )
+        {
+            int rc =3D unmap_memory_from_domain(d, scmi_data.shmem_addr,
+                                              scmi_data.shmem_size);
+            if ( rc )
+                printk(XENLOG_ERR "Unable to unmap_memory_from_domain\n");
+
+            goto error;
+        }
+    }
+
+    d->arch.sci =3D channel;
+
+    return 0;
+error:
+    relinquish_scmi_channel(channel);
+
+    return ret;
+}
+
+static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_devid)
+{
+    struct scmi_channel *channel, *agent_channel;
+    scmi_msg_header_t hdr;
+    scmi_perms_tx_t tx;
+    struct rx_t {
+        int32_t status;
+        uint32_t attributes;
+    } rx;
+    int ret;
+
+    if ( !scmi_data.initialized )
+        return 0;
+
+    printk(XENLOG_DEBUG "scmi: scmi_devid =3D %d\n", scmi_devid);
+
+    agent_channel =3D get_channel_by_domain(d->domain_id);
+    if ( IS_ERR_OR_NULL(agent_channel) )
+        return PTR_ERR(agent_channel);
+
+    channel =3D get_channel_by_id(HYP_CHANNEL);
+    if ( IS_ERR_OR_NULL(channel) )
+        return PTR_ERR(channel);
+
+    hdr.id =3D SCMI_BASE_SET_DEVICE_PERMISSIONS;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    tx.agent_id =3D agent_channel->agent_id;
+    tx.device_id =3D scmi_devid;
+    tx.flags =3D SCMI_ALLOW_ACCESS;
+
+    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&rx));
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    ret =3D check_scmi_status(rx.status);
+    if ( IS_ERR_VALUE(ret) )
+        return ret;
+
+    return 0;
+}
+
+static int scmi_add_dt_device(struct domain *d, struct dt_device_node *dev=
)
+{
+    uint32_t scmi_devid;
+
+    if ( (!scmi_data.initialized) || (!d->arch.sci) )
+        return 0;
+
+    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
+        return 0;
+
+    printk(XENLOG_INFO "scmi: dt_node =3D %s\n", dt_node_full_name(dev));
+
+    return scmi_add_device_by_devid(d, scmi_devid);
+}
+
+static int scmi_relinquish_resources(struct domain *d)
+{
+    int ret;
+    struct scmi_channel *channel, *agent_channel;
+    scmi_msg_header_t hdr;
+    struct reset_agent_tx {
+        uint32_t agent_id;
+        uint32_t flags;
+    } tx;
+    uint32_t rx;
+
+    if ( !d->arch.sci )
+        return 0;
+
+    agent_channel =3D d->arch.sci;
+
+    spin_lock(&agent_channel->lock);
+    tx.agent_id =3D agent_channel->agent_id;
+    spin_unlock(&agent_channel->lock);
+
+    channel =3D get_channel_by_id(HYP_CHANNEL);
+    if ( !channel )
+    {
+        printk(XENLOG_ERR
+               "scmi: Unable to get Hypervisor scmi channel for domain %d\=
n",
+               d->domain_id);
+        return -EINVAL;
+    }
+
+    hdr.id =3D SCMI_BASE_RESET_AGENT_CONFIGURATION;
+    hdr.type =3D 0;
+    hdr.protocol =3D SCMI_BASE_PROTOCOL;
+
+    tx.flags =3D 0;
+
+    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx));
+    if ( ret )
+        return ret;
+
+    ret =3D check_scmi_status(rx);
+
+    return ret;
+}
+
+static void scmi_domain_destroy(struct domain *d)
+{
+    struct scmi_channel *channel;
+
+    if ( !d->arch.sci )
+        return;
+
+    channel =3D d->arch.sci;
+    spin_lock(&channel->lock);
+
+    relinquish_scmi_channel(channel);
+    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
+
+    d->arch.sci =3D NULL;
+
+    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
+    spin_unlock(&channel->lock);
+    return;
+}
+
+static bool scmi_handle_call(struct domain *d, void *args)
+{
+    bool res =3D false;
+    struct scmi_channel *agent_channel;
+    struct arm_smccc_res resp;
+    struct cpu_user_regs *regs =3D args;
+
+    if ( !d->arch.sci )
+        return false;
+
+    agent_channel =3D d->arch.sci;
+    spin_lock(&agent_channel->lock);
+
+    if ( agent_channel->func_id !=3D regs->x0 )
+    {
+        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
+        goto unlock;
+    }
+
+    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
+                  agent_channel->chan_id, &resp);
+
+    set_user_reg(regs, 0, resp.a0);
+    set_user_reg(regs, 1, resp.a1);
+    set_user_reg(regs, 2, resp.a2);
+    set_user_reg(regs, 3, resp.a3);
+    res =3D true;
+unlock:
+    spin_unlock(&agent_channel->lock);
+
+    return res;
+}
+
+static int scmi_get_channel_paddr(void *scmi_ops,
+                           struct xen_arch_domainconfig *config)
+{
+    struct scmi_channel *agent_channel =3D scmi_ops;
+
+    if ( !agent_channel )
+        return -EINVAL;
+
+    config->sci_agent_paddr =3D agent_channel->paddr;
+    return 0;
+}
+
+static const struct dt_device_match scmi_smc_match[] __initconst =3D
+{
+    DT_MATCH_SCMI_SMC,
+    { /* sentinel */ },
+};
+
+static const struct sci_mediator_ops scmi_ops =3D
+{
+    .probe =3D scmi_probe,
+    .domain_init =3D scmi_domain_init,
+    .domain_destroy =3D scmi_domain_destroy,
+    .add_dt_device =3D scmi_add_dt_device,
+    .relinquish_resources =3D scmi_relinquish_resources,
+    .handle_call =3D scmi_handle_call,
+    .get_channel_info =3D scmi_get_channel_paddr
+};
+
+REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_SCMI_SMC=
,
+                      scmi_smc_match, &scmi_ops);
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 9180be5e86..a67237942d 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
 #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
=20
 #define XEN_DOMCTL_CONFIG_SCI_NONE      0
+#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
=20
 struct xen_arch_domainconfig {
     /* IN/OUT */
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246488.425130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cr-0008VN-BL; Tue, 14 Dec 2021 09:34:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246488.425130; Tue, 14 Dec 2021 09:34:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cr-0008VC-6s; Tue, 14 Dec 2021 09:34:45 +0000
Received: by outflank-mailman (input) for mailman id 246488;
 Tue, 14 Dec 2021 09:34:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Cp-0007DW-9a
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:43 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 100e8040-5cc1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:34:41 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE8mM0e003673;
 Tue, 14 Dec 2021 09:34:31 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxr33874b-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:31 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR2PR03MB5162.eurprd03.prod.outlook.com (2603:10a6:101:26::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 09:34:25 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 100e8040-5cc1-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UwMCwwQXqjdWHPoSIBNlXW/2kkQyifJHYa+QPpeSwcRB7t1lx1HlqFsJvsgv9vEakc7Pn2D1k6AMcs7G4T7tQBREewIztTHdaTCXm1yJIQa3xD5qs84q8Dy8hq1e7S27+LevN4pJeX0K7UeJz3bqSiq4fOiRn1UMqKO9RoaCd+gmTSLbf5kUCr2mLU7qzWGAaFOepjw3141inXlNv+BwSREZ7G3PdKv2b6cwMdqdf9dwa/VGMENLgUlcz0nANTlvrb8bRp6OyzL/gQo2cX69Bgt5g+GDnnn/oTaY4w7qBNCJ8C7/1bqcgiNY+MM756/Wf99Zami+PpXE1RGzJitFKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5HKrYB6SvkH+0z8vtwa49lxvxU4I58QQAwDDiPC1Yg8=;
 b=exkoGv/nni6YNhrwNCGwJa/o3/hHlAJYN99pZwxec5yZFjuKnQUqi8g4ZL95U//u2DlPJLzL/ePdBw702dvNDGB72jUrE4ne6x3vNgZEyxaaedYPvNTRCHxP8PP1v+y3XNUWbCzBMNaHStRjvWwSlt7QkjlCcSgurnMlFts/D1kzAsTlRPrRIJYtD31Zs7xIaag7ppbZYXfhHGdkitzVfN/5AYM6wEc15ZOEtXJl+dYjD/YXfHS8sQO55BMFSBx3q6VirlO4D2QqB3L2KubVFRiOtKKfXfksd246xhSngqncjEcryKLCNyVuXcE0XecbeVxSZfRpn8W4qLIDhJv+hw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5HKrYB6SvkH+0z8vtwa49lxvxU4I58QQAwDDiPC1Yg8=;
 b=Ty4slgKMwrGKaBsjf+B2udHjXAv2RU8B5k6EkwDLHamKtqSEODDL5b3bUoRWtVngybn/pmeNvTWxqnUOyZKJffFkbrMPEjAa2GHZ6NfdQBiCF9Nk6CN27lE2vyPOyyrneR4e2x0T51wpOxObEu3j/xP4eyUPTsIGBqCTzyFvCFchGnkIKoobPOOT0GqaxoZ0OzBHDBLcQYnhh4x+7KYtudMvMxtTe1ZuWRlgXbV9EWJixgPCAncOuI+GBPX0F5l2f5iIN19HBm0gG3KeKLD6vGqzMm5QcguNXL2hr4KEomNF74by+Gd6HLrdFIgiC7Nd0hLK1BrEF682VnRApcdFOA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v1 2/5] xen/arm: add generic SCI mediator framework
Thread-Topic: [RFC v1 2/5] xen/arm: add generic SCI mediator framework
Thread-Index: AQHX8M3IB9WR9OXgbE2xll7qsLGWCw==
Date: Tue, 14 Dec 2021 09:34:24 +0000
Message-ID: 
 <c0afe4837fe99e7f7921fc43b130aa2234f234be.1639472078.git.oleksii_moisieiev@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e8ab3c2b-0600-422c-935b-08d9bee4ead6
x-ms-traffictypediagnostic: PR2PR03MB5162:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB51629015715B55D1DF6A15D7E3759@PR2PR03MB5162.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Lr+EizdDW3+1EkhjMTkYs51YyfAHaFeV8ARQ6c+fXlL+W5JJQhTblV2bw7AnzpfyUfx41UUIxf6GErurKQLo9Jzu/NPGbJgf6r2sbmkytup6yZgeAkJ0O7Q3Gc8XsrWMDsXmP+PBTjaR9FPeS+RHbCRv6B5BJUPgxVoVPYwyI4mQ5wYK1MIGQ72tdvuWbLU1WbdAMEOXKyNJ5zgHanrralo3rxTSlxEMREUdSibc47aQzYdXc9kqcfAmBYEsAY8gmsnXjvbz3f4nDltil/oWnaDu6njSn5Zsr6PwnuyoeUEuteAPDE8nn7kskUz4I+UOv39croeIbcyJdG1UUEHA4+Nl0A/lcXIxpWbnufaaPkpxSLhQ8Sf7q2YCqXLF6aVcUtMRZnU/zWXZeT9HsVcXdm4sKIkE0sPfYZl8fkInpD4+7wddZxu9n62vky5PTlSrkktflv/2KI9dv6fXWu5CQxBsriGqi66e2e6dldRVLFPXr0PclJLkJLVR1M/4xAV1NuwgReDmqa3O30nsyJ1lGy3qNJpYdEOVaDbwIWzOxQAbw9GF13mZWTGcVwX/OF52pyNjD8VMspnJU00gxR6MM5db3TuGUjHIo/7Jzr/fB/09btyxbBAugnSYKifrhxu5Xyf305BcYpd3y+UXmEin7SrcUnSUd6U5Q6Gece7+oIlqLEdk6hbYxZcphNQbZXWxjYzUwfuAU5vMNfqVO72SOgrstYvOW8sy+R8V8rv0CGZiCgmvoXbQzFLB5s/I9pTpLJI6/gsaWOqQC2xZYrE3Yw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(30864003)(5660300002)(38070700005)(38100700002)(8676002)(4326008)(316002)(122000001)(2616005)(36756003)(54906003)(6512007)(186003)(26005)(66476007)(66556008)(83380400001)(64756008)(66446008)(2906002)(6486002)(71200400001)(76116006)(6506007)(86362001)(8936002)(91956017)(66946007)(6916009)(41533002)(21314003)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?PF+a1wDPNITxYzO+CVWLhv6cupeYFD4x4az5b/Fw7baZ2ZiWdNurw3J+Ed?=
 =?iso-8859-1?Q?lrAyyuJXWs6Y3VcNxhNaqa70WJ3sEUT60ejR8ifTplaf7Wjfz6AhnTQ/xk?=
 =?iso-8859-1?Q?cCdt1NsnS1SG7EFASg6sPI5rnxUv/F8P2KoD4+QaosXvxiuias0h47hXra?=
 =?iso-8859-1?Q?ek90V8P/g8xk9xb6nJyIU7JfB9sTd6FXMDv0sH0Xb/DfNzqV1ctI6VKl4U?=
 =?iso-8859-1?Q?+9yo94sfG2Z7CzjldJn8EdUxQbqv4tw+dfztT298LTsGsFoGjnqLvMk2T6?=
 =?iso-8859-1?Q?okTp0Jj/VsE1VayD/jQNr7MJ+NIJ1stPOIPUf4qedLwSX0JWJdxlbzwiTt?=
 =?iso-8859-1?Q?lxBlM0CFinxlqx91ZLoNlwNXg3l2GmYcOcjY/kdxTKeRdEy8f6vqSwQWjT?=
 =?iso-8859-1?Q?UYVVTyr8KDa6rWggn5PmL2r5mCRmPzIwfGLpPM7oPCmfLfe/0H2icE/rz2?=
 =?iso-8859-1?Q?UJUkuX9SIZ98jnVf90yZc6WO8CV9BSK0ZXhk+i4zLfl7HG8sUALPQLNgRq?=
 =?iso-8859-1?Q?StrvVwTTjxEjoZO3m8aj55jZ4/5wxz5rG+OqT6C0wDBDPQI0CEZLKCHwt6?=
 =?iso-8859-1?Q?Prl+Px8JYf3aAyBqp11HnYaCT+O7LrzxJOS6KQyo+kUL3sRHwRr910oN5F?=
 =?iso-8859-1?Q?dkj0ibmB0LYPPUVitQIE8/1g2x4pwY7RcijVa16qPCkQeiXEuf8vkZaCOo?=
 =?iso-8859-1?Q?H9+MrjEr2Vieo3FEuTRxmPBSOvOyRgZNTPKYNaxeAD4s+pekQLd3uqOMvv?=
 =?iso-8859-1?Q?L9+ztoAxveJRjp5fugJ8lMa1Wtz90ZHFVFCn/b06si7t7tQa4R36bienUS?=
 =?iso-8859-1?Q?3/gt9UK5AkVjKzg/hQHKP6fDnpHLVYzrW4/p/6cdWxukSOxNXLpdTMsh17?=
 =?iso-8859-1?Q?LIUh1Sa9LxYFf3rdIVuWKsaPaqYXCtlF9104StSkn4airCPuBo4vt2YdCI?=
 =?iso-8859-1?Q?vR/vuJn8uCx0xSMmSoMhld8bzqzXva9iaIxfpL30WmjhxEn9AmhgLTIXxR?=
 =?iso-8859-1?Q?bSK1X3s0ga8GUEIibzDwxfQiFvwxGkuSRHNtHnKD4NQjKmPWmFjYK8/IRz?=
 =?iso-8859-1?Q?joyifMIFtQ50GGHpxZkXBcrhJsv/DpgAdLN/pmYswnDH1QDsnsnTu0H8Qm?=
 =?iso-8859-1?Q?YM4mUm0r0z6xFzV/k1RLng6mEtQphDKM0mNyucYXVEjgkiur3Yr7IrPoxo?=
 =?iso-8859-1?Q?1W385XTfEFRCFHP5VrqfEuBNh+PZW8kTCCVPl3IjAkKP7WCubYIR4V6h7W?=
 =?iso-8859-1?Q?uI0DZC3WKTsDSqxw/Je6E/zeHLqlRIMypQe+35X6xykRKADwHvlS0YHV8/?=
 =?iso-8859-1?Q?ZU9X3UOmpN1+zrbYp/z0t9ev47KJWtScb6ZNmFQxLRYjJqmJ3pnwDNi2YR?=
 =?iso-8859-1?Q?oSncDe0rK2Qzw7GwW0jW+IXS1pIOSMjgvWTZEEcEft1V+q/mVizDo7XjTe?=
 =?iso-8859-1?Q?ELwTjkKM9Ws7RZem6j6lglK7btpg14EHPe5NqDrY5xKh0y+zVCRsI20MaZ?=
 =?iso-8859-1?Q?y2cfaAU5kU+VwHOAgwEA7NV1+KLIXp2wx7XkD0a46F7YN6+tE2OX4JMNgS?=
 =?iso-8859-1?Q?YvG7F5YvQlZh7Q5Wq9EfVkTwjYq1dTZG7DRNAKLsMQ2InWLRLjX3svkLmV?=
 =?iso-8859-1?Q?9qiyG6bQtBtOBZsHjppKiutPcunHtgmJXEQLChTuzlHGNan7/1/edF+tCO?=
 =?iso-8859-1?Q?wQu2g7bfa68DLc53hz97m2l7J0hJ1vCa+Hy/ZlTHa+wCRIpaZE2/v2bbBn?=
 =?iso-8859-1?Q?iG38K3872OWZzugmMthC7nJpY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8ab3c2b-0600-422c-935b-08d9bee4ead6
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:25.0294
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RfqdyPuxzpK6fVl6BWZCRh4B0qxyja2icLr2P17aFoi0M0sb2PDsGY4FW6M9rRx0f1R2uC9DFJUED9BG5sQ7NsCJzR2J7eSLsAKmmjESwPA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5162
X-Proofpoint-ORIG-GUID: wlhcHQlPM2w9Xz2Hror1NT-CP53P_nvL
X-Proofpoint-GUID: wlhcHQlPM2w9Xz2Hror1NT-CP53P_nvL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0
 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0
 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

This patch adds the basic framework for SCI mediator.
SCI is System Control Interface, which is designed to redirect
requests for the Hardware (such as power-domain/clock/resets etc)
from the Domains to the firmware. Originally, cpg should be passed
to the domain so it can work with power-domains/clocks/resets etc.
Considering that cpg can't be split between the Domains, we get the
limitation that the devices, which are using power-domains/clocks/resets
etc, couldn't be split between the domains.
The solution is to move the power-domain/clock/resets etc to the
Firmware (such as SCP firmware or ATF) and provide interface for the Domain=
s.
XEN shoud have an entity, caled SCI-Mediator, which is responsible for mess=
ages
redirection between Domains and Firmware and for permission handling.

This is how it works: user can build XEN with multiple SCI mediators.
See the next patches, where SCMI-SMC mediator is introduced.
SCI mediator register itself with REGISTER_SCI_MEDIATOR() macro.

At run-time, during initialization, framework calls probe for the first
matching device in the device-tree. When no device-tree is present - the
first registered mediator should be probed.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 MAINTAINERS                    |   6 ++
 xen/arch/arm/Kconfig           |   8 ++
 xen/arch/arm/Makefile          |   1 +
 xen/arch/arm/domain.c          |  24 +++++
 xen/arch/arm/domain_build.c    |  11 +++
 xen/arch/arm/platforms/rcar3.c |   3 +-
 xen/arch/arm/sci/Makefile      |   1 +
 xen/arch/arm/sci/sci.c         | 128 ++++++++++++++++++++++++++
 xen/arch/arm/setup.c           |   1 +
 xen/arch/arm/xen.lds.S         |   7 ++
 xen/include/asm-arm/domain.h   |   4 +
 xen/include/asm-arm/sci/sci.h  | 162 +++++++++++++++++++++++++++++++++
 xen/include/public/arch-arm.h  |  10 ++
 13 files changed, 365 insertions(+), 1 deletion(-)
 create mode 100644 xen/arch/arm/sci/Makefile
 create mode 100644 xen/arch/arm/sci/sci.c
 create mode 100644 xen/include/asm-arm/sci/sci.h

diff --git a/MAINTAINERS b/MAINTAINERS
index e43dc0edce..5f96ea35ba 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -512,6 +512,12 @@ S:	Supported
 F:	xen/arch/arm/tee/
 F:	xen/include/asm-arm/tee
=20
+SCI MEDIATORS
+M:	Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+S:	Supported
+F:	xen/arch/arm/sci
+F:	xen/include/asm-arm/sci
+
 TOOLSTACK
 M:	Wei Liu <wl@xen.org>
 S:	Supported
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..186e1db389 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -106,6 +106,14 @@ config TEE
=20
 source "arch/arm/tee/Kconfig"
=20
+config SCI
+	bool "Enable SCI mediators support"
+	default n
+	help
+	  This option enables generic SCI (System Control Interface) mediators
+	  support. It allows guests to control system resourcess via one of
+	  SCI mediators implemented in XEN.
+
 endmenu
=20
 menu "ARM errata workaround via the alternative framework"
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index 07f634508e..6366ff55e5 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -8,6 +8,7 @@ obj-y +=3D platforms/
 endif
 obj-$(CONFIG_TEE) +=3D tee/
 obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
+obj-$(CONFIG_SCI) +=3D sci/
=20
 obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
 obj-y +=3D bootfdt.init.o
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 96e1b23550..80d0a23767 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -34,6 +34,7 @@
 #include <asm/platform.h>
 #include <asm/procinfo.h>
 #include <asm/regs.h>
+#include <asm/sci/sci.h>
 #include <asm/tee/tee.h>
 #include <asm/vfp.h>
 #include <asm/vgic.h>
@@ -688,6 +689,13 @@ int arch_sanitise_domain_config(struct xen_domctl_crea=
tedomain *config)
         return -EINVAL;
     }
=20
+    if ( config->arch.sci_type !=3D XEN_DOMCTL_CONFIG_SCI_NONE &&
+         config->arch.sci_type !=3D sci_get_type() )
+    {
+        dprintk(XENLOG_INFO, "Unsupported SCI type\n");
+        return -EINVAL;
+    }
+
     return 0;
 }
=20
@@ -764,6 +772,15 @@ int arch_domain_create(struct domain *d,
         /* At this stage vgic_reserve_virq should never fail */
         if ( !vgic_reserve_virq(d, GUEST_EVTCHN_PPI) )
             BUG();
+
+        if ( config->arch.sci_type !=3D XEN_DOMCTL_CONFIG_SCI_NONE )
+        {
+            if ( (rc =3D sci_domain_init(d, config->arch.sci_type)) !=3D 0=
)
+                goto fail;
+
+            if ( (rc =3D sci_get_channel_info(d, &config->arch)) !=3D 0)
+                goto fail;
+        }
     }
=20
     /*
@@ -796,6 +813,7 @@ void arch_domain_destroy(struct domain *d)
     domain_vgic_free(d);
     domain_vuart_free(d);
     free_xenheap_page(d->shared_info);
+    sci_domain_destroy(d);
 #ifdef CONFIG_ACPI
     free_xenheap_pages(d->arch.efi_acpi_table,
                        get_order_from_bytes(d->arch.efi_acpi_len));
@@ -996,6 +1014,7 @@ enum {
     PROG_xen,
     PROG_page,
     PROG_mapping,
+    PROG_sci,
     PROG_done,
 };
=20
@@ -1056,6 +1075,11 @@ int domain_relinquish_resources(struct domain *d)
         if ( ret )
             return ret;
=20
+    PROGRESS(sci):
+        ret =3D sci_relinquish_resources(d);
+        if ( ret )
+            return ret;
+
     PROGRESS(done):
         break;
=20
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d02bacbcd1..38874615dd 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -22,6 +22,7 @@
 #include <asm/kernel.h>
 #include <asm/setup.h>
 #include <asm/tee/tee.h>
+#include <asm/sci/sci.h>
 #include <asm/platform.h>
 #include <asm/psci.h>
 #include <asm/setup.h>
@@ -1894,6 +1895,10 @@ static int __init handle_device(struct domain *d, st=
ruct dt_device_node *dev,
                 return res;
             }
         }
+
+        res =3D sci_add_dt_device(d, dev);
+        if ( res < 0 )
+            return res;
     }
=20
     res =3D handle_device_interrupts(d, dev, need_mapping);
@@ -3075,6 +3080,10 @@ static int __init construct_dom0(struct domain *d)
     if ( rc < 0 )
         return rc;
=20
+    rc =3D sci_domain_init(d, sci_get_type());
+    if ( rc < 0 )
+        return rc;
+
     if ( acpi_disabled )
         rc =3D prepare_dtb_hwdom(d, &kinfo);
     else
@@ -3109,6 +3118,8 @@ void __init create_dom0(void)
     dom0_cfg.arch.tee_type =3D tee_get_type();
     dom0_cfg.max_vcpus =3D dom0_max_vcpus();
=20
+    dom0_cfg.arch.sci_type =3D sci_get_type();
+
     if ( iommu_enabled )
         dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu;
=20
diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.=
c
index d740145c71..a268b09454 100644
--- a/xen/arch/arm/platforms/rcar3.c
+++ b/xen/arch/arm/platforms/rcar3.c
@@ -18,10 +18,11 @@
  */
=20
 #include <asm/platform.h>
+#include <asm/sci/sci.h>
=20
 static bool rcar3_smc(struct cpu_user_regs *regs)
 {
-    return false;
+    return sci_handle_call(current->domain, regs);
 }
=20
 static const char *const rcar3_dt_compat[] __initconst =3D
diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
new file mode 100644
index 0000000000..837dc7492b
--- /dev/null
+++ b/xen/arch/arm/sci/Makefile
@@ -0,0 +1 @@
+obj-y +=3D sci.o
diff --git a/xen/arch/arm/sci/sci.c b/xen/arch/arm/sci/sci.c
new file mode 100644
index 0000000000..5961b4cd5d
--- /dev/null
+++ b/xen/arch/arm/sci/sci.c
@@ -0,0 +1,128 @@
+/*
+ * xen/arch/arm/sci/sci.c
+ *
+ * Generic part of SCI mediator driver
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <xen/errno.h>
+#include <xen/init.h>
+#include <xen/sched.h>
+#include <xen/types.h>
+
+#include <asm/sci/sci.h>
+
+extern const struct sci_mediator_desc _sscimediator[], _escimediator[];
+static const struct sci_mediator_desc __read_mostly *cur_mediator;
+
+bool sci_handle_call(struct domain *d, void *args)
+{
+    if ( unlikely(!cur_mediator) )
+        return false;
+
+    return cur_mediator->ops->handle_call(d, args);
+}
+
+int sci_domain_init(struct domain *d, uint16_t sci_type)
+{
+    if ( sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_NONE )
+        return 0;
+
+    if ( unlikely(!cur_mediator) )
+        return -ENODEV;
+
+    if ( cur_mediator->sci_type !=3D sci_type )
+        return -EINVAL;
+
+    return cur_mediator->ops->domain_init(d);
+}
+
+void sci_domain_destroy(struct domain *d)
+{
+    if ( unlikely(!cur_mediator) )
+        return;
+
+    cur_mediator->ops->domain_destroy(d);
+}
+
+int sci_relinquish_resources(struct domain *d)
+{
+    if ( unlikely(!cur_mediator) )
+        return 0;
+
+    return cur_mediator->ops->relinquish_resources(d);
+}
+
+
+int sci_add_dt_device(struct domain *d, struct dt_device_node *dev)
+{
+    if ( unlikely(!cur_mediator) )
+        return 0;
+
+    return cur_mediator->ops->add_dt_device(d, dev);
+}
+
+int sci_get_channel_info(struct domain *d,
+                         struct xen_arch_domainconfig *config)
+{
+    if ( unlikely(!cur_mediator) )
+        return 0;
+
+    return cur_mediator->ops->get_channel_info(d->arch.sci, config);
+}
+
+uint16_t sci_get_type(void)
+{
+    if ( unlikely(!cur_mediator) )
+        return XEN_DOMCTL_CONFIG_SCI_NONE;
+
+    return cur_mediator->sci_type;
+}
+
+static int __init sci_init(void)
+{
+    const struct sci_mediator_desc *desc;
+    struct dt_device_node *dt =3D NULL;
+
+    for ( desc =3D _sscimediator; desc !=3D _escimediator; desc++ )
+    {
+        if ( likely(dt_host) )
+        {
+            dt =3D dt_find_matching_node(dt_host, desc->dt_match);
+            if ( !dt )
+                continue;
+        }
+
+        if ( desc->ops->probe(dt) )
+        {
+            printk(XENLOG_INFO "Using SCI mediator for %s\n", desc->name);
+            cur_mediator =3D desc;
+            return 0;
+        }
+    }
+
+    return 0;
+}
+
+__initcall(sci_init);
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d5d0792ed4..201de01411 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -50,6 +50,7 @@
 #include <asm/cpufeature.h>
 #include <asm/platform.h>
 #include <asm/procinfo.h>
+#include <asm/sci/sci.h>
 #include <asm/setup.h>
 #include <xsm/xsm.h>
 #include <asm/acpi.h>
diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
index 08016948ab..3683f4821f 100644
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -142,6 +142,13 @@ SECTIONS
       _eteemediator =3D .;
   } :text
=20
+  . =3D ALIGN(8);
+  .scimediator.info : {
+      _sscimediator =3D .;
+      *(.scimediator.info)
+      _escimediator =3D .;
+  } :text
+
   . =3D ALIGN(PAGE_SIZE);             /* Init code and data */
   __init_begin =3D .;
   .init.text : {
diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
index 9b3647587a..d9b164017f 100644
--- a/xen/include/asm-arm/domain.h
+++ b/xen/include/asm-arm/domain.h
@@ -89,6 +89,10 @@ struct arch_domain
 #ifdef CONFIG_TEE
     void *tee;
 #endif
+
+#ifdef CONFIG_SCI
+    void *sci;
+#endif
 }  __cacheline_aligned;
=20
 struct arch_vcpu
diff --git a/xen/include/asm-arm/sci/sci.h b/xen/include/asm-arm/sci/sci.h
new file mode 100644
index 0000000000..aeff689c72
--- /dev/null
+++ b/xen/include/asm-arm/sci/sci.h
@@ -0,0 +1,162 @@
+/*
+ * xen/include/asm-arm/sci/sci.h
+ *
+ * Generic part of the SCI (System Control Interface) subsystem.
+ *
+ * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
+ * Copyright (C) 2021, EPAM Systems.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __ASM_ARM_SCI_H
+#define __ASM_ARM_SCI_H
+
+#include <xen/lib.h>
+#include <xen/types.h>
+#include <xen/device_tree.h>
+
+#ifdef CONFIG_SCI
+
+struct sci_mediator_ops {
+
+    /*
+     * Probe for SCI. Should return true if SCI found and
+     * mediator is initialized.
+     */
+    bool (*probe)(struct dt_device_node *scmi_node);
+
+    /*
+     * Called during domain construction if toolstack requests to enable
+     * SCI support so mediator can inform SCP-firmware about new
+     * guest and create own structures for the new domain.
+     */
+    int (*domain_init)(struct domain *d);
+
+    /*
+     * Called during domain destruction, releases all resources, that
+     * were allocated by the mediator.
+     */
+    void (*domain_destroy)(struct domain *d);
+
+    /*
+     * Called during parsing partial device-sci for the domain.
+     * Passing device_node so mediator could process the device and
+     * mark the device as related to the domain if needed.
+     */
+    int (*add_dt_device)(struct domain *d, struct dt_device_node *dev);
+
+    /*
+     * Called during domain destruction to relinquish resources used
+     * by mediator itself. This function can return -ERESTART to indicate
+     * that it does not finished work and should be called again.
+     */
+    int (*relinquish_resources)(struct domain *d);
+
+    /* Handle call for current domain */
+    bool (*handle_call)(struct domain *d, void *regs);
+
+    /* Gets channel configuration and store it in domainconfig */
+    int (*get_channel_info)(void *sci_ops,
+                            struct xen_arch_domainconfig *config);
+
+};
+
+struct sci_mediator_desc {
+    /* Printable name of the SCI. */
+    const char *name;
+
+    /* Mediator callbacks as described above. */
+    const struct sci_mediator_ops *ops;
+
+    /*
+     * ID of SCI. Corresponds to xen_arch_domainconfig.sci_type.
+     * Should be one of XEN_DOMCTL_CONFIG_SCI_xxx
+     */
+    uint16_t sci_type;
+
+    /* Match structure to init mediator */
+    const struct dt_device_match *dt_match;
+
+};
+
+int sci_domain_init(struct domain *d, uint16_t sci_type);
+void sci_domain_destroy(struct domain *d);
+int sci_add_dt_device(struct domain *d, struct dt_device_node *dev);
+int sci_relinquish_resources(struct domain *d);
+bool sci_handle_call(struct domain *d, void *args);
+int sci_get_channel_info(struct domain *d,
+                         struct xen_arch_domainconfig *config);
+uint16_t sci_get_type(void);
+
+#define REGISTER_SCI_MEDIATOR(_name, _namestr, _type, _match, _ops) \
+static const struct sci_mediator_desc __sci_desc_##_name __used     \
+__section(".scimediator.info") =3D {                                  \
+    .name =3D _namestr,                                               \
+    .ops =3D _ops,                                                    \
+    .sci_type =3D _type,                                              \
+    .dt_match =3D _match                                              \
+}
+
+#else
+#include <public/errno.h>
+
+static inline int sci_domain_init(struct domain *d, uint16_t sci_type)
+{
+    if ( likely(sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_NONE) )
+        return 0;
+
+    return -XEN_ENODEV;
+}
+
+static inline void sci_domain_destroy(struct domain *d)
+{
+}
+
+static inline int sci_add_dt_device(struct domain *d,
+                                    struct dt_device_node *dev)
+{
+    return 0;
+}
+
+static inline int sci_relinquish_resources(struct domain *d)
+{
+    return 0;
+}
+
+static inline bool sci_handle_call(struct domain *d, void *args)
+{
+    return false;
+}
+
+static inline int sci_get_channel_info(struct domain *d,
+                                       struct xen_arch_domainconfig *confi=
g)
+{
+    return 0;
+}
+
+static inline uint16_t sci_get_type(void)
+{
+    return XEN_DOMCTL_CONFIG_SCI_NONE;
+}
+
+#endif  /* CONFIG_SCI */
+
+#endif /* __ASM_ARM_SCI_H */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index 94b31511dd..9180be5e86 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -314,12 +314,16 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
 #define XEN_DOMCTL_CONFIG_TEE_NONE      0
 #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
=20
+#define XEN_DOMCTL_CONFIG_SCI_NONE      0
+
 struct xen_arch_domainconfig {
     /* IN/OUT */
     uint8_t gic_version;
     /* IN */
     uint16_t tee_type;
     /* IN */
+    uint8_t sci_type;
+    /* IN */
     uint32_t nr_spis;
     /*
      * OUT
@@ -335,6 +339,12 @@ struct xen_arch_domainconfig {
      *
      */
     uint32_t clock_frequency;
+
+    /* Sets shared address to sw domains.
+     * This information is needed to set correct channel in Domain partial
+     * device-tree
+     */
+    uint64_t sci_agent_paddr;
 };
 #endif /* __XEN__ || __XEN_TOOLS__ */
=20
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:34:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:34:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246489.425134 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cr-000089-Oh; Tue, 14 Dec 2021 09:34:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246489.425134; Tue, 14 Dec 2021 09:34:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4Cr-00006v-KT; Tue, 14 Dec 2021 09:34:45 +0000
Received: by outflank-mailman (input) for mailman id 246489;
 Tue, 14 Dec 2021 09:34:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qXUZ=Q7=epam.com=prvs=298265c1fe=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mx4Cp-0007JG-CQ
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:34:43 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 35c0b5fa-5cc0-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:28:35 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BE943EJ004675;
 Tue, 14 Dec 2021 09:34:37 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxraag3uw-5
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 14 Dec 2021 09:34:37 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6976.eurprd03.prod.outlook.com (2603:10a6:102:e4::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 09:34:30 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:34:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35c0b5fa-5cc0-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m48qyoYx/iKZFtFXfcW1CLJyzLSNIh10N2U8F/k9zetZl76mta/xpNhTPtUUvUnW/UM1bm0AtCecbJFMfHYPYl0LnNXU1kWOhDF+CzwQIu3I8EQi0GZcUNSFQr9GHB7qogksEZH+bMkuuf98UkxBlHFPU/NmMeo393wy+cyMx0AmDXcvi7rjq4yjrwmxrKlGwkfBgXcsH8/dB5cxZ9R8tFRTMeN5LTHzON1+v+0YpBoLWiINEy5+yi9rLUO1S6S7jG2Z2ZokwjytCFiASttz5tRkpa+dOn0610SRiz7aWV1DIzRoe49TS5eVl7AKjORGMveixsoNpjOcInSDySo3oQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=NuMyjEbSpSIao6BH2oZdWuIEjdeXmzyuL/4oyil7Wmc=;
 b=NvSp+ny15CW+7+rDnu9OWE36EmkjdhLCqGkUvf3TCswiP4+yXAE7l+JWNYQxc3sBVMCpnMKcCLFDPIrcHi257/7MyuQjtMiDUvLU4YLNshkDU0//LAlilzUvY5z1tGPFavAbelF1snAe6hkhT37tsBYnxq3hXoXFn+O0xv+b3Mldq5BhUwq/lebVA8kF8/G2WNNl5FnoonPqbFKPFXHtJd/nsuKaiR0RRs8J0AYpdhcQB9piHDsPNxER94n6ySmMde/g2lZiQDVXHkdxJtXx7QrZiaD5dw6B6semlaneXCUckb/cKNHhKl2F4fzlPSyefihc6eqOn75C0TvSlb6eJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=NuMyjEbSpSIao6BH2oZdWuIEjdeXmzyuL/4oyil7Wmc=;
 b=q6W53TiSH1KhwtgXlL9zuELN3xKU1FuvUx3zd4ah+8b+1FEYBquF3Jidii0wt7atZ8we6YSh1mGudUfqmh802rBc9qdLO2512AjDKg5CX/a2k3PTbzs6t/+DxV+JjENvd0LW6ToTWBNYQL1y/eiRkuUbHg2jiaeKqnJdrB5jM+FrsmxsW04GUTWelxloUoFE7YhMISmGKpbcWGZibfHSABu5lX89HYrzWEvrtG7VOuZyaVlilSMBYwxREXACmlA3wk+4YhZMK2RX3P+dzcEmHDLMjH28ZNpWsbvkh52+CRlUS8F8F7gx0J7FJz25wfZtydT6akVHvLY75w+iPJJgwA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, Wei Liu <wl@xen.org>,
        Juergen Gross <jgross@suse.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+g==
Date: Tue, 14 Dec 2021 09:34:30 +0000
Message-ID: 
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d782d05e-9d15-4391-20f1-08d9bee4ee01
x-ms-traffictypediagnostic: PA4PR03MB6976:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6976BD1F9B8267AE294B2E20E3759@PA4PR03MB6976.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:538;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 LXqwGYCnlvewmBDk77E+vGdGvpUzpOZ9C/YJ1AyI9p4PDaGITyjsMR+i1egcyXDuV6hRpM+Ui9Vesq6I0logEFjbCpFWsN2DHk5tdT/fW/sZ9ctGLPKG8ObJXsyfwuG2whxMhpxgJTp6Q00AkLwuEhW3P+rRFbvDH5iqVJDVNbKal67Fl7Y+8C7VnmpDyQQmWgHy6hSth8FH8LFiHb5lJFvVKSueH7Z94VeaZR3SbkHj2EjU4sDw9wuVN2X+pVUEq61wOLfC2LZtg5NWSAkI1ZriQcNaNjCTppRKbrXhVYQ6a0mb0SNQwWY4vh1SAqnIbg8aD0RqJHQ9kbUj0UkNOOPkpu/x/y681OMFow1rp5U1oPj/dCXICi2ScNfS3uCf9SmVr6H0fF3xlNuadXt6DsAm5HC89QfQNAsE7QnRlqkpzq6TzlgRTONEghEBkqsS92yD/c1+PjVUVz14BVFq0P32bFrdViL4OgleGM7hkFDq0hgfTKJgF0h3NXyakwpdaYUGF+K0Ld5e4igGAbT8BT3zITZnpXJ8oetlrQ7epXsWTB78SmKWt9lR01HXN+o+IFLyZLIlyWfmqrwM2foazkcaY0iktB+V9L3J7sLxlSQm+11vj1LqP9+Lx5sj19w0nX7vIoUHNNPc4nGpnEmb80cd7jJgwXNbL2fc+KywWNOVfor71mjfBl/0we3Y3LmuXjx/xJ31auT0v6/++Zpg+w==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66476007)(64756008)(66556008)(66946007)(26005)(66446008)(76116006)(5660300002)(91956017)(508600001)(86362001)(83380400001)(186003)(30864003)(7416002)(6916009)(4326008)(2906002)(6486002)(38070700005)(8936002)(2616005)(36756003)(71200400001)(8676002)(38100700002)(122000001)(6512007)(6506007)(316002)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?dUH0YfGfqSD0cghep/a3Yx/g38c+7tCWraVMq6y5vOSalZXuoa7MPNVTCu?=
 =?iso-8859-1?Q?fV41dQRKMDQEuoIaXP7sO2Vt3N/DgxF5KRmA/x9Kl9gz2uDPeRxCAiw2XG?=
 =?iso-8859-1?Q?wmDRzr38TL/Np37HcwzOxOW0xsqk5ckIgoGFJogXAHuMjp3ZMQJVjBSbt2?=
 =?iso-8859-1?Q?WEbxB+Cv4FALZaPDCN/03VEQfwRVzjAjn0xBgi6hagreJ9LSaTrIFC4c9P?=
 =?iso-8859-1?Q?poNcqZoeqzy8ZxWhhrAfnkcgmNFiqgiNgtUs/+izwbhdcp+jRF6RDxfhrS?=
 =?iso-8859-1?Q?TQMCDyO08tn4zjwCXUlGpxRIJ5Ly3pamSOK9JdGMwOsr/z6ji39F6QGUU8?=
 =?iso-8859-1?Q?4xdf/E3lD5HDOKLCEUrUpbACTlC57fKIct2o6EVJzt0BQ9FWc+lLJKstYk?=
 =?iso-8859-1?Q?WW9mlUKsKtZ2UJxWmnHcs1sOWc7sdYuzogHKEsyphpVTW3ijugQcEiJR0D?=
 =?iso-8859-1?Q?z9LdBKp+0tkJeA72Q8GyzCSDrb562/bW4KfeBnbZSnYmCYOIfFddw0cb1x?=
 =?iso-8859-1?Q?6eQ3uciIAxh44P6Kk4EDqohq5F2tMqAbjeLW/v6gYSOtamDpS96qSyojo6?=
 =?iso-8859-1?Q?GnP2pwsLgOe3JqptDQhxoAjn+hT/YNm6csmJB2O2W7YqPWWvRMAOTFrJjs?=
 =?iso-8859-1?Q?+uoIBtYII7vM8lYmWK3ulz1LWSZwQVeRB0Md8jW3G/7CYlPdfbbSc9YeD5?=
 =?iso-8859-1?Q?4iLZlBbgye6zqySXactSc7Vd0WLO3/9y8gDfG/tQwmxbY4Nn9gp5FbrDD3?=
 =?iso-8859-1?Q?lsLvQT+biZH/sedYdYV5+4zjXV9p8pbD1sDlo8XZ+KnO1DtWC8nrbiSomK?=
 =?iso-8859-1?Q?7y9pGjuhlKpFIkuaqdYYDECq1P6YwsZDASPaLIVYYlm8Hnj0WI31Jsisd5?=
 =?iso-8859-1?Q?WN7y/RZKczxJl2Iw40Fa72nFioMeVIaNUGCy2ZWVFzDlIpJjRFnGU6ZUFF?=
 =?iso-8859-1?Q?wBP3ysGFTfSPgyD/cjBti3IdDkJycUnF524HNPq12iKcZvOU9lu8t5bply?=
 =?iso-8859-1?Q?OkFTcwKUR3d3cyjAGWI7qmzK3dQg00fKZMvXbwzdhAcDRJldCsPiM7p85F?=
 =?iso-8859-1?Q?v32ktvnR40cwAV1g3EnHB2/se89V4PzGIlIJ14DB2hNNohLN785y8PqD/N?=
 =?iso-8859-1?Q?/Tr/IcM7n0tuRWSIobZvzdSryVjZxI/CvVfEQ/YJc/TwxGZe83ZcqbLpLn?=
 =?iso-8859-1?Q?ZDVBoAHUxia1c/CQwzCDk/QWel1QxQi7TPXSwBrFc7tUoxRqsnU9fw4sTd?=
 =?iso-8859-1?Q?+5DlZ4XX+3Y2YUyAmSiZsS7QXLLXDlpfZa3L10Vip1rVLBRYZdHTJnMQ3N?=
 =?iso-8859-1?Q?9Tzei7+Hq1ICdGq0A8XJjUoQgQ0TdDisQyShdmvbz+qcN/eMAfgjnZd7Rq?=
 =?iso-8859-1?Q?5qFsbLkQ6TXdkkj/24wtPvN3A5VSzZ5+YjMFQ5hEzo/9kbNcdnpY2HoD8+?=
 =?iso-8859-1?Q?ynKnWwKWwkng/wjwy1hsjxEo1BbcWxBKI8MGxwsRM5ctTMlEGXr0gJjSca?=
 =?iso-8859-1?Q?CG5QW5VTN30DYPV8gT7grbBim9iwsSss98nkdiGGPHEFvEgVxjrczIXiVp?=
 =?iso-8859-1?Q?dJeoMa5ResJL1Lis5SlcnTNr6FsWNWAAxeRncGMy3fi/G/iA0vZGL4GjTG?=
 =?iso-8859-1?Q?2XpRsCiPgLOxhvm7FQqFFUfs9VN2empMe7H7DWyxLKJr8ruNOM0d5O+NhY?=
 =?iso-8859-1?Q?nNb8NVPHfQtIbddH6JLWiMurq8H3CHIo38t92LLFGibbJUMazsfsaJKPjd?=
 =?iso-8859-1?Q?mnUYjVZrmz50LRJfiJg0GRmaU=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d782d05e-9d15-4391-20f1-08d9bee4ee01
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 09:34:30.3570
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HtACawbFOb6DEVtIJacr+L0gGTFKQD12nO1+eYoQu5syS2t66Y4N8xRYYY2lV0eFlZ1b/syLOxZkOpPuL79k9WILjhr19RroMqKGW2jJL5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6976
X-Proofpoint-ORIG-GUID: CFOXjYvmOTrU-6BM0q3KoB0xKMi33wW-
X-Proofpoint-GUID: CFOXjYvmOTrU-6BM0q3KoB0xKMi33wW-
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-14_05,2021-12-13_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0
 priorityscore=1501 suspectscore=0 mlxlogscore=999 spamscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112140054

Integration of the SCMI mediator with xen libs:
- add hypercalls to aquire SCI channel and set device permissions
for DomUs;
- add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
- SCI requests redirection from DomUs to Firmware.

Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
---
 tools/include/xenctrl.h           |   3 +
 tools/include/xenguest.h          |   2 +
 tools/libs/ctrl/xc_domain.c       |  23 ++++++
 tools/libs/guest/xg_dom_arm.c     |   5 +-
 tools/libs/light/libxl_arm.c      | 122 +++++++++++++++++++++++++++---
 tools/libs/light/libxl_create.c   |  54 ++++++++++++-
 tools/libs/light/libxl_dom.c      |   1 +
 tools/libs/light/libxl_internal.h |   4 +
 xen/arch/arm/domctl.c             |  15 ++++
 xen/include/public/domctl.h       |   9 +++
 10 files changed, 223 insertions(+), 15 deletions(-)

diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 07b96e6671..cdd14f465f 100644
--- a/tools/include/xenctrl.h
+++ b/tools/include/xenctrl.h
@@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
 int xc_domain_soft_reset(xc_interface *xch,
                          uint32_t domid);
=20
+int xc_domain_add_sci_device(xc_interface *xch,
+                              uint32_t domid, char *path);
+
 #if defined(__i386__) || defined(__x86_64__)
 /*
  * PC BIOS standard E820 types and structure.
diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h
index 61d0a82f48..35c611ac73 100644
--- a/tools/include/xenguest.h
+++ b/tools/include/xenguest.h
@@ -242,6 +242,8 @@ struct xc_dom_image {
=20
     /* Number of vCPUs */
     unsigned int max_vcpus;
+
+    xen_pfn_t sci_shmem_gfn;
 };
=20
 /* --- arch specific hooks ----------------------------------------- */
diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
index b155d6afd2..07bb390e17 100644
--- a/tools/libs/ctrl/xc_domain.c
+++ b/tools/libs/ctrl/xc_domain.c
@@ -2206,6 +2206,29 @@ int xc_domain_soft_reset(xc_interface *xch,
     domctl.domain =3D domid;
     return do_domctl(xch, &domctl);
 }
+
+int xc_domain_add_sci_device(xc_interface *xch,
+                              uint32_t domid, char *path)
+{
+    size_t size =3D strlen(path);
+    int rc;
+    DECLARE_DOMCTL;
+    DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN);
+
+    if ( xc_hypercall_bounce_pre(xch, path) )
+        return -1;
+
+    domctl.cmd =3D XEN_DOMCTL_add_sci_device;
+    domctl.domain =3D domid;
+    domctl.u.sci_device_op.size =3D size;
+    set_xen_guest_handle(domctl.u.sci_device_op.path, path);
+    rc =3D do_domctl(xch, &domctl);
+
+    xc_hypercall_bounce_post(xch, path);
+
+    return rc;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c
index 5e3b76355e..368a670c46 100644
--- a/tools/libs/guest/xg_dom_arm.c
+++ b/tools/libs/guest/xg_dom_arm.c
@@ -25,11 +25,12 @@
=20
 #include "xg_private.h"
=20
-#define NR_MAGIC_PAGES 4
+#define NR_MAGIC_PAGES 5
 #define CONSOLE_PFN_OFFSET 0
 #define XENSTORE_PFN_OFFSET 1
 #define MEMACCESS_PFN_OFFSET 2
 #define VUART_PFN_OFFSET 3
+#define SCI_SHMEM_OFFSET 4
=20
 #define LPAE_SHIFT 9
=20
@@ -69,11 +70,13 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
     dom->console_pfn =3D base + CONSOLE_PFN_OFFSET;
     dom->xenstore_pfn =3D base + XENSTORE_PFN_OFFSET;
     dom->vuart_gfn =3D base + VUART_PFN_OFFSET;
+    dom->sci_shmem_gfn =3D base + SCI_SHMEM_OFFSET;
=20
     xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
     xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
     xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_=
OFFSET);
     xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn);
+    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->sci_shmem_gfn);
=20
     xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
             dom->console_pfn);
diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
index eef1de0939..73ef591822 100644
--- a/tools/libs/light/libxl_arm.c
+++ b/tools/libs/light/libxl_arm.c
@@ -8,6 +8,8 @@
 #include <assert.h>
 #include <xen/device_tree_defs.h>
=20
+#define SCMI_NODE_PATH      "/firmware/scmi"
+
 static const char *gicv_to_string(libxl_gic_version gic_version)
 {
     switch (gic_version) {
@@ -101,6 +103,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
         return ERROR_FAIL;
     }
=20
+    switch (d_config->b_info.sci) {
+    case LIBXL_SCI_TYPE_NONE:
+        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_NONE;
+        break;
+    case LIBXL_SCI_TYPE_SCMI_SMC:
+        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_SCMI_SMC;
+        break;
+    default:
+        LOG(ERROR, "Unknown SCI type %d",
+            d_config->b_info.sci);
+        return ERROR_FAIL;
+    }
+
     return 0;
 }
=20
@@ -122,6 +137,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
     }
=20
     state->clock_frequency =3D config->arch.clock_frequency;
+    state->sci_agent_paddr =3D config->arch.sci_agent_paddr;
=20
     return 0;
 }
@@ -502,9 +518,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
     int res;
     LOG(DEBUG, "Creating OP-TEE node in dtb");
=20
-    res =3D fdt_begin_node(fdt, "firmware");
-    if (res) return res;
-
     res =3D fdt_begin_node(fdt, "optee");
     if (res) return res;
=20
@@ -517,9 +530,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
     res =3D fdt_end_node(fdt);
     if (res) return res;
=20
-    res =3D fdt_end_node(fdt);
-    if (res) return res;
-
     return 0;
 }
=20
@@ -902,10 +912,9 @@ static int copy_node(libxl__gc *gc, void *fdt, void *p=
fdt,
     return 0;
 }
=20
-static int copy_node_by_path(libxl__gc *gc, const char *path,
-                             void *fdt, void *pfdt)
+static int get_path_nodeoff(const char *path, void *pfdt)
 {
-    int nodeoff, r;
+    int nodeoff;
     const char *name =3D strrchr(path, '/');
=20
     if (!name)
@@ -925,12 +934,101 @@ static int copy_node_by_path(libxl__gc *gc, const ch=
ar *path,
     if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
         return -FDT_ERR_NOTFOUND;
=20
+    return nodeoff;
+}
+
+static int copy_node_by_path(libxl__gc *gc, const char *path,
+                             void *fdt, void *pfdt)
+{
+    int nodeoff, r;
+
+    nodeoff =3D get_path_nodeoff(path, pfdt);
+    if (nodeoff < 0)
+        return nodeoff;
+
     r =3D copy_node(gc, fdt, pfdt, nodeoff, 0);
     if (r) return r;
=20
     return 0;
 }
=20
+static int get_node_phandle(const char *path, void *pfdt, uint32_t *phandl=
e)
+{
+    int nodeoff;
+    const char *name =3D strrchr(path, '/');
+
+    if (!name)
+        return -FDT_ERR_INTERNAL;
+
+    name++;
+    nodeoff =3D fdt_path_offset(pfdt, path);
+    if (nodeoff < 0)
+        return nodeoff;
+
+    *phandle =3D fdt_get_phandle(pfdt, nodeoff);
+    return 0;
+}
+
+static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt,
+                           struct xc_dom_image *dom)
+{
+    int res;
+    char buf[64];
+    uint32_t phandle =3D 0;
+
+    res =3D get_node_phandle("/scp-shmem", pfdt, &phandle);
+    if (res) return res;
+
+    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
+             dom->sci_shmem_gfn << XC_PAGE_SHIFT);
+    res =3D fdt_begin_node(fdt, buf);
+    if (res) return res;
+
+    res =3D fdt_property_compat(gc, fdt, 1, "arm,scmi-shmem");
+    if (res) return res;
+
+    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
+                    GUEST_ROOT_SIZE_CELLS, 1,
+                    dom->sci_shmem_gfn << XC_PAGE_SHIFT, XC_PAGE_SHIFT);
+    if (res) return res;
+
+    LOG(DEBUG, "scmi: setting phandle =3D %u\n", phandle);
+    res =3D fdt_property_cell(fdt, "phandle", phandle);
+    if (res) return res;
+
+    res =3D fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
+static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, int te=
e,
+                              int sci)
+{
+    int res;
+
+    if ((tee !=3D LIBXL_TEE_TYPE_OPTEE) && (sci !=3D LIBXL_SCI_TYPE_NONE))
+        return 0;
+
+    res =3D fdt_begin_node(fdt, "firmware");
+    if (res) return res;
+
+    if (tee =3D=3D LIBXL_TEE_TYPE_OPTEE) {
+       res =3D make_optee_node(gc, fdt);
+       if (res) return res;
+    }
+
+    if (sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC) {
+        res =3D copy_node_by_path(gc, SCMI_NODE_PATH, fdt, pfdt);
+        if (res) return res;
+    }
+
+    res =3D fdt_end_node(fdt);
+    if (res) return res;
+
+    return 0;
+}
+
 /*
  * The partial device tree is not copied entirely. Only the relevant bits =
are
  * copied to the guest device tree:
@@ -1088,8 +1186,10 @@ next_resize:
         if (info->arch_arm.vuart =3D=3D LIBXL_VUART_TYPE_SBSA_UART)
             FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
=20
-        if (info->tee =3D=3D LIBXL_TEE_TYPE_OPTEE)
-            FDT( make_optee_node(gc, fdt) );
+        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->sci) );
+
+        if (info->sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC)
+            FDT( make_scmi_shmem_node(gc, fdt, pfdt, dom) );
=20
         if (d_config->num_pcidevs)
             FDT( make_vpci_node(gc, fdt, ainfo, dom) );
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_creat=
e.c
index dcd09d32ba..c7372fd344 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -596,6 +596,37 @@ out:
     return ret;
 }
=20
+static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
+                         uint64_t guest_addr)
+{
+    int ret;
+    uint64_t _paddr_pfn =3D paddr >> XC_PAGE_SHIFT;
+    uint64_t _guest_pfn =3D guest_addr >> XC_PAGE_SHIFT;
+
+    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
+
+    ret =3D xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1, 1);
+    if (ret < 0) {
+        LOG(ERROR,
+              "failed give domain access to iomem page %"PRIx64,
+             _paddr_pfn);
+        return ret;
+    }
+
+    ret =3D xc_domain_memory_mapping(CTX->xch, domid,
+                                   _guest_pfn, _paddr_pfn,
+                                   1, 1);
+    if (ret < 0) {
+        LOG(ERROR,
+              "failed to map to domain iomem page %"PRIx64
+              " to guest address %"PRIx64,
+              _paddr_pfn, _guest_pfn);
+        return ret;
+    }
+
+    return 0;
+}
+
 int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
                        libxl__domain_build_state *state,
                        uint32_t *domid, bool soft_reset)
@@ -762,6 +793,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_con=
fig *d_config,
         goto out;
     }
=20
+    if (state->sci_agent_paddr !=3D 0) {
+        ret =3D map_sci_page(gc, *domid, state->sci_agent_paddr,
+                            state->sci_shmem_gfn << XC_PAGE_SHIFT);
+        if (ret < 0) {
+            LOGED(ERROR, *domid, "map SCI page fail");
+            rc =3D ERROR_FAIL;
+            goto out;
+        }
+    }
+
     dom_path =3D libxl__xs_get_dompath(gc, *domid);
     if (!dom_path) {
         rc =3D ERROR_FAIL;
@@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libx=
l__ao *ao, uint32_t domid,
 {
     AO_GC;
     libxl__ao_device *aodev =3D libxl__multidev_prepare(multidev);
-    int i, rc =3D 0;
+    int i, rc =3D 0, rc_sci =3D 0;
=20
     for (i =3D 0; i < d_config->num_dtdevs; i++) {
         const libxl_device_dtdev *dtdev =3D &d_config->dtdevs[i];
=20
         LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
         rc =3D xc_assign_dt_device(CTX->xch, domid, dtdev->path);
-        if (rc < 0) {
-            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
+        rc_sci =3D xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
+
+        if ((rc < 0) && (rc_sci < 0)) {
+            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
+                 "xc_domain_add_sci_device failed: %d",
+                 rc, rc_sci);
             goto out;
         }
+
+        if (rc)
+            rc =3D rc_sci;
     }
=20
 out:
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index fe9f760f71..b1d288a8b9 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -710,6 +710,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
         state->console_mfn =3D dom->console_pfn;
         state->store_mfn =3D dom->xenstore_pfn;
         state->vuart_gfn =3D dom->vuart_gfn;
+        state->sci_shmem_gfn =3D dom->sci_shmem_gfn;
     } else {
         state->console_mfn =3D xc_dom_p2m(dom, dom->console_pfn);
         state->store_mfn =3D xc_dom_p2m(dom, dom->xenstore_pfn);
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_int=
ernal.h
index 0b4671318c..f9f9cc633a 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -1407,6 +1407,10 @@ typedef struct {
     /* Whether this domain is being migrated/restored, or booting fresh.  =
Only
      * applicable to the primary domain, not support domains (e.g. stub QE=
MU). */
     bool restore;
+
+    /* sci channel paddr to be set to device-tree node */
+    uint64_t sci_agent_paddr;
+    xen_pfn_t sci_shmem_gfn;
 } libxl__domain_build_state;
=20
 _hidden void libxl__domain_build_state_init(libxl__domain_build_state *s);
diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 6245af6d0b..ba200407da 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -4,6 +4,7 @@
  * Copyright (c) 2012, Citrix Systems
  */
=20
+#include <asm/sci/sci.h>
 #include <xen/errno.h>
 #include <xen/guest_access.h>
 #include <xen/hypercall.h>
@@ -175,6 +176,20 @@ long arch_do_domctl(struct xen_domctl *domctl, struct =
domain *d,
=20
         return rc;
     }
+    case XEN_DOMCTL_add_sci_device:
+    {
+        int rc;
+        struct dt_device_node *dev;
+
+        rc =3D dt_find_node_by_gpath(domctl->u.sci_device_op.path,
+                                   domctl->u.sci_device_op.size,
+                                   &dev);
+        if ( rc )
+            return rc;
+
+        return sci_add_dt_device(d, dev);
+    }
+
     default:
     {
         int rc;
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index b85e6170b0..671c72c3e8 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
 #define XEN_DOMCTL_vmtrace_get_option         5
 #define XEN_DOMCTL_vmtrace_set_option         6
 };
+
+/* XEN_DOMCTL_add_sci_device: set sci device permissions */
+struct xen_domctl_sci_device_op {
+    uint32_t size; /* Length of the path */
+    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
+};
+
 typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
 DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
=20
@@ -1265,6 +1272,7 @@ struct xen_domctl {
 #define XEN_DOMCTL_get_cpu_policy                82
 #define XEN_DOMCTL_set_cpu_policy                83
 #define XEN_DOMCTL_vmtrace_op                    84
+#define XEN_DOMCTL_add_sci_device                85
 #define XEN_DOMCTL_gdbsx_guestmemio            1000
 #define XEN_DOMCTL_gdbsx_pausevcpu             1001
 #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
@@ -1326,6 +1334,7 @@ struct xen_domctl {
         struct xen_domctl_psr_alloc         psr_alloc;
         struct xen_domctl_vuart_op          vuart_op;
         struct xen_domctl_vmtrace_op        vmtrace_op;
+        struct xen_domctl_sci_device_op     sci_device_op;
         uint8_t                             pad[128];
     } u;
 };
--=20
2.27.0


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:38:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:38:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246512.425151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4G0-0002jv-Jm; Tue, 14 Dec 2021 09:38:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246512.425151; Tue, 14 Dec 2021 09:38:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4G0-0002jo-Gm; Tue, 14 Dec 2021 09:38:00 +0000
Received: by outflank-mailman (input) for mailman id 246512;
 Tue, 14 Dec 2021 09:37:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0izq=Q7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mx4Fz-0002ji-Ay
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:37:59 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 84122035-5cc1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 10:37:57 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 84122035-5cc1-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639474677;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=cMounVm5pz5tIlPw8vbYa1F55aMBxu8+npfkaESQRP8=;
  b=QoXyosTT/3B67Ff7OXgU2sByCRdXHQyIenG8U+uY8U++4qqpa+qlNFW7
   pHbzl0SzI3qGcvEjp7ihD+bbTTd5om3GLs4dxb45Q2/NmRZWsmAKoIBJi
   bnpJALOkOGTHS9joJ74DqNg8TfI/NLo7WI3PIJuTS9k5HrKa5nUjCArZt
   Y=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: vTGboCc3YSm8rOmRU1bc82iYJ8vIqoM1J5eNIWba46QDqfSHym8X7O9OO1OiVMNrSwVwfGRQU4
 4aUXJyg4WL7zwqtMyU6PeOGCE5L5inX2r4RzfChcO/cZZ79KMnnU9puQGYYsE9w2T2Jlo02rqI
 +kqrYRrl8pI+IdwPyIXfnueszn2mHJ3m3WOaZkbYln3U+bs80NLB/GawYOb9LG51/aDGnEEvG8
 DTVhQTwhz6p0f20b+Ej4EIfSLS14J6th59o93kf3DVKbij7eaAoglZR/axE+1VkfVlEZd0EiUt
 6Zr3ElI7YRc197w6DzAdNayQ
X-SBRS: 5.1
X-MesageID: 59909729
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:FlcHIq9bmfnWC50Itr4XDrUDTXmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 jEfXTiCMqmJZTD0c9BxaoXipBxXvcSEyINrQQY4/Hw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh2z
 4hV7oy3WDwvBZDTqc0HSxlpEjpxaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp0fTK6PO
 JBIAdZpRC38Y0QeBU0XMplkvb+GlEW4eDEGil3A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0XN0NC7Yq7xC2zJHp/DewHHAEfz9aZ4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9zABbvzt68owGOlor+p5
 idsdy+2tr9mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ldRsza55ZJ2C4M
 Cc/XD+9ArcJYxNGioctPOqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6CHfjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClIOMAkc5zX5m9vNoqRpwPZYkPnm5
 Ha4VhMKwVbznySfew6LdmpiePXkWpMm9SA3OiklPFCJ3Xk/YNnwsPdDJsVvJbR3pvZ+yfNUT
 uUef5nSCPp4VTmaqS8WaoPwrdI+eU3z1x6OJSesfBM2Y4VkG17S4tbhcwa2rHsOAyO7uNEQu
 bql0g+HE5MPSx47VJTdae61zkP3tn8YwbogU0zNK9hVWUPt7Ik1dHCh0q5pe5kBcEyRyCGb2
 gCaBQYjidPM+4JlosPUga2krpuyF7csFERtAGSGv629MjPX/zT/zNYYAvqIZz3USEj95L6mO
 bdO1/j5PfAKwARKvo57H+o5xK4y/YKy9bpTzwAiF3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZO3CkMVKSokcv+HhKMdlTTl5PgoJFn3uX1s972dXEQOZxSBhUSx9leu3F/JF
 Qv5hPMr1g==
IronPort-HdrOrdr: A9a23:RIDdx6izACkPVoVKYHiMUBOQmHBQXtYji2hC6mlwRA09TySZ//
 rBoB19726StN9xYgBFpTnuAsm9qB/nmaKdgrNhWItKPjOW21dARbsKheCJrgEIcxeOkNK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59909729"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH] x86/cpuid: Fix TSXLDTRK definition
Date: Tue, 14 Dec 2021 09:37:32 +0000
Message-ID: <20211214093732.30424-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

TSXLDTRK lives in CPUID leaf 7[0].edx, not 7[0].ecx.

Bit 16 in ecx is LA57.

Fixes: a6d1b558471f ("x86emul: support X{SUS,RES}LDTRK")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 tools/libs/light/libxl_cpuid.c              | 2 +-
 tools/misc/xen-cpuid.c                      | 3 +--
 xen/arch/x86/x86_emulate/x86_emulate.c      | 2 +-
 xen/include/public/arch-x86/cpufeatureset.h | 2 +-
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
index 815498d4f3d0..e1acf6648db4 100644
--- a/tools/libs/light/libxl_cpuid.c
+++ b/tools/libs/light/libxl_cpuid.c
@@ -209,7 +209,6 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str)
         {"avx512-vnni",  0x00000007,  0, CPUID_REG_ECX, 11,  1},
         {"avx512-bitalg",0x00000007,  0, CPUID_REG_ECX, 12,  1},
         {"avx512-vpopcntdq",0x00000007,0,CPUID_REG_ECX, 14,  1},
-        {"tsxldtrk",     0x00000007,  0, CPUID_REG_ECX, 16,  1},
         {"rdpid",        0x00000007,  0, CPUID_REG_ECX, 22,  1},
         {"cldemote",     0x00000007,  0, CPUID_REG_ECX, 25,  1},
 
@@ -220,6 +219,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str)
         {"srbds-ctrl",   0x00000007,  0, CPUID_REG_EDX,  9,  1},
         {"md-clear",     0x00000007,  0, CPUID_REG_EDX, 10,  1},
         {"serialize",    0x00000007,  0, CPUID_REG_EDX, 14,  1},
+        {"tsxldtrk",     0x00000007,  0, CPUID_REG_EDX, 16,  1},
         {"cet-ibt",      0x00000007,  0, CPUID_REG_EDX, 20,  1},
         {"ibrsb",        0x00000007,  0, CPUID_REG_EDX, 26,  1},
         {"stibp",        0x00000007,  0, CPUID_REG_EDX, 27,  1},
diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index 9b59fec26371..fb36cac07baa 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -128,7 +128,6 @@ static const char *const str_7c0[32] =
     [10] = "vpclmulqdq",       [11] = "avx512-vnni",
     [12] = "avx512-bitalg",
     [14] = "avx512-vpopcntdq",
-    [16] = "tsxldtrk",
 
     [22] = "rdpid",
     /* 24 */                   [25] = "cldemote",
@@ -172,7 +171,7 @@ static const char *const str_7d0[32] =
     [10] = "md-clear",            [11] = "rtm-always-abort",
     /* 12 */                [13] = "tsx-force-abort",
     [14] = "serialize",
-
+    [16] = "tsxldtrk",
     [18] = "pconfig",
     [20] = "cet-ibt",
 
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c
index 069acde51791..f71015ffa1ff 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -2000,7 +2000,6 @@ amd_like(const struct x86_emulate_ctxt *ctxt)
 #define vcpu_has_avx512_vnni() (ctxt->cpuid->feat.avx512_vnni)
 #define vcpu_has_avx512_bitalg() (ctxt->cpuid->feat.avx512_bitalg)
 #define vcpu_has_avx512_vpopcntdq() (ctxt->cpuid->feat.avx512_vpopcntdq)
-#define vcpu_has_tsxldtrk()    (ctxt->cpuid->feat.tsxldtrk)
 #define vcpu_has_rdpid()       (ctxt->cpuid->feat.rdpid)
 #define vcpu_has_movdiri()     (ctxt->cpuid->feat.movdiri)
 #define vcpu_has_movdir64b()   (ctxt->cpuid->feat.movdir64b)
@@ -2009,6 +2008,7 @@ amd_like(const struct x86_emulate_ctxt *ctxt)
 #define vcpu_has_avx512_4fmaps() (ctxt->cpuid->feat.avx512_4fmaps)
 #define vcpu_has_avx512_vp2intersect() (ctxt->cpuid->feat.avx512_vp2intersect)
 #define vcpu_has_serialize()   (ctxt->cpuid->feat.serialize)
+#define vcpu_has_tsxldtrk()    (ctxt->cpuid->feat.tsxldtrk)
 #define vcpu_has_avx_vnni()    (ctxt->cpuid->feat.avx_vnni)
 #define vcpu_has_avx512_bf16() (ctxt->cpuid->feat.avx512_bf16)
 
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index d6260c801ab5..647ee9e5e277 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -239,7 +239,6 @@ XEN_CPUFEATURE(VPCLMULQDQ,    6*32+10) /*A  Vector Carry-less Multiplication Ins
 XEN_CPUFEATURE(AVX512_VNNI,   6*32+11) /*A  Vector Neural Network Instrs */
 XEN_CPUFEATURE(AVX512_BITALG, 6*32+12) /*A  Support for VPOPCNT[B,W] and VPSHUFBITQMB */
 XEN_CPUFEATURE(AVX512_VPOPCNTDQ, 6*32+14) /*A  POPCNT for vectors of DW/QW */
-XEN_CPUFEATURE(TSXLDTRK,      6*32+16) /*a  TSX load tracking suspend/resume insns */
 XEN_CPUFEATURE(RDPID,         6*32+22) /*A  RDPID instruction */
 XEN_CPUFEATURE(CLDEMOTE,      6*32+25) /*A  CLDEMOTE instruction */
 XEN_CPUFEATURE(MOVDIRI,       6*32+27) /*a  MOVDIRI instruction */
@@ -280,6 +279,7 @@ XEN_CPUFEATURE(MD_CLEAR,      9*32+10) /*A  VERW clears microarchitectural buffe
 XEN_CPUFEATURE(RTM_ALWAYS_ABORT, 9*32+11) /*! June 2021 TSX defeaturing in microcode. */
 XEN_CPUFEATURE(TSX_FORCE_ABORT, 9*32+13) /* MSR_TSX_FORCE_ABORT.RTM_ABORT */
 XEN_CPUFEATURE(SERIALIZE,     9*32+14) /*a  SERIALIZE insn */
+XEN_CPUFEATURE(TSXLDTRK,      9*32+16) /*a  TSX load tracking suspend/resume insns */
 XEN_CPUFEATURE(CET_IBT,       9*32+20) /*   CET - Indirect Branch Tracking */
 XEN_CPUFEATURE(IBRSB,         9*32+26) /*A  IBRS and IBPB support (used by Intel) */
 XEN_CPUFEATURE(STIBP,         9*32+27) /*A  STIBP */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:41:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:41:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246527.425162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4J9-0004HC-42; Tue, 14 Dec 2021 09:41:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246527.425162; Tue, 14 Dec 2021 09:41:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4J9-0004H5-0p; Tue, 14 Dec 2021 09:41:15 +0000
Received: by outflank-mailman (input) for mailman id 246527;
 Tue, 14 Dec 2021 09:41:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iTjg=Q7=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mx4J7-0004Gz-1U
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:41:13 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d9d9039-5cc1-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:35:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d9d9039-5cc1-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639474869;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QERmxLNSvvFx6vzNSYmMrsv0e2X5CmwuAGyK1bazfj4=;
	b=uVT3SzBcceVfCKVd9bfwP/mkrBbU6i6CXo8B0uqt0K0CoD5a4qXyBj1twarA7qhg9DUpCf
	OrVbNB7kcn9ckbfr0CT2aeLTQTe7pl003+0ptW2EbYL49mtlKdiGcdgbTrY3LmUvHIDRVO
	oUyYJTCLGbEKPL3lyqY4wNdexzr+WwLkloa+hbSAnazTQRKYFU/bmsDlS0IKdiZ6tW9GGx
	HiqEkWnh0eDq6pt7S9pHkclWGxZU61oDJv8S9DVEIUgIkiP6c3yxVlpBmL8rJzB+H4TNe6
	G8+D7456TbPXVtBVebfm1EMXeWbrmmtdvroOCyBCNYYLr4GmBNBW77LIxVu6Kg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639474869;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QERmxLNSvvFx6vzNSYmMrsv0e2X5CmwuAGyK1bazfj4=;
	b=KbnnQxJjrjwD3AUzOdrDHb83i5GFD5BYZ+EuPZBYHEXZFSMZ3bN/5+CPOSNQTQ/bGXXBRZ
	h+7rXr2HbjWxd5Dw==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya
 <okaya@kernel.org>,linux-wireless@vger.kernel.org, Johannes Berg
 <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <20211213182958.ytj4m6gsg35u77cv@detonator>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator>
Date: Tue, 14 Dec 2021 10:41:08 +0100
Message-ID: <87fsqvttfv.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Dec 13 2021 at 12:29, Nishanth Menon wrote:
> On 23:18-20211210, Thomas Gleixner wrote:
> Also while testing on TI K3 platforms, I noticed:
>
> msi_device_data_release/msi_device_destroy_sysfs in am64xx-evm / j7200

The warning complains about a device being released with MSI descriptors
still attached to the device. This was added by:

  5b012cede0f7 ("device: Add device::msi_data pointer and struct msi_device_data")

That's not a regression caused by this commit. The warning is just
exposing an already existing problem in the iwlwifi driver, which seems
to do:

   probe()
     setup_pci_msi[x]_interrupts()
     start_drv()
       if (try_to_load_firmware() == FAIL)
       	   device_release_driver()
                ...
                msi_device_data_release()
                    WARN()

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:41:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:41:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246530.425174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4JW-0004kV-Ch; Tue, 14 Dec 2021 09:41:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246530.425174; Tue, 14 Dec 2021 09:41:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4JW-0004kO-98; Tue, 14 Dec 2021 09:41:38 +0000
Received: by outflank-mailman (input) for mailman id 246530;
 Tue, 14 Dec 2021 09:41:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx4JV-0004Gz-Mb
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:41:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2d4b1d84-5cc1-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:35:30 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-Xp6fDrIBMA6E7g81rcuBMg-2; Tue, 14 Dec 2021 10:41:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3936.eurprd04.prod.outlook.com (2603:10a6:803:23::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 09:41:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 09:41:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2d4b1d84-5cc1-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639474896;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=V6Fc1grdlexpszAPWZbZ1T/t6DpZ80ZnT6ApIGLSZVw=;
	b=jYecUeRO2PyPw1f0gChoUSCm5tMx3iP0O5vNbE2Ir30s7s45TerlUAL1OLtCYQ9wQHxb8D
	aZ+X7DH3fEWDHyR5GSsYqO/0bjhO6xZzs4MHkzYbenbUCPVJI4WXYtYyMpbVPQp/KCyF/Q
	Vj/JctMWCCNwdSxTQq3aYpbIbcZsAUI=
X-MC-Unique: Xp6fDrIBMA6E7g81rcuBMg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cRvSVeIfPkJyfwFMS+SxRQ59GA418Ztax2UkZvHLg3RrYkjmOgixj0ordOA4REr9npGWK9q8Rkd49pZ+MGl0XnOQoZtM+Jf0OM8sK/IPTCI1V5hToa2xa6Q1WJnaodQ+OsxFMwZ2HR66TDy8NHM2hVHKO7nXKwJWhITEOS68EgAwyNUkJmDnoy8XQ4JYF7IQi5e7FrK4N23j7v4rb0DVxZti1MgkmS6axym/cXbNWZgwAjI1uQ9KICT0edBREBfVv08hZAMCZ/aEdf13BBBEWh3UqMqZgLHEtsxQ8CpxWk2ckPnEEsdnmbF7DIaef/262iIbMvGPzb4mNyBBM4x0xQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=V6Fc1grdlexpszAPWZbZ1T/t6DpZ80ZnT6ApIGLSZVw=;
 b=m5ZgAjOlHsi//DlpMxnCb2kl/nGfqh3ZLYutXo2MvPVDy9Y9TVzTyshKYZOLckA8QRksg+NpSUZvoe9WvrZ+wu1EQLgJrUCZPrHoGOeG0u+oRiaL0F3BVCW1eidD4aTS+G1MNh1bK/6cZhQDQiramfcLPHMM3t7iVSxtkN1NqzNsftsscNBaP+evOg4ovK9GTIdjEgIDxA+xMUjBz292zMoMvD+em5ZyYcg6QNHONZpGc/19wG8VPcMonZHxSNwKBl+VtgLsyPDqFYakBATQxV030TIKfMX6fCXEMZ7ClhZsYcuYZPkfO5gaLw8fHHJGatgFr+i829pruLicjHt4tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
Date: Tue, 14 Dec 2021 10:41:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5P194CA0021.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:203:8f::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ce78517-3788-4734-7f5e-08d9bee5e99c
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3936:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB39367176838827FF278EE787B3759@VI1PR0402MB3936.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ji8GnNZzuIigUJOBoAvVkp3d+RfW6sJ5bpE91m6osU3Nv1rMmZQxv0WOSAjXobVidJCyybI1kJ+U9NhYtEi1roaB+YP+OZkMMcpt+Rih1U3p/+SqpYpqUa7hLSf6cQL0yM8REYLpFmmFetAFm9qVJ4pV9FA8zFHWbFt2EMyGPn7fuZJcfd8w6B2iUF7a4Ws5XbQVtctJxju3oO97Xhb/Dna7W5MEL95/fISmrjFS5IuXEa6aOQaU1B6Of74bPLxWjrYdSjfBFys0oMZodf9IiYZZRdENHBnZJIzT8Te3AfWKBP/8kfwzp2C6Dq3koAFXnuZS+trazi9r/VJfWMPf6n+raeqKudxNqZvYpPlAZYk/KGdzeALSiNkykf08zxkxNmGbliGoaFRQb5t/+1f2LaBp5PgMCB5CA3H3R5OP+QgL499c4ywVPtS44X74mi5NF8lHJGllNbkXjBQoJDzax3TQLCAZL5+lMEBxOrOqrLxsuTnrngYLdJJoBbKwthNiZE8NJsCoi8rk1LmBneqAGVVNKX1GQ9zZy+6B9cBMXMVZo+GK2Bm5EjRQLR7A/T6NCEh7MdZuCO06fs5gOQzZz7H9damGEP9bygCdhPwLSi5+iYUYfloczlO/NS/qSSZvAM3XHpaqOsfZvBEYlvG1b4x0MGKgf7akOoVApA+jQxtSTauoQlYRwoa2i/gXRtgzG/aM7JDAcHBv5yQflpMEVbkpWzR9YWfjSzLA+TGPn8Q=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(7416002)(31696002)(4326008)(8936002)(83380400001)(6916009)(2906002)(5660300002)(6486002)(316002)(38100700002)(8676002)(54906003)(66946007)(4744005)(186003)(26005)(36756003)(6506007)(53546011)(66556008)(31686004)(86362001)(6512007)(66476007)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SXlkTlFwRGFOdzlEaU9aQmwrcU5TL3VDS1grNUZtVlcxTHB6aW5WMUJCNzlO?=
 =?utf-8?B?Yk9TcUxqWUNtck1iUDVPVEdnajNvejN1WmE3QXlkZ0RHWmtaSUpHcXhwS0Ru?=
 =?utf-8?B?Z3I4WDFFOSs1Y2VIUUlFVDhyVHNKSm5iUll1RHoyN0gxVENGRFpSeHBSeXpa?=
 =?utf-8?B?U21YbDhxR3FhZlE0MWVFbWRGNzRwU3RVRG9WQkpsNGt3aXF2MDZOdXdoUVpu?=
 =?utf-8?B?cGIvM2c2MXMreGczZkxEVk56dUNpTGUvTFNPcW1DblgvZ2RKeHJBTzJEbG5Y?=
 =?utf-8?B?c1huTlJBQjkxQmpnb3ZPdi9aQTNMTDBRbFNwRElKTVR6aWhzSEEzTFZkMVJr?=
 =?utf-8?B?eVZqSWRGM2x4UzdXVnpwaDV6TTNSTTFtelJRdDFtaTVJdDl1Nnh4bXd0blpE?=
 =?utf-8?B?OHcxVDJxZEVUajFHRThjRG5wTkZWSEt0WnMzSTBRc3kzWERPQU1OMzhtVE0x?=
 =?utf-8?B?UkZ0Tk1MVnlFbDBXaWFJL20yOW1iZHNhMTZXZkV4RUlJVlRIOUN2UW9nSHBL?=
 =?utf-8?B?eEpkbS9mMUt2NHFRSjROV3ViaHBxakR2NU1FNCs1b0ErVjJNUlNYTUhCd0tJ?=
 =?utf-8?B?dGxhUzV1TGZ2d09ZTUl2dmFhN1Bwb2g3cUMzRWdJTmllbTFPU2lXMEJKMlB3?=
 =?utf-8?B?MEQ3UHp2MXRWTm1FSDZWenFzc1BRbHR0dFZvdkpWNFg3clArYUVMOHRkKzhu?=
 =?utf-8?B?U0xqNy91b0JIeVRMWER2TnhvcEpaOVpIakplSlNtWkN2a2tTcGU0K2x3MTVJ?=
 =?utf-8?B?VkQ1bnRUZVVRZmdYbHNVbGIrcERkZVJGSkQ2S3oxaUFGWjFkUml1V0tHQ1ZM?=
 =?utf-8?B?K3VJOHpucHNzZEpvNlNjRm9SenAva2cyMm1pTlVCaTBOcklXZW9kNytsRjlp?=
 =?utf-8?B?Q1ZEL2VkWUxFblg3aXh1NGxuYjN4YXhkL0UyMVdZSFRQNGhMMXAvSFBCYWxE?=
 =?utf-8?B?QXUxaWpwK1BoV3NzZWhBU2grRGlRQUJ5ZzFMbTYyTWd4dVdNYjhDb0N6VFFD?=
 =?utf-8?B?VnVxRlVvMUVwY05MdFFBS3IxOHRaU2ZZTytzWlZjSlM5bStwdVJwRGNaNUtR?=
 =?utf-8?B?N05WWXFoWFFFd2FjTEhsdi9vSXU0OXRkNlZvRzRWbWVXNEdzZnd6Tk5Jc0xw?=
 =?utf-8?B?Q3ROY2dOYnRWWi9CeVE4YXJOZEY3b1VudW1JSGQ5aUoydk51QWhVMC9Xa3dQ?=
 =?utf-8?B?RFRIdE8xSWtNYjJ6TnRqZUh4aElNaXcrdG5JV3VFRk9YZmZOcG1FOTdsTFFz?=
 =?utf-8?B?T1hPM1d4NXA4WnJqRW9Yd2x3STBOQno0QTZ2ZkxoV2NZaVNBQ2tGWGJnekZP?=
 =?utf-8?B?RzRXakVuZENTS05nMG51amZ6ZzhvM2hUTDM3VkY5ZFhLcjJXMXN6akh5clU5?=
 =?utf-8?B?M1pJTklKam1GNE5KOVlIUWZreW9jdW5MNFBYeDZpcU5ZOEVqVU1OSVhDYU1M?=
 =?utf-8?B?alJwenpvOEd5aGVFd0Z6Nk4wSFlGRC9iNHFsTVFFalJBQWVLMEtYNE4yOWpt?=
 =?utf-8?B?YnZuY3pYeTJ0VXh3d2d3L3EzMThOQWpONDNISGswMmxhaGpBcmJrTDJPTHJj?=
 =?utf-8?B?V243dGgwNmhIaEtiSnpucERjQXQzWnBPYmh0d1VhdmV1ci9ONzZna0ZEb0xS?=
 =?utf-8?B?bTNaTDZIaEhVVGM1UE5RdEdKRWY1QzZoaVovSnFLZ1hxbWZxeGJ1T2xDWm1n?=
 =?utf-8?B?VTFldkRtRUVXb0Y0QWlHWWxJZ1JVV1UrblpRMGp2OEUwajRNWFZOSjUwVmp2?=
 =?utf-8?B?SHUybXZabWJmRG5IdGZ2Mjl5WmRubVVHT0NXaWw1V1VvSG1qc2xleHBlbmFq?=
 =?utf-8?B?VWhSdHd4SXhOT0FuOWRGYlNSK203dTdrODViZnErR0xSdFRaeHRvYjYyRGd1?=
 =?utf-8?B?OXQ4ak5GbE5wZDJ0eitTUU8yeFhCOUFBbXZHa3ZZS3VaWjAwbjlxc2NBelNn?=
 =?utf-8?B?NmFwc3hXVmY5bXh3YmFzOWN1b1pGM3kyZ3JhQ2RsSlRFblBFeUNWNUozZm1F?=
 =?utf-8?B?cTVwSGhMZHl3K1dpU2V3R29iMFREV0VZTHVRZVdxeEVCQzRwWUQ0RUVxaHV1?=
 =?utf-8?B?SHpxd1oxNFNrU2ZYbnFHeWVRNStBUUE0aXQydUxCQ2dHdFhuNjdlbmllM3ZV?=
 =?utf-8?B?VVk3OGdzem5IQ1hhZDNTZ3pjN3NnRnlkL1VPZUNxQXZjTHNOSXJTamtReUtr?=
 =?utf-8?Q?u4Fv02oFzfurxFFJ3E4K+xU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ce78517-3788-4734-7f5e-08d9bee5e99c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 09:41:32.6861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZPsZhPRrtFv0Gk8Joe/Dxcj1ArGCRUENW0fk+ENEFpgEBDwGp7LlQJddIpfsAyHY8Q9HJZirAyAxA8KFkwTt4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3936

On 14.12.2021 10:34, Oleksii Moisieiev wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>  #define XEN_DOMCTL_vmtrace_get_option         5
>  #define XEN_DOMCTL_vmtrace_set_option         6
>  };
> +
> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> +struct xen_domctl_sci_device_op {
> +    uint32_t size; /* Length of the path */
> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> +};

This being - aiui - Arm-only, please enclose it by respective #if,
just like we do for certain x86-only ops.

I'm further afraid the term "SCI" is ambiguous with ACPI's System
Control Interrupt, so there's some further tag needed in the names
used here.

Finally please make padding explicit and check that it's zero on
input.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 09:51:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 09:51:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246542.425185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4T7-0006To-A5; Tue, 14 Dec 2021 09:51:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246542.425185; Tue, 14 Dec 2021 09:51:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4T7-0006Th-6x; Tue, 14 Dec 2021 09:51:33 +0000
Received: by outflank-mailman (input) for mailman id 246542;
 Tue, 14 Dec 2021 09:51:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=COgj=Q7=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mx4T6-0006Tb-JZ
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 09:51:32 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 8f44636d-5cc2-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:45:24 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EE217D6E;
 Tue, 14 Dec 2021 01:51:29 -0800 (PST)
Received: from [10.57.7.67] (unknown [10.57.7.67])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3AEA3F5A1;
 Tue, 14 Dec 2021 01:51:28 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f44636d-5cc2-11ec-85d3-df6b77346a89
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
Date: Tue, 14 Dec 2021 10:51:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Julien,

On 14.12.2021 10:33, Julien Grall wrote:
> 
> 
> On 14/12/2021 09:17, Michal Orzel wrote:
>> Hi Julien, Jan
> 
> Hi,
> 
>> On 08.12.2021 10:55, Julien Grall wrote:
>>> Hi,
>>>
>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>
>>>>>
>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>> Hi Julien,
>>>>>
>>>>> Hi,
>>>>>
>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>
>>>>>> I will change to "from AArch32 state".
>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>
>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>
>>>>>> Ok.
>>>>>>>>
>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>> needs to be fixed.
>>>>>>>
>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>
>>>>>> I would say:
>>>>>> "
>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>> if the command passed as the first argument was clobbered,
>>>>>> "
>>>>>>>>
>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>
>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>> when not passed.
>>>>>>>
>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>
>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>> ```
>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>> ```
>>>>>
>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>> wrong entry.
>>>>>
>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>
>>>> Since my suggestion was only to avoid the need for specifying a default
>>>> for the parameter (which you didn't seem to be happy about), it would
>>>> then merely extend to
>>>>
>>>> .if !0\hyp && 0\compat
>>> Isn't it effectively the same as setting a default value?
>>>
>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>
>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>
>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
> 
> Yes. This is the only way I could think to avoid making 'compat'optional.
> 
>>> Cheers,
>>>
>>>>
>>>> or something along those lines.
>>>>
>>>> Jan
>>>>
>>>
>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>> stp wzr, wzr, [sp #8 * 0]
>> stp wzr, wzr, [sp #8 * 1]
>> ...
> 
> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
> 
I hope you meant str and not ldr.
So a loop would look like that:
str wzr, [sp, #8 * 1]
str wzr, [sp, #8 * 3]
...
> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:01:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:01:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246552.425196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4cs-0008EK-DN; Tue, 14 Dec 2021 10:01:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246552.425196; Tue, 14 Dec 2021 10:01:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4cs-0008ED-9a; Tue, 14 Dec 2021 10:01:38 +0000
Received: by outflank-mailman (input) for mailman id 246552;
 Tue, 14 Dec 2021 10:01:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx4cq-0008E7-LL
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:01:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6c389a1-5cc3-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 10:55:27 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32--86aFwJ0MJ-UuC8gi394Yg-1; Tue, 14 Dec 2021 11:01:32 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Tue, 14 Dec
 2021 10:01:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 10:01:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6c389a1-5cc3-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639476093;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uxWvJWZC27nj53U0HHM1Py0nt5gs2ohPCNrqwzrooNM=;
	b=EAxgUQzRqMALisHvVWZKnc9OsCSzMriDffKIFTjlazkfLMcA2MTtmeEess+dKrvgixtfag
	vYijyoURZGRzBnbILsggr8CTzNPI2OATREDx2qbrSvun134l+dnOGvaOHu0QYiIZhZVGU8
	IkdhlmrAoyFPly94m7AwZKbrnHuBvZM=
X-MC-Unique: -86aFwJ0MJ-UuC8gi394Yg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nIe9mqoDJQ7yJD+fjm7Gf1MUVNywI9FB26MWOCjX1uB0bBgjTPobsbsjjlLcoXbc3fcl4Blf1JdLNM7rnqnn3Zcn2spP+OV7wBYIIKizKNP4ZJ2UNhmErEqyBhg7M/Ck7K4LpdrzTIq/jC3TU3eGJev+OBT98rCngovWeqjPvXlyzjQ+UzBXjXSl8mI2Q/OJ63YTzMqfeAhMRcMZw0dtn+U6AMAWYLfW358wpZdFD8ygU2DkKSAetIN7nCV4foYyO60lfZhIuUptKMQlIzgZKwwU50DCLcVHWts02DRICzmuijg/xCMFYs8JweNHD5AY96x0tIrRye8hVRmL54Mjzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uxWvJWZC27nj53U0HHM1Py0nt5gs2ohPCNrqwzrooNM=;
 b=CUZAn++2Fe1zqqnlz5npkSzpMCONmaJ0oQ6XDcXlF33X2uQhyGdm/lt8voTgltihleX2NMsLWeaf6Kh57frzuufIU2UXQPUUyIT/piWWp3n3B032D5chr8kyI/qWifPU7UfntFoYwKyT1a0TTqZtN6+30TJABgRIEG0xGu5jRyymvBaQnpFIFSNzhrNmdUUUUFcufjy++wJreiwjdVFm8Z/hezP0KdGeN3mzodJaD9ojJJLpCxbuH/GeKqKGppOwngVonsuPWEGJznXlx3n0PejdUTgxDqew09k77CtrbeIrNAeoGYmO3kfU9RRywTebxpGkB+JY7ZGY1K2S/vRY8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
Date: Tue, 14 Dec 2021 11:01:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>, Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0022.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 03ad3685-ce31-47b3-c526-08d9bee8b301
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB37743B955426EDD6A015CB89B3759@VI1PR0402MB3774.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	RMBUY5uruLzvUjj0sYzr0uNNqXdVkluSobwB+UqB7c+16PEneEZxL6Ei6w7+drp4YnPZLf7Vx1OWMd7HkOX8ZMi2MfqJPbpohwGy4fo2cvtcwdCzeJTVmc6yAh0JWjmqNb7+0oYDsxCiUkc0qjHwG9CD7l4UMupAAjols1kTIOqyJmg1YY3h4HxTfKBHEVDngFETgUcZUFSgGrt1bvzmFN2XYgk4K3vYJQJ7z2f3vdg/Dt/Dh6bbKqpoU7zhyG7DnwWvdSFb7+CeAIVv2wIDBP35M8Ae8Dk6VoTX2hztTEYBhh3NW69aShnvtqiwhDEv7tFagLBm22eQ4pZ4eOUhlhkK41E+KCBFSxjxFLUzRSmabFW32fx8laJfqsiHtiYa3fSjj3rIyn6glG0CcX+d8uvg/9TYnAjPMJgfPke1oab+TfEXmBX5mATC+tGvfwYP4ZBHR2S3nMkZNWO6PzewNbvEb+eZJFLub+HSie5aSGdhNcfWqz+rsOIhfLEBBzHTNlW1xexPlfvyzOIkF8tdKZhLPfVRt6zPVktrUMamMA0jAazyAbGTdUIqDYeL1pVrD7+dUepUZjm6PkV1uIwcku7h8xM9UOzUDUZRZGJ8SUBU7rfta6wolLuPHHLYSQcOow3ZU+qLRgX/m8R0U4Fz2YB5j1mHmDdopTK4XIH2A7u4xyxt5NGN1TPAlTs+whLjzgZ+gswAxXSgFwWucQsQPTdbG/1BYgw9fNnhHkHBt0trVWTWOkbjbxmMdQO1m+J5
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(66556008)(6506007)(53546011)(26005)(66476007)(6512007)(36756003)(38100700002)(66946007)(6486002)(508600001)(31686004)(83380400001)(31696002)(8936002)(5660300002)(2616005)(4326008)(2906002)(8676002)(316002)(110136005)(54906003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajRDMlp6STJoRDBNWEI2QlNuUWRqY3JKTUliVllLbi9wOTU4ZklNZFd1TXYx?=
 =?utf-8?B?bjZPNTVMK1RLZFhTdUtuREVwSkozbU91b3VISmpYME1jWVpDZnFvZ0h4VkFa?=
 =?utf-8?B?TUxkcHp5QTd3NlBqQXN5bXp2VkFncnQ0ZDRnc3ZLKzRCdDU3MDN3NEVicUhs?=
 =?utf-8?B?RXZlWHdlOWxUVjR4cUlQVDFLOFh5TSs0M2dyN2Jobld3SnJuNnMralNZc1Ba?=
 =?utf-8?B?WTJjOFhqd2xFYjF6T1pOYlo3eHhTK2NaZWdpVTNmWG1MTkFubTF0dEtwdS9Z?=
 =?utf-8?B?N3VObDF5VktzeS9JNStDSmlaRVArdzQ3NGFJNmN6NTBJVDRQcFNZQVg4cTZN?=
 =?utf-8?B?MnhMOVJIalEwcm5aWjFUNGZIUCtyS0tUQnVGTmZlN1lqTzBZMllDU0dpUGdn?=
 =?utf-8?B?M2h2aStnZ0pYS3ZNT01xN243a2QydTZxTUFrVzczQXVEK0l1VnJ3K1JCUThx?=
 =?utf-8?B?ZEI2eUkralFhcEwrVCtGZU1hQzlSR2MyZ3pLd2JraE1WQUMwTThMTmhET2I1?=
 =?utf-8?B?d1BBbDAwMW1CL0RoL0NWV2dtZWhqdzBQeUg3a25NeG9sa0xyaE42VVJPckov?=
 =?utf-8?B?ZG9LcFhPS1ZtVDh2ajR2Q1phSzdndGlxVGR3emI5L2drajJxYnpBcXNoeWRY?=
 =?utf-8?B?dkxXcTQyRW1nQlphNmNJNTZja2VXTzcya2pyc3B1dlpVYzFuV3JUMWF3dnN2?=
 =?utf-8?B?OFBSOXB1c0pKamhOeUZrc0RGcUFSa0l1MHBRKzRHViswM2RSdm1DYTNQanMw?=
 =?utf-8?B?TU8zamJwbE5PaFBpS1RCUFNWT1JUZ2xWZkJaNVVhRTI1cnBKS2RrQnNVRmZq?=
 =?utf-8?B?eWEyemEwdE1NOHczMHM4NjAvaVduU0Q0UWdPc2UzQ3FWRTJucmtEemxvc2t2?=
 =?utf-8?B?NUFqQmlpdW9CQS9kcTBhOFhVS2Z2SHR5enVNM1dYYmpHcUhBMjhOMkxpd2w1?=
 =?utf-8?B?WGpPYzdUQjdqSWFFQjFEMFFTV2xtcS85SlcyanRoVktEWmV5S0lnNjZPZW9Q?=
 =?utf-8?B?TCtvQXBlMUpKNnZRbFFzUVhVTHcwUjVSdDl5c2hYMVprM1VCSkFJVmxYK3BD?=
 =?utf-8?B?R1VHL01HYy9sS1c5R2V1RWtvbEM5SG4ydk1jRDUyWHJ4Wm55T3BSM3hLbzhn?=
 =?utf-8?B?U29ueG42azdPb2VsZEFHTVdLb3Q3M3lqUzc3bnFabHBFVVZkYUtzZFdnNVBR?=
 =?utf-8?B?emxXUktXMVozMWVybVV5VlozYnlJVkIxWVFBVnJoWGdBZnRqMC9TVk5lc1RE?=
 =?utf-8?B?am9NM3dTR2hjeUFGZHh3N3hETUJmTTExTyt6WmZBY1JzUXp6ZW5DRlBvUE5M?=
 =?utf-8?B?SUJtL2NqeTB0dU03L3pSMm51bHcySWN6ckdzN3FuOWpKZzBzRU4zTExheitY?=
 =?utf-8?B?dXdjajRhdWp2UHBKTUQ0aWZydEdsRkNDZEEvb3BacVZwLzlXZUZFMkM3WWxO?=
 =?utf-8?B?MXlvY3NsRUx4V2pZamorZFZHcjEvbG5IK2ZyazErUnlONW1kR2tZL2RsYWV6?=
 =?utf-8?B?Rm1zQWJrR3l3MWh1THdwcFM4MkE1U2NIV3dJVmRuUFBrVGZITFdpamYwZm9u?=
 =?utf-8?B?ejhJdFBUcnB5ekZFOTc3RWdaVk1HS2FEZ2o4UnIzbldxQVhiSXlUZkJ6bFJP?=
 =?utf-8?B?bU9acTlQVDkyME9vN2ExdUZqb2FKakFRY0hCaGUzd1pHL3NMb1ZIeXdGRjNM?=
 =?utf-8?B?UXJ5cHJhRTA1MndtSksrMXdkSXZjS3JxVkEyNEI1UzcxSnB1QXhaT053RnBJ?=
 =?utf-8?B?OXlybHNvN0lGeTRNTHNqQjkxM3ptZUY4YmdGMFdoam45dDRWaWdQNExTRTFl?=
 =?utf-8?B?NWo5UmJNRlFGMytEeEl5YlZ2eFZzMzV5eThUYmtWM0RWNk02dVFQQzBHNytV?=
 =?utf-8?B?ZWFRK1BTMjhRWjU0YXloUWlSbFpZSTloNkRJQ2NhZVpKK3ZxNVVJUWlNR09E?=
 =?utf-8?B?RjMzb05kdlFkNm5iZGZvMks4eUJKUXJlTDR0UEJVYzZ2NmliK3NZdmlvZklP?=
 =?utf-8?B?L0hqOTVoNTZUdXRyNzYrbkx5dEZDQVRqQ2ZkQU1ISW9zN2FGMlE4ZFNsdzcr?=
 =?utf-8?B?Y3E4SUkwZ0l0UThtbk1SYlp2bUNMUFUzZ3IyS0RuZGsrcEdpRzEzZU9Ubm1O?=
 =?utf-8?B?SC9Ud2dLWUF0UXRjVDNhS3BzSjJkS1NOSnN3REd5ZGFWQmkrRXFsYXBscVR5?=
 =?utf-8?Q?kh+Kho8IQDvuS3qfLwdh4hg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03ad3685-ce31-47b3-c526-08d9bee8b301
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:01:29.5693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zzCi5SGDo3/xYtBCARgquxupGK7CN2ndbuMc6ZubleWSgXc0eqi0gkb2KgzHgn7zNhBgIbpJDz7dG95BRO4psQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774

On 14.12.2021 10:51, Michal Orzel wrote:
> Hi Julien,
> 
> On 14.12.2021 10:33, Julien Grall wrote:
>>
>>
>> On 14/12/2021 09:17, Michal Orzel wrote:
>>> Hi Julien, Jan
>>
>> Hi,
>>
>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>
>>>>>>
>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>> Hi Julien,
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>
>>>>>>> I will change to "from AArch32 state".
>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>
>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>
>>>>>>> Ok.
>>>>>>>>>
>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>> needs to be fixed.
>>>>>>>>
>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>
>>>>>>> I would say:
>>>>>>> "
>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>> "
>>>>>>>>>
>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>
>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>> when not passed.
>>>>>>>>
>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>
>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>> ```
>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>> ```
>>>>>>
>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>> wrong entry.
>>>>>>
>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>
>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>> then merely extend to
>>>>>
>>>>> .if !0\hyp && 0\compat
>>>> Isn't it effectively the same as setting a default value?
>>>>
>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>
>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>
>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>
>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>
>>>> Cheers,
>>>>
>>>>>
>>>>> or something along those lines.
>>>>>
>>>>> Jan
>>>>>
>>>>
>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>> stp wzr, wzr, [sp #8 * 0]
>>> stp wzr, wzr, [sp #8 * 1]
>>> ...
>>
>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>
> I hope you meant str and not ldr.
> So a loop would look like that:
> str wzr, [sp, #8 * 1]
> str wzr, [sp, #8 * 3]
> ...

Why "a loop" and why #8 (I'd have expected #4)?

There's another oddity which I'm noticing only now, but which also
may look odd to me only because I lack sufficient Arm details: On
x86, it would not be advisable to store anything below the stack
pointer (like is done here when storing x0 and x1 early), unless
it's absolutely certain that no further interruptions could clobber
that part of the stack.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:10:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:10:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246559.425206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4lO-0001OS-6h; Tue, 14 Dec 2021 10:10:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246559.425206; Tue, 14 Dec 2021 10:10:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx4lO-0001OL-3i; Tue, 14 Dec 2021 10:10:26 +0000
Received: by outflank-mailman (input) for mailman id 246559;
 Tue, 14 Dec 2021 10:10:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=COgj=Q7=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mx4lM-0001OF-61
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:10:24 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0c568b2a-5cc6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 11:10:22 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA7536D;
 Tue, 14 Dec 2021 02:10:21 -0800 (PST)
Received: from [10.57.7.67] (unknown [10.57.7.67])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A218C3F5A1;
 Tue, 14 Dec 2021 02:10:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c568b2a-5cc6-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <ca043814-3d8b-1a4e-6eca-b0078bb851ec@arm.com>
Date: Tue, 14 Dec 2021 11:10:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 14.12.2021 11:01, Jan Beulich wrote:
> On 14.12.2021 10:51, Michal Orzel wrote:
>> Hi Julien,
>>
>> On 14.12.2021 10:33, Julien Grall wrote:
>>>
>>>
>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>> Hi Julien, Jan
>>>
>>> Hi,
>>>
>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>> Hi Julien,
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>
>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>
>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>
>>>>>>>> Ok.
>>>>>>>>>>
>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>>> needs to be fixed.
>>>>>>>>>
>>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>>
>>>>>>>> I would say:
>>>>>>>> "
>>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>> "
>>>>>>>>>>
>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>
>>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>>> when not passed.
>>>>>>>>>
>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>
>>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>>> ```
>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>> ```
>>>>>>>
>>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>>> wrong entry.
>>>>>>>
>>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>
>>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>>> then merely extend to
>>>>>>
>>>>>> .if !0\hyp && 0\compat
>>>>> Isn't it effectively the same as setting a default value?
>>>>>
>>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>>
>>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>>
>>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>>
>>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>>
>>>>> Cheers,
>>>>>
>>>>>>
>>>>>> or something along those lines.
>>>>>>
>>>>>> Jan
>>>>>>
>>>>>
>>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>>> stp wzr, wzr, [sp #8 * 0]
>>>> stp wzr, wzr, [sp #8 * 1]
>>>> ...
>>>
>>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>>
>> I hope you meant str and not ldr.
>> So a loop would look like that:
>> str wzr, [sp, #8 * 1]
>> str wzr, [sp, #8 * 3]
>> ...
> 
> Why "a loop" and why #8 (I'd have expected #4)?
> 
You are right. I confused it with stp. #4 is correct.

> There's another oddity which I'm noticing only now, but which also
> may look odd to me only because I lack sufficient Arm details: On
> x86, it would not be advisable to store anything below the stack
> pointer (like is done here when storing x0 and x1 early), unless
> it's absolutely certain that no further interruptions could clobber
> that part of the stack.
> 
I cannot answer this question. Sorry.

> Jan
> 
Cheers


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:45:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:45:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246570.425229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5JW-0005LH-D3; Tue, 14 Dec 2021 10:45:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246570.425229; Tue, 14 Dec 2021 10:45:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5JW-0005LA-8M; Tue, 14 Dec 2021 10:45:42 +0000
Received: by outflank-mailman (input) for mailman id 246570;
 Tue, 14 Dec 2021 10:45:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JiGg=Q7=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1mx5JU-00054J-Fp
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:45:40 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 1f633c3b-5cca-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 11:39:32 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 611016D;
 Tue, 14 Dec 2021 02:45:38 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E7F4C3F5A1;
 Tue, 14 Dec 2021 02:45:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1f633c3b-5cca-11ec-85d3-df6b77346a89
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Date: Tue, 14 Dec 2021 10:45:17 +0000
Message-Id: <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

vpci/msix.c file will be used for arm architecture when vpci msix
support will be added to ARM, but there is x86 specific code in this
file.

Move x86 specific code to the x86_msix.c file to make sure common code
will be used for other architecture.

No functional change intended.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/arch/x86/msi.c                       |   2 +-
 xen/drivers/passthrough/amd/iommu_init.c |   1 +
 xen/drivers/vpci/Makefile                |   1 +
 xen/drivers/vpci/msi.c                   |   3 +-
 xen/drivers/vpci/msix.c                  | 134 +++++---------------
 xen/drivers/vpci/x86_msix.c              | 155 +++++++++++++++++++++++
 xen/include/asm-x86/msi.h                |  28 ----
 xen/include/xen/msi.h                    |  28 ++++
 xen/include/xen/vpci.h                   |  21 +++
 9 files changed, 239 insertions(+), 134 deletions(-)
 create mode 100644 xen/drivers/vpci/x86_msix.c

diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
index 5febc0ea4b..2b120f897f 100644
--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -23,7 +23,7 @@
 #include <asm/io.h>
 #include <asm/smp.h>
 #include <asm/desc.h>
-#include <asm/msi.h>
+#include <xen/msi.h>
 #include <asm/fixmap.h>
 #include <asm/p2m.h>
 #include <mach_apic.h>
diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
index 559a734bda..fc385959c7 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -20,6 +20,7 @@
 #include <xen/acpi.h>
 #include <xen/delay.h>
 #include <xen/keyhandler.h>
+#include <xen/msi.h>
 
 #include "iommu.h"
 
diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
index 1a1413b93e..543c265199 100644
--- a/xen/drivers/vpci/Makefile
+++ b/xen/drivers/vpci/Makefile
@@ -1,2 +1,3 @@
 obj-y += vpci.o header.o
 obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
+obj-$(CONFIG_X86) += x86_msix.o
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 5757a7aed2..8fc82a9b8d 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -16,12 +16,11 @@
  * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/msi.h>
 #include <xen/sched.h>
 #include <xen/softirq.h>
 #include <xen/vpci.h>
 
-#include <asm/msi.h>
-
 static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
                              void *data)
 {
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 846f1b8d70..7a9b02f1a5 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -17,15 +17,24 @@
  * License along with this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <xen/msi.h>
 #include <xen/sched.h>
 #include <xen/vpci.h>
 
-#include <asm/msi.h>
 #include <asm/p2m.h>
 
-#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
-    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
-     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
+/*
+ * The return value is different for the MMIO handler on ARM and x86
+ * architecture. To make the code common for both architectures create
+ * generic return code with architecture dependent values.
+ */
+#ifdef CONFIG_X86
+#define VPCI_EMUL_OKAY      X86EMUL_OKAY
+#define VPCI_EMUL_RETRY     X86EMUL_RETRY
+#else
+#define VPCI_EMUL_OKAY      1
+#define VPCI_EMUL_RETRY     VPCI_EMUL_OKAY
+#endif
 
 static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
                              void *data)
@@ -138,29 +147,6 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
         pci_conf_write16(pdev->sbdf, reg, val);
 }
 
-static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
-{
-    struct vpci_msix *msix;
-
-    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
-    {
-        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
-        unsigned int i;
-
-        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
-            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
-                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
-                return msix;
-    }
-
-    return NULL;
-}
-
-static int msix_accept(struct vcpu *v, unsigned long addr)
-{
-    return !!msix_find(v->domain, addr);
-}
-
 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
                            unsigned int len)
 {
@@ -182,21 +168,19 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
     return &msix->entries[(addr - start) / PCI_MSIX_ENTRY_SIZE];
 }
 
-static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
-                     unsigned long *data)
+int msix_read(struct vpci_msix *msix, unsigned long addr, unsigned int len,
+              unsigned long *data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
     const struct vpci_msix_entry *entry;
     unsigned int offset;
 
     *data = ~0ul;
 
     if ( !msix )
-        return X86EMUL_RETRY;
+        return VPCI_EMUL_RETRY;
 
     if ( !access_allowed(msix->pdev, addr, len) )
-        return X86EMUL_OKAY;
+        return VPCI_EMUL_OKAY;
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
         switch ( len )
         {
         case 4:
-            *data = readl(addr);
+            *data = vpci_arch_readl(addr);
             break;
 
         case 8:
-            *data = readq(addr);
+            *data = vpci_arch_readq(addr);
             break;
 
         default:
@@ -222,7 +206,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
             break;
         }
 
-        return X86EMUL_OKAY;
+        return VPCI_EMUL_OKAY;
     }
 
     spin_lock(&msix->pdev->vpci->lock);
@@ -256,22 +240,20 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
     }
     spin_unlock(&msix->pdev->vpci->lock);
 
-    return X86EMUL_OKAY;
+    return VPCI_EMUL_OKAY;
 }
 
-static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
-                      unsigned long data)
+int msix_write(const struct domain *d, struct vpci_msix *msix,
+               unsigned long addr, unsigned int len, unsigned long data)
 {
-    const struct domain *d = v->domain;
-    struct vpci_msix *msix = msix_find(d, addr);
     struct vpci_msix_entry *entry;
     unsigned int offset;
 
     if ( !msix )
-        return X86EMUL_RETRY;
+        return VPCI_EMUL_RETRY;
 
     if ( !access_allowed(msix->pdev, addr, len) )
-        return X86EMUL_OKAY;
+        return VPCI_EMUL_OKAY;
 
     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
     {
@@ -281,11 +263,11 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             switch ( len )
             {
             case 4:
-                writel(data, addr);
+                vpci_arch_writel(data, addr);
                 break;
 
             case 8:
-                writeq(data, addr);
+                vpci_arch_writeq(data, addr);
                 break;
 
             default:
@@ -294,7 +276,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
             }
         }
 
-        return X86EMUL_OKAY;
+        return VPCI_EMUL_OKAY;
     }
 
     spin_lock(&msix->pdev->vpci->lock);
@@ -372,60 +354,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
     }
     spin_unlock(&msix->pdev->vpci->lock);
 
-    return X86EMUL_OKAY;
-}
-
-static const struct hvm_mmio_ops vpci_msix_table_ops = {
-    .check = msix_accept,
-    .read = msix_read,
-    .write = msix_write,
-};
-
-int vpci_make_msix_hole(const struct pci_dev *pdev)
-{
-    struct domain *d = pdev->domain;
-    unsigned int i;
-
-    if ( !pdev->vpci->msix )
-        return 0;
-
-    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
-    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
-    {
-        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
-        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
-                                     vmsix_table_size(pdev->vpci, i) - 1);
-
-        for ( ; start <= end; start++ )
-        {
-            p2m_type_t t;
-            mfn_t mfn = get_gfn_query(d, start, &t);
-
-            switch ( t )
-            {
-            case p2m_mmio_dm:
-            case p2m_invalid:
-                break;
-            case p2m_mmio_direct:
-                if ( mfn_x(mfn) == start )
-                {
-                    clear_identity_p2m_entry(d, start);
-                    break;
-                }
-                /* fallthrough. */
-            default:
-                put_gfn(d, start);
-                gprintk(XENLOG_WARNING,
-                        "%pp: existing mapping (mfn: %" PRI_mfn
-                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
-                        &pdev->sbdf, mfn_x(mfn), t, start);
-                return -EEXIST;
-            }
-            put_gfn(d, start);
-        }
-    }
-
-    return 0;
+    return VPCI_EMUL_OKAY;
 }
 
 static int init_msix(struct pci_dev *pdev)
@@ -472,11 +401,10 @@ static int init_msix(struct pci_dev *pdev)
         vpci_msix_arch_init_entry(&msix->entries[i]);
     }
 
-    if ( list_empty(&d->arch.hvm.msix_tables) )
-        register_mmio_handler(d, &vpci_msix_table_ops);
+    register_msix_mmio_handler(d);
+    vpci_msix_add_to_msix_table(msix, d);
 
     pdev->vpci->msix = msix;
-    list_add(&msix->next, &d->arch.hvm.msix_tables);
 
     return 0;
 }
diff --git a/xen/drivers/vpci/x86_msix.c b/xen/drivers/vpci/x86_msix.c
new file mode 100644
index 0000000000..b38b52e410
--- /dev/null
+++ b/xen/drivers/vpci/x86_msix.c
@@ -0,0 +1,155 @@
+/*
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms and conditions of the GNU General Public
+ * License, version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <xen/sched.h>
+#include <xen/vpci.h>
+
+#include <asm/msi.h>
+#include <asm/p2m.h>
+
+u32 vpci_arch_readl(unsigned long addr)
+{
+    return readl(addr);
+}
+
+u64 vpci_arch_readq(unsigned long addr)
+{
+    return readq(addr);
+}
+
+void vpci_arch_writel(u32 data, unsigned long addr)
+{
+    writel(data, addr);
+}
+
+void vpci_arch_writeq(u64 data, unsigned long addr)
+{
+    writeq(data, addr);
+}
+
+int vpci_make_msix_hole(const struct pci_dev *pdev)
+{
+    struct domain *d = pdev->domain;
+    unsigned int i;
+
+    if ( !pdev->vpci->msix )
+        return 0;
+
+    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
+    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
+    {
+        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
+        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
+                                     vmsix_table_size(pdev->vpci, i) - 1);
+
+        for ( ; start <= end; start++ )
+        {
+            p2m_type_t t;
+            mfn_t mfn = get_gfn_query(d, start, &t);
+
+            switch ( t )
+            {
+            case p2m_mmio_dm:
+            case p2m_invalid:
+                break;
+            case p2m_mmio_direct:
+                if ( mfn_x(mfn) == start )
+                {
+                    clear_identity_p2m_entry(d, start);
+                    break;
+                }
+                /* fallthrough. */
+            default:
+                put_gfn(d, start);
+                gprintk(XENLOG_WARNING,
+                        "%pp: existing mapping (mfn: %" PRI_mfn
+                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
+                        &pdev->sbdf, mfn_x(mfn), t, start);
+                return -EEXIST;
+            }
+            put_gfn(d, start);
+        }
+    }
+
+    return 0;
+}
+
+struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
+{
+    struct vpci_msix *msix;
+
+    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
+    {
+        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
+        unsigned int i;
+
+        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
+            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
+                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
+                return msix;
+    }
+
+    return NULL;
+}
+
+static int x86_msix_accept(struct vcpu *v, unsigned long addr)
+{
+    return !!msix_find(v->domain, addr);
+}
+
+static int x86_msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
+                          unsigned long data)
+{
+    const struct domain *d = v->domain;
+    struct vpci_msix *msix = msix_find(d, addr);
+
+    return msix_write(d, msix, addr, len, data);
+}
+
+static int x86_msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
+                         unsigned long *data)
+{
+    const struct domain *d = v->domain;
+    struct vpci_msix *msix = msix_find(d, addr);
+
+    return msix_read(msix, addr, len, data);
+}
+
+static const struct hvm_mmio_ops vpci_msix_table_ops = {
+    .check = x86_msix_accept,
+    .read = x86_msix_read,
+    .write = x86_msix_write,
+};
+
+void register_msix_mmio_handler(struct domain *d)
+{
+    if ( list_empty(&d->arch.hvm.msix_tables) )
+        register_mmio_handler(d, &vpci_msix_table_ops);
+}
+
+void vpci_msix_add_to_msix_table(struct vpci_msix *msix,
+                                 struct domain *d)
+{
+    list_add(&msix->next, &d->arch.hvm.msix_tables);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/include/asm-x86/msi.h b/xen/include/asm-x86/msi.h
index e228b0f3f3..0a7912e9be 100644
--- a/xen/include/asm-x86/msi.h
+++ b/xen/include/asm-x86/msi.h
@@ -148,34 +148,6 @@ int msi_free_irq(struct msi_desc *entry);
  */
 #define NR_HP_RESERVED_VECTORS 	20
 
-#define msi_control_reg(base)		(base + PCI_MSI_FLAGS)
-#define msi_lower_address_reg(base)	(base + PCI_MSI_ADDRESS_LO)
-#define msi_upper_address_reg(base)	(base + PCI_MSI_ADDRESS_HI)
-#define msi_data_reg(base, is64bit)	\
-	( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
-#define msi_mask_bits_reg(base, is64bit) \
-	( (is64bit == 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4)
-#define msi_pending_bits_reg(base, is64bit) \
-	((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
-#define msi_disable(control)		control &= ~PCI_MSI_FLAGS_ENABLE
-#define multi_msi_capable(control) \
-	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
-#define multi_msi_enable(control, num) \
-	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
-#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))
-#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBIT))
-#define msi_enable(control, num) multi_msi_enable(control, num); \
-	control |= PCI_MSI_FLAGS_ENABLE
-
-#define msix_control_reg(base)		(base + PCI_MSIX_FLAGS)
-#define msix_table_offset_reg(base)	(base + PCI_MSIX_TABLE)
-#define msix_pba_offset_reg(base)	(base + PCI_MSIX_PBA)
-#define msix_enable(control)	 	control |= PCI_MSIX_FLAGS_ENABLE
-#define msix_disable(control)	 	control &= ~PCI_MSIX_FLAGS_ENABLE
-#define msix_table_size(control) 	((control & PCI_MSIX_FLAGS_QSIZE)+1)
-#define msix_unmask(address)	 	(address & ~PCI_MSIX_VECTOR_BITMASK)
-#define msix_mask(address)		(address | PCI_MSIX_VECTOR_BITMASK)
-
 /*
  * MSI Defined Data Structures
  */
diff --git a/xen/include/xen/msi.h b/xen/include/xen/msi.h
index c903d0050c..1c22c9a4a7 100644
--- a/xen/include/xen/msi.h
+++ b/xen/include/xen/msi.h
@@ -3,6 +3,34 @@
 
 #include <xen/pci.h>
 
+#define msi_control_reg(base)       (base + PCI_MSI_FLAGS)
+#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO)
+#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI)
+#define msi_data_reg(base, is64bit) \
+	( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
+#define msi_mask_bits_reg(base, is64bit) \
+	( (is64bit == 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4)
+#define msi_pending_bits_reg(base, is64bit) \
+	((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
+#define msi_disable(control)        control &= ~PCI_MSI_FLAGS_ENABLE
+#define multi_msi_capable(control) \
+	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
+#define multi_msi_enable(control, num) \
+	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
+#define is_64bit_address(control)   (!!(control & PCI_MSI_FLAGS_64BIT))
+#define is_mask_bit_support(control)    (!!(control & PCI_MSI_FLAGS_MASKBIT))
+#define msi_enable(control, num) multi_msi_enable(control, num); \
+	control |= PCI_MSI_FLAGS_ENABLE
+
+#define msix_control_reg(base)      (base + PCI_MSIX_FLAGS)
+#define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE)
+#define msix_pba_offset_reg(base)   (base + PCI_MSIX_PBA)
+#define msix_enable(control)        control |= PCI_MSIX_FLAGS_ENABLE
+#define msix_disable(control)       control &= ~PCI_MSIX_FLAGS_ENABLE
+#define msix_table_size(control)    ((control & PCI_MSIX_FLAGS_QSIZE)+1)
+#define msix_unmask(address)        (address & ~PCI_MSIX_VECTOR_BITMASK)
+#define msix_mask(address)          (address | PCI_MSIX_VECTOR_BITMASK)
+
 #ifdef CONFIG_HAS_PCI_MSI
 
 #include <asm/msi.h>
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 9ea66e033f..4cb7665d54 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -150,6 +150,11 @@ struct vpci_vcpu {
 };
 
 #ifdef __XEN__
+
+#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
+    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
+     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
+
 void vpci_dump_msi(void);
 
 /* Make sure there's a hole in the p2m for the MSIX mmio areas. */
@@ -220,6 +225,22 @@ bool vpci_ecam_write(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
 bool vpci_ecam_read(pci_sbdf_t sbdf, unsigned int reg, unsigned int len,
                     unsigned long *data);
 
+void register_msix_mmio_handler(struct domain *d);
+
+void vpci_msix_add_to_msix_table(struct vpci_msix *msix, struct domain *d);
+
+int msix_write(const struct domain *d, struct vpci_msix *msix,
+               unsigned long addr, unsigned int len, unsigned long data);
+
+int msix_read(struct vpci_msix *msix, unsigned long addr, unsigned int len,
+              unsigned long *data);
+
+u32 vpci_arch_readl(unsigned long addr);
+u64 vpci_arch_readq(unsigned long addr);
+
+void vpci_arch_writel(u32 data, unsigned long addr);
+void vpci_arch_writeq(u64 data, unsigned long addr);
+
 #endif /* __XEN__ */
 
 #else /* !CONFIG_HAS_VPCI */
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:45:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:45:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246569.425218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5JQ-00054W-Vr; Tue, 14 Dec 2021 10:45:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246569.425218; Tue, 14 Dec 2021 10:45:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5JQ-00054P-Sf; Tue, 14 Dec 2021 10:45:36 +0000
Received: by outflank-mailman (input) for mailman id 246569;
 Tue, 14 Dec 2021 10:45:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=JiGg=Q7=arm.com=rahul.singh@srs-se1.protection.inumbo.net>)
 id 1mx5JQ-00054J-0u
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:45:36 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTP
 id 1c62fad1-5cca-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 11:39:27 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 366146D;
 Tue, 14 Dec 2021 02:45:33 -0800 (PST)
Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com
 [10.1.199.62])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E55C3F5A1;
 Tue, 14 Dec 2021 02:45:32 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1c62fad1-5cca-11ec-85d3-df6b77346a89
From: Rahul Singh <rahul.singh@arm.com>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com,
	rahul.singh@arm.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
Date: Tue, 14 Dec 2021 10:45:16 +0000
Message-Id: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

IO ports on ARM don't exist so all IO ports related hypercalls are going
to fail on ARM when we passthrough a PCI device.
Failure of xc_domain_ioport_permission(..) would turn into a critical
failure at domain creation. We need to avoid this outcome, instead we
want to continue with domain creation as normal even if
xc_domain_ioport_permission(..) fails. XEN_DOMCTL_ioport_permission
is not implemented on ARM so it would return -ENOSYS.

To solve above issue remove PCI I/O ranges property value from dom0
device tree node so that dom0 linux will not allocate I/O space for PCI
devices if pci-passthrough is enabled.

Another valid reason to remove I/O ranges is that PCI I/O space are not
mapped to dom0 when PCI passthrough is enabled, also there is no vpci
trap handler register for IO bar.

Signed-off-by: Rahul Singh <rahul.singh@arm.com>
---
 xen/arch/arm/domain_build.c   | 14 +++++++
 xen/common/device_tree.c      | 72 +++++++++++++++++++++++++++++++++++
 xen/include/xen/device_tree.h | 10 +++++
 3 files changed, 96 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d02bacbcd1..60f6b2c73b 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -749,6 +749,11 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
                 continue;
         }
 
+        if ( is_pci_passthrough_enabled() &&
+                dt_device_type_is_equal(node, "pci") )
+            if ( dt_property_name_is_equal(prop, "ranges") )
+                continue;
+
         res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
 
         if ( res )
@@ -769,6 +774,15 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
             if ( res )
                 return res;
         }
+
+        /*
+         * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled,
+         * also there is no trap handler registered for IO bar therefor remove
+         * the IO range property from the device tree node for dom0.
+         */
+        res = dt_pci_remove_io_ranges(kinfo->fdt, node);
+        if ( res )
+            return res;
     }
 
     /*
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..9fa25f6723 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -2195,6 +2195,78 @@ int dt_get_pci_domain_nr(struct dt_device_node *node)
     return (u16)domain;
 }
 
+int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *dev)
+{
+    const struct dt_device_node *parent = NULL;
+    const struct dt_bus *bus, *pbus;
+    unsigned int rlen;
+    int na, ns, pna, pns, rone, ret;
+    const __be32 *ranges;
+    __be32 regs[((GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS + 1)
+               * 2];
+    __be32 *addr = &regs[0];
+
+    bus = dt_match_bus(dev);
+    if ( !bus )
+        return 0; /* device is not a bus */
+
+    parent = dt_get_parent(dev);
+    if ( parent == NULL )
+        return -EINVAL;
+
+    ranges = dt_get_property(dev, "ranges", &rlen);
+    if ( ranges == NULL )
+    {
+        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
+               dev->full_name);
+        return -EINVAL;
+    }
+    if ( rlen == 0 ) /* Nothing to do */
+        return 0;
+
+    bus->count_cells(dev, &na, &ns);
+    if ( !DT_CHECK_COUNTS(na, ns) )
+    {
+        printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
+                  dev->full_name);
+        return -EINVAL;
+    }
+    pbus = dt_match_bus(parent);
+    if ( pbus == NULL )
+    {
+        printk("DT: %s is not a valid bus\n", parent->full_name);
+        return -EINVAL;
+    }
+
+    pbus->count_cells(dev, &pna, &pns);
+    if ( !DT_CHECK_COUNTS(pna, pns) )
+    {
+        printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
+               dev->full_name);
+        return -EINVAL;
+    }
+    /* Now walk through the ranges */
+    rlen /= 4;
+    rone = na + pna + ns;
+
+    for ( ; rlen >= rone; rlen -= rone, ranges += rone )
+    {
+        unsigned int flags = bus->get_flags(ranges);
+        if ( flags & IORESOURCE_IO )
+            continue;
+
+        memcpy(addr, ranges, 4 * rone);
+
+        addr += rone;
+    }
+
+    ret = fdt_property(fdt, "ranges", regs, sizeof(regs));
+    if ( ret )
+        return ret;
+
+    return 0;
+}
+
 /*
  * Local variables:
  * mode: C
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index fd6cd00b43..ad2e905595 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -849,6 +849,16 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
  */
 int dt_get_pci_domain_nr(struct dt_device_node *node);
 
+/**
+ * dt_get_remove_io_range - Remove the PCI I/O range property value.
+ * @fdt: Pointer to the file descriptor tree.
+ * @node: Device tree node.
+ *
+ * This function will remove the PCI IO range property from the PCI device tree
+ * node.
+ */
+int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *node);
+
 struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
 
 #ifdef CONFIG_DEVICE_TREE_DEBUG
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:48:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:48:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246580.425240 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5M0-0006LB-Ph; Tue, 14 Dec 2021 10:48:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246580.425240; Tue, 14 Dec 2021 10:48:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5M0-0006L4-MH; Tue, 14 Dec 2021 10:48:16 +0000
Received: by outflank-mailman (input) for mailman id 246580;
 Tue, 14 Dec 2021 10:48:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx5Lz-0006Kw-At
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:48:15 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 54fc08f8-5ccb-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 11:48:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54fc08f8-5ccb-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639478892;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=BuHTTxBxf2AGi62V3tC+LLu8BM7QZz4B0jA19pQPeTs=;
  b=JitUvwB8Rp0f3XP2/7JDZmX6M3hgXhnS5B3duDNzF+VXK+FA+xaunAK5
   QbAwDBbA8lQLPVvS0PUsckWr9zBHgNQjoGTTNlx8Ve2fLND16b/Mg61tT
   RqCOAjE1AQ5PyR8Kq6J+6SM6aUilUpSjmoLzbFp8lK9CgWPhVASyBRjVC
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: IdhPWkE1m2RWgaZTLNFlw8FD2mHIU+tquF9ZMval0BYd9Pv8wP/yjYEfqpuMEkIju4IYcV+f8f
 DNsKfCP9s/PCm+x0IkKrYqnsCOpaI+A47XBjZ+Ny3ssNQSps1NfKuVlWX/vRZ5v5QaekmkE2iA
 VxaAIvEiDxbFVPWzu54AlSmHXOgAk8CGjslpSGaxYQ8ukeNY7xvX6KvamBP7BEaNdt4vVHxqqs
 gqSaJUdOYBk7z/JmXoejFBCxyph3TcMeIy8gMZjoQUbqC55rnyQCKivV5+lugWMRJ1sBq5l3Y1
 3eGx5PE01QOYXa17qm23H/UY
X-SBRS: 5.1
X-MesageID: 59982551
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:a5wQcqM3xBTWop7vrR16kMFynXyQoLVcMsEvi/4bfWQNrUoqgmEBn
 2pJXj3Sa6mKMWOjfownPY+29BwGuZXRxtBlGQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowygs/Uh8
 c4djNu9ezoQIKfeu8kZTDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/ibtI8CgWpp7ixINd39R
 MgdaRM1Vgr/eyd0NllPDrxvwej90xETdBUH8QnI9MLb+VP70whZwLXrdt3PdbSiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOGTeKR0xDkHYgFc
 gpNp3Ro/fNaGFGXosfVZjSUhS69pU4lHNdiLtQk4hOu567LylPMboQbdQJpZNsjvc4wYDUl0
 F6Vgt/kbQBSXK2ppWG1renN827rUcQBBSpbPHJfE1NZizX2iNhr1kqnczp1LEKiYjQZ8xnUy
 ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AjLNAuBRPtfNi2mUBb7zt6kowGGxFAbpg
 ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmr2qiL5JNgNvm4vdC+F1/ronxezP
 yc/XisLu/du0IaCN/crM+pd9ex0pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE
 c7DK66EVC9CYYw+lWbeb7pMidcDm3FlrUuOFM+T8vhS+efHDJJjYexeawXmgyFQxP7snTg5B
 P4DbZbXkEsGD7WlCsQVmKZKRW03wbEALcmeg+Rcd/KZIxogH2ckCvTLxqgmdZAjlKNQ/tokN
 FnnMqOB4Fag13DBNyuQbXVvNOHmUZpl9CppNi0wJ1e4nXMkZN/3vqsYcpI2e5gh9fBikqEoH
 6VUJZ3YD6QdUCnD9hQccYL58N5oeiO0iF/cJCGiejU+IcJtHlSb5t/+cwLz3yASFS7r59Amq
 rit21qDE5oOTghvFujMb/erww/jtHQRgrsqDUDJPsNSaAPn940zc379ifo+IsctLxTfx2TFi
 1bKUElA/eSU+t076tjEg6yAvryFKeomExoIBXTf4Ja3KTLeojipz7hfXbvaZjvaTm71pvmvP
 L0H0/HmPfQbt19WqI4gQa1zxKcz6taz9b9XygNoQCfCY1ixU+4yJ3CH2Y9Et7FXx68fsgyzA
 xrd9t5fMLSPGcXkDF9Oe1Z1MrXdjakZymvI8PA4AETm/ysmrrOIXHJbMwSIlCEAfqB+N5kow
 Lt5tcMbg+BlZsHG7jpSYvhoylmx
IronPort-HdrOrdr: A9a23:sB4kNa0nOeqn7DA5al8h7wqjBGokLtp133Aq2lEZdPUMSL38qy
 iv9M536faGskd0ZJhAo6H7BEDuexLhHPJOirX5eI3SPjUO21HYUb2Kj7GD/9SIIUSXygce79
 YCT0EUMrHN5C1B4/oSlzPWLz9P+rO6GeuT9IDjJj9WPGdXg/8M1XYBNu5Zf3cGPzWuK6BJbK
 ah2g==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59982551"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UO7mZqPc+Vd+a2exR3ujj+nteqJFKhPe5BkdpLVpEnCzGXX1hMHpEUbv0++5bNWDTPnBzXg4jZm05qAAyWFu6pJhDpPWJ+Pp9xCTLdcl1NXS8qynbN4IhVA5mOT/7xmurFzpkOxphmMDin/1FrqFHd2Q5/sAKKmVnb0JoodgtaGt/KLt40MxnjR0SC0B9IbGMSubrsLFeDcAGncWQ48M/qOm7a1tc9VMwSzvs4T6LcuQ62Qt1PWicBvDdnqEGcyJVnTxfTNbudpYyQ/p+YPfoH8DL0ViHcmNtI81KaDsGhFJ7FnkPHA1y4exFb4sFonWqX20Yx3duYVYY8vZzo0/pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OLfnLl9EECw5E4w32OxKKkKw3mpoSaT52z724tt1lkU=;
 b=DBhJM3BLWnZJsiLYX83p1qv/58fN3KO12DfklJ+S/V6t/S9qjqtrundoZQMEXQD9ZLvvYxpnqtzzdyZ2lBe7cQHp7OI2JWgFB+Mr4N9w/jjjDVucKlMSMjIgbcICXK8LmF3AL6FC724bERQF2D32Jc9C/312R2PtvZcRV068Ml0aQ4ZH+oHasAjpjD2/LZMU5lXbmhXaJMUgFdM2SqWbHSe7gLaLUEzt5DYg4hRYbvYT1AR4VYjBR9fXWwfgI7IgeVhatvAw3+6MW2kf96Rgff9FXdwXxgNHLYtdvMBBbLc7YaQSHLQsgg5sVdMdVneIbivvZ6xw8q98nphANqiaIw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OLfnLl9EECw5E4w32OxKKkKw3mpoSaT52z724tt1lkU=;
 b=sPEq8f8xS/i5a00YdKfwagVHxc7mjDZzLWdqVPqIpbCOjLi2XENA0Gw/1J2uYqc0BINLG8l3mKTt4YyEV2YdQ2JsGYDcAz8pX/tSnR7Zl/iIaKVWnSMMeXWYb9wAFhYlOMV4t/PhTGaVQiPMtJ+z6SEsB8zbRfBdENEZMpiAS8s=
Date: Tue, 14 Dec 2021 11:48:00 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5] x86/PVH: improve Dom0 memory size calculation
Message-ID: <Ybh2YJTsGuEsLN8/@Air-de-Roger>
References: <5d675c6c-8cb1-f218-75d7-cb13f8b2e669@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5d675c6c-8cb1-f218-75d7-cb13f8b2e669@suse.com>
X-ClientProxiedBy: MR2P264CA0129.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:30::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b5bafc02-c7cf-4ea4-b021-08d9beef371e
X-MS-TrafficTypeDiagnostic: DS7PR03MB5590:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB5590358B85CB2F5064FD34DD8F759@DS7PR03MB5590.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jOATrXtDAUJm8FzZl77ROkS8mbqHQH1q7Fm3j+PtOr9G4B2buC3Fmrek+zbEsXosBS4NcGUsIi6bfvcg1pe+GfPhZeL8+/AdSoQJN6zNtzd03RSZbSzJ9FDfEgUmTI/QiYsylEDgfAYidig+L/lnzDtnHtKFbzQT/A0pjSTug7UVobVB/kBhJJgWTGevSMrnpgEkWNwmGHE/8im/wdnCIRhAX/1cvj+u5a2LORV0EvZHM8mdfb71gGu/J1UNQv52YlpjZAfbyK0UFodnSFf7Rp2vuMfkY33E2XIQbIpHs9wDfJk29IeGtGFgN1U1HonKAXcXqNV5d8AAxTf0qaNmsWUikYdf7Pq7bX4SCk8warW69n6Mbi0FeqKAPZq6wjfe//Te1zIAxyO5c07jAWthX7nUrK9RYM3rQRFi9hzqduDyCHHRtaMxtqPjkyPAveaVDUgbhiZcLYA1soku9F5LaXOzxAhB583kcFtll+P3Kf8IVzRuIWZzEXtdbxh5p0kJnGn6rEnItd3+dUxbYTBjMiappmM5B/JqgoimCSQAj7xmlJIPfYkwBgwHarCFibh2fwjOqXCb6vGwfkOe+fhdiMq2YAy4PD5icStlsUxTzVaTl0xn3FycXAatk34jjHFURMivizh5Lh5kRc6kAjtw1IxGLkuOn04l+cq/iVqvckeWtyUGRsdf4RWF88yHeQ+GwTi+BEqvC+k4/tbgzHm0iA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66476007)(85182001)(6916009)(186003)(6506007)(9686003)(5660300002)(6486002)(316002)(66556008)(6512007)(66946007)(38100700002)(26005)(2906002)(508600001)(86362001)(83380400001)(4326008)(6666004)(54906003)(82960400001)(8676002)(8936002)(33716001)(25903002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnM1V3lMd3djNjZDREpULzhMNDRLaTI5N3Z0bmpvTE1qdW5YRDhZQUd5UDlC?=
 =?utf-8?B?Q1MwdEZDUTYweW9SRkVyMngyRmViM1J6YnFIOXZuY1RLMjMwMnBKaFpGZFRs?=
 =?utf-8?B?TlJsRk16KzN3NlhLUFE1Um9VSm5FMm9BR2RvaWYyeWZZUjBUS1JGNS95NDdJ?=
 =?utf-8?B?dmd6QWZzWDNrU3o2aDNmT3ZDd2lJOTg2Q21keXZNeXZ4ejhVL09IckN6MUQ3?=
 =?utf-8?B?REhLNC9JMTl6RW5ITmZrM2kxNFllV0tVR0c5V1RRaEYvRldiSGwzUlU1ZmFZ?=
 =?utf-8?B?UVY1dUdCK1RIZkh5RDhOQW9sUXliaHltQzZxVzRpa1BkdGk2U1FzY2FsS3FM?=
 =?utf-8?B?ZnBVR1BocFR5bm1DL0ZuaTFWNFlGOFM0UDhSMm1VRW05d1V3blNvcUEzaWtZ?=
 =?utf-8?B?OWJwWXdNYTdOMDI4emhyVFc2U2s1UTc3M1pocVozY3ltcHcwbkUxYWxrNG11?=
 =?utf-8?B?WFU5MURDQm1iVnJJY0lSQzBpOUdhQzRVMkxYMnBTcnRWdmVkMytXWk9QT0VK?=
 =?utf-8?B?SFlpSHVVMy90QVNPeGVIaDNURkN5RExaSUh0S3NSb1BpbXVXWEphTFVSaGJL?=
 =?utf-8?B?MGx0NGZHeUJWdFZYdmhySkl5U250V2VhYTFqb0VVMXFHbmpNcnkyQVlBaVZz?=
 =?utf-8?B?c3JoaWZLdWY4TktYeU9PeklzTUoyS3o5ZGVIbSs2Y0NIRjE5RVhEUzQ1emd6?=
 =?utf-8?B?MC9jaGVuQldZSld6d2svOTFNUGE1UHo0ZFlYakhGdXk2VTk1aDhRdTF4Qitj?=
 =?utf-8?B?Skt3U1lUVnFDcUtnSWhTUlZyeHF1cHRCaTN1b3owMXJieDdLNVJ6Y0o1bkdk?=
 =?utf-8?B?bVRHUVY1bWNsdWdBc0E0MDNQdE50UTRpQnV2SlZ1OGpVSmtDZU5Jd3hYLzBR?=
 =?utf-8?B?MXJyNEZlejMvaE1JbGxuQUNKNjZDa2YxakNFVkZHVHdLTnRYekRRQll1NS9N?=
 =?utf-8?B?ZXBWNWN2cGpBcWxiTGgvVjZsZXorSitDaDdXdGxFM1QxZEJYMnVFVkRiMnBS?=
 =?utf-8?B?QkxocGVReEhiQ0c1dkw1cy9HY3VTbmFGMERZeFVoeGZOV25ZNkpXcHFOcHBP?=
 =?utf-8?B?NmV4dVhjRXVGRnhxOXRwMWg0UzNLZ2RrTldLSHZGbU1WS0tDTjVNZmxsM3dq?=
 =?utf-8?B?dzRjWGJyWXQ3dEFlZktVVHdxOFNwakdCNVN2VDFOWWZNYjBETTA4bW5HbUxE?=
 =?utf-8?B?c29BOWZtU0JNK1JiTTh2bUI0Zk9kbUZWLzN1bzlsZjIvNk1ucy90bXlkUjlT?=
 =?utf-8?B?Yk5PVUdoVmdGYVhhUWNKM3ZJWnA3dTQ5ZW5tOHdVc1lnVElucXB4RHJ1Rk14?=
 =?utf-8?B?OXdjcnkzRnNGeCtsanV3REhhWXZaeWtyODUwVGdIejZBOTg3UnI1QVJ4TU9H?=
 =?utf-8?B?NzNUVjMvS3dCMjVhQysvVnRVajV5bi9rdWdmMzdkZnJHWmdzQkVOc1FicE55?=
 =?utf-8?B?VTlHT3hEZmhEd2l3czhvSWkxV0wwVTFHVnhpOGFLdVFVUFZkWklQODRmQS9T?=
 =?utf-8?B?aDFMZ3ZORHVyZ0V5VENyblVQL2p6S016VzZETmdXaWdNeDZqcUtDbFI3clBK?=
 =?utf-8?B?cW1qamY3cjJpTjE4TjlNVWpXTHpGZldnTGRUNWlXa2kzdTZyemtvckdCRkRo?=
 =?utf-8?B?N0ladTNmRGtLRjZ6VjZ3RWxFNWdUTHAxbmFmU2F2TmFKaS9OV0ZoN0JWblUr?=
 =?utf-8?B?amhYbDU3aGZvVzhOV2JBZlZpVHBLaGJLcVpXZjdRNlJ1a3VUeDFXdDRXbXU1?=
 =?utf-8?B?SnZHVW1iMjdqOFY4Q1Y5WldJcWdNWWNxM1hIQkdNd3RPbng2azBUT1JqT0xY?=
 =?utf-8?B?cFA5eEtwZXE0dlFjNXl2bm95YVduNVlRaElsTjgrUkhkRmkwSE5vMzUxTm1p?=
 =?utf-8?B?TTRiVkxyUjJnNFRIdkw1bWJpSzMrWktFS0tJZWFaejgycldINlNwdUt5Y29R?=
 =?utf-8?B?Zi84UFlrSlkrYWUzUlcyZ3I5eFFzdlV5NXRFc1lxb3d0SFphbkNBcUhtNlJ2?=
 =?utf-8?B?YzMzZGNsOVJJVlVDVnA4ekpOcUgvUitSOWY4TXBodG9NMzZpc0hQSDBDNG5N?=
 =?utf-8?B?ZzAwRklFNFVqcEdsdGxKa0ZUYXFsS0EyYVlqMDZVSmpIMzFTSUFvb3Q4Nitr?=
 =?utf-8?B?d25JL1pmTU5sbHpQUXBnVGg4OWpXL2RqQ0JPWW1RckpWZVM4NVU3M2hmTmZN?=
 =?utf-8?Q?hduyXy2xwYq86hzbLqnOLjg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5bafc02-c7cf-4ea4-b021-08d9beef371e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:48:08.3055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bwV44VOJw9X+97ZVPjr9fu5v7uFYYnB0O9PMwxL/IRqf+bSXcQ/QD0KpaFRXtOvIkL/c5viBd4nbDWv9eiV4HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5590
X-OriginatorOrg: citrix.com

On Fri, Dec 03, 2021 at 11:27:20AM +0100, Jan Beulich wrote:
> Assuming that the accounting for IOMMU page tables will also take care
> of the P2M needs was wrong: dom0_paging_pages() can determine a far
> higher value, high enough for the system to run out of memory while
> setting up Dom0. Hence in the case of shared page tables the larger of
> the two values needs to be used (without shared page tables the sum of
> both continues to be applicable).
> 
> To not further complicate the logic, eliminate the up-to-2-iteration
> loop in favor of doing a few calculations twice (before and after
> calling dom0_paging_pages()). While this will lead to slightly too high
> a value in "cpu_pages", it is deemed better to account a few too many
> than a few too little.
> 
> As a result the calculation is now deemed good enough to no longer
> warrant the warning message, which therefore gets dropped.
> 
> Also uniformly use paging_mode_enabled(), not is_hvm_domain().
> 
> While there also account for two further aspects in the PV case: With
> "iommu=dom0-passthrough" no IOMMU page tables would get allocated, so
> none need accounting for. And if shadow mode is to be enabled (including
> only potentially, because of "pv-l1tf=dom0"), setting aside a suitable
> amount for the P2M pool to get populated is also necessary (i.e. similar
> to the non-shared-page-tables case of PVH).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:50:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:50:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246587.425251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5OB-0007tf-Af; Tue, 14 Dec 2021 10:50:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246587.425251; Tue, 14 Dec 2021 10:50:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5OB-0007tY-7B; Tue, 14 Dec 2021 10:50:31 +0000
Received: by outflank-mailman (input) for mailman id 246587;
 Tue, 14 Dec 2021 10:50:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx5O9-0007tQ-Do
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:50:29 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a66c4250-5ccb-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 11:50:28 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-11-NjN0jJ44M8yxneRNRr-Dgg-1; Tue, 14 Dec 2021 11:50:27 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5743.eurprd04.prod.outlook.com (2603:10a6:803:e0::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 10:50:24 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 10:50:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a66c4250-5ccb-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639479028;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=E0tkE/qX64lFKIFZGMymC/B9R7jluBGBrYJ7eoHmcGI=;
	b=hPwn2arIA3zxzvgCWsWn8aSbvj7J/fD/5f1FcuJ8viakwUUvkW3H4lUNu5VzBB6IA0ROtX
	5m/ezLg8smj7We4pNKzKp/LoZqtsd0AMyzpG5SkSwQYStKTZYiIPxrm1E99u/GRJAkGnfy
	IN+Q6c+dHIBXqEh7XQhWOloiBnlHsEY=
X-MC-Unique: NjN0jJ44M8yxneRNRr-Dgg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=oGiRTaFZB9A7+WnCvHNNviZIinyG74zcZF6ZUtb+xtcszyxRZSkmdsuSWPYLr7pJFw7scjPrsnULXI4pz53tLB/pKCmwWYuppNq4llwnmFEBiU42nCZsuX7g5nmjvzDqeaEb86mJ+YeS+iPhee8vkbj0DFku2GlopHOzIUeWg4LEGNkugJfPN/GceX3xH1i+AKwdShdOb1ngaw1mlWNus0Eo9bKYvbobxmYCtBHywgZ4NUlRCiZdNlSG1kCDOG5BA4cqGra51nlqpt8UlSoOV+M0QKTwI0kygDUN1TFaKv8I32lgvh+xND4kv77lnuacaXbzx5vudHmxU2y8BtJ9fQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E0tkE/qX64lFKIFZGMymC/B9R7jluBGBrYJ7eoHmcGI=;
 b=QofFO/BPCXxJweJARxhNChOdatp2gF0Ip+ftKgCqCxc2p9CRS9StsfXECC0JIWevKPZmrI4mqBp4TBif/hq+z7dl4pHynt8gM4tF2NncLiWaBeNxaoAraXeDQ7Doe5k1Q1J0LC+BrBjHfL36HbpSjelo6GYmNnCk53JNBiBE5fTfoQkgL5Tw3XzxspgAlZ7Tajq7AS9yEKjVDCL4kXaaeEyrJ5wGAw+idQlYM+Xmfd+9knQJMJTiHTInJq/fd5OsPXxrBjmp3QLZQjgfiBv/PeN2+XdUJWvIoZA8YsVz0PxkulzisSrVdSae7lLYGyPo7+qZDjC5UTcz5fJAqZg9mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <5bee28dd-35ad-a1c1-10aa-27bd2fd9a6fe@suse.com>
Date: Tue, 14 Dec 2021 11:50:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] x86/cpuid: Fix TSXLDTRK definition
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211214093732.30424-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211214093732.30424-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR04CA0041.eurprd04.prod.outlook.com
 (2603:10a6:20b:f0::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 10d5de77-251b-4d42-c90b-08d9beef8879
X-MS-TrafficTypeDiagnostic: VI1PR04MB5743:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57438323D03BC86BD5D49C14B3759@VI1PR04MB5743.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YxZCjyqCFYQC+txueMg31dX4NQPglHFFApGE2neeXvBwozDHGad0XKx5PZTfFKVk5l+fKYdQ0I7jrAcQXE4ZjVvu7zlk7GQqsx9hnt4spvMOBgFvYyLTv9VfvkPvQWttgm67p4rPwFV4Qksi42MPETGQ42NETEV6fgjYqTVjxg8DnM+H/1yr6ge9XpOYUlo+35WCiBWSgnpMj09vnBTnfhMThV1Be0TOAOc3nUlmx3qz5zP9qmAEdh7qT2SZhkhueW+bOGPcU79ZhW/DMqPuQ2SN3aB3jbLiNq99ANvZ7V3IPdHm7M37c0dzgsv9RRFkkGxJdrRBZ783AH3JJaikesQ/UAFaV3uPFUd7o91Uf8VLObyBaaaEacrWDrPyLaC6vvRgpqEwmaxLuDqrrgAZ7T2WFdHDQDsbZFw80mjg9EobZSUDbtHikSB8V7AyYu+RRUUoFIru9ROBMZy03uckb+bDZfvFg4bQb+xoNB2eecZlAKlt8PbMQiggxEV8KaaRT72BM3F1YAJn+C4gKNI9z+qQUdv8FHuhUGbXTKxycWCNWoLL/yP5+Ge4eWVu/Dy5xjpXqlKyA3yDpOzd+N+2xrtG3QjTg74IChdjsE4W7RsuUni4r7b80mobBtDpHy/UaCCmLgHAZ6fS9WB/jlADkzq9iiHSZOKQ0lpjDUnvoh68b7BrWDCR+VBEpjShRkyb48YKSJYeuJCaLj77LaT3VafFBkWBoXSGuQ3wFd3HrVKy9XbR+/HH6jG4cxFtmRUULFaMPLLyi1Xqi1VPcxUSqKDxeawJ3bBJfauG0xNb3/4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(8936002)(4326008)(316002)(6486002)(6506007)(31686004)(5660300002)(53546011)(36756003)(86362001)(66946007)(26005)(54906003)(6512007)(2616005)(2906002)(66476007)(8676002)(66556008)(4744005)(186003)(508600001)(6916009)(31696002)(121003001)(133343001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTd0Z2RRM0kxT1pZTzExT1V5dWhRdjBBVU9ieHB4U2o0RktQVitCQTUyU0RB?=
 =?utf-8?B?N3BKUWU4OGZWWldhZGZDREJoTUxiK2xrVVdqeVVGQ3RGSGtlbGhTQmtxMFJ3?=
 =?utf-8?B?WHVLYmROSVJNRWVRZWJWQnV2aEE5Rnp5YzNqb3JrYzV2UXh6YzJ5NS91OHVO?=
 =?utf-8?B?eHBMS1Z0M0hVcHFndUFpd21YTmtSQzJpcWQ1cFMrZHFacVBQbzREZjY4Q01O?=
 =?utf-8?B?WjBEN3o3bzlmaG9qcTN2clVncUF1NHQ2d1BqVzVLZmFCb3ZMbkwybzBGSSt1?=
 =?utf-8?B?YXVlbWx3OFJkNjEzb0YyYzQ1ZDZJQll2YjA2UGJWaW9xS0pPV3hmR2tVVGdv?=
 =?utf-8?B?SjM5VSt6TVdZdWR3YmZWTFpmQUNPUkxEWWFYd0Y3QXF1UUFOdi9TdFp3dVFl?=
 =?utf-8?B?QzFHWUlBOUROajVaWTJ6L0RqYW5Dc3VhYWdLYkFqakpUYVFWMVk4WDF0ZGdG?=
 =?utf-8?B?SGhEbHpmS0FCbW0vTC9PdXIybHRCK3FpZFp2eXUzbHZUN2tqdFhtRDBKY2xq?=
 =?utf-8?B?VEcwREwxaTREc05jRTJkSkxRaUJzbU56ZlRabmlyK2tITWp2UWQvN1AzUkxO?=
 =?utf-8?B?eHd5TnZHNlJTSlczM3NhZEVWM2dZdHhvSVBUQ0VCdkVkaHRjU0N6T3BBbDNI?=
 =?utf-8?B?Vm5LTHFZc1V0ZHpLcDc3NzhQbGtXMnpkSXp3ZXl6d0pUa1JVZlI0S0hqdGNT?=
 =?utf-8?B?RW14c2NaY1c1MzJ4azhIamJnNXY1Sjd2UHNxS01xbWhxQ0RnNGRrdnJIOGZU?=
 =?utf-8?B?T0o3VEFTemdnM2ppZzFYd2hTY0tXNjdrem5OMU9uWlg0eHlBMVlmOTQ3d1di?=
 =?utf-8?B?WkhYMFlGNmFzQ1JzVjV2N1R1SVQ1UE5vZDkzbU1jbys0V3VZYXE5Mkluc2dO?=
 =?utf-8?B?b25lTVFNaTF0MDJaWFVRelZTRzA5cXQxbWRzNm0rZWIyVTNDWUt0RXp3dlZY?=
 =?utf-8?B?dkM0NVUwMWc5TkNPeVJsZk9RalJXcStLV1dZVitURnU4YU05eXRTMXhEVms2?=
 =?utf-8?B?TC8vb1lQWlpOUVo5Sm94ODFJQTBIS2gvNXQrdW83OEhJb0pPcTFZOE5zMmJ3?=
 =?utf-8?B?TTFtQzRBYlo2OFdsVDA4UTlIT3BUMitDV0phSkVZOTNhYWVQMi9QaWlVWDhn?=
 =?utf-8?B?M0k2OTZtQmNycmdhdzVURS9OTlpsdHM1V3NKQlpLYldCNkM0ZnFWUHdLV0pK?=
 =?utf-8?B?MlZzTXB0SW53eXFHNTNRWDZGakVhRnl5MTArMjFaZVI4eXE4Szh0ZkJoVmlQ?=
 =?utf-8?B?QmVRblgzZFJCaE03OXZ6ZUV6eHphM2dWZ0lWS2MxQ0JxaGRhTzk5dW5zK1pM?=
 =?utf-8?B?eUszaFBtV1R0SFYyUHZHR3hOWURUK3pUeEZGeUJNRThTQ0g3SndxY3cyNXBY?=
 =?utf-8?B?QlJ5SlJwQm90QWtaMWJzQ1BhTHd1YTEwWEwxTklsT2hONndDZ3RLMGVwQnlS?=
 =?utf-8?B?dWJEUldLTUNBaEZ6SnlJVkU3R2FHZWpLM0lNcHhWMWc5VmNIeFBUdlEvMGV2?=
 =?utf-8?B?dkxxcVJmOUtEMktxMm05R2Z6MFducjgzMGFzMGI3czlnLzA2cjBCZXhELzFl?=
 =?utf-8?B?SHl4djZEWmd4WHhIdDhKeG9TOXZoS2MxSXBPd0RHeGZEOGxISzRQcTc4Nzhq?=
 =?utf-8?B?Tjk0K2oxMk1SQWVxZWErakV1UkV5cTFlclFJeXFacU9UTHJyQ2IxNnd0M3E1?=
 =?utf-8?B?MmRKWklybFh4dVM1RVB2c3JEamlXOE1HK2hQRXJlV2dlazE2WmdCMDVHT2Rl?=
 =?utf-8?B?TUlHMmQwa1pGRTZJODhuVDErdHBHVTRvcjFNMFI5RXlpMjJOTUFGQWlxL2dS?=
 =?utf-8?B?WjNYTFZiNkRVVFpFdXhocWZHM1JOejdNSjAwUlZiVjFaMVhieTNWWkVYd1hB?=
 =?utf-8?B?Snp6cjBmcmhINlplY0NrWFZzQ1hLeDJGZDlVSUh3bVMyL0IrNkppZ2E0TW80?=
 =?utf-8?B?dWZ4RURZbm5ENDRrYUREWTV1d2JpRUZtYmJjbzVQaHpuUFJTUnhEb0VISDJX?=
 =?utf-8?B?SXFXeWxKbmx4YWp6OWxjYnNpaC9Udm4wd2hEUm1qR1djMDFCRXE1R093U3dX?=
 =?utf-8?B?aWtLMlI5REg0STlZWDZVQTJwd3BGMzVHS1VQaDd0RzlZaW9jVHlDMXdLOTRI?=
 =?utf-8?B?SlRoeFJHVklScHRjS1JXdDJzNThkM0pVZnJ2ZUpUdVh0eEpqYzhHNW1WWFQ3?=
 =?utf-8?Q?OjKjP+hgJ80JfxITUuBnNg8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10d5de77-251b-4d42-c90b-08d9beef8879
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:50:24.7598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NbMsKGve1X9Nisr/OrjXIsJ3KM6KvhT6qCr0J7IPyGxre0YKapeIU41EnCtHy/OsQOWc+g9c3YaSMK5OOWui+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5743

On 14.12.2021 10:37, Andrew Cooper wrote:
> TSXLDTRK lives in CPUID leaf 7[0].edx, not 7[0].ecx.
> 
> Bit 16 in ecx is LA57.

I wonder how I managed to screw this up; it certainly hasn't been a typo
in the original doc.

> Fixes: a6d1b558471f ("x86emul: support X{SUS,RES}LDTRK")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 10:59:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 10:59:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246592.425261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5XD-0000Kt-7a; Tue, 14 Dec 2021 10:59:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246592.425261; Tue, 14 Dec 2021 10:59:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5XD-0000Km-4Y; Tue, 14 Dec 2021 10:59:51 +0000
Received: by outflank-mailman (input) for mailman id 246592;
 Tue, 14 Dec 2021 10:59:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx5XB-0000Kg-Nz
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 10:59:49 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f314e794-5ccc-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 11:59:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f314e794-5ccc-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639479588;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=OVIZOU/9NYSkNJbhKWqn/Qu9V/D7lRQN9h9G11OCn5Y=;
  b=dtquE57lPQ02LZzfkvAgLS16c+r2HXEomiQcJjsa2Xjeq+jpwnZwq/Mu
   j8+X3jRalN8pcjTqmiryDlbYw48T9OIlyY40mNHr1RN7zn4D0TrDB9OMK
   DDBqmttA0uoIgxl8qeNDh+W8MnFTmh8ZTx5vT6Ca8JlUU5ujBQCWJCebd
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: J9rjl4mlP2VTxMoriNqN7P24mIzooBvI97LifaJAtoVpQHNZErkhS8CTkcdefS4brf7fCowUGh
 xIIgbRgJCMTHjss+oIlhTeHhrfzzI3xT62ZE5Zi3u4s20AU7+RaMQOfnZgn1BPP6pAcYo/C3iJ
 iXp1+aC5IDFepM7EympRPMQW2SRuZbo6A+2crItYu+Su0QnsqIAff9z3XlTqaru2LIhBp/LLOo
 QE3ihjIJO8JHrkeS7ONCcOPr6ta0MjPwrRfNclUgkWI+kTnIAM78BuhMUmBWULLzOfaRHd+u3F
 myGssBIckR5FCb2zBEamJ2RB
X-SBRS: 5.1
X-MesageID: 59914560
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LKVXva5sGc+PicWeZo+d1gxRtDHBchMFZxGqfqrLsTDasY5as4F+v
 jBKW2+DPK3YZTbzfIhya9yy9ElQ6p7Xy9RhSgE/pCgxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z2
 M1slrfvRyESDrz1g74lYUV6IzwvIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWZh35wTQ662i
 8wxUBg+czTJfEd1JnA9BbYOldqYnHXibGgNwL6SjfVuuDWCpOBr65DpMdzIapmAQcJenW6Gq
 W/cuWf0GBcXMJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiUOkXd9bb
 k4d/CsyqrIp3FKkQ8O7XBCipnOA+BkGVLJ4F+w89RHIyafO5QudLnYLQyQHa9E8ssIyAzsw2
 TehlsPjAjFHs7CPT3+ZsLuXxRu4PjIUNikFfjMeShUe4MjLp5s6hRbCCN1kFcadhd3vGCrsx
 CiKoW48jrQXicMX/7qy+1nLhDXqqIKhZhUu+gzdU2ah7wV4TI2ofYql7R7c9/koBISWVF6ap
 1AfhtOTqusJCPmweDelGbtXWuvzvrDcbWOa0QUH84QdGyqF62aCXqsP7hdFFFZQKZw8S2PLU
 FKCplYEjHNMB0eCYahyaoO3Ls0ly6n8CNjoPszpgspyjotZL1Heonw3DaKE9yW0yRV3z/ljU
 XuOWZ/0VS5yNEhx8Nahqw7xO5cPzzt2+27cTIuTI/+PgevHPy79pVvo3TKzggEFAEGs/FW9H
 zV3bZLiJ/BjvAvWOHa/HWk7dw9iEJTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp
 y/mCxMCkQKi2yKWeW1mj0yPjpu1Av6TSlphYkQR0auAgSB/Me5DEo9BH3fIQVXX3LM6lqMlJ
 xX0U86BHu5OWlz6F8c1NvHAQHhZXE3z32qmZnP9CBBmJsIIb1GYorfMI1q0nAFTX3XfiCfLi
 +D5vu8tacFYHFoK4Qe/QK/H8m5dSlBBwr8vBBWRfYEIEKgumaAzQxHMYjYMC5hkAT3IxyeA1
 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMndqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP
 iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N
 mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5
 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
IronPort-HdrOrdr: A9a23:T6VqpKi1Xp772WXbdTWMRGF78HBQX0J13DAbv31ZSRFFG/FwyP
 rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKOzOWxVdATbsSlrcKpgePJ8SQzJ8+6U
 4NSdkaNDS0NykHsS+Y2njILz9D+qj/zEnAv463pB0MPGJXguNbnn9E426gYzNLrWJ9dPwE/f
 Snl656T23KQwVpUi33PAhPY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5kUUtKPpZ0fSKGMB28ffvyChPhHb3GLtBPB5ufke++3F0KjNvaDaDgiqFC36
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59914560"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BJb9j3xzd4rFoznGnG7FCP278fOHYL7hDaXmUmbTPa728FVQzi1bgHOF6F/BBF+Kw6UgHXEdVFjuaSXflJfxgaQzjdSo02bqvHvBo5FYtJK/YGd2+5J8Qxe9Qn7c43v7qcw3OvnxqqeZMYiycpGHhFKVY0uxmYS5gnf6431lFxWDoka+k38MFsHJu5ZBfOCC9U1u4yXbgUkPiUN8pwLyH7O+Uv6SekCZBZFxGItGL3yDCYRyEwCNoeX7CPjuJpWdVR5Sx9LK3wSXXUDtektiPoExzR/pBCPXlGqAtWN/xB2mEG/cC5mJyRFh3FAMS/wJZZ4iV0fQD+rwmkmzbrmVpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Kkztyy0W5pmcTI4txdMVindIopx+IzDgPSYR4q6jFf0=;
 b=Y81F3u/rOvT1UABPRS7+Fu7njubeaBw3GEwVKHTkoRItV4TcJUB2DT0nxsKl8Zf09W/dIXfdAyYn/Oa5Ar62ibxhWk9SWNrN7fhUgoGdp2TUBR3qtoEPYv6NAxJosuhrWoPkZ/humC4z/m88zozbzkWiHDrV6iQ5pMtg9awIYmzM3p+JRQ7bayktXwO+VDXXFvmmtg/t5rNROB2x0y05M/1rPIZ7uStV4RJFbl5osfoRaqXyreGnIpWrIlTlO4BJdvFP4h9tFX3vZwQ1d3kO/xXVD9DDZ+bLvYGCbPVPaRK8fc3TA9erASOKG+8TN1JrKYhh9pK0PdVFcORco1IGDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Kkztyy0W5pmcTI4txdMVindIopx+IzDgPSYR4q6jFf0=;
 b=qr+dQo7OGzrQrlvp/Bz4SCCvGyPh+nZjYsWYs8fPNDC0fTigzFi3j5QoU/JczKNPFWij47eqL3IcJDREqmFFBfvrCDdPQVlN1jc+8plaW1KvNZWNHxWaTXwaAyKtIgDzmrpD6ezLiAE26ociNh7bNaUpfMoFUMer0DRPePSyoiM=
Date: Tue, 14 Dec 2021 11:59:39 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC: <boris.ostrovsky@oracle.com>, <jgross@suse.com>, <sstabellini@kernel.org>,
	<axboe@kernel.dk>, <xen-devel@lists.xenproject.org>,
	<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable
Message-ID: <Ybh5G2ziyRXkz3WF@Air-de-Roger>
References: <d6f31db1d2542e1b4ba66d4cea80d3891678aa5a.1638476031.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d6f31db1d2542e1b4ba66d4cea80d3891678aa5a.1638476031.git.christophe.jaillet@wanadoo.fr>
X-ClientProxiedBy: FR0P281CA0051.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 99afef81-656e-4b52-b7ae-08d9bef0d59c
X-MS-TrafficTypeDiagnostic: DM6PR03MB4603:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB46032A8C372668D1D54BEA248F759@DM6PR03MB4603.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: qjDf5Wdg2n8t+hzFbXz3OjO4x+2JkPIzVcYfnUUjsynwpOae8IJfV5ltUP+6qbM1w/Az2x5oL7Pkk9iT5k1Sj7yFWI/wiGWwYZVr/21LSEcxpzayjAV9iZhbTRWWp04HslGCza7lqF3CnMq/wYTCdI4OOCToaaM3FZUAwH9JVeu3g8hTyt6mOpxuNMTh6/1LdryfpxzFSH67sDDc8R/8bPo9ZWMLabTqeTMGiVVADRpH9hCg79MCE1uq6DvVF4Ql+rcm7i+88HUwziOWWev3ClRXJrn2koPs59Zbn/2JzrcdGyaFMBDhtLJPGxowHbXT89mhzh7M+Ox4xHF6kYGrfNS1XEihVUfwIquKz2bt/XJ/yVSNmgpDnKPTkyXPTN9VpUoqxmk6CtthcrVmmZkIzQW/Fkdlva4QyyqDI4aVrDEyLNzT1djXE30VO1MWmGRABA7lAg8fnBy7NEP2h4gDpow4slhYIldTf1EXDZ3T0+dw6o8fjsCR/tygsy0ITdNLvdnAjnXPriI6gKWwsyWK7tF1wG+nDVCRaoKyRC8Y6FupJRCF0IyDZDWmpZL7nYGSizOPyQywnwk90Evt0/I4avPivGTU8v6uLUnn+v5mD/RDd5blEphak60kbJBa2EVzEjjtldXcob9HfQgj2O+21A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(316002)(8936002)(508600001)(38100700002)(33716001)(6916009)(6666004)(82960400001)(4326008)(8676002)(26005)(5660300002)(85182001)(66946007)(6512007)(6506007)(9686003)(6486002)(66556008)(66476007)(2906002)(86362001)(186003)(4744005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVRSNmpQdi9aMEIvVUsvU3NaR1NaOCtRRFN1Y3UwRmQxWmhQTWZyc3JVUWFJ?=
 =?utf-8?B?MndJYzhxYUFwTlVmUmp6M2tENDlFWm1CaE94VG9SZzlCZys2dzkwc28zWHBP?=
 =?utf-8?B?cy9UZHFlc25WemFlK002cWlmbkxKQ1hqd05pM0NVVDAyS2dSVWM4TEYya2JL?=
 =?utf-8?B?a2NMR0dNU2lYby9aQWxDKzVDMVpsWEkwMkNmRER6eDE1d291VXA4U0d2T3NY?=
 =?utf-8?B?aDJZOER6RmlMY0d5eVpDTVh6dk5RV1FEOUNDWEpLL1VmN0gyK083NC8rTTNU?=
 =?utf-8?B?UE9YSi95elh0WlJIREcwa09wVTVFaktVUkhpUzBMYmp1ZTN1Y0NtZUdiY1d3?=
 =?utf-8?B?VnpUclNocmpSVDRXSWFvTXdwMG1KeEZ6UlhpQXFGKzFtaDN6eTBWWm83MTZ3?=
 =?utf-8?B?V285MVZlWkVuS2ZKRWZFT0pyN0dwVEFxTUVxZlhRVFUyQURYRENQZUNnTmxY?=
 =?utf-8?B?cVFnNitkbmttZVo5SXdLNWN0VTFXUkZHVCtFOTg2ZzUvclhPTHJrQ1g0amxI?=
 =?utf-8?B?cVJocnJXSjVQN0dFMW5LOUVqb3F3c1ViNnFnbDV6YmJiYm1NRDhVOENXeEZo?=
 =?utf-8?B?Y0dPQUlESWpFSk9VQUFJSVBqZityL3BKTGVKeUZPcy95OG5OUDRUN2ppSTdn?=
 =?utf-8?B?M1ZPZFVhMUw3ZTBCRFVrTFYrZCtwZGtYWGJlZVZFbHhoVmZyM0VLVVJnUG84?=
 =?utf-8?B?UEZrYWM1aFRYYktZdytjdmtmV0dTYzg1bUlVejZsK0xiRXFKOXE0bTVrb1Yr?=
 =?utf-8?B?K0VIS0o0TkpJeFUvMThZNDEwOUpVWm02M2xWMmFuUjlwdmJkbE5EMW15eFBn?=
 =?utf-8?B?RkZ0MHBlVWlwYUFkbUU1Ykt0V09KTzhpTXluL2JvTTZKdW5YTXFzc0tMclhJ?=
 =?utf-8?B?RkxjbVFhVEtiTjYyNGZMUXQvUEMrUi82MGkwZVpOLzBmWG55aUFaTVVXZEp5?=
 =?utf-8?B?aldNVHVydkdFSUdobXVldTFremhqNUpsR0NmQ01ZbGJEU3YwUXZiZGtDSmM2?=
 =?utf-8?B?MzVETHBkMzZKQm1POTc5L1hhQjBOU0hlWkJuNHJVNFZLeEFJSitQdDJGZ0Yr?=
 =?utf-8?B?bjltVUFBaFdZbmZiek9XTnh4Z3IvOC9HTENCKzQ0ODhySnhidG9aQ3RJMVU4?=
 =?utf-8?B?bTloQStUTTNhanZjblptKy9ZdGw5SDFPTHNSckpIcXZray8rSXA1b1B4VDF4?=
 =?utf-8?B?ekRTSCs4QXJHSUpwd1lyRjEyOGoyenBjY3BFT0hscDg1V3U2U2FOdkt4enZS?=
 =?utf-8?B?bGNnNGpmMHBzSVN6YktMd3VVM3g2TlRwMEIrNkJldER0bnVuWEZaY2JSVkZz?=
 =?utf-8?B?TnJGYnErVCt3WWlWZW1jUWhkbzNLL014b0N3WTVNNXh6d21PMzlvMXMzMlVt?=
 =?utf-8?B?T2w4SDhPZG5xc0lKL1ZxS01lNERtSTZJZlh2UFEzWER0eFV4VGlhK2QvZU0w?=
 =?utf-8?B?bmZoNG9vNkYwVzd5dTBQclk4YjlWNDBpM3dBNTNnQ0tvandoQld2MmxEcStQ?=
 =?utf-8?B?ZXB2WG15c3gxNHBxZXBkaWhwc2NtQ2p3czVzcWRQSVFJaVl4WVlBdERoQzNy?=
 =?utf-8?B?bC9KbFJYVFdCVThRSWtHekxWSUkxcEl3OTMybHdvTTJFaEV4MDNvK3dGdnRC?=
 =?utf-8?B?bjR0clB3N3g5Tmh1cVlNbktSSi93eXVFc0d3RFBUZGNqUUI5MGNFZitrVVFE?=
 =?utf-8?B?dFAvS2ptelZpcjJmVlpuV1hvT0hRYVJ5ZHdmbWlkSHV0SVAzMlRhNDBlakd5?=
 =?utf-8?B?SkpScnJsMkYwSGNzaGZESi81eU5Uc0tJQi91UXhmK1B0c1RuUGsxWXEvOGR0?=
 =?utf-8?B?NUJOTjYyVDZTdXVPNEJWdUJyc1dYcVN3ZTgrbFRJTU1WcC9uR2VRNmVTQlM2?=
 =?utf-8?B?WG5HOTh5UUduNkF0SG5MV2hENm1HWmhaL0lvbnVNT2RlaXlrNmRXaC93bWFi?=
 =?utf-8?B?YlRWeTN1SVdheWVxdHQzMXc1NU01bTYrTzNteDl6MStIK2d4Q01CdlF1bmNS?=
 =?utf-8?B?b3Z2WU9BY0E3R1VpVjdvMkNvV0Z6OVh1OWpTVGJNVnVXY2xaR20wYVFwcTV6?=
 =?utf-8?B?K2M2dGFrNlViSngxemZKeVp5ZnN2eDczb0hNZWpxL1dqZkFqTEV1SHowOTVZ?=
 =?utf-8?B?S0kyRTU4UlliQzFMOFFSUlBvUlpiOENCdHRUb2Zra0VnUDBUcEhkdjBtT3NC?=
 =?utf-8?Q?ya2zW6Z0YySAaeTLZCd80xw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99afef81-656e-4b52-b7ae-08d9bef0d59c
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:59:43.5817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5t8e9VOrdWXOvS2DlEzhFhKgn34e6UhPkeTqxCIcyeawyf9uGB8FS8lfhods+tjncMV3rsvu58fkufLC6YnBkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4603
X-OriginatorOrg: citrix.com

On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> open-coded arithmetic in allocator arguments.
> 
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.
> 
> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:01:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:01:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246596.425273 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5YR-0001fE-Ii; Tue, 14 Dec 2021 11:01:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246596.425273; Tue, 14 Dec 2021 11:01:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5YR-0001f7-FV; Tue, 14 Dec 2021 11:01:07 +0000
Received: by outflank-mailman (input) for mailman id 246596;
 Tue, 14 Dec 2021 11:01:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mx5YQ-0001f0-0g
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:01:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx5YM-0005y9-VT; Tue, 14 Dec 2021 11:01:02 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx5YM-0007mf-P1; Tue, 14 Dec 2021 11:01:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=SY2NtsuHZYxhJkjj3ratLDMSWFvs5DrNh7WkKsLWtzE=; b=CQiPV9D1tCFwuSG+QsU1XN2Fks
	7HOKAM6mJ8YWy/76Vs/QBVpEvNikWG8qHHmVqP1/VFui8UoWvOnI04ua89G8p87w2ylDlCfKgapK9
	rIsRGLw4RM7o7OcMA+prsRb0lPsIvLBgQcARA4euSRP1mLfIJbZkQO42BvaouW/Pr6wo=;
Message-ID: <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
Date: Tue, 14 Dec 2021 11:01:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Replying in one e-mail the comments from Jan and Michal.

On 14/12/2021 10:01, Jan Beulich wrote:
> On 14.12.2021 10:51, Michal Orzel wrote:
>> Hi Julien,
>>
>> On 14.12.2021 10:33, Julien Grall wrote:
>>>
>>>
>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>> Hi Julien, Jan
>>>
>>> Hi,
>>>
>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>> Hi,
>>>>>
>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>> Hi Julien,
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>
>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>
>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>
>>>>>>>> Ok.
>>>>>>>>>>
>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>>> needs to be fixed.
>>>>>>>>>
>>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>>
>>>>>>>> I would say:
>>>>>>>> "
>>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>> "
>>>>>>>>>>
>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>
>>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>>> when not passed.
>>>>>>>>>
>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>
>>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>>> ```
>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>> ```
>>>>>>>
>>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>>> wrong entry.
>>>>>>>
>>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>
>>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>>> then merely extend to
>>>>>>
>>>>>> .if !0\hyp && 0\compat
>>>>> Isn't it effectively the same as setting a default value?
>>>>>
>>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>>
>>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>>
>>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>>
>>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>>
>>>>> Cheers,
>>>>>
>>>>>>
>>>>>> or something along those lines.
>>>>>>
>>>>>> Jan
>>>>>>
>>>>>
>>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>>> stp wzr, wzr, [sp #8 * 0]
>>>> stp wzr, wzr, [sp #8 * 1]
>>>> ...
>>>
>>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>>
>> I hope you meant str and not ldr.

Yes. I am not sure why I wrote ldr.

>> So a loop would look like that:
>> str wzr, [sp, #8 * 1]
>> str wzr, [sp, #8 * 3]
>> ...
> 
> Why "a loop" and why #8 (I'd have expected #4)?
> 
> There's another oddity which I'm noticing only now, but which also
> may look odd to me only because I lack sufficient Arm details: On
> x86, it would not be advisable to store anything below the stack
> pointer (like is done here when storing x0 and x1 early), unless
> it's absolutely certain that no further interruptions could clobber
> that part of the stack.

We are entering the hypervisor with both Interrupts and SErrors masked. 
They will only be unmasked after the guest registers have been saved on 
the stack.

You may still receive a Data Abort before the macro 'entry' has 
completed. But this is going to result to an hypervisor crash because 
they are not meant to happen in those paths.

So I believe, we are safe to modify sp before.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:08:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:08:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246604.425284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5fm-0002RX-G5; Tue, 14 Dec 2021 11:08:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246604.425284; Tue, 14 Dec 2021 11:08:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5fm-0002RQ-C6; Tue, 14 Dec 2021 11:08:42 +0000
Received: by outflank-mailman (input) for mailman id 246604;
 Tue, 14 Dec 2021 11:08:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx5fk-0002RK-Nd
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:08:40 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2e544945-5cce-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 12:08:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2e544945-5cce-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639480116;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=5EAFu/HMn9FrEeyNoroT7Pt3sVrE+2Ra3fLKi5vt3OY=;
  b=NysZMy4dI2ACr/HuAHcK6cJfkMC3njwAEJ2aQMuCymjFVv1jN4bahrUV
   so1PhJq2StWnKXT7kpck6nilUfIw3UacYtSglBiXOa2IoaDz2x7hFlxv3
   dCZ/CZqCOShhmLRmMR8BGHxmWN8eKJI4nEDc5vwJ2MzEWEybkBdD2Ffoi
   s=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: B8Z1VmTAJwOsifiTBGGNYVhTDSDM+MiSB/GML7aO9RqIUVPhBdPrfQ9qWqxmy2ADGVbP2Xb5Bw
 whNArWDYilhGr7pwMwRXsi1V6+Tgl8+uLQ8pb8IQ3928wZ1K2zhXpiPffb40UlR5CZ/j/G/i3p
 OeyVQRiEaabDaBxjLNGnJSdTR9OklxVIHP3VRsRYqJM63el5/P9bwLePTYWy/KSpJ2krLdwtt6
 T6Xpbbbd5em52TTHkBrmPTAS6mUP6dSpSvrnEFDpCxMPDABINNysZB4qmVv8XSTjYUyDl5B6Yn
 bsZ5mtz5NjWiUB/SMicZpHnk
X-SBRS: 5.1
X-MesageID: 62039465
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Azrtmq7Cgv7AyYhnYhMirQxRtDHBchMFZxGqfqrLsTDasY5as4F+v
 jEZCDuHO/iJazamL4p3b9/koRhUucDWydVkQFdk/ikyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx
 tlUjs2SeFYTJYLIhvQnDUhXIzFPBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgm1o3ZESQ6u2i
 8wxRR1ybU7yfBx2ZFoLDsIGh7uSmyjBbGgNwL6SjfVuuDWCpOBr65DpMdzIapmAQcJenW6Gq
 W/cuWf0GBcXMJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiUOkXd9bb
 k4d/CsyqrIp3FKkQ8O7XBCipnOA+BkGVLJ4F+w89RHIyafO5QudLnYLQyQHa9E8ssIyAzsw2
 TehlsPjAjFHs7CPT3+ZsLuXxRu4PjIUNikFfjMeShUe4MjLp5s6hRbCCN1kFcadhd3vGCrsx
 CiKoW48jrQXicMX/7qy+1nLhDXqqIKhZhUu+gzdU2ah7wV4TI2ofYql7R7c9/koBISWVF6ap
 1AfhtOTqusJCPmweDelGbtXWuvzvrDcbWOa0QUH84QdGyqF9XK6RtFy0WBEP2htLNY+J27mU
 F/igFYEjHNMB0eCYahyaoO3Ls0ly6n8CNjoPszpgspyjotZL1Heonw3DaKE9yW0yRV3z/ljU
 XuOWZ/0VS5yNEhx8Nahqw7xO5cPzzt2+27cTIuTI/+PgevHPy79pVvo3TKzggEFAEGs/FW9H
 zV3bZLiJ/BjvAvWOHa/HWk7dw9iEJTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp
 y/mCxMCkQKi2yKWeW1mj0yPjpu1Av6TSlphYkQR0auAgSB/Me5DEo9BH3fIQVXX3LM6lqMlJ
 xX0U86BHu5OWlz6F8c1NvHAQHhZXE3z32qmZnP9CBBmJsIIb1GYorfMI1q0nAFTX3XfiCfLi
 +D5vu8tacFYHFoK4Qe/QK/H8m5dSlBBwr8vBBWRfYEIEKgumaAzQxHMYjYMC5hkAT3IxyeA1
 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMndqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI
 +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B
 B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP
 iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N
 mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5
 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
IronPort-HdrOrdr: A9a23:qxryUqAY2aqKuKTlHeg2sceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="62039465"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kuYPJW8sdJpKXA0L1MuvjnJNJ9cdc0i3elUUcWC920hUpT4DXgE06ZOSCT5QJoe+hbBKzRz3QriGuAn815QUk+az/7nk6Q26TYvgY/5623Z66RtrrLZdZ+tRDd+Mfke+lPZNx/kD2xZTM/vh6Z42qoMJ9t5FiNqbUMtquw+MnYzuzjDgBhxcWNZ/Qj1ZznfFD99Tfu/ojeIk4ykj5jUHospylDFRX0dSzE3g0cmWdWBV7p3LeUJWr3qNLvjqEzLmAaqkQ+V7rALEWgrzst+5cUqIlonJ2VdKvQjnhgAVmA27ifH7U1SZk9MW7QfEJB8QfriI/uDYz8Sl62Dy4XO02Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=73NJWetcVUrSo6Bba6C96xaPBU2yixLWFWq42EYFVtE=;
 b=mZwzQ80avLBZvllUUK8cAIORSfk19ahN9QlrTrryelBUbfkT3fz7GBHjNiQtSWutdYyX1YPffKrLEWPxc2cd1kWi+AUd3ukM+viNsHzoi9jooDB/zuI4la8nD7cquxBy7UXN6rJotr7iISIgkl0UXmkHG07/pC1EGDi9X5cR7as5a1l09PC1MOXk0uwmhxDZ+mv3jgWA5Ik3i2njmDiqJ0hlKrwq9W/skXWUMeCldT6Otr3agYwCDVgcYysITX1BJHfjd4CDiKUVWkIiJwbfhQ+nV70wBuoofkMq+9ZeaTj8FnYpyDp944QTZo6sw9ZWkB3YA56IFdpmWB7VN+oiTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=73NJWetcVUrSo6Bba6C96xaPBU2yixLWFWq42EYFVtE=;
 b=mV10h1P0LAKaxTwnLQAch/+xu47AfySrX1wXTyqsvSVI5d9d0Thkq16Udpgfjg2iGdFtSL3n7Z2XeEWgM7EFylwWORfHcR4hZUd5PUU2+DO4+/H4QX92iNZKw37zvxris2VAgHkV8VMzYG7V92nJcClgjP4FPPr3oRlB5+0b7VA=
Date: Tue, 14 Dec 2021 12:08:26 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
CC: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	<boris.ostrovsky@oracle.com>, <jgross@suse.com>, <sstabellini@kernel.org>,
	<axboe@kernel.dk>, <xen-devel@lists.xenproject.org>,
	<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable
Message-ID: <Ybh7KgtQt0/MFtyw@Air-de-Roger>
References: <d6f31db1d2542e1b4ba66d4cea80d3891678aa5a.1638476031.git.christophe.jaillet@wanadoo.fr>
 <Ybh5G2ziyRXkz3WF@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Ybh5G2ziyRXkz3WF@Air-de-Roger>
X-ClientProxiedBy: MR2P264CA0160.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::23) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 35627b30-57d5-4ce5-1c5d-08d9bef2102d
X-MS-TrafficTypeDiagnostic: DM6PR03MB4971:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB497102200AC5DD8776A863DE8F759@DM6PR03MB4971.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LzCS+4iQlwBnB+Ly3nHX84Mx0FJQlLWb+/rCdUKj1dkeYxOFqIUvPA4sV8EvRgQ4GrUmwGyZmo6HtgLNOCDyYrfdfY5rShUn3TQ/P6pg0FPZhlVokkywyKvrPSIfgOFoXt7kNcaM95Uv0qGgsQm+F9wDdy3/AU0P0fPtnGKc1lNdfn73E3oFVm21dlOA7vqHF/M4PVDN46siAARON+soIxBc1mqI+BloN7744cUSP4jVUq+BNo7pkj4KINgdo8VCXugioDJWmY9b09m+7ydYnAfRmKY4Bs273f4di6WGbYqEF1Ux1kkfSioycx+c/C1x6L9jKQQW2Nz4T8sTp0HIb63mgUUQ9vPLzhaiz7/mzoK8jITH8CNccKYeHNSpNAIyINX+XSUuDFioqJMjsZRVlpkf6qPnJadN0/lpBWXdDU9DkhXgUI23rEnKc9L+FqIyeuxpdLNblpUIWuVlsfVzFmE31pv1nnhF/kR6UR3gdhLbdgH2q5JHSm6mwaVrdiNX7dliF9ifP+XqVlI2JntWpPo6U+LeKA52pN49e2pzKs0ARjWc+XvcEZt6U8mCcMikAU1RV/U1pi7PO01ce6Tgip0uT4u4X/GZljFCRQzaYFQfVuFaAhlAkUWLJbIoB6FpeO8DQli4vWKcabneQ3rpsA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(508600001)(6862004)(6506007)(2906002)(186003)(6512007)(86362001)(6200100001)(316002)(9686003)(8676002)(26005)(33716001)(6666004)(4744005)(8936002)(66476007)(6486002)(66946007)(5660300002)(85182001)(38100700002)(66556008)(4326008)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlRpUXMxb3F6QjRqVlpMWDhjdy9qS3JiZVdNL2d3aUZrYi9oWHo2d1ZHM29l?=
 =?utf-8?B?WGhPYy8vQ0crWkVJYy9YdDhXaDh1SjY5TmFveFpFMXNWZ240dlU0Vko5SGR5?=
 =?utf-8?B?MXhxZWJ5SGFxQVRYQTVTclViZ0FEcnp4MUQwclhvakRSVFp1SUFMR2pMcVlJ?=
 =?utf-8?B?dGpiUitkZXQ3YzB1d000VGFKSlZhZk5SUUFBTWhTbGpOZGVTS1ZrWGhQYmlY?=
 =?utf-8?B?S3Z1YXRxU2lrMHBzNTgxM2lKUENQbzZSZndVSllNNy92RWVUNnRxY0JxN09l?=
 =?utf-8?B?NkFHMlJWTjZZUjJ4S3F4eUN0bGJqUHFtYUVqQTRMTVdYeDNkSFRFZHV5MzJM?=
 =?utf-8?B?VjlSWDVOZTB3V2VyNmJWTHlsNjJ2S1lCNW5NNUw2NmZFQUhFclF3K0FkNlk0?=
 =?utf-8?B?OWpadHNsbzlkc1Q3MFBEK2lpSWdBVzk0Smg4bEtqTXdLbkE3V25XTE9Tb1ZX?=
 =?utf-8?B?eEVTQStFckI3cmgwQkVTWGI5NlMxS3hCMzg2V1hYT2d5M0tvZFkrZkQ2NHRZ?=
 =?utf-8?B?ODJZM25xWEVuWm1lRFlqWGl0bXFKOUp1czEvRjJiMUlxMmV2QnVrSFZBbmh6?=
 =?utf-8?B?NTRNdzU0OTUrK1dlUDZjVDVQTEdETFdCTGlQZVdPdVN1TGJQbHF3bER3QlNo?=
 =?utf-8?B?TmluelRDVDZDSzl2YzJHVGU3aGdBK251L09la1REd1MrUm1EaTI5UUhVTTUw?=
 =?utf-8?B?OXE2bk91aFRyTlc1NGk5c3lMekZIWmhzc05NYnF1aG8zc2QzbGI0ekRWNDV3?=
 =?utf-8?B?SHlHb3R4cnZ4d3dnZ1NjMWUvUTI2bHVxSGc5TmdIelJQaHM5TTJwcW1UUSt6?=
 =?utf-8?B?OWcrbVp3TmdDWFF6TjExQkQ1YnZzUnFNR2g2cXFrd2s3aEdxZEM5LzUrRmRa?=
 =?utf-8?B?VC85QVl3ZFQ4SmdrMXVhRE5RSkQxQkVNajk4N2xsdXRRUk1Kd0ovUVppWmJw?=
 =?utf-8?B?a3FPa0E4Z0RJaEZ1dFprWlpQZW9MdHMvcnNMUDB2RmRuakhVM2xaQUtyNGI0?=
 =?utf-8?B?ZEdJVDlrWXhEc0VtRDI2ZE96V2Q3SU5JNFBDTFBNY0dRTGxhbG9VTWZoUGxO?=
 =?utf-8?B?ZEltb0ZQMUdLOGExR1c5UlB1RUs0b3JlZzk2NVIxbUxVclRzbHlTdDZpQjVF?=
 =?utf-8?B?SGQ5MkZnNFk4UlhMZGJWVTlnTjVjK21FNTFVUFFLUElZcENxdFliOHdTbHV5?=
 =?utf-8?B?clNYbzAxKzAwdXRyWFVXNFVudnF1WUM3Y2NkU3pOZXV4Ny93bVVOSWhoU0Q3?=
 =?utf-8?B?TnkxUFkyRHhpWThmMUdMYS9QaTBKaFprRk1CSGpxRkQxRGZISDQrcjZTakM1?=
 =?utf-8?B?WXFCdE81ZnNRMytuVEtWMWJuZmpLdWJtYXdIeStQUiszYU9lL1VNaTVnYWhs?=
 =?utf-8?B?ZTBuMzdnWUdoazdOKy9hZThPOWZyVU9OR01zNVlBRUp0aW9yWU5tN1RTRVM2?=
 =?utf-8?B?WWdZQmJIa05NczJVOHQxbENEZzBzRmtOZGFvaFdvbm0vK1lmWHlic0VaWDJ3?=
 =?utf-8?B?Z0tpVGRuQU9LVXZ4SXpoRFdqZCtZcFZ3ZnJUbGQrMTNvd0JqbStPSHdMbVl1?=
 =?utf-8?B?c2laQ3lPKy9NVVdJdFJ6NC80Zm1vNzlzYksrL3VXa3lZUk9heExseHk5OEQv?=
 =?utf-8?B?dUM5d3U2dE4yYTFHMkxnd3h5SUgycmhEMVlBbjloY0VhdWNaU3hNOS8vTlIw?=
 =?utf-8?B?UTcrSHhHVWw4enY1dVFnWXlUSUt0MFZzU3JPT08xTkZjNGlnTHpCQTdQTzZ2?=
 =?utf-8?B?MUh4TXZsdWhPaWxrQUNuL0pyTkVqWnVUR2ppN0ErdVFXUENkQXF4dVNWTnRw?=
 =?utf-8?B?cVFwYUVDR1A5ZS9HRWZUSXB3T3NPRERRUlhHdXdQbzl4c2xuY3d2cnFpalNz?=
 =?utf-8?B?RS8rbWxlcHBkNzYyZWxXL1IrYkpHUFByb3FGMUFhcDFqSWRmUjdETXVTbG53?=
 =?utf-8?B?SDFGWVhwdG40aXRBYXNkY29CeXdRNXF3eUJDZmxhK3VXRTd3TVNyQTNUUHRx?=
 =?utf-8?B?b1hjU2hVR2JiaUlFa0FWc1llVm9RaE5JQjJnUzFOODVyV1dSemU1OG01VFdt?=
 =?utf-8?B?NlNIZXhtbkJNeS9tN2Iyb216dEl2ZEhIKzRjN0x0dnlscWtRSm1VRFlDTEV2?=
 =?utf-8?B?Q0pwS1ozM2xzNi9uTUtFVWJMbzVzUGdHWlAwS2NPa21yOVJNNjg5czJSa2JU?=
 =?utf-8?Q?SMTkc6lbhfKijSAPEEMiers=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 35627b30-57d5-4ce5-1c5d-08d9bef2102d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 11:08:31.2998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hl8D57BSl0OchbNbsrFFnyi0Cg8S0PwsDgXGQ19h4OF2KR182VbTnroB7x4L+oI8zs5ukrBuIVarH6gy2kZslQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4971
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote:
> On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
> > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> > open-coded arithmetic in allocator arguments.
> > 
> > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > consistency.
> > 
> > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Oh, I see there's been further discussion on this to avoid relying
implicitly on the size of the bitmap being rounded to the size of an
unsigned long. I think a new version is expected then?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:29:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:29:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246610.425295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5zJ-00052m-5m; Tue, 14 Dec 2021 11:28:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246610.425295; Tue, 14 Dec 2021 11:28:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx5zJ-00052f-2P; Tue, 14 Dec 2021 11:28:53 +0000
Received: by outflank-mailman (input) for mailman id 246610;
 Tue, 14 Dec 2021 11:28:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q7Ra=Q7=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mx5zI-00052Z-HY
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:28:52 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 021cafdf-5cd1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 12:28:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 021cafdf-5cd1-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639481331;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=7H6Ek+0WUR6KXWgs7sDLcHzMH3wOPYLluORhQ7+YqqA=;
  b=NKUWTNtBVGtezrD4VmlzBhN99h8cMI2ChE+wBmOFtZvqReAc77qSzYqy
   fnH5Q3NuH56UDeSRLA9bdvN8FjNoJUvoeLCqFt3mB+JwT0SutCNftW5+t
   rK87wv7j0X/4YDyq4xyXCjuOH6Aw6F0nYLSPkMDfK0QoDqiAxd5RydJ7f
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: a+r3lEELtNgy5tt0jrMaNNkcKYUtKOBq8fKHtxeCTYxkwmPv7kUJrataz+Jt6mzudzGXab3Fwh
 E26DjK867qflkE8CLDCHrbuqCDyBR+1CEXu2EdqHjvQbDlCQwUrimL7BZV1vAJan6/OHJjqCyl
 SR35KczzFJJy07i8AyNuLTEUjiXIJCKxbd5AdLqAnRHBmP0QxNbkkf46zVbdH0NcwlksgelKVA
 7HIA14pU2i/h3+AdqdFeGpsjPa8cNcF11uD7GGxHrLHtWwWQhTunAJ3Zjcw4skjVqE/BllLxkp
 1yocOJOrpzXg0nHNpovKqxOB
X-SBRS: 5.1
X-MesageID: 62040645
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4nCCz6J+aDYt3PcZFE+REpIlxSXFcZb7ZxGr2PjKsXjdYENSgjcBx
 jMeDTuEOK7cZmWhedt2aY/nph5U6sWGz4RnSwdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg6x7Zj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB21mv1s8
 dMck6ChRDwrHrTWldsAfBhHRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Glq3pwWQ6qDD
 yYfQSMsVRL+RzpDAG8OB5szwcuigX3gLSIN/Tp5ooJoujOOnWSdyoPFL979atGMA8JPkS6wp
 G3c+H/iKgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiEKBkwMlXYt2L/w30wOt07DZ3Bu2B3dRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl8pDGJGT9bxgbQ+0RqmBNzGJrVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtEMumgmeRk2Y5ZsldrVj
 Kn741w5CHh7ZiTCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2l3hW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyil08CDbagO3aPqub+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yb5zexzdop7sb5Sk+uUr
 HixVlUBkAj0hGHdKBXMYXdmMeu9UZF6pHM9HCotIVf3hCRzPdfxtP8SJ8ktYL0q1O1/1vooH
 fMLTNqNX6ZUQTPd9jVDMZSk9N5+dA6mjB6lNja+ZGRtZIZpQgHEo4e2fgbm+CQUIDCwsM8y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg6Zucc8WKBjFyj+L7
 CqsAE8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYwq2uMPADm1oW4YNwH6wykPA77trr4bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFt3Z+uO4vgYhz3O4KlnO079/iJ2oOKKXEg608NgU8CBwG+Z6L8Y/
 No=
IronPort-HdrOrdr: A9a23:e1dIwaNLJl2cwcBcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy
 nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ
 uIGJIfNDSfNzZHsfo=
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="62040645"
Date: Tue, 14 Dec 2021 11:28:45 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell
 ...)
Message-ID: <Ybh/7ZYFKWTe6Cps@perard>
References: <20211213190449.4830-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211213190449.4830-1-andrew.cooper3@citrix.com>

On Mon, Dec 13, 2021 at 07:04:49PM +0000, Andrew Cooper wrote:
> Something slightly weird is going on.  Before this, the exact number of hits
> that verson.sh gets isn't stable, even when running repeat incremental builds.
> I suspect this means we've got a lurking parallel build issue.

It could simply be that `make` have decided that one of the Makefile
have been updated and thus `make` need to reexecute. And I'm pretty sure
it would be because of the generation of those .*.d2 files from .*.d
dependency files.

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:30:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:30:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246615.425305 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx617-0006Vs-H3; Tue, 14 Dec 2021 11:30:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246615.425305; Tue, 14 Dec 2021 11:30:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx617-0006Vl-E7; Tue, 14 Dec 2021 11:30:45 +0000
Received: by outflank-mailman (input) for mailman id 246615;
 Tue, 14 Dec 2021 11:30:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mx616-0006Vc-Kn
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:30:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx611-0006UC-6p; Tue, 14 Dec 2021 11:30:39 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mx611-00016a-0S; Tue, 14 Dec 2021 11:30:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:From:Subject:MIME-Version:Date:Message-ID;
	bh=JgIY7zp+DbsiQhlfWN/u9itAQOCp6RXi1GyiBcC5k1M=; b=gUTCDcUGkX9kYEYEpwhz2BzEIc
	GZ6KPw2VAdCYFmOQ3iWS9obWS1irypscDHRszYbQTsmOEnPOoB3ejaXMSYfnN56GfvI9n9PHxlJqi
	AK/FwYPYMS1DEpjsyK0vv6vr1TG2Dbn684slR1rQ57AgRZGVxBqGiPgaunFIP8YHrJac=;
Message-ID: <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
Date: Tue, 14 Dec 2021 11:30:37 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
In-Reply-To: <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 14/12/2021 11:01, Julien Grall wrote:
> Hi,
> 
> Replying in one e-mail the comments from Jan and Michal.
> 
> On 14/12/2021 10:01, Jan Beulich wrote:
>> On 14.12.2021 10:51, Michal Orzel wrote:
>>> Hi Julien,
>>>
>>> On 14.12.2021 10:33, Julien Grall wrote:
>>>>
>>>>
>>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>>> Hi Julien, Jan
>>>>
>>>> Hi,
>>>>
>>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>>> Hi Julien,
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>>
>>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>>> "If the general-purpose register was accessible from AArch32 
>>>>>>>>>>> state the
>>>>>>>>>>> upper 32 bits either become zero, or hold the value that the 
>>>>>>>>>>> same
>>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>>
>>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>>
>>>>>>>>> Ok.
>>>>>>>>>>>
>>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed 
>>>>>>>>>>> and this
>>>>>>>>>>> needs to be fixed.
>>>>>>>>>>
>>>>>>>>>> Can you outline why this is a problem and why we need to 
>>>>>>>>>> protect? IIRC, the main concern is Xen may misinterpret what 
>>>>>>>>>> the guest requested but we are not concerned about Xen using 
>>>>>>>>>> wrong value.
>>>>>>>>>>
>>>>>>>>> I would say:
>>>>>>>>> "
>>>>>>>>> The reason why this is a problem is that there are places in 
>>>>>>>>> Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>>> If they are not, this can lead to misinterpretation of Xen 
>>>>>>>>> regarding what the guest requested.
>>>>>>>>> For example hypercalls returning an error encoded in a signed 
>>>>>>>>> long like do_sched_op, do_hmv_op, do_memory_op would return 
>>>>>>>>> -ENOSYS
>>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>>> "
>>>>>>>>>>>
>>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers 
>>>>>>>>>>> on an
>>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>>
>>>>>>>>>>> Set default value of parameter compat of macro entry to 0 
>>>>>>>>>>> (AArch64 mode
>>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if 
>>>>>>>>>>> parameter is blank
>>>>>>>>>>> when not passed.
>>>>>>>>>>
>>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>>
>>>>>>>>> Yes, this is a compilation error. The errors appear at each 
>>>>>>>>> line when "entry" is called without passing value for "compat".
>>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>>> When taking the current patch and removing default value for 
>>>>>>>>> compat you will get:
>>>>>>>>> ```
>>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>>> ```
>>>>>>>>
>>>>>>>> Thanks for input. I am concerned with your suggested approach 
>>>>>>>> (or using
>>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller 
>>>>>>>> to not
>>>>>>>> properly specify compat when hyp=0. The risk here is we may 
>>>>>>>> generate the
>>>>>>>> wrong entry.
>>>>>>>>
>>>>>>>> compat should need to be specified when hyp=1 as we will always 
>>>>>>>> run in
>>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>>
>>>>>>> Since my suggestion was only to avoid the need for specifying a 
>>>>>>> default
>>>>>>> for the parameter (which you didn't seem to be happy about), it 
>>>>>>> would
>>>>>>> then merely extend to
>>>>>>>
>>>>>>> .if !0\hyp && 0\compat
>>>>>> Isn't it effectively the same as setting a default value?
>>>>>>
>>>>>> The reason we seem to get away is because other part of the macro 
>>>>>> (e.g. entry_guest) will need compat to be valid.
>>>>>>
>>>>>> But that seems pretty fragile to me. So I would prefer if the new 
>>>>>> code it added within a macro that is only called when hyp==0.
>>>>>>
>>>>> So you would like to have a macro that is called if hyp=0 (which 
>>>>> means compat had to be passed) and inside this macro additional 
>>>>> check if compat is 1?
>>>>
>>>> Yes. This is the only way I could think to avoid making 
>>>> 'compat'optional.
>>>>
>>>>>> Cheers,
>>>>>>
>>>>>>>
>>>>>>> or something along those lines.
>>>>>>>
>>>>>>> Jan
>>>>>>>
>>>>>>
>>>>> So when it comes to zeroing the top 32bits by pushing zero to 
>>>>> higher halves of stack slots I would do in a loop:
>>>>> stp wzr, wzr, [sp #8 * 0]
>>>>> stp wzr, wzr, [sp #8 * 1]
>>>>> ...
>>>>
>>>> I don't think you can use stp here because this would store two 
>>>> 32-bit values consecutively. Instead, you would need to use ldr to 
>>>> store one 32-bit value at the time.
>>>>
>>> I hope you meant str and not ldr.
> 
> Yes. I am not sure why I wrote ldr.
> 
>>> So a loop would look like that:
>>> str wzr, [sp, #8 * 1]
>>> str wzr, [sp, #8 * 3]
>>> ...
>>
>> Why "a loop" and why #8 (I'd have expected #4)?
>>
>> There's another oddity which I'm noticing only now, but which also
>> may look odd to me only because I lack sufficient Arm details: On
>> x86, it would not be advisable to store anything below the stack
>> pointer (like is done here when storing x0 and x1 early), unless
>> it's absolutely certain that no further interruptions could clobber
>> that part of the stack.
> 
> We are entering the hypervisor with both Interrupts and SErrors masked. 
> They will only be unmasked after the guest registers have been saved on 
> the stack.
> 
> You may still receive a Data Abort before the macro 'entry' has 
> completed. But this is going to result to an hypervisor crash because 
> they are not meant to happen in those paths.
> 
> So I believe, we are safe to modify sp before.

Hmmm... I meant to write on the stack before sp is modified.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:41:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:41:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246622.425317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6BT-000888-J3; Tue, 14 Dec 2021 11:41:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246622.425317; Tue, 14 Dec 2021 11:41:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6BT-000881-EE; Tue, 14 Dec 2021 11:41:27 +0000
Received: by outflank-mailman (input) for mailman id 246622;
 Tue, 14 Dec 2021 11:41:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx6BS-00087u-9s
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:41:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c3033453-5cd2-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 12:41:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3033453-5cd2-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639482084;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=RohtPB1UjVwnzrfRWCirW2a3bXeTQxQ879ydkM3kt7c=;
  b=EiVQrVrNQPdGzfN8PJSJxGESLXO+tBe1x/1ogpJgb9SOPPLK+3pWRGqT
   +p6nBojiJnlN+N8gCm1vP4+xsUNC0qMZEtA4m53Xs6aY4llbIcNaFojdx
   Or/BINdpBUNAqs7J5Hj/u7f53LWg+e5XmlE0U+3BQ5LSXL4I5Lu9l+6Qv
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: bNrJJbYwc6rf+JWM64rwKXsAcMWUa+0sEIrPGYEn7VUhqptoOK1oe+Xsmwd1IJx5gx0m0zR5rB
 hbBWea6jEG/VHKV8rwyKQceGfzdZvYzm5gC5H6CvcZYMuiEj/PJsQ/d2lVzKbg+v2eW0IIWzh8
 GYAGIaHW9tkfq5SzEeiqXL/NxSDdp5V1+PurIpCX4L3BRZDBIPgSdaGzOjbPJh+JTfNp7Rkwo5
 xG0GQJZYfMY+mTfbW5E6RVRi7DLijvi4TJ1S0Dr0qQUgJuZbWMEJDK6o3gDAQtrELRg4Kiy7u8
 JkiTdIFSaZugZsC40KOFOuQN
X-SBRS: 5.1
X-MesageID: 59475194
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CBGquatlAEPoyr7m7tnxnTaGsufnVKFZMUV32f8akzHdYApBsoF/q
 tZmKWDUPPaPYTSheNAiYNnjo0wHvZHXnYI3QAU9/3sxEiND+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy2IThWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Nplvp+IZjsSI7D2sulaVURHHiR6Ao8f0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY25ESQquHN
 pZxhTxHSwvyTTdwIgsrNrEXurexqCDDbWZUkQfAzUYwyzeKl1EguFT3C/LNc8GObdVYmACfv
 G2u12f0HBAccsCewDyt83Swi+uJliT+MKoQHrCl8v9hgHWI23ceThYRUDOTsfS/z0KzRd9bA
 0gV4TY167g/8lSxSdvwVAH+p2SL1iPwQPIJTbd8slvUjPOJvUDJXQDoUwKtdvQtt/cZeQc3y
 2WjkpTvWCNitbmqayu0o+L8QSyJBQAZKmoLZCkhRAQD4sX+rIxbsi8jXuqPA4bu0ISrRGiYL
 ySi6XFn2u5N1ZJjO7CTpAif21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1
 UXoevRyDshSXflhdwTXGY3h+Y1FAd7fb1UwZnY1QPEcG8yFoSLLQGypyGgWyL1VGsgFYyT1R
 0TYpBlc4pReVFPzM/QmP9joU5l0kvmwfTgAahwyRoARCnSWXFXYlByCmGbKhzy9+KTSuf9X1
 WinnTaEUi9BVPUPIMueTOYBy747rh3SNkuILa0XOy+PiOLEDFbMEO9tGALXMogRsfLcyC2Io
 o03H5bblH1ivBjWP3C/HXg7dgtRcxDWxPne9qRqSwJ0ClY8RTx6VaaOmehJlk4Mt/09q9okN
 0qVAydw4FH+mWfGOUONbHViY6noRpFxsTQwOilEALpi8yFLjV+H4PhNep0pU6Mg8eA/n/d4Q
 +NcI5eLA+hVSySB8DMYNMGvoItnfRWtpASPIyv6P2RvI88+H1TEqo3+Yw/i1CgSFS7r58Ewl
 KKti1HASp0ZSgU8UMuPMKCzz0m8tGQ2kf5pWxeaOcFafUjhqdA4KyH4gvItDdsLLBHPmmmT2
 wqMWE9KrujRuY4lttLOgPnc/YuuFuJ/GGtcHnXasunqZXWLoDL7zNYZAuiSfD3bWGflw4mYZ
 L1Yn6PmLfkKvFdWqI4gQbxl+r0zuon0rLhAwwU6QHiSNwa3CqltK2Wt1NVUsvEf3adQvAa7V
 x7d+tRePrnVasrpHERIeVggZ+WHk/oVhiPT/bI+J0CjvH17+7+OUENzORiQiXMCcOspYd19m
 epx6tQL7wGfiwYxNofUhy9ZwG2AM3gcXvh1rZodGoLq1lImx1wqjUYw0cMqDEVjs+lxD3Q=
IronPort-HdrOrdr: A9a23:ATWZqa+0Y5RkBRK5zoluk+FHdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJPhSQRI+Lp3+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G
 CAymXCl+memsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb
 D30lodFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNyN+NxwaZiNjfJ4Uspu99xlI
 hR2XiCipZRBRTc2Azg+tnhTXhR5wuJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed
 NpENrX6J9tAB2nhkjizypSKeGXLzYO9k/seDlGhiXV6UkYoJlB9TpZ+CRF9U1wsK7USPF/lp
 L52+pT5fZzp/QtHNFA7dE6MLyK41z2MGLx2V2pUCba/YE8SjrwQs3Mkf4IDN/DQu198HJ1ou
 WGbG9l
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59475194"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fa3lw7IwPQK1w5gU7ki9fPsgoGzSGTinEVznEY7fqQwaVnN19RY1LIBP9TDuJdGp2ApAfNcDDMGJZYGpAFfx3d3cSuUPaaFlfEAZtJWl+acj1RmsNIV7DHhNFmbtZda6R4e+2Zd9oEAJ4EOzAKkgidGMDY85AxNhklaq1QOgDDjHRr1RUgf80JdtcNPdr4B+6OwS6Wmnn8jKmVE6g35Ym5tmWPI5aJRORGEzkR0/9bwhh5qpy8iX1tlP/yXPQAigja8zDrVlFIXGZBFS4sSasBoPYO/buBwu9gL3+h4KrFINWudCSpiYe+9jvbGrua6is+/crMHZVYBUZh9FMG7xGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=v+8BpJzw0eKICSZuO/VYrw03LPgsY0enNxrFAfUBmiY=;
 b=gDRSBFkD1u4u6LvkG/KC2wyD95EqyE355CHPp6xiDqpX8a9TT2nXbYocZKiufzJXuNhKpne9vGXuUyFEUr2coYgkPuJpe6q/uiN+liB6p+IucGHHamlo8KCmNH30HZ7C0/0nuGUlaZyWRjZSHEBZGnOJKSUY60l8aV5wKpCPHlZaKo9xD7rmYndwo4b7qiyiUJbGCZ1ONxrD0KyfSQE/EedDkhbLzPXfe3MaD4fFU3NaFq56ucvmym+1FNG38XqX5afIioi35NNOzFm1jdQEovQS+B/hvsLoaWzt1GLerrCOqTbsxQ86bCRC0ixNipYmsKtIGVZ4Gt2ywMwmxJlhqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=v+8BpJzw0eKICSZuO/VYrw03LPgsY0enNxrFAfUBmiY=;
 b=YC3nxMZ/E4gnXyN+1dJ/h1lyuNWZFXt8/mX+bLgfz2QjvaQCPPOnBCrEh2U42f5JVz+cZkTD1p/n7Yt6oeNfdNl4G+eTVBHKDG7uWjf05U2tLgqpdEhPiJ2ZlXhcRk+Tj45cpxGalSliyHEenIUca1BSd4z7G05GmWXzooOafVQ=
Date: Tue, 14 Dec 2021 12:41:14 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <YbiC2m4d+2OvK57J@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbdsAy0huMXBjJe/@Air-de-Roger>
 <265f07b5-03e0-a8a1-a665-1fe35436f7a1@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <265f07b5-03e0-a8a1-a665-1fe35436f7a1@suse.com>
X-ClientProxiedBy: MR2P264CA0035.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::23)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d7ae954-7493-46a8-c739-08d9bef6a578
X-MS-TrafficTypeDiagnostic: DM6PR03MB5083:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB5083BE878F6D51327A9CAC738F759@DM6PR03MB5083.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: XxeE0aWowLnoiKobffuNf/wZ5Sx0Nlxv+bcXP8pnHCLBnIi5A99XH0Ekq4Ex9guGRk/Dci+X6wGCPg2T9v+op5z8e/iE6+zEpN2vaQASxD83QESgc7pC85aounTIAzCk2LxsGhTN89tHrmSiWu83LeJtMHmb7uE2jG0QM17z/+tsGcSEQWtzn+tkrBsHCh/Hxqd9Dz0sv3GvEEsMdpeKaPApL6JGutfeWrUPbNQL6AfttnstAA717GC3y0Hg8DcB0m+QqXqnRx2F6tfppuxMCkwgCV6Z4Xw8nd2r+zxk3Y0NCcUl23XgCRRgUL9J3OaCZrNEXAOuMaIwkCu6PjcBwmumywWbf/bH1DRe67JiLeD6aGAv9l71qwQo0pcgnVLXu9E7mF1AUteOYVG02R9cQRZcR7yUmdPGYX9QlIT4gsySw7EudJWj6ST7P/r4aVQr4Fzrocx8Nhp1/83nejvZlHgmgaFM23eQ0ZqyXLV9v2L7QrTqU3D9dFYmYyV4PvNohTZ0r75Ki8kGWzyfDnVJHN4gHKE0OEfC5AJ59NJylr7k49Hv6rZ/ZQY87vmJ8BCf9md5eqM9V66WMerhcNHL0WBniLhYTlvJFLvrCahQmk3frxOVfM1wzk47pf5ETvTO2I3o+m9dSbZLUwTXrH7W34ySiaB4YvoqhtYNIYjD3GsM19FlEogN/hALwlvE9qD3+VXDDUwrzB7vnEdM1rju4w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66476007)(53546011)(6506007)(6512007)(8676002)(86362001)(6916009)(82960400001)(9686003)(85182001)(54906003)(66556008)(6486002)(316002)(33716001)(26005)(83380400001)(508600001)(2906002)(66946007)(186003)(6666004)(4326008)(5660300002)(8936002)(38100700002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXhqTkNYWSt6UG5SejRaUDVNeWR4a04rZW5ZWHU4MFY0aVJXMWNqU2poajRs?=
 =?utf-8?B?enRCT1B6SHdBM3VaQ054bkZMRTcvNGlsWldOczFRQVVtQ2ErcGQyRU1UTGFQ?=
 =?utf-8?B?c0JOR0trUjNRV2JPSUVoUEVTazNrYkNsdVpMV0hNc0oxTzJ0cjJ5MERqUUlY?=
 =?utf-8?B?ekMzMk53aStIS1NibHdTRHRPSUN6cGJyWWkycytqVFR1UzNZSHJVdmpISlBo?=
 =?utf-8?B?REZ0M05pdTNFR25XMU5wRExFOEgvUGZyTFlmam1XRENlOVE4L1NuNUVrdzlo?=
 =?utf-8?B?RHNLaTBPUVVCUGV6SkM1WmY2YktHYzhJRTR6Mm1vQndOT3IrV0FGZGxtYy9G?=
 =?utf-8?B?UFozMlY4bUZyWDlzMUJKSGpYVUNQRjlQeFlzeW5qSXhaOVdHWVd5RTBVYk42?=
 =?utf-8?B?RFUwQ0NEclB4TU55enExWDN0Vjk0MTd6T0FTUkxwNjdqSGc2SmpBQVovdkpw?=
 =?utf-8?B?RjlYWGdCMVczYUN2R0hyM3VhcHVoWk5pZGpQa2Q5MU1heHRDdHdEN2xQZi95?=
 =?utf-8?B?U0daK0VQVVNXMHExRHJUVXUwbHEvQTBIYU9MaUhuN3lqZmZ2cityd2FkVXBM?=
 =?utf-8?B?eDVwbHhqSDFjTC9jaFVULzUxalg0NXhLUXZPS1VpT2sxTEZLU3R2RHhSRjdk?=
 =?utf-8?B?RzI3dWhnOUJnQWcvbFl4dVpjRjBGVUp0MUwreFNZM1JPTitVbk9pSlNQbmY4?=
 =?utf-8?B?eTUveHoxc0pwd0JQaVRVeksyeDZDUVpQU1NTYUNXUTJ4YU9LQ3l0Mk1IVFFX?=
 =?utf-8?B?VFVOTFlTemVKc0MyNDVTeTRENjYzRk1TUEpaNlVrWW1nWFpKNkxqUGVwZXpi?=
 =?utf-8?B?ZDQySlptcE82T2hoSmEzNjlVN1Y0TXdFcTZkL3RRZFhTSHpaRXFuRm1nZWs0?=
 =?utf-8?B?Y2s1V0FDZEpkbkNmRDFucWRwUnhZRG9GcVVvazZBTkNNNS96QWxEckllZ3Ri?=
 =?utf-8?B?eUtUUlBmUndhbkZ5YkhvSXFNYk1NcEtUQzFoczFzUU9kcTMvZnFTbTBYVXY0?=
 =?utf-8?B?NU1Da0N6RnduaElxbVIyU1ppamFmdHB4dS81M0pPUEdOODk4Y3FveHFzdXMx?=
 =?utf-8?B?TU9qVjBUc09FamxqK3pyRmYrN25WUnl0Sk1GNktBTDBFQUFWcWlOVUpUTDJT?=
 =?utf-8?B?bXpRMk83QWltTGlKZGpMN2pvNVoxWHJJUXRZQzhUblVSdWFCUFBsWm9ib3lE?=
 =?utf-8?B?YzYxWVpZN1lqTlhPNXZybzVLVkh0MzM4S1NBeDJxU0FSRkpzUXFmcHFON0Zv?=
 =?utf-8?B?dEpET3Jrdk5pWnBMcnJhYldKNTIyakNCdHNPOGxURnZ6N092bktEc2h2TzZN?=
 =?utf-8?B?MTdjTnJESU1XUkhlWXloS1JLWjl6U3Rpc1RqVkVGM1lBdEVJdDNmTHNqdldx?=
 =?utf-8?B?MitIMHNhRkl6VW4zWDRGRlFJMnh0SlEvQ3ZudWVVQnZjOVVndEpqOVNSM0dF?=
 =?utf-8?B?aWdvREtZRmdQQzJzWlpmRzUzQ3dYOFgxcjd1VzZFM3RxeWpBWHJHK2lMb3c0?=
 =?utf-8?B?VDVwdW1nTUpLWHJQS0dCS0VtYVNGWjljS29KMDdlekw1K2Y2RW02Zk5qZ0pn?=
 =?utf-8?B?TnR5NTZiSm4xZXZFUG02N1F0OFBGdEtINzFHLzAyZUFoeWp3c0RjVnlkaTFN?=
 =?utf-8?B?STBJbkNUbE5ETFZvc0FncGI5NGk5enJBNGFwOXJYSEh6WGsvK040NVoyV0pv?=
 =?utf-8?B?cTljLy9JY01PT3JXRUN2c2paMGlPdStRdG9OaWxJeFFJT0RLV3Y3ZU0vTkdu?=
 =?utf-8?B?MldkT0RhdXhoQzlkQms0clluSTMvRDR2WkRUbmd4MkhYU3l4QTlWVWJndExU?=
 =?utf-8?B?V25mODdib0NmZ3pNeXBOV2JOZzJhMDhrSzc5QzlyemoycEZoV21WTCtVUEdZ?=
 =?utf-8?B?dWNSdFBiL3R0dUVLOVVkRTM1NEw5cE5MdjhCZGIxeHRoMmNmSHlSTDlRSFl4?=
 =?utf-8?B?cWZFWndTVmN1MGNkK0c1K3JYVWtHb3AxKzZmOVorUWNsb0VuSk0ycGFhc2dk?=
 =?utf-8?B?UzZHSThWRkFYQWJ2T3N3Rm9JV1JkelVwVU8vVUFJbC9lUC9vNms4TkJNNEs0?=
 =?utf-8?B?c3dBbUk5OTJ2cEJ4ZzEycEt5VTUrdm5rc1MyeFZNZ2trc25oZUxJVnIweDF6?=
 =?utf-8?B?UFBPMTZiVkpKK3ZhK2hYOG1hZm9jMUxTcnhodDdhcmNQYkhlRXMvcjM3WUF4?=
 =?utf-8?Q?hg7TiU+/vjCXPiMfTaSbV7k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d7ae954-7493-46a8-c739-08d9bef6a578
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 11:41:19.9274
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: foxtRQdvv4cDmkI+zPXP2SZt04MeMYPmPpqP/6YUAIwMCmkaZHRgARf2X7i85HBYZEWlJQAgDEgp/DYy8F7qiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5083
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 10:15:37AM +0100, Jan Beulich wrote:
> On 13.12.2021 16:51, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> >> Page table are used for two purposes after allocation: They either start
> >> out all empty, or they get filled to replace a superpage. Subsequently,
> >> to replace all empty or fully contiguous page tables, contiguous sub-
> >> regions will be recorded within individual page tables. Install the
> >> initial set of markers immediately after allocation. Make sure to retain
> >> these markers when further populating a page table in preparation for it
> >> to replace a superpage.
> >>
> >> The markers are simply 4-bit fields holding the order value of
> >> contiguous entries. To demonstrate this, if a page table had just 16
> >> entries, this would be the initial (fully contiguous) set of markers:
> >>
> >> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
> >> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0

Could you expand bit more on this explanation?

I don't get how such markers are used, or how they relate to the page
table entries. I guess the point is to note whether entries are
populated, and whether such populated entries are contiguous?

Could you provide a more visual example maybe, about what would go
into each relevant page table entry, including the marker
information?

I would like to understand this instead of trying to figure out from
the code (as then I could be making wrong assumptions).

> >>
> >> "Contiguous" here means not only present entries with successively
> >> increasing MFNs, each one suitably aligned for its slot, but also a
> >> respective number of all non-present entries.
> > 
> > I'm afraid I'm slightly lost with all this, please bear with me. Is
> > this just a performance improvement when doing super-page
> > replacements, or there's more to it?
> 
> What I wanted to strictly avoid is to have to scan entire pages for
> contiguity (i.e. on average touching half a page), like e.g.
> map_pages_to_xen() and modify_xen_mappings() do. Hence I tried to
> find a scheme where for any individual update only a predictably
> very limited number of entries need inspecting (some of these then
> of course also need updating).

Thanks. So there's some extra cost here of having to update those
markers when a page table entry is modified.

Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 11:48:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 11:48:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246629.425328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6I9-0000TM-Db; Tue, 14 Dec 2021 11:48:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246629.425328; Tue, 14 Dec 2021 11:48:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6I9-0000TB-AY; Tue, 14 Dec 2021 11:48:21 +0000
Received: by outflank-mailman (input) for mailman id 246629;
 Tue, 14 Dec 2021 11:48:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx6I7-0000T3-Ml
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 11:48:19 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id babf688f-5cd3-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 12:48:18 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-HzB61-XBM0W81qC_G7eLdA-1; Tue, 14 Dec 2021 12:48:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 11:48:15 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 11:48:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: babf688f-5cd3-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639482498;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BugTkLTEJlKSxiIgc+A8/d8cFrXcOUFQgSoTo2Y8818=;
	b=Lhatn6esLwJSFd4HYgMlYPEMstxbO3i80KwsucWgGLZBNJIGDkmMWQTfJAvtJzzSg4D6gQ
	QFr35vtcMN63Uy5et5C+7jiHA77OObGy4TfZMlZJOPdHaAnrDQMgq0GUGYX6oEv/zlFXFK
	x9RFATepK/l6YbdZLhEg3vzu/dJ7aa0=
X-MC-Unique: HzB61-XBM0W81qC_G7eLdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=frW9FvbfUyxc5QuRRwMwPjpsQmRxeN0doA3VrkWeuNa/APIspT6dQLeJLhc+bPlK9AMA4IOWZG7NwkuoCsa4AyzanvJ5NljIEFINwLzsuPrBZ9QzAXZVPhk0uTFtc8NIXyvvUE5dhN+w0DJS4GbWJI7EqdtZ3XappazlBrKCzWExaRPXuKDMDqmUuVZNU/66TO3Cd6YxHAYGyepGQxG9BIQlRlcZkwSe/xy6wg9qtvCQqDXktOshm3Xn/+TVIrhqRZeq8KmPkNdWFPuKoy2qdh+1BaxeH8waq+ERfXQPkogOr3zSgYNTTkQE3JnLY6RhjfBV1E57Ftys0qbwJ/JZGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8tD7mjhLgKjpYmDK84hJGLgP69zuLm9AE3WnkKlb3PA=;
 b=H5X056fsDlNYU2vmR2oc32OIptpT+s4CEmAxYiYLYjtKwZ46CpNONZ4107uuFmZkejIvT2ygPXtbAEcHC7sHyjegmNO76pkrBc/HT2v2YlXgrgYCeN04tMBMJvvoWqRyKGgueHrByi93gI26/mKd+XTC+FwVQIJtB/yPhxD0T7rvo3Hh4qQbg3umKuzY8eNXcdSKhMl6MnACXPjcsLVCCwKd9w+jjmzzBNig2zkc2Kt01+9hV60VdTHefTOyTzj2elHXN46l3iaIrg+ZnI0bVAWziYgJujuwkEuSRGv0FBhjHu/CPuFVvj40tZ/S5hykNAYI5uc7CceukitDtIe3yw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ebd3797c-fe3b-abcc-bad7-7abd5fd5fd2f@suse.com>
Date: Tue, 14 Dec 2021 12:48:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbdsAy0huMXBjJe/@Air-de-Roger>
 <265f07b5-03e0-a8a1-a665-1fe35436f7a1@suse.com>
 <YbiC2m4d+2OvK57J@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbiC2m4d+2OvK57J@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0051.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3a58d64-78a5-42bc-fc29-08d9bef79d1a
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB26059FA2F40C086B1FE1DECDB3759@VI1PR0401MB2605.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0lGjKfHPP6Ate4Whv879A4w/UbzbIh6T2NX4NAEGnY0otC74jogOEGV+r8MzWMsU2Ww2qPpVBYnOWp7DcitWU2sED1YN8Uh+PHtIrpVdSbfNTYTKq41j3AlYgx/Q6Qb0bq3hacPfHOUahrtD19+20Ug4rKlujn+wm8HPgjYrRdQZ3J5C+E1nNQJfxkcApIhGxHZjZj9bGw0OLIUaYYfgJEMScUSoJx80zKqx0nGmgQWJTRqtXcTCqc4kA1btuI+F5Nlzce7YdG7NhNxnzJnlWjfcs84168UnjFYiFOBwiVDqQOrJnYA6JxPYbegYTmH1pUGmzBMY/HKOgewkkVhh9TF6GdaTMYfD6DfkmpxPh4ecYqvpGV5oYwweuNaY4klIiZJvMOZMCiBKx7pcYdExm6Pi5uG6igaFC2/HgmQ4xI09TjAYeCAXoA8PUB5JFSlGU/db1A3CANTPUEJu+z7qJxMuZNWWU5Wm6Q/tOOyMjvetC9yUR+HFUYeTOtvYDHeHEWh7cexYxux/EPhiQm7uEG/cJ6XQbwbJxY1m/a2DVRSRe8Y2O2NGalUUz03fxX7gNZxKiwFoJ1E0ib5UDKaboBStcXHKOCeGGumP6EdMIcDM1w6o2/MDzbn1iHlbiS5RO46MGC6oqLBWH5vS6X1VZ2BnvEDi1do9cB94OOpkGkAS+zyySRBSU5GatsQQ3qauoXsRKhoEI4E6j+MmIsClsEh+HP04LlJFdDTgJZjcHtI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(53546011)(36756003)(2906002)(38100700002)(8676002)(83380400001)(316002)(6512007)(31696002)(508600001)(2616005)(31686004)(54906003)(6486002)(4326008)(66476007)(6916009)(86362001)(66946007)(5660300002)(66556008)(186003)(26005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?APErmRyeBvRZUENliOdSJnzQHcikHkJOexIGeSbfuNFb3CrwUaGiHGNfbiR5?=
 =?us-ascii?Q?PyJreLtAqf6HYubGc0Ttav3v4z1cWa0BPc75QzyBS5iOgSbAlOmrECSta3Dl?=
 =?us-ascii?Q?N0FWpNgrrSYooLo4YFLSM57s8nqvhhbFmkqDOlh8xQJ3NFEiawp908FTZrII?=
 =?us-ascii?Q?2K+SpD7UMiWMBE36FURsR/VzCXFInYdAUDdekx3iB+p+GcmP99oveTVVrW/R?=
 =?us-ascii?Q?Tl/ZgI1alXyejQyvtS6plLrZlV3XOWCXdpFdgV7xdVovDqwdVOT1zFkM6+Dq?=
 =?us-ascii?Q?9lVfn+UKRZn2VfEMVUjaA3SLAzC6gnl7HdNRfURTaoGDCSCgkgw8/Ps9PVfJ?=
 =?us-ascii?Q?PCbYzS5RURSynS0J6DodnAnhQm8XlP8ZNkFKIrcODaXErgOcd8757ot2yfYY?=
 =?us-ascii?Q?rC2DUlW6wVT+Re7QV6FzyWs2OTMcJlOLeZc2O21q0tY5aPdqK93rDwvG5Own?=
 =?us-ascii?Q?Nhch5F4DY5k2arMnJ/XIvP612OeHj4tsanGYdTmJis75d91IRdiTjHzA9IqC?=
 =?us-ascii?Q?pA7Yeo1v89Jx/huGZNbkBKr0rs4nSkGp9XT7/gImcJyGZMTosj4abcl8cjR9?=
 =?us-ascii?Q?5k7z6o5nmVQP7YInoJ/LbmATsyk4YnJyUvF8Hl63wJIAU3uoSJjHzb1hWqpF?=
 =?us-ascii?Q?LXKuwluKEs/9MuJlyHv5RZHqd0uopop4hKYHEG16jerRv6nlt8duIYDYXexl?=
 =?us-ascii?Q?5Xai8MhsPe69fGDeW6ho+02ljrQwlLZJouKm6W5RrCNKadhzusYT61mUIQvR?=
 =?us-ascii?Q?JU9CX4VyJilDdl/xZbcbr37q6f94lNTY9XILnA9SrHG7UGCtkFixpsa8Iafn?=
 =?us-ascii?Q?4f2IYKOPH0kbXX81poMh/8dJg+j3sWyi5gX2zq72FNoqHOG775LPI7/f3beo?=
 =?us-ascii?Q?TqxzYvSbevKIcf+reDY5NO2kX5jo23KfUOSpbyDP661Wk1qxanrKqU+i/a6A?=
 =?us-ascii?Q?E+pISH+TWoHNbOg8Aot5WzzzZ9kLqeTaJE71Oae6XsNOvnGbdRmA2Zn7BpRw?=
 =?us-ascii?Q?VjL4ae+eRGS0D/gUs4j+1p/7aLCcJf/CxQXCM2OeQEI4AC9CQjoKSkvvIdDB?=
 =?us-ascii?Q?0t7oO5MZ3ODGD+Sr58RmvJ8S9NGlthX3yjQvi75If6qIQFAWbB1Z6YKOGGxk?=
 =?us-ascii?Q?1klzo3m1/3w6EUXHyUGEiYDlwE+n2Zs/vt0V2ZMvH9YS3JX7LDnI9mAyCrKk?=
 =?us-ascii?Q?3Vt0Rvwkw2FT4eV30GF5KI56f1aICKwr0eU6ee58f8RJm15qM+KE03GT/noK?=
 =?us-ascii?Q?FdNaKRYugz5or0GBBWpQsi3Nkrg5R9f/Dmuw4ai6BS4XT6GwDHqQXllyIQNK?=
 =?us-ascii?Q?vQ7zJXbYR7AlqKjGGjgYWCF1Eto1A8dL4ay2avYi9ug8jtsWH8M1bMr6gzZx?=
 =?us-ascii?Q?NCKkB+wy5XEN3oeIWXm84b+WfI+KZVAHlyBshX3PYTnOihO/bJQxn8WBdbtB?=
 =?us-ascii?Q?neXQaHat9ip/cjND9EAZCm6ZJ0W+tA/kJiSG0DGNWTz9oj1lHLsjBoYk7KXA?=
 =?us-ascii?Q?yMKQYM7kc0b60JIsb/nL7ujCHOh6MInFjIvFpxyjV73tcA931/wi54/VjTGj?=
 =?us-ascii?Q?UyIClRSGry9bY9KfQ0W/mWj4QKdH+gmb8e+bfT/y3KJ1u8NJpJQaiRsqnPC8?=
 =?us-ascii?Q?AJmei4cKoIrbeYLld2dlVjI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3a58d64-78a5-42bc-fc29-08d9bef79d1a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 11:48:15.3355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y1VTIq5Tu1+hjZ0i3RrjruU7OLfZZgF39kQiBDQMZJGNe5oZcCFBLoiKHVpBWyWUNmEorn2gxQ/hQVZERknBJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605

On 14.12.2021 12:41, Roger Pau Monn=C3=A9 wrote:
> On Tue, Dec 14, 2021 at 10:15:37AM +0100, Jan Beulich wrote:
>> On 13.12.2021 16:51, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>>>> Page table are used for two purposes after allocation: They either sta=
rt
>>>> out all empty, or they get filled to replace a superpage. Subsequently=
,
>>>> to replace all empty or fully contiguous page tables, contiguous sub-
>>>> regions will be recorded within individual page tables. Install the
>>>> initial set of markers immediately after allocation. Make sure to reta=
in
>>>> these markers when further populating a page table in preparation for =
it
>>>> to replace a superpage.
>>>>
>>>> The markers are simply 4-bit fields holding the order value of
>>>> contiguous entries. To demonstrate this, if a page table had just 16
>>>> entries, this would be the initial (fully contiguous) set of markers:
>>>>
>>>> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
>>>> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
>=20
> Could you expand bit more on this explanation?
>=20
> I don't get how such markers are used, or how they relate to the page
> table entries. I guess the point is to note whether entries are
> populated, and whether such populated entries are contiguous?
>=20
> Could you provide a more visual example maybe, about what would go
> into each relevant page table entry, including the marker
> information?

I'm not sure I understand what you're after. The markers say "This
2^^marker aligned range is contiguous" (including the case of
contiguously clear). And they go into a vendor dependent ignored
4-bit field in each PTE. (Obviously odd numbered PTEs won't ever
be updated from holding a zero marker.)

An intermediate page table is eligible for replacement when the
marker of entry 0 is 9.

>>>> "Contiguous" here means not only present entries with successively
>>>> increasing MFNs, each one suitably aligned for its slot, but also a
>>>> respective number of all non-present entries.
>>>
>>> I'm afraid I'm slightly lost with all this, please bear with me. Is
>>> this just a performance improvement when doing super-page
>>> replacements, or there's more to it?
>>
>> What I wanted to strictly avoid is to have to scan entire pages for
>> contiguity (i.e. on average touching half a page), like e.g.
>> map_pages_to_xen() and modify_xen_mappings() do. Hence I tried to
>> find a scheme where for any individual update only a predictably
>> very limited number of entries need inspecting (some of these then
>> of course also need updating).
>=20
> Thanks. So there's some extra cost here of having to update those
> markers when a page table entry is modified.

Well, yes, in order to re-coalesce _some_ extra cost is to be paid in
any event.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:05:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246645.425339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Yq-0003JC-7n; Tue, 14 Dec 2021 12:05:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246645.425339; Tue, 14 Dec 2021 12:05:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Yq-0003J5-4f; Tue, 14 Dec 2021 12:05:36 +0000
Received: by outflank-mailman (input) for mailman id 246645;
 Tue, 14 Dec 2021 12:05:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6Yo-0003Iz-6Q
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:05:34 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20718.outbound.protection.outlook.com
 [2a01:111:f403:700c::718])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 20bb89ce-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:05:30 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:05:26 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:05:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 20bb89ce-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kyPZbfV7ncv8hnGVRalV8rkM7MwNfWIlmTfbTqGpd1jnwmz6cq7UYrwBGjL4P00pS17J599+nm/55s/uFwFbLZugMc+Qx6EDNues1fiwhJBzULVJ0Dzsw6kcJMvZmemACob+9lKeGL+oWTXyUSkVlr3ztMv3cWPpI8W+EDFPP06JWKeGA3czwuofMzDEPS4IoSIIeax/xuHSW1xuuCaG8yfrDg0AqkP4mG/MExJeYyPdQtL/a5abP6xHlxB7uc/mKwcr5m5oH914iUjvYhv6uM1SxoKwYZQVLJP5uE47ZPUHRX/2j4CoTUfjY8IrYR088nQ67XcZtc/snEHFdLfcnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=y+mW5dyfZU3halDXOhUj99ynn3ihdoCfaglw81cFr3U=;
 b=DEHFA9S8QLo4nck16KOvt+GHyO0XfOYJYk38MO4K1E9asygI1QkyRrUBSCQa6KU5nEKtv1pjQLaPAV6Mbyz5Y1NAl9IC3/tTtE0fOMPIFuC6EbA4BryX9vsU+LwFxQ6ysXKpYyP7WlWsspnSgg16Z779IhsL2b9sv2TeAvy2MtxZuXU6AgHWPn9tnR7gs6zEJ4fdedCE5sJUnQj75wUiAwmRcg5npswvNPldKQUonij0+zx5G16uxYN682vmm1oKE41/468pN2sUirY7MzUBC/Jbxx6V9BBJOysJ342elysDVZ4JgeyXEjt+KlTn96ud5zT5QOntxGxUm6NGDB/v3w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=y+mW5dyfZU3halDXOhUj99ynn3ihdoCfaglw81cFr3U=;
 b=jFxv+fb66AdcoImSj8Owj+rhXk4IHqF43CBr7Evl+YwHv0sW+jMvW6NHyedFtx94jZwfHe7DTDvThbSk/vsuIyyAXaSjo7/P7CAFjiiSL2qOH0svE+MuZMRPL0LZ/W34PBGY9R6R8YrAwYklhP99VxRl1G4wXG4xyQXc4JHADBg=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 01/10] iommu/ipmmu-vmsa: Remove all unused register
 definitions
Thread-Topic: [PATCH 01/10] iommu/ipmmu-vmsa: Remove all unused register
 definitions
Thread-Index: AQHX47d4hOj8rE1gDUuIyaw11OIatqwx9SzA
Date: Tue, 14 Dec 2021 12:05:26 +0000
Message-ID:
 <TY2PR01MB369283FAA9B13D17DD708603D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-2-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-2-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 85e10458-d55b-48b6-2e9a-08d9befa03a2
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB3436E032C5AA21876ED8DD15D8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:400;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 lY9+8HEHEi/Y7/j/sx9UyIlwgie4Za57TzhgbZQkcqOfwxhE69XQDMPziG0GfhGYJOBTk5lRXsIhZz5bTdA5WPITpULzlTtrJTUftLHumU71LEq3e+fnpwmTTjcp2heDiqOlELI+7tqqQBxxmPI5XmPDwpbhrHOJaYn+mTOoRayhr7wyeZ1AqWZ5h2RBXr6tCzTnMajGO+oFJLNL4UlHuPtVT28/qVfDv7MwR1usN5dNY4a/JUjqnyycwFPAB/3ILX4AD5GK98/KTNQtXEaxg/YDmC1FFIwgGVNdfSSBgumpUWBKEjspVXjioXkVRUWXGTY7nu2y/5g/dhHZqNgITWmp1ocC42XusNCM32yuZJt+ebZkl9vGmH1yvK1zi2H7Rr/DYeSkjC0BPb/QeRi/YnwGzMmNxRR/EsH3/P60vUWdTBfG1iRHa6nTrTOmJYk5YKuhEhinI0bQXvwlGr5PUyr0q3YGk7AmUw38lIyVDHxOUQQHrBfHInyXbkc3uOAenUac5hkrC7+XSXwDl5JfyEgJzWq0SqpImdNpGS9LyVmUBPaUnnfhT1hYRsV7GN2KCx8n9nnH4HI5xgzMVQnW7XuSiQeGoBPjqRiO2eyf1DDJYNVjkY/wrRq6eYzaxxP/wtQkRdzHiQqT7c7Ej9eiCywymlBfdmVqIAGbACBgUjpvEFVPggA+i5875CbTq03yU8wQYw+WsQBg+4zZ4saH9g==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(52536014)(86362001)(4326008)(9686003)(33656002)(26005)(2906002)(7696005)(8936002)(38100700002)(508600001)(6506007)(5660300002)(186003)(8676002)(54906003)(66574015)(316002)(83380400001)(110136005)(38070700005)(76116006)(66446008)(66476007)(71200400001)(55016003)(64756008)(66946007)(66556008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?K1B2U0R6Wm9YekhwajRtc1JnOThSZ2VMZ3pIeGF3eTVUd1E3OXNLVEdlTXho?=
 =?utf-8?B?cURVNXM2NXZBWFdqcjVUUllVS0FPRUFWK1A0MWZ0NzZubWJpU0FjeldxVnpY?=
 =?utf-8?B?eU5Bb29LT2ZLVnpIY21xT1owSjJJdDRsU0hTT3BIUkZGWS9YcDQvd0YyTXZU?=
 =?utf-8?B?dTBHZFM3S29YQlBHMHhWMnl3LzY2d2xLeHJwY1Q0ZFZ1MDN2NExheTJVdnRJ?=
 =?utf-8?B?VmxaK2d3V3VSNmhzTE5QVmEyWE5zQytvZzB6NUFWaXRlT0lvK1N3M3N0cUYw?=
 =?utf-8?B?eWF6QThJL1lEMnIvSFlsY2d1RWZVYVB6VDJGT21oK2dQQk5SRkNucU1UbUl4?=
 =?utf-8?B?T2hLc05rVUtLbHdxMzdraS9hUWhPa0JCTU9OZS9SYWN5c0hoYmRtY0NJYUdH?=
 =?utf-8?B?RUxwWEk2dFN5ZzVqYjU5b2NPYkJNYkRHeXEvMjNFTkdpczlCd0ZUenhqb0Fi?=
 =?utf-8?B?blNxYzViR0tFYWNQUHBpaFlvZk5Ea3FuZVFRemxDTklMLzZxS3pFYVplcm5w?=
 =?utf-8?B?VEpqeDU4TnV6eCtRSFhMZGErbUVGV1lvVFZBaS9KRDNQanZCclJYeFhHUkdE?=
 =?utf-8?B?UHhzMVQvTXc1UEE1WXZTSjJuZ2VvblVjYjlaZldycUViMDFWc0ZHOVFTbFY2?=
 =?utf-8?B?TVExY3I4eU1SZ2VQNzUyZW5aT25ReWhUeTNuUUEvNWxia0lzN2xlRHFkdExG?=
 =?utf-8?B?ZDM4a3RGeStoWlpMdkZHTnpTQVY5OE9tS0dmU2p0V1ZScHgyOXdyUVBObS90?=
 =?utf-8?B?eFhoSlBkOTJES2E2YnRGVmpBTVRwSzZxUXEwVFlBR1p5VW1EYUdQcTBjVGI1?=
 =?utf-8?B?TXRRZEtUL25OeHIzRU4weHFuaUc4SFZkbHBpMGI0NnFPUElNOFVhZVJmSGJl?=
 =?utf-8?B?M25oQjlOY3lNUzJSMFQ1L2EvMmdXV0JBa1lsOGtyeEp3STg5ZzRuMlhLOWwz?=
 =?utf-8?B?U2o0alJXVkUvTHlQOEprVjA5UmlDWEZBYjA1cnVjOGYzTkpuMXpNZE4zWG9W?=
 =?utf-8?B?Snd1ZjRacWJ4TmhSNVlYendiZkNoNmFyQUdQMXRXbytoQUpHdEg1KzYwRlJR?=
 =?utf-8?B?WWV3MFN2c0ZJTnhkK0lBck9lMDVPOGN5a2lVbTlUM2JJQVJ3VkExWlYwSm42?=
 =?utf-8?B?L3lGMmQ4TzJySmxLTWJlVHJzdWtrLzZxNXp6ZlFSQlkzcUFCd3VwSTFqUmZU?=
 =?utf-8?B?UnNodEFrL1dHdmxEcUJPaWx5bjJ3SGxkK2NYRHFPQWtRRjFUVEg3N2tHMUJL?=
 =?utf-8?B?NG9JZ2hVWjYzK1Rpbk91OHZabHhtbHlIQXN4RWRFcjJyVGptaTlnVGYzN1Fy?=
 =?utf-8?B?UW44Y25GV1NKTU5jVXk5b0t3TVFlS3dOTUlLSElNT2xBL1p5ZHVvUno5QldN?=
 =?utf-8?B?WHFyN3h4bEtSQWpnVWF5TUN1bEo0bldLT3Y0dmlFWW1UNHM4clZpZHZLNm9n?=
 =?utf-8?B?UWNKT1dhc04vdXE5eCtnRnptMmFSRjdOeGI3ZGJVV2tkczAzVWJmTkUyMkpm?=
 =?utf-8?B?czlHZ2dPbW44TXFtZjlkdzVzalNJdUVMbExpSzlDSzlCUm0zV2JMTmFhUGxo?=
 =?utf-8?B?Y1RhYnJtNEhjMWZJZGZheTFZZWxYcjNlSThGVkUzRFVFTG9ER29mMHVNc2xo?=
 =?utf-8?B?TDVhYnVhVHJaMkU3ZlVVMXBJSzI5dWo2a0ZRbWI3akFZUVAxRkpVQ1BCSjBI?=
 =?utf-8?B?YnZBakVyVGNYeTNpemlDOFcxSlhrZ1BJQlRra2Jpb3ExN2h3WHBxSkJUWW9n?=
 =?utf-8?B?QVNqa24wSVpsd2NabTZLUG5yNUUyWGovMGtqVml3ejY5bmtaSGk4N1NnMHNW?=
 =?utf-8?B?WHpLVkIzRGNQRWlsRThQd0IrREhKUlQwRnplWkU2TzZoNEdtbkhCRUtBSXVQ?=
 =?utf-8?B?YmtTK1JvaTlaQnJMWlpabVFWVVFUK3ZKZlRtc004aWthem8xRlE2ZGI2VW9O?=
 =?utf-8?B?dmtSVWZMM1lramZEMi9Gb3VMc2kyaWdDOTRiUWxtYWx6QUxBNGVqVWQ5QXZG?=
 =?utf-8?B?bU1NWkNnWmhjRThLY1lJS2tGNnpDZExQSEVFU3lGZ3k3S0hpQjlQZjhTWXQr?=
 =?utf-8?B?dFhCUlhJUHJwRlZVTmFsYjdKN1RhbE9YdW4rUGFkMElkZU1JZkkrTGJxUkE4?=
 =?utf-8?B?Z09KZHg1d3FhQS9yUXR1RzZNOTJYK3lQVDQwU0NLaUg5aGlhMDRHWDNFSW1E?=
 =?utf-8?B?SXlia0JUcUoxKzJlbksxUWY2N1pDRGplZlhtTzdvbTYvNW9wenVkMS91UTl1?=
 =?utf-8?B?cW5YQnc4RXNGZ05jVTRTWHVEVHpaR0phTFpZQXdnMFVMQzFBdUJqSXF3ZzVG?=
 =?utf-8?B?N3JvTDlQOWpaOE1vR0dZbWFQK0sybzVSRDJUTlZlc1A1bVcvVFVIdz09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85e10458-d55b-48b6-2e9a-08d9befa03a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:05:26.1287
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DYqvKyVAEXtq2BSZf7FalmO23HtAdq3mFeGgZl/b7A/kheWDTUY9l0hpI2+vSrPm3xgS7BLRuZeMoQoaPfpdLovgru0+1E0DAxfucIfZ0rd3JpEjiyHpHd7BgBZm1ASN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

SGVsbG8gT2xla3NhbmRyLXNhbiwNCg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbywgU2Vu
dDogU3VuZGF5LCBOb3ZlbWJlciAyOCwgMjAyMSAyOjUyIEFNDQo+IA0KPiBGcm9tOiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IA0KPiBUaGlz
IGlzIGEgbm9uLXZlcmJhdGltIHBvcnQgb2YgY29ycmVzcG9uZGluZyBMaW51eCB1cHN0ZWFtIGNv
bW1pdDoNCj4gNzdjZjk4Mzg5MmIyZTBkNDBkYzI1NmI3ODQ5MzBhOWZmYWFkNGZjOA0KPiANCj4g
T3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6DQo+ICBjb21taXQgNzdjZjk4Mzg5MmIyZTBkNDBkYzI1
NmI3ODQ5MzBhOWZmYWFkNGZjOA0KPiAgQXV0aG9yOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGlo
aXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ICBEYXRlOiAgIFdlZCBOb3YgNiAxMTozNTo0
NSAyMDE5ICswOTAwDQo+IA0KPiAgIGlvbW11L2lwbW11LXZtc2E6IFJlbW92ZSBhbGwgdW51c2Vk
IHJlZ2lzdGVyIGRlZmluaXRpb25zDQo+IA0KPiAgIFRvIHN1cHBvcnQgZGlmZmVyZW50IHJlZ2lz
dGVycyBtZW1vcnkgbWFwcGluZyBoYXJkd2FyZSBlYXNpbHkNCj4gICBpbiB0aGUgZnV0dXJlLCB0
aGlzIHBhdGNoIHJlbW92ZXMgYWxsIHVudXNlZCByZWdpc3Rlcg0KPiAgIGRlZmluaXRpb25zLg0K
PiANCj4gICBTaWduZWQtb2ZmLWJ5OiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1v
ZGEudWhAcmVuZXNhcy5jb20+DQo+ICAgUmV2aWV3ZWQtYnk6IE5pa2xhcyBTw7ZkZXJsdW5kIDxu
aWtsYXMuc29kZXJsdW5kK3JlbmVzYXNAcmFnbmF0ZWNoLnNlPg0KPiAgIFNpZ25lZC1vZmYtYnk6
IEpvZXJnIFJvZWRlbCA8anJvZWRlbEBzdXNlLmRlPg0KPiANCj4gKioqKioqKioqKg0KPiANCj4g
VGhpcyBpcyBhIHByZXJlcSB3b3JrIG5lZWRlZCB0byBhZGQgc3VwcG9ydCBmb3IgUzQgc2VyaWVz
IGVhc2lseQ0KPiBpbiB0aGUgZnV0dXJlLg0KPiANCj4gQWx0aG91Z2ggTGludXggYW5kIFhlbiBk
cml2ZXJzIGhhdmUgYSBsb3QgaW4gY29tbW9uLCB0aGUgbWFpbg0KPiBkaWZmZXJlbmNlcyBhcmUg
aW4gdHJhbnNsYXRpb24gc3RhZ2VzICh0YWJsZSBmb3JtYXRzKSwgVk1TQXY4IG1vZGVzLA0KPiBz
dXBwb3J0ZWQgU29DIGdlbmVyYXRpb25zLCBldGMsIHRoZXJlZm9yZSB0aGF0J3Mgd2h5IHRoZXJl
IGlzDQo+IGEgc2xpZ2h0IGRpZmZlcmVuY2UgaW4gcmVnaXN0ZXJzL2JpdHMgZWFjaCBkcml2ZXIg
Y29uc2lkZXJzIHVudXNlZC4NCj4gDQo+IE5vIGNoYW5nZSBpbiBiZWhhdmlvci4NCj4gDQo+IFNp
Z25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl
cGFtLmNvbT4NCg0KVGhhbmsgeW91IGZvciB5b3VyIHBhdGNoIQ0KDQpSZXZpZXdlZC1ieTogWW9z
aGloaXJvIFNoaW1vZGEgPHlvc2hpaGlyby5zaGltb2RhLnVoQHJlbmVzYXMuY29tPg0KDQpCZXN0
IHJlZ2FyZHMsDQpZb3NoaWhpcm8gU2hpbW9kYQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:05:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:05:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246646.425349 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Yw-0003a0-FK; Tue, 14 Dec 2021 12:05:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246646.425349; Tue, 14 Dec 2021 12:05:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Yw-0003Zt-CK; Tue, 14 Dec 2021 12:05:42 +0000
Received: by outflank-mailman (input) for mailman id 246646;
 Tue, 14 Dec 2021 12:05:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6Yu-0003Iz-Mr
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:05:40 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on2070d.outbound.protection.outlook.com
 [2a01:111:f403:700c::70d])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 264f7b4c-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:05:39 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:05:35 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:05:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 264f7b4c-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IjDdXU8kMTdsrYUZ6o8iDgTHchv2u2P7drPLiaIRXZqpXRYRzfRCfsNd8BLfqJd/zOJQW4s3KW8Ysb4RZTAZ2RdMqs6Wy1/3IJzKM2lH6IoThBrxnsFlHnRkl08z5WGS7RvnP+BXPJosmoxT6fG/62bI/3yWKZwo4eBFI93u04S5lnKjhnTwZuwZXhRy12ykEPeWOOMooysoFbc2Tb2RytFFVqQqCe1uTUYdafZ/eti9VoSecGcKatXTATxsHc5mcqnRMyhBy36+W5NLYa9R58HJt4YnDd/Yf/nIx4cFk0B4KsFqj2iUHWY0vC4mDaNGIAkVUtAoVs3CpFMYIyzbLA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MsUZgLCtyKsEdNuXNMxlfctoNkMMKk3ukpTp2QX20ms=;
 b=R9I3WiJYKMnk3nuJ/74T34epGZjdRrM07SZ0FlXB5fhN88yxrOE7AUyyX2epyuzfFRqlfNndqNx6FzGhBgnF/fJCZQ4MxZDI5kBuVU0ggYVxPnHGaE/gUJVYEHnzCRPG+12u398IuMnFlL4nfD48pFOI1/dmAOxNBJfhAfF+7JUXaJM3JDbsDRLpr/NwSO8+/E6qGs35ERQSfWBI5Ul7ztSE9EVcCdx5Y3Jr5B0MvgrnLhRLIg3LOPXlKjzPCiXUiv6B+X2n7j9Qjj/kUTFGnYSRPgS2OvdsyQnBf67dDNdHVOUcteqP957K0CBe2Kx5igquvA4tgeGaHcpzeDy4SA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MsUZgLCtyKsEdNuXNMxlfctoNkMMKk3ukpTp2QX20ms=;
 b=GO2DB6+53LhGiiVflrMHuZVo9GgO8pzekV5hGW3qyKAJGL32DriH3sNT9GulPzh2VxjS/eiJXTMQsAQnznFFp2QhtYojQ74Mlxc43QbrPB1b7Uw/kfGmbLav/mjd0Jxgmz8hUESP7QoDIuF6Bu/mH4A+XbQSeKEcuIcnfGo75+w=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 02/10] iommu/ipmmu-vmsa: Add helper functions for MMU
 "context" registers
Thread-Topic: [PATCH 02/10] iommu/ipmmu-vmsa: Add helper functions for MMU
 "context" registers
Thread-Index: AQHX47d5bUBAY0i+EkObsnwBPyqCUKwx9ZHw
Date: Tue, 14 Dec 2021 12:05:35 +0000
Message-ID:
 <TY2PR01MB3692F7B244E88C6A185993CDD8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-3-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-3-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5c7609fa-b90d-49f8-3585-08d9befa094f
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB3436A29FAA3C962B47B0AA97D8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1169;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 cD5juAUbYGtMDUbg258o/qpY40bIcDculav9n34yg9yeuRmYS5elHoAaXBoTSPjSLqbI9C3l4RMc6XrPmX9ENDALyhoYYmad+qNhTarkcuOP19ghM5MIi2FhAWT9Zw0YqxdGNjD7fXZ32pkOEriMA4tOVC/4UEQyYifaKmRCoDqdOPmJLic7nNzrqA2FLnim6xKlkefRyYQqwAIrtsUyXJBRzlTn5Uj8PK8hXFLipM1D6/LTv7+THqVdtcJhnTUL+IIWOyNwTI9JWMIDHrtf2qoRhDIuSHMsVSbnuHBBmy1y2NHTKK62Owm1GWcRqOXSsDP/WvZDYew/LBZ0DFchLjMHx0d7R5nGjxpL7wcTZ6XL+Lou3qeM/p/tSv5e2MgpSBWfl4uiK6y36Jycoc1qBSqJoiI7tAA1coVFTdNkTaeIPiSdYZGjxvqn1SKNv7WZZY6tNnThCzHiJiCbw6d8fEGSkXE8SIuNli3bwztyl4zZ96dwaHbEllLU57JKDXVKTA42eOVfxw2XWfU42POqog8Bf1EIlus1Y05l/iAqBdIxjshMcQ/KrSNDlFK6h3Eh09lY/ma9vx4LshQqDyx3xhFnIv633xFTU19YCG5jQnQidlyizXOjOm+hUOdPqNGLxteGBi2a8KXDt9wTm/pA+SiSz+HX7wWWKW4kUPXSh93bMMP8q0Uil5JyS3Ah/iP/nUWb8w9BuVYyxuHCZ12w7Q==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(52536014)(86362001)(4326008)(9686003)(33656002)(26005)(2906002)(7696005)(8936002)(38100700002)(508600001)(6506007)(5660300002)(186003)(8676002)(54906003)(66574015)(316002)(83380400001)(110136005)(38070700005)(76116006)(66446008)(66476007)(71200400001)(55016003)(64756008)(66946007)(66556008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Ni9sZVpJeDBZK1FyOG5NeDRRbTMvZkIxNDE1VHlFMWZPTHNrUENMM2wxa1Ra?=
 =?utf-8?B?ajN4TGpyQmlSSDRCOWM4N2Ywb3VUY05VcEkwREdFRmxIdHZkaUlsNnZlYmlN?=
 =?utf-8?B?Qm82Y1FxUVVPaW1pVWdZUjZwRDg5TXg2RVFtV0gxcFc3VXZnSGJuZGc3OVNG?=
 =?utf-8?B?Unp0RVVxYlBtSDlHM0xSYmZHTUJuSmx3NDI0cVF1QldwS0xWajFhWE1aSVlF?=
 =?utf-8?B?NmRHK0d0QURQZktjUld4SFFsYzk3UlhTamlCNGxJd0c2K0tXTVMzL1RtMHBL?=
 =?utf-8?B?OHFBak50dEV1RG04OWlaZGFlQklVT2RiMDFXTXlUa2k5ZllKYjFzaDRzaENC?=
 =?utf-8?B?U05mOGFobGNwbkNtdlR1dlFLcThPQ3pLNXkvdDErZjBZeFU0K0R6bmVmMGF2?=
 =?utf-8?B?TWxXTVB4WXI3cStVRm00U3krbEVWWXRsci8vb3krT094N0VRVGhFRHQ1ZW1E?=
 =?utf-8?B?Sy9rZzhiYkt6Z0RydThlQ3g1SmdkUUZpYjBZUE9GTEFzOFozeWhXdjVSSnZ1?=
 =?utf-8?B?Q0Q4NC9HMURVSE9LblJONVpvc2FpVEQ3ZEVwQlFHdHBHVHlUYVdrc3FqWlov?=
 =?utf-8?B?eE5teCtjUVNYMUQ4QUtCZnplalYxLzBaK1NiVytlbzY1OUxOZDVPWHlBOU9V?=
 =?utf-8?B?d1MxY1BzQms5UEVRRXNvazR2TGFCSzdhdDhHWXRrTXFxY205L09mQ1FyOS9p?=
 =?utf-8?B?bEgxSEFZRXZYY1k2QURzT0hmZTY2Sk5Edk1zWkVBN1VKMDZsNUZjdVdLbGNH?=
 =?utf-8?B?OEFBNGFaVnhpQk1NODJUcEcrK3N1V1NHS0NQWTh1SjNiV0NKaWUyTzdvUkFu?=
 =?utf-8?B?Rm1YWlQxVkh4SkpoN0x0MDd3eUN0WDV1bm02aXM3eUdFTzhJTW1kMlFVY1pr?=
 =?utf-8?B?YlNtM0NBbDNoMmRRbHQ3blVucmxkb0pjcWxUdXVmbVJPMXMxY0IyN3N4Z0dW?=
 =?utf-8?B?WjM5ckpsMHVMNHBrRTlYRlhFTnNpaDdTSll5emk2NU1qWm9jTmFKMXlxa1l3?=
 =?utf-8?B?Ry9VR2g5WS9NNEh4ZmxEbVBwWTZORGVSUWdMRkNrQmJGcDlDTnpVMVMxaTd2?=
 =?utf-8?B?WG1ZemRveGp2YzR3U0VlakpUOTltSzFEODlLZTRBN3FUZnhuVkl4QmxncXdp?=
 =?utf-8?B?VCtoWHRDbS9ITXYrUVFnYlZmTW1VS3hTYldiNGsvTUtVMkpWcG1oK3NtLzBQ?=
 =?utf-8?B?QkoxZUJPNGpyclJQSUxhdHNuRHdFdGtMeGk4ei8zV0tMbDBzKzVJQlErSk9s?=
 =?utf-8?B?M25VditEc1k5aExJdmZMOWNzWUYrU1hCeWp5NmdzUlh0MnUzbGRkWXd4Y1k0?=
 =?utf-8?B?SDhqcm9lRDFWZll2eGRtOFlXbmZ1MzVpSEJhLy81SmozbVRLWU5XUlZqUFBI?=
 =?utf-8?B?NGkycGhOdHljamxKaXAzM1lWNTNta1lWRXcyMHRZdEpDZzI3OHNaYmd4ZU1Y?=
 =?utf-8?B?MzRySnJ3cjVLMXhOVFZueGZxcWZJNVYxZnlKT2liY0R0MzBUZUNTYlFjaHM1?=
 =?utf-8?B?VVo5Nm56bXMvckZjTGVyM20yM3BTRTdmRE1XNkNweHVtYlFteWJyZ0RrSjEx?=
 =?utf-8?B?eS9EWWJ6UnJOOTR0QlNLOWUvc1U0STNCQmF0VEZ4SkQzTHpxT3QxVlQ2NHpT?=
 =?utf-8?B?c0ttR3VQSnRQeXpUMFRGdXd0MjFOelJZejY1QTNHa2l0UzZrNEhwRWhtTXJT?=
 =?utf-8?B?YXJnRXR6MXVwbU0xcnJqbjYyTSt6Nmx2eEdCNTd5MmpOT2hyM2pmVHQyQ0tm?=
 =?utf-8?B?d0ZqT1RuVmx3S1ZTRldlRFo3QVBwNDBnVzhmTWRBdHVDMk1jdlRLUE1pbGgw?=
 =?utf-8?B?OTFyMUJTTFpDMWpBemZMT0dmbDlNaCtVR0xIUnJpQ1N2V0I5OGNGSFNMQmNR?=
 =?utf-8?B?bTd1SEhxUElUQ3lncXRSdGYzd25raUw1UGtHNHNyU3pMcGlWNEFLNE9nYUFG?=
 =?utf-8?B?WHJlNmNvUHVPb0NIN2ZjNE9TaDIwSDIvRTQyZW5PNHdIZUkwZVJvT1g0ejZ5?=
 =?utf-8?B?TnU1WGJ2TFI0UUdTOEZsbzBZQ2hFMWxlZ1lDVnR5ZURFQ01TejgvVEpISnZ4?=
 =?utf-8?B?NWxkUXlESlNzSnZkamI0Q1cySnBSSThndjAxbFRNblArdExmZVdmR1dGL08v?=
 =?utf-8?B?bkQzZDdjNTNyN0pPMjgzM2l0MURVY1ZJa1d4dUlKaHUvSFRNSHl4MDhYVEgw?=
 =?utf-8?B?YkNnQWg1cDNTZ0NqYTNLS05ySGg0TlZzQnNEOHh0bXZrY2VCZWc5MVpTQVNH?=
 =?utf-8?B?RXZQd0ZTcXE2VncvUW42aDM3b3l6bXJhRDVraGNWZkdCQ3cyMko1UU53STh5?=
 =?utf-8?B?K0VWUkR5eGd5ZEllKzdveHBqL1diNCtSMSs5QThoMjVVeDNWekY2UT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c7609fa-b90d-49f8-3585-08d9befa094f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:05:35.5743
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G70YnSwjWSgg7m6eamd76Oa4mFWTT48DTSKFF2pZDz4qqoA9JRHtHmuTRhnHtJnJHUFziKlvrxJD4fHNfJUlAxtwuBLOjfZskSRBq6kUN8m8mU4q+BllrHE+COlZEljn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

SGVsbG8gT2xla3NhbmRyLXNhbiwNCg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbywgU2Vu
dDogU3VuZGF5LCBOb3ZlbWJlciAyOCwgMjAyMSAyOjUyIEFNDQo+IA0KPiBGcm9tOiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IA0KPiBUaGlz
IGlzIGEgbm9uLXZlcmJhdGltIHBvcnQgb2YgY29ycmVzcG9uZGluZyBMaW51eCB1cHN0ZWFtIGNv
bW1pdDoNCj4gMTZkOTQ1NGY1ZTA0NDdmOWMxOWNiZjM1MGIzNWVkMzc3YjlmNjRlYg0KPiANCj4g
T3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6DQo+ICBjb21taXQgMTZkOTQ1NGY1ZTA0NDdmOWMxOWNi
ZjM1MGIzNWVkMzc3YjlmNjRlYg0KPiAgQXV0aG9yOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGlo
aXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ICBEYXRlOiAgIFdlZCBOb3YgNiAxMTozNTo0
NyAyMDE5ICswOTAwDQo+IA0KPiAgIGlvbW11L2lwbW11LXZtc2E6IEFkZCBoZWxwZXIgZnVuY3Rp
b25zIGZvciBNTVUgImNvbnRleHQiIHJlZ2lzdGVycw0KPiANCj4gICBTaW5jZSB3ZSB3aWxsIGhh
dmUgY2hhbmdlZCBtZW1vcnkgbWFwcGluZyBvZiB0aGUgSVBNTVUgaW4gdGhlIGZ1dHVyZSwNCj4g
ICBUaGlzIHBhdGNoIGFkZHMgaGVscGVyIGZ1bmN0aW9ucyBpcG1tdV9jdHhfe3JlZyxyZWFkLHdy
aXRlfSgpDQo+ICAgZm9yIE1NVSAiY29udGV4dCIgcmVnaXN0ZXJzLiBObyBiZWhhdmlvciBjaGFu
Z2UuDQo+IA0KPiAgIFNpZ25lZC1vZmYtYnk6IFlvc2hpaGlybyBTaGltb2RhIDx5b3NoaWhpcm8u
c2hpbW9kYS51aEByZW5lc2FzLmNvbT4NCj4gICBSZXZpZXdlZC1ieTogR2VlcnQgVXl0dGVyaG9l
dmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT4NCj4gICBSZXZpZXdlZC1ieTogTmlrbGFzIFPD
tmRlcmx1bmQgPG5pa2xhcy5zb2Rlcmx1bmQrcmVuZXNhc0ByYWduYXRlY2guc2U+DQo+ICAgU2ln
bmVkLW9mZi1ieTogSm9lcmcgUm9lZGVsIDxqcm9lZGVsQHN1c2UuZGU+DQo+IA0KPiAqKioqKioq
KioqDQo+IA0KPiBUaGlzIGlzIGEgcHJlcmVxIHdvcmsgbmVlZGVkIHRvIGFkZCBzdXBwb3J0IGZv
ciBTNCBzZXJpZXMgZWFzaWx5DQo+IGluIHRoZSBmdXR1cmUuDQo+IA0KPiBCZXNpZGVzIGNoYW5n
ZXMgZG9uZSBpbiB0aGUgb3JpZ2luYWwgY29tbWl0LCB3ZSBhbHNvIG5lZWQgdG8gdXBkYXRlDQo+
IGFuIGV4dHJhIGNhbGwgc2l0ZXMgd2hpY2ggTGludXggZHJpdmVyIGRvZXNuJ3QgaGF2ZSwgYnV0
IFhlbiBkcml2ZXINCj4gaGFzIHN1Y2ggYXMgaXBtbXVfY3R4X3dyaXRlX2NhY2hlKCksIGV0Yy4N
Cj4gDQo+IE5vIGNoYW5nZSBpbiBiZWhhdmlvci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtz
YW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCg0KVGhhbmsg
eW91IGZvciB0aGUgcGF0Y2ghDQoNClJldmlld2VkLWJ5OiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9z
aGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQoNCkJlc3QgcmVnYXJkcywNCllvc2hpaGly
byBTaGltb2RhDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:06:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:06:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246647.425361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Z5-0003wZ-Nc; Tue, 14 Dec 2021 12:05:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246647.425361; Tue, 14 Dec 2021 12:05:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Z5-0003wQ-KD; Tue, 14 Dec 2021 12:05:51 +0000
Received: by outflank-mailman (input) for mailman id 246647;
 Tue, 14 Dec 2021 12:05:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6Z4-0003un-CO
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:05:50 +0000
Received: from JPN01-TYC-obe.outbound.protection.outlook.com
 (mail-tycjpn01on20719.outbound.protection.outlook.com
 [2a01:111:f403:7010::719])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 51883309-5cd5-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 12:59:42 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:05:45 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:05:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51883309-5cd5-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CAN5QOoZ3Lr1THJhgTjh9Hiot44AtBL96LK0xqPGnhIjCJk51fsQQY41HCYInRmjU30NdoGnCC6j8FlF4PFRl8MsElhPfXE3nDlcn1TDPCuESLo/mzjQFkUEJ/g1vQRNy/YshDqVyyjxke/ui5WNguAs7ScZM74uucgYP7TrbzvS4+auHsedioZKOjUT9RRuxxzh0w+ByXvKiynLQLc9iYIRI6ieO0DveW4XW8Z9AUL4PdJamxYbrztwrlwR7naw6jg5cbNSQUoMdVgfsorQjf1g5y6SCEt0RK6K+63sauJXkm4SQFtZO1O9kmh5mAY1I2T5mbVVf18WYXazSoJ5gA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UWR7wCZTh48p5KfsTZ1X+ycSMn64E2sBRAYS2QGRP3E=;
 b=QSAUifmDOP0GKgxlVr6abttTi/PVbDoHBQ8zrvq0zyAU0BNKcWYAu26Ru0sVHRup0aR4udTmCw6e48pVFg/LVNF59KZ5xmNaxEaIh/HwdO5unE2zsBKnMLfyXLGQ1VGMBjVvrP4QfPOEn6+vB7Ta6i+hFmlbUcGJwdKBTrGxR5O6GeqVmmBx9Wh2fq2O6RwBHOlv26aJaIELGO7BnLxj3D1nCmQAgTCrqmke543xu3xKescLjDhJkjHpLRkngMCKylAIiJ7CT/bN2B5l3UZPjb+GeREjm6DYWXi3ILWoS99htUcdUzj4z+FLs8DoT3VWtoTwiV3dFtjsD3mQrT0BQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UWR7wCZTh48p5KfsTZ1X+ycSMn64E2sBRAYS2QGRP3E=;
 b=WGC9wKnhtqbmSUl8LPIir+ERvW9pwcIpiWgNOpOnKYVfensWxv5MQHvlsvvunX3iV+YcKWGN3Y8NQOzIz0A8AcxqpsPg3H0nPu8yKnL36eXZBvxYLwfEvMARVHJi5Ms3vjYV0UTHWQ93rtprjhua7vOPIkJBF19SIOBWOutzg8U=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 03/10] iommu/ipmmu-vmsa: Add helper functions for "uTLB"
 registers
Thread-Topic: [PATCH 03/10] iommu/ipmmu-vmsa: Add helper functions for "uTLB"
 registers
Thread-Index: AQHX47d6jEgJuhJME0m5DFdy3SZFF6wx9csg
Date: Tue, 14 Dec 2021 12:05:45 +0000
Message-ID:
 <TY2PR01MB369283B44CECFC3A5A148388D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-4-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-4-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f8acda79-c781-4b3b-1956-08d9befa0f40
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB3436BB42B8A428CB252D17A8D8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:534;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 eM2Vu88KM0mMe9yHkVQQ2T6ff3Cxcap1flRKg2tk6zzukbLDcDP5XApCb4Ktf0QCH9O0IdutNKY5bT3BIYIa0m7OCXuJepModUQ6b4hCXZrvVzR9McOfdvpmqdzFTgNZsx7FkoBkqOAeKSE14h1sHOCKS4XxNhcGltOF1R/oCldsSWguHsT1M1ShTCIxcLSjGTCqC95tUHW+A0KZifxd6mxWCBTwyM9AYHYEV2vF1zqHgNHwIitaxpBNuwT0nbmzAJmS/vsA2VpYDAb2iFrX9gLoHLsFKMG/FFWHs50qQlNmOgEU3XrMKlFwsYvlhEhwqOGiHolGax1KaK6WE1yBsUpCMdmlLl+XMPVZ8Gf071pdEzXTR+qmKPLjNrCueIy2/dxP2HNxpNcN8gGuy6B0Zxy5ua5q/jEmbX9hmrvJ8WGZsFPVsHhcVCM0dd1p0rC8YIcqjTzBQikh6aVm/PCas8Dptxy5DD14Fhzq+QMDqr1vSnU+D4G6IN01BZyHiGKh0xGpPoOiH9njGLTFULPY0FQarczFTC104yqDGn5M8E5duY0JNYZHKsVUAe4WnoY/EcwYzgsLNNQyVzj31d1vOJ+JqAuMcqGNBDKpowpj8MXEfWs6vOrUDBaAZ6tAZXLo3eQ6m9jqNTUqftA4qaMtGppOLTPK7aS/sptIMpCkVm+kGdAKiLb8d5UeUx9Ikco16TLYMIJWG8f7B7K1H3y1rw==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66574015)(54906003)(83380400001)(110136005)(6506007)(38100700002)(508600001)(186003)(8676002)(5660300002)(55016003)(64756008)(71200400001)(66476007)(66556008)(66946007)(38070700005)(76116006)(66446008)(122000001)(52536014)(4326008)(86362001)(7696005)(2906002)(8936002)(33656002)(26005)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?TERRaUpKcjh6TGdLUUN3VzUrZzcvWTFHRC9sOG5VSU1xN3hLOC9keVRtbUxU?=
 =?utf-8?B?S2RNSjVycUt3YisrbkpPbmpJVVF3bkozcUlHZ3NmZVYxa0xsV0hSUXloUTFL?=
 =?utf-8?B?TnRtM3BTZmM3Wm5ndW5EbjB2TVpHTG1OTXJZcFVPMFBuN2EwbFVUYXVseHdF?=
 =?utf-8?B?am9mcmFsUnlzaU8xdy9Ed0dlZXFKdHlPMGZhVjN5a0pDSDk3aXJrbTU0UlVw?=
 =?utf-8?B?bzFrSkxHdWVjMm9uSE1rdnNDMVBHL1pHeWVPTThwQy9MT2Y1eUd3WTNOT0J1?=
 =?utf-8?B?Ny9hcjJwZXA3OS9NVVYvcGhtSmhVRlRNbFZFT1daSlZIMVpDeTkrNkNxZ0ww?=
 =?utf-8?B?ejJ1TFNld3lnTlBZK2Y1SzQxckJ2bGoyNGwwbWIvS01qK0prc29rTTRYQzhG?=
 =?utf-8?B?cHdYT3hrVm1iVFNyZ1VpT3A0VCtpaTFGUHJqaTRqdkhSRkVIL1BNTGt6enNF?=
 =?utf-8?B?Q2VuRVpBazFrVXNYRmxybnA3Qm14blRWQVlKZmJoZjlJdUVIWlFiYUx2UlNQ?=
 =?utf-8?B?YmYvUVg1UmdLaGp1eExzZU13ME1CZHFMZ05BRkpTZUZIdnFndzlQLzJsTHN5?=
 =?utf-8?B?ZUc0QlpSZFgzWXpkcDlyT1JkYzg1VlBOYlZITFB6b2YyL04yU1lnREEyZzNh?=
 =?utf-8?B?Z2VPZU9sS09aYzlWSTY3bGl0TXBSdXVmV0duYTBKRDhtOTBFeEM0b052NDM4?=
 =?utf-8?B?N2dreUlhczVQMHdkSHlFZUJPajU3ajE3VE91WUdZWURuWnZUQjZsQTJpbkZ1?=
 =?utf-8?B?RlhNQ3lYdXJHTWI1V3RKWkpOakIyYzRIN01zT1VWQWFWMXBaaUsyV0hQMkxW?=
 =?utf-8?B?Wi84MUxUMHFCMWVlS3FpR1NBWlkvdzJUV2RqTjVITmk0Q1FLcG9vbTV1UUQy?=
 =?utf-8?B?a29pTCtES0N6UkRGTlRWbnZOWC96NThHeExwNVhsNTRTTWJMTGpURVlpM3Nm?=
 =?utf-8?B?SjdsYnVWbWxsK0paY1l0bll1UFJnRWkxNnZwVS9aZTJaaFhDMVhQZ05zUnRi?=
 =?utf-8?B?NUJ4VE81UzRVelM3S2NNR2dyK0NYSW44SUFxaVErRDA4TmxrZlZBWWlxeDNy?=
 =?utf-8?B?UERvZ1NuVGVTam13cDN0b1d4bFd1aWg1UlVNUHBoVXcyQUJYVnJDb1lZb2R6?=
 =?utf-8?B?eFhUaXN3V2JoS3NTK0JodnU1cFJNZGw1b1FrdXdvdVBoeHRMZmxLT2V4YTdo?=
 =?utf-8?B?MWR6eXlNeXFWRDB6aVZvbWpENVRxS01nZG1mYnhyZFA4VkpibTcyTmhUK3hL?=
 =?utf-8?B?ek5jcG8yMVFkYXEwbzFEM3dFL1NOT3N5MG1tRVdRV1k2a000SmgyNVBuUWZa?=
 =?utf-8?B?K015WFZkZHVIRytuRlltZmFRemVJclFhMndjcW1GN2c3NmNJdzIwZmVGblBT?=
 =?utf-8?B?NFk2OUQ4cWpiOGswUEp0N1lSWW91VWRmUXpTZzhNMGhUYmFTMlpjV0VOQmoy?=
 =?utf-8?B?U0ZBSlF6RkQ3TUUvSDVQTHpWVWo2blR2aW1BcVgxTTJCUWJxVnFzRGQxM1ZI?=
 =?utf-8?B?eGhNc2lrQ25TTkpZYVFsdzR2aFcvSDBUcEZpMk1seHRlOExsV2dNMDV6NmI3?=
 =?utf-8?B?aEtHbHhiNkRrVW96cDZ4Q1Q4T080Y0ZRRmZteXF0WFdXOGpFS3JOUnF1Uzdh?=
 =?utf-8?B?RXAyT1E0bEdXS0hpdXNoaHd5OHdtR2MrSE5GZW53a3VpcGhDOW52NFlhODFa?=
 =?utf-8?B?T09waXlFcW5iUFlzMzBzNVdZQkp1N1owMXhhMDRJQ2FmcTZHeTZXbVRkUk1z?=
 =?utf-8?B?NVVhcndXcnBuRjc4dVVBdXBzblJGMFhNdkgwdjFIWlVtVElSN1NzOHF0V0s2?=
 =?utf-8?B?OURLUytXTE9PNEZQMlVMTExtT3ZaTVFQVEJyeGJmeDFaUSs0UmkvcnF5ZTFK?=
 =?utf-8?B?djcwelE5M096dTNSNENFY1JhcHRzVXpTeHFFUlQ1bFppVTFLSDVtNUhodTM3?=
 =?utf-8?B?OUhJNmlHaVFiUTFpWmFrR3hIU1FIOVJNOWY1OWNhQUdqRDUrV0VhcUV4dEpC?=
 =?utf-8?B?NkJVcE5EcE5xSzNkenhnbzVDVkNGODV1a3NpWG9INmpvSWNRd0MvNnFDTW9F?=
 =?utf-8?B?RzBsWE1jTUFaQjBaMzliK1VUMlBiRkNncTl0RE5IUzV0MU1rVHFNakxGbnhi?=
 =?utf-8?B?SGNLbEVxWDlScXBubmRSOUxwTTM1K1I4eXNaeU5BdURzbTRQM0QzazJJR0M3?=
 =?utf-8?B?R3hrb2JtU0pNeVJtaUdhYlZkdTE1cjRwTWZRVHJpR1lLWUIrTWJXMk9LNEln?=
 =?utf-8?B?WEFnSHNnT2Z1NnZ0WlE4TFhQazhKZHQzc3RBT0JyaXJJMUtDam9uUGpFRVFD?=
 =?utf-8?B?bk8yVWlVNkd3TGZlY1IvMFEvQmwvYzM1N0JSZXNIN2p0dTI3ampUUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8acda79-c781-4b3b-1956-08d9befa0f40
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:05:45.5616
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gpOIyPO5jsTPv7Iyfl/9uYt3qNC+4Lcb6TWRUfY0t+wCJrsRZ3cwJvuscsBeURK3AzcX4sqgR0ZwaY9/1ij0GesWuvLGUAL7vAzGTTBQIUG4RfNL8unX8tKGxEHJ8G3I
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

SGVsbG8gT2xla3NhbmRyLXNhbiwNCg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbywgU2Vu
dDogU3VuZGF5LCBOb3ZlbWJlciAyOCwgMjAyMSAyOjUyIEFNDQo+IA0KPiBGcm9tOiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IA0KPiBUaGlz
IGlzIGEgbm9uLXZlcmJhdGltIHBvcnQgb2YgY29ycmVzcG9uZGluZyBMaW51eCB1cHN0ZWFtIGNv
bW1pdDoNCj4gMzY2N2M5OTc4YjI5MTFkYzFkZWQ3N2Y1OTcxZGY0Nzc4ODU0MDljNA0KPiANCj4g
T3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6DQo+ICBjb21taXQgMzY2N2M5OTc4YjI5MTFkYzFkZWQ3
N2Y1OTcxZGY0Nzc4ODU0MDljNA0KPiAgQXV0aG9yOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGlo
aXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ICBEYXRlOiAgIFdlZCBOb3YgNiAxMTozNTo0
OSAyMDE5ICswOTAwDQo+IA0KPiAgIGlvbW11L2lwbW11LXZtc2E6IEFkZCBoZWxwZXIgZnVuY3Rp
b25zIGZvciAidVRMQiIgcmVnaXN0ZXJzDQo+IA0KPiAgIFNpbmNlIHdlIHdpbGwgaGF2ZSBjaGFu
Z2VkIG1lbW9yeSBtYXBwaW5nIG9mIHRoZSBJUE1NVSBpbiB0aGUgZnV0dXJlLA0KPiAgIFRoaXMg
cGF0Y2ggYWRkcyBoZWxwZXIgZnVuY3Rpb25zIGlwbW11X3V0bGJfcmVnKCkgYW5kDQo+ICAgaXBt
bXVfaW11e2FzaWQsY3RyfV93cml0ZSgpIGZvciAidVRMQiIgcmVnaXN0ZXJzLiBObyBiZWhhdmlv
ciBjaGFuZ2UuDQo+IA0KPiAgIFNpZ25lZC1vZmYtYnk6IFlvc2hpaGlybyBTaGltb2RhIDx5b3No
aWhpcm8uc2hpbW9kYS51aEByZW5lc2FzLmNvbT4NCj4gICBSZXZpZXdlZC1ieTogR2VlcnQgVXl0
dGVyaG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5iZT4NCj4gICBSZXZpZXdlZC1ieTogTmlr
bGFzIFPDtmRlcmx1bmQgPG5pa2xhcy5zb2Rlcmx1bmQrcmVuZXNhc0ByYWduYXRlY2guc2U+DQo+
ICAgU2lnbmVkLW9mZi1ieTogSm9lcmcgUm9lZGVsIDxqcm9lZGVsQHN1c2UuZGU+DQo+IA0KPiAq
KioqKioqKioqDQo+IA0KPiBUaGlzIGlzIGEgcHJlcmVxIHdvcmsgbmVlZGVkIHRvIGFkZCBzdXBw
b3J0IGZvciBTNCBzZXJpZXMgZWFzaWx5DQo+IGluIHRoZSBmdXR1cmUuDQo+IA0KPiBCZXNpZGVz
IGNoYW5nZXMgZG9uZSBpbiB0aGUgb3JpZ2luYWwgY29tbWl0LCB3ZSBhbHNvIG5lZWQgdG8gaW50
cm9kdWNlDQo+IGlwbW11X2ltdWN0cl9yZWFkKCkgc2luY2UgWGVuIGRyaXZlciBjb250YWlucyBh
biBhZGRpdGlvbmFsIGxvZ2ljIGluDQo+IGlwbW11X3V0bGJfZW5hYmxlKCkgdG8gcHJldmVudCB0
aGUgdXNlIGNhc2VzIHdoZXJlIGRldmljZXMgd2hpY2ggdXNlDQo+IHRoZSBzYW1lIG1pY3JvLVRM
QiBhcmUgYXNzaWduZWQgdG8gZGlmZmVyZW50IFhlbiBkb21haW5zLg0KPiANCj4gTm8gY2hhbmdl
IGluIGJlaGF2aW9yLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28g
PG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KDQpUaGFuayB5b3UgZm9yIHRoZSBwYXRj
aCENCg0KUmV2aWV3ZWQtYnk6IFlvc2hpaGlybyBTaGltb2RhIDx5b3NoaWhpcm8uc2hpbW9kYS51
aEByZW5lc2FzLmNvbT4NCg0KQmVzdCByZWdhcmRzLA0KWW9zaGloaXJvIFNoaW1vZGENCg0K


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:06:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:06:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246650.425372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6ZF-0004Tu-4w; Tue, 14 Dec 2021 12:06:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246650.425372; Tue, 14 Dec 2021 12:06:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6ZF-0004Tn-1S; Tue, 14 Dec 2021 12:06:01 +0000
Received: by outflank-mailman (input) for mailman id 246650;
 Tue, 14 Dec 2021 12:06:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6ZD-0003Iz-Qz
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:05:59 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20731.outbound.protection.outlook.com
 [2a01:111:f403:700c::731])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31e444f8-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:05:59 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:05:56 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:05:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31e444f8-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jEqrX4fa5cjv3+NJvtMcDUQZ8jkvJfIudNLBhy8r/D9Zp2M1NFslyA75s0SyaGlOWqf8BYinM7p7AomKdyMDbyoNfzVYdZOKWkbbCoY4VMCUDhQwXEQ5NqH3yLx0PIz14lR0A2RQqJ8n0kShJEEKSbUKGUpOsTXDnUEod4JSrRzFecyiyuI4MVLrTN+ZrAMub/UABG9MHm5A4RMDbwWsASmBRbrehdFiaAkv6i1RHxntVr6NuOyBjWMHZ9v14TL8Yy7Fo6SmyD1BZLU9sTWMo9CnwhR1xT2jToEMZFFpCfYpKDnZGTW5slaPts4YZosYnwbka9Px8ePKvuh+uMNx0Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5Zi0ScpQv+Pk0yCO8VpXPoAyBXpW6xs9wjgk1+H+o4g=;
 b=a6zMcTjNuuGsZG6haRenu3WsD+AMalMJpeewnTLxE2F+m7xaoZHkqFo/IOmgcZTOJqFYkWArJ6x2ZS2S16gc/1kYg+1R1uQoABwaricwnnzpL9EGqeNz+/6NxI/QR8R0nBn9JQPo1BtfPmFd9Rblz82EGckSSoqlOff89m31ErRNIO2Z1ip5CqXH7WT+BqUbjraVcIkNaOaO7AQJMEBTyfPis+zm8sqC00aAr+WGfH97wRCdwhuabaz/j9w8bATG2MkgKZeZaqTvNY7N9AaYyjJbQrANPpJV8GENgiKjesZpfWbU/Frumd4aHu39P3ey7Wqbt7cXpde50CFCjnaX2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5Zi0ScpQv+Pk0yCO8VpXPoAyBXpW6xs9wjgk1+H+o4g=;
 b=KgrwrifX0VZp32QdPlEqkY8OINF/4F2qbfb4PWwXqQn9u7r33FIVkV3XWXso7quwvWRRCH72Zi+2LVLyLSiDRL17STNXKqm5b5OiIffdRHyghPdtwma4V6PqAIondE8WpTonCvJ/U5s3jEHklJ2992ukXeZ62bd9ZLmQYQYqM6E=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 04/10] iommu/ipmmu-vmsa: Add light version of Linux's
 ipmmu_features
Thread-Topic: [PATCH 04/10] iommu/ipmmu-vmsa: Add light version of Linux's
 ipmmu_features
Thread-Index: AQHX47d5KD29OXhbPEy75XHCjn67uqwx+H8g
Date: Tue, 14 Dec 2021 12:05:56 +0000
Message-ID:
 <TY2PR01MB3692ACF84DD7938E620B8267D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-5-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-5-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0127962b-c815-4430-be8b-08d9befa1589
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB34362D30FC73C5196C4DE5B1D8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 uLlfFTyzke0tRXAqcjhRijuUSqc+JV2BwtBDoQFU5MDnS3EzebzcEaY8sqta5ZUPOQzux5pU2dBhpxCbv+Mf3TqZXBjCBxD1UZ2QvHTTL4IU2lLAaHT8KpqoG0GBURmzrxBmltsIWgv9k6pVTflTjo4ry9D7A5Wcn3bO12RUNff0SAc/8iG4cnC8kTI3KfpSt92o4J/nFiaqn8oCDRrq+pFQeyYw+10BzFgyFRQOqLuCjblY0hn78EyjDyHP6/ikfYmsi6XjT9jBZ2O4KqifChyZ0snxKqzeVLj/KdqxMiiud7dwAq6qaYGCk1zz5gqOlc/yemfdWxyKmwqX425dv4zEavM6+aRyAdVqaThEzFOmDhLaNjk5yQuSgibMyEmAAGB00jQ6NZ7Lnf7tsH4d6OwDB/Yhd077xXLX37wqX4wSSKzjpwzQk3MXUC1HA+y9gleGasctFlHsriT5IDBiEPHpDM93NVcz7CSJy/pRFJY32R93jbk2NpgRPQWIFD7/PYZ+YC+6W2+cZpCrYkBW7aquILYPHdHlniywS4nTGJPlXrrldXkRzSrVKadHC6m38zQa/BdGrt830v3vXIgml54sdz2C43gwAHjjra/J3OxGC6qhth9wRf6pQ3XTlNgBKc6uCHqlUDQjnb5G2zJghvWOtcCM2u6m2+sM7rAJdddOWWswMDFT8+fqnm9v+Ck2VYmm+cGXGHXL9lwMUtPdFA==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(54906003)(110136005)(6506007)(38100700002)(508600001)(186003)(8676002)(5660300002)(55016003)(64756008)(71200400001)(66476007)(66556008)(66946007)(38070700005)(76116006)(66446008)(122000001)(52536014)(4326008)(86362001)(7696005)(4744005)(2906002)(8936002)(33656002)(26005)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?dDfkwVuPYP6fBiPXRnJGbDg+68yUsXiCNH01CaVbOuRIZUvzHAHeSEIGuV+W?=
 =?us-ascii?Q?TlVVCNtejtjB1SZ7jNoWnBnZzdG7QJJ5HBjov9GX3nUCGv7FKTjZVvLL5PLa?=
 =?us-ascii?Q?YAuT6ZG0PXdQqQl75dyubUg4nY56hu7KjVeguXHVgQBlJrIDxMlklasx0W6b?=
 =?us-ascii?Q?02S1yV9s5uwO8jkWNVeesv3QaRPXkxfNzkGlcVfeaTZH8PZ9wOsH7B5CzI/P?=
 =?us-ascii?Q?YiDqge0JcAgxYtwEELuGeecU0eHNf5Xjn/ncxljn265fjaf0mbHZL0Lw2Ypg?=
 =?us-ascii?Q?fGBuLW9c9dENNWm10UOQAD0LsOsQqZPObJZj8CG+DC141Fwcg9MN4UpX9fVL?=
 =?us-ascii?Q?AJ+9Vrju9mHckOYufjiqi4BUvRVIjBBH7L6VRA/YzZ2bBJPa3eo7h49qb/9u?=
 =?us-ascii?Q?rDoi9y9gjXYYZpkS8I0Id98RuYFg4ltOMJ5We7xeSF0obpFeRBTFWm8QQMpB?=
 =?us-ascii?Q?a/p3OpU7SID8QVYf5QeCOH0rpV4IiddCh9JKl5DjlOeAZON+XhgpnUGBFqGA?=
 =?us-ascii?Q?ZWdyr+L3ErqfLzeTnt71Nvyct6lMeNYfacUK1bEnM2TLzYCa1BnoErGPm9Bw?=
 =?us-ascii?Q?GSkzKJG9h0lmEGLRB5u3wL22UXl53A6jorVpsbJ8bsUHnHu6Bib7C3Fl+oKZ?=
 =?us-ascii?Q?5Ejk+s+zHwQOWD0e3CPf9HZa7bTlCsSE3ttWg6Qc0Wx48scm13m5jBDOGYh9?=
 =?us-ascii?Q?uiZZuhEeLbRCmuoW55RH/L7cQ0UUReHeLULRFHHPanPOz0oqjfUYhhhDvAJC?=
 =?us-ascii?Q?tuNnyTcK4kE4zH+B2xZ0wL2oLpazs61wYflYvEc+AHpW78O47Gdm4QxNcDn/?=
 =?us-ascii?Q?qujxuKLP49zrWIezGydl7NB8gEMU46czTJ1ZRIsr3Tz1NMAKt93PLF5kc1Q2?=
 =?us-ascii?Q?XWpzfojGQuq6EVE9B2Jz7Gk9iB7mAptSCqsLive+2sQGTQXW1jcquNSnhsUL?=
 =?us-ascii?Q?ylJcY/JIut+MeUpm2xJgOheiFJGFkOZX7e5Lz6CNjFGaByqJnO3oOiHL6Bxt?=
 =?us-ascii?Q?ee96vHxrZnEkzMuZ36HNlrcY01dViKQvzXy17sCajlijcUD+g/UvhTIXmp+T?=
 =?us-ascii?Q?q/Rhti9oJZSNLmnKfcv7ejPVpATLTHP+bB7yyCsu7nr7iNT20ikjHcGaWcxI?=
 =?us-ascii?Q?Y49erHS0J+b96LhSH4xb4Vmc2/Sxwa6spoU/A82Kr+f8Ltez+IrrsYJJivMd?=
 =?us-ascii?Q?Y4CeioGnQwbIN4q4dv+Qm/P8EyAdGJuls1SXyJfE8USlO9BBKa/Jb4k2XfMP?=
 =?us-ascii?Q?n0hrMHvAS/yvK6i1EegEtQn9j0vxLB4Izybae/wjSJF6PMgPev1rol68CkQN?=
 =?us-ascii?Q?WXdad487IGNnUUZ2cAAYeKGqcAC2LA0FSbkXdd5ReFVqOUfvqzCFa15FHN6R?=
 =?us-ascii?Q?U+sXTtPw+2KPk7iILDU+X+4VpnltGjN7ldaU54FZT83WtDsL/ZEu5PcA2BEO?=
 =?us-ascii?Q?xKQgr7WVUB5uVp91D/PqAOW8GgbITR+o3LrE5Btx93Uw/tlBQhSJYCYcpZi6?=
 =?us-ascii?Q?TT3U9h7F4E5D2hcji60RdcdlkjVZkedWhN3tC7tJ1WAJZ/iPbSw7iYBBhjNh?=
 =?us-ascii?Q?jRGoBcHNg/j3/+em00BreC7swa2BCEleb9NihT5il2AwGS63D2f3XRDCiWz6?=
 =?us-ascii?Q?lRxEUNSeAIO1tJxgzYlNxAvH/qV+bE0SAMW4ZbIBiaz1Z3QnV//SrQdptzgP?=
 =?us-ascii?Q?yVtU/pnpWvA/Rxii3QgkZloQETcg/azxmTOmr4vSYxhzwt8jx6/8IBcuLfKr?=
 =?us-ascii?Q?Lu/Uyt+vsA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0127962b-c815-4430-be8b-08d9befa1589
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:05:56.1306
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mJljCHMcTUHfqlav/y/6u7hJifkLhfCaTINcu1skFq7wfOUoCHraglPnuB/N3Zi2PCa9AShL/kkBhNIkiJR8g5F4To0N/qF5igs+RemxhAE2BO2IGUpj8h7pLMVAuE8o
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> This is a prereq work needed to add support for S4 series easily
> in the future.
>=20
> We don't need to pull the whole struct and all instances as Xen
> driver doesn't support old Arm32 based Gen2 SoCs, so there is no
> point in keeping all differences between Gen2 and Gen3 here.
> All what we need is a minimal support to be able to operate with
> Gen3 and new S4.
>=20
> Add Gen3 specific info with only two fields (number_of_contexts and
> num_utlbs) for now, the subsequent patches will add remaining bits.
>=20
> No change in behavior.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:06:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:06:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246661.425383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Zy-0005XC-GT; Tue, 14 Dec 2021 12:06:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246661.425383; Tue, 14 Dec 2021 12:06:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6Zy-0005X5-DF; Tue, 14 Dec 2021 12:06:46 +0000
Received: by outflank-mailman (input) for mailman id 246661;
 Tue, 14 Dec 2021 12:06:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6Zw-0003Iz-V5
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:06:45 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20723.outbound.protection.outlook.com
 [2a01:111:f403:700c::723])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4cc0f9a9-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:06:44 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:06:41 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:06:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4cc0f9a9-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nMKwrQMcZWpYGtU3QfzqYxGUlnNK1BYK7v0g+NFOsdHtbn9SxdX9n7xS7J13P7jWifukKU4BCnIsPqkBNOvJ/9mp+dEHtwaR+ppI3PNdtbjTbi5cAOulm9Ecr0Zxc3cVu6CXhpc/of2qN+bDD4gkaM4rYrmIUKO8jJgC4EyWolh2PNssRr13KGTK3EPYqGoGy9T8aVEG3JVMFbIj4Zgjdt6WtV+7lGH5givNIasS0AQZeqbcdN9H65ikbUDGHvifJOCjdTn+mDm/quUKLJvToHOLNcfQbVDrRe7fogr8Qpx/RL+pYcjWGqa5xa95WS72W8oaRrMGbX3RYcTPHze1Iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3W5IVQyfR/x1Llh/Gab+PDEOaMjzQAq4z29MrhmMMvs=;
 b=AhqLfxQ7s4oG6xUrrCq1AG7lR2IJxcTVLa1ee/RfcLhwNccB37zaOtJPu3W4Xkx4V3pKKrLWl6bAEJ0Vw1oCjsYGMNW3SromSoRXb31gRaHCLs7D2GnxlqkL167ri0q3vaOyM6UiSl0JkXeExEM2pzeC8DA/Yoz4adwlFAwBlNI/t5Jpk7wckzGJYfwM8IjJlOmmxAp9ozRYV2GgyxIA7AwY3U5cQAqRAO35QfJcIuNf1bgSHg7UH10cdjcF391sUwSeCTF7aLiZdQUArsKfBIi33kLQxKFvcULvsq/A2G9GjSiSUUD61/c+8kKhWP/hOOvx+Q6cFCZx+zB6vIgxNw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3W5IVQyfR/x1Llh/Gab+PDEOaMjzQAq4z29MrhmMMvs=;
 b=asITbfTo/Ii4Evet3kzVhSn4eFGkmW6KhNG09eIHc2U0ynLXQo62VGTAo6A9bdkASfI+yYq14kFq4XQq6uDE5b2bVm+MbsPGHKLVhJUljoXN6LpjjQWpEmEQ/78XFzEqRC3L5TDLRguCy5xAgjXAtmKl8stUIcKGru9W/mqXiXc=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 05/10] iommu/ipmmu-vmsa: Calculate context registers'
 offset instead of a macro
Thread-Topic: [PATCH 05/10] iommu/ipmmu-vmsa: Calculate context registers'
 offset instead of a macro
Thread-Index: AQHX47d6LazdN1mBlEi6ZMYdv27fAawx+SqA
Date: Tue, 14 Dec 2021 12:06:41 +0000
Message-ID:
 <TY2PR01MB369220015BE41FEB9CAC24B8D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-6-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-6-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bd7b52ee-c005-476a-4564-08d9befa3073
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB34365A853ACCCC6DA2E3F8ADD8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1850;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 FdLmc8y+mldlBL6ykmKuSY3SQ44tS0Ut9J7LjYIRYlJw2CYqxJsfA/vU9jX5BTGz5gXDOsDa/PnaV6pxCn+DzwVHi+pl2yy5+uy9525I1GknCcfPE4w/zxLDwVtugTBXr8vN2SW4Uh7miqL28hp3n3qzmrf6duc3oEk7azlvTARCZUBmD1zj/u8tTqa/n1KZgeYrCtwM87/O/yk/FP6GxO1ITDZlpymUrQN4Kvsy3WGZwho1M9Ox9n/bju5E1NDvozw24OnouKrxOE40vhPC+06o9KE4Kec81xWAa6C1WacaM4xppuCzw3Rdo1lMKqHX8LVFBFg8r02GdUhgI1vaY4d7Nf0hLl/S8DizPjIe+nTrR0QfYcEpadSZTxwNyFcX7w3HGkLSjONhZdRKUDYgMXf68VWqWW/YNQLtCBOiQpEQ6PvknVQVbi33maLz/MSxGqE/YbtpzZTe4SsEINA8T5FNUyWo9VnDJkbWfs308xFSzot3yho9rY/1jPEGxxWYcmIHHU2pQ9glbTU/z55vyz7VIHj205ySMv/kJAdAtv5nPZQiFadrYJV8CYhOMwrn3JKS5tQNstMV4J5fx3u5tafJC9aTrkZHYURcqQNSRjz/ABr6c3BwZQmkY3gteYAPpUDGQ3RSwKR+LJJi1LrjZg2wx601RHfxFbK4X0ia2G+dBMw83tLffRSO2XwYJX55X8tavz1SwdS6kH1hi3BswQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66574015)(54906003)(83380400001)(110136005)(6506007)(38100700002)(508600001)(186003)(8676002)(5660300002)(55016003)(64756008)(71200400001)(66476007)(66556008)(66946007)(38070700005)(76116006)(66446008)(122000001)(52536014)(4326008)(86362001)(7696005)(2906002)(8936002)(33656002)(26005)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?Rng2UmkxSGl0U3V1OE5DaUlmRTcrN2NQamQrYmhla2JnL09IWi9rd290VHlD?=
 =?utf-8?B?NklpQTVydEQ3YUVTczdTYnE4U2tta2t2TG5DWTI1TzQ2THVqaUVQbnFDUWt5?=
 =?utf-8?B?dkJuNHQ4ZUtXR0Z6bUxFc251VFlZM284S1Rpajdxam04QnZmOXJtUjZPM1p6?=
 =?utf-8?B?RzF1dXZySTRObmhucXo2aFRLSWk5T05sQXlrNTErOVNNVi92dmdpYmNpRVRT?=
 =?utf-8?B?QVVpVHpvaWEyVjJhSGJ2dzNFMHpQWGw0Wld5K016VjdVRFlrYzFtWmpTQ1kv?=
 =?utf-8?B?U1FBdEdZUjVYMlZ2TkFTRDQ4UVpiUU5ockJMOW41bWhCa0hXYm0xeDN0NTJU?=
 =?utf-8?B?aENQWnhBZ28rNHhCdkFpYmU0OTNWOHkrN0J1WmJXcWVEenAwcWhWdFlMYkdT?=
 =?utf-8?B?V2JqWXBJVkRYTm5hL3k3OUJLUlEvbWNOMkFoZno2YUhzUmdYNVdIbSt0NEo4?=
 =?utf-8?B?VGw2WFByVTB6V0ZLVHJxekRzcERKS0JqWEd2Q3hHemE4aHZhR3Z6VWZwbTZl?=
 =?utf-8?B?NzhBWTY0Uk1UWHQzekZVS0tIeTl5QVlUdy9iS2J6dm5wa0NwMDVYVHltK3JO?=
 =?utf-8?B?ZjJWaEk5NWIzTnZBZUt1bVlKQVVQbGR5RmdZaUZreFJ5VTcxb21WbW9VR05W?=
 =?utf-8?B?ZktNdXZiNllrV2ZVaEFQeENnR0MxenFMa2d3YW1oa1lWL1BuemtkVU90Y2hW?=
 =?utf-8?B?OXhyd3RzdnFCMjB5WTAvam0wdmtHYnVhN05aTUpPTWdTdm1jV0VGLzMwelQ4?=
 =?utf-8?B?aWtWbHFiQUx1TjZDUzNnRUlsbmpsNEJjb2Z5S1FBVVdKOHMwaloyMm5SVHhN?=
 =?utf-8?B?cUpSOWdOVWJHYmxmRWZsSFRLdjFEaEN1dC9zQXJoSW5PWnNjV2JmTVBPVmw0?=
 =?utf-8?B?Z3dvYmEzRnU2bGVIdU05WmJoSTFZc1NlWWVlbHFid3c4QlcwY1pJcnNldU44?=
 =?utf-8?B?NjRPZmZ1a2oxOGRlMlcya3RiaXRpMFJIQnVkZnV0UHR5N3A2eEpyWGFZS1ph?=
 =?utf-8?B?OWE1WFgzeDNWVEk0N0RYR25STXJvLzF1Slk0M3NWNGNQRERHOFByeTZySkp4?=
 =?utf-8?B?eHZlREozUkF6Tm14Q21KcDNUdWRBMys0clJpUW04emltc2w2Yyt2bGRybnEx?=
 =?utf-8?B?ekh4Tm4raXFBK240UEVLUG5rN2RaMlc1ckQ1Vi9RbXJIdHNiRzZzRkRhblEy?=
 =?utf-8?B?WGRRWXYwZCt0eVVmeDIvRjNreWdXd09vVkxvbS9USDB6RDZyQmNrMlljWWJu?=
 =?utf-8?B?RjJUM1UxRC9LeWUwbUxyelNqOUVlbTRmUkpDQkJDSDVpb3BaZ3JQbVRaalhR?=
 =?utf-8?B?YmlkRStlSUZjMFhoZGxmMWxhaStGZVBKYTcvZXZpakdiZ0h5THRtZFc5SHVh?=
 =?utf-8?B?SVJDMlhEWFRKTzhCTVI4bzhjaUNYalRhd1lKcG9zOU5PajZWOTlSdUtXeFVJ?=
 =?utf-8?B?dFFNL2NuNTE4OE9HZTlXMXlIcDB0QnZ6L3ZqZDhLamlqY0NLVnltUDFqLzF6?=
 =?utf-8?B?WExEVXI3YmMzdDBVS1hWZmt5RUYyV0ZsRVlyZ1QyRGlKMUt3S2pwSWxqOUVo?=
 =?utf-8?B?Z1lPS2c2UjJWMmZKNGY2eVVualpISFc3WmJReUJMc0l5THpxMjI1ZmVmUTRD?=
 =?utf-8?B?dkMwWmZTc3R2RTBYV29GcFl6TFRoZmNXd3NNeENiWk1FYXo3Y29XR0V6K3pa?=
 =?utf-8?B?bDFPREIwQWpvUWU1RW16SERKMmNPY1h6aER3eEZFQ2hSZFdIdEg5aUQxalJr?=
 =?utf-8?B?VnBVSW8yMXB3MFpyWkFrcStVVzlITE5yTVB5aTQvSHF5eHd3RkxsWnZGYlR2?=
 =?utf-8?B?cVJkcll5NFVvUUxuWkdOOElTREhzY0QycmdBb2Q5Q3RuMXQrUktHdEpIMGhH?=
 =?utf-8?B?SEpIRnFWNXpiNXdHdjFpTUJOTGx2VElwVXZjOWNPeVVBT0pCOVBwc1dmYVFP?=
 =?utf-8?B?b1dqMWEzcXZmdE1hYVU0VVJJS3FISWp4cmc2TEVzR2t6VEVEakFPemhxZnFR?=
 =?utf-8?B?WjhtRjZadm42eVo1VkpHMHNLaWQxQ1Blb2Q5czZkai9mSGtqYnlxMklyTGRO?=
 =?utf-8?B?WnVXRXh5Wi93NjQ5TU9EM0ZKZHZtZ3Rvci9zM0UwVXpWbi9hV2FXMnpsM3Nu?=
 =?utf-8?B?QlNFbmgxRlJ5VGZHZkJpOGNlWXRZenQ4YXl0L21Xdk9reDBMaldxeXl4RTdj?=
 =?utf-8?B?S2ROZVI4dkNkZVJDNVpPTjdKYi9nWTh3MnJxYzJWTnNJQm5EbEMzdzhFSGU1?=
 =?utf-8?B?TDdHWmNxaFAyVE56M2UzSXB3bzBReHRkT1FSTHhiQ2pjR014WHpkVHo0MC82?=
 =?utf-8?B?VjlGUnFlYWFnUTZwVEk2MDQwQlBwZCtNSENxcW5TdmF5OUhlYi9mUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd7b52ee-c005-476a-4564-08d9befa3073
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:06:41.2478
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CvopMt6+L+B6nZf/AMjGCGgx7TexZiBJrHLx1gXun5qDcHUwud1DgEXGnbgHyoRhTCafUQq/WGGOJn4E1Kc3fwyuYqiAkUl20cZmPuPFLYAeRUZTi8+Q5Ufdj8kTwZwq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

SGVsbG8gT2xla3NhbmRyLXNhbiwNCg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbywgU2Vu
dDogU3VuZGF5LCBOb3ZlbWJlciAyOCwgMjAyMSAyOjUyIEFNDQo+IA0KPiBGcm9tOiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IA0KPiBUaGlz
IGlzIGEgbm9uLXZlcmJhdGltIHBvcnQgb2YgY29ycmVzcG9uZGluZyBMaW51eCB1cHN0ZWFtIGNv
bW1pdDoNCj4gM2RjMjhkOWY1OWVhYWU0MTQ2MTU0MmIyN2FmZTcwMzM5MzQ3ZWJiMw0KPiANCj4g
T3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6DQo+ICBjb21taXQgM2RjMjhkOWY1OWVhYWU0MTQ2MTU0
MmIyN2FmZTcwMzM5MzQ3ZWJiMw0KPiAgQXV0aG9yOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGlo
aXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ICBEYXRlOiAgIFdlZCBOb3YgNiAxMTozNTo0
OCAyMDE5ICswOTAwDQo+IA0KPiAgIGlvbW11L2lwbW11LXZtc2E6IENhbGN1bGF0ZSBjb250ZXh0
IHJlZ2lzdGVycycgb2Zmc2V0IGluc3RlYWQgb2YgYSBtYWNybw0KPiANCj4gICBTaW5jZSB3ZSB3
aWxsIGhhdmUgY2hhbmdlZCBtZW1vcnkgbWFwcGluZyBvZiB0aGUgSVBNTVUgaW4gdGhlIGZ1dHVy
ZSwNCj4gICB0aGlzIHBhdGNoIHVzZXMgaXBtbXVfZmVhdHVyZXMgdmFsdWVzIGluc3RlYWQgb2Yg
YSBtYWNybyB0bw0KPiAgIGNhbGN1bGF0ZSBjb250ZXh0IHJlZ2lzdGVycyBvZmZzZXQuIE5vIGJl
aGF2aW9yIGNoYW5nZS4NCj4gDQo+ICAgU2lnbmVkLW9mZi1ieTogWW9zaGloaXJvIFNoaW1vZGEg
PHlvc2hpaGlyby5zaGltb2RhLnVoQHJlbmVzYXMuY29tPg0KPiAgIFJldmlld2VkLWJ5OiBHZWVy
dCBVeXR0ZXJob2V2ZW4gPGdlZXJ0K3JlbmVzYXNAZ2xpZGVyLmJlPg0KPiAgIFJldmlld2VkLWJ5
OiBOaWtsYXMgU8O2ZGVybHVuZCA8bmlrbGFzLnNvZGVybHVuZCtyZW5lc2FzQHJhZ25hdGVjaC5z
ZT4NCj4gICBTaWduZWQtb2ZmLWJ5OiBKb2VyZyBSb2VkZWwgPGpyb2VkZWxAc3VzZS5kZT4NCj4g
DQo+ICoqKioqKioqKioNCj4gDQo+IFRoaXMgaXMgYSBwcmVyZXEgd29yayBuZWVkZWQgdG8gYWRk
IHN1cHBvcnQgZm9yIFM0IHNlcmllcyBlYXNpbHkNCj4gaW4gdGhlIGZ1dHVyZS4NCj4gDQo+IEFs
bW9zdCB0aGUgc2FtZSBjaGFuZ2UgYXMgb3JpZ2luYWwgY29tbWl0IG1ha2VzLCBidXQgd2l0aG91
dCB1cGRhdGluZw0KPiBzdHJ1Y3QgaXBtbXVfZmVhdHVyZXNfZGVmYXVsdCB3aGljaCBYZW4gZHJp
dmVyIGRvZXNuJ3QgaGF2ZSAodGhlcmUgaXMNCj4gbm8gc3VwcG9ydCBvZiBvbGQgQXJtMzIgYmFz
ZWQgR2VuMiBTb0NzKS4NCj4gDQo+IE5vIGNoYW5nZSBpbiBiZWhhdmlvci4NCj4gDQo+IFNpZ25l
ZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFt
LmNvbT4NCg0KVGhhbmsgeW91IGZvciB0aGUgcGF0Y2ghDQoNClJldmlld2VkLWJ5OiBZb3NoaWhp
cm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQoNCkJlc3QgcmVn
YXJkcywNCllvc2hpaGlybyBTaGltb2RhDQoNCg==


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:09:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:09:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246672.425394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6cC-0006VC-U6; Tue, 14 Dec 2021 12:09:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246672.425394; Tue, 14 Dec 2021 12:09:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6cC-0006V5-Qs; Tue, 14 Dec 2021 12:09:04 +0000
Received: by outflank-mailman (input) for mailman id 246672;
 Tue, 14 Dec 2021 12:09:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6ad-0003Iz-A3
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:07:27 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20701.outbound.protection.outlook.com
 [2a01:111:f403:700c::701])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 660d7a2f-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:07:26 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:07:23 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:07:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 660d7a2f-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UYU6HRAs26/rosbWFMkzwMALOLLLS1EJKqcbCuLqSD9HW7vITymu1xB3UpX4OjfUFeqyRSKwk16K3+jr+NL4V9h3W/W9cO6U+arh7vjDBKOxwe9AKAZo7FGjalWZQgYvv4uYojKx5JNS23n0QPNB/lsVQIPkhF9SwR5DLlAM1YF+crh94QfckYew/MJhzpuZr35W3kh/89lBJUlb/w4bZoFY9xg3JpQ+qLd9hwMQS/2rjFb3Lrlw/SWqf4hX5r2XxzUksdxI+lmzBMQDPncF+6J9zvy6bKUeSQ0Q75dBeHZHzkdYH777dt9z5Tm1PRf9dphoqMDSqZO0H+Fbgmh2hQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KAAonJQdAc7aQfXPD2alQm8jM9VZWLKpyhWrVw2c8AM=;
 b=EcioW0BtikiWt2GEdpM5vOKSTytkGYGLH9obCHoulMJbp5d1A55Rnro3kRZTN2iK5mq7PP1MSwSHglDa+RQiY1xNv/cF3EqzSpJqOmrBmtDP1Jua4EUm7CPtYfR8Zy1xIaiKherZhq6iJg0Rzk6LqWOntOGF91XPc9tBXt4ca/RrKIrDCzdHJVhFeCSstHANFyXPItIBCuKcjODi8HoumqQ7NxE4vR3ddxXZKbmRH39AMXeKPjcwepaS3i3KSy0cGsWACjIs5Er0mTRK9dRtHtNgnnnR7mMwnKXctE0asjXxA95RzQS52TTJFMGrjWt2v/RX0qubDcJtyXSQ5zAaQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=KAAonJQdAc7aQfXPD2alQm8jM9VZWLKpyhWrVw2c8AM=;
 b=n2ujv8bVrHOHp4G8MRo6usC2AM20CyNny8omc5W5Z5tjAiaf4gFVT2tKfucF3C1epjCOSONjXz9+A+q4ll6jK/wm/mx5HOmHAqIuqRP15FzRu8jcUCwmYnf4p4LHACMddwKZcNyDwJUgcTbzebRBhXCrjFhHB3Rjoc+XoUzHI8w=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 06/10] iommu/ipmmu-vmsa: Add utlb_offset_base
Thread-Topic: [PATCH 06/10] iommu/ipmmu-vmsa: Add utlb_offset_base
Thread-Index: AQHX47d6c2c4q5ZGtk6fn0XsGVxVaqwx+WZQ
Date: Tue, 14 Dec 2021 12:07:23 +0000
Message-ID:
 <TY2PR01MB3692B63DA7286321DD50870ED8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-7-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-7-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5482a9e-20a8-4129-2b37-08d9befa49b3
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB34361A9BC6312B3953BDEF0ED8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1122;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 pjJFx8YwcTFkzOXrRUEh3ZA2JB202OauodBTR8k+dde4QKz2FlmYRvswWOXNzJ9q1estKYSgouuggmHo6ZKheg0oYrJpa5TsNvEUTX5OiT0TjMbRpJnPBgt5tJlv1oGU/7IeY/CQk45chZT2c3/19tS47qTWkZ38Rdm6WhnkOBY5YQLQUH86V0hgfBGJ12aTNOb0OJlVeA4UZq7EJblIpeILxop/5gqlOm4a6DtTHXQBpP2rywHvq06ZzfTK5NRRF7MTMb4fv0wsrO3uNr18B0mObkqdZlz16cMVni6R71mMsBEDqBM1Vvf8arPp39nNJe+jgSee1HHFS/sw+Tg1gDlSgNghOrJZmxst8K2DfHnZ+7yrlNOy4X3NL8aVKKkNSx2xJj5hOGx9/Rs5DtbU3Vr10xIjRQ6Q0NVEzZv3V3XSut0vTIHhVvH58o3wF6A5CbiHhVcNoaJlaNN0UO1dVO4KeaJz6qFgU8kV7iEXJEBYKluG5dYzFrZ/plOU8vRRelm5w2xHlTJF5o3g480pjd74prUmIB9Oooi0o7zd71VnT0EpEJ2N27w1hg3iAnPoFfrgAhfEktXYm2uJvsuOhXrVwt/QC3AgNj1pNWd5i0rZYu1U3oaYEIIXB5TEsFOYiMRkfGcDkDBrhvP09s2nEH0+iOKxpE/hZYxvXlT1GUsUcPtIfYIAwMvYoJEPkID3jLBw1KEY0zeqD/FdTsBfVQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(66574015)(54906003)(83380400001)(110136005)(6506007)(38100700002)(508600001)(186003)(8676002)(5660300002)(55016003)(64756008)(71200400001)(66476007)(66556008)(66946007)(38070700005)(76116006)(66446008)(122000001)(52536014)(4326008)(86362001)(7696005)(2906002)(8936002)(33656002)(26005)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?utf-8?B?eXN5L1lsVnRnSTlzTmt4ZjluRVJaL2FBNmNkSzBMYnNQVzNKeWhTUFpRZnk0?=
 =?utf-8?B?TC81V3FFWjBJQUlEY3RUKzIySGNWWmZoSGxQT1FpdGozTVZWckQ4c2cxWmkx?=
 =?utf-8?B?aEo5ZEtiTldwdVpKOE5HRGhkVnF0Rjg1TDdWMHZOS1UweU0wK3o5T0xMajF1?=
 =?utf-8?B?SGpRQWNVWkwrTCs5QjI1VmFxWklKU1Q1cmNyejNLdG1pK3JSMkx3ZWNYQWlJ?=
 =?utf-8?B?UVRjTUJlYlJHakd0cXBnL0JGNi81ZngxUC8rK3VLTFBlWXFWN1pJTlVqS1RZ?=
 =?utf-8?B?R2VZMXIzTndkSU1YWDh1citmc1g1bUh4dXdGTGJKNjRhdUxoeXp4YStnNzhw?=
 =?utf-8?B?Smx0cXdXSmdob0ptSjJscTNwcDFVb1ozRnE3cERSVVllRjJaSzVDUE5lRVp2?=
 =?utf-8?B?MUsvd2Z6cFFJYm5pZEt4OUlIRWc5a21VZEsvQzBDRWtUWUUvTjMrbUZDUjdB?=
 =?utf-8?B?L3VTYWYyNE9XZHN1VWRrRjh4TVh1eGVxc1BHMmNzSjJJQUsvWEhOT1hvVG56?=
 =?utf-8?B?Tm1BbUZQOVdNNm1YUlhIMlcvTEpla1VPTzl4WGhFNDRkUFpyRm5zK1Z5YThr?=
 =?utf-8?B?OUtzMGk1TW1sMWxyZ0UxSS93eGw0RHhWOXFHODFyazk5WDlnMXZKTmJBU1g5?=
 =?utf-8?B?UHdXT3cyYUpLVjJONkw1Sk0yN2x5U1N1OGZhTnRTM0N5MExGcXM3R1pqZHMv?=
 =?utf-8?B?VW1PaUZqOE15b0d0WkNGQldMY1dGRDZWdUZYUENtTFQ5VU9ndmNrK3lmVTE3?=
 =?utf-8?B?cmFTUUllcWtXZHlJR1pMUHZYN1FNMm9IaXdyNGxJcDdxaG5QbGVjb0FpeU42?=
 =?utf-8?B?SzIrdVFvbCsyQnNyRFZRcHVrYWJZbXN3azdNa2lpS1RkQVM2U0VXWFAxRU1R?=
 =?utf-8?B?WkhlZDBWKzJNVW0ya1Jxc2JlM3g3VWVrcEUwK1hjWWpzVEN5ck1CdFVKOUda?=
 =?utf-8?B?aitBUk1SSGtqTklDNXNhTHBqcHdUSC9yd0RCMFVwdVRyRHMzRElDbGgvaXlB?=
 =?utf-8?B?c1M0Rk5sTFVHdEMvcmFLUVFYSFJaUUFyVU5OdDFnZDV2NEJjWUEwUkFIWGRI?=
 =?utf-8?B?d29Ld3lsTTJOUkNPOC82Skplek5tcTBYR2kyRFdhdDJXVVNFVHNsbW9vSVcz?=
 =?utf-8?B?Y0lhU2NCc2NFWExCMWNVVkszUlQ3bFZQTGo1czl2c1RNTmI0MGJPa1Bvd2xN?=
 =?utf-8?B?cUxaVGc2dGFZMmJQbWtSb1RYZGxrVjd6ZVE4bVB4cENWY2JOVWhIY2ZDTklm?=
 =?utf-8?B?K2RDcllPWlRabGdtSC91QVZ4emMrNW83U1JYRndnMkl5WnNNN0FlLzFxZ1JX?=
 =?utf-8?B?d2VuWFVjYlNCRTJGMEJabW1yZ0JRQ3QzL3dETit4YTJqVjdFZlRIakt5cVFL?=
 =?utf-8?B?Y3lkQ282Rkh5M1lMTm5pY2txS1dUQ0JPdEZFYUVrWFBHYmdIYVQ0YkdXcDFS?=
 =?utf-8?B?VHJjbE01NnUwaEhWVk0yYUJWMmFZdnlxQ2dUSXQvWEcva1J6S0Q2eTk1ZWZl?=
 =?utf-8?B?YjByUmg3d1FuQWFHRmdwTE1OMGFRMjA5VnVkejFISFBYWkhkVVh3UndZaEdR?=
 =?utf-8?B?TWNtNFREOEZJYWo0L3RzWllHZVRIRUk5ZGRhLzQyV1AyRW5FaDJDMTFwSTR3?=
 =?utf-8?B?UWhzMlNqbkJCQ3VJTUllc3luZlp6WDM2anNtYTJMeEo3QUM5M2kzODZqeGtQ?=
 =?utf-8?B?VmozV0I1L1NmYVYzTHY4OWdkZ1E3Uld2T2pReVlEU1ppWGtidUpHajVmemFE?=
 =?utf-8?B?anRjMnhBYlhnZW9rYWY2ekh6RVg4NkVLcDQ0c2lKK2xrV05JOGJoaGdtbzF0?=
 =?utf-8?B?VWVCQ3FORk9zcDJQYnp3TTRLWU9hN1JsUU9pcDhCY3ViZGRIL1gyOG9rdnFH?=
 =?utf-8?B?VWlSQUN4Smo4STFkYlI5Tlpubm9Ea3V4SlFPYnIxd1IyZE4wNVdJVENQNS9M?=
 =?utf-8?B?SVRhenVUZDRRTW1nd0hUQmk0VXFJREtIVzFNS21NRmdKRitRcUlabUJWR3Rp?=
 =?utf-8?B?cnIxYVNiTm1OWlVDK3N6aXNrRlRlMEdtQ1NGdUpRNDBHeXNENU1XL3p1Q0FB?=
 =?utf-8?B?Z2l4MmhkckM1dDE5L0ZHTlhCbFBOZjZCak8ySjBjWGJqa0NydjFDSm5vNlpm?=
 =?utf-8?B?Z2VPaEtSUWpyU1h6cXI3Z3Y4RmNuNU1xNTBRQyt5WkdVL2JPSkVnY1RSVGwy?=
 =?utf-8?B?L1BCa3BsaW82WXY4M0lEdkE5U3duZ1UxSFE1aDRwVVB4NnB0RmpFOE11d1Iz?=
 =?utf-8?B?RFY3V1pFWGJyQ29RdFNTZEhxZFZNby9wNXFWMWhTc3FUOHhiY2FMSEs4S2Q1?=
 =?utf-8?B?cWkvTTdLN0lLbUE5K3JmRnNWRnVINzhmL1Q3MnpWS08zNVlERExnUT09?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5482a9e-20a8-4129-2b37-08d9befa49b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:07:23.6786
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NtFe+Xhp6ImsYnzPwd4sMLDoiq3oh2a2MZTdsYbpzVlL4vpLaUgwt623kcEciW9SxqrWUtMIxsUFAIuL0O6cLH0SRv3uvET8NmhLginOXsnZTfBefHJSwKWeKIh8+o49
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

SGVsbG8gT2xla3NhbmRyLXNhbiwNCg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbywgU2Vu
dDogU3VuZGF5LCBOb3ZlbWJlciAyOCwgMjAyMSAyOjUyIEFNDQo+IA0KPiBGcm9tOiBPbGVrc2Fu
ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+IA0KPiBUaGlz
IGlzIGEgbm9uLXZlcmJhdGltIHBvcnQgb2YgY29ycmVzcG9uZGluZyBMaW51eCB1cHN0ZWFtIGNv
bW1pdDoNCj4gMTI4OWY3ZjE1MDAxYzdlZDM2YmU2ZDIzY2IxNDVjMWQ1ZmVhY2RjOA0KPiANCj4g
T3JpZ2luYWwgY29tbWl0IG1lc3NhZ2U6DQo+ICBjb21taXQgMTI4OWY3ZjE1MDAxYzdlZDM2YmU2
ZDIzY2IxNDVjMWQ1ZmVhY2RjOA0KPiAgQXV0aG9yOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGlo
aXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+DQo+ICBEYXRlOiAgIFdlZCBOb3YgNiAxMTozNTo1
MCAyMDE5ICswOTAwDQo+IA0KPiAgIGlvbW11L2lwbW11LXZtc2E6IEFkZCB1dGxiX29mZnNldF9i
YXNlDQo+IA0KPiAgIFNpbmNlIHdlIHdpbGwgaGF2ZSBjaGFuZ2VkIG1lbW9yeSBtYXBwaW5nIG9m
IHRoZSBJUE1NVSBpbiB0aGUgZnV0dXJlLA0KPiAgIHRoaXMgcGF0Y2ggYWRkcyBhIHV0bGJfb2Zm
c2V0X2Jhc2UgaW50byBzdHJ1Y3QgaXBtbXVfZmVhdHVyZXMNCj4gICBmb3IgSU1VQ1RSIGFuZCBJ
TVVBU0lEIHJlZ2lzdGVycy4gTm8gYmVoYXZpb3IgY2hhbmdlLg0KPiANCj4gICBTaWduZWQtb2Zm
LWJ5OiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1vZGEudWhAcmVuZXNhcy5jb20+
DQo+ICAgUmV2aWV3ZWQtYnk6IE5pa2xhcyBTw7ZkZXJsdW5kIDxuaWtsYXMuc29kZXJsdW5kK3Jl
bmVzYXNAcmFnbmF0ZWNoLnNlPg0KPiAgIFNpZ25lZC1vZmYtYnk6IEpvZXJnIFJvZWRlbCA8anJv
ZWRlbEBzdXNlLmRlPg0KPiANCj4gKioqKioqKioqKg0KPiANCj4gVGhpcyBpcyBhIHByZXJlcSB3
b3JrIG5lZWRlZCB0byBhZGQgc3VwcG9ydCBmb3IgUzQgc2VyaWVzIGVhc2lseQ0KPiBpbiB0aGUg
ZnV0dXJlLg0KPiANCj4gQWxtb3N0IHRoZSBzYW1lIGNoYW5nZSBhcyBvcmlnaW5hbCBjb21taXQg
bWFrZXMsIGJ1dCB3aXRob3V0IHVwZGF0aW5nDQo+IHN0cnVjdCBpcG1tdV9mZWF0dXJlc19kZWZh
dWx0IHdoaWNoIFhlbiBkcml2ZXIgZG9lc24ndCBoYXZlICh0aGVyZSBpcw0KPiBubyBzdXBwb3J0
IG9mIG9sZCBBcm0zMiBiYXNlZCBHZW4yIFNvQ3MpLg0KPiANCj4gTm8gY2hhbmdlIGluIGJlaGF2
aW9yLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5k
cl90eXNoY2hlbmtvQGVwYW0uY29tPg0KDQpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaCENCg0KUmV2
aWV3ZWQtYnk6IFlvc2hpaGlybyBTaGltb2RhIDx5b3NoaWhpcm8uc2hpbW9kYS51aEByZW5lc2Fz
LmNvbT4NCg0KQmVzdCByZWdhcmRzLA0KWW9zaGloaXJvIFNoaW1vZGENCg0K


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:10:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:10:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246679.425405 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6dW-0007rx-Cx; Tue, 14 Dec 2021 12:10:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246679.425405; Tue, 14 Dec 2021 12:10:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6dW-0007rq-92; Tue, 14 Dec 2021 12:10:26 +0000
Received: by outflank-mailman (input) for mailman id 246679;
 Tue, 14 Dec 2021 12:10:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=jWHN=Q7=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mx6dU-0007rZ-Bd
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:10:24 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on2072f.outbound.protection.outlook.com
 [2a01:111:f403:700c::72f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d0697a37-5cd6-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:10:23 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB3436.jpnprd01.prod.outlook.com (2603:1096:404:d7::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 12:10:19 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 12:10:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d0697a37-5cd6-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kklKdxGrR/xCu6BFPjEvEtFLUrExvC38rU7E1tQLCjeVGrUJmVLVQd4P4ByBd+mLj/zdkW6W/npoFpCBALmymYcTwSDsKdd/ncbDWlKNcvIOEoDbfBEkFu3xFvz+kDjwVPCGPrWo/Z04r26ItyLwGOG3Md7nl0uRQFVL1/JAjBMindEVp2zkEfeIK9v1QAZZvKu/8x9656Lvn/LvTMpDeMTAf3/pmcrD0swVT+cRm21mU+RHpKcl1cnJkTjFmse6Z7kUyeceECCMxkMN3PXceoH6OZ3+tY6OdeksTyO5QhPhJV3S3DzZzWSEPennBwK05lcLSI8h2l6TXHGcIrk+Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hhKJ0r7Rd+YA5xfqq6WK9bWNw2l9thUfp+oHM3bRvaw=;
 b=eurSncho5h66VNL3v2OnHMgoUvWaMvRNLZ9ERgNIeKy92zHxb4o2X/kF1vnagnlYROOJKQm7762tb2lM1utoLW+CZBHFoceU9WZ9w4Q6A/eMlzi6TIua/SngElAk9DnffGLh0kID41520dv9oj+OwoJbffWGponPNXneVegrFa4ep16ZMSWS85ieFRcISwZ54zK6XQ7MX7WuoYYglyNHhFhnAVycEJW70awO6GOc35x98VYkqlXaXFTLw4xSs5zd2SPgZfUwpNQZqESs5LTqK8ePT2ym19rRPmr24AxzNYubDgtLjm6R1BBFJ+9WCSHlOQPDJLXtQh3d4uBcXQKsbQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hhKJ0r7Rd+YA5xfqq6WK9bWNw2l9thUfp+oHM3bRvaw=;
 b=gIkgD4pa9jxQ8B8mDe8Sw1POi979AQA9phBtt2jlILv/TQNnuVU7AZipUr5NvC6DUuzw3TtkzEBUbpV2NnjgbdzVSje6E4cbMDAxiAf3qT/7NPFESENP8II8+8wzRnWUojoXY49sOJqxpg6GCM8p9ed0jADoFwr/xEMSHnnaW7o=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Jan Beulich
	<jbeulich@suse.com>, Paul Durrant <paul@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: RE: [PATCH 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4)
 support
Thread-Topic: [PATCH 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4)
 support
Thread-Index: AQHX47d8fbMLgxHqOUqKrUFepan2+Kwx+dWw
Date: Tue, 14 Dec 2021 12:10:19 +0000
Message-ID:
 <TY2PR01MB36922C89869ADAAF34A75F35D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-8-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-8-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 053f85eb-a995-4402-1593-08d9befab29c
x-ms-traffictypediagnostic: TY2PR01MB3436:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB3436A28DEAE87B45ECE420D6D8759@TY2PR01MB3436.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Se5YEEwEkllTPo778YAiJiyQNvOzawUBHBwWT4m9JN+bfyBrnrxoSeCtIgdLV6r0rERRk4swpa+j8+aRWMK8qIGo+hSNRmB47z09CbR4R9BIq4FeNkfvaiZCKGMsq7sDgQB+6Ha5ub2JPkKmhOCiyifxLWZ5Aiod4dtaoq7fIZngJO5GPm/dp0qiOyfWmtHQJqm0J6ppF/YVEtqcgN5Dz1n+bXNhZ19Jspqm3Pc7Td7ndZS/T9TpwB3+AziWpRjB9+Mq0Lxh7YjyCiy37JyrS0xN4UaTE2K9Dr8ttqQ3OmcBCU6hEADXjDsfkLMEhIE4eBFGTYywarEn0UEP/pP6AnSneQVPp9+eF3JFzzVjtkDpjfucwmvOLaFqkBymi8gIMFsSYKTScW6dK9HTS/vwSzKkxtP9LHZFVRcDOz67teq1Ws34kTaFFcBNkCileeJ1weL4TM5+/wIf/qrdJufdXkpXFvKK8We3ryP8opFtv5cdpLTqyCnfTLa92rpkmKA2M0fj05gWqfL3LxDbwdi29Y5krWVh1AhUjlEkNdtPrTuB7T0YZxCrrvZz3H+pAamJiLAL3FIH8afOJaUgPYnE4CfryaKcmr0u0MRnbuBWCsaQthoNM/zAlasdXOyci0R2k/DRGgUxLRcxUx85dqBL8wDMA+tFJ11Zq8dw0R0QV6hQUDgaWfb8kluqInWdkXQFSjg9wUcDZGzkKuSgPycZXomON/Vk6dN6Li5wTP1cKdpzPF/JKuV0oTi78yt3q8hTNAFcwacKY+r0CPCnXIIVCn9uanZrgY7TGZeOtBAw4kqDf++wkNdnFoJ9qLzxVM33DgtPLZ9+y9SkNnAUI1HbJg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(54906003)(110136005)(6506007)(38100700002)(508600001)(186003)(8676002)(5660300002)(55016003)(64756008)(71200400001)(66476007)(66556008)(66946007)(38070700005)(76116006)(66446008)(7416002)(122000001)(52536014)(4326008)(86362001)(7696005)(4744005)(2906002)(8936002)(966005)(33656002)(26005)(9686003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?tKO5+fKtU1R0A7nlMyzz6SYjsLH1uBTC7UkK7Jb45kNj/hZtJwVmHc1dBBX1?=
 =?us-ascii?Q?I+nstpnLjHZjGA8II2HSirvHeM6I3EEhvI9n5yFiBIRlJHnC6U50pYp+wNqs?=
 =?us-ascii?Q?xs6hZQWbacj/kmwk4wTQOmOwSi6mJV8eLREk1zcQp0pCX7rm9Dz7iMol+S/P?=
 =?us-ascii?Q?tb0rFogjgCv19vmfSx3cjYG5iv2MU3WJqq3FYB4fsMdAZUcmdRtat8hKdAmi?=
 =?us-ascii?Q?CVFu9MU0G/XwpDM3+Kw5mCQwmDQzwLEYNnoErhBoZztwmzvazzPbIGGvbHYI?=
 =?us-ascii?Q?2vuRJ4PeIuRFlTnv33qXdeMW5p+umXGDF/7PibdsUYEXSCivkOdEH4CvQPBQ?=
 =?us-ascii?Q?JC9njCMKfV9UXJ2sOWVd8KOzj3pGNEC9QHmIsS5rz82Kiye2veNjkeSdM32o?=
 =?us-ascii?Q?lLbaXn+ASv+GTHtXP51/wYmRST9oIM6L1ZPl+saynAATddcWjSzGDwpvvDhk?=
 =?us-ascii?Q?CLCMrNhyHzVXwUCy7SuGsAxjy9tRYuCGUMnTmfUmEcbmUM8EMyH1ARFufW9l?=
 =?us-ascii?Q?vW39nCAbHDD54stghVMewl7E6R+gSNLyQRIMyz7a95HIeAWSQyFFmU/ngVMi?=
 =?us-ascii?Q?weJyPkPXwltMAZLNSATrNOsqy/uf/8JoW4DiQXIpbs2SEw6SafF+XAIje9io?=
 =?us-ascii?Q?UVJqLFLSAylgR2qBDaoEui5Nx+iWiMEf7SjGXTTnDOKaQL1tq4um9WIzUEuZ?=
 =?us-ascii?Q?hwfWz2yc/mmF4720R8Tv8jXxDkqA7ctfmmJiFvlEYYfBHnTEmzIvawJNWv0h?=
 =?us-ascii?Q?dhZIyMW0cJ34pKDNLFxFecHGAQiqDxdK8fCdAC8h/AV7tOuDC5snYHry19Qi?=
 =?us-ascii?Q?xqD9rHi124lOX1WcMPSmxx34nmtiVuTmQnL8R4O+QnlfPV236wRisquB3PaA?=
 =?us-ascii?Q?CFbPZ04Sk56qLUkbWf6KKz9QRMVvfKyvO4fhfLPCQaX001svYF6g5WIav1e7?=
 =?us-ascii?Q?TlUR4o0BI9Kyi7TO8nYJytVD+XKAexmJJcoZaF1FfHR3tcveMRKAxwUG8d5p?=
 =?us-ascii?Q?cPGlqJp5tzHgMgl6N2vfW81F/CRFoKhn/AGK6jWso0SviWWJ8mo3uu1Dcabm?=
 =?us-ascii?Q?ClZF1k+3xON1dcGJE1rLJo59xOK1hdzzfYCk8cOMpLm7hjnR1Pl3cx6wWWn4?=
 =?us-ascii?Q?WeFNilSOCLq3JnZbx7O+WkGlw2ibW1RCN0xqvITqxviMttJNyV6ByFIsjMmh?=
 =?us-ascii?Q?R4Gfom/AOp7jx9QqkFA/ldTkRiONbB7eOHsnjB2WRltVDrb6L/CWt+MqW4WQ?=
 =?us-ascii?Q?hx04IYGHEM1RrNGKz1+atn49nBzzah6DQI7pjHbY8EnN72AmM6bsRQ8pLRjc?=
 =?us-ascii?Q?2u5UyIyf6QGgZK555uYoQ7ZLyaumf0eAHvQl46qd9esb2s2gfV5gj6ueq67m?=
 =?us-ascii?Q?JKwTNbxuzgS2VTZyi8DAuffwtERukHMCuMrNsw0Q2ybyhP4FQNjYK/fvBL4e?=
 =?us-ascii?Q?SMgcPl8CdSbIWF+86E9jOHVZY0VAnOi+H1SdTPJgdhC6SSx499hgXQmT6dXp?=
 =?us-ascii?Q?KNxSsN4DZLFn/wrXFn0Akaof2i4k/t15DU5HBZi5uVRXKOsQE9dOnJ3IB/rM?=
 =?us-ascii?Q?OAmL60VDovb2+948OmIWVqgeFs6gBpxW/s620PH8L2esY5K7ovoGuQD9oY3u?=
 =?us-ascii?Q?1I67f5SMD9ya67+Kqh1Q96fSbsElMSRt3WjT7Cyuzl6i4BNByrIVe8/rFl3g?=
 =?us-ascii?Q?bPG0bjpbs2Vi/dwJFZ3fj8Th1Rw9KX/HH3KbXeTTS56zAbjiAoge9YW1ctAv?=
 =?us-ascii?Q?fHyJ4K2cdg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 053f85eb-a995-4402-1593-08d9befab29c
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 12:10:19.6891
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /M7NuwcRaTrBRXObsGesU5HUvdYOjoeD2KBKz6wM+aTalaGwWxfuT0PTI63Lh6TZJOGBuVDo1jyYGWFDfObWfNYvNDyCBKOZvvMKZcBLKQm8gbzGWlHEXg0J8amKnyXq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3436

Hello Oleksandr-san,

Thank you for the patch!

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Based on the following commit from the Renesas BSP:
> 7003b9f732cffdc778fceb4bffb05ebb4540f726
> located at:
> https://github.com/renesas-rcar/linux-bsp/tree/v5.10.41/rcar-5.1.3.rc5

I would like to reuse an upstream-based patch instead of this BSP patch.
Linux upstream doesn't support the IPMMU-VMSA driver for R-Car S4 yet,
but I believe the following patch can be helpful for R-Car S4:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/d=
rivers/iommu/ipmmu-vmsa.c?h=3Dv5.16-rc1&id=3D7a62ced8ebd0e1b692c9dc4781a8d4=
ddb0f74792
I have a plan to modify the Linux IPMMU-VMSA driver for R-Car S4 in the fut=
ure.
- The ipmmu_features_r8a779a0 is replaced with ipmmu_features_rcar_gen4.

I'll review further patches (8/10 through 10/10) tomorrow or later.

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:10:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:10:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246681.425416 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6dj-0008H3-KC; Tue, 14 Dec 2021 12:10:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246681.425416; Tue, 14 Dec 2021 12:10:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6dj-0008Gw-H5; Tue, 14 Dec 2021 12:10:39 +0000
Received: by outflank-mailman (input) for mailman id 246681;
 Tue, 14 Dec 2021 12:10:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6di-0008ED-JZ; Tue, 14 Dec 2021 12:10:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6di-0007D9-Bq; Tue, 14 Dec 2021 12:10:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6dh-0007k6-Se; Tue, 14 Dec 2021 12:10:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6dh-0003Qx-S7; Tue, 14 Dec 2021 12:10:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Scw9f1roNrNNIXQZnPSEoaWMMTPz1H+9EP/8J2xFqz0=; b=q5u+2r9vumhXjcU+zpUg4ry4aI
	AIf/ObrDM2MjYcC7f4hm+nTz1lMEpj1qIbnQACtjLxwsn3aANuo/vvMAbzV/Iu4PvG9ktzsTx5Je1
	J3r5Br3NnJB0b6PVgWOsj7c4uhyGt4PmVWBh/BIBP8zVKKhDn/dPdnj4Mj6pmVcfM11Y=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167402-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167402: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:regression
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 12:10:37 +0000

flight 167402 xen-unstable real [real]
flight 167408 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167402/
http://logs.test-lab.xenproject.org/osstest/logs/167408/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail REGR. vs. 167387

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 18 guest-localmigrate fail in 167408 pass in 167402
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 18 guest-localmigrate/x10 fail pass in 167408-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167408-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167387
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167387
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167387
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167387
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167387
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167387
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167387
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167387
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167387
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167387
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167387
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167387
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167387
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167387  2021-12-13 01:52:51 Z    1 days
Testing same since   167402  2021-12-14 00:36:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit d828caa9aeee80c59a35f662f875f6573e9b532f
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Dec 13 17:50:48 2021 +0000

    tools/libfsimage: Fix SONAME
    
    This gets missed on each release.  Follow the same example as libs.mk and pick
    the version up dynamically.
    
    Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
    Suggested-by: Anthony PERARD <anthony.perard@citrix.com>
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Anthony PERARD <anthony.perard@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:14:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:14:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246693.425429 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6h9-0000mB-8j; Tue, 14 Dec 2021 12:14:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246693.425429; Tue, 14 Dec 2021 12:14:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6h9-0000m4-5u; Tue, 14 Dec 2021 12:14:11 +0000
Received: by outflank-mailman (input) for mailman id 246693;
 Tue, 14 Dec 2021 12:14:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6h7-0000lu-HE; Tue, 14 Dec 2021 12:14:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6h7-0007HK-7n; Tue, 14 Dec 2021 12:14:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6h6-0007pN-SG; Tue, 14 Dec 2021 12:14:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mx6h6-0005NM-Rq; Tue, 14 Dec 2021 12:14:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=oF9+Oq50nsXPcvAkWqCOUg3dERn4Iff9Lq60fwF6+KY=; b=K53iBD394+H3rdakv43K44BMun
	BGC62atO/119f4rYW/JF3uLUsHH1xE931KW3uFCjZF6jhhuYsI2W/iHrh/BbWSTcG4O1zvBGcQGkm
	/J2JdDzlb2sWuFgqVoU+z3S0kudQj1BljpPEvIYYf7C4hpinamlEysLz7G+vWKrMfSGk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167407-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167407: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1382241fe880d48e109f2056cec052bb3919a9d1
X-Osstest-Versions-That:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 12:14:08 +0000

flight 167407 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167407/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1382241fe880d48e109f2056cec052bb3919a9d1
baseline version:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f

Last test of basis   167400  2021-12-13 20:00:36 Z    0 days
Testing same since   167407  2021-12-14 09:02:57 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d828caa9ae..1382241fe8  1382241fe880d48e109f2056cec052bb3919a9d1 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:18:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:18:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246700.425447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6ki-0001Qu-Qx; Tue, 14 Dec 2021 12:17:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246700.425447; Tue, 14 Dec 2021 12:17:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx6ki-0001Qn-Nv; Tue, 14 Dec 2021 12:17:52 +0000
Received: by outflank-mailman (input) for mailman id 246700;
 Tue, 14 Dec 2021 12:17:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pz9/=Q7=linutronix.de=bigeasy@srs-se1.protection.inumbo.net>)
 id 1mx6kh-0001Qg-Mf
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:17:51 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 004c6a35-5cd7-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 13:11:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 004c6a35-5cd7-11ec-85d3-df6b77346a89
Date: Tue, 14 Dec 2021 13:17:47 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639484269;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5EjK9U4c1B2UMzOdb/VrmnUd2kGnJXX71T0l2vaNMvw=;
	b=LFK+C3/7skCLlAKeYual5QNG0cjYG8e40f7TSY4MQqfma/UQ6d67wFxp39AR88lvO6nePR
	uhIdror80ph6fl02ir+ouKap1Hd1kz2bMADADJoY6PsTyu4+kU3FplepMkdGvK3qkXxqNT
	tI3GVA5NH04Gtx6TlpfCcMKQmyjUClmA2jz5tFDeaMGotkSsNlkrABbE3cMeZxaphrP9nI
	wRS44pc63FwetZVhkg2U2AYJOaOJmd9mm4rVm406sRAGsN/ooXy47H2AnhrOEKxMYLFvVb
	4y6n1ZWibQT/Ol1h5qLWCHj2AAq8DyPA9vjubBln43hM6sEiWGYE8+gyrJ26UQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639484269;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=5EjK9U4c1B2UMzOdb/VrmnUd2kGnJXX71T0l2vaNMvw=;
	b=rJpgtcmrZni7owWFcBoJFviG+yZFYbPz0kQR2t++AUzw4JSTKMPNOiAow/U3ui0/V0TFgc
	gHq6c2V421H3vDAQ==
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
	xen-devel@lists.xenproject.org
Cc: Thomas Gleixner <tglx@linutronix.de>, Longpeng <longpeng2@huawei.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/2 v2] cpu/hotplug: Allow the CPU in CPU_UP_PREPARE
 state to be brought up again.
Message-ID: <YbiLa2nK3pYruDSK@linutronix.de>
References: <20211206152034.2150770-1-bigeasy@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211206152034.2150770-1-bigeasy@linutronix.de>

On 2021-12-06 16:20:32 [+0100], To linux-kernel@vger.kernel.org wrote:
> This is a repost of the previous patch (#2) and adding Boris
> (Ostrovsky)'s suggestion regarding the XEN bits.
> The previous post can be found at
>    https://lore.kernel.org/all/20211122154714.xaoxok3fpk5bgznz@linutronix.de/

ping.

Sebastian


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:37:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:37:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246705.425457 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx73W-00042E-Ez; Tue, 14 Dec 2021 12:37:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246705.425457; Tue, 14 Dec 2021 12:37:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx73W-000427-C4; Tue, 14 Dec 2021 12:37:18 +0000
Received: by outflank-mailman (input) for mailman id 246705;
 Tue, 14 Dec 2021 12:37:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx73U-000421-Fq
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:37:16 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f5a6161-5cda-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:37:14 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f5a6161-5cda-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639485433;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=e7iNh7eKzfNaD6+64EUknrfrSEZzZMdaO3S7Tsc7IiQ=;
  b=XgLHSNmAPlGxlZqNN8d5UzNqfQtjF+a5IsHsiYS/HermBpu29//KlgxA
   2lkesJEFpQVwpWQ2v9W8H0zLro3irdGkm3BZ1j+LXbODCA1/cXGEBhoU8
   qGkpsjdv7Y0+Eeu4/FNf1oigrXwvwYNnxHqMYKMHzSnJqg6Fsc/FkqHWF
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: AxMu/z/fZ7kusg/ALSFxAa6uTJerixq4i/eXHhI2kEQIo7ntsRm4ulwnN3nOVfDN+xsI7ZxtN/
 uERKE0euIIlPQKtWOvh1JgTfaric7WUxyqpzsA7NqFmEE3S7pDgyuEJhaBZuh7n51wy+ImWgSg
 lkVzez4CedheVbjfGXoSwl+OTj+9gCQgktAUKbvdr+agZDQxlvv+flDN0sO3eeqh/quin6k8Jc
 9XRn/VAf16w6rnhlUtq4909TzGPvssOyc+gF2tZUfKINuf/u6HqpjmsO7EcQI4SBfGjzZ+1Ex5
 zp0goOyvxFS2fcwPvdH2Dngl
X-SBRS: 5.1
X-MesageID: 59971315
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Dz57Z6CKRxeARBVW/53kw5YqxClBgxIJ4kV8jS/XYbTApD0h1TNUm
 jYYXTuCOPaMMGbxc9BybNi0pkMG65eGmNRmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX570E47wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/myekuf0g9
 pJ0tMaQazokHrHvxPUYXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHvSbuoYDhWpYasZmIK3mI
 OUobj9VUC/Pfj9JPgkTOMgApbL97pX4W2IB8w/EzUYt2EDMyCRh3b6rN8DaEvSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCglee22gSAx0+TkagrL+yjUvWc8hWK
 1EQvDEvq6cy3EWxS5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceTzEwy
 kWAmd+vADV1qaCUUlqU7LLSpjS3URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDoalnPDTNGDOh
 AmL9ggcurgzke1XxqC0qAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bct/HEwDpU
 Gws3pHHsbtQVc3leDmlGb1VRNmUC+C53CowaLKFN70o7HyT9nGqZui8CxkudR4yYq7oldIEC
 XI/WD+9BrcPbBNGjoctOupd7vjGK4C6SrwJsdiOMbJzjmBZLlPvwc2XTRf4M5rRuEYti7ojH
 pyQbNyhC30XYYw+kmHnG71EieJ1mXFurY82eXwd5074uVZ5TCTKIYrpzXPUNrxphE96iFu9H
 ylj2zuilEwEDbyWjtj/+o8PN1EaRUXX9ritw/G7gtWre1I8cEl4Uqe56ep4J+RNwvUN/s+Vr
 yrVchIJlzLCaYjvdFzihoZLM+i0A/6SbBsTYEQRALpf8yR5PNv0sv5AL8BfkHtO3LUL8MOYh
 sItIq2oKv9OVi7G63Iaa5z8p5ZlbxOlmUSFOC/NXdT1V8IIq9Xh9oC2cw3x2jMJCybr58Iyr
 6f5jlHQQIYZRhQkB8HTMar9w1S0tHkbueRzQ0qXfYUDJBSyqNBne37rk/s6A8AQMhGflDGU4
 BmbXEUDru7Xro5rrNSQ3fKYr52kGvdVF1ZBGzWJ9q6/MCTXpzLxwYJJXOuSUyraUWf4pPera
 elPlqmuO/wbhlda9YF7Fu8zn6454tLuoZ5czxhlQyqXPwj6VOs4LyDfj8dVt6BLyrtIgieMW
 xqCqotAJLGEGML5C1pNdgArWfuOiKMPkT7I4PVrfEijvH1r/KCKWFl5NgWXjHAPN6N8NY4oz
 LtzuMMS7ADj2BMmPszf03JR/mWIaHcBT78mptcRB4qy0lgnzVRLYJr9DC7q4c7QN4UQYxdye
 jLE1rDfg7l8x1bZdythHHfA6uNRmJAStU0Y11QFPVmIxoLIi/JfMMe9KtjrotC5Fil67t8=
IronPort-HdrOrdr: A9a23:x7aT/KuVV3Rja79QikAsf3t27skCkoMji2hC6mlwRA09TyXGra
 6TdaUguiMc1gx8ZJhBo7C90KnpewK7yXdQ2/htAV7CZnidhILMFuBfBOTZsljd8kHFh4pgPO
 JbAtRD4b7LfClHZKTBkXGF+r8bqbHtms3Y5pa9854ud3AQV0gJ1XYGNu/xKDwOeOApP+tfKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59971315"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pu6ybrB+FMDIqqYokNtO68BVeCA2+OcSFnNww7I2wCWnaycM+frSqyUqthUFG79yFf1dQYfI7ohytj356mSqW/sk3zoOh4/gSO6Jaa9o3c+TB4sfHhOgw7ZGjfbX0DZt44peaOmytsdPlnExypN+w5wue6C+zcWQs7UpBidSj+4dLCQQ3Bmd8k/BC/f3INRl0tt7Zt8011/pr5k6MZt4lbJRo46DvT3mifjfmU/FYU0bnNM8ezq8t5Ll7C0oDg5gd3s/flm/MdmmzZnifBGz63iYcJJRqwSc9eahoCx0M5K2Fpj7sRQCHZWXgQJ9RplBaoAdPrCQaVdTanh8MCE7/w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=zrNzOh9nt6fBFtn7oM9cS0cwQi8xHYmKQRXAU7mIWSE=;
 b=iZaCshPwdJI9Zg+Ii9BwAa1WuPKn9OrIGxHGC+kHTd3Qdx/vHwdRiOuQmRSJPGJqufxzsPOT3Fxo6adYB6fZWvg3s09I56WyH8iAyEbXWDMx12KcbbJoUPDhDGlcsq+rSwJXLnx0qt+w4POHkwvJ1F2hjhwVFjjXUpYChjFKr8YOo3PcDplmfkRz1CVm/ZtAOnPf/t4iDZ+QUDTYV+AFnt/uxrMNjxvnucIXUXjMFO5w2iuKh6yiPh7s4+qJuijM4SKasP7hlKuT2U2ZQlWh9MJUHQtDxqZq9A2byEyiA695k5Ip/SARjwGOkRQ5SMe16fxiwInwgHk/kCDB9EN35w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zrNzOh9nt6fBFtn7oM9cS0cwQi8xHYmKQRXAU7mIWSE=;
 b=U5k5zU73JzKbQJR97InMu3zOy513CI+8X3kmPSymy9IhHNocqIqOq2Cz7WB8TCdE5H5R2daap1m1ph4YfA3ywdIIKtGfkypyqQ1Cvbr34j23nuPdoay2UGD8Na6lWkSx2UzT8SNI4IR4DZIVp+Um+Nn0gTtIvR1zBbIbe8n1KuM=
Date: Tue, 14 Dec 2021 13:37:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <rahul.singh@arm.com>
CC: <xen-devel@lists.xenproject.org>, <bertrand.marquis@arm.com>, Jan Beulich
	<jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu
	<wl@xen.org>, George Dunlap <george.dunlap@citrix.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Message-ID: <YbiP7YlpY22llB5Y@Air-de-Roger>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
X-ClientProxiedBy: MR1P264CA0089.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6187c76-5329-4a45-afaf-08d9befe70da
X-MS-TrafficTypeDiagnostic: DM4PR03MB6190:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB6190376AECC9AE304038350A8F759@DM4PR03MB6190.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wSICaKOi+JXKqPGQhKsTsmShcYPQXIYogtOqUHmYGQb5tLA2DIbv+U37+H24sQ0mAbRhfG1Yr813UwtQ97fT2dGyhZ5mG2+9f2g9tshMD1wnsBH9uJjMsG62IEBlAJDcWfu+BxYa6FJD6V3Bll5SFH1XGQEzSecCpVVHWm6MQkNC3en+t3VffAaJqXmHrdT7SS0xZ9TIEIsvwV0+yaQ4Pr1j1zhgDLIcO49GvGJBncr3tJMnzvaFT+00lX/0z64orj/6UgPebSu02Nct8JzpZQ7EAgrc8k683L3/HXt52/ssFTwXrF6tkdk+HzyfJ/E77Kd2CkKtIIWr0Yb1lwBXHDTfwaPBnaiNfjTe/EEY6hHTaJCrIkwkKeriEAw9ywxEn9PAi+qMmwsFXrpuGLg5L58spFQrlO+qrq8m3HQRV82n4SUnS9gzt4CoXFBFssuxi+WPDTBtyK4YmVO0Qa081YJ+O80sJ0e5L9onSrf4XjOHR6p4x9opXN/CPwIBQ0/wf9rrbQJE77suZwqeso+Hrbb7+LHTm6uhhzGFs99kTUKHozUhZXivru0SPkr/eGZBhFZJD9guKYZj6VHXQfKP9TWND/zdUUUyf57yVrWHgZBuHp4yJOJVguaV5df8/dZcWTHeL2Y0CyJBWU0+/QHRwx5EABg4ufXfnvrNv97K/n8QisC5tQMm4pdqbiwHCJwFe1uYb9tgWMB/tPnkGe2pe7t+lxb9rozfofrtnJ8Z9T/4jCgxWt896zuU8KpWS/080Dfn0aYCmy8z4CzGSS8T+VTvQPhUNI2F+2FaKkKIieg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(82960400001)(86362001)(66946007)(66556008)(66476007)(9686003)(6512007)(186003)(6506007)(316002)(6486002)(5660300002)(8936002)(85182001)(8676002)(6666004)(508600001)(6916009)(83380400001)(38100700002)(33716001)(26005)(2906002)(4326008)(54906003)(309714004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3Roak9ORkp2bXgrQkZtV2JobFJLSXlDRVV2RThyemZkYzRvOHo3WkdkWW9l?=
 =?utf-8?B?K2h0bUJTRTk2a0VJMHFmQnI3SWNkNE8yQnJtQ213QzVJa1RoSTI5QUdvdFlT?=
 =?utf-8?B?bnFad2w1THphVFU4Zm5EaDJlQXJzK0M1amNLOWxoeGlOaS9kL2M5TFI2R2M5?=
 =?utf-8?B?ZUdCdStBNUU4V1NHVC9pQ0gwdm56V1laem8wUVR3aUNJNDJtb0plVVNFKy93?=
 =?utf-8?B?MGRLV2JPck0rdUNLY1lmNFJaNm9NZVBpZGExaDduOGJaTGVLbWE2ZmptcXJ4?=
 =?utf-8?B?UExHSmJRdm5HT043bFRhZ3NTRXhjUmlMU3lJNFJuMUpCSnlNd1UyMHJwNStx?=
 =?utf-8?B?VUxwblUyNDRRaHZ5UldQS0F1SDJwcXk0cGJUTjVpZi9lK21yZnRHSTBWbk1s?=
 =?utf-8?B?UTRzN2xjT1Z6ZHAzMC92WGl5V3pVT1ZtTmJaUGpGYkEvbkltbS9hMHI1Q3dJ?=
 =?utf-8?B?eU1yaEx4ei93QVgwY0pjMUk1WHFKdVhkeXMyM1AyQW5Wd3NRazFnR3VFOFA1?=
 =?utf-8?B?dTliYlVrWkVBbXdmK2pSQ1ZsNkk1eE1WNjhYeHdkaW13R2t3TlRTTUcwcy9I?=
 =?utf-8?B?eit0RXQ1Q3hDRjBreWFENDVmSTdmZ0RGaEN5NEZ3OHpRT3lpQ2hVZ1d0R2py?=
 =?utf-8?B?aDFJZ0J1enlwdEtNTlJmUUVISFJoZFZBVGVGeVQyS0YxWE1jWnFCZ0h4SGYw?=
 =?utf-8?B?K1FNQUNDSVBleGxMVy9Jd1VyaGZ4OWhVanlWZC95Mkc4VUpLN09LNUpldEVX?=
 =?utf-8?B?WGtmaEM5VHR6YjBBbTBTS0lIVUJiUVJyem93LzhpTC9zbGgwOS9IRTJLS3Ur?=
 =?utf-8?B?d0dFbTBJRG4xSWVXR3pZNWkzcUlrK3BSNFVMODk5ZmVRYitzd3J5eFdBdWp0?=
 =?utf-8?B?TFdDQzBZK2p5RjdHNVV6SjBRWUd5aExLWmJ3VHZVMWYwMEN6cEtqQS83Umhs?=
 =?utf-8?B?Q2hYNzVRejFTa21RR2o4UHFnc0NGN0VNQ0xQa3BST3ZTVEJZL1lDZzd4VUhl?=
 =?utf-8?B?N2YxY0Zpb2NnSk1kWW1RSFFlNjh5emsveU96L2c3aUszQ1JYeFEzYUk0TGlh?=
 =?utf-8?B?QnYzOUI2YUU0RkcweWdSUFExQ25vb1hCdmw4TjBqa1I2bTU2L3J1WGNuaGk0?=
 =?utf-8?B?R1BnYVVSWHpaYnlsNVljMHdvZVEwZGJuSXRFVDdGTThZQkdPRTZuRU9FR0Jo?=
 =?utf-8?B?amxRaENBY2hMNmRSVTdPWXppMFZJQXhFcTBMeExZRkVVWEhTYXQrbEZnTXRh?=
 =?utf-8?B?MUZTa2JtTkVjUTlxbDlmMVV0QXFoZHprSmtZZ0pmNS94U2xWSzNSaVFoUEdj?=
 =?utf-8?B?UjBZV0oyQlZ2S2hIMC9xY0wrbkQyMmVDcWQ1K0s1MEJMQjk0SS9PczBSWW5h?=
 =?utf-8?B?c2pScFhkSmw1TFdnMVVvMnM0N0hrRVM5c3dxTG51T3V5Q3ZUeHFaRnpBajY0?=
 =?utf-8?B?YjBibm9ZZUxmZTZoL1paL0RtcTZqWXZBQllORnZHYXJ5ZkU4UWl1RmlrUnhJ?=
 =?utf-8?B?QmN4dHNRc05oRmwyL29walV3ME52Q29mODJhV0E2cWNQWTE3ZEdNZzl3Ylk2?=
 =?utf-8?B?VW03Y2RyV0JCbGdLV1ZhOU5uM3lPSWxrZ0wyc2VwQzFDaHYzN2QxWERVRDYx?=
 =?utf-8?B?OU50Y29VdFN5QmIzb2l0VFZIQ05KcG4veXFNeTJCY0FncTQrcjJad2JGR1pF?=
 =?utf-8?B?Z21KTEhIaW9kenVMZlRnd0xJS3g2RVlNYUE1ZXE1bFVIYUNGenBJeVg0R0d4?=
 =?utf-8?B?MGMyZVNnaFV0N25PbEg3dDQzQTU2byt4VHl4TTVpd0lmVi9TL2djNEkzd2R1?=
 =?utf-8?B?RUFkTEpTVHVEdDlvYmdjQ0wvYStMcnJaWVVJTjg2b0FJd3o2V3E5RFNmMlBn?=
 =?utf-8?B?TTdhSFg4cUhlVThJYWxtWlNRMy91ZEJlNURHcy9QQUJacWZOZm1iZldJek1Z?=
 =?utf-8?B?bTRieXB3UDlvWE15MFhobHlKeTdRSmNsVWUzRDRjdWNjNnVEOENJQlZ3RlYx?=
 =?utf-8?B?N2xzZDl6WExPRnNjYzhPWnVTNGM3OS9va3lLbjQyT3RvWldRdEVTVTB4dEJR?=
 =?utf-8?B?YWNzVnBMbTBOd0FIdmw4OE4xVFNWS2xSUkp6RzRHY1g0a09HOTMzd2F2NjY0?=
 =?utf-8?B?aHVYVGtCWWtacFZtMVZzK29uS00wdUhoeXlEMEhXdWk5ZnNvdlA0WHlralM4?=
 =?utf-8?Q?w18BX9FcvMpObF6X7n9bRoI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d6187c76-5329-4a45-afaf-08d9befe70da
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 12:37:07.5539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3LuH3dEzNivCuaUvqLRlLUL+mz58q5DGrP1CxIG3ZEW8zS0f5wJCyZzc2h6KOcCf68GjGLNoAGGuHFKSUocwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6190
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 10:45:17AM +0000, Rahul Singh wrote:
> vpci/msix.c file will be used for arm architecture when vpci msix
> support will be added to ARM, but there is x86 specific code in this
> file.
> 
> Move x86 specific code to the x86_msix.c file to make sure common code
> will be used for other architecture.
> 
> No functional change intended.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>  xen/arch/x86/msi.c                       |   2 +-
>  xen/drivers/passthrough/amd/iommu_init.c |   1 +
>  xen/drivers/vpci/Makefile                |   1 +
>  xen/drivers/vpci/msi.c                   |   3 +-
>  xen/drivers/vpci/msix.c                  | 134 +++++---------------
>  xen/drivers/vpci/x86_msix.c              | 155 +++++++++++++++++++++++

This should go into xen/arch/x86/hvm/vmsi.c there's already vPCI MSI
specific code in there.

>  xen/include/asm-x86/msi.h                |  28 ----
>  xen/include/xen/msi.h                    |  28 ++++
>  xen/include/xen/vpci.h                   |  21 +++
>  9 files changed, 239 insertions(+), 134 deletions(-)
>  create mode 100644 xen/drivers/vpci/x86_msix.c
> 
> diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c
> index 5febc0ea4b..2b120f897f 100644
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -23,7 +23,7 @@
>  #include <asm/io.h>
>  #include <asm/smp.h>
>  #include <asm/desc.h>
> -#include <asm/msi.h>
> +#include <xen/msi.h>

You likely need to move this up to the xen/ prefixed include block.

>  #include <asm/fixmap.h>
>  #include <asm/p2m.h>
>  #include <mach_apic.h>
> diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c
> index 559a734bda..fc385959c7 100644
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -20,6 +20,7 @@
>  #include <xen/acpi.h>
>  #include <xen/delay.h>
>  #include <xen/keyhandler.h>
> +#include <xen/msi.h>
>  
>  #include "iommu.h"

Might be better to replace the asm/msi.h in include in iommu.h with
xen/msi.h instead (or just add the xen/msi.h include instead of
replace).

>  
> diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
> index 1a1413b93e..543c265199 100644
> --- a/xen/drivers/vpci/Makefile
> +++ b/xen/drivers/vpci/Makefile
> @@ -1,2 +1,3 @@
>  obj-y += vpci.o header.o
>  obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
> +obj-$(CONFIG_X86) += x86_msix.o
> diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
> index 5757a7aed2..8fc82a9b8d 100644
> --- a/xen/drivers/vpci/msi.c
> +++ b/xen/drivers/vpci/msi.c
> @@ -16,12 +16,11 @@
>   * License along with this program; If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +#include <xen/msi.h>
>  #include <xen/sched.h>
>  #include <xen/softirq.h>
>  #include <xen/vpci.h>
>  
> -#include <asm/msi.h>
> -
>  static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
>                               void *data)
>  {
> diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
> index 846f1b8d70..7a9b02f1a5 100644
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -17,15 +17,24 @@
>   * License along with this program; If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +#include <xen/msi.h>
>  #include <xen/sched.h>
>  #include <xen/vpci.h>
>  
> -#include <asm/msi.h>
>  #include <asm/p2m.h>
>  
> -#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
> -    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
> -     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
> +/*
> + * The return value is different for the MMIO handler on ARM and x86
> + * architecture. To make the code common for both architectures create
> + * generic return code with architecture dependent values.
> + */
> +#ifdef CONFIG_X86
> +#define VPCI_EMUL_OKAY      X86EMUL_OKAY
> +#define VPCI_EMUL_RETRY     X86EMUL_RETRY
> +#else
> +#define VPCI_EMUL_OKAY      1
> +#define VPCI_EMUL_RETRY     VPCI_EMUL_OKAY
> +#endif

Since msix_{read/write} are no longer directly used by the MMIO
handlers you might as well just return an error code (or a boolean)
and let the caller translate that into the per-arch return code.

>  
>  static uint32_t control_read(const struct pci_dev *pdev, unsigned int reg,
>                               void *data)
> @@ -138,29 +147,6 @@ static void control_write(const struct pci_dev *pdev, unsigned int reg,
>          pci_conf_write16(pdev->sbdf, reg, val);
>  }
>  
> -static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr)
> -{
> -    struct vpci_msix *msix;
> -
> -    list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next )
> -    {
> -        const struct vpci_bar *bars = msix->pdev->vpci->header.bars;
> -        unsigned int i;
> -
> -        for ( i = 0; i < ARRAY_SIZE(msix->tables); i++ )
> -            if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled &&
> -                 VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) )
> -                return msix;
> -    }
> -
> -    return NULL;
> -}
> -
> -static int msix_accept(struct vcpu *v, unsigned long addr)
> -{
> -    return !!msix_find(v->domain, addr);
> -}
> -
>  static bool access_allowed(const struct pci_dev *pdev, unsigned long addr,
>                             unsigned int len)
>  {
> @@ -182,21 +168,19 @@ static struct vpci_msix_entry *get_entry(struct vpci_msix *msix,
>      return &msix->entries[(addr - start) / PCI_MSIX_ENTRY_SIZE];
>  }
>  
> -static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
> -                     unsigned long *data)
> +int msix_read(struct vpci_msix *msix, unsigned long addr, unsigned int len,

This now requires a vpci_ prefix, since it's a global function.
Plain msix_{read,write} is way to generic.

> +              unsigned long *data)
>  {
> -    const struct domain *d = v->domain;
> -    struct vpci_msix *msix = msix_find(d, addr);
>      const struct vpci_msix_entry *entry;
>      unsigned int offset;
>  
>      *data = ~0ul;
>  
>      if ( !msix )
> -        return X86EMUL_RETRY;
> +        return VPCI_EMUL_RETRY;
>  
>      if ( !access_allowed(msix->pdev, addr, len) )
> -        return X86EMUL_OKAY;
> +        return VPCI_EMUL_OKAY;
>  
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>      {
> @@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>          switch ( len )
>          {
>          case 4:
> -            *data = readl(addr);
> +            *data = vpci_arch_readl(addr);

Why do you need a vpci wrapper around the read/write handlers? AFAICT
arm64 also has {read,write}{l,q}. And you likely want to protect the
64bit read with CONFIG_64BIT if this code is to be made available to
arm32.

>              break;
>  
>          case 8:
> -            *data = readq(addr);
> +            *data = vpci_arch_readq(addr);
>              break;
>  
>          default:
> @@ -222,7 +206,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>              break;
>          }
>  
> -        return X86EMUL_OKAY;
> +        return VPCI_EMUL_OKAY;
>      }
>  
>      spin_lock(&msix->pdev->vpci->lock);
> @@ -256,22 +240,20 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>      }
>      spin_unlock(&msix->pdev->vpci->lock);
>  
> -    return X86EMUL_OKAY;
> +    return VPCI_EMUL_OKAY;
>  }
>  
> -static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
> -                      unsigned long data)
> +int msix_write(const struct domain *d, struct vpci_msix *msix,
> +               unsigned long addr, unsigned int len, unsigned long data)
>  {
> -    const struct domain *d = v->domain;
> -    struct vpci_msix *msix = msix_find(d, addr);
>      struct vpci_msix_entry *entry;
>      unsigned int offset;
>  
>      if ( !msix )
> -        return X86EMUL_RETRY;
> +        return VPCI_EMUL_RETRY;
>  
>      if ( !access_allowed(msix->pdev, addr, len) )
> -        return X86EMUL_OKAY;
> +        return VPCI_EMUL_OKAY;
>  
>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>      {
> @@ -281,11 +263,11 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
>              switch ( len )
>              {
>              case 4:
> -                writel(data, addr);
> +                vpci_arch_writel(data, addr);
>                  break;
>  
>              case 8:
> -                writeq(data, addr);
> +                vpci_arch_writeq(data, addr);
>                  break;
>  
>              default:
> @@ -294,7 +276,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
>              }
>          }
>  
> -        return X86EMUL_OKAY;
> +        return VPCI_EMUL_OKAY;
>      }
>  
>      spin_lock(&msix->pdev->vpci->lock);
> @@ -372,60 +354,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
>      }
>      spin_unlock(&msix->pdev->vpci->lock);
>  
> -    return X86EMUL_OKAY;
> -}
> -
> -static const struct hvm_mmio_ops vpci_msix_table_ops = {
> -    .check = msix_accept,
> -    .read = msix_read,
> -    .write = msix_write,
> -};
> -
> -int vpci_make_msix_hole(const struct pci_dev *pdev)
> -{
> -    struct domain *d = pdev->domain;
> -    unsigned int i;
> -
> -    if ( !pdev->vpci->msix )
> -        return 0;
> -
> -    /* Make sure there's a hole for the MSIX table/PBA in the p2m. */
> -    for ( i = 0; i < ARRAY_SIZE(pdev->vpci->msix->tables); i++ )
> -    {
> -        unsigned long start = PFN_DOWN(vmsix_table_addr(pdev->vpci, i));
> -        unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
> -                                     vmsix_table_size(pdev->vpci, i) - 1);
> -
> -        for ( ; start <= end; start++ )
> -        {
> -            p2m_type_t t;
> -            mfn_t mfn = get_gfn_query(d, start, &t);
> -
> -            switch ( t )
> -            {
> -            case p2m_mmio_dm:
> -            case p2m_invalid:
> -                break;
> -            case p2m_mmio_direct:
> -                if ( mfn_x(mfn) == start )
> -                {
> -                    clear_identity_p2m_entry(d, start);
> -                    break;
> -                }
> -                /* fallthrough. */
> -            default:
> -                put_gfn(d, start);
> -                gprintk(XENLOG_WARNING,
> -                        "%pp: existing mapping (mfn: %" PRI_mfn
> -                        "type: %d) at %#lx clobbers MSIX MMIO area\n",
> -                        &pdev->sbdf, mfn_x(mfn), t, start);
> -                return -EEXIST;
> -            }
> -            put_gfn(d, start);
> -        }
> -    }
> -
> -    return 0;
> +    return VPCI_EMUL_OKAY;
>  }
>  
>  static int init_msix(struct pci_dev *pdev)
> @@ -472,11 +401,10 @@ static int init_msix(struct pci_dev *pdev)
>          vpci_msix_arch_init_entry(&msix->entries[i]);
>      }
>  
> -    if ( list_empty(&d->arch.hvm.msix_tables) )
> -        register_mmio_handler(d, &vpci_msix_table_ops);
> +    register_msix_mmio_handler(d);
> +    vpci_msix_add_to_msix_table(msix, d);
>  
>      pdev->vpci->msix = msix;
> -    list_add(&msix->next, &d->arch.hvm.msix_tables);

You could likely do the registering of the handler and the addition of
the table in the same handler: vpci_msix_arch_register or similar.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:38:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:38:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246710.425469 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx74N-0004bv-Vk; Tue, 14 Dec 2021 12:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246710.425469; Tue, 14 Dec 2021 12:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx74N-0004bo-Qm; Tue, 14 Dec 2021 12:38:11 +0000
Received: by outflank-mailman (input) for mailman id 246710;
 Tue, 14 Dec 2021 12:38:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KYVb=Q7=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mx74M-000421-RZ
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:38:11 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b2050bfe-5cda-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:38:10 +0100 (CET)
Received: by mail-lf1-x12f.google.com with SMTP id z7so36512293lfi.11
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 04:38:10 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id r5sm1879323lji.132.2021.12.14.04.38.08
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Dec 2021 04:38:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b2050bfe-5cda-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=fEoG2D1+lzGwxI9iKVc9jEyaXpS5rk2Da8vud5FGmZY=;
        b=i18JZ8UOcByRAgriEWMc5gMvcvhJgUzrwjnSzZCBHPND13enFnoZ5nBQX6Fr6owOuH
         GZJFmnGlG4sAJ0fMgwFO1E7vwBBCtpjKHfRTisgElzba/KSMxaKPYsmGxNgYzzacG2yi
         e5b8L7IxNcNW0AorAjIoC4gliDtNl+pNqTBeLwk76SOng4ONEVcu0KBUC3a3owQq6tUW
         cFLwEVceVgktxUrWzg69sp096S8VbRL6Qgiaqp+wE9gPt3fbL63jV7L027dtKCtbYWwS
         igEpjDjaKNtSIKtV0GvCAv9gARd+v0NrYVZNQSgf6hWwo40Syuk4Np1xk2+vSJebV0sd
         xpDw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=fEoG2D1+lzGwxI9iKVc9jEyaXpS5rk2Da8vud5FGmZY=;
        b=v4veQGPqiUtvYPbl1KGz4bpaqEq+91cEW7RKjhPI1cyetgAtsF6+oc/w4YA8XzvMuM
         w65LCTlKGj7lNkkjzb2Qb3xoiuQfE+boJsZo2m/b8q0Trquo4n5O01tKRJiHJi+CT00m
         tDxC5vJS15JyWCPOmISdVTF/JpCM+dJZ2K8H3+RWAS0AhCgycGv2jeCdgBT1lLbOxrcX
         x60UeNY2Z/iJvEAzpBxOI+IA3cStxliWzYECL8isUOlcEa/bnLLejnxbwHevs7WIBxfj
         0VccbynGBndzPq+dPmR/WEdc+UXCDFCjGxLU6YXOjXdK/Gx+K9znPnPwusVwOmlqBgQg
         0pdQ==
X-Gm-Message-State: AOAM533RbwEmBMO4+RU/SVqLadiOiAKd7RubPEMFlW/uLSZ9ZzhXM9Ie
	Xf1SFu4sPFEAeIKX2bqph3A=
X-Google-Smtp-Source: ABdhPJyg6Wd45KiqBhUprtCyaJ+CDTKuTGLIcB8KvxyjeJGkvbS3jv8wEULy19O78YFkW5m52heU+Q==
X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr4288388lfb.628.1639485489746;
        Tue, 14 Dec 2021 04:38:09 -0800 (PST)
Subject: Re: [PATCH 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4)
 support
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Jan Beulich <jbeulich@suse.com>, Paul Durrant <paul@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-8-git-send-email-olekstysh@gmail.com>
 <TY2PR01MB36922C89869ADAAF34A75F35D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <0c41033e-fffd-1d47-a4d9-a8d28f0b835e@gmail.com>
Date: Tue, 14 Dec 2021 14:38:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <TY2PR01MB36922C89869ADAAF34A75F35D8759@TY2PR01MB3692.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 14:10, Yoshihiro Shimoda wrote:
> Hello Oleksandr-san,

Hello Shimoda-san,


>
> Thank you for the patch!
>
>> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Based on the following commit from the Renesas BSP:
>> 7003b9f732cffdc778fceb4bffb05ebb4540f726
>> located at:
>> https://github.com/renesas-rcar/linux-bsp/tree/v5.10.41/rcar-5.1.3.rc5
> I would like to reuse an upstream-based patch instead of this BSP patch.

Makes sense


> Linux upstream doesn't support the IPMMU-VMSA driver for R-Car S4 yet,
> but I believe the following patch can be helpful for R-Car S4:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/iommu/ipmmu-vmsa.c?h=v5.16-rc1&id=7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
> I have a plan to modify the Linux IPMMU-VMSA driver for R-Car S4 in the future.
> - The ipmmu_features_r8a779a0 is replaced with ipmmu_features_rcar_gen4.

Thank you for the pointer, I got it, will do.

>
> I'll review further patches (8/10 through 10/10) tomorrow or later.

Thank you!


>
> Best regards,
> Yoshihiro Shimoda
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 12:52:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 12:52:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246721.425484 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7Ht-0007Ih-5h; Tue, 14 Dec 2021 12:52:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246721.425484; Tue, 14 Dec 2021 12:52:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7Ht-0007Ia-2p; Tue, 14 Dec 2021 12:52:09 +0000
Received: by outflank-mailman (input) for mailman id 246721;
 Tue, 14 Dec 2021 12:52:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=C1I2=Q7=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mx7Hr-0007IT-LF
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 12:52:07 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a389d707-5cdc-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 13:52:05 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:42982)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mx7Ho-000BQw-8R (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 14 Dec 2021 12:52:04 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 516D020339;
 Tue, 14 Dec 2021 12:52:04 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a389d707-5cdc-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4210cadd-a717-2a8b-1cba-044f2bede588@srcf.net>
Date: Tue, 14 Dec 2021 12:52:03 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211213190449.4830-1-andrew.cooper3@citrix.com>
 <76367980-c0ff-13c6-4a86-24be90f28f8d@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell
 ...)
In-Reply-To: <76367980-c0ff-13c6-4a86-24be90f28f8d@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 14/12/2021 08:17, Jan Beulich wrote:
> On 13.12.2021 20:04, Andrew Cooper wrote:
>> --- a/tools/libs/libs.mk
>> +++ b/tools/libs/libs.mk
>> @@ -6,7 +6,10 @@
>>  #   MINOR:   minor version of lib (0 if empty)
>>  
>>  LIBNAME := $(notdir $(CURDIR))
>> -MAJOR ?= $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
>> +
>> +ifeq ($(origin MAJOR), undefined)
>> +MAJOR := $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
>> +endif
>>  MINOR ?= 0
>>  
>>  SHLIB_LDFLAGS += -Wl,--version-script=libxen$(LIBNAME).map
> Wouldn't it be better to move the "endif" past the setting of MINOR
> (which then could use := as well)? Libraries with their own versioning
> would imo better specify both rather than relying on getting 0 from
> here (which at present none of them does). Would require an
> adjustment to the comment at the top of libs.mk, though.

I considered that, but decided against it.

Absolutely nothing good can come of having a mix/match of whether MAJOR
and MINOR are set, and the whole point of this logic is to provide a
safe default when things are unspecified.

>
> And further, since you're switching to $(origin ...), wouldn't this
> be an opportunity to avoid stray inheriting of values from the
> environment, by switching to "ifneq ($(origin MAJOR), file)"?

No.  Not because I think setting MAJOR on the command line is sensible,
but because it fails the principle of lease surprise.

Basically all variables are editable on the command line and the
environment.  Prohibiting this one alone is bizarre, unnecessary, and
fragile in the case where if it is encountered, it's probably someone
who knows exactly what they're doing, trying to debug the build system.

~Andrew


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:35:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:35:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246733.425498 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7xP-0003ac-IM; Tue, 14 Dec 2021 13:35:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246733.425498; Tue, 14 Dec 2021 13:35:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7xP-0003aV-FO; Tue, 14 Dec 2021 13:35:03 +0000
Received: by outflank-mailman (input) for mailman id 246733;
 Tue, 14 Dec 2021 13:35:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=z9rB=Q7=gmail.com=jandryuk@srs-se1.protection.inumbo.net>)
 id 1mx7xN-0003aP-UG
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 13:35:02 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2a29b1f-5ce2-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 14:35:00 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id z8so28306614ljz.9
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 05:35:00 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2a29b1f-5ce2-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=TlxjNyqeqo4Wdhom6SPIkPBaNmlnztiz6pIKybY2+8c=;
        b=PXfwgG5ZpsSRysswoSWec0gaWbWXrYGDxXXNVGFXbSbbRjSsFWb2gsmCbqqL0RnnP3
         jdmpxl85s74mZdSQR2X+XJZAn+K+aPdNVhZStUgq7GK/8UCxf1l1LLMf3v1d6ZSb4OJd
         SvKKRxSA8yY6uP3+3L4LwDZchGgevLa2x61Q4jPlFQEu4S6Y6lQVMTN1Toc2//Ch/FJD
         k9RB2QvaWiMnwcXS6Msx2BBR+wo5fVW2EI/MNprxIpRu40ZFX93xSg1gohnT97Y9Kn8i
         QUrdmkM1V/O0+6uf2S38feS4f99hEqVfeXh4aHdx+j9EHeu1IUvS5JfRG06HgqFW5z40
         SvMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=TlxjNyqeqo4Wdhom6SPIkPBaNmlnztiz6pIKybY2+8c=;
        b=6Esh0LJ0jE/NnXXiZWEsjlWarAsNewlZ+IL2e4Reeov9itigenmzTb9Hafmqonjan4
         wi4sPu/KWtrFh74sk5NdMYxcFBAYHkkPLVcD/MDFSpAqIEx51lI2It7Rcq9kBAXjvUlm
         UYh5rY60ny2EGGXpkkHZ0FbvprI1ELpW5Xxe0CQJ4NH0JBaOQ7yWRH7lkAM6/4wZBydf
         XGQBwnHv03kCZI7JlDm337Eys9AkzrEM74j+jST/IjxXSlD6FjnlnBqvBURJ7NbC39Pf
         CCaMLw0hdzBceJWAXSdFOkOM8SM63Q2gmzvWZ9sXekIWzBYmCXpGVcaaSGj9ZO3h3ZeQ
         pO7Q==
X-Gm-Message-State: AOAM532hmJ6uTJG1W8yr3jCVbmx48BveiMWmgSZZa7Bb6R6Xooxjn4Nb
	ply4raooh4CDpdAjs4ng/0h8wmAaIsflEY3buwk=
X-Google-Smtp-Source: ABdhPJy3z1jkawSuYE0c5cvaDnae95EW67Yef2dNtf20YE3Z9B6l7+HVttacfuJ4YnHAOi5KpLSON8qMG+ray4eIvLA=
X-Received: by 2002:a2e:8ecd:: with SMTP id e13mr4834831ljl.459.1639488899600;
 Tue, 14 Dec 2021 05:34:59 -0800 (PST)
MIME-Version: 1.0
References: <5114ae87-bc0e-3d58-e16e-6d9d2fee0801@suse.com>
In-Reply-To: <5114ae87-bc0e-3d58-e16e-6d9d2fee0801@suse.com>
From: Jason Andryuk <jandryuk@gmail.com>
Date: Tue, 14 Dec 2021 08:34:48 -0500
Message-ID: <CAKf6xpt6+ZkXK5uXyp15UyA1J2AhtZWipW04M1xD1Yx4nx3jOw@mail.gmail.com>
Subject: Re: [PATCH] libxl/PCI: defer backend wait upon attaching to PV guest
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, 
	Anthony Perard <anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>, 
	Stefano Stabellini <stefano@stabellini.net>
Content-Type: text/plain; charset="UTF-8"

On Tue, Dec 14, 2021 at 2:50 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Attempting to wait when the backend hasn't been created yet can't work:
> the function will complain "Backend ... does not exist". Move the
> waiting past the creation of the backend (and that of other related
> nodes), hoping that there are no other dependencies that would now be
> broken.
>
> Fixes: 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are reflected in the config")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Just to make it explicit: I have no idea why the waiting is needed in
> the first place. It's been there from the very introduction of PCI
> passthrough support (commit b0a1af61678b). I therefore can't exclude
> that an even better fix would be to simply omit the 2nd hunk here.

The first time a device is attached, the backend does not exist, and
the wait is not needed.  However, when a second device is attached,
the backend does exist.  Since pciback goes through Reconfiguring and
Reconfigured, I believe the wait exists to let the frontend/backend
settle back to Connected before modifying the xenstore entries to add
the additional device.  I could be wrong, but that is my best answer
for why someone went to the trouble of adding a wait in the first
place.

Prior to 0fdb48ffe7a1, the backend was created before the watch:
     num_devs = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/num_devs", be_path));
-    if (!num_devs)
-        return libxl__create_pci_backend(gc, domid, pci, 1);

     libxl_domain_type domtype = libxl__domain_type(gc, domid);
     if (domtype == LIBXL_DOMAIN_TYPE_INVALID)
         return ERROR_FAIL;

     if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
         if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d",
XenbusStateConnected)) < 0)
             return ERROR_FAIL;
     }

Here and elsewhere, num_devs has been used to identify pre-existing
backends.  That's why I went with the following to address this:
-    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
-        if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d",
XenbusStateConnected)) < 0)
+    /* wait is only needed if the backend already exists (num_devs != NULL) */
+    if (num_devs && !starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
+        if (libxl__wait_for_backend(gc, be_path,
+                                    GCSPRINTF("%d", XenbusStateConnected)) < 0)

Regards,
Jason

> --- a/tools/libs/light/libxl_pci.c
> +++ b/tools/libs/light/libxl_pci.c
> @@ -157,11 +157,6 @@ static int libxl__device_pci_add_xenstor
>      if (domtype == LIBXL_DOMAIN_TYPE_INVALID)
>          return ERROR_FAIL;
>
> -    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV) {
> -        if (libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected)) < 0)
> -            return ERROR_FAIL;
> -    }
> -
>      back = flexarray_make(gc, 16, 1);
>
>      LOGD(DEBUG, domid, "Adding new pci device to xenstore");
> @@ -213,6 +208,9 @@ static int libxl__device_pci_add_xenstor
>          if (rc < 0) goto out;
>      }
>
> +    if (!starting && domtype == LIBXL_DOMAIN_TYPE_PV)
> +        rc = libxl__wait_for_backend(gc, be_path, GCSPRINTF("%d", XenbusStateConnected));
> +
>  out:
>      libxl__xs_transaction_abort(gc, &t);
>      if (lock) libxl__unlock_file(lock);
>
>


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:37:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:37:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246738.425508 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7zN-0004C1-Uj; Tue, 14 Dec 2021 13:37:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246738.425508; Tue, 14 Dec 2021 13:37:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7zN-0004Bu-Rk; Tue, 14 Dec 2021 13:37:05 +0000
Received: by outflank-mailman (input) for mailman id 246738;
 Tue, 14 Dec 2021 13:37:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx7zN-0004Bk-A6; Tue, 14 Dec 2021 13:37:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx7zN-0000F5-3j; Tue, 14 Dec 2021 13:37:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx7zM-0002Fs-Oc; Tue, 14 Dec 2021 13:37:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mx7zM-0008Mc-O2; Tue, 14 Dec 2021 13:37:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jJPgplJfZHpoLGeFcaVbsb+PHcraq6xcKqnwgvdIkVg=; b=vBY9RaIhCHlqc4LPncT6KG4dbu
	DL3KkGLfOOdlnhJ2IwPnrPHiJbI+7VFMIJULfG6dIGmGzDWqcPa+mfOGrkHIgtORN4ImXddeBBTRG
	zpnhhrL0EkoOJihlA2gUDcseseKbiBIDuZI6l2yu0aL8OQRqIbO9dgQTPYMqa2u7/Irw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167409-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167409: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c039fa7ff09729de07bc7ebcdd4878340bfaf252
X-Osstest-Versions-That:
    ovmf=7a6e6ae9332614d386446d2a73e34b74fe66446f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 13:37:04 +0000

flight 167409 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167409/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c039fa7ff09729de07bc7ebcdd4878340bfaf252
baseline version:
 ovmf                 7a6e6ae9332614d386446d2a73e34b74fe66446f

Last test of basis   167394  2021-12-13 16:12:39 Z    0 days
Testing same since   167409  2021-12-14 11:40:24 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <rebecca@nuviainc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7a6e6ae933..c039fa7ff0  c039fa7ff09729de07bc7ebcdd4878340bfaf252 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:37:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:37:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246741.425522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7ze-0004c0-7t; Tue, 14 Dec 2021 13:37:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246741.425522; Tue, 14 Dec 2021 13:37:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx7ze-0004bt-4n; Tue, 14 Dec 2021 13:37:22 +0000
Received: by outflank-mailman (input) for mailman id 246741;
 Tue, 14 Dec 2021 13:37:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx7zc-0004bO-LF
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 13:37:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f54d9cd4-5ce2-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 14:37:19 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-6LB8YFTTM_m-oxuEfhiy-A-1; Tue, 14 Dec 2021 14:37:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3117.eurprd04.prod.outlook.com (2603:10a6:802:6::32) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Tue, 14 Dec
 2021 13:37:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 13:37:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f54d9cd4-5ce2-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639489038;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=67ANt6WrOHi8j4wVKlSSrrOphozpRx579YorBVJoke8=;
	b=OUh3Cr/cHYGu3K9FPNg/X5nn2hAD0YO05+/kxYBM58Lm6FYsppZ+k4vS+cqazGgfVAQbiG
	QkmBAGiFbS554ix7F9immxhD2z14HTNU+4R4XpdMmKUMu5UO3yg5Zf6/786jJEWTVg6tuy
	35uqaR0qqOIaIvwS/AwZvmE2iOokwbY=
X-MC-Unique: 6LB8YFTTM_m-oxuEfhiy-A-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fKVbWLvzQO3aXlRB6enybpNwVT62jN6bKETAokqR2OZrnoPMFoxT1Cr2LbbYTIHflMtcHw+eNp32Oi1nRXGHbqidHNJu78OPNDa722xIpsrgNiE5rf6DRDNQOLdNbu0tL+t6VQRXoiOvEZz7BZao1eEhgznNq0z1LEBoTE0IfHgJPo4ckV4AMA94jb5QZgS33XQdOTDIKP6u4C7/0sBAJlbByNcGlLDXU6JDtiCQxzkbGhzFJ4oeHq/VMkSzyX8vjwNjsbTzHIN1H49nwiRpSU1qMssyNUiRLdw2GC29lYiIGgJuw+pOoBU5iK65FpHR72VXWGiqh1oLKSVUTZtbCA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=67ANt6WrOHi8j4wVKlSSrrOphozpRx579YorBVJoke8=;
 b=Hrprz23H7WYxX6vjfPjhk1sf+pV/pyF1e5IbjY+KBQGIETKr26sNrFzlIZ/BIBGvdPS+gIgmS4AamAHcklB3Tl/7l+Amr/cyY69cVFBqnAI7T6EJILSxGMK1uYCUCEaFLk66dYFqVvUOEgEUXO4PRK2Amsc3hruoDwgyKJiBUxoR3sZqCt7lXjJRS73jWVYwqN5f3/UHGMHK+fs5T40trLhCjNYWGyCItL+eyjqlC+CxbP73rvGNBlhc1ts9XKyUHBoqPwC7mapgQg2sjsW7dQseqg+U2Nww3XslCa+PZEmKiBTab+5MdomSB30u6qjOUS8W+ifoP+AvyUattLEaLw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
Date: Tue, 14 Dec 2021 14:37:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
Content-Language: en-US
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0009.eurprd02.prod.outlook.com
 (2603:10a6:203:69::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 84679d62-0c8f-4f66-db72-08d9bf06d6c6
X-MS-TrafficTypeDiagnostic: VI1PR04MB3117:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB311726E4B5F753C7256397F0B3759@VI1PR04MB3117.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fII+AZEzDU2g9gAv6xJzgtnQVY2deOGLDrNLBSb7fPHszLaDFHCnxF0bqZXdNgtGv1eyE//fzdlDf9q0+MwZJwWWaOH5j3czgKzP2NllXnkZZdFTNz/CQjgO0ETte2ETmEbm+LNew90St/0jcGlAkK1MTW2y2i1LVbzbKmXwUFg2LpPxN7jnoTj1tmsAP5Npk3XH8qO287RrxIOLv59C7nTy4fBj/MOg5sZ+QgfjDiGCAcxUwCWo4QYXwj7wClcujdE5CvhIofi40WHw42KWcYcWbVDO+eNLzsShQKVuuuu3qINK2Uns0nmxpvQ2tD5ibPzqDnii5xSMx6Oe16/8uZCusIAyrkKsrv8xq0Xall45I8nEDr7Gm1Nk34yDSrgf5iU9jITvleY2OVO0YUa5db9UoaDbByRqB6UFChDMvDFbJYFi2+dcRzBrc8xeiehvvk02eI5GKB8SsSPF/pomkl1FxT1S75b31QH2LvKjPTphv1v6o/Dkv2lbKIg27gOev0Xfz+xg1/oEGQ4YK2ovty/fLSKhMZx1W4QiIC6UPAVendBJfoqRaa+eP8zFdaO2nQUWVo8Yu7Pdd4JHoTslbwYDEw0EENmhJH4PKtp2ucY5KiFhhRlFz9zGgnLeAST5jwQdy7o376DVT2LEPxl5/mreiQsJ1dM8IhmdMV7F3XHny34cFLqZuOBMEE5WJaCYsgcqgQq8MS/W/MS1k1QJfkS4YlGEfSGZwfHIZLFO4II=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(86362001)(8936002)(8676002)(6486002)(4326008)(66946007)(36756003)(186003)(2906002)(38100700002)(66556008)(66476007)(5660300002)(31686004)(26005)(31696002)(6512007)(2616005)(7416002)(54906003)(6506007)(53546011)(508600001)(316002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aTZ2aXZjRjhybEpqS1lXdDFPaFRNcEY1aE9WQ1F3VXp5M0tUOUlHR01oRVdq?=
 =?utf-8?B?blFIR0F4VWw0dlg5UVdBd3F4Y0ZIR1ZQZklCaDlaOFh5SENCY21xbTA0QTdl?=
 =?utf-8?B?ZkxCRStobjhYVGF5VzNxY0Z0V1BOZVlscVpFNGlBV20wWEVLaFBTNE9lSklG?=
 =?utf-8?B?MkxTeU4xQXl3N3NxRWFMS2owT3ZhTDNVcGk2eW1mSXhNSGhFQjJoWVg1N3Br?=
 =?utf-8?B?dkJ1Q21YNFpDcGlUMmZHVjRJQ1FQQWF2ZDRPRE02MGZuZUpGcks4WjhqRS9M?=
 =?utf-8?B?QVdCMEN3L0hGcDVEMVRaQU9lQklLOUUwU0RXem1RbXVvSUhmNk9uZlBaY283?=
 =?utf-8?B?TEZVbGhMZkNTMTRZdndVZWxuQ2J4dzVZVGNUT1Q3a2YxbGY1NUl6cFRUejRH?=
 =?utf-8?B?ZkNWZmVFQlYrVXd3Y0tWQTNNWW5PTm1UajBuc0ZLSVZmN3kwclBjMTArNUNa?=
 =?utf-8?B?MVlVNHBtMzJwaVUxVTZUKytvWWRtR202LzdNRVNCMEtvMVc1NEtoRDlJS1c5?=
 =?utf-8?B?K3Y1L2FhYzJybjBxNlljcDFzVTYySzhoelhiUi9SZjRsNERRZXR5OTFWeDVs?=
 =?utf-8?B?SWZlNHo1OWt1S3dFZDhYSUMxVU9xaTJWTFN2WkZ0NkxZWlZmdm9mY1E3UzNz?=
 =?utf-8?B?aDBlS2o3SDdUWitjY1ZUczN0ZkRQVE96RG9COC9nN3NES0VnV0ZpWTZ6NVZK?=
 =?utf-8?B?MjVZRVNtcUd5WC9GOXR0OW9RN0sxRzc2eE1aTUoxT3V3N1g2eHd6MDdDUm5u?=
 =?utf-8?B?RFRVaVFMYThFZnFDNXhGR095OHowbHZsMnAvS0I0TFA0ejYvTGFucG1xSFE2?=
 =?utf-8?B?S3hBR0N0cTBRNWlsVHR6SHhGdzBKTmd6TGZvWXJ5dmF2cGc0V3lwdnk5ajc4?=
 =?utf-8?B?cmZvT0lmcW9rV09sVnBybjMvSE9MUjk5UTNUL29rWTI1QTNBU3NMMVZjRFV2?=
 =?utf-8?B?TERkcmpBck1hVmkrRXNEZEdpbzZMTWZZRmtURGw5eDJrNGJnV0d6MklxVDRt?=
 =?utf-8?B?emV5RE1BY2F5SUgzOHhCejcxajczTTNER0FkUXA3ZmxvQmZvanVnRkYxZDRr?=
 =?utf-8?B?d2NHSEx0ZnA1Q0pnK3lVcnkxT2ptYk1TUGJ4TkgxQVFmQmdHbWJkM2xzTWNu?=
 =?utf-8?B?dlgyWnJlMVB4cUdic1dRK282a3RCQm1BUzltRXVkaEt3aEpsMjBtcmU4enlD?=
 =?utf-8?B?QnhMZnk5VnBOZmJPaS9MdWdXUHFVVEtKdnhGMmkwVTVqYmVoSjVUNlNDc2kz?=
 =?utf-8?B?MURwdmx5enFJMHJEMGJJK004djJOMmNPNVRNSUlwZDJFQS9VNHdUY1lVcDhS?=
 =?utf-8?B?K1djanZVR3dsNm1TSytOWWliZ0FzSS9KQVhObkN6L21aWTlWSmVkaXdDNHBP?=
 =?utf-8?B?aXA2SHNKUncxdWFqcTZueW9PYTRuNGQzUytTNkRFS2FBeDNrQlpaRW9rZFBL?=
 =?utf-8?B?SHBwcUFXV2pEb0dCYndSQTlaY0NYY0I1RTJGVjNERmVvME5aVXNublArNlRr?=
 =?utf-8?B?aHh4ZERPM2dsMmQ2TjhXV0w1SGVmUUVOYmxCVnJXZ1Y5VzZEckI4djNzRHJ2?=
 =?utf-8?B?RzRaVUN5c1JGTzhrTmpKc200UXkxS0lSc0N0b0FkcjV5NzhCS3NxYVA2aWJG?=
 =?utf-8?B?TWVnMmxKMVZESnBWTlJFd3BscU9LS1FyUFlRODYrdk4xUEN0NlhkMjN3SnY0?=
 =?utf-8?B?Z3BncTVFa3hreXRyb2d2SXpqQ050ek9nSHFBbmhodHk1SFZsbGR3b2tJWHdX?=
 =?utf-8?B?THFTdWdzSUl4bUg5Vk9YMEpjNTRLSVpuajZEdGx1UE93d2I3VkNLMXh3MFZB?=
 =?utf-8?B?UHVFVENqREV3N24wemd4RWdJSWVhYTNvNW9aaUxuQlBLWThUS3ppcVJZVlZ2?=
 =?utf-8?B?WGd3VEgyeDJOTnQvaEEzK0daNjlZZEM5Uk1MaUxkZkdaaFBNZWhXUEpEVEdL?=
 =?utf-8?B?TTZQTjh5UEZyUEdnT21TQTgwRjlGYWR5MUpLdnFuZHJIcDhWNGFpdERVRW1h?=
 =?utf-8?B?bFhRRHgxcXlaV20zTHcvTjFQOFRwSStyM3hhRVN1ZEdoRUg5WFMzem9vSFlr?=
 =?utf-8?B?Q0EwSXI1RVZKRnIra1dmSjRGMW55OHp2SHhsNlpaa3pFUlRvMnVzbTJMQUxs?=
 =?utf-8?B?eHhwUEhHdnkzTlJXNnpCYktqTU43V2xsVENVQ3J1SjMxY0d6Z1dxVDZ0RDEx?=
 =?utf-8?Q?PWBLtE9fR9FRYv4AL7o3EcU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84679d62-0c8f-4f66-db72-08d9bf06d6c6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 13:37:14.5030
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Izx0VgjvK+rrdja2xEO4thcsW5KaSzU3x0Rq9Tzlj2zkrr+S3gp0YIR5u8rVtd7OWCTV0HD0rtLgn4KPhfKfsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117

On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1382,8 +1382,10 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d,
>      spin_lock(&d->page_alloc_lock);
>  
>      /* The incremented type count pins as writable or read-only. */
> -    page->u.inuse.type_info =
> -        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1;
> +    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask);
> +    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none
> +                                                  : PGT_writable_page) |
> +                                MASK_INSR(1, PGT_count_mask);

It's certainly up to the Arm maintainers to judge, but I would have
deemed it better (less risky going forward) if PGT_count_mask
continued to use the bottom bits. (I guess I may have said so before.)

> @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
>      }
>  
>      /* Map at new location. */
> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
> +    else
> +    {
> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
> +
> +        p2m_write_lock(p2m);
> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) )
> +        {
> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access);
> +            if ( !rc )
> +                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
> +        }
> +        else
> +            rc = -EBUSY;

May I suggest to avoid failing here when page_get_xenheap_gfn(mfn_to_page(mfn))
matches the passed in GFN?

> @@ -2169,6 +2170,9 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>      if ( unlikely(pg == NULL) )
>          return NULL;
>  
> +    for ( i = 0; i < (1u << order); i++ )
> +        arch_alloc_xenheap_page(&pg[i]);
> +
>      memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));

I think this and ...

> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>  
>  void free_xenheap_pages(void *v, unsigned int order)
>  {
> +    struct page_info *pg;
> +    unsigned int i;
> +
>      ASSERT(!in_irq());
>  
>      if ( v == NULL )
>          return;
>  
> +    pg = virt_to_page(v);
> +
>      memguard_guard_range(v, 1 << (order + PAGE_SHIFT));

... this really want to (logically) move into the new arch hooks.
That'll effectively mean to simply drop the Arm stubs afaict (and I
notice there's some dead code there on x86, which I guess I'll make
a patch to clean up). But first of all this suggests that you want
to call the hooks with base page and order, putting the loops there.

> @@ -166,6 +173,32 @@ extern unsigned long xenheap_base_pdx;
>  
>  #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
>  
> +static inline gfn_t page_get_xenheap_gfn(struct page_info *p)

const please wherever possible.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:41:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:41:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246752.425534 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx83A-0006NA-Ri; Tue, 14 Dec 2021 13:41:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246752.425534; Tue, 14 Dec 2021 13:41:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx83A-0006N3-Og; Tue, 14 Dec 2021 13:41:00 +0000
Received: by outflank-mailman (input) for mailman id 246752;
 Tue, 14 Dec 2021 13:40:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cai7=Q7=gmail.com=xadimgnik@srs-se1.protection.inumbo.net>)
 id 1mx839-0006Mx-K9
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 13:40:59 +0000
Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com
 [2a00:1450:4864:20::432])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7832e218-5ce3-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 14:40:58 +0100 (CET)
Received: by mail-wr1-x432.google.com with SMTP id j3so32485950wrp.1
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 05:40:58 -0800 (PST)
Received: from [192.168.1.186] (host31-48-92-117.range31-48.btcentralplus.com.
 [31.48.92.117])
 by smtp.gmail.com with ESMTPSA id u2sm16264414wrs.17.2021.12.14.05.40.57
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Dec 2021 05:40:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7832e218-5ce3-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=message-id:date:mime-version:user-agent:reply-to:subject
         :content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=d5ndx34hN9m4TAr2xVMmBcuyEYVL6HUh2Zoc6H0l7hk=;
        b=kaRvdUhjK5mUvT3+oDIJClgAKiVvpfQFixukB5F2HVK4rUJMJ9XjxhXjCrceLjBc4h
         StwQCf3n4o/vQdj8KeHTHh5ZcUS/vDMwQtV9JtHE0BmKFUQquPKlB4gankOpGawqLTSi
         DiB9D4XD3hlmVj0KHHaeDaMClV/fnlmnLuz+2cAOjTXHljQ+alZaeT6ESVo2ll8lLHh6
         tTRydUk99j6UVvoeSBCytWV94rfGcVes/oR6rF/Tt6xDstaVqyV4/zAD0WxNznlcSVsp
         FBGOLRdd2dNFgUssQ82YMqtL4n60hzlBATcKzBhMqN9dPMdShuK8XQlm8K0MnUBT/omo
         PWvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to
         :subject:content-language:to:cc:references:from:in-reply-to
         :content-transfer-encoding;
        bh=d5ndx34hN9m4TAr2xVMmBcuyEYVL6HUh2Zoc6H0l7hk=;
        b=JwoMfBCntQKyevMz+vuHmVCsL9xcR5VYDJl8opj+2pcYM56DoqIIwNmZzVWHOl0AOi
         dcT0Ubq/qac7ShvgFrizR9RPLtAKnp/agtaMPCab1VL9+YpwfxzqICmCqxnoJ3MeGk6h
         92gXgYWeRuUcuXZHTFd+28+XhIxDWQrissFsDGfNvFm3wRT6d2ByAf5714zgQ8XYihA+
         A1O4XhWavh1VyixTdmPtw0gdiqc0sRJmorPTztS3Ge/dhgAAHKk//7MGUkxMZ1181PkM
         ssFcJQu2jv/o9WhQ5xAgwX1wUUNA9pTs0BbgAMD8xJChI4x48jQoSmZBGdVeGN2WdJQx
         yuVQ==
X-Gm-Message-State: AOAM533t6HCMmJ1q8T9+9oLBRVsb8Zf4MWruATlk1Auj+mU1W+2j/JKU
	wWI5vJFntfvp2vnBkSRrunY=
X-Google-Smtp-Source: ABdhPJySJ7nTJD03hzl2t9OmC0fdR31hCq/n5Ku3bel24kiVofteNrsCpe58LVNU6wohiG/7LHR/Qw==
X-Received: by 2002:adf:a10f:: with SMTP id o15mr5860296wro.592.1639489258334;
        Tue, 14 Dec 2021 05:40:58 -0800 (PST)
Message-ID: <adfe1c14-f773-0592-e304-d80da8380cc0@gmail.com>
Date: Tue, 14 Dec 2021 05:40:57 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Reply-To: paul@xen.org
Subject: Re: [PATCH] xen-hvm: Allow disabling buffer_io_timer
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>, qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony Perard <anthony.perard@citrix.com>, Paul Durrant <paul@xen.org>,
 Paolo Bonzini <pbonzini@redhat.com>,
 Richard Henderson <richard.henderson@linaro.org>,
 Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin"
 <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
 "open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
References: <20211210193434.75566-1-jandryuk@gmail.com>
From: "Durrant, Paul" <xadimgnik@gmail.com>
In-Reply-To: <20211210193434.75566-1-jandryuk@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 10/12/2021 11:34, Jason Andryuk wrote:
> commit f37f29d31488 "xen: slightly simplify bufioreq handling" hard
> coded setting req.count = 1 during initial field setup before the main
> loop.  This missed a subtlety that an early exit from the loop when
> there are no ioreqs to process, would have req.count == 0 for the return
> value.  handle_buffered_io() would then remove state->buffered_io_timer.
> Instead handle_buffered_iopage() is basically always returning true and
> handle_buffered_io() always re-setting the timer.
> 
> Restore the disabling of the timer by introducing a new handled_ioreq
> boolean and use as the return value.  The named variable will more
> clearly show the intent of the code.
> 
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>

Reviewed-by: Paul Durrant <paul@xen.org>


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:52:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:52:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246757.425544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8E6-00080Q-UO; Tue, 14 Dec 2021 13:52:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246757.425544; Tue, 14 Dec 2021 13:52:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8E6-00080J-RU; Tue, 14 Dec 2021 13:52:18 +0000
Received: by outflank-mailman (input) for mailman id 246757;
 Tue, 14 Dec 2021 13:52:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx8E5-000807-59; Tue, 14 Dec 2021 13:52:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx8E4-0000WQ-Td; Tue, 14 Dec 2021 13:52:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mx8E4-00033v-Gt; Tue, 14 Dec 2021 13:52:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mx8E4-0003AX-GQ; Tue, 14 Dec 2021 13:52:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aWCV/ZomAB/w7NNgfyBG1lRj6ruuYEPQDUAxqZ1C+dM=; b=VUMGWI4CHPTzW+7rfXcXPsbvVt
	ZVHwZYE4V6xYObTNr/FVZZO5rKBYnZeDzQm0xV+17nreiAFmA2Slae/2hNCodoHzOfssKtI+CvT5E
	oJyZIf6L7dKWBQOP25fadwqff0T3SP1xVzF312qbVh/jJYPiu8roE9w+KzP8tCMiopkg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167404-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167404: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
X-Osstest-Versions-That:
    linux=aa50faff4416c869b52dff68a937c84d29e12f4b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 13:52:16 +0000

flight 167404 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167404/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 167399

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167399
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167399
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167399
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167399
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167399
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167399
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167399
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167399
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167399
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
baseline version:
 linux                aa50faff4416c869b52dff68a937c84d29e12f4b

Last test of basis   167399  2021-12-13 19:39:34 Z    0 days
Testing same since   167404  2021-12-14 04:11:09 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Arnd Bergmann <arnd@arndb.de>
  Dan Carpenter <dan.carpenter@oracle.com>
  Jason Wang <jasowang@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Michael S. Tsirkin <mst@redhat.com>
  Parav Pandit <parav@nvidia.com>
  Steven Price <steven.price@arm.com>
  Suzuki K Poulose <suzuki.poulose@arm.com>
  Wei Wang <wei.w.wang@intel.com>
  Will Deacon <will@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   aa50faff4416..5472f14a3742  5472f14a37421d1bca3dddf33cabd3bd6dbefbbc -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:53:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246761.425559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8Eg-00005B-9n; Tue, 14 Dec 2021 13:52:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246761.425559; Tue, 14 Dec 2021 13:52:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8Eg-00004z-5P; Tue, 14 Dec 2021 13:52:54 +0000
Received: by outflank-mailman (input) for mailman id 246761;
 Tue, 14 Dec 2021 13:52:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx8Ee-0008U0-O2
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 13:52:52 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 206fc71c-5ce5-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 14:52:51 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-aXnlh77NNMm4b7U0JLeoRg-1; Tue, 14 Dec 2021 14:52:49 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 13:52:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 13:52:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 206fc71c-5ce5-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639489970;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KWKFtm6ZXF44qiSUmXPznQZW3QCKhJEVH8CFZzICRLA=;
	b=asfyLl33AGSg/wF3dS3+lUiQoq5PKj02l9tKoeF+jgIIIjRjwOKSLCK5BXhIMEHQsnbOtY
	CnrNqMBNjJzGeYvkrFZAZMtZ0OuuI0WK4QxZQ+k9gW/zPYf6yCg6Apt7WQrZn1TRcSgwJs
	q5Miv+vglrIvaXsmotD/5R35464vYCQ=
X-MC-Unique: aXnlh77NNMm4b7U0JLeoRg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=W62S0eSkHVUTsuPvS4CfpMMOtu0Dw3sNDu08KpPc1T9y1TZEau8wWDDWW7cAMQ/3xAEH2BGkWrnslcmAyeh9kitL8DllNy3Yge/rWZlVDxVZ1j8xwxwfNhrmMzYXzoejA2speypVqfN6UK16W7MOFD7ZUYY9Zbs2belRqp5LQIG4vYNelawxZaUt6x7eBlfbY/KCOz9S7AR639uptdwy3ulYvkEqf/wn6cZFh7x+n1yHM7fUE0+DFyLc1lTlmG1EfZPV8NYz9nY5dKNp34yTTjFenH3zi0db8uJUE8s0JrZAXfhtWItXLijp5tFnrWY+bZ2t4/qtaYyeO/8A3h4Hjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KWKFtm6ZXF44qiSUmXPznQZW3QCKhJEVH8CFZzICRLA=;
 b=hEXCIS/KMQZ7gZuz2STxDrmU2jF9ukf3Tqlqoolgl1dOAM072CGiRJ7UVe73h101Io2w9X5jbwTRebYXBs8bk3vj9hF6P08XeTTuIV2w5osnOhwdihdwIor5J2jVMJw3pYG6yG10rbKoogE1VEmO6zwwPBk0Q28Jbvz1Q9HpQBPzUjbs7s9xRl26UQw/4QusLhSQxt7rEu6ES75pNOI2w/0cpXITViZ9CfXwENoJw5e+pyCmDClFgayCaNDv0gzFMZuWDll3S+R5AAgA64MRvmQnjznHjyAjdeKRlgac/BYYdMxqHW/kUSU4lVOzezcLBiOQX15sc1AU/MyDURUC8A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <18a2487b-f754-d971-2e89-93e54b7b951b@suse.com>
Date: Tue, 14 Dec 2021 14:52:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] libxl/PCI: defer backend wait upon attaching to PV guest
Content-Language: en-US
To: Jason Andryuk <jandryuk@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>, Paul Durrant <paul@xen.org>,
 Stefano Stabellini <stefano@stabellini.net>
References: <5114ae87-bc0e-3d58-e16e-6d9d2fee0801@suse.com>
 <CAKf6xpt6+ZkXK5uXyp15UyA1J2AhtZWipW04M1xD1Yx4nx3jOw@mail.gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <CAKf6xpt6+ZkXK5uXyp15UyA1J2AhtZWipW04M1xD1Yx4nx3jOw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0003.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::9) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d5a1cc19-37ac-4c1e-34e7-08d9bf09020a
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2448B392B74D47282695123AB3759@VI1PR0401MB2448.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	sUnom1axr6L+20WFYfdCmczZQrgIz49x+SXeviYMh5mDSFEJ8RePURaCCQGZDhfJkb9dNtagixNtPyNgyMfkePFmkgNWwzLzJkwt4MCnjV0CwAzE3tywF1wrQlbGrcFPt57boZOXmuCgMzDsY+WICa1wGXvgTQwsfuQ9oGEd8wTXodmn+j6aAwwJDiIsDD6ePNomxN0J/JuZl+25G71mPaCYwPRK9H5ZVXW5sOeSuvlirJgxyoQ9b3gxz5MmdrOgOUHcXvfyCZmBejYKe4mGeszUJy+7x0JrOmtaOveM5Tsn/x+hXTOaPAqUqj6fQP8uTkTsJpaRbD1tOejRty8wEvn4aR87E7RCpvGphaBHEriPidtWc2Y1YrwmT8N7ymF1ueeuqoUZpf0eskz/6FL1qnZs54bTzkfdrIitgQGhgVwwmy7197PIZgxoKyDOCfvhcJHdadxaBaqpE/AKTaD68/mPhSczwPOC29/BeMwbKgSwCEPCXsaB7rcTD0Iiqtll502fDUgel7kZVzVDX3cC5gDhL11wRjGDKq7JQLMpEQf15a0G7gftkupqPnAQ7hjfxc3woLEoO3CuqOjYbKqkm9kgA05cJ99u3dN8ZcabwCs7Tf/yqnRRfZRNuu4g1021DicC7jLOqhuI8aCTaBsH4rLImIsxJFMbA4NqFWIF3aUT/GJ4rX7E/Hgy+6dFY3mcv0/OrEa9qJezSTuPxpBRGHw3V9NBvia192HARirH03O7Y9Z/W54r/yED4MaSEOlz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(6486002)(86362001)(6506007)(53546011)(4326008)(31696002)(5660300002)(8676002)(31686004)(186003)(6512007)(2616005)(508600001)(6666004)(6916009)(2906002)(66476007)(8936002)(316002)(36756003)(66556008)(66946007)(83380400001)(54906003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WmJrVzlwMVJsUVFHWWZWM0d4c093bDNRVmFrNmxjdGRKQ1I3T3R4ZEQyeGY2?=
 =?utf-8?B?WHh4V0dHL3FyelFEeVhGUXpUaDE0T2g1UENNL3piaERZdmVWWlgvbDAwdmJh?=
 =?utf-8?B?YzZrc1ozc2JESlBHQ0ZsdE1PWExNVVhmY0N2aHVyMTFBbnpYcVpRbkFtdThz?=
 =?utf-8?B?ZVM5UW45dm1PbmFkK0V6ZWhkMHVzYVlLdEEyaDVidFlPS1UyRVB2M1N5Ris1?=
 =?utf-8?B?TGFDSW1iSmM1WXBqTVk5TnpBbEFCRm02Q3F2VmtPY3NwL2c3RmtuZmRkQldv?=
 =?utf-8?B?V2NBYVdWMUdJYzY1d1RDaFd1VUNsYytRVUZDUi9Vc1MrVWJmaFJPMzRCdEdQ?=
 =?utf-8?B?WGxnWjhYeVNaSFJKY29KRVhSbTA5NHVjVENJMEw2RFBRTWZNTXVrUFBCdHdK?=
 =?utf-8?B?NWJvMDI4OTg3MjA0L1FsZDZONGdEcDkraUxpYmxjTUFOd2l3WEhDdzlvMHh0?=
 =?utf-8?B?eVZPWFN5VFF3YzEvMzdRT1VybGtkQkVQYlE2UU1rN3g1VUdGRzFxd3B4UkRF?=
 =?utf-8?B?OTB1eGQ2QlRvS041RW41Y2ovNC9uZG1ZTVVycjJzTkpwbjFrSllsQU9JS05a?=
 =?utf-8?B?QVdvZUdSNVh4alowbmNibXRqMzdkcTdKL0gycXpXZnRTMEl5NE9LM0Raem9F?=
 =?utf-8?B?cUtjbzlhNXh3WHlnSFVyQmdmR2NBbTEzcnI2QmtuWVFSeFV1NVdyZ2FmK2x6?=
 =?utf-8?B?bmY5V0JjVWJUOXFMakN6dy9zWFVBeFFmemFoT2wxOGhBTFhISlF3NWlTcHZF?=
 =?utf-8?B?bUh5RmtEVmoyRWdhYWd5U1ZJRkY2NzVraGdWYnY0QWkrcDlrYlRlQXRPUUdo?=
 =?utf-8?B?ZjkvTmJjUTM5b0xrMmY1VGVtT2llWE9XUDRkK3hJL2tQcGl1Ym9kUitmZERR?=
 =?utf-8?B?UDE2UklkSHRoWjlHNi9mUHRMSjVndTNBRjkrTlh3Yk0xU0NHOFdraFNxbWZK?=
 =?utf-8?B?UjU3bGpIQUNWQU85MkdBM01HUnpkWDRtdFo4Z0RxbXNWUXhHV0ZFeEx5UDJu?=
 =?utf-8?B?NzBYaEkvNUgvWmtwSklpdTlycXdxRjY2SlFoRlM4Q0I4WXM2ckNlc0xpMXVr?=
 =?utf-8?B?RUk1WjFlWnJVNHJwR3R6UnhFM1M4ZzdDb2lEZCs5TStSL21OVjVQV1RBNVcz?=
 =?utf-8?B?T2diRDFVZ1J4SzBJbm1ueVlCM0U5eDNNLzN1Q3FkcnpQaHNaYVFvbTI2ZHkz?=
 =?utf-8?B?SkJDQ3pjODB6L3hnbW8zZWZXY1JvQ0N3TisrWXVsNkJKbENyakNiOHB1RVBi?=
 =?utf-8?B?OCt5bG02YlZhRUdtUjg5d21QSVZFU0d0dk1XZ2hSdVNJZjVsZ1JtaCtET1Jt?=
 =?utf-8?B?NUg1RGI4SjV5N2loa09qdENqcUUwc2laZ211V21hYU13bjQ3K1pwSnJJNEtn?=
 =?utf-8?B?UW02MFNzZXU5MG8wWXViN3hUVnRRbGlhYWVrQ1A0OEY5YTRqT2wyQmVHMHpH?=
 =?utf-8?B?amdCMWE2bEhEQ3cycEY0WDlFMDBodU9tdFlVSElKYnJnZk9qYVdRNkhCNkJT?=
 =?utf-8?B?SGRTOGp1ZW1TNFZvNFdaUEhQRmNxN2JVSWM4c3BtU3BVc1A3cmFrVktpVEx1?=
 =?utf-8?B?bWNJdTdadEt2a3RuT1RmVTJ0UG1uVS9uemEveUNHbmRRYlprOEYyNkFZMXpS?=
 =?utf-8?B?M2c4RHIrWEovQ3g5RU9PR3A1eENOaFJ4TjFZMlNjZ0RseklNSWg2QVoxZnhF?=
 =?utf-8?B?Y0xVU0pRQ3Y3dkl2YWl1cHkyYmIrTjUyUmk0RlFIc3FpWWR5VUNuNVJxN3Rw?=
 =?utf-8?B?SHdwbkxBaDJ6V0lnWUYvNUJ3RERGYld4OUludEdQOG1aZk9SL3o3VHpLMSts?=
 =?utf-8?B?cXNRL1ZRaEFxZEFNTUIvL1RyOTZwTDBZU0JHYWlianBGOE1YemdEc0lERGtT?=
 =?utf-8?B?bG5tYi9pU05iTWcrcVgrcHI3TzhWMEc0V2RTc3J4d3hxS2Y0V0h4Mnhxc1ht?=
 =?utf-8?B?ZVVRYkpUNGZ0VU43eDRtU21laFdydmgyTmF2b2swUFBVRWlMMlljOVJtV2ZG?=
 =?utf-8?B?L1JLU1UwZ1RIU0c1aTJmQ1ZaQTVsS0wwSVVrZlF4TDhlTlpZMlpRMll3ZlA2?=
 =?utf-8?B?N1JkY0h5SVhsNGlWblcxZ0M0V0dEUzFFbTNQRm5ka2NSVHpuUWxyeEtZU2Nz?=
 =?utf-8?B?K2VRQ0JoL1RnUmdUUmx6bDUwcnljQUJ6SjhPN3laTkZCQkZqZTlDdFZmVUtn?=
 =?utf-8?Q?Y/C+r5IMjE2MmwJzkq1n5IY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5a1cc19-37ac-4c1e-34e7-08d9bf09020a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 13:52:46.1159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O1PlPuvDFt0S8phx/ULuG3CBRZBwfDKAzg+toQgKaouon3XZFHPMgNdXhz36C5FGVXREHrMqIQ7DSU7NyZp4PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448

On 14.12.2021 14:34, Jason Andryuk wrote:
> On Tue, Dec 14, 2021 at 2:50 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Attempting to wait when the backend hasn't been created yet can't work:
>> the function will complain "Backend ... does not exist". Move the
>> waiting past the creation of the backend (and that of other related
>> nodes), hoping that there are no other dependencies that would now be
>> broken.
>>
>> Fixes: 0fdb48ffe7a1 ("libxl: Make sure devices added by pci-attach are reflected in the config")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Just to make it explicit: I have no idea why the waiting is needed in
>> the first place. It's been there from the very introduction of PCI
>> passthrough support (commit b0a1af61678b). I therefore can't exclude
>> that an even better fix would be to simply omit the 2nd hunk here.
> 
> The first time a device is attached, the backend does not exist, and
> the wait is not needed.  However, when a second device is attached,
> the backend does exist.  Since pciback goes through Reconfiguring and
> Reconfigured, I believe the wait exists to let the frontend/backend
> settle back to Connected before modifying the xenstore entries to add
> the additional device.  I could be wrong, but that is my best answer
> for why someone went to the trouble of adding a wait in the first
> place.

If things are as you describe them, then the change here is wrong: The
waiting gets moved from before the creation of the new device's nodes
to immediately after. Yet then I also can't see how else I should
address the issue at hand, so I'd have to defer to someone else; this
may involve undoing / redoing some of what the commit referenced by
the Fixes: tag did.

However, since all new nodes get added in a single transaction, I
can't see why waiting for the completion of a prior reconfigure would
be necessary: That'll either notice (and process) the new nodes, or
it won't. If it does, the next reconfigure would simply be a no-op.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 13:57:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 13:57:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246770.425570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8Ix-0000to-W3; Tue, 14 Dec 2021 13:57:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246770.425570; Tue, 14 Dec 2021 13:57:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8Ix-0000th-SN; Tue, 14 Dec 2021 13:57:19 +0000
Received: by outflank-mailman (input) for mailman id 246770;
 Tue, 14 Dec 2021 13:57:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx8Iw-0000tW-Vi
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 13:57:18 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bfdf976e-5ce5-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 14:57:18 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2051.outbound.protection.outlook.com [104.47.12.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-jdc5vjMpMc-OVqkVnPCM6w-1; Tue, 14 Dec 2021 14:57:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 13:57:13 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 13:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bfdf976e-5ce5-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639490237;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=d82SRRXUwYU57am3sBelN7Vzrjljofv/UekY15CZkOc=;
	b=DmO8CwF6R4Su9BKM8sL/s5ISJwoWKe+79ukHu/DwEaoA2T1nGpWh9EZ7jqhnmJ2HkeWK2G
	4neeQmVs8tzQbVowuCAp8o1MwmeCkNtrArd9kiJKGbs13vm9Iqc8xa2xgmaIOFKzpyD/m0
	lC4ZmPL9rZFJHgAac5pfVrDFRm2Mk3M=
X-MC-Unique: jdc5vjMpMc-OVqkVnPCM6w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DWJVqiQBJkLd6D/8D9HjHDoqRMUwpZjYJjm+PWn6BXSgvUIWpCctHQhotxPOsRDgJkQuDHpPOW/YduyEv4IOcDzVbr/9ZOjE8NjqLNLHWffMVntHtxL9cdYi2VQeORnAg3GTieT5hhHBz8cc872Aih2Ja4rep4zXuanlWyt/uCcixKdSBzuXXwNa1iyhgS+EdDJuhiEIU0PrQ/iJR+Y0NsBysaONsMeOA4EBKXChd4WwBNW+zO21zkyuFDxzpfFuMLJI4DvpZ7oheZjEiptntuWj7LX+77t5J6/86Ygi5VDX99kqOYBkV4o4+Tw7tsG7ofbfmcrRbGjiAwJtB5ENqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gL7B/+3GB/q7NpfNxCWO1Yl+U7BzzRJ4Nt2Gs18E03Q=;
 b=YVvyiYpwEqDdDPKoWv2zyDQN8867rOlUQHvWAY/BbPO+JfcbxwZEQhDbUi9c3tf3VX7o/54v3rdy+aU8xJtpTkwKfKnHNOqR3Ev1Unz0fti5m8cDM87sqKYJUI7+gM78D6S5fliFtj6074NDugMkoHBPfxuFbMC/HvArfckhOvd4DOZMrhwuZUZ2Ek7I7ujEw4P0L331t6tX4pnErzE+k7+bIc+q2mWb9A6ze/U+D2XYPfbrQq6T5xzJ4ff82Kmoj6EcVmmXR8eHryn9mzBNwU825swyamrD6aC9aCdU64DTRHRL9yCF/A3gxOOUaTeuoIfxeN1exCnRzNQdjAxFYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <72ba2a9a-e5a9-5a42-9761-f8a68dd9c70a@suse.com>
Date: Tue, 14 Dec 2021 14:57:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell
 ...)
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Juergen Gross <jgross@suse.com>, Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211213190449.4830-1-andrew.cooper3@citrix.com>
 <76367980-c0ff-13c6-4a86-24be90f28f8d@suse.com>
 <4210cadd-a717-2a8b-1cba-044f2bede588@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <4210cadd-a717-2a8b-1cba-044f2bede588@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0115.eurprd04.prod.outlook.com
 (2603:10a6:20b:31e::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a9b53dab-c65a-486e-c1c9-08d9bf09a11a
X-MS-TrafficTypeDiagnostic: VI1PR04MB6174:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB6174E44F0F43552FD6FD6F44B3759@VI1PR04MB6174.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gs2C1nq0zrNUIq5ebEM9KuK9cTLyTJLjAatFvU18ahX1BWHNnn+ufVnQzLohhMpYe5Vo/UdpJogiRSOPt5Xhb1xWavDX0Hji6Z15uOYG77+tmtErkRDkPoR3/zU48G5O0NXK9RtxXWTZdTqtFNTMlMMBvR98oic8za+0idMrH3Q4B5P4dTiM2mKrUtyXTirK71c6BLyTUAJ49oTxhSG6uCoV0LPwMJRSpxENN8oTIZT4XbDi+9b4U8LiKBgVOv/2I0JaNPVvGc+mO7RzMWndwO8eIJkKQRrClveuAMINCfqxZKXf6nU0Xei+D8Hp1vPQsG2xmY5N/C0Ys50V7v6X6sjctpQa3MRMM0G++h7IG+OAqvtyXdW8nRC6scOcPPOAry9A0y+TcTBmvdFjjd1iBBiPVSU72bUL/CLwj4YelZLUCWiumY7/hmtoKjerD5f8VrSwL/OiBovYKFuglVFXET+4pzkqQSQgnHA4yqusRQ/6PKOXDfYVQm+zRKov9n0s7+cFPrkxaR2L+NWs5zBPZCdMtGQ6mNC5kd8d0VUoEqyW+04h4EF1ULONaep8vIy8kmwzHRmVdm92dKYRSssmsHuPNgOznFyXAl6VIVN4V+0Y/etAzJSpktlqvHByJn/jxFXej1ZoNtsW6b4+HEge5qz2z1JFus2Io4I4HzcQxkHTuPoxjnFfbFa137ZLfFW9PLAJFZvIGvzhS6DrYZNuhI3n01zoQTRuiexjEYRkfZyCGgFprGj408MWdPjCeMxY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(54906003)(26005)(6512007)(38100700002)(110136005)(31696002)(316002)(186003)(8936002)(4326008)(66946007)(86362001)(6506007)(2906002)(36756003)(53546011)(66476007)(66556008)(8676002)(508600001)(31686004)(2616005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7Ey453SWY6wTfdKKZolnDy71okboyIGJweyWv1vOzLX3RnFKtLKwgXR8S613?=
 =?us-ascii?Q?dvpWuBrJn55wvGmWT8L9lISjIGKWhBCNc2J7zbtu0ltGfHXvPXSypV9SjSUy?=
 =?us-ascii?Q?8j34qOaB/iWJQrPpci1UakWfDR3IgPXJLvoZOzE4ALa/KGKqGr+1BomQF9jo?=
 =?us-ascii?Q?nIV5RiZa8eysQQexM2ht5+uWvio6rUWF3mjR8Y2pad9pu/n3+qiYATRjNVgf?=
 =?us-ascii?Q?GO0B8NVuorFMiodKnXCTWUzTYeIx/YwK1+ZxqenlTgBQo598tyze7i6LRden?=
 =?us-ascii?Q?grJ/WTJoax4IXDm/VguR87NHZel7YY4vkoK4iMWwlbDohF2ldEwnpLu4cqMz?=
 =?us-ascii?Q?wVVz8CLv7pieA9yRkzhdCFHEuHDZECUeWSuvExk++l+u68FZvNkP9wW3Ity6?=
 =?us-ascii?Q?186U6uJWxQzx9og36ldhVVNeQmvMajZmQebO8zPav7DCr1LjJ3EhP/2iEfv7?=
 =?us-ascii?Q?and9k2kcc7lShtB2x8NNdc6xRLywrbSwo94z6kAunQBqfo6wCdKxkxNcAAQ2?=
 =?us-ascii?Q?FS8+uv8ixV1nnwzHuS0JUrcnaRwNtsC5pK2oCUrCg0ZLo6rBkvG79ZG6NOZj?=
 =?us-ascii?Q?pTwaS/KP0W4rmlB5qZt1WWFSHkfQwEvuzASBFWWI6NNvVhwGPJnCnZ63I+6M?=
 =?us-ascii?Q?41uvY/Ozmxn2JuG8RgEdMWOG5Easof3ITOanWvfrm1/U6/5zv0tWcKXHNamS?=
 =?us-ascii?Q?4ZO1e/vOgJvrTIHS1HUF/t91fwoV+yC77ftsIm91NYjlQRsKAXo4CYKt1VwD?=
 =?us-ascii?Q?UggrgxqjyrHyOKb/uOKj+cqOfzd73QAhwO7Cawuilh8OJN0lY7UZprbdu/Kr?=
 =?us-ascii?Q?lg5DyiEEVK4Ota2kiGUea9vHVrvCUWFvTcUGdzCC+PZnurr7czThpQ1tHeCI?=
 =?us-ascii?Q?ywEoG9iIILdTRkM+BEGmYfq/BqHy36Rk/efoYznKu8OUE5HesSUPBPl84S2s?=
 =?us-ascii?Q?kaek9qKEMh9tnnJHV/BqDt1mpy6m9QRDyy/EEawh6cwhaeCrg58R2l2vt/hx?=
 =?us-ascii?Q?K/YUSgnJVjGcaFeG2B25PbI6lEEW6jdDqslSQC+qEYu9fTWDP4ylEX+jWsiX?=
 =?us-ascii?Q?GEQwtIicb54a2h3nnHqV1vE4mPXEjbWAYw1d14p9Et5AU7lBlnz+mCRgrhFn?=
 =?us-ascii?Q?ko+NzOqU7Rz3H2MIPDEE+hSffxmls0rVkF0GTFomHphmnUZnVTKH89w3qRJc?=
 =?us-ascii?Q?iawzdgfCyVF0WDgodl6zWhGZiddljJgVdHVDJDsaZx2dZXvA0m9Z5DITEwm+?=
 =?us-ascii?Q?RlIxHzhAAUrWTMkXoKSrMNW9GZTbYOI5mlvr7vRxqLHg7R06W88jeNS2Foab?=
 =?us-ascii?Q?VSHP9hz7GdZMJqBrdMKEvL+7UKmyRlh5l92nBsa12yPSDAVEo7G2y8WZpLs9?=
 =?us-ascii?Q?h4INMqYBb2XqHLgBy+6wrLsSkqHWI5hVmVxwvM198qmUpv+7s0qhzYL1QLBD?=
 =?us-ascii?Q?BcrwG8NoYUKAoj8OrQZeR/0iyldHS0ymlSboEs+FiqYs8Ahii6fSKUoS+v7X?=
 =?us-ascii?Q?QJcb7Yl4WJZktM2rs1w+CW05aldyJNUiWn/da7zqLMrXxYcCrcu+4XxCEYob?=
 =?us-ascii?Q?OjktS+cssJnRU/H3qb63pIvnExNvDj71O+KYleGMVrLQhgURjps113wmVDHf?=
 =?us-ascii?Q?OLzvQRYxph90LrCly/xC3RM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9b53dab-c65a-486e-c1c9-08d9bf09a11a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 13:57:12.9661
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2TeS5nlHnE6+89yveZ7ECVt9Z/pT4nUCsgjdOKxavOGxpYC5Ge9/v/hElQ3Tp3H7APhyUReTQ4wcq61AX1hgzw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174

On 14.12.2021 13:52, Andrew Cooper wrote:
> On 14/12/2021 08:17, Jan Beulich wrote:
>> On 13.12.2021 20:04, Andrew Cooper wrote:
>>> --- a/tools/libs/libs.mk
>>> +++ b/tools/libs/libs.mk
>>> @@ -6,7 +6,10 @@
>>>  #   MINOR:   minor version of lib (0 if empty)
>>> =20
>>>  LIBNAME :=3D $(notdir $(CURDIR))
>>> -MAJOR ?=3D $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
>>> +
>>> +ifeq ($(origin MAJOR), undefined)
>>> +MAJOR :=3D $(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
>>> +endif
>>>  MINOR ?=3D 0
>>> =20
>>>  SHLIB_LDFLAGS +=3D -Wl,--version-script=3Dlibxen$(LIBNAME).map
>> Wouldn't it be better to move the "endif" past the setting of MINOR
>> (which then could use :=3D as well)? Libraries with their own versioning
>> would imo better specify both rather than relying on getting 0 from
>> here (which at present none of them does). Would require an
>> adjustment to the comment at the top of libs.mk, though.
>=20
> I considered that, but decided against it.
>=20
> Absolutely nothing good can come of having a mix/match of whether MAJOR
> and MINOR are set, and the whole point of this logic is to provide a
> safe default when things are unspecified.
>=20
>>
>> And further, since you're switching to $(origin ...), wouldn't this
>> be an opportunity to avoid stray inheriting of values from the
>> environment, by switching to "ifneq ($(origin MAJOR), file)"?
>=20
> No.=C2=A0 Not because I think setting MAJOR on the command line is sensib=
le,
> but because it fails the principle of lease surprise.
>=20
> Basically all variables are editable on the command line and the
> environment.=C2=A0 Prohibiting this one alone is bizarre, unnecessary, an=
d
> fragile in the case where if it is encountered, it's probably someone
> who knows exactly what they're doing, trying to debug the build system.

And then there's that someone else who ends up having MAJOR or MINOR
set in the environment from whatever was done previously in a shell.
The two variables are simply of too generic name to sensibly be
communicated via the environment (and I specifically separate the
variant where they're specified on the make command line).

Anyway - none of what I've said is an objection. I was merely hoping
we could get the whole thing a little less fragile at this occasion.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 14:16:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 14:16:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246783.425581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8aj-0003bX-IN; Tue, 14 Dec 2021 14:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246783.425581; Tue, 14 Dec 2021 14:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8aj-0003bQ-EQ; Tue, 14 Dec 2021 14:15:41 +0000
Received: by outflank-mailman (input) for mailman id 246783;
 Tue, 14 Dec 2021 14:15:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx8ah-0003bK-Qm
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:15:39 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f8b1814-5ce8-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 15:15:38 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-sGugHCXENSmaOOeuckITjA-1; Tue, 14 Dec 2021 15:15:36 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4944.eurprd04.prod.outlook.com (2603:10a6:803:60::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec
 2021 14:15:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 14:15:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f8b1814-5ce8-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639491337;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8zaD+wrF98sV2bkLjh0h3jn/wLVrDA+xd4/sIpuA/AY=;
	b=fmtlxRq4GZ3jZ8E7ow+mfxkBKnDXy1XVMKDg804/I2fsDuoxoXJizBY8kvSlWtoMvISh1R
	GPmhSWQ7DQXFiyLcL9w+jETL7KZJIdrIXrrx5iB9DeQ5nOXuHnk4Dy/zg8EW8m8FqIoL0A
	RnBO0awPPCqhf3GRbCa/ReTMGFKdDNs=
X-MC-Unique: sGugHCXENSmaOOeuckITjA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SE9wonCMOCVI4jxWV5RJyBIsRDRGYNVIbstWADanVgFXf34YmhUsoZiI8/Scga7Pay1H/wxnWBgB3fubJTkYxoRiUeVmhe+jnEdmIk7DHHIxWfIVoeKjDKXN4Q5smY2OtZG40YCykPwqiIQscYqwHDyjY2wepMYjLmFvMlbNP/Daug3v/MhYdz1v86n1SdcfHNPqAux07d2EoIU0j6Ylw56l8oVTjMdESCacE0qV463j6pocuUntlJV7ar85E9jfPqgZoGc5dpFhyR7IzGV3QoKvZFknga5ZoniUZCvWY7mi0P8lMXDvcoFrNjCRJabfJDnDW68dAQzL5J8Z4yCoQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8zaD+wrF98sV2bkLjh0h3jn/wLVrDA+xd4/sIpuA/AY=;
 b=TPC84Ha3/ZBkYoKGM5qnBug036NF+AgcYI5BKBIwJDxxGQPpbb0ZXNj0qnDxt8+LjeYJiI1bnYz4EGIhCo/o6bNO7jt1Cii2ULGZ66E3S8xSdxlIV2SApb6SWJ6CR9b3wCxze8UrVzQQg5eP4abfGGFH/Uz1AfdJo9k0bt/nTfENjXQnBzwONc+RVDjRmUMVRR3zjdQcIqoWwU2ST8zD+PwfY05WV7xPZveMXI2E1b/akYPWFkUfJERJBZnnwWTL6ApHcVpCV8UoPnTB7iMKWo21TS33wv23IPivF7KTDYde85chpYaFjDyW8HBTZ8e8E9mgejQJp9UforaeKxeLAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <90c66d68-4939-f203-de2a-caebd0d6fc6c@suse.com>
Date: Tue, 14 Dec 2021 15:15:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Content-Language: en-US
To: Rahul Singh <rahul.singh@arm.com>
Cc: bertrand.marquis@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 xen-devel@lists.xenproject.org
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0216.eurprd06.prod.outlook.com
 (2603:10a6:20b:45e::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: dc27fc3e-2dd4-4abd-2e7a-08d9bf0c3139
X-MS-TrafficTypeDiagnostic: VI1PR04MB4944:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB49449DF1C1FF6EC101DABB4BB3759@VI1PR04MB4944.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fDc57fjTyEIHhCHBHPfd6IRzyxhqCJuDdnk5sdu32D+itW8rtR9eM6VVw3rl+GphGTDcGsvM2hLWPx1A+kVqyZyYqUzEOI42EVeC9n0w8NX9sGNuXxkWP2GznIZwqAjYUJhwHN+7guUX05TGqu+mTMI2B//TRBAfsAuJftxbNokLInhEYXE7I4RJL0lIrZW/r4UnSItUrxy/rmqI3S6+twquBrhwBX0xKmrGdoCQqw1YY70JRbqSwGdlwhht1yyw9Ln6QwApx/gvXkK7EfEHvjYAMRvENoh2Now4MIbQcG3aqOFXTMeQVHvFmt4+nXZgqpnl8d7dLwB+ZnsJf0NkIO1LAyFIAiPX481f0jYrTiehfKqwqreAIqB8pAkU4HyKRKkploU8mK8VH9pLHXdncpgwe3VDtZrpn9hoATk4t03XBQ85DJbPCfiPD2WRpzQZdJr896VsQugqSt+3VJIBzKYmYKXRN1EVpaMmOZIihHlxs1BrUfYE7nPN7MwR4YT3X96JOK6Gh/HuT7OlmdVfTy7e21Ak46hDoF+E8AjZH+IyYhVCpGk/Eu/vkqfkV+R3zpb/MYl8posVbE1Bwpdc8/2u6tLCvFsmPeE+RFrL/RFDQd7f2wxkiIKqFRljfrS3DwJNSwLXITKbbv+MTsHihMZ/t9V8JKaqf+NXFvFjAFy7SbRxGDFv/i+JksMCWwMjQ21x3x0UoJRUuujwZW3XJbJKtH4jzrMURihG9xzdgnJEwi4hsrUzV9+UCNQGAcAMnBJx8UQ0L6HKLmL25pCXipMv5UKAgtYrgnxG14orUjCBkYLnMhqCwJ+FxkfaqaObJtk0DTXlNoJcNs3zwmJoCA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(66946007)(186003)(2616005)(8936002)(26005)(86362001)(5660300002)(31686004)(508600001)(6916009)(83380400001)(6512007)(38100700002)(36756003)(8676002)(53546011)(6506007)(54906003)(4326008)(2906002)(316002)(31696002)(6486002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TjkvdTR2cG92ZWR4SWZzQUE1TkwycFpqdUJlbjJQSlpiQUxnMG83TTIvZGIy?=
 =?utf-8?B?eG9uUGNEZGtYdFZrOWJ3a1l2QUE1a1hyMGNRcU9hLzhWREllWTE3c2tKMHRB?=
 =?utf-8?B?eHhzVy9ZcmJpb0NQTndIbE5MV2V0dklXUnd2bHNMdWVKWHNMaHpBeTgrdFBR?=
 =?utf-8?B?eFRPZTROQ0JReVhjZ2pIUENvcW9oNWVKaXh3bnVxNmd0dFBKNjRXNU9jbndU?=
 =?utf-8?B?Mmg5Z2t2dkpiTnIyYmxYaHFEcmZtc1doUXJRditLR3B2dU83L1o2bUVaNFRX?=
 =?utf-8?B?Q3ZaR0dTMUp1dS9IeE85NWhsc3R2Tmp5VGRNNGNLM3dlRUlrYjRsb3doR0lT?=
 =?utf-8?B?ZFE3K3lqektMSHV6dkZKMTNFdDZlWG4wVEg3Z0lLYUxGd0NUYUltSmRqQlpm?=
 =?utf-8?B?eXZtaUNUT2xGRnh0aE5DOUtUTktaV1pnRUdFd0tKdEJnYUZITjlQOUszWi9Q?=
 =?utf-8?B?RFpwb0tadnRqY0Vsblltb3Z0bWc4YU5sZHAvQjhVOGY1RWhTVklpaDkyWWlX?=
 =?utf-8?B?cm9xYXZsSjBuQjJwTGxDSEl2QmJlTXg5R0w2K1J6MjRqbFJ5Zkc2VnYzNitj?=
 =?utf-8?B?YW1pYUNNakdGeXhrUUd2aU5OUThlY0J5R3ZYR1ZGR1pZZVZlTkk3amZVa2ZP?=
 =?utf-8?B?UUh3MFY2Qk5jc3c0RzlxcndOZkRoVy9kNE1yNVU5VFhjMUUrV2FPTXU5Y3VW?=
 =?utf-8?B?T3NFNVRFeDdMYytjR0RIT2lxUjV2ODczMHhPNGlaMEJ5Tm1RK013TThidU9E?=
 =?utf-8?B?STlpdktBdm94L09KdUhzcUF5anVjdlRjcE1qTlowem4zQzZpUFRDYXcreWRp?=
 =?utf-8?B?aW9oRFIrYUlreU9KVTdWelB0M3VKV2JCeENsSmtuMS9zQnkxaC9KYldveDQx?=
 =?utf-8?B?cUNBNU5VTGpQQS9zaWVuUUxUbnZMTWJ6QlZscVlaMjh4bVZ0SkU1ellxc1JZ?=
 =?utf-8?B?d0IrMFp2VVhJRGdGR1JBOHhPb2hMTXF4SEZOOEh6M3JuYUFwNWwzWmYxc3VI?=
 =?utf-8?B?VzRNakFuY0trSTl2bGgvTnZkV1h4bytReWZYSnlKbXNObElZWGhYUVZYL1kr?=
 =?utf-8?B?TGQ5WjBKVFZPaFg0YlhKTDd2MVdxWGwvc1FzNU0yYmJLNnl6ZmU1RWpSbHB0?=
 =?utf-8?B?UTRFYUFxTFhGc1ZsOVV4Z0VyL1RiZGpHR0hoWFlKazI2YWxWMXNSU283aEVT?=
 =?utf-8?B?ODA3Y2g3ZEUvaW5mQ1BmTEhvRDBGM29PTVhRa0xsUDZCdGpDZ3JiaGZ6cFJx?=
 =?utf-8?B?eDByMm1JNEI4dS9tTFBTYzdWSDRwK0FFbElaRmJCTUJNZ0hyZGRpc1JqL0dt?=
 =?utf-8?B?aC9oWEJKRFBlWVhJZWZmaEJIRlNYUnNhK29EUytDdVlsc3JNRVVBa1l2QU1h?=
 =?utf-8?B?bjk4VC91alUxRWlucWNZTUt4bWs2Tmtmam5TSnZuUUdHMHhHMFJKVzM1UFhF?=
 =?utf-8?B?WnpWRURXVm1HbDF0K2tEbmc3amZmcTIvejB4dGtBRFVYb3NyOUl1b1NYdnJt?=
 =?utf-8?B?TVJZYU9FenhEWE93QkNCR3pSMnNRZmtRcGVsRlY4QVVueUhxTm1rOFVpdnha?=
 =?utf-8?B?R0d6K2ZlWFBscUY5WWVnVDBERk5kUGZYL2ZFcWdHdjRjZlhmVjR3V1VIUnRX?=
 =?utf-8?B?YkhEdEdiQi8xTlJhQTNMNEF1NCtlejdhdHhoeDhqR04zdTdCYlBZa2RGdTFs?=
 =?utf-8?B?SU1tQ3J5TmhYbFhGS0swQVBxODE0SEJMMmRobzA4VmVMa3ZpbEtRdC8wVFV5?=
 =?utf-8?B?NHUvRHovRXplQjBlWGdwcDYxNGtLdHZDU0FPUjJ5QzlaMVIwVnlINlNpazMz?=
 =?utf-8?B?S3lRV3diSXZ6SlJpY2dKeFdGSTNRaVNJRXUxdVpVS0VpMUFTQVRqTGI5S2NC?=
 =?utf-8?B?aGMzQUdMeDI4Z1RrYlhJS3hwNlFVdUxITElyWE92aDY1KzJ5THUzNXl6OGxy?=
 =?utf-8?B?S2lPOXhucVRIUjUzd0ZhaDJ6UTZsYlFRaDROaWpoOCs2QlRPdmR2MVpiNWkv?=
 =?utf-8?B?N0NYYWhUNk56T3hzTzhWaTRpNitMZGtvOUNQRGFPNy8zRnBMM3k0QUg1Nm85?=
 =?utf-8?B?eWs3K2s0Wjh5ZWtyWFVGK2pSN2ljWWtoR29RVldORThtM3YvQnlXZ1V2UTkx?=
 =?utf-8?B?VGM3bUpxR2lrdEwwb3VNUXU0RThpdXVTeVNUcEMzQ0VhbnhKb0lSMm14YnZa?=
 =?utf-8?Q?nHT+ARRO4J4s9v/VJsugYtc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc27fc3e-2dd4-4abd-2e7a-08d9bf0c3139
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 14:15:33.7598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hAu2CVFRT7xYA4hlffDPEsOhW0lmzrRSNU7fGH1wMqXqzVHOj3SkWgp6hMr+F229EzvES5izxURVb/xpFfJHmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4944

On 14.12.2021 11:45, Rahul Singh wrote:
> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -17,15 +17,24 @@
>   * License along with this program; If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> +#include <xen/msi.h>
>  #include <xen/sched.h>
>  #include <xen/vpci.h>
>  
> -#include <asm/msi.h>
>  #include <asm/p2m.h>
>  
> -#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                               \
> -    ((addr) >= vmsix_table_addr(vpci, nr) &&                              \
> -     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
> +/*
> + * The return value is different for the MMIO handler on ARM and x86
> + * architecture. To make the code common for both architectures create
> + * generic return code with architecture dependent values.
> + */
> +#ifdef CONFIG_X86
> +#define VPCI_EMUL_OKAY      X86EMUL_OKAY
> +#define VPCI_EMUL_RETRY     X86EMUL_RETRY
> +#else
> +#define VPCI_EMUL_OKAY      1
> +#define VPCI_EMUL_RETRY     VPCI_EMUL_OKAY
> +#endif

In addition to what Roger has said, at the example of the above I think
you want to split this change. The change in return value naming could
likely quite well be a separate thing. And then it'll be easier to see
which other suggested changes are really movement of x86-specific stuff
(looking over it I wasn't convinced everything you move really is).

> @@ -472,11 +401,10 @@ static int init_msix(struct pci_dev *pdev)
>          vpci_msix_arch_init_entry(&msix->entries[i]);
>      }
>  
> -    if ( list_empty(&d->arch.hvm.msix_tables) )
> -        register_mmio_handler(d, &vpci_msix_table_ops);
> +    register_msix_mmio_handler(d);
> +    vpci_msix_add_to_msix_table(msix, d);
>  
>      pdev->vpci->msix = msix;
> -    list_add(&msix->next, &d->arch.hvm.msix_tables);
>  
>      return 0;

May I ask that you don't alter the order of operations? I take it that
vpci_msix_add_to_msix_table() is the replacement of the list_add().
That should occur only after pdev->vcpi has been updated. I could in
fact imagine that in cases like this one for Arm barriers may need
adding.

> --- /dev/null
> +++ b/xen/drivers/vpci/x86_msix.c
> @@ -0,0 +1,155 @@
> +/*
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms and conditions of the GNU General Public
> + * License, version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public
> + * License along with this program; If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <xen/sched.h>
> +#include <xen/vpci.h>
> +
> +#include <asm/msi.h>
> +#include <asm/p2m.h>
> +
> +u32 vpci_arch_readl(unsigned long addr)

Nit: No new uses of u<N> please; these are being phased out, with
uint<N>_t being the intended types.

> +{
> +    return readl(addr);
> +}
> +
> +u64 vpci_arch_readq(unsigned long addr)
> +{
> +    return readq(addr);
> +}
> +
> +void vpci_arch_writel(u32 data, unsigned long addr)
> +{
> +    writel(data, addr);
> +}
> +
> +void vpci_arch_writeq(u64 data, unsigned long addr)
> +{
> +    writeq(data, addr);
> +}

Functions like these (if, as Roger said, they need abstracting in the
first place) or ...

> +void register_msix_mmio_handler(struct domain *d)
> +{
> +    if ( list_empty(&d->arch.hvm.msix_tables) )
> +        register_mmio_handler(d, &vpci_msix_table_ops);
> +}
> +
> +void vpci_msix_add_to_msix_table(struct vpci_msix *msix,
> +                                 struct domain *d)
> +{
> +    list_add(&msix->next, &d->arch.hvm.msix_tables);
> +}

... these would imo better be inline helpers.

> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -148,34 +148,6 @@ int msi_free_irq(struct msi_desc *entry);
>   */
>  #define NR_HP_RESERVED_VECTORS 	20
>  
> -#define msi_control_reg(base)		(base + PCI_MSI_FLAGS)
> -#define msi_lower_address_reg(base)	(base + PCI_MSI_ADDRESS_LO)
> -#define msi_upper_address_reg(base)	(base + PCI_MSI_ADDRESS_HI)
> -#define msi_data_reg(base, is64bit)	\
> -	( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
> -#define msi_mask_bits_reg(base, is64bit) \
> -	( (is64bit == 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4)
> -#define msi_pending_bits_reg(base, is64bit) \
> -	((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
> -#define msi_disable(control)		control &= ~PCI_MSI_FLAGS_ENABLE
> -#define multi_msi_capable(control) \
> -	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
> -#define multi_msi_enable(control, num) \
> -	control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
> -#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))
> -#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBIT))
> -#define msi_enable(control, num) multi_msi_enable(control, num); \
> -	control |= PCI_MSI_FLAGS_ENABLE
> -
> -#define msix_control_reg(base)		(base + PCI_MSIX_FLAGS)
> -#define msix_table_offset_reg(base)	(base + PCI_MSIX_TABLE)
> -#define msix_pba_offset_reg(base)	(base + PCI_MSIX_PBA)
> -#define msix_enable(control)	 	control |= PCI_MSIX_FLAGS_ENABLE
> -#define msix_disable(control)	 	control &= ~PCI_MSIX_FLAGS_ENABLE
> -#define msix_table_size(control) 	((control & PCI_MSIX_FLAGS_QSIZE)+1)
> -#define msix_unmask(address)	 	(address & ~PCI_MSIX_VECTOR_BITMASK)
> -#define msix_mask(address)		(address | PCI_MSIX_VECTOR_BITMASK)
> -
>  /*
>   * MSI Defined Data Structures
>   */
> diff --git a/xen/include/xen/msi.h b/xen/include/xen/msi.h
> index c903d0050c..1c22c9a4a7 100644
> --- a/xen/include/xen/msi.h
> +++ b/xen/include/xen/msi.h
> @@ -3,6 +3,34 @@
>  
>  #include <xen/pci.h>
>  
> +#define msi_control_reg(base)       (base + PCI_MSI_FLAGS)
> +#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO)
> +#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI)
> +#define msi_data_reg(base, is64bit) \
> +	( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )

As you move this code, please tidy is style-wise. For the construct
here, for example this would mean

#define msi_data_reg(base, is64bit) \
    ((is64bit) ? (base) + PCI_MSI_DATA_64 : (base) + PCI_MSI_DATA_32)

or perhaps even

#define msi_data_reg(base, is64bit) \
    ((base) + ((is64bit) ? PCI_MSI_DATA_64 : PCI_MSI_DATA_32))

Further items would want similar adjustments.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 14:37:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 14:37:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246790.425595 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8uv-0006I8-B3; Tue, 14 Dec 2021 14:36:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246790.425595; Tue, 14 Dec 2021 14:36:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx8uv-0006I1-7y; Tue, 14 Dec 2021 14:36:33 +0000
Received: by outflank-mailman (input) for mailman id 246790;
 Tue, 14 Dec 2021 14:36:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q7Ra=Q7=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mx8uu-0006Ht-0M
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:36:32 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38da17e6-5ceb-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 15:36:29 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38da17e6-5ceb-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639492589;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=/0+e9Kdg+aIpKoqaM6bidD6aLWE/lEe9a5+cvl4+vyE=;
  b=Hz9nf+VSKS8V4igWTfGl8rDyozYjtCU2Zvw2a4VMV8TLB8MhBVHAnIuQ
   BbLRJG/utgOwzrbMEdcACqfFT0EwLB4cIEkI+PkhvlStoHfAH5x80kY/z
   8Ts1Cf0TGbNgvOyzQSfidHKecgYTShR84Nv1VLiT6oe6kA8Ob2x7lLWiH
   Y=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: MGYQiKU6xxh+adcH0F47ohHqOlmYoQyo2gKxXFcOOo7z5YdrTarsvjyLGfl+h/jN8Oj5YW3/D3
 cS4o3W3mpqAkgKVdCH6WTmBZ6SCtF7lsvnm2ednjb+gesDhktISrvGHWuFWeCPMq8EuPPb9x1f
 uzBd7hUPxa7NsBaVDSAm2yxzNIP6YY/TWf8aEtV+G/yVlewprsjs/5x/dM4EolKyJcAZXhl51E
 sXcO+MYQhQ80PZglgryEcx5A65Dt1ikoYVYgiUjADWTtw89V5HrZkDRC0vRBUoHJuju1qlfUpV
 hi7seSAXVlyXbA53bMIXuC6V
X-SBRS: 5.1
X-MesageID: 59982327
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Kj/246jEhNbk/5iQ4uGKP0lJX161oxcKZh0ujC45NGQN5FlHY01je
 htvWzvXb/2DNDHwcop0a4myphxQ7cDQmtI3GQc+pSExQnwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx3YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /18iKThEAQKNZaSiftAQwsJPGJ/IoFJreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNauPN
 ppDMmAwBPjGS0dEYXFGMLsxoOKpryb8URxylFKFn6VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRAB4AM8eE4SGY6X/qjejK9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+ttK7xj6yKG8fTF/FuJFDkrDT9eRNNz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbs1oWtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D4gbQ4xawZRGp8crVnl
 CJb8yR5xLpRZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggfxY1aJ9cJGG2M
 R+7VeZtCHl7ZiTCgUhfOd3ZNijX5fK4SYSNug78MLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFMiT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWPnOKrNVNdA9SdhDWx/ne8qRqSwJKGSI+cElJNhMb6epJl1VNk/sHm+HW0
 Gu6X0MEmlPziWeecVeBa2x5aaOpVpF69CppMSspNFeu+n4ifYfws/tPK8ppJeEqpL550Pp5b
 /gZYMHcUP5BfSvKpmYGZp7noY08KBny3VCSPzCoaSQUdoJ7Q1Cb4cftewbirXFcDie+ucYkj
 aen0wfXHcgKSwh4VZ6EY/Oz1VKh+3ManbsqDUfPJ9BSfmTq8ZRrdHOt3qNmfZlUJEyalDWA1
 guQDRMJnsX3otc4oIvTmKSJj4a1CO8iTEBUKHbWsOStPi7A82v9nYIZCLSUfSrQXX/f8bm5Y
 bkH1On1NfAKkQoYs4d4FLo3n6sy68G2+u1fxwVgWn7Kc06qGvVrJXzfhZtDsahEx7l4vwqqW
 x3QpokGaOvRYM61QkQMIAcFb/iY0aBGkzbf2v05PUHm6XIl57GAS0hTY0GBhSE1wGGZ62/5L
 TPNYPIr1jE=
IronPort-HdrOrdr: A9a23:DKu/7aFIaW6Uk3ENpLqE6seALOsnbusQ8zAXP0AYc31om+ij5q
 eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079
 YYT0EUMr3N5DZB4/rH3A==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59982327"
Date: Tue, 14 Dec 2021 14:36:23 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Juergen Gross
	<jgross@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] tools/libs: Don't recursively expand MAJOR ?= $(shell
 ...)
Message-ID: <Ybir5x3AaHYqanwN@perard>
References: <20211213190449.4830-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211213190449.4830-1-andrew.cooper3@citrix.com>

On Mon, Dec 13, 2021 at 07:04:49PM +0000, Andrew Cooper wrote:
> ?= is a deferred assignment.  Switch to an alternative form which lets us use
> an immediate assignment.
> 
> Before, version.sh gets run anywhere between 46 and 88 times, with 50 on a
> `clean`.  After, 6 times, invariant of main rune, and whether it is an

Instead of just 6, you probably mean between 6 and 12 times,
"make clean; make; make", the last make would run version.sh 12 times.

> incremental build or not.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 14:51:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 14:51:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246798.425606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx994-0000WA-PZ; Tue, 14 Dec 2021 14:51:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246798.425606; Tue, 14 Dec 2021 14:51:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx994-0000W3-Lo; Tue, 14 Dec 2021 14:51:10 +0000
Received: by outflank-mailman (input) for mailman id 246798;
 Tue, 14 Dec 2021 14:51:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx993-0000Vt-H4
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:51:09 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 43e82e91-5ced-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 15:51:07 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43e82e91-5ced-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639493467;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5oNuD8VEQyPv7E2WfZtUh1Bwtr5EvGJs0byCK2iECl0=;
  b=hKruE+SO6+iD29K6P4h9wFwkZfJlFFbFQeaeDHZqdnb2SV3JFJLFn6IM
   ZiA330Cw1XBTYVaaOltp1fJusvx8jYiTv0ta7CcZwabWtdk6CNfEpDp+0
   5lUsiG+EBxPp9gvIS3ur/qcPSMzOzHHlZfE9/ErkLvDbTlDwXvLi7L/KS
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: UkQmCFYnl6IiGcfpPtWcVS1jJ2WAswybIn7TyCydSUt9YM+FEXgLqIjfDxgY4aS+rrfG1kxq59
 TusqESE1uegOKCzxXWElSjzJbwQA9OslvnkqToI7+ki31TaIDgRWLaWNSAWsLDb7rqjzbC+a9+
 l4q3TRtrgogSI0ATMj7XNwA953JCINmbF1uvDNxC37kLbA1prtg9v7W13h1ECysxDeu8qUQoYq
 Dzi3x+RNdwhWZ0fgJPtDcrDGfgWAaZ3fUuN3sN5jt1CgFOb8ACXSS55CIVB71isSzf4MpUD51U
 aN2iYPprfYAHJx66DTa5pvZj
X-SBRS: 5.1
X-MesageID: 59490827
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:CGACSqhSvDJATECFT0oqICKQX161lxcKZh0ujC45NGQN5FlHY01je
 htvD26HPquMZTT1KYhwa4/k9E5TscfdndFgHAtt/CA1F3gb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx3YDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0W6oG2ZxcvLJfyxugSUAcICy9FHqBvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t15wfRaaEO
 KL1bxIodEzAO00VFGszJ4NhwOOK2GjmUR9x/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru/GnnAxdcKN2WzxKE9G6hgqnEmiaTcIAYGaC89/VqqEaO3WFVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQId5qckYVTo47
 GHXk9zqG2x3voa2RFvIo994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3ipQif6w9AsKQlWeLcCu//emu+pj10a4e+D2BDwQiKtK0QRGp1o7Tog
 ZTlpyR8xLxeZX1uvHbUKAnoIF1Pz6zaWNE7qQQwd6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0Nv4rOdvpVpp1nPiI+THZuhb8NIUmjn9ZLlDvwc2TTRTIgzCFfLYEz8nTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvfvsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmrflA7RTp/UqCJmtvMueVNxsxoqwsBx
 VnkMmdww1vjn3zXbwKMb3FocrT0Wphj63k8OEQR0ZyAgRDPuK6js/UScYUZZ74i+LAxxPJ4V
 aBdKc6BHu5OWnLM/DFENcvxq4lrdRKKgwOSPnX6PGhjLsA4HwGZqMX5egbP9TUVCnblv8UJv
 LD9hBjQRoAORlo+AZ+OOu6v1V64oVMUhPl2AxnTOtBWdUi1qNpqJiX9g+UZOcYJLRmflDKW2
 xzPWUUTpPXXop9z+97M3PjWo4CsGup4P0xbA2iEsurmaXiEpjKumNYSXvyJcDbRUHLP1J+jP
 egFnevhNPAnnUpRt9YuGbhc0q9jtcDkoKVXz1o4ESyTPUirEL5pPlKPwdJL6v9W3rZctAa7B
 hCP991dNenbMc/pCgdMdg8sb+DF3vAIgDjCq/8yJRyitiNw+bOGV2RUPgWN13MBfOckbtt9z
 LdzotMS5iy+lgEuY4SPgS1j/miRKmANDvc8vZYADY630gcmxzmuu3AH5vMaNH1XV+hxDw==
IronPort-HdrOrdr: A9a23:LCnRpq0/8ejosw0IjEp4jQqjBRpyeYIsimQD101hICG9Lfbo8v
 xGzc5rtyMc1gxhO03IwerwSJVohEmsgaKc4eEqTM+ftXrdyRiVxeBZhrcKrAeQZxEWmtQts5
 uINpIOeeEYbmIKw/oSgjPIbOrIqePvmMrE6Ya/vhMdKj2Gc5sP0+46MHfkLqQffngFOXNTLu
 vm2iMznUvcRZ1hVLXAOpBqZZm7m/T70LjhbBI6GRhizAWVlzun5J7WeiLonis2Yndkx7ovzH
 bCqhf+7Km4qf23oyWslFM7264m3ecJh+EzXvBlRaAuW3rRozftQL4kd6yJvTgzru3qwFE2kO
 PUqxNlBMh342O5RBD+nfO4sTOO7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys
 twrjGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYcc99RrBmdIa+d
 RVfZ/hDbdtAAynhknizzVSKQmXLyUO9hTveDlIhiXa6UkW7SVEJ41x/r1aop5KzuNOd3B+3Z
 WyDkyz/Is+CPP+XZgNQ9vpCfHHf1AlYSi8aF56cm6XT53uzRr22tLKCItc3pDiRHT+pKFC1a
 gpFmko6FIaagbnBMrL25tQ6xjIBH6wUDT3xstCjqIJ44EUdYCbeRFrYGpe5fednw==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59490827"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZjZrkjRatDlDohwGylIluDSOSoogiy+doVla7+zn8wNN+ZR5o7Ql+nI7JOBYXDYb6RkgnQveCVfwxRwvNOqfz7qGDo8vKu95hEatVyTk6AfvZO0DjZMIUbd3l39Z9ta4R7UChu0MB6r7LHNja7Uq2yxk8Xqov/SCMl8KvnN3VjWBTWBdSjOQ6vvkKiAYP7G8RzQbqmtBUqvzoXqZ61pJ3q1Vzeo+nX41hxpFrr4KVn0Ho82g5qyQBBoZF8kUjRZ7XDV224rdYoh2Mc8kT25bA+x4ALAnGcTMM1jeCkFRsVPxftNW/3atXfhNiUB1iy9YgCtDx/qpiKWZJoQ537vK2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Z5AwfmST6IEJAWwXeNpOUO0xK1o8sx/l3Wpo8ECsrhQ=;
 b=DEP++/jlI03qBoLXjQTDYgqi5VkuqaTzEehNIhRNJ61Gfno1GhJik/RVWYeAYnDfgXWZKpHepGnN5a3q8nNcQOoWmY5GE7AZeno5IXJvSo9yOp/zmsEdxcuM1qwcy3d2mctaNxz5nocOj+ygRKtE8JVkv9Ivf8QAF3y+BSuawKTs9fmDvMtiaFhukZFl1TKEbcrJxzKR/f8OePZPFVn2/fG7zxqDLq/i5nFzLNTmvgBbRYCiT0NhPMzXeUtbNb+C4TbvuDvFzhOCXZ7YmuqlZ1li7cHll4Brg/XnQT3WODYMn67AJ2dWedYFGHrs/s5UtXhrstfPXYMziD5YODUSnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Z5AwfmST6IEJAWwXeNpOUO0xK1o8sx/l3Wpo8ECsrhQ=;
 b=aYmJDwggVSoQVYKnkb7bsV2XLy6Frb1n/Q4/apiVW7LxVNq5xA7APoAHJPuovxbFdS8MFpzrPf4vOQhRxKLyF94a1ByG6FVw0SSIKSuzkLFTplPiKr1HWdNsETnbU7LgNZpNVUczw4U4ZylDxHLlYBywjrzja0mnfV4niMYrxYw=
Date: Tue, 14 Dec 2021 15:50:56 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <YbivUH/Er0o2PwsG@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
X-ClientProxiedBy: MR2P264CA0174.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::13)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cdf67072-7f00-4909-dc34-08d9bf1125e0
X-MS-TrafficTypeDiagnostic: DM6PR03MB3481:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB3481CC0A225EEBAB5F95517B8F759@DM6PR03MB3481.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 50tw47/arc+1U3CMZibCDAG01kjZJHBCURX5mbFszuDtSteHkE5xcQEB1cbmZB6hdmhi+e+a/Ve4XLfE+O3wzbVXFMCie/5P+z8udnyvQ1PB0uW7/7uLsYaRPy8KubS8dIyraNNELlVhYLd01sxEAAtPRndcT1Ek+BlnpijhdL5Pw2JBHKCXoT4aaMGC11M2pClDiOY1Yv/rO8OtXLypgdTqtDRsrTYHViZemzH1vouBtGjUXPMasz+/mL//YxC8Y3CXzgaCjSElroFOJkrc+VzddJxF8RqoSQc2UDyQaUT41q2pbo4RV9GzbEVUQ7YkJN6efpL/yQAaehir6RkgpaGrAaShe3RXtIpKJ00L45mzqsrO+u7eZeJSgU6KDi613j8KmTzbDHAjxc/s+wHcNFrKgXTyXwID7sknmV17UpxJMj5d1QGLLFwkEb+MDTOYPHKIFhBSz07CgVRLyLirSyvq/ptDv8BNXxeHwFBCwkHBh8RJ9OArDeyXdz90YjqvZJUJMFOdNVtXOGQUezcd03Pg8f4GjtkIivkCqFmmHmCUa+NWdKOBJey4l3hLkXJeJsYNeqX+OlHmEsyD4QOzCaJn42Mw7wuka1uAXSw4KBe7amFrTLrkpPDltUClaeFSRYpVGGhBRWCPJ9JgELArQg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(316002)(54906003)(83380400001)(6506007)(38100700002)(508600001)(8676002)(186003)(6486002)(5660300002)(66476007)(66556008)(66946007)(4326008)(86362001)(33716001)(6916009)(6666004)(85182001)(2906002)(8936002)(82960400001)(26005)(6512007)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0d2UzJoRUprTGJXVGRUek5qaHVUSjBKZXNqRnE5VWxzZ2x6WVBTYkdxM2hR?=
 =?utf-8?B?eFZjUCt2ZGdwMG5GVDhsYmZHUy9rc3AzT3MwdG10WG1lTWQxYU5US1piTkht?=
 =?utf-8?B?Njg5Tm9NSHdmNEFKN0c4cmJFZmtOQTd4MTVaMjZDSVhvUlZvQ3ZSZHlTUXBS?=
 =?utf-8?B?d0t0UVk1Z2NJZHFldFpFVll3Ynp3cFJpMzV1V3FVdFdRRlhVdjcyY1VpbjBK?=
 =?utf-8?B?Y0IyNVJ6VHh6R2RVYnFQZG5CbUNWMUlqK3ZMMWhUTEpwVCtoMzNiWGFRV283?=
 =?utf-8?B?NkpVelg2YjZUNmRGNGEwQXlXZFBBTHdvc2NoOHJYREhqMjJlSGIxanFrQXFo?=
 =?utf-8?B?MmNNWnhBVkp5QUxhNWJGSTlwU0xDWmlOdlZyNmh0RjEzYnN4TlVRVE5NRmtB?=
 =?utf-8?B?V3lFbGZqWDdDOGc1Y3k0K2dkcnhYVTQxRTNLWkdxelE5cDFnYmhtN3loSDZV?=
 =?utf-8?B?NGk1V3FwQS9xcm5LYUNXWjF0YTBpQTlTdVd1ZUNUai9veW5ERnNwK3NvbVp4?=
 =?utf-8?B?Sit5aTFoTkRLcUhyTVJNN0JLb3ZIdGpCTHNKTzJTNWwvbldCQ2FhQ3pRMGxR?=
 =?utf-8?B?NFpQd2hFZjFVYXI0RDgwdm9UKy9YMVpIZzVVa0FPd3p6YVpCVUo3K0lCd0dU?=
 =?utf-8?B?R29ZWVVPNjd6T1dYMzZxbFZxV1pib29DZnFDYU14NHpTZzhnWUQzMVRKWmFC?=
 =?utf-8?B?VXduSVRadDFtczg2alFudWp6TERNWEZtdVdDNEY5RmNyaS81cGU2K2Jza05G?=
 =?utf-8?B?Y0UyN3FOUS9uRHpOOVVQZmR2VENaNUJrQTFzUElJRVZqNmp3N3FobktudEVn?=
 =?utf-8?B?UG02SG4xeDlxNnhBUTFSUm5lcTVvS0tSOFNJSXVvYnI5djBCZmhXVkxtL1FX?=
 =?utf-8?B?S0pPQlU0YmlyMUpMTzdhMHMxMis2cjIxR0dxZERZRDkxT3N5UXdFQTNEYU5S?=
 =?utf-8?B?dkVHNkFsSkljc1JoczRhaXlqNTJHNEhIMkQwTE9sbTAzNXQ1V3FWYnlJL0pv?=
 =?utf-8?B?b1ZEbklpZUlRcDc0OWlrelV5WmdlWUZzanY0cjcxNzRKMXdTOTZDSmVxMDk5?=
 =?utf-8?B?bjhMbklVZHo1eHU1bmgydmNhWGQvOTlwWDNlNlFVMGMxb1hmQyt3aFQyVUNt?=
 =?utf-8?B?Z0FRbUxLeWZReFRsMUk1U2tnS0t2ZXM1c2dHTk9RNldXN1dKVGlJU0IwTmJj?=
 =?utf-8?B?V0hQNC9kNUZQK0Y0bVZLdmh3Z085UGFyQWFjejBXR2M4bjRtWWRKWFVBbTVk?=
 =?utf-8?B?aWJBbUZGQkcxWjZrV0QrS1l3R2ttYXpENmpSc09kTHpHZE55dlk3bE1lM0Fu?=
 =?utf-8?B?VHhzY0Z6aWpYSUc2SDUyUmJzeTgxMlJ0SmVkSnRXMEtvaFRoYTYyVW4zOFJi?=
 =?utf-8?B?ODdXU2U4WklsZmRCUjZEeTdsc1RvM1VST2xpaEVkOHNGb0pDZWJ4RlFBaVYw?=
 =?utf-8?B?VGVjVW41TlU0U3RWWDZackxsUEFhVERkeWF5YkJxZ3ZjWkV6dEF1c2V6VkUx?=
 =?utf-8?B?bUo1OTlqNjZINDFydHV2dFFlY0lUZlBwZnNJVUdJcjhKb0tIWEFNYUJjMk9u?=
 =?utf-8?B?V25RTWVDSjZna1NXb1I3bmd2K2ptK3ZQZkJhQWYza0RNbktWQzdMZjlxZ3li?=
 =?utf-8?B?RzFZc1VDd1BkWnhDdlo1YWNEWHBPTjkvb2tRSVVZc2k3Y28vMG8vQlFLUHNG?=
 =?utf-8?B?STJwVUREdUFOUGYvRnRXNmU1NzhzZ3RPYUhUSS9vZ01hOFUxa1p2U0gxUHFv?=
 =?utf-8?B?N0JnUzZxQ3JkRSs1clhhc0lDa0RFenJQSWp2aGxnTk9IVlQ3UE1vS2x4Qm4z?=
 =?utf-8?B?SkZJVEtjYlBxRlZxSWtqTkRwKzZyOVpUeUJOTU4vUzl3VXZNWk1PR3FiSERW?=
 =?utf-8?B?YkZhaDlUYnl6WVhxaTA2TG1MMGFmRjZBUG00blVwbldRcGtUM1V1SDdSMlg0?=
 =?utf-8?B?L3JPQ3l0aExMdmJ1LzNNbE9hWVFmS05KYmtJbCtHMzQrb2I0VWw0SWhzR1pq?=
 =?utf-8?B?MnhjYTRCcUJIRkRJUG1sTXBwQXptajNEVkx5YjVPejczOW9IcFkxcTc2ZFRD?=
 =?utf-8?B?SG5sRWtkMWYyRDlxY2gwN2YzRWl1SUozbXV4bWV4TmE0QW1aRHduSzZPRTNo?=
 =?utf-8?B?eWEyT3pmRFRiYk9QU1NzK1lXdDhoVk5YcTFiREJqTlRWS1kzMm1iM05vZ0xH?=
 =?utf-8?Q?Xcy9d4hf9vrb05IBtiCdK1w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cdf67072-7f00-4909-dc34-08d9bf1125e0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 14:51:02.4251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: djoAsfjemz6Q5mF16jcIxij0w6r2WgGRQTuhBGV0eVB/QsU66qU3ucW0A08IU2no+Obo787TCpsFXEw4VmgyYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3481
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> Page table are used for two purposes after allocation: They either start
> out all empty, or they get filled to replace a superpage. Subsequently,
> to replace all empty or fully contiguous page tables, contiguous sub-
> regions will be recorded within individual page tables. Install the
> initial set of markers immediately after allocation. Make sure to retain
> these markers when further populating a page table in preparation for it
> to replace a superpage.
> 
> The markers are simply 4-bit fields holding the order value of
> contiguous entries. To demonstrate this, if a page table had just 16
> entries, this would be the initial (fully contiguous) set of markers:
> 
> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
> 
> "Contiguous" here means not only present entries with successively
> increasing MFNs, each one suitably aligned for its slot, but also a
> respective number of all non-present entries.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Obviously this marker only works for newly created page tables right
now, the moment we start poking holes or replacing entries the marker
is not updated anymore. I expect further patches will expand on
this.

> ---
> An alternative to the ASSERT()s added to set_iommu_ptes_present() would
> be to make the function less general-purpose; it's used in a single
> place only after all (i.e. it might as well be folded into its only
> caller).
> ---
> v2: New.
> 
> --- a/xen/drivers/passthrough/amd/iommu-defs.h
> +++ b/xen/drivers/passthrough/amd/iommu-defs.h
> @@ -445,6 +445,8 @@ union amd_iommu_x2apic_control {
>  #define IOMMU_PAGE_TABLE_U32_PER_ENTRY	(IOMMU_PAGE_TABLE_ENTRY_SIZE / 4)
>  #define IOMMU_PAGE_TABLE_ALIGNMENT	4096
>  
> +#define IOMMU_PTE_CONTIG_MASK           0x1e /* The ign0 field below. */

Should you rename ign0 to contig_mask or some such now?

Same would apply to the comment next to dma_pte for VT-d, where bits
52:62 are ignored (the comments seems to be missing this already) and
we will be using bits 52:55 to store the contiguous mask for the
entry.

> +
>  union amd_iommu_pte {
>      uint64_t raw;
>      struct {
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -116,7 +116,19 @@ static void set_iommu_ptes_present(unsig
>  
>      while ( nr_ptes-- )
>      {
> -        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
> +        ASSERT(!pde->next_level);
> +        ASSERT(!pde->u);
> +
> +        if ( pde > table )
> +            ASSERT(pde->ign0 == find_first_set_bit(pde - table));
> +        else
> +            ASSERT(pde->ign0 == PAGE_SHIFT - 3);

You could even special case (pde - table) % 2 != 0, but this is debug
only code, and it's possible a mod is more costly than
find_first_set_bit.

> --- a/xen/drivers/passthrough/x86/iommu.c
> +++ b/xen/drivers/passthrough/x86/iommu.c
> @@ -433,12 +433,12 @@ int iommu_free_pgtables(struct domain *d
>      return 0;
>  }
>  
> -struct page_info *iommu_alloc_pgtable(struct domain *d)
> +struct page_info *iommu_alloc_pgtable(struct domain *d, uint64_t contig_mask)
>  {
>      struct domain_iommu *hd = dom_iommu(d);
>      unsigned int memflags = 0;
>      struct page_info *pg;
> -    void *p;
> +    uint64_t *p;
>  
>  #ifdef CONFIG_NUMA
>      if ( hd->node != NUMA_NO_NODE )
> @@ -450,7 +450,28 @@ struct page_info *iommu_alloc_pgtable(st
>          return NULL;
>  
>      p = __map_domain_page(pg);
> -    clear_page(p);
> +
> +    if ( contig_mask )
> +    {
> +        unsigned int i, shift = find_first_set_bit(contig_mask);
> +
> +        ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) == PAGE_SHIFT - 3);
> +
> +        p[0] = (PAGE_SHIFT - 3ull) << shift;
> +        p[1] = 0;
> +        p[2] = 1ull << shift;
> +        p[3] = 0;
> +
> +        for ( i = 4; i < PAGE_SIZE / 8; i += 4 )
> +        {
> +            p[i + 0] = (find_first_set_bit(i) + 0ull) << shift;
> +            p[i + 1] = 0;
> +            p[i + 2] = 1ull << shift;
> +            p[i + 3] = 0;
> +        }

You could likely do:

for ( i = 0; i < PAGE_SIZE / 8; i += 4 )
{
    p[i + 0] = i ? ((find_first_set_bit(i) + 0ull) << shift)
                 : ((PAGE_SHIFT - 3ull) << shift);
    p[i + 1] = 0;
    p[i + 2] = 1ull << shift;
    p[i + 3] = 0;
}

To avoid having to open code the first loop iteration. The ternary
operator could also be nested before the shift, but I find that
harder to read.

> +    }
> +    else
> +        clear_page(p);
>  
>      if ( hd->platform_ops->sync_cache )
>          iommu_vcall(hd->platform_ops, sync_cache, p, PAGE_SIZE);
> --- a/xen/include/asm-x86/iommu.h
> +++ b/xen/include/asm-x86/iommu.h
> @@ -142,7 +142,8 @@ int pi_update_irte(const struct pi_desc
>  })
>  
>  int __must_check iommu_free_pgtables(struct domain *d);
> -struct page_info *__must_check iommu_alloc_pgtable(struct domain *d);
> +struct page_info *__must_check iommu_alloc_pgtable(struct domain *d,
> +                                                   uint64_t contig_mask);
>  void iommu_queue_free_pgtable(struct domain *d, struct page_info *pg);
>  
>  #endif /* !__ARCH_X86_IOMMU_H__ */
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 14:53:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 14:53:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246803.425622 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9As-0001BJ-GZ; Tue, 14 Dec 2021 14:53:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246803.425622; Tue, 14 Dec 2021 14:53:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9As-0001Ai-AV; Tue, 14 Dec 2021 14:53:02 +0000
Received: by outflank-mailman (input) for mailman id 246803;
 Tue, 14 Dec 2021 14:53:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Ar-00017n-1C
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Aq-0001ef-Vh
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:00 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Aq-0006sd-Uc
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:00 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mx9AU-00022D-1i; Tue, 14 Dec 2021 14:52:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:
	MIME-Version:Message-Id:Date:Subject:Cc:To:From;
	bh=sL/tFxUW5cMsBZucpfT8NrbTO2W9KHagvOGWHLKC/Pg=; b=cU5bjWUykB2Mkw4mtiZ7sst4SA
	pS7kKlxxXPM9/odW3nJ5DSlvE02Pugfz8R6Escnf8oPVVckRPDhQxE1DxP8NdHF+7bwqngOpTFqdb
	dOk5sK6Kr3id7V1Qa3Hp6vrbmHi3RSHeUxXqCQ/IRGmZe4/LlCOg1Fwe5RX9xdWUmYj0=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [OSSTEST PATCH 1/2] daily-cron-email-{play,adhoc}-*: Drop Citrix email
Date: Tue, 14 Dec 2021 14:52:25 +0000
Message-Id: <20211214145226.2248-1-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Any such adhoc flights run from cron should be reported to
osstest-admin, not my (soon to be deleted) Citrix adddress.

Now the only remaining occurrences are
  - examples
  - authorship annotation of the init script
  - crontab-cambridge, which would need updating

CC: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 daily-cron-email-adhoc                | 2 +-
 daily-cron-email-adhoc-bisectcomplete | 2 +-
 daily-cron-email-adhoc-bisectdone     | 2 +-
 daily-cron-email-adhoc-bisectrun      | 2 +-
 daily-cron-email-play                 | 2 +-
 daily-cron-email-play-bisectcomplete  | 2 +-
 daily-cron-email-play-bisectdone      | 2 +-
 daily-cron-email-play-bisectrun       | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/daily-cron-email-adhoc b/daily-cron-email-adhoc
index d2028d928..d67754523 100644
--- a/daily-cron-email-adhoc
+++ b/daily-cron-email-adhoc
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-adhoc-bisectcomplete b/daily-cron-email-adhoc-bisectcomplete
index d2028d928..d67754523 100644
--- a/daily-cron-email-adhoc-bisectcomplete
+++ b/daily-cron-email-adhoc-bisectcomplete
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-adhoc-bisectdone b/daily-cron-email-adhoc-bisectdone
index d2028d928..d67754523 100644
--- a/daily-cron-email-adhoc-bisectdone
+++ b/daily-cron-email-adhoc-bisectdone
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-adhoc-bisectrun b/daily-cron-email-adhoc-bisectrun
index d2028d928..d67754523 100644
--- a/daily-cron-email-adhoc-bisectrun
+++ b/daily-cron-email-adhoc-bisectrun
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-play b/daily-cron-email-play
index d2028d928..d67754523 100644
--- a/daily-cron-email-play
+++ b/daily-cron-email-play
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-play-bisectcomplete b/daily-cron-email-play-bisectcomplete
index d2028d928..d67754523 100644
--- a/daily-cron-email-play-bisectcomplete
+++ b/daily-cron-email-play-bisectcomplete
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-play-bisectdone b/daily-cron-email-play-bisectdone
index d2028d928..d67754523 100644
--- a/daily-cron-email-play-bisectdone
+++ b/daily-cron-email-play-bisectdone
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
diff --git a/daily-cron-email-play-bisectrun b/daily-cron-email-play-bisectrun
index d2028d928..d67754523 100644
--- a/daily-cron-email-play-bisectrun
+++ b/daily-cron-email-play-bisectrun
@@ -1 +1 @@
-To: ian.jackson@eu.citrix.com
+To: osstest-admin@xenproject.org
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 14:53:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 14:53:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246802.425616 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9As-000188-5G; Tue, 14 Dec 2021 14:53:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246802.425616; Tue, 14 Dec 2021 14:53:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9As-000181-2P; Tue, 14 Dec 2021 14:53:02 +0000
Received: by outflank-mailman (input) for mailman id 246802;
 Tue, 14 Dec 2021 14:53:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Ar-00017o-1C
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:01 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Aq-0001eh-W2
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:00 +0000
Received: from iwj (helo=mariner.uk.xensource.com)
 by xenbits.xenproject.org with local-bsmtp (Exim 4.92)
 (envelope-from <ijackson@chiark.greenend.org.uk>) id 1mx9Aq-0006se-Uw
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 14:53:00 +0000
Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk)
 by mariner.uk.xensource.com with esmtp (Exim 4.89)
 (envelope-from <ijackson@chiark.greenend.org.uk>)
 id 1mx9AU-00022D-Ae; Tue, 14 Dec 2021 14:52:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:
	MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From;
	bh=bQCwcqRFVfQqb2XI4XqFeSRt/U/1Sd9ionlY70addAk=; b=ZERjAsUqGH945CWig1FxB9Lsm5
	ah51ZJCl7RruubkVvFa1/8e/ZMccF/qND0LNq9X4E3xrWCpycSir1KZUSqNpUjyhQvtCETE17RzUG
	we9UR8O8zpOUvOmcuFUGhXvWmbsyvJ9SIEAOvi36oQw0XTstcONS9oIdgh8Um7sDbcX0=;
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [OSSTEST PATCH 2/2] daily-cron-email-real-*: Temporarily drop osstest-admin
Date: Tue, 14 Dec 2021 14:52:26 +0000
Message-Id: <20211214145226.2248-2-iwj@xenproject.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211214145226.2248-1-iwj@xenproject.org>
References: <20211214145226.2248-1-iwj@xenproject.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Roger has agreed to take on osstest admin for the moment.  Someone who
intents to take on the role long term will probably want to get CC's
of these flight reports, but it's fairly noisy.  So for now, send them
only to the lists.

CC: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 daily-cron-email-real                | 3 +--
 daily-cron-email-real-bisectcomplete | 3 +--
 daily-cron-email-real-bisectdone     | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/daily-cron-email-real b/daily-cron-email-real
index a52fe680c..743074c60 100644
--- a/daily-cron-email-real
+++ b/daily-cron-email-real
@@ -1,3 +1,2 @@
-To: xen-devel@lists.xenproject.org,
-    osstest-admin@xenproject.org
+To: xen-devel@lists.xenproject.org
 Bcc: osstest-output@lists.xenproject.org
diff --git a/daily-cron-email-real-bisectcomplete b/daily-cron-email-real-bisectcomplete
index a52fe680c..743074c60 100644
--- a/daily-cron-email-real-bisectcomplete
+++ b/daily-cron-email-real-bisectcomplete
@@ -1,3 +1,2 @@
-To: xen-devel@lists.xenproject.org,
-    osstest-admin@xenproject.org
+To: xen-devel@lists.xenproject.org
 Bcc: osstest-output@lists.xenproject.org
diff --git a/daily-cron-email-real-bisectdone b/daily-cron-email-real-bisectdone
index 50dc9cde3..1eb6909c6 100644
--- a/daily-cron-email-real-bisectdone
+++ b/daily-cron-email-real-bisectdone
@@ -1,2 +1 @@
-To: osstest-admin@xenproject.org
-Bcc: osstest-output@lists.xenproject.org
+To: osstest-output@lists.xenproject.org
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:05:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:05:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246812.425638 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9N0-0003Mk-HW; Tue, 14 Dec 2021 15:05:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246812.425638; Tue, 14 Dec 2021 15:05:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9N0-0003Md-EQ; Tue, 14 Dec 2021 15:05:34 +0000
Received: by outflank-mailman (input) for mailman id 246812;
 Tue, 14 Dec 2021 15:05:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9Mz-0003MX-BI
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:05:33 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 480b3dde-5cef-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 16:05:32 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-7Fvbs2vmPoaQMb7XzMBq6w-1; Tue, 14 Dec 2021 16:05:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2446.eurprd04.prod.outlook.com (2603:10a6:800:4e::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.15; Tue, 14 Dec
 2021 15:05:29 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:05:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 480b3dde-5cef-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639494331;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OyJ+Wbqp164NKnahUrTP17xVfBzStMIpJ8JrKNVysVQ=;
	b=QBEX5PUvIdgupVgRwZHD4KZ2nxDGGpv5ftEQxu/V8Do4zWWHgfE+uD0UW+oy6OR+Jjn7/D
	gJW/TYcMCIw0vXHqjBtX0+Tk9pn/d8i0wPGdvNcx/MhM/0dCXnqdbra+fMAfsFy3BcsyD7
	eC8DbW4/loOR5avaUZSM5bzx2BDYrcY=
X-MC-Unique: 7Fvbs2vmPoaQMb7XzMBq6w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e0mg2JjXLXDD7HE53879p1t60/oMhZ595EzxAOIgu4dLKvWRzuH9o69RjllXDBtqMSAB/pAlGU9Zu2Q+9IiNJY0ReEHVn9T6aOO7sXOj6+3aVnFLOZpFZnkLIVSPFHFPnqOko3wEHPoZfyz1keCynMknW7MnVCIu07GsPkpZEdIfOvbzaFte0l9wjOKICEjZp3Epa0IQh0xHkbFOUn3dHKrFfAeDOHjRTGSSBvG53PsF/e0zyKwemTj7Sd3MMwMK+Cp+ob+nFNab1YF9Xh1HTihv9fsVYFNnryIDrnVpcIyfIijkpcmnDpKnNPlBOC8W79NA3OFu6LVIDd8hFeOnQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vTLdYKmzRkDQfscq7wXpk9Qe9lHGXyErjVwWdJjcN/o=;
 b=JJsEdG4PPXScyqVF+fY62UtK3DWvlxcP85vQAJOXXO3efDCfeZ6v3btfPEzg2CzheEFNxMvbhbp/YFBlGpHQb6lNr0o++fyCwRUFtvv3XVNRiGyXgUQdKTuRFgLa539xkzEMsfPa7WYzoZGwH0U6UKcGT+QCLFpi8u0C0upm7JjoWaquperHfZ6B7yV6jso9DLl3XgC3Rz+VIgEuxzSY+dff7wUUDDdThIp++lkzLPwb+7+mpDg31mDh9E0/eRla1GvoxtFW8Auw0ky5QCL3Mn4A3Le5h8egH1XrcyrBOJKWK54ROHTC4NW8nX0GfWriqY7UuOAMadZtA339bTkt2w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <fb221da6-2ad5-e298-c582-364943b95198@suse.com>
Date: Tue, 14 Dec 2021 16:05:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbivUH/Er0o2PwsG@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbivUH/Er0o2PwsG@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0701CA0067.eurprd07.prod.outlook.com
 (2603:10a6:203:2::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e316d130-3e2d-4e39-6d52-08d9bf132a8f
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2446:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB24462A77166A76ADCA1592B0B3759@VI1PR0401MB2446.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Gmu6Gxz8BgYmsyF2CgHshFp6xp9impx3f/afkUqwqEXXzbGkj/Gt3TX+Og25OpxypTlqw27wTx39p2hqc9ho4w44SYDuwxMlCwiaDQyrkVIeYv9e0KSsuWGQztaiA51q6QM7HWjBp1+/5MYLQCrKtmSYevPS/+BAjezEa5bk08tPbjQuKukT33+lbpz8EoKjCXUt+z4sNf4Xeq+2+Bay15iIj6+OH/j6Nsx+TM0Ix94QGwyIFYwOmu6R4lV53xlG0KcmmnWwyekB2EABQkms34Mt27tGBEL78ssytMDcU7GbRPaKzgL9zRnVM5xjiliYDxP8OaiHeCpOAqGnCThX8Pqp5gAYswI/InQoN92WTeAiC01FVcqkHW4hxKnexD+Ys5fCNesyrjBi4Tq+/6B38tgb+pzS9KHaZwAB/0lU5/zmRwbd2+1KCcFc1JSioaNy7g3IUADkVQlf6Oujj+HqXPB1IcwRdGL7xnceptdXDtnGj4Vd2rr4oWr0G8WhKoNn+8QVKKt5A0rg0i+DleVHZIikAUg9nVkIyOk2wwSJvqIt8HAfW4fU7vZLiD0j9fm0fev34GSpXZNModtf9dWhSCNwzWA5i1pIOVUvLIYCFoo9yHJsF6t/iAxhWs8LG2IcmdG+ZgtYKeuQ7aJd4CkGDWwSjDZHV3OjiucJvY6Ugps/o8BpcYuJYZ6CxqorlPqqMUFhfkLUgTr2ruvg2sV2VuEJcA72Cj32fm92JP0to+c=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(8676002)(31696002)(508600001)(4326008)(2906002)(66476007)(6916009)(66946007)(66556008)(31686004)(2616005)(54906003)(316002)(38100700002)(83380400001)(5660300002)(26005)(36756003)(186003)(6486002)(6506007)(53546011)(86362001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?u9zjwjsKDdPYgxFPv1b07/ABt8YZBVkFkWDlM9Cag/OvWecaIIWz4J/kKuz8?=
 =?us-ascii?Q?ews/ctn4fHE5Mlm8P8kJVviCjb0RF3FA4dXNaUvpENdS7urgV8RGJarv/Hxi?=
 =?us-ascii?Q?3tv0pT89prObh5kUibbrNyBIK8rqVpEgqJzGjfSPhX3JJo9+OeqV9NxqD7qe?=
 =?us-ascii?Q?rDyRqObye/otPx9fimrsbaiY/X0dnJB89j9XqdL1jOYlqrrny/Z/yyKVwOgc?=
 =?us-ascii?Q?J/xg8JHQoYs5rbrZdA7SunfpAFY+xU1vTF7+3TRwFHvbx9aUtB3Y8zAQUcMF?=
 =?us-ascii?Q?3L6I5y0X9NefBJvsNMPEDYBN8iApcBybHjpuQ+Nd4SqOC0vTTGsBNtgtSda5?=
 =?us-ascii?Q?vanfLJjjqWg4Ou8n3yojJ+nM4BAjDXsgWqbv6rpyIeZ7lUD8ceRAeN3WsJNw?=
 =?us-ascii?Q?3Er/XYfxbJDGhVWc+wYXiRGo5xyPS+yJhD5dd5VebpXXBv3ppjA0tTfW1oBs?=
 =?us-ascii?Q?ACBAJTtWJZNTZQ4qKJmP0PMMrFf+hFkNN3E/fsD2QgUkgmNpiVRPEjlM5hJM?=
 =?us-ascii?Q?HRB/D/Kpr/CxmUd2qyViMWW5xzSVY2X746Vzo97BYQLKCXELpkWkdfS16htR?=
 =?us-ascii?Q?qlLixuwcxusrXyegGe6uiwDrV6aEdws7mG44Puae4XP58vJ5WA4AUA1Bm162?=
 =?us-ascii?Q?RVJwdVfl6TTRw04s1p70kiW7IxLbqAwXaVGquESzzCv+UQtrlAHXe1GqZusV?=
 =?us-ascii?Q?+exI2/5cVP5IwQjg+5d+tE/d5zklK93KlG7QG6Pz9mCddo3JOABaZHJ9NN3c?=
 =?us-ascii?Q?l/lHPQ4YRHoyj0Lovqf1mZ4x9ptozDgPJ0WiXQru9WTsM+pI3ZcidIDsBAmF?=
 =?us-ascii?Q?MX4UnvLCkM1PH22VrDeNe2PmJQ7EkRi1gD1d1JcdgtkozeMXvVPKOFwn/qEO?=
 =?us-ascii?Q?1MP6gR4/tAZk5PZp7m8Xvh+JClMO0K3vUIOry9qolCxIWUKRrghHcG5KtBLz?=
 =?us-ascii?Q?nu+aepG98Rvs/T2hY6frsJJmPj4fYtDH5bn71nGRA9WOEqYSzh9qCcmh4JhQ?=
 =?us-ascii?Q?xwZrhRsOXqFV4cFKDOp2MpTFIIqQu2oSCUxzdrSIVzZmbSVNpv5wDb0SP6zI?=
 =?us-ascii?Q?Y/iHvVcoo8NjFfqJOdvI5DFYhq2O9zlAYIRuPac/NJrK9RLTpYPRN3t98b0i?=
 =?us-ascii?Q?HLUMxPqZgIiSdINupjsl4986QdmTAHQ2uHeCH6JyucasgaBLiP6QflVDbkFF?=
 =?us-ascii?Q?pvK5iax/bVrT36Ty8eVnpKPDsRQ6Y0I9Z+jaxMM0bIhZci2vvfhrKU4wt5Bc?=
 =?us-ascii?Q?A8uQfZaSLxbn99XhHqEAX6H+pwSg8zYMg85i7m1u80MtyRUYPcag9YgWMHYZ?=
 =?us-ascii?Q?TIxgbqoQb/T6fjq1EE2XetxQGjNmCMNaPLQECfVnYup2qZF9r2KoEXn67h4e?=
 =?us-ascii?Q?cOCZK3rPZtCjQTCQhDl53weoRZEb4lO2zzmBd3k3BPyNc+xTDuhcapI185gx?=
 =?us-ascii?Q?ck7dqR4qySi+00dYaBAoaT7LgGWV0U26ZQSNKannMC6tpCtB7lGQ3v6ipQ5g?=
 =?us-ascii?Q?BoNkHDqroMlZmtvdHkidIzF10HyLpvpJMa6rjzz0XH2+WMDuqaCv41kCX3Zy?=
 =?us-ascii?Q?eTBgS1k5Z5yhjOybKYwv085u/vp6sWRhYnnZht7wsotwUq4lyJFKw5DGugmx?=
 =?us-ascii?Q?108vNNnuaDkryMmRbVl3h6w=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e316d130-3e2d-4e39-6d52-08d9bf132a8f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:05:29.0051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: myAhpSR8RTSrQux/nRrwhAJn63bdkfKZVFa0xurxQmqrNhyALbZeZdZ333R53HWNYoSw7NsSr7CG+5y7oH1MSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2446

On 14.12.2021 15:50, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>> Page table are used for two purposes after allocation: They either start
>> out all empty, or they get filled to replace a superpage. Subsequently,
>> to replace all empty or fully contiguous page tables, contiguous sub-
>> regions will be recorded within individual page tables. Install the
>> initial set of markers immediately after allocation. Make sure to retain
>> these markers when further populating a page table in preparation for it
>> to replace a superpage.
>>
>> The markers are simply 4-bit fields holding the order value of
>> contiguous entries. To demonstrate this, if a page table had just 16
>> entries, this would be the initial (fully contiguous) set of markers:
>>
>> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
>> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
>>
>> "Contiguous" here means not only present entries with successively
>> increasing MFNs, each one suitably aligned for its slot, but also a
>> respective number of all non-present entries.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
> Obviously this marker only works for newly created page tables right
> now, the moment we start poking holes or replacing entries the marker
> is not updated anymore. I expect further patches will expand on
> this.

Well, until there's a consumer of the markers, there's no need to
keep them updated. That updating is indeed going to be added in
subsequent patches. I've merely tried to split off pieces that can
go one their own.

>> --- a/xen/drivers/passthrough/amd/iommu-defs.h
>> +++ b/xen/drivers/passthrough/amd/iommu-defs.h
>> @@ -445,6 +445,8 @@ union amd_iommu_x2apic_control {
>>  #define IOMMU_PAGE_TABLE_U32_PER_ENTRY	(IOMMU_PAGE_TABLE_ENTRY_SIZE / 4=
)
>>  #define IOMMU_PAGE_TABLE_ALIGNMENT	4096
>> =20
>> +#define IOMMU_PTE_CONTIG_MASK           0x1e /* The ign0 field below. *=
/
>=20
> Should you rename ign0 to contig_mask or some such now?

Not sure. I guess I should attach a comment linking here.

> Same would apply to the comment next to dma_pte for VT-d, where bits
> 52:62 are ignored (the comments seems to be missing this already) and
> we will be using bits 52:55 to store the contiguous mask for the
> entry.

Same here then.

>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -116,7 +116,19 @@ static void set_iommu_ptes_present(unsig
>> =20
>>      while ( nr_ptes-- )
>>      {
>> -        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
>> +        ASSERT(!pde->next_level);
>> +        ASSERT(!pde->u);
>> +
>> +        if ( pde > table )
>> +            ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table));
>> +        else
>> +            ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3);
>=20
> You could even special case (pde - table) % 2 !=3D 0, but this is debug
> only code, and it's possible a mod is more costly than
> find_first_set_bit.

Not sure why I would want to special case anything that doesn't need
special casing. The pde =3D=3D table case needs special care because there
find_first_set_bit() cannot be called.

>> @@ -450,7 +450,28 @@ struct page_info *iommu_alloc_pgtable(st
>>          return NULL;
>> =20
>>      p =3D __map_domain_page(pg);
>> -    clear_page(p);
>> +
>> +    if ( contig_mask )
>> +    {
>> +        unsigned int i, shift =3D find_first_set_bit(contig_mask);
>> +
>> +        ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) =3D=3D PAGE_=
SHIFT - 3);
>> +
>> +        p[0] =3D (PAGE_SHIFT - 3ull) << shift;
>> +        p[1] =3D 0;
>> +        p[2] =3D 1ull << shift;
>> +        p[3] =3D 0;
>> +
>> +        for ( i =3D 4; i < PAGE_SIZE / 8; i +=3D 4 )
>> +        {
>> +            p[i + 0] =3D (find_first_set_bit(i) + 0ull) << shift;
>> +            p[i + 1] =3D 0;
>> +            p[i + 2] =3D 1ull << shift;
>> +            p[i + 3] =3D 0;
>> +        }
>=20
> You could likely do:
>=20
> for ( i =3D 0; i < PAGE_SIZE / 8; i +=3D 4 )
> {
>     p[i + 0] =3D i ? ((find_first_set_bit(i) + 0ull) << shift)
>                  : ((PAGE_SHIFT - 3ull) << shift);
>     p[i + 1] =3D 0;
>     p[i + 2] =3D 1ull << shift;
>     p[i + 3] =3D 0;
> }
>=20
> To avoid having to open code the first loop iteration.

I could, but I explicitly didn't want to. I consider conditionals
inside a loop which special case just the first (or last) iteration
quite odd (unless they really save a lot of duplication).

> The ternary
> operator could also be nested before the shift, but I find that
> harder to read.

If I was to make the change, then that alternative way, as it would
allow to avoid the addition of 0ull:

    p[i + 0] =3D (i ? find_first_set_bit(i)
                  : PAGE_SHIFT - 3ull) << shift;

I could be talked into going that route (but not the intermediate
one you've suggested).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:07:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:07:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246815.425650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9OU-000413-3u; Tue, 14 Dec 2021 15:07:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246815.425650; Tue, 14 Dec 2021 15:07:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9OT-00040v-Uo; Tue, 14 Dec 2021 15:07:05 +0000
Received: by outflank-mailman (input) for mailman id 246815;
 Tue, 14 Dec 2021 15:07:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx9OS-00040d-UR
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:07:04 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d920f7e-5cef-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 16:07:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d920f7e-5cef-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639494423;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=ibZGt/QLVSF0V8x3om5/gxxMTbcr9Wz8OcZ/SEqfFIo=;
  b=NTnoDYEUVPab1PDQ3doOOibjuK7t/QiGSYXC11GS61U1DFUiRYnWxG7w
   F2keqQnK+echgIM61Fw0k3e2BRm2uzv5Nctc1LfPdweJj7Pjte/TWIg/c
   qYupdZSsDPKunw4M9ePcC+WmvWtaWUxGvti53tjXsSmwFbHU6WFVdBk6n
   4=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 0bj0s8KdS9qKQ6pr/26AjE9pZXSNE1GZxOg4h5P2PlxZ3OTpUz7Mg9XLdT9QlayOQticaogUI6
 MwzZLCxA4dYZTvShkLsPJMvq8Q+MJCWoErmLj+XAvWM/P3E+ECE6e7on8oszqapyN5XETsqzMe
 y03CZp/0iJv3NuOwMkPv1bwl1F7CT+OQEfKovuHZa8tryXi6waCqp9FMwrijxzTIb8IZMl+QjZ
 RXwfRDjIS8f4Lz/RHhPN3qtDQwMsxXnoqdDJBzJsXJViDP/jWjjMlw6PxyLbFsjcjiFUXUehAt
 tyuOlb/pxiJNUby3MscJH8dv
X-SBRS: 5.1
X-MesageID: 60383985
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:gIF/4KN5Eqc3RHTvrR1TkMFynXyQoLVcMsEvi/4bfWQNrUoggjQCy
 WNMDTuDb67eYWD8ctpyOo2xp04H7MWHnNNkGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoy6rkM139
 tFLj4ShUwUnP6TnlfgkSDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uSvo8DjWdt7ixINcnaY
 /ULMj1mUDLRXTdOOXg4A60xmvj90xETdBUH8QnI9MLb+VP71AVs1JD9PdyTfcaFLe1Wk1iZo
 CTa/m3/KhAcKNGbjzGC9xqEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ
 koM4C0soKMuskuxQbHAswaQ+SDe+ERGApwJTrN8uFrlJrfoDxixHUoLUzh/bNocrN4sRzIr3
 3SEg+ryLGk62FGKck61+rCRpDK0HCEaK24eeCMJJTc4D8nfTJIb1UyWEIs6eEKhppisQGyrn
 WjWxMQrr+xL1ZZj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4
 Chsdyu2trlm4XSxeMqlGrpl8FaBvantDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib
 Sf74F0KtcMJZSP3M/AmM+pd7vjGK4C6SrwJsdiOMbJzjmVZLlfbrEmCm2bOt4wSrKTcuf5mY
 srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepUaDOmM7FihIvZ8Vq9z
 jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8riq8ZEKLbDafVI9cIzjYteIqY4cl0Vet/09vs/D/
 22nW18ez1z6hHbdLh6NZGwlY7TqNauTZ1phYkTA5H6khCouZ5iB9qAae8dldLUr7rU7n/V1U
 +MEa4OLBfEWEmbL/DEUbJ/cqo1+dUv02VLSbnT9ODVvLYR9QwHp+8P/ele9/ic5ESfq59A1p
 Ket112HTMNbFRhiFsvfdNmm00i14SoGgOt3UkaReotTdUzg/ZJEMSv0ivNrccgAJQ+anmmR1
 hqMAAderu7I+tdn/N7MjKGCjoGoD+ohQRYKQziFte67bHCI8HCizIlMVPezUQrcDG6kqr+/Y
 eh1zu3nNKFVllh9rIchQa1gyrgz5oWzquYCnBhkBnjCc3+iFqhkfiudxcBKu6BAmu1ZtA+xV
 h7d89VWI+zUasbsEVpXLws5dOWTk/oTn2CKv/gyJUz74g5x/aaGDhoOb0Xd1nQFIesnKp4hz
 McgpNUSul62hRcdO9qbijxZqjaXJXsaXqR77pwXDecHUObwJo2utXAENhLL3Q==
IronPort-HdrOrdr: A9a23:jklymKuTzu6I0KzsUF7bhnC07skC74Mji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkDuRYTzrdHGeKjM2YabQQ/
 Gnl7Z6TnebCD8qhoPRPAh2Y8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX212oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iHnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJMg4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAlqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocYTbqjVQGYgoBT+q3uYpxqdS32AHTq+/blnwS+pUoJjnfxn6ck7zI9HJFUcegy2w
 2LCNUtqFh0dL5nUUtKPpZ0fSKGMB29ffvyChPgHb3GLtBPB5ufke++3F0KjNvaDaDgiqFC36
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="60383985"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U3TtIs1OW8hcVPWtVg/IW+JZeaRJVCcG1Z4aHCIkj8h1W6jSsFowGS0j/Gm90tT14ue1uVN28lQApkFR5bOBDgPJhYt4OMqFgUaXBXmUzeMD1rplvofHdo50XrSyodgMecPrAHRBOiIKJx5xMkXKmWHvR6QAFy4iStP516offGcfPLXYZgStw0kN4SFGb0eZSRA6nr5oXRaDAwXww2fBIkGD5lXpt18Mc+TQtjQf1Phi12dHWeefoboAfUf5PJfiULeD2RHIQxKrLyPu/98U10ezpETiM5+MzI3yAQpO8rl6x9bxn1FPNd8WAEs8T0uGHVite+JRG1pAaSNpHCNUQw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XL5SZ5t1V2LttmnHb65odBicDHWtXodGq4MhIY5Si0g=;
 b=FLsbA3iKOBzz9PCaAFRAANTDI9coUXZbYZpVMlStHYshdr5iNFmnAXrZ8QtzTLKwEChnT7kism9M3BeFW0cg5Jot/oan/7piI+oOOfbeB2RToxwTZjQPYB6pQqSt2JFLJBs2wFpaZoZaxPLOQxHvtlJDnIaAJ7m5/+/iwPUZjNhHDhgn3o7SXSAJ/YfOiST9EngWty17KvuV/bavUhjoJ0GQSarAhxdUmPaouNeCNaa98bZkdKrkAbGNG2jlc1ECPEQOQyiHNJ5PQozHckcklyiUo0YodNE6iKMGKMBM8aTJ5LDwalj8+57p3tIatcsDdAFEgdinJEq/+tJra7CtSg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XL5SZ5t1V2LttmnHb65odBicDHWtXodGq4MhIY5Si0g=;
 b=RgpFNISoKImtJZmVNq0LVRaVO9CwtSj1XvHouERMK2RhxFoLmwc1EojbXWRTtwBGE7WRca/bawzc3VLnuaWswhuNX60BeNxZsFQpPpOIKC8ojWGgsBOC1kX47yrmJckOxJTfm1XSJVHSro4WVkP2Sq7izsvPbLldEyKu/YJWoiE=
Date: Tue, 14 Dec 2021 16:06:43 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <YbizA1adGRRIlcTv@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
X-ClientProxiedBy: MR2P264CA0061.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:31::25) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: daa93b5b-0dfe-42b0-2889-08d9bf1359b4
X-MS-TrafficTypeDiagnostic: DM6PR03MB3580:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB3580DB562A5543B90B3DECD98F759@DM6PR03MB3580.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1417;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: P/rs8AC3W/R3HXJzhxMpksyKUuvNk3gQr11RwQGjo88/7lrguHcDNJGml1QJ/9cwJYhFBzl3i+YAdJDV3U9e7rhc712xXNL/jeov/Y/LOFgQlpQPRXAUl3QOOf/8SQqXNewlQ/OQcktZc83OsmhIyvtsESB+351uPmsn9y9k4Q+GVuflyrscBl4NQvPZMu6rqn5hn0X5c+t9B8DK7SHXTYD+7yOJzBzkg3Gd+vBF76bSSKPKekY+cRRGndXfO9rIYgk0RTxeMDb6HFekW/dWlq7lSbJdm28JGi/PpKZ4A0oUs/Xzp+SJp0c9p0xHK0HLdGTzwDnqsztQ8ZEmsugtjdDadDr//JRNmvz5mB0FBqviJyv6itUx53J0xE9sD4BnD3QJtxHnYTla6xAzaaSiOTuHydbwgvjm2JTUyzpcYERESSzq0lLUZzkK9FRKvsGO3TiltFU5dtj4ybWrIpYXOhIRYrUYB7JBMNy7erUebPQ6M4My1rsZFHJcc1QIwOJIdXUK4edAavRORdihMAMrlPWPSwgXhsKtb2p9qkhQuFiKI2Fu+z7QPm05030cL0+/Bgmzvapo1wLnHw7ZDjZTAn6+sW5+dr/T4JWRRKrI4xBZkpu8G2xy4uV88IY4kEkp3wPgQb0H11E8bc5NfbLRMw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(82960400001)(508600001)(66946007)(86362001)(85182001)(8936002)(66556008)(8676002)(54906003)(316002)(2906002)(38100700002)(9686003)(66476007)(26005)(5660300002)(186003)(6506007)(6916009)(6512007)(4744005)(6666004)(4326008)(6486002)(33716001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDhuLzdNUGhIREY4cDJPeW1kWWkzT0doREgrb2krc0huNDhyNytvRi80MjZj?=
 =?utf-8?B?RStJS2xIbWlGRkgxQjZMN0NLWG5RTDZJOUh3OUF4Qy84WWNaa1phLys5bTFw?=
 =?utf-8?B?SnBxNG5mSWxTUFNYZHpyTzFMZFhBUnkvR0FLTVpQc1BXbkpCQUgydkphOUc3?=
 =?utf-8?B?WDA2bGlvVHRTemNISmpJcEhpWjVwQUh0VVlSZVpuZE91RmNUY1pLMjBtdFM5?=
 =?utf-8?B?VElnSk5SaDJHdW5ndVhZWkJNVS9oRjZpaUxEZjR0aWVmK3EzSHpNUTBiSWho?=
 =?utf-8?B?U3hla0NLdHhocHJsV3kwcUhQcFNpQTFxdCt4ZmRyZmR4ZVBKYUdhQVBqdHh1?=
 =?utf-8?B?bFYxWW9ObEdSWVFoSVYyZkxCRjh5RUhOdU1YRjJvbDJUbEtZdDZBbmxpY3dj?=
 =?utf-8?B?bVU5UWppc1NSMGpzeHRMNm9OcVNDb0RhUXJVVTd5dmRsdjAwZjdBVFJUWERw?=
 =?utf-8?B?Z1VoT0VYWDlOMmFNcGR1bittMHJnV1AxOXJ1cGhCRUhEd1ZJRzE5RDdTN0x2?=
 =?utf-8?B?QnVDeXQxTjhWQlAvRnc2cTA3V05CVlBIQXFXT010SERySDZaaC9FRndhdjZZ?=
 =?utf-8?B?T0dWMzAvSU5tcWN0YlhWcFRXUmF1aTY5eEY1TjJQN2p4UEFlT2R3cG1tVm9Q?=
 =?utf-8?B?cTkrN3AxeldkV0UzcUVOY2NBeXloWGRaZEJ5UDBjK2sraG01OVhId1lIZEpm?=
 =?utf-8?B?VVZMelFUaGtCcHdtMm1lczAya1MyZDhnNmQ1ZlkrMktkVWJTdVlEN0E0bllH?=
 =?utf-8?B?Y2RldXNmei8yQ3pST0JFcnZCdUpzK2t5VCtoU05saUl1UFVvcVIxeXlZdFhZ?=
 =?utf-8?B?Zmh4ZGtQeFltc2krcTFPVVFEWkpkcWxUSlM3ZUpXUithSHBwQ1ZsV0RpWW1S?=
 =?utf-8?B?M2VyelhsUVNpNUo5TUN2b1NEL25pcGVJK3ZtdVVnQnM5REJYaEt5TmpEeGEy?=
 =?utf-8?B?cmxmaml4ejV2TUNZQ214VmlLR0M4ZDdNVzBJV01RbjVmaGFTcm5rTDUrNWNi?=
 =?utf-8?B?MG8xQk8zVk5VbnJBdVd3L0pBeVArWlM3M1FETmoyTkdNc2t3MGNROXlnVHhz?=
 =?utf-8?B?SnFKdEhnVVp0MHlEcmR3Q2RxMDU5ZlhDUWlJQnhnUkJodjJpZ2JhMnQyT2E1?=
 =?utf-8?B?V0xNWmZ2alplSVY5VFNHLzlJODRQY0dRTFA2N29kSkdiM3BnWW5tN2tjbVlj?=
 =?utf-8?B?M0NGdm9pNTVvaGJSVFg5dmtxaU5oN2RxVi9VV3NydGw1SDZDUUc4RUJoMC9S?=
 =?utf-8?B?ODM0dUJHNm1qS3pNelBVeEdDREtsenhvaHg4Z0pValIrMktyL0oxUTRJRmYr?=
 =?utf-8?B?cDEzMnBBUEtTRlNSMGNINzVxZ1Vkc3p0UFZrZ2RSUHVoMVNFdnRFNnl0RUZh?=
 =?utf-8?B?YUNkbjhCQXAvNVRIRTN4S21UTjBBdjdHLzNTQVBlV3B3SkdOSFFWNXIxMGth?=
 =?utf-8?B?TjJsaXAxNXJSNEU0QlZnanZTMytrdS9VbTJtbEhWSTA4OFEwZjFWcDJkcjRH?=
 =?utf-8?B?MW5pNUtwMVhWa0M3VUdCVlJybnI1Y2dLZ1RZai9SNXVVSmxFUDJqWnd3eTMv?=
 =?utf-8?B?Yy9uVDBYRXNEaHAycXZwWTEvWmRpM2pPVFl5bVVQL3UrRy9uVHd1S2NUaWpE?=
 =?utf-8?B?d25wNm1vVXlyQU5xMVlDc0VLMG5DSTBiQVpIS1JURmRiOTBsZkdSNmMrMXBv?=
 =?utf-8?B?aE00RjdLN2QyL0JMaUpZeUFMR1ZQSCtMQ1ZuS21uaUljZSt4Vm90N29JTjdZ?=
 =?utf-8?B?TWhUMmx5bTFrUUtnTUpONTcvSXhpOVBCS09NblRvSklEQ3NtRlY4Y0xVUlFK?=
 =?utf-8?B?dy9wQmt1YWQweFNNZHJCUFZQNzU5U3FUclhPaVN3ZVRYemtZWndFMUhITFlH?=
 =?utf-8?B?QXppbXJJZWh4c3V2OUJ3c3hyNU9taUNrQU1mTG5BYTJNbG02RmsrWHd6SU5a?=
 =?utf-8?B?R2lrdVhMLzBHak52ZHdKYVdvK0tvc0E4SlBubjVlclU1dVIzUXFtQ2ViL01a?=
 =?utf-8?B?UC9oM1NoTFZ4V1RjekwzUGlRbWJwZVZ6SzhDbWJWcFpXOWdadHcwSjJ1Vmsw?=
 =?utf-8?B?eTRYQWtKZzVBOHh4QTV3UmhYWDhNYmxjUitwbEd5T3JTRGkzc2I5eEQ2aWVT?=
 =?utf-8?B?OWxKMjFiK1J3T0dwc21yV0JjbTFLL3pUeHhXVTRVZzVXY1lDMW5NZjN5V0xx?=
 =?utf-8?Q?OFKIFP05Dq91djfOemgKM1k=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: daa93b5b-0dfe-42b0-2889-08d9bf1359b4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:06:48.1133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rE1w5Mt9LpJEwWobizDuDvzrlg+m3/DMUglsmxc2t30YEOIPGSGjzHZnNujrT907JIZV5C2SKnYymSfdpF1vYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3580
X-OriginatorOrg: citrix.com

Forgot to comment.

On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -238,7 +238,7 @@ int amd_iommu_alloc_root(struct domain *
>  
>      if ( unlikely(!hd->arch.amd.root_table) )
>      {
> -        hd->arch.amd.root_table = iommu_alloc_pgtable(d);
> +        hd->arch.amd.root_table = iommu_alloc_pgtable(d, 0);

So root tables don't get markers setup...


>          if ( !hd->arch.amd.root_table )
>              return -ENOMEM;
>      }
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -297,7 +297,7 @@ static uint64_t addr_to_dma_page_maddr(s
>              goto out;
>  
>          pte_maddr = level;
> -        if ( !(pg = iommu_alloc_pgtable(domain)) )
> +        if ( !(pg = iommu_alloc_pgtable(domain, 0)) )

...likewise here.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:10:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:10:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246824.425660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Rs-0005Xz-IM; Tue, 14 Dec 2021 15:10:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246824.425660; Tue, 14 Dec 2021 15:10:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Rs-0005Xs-EJ; Tue, 14 Dec 2021 15:10:36 +0000
Received: by outflank-mailman (input) for mailman id 246824;
 Tue, 14 Dec 2021 15:10:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9Rr-0005Xm-Iq
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:10:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fc5abbac-5cef-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:10:34 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-ipeAA4ZfNASAhvgWdVqtFQ-1; Tue, 14 Dec 2021 16:10:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB2701.eurprd04.prod.outlook.com (2603:10a6:800:af::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 15:10:31 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:10:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fc5abbac-5cef-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639494634;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VSftDR1HEYYpWf5OLbtVlhbMevF/3BMHkUISlL569Wo=;
	b=F10RYFZIBISWHF4iPWpd3xZBQIl4Xzanbzue4QGvyzIPTGVnlqGW4u6s8Bmr9fBIoqeQEb
	Yy1dlLIIbXeOVsaxdiPwgT4UDme8v7+84a5aMVI1nSWf8Bgamh4Ej/Ykgw0gdTItDfSRWO
	vPNORLd90j9DJN4Dcy8mB/sa55FIlYs=
X-MC-Unique: ipeAA4ZfNASAhvgWdVqtFQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T+LHHFNkM1QPoUPtQpIje31wYd+kf6P+cRzjs0t5CBs9OrSA9/P5HDRxfbP/alxh/ai55tqTQV7tzsoFKomKhN40EGi/rZJgUs3eUurzSp1jI6BB9+m5HYgLHUjwU5dpzu3mYOskgpyQD4DsPpjUtT4moTt3ev095RgF6YdSHMWd9G7N/ZyMaNYQ1FLRdv3n2AOxhfr6qCt9o5r1NLGTdwdMJdR+WIgoE2PLx+HjlxhhqOCDdw/wjdVSvs0Mc9dp+xxKLLSgY6fCdxxyRzFMXTTJn9WTFtea/vFRG5jRZcljaidnIJE1M5rDSyxWQgvjyVT2V66hgMaaWoOTtxM9ow==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aFYHNZzwOHkEq8nsDZdIz1h5pD2dwJzLNbnpYtmgyC8=;
 b=FSYj6nPjHObopcYML7SFvTBpFU9EJXhcstuWrYlJd6Dlt0jif4XHS6s04bWPyiDCsevj9A///AqAvDj4Po+di432dCsnui237I+xj6jLk6i+RhpDbm2auulB5uw3n731d2CDg5+PChNzhRYj1pMunZ3p2YfGBIo8f5BqXT8SqGDdwTV3sT1+6TD78Qw8u47wEvE5f97WxZLZ1SWprQ2KMZoQNKXPH7BYkLkY35NmIlsXuzWIIONFUYR4aspr/PWARCTdZjYC5QQRfQ6OfrmGawdzvlYEXb89Pg64eQN1l7eV9Eox2s/nQDVZ5HAdC3kyRRhLidSsDzsRWmnenEGIOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d05185f5-7ef3-4a76-60d1-0db38041baae@suse.com>
Date: Tue, 14 Dec 2021 16:10:28 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbizA1adGRRIlcTv@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbizA1adGRRIlcTv@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0188.eurprd04.prod.outlook.com
 (2603:10a6:20b:2f3::13) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8f389b7b-b698-4c3e-128c-08d9bf13dedf
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2701:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB27012C7FD0B42FF5300A444FB3759@VI1PR0402MB2701.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jpwFdrUN/tla1Ntt1MOlghpmlYDDi3mBTtgJSCI204LQocM+Hk60rz9lnbn62dcCV3YQkLWvZPb2NHB7GwHyd9jJ8V55NHgud3oSLMgkXHVzfoKFiELiUf3ubSLyOjO419V6EnkDdEkM/42drFjqcxVXZOqjlFnDn3ynUHpfaAngbqnVu8uCo7q9wXPFLybUd++tg82scOqtEj3MH+Z4wVeCAAXpAASsXpcIn3pCo+Y+1/aqBDmdhpm2pU069cB1I1L4PFTFAe3aAzLhXqpiu5u1fa5dMz8Pi/y3Lw+1HT8ebR9uuQziqG1u7Ml5RPZjTozbTYNCAdFUFjskKPMxgeXq4c1vPS9M6VdAqTsPfJHm3SUdbws/IDkVqpHtTThp8Lh5mc2V8SZegkl26ilWb5qRwo715brXXVBVbX61KdvlNcwGOtS2Nv42VPllILQTDZbNz3FIDkhZIdm4Mq2BLtEBiufGjxnc1O1JuTQ6ag8K3NHstK+dt6iUtsNXQ0C0tLj0rSsMc77b2eT7Vs6KVAKj+0Yw9UuDPwmxjWj5OmdhN2k5be1Qs/++SmqnVYeEqMILwMMGOGZcZzJHd9taMjyKrnLny9mfAOeqv3Yli9TN9pmfFyU9SMY4kDjnHk2eVo3qYxPeobWmkDx7cD2Znj+u2jsRjDojyi6Qw6ZvJyKL6pEfiSV3XEBMke+luUtEIYvP/igIRxsQM0dKulKXqEnvwzyhRlTzVNBj3TceA94qqciFuQFI7JwsfuVv4ky+
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(54906003)(6916009)(31696002)(2616005)(508600001)(186003)(6666004)(8676002)(316002)(4326008)(8936002)(5660300002)(66476007)(53546011)(6506007)(6486002)(66556008)(26005)(36756003)(86362001)(31686004)(66946007)(6512007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HwGZdfUZyx1sP8wpOMTny43ZWZq15xXaiNGR6YFcGZdlAhe3YwNO9rBdcwtc?=
 =?us-ascii?Q?7i0EC8wLeyNinfKN0rpOb/OS53nDnj0SIHbk9ipzRe5WXf2VIubc0RTaQ/xo?=
 =?us-ascii?Q?qlHUe9D5zbSJl5fhq6u7F4H2FxfeSfzgcgAv4Sg8DlZSoU72urL4WRIYUcyW?=
 =?us-ascii?Q?IFwCxdT9ydG8JKaz2qLdnW8ivb0Uh/nAuK/KOnaLJp5w8ffor/oq+jHf9yXC?=
 =?us-ascii?Q?X68iaMRedbK6Ep45GCcEs2pkCsC6UTDpz0t+WZkEPGBEfNRpSi3k9wNZDzMq?=
 =?us-ascii?Q?xJ1kz0Ta96o1Duth2egn/R7HUds2afmzRVfns3GrvyrZ1qrb2I/c4zJAL2wD?=
 =?us-ascii?Q?qV6g5ILQ2Km3PJfYAlfIrhkyou9b5YPaFI746xCtXdXqmja43MU5ijVjrD7T?=
 =?us-ascii?Q?BYIh7P3wea3684Z7X4Y0og0ifsLTIqVKyn9X9V4/27pnRMoAfpzUum+Mp1dQ?=
 =?us-ascii?Q?Cr5FfKe4WFoMOH05jFLEQaaAQhypIG2q1ezBCDp0eFRbRvENjQqxz0ZmrGR8?=
 =?us-ascii?Q?l7L40b0xodenHOMN7EPihGefkJ+KG5CmV2/FbH2KTFAbXkhURkLfLuIsyLCr?=
 =?us-ascii?Q?4ACK4i5b6Zbz8tk5pAUl8+dE0b4fbP8HNt7sVulZuArsWl4QlO0ODsInzYmI?=
 =?us-ascii?Q?FSXUo1Oc8F1RhmUVAxhP7oG4IaLNcxTEaIB6HkZAm04bqmlWM6xo0SQcEGAC?=
 =?us-ascii?Q?kXLtKfCFQ7Y+lVrSVS8iSk9rJ4BaDHolnPqlLhml/HAb4eAzRcISO8kpM3nA?=
 =?us-ascii?Q?xyOYUy11VnzEh6FrRVwUeB9qIKCNFD7F3dMqAlazWJWocpZd3MGN6FLEvPdW?=
 =?us-ascii?Q?jylWfrBPJaNdn+bepP8ndmRJ0k2Ymc+LxFw3xLdNht9b+rvVKrqyTJEElwlk?=
 =?us-ascii?Q?gebbooY9+csMWU5Qj7Wibd3P7xFOnEbluC9NXjiPLd5lwzhAXth4X9Tx4mvH?=
 =?us-ascii?Q?1UrcgfwF/zHFVKEjJUM/+TpWNBbqm0wUgHUya+dv5+LeT/OOn1Th41twcnPa?=
 =?us-ascii?Q?mChiJfimYMFZygQLTWYmU29F3kHbjx+rCl8Vpnt9Q0AI/fDHhESDG0vnR/eP?=
 =?us-ascii?Q?CFcQ3kSYnX5p+zJRhiiRAawN7lax5J2xvYhldnKDcEQXqVbjb2Yf4PVbXsDR?=
 =?us-ascii?Q?Q7IL4iMNANsIME0bJShXr4bIeKzM29Q/9pqVwFiRZ41d0XFTsJ/ZRpRoEYMB?=
 =?us-ascii?Q?PIFMsN1GKFMBZhU0rptcjme6dEfHqiikqgqyj50YWt4mVEXoCTQWJ6LG9ks1?=
 =?us-ascii?Q?pIUJlj55XXQTMjZLZ7D5ZV2VDhEQATwf26xGN38PeK/t9IAbrvWvcUKO+XX/?=
 =?us-ascii?Q?Sys/Jo8qbe7seBVVw91yOQNbGYqs+uD+8buZKJrb9IseoXtbCteP2LXIH+AJ?=
 =?us-ascii?Q?DIxX2i83yhsRSa5iCeZmxVobQXayBSUSLCcN0CTdwWuknZ91jFRA16W79tiD?=
 =?us-ascii?Q?dRS1Pnxpt+qX0sDREe8rYlfZZ26rvGAn9Z4caPOIVLfJ49uJ4majSY3GCnfP?=
 =?us-ascii?Q?POW61vYJ3YVJSGQ+m/VICZIwv0ymuBp0KH45AVRr2iiJEGOGD6poxb6T83Mu?=
 =?us-ascii?Q?GEVw0wxKC3+C9GqKQ1bdjNq7afoYw8J9lIeyBaYT2b/KnqTK1y61zDsirhKb?=
 =?us-ascii?Q?fuJrktDCKrP3rFrLy2CuHH4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f389b7b-b698-4c3e-128c-08d9bf13dedf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:10:31.5100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N0Ejz4FkXTitiVLQLI2BDNoi4DxnjjAwMAGIIb8Us1twzV7XelsH13ebaotkRuOG5vdd4bUav7ZN4wMnuzGSYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2701

On 14.12.2021 16:06, Roger Pau Monn=C3=A9 wrote:
> Forgot to comment.
>=20
> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>> @@ -238,7 +238,7 @@ int amd_iommu_alloc_root(struct domain *
>> =20
>>      if ( unlikely(!hd->arch.amd.root_table) )
>>      {
>> -        hd->arch.amd.root_table =3D iommu_alloc_pgtable(d);
>> +        hd->arch.amd.root_table =3D iommu_alloc_pgtable(d, 0);
>=20
> So root tables don't get markers setup...
>=20
>=20
>>          if ( !hd->arch.amd.root_table )
>>              return -ENOMEM;
>>      }
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -297,7 +297,7 @@ static uint64_t addr_to_dma_page_maddr(s
>>              goto out;
>> =20
>>          pte_maddr =3D level;
>> -        if ( !(pg =3D iommu_alloc_pgtable(domain)) )
>> +        if ( !(pg =3D iommu_alloc_pgtable(domain, 0)) )
>=20
> ...likewise here.

Yes. Plus quarantine domain's page tables also don't. Neither root
tables nor quarantine domain's are ever eligible for re-coalescing,
so there's no point having markers there.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:13:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:13:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246829.425671 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9UP-0006Ah-Uy; Tue, 14 Dec 2021 15:13:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246829.425671; Tue, 14 Dec 2021 15:13:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9UP-0006Aa-S5; Tue, 14 Dec 2021 15:13:13 +0000
Received: by outflank-mailman (input) for mailman id 246829;
 Tue, 14 Dec 2021 15:13:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9UO-0006AU-CB
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:13:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 59e2b2b6-5cf0-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:13:11 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-8HEjJ2HxP1-o3b5JGQg4Kw-1; Tue, 14 Dec 2021 16:13:09 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.25; Tue, 14 Dec
 2021 15:13:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:13:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 59e2b2b6-5cf0-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639494791;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=LFhltr32nVeBPERlqPOzT0ScrNpALWIB781vsRvEsbk=;
	b=UYVTJbJEjnxLJKaoMMZZY+h8hYmdBjpWGQpBkW4zv98AAvbZkCAbaPRnkdr1gt/vRKk++t
	3rHMdxDapI4sQYk6vqjoKWxySjlNDIWUnDpUKm4wTvgrzSQcLr9YZbncbz/13YpO4ToLk+
	3JayHShNOhg76oFgNqxrFneOJGuDrOE=
X-MC-Unique: 8HEjJ2HxP1-o3b5JGQg4Kw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MIv0tdKOoo3rcjxCgyU35RiRbwWAX693dcOjrNbvjJE1xZ/ju26wHpGSgcVE/OC14T+C4XmDeVmJ7nFS9Eg46y1LSKwaoQnhUYCBb2Mgjf7YuE0e0KGkdz/HgD8QP0rxG59E/ViCc712CcCAH6iF16AUEA9enNgYaGqJ+y3YXlgFYWRllps9Niy7hV1il0WmDeU9FFPV7fZ2oQhkr9nAIvR+q0TGFRxZ/JPXA+BvWLrc5nzMepn1fFqdT3/LaGtP5ny1GSC29AfqWCc4d0Y9/9PHB2W9N3vQlCj5H5J9miK/INgqa/Xr7SjS7MrC1aDDKcIBAh6QyfO+mPJ6kZefnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LFhltr32nVeBPERlqPOzT0ScrNpALWIB781vsRvEsbk=;
 b=LxbY3faQh/etsREWJKLycxzmL/rV0x34E6q6oFS9W4RejMoswe1dcSEigq3H5uL5eq8jBrgKy3ycZYEUDI5u3Z9OBdm+asAc66snAYmuSMU30HtJaiX3FqOS4JgflZoMqCpFWvg2PEjkCjCvh8LUswXOiAwA0q73shys/4xMdsqWq7CKTjdHPxdk/rvVT+uA6DbAnzxR+ZeKuoafdqzXWWNXn3qxXAWvc1Dfb89jLt7bzWnOXZF9oCCoHt2MVcuPeNYemjTvmHYb7bMN3rwjllEewkZxMEu0EbafstKJ4VpTJg6fuLmdD51dt+rij4yKFLLHM3x7kk9toA8wIYuIGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f751205c-941a-5ce0-44a1-e8151a1a0887@suse.com>
Date: Tue, 14 Dec 2021 16:13:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: drop/replace MEMORY_GUARD
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P191CA0096.EURP191.PROD.OUTLOOK.COM
 (2603:10a6:209:8a::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a3be98f-60a9-409d-4b91-08d9bf143c17
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533E0B056680CEC51BE8477B3759@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:514;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	0kySnK4Hlom7yrlk8myp/ULleRt7FeJ4b5uW6UPl9mw3LSmBMaXBBB3kwmh1AahLpA3tQPx9x/w38nqcuIb0SaZprWFGVSLpoEEfSK7iQc79R4nYXeU0X6vqtRvBNzKOMA8YSJzKTGk6IVgwOK3pYIxWN/MEieVsCel2n0CWlsthGbIR0ihr/vx9ypB8A8j+XDgwBmGZu92UvuES/ss1l0nzO+Oi+z/Aq/6hCdHOZs83eF2yW00ZgPdruG9K4zHoM+1LpfJ7fq3RYRsJZ6rWtcnzimK3u7ejKffjm1fxojPEojWjNR9bTYLgjY07vepaX92Jsvp6r11mIbEIBsYvWTu5u/PedPjm6kgwO0UfuzU5uf8WVbMrj69zyx42DAYuxeqYqDP4Qc21RtYS10ijXTS5fQMKXJOzX66U51Y1h8X/wXCkvXJjBzSSvhLbRSS7qGLwmMzFssxkJL1/Yy7b6bk6wwVTsUVL5yrl18Yor3VAGW1x3fZtvbJTlxfJlInzCScnGG8AYsMfKsbGcAeiSDxAopSyl4uTlWah6egfmZcMaSnE3XQpLoWTphknFpcVgcfLfjxTK15jZDra+hDGLanxKYod4OorKtfTOb5zy8NbJc3xa6gYlMHYO74jJsLET+OpyyaN6k1IdLurWy+a86Cc6r0DIKaxmMJeCjZJREq0g8EZECe+b2G9/wU9XFPoiX2U8G/r7+4q5FxbkZJhbz1rwUtcfG3+fGGbOqSIZno8K4qzohW0b7YnZ6utsGYu
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(5660300002)(6512007)(83380400001)(54906003)(2616005)(2906002)(26005)(86362001)(6916009)(38100700002)(6486002)(66556008)(186003)(8936002)(66476007)(508600001)(66946007)(8676002)(36756003)(4326008)(6506007)(316002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEVyQ2FhMllkWWVUTlJSQlhwYjI3NWdOdUtWTThHaTlFT2gycENjcWN1TzJp?=
 =?utf-8?B?RG1sWDcxemtadGlqMHVBRWpXNE8rVHNlbEJVYkd0SzhpaHE2KzBrVzdYWHV6?=
 =?utf-8?B?UFh0KzRqSUhNWDF1bjVId3ZIMGxlNnRLUnZJM1JTZXRsLzkzbFpZcVZ0NEE0?=
 =?utf-8?B?UUY1TTFjcjRnN0ZRamJwTWhNZFBtcDA3ZjdUQ3gvdU52NVRCbFJlQ25tbVJR?=
 =?utf-8?B?ODErTWhPUG5QYWNpN0pVL3VwbktGd25pNTdzenJTUTFtQmp0ejExdlNJWGE0?=
 =?utf-8?B?TXgvSG1qREV6ZEpFUnZUa0RDRzZSL3ErT2ovZmpTSHVoYTZYUzhvN2dDL2o2?=
 =?utf-8?B?aGpRNjRDNUJ1SlhOSko0Y0RabjVKbHNmZklmVG5jeUZKRW5pL1R3NUIrdUpO?=
 =?utf-8?B?N3RJaFVSQ0grcDJDRFg4TEcrNnoxSmpyQStBWlBscjFjUFJqTUMyTlpTZmJ0?=
 =?utf-8?B?M0wyeGVqVGtFNUlVOWxpY2xtSXl5Tk1wVENmT3JkNlB2RC9zcDUyd1dPUkFp?=
 =?utf-8?B?eTJLaDlQSkFCVllkOUo4VWFPRU1odzAwSnlPYkxiTVlHYUkrL25tSFdYVlV1?=
 =?utf-8?B?enhVWkJydkN5Y01oWTRSQVE4M2xzYzJ1ejBJSE10Ui8vTnpROHFyQmdlVCtB?=
 =?utf-8?B?aTlrRGRiUm9udUR4T3pSODFLeWw4R2lKcHdTSGloMG5MaEVXR3hYRm91cUhW?=
 =?utf-8?B?K0JEUXl4alYvM05aczJPSHRIOEw3cXE3SE5wVmloSC9ubFljaDZIQ0h1NXYx?=
 =?utf-8?B?TzR0RHdrUkdLWjZDY3ZEcjVHcFRqZG9JeDlOdjY1S2NMWk1Xem5QajNYeTJY?=
 =?utf-8?B?Y1JBbmZhcUEwdWVUajQ4cGxyckV3QVhhNGQ1S0FvVC9WYmpZZktYU0xtT2lM?=
 =?utf-8?B?clN3NkR2cnRTbFVCd1ZCbkhsSW5IWHRQVjdLb3MzaEhnWW1zWHF0NHRkeVBP?=
 =?utf-8?B?VGJnUWtoWTk0S05FMTV3Vm5HMStLVHo1amoramwya0RkZmNYT2wwUkxQOHE0?=
 =?utf-8?B?L2dkK1FvV2RDZkJidm9hVHFzT2grMlE3Qll2Q3JpUlZ5VTlXY3Q3d1pWeHFF?=
 =?utf-8?B?QllIWWVMdWFnYy9CL08xb1RXb3hKUkUvUkNlSm96MFJZUzc5dklTTDVtRnpj?=
 =?utf-8?B?dXQwcEhQeC9hVHMxbUM5OFBHVGs2SWZuWjE5VTV4cElLdWRtZTdJMUpia05F?=
 =?utf-8?B?MGFzelRCY1dLOXlUV3Y2K2RCU0lGbENYenFUdXhIQ3ZZOFYyWVNMVjluWUQr?=
 =?utf-8?B?dVNQOXNwcmx4NHZWRnhsM2pIeHRFV0RWWmovbXA5b0lPZWVJd1RlWVN3RHN3?=
 =?utf-8?B?dHdCRUpNMzlMUDZsekFVOEdQWmVPWkQ4dTd6b2VlZTlJa3ByMHZDbkJCR3hR?=
 =?utf-8?B?cit2RGVDdmtEcWt0bjRsRHg2N0pDWTdRNUxZV0V0cExyR0laWUN5WnhJeW1v?=
 =?utf-8?B?VEZsMUEyQll2b1B1TitEd3U1ZHo3cnRLVzhmTDd1QmZVaHRrUlpQTXI4azU0?=
 =?utf-8?B?aHEvTnp4VHFOaFExQUJEcVBUU0VxZ3Y5WDNLU0xFYWZ1R0lpazhZaE5hNDc4?=
 =?utf-8?B?ejhUT3RlcFRaL2UxYUYwVmtIUGFkREFhNVBaVlRZenk1K2M1VzNpL0pIaEVo?=
 =?utf-8?B?QlV3NExrWjRwTWVNMTR1Zzh3aGc3U3ZoTVVJK3JpWm91Ym5HTXYvdUFMQi9X?=
 =?utf-8?B?ZFU2THdVeXhWNkgwWTJvYnBMMGZONnE1ajhUd3JJUnpGNTlIOWdySnVyYVBy?=
 =?utf-8?B?TmZhWU9NWnhtZUIybXNjdUlZdjAxSEgxRjRqWHB1alhqOURxUHlEa2ROQXNM?=
 =?utf-8?B?S05oVVJ5UE1hV1VtRW56R3UyS29GOFpJbklKZDhiamFURG1oWmEwQVM1dVdl?=
 =?utf-8?B?MEhWWG1wRmpXVzdQc0pFclo5eFlRMkJjV2YvVzZ1RERRWVo1UGUzUDYweWh5?=
 =?utf-8?B?enBmK3p3a2ZmZ1cxaFZqSU9LWXcrSGN0WHY3YStGcGVrZEI0RHJKc3d6WVlJ?=
 =?utf-8?B?N0R3MWFVdStJcjVaWXUzNDNKOUlkcmJ0WHRvZU1lMW1oUGNEWXh2T2FMVFFJ?=
 =?utf-8?B?ZHpZM3o5Y2hGZzJ1enlzLzBVeGFGU04zeE4yeVhUWDdwZUVFTmpUS3h6eHZm?=
 =?utf-8?B?TDJiM3dNcEsvajdTQkFBcGZOM1lhaURDSVBSTUJKUW9oeTBta0x2UEpQRjZw?=
 =?utf-8?Q?6XXebkvrWm6n409CQ0l9z34=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a3be98f-60a9-409d-4b91-08d9bf143c17
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:13:07.9106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R08874XAKCLKxn2yGdgFVFeAIRRI8q0FW3wxvfVpYkfvZ3B/LbuZExYcL4SHK4PaINl61qOxth+PE1mrbWp3qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

The functions it guards are dead code. Worse, while intended to exist in
debug builds only, as of commit bacbf0cb7349 ("build: convert debug to
Kconfig") they also get compiled in release builds.

The remaining uses in show_stack_overflow() aren't really related to any
memory guarding anymore - with CET-SS support the stacks now get set up
the same in debug and release builds. Use CONFIG_DEBUG there instead.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -6109,36 +6109,6 @@ void free_perdomain_mappings(struct doma
     d->arch.perdomain_l3_pg = NULL;
 }
 
-#ifdef MEMORY_GUARD
-
-static void __memguard_change_range(void *p, unsigned long l, int guard)
-{
-    unsigned long _p = (unsigned long)p;
-    unsigned long _l = (unsigned long)l;
-    unsigned int flags = __PAGE_HYPERVISOR_RW | MAP_SMALL_PAGES;
-
-    /* Ensure we are dealing with a page-aligned whole number of pages. */
-    ASSERT(IS_ALIGNED(_p, PAGE_SIZE));
-    ASSERT(IS_ALIGNED(_l, PAGE_SIZE));
-
-    if ( guard )
-        flags &= ~_PAGE_PRESENT;
-
-    map_pages_to_xen(_p, virt_to_mfn(p), PFN_DOWN(_l), flags);
-}
-
-void memguard_guard_range(void *p, unsigned long l)
-{
-    __memguard_change_range(p, l, 1);
-}
-
-void memguard_unguard_range(void *p, unsigned long l)
-{
-    __memguard_change_range(p, l, 0);
-}
-
-#endif
-
 static void write_sss_token(unsigned long *ptr)
 {
     /*
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -642,7 +642,7 @@ void show_stack_overflow(unsigned int cp
 {
     unsigned long esp = regs->rsp;
     unsigned long curr_stack_base = esp & ~(STACK_SIZE - 1);
-#ifdef MEMORY_GUARD
+#ifdef CONFIG_DEBUG
     unsigned long esp_top, esp_bottom;
 #endif
 
@@ -650,7 +650,7 @@ void show_stack_overflow(unsigned int cp
         printk("Current stack base %p differs from expected %p\n",
                _p(curr_stack_base), stack_base[cpu]);
 
-#ifdef MEMORY_GUARD
+#ifdef CONFIG_DEBUG
     esp_bottom = (esp | (STACK_SIZE - 1)) + 1;
     esp_top    = esp_bottom - PRIMARY_STACK_SIZE;
 
--- a/xen/include/asm-x86/config.h
+++ b/xen/include/asm-x86/config.h
@@ -57,10 +57,6 @@
 
 #define NR_hypercalls 64
 
-#ifndef NDEBUG
-#define MEMORY_GUARD
-#endif
-
 #define STACK_ORDER 3
 #define STACK_SIZE  (PAGE_SIZE << STACK_ORDER)
 
--- a/xen/include/asm-x86/mm.h
+++ b/xen/include/asm-x86/mm.h
@@ -530,14 +530,6 @@ extern struct rangeset *mmio_ro_ranges;
 #define compat_pfn_to_cr3(pfn) (((unsigned)(pfn) << 12) | ((unsigned)(pfn) >> 20))
 #define compat_cr3_to_pfn(cr3) (((unsigned)(cr3) >> 12) | ((unsigned)(cr3) << 20))
 
-#ifdef MEMORY_GUARD
-void memguard_guard_range(void *p, unsigned long l);
-void memguard_unguard_range(void *p, unsigned long l);
-#else
-#define memguard_guard_range(_p,_l)    ((void)0)
-#define memguard_unguard_range(_p,_l)  ((void)0)
-#endif
-
 void memguard_guard_stack(void *p);
 void memguard_unguard_stack(void *p);
 



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:15:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:15:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246836.425683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Wa-0006q0-En; Tue, 14 Dec 2021 15:15:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246836.425683; Tue, 14 Dec 2021 15:15:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Wa-0006pt-Bn; Tue, 14 Dec 2021 15:15:28 +0000
Received: by outflank-mailman (input) for mailman id 246836;
 Tue, 14 Dec 2021 15:15:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx9WZ-0006pk-Jd
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:15:27 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a97acfd1-5cf0-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:15:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a97acfd1-5cf0-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639494926;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=DOL4ZabMUwAbKdqSNR0cVvDQXxVUqA23V/kFpU5QhvE=;
  b=fBhNEsgactuua5wDEIPcY0tVW3wn+8B5h6Y/CI3C1Yu0lrPZWmJyJX5d
   2g8NpvyYeXVyyLGjBbbHQzwibA6uFfgIyG8yu6WF8eImdsR1KiHGEaQDQ
   56hXNHa/qR8CMBlmV5T3na3En2fChvXlB6h2Ucxa4cq/afZLOtD4fgiim
   8=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: ohebrPkhOuPel6yu0druO4yDrXy+hgXfnUlj7as8eJHBdq2xS3iCPV6DWnQRJb9U4kDx99/gG5
 AZYAwDrhKie6tsx6hO6k37QE51d24VxOycVrmK59gDJQdrPkq6McrbnpshMPWgcC+jMS0yxiZK
 uvCkUagMkTntLuW7xuh8EPv6f+LCkyuDcNH0UC5GnQRUfG2haon/F788js6zCFz57af97YEHKp
 UhqpbYOEs0x2hsTjOTYZK6W+8XFxTVRCQ6cBpy+nJZktLXMUnAWe07y2DHHP8zuTvtu7s+Go/U
 yrGvcgYLarz/d5nXQvIvozjV
X-SBRS: 5.1
X-MesageID: 59494132
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:u+rty64MCuCRTK0ikoBhJQxRtM/AchMFZxGqfqrLsTDasY5as4F+v
 mofXm2COPuDY2qjfdh2aIvi9kIBuMDcy98wTwY//CwxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Iw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 +pA7ZeKc0AQHaTWssswSzNyOChsMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWZs15wXRqy2i
 8wxUWJCQgvOUkF1GAklF4AlxvmzqWL6SmgNwL6SjfVuuDWCpOBr65D1OcfRUsyHQ4NShEnwj
 mHL4WX/RA0bPdq3yDyZ/3bqjejK9Qv5Uo8PELyz9tZxnUaegGcUDXU+RVa95PW0lEO6c9ZeM
 FAPvDojq7Ao806mRcW7WAe3yENopTZFBYAWSbdjrljQlOyEuG51G1ToUBZqV9F+v/UMAgUJ3
 0WjsP7xLxZEua+aHCf1GqivkRu+Pi0cLGknbCACTBcY79SLnLzfni4jXf44Tvfr04Sd9SXYh
 mnT8XNg3+l7Ydsjjv3jpTj6bySQSo8lp+LfziHeRSqb4wxwf+ZJjKT4uAGAvZ6swGt0J2RtX
 UToeeDCvIji7rnXzURhpdnh+pnzuJ5p1xWG3jZS82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif
 VXevwhcjLcKYiD7MfUuO9/vVJV6pUQFKTgDfqqLBjapSsIuHDJrAQk0PRLAt4wTuBZEfV4D1
 WezLp/3UCdy5VVPxzuqXeYNuYLHNQhlrV4/savTlkz9uZLHPSb9Ye5cbDOmM7FhhIvZ8V692
 4sOaKO3J+B3DbSWjt//qtVIczjn7BETWPjLliCgXrLZf1c9Rjh+U6S5LHFIU9UNopm5X9zgp
 xmVckRZ1ED+lTvALwCLYWpkc7ThQdB0qndTAMDmFQ/AN6ELbdn94aEBWYEweLV7puVvweQtF
 6sOetmaA+QJQTPComxPYZ74pY1kVRKqmQPRYHb1PGlhJ8ZtF17T59vpXgrz7y1SXCC5gtQz/
 u+73QTBTJtdGwk7VJTKaOiixk+atGQGnL4gRFPBJ9ReIR2+8IVjJyHroOUwJsUAdUfKyjeAj
 l7EChYEv+jd5YQy9YCR16yDqo6oFcp4H1ZbQDaHverna3GC8zP6k4FaUeuOcTTMb0/O+f2vN
 bdP0vXxEPwbh1IW4YByJKlmkPAl7Nz1qr4Ekgk9RCfXb06mA69LK2Wd2ZUdrbVEw7JUtFfkW
 k+L/dUGa7yFNNm8TQwULQshKO+CyesVin/Z6vFseBf24yp+/bymV0ROPkbT1HwBfeUtaI51k
 /08vMM26hCkjkt4O9mLuSlY6mCQIyFSSK4grJwbXNfmhwdDJouuunAA5vsaOK2yVug=
IronPort-HdrOrdr: A9a23:dsj8l6EJrlpGin0NpLqE7MeALOsnbusQ8zAXPidKOHtom62j5q
 STdZEgviMc5wx8ZJhNo7+90cq7IU80l6Qa3WB5B97LNmTbUQCTTb1K3M/PxCDhBj271sM179
 YET0GmMqySMbGtt7eZ3DWF
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59494132"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WzcfIc6HY1ys+7UT95Ov6+DrvxC3HDt/g4MDfUTfuwLm364q4ZOT0HCTM8OteXswRfwXopZ6ZbLriiNVSe7jQhZ58ttSyNDmTt3dfr8UDx1f/US/QrWT8PjKuhPai32BJaa45SNLt2FtXM4yM72FD2SmMBfcevSjBhnDVVFmoOpgkfVE3TvFTsLajTcROtPHNmBpqKrEQEpCpdFpwO3yKCq45R/nIETCjKkarjAXc7iNRgd+D3V1faxCT3t+QnBnSa8dOgXalrshuBc7gp7WvxpCYm6hduFA+bFUS7cVB5+odTgXrrP1EmUd6H2t5a7osjEwkzH1Pl+dtVXLuA8yKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YN9lW1TI4ATp0d0WrCH5IjPExl0iV6e2d5QMJ/yvlEc=;
 b=FiHfsyCW1X1CIMMLB05rkCvFOIwdDle9zG8VLoA0Kgnii4cmsIyoHYcRjUeT+SlseQO4YCPJp/gq5odkSUAI97yZd4b9rE+/FkHOGfaDZ2vmEroeR3EGEsopChpCFZ+PIXtjvb1FzAsJea0MsY/piARm+pCDEjqsXyXN3qaO4OwJjgAIZmRnRqm2MbQ1KZHUbcrIjE1PIryWUbAfA079VUTzskFZbsY/rEdZ5sH3HZ42KMT66LO441Yfdd2MPPZwn6whZMt6cM1UMM40I7to0GtzZzLGD4UbDQHw81ZbsgZso1nTCgAk2fBP5XLktfb06sFyzzlrdeeCtUw49NJhKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YN9lW1TI4ATp0d0WrCH5IjPExl0iV6e2d5QMJ/yvlEc=;
 b=SY3tCHJ0k3r5xaWE4S1pINk8EcbWepglxe+65CWQV2iM44tHy4Zg8mzjKgfaamfJKCLJG+R3bH6nn/iVit4w3ttkIKBZstm7GjhF6s9nWrXZpxecs6miXkxEB+RmtYMQCIlyzD3iLoaRUV2B+kNXJfwc5Pq3PIXIbjQGPEhSCOo=
Date: Tue, 14 Dec 2021 16:15:16 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <Ybi1BJR+UybxeMMy@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbivUH/Er0o2PwsG@Air-de-Roger>
 <fb221da6-2ad5-e298-c582-364943b95198@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fb221da6-2ad5-e298-c582-364943b95198@suse.com>
X-ClientProxiedBy: MR2P264CA0001.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::13) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0b512e8-2a7c-4eac-0e2b-08d9bf148ba3
X-MS-TrafficTypeDiagnostic: DM6PR03MB5081:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM6PR03MB5081F28E0DD84522999FEDF18F759@DM6PR03MB5081.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9+ukeIGYe8BAxXVShjHKNK4i4uKP2IbyxFnMgVurNhSygsO+7CK59On3oOiumrMBVlz2lyUl+jtXIitDXOYMMqKomO5tS4OqGGNlkOPXTamtoAeLv4bFnNIZ+dRxeUcuhDuRbLI+KTVcwEMJNkO5CQXTX/wRS3sNUM40qR/1A1TOk9ydCU3gyukqH1SPhwmM5C1XpNJNFAneAceqGl8lCSbrMiW0iITIFErfUX70n0kN2sY8kwFaP2dWPkGSXlKxkY+xWwNhuCoFO2URk9x97H/17zAmEzcagpwqIwdrIgBkp0Fb+kEc4HgVMregGF7WdMAODEzCmEDC9R5VQs8WA0Il/+/ovEL07Cwj7dsJ43ZRmUWGmJw94yHtuZ0H9AUP/0cvHkS6Ojtar4GSjGZdp/d5lTpfYPfys/zJPWF3/Au5zsf+jdzFIQu2X4MxOzFwQYcjyW246yoFci3xlMNsD6jNa5lSj4IxB//c1wK+QsFP+6UeFBghQ8L6JW+qtf1oBXWtpxH3xCB8+MYnvuIetFruAvOD8iZttWr8+o90aaWG7KWhSFvtUvH66IiWXIikIMqrO6PngL1uwwZ8xnEa+jYHpMlki6DHmhe/opPzwTL1wuZfHHEIwd6UsmBjpe22zQXeMN495tVkEHHL0oDzsitcQwZ1MCWouRFyzipvqZKM/WUg1bbCO0NHr2E9dB0BlxO0+GI9osRih/QgoQZD8g==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(38100700002)(54906003)(316002)(6506007)(82960400001)(6916009)(8936002)(66476007)(6486002)(26005)(66556008)(186003)(53546011)(8676002)(2906002)(9686003)(508600001)(5660300002)(6666004)(66946007)(6512007)(4326008)(86362001)(33716001)(85182001)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXR5UExVdUp2NFVOdkFHSVdVckpXaVNvUjVwTmJSTTR3OVJVUlV6RWcyd0la?=
 =?utf-8?B?OVF3ZmpTN1NJdFBmM2lmbllrek40RUdieU9IRXNMQkJaMjBESUh5OXJZZzV1?=
 =?utf-8?B?aGphWU9KSU11UVJ3a1AyaUpZYm5KSWhkclUvYjN3a0p0U2x0UHVEajEvNktS?=
 =?utf-8?B?ZzBWZi93Y3o4U0lROWkraE5rQkg3ZGVDd1c0SFdiaDBPVkx1V2dDU09Edmlq?=
 =?utf-8?B?bzVMRTZQT0RwS3lidzkyVVMwNklQQTM0V2UrQUJVcVAwWkhLaTZ4QW43T0pu?=
 =?utf-8?B?T1c4L1dLYWp4NHVORzZEbk1BM0VYVENjYmx4VlJFTTN3Njd4YllkNHljaWdV?=
 =?utf-8?B?V05XN3l2S2FVZUVjYjdUdTZaeHRTL3p6MHZkNFQrLzVtc0NjdmNUaXRkeGFR?=
 =?utf-8?B?aGhpaVA1QzBxMkRQR0VsUHdRdndVSDdNZDJJVVA5Y0NENlpuQWR1c2pSTnlh?=
 =?utf-8?B?M3Fzb2hwbVA0MTJVTWFhbXFFV2h3YTZaUnQzcWdhTWlSK3FYNFlDUkJ5blpM?=
 =?utf-8?B?YkhUSCtCc29EaVF2cmtXZ1h6NWluejdUYWd5a3p0STltdW05VjBIcGhDSzUz?=
 =?utf-8?B?U21VYU5wNDUrYWo2VHdCdVI1eE80REhDMFc5OXloemhaYWJ4b3Z6K1RMOFlT?=
 =?utf-8?B?NHh2emxYUGMyUmtnc1ZRbFpaWkZCZG5hL0kyTlkrVmh5OHk5blJ5TjRPQ1Ro?=
 =?utf-8?B?U1JVOXBhQU1UNFlSZUErdytSc2h3eFBscnQ2aE9tSmFidHBRcDhJVkVFdUlO?=
 =?utf-8?B?NUZMOTdlb0p3ZjZFOGtyOEtONnNISkpVcHExOGpSZHZZT1ZUQVNvYkRna3ln?=
 =?utf-8?B?SEN1eTJEVnlrM255UExkZGhnRlNsVzlBbmFOaW42bEs1VG51SnpKNGc2Mmg0?=
 =?utf-8?B?enIrZ1RPNzZFeUN6bE9nWU5YVHVnTHNsSHEwcDhRMlNVS2RhMVdMRGxpSy9n?=
 =?utf-8?B?N1RUVjJSYnZiS3dYOXJGbG5BeUpxOGh3c1ozalBENDRkTlArUUlGc3hrMFBs?=
 =?utf-8?B?aGdKS0JtT2s3U1l1VjEwNkRtNzlBWlZ0VmQza1pBMGgvSFI3SGZYSW1KY284?=
 =?utf-8?B?OWlVVEdHcjU2QWhPUUNwV2ljNVJkTCt5dXZ3RGNMM1NkUW5NZ3RCb1FXN3Ux?=
 =?utf-8?B?QmVmM2tGamtOWExPM2ZGTVhSRzlqMCtCa2U3bFFWc2pZOVoyWmZoZ0ZRQ0xT?=
 =?utf-8?B?R1VRQmlFLzZNNHQwaVlHZ3FYSTdycngzZE45V2E2M1Bzem16TTNXVmU0MUh4?=
 =?utf-8?B?cXozK0kwMkJSSFZWbEtQNGUwcmNWU3E5dU1hSHp6ZTBOT3c3MWhncG5iYmpv?=
 =?utf-8?B?c0RIb01qZkgyWFQ0KzBrblJVbEdyS2FrODc2VUp2cHhRMjNzTE1IQ2lyWWZX?=
 =?utf-8?B?Yk8zSW9wU3FsQ1RVRUZuc0E2MkRXSnhrUlNKamQ1Q1RNanBaMCtNL2lyNUty?=
 =?utf-8?B?TTVNTTc3Qmx2NExmWGVPYjg1SmFPY1JvdWFpVDhVTDc1ay9YcittYXpadHhI?=
 =?utf-8?B?Tko4UWJOL2tOdTk1NUJzV3BiY01CTER4N0thOVpBQkFteGk0Q2xINWpyVXU3?=
 =?utf-8?B?NW0yQ0xJUmt4QlB6eGlmVUY3SUVDVkk5dDZqSzVOMlBpaHRxbXVyOFFwR0No?=
 =?utf-8?B?Wk5KQVRJWG1QTnlya1I1S3N2U2xWeXYxdTZRS3JUa01Kc2lrbS9Sa0NWQ0hz?=
 =?utf-8?B?RmVLc1NhZCs4K0xHbFE0ZklHdk5sVWNnWkMyTHlqNzRQN2tKYWJ1KzE5bk5Q?=
 =?utf-8?B?amJnWDFjaUZXSFoyN0NsVmFtUnh3V2VuMkZxVkJXbW1QRU1GL3pnQmp6UVFR?=
 =?utf-8?B?ZkJTSTBNendveEIwVlZLbERNUENyWmljM05RdjRqaHJNbGdDSTFwMFFpMWlX?=
 =?utf-8?B?RmVDYjhjYkkzSWU4NUVWeGdlSjdhbHFJM3BHQ3E5VFJJVnBvOXVPRjdCd2FC?=
 =?utf-8?B?Kyt3MTlYWUxSRktyOFowQWJDL3J6d0U2Vk96aXRHSFJhQUJnOWd2WEtZWngx?=
 =?utf-8?B?MjJoeTdCaFVFZlpRNXNLelB1eWNuSG55cmd6L0lvUzNJdlpISU1LOU9CN2FQ?=
 =?utf-8?B?RkFoTHBGczlVcTZOOVR2UDNsY3Y5S1JRaStGQnJhbnlmR2tVTVlPTHpZTENa?=
 =?utf-8?B?aGFZVzMxclIrcGxLRjJESVd4WW5jcWZwQzlTVExkOFdvaXM4eHJaN0xUcnFO?=
 =?utf-8?Q?VXXERM/Ia5ijTztmb+vVL6w=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0b512e8-2a7c-4eac-0e2b-08d9bf148ba3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:15:21.3820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UgLs66n8wt/EiCdFnVMH4pjfEid96cyGqTA5sD+yfeoEon7QTUMB2Ds5qUqCn67crxbZNVb7nkQoKWX3HFX7zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5081
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 04:05:27PM +0100, Jan Beulich wrote:
> On 14.12.2021 15:50, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> >> --- a/xen/drivers/passthrough/amd/iommu-defs.h
> >> +++ b/xen/drivers/passthrough/amd/iommu-defs.h
> >> @@ -445,6 +445,8 @@ union amd_iommu_x2apic_control {
> >>  #define IOMMU_PAGE_TABLE_U32_PER_ENTRY	(IOMMU_PAGE_TABLE_ENTRY_SIZE / 4)
> >>  #define IOMMU_PAGE_TABLE_ALIGNMENT	4096
> >>  
> >> +#define IOMMU_PTE_CONTIG_MASK           0x1e /* The ign0 field below. */
> > 
> > Should you rename ign0 to contig_mask or some such now?
> 
> Not sure. I guess I should attach a comment linking here.
> 
> > Same would apply to the comment next to dma_pte for VT-d, where bits
> > 52:62 are ignored (the comments seems to be missing this already) and
> > we will be using bits 52:55 to store the contiguous mask for the
> > entry.
> 
> Same here then.

I would prefer that.

> >> --- a/xen/drivers/passthrough/amd/iommu_map.c
> >> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> >> @@ -116,7 +116,19 @@ static void set_iommu_ptes_present(unsig
> >>  
> >>      while ( nr_ptes-- )
> >>      {
> >> -        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
> >> +        ASSERT(!pde->next_level);
> >> +        ASSERT(!pde->u);
> >> +
> >> +        if ( pde > table )
> >> +            ASSERT(pde->ign0 == find_first_set_bit(pde - table));
> >> +        else
> >> +            ASSERT(pde->ign0 == PAGE_SHIFT - 3);
> > 
> > You could even special case (pde - table) % 2 != 0, but this is debug
> > only code, and it's possible a mod is more costly than
> > find_first_set_bit.
> 
> Not sure why I would want to special case anything that doesn't need
> special casing. The pde == table case needs special care because there
> find_first_set_bit() cannot be called.

Well in iommu_alloc_pgtable you already special case odd entries by
explicitly setting the mask to 0 instead of using find_first_set_bit.

> >> @@ -450,7 +450,28 @@ struct page_info *iommu_alloc_pgtable(st
> >>          return NULL;
> >>  
> >>      p = __map_domain_page(pg);
> >> -    clear_page(p);
> >> +
> >> +    if ( contig_mask )
> >> +    {
> >> +        unsigned int i, shift = find_first_set_bit(contig_mask);
> >> +
> >> +        ASSERT(((PAGE_SHIFT - 3) & (contig_mask >> shift)) == PAGE_SHIFT - 3);
> >> +
> >> +        p[0] = (PAGE_SHIFT - 3ull) << shift;
> >> +        p[1] = 0;
> >> +        p[2] = 1ull << shift;
> >> +        p[3] = 0;
> >> +
> >> +        for ( i = 4; i < PAGE_SIZE / 8; i += 4 )
> >> +        {
> >> +            p[i + 0] = (find_first_set_bit(i) + 0ull) << shift;
> >> +            p[i + 1] = 0;
> >> +            p[i + 2] = 1ull << shift;
> >> +            p[i + 3] = 0;
> >> +        }
> > 
> > You could likely do:
> > 
> > for ( i = 0; i < PAGE_SIZE / 8; i += 4 )
> > {
> >     p[i + 0] = i ? ((find_first_set_bit(i) + 0ull) << shift)
> >                  : ((PAGE_SHIFT - 3ull) << shift);
> >     p[i + 1] = 0;
> >     p[i + 2] = 1ull << shift;
> >     p[i + 3] = 0;
> > }
> > 
> > To avoid having to open code the first loop iteration.
> 
> I could, but I explicitly didn't want to. I consider conditionals
> inside a loop which special case just the first (or last) iteration
> quite odd (unless they really save a lot of duplication).
> 
> > The ternary
> > operator could also be nested before the shift, but I find that
> > harder to read.
> 
> If I was to make the change, then that alternative way, as it would
> allow to avoid the addition of 0ull:
> 
>     p[i + 0] = (i ? find_first_set_bit(i)
>                   : PAGE_SHIFT - 3ull) << shift;
> 
> I could be talked into going that route (but not the intermediate
> one you've suggested).

If you prefer to open code the first iteration I'm also fine with
that.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:17:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:17:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246839.425693 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Xy-0007RC-Pz; Tue, 14 Dec 2021 15:16:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246839.425693; Tue, 14 Dec 2021 15:16:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Xy-0007R5-Mt; Tue, 14 Dec 2021 15:16:54 +0000
Received: by outflank-mailman (input) for mailman id 246839;
 Tue, 14 Dec 2021 15:16:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9Xx-0007PH-8Y
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:16:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d77140a5-5cf0-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:16:46 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-lXl44aIyPhuVVAuuritTmA-1; Tue, 14 Dec 2021 16:16:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6384.eurprd04.prod.outlook.com (2603:10a6:803:126::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Tue, 14 Dec
 2021 15:16:39 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:16:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d77140a5-5cf0-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639495001;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=oTnYpNOrpXU+v29cmdfEITKc/+oXUuEoOqhKM6iPyRE=;
	b=iDAf1wHVKQxVbwZ0HkvoYOpjSOra8YZ23AiUHHssr8z+kxGlEfQ7RckYeqM5/ISaAZjkGP
	xTPMF0XmNJQ9QudaAO0Y1fZhtko0gwLxFz16jdOEG5Wgbpix7h9OeH2HBn2rMIYgs26AgZ
	uuoqHUsrVTOHvg8SZ5aNOnEDfZqwmcI=
X-MC-Unique: lXl44aIyPhuVVAuuritTmA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KjG/1+wVmpKxXqPexuZfT5R64old9KNjOvdn6M9S6FlCDnyi3di5F1PFR97UQ1wWs/QSPovXDJPZZpFkrEs3xgVAZdvvADgjzHmGYCNlN4eR/nfeXHBpz+4lCwqStigXpqpjoKy562fRs3bcjwWWEKb/8JTvJcmzFTH4wkR4TQgP+M1owf9DSXce+SGuEId/iGGuNZld4QJzABwFp14hqbbddGHMZdR3Tkm8G7oRE+J2dRr6uRNtStFNgNlqGpWCngECuL8SwdVYPjI3LEYchs1yMb3+VFjtQgVdpDee/GSUXJwsR2HqxrTSVu3QPcanr74mfYTBB++/6kOa/h8ciQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=oTnYpNOrpXU+v29cmdfEITKc/+oXUuEoOqhKM6iPyRE=;
 b=QvfGve+/BTam1dExcpk7a+h2My5kcrCipKEamuEN0L7zSuoDERhdiFqPlKfvioj7McYP9p5ZhIEns19QezyMqmcjznuDHMKif7Q7Eg89cM6i13GXcap9xck0iQFptp/gOJhdhGP02RL3uoQkxOcQqEpBQg82NyI+Tug/iAo9MqyQtpZ8AGmnQxEBBg+6+CZo3evgmvpr/N4TM7Jogm4ETYui310Yb+5rXg1TbFUPeZ9KF+o215rghZ2P9mBUxWM/aNkX4nPMkoO8HGJJiQJdtG3A97lrFL0bI/ADMFn9H/A/thJTaRq/EfDXy8yNAMfxqbLc2Ms5Kvb5xj0shzSQOA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <11f9f2e5-102a-247b-368b-29021f5e7a84@suse.com>
Date: Tue, 14 Dec 2021 16:16:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] Arm: drop memguard_{,un}guard_range() stubs
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0077.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:88::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3bef7ce7-bdc3-4ee4-7e46-08d9bf14ba36
X-MS-TrafficTypeDiagnostic: VE1PR04MB6384:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6384CE2A4391891E49C0E25AB3759@VE1PR04MB6384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4502;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aBBIajij/Ebw+0XlnMbceOImrxEK6ft0PSXN0sMzwlhfYIXTOjFEKz5X58H2vgAYk965tpsIxjKKjBFCTmYfyKkna+RVPfgOPCOqPnuHt4AeWJ0zljettH61FrpNgksNrbfyJ+hSWO0SCK2FedxW3bTZG6UcUQthG65U9RWCiNgJlKt4yhx+8sUo9SBJ5J97H21Uzl19grTDnWnOF4HNS+e1wp3ZDFYv+k2XD8HZEbxw1swZ50AQ9nkOL6mKSY6XMfflDEhkEqzH7GKo6Fwu06PjAMT8v7hnuz1McGXHlgbhxn11LXwwDFKmwPCOEcColZl5hNG03dRWPmKFC4lNIa0Zo2cOHiHJYh5q8ixyZixab9C8ypX6H0hLNS4yuzBT2lnjGOuwQAZu3AtIlkpYjADe2zEjb1lBLX1Fw1QD/u/7KlG4ZztPSuyJ/PorZ66eQfkCOQUjFA0ld3bHs+092AkCZFAb9rbhwgVNOUlyU+p/E8CoNm7YZZ7RT8We9y31NQrAdjn/W9/7XlAL1B5+o2OmwMgf1kv4IljEfu40qPhtnXinpTsW5HgldSWXfKw4IFsoqj9PxMnILKijRTux+S7yAVoyPodKu2MMK87JAZKk5u64MJFvVKcC9F7Jp9FuJgYfmqoDpFLN1/CdS748XxNDZeGwyz/gEKytaxioBBueeHKjX83+1grHOAk+7nCH5/VGhdF9MjDu9x8VB1Q57Ws1ANDJnVthykRPK4PNURUQrpOgv1JpobSQMEwRz4h6
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(38100700002)(86362001)(4326008)(6916009)(2906002)(66476007)(66556008)(66946007)(83380400001)(6486002)(508600001)(316002)(8676002)(54906003)(5660300002)(31696002)(6512007)(36756003)(8936002)(31686004)(6506007)(26005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cVFSK0VTR2lEU0ViOGY0ZVJ1dFEySW1GMWhPb2hhclhwaWhIdFZjSEJFQmV0?=
 =?utf-8?B?ZlNMY0RjZXlVMDczV1I1SWs3NStMSWdjZy9LQlpaU0lOMlJsMWFxZmJZK2lz?=
 =?utf-8?B?NlJEK1dsU3VVRUNveDgxWG12Ull5RjVqM2NvaTBSZmc4dy9aUk5xeWNGMktq?=
 =?utf-8?B?N2FKZURpb3VNRGRQY3FRL2lLRUlIU0ttcDhJQmpuMWZPM2xCNWJOZlFGblQw?=
 =?utf-8?B?cDh3a1pjb0UxN0VzRXF3bTRPWENXZE43cERMeGhqWGI2VmhDM0Z6eEJkbzQ4?=
 =?utf-8?B?WkcrYmN5ZE03N3dSWTBwMzdVbmRtS0V6ZzMvMnlobWlSTHdGY0dGL0JSQ3pp?=
 =?utf-8?B?RGFMOWF1ZnMwcXUxUk13c2laQ3pVcW9NcEZSdjNBcEFlTHNZZUpreFZwY3ZS?=
 =?utf-8?B?SUNkcWpWczRKMklTS3FLbkt1WktZeGhuOFd3Z3czMjgrRFYwV2hXSjdVd056?=
 =?utf-8?B?RmorbUlqNTA2NEl0N1cvRHc1cFdidmZoaS9lOFlDRytjdTJvb2hxZHo0a3Ay?=
 =?utf-8?B?cFVubDhyblNKMUFxRmlKWUhNWHQrRUFSTGVjSm9tbStxdlpnd3N5aWUzWlhU?=
 =?utf-8?B?bnpWMTBzaFVCUW9vT0RQZ3ZnaXAzT3NwL2ROdjA0TEcwMHZ6UjcwSDJSSWNL?=
 =?utf-8?B?MUQyRTNIdXc2YlFmYXQwQlRNMXdQMGtkeW5Fb2ZrQU9wcXZlRzJQbFBhZ0Rr?=
 =?utf-8?B?WkNMeDk3ZnFFZkVVaVo3L3RrUlJ0TzgyeUw2V2o3UG5VRjByZzBFL2NlZVU0?=
 =?utf-8?B?Si9IbmZJLy80Rm5tTUlLU1p4dmlTdGxhT0t2dS9zcFN4Vk5wYlhaNzZUb2dE?=
 =?utf-8?B?ZkdqZUVHTUFsUlRvQm1QZ1VZb09mcVBleW91aTQ4UGRSZ3czUWZ6RlBhbE10?=
 =?utf-8?B?VUNiNDQwQXNUN0lRZUhXVTZIY2hrRVJsWVJFWmZ5Vi81c2w2bG1kNm5Zblpl?=
 =?utf-8?B?QVZJVEFpaW5tR3dwek0zNXYrVHhweUJ2eG5sOEdUR3FYQ0pxQ2VEMWpBMW82?=
 =?utf-8?B?d0xadFo5OXV5OHpkajNHRUZBN3pTUDc0a1ptSWJ4R0pXSXZmekE0cVQ1MVh5?=
 =?utf-8?B?a3dJaUpQZ3ZNZGxiWlRlMkhMczdONGZ1d05wcjN1UmtmRmNDaE9TRFYzN2Zw?=
 =?utf-8?B?blU1akpXNEtXdFVrekhsd0lZc0xMeVhYakxHbWx0N3BGYjdWaG5Kb0FYeFpD?=
 =?utf-8?B?UE9XM296aC91R2lBdTcrVlhaaVlrNmNyam40bjdxbnpnV0pmc216WURNWmhH?=
 =?utf-8?B?M3pvbzZqYWF1RVJORjViaW5mUE1pUUF6MVl1RUtNWGZQQ21SUzdjQzZaTllP?=
 =?utf-8?B?QVVhVVFYZ0NxeDh3WWo0VURnQk8wdDF2NXJOd09IMHJQMm5FeDBNcFpIOVlN?=
 =?utf-8?B?THVVU0U5M3pkVkJiVVpFZXRDZTNNWlNYbkJkbEhVN3czZzRYdmpKR1JuOWVO?=
 =?utf-8?B?UVZ6RGNHUlh6SGptSk9XNG05cU5GNkc2YTVpNHhlZzNWTkFnMnFKTFh6Mzhn?=
 =?utf-8?B?NDhZL0U3NkxJb2RzQnU1SlJsZXJKS0F2bDVsY1ZJMnJVSURRV3ZpKzl5WHhy?=
 =?utf-8?B?UUs1Yk9wL2ZocU53VnlKaUxGUVNHVHVCU09xUjlXMmY0QndWRXVkL0VkZjls?=
 =?utf-8?B?TjVSeVZMV0tRNmdnbG1yYlFOM3FyeERRYzkxVi9pMDZRZnVrUVhjcE0wQmtw?=
 =?utf-8?B?SmVPVi9CdDQyRFpSQ2dSY3QyTWxidFpxcVNGdFJaOHFoWTByeUhNc3J3UnJs?=
 =?utf-8?B?bENGR0J5OFMrSUI0ZnZPSmZRL1hBYU9kVjgrSzQ0V3NHUTVwelhpN0pid1BF?=
 =?utf-8?B?NDZObmcwSGVRMjMvTTZ0NThKcUEzdTZlVzBCWGlHMWdzc252WHRnNlJqa00v?=
 =?utf-8?B?VGVGQ0JRbU1tQzJSbWdxRjJaWWxRY0Vlc1dlY05PUERoN3hvQTV3MmZsL1FC?=
 =?utf-8?B?R210dnA4c3VvMWxKQklHdDlmMU1GOEVHSkJVbGNVNVR4RDRRUWp0MnlNTEhC?=
 =?utf-8?B?VUVQQ3hmOWpuZEVvaXpIQ1pyR0U3QVFUK3R1b3FhdnFNUGtXTklHaGc4L3Er?=
 =?utf-8?B?dnY5US9MM0xnb0JOUWw3YVFxL0NsSWYzL29paHpyNnRkWEtWeEZhcTh4ZVU5?=
 =?utf-8?B?Q1ROeEExMXpYdmZUNCtiVTY4UjNqZHlXcDN1bEtzMlREYm5JMjllTXFkTG9O?=
 =?utf-8?Q?5v3VODfIoNRpNE+qa2cLdto=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bef7ce7-bdc3-4ee4-7e46-08d9bf14ba36
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:16:39.4879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hueLzPLe+CO3Bz7f49rVve7wP4xN44157G+R0WFqW6B87Auwgrro4qsPf2UMMBlTCM2+SL/ipSxwHNBzYGYmzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384

These exist for no reason: The code using them is only ever built for
Arm32. And memguard_guard_stack() has no use outside of x86-specific
code at all.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -2152,8 +2152,6 @@ void init_xenheap_pages(paddr_t ps, padd
     if ( !is_xen_heap_mfn(maddr_to_mfn(pe)) )
         pe -= PAGE_SIZE;
 
-    memguard_guard_range(maddr_to_virt(ps), pe - ps);
-
     init_heap_pages(maddr_to_page(ps), (pe - ps) >> PAGE_SHIFT);
 }
 
@@ -2169,8 +2167,6 @@ void *alloc_xenheap_pages(unsigned int o
     if ( unlikely(pg == NULL) )
         return NULL;
 
-    memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));
-
     return page_to_virt(pg);
 }
 
@@ -2182,8 +2178,6 @@ void free_xenheap_pages(void *v, unsigne
     if ( v == NULL )
         return;
 
-    memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
-
     free_heap_pages(virt_to_page(v), order, false);
 }
 
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -341,10 +341,6 @@ long arch_memory_op(int op, XEN_GUEST_HA
 
 unsigned long domain_get_maximum_gpfn(struct domain *d);
 
-#define memguard_guard_stack(_p)       ((void)0)
-#define memguard_guard_range(_p,_l)    ((void)0)
-#define memguard_unguard_range(_p,_l)  ((void)0)
-
 /* Release all __init and __initdata ranges to be reused */
 void free_init_memory(void);
 



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:18:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:18:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246844.425705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Z5-00081a-4D; Tue, 14 Dec 2021 15:18:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246844.425705; Tue, 14 Dec 2021 15:18:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9Z5-00081T-15; Tue, 14 Dec 2021 15:18:03 +0000
Received: by outflank-mailman (input) for mailman id 246844;
 Tue, 14 Dec 2021 15:18:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xzzU=Q7=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mx9Z3-00081D-Qg
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:18:01 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 057b74c3-5cf1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:18:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 057b74c3-5cf1-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639495080;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=1jbemwLAmtHI34QcQmbKlum9w8py18HrlyvXIj1QkzQ=;
  b=ewAHiciJAjHnYNNIZ+CSMKqYoJ0nTf3JJHc6YMkzSvFwTpoi8Q78UZpZ
   mCTCpIU8nyhUfDS8u4nNqFB31+GzztWiPQVS65DQvgq6bqN3DIHn//FSL
   wCrDi+xerP3TN/xE3NelWHIukBioM/W7Dmh5Dsf5aWJrLKAP4hTjJ2zFF
   M=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DHwFUt6SWcOpMxXlWgS4Y3R1+5eWU9P1A7a9Apdxg7hx3V0GFQIjOj98k0fYRUd2fwrpyQPPmN
 +Tqk4S+AxJla55hWpmR4RZIRX3Jp9rhfxgRtKlRbezI2Oq5c7P3SlU5KiKaF7RSVCs1J2O65lx
 IKRPTotbb28Akd86V+LfDwZOcGw0grjloxODQDQpzREjlMZj2nWQk8gD3/tIRvAvrWJy9P2FAg
 O/fsJgom07MCuRGqaZabzKJ5He9kF0pKuYf4Z7CRy5l0bu1PJciXwXXVgoKP/BMJgvtiQUAKMG
 cZCAKyeZpvaoLfg1OqroWlvZ
X-SBRS: 5.1
X-MesageID: 59987521
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3JXI1q/kXh/jqM0BMcvCDrUDd3mTJUtcMsCJ2f8bNWPcYEJGY0x3y
 GoZUG/TaKqMMTb1eI1/b4+/oUsC6Jfczt42HAs9r3o8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg3tYy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhN2
 c4WuLiAeDsyI4vAnrsdWCBjSApXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcFjWZg2Z0URJ4yY
 eILeR5pd07pYCd3K3FIT84luML5glvWJmgwRFW9+vNsvjm7IBZK+KDkLd79atGMA8JPkS6wp
 W/Y/mK/HhATMvSezyaI9jSngeqntSHxVZ8WFba43uV3m1DVzWsWYDUGWF3+rfSnh0qWX9NEN
 1dS6icotbI19kGgUp/6RRLQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZgJQc4crkP8HeSc38
 FOPwNPiPAc0m5TAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfnW0jsv7cZo09SfDo17UZDRm1m
 mnX93Zm293/mOZSj/3jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5TOhAztJcvU/MBofAnrNOv2jxpiGGeD6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNZyr2N/YvPtzuWpRCIU3c+TLNDK+8gj1mOMcZSeN61Hs2OR74M57FziDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTP7hRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/KrTef1E4QT55UJc8A9oJIuRYokicrc+Rl
 lmVUU5E0lvvw3rBLASBcHd4b73zG514qBoG0eYEZD5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:XiGx/6G0yHYSBh6SpLqFd5HXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCD4qhoPRPAhxY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT
 GtqX202oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq
 iAnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDQ4SOo5kv8Z0YxHZ400vsJVXy6
 RQxV+UsJJREFfpgDn9z8KgbWAqqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv
 V0Bs203ocZTbqjVQGbgoBT+q3vYpxqdS32B3Tq+/blnAS+pUoJj3fxn6ck7zM9HJFUcegz2w
 2LCNUuqFh0dL5kUUtKPpZ3fSKGMB28ffvyChPhHb3GLtBOB5ufke+93F0KjNvaDKDgiqFC3q
 j8bA==
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59987521"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DSClVzpt+BJUaqBE47pkj7pXZ2IZxx++eUqCcTY4NBvKCqgcMhsm+G6qT7JY72EIkSUNf4+35dqzbI8QuGna8zZKW5/A4fP5be+JZbVxNZGvZkWLGj7lPDugcjmrrFBCacKy96wiBeKeMnrQik/fSF3+3rzvW9R5Ef8Y3dVEtC+j1zm+QvYPHMqCxHYG6UA4e105j8p+eoE+XkF+myhYcyNijtruTQDhKbUHfEdtYaYmy0xbhseMng4g8la4POrLI31+tiktzur+5hVgTsL0qiKCEaTRf80GMX0bqz2LqprTOGVfU31ibMWORE8ENMAzdw0Tf+tWaPN5JQaKCukrgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ybmFtDqrVx/mRF0CGZIbVJlc1SQ5iCYRNRu95LmTnmE=;
 b=e8uhzoJ2zUhh8Lgv8TAbDHdDtdyXgB8sMwgMsTD5EJ/ooxHaHh+f7rUc2K7fvZSzwHgdGtrjhVs4ZWwjf9JoTBM0oA2/5zjfyBhoaIvnHrcLcUgh+W7bVATvOdz9KeN9ZUTxSC5mK12gudrSWK5a5ASR1bDu7vQN4VgvRRue7rgKCXkyBUXiFRKv3wl3CMmRMjnTGNGyDOdQiyjAefUb43tglLT0C4vihjH//NYt6yidNNF3+bfDK6XktzPbub2Mp1rhFhmKkCHfmr0yQR4b/MttSzlwzE/jXxfvjqhwqRXyep46RetsdDxV2Vco0HRV60U3zzeCZ3KRJxv4FQtnUg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ybmFtDqrVx/mRF0CGZIbVJlc1SQ5iCYRNRu95LmTnmE=;
 b=ulsdjIE0/A9YD52GdAme2Otc4D/bKwa9z/z4qFnI85Qmy4VIzQ3W79G/G9MWZ1UotudYokdOxFw33RLjbwaXsvC0zwUUG2WzxIFX5L/GGRnbph/2lK6qV02wMozRysJhNKUW81yv5lnC8N6Jqfl8J9i1N0B3qhlh42H1FOwt3JU=
Date: Tue, 14 Dec 2021 16:17:52 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Message-ID: <Ybi1n5uyLop/4wh5@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbizA1adGRRIlcTv@Air-de-Roger>
 <d05185f5-7ef3-4a76-60d1-0db38041baae@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d05185f5-7ef3-4a76-60d1-0db38041baae@suse.com>
X-ClientProxiedBy: FR0P281CA0048.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:48::10) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7c393de3-1d61-4a80-98c9-08d9bf14e7b4
X-MS-TrafficTypeDiagnostic: DM5PR03MB2490:EE_
X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr
X-Microsoft-Antispam-PRVS: <DM5PR03MB2490B1B39A4F9C27174888F98F759@DM5PR03MB2490.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 16DEIF3neIo+hlItoTgTW75n3zFY2kYgqbD+/GqsPQBHd0R5HucKGhwz9uQLd8u/rYsYnw/jDc16qEdHBKHgAemkDUosOraljm8ufQkEtZ2Nw0k3OAZbuXLshzyYXEtRgBA0S61Nnx+lNpxqrYpXkuZUZXqGgcvPEkv3yKUNV9G/Wm6KYf2Hr3is6H4xU+xFRJTKxb0CYe5sdDlnSAtyD0i32ejDggFOU33R7Qn+Gu7Bja8ZuS94NRYdpA8kopQpqmVDa6WR6+sAqkuFPM/vqDWACLxf9gOC4V/hJCRGQwg8fYww+YsGgasaWxfDVGCB+4cOMyonovirFB/3trtyvIx4k4Ie7F9XtB678aAmGHQvlxwQx3cuVcSOMuT1rSLdO1bKtvaIJwMNySItVXe/UEIsqQqUtej+id0eZfWbHxj7iJTOkobTF54jGjVPZSe5h/rTtjhErwq1GTU8SGes6g4W79soqV/pI8dsljeu1oiogScVECXHaMG7ENvhU55ilm3u1i7GSlMTRHznzVsyMbfHUaJg7ydjtg6WSmLLuAwbPCuUL47Np9HCpbgs2m/AdX13xMyWKPqJL7+iNPpnIP8PEg3/RHp0jiUb4pxa5rWBH4IHlfQdaYf8oNpoEk0zGHHdgZ1toraR11Yt4nM2NA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(33716001)(4326008)(6506007)(53546011)(85182001)(508600001)(54906003)(6666004)(26005)(6916009)(82960400001)(66946007)(38100700002)(8936002)(186003)(66556008)(66476007)(6512007)(9686003)(316002)(6486002)(8676002)(5660300002)(2906002)(86362001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGFISmkzdGhYN3F2Q0xnOExtTGF1ZlFROWladWd1TjAvSzlITExHTE93WURX?=
 =?utf-8?B?Mm9SRVNkYWZSVTl1bWVXSk5NR1JWWjBPbllTTGE5ODljU2VKRkdzNU9oakFk?=
 =?utf-8?B?MUY4RXE0YmNtR2JWVlhVbEhtTGpwcjdIWUlUSWF1S25KUFF2Qzg0YWZzWHdW?=
 =?utf-8?B?VHBpUHU2Qkh2SldBSmlqK1dPY0N2c1Bac2c4ZkxpZWdkUXFTVU5nOUpYRFJm?=
 =?utf-8?B?d1VSWWNIVVJaa0w0Ukt0Mm1lYlFCeEdHR3RsMjBzWDdsdlVIZkJMNmxMSWdM?=
 =?utf-8?B?aEJiMkhxZGhnSURvcm1MS0tzUTRWT2JucW1jR0ZUeStrWDNZeHYxYXVjZk9v?=
 =?utf-8?B?SzNtOEU1WWR2RXpZTzZjYk55Tkl1LzBwRnNWWmFxMFp1eEJKb1BXMmNsem52?=
 =?utf-8?B?ZlI1UU9IUXlyUGhOWVB0a25LclpCWVZ2dTlha3dnbGZWUHlYY3VsV3pkcklU?=
 =?utf-8?B?a3RaRzdPNG9CSnEyL0ZyOWZvUEZKZkJTTnJuamlCRytvbmYreCtqSFZKVEpy?=
 =?utf-8?B?ZnJZSjNhdncyWlUvMms3MUFubVdNNjhZSCs1VmlJclpPNExYUlFCb0ptbC8w?=
 =?utf-8?B?QWR6ejVKbVRNRFl5TkNCQmNna1FDWlpqbDNYS2FaZkNKUFd6d1diY2pxYnRP?=
 =?utf-8?B?SGVQWFcvUU1zUlh0T2tzZEIwanQzb2VhdEZBdHhlMjErQmFxU1ZYMDB4VFdC?=
 =?utf-8?B?bEhCSHBHVHMrUzV1WkVZWFNsRFF5Zm1iTHFHTXQrTDRsMzB1d3hPeEY2VWFy?=
 =?utf-8?B?a3pPZURMemhNZ1lZczRTTWZBR1BJOU1UdGJOK3Npdld5dXRJOC9CMXRuUW1D?=
 =?utf-8?B?eldTOHJZcWN5RjdoZlo5eWlRdFFZV2wwOUtkMVhCa2ZUYWNiT1RZTEVvVWpt?=
 =?utf-8?B?ZWg1R1IyUEw4Zk9NRHBaei9hblFXWmlvQlJyNU1CL0F0U3FzWVR4ZitZSGdW?=
 =?utf-8?B?V2xPN3hTK2RvWkpqMEdCQ0swU3BsdkQ2UzJPdnFQTjVDdmV6bWwwWFU5bXdy?=
 =?utf-8?B?MGxQWDB4OEZBNU5oYm16WjJtcElFYnpjV1poVTNjdE1xTGNtMksxckUvZGNI?=
 =?utf-8?B?bk11KzcxL0F0MGJocGVXR2FzU1JQdVNkMkF4RFFRQ3BTYm9SeTl1TEd0aHJL?=
 =?utf-8?B?cWNCM2l5cFBjZ3hHZEx5L1BBK0x1QlZycWRUUkU1NGtFeHhvZThJM1FCby9v?=
 =?utf-8?B?cXhmZ09xS3orR3pDNXVGVE1NNzJtVXlzQm5Qc2M1NDhObkZYdkZtd0pTSlhG?=
 =?utf-8?B?SlJkSVRHODRNblZoanBIQ21zTVczOGhyTlUxamRjWXR6TG9tMzlOeG5lUWVr?=
 =?utf-8?B?WVJUTkdSMGhObU51U0FXQU9UcW1KbHE1RlFkNXpoWkdFbXpWeFFXVDNJdytw?=
 =?utf-8?B?dHp4R00xL1dVS3JIV0RhakRZY096ZEVlVG1ZdW1nZk83R0czWUR3ZnBHcGJB?=
 =?utf-8?B?cGtvTVdhcDcrKzYyS0M5d3k2d3lKUmM1S3dydlBjRXVoTU5DY0liNGw3TnlZ?=
 =?utf-8?B?T29velZwUGhZMUFQSld5SWFSdnJTRlBXYnpXR3JnUW05M2dMa3VVWkR0ZDBO?=
 =?utf-8?B?RHVnOXVRK1hZb3llcFRXREJPRUwxeFVkODAxMmFHQzMzSWpxS2dQclNrSGkz?=
 =?utf-8?B?T04vc1lkeVY5SS9uU0pIeEI0RHY2YzJPVHNsZTRoZGNzU2lMczByd0xJT3pl?=
 =?utf-8?B?dnhKRGE4WmJIcHBqbDMzaVo3RXJxbUpOL3BoclIxY0oyUW9RKzk0a25UQUVu?=
 =?utf-8?B?SE5oMWRtc0psaHNsSFdSaWlrU3ZwSGcxak5rQzhFcjd4UjR5UjVHblBHOUFo?=
 =?utf-8?B?N2lWa01yYXlpMzFleVBBZGNtazYrakpNMXdaTFhEZWN0dldmYmMveGprK2Vm?=
 =?utf-8?B?NnZYRFQ0c1REd1VNR0ZVMUhINEM1a0diejhxRFFDOWlDajlpbE9wZDhhazYy?=
 =?utf-8?B?UTdlOHpxODdyOWNraXBDVDROcFhEUEFRYmRwTEUvV1hGcnllUmErbkFPK2lE?=
 =?utf-8?B?QXNMRFFWTGVRRWtIbjJrUXlpb2FuditTemJrN1hDOWhxTnRXREtLSjE3cFp4?=
 =?utf-8?B?N2ZzM0JHbVpKL3JqbkNBUDVJY09MZldQanRmSVJZSWdkN1lFNGJwVlkvcFdk?=
 =?utf-8?B?WldWYlZTcmVaaWRkQVRUUXpNV0Q1NWJmamZxWTI4OHNjUnQwWmZLM05kYUU5?=
 =?utf-8?Q?wu05RgJbhBeaRV1arKgN6pk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c393de3-1d61-4a80-98c9-08d9bf14e7b4
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:17:55.9400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3HKkw3J89YSf2SNnNq5KgEUffFzo4JNuRhF66jXXa/dQGEhqkgEAjvIBe9y93TesrOgqniiFhWhBZn4YOe/Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2490
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 04:10:28PM +0100, Jan Beulich wrote:
> On 14.12.2021 16:06, Roger Pau Monné wrote:
> > Forgot to comment.
> > 
> > On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
> >> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> >> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> >> @@ -238,7 +238,7 @@ int amd_iommu_alloc_root(struct domain *
> >>  
> >>      if ( unlikely(!hd->arch.amd.root_table) )
> >>      {
> >> -        hd->arch.amd.root_table = iommu_alloc_pgtable(d);
> >> +        hd->arch.amd.root_table = iommu_alloc_pgtable(d, 0);
> > 
> > So root tables don't get markers setup...
> > 
> > 
> >>          if ( !hd->arch.amd.root_table )
> >>              return -ENOMEM;
> >>      }
> >> --- a/xen/drivers/passthrough/vtd/iommu.c
> >> +++ b/xen/drivers/passthrough/vtd/iommu.c
> >> @@ -297,7 +297,7 @@ static uint64_t addr_to_dma_page_maddr(s
> >>              goto out;
> >>  
> >>          pte_maddr = level;
> >> -        if ( !(pg = iommu_alloc_pgtable(domain)) )
> >> +        if ( !(pg = iommu_alloc_pgtable(domain, 0)) )
> > 
> > ...likewise here.
> 
> Yes. Plus quarantine domain's page tables also don't. Neither root
> tables nor quarantine domain's are ever eligible for re-coalescing,
> so there's no point having markers there.

Quarantine won't be coalesced anyway as the same mfn is repeated over
all the entries, so it will never be a suitable candidate for
coalescing?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:22:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:22:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246851.425715 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9cq-0001Em-O7; Tue, 14 Dec 2021 15:21:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246851.425715; Tue, 14 Dec 2021 15:21:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9cq-0001Ef-L8; Tue, 14 Dec 2021 15:21:56 +0000
Received: by outflank-mailman (input) for mailman id 246851;
 Tue, 14 Dec 2021 15:21:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9cp-0001EZ-EB
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:21:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91485565-5cf1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:21:53 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-8wwFTmsEPg-VD65Y11OImw-1; Tue, 14 Dec 2021 16:21:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7037.eurprd04.prod.outlook.com (2603:10a6:800:125::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Tue, 14 Dec
 2021 15:21:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:21:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91485565-5cf1-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639495313;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WPhPfrSkj9ANFiUdNv+LLOjW3A4h+KcEpAaqpqVYUeo=;
	b=QbEu+WeIZHe+83qeyd0FiPQQnnqzDXUjm5Pn7ez601sp34vyKp7HVweJvT9A+w/6BNXuwa
	TWYvyZAxFByef28jdR9dxnsqr63n9KzXs4YtZi4rYXXABOsleZ/dft6EsGEQLGln/q9BJe
	lmEMAkwDh2PiojTHOqX5aVWL/ews/5w=
X-MC-Unique: 8wwFTmsEPg-VD65Y11OImw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IKMVl0A5sIiGx5gPzP0egGh6qzNdh+8Ln9EFBhEanqvOmADPZy85qA4EACY+7FOTG4iv0myUu/bU5Cf/um6Jk4ROXKNmHzHRkjKM3Zn8HaXR2X+1ugRNs0MjYHCc7VWyCFjmMvOBxMubhpoodzCDTYwyTgiv4gEu2h1Rf6hScarhT5amfpAe+hZU8DEoOqWic/NYvqjOXw7J6VrbxaEmJqJEF51qiJ6e5q5lrQ8lO6ZuRcIBTf4RTXG3uD8RBa7J+W33nFEglfKy5R9cdNkAmVwljXHQ5b6U5+L4B4+7pB87KKAwqV2LhoUzLw87btxl+8D82LjNd2RRQC7Ft+Y+gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BuLwTY5RZx4Bn86K/JtQgfz+h+ld0WJ0s3DFkB/c9po=;
 b=aB7FkO9ZcBLgJOSZsSqvwmB65N3otHdMuHlJjYLz45IMzuu/QRyuPXY2caNEmHBqURp7UBbeudt7b5HAhaqa8C47bwFmFez+gKB2cMrMbBUrzQiboNQV1IxWm6YdHI1OvgyZ3OFh8veMyQpvZbrTEKkuwsf6IbKODXlBF2+Kgn47zATRI02W/RIyLAN/e0mEVsuDhnrKZ8diZy58SnZsDIHK3siJc7NwZ8sLNajRO7GlKSmgpUx8YNDdwrDPq8auxPyo1Tc6WYxuYfGTeFYyEJqPdR0Ydz7fPHfyOUl1TbEkNbdHAW5GpWfwxh8RBuh1VKQ/SfEhg7Ge5rF7vWYGUw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dce504e9-a4f1-1c85-61fe-274f2a96b091@suse.com>
Date: Tue, 14 Dec 2021 16:21:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbivUH/Er0o2PwsG@Air-de-Roger>
 <fb221da6-2ad5-e298-c582-364943b95198@suse.com>
 <Ybi1BJR+UybxeMMy@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ybi1BJR+UybxeMMy@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0002.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::7) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 759016a8-fc37-45c3-102b-08d9bf1573f6
X-MS-TrafficTypeDiagnostic: VI1PR04MB7037:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7037400E6E71100334E2C9DDB3759@VI1PR04MB7037.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	v0d9sP+ecq7CCUMTfzXgCx6oX6bewCaXmm1KFHgIFPK5h/Iexfn6eXLspQMyBK1g/lcdjEZmwhIScJk+m/TGOyKaD43nsi7MHbBR4Q8ctTXa7+iaJ3a5V5r4UI1y3YTXvRkxcQxvxv3UtGAG+7d0H4UsMwRe/mTqSuo55edesfJhWznhDLBdUnjUk6sBvQKxZV2EafdAY1xRvzHQyoiloamta7z64hQI74x7XASO5hTaEDZ3GZI3dFEOwFUgeMRpv8hH9yezoOEjbh4sndgQUgk7KcDjn9OyLF7nmVvhHzz4TeAQP+JA7tgFfh0240KGNLCH3nLgAviVebuTUFD9r5O5RNiSoUx7SXsstTKkuyZOrss1xeNTvJxMBslQx8DwmA1elGcFYBqsIAoJLW0ivg1MW5qJQ5bQFHhPJ/P/f9Oet3rYwqhW3uk69CHVWsQjeKnVLT0n6YQ+sRb0EV/nrmURBLjWmF2nqFUQNE125uO9a+UeZS87SPSuSK/FovTk9AbXNprmTJ4RTSN5fR/SFgxHVEoyczIhINzaU0Eh7u/jn5Nze1ZTfoYgg2suqd3Gq+B7VibowYhig+dWCMTtN/qANWI1gKlh1xCZ2l9FGUpxNLZCWF9uaswCh5Mo8AsEk1t4l4GIRDEfvM3qZb5mG0JJGEaa35tmHkQJ5Ii+t7d5tfZlUBvOTua4iFqKEseQ56LDyhGKawgoDUnzBCx0JBMwLlC8lqcvJopQ8W1Ndyk+xeF7xrgRZVo/m2MdjjzX
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(38100700002)(66556008)(508600001)(4326008)(31686004)(86362001)(66476007)(36756003)(66946007)(2616005)(6916009)(54906003)(186003)(26005)(316002)(2906002)(8936002)(8676002)(6506007)(5660300002)(6486002)(53546011)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JrEl8bRf3NoivIWVcbuR2U1p43YvNheFAs0RKibVT5u0FB45A9yww0ZUeQyv?=
 =?us-ascii?Q?+pjJMmh9PO68tjTrbI4fdNiOHxy7PLnT0McGWffa/9ERdzq7Db07+I3WsLzi?=
 =?us-ascii?Q?jjgGZ1XD7LoWSkmqr0TKuCKVdVUBMzC5B43NMHIHc9HvRoVzaZKOV8pSu2wQ?=
 =?us-ascii?Q?VPeRa7lbS9+CaPVbPZwbLAFM+mPdCMwFi7qc5sLbqzG1kkXY56n40tczKsBk?=
 =?us-ascii?Q?t4ZThUnOuhuGAvik/AFpJPwsBDa3b0lDzqm3yDdFGw5z2cSchBfFH7J202sT?=
 =?us-ascii?Q?V3WnBhSguyR8RqnjS3F3AOh08dw8PSaulbL+H/nbGwxbyrducbfmaxg2rgO0?=
 =?us-ascii?Q?ljoaG3+mTOrB081fXnad+rICjJRHeuyWPVZskZ8I0hT3yei0evFPGDDrO8Y6?=
 =?us-ascii?Q?Y8j288ArgvcSjXnq+mXqy7VYQFtEG8jI4eY1qb415Fk4sYINzbO8RLnVnwly?=
 =?us-ascii?Q?Oft/F7I7Bb2WDWWQOpBBu17QybLto99FpL7qnEdKqsAtzSkV6o0CeGfZebLD?=
 =?us-ascii?Q?UsHvFeux74B2nt9Q4/gRtezwJNSBf/2PMP2VgtmBIKeOS27Icngrsqbu2eQh?=
 =?us-ascii?Q?f5QzoAPuxeSxIBOR3anyzz5enYBBB7boO6HJ9syWEBoB3bcA2VErSqU/2rpr?=
 =?us-ascii?Q?O0ZfIyr9OChxjBLMUKs1vKdxcvVppSS8W6DAxTWYYgjmo4JQNeieAowuivgG?=
 =?us-ascii?Q?4CodOd5QhbkGWXfDct0tceO19pMxTNDYfbDMwNql0T4W/hEQDbhzevY3Gu1D?=
 =?us-ascii?Q?oAIVBj3SRYRvv7HSJvWdmnuOBtlj7q0LleF6i/E9SidRfCbD4zzDDcS+quC6?=
 =?us-ascii?Q?m5/zHS0YeSTlIqOVZ5PU0NP3IcicXbSAtoFHCXvSYDyrM+K6UvjZdEVNlJhf?=
 =?us-ascii?Q?fKmwKNE8WQCipwCt7V+Oj8hwpq+A3J/VH/gSDoZmMH/22DbXo0N18bJEFslW?=
 =?us-ascii?Q?Q0f3o62EmpEzbKw7J9qztxZcAkASuPEMGXv40wHLi9w7NPYN/rSUzy+UZ1SA?=
 =?us-ascii?Q?nVzrrxX0QxwiErFhYwwIWUBQlyeNTFNN7ZCR/lyraM8DrGOf4IA6lLTsnwMN?=
 =?us-ascii?Q?EJwmsn+I4lVsTBCliyICN5/Qlp7ZYBiCDhksbEWIrrcKmbmR3lZ4tdS8K0/V?=
 =?us-ascii?Q?/QHS3oPIFLRE2qUP8HokwSlrRPIAH5g2+9pXp4liEyjdzrLuupKNDdv4Yf62?=
 =?us-ascii?Q?l61gzcCRGE6kyk3wjc/cVQiGP2ZYZRYns+wG3xAKtoKoAmzi86XH/GDBjWq5?=
 =?us-ascii?Q?jDO72XSZPx94Jp3NBzUY0x79eS5Ale96nCye22S7BwRk9Wc0QW9kjxOLq5Hj?=
 =?us-ascii?Q?nqgMTekpH4aef6aosUWXUMFs77iJi4PhLSZI1ERhBy/YGycBLLWtr1oZ/kbn?=
 =?us-ascii?Q?OqcIjx5EibWKY0bCVG+HfUawqJE4kHBkpulm0mZ/HdAhZFwPR/YpePsziElb?=
 =?us-ascii?Q?eezHTvDfQQ1sgdI8gOumH8yLPG8kUA7ztFsr/jO+gYggIXj2fUENG22IiVIE?=
 =?us-ascii?Q?sScatyBep4Z8CdvG8+bEgi/0QLIeDqYpfTZHiIPzjkMEFVDhqnnWPMvAftqZ?=
 =?us-ascii?Q?/cSZ40DP9MK1r8o83hlV508tNIqm9rE8IrpjwYybBVWn2XjOh6fZUpaAJPod?=
 =?us-ascii?Q?NCaX8Aas7Ze2SvcF4JmNIlY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 759016a8-fc37-45c3-102b-08d9bf1573f6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:21:51.1469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n7P4Zrsm03SVZcC32WbAWwL6zunkC2QbnMla5gp6In8NlDkaQv+Q+QMY0aVdJtVg+fkQvZ3Yfr0MHhUviDJTmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7037

On 14.12.2021 16:15, Roger Pau Monn=C3=A9 wrote:
> On Tue, Dec 14, 2021 at 04:05:27PM +0100, Jan Beulich wrote:
>> On 14.12.2021 15:50, Roger Pau Monn=C3=A9 wrote:
>>> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>>>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>>>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>>>> @@ -116,7 +116,19 @@ static void set_iommu_ptes_present(unsig
>>>> =20
>>>>      while ( nr_ptes-- )
>>>>      {
>>>> -        set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
>>>> +        ASSERT(!pde->next_level);
>>>> +        ASSERT(!pde->u);
>>>> +
>>>> +        if ( pde > table )
>>>> +            ASSERT(pde->ign0 =3D=3D find_first_set_bit(pde - table));
>>>> +        else
>>>> +            ASSERT(pde->ign0 =3D=3D PAGE_SHIFT - 3);
>>>
>>> You could even special case (pde - table) % 2 !=3D 0, but this is debug
>>> only code, and it's possible a mod is more costly than
>>> find_first_set_bit.
>>
>> Not sure why I would want to special case anything that doesn't need
>> special casing. The pde =3D=3D table case needs special care because the=
re
>> find_first_set_bit() cannot be called.
>=20
> Well in iommu_alloc_pgtable you already special case odd entries by
> explicitly setting the mask to 0 instead of using find_first_set_bit.

I don't consider this special casing; instead I'm unrolling the loop
4 times to simplify calculations not only for odd entries, but also
for those where index % 4 =3D=3D 2. Unrolling the loop here just for the
assertions doesn't look very desirable.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:24:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:24:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246856.425727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9fG-0001qD-6C; Tue, 14 Dec 2021 15:24:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246856.425727; Tue, 14 Dec 2021 15:24:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9fG-0001q6-2H; Tue, 14 Dec 2021 15:24:26 +0000
Received: by outflank-mailman (input) for mailman id 246856;
 Tue, 14 Dec 2021 15:24:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=C1I2=Q7=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mx9fF-0001px-LW
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:24:25 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eab3baf7-5cf1-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 16:24:24 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43026)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mx9fD-0002Do-7i (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 14 Dec 2021 15:24:23 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2A91E1FDB0;
 Tue, 14 Dec 2021 15:24:23 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eab3baf7-5cf1-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <f7c89a9b-cfb6-5489-c55a-419d687557a8@srcf.net>
Date: Tue, 14 Dec 2021 15:24:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] x86: drop/replace MEMORY_GUARD
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <f751205c-941a-5ce0-44a1-e8151a1a0887@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <f751205c-941a-5ce0-44a1-e8151a1a0887@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 14/12/2021 15:13, Jan Beulich wrote:
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -642,7 +642,7 @@ void show_stack_overflow(unsigned int cp
>  {
>      unsigned long esp = regs->rsp;
>      unsigned long curr_stack_base = esp & ~(STACK_SIZE - 1);
> -#ifdef MEMORY_GUARD
> +#ifdef CONFIG_DEBUG
>      unsigned long esp_top, esp_bottom;
>  #endif
>  
> @@ -650,7 +650,7 @@ void show_stack_overflow(unsigned int cp
>          printk("Current stack base %p differs from expected %p\n",
>                 _p(curr_stack_base), stack_base[cpu]);
>  
> -#ifdef MEMORY_GUARD
> +#ifdef CONFIG_DEBUG

Looking at these, I think we'd be better dropping the ifdef and
compiling it in unconditionally.

This is only used in the #DF path, which is a fatal error path. 
Throwing away information we trivially have to hand is actively
unhelpful to whomever is analysing the logs.

Preferably with the ifdefary dropped, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:24:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:24:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246857.425738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9fH-000264-D9; Tue, 14 Dec 2021 15:24:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246857.425738; Tue, 14 Dec 2021 15:24:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mx9fH-00025v-9o; Tue, 14 Dec 2021 15:24:27 +0000
Received: by outflank-mailman (input) for mailman id 246857;
 Tue, 14 Dec 2021 15:24:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mx9fG-0001sI-Mn
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:24:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e72cee7b-5cf1-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 16:24:17 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-Tv_BzGrHPyGH_wIxvVA-dA-1; Tue, 14 Dec 2021 16:24:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Tue, 14 Dec
 2021 15:24:22 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 15:24:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e72cee7b-5cf1-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639495464;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UtZxlfH8PKpS2a6kHCZoRLzPD8KLVCoENPmqGmdfmjw=;
	b=AkM5owehHrl1Ns3P9kKcg8cmCbO95VHpY5B31BCc/PAPK01LewUMpfUC40NBU///4kHSHF
	LLcJBQeWbz6FctkBU+vASdQh5UIXPB4NBm6uzdQSeOmKbAl9rJ3M+5knNaLcysC2xYBs1r
	HS/Tx8CjkEkPJ5UbCQDee9AaOTkmpVM=
X-MC-Unique: Tv_BzGrHPyGH_wIxvVA-dA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=atse2+mdvbLOEpvr47T5MGbdlK45H1j+klyO9FlKzsDRj/7BG6nSQB1OXYhRmIdtJ9D7MX3PITN2403Ut56dsaHG4tS0AlpUiLvZdL8Sb2GbiA+ib0GTbnJmTckP7VNIgHNl0+wAGhZmFEARMVgqhmafi2uX3UMU+za7LcLcrZoeUQNAzsekbixTqY84fKmu9FTnLpTSZjLrclprlQR7c+pmkI4fEN51WLbQ5d3z/G+wpEpdnSq61nIjHa2fy1j5szF8rbSFg41ZD4DDpz3ptBdVo/JJ2Z5Xl0zNUGgZuvw41saJLNkfap21SPWfg5I56msVJKlq800se8WW1UPMtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5j6m3dLNLPywJrdFr4gfP8MYpoFpIDzg+zstgRxf52A=;
 b=XW2x8KbHQl6gasW+bB8gxt7+FVfkGqjtcOqo9ab2plmeE+i6tPVdzX3eNaJzHFYsny7XWh7B4WwNzEuURD3DcENYISWgBvyuOCTzi5jKSn3Zo/Wa5Vy8tGn9TXXKnEzvGMzK52R6CE0+ONjLkHu8n4Y/pXhqN3WLvKfbprUUFBq3s2bGYqbPkKKh8Vn3p3kiRKEPSwp7IrJYJOenS6su8qBjeUjxaibs2iTmIlCIIzx0jxGirXc6b/sfs+Wlj060q++Rq5S9i8c1o3gG4zlIduDsfRlu2+sa4ShKtu2fi4aCs8xYhkehfDnnV7ucN8SWyg+7tCh20/JHTHYmGLOAMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <294a013d-f6f2-a345-3dfc-988ead108d49@suse.com>
Date: Tue, 14 Dec 2021 16:24:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 15/18] IOMMU/x86: prefill newly allocate page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <2656844d-47cc-70c3-d7ce-7d83967d576e@suse.com>
 <YbizA1adGRRIlcTv@Air-de-Roger>
 <d05185f5-7ef3-4a76-60d1-0db38041baae@suse.com>
 <Ybi1n5uyLop/4wh5@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ybi1n5uyLop/4wh5@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0014.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f25957f4-404e-4e15-bf45-08d9bf15cdd8
X-MS-TrafficTypeDiagnostic: VI1PR04MB6302:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630221ADB1D2C58B8577928BB3759@VI1PR04MB6302.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Mi/wlS2BXLS+hW+ccSmp5zF5BGISFjbj1K13dZU+z3QjVKfiY0A4K2QPV068xLf7zt4rljbX2AMwpUPMuadixUsiokErLGx1KiqJT4nNtJgBLX74sRaUSB/IragLGRYZOG5DI+4OCP8dcdhna7IohFXprXxVJIU7qyOFPVVM2TFDgBzE6Vh6OkmFyZ5/qS4JBeObGPvqPh18q1zmWYU17FAMkNrsH5TUvo/xWCHG7pYnJ/Bldmv7SWN4HuL4/OMhnG9Ofl8klXNDBqG0S5xegDSV5Sod+lfM5zYlOU6ME270JkvCR2mhfD4cRPLRSkVkkNYGmX+OPxR9kd1uB7NKUM8D7izOEn52ZTBbZ3Za1V1ADe8eev7E0shYtkOpBkjjD86G1fJe29UDFyeM8L5/OM+ANu7XaDNWUTn6w6gADgnz1tjktLLU+mZfB8MUMRvgclKZTm/tPmLLyZ/j8LRd8ivjABGcYSu2OxxsnO0weqTmyMJu6hC8j46Rvryuv1l2hhCDhjON0gqcQf3YAEPkVHtNo0AS745B/ImO9uIHDKckkOMwY9rbUlmXAu4eUMU2u/NIHothtWoH1G9OG1RFZNRj5zCQG6gNk87W+9hC26Za0umPu8RS6egm6kLg2DwaMumrXKu2EM8qnSgukFH5iB2ttcmsgm/UPrmVN3113O/TAE4+OJHio+JRA+T+PucXY4vnLSUrXMiuUpUs61OfAgjwUN6kv6uEfLxiODAsDzPu0CyYtaJa2yJm9XbsvLkg
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(36756003)(26005)(31696002)(53546011)(6916009)(2616005)(4326008)(508600001)(186003)(54906003)(86362001)(2906002)(8676002)(31686004)(8936002)(38100700002)(6512007)(5660300002)(316002)(66946007)(6486002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Rxv4HQB/aCMn7Kb5MTfozAclsxZ99gEcEuYyL5/5yoU1yCUuuNccfIcYqRlK?=
 =?us-ascii?Q?j1TUJXg/trp8/NT7/UFL205glE+JDWVotICPtQMfjL0nBRZtUjTmYT/ZxoY+?=
 =?us-ascii?Q?20YXzFKader93qne6efGB3akmCihPZjZew6soJQyknumqrKgDA7Ym0bhoN/d?=
 =?us-ascii?Q?hZe+bZFRUNolMD2sPpTdfmrAD8JhTUHEpNuLKt8mNdn4vRPO/mKhxmeeDaTz?=
 =?us-ascii?Q?l65l7rJgFwAIC7zfLRen5xnDh08zJnHqQ/a1unqnT+Aoa3F67AHt9McnIv/6?=
 =?us-ascii?Q?D+Nm0Xacgiy/omr2GBL8iTVrPpmUrjywxpfLGQTkz0zXVO99GlBAuH4qwoZ2?=
 =?us-ascii?Q?xXuTTLyBV38uignAowTzvB+OhabiqX48Qh1nQxmg8DyD8gQfGytdPp+1O9oY?=
 =?us-ascii?Q?RpF65oTqOnZKK+oi7vMB8/RjNJxjL3hdUHNQofNd6khfqeE2NtLHsna9HgNz?=
 =?us-ascii?Q?un3J+kMhc+PulQO0fzEThb3qoMQPa32uQYS3XqsXpjgH3UQ3Hb2aOQiyWo/d?=
 =?us-ascii?Q?LAkkRz34WC0Lvycv4GA5wckMQbhLvtwPEFSw2t+9Teiph3wlWIrL1TOC4kJR?=
 =?us-ascii?Q?Q2RS+MK5xUqm3NY2FR5ztj/8B6reULhIWGpX3EY6X1Bzw31m5fsSXnLt8foN?=
 =?us-ascii?Q?ESIr9phRMtM5VkmHGfBx2VdXT0IeDBSvuF10XLrH6HSps7fWtnAsz/PxkVQU?=
 =?us-ascii?Q?vDBRS6X+Qaocl3JE5pVqZWapTtlAC4jkGI4ewX70cl7CWDi0Z2zAbzN/T519?=
 =?us-ascii?Q?wYOzyNW85jCuTC2ghMD0MqnykyUYkV6phtgmZNmKwFMle50lQZZXOmhbDUpN?=
 =?us-ascii?Q?eImGMFpDpr5mfuPx8BccZQqWqx+r3gkLmm/+vNDqv73JGOH4ErPgYU+fasaH?=
 =?us-ascii?Q?VYOTxvkBfM4SWZlOxz2jX9FdJoscaM4UeHqrdwlNyGq9LttGPHKhJoJs9sJE?=
 =?us-ascii?Q?oLTkKApFzI9pN1ZhJw7deMS/zR0ZPSyqC2k895ium/jm+Tj/syduK01Q/XgN?=
 =?us-ascii?Q?/4vlA/3k/L4iyEakk81T32IZNXRG1qvN4T3YCaU2QLhMq07lsywmqnXGQB/u?=
 =?us-ascii?Q?lgG2EIPaBb4omGRCWWPgsfqwNbZq8mFuXhZoynkNSkfy8R4CgtItEJC11A2O?=
 =?us-ascii?Q?X9ADLs/fCvgeFIAnR6fhwgQwKGu0AiZpimlDr3Gq30lB5Y1LH+hap1WvmNhW?=
 =?us-ascii?Q?EVilVa61fSr4tfohw7tMggKeEuvcAcWiwwcaOIyPq4sl+cWqYkylFipoD1VY?=
 =?us-ascii?Q?KeRdgTDPavpNzZ/yqKaAfqhxBd+rTt/pHcJ7f91z/IX3FcBL1thfRtIf5/WL?=
 =?us-ascii?Q?HCZ+8/J17imKTOMa3G7Jvix7Bfor4JIVsA5oe3U/WZ6X6UP97dcxzfs73mbR?=
 =?us-ascii?Q?QWyKv50+U7noDshw/lpAd5NDB7FhCf0nnh4otsBZQSpWAPA5LP/1ny9Egi70?=
 =?us-ascii?Q?jQXDFxSdzEbVem+ANKGfXKK4NzmK+9LVEZG8e/MkpKveLwG9aMPGbSScaNv/?=
 =?us-ascii?Q?6X07xT9UFmHH/CWQhJk7TZYJF5CxVjRuI9V+EQQbfMqmwc7oevLHo2u4aEcf?=
 =?us-ascii?Q?9ZnwEZP2DTKStZSwS5c3u4rhZV8jtsCtepoocj2qZCwcmHs2iau/wBLFgIZn?=
 =?us-ascii?Q?WpWf7zWwOi9UG5KGF/LNC0k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f25957f4-404e-4e15-bf45-08d9bf15cdd8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 15:24:21.9247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zM4a6zFn8jVI86CdGRyCmdk5sn7zwu3eXa1Od6QSIhh33wLoTv/MSlcHDvx+7oLkC7+hy906Yx8suKkq+gLkwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302

On 14.12.2021 16:17, Roger Pau Monn=C3=A9 wrote:
> On Tue, Dec 14, 2021 at 04:10:28PM +0100, Jan Beulich wrote:
>> On 14.12.2021 16:06, Roger Pau Monn=C3=A9 wrote:
>>> Forgot to comment.
>>>
>>> On Fri, Sep 24, 2021 at 11:54:58AM +0200, Jan Beulich wrote:
>>>> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>>> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
>>>> @@ -238,7 +238,7 @@ int amd_iommu_alloc_root(struct domain *
>>>> =20
>>>>      if ( unlikely(!hd->arch.amd.root_table) )
>>>>      {
>>>> -        hd->arch.amd.root_table =3D iommu_alloc_pgtable(d);
>>>> +        hd->arch.amd.root_table =3D iommu_alloc_pgtable(d, 0);
>>>
>>> So root tables don't get markers setup...
>>>
>>>
>>>>          if ( !hd->arch.amd.root_table )
>>>>              return -ENOMEM;
>>>>      }
>>>> --- a/xen/drivers/passthrough/vtd/iommu.c
>>>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>>>> @@ -297,7 +297,7 @@ static uint64_t addr_to_dma_page_maddr(s
>>>>              goto out;
>>>> =20
>>>>          pte_maddr =3D level;
>>>> -        if ( !(pg =3D iommu_alloc_pgtable(domain)) )
>>>> +        if ( !(pg =3D iommu_alloc_pgtable(domain, 0)) )
>>>
>>> ...likewise here.
>>
>> Yes. Plus quarantine domain's page tables also don't. Neither root
>> tables nor quarantine domain's are ever eligible for re-coalescing,
>> so there's no point having markers there.
>=20
> Quarantine won't be coalesced anyway as the same mfn is repeated over
> all the entries, so it will never be a suitable candidate for
> coalescing?

Correct.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 15:56:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 15:56:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246867.425749 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxA9m-000657-TU; Tue, 14 Dec 2021 15:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246867.425749; Tue, 14 Dec 2021 15:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxA9m-000650-QH; Tue, 14 Dec 2021 15:55:58 +0000
Received: by outflank-mailman (input) for mailman id 246867;
 Tue, 14 Dec 2021 15:55:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxA9l-00064u-C1
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 15:55:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxA9k-0002lj-2U; Tue, 14 Dec 2021 15:55:56 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxA9j-00035B-T2; Tue, 14 Dec 2021 15:55:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=bQRLehkTctN+flDSJ3RcpkVsQ+aEPcvXozrvdMCubdE=; b=0RXJvPJYN+2d0Aa2ekBDCoxEz5
	B+KVQDm2rtcGOQJTXrQEfJ8zcpkO3dY8Gp+msNSD4vD7sx1JkETUl+0Bk79HkmGY6So9cYYqstAyZ
	rnsN0bTtODiafpP1aMM21aQASCZCt7axoDsaRR0vd3bnWjlg4oruEVCYVO1P1hMuZpNo=;
Message-ID: <d41a193f-5b76-eeeb-2db8-e859136d1dc5@xen.org>
Date: Tue, 14 Dec 2021 15:55:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] Arm: drop memguard_{,un}guard_range() stubs
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <11f9f2e5-102a-247b-368b-29021f5e7a84@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <11f9f2e5-102a-247b-368b-29021f5e7a84@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 14/12/2021 15:16, Jan Beulich wrote:
> These exist for no reason: The code using them is only ever built for
> Arm32. And memguard_guard_stack() has no use outside of x86-specific
> code at all.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

> 
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -2152,8 +2152,6 @@ void init_xenheap_pages(paddr_t ps, padd
>       if ( !is_xen_heap_mfn(maddr_to_mfn(pe)) )
>           pe -= PAGE_SIZE;
>   
> -    memguard_guard_range(maddr_to_virt(ps), pe - ps);
> -
>       init_heap_pages(maddr_to_page(ps), (pe - ps) >> PAGE_SHIFT);
>   }
>   
> @@ -2169,8 +2167,6 @@ void *alloc_xenheap_pages(unsigned int o
>       if ( unlikely(pg == NULL) )
>           return NULL;
>   
> -    memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));
> -
>       return page_to_virt(pg);
>   }
>   
> @@ -2182,8 +2178,6 @@ void free_xenheap_pages(void *v, unsigne
>       if ( v == NULL )
>           return;
>   
> -    memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
> -
>       free_heap_pages(virt_to_page(v), order, false);
>   }
>   
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -341,10 +341,6 @@ long arch_memory_op(int op, XEN_GUEST_HA
>   
>   unsigned long domain_get_maximum_gpfn(struct domain *d);
>   
> -#define memguard_guard_stack(_p)       ((void)0)
> -#define memguard_guard_range(_p,_l)    ((void)0)
> -#define memguard_unguard_range(_p,_l)  ((void)0)
> -
>   /* Release all __init and __initdata ranges to be reused */
>   void free_init_memory(void);
>   
> 

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:03:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:03:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246873.425760 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAGm-0008D3-K5; Tue, 14 Dec 2021 16:03:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246873.425760; Tue, 14 Dec 2021 16:03:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAGm-0008Cw-Gy; Tue, 14 Dec 2021 16:03:12 +0000
Received: by outflank-mailman (input) for mailman id 246873;
 Tue, 14 Dec 2021 16:03:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q7Ra=Q7=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxAGk-0008Cq-Ss
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:03:11 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4eeebe87-5cf7-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 17:03:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4eeebe87-5cf7-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639497787;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=caysg20LYi0EhTAWT/KHfFYtdPiBMPQZuUXeSMnogUM=;
  b=Us8zmrah6j2/FqeCSEgfoxA9VoXurV6YdLmQZFqXevC3OE03ZYNW3pUH
   4HQAOTEyZynRefttJ41Fqc97v+caEyXE2utshDHLVVrWmBVkFomIWQmQn
   mxKsqzw5GoDl36RrISHod52si/nc118EfqlJSu8e0vDAnlMB/D6XCXPsJ
   o=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: XKX/I7FhXgjC+hJsx+R7vVltiq4NG0+XVhJkwfOqvlHQjsORA2Hg4wtEYZHbgYt6SE0VCDjgul
 XvipK2YVWDZvvCSsw7exfl3v5/P2IMnpYbwVT7jvmrmV6cuEsebP2rBXcS60tYJAmYCm641ZGo
 2hx9Z174wHhZW+EjaUpl8/LO+AMd9cnoozqJ+T9tU0dbGqNvQRQLS1T12O415GV3+WfPUQnO9n
 xca8OjK6JpqBscs+MNm0t3ZXv8tpNUJqN6IQVG4RF2M4ObPHuYiWkrmPINVGm9bhcH3g9Djhs5
 3175TgdLPK06lQ8W5cJdfgX/
X-SBRS: 5.1
X-MesageID: 60009620
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rZz4rKPRaBVDRmrvrR3QkcFynXyQoLVcMsEvi/4bfWQNrUom0mRWm
 2NJDzuPa67cZDf0fdwkO4Ww8ENT68eExt8xQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s/w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo3LYz9Es9
 9kOjJ2XdCkTN/bhvf9GViANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9o3pEQR662i
 8wxOTwzcCieYSN2C3A8D7Y7u/iJqFvDSmgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSdxiCC6WmEnfLUkGXwX4d6PL+l8v9nhnWDy2pVDwcZPXOxrOOlkEe4V5RaI
 lYN5ys1haEo8QqgSdyVdyO/pHmIrxsNQe16Gucx6ByO4qfM6gPfDW8BJhZRZdpjuMIoSDgC0
 l6Sg8ivFTFpqKeSS3+W6vGTtzzaES8RIGwZeT4fTSMK5tDipMc4iRenZtFnHa2uh9v5Awbs0
 iuKpygzgbYUpcMT3qD99lfC6xq2oYPDVAky5QP/V2Oj4ARiaYXjbIutgXDE6d5QIYDfSUOO1
 EXogODHsrpIV8vU0nXQHqNdR9lF+sppLhWb0A5uQqYttA2s3EONR4kLzRRlf0JQZ5NslSDSX
 GffvgZY5Zl2NXSsbLNqb4/ZN/nG3ZQMBvy+CKmKM4MmjoxZMVbeoXowPRL4M3XFyRB0yckC1
 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59ZYDNijchjtctoRTk5F
 f4FaKNmLD0FD4XDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4Jdc0w/4MzrqWo
 SDtMqO99LYZrSeYQeltQio8AI4DoL4l9S5rVcDSFQjAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ
 8TpiO3basmjvg/vomxHBbGk9dQKXE3y2WqmYnv9CBBiLsUIb1GYpbfZkv7HqXBm4tyf7pBl/
 dVNF2rzHPI+euiVJJqMNa/0kQru5SN1dSAbdxKgH+S/sX7EqOBCQxEdRNdtSy3VARmclDacy
 SiMBhIU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu/QVlL9UsAe7Q
 GyV/dxeNenbMc/pCgdJdgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYsadEr2
 +YsvsIS+jeTsBtyP4bUlD1Q+kSNMmcED/ctuKYFDdK5kQEs0FxDP8DRU3ek/JGVZtxQGUA2O
 TvI1rHajrFRy0eeIXo+EX/BgbhUiZgU4U0YyVYDIxKCm8bfh+9x1xpUqGxlQgNQxxRB8uRyJ
 mk0aBElefTQp29l1JpZQmShOwBdHxnIqEX+xmwAmHDdU0T1BHfGK3cwOLrV8U0Um46GkuO3I
 F1MJL7ZbAvX
IronPort-HdrOrdr: A9a23:+K0bd6mX85AttVytnd4M7/PIxZDpDfIu3DAbv31ZSRFFG/Fxl6
 iV/cjz8SWE7wr5OUtQ/exoV5PtfZqxz/FICMwqTNGftWrdyQ6VxeNZnOjfKlTbckWUnINgPO
 VbAspD4bXLfCFHZK3BgDVQfexP/OW6
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="60009620"
Date: Tue, 14 Dec 2021 16:03:00 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: <xen-devel@lists.xenproject.org>, Oleksandr Tyshchenko
	<oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Nick Rosbrook <rosbrookn@ainfosec.com>, "Juergen
 Gross" <jgross@suse.com>, Stefano Stabellini <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <YbjANCjAUGe4BAar@perard>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1638982784-14390-2-git-send-email-olekstysh@gmail.com>

On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> This patch adds basic support for configuring and assisting virtio-disk
> backend (emualator) which is intended to run out of Qemu and could be
> run in any domain.
> Although the Virtio block device is quite different from traditional
> Xen PV block device (vbd) from the toolstack point of view:
>  - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>    written to Xenstore are fetched by the frontend (the vdev is not
>    passed to the frontend)
>  - the ring-ref/event-channel are not used for the backend<->frontend
>    communication, the proposed IPC for Virtio is IOREQ/DM
> it is still a "block device" and ought to be integrated in existing
> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
> logic to deal with Virtio devices as well.

How backend are intended to be created? Is there something listening on
xenstore?

You mention QEMU as been the backend, do you intend to have QEMU
listening on xenstore to create a virtio backend? Or maybe it is on the
command line? There is QMP as well, but it's probably a lot more
complicated as I think libxl needs refactoring for that.

> Besides introducing new disk backend type (LIBXL_DISK_BACKEND_VIRTIO)
> introduce new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model.
> 
> In order to inform the toolstack that Virtio disk needs to be used
> extend "disk" configuration by introducing new "virtio" flag.
> An example of domain configuration:
> disk = [ 'backend=DomD, phy:/dev/mmcblk1p3, xvda1, rw, virtio' ]

This new "virtio" flags feels strange. Would having something like
"backendtype=virtio" works?

> Please note, this patch is not enough for virtio-disk to work
> on Xen (Arm), as for every Virtio device (including disk) we need
> to allocate Virtio MMIO params (IRQ and memory region) and pass
> them to the backend, also update Guest device-tree. The subsequent
> patch will add these missing bits. For the current patch,
> the default "irq" and "base" are just written to the Xenstore.

This feels like the patches are in the wrong order. I don't think it is
a good idea to allow to create broken configuration until a follow-up
patch fixes things.

> diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
> index 70eed43..50a4d45 100644
> --- a/tools/xl/xl_block.c
> +++ b/tools/xl/xl_block.c
> @@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
>          return 0;
>      }
>  
> +    if (disk.virtio) {
> +        fprintf(stderr, "block-attach is not supported for Virtio device\n");
> +        return 1;
> +    }

This might not be the right place. libxl might want to prevent hotplug
instead.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:20:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:20:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246880.425771 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAWm-0001gl-75; Tue, 14 Dec 2021 16:19:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246880.425771; Tue, 14 Dec 2021 16:19:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAWm-0001ge-3r; Tue, 14 Dec 2021 16:19:44 +0000
Received: by outflank-mailman (input) for mailman id 246880;
 Tue, 14 Dec 2021 16:19:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxAWl-0001gU-EC; Tue, 14 Dec 2021 16:19:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxAWl-0003jJ-4h; Tue, 14 Dec 2021 16:19:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxAWk-00022h-Qf; Tue, 14 Dec 2021 16:19:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxAWk-0007xr-QC; Tue, 14 Dec 2021 16:19:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Q7iWRRkw7Gh/BALpTdxyYcz+3J143dOabZRUiRQfZCU=; b=cUUXPKIJmj2BI2lI0F++vJ3o64
	05C0NpBbmafd6Uh926lsIP6rbQqsqtsQMKb8FxEvGTu/fOlCHFsAR6ePScJpYmEfgYRrJGfI7qVk1
	4e+iTk6bm0bj9hJ4ivX2wrnMJti1luWlwY1lDptu/KxbtjIVAS5jfetFGP+z7dEieQHs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167405-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167405: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=497e6f5fa6504cd0390a228befb410c16b959135
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 16:19:42 +0000

flight 167405 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167405/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              497e6f5fa6504cd0390a228befb410c16b959135
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  522 days
Failing since        151818  2020-07-11 04:18:52 Z  521 days  503 attempts
Testing same since   167405  2021-12-14 04:18:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 88693 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:23:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:23:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246886.425785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAab-00033w-PY; Tue, 14 Dec 2021 16:23:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246886.425785; Tue, 14 Dec 2021 16:23:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAab-00033p-Lu; Tue, 14 Dec 2021 16:23:41 +0000
Received: by outflank-mailman (input) for mailman id 246886;
 Tue, 14 Dec 2021 16:23:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=twTw=Q7=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mxAaa-00033j-FG
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:23:40 +0000
Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2fd4dcf7-5cfa-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 17:23:37 +0100 (CET)
Received: from lelv0265.itg.ti.com ([10.180.67.224])
 by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BEGMmuO025468;
 Tue, 14 Dec 2021 10:22:48 -0600
Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38])
 by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BEGMmM0085080
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Tue, 14 Dec 2021 10:22:48 -0600
Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE108.ent.ti.com
 (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 14
 Dec 2021 10:22:47 -0600
Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com
 (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Tue, 14 Dec 2021 10:22:47 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BEGMllf122522;
 Tue, 14 Dec 2021 10:22:47 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fd4dcf7-5cfa-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639498968;
	bh=j8vcNDlyu6rGGlbNXrHIPndlfNexrjOXKWOfEEIJnnk=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=xgTGUZkLvFa0MkQp65s/DUVAeZv9Jh6bDvETBxkkXt9kHUJh2S2ely6DWwhAEv7nE
	 9sCLwo7TGhPOwJHN4Tpl9RtuWpdVoaxfjasPPolvZWeFEwB03D/XW8/nuRUiuxjvP2
	 bQ7FHOHAdSfs79apWvV8d5LiB3urN2udwFKj+JSg=
Date: Tue, 14 Dec 2021 10:22:47 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Juergen Gross
	<jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann
	<arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin
 Herrenschmidt <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, Mark Rutland
	<mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>, <linux-wireless@vger.kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Message-ID: <20211214162247.ocjm7ihg5oi7uiuv@slider>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator>
 <87fsqvttfv.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87fsqvttfv.ffs@tglx>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 10:41-20211214, Thomas Gleixner wrote:
> On Mon, Dec 13 2021 at 12:29, Nishanth Menon wrote:
> > On 23:18-20211210, Thomas Gleixner wrote:
> > Also while testing on TI K3 platforms, I noticed:
> >
> > msi_device_data_release/msi_device_destroy_sysfs in am64xx-evm / j7200
> 
> The warning complains about a device being released with MSI descriptors
> still attached to the device. This was added by:
> 
>   5b012cede0f7 ("device: Add device::msi_data pointer and struct msi_device_data")
> 
> That's not a regression caused by this commit. The warning is just
> exposing an already existing problem in the iwlwifi driver, which seems
> to do:
> 
>    probe()
>      setup_pci_msi[x]_interrupts()
>      start_drv()
>        if (try_to_load_firmware() == FAIL)
>        	   device_release_driver()
>                 ...
>                 msi_device_data_release()
>                     WARN()
> 

Agreed that the warning is fine, the null pointer exception that follows
[1] [2] it however does'nt look right and it can be trivially fixed with the
following fixup for ee90787487bc ("genirq/msi: Provide
msi_device_populate/destroy_sysfs()") below, with that the log looks
like [3] - the warn is good, the null pointer exception and resultant
crash could be avoided (not saying this is the best solution):

diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index ab5e83f41188..24edb870c66f 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -252,11 +252,14 @@ int msi_device_populate_sysfs(struct device *dev)
  */
 void msi_device_destroy_sysfs(struct device *dev)
 {
-	const struct attribute_group **msi_irq_groups = dev->msi.data->attrs;
+	const struct attribute_group **msi_irq_groups;
 	struct device_attribute *dev_attr;
 	struct attribute **msi_attrs;
 	int count = 0;
 
+	if (!dev->msi.data)
+		return;
+	msi_irq_groups = dev->msi.data->attrs;
 	dev->msi.data->attrs = NULL;
 	if (!msi_irq_groups)
 		return;

[1] https://gist.github.com/nmenon/36899c7819681026cfe1ef185fb95f33#file-am64xx-evm-txt-L1049
[2] https://gist.github.com/nmenon/36899c7819681026cfe1ef185fb95f33#file-j7200-evm-txt-L1111

[3] https://gist.github.com/nmenon/575afe7d04463026a7e420a76c2c1c5b
	https://gist.github.com/nmenon/575afe7d04463026a7e420a76c2c1c5b#file-am64xx-evm-txt-L1018
	https://gist.github.com/nmenon/575afe7d04463026a7e420a76c2c1c5b#file-j7200-evm-txt-L1053
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:27:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:27:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246890.425795 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAdh-0003fD-7B; Tue, 14 Dec 2021 16:26:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246890.425795; Tue, 14 Dec 2021 16:26:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAdh-0003f6-4A; Tue, 14 Dec 2021 16:26:53 +0000
Received: by outflank-mailman (input) for mailman id 246890;
 Tue, 14 Dec 2021 16:26:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KYVb=Q7=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxAdg-0003f0-3Q
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:26:52 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a4317001-5cfa-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 17:26:51 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id b1so37747048lfs.13
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 08:26:50 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b12sm31629lfb.146.2021.12.14.08.26.49
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Dec 2021 08:26:50 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4317001-5cfa-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=DprBb2HHkk6EbP3eN9JugbZna4UuXU1A8PcH+AUxVjY=;
        b=UjioMSsyc11laKt3otEung5PFsP+d9sQo7AZnD6z/FVW4iwGGfg0Wxdg/02M6F5/tF
         2xKiLG9CE++/vPlp+EYDnbBfXbfSTjwjxYHWRgzrUT0sgYu7rxsIOvR0mha/tVCGZs5x
         rj6/+L3Lr7+LHCnXl64DFSq7VeDqM4GajRv/x3Tp78eW5pFnMp6JanY/E9VayzHxHI60
         P+l0tJl/glWJJzhLs5BJycR3VqCMKhf8MHNBaGNcLk5XSv9A57Rfng/d1vkHXPBxwgRy
         FyuUn0Uzlxm/81z72XU+TIlDy+YRDfn7tpfM+bqaG+7xPcJVXgCAPr65wPQeuUn8HH7X
         zNfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=DprBb2HHkk6EbP3eN9JugbZna4UuXU1A8PcH+AUxVjY=;
        b=SfDfAwrVJhgl6KMzmkuQIje7WD1jOGhpGQ3tVXGpGyqeGs2oguTsAI/jr0N1aJB7yx
         uc7/cyuZQWLP7TZP2pT4A1IzWp77qvYgfCkfQbBtvglgIVjMgFmAWA+BYtcMbEJS3FFD
         WPtxTrtnY5gnlxHfEcWvjuLLKTvL7PJnhNcAxqq2ocHX5xa8VZE5Akh+30MghgsDy5mi
         CO8NCzryvaw+JY9eo5mI2JcV5++bjGubi4of6eA+6Mi9GAh7ySfqgtmqopLPymHMr/ZB
         m8oF6kxE2PFmLxnQalQVHxsehiiho5kDqPmtvPHqI5dlaWuziTV5J8aTob1HyQ2eJtXs
         xrwQ==
X-Gm-Message-State: AOAM530esp5EANBEc6bu/EYhvHap2bOe60PTJeOEzkQ4+T0bssk+VzIs
	f/6Rz3rZYrge6Rioj6MJxsBsxFIKf5g=
X-Google-Smtp-Source: ABdhPJxT91TfWjOQlICHfLdPuY595OGKYEiXc7q8AGWYh/XPV04shdbJiFsdkxE9NAnD2JKu+Qcx8g==
X-Received: by 2002:a05:6512:2386:: with SMTP id c6mr5707542lfv.166.1639499210321;
        Tue, 14 Dec 2021 08:26:50 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
Date: Tue, 14 Dec 2021 18:26:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 15:37, Jan Beulich wrote:

Hi Jan, Julien.

> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -1382,8 +1382,10 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d,
>>       spin_lock(&d->page_alloc_lock);
>>   
>>       /* The incremented type count pins as writable or read-only. */
>> -    page->u.inuse.type_info =
>> -        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1;
>> +    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask);
>> +    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none
>> +                                                  : PGT_writable_page) |
>> +                                MASK_INSR(1, PGT_count_mask);
> It's certainly up to the Arm maintainers to judge, but I would have
> deemed it better (less risky going forward) if PGT_count_mask
> continued to use the bottom bits. (I guess I may have said so before.)

If I am not mistaken the request was to make sure (re-check) that moving 
the count portion up
was compatible with all present uses. The code above is only a single 
place on Arm
which needs updating.


>
>> @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
>>       }
>>   
>>       /* Map at new location. */
>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>> +    else
>> +    {
>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> +
>> +        p2m_write_lock(p2m);
>> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) )
>> +        {
>> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access);
>> +            if ( !rc )
>> +                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
>> +        }
>> +        else
>> +            rc = -EBUSY;
> May I suggest to avoid failing here when page_get_xenheap_gfn(mfn_to_page(mfn))
> matches the passed in GFN?


Good question...
There was an explicit request to fail here if page_get_xenheap_gfn() 
returns a valid GFN.
 From the other side, if old GFN matches new GFN we do not remove the 
mapping in gnttab_set_frame_gfn(),
so probably we could avoid failing here in that particular case. 
@Julien, what do you think?


>
>> @@ -2169,6 +2170,9 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>       if ( unlikely(pg == NULL) )
>>           return NULL;
>>   
>> +    for ( i = 0; i < (1u << order); i++ )
>> +        arch_alloc_xenheap_page(&pg[i]);
>> +
>>       memguard_unguard_range(page_to_virt(pg), 1 << (order + PAGE_SHIFT));
> I think this and ...
>
>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>   
>>   void free_xenheap_pages(void *v, unsigned int order)
>>   {
>> +    struct page_info *pg;
>> +    unsigned int i;
>> +
>>       ASSERT(!in_irq());
>>   
>>       if ( v == NULL )
>>           return;
>>   
>> +    pg = virt_to_page(v);
>> +
>>       memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
> ... this really want to (logically) move into the new arch hooks.
> That'll effectively mean to simply drop the Arm stubs afaict (and I
> notice there's some dead code there on x86, which I guess I'll make
> a patch to clean up). But first of all this suggests that you want
> to call the hooks with base page and order, putting the loops there.

I see your point and agree ... However I see the on-list patches that 
remove common memguard_* invocations and x86 bits.
So I assume, this request is not actual anymore, or I still need to pass 
an order to new arch hooks? Please clarify.


>
>> @@ -166,6 +173,32 @@ extern unsigned long xenheap_base_pdx;
>>   
>>   #define maddr_get_owner(ma)   (page_get_owner(maddr_to_page((ma))))
>>   
>> +static inline gfn_t page_get_xenheap_gfn(struct page_info *p)
> const please wherever possible.

ok, will do.


Thank you.


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:36:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:36:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246897.425807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAmh-0005Jo-6o; Tue, 14 Dec 2021 16:36:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246897.425807; Tue, 14 Dec 2021 16:36:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAmh-0005Jh-3k; Tue, 14 Dec 2021 16:36:11 +0000
Received: by outflank-mailman (input) for mailman id 246897;
 Tue, 14 Dec 2021 16:36:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iTjg=Q7=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxAmg-0005Jb-12
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:36:10 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ec8c91d6-5cfb-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 17:36:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ec8c91d6-5cfb-11ec-9e60-abaf8a552007
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639499761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=jHkEiVG0BVT8V/9kbAcBq/GVsYt3jqgvF40FkGyKrlo=;
	b=x+UREoz0tV0ByegvETONzIcJg/btHkYAeUTOB9Cwk6fF4WS4tcdqSKPZhosLY9Kw8fzkL2
	iAO8dxlrohDcjOfDmK3UIx35hhe0gnfY1J6UUVxyO061FZZ9igOXoMxu0oZsfFw4GbgpYB
	Q5rK3Ehp3GsvY/ZWFqOBDe34LxDsXDQAfeXwgAzwLGuRTF6/6fajjiB+l4faY58KyXYRd9
	TRvQUMx4KhjpOhAQjyD53NZ44/KDHNZzen3o5CWSSmMuXJs7tSK49MGIkP5L/9Tw/0p3r8
	ob+7BJIhXKuW4vpCWZYdUoDVrJaJ+Ar127CVhFKQjgeiplPgqNc0w3IVyPx/sg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639499761;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=jHkEiVG0BVT8V/9kbAcBq/GVsYt3jqgvF40FkGyKrlo=;
	b=JRPDqiMesD5qMuzHSYGkN8LOEMskH9IhyPnRCqMbSThsy+YATwXU6QDtFhGJhGuZcxfILm
	UyvW8q3ctT/IqHDg==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <20211214162247.ocjm7ihg5oi7uiuv@slider>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider>
Date: Tue, 14 Dec 2021 17:36:00 +0100
Message-ID: <87wnk7rvnz.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Dec 14 2021 at 10:22, Nishanth Menon wrote:
> On 10:41-20211214, Thomas Gleixner wrote:
> Agreed that the warning is fine, the null pointer exception that follows
> [1] [2] it however does'nt look right and it can be trivially fixed with the
> following fixup for ee90787487bc ("genirq/msi: Provide
> msi_device_populate/destroy_sysfs()") below, with that the log looks
> like [3] - the warn is good, the null pointer exception and resultant
> crash could be avoided (not saying this is the best solution):

Aaargh.

[   13.478122] Call trace:
[   13.509042]  msi_device_destroy_sysfs+0x18/0x88
[   13.509058]  msi_domain_free_irqs+0x34/0x58
[   13.509064]  pci_msi_teardown_msi_irqs+0x30/0x3c
[   13.509072]  free_msi_irqs+0x78/0xd4
[   13.509077]  pci_disable_msix+0x138/0x164
[   13.529930]  pcim_release+0x70/0x238
[   13.529942]  devres_release_all+0x9c/0xfc
[   13.529951]  device_release_driver_internal+0x1a0/0x244
[   13.542725]  device_release_driver+0x18/0x24
[   13.542741]  iwl_req_fw_callback+0x1a28/0x1ddc [iwlwifi]
[   13.552308]  request_firmware_work_func+0x50/0x9c
[   13.552320]  process_one_work+0x194/0x25c

That's not a driver problem, that's an ordering issue vs. the devres
muck. Let me go back to the drawing board. Sigh...

Thanks,

        tglx



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:45:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:45:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246903.425818 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAvS-0006uK-3A; Tue, 14 Dec 2021 16:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246903.425818; Tue, 14 Dec 2021 16:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxAvS-0006uD-03; Tue, 14 Dec 2021 16:45:14 +0000
Received: by outflank-mailman (input) for mailman id 246903;
 Tue, 14 Dec 2021 16:45:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=pVj/=Q7=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxAvR-0006u7-Ia
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:45:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 34733439-5cfd-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 17:45:12 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-AJLBPiHANomlkwT3xjOwIw-1; Tue, 14 Dec 2021 17:45:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Tue, 14 Dec
 2021 16:45:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021
 16:45:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34733439-5cfd-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639500311;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qMZVw8TI2E2IED6ByzTbPC6NglxWEODXw8SstT5zBac=;
	b=LSNO1vih59TO+ZAEToajVixoFKXledL17AdEk3Ume3eG/iaxtqH0XxVM720P/xDEJOJ8Co
	HY9Ueg4Xkki59zObTgFL6CV6ZyQatfgkOv3lV+MgRNHVSHdYfaHpJgo+O5n5J64Mzwcujo
	WNIglTgVoZkJ9zrWsSZEvoq7ZEzv4a0=
X-MC-Unique: AJLBPiHANomlkwT3xjOwIw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MsvZDWWWbsAV+V8cpLoGR2jEtVYtYkdHBH+4AFSNva2oN5mfa7rg+44dKJjK97sactuUAKjHn+jegSAryzzFXplIVK7LaENdrNEm24CQ+3frhYz+L5tcTmwbjEFR8NC3EgARMvVFMF0Zg/3ZZgtrK/HXfKntSDjsUhe7SKSOQJ7M+XiYBZvq/wLk5G0sqaDEjL2fjYPyvtdVhlx5C8+fS52IvOC9dKvp6/Pi/0Fq35jjOhmRGf2qhCRSlh1q5M9oScEajc/X87p2youfEqj/Ggn4O5bpUH83K10SOUNt4NbEEoCwY6jKLPrLL5fTXs2o8y6AFj6SK4WZa7KrwWznVw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qMZVw8TI2E2IED6ByzTbPC6NglxWEODXw8SstT5zBac=;
 b=OXCRq2zZz3ZceTNtbPDY/CulO6c6+siIyykjyxOvU6S2BD/9vqbZjBmU7Q7VXZEgKl4d4zZfcxTwJ5Myo05R+r+08RkQOBiNX5ueo9eaIfGLSs4LEmKzRwlO2SbdLgh87jWkqSkWCWvMifqC87N7iifo+PS2E8vPBD7kPyb0BPomAbBrNOkHmFMDK0bHUFqRYhmRlzb+VlYjSuN1cRcwxdqb3VaPieOTPdebswXO2yEH8ALbqZMQTA/CzEM8XS59+Dj4pfgWnT5GNRCl2edrD5QhXtxRdzJ+mhYza6PzrSw2ul8YMU3+9i4/rzdfb3zwYnnHbDHvbToc9bYiYBfy+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
Date: Tue, 14 Dec 2021 17:45:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0036.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aabdfd40-b82f-4b3b-6445-08d9bf211681
X-MS-TrafficTypeDiagnostic: VI1PR04MB5742:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57428DB90F310EE95926C295B3759@VI1PR04MB5742.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dRhmYyg8uo/lSxFN77S32K+kSzV0NM0K0wquq6HSMQ6ETlBNhsnx3w1v1B2dWKV5O1j6/2s28ujsTA7G1zo2jg/kuCHjxvq5HloOriodSw+4DDF5qj/SDo2XV7TNfKwpMxGwD9YU22YxKPT12mhAT0RUd+AmE7mCISydJcIkhZpQcsOf9U9h1xDKkQHjBXIb0ztmU+KjTamSAGrQ9FGSL3X+Ror7BfST72ZjEHfpEv8uw5MPShJoOvRnw82za7wZWrJaZbe0YP8HM9A8vcRDoHrhoAosJeVTrEVyMbg0ab1t4UrmdSelL2RcmanFgavrDxKOwStPlq32R5TmCgSZ5xbSJgBias7bS6sAS1iHdJ2kc53U7f0F6W3SNGQlAgWIdcex7CxC76QoTv04pXA0iXrZ+llLLTlVi5cbmRtZIVn6WmPmd7Ke3oCfQ1lqMLxCCA62i97iQdIWdV19fjU3SF9/NGDghTb0jAo4Tt5QwGWhYByQt7wyhYZFExr27r8Ah5BQHNN1ymRSIZn2riVXUVewDreRw0yljX8NGSqfRf85GYAKq8mmwz3BdnunlLw9nB+2C9ZAfyx2+zgIVngmSdrkWHIJXa5noHaLcICxrIusHm7FwKxofZg3Hgr4LE4tA6cTddRMuSYUcXxGp4bc0OMYZjtWUd8FOZ9Zvsflzoajonj1A5sWwERBsLkkGkgs/Wc4MdlbfKL++sfjyeSDi8u6F1uGVnMf9P+TtP8P5Tg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(66946007)(2906002)(4326008)(31686004)(508600001)(66476007)(186003)(66556008)(7416002)(26005)(38100700002)(54906003)(316002)(6916009)(8676002)(53546011)(5660300002)(8936002)(6486002)(36756003)(6512007)(86362001)(6506007)(83380400001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VGZtdDhTbkNFSEpYbkoxM0txbmVuazFxbU16Mk1IOUVkdEVmKzdoRWxlQkdS?=
 =?utf-8?B?cGgzMVNGK0FFZzU0RW5QRnJyaVM5ckxsbEw0SkFpOWU5OWgxbUVvQmNuVGhl?=
 =?utf-8?B?VEFIRmVQS2JyOVUzVWVzanZkRnd0eWM0NnJvYiswL3V2RDQySHQvOEtiaWQv?=
 =?utf-8?B?T3VqTENtNVlodEZnYVByV2lieE1uVXMxaWNYUXJNdmhwVnorNGwwdXRpakRu?=
 =?utf-8?B?d0lxdUFOODNwOFhMdFNqd3dIZG84MDFLY3VmVWt6L1hRemtlMzl0V2I0RFh3?=
 =?utf-8?B?emFxQUhzYW13Wkx6RVMyUlNqWU5nSHFGT3ZrUEJxbExPVHNMcFBCSGExaFl4?=
 =?utf-8?B?L1BsVXBMTnVZZkw0eStmeTZMb2VvcVJjMnhtUHd6V3hXSUF5WkYwTXB0OWxQ?=
 =?utf-8?B?YUI3c0FxSHRseHRyRDBEQlRxWGZER0U5M1k3RjVsRGpRQjErWllLQkpBOHVO?=
 =?utf-8?B?Wkd0VCttaTZUMkVsMnNoaEZ0QUM0TmxxYktPMUR1RUVrL3BuMFVTYXNJelBx?=
 =?utf-8?B?bVptZFl1UlA1TVVKNzVzNXdJemlZWEhpRzRrV2tpcWViRkZFa3hPZnRobGxo?=
 =?utf-8?B?UXoyUjVXU0h0aG9Ua3l2U3k3VDYvb0JkSDJDMkU1RWZUSnpEcDRTMFdCSzh4?=
 =?utf-8?B?b0FqVTg3bEdsNXhQb3FTSk43cktDanhqcldBeStKa3hqSEtnaldWVmM2dEhT?=
 =?utf-8?B?Ylh3am9wTDk5Q2ZlT0VIMlZoMU80bmlYdWhMZ014N0gwZEpPSk5FRHhZSWRW?=
 =?utf-8?B?ek5qdHJCSWYzL0tCb1dBZmFmRHVZOUhWS2UvUERjWmtqaVpDTmtxSUgwWlhh?=
 =?utf-8?B?UStjOUNEdmFKUGk3N0JaZ2NaN1FJUVljV2hpN2cxb1NscWVuOUpyOVJ4VVRj?=
 =?utf-8?B?YW1vdFVUN1p0ckhNb3lnY3lqOHV4TUdzVzJVZGsyMzFQdjdVUEs5VkluTzRv?=
 =?utf-8?B?Wi9qL25INHIrU2M4TG52VkZkQkJmbGk2djRySzZiU08rSFg1aXR5c09Rdmdl?=
 =?utf-8?B?WUE2SjJzNmw1N1FBQXZMVERlUUx6RzFJaGJyUnVhMktQTEJieElTcHhlR3VR?=
 =?utf-8?B?bndGSkcwWU5xQ0NaeXBtMW80Y1JSM0ZVdEdDTkp3ZW00U1IyZU1mRFllaUNx?=
 =?utf-8?B?ZllWWEt1dndJK3IyajhLdkw2Z3p3WjBKQUkrUTR2ejR6cjRya1VYMmZCNjVK?=
 =?utf-8?B?VVZ4VnN3dUpVVGE2dmRsaDBKL0Q5RCsrVUJNWUlSTnlrNERjZlF0ZWUySGFo?=
 =?utf-8?B?czVwZ21mU1lZSVRPTFk4bENYdFZ4c2U5WWRNend1S2RJdlVMb3dCRzhWQ3V0?=
 =?utf-8?B?d1lDN3FlWmNtY2R5NlBzS2JLUVBlRk9jdzRqZThWcXk1ZjVtSE84a0o1anhU?=
 =?utf-8?B?L0wwRy9ZVHJCMjROTzBiUG1NL29XWFM4UDFkYjV6QjZqb0dQL0NaSmI0aHV4?=
 =?utf-8?B?aVpUZy9rTVV5Tm9VWHVINU1zWVhPVmczSmFUTFR6TExCT3JDQW1TaUVlMHho?=
 =?utf-8?B?Nk44b0w4OXAzWjhibUV6TUd2dzJFVDJFalA5R3dMN0x6bFhQZmVBRzZESzZa?=
 =?utf-8?B?S25qbnUwZmFLNTdvY0J5SWg2Rk1BblBZMXBkazljYzduK1g5Y2xTc0pGcHRQ?=
 =?utf-8?B?aTFsNldhN1VadktlZ1pyVHBMeXBOTnBIRXM3eWpwY2hzdm5LcEovaFdJNjJx?=
 =?utf-8?B?Njk2bmtpOU9tZW0wVEdsc1NMN1c0L0JWaktzaUQxTlBiTitJOU9rQ1VHdWRo?=
 =?utf-8?B?K2VFM1B4T1RoUnB6UVlIQVJ1WkUyMnphNFRsd3F0aVRKYjRvZ1gyaml6bS9t?=
 =?utf-8?B?a3J1eERjSnF3TEhCTHJaRHlRZms5RGRuNkFhRU13SXF0WUtKakRlT3FuNk1S?=
 =?utf-8?B?TDV5T3NLWnYvRHlKL2hmMXlBVzVjRWw3eEoydFZ1S0VjeHd4YjZNZnhUTnZQ?=
 =?utf-8?B?MzVTVmQ2UktJdGJubnNUTGxMRFhKdWh1K3RWMUFxclBsbkFBa1VxRkt4VW9V?=
 =?utf-8?B?allLMXlmR0VxaGFaYW1lOStNWjV1Y3lJK1ozdkRkWDNRSE5zN3NuUkRLbWtw?=
 =?utf-8?B?NWRrV2FjYmNoMVZSd01uaWFhMCtnY2FjSXVEWVljYzIvb296eFRFQnlLa3hI?=
 =?utf-8?B?STRFMTJ2R0c0Qkx4c1VtdU50MWFUNTFMQzdmM1FtcFJ4M20zdmpGaWt5blV6?=
 =?utf-8?Q?aW7QIGA8z5oGIDKGThzH/u8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aabdfd40-b82f-4b3b-6445-08d9bf211681
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 16:45:08.3539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wGyQC/ChAtNUW97qRU+G0GYeUHPRNshv0uoYeZh/Sxqdt3Sdk0ALJEoJAQcv32JNwHxiPX9LNSdZGFzyMxeIlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742

On 14.12.2021 17:26, Oleksandr wrote:
> On 14.12.21 15:37, Jan Beulich wrote:
>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>>   
>>>   void free_xenheap_pages(void *v, unsigned int order)
>>>   {
>>> +    struct page_info *pg;
>>> +    unsigned int i;
>>> +
>>>       ASSERT(!in_irq());
>>>   
>>>       if ( v == NULL )
>>>           return;
>>>   
>>> +    pg = virt_to_page(v);
>>> +
>>>       memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>> ... this really want to (logically) move into the new arch hooks.
>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>> notice there's some dead code there on x86, which I guess I'll make
>> a patch to clean up). But first of all this suggests that you want
>> to call the hooks with base page and order, putting the loops there.
> 
> I see your point and agree ... However I see the on-list patches that 
> remove common memguard_* invocations and x86 bits.
> So I assume, this request is not actual anymore, or I still need to pass 
> an order to new arch hooks? Please clarify.

Well, that patch (really just the Arm one) effectively takes care of
part of what I did say above. Irrespective I continue to think that
the hook should take a (page,order) tuple instead of getting invoked
once for every order-0 page. And the hook invocations should be placed
such that they could fulfill the (being removed) memguard function
(iirc that was already the case, at least mostly).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:51:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:51:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246911.425829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB1H-0008TD-Op; Tue, 14 Dec 2021 16:51:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246911.425829; Tue, 14 Dec 2021 16:51:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB1H-0008T6-Lo; Tue, 14 Dec 2021 16:51:15 +0000
Received: by outflank-mailman (input) for mailman id 246911;
 Tue, 14 Dec 2021 16:51:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KYVb=Q7=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxB1G-0008T0-U1
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:51:15 +0000
Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com
 [2a00:1450:4864:20::22d])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 084e911a-5cfe-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 17:51:07 +0100 (CET)
Received: by mail-lj1-x22d.google.com with SMTP id i63so29251764lji.3
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 08:51:13 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id s15sm40278lfb.216.2021.12.14.08.51.12
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Dec 2021 08:51:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 084e911a-5cfe-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=OiNxOwpxiOMNu2w7h9qWcHz9qxeoJCMQlCzPYcP/iUc=;
        b=Ubkj2k/iuYEKMqZEbka2uXDBKzgqLXzvUhlKYdO0BjUeFmJbjgmYNtPW2bpXIQsaIP
         RuRvoJNSVaRRBKJjaMd2TqyKvVlnVC8jj3oU7akcr7lS1O2nFeEZD2fXW1CpRK9fTZQF
         8pNMNYYk2WPsMyL5um2ywPm4gj0gKMvtxQBUq1wrSPy49NrU+ZI2K7B+FrXfFjUGHVn8
         pU6lxnGc1jY8tT1hEDAKlhNjbQBgaghV8TzZZBOHACA2WxQKyj8QgGi/N0cnIA9/u5zn
         SBpk8po6hypk4Z/MEQMVcSSctLQIUpOyDgwpYPLvUKR3D6ZQzNzjA9dzA1+epNIkXJqo
         ws+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=OiNxOwpxiOMNu2w7h9qWcHz9qxeoJCMQlCzPYcP/iUc=;
        b=i1YLvclZkRqVoo0+5g/9OVMLA3rzWZH+mgsSL9z6zIoYdPag3nl5eYEC/apae959bQ
         zm7Pb0WlH1FI2phyUVBPYSUcfMazE95nYAAYb7VsSAKf456UoaY/iNvm9HsGv0xZr162
         cq/2zHICOF0Unk5P5PRFUcyQQ1TazW1Av7lZLdF23SgPsYXhBKlIHD5jqi8/mIJk7+f5
         O7bfNPU4hH1uMjr7I3wlnnAuiOCWmCMIHLHD7cA/FtmpXybPlR1QDby3DAa8C7dPxnVN
         yQvBc/i1Z0JK0FMadgdmyuwHPjrM4GdehPlwW5U5/TgnqqXMoLBTSKgrUPFqY2F0KNYq
         CR3w==
X-Gm-Message-State: AOAM532aWWBvmLr6ck2KFx4qDyqGPcRFf54px8QvElGdUCxlg2I0HBXi
	al4O2n5+o5RFDlS3DssNChM=
X-Google-Smtp-Source: ABdhPJwEAQ/1c+e41U+3CAiWRvKmRPG91vpYWU+BgmGyUW5ullZ0xLel8WvJkw/R2hCZUVeYOsyQDg==
X-Received: by 2002:a2e:a594:: with SMTP id m20mr5640187ljp.332.1639500673341;
        Tue, 14 Dec 2021 08:51:13 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <12f4e7fb-2908-99ae-eaf7-22861aa37484@gmail.com>
Date: Tue, 14 Dec 2021 18:51:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 18:45, Jan Beulich wrote:

Hi Jan.

> On 14.12.2021 17:26, Oleksandr wrote:
>> On 14.12.21 15:37, Jan Beulich wrote:
>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>>>    
>>>>    void free_xenheap_pages(void *v, unsigned int order)
>>>>    {
>>>> +    struct page_info *pg;
>>>> +    unsigned int i;
>>>> +
>>>>        ASSERT(!in_irq());
>>>>    
>>>>        if ( v == NULL )
>>>>            return;
>>>>    
>>>> +    pg = virt_to_page(v);
>>>> +
>>>>        memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>> ... this really want to (logically) move into the new arch hooks.
>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>> notice there's some dead code there on x86, which I guess I'll make
>>> a patch to clean up). But first of all this suggests that you want
>>> to call the hooks with base page and order, putting the loops there.
>> I see your point and agree ... However I see the on-list patches that
>> remove common memguard_* invocations and x86 bits.
>> So I assume, this request is not actual anymore, or I still need to pass
>> an order to new arch hooks? Please clarify.
> Well, that patch (really just the Arm one) effectively takes care of
> part of what I did say above. Irrespective I continue to think that
> the hook should take a (page,order) tuple instead of getting invoked
> once for every order-0 page. And the hook invocations should be placed
> such that they could fulfill the (being removed) memguard function
> (iirc that was already the case, at least mostly).

ok, thank you for the clarification, will do.


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 16:54:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 16:54:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246916.425839 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB4N-0000gS-7V; Tue, 14 Dec 2021 16:54:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246916.425839; Tue, 14 Dec 2021 16:54:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB4N-0000gL-4b; Tue, 14 Dec 2021 16:54:27 +0000
Received: by outflank-mailman (input) for mailman id 246916;
 Tue, 14 Dec 2021 16:54:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxB4L-0000gC-Jg
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:54:25 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxB4K-0004KH-Io; Tue, 14 Dec 2021 16:54:24 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxB4K-0002AD-CF; Tue, 14 Dec 2021 16:54:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=upQLjFNoZXCyppKCSlH6HchYl35o/wg3rq4iXzg9dGY=; b=fjqb3aOaUdtKGk2UZeqB7xO7HX
	+MqnHW9YVa3k2Mt7Z+HnwAipNkN9tebH25yb8ql7Yqk1qNYk3El4LJmMaFmpYD4utG4y/lt6gzHci
	Zffcg7icA37P9LDedZ9eGIiX7p7I5Zx3qI3pjEtq2iwl9PyBrHRCa2SH/Ecc1OUu7U7g=;
Message-ID: <f9a5844a-6e70-cb10-a5b8-4bdf55751f5f@xen.org>
Date: Tue, 14 Dec 2021 16:54:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 01/47] build: factorise generation of the linker
 scripts
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-2-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-2-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> In Arm and X86 makefile, generating the linker script is the same, so
> we can simply have both call the same macro.
> 
> We need to add *.lds files into extra-y so that Rules.mk can find the
> .*.cmd dependency file and load it.
> 
> Change made to the command line:
> - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags).
> - Added -D__LINKER__ even it is only used by Arm's lds.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> ---
> 
> Notes:
>      v6:
>      - CPP already used instead of CC -E
>      - -Ui386 already removed
>      - cpp_flags is now a macro
>      - rebased
>      
>      v5:
>      - rename cc_lds_S to cpp_lds_S as the binary runned is now CPP
>      - Use new cpp_flags instead of the open-coded filter of a_flags.
>      
>      v4:
>      - fix rebuild by adding FORCE as dependency
>      - Use $(CPP)
>      - remove -Ui386
>      - avoid using "define" for cmd_cc_lds_S, as adding '; \' on each line is
>        still mandatory for if_changed (or cmd) macro to work.
> 
>   xen/Rules.mk          | 4 ++++
>   xen/arch/arm/Makefile | 6 ++++--
>   xen/arch/x86/Makefile | 6 ++++--
>   3 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 5e0699e58b2b..d21930a7bf71 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -238,6 +238,10 @@ cmd_cpp_s_S = $(CPP) $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $<
>   %.s: %.S FORCE
>   	$(call if_changed,cpp_s_S)
>   
> +# Linker scripts, .lds.S -> .lds
> +quiet_cmd_cpp_lds_S = LDS     $@
> +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $<
> +
>   # Add intermediate targets:
>   # When building objects with specific suffix patterns, add intermediate
>   # targets that the final targets are derived from.
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 07f634508eee..a3a497bafe89 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -67,6 +67,8 @@ obj-y += vsmc.o
>   obj-y += vpsci.o
>   obj-y += vuart.o
>   
> +extra-y += xen.lds
> +
>   #obj-bin-y += ....o
>   
>   ifneq ($(CONFIG_DTB_FILE),"")
> @@ -132,8 +134,8 @@ $(TARGET)-syms: prelink.o xen.lds
>   .PHONY: include
>   include:
>   
> -xen.lds: xen.lds.S
> -	$(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $<
> +xen.lds: xen.lds.S FORCE

Sorry, I haven't really followed the build system rework. Could you 
explain why it is necessary to add FORCE?

> +	$(call if_changed,cpp_lds_S)
>   
>   dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE))
>   
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index 69b6cfaded25..669e16e72690 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -78,6 +78,7 @@ obj-y += sysctl.o
>   endif
>   
>   extra-y += asm-macros.i
> +extra-y += xen.lds
>   
>   ifneq ($(CONFIG_HVM),y)
>   x86_emulate.o: CFLAGS-y += -Wno-unused-label
> @@ -238,6 +239,7 @@ endif
>   note_file_option ?= $(note_file)
>   
>   ifeq ($(XEN_BUILD_PE),y)
> +extra-y += efi.lds
>   $(TARGET).efi: prelink.o $(note_file) efi.lds efi/relocs-dummy.o efi/mkreloc
>   ifeq ($(CONFIG_DEBUG_INFO),y)
>   	$(if $(filter --strip-debug,$(EFI_LDFLAGS)),echo,:) "Will strip debug info from $(@F)"
> @@ -290,8 +292,8 @@ $(BASEDIR)/include/asm-x86/asm-macros.h: asm-macros.i Makefile
>   	$(call move-if-changed,$@.new,$@)
>   
>   efi.lds: AFLAGS-y += -DEFI
> -xen.lds efi.lds: xen.lds.S
> -	$(CPP) -P $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $<
> +xen.lds efi.lds: xen.lds.S FORCE
> +	$(call if_changed,cpp_lds_S)
>   
>   boot/mkelf32: boot/mkelf32.c
>   	$(HOSTCC) $(HOSTCFLAGS) -o $@ $<

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:00:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:00:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246921.425851 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB9b-0001YV-1B; Tue, 14 Dec 2021 16:59:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246921.425851; Tue, 14 Dec 2021 16:59:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxB9a-0001YO-UV; Tue, 14 Dec 2021 16:59:50 +0000
Received: by outflank-mailman (input) for mailman id 246921;
 Tue, 14 Dec 2021 16:59:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxB9Z-0001YI-LI
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 16:59:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxB9W-0004QF-7S; Tue, 14 Dec 2021 16:59:46 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxB9V-0003yy-Vv; Tue, 14 Dec 2021 16:59:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cl2qNmg6npQtF8aRqXB+zmRxOSPTK7igbUJLpSCkCLw=; b=HrOGGQMWbAmHX2JpjeDG0RIMiq
	9YC17B4Ot8m3Y34LAJEhdRzttNVRhdpCwuv1/WbiCdL+8c1LHXyNVgupG3bGRE9QPxEijv7I961wa
	5qTo2d+dQecokCSFSCv43KYvHLCl5cE76Lv21RPThm74QVdVCxoZX+5PoAwH6ihgxFCE=;
Message-ID: <ac4b071c-3177-e23d-b656-fd9988ccab89@xen.org>
Date: Tue, 14 Dec 2021 16:59:41 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 02/47] xen: move include/asm-* to
 arch/*/include/asm
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-3-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-3-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 25/11/2021 13:39, Anthony PERARD wrote:
> This avoid the need to create the symbolic link "include/asm".
> 
> Whenever a comment refer to an "asm" headers, this patch avoid
> spelling the arch when not needed to avoid some code churn.
> 
> One unrelated change is to sort entries in MAINTAINERS for "INTEL(R)
> VT FOR X86 (VT-X)"
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Paul Durrant <paul@xen.org>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:01:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246925.425862 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBB6-0002su-Bq; Tue, 14 Dec 2021 17:01:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246925.425862; Tue, 14 Dec 2021 17:01:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBB6-0002sn-8r; Tue, 14 Dec 2021 17:01:24 +0000
Received: by outflank-mailman (input) for mailman id 246925;
 Tue, 14 Dec 2021 17:01:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBB5-0002sf-RX
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:01:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBB5-0004Ug-FG; Tue, 14 Dec 2021 17:01:23 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBB5-0004GO-9X; Tue, 14 Dec 2021 17:01:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=pQZjbl+7YWLkiQ12TSpI2RPDywROfLWXRYGcilQ12vU=; b=y5JBEqVcwJkUu9s6udrFjXKLYA
	V+d8W5Hc6rBgxxSfLbC/Tpdvj8Nxp02F7hAjbM2ENvpCuquAqUpCeOgkJ4iZZytDu927JSvt26Dyw
	NEZhEn3fXXWDTU64v3DrpC3ZQa9EvCfh9gTENjvjNj7vcbf7vZvemg/puvDHQr97/Hlo=;
Message-ID: <63996801-d069-c648-928d-fe951c35b720@xen.org>
Date: Tue, 14 Dec 2021 17:01:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 05/47] build: adjust $(TARGET).efi creation in
 arch/arm
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-6-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-6-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> There is no need to try to guess a relative path to the "xen.efi" file,
> we can simply use $@. Also, there's no need to use `notdir`, make
> already do that work via $(@F).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:02:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:02:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246930.425873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBCH-0003VR-MV; Tue, 14 Dec 2021 17:02:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246930.425873; Tue, 14 Dec 2021 17:02:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBCH-0003VK-JG; Tue, 14 Dec 2021 17:02:37 +0000
Received: by outflank-mailman (input) for mailman id 246930;
 Tue, 14 Dec 2021 17:02:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBCG-0003VA-G6
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:02:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBCD-0004Wl-T0; Tue, 14 Dec 2021 17:02:33 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBCD-0004Kn-Nf; Tue, 14 Dec 2021 17:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=yMVbd1odnAEVw/2SZF//3pcjOGZ9OCHBWl6xLcEeUh8=; b=b7DaHShhks/4HGgkI3e4b7/hzu
	J7NnKNPMSDdVXbfCYOkwhkbKlND+fiBjrOICd2kOH0MdHtTQSbcrNmCk9KWOz/0LSnI3jpNhEva3U
	gK+gPuOhZoVmIJNnP2w1ebEzn2B4GRI5SY5e0VkGP2Ai30vMj7t9ZZVY9fWoxcFsURIU=;
Message-ID: <b9226076-a5e9-b664-8947-eb1d94c8a2ca@xen.org>
Date: Tue, 14 Dec 2021 17:02:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 08/47] build: prepare to always invoke $(MAKE) from
 xen/, use $(obj)
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-9-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-9-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> In a future patch, when building a subdirectory, we will set
> "obj=$subdir" rather than change directory.
> 
> Before that, we add "$(obj)" and "$(src)" in as many places as
> possible where we will need to know which subdirectory is been built.
> "$(obj)" is for files been generated during the build, and "$(src)" is
> for files present in the source tree.
> 
> For now, we set both to "." in Rules.mk and Makefile.clean.
> 
> A few places don't tolerate the addition of "./", this is because make
> remove the leading "./" in targets and dependencies in rules, so these
> will be change later.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>

For Arm:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:04:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:04:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246936.425895 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBDf-0004Oa-9w; Tue, 14 Dec 2021 17:04:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246936.425895; Tue, 14 Dec 2021 17:04:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBDf-0004OT-6s; Tue, 14 Dec 2021 17:04:03 +0000
Received: by outflank-mailman (input) for mailman id 246936;
 Tue, 14 Dec 2021 17:04:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBDe-0004O3-7S
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:04:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBDc-0004Yp-0r; Tue, 14 Dec 2021 17:04:00 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBDb-0004RZ-RG; Tue, 14 Dec 2021 17:03:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=cs377JxwHdAJu/wXuE4+voLmIwWBaQNxiEvBgwGbng4=; b=BzfEhWjETVX+ttE2LQE1dM9Ayi
	VAA7/pnYBLU0t4smq/c+CbNUbdwn4QWwIlqh7KHMijr/dktTbdKqhgqhwMOODWlXVabFJ9GPdw1mX
	nJmlGWzNn0Ss36E+V1eALyYw43NneaGhYqjEBv7gf4bas+5/ikW0RqsWXUPYpHtiuhhs=;
Message-ID: <b2724f38-6dcb-e7c6-40ce-783de9941e16@xen.org>
Date: Tue, 14 Dec 2021 17:03:56 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-13-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthonny,

On 25/11/2021 13:39, Anthony PERARD wrote:
> A subdirectory is now built by setting "$(obj)" instead of changing
> directory. "$(obj)" should always be set when using "Rules.mk" and
> thus a shortcut "$(build)" is introduced and should be used.
> 
> A new variable "$(need-builtin)" is introduce. It is to be used
> whenever a "built_in.o" is wanted from a subdirectory. "built_in.o"
> isn't the main target anymore, and thus only needs to depends on the
> objects that should be part of "built_in.o".
> 
> Introduce $(srctree) and $(objtree) to replace $(BASEDIR) in cases a
> relative path is better, and $(abs_srctree) and $(abs_objtree) which
> have an absolute path.
> 
> DEPS is updated as the existing macro to deal with it doesn't know
> about $(obj).
> 
> There's some changes in "Rules.mk" which in addition to deal with
> "$(obj)" also make it's looks more like "Makefile.build" from Linux
> v5.12.
> 
> test/Makefile doesn't need special handling in order to build
> everything under test/, Rules.mk will visit test/livepatch via
> $(subdir-y), thus "tests" "all" and "build" target are removed.
> "subtree-force-update" target isn't useful so it is removed as well.
> 
> test/livepatch/Makefile doesn't need default target anymore, Rules.mk
> will build everything in $(extra-y) and thus all *.livepatch.
> 
> Adjust cloc recipe: dependency files generated by CC will now have the
> full path to the source file, so we don't need to prepend the
> subdirectory. This fix some issue with source not been parsed by cloc
> before. Also source from tools/kconfig would be listed with changes in
> this patch so adjust the find command to stop listing the "tools"
> directory and thus kconfig. With a default build of Xen on X86, they
> are a few new files parsed by cloc:
>      arch/x86/x86_64/compat/mm.c
>      arch/x86/x86_64/mm.c
>      common/compat/domain.c
>      common/compat/memory.c
>      common/compat/xlat.c
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Bob Eshleman <bobbyeshleman@gmail.com>

For Arm:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:04:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:04:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246935.425883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBDa-000472-1v; Tue, 14 Dec 2021 17:03:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246935.425883; Tue, 14 Dec 2021 17:03:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBDZ-00046v-VJ; Tue, 14 Dec 2021 17:03:57 +0000
Received: by outflank-mailman (input) for mailman id 246935;
 Tue, 14 Dec 2021 17:03:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iTjg=Q7=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxBDY-00046n-Pl
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:03:56 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cc0ebb62-5cff-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 18:03:48 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cc0ebb62-5cff-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639501430;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RXDy+gEt+jM/GLA+wNxlJEuBnWYy8r3p2Ru1kkxGm4Q=;
	b=4P9YNy0ES7591XCDm5PSWup8bN4QZP7lauZPNqzguglGF810Qx6tlHC+ni+cCTXT//bRrL
	8sy8xtbBW2WNueS1zjqp8h8A0yb4naQSxUV7RBh2hqT1tsFq6begUYU0evqtkPzN01b278
	fd9gHbaeywBmVDCmDPd2qQ/zpjMiaB9wQAqsRoE0OI6pkTd0Mdkr8wct9zyvWczqltcPfP
	gVFurKQstARHhwA4cqkMjQuwW0a240akK7UOWCq2KqJXtL/Zk07hDvbDB6Geb3dHg82+ku
	rQEa7JysFMGTutJcrfi+Bj+sn5C4cesBd4+iCf7oAFV+qmPbWW589QvaRwSxBw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639501430;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=RXDy+gEt+jM/GLA+wNxlJEuBnWYy8r3p2Ru1kkxGm4Q=;
	b=NEaZQwUVupGSoHFBC83jQ5nykyNdZrjtpZRBFsQka5WyTgqzd9VoqFy4Lrz/ewIMzZW0fK
	mYumgixv6qanTNBQ==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <87wnk7rvnz.ffs@tglx>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
Date: Tue, 14 Dec 2021 18:03:50 +0100
Message-ID: <87tufbrudl.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Dec 14 2021 at 17:36, Thomas Gleixner wrote:
> On Tue, Dec 14 2021 at 10:22, Nishanth Menon wrote:
>> On 10:41-20211214, Thomas Gleixner wrote:
> [   13.478122] Call trace:
> [   13.509042]  msi_device_destroy_sysfs+0x18/0x88
> [   13.509058]  msi_domain_free_irqs+0x34/0x58
> [   13.509064]  pci_msi_teardown_msi_irqs+0x30/0x3c
> [   13.509072]  free_msi_irqs+0x78/0xd4
> [   13.509077]  pci_disable_msix+0x138/0x164
> [   13.529930]  pcim_release+0x70/0x238
> [   13.529942]  devres_release_all+0x9c/0xfc
> [   13.529951]  device_release_driver_internal+0x1a0/0x244
> [   13.542725]  device_release_driver+0x18/0x24
> [   13.542741]  iwl_req_fw_callback+0x1a28/0x1ddc [iwlwifi]
> [   13.552308]  request_firmware_work_func+0x50/0x9c
> [   13.552320]  process_one_work+0x194/0x25c
>
> That's not a driver problem, that's an ordering issue vs. the devres
> muck. Let me go back to the drawing board. Sigh...

Which is pretty obvious why:

   pcim_enable_device()
        devres_alloc(pcim_release...);
        ...
        pci_irq_alloc()
          msi_setup_device_data()
             devres_alloc(msi_device_data_release, ...)

and once the device is released:

    msi_device_data_release()
    ...
    pcim_release()
       pci_disable_msi[x]()

Groan....


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:06:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:06:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246946.425906 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBFQ-0005Hu-MJ; Tue, 14 Dec 2021 17:05:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246946.425906; Tue, 14 Dec 2021 17:05:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBFQ-0005Hn-JR; Tue, 14 Dec 2021 17:05:52 +0000
Received: by outflank-mailman (input) for mailman id 246946;
 Tue, 14 Dec 2021 17:05:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBFO-0005HZ-Ko
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:05:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBFN-0004bo-Cd; Tue, 14 Dec 2021 17:05:49 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBFN-0004ZE-5z; Tue, 14 Dec 2021 17:05:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+lIwA4ZRTVSYc1f5arQHlKa8htLLoqiCznblSSNKg6Y=; b=ndlW8Xqi0trp/BGMJWe+aNZOPh
	JhJs7FWe6jKCBuiPkmVMiCKCdiEO5x2fjK3OovqeTN7OiteNCtnqYF6JeOb/j0XVwFbgGBiz7tWO7
	GZBCrq/zk1lNuichKUt7d23yB8e3QppAAZupcPXhqoObH2pOkT5sALHDgwMsLFX7jTlg=;
Message-ID: <bcca6950-666f-63ea-9ea2-49f70d8a252a@xen.org>
Date: Tue, 14 Dec 2021 17:05:46 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-15-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-15-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> For two reasons: this macro is used to generate a "linker script" and
> is not by the linker, and name starting with an underscore '_' are
> supposed to be reserved, so better avoid them when not needed.

If that's the case, then shouldn't we also rename __ASSEMBLY__?

> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
>   xen/Rules.mk                      | 2 +-
>   xen/arch/arm/include/asm/config.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 4624739ca7e2..d32fec0ae037 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -256,7 +256,7 @@ $(obj)/%.s: $(src)/%.S FORCE
>   
>   # Linker scripts, .lds.S -> .lds
>   quiet_cmd_cpp_lds_S = LDS     $@
> -cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $<
> +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -DLINKER_SCRIPT -MQ $@ -o $@ $<
>   
>   targets := $(filter-out $(PHONY), $(targets))
>   
> diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h
> index c7b77912013e..2aced0bc3b8b 100644
> --- a/xen/arch/arm/include/asm/config.h
> +++ b/xen/arch/arm/include/asm/config.h
> @@ -191,7 +191,7 @@ extern unsigned long frametable_virt_end;
>   #define watchdog_disable() ((void)0)
>   #define watchdog_enable()  ((void)0)
>   
> -#if defined(__ASSEMBLY__) && !defined(__LINKER__)
> +#if defined(__ASSEMBLY__) && !defined(LINKER_SCRIPT)
>   #include <asm/asm_defns.h>
>   #include <asm/macros.h>
>   #endif

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:06:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:06:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246950.425916 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBGK-0005rG-Vz; Tue, 14 Dec 2021 17:06:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246950.425916; Tue, 14 Dec 2021 17:06:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBGK-0005r9-T5; Tue, 14 Dec 2021 17:06:48 +0000
Received: by outflank-mailman (input) for mailman id 246950;
 Tue, 14 Dec 2021 17:06:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBGJ-0005r0-Pi
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:06:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBGI-0004co-PE; Tue, 14 Dec 2021 17:06:46 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBGI-0004dS-J3; Tue, 14 Dec 2021 17:06:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=3O7SKgxbikZjYBZgc3TdUmLQIqhTETNz8bS/8BF5bCQ=; b=LXc81H3OgV/LOzJddtEMbZn4mT
	V11AoxX+CZeZquBL/kWgmbz/42FSr7p0F7Xm+SB1D9nmTBzH7lnAjAQB6SB03w4PLPC5K5Xp0I+G1
	bhoil4I1XW2EyvNIzB13m/GN2GO1F8EsMorjK+k6PKzNv0N8gfKFSyciXUnsXJ2JNnDo=;
Message-ID: <67c1bcb0-032b-0699-74d2-70677d177f64@xen.org>
Date: Tue, 14 Dec 2021 17:06:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 20/47] build: add headers path to CFLAGS once for
 all archs
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-21-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-21-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> This just remove duplication.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

For Arm:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
>   xen/Makefile           | 3 +++
>   xen/arch/arm/arch.mk   | 3 ---
>   xen/arch/riscv/arch.mk | 2 --
>   xen/arch/x86/arch.mk   | 2 --
>   4 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/Makefile b/xen/Makefile
> index 06d5e4fd61c1..efd7538099f3 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -312,6 +312,9 @@ CFLAGS += -flto
>   LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>   endif
>   
> +CFLAGS += -I$(srctree)/include
> +CFLAGS += -I$(srctree)/arch/$(TARGET_ARCH)/include
> +
>   # Note that link order matters!
>   ALL_OBJS-y                := common/built_in.o
>   ALL_OBJS-y                += drivers/built_in.o
> diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk
> index 4e3f7014305e..094b67072304 100644
> --- a/xen/arch/arm/arch.mk
> +++ b/xen/arch/arm/arch.mk
> @@ -1,9 +1,6 @@
>   ########################################
>   # arm-specific definitions
>   
> -CFLAGS += -I$(srctree)/include
> -CFLAGS += -I$(srctree)/arch/$(TARGET_ARCH)/include
> -
>   $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
>   $(call cc-option-add,CFLAGS,CC,-Wnested-externs)
>   
> diff --git a/xen/arch/riscv/arch.mk b/xen/arch/riscv/arch.mk
> index 694ba053ceab..ae8fe9dec730 100644
> --- a/xen/arch/riscv/arch.mk
> +++ b/xen/arch/riscv/arch.mk
> @@ -11,5 +11,3 @@ riscv-march-$(CONFIG_RISCV_ISA_C)       := $(riscv-march-y)c
>   # -mcmodel=medlow would force Xen into the lower half.
>   
>   CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany
> -CFLAGS += -I$(srctree)/include
> -CFLAGS += -I$(srctree)/arch/$(TARGET_ARCH)/include
> diff --git a/xen/arch/x86/arch.mk b/xen/arch/x86/arch.mk
> index 5152de343082..1ba488d645c0 100644
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -3,8 +3,6 @@
>   
>   export XEN_IMG_OFFSET := 0x200000
>   
> -CFLAGS += -I$(srctree)/include
> -CFLAGS += -I$(srctree)/arch/$(TARGET_ARCH)/include
>   CFLAGS += -I$(srctree)/arch/x86/include/asm/mach-generic
>   CFLAGS += -I$(srctree)/arch/x86/include/asm/mach-default
>   CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET)

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:08:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:08:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246956.425928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBHL-0006X2-D6; Tue, 14 Dec 2021 17:07:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246956.425928; Tue, 14 Dec 2021 17:07:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBHL-0006Wv-9r; Tue, 14 Dec 2021 17:07:51 +0000
Received: by outflank-mailman (input) for mailman id 246956;
 Tue, 14 Dec 2021 17:07:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBHK-0006Wn-0V
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:07:50 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBHI-0004fc-2k; Tue, 14 Dec 2021 17:07:48 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBHH-0004jZ-Sr; Tue, 14 Dec 2021 17:07:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=i50K/7EwgKHpshLqmUbo5A/wty9ebUcpgeIvfZUJmjE=; b=dqSloZFh1/Z7lQQZbAgtap12rz
	0AWGfTpZOGtxQbUUFYkXX4/sFNAXHWesqR/4rm0n0yKH4h+q+h/QNYoajzOnJZ74NpL1rhRTLIap1
	es/1D9fKNgxGH5iQc0akYcafFpKji7rOGod7oRKWyTdudujiy+k0iTZdbrIQhulKHzV4=;
Message-ID: <d8b5bc56-1bdd-d6ec-42aa-860e81172e88@xen.org>
Date: Tue, 14 Dec 2021 17:07:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 22/47] build: clean-up "clean" rules of duplication
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>, Andrew Cooper
 <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
 Ian Jackson <iwj@xenproject.org>, Stefano Stabellini
 <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-23-anthony.perard@citrix.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211125134006.1076646-23-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Anthony,

On 25/11/2021 13:39, Anthony PERARD wrote:
> All those files to be removed are already done in the main Makefile,
> either by the "find" command or directly (for $(TARGET).efi).
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:09:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:09:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246964.425939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBJO-0007MB-QD; Tue, 14 Dec 2021 17:09:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246964.425939; Tue, 14 Dec 2021 17:09:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBJO-0007M4-Lk; Tue, 14 Dec 2021 17:09:58 +0000
Received: by outflank-mailman (input) for mailman id 246964;
 Tue, 14 Dec 2021 17:09:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q7Ra=Q7=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxBJN-0007Lr-NL
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:09:57 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a4404363-5d00-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 18:09:49 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a4404363-5d00-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639501795;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=8hn57TMkA5v9dIzqrpDBV1g9Ok9lBo7N43dr/HPID7I=;
  b=HxRnK7zr7h6qyoZdwv+DoACJ4ewbQRkWYlBiRMnriJUp30G9JSXjByyD
   ErutfxpM60rp3Tfe703ef/KT3iYYxgMBHujTQxx9xkyvamgjk+vBfQVUB
   ATWipnmNPH6421gR3kfUstqRNGKtvgSO1ipx+KA6immRol+OUxL9ZQ9Lw
   Y=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: P19R1AKNmumojWfJZeb306TR1taRhAj7QWHpS+SKSk7jJTrkm1+Ne7v55m1luAg0kcA2UsovSK
 +vd0/lctz3qfpi+bCjPOR7IorXjB9xU/JChLhofKv5+iQ7tU8K/HhZ1NVZ3485s8X1SYGs4q7C
 0V0uG5LaB8AdPHK2FsxojV0Ca3woyZY2oGpFLlaXgD299OeU17tf+VLJ9NeKOciDl1datyDBmM
 2YJTJukn5NpTiinVZ4shT1Ft7JMBmQJPvTe+bHeUPVhQUZZ3dyWG1FVF0xCytf2IVVWEvTTozj
 1w1erCXT8kaNgYP1cshfxHRp
X-SBRS: 5.1
X-MesageID: 59506316
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SDRZCapAuT7BxfcOYzrOe0M6/mJeBmKnYhIvgKrLsJaIsI4StFCzt
 garIBmCPvaPYmD9co1zOonn8EMOucWByoU3QQM++yA0RXtG8ZuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24HlW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZmpVjt4ZPfNo/4MQjl2TXEmH5BGu6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ptEMWQ0NUqojxtnHgYsGJY/lteU2TrAUCxBilOu4qEv/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkBL8CWwzeB9nOqh8fMkDn9VYZUE6e3ntZgjUeP3GUVBFsTXEGivPiiokekXpRUL
 El80hQpqa8+5Um6VO7XVhezoGOHlhMEUt8WGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmL+ITXOQ8J+EoDX0PjIaRUcDei0sXQYD+8Pkoow4klTIVNkLOKy/g8DxGDrw6
 yuXtyV4jLIW5fPnzI3iowqB2Wj14MGUEEhlvW07Q15J8Ct8fZGZNtby6GPB/OdgAtjJFnu8v
 Dsbzp32AP81MbmBkymEQeMoFb6v5uqYPDC0vWODD6XN5Bz2pSf9INk4DCVWYR4wb51aIWOBj
 Fr74FsJvPdu0G2Wgbibim5bI+Aj1uDeGNvsTZg4hfIeM8EqJGdrEMyDDHN8PlwBcmBwwcnT2
 r/BKK5A6Er274w9k1JaoM9HjtcWKtgWnz+7eHwC503PPUCiTHCUU6wZF1CFc/o06qiJyC2Mr
 Y0Oa5HTk0gBD7yuCsUyzWL1BQpVRZTcLcqpw/G7i8bZelY2cI3fI6G5LUwdl3xNwP0Oy7agE
 oCVUU5E0lvv7UAr2i3RAk2PnIjHBM4lxVpiZHREFQ/xhxALPNf3hI9CJsBfVeR2q4ReIQtcE
 qBtlzOoWa8UFFwqOl01MPHAkWCVXEjx2F/VYXP6OGNXklwJb1Whx+IItzDHrEEmZhdbf+Nny
 1F5/g+EE5cFWSp4C8PaNKCmw1+r5CBPk+NuRUrYZNJUfRy0ooRtLiXwiN4xIt0NdkqflmfLi
 V7ODEdKv/TJrq807MLN2fKOobC2HrYsBUFdBWTas+q7bHGI4mq5zIZce++UZjSBBnjs8aCva
 LwNnfHxOfEKhnhQtI94H+o5xK4y/YK39bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQDYOeHIsLoFlIVNTEJVOXb2KFGgCTW4NQ0PF7+uH198o2YXBgAJBKLkiFccud4adt33
 ec7tccKwAWjkR52YM2ehyVZ+mnQfHwNV6Ir6sMTDIPx01d5z1hDZdrXCzPs4YHJYNJJaxF4L
 jiRjavEprJd2kudLCZjSSmThbJQ1cYUpRRH7F4ePFDYyNPKi8g+0ABV7TlqHB9eyQ9K0r4rN
 2VmX6GvyX5iI9u8aBB/Yl2R
IronPort-HdrOrdr: A9a23:L9Bqq6q9nKfd1LcfZqQnJkIaV5opeYIsimQD101hICG8cqSj9v
 xGuM5rsiMc6QxhPE3I9urtBEDtexzhHNtOkO8s1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM
 VdmsBFeaTN5DNB7foSjjPXL+od
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="59506316"
Date: Tue, 14 Dec 2021 17:09:49 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Julien Grall <julien@xen.org>
CC: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Stefano
 Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [XEN PATCH v8 01/47] build: factorise generation of the linker
 scripts
Message-ID: <YbjP3ZBaRVf0s4t6@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-2-anthony.perard@citrix.com>
 <f9a5844a-6e70-cb10-a5b8-4bdf55751f5f@xen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f9a5844a-6e70-cb10-a5b8-4bdf55751f5f@xen.org>

On Tue, Dec 14, 2021 at 04:54:21PM +0000, Julien Grall wrote:
> On 25/11/2021 13:39, Anthony PERARD wrote:
> > diff --git a/xen/Rules.mk b/xen/Rules.mk
> > +# Linker scripts, .lds.S -> .lds
> > +quiet_cmd_cpp_lds_S = LDS     $@
> > +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $<
> > +

> > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > +xen.lds: xen.lds.S FORCE
> > +	$(call if_changed,cpp_lds_S)
> 
> Sorry, I haven't really followed the build system rework. Could you explain
> why it is necessary to add FORCE?

This new rules make use of a new macro "if_changed", and we need to
execute this new macro every time, even if the source file hasn't been
modified.

if_changed, in addition to checking if the source is newer than the
target that make does, also compare the command line used to generate
the target. If the command line have changed, the macro update the
target.

The command line to execute is stored in "cmd_$1" variables, in this case
"cmd_cpp_lds_S". The macro if_changed store the command line in the file
".${target-name}.cmd".

So, every time the macro if_changed is used, we need to tell make to
always execute the recipe, thus FORCE.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:10:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:10:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246965.425950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBJQ-0007cF-0R; Tue, 14 Dec 2021 17:10:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246965.425950; Tue, 14 Dec 2021 17:09:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBJP-0007c8-TN; Tue, 14 Dec 2021 17:09:59 +0000
Received: by outflank-mailman (input) for mailman id 246965;
 Tue, 14 Dec 2021 17:09:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxBJO-0007Lx-HP; Tue, 14 Dec 2021 17:09:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxBJO-0004iZ-E8; Tue, 14 Dec 2021 17:09:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxBJO-0004aJ-5J; Tue, 14 Dec 2021 17:09:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxBJO-00032r-4r; Tue, 14 Dec 2021 17:09:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=V8wDBPWrk+c+vZfN2yme2XVtDMgcVJxLZmxxLsvstMY=; b=qoNO9SwinGvL+F7FQYYlPN2X7K
	sLKd+zE5FkBqg0trXBeDcTBF1/FkegmYkSYJinTZE7Qj6vZpaMyP9oXnIJzfekRdU3USpgGdDRVG6
	w/fYpZZv5zKKUBqhdbbF9Ncbxyt6ZEToYZCWae5bT77lmjMxmQCrbHoojczYEPxTryUg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167412-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167412: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=249e0f1d8f203188ccdcced5a05c2149739e1566
X-Osstest-Versions-That:
    xen=1382241fe880d48e109f2056cec052bb3919a9d1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 17:09:58 +0000

flight 167412 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167412/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  249e0f1d8f203188ccdcced5a05c2149739e1566
baseline version:
 xen                  1382241fe880d48e109f2056cec052bb3919a9d1

Last test of basis   167407  2021-12-14 09:02:57 Z    0 days
Testing same since   167412  2021-12-14 13:01:35 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1382241fe8..249e0f1d8f  249e0f1d8f203188ccdcced5a05c2149739e1566 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:12:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:12:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246974.425964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBLc-0000ti-FU; Tue, 14 Dec 2021 17:12:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246974.425964; Tue, 14 Dec 2021 17:12:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBLc-0000tb-CN; Tue, 14 Dec 2021 17:12:16 +0000
Received: by outflank-mailman (input) for mailman id 246974;
 Tue, 14 Dec 2021 17:12:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBLb-0000tT-MN
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:12:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBLZ-0004ks-Mh; Tue, 14 Dec 2021 17:12:13 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBLZ-0005Bl-GF; Tue, 14 Dec 2021 17:12:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ykFKRdNjX5CVmLmfQ+KGFWC3D32lG6LQeCQYTdB8+MQ=; b=peOnIfVcE0qTWG7WnbyvtHFr4v
	jRLzIlSP2g3hFzT6FrWgUGOu0bP5mlXMN/zcLR+mAFCi2DlDZgNMPGnto/5tMUiQFVMJKbDzYIbUY
	w2HnLSjtbYTm1DVG4DPFsL59h5OpDuCyQtkM5RJ+kUUNX7npKYGv8gGaNLiy/2eYk3G0=;
Message-ID: <c18e0102-86fc-2ba5-52f4-7607c96517c1@xen.org>
Date: Tue, 14 Dec 2021 17:12:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 01/47] build: factorise generation of the linker
 scripts
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-2-anthony.perard@citrix.com>
 <f9a5844a-6e70-cb10-a5b8-4bdf55751f5f@xen.org> <YbjP3ZBaRVf0s4t6@perard>
From: Julien Grall <julien@xen.org>
In-Reply-To: <YbjP3ZBaRVf0s4t6@perard>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/12/2021 17:09, Anthony PERARD wrote:
> On Tue, Dec 14, 2021 at 04:54:21PM +0000, Julien Grall wrote:
>> On 25/11/2021 13:39, Anthony PERARD wrote:
>>> diff --git a/xen/Rules.mk b/xen/Rules.mk
>>> +# Linker scripts, .lds.S -> .lds
>>> +quiet_cmd_cpp_lds_S = LDS     $@
>>> +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $<
>>> +
> 
>>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>>> +xen.lds: xen.lds.S FORCE
>>> +	$(call if_changed,cpp_lds_S)
>>
>> Sorry, I haven't really followed the build system rework. Could you explain
>> why it is necessary to add FORCE?
> 
> This new rules make use of a new macro "if_changed", and we need to
> execute this new macro every time, even if the source file hasn't been
> modified.
> 
> if_changed, in addition to checking if the source is newer than the
> target that make does, also compare the command line used to generate
> the target. If the command line have changed, the macro update the
> target.

Ah, that's the part I was missing. Thanks for the clarification! With that:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:21:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:21:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246979.425975 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBUA-0002Tk-Af; Tue, 14 Dec 2021 17:21:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246979.425975; Tue, 14 Dec 2021 17:21:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBUA-0002Td-7m; Tue, 14 Dec 2021 17:21:06 +0000
Received: by outflank-mailman (input) for mailman id 246979;
 Tue, 14 Dec 2021 17:21:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBU9-0002TX-FK
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:21:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBU8-0004uT-7j; Tue, 14 Dec 2021 17:21:04 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBU8-0005ay-0z; Tue, 14 Dec 2021 17:21:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=tnYvMRimOZIN7460hREEVRJGGqHlnG04HoHpZv9+SPg=; b=IaANiDtAdUf59C4OZpBGZrQvcq
	prjPNK7cDpWFXHXDQHEJR4iUiVk1n4Ak/CxIQrTPhp4I6K8sFHleh8mDqfuv3zs4HqeEaBN+/rIbh
	uKlg3hbCorfxRr4yKPwj0mPUJeZS+DRh4UE/kG3s4oXTCyvEkUPKM+sLKCF+cth+7xMw=;
Message-ID: <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>
Date: Tue, 14 Dec 2021 17:21:01 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-2-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211208155606.20029-2-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 08/12/2021 15:55, Juergen Gross wrote:
> Today Arm is using another entry point for the vcpu_op hypercall as

NIT: The 'as' doesn't sound right here. Did you mean 'compare to'?

> x86, as some of the common sub-ops are not supported on Arm. The Arm
> specific handler filetrs out the not supported sub-ops and then calls

Typo: s/filetrs/filters/

> the common handler. This leads to the weird call hierarchy:
> 
>    do_arm_vcpu_op()
>      do_vcpu_op()
>        arch_do_vcpu_op()
> 
> Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
> arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
> of above calls can be avoided without restricting any potential
> future use of common sub-ops for Arm.
> 
> Additionally the single user of HYPERCALL_ARM() can be modified and
> HYPERCALL_ARM() can be removed.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:37:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:37:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246985.425986 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBjX-0004BF-PB; Tue, 14 Dec 2021 17:36:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246985.425986; Tue, 14 Dec 2021 17:36:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBjX-0004B8-Ke; Tue, 14 Dec 2021 17:36:59 +0000
Received: by outflank-mailman (input) for mailman id 246985;
 Tue, 14 Dec 2021 17:36:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxBjW-0004B2-76
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:36:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBjV-0005A0-Kf; Tue, 14 Dec 2021 17:36:57 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxBjV-0006pt-Dz; Tue, 14 Dec 2021 17:36:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OC7sxcFPGkiDzQI1wEyryA9hcrz9jfCs4oCwHco0SoI=; b=Fb3e9Oi6Zsyg9+bOSl9grOum0/
	vx97KNkXggQ5THJlrFUIPbj7OcEzqE64tQtdLg7pC87JVHIiy7oVU4YJLm2ryiT43x6O/Bo53fjRn
	Lo/vrC5BHNMb5D6toDIsfN9NrF73pPS1jxXymfgOjGkESwS492VwmTzpViwYaUGa3zYY=;
Message-ID: <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
Date: Tue, 14 Dec 2021 17:36:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211208155606.20029-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 08/12/2021 15:55, Juergen Gross wrote:
> Today most hypercall handlers have a return type of long, while the
> compat ones return an int. There are a few exceptions from that rule,
> however.

So on Arm64, I don't think you can make use of the full 64-bit because a 
32-bit domain would not be able to see the top 32-bit.

In fact, this could potentially cause us some trouble (see [1]) in Xen.
So it feels like the hypercalls should always return a 32-bit signed 
value on Arm.

The other advantage is it would be clear that the top 32-bit are not 
usuable. Stefano, what do you think?

> 
> Get rid of the exceptions by letting compat handlers always return int
> and others always return long.
> 
> For the compat hvm case use eax instead of rax for the stored result as
> it should have been from the beginning.
> 
> Additionally move some prototypes to include/asm-x86/hypercall.h
> as they are x86 specific. Move the do_physdev_op() prototype from both
> architecture dependant headers to the common one. Move the
> compat_platform_op() prototype to the common header.
> 
> Switch some non style compliant types (u32, s32, s64) to style compliant
> ones.

TBH, I think this should have been split because the modifications are 
done on lines that are untouched.

The extra patch would have made the review easier (even if this patch is 
still quite small).

> 
> Rename paging_domctl_continuation() to do_paging_domctl_cont() and add
> a matching define for the associated hypercall.
> 
> Make do_callback_op() and compat_callback_op() more similar by adding
> the const attribute to compat_callback_op()'s 2nd parameter.
> 
> Change the type of the cmd parameter for [do|compat]_kexec_op() to
> unsigned int, as this is more appropriate for the compat case.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Cheers,

[1] [1] 
https://lore.kernel.org/xen-devel/20211206142032.27536-1-michal.orzel@arm.com/

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:39:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:39:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246991.425996 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBmH-0004xl-5c; Tue, 14 Dec 2021 17:39:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246991.425996; Tue, 14 Dec 2021 17:39:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBmH-0004xe-2m; Tue, 14 Dec 2021 17:39:49 +0000
Received: by outflank-mailman (input) for mailman id 246991;
 Tue, 14 Dec 2021 17:39:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=C1I2=Q7=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxBmF-0004xW-7a
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:39:47 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d347d94e-5d04-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 18:39:45 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44136)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxBlz-000BnM-1a (Exim 4.95) (return-path <amc96@srcf.net>);
 Tue, 14 Dec 2021 17:39:31 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 8AFF42056A;
 Tue, 14 Dec 2021 17:39:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d347d94e-5d04-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <a7f0b1b0-cf4c-5ff1-cfd1-a2df9076ba46@srcf.net>
Date: Tue, 14 Dec 2021 17:39:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 02/47] xen: move include/asm-* to
 arch/*/include/asm
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Paul Durrant <paul@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Tamas K Lengyel <tamas@tklengyel.com>,
 Alexandru Isaila <aisaila@bitdefender.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>,
 Kevin Tian <kevin.tian@intel.com>,
 Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-3-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211125134006.1076646-3-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 25/11/2021 13:39, Anthony PERARD wrote:
> This avoid the need to create the symbolic link "include/asm".
>
> Whenever a comment refer to an "asm" headers, this patch avoid
> spelling the arch when not needed to avoid some code churn.
>
> One unrelated change is to sort entries in MAINTAINERS for "INTEL(R)
> VT FOR X86 (VT-X)"
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:44:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:44:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.246997.426007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBr3-0006Oy-TR; Tue, 14 Dec 2021 17:44:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 246997.426007; Tue, 14 Dec 2021 17:44:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxBr3-0006Or-QW; Tue, 14 Dec 2021 17:44:45 +0000
Received: by outflank-mailman (input) for mailman id 246997;
 Tue, 14 Dec 2021 17:44:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KYVb=Q7=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxBr3-0006Ol-8S
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:44:45 +0000
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com
 [2a00:1450:4864:20::236])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85b259c2-5d05-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 18:44:44 +0100 (CET)
Received: by mail-lj1-x236.google.com with SMTP id m12so29482307ljj.6
 for <xen-devel@lists.xenproject.org>; Tue, 14 Dec 2021 09:44:44 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l5sm66998ljh.66.2021.12.14.09.44.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 14 Dec 2021 09:44:43 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85b259c2-5d05-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=uqxUfm1THXv/yDKcD369ZBk4WnFZq/PwykH2G2ovfx8=;
        b=HkPhSAhtrIPNwoawvtRNGKHA1GMJkgBCRuG4dMJnzFvAteqUsC/O6YSoF/0JFNibP8
         qxqJgy49FPhoKTJaKHrMAPbHyzGsWhXEk0fMZSfsG/ktlhTnDQS7Q5MBv/xrfxTWeriR
         aIBiezl6SrIUCUtGt+6PrACk7EbOmcyKLeMB+lWC3Wb4nu9Hc1tq1z4Tg/R3oB1fuuPf
         ZGw9AUjKyhvGZ10d3xePOsgTJuSWR/G4iGeJf3i6uvyOixAHmnILHTqZiw/ub2FGDEcH
         xZexdX42D+MKKr17yqTZyd5jvbZEM6+1VCrEPGxXdKbcK6ewJqljRxYKqlMVeVxUaV65
         I7gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=uqxUfm1THXv/yDKcD369ZBk4WnFZq/PwykH2G2ovfx8=;
        b=di5RbaXTa81FmoWarBeAzMDWLFhC4g36H5tGfXg5CEsbEG2Dhzwzk3g8ROKColwTJ2
         pIcmON0gSS906T8d2QGWgRY3OxhDu6de41QnhU9Cz8vingJQmHLswdOueogOSbvkvowp
         GaLQd4ogeeLqNIZkXGB6jSnqmUFfN/f0Hm0W5iH1rsRXUQ65dYTsFfBfHsrII32jGr/E
         5brY60rWRTbxw0ntgtovBEEtO9Slebc8DB5E5ZhEoRH10E5SwkFmmX74cd03KDumBVnm
         zwDyUnZK49jusaujGy0+uam2nhs3iXrS3N/HpbyouvB4G2qAQJz+tM4phcgh/uOynqli
         tGkQ==
X-Gm-Message-State: AOAM5323Qg00CdnLRU9iVRAHHTOX2C+2HO1bSsfL1L3UF6cSFHj2bVHx
	9Sw4ZW0v6ebzkSsZUHooOGM=
X-Google-Smtp-Source: ABdhPJzyHjwRnzY+cUwIqV/SFE74ckoJfjQjc2Sb5RXrlEZGACAkq7j+HuGYKrn4kpRFF6erAVVKDA==
X-Received: by 2002:a05:651c:a0f:: with SMTP id k15mr6554516ljq.298.1639503883712;
        Tue, 14 Dec 2021 09:44:43 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
Date: Tue, 14 Dec 2021 19:44:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YbjANCjAUGe4BAar@perard>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 18:03, Anthony PERARD wrote:

Hi Anthony


> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> This patch adds basic support for configuring and assisting virtio-disk
>> backend (emualator) which is intended to run out of Qemu and could be
>> run in any domain.
>> Although the Virtio block device is quite different from traditional
>> Xen PV block device (vbd) from the toolstack point of view:
>>   - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>>     written to Xenstore are fetched by the frontend (the vdev is not
>>     passed to the frontend)
>>   - the ring-ref/event-channel are not used for the backend<->frontend
>>     communication, the proposed IPC for Virtio is IOREQ/DM
>> it is still a "block device" and ought to be integrated in existing
>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>> logic to deal with Virtio devices as well.
> How backend are intended to be created? Is there something listening on
> xenstore?
>
> You mention QEMU as been the backend, do you intend to have QEMU
> listening on xenstore to create a virtio backend? Or maybe it is on the
> command line? There is QMP as well, but it's probably a lot more
> complicated as I think libxl needs refactoring for that.


No, QEMU is not involved there. The backend is a standalone application,
it is launched from the command line. The backend reads the Xenstore to get
the configuration and to detect when guest with the frontend is 
created/destroyed.


>
>> Besides introducing new disk backend type (LIBXL_DISK_BACKEND_VIRTIO)
>> introduce new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model.
>>
>> In order to inform the toolstack that Virtio disk needs to be used
>> extend "disk" configuration by introducing new "virtio" flag.
>> An example of domain configuration:
>> disk = [ 'backend=DomD, phy:/dev/mmcblk1p3, xvda1, rw, virtio' ]
> This new "virtio" flags feels strange. Would having something like
> "backendtype=virtio" works?


IIRC I considered "backendtype=virtio" option, but decided to go "an 
extra virtio flag" route, however I don't remember what exactly affected 
my decision.
But, I see your point and agree, I will analyze whether we can use 
"backendtype=virtio", I hope that we can, but need to make sure.


>
>> Please note, this patch is not enough for virtio-disk to work
>> on Xen (Arm), as for every Virtio device (including disk) we need
>> to allocate Virtio MMIO params (IRQ and memory region) and pass
>> them to the backend, also update Guest device-tree. The subsequent
>> patch will add these missing bits. For the current patch,
>> the default "irq" and "base" are just written to the Xenstore.
> This feels like the patches are in the wrong order. I don't think it is
> a good idea to allow to create broken configuration until a follow-up
> patch fixes things.

Yes, I also think this is not an ideal splitting, so I decided to write 
a few sentences to draw reviewer's attention to this.
The problem is that second patch adds Arm bits which are local to 
libs/light/libxl_arm.c and if I put it before the current one I will 
break the bisectability
as there will be no callers yet.


>
>> diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
>> index 70eed43..50a4d45 100644
>> --- a/tools/xl/xl_block.c
>> +++ b/tools/xl/xl_block.c
>> @@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
>>           return 0;
>>       }
>>   
>> +    if (disk.virtio) {
>> +        fprintf(stderr, "block-attach is not supported for Virtio device\n");
>> +        return 1;
>> +    }
> This might not be the right place. libxl might want to prevent hotplug
> instead.

Could you please point me the right place where to prevent hotplug?


Thank you.


>
> Thanks,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 17:58:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 17:58:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247002.426019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxC3m-00084F-44; Tue, 14 Dec 2021 17:57:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247002.426019; Tue, 14 Dec 2021 17:57:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxC3m-000848-0g; Tue, 14 Dec 2021 17:57:54 +0000
Received: by outflank-mailman (input) for mailman id 247002;
 Tue, 14 Dec 2021 17:57:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=fP3+=Q7=wanadoo.fr=christophe.jaillet@srs-se1.protection.inumbo.net>)
 id 1mxC3k-000842-UO
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 17:57:52 +0000
Received: from smtp.smtpout.orange.fr (smtp03.smtpout.orange.fr
 [80.12.242.125]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5aec6200-5d07-11ec-9e60-abaf8a552007;
 Tue, 14 Dec 2021 18:57:51 +0100 (CET)
Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA
 id xC3hmDtUWIEdlxC3hmHzWx; Tue, 14 Dec 2021 18:57:51 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5aec6200-5d07-11ec-9e60-abaf8a552007
X-ME-Helo: [192.168.1.18]
X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ==
X-ME-Date: Tue, 14 Dec 2021 18:57:51 +0100
X-ME-IP: 86.243.171.122
Subject: Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org,
 axboe@kernel.dk, xen-devel@lists.xenproject.org,
 linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
Newsgroups: gmane.linux.kernel.janitors,gmane.comp.emulators.xen.devel,gmane.linux.block,gmane.linux.kernel
References: <d6f31db1d2542e1b4ba66d4cea80d3891678aa5a.1638476031.git.christophe.jaillet@wanadoo.fr>
 <Ybh5G2ziyRXkz3WF@Air-de-Roger> <Ybh7KgtQt0/MFtyw@Air-de-Roger>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Message-ID: <14dbcf69-afc1-c11b-e1ad-e8453a80cc6e@wanadoo.fr>
Date: Tue, 14 Dec 2021 18:57:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Ybh7KgtQt0/MFtyw@Air-de-Roger>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Le 14/12/2021 à 12:08, Roger Pau Monné a écrit :
> On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote:
>> On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
>>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
>>> open-coded arithmetic in allocator arguments.
>>>
>>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
>>> consistency.
>>>
>>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
>>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Oh, I see there's been further discussion on this to avoid relying
> implicitly on the size of the bitmap being rounded to the size of an
> unsigned long. I think a new version is expected then?
> 
> Thanks, Roger.
> 

Yes, I'll send a patch in order to add a 'bitmap_size()'
I'll update this patch when/if it is merged.

You can drop it for now.

CJ


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 18:12:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 18:12:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247011.426030 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxCHO-0002Iz-Bm; Tue, 14 Dec 2021 18:11:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247011.426030; Tue, 14 Dec 2021 18:11:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxCHO-0002Is-8v; Tue, 14 Dec 2021 18:11:58 +0000
Received: by outflank-mailman (input) for mailman id 247011;
 Tue, 14 Dec 2021 18:11:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Q7Ra=Q7=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxCHN-0002Ik-3H
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 18:11:57 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4c3c3525-5d09-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 19:11:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c3c3525-5d09-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639505514;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=5OyLA5AStZ/0Y3oavESWTpPnQwHRYRXtQ7aTP9l0ESM=;
  b=ImW2O357AB+l03vuCdOrVDGQUaTYgOjDC1Zy70jxj9upPJe+5xCZJuWm
   6LB71X3cFQEeqfj+K1zppz6ZrCEZ3KrNz7IAn8jqm662yqWEiCe0eF4OL
   IUkGZ9LZED7IFh7iDfHNZloSuMhI7CuwAzNc2I+CxTfnN/AtLwmK24JIX
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: oQ35Ox3syJsHmoPHGSuqyDw5LT8lMslOK84a4A/CusoGFqnkMeR+Cyj5dpjo4jCVVCcp9Eh9AA
 nNZvGgCxAh5pQvhpHwtOzKINZR13lr+l4IVz2P1GtHWE+gtvrw3BKrmVavsTFcSklk5JHCQVvl
 5HA+S145jFcM8ZFJqzZewFVHsY1nQNvzVlsLcPIEeRNC4oJpRnDCFJNzO9Wna3lzk1Tpee7eHB
 wyP7dJv3hQOgrQQTs6LFZgsHH9htc7ScYTLnksgNbIj2Avm2YKl9ET9x18vskeFusy5/bYX/gG
 vgq2WNMlhp2BpRieclieSG1m
X-SBRS: 5.1
X-MesageID: 62082656
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:4FRij63dJ6rX0IjBNvbD5RB2kn2cJEfYwER7XKvMYLTBsI5bpzIEn
 WpKC2HQbKuKYGTyfN0lYY6w80NT6J7UzNI2SgVppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn970Es5wrJh2OaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhz91Rm
 M5U7oeLSSQLAJfBtdpCdhBYOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9u3JgeR6iDO
 aL1bxIoNE7kWB1qPWwsEYgvmvaH30jVazNX/Qf9Sa0fvDGIkV0ZPKLWGNjaYNuRXu1Og12V4
 GnB+gzRHRUyJNGZjz2f/RqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlbUsz5MQMMLCNY6yyOz8Kf53Vm8D2gtG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DETFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBvGsnfBo3bZdUEdMMX
 KM1kVkOjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3FmrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/LoarSjeK0kl9YxMI6b9+KYFjgYpPkeLEo
 iO0VkNCkQKtjnzbMwSaLHtkbeq3D5p4qHs6Ow0qPEqphCd/Mdr+sv9HestlZ6Qj+cxi0eVwE
 6sPdfKfD6kdUT/A4TkcM8Xw9dQwaBSxiAuSFCO5ezxjLYV4TgnE94a8LAvi/SUDFAStss46r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJuepMCMxTOwDeex
 j26OxZAqLmfuZIx/fnImbuA89WjHdxhExcIBGLc97u3a3XXpzLx3Y9aXe+UVjnBT2eoqr66b
 OBYwvygYv0KmFFG79h1H7pxlP9s4tLuo/lRzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXaeeTJcfoMF8NPw50PO2M2MYdliTW8flocl7x4zV6/ebfXEhfV/VWZPex8Feh3FsZ/
 Noc
IronPort-HdrOrdr: A9a23:6jNq3agjmbc+5Y0AhA6/l4kFIHBQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.88,205,1635220800"; 
   d="scan'208";a="62082656"
Date: Tue, 14 Dec 2021 18:11:44 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, "Juergen
 Gross" <jgross@suse.com>
Subject: Re: [PATCH] tools/libxl: Don't read STORE/CONSOLE_PFN from Xen
Message-ID: <YbjeYEJDHkG3K9aT@perard>
References: <20211209170752.20576-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211209170752.20576-1-andrew.cooper3@citrix.com>

On Thu, Dec 09, 2021 at 05:07:52PM +0000, Andrew Cooper wrote:
> The values are already available in dom->{console,xenstore}_pfn, just like on
> the PV side of things.  No need to ask Xen.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 19:19:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 19:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247050.426040 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxDKP-0000nH-HN; Tue, 14 Dec 2021 19:19:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247050.426040; Tue, 14 Dec 2021 19:19:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxDKP-0000nA-EB; Tue, 14 Dec 2021 19:19:09 +0000
Received: by outflank-mailman (input) for mailman id 247050;
 Tue, 14 Dec 2021 19:19:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxDKN-0000n4-SP
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 19:19:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxDKM-0006zs-Fq; Tue, 14 Dec 2021 19:19:06 +0000
Received: from [54.239.6.190] (helo=[192.168.26.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxDKM-0005Jv-7s; Tue, 14 Dec 2021 19:19:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VWuuhPiWxrynR9YP+MPVfYcQ6l8C+r8VC875tn3U7L4=; b=SiV4qGUePjlBILafP/4lyhezxl
	oMaO28feyiS4aayFPi6/kkn0rcz0S28zbhaP4j2w4WIMRC8Gu63ZJmLzeN6M8+g5etAtVkNlRPYAu
	SdWM0nea5EASXCRFTDslq4d4n7kHHq+LLb7JUh0/FJqXv1sZTaeetEjNQ1kuXZ+f80cI=;
Message-ID: <4ed5073e-8083-ac72-6477-676eaf2e2eb8@xen.org>
Date: Tue, 14 Dec 2021 19:19:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] SUPPORT.md, MAINTAINERS: De-support qemu-xen-traditional
To: Ian Jackson <iwj@xenproject.org>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211209142640.24437-1-iwj@xenproject.org>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211209142640.24437-1-iwj@xenproject.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ian,

On 09/12/2021 14:26, Ian Jackson wrote:
> In 4.16 we changed to not build this by default.  I think it is now
> time to explicitly desupport it, completely, in favour of Linux dm
> stub domains.
> 
> Signed-off-by: Ian Jackson <iwj@xenproject.org>
> ---
>   MAINTAINERS |  2 +-
>   SUPPORT.md  | 18 +++++++++---------
>   2 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e43dc0edce..933579541f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -455,7 +455,7 @@ S:	Supported
>   F:	tools/python
>   
>   QEMU-DM
> -S:	Supported
> +S:	Obsolete
>   T:	git https://xenbits.xenproject.org/git-http/qemu-xen-traditional.git
>   
>   QEMU UPSTREAM
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 3a34933c89..b64ebee93b 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -802,17 +802,17 @@ See the section **Blkback** for image formats supported by QEMU.
>   ### qemu-xen-traditional ###
>   
>   The Xen Project provides an old version of qemu with modifications
> -which enable use as a device model stub domain.  The old version is
> -normally selected by default only in a stub dm configuration, but it
> -can be requested explicitly in other configurations, for example in
> -`xl` with `device_model_version="QEMU_XEN_TRADITIONAL"`.
> +which enable use as a device model stub domain.  This old version is
> +not built by default.  Even if it is build, it is normally selected by
> +default only in a stub dm configuration, but it can be requested
> +explicitly in other configurations, for example in `xl` with
> +`device_model_version="QEMU_XEN_TRADITIONAL"`.
>   
> -    Status, Device Model Stub Domains: Supported, with caveats
> -    Status, as host process device model: No security support, not recommended
> +When device model stub domains are desired for the additional
> +security, we recommend using a device model stub domain consisting of
> +a modern qemu and a Linux kernel.

Looking at SUPPORT.md, we have:

### Linux device model stubdomains

Support for running qemu-xen device model in a linux stubdomain.

     Status: Tech Preview

Is it still accurate? If yes, I am not sure we can recommend user to 
switch to Linux stubdomain until this is fully supported.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 20:16:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 20:16:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247068.426052 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxEDA-0007Re-Nb; Tue, 14 Dec 2021 20:15:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247068.426052; Tue, 14 Dec 2021 20:15:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxEDA-0007RX-KW; Tue, 14 Dec 2021 20:15:44 +0000
Received: by outflank-mailman (input) for mailman id 247068;
 Tue, 14 Dec 2021 20:15:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iTjg=Q7=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxED9-0007RR-6A
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 20:15:43 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99682f72-5d1a-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 21:15:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99682f72-5d1a-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639512936;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=d4wqcXY+MET+Bv0FcRzIRIc5XGvbPUI2bHV9pxD9Ydo=;
	b=moChZUSho9BA78Zeq1WI5tu/U00oT82AtvfenvZ7wj4+/rbRuMvnEvgp06APrkesXoQIzl
	7RPpBe3m0oONdQpdS7DAAUNLaW0sDBUgC0jenFPjG7Wr9CEB6Oy4B9l4Iuq/IfEVofBt4t
	vnaGOWsnREceAU8uxY8NAKpNhml+AgXrJsZ6gKqMSiQL7bA9CFgw8w2TYZeEYT8V3NhbQ8
	JAqpROxGWfe9cCXptM9xGI/fDzxgqMZx8ZITW8fq90knUugjlJY38p2e8sp+HmqqufWXbS
	n3mRyaNC3MmjNNomr7JUos4qRao6JylFxbVwVGdREF91hazpGg2c9oB6BzqE4w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639512936;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=d4wqcXY+MET+Bv0FcRzIRIc5XGvbPUI2bHV9pxD9Ydo=;
	b=+ecmdjzCvUtoz/ixJ5pxFaVr7F21Ajeaa5ilYhIAuSfZy+n3tm1NOnNdHltlRFCs+3G/Mc
	B5RpqeVcmdLBkuDA==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <87tufbrudl.ffs@tglx>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx>
Date: Tue, 14 Dec 2021 21:15:34 +0100
Message-ID: <87mtl3rli1.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Nishanth,

On Tue, Dec 14 2021 at 18:03, Thomas Gleixner wrote:
>     msi_device_data_release()
>     ...
>     pcim_release()
>        pci_disable_msi[x]()
>
> Groan....

I think I managed to distangle this. Can you please give:

   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4-part-2

and/or the full pile:

   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4-part-3

a test ride?

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 20:58:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 20:58:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247079.426071 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxErr-0003mb-39; Tue, 14 Dec 2021 20:57:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247079.426071; Tue, 14 Dec 2021 20:57:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxErq-0003mU-WE; Tue, 14 Dec 2021 20:57:47 +0000
Received: by outflank-mailman (input) for mailman id 247079;
 Tue, 14 Dec 2021 20:57:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=twTw=Q7=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mxErq-0003mO-0N
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 20:57:46 +0000
Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7ae2223a-5d20-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 21:57:43 +0100 (CET)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
 by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BEKuQ2G087867;
 Tue, 14 Dec 2021 14:56:26 -0600
Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27])
 by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BEKuQZP071677
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Tue, 14 Dec 2021 14:56:26 -0600
Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE106.ent.ti.com
 (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 14
 Dec 2021 14:56:26 -0600
Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE111.ent.ti.com
 (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Tue, 14 Dec 2021 14:56:26 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BEKuQKW080208;
 Tue, 14 Dec 2021 14:56:26 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7ae2223a-5d20-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639515386;
	bh=j3osEyGU+RxWIqSwbtxX3t4fWrHk6cyOWUyU3Kklrls=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=ro9Zy1BiNWwoHciKsimW9l8VopF6tYlVp/6zMhM4RqRr5OMdDNHhzpvvxTClpNzB8
	 dPzQuK5sKOVV9r4w2zlsPGBt+0LP2kgt2QlGyvAvguubR7lVNMCWrPyux0hcVHFUr4
	 7zdyFM5y9LIDHeI/2x8RTh77XgWACTwR6L5QvGfs=
Date: Tue, 14 Dec 2021 14:56:26 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Juergen Gross
	<jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann
	<arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin
 Herrenschmidt <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, Mark Rutland
	<mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>, <linux-wireless@vger.kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Message-ID: <20211214205626.lrnddha6bd6d6es5@possibly>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator>
 <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider>
 <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx>
 <87mtl3rli1.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87mtl3rli1.ffs@tglx>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 21:15-20211214, Thomas Gleixner wrote:
> Nishanth,
> 
> On Tue, Dec 14 2021 at 18:03, Thomas Gleixner wrote:
> >     msi_device_data_release()
> >     ...
> >     pcim_release()
> >        pci_disable_msi[x]()
> >
> > Groan....
> 
> I think I managed to distangle this. Can you please give:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4-part-2


Umm.. I am not entirely sure what is going on.. but all kinds of weird
corruption seems to occur with msi-v4-part-2 that does'nt seem to be
present in v5.16-rc5. (I use NFS since ethernet in K3 platforms use
inta/intr and dma that is impacted by this series).

I will try and rebase your patches on v5.16-rc4 to be sure as well and
report back later today once i get some time.

[1] https://gist.github.com/nmenon/a66e022926c4c15313c45d44313d860c msi-v4-part-2
[2] https://gist.github.com/nmenon/43085664d69ad846d596e76a06ed0656  v5.16-rc5
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 21:15:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 21:15:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247088.426085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxF8J-0006Tl-Ng; Tue, 14 Dec 2021 21:14:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247088.426085; Tue, 14 Dec 2021 21:14:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxF8J-0006Te-Ki; Tue, 14 Dec 2021 21:14:47 +0000
Received: by outflank-mailman (input) for mailman id 247088;
 Tue, 14 Dec 2021 21:14:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxF8I-0006TU-KG; Tue, 14 Dec 2021 21:14:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxF8I-0000eE-FS; Tue, 14 Dec 2021 21:14:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxF8I-000081-4I; Tue, 14 Dec 2021 21:14:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxF8I-0007Fz-3m; Tue, 14 Dec 2021 21:14:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=cDUlxkXDQejbcBC+diOzn8vjQXjqFKoQ3Tvlnp8iMmU=; b=a76VbNk/fci/hnWfqMaoIDlp2j
	CsPJb23CtzksUQNl2ZvL/QCD8kDofPQTIQxxWUynwiI/YaHkedyTZiq4rpW6Jwh/lFNWd3QTwDvrG
	SgCW6afNzpcKcH5ayFza8j488tCRPPAzWlws5LUpmja14+STmQYKMYlVwKUjvkOC9R+s=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167411-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167411: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-arm64-arm64-examine:reboot:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 21:14:46 +0000

flight 167411 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167411/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail in 167402 pass in 167411
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 18 guest-localmigrate/x10 fail in 167402 pass in 167411
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167402 pass in 167411
 test-arm64-arm64-examine      8 reboot                     fail pass in 167402

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167387
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167387
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167387
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167387
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167387
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167387
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167387
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167387
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167387
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167387
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167387
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167387
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167387
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167387  2021-12-13 01:52:51 Z    1 days
Testing same since   167402  2021-12-14 00:36:45 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     fail    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   df3e1a5efe..d828caa9ae  d828caa9aeee80c59a35f662f875f6573e9b532f -> master


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 21:16:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 21:16:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247093.426100 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxF9z-00074C-5O; Tue, 14 Dec 2021 21:16:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247093.426100; Tue, 14 Dec 2021 21:16:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxF9z-000745-2A; Tue, 14 Dec 2021 21:16:31 +0000
Received: by outflank-mailman (input) for mailman id 247093;
 Tue, 14 Dec 2021 21:16:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=0izq=Q7=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxF9x-00073z-MW
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 21:16:29 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 186a4ff5-5d23-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 22:16:27 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 186a4ff5-5d23-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639516587;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=4bkx3TwcUrdcOyHKGlZDOQ8jcimHx5KjsB2hX06YZ+w=;
  b=AgLLQ+KQAt41mgyXx9dUvi4XV7IHlV13/6e0E7x2MpoLngbP7lNPJMvH
   YD35wOyiqb22FIGadLXpRs0g4E0j6c7SlowXx/ILgdHWShd2bzFOz7Naw
   PyRbnPFjZR659f+DdyuerpQwgBRQ2tS1kk7f2fzNfa9OUXIvd02R/Zl4A
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: yc5EX/TepT8qErSTbH/kFzv5IVH8vEsdsFvwsICzdzgm10SRZ3YIityZwzlHWnvAEuu6xgGSid
 HhEPWmJSJ1ILt6qO3xIIEaiR8IEPXQKJgQcjoOLIf0F4202xU4YjnUiBIQIvQlOXIEjCKVqSNo
 B+UVDRfTZKE7slYjerzBprF+Fc5jHuglBg63U4XC/br4QD0gQidqki4aNmI31YSRJx/Gx27aQX
 VNrk0aYz21dU4lT4f37rT2sxxzA6LZtXZTgJYSwG2HSlY/vIGOoZCLfE9j5oojfD8jHXAO3ES8
 4u6bWytdbS6s6i2LQm3DvdRM
X-SBRS: 5.1
X-MesageID: 59527717
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:vXI7KKwAh+y7lO7SoiV6t+fUwSrEfRIJ4+MujC+fZmUNrF6WrkUAx
 mNLWGHSbviNZGXxLtgja4+1p0gCvpbdmNU3TlQ++yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbdl2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt49Py
 tJ1v5aQcws0H7HXmcocbDpzIwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVoru0lINPmI8U0vXZ4wCuCJf0nXYrCU+PB4towMDIY25ETR6mBP
 pVxhTxHcRjYeDBTan4rI7UvmLf4mz6jcGJSgQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krK53/8Aw0aHNWHxCCZ72m3gevSgSL8XplUH7q9ntZ6jVvWymENBRk+UVqgveL/mkO4Q8hYK
 UEf5mwpt6da3G6BQ8T5Xha4iGWZpRNaUN1Ve9DW8ynUlPCSuVzAQDFZEHgRM7TKqfPaWxR16
 F2Op9njJQZjrZyJUnOz94i3hgObbH19wXA5WQcISg4M4t/GqY41jw7SQtsLLJNZnuEZChmrn
 WnU8XFWa6E7yJdSiv7lpQyvbyeE/8CRFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7
 BDodyVzhd3i7K1hdgTREI3h/5nzvp5p1QEwZ3Y2TvHNEBz3pBaekXh4um0WGauQGp9slcXVS
 EHSoxhNw5RYIWGna6R6C6roVZ97kPC+S4S4Bq6OBjarXnSXXFXZlM2JTRTPt10BbWB2yf1vU
 XtlWZjE4Ykm5VRPk2PtGrZ1PU4DzSEi32LDLa0XPDz8uYdykEW9EO9fWHPXN7hRxPrd/G39r
 ocHX+PXmk43eLCvPUHqHXs7cAliwY4TXsut9aS6t4erf2JbJY3WI6OLnO56JdU6x/89eyWh1
 ijVZ3K0AWHX3RXvQThmoFg5AF82dZog/389IwI2OlOkhyoqbYq1tf9NfJorZ7g3sudkyKcsH
 fUCfsyBBNVJSyjGpGtBPcWs8tQ6eUT5nx+KMgqkfCM7I8xqSTvW94K2ZQDo7iQPUHa67JNsv
 7262wrHapMfXAA+Xt3OYfeiwgrp73gQke5/RWXSJdxXdBm++YRmMXWp3PQ2P9sNOVPIwT7Dj
 1SaBhIRpO/spY4p8YaW2fDY/tnxS+YnRxhUBWjW67qyJBL2xGv7zN8SSvuMcBDcSHjwpPeoa
 9JKwqyuK/YAhltL7dZxSu450aIk6tLzjLZG1QA4Tm7TZlGmB748cHmL2c5D6v9EyrND4FbkX
 0uO/p9ROKmTOdOjG1kUfVJ3YuOG3PASuz/T8fVqfxmquH4ppOKKARdIIh2BqC1BN78kYooqz
 NAotNMS9wHi2AEhNcyLj3wM+mmBRpDav37Lan3O7FfXtzcW
IronPort-HdrOrdr: A9a23:8VTiFaiP3Yf/k4tTvngCoGDglXBQXtYji2hC6mlwRA09TySZ//
 rBoB19726StN9xYgBFpTnuAsm9qB/nmaKdgrNhWItKPjOW21dARbsKheCJrgEIcxeOkNK1vp
 0AT0ERMrLN5CBB/KTH3DU=
X-IronPort-AV: E=Sophos;i="5.88,206,1635220800"; 
   d="scan'208";a="59527717"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Daniel Smith
	<dpsmith@apertussolutions.com>
Subject: [PATCH] x86/cpuid: Introduce dom0-cpuid command line option
Date: Tue, 14 Dec 2021 21:16:00 +0000
Message-ID: <20211214211600.2751-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Specifically, this lets the user opt in to non-default for dom0.

Split features[] out of parse_xen_cpuid(), giving it a lightly more
appropraite name, so it can be shared with parse_xen_cpuid().

Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply it
to dom0's policy when other tweaks are being made.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Daniel Smith <dpsmith@apertussolutions.com>

RFC, because I think we've got a preexisting error with late hwdom here.  We
really should not be cobbering a late hwdom's settings (which were provided in
the usual way by the toolstack in dom0).

Furthermore, the distinction gets more murky in a hyperlaunch future where
multiple domains may be constructed by Xen, and there is reason to expect that
a full toolstack-like configuration is made available for them.

One option might be to remove the special case from init_domain_cpuid_policy()
and instead make a call into the cpuid code from create_dom0().  It would have
to be placed between domain_create() and alloc_dom0_vcpu0() for dynamic sizing
of the FPU block to work.  Thoughts?
---
 docs/misc/xen-command-line.pandoc |  16 ++++++
 xen/arch/x86/cpuid.c              | 114 +++++++++++++++++++++++++++++++++-----
 2 files changed, 115 insertions(+), 15 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index f7797ea233f9..1278f9c27597 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -801,6 +801,22 @@ Controls for how dom0 is constructed on x86 systems.
 
     If using this option is necessary to fix an issue, please report a bug.
 
+### dom0-cpuid
+    = List of comma separated booleans
+
+    Applicability: x86
+
+This option allows for fine tuning of the facilities dom0 will use, after
+accounting for hardware capabilities and Xen settings as enumerated via CPUID.
+
+Options are accepted in positive and negative form, to enable or disable
+specific features.  All selections via this mechanism are subject to normal
+CPU Policy safety logic.
+
+This option is intended for developers to opt dom0 into non-default features,
+and is not intended for use in production circumstances.  If using this option
+is necessary to fix an issue, please report a bug.
+
 ### dom0-iommu
     = List of [ passthrough=<bool>, strict=<bool>, map-inclusive=<bool>,
                 map-reserved=<bool>, none ]
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 151944f65702..896bc1595317 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -26,17 +26,18 @@ static const uint32_t __initconst hvm_hap_def_featuremask[] =
     INIT_HVM_HAP_DEF_FEATURES;
 static const uint32_t deep_features[] = INIT_DEEP_FEATURES;
 
+static const struct feature_name {
+    const char *name;
+    unsigned int bit;
+} feature_names[] __initconstrel = INIT_FEATURE_NAMES;
+
 static int __init parse_xen_cpuid(const char *s)
 {
     const char *ss;
     int val, rc = 0;
 
     do {
-        static const struct feature {
-            const char *name;
-            unsigned int bit;
-        } features[] __initconstrel = INIT_FEATURE_NAMES;
-        const struct feature *lhs, *rhs, *mid = NULL /* GCC... */;
+        const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */;
         const char *feat;
 
         ss = strchr(s, ',');
@@ -49,8 +50,8 @@ static int __init parse_xen_cpuid(const char *s)
             feat += 3;
 
         /* (Re)initalise lhs and rhs for binary search. */
-        lhs = features;
-        rhs = features + ARRAY_SIZE(features);
+        lhs = feature_names;
+        rhs = feature_names + ARRAY_SIZE(feature_names);
 
         while ( lhs < rhs )
         {
@@ -97,6 +98,73 @@ static int __init parse_xen_cpuid(const char *s)
 }
 custom_param("cpuid", parse_xen_cpuid);
 
+static uint32_t __hwdom_initdata dom0_enable_feat[FSCAPINTS];
+static uint32_t __hwdom_initdata dom0_disable_feat[FSCAPINTS];
+
+static int __init parse_dom0_cpuid(const char *s)
+{
+    const char *ss;
+    int val, rc = 0;
+
+    do {
+        const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */;
+        const char *feat;
+
+        ss = strchr(s, ',');
+        if ( !ss )
+            ss = strchr(s, '\0');
+
+        /* Skip the 'no-' prefix for name comparisons. */
+        feat = s;
+        if ( strncmp(s, "no-", 3) == 0 )
+            feat += 3;
+
+        /* (Re)initalise lhs and rhs for binary search. */
+        lhs = feature_names;
+        rhs = feature_names + ARRAY_SIZE(feature_names);
+
+        while ( lhs < rhs )
+        {
+            int res;
+
+            mid = lhs + (rhs - lhs) / 2;
+            res = cmdline_strcmp(feat, mid->name);
+
+            if ( res < 0 )
+            {
+                rhs = mid;
+                continue;
+            }
+            if ( res > 0 )
+            {
+                lhs = mid + 1;
+                continue;
+            }
+
+            if ( (val = parse_boolean(mid->name, s, ss)) >= 0 )
+            {
+                __set_bit(mid->bit,
+                          val ? dom0_enable_feat : dom0_disable_feat);
+                mid = NULL;
+            }
+
+            break;
+        }
+
+        /*
+         * Mid being NULL means that the name and boolean were successfully
+         * identified.  Everything else is an error.
+         */
+        if ( mid )
+            rc = -EINVAL;
+
+        s = ss + 1;
+    } while ( *ss );
+
+    return rc;
+}
+custom_param("dom0-cpuid", parse_dom0_cpuid);
+
 #define EMPTY_LEAF ((struct cpuid_leaf){})
 static void zero_leaves(struct cpuid_leaf *l,
                         unsigned int first, unsigned int last)
@@ -727,17 +795,33 @@ int init_domain_cpuid_policy(struct domain *d)
     if ( !p )
         return -ENOMEM;
 
-    /* The hardware domain can't migrate.  Give it ITSC if available. */
     if ( is_hardware_domain(d) )
+    {
+        uint32_t fs[FSCAPINTS];
+        unsigned int i;
+
+        /* The hardware domain can't migrate.  Give it ITSC if available. */
         p->extd.itsc = cpu_has_itsc;
 
-    /*
-     * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0,
-     * so dom0 can turn off workarounds as appropriate.  Temporary, until the
-     * domain policy logic gains a better understanding of MSRs.
-     */
-    if ( is_hardware_domain(d) && cpu_has_arch_caps )
-        p->feat.arch_caps = true;
+        /*
+         * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to
+         * dom0, so dom0 can turn off workarounds as appropriate.  Temporary,
+         * until the domain policy logic gains a better understanding of MSRs.
+         */
+        if ( cpu_has_arch_caps )
+            p->feat.arch_caps = true;
+
+        /* Apply dom0-cpuid= command line settings. */
+        cpuid_policy_to_featureset(p, fs);
+
+        for ( i = 0; i < ARRAY_SIZE(fs); ++i )
+        {
+            fs[i] |= dom0_enable_feat[i];
+            fs[i] &= ~dom0_disable_feat[i];
+        }
+
+        cpuid_featureset_to_policy(fs, p);
+    }
 
     d->arch.cpuid = p;
 
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Tue Dec 14 21:20:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 21:20:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247101.426111 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxFDN-0007sY-PW; Tue, 14 Dec 2021 21:20:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247101.426111; Tue, 14 Dec 2021 21:20:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxFDN-0007sR-MM; Tue, 14 Dec 2021 21:20:01 +0000
Received: by outflank-mailman (input) for mailman id 247101;
 Tue, 14 Dec 2021 21:20:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iTjg=Q7=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxFDN-0007sL-1h
 for xen-devel@lists.xenproject.org; Tue, 14 Dec 2021 21:20:01 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 97e8ba15-5d23-11ec-85d3-df6b77346a89;
 Tue, 14 Dec 2021 22:19:59 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97e8ba15-5d23-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639516798;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UY5SIbLiQJhNf3IcwLAaYT3af81CnBCUSA3qSWP4dj0=;
	b=EzQFCHRvraOq6euqkQn1B+tUeoQ1uw1bo4mwk9Q+vKSF8S8PO4nMGeLKZ/WNHEDZ5eJhpq
	mjggZFTuoIKEO/OrzzxxfitzasNIFFxeDKcRyrdk7DdmUaNmMFC1unLIMtUfaK38TWwXYn
	h2orgm5VCZyrGWnjQirGszYr8438eZQal4q/1iuBvD2zWg9nOeapYD6mAyJQRKxCWoQSAd
	enz2/bCSy9StMuvCnU8bbCEhKsc+iX17V3lbzwiD4WPpGEDgVUswHFbLH8z54QbwfbJl42
	iPxl/XpXV7+3L/A3q2mlzAY6VVHUHz35mnJZ8s3Ze10jfDmKSXRCDaOkhFkkdQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639516798;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=UY5SIbLiQJhNf3IcwLAaYT3af81CnBCUSA3qSWP4dj0=;
	b=lDR2zL85oMI4BdOLKEJ1Arl/dti0X9kWdevk0BKKPLGWBqf9hwgLOpBluOuP1fE4iBCR8Y
	5fOFMFfQxW57zEAA==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>, Juergen Gross
 <jgross@suse.com>, xen-devel@lists.xenproject.org, Arnd Bergmann
 <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <20211214205626.lrnddha6bd6d6es5@possibly>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx> <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly>
Date: Tue, 14 Dec 2021 22:19:57 +0100
Message-ID: <87h7basx36.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Nishanth,

On Tue, Dec 14 2021 at 14:56, Nishanth Menon wrote:
> On 21:15-20211214, Thomas Gleixner wrote:
>> I think I managed to distangle this. Can you please give:
>> 
>>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4-part-2
>
>
> Umm.. I am not entirely sure what is going on.. but all kinds of weird
> corruption seems to occur with msi-v4-part-2 that does'nt seem to be
> present in v5.16-rc5. (I use NFS since ethernet in K3 platforms use
> inta/intr and dma that is impacted by this series).
>
> I will try and rebase your patches on v5.16-rc4 to be sure as well and
> report back later today once i get some time.
>
> [1] https://gist.github.com/nmenon/a66e022926c4c15313c45d44313d860c msi-v4-part-2
> [2] https://gist.github.com/nmenon/43085664d69ad846d596e76a06ed0656  v5.16-rc5

thanks for trying. I'll have a look again with brain awake tomorrow
morning.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Tue Dec 14 22:52:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 14 Dec 2021 22:52:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247143.426121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxGeN-0001i1-G2; Tue, 14 Dec 2021 22:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247143.426121; Tue, 14 Dec 2021 22:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxGeN-0001hu-DF; Tue, 14 Dec 2021 22:51:59 +0000
Received: by outflank-mailman (input) for mailman id 247143;
 Tue, 14 Dec 2021 22:51:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxGeM-0001hk-Iu; Tue, 14 Dec 2021 22:51:58 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxGeM-0002EI-CD; Tue, 14 Dec 2021 22:51:58 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxGeM-0004FF-2M; Tue, 14 Dec 2021 22:51:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxGeM-0002qy-1s; Tue, 14 Dec 2021 22:51:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3xIXAXENPL5WM/27ltKMFYQMyup+meI5OzOQmZYbOdc=; b=NgOrSF2UwBT5ORVOG9NJ54bdwD
	GWRajWIQDbknRkOHhDYcHs4VSU1oeddkKQHZV9xgcvdldhINBzOrlziQ9jMlNvkwoO9B3qVX5wlZ2
	jbmL+lgp6IE0V/vi7s7Bk1ndnRd/2RfmaCIfHiopdV79lr8b7GQB39pnuB/8RYCsDzxs=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167414-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167414: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=9006967c8d24f5d9585278fb6363b08f2118d424
X-Osstest-Versions-That:
    ovmf=c039fa7ff09729de07bc7ebcdd4878340bfaf252
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 14 Dec 2021 22:51:58 +0000

flight 167414 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167414/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 9006967c8d24f5d9585278fb6363b08f2118d424
baseline version:
 ovmf                 c039fa7ff09729de07bc7ebcdd4878340bfaf252

Last test of basis   167409  2021-12-14 11:40:24 Z    0 days
Testing same since   167414  2021-12-14 16:10:26 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   c039fa7ff0..9006967c8d  9006967c8d24f5d9585278fb6363b08f2118d424 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 00:44:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 00:44:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247150.426135 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxIPE-0005QZ-Ga; Wed, 15 Dec 2021 00:44:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247150.426135; Wed, 15 Dec 2021 00:44:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxIPE-0005QS-Db; Wed, 15 Dec 2021 00:44:28 +0000
Received: by outflank-mailman (input) for mailman id 247150;
 Wed, 15 Dec 2021 00:44:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxIPC-0005QI-Dj; Wed, 15 Dec 2021 00:44:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxIPC-0004io-8q; Wed, 15 Dec 2021 00:44:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxIPB-0008CA-UG; Wed, 15 Dec 2021 00:44:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxIPB-0005W3-Tk; Wed, 15 Dec 2021 00:44:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=piSYNCUHPZRvRERUBEEVDHK+S8brdImnigpFmPxWpK8=; b=Ok7mRktdslnkiWe5m38IWCU5UZ
	uLd4CNcDKvtGCxjmk0PwO1Oz2oOXa7wD4vMHpjrGAtnEJ5n2Xex+d8LLYOOWW9CpZPP+YlAC0kxLX
	nfWIMLFW7Jos6mMxrNj3ySkysy6FMxd2Ihb+3KGV1bYAMbqfM1T2HvLIAw545qZFMVtY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167413-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167413: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:regression
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7f70428f0109470aa9177d1a9e5ce02de736f480
X-Osstest-Versions-That:
    linux=e3c95128def1c937754a5cdc3d297fa47968e9f6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 00:44:25 +0000

flight 167413 linux-5.4 real [real]
flight 167420 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167413/
http://logs.test-lab.xenproject.org/osstest/logs/167420/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail REGR. vs. 167230

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 167420-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167230
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167230
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167230
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167230
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167230
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167230
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167230
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167230
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167230
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 167230
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167230
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167230
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167230
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                7f70428f0109470aa9177d1a9e5ce02de736f480
baseline version:
 linux                e3c95128def1c937754a5cdc3d297fa47968e9f6

Last test of basis   167230  2021-12-08 08:12:55 Z    6 days
Testing same since   167413  2021-12-14 14:15:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alan Young <consult.awy@gmail.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexander Sverdlin <alexander.sverdlin@nokia.com>
  Alok Prasad <palok@marvell.com>
  Alyssa Ross <hi@alyssa.is>
  Andrea Mayer <andrea.mayer@uniroma2.it>
  Andrew Morton <akpm@linux-foundation.org>
  Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
  Anton Altaparmakov <anton@tuxera.com>
  Ard Biesheuvel <ardb@kernel.org>
  Ariel Elior <aelior@marvell.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bindushree P <Bindushree.p@intel.com>
  Brian Silverman <brian.silverman@bluerivertech.com>
  Chen-Yu Tsai <wens@csie.org>
  Christian König <christian.koenig@amd.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Davidlohr Bueso <dave@stgolabs.net>
  Davidlohr Bueso <dbueso@suse.de>
  Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  Evgeny Boger <boger@wirenboard.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  freak07 <michalechner92@googlemail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurucharan G <gurucharanx.g@intel.com>
  Gwendal Grignou <gwendal@chromium.org>
  Hannes Reinecke <hare@suse.de>
  Hans de Goede <hdegoede@redhat.com>
  Herve Codina <herve.codina@bootlin.com>
  J. Bruce Fields <bfields@redhat.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jens Axboe <axboe@kernel.dk>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jeya R <jeyr@codeaurora.org>
  Jianglei Nie <niejianglei2021@163.com>
  Jianguo Wu <wujianguo@chinatelecom.cn>
  Jimmy Assarsson <extja@kvaser.com>
  Jiri Kosina <jkosina@suse.cz>
  Joakim Zhang <qiangqing.zhang@nxp.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josef Bacik <josef@toxicpanda.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kailang Yang <kailang@realtek.com>
  Karen Sornek <karen.sornek@intel.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Lars-Peter Clausen <lars@metafoo.de>
  Lee Jones <lee.jones@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lionel Landwerlin <lionel.g.landwerlin@intel.com>
  Luca Stefani <luca.stefani.ge1@gmail.com>
  Manish Chopra <manishc@marvell.com>
  Manjong Lee <mj0123.lee@samsung.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marc Zyngier <maz@kernel.org>
  Mark Brown <broonie@kernel.org>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Michal Maloszewski <michal.maloszewski@intel.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Mitch Williams <mitch.a.williams@intel.com>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Oleg Nesterov <oleg@redhat.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Patrik John <patrik.john@u-blox.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Qu Wenruo <wqu@suse.com>
  Rob Herring <robh@kernel.org>
  Shaokun Zhang <zhangshaokun@hisilicon.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <simon.horman@corigine.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stephen Boyd <sboyd@kernel.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Takashi Iwai <tiwai@suse.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tony Brelinski <tony.brelinski@intel.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vincent Mailhol <mailhol.vincent@wanadoo.fr>
  Vladimir Murzin <vladimir.murzin@arm.com>
  Wudi Wang <wangwudi@hisilicon.com>
  xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
  Yang Yingliang <yangyingliang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     fail    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 2594 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 02:45:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 02:45:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247164.426153 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKI0-0003ZX-Jm; Wed, 15 Dec 2021 02:45:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247164.426153; Wed, 15 Dec 2021 02:45:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKI0-0003ZP-Dl; Wed, 15 Dec 2021 02:45:08 +0000
Received: by outflank-mailman (input) for mailman id 247164;
 Wed, 15 Dec 2021 02:45:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+4EW=RA=epam.com=prvs=29836cc2ab=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mxKHz-0003ZE-DU
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 02:45:07 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 01326321-5d51-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 03:45:05 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BEJ1Bnw022232;
 Wed, 15 Dec 2021 02:45:00 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxur5t6nb-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 02:44:59 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7764.eurprd03.prod.outlook.com (2603:10a6:102:20a::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Wed, 15 Dec
 2021 02:44:56 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%5]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 02:44:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 01326321-5d51-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jWFEUnynb0sB9vUKZEGmrQt0cnH+MFGDTYcFIp5vtV129zSr8OJziSiTNGhMHekVJVOuGLDn//wtYVNn92NwQSjTHzC8hPjU/TCWfanyXpLxgFwVpwsD2eL00d5kXf4JObpD2cu8AbMhTQMx+spL1vz/AxsYyE4Fhj2Uif49XtqWf0knDfULVrcECykOAcQhcc3xj7ZT9gd+KO8UU8hXdUamMfLTX+MAXda20v4yy/ZYhotxhPf1lXyVtdukhD5YzpX9WrjTJYMxJdW3FSxLcTdgt8Qiz5Hvj65Du91E9nP2e0jJk8dIaxfxmJeCkgZkDm/JSYVmNhWUKZ/MWqB/eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=F3Fox1akmzzJlMnIPBkUC0DQ6SQS2WrV90ks2hEFlTE=;
 b=R+ZreJ70EUh1Bj8uPBWNRxnh0I3tu4EqSnhima5mZ9Bv5cU+oouwaXA10AQYeKRW25GHf0scwtDXrIIeaiXxQ6H6gQlVWxVgw78LY8V4CtEq4YLKHeOCFBUrGdviUiJTibOPHa4sVzbs9FY/n6X2uXO8nGmETGYcLhqFlXo3b1H5XhqRsNzQNT7LQ2JVE87bYumOxCfwsQe8JpJ7nHBeY9xoWk5Dun5/xfZzNd+XYfGdA/ITdAEvEkOO2jCmkFX1AG71EeB3cfOCtdKgkln/nTsc9VqlkHDg7lMKtugTwkeBxVoR/O1ALHbqfppVt4uG2TXwdVLDlQf/KNraKI1/lQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=F3Fox1akmzzJlMnIPBkUC0DQ6SQS2WrV90ks2hEFlTE=;
 b=qT2WUaiL/FLh6b3Bw2n3PcammBtxNw/eKmLDhDdfiIF3QZHotdPJninMLM3aKayX50jANTCMWX8cqbPl7KEAT2dqeLAnfTspPhqa1A6AI/oG0IenEMjhTQSdErYdmou5RCWVJK17nLCZiShgs9XgRBBotQNIbu6HgE21SqRI+ziuPP406jE3UG6Ur5kRiqFVHjNlWaAwK56+AZJBY6FwDfOaNdlw1AzoB136kyPUoUUfkUFM7+EPMNORMIyeyw/O2ojcnxGPrrAQy9zYWcQfeo1TBMbcFvIgr8z318BHXDDEl0dZV14/WGAOnXSmKI1qPKeMRlJIqqnuvT1o0OoFUA==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP
 to 0
Thread-Topic: [PATCH 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP
 to 0
Thread-Index: AQHX47d9QLo6g0x4ak2nHeVJbXy2O6wy86aA
Date: Wed, 15 Dec 2021 02:44:55 +0000
Message-ID: <87lf0my4cq.fsf@epam.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-9-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-9-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f97b201b-9b5b-4af2-bc60-08d9bf74e0e5
x-ms-traffictypediagnostic: PAXPR03MB7764:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB7764F2DBB1E357BE1ED4EA02E6769@PAXPR03MB7764.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 zVLai2DIW8axhOcP37kC7YLTy0AIKtkp6BFUHo848i7YUgxIuwD32Msu3/Zk0gCqgVL9dxrhUp88Ywo9iWvTI0FyZcXUfmeD3dWlh+lSxdPjRf17zmJyr4BY59UPwrb806sD3+6gB+OOcPc6RQ4f0X2srMMWb/EIMzIIguGCxn6UeeQyIZbO83uVtnua8w1UyuLiVPIl3UpFpE5VfiUnc4LenaprCkvuj4NRR9vCPKZyO+QDMGXL23t1Xnwsvg5aR6fySUyv9h7LNQfpdLwH8wkVV9SA5c6F3cRtyWxacMr+8fszn0ufzHPBZc/7NGPL3Eh43HpplItOku8wFJU1HoPqiwOFr193Gs24UHY10qQUYhz53VvKHkhe0kII0Q5ujT/tET5KelxrnoWgQGHGks5HGRTmOLrUO6Hqamcx42aZ6Z1e5JiG1QJxJnjVqSvdfGnt7euVMv3W+sc1WTMiTG/s4Fa5FTl6nY1Fa/jxK38Hl76CK6s82OvY/M442TKGetJ8XojGFUZzFqvb/QMfwN0THRjQfb1RC9gV865fMjY4ZRgOYhJwVDtntXVAG74SEjC8BswMzT+HDq3WOVK9XaMNVSXi10tqUIqUVHy5COeJTFnQvFJPn0MMA5rLbRB1U50/1fbXPFagocbaLZACea0rg6ehsGiRWkNANtQlN5YjDChx1xLIoGgQ4Xw+OLSbM2fPek7PyWROAYkI2ZksOJHIRiSPkwulEULimXKzL1e5Fxnsm54sQ6P2frw09ikV1hTs39aty1Y+oa3ovzZbj4ZcaYjKCe/7QTOHEM3B6sQ=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(2616005)(76116006)(66946007)(66476007)(6512007)(508600001)(36756003)(38100700002)(38070700005)(54906003)(122000001)(91956017)(5660300002)(6486002)(966005)(316002)(71200400001)(66556008)(2906002)(6916009)(66446008)(55236004)(26005)(64756008)(83380400001)(8936002)(8676002)(6506007)(4326008)(186003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?V0pu/8VmOcITgodxhQ29AncEFcE2vvm/O1MsCAjVEjkU2LrOKhyA9obFDg?=
 =?iso-8859-1?Q?EAYp2smAYXxJMJO6enlkqpdDvtpSHk15kwP3FaX/xIqEOD8wSM529BCTEh?=
 =?iso-8859-1?Q?DRnBu0gmA3XbOo/20GCYmdMaxKc7U4anHuMO19MxCHMnCXKAE/8e+bSMCa?=
 =?iso-8859-1?Q?KMc+0+W+9BD/pOsrTBRDf68yhW2+nTD1pQaizff2tDZWq8FCod7HPrX2ls?=
 =?iso-8859-1?Q?ihKYNJUjDiHsbo1P7+Xo+AVlMBbfkEnZuUJ9vi13t+Bd0ifOB3OqsUyLxN?=
 =?iso-8859-1?Q?7llJSOgipHfmZd2wC1M8unl8B6YWIu0p1Qp5/b4miqvIpMnrdfemsWrrsh?=
 =?iso-8859-1?Q?Jdk8GZxhVuTqc5Oxo9I8NtnErYI4gQOcnz6sFSE1ISldEFjPNYTTidNSb3?=
 =?iso-8859-1?Q?ZB1g/K5dy82e1vuqhvMJyWARVnN5yYvT/U+2yb2yqVhWTY5YRJAhwoHDDQ?=
 =?iso-8859-1?Q?UvEdvfPk8VO9eA+Hiqh5dae5ukU/8FQfLTkSUt4g/PUSmU8kgum48AhFkW?=
 =?iso-8859-1?Q?gM4Dt2qi49BQsPXpUSAgy6yJt/Q4ktQJgSAhEZRx+dU6rZL8EfKxk0z3Vh?=
 =?iso-8859-1?Q?kY5DPWAtLp7rASzdGB3vIUKRdRockIoNK3TOn3Ezb2xav2Dwff3vaxYh0N?=
 =?iso-8859-1?Q?vIGX2phmvuiniIULa1ylW1E7zLpUkeB0hHWPbCci3PhFeQ4bP01/wO2ISq?=
 =?iso-8859-1?Q?0Dwpb1liBocNdFoLx1MuHIo761OQ0szhizbb6qLgvC4+bjbF+YtUeW2xX7?=
 =?iso-8859-1?Q?FNhI80Ag48/7fYjj3LhY4WRAzEr7mx0DLHe072PdkYdcjeiKTvAFMIHJzs?=
 =?iso-8859-1?Q?UK2nML9C0xxpkrTkeAFVesGHDwG1ubHoFxBEDRwAqm3n8G7oHxk0S//eIv?=
 =?iso-8859-1?Q?p/reg/dg3enpeFhre2HJ8Vb/CGksRmRwgenryIDXDB80TLLJ/hnetZW8NT?=
 =?iso-8859-1?Q?E/AfYrz33s8D7gAaAIqSIpKMAJpUF2DXzlHYLMdds3DYS6qzag/Mw8gxL0?=
 =?iso-8859-1?Q?Z084BeZ4blAWQpq08Us2lh9irdZ+0obZ05guZtlGj54bzaVX7m1IE5h2AH?=
 =?iso-8859-1?Q?7456gISpFAo9deZz4HI6ylDoY0SZ1W9q8b9t9WlE8crofRi2Zq+e1MAqr0?=
 =?iso-8859-1?Q?CnQDjNVzz8OLxIIK0eUt55Em/oUiiQFspdr1pLExUO2y9w4GtEvGoRjZ/+?=
 =?iso-8859-1?Q?1IS8V6a+4ZBIJs9aNPtaTVeGAR6Tir8vUKQfGICMct0EflFVWSTB7bhoVg?=
 =?iso-8859-1?Q?czxtzk7v9HIG+OXMu3KZKS4BCyUeTu44krjlV9ShdKvZ40Xb/84AQA716h?=
 =?iso-8859-1?Q?MuBZOgNFX89pKgYquVro4VynYJ4hmlGQEQCN8ectdqhJI1QFunaRZSdorm?=
 =?iso-8859-1?Q?FsbZ1ILySj6toA6lefVBoqku397Ex55fbGAYV1Hwv3+kIAi4rvpICz1aFl?=
 =?iso-8859-1?Q?usUcQNjE6apjdw2JpQhdklyDSiKth3FyLcanv/oA3qUrU9OB/QUN3JXs5O?=
 =?iso-8859-1?Q?mpu85/mE9phlajZhXoujHYz5xhAOUdu5h1d01l8afBHBWUVBptb0cXBuLu?=
 =?iso-8859-1?Q?XXjLEw7rel3rqj2eHFj7P91GHrPamo1naqld5Fl2I+rFUdrbGHeMSwqPUm?=
 =?iso-8859-1?Q?i9UeBCkhqdPo+2fRmOW7OfFAoaZxDAnWQRv8RbUYZDDyrsWC2TVtzxKM0I?=
 =?iso-8859-1?Q?hnv8x8iVtju1WX4fEDqU0toL1jOTpR6srhnxfTlGzcqZxRVl6iO0FS+3FV?=
 =?iso-8859-1?Q?uqt7ZEoHiZkB20kvH/syvzlpU=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f97b201b-9b5b-4af2-bc60-08d9bf74e0e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 02:44:55.9118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ffJfAvsdFudIesnCcfH+G1vZR+8J7IHXUEludmjweO5KDapV8nXEBrjIXifBOsWNsIdn04my5gu0BbyB1zIv4jgwJyUw8YUtXAkEt8XddFw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7764
X-Proofpoint-GUID: eGoxWpieoxS4A87ApDwCr-n9fXADRz33
X-Proofpoint-ORIG-GUID: eGoxWpieoxS4A87ApDwCr-n9fXADRz33
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_01,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 impostorscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 spamscore=0 bulkscore=0 clxscore=1011 phishscore=0 malwarescore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150013


Hi Oleksandr,

Oleksandr Tyshchenko <olekstysh@gmail.com> writes:

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Based on the following commits from the Renesas BSP:
> 8fba83d97cca709a05139c38e29408e81ed4cf62
> a8d93bc07da89a7fcf4d85f34d119a030310efa5
> located at:
> https://urldefense.com/v3/__https://github.com/renesas-rcar/linux-bsp/tre=
e/v5.10.41/rcar-5.1.3.rc5__;!!GF_29dbcQIUBPA!mB3ScUYdbD0s4mYzmb1Wu61fm6lRM1=
RhcvULXNjedfRRx0XhTk4HshhraUhZ3FRwxzSFY2I$ [github[.]com]
>
> Original commit messages:
>  commit 8fba83d97cca709a05139c38e29408e81ed4cf62
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Wed Apr 28 18:54:44 2021 +0700
>
>   iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
>
>   Need to set bit IMSCTLR_USE_SECGRP to 0
>   because H/W initial value is unknown, without this
>   dma-transfer cannot be done due to address translation doesn't work.
>
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>
>  commit a8d93bc07da89a7fcf4d85f34d119a030310efa5
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Tue Sep 7 14:46:12 2021 +0700
>
>   iommu/ipmmu-vmsa: Update IMSCTLR register offset address for R-Car S4
>
>   Update IMSCTLR register offset address to align with R-Car S4 H/W UM.
>
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>
> **********
>
> It is still a question whether this really needs to be done in Xen,
> rather in firmware, but better to be on the safe side. After all,
> if firmware already takes care of clearing this bit, nothing bad
> will happen.
>
> Please note the following:
> 1. I decided to squash both commits since the first commit adds clearing
> code and only the second one makes it functional on S4. Moreover, this is
> not a direct port. So it would be better to introduce complete solution
> by a single patch.
> 2. Although patch indeed does what it claims in the subject,
> the implementation is different in comparison with original changes.
> On Linux the clearing is done at runtime in ipmmu_domain_setup_context().
> On Xen the clearing is done at boot time in ipmmu_probe().
> The IMSCTLR is not a MMU "context" register at all, so I think there is
> no point in performing the clearing each time we initialize the context,
> instead perform the clearing at once during initialization.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

> ---
>  xen/drivers/passthrough/arm/ipmmu-vmsa.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passt=
hrough/arm/ipmmu-vmsa.c
> index 8dfdae8..22dd84e 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -229,6 +229,9 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
>  #define IMUASID0(n)            (0x0308 + ((n) * 16))
>  #define IMUASID32(n)           (0x0608 + (((n) - 32) * 16))
> =20
> +#define IMSCTLR             0x0500
> +#define IMSCTLR_USE_SECGRP  (1 << 28)
> +
>  #define IMSAUXCTLR          0x0504
>  #define IMSAUXCTLR_S2PTE    (1 << 3)
> =20
> @@ -979,6 +982,10 @@ static int ipmmu_probe(struct dt_device_node *node)
>          set_bit(0, mmu->ctx);
>      }
> =20
> +    /* Do not use security group function. */
> +    reg =3D IMSCTLR + mmu->features->ctx_offset_stride_adj;
> +    ipmmu_write(mmu, reg, ipmmu_read(mmu, reg) & ~IMSCTLR_USE_SECGRP);
> +
>      spin_lock(&ipmmu_devices_lock);
>      list_add(&mmu->list, &ipmmu_devices);
>      spin_unlock(&ipmmu_devices_lock);


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 02:58:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 02:58:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247169.426164 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKV5-0005Bq-PE; Wed, 15 Dec 2021 02:58:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247169.426164; Wed, 15 Dec 2021 02:58:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKV5-0005Bj-Lc; Wed, 15 Dec 2021 02:58:39 +0000
Received: by outflank-mailman (input) for mailman id 247169;
 Wed, 15 Dec 2021 02:58:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+4EW=RA=epam.com=prvs=29836cc2ab=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mxKV4-0005Bd-5r
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 02:58:38 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e4fda1f3-5d52-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 03:58:36 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BEIor8b026032;
 Wed, 15 Dec 2021 02:58:26 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cxw3m9rf6-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 02:58:26 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB8013.eurprd03.prod.outlook.com (2603:10a6:102:21c::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 02:58:23 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%5]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 02:58:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4fda1f3-5d52-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dY0BA2R54nd1d5nhqfuZH8Ep/9C48paxKlLjsT9T/q8q1ShoioU7t9tI8HxzpvJTwmhO3J7rlJKPPOnlJgX6JRQJKKc3T97ssbJ4vlAX3uzjM/D4Z0DjGJKa4zS7NHXxfOjsr03+Tt5j4ps54kdHxQRB6bFXpjEJGxpfrsy2nbUgdz7Sobl7394pzZ8ZXiuw+C+84y1CM09gkaG5ep5LcBs1ywcQGCPei2pnwqSZ0IFa/iSzqJjvQuzydhnwXlvx8gKhOug6HHHK+RmN4JZ3NW4WxMhNYa1EPQ4OtM9YmsgQgedUavJVKsPr7YdTJNzT/4XbTgNJHORhzncPBi4LmQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sMCT9bfFXwIARly75ze9eByLQlmhSeE6onxcSwbJ6BI=;
 b=R5H68UQzownuZPQXfjvxiJPMFcP5nN3uyEue/cc/l9MKp6EIRilQkONW8yQnWJeX2376NVRYTvywcKo2/+Y7OFa3A/PjSJtSQSL2URVvLOmrgGYTliI4uW8aIwnQRZh87g3y2Ag7S/3+PlNkURe8ibIsUsYElitwT+8dzebBRqEOWoqS+qt8LAHJfQkX83LIjeGZ8+la4nH6lRgikVt3skOlK44Gj0GdeyhBwVwwR5f9/OwuHVsGVdEjDy7YFkb4OAxWetCwkqEAmu7XQK4GznagGvyG0cM3frckdK3WqOEZjYCvQnWPTgiyApY6iWzdiFHCqgZFBVPPFzT11DpK0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=sMCT9bfFXwIARly75ze9eByLQlmhSeE6onxcSwbJ6BI=;
 b=crFEFE4GmtaSd5/l7BWdChKINslrRGDLdkHL3+Iyr8PseBKmWRBKgZ4mM/jK5nyTzJpRFEF7xE+Res9mTM1s7OeWtlAJt2vWWPGc2nHv+FYsyl/uf8Q9X+Jz1h+OG2TKkqXvovHtHv2HgKvhgC95DgoVufqCxl7Q+DpnCY5eXf90fECUnU3+1wJPC7KW0muA1DQ6Bn9IxfEc7wK79LWdeyGpzLdd/TB5k9ftDd7zEifMXguaxoXbginSF7wm2L0mfL2C3dqoFNSWsEXm7jeWJ67DT8o2M+m7AeGUYqX0jIyttvzDwMnQJ8tVO271HWu7j2iasdcr4qbzi36ACb7bbQ==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
Thread-Topic: [PATCH 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
Thread-Index: AQHX47d8XeRfYSQoykqwT5zn68xBhKwy9zgA
Date: Wed, 15 Dec 2021 02:58:23 +0000
Message-ID: <87ee6ey3ox.fsf@epam.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-10-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-10-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a3de576f-9011-4043-99b0-08d9bf76c1f7
x-ms-traffictypediagnostic: PAXPR03MB8013:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB80139DBCDFD9777E5893E2C6E6769@PAXPR03MB8013.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 kTC1gLtueD82GF1Cqm61cpL/QPYzh/T7QjN146g/Mc7kgWlL21MdPfGhSW521pQLAWRxeaQL8kS4htod9LtV9XYIn3TbKSMEp6GeZH/1cChq3MCH7H03quJCV7HHhtYEcjeoNxrVsMDGM5Rb2ZDKMhzlLFX44ZdXH97Kec+dVoW0QkJyf2jwpRYQ84HDQ6qLdCKr0hXca86eNh0Cy6OMWqqgyo81XESXX2vEffd/7Jt9BVM2lsytoLnEYK6KuWrUs/W5DnTNJ7+Qsr+cWrCWu500zr9d9H7KarsGb20qsFwiP3zC77R35GultfI9JLKufBP5lXUJ/DrH1dmpZ/2HKM12xoVsNTuC6mTp/OQox80xEemcLRpnAK6wKsvCpavVr/3DKHVp/PECQm1cack1TadYPcRvK9H9OyzUCZvnIxcvdX+txfJEi6pjJts+37F6rJ69rleQc+P9G9ffX7vAIawsXz33rAOSit7EhsZSSu6w2Sxk7G7sl5Tc18dCouXL30xn09UBWh69JWwdefxWQGOGgqBAj+e1vL2wIC9Tmtu07cD8+ocA7igygl5jADcZZjwkQY4wvbBkoxlqkqrjqSw9yjjT/cnZee/6e5lz0ZJuPvd6yL2Ov6PEPpCfcgGi689TEzMoRCCmSLZbQ6IOz3nth98GXGt5VyUjsSp5IMvD53oCeT+0JGqfOaZ5bQj/6ciTQetmVlGovbN/K2Lxew==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(76116006)(2616005)(186003)(38070700005)(5660300002)(508600001)(6916009)(8676002)(66446008)(2906002)(66946007)(66556008)(64756008)(26005)(54906003)(6486002)(91956017)(66476007)(6512007)(316002)(4326008)(8936002)(55236004)(38100700002)(71200400001)(36756003)(86362001)(6506007)(122000001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?nRVVhtRCPRpngnq11YlLD50aruy7m/8qYYJz0fWgMdRAEJM2ZWonrl2Hqk?=
 =?iso-8859-1?Q?UdACX5qUeNtFzHjxq5lQYEF6oNDMq9zlCTzeBiOI7NKch/LlHNNVDWlyZj?=
 =?iso-8859-1?Q?MKPs6y+uTv6ozhlfJYP7lv9VSiEz8T7JnpUpjJCVFETLhx2fEyXTOz8pG2?=
 =?iso-8859-1?Q?JdCBfnhLC3EIho0C3MyVOik4Ju0dVD66gzOkIbpVZfrrYaA33k+dL7NtNq?=
 =?iso-8859-1?Q?rAFMXOGnFgFxxcqwo1dy9jXv13YX5NqoqUPYHEl/sSSeEEs1/GNkOB7Ni0?=
 =?iso-8859-1?Q?kKF914t4iw25dydo2ull5tLscEBuryeXIWP4nkStz9uXPIayCmqGtJzQ+U?=
 =?iso-8859-1?Q?/JvU3Fvy9xFfHYcLqm5JzADuvTmV5rmz2FLzd56i1J79ouKiNNnP2zfid7?=
 =?iso-8859-1?Q?zGW3XqC0JQ479jquWJZqSqde3bQ7PD0ky2KVlx+V0a4mgSNe30LYVeh62F?=
 =?iso-8859-1?Q?WksFxgvTp+LoFraUUGoCIGNjgJre41T2PhJ7bjk3EJAeSLFR3lBybjVxoC?=
 =?iso-8859-1?Q?nyqDyyhL6dHM5vJmuacVENmwibt6Yz0Z6bMV7237K+z1b+gOVju5CH9urY?=
 =?iso-8859-1?Q?lPR0P80DZdI/h+IBOuZTWW/CnDi+5PCzx2mOWKr/PGhDzSn1vLTjVKBv7I?=
 =?iso-8859-1?Q?RwWysYEW4qUif6MivJwRA/nhvujLitT1/R5uU55HtOeZeiJrnLIiG2HRII?=
 =?iso-8859-1?Q?tdHkmuYbidqH9Va18Xjgs9fV/zoZR25wgqym6bBLIhjlihzKOFvEg+VON/?=
 =?iso-8859-1?Q?srrgUcXyDm4Cv6e9XReShx63zuPUKFZHeRqSgcUfVvWQOrLwHyTIFXs77c?=
 =?iso-8859-1?Q?mKIAbIyFt/teNUTp6bMtbX5pjeRRJK39amfTAOdUdl8lcV9eKMgA0wp9Ol?=
 =?iso-8859-1?Q?myqRo0zFQ4p3DRq8/daby0cgqa7SERQKwTuSunJ+P27K2dJ4Z19enjbWji?=
 =?iso-8859-1?Q?5vkX0diYf8bHMm7b1pxGLkf8CRm8pKNHZrppCxENABk/zi2YQ9XMUMcemo?=
 =?iso-8859-1?Q?0+ppFE4Ih/hPoOVBGd9rCuo4TZ9omU1rGw3hxMgzi12kD9k/ZZ9ulbMEZt?=
 =?iso-8859-1?Q?/fZCagQk4auFEWWTRMojMANwVdVaw+wFAcw52PBEXee+/IhOGIBJjl8HCh?=
 =?iso-8859-1?Q?EPNjRbliEHeC56a2pQE3gKkwHoTi8Pthfv11VVQXSxtO3iHFPY39EIyX+f?=
 =?iso-8859-1?Q?gi/1QkPxfSrWvWVu+t+gtiUMHZSVUe+9s/lQqawbZfEX83tiXhcglWD818?=
 =?iso-8859-1?Q?kJDw9qBXAa1PDsPYVlZx/jFK2mmPkb/AkgWICqGA9wMZrglx8pjRiW294j?=
 =?iso-8859-1?Q?vVJFLUyGUiEPr+0pEQTBt7fQe6lA/0OlGdn11sGYoJE9L3MKXF0sCrlICo?=
 =?iso-8859-1?Q?vdpaSdRnaYsEWrtXcCtPBTNAl50ZHHcLdZKwBs50m0s2KsbRjn4NQOe7TU?=
 =?iso-8859-1?Q?Z8eVLZd++B8re14iDjlMQA19u8D7raztwpRo/u3ojM/me1nLoytKbiep/X?=
 =?iso-8859-1?Q?vtCG+h+m3hUNaAsI7wi1RdfIn/3EYusAXlp/97tr7DRXMPN+fmHfeu0buw?=
 =?iso-8859-1?Q?5J/TNsq4q+NuPReySxXFSuEm7n1IxhSfnQ63WphEMQ0TXE+8mzNLK2E5x4?=
 =?iso-8859-1?Q?mNR9swc1CIUS0LvkGdFELrBp8q4jvW4QGvw5FRW0CLItvvhb+gmTZ6SuHD?=
 =?iso-8859-1?Q?p0+qM0mjVuusgTedVzQDrP7Txm4d4xWXA223jJCJGUAbQ31dxiZaoiv+uk?=
 =?iso-8859-1?Q?sDpYWXmJSRgrSZAUUQUZb7K4A=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3de576f-9011-4043-99b0-08d9bf76c1f7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 02:58:23.0286
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KykVHevTPEmxFgGldEiKRoiVhVtyjZzAi6gSYg/QPCaxXaNiEgmugbUHBQWv6tk0d5irrQJf8arAtr5tAAj5Cb7DQixzX9BdsZWXgx/4grI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8013
X-Proofpoint-GUID: Ss77gkegRp0kJomqmhSirlCsAcjo1TrJ
X-Proofpoint-ORIG-GUID: Ss77gkegRp0kJomqmhSirlCsAcjo1TrJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_01,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0
 mlxlogscore=973 lowpriorityscore=0 spamscore=0 clxscore=1015
 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112150015


Hi Oleksandr,


Oleksandr Tyshchenko <olekstysh@gmail.com> writes:

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Reference-count the micro-TLBs as several bus masters can be
> connected to the same micro-TLB (and drop TODO comment).
> This wasn't an issue so far, since the platform devices
> (this driver deals with) get assigned/deassigned together during
> domain creation/destruction. But, in order to support PCI devices
> (which are hot-pluggable) in the near future we will need to
> take care of.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  xen/drivers/passthrough/arm/ipmmu-vmsa.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passt=
hrough/arm/ipmmu-vmsa.c
> index 22dd84e..32609f8 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -134,6 +134,7 @@ struct ipmmu_vmsa_device {
>      spinlock_t lock;    /* Protects ctx and domains[] */
>      DECLARE_BITMAP(ctx, IPMMU_CTX_MAX);
>      struct ipmmu_vmsa_domain *domains[IPMMU_CTX_MAX];
> +    unsigned int utlb_refcount[IPMMU_UTLB_MAX];
>      const struct ipmmu_features *features;
>  };
> =20
> @@ -477,13 +478,12 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_doma=
in *domain,
>          }
>      }
> =20
> -    /*
> -     * TODO: Reference-count the micro-TLB as several bus masters can be
> -     * connected to the same micro-TLB.
> -     */
> -    ipmmu_imuasid_write(mmu, utlb, 0);
> -    ipmmu_imuctr_write(mmu, utlb, imuctr |
> -                       IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMU=
EN);
> +    if ( mmu->utlb_refcount[utlb]++ =3D=3D 0 )
> +    {
> +        ipmmu_imuasid_write(mmu, utlb, 0);
> +        ipmmu_imuctr_write(mmu, utlb, imuctr |
> +                           IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR=
_MMUEN);
> +    }
> =20
>      return 0;
>  }
> @@ -494,7 +494,8 @@ static void ipmmu_utlb_disable(struct ipmmu_vmsa_doma=
in *domain,
>  {
>      struct ipmmu_vmsa_device *mmu =3D domain->mmu;
> =20
> -    ipmmu_imuctr_write(mmu, utlb, 0);

It would be great to have

+      ASSERT(mmu->utlb_refcount[utlb] > 0);

there. Just in case.

> +    if ( --mmu->utlb_refcount[utlb] =3D=3D 0 )
> +        ipmmu_imuctr_write(mmu, utlb, 0);
>  }
> =20
>  /* Domain/Context Management */


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 03:04:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 03:04:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247174.426174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKaP-0006jt-Dw; Wed, 15 Dec 2021 03:04:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247174.426174; Wed, 15 Dec 2021 03:04:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKaP-0006jm-B4; Wed, 15 Dec 2021 03:04:09 +0000
Received: by outflank-mailman (input) for mailman id 247174;
 Wed, 15 Dec 2021 03:04:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+4EW=RA=epam.com=prvs=29836cc2ab=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mxKaO-0006jg-3J
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 03:04:08 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a9e5b6d9-5d53-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 04:04:06 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BEJB0p9000732;
 Wed, 15 Dec 2021 03:04:02 GMT
Received: from eur05-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cxuyea0kw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 03:04:02 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7652.eurprd03.prod.outlook.com (2603:10a6:102:201::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 03:03:59 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%5]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 03:03:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9e5b6d9-5d53-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TioPVD1zwXOrsf1ZwAGRWrgp1IkGJZuFokuzqj+8T4RoFu6hw6tS3B0I3PtZDY25+qCvuKrdnPPG7JI//ximLfrkeD/foXnsNfJpG+iucC3UNgRU5HybZvoq215q1Kqsi2ezOVjOrkE8Degi1N909wSMuHuqYLnmMp4S/NTeRNeumiLII2P8tMA+YqTQh3HYoVPtaKdKcwXwEETkcOOLHNh15jSwCeQhia506ctQ7SnucF03kBCsJFKhEOgwh9ybokMAd2x/Ih5A2z/buR/utTvDy/joHq22Y06EyyvTjff/AsvKhOiJobAUH9h+9tG4lZRA9E2QkImQ6VXG7WWuWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PNlgJe5sHL16Fjk0h3qwhjw73UXpZVLLuyzLp/gpKrg=;
 b=GGIHJavY51dp6isyU2bM/iVRs06rLLkF47mHf14RYHXqhZFKLXRFRlPPM1kG8n86ueudRGu0l8exaWnhf/vaW8b7yqxW+JEL4CWou1kKmmHjXW3bT9PqmL3oClZcbjbXn1OT3hSxPKHO1DHBEJVpUP+m7zHjI+KdHjKhUuujVzd89C6ojLDo79NEXN6JJPPcyf1v8DOICtVJPOCy49DjGc9OqLqdKIqoxYXwC7kMy4/GwKCJNRlPrt0ScWnuetIHLRXtFn5ReEbGUbX661xO/wnbHCzNXJOVjzAvWaZTm0C7TAG3gnvfUCPY0jIzjtOLdgxX9Um9hdTH2J9zSBGD/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PNlgJe5sHL16Fjk0h3qwhjw73UXpZVLLuyzLp/gpKrg=;
 b=Y0gW2NsZcSscV6qI2UzKcL01RuAoGBJE1bM66ZljAfmuz9ie261ecffyraMlAp10O5vKTNHXQ5XbMvvdhlMGAgR90ch/6TbV+MpRT9dSASY+hUo/PnObyPixDIRketnxYWa1lyBHwB1EB8YWLEF06DygbU9uAsWHFvGcNf495QwRiAP6dvDQzBcUpuANgTHBSxsR4FZwlPQl+uuM5I4IQTI77HC0VgCG4u/s8Q8wILyp5U/cEd6oBTeYSPkO711WqTbXEoWQ7d12ox+qatH8e9GbPlfh9s4R+/xUyD4Sqhu+c6hh0qbDpmmUWiqSIASsh/g2V9eF3uESVH7fET2egg==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Yoshihiro
 Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 10/10] iommu/arm: Remove code duplication in all IOMMU
 drivers
Thread-Topic: [PATCH 10/10] iommu/arm: Remove code duplication in all IOMMU
 drivers
Thread-Index: AQHX47d9oHPrGhwq2Umum7HnvXtv26wy+BMA
Date: Wed, 15 Dec 2021 03:03:59 +0000
Message-ID: <877dc6y3fl.fsf@epam.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-11-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-11-git-send-email-olekstysh@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 12f38d79-4b0a-40bd-8d5c-08d9bf778a57
x-ms-traffictypediagnostic: PAXPR03MB7652:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB76526F59BF8F171B1B76E964E6769@PAXPR03MB7652.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4303;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 AOsUdFsTSFivp7EUBtAEE2pJsmCkLvb7aDZqVYwD10HPJ8LuwNWA4wmluSi89hHWBouxqrVW0t1Hn/+Mv7Bwg66fsDsGo1PHUGSii+Z6SRGWwqXBnDxIOrD5Bkhs03vwm2YhIwqvxXgM4kj6ZriHnle8YXw5P5IplEqH+VdUK+hqsg7x/0DXoWlKWH5V8giHFLF/r+ZV0s+YW+QjeJjAjF2wnzaUMUCrRvtstUSaey0MWnMuTQCRL/9Z5CkNf/I8eZVpPekQszvJfjTAT7FLuAYFtec76fyih0ZA6SHP2YDvOvZ9ICn6bWlYGnPgUfWATLNIG7MF7qRM4fQiJX+pWJFgVSxqLF8+lFFIyIF9E6q3nAWTCcWAlBszILa6DmxGklr+nlLzWCDKeFOEeVtwYjGOFcpng65yP9BrQVm/GG3gZseZvwH+PVHqs4ByfBq7tkRpCh+IAbxhvbasvHyNR4V2wBbHH2Afl44dNrCL3KvZ/G3Z3XbMJLm56VIJYX6UHjbh0cwt00P9c9eZ4NWPJb8cZYxiUf/wKQmULPUZobLL4bNAxOrlI7vF5CTBE+xANiEqt3dpHmLI0nytGWywWjkif68nNIuEPcLEO8z8tGlMB/ak2dqd9prvOv030ipWpHTTvW7+yPUml2QYjdJno1DMBnmBOH/ywXjyKxulAP7ZSfOB+g2p8VU7nfkkRsL1U0d1Jr2hQR0U14Omhnftww==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(91956017)(86362001)(66556008)(76116006)(66946007)(54906003)(66446008)(36756003)(8936002)(122000001)(6512007)(2616005)(38100700002)(8676002)(6916009)(508600001)(6486002)(64756008)(66476007)(71200400001)(55236004)(83380400001)(4326008)(38070700005)(5660300002)(316002)(186003)(6506007)(2906002)(26005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?d1USD5Oz3hBmovImA0BGvTC7956QNPvsJ+RLT6XX2zZSlb+1t3rkIC/QDe?=
 =?iso-8859-1?Q?Oy3th0EaVrzI/xvbtGGqiCQg5U+ysXrHiE3B5C2238eM523yN/gFUMb/tx?=
 =?iso-8859-1?Q?jQDYmS7F9sUsag23wAMLqjIHmPMOmAq2zb/jz7F9uv03kc08BdxrA/AiIb?=
 =?iso-8859-1?Q?0bDoTrpl8mGOCeIJl4ljgLqv26BfpIfVJLbIxqUsYxFyzAJ7w67C4DiTho?=
 =?iso-8859-1?Q?aVbaCSsziFl2g5sxQteKhFGJht1AmAxrLDMX53l5Xx3A21CKwTDPKLpk3K?=
 =?iso-8859-1?Q?uS3aE5uMO50vN4RA0QKWCfqga1SctceafMccH1QoRxCE1x0JlCbmEt9tfe?=
 =?iso-8859-1?Q?iX9SSpV5i78xbnSajX8OzdYo/9cvz1yx2y6hWEAvYvNGPEr0I/a1zIwq9K?=
 =?iso-8859-1?Q?tcXGB9m38TIwqV2tAjEqRtTkfJC0dqrQfqmyCe322IKnj/AfEyWdeR9rU9?=
 =?iso-8859-1?Q?HhUDjkvVQhMvMTdphlxA1Y3Zqd3G/fHw2ykFa3SAavTMP1Z8ZOUWeF2Iod?=
 =?iso-8859-1?Q?mfqDCWBmi2KR1NlvZdXwVGt5SyMeWx5XYfd+q32X69CtwgK0is05z+9GRd?=
 =?iso-8859-1?Q?e7NFUY/MX2tDZMTWSBCYtY3i1CpECgvYmWcMpNxXPpZEl2YmjZgmgdCbZ9?=
 =?iso-8859-1?Q?ffv1FB+VE2SVttHlkNu9xcm6Dm03qkrc+/Ow4xDWb94L3Q+p8jeF9pnvFE?=
 =?iso-8859-1?Q?JXunD1Q7DvP4D51t2mgpWLyReUVCyov1zsUfYg1snu5IL4Cbocqm8cNILz?=
 =?iso-8859-1?Q?w4PhW4SLKLrXHfqSTI5JX9SEY7QEcWBW8JEyiMT2KHK77wtB8pva2p+ZMv?=
 =?iso-8859-1?Q?AJk2VxWzyktOIUwTgx8b/yeAT00o1MlDGJiGEO3Rmf/yjR9x0oeglI+CJm?=
 =?iso-8859-1?Q?QLcvXJVJXtgQWbbRCGsXbLzO/cjIKfB7TQ0MidrdKOpLf9oZSCv1ann19r?=
 =?iso-8859-1?Q?m4Vn7TWnJvA6WFfS2zL8NYF/B9nwqxvtuBTbuTWmWYjNc17DR4UeD26OCy?=
 =?iso-8859-1?Q?aWJzQn3J7VXqhJyrj3yXWkh1xpgxuyAtmg+ax3M1f+Se9SmQ/dkksCanXB?=
 =?iso-8859-1?Q?nnEhnS0r3hzBoRM9ocVf8/7YeBvrKLXz18Q9qLYUzf2pQZAFU34eAzWK1B?=
 =?iso-8859-1?Q?7W1Gl6DaMyd9ti0Ris9n8jc5iLneQLnh2z661SgzTz72mvnS+XR95X/C9R?=
 =?iso-8859-1?Q?rvkmHvrqrkLB9hQrAx6danVl23gmHr/XwrcaV59l4jG3mknc2ABs09l08B?=
 =?iso-8859-1?Q?l9maxGb1Rut69tTkE8F4l93AQye7S48BRpyh0kVncXgnBvMRGYmnoNU04O?=
 =?iso-8859-1?Q?cZIjgCsY1k3/tycsyGNLVeesPgWz8yL3QYwNJ5qtcrYplRzqRP2fVXJiXm?=
 =?iso-8859-1?Q?lwAXe1Eojpdlg3OJ5z/eRbgb0m3r+HRGRKHEgMXhn5fjjC40GUUQ1n6SV1?=
 =?iso-8859-1?Q?pQRZ8TApmeXe+CwEIhJPGveHNgnl4KUrGy+/UTqyPKFwVsX50ANGX8vPYe?=
 =?iso-8859-1?Q?Fzdff9H9OuZ7+faiA2Ad6ikzixLGVVIXK9K9fUItF5UBBjoZ+hqoPAM2ol?=
 =?iso-8859-1?Q?zrhke2GAiYpZyOWYzGg10BRG069jH0XF2KtaT9j9SrDru0xd4Niv26yM9v?=
 =?iso-8859-1?Q?2jor3UrM4sjbIFeKnnfdJPmPDV8ofmfDLPGf4tDv6cGGx0DUcCmGAsYq49?=
 =?iso-8859-1?Q?rpq+7IRS3uO7wKA6D/PfTwuMcGX/QctJ0DEKpx2yd9YcRLqGZbIchP5dTh?=
 =?iso-8859-1?Q?OndcxdMEEMd0Xc127lb68R2kg=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12f38d79-4b0a-40bd-8d5c-08d9bf778a57
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 03:03:59.1706
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 196DedVcMI3oaoipZRDGHyr3iMlz06o6xgrktnJCMFpfcdDG/U3Bh0Wn0t/vewUfeU3iPYkbnCMi0ORLRC47Sjykj/jmftqrHTmV0QBb1kg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7652
X-Proofpoint-ORIG-GUID: a7YXSkelcRjvkG7JkPqbRtmsSr0A6Q6R
X-Proofpoint-GUID: a7YXSkelcRjvkG7JkPqbRtmsSr0A6Q6R
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_01,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0
 mlxlogscore=991 adultscore=0 spamscore=0 priorityscore=1501 suspectscore=0
 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112150016


Oleksandr,

Oleksandr Tyshchenko <olekstysh@gmail.com> writes:

> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> All IOMMU drivers on Arm perform almost the same generic actions in
> hwdom_init callback. Move this code to common arch_iommu_hwdom_init()
> in order to get rid of code duplication.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

> ---
>  xen/drivers/passthrough/arm/iommu.c      |  7 +++++++
>  xen/drivers/passthrough/arm/ipmmu-vmsa.c |  8 --------
>  xen/drivers/passthrough/arm/smmu-v3.c    | 10 ----------
>  xen/drivers/passthrough/arm/smmu.c       | 10 ----------
>  4 files changed, 7 insertions(+), 28 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthroug=
h/arm/iommu.c
> index ee653a9..fc45318 100644
> --- a/xen/drivers/passthrough/arm/iommu.c
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -134,6 +134,13 @@ void arch_iommu_domain_destroy(struct domain *d)
> =20
>  void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
>  {
> +    /* Set to false options not supported on ARM. */
> +    if ( iommu_hwdom_inclusive )
> +        printk(XENLOG_WARNING "map-inclusive dom0-iommu option is not su=
pported on ARM\n");
> +    iommu_hwdom_inclusive =3D false;
> +    if ( iommu_hwdom_reserved =3D=3D 1 )
> +        printk(XENLOG_WARNING "map-reserved dom0-iommu option is not sup=
ported on ARM\n");
> +    iommu_hwdom_reserved =3D 0;
>  }
> =20
>  /*
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passt=
hrough/arm/ipmmu-vmsa.c
> index 32609f8..451fc21 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -1336,14 +1336,6 @@ static int ipmmu_iommu_domain_init(struct domain *=
d)
> =20
>  static void __hwdom_init ipmmu_iommu_hwdom_init(struct domain *d)
>  {
> -    /* Set to false options not supported on ARM. */
> -    if ( iommu_hwdom_inclusive )
> -        printk(XENLOG_WARNING "ipmmu: map-inclusive dom0-iommu option is=
 not supported on ARM\n");
> -    iommu_hwdom_inclusive =3D false;
> -    if ( iommu_hwdom_reserved =3D=3D 1 )
> -        printk(XENLOG_WARNING "ipmmu: map-reserved dom0-iommu option is =
not supported on ARM\n");
> -    iommu_hwdom_reserved =3D 0;
> -
>      arch_iommu_hwdom_init(d);
>  }
> =20
> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthro=
ugh/arm/smmu-v3.c
> index d115df7..ca8b5c7 100644
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -3404,16 +3404,6 @@ static int arm_smmu_iommu_xen_domain_init(struct d=
omain *d)
> =20
>  static void __hwdom_init arm_smmu_iommu_hwdom_init(struct domain *d)
>  {
> -	/* Set to false options not supported on ARM. */
> -	if (iommu_hwdom_inclusive)
> -		printk(XENLOG_WARNING
> -		"map-inclusive dom0-iommu option is not supported on ARM\n");
> -	iommu_hwdom_inclusive =3D false;
> -	if (iommu_hwdom_reserved =3D=3D 1)
> -		printk(XENLOG_WARNING
> -		"map-reserved dom0-iommu option is not supported on ARM\n");
> -	iommu_hwdom_reserved =3D 0;
> -
>  	arch_iommu_hwdom_init(d);
>  }
> =20
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough=
/arm/smmu.c
> index c9dfc4c..ec18df7 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2851,16 +2851,6 @@ static int arm_smmu_iommu_domain_init(struct domai=
n *d)
> =20
>  static void __hwdom_init arm_smmu_iommu_hwdom_init(struct domain *d)
>  {
> -	/* Set to false options not supported on ARM. */
> -	if ( iommu_hwdom_inclusive )
> -		printk(XENLOG_WARNING
> -		"map-inclusive dom0-iommu option is not supported on ARM\n");
> -	iommu_hwdom_inclusive =3D false;
> -	if ( iommu_hwdom_reserved =3D=3D 1 )
> -		printk(XENLOG_WARNING
> -		"map-reserved dom0-iommu option is not supported on ARM\n");
> -	iommu_hwdom_reserved =3D 0;
> -
>  	arch_iommu_hwdom_init(d);
>  }


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 03:20:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 03:20:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247179.426185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKq8-0000tb-UL; Wed, 15 Dec 2021 03:20:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247179.426185; Wed, 15 Dec 2021 03:20:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxKq8-0000tU-RJ; Wed, 15 Dec 2021 03:20:24 +0000
Received: by outflank-mailman (input) for mailman id 247179;
 Wed, 15 Dec 2021 03:20:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+4EW=RA=epam.com=prvs=29836cc2ab=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mxKq7-0000t8-HU
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 03:20:23 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee37facd-5d55-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 04:20:20 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BEJ0s4R027920;
 Wed, 15 Dec 2021 03:20:14 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cxvm99wfv-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 03:20:14 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7715.eurprd03.prod.outlook.com (2603:10a6:102:207::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Wed, 15 Dec
 2021 03:20:11 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%5]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 03:20:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee37facd-5d55-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mfi9cgOuhtFzFBD3ZLMSiY7iVZUCjYkFLR8KRGYwJOGBWpccpCkCsrWIykA+PskO3nITuO9PO6agze8cpxCRPG/Zx9ZBfQhPeWNEEm3PJu4NhhZU/tixDUSP+QtyxADHp+lktDCZqebaClmpKBo4bc7J/Rr1/KcVnopzqxLE0VYVCza58h7FNSi6q8oWWrOj9GY8uaG7lh6m5rWek1Bed/beLVyDotGDHgl2KYkA4XquzYp/oObeL5+a6rPavGOywehatW4dMcFvPzqL89WRx5fLUn6Qi9zPUdCqFIhjmtfNTV3AXPwJ37kV3O+JNU39O+zg2elNvc8iWXbJRFYO+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=A3qRzOHYtX1Vxycy0gv1vnca2TPm+x3DlcCGqKQcMUs=;
 b=Rl4hnk/S2VKXeOe3/wBbVtUtEXVS6ia6TD8okKDxck9Of3j+QholZnKWCcRhrDlE1KkcEhu9AzEjqBExAwhBt2PfMU3SdhU2wzYttLq4Xg0Tn2623nTE5IjjAaCt4uep4C/OINM0KAdit7NSZKH3Wi11XA8gXUeBjuKRwMgEuBZAgmR6emTxnOMmybZzi/SUoGd9R7Rt7nEwJgRCkXlbdxWG8s8oLawBHBVlEjbbHwu13dxWLo4mLnR1NIw5UkLZRna+rhc81I8H0Rw2mnKOzHwJBRmM/BtjxRO4iMfy4N2fbyV3kllK+fmhtIDieRduVT//yQDvhWC9yNvox4KmRw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=A3qRzOHYtX1Vxycy0gv1vnca2TPm+x3DlcCGqKQcMUs=;
 b=CiOyo2QLhMsEIx4JnZvZw5m1c+3qRZPnim5NhP418sJxQLABHxaR3S7tf6VrkwWL4twyU41QkSlozPHQFzdrEQrVHIUiKePjDYSnCN2nikE3Lm7MO57C3j3obY07g9qEt9mA81AFp6lqmOOY+MtFzaRjQDbxWQZ9G2vATIu+Bp3QU4XxpX2JwYLx7AVmuG9uCwp7Dd3d3rTdnMGrE6niVHdvk1zgw3677M9cjj+ObHMFP7SoD8knA0Vo39HzJOFcmaaIQYWYdoL1i3Gno8ypxu40s3FRwAvqKqZP7rMGCriJAKmANl3xlpwChrWm+XoPWKHnaqIn2H+H5aTvyygmIQ==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag
Thread-Topic: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag
Thread-Index: AQHX4ewD6xGoUYTQl0OPrjjPmZfF+KwzAP2A
Date: Wed, 15 Dec 2021 03:20:11 +0000
Message-ID: <87zgp2wo45.fsf@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-2-andr2000@gmail.com>
In-Reply-To: <20211125110251.2877218-2-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 75e62379-f318-413b-2516-08d9bf79cddd
x-ms-traffictypediagnostic: PAXPR03MB7715:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB7715BE6B83FE7B6AD0573D15E6769@PAXPR03MB7715.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 cosjT53zWrERAopdU4Htc7ABRgk3iBNw6AtQYwxWVTASluZsmGUF200Xt9WfFbI145zY/c67ICTXXrix1HrbzN5dCBrllyN//e0nBrcG7xv9R15oexQmHW1X07RNrjL5fFMTZtIM1jvE7hGZnP775Yi6Tjj+oollvLsgmopHvRQktQh+TkQht/S516q/O36Ca9xCk9whV/33qdZAmq9S56v4VNyElBazC8RLSye6BCaSaYXgqhouNNOzNen0qiDmLZXbCQJSKfxDyWOIkVrMPzq3Gj8eoYSQnvNkv5vqjH6uv/ZGO0/pjpiU3Foy4lYA167JE4RpBvBevZzzenp2yPehP9FWghmxoFIocwx4uEm9GjuuL4iurK+1rpx7GsbAuY/K47yHMUiJZCjQ1Gu7cDcgAEcQK7p9NCUMUVeWxKFAFTY4w2cKOuWsmIJtM2Lz949CfD4Q7BGf5oiBUoR5+iYSRHDsV4CbWZj9pV0UMRSgFFYnZKGoHFBnvBFNZ1VGjdshr4QFBobCK0P/Q/It1i48vz+hvfS3bfgKHcnrHaCk/XELYEifioaHEtadlTfWGdASpI7WUqiz4GOczZvxVMVWgo6gj3y76mCd67EG3hkB4k6vwvYV61OmpdRp/71Y4OguwAEh6uFVh0zptgTkfRN9vyDvGihdhfx9F0wF+IDAIG9zT/HOH1Sn8uqwS50OsGUK/L3L726uETPCt+5V8A==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(2616005)(83380400001)(38070700005)(55236004)(186003)(26005)(66946007)(36756003)(4326008)(38100700002)(107886003)(508600001)(6506007)(122000001)(66556008)(76116006)(7416002)(5660300002)(66446008)(86362001)(2906002)(316002)(66476007)(8936002)(71200400001)(8676002)(6486002)(6916009)(64756008)(6512007)(91956017);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?24zMXKiDO7q9rItcEgvzzu08k26CD/f3t8uBPQgSW5ieAxLr72zE9I6pN6?=
 =?iso-8859-1?Q?1a8I4Y9h+kKWVfheHC9C4CC7zwqpVFGUVDkAOlpkpgprVnl97ZyAUCZgsM?=
 =?iso-8859-1?Q?8fUiKu9A18cg/GpZQm+49AeFGxZOaIiILaRRTePo6q2gM6AJXEzgFoy0MD?=
 =?iso-8859-1?Q?XopaHT1XLEU40e51Sz7vuB0KSYAfWcXhW3HxZrXNaIPDu6yPmbxRARlfxe?=
 =?iso-8859-1?Q?ea7aEvZH6moA1J/gSmHBPZ0+oOkW7JOh1yNhoQdtRINOs5Jr2zmTcvv0AA?=
 =?iso-8859-1?Q?7SKN7gePt+PNcb/TcT7IjQllV+r/+7eMIjiVhdH9wnmkp6EmYblHc4gy2H?=
 =?iso-8859-1?Q?dbGeqhdVOzUGnIGWC9NIEhR9MO3RCox3R5zsDfj1T8iGJIBNNygPVds00L?=
 =?iso-8859-1?Q?RrOfEmpQxoFJEUKx4jWMoWd+wUYMvw+VELoxPDICNS3UiNTrJPBTeTAW4A?=
 =?iso-8859-1?Q?n3F+SG6gLuzFtPih1dqOqNtSUAwPQAQL31GyKplrGb5Oqp9140gMnQBTfv?=
 =?iso-8859-1?Q?VRInYWEJLcPaCJ2dNYdAaHs6RNsdYs/gzjs6xWN6LcmLuqiBYWnatkHbyX?=
 =?iso-8859-1?Q?awJyme6M34xpyvFuVs2ShE4djsex//XAJ4m12ND46cDwiUI8YMaxQRUIcd?=
 =?iso-8859-1?Q?0y+vDdMCQh6wZnxCuRlCclt9ADzWzMV6th6QPHZJQvF8hXgcqYe4QgEAWM?=
 =?iso-8859-1?Q?pgphPfXWCFUzfnXmzP9tFfx3LU+ywTw2nlSV2U2eFiSFVynXe7hL2fY8za?=
 =?iso-8859-1?Q?I2qtVWi70AFZkQjjRVE1+/qDgOz5/TEiDedhf0OpjhkJ5kSn/9yChlnPWZ?=
 =?iso-8859-1?Q?H8DGeQ6u71J39cfRDYpyImdVVBlV16K08J7mbvgUKy7jnjwZOCxb9wyBHP?=
 =?iso-8859-1?Q?RX21qfT+3bNOn6g5iT//KMqx4YYi6apOQ/rZBCqcoc0thFSOYgbnSCmqsh?=
 =?iso-8859-1?Q?Bnay7BOswIATr+1VjbIHglNNLeXAW0WAS5FivyNnR4KMvXpeJBBsOUHf8w?=
 =?iso-8859-1?Q?B2NvH2s1D3tD8ng29PEX8VliNvutZeyNwB40YP67ciKPkPixvY/lzKeGL/?=
 =?iso-8859-1?Q?I1xP/GaN/Xl3tdOT9hOGWJVJ8WZGXEzYiF9SCSET0lHj5JnB4cCe7CrH3R?=
 =?iso-8859-1?Q?jFKK8P6gd+4sxurD6M/javih2CNIVVl4xs5REzgzMgk3L189ZU1kmuAqoR?=
 =?iso-8859-1?Q?FJc/fM4WsMkGsJYEFSiz//Q26RCRwmwZeNfnbujgJkih/KU5deFQ6eIhNc?=
 =?iso-8859-1?Q?0zZnfEoxDfg2JTHqAzBg7TcRStngcBI85vjQOKLVBXVHhSlhM/EKH+ZXEG?=
 =?iso-8859-1?Q?ogZPry/8g12xX3nDOhwUvU926k52m/dlgnyefUx2yv9X1QHu+lmv90pQ5P?=
 =?iso-8859-1?Q?dq2sVatFucGuQNa3v5J88cz+MOivzKCDNNGg3aCgPOePmjqu4iZewTE/T6?=
 =?iso-8859-1?Q?QfKjmp4T4wznAxjHPD1svtrZ/lsj4pplE8VZnOyRh8PB3WsIY9907Zn1n2?=
 =?iso-8859-1?Q?jS2hgl4TQjESuv3gkvo2d1xgY4t86ECfTex6xTsXq+Ai1Y2c4Ls9SrcJaP?=
 =?iso-8859-1?Q?OTREoYWsgra+NO2dFr8ukDjeo8DLR0PdMQpZt0xwaX2kQwo3JJH6bkTRuN?=
 =?iso-8859-1?Q?zrD+zv0S7ObWa+ZRJgrF/h6fdtm2frsO/i21ylZf8xYbRp8hOyy+0ZmTY+?=
 =?iso-8859-1?Q?mBOIej492wBWwEgdS+tN8XM7EjMpDLjDOjBm7nK/7QsMNz1a/rpTxdCKFh?=
 =?iso-8859-1?Q?GFWqlqOHlv35e/dkLuZaEqIkk=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75e62379-f318-413b-2516-08d9bf79cddd
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 03:20:11.4468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kxdONrbOIaF2L69aPRQ1CbLdpQG9x6836yIRvltsw1Esqk3UBWvBKbj4M9KrcoOT85XpmbeOmGiyF46fuZO3nCKkt2MHTi8CHo/lP8xve3M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7715
X-Proofpoint-GUID: TMTTRym1KVZJRqeZ4W8ZeOGMYh-37w-D
X-Proofpoint-ORIG-GUID: TMTTRym1KVZJRqeZ4W8ZeOGMYh-37w-D
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_01,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0
 suspectscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0
 mlxlogscore=999 clxscore=1011 malwarescore=0 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150017


Hi Oleksandr,

Sorry for jumping in amid v5, but...

Oleksandr Andrushchenko <andr2000@gmail.com> writes:

> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> There are range sets which should not be printed, so introduce a flag
> which allows marking those as such. Implement relevant logic to skip
> such entries while printing.
>
> While at it also simplify the definition of the flags by directly
> defining those without helpers.
>
> Suggested-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> ---
> Since v1:
> - update BUG_ON with new flag
> - simplify the definition of the flags
> ---
>  xen/common/rangeset.c      | 5 ++++-
>  xen/include/xen/rangeset.h | 7 ++++---
>  2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c
> index 885b6b15c229..ea27d651723b 100644
> --- a/xen/common/rangeset.c
> +++ b/xen/common/rangeset.c
> @@ -433,7 +433,7 @@ struct rangeset *rangeset_new(
>      INIT_LIST_HEAD(&r->range_list);
>      r->nr_ranges =3D -1;
> =20
> -    BUG_ON(flags & ~RANGESETF_prettyprint_hex);
> +    BUG_ON(flags & ~(RANGESETF_prettyprint_hex | RANGESETF_no_print));
>      r->flags =3D flags;
> =20
>      safe_strcpy(r->name, name ?: "(no name)");
> @@ -575,6 +575,9 @@ void rangeset_domain_printk(
> =20
>      list_for_each_entry ( r, &d->rangesets, rangeset_list )
>      {
> +        if ( r->flags & RANGESETF_no_print )
> +            continue;
> +
>          printk("    ");
>          rangeset_printk(r);
>          printk("\n");
> diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h
> index 135f33f6066f..045fcafa8368 100644
> --- a/xen/include/xen/rangeset.h
> +++ b/xen/include/xen/rangeset.h
> @@ -48,9 +48,10 @@ void rangeset_limit(
>      struct rangeset *r, unsigned int limit);
> =20
>  /* Flags for passing to rangeset_new(). */
> - /* Pretty-print range limits in hexadecimal. */
> -#define _RANGESETF_prettyprint_hex 0
> -#define RANGESETF_prettyprint_hex  (1U << _RANGESETF_prettyprint_hex)
> +/* Pretty-print range limits in hexadecimal. */
> +#define RANGESETF_prettyprint_hex   (1U << 0)

If you already touching all the flags, why not to use BIT()?

> +/* Do not print entries marked with this flag. */
> +#define RANGESETF_no_print          (1U << 1)
> =20
>  bool_t __must_check rangeset_is_empty(
>      const struct rangeset *r);


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 05:53:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 05:53:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247187.426196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNEE-0008SO-4R; Wed, 15 Dec 2021 05:53:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247187.426196; Wed, 15 Dec 2021 05:53:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNEE-0008SH-1K; Wed, 15 Dec 2021 05:53:26 +0000
Received: by outflank-mailman (input) for mailman id 247187;
 Wed, 15 Dec 2021 05:53:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxNEB-0008Rs-Nh
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 05:53:24 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e450def-5d6b-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 06:53:21 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BF5h77A032077;
 Wed, 15 Dec 2021 05:53:15 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cyab5r19c-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 05:53:15 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM9PR03MB6881.eurprd03.prod.outlook.com (2603:10a6:20b:286::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Wed, 15 Dec
 2021 05:53:13 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 05:53:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e450def-5d6b-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RuA3jzW/M/+fBqgF5gATie76DkEb+qPMFLPs0TixoMlMgi9ZXdU2Lgw/uwh3NuWrgFfXepppA8Ad2VKdsKCXssnSPOeT7qpiqlw6IkLZ392dhjzzLU4F2NQ2wOCdn8jTjm1TEuF9CXOMuMAovNixFhdngGwgVa1GZRWrWLQBHfhlXy2kvaf5fSSmoFtY6gF7O14uF1Ys+yfk/OTBbr1ZbGwUTFVoQSUAJS0wl4OD/ORGFfKlFWsC+nUw5g/uli12CcGEbPlNgUHPpT2WzGNN9HJbwTEIhGLmh9J5+G1kwKkZnhQ9unpo3Ltu/h5m0fV+v7otZOwJ/QG/o6v7YcDw6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RFr7vV8MIWoq/5YEpnsbPn1gw4dy2p5x9PZcQyqp4Xs=;
 b=DNhVlFs0Gyl9r2mGGy113q2MNqSwic5FZdHzA/wHvT4NsYsESS28Kc3DQWImIXAY1QxKuZGp4ims1tvWFlQl+9d6MgktEzBxdmzYIRy7WHor8JXWqs2eLg8xgD1untso+vmN6kc7/3VCkAw5WueJ5GiWrB927jooCgF4iXBxsZ7VeUjk3wVAPvIrwS13klhy+RJnLVo4zyxWk4y94p/00LR7B0aZtCaIuSab0ZccRyxFgZCR2OU8idZz7DcRbbhaNzcCj95m2jAc+pD63uaQtJUl03SD/zmTmqwIhXX0TstnuPJTj+QyHoGNZG68+DN/OnSPW1hfYVf7xJGBWFW96Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RFr7vV8MIWoq/5YEpnsbPn1gw4dy2p5x9PZcQyqp4Xs=;
 b=CCtzr/AmWNlIrDiVu0lcfTkuaQ0VPwRPHWk82GS33Z/hVtLNDylQyjT78hF8wOsW25Xd5rPokx17oBjHrDSDvGV68B5GrbnMJoR7N2b6dpUH6r6lWShI9wwb8DZijrYNtoR1zzCMA6Jshqhx5q8IIHMsXoTD0SZNQ+qdWJe/Lkv9R+xM1BQ95c9Y2ZYkf5seMGgJ05C5E4M+ooegf3ZYFRl+1SKiJyjrjgszdllyDkhCsbJPBu351y+86RisRtAEC4QAtCFlpVCBIkcVQnA2roSqgpeuNfq7PdH0HhTI8VF9hZ9oqjS5v1OtrQ4sFAdFC38+lV/7oBfqdFiBbAUeGA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "jbeulich@suse.com"
	<jbeulich@suse.com>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        "george.dunlap@citrix.com" <george.dunlap@citrix.com>,
        "paul@xen.org"
	<paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag
Thread-Topic: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag
Thread-Index: AQHX4ewDgOC3qPO0fU6q4Y3oEVCq8awzAX6AgAAqwAA=
Date: Wed, 15 Dec 2021 05:53:13 +0000
Message-ID: <16de6c3b-b88c-99ab-d836-9d0cf0d66b1a@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <20211125110251.2877218-2-andr2000@gmail.com> <87zgp2wo45.fsf@epam.com>
In-Reply-To: <87zgp2wo45.fsf@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0e0d565d-e520-44bf-a599-08d9bf8f2eb4
x-ms-traffictypediagnostic: AM9PR03MB6881:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM9PR03MB6881FFF813E729819AAF748AE7769@AM9PR03MB6881.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 4h+LlzBpTb9rdD6gw9w+bBPojCRl6LaqiVFVx4HGeGxHxBgAXM8tmR/u5DjnaUpztZVEcpV9+vD9R0Sbm5q2G4q6YnqioHr8A9Yp9pUicMGB/DKIznXSoSa/nGQBWKf9iLAW65DixlPUJBT7J+yPVL7wenKfA+iIFXFK4noBcrZIoveNszvHtBSsn3FSJW1wfj0uTole62to0SCebiDI9ZU5OJwbseO2DqY6llmfJtBXZexzFWgKCOupHdh3naiiijB7tleUcyv6x1kQ7LcHNvTiLvL4BSIqlzrCZMMISmv7SKPI4DuzRYRDT+8xVETS7ZXquU8/gpsNNfMLVhr/wySic93uxoMcG6/CtvCd2p1lT2A9vBrnEYdl8T6dtDnwk9aUZHlRz4ExJt4eAj1/sHmwfwKO4pno8rz45jZNH2wo8MWZk4NADi4qgEr/jCgWuhiZY8hDKfDb/qJYpAW1kSDP8TZbHsDLsty2qTzhpBNxZHrIINeJt2YNMTaOOHeoDOey+zn+pvj/AwIa+dX8vxrk23EWpCCiBxUAerzkMRliUciJ4vfXtT0ci5B6kOV25X/x+l63Bh/g3XYrxNDc+6i95uanWyrjyvBUqa0iHEHiPCKbXv7T9Osf5I+WdxTe1eYr3Bi5U1ovm0XVvKLFUV+TcXaJo2272yu+FlsIVOVLX4WogJI4DeLx7fm0jwcPzD0OY8pAgw+JQcvF66G5rfKI9mlbrVBEVnSS1w482icOXu2S4m1c9CXwb4ZNRVypVrW6UFxRZ/cWXLIui4IosGr0zaNmbAC5979yh9lLGS6qPbEOpUgVmCeiw62nY92XdKsbrN01CZ1VL7CpFYEhfA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(7416002)(6512007)(6506007)(26005)(6862004)(38100700002)(8936002)(2906002)(36756003)(83380400001)(6636002)(966005)(86362001)(55236004)(71200400001)(2616005)(4326008)(54906003)(53546011)(508600001)(66556008)(66446008)(66946007)(107886003)(122000001)(31696002)(37006003)(6486002)(66476007)(316002)(64756008)(76116006)(8676002)(5660300002)(38070700005)(186003)(91956017)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?V1JnZFN4VFFwMDIzMTRNRmVQekg4YzJRRlhNQTlQOEswdlBDb3d1ZGlhbkFK?=
 =?utf-8?B?cmVlZzdLWm5KcCs3TGx6MEsyTU5lUHFGU1EvcjdiYW04MkdEd1g5dDdSa1BV?=
 =?utf-8?B?Lzl0VGV0eCsvd2NNbk9ycVlHbUxxVjhHYUhMZ1U1R3pnd202aEVJeVcwb1Q4?=
 =?utf-8?B?TnlScUk2WDd6MUhiazJqUHhnZzREVnF2VXFxRi8vS0FxSzZqa1o2UXR0MERv?=
 =?utf-8?B?WUFSdVErdkNiVTQyNHFyV1NyY0l5ZkpoWFV5MDBPVDJXTzFEbVc0cG5aM09H?=
 =?utf-8?B?bWM5eGxBQmRoTHUrcDJrSnhvTEJtbEpHRlZxa09EbHJqcWVodXFNTE5jaEpN?=
 =?utf-8?B?R2JqZWpOS21PcHRURUVESTFPa1YrY3l1ckJoN3Q5NFdNSGx1dEo0TGIrdFl4?=
 =?utf-8?B?aUFGQjJMOFVtOFpDMTRXMEhSS21jQVBEcWNGaVpwcXlDK1dNd2ltUVRuWjJq?=
 =?utf-8?B?UHlJVXBIZlNBZmEzN3YyRnFad2ltK0tpZkVMYU54ZW5JbWoreWRMNkkydmdi?=
 =?utf-8?B?TlVqcFJ1TVlQd1NyQmx6QjN1MWU4ZERYd3FyMllNUUhCcVJMeXUvcnltTUhU?=
 =?utf-8?B?WnczNVcrRUxmQ2cxQkpuWUc1dU45eWUvcE9qM2dxcFp4SjJCbUN1ZHl5akdj?=
 =?utf-8?B?alBrNTZSRzZIb2NRTlBrMUhiM1Y1aWNETUs0RGhvVGdPZUNmZytTMitDY0ov?=
 =?utf-8?B?amJ1SVpaZlRyYlZNengwVm1VM3p6N2Rmbkcyd1JOMi91R3hCWHdFZkFRV1ZS?=
 =?utf-8?B?dVhjV1pzSEhOWVBOWXMzYU9wckpBUFBKeEY2alFROUpheFM5UUtVNjk3eFh5?=
 =?utf-8?B?T21CNTZFSjlsSmJsK2VDNFByaTl3aFFDQzl1d3VFc01SV3Q2K3ZSeXIzc1hp?=
 =?utf-8?B?bzJYckZSWEw5dWs2ZVE4MjU5eUtjNURYYlU3QmhwRVJFaitQVW5nODE2Qm45?=
 =?utf-8?B?MjhtYXpBSTNEUDdPdjNCNlZyNkd4K1ZyS0xobkF0cmdKckc1RjdPUzAyblNq?=
 =?utf-8?B?L29CTGdpQ1ZoYUwvbjd5T1ExazQwakZMTUVyZVB3WFlpNFg0UjdBbytYUWlU?=
 =?utf-8?B?Ni80TVhsMnNQRXFweUhaMTZtTzQ2anlJTGxrUmdKRy85UEVieGcrMk1GNmtn?=
 =?utf-8?B?YW9FSkVlaHdTbDh5eThmL2ZqS0RQVGFGNTZVeGdNK3RZTVpxenJBaHQxUlJn?=
 =?utf-8?B?RG9Zd2dDREdoTFlWK3B5WEJaTXNOMkdtMjFGT0twbmRxaE1wYWJYSzMrQ2w3?=
 =?utf-8?B?MWExUmRKVlROaVFGZUhNbzVnQkg5OGp0V0FBUkZUL2lHU243UWN4MHArMTRK?=
 =?utf-8?B?VzJFTVQ0czFUUGc0SEtURU1kemlzQmhKSFVqajZnN3lONFdNRCtsWWNRMTVH?=
 =?utf-8?B?blFNV2xJYXVPZE5PLzhMSEoydmtxNWE0L3hxZkJpeFhvWUZEZmcwVWpCa2g4?=
 =?utf-8?B?Z1cxMGVQUGxEYlIyR3lNU0N0WUNpMGtyRUZkOUE4ZVlvK1ppSVpFenk4bmFL?=
 =?utf-8?B?SFo5aXZ5Wk1rSGttZ1dCQ28rc0xvQWZVQ1JwQ3pubHZIKzBiRHd5RE5yWUxq?=
 =?utf-8?B?UWZBVE80bzl5TUNOYVNIZGVsWUJ3YTUvdThmcFlUbGNHdkk3dlE5c2IyZFBV?=
 =?utf-8?B?WnA1Q0FRY1NkY2xOcjZ3UzFaSFZjOExvUkJMYmlDeUdQY0t3dlp1RDIra05m?=
 =?utf-8?B?WUloN1JLbkRYc3FhTEZlbkhkTUJGb1Z0TTBQaUZrUlozOUZQdURVSEpwWENj?=
 =?utf-8?B?NXlCKzhWZWh5NHg0NzVmYmExOTU5U2RWb000UGsxS3l5ZVY5MzQyYnJWT1B2?=
 =?utf-8?B?aEhIVmNjQnVSenNPZ29BTmI1U3VzM0pDNUNyUDhtT2tVREpKWWVRdytUL1dE?=
 =?utf-8?B?NnZOVHNDTEpFVlc2dW1IUHRmaXNzV09iWHAvUDR4dUoyQ0s4MEwzQVJFMFpD?=
 =?utf-8?B?WEJVWTdmaEw4S2JiTG9FQ1F3QlJFSHMwSWVGWXRaMTB4WVRpd0U4ZUVGNXZm?=
 =?utf-8?B?VFZDdHA4b2o0ZDk1VURuLzVLWkFSSWh3SFlVTlMzb2sxaXJNTEdUcGM5RXdK?=
 =?utf-8?B?cWRBRVFGRXZwTVFCZXpCK3oyOVU4SkR3SXpaVnI2dElHTGlIenFqUTh6dldT?=
 =?utf-8?B?QXRFeThROTI2QklJSGtxZHlXcHpYZjR3dmIyR3Q1dkZ3NWlsVy9QYkt4SlBO?=
 =?utf-8?B?NGhlanNIWFM0dStwRTFld2x3dk0rR0NCVjc5UklVUHFPbExVbGZyOVBxa0Fw?=
 =?utf-8?B?dENCVW40OVRydEFYTkNYZUV1clVlaHVjSmRiZkc5akp2YktLekJZVW5zb1dG?=
 =?utf-8?B?RzJ2b2JjSGxsaEs1OVJIc29WMnBNMHJDOUgxMTNqOVBkTUlDcmdOQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <3506ED13D949BA43A1DC3526050FCF1D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e0d565d-e520-44bf-a599-08d9bf8f2eb4
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 05:53:13.3674
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: n6nlJWoSs59Es9oel6YPmEjAVSyfKPCepKY1DsBfJYCh+g7LzNIExAJdC9XrDmnd7qoQeiD3yVUzBLR8O8/XXfJyEM+f6lPrhBhZKECUq/saMNUereefmdZxI3KkX2+s
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6881
X-Proofpoint-ORIG-GUID: mes7xqtz0spX51wpGwgaMKI-0F_bVl-t
X-Proofpoint-GUID: mes7xqtz0spX51wpGwgaMKI-0F_bVl-t
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_05,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 impostorscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0
 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150034

SGksIFZvbG9keW15ciENCg0KT24gMTUuMTIuMjEgMDU6MjAsIFZvbG9keW15ciBCYWJjaHVrIHdy
b3RlOg0KPiBIaSBPbGVrc2FuZHIsDQo+DQo+IFNvcnJ5IGZvciBqdW1waW5nIGluIGFtaWQgdjUs
IGJ1dC4uLg0KPg0KPiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8YW5kcjIwMDBAZ21haWwuY29t
PiB3cml0ZXM6DQo+DQo+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRy
X2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhlcmUgYXJlIHJhbmdlIHNldHMgd2hp
Y2ggc2hvdWxkIG5vdCBiZSBwcmludGVkLCBzbyBpbnRyb2R1Y2UgYSBmbGFnDQo+PiB3aGljaCBh
bGxvd3MgbWFya2luZyB0aG9zZSBhcyBzdWNoLiBJbXBsZW1lbnQgcmVsZXZhbnQgbG9naWMgdG8g
c2tpcA0KPj4gc3VjaCBlbnRyaWVzIHdoaWxlIHByaW50aW5nLg0KPj4NCj4+IFdoaWxlIGF0IGl0
IGFsc28gc2ltcGxpZnkgdGhlIGRlZmluaXRpb24gb2YgdGhlIGZsYWdzIGJ5IGRpcmVjdGx5DQo+
PiBkZWZpbmluZyB0aG9zZSB3aXRob3V0IGhlbHBlcnMuDQo+Pg0KPj4gU3VnZ2VzdGVkLWJ5OiBK
YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu
ZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pg0K
Pj4gLS0tDQo+PiBTaW5jZSB2MToNCj4+IC0gdXBkYXRlIEJVR19PTiB3aXRoIG5ldyBmbGFnDQo+
PiAtIHNpbXBsaWZ5IHRoZSBkZWZpbml0aW9uIG9mIHRoZSBmbGFncw0KPj4gLS0tDQo+PiAgIHhl
bi9jb21tb24vcmFuZ2VzZXQuYyAgICAgIHwgNSArKysrLQ0KPj4gICB4ZW4vaW5jbHVkZS94ZW4v
cmFuZ2VzZXQuaCB8IDcgKysrKy0tLQ0KPj4gICAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9u
cygrKSwgNCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9yYW5n
ZXNldC5jIGIveGVuL2NvbW1vbi9yYW5nZXNldC5jDQo+PiBpbmRleCA4ODViNmIxNWMyMjkuLmVh
MjdkNjUxNzIzYiAxMDA2NDQNCj4+IC0tLSBhL3hlbi9jb21tb24vcmFuZ2VzZXQuYw0KPj4gKysr
IGIveGVuL2NvbW1vbi9yYW5nZXNldC5jDQo+PiBAQCAtNDMzLDcgKzQzMyw3IEBAIHN0cnVjdCBy
YW5nZXNldCAqcmFuZ2VzZXRfbmV3KA0KPj4gICAgICAgSU5JVF9MSVNUX0hFQUQoJnItPnJhbmdl
X2xpc3QpOw0KPj4gICAgICAgci0+bnJfcmFuZ2VzID0gLTE7DQo+PiAgIA0KPj4gLSAgICBCVUdf
T04oZmxhZ3MgJiB+UkFOR0VTRVRGX3ByZXR0eXByaW50X2hleCk7DQo+PiArICAgIEJVR19PTihm
bGFncyAmIH4oUkFOR0VTRVRGX3ByZXR0eXByaW50X2hleCB8IFJBTkdFU0VURl9ub19wcmludCkp
Ow0KPj4gICAgICAgci0+ZmxhZ3MgPSBmbGFnczsNCj4+ICAgDQo+PiAgICAgICBzYWZlX3N0cmNw
eShyLT5uYW1lLCBuYW1lID86ICIobm8gbmFtZSkiKTsNCj4+IEBAIC01NzUsNiArNTc1LDkgQEAg
dm9pZCByYW5nZXNldF9kb21haW5fcHJpbnRrKA0KPj4gICANCj4+ICAgICAgIGxpc3RfZm9yX2Vh
Y2hfZW50cnkgKCByLCAmZC0+cmFuZ2VzZXRzLCByYW5nZXNldF9saXN0ICkNCj4+ICAgICAgIHsN
Cj4+ICsgICAgICAgIGlmICggci0+ZmxhZ3MgJiBSQU5HRVNFVEZfbm9fcHJpbnQgKQ0KPj4gKyAg
ICAgICAgICAgIGNvbnRpbnVlOw0KPj4gKw0KPj4gICAgICAgICAgIHByaW50aygiICAgICIpOw0K
Pj4gICAgICAgICAgIHJhbmdlc2V0X3ByaW50ayhyKTsNCj4+ICAgICAgICAgICBwcmludGsoIlxu
Iik7DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL3Jhbmdlc2V0LmggYi94ZW4vaW5j
bHVkZS94ZW4vcmFuZ2VzZXQuaA0KPj4gaW5kZXggMTM1ZjMzZjYwNjZmLi4wNDVmY2FmYTgzNjgg
MTAwNjQ0DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vcmFuZ2VzZXQuaA0KPj4gKysrIGIveGVu
L2luY2x1ZGUveGVuL3Jhbmdlc2V0LmgNCj4+IEBAIC00OCw5ICs0OCwxMCBAQCB2b2lkIHJhbmdl
c2V0X2xpbWl0KA0KPj4gICAgICAgc3RydWN0IHJhbmdlc2V0ICpyLCB1bnNpZ25lZCBpbnQgbGlt
aXQpOw0KPj4gICANCj4+ICAgLyogRmxhZ3MgZm9yIHBhc3NpbmcgdG8gcmFuZ2VzZXRfbmV3KCku
ICovDQo+PiAtIC8qIFByZXR0eS1wcmludCByYW5nZSBsaW1pdHMgaW4gaGV4YWRlY2ltYWwuICov
DQo+PiAtI2RlZmluZSBfUkFOR0VTRVRGX3ByZXR0eXByaW50X2hleCAwDQo+PiAtI2RlZmluZSBS
QU5HRVNFVEZfcHJldHR5cHJpbnRfaGV4ICAoMVUgPDwgX1JBTkdFU0VURl9wcmV0dHlwcmludF9o
ZXgpDQo+PiArLyogUHJldHR5LXByaW50IHJhbmdlIGxpbWl0cyBpbiBoZXhhZGVjaW1hbC4gKi8N
Cj4+ICsjZGVmaW5lIFJBTkdFU0VURl9wcmV0dHlwcmludF9oZXggICAoMVUgPDwgMCkNCj4gSWYg
eW91IGFscmVhZHkgdG91Y2hpbmcgYWxsIHRoZSBmbGFncywgd2h5IG5vdCB0byB1c2UgQklUKCk/
DQpJdCB3YXMgZGlzY3Vzc2VkIHByZXZpb3VzbHkgWzFdIGFuZCB3ZSBkZWNpZGVkIG5vdCB0byB1
c2UgdGhlIEJJVCBtYWNybw0KDQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCj4NCj4+ICsvKiBEbyBu
b3QgcHJpbnQgZW50cmllcyBtYXJrZWQgd2l0aCB0aGlzIGZsYWcuICovDQo+PiArI2RlZmluZSBS
QU5HRVNFVEZfbm9fcHJpbnQgICAgICAgICAgKDFVIDw8IDEpDQo+PiAgIA0KPj4gICBib29sX3Qg
X19tdXN0X2NoZWNrIHJhbmdlc2V0X2lzX2VtcHR5KA0KPj4gICAgICAgY29uc3Qgc3RydWN0IHJh
bmdlc2V0ICpyKTsNCj4NClsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Byb2plY3Qv
eGVuLWRldmVsL3BhdGNoLzIwMjExMTIyMDkyODI1LjI1MDIzMDYtMS1hbmRyMjAwMEBnbWFpbC5j
b20v


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 06:08:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 06:08:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247192.426208 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNSb-0001lS-Fe; Wed, 15 Dec 2021 06:08:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247192.426208; Wed, 15 Dec 2021 06:08:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNSb-0001lL-CD; Wed, 15 Dec 2021 06:08:17 +0000
Received: by outflank-mailman (input) for mailman id 247192;
 Wed, 15 Dec 2021 06:08:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kH8z=RA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxNSa-0001lF-3d
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 06:08:16 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63aaf074-5d6d-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 07:08:15 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 41377212C3;
 Wed, 15 Dec 2021 06:08:14 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E987713A3C;
 Wed, 15 Dec 2021 06:08:13 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 1c2+N02GuWFdAwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 15 Dec 2021 06:08:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63aaf074-5d6d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639548494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=iZheiGZdbRDGgQGqifJdEGiM7JY1ovpHb9ld3InukS4=;
	b=MTdbeaXSiHoEJ1K+K8+4+4TyWstRIEK0JzT4irfodEyYnO7Dn9a+HLT979Ky9Wm2TzChlH
	aTOP8wpWhAhZr8fQ05dAW5TEGDHkZt7W/vdeIpuic87f4ASvbU4aTwiV/ttqe8tFSvknHv
	LN3Bc3rbcspgHK5GvFXfFpUy+4TvwyA=
To: Oleksandr <olekstysh@gmail.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
Date: Wed, 15 Dec 2021 07:08:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qb7QZQwWXox38xBcdN4tUNJ8YNtIT9uhO"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qb7QZQwWXox38xBcdN4tUNJ8YNtIT9uhO
Content-Type: multipart/mixed; boundary="8kEO7Kik2MyO5CD8llqOZ0OumdcO7QEVE";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
In-Reply-To: <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>

--8kEO7Kik2MyO5CD8llqOZ0OumdcO7QEVE
Content-Type: multipart/mixed;
 boundary="------------491457425DECF17EF5B5279F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------491457425DECF17EF5B5279F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 14.12.21 18:44, Oleksandr wrote:
>=20
> On 14.12.21 18:03, Anthony PERARD wrote:
>=20
> Hi Anthony
>=20
>=20
>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> This patch adds basic support for configuring and assisting virtio-di=
sk
>>> backend (emualator) which is intended to run out of Qemu and could be=

>>> run in any domain.
>>> Although the Virtio block device is quite different from traditional
>>> Xen PV block device (vbd) from the toolstack point of view:
>>> =C2=A0 - as the frontend is virtio-blk which is not a Xenbus driver, =
nothing
>>> =C2=A0=C2=A0=C2=A0 written to Xenstore are fetched by the frontend (t=
he vdev is not
>>> =C2=A0=C2=A0=C2=A0 passed to the frontend)
>>> =C2=A0 - the ring-ref/event-channel are not used for the backend<->fr=
ontend
>>> =C2=A0=C2=A0=C2=A0 communication, the proposed IPC for Virtio is IORE=
Q/DM
>>> it is still a "block device" and ought to be integrated in existing
>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>>> logic to deal with Virtio devices as well.
>> How backend are intended to be created? Is there something listening o=
n
>> xenstore?
>>
>> You mention QEMU as been the backend, do you intend to have QEMU
>> listening on xenstore to create a virtio backend? Or maybe it is on th=
e
>> command line? There is QMP as well, but it's probably a lot more
>> complicated as I think libxl needs refactoring for that.
>=20
>=20
> No, QEMU is not involved there. The backend is a standalone application=
,
> it is launched from the command line. The backend reads the Xenstore to=
 get
> the configuration and to detect when guest with the frontend is=20
> created/destroyed.

I think this should be reflected somehow in the configuration, as I
expect qemu might gain this functionality in the future.

I'm wondering whether we shouldn't split the backend from the protocol
(or specification?). Something like "protocol=3Dvirtio" (default would be=

e.g. "xen") and then you could add "backend=3Dexternal" for your use case=
?
We could later expand that to "backend=3Dqemu" or "backend=3D<script-path=
>".


Juergen

--------------491457425DECF17EF5B5279F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------491457425DECF17EF5B5279F--

--8kEO7Kik2MyO5CD8llqOZ0OumdcO7QEVE--

--qb7QZQwWXox38xBcdN4tUNJ8YNtIT9uhO
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG5hk0FAwAAAAAACgkQsN6d1ii/Ey/e
Dwf/Wxf1WOpLFs+i496DwbiXbgs4qAPgLQs8Icx7Ys3XKMPvufJ5/MI0b7h+ndkI1qT5r727CX8M
ZYdNLf8LTzTUjgoaVkI3JxtL0TYGwEqexD7dLw0XBByvQx+5vMoxUkjQJWh8ouagNEGlJRF3AWu3
D1yrInccr1GVcrZVtAH43gF4TargFdGvYg6mHLVMeI8P7lHyHzoXvjXdw7/xa/V8J4xKADSv4px1
AAdoT4aShhUQhMUR0qGX2ox77hE58f7ArbWpoy9r9Ym0moPGODHiDnulvYXS5jx7uzzOWu3RBL88
dkE1zcjUuLLqSUPKDRJqY66l1xztSwxK6j/qFQaPoA==
=CnlC
-----END PGP SIGNATURE-----

--qb7QZQwWXox38xBcdN4tUNJ8YNtIT9uhO--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 06:38:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 06:38:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247199.426218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNvV-0005No-Up; Wed, 15 Dec 2021 06:38:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247199.426218; Wed, 15 Dec 2021 06:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxNvV-0005Nh-Rs; Wed, 15 Dec 2021 06:38:09 +0000
Received: by outflank-mailman (input) for mailman id 247199;
 Wed, 15 Dec 2021 06:38:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxNvV-0005Nb-Fs
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 06:38:09 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8f8fbaac-5d71-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 07:38:07 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BF6I16h017199;
 Wed, 15 Dec 2021 06:38:03 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cxw0c29nb-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 06:38:03 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM4PR0302MB2802.eurprd03.prod.outlook.com (2603:10a6:200:93::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Wed, 15 Dec
 2021 06:38:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 06:38:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8f8fbaac-5d71-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=U/QSxlGHGKyal8hf0G+hsoMEvpWNpni0nmbGbMaq+unlRWPKbHC7qjYEoE1ki2vrSmvCF3/8ttwlD6lyeXfkROer5XvzzS7kBGnSSmrE1n171E9+jLqvw8kc8+Gw9eielzD00uaXpAgGVTKqBkdjxtiatIFZYkNMPNjOyGjgKVdguCtoiXa2K6uFdERNKYdqbkcugjpICzzNnHVy7qOoU0wjR2HXO0zhhlUKexAEWQ13QhTndfXAP/qxOqssU3p5o/dFMOk5QMnkJjn4DBGAJz+wc+V4Y5ADnWJLrMtjFb5MunZ6pUEGFhTLhbvevmNibbdiGntMlDuSEvktUxkPiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=MiWfHZtE1ejyMeD06V3TtShkkURLQ0Gcgg35aR4QIxE=;
 b=mSxFVI3UwhPQAxFEi0z08Ex8kKqBfLNOKwXhDLW4F/8la4coF7ngaxUx/R781ywujv7HQNlMUUzysbwCtVIeOWAO84Y8lrnfkYaVAFvDZesPKT/DEeBjScWP8IaxKDLUj08cBmFQESWTP2cqzD/B/fuw9nrjtjkzLS9gNxgC+x4mV13kMZJmA3kTVu/XOG4F/ZLUxoVRkBt3P4uUv30RJrusDLloWXBDkMnB81ofhKBm6fNw4L6kWA67MMFylDnmopOQ9fg7Yj7MuNglUpwcOsVeyMYI1L63gzIA3NCgn4tzhFOiDz5KW922Ty2v+74b6CinysGASzX4Wv3zCHeQVQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=MiWfHZtE1ejyMeD06V3TtShkkURLQ0Gcgg35aR4QIxE=;
 b=KJ/TgZp870XjNVNlwkkFrswvwShpAv+4ubimVJ3WWSr+5VJJBWVZFm1eLht1WQqcOsCaPvF1u2xpqHzLpaOjCWYvWw4aZkZ2F47qNVwj1+pvvo0PzU9InwPREFxAUnrw4/6UY5EY/5KpY683ebK3VxEpuKmgqPtHWZ6I/Xu5UAJacfyAUMHfE9QqB3NrQ+/EngqCE0tbN7Obwj7P3yY2dENMweJY3jEQnmUuUdUQZTtt2wt5eczdXJ0sh+5/ed+TGaLkUX56Gtm0lbtm0SxK1oJWdjsXtp8eBsrm8muk7dRCipWMwkrNp0fHbJmEl1WDypAe6Cp5TQwOed6c+2h35A==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall
	<julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
Thread-Topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3
 platform
Thread-Index: AQHX8X5NR2L2gsXoQUG7s41/KjELVw==
Date: Wed, 15 Dec 2021 06:38:00 +0000
Message-ID: <e6087283-063f-bd4b-060b-e366c30add64@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: 
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4ad59d14-423d-47b5-742e-08d9bf957042
x-ms-traffictypediagnostic: AM4PR0302MB2802:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM4PR0302MB28025762F63032FBAA492DADE7769@AM4PR0302MB2802.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 fw7uGEUsL2oF8GdyRQZkZmxw9OsPL5q7+rD47QjAxoGhlF2X48D6GLWqWT5imRNAawedUlj2z1rlunB9bGfRb9cGcj1tKpdnTcONKTTkSGOAFGr+4In4hyStjIhapsTNehW/olQaKuYDAgk4qGmv96AAExC8MxvPC/SL8ttH6CL01toApwLrKW0fFXcXN3ZXMk0Dy59H91XJvd3eFQ/Tg2GpGuBlhBOanxeVacK4IusikYml0fl0Ueidax2o3L9JcsDRwAgYKsOAwfCfoKdbSfJ3bQxhwxGeOoZzA6juPtuRQWsF82JqZbj5J1u6OUIl5dC2cHLeBQYyk1PpatsUu1iEybrxrxHeUqtyfBL7jbuuCF9FMD884f9JoWSvgU1tJkUmru6U1xarNNYQuIPiJoASqsdYfSfQNO/cUOGVqV2ikchw8kh1ljmQ/ohOhfnA6h9p9ji4x0/Lg1q5XSrYFO1nembFn/PCy6D8FJw2kS9agn5fiQEsrOsYYvnwVdoOrAqmYy1ds6HEhlhRLuYO6IfCttFgkn4ak0/l57BjE83IoT3mrAltyopYzFKiuBNoiIeLpwRwLtJihvFroFjkrJbt6zXjZBvv0lB3CchmEUbVki7LVOOPGRzFIPOMJa2TIbY0nQB65e7F9XpNVoqCJDmsm6SoeUJ9wwP9NlUZrX02nWF7V91B0MskOvCRyU/E66tuoGPaH4NKcHp1xbE4rg0iBohv3QUjMxlQ2QcDt5xCU6tL7u2krpKP0AbwKw/Z
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(76116006)(66946007)(6506007)(53546011)(186003)(508600001)(6512007)(38100700002)(36756003)(6486002)(122000001)(5660300002)(91956017)(64756008)(66556008)(66446008)(66476007)(55236004)(31696002)(86362001)(8936002)(2616005)(38070700005)(31686004)(2906002)(71200400001)(316002)(54906003)(4326008)(110136005)(8676002)(2004002)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?T21xN2J3UURQdHJGelRmMjZleUt4Qi9yR3l0UmFPV0VsWFVCRVEvR1JBYnM4?=
 =?utf-8?B?b0ora3h1RU50Vyt1WWhFaEhYVitGV3FPeDhEbS9WOGoyOW9XdzJtMXlTcmZM?=
 =?utf-8?B?ODFtTTd5djdEN0hNSi93cGlmaWNhSjdZblJoSTdOT01aZW1vdG5tdTRhV0Fa?=
 =?utf-8?B?d1R1QnNTdUQycFdCdkZkdG1oYmU3anBOQ3FVbWNmUTVMS0RhY0FtMVJiTEZm?=
 =?utf-8?B?QVA1ZzZBdGVxT0h1SzR0cUF2eVhsaWZtb3ZNcUZKSUR4am4rVUlyekhuaVdM?=
 =?utf-8?B?a0kxVUNkVlNZbmkvWUE4eUtvaTNMeVNibVc1Qkx1SnVRR3VMTkIwcldFZUU2?=
 =?utf-8?B?cjZseEw3eVhLS2RwcXdseFNidE9McDNFSUZrbzV4OHBpRzA0N0wrR1JiL1ZJ?=
 =?utf-8?B?QjRGZlBLZjkzY2xkMzlFZEYxczV0cWJBazVUWS9yeTFWb3ZHYmdoWnBDNExS?=
 =?utf-8?B?R0c1bE5rYzRLWnJGOVJVYlVIRnVUYUlEZ2tkZjZCSktqa2Y2V21IUEZBcXo4?=
 =?utf-8?B?NmN4NVZ5S3ZTN1R5VFlBeUxlN3pIOGYyR1ZGL2Nwc3Y0cGViNEw3cy9lZFA1?=
 =?utf-8?B?L0EzVE8rK1V1dkFob29RaThiZEJMcUdyTlZ0Q0ZIcUZIMDMyY3pmV1lZdGdw?=
 =?utf-8?B?TXpRL05hbmZkcjEybEpwUmk0WDBINkM1aC92NUpybnhhWk5aMlJydE1maVhy?=
 =?utf-8?B?TTJEUXVjYTRVYVorT25ZUHFYY1FNOFFvTytvSDhvS2ZJb2c1Y1g3QURyTlor?=
 =?utf-8?B?QVJ2L3FsMnM1SEhGcUpZdW0wYUdDRVRkUW5zZTRXLzg2blhXWU5EdS84MDRh?=
 =?utf-8?B?UzI0TnBhY05qb20yS0xMUUVHTTFleVlvaHcwY1FXZlNSa3QyWE1nclV4VG5K?=
 =?utf-8?B?ZVpROFlrbGRJV3JOVmJlOGpuaTUrMVJFcWZ5QytiaVdwcU1lL0ZkM3p4RlFO?=
 =?utf-8?B?dml1NDFrMUovQ2NvaEIvNm9oeEVla3VXQy9ZZWd0b2RJS05JVDhPZjkzbFNq?=
 =?utf-8?B?cHVoUmNCdi9PR0doL3FLV25pZVBhTnYvVWZJUmo2Rm1UVmNmNkowRHFFano5?=
 =?utf-8?B?eTRLbFhLbVEyUVZHUzBlT2U2ejR6QVFoWi9DOFhxU0VIWFJOaUpzeEN2Mkhx?=
 =?utf-8?B?eG55TDAxdkZtdjVRWEZqRzVHZ2haanNYbHhDZVV3QkhYSHBEL04xTTF1dWo4?=
 =?utf-8?B?blRuaWk5SVBRMXBDUDJSbkFoS2lCUCtLTlZtVldYNStqUW94dzFwSVRma05t?=
 =?utf-8?B?Z08rUG0vcy8wUnRKb1BPQVI4Z2tMbFE0a1VHdmJKdWZFUlVJQUphU3pJVG9P?=
 =?utf-8?B?OWFMVXBUQm1uOHBuU0Y4dVZkYzllZUIxMHMzTllFWFZVWFpYdVV1Unc0SmpM?=
 =?utf-8?B?eW0xT3RzQ09OWUo0UXdYa1BRMkhCQWJGbkhNemxacUpIai9seU9HR05Vbkov?=
 =?utf-8?B?Q2JncjhBejIrd3IwR2k3cSswRWtGeCsyclg4NjZ0SzNiYSt6cU1vaGJsaC9m?=
 =?utf-8?B?VjlxOVJkNnBlUmN5WldmTEpxT2k4ODB1YmdjTnJUQUdhbjJQMi9kY0N5dlli?=
 =?utf-8?B?UTNFaWJKTlBqWUV1TjRNWnJLWnRVeFMyS0l3eFFPR0I4TE9mVktUTTI0TzVK?=
 =?utf-8?B?RnRlVTJPSXcwa0hKTXpGU29wYnp1ZmNjaDJBbmRWekVOSWFZRXhCQWtra1pa?=
 =?utf-8?B?aUdLTXlrZEtpbUhmTzhjRkgvZGdWOVQvRG52Nk0xUGlNclNNR0ZwdklpZUJZ?=
 =?utf-8?B?SXliQndkZnZwRlVKbDRKZXUwdWFZb2pLb0dPcFUvUXY4TzY4c1ptcFpKUitT?=
 =?utf-8?B?bjZqOUZnQ0VmSzE3NEx3MHVYTVREQnZVSmQ2NzFJWnZsNGpaaUx6N1NndWw2?=
 =?utf-8?B?alJTaStpVHpCdHFpVHQ1cVduZm9kZVFhcDlmMVN5SlZnMmoxZE9WRHUySVlu?=
 =?utf-8?B?U21VSks1MU8xaXl2MndGVUJYeXBHMW9wUGYyeEQ1ZlgvNE9pcG41R1A1Zy96?=
 =?utf-8?B?a0N3SnVqbmNya3BDL3AvWDNvdXZEUlBvY3V0WnYxNkVobldvdU1aZnZyWjJM?=
 =?utf-8?B?UlVSZzh4b0xZZmZURkl0aWRZWUFDOHhxRDdRQTEwMTRhWVd4ZTJKZUtxZy9U?=
 =?utf-8?B?bDUycjh5WHp6LzczN280YmNKbGFnak1qcElVR29DcVVmdEpuNzIvQ3ptbGxs?=
 =?utf-8?B?dWRnb3prUjhhMHErak5ybkZTR2FwKzdBVDJranZPdWpvTGxic3RGMGlCV0Uz?=
 =?utf-8?B?T052cnlWZDdWdmRScW1kVjRsbjhEZ3ZkSXBjcWxXZFFuMm1pLyt1dXN4eTJ3?=
 =?utf-8?B?NkY4bVMyek56Q2Uwek0yaFNMRXZ4eXk1TVF1c2o5MDNBdTNWY2lKQT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <72B08F9136D93146BDB0281A758BF3E0@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ad59d14-423d-47b5-742e-08d9bf957042
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 06:38:00.3759
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JisOqeuehTc/xUkIlhLEh4BMGMjBDaL8/0L0rCmDq/V6LTZWzInN+lZuUfsVo72vy1nA+s4oDtLBEkqWn4Sgq82LwclbRj4SA61MnzgVkTEV0Nb8vCsC1g7XrLpCa7mM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2802
X-Proofpoint-ORIG-GUID: xeX2fKJcyCKY90ZtGj3m8zYWQQTabQbN
X-Proofpoint-GUID: xeX2fKJcyCKY90ZtGj3m8zYWQQTabQbN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_06,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 impostorscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0
 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150036

SGksIE9sZWtzaWkhDQoNCk9uIDE0LjEyLjIxIDExOjM0LCBPbGVrc2lpIE1vaXNpZWlldiB3cm90
ZToNCj4gSW1wbGVtZW50YXRpb24gaW5jbHVkZXMgcGxhdGZvcm0tc3BlY2lmaWMgc21jIGhhbmRs
ZXIgZm9yIHJjYXIzIHBsYXRmb3JtLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2lpIE1vaXNp
ZWlldiA8b2xla3NpaV9tb2lzaWVpZXZAZXBhbS5jb20+DQpSZXZpZXdlZC1ieTogT2xla3NhbmRy
IEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KDQo+IC0t
LQ0KPiAgIHhlbi9hcmNoL2FybS9wbGF0Zm9ybXMvTWFrZWZpbGUgfCAgMSArDQo+ICAgeGVuL2Fy
Y2gvYXJtL3BsYXRmb3Jtcy9yY2FyMy5jICB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKw0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKQ0KPiAgIGNyZWF0
ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC9hcm0vcGxhdGZvcm1zL3JjYXIzLmMNCj4NCj4gZGlmZiAt
LWdpdCBhL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMvTWFrZWZpbGUgYi94ZW4vYXJjaC9hcm0vcGxh
dGZvcm1zL01ha2VmaWxlDQo+IGluZGV4IDg2MzJmNDExNWYuLmI2NGMyNWRlNmMgMTAwNjQ0DQo+
IC0tLSBhL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMvTWFrZWZpbGUNCj4gKysrIGIveGVuL2FyY2gv
YXJtL3BsYXRmb3Jtcy9NYWtlZmlsZQ0KPiBAQCAtNCw2ICs0LDcgQEAgb2JqLSQoQ09ORklHX0FM
TDMyX1BMQVQpICs9IGV4eW5vczUubw0KPiAgIG9iai0kKENPTkZJR19BTEwzMl9QTEFUKSArPSBt
aWR3YXkubw0KPiAgIG9iai0kKENPTkZJR19BTEwzMl9QTEFUKSArPSBvbWFwNS5vDQo+ICAgb2Jq
LSQoQ09ORklHX0FMTDMyX1BMQVQpICs9IHJjYXIyLm8NCj4gK29iai0kKENPTkZJR19SQ0FSMykg
Kz0gcmNhcjMubw0KPiAgIG9iai0kKENPTkZJR19BTEw2NF9QTEFUKSArPSBzZWF0dGxlLm8NCj4g
ICBvYmotJChDT05GSUdfQUxMX1BMQVQpICAgKz0gc3VueGkubw0KPiAgIG9iai0kKENPTkZJR19B
TEw2NF9QTEFUKSArPSB0aHVuZGVyeC5vDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vcGxh
dGZvcm1zL3JjYXIzLmMgYi94ZW4vYXJjaC9hcm0vcGxhdGZvcm1zL3JjYXIzLmMNCj4gbmV3IGZp
bGUgbW9kZSAxMDA2NDQNCj4gaW5kZXggMDAwMDAwMDAwMC4uZDc0MDE0NWM3MQ0KPiAtLS0gL2Rl
di9udWxsDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9wbGF0Zm9ybXMvcmNhcjMuYw0KPiBAQCAtMCww
ICsxLDQ2IEBADQo+ICsvKg0KPiArICogeGVuL2FyY2gvYXJtL3BsYXRmb3Jtcy9yY2FyMy5jDQo+
ICsgKg0KPiArICogUmVuZXNhcyBSLUNhciBHZW4zIHNwZWNpZmljIHNldHRpbmdzDQo+ICsgKg0K
PiArICogT2xla3NpaSBNb2lzaWVpZXYgPG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KPiAr
ICogQ29weXJpZ2h0IChDKSAyMDIxIEVQQU0gU3lzdGVtcw0KPiArICoNCj4gKyAqIFRoaXMgcHJv
Z3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9k
aWZ5DQo+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBM
aWNlbnNlIGFzIHB1Ymxpc2hlZCBieQ0KPiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv
bjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3INCj4gKyAqIChhdCB5b3VyIG9w
dGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ICsgKg0KPiArICogVGhpcyBwcm9ncmFtIGlzIGRp
c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsDQo+ICsgKiBidXQg
V0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBv
Zg0KPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQ
T1NFLiAgU2VlIHRoZQ0KPiArICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUg
ZGV0YWlscy4NCj4gKyAqLw0KPiArDQo+ICsjaW5jbHVkZSA8YXNtL3BsYXRmb3JtLmg+DQo+ICsN
Cj4gK3N0YXRpYyBib29sIHJjYXIzX3NtYyhzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykNCj4g
K3sNCj4gKyAgICByZXR1cm4gZmFsc2U7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBjb25zdCBjaGFy
ICpjb25zdCByY2FyM19kdF9jb21wYXRbXSBfX2luaXRjb25zdCA9DQo+ICt7DQo+ICsgICAgInJl
bmVzYXMscjhhNzc5NSIsDQo+ICsgICAgInJlbmVzYXMscjhhNzc5NiIsDQo+ICsgICAgTlVMTA0K
PiArfTsNCj4gKw0KPiArUExBVEZPUk1fU1RBUlQocmNhcjMsICJSZW5lc2FzIFItQ2FyIEdlbjMi
KQ0KPiArICAgIC5jb21wYXRpYmxlID0gcmNhcjNfZHRfY29tcGF0LA0KPiArICAgIC5zbWMgPSBy
Y2FyM19zbWMNCj4gK1BMQVRGT1JNX0VORA0KPiArDQo+ICsvKg0KPiArICogTG9jYWwgdmFyaWFi
bGVzOg0KPiArICogbW9kZTogQw0KPiArICogYy1maWxlLXN0eWxlOiAiQlNEIg0KPiArICogYy1i
YXNpYy1vZmZzZXQ6IDQNCj4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5pbA0KPiArICogRW5kOg0K
PiArICovDQo=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 07:03:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 07:03:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247205.426229 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxOJw-0000UJ-UX; Wed, 15 Dec 2021 07:03:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247205.426229; Wed, 15 Dec 2021 07:03:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxOJw-0000UC-Re; Wed, 15 Dec 2021 07:03:24 +0000
Received: by outflank-mailman (input) for mailman id 247205;
 Wed, 15 Dec 2021 07:03:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kH8z=RA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxOJv-0000U6-P8
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 07:03:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16114ba3-5d75-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 08:03:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 2B30921129;
 Wed, 15 Dec 2021 07:03:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D56BA139CF;
 Wed, 15 Dec 2021 07:03:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id TqfRMjeTuWH7FAAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 15 Dec 2021 07:03:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16114ba3-5d75-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639551800; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=I7tE/WmrRh0tbRmNof3iBkuV11rlx3fWL5o4e1WDJgs=;
	b=VC55i5QvB0u29JISehTJplAjl9n4hkjRPXJAaV+gy2C2A/ZyPeHOyvsiDmzcrhKYOIwLt0
	8jyt/mOVCz/2i8LgVL1qm3D8/VLp/lhMBdKQMx5v8flkkISGeVfM/s7ZriXojqfi/L803s
	Z1KnhNW7Lec5FImWJMyXAUPlIc6BErY=
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Message-ID: <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
Date: Wed, 15 Dec 2021 08:03:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="z0rgR56fMnYEIWcmJLqhGk2F8AM62QRz0"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--z0rgR56fMnYEIWcmJLqhGk2F8AM62QRz0
Content-Type: multipart/mixed; boundary="hvUyHbuLxdlKobNpd8FF7ecSSyGfHZhDG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
Message-ID: <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
In-Reply-To: <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>

--hvUyHbuLxdlKobNpd8FF7ecSSyGfHZhDG
Content-Type: multipart/mixed;
 boundary="------------89277A122A0C5C84F18DC9C3"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------89277A122A0C5C84F18DC9C3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 14.12.21 18:36, Julien Grall wrote:
> Hi,
>=20
> On 08/12/2021 15:55, Juergen Gross wrote:
>> Today most hypercall handlers have a return type of long, while the
>> compat ones return an int. There are a few exceptions from that rule,
>> however.
>=20
> So on Arm64, I don't think you can make use of the full 64-bit because =
a=20
> 32-bit domain would not be able to see the top 32-bit.
>=20
> In fact, this could potentially cause us some trouble (see [1]) in Xen.=

> So it feels like the hypercalls should always return a 32-bit signed=20
> value on Arm.

This would break hypercalls like XENMEM_maximum_ram_page which are able
to return larger values, right?

> The other advantage is it would be clear that the top 32-bit are not=20
> usuable. Stefano, what do you think?

Wouldn't it make more sense to check the return value to be a sign
extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?

The question is what to return if this is not the case. -EDOM?

>=20
>>
>> Get rid of the exceptions by letting compat handlers always return int=

>> and others always return long.
>>
>> For the compat hvm case use eax instead of rax for the stored result a=
s
>> it should have been from the beginning.
>>
>> Additionally move some prototypes to include/asm-x86/hypercall.h
>> as they are x86 specific. Move the do_physdev_op() prototype from both=

>> architecture dependant headers to the common one. Move the
>> compat_platform_op() prototype to the common header.
>>
>> Switch some non style compliant types (u32, s32, s64) to style complia=
nt
>> ones.
>=20
> TBH, I think this should have been split because the modifications are =

> done on lines that are untouched.
>=20
> The extra patch would have made the review easier (even if this patch i=
s=20
> still quite small).

I can split the patch if you want.


Juergen

--------------89277A122A0C5C84F18DC9C3
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------89277A122A0C5C84F18DC9C3--

--hvUyHbuLxdlKobNpd8FF7ecSSyGfHZhDG--

--z0rgR56fMnYEIWcmJLqhGk2F8AM62QRz0
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG5kzcFAwAAAAAACgkQsN6d1ii/Ey/I
/Af+KZoKfwOcntX3GBMl0kbhVtOoNsqtNfxCpbWt8sa/i0cBK7f3+2xtDGe3f8qwGGb9hVM33bi8
v+vaQYbiwcLqkFStakE0SGU/lhYreh3TLrdOCZ2CBEnhmodMBHoZ9fy7BUh/iSb3OyFW1FX5RfaJ
T9SuP1QTqefN2lJSQeDof6FVzAuO6km4vVYDE2uT9zfEpi16T9TPKQF8fzGD9rmFE+7JQfZKdUgE
gE8XL0ge3JL3OsZYCL7xTDssPiBkDnbUcVy/mKKXmQ4svxyxUJnrvEipkPH4HWEVhv3bnpSSr7bW
KhjrLafCPzSWBALyHJjHJc1M8vrxA1/cGEXicYiKaQ==
=9V5H
-----END PGP SIGNATURE-----

--z0rgR56fMnYEIWcmJLqhGk2F8AM62QRz0--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 07:12:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 07:12:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247210.426241 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxOSJ-00024V-Q7; Wed, 15 Dec 2021 07:12:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247210.426241; Wed, 15 Dec 2021 07:12:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxOSJ-00024O-Ml; Wed, 15 Dec 2021 07:12:03 +0000
Received: by outflank-mailman (input) for mailman id 247210;
 Wed, 15 Dec 2021 07:12:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kH8z=RA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxOSI-00024I-HU
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 07:12:02 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4c92cb22-5d76-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 08:12:01 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3463221129;
 Wed, 15 Dec 2021 07:12:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E247213A9F;
 Wed, 15 Dec 2021 07:12:00 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iXrKNUCVuWG3FwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 15 Dec 2021 07:12:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4c92cb22-5d76-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639552321; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=15My+PJ6ro/29XJ7JPxPnTvWs3MugXPrknbtyof5fn4=;
	b=dry/vHdEj3t68n8iZ68fSXnK9DsHmPiVSmekUGEyxwq6py1dAfd7kdyhxXFmfA3LtwVq/H
	MhAYC89nQw7Ht03U1s1FLULkeeBs8LuBBLa5ZGJLOKW6LLcsS3n5DQ9jTspaF2V3vpqEpV
	j4T2RCH66gcEW4S7WhoH8k7uE5XTUvY=
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-2-jgross@suse.com>
 <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code
Message-ID: <3af8127b-36b6-b810-3060-313736ce1735@suse.com>
Date: Wed, 15 Dec 2021 08:12:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="x7SYBZboS7A9pr6GNVHuw3RrSTI1pXgp7"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--x7SYBZboS7A9pr6GNVHuw3RrSTI1pXgp7
Content-Type: multipart/mixed; boundary="uXBEoWnl3ybfSedL27BmyzCDvnqce1jZC";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Message-ID: <3af8127b-36b6-b810-3060-313736ce1735@suse.com>
Subject: Re: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-2-jgross@suse.com>
 <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>
In-Reply-To: <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>

--uXBEoWnl3ybfSedL27BmyzCDvnqce1jZC
Content-Type: multipart/mixed;
 boundary="------------69BD973EF22395FF7CC7512D"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------69BD973EF22395FF7CC7512D
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 14.12.21 18:21, Julien Grall wrote:
> Hi Juergen,
>=20
> On 08/12/2021 15:55, Juergen Gross wrote:
>> Today Arm is using another entry point for the vcpu_op hypercall as
>=20
> NIT: The 'as' doesn't sound right here. Did you mean 'compare to'?

Hmm, it should even be "different" instead of "another". And then it
should be:

   The entry point used for the vcpu_op hypercall on Arm is different
   from the one on x86 today.

>=20
>> x86, as some of the common sub-ops are not supported on Arm. The Arm
>> specific handler filetrs out the not supported sub-ops and then calls
>=20
> Typo: s/filetrs/filters/

Yes.

>=20
>> the common handler. This leads to the weird call hierarchy:
>>
>> =C2=A0=C2=A0 do_arm_vcpu_op()
>> =C2=A0=C2=A0=C2=A0=C2=A0 do_vcpu_op()
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arch_do_vcpu_op()
>>
>> Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
>> arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
>> of above calls can be avoided without restricting any potential
>> future use of common sub-ops for Arm.
>>
>> Additionally the single user of HYPERCALL_ARM() can be modified and
>> HYPERCALL_ARM() can be removed.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>=20
> Reviewed-by: Julien Grall <jgrall@amazon.com>

Thanks,


Juergen


--------------69BD973EF22395FF7CC7512D
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------69BD973EF22395FF7CC7512D--

--uXBEoWnl3ybfSedL27BmyzCDvnqce1jZC--

--x7SYBZboS7A9pr6GNVHuw3RrSTI1pXgp7
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG5lUAFAwAAAAAACgkQsN6d1ii/Ey9V
+QgAhiJ94tekZvvRqy6hOczHq+mECr6FJQwlBC6dsLWy4OeklwkCRpO3R3/tuuCMdNxjIhrvF3yU
MGT0dk2S09pMIRvq+cP/Vxi2b8lcypZLpVTPYPhfJX62/2anmAuuf828xGqz3n/fpb++hY66lpKv
Up058u7K+/FAs+PzhNScVcKuCwALJS7aQuOi6easQSe/Y6z909m5DEG4DEyMjWKWWdOs6BwZXEsJ
5BBK3HAZ0kqAgUjDeXolEI6EJky1jtw2KnuyVUll9VepCbTxPjqwCdu3TkuTVUFwsmT81G4NXYOM
KBetwy2jmhHelw8Zyh91nkEbFp9P6/nzKt0uX6loGg==
=S6Ms
-----END PGP SIGNATURE-----

--x7SYBZboS7A9pr6GNVHuw3RrSTI1pXgp7--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 07:50:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 07:50:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247217.426251 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxP35-0006GV-Tm; Wed, 15 Dec 2021 07:50:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247217.426251; Wed, 15 Dec 2021 07:50:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxP35-0006Fs-Qk; Wed, 15 Dec 2021 07:50:03 +0000
Received: by outflank-mailman (input) for mailman id 247217;
 Wed, 15 Dec 2021 07:50:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=E5lv=RA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxP34-0005zZ-60
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 07:50:02 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9aefe46b-5d7b-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 08:50:00 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-lJQ-T_2TN7iyBUeepkw3Jw-1; Wed, 15 Dec 2021 08:49:59 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 07:49:57 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 07:49:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9aefe46b-5d7b-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639554600;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=6hjPK7PHXBANagm/R9dQprIb3qUp/MtlmAJs19zyROc=;
	b=Yz/Ly5qV6nWF7z11RvAzcLrlWz5xaUABdqGnnOp8gZ319NJfBuRCPp2hE2wij6sT1j0YBm
	bToc/T5AY8RUFBO2aR19wBJ/vAtewCkQrDu/HeIyKTnljluzZQcXssiBt/Fj2Kl0+nymrK
	l0UVibQ+iX7IqErz8WxpRM9WWGPYB0U=
X-MC-Unique: lJQ-T_2TN7iyBUeepkw3Jw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DIV+psMwmzz/RMeG4PvXL8z8zzdIBp7Qzy4JEZBiog6sHp/EswkppcmAMCU5qKZfDr5aHd+n3pm6bvrVGmO3sf1WwoOKo7DUA8vS/zWwuangscXEAYZYNBJKdoLxTCvlHTsoXwJbzyHDN5dsNMkNHCnYjV+PBUUlSDMbB7jB2vHQzMHRVU+ZKqfa7snf+mad9OFOgMU8xUYqsWETuQY7Xk96Uu5E9KiDBMvDFx+Phmk77C1Ltqx3KFbvK7QqT0r5Snk+ngJy+IK6zBKg02fojNwlXO/myoQDxdwSndv2iSX7nrZN0RsspM/Wf6X+iv05SkoKv9qQ/I+Sabz2Syk6mw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6hjPK7PHXBANagm/R9dQprIb3qUp/MtlmAJs19zyROc=;
 b=UjhSIgq2TiWu9ypt07AkdVx4X1Zol8b+k4PEkyPRc12zntC8wGZwwl0ragEV5NKMbUE+iLT5+/wlrbmqEofGJX2+RCWW+kfP2Ap8UwTlo4BBDeLHUIyV2rhNZn4XwXfMJZWz3K1+tfj0Eum6+rlLkuWB0HodzbQrT9sgsZy239yjQrK+tMkgML71vvurOdKNXEB1pF5yGvD83WGpTmgT4dAIj+AXW2wRk1uqIima4APTxcVte2q5ttjCU8gco5Qm8HImElnEKWltZxV2DUzgtrLbww4OoAO9oXNQWRFP6ZyGn6PjJEcndRj6XUuwrtQUQZKm+RSVx09FG/GEjfpRSA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cd636560-dcc3-1035-43cd-2813f5978333@suse.com>
Date: Wed, 15 Dec 2021 08:49:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-15-anthony.perard@citrix.com>
 <bcca6950-666f-63ea-9ea2-49f70d8a252a@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <bcca6950-666f-63ea-9ea2-49f70d8a252a@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR05CA0018.eurprd05.prod.outlook.com
 (2603:10a6:20b:2e::31) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eff27ef2-0e48-4e88-31ee-08d9bf9f7d11
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB393493B00D745D1BA505FB58B3769@VI1PR0402MB3934.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	VwCw2Kl20vgdPIXpe9psEeQ1pt80qvc126OOyui7PAtssfEimv50mmCFAK3RlNEBAdLzz7MAfMiGf/vDsReECATPBOKekHEmh4v15qavVxzNfBzxezhi+JKNKRrcGAji+toRwQIB7fpav/WeuqzoOlt+JXfjpT8KdHcrO93jGiJXoJE8yQ+jxkXT4yW4R0RW3Dw0EZfc2nEvDWIJYoiZnd7peSCkl0XwLijR2vBbxShGWXusQHhyDnlYnzLOc+R+GQAgexXIpujVkLLlbeHzsUYtvUCsaKgeYG1fndVar30C6qzsKXl3nV/S695Llr1otyfiYQbK7CG51VQK9TO48wHXWmwGQJz6n5Hxi78juanOh5RuzA1BKYA56RxRNv99luZtw5mxZKPBnYnMyDS/MUCXrV8Q0/YY51ectiIkd9KvQlawxhFCetgayzQDM/tGSEtYU0bSMQG+mPOriNIDb4RnQKDXQGqvJFvFxcd25PMl68yxQQ+VGwfz8jdd90+Wb+11gie3IJMvhavK/ivbxmhEan3lxhrF3ZRUv+OeeCV0sTKztgVDcc6biiaJt4HFtbDP6TD5oFSmKxtnIe1q4XAMURUOmo/P+V39/blSMGPUZZpfysI3iLSF90COwuD6Md6Pr/YF2a3/y9kl6SV6k5/5jBHFh46nUoz1PoWlZl2kaZKNKD4uPTss1HdK0QQmg/b9XHT4ED99492Ko4oFjsga++UT+kiLgW8lItESLp0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6512007)(6666004)(66946007)(4744005)(36756003)(66556008)(66476007)(31696002)(6916009)(8676002)(5660300002)(86362001)(6486002)(8936002)(4326008)(2616005)(7416002)(508600001)(186003)(38100700002)(31686004)(2906002)(316002)(26005)(53546011)(6506007)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aU1GN0JzeUxMYnFLd0FLVzRldEdRNVdydDVwOG11bm9qSHZJaFdzNWhCWkRQ?=
 =?utf-8?B?NTk1ZElJdWQyTTBHUmtZcjVaQy91MWJkSWs5ZVlOTml0aHRaSWhvMXd5RXhI?=
 =?utf-8?B?VDlldXdjWlhDeDQ3VHBVZE8xRjI4cWJFQzI2eGFTTloyZTdvY0d4aThrK2tO?=
 =?utf-8?B?UnE2VS9zZUFxRTliK0ZIanYvcUkwVzdpbmVOd3VlR3B2WE8rdjR4VERTSU4z?=
 =?utf-8?B?ZTlOc0d4UEg4RTVMZEE2ZE1PWjV4S0Z6aDdhOEVkSmdpNEZvUk1DekxCRnZI?=
 =?utf-8?B?aEhTZmdmOE5QVWd2V0ZYUWFTKzZVc0x4RXVuanEyZUc3c21laFhMd1JMdEVI?=
 =?utf-8?B?eitaWTVvbEp2aW01TDBLbU53eWNKMWpuTCtUTktYQjM4dmFrQU1nVXRmZXlD?=
 =?utf-8?B?NDFIZWZ6VURiVDJsTVU1TVZZRmdBVnhMWVVCWGlZd3plc3FoWXhVTHlselFX?=
 =?utf-8?B?bDdLU3JOTFVlVnVMekVYZVVPSzVZYzN1U3FDZTI3RjlSM1ovbVBqNXd4cmta?=
 =?utf-8?B?Zk9iRWVFVHU2cEFyNkJTSVl1TjJIRXllUHJQRENzVEJxcnZmLzhCTmNiaWR3?=
 =?utf-8?B?TElhR3RhMmVGUDBPdDhaYWdxUW00TWJGRzFLcXg3YkR0RHd0RFViSTFtWHB0?=
 =?utf-8?B?UjdnUnhmdlNkM3dEeUxGTC9WMCtpQUJsT3lZV0lkSzdmSmZmNWJ5SVZOMUkw?=
 =?utf-8?B?SnBGL00zSTVlL1o2Wm0vdGZLdHhhL2IxRnNzamdJcFIreUp5NnhFdDdyVzdK?=
 =?utf-8?B?Z1pyaGNzeEJqVnV6cmJnVVRQcTNoeUhkVWNMaHh2UVRBbCtHSUZNUHFmajA2?=
 =?utf-8?B?V09sNE0waEpJRlNQVDZaYVNkem1jSUYvWFVQTit4R1Z6S1Z5VlNHNWhiK1FM?=
 =?utf-8?B?VG5uV3dtM3FzUU1HeG5pSXR5dkJneGVNOGVjMzI0TFI2UW1tSlc1YjRaNTR2?=
 =?utf-8?B?TDUxL1lQZzUxMjdDV2JUS2c5SVdvMFVIQW0wOU9GT3lUL2hyQ0FTYy9UbVMr?=
 =?utf-8?B?R2JoOEdEUm4vdjJ6MHd2MTcxZWg4K1dsZUVrSHhXSURZeGQxWkxabFBkUElJ?=
 =?utf-8?B?WmFVeTVzT2llY1VIWER6UG9lTi9hditOY3lIbjM2YmNNZ3pDVit1MVYweGNJ?=
 =?utf-8?B?bkZEV2dkZ1VjVGNMelNvRWxBdmtDNU4vbm5XbzlrSElBakx3emFUM056Wkoy?=
 =?utf-8?B?VGdXUkordlcyK2xydXM4WEllTXk2eit2Vnh3ejlYUlVaejFXZ0U3SFpMcElI?=
 =?utf-8?B?UzJlcHJYbm1EVms4dUxyR0c2ZG5Qbk9iSno5d1BBTU9kZmxmUzh1UmtJSTRt?=
 =?utf-8?B?VGNqeWRpeWlZeWFwWSswUW5kcEY2SFN6bTlIbEovVjU3NHhrSmtweUx4Y216?=
 =?utf-8?B?R2lqQWJZMGcva1RGZ2plTE1TTys1Ump4anN4a1pxYndLeUorUCtZeUNOelc5?=
 =?utf-8?B?TER0UjQ5bzlhd0VmTDZuMnVBVDQ0allMUGpoYk1oR2RIYXVWbkRwZDBMNUJk?=
 =?utf-8?B?UWZzSzduRWk2b004aVk1VFJHcStJNEdPakdrV3BBaFl0cDV1RDdGVFNBdlhT?=
 =?utf-8?B?eUJDRGlTcTBaTko5Wk5zTTJTT1NMMWI4ekRnOEpvU0d2b0VJQmhQS1QwR2Fq?=
 =?utf-8?B?SXdzMVJBRi8zVGp4cnRQNnlkQ29jdm1CZVovNVg3c3pKRXQ2UU5tdXp1b1pI?=
 =?utf-8?B?UkhxenUxY1lNdUxXTFVLQkI5ZjJRZEVxZE5wdjEzOHBBcnN3SXBFRFFSeC83?=
 =?utf-8?B?ZTQ1R0IwWEtjQ1U0ZStwalBWNjFscjhUc1M3RlNFdys4RVUwMVVuOVdHaXAw?=
 =?utf-8?B?ZDgvMXN0c2dETktFN0t3ZVJuSVk1czc5K2RoNjRxQ1I3YlVIc2FiMGNQaWlk?=
 =?utf-8?B?OVU4aEJqUTlPM3JSYjYrWnI4YWZ3N1JkaGJwWDBTcVZIOCtXQ3ZmbkNqalpk?=
 =?utf-8?B?aVdJUWx4K2szUHgxV2NRWFd3RWVqQkUvZWlRNmVPWk1ldFFka01JTWZYSndJ?=
 =?utf-8?B?Y2FxT05PR0RwSlNCWXJNeCtVNWNiL2Z6SUJrNk9tSm9IbVYyUU13djRhRCtv?=
 =?utf-8?B?S2R2VXF3bEhTWk05OGlrdHlxU2NzNE1nUVpwdzlydjdPc0xVVVkzOFBJaENH?=
 =?utf-8?B?V29ZN3orWjcwNHBleFB2ZkR0UUEwbElQVityMEtOZWh0YVMyOHpjcHFkZmtj?=
 =?utf-8?Q?iv2cVTAJ3xYMuq691ikd9N4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eff27ef2-0e48-4e88-31ee-08d9bf9f7d11
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 07:49:57.0259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dDxYqIVoFLrqlmEkjRNKzzGpUdl1jmHX87i08hq9u/QKGVWDk4OjSxbYmPBCGTGfLEvzy3zq7P9Pc6R6bIe2PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934

On 14.12.2021 18:05, Julien Grall wrote:
> On 25/11/2021 13:39, Anthony PERARD wrote:
>> For two reasons: this macro is used to generate a "linker script" and
>> is not by the linker, and name starting with an underscore '_' are
>> supposed to be reserved, so better avoid them when not needed.
> 
> If that's the case, then shouldn't we also rename __ASSEMBLY__?

I'd rather not - unlike __LINKER__ (afaict at least) __ASSEMBLY__
is a commonly used identifier (which we've actually inherited from
Linux).

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 08:35:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 08:35:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247230.426263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPkI-0003Qq-Js; Wed, 15 Dec 2021 08:34:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247230.426263; Wed, 15 Dec 2021 08:34:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPkI-0003Qj-Gj; Wed, 15 Dec 2021 08:34:42 +0000
Received: by outflank-mailman (input) for mailman id 247230;
 Wed, 15 Dec 2021 08:34:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=E5lv=RA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxPkH-0003Qd-9k
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 08:34:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d78476d4-5d81-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 09:34:39 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-95-IjKZ8NlaN7ix_0e6n9g-1; Wed, 15 Dec 2021 09:34:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Wed, 15 Dec
 2021 08:34:36 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 08:34:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d78476d4-5d81-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639557278;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=bHjquGZBxT29+rV3DyLXhP66ZZNGhOFNu6NrVqAHeww=;
	b=lhw8u6ps4HJp5XiE2IiLo/0pRTZydRAsja3z/uYfxdaBX8NWYDCqIcmd/wXXBpirNQjbn/
	SkJ4LIL+F850NRE3I3LCC7io+9YX+MjL83Ed5PQdyUhdEfuLTOHcTZX+6p2ccze2NEmBpf
	+7rccGZmkvdCRAVLHSXMiRyGNekyV+M=
X-MC-Unique: 95-IjKZ8NlaN7ix_0e6n9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EnAZ5Gbl4+Q+1dJ06x6pxShyR5rjktq1GZXcQZfLSSJVIQAgX8XQLvXCQ8HosiwRqpvwQtS45sGTcoVaIGe5TCYpg09m5HR4i2iJ7l5r4zGaJIyFIMKmjayuJNJUQpxnc93PrlpWjzJZQQDka2HlZleWQIrhgwtYzvOddVhHsccgH+5GxtaFSPQiB4h+8NavaxCAP9PhFZ6ADHwoQDZyXWGqNzeQaoeJ77wYcj0VJMtzXAKA/bVcNXm9uVe+EKT2v/1TsrlJJ482SSeBkbJu/im5KnvXl/H5vdFTBG9B/cExeOiHsCT3NnlY9y7/+I9/BE2kd43bX6k2A3iSsLk+Cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=EntNobZw59qZauAyRBO6b0T0b+lzqTdU7cIWKa5tkNE=;
 b=mFSBe7zA2B/BglHEXJjJQkZhDBropXb6HaymfbAPHuvWWbIuFzTRqtuXBR0LC+9/Uu+U0ue7xHeogOusTh0qAg/NNLpl55BbWSr57VCF7JWSFW5tVp4AHdO0rJxOqR6FYzyx+40M/p0PutThXxTgXCTCqZODBUbdTOlIZ0CST00ZajYDgzp3rczDL06ERWaG7+Q36f0DqTcxwDwlfbHt7b6x4sfa+/XPImnltTROGvf+QtMT4U07uC3yorrZWou5Pj+r22/MLQKW5kqOE1fdRJD0lyh3di+ZknIPdVA+xqYBGCd/Y+UNtRtAZjjygAhrWJM6ZSoG+dkZcOi27K2kJw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b187ef25-bbfa-1880-0a10-462c2ba64e72@suse.com>
Date: Wed, 15 Dec 2021 09:34:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] x86/cpuid: Introduce dom0-cpuid command line option
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Daniel Smith <dpsmith@apertussolutions.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211214211600.2751-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211214211600.2751-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0048.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3d4fc218-d32c-4678-d8ad-08d9bfa5ba17
X-MS-TrafficTypeDiagnostic: VI1PR04MB4384:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB438471FE5D1CB9980FFFCE52B3769@VI1PR04MB4384.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PdV/scv4zMZrEJe9n7ZWforVwd66H9bp9tGtl9EzlpAmn/FJkSf8rBxWq/HVoBorCk+8psdNRJ9B9W744+Os/R3ISJeHelclEtcXaGcU4uR17Bz7dpKscyUIsHX9h+2Qdwa6RUi+cKB504flEUBoxYcNj6rOIkGMyVMadSFKbJub8rq+bFN0c6St8LdKWcuI6ax8ahCjB8kgdgzBWqA3HnW22G+2ZDlguqSEJ396GO/uT0zp5j3SiJaknW4nFIKKackiG5gnFWnGgBsHiOB2YOUlQghI4/3VCVoonmGDdP+P5s0sT9WAuvxKIG4HdOYZk4WffPm8dmUp7u4RRYKXIF0tEoHQXi1ql3DfwFgbT5GivSQI/kz0F0nsBIIGdJX9qIPLGfvCDy48P7gYCatzL8hR6chwpMBGRe2t3k7un9RetVHDVWOpSs1842Ja21dW0ITU2rhOygbC6W/eHxCGtfYch5++CezA54W3rvUmD/lCjoUNggoLgtbGdphXBZNVUlhyRNmo7Q39jhSvvesUez4zZTjzcmfYUqv+Rt+dnSx4aOP3YU2gmDfB/N+xJIJrxtEWBYcZ+ML3kLi5r0MH4r3+7PapznO71/W0PgV8GEOWN396WXkR8ANTYcQSU5arG5BFUg5F9dhWntOSWsarAphD9ISB8EQ+A4zSoWwW4ANYbV0BjwU0XB39eTesHP5pVOr+7AYjRMCPIHcAI+E/ca6Kdk3h+v7igVfO6r6c4H6PqNqsaJysLEk/wRJLn2Wl
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(6486002)(83380400001)(186003)(6512007)(26005)(53546011)(6506007)(31696002)(5660300002)(2906002)(8676002)(6916009)(508600001)(8936002)(66946007)(2616005)(31686004)(54906003)(316002)(38100700002)(4326008)(86362001)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2BRiXN/UWeVxzHr0GhjhkmnPEFrbmVAUzpbWt1zl5nGgYqAwYMFPJMONfNcN?=
 =?us-ascii?Q?k6/R5OfaH0rFZOveEfWQmMGfjDWaqehbLta5Rzrg265D3fj01maoDisDfqBq?=
 =?us-ascii?Q?abqzc80PJWydC3ppDyvlsqgQ9zyhQsaRSv87DuMT4u45utAOIvwZ24VU/pxq?=
 =?us-ascii?Q?gdv1eFSnFSZEHpE7JQFIudYlehzkelUsdrl2cUjKAZXqmXboGRDVSR7GFgo/?=
 =?us-ascii?Q?vIXGTJQhDepFhrJPeu7jIHWt9fPOZydCWorp92mdw0XZdCOoiBkB7FccIGEn?=
 =?us-ascii?Q?4INCdC251AX/DnhO3IBAKumILvlSkwFOi5Ag7FLaN/ceSpHToTGX+efp+dXd?=
 =?us-ascii?Q?VG7ADR//wpUQdj8NQP1qaLW/K6eJAnUwjBGz8K8X0mlqD+AIcn2fKhC6W+oM?=
 =?us-ascii?Q?p0oarMqpQteSlM4q10Z4XBM0bZB7A6J7dOfvqJJq5kGdWJO4Fu9AjeOu8igX?=
 =?us-ascii?Q?Ay/AolOE1tSJW8edKfp2QwKNudQ70cRblHr8TAGxfFOvswZ1KxG2/tCTXhay?=
 =?us-ascii?Q?NL6PhhL2XcNFrOtuSCpMEGfmpdUKgkptr+/lfOjZL42PaNAWlh/x8oX+L5n8?=
 =?us-ascii?Q?6jag/YVKeOMPE0vEbTZMZU9qewxcJ59wET8oveHRuVZl1MuPi/mjAkkQQ77K?=
 =?us-ascii?Q?ol9xIMexGJSFo2rwEOLjz9OALf4taVM5zFPdKDsqgHtSXWH8TlmKv/LP9jNi?=
 =?us-ascii?Q?0VKocFV9oKM6YDnG4wotztyqRy6RtS8Rv+Es1spHVHQPkIxYymUTxnFCWL+0?=
 =?us-ascii?Q?XivNXjxQxj6EMhQsDmMKaz33jYWtS9ZuNYyz+C2Th1tuKawdbzMQWo7Ameme?=
 =?us-ascii?Q?y/ZooaM05uEsGRj1dHxCTItE/QB5FZN5h0t93GfCbKEt6gxknCEIue4ViYOK?=
 =?us-ascii?Q?99qpBnDnBM/W4OmtWOF6nxhLuV109CNTSiM9coYzBhGkL3mxKif1am3D78nA?=
 =?us-ascii?Q?Caz+KwYNxAhUMqCF3StDA68XfX8SsNGBJdhniaL43PoTNAz751mme8Bb2ki5?=
 =?us-ascii?Q?UPvqUX651XOktCan+IBxZ8ZKHR1y/wUVfpTWFHgo7AvyhhLcHYczHuCdPAd1?=
 =?us-ascii?Q?twmaDn2N7asg3nRFsYKDeoqT8mDc8DLfTxp5CPwo1a1N5L92OdyWBcMTQGo3?=
 =?us-ascii?Q?LSIcnhp9rBqIyDxp8iRnJvcQCBjr9Ntv9eSXsaeiy0+7+kOskhP3l0vdJbK0?=
 =?us-ascii?Q?/D9WfAQ3h+IA5PwuSK1bYlGMlPwlVre+VmJIn4MEqIG7KMsDruslBR2LtRNL?=
 =?us-ascii?Q?T2riENRDIf7XwVwhiw3v+dxKVAnw/5+i8Eb0QYtQwCgnOAkvpovyR567V43m?=
 =?us-ascii?Q?A14ltDQRwB9v+yNtR/vM/nmRXmEa/tu6uzt6DsTtmJrZPt+diq+uSbkgN+8u?=
 =?us-ascii?Q?ZbONEDdD+hc6eVyGE0lZ6pHsimEg/FJEVvwhvEK81B+BYhgd0+8vXjAwrps8?=
 =?us-ascii?Q?p7xd1zcrBDJmGHmy6kkzRKW4M3kfRbKQ0H304MEIso3Sa6yaj/hzUVDqqJ+z?=
 =?us-ascii?Q?nfZc1rnHcD+XEKpFK2f9fJsxtnfCFOd8pLhhvHhkWy5QpyyQtuwEny+swn7o?=
 =?us-ascii?Q?KlhmkU1qfrvCfJYxXBn1A2t0vD9xP/A7CPqnql/IRU7reN0rfF+ZcVrU938w?=
 =?us-ascii?Q?od/waeSnS5nNqz9TP/w1aoI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d4fc218-d32c-4678-d8ad-08d9bfa5ba17
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 08:34:36.3938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NinluKVxlqWCVqBc4ZOhA79MOJdd835SNUjrrirf/vRS6oYhB852OWYVbR/p1uH1qOUGNCEFs6EQ+oUN2VRPAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384

On 14.12.2021 22:16, Andrew Cooper wrote:
> Specifically, this lets the user opt in to non-default for dom0.
>=20
> Split features[] out of parse_xen_cpuid(), giving it a lightly more
> appropraite name, so it can be shared with parse_xen_cpuid().

With the latter one I guess you mean parse_dom0_cpuid()?

> Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply=
 it
> to dom0's policy when other tweaks are being made.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Daniel Smith <dpsmith@apertussolutions.com>
>=20
> RFC, because I think we've got a preexisting error with late hwdom here. =
 We
> really should not be cobbering a late hwdom's settings (which were provid=
ed in
> the usual way by the toolstack in dom0).

For ITSC I think also covering late hwdom is at least acceptable. For the
speculation controls I'm less certain (but as per the comment there they're
temporary only anyway), and I agree the command line option here should
strictly only apply to Dom0 (or else, as a minor aspect, the option also
would better be named "hwdom-cpuid=3D").

> Furthermore, the distinction gets more murky in a hyperlaunch future wher=
e
> multiple domains may be constructed by Xen, and there is reason to expect=
 that
> a full toolstack-like configuration is made available for them.

Like above, anything created via the toolstack interfaces should use the
toolstack controls. If there was something dom0less-like on x86, domains
created that way (without toolstack involvement) would instead want to
have another way of controlling their CPUID settings.

> One option might be to remove the special case from init_domain_cpuid_pol=
icy()
> and instead make a call into the cpuid code from create_dom0().  It would=
 have
> to be placed between domain_create() and alloc_dom0_vcpu0() for dynamic s=
izing
> of the FPU block to work.  Thoughts?

As said above, I think the ITSC special case could stay. But apart from
this I agree.

> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -801,6 +801,22 @@ Controls for how dom0 is constructed on x86 systems.
> =20
>      If using this option is necessary to fix an issue, please report a b=
ug.
> =20
> +### dom0-cpuid
> +    =3D List of comma separated booleans
> +
> +    Applicability: x86
> +
> +This option allows for fine tuning of the facilities dom0 will use, afte=
r
> +accounting for hardware capabilities and Xen settings as enumerated via =
CPUID.
> +
> +Options are accepted in positive and negative form, to enable or disable
> +specific features.  All selections via this mechanism are subject to nor=
mal
> +CPU Policy safety logic.
> +
> +This option is intended for developers to opt dom0 into non-default feat=
ures,
> +and is not intended for use in production circumstances.  If using this =
option
> +is necessary to fix an issue, please report a bug.

You may want to state explicitly that disables take priority over enables,
as per the present implementation. Personally I would find it better if the
item specified last took effect. This is, as mentioned in other contexts,
so one can override earlier settings (e.g. in a xen.cfg file used with
xen.efi) by simply appending to the command line.

> @@ -97,6 +98,73 @@ static int __init parse_xen_cpuid(const char *s)
>  }
>  custom_param("cpuid", parse_xen_cpuid);
> =20
> +static uint32_t __hwdom_initdata dom0_enable_feat[FSCAPINTS];
> +static uint32_t __hwdom_initdata dom0_disable_feat[FSCAPINTS];
> +
> +static int __init parse_dom0_cpuid(const char *s)
> +{
> +    const char *ss;
> +    int val, rc =3D 0;
> +
> +    do {
> +        const struct feature_name *lhs, *rhs, *mid =3D NULL /* GCC... */=
;
> +        const char *feat;
> +
> +        ss =3D strchr(s, ',');
> +        if ( !ss )
> +            ss =3D strchr(s, '\0');
> +
> +        /* Skip the 'no-' prefix for name comparisons. */
> +        feat =3D s;
> +        if ( strncmp(s, "no-", 3) =3D=3D 0 )
> +            feat +=3D 3;
> +
> +        /* (Re)initalise lhs and rhs for binary search. */
> +        lhs =3D feature_names;
> +        rhs =3D feature_names + ARRAY_SIZE(feature_names);
> +
> +        while ( lhs < rhs )
> +        {
> +            int res;
> +
> +            mid =3D lhs + (rhs - lhs) / 2;
> +            res =3D cmdline_strcmp(feat, mid->name);
> +
> +            if ( res < 0 )
> +            {
> +                rhs =3D mid;
> +                continue;
> +            }
> +            if ( res > 0 )
> +            {
> +                lhs =3D mid + 1;
> +                continue;
> +            }
> +
> +            if ( (val =3D parse_boolean(mid->name, s, ss)) >=3D 0 )
> +            {
> +                __set_bit(mid->bit,
> +                          val ? dom0_enable_feat : dom0_disable_feat);
> +                mid =3D NULL;
> +            }
> +
> +            break;
> +        }
> +
> +        /*
> +         * Mid being NULL means that the name and boolean were successfu=
lly
> +         * identified.  Everything else is an error.
> +         */
> +        if ( mid )
> +            rc =3D -EINVAL;
> +
> +        s =3D ss + 1;
> +    } while ( *ss );
> +
> +    return rc;
> +}
> +custom_param("dom0-cpuid", parse_dom0_cpuid);

I wonder whether it wouldn't be better (less duplication) if the bulk
of the code was also shared with parse_xen_cpuid(). In return moving
features[] wouldn't be needed then.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 08:44:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 08:44:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247237.426276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPtE-00051D-I2; Wed, 15 Dec 2021 08:43:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247237.426276; Wed, 15 Dec 2021 08:43:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPtE-000516-EO; Wed, 15 Dec 2021 08:43:56 +0000
Received: by outflank-mailman (input) for mailman id 247237;
 Wed, 15 Dec 2021 08:43:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iD5n=RA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxPtD-000510-Cr
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 08:43:55 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 21464ec1-5d83-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 09:43:53 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 21464ec1-5d83-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639557833;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Kyc5hA5unG9cZZZ/4DgK6uatWjK8XcZes/1sBJxAHKg=;
  b=UpjAdiX5NzZnYGplZMwBJUTGnuqnRBoL3TQypgkrrfd0R1/HZN13EbsB
   gvB9UheM9YcCAgmqHbkOr3Kg36yzuSlxpV+zoJk7tPEnKuR8SG6FWcP1i
   L+TlJkOXDoXjlBIUNGJRI0ifzPro+120+OAFRCHWdpCP6si4bdaT6bQi+
   A=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: DT7cib3dcjKt8uMDZTPBhk6bZNnt2lZhZYajoV2SWUBFlXN8bSH94/+SMgROqd+HxUNGgUsz9s
 zHd4zimi4Druda5UCTKGVkY0G9it10W2YeMnf0nkG/Mb83c8PchGSci6NoYd4EW9FzujDdrVhy
 WB3bICcadGqO9iaUvsftitKxuQhk1UOGoxdGqYiytyxzHsEgd0oSKZeGOvZoC/NgFYadw7NsvU
 qjbp1elxmxF6yp4h5/19Xq1jJXCurVFWQz4LUdV0LhQeOPMzdjdmGUCRtBqdU+J1BXTQjKZSL7
 Sbs2WcFyrKjutugZ3rTc2V+d
X-SBRS: 5.1
X-MesageID: 62131961
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Q6/4lKsv33k+XdVzbduu1LF6HefnVINZMUV32f8akzHdYApBsoF/q
 tZmKW7UO/+KYjGjc4tyPY/j8RxS78SHx94wHlA5/iFgQSIX+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy2IXhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpltLPqW1s2Lp/1tvU3DxV9I2ZXApZt5+qSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JoXRq+PO
 ZNxhTxHfgTAfwJIEV0sCalgxt+GnF3ZLm10twfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcLMaYyzeO7jSrnOCntSLkWqoCGbug7PlojVaPgGsJB3UruUCT+KfjzBTkApQGd
 hJSqnFGQbUOGFKDT/anTUGnsEy9kA82B9Z1I6oT1zqm1f+Bi+qGPVQsQjlEYd0gkcY5Qz02y
 1OE9+/U6SxTXK69EizEqOrNxd+mEW1MdDJZO3dYJecQy4C7+Nlbs/7Zcjp0/EdZZPXRECq4/
 T2FpTNWa1473Z9SjPXTEbwqbluRSnn1ouwdulW/soGNtFoRiGuZi2qAsAmzARFodtnxc7V5l
 CJY8/VyFchXZX13qASDQf8WAJai7OufPTvXjDZHRsd6pmn1pSDzINAOulmSwXuF1O5eJ1cFh
 2eJ5mtsCGJ7ZiP2PcebnarvYyjV8UQQPYu8Da2FBja/SpNwaBWG7ElTib24hAjQfLwXufhnY
 /+zKJ/0ZV5DUPgP5GfnH481jO5wrghjlDy7eHwO50n+uVZoTCXOEult3ZrnRr1R0Z5oVy2Jq
 YsCbJXTlE0EOAA8CwGOmbMuwZkxBSFTLbj9qtBNd/7FJQxjGWo7DOTWz69ncItg95m5XM+Rp
 BlRg2dUlwjyg2PpMwKPZiwxYb/jR88n/3k6ITYtLRCj3H16OdSj66IWdp0We7g79bM8ka4oH
 qddI8jQUO5STjnn+igGacWvpoJVaxn21xmFODCoYWZjcsc4FRDJ4NLtYiDm6DIKUnisrcI7r
 rD5jlHbTJMPSh5MFsHTbP7znVq9sWJEwLB5XlfSI8kVc0LpqdA4Jyv0h/4xAscNNRScmWfKi
 1fIWU8V/LCfrZU0/d/FgbG/g72oS+YuTFBHG2T77KqtMXWI9GSU3oIdAv2DeirQVT2o9fz6N
 /lV1fz1LNYOgE1O79hnC79uwK8zu4nvqrtdwlg2FXnHdQ32WLZpI33A1shTrKxdgLRevFLuC
 E6I/9BbP5SPOd/kTwFNdFZ0MLzb2KFGgCTW4NQ0PF7+tX1+87ewWElPOwWB1X5GJ7xvPYJ5m
 eostab6MeBkZsbG5jpesh1pyg==
IronPort-HdrOrdr: A9a23:FvtDzaoHWyMqFltJN22T9kgaV5uzL9V00zEX/kB9WHVpm5Oj+P
 xGzc526farslsssREb+OxpOMG7MBThHLpOkPMs1NCZLXTbUQqTXfpfBO7ZrQEIdBeOlNK1uZ
 0QFpSWTeeAcWSS7vyKkTVQcexQueVvmZrA7Yy1rwYPcegpUdAZ0+4QMHfkLqQcfnghOXNWLu
 v52iIRzADQBkj/I/7LTUUtbqzmnZnmhZjmaRkJC1oO7xSPtyqh7PrfHwKD1hkTfjtTyfN6mF
 K13jDR1+GGibWW2xXc32jc49B/n8bg8MJKAIiphtIOIjvhpw60bMBKWqGEvhoyvOazgWxa2u
 XkklMFBYBe+nnRdma6rV/E3BTh6i8n7zvYxVqRkRLY0LrEbQN/L/AEqZNScxPf5UZllsp7yr
 h302WQsIcSJQ/cnQzmjuK4GS1Cpw6Rmz4PgOQTh3tQXc81c7lKt7ES+0tTDdMpAD/60oY6C+
 NjZfusq8q+SWnqL0wxg1Mfg+BFBh8Ib1W7qwk5y4CoOgFt7TFEJxBy/r1bop8CnKhNPKWsqd
 60dpiAr4s+PfP+W5gNcNvpcfHHelAlfii8Ql56AW6XXZ3vaEi946Ie3t0OlZSXkdozvdwPpK
 g=
X-IronPort-AV: E=Sophos;i="5.88,207,1635220800"; 
   d="scan'208";a="62131961"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MjsTlHifb1lXvfJGM1fjqhAYuuiiiSs7jwh7AnPfgfhzYjCcGY3ajOVuktr+RmLCqgtZ+Kp8HjTnjofihUIJWyjaKERpkIrFo6edkDhZxEbxYCuBZux5WUaKkrJw45tlryr7hJi+h9hi3Cio9dwiPm0XPcDWDay1nDGfdEjt8ks3y5UlU1wOZkdIMqp3OVztMz0LeVchOah6riprGKpK4Px1GcYbTgr3JoiMQZ5exSUDzbcQ9bdBI45+i53MpRDDoDxBqSAebG4WzyQX/R0tbWt+kbBNoOT1wWRtSnAypGPwz/V7AXCuEB+rGV8+B9tlbKjJQw+WCdVHCyggx/G3xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M5C+ZIk3e8/GCHvvU87Qy33fQR347nYv6mO5zi/A6Bk=;
 b=Z8Yt9mK9cY7L8jUElT6DdhsME5y+lwVfLyzIzqQZpWyGtTv2b545imsX0wRJbYpAuntkQSqXnhFetdtBxmdv4szxgPSL5KebxYQU9svzSpj/w1wnS2oRxOT19cfhbeRBb5Akn1LUxd3j3Lr1hrTApLk03FeBWMQYeuIxqqSaBzkfELTUnIHenMjD+LTxu8QWgL8yd7iN/wc3feZLl3mjIRAF1drDd/ie6a3Q5GyA+wZPq7CPlAW3O4DY3td2U0vT8ZymHph32Qr8Nxoxt5BqtWoLnfozKjIb/8U77ys6Etq+OEDdwHKU0Eida3FBFuifSbGSWFbEGpdSW8Km/tz7bA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M5C+ZIk3e8/GCHvvU87Qy33fQR347nYv6mO5zi/A6Bk=;
 b=fAm8jB29P8exvAI4VIehnx+6aM0nosAfDm4SCKvIKxR3pzqoMQsxLQCJHCtCg/989BNP14+rdn1dp9l4i8Rq3crwNEa14qDFLkqx66Cr4kbz94N+wiDrhvsPFLYzt4iF7Til7L/8UXb+20N5PAhsT4gJzizDqhXfh5FtSdVL4pA=
Date: Wed, 15 Dec 2021 09:43:33 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: [OSSTEST PATCH 2/2] daily-cron-email-real-*: Temporarily drop
 osstest-admin
Message-ID: <YbmqtYj4JRFNz24D@Air-de-Roger>
References: <20211214145226.2248-1-iwj@xenproject.org>
 <20211214145226.2248-2-iwj@xenproject.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211214145226.2248-2-iwj@xenproject.org>
X-ClientProxiedBy: MR2P264CA0042.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::30)
 To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ffdf7d78-3f34-4986-388f-08d9bfa6fd73
X-MS-TrafficTypeDiagnostic: DM4PR03MB6096:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB6096225CCBA1592F4C9A08F88F769@DM4PR03MB6096.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ExGqt3T3xEontPNegFanOFUEvfa00U0VOCOBsK1LQ/axr+IK3mQmA1XYtsVvHMmc/5MwBGIEYNEyTH4a6iY48z98edC7FFKDps3n52tTdtLtqeGBAVxxSRPwYk3W+up2G+KNLXDRqJdBxhinS5X7QpOvQqWLqKOGDU/YLs17he6QkkxR81gyD0Ad9jd3IjNjZs9nW7AxbRNahtxpkgEeVUQQb0P8PrHPAalFEMD99KyKdnCXlctT8DM2XE3ejTxfrXRfgkYKzJmZ0DrP/pxMYprDM/mr4hw3zPIeGZwd7ImcOBwzzE+jc2rV4s6F+2H6v66Hif2j7xZklwwn8Lt4qDtFMW2Z+ahX++Y9HfP5D4qKpc4S0R7xHPkoCOgx8d27HnCFLdntvmxZCx6IOqifwvQgcIWpED334eIhXAtoznx5UU0pnt4p2/uUUTKNuFdZzA2BkcQdwrkKHuXiwfSoAwag75BDpQIIOWQVvl3YZbszrXPCBPVcaeEqxf6cR8a5q6bacOWA+7JhiDZm/bV8CJf7kp8PxyiKkqJ0cdSKHvNb77SrPXxhtSi2nr5ZDeV4DVtKorC7EI7hD8yEVhaDnrv0OLD/+Re0huwHh/z4LSVI4jIE3T1huE06lCvIW+8JVglOrghUBrLmE+RQ0p1M6A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(9686003)(4744005)(6916009)(186003)(85182001)(38100700002)(6486002)(83380400001)(6512007)(5660300002)(33716001)(508600001)(66946007)(8676002)(66476007)(66556008)(316002)(26005)(8936002)(2906002)(82960400001)(86362001)(6506007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlU2WlQxL0dHalZya0NXN0VHakRKamt5MHZhSmFtR0czbUJKU25WMWY1eVll?=
 =?utf-8?B?L0hMUVAvZ1BJaHNlak51WWpIbk1HZE1oaklhbUlTc3U1Ymt6aytrQUhGQy85?=
 =?utf-8?B?UHBaTnFkbDZ6WGtrY0FXRnFSOHR3Mk43Rkd1dUJxcGFsV2l1MDk3ZWdsd1Uw?=
 =?utf-8?B?MlRheU8xbWw1Ui96aVUyNmlHeW1aaUhQMTRJTi9nZ0V2WXBrRnBGcllTblhS?=
 =?utf-8?B?L1ptV3VlaDdwcHhmTXpmS0N4Zm82eTZ1emdDTXp1bndsRUNOTGlBQkYzN2w0?=
 =?utf-8?B?VGFxYmZZSUN6dHlsbTkrOW40bGw0dGZxOHRHeTdsOHkrQ2RjdTdTby84WFdY?=
 =?utf-8?B?Q2czSC9FUld3cXhyL3orZS9uVXJKbFJ5R1VSc3lrbk85MVB1bW1mR1RITFFZ?=
 =?utf-8?B?T0xWdFhaY21wa2RINEhVakx1UVN6VEptRmVUekFJVXRrMVVwSWlTZThmZzJX?=
 =?utf-8?B?MEwwcUR0SXVqRjhZWG1JUnBHR3pvV0FhV3phNFlET1UweEd2UFBuRy9hREVa?=
 =?utf-8?B?TG8zZmViVXBsWStVVHcyZ2doN3lZaWdjQTBYWFMrMnFQQ0hyd1laRExRaDNi?=
 =?utf-8?B?SHhiREJkSFZTODArYndEOG10alJoOGtabjFQb29lNTd3TlNuR1kxSVVyd2la?=
 =?utf-8?B?bUhjVzRuMkZGOEEzZU5mT3AxdU1kSW56dFpKdStTVXQyMHVmQUJMMGRCQXAr?=
 =?utf-8?B?c01VOVA4ek44c0FFWC9ueWZuS1U5VXFaeE9NL1Jjb2preEJHMFFXS21scnV3?=
 =?utf-8?B?ZHRxendsUUlCbHE2bUJ6cHlxcFRFYW9IcVFHNURBZkJKK1BuektuTlNCRG9n?=
 =?utf-8?B?ZWdFTHNWeitsaVBKcjNmaVZvVEpIYlFySTV1U3pjNHpTbXpQNHNubFBydkFi?=
 =?utf-8?B?NDhqSTRNQm9XbnVDOWd6VHZLbnJNQzltTHQ1dVpoZmRMRUNhNTYxc2JCTEZ2?=
 =?utf-8?B?aGg0aG9CdUFJaXQyRjFCRUpFZzlGbE1xbzJFb0xxdHVaZktRL1pVVUc4Sitz?=
 =?utf-8?B?bHQzempUdDBlcXFWb2JKT2NScDZmWHdaaTBib2kwNm51TGdja2puWFdLNkdF?=
 =?utf-8?B?ZDJHZ21SNmZwaWFQd0x6dnFzSnlDL3VhNXk0bzlwZkpVZHlTRUk5NWk2Vlhk?=
 =?utf-8?B?SWFOL0VTdjNMdyt5YXFvcHE4TGNaRFhvTWFaekMxcDB0dlMwblNRek4zYjVC?=
 =?utf-8?B?bHk0K3VEWmh1QUNZMHhDRXczclNlODZWYWl1QkRCSnQ0aXZOY3Z4SzQ2bXhV?=
 =?utf-8?B?LzBlRGRodjY4MDZvREloclA5alVPdFRIVm5MSG5BT3RJdXRpenFFMHpJUlZP?=
 =?utf-8?B?TE1FcTFnOTJOVXp3VHdlWHZ0aEprbTJZdHBXMGNrZEV5RjhBcDJtN2NWRjk2?=
 =?utf-8?B?MjdMaUdWWDd4SzAzNjRKYnBUc2NFWVNYM3VLTktUVm92VlB5aDlacmYwbjFJ?=
 =?utf-8?B?YWV0MjRIUFhtZkFCWlEwQTU1UDdaY01CWm1HWDBPUlhackozL2JEdCttSkRp?=
 =?utf-8?B?UlZjcWpJQjFPUXhlY1RpeFp1OVQvaHRDMnMvQVhhWTVaaEJCaTRZV2kvWWdi?=
 =?utf-8?B?bGxBdnlTVnRYdU00YWtBN1kvMGVjRTRHaUVNY0NMa0VtUlZyOG5wb29La3pX?=
 =?utf-8?B?ZUxGdWY0bi91cU5xMVEvandPMEQwRWd5Vlp0OXFMSEc5SGJ3d2lBRkVzRXJz?=
 =?utf-8?B?MFlqNG1QUVZ6TCtrY3Q2Ykc5bGlJWmpiTGNKdGx1b0o1NElSUkhTTXcybWdF?=
 =?utf-8?B?NURNSnlFNU5lOVQrU20rdGVkK1JDYysrVWl3TXdwazRpcVVnc2hGQ29kYzdM?=
 =?utf-8?B?MEJrTU4rb2IwQmI0NUVQY24vb1RKaVE4dk1YdTcxNGRpOWxWeDM0RjRTZDJ6?=
 =?utf-8?B?V3FmYTFJTHNPUnd1QjRCUFJHd0FqOTc5NGhXZGdMeUI3bkQ3TVl3TFFZL0dh?=
 =?utf-8?B?VTN3UzQ0RUFMOWRSeTJQVEdiMXlvdTRGYmFiclNDSTR3WUdYY1JPMUpTbUEy?=
 =?utf-8?B?Rk9ONENsbElKSWVDRzlLMU1sU0J0VjR5U2ZxK2pWVXd1Y1dyekZRdGpvaEdF?=
 =?utf-8?B?L1J6OCs4d2JmMWozZThGYkx3VDZSNWlOY2xlV1pncnVaQlhocmk1RmQ5akc2?=
 =?utf-8?B?SlNGakpFSGVVaXdxenljci91VzM2SmJqUXBMNW1iSlhXMmV6OWd3MXUyaEsy?=
 =?utf-8?Q?K8pl2rM8yFD4EA56y1hdpZw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ffdf7d78-3f34-4986-388f-08d9bfa6fd73
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 08:43:38.8453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Css71Z/+hFyENQO3dtZ6qc9USEII51XqwU6ZUqLvcmCSHNFV4ivFxB3Jw4efT/mskqqszaZ/2toaZGpfdPTUVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6096
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 02:52:26PM +0000, Ian Jackson wrote:
> Roger has agreed to take on osstest admin for the moment.  Someone who
> intents to take on the role long term will probably want to get CC's
> of these flight reports, but it's fairly noisy.  So for now, send them
> only to the lists.
> 
> CC: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Ian Jackson <iwj@xenproject.org>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 08:44:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 08:44:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247238.426287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPtV-0005Pb-UQ; Wed, 15 Dec 2021 08:44:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247238.426287; Wed, 15 Dec 2021 08:44:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxPtV-0005PU-Qh; Wed, 15 Dec 2021 08:44:13 +0000
Received: by outflank-mailman (input) for mailman id 247238;
 Wed, 15 Dec 2021 08:44:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iD5n=RA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxPtU-0005Nq-Tl
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 08:44:12 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 2bae42ba-5d83-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 09:44:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2bae42ba-5d83-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639557851;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=LiGmE41CA0sxKglQkTC+aAionA4riLwh9n/+hRtPagQ=;
  b=becK6jpJlibGVe3tobCf/NcRbh+qORf8qlf9b+lBAfraTyVujc0iRNHm
   7kf5vd/KljhVLoIGFpuoEvTH4OHSd6xmP8KkdiG6qj5Asu0oZAB/8Fc59
   lo78LThoP4W52z6PmJu5MpjmsCerkgKXfsy+V/tQ+XwxMCh0CqFwIt8Mw
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: X7EN5DQ0lAUxfrZl+No+DvQ/AfiWSa4tchedwvMmrdxElN+PkxSpnZy4bI5f3rxCR5nlgE5+iU
 ONZeVFB7xxGvsWLB4P7k5aqwlNWio/Qn8BnZGdIZ9tBJsI7bFyCvMj/8wNJiUO4Ojs41hDC0hV
 eyMgyL1uHYyzE7P6/7EpoWgxJ346v/rAFgwdddr2ZadVir2kZcCOH/Kboe6cWGMR8k6p1yEToZ
 9CVHTUxcC3AD8CCfTH5Vq4aGRmr2aFOJLbjejKAgVIk8D4qGsMoCjfgNvDXLYUTBx3nKIyDZ5k
 Aqug8HgBSHitUljvSqPgNi/8
X-SBRS: 5.1
X-MesageID: 59560885
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:sK+/iaJ68LL64/V1FE+RBJIlxSXFcZb7ZxGr2PjKsXjdYENSgjZRm
 GoXCzrTaa3fYGX9L4pwOYu/8h8H6JaAzN5jQFdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg6xrZg6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB3OkfpX5
 fBBrqfoVCovYqOdpd0iAgJhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XtIIGhGdg26iiG97XX
 MVBMQpSci7pbiZOGmoTL8ITucun0yyXnzpw9wvO+PtfD3Lo5Bx81v3hPcTYfvSORN5JhQCIq
 2Te5WP7DxoGctuFxlKt822urv/CmzvhX4AfH6H+8eRl6GB/3URKVkdQDwHi56Dk1AjuALqzN
 nD45AJpo4IU2WmnVeKlQjC+/HDVgycjCsFpRrhSBB629oLY5AOQB24hRzFHacA7uMJeeQHGx
 mNljPuyW2Ux7eT9pWa1s+7N8GjsYXR9wXoqPHdcFWM4D8/fTJbfZ/4lZvJqC+aLg9L8AlkcK
 Bja/XFl193/YSPmvphXHGwrYRrw9vAlrSZvv207u15JCCsgNeZJgKTytjDmAQ5odtrxc7V4l
 CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmaN3AYxQcl8p2r3k5JGQWy2yGsgTKuOGpxbEQIFn
 WeJ4V8BjHOtFCXCgVBLj3KZVJ1xkPmI+SXNXfHIdNteCqWdhyfclByCkXW4hji3+GB1yPlXE
 c7CLa6EUCdCYYw6nWHeb7pMjtcWKtUWmDq7qWbTlE/8j9JzpRe9FN84Dbd5Rrxjsf7f/lyKq
 4032gnj40w3bdASqxL/qOY7BVsLMWI6FdbxrclWffSEOQ1oBCcqDPq5/F/rU9U+90iMvuuXr
 Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV
 eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq
 rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj
 lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T
 uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L
 TzNZCLCB9SDtycX
IronPort-HdrOrdr: A9a23:J2j5galdCm92FbWhCaWn++ykFtzpDfO0imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmHp6VMt1xNfdfOla9MS4kD1jiU2gPNJt3ck4l+KSHqInc2omRCek1Jd0J6d
 P8bG8=
X-IronPort-AV: E=Sophos;i="5.88,207,1635220800"; 
   d="scan'208";a="59560885"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HkNclx5Fi4w2EGGYmYXEmQnpJ0XjscFddgB+ed85K6RNj3vYV4iUpWTmllpTvTReK8nWpFOZqUR+WwU7VQJCaECFraTWtXjqpqu4i6a7vCyUAqk6bJhYMYk6sUvv0/1zU/2YoXsfNoEUIjVcpbbFI4qagEUUyR73+0eqkAwi8GvCvXDNjhmtkQw+FJnhGTWOiyDqmlNeLIakTJZoiGdCLTtj+/9oIxAX5MngjRYMtt24tzfXehQHJLn9+ZtrYlkWutRnP67s/w7XMe/3LjnHAytiGQ4BTq2nWTcsR9tjzEP/GB2DcPp0yrWfaS2oIDTOFog1vML1YEUuF0snBXz+Ew==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tQo+YxlM23lAFaH0EiGqDgYh8OCGv5h6MGHipUu+WX8=;
 b=Sdv2DQFzZseu8LGVfbbNDI5wF5HM04xJ3GycRJ8ub9UWDGMAxzsSQeseNNhs07FjSJVPLE83jRTQWzhzAGGoXjhLtRFgH1Yd0Gxvudd3TIeDWcB/VMT7ds3gCeK1gZjUDWgfwmz9QDaJwJUx00tZHthoetrDYQdFom1r6UZc/oCep1t8jbQM9sE+yayguHC31s4O4pauRZh/ECRD6rqjF3Sq9bqw+RlbJGPbVEMBSP1YLYcAKGotDaZhLX8Fz757KlA2ZJrdEKA5nrnKg3ZP25fK6F1HBxdAXdYt2xPGMWcdFtJzjelp0yh/j0cylsdL9G5MpZuZv9gRseF4PQrHKg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tQo+YxlM23lAFaH0EiGqDgYh8OCGv5h6MGHipUu+WX8=;
 b=RB84v1G53fIZejjYugFDGuSikc0ONc4h9W+qPEox/9LlaIKl/x6UZrI1oCAv01aw0gXSeuscD4S/dq4/cp4cmNMt5OKVQHOnI9A3wmxxF4jrNlolYMA4nsnKUvl2Nk4mLLv/08gNyYz1duBXl/TV2AEvUH1Yj0oiKrWigrgjb9Y=
Date: Wed, 15 Dec 2021 09:43:57 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: [OSSTEST PATCH 1/2] daily-cron-email-{play,adhoc}-*: Drop Citrix
 email
Message-ID: <YbmqzVQSKxf2Vbd7@Air-de-Roger>
References: <20211214145226.2248-1-iwj@xenproject.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211214145226.2248-1-iwj@xenproject.org>
X-ClientProxiedBy: MR1P264CA0143.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::22) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 989ee883-7ea9-499a-cebb-08d9bfa70bb2
X-MS-TrafficTypeDiagnostic: DM4PR03MB6096:EE_
X-Microsoft-Antispam-PRVS: <DM4PR03MB60960EAFF416CB2492591A258F769@DM4PR03MB6096.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: hpJo9gJONG6Wj8ZNRWuA2zUSAGymwOXh8Av8+pO49v/yckw8ptzbScq7Cx4v+32tj8s2mOnX44JpklqjV+v9+yaO5Q3sVxlO3CALXBWFuG2HK94Dub9iLQEHkJGufsusHcqUcMzckAbFXcISxu4oxBzKZNe3+XQ3uR7crNKTT9XcAIGUNq03kwNmFGl8hXGnPbGU+B16rJ7mro5RhJ5J5GxNAhMF4zBnVYm9A4LWLYK3sK0B2jzJnANgI+YaI10+THm4kz0H98/NiOAmVp+VCEhQ4n/w3SDurYgUoUx33PVuqfbbW55t3phdRP9YgfKvh11JPPLko7ohmUGjSQqgHrF/YC4qeo39rRE7i8vvBWBXpGb92Ekn4T0NBMfbUGYFZGwsZ0aEwg/zoaygvV4LnHqyGpHErdKjJo9d+w3L5jyu2w3GnwA48YPk+/sHMGoHAi2rbuvlLtkRMthwSVg/Py9O97Lo1e3G43b63VwT8xviRbJE2xEyKrS1jChzI5z0hd3J/Zj2VKru6ubreOyIspwr7bWOd439shvGX4Rb8aUgG3pbs0f/qTaSsZ0opt7vorvc3HtOoa0uJxDi7YcKQDjGe0q5zCjZyC3kt2sRi5BpJp6qp6npx0qx+qX7yIQsar5TAldTuwwW3ALT6Kmwow==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6666004)(9686003)(4744005)(6916009)(186003)(85182001)(38100700002)(6486002)(83380400001)(6512007)(5660300002)(33716001)(508600001)(66946007)(8676002)(66476007)(66556008)(316002)(26005)(8936002)(2906002)(82960400001)(86362001)(6506007)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmtUNCsrc0xtdjQrZUwxNDlMbjMzM3YyWHp0ODdEQ1lYVGNneFN4aTFIU3c3?=
 =?utf-8?B?aHlTYUw0SE5VZkFTR2ZwYW95M2p5L1VBTExjbUo3dGpydkNIZ2Y4azlnZmpj?=
 =?utf-8?B?THlvTVVsWG0ybGcyNi9TVyt5V2toeHYvV0EzdDIxVDMrOTBZTHVXUlRwKzVG?=
 =?utf-8?B?c0UxVW9zSjhvN1hPZ3NXcStJMXVScVFiYlNsUVJZWUtNZ2RQOTZBL3c2SC8y?=
 =?utf-8?B?TGJvTzUvM0lad3V2cmpSdll6RVNYM3BNTEdlVStGcFh3cm5VQVVqT28rMXJ2?=
 =?utf-8?B?L3I3Y25HbGEvTFdvWmxKbGo4TEZlNDU3UVhUV2p1dytvbzgrQVZCcXpFYjNI?=
 =?utf-8?B?SVo0SHUrK1VCaU1acUdVWHR2cnhZUlh4c3Zvbk5KbkJ4dEVGMWo4ZE5hV2tk?=
 =?utf-8?B?NXlMSVlaemxDaXpXYWxZZk81eW1jUThwU09ia2pSaDV6MDkwOXdhemhPYkJ6?=
 =?utf-8?B?dFFWcWZURk1hblhqT1orUWxhZzdnT3JHNnNjU3BTc05UeXhQdElJVmRYL0hF?=
 =?utf-8?B?a3JwN20xS1ByYWllU2k4L05zT2YzdmRZNlFweGlTaVZveUpVYklzeDRoME5D?=
 =?utf-8?B?S2Z3Zkp2NVFMZmtua2lWRXNPZGQvbTVVbmNueDBMMnFpaFpvN1JhdWRiUjc1?=
 =?utf-8?B?OENRNE9TaFNIa0ZWRi8vNUEvR21JN3pnTFd0am1rUEhGSnBGcmRtaFUzTzhE?=
 =?utf-8?B?aWVUWGkzd0FFeDY3UXp3bXgrM2NxZTlaWUkvd1dzQzVoVm83U2xGZXI4S3lF?=
 =?utf-8?B?VXFhSmZPall5UTZoM2NuY0FibWlsaDIvRkRiU2l2NjVzTVZTR3U2Znc1OTlD?=
 =?utf-8?B?V0p4U2hHTEM3Z0ZlR3lqY3hURk9KRHlXVStPbXpnVFhaSlRENGhZMUxhQUVO?=
 =?utf-8?B?QlROd0swWVZUR3UwRWtCaGVXdWlvWGF4R3ZZMHN2dno2N0F4VVpTY2pxK2c2?=
 =?utf-8?B?Ukt4amI5aFp3RkRVRzNUZEdFR3c2TWFLZmhXWXorMDFYSEI4NWdTN1pXendQ?=
 =?utf-8?B?dGFadnRkUTBEcXJXRUJNUytOWHJkU3A5Q2RPR3pvRG4rd2JWakpvL09pYks3?=
 =?utf-8?B?aW42ZGwxQkc5aTFZMFVRSFBVNFJYVGVZNlpNb2tQbkdrN2lZZkpreW1FNjU3?=
 =?utf-8?B?MmxZZ1RGMkZPRVdXQys5NzF2dEdkU25TUXpad3lWdlBoUzNYUGp3d0FGQmxO?=
 =?utf-8?B?Q04rOVVpd2VyTE5BVllwQXBFM2VYOEdBK3VqdmJ1RWdwQmZpVE5rMGNvQmJh?=
 =?utf-8?B?eGI4YnlPdHV6SDNOVTlDU3FiMkkwa1Y0SDE5cXYzRTByNnhXVzF5MG5OS1Bi?=
 =?utf-8?B?Rkk2MlNLOGgvZDRLNkQ5VlBIUitPMzJJVGQ1d0NDWFhQOUVGZWVwTTFkR1Zm?=
 =?utf-8?B?Qlo0dHo4WVRGbkdBcUhVUmJLcEFrbGVvbUlXc2NFaW1BSHhUWG95QXV0aGdJ?=
 =?utf-8?B?eWFpVkN3QStOOUlTazNKajZGTmd6dXZkaGJkRVVDMDRiWDVQb2p1SkRqNGF4?=
 =?utf-8?B?TXEzYjhjTDM4Z3NKeTZHZ1VWU0VVa1lyTDJaQlJaL3E1Zk52ZkhYWi9tMFhy?=
 =?utf-8?B?SEN0ME9aUnU1TmRxUTJrdWVtaWNGVVEwcTJxckFFT2RPd2JyS2xCMytZTHdh?=
 =?utf-8?B?U3ZRbkJEd1JGVDhqdHhwTkJKTkNPOVA5eUhXb3dPZFB3TXJTN0k1MlF2OWFl?=
 =?utf-8?B?NlN3WXJkWUtFSXhOUkloQ3JRNHpkcUtZWW05NWU0M1dxOThaenpFYW50cjNt?=
 =?utf-8?B?UVhSbDliSGtkemNkUHdDdFQvMzdiK2dLYUhnTW9Qb1RoTXZPVEM2NFN1QzZm?=
 =?utf-8?B?UjNIYmNPNXNXTWVRekdhZkFDK1J5VFo4cDdYS3FjZUg2OW5KaUg0YWYzbHJt?=
 =?utf-8?B?ZCtURm95d2g1NWFtbUtJdGp2SXNSUmt5Qk9nc2pkTkduZ2hCSDlVblJHS3Ba?=
 =?utf-8?B?MHRTZHQzSTFudnJCM0MyMDBxcXdGa0xzT01pOEx4QmpXQ1g5dE9WejE1Rkc2?=
 =?utf-8?B?ajl5YjVzbkNPcUNVSm11dFFQTWxaWmdDdFp1QkhJSVduZ3N5VkdLTDR1RkxQ?=
 =?utf-8?B?UVFBMnhDR3pVRTc0S1ptdzB4ZTQ3TVBzSk8yVXg0V0xkdnBJeFdXR2pIdXNL?=
 =?utf-8?B?dndMNllMbWkzMmZkUmp4MS9yVnBlM2FtWm95WktJTTlVUHREYjhQeFRKY2R0?=
 =?utf-8?Q?uwjURUmsQi9HFd1YbOCkPvI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 989ee883-7ea9-499a-cebb-08d9bfa70bb2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 08:44:02.7054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hsRbTRHxI5yGarjpM7yjmj9P3qwJ6EyXzh1FSXiXqxkVl9+AgS3N4chGLSMXiJXpCJSGwG1ZV4LkLYty9gVnVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6096
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 02:52:25PM +0000, Ian Jackson wrote:
> Any such adhoc flights run from cron should be reported to
> osstest-admin, not my (soon to be deleted) Citrix adddress.
> 
> Now the only remaining occurrences are
>   - examples
>   - authorship annotation of the init script
>   - crontab-cambridge, which would need updating
> 
> CC: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: Ian Jackson <iwj@xenproject.org>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 08:55:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 08:55:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247249.426298 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQ4d-0007Fv-0L; Wed, 15 Dec 2021 08:55:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247249.426298; Wed, 15 Dec 2021 08:55:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQ4c-0007Fo-Tk; Wed, 15 Dec 2021 08:55:42 +0000
Received: by outflank-mailman (input) for mailman id 247249;
 Wed, 15 Dec 2021 08:55:41 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kH8z=RA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxQ4b-0007Fi-TN
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 08:55:41 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c7762e87-5d84-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 09:55:40 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 4299121107;
 Wed, 15 Dec 2021 08:55:40 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BEE413A6B;
 Wed, 15 Dec 2021 08:55:40 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id fr2CBYytuWE6QwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 15 Dec 2021 08:55:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7762e87-5d84-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639558540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rA2PPHimPqd2WGEoLE7pNkyE+Am9co0F2w1XVXqv7Zk=;
	b=S/GwLbmn3qKwx0KN9nxLxeqVEdiGo9YQqSxP/vTa38UIOXKGLMcUk65NXIHaOizghBafKF
	8YiX1plzZAoUS6fYVtEsC46Hz1kzC/DzSRDSRe7mNkUd1Wd+fA0NVz1sdMe2xmqpB1rD0a
	jO/lRnADuribuIzpcfJrOQW0sz92gaU=
Subject: Re: [PATCH] xen/pciback: fix typo in a comment
To: Jason Wang <wangborong@cdjrlc.com>
Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20211212032408.52180-1-wangborong@cdjrlc.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <68aa97ae-dd76-5879-3dba-a08c3581f25b@suse.com>
Date: Wed, 15 Dec 2021 09:55:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211212032408.52180-1-wangborong@cdjrlc.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="MtKaboN7PRCVbLi20XvpiHLMkP7wJh3Dt"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MtKaboN7PRCVbLi20XvpiHLMkP7wJh3Dt
Content-Type: multipart/mixed; boundary="GorFHiUnBwJkF0gcj3A7cXL8s8u8YTG3J";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org,
 xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Message-ID: <68aa97ae-dd76-5879-3dba-a08c3581f25b@suse.com>
Subject: Re: [PATCH] xen/pciback: fix typo in a comment
References: <20211212032408.52180-1-wangborong@cdjrlc.com>
In-Reply-To: <20211212032408.52180-1-wangborong@cdjrlc.com>

--GorFHiUnBwJkF0gcj3A7cXL8s8u8YTG3J
Content-Type: multipart/mixed;
 boundary="------------FB1518124BAB239808CC7C2F"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------FB1518124BAB239808CC7C2F
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 12.12.21 04:24, Jason Wang wrote:
> The double `the' in the comment in line 163 is repeated. Remove it
> from the comment.
>=20
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
>   drivers/xen/xen-pciback/pciback_ops.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pc=
iback/pciback_ops.c
> index 3fbc21466a93..e38b43b5065e 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *p=
dev,
>   	}
>  =20
>   	/* The value the guest needs is actually the IDT vector, not the
> -	 * the local domain's IRQ number. */
> +	 * local domain's IRQ number. */

When touching this comment, would you mind to correct its style, too?
It should have a leading "/*" and a trailing "*/" line like e.g. in
line 72 of the same source file.


Juergen

--------------FB1518124BAB239808CC7C2F
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------FB1518124BAB239808CC7C2F--

--GorFHiUnBwJkF0gcj3A7cXL8s8u8YTG3J--

--MtKaboN7PRCVbLi20XvpiHLMkP7wJh3Dt
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG5rYsFAwAAAAAACgkQsN6d1ii/Ey8x
mwf+ISB1pg5TvxP1/6a20M2SKwjPP+lmaGU3qJ9bCJidSAUBQgbvJj+sq/r5LWnrEdD9i7IlAj9K
JUfRRxnrDwWHUW5OO89hvhDnN1zG1pMJam6dQH76VP4nrtiYOR1pOQMIj3dkAP/iKOvFl+b9wNrJ
foiq3OYM+Gu/KPX5H3JHU2GM98EdGT0+wMDjrc+vlSwMBvG+zEgRVX5kso1f49EuS2+Oh2yEytdR
U/NfwdKfPoqLt7EacFdaXP5uWdqEs4YFZXh+MVgNV4X8ZmSXt4JrW70DVZjAfmQnifriVWZOaB2e
9Z7pXr3Ahy9yox29XewCMgTDXTfT2jzIt/KfZQIj6w==
=UUpl
-----END PGP SIGNATURE-----

--MtKaboN7PRCVbLi20XvpiHLMkP7wJh3Dt--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:06:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:06:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247256.426310 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQF6-0000RW-4G; Wed, 15 Dec 2021 09:06:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247256.426310; Wed, 15 Dec 2021 09:06:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQF6-0000RP-0F; Wed, 15 Dec 2021 09:06:32 +0000
Received: by outflank-mailman (input) for mailman id 247256;
 Wed, 15 Dec 2021 09:06:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxQF4-0000RF-Fr; Wed, 15 Dec 2021 09:06:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxQF4-0007q3-7T; Wed, 15 Dec 2021 09:06:30 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxQF3-0003vu-Tk; Wed, 15 Dec 2021 09:06:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxQF3-0004oY-T0; Wed, 15 Dec 2021 09:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=W3z/JrtxjDULDngztKVJqQJ9Gp9eU3/kU8bKZG8tUho=; b=xhzbldmwvubAPcIL09uHeq+o1k
	bwzwgEP3cD1GYPH992W1fYk772AWONij/StZECg4bG0CCl/ErxFsVV0GXh8K1afQJhkG3YTr5Rik0
	v8dmv/r3J/FBTPDTDmlcpPAc0j6K+K1n2jojP3TaysQppaV6yTtofKniXaJsB5vOjwl0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167417-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167417: regressions - FAIL
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:regression
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=af1719795c888938855b412b33192dfc7072962d
X-Osstest-Versions-That:
    qemuu=a3607def89f9cd68c1b994e1030527df33aa91d0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 09:06:29 +0000

flight 167417 qemu-mainline real [real]
flight 167424 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167417/
http://logs.test-lab.xenproject.org/osstest/logs/167424/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail REGR. vs. 167228

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167228

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167228
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167228
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167228
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167228
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167228
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167228
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167228
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167228
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                af1719795c888938855b412b33192dfc7072962d
baseline version:
 qemuu                a3607def89f9cd68c1b994e1030527df33aa91d0

Last test of basis   167228  2021-12-08 05:42:12 Z    7 days
Testing same since   167417  2021-12-14 21:09:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit af1719795c888938855b412b33192dfc7072962d
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Tue Dec 14 12:40:12 2021 -0800

    Open 6.3 development tree
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

commit 44f28df24767cf9dca1ddc9b23157737c4cbb645
Author: Richard Henderson <richard.henderson@linaro.org>
Date:   Tue Dec 14 12:35:01 2021 -0800

    Update version for v6.2.0 release
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:21:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:21:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247265.426323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQSz-00032S-Go; Wed, 15 Dec 2021 09:20:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247265.426323; Wed, 15 Dec 2021 09:20:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQSz-00032L-Dr; Wed, 15 Dec 2021 09:20:53 +0000
Received: by outflank-mailman (input) for mailman id 247265;
 Wed, 15 Dec 2021 09:20:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxQSx-00032C-Ux
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:20:51 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQSt-00085a-PN; Wed, 15 Dec 2021 09:20:47 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQSt-0002o7-Ig; Wed, 15 Dec 2021 09:20:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=OCQYv43R9XULZPs9AF1DXysbDDo+UclFveHYvBtLyxA=; b=mQgzMWgqd7YuUXGq3RlD/2SYwm
	aNnIc8OfI83iDq79CGekBtJ0yez+j1Yg6pnZKD7Sap9su2Bn4idtCqfJzCqV7Si4L0+ZRDEit9q1T
	C1fNn2Yo4I3FslAcO8Ycy1xZux4suPWvQm7Ov3HF1u1fOeCI7DqLOyU9FDMpZD8T2BKk=;
Message-ID: <10dff775-9890-0ecb-6b71-f61893051ad2@xen.org>
Date: Wed, 15 Dec 2021 09:20:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-15-anthony.perard@citrix.com>
 <bcca6950-666f-63ea-9ea2-49f70d8a252a@xen.org>
 <cd636560-dcc3-1035-43cd-2813f5978333@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <cd636560-dcc3-1035-43cd-2813f5978333@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 15/12/2021 07:49, Jan Beulich wrote:
> On 14.12.2021 18:05, Julien Grall wrote:
>> On 25/11/2021 13:39, Anthony PERARD wrote:
>>> For two reasons: this macro is used to generate a "linker script" and
>>> is not by the linker, and name starting with an underscore '_' are
>>> supposed to be reserved, so better avoid them when not needed.
>>
>> If that's the case, then shouldn't we also rename __ASSEMBLY__?
> 
> I'd rather not - unlike __LINKER__ (afaict at least) __ASSEMBLY__

I can't remember where I took __LINKER__ from.

> is a commonly used identifier (which we've actually inherited from
> Linux)

Fair enough.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:28:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:28:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247271.426338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQZk-0003jP-92; Wed, 15 Dec 2021 09:27:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247271.426338; Wed, 15 Dec 2021 09:27:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQZk-0003jI-60; Wed, 15 Dec 2021 09:27:52 +0000
Received: by outflank-mailman (input) for mailman id 247271;
 Wed, 15 Dec 2021 09:27:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4xGT=RA=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxQZj-0003jC-H3
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:27:51 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 44e26bde-5d89-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 10:27:49 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 794E26D;
 Wed, 15 Dec 2021 01:27:48 -0800 (PST)
Received: from [10.57.5.111] (unknown [10.57.5.111])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F41D3F5A1;
 Wed, 15 Dec 2021 01:27:47 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 44e26bde-5d89-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
Date: Wed, 15 Dec 2021 10:27:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Replying to both Julien and Jan,

On 14.12.2021 12:30, Julien Grall wrote:
> 
> 
> On 14/12/2021 11:01, Julien Grall wrote:
>> Hi,
>>
>> Replying in one e-mail the comments from Jan and Michal.
>>
>> On 14/12/2021 10:01, Jan Beulich wrote:
>>> On 14.12.2021 10:51, Michal Orzel wrote:
>>>> Hi Julien,
>>>>
>>>> On 14.12.2021 10:33, Julien Grall wrote:
>>>>>
>>>>>
>>>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>>>> Hi Julien, Jan
>>>>>
>>>>> Hi,
>>>>>
>>>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>>>> Hi Julien,
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>
>>>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>>>
>>>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>>>
>>>>>>>>>> Ok.
>>>>>>>>>>>>
>>>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>>>>> needs to be fixed.
>>>>>>>>>>>
>>>>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>>>>
>>>>>>>>>> I would say:
>>>>>>>>>> "
>>>>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>>>> "
>>>>>>>>>>>>
>>>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>
>>>>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>>>>> when not passed.
>>>>>>>>>>>
>>>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>>>
>>>>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>>>>> ```
>>>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>>>> ```
>>>>>>>>>
>>>>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>>>>> wrong entry.
>>>>>>>>>
>>>>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>>>
>>>>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>>>>> then merely extend to
>>>>>>>>
>>>>>>>> .if !0\hyp && 0\compat
>>>>>>> Isn't it effectively the same as setting a default value?
>>>>>>>
>>>>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>>>>
>>>>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>>>>
>>>>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>>>>
>>>>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>>>
>>>>>>>> or something along those lines.
>>>>>>>>
>>>>>>>> Jan
>>>>>>>>
>>>>>>>
>>>>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>>>>> stp wzr, wzr, [sp #8 * 0]
>>>>>> stp wzr, wzr, [sp #8 * 1]
>>>>>> ...
>>>>>
>>>>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>>>>
>>>> I hope you meant str and not ldr.
>>
>> Yes. I am not sure why I wrote ldr.
>>
>>>> So a loop would look like that:
>>>> str wzr, [sp, #8 * 1]
>>>> str wzr, [sp, #8 * 3]
>>>> ...
>>>
>>> Why "a loop" and why #8 (I'd have expected #4)?
>>>
>>> There's another oddity which I'm noticing only now, but which also
>>> may look odd to me only because I lack sufficient Arm details: On
>>> x86, it would not be advisable to store anything below the stack
>>> pointer (like is done here when storing x0 and x1 early), unless
>>> it's absolutely certain that no further interruptions could clobber
>>> that part of the stack.
>>
>> We are entering the hypervisor with both Interrupts and SErrors masked. They will only be unmasked after the guest registers have been saved on the stack.
>>
>> You may still receive a Data Abort before the macro 'entry' has completed. But this is going to result to an hypervisor crash because they are not meant to happen in those paths.
>>
>> So I believe, we are safe to modify sp before.
> 
> Hmmm... I meant to write on the stack before sp is modified.
> 
> Cheers,
> 

I would like to summarize what we discussed before pushing v2.
Changes since v1:
-update commit message adding information why do we need to zero top 32bits
-zero corresponding stack slots instead of zeroing directly gp registers
-create a macro called by entry, protected by if hyp=0. In macro add if compat=1

Now when it comes to implementation.

1. Regarding save_x0_x1, it is 0 only for guest_sync_slowpath, which is called by guest_sync.
So as we are dealing only with compat=1, save_x0_x1 cannot be 0.
The conclusion is that we do not need to worry about it.

2. Regarding clearing high halves of stack slots.
The new macro (called zero_stack_top_halves) will be called in entry before the first instruction sub sp,sp.
To avoid saving sp position/moving it, the simplest would be to execute 30 times:
str wzr, [sp, #-(UREGS_kernel_sizeof - 4)]
str wzr, [sp, #-(UREGS_kernel_sizeof - 12)]
...
I could also use .irp loop like (.irp n,1,3,5,7,...) and then:
str wzr, [sp, #-(UREGS_kernel_sizeof - (4 * n))]
but FWIK Jan does not like loops :)

Let me know what u think.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:35:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:35:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247284.426381 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQgv-0005d6-H3; Wed, 15 Dec 2021 09:35:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247284.426381; Wed, 15 Dec 2021 09:35:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQgv-0005cz-Dy; Wed, 15 Dec 2021 09:35:17 +0000
Received: by outflank-mailman (input) for mailman id 247284;
 Wed, 15 Dec 2021 09:35:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=E5lv=RA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxQgu-0005ct-64
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:35:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4e061dbf-5d8a-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 10:35:14 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-CshbxS03OxKBEdvM7iIo_Q-1; Wed, 15 Dec 2021 10:35:12 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4846.eurprd04.prod.outlook.com (2603:10a6:803:5b::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 09:35:10 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 09:35:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4e061dbf-5d8a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639560913;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tiWYUneSy5SMM7B4blqAl0KhY4d7zmQhARRK4bkn8Qs=;
	b=X8hyjeLQeF5pUeE0LMHoZMswF4invV5u6QH8C9T54wPWqY7pj6nCuViSJeCNeTZ2Yh/ru6
	yxh7dUvL7iYIIJlpIM1o4wOmHVd9A3pCeLuJfL5qLfAWhwz4y6f15dDhCUgjO2ed9+fhqA
	C+1JWXTUaRoPnbRcIV6cQX64DlhxY7U=
X-MC-Unique: CshbxS03OxKBEdvM7iIo_Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aolIeHx9lwJgi3SHVMVAQvnXoHjbJq1qLZpwK+n9CPfkQRdRGcr2RBLheu8utag9z7WDNp3TZQlSd+iAevcFMZF3wZXP9qszypTeyapb4yFzKwUri2dHuYk7AwFidb6hojaKi+GbnnWsC3xSPwlDUHAzsS0KGSauiQubKUQ9bWfda3PhOqtQqcfdYz/O41WOZehEMgGuokRi8e2TWaW1PI8KUOo4C69uXlupxEqFitoimmzxSPKAxxqKx2N/GIYpbUM7xJQgoe17SKsJYC3+FuvIvYinVjnvZWnhmGFN5MQRnINSiWNZZjWnBFrba39fODhERlNNvWL2RYGvFuXF6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tiWYUneSy5SMM7B4blqAl0KhY4d7zmQhARRK4bkn8Qs=;
 b=QG5QvYSl1qwTnPbw9QgznyxbcqzcuyCUZ9Ge2REcdsVbVUgu2ppw1nStdXFJj1Zg0VgwNh+hhIM0h6dkP4wL5Ar3845efoQM70sPaJrrRexV5rEZkw90Ba8LozwjTY6mVgsEsrrXX0mpJ2sj2R0/CRxKU9TDTZz+ylalkxvLRm1z+HeM2ts7N8yUPOS7tpWC4DO0e4k8NFfB1gJZPhiAfVunR2vR1qaYlT6kcAC/FHrBt+jnWjfrdTDtT/kzPlnHR/eKbo3HsEUeK2/vnGi+kN+VCiPY9eM2atRKokBLPxQqf/t1NSlgiwliYVeYn3LFcQIVEN5R5B4My3Aspb6wZA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
Date: Wed, 15 Dec 2021 10:35:07 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0098.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::39) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8c5ff4b0-9788-4dea-c352-08d9bfae2fef
X-MS-TrafficTypeDiagnostic: VI1PR04MB4846:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4846D7666F76C256B429516FB3769@VI1PR04MB4846.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Sbr0nuFvwVUU1ZQpixtKOJ2c80ipjhNR1WaAjPFCGLv3qQSqo70o/JFt40Myvoz6i01PLdQRqXAyBs+HTUStG75bQfOlWyVV2U5Q/IlT6hPxTaDlSO8rKkBtH9Z0guKok+fXdbb1NF9k4Ql2Dc++Id3XcGzV85DKGYSGyCYWhslvb4XvJWaMt5fXxgF1ez0JPAf1H7bHOKytkTdSQ/cRB93u+hEkyRMH7KLA19Xw5LkjYBcsf9jyuDH3OUDbQAqDla8DIxjyoB9p8qMMvidJeuXhZa/vUT3eEhyfo87ZyzSrZsaC2msubDOeMtN7ovrRwfnGGcYcm0tQJGEawSXh/RFx6DGaBiOkF046GO4jbPrDCSd9eGu/Kdwd+aLY2JKrD4A188MFpY1GgECv8w17RuTUVs13Ya5j/weJNxbSrEzLY/OfNiKOCTtQ4Uz0d5mOKa41BpKdT3kcnxulB9B1hlgD135DS/DjOZXuvZdKsAvzUmZhktt4ZN7R6Cw6Gf4CQtFlRtfu4/5H6pCNt0H4I2vL0QDdSEd/+w+lOc1FjLq+f82/FEhM/ME1t/UI3itDtZyC6YKmeEuPiJgT6mcncmabVxsS83y2xHSuulJgFaHWyK7XgEWrB2mivpWh2mQwgdG/Xq3kM4PkHGnBVG7v1YzvfPJOQ8RK0gl7Vi1a1c7O2tNj1YpLhPBSogiu+9RcFVwPxYaBvaXmqF19gwDBXj6PIwN4JMRToVKucI+yP7A=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6506007)(36756003)(53546011)(6486002)(54906003)(31686004)(316002)(6916009)(26005)(8936002)(6512007)(186003)(8676002)(5660300002)(508600001)(31696002)(2906002)(2616005)(6666004)(4326008)(38100700002)(83380400001)(86362001)(66556008)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTB4S0ZZRm53QjFoYVYxc1lZekl6RU4ybEwvaVR2SDVrWklJUlBYaEMvWStk?=
 =?utf-8?B?MytXT3NWYUwza0hjK3N4NzVsWEhBOENZNjZSdWJwMC92MDF2SE11N1grSWp2?=
 =?utf-8?B?OXJ1MTZDd290c0Foc0Q2bStJY2xXU3lYOTVaa2tEMjdRcTRIMTVkblROVDBu?=
 =?utf-8?B?SzFaVFp4elhGS3FDOW9vd25QM1lKMm5ya08yRXFPYWNYMmVvemRJZ01RNUxH?=
 =?utf-8?B?NmRTUktCdis1a3dHanZHNTNBRDBmenFxQ2dCL0t5LzRJdmh3eCtiOUY2ei9T?=
 =?utf-8?B?N1BVVnJRWkM4aGVlc0R5TWNmT1QwajZ4OUd5UkY4V01lcDgreW5oNEFLK1A2?=
 =?utf-8?B?WCtUQkZpbHBOK001QVpWWUEvbnQ1OVpsZy96Y3N5bXhRWFNsc2NoY1gyZWRG?=
 =?utf-8?B?eVd1b01rMjhFTkkrc3kwNTZlQzN6b1QwVW1LQloxd0h5aFV1T3Y5eXU3b2hI?=
 =?utf-8?B?NTYxM09wam1CczFrWkpsN2dPalQvUWdYK3ozOW5NZUdmb0FXcHI5UUpIaThI?=
 =?utf-8?B?WnRDOTNtM3dpWXpYZ0pZVEJBeDVINEpLWGRvcEdtekdWT3Y3WWdTTG8vVWFk?=
 =?utf-8?B?SFZoR0FFTno5QkM3SURraGRuUVd0UEZVdkdscUFaSnhOeFRiOVp0TytsTzVO?=
 =?utf-8?B?bzBZb3NicC90b0NWOFFQVFVqa0dKNjJpUGxrUnRyc2I3WlNxZFBwdCsxYnJI?=
 =?utf-8?B?WkRFV2FrVWxOMlBTTFpSdlQwVGlxcnc1emdZMlJkKzh2MVMzNjhWUXZBOERs?=
 =?utf-8?B?amNkdTZKV2JMbXZJL0tyeWxaQnlKRkQxYnhyNVNFUitzU3lmTW5JWlZIK24x?=
 =?utf-8?B?NWdNNENzc0V3a1ZGeFNyNU9GVk80UXc5OTRZa2g1bXZNQUx5ZExJb2Y5WkRQ?=
 =?utf-8?B?NjZlSXlHVmFsSHVVZTIvaFFMblBSeGV2TEdyT1pxYktsbUlCcytOTHVWKzVE?=
 =?utf-8?B?RzVhVDIxdVBkdFZBdkcyUWtDQjAvMmF2dUU2YVpSL0Z6MURTLzY3VkNzOHV2?=
 =?utf-8?B?ajkvT1BqRGlUK1NEeFk3ZSs2dlkydHRVZ1lQYVNzSDkvejlxcCtjc2M5dEtU?=
 =?utf-8?B?bFhYY3ZQcWpBRnEyMzcyL2ZkQVpOeVlaQ2NSM0dTcDdMTlk4eFd5Mi8yZjcr?=
 =?utf-8?B?ajBuY08vNnNZZXdSZ1lFendUaWdMYXljQ01aR1RRVVkvN3JJWE5QbzBPRHRu?=
 =?utf-8?B?Y0NRaHRXVEVwWnJHNzcwSDJtZWpEV0crQkxwSHl5ekJ4Y3Yzbi9VUW9JMjc0?=
 =?utf-8?B?ZTFqbGtJUFFCdFNtbnZBZTNXZ2grdjRXZ0N0TmpFZHRqMGprd3ZVN041Yjk4?=
 =?utf-8?B?SzcxVnRiYU41Y1B2ems3R2sxZlF3aUkvMUNiUkdEM1lHR0prcWpYZWQ3ZlZh?=
 =?utf-8?B?SFg3cHZXQThiUSsrYW5CWlJiN05xOHpCMlRuWjYzTzN2Rm9oWWpEZHdveTNQ?=
 =?utf-8?B?eU8xc1pqUUxIRGlwTU1mbi9NUzluV0t5Z042YmRCR1JNOHlqMDJhbjRDa1Rp?=
 =?utf-8?B?VncyQ1BLcVZaZ0FzemE4S0lGMHRlV2NxdGtac29Hcno0b3BRaUNkc1kyaXRC?=
 =?utf-8?B?STlGR2VTWm9ZRWIrM1hhNUNGMXZoOENjQVVtOG1iTkc4eFp0YStJQmVKUFUx?=
 =?utf-8?B?c1NyMXJzWmF6VktBQ3BhZzl4OHNuYkFRSmp3UXlXcmFoeFlZajBSUlJJais3?=
 =?utf-8?B?dUtDdFc2Y1hVZ3pHWnRVc2tPS0djc1RtZ1l1dU4vQlBaMjRyQll1V1RWdWhD?=
 =?utf-8?B?V2JmTDJjUnkycjZTUUZaM3dLVGpsdmtkZUVSZkIrUXhJSXdJZkFyYTE3Q3dN?=
 =?utf-8?B?ZUdFSVhrN05USGhaZ3luOTJMYmhaVjFhWEpRNFZTbEdIa2NabHFQYURMWk1m?=
 =?utf-8?B?NzUzaVA4OWd3c01xZUtaL2k0TXVvVWZRazF3dEFMdEZvSHh4ejdXRHJhcEJX?=
 =?utf-8?B?elo0Y0pXelY5VXA3cWFJUGE5ZTBZM0VPZnpMR2NkOHppRUYvRzVqN2ptODlB?=
 =?utf-8?B?M0k1cnQ2bW14TWFNSzd2WG1MdG5KRGZ4N3hxM2RPMkJzdk1IUUVBR0JhelFV?=
 =?utf-8?B?cHQvRGsxSDFRWnJuWTIzN25GZDVnREREODlaSmQ4cjJhalMvS20wMXA2Mlkr?=
 =?utf-8?B?aDRyTDNiK0NGN2lNYzVYT1Z3TWZKRzJQcDZVZ2g1RGpuOU4xL1BjOFhBcWN4?=
 =?utf-8?Q?rzEgGMWnXnGlebdPM76y2B8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c5ff4b0-9788-4dea-c352-08d9bfae2fef
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 09:35:10.0801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t80zkGj0LGvsIM7AZ76hAOTZqe3djwMGBxZH27xBYjU2gm0jrNRTmHdDYFWSWne55CXOamG2AL0SBJEmYhMmnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4846

On 15.12.2021 10:27, Michal Orzel wrote:
> Replying to both Julien and Jan,
> 
> On 14.12.2021 12:30, Julien Grall wrote:
>>
>>
>> On 14/12/2021 11:01, Julien Grall wrote:
>>> Hi,
>>>
>>> Replying in one e-mail the comments from Jan and Michal.
>>>
>>> On 14/12/2021 10:01, Jan Beulich wrote:
>>>> On 14.12.2021 10:51, Michal Orzel wrote:
>>>>> Hi Julien,
>>>>>
>>>>> On 14.12.2021 10:33, Julien Grall wrote:
>>>>>>
>>>>>>
>>>>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>>>>> Hi Julien, Jan
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>>>>> Hi Julien,
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>>
>>>>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>>>>
>>>>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>>>>
>>>>>>>>>>> Ok.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>>>>>> needs to be fixed.
>>>>>>>>>>>>
>>>>>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>>>>>
>>>>>>>>>>> I would say:
>>>>>>>>>>> "
>>>>>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>>>>> "
>>>>>>>>>>>>>
>>>>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>>>>>> when not passed.
>>>>>>>>>>>>
>>>>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>>>>
>>>>>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>>>>>> ```
>>>>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>>>>> ```
>>>>>>>>>>
>>>>>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>>>>>> wrong entry.
>>>>>>>>>>
>>>>>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>>>>
>>>>>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>>>>>> then merely extend to
>>>>>>>>>
>>>>>>>>> .if !0\hyp && 0\compat
>>>>>>>> Isn't it effectively the same as setting a default value?
>>>>>>>>
>>>>>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>>>>>
>>>>>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>>>>>
>>>>>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>>>>>
>>>>>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>>>
>>>>>>>>> or something along those lines.
>>>>>>>>>
>>>>>>>>> Jan
>>>>>>>>>
>>>>>>>>
>>>>>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>>>>>> stp wzr, wzr, [sp #8 * 0]
>>>>>>> stp wzr, wzr, [sp #8 * 1]
>>>>>>> ...
>>>>>>
>>>>>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>>>>>
>>>>> I hope you meant str and not ldr.
>>>
>>> Yes. I am not sure why I wrote ldr.
>>>
>>>>> So a loop would look like that:
>>>>> str wzr, [sp, #8 * 1]
>>>>> str wzr, [sp, #8 * 3]
>>>>> ...
>>>>
>>>> Why "a loop" and why #8 (I'd have expected #4)?
>>>>
>>>> There's another oddity which I'm noticing only now, but which also
>>>> may look odd to me only because I lack sufficient Arm details: On
>>>> x86, it would not be advisable to store anything below the stack
>>>> pointer (like is done here when storing x0 and x1 early), unless
>>>> it's absolutely certain that no further interruptions could clobber
>>>> that part of the stack.
>>>
>>> We are entering the hypervisor with both Interrupts and SErrors masked. They will only be unmasked after the guest registers have been saved on the stack.
>>>
>>> You may still receive a Data Abort before the macro 'entry' has completed. But this is going to result to an hypervisor crash because they are not meant to happen in those paths.
>>>
>>> So I believe, we are safe to modify sp before.
>>
>> Hmmm... I meant to write on the stack before sp is modified.
>>
>> Cheers,
>>
> 
> I would like to summarize what we discussed before pushing v2.
> Changes since v1:
> -update commit message adding information why do we need to zero top 32bits
> -zero corresponding stack slots instead of zeroing directly gp registers
> -create a macro called by entry, protected by if hyp=0. In macro add if compat=1
> 
> Now when it comes to implementation.
> 
> 1. Regarding save_x0_x1, it is 0 only for guest_sync_slowpath, which is called by guest_sync.
> So as we are dealing only with compat=1, save_x0_x1 cannot be 0.
> The conclusion is that we do not need to worry about it.

Oh, good point. I guess you may want to add a build time check to
avoid silently introducing a user of the macro violating that
assumption.

> 2. Regarding clearing high halves of stack slots.

I don't think I understood earlier responses that way. I think
fiddling with the stack was meant solely for x0 and x1 when they
were saved earlier on (i.e. instead of re-loading, zero-extending,
and then storing them back). That's also why ...

> The new macro (called zero_stack_top_halves) will be called in entry before the first instruction sub sp,sp.
> To avoid saving sp position/moving it, the simplest would be to execute 30 times:
> str wzr, [sp, #-(UREGS_kernel_sizeof - 4)]
> str wzr, [sp, #-(UREGS_kernel_sizeof - 12)]
> ...
> I could also use .irp loop like (.irp n,1,3,5,7,...) and then:
> str wzr, [sp, #-(UREGS_kernel_sizeof - (4 * n))]
> but FWIK Jan does not like loops :)

... in an earlier reply I expressed my surprise of you mentioning
loops - I simply didn't see how a loop would come into play when
dealing with just x0 and x1.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:39:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:39:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247292.426391 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQl6-0006To-85; Wed, 15 Dec 2021 09:39:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247292.426391; Wed, 15 Dec 2021 09:39:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQl6-0006Th-4q; Wed, 15 Dec 2021 09:39:36 +0000
Received: by outflank-mailman (input) for mailman id 247292;
 Wed, 15 Dec 2021 09:39:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxQl5-0006Tb-41
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:39:35 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQl4-0008S3-M1; Wed, 15 Dec 2021 09:39:34 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQl4-0004Ou-Bn; Wed, 15 Dec 2021 09:39:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Tmal6A7zHVQ6hD/i5vkcSVJU+yGxCgWMiNpa62MSAaA=; b=g3ujYxtperrrR+0zH/FSRA/LuA
	mwhL5y53ifcZ2V6USur3LaQRfrtjjnMbq8KvrSJQi8kQd3VP6fe4iKAWkLOhES2HSkLiYVRZCo2C+
	YU9KC4h/EM9vxyDNy4X3EvPQ3sXrYBW8XXTYU2Uh32u6WISKN7WAYyUAu+XuDx9uHSPc=;
Message-ID: <35435638-a132-1b46-6add-b923f9f2785f@xen.org>
Date: Wed, 15 Dec 2021 09:39:32 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 14/12/2021 09:34, Oleksii Moisieiev wrote:
> Implementation includes platform-specific smc handler for rcar3 platform.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   xen/arch/arm/platforms/Makefile |  1 +
>   xen/arch/arm/platforms/rcar3.c  | 46 +++++++++++++++++++++++++++++++++
>   2 files changed, 47 insertions(+)
>   create mode 100644 xen/arch/arm/platforms/rcar3.c
> 
> diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
> index 8632f4115f..b64c25de6c 100644
> --- a/xen/arch/arm/platforms/Makefile
> +++ b/xen/arch/arm/platforms/Makefile
> @@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) += exynos5.o
>   obj-$(CONFIG_ALL32_PLAT) += midway.o
>   obj-$(CONFIG_ALL32_PLAT) += omap5.o
>   obj-$(CONFIG_ALL32_PLAT) += rcar2.o
> +obj-$(CONFIG_RCAR3) += rcar3.o
>   obj-$(CONFIG_ALL64_PLAT) += seattle.o
>   obj-$(CONFIG_ALL_PLAT)   += sunxi.o
>   obj-$(CONFIG_ALL64_PLAT) += thunderx.o
> diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.c
> new file mode 100644
> index 0000000000..d740145c71
> --- /dev/null
> +++ b/xen/arch/arm/platforms/rcar3.c
> @@ -0,0 +1,46 @@
> +/*
> + * xen/arch/arm/platforms/rcar3.c
> + *
> + * Renesas R-Car Gen3 specific settings
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021 EPAM Systems
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/platform.h>
> +
> +static bool rcar3_smc(struct cpu_user_regs *regs)
> +{
> +    return false;
> +}

Looking at the rest of the series, this is going to be replaced in patch 
#2 with:

return sci_handle_call();

SCMI is not specific to RCAR3. So I would expect the function to be 
called from common code.

If it still needs some platform specific code, then I think it would be 
best to introduce rcar3.c at the end of the series. So we don't 
introduce a dummy platform and not hook the code in the middle of 
patch#2 which is meant to be generic.

I will have a proper review of the rest of the series in the new year.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:40:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:40:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247295.426403 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQmH-0007ld-IV; Wed, 15 Dec 2021 09:40:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247295.426403; Wed, 15 Dec 2021 09:40:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQmH-0007lW-F0; Wed, 15 Dec 2021 09:40:49 +0000
Received: by outflank-mailman (input) for mailman id 247295;
 Wed, 15 Dec 2021 09:40:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxQmG-0007lK-73
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:40:48 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQmF-0008Sv-OG; Wed, 15 Dec 2021 09:40:47 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxQmF-0004Tr-Gi; Wed, 15 Dec 2021 09:40:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=QTqsXTRgholLSboenw5XLI8MHw4DOIR4Wf5YAshPVqE=; b=bVtQ63DoKIQUZ9MN5kDyhw9weW
	QISoMVc+7QWWM39Y7mIX3D33oCWABQ5CFGy56mZp5lkM/62sqBs8+vQ7SiS4gCfxs9GXogVbqg/AL
	MymSkQT7UdoQg9Efj2vfuu5DeLeb61xrgmxBKUXFIJaxj+Jm08ae9OEZodiAghMhCybw=;
Message-ID: <89d039a4-bf48-cc2b-5055-15441af2090a@xen.org>
Date: Wed, 15 Dec 2021 09:40:45 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 01/13] xen: move do_vcpu_op() to arch specific code
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-2-jgross@suse.com>
 <1ce9aa8a-adc2-18cb-2c06-8a8a63c3b774@xen.org>
 <3af8127b-36b6-b810-3060-313736ce1735@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3af8127b-36b6-b810-3060-313736ce1735@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Juergen,

On 15/12/2021 07:12, Juergen Gross wrote:
> On 14.12.21 18:21, Julien Grall wrote:
>> Hi Juergen,
>>
>> On 08/12/2021 15:55, Juergen Gross wrote:
>>> Today Arm is using another entry point for the vcpu_op hypercall as
>>
>> NIT: The 'as' doesn't sound right here. Did you mean 'compare to'?
> 
> Hmm, it should even be "different" instead of "another". And then it
> should be:
> 
>    The entry point used for the vcpu_op hypercall on Arm is different
>    from the one on x86 today.

LGTM.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:49:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:49:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247302.426413 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQu8-0008UQ-CV; Wed, 15 Dec 2021 09:48:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247302.426413; Wed, 15 Dec 2021 09:48:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxQu8-0008UJ-9e; Wed, 15 Dec 2021 09:48:56 +0000
Received: by outflank-mailman (input) for mailman id 247302;
 Wed, 15 Dec 2021 09:48:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4xGT=RA=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxQu7-0008UD-CO
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:48:55 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 3660c4a5-5d8c-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 10:48:53 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 963A66D;
 Wed, 15 Dec 2021 01:48:52 -0800 (PST)
Received: from [10.57.5.111] (unknown [10.57.5.111])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B3403F5A1;
 Wed, 15 Dec 2021 01:48:51 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3660c4a5-5d8c-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
Date: Wed, 15 Dec 2021 10:48:45 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 15.12.2021 10:35, Jan Beulich wrote:
> On 15.12.2021 10:27, Michal Orzel wrote:
>> Replying to both Julien and Jan,
>>
>> On 14.12.2021 12:30, Julien Grall wrote:
>>>
>>>
>>> On 14/12/2021 11:01, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> Replying in one e-mail the comments from Jan and Michal.
>>>>
>>>> On 14/12/2021 10:01, Jan Beulich wrote:
>>>>> On 14.12.2021 10:51, Michal Orzel wrote:
>>>>>> Hi Julien,
>>>>>>
>>>>>> On 14.12.2021 10:33, Julien Grall wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 14/12/2021 09:17, Michal Orzel wrote:
>>>>>>>> Hi Julien, Jan
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>> On 08.12.2021 10:55, Julien Grall wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On 08/12/2021 07:20, Jan Beulich wrote:
>>>>>>>>>> On 07.12.2021 20:11, Julien Grall wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 07/12/2021 08:37, Michal Orzel wrote:
>>>>>>>>>>>> Hi Julien,
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>>> On 06.12.2021 16:29, Julien Grall wrote:
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 06/12/2021 14:20, Michal Orzel wrote:
>>>>>>>>>>>>>> to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>>>
>>>>>>>>>>>> I will change to "from AArch32 state".
>>>>>>>>>>>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>>>>>>>>>>>> "If the general-purpose register was accessible from AArch32 state the
>>>>>>>>>>>>>> upper 32 bits either become zero, or hold the value that the same
>>>>>>>>>>>>>> architectural register held before any AArch32 execution.
>>>>>>>>>>>>>> The choice between these two options is IMPLEMENTATIONDEFINED"
>>>>>>>>>>>>>
>>>>>>>>>>>>> Typo: Missing space between IMPLEMENTATION and DEFINED.
>>>>>>>>>>>>>
>>>>>>>>>>>> Ok.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>>>>>>>>>>>> needs to be fixed.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Can you outline why this is a problem and why we need to protect? IIRC, the main concern is Xen may misinterpret what the guest requested but we are not concerned about Xen using wrong value.
>>>>>>>>>>>>>
>>>>>>>>>>>> I would say:
>>>>>>>>>>>> "
>>>>>>>>>>>> The reason why this is a problem is that there are places in Xen where we assume that top 32bits are zero for AArch32 guests.
>>>>>>>>>>>> If they are not, this can lead to misinterpretation of Xen regarding what the guest requested.
>>>>>>>>>>>> For example hypercalls returning an error encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op would return -ENOSYS
>>>>>>>>>>>> if the command passed as the first argument was clobbered,
>>>>>>>>>>>> "
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Fix this bug by zeroing the upper 32 bits of these registers on an
>>>>>>>>>>>>>> entry to hypervisor when switching to AArch32 state.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Set default value of parameter compat of macro entry to 0 (AArch64 mode
>>>>>>>>>>>>>> as we are on 64-bit hypervisor) to avoid checking if parameter is blank
>>>>>>>>>>>>>> when not passed.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Which error do you see otherwise? Is it a compilation error?
>>>>>>>>>>>>>
>>>>>>>>>>>> Yes, this is a compilation error. The errors appear at each line when "entry" is called without passing value for "compat".
>>>>>>>>>>>> So basically in all the places where entry is called with hyp=1.
>>>>>>>>>>>> When taking the current patch and removing default value for compat you will get:
>>>>>>>>>>>> ```
>>>>>>>>>>>> entry.S:254: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:258: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:258: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:262: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:262: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:266: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:266: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:278: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:278: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:292: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:292: Error: ".endif" without ".if"
>>>>>>>>>>>> entry.S:317: Error: symbol `.if' is already defined
>>>>>>>>>>>> entry.S:317: Error: ".endif" without ".if"
>>>>>>>>>>>> ```
>>>>>>>>>>>
>>>>>>>>>>> Thanks for input. I am concerned with your suggested approach (or using
>>>>>>>>>>> .if 0\compat as suggested by Jan) because they allow the caller to not
>>>>>>>>>>> properly specify compat when hyp=0. The risk here is we may generate the
>>>>>>>>>>> wrong entry.
>>>>>>>>>>>
>>>>>>>>>>> compat should need to be specified when hyp=1 as we will always run in
>>>>>>>>>>> aarch64 mode. So could we protect this code with hyp=0?
>>>>>>>>>>
>>>>>>>>>> Since my suggestion was only to avoid the need for specifying a default
>>>>>>>>>> for the parameter (which you didn't seem to be happy about), it would
>>>>>>>>>> then merely extend to
>>>>>>>>>>
>>>>>>>>>> .if !0\hyp && 0\compat
>>>>>>>>> Isn't it effectively the same as setting a default value?
>>>>>>>>>
>>>>>>>>> The reason we seem to get away is because other part of the macro (e.g. entry_guest) will need compat to be valid.
>>>>>>>>>
>>>>>>>>> But that seems pretty fragile to me. So I would prefer if the new code it added within a macro that is only called when hyp==0.
>>>>>>>>>
>>>>>>>> So you would like to have a macro that is called if hyp=0 (which means compat had to be passed) and inside this macro additional check if compat is 1?
>>>>>>>
>>>>>>> Yes. This is the only way I could think to avoid making 'compat'optional.
>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> or something along those lines.
>>>>>>>>>>
>>>>>>>>>> Jan
>>>>>>>>>>
>>>>>>>>>
>>>>>>>> So when it comes to zeroing the top 32bits by pushing zero to higher halves of stack slots I would do in a loop:
>>>>>>>> stp wzr, wzr, [sp #8 * 0]
>>>>>>>> stp wzr, wzr, [sp #8 * 1]
>>>>>>>> ...
>>>>>>>
>>>>>>> I don't think you can use stp here because this would store two 32-bit values consecutively. Instead, you would need to use ldr to store one 32-bit value at the time.
>>>>>>>
>>>>>> I hope you meant str and not ldr.
>>>>
>>>> Yes. I am not sure why I wrote ldr.
>>>>
>>>>>> So a loop would look like that:
>>>>>> str wzr, [sp, #8 * 1]
>>>>>> str wzr, [sp, #8 * 3]
>>>>>> ...
>>>>>
>>>>> Why "a loop" and why #8 (I'd have expected #4)?
>>>>>
>>>>> There's another oddity which I'm noticing only now, but which also
>>>>> may look odd to me only because I lack sufficient Arm details: On
>>>>> x86, it would not be advisable to store anything below the stack
>>>>> pointer (like is done here when storing x0 and x1 early), unless
>>>>> it's absolutely certain that no further interruptions could clobber
>>>>> that part of the stack.
>>>>
>>>> We are entering the hypervisor with both Interrupts and SErrors masked. They will only be unmasked after the guest registers have been saved on the stack.
>>>>
>>>> You may still receive a Data Abort before the macro 'entry' has completed. But this is going to result to an hypervisor crash because they are not meant to happen in those paths.
>>>>
>>>> So I believe, we are safe to modify sp before.
>>>
>>> Hmmm... I meant to write on the stack before sp is modified.
>>>
>>> Cheers,
>>>
>>
>> I would like to summarize what we discussed before pushing v2.
>> Changes since v1:
>> -update commit message adding information why do we need to zero top 32bits
>> -zero corresponding stack slots instead of zeroing directly gp registers
>> -create a macro called by entry, protected by if hyp=0. In macro add if compat=1
>>
>> Now when it comes to implementation.
>>
>> 1. Regarding save_x0_x1, it is 0 only for guest_sync_slowpath, which is called by guest_sync.
>> So as we are dealing only with compat=1, save_x0_x1 cannot be 0.
>> The conclusion is that we do not need to worry about it.
> 
> Oh, good point. I guess you may want to add a build time check to
> avoid silently introducing a user of the macro violating that
> assumption.
> 
>> 2. Regarding clearing high halves of stack slots.
> 
> I don't think I understood earlier responses that way. I think
> fiddling with the stack was meant solely for x0 and x1 when they
> were saved earlier on (i.e. instead of re-loading, zero-extending,
> and then storing them back). That's also why ...
> 
This patch and the problem it solves is about clearing top 32bits of all gp registers so not only x0,x1.

>> The new macro (called zero_stack_top_halves) will be called in entry before the first instruction sub sp,sp.
>> To avoid saving sp position/moving it, the simplest would be to execute 30 times:
>> str wzr, [sp, #-(UREGS_kernel_sizeof - 4)]
>> str wzr, [sp, #-(UREGS_kernel_sizeof - 12)]
>> ...
>> I could also use .irp loop like (.irp n,1,3,5,7,...) and then:
>> str wzr, [sp, #-(UREGS_kernel_sizeof - (4 * n))]
>> but FWIK Jan does not like loops :)
> 
> ... in an earlier reply I expressed my surprise of you mentioning
> loops - I simply didn't see how a loop would come into play when
> dealing with just x0 and x1.
> 
> Jan
> 

Michal


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 09:57:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 09:57:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247307.426424 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxR2d-0001eu-8o; Wed, 15 Dec 2021 09:57:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247307.426424; Wed, 15 Dec 2021 09:57:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxR2d-0001en-5I; Wed, 15 Dec 2021 09:57:43 +0000
Received: by outflank-mailman (input) for mailman id 247307;
 Wed, 15 Dec 2021 09:57:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxR2b-0001eh-OQ
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 09:57:41 +0000
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com
 [2a00:1450:4864:20::434])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 709c7e45-5d8d-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 10:57:40 +0100 (CET)
Received: by mail-wr1-x434.google.com with SMTP id s1so3018832wrg.1
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 01:57:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 709c7e45-5d8d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=a48mFvuUcnCIP9cUd4qhU8qQ0bb/d/xrOxAOQhxTyq8=;
        b=X3e3owUVcUqJYstARIdMCgY949jtyGhpYJV70LWkIO0Jf9SCF1lNOMBanK3cUt+cq2
         aoPjrs4uM2ZjBNKdYUcG2FxIR2Klx1cfi8T+FBCajQbvum4QoqHtyTk39KgVgdcsIxCC
         Q3pi3QxGJ7LBuWL5DjEpKQqS5/xIcVQidtwx1hiLd81Y429WS7Qex06ISXIYwfyI+5Lu
         YAzlnEPCVJFL0k7RbxrnEHo12nAXhMTFrEgydyIExkIOr5VYst5Bob7wka1fXRK3gnIA
         DErB6d6ndll7zrT6yW50nV5OvdmJj+jrxZitNHhwYgOiUDr7XKLQ/Dul1mal1nGhvLoB
         UcHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=a48mFvuUcnCIP9cUd4qhU8qQ0bb/d/xrOxAOQhxTyq8=;
        b=jVp+9TGAhqy5mlhyTW6xPGzL1hFjxkpIu5XNHyvHvu3zqdb7Ce8Tn1U/KWCx/zY0jZ
         +yt8enHpmSYNXQ6WFQ8+fYj86noOKsVLeNMbfGZrRfCNsxR8ockZnuSn1WwjdBlZDstu
         KYShImJ/tDpNGIocJryM8SMhgm5xa2qNmGRHJKtphmSOziagqfKxiwVeMuMP2zokF6Xj
         CdN3kiaMWEUber/yG3GbSYcbInBsfEFjmiVhiDuNBSg/q2pQdyx1FU/sJ4XWyqSY6nj6
         TAkh102JYXnCrjD+xcSBaUw0gM16EeyfK0ySOAPh5fjKyYjOGzVmGDt2hBTwDrCNJhC8
         sBJw==
X-Gm-Message-State: AOAM533bnz0jxJLqYUNbILyLrdvy7X03x7QAX6xNQpGMbGrPeHw0AWCy
	KK6PnvqIrFWW19SogZICB59i93cDdfcgCb8fb34=
X-Google-Smtp-Source: ABdhPJzfiaeA6axviDewYMYN45aOZj4gzclrDCiPKIkEhIXDoiQEa5vnifzLr6G/KdiMowZQI/2XzWnCbDV0HY154eg=
X-Received: by 2002:adf:ef4f:: with SMTP id c15mr3696725wrp.226.1639562259957;
 Wed, 15 Dec 2021 01:57:39 -0800 (PST)
MIME-Version: 1.0
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
In-Reply-To: <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
Date: Wed, 15 Dec 2021 11:57:29 +0200
Message-ID: <CAPD2p-mWWUT=kLFDOfsYrZp7hGLLbbU4SiPaFg1SKjF3Tkj5kQ@mail.gmail.com>
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: multipart/alternative; boundary="000000000000178b5e05d32c56b8"

--000000000000178b5e05d32c56b8
Content-Type: text/plain; charset="UTF-8"

On Tue, Dec 14, 2021 at 11:35 AM Oleksii Moisieiev <
Oleksii_Moisieiev@epam.com> wrote:

Hi Oleksii

[sorry for the possible format issues]

Implementation includes platform-specific smc handler for rcar3 platform.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>  xen/arch/arm/platforms/Makefile |  1 +
>  xen/arch/arm/platforms/rcar3.c  | 46 +++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+)
>  create mode 100644 xen/arch/arm/platforms/rcar3.c
>
> diff --git a/xen/arch/arm/platforms/Makefile
> b/xen/arch/arm/platforms/Makefile
> index 8632f4115f..b64c25de6c 100644
> --- a/xen/arch/arm/platforms/Makefile
> +++ b/xen/arch/arm/platforms/Makefile
> @@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) += exynos5.o
>  obj-$(CONFIG_ALL32_PLAT) += midway.o
>  obj-$(CONFIG_ALL32_PLAT) += omap5.o
>  obj-$(CONFIG_ALL32_PLAT) += rcar2.o
> +obj-$(CONFIG_RCAR3) += rcar3.o
>  obj-$(CONFIG_ALL64_PLAT) += seattle.o
>  obj-$(CONFIG_ALL_PLAT)   += sunxi.o
>  obj-$(CONFIG_ALL64_PLAT) += thunderx.o
> diff --git a/xen/arch/arm/platforms/rcar3.c
> b/xen/arch/arm/platforms/rcar3.c
> new file mode 100644
> index 0000000000..d740145c71
> --- /dev/null
> +++ b/xen/arch/arm/platforms/rcar3.c
> @@ -0,0 +1,46 @@
> +/*
> + * xen/arch/arm/platforms/rcar3.c
> + *
> + * Renesas R-Car Gen3 specific settings
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021 EPAM Systems
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/platform.h>
> +
> +static bool rcar3_smc(struct cpu_user_regs *regs)
> +{
> +    return false;
> +}
> +
> +static const char *const rcar3_dt_compat[] __initconst =
> +{
> +    "renesas,r8a7795",
> +    "renesas,r8a7796",
>


Please note that since Linux commit:
"9c9f7891093b02eb64ca4e1c7ab776a4296c058f soc: renesas: Identify R-Car
M3-W+"
the compatible string for R-Car M3-W+ (ES3.0) SoC is "renesas,r8a77961". So
in case we want to have vSCMI feature on this new SoC revision as well we
will need
to extend the compatible list.


+    NULL
> +};
> +
> +PLATFORM_START(rcar3, "Renesas R-Car Gen3")
> +    .compatible = rcar3_dt_compat,
> +    .smc = rcar3_smc
> +PLATFORM_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> --
> 2.27.0
>
>

-- 
Regards,

Oleksandr Tyshchenko

--000000000000178b5e05d32c56b8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Dec 14, 2021 at 11:35 AM Olek=
sii Moisieiev &lt;<a href=3D"mailto:Oleksii_Moisieiev@epam.com" target=3D"_=
blank">Oleksii_Moisieiev@epam.com</a>&gt; wrote:<br></div><div dir=3D"ltr" =
class=3D"gmail_attr"><br></div><div class=3D"gmail_attr">Hi Oleksii</div><d=
iv dir=3D"ltr" class=3D"gmail_attr"><br></div><div class=3D"gmail_attr">[so=
rry for the possible format issues]</div><div dir=3D"ltr" class=3D"gmail_at=
tr"><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px=
 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Implementat=
ion includes platform-specific smc handler for rcar3 platform.<br>
<br>
Signed-off-by: Oleksii Moisieiev &lt;<a href=3D"mailto:oleksii_moisieiev@ep=
am.com" target=3D"_blank">oleksii_moisieiev@epam.com</a>&gt;<br>
---<br>
=C2=A0xen/arch/arm/platforms/Makefile |=C2=A0 1 +<br>
=C2=A0xen/arch/arm/platforms/rcar3.c=C2=A0 | 46 +++++++++++++++++++++++++++=
++++++<br>
=C2=A02 files changed, 47 insertions(+)<br>
=C2=A0create mode 100644 xen/arch/arm/platforms/rcar3.c<br>
<br>
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makef=
ile<br>
index 8632f4115f..b64c25de6c 100644<br>
--- a/xen/arch/arm/platforms/Makefile<br>
+++ b/xen/arch/arm/platforms/Makefile<br>
@@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) +=3D exynos5.o<br>
=C2=A0obj-$(CONFIG_ALL32_PLAT) +=3D midway.o<br>
=C2=A0obj-$(CONFIG_ALL32_PLAT) +=3D omap5.o<br>
=C2=A0obj-$(CONFIG_ALL32_PLAT) +=3D rcar2.o<br>
+obj-$(CONFIG_RCAR3) +=3D rcar3.o<br>
=C2=A0obj-$(CONFIG_ALL64_PLAT) +=3D seattle.o<br>
=C2=A0obj-$(CONFIG_ALL_PLAT)=C2=A0 =C2=A0+=3D sunxi.o<br>
=C2=A0obj-$(CONFIG_ALL64_PLAT) +=3D thunderx.o<br>
diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.=
c<br>
new file mode 100644<br>
index 0000000000..d740145c71<br>
--- /dev/null<br>
+++ b/xen/arch/arm/platforms/rcar3.c<br>
@@ -0,0 +1,46 @@<br>
+/*<br>
+ * xen/arch/arm/platforms/rcar3.c<br>
+ *<br>
+ * Renesas R-Car Gen3 specific settings<br>
+ *<br>
+ * Oleksii Moisieiev &lt;<a href=3D"mailto:oleksii_moisieiev@epam.com" tar=
get=3D"_blank">oleksii_moisieiev@epam.com</a>&gt;<br>
+ * Copyright (C) 2021 EPAM Systems<br>
+ *<br>
+ * This program is free software; you can redistribute it and/or modify<br=
>
+ * it under the terms of the GNU General Public License as published by<br=
>
+ * the Free Software Foundation; either version 2 of the License, or<br>
+ * (at your option) any later version.<br>
+ *<br>
+ * This program is distributed in the hope that it will be useful,<br>
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of<br>
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.=C2=A0 See the<br>
+ * GNU General Public License for more details.<br>
+ */<br>
+<br>
+#include &lt;asm/platform.h&gt;<br>
+<br>
+static bool rcar3_smc(struct cpu_user_regs *regs)<br>
+{<br>
+=C2=A0 =C2=A0 return false;<br>
+}<br>
+<br>
+static const char *const rcar3_dt_compat[] __initconst =3D<br>
+{<br>
+=C2=A0 =C2=A0 &quot;renesas,r8a7795&quot;,<br>
+=C2=A0 =C2=A0 &quot;renesas,r8a7796&quot;,<br></blockquote><div><br></div>=
<div><br></div><div>Please note that since Linux commit: &quot;9c9f7891093b=
02eb64ca4e1c7ab776a4296c058f soc: renesas: Identify R-Car M3-W+&quot;<br>th=
e compatible string for R-Car M3-W+ (ES3.0) SoC is &quot;renesas,r8a77961&q=
uot;. So in case we want to have vSCMI feature on this new SoC revision as =
well we will need<br>to extend the compatible list.=C2=A0<br></div><div><br=
></div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+=C2=A0 =C2=A0 NULL<br>
+};<br>
+<br>
+PLATFORM_START(rcar3, &quot;Renesas R-Car Gen3&quot;)<br>
+=C2=A0 =C2=A0 .compatible =3D rcar3_dt_compat,<br>
+=C2=A0 =C2=A0 .smc =3D rcar3_smc<br>
+PLATFORM_END<br>
+<br>
+/*<br>
+ * Local variables:<br>
+ * mode: C<br>
+ * c-file-style: &quot;BSD&quot;<br>
+ * c-basic-offset: 4<br>
+ * indent-tabs-mode: nil<br>
+ * End:<br>
+ */<br>
-- <br>
2.27.0<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><span style=
=3D"background-color:rgb(255,255,255)"><font size=3D"2"><span style=3D"colo=
r:rgb(51,51,51);font-family:Arial,sans-serif">Regards,</span></font></span>=
</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><div><span style=3D"backg=
round-color:rgb(255,255,255)"><font size=3D"2">Oleksandr Tyshchenko</font><=
/span></div></div></div></div></div></div></div></div>

--000000000000178b5e05d32c56b8--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 10:33:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 10:33:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247316.426436 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRat-0006JE-4d; Wed, 15 Dec 2021 10:33:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247316.426436; Wed, 15 Dec 2021 10:33:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRat-0006J7-1U; Wed, 15 Dec 2021 10:33:07 +0000
Received: by outflank-mailman (input) for mailman id 247316;
 Wed, 15 Dec 2021 10:33:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=E5lv=RA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxRas-0006J1-8m
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 10:33:06 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 62c4540e-5d92-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 11:33:05 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-M3fWBv74Mya1BFhAjLtbvQ-1; Wed, 15 Dec 2021 11:33:03 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7038.eurprd04.prod.outlook.com (2603:10a6:800:12d::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Wed, 15 Dec
 2021 10:33:02 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 10:33:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62c4540e-5d92-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639564384;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=fNY97RAWAvq49SPTtqhfLbGCOmtlRioiKDhBUo1Ak8Y=;
	b=VIM5UBf1pQOSekriDTo5OnOSg0Q2DYYWW0w3LiVTXcJS+YFQ5Xq9unmOhddrfhonba9Dj4
	Lzb6W8vTrh1XM7qdM8hUOqU7Rys6pfPaADRbcMyrFdLohxr8l3bHSujqrY9Dzt6mKXvn4u
	1w/VMmQ6190PwDfBpM+tn8DYgJei3m8=
X-MC-Unique: M3fWBv74Mya1BFhAjLtbvQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fAK28v7D0zIw+kCvuWgAIjrWGnDNIrI2JJP7/N7FwnVRYEHHSvGqWTSjSIm/5OfSFH5eTpufAGKDJc0Wda5tEGyiT4dAdsNtSMm+UwR18xaANLJ/O4Y+6GDyCOsDxpnfgfJUUAVeIefJAgRPzEXucq2WezXw773R+my5WC99YhK8bOwbcA7h1YlNS3RP8TSJV5K9vqjva3sCuMYdv7pK5BKGCNGct2det3fJh5VCG3PtN/N03DAwQgvj5nYtRFHoe0TQBWJ/t6biGJBWrAxBynn/ebVVK6J5vBq1q9Zo6Z5Us0cjyJRlJTuEZqp2gv2HDBAJh4pbCz0ZG+JR5G7c8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=fNY97RAWAvq49SPTtqhfLbGCOmtlRioiKDhBUo1Ak8Y=;
 b=OYKZ9RFxP5MQ2uMw+Jxq+Yb57KhMGZpmO3xYjhC2cwgqiM5mdfVAG365Sr1QEUVCR+QDgEgDxglxpG/nJxrFzU2l+6N0WDyApWSL/3Dqc6s7S1Ea4HtzzW+VYwiz5BrW0kglffOL6v3HSBHwp8CYhrZMFajpMdHCO0nrywGeQogCZVqc71Vb501CtzxAUV3Ci85sP7IN+/frC4BtZlgeoKNLJkdXF6Rn5HijG0lnO3ZzGBWIyppmEZ+Fu/55WVyOvlsKBoEPkeCrySgzoAokNX0pqbiqpDur1H0TMBcd5VVSHi/w2romRSIaQg55Ww3ytJxPxSHMflipgVq94Vl/Ig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6e54f971-84c3-3635-12c8-643b619b2b53@suse.com>
Date: Wed, 15 Dec 2021 11:32:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
From: Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
 <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
Content-Language: en-US
In-Reply-To: <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0016.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31895e42-28bf-45a3-4bee-08d9bfb64595
X-MS-TrafficTypeDiagnostic: VI1PR04MB7038:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7038F0E21144F28213EEF000B3769@VI1PR04MB7038.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6Tw3mtNEioUQ2d9x7CLUBhR7pxDc2iHcS/WovX64qg5D/E//8qDahdEfXxto9Tc2V/Wq2vVKdZDrwBvcHxoJdRqGSnQ6e23wSXDUiSR2q467yeiv5ph2/BLFg+oKRoZkFb+zjQdgrzszOuCV+IiHH9/j01iMPCrGIUSOIfz/uUBM5gDzDagyNRott9owyPiLgDY+Lk+cJQKPF9CGcPaXuNdw1NbX2r3jTbXVKGJUoEVZI56xD3CHDff1Hhggac0/S3IZIwa1ctcaO4ifxLoRuQF2Vct9+yV4gYaSO9a35u/vFo8feN9MlISc58tLth26yRNKin47oE6CQXpH0c5gD5RGmIsWN99yigR55cHjiXQGp647Iz4py5MEu3idm+u6sKBYdvY7sapk6VNX9GQdGLO7F+ZQ8DuTemZzBqEWsiKYkueV+aWvQsxQh2QQG3SfxaLssNooG73bluFX83xdze+fCtvksCRFzam5mKNn0nfdvGTMkL/dC2mHgvjfz/EFJeqPpH14X+xFd+5a5qcZrtqgHN83tw68usl/jSQFPhmXhNLLOmPYGg1Mq9GOzRykiMjtmdw2hLLbDqkwRQcfhkJaKuIG5Gt1DqZfeupFySkMOPAuJvbN2UusdfWiUgzYptl+yewVKQo6LHETN/RHJH6NE/k1hNamAwDJnHMUr+2aajDrWdgbGCrJGR99imPkUmlh7FkfFViM/zU945hg68sfy6cFP4y3J/L/UsWKopAxBytAgLQPtumxLlPbMcp0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(26005)(8936002)(38100700002)(8676002)(86362001)(6512007)(66556008)(6486002)(66476007)(508600001)(66946007)(83380400001)(31686004)(36756003)(186003)(4326008)(53546011)(54906003)(4744005)(6916009)(6666004)(6506007)(2616005)(316002)(2906002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MzFTaXIwaXdRRDdNRmMvK3A5M1JkSWY1cS9RR0p1NUp5eGljUkszZjhvcWZ6?=
 =?utf-8?B?RndPUnhrcDNMZU9JZTVORURiaWJ4V09WNGlYaE1EZGJvZjNnb09VZmJMeWxN?=
 =?utf-8?B?dFdTeFdTMGFCdHpJZ1hkeWJYdDF0RUJhSGpndW44Z2JDaHVNRzhObWdsVzZO?=
 =?utf-8?B?VFViNnZhTW1lSklOdE02d3BBS0YrbGNldHpFWkZFazRoS3dkSkJqOXVnRFpz?=
 =?utf-8?B?b3BPWWJrZitRcGFCd0VTZEJsMzFZQzlhUnlqbERIbzJhNmxkaWU5L0UxRFM0?=
 =?utf-8?B?ekFpaFo4T0RMcmhKTkNqRHNDZGhQd0doRHlVRExhZVpZNWdKNEdidWZXTTFh?=
 =?utf-8?B?aHpwM0MvdnlsdlA0Y09SY3JadnNDRHg5TVhRRnZVbXhReE0wTGt3NjFyNUR6?=
 =?utf-8?B?NUh4SnN5ZXpTSTJ6OWdyQTBDbFZQeldrV3NiTngyd2p0cnRxZlR6amJhWnk0?=
 =?utf-8?B?TlZLZGJTTmFCMnVFdzRQbno3bklsNHRUeTh2NWJBYmN4bjUyaFdZTERoNllM?=
 =?utf-8?B?TGc0cTJ2SkxxNm9DaEZkR2ZPZUpBV3hWaytKLy83cFgyWnRyVm5pdy92V3d0?=
 =?utf-8?B?U3JMWnJOd1FWQkJUM0VsME5seG9YYkZXNTBZZzh1VlhEYjJVWmVCYlU5V2Vq?=
 =?utf-8?B?d3N2bEV4emNvVzZtYm1aOExKNEpCZEorUFB5bVlwUmJDOVJYUzJtZE9sNmJm?=
 =?utf-8?B?YmRFM0E3THVBMTB4NURvNThhQUpWcHBJRkJsZk52U0JTdmd4cG1mRkpOcDRu?=
 =?utf-8?B?S0RpZGZXdng2bmJaL3FlbVFYMk5ybndHTFN3aFIrMnR0eUNKcGJFVm1Pb2dx?=
 =?utf-8?B?dmVpczNYdmVBRGEyVHJaUHh1aSs0MkYvT281djNiTHpoTG9LbGdBUVBaZit5?=
 =?utf-8?B?Sk5Fb1BEem0waHFlck1semJBVnNYM3BiY1F1bEp3SlRLUjhKN3YwOTkyTWcx?=
 =?utf-8?B?a2szVE1NZWZKcWdxTjI3cUE5V1ZkaGYweCtVVFZmaGY5US9IVDdIRmRSN1pC?=
 =?utf-8?B?SlNMekV6ekluMXdkWmNNa1VyeWJSRHJGN1A0YzVYQ3RsY0tzVkwxL2VYVDg5?=
 =?utf-8?B?RHRvYzdDWnp1VTM2U2hzWlhBMkhReSt4b3lIU3FkUGNTLy9lRWFGZm1uY04r?=
 =?utf-8?B?Y0dkRnhmdzJuenVwMWp2Y21QVzJvUjVhTlE3SFhmNzdaUDRHRWZsQnQ4Y3hU?=
 =?utf-8?B?ZjVmcUNOdkUvQW96cHpsTlY1cDdvNlhwY3RIbVNTY3VSRWp5WlI4TnlkSlAr?=
 =?utf-8?B?OFdIU25vK3pwelpXbmdoT0hBVjRkNExJREx3aFc4M0srQkdrNGVBamp2UkFa?=
 =?utf-8?B?R2IwUU5kUmk1V01wU05JSDlpaXM0SHloRml2eHkyNkhLUGZ4RUhMRXFxNy93?=
 =?utf-8?B?UjcyRXRoZGttamtPZUY4SGJ3TlV0djFWZ1dmWXpUcmNLanJEazArYkI0OG9w?=
 =?utf-8?B?N2lVZnlyaWNoOXd1WERNQ2VHV3VwQWZnYWNiSm8zWk1LTzlyV1VWbXJIS3JG?=
 =?utf-8?B?K01xNURpS1c1YjRPUlBDMWpla3hnSUpnZlhvMWtWaFFaMDlPZk1lM1VhWVZj?=
 =?utf-8?B?UWtlV1FWSnBpOFdCRHZxQiswRUtHam1aR2lxRkM0M1lBN0NQaXByb1BTSXpx?=
 =?utf-8?B?bTZZNklHYmc0cU11MkdmQ3VXWEVkTmhsRjZGaVlVbENTYTdzcGUxbTQzY3A3?=
 =?utf-8?B?aW54cjFiY28wVDNjbTcwdVJVQ1ZtSFVMc01CalZVdFVVTTdTNk42N2EvM1hp?=
 =?utf-8?B?c3JOUTlKWkVCYklQZ2QvOVMzWWNDSmMzdmswVjk5a0k3THJMdWpaek1palZJ?=
 =?utf-8?B?dStPWFFPZjZtMzdaSGJOZ0UxNnZEOGhlak5HU1VBR05uclpJS2x3L0UzczND?=
 =?utf-8?B?aVIxdm96YWJIa05iU0JZT3dGTTkzNmlvYW1mY0VaYUthemZRa095TldqektQ?=
 =?utf-8?B?VWNRR2JKeDhYdHYydUEra3pKU0ovWVJzbXhUcFRSN2pWY1Brcmtnd0xjRWtM?=
 =?utf-8?B?bnRFVkNlSnFTblYvaTIxWDhMVDRGT0tvUENRQmJCMnJHbU0yTzgrbStFcEhz?=
 =?utf-8?B?cEJtRjJ2R3haZHkyeENhcytRMDdhRjZPOFVBTHBZVXZCQXFNVEswR0RLekRO?=
 =?utf-8?B?UFc5VVNqcmU0QWdyMEdSR0tpNkI2WEc3cFBxMzZkcGJ5Wnk0a2E4T1dpaERu?=
 =?utf-8?Q?1M3YsOZX8vMdObCF8HtSwGo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31895e42-28bf-45a3-4bee-08d9bfb64595
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 10:33:02.3380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6JGLAg5zdottTN4nDTv8dfDAOYoOhnV9608AF0aNhHIgSFQRL0Fd7oAcHxrnKS8tM85n31gszmafVjR9vx0K6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7038

(Re-sending an abridged version, as apparently spam filters didn't like
the original message with more retained context; I'll have to see whether
this one also isn't liked. Sorry.)

On 15.12.2021 10:48, Michal Orzel wrote:
> This patch and the problem it solves is about clearing top 32bits of all gp registers so not only x0,x1.

That's well understood. Yet for everything still in registers simply
using mov ahead of the respective push (as you had it) is still
preferable imo.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 10:41:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 10:41:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247321.426447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRiO-0007qd-Vg; Wed, 15 Dec 2021 10:40:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247321.426447; Wed, 15 Dec 2021 10:40:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRiO-0007qW-SY; Wed, 15 Dec 2021 10:40:52 +0000
Received: by outflank-mailman (input) for mailman id 247321;
 Wed, 15 Dec 2021 10:40:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4xGT=RA=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxRiN-0007qN-EK
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 10:40:51 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 77b091e3-5d93-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 11:40:49 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92CE56D;
 Wed, 15 Dec 2021 02:40:48 -0800 (PST)
Received: from [10.57.5.111] (unknown [10.57.5.111])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7520C3F5A1;
 Wed, 15 Dec 2021 02:40:47 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77b091e3-5d93-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org,
 Julien Grall <julien@xen.org>
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
 <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
 <6e54f971-84c3-3635-12c8-643b619b2b53@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <219d27fe-4e77-59f5-b559-4bc70c2a0399@arm.com>
Date: Wed, 15 Dec 2021 11:40:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6e54f971-84c3-3635-12c8-643b619b2b53@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 15.12.2021 11:32, Jan Beulich wrote:
> (Re-sending an abridged version, as apparently spam filters didn't like
> the original message with more retained context; I'll have to see whether
> this one also isn't liked. Sorry.)
> 
> On 15.12.2021 10:48, Michal Orzel wrote:
>> This patch and the problem it solves is about clearing top 32bits of all gp registers so not only x0,x1.
> 
> That's well understood. Yet for everything still in registers simply
> using mov ahead of the respective push (as you had it) is still
> preferable imo.
> 
> Jan
> 

In that case let's wait for Julien's opinion to decide whether I should get back to the previous
solution with mov or to the stack solution.

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 10:52:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 10:52:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247326.426458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRss-000113-VX; Wed, 15 Dec 2021 10:51:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247326.426458; Wed, 15 Dec 2021 10:51:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxRss-00010w-Sh; Wed, 15 Dec 2021 10:51:42 +0000
Received: by outflank-mailman (input) for mailman id 247326;
 Wed, 15 Dec 2021 10:51:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v6+1=RA=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mxRsr-00010q-3J
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 10:51:41 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9d9b8ec-5d94-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 11:51:38 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639565493847551.7972671181299;
 Wed, 15 Dec 2021 02:51:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9d9b8ec-5d94-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1639565495; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=Aq6kNSN+rgVghSZPLKDWo+9+IP/vezblYyocWYagUJDnR3sAYPHws1M7vsOYJ7dxE6ajgXJchnlNCnbhX2DxNs/wZm174O8b6SpD7HaySr6J1VXfSRB2sKUZxPiZOQZN/RJkvOxtGl6x+P9AMoC7yCHX/VQiW8RJEzW1DiZq9qc=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639565495; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=Yb/PzMW1nL5/GwsT7rhPmBY+IyuRV/dbBMCsFjfLduY=; 
	b=eLAX4HzuVkQFmKv93T0RqKDV8W2NQU7SkVYd1hMQMWhlfYGHJTGQVCmpWaL7YqQcEBOXah3mbdpvuMFjZEwUHO3HuDKZdMErLPFGxxQw+5F+0AbCm6dsJyTJmcNFPtja8FLlMIzJim3ujWa/RUW2s9tJIBQhKl0nBkKGrbD3/TU=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639565495;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=Yb/PzMW1nL5/GwsT7rhPmBY+IyuRV/dbBMCsFjfLduY=;
	b=aZ5Pe358m/x4kZzhRlbviArkIzDGzPtGjfarFC4WBHIlkpfS9r4PsmwY5tE0bueW
	voqNVHQml4Hf1ci43H6IEUCex1rFqt6rvhiIK0GXP3xc0Yg8OLQ49RajcVZSQdzlZXJ
	/8yXvYiAEVtS+yWZTzRua3elrPILiUHdILBP25lc=
Subject: Re: [PATCH] x86/cpuid: Introduce dom0-cpuid command line option
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <20211214211600.2751-1-andrew.cooper3@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <8cb4e5cb-5eb3-6967-91de-97c222645ecb@apertussolutions.com>
Date: Wed, 15 Dec 2021 05:51:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211214211600.2751-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 12/14/21 4:16 PM, Andrew Cooper wrote:
> Specifically, this lets the user opt in to non-default for dom0.
> 
> Split features[] out of parse_xen_cpuid(), giving it a lightly more
> appropraite name, so it can be shared with parse_xen_cpuid().
> 
> Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply it
> to dom0's policy when other tweaks are being made.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Daniel Smith <dpsmith@apertussolutions.com>
> 
> RFC, because I think we've got a preexisting error with late hwdom here.  We
> really should not be cobbering a late hwdom's settings (which were provided in
> the usual way by the toolstack in dom0).
> 
> Furthermore, the distinction gets more murky in a hyperlaunch future where
> multiple domains may be constructed by Xen, and there is reason to expect that
> a full toolstack-like configuration is made available for them.

For hyperlaunch, perhaps Christohper and I should revisit the DTB to add 
a cpuid field/mask where CPU features can be masked out.

> One option might be to remove the special case from init_domain_cpuid_policy()
> and instead make a call into the cpuid code from create_dom0().  It would have
> to be placed between domain_create() and alloc_dom0_vcpu0() for dynamic sizing
> of the FPU block to work.  Thoughts?


v/r,
dps


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 11:02:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 11:02:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247332.426470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxS3f-0002fF-25; Wed, 15 Dec 2021 11:02:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247332.426470; Wed, 15 Dec 2021 11:02:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxS3e-0002f8-T9; Wed, 15 Dec 2021 11:02:50 +0000
Received: by outflank-mailman (input) for mailman id 247332;
 Wed, 15 Dec 2021 11:02:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxS3d-0002ey-Fa; Wed, 15 Dec 2021 11:02:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxS3c-0001gl-G9; Wed, 15 Dec 2021 11:02:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxS3c-0000bF-8K; Wed, 15 Dec 2021 11:02:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxS3c-0003Yo-7s; Wed, 15 Dec 2021 11:02:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=25DTJbVRP8gtnznZQuG0w8y+8aRb6pZArL6ItBRUi+4=; b=V05TXT3Avrv+qjFHA7q46bKBdr
	NEZU9+nrNdRQ1+y0n3H8Fylaux/Pfby4GiIPeQOYNtLMAPGRbuREydPM92R3296N/OyW41Fi0hTBG
	PTNjBww1bIIKKC5jRIHMW8F1IoUAYxRKuJ/IBvq79RI14ACSWFkR1zD9YPRofjFI4LHI=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167428-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167428: regressions - ALL FAIL
X-Osstest-Failures:
    xen-unstable-coverity:coverity-amd64:coverity-upload:fail:regression
X-Osstest-Versions-This:
    xen=249e0f1d8f203188ccdcced5a05c2149739e1566
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 11:02:48 +0000

flight 167428 xen-unstable-coverity real [real]
flight 167430 xen-unstable-coverity real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167428/
http://logs.test-lab.xenproject.org/osstest/logs/167430/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 coverity-amd64                7 coverity-upload          fail REGR. vs. 167384

version targeted for testing:
 xen                  249e0f1d8f203188ccdcced5a05c2149739e1566
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167384  2021-12-12 09:20:52 Z    3 days
Testing same since   167428  2021-12-15 09:21:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>

jobs:
 coverity-amd64                                               fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 249e0f1d8f203188ccdcced5a05c2149739e1566
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Dec 13 20:33:42 2021 +0000

    x86/cpuid: Fix TSXLDTRK definition
    
    TSXLDTRK lives in CPUID leaf 7[0].edx, not 7[0].ecx.
    
    Bit 16 in ecx is LA57.
    
    Fixes: a6d1b558471f ("x86emul: support X{SUS,RES}LDTRK")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 1382241fe880d48e109f2056cec052bb3919a9d1
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:50:07 2021 +0100

    perfc: drop calls_to_multicall performance counter
    
    The calls_to_multicall performance counter is basically redundant to
    the multicall hypercall counter. The only difference is the counting
    of continuation calls, which isn't really that interesting.
    
    Drop the calls_to_multicall performance counter.
    
    Suggested-by: Jan Beulich <jbeulich@suse.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 668dd44902bbaf52f8e7214e0da060b6ec962e88
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:49:23 2021 +0100

    x86/perfc: add hypercall performance counters for hvm, correct pv
    
    The HVM hypercall handler is missing incrementing the per hypercall
    counters. Add that.
    
    The counters for PV are handled wrong, as they are not using
    perf_incra() with the number of the hypercall as index, but are
    incrementing the first hypercall entry (set_trap_table) for each
    hypercall. Fix that.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 7b99e7258559c9caa235d9faf323b22c68e4a581
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:48:17 2021 +0100

    x86emul: drop "seg" parameter from insn_fetch() hook
    
    This is specified (and asserted for in a number of places) to always be
    CS. Passing this as an argument in various places is therefore
    pointless. The price to pay is two simple new functions, with the
    benefit of the PTWR case now gaining a more appropriate error code.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Paul Durrant <paul@xen.org>

commit c49ee0329ff3de98722fd74ed5ba6d9665701e54
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:47:31 2021 +0100

    SUPPORT.md: limit security support for hosts with very much memory
    
    Sufficient and in particular regular testing on very large hosts cannot
    currently be guaranteed. Anyone wanting us to support larger hosts is
    free to propose so, but will need to supply not only test results, but
    also a test plan.
    
    This is a follow-up to XSA-385.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 53ed194539ddbea4f6aecb1b7c2f33aa8c0201d9
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:46:48 2021 +0100

    x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed by: Alexandru Isaila <aisaila@bitdefender.com>

commit 7dc0233f534f64e7f3ee71e74e05dd5ab8a24808
Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Date:   Tue Dec 14 09:44:44 2021 +0100

    vpci: fix function attributes for vpci_process_pending
    
    vpci_process_pending is defined with different attributes, e.g.
    with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
    Fix this by defining both of the definitions with __must_check.
    
    Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
    Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit d828caa9aeee80c59a35f662f875f6573e9b532f
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Dec 13 17:50:48 2021 +0000

    tools/libfsimage: Fix SONAME
    
    This gets missed on each release.  Follow the same example as libs.mk and pick
    the version up dynamically.
    
    Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
    Suggested-by: Anthony PERARD <anthony.perard@citrix.com>
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Anthony PERARD <anthony.perard@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 11:57:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 11:57:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247340.426483 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxSuN-0008QB-6j; Wed, 15 Dec 2021 11:57:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247340.426483; Wed, 15 Dec 2021 11:57:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxSuN-0008Q4-2S; Wed, 15 Dec 2021 11:57:19 +0000
Received: by outflank-mailman (input) for mailman id 247340;
 Wed, 15 Dec 2021 11:57:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxSuL-0008Pw-DH
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 11:57:17 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 24120160-5d9e-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 12:57:14 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFBmlJ4030002;
 Wed, 15 Dec 2021 11:57:04 GMT
Received: from eur01-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2053.outbound.protection.outlook.com [104.47.1.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cyftdg11p-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 11:57:03 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB5796.eurprd03.prod.outlook.com (2603:10a6:208:156::32)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Wed, 15 Dec
 2021 11:57:00 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 11:56:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 24120160-5d9e-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Ri6uvVlTC0sjj3qQJoAaVqtClM4Oc3xir77Rc2mj3M7983yZ9agw1WlRCvesTI/i8a+nOIqOupfyrK09aZbc4YTPaReGxfhD+5+mpR6mdfSvQP8RTMNLIRLqQeaHIDFN7msQ73Cog9SvUOOxmMqgaEJWcfpRIWnmOltHxJ4etUs7V6Wm9KIVvAksWAKTmJnld8e0ZelPmUwL3154sJwITfd6Wr+x4kaTFU54CcRUUbK8A31O4JhA+d8cFUkYcIaKOhCWJZFwkLGDT5HphLqChvRBc2R3Bb4uo6/ahadUp1y+YiXFR+Ch0ALGqIFqcEWepGG4CqxkAsNIVCobmsmyxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Y0bkVSVrmM/z5GDoxBP3lueyrdo2quxay8ie0YZLG6o=;
 b=CNFFpS3JyulEsvjJvtuq0MzlwnaL9hgL543Y7iubsFXBM9+wL9oxompl4hX1OvF91mXvlGziGQIssCosqnbjSPZPfx8E6RsDwpS5neG9GPoNrgBCN2NthowtUVKZoHiOsagvVjcyeurIQNtIw9nhjgeD5HD3tVkBegH9VLyzkrfzOPV4VnEd7Mhmh9pC0ZPU4scQcVjdIF0sU1EF+8wX32OxAzE7y6YGCuERPhCtPIY8dZY8b+S8f1Z1a1hJru5JmlMddDXxTAKDjorhv/tK7VSZ/Q2fnGALaH4ovj1LOHkpuhFf2GwYHjYNbH26STn5kq9M2EQmLF99AXE2NW8j5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Y0bkVSVrmM/z5GDoxBP3lueyrdo2quxay8ie0YZLG6o=;
 b=mJDzcHqaB1eXSDErzucJV5hbFzCHj2/0Lrx09J1Rf6Pckg0ZhumLBVExy+ZlytGx9Nupj73KXbWq7kjfydyEEzpft7Qdg0IqGB2amOWb4QuyLJ1zffBsFH6JUqCLDPFiEZP/BhubJqA9Ru/LSKsz0X4tvtHt1MPfpB9PdoX7C04iACwP8lMLGkhsxhghX4PspI9UQUQuhz71SWRJiYi3udI4Rcnxz17T7vN9uz5Pn0k2ieL7xmbnFzEYH1gt2XMvHFDIsrKeDvFhPOT2335kgcGoCyLbAVP3/8zkcKJeDVWYD1QWbrLUaF0Op40X84x9F6LJAc74QL0MSS+jXpo/aw==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        "jbeulich@suse.com" <jbeulich@suse.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Wei Liu <wl@xen.org>
CC: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "george.dunlap@citrix.com"
	<george.dunlap@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        Oleksandr
 Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Topic: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Index: AQHX4ewD/fiBagJockWfLYQGw/ZN1KwzkeKA
Date: Wed, 15 Dec 2021 11:56:59 +0000
Message-ID: <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
In-Reply-To: <20211125110251.2877218-1-andr2000@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4b751625-5a25-431c-9b04-08d9bfc20054
x-ms-traffictypediagnostic: AM0PR03MB5796:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB579625D5131BAC98558E8841E7769@AM0PR03MB5796.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 R9IiXMz/0GaV4FHYvBj+Ta8+bQfjpICH/sq7tT/Y/gXN0DBwJFiXVl5T7mRF5IRSoJ/JRbdXkgdM3pDUvjMkIJZOJQruoEwaISdzuN4r4uJ6pdI+hz6XacoRWGNbPg5rQHP03xGzDhr3xqLKMQ8JCWkyXtNgHlqh2m+SFPzx/ZT+5zupX0d2SwVvuc2sTNWLcf7ih63DZcgwz0kRqke32XOpZ8Ykviyc2Nnb37iEeieaJLcHhz3s1heugnBaw7ej1qlV3qCYhahv10iR6vur+fMVFA0XrBYo0JG9BbQOHw1h5X90jdZgWlS2hlRWjmM/Rtk/UAY8OxOTx1fHxaLN+oCWn2+cejHd4D2Ja2NA8As7NPDnMWMvi3yT6yFKOZqzAA9zO33FXZBXl1OAl8HEvohTcbF9Ui9/T8ZsFaTu+oq4Umu+56znMJ8wiN3kyMSlMkI6S/fVOnKwqy7mNOA2O/E8b9oNAOCCZRjWyqQSA/GRmCbJ8TTfVJEbQ3ztVz/ig46OIYYlNlez+IrG0aOlHAJ7IIbHvY/coxq6FC1BNNvoPb+d/Tr6njF0XHW+XHpZqC2RA12Mq5NlXRqn5O970H6L00miy8XuERf0M2AZLsdjixxuwET7yZFl/+eHLziTX9BI8AOdvj50bxDyKS1dHi+KIw+vrEhgAAId1Sl4uzJVUYr1M2YLyH3eH3HmE/UMLscD2CdD3m7nJFJpCgwyLI/a0NdSYCaffsOel7Hv5cLlgSdaFb9yLA6KT9HpraJ0KYMhTs6R2R0FV3Cm2sx75fvhJjTvALjM9Xvfm7tBXpRvUs4cRbGVW7w2k/lONWHBJNqQ2ufr5e6mQbMW6uO0Qg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2616005)(66476007)(53546011)(66446008)(83380400001)(38100700002)(122000001)(5660300002)(86362001)(966005)(66946007)(110136005)(64756008)(107886003)(6486002)(6506007)(7416002)(31696002)(2906002)(6512007)(66556008)(71200400001)(91956017)(508600001)(36756003)(76116006)(8936002)(26005)(4326008)(186003)(316002)(8676002)(31686004)(38070700005)(54906003)(55236004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?WUZZQzQ1dEdtMVZSb2xUc0s5U3A3NUp0WkJHZnJ0R0tMeGdGNk1iNExwaGJt?=
 =?utf-8?B?d2NRMXM0bzk0d3hHaXplSFJJNHptcng2ZlBJaFBPaEhaTUZNNGVmUmNUem85?=
 =?utf-8?B?aEEzVTRENjVtRjRpaVp1YVVqS2xyckVKOHViZTVSMGU2N01LTlRzVGgzRERn?=
 =?utf-8?B?TEZ6SEhYMUh4blJFcnpBWVloQ2dER01zSlpuK2U3ZTROdDNVZ3RCcFVlRUQ0?=
 =?utf-8?B?R1B6T0ZiaE1EbklxTkhXREhMeW9yTkh1MG1jRmgrUHhUTGp5NnBvV2hoVFE5?=
 =?utf-8?B?MW85K2x5c0FKZVY5Q2c4aFErRHZIbk9TS3NRVUxiYk1KRHkvbG1FcHRsYzhj?=
 =?utf-8?B?ZmxIdThweTBWMTZjU2dCV2s1amhsSHQ3RHJjd253UE5PbGRGSXgvTmR1T3R4?=
 =?utf-8?B?TnBGV3FvOXlwT0V1QnMyWTFHL3laWnhHOHR3aVVqaSt5R0V2eXlnMGIzOXM2?=
 =?utf-8?B?VXhyOC84Vm9FRXlUV3AwY2JUZDhKRVY0a3hEUTdrUERGdVJmRk1yQXVVMzNM?=
 =?utf-8?B?TktEYXJ1WmpqdmJ6dlBIUTVPaTdua2dZU0ZGRmFxaWhtSVJFTlEyYW4rSSsx?=
 =?utf-8?B?MEdkazBsQkdJakp0N2E3UHZWVzdlM2NxbUwyTzBVci9YNndUQmFnazNsQWVv?=
 =?utf-8?B?cG1jcExJTThLM0x0SURRZnN0V250UUVEd0FuYWFSeWY4REFiT2hoc1d6eWdY?=
 =?utf-8?B?T1I4R2hONit5Z1lxS0s2R0toaXdQM2x6T1JYbDRrMUREaFF4S09PVndENkow?=
 =?utf-8?B?SDg5aFJTZTAyc3FVQlNySW1pWEJBYnl0NE9rOWFTZ2h2ZjRERXA5U05iby9r?=
 =?utf-8?B?UWlEQ243WURmZ1JGZ3JPd0lqZWZKdlBSN3h1OTJpUlNVNm5XMCtxbU5GZ2pV?=
 =?utf-8?B?TTVWQjdhYy9vY3VOYzgwUUdZR0RDOVpkc3FiSVFiN1p0UVIxcVpkUk1ERDV4?=
 =?utf-8?B?aWZlUmlwQkdBU0tyMGt4R1ZiUG8xS1J4c2JSZzZtRys4czV5ODdpdXBHdk5l?=
 =?utf-8?B?Vm1Xd0pTL3FvRWRYYmt5ZTc0YktONXlna2xEZVdCaUI2dHlkQW11SHgvSldD?=
 =?utf-8?B?WFhJUmhYM0JwSGZESXJEWU9GQnVZZXZvMWJTVFhoemx0RVhKcEpreGQ4L2sv?=
 =?utf-8?B?ckg0VFlpNlhadi9yUXJraThLVFV3dlpmeDJnRjhCeUpmb0xrUDZPUjVnV1F6?=
 =?utf-8?B?dHBkOEJTQlBhVnVIYlJscENJSmd5UHRKcWxnd0Y4VndzakVGWm9pMHdyYitI?=
 =?utf-8?B?UzZFM3ZGMGgrZVREWEdFL3JZVExzTzY2TVc4K0pvVStxaFNYQTM1a1c4WC9D?=
 =?utf-8?B?SmxtQzVxVE5OWTJCeTVuQzJ6YmkrT2RCMW1jRFhPTnMyTythamVnN0JvdWtB?=
 =?utf-8?B?amh3S3FQUC9CWEdpd2grL3hsR0hneWkrSGhXWFR3SVdCc0NKSjltckVrMVBL?=
 =?utf-8?B?TkovZ3VwR2h6anYrdjM1Z29XK2ZHM1NaUmIvSlVZakM4TCtuY29rbHlkOWt0?=
 =?utf-8?B?TjdsM0tzbnVRRWF4eDVOb2NRd3ZCcUNReCsrU0MvS2N4TGxKMFgrQzV3RTJB?=
 =?utf-8?B?QXhValBFcm9pR3ZkOWVwTzZ1Y0crNFBlbU9BZTlZWDVkZE9jT3daTkFRdVNF?=
 =?utf-8?B?TjVtcmV6U3hNTk95QmxFR25HWXVYMHpSQ1lreTU2RStQTVcwbk9oNExUMVk4?=
 =?utf-8?B?L1dSMGJBSFFsT1I0RElpSmQrbXZ1aUhtc1hnQ3BEZmx1Y0gvblhRc25xU3JQ?=
 =?utf-8?B?K01YOTI4bGg1SFpGQWh5RXBYSWgyWWJ3Ym5vTU1WM3ZyRFJqY3pFazVlU3Rm?=
 =?utf-8?B?dzliZ1NUdmNLK3hEVTFuMnpzaDJIQlRUYmQ3K0lzUVZybWpveGJxU0I4YllI?=
 =?utf-8?B?MzFyeWViYU1rbDdJWE1wRjUzbUFMRHhScjZ3T09kb3J4THlRRXd5Q3owMTlH?=
 =?utf-8?B?cTllei8vOFhsMWxYMjdWM2h0VVQyaDJwdDkyRmNONFZZTVRiS09TR042UW5r?=
 =?utf-8?B?YTFyR21mc0NYenZNY2hma0JRbGl4VUFZTnY0aFNCbkVBVDVPV1VKbFBFRmlL?=
 =?utf-8?B?MUt2cjJFQ1lSejVtM1htdXF5cjFyOTZNWURSbGhZWm9zWmdkUUtZdm84aERl?=
 =?utf-8?B?QzRQV0VFRG5FNEI0VW9LYmtNQTlnM3EvdnFjRFliclAxSGFaaU05cUtuZ1dM?=
 =?utf-8?B?NEtNYjNldjlJNXlCdHF0RWVYS01ITDBRS2JkZVFuSGNtaHVBRDNRUWs3d2E2?=
 =?utf-8?B?U21PV2wvNVlRNW1QTHdXMHZ2ME9Za3lVS1lHY1JDV3B2ckM4WnZCU3dWbFJx?=
 =?utf-8?B?VUN6empmQjFuMnVzekg4djZlSkJnd3NmcTNQUURHNURxOUMxTDhFUT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <7DD8B8CC1E70F94C88C204F88ECF2761@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b751625-5a25-431c-9b04-08d9bfc20054
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 11:56:59.8803
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ykol727qKtpMv3hc3a3stATwkS/bhZYMp0vq5YCKXJHQ9eiDFKMkj+wTG/lvGnghlyHB9Q4fir1KiZ74XPf0YRhrJhZ4+hABsl8zwFy5zW+Edz9M9o9MkUgyIhiF5Ac7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5796
X-Proofpoint-GUID: PgXLkbkbKBzEh7daz_lUo4csGjO6nzF0
X-Proofpoint-ORIG-GUID: PgXLkbkbKBzEh7daz_lUo4csGjO6nzF0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_08,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015
 bulkscore=0 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0
 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112150066

RGVhciByZXN0IG1haW50YWluZXJzIQ0KDQpDb3VsZCB5b3UgcGxlYXNlIHJldmlldyB0aGlzIHNl
cmllcyB3aGljaCBzZWVtcyB0byBnZXQgc3R1Y2s/DQoNClRoYW5rIHlvdSBpbiBhZHZhbmNlLA0K
T2xla3NhbmRyDQoNCk9uIDI1LjExLjIxIDEzOjAyLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3
cm90ZToNCj4gRnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNo
Y2hlbmtvQGVwYW0uY29tPg0KPg0KPiBIaSwgYWxsIQ0KPg0KPiAxLiBUaGlzIHBhdGNoIHNlcmll
cyBpcyBmb2N1c2luZyBvbiB2UENJIGFuZCBhZGRzIHN1cHBvcnQgZm9yIG5vbi1pZGVudGl0eQ0K
PiBQQ0kgQkFSIG1hcHBpbmdzIHdoaWNoIGlzIHJlcXVpcmVkIHdoaWxlIHBhc3NpbmcgdGhyb3Vn
aCBhIFBDSSBkZXZpY2UgdG8NCj4gYSBndWVzdC4gVGhlIGhpZ2hsaWdodHMgYXJlOg0KPg0KPiAt
IEFkZCByZWxldmFudCB2cGNpIHJlZ2lzdGVyIGhhbmRsZXJzIHdoZW4gYXNzaWduaW5nIFBDSSBk
ZXZpY2UgdG8gYSBkb21haW4NCj4gICAgYW5kIHJlbW92ZSB0aG9zZSB3aGVuIGRlLWFzc2lnbmlu
Zy4gVGhpcyBhbGxvd3MgaGF2aW5nIGRpZmZlcmVudA0KPiAgICBoYW5kbGVycyBmb3IgZGlmZmVy
ZW50IGRvbWFpbnMsIGUuZy4gaHdkb20gYW5kIG90aGVyIGd1ZXN0cy4NCj4NCj4gLSBFbXVsYXRl
IGd1ZXN0IEJBUiByZWdpc3RlciB2YWx1ZXMgYmFzZWQgb24gcGh5c2ljYWwgQkFSIHZhbHVlcy4N
Cj4gICAgVGhpcyBhbGxvd3MgY3JlYXRpbmcgYSBndWVzdCB2aWV3IG9mIHRoZSByZWdpc3RlcnMg
YW5kIGVtdWxhdGVzDQo+ICAgIHNpemUgYW5kIHByb3BlcnRpZXMgcHJvYmUgYXMgaXQgaXMgZG9u
ZSBkdXJpbmcgUENJIGRldmljZSBlbnVtZXJhdGlvbiBieQ0KPiAgICB0aGUgZ3Vlc3QuDQo+DQo+
IC0gSW5zdGVhZCBvZiBoYW5kbGluZyBhIHNpbmdsZSByYW5nZSBzZXQsIHRoYXQgY29udGFpbnMg
YWxsIHRoZSBtZW1vcnkNCj4gICAgcmVnaW9ucyBvZiBhbGwgdGhlIEJBUnMgYW5kIFJPTSwgaGF2
ZSB0aGVtIHBlciBCQVIuDQo+DQo+IC0gVGFrZSBpbnRvIGFjY291bnQgZ3Vlc3QncyBCQVIgdmll
dyBhbmQgcHJvZ3JhbSBpdHMgcDJtIGFjY29yZGluZ2x5Og0KPiAgICBnZm4gaXMgZ3Vlc3QncyB2
aWV3IG9mIHRoZSBCQVIgYW5kIG1mbiBpcyB0aGUgcGh5c2ljYWwgQkFSIHZhbHVlIGFzIHNldA0K
PiAgICB1cCBieSB0aGUgaG9zdCBicmlkZ2UgaW4gdGhlIGhhcmR3YXJlIGRvbWFpbi4NCj4gICAg
VGhpcyB3YXkgaGFyZHdhcmUgZG9hbWluIHNlZXMgcGh5c2ljYWwgQkFSIHZhbHVlcyBhbmQgZ3Vl
c3Qgc2Vlcw0KPiAgICBlbXVsYXRlZCBvbmVzLg0KPg0KPiAyLiBUaGUgc2VyaWVzIGFsc28gYWRk
cyBzdXBwb3J0IGZvciB2aXJ0dWFsIFBDSSBidXMgdG9wb2xvZ3kgZm9yIGd1ZXN0czoNCj4gICAt
IFdlIGVtdWxhdGUgYSBzaW5nbGUgaG9zdCBicmlkZ2UgZm9yIHRoZSBndWVzdCwgc28gc2VnbWVu
dCBpcyBhbHdheXMgMC4NCj4gICAtIFRoZSBpbXBsZW1lbnRhdGlvbiBpcyBsaW1pdGVkIHRvIDMy
IGRldmljZXMgd2hpY2ggYXJlIGFsbG93ZWQgb24NCj4gICAgIGEgc2luZ2xlIFBDSSBidXMuDQo+
ICAgLSBUaGUgdmlydHVhbCBidXMgbnVtYmVyIGlzIHNldCB0byAwLCBzbyB2aXJ0dWFsIGRldmlj
ZXMgYXJlIHNlZW4NCj4gICAgIGFzIGVtYmVkZGVkIGVuZHBvaW50cyBiZWhpbmQgdGhlIHJvb3Qg
Y29tcGxleC4NCj4NCj4gMy4gVGhlIHNlcmllcyBoYXMgY29tcGxldGUgcmUtd29yayBvZiB0aGUg
bG9ja2luZyBzY2hlbWUgdXNlZC9hYnNlbnQgYmVmb3JlIHdpdGgNCj4gdGhlIGhlbHAgb2YgdGhl
IHdvcmsgc3RhcnRlZCBieSBSb2dlciBbMV06DQo+IFtQQVRDSCB2NSAwMy8xM10gdnBjaTogbW92
ZSBsb2NrIG91dHNpZGUgb2Ygc3RydWN0IHZwY2kNCj4NCj4gVGhpcyB3YXkgdGhlIGxvY2sgY2Fu
IGJlIHVzZWQgdG8gY2hlY2sgd2hldGhlciB2cGNpIGlzIHByZXNlbnQsIGFuZA0KPiByZW1vdmFs
IGNhbiBiZSBwZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jaywgaW4gb3JkZXIgdG8gbWFr
ZQ0KPiBzdXJlIHRoZXJlIGFyZSBubyBhY2Nlc3NlcyB0byB0aGUgY29udGVudHMgb2YgdGhlIHZw
Y2kgc3RydWN0Lg0KPiBQcmV2aW91c2x5IHJlbW92YWwgY291bGQgcmFjZSB3aXRoIHZwY2lfcmVh
ZCBmb3IgZXhhbXBsZSwgc2luY2UgdGhlDQo+IGxvY2sgd2FzIGRyb3BwZWQgcHJpb3IgdG8gZnJl
ZWluZyBwZGV2LT52cGNpLg0KPiBUaGlzIGFsc28gc29sdmVzIHN5bmNocm9uaXphdGlvbiBpc3N1
ZXMgYmV0d2VlbiBhbGwgdlBDSSBjb2RlIGVudGl0aWVzDQo+IHdoaWNoIGNvdWxkIHJ1biBpbiBw
YXJhbGxlbC4NCj4NCj4gNC4gVGhlcmUgaXMgYW4gb3V0c3RhbmRpbmcgVE9ETyBsZWZ0IHVuaW1w
bGVtZW50ZWQgYnkgdGhpcyBzZXJpZXM6DQo+IGZvciB1bnByaXZpbGVnZWQgZ3Vlc3RzIHZwY2lf
e3JlYWR8d3JpdGV9IG5lZWQgdG8gYmUgcmUtd29ya2VkDQo+IHRvIG5vdCBwYXNzdGhyb3VnaCBh
Y2Nlc3NlcyB0byB0aGUgcmVnaXN0ZXJzIG5vdCBleHBsaWNpdGx5IGhhbmRsZWQNCj4gYnkgdGhl
IGNvcnJlc3BvbmRpbmcgdlBDSSBoYW5kbGVyczogd2l0aG91dCBmaXhpbmcgdGhhdCBwYXNzdGhy
b3VnaA0KPiB0byBndWVzdHMgaXMgY29tcGxldGVseSB1bnNhZmUgYXMgWGVuIGFsbG93cyB0aGVt
IGZ1bGwgYWNjZXNzIHRvDQo+IHRoZSByZWdpc3RlcnMuDQo+DQo+IFhlbiBuZWVkcyB0byBiZSBz
dXJlIHRoYXQgZXZlcnkgcmVnaXN0ZXIgYSBndWVzdCBhY2Nlc3NlcyBpcyBub3QNCj4gZ29pbmcg
dG8gY2F1c2UgdGhlIHN5c3RlbSB0byBtYWxmdW5jdGlvbiwgc28gWGVuIG5lZWRzIHRvIGtlZXAg
YQ0KPiBsaXN0IG9mIHRoZSByZWdpc3RlcnMgaXQgaXMgc2FmZSBmb3IgYSBndWVzdCB0byBhY2Nl
c3MuDQo+DQo+IEZvciBleGFtcGxlLCB3ZSBzaG91bGQgb25seSBleHBvc2UgdGhlIFBDSSBjYXBh
YmlsaXRpZXMgdGhhdCB3ZSBrbm93DQo+IGFyZSBzYWZlIGZvciBhIGd1ZXN0IHRvIHVzZSwgaS5l
LjogTVNJIGFuZCBNU0ktWCBpbml0aWFsbHkuDQo+IFRoZSByZXN0IG9mIHRoZSBjYXBhYmlsaXRp
ZXMgc2hvdWxkIGJlIGJsb2NrZWQgZnJvbSBndWVzdCBhY2Nlc3MsDQo+IHVubGVzcyB3ZSBhdWRp
dCB0aGVtIGFuZCBkZWNsYXJlIHNhZmUgZm9yIGEgZ3Vlc3QgdG8gYWNjZXNzLg0KPg0KPiBBcyBh
IHJlZmVyZW5jZSB3ZSBtaWdodCB3YW50IHRvIGxvb2sgYXQgdGhlIGFwcHJvYWNoIGN1cnJlbnRs
eSB1c2VkDQo+IGJ5IFFFTVUgaW4gb3JkZXIgdG8gZG8gUENJIHBhc3N0aHJvdWdoLiBBIHZlcnkg
bGltaXRlZCBzZXQgb2YgUENJDQo+IGNhcGFiaWxpdGllcyBrbm93biB0byBiZSBzYWZlIGZvciB1
bnRydXN0ZWQgYWNjZXNzIGFyZSBleHBvc2VkIHRvIHRoZQ0KPiBndWVzdCBhbmQgcmVnaXN0ZXJz
IG5lZWQgdG8gYmUgZXhwbGljaXRseSBoYW5kbGVkIG9yIGVsc2UgYWNjZXNzIGlzDQo+IHJlamVj
dGVkLiBYZW4gbmVlZHMgYSBmYWlybHkgc2ltaWxhciBtb2RlbCBpbiB2UENJIG9yIGVsc2Ugbm9u
ZSBvZg0KPiB0aGlzIHdpbGwgYmUgc2FmZSBmb3IgdW5wcml2aWxlZ2VkIGFjY2Vzcy4NCj4NCj4g
NS4gVGhlIHNlcmllcyB3YXMgYWxzbyB0ZXN0ZWQgb246DQo+ICAgLSB4ODYgUFZIIERvbTAgYW5k
IGRvZXNuJ3QgYnJlYWsgaXQuDQo+ICAgLSB4ODYgSFZNIHdpdGggUENJIHBhc3N0aHJvdWdoIHRv
IERvbVUgYW5kIGRvZXNuJ3QgYnJlYWsgaXQuDQo+DQo+IFRoYW5rIHlvdSwNCj4gT2xla3NhbmRy
DQo+DQo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAxODA3MTcwOTQ4
MzAuNTQ4MDYtMi1yb2dlci5wYXVAY2l0cml4LmNvbS8NCj4NCj4gT2xla3NhbmRyIEFuZHJ1c2hj
aGVua28gKDEzKToNCj4gICAgcmFuZ2VzZXQ6IGFkZCBSQU5HRVNFVEZfbm9fcHJpbnQgZmxhZw0K
PiAgICB2cGNpOiBmaXggZnVuY3Rpb24gYXR0cmlidXRlcyBmb3IgdnBjaV9wcm9jZXNzX3BlbmRp
bmcNCj4gICAgdnBjaTogY2FuY2VsIHBlbmRpbmcgbWFwL3VubWFwIG9uIHZwY2kgcmVtb3ZhbA0K
PiAgICB2cGNpOiBhZGQgaG9va3MgZm9yIFBDSSBkZXZpY2UgYXNzaWduL2RlLWFzc2lnbg0KPiAg
ICB2cGNpL2hlYWRlcjogaW1wbGVtZW50IGd1ZXN0IEJBUiByZWdpc3RlciBoYW5kbGVycw0KPiAg
ICB2cGNpL2hlYWRlcjogaGFuZGxlIHAybSByYW5nZSBzZXRzIHBlciBCQVINCj4gICAgdnBjaS9o
ZWFkZXI6IHByb2dyYW0gcDJtIHdpdGggZ3Vlc3QgQkFSIHZpZXcNCj4gICAgdnBjaS9oZWFkZXI6
IGVtdWxhdGUgUENJX0NPTU1BTkQgcmVnaXN0ZXIgZm9yIGd1ZXN0cw0KPiAgICB2cGNpL2hlYWRl
cjogcmVzZXQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgd2hlbiBhZGRpbmcgZGV2aWNlcw0KPiAgICB2
cGNpOiBhZGQgaW5pdGlhbCBzdXBwb3J0IGZvciB2aXJ0dWFsIFBDSSBidXMgdG9wb2xvZ3kNCj4g
ICAgeGVuL2FybTogdHJhbnNsYXRlIHZpcnR1YWwgUENJIGJ1cyB0b3BvbG9neSBmb3IgZ3Vlc3Rz
DQo+ICAgIHhlbi9hcm06IGFjY291bnQgSU8gaGFuZGxlcnMgZm9yIGVtdWxhdGVkIFBDSSBNU0kt
WA0KPiAgICB2cGNpOiBhZGQgVE9ETyBmb3IgdGhlIHJlZ2lzdGVycyBub3QgZXhwbGljaXRseSBo
YW5kbGVkDQo+DQo+IFJvZ2VyIFBhdSBNb25uZSAoMSk6DQo+ICAgIHZwY2k6IG1vdmUgbG9jayBv
dXRzaWRlIG9mIHN0cnVjdCB2cGNpDQo+DQo+ICAgdG9vbHMvdGVzdHMvdnBjaS9lbXVsLmggICAg
ICAgfCAgIDUgKy0NCj4gICB0b29scy90ZXN0cy92cGNpL21haW4uYyAgICAgICB8ICAgNCArLQ0K
PiAgIHhlbi9hcmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgIDMzICsrKy0NCj4gICB4ZW4vYXJj
aC94ODYvaHZtL3Ztc2kuYyAgICAgICB8ICAgOCArLQ0KPiAgIHhlbi9jb21tb24vcmFuZ2VzZXQu
YyAgICAgICAgIHwgICA1ICstDQo+ICAgeGVuL2RyaXZlcnMvS2NvbmZpZyAgICAgICAgICAgfCAg
IDQgKw0KPiAgIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIHwgIDExICsrDQo+ICAgeGVu
L2RyaXZlcnMvdnBjaS9oZWFkZXIuYyAgICAgfCAzNTIgKysrKysrKysrKysrKysrKysrKysrKysr
KysrLS0tLS0tLQ0KPiAgIHhlbi9kcml2ZXJzL3ZwY2kvbXNpLmMgICAgICAgIHwgIDExICstDQo+
ICAgeGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMgICAgICAgfCAgIDggKy0NCj4gICB4ZW4vZHJpdmVy
cy92cGNpL3ZwY2kuYyAgICAgICB8IDI1MiArKysrKysrKysrKysrKysrKysrKystLS0NCj4gICB4
ZW4vaW5jbHVkZS94ZW4vcGNpLmggICAgICAgICB8ICAgNiArDQo+ICAgeGVuL2luY2x1ZGUveGVu
L3Jhbmdlc2V0LmggICAgfCAgIDcgKy0NCj4gICB4ZW4vaW5jbHVkZS94ZW4vc2NoZWQuaCAgICAg
ICB8ICAgOCArDQo+ICAgeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgICAgICAgfCAgNDcgKysrKy0N
Cj4gICAxNSBmaWxlcyBjaGFuZ2VkLCA2NDQgaW5zZXJ0aW9ucygrKSwgMTE3IGRlbGV0aW9ucygt
KQ0KPg0K


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 12:07:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 12:07:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247347.426494 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxT4Q-0001hN-A5; Wed, 15 Dec 2021 12:07:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247347.426494; Wed, 15 Dec 2021 12:07:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxT4Q-0001hG-72; Wed, 15 Dec 2021 12:07:42 +0000
Received: by outflank-mailman (input) for mailman id 247347;
 Wed, 15 Dec 2021 12:07:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=E5lv=RA=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxT4O-0001gi-Oj
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 12:07:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99170540-5d9f-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 13:07:39 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-DxGG4ctFMGKxak2UNYO1ig-1; Wed, 15 Dec 2021 13:07:37 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.25; Wed, 15 Dec
 2021 12:07:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 12:07:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99170540-5d9f-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639570059;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=nxyhZTlEzR5YCpYo4L4Y4mwpF9Atr6VzvbS9ubaWdmo=;
	b=KYzN9dD7w3U7JJ5FaS6dUmUVkAzxIZ/pJm8uo5bblZfwzqYdVpIgwvRctZaApoSZcNoBxY
	FV94wL4Kopa33W/ihFzP+IzINHwVEheDIGZKOaG3aQY6XmyzQYzz0GyQhDMsFrDdC8g/3V
	Y695ns7sIyakKQQSJkPImEut0L0wgL4=
X-MC-Unique: DxGG4ctFMGKxak2UNYO1ig-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JMKvDw7En3wVFDrNERdFbg+EL5Efd9oo99hWBwa6a9JFZDw0Gpv6sTjO0rJ7yBP3lyobvpdQYwPONi7CizrmtYR4yfeAtmg+5RcnKzQNXSJRTrdZIhaVNnapwZiK9iv5KhJ6ajLStK3DEXtyzPL9g0n/D8Fl+E/s2OADEpOlixSWLc9DLnTjSGNKIl7clh/sIm0zD48ACaFK0iyUYrFpYhaPoEQwJRU5Gkv0OlEHxL/cJvoQ7727ts4kQxmgx1ohBA4cJ1Oy98uv8zxrqPcC/QmAgJycucPhN+uwSKDa1x8LfcYOcbdziOKHnZcojtzZx7svro8h0CERMYwWremBxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nxyhZTlEzR5YCpYo4L4Y4mwpF9Atr6VzvbS9ubaWdmo=;
 b=dImBW6oS1NURllzz9cKA+zU88PXj2wls3MVKDgNxsQdmGLX0hC+8Pg0sW6SBaIbyTcdxo8s2aBWDuviPNOc76vsPjWPlQJ/ikh1GpTi49a05/ph7I2kZLoecwMAQliVVGJiH9r+Z2hwempuW5hifx8VXAyh6l+KBfVzJmzDDXkyFBrG4C2jLVWOXV413kDI/t/fI4q8f8E6/JL2AV1XkIEgnthSEC2j2ZVCIfGC86C3RXssq5LA7hUzebW/zPau0bNK8mc3ygLxEaMX9mR8AeHbCx9AiEVKrlae5zGGrYDPWv0QohqqO+pLGn1rPUzm1l/Jti7lfYnXEADhnW1McyA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <79466492-fd58-1be0-c47e-13fc1e17479d@suse.com>
Date: Wed, 15 Dec 2021 13:07:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Content-Language: en-US
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Cc: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 "roger.pau@citrix.com" <roger.pau@citrix.com>, "paul@xen.org"
 <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, "julien@xen.org" <julien@xen.org>,
 "sstabellini@kernel.org" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FRYP281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::17)
 To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 56f840b9-ec58-46cf-8677-08d9bfc37ada
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533A0FD13209013A9D028C4B3769@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	aFSutYcQQkez6sTuemjeNSp06haCbkWAXn1hvj+q8etHRskJLTu4KQM8ThyZ6HwCyTt8XHKF4hEphgyMCLgpBk6OxsNO2rMk/8O3e5FTxS270SaIfIzVKO6LVDso7ncjp1ZkRsDyBIoh/AVtVzCaZBaZhTE27yINjhZFixaSZke4BXB2r4mFJej5EzQ9Kgi1F8HZFLoUBgi6OU8nNudVWHUZkOk2LwV2XNp2+aMeHfdZPJysIIGjvBbPrH0oScH289FmKD3whNdk7xvLRLEzyro39Hq2xAmXVyAgjK4xN56JnB66PR25X/SOZHLbTdovdc9Rmk1LfIiWUacy50Vpj/+15U8R4jeX4BwMYKlJ4NKhrxZYzWAXf7iyVnd1RzdjaRWxhFRbMZFUmGxb676iO07dvKdpTRnpXRn6LkRPqYprpKERIR7fHu+gMWJZSXNixPi7LHDOWfR5yMlxrlVJoSIYArRQr09GmVfPLjYB9fnbKIn3jac4DuDh8KnptP+WLxYlx+IChn2egxGVNy/ZQWDkTuKbORcg+wJR0hD93DaG5XT5joYxTt36kQ9CkajfTj4lG3Qs+jfgiAPohJ+WFeZV6NEZizVh8ZfdzE69/KJMqjdpXQXfeJf7vFX4lyWziTR11AD5NYb8kwr2z+dt61JjZP1C6/OHn2fV28uGf/oiYuu97e1u5y6PjL+NKyHm9zcH8+8Xs0B3fKf1f5Vn+z+CfkvOx61Osy9USXOz3M5BxZnP/BArgMHLUg+2sAH9e0md9K6SgYIENhAbW8B/NVDzPH2HS/X7xmdFYliwGm+dZqkCWfQm72ApS3acV7Bn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(5660300002)(54906003)(2906002)(966005)(83380400001)(6916009)(26005)(86362001)(8936002)(66476007)(2616005)(6512007)(6486002)(186003)(66556008)(508600001)(7416002)(8676002)(36756003)(66946007)(53546011)(316002)(31696002)(38100700002)(4326008)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N2FRalhhTEhNd09FNTkvdDg1TTZXaGVqdm40TjVlVS9aTEJLNEJRQzBLUU1L?=
 =?utf-8?B?U2hSTUZtNXVHTWJXRmVtS2FZeG5MM3F6bE55SHBPbTJPcFRrWjZuMlNPVmRE?=
 =?utf-8?B?NDM0RGZMb1pXY2lYbDhhVFdtUDdQMlk3QVNEcm5qT2h1UTBVVkZUb0pUblhh?=
 =?utf-8?B?ZTBsdXFySlJPSzVQMUtMR2ZUcU9XenNudDRRaXNmOGE5MmxlMXRkR05PVXl1?=
 =?utf-8?B?dDUxamVlMmpRS1VsTzJReU5yUFBPbHdKbkF5aCtSRlhHWmhxTU5zK2lZWkRN?=
 =?utf-8?B?MWZIQm96alR1b2I0d2ZNSkE2UmZQclpISzFsSVJFRzczWmVManlCZmJudVp1?=
 =?utf-8?B?OUFNb2doQVA4Y2NneGhSMkZoNzlaZXZFOStVZ0NKckRnejJaMHIrL0tPdUxt?=
 =?utf-8?B?NUFTNUo0V2s3WXM0M2ZweE5mY1V0V2ROQUtTTi9ocThBRHJQZFZGcGFKa0Zv?=
 =?utf-8?B?NDJkZnVHVldzTnY3cncrajJTeEhMVTlSUkkrU2xoOVU5NDZMaUpLUjd5YjRP?=
 =?utf-8?B?Mmg3Zys2Rkw5eGJWWU5rcnFEYytYb2FKdlB6MnVoNGI3U0hWUU5Cdi9UQ0da?=
 =?utf-8?B?dmFQREkzSEUrVUIvOVd4c1h6ZG1nQU96eXZYUVJTdnByN281RlFKOC9leFdr?=
 =?utf-8?B?OTFoR0RZK2tlZHQ5VTRLcXJpWEw5QUVISytLaC9MMERnaHFEaTBycmxzdVhk?=
 =?utf-8?B?TlViOTgrajJNMzMzSWZzYnRxT05PMjVMSEJSV1N6SkNNWVN5WHkzNDYxY2Rn?=
 =?utf-8?B?THNYcHhxMFdYUjJ2Ukc4S05HVE5yMmlZWXBYdFJrT0pPSXF3VUU2TnAxWFJK?=
 =?utf-8?B?TUZQRUxQdXZ1dWJFekdyOXdIazBMeHR2MHhoUmNucVp2RHlEa09CaFVqNEVE?=
 =?utf-8?B?QTgreXVKVFRRUE9pK0lqb3JuYjR3cm9sMEtQTzB4S2RhMUlESTZnemNDRzJE?=
 =?utf-8?B?dkdBVkEwWlovSFBmaDhGb291MERYc3Z0cnVxOW5xQmNTMkYwWEszNThCQW5M?=
 =?utf-8?B?TlI4NTgvQUFQUnVyMzVXVExWYm0rUml3RVoySmpYWXdKV0NOWlFvdmhjQkwx?=
 =?utf-8?B?bzAzWXRKMHN1ZUdKU0V4T2VWeUZiSTgyemhuMU95VmgyTXE1NWkvT3BMQlRS?=
 =?utf-8?B?eVlPREZqTDIrVmZJdFAyR2ZnbFRCbTJPUTNEQlJHWkt2OHNGbnJTS3IrcURS?=
 =?utf-8?B?SXZLZk5WWkEwUEttVE11OTRiYXUvc0V3QWN1Zy9xeFFGU2JMM0xibUkwSkdK?=
 =?utf-8?B?WHU4bTRCL1JjVXpOMmRtRFBocG1aZmJMcVJ6L3UweDhEeGk3NFMra29Zc2Y3?=
 =?utf-8?B?eXBTN1pVMjhWMGR3V1Z0ZzJGMnlkZ2Q3Zlk1eFQrYWpYMUxpOSs5S2EvQWZK?=
 =?utf-8?B?aWNram9xbDN0RHI5OVllZEZUMzZmWWJXaEhxMXJ3UVNjL3JsdEFEQzlLVW54?=
 =?utf-8?B?OWg3MGI4aTRUR0NxNXhsN2ZMKzl5WkdMblFsWFM1VE9meEhtcFFYdVdmK243?=
 =?utf-8?B?eWQ5TTlBSlZwbVhsMmtKaDk1ZnhlckluTHd0YmhQMzNWODJWMUtGbVA3Ryt4?=
 =?utf-8?B?cDI5elhPZTUyekpBUS9rSWo2OEJwLzZOQ0syWkMrNGdoREExVTAycklrcEs1?=
 =?utf-8?B?RUpPWThncS9OR2NBT3VsVHNpdGM4bGhySjgweEY4REpNMXNqRmdkb3FQRVpt?=
 =?utf-8?B?L2s1d3V2V2s2RFpwZE5HaFROQ0pHMy9ZMmNPd2E4c21GcUovNnNjbk12bkJV?=
 =?utf-8?B?RTdCZ05MNnJIVUtWQTIzMHVRYU5PNXUrbEIwOHZCSi9PRXdOQ1Y0ZU5zZkc2?=
 =?utf-8?B?d2RhQm9FL25NeTQ3NHpodTE3eDFRTVpXR0lJazNsaWxXNGdoQlBoU0RUQkk4?=
 =?utf-8?B?SjZSUDVtRG1qSWsrdHhrVUhiS1AvOVB6cGZUamowY3lKck9vVFRxdEE1NzFZ?=
 =?utf-8?B?d3ZwanRXSGx4MWFVcGVFOExzM0VPNFpreGZnLy8zUWhxeE9HY2luYXpTdmNl?=
 =?utf-8?B?Y0VKa21jU3g1RHlQZUVNdER1MDBKS01wKzhqV3R6RWM0b05ud3c1b1RQZlVi?=
 =?utf-8?B?cGpyRThYY3FsQ0h0TGJXSysrbDNZWGQyNXZhNzRZSlJQazVVb3p5ZHVnbHlw?=
 =?utf-8?B?NTd5dFh1VjVhMW55bmE5cnF1RU1UcWxDRVYraExFRWtLQTlCQTFGRExKYUUy?=
 =?utf-8?Q?qzgW1B01sj7AHkE/p3qM2S4=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56f840b9-ec58-46cf-8677-08d9bfc37ada
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 12:07:35.1914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QXwOjCmoPt3x8ynqZToOn2gSKlQJlG+oBtWO6IvOU60C2l5d284UAxJxh+J7hHJQuoOJVYpiunIAgQUiFvSnCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 15.12.2021 12:56, Oleksandr Andrushchenko wrote:
> Dear rest maintainers!
> 
> Could you please review this series which seems to get stuck?

I don't seem to have any record of you having pinged Roger as the vPCI
maintainer. Also, as said on the Community Call when discussing this,
I don't think I'd view this series as in a state where an emergency
fallback to REST would be appropriate. As indicated, in particular I
wouldn't want to commit any of it without Roger's basic agreement. IOW
while REST maintainer reviews may help making progress (but as much
would reviews by anyone else), they may not put the series in a state
where it could go in.

In any event, as also said on the call, afaic this series is in my to-
be-reviewed folder, alongside a few dozen more patches. I'll get to it
if nobody else would, but I can't predict when that's going to be.
There's simply too much other stuff in need of taking care of.

Jan

> Thank you in advance,
> Oleksandr
> 
> On 25.11.21 13:02, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> Hi, all!
>>
>> 1. This patch series is focusing on vPCI and adds support for non-identity
>> PCI BAR mappings which is required while passing through a PCI device to
>> a guest. The highlights are:
>>
>> - Add relevant vpci register handlers when assigning PCI device to a domain
>>    and remove those when de-assigning. This allows having different
>>    handlers for different domains, e.g. hwdom and other guests.
>>
>> - Emulate guest BAR register values based on physical BAR values.
>>    This allows creating a guest view of the registers and emulates
>>    size and properties probe as it is done during PCI device enumeration by
>>    the guest.
>>
>> - Instead of handling a single range set, that contains all the memory
>>    regions of all the BARs and ROM, have them per BAR.
>>
>> - Take into account guest's BAR view and program its p2m accordingly:
>>    gfn is guest's view of the BAR and mfn is the physical BAR value as set
>>    up by the host bridge in the hardware domain.
>>    This way hardware doamin sees physical BAR values and guest sees
>>    emulated ones.
>>
>> 2. The series also adds support for virtual PCI bus topology for guests:
>>   - We emulate a single host bridge for the guest, so segment is always 0.
>>   - The implementation is limited to 32 devices which are allowed on
>>     a single PCI bus.
>>   - The virtual bus number is set to 0, so virtual devices are seen
>>     as embedded endpoints behind the root complex.
>>
>> 3. The series has complete re-work of the locking scheme used/absent before with
>> the help of the work started by Roger [1]:
>> [PATCH v5 03/13] vpci: move lock outside of struct vpci
>>
>> This way the lock can be used to check whether vpci is present, and
>> removal can be performed while holding the lock, in order to make
>> sure there are no accesses to the contents of the vpci struct.
>> Previously removal could race with vpci_read for example, since the
>> lock was dropped prior to freeing pdev->vpci.
>> This also solves synchronization issues between all vPCI code entities
>> which could run in parallel.
>>
>> 4. There is an outstanding TODO left unimplemented by this series:
>> for unprivileged guests vpci_{read|write} need to be re-worked
>> to not passthrough accesses to the registers not explicitly handled
>> by the corresponding vPCI handlers: without fixing that passthrough
>> to guests is completely unsafe as Xen allows them full access to
>> the registers.
>>
>> Xen needs to be sure that every register a guest accesses is not
>> going to cause the system to malfunction, so Xen needs to keep a
>> list of the registers it is safe for a guest to access.
>>
>> For example, we should only expose the PCI capabilities that we know
>> are safe for a guest to use, i.e.: MSI and MSI-X initially.
>> The rest of the capabilities should be blocked from guest access,
>> unless we audit them and declare safe for a guest to access.
>>
>> As a reference we might want to look at the approach currently used
>> by QEMU in order to do PCI passthrough. A very limited set of PCI
>> capabilities known to be safe for untrusted access are exposed to the
>> guest and registers need to be explicitly handled or else access is
>> rejected. Xen needs a fairly similar model in vPCI or else none of
>> this will be safe for unprivileged access.
>>
>> 5. The series was also tested on:
>>   - x86 PVH Dom0 and doesn't break it.
>>   - x86 HVM with PCI passthrough to DomU and doesn't break it.
>>
>> Thank you,
>> Oleksandr
>>
>> [1] https://lore.kernel.org/xen-devel/20180717094830.54806-2-roger.pau@citrix.com/
>>
>> Oleksandr Andrushchenko (13):
>>    rangeset: add RANGESETF_no_print flag
>>    vpci: fix function attributes for vpci_process_pending
>>    vpci: cancel pending map/unmap on vpci removal
>>    vpci: add hooks for PCI device assign/de-assign
>>    vpci/header: implement guest BAR register handlers
>>    vpci/header: handle p2m range sets per BAR
>>    vpci/header: program p2m with guest BAR view
>>    vpci/header: emulate PCI_COMMAND register for guests
>>    vpci/header: reset the command register when adding devices
>>    vpci: add initial support for virtual PCI bus topology
>>    xen/arm: translate virtual PCI bus topology for guests
>>    xen/arm: account IO handlers for emulated PCI MSI-X
>>    vpci: add TODO for the registers not explicitly handled
>>
>> Roger Pau Monne (1):
>>    vpci: move lock outside of struct vpci
>>
>>   tools/tests/vpci/emul.h       |   5 +-
>>   tools/tests/vpci/main.c       |   4 +-
>>   xen/arch/arm/vpci.c           |  33 +++-
>>   xen/arch/x86/hvm/vmsi.c       |   8 +-
>>   xen/common/rangeset.c         |   5 +-
>>   xen/drivers/Kconfig           |   4 +
>>   xen/drivers/passthrough/pci.c |  11 ++
>>   xen/drivers/vpci/header.c     | 352 +++++++++++++++++++++++++++-------
>>   xen/drivers/vpci/msi.c        |  11 +-
>>   xen/drivers/vpci/msix.c       |   8 +-
>>   xen/drivers/vpci/vpci.c       | 252 +++++++++++++++++++++---
>>   xen/include/xen/pci.h         |   6 +
>>   xen/include/xen/rangeset.h    |   7 +-
>>   xen/include/xen/sched.h       |   8 +
>>   xen/include/xen/vpci.h        |  47 ++++-
>>   15 files changed, 644 insertions(+), 117 deletions(-)
>>



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 12:13:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 12:13:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247353.426504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTA4-0003Eq-VE; Wed, 15 Dec 2021 12:13:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247353.426504; Wed, 15 Dec 2021 12:13:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTA4-0003Ej-SK; Wed, 15 Dec 2021 12:13:32 +0000
Received: by outflank-mailman (input) for mailman id 247353;
 Wed, 15 Dec 2021 12:13:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4tZ4=RA=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxTA3-0003Ed-A4
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 12:13:31 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 694c1d7b-5da0-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 13:13:29 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44218)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxT9x-000za2-0t (Exim 4.95) (return-path <amc96@srcf.net>);
 Wed, 15 Dec 2021 12:13:25 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 0FBE61FB86;
 Wed, 15 Dec 2021 12:13:25 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 694c1d7b-5da0-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <1d937a49-e0a2-58a2-b51c-495a957adb0d@srcf.net>
Date: Wed, 15 Dec 2021 12:13:24 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Daniel Smith <dpsmith@apertussolutions.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211214211600.2751-1-andrew.cooper3@citrix.com>
 <b187ef25-bbfa-1880-0a10-462c2ba64e72@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86/cpuid: Introduce dom0-cpuid command line option
In-Reply-To: <b187ef25-bbfa-1880-0a10-462c2ba64e72@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 15/12/2021 08:34, Jan Beulich wrote:
> On 14.12.2021 22:16, Andrew Cooper wrote:
>> Specifically, this lets the user opt in to non-default for dom0.
>>
>> Split features[] out of parse_xen_cpuid(), giving it a lightly more
>> appropraite name, so it can be shared with parse_xen_cpuid().
> With the latter one I guess you mean parse_dom0_cpuid()?

I do, yes.  This is a copy/paste error.
>> Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply it
>> to dom0's policy when other tweaks are being made.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Daniel Smith <dpsmith@apertussolutions.com>
>>
>> RFC, because I think we've got a preexisting error with late hwdom here.  We
>> really should not be cobbering a late hwdom's settings (which were provided in
>> the usual way by the toolstack in dom0).
> For ITSC I think also covering late hwdom is at least acceptable. For the
> speculation controls I'm less certain (but as per the comment there they're
> temporary only anyway), and I agree the command line option here should
> strictly only apply to Dom0 (or else, as a minor aspect, the option also
> would better be named "hwdom-cpuid=").
>
>> Furthermore, the distinction gets more murky in a hyperlaunch future where
>> multiple domains may be constructed by Xen, and there is reason to expect that
>> a full toolstack-like configuration is made available for them.
> Like above, anything created via the toolstack interfaces should use the
> toolstack controls. If there was something dom0less-like on x86, domains
> created that way (without toolstack involvement) would instead want to
> have another way of controlling their CPUID settings.
>
>> One option might be to remove the special case from init_domain_cpuid_policy()
>> and instead make a call into the cpuid code from create_dom0().  It would have
>> to be placed between domain_create() and alloc_dom0_vcpu0() for dynamic sizing
>> of the FPU block to work.  Thoughts?
> As said above, I think the ITSC special case could stay. But apart from
> this I agree.

So I disagree with keeping the ITSC special case.

I do agree that a non-dom0 hwdom probably wants ITSC, but ITSC
explicitly can be controlled by the toolstack, and therefore Xen should
not be overriding the toolstack's decision.

IMO, this really does want to remain dom0-cpuid= rather than
hwdom-cpuid=.  It is specific to the domain which Xen creates as part of
bringing the system up.

In a future world with hyperlaunch/dom0less/etc, there is (or should be)
adequate provision to specify settings like this for all created
domains.  In this case, perhaps hyperlaunch declares that dom0-cpuid=
gets ignored, because we probably don't want random command line
settings impacting one N'th of the carefully curated system configuration.

(Also, any Xen constructed domains in a hyperlaunch world probably want
ITSC, but I'll again argue firmly that Xen should not be special-casing
this one feature.)
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -801,6 +801,22 @@ Controls for how dom0 is constructed on x86 systems.
>>  
>>      If using this option is necessary to fix an issue, please report a bug.
>>  
>> +### dom0-cpuid
>> +    = List of comma separated booleans
>> +
>> +    Applicability: x86
>> +
>> +This option allows for fine tuning of the facilities dom0 will use, after
>> +accounting for hardware capabilities and Xen settings as enumerated via CPUID.
>> +
>> +Options are accepted in positive and negative form, to enable or disable
>> +specific features.  All selections via this mechanism are subject to normal
>> +CPU Policy safety logic.
>> +
>> +This option is intended for developers to opt dom0 into non-default features,
>> +and is not intended for use in production circumstances.  If using this option
>> +is necessary to fix an issue, please report a bug.
> You may want to state explicitly that disables take priority over enables,
> as per the present implementation. Personally I would find it better if the
> item specified last took effect. This is, as mentioned in other contexts,
> so one can override earlier settings (e.g. in a xen.cfg file used with
> xen.efi) by simply appending to the command line.

Order of enabled/disabled I feel is an implementation detail.  Perhaps
what to put in the docs is that specifying both forms is unsupported,
but "this is for developers only" is already a fairly big hint.

The only way to make a latest-takes-priority scheme work is to use
string_param() (creating an arbitrary upper bound limit), and parsing
the list during dom0 construction.  For a developer-only option, I
really don't think the complexity is worth the effort.
>> @@ -97,6 +98,73 @@ static int __init parse_xen_cpuid(const char *s)
>>  }
>>  custom_param("cpuid", parse_xen_cpuid);
>>  
>> +static uint32_t __hwdom_initdata dom0_enable_feat[FSCAPINTS];
>> +static uint32_t __hwdom_initdata dom0_disable_feat[FSCAPINTS];
>> +
>> +static int __init parse_dom0_cpuid(const char *s)
>> +{
>> +    const char *ss;
>> +    int val, rc = 0;
>> +
>> +    do {
>> +        const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */;
>> +        const char *feat;
>> +
>> +        ss = strchr(s, ',');
>> +        if ( !ss )
>> +            ss = strchr(s, '\0');
>> +
>> +        /* Skip the 'no-' prefix for name comparisons. */
>> +        feat = s;
>> +        if ( strncmp(s, "no-", 3) == 0 )
>> +            feat += 3;
>> +
>> +        /* (Re)initalise lhs and rhs for binary search. */
>> +        lhs = feature_names;
>> +        rhs = feature_names + ARRAY_SIZE(feature_names);
>> +
>> +        while ( lhs < rhs )
>> +        {
>> +            int res;
>> +
>> +            mid = lhs + (rhs - lhs) / 2;
>> +            res = cmdline_strcmp(feat, mid->name);
>> +
>> +            if ( res < 0 )
>> +            {
>> +                rhs = mid;
>> +                continue;
>> +            }
>> +            if ( res > 0 )
>> +            {
>> +                lhs = mid + 1;
>> +                continue;
>> +            }
>> +
>> +            if ( (val = parse_boolean(mid->name, s, ss)) >= 0 )
>> +            {
>> +                __set_bit(mid->bit,
>> +                          val ? dom0_enable_feat : dom0_disable_feat);
>> +                mid = NULL;
>> +            }
>> +
>> +            break;
>> +        }
>> +
>> +        /*
>> +         * Mid being NULL means that the name and boolean were successfully
>> +         * identified.  Everything else is an error.
>> +         */
>> +        if ( mid )
>> +            rc = -EINVAL;
>> +
>> +        s = ss + 1;
>> +    } while ( *ss );
>> +
>> +    return rc;
>> +}
>> +custom_param("dom0-cpuid", parse_dom0_cpuid);
> I wonder whether it wouldn't be better (less duplication) if the bulk
> of the code was also shared with parse_xen_cpuid(). In return moving
> features[] wouldn't be needed then.

I wondered the same, but couldn't think of anything I liked.

I suppose an always_inline parse_cpuid(void (*cb)(feat, val)) wouldn't
be too bad.  We'd need 5 functions in total, but it will optimise back
to 2 with no function pointers.

~Andrew


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 12:22:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 12:22:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247360.426520 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTJ0-0004ss-VB; Wed, 15 Dec 2021 12:22:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247360.426520; Wed, 15 Dec 2021 12:22:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTJ0-0004sl-Qj; Wed, 15 Dec 2021 12:22:46 +0000
Received: by outflank-mailman (input) for mailman id 247360;
 Wed, 15 Dec 2021 12:22:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxTIy-0004sZ-Na
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 12:22:44 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b3867362-5da1-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 13:22:43 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFBQZMk002244;
 Wed, 15 Dec 2021 12:22:38 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cyab5seg5-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 12:22:38 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6322.eurprd03.prod.outlook.com (2603:10a6:20b:15e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Wed, 15 Dec
 2021 12:22:32 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 12:22:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3867362-5da1-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ffmsccOMbMiM4Y/vkmmomPdx8GVfot+ziwaR8CPAWr1WjG89iGY6a1zAG0l9yptEJkHfNZJSjJt66Xwd1rS9rxSHj0e0rSWH1JIxlxx/KPmwykSR/zPtxm76r4tYl4DAqsGTiMzHKCQ42pXuan6khR4jxeKjppvjHYcS8Z9RBHpA379UWXzhNmRdsRwZqZbs5jyEJS9Eg3bcysjMvUQN3prtlQ1INVx0ABLpi2csF8hP7u4cQC1d4HM+BQL2Yife6rhyFP8FrwbYbcgdrU+lHB8i/PP5yZZqp+qGEDAAOQ8OxUJjz4b1mQ0IP3UFCXRIt0ZD/ULLZez0+BiPj2y17g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=M7Lmew5aTXMFWs8lqfXf2jDqzpQ45MYbLfcf86EDmaI=;
 b=ZLS0dy5y/+jyDyUiC+x8pGEWsI7erEP8nkxmZOKShjO/Sfb1HYnjGfO2VCI0sz8Js9DtyDGPLQ4d24epGpDUmA5SVLOb+hE9sxsnccHj7FDNuDhY0SZAmd/dS1IE1FwYjS8jH32D12GlNiODdgzMY9e+ZOO9LRk/M7msx7N4Q777lF/2lJPFDzQgrgybaPXWfkYJIHKPg3e+kCmifG95GfXrL17osE9IiHQQ1uQuDVZ/iW0WUuYxuxGNf1RX9eGn6LsrbLzmuPYeklQBWAQv39CtoVR/ETS/Cb0jeZVNXyBfTFycSAggqPxrbiVVoPrFv7qmHrOuZIIyoSz/qNm0tQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=M7Lmew5aTXMFWs8lqfXf2jDqzpQ45MYbLfcf86EDmaI=;
 b=qG90m6rMGZTWkJEH774v34H6DQQxnxvYJMb7NZkETd//axI/RlgVeaoBr/F69AkrasjHzvOILBdz8rSY3gnEk63Ps7x/n9bCQ7WttWJQIi3W7XCo07n4XCtZ4t8oUQN1c83g77IjhS7iCJnF1pVDF+Wm2znxZMz6u3dxsSm4OtPCSt4xRWotHQiefxmIYM6ljqvhG3rx2pkdLxvUmgkBf1Fu/5hH2MnysiSy6qbReANB1RfOaelPfX7bhIerywoyDtfRGMVo6XfoLKgbUJQUuWTTSfyhPljS9M0zfBX5cGEAcwM5q9niJN2+SKzVedtdiHEqOhDU2ZoxkJ8dNjF8Gg==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        "roger.pau@citrix.com" <roger.pau@citrix.com>,
        "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Topic: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Index: AQHX4ewD/fiBagJockWfLYQGw/ZN1KwzkeKAgAAC9ICAAAQugA==
Date: Wed, 15 Dec 2021 12:22:32 +0000
Message-ID: <1103f95b-3345-f28f-1eed-7f26328d67fa@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
 <79466492-fd58-1be0-c47e-13fc1e17479d@suse.com>
In-Reply-To: <79466492-fd58-1be0-c47e-13fc1e17479d@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b037afab-0e6a-4ed6-f03b-08d9bfc59197
x-ms-traffictypediagnostic: AM0PR03MB6322:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB63225E0049B49222788E2427E7769@AM0PR03MB6322.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 tKaFGIv9bHxQ3yGCsSgKPkOtOuCtHWTbtcdt3pI5dqgIj0sooGVr8ZP9eoiuXLgwCht0BD9o0rs2qRSs/0TOo5T5l+SsdumliFu6u4/UO2JkCscj7wt4mQ5Z61TBVi8fkHkseG+HCXfpj3NcsvHh0j/SVnKwjdpEa5lvlooJrI1i18wF650V1UrfZDbk/C4oWmgklpt7hr3ptAqlJVwV+EOEFiBFERmLVasGgKgKMYsyaqlXx4QcDjodp2GFo6qh/3kkfAhH0aQ+UHdlXkfYHXuWGGdLiP5EzYaK+xBAQ6sIxLvXyw+LCdYL17XjxiszUYvubnZXRleANZ7O5ds6Hwdd7wPZ9wfMjnLg3oCKLrq17vetHz/OInYKfpDdC3IMhRiZXxRgAWPz3X1iedag1BYyFkxP/wTIj8NE1RjydpLXBysVbj6Ec/9hhLOt09gtxhWhZ2zNcH971hLCnBV6nTQOV6sFifIkcyPMTi1IG795mYaQs9zBmVbVPsPm6O7iSY1xNUZNieMWg3yq+AvE44yRTwTi8US2wAVpQTaWDAjBrdLGUSOy0OAxKlNzX1MuxtXmcQDaYbDPmyzXhB81UVrB2eh3fR7evjrDpNvEAfqCpDHh/tWJkdDVCDsQ7hAgB2N9McnIuhuAwkrMU0yt9ZnB0egQZjlz03dHF8HDakKtEQmriFMPl01/BmCEBB85DcwG3mARkhWBKzyTmyZNs6TpyWYCHWCLJ0YumezGuDDaVIefAWRhtx+6FiCYplb1p23ns/buVMR/rVrykvVbPSz9v9sV8HHsF7T4u7jo3mlEjTXz+kc2d2yhxiiGTO5lJGr/D/FV7t9Ig6a5y2ZSfA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7416002)(36756003)(38100700002)(8936002)(71200400001)(31686004)(6486002)(186003)(26005)(38070700005)(55236004)(5660300002)(8676002)(966005)(31696002)(86362001)(66946007)(66556008)(66476007)(53546011)(6512007)(6506007)(64756008)(4326008)(2906002)(316002)(6916009)(76116006)(91956017)(2616005)(83380400001)(66446008)(508600001)(122000001)(54906003)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?RG5oa1h3Y0g5Y1RTSmV6ZXcrNUZ4dkp6OFN6UElIQjNPcWFabmROdWx6ODNV?=
 =?utf-8?B?YTRIV2RZWndjcEhycXhscjMvcFFUdDZXejZYWW95SDFrcDBJNzQ4VFp5Rmdk?=
 =?utf-8?B?aTFGVFdFeEpSWWhVRWxLemlKeENSTnhjN0JLd1RMc3R5ck9UOVZXZHgzd2gy?=
 =?utf-8?B?NTduc0ExcXNKcVdHMFNDak9nczNuU1g5NXBTNktWVVVIQ2s5WVdPcTg5ajR6?=
 =?utf-8?B?L2syWlUwUksyTkUvTitDWFU5YUIwYXBWUDRtTWZMWC9Nd0ZpeFM0Ri9QQXZO?=
 =?utf-8?B?ejFvZmQ1UnFGKzJTMkViRmxvYytMS0w0bU91MzQ0NCs2Z0JNeVVsd254Qzg0?=
 =?utf-8?B?T2NmczBwb0VJRlJJUzdaQ1d4aXcrYmNJdSthTm9JWllvRjEwTkdISGsyanlr?=
 =?utf-8?B?bC9UdlFBN0xjVEdlb0t2c1ptZFJ1RzV2V2pVM1RJa2l3eVYyYjA2MFFUdTZw?=
 =?utf-8?B?V0d6MW45TmNhN0NpNzJkL0ZBVkRjNG9CMHVLeHkxL2JCNTA4M3dtVnFlRVRq?=
 =?utf-8?B?cUYrdWNmMXkwMHZMMjJsMWVsanRFOFMzaDB3ZVhYcXY5WDZNM2VLd1FvbktX?=
 =?utf-8?B?dFQyL0hUZ0dra3B2YzMxN2czYVNJOG0zenRQTUY3ZGgxZUg2QVNxSXJydExZ?=
 =?utf-8?B?OWVKR2RhdXBuQU5NQlBXZ1VSQWxtSlpUM3V6S0NBWlI5SlNoZUwvQ1M1Qzhs?=
 =?utf-8?B?Q1VyUFY1VCtQbUFKTExSMFFBb1RFc1VvRUpoMXF4YWEzemRUbHVFd2hZVEVE?=
 =?utf-8?B?Q2xEV21oQTM2dzVUejE5SEFFdit6V3VDQmVSRzJqRnlnaE12RkZFM2RuTnI4?=
 =?utf-8?B?Qlp4RE1YbEp4d1pvYXBQYW4wNmRuTzY3RVRCZ3VCVXhaamJmdkpvMk1IZm84?=
 =?utf-8?B?T1IraElLcVcxcGNSbmFtYVNOQUhYZEk5K3J2ZmY4OHg5V2VNNldyK1Q1MVZV?=
 =?utf-8?B?NUJqSVVwRDgxU1lFeUtYMFNHekoweXlOUXNTL0ZLRkp0ZVBlSVJYMUFiQklM?=
 =?utf-8?B?R2V0d0RWdktxN0RmQVh1WmZnZlFkMHB4WDBWbytLeTU3a0U0MUVEaE9RTVE0?=
 =?utf-8?B?V3lSUlpTMEQ2ZnZJZzQzYXljdFU3ZVg3VExNQklueC9zTTUyVzlvK2Q4cXJk?=
 =?utf-8?B?VzNlV1ZjUXUwM3liWkt0enc5LzBXU1hKdllEOUI0VDhtOTR2dWlqdEU1SU03?=
 =?utf-8?B?MUlacVZHUS9YZGRhdVF4SHNYYmd0YWgzWnNQdU51R0hpblI1eDhRdWthaGh6?=
 =?utf-8?B?YnN0NGpvak9kWmxWSlR1MzFTWVpiWHluWVVMWVAxWVlveGlQeGFPaThabUp5?=
 =?utf-8?B?Nkh4Zzg2cjJsangzcXVlbjRsQS9UTWMzMFZNb1hvVW1DT2I1YlJ1NEpQZzRw?=
 =?utf-8?B?U0svU1prWE1DZkNDSjY3Q0JuREk5cDFtZ214Ykk1bXhMbnJscUdSSmM3cmlW?=
 =?utf-8?B?bDJEY085UDk2WUhveFhTRHhXRzJyZVYrbGF0a1FhM1R0R2xJcU0xUTB3ZXQx?=
 =?utf-8?B?RUt3QjFLSU1rYlhWUVJUWTVxd05FOUlweGhlNm16dTExSDlMdU9rZlUxbHkx?=
 =?utf-8?B?V1ZKRmExck1aOHlVVm9kM0trSm8zNTZTTG5SbUFsQldJdzBZa1FUM1YwaGdO?=
 =?utf-8?B?d0RwUjYzbDJOQVcyWkJ1WEhRYkhxV29aN2tCbDY4WWNTTFFCOGJWU1Z3RDRG?=
 =?utf-8?B?d1d0Z3FUWUg0ZGx1MlZXdXZIeDZuZzhtblQ4cDRSYnM0MEV6RS9rSWl4bjhi?=
 =?utf-8?B?RGFIUnpXdFppdWpicWhnbnVQeXF2SERkd2JoQVFheFZJaGpEaWt6YllpTTZh?=
 =?utf-8?B?WjRSaUVITDVjVC9KRWF6NCtHMGIwSEtac2E5S1ZLZzhFNVF4NHBGRE9yMFBD?=
 =?utf-8?B?aFN6L3VrcFdGdTB4SHJnWkdDcDN1VzJyK0JFcWw1eTFxRlg2ZDRMSGtQZEsv?=
 =?utf-8?B?d3NDMVJqdVJ6V2hWd0xYaGEyUFZ6M2RsdHBvU29xaXZuZnEzTTNlNmlxS3FW?=
 =?utf-8?B?V2MrRzM5ZkdESHFWY01VejNMWU45RU0zYmlzdW5KWDBROWF6bmxVa290KzRD?=
 =?utf-8?B?Z0pORHFRVmJXNGdQU2lIMTJJRkJDbDZaTHFXS3Q2cUk1Q0wybXN1cEhYeFdW?=
 =?utf-8?B?U3ZacUFzTW02ZzRKTzhNRFRncHZZcStOQ2Niem05QzNnWmRSRmYyUEo1bmxz?=
 =?utf-8?B?amZUQ0tFdHpNNXBUZ1FXbCtLajYyOU5YT3Q5MXZVQXk3ZVJNQ0sxM3BHT0k3?=
 =?utf-8?B?RHM0bzVTZjJxTUk1Q2ZwdEhRSElaT1paOE9GRWhscU5NVWVSakJtOG00UGRo?=
 =?utf-8?B?VzVlWUwwd2lrTW5ROXBtNjJxSDU3R0U1OSt2VmVzQVk5SzZla1pydz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C53BE81991C8DB40917050CC5D1694B4@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b037afab-0e6a-4ed6-f03b-08d9bfc59197
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 12:22:32.1127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3fOrcfYjYumA1U2PxNlXYXt92LXP5WjGCqLWm8TvFrkTnBcdnLXharU/9Da74CTl4H9xBM4nZmcFMshoRzBhUOuBSCoaiD9XFffhQPTL2FbH8McWcUE9iRMTzY6cgNKS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6322
X-Proofpoint-ORIG-GUID: W6S605BpcYgiDZb2Gk-lrnn3lMjohTyI
X-Proofpoint-GUID: W6S605BpcYgiDZb2Gk-lrnn3lMjohTyI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_08,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015
 impostorscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0
 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150069

SGksIEphbiENCg0KT24gMTUuMTIuMjEgMTQ6MDcsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAx
NS4xMi4yMDIxIDEyOjU2LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IERlYXIg
cmVzdCBtYWludGFpbmVycyENCj4+DQo+PiBDb3VsZCB5b3UgcGxlYXNlIHJldmlldyB0aGlzIHNl
cmllcyB3aGljaCBzZWVtcyB0byBnZXQgc3R1Y2s/DQo+IEkgZG9uJ3Qgc2VlbSB0byBoYXZlIGFu
eSByZWNvcmQgb2YgeW91IGhhdmluZyBwaW5nZWQgUm9nZXIgYXMgdGhlIHZQQ0kNCj4gbWFpbnRh
aW5lci4NCk5vLCBJIGRpZG4ndC4gUm9nZXIgaXMgb24gQ0MsIHNvIGhlIG1pZ2h0IHNoZWQgc29t
ZSBsaWdodCBvbiB3aGVuIGl0IG1pZ2h0DQpoYXBwZW4sIHNvIHdlLCB0aG9zZSB3aG8gd29yayBv
biBQQ0kgcGFzc3Rocm91Z2ggb24gQXJtLA0KY2FuIGFsc28gcGxhbiB0aGUgcmVsZXZhbnQgdXBj
b21pbmcgKHJlKXdvcms6IHdlIHN0aWxsIG1pc3MgTVNJL01TSS1YIGFuZA0KSU9NTVUgc2VyaWVz
IHdoaWNoIGRvIGRlcGVuZCBvbiB0aGlzIG9uZQ0KPiAgIEFsc28sIGFzIHNhaWQgb24gdGhlIENv
bW11bml0eSBDYWxsIHdoZW4gZGlzY3Vzc2luZyB0aGlzLA0KPiBJIGRvbid0IHRoaW5rIEknZCB2
aWV3IHRoaXMgc2VyaWVzIGFzIGluIGEgc3RhdGUgd2hlcmUgYW4gZW1lcmdlbmN5DQo+IGZhbGxi
YWNrIHRvIFJFU1Qgd291bGQgYmUgYXBwcm9wcmlhdGUuDQpObyBlbWVyZ2VuY3kgaGVyZSwgYnV0
IHY1IHdpdGhvdXQgYW55IGFjay9uYWNrIG1pZ2h0IHJpbmcgYSBiZWxsDQpXaGljaCBtYWRlIG1l
IHdyaXRlIHRoaXMgZS1tYWlsDQo+ICAgQXMgaW5kaWNhdGVkLCBpbiBwYXJ0aWN1bGFyIEkNCj4g
d291bGRuJ3Qgd2FudCB0byBjb21taXQgYW55IG9mIGl0IHdpdGhvdXQgUm9nZXIncyBiYXNpYyBh
Z3JlZW1lbnQuDQpUaGlzIGlzIGNsZWFyIGFzIGl0IGlzIHVwIHRvIHRoZSByZWxldmFudCBtYWlu
dGFpbmVyIHRvIGNvbW1pdCB3aGljaA0KSSBtaWdodCBub3QgZXhwZWN0IGZyb20gdGhlIHJlc3Qg
bWFpbnRhaW5lcnMNCj4gICBJT1cNCj4gd2hpbGUgUkVTVCBtYWludGFpbmVyIHJldmlld3MgbWF5
IGhlbHAgbWFraW5nIHByb2dyZXNzIChidXQgYXMgbXVjaA0KPiB3b3VsZCByZXZpZXdzIGJ5IGFu
eW9uZSBlbHNlKSwNClRoaXMgaXMgbXkgZ29hbDogdG8gaGF2ZSBhY2svbmFjayBhdCBsZWFzdCBm
cm9tIHRoZSBSRVNUIG1haW5hdGFpbmVycw0KPiAgIHRoZXkgbWF5IG5vdCBwdXQgdGhlIHNlcmll
cyBpbiBhIHN0YXRlDQo+IHdoZXJlIGl0IGNvdWxkIGdvIGluLg0KRmFpciBlbm91Z2gNCj4NCj4g
SW4gYW55IGV2ZW50LCBhcyBhbHNvIHNhaWQgb24gdGhlIGNhbGwsIGFmYWljIHRoaXMgc2VyaWVz
IGlzIGluIG15IHRvLQ0KPiBiZS1yZXZpZXdlZCBmb2xkZXIsDQpBcHByZWNpYXRlIHRoaXMNCj4g
ICBhbG9uZ3NpZGUgYSBmZXcgZG96ZW4gbW9yZSBwYXRjaGVzLiBJJ2xsIGdldCB0byBpdA0KPiBp
ZiBub2JvZHkgZWxzZSB3b3VsZCwgYnV0IEkgY2FuJ3QgcHJlZGljdCB3aGVuIHRoYXQncyBnb2lu
ZyB0byBiZS4NClRoYW5rIHlvdQ0KPiBUaGVyZSdzIHNpbXBseSB0b28gbXVjaCBvdGhlciBzdHVm
ZiBpbiBuZWVkIG9mIHRha2luZyBjYXJlIG9mLg0KU3VyZSwgb3VyIGNvbXBhbmllcyBkbyB3YW50
IHVzIHRvIGRvIHNvbWV0aGluZyB1c2VmdWwgZm9yIHRoZW0gYXMgd2VsbCwgYnV0IHJldmlldw0K
DQpUaGFuayB5b3UsDQpPbGVrc2FuZHINCj4NCj4gSmFuDQo+DQo+PiBUaGFuayB5b3UgaW4gYWR2
YW5jZSwNCj4+IE9sZWtzYW5kcg0KPj4NCj4+IE9uIDI1LjExLjIxIDEzOjAyLCBPbGVrc2FuZHIg
QW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8
b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+PiBIaSwgYWxsIQ0KPj4+
DQo+Pj4gMS4gVGhpcyBwYXRjaCBzZXJpZXMgaXMgZm9jdXNpbmcgb24gdlBDSSBhbmQgYWRkcyBz
dXBwb3J0IGZvciBub24taWRlbnRpdHkNCj4+PiBQQ0kgQkFSIG1hcHBpbmdzIHdoaWNoIGlzIHJl
cXVpcmVkIHdoaWxlIHBhc3NpbmcgdGhyb3VnaCBhIFBDSSBkZXZpY2UgdG8NCj4+PiBhIGd1ZXN0
LiBUaGUgaGlnaGxpZ2h0cyBhcmU6DQo+Pj4NCj4+PiAtIEFkZCByZWxldmFudCB2cGNpIHJlZ2lz
dGVyIGhhbmRsZXJzIHdoZW4gYXNzaWduaW5nIFBDSSBkZXZpY2UgdG8gYSBkb21haW4NCj4+PiAg
ICAgYW5kIHJlbW92ZSB0aG9zZSB3aGVuIGRlLWFzc2lnbmluZy4gVGhpcyBhbGxvd3MgaGF2aW5n
IGRpZmZlcmVudA0KPj4+ICAgICBoYW5kbGVycyBmb3IgZGlmZmVyZW50IGRvbWFpbnMsIGUuZy4g
aHdkb20gYW5kIG90aGVyIGd1ZXN0cy4NCj4+Pg0KPj4+IC0gRW11bGF0ZSBndWVzdCBCQVIgcmVn
aXN0ZXIgdmFsdWVzIGJhc2VkIG9uIHBoeXNpY2FsIEJBUiB2YWx1ZXMuDQo+Pj4gICAgIFRoaXMg
YWxsb3dzIGNyZWF0aW5nIGEgZ3Vlc3QgdmlldyBvZiB0aGUgcmVnaXN0ZXJzIGFuZCBlbXVsYXRl
cw0KPj4+ICAgICBzaXplIGFuZCBwcm9wZXJ0aWVzIHByb2JlIGFzIGl0IGlzIGRvbmUgZHVyaW5n
IFBDSSBkZXZpY2UgZW51bWVyYXRpb24gYnkNCj4+PiAgICAgdGhlIGd1ZXN0Lg0KPj4+DQo+Pj4g
LSBJbnN0ZWFkIG9mIGhhbmRsaW5nIGEgc2luZ2xlIHJhbmdlIHNldCwgdGhhdCBjb250YWlucyBh
bGwgdGhlIG1lbW9yeQ0KPj4+ICAgICByZWdpb25zIG9mIGFsbCB0aGUgQkFScyBhbmQgUk9NLCBo
YXZlIHRoZW0gcGVyIEJBUi4NCj4+Pg0KPj4+IC0gVGFrZSBpbnRvIGFjY291bnQgZ3Vlc3QncyBC
QVIgdmlldyBhbmQgcHJvZ3JhbSBpdHMgcDJtIGFjY29yZGluZ2x5Og0KPj4+ICAgICBnZm4gaXMg
Z3Vlc3QncyB2aWV3IG9mIHRoZSBCQVIgYW5kIG1mbiBpcyB0aGUgcGh5c2ljYWwgQkFSIHZhbHVl
IGFzIHNldA0KPj4+ICAgICB1cCBieSB0aGUgaG9zdCBicmlkZ2UgaW4gdGhlIGhhcmR3YXJlIGRv
bWFpbi4NCj4+PiAgICAgVGhpcyB3YXkgaGFyZHdhcmUgZG9hbWluIHNlZXMgcGh5c2ljYWwgQkFS
IHZhbHVlcyBhbmQgZ3Vlc3Qgc2Vlcw0KPj4+ICAgICBlbXVsYXRlZCBvbmVzLg0KPj4+DQo+Pj4g
Mi4gVGhlIHNlcmllcyBhbHNvIGFkZHMgc3VwcG9ydCBmb3IgdmlydHVhbCBQQ0kgYnVzIHRvcG9s
b2d5IGZvciBndWVzdHM6DQo+Pj4gICAgLSBXZSBlbXVsYXRlIGEgc2luZ2xlIGhvc3QgYnJpZGdl
IGZvciB0aGUgZ3Vlc3QsIHNvIHNlZ21lbnQgaXMgYWx3YXlzIDAuDQo+Pj4gICAgLSBUaGUgaW1w
bGVtZW50YXRpb24gaXMgbGltaXRlZCB0byAzMiBkZXZpY2VzIHdoaWNoIGFyZSBhbGxvd2VkIG9u
DQo+Pj4gICAgICBhIHNpbmdsZSBQQ0kgYnVzLg0KPj4+ICAgIC0gVGhlIHZpcnR1YWwgYnVzIG51
bWJlciBpcyBzZXQgdG8gMCwgc28gdmlydHVhbCBkZXZpY2VzIGFyZSBzZWVuDQo+Pj4gICAgICBh
cyBlbWJlZGRlZCBlbmRwb2ludHMgYmVoaW5kIHRoZSByb290IGNvbXBsZXguDQo+Pj4NCj4+PiAz
LiBUaGUgc2VyaWVzIGhhcyBjb21wbGV0ZSByZS13b3JrIG9mIHRoZSBsb2NraW5nIHNjaGVtZSB1
c2VkL2Fic2VudCBiZWZvcmUgd2l0aA0KPj4+IHRoZSBoZWxwIG9mIHRoZSB3b3JrIHN0YXJ0ZWQg
YnkgUm9nZXIgWzFdOg0KPj4+IFtQQVRDSCB2NSAwMy8xM10gdnBjaTogbW92ZSBsb2NrIG91dHNp
ZGUgb2Ygc3RydWN0IHZwY2kNCj4+Pg0KPj4+IFRoaXMgd2F5IHRoZSBsb2NrIGNhbiBiZSB1c2Vk
IHRvIGNoZWNrIHdoZXRoZXIgdnBjaSBpcyBwcmVzZW50LCBhbmQNCj4+PiByZW1vdmFsIGNhbiBi
ZSBwZXJmb3JtZWQgd2hpbGUgaG9sZGluZyB0aGUgbG9jaywgaW4gb3JkZXIgdG8gbWFrZQ0KPj4+
IHN1cmUgdGhlcmUgYXJlIG5vIGFjY2Vzc2VzIHRvIHRoZSBjb250ZW50cyBvZiB0aGUgdnBjaSBz
dHJ1Y3QuDQo+Pj4gUHJldmlvdXNseSByZW1vdmFsIGNvdWxkIHJhY2Ugd2l0aCB2cGNpX3JlYWQg
Zm9yIGV4YW1wbGUsIHNpbmNlIHRoZQ0KPj4+IGxvY2sgd2FzIGRyb3BwZWQgcHJpb3IgdG8gZnJl
ZWluZyBwZGV2LT52cGNpLg0KPj4+IFRoaXMgYWxzbyBzb2x2ZXMgc3luY2hyb25pemF0aW9uIGlz
c3VlcyBiZXR3ZWVuIGFsbCB2UENJIGNvZGUgZW50aXRpZXMNCj4+PiB3aGljaCBjb3VsZCBydW4g
aW4gcGFyYWxsZWwuDQo+Pj4NCj4+PiA0LiBUaGVyZSBpcyBhbiBvdXRzdGFuZGluZyBUT0RPIGxl
ZnQgdW5pbXBsZW1lbnRlZCBieSB0aGlzIHNlcmllczoNCj4+PiBmb3IgdW5wcml2aWxlZ2VkIGd1
ZXN0cyB2cGNpX3tyZWFkfHdyaXRlfSBuZWVkIHRvIGJlIHJlLXdvcmtlZA0KPj4+IHRvIG5vdCBw
YXNzdGhyb3VnaCBhY2Nlc3NlcyB0byB0aGUgcmVnaXN0ZXJzIG5vdCBleHBsaWNpdGx5IGhhbmRs
ZWQNCj4+PiBieSB0aGUgY29ycmVzcG9uZGluZyB2UENJIGhhbmRsZXJzOiB3aXRob3V0IGZpeGlu
ZyB0aGF0IHBhc3N0aHJvdWdoDQo+Pj4gdG8gZ3Vlc3RzIGlzIGNvbXBsZXRlbHkgdW5zYWZlIGFz
IFhlbiBhbGxvd3MgdGhlbSBmdWxsIGFjY2VzcyB0bw0KPj4+IHRoZSByZWdpc3RlcnMuDQo+Pj4N
Cj4+PiBYZW4gbmVlZHMgdG8gYmUgc3VyZSB0aGF0IGV2ZXJ5IHJlZ2lzdGVyIGEgZ3Vlc3QgYWNj
ZXNzZXMgaXMgbm90DQo+Pj4gZ29pbmcgdG8gY2F1c2UgdGhlIHN5c3RlbSB0byBtYWxmdW5jdGlv
biwgc28gWGVuIG5lZWRzIHRvIGtlZXAgYQ0KPj4+IGxpc3Qgb2YgdGhlIHJlZ2lzdGVycyBpdCBp
cyBzYWZlIGZvciBhIGd1ZXN0IHRvIGFjY2Vzcy4NCj4+Pg0KPj4+IEZvciBleGFtcGxlLCB3ZSBz
aG91bGQgb25seSBleHBvc2UgdGhlIFBDSSBjYXBhYmlsaXRpZXMgdGhhdCB3ZSBrbm93DQo+Pj4g
YXJlIHNhZmUgZm9yIGEgZ3Vlc3QgdG8gdXNlLCBpLmUuOiBNU0kgYW5kIE1TSS1YIGluaXRpYWxs
eS4NCj4+PiBUaGUgcmVzdCBvZiB0aGUgY2FwYWJpbGl0aWVzIHNob3VsZCBiZSBibG9ja2VkIGZy
b20gZ3Vlc3QgYWNjZXNzLA0KPj4+IHVubGVzcyB3ZSBhdWRpdCB0aGVtIGFuZCBkZWNsYXJlIHNh
ZmUgZm9yIGEgZ3Vlc3QgdG8gYWNjZXNzLg0KPj4+DQo+Pj4gQXMgYSByZWZlcmVuY2Ugd2UgbWln
aHQgd2FudCB0byBsb29rIGF0IHRoZSBhcHByb2FjaCBjdXJyZW50bHkgdXNlZA0KPj4+IGJ5IFFF
TVUgaW4gb3JkZXIgdG8gZG8gUENJIHBhc3N0aHJvdWdoLiBBIHZlcnkgbGltaXRlZCBzZXQgb2Yg
UENJDQo+Pj4gY2FwYWJpbGl0aWVzIGtub3duIHRvIGJlIHNhZmUgZm9yIHVudHJ1c3RlZCBhY2Nl
c3MgYXJlIGV4cG9zZWQgdG8gdGhlDQo+Pj4gZ3Vlc3QgYW5kIHJlZ2lzdGVycyBuZWVkIHRvIGJl
IGV4cGxpY2l0bHkgaGFuZGxlZCBvciBlbHNlIGFjY2VzcyBpcw0KPj4+IHJlamVjdGVkLiBYZW4g
bmVlZHMgYSBmYWlybHkgc2ltaWxhciBtb2RlbCBpbiB2UENJIG9yIGVsc2Ugbm9uZSBvZg0KPj4+
IHRoaXMgd2lsbCBiZSBzYWZlIGZvciB1bnByaXZpbGVnZWQgYWNjZXNzLg0KPj4+DQo+Pj4gNS4g
VGhlIHNlcmllcyB3YXMgYWxzbyB0ZXN0ZWQgb246DQo+Pj4gICAgLSB4ODYgUFZIIERvbTAgYW5k
IGRvZXNuJ3QgYnJlYWsgaXQuDQo+Pj4gICAgLSB4ODYgSFZNIHdpdGggUENJIHBhc3N0aHJvdWdo
IHRvIERvbVUgYW5kIGRvZXNuJ3QgYnJlYWsgaXQuDQo+Pj4NCj4+PiBUaGFuayB5b3UsDQo+Pj4g
T2xla3NhbmRyDQo+Pj4NCj4+PiBbMV0gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBz
Oi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDE4MDcxNzA5NDgzMC41NDgwNi0yLXJvZ2Vy
LnBhdUBjaXRyaXguY29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhbnRETFEta2lvc0xMUERMR19EN0M3
U2RlYjFBZDFqLTQzWGp1Q0dUTWdlSk5ib0FOU3RzWUZQNmExaFI0M3M2N0dOdUZBeDdIdWckIFts
b3JlWy5da2VybmVsWy5db3JnXQ0KPj4+DQo+Pj4gT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gKDEz
KToNCj4+PiAgICAgcmFuZ2VzZXQ6IGFkZCBSQU5HRVNFVEZfbm9fcHJpbnQgZmxhZw0KPj4+ICAg
ICB2cGNpOiBmaXggZnVuY3Rpb24gYXR0cmlidXRlcyBmb3IgdnBjaV9wcm9jZXNzX3BlbmRpbmcN
Cj4+PiAgICAgdnBjaTogY2FuY2VsIHBlbmRpbmcgbWFwL3VubWFwIG9uIHZwY2kgcmVtb3ZhbA0K
Pj4+ICAgICB2cGNpOiBhZGQgaG9va3MgZm9yIFBDSSBkZXZpY2UgYXNzaWduL2RlLWFzc2lnbg0K
Pj4+ICAgICB2cGNpL2hlYWRlcjogaW1wbGVtZW50IGd1ZXN0IEJBUiByZWdpc3RlciBoYW5kbGVy
cw0KPj4+ICAgICB2cGNpL2hlYWRlcjogaGFuZGxlIHAybSByYW5nZSBzZXRzIHBlciBCQVINCj4+
PiAgICAgdnBjaS9oZWFkZXI6IHByb2dyYW0gcDJtIHdpdGggZ3Vlc3QgQkFSIHZpZXcNCj4+PiAg
ICAgdnBjaS9oZWFkZXI6IGVtdWxhdGUgUENJX0NPTU1BTkQgcmVnaXN0ZXIgZm9yIGd1ZXN0cw0K
Pj4+ICAgICB2cGNpL2hlYWRlcjogcmVzZXQgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgd2hlbiBhZGRp
bmcgZGV2aWNlcw0KPj4+ICAgICB2cGNpOiBhZGQgaW5pdGlhbCBzdXBwb3J0IGZvciB2aXJ0dWFs
IFBDSSBidXMgdG9wb2xvZ3kNCj4+PiAgICAgeGVuL2FybTogdHJhbnNsYXRlIHZpcnR1YWwgUENJ
IGJ1cyB0b3BvbG9neSBmb3IgZ3Vlc3RzDQo+Pj4gICAgIHhlbi9hcm06IGFjY291bnQgSU8gaGFu
ZGxlcnMgZm9yIGVtdWxhdGVkIFBDSSBNU0ktWA0KPj4+ICAgICB2cGNpOiBhZGQgVE9ETyBmb3Ig
dGhlIHJlZ2lzdGVycyBub3QgZXhwbGljaXRseSBoYW5kbGVkDQo+Pj4NCj4+PiBSb2dlciBQYXUg
TW9ubmUgKDEpOg0KPj4+ICAgICB2cGNpOiBtb3ZlIGxvY2sgb3V0c2lkZSBvZiBzdHJ1Y3QgdnBj
aQ0KPj4+DQo+Pj4gICAgdG9vbHMvdGVzdHMvdnBjaS9lbXVsLmggICAgICAgfCAgIDUgKy0NCj4+
PiAgICB0b29scy90ZXN0cy92cGNpL21haW4uYyAgICAgICB8ICAgNCArLQ0KPj4+ICAgIHhlbi9h
cmNoL2FybS92cGNpLmMgICAgICAgICAgIHwgIDMzICsrKy0NCj4+PiAgICB4ZW4vYXJjaC94ODYv
aHZtL3Ztc2kuYyAgICAgICB8ICAgOCArLQ0KPj4+ICAgIHhlbi9jb21tb24vcmFuZ2VzZXQuYyAg
ICAgICAgIHwgICA1ICstDQo+Pj4gICAgeGVuL2RyaXZlcnMvS2NvbmZpZyAgICAgICAgICAgfCAg
IDQgKw0KPj4+ICAgIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jIHwgIDExICsrDQo+Pj4g
ICAgeGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYyAgICAgfCAzNTIgKysrKysrKysrKysrKysrKysr
KysrKysrKysrLS0tLS0tLQ0KPj4+ICAgIHhlbi9kcml2ZXJzL3ZwY2kvbXNpLmMgICAgICAgIHwg
IDExICstDQo+Pj4gICAgeGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMgICAgICAgfCAgIDggKy0NCj4+
PiAgICB4ZW4vZHJpdmVycy92cGNpL3ZwY2kuYyAgICAgICB8IDI1MiArKysrKysrKysrKysrKysr
KysrKystLS0NCj4+PiAgICB4ZW4vaW5jbHVkZS94ZW4vcGNpLmggICAgICAgICB8ICAgNiArDQo+
Pj4gICAgeGVuL2luY2x1ZGUveGVuL3Jhbmdlc2V0LmggICAgfCAgIDcgKy0NCj4+PiAgICB4ZW4v
aW5jbHVkZS94ZW4vc2NoZWQuaCAgICAgICB8ICAgOCArDQo+Pj4gICAgeGVuL2luY2x1ZGUveGVu
L3ZwY2kuaCAgICAgICAgfCAgNDcgKysrKy0NCj4+PiAgICAxNSBmaWxlcyBjaGFuZ2VkLCA2NDQg
aW5zZXJ0aW9ucygrKSwgMTE3IGRlbGV0aW9ucygtKQ0KPj4+DQo=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 12:24:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 12:24:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247366.426530 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTKU-0005WH-Cp; Wed, 15 Dec 2021 12:24:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247366.426530; Wed, 15 Dec 2021 12:24:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTKU-0005WA-9Q; Wed, 15 Dec 2021 12:24:18 +0000
Received: by outflank-mailman (input) for mailman id 247366;
 Wed, 15 Dec 2021 12:24:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxTKT-0005Vx-Og; Wed, 15 Dec 2021 12:24:17 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxTKT-00036I-68; Wed, 15 Dec 2021 12:24:17 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxTKS-0004q8-Sd; Wed, 15 Dec 2021 12:24:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxTKS-0000N1-SA; Wed, 15 Dec 2021 12:24:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=goTNbddNmwfNCDc+bemREzlH13CVSvO7zrMvisvXcSs=; b=jam+vGXffHyuFOA3p0P6R/0FT5
	xqHrUigoOSUEFXkjfYNzah6/9c8Xyon1gXaFO2IxwmBm6MeZmyz8tH80y9G9+aWCTXXqy5/GRqMcg
	y+a+itpii8VYVOd3AskeyHrYwWdjn/pdFoRsn2mS+sC3io/OLobm2Mpl2qWx7aJYjZa0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167416-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.15-testing test] 167416: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.15-testing:test-amd64-amd64-xl-credit2:guest-localmigrate:fail:heisenbug
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=aba22c67efe4404a2a84e378bfd98def5ec8e647
X-Osstest-Versions-That:
    xen=c623a84c2a4fda1cd25f5347a6298706218eb5fb
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 12:24:16 +0000

flight 167416 xen-4.15-testing real [real]
flight 167433 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167416/
http://logs.test-lab.xenproject.org/osstest/logs/167433/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-credit2  18 guest-localmigrate  fail pass in 167433-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167217
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167217
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167217
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167217
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167217
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167217
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167217
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167217
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167217
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167217
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167217
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167217
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  aba22c67efe4404a2a84e378bfd98def5ec8e647
baseline version:
 xen                  c623a84c2a4fda1cd25f5347a6298706218eb5fb

Last test of basis   167217  2021-12-06 15:36:51 Z    8 days
Testing same since   167416  2021-12-14 21:09:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  fail    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c623a84c2a..aba22c67ef  aba22c67efe4404a2a84e378bfd98def5ec8e647 -> stable-4.15


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 13:03:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 13:03:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247374.426544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTvZ-0001jG-BD; Wed, 15 Dec 2021 13:02:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247374.426544; Wed, 15 Dec 2021 13:02:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxTvZ-0001j9-8F; Wed, 15 Dec 2021 13:02:37 +0000
Received: by outflank-mailman (input) for mailman id 247374;
 Wed, 15 Dec 2021 13:02:36 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxTvY-0001j3-HB
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 13:02:36 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45c5080c-5da7-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 14:02:35 +0100 (CET)
Received: by mail-lj1-x232.google.com with SMTP id z8so33189425ljz.9
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 05:02:35 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id v10sm434715ljp.125.2021.12.15.05.02.34
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 05:02:34 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45c5080c-5da7-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=izfCUCHmd2ACPFfma9Y4V09rmGSvApdm4ziD7yvYm78=;
        b=RjiGfIZXTNCATTVcthCBFogAJofMWOG7Guugc4Ont36BDt9At83CU0XY5i3cmxEQy6
         9xirWvLvC4jLXO+0WAq4uijLANJkDJP2dykWq57zLRtjKL04w5cBQpJr0sOf5vF81aSE
         gSQ2VkRrXH4Gcr53WKgognKtAyi/LlPNTqxuGIJ7wfRHNwWkpsXvo21e4iJg664wbGdf
         JzUCkOHIo/XkikcbJ1/mXNEmbdfzhgddKNiY00g5boNQhyM8ICGMpmCPCgWn7Yn0w7Bf
         aZPMaaLO2fv+WKsf2+L31lpkxIFLFWVah6dheARbMIsJLqNaiq3Q+GUAoBUq1bhuxFy3
         gyCA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=izfCUCHmd2ACPFfma9Y4V09rmGSvApdm4ziD7yvYm78=;
        b=Nw0cWC1VlMSjMs7niXHKhMYSz0RYNPaj+R7hcf8sie7hnGsazsvVO/n6+ebst14HIx
         SdJsSkpeNMfLzXqqAZKq+0LHHWgzqw9bD2sMmCLFJ5Z1wS+0K8IGXGrJBgIM7hbRcekV
         gObADcMPs3OmF2eo+m16WI9wVsfCBGsRXyB6/hm2/EjQRmm01+lI3hG9PnkOSbCI/Ejq
         bCJ7szchLaol8u+YwBtky6r2t94yqsy9SBapgrTZ8Nj/g5JFSUm+7kEcLe5YWn3OdeDm
         WlHG68Ap+VmNJ3pekqPc1ysC8pJhqzFJAGwpJ3fLOfhdXIYxEXuvdkVGmhORjAJpiJ6u
         ww6A==
X-Gm-Message-State: AOAM532zmpbxKMVFNdzbJ3OJFm83PqZevlrv32G5E4DFm47G7aqCmaSm
	AEM8UOJX5wYfGKS59ldGa2E=
X-Google-Smtp-Source: ABdhPJwOuXDh1jDGghYX5zg0XzpcVmxS5IDu0PDFYrddOnFRxPSTfMBr2xYe/diVo7ExZcziTLZRkw==
X-Received: by 2002:a2e:a268:: with SMTP id k8mr10105655ljm.451.1639573354919;
        Wed, 15 Dec 2021 05:02:34 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
From: Oleksandr <olekstysh@gmail.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>, Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
Message-ID: <5ad59468-0deb-2063-6146-28cdaf2b6488@gmail.com>
Date: Wed, 15 Dec 2021 15:02:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 14.12.21 19:44, Oleksandr wrote:

Hi Anthony

>
> On 14.12.21 18:03, Anthony PERARD wrote:
>
> Hi Anthony
>
>
>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> This patch adds basic support for configuring and assisting virtio-disk
>>> backend (emualator) which is intended to run out of Qemu and could be
>>> run in any domain.
>>> Although the Virtio block device is quite different from traditional
>>> Xen PV block device (vbd) from the toolstack point of view:
>>>   - as the frontend is virtio-blk which is not a Xenbus driver, nothing
>>>     written to Xenstore are fetched by the frontend (the vdev is not
>>>     passed to the frontend)
>>>   - the ring-ref/event-channel are not used for the backend<->frontend
>>>     communication, the proposed IPC for Virtio is IOREQ/DM
>>> it is still a "block device" and ought to be integrated in existing
>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>>> logic to deal with Virtio devices as well.
>> How backend are intended to be created? Is there something listening on
>> xenstore?
>>
>> You mention QEMU as been the backend, do you intend to have QEMU
>> listening on xenstore to create a virtio backend? Or maybe it is on the
>> command line? There is QMP as well, but it's probably a lot more
>> complicated as I think libxl needs refactoring for that.
>
>
> No, QEMU is not involved there. The backend is a standalone application,
> it is launched from the command line. The backend reads the Xenstore 
> to get
> the configuration and to detect when guest with the frontend is 
> created/destroyed.
>
>
>>
>>> Besides introducing new disk backend type (LIBXL_DISK_BACKEND_VIRTIO)
>>> introduce new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current
>>> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model.
>>>
>>> In order to inform the toolstack that Virtio disk needs to be used
>>> extend "disk" configuration by introducing new "virtio" flag.
>>> An example of domain configuration:
>>> disk = [ 'backend=DomD, phy:/dev/mmcblk1p3, xvda1, rw, virtio' ]
>> This new "virtio" flags feels strange. Would having something like
>> "backendtype=virtio" works?
>
>
> IIRC I considered "backendtype=virtio" option, but decided to go "an 
> extra virtio flag" route, however I don't remember what exactly 
> affected my decision.
> But, I see your point and agree, I will analyze whether we can use 
> "backendtype=virtio", I hope that we can, but need to make sure.


I have just rechecked/experimented, we can use "backendtype=virtio" 
instead of an extra "virtio" flags.

disk = [ 'backend=DomD, phy:/dev/mmcblk0p3, xvda1, backendtype=virtio' ]

Also backendtype section in xl-disk-configuration.5.pod.in really wants 
updating as
at least the first sentence is not true for virtio backend:

"This does not affect the guest's view of the device.  It controls
which software implementation of the Xen backend driver is used."

So shall I go this direction?



>
>
>>
>>> Please note, this patch is not enough for virtio-disk to work
>>> on Xen (Arm), as for every Virtio device (including disk) we need
>>> to allocate Virtio MMIO params (IRQ and memory region) and pass
>>> them to the backend, also update Guest device-tree. The subsequent
>>> patch will add these missing bits. For the current patch,
>>> the default "irq" and "base" are just written to the Xenstore.
>> This feels like the patches are in the wrong order. I don't think it is
>> a good idea to allow to create broken configuration until a follow-up
>> patch fixes things.
>
> Yes, I also think this is not an ideal splitting, so I decided to 
> write a few sentences to draw reviewer's attention to this.
> The problem is that second patch adds Arm bits which are local to 
> libs/light/libxl_arm.c and if I put it before the current one I will 
> break the bisectability
> as there will be no callers yet.
>
>
>>
>>> diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c
>>> index 70eed43..50a4d45 100644
>>> --- a/tools/xl/xl_block.c
>>> +++ b/tools/xl/xl_block.c
>>> @@ -50,6 +50,11 @@ int main_blockattach(int argc, char **argv)
>>>           return 0;
>>>       }
>>>   +    if (disk.virtio) {
>>> +        fprintf(stderr, "block-attach is not supported for Virtio 
>>> device\n");
>>> +        return 1;
>>> +    }
>> This might not be the right place. libxl might want to prevent hotplug
>> instead.
>
> Could you please point me the right place where to prevent hotplug?
>
>
> Thank you.
>
>
>>
>> Thanks,
>>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 13:08:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 13:08:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247381.426555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxU1H-0002RZ-4w; Wed, 15 Dec 2021 13:08:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247381.426555; Wed, 15 Dec 2021 13:08:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxU1H-0002RS-1u; Wed, 15 Dec 2021 13:08:31 +0000
Received: by outflank-mailman (input) for mailman id 247381;
 Wed, 15 Dec 2021 13:08:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxU1F-0002R2-FB; Wed, 15 Dec 2021 13:08:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxU1E-0003rz-Mq; Wed, 15 Dec 2021 13:08:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxU1E-0007Tf-Dt; Wed, 15 Dec 2021 13:08:28 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxU1E-0005gf-BG; Wed, 15 Dec 2021 13:08:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zVxvgbA3TaeyqYlXa8kq3oEGRwtqsJ0zejAijl3tCvc=; b=UkS/Cj3UFl/77HsBBb630U196m
	V3Tn+DoF8+Tonz9q5t5jjpOpSFE2YjxUOTeORtKFBcSEy7OkaiOu2/LqXqiZIzJBMPMycRhzrCoPd
	13G1RN9F/xqZBPkS2oOlQ4tWyAYcHo8/r7e6Wrp/+/qz4wAcW31UxbhUAxs5m1x5mrs8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167415-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-4.14-testing test] 167415: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=cbadf67bcab4e29c883410db393f4f5ef34df04a
X-Osstest-Versions-That:
    xen=c4cf5388652e8434652e30c73aa79635b4253675
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 13:08:28 +0000

flight 167415 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167415/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167216
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167216
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167216
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167216
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167216
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167216
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167216
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167216
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167216
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167216
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167216
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167216
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  cbadf67bcab4e29c883410db393f4f5ef34df04a
baseline version:
 xen                  c4cf5388652e8434652e30c73aa79635b4253675

Last test of basis   167216  2021-12-06 15:36:40 Z    8 days
Testing same since   167415  2021-12-14 21:09:04 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Stefano Stabellini <sstabellini@kernel.org>
  Stefano Stabellini <stefano.stabellini@xilinx.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c4cf538865..cbadf67bca  cbadf67bcab4e29c883410db393f4f5ef34df04a -> stable-4.14


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 13:41:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 13:41:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247391.426577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUX5-0006xL-OF; Wed, 15 Dec 2021 13:41:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247391.426577; Wed, 15 Dec 2021 13:41:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUX5-0006xE-Kj; Wed, 15 Dec 2021 13:41:23 +0000
Received: by outflank-mailman (input) for mailman id 247391;
 Wed, 15 Dec 2021 13:41:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxUX3-0006x8-IP
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 13:41:21 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id af633797-5dac-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 14:41:20 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id k37so43312991lfv.3
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 05:41:20 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id y7sm56169lfe.222.2021.12.15.05.41.18
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 05:41:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af633797-5dac-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=QGMsG2Qq+3i5fYEiIxeLez6/JesFrzIf/Iid84/MF0A=;
        b=LSLod0Kwbnc0bDK4hH1ykjsxnPpJrMWnLIF/5ULvrLonTI+/fGP0063gcUvSj8KuCk
         NBlD3/xehhothoM6fmQcz0ppIec8vfjJ6sBIP4ObX1+yQC+vVTNE12x4zDmdLgkDtjnm
         erNuLZtIwCOW8c8+BgAuM1UVSicB+jBaD1HYrmkJFN4KHdeUm8a0nwSgtmQyES80yfEj
         3OPBwb3xRhrR3huz+sr6GF0w6Vp5yTCqXP6fiGwVBW73d19t+hGG2z8NJ0IpqTYwG9vL
         T55yQapvosByA7gjUqJgKsngeWpeEjiokV75PmTCaZ8CZQnfaTOQcc3oVTE4l3wr4KJf
         ph0Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=QGMsG2Qq+3i5fYEiIxeLez6/JesFrzIf/Iid84/MF0A=;
        b=bb3oGp1bHc6UjdWmbY82MCq8buIBxaCeEdz2rxPZngbQUU3MM5+C5isvPn7Uojt8bC
         QcEUpRYXig3IdsEu4+CAHIAXJTEconJSjeNW2iC183xHbdcb76LgylQH86IhSgyV0ZLn
         f9CwHKskQ9u2s7bQRcTQjntEtbCY3tycRz9D1gQdPpb6+f5lr3Lh2b+o4AeVUBj0M2U0
         6yMw+AJqoUyw0I7SYoBPcvuyACpdiC+i6VT7gvz2YmPQhkd3+BREDg12jW7jE+MI9VCI
         gLM+QjHaAeDFiQupDY3zq61aRgsJHmtCmx0hGboCU3gNU7GrpbdLAdVY4H9nomY+yytk
         /gog==
X-Gm-Message-State: AOAM532NUJcJvrqag+WdakBjzekMf9FKLfMPU6k6X7Bo8Gnns+NEE2hm
	fiL4Fq7YwTm2Fud5GElRVfE=
X-Google-Smtp-Source: ABdhPJwnt10ndsBUfLTbEF8JQrH+oAHom/6cO98D74xNylOHw+c0RF5maosSXtQdgxrasxAYmus5Bw==
X-Received: by 2002:a05:6512:39c4:: with SMTP id k4mr9767269lfu.79.1639575679575;
        Wed, 15 Dec 2021 05:41:19 -0800 (PST)
Subject: Re: [PATCH 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-10-git-send-email-olekstysh@gmail.com>
 <87ee6ey3ox.fsf@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <c28cfcf3-4da5-4a3c-baeb-229759d506c2@gmail.com>
Date: Wed, 15 Dec 2021 15:41:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <87ee6ey3ox.fsf@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 15.12.21 04:58, Volodymyr Babchuk wrote:
> Hi Oleksandr,

Hi Volodymyr


>
>
> Oleksandr Tyshchenko <olekstysh@gmail.com> writes:
>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Reference-count the micro-TLBs as several bus masters can be
>> connected to the same micro-TLB (and drop TODO comment).
>> This wasn't an issue so far, since the platform devices
>> (this driver deals with) get assigned/deassigned together during
>> domain creation/destruction. But, in order to support PCI devices
>> (which are hot-pluggable) in the near future we will need to
>> take care of.
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   xen/drivers/passthrough/arm/ipmmu-vmsa.c | 17 +++++++++--------
>>   1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> index 22dd84e..32609f8 100644
>> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> @@ -134,6 +134,7 @@ struct ipmmu_vmsa_device {
>>       spinlock_t lock;    /* Protects ctx and domains[] */
>>       DECLARE_BITMAP(ctx, IPMMU_CTX_MAX);
>>       struct ipmmu_vmsa_domain *domains[IPMMU_CTX_MAX];
>> +    unsigned int utlb_refcount[IPMMU_UTLB_MAX];
>>       const struct ipmmu_features *features;
>>   };
>>   
>> @@ -477,13 +478,12 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_domain *domain,
>>           }
>>       }
>>   
>> -    /*
>> -     * TODO: Reference-count the micro-TLB as several bus masters can be
>> -     * connected to the same micro-TLB.
>> -     */
>> -    ipmmu_imuasid_write(mmu, utlb, 0);
>> -    ipmmu_imuctr_write(mmu, utlb, imuctr |
>> -                       IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
>> +    if ( mmu->utlb_refcount[utlb]++ == 0 )
>> +    {
>> +        ipmmu_imuasid_write(mmu, utlb, 0);
>> +        ipmmu_imuctr_write(mmu, utlb, imuctr |
>> +                           IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
>> +    }
>>   
>>       return 0;
>>   }
>> @@ -494,7 +494,8 @@ static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain,
>>   {
>>       struct ipmmu_vmsa_device *mmu = domain->mmu;
>>   
>> -    ipmmu_imuctr_write(mmu, utlb, 0);
> It would be great to have
>
> +      ASSERT(mmu->utlb_refcount[utlb] > 0);
>
> there. Just in case.

ok, will add.


Thank you.


>
>> +    if ( --mmu->utlb_refcount[utlb] == 0 )
>> +        ipmmu_imuctr_write(mmu, utlb, 0);
>>   }
>>   
>>   /* Domain/Context Management */
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 13:57:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 13:57:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247396.426588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUmR-0000D2-4M; Wed, 15 Dec 2021 13:57:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247396.426588; Wed, 15 Dec 2021 13:57:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUmR-0000Cu-0B; Wed, 15 Dec 2021 13:57:15 +0000
Received: by outflank-mailman (input) for mailman id 247396;
 Wed, 15 Dec 2021 13:57:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iD5n=RA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxUmQ-0000Co-4x
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 13:57:14 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e58f4a1a-5dae-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 14:57:11 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e58f4a1a-5dae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639576632;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=971pSX+Xi/lDpOhCA1Tke+Ysl99LDypZPs08PQRLQIk=;
  b=LK5mH5BsxuLB1zdzRN/Y13fg7DJ34Fjlui7kVBVjqc0fNQM1EZTOuFWP
   XpSZaTsF0zMa8FIh3hV280ERpMsrVxY5YYuw9ervtA3AOGcU5oLwv4j2P
   9BxwvndzynDmWYDi+E5kUES7KnyNCnFNk6WoyECK3fb5937wm+I7P6rMb
   w=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: i/pK7wI4uPqswoz5W2tg9D+OP2NUXlyr8pioedD9LDYFZWvDv6nsdI+2hRVArD9LwH/XAHnz8n
 j/icTDZuG+z//OgRBdhPNqGkFOXlPg/9yUZyDtM1y6NvMwR4NTRB82MCvwQbGvnnUyclV1d0i6
 7kMcW6uSuY3fS0MQL0vyH4nh1FBLNHr4shSezUGIfHW7emq8gJAId52RQUZdJNC5x7jfPY/VI+
 Qp/X4lh3GUOVSJsCrwu180i0OE0P8epdx4Nsb2wFcd7eIoSxYlM3AHj1QSd7uhHrKmNStDJSsU
 pJkVv6ct2nKZurvPryuTpNDY
X-SBRS: 5.1
X-MesageID: 60024663
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Yisarq/ByWLeVoO1PVKJDrUDbXmTJUtcMsCJ2f8bNWPcYEJGY0x3x
 zMcXjuDO/2NYmT8eIwlbdi/9k0EuZGAnNIxQVQ/qSs8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg39Yy6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhq8
 dBSqrCsEzsEI4eLnblHQzp7Kh1xaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguw5K8bmJsUHs2xIxjDFF/c2B5vERs0m4PcGhG9q2p4QRp4yY
 eIQZWNPURjeeydUGV41ApEhh9y2hnnGJmgwRFW9+vNsvjm7IBZK+KDkLd79atGMA8JPkS6wu
 Wbu72n/RBYAO7S3yzCI73atje/nhj7gVcQZE7jQ3u5nhhify3IeDDUSVECnur+ph0imQdVdJ
 kcIvC00osAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l0ZPR/Bm1GjI4YyNrL9l77t8VZgUW2
 Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6
 2nS9HBWulkFsSIcO0xXF3jjiinkmJXGRxVdCu7/DjP8tVMRiGJIiuWVBbnnARRocNbxorqp5
 iFsdy2iAAYmVMDleMulGrplIV1Rz6zZWAAweHY2d3Xbyxyj+mS4Yadb6yxkKUFiP64sIGGyM
 RKL510Buc8NZhNGiJObharrVazGKoC6SrzYug38NIISMvCdiifZlM2RWaJg9z+0yxV9+U3OE
 ZyabdytHR4n5VdPl1KLqxMm+eZznEgWnDqLLbiilkjP+efPPBa9FOZeWHPTP79R0U9xiFiMm
 zqpH5DRkEs3vSyXSnS/zLP/2nhWdyVmXs6v9JQMHgNBSyI/cFwc5zbq6epJU6RunrhPl/eO+
 Xe4W0RCz0H4i2GBIgKPAk2Popu1NXqmhX5kbyEqI3iy3H0vPdSm4KsFLsNldrg77u1zi/VzS
 qBdKcmHB/1OTBXB+igcMsah/NAzKkzziFLcJTehbRg+Y4VkG17D9Oj7c1a97yIJFCe265cz+
 uXyygPBTJMfbA1+F8KKOum3xla8sCFFyuJ/VkfFOPdJf0Do/NQ4IiD9lKZvccoNNQ/C1n2R0
 APPWUUUouzEookU9tjVhP/b89f1QrUmRkcDRjvV97e7MyXe71GP+44YXbbaZy3ZWUP15L6mO
 bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtL3Taj8lCsqpBmu1QtQesA
 x/d/9BbPfOCOd//EU5XLw0gN7zR2fYRkzjUzPI0PESlu3MnoOvZCR1fb0uWlShQDLppK4d0k
 +4utfkf5xG7lhd3YM2NiTpZ9jjUI3ENO0n9Wkr23GM/ZtIX92x/
IronPort-HdrOrdr: A9a23:G/7ot6lKZma5gH4mphjNF64lHuTpDfNXiWdD5ihNYBxZY6Wkfp
 +V7YgmPE7P+UsssS8b6Kq90fG7MDrhHZ4c2/hhAV7QZnivhILIFvA60WKG+Vfd8kLFh5tgPM
 tbAtFD4ZjLfC5HZMvBkW+F+rUbsYG6GcKT9JPjJh5WJGkGGsUQiHYDe3nrbHGeBjM2cqbRfK
 D22iMtnUvRRZ1jVLXIOpBzZZmxmzSkruOfXfaJbyRK1OGc5gnG1JfKVzyjmjsOWTJGxrkvtU
 LflRbi26mlu/anjjfBym769f1t6YHc4+oGIPbJptkeKz3qhArtTp9mQae+sDc8p/zqwEo2ke
 PLvwwrM61Imi7slyCO0EfQMjvboWgTAkzZuA6laLzY0JzErQcBepV8bERiA0jkAgQbzYNBOe
 lwrimkXtJsfFn9dCaX3bb1vkZR93Zc50BSytL61xZkMbf3b9Rq3O8iFEU/KuZjIMr/g7pXdd
 VGHYXS4u1bfkidaG2ctm5zwMa0VnB2BRueRFMe0/bllwS+sUoJjXfw/vZv20voNahNBaVs9q
 DBKOBlhbtORsgZYeZ0A/oAW9K+DijITQjXOGyfLFz7HOVfUki97aLf8fEw/qWnaZYIxJw9lN
 DIV05Zr3c7fwbrBdeV1JNG/xjRSCG2XCjryMtZ+59l04eMA4bDIGmGUhQjgsGgq/IQDonSXO
 uyIotfB7v5IW7nCe9yrk7DsllpWDkjueEuy5oGsmO104P2w9fRx6Hmmd7oVfXQLQo=
X-IronPort-AV: E=Sophos;i="5.88,207,1635220800"; 
   d="scan'208";a="60024663"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eKoX8p469MbGid/k9BHgQ0q1bm5OVYwNFdHk1ecVFdZPe99xwpXs7pKMpE4bB9t5UnCN0j/QI84XxooPlmQMp8DtqEIhXmxW4rw1C+BwPFLcB6Cm22G8VUcmAM0TSM/QsHAlAx1XDHMkDUjjfV5QGlQuq5BsTrDfyAAbGr3zrl5yKNqRSDdtEwqwZQm7mthaqaEbdqfTCLRt6UmRPTESEUk5F6CSPiRNH7yA8mfpwz9N+nKA/L50dWSZV02UwW7gOkfPtootNa2HH4O9HkBVW7tJRDdTQvlo5pDY944Mj0YfOt02F9zMHOUIlpGyuqpCGIpu2Zl3JRs9Ys/FQ/8/Rg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/ZHD19mx1v5bAytFP65czEDogI0hoGJz/gYVrGxQjyY=;
 b=cY3AbsRO8KRlKyXCcguw8nguOgNQj4DGRXX+oeEVue/2w8r+47tFqmuCfr8tLm7knTNa2ZLvi6JLwq/618aCGmIIQRLVumd/h2/cRQC5K1LyP5jhLYnIcTjrMvIDYpwP61p1FbH8xqCsD3vX03VawAVpYrQc7Zjt32kaCuEDFkGv2tLMxNmKFq7225uOxazkvI+whTqmg1If+7OxCkxVQZfSy8afElBG2OxM9d9SLgE9NYWF54DyY5jYR81gESVsyAZ+JVxcjSyeNW4W1m6KBTujm8pptqchoHIvygzbrQ7LDj2qs97XuViYq4s5rqB5XW+Od5HVTa8SHuVf4vgTrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/ZHD19mx1v5bAytFP65czEDogI0hoGJz/gYVrGxQjyY=;
 b=cnzwd99jJAUuuZVibIMaPWy8HsnJiPLWQC9bj8Sie+89imALRA6mvSrmrN06HyFd9/VboPcKDnLmpCT39Xpu/UUvxykIMm44JOEP4tpVPGe1DntgnMzceuzORtIq8RS+bUEeRLiTxlyhYt3PI/L53uY427ETGT0NZHZMfcf5zK4=
Date: Wed, 15 Dec 2021 14:57:01 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 16/18] x86: introduce helper for recording degree of
 contiguity in page tables
Message-ID: <Ybn0LaRuFpUfcmoU@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <aab0b88b-7643-cc08-756b-0684f93be257@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <aab0b88b-7643-cc08-756b-0684f93be257@suse.com>
X-ClientProxiedBy: MR2P264CA0076.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::16) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf500cf2-b25e-4065-d215-08d9bfd2c7fb
X-MS-TrafficTypeDiagnostic: SN6PR03MB4496:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB4496C6E8C8D1844D91FC8CC98F769@SN6PR03MB4496.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: QGyzykFIk6ii4/FgpMes75pCExa+4vsgwE9U9TDAkx9IaDdMPQlYZ8UleY8lEGqMx+rrYHoF9Rql7pm8agLeYgXxjB7gYLFQ4SaHkKgT9dj5b9CdoSq7fdouEJMpNTaJkQJyNyRGx6HFboEjLUi+N7pb5WsykejasFGjFTqkJLHB9atjqgDJ80P7sdUNTYVM/WtPUcMbM0Yq+xMcYiI5TE1pY48q2B1npULK9b3YNzWvv7Dfj63VMLBoiL70mq47PsVXLz9HXaSux1prpyPKpaBHgxo3jQ/Atj05wkTZhf+Rj7YyPndqPVZ4NVpv9qkSiUV+PnvFCZ1PjmcwalPhEXSgbLgwnfQGJN/rP9olO4Luf+9lRQQYsCbZE8Tm9u8YOR9S6/SIR/YBYp25qvk775MHF4LHMFgQVvEFYCfc0sDmBxrNIES0Ife4R6gJSGmny0lu+L6oNCuPQcuZzCGrjeU9RlbOD75DkhEAKLQTri5hJVbx8e1LlDNjUh3VoyErB+dONf9ZSbxNyI8GcbmCrheuKK+R/E83gpSoX6Gt3ZxaXJIVsJ/2XzIk+3XUKns1aTBMRKVWizPLRkizyWRvXml1EZTlMkDIy1qsioyQ8xa40aSF9CZY5f2+lYPl8XuuSxtgo0mP2qZ+34Skw3W97Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(86362001)(508600001)(8676002)(38100700002)(6486002)(6666004)(6506007)(82960400001)(66556008)(66476007)(186003)(26005)(6916009)(9686003)(66946007)(33716001)(6512007)(83380400001)(54906003)(2906002)(316002)(85182001)(5660300002)(8936002)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UERUWXhkZ2pSc1laZHB3WXJGRUpWdkJGcUpmUktBMDJHM3ZkUHdRRkx6bGwv?=
 =?utf-8?B?aGROa1hyY2xIVDlBU2ZXdUVsTkg5dWhmYkRjZk5MQVoxOXN5eXZDR3BGM0NF?=
 =?utf-8?B?QU5xcGE0SFk2YUlNWmZjMWQxMzRQNEJlN2l4WUdSRUJWWVptanBId1RNeThI?=
 =?utf-8?B?d2cvakdEYkJ5R0xsbEsrMldtMWd3d29tUXVWb0RmTWd3eXlnSUZRVkdPTks2?=
 =?utf-8?B?SmRRTFNoM2c2eEM5WmhuL25ZR09sUm42RFprVU1rbDAvME95US9wbm9PODFp?=
 =?utf-8?B?bkRtdStYRUpyN2pocjlGSkhjWXZ6dEZlVTQvejhVM0V3MWc3L0xyVDEyUVBW?=
 =?utf-8?B?V2padTZuOTdMbE93QTBoSFdBak9obkIzVERFT0xkTENRWkQvL3FkeC82SVM2?=
 =?utf-8?B?NWM0RzlocnRPQ1hoRzAxVmtaMHdjNjAycTJ2eWcraEtOQ0E3a3FQbllVaDNO?=
 =?utf-8?B?MWJuWHlQZFl2L3NFMDRYWjlNVnNIenphL3ByRHN4cnMyWGFyemhMTERmclBa?=
 =?utf-8?B?dUViSFpORHZzdytEM29Iai9EZUpQWEFkMzRHU1NRdW5LQWxsbkpVWmlMVTFH?=
 =?utf-8?B?WC9IUUNIRlJiSGpxRExTSmU0N2VqMjZYKzJpOXNLNUxrSGd2NXh4Ujg0UnpZ?=
 =?utf-8?B?SkQwUlhsOWhmRVI2dzlGNlFINGhiWG9xQ1d0VXVCNjlGeU9OUEZFb29pMWpv?=
 =?utf-8?B?V3FrZEpXUmp0VUgrY1ZKalhjRjgwcVNrRlBYMDZVR2pVclFRZjlxZWZmckdT?=
 =?utf-8?B?dkpNVmpWOTRkVEZvMnI3Y3BPcnFadVZrYlBCU29DR3dIcFE4Vmg1YkFFcisz?=
 =?utf-8?B?TmEzVjVTeVhKSTBLak5IQTZ4Vlgva2lhbWNwL0JndzZnbm16eGVxL1dGTG9G?=
 =?utf-8?B?T3FENW00U3poRFUxWktmcmwrV1Y0R3BZdFIyQmFESDF5VnYrTFB6QmQ3Uklk?=
 =?utf-8?B?aEJlblBSay9pODNVYUtQbjg5a3g5OERTQ3hTSnhFZ1NPempnNDVkUDBEWG5O?=
 =?utf-8?B?Y2JPOEFaSGZRUnBrd3R0OUNqbFN3eTl1eTIvZTh2T3U4cUdTNFgwRm1pNEpa?=
 =?utf-8?B?dmNYTldLVmpKaFJseXhwZWx0M3JGYjVaN1RIQUw4dHVKNFJMdVdTWENGY3Ja?=
 =?utf-8?B?WEJNeDNLaWh2SXJTYUZRR0kwTFJuQ1A1S0xYSjM1aVR3L3NrTHZLTzg3WGJF?=
 =?utf-8?B?aTlQOWFaRlpnWXROUTVKb05rTTVFeitSOE9wN29DaDFENkFnSytvcmExTU1r?=
 =?utf-8?B?b2Z0RVZuUTQyRGZFTlptdVk2QnBBSEI2VitTMWNVdlNTNjZWRGhoSnZ5Y2p2?=
 =?utf-8?B?cGV1S2RiSGFyOENuWExBMlExdEc3bjRiQ0lMREN3Q205Mlc5cXprZWI1VUtT?=
 =?utf-8?B?bkVVc2tKNVF0alRQMkpGdGVWVkpxKzhwYkxIL09tMmx2RURybjlvUGNabS94?=
 =?utf-8?B?TDBtMkVwY2t0ZmVnMkk4RzdUaTVaYXZHdEdUcUp0cEh5UkFtZE1pWlM3TUNy?=
 =?utf-8?B?cWRnc1dUMVZlVWg5MmIwRkFJNUUzZEpTMEZQSnJYbURmbEtTVVF0VU5WTVNv?=
 =?utf-8?B?L0YyTmdlNjd5WWZPSGxjZXl6YjFVL2Z4VGp5S2tkQ2prRTA5WFBwVml6WGx5?=
 =?utf-8?B?QWRJRktDN3NlSjZmQkRLZUtGSFM3L01LT1ZQcWFlV0xXdWtyQmpROEtjTzNi?=
 =?utf-8?B?Umo3UjRFU1I1RHhGakxlbTlTZ1gxSCtqQ2JDT3BlV2E5L3QwNndKNC91akxG?=
 =?utf-8?B?dCs3Um9LSEYyYy9jSmM5eEJTK0VkVC9GZVR6RFNSRWVwY1k4VlBVdTFPV3p2?=
 =?utf-8?B?Wm8rMm12eTUyd3djWDZFV2JCMTU2bXNYYi9tNWpSU2Q5dVhucG1GaS9QUHhk?=
 =?utf-8?B?ZjkyWVN2akJPdVIvaWN3VzV5Wk93VWM3UjBXRUdhdzV2QkJWYUJ6cmhGUmhN?=
 =?utf-8?B?ODE3UHZkZE1QZmlOTUp6eSt2MHRLQnZiZVJRZHN6bmpkNVVVdjlxa2lBT3ov?=
 =?utf-8?B?OFlJL3pxZ1VCYkNFR1lwbXVFaGpvRFNwZXV4OUFKMEZtdytHOGk0K0J1OUVV?=
 =?utf-8?B?Um5jVVBwWnNyNDJJM3RSTTBKL3R2VGE1ZVdxQmNvMFNSQi9FbkRwTUZiUlRN?=
 =?utf-8?B?Wld3TnM2bE4zNmRRTnZDZUptaU9NWTlKSERQaFVBUEhFVEcyNjFPUWNtZDg4?=
 =?utf-8?Q?z1xTsDlpgJhbFpGOyz4htrY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf500cf2-b25e-4065-d215-08d9bfd2c7fb
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 13:57:07.2436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jc86v99dqc1LB8vuBn9HP8a9L3ADn42Z8S6NfbdYAm3aJLBfOR5/Jr++XBIyLQtNAgQfNqr2pLEOwipLcMqMjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB4496
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:55:30AM +0200, Jan Beulich wrote:
> This is a re-usable helper (kind of a template) which gets introduced
> without users so that the individual subsequent patches introducing such
> users can get committed independently of one another.
> 
> See the comment at the top of the new file. To demonstrate the effect,
> if a page table had just 16 entries, this would be the set of markers
> for a page table with fully contiguous mappings:
> 
> index  0 1 2 3 4 5 6 7 8 9 A B C D E F
> marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0
> 
> "Contiguous" here means not only present entries with successively
> increasing MFNs, each one suitably aligned for its slot, but also a
> respective number of all non-present entries.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: New.
> 
> --- /dev/null
> +++ b/xen/include/asm-x86/contig-marker.h
> @@ -0,0 +1,105 @@
> +#ifndef __ASM_X86_CONTIG_MARKER_H
> +#define __ASM_X86_CONTIG_MARKER_H
> +
> +/*
> + * Short of having function templates in C, the function defined below is
> + * intended to be used by multiple parties interested in recording the
> + * degree of contiguity in mappings by a single page table.
> + *
> + * Scheme: Every entry records the order of contiguous successive entries,
> + * up to the maximum order covered by that entry (which is the number of
> + * clear low bits in its index, with entry 0 being the exception using
> + * the base-2 logarithm of the number of entries in a single page table).
> + * While a few entries need touching upon update, knowing whether the
> + * table is fully contiguous (and can hence be replaced by a higher level
> + * leaf entry) is then possible by simply looking at entry 0's marker.
> + *
> + * Prereqs:
> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4
> + *   contiguous bits (ignored by hardware), before including this file,
> + * - page tables to be passed here need to be initialized with correct
> + *   markers.

Given this requirement I think it would make sense to place the page
table marker initialization currently placed in iommu_alloc_pgtable as
a helper here also?

> + */
> +
> +#include <xen/bitops.h>
> +#include <xen/lib.h>
> +#include <xen/page-size.h>
> +
> +/* This is the same for all anticipated users, so doesn't need passing in. */
> +#define CONTIG_LEVEL_SHIFT 9
> +#define CONTIG_NR          (1 << CONTIG_LEVEL_SHIFT)
> +
> +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK)
> +#define SET_MARKER(e, m) \
> +    ((void)(e = ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK)))
> +
> +enum PTE_kind {
> +    PTE_kind_null,
> +    PTE_kind_leaf,
> +    PTE_kind_table,
> +};
> +
> +static bool update_contig_markers(uint64_t *pt, unsigned int idx,

Maybe pt_update_contig_markers, so it's not such a generic name.

> +                                  unsigned int level, enum PTE_kind kind)
> +{
> +    unsigned int b, i = idx;
> +    unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT;
> +
> +    ASSERT(idx < CONTIG_NR);
> +    ASSERT(!(pt[idx] & CONTIG_MASK));
> +
> +    /* Step 1: Reduce markers in lower numbered entries. */
> +    while ( i )
> +    {
> +        b = find_first_set_bit(i);
> +        i &= ~(1U << b);
> +        if ( GET_MARKER(pt[i]) > b )
> +            SET_MARKER(pt[i], b);
> +    }
> +
> +    /* An intermediate table is never contiguous with anything. */
> +    if ( kind == PTE_kind_table )
> +        return false;
> +
> +    /*
> +     * Present entries need in sync index and address to be a candidate
> +     * for being contiguous: What we're after is whether ultimately the
> +     * intermediate table can be replaced by a superpage.
> +     */
> +    if ( kind != PTE_kind_null &&
> +         idx != ((pt[idx] >> shift) & (CONTIG_NR - 1)) )

Don't you just need to check that the address is aligned to at least
idx, not that it's exactly aligned?

AFAICT this will return early if the address has an alignment that
exceeds the requirements imposed by idx.

> +        return false;
> +
> +    /* Step 2: Check higher numbered entries for contiguity. */
> +    for ( b = 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b )
> +    {
> +        i = idx | (1U << b);
> +        if ( (kind == PTE_kind_leaf
> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) != (1ULL << (b + shift))

Maybe this could be a macro, CHECK_CONTIG or some such? It's also used
below.

I would also think this would be clearer as:

(pt[idx] & ~CONTIG_MASK) + (1ULL << (shift + b)) == (pt[i] & ~CONTIG_MASK)

> +              : pt[i] & ~CONTIG_MASK) ||

Isn't PTE_kind_null always supposed to be empty? (ie: wouldn't this
check always succeed?)

> +             GET_MARKER(pt[i]) != b )
> +            break;
> +    }
> +
> +    /* Step 3: Update markers in this and lower numbered entries. */
> +    for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b )
> +    {
> +        i = idx ^ (1U << b);
> +        if ( (kind == PTE_kind_leaf
> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) != (1ULL << (b + shift))
> +              : pt[i] & ~CONTIG_MASK) ||
> +             GET_MARKER(pt[i]) != b )
> +            break;
> +        idx &= ~(1U << b);

There's an iteration where idx will be 0, and then there's no further
point in doing the & anymore?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 14:01:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 14:01:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247403.426599 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUqi-0001mh-PH; Wed, 15 Dec 2021 14:01:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247403.426599; Wed, 15 Dec 2021 14:01:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUqi-0001ma-MB; Wed, 15 Dec 2021 14:01:40 +0000
Received: by outflank-mailman (input) for mailman id 247403;
 Wed, 15 Dec 2021 14:01:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxUqh-0001mQ-Hn; Wed, 15 Dec 2021 14:01:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxUqh-0004oP-2x; Wed, 15 Dec 2021 14:01:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxUqg-0002Id-PY; Wed, 15 Dec 2021 14:01:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxUqg-000073-P5; Wed, 15 Dec 2021 14:01:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Vhq74C+GhUbqLZgePLLawz2XwSqe2BcMUuFjmsdwt0Q=; b=QFxYY2mIprgZ/RT0v2jjN1CluO
	0Oi0jqFuoPW/9WpEDKsMJNxNv5KlpELjGw+W4vP8G8lO2rD5sUOZKoXCOAsDGxhofQtegl4iVWBF2
	0HmyRruHMjNyt602tXVGwGPx1MGviJ0oD5THiVoW05YMZicgLGc2TjCmkNKEVqPY0rLU=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167429-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167429: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=9956fdc70f99b0f133be7f16f62417928a84622c
X-Osstest-Versions-That:
    xen=249e0f1d8f203188ccdcced5a05c2149739e1566
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 14:01:38 +0000

flight 167429 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167429/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  9956fdc70f99b0f133be7f16f62417928a84622c
baseline version:
 xen                  249e0f1d8f203188ccdcced5a05c2149739e1566

Last test of basis   167412  2021-12-14 13:01:35 Z    1 days
Testing same since   167429  2021-12-15 10:02:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Julien Grall <jgrall@amazon.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   249e0f1d8f..9956fdc70f  9956fdc70f99b0f133be7f16f62417928a84622c -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 14:02:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 14:02:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247407.426613 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUrO-0002Iy-4J; Wed, 15 Dec 2021 14:02:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247407.426613; Wed, 15 Dec 2021 14:02:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxUrN-0002Ir-Vz; Wed, 15 Dec 2021 14:02:21 +0000
Received: by outflank-mailman (input) for mailman id 247407;
 Wed, 15 Dec 2021 14:02:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rtoO=RA=kernel.org=arnd@srs-se1.protection.inumbo.net>)
 id 1mxUrM-0002GE-FA
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 14:02:20 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9d0433e1-5daf-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 15:02:18 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AB11CB81F21;
 Wed, 15 Dec 2021 14:02:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D94EC34604;
 Wed, 15 Dec 2021 14:02:12 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d0433e1-5daf-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639576935;
	bh=cXYTLYTbqfDJRy2dCkqPSsmWK+rChKlIWB5CxhnAkoE=;
	h=From:To:Cc:Subject:Date:From;
	b=fuGPzjjPZux4pwsI/ALYQx5LaT/QTolTA/G5sONu5Ge6PHgTmT842mg1U6HQlhFGH
	 PTQwis0a8Mfdi69qfIeKVK0hnaXAJ/nEEcqzCbyN1IXzwMlKJp9adKLt5i9iQLrTKO
	 Sgd6HxvPLIjyUf/ko+aNJqH8Ejxy2Qcdb1EQKitxEjXoDE3g2yjpLn+lNC3XQIdts1
	 5d8IiYdvi95acthucvRyOZ/mJlj3cJ+6zvW7EYRpvPgxOD638pXPPZi9GtB/OEo/qi
	 I1kARHx46CV3t+i+mk7RccENhXFhSwZy2i3v48m9EYiy3DMia7A7Yhme+CtWjc9jlB
	 h0GUrJd6/8DDg==
From: Arnd Bergmann <arnd@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	xen-devel@lists.xenproject.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] x86: xen: Fix xen_initdom_restore_msi #ifdef
Date: Wed, 15 Dec 2021 15:01:59 +0100
Message-Id: <20211215140209.451379-1-arnd@kernel.org>
X-Mailer: git-send-email 2.29.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Arnd Bergmann <arnd@arndb.de>

The #ifdef check around the definition doesn't match the one around the
declaration, leading to a link failure when CONFIG_XEN_DOM0 is enabled
but CONFIG_XEN_PV_DOM0 is not:

x86_64-linux-ld: arch/x86/kernel/apic/msi.o: in function `arch_restore_msi_irqs':
msi.c:(.text+0x29a): undefined reference to `xen_initdom_restore_msi'

Change the declaration to use the same check that was already
present around the function definition.

Fixes: ae72f3156729 ("PCI/MSI: Make arch_restore_msi_irqs() less horrible.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This should go on top the irq/msi branch of the tip tree, which
introduced the build regression
---
 arch/x86/include/asm/xen/hypervisor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/xen/hypervisor.h b/arch/x86/include/asm/xen/hypervisor.h
index 677f84d0039f..1bf2ad34188a 100644
--- a/arch/x86/include/asm/xen/hypervisor.h
+++ b/arch/x86/include/asm/xen/hypervisor.h
@@ -59,7 +59,7 @@ static inline bool __init xen_x2apic_para_available(void)
 
 struct pci_dev;
 
-#ifdef CONFIG_XEN_DOM0
+#ifdef CONFIG_XEN_PV_DOM0
 bool xen_initdom_restore_msi(struct pci_dev *dev);
 #else
 static inline bool xen_initdom_restore_msi(struct pci_dev *dev) { return true; }
-- 
2.29.2



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 14:51:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 14:51:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247417.426628 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVcs-00086m-SB; Wed, 15 Dec 2021 14:51:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247417.426628; Wed, 15 Dec 2021 14:51:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVcs-00086f-My; Wed, 15 Dec 2021 14:51:26 +0000
Received: by outflank-mailman (input) for mailman id 247417;
 Wed, 15 Dec 2021 14:51:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iD5n=RA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxVcq-00086Z-Tj
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 14:51:25 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 76585d96-5db6-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 15:51:21 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 76585d96-5db6-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639579881;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=5SyX/wlj8b+5lplAD2ca4LRgi1p42NtNL4OxTuHNdkA=;
  b=ZWe/QHtT3H2aMDzsPb3RaAEw998Q/KZyFM5l1Op+BlCrqmdcvymO3/l4
   IsdHtnMcgG9AFm75pk+IhWiDsKNz4DaYPyhkS+ufQvwUuDMleVd6E/3LV
   qjobdL8wCtsrglBfHLHxpMji+eK0d9Jdh6wzsBWSetr2Xnypo33Ibom4a
   I=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: R+VEUmi5itQMvGNR7Nt09vyQPqXS/5sCv4B7E/fLYGHVo5U1JPQqw54r2QX1pQEEHeWsXb1DQt
 FW/ltY1V4US/6TEopZDhL5TALbcGJCox0/cl+zqVLpPJavEBGXpU2vodH/x1qt+ozp7uKfZtrm
 Kvx+9C1lVZ1CTXeK2rINijWwu/fl6qK/i1FYIGKeXcE+8mzEf8W3nKfj2xhUHF9gYL3bOho9kt
 wz+WhX2iDHKOAK56voFpgwh8AWdbLh704HJe06VwxbV01rRDECbLgY7DQ/J3+AU2PHO2z7LL/l
 CVjJ6Gu2hnyG9i+osF+Wmi9Z
X-SBRS: 5.1
X-MesageID: 60481605
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OJXdbaBwoSQbfxVW/xjlw5YqxClBgxIJ4kV8jS/XYbTApDwi32RVz
 WZJDD+EbK7bM2Kne9wibYi08hsDvp/TydY2QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX570E87wYbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/tjaXksF+8
 /Rxt9/uTD0WJvCVxsZaTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf2WtYYGhGpYasZmM6zMX
 vpBRQJTaz/qRQJSAEUIEqskpbL97pX4W2IB8w/EzUYt2EDDwQo03LXzPd79ft2RWd4Tjkuev
 njB/WnyHlcdLtP34SCM8m+owPTOmyz7cIsIEfuz8fsCqFee3HAJARsaE16yu+Cki1WWUshab
 UcT/0IGsqwa5EGtCN7nUHWQu2WYtxQRX95RFewS6wyXzKfQpQGDCQAsTCNFadEgnN87Q3otz
 FDht/TtCD90ubuZU0Wh56yUpjO/PysSBWIabCpCRgwAi/HhqowuihPETv54DbW4yNbyHFnY5
 DSHrzM3gbkJuucN27+m5lDMgz+qpZ/hQxY840PcWWfNxhtweYqNd4Gur1/B4p5oBZyFQ1y2m
 WkLksmT8sgDFZiI0ieKRY0lIrat4PqUNSzGtnRmFZIh6jeF9maqeMZb5zQWGatyGp9aI3mzO
 haV4F4Pos8IVJe3UUNpS7+yFck7wpPBKdamCPXuUcITO8ZTMxDSqUmCenWs92zqlUEtl4Q2N
 pGabdugAB4mNEh38Nalb7xDiOF2n0jS0UuWHMmmlEr/jdJycVbMEe9dWGZieNzV+09tTO/91
 99Ef/WHxBxEOAEVSnmGqNVDRbzmwJVSOHwXlyC1XrLTSuaFMDt4YxM0/V/HU9U090iyvr2Xl
 kxRomcClDLCaYTvcG1mkExLZrL1RopYpnkmJyEqNlvA8yF9OtfytPlBJ8ZnI+NPGAlfIRhcF
 adtlyKoWKsnd9g6025FMcmVQHJKKnxHej5izwL6OWNiLvaMtiTC+8P+fxuHycX9JnHfiCfKm
 JX5jlmzacNaH2xKVZ+KANryngvZlSVMw4paAhqXSuS/jW2xqeCG3QSq1aRpSyzNQD2erganO
 /G+XU1F+LKT+tBtq7EkR8ms9u+ULge3JWIDd0Hz5reqLyjKuG2lxI5LSuGTej7BEmjz/c2fi
 S99lpkQ6dULwwRHtZRSCbFuwf5s7tfjveYCnA9lAG/KfxKgDbY5eiuK2sxGt6tswL5FuFTpB
 hLTq4cCYbjZatn4FFMxJRY+arjR3/8jhTSPv+8+J1/35XEr8ePfA1lSJRSFlAdUMKBxbNE+2
 e4ktcNPs16/hxMmP8yolCdR82jQfHUMX79+7sMRAZPxixptwVZHOMSOBijz6ZCJStNNLkh1f
 WPE2Puc3+xRnxOQfWAyGH7B2ftmqa4P4B0ankUfI1mpm8begqNl1hNm7jlqHB9eyQ9K0rwvN
 zEzZVF1P6iH4xxhmNNHAzK3AwhECRCUph7xxl8OmDGLRkWkTDWQfmg0OOLL90EF6WNMODNc+
 ejAmmriVD/reuD33zczBhE5+6CyE4Qp+12Qgt2jEuSEA4I+MGjsjaKZbGYVrwfqXJEqj0rdq
 Og2pOt9ZMUX78LLT3HX32VC6YktdQ==
IronPort-HdrOrdr: A9a23:bT+Xwaz3zvXcJPDEo5zUKrPxyOskLtp133Aq2lEZdPULSKKlfp
 GV88jziyWZtN9wYhEdcdDpAtjnfZr5z+8J3WBxB8bZYOCCggqVxe5ZnO7fKlHbaknDH6tmpN
 tdmstFeazN5DpB/L7HCWCDer5KqrT3k9HLuQ6d9QYXcegDUdAf0+4TMHfjLqQZfnggOXJvf6
 Dsmfav6gDQMkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/jIsKwC
 zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6t2H2RIPqp
 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCmlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117
 8O936FtrJMZCmw0hjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXX9
 WGNPuspMq+TGnqLEww5gJUsZ6RtzUIb1u7q3E5y42oO2M8pgE986MarPZv6UvouqhND6Ws3N
 60QZiAoos+OvP+XZgNdNvpfvHHeFAlYSi8eV56cm6XXJ3uBRr22uvKCfMOlaaXRKA=
X-IronPort-AV: E=Sophos;i="5.88,207,1635220800"; 
   d="scan'208";a="60481605"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Po5giEmZwxuyFMI9w1j8ou1Hv0cyuglG7V3/VV4XG1Y8Y0uSfMsbB1wi4Qi843mb1Qq+ysahBeS1ibXFtXL+f8tJImwMloysqrQfO1XEvJSDRarv+Zsnx2NXbhjteZsOeao8wnXWu47ERNF4zveuL00DAOlhzUSF9D1K3ZmNVr6sQ+mltZaU8R2NWYjKY6Zau5Pqybb0CKDmRVHZWsbuy0+jt2H9yZaUdUiQRhXw1YAOBusKOSST5g6y21X6bNpvEmriYU4NXp+xlmH6Kpx/NKKArZQ3dXdIb/VQ0m79Hqv2yyE+cVoqOwi9DHDt36U9KL9zWw94/Aa+psQZoA5Eqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o02XVI8qcv9II66wpAcTgX+8H9fTt9VW2JktbX3kT4Y=;
 b=hICRglBenf/Ohjm4AVDG7j9qqYg7673B/Ek6lAoJWVy+8tI07B3KMuEinxjbdtyZv+iZ5+v1oVK0ze+VqukCqkSvv7g/UgGloPvnnyoOVMssjG1IjHmjn5Esnaopl/PqvHW7TVGqMTKUOOpm2mNPQN7tSaE7ZdG/JpXInzA84cCIhrd0I0ZDTLCGoTtu0y3+b/YqlwlWmt5vdwa3FFds78OpSTDAHQ4UZjSzZh6E4JifzaqXwsmCDNTD+Bf06ufTqUg7EhRlTOOi3Ncl/DaefgOM66+CBpHDdU5EoySe/RC1tnMMymjzJofOK/hSVM9PzctP+LDC7auOGnHMoijHhQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o02XVI8qcv9II66wpAcTgX+8H9fTt9VW2JktbX3kT4Y=;
 b=Wi8XNAo9FQSOtROtmQ5D8wTqBmdOi2jxJ0DcMRdDJp8QqNijYqF8jYcjjHZ6KBnEXPgQxgas4QwzZpRUc4+PuEIOHroakHpqu9NEJ5X8O//dKo89CMpqNgw9JTW4JtLXNJA2Z4Pm7OV+AhrZ7wGwmt++GpcQCko85RNy9DPtpT8=
Date: Wed, 15 Dec 2021 15:51:10 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: Jan Beulich <jbeulich@suse.com>, Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Artem Mygaiev <Artem_Mygaiev@epam.com>,
	"paul@xen.org" <paul@xen.org>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Rahul Singh <rahul.singh@arm.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	"julien@xen.org" <julien@xen.org>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Message-ID: <YboA3j4GDLMxKP0A@Air-de-Roger>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
 <79466492-fd58-1be0-c47e-13fc1e17479d@suse.com>
 <1103f95b-3345-f28f-1eed-7f26328d67fa@epam.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1103f95b-3345-f28f-1eed-7f26328d67fa@epam.com>
X-ClientProxiedBy: MR1P264CA0016.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::21) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 152432e3-2bb0-4e23-46fb-08d9bfda57a3
X-MS-TrafficTypeDiagnostic: SN6PR03MB3646:EE_
X-Microsoft-Antispam-PRVS: <SN6PR03MB36466274D6FC29595B893D3C8F769@SN6PR03MB3646.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rmCIR3T1VflYF27LPXauPxmQkMz06I39uq4HE1KnCPwZ4SozXAaqizh8ZDqQGPnPDM0e+arCqnz7WaO9+s9cM5xwnfKYw5UC3VRi7mwwcukn4VPkeRnslycS2myzV0SeDlrHp8K/udwKVT1vM/slzTrouCMxpn4sbuzoDtIBPC1kd4TGSCPzEXxC0vO4gIbagFIKbW/phBwGq9I4FHk2M8H5A8gMiw9OY/mN4Te9lWWXHvHxzw7GXWyj9GXl4/0drP9w17eKSJBZKOyngIjmXf1Ueu6AbCtbKAz7adt76/0V6DgJmFQ7GX5TELtUlh1agnmVlYI0968zUAzWOMUBU6MQGuRTsqKAvFg0S5OIZNaow1zRqcExtyu8zkq9mr7siC9LTdZjEGXR0D6qqimMmtG8W93/7ZOeeKFdAVhh+AVj9/Ny6M/BX2l+o90ABWPyPPlfyj4SWGs3iRKwEKVtlvtDmmTuY66Ey32H1NnS4IzzEl097ex8WY4tA0M6Xd2+4halcbXK73GPka7RWFGHk2cKJCZT4EntPvhVMCepzg3floJMYHAzhr0H9TB5+N8eOYRdBR9j33sSQ/t6XYMn2V9KpJptckzjHG8ZE/mrsubofVObJ2AQ1C2DMDVhf/Q36JU8Q8I6J5OmEYiLpFHiUA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6506007)(6486002)(53546011)(66946007)(9686003)(5660300002)(8676002)(83380400001)(2906002)(8936002)(6512007)(4326008)(26005)(508600001)(82960400001)(66556008)(85182001)(33716001)(6916009)(86362001)(66476007)(38100700002)(6666004)(54906003)(186003)(316002)(7416002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWZ1Q2syZVFPaWQ5SGFzMW9DNHQrZWpvdTc1ZUl1aTZYVUZrY1ZZRkwxMlZB?=
 =?utf-8?B?dEk4Q2JuTlZnUHN4UCtBV3BBR1JuS2QraUtEOURMTHUrRWVhRldJUFpZRWJ3?=
 =?utf-8?B?Wk4rdFVPSGJXSEVtTGtzLzNibFhTVWdkazBicmNvc2YzUkI0SDNuRE9XZUJF?=
 =?utf-8?B?ZXVVWnJXeXpkVmRXTkR6THVvek1wQWJldjF5dW80NHZZWGs1NlExdUVueFNo?=
 =?utf-8?B?dGhHdytucU9iOFFzdmV0N2hPQUFKclBkajJ5S2VpQWZBeWVqNGt5QjZCeng0?=
 =?utf-8?B?NDU1aEFsQlpYYWsyTzQvQ3ZBVFdEVW5iNUh1Yks3NldBZlpmQ0F1Rm5DYzNM?=
 =?utf-8?B?U0dIWlpFS1JrTkt4cHlXeHM2dDh3Ri9udjJoVmNGd09wSUlkR0RHSnJWSSs4?=
 =?utf-8?B?eVluZ1M2bllIMnBYZm9kbzFlVkszNXVNTVVSVjRYUTFoVVlyb0NaeW01RnFa?=
 =?utf-8?B?cFhnRmJGQzlnNDNqQzBPRTVYYVNuTGVPOStCR0tDZ1M4aGxlMEdrZmw2cGlW?=
 =?utf-8?B?dS9kZTBNdXBLcm9iVEtpL1BuT0JFdllvZVJyRkkyemUrL1lRVm5jTlBmYnlL?=
 =?utf-8?B?MmMrMVdpM1hxZXhKTk95RkxsM1V0cFVrOFRZSTVSU3VnWXQyVTRobkRTRElJ?=
 =?utf-8?B?WVV6eHJkczgxTGdMa3Vpelh4SnpKUWdXYlJxWk1kK2ZXbkdqRm9qdWIxUVds?=
 =?utf-8?B?SUhrWUxBL1RtZzZrVXVrQ1lwSDEyVzc5V1lMZkVDbzVjV3ZEYlRHU25lR3px?=
 =?utf-8?B?UElLVmVzZzNyakQ5MmJBbW9QeFBnSHN0ZWZuUWNsYXdWTEtVT3ROdFI3V3Ir?=
 =?utf-8?B?Q0tPTHlkYWI5SWw2bGowbTFwM3RyS1NoTEVPZWdWZkJzcG1qT05wUCtUMk1s?=
 =?utf-8?B?ZmhkVThKbzFTaG9LcnFYRFNxdU1pR0doUnQyM25TVXhNUmtPNFhCUHpma2Z2?=
 =?utf-8?B?NGJ3MDJRWTV6Wk9NaXBzS0JmVEY4Y1Y1T3BzOFgzM1Z2eDAvanhMdHZSa1Rr?=
 =?utf-8?B?cGJCc25tVUFRTVRLL1Bxam9oRjI5clNjM3lUd3haeXJuVExKVVg1ZnJrd2t3?=
 =?utf-8?B?TjcxcTBaaG9LdUgvczlXMFBwcHBtUXpvRTd0b1VwMDlpTHBFWndZUDhVbWZH?=
 =?utf-8?B?UytaYmxCR0ZQZENJN0MxTUU1UHMrQW9aQXRUWHlESjZRNFB6bEJFemdVVGJo?=
 =?utf-8?B?YUpmS3MyU01wbHhrNHR1Yjh5VUFYaUdId2crOFpGRGFlY1pZdDQ1Um5VL0gy?=
 =?utf-8?B?Y3ZkdjdEL2JKYmM0cTFBc3FScHUxSndzTHlkSC83UGp5dVNoWXpXSm5sSGVo?=
 =?utf-8?B?c01DWlhTYSswYjI2L04vWnFyUU9yemlnZnFSYzBoeHNuSy81bTEzVngvQ3Zt?=
 =?utf-8?B?MFByL05sV21UNm5RelJqbUxoZkl1ZDYzaGVVT3dPWjY2M1QwSCs5Q1IwSjlp?=
 =?utf-8?B?d29LODlTaFpzMnNWUVZvK2JteCswYWFtWmlPcjE2VlIxREtUYng1VklaZ2pQ?=
 =?utf-8?B?VC9UR3FxZTk0bXhLMHQ1UC9EczRDWXRPNUxvN1JqaGNYclkzZHh1M3BXS3h6?=
 =?utf-8?B?WVdJNzBqRVQyTityZ3g0YmNjaitHSFlBbHdTTXlJaGlOSUFIWnc2MzFUWVJt?=
 =?utf-8?B?RVVaa2krV0c2K3ZmNkNJaFZ0TkszQXYwVks5WG1JaGgwY3N4SStkNDkraTVp?=
 =?utf-8?B?NDRPRWtOVjJVZGFBaVMyRlgrWHFSM0xadHZFSGVITER3MzhtMCtyQ0JaMXZY?=
 =?utf-8?B?Z05kNndHUzdoTXdjY1FTa25FM2I5QWU0Z09XNDRtbWhWWmE2aVJ2L1YzT25U?=
 =?utf-8?B?Zk1QWEJKaHlYUk5LdmR1NHBLSHdmNDVsQ09SWDNaVUkvQzBMWGVWc1FHUW9u?=
 =?utf-8?B?dXFrVnVOMXZMRXZ2WVhkSU5ZWGdUOFlhRzVhNGJtdmsvYzNFdldlUG41am4x?=
 =?utf-8?B?bWw4L2JIT3JpQzlzdkpzVG1VbDRGbzFNQ1pxbWVTYm9sd0tFV25BazVCNnRr?=
 =?utf-8?B?NU4xa1BveXgwSm1peVBERjVqa2plNzBZVm8zeVludHJsUk5jSUNWYnlBcTlp?=
 =?utf-8?B?Vmx6UW54RFI0RkpneDNZa1pMRVBaN1l6Wk9QN2cwN1lwZytzNEZhQUs4Zm9v?=
 =?utf-8?B?QW0wNzFTUXdreS9ySWVIS1VmeHk4WWpaNklxUFRPekxxcXFGRC9STzRNdmVS?=
 =?utf-8?Q?y4Cm5pYNo8JMPcvN7Q7InZM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 152432e3-2bb0-4e23-46fb-08d9bfda57a3
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 14:51:14.6089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y95rsqWfrVx/Yts25TqQYnBnvDF4MC6czPeSWJ5I6/8wML2nrgIG54rZ+kzJFOnfsJO1xXs7pVUd4TEURU3Vwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR03MB3646
X-OriginatorOrg: citrix.com

On Wed, Dec 15, 2021 at 12:22:32PM +0000, Oleksandr Andrushchenko wrote:
> Hi, Jan!
> 
> On 15.12.21 14:07, Jan Beulich wrote:
> > On 15.12.2021 12:56, Oleksandr Andrushchenko wrote:
> >> Dear rest maintainers!
> >>
> >> Could you please review this series which seems to get stuck?
> > I don't seem to have any record of you having pinged Roger as the vPCI
> > maintainer.
> No, I didn't. Roger is on CC, so he might shed some light on when it might
> happen, so we, those who work on PCI passthrough on Arm,
> can also plan the relevant upcoming (re)work: we still miss MSI/MSI-X and
> IOMMU series which do depend on this one

Hello,

I'm quite overloaded with patch review and other stuff, since I've
taken over the Community Manager role while George is away.

There are series on the mailing list that have been pending for way
longer, and while I understand that this is of no help or relief for
you it wouldn't be fair for me to review this piece for work before
other series that have been pending for longer, as other submitters
also deserve review.

Sorry, but I think it's unlikely I will get to it until after new
year.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:03:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:03:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247423.426639 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVny-0001MB-So; Wed, 15 Dec 2021 15:02:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247423.426639; Wed, 15 Dec 2021 15:02:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVny-0001M4-PZ; Wed, 15 Dec 2021 15:02:54 +0000
Received: by outflank-mailman (input) for mailman id 247423;
 Wed, 15 Dec 2021 15:02:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxVnx-0001Ly-Tz
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 15:02:54 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1245338c-5db8-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 16:02:52 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFEx3eA010556;
 Wed, 15 Dec 2021 15:02:46 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3cyhbj0bvk-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 15:02:45 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB4018.eurprd03.prod.outlook.com (2603:10a6:208:73::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 15:02:42 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 15:02:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1245338c-5db8-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=huC+wacYECfl2ihOhXzzFP+2wSytbAZm6LeJQ6+zWKWwPQIdElY8MDnFgQDnl815KFApp/I+FI73wgTvh3hxCfmTYlFbkK8v6XLk7fPhsOlMIyaYhRLit4OmsTg3NNrKOChS8V/uvJYyp8RRYYZEpBJA0c3A55YQg7IPeietPSUk6MNOE7Kx6eCgQg68Mjblhm0FiYV/+ejugRBB3M8HGA6LDS32hjZboNXaN1tUJ3QyIv3bWZeB2lH9biEfXBMU333zIbD+0l2j074NBks1xwj4adxieoU7SrVSWc6l/FYvPrDuEueY9JP7ogYaYBdVO+F0+kWWgMqm4Iin/7QMlQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QkAx75UpxvNRIddmGK02LVHtukL3hLbTd/rLb61GpFE=;
 b=GVS2pbtsTKLMgxxGfR4cerfFikA1JpRoaex2SqCZGnGU4BIgu651fun2eWmRlrZexdjKByn2V9XYZDw1WEQkhoLMZVaLFWAL9RZ+rjBgOqhMYRAbnTyru+1mqwy2BZchC5Y68pJhdGjvhyu8Z/6xT6SqLVP0stocoW+AUqUeAFS/IKL8MWn8mMwuk48PNcvz/EuyX0+imc6rfuBUGbtNA3Og0u5wmGd1Y6WX4mMq7MrvlvelSjvt6xX/FVl82epJkXWPQlyanRbpygUiKblcM4tKf5XlfNiA4oz+Zd5bQ+75D62KTv2ek7fqzADb+HwkD6UKfyzjfRecy1WzIXW2tg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QkAx75UpxvNRIddmGK02LVHtukL3hLbTd/rLb61GpFE=;
 b=QfccvUDiuS88kAuRoL+ePaeSCEYxiwg06waiYbpdKHXHQGLkoweQVy95kEhMHnsLPIw+xpulDZKxvtw3UgV+50oi2WEIqmO5ghCSCw8C0QRk2trUr4ASZbZh66SlUBe4qr1TzuvFkH7d4LoEUiuG2usrLg9k5bSzM6X6l+Eo3Ngiw4evj1J8S8ExDyyc/BEBG3pDx6d5R4ksP8ynDK5HA5JniTXpxsHQchDzAfTLmNdps/1BoC/kGc2VmlTGBdfRlZ55HI0YXZmn4/A9N4umNFjMSSJq2kAhdrCoM57KXTUCjvJhBBAL+k3fro0NAYLq/XmKuyGBEsqF8WgdQAc7ZA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>, "paul@xen.org" <paul@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh <rahul.singh@arm.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        "andrew.cooper3@citrix.com"
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        "julien@xen.org" <julien@xen.org>,
        "sstabellini@kernel.org"
	<sstabellini@kernel.org>,
        Wei Liu <wl@xen.org>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Topic: [PATCH v5 00/14] PCI devices passthrough on Arm, part 3
Thread-Index: AQHX4ewD/fiBagJockWfLYQGw/ZN1KwzkeKAgAAC9ICAAAQugIAAKYkAgAADOQA=
Date: Wed, 15 Dec 2021 15:02:42 +0000
Message-ID: <66b7b1ba-2dae-8861-4dad-01bb9d1cda1c@epam.com>
References: <20211125110251.2877218-1-andr2000@gmail.com>
 <3a9f16d5-f076-92e2-f1b9-33a3c1a3371b@epam.com>
 <79466492-fd58-1be0-c47e-13fc1e17479d@suse.com>
 <1103f95b-3345-f28f-1eed-7f26328d67fa@epam.com>
 <YboA3j4GDLMxKP0A@Air-de-Roger>
In-Reply-To: <YboA3j4GDLMxKP0A@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2b0e0948-1a85-420d-5e0f-08d9bfdbf1ff
x-ms-traffictypediagnostic: AM0PR03MB4018:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB4018A1B26329C97352C44639E7769@AM0PR03MB4018.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 k7yvescKho90d18z4yWtX9+4xhi2ssGZ7Omfix21O/qxN0341wvofqHnkz35oR4hyBnzl5KOey+we1Pb9TGdOP0YUUZbrWq5CGq6FrSfkw25qfGJqjgKx2FP7HLkybLYhFw3ARZr8qihJrwVwb2PVoEFJmDEeJD3CAUx/UK19ZHwjTatNo2cwu8r891TReJGVE2i4d837ZfpNNKJJYsekRFKBWZZuueSWUr1INL95ywUIAs+y+57anCFWw/Q466ls7SJp8Ft7x+yPXm1rcewqqmZp4o0mD0NkZrpuB7sjVswhGH4Ggm2JLDm4D+gwqEEzYwHaGOONsaxlttLmb4qomVWjvE1phSdvBBcrhjUVHjtmTiF2KLaOByqI7tf7Q1yR2rSLCULWPgpvnU+0RKaeIFZXS1wWPntCEe07yci+AkI8JiIWtj2wgFi755tTxTX8Oap46vlLNouhT40DIyx6lQ2eTS7sgxvHyocTN3VMe6L2XkoDDHh1q5IKbEtkGg70hPzfeTGOOW3uo3HcHvweQFcyZrhaB6Vt4EiH3jv8b6OSZhF+nXEBuUlUlGs7Nws5dxk0vzcWiBWcOYgU6AkAbCr44ddB7GkKpAvllWNMvPGyhWRwKJKIoIhEuinwsihHxddabvpO+wS8feTItxVBAQQLOWDfkXAmEPYsg6Z6m+4AscugaJ7CQ6b5zOU8MXjSxZsERze1qFYW7vEosFUTS4C2Bb7aJmnJllNRW+cTkIRDP3SL6+hncvU0CU6FnOZ
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(31686004)(83380400001)(7416002)(122000001)(38100700002)(36756003)(8676002)(508600001)(8936002)(2616005)(38070700005)(5660300002)(6512007)(66556008)(66476007)(66946007)(2906002)(6506007)(55236004)(6916009)(66446008)(76116006)(316002)(54906003)(64756008)(91956017)(4326008)(26005)(186003)(107886003)(6486002)(86362001)(31696002)(71200400001)(53546011)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UmlNaE9od2tCc1Q4eXlSNCs0TlhHLzdKclY4bnF3a1YrRWZXM29jS0MrMytE?=
 =?utf-8?B?RlVkOWd5VkFDc2hsUnh0enhiTVN1dUpMcG5KaW41eTYvWGZ5MXFYZXFpOUdQ?=
 =?utf-8?B?dUNLcDRCTnFJNXZSQm1ySi93R2hHYjJEVDZUVG5uS2ppaFZjKzNEOVpGVmEx?=
 =?utf-8?B?UkRuZGMwR3FUUWcveG5YNWRIR1lFTUNsWm1rSDQ4UEtNSTd1Q2NSb3JweFFP?=
 =?utf-8?B?bVZxQWdwR2lQTFlaZnZsSmhQazhqQTB3MEFMdUZ4SFZjbU9VMmFCRTdLRU5C?=
 =?utf-8?B?blZEaFV5S2s1dlBVZXNYaEJ3bHZjUFdWMzZsY1ZMcWpFWmNzeXUrdXBkNzk2?=
 =?utf-8?B?Y3E2OFBQci9DT0N6aWlzUVd6U29CZEVmUTJndExjU0dxMWY0VmFQeDBidURp?=
 =?utf-8?B?N09sUm92N2UzbU5RLzZOMGtyUFBzTlM3ckoxMEhQcmZ6bGhBYzNzZWkrY0Ra?=
 =?utf-8?B?bGJTZm5vL3A3QUk0T2JBRVV3QTFEMy9sTU9HWEhLTWlKbFJrd3piRjJaTHR1?=
 =?utf-8?B?RXkwSjg5aGVBV0FVRCttQTkwVU9oSUgrQXJDOEcyWG9GUkVXSlY3M2Y5ZTcx?=
 =?utf-8?B?UkZJUi96QzhjUERkRXhhM2JlWEJTSUlUQ05CSkFTQVpuM1E4dHNCTnM0Qms1?=
 =?utf-8?B?WG9RcjNZLzhYVkp0Rk1xR2o2TUozRXYxU1pzTENCZVgrbmswWkhsRFZOR0hi?=
 =?utf-8?B?NUE3TjNrZ0RTSjNFQ3hpWHlnalVwRGo0d3NNcFlxYWl5SFZDR0Zvd3BTRklM?=
 =?utf-8?B?dEMvWmF4cmpEVWlvY3NDeHl3U0NJc054QWFkSU51bHRyS3kyc1BiWDhrcUVp?=
 =?utf-8?B?TU9YMWNmM0RQRG1kOUlyK1FBTmZzclRucTZpSFVhWm83KzNCUVhpMFowemhL?=
 =?utf-8?B?cUU2cGF6eUpiVUxiNU1HQW9rYlhrcFhncW53bWhuR2luMTd2L3I3K1U2enNY?=
 =?utf-8?B?TkZieENaSW5FQ2JYU0dJVStwVnlaWW1YU3ZyVDVlN25LZ2tkSlVIenB6VjM0?=
 =?utf-8?B?MGViR284SnBHYWZPOHNmRm5CSzNzb2diMlJFeitzS0swUGY5N0JwWno3ektX?=
 =?utf-8?B?SzJTbm1jUElLL2M1V0VnOFhieDdTTGVFdTVDcUlzR0hkektLMDV1MDZFanQ1?=
 =?utf-8?B?SndhM3hyRGFNeDBnbk1MOXJHU3NsRzVPVUlrcTJEYWJ2MzFhcGlvWHk3YVBZ?=
 =?utf-8?B?eFVwR1M2OC9JaFUvM3pMcVdGRVZoMlFGY2dhRVVMTjFzSTJiTC9wWlRPRWpv?=
 =?utf-8?B?UHZZMTVNczVLbE8wL1Ywa09CcU5VYUk3NmFRb2xwcnlBYVV0d2xpaDdJa2tI?=
 =?utf-8?B?R3pKTDFQRFlQMEhtZzZ0V2dQbkt2MlFXVDA3MmlHUnZBbjBlQVFaREN4d3Ro?=
 =?utf-8?B?RG56UzQ2Nis0MmtNeFFCMnVTWThVVCs1eDQ5b0E0N3p6RGwrRFVoY3U1c1lN?=
 =?utf-8?B?bkh4bUxHc0xhYmhramIzNklVZ2hNM0M1SEdwZ2dPUU14dTlrdERKK3FTbno3?=
 =?utf-8?B?VzFrQWloYkZIandjU3ZuSXdzQUtEeXFYdzlEY0F1RFEzY3NFOGFIcGpndlBX?=
 =?utf-8?B?UWw2QlVnaG5CN25MbGdzWDVBOWNFTGdUaW5KSkE2QkltcWF6a2t5R0JyelFD?=
 =?utf-8?B?cjRPemZyVjZnNmJqOHZmZm1xbXFnd0Fjbk5lUE92L1JVOFB0OUR5RUU2UUR0?=
 =?utf-8?B?OXZ0SFltZFd4MDJ3TEZTM3poMGN4UkNrNWRVQzJpMlF5NU1ScVdFTC9JVWNh?=
 =?utf-8?B?enRneWsrMmZhditIdXhNVzB3KzF4eE82c1ZaRXpYYkp4L1pkdGdEblkvTXEy?=
 =?utf-8?B?WXc0MW9aZ2E2UUVJUnUzaEpGVWsrSFQ3Z0hBbC94QzJiZDNBdEh0aU0rdExm?=
 =?utf-8?B?MzkveU1LRjF3TDlRNnlVRE56dlU0RHFzNnNKNEdBNlhUdDcrNTcyOExuNWE4?=
 =?utf-8?B?cmt3ZFNwQ1I1c0FRWVhLY2U4VDZ5ZnhFalIvM0dqbWpJaWhXVWs3emJGQnJX?=
 =?utf-8?B?eGhSdDhwSmFxektaZjhaMVRHNU1OZWVxbFpINHBBTjNqb0pjcXNIY00rcTNN?=
 =?utf-8?B?S1B3SzRENUlrK0FpMWkxR05VVVhaM3M4UXphbnJZZ0hHaE9jSEwwVEV2b1VG?=
 =?utf-8?B?MkEvNWF2ekpBU0l0T3JuRmxXNEloaWY0dEQyVWoveGxza2pPOWp5UURyaTRE?=
 =?utf-8?B?cjlwN0xMUWp5ZXNzWUtTaUVkTWtlZUNKbFltakJvMU5RbERhNGJSMWpnWG8x?=
 =?utf-8?B?dHRYMW5vVDYxMlBaeEViaW5mVVZHTSt5bUtQWURHaDlVdStPR2J6VmFJYzRJ?=
 =?utf-8?B?UFlCNHZiNTAyRWIwUzNGRTJoM2MyTGM1SUNaRnIyYlorL3VTRlpaZz09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <11D2607201EE5D41B8238D9AF3D26DB5@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b0e0948-1a85-420d-5e0f-08d9bfdbf1ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 15:02:42.7799
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YI4xO3aOwAh08zeOO87dpduibtvtxnbM2oUXkap5fteEif52zQD+budobixJiJ6y3b9/yF6dtlWYe/Y61Zdx8uQvxNMaoC/wGaRt8rUzPzqfpcvTSedM9kuuRG2YphX9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4018
X-Proofpoint-GUID: JZy_NNUKkRk8OMxcVISZxChzOyrDKgh_
X-Proofpoint-ORIG-GUID: JZy_NNUKkRk8OMxcVISZxChzOyrDKgh_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_09,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 spamscore=0 phishscore=0 clxscore=1015 mlxlogscore=606 impostorscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150085

SGksIFJvZ2VyIQ0KDQpPbiAxNS4xMi4yMSAxNjo1MSwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToN
Cj4gT24gV2VkLCBEZWMgMTUsIDIwMjEgYXQgMTI6MjI6MzJQTSArMDAwMCwgT2xla3NhbmRyIEFu
ZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBIaSwgSmFuIQ0KPj4NCj4+IE9uIDE1LjEyLjIxIDE0OjA3
LCBKYW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNS4xMi4yMDIxIDEyOjU2LCBPbGVrc2FuZHIg
QW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+Pj4gRGVhciByZXN0IG1haW50YWluZXJzIQ0KPj4+Pg0K
Pj4+PiBDb3VsZCB5b3UgcGxlYXNlIHJldmlldyB0aGlzIHNlcmllcyB3aGljaCBzZWVtcyB0byBn
ZXQgc3R1Y2s/DQo+Pj4gSSBkb24ndCBzZWVtIHRvIGhhdmUgYW55IHJlY29yZCBvZiB5b3UgaGF2
aW5nIHBpbmdlZCBSb2dlciBhcyB0aGUgdlBDSQ0KPj4+IG1haW50YWluZXIuDQo+PiBObywgSSBk
aWRuJ3QuIFJvZ2VyIGlzIG9uIENDLCBzbyBoZSBtaWdodCBzaGVkIHNvbWUgbGlnaHQgb24gd2hl
biBpdCBtaWdodA0KPj4gaGFwcGVuLCBzbyB3ZSwgdGhvc2Ugd2hvIHdvcmsgb24gUENJIHBhc3N0
aHJvdWdoIG9uIEFybSwNCj4+IGNhbiBhbHNvIHBsYW4gdGhlIHJlbGV2YW50IHVwY29taW5nIChy
ZSl3b3JrOiB3ZSBzdGlsbCBtaXNzIE1TSS9NU0ktWCBhbmQNCj4+IElPTU1VIHNlcmllcyB3aGlj
aCBkbyBkZXBlbmQgb24gdGhpcyBvbmUNCj4gSGVsbG8sDQo+DQo+IEknbSBxdWl0ZSBvdmVybG9h
ZGVkIHdpdGggcGF0Y2ggcmV2aWV3IGFuZCBvdGhlciBzdHVmZiwgc2luY2UgSSd2ZQ0KPiB0YWtl
biBvdmVyIHRoZSBDb21tdW5pdHkgTWFuYWdlciByb2xlIHdoaWxlIEdlb3JnZSBpcyBhd2F5Lg0K
Pg0KPiBUaGVyZSBhcmUgc2VyaWVzIG9uIHRoZSBtYWlsaW5nIGxpc3QgdGhhdCBoYXZlIGJlZW4g
cGVuZGluZyBmb3Igd2F5DQo+IGxvbmdlciwgYW5kIHdoaWxlIEkgdW5kZXJzdGFuZCB0aGF0IHRo
aXMgaXMgb2Ygbm8gaGVscCBvciByZWxpZWYgZm9yDQo+IHlvdSBpdCB3b3VsZG4ndCBiZSBmYWly
IGZvciBtZSB0byByZXZpZXcgdGhpcyBwaWVjZSBmb3Igd29yayBiZWZvcmUNCj4gb3RoZXIgc2Vy
aWVzIHRoYXQgaGF2ZSBiZWVuIHBlbmRpbmcgZm9yIGxvbmdlciwgYXMgb3RoZXIgc3VibWl0dGVy
cw0KPiBhbHNvIGRlc2VydmUgcmV2aWV3Lg0KVGhpcyBpcyBmYWlyDQo+DQo+IFNvcnJ5LCBidXQg
SSB0aGluayBpdCdzIHVubGlrZWx5IEkgd2lsbCBnZXQgdG8gaXQgdW50aWwgYWZ0ZXIgbmV3DQo+
IHllYXIuDQpUaGFuayB5b3UgaW4gYWR2YW5jZSwNCk9sZWtzYW5kcg0KPg0KPiBUaGFua3MsIFJv
Z2VyLg0K


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:03:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:03:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247424.426649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVo5-0001dl-72; Wed, 15 Dec 2021 15:03:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247424.426649; Wed, 15 Dec 2021 15:03:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVo5-0001de-4A; Wed, 15 Dec 2021 15:03:01 +0000
Received: by outflank-mailman (input) for mailman id 247424;
 Wed, 15 Dec 2021 15:02:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxVo3-0001cs-Hk
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 15:02:59 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16c6ee67-5db8-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 16:02:58 +0100 (CET)
Received: by mail-lf1-x129.google.com with SMTP id cf39so31591776lfb.8
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 07:02:58 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id i17sm356323lfe.281.2021.12.15.07.02.56
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 07:02:57 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16c6ee67-5db8-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=3VUw9tM+m0jbarRH4w6pSt3+J8WEisanbtrcGRlG8ww=;
        b=XnX3KlMW71XibvS+5PXXLlk/jp/CjOWYWwz+PHDxyU+EBz4JT0PPCKxrWWXOY9YA8L
         qn+C3VGweZy/OFJjDBD4VO8HkNajlpPonD/3H3IPcZdKtXUJ7rJ7/HxeBX7EvBBhjXZT
         mZea9qLNtc2Nlqhb2kkM2wKbFvrrsDsBzVX+dBZZ2LxeWxXlo79pHJsSCFIqH7YH2eVl
         7AcZcEUlsyyB+6jJLvPCCasQKM8D6q+0716kCv2+9TCEMIZ0Pfh+7ApQYRfrwJscY47S
         zrA5s2Dc4vDxnUWUIAE8tq6S7yy2FXWaeVP1L97Ln55xYLX9oP8kh0uxPGsB9mUViQ7F
         dupQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=3VUw9tM+m0jbarRH4w6pSt3+J8WEisanbtrcGRlG8ww=;
        b=AlvZOxNJ0gosS+jmi+E2XgYsq5WPD+YcdtytmOfHJnr6U/MTEAGHERuR9p/2muyFPv
         D6R4HNwGG1Nkn/5UGhJFvLqIZF1+6jQn19uMevyO9sksh+9MX/8sO33yZOPQcSlua0O0
         GbFDVnYm/06zG30MjJqkFFy1mESBY/VsinZyGi+Xiwi3XsWXAxAH5wi1Wenjr/mkhgxM
         /k+CXng2dv2G/Ce2BNpdRXRfXuBXt9wDSC7HBGE4aq/xnTozlFJoQVX0/aVm2D333TfF
         yKDyDwM5Xt4razyIUD0s8yGaX4Ztg4Z4JUEnMtn6HWDVf5Z3evAg81vHuCHE+pZBR+uh
         61lQ==
X-Gm-Message-State: AOAM533naV6r9+6f7Ie3B1gillozVwY8mKsDJ7Dt+OvRqftnJk2UniBj
	PbHyYaqqxafnTbnDoZy211k=
X-Google-Smtp-Source: ABdhPJwwLhZgub0yES1ms41VWT9/AvEg4+0/KrQ2xBoQ/ggbyh9d+FURZ5MtAp17elZ2aHcq7O0W1g==
X-Received: by 2002:a05:6512:308b:: with SMTP id z11mr9662770lfd.177.1639580577565;
        Wed, 15 Dec 2021 07:02:57 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
To: Juergen Gross <jgross@suse.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
Date: Wed, 15 Dec 2021 17:02:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 15.12.21 08:08, Juergen Gross wrote:

Hi Juergen

> On 14.12.21 18:44, Oleksandr wrote:
>>
>> On 14.12.21 18:03, Anthony PERARD wrote:
>>
>> Hi Anthony
>>
>>
>>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>
>>>> This patch adds basic support for configuring and assisting 
>>>> virtio-disk
>>>> backend (emualator) which is intended to run out of Qemu and could be
>>>> run in any domain.
>>>> Although the Virtio block device is quite different from traditional
>>>> Xen PV block device (vbd) from the toolstack point of view:
>>>>   - as the frontend is virtio-blk which is not a Xenbus driver, 
>>>> nothing
>>>>     written to Xenstore are fetched by the frontend (the vdev is not
>>>>     passed to the frontend)
>>>>   - the ring-ref/event-channel are not used for the backend<->frontend
>>>>     communication, the proposed IPC for Virtio is IOREQ/DM
>>>> it is still a "block device" and ought to be integrated in existing
>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>>>> logic to deal with Virtio devices as well.
>>> How backend are intended to be created? Is there something listening on
>>> xenstore?
>>>
>>> You mention QEMU as been the backend, do you intend to have QEMU
>>> listening on xenstore to create a virtio backend? Or maybe it is on the
>>> command line? There is QMP as well, but it's probably a lot more
>>> complicated as I think libxl needs refactoring for that.
>>
>>
>> No, QEMU is not involved there. The backend is a standalone application,
>> it is launched from the command line. The backend reads the Xenstore 
>> to get
>> the configuration and to detect when guest with the frontend is 
>> created/destroyed.
>
> I think this should be reflected somehow in the configuration, as I
> expect qemu might gain this functionality in the future.

I understand this and agree in general (however I am wondering whether 
this can be postponed until it is actually needed), but ...


>
>
> I'm wondering whether we shouldn't split the backend from the protocol
> (or specification?). Something like "protocol=virtio" (default would be
> e.g. "xen") and then you could add "backend=external" for your use case?

... I am afraid, I didn't get the idea. Are we speaking about the (new?) 
disk configuration options
here or these are not disk specific things at all and to be applicable 
for all possible backends?
If the former, then could the new backendtype simply do the job? For 
example, "backendtype=virtio_external" for our current use-case and 
"backendtype=virtio_qemu"
for the possible future use-cases? Could you please clarify the idea.


Thank you.



> We could later expand that to "backend=qemu" or "backend=<script-path>".
>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:15:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:15:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247435.426661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVze-0003c5-CS; Wed, 15 Dec 2021 15:14:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247435.426661; Wed, 15 Dec 2021 15:14:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxVze-0003by-9B; Wed, 15 Dec 2021 15:14:58 +0000
Received: by outflank-mailman (input) for mailman id 247435;
 Wed, 15 Dec 2021 15:14:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=iD5n=RA=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxVzc-0003bs-Eo
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 15:14:57 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0c5ecb4-5db9-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 16:14:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0c5ecb4-5db9-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639581293;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=HQGh1PYcJy47v6FrkcJXZDix0saAOacVjjqn19PDpQ4=;
  b=ZiNxccZGYAFNJZf8annEZXkGSaaVeNkxv13Mm56KWOUk8rsIfmLd6e/U
   YQODGKMWTEhK0nX7O1EU9g6ESBw0o2eCkvw+btXQGhP70Yj621B8ka6Uh
   +rRzRGP61G8GW6cYicoyWzMZ0docsiqr9Zf4WXZ1it78cubCj15LEBlvU
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: yomYvrEkLaTc1eHITXkFgo3403Cs+eq2keBG9LxC+SXj/vHjHrw5iKjJag1ALjRWRxkclEFW9m
 kd5gYNS7wRdMsMHk71rBbDrOJQ7/3EpIc3D11c9WC3YmGc8St2Z0lPxVRLKHKyLwzAFSY7Tb5X
 zoOwaVTzOKVH2PhwZdnITGY7SsXtmXzTK669M2QH3gDRT+G7pHK6rcmfrz48CMpv+/bmcaZoY2
 OUqHmwoOma7z61Q42FA9bXtkdwioGVKAf7Vw26wYm+6PbhOxwYCLdX/v3KGbhOAWXqVgYnbnyC
 vV+4werdhhvkKonpd/i9TrxG
X-SBRS: 5.1
X-MesageID: 59591454
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qu95OKiGnPVldbqSOyyMl1tzX161uBcKZh0ujC45NGQN5FlHY01je
 htvWWDVO6mPZDahc9h0ao7j9kMPvZSDyoRnTwdo/iw2Qyob9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx3IDja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1rmK2oWwoMAZTB27QaYSl0MhBiEp1JreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9t150fRKqDO
 6L1bxJCT0mZY0VCJ240Fc0xscajvEfEaR9x/Qf9Sa0fvDGIkV0ZPKLWGMLcZ9iiVchT2EGCq
 Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0ffdhC/83zT60x+mE5DSpKkk1UhFxZ4lz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9zABbvzt68owGOlor+p5
 Slsdy+2tr9mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ldRoxbJhUJG+3O
 ic/XD+9ArcJYhNGioctPOqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6CHfjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8
 G37UUhdoGcTT1WdcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:GL4E5KAfqZ4T/xvlHehOsceALOsnbusQ8zAXPh9KJiC9I/b1qy
 nxppkmPH/P6Qr4WBkb6Le90Y27MAnhHP9OkPIs1NKZMjUO11HYTr2KgbGSpgEIXheOi9K1tp
 0QDZSWaueAdGSS5PySiGLTc6dC/DDEytHRuQ639QYTcegAUdAH0+4WMHf+LqUgLzM2eabRWa
 DsrvZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolCs2Yndq+/MP4G
 LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REIGqjXQQmqWC+VwqmN
 7Dr1MJONly0WrYeiWPrR7ky2DboUETwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y
 pQtljp+KZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUB4S0LpXUd
 WGMfuspMq/KTihHjPkVyhUsZGRt00Ib1m7qhNogL3W79BU9EoJu3fwivZv20voz6hNO6Ws0d
 60R5iApIs+P/P+UpgNd9vpYfHHfFAlEii8eV57HzzcZdM60jT22trK3Ik=
X-IronPort-AV: E=Sophos;i="5.88,207,1635220800"; 
   d="scan'208";a="59591454"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QOFYT4UJ3xGBaI4CQjkEHnYhENi/zx0zEhvvap0sDCawt/oUODItLGZwAcrGdjgGX4hGylbYi2uKrGCO5yAaOjQ0xbq9wsNcYvbpBeJ0qV84K76UvA4/uwYdcIIQv4Ex1RdtwzRNa8ZHYQDv0HvU9OkwWdgZOioPewI+QEq5C8xp/wi7MXn44m+E1qZ//V6zUiMKZBtEnbrIWkyxF6L3t0LWVtwICT+iINfJVDruffxhFi86ILEmhrsPWje7S+DMSzYk70NBVpn95gEjrpfCzOJrsYF7PNEV1NQRtnXlPLOYKH1G3XcJFA2yY1xlcSWBKVewkqjZwso9BkYBQC3AIw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o9SMaDTnxsGI2iay8CBbhBdAFcma89TZhFlhp9GfPEU=;
 b=VIJcpj3R5EdbREj6H54OZQ4dCvscXskn76+brnP3dXKi2KhRpwK6XLIca8N/TsdtZBEVGmUi7obc0+CcyXw0W7sV8M/R/xRvh+e/V/IkuetsQZiclh95feovLPXQa4ywry1CdZhk/TCaG4PKZ4RXzOqyRuhVvNS4I+ZTqtChGS8F71flIid643MqIJ/F3AYnR3fwn+vsdf3tiVc/FvMnevneT2oJ9kK32Jst5lQMaw7AC+lggNouXFZCZEZjDBYHmiumY+R0qeb/w56JEpu32KSd9taH1qAdSe61EqhcijqKGhCJA8am88WCakWUptrhPc4/gLljrNUDUrb5A1e1Pw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=o9SMaDTnxsGI2iay8CBbhBdAFcma89TZhFlhp9GfPEU=;
 b=V3k5lu2+mCkM0aUCCFTIKYiYyKf8qk04c+g75lDjd+zGABCu1WDVtI7/1cBS/P3j7PfBmJTD3OixbM3um92zWYRCxSX3wjNIdUK05xGJmM7FUBf7pmnISRhcslL40QWYZsCTTEZx18egPyLeB94S8DnwUs+f8cnWil3VCtATT1A=
Date: Wed, 15 Dec 2021 16:14:38 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v2 17/18] AMD/IOMMU: free all-empty page tables
Message-ID: <YboGXiHaAO1cuUnd@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <ef31b6f4-09f5-cded-a235-5dce3c5399ce@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ef31b6f4-09f5-cded-a235-5dce3c5399ce@suse.com>
X-ClientProxiedBy: MR1P264CA0086.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3f::31) To SA0PR03MB5610.namprd03.prod.outlook.com
 (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b1d9329a-55c1-4881-0c54-08d9bfdda034
X-MS-TrafficTypeDiagnostic: SN2PR03MB2415:EE_
X-Microsoft-Antispam-PRVS: <SN2PR03MB2415C0D0FBE0576F2E518A3D8F769@SN2PR03MB2415.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aKIdDbyNVlj8TOgDicPs2r6xEm7vbe20LbQfTEJkUm8jsbW2hc5pdgD2/lCGSR1RxfxGQ78UTxpA8qA6Dxhf2NMANyV8AxiaVeO69w3SWYlalshoGrYPuTQ1YAKCiN6b5YuLabYU689d1dl/wf6mu7QZVguQeRPVUwfySRkdFkhTGTX0qZwGXMQJAOlFZBnUIZlK/Ez/+tuuv4hjwecmgMjtUEy8A59JkI+CYX9pUO3QcC0u6UXboAFBbidCuSXeHAGYVll/pka1NBFGLMQT9I2OIlhN60TazyCa79rUqaFxx5L/WHG3TGeY3hW/l7rIeeIzTo8+OTjq8NFnej8uXJcSmo1RT76O1VHZ5TXRuaJpFoXdZWHfKqoJg9AMD12kD/qSmY+eLq1PBPIf1Gdjj7UtDlUW8trhGYU98LKpQR4ZhWIO8ZOAvOnC9okSw59QOK87bqEKvmbagFobEdO9knIio18zM8MCwkZJv5H6ba1fO0p8GO++VNzvGn2p0B/StCu2tCQl3/tAieOqPv1F4J5MKtrXrqOFyrbYTeRdei3zsZBigaGtX5+6L/NHN5B5ryJPatxQkxpJNAWCzU1As5N/jSuh3fnlfNFfXVlQyGYsDzPJX6/5IxODv46NFqW3lQRrQj2mf7iIhNt798KBDQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66946007)(66556008)(66476007)(316002)(5660300002)(6486002)(6506007)(86362001)(6666004)(8676002)(38100700002)(26005)(186003)(83380400001)(33716001)(508600001)(6916009)(85182001)(2906002)(54906003)(82960400001)(4326008)(8936002)(6512007)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkxwU2hiMHY5VENiODNobEUzUE5KamZpSzZ2ak5tMlVnUHBnbGZveFdyNVlx?=
 =?utf-8?B?K3JZYmtncTBkWnFiME5GL3k2enV2TXB6SFBoN2ZlMlZ3MklERzBjQnB4Z2NU?=
 =?utf-8?B?RXdJN2hXUUFjWDNOVWJhUDBNZEF3d3psMmZ0WXZ0bnR1TlJza29qVFVMdHJk?=
 =?utf-8?B?RGNoelJVZ2tXUUZIZkxwWHlCR3NjNS9jTlpRVzFTYXFKMnFvQU9DVmkrb0RK?=
 =?utf-8?B?MUdjUGt6VkZmVkR0OVh0SkhBU0NNcjJjTURjaFluK0dOYitlc05WdXlUYmRr?=
 =?utf-8?B?V1pESWRha2haVytpaFFFWGwrY2VwWHlwclNFb3cxVC9zQzJnckl2Mk9sdHdr?=
 =?utf-8?B?a0oySFlVNWE5SHdXS01SOThUQ0NQVkMxbGJ3RjFwSzB6eWpVSWxYVTdid1Ji?=
 =?utf-8?B?SWl5Q3Bsd0tuYVBJaTRTR0hjaU16cDFGOWtQQ0hscHlZWW1IWEtpM1JwbCtY?=
 =?utf-8?B?K1NoWE5mRVBxWjF0anBtMUlMS0p0TFVrZWQ0TVdNMnZPbC9uSlN1blRpSTEx?=
 =?utf-8?B?NkFOdFh0K080K05LVnZNNG4wdFhCL0tCYUlmQ1phaGh0KzNBY3B5c2tscnNm?=
 =?utf-8?B?VE5zUlV3MllaVFpEb2w3eEpzU0cxb1ZENnV2bC9vQnA5NC9HODlEMGhZeXVE?=
 =?utf-8?B?d0xrbDl3Mi9pOXg0Y0pSbHF3aGlidTA0ZDNlNlVZNnc1WXBIQlZxQTZWTi9k?=
 =?utf-8?B?b1B5azdPUVRwSU5rTFdydTMrN0lGdURCK1MzaVM1Um5yYUZmc2Fld3Mzd0c5?=
 =?utf-8?B?U1ZMcFFrUlV3UXhDTG9jenFvNEpETVN6RU5UYnBnUGdRUG1pOGQ2alhUb2VB?=
 =?utf-8?B?Qnd2Y200ZnV2aSsreFl3NU5oRVphSHUvaEdWVTY0S3pVOVlCbHdQeUFjWllT?=
 =?utf-8?B?ejJWZW5pNXZSbkNJUHltRVByQ016V1JxM2xOemVmZ1F0NE9xRHBQekhsMmY1?=
 =?utf-8?B?akFBNU44SmhFQjdQZFNjYXdlMGFsaDBnblltbDJ4Z2pVa1UyRXduRGVkeVFS?=
 =?utf-8?B?dnFNN0JFRXptTVJ2bmtvaWZRYkdUZ3RyN3VGSVkxbnlocTRyQnV2TDM4aHdo?=
 =?utf-8?B?WlRnTU1SQWhsblBNSmkycGQzbEdGY2hxQ253MFZQcDVuWmV3L21TNHZSRmdO?=
 =?utf-8?B?UHVLREp0TUltZnlJV2VJeUVsa2haRGZSeDZGQ2JtZVRsdEtrVENpb0ErNjdN?=
 =?utf-8?B?akIxN2hXR3ZPQVpvV2o3dTRRSlZVRzBkd2J4MWRqZnlESUJnRElSbkJoQ25m?=
 =?utf-8?B?a2RHdTYxMXhaV0ZmeEZlTGJ1dXZYcThzQ1hVeDkvbDdMa1BCOXZpZkU3MjNl?=
 =?utf-8?B?cmN3elVRbUNtK2FvSEoyNGdrVTUxenRFc1E3N2RlVmhmT1oybVZkSWNEbXYz?=
 =?utf-8?B?R2JoWXZVUTM1cTNGa3hnczRHV01vY2p6dE53TWg1R0xVejd4cWRzNFk1TTFE?=
 =?utf-8?B?R3p1RlJ6Q0tBYzlvMFlJMldlWGJzTUNQRmhLM3JXaHNEaGRRQTlPTE5UbzVl?=
 =?utf-8?B?WVo5UzdvSzFVUzdQdERxNm45R3NYamwyWGFKZllkTEFrM1ovZVA5OTFlWmVu?=
 =?utf-8?B?VFJHcFMzTHM4Y1FoWExsYm50ZHVZU2luQzQxK1J1ZmozRUFxb0thRkxUNTk5?=
 =?utf-8?B?VjB0Z2owMitITVM1ck1ERm1oTWZ3dUE1NFRKSlQyQzJLZ3dzUWRmT0MyTDIr?=
 =?utf-8?B?U3YzcEZaRU1VV21nODVUV3RwaEdCaWh2WHV6MjhUcW5ITUwvNXZWM0haK2Vp?=
 =?utf-8?B?cjFjd055a2o5NXR3aGF0bmQzMmJrVHZLZjRSUk0vZCsxbGRDWGNobHlxOHht?=
 =?utf-8?B?dzZtajFZUk0vaUt5dVlSRUhXVTFzNnlPblEwSDVNMkZ6MkJJV0MvRFFOR1FE?=
 =?utf-8?B?M01PclY0WGJRYnlkRm9YN0E0UFlHeXdqRGx0M2JMU0p1T21TY2pNcVlQcXVk?=
 =?utf-8?B?c3l0UndQRFdRNDAxeE4vREsrK1dTOVBpYnIySEVaeHI5MWI2TzFMSER6VEpB?=
 =?utf-8?B?OElxZG5sUnlyZDNwbVlSUk5tdCtWOXNnY0RIeFRjRE5vUE9GVjlpdm9oQURs?=
 =?utf-8?B?aXRvMit6T2w5R2J6SnJIRFRXdy8yV09aUFVLVjdsa3E1L1VPMDY5ZW5adytT?=
 =?utf-8?B?c01xUXZIKzBJdEFCZnQzdzVLakNDTWdlbkhzZFRWdzNIV3V3czlwbGlldjlZ?=
 =?utf-8?Q?6PgMgpEtfaopi0TNPU0Q8WY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b1d9329a-55c1-4881-0c54-08d9bfdda034
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 15:14:44.9055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TF9vzTYxb4b40zzbFLmm6vhjj9jk5y1j0azvXggMuAlPchquk2+DyXerwrSjXbzVz92D4eijPQNO4HxgZQvJwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2415
X-OriginatorOrg: citrix.com

On Fri, Sep 24, 2021 at 11:55:57AM +0200, Jan Beulich wrote:
> When a page table ends up with no present entries left, it can be
> replaced by a non-present entry at the next higher level. The page table
> itself can then be scheduled for freeing.
> 
> Note that while its output isn't used there yet, update_contig_markers()
> right away needs to be called in all places where entries get updated,
> not just the one where entries get cleared.

Couldn't you also coalesce all contiguous page tables into a
super-page entry at the higher level? (not that should be done here,
it's just that I'm not seeing any patch to that effect in the series)

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> v2: New.
> 
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -21,6 +21,9 @@
>  
>  #include "iommu.h"
>  
> +#define CONTIG_MASK IOMMU_PTE_CONTIG_MASK
> +#include <asm/contig-marker.h>
> +
>  /* Given pfn and page table level, return pde index */
>  static unsigned int pfn_to_pde_idx(unsigned long pfn, unsigned int level)
>  {
> @@ -33,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig
>  
>  static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn,
>                                                     unsigned long dfn,
> -                                                   unsigned int level)
> +                                                   unsigned int level,
> +                                                   bool *free)
>  {
>      union amd_iommu_pte *table, *pte, old;
> +    unsigned int idx = pfn_to_pde_idx(dfn, level);
>  
>      table = map_domain_page(_mfn(l1_mfn));
> -    pte = &table[pfn_to_pde_idx(dfn, level)];
> +    pte = &table[idx];
>      old = *pte;
>  
>      write_atomic(&pte->raw, 0);
>  
> +    *free = update_contig_markers(&table->raw, idx, level, PTE_kind_null);
> +
>      unmap_domain_page(table);
>  
>      return old;
> @@ -85,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte
>      if ( !old.pr || old.next_level ||
>           old.mfn != next_mfn ||
>           old.iw != iw || old.ir != ir )
> +    {
>          set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
> +        update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), level,
> +                              PTE_kind_leaf);
> +    }
>      else
>          old.pr = false; /* signal "no change" to the caller */
>  
> @@ -259,6 +270,9 @@ static int iommu_pde_from_dfn(struct dom
>              smp_wmb();
>              set_iommu_pde_present(pde, next_table_mfn, next_level, true,
>                                    true);
> +            update_contig_markers(&next_table_vaddr->raw,
> +                                  pfn_to_pde_idx(dfn, level),
> +                                  level, PTE_kind_table);
>  
>              *flush_flags |= IOMMU_FLUSHF_modified;
>          }
> @@ -284,6 +298,9 @@ static int iommu_pde_from_dfn(struct dom
>                  next_table_mfn = mfn_x(page_to_mfn(table));
>                  set_iommu_pde_present(pde, next_table_mfn, next_level, true,
>                                        true);
> +                update_contig_markers(&next_table_vaddr->raw,
> +                                      pfn_to_pde_idx(dfn, level),
> +                                      level, PTE_kind_table);

Would be nice if we could pack the update_contig_markers in
set_iommu_pde_present (like you do for clear_iommu_pte_present).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:28:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:28:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247440.426672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWCv-0005Fz-Ij; Wed, 15 Dec 2021 15:28:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247440.426672; Wed, 15 Dec 2021 15:28:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWCv-0005Fs-Fe; Wed, 15 Dec 2021 15:28:41 +0000
Received: by outflank-mailman (input) for mailman id 247440;
 Wed, 15 Dec 2021 15:28:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxWCt-0005Fm-OZ
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 15:28:39 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ac7fdbfa-5dbb-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 16:28:37 +0100 (CET)
Received: by mail-lj1-x235.google.com with SMTP id b19so32083415ljr.12
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 07:28:38 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id l22sm365963lfc.307.2021.12.15.07.28.36
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 07:28:37 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac7fdbfa-5dbb-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=vg7Dm1smVZxgfGUzJHFPwHjldCpWgF79YZo3lBpnGu0=;
        b=fhnDyo38zsMz7KcqM4yslSLJnY47Q7bjQq2mvRKIMiE2veBFjmyDDZO8zklfMcUM+y
         kRoMuPhcPubBBiNyHtzMdmByBl5cfgn4pLjfovRpVmM475wMM9X/K70+4bMi0qje1of7
         Fi3VSjOhChqAegPMuoMEA4IfINUzzFEHDh4Nzf7w6jDqSLNJ8ytHn7yo1I/UG9Wud6tL
         5xZicaNX8p5vqymYsbPkEz4YXy1VzoNp6xDADDabSd1E7WaExk7D4TF9w2bdTVgrjHe3
         w8v14jnwrOw3Sjgy8jWdzI2pmV3YYSVZZpkinNTbAYtFAFvxqz/FWvW8NjFOSCOCyKE3
         mGHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=vg7Dm1smVZxgfGUzJHFPwHjldCpWgF79YZo3lBpnGu0=;
        b=6U8/+echeVccU5KF+G3RKGkFLmz8zYTKZyoRlYcnRyuiUMAkg9KdRO/CYIqa1wt7CL
         kONXJ82IfvcXwYFrz7MIKP4cq/T4eQmdYHxA4Ra0QlZgjRNSKM89/P8pqxBkb9reWXal
         RoQ88zvC5u6tWOPrFjN47vUeITZkDOIpv3/XvjFEu+IEb7d+4l+JAgv0kwM8wq7Rib8/
         mVg+/AZ/OuC5Ooyd7yqe3TtaqXEu2M+Ws6eeZ0bzHdIFqXbAu4xFZEVoQCL/cqkd0NCx
         /PaJvHjn7bvjCPpFllv1aoSHD8RQgz0w6urfiXzphx4ZFsfKZsN2Hy2GKeTmxqiEX6Tq
         QMXg==
X-Gm-Message-State: AOAM5321zuxf7Dcyim3J781rqAeMDhY+WrAgqajFNRXuhu8X4WEpM0Ag
	0ogvQXetG2geyPI7GrUdO9s=
X-Google-Smtp-Source: ABdhPJxBAMtsVJBtGLdn2yBjtpbNB6tqfiQV2JkGF0h7zh8wXGQbCQzYKVBRvHXA0Amo5a9h0+vZfQ==
X-Received: by 2002:a2e:bc1b:: with SMTP id b27mr10701166ljf.91.1639582117624;
        Wed, 15 Dec 2021 07:28:37 -0800 (PST)
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <d0c860ea-2134-d8dd-9bf8-87cd9c1a9305@gmail.com>
Date: Wed, 15 Dec 2021 17:28:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 24.09.21 12:53, Jan Beulich wrote:

Hi Jan

> Having a separate flush-all hook has always been puzzling me some. We
> will want to be able to force a full flush via accumulated flush flags
> from the map/unmap functions. Introduce a respective new flag and fold
> all flush handling to use the single remaining hook.
>
> Note that because of the respective comments in SMMU and IPMMU-VMSA
> code, I've folded the two prior hook functions into one.

Changes to IPMMU-VMSA lgtm, for SMMU-v2 I think the same.


> For SMMU-v3,
> which lacks a comment towards incapable hardware, I've left both
> functions in place on the assumption that selective and full flushes
> will eventually want separating.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> TBD: What we really are going to need is for the map/unmap functions to
>       specify that a wider region needs flushing than just the one
>       covered by the present set of (un)maps. This may still be less than
>       a full flush, but at least as a first step it seemed better to me
>       to keep things simple and go the flush-all route.
> ---
> v2: New.
>
> --- a/xen/drivers/passthrough/amd/iommu.h
> +++ b/xen/drivers/passthrough/amd/iommu.h
> @@ -242,7 +242,6 @@ int amd_iommu_get_reserved_device_memory
>   int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
>                                                unsigned long page_count,
>                                                unsigned int flush_flags);
> -int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
>   void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int dev_id,
>                                dfn_t dfn);
>   
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -475,15 +475,18 @@ int amd_iommu_flush_iotlb_pages(struct d
>   {
>       unsigned long dfn_l = dfn_x(dfn);
>   
> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> -    ASSERT(flush_flags);
> +    if ( !(flush_flags & IOMMU_FLUSHF_all) )
> +    {
> +        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> +        ASSERT(flush_flags);
> +    }
>   
>       /* Unless a PTE was modified, no flush is required */
>       if ( !(flush_flags & IOMMU_FLUSHF_modified) )
>           return 0;
>   
> -    /* If the range wraps then just flush everything */
> -    if ( dfn_l + page_count < dfn_l )
> +    /* If so requested or if the range wraps then just flush everything. */
> +    if ( (flush_flags & IOMMU_FLUSHF_all) || dfn_l + page_count < dfn_l )
>       {
>           amd_iommu_flush_all_pages(d);
>           return 0;
> @@ -508,13 +511,6 @@ int amd_iommu_flush_iotlb_pages(struct d
>   
>       return 0;
>   }
> -
> -int amd_iommu_flush_iotlb_all(struct domain *d)
> -{
> -    amd_iommu_flush_all_pages(d);
> -
> -    return 0;
> -}
>   
>   int amd_iommu_reserve_domain_unity_map(struct domain *d,
>                                          const struct ivrs_unity_map *map,
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -642,7 +642,6 @@ static const struct iommu_ops __initcons
>       .map_page = amd_iommu_map_page,
>       .unmap_page = amd_iommu_unmap_page,
>       .iotlb_flush = amd_iommu_flush_iotlb_pages,
> -    .iotlb_flush_all = amd_iommu_flush_iotlb_all,
>       .reassign_device = reassign_device,
>       .get_device_group_id = amd_iommu_group_id,
>       .enable_x2apic = iov_enable_xt,
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -930,13 +930,19 @@ out:
>   }
>   
>   /* Xen IOMMU ops */
> -static int __must_check ipmmu_iotlb_flush_all(struct domain *d)
> +static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
> +                                          unsigned long page_count,
> +                                          unsigned int flush_flags)
>   {
>       struct ipmmu_vmsa_xen_domain *xen_domain = dom_iommu(d)->arch.priv;
>   
> +    ASSERT(flush_flags);
> +
>       if ( !xen_domain || !xen_domain->root_domain )
>           return 0;
>   
> +    /* The hardware doesn't support selective TLB flush. */
> +
>       spin_lock(&xen_domain->lock);
>       ipmmu_tlb_invalidate(xen_domain->root_domain);
>       spin_unlock(&xen_domain->lock);
> @@ -944,16 +950,6 @@ static int __must_check ipmmu_iotlb_flus
>       return 0;
>   }
>   
> -static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
> -                                          unsigned long page_count,
> -                                          unsigned int flush_flags)
> -{
> -    ASSERT(flush_flags);
> -
> -    /* The hardware doesn't support selective TLB flush. */
> -    return ipmmu_iotlb_flush_all(d);
> -}
> -
>   static struct ipmmu_vmsa_domain *ipmmu_get_cache_domain(struct domain *d,
>                                                           struct device *dev)
>   {
> @@ -1303,7 +1299,6 @@ static const struct iommu_ops ipmmu_iomm
>       .hwdom_init      = ipmmu_iommu_hwdom_init,
>       .teardown        = ipmmu_iommu_domain_teardown,
>       .iotlb_flush     = ipmmu_iotlb_flush,
> -    .iotlb_flush_all = ipmmu_iotlb_flush_all,
>       .assign_device   = ipmmu_assign_device,
>       .reassign_device = ipmmu_reassign_device,
>       .map_page        = arm_iommu_map_page,
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2649,11 +2649,17 @@ static int force_stage = 2;
>    */
>   static u32 platform_features = ARM_SMMU_FEAT_COHERENT_WALK;
>   
> -static int __must_check arm_smmu_iotlb_flush_all(struct domain *d)
> +static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn,
> +					     unsigned long page_count,
> +					     unsigned int flush_flags)
>   {
>   	struct arm_smmu_xen_domain *smmu_domain = dom_iommu(d)->arch.priv;
>   	struct iommu_domain *cfg;
>   
> +	ASSERT(flush_flags);
> +
> +	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
> +
>   	spin_lock(&smmu_domain->lock);
>   	list_for_each_entry(cfg, &smmu_domain->contexts, list) {
>   		/*
> @@ -2670,16 +2676,6 @@ static int __must_check arm_smmu_iotlb_f
>   	return 0;
>   }
>   
> -static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn,
> -					     unsigned long page_count,
> -					     unsigned int flush_flags)
> -{
> -	ASSERT(flush_flags);
> -
> -	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
> -	return arm_smmu_iotlb_flush_all(d);
> -}
> -
>   static struct iommu_domain *arm_smmu_get_domain(struct domain *d,
>   						struct device *dev)
>   {
> @@ -2879,7 +2875,6 @@ static const struct iommu_ops arm_smmu_i
>       .add_device = arm_smmu_dt_add_device_generic,
>       .teardown = arm_smmu_iommu_domain_teardown,
>       .iotlb_flush = arm_smmu_iotlb_flush,
> -    .iotlb_flush_all = arm_smmu_iotlb_flush_all,
>       .assign_device = arm_smmu_assign_dev,
>       .reassign_device = arm_smmu_reassign_dev,
>       .map_page = arm_iommu_map_page,
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -3431,7 +3431,6 @@ static const struct iommu_ops arm_smmu_i
>   	.hwdom_init		= arm_smmu_iommu_hwdom_init,
>   	.teardown		= arm_smmu_iommu_xen_domain_teardown,
>   	.iotlb_flush		= arm_smmu_iotlb_flush,
> -	.iotlb_flush_all	= arm_smmu_iotlb_flush_all,
>   	.assign_device		= arm_smmu_assign_dev,
>   	.reassign_device	= arm_smmu_reassign_dev,
>   	.map_page		= arm_iommu_map_page,
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -463,15 +463,12 @@ int iommu_iotlb_flush_all(struct domain
>       const struct domain_iommu *hd = dom_iommu(d);
>       int rc;
>   
> -    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush_all ||
> +    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush ||
>            !flush_flags )
>           return 0;
>   
> -    /*
> -     * The operation does a full flush so we don't need to pass the
> -     * flush_flags in.
> -     */
> -    rc = iommu_call(hd->platform_ops, iotlb_flush_all, d);
> +    rc = iommu_call(hd->platform_ops, iotlb_flush, d, INVALID_DFN, 0,
> +                    flush_flags | IOMMU_FLUSHF_all);
>       if ( unlikely(rc) )
>       {
>           if ( !d->is_shutting_down && printk_ratelimit() )
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -731,18 +731,21 @@ static int __must_check iommu_flush_iotl
>                                                   unsigned long page_count,
>                                                   unsigned int flush_flags)
>   {
> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> -    ASSERT(flush_flags);
> +    if ( flush_flags & IOMMU_FLUSHF_all )
> +    {
> +        dfn = INVALID_DFN;
> +        page_count = 0;
> +    }
> +    else
> +    {
> +        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> +        ASSERT(flush_flags);
> +    }
>   
>       return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified,
>                                page_count);
>   }
>   
> -static int __must_check iommu_flush_iotlb_all(struct domain *d)
> -{
> -    return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
> -}
> -
>   static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int next_level)
>   {
>       if ( next_level > 1 )
> @@ -2841,7 +2844,7 @@ static int __init intel_iommu_quarantine
>       spin_unlock(&hd->arch.mapping_lock);
>   
>       if ( !rc )
> -        rc = iommu_flush_iotlb_all(d);
> +        rc = iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
>   
>       /* Pages may be leaked in failure case */
>       return rc;
> @@ -2874,7 +2877,6 @@ static struct iommu_ops __initdata vtd_o
>       .resume = vtd_resume,
>       .crash_shutdown = vtd_crash_shutdown,
>       .iotlb_flush = iommu_flush_iotlb_pages,
> -    .iotlb_flush_all = iommu_flush_iotlb_all,
>       .get_reserved_device_memory = intel_iommu_get_reserved_device_memory,
>       .dump_page_tables = vtd_dump_page_tables,
>   };
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -147,9 +147,11 @@ enum
>   {
>       _IOMMU_FLUSHF_added,
>       _IOMMU_FLUSHF_modified,
> +    _IOMMU_FLUSHF_all,
>   };
>   #define IOMMU_FLUSHF_added (1u << _IOMMU_FLUSHF_added)
>   #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified)
> +#define IOMMU_FLUSHF_all (1u << _IOMMU_FLUSHF_all)
>   
>   int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
>                              unsigned long page_count, unsigned int flags,
> @@ -282,7 +284,6 @@ struct iommu_ops {
>       int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn,
>                                       unsigned long page_count,
>                                       unsigned int flush_flags);
> -    int __must_check (*iotlb_flush_all)(struct domain *d);
>       int (*get_reserved_device_memory)(iommu_grdm_t *, void *);
>       void (*dump_page_tables)(struct domain *d);
>   
>
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:36:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:36:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247447.426683 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWJu-0006s0-FO; Wed, 15 Dec 2021 15:35:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247447.426683; Wed, 15 Dec 2021 15:35:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWJu-0006rt-CJ; Wed, 15 Dec 2021 15:35:54 +0000
Received: by outflank-mailman (input) for mailman id 247447;
 Wed, 15 Dec 2021 15:35:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxWJt-0006rj-D6; Wed, 15 Dec 2021 15:35:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxWJs-0006Qm-V1; Wed, 15 Dec 2021 15:35:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxWJs-0007S7-GE; Wed, 15 Dec 2021 15:35:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxWJs-0002H8-Ff; Wed, 15 Dec 2021 15:35:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=wVA1OYdIrhPf9B13j6zngZNL/439YPGYHzqb1MqBLhY=; b=wgtKtG5AKhKPQzZv3MBsm/L1Ko
	xUdJ9gmE0cDVkMonsT4nqSJ0xozpigwwtd0WpWQUEPYsN6LYDtP7wamMLmVgWmz4owKztHdpuPffX
	fiEbjzvU9eCUlEag6pPSJ+WFkdozz75kUI5eqpDwk0f3dNLMpia6oht3LP/XxCuKMj0U=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167419-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167419: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=38f6d78c3b62f8825e7d802697b7992418a72da7
X-Osstest-Versions-That:
    ovmf=9006967c8d24f5d9585278fb6363b08f2118d424
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 15:35:52 +0000

flight 167419 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167419/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 38f6d78c3b62f8825e7d802697b7992418a72da7
baseline version:
 ovmf                 9006967c8d24f5d9585278fb6363b08f2118d424

Last test of basis   167414  2021-12-14 16:10:26 Z    0 days
Testing same since   167419  2021-12-14 23:11:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Pierre Gondois <Pierre.Gondois@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   9006967c8d..38f6d78c3b  38f6d78c3b62f8825e7d802697b7992418a72da7 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 15:58:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 15:58:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247454.426699 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWfT-0001CV-Bt; Wed, 15 Dec 2021 15:58:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247454.426699; Wed, 15 Dec 2021 15:58:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWfT-0001CO-97; Wed, 15 Dec 2021 15:58:11 +0000
Received: by outflank-mailman (input) for mailman id 247454;
 Wed, 15 Dec 2021 15:58:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=kH8z=RA=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxWfR-0001CI-HW
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 15:58:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cb3d14ad-5dbf-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 16:58:07 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 51FDF210E8;
 Wed, 15 Dec 2021 15:58:07 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AAE313B75;
 Wed, 15 Dec 2021 15:58:07 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id r4ZwAY8QumHrEwAAMHmgww
 (envelope-from <jgross@suse.com>); Wed, 15 Dec 2021 15:58:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb3d14ad-5dbf-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639583887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=jYr7j45kf3CVDPqQWgTjhGPwDBfSwHjT7cvkuVL6Pgo=;
	b=XkNGnL7pZZ6w5cs1CV0CkgjhW7kMGYW9/U7FUJq0XX4TsEjdsbCcvt4eNIJ6zvQZNGLA4P
	q3zMpTsGB8XmhtTvG4awnMzW1T9fVlmQ06+yo50Ibq/nqvky1ex2JldNS1Fgs6vWXZ06Kf
	M83cePallsEmJobaH8c/omnEN96oPYM=
To: Oleksandr <olekstysh@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
Date: Wed, 15 Dec 2021 16:58:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="VeOjrmomgssEjMMOywE0wIhp0gRv3Sn8d"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--VeOjrmomgssEjMMOywE0wIhp0gRv3Sn8d
Content-Type: multipart/mixed; boundary="xxLXFWYBRL1QSwkGyBQNnNYre2XMJP89u";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
In-Reply-To: <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>

--xxLXFWYBRL1QSwkGyBQNnNYre2XMJP89u
Content-Type: multipart/mixed;
 boundary="------------A23C7142272FCC8AC239F321"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------A23C7142272FCC8AC239F321
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.12.21 16:02, Oleksandr wrote:
>=20
> On 15.12.21 08:08, Juergen Gross wrote:
>=20
> Hi Juergen
>=20
>> On 14.12.21 18:44, Oleksandr wrote:
>>>
>>> On 14.12.21 18:03, Anthony PERARD wrote:
>>>
>>> Hi Anthony
>>>
>>>
>>>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote=
:
>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>
>>>>> This patch adds basic support for configuring and assisting=20
>>>>> virtio-disk
>>>>> backend (emualator) which is intended to run out of Qemu and could =
be
>>>>> run in any domain.
>>>>> Although the Virtio block device is quite different from traditiona=
l
>>>>> Xen PV block device (vbd) from the toolstack point of view:
>>>>> =C2=A0 - as the frontend is virtio-blk which is not a Xenbus driver=
,=20
>>>>> nothing
>>>>> =C2=A0=C2=A0=C2=A0 written to Xenstore are fetched by the frontend =
(the vdev is not
>>>>> =C2=A0=C2=A0=C2=A0 passed to the frontend)
>>>>> =C2=A0 - the ring-ref/event-channel are not used for the backend<->=
frontend
>>>>> =C2=A0=C2=A0=C2=A0 communication, the proposed IPC for Virtio is IO=
REQ/DM
>>>>> it is still a "block device" and ought to be integrated in existing=

>>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuratio=
n
>>>>> logic to deal with Virtio devices as well.
>>>> How backend are intended to be created? Is there something listening=
 on
>>>> xenstore?
>>>>
>>>> You mention QEMU as been the backend, do you intend to have QEMU
>>>> listening on xenstore to create a virtio backend? Or maybe it is on =
the
>>>> command line? There is QMP as well, but it's probably a lot more
>>>> complicated as I think libxl needs refactoring for that.
>>>
>>>
>>> No, QEMU is not involved there. The backend is a standalone applicati=
on,
>>> it is launched from the command line. The backend reads the Xenstore =

>>> to get
>>> the configuration and to detect when guest with the frontend is=20
>>> created/destroyed.
>>
>> I think this should be reflected somehow in the configuration, as I
>> expect qemu might gain this functionality in the future.
>=20
> I understand this and agree in general (however I am wondering whether =

> this can be postponed until it is actually needed), but ...

This might lead to the need to support some "legacy" options in future.
I think we should at least think whether these scheme will cover (or
prohibit) extensions which are already on the horizon.

>> I'm wondering whether we shouldn't split the backend from the protocol=

>> (or specification?). Something like "protocol=3Dvirtio" (default would=
 be
>> e.g. "xen") and then you could add "backend=3Dexternal" for your use c=
ase?
>=20
> ... I am afraid, I didn't get the idea. Are we speaking about the (new?=
)=20
> disk configuration options
> here or these are not disk specific things at all and to be applicable =

> for all possible backends?

I was talking of a general approach using the disk as an example. For
disks it is just rather obvious.

> If the former, then could the new backendtype simply do the job? For=20
> example, "backendtype=3Dvirtio_external" for our current use-case and=20
> "backendtype=3Dvirtio_qemu"
> for the possible future use-cases? Could you please clarify the idea.

I want to avoid overloading the backendtype with information which is
in general not really related by the backend. You can have a qemu based
qdisk backend serving a Xen PV-disk (like today) or a virtio disk.

A similar approach has been chosen for the disk format: it is not part
of the backend, but a parameter of its own. This way e.g. the qdisk
backend can use the original qdisk format, or the qcow format.

In practice we are having something like the "protocol" already today:
the disk device name is encoding that ("xvd*" is a Xen PV disk, while
"sd*" is an emulated SCSI disk, which happens to be presented to the
guest as "xvd*", too). And this is an additional information not
related to the backendtype.

So we have basically the following configuration items, which are
orthogonal to each other (some combinations might not make sense,
but in theory most would be possible):

1. protocol: emulated (not PV), Xen (like today), virtio

2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)

3. format: raw, qcow, qcow2, vhd, qed

The combination virtio+phy would be equivalent to vhost, BTW. And
virtio+other might even use vhost-user, depending on the daemon.


Juergen

--------------A23C7142272FCC8AC239F321
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------A23C7142272FCC8AC239F321--

--xxLXFWYBRL1QSwkGyBQNnNYre2XMJP89u--

--VeOjrmomgssEjMMOywE0wIhp0gRv3Sn8d
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG6EI4FAwAAAAAACgkQsN6d1ii/Ey8I
twgAlw6MP7MLov3vc6X+VCcVcW63Bg2ubPBgVO4gISFh+dRob2YBuZed2EymBz5DIExvIcJd5M63
3xPMzWjOQyhxysyv3or37O0SfUFTGYf2jPwSercPtwi0aDBIjzVUvIo3YGlCD1Tz+f3bQUa0pLlo
rCHIwG1P6Crx78+R+EgH+5v5Au9XC35WCtzpUKRJFQ1bA2JpA27blK4It4H67ndeBgePGZar6cvN
wHbrI0WIGXNrRbscM6P5vFNWuckWwgst56xYn2Q5XydOwAJ/EUCMpPQN9UjZPFVv9DtHO4rjEKs+
Ko5ur4SbVs1B2OaNGB1uKvjSDFgoTH3qZuKdGoHr+g==
=DcRg
-----END PGP SIGNATURE-----

--VeOjrmomgssEjMMOywE0wIhp0gRv3Sn8d--


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 16:18:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 16:18:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247462.426711 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWyu-0004N9-P2; Wed, 15 Dec 2021 16:18:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247462.426711; Wed, 15 Dec 2021 16:18:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxWyu-0004N2-Ln; Wed, 15 Dec 2021 16:18:16 +0000
Received: by outflank-mailman (input) for mailman id 247462;
 Wed, 15 Dec 2021 16:18:15 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EjzN=RA=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxWyt-0004Mu-4a
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 16:18:15 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9a4eddcf-5dc2-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 17:18:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9a4eddcf-5dc2-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639585092;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rJVDTOuDDTSDYTKGknJ4P2/i6V8wI5GXY78I0tAdccE=;
	b=Duk9xXYJRbMmemMIOmEyunjHOHUpSQ52ka5BJz2QJs2S0qPRIK58y+S3Lko1ZlEjQE4BX8
	ZU028VnNCSYc9l0XY8uhQma7yD4UrOymDjltXVY4rv8h7zgNlwduFdqwAcAFDON1RX3zi2
	mmVT0W/J+Dnpx9gU69YThbgcMVdIGDwktBYeU8w6xHDNNQ1cfVXfi7UJUdu8cZFpZ4djvW
	sNfj11z/AlBcs/iBjLIkOdp3fZ5Jn2Frw6ku5unRVchcjEBwGq+5TST3aSGvBDLz4W/cCs
	+a6ygbS16QffcOcKDJAfM3Xj6o1sZeY6YbYJAVGM9q/cH3hPizriXmurSZqczA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639585092;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rJVDTOuDDTSDYTKGknJ4P2/i6V8wI5GXY78I0tAdccE=;
	b=VaI3p2v0+/sjSWEzfZRRZs5oPT3dZJd36h/55liytya3KHC+MGusZdBUZeky4AheCysSDm
	D0SIY5tvwLxpauBg==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>, Juergen Gross
 <jgross@suse.com>, xen-devel@lists.xenproject.org, Arnd Bergmann
 <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <87h7basx36.ffs@tglx>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx> <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly> <87h7basx36.ffs@tglx>
Date: Wed, 15 Dec 2021 17:18:11 +0100
Message-ID: <87zgp1rge4.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Tue, Dec 14 2021 at 22:19, Thomas Gleixner wrote:
> On Tue, Dec 14 2021 at 14:56, Nishanth Menon wrote:
>
> thanks for trying. I'll have a look again with brain awake tomorrow
> morning.

Morning was busy with other things, but I found what my sleepy brain
managed to do wrong yesterday evening.

Let me reintegrate the pile and I'll send you an update.

Thanks,

        tglx


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 16:36:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 16:36:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247467.426722 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXFu-0006wo-8e; Wed, 15 Dec 2021 16:35:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247467.426722; Wed, 15 Dec 2021 16:35:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXFu-0006wh-5X; Wed, 15 Dec 2021 16:35:50 +0000
Received: by outflank-mailman (input) for mailman id 247467;
 Wed, 15 Dec 2021 16:35:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EjzN=RA=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxXFt-0006wb-4j
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 16:35:49 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0e69a80f-5dc5-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 17:35:47 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0e69a80f-5dc5-11ec-9e60-abaf8a552007
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639586146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3UB4Bw8MahD5M8h/NI3Qg8AnbGIqaExPOcnRrzmSiao=;
	b=UJE/DKAABkBqFfjPbQnvYAH3rAoH/vlj0D3tBq02glY+Xwhi8IpuF/pdE8zOIh+LNq59Nl
	kIqPjL89RcIzLEag1h7k2fjb+cwOgjLe2MPvqWGyX6pPIlfV1AnbJNO0RuBaUEb7/o0lvf
	q7lAhQWh+jCRH3tIOsFsqmXut2p3+pY+woMjHpqHODXs3CqrcekUWtGDQ70j670MFnLBTT
	aQ4wHJwfbR6HaCSKuK7oh9/3WwrmyLBIAATt4Nc3Q80k12NK8vG02zW6aIuT4FiJH5XBgo
	uSp+QB7y3cnGolmhLgdyTIlgvw5ujoxSylCKtVjDQrixkhMxYakcLekWYL3jCQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639586146;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=3UB4Bw8MahD5M8h/NI3Qg8AnbGIqaExPOcnRrzmSiao=;
	b=FmacxqQdf9S6/zcHrLZoWNqKtU3gTCf8SLlCTPXPqPhR+QBO0MStt+qlts1rWvFXaKykO/
	d3arXts9WnCbrmDA==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>, Juergen Gross
 <jgross@suse.com>, xen-devel@lists.xenproject.org, Arnd Bergmann
 <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <87zgp1rge4.ffs@tglx>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx> <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly> <87h7basx36.ffs@tglx>
 <87zgp1rge4.ffs@tglx>
Date: Wed, 15 Dec 2021 17:35:46 +0100
Message-ID: <87wnk5rfkt.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Dec 15 2021 at 17:18, Thomas Gleixner wrote:

> On Tue, Dec 14 2021 at 22:19, Thomas Gleixner wrote:
>> On Tue, Dec 14 2021 at 14:56, Nishanth Menon wrote:
>>
>> thanks for trying. I'll have a look again with brain awake tomorrow
>> morning.
>
> Morning was busy with other things, but I found what my sleepy brain
> managed to do wrong yesterday evening.
>
> Let me reintegrate the pile and I'll send you an update.

   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.1-part-2
   git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.2-part-3

That should cure the problem.



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:17:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:17:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247472.426733 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXta-0003E2-Ai; Wed, 15 Dec 2021 17:16:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247472.426733; Wed, 15 Dec 2021 17:16:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXta-0003Dv-7F; Wed, 15 Dec 2021 17:16:50 +0000
Received: by outflank-mailman (input) for mailman id 247472;
 Wed, 15 Dec 2021 17:16:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EjzN=RA=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxXtY-0003Dp-Cl
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:16:48 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c80da237-5dca-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 18:16:46 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c80da237-5dca-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639588605;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hTXOQ1FMkJ0+Ve5/rvFPORGJ7hh35Px6k1s7EMBqwmo=;
	b=i6Ikjou/b+Yv6lqIV32A3e7GrIvLIXj3odnZe3TCIDVaZVz2iBNvzwVInSKTb//rUts3UC
	JXIUPspxUbLjL9vLFCxTqkEmsPcQqa0jlRZz9J/ERXHS6IU+v5Pv+VEwjaIZfQH59cCNVG
	TqlToMkGDTbisox0dOJ/N64NarNbO3ICfcEhoFvRBVMDwbMb41vhNRSUHGUzt3KciwFYd7
	KRvqTPgAkbaRf2bOiXIaKgM/dYKSqDiHD48+e3p3RQ+gRngvixMUmQX9dMSiQcMx2hbtZI
	cHrIArstu1gEQ3/ZZ5d7srqdLoqOVYjoPAeWdZ3az2kYFP70K+iy5VdJAoq5Kg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639588605;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hTXOQ1FMkJ0+Ve5/rvFPORGJ7hh35Px6k1s7EMBqwmo=;
	b=uXGey63VsKcnveGMEu+kEJG3x08mVaUqgXZXmEYNmGM1D3z+MIXuzL71XeYcsBJuZs9Whq
	rytYH1rq8fa5TmBg==
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Stuart Yoder
 <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth
 Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Santosh Shilimkar
 <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>
Subject: [patch V4 09-01/35] PCI/MSI: Decouple MSI[-X] disable from
 pcim_release()
In-Reply-To: <20211210221813.740644351@linutronix.de>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.740644351@linutronix.de>
Date: Wed, 15 Dec 2021 18:16:44 +0100
Message-ID: <87tuf9rdoj.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

The MSI core will introduce runtime allocation of MSI related data. This
data will be devres managed and has to be set up before enabling
PCI/MSI[-X]. This would introduce an ordering issue vs. pcim_release().

The setup order is:

   pcim_enable_device()
	devres_alloc(pcim_release...);
	...
	pci_irq_alloc()
	  msi_setup_device_data()
	     devres_alloc(msi_device_data_release, ...)

and once the device is released these release functions are invoked in the
opposite order:

    msi_device_data_release()
    ...
    pcim_release()
       pci_disable_msi[x]()

which is obviously wrong, because pci_disable_msi[x]() requires the MSI
data to be available to tear down the MSI[-X] interrupts.

Remove the MSI[-X] teardown from pcim_release() and add an explicit action
to be installed on the attempt of enabling PCI/MSI[-X].

This allows the MSI core data allocation to be ordered correctly in a
subsequent step.

Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V4: New patch
---
 drivers/pci/msi/msi.c |   33 +++++++++++++++++++++++++++++++++
 drivers/pci/pci.c     |    5 -----
 include/linux/pci.h   |    3 ++-
 3 files changed, 35 insertions(+), 6 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -341,6 +341,31 @@ void pci_restore_msi_state(struct pci_de
 }
 EXPORT_SYMBOL_GPL(pci_restore_msi_state);
 
+static void pcim_msi_release(void *pcidev)
+{
+	struct pci_dev *dev = pcidev;
+
+	dev->is_msi_managed = false;
+	pci_free_irq_vectors(dev);
+}
+
+/*
+ * Needs to be separate from pcim_release to prevent an ordering problem
+ * vs. msi_device_data_release() in the MSI core code.
+ */
+static int pcim_setup_msi_release(struct pci_dev *dev)
+{
+	int ret;
+
+	if (!pci_is_managed(dev) || dev->is_msi_managed)
+		return 0;
+
+	ret = devm_add_action(&dev->dev, pcim_msi_release, dev);
+	if (!ret)
+		dev->is_msi_managed = true;
+	return ret;
+}
+
 static struct msi_desc *
 msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
 {
@@ -884,6 +909,10 @@ static int __pci_enable_msi_range(struct
 	if (nvec > maxvec)
 		nvec = maxvec;
 
+	rc = pcim_setup_msi_release(dev);
+	if (rc)
+		return rc;
+
 	for (;;) {
 		if (affd) {
 			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
@@ -927,6 +956,10 @@ static int __pci_enable_msix_range(struc
 	if (WARN_ON_ONCE(dev->msix_enabled))
 		return -EINVAL;
 
+	rc = pcim_setup_msi_release(dev);
+	if (rc)
+		return rc;
+
 	for (;;) {
 		if (affd) {
 			nvec = irq_calc_affinity_vectors(minvec, nvec, affd);
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2024,11 +2024,6 @@ static void pcim_release(struct device *
 	struct pci_devres *this = res;
 	int i;
 
-	if (dev->msi_enabled)
-		pci_disable_msi(dev);
-	if (dev->msix_enabled)
-		pci_disable_msix(dev);
-
 	for (i = 0; i < DEVICE_COUNT_RESOURCE; i++)
 		if (this->region_mask & (1 << i))
 			pci_release_region(dev, i);
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -425,7 +425,8 @@ struct pci_dev {
 	unsigned int	ats_enabled:1;		/* Address Translation Svc */
 	unsigned int	pasid_enabled:1;	/* Process Address Space ID */
 	unsigned int	pri_enabled:1;		/* Page Request Interface */
-	unsigned int	is_managed:1;
+	unsigned int	is_managed:1;		/* Managed via devres */
+	unsigned int	is_msi_managed:1;	/* MSI release via devres installed */
 	unsigned int	needs_freset:1;		/* Requires fundamental reset */
 	unsigned int	state_saved:1;
 	unsigned int	is_physfn:1;


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:19:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:19:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247491.426744 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXwW-00046H-Ty; Wed, 15 Dec 2021 17:19:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247491.426744; Wed, 15 Dec 2021 17:19:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxXwW-00046A-PT; Wed, 15 Dec 2021 17:19:52 +0000
Received: by outflank-mailman (input) for mailman id 247491;
 Wed, 15 Dec 2021 17:19:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EjzN=RA=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxXwW-000462-7l
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:19:52 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 35dc1890-5dcb-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 18:19:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 35dc1890-5dcb-11ec-9e60-abaf8a552007
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639588790;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8dWZtEdF7LamMiNHDQtUJa+ux0BuM6MSUIqH9b+Hvyo=;
	b=wYhmWV2tAzCQfd9US7tK/sDWCnBbJEkh0toY9VDuwtDZ0a56PMo8BoccPtbLPELWo9I28H
	HKc2neisW5z7nVF58H33hQ6I3JpDjp7x8Kvp/cCgjUvnYD8QdYGH61A1BeXSEXOYr4fYH5
	DLBlYKQg7bDxik0O85eEeU6t0YgTJ460cdP5T6mA0DAEz4t2jvbnSoMRyHmCdRIsX+WU5+
	q/5iZYQod3bSNBGwjqvNjip+w8Kzgei0iFMPfqmZqeU25htKL5R6ykYiRwqQfnG6lFz+mQ
	r3FvWyI39vnZ4v4UgiVkKOdpkffYfcVyqNIiIF+3PGfZRf0ksOR9s1/A7ZSHGA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639588790;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=8dWZtEdF7LamMiNHDQtUJa+ux0BuM6MSUIqH9b+Hvyo=;
	b=lk+vW3OXeYaf8seyWIaOrmuYBvQZ09fZDnlpC9df3JMNaqJ74ZUxSByXPFwmhYxR0MLbL9
	iLeRWTRdVJiovHBA==
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>,
 Jason Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok
 Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Stuart Yoder
 <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth
 Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>, Santosh Shilimkar
 <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org, Vinod Koul
 <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>
Subject: [patch V4 09-02/35] PCI/MSI: Allocate MSI device data on first use
In-Reply-To: <87tuf9rdoj.ffs@tglx>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.740644351@linutronix.de> <87tuf9rdoj.ffs@tglx>
Date: Wed, 15 Dec 2021 18:19:49 +0100
Message-ID: <87r1adrdje.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Allocate MSI device data on first use, i.e. when a PCI driver invokes one
of the PCI/MSI enablement functions.

Add a wrapper function to ensure that the ordering vs. pcim_msi_release()
is correct.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
V4: Adopted to ensure devres ordering
---
 drivers/pci/msi/msi.c |   17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -366,6 +366,19 @@ static int pcim_setup_msi_release(struct
 	return ret;
 }
 
+/*
+ * Ordering vs. devres: msi device data has to be installed first so that
+ * pcim_msi_release() is invoked before it on device release.
+ */
+static int pci_setup_msi_context(struct pci_dev *dev)
+{
+	int ret = msi_setup_device_data(&dev->dev);
+
+	if (!ret)
+		ret = pcim_setup_msi_release(dev);
+	return ret;
+}
+
 static struct msi_desc *
 msi_setup_entry(struct pci_dev *dev, int nvec, struct irq_affinity *affd)
 {
@@ -909,7 +922,7 @@ static int __pci_enable_msi_range(struct
 	if (nvec > maxvec)
 		nvec = maxvec;
 
-	rc = pcim_setup_msi_release(dev);
+	rc = pci_setup_msi_context(dev);
 	if (rc)
 		return rc;
 
@@ -956,7 +969,7 @@ static int __pci_enable_msix_range(struc
 	if (WARN_ON_ONCE(dev->msix_enabled))
 		return -EINVAL;
 
-	rc = pcim_setup_msi_release(dev);
+	rc = pci_setup_msi_context(dev);
 	if (rc)
 		return rc;
 


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:36:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:36:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247496.426755 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYCb-0006VS-AO; Wed, 15 Dec 2021 17:36:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247496.426755; Wed, 15 Dec 2021 17:36:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYCb-0006VL-77; Wed, 15 Dec 2021 17:36:29 +0000
Received: by outflank-mailman (input) for mailman id 247496;
 Wed, 15 Dec 2021 17:36:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxYCZ-0006VF-SO
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:36:27 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYCZ-0000Zx-Ki; Wed, 15 Dec 2021 17:36:27 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYCZ-0008SP-EP; Wed, 15 Dec 2021 17:36:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=hUUFyS/gdCmhvpgv+kxy2T441Ba74d4RYuLPHMiEqT8=; b=cRbtBA1v5CRmGJ88iKDTMlzwxN
	OS8frRS2OIrUhva85beiAmibTKkQJc3y3UTQai3AZ++dDuKO3QdhkbC7nLRTDMZPmxbmVWm2Jeol+
	dsSltonPorsYMNflb03qbq+fyABxmM0zWW7R5jGb0LFZ8wPyIce/l+2Fi9l6baUCE7mM=;
Message-ID: <bf28a521-9187-4d12-2072-77f20e2c69ca@xen.org>
Date: Wed, 15 Dec 2021 17:36:25 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for
 hardware domain
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>,
 Oleksandr Andrushchenko <andr2000@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "sstabellini@kernel.org" <sstabellini@kernel.org>,
 Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Artem Mygaiev <Artem_Mygaiev@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <rahul.singh@arm.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <20211209072918.460902-3-andr2000@gmail.com>
 <78ee3d68-7901-2cfe-b0f1-76239339dc49@xen.org>
 <d58e87db-2be9-e982-b78e-64d72afb59ef@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <d58e87db-2be9-e982-b78e-64d72afb59ef@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 10/12/2021 18:37, Oleksandr Andrushchenko wrote:
> Hi, Julien!

Hello,

> On 10.12.21 19:52, Julien Grall wrote:
>> Hi Oleksandr,
>>
>> On 09/12/2021 07:29, Oleksandr Andrushchenko wrote:
>>> +unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
>>> +{
>>> +    if ( !has_vpci(d) )
>>> +        return 0;
>>> +
>>> +    if ( is_hardware_domain(d) )
>>> +    {
>>> +        int ret = pci_host_iterate_bridges_and_count(d, vpci_get_num_handlers_cb);
>>> +
>>> +        return ret < 0 ? 0 : ret;
>>
>> Sorry I only spotted this now. AFAICT, ret is not meant to return ret < 0 in this case. But if it were then I think it would be wrong to continue as nothing happened because the code will likely fall over/crash when registering the I/O handlers.
>>
>> I would document this oddity with
>>
>> if ( ret < 0 )
>> {
>>     ASSERT_UNREACHABLE();
>>     return 0;
>> }
>>
>> I can do the change on commit if the others are happy with it.
> Yes, please, do me a favor

Ok. With that:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

>>
>> Cheers,
>>
> Thank you,
> Oleksandr

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:46:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247505.426782 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYMT-0008I6-Di; Wed, 15 Dec 2021 17:46:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247505.426782; Wed, 15 Dec 2021 17:46:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYMT-0008Hz-Aj; Wed, 15 Dec 2021 17:46:41 +0000
Received: by outflank-mailman (input) for mailman id 247505;
 Wed, 15 Dec 2021 17:46:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dBW1=RA=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1mxYMR-0008Ht-KC
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:46:39 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2ce79bf-5dce-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 18:46:37 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 21FF8618FF;
 Wed, 15 Dec 2021 17:46:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAC38C36AE0;
 Wed, 15 Dec 2021 17:46:34 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2ce79bf-5dce-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1639590395;
	bh=8eon80aBZeFq23Odf9TNhXLZ0kuufkyxyEQ2UyQvkqg=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=UkCoNkhqYhaWsFSTKJpb77W8nbK6xBhgXx04HDrtcU3wqKWjQXiGzgyhrmLZyIcpi
	 MQjyZk+Z77/94x42VRHSfHDxYxwbhzyU1x8FRVQnYWLIzTIG39Is2wA6fDhqQ2fpqP
	 n5B4SefG3RtkmGRq+Q9AMgbeRnK4rPW85FgQYoxs=
Date: Wed, 15 Dec 2021 18:46:33 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V4 09-01/35] PCI/MSI: Decouple MSI[-X] disable from
 pcim_release()
Message-ID: <Ybop+ZdUQSqGkOxe@kroah.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.740644351@linutronix.de>
 <87tuf9rdoj.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87tuf9rdoj.ffs@tglx>

On Wed, Dec 15, 2021 at 06:16:44PM +0100, Thomas Gleixner wrote:
> The MSI core will introduce runtime allocation of MSI related data. This
> data will be devres managed and has to be set up before enabling
> PCI/MSI[-X]. This would introduce an ordering issue vs. pcim_release().
> 
> The setup order is:
> 
>    pcim_enable_device()
> 	devres_alloc(pcim_release...);
> 	...
> 	pci_irq_alloc()
> 	  msi_setup_device_data()
> 	     devres_alloc(msi_device_data_release, ...)
> 
> and once the device is released these release functions are invoked in the
> opposite order:
> 
>     msi_device_data_release()
>     ...
>     pcim_release()
>        pci_disable_msi[x]()
> 
> which is obviously wrong, because pci_disable_msi[x]() requires the MSI
> data to be available to tear down the MSI[-X] interrupts.
> 
> Remove the MSI[-X] teardown from pcim_release() and add an explicit action
> to be installed on the attempt of enabling PCI/MSI[-X].
> 
> This allows the MSI core data allocation to be ordered correctly in a
> subsequent step.
> 
> Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> V4: New patch


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:46:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:46:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247506.426793 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYMd-00009s-Kw; Wed, 15 Dec 2021 17:46:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247506.426793; Wed, 15 Dec 2021 17:46:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYMd-00009e-I5; Wed, 15 Dec 2021 17:46:51 +0000
Received: by outflank-mailman (input) for mailman id 247506;
 Wed, 15 Dec 2021 17:46:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=dBW1=RA=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1mxYMc-0008Ht-Ss
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:46:50 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fa9fec3c-5dce-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 18:46:49 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 26215B8204D;
 Wed, 15 Dec 2021 17:46:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3895EC36AE0;
 Wed, 15 Dec 2021 17:46:47 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fa9fec3c-5dce-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1639590408;
	bh=oVAWRtkVhyLVewrr96Eqb3xtvZVqpmLF7lafQtqO6io=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=RDn0d3Wgo9MrkKkAlhFp4clsP7kYBq6OP2oGHpB+ZI+/t6B5qJsnoCzurjsB46fWy
	 AoK6Or0D4ayB4bHwvQH/ebEEdMkczC3evphKuABc44ElX4jTf+p1dRuhuUK9c1usOI
	 gwGgUwjsoCjjzpzu2MRgkv/yDC8qQwbLbyooW/C4=
Date: Wed, 15 Dec 2021 18:46:45 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V4 09-02/35] PCI/MSI: Allocate MSI device data on first
 use
Message-ID: <YboqBZuwu5qDwxKS@kroah.com>
References: <20211210221642.869015045@linutronix.de>
 <20211210221813.740644351@linutronix.de>
 <87tuf9rdoj.ffs@tglx>
 <87r1adrdje.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87r1adrdje.ffs@tglx>

On Wed, Dec 15, 2021 at 06:19:49PM +0100, Thomas Gleixner wrote:
> Allocate MSI device data on first use, i.e. when a PCI driver invokes one
> of the PCI/MSI enablement functions.
> 
> Add a wrapper function to ensure that the ordering vs. pcim_msi_release()
> is correct.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 17:48:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 17:48:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247513.426804 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYOI-00011u-0j; Wed, 15 Dec 2021 17:48:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247513.426804; Wed, 15 Dec 2021 17:48:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYOH-00011n-Tm; Wed, 15 Dec 2021 17:48:33 +0000
Received: by outflank-mailman (input) for mailman id 247513;
 Wed, 15 Dec 2021 17:48:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxYOG-00011N-N6
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 17:48:32 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYOG-0000oq-CO; Wed, 15 Dec 2021 17:48:32 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYOG-0000yb-6H; Wed, 15 Dec 2021 17:48:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=EIXY0pH3FFvVoepyu1PKulGiK0ad+7HJPnljWC/AowE=; b=j7andU+Iq29SJZqxaN5390cmaR
	BHJx0e9DCKWMImxriCMzem4/oZUFk0O3iNYbobcOfX6bc46GTDizcUNVr/awoeLrL8IJPTvsI+Fn8
	QbtdipOxtk/fWyk7C5Y94dBQDEdgHIevVIzhDTAW0jOOB+JrFNIA1f65v16ScElqdScU=;
Message-ID: <17e4ce2b-be61-8fdb-d742-ea6ddf8fa996@xen.org>
Date: Wed, 15 Dec 2021 17:48:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v8 0/4] PCI devices passthrough on Arm, part 2
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
 xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com,
 volodymyr_babchuk@epam.com, artem_mygaiev@epam.com,
 bertrand.marquis@arm.com, rahul.singh@arm.com,
 Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211209072918.460902-1-andr2000@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 09/12/2021 07:29, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> Hi, all!

Hi Oleksandr,

> This is an assorted series of patches which aim is to make some further
> basis for PCI passthrough on Arm support. The series continues the work
> published earlier by Arm [1] and adds new helpers and clears the way for
> vPCI changes which will follow.
> 
> RFC is at [2], [3]. Design presentation can be found at [4].Hi
> 
> I have removed patch
> [PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices
> as it seems that this needs more time for decision on how to achive
> that.
> 
> I have also added a new patch
> [PATCH v7 4/7] xen/arm: account IO handler for emulated PCI host bridge
> with a tiny latent bug fix.
> 
> This series contains all the patches which are left un-committed yet.
> 
> Thank you,
> Oleksandr
> 
> [1] https://patchwork.kernel.org/project/xen-devel/list/?series=558681
> [2] https://lists.xenproject.org/archives/html/xen-devel/2020-07/msg01184.html
> [3] https://lists.xenproject.org/archives/html/xen-devel/2020-07/threads.html#01184
> [4] https://static.sched.com/hosted_files/xen2021/e4/PCI_Device_Passthrough_On_Arm.pdf
> 
> Oleksandr Andrushchenko (4):
>    xen/arm: add pci-domain for disabled devices
>    xen/arm: setup MMIO range trap handlers for hardware domain
>    xen/arm: account IO handler for emulated PCI host bridge
>    xen/arm: do not map PCI ECAM and MMIO space to Domain-0's p2m
> 
>   xen/arch/arm/domain.c              |   2 +
>   xen/arch/arm/domain_build.c        | 132 ++++++++++++++++++++---------
>   xen/arch/arm/pci/ecam.c            |  14 +++
>   xen/arch/arm/pci/pci-host-common.c |  77 ++++++++++++++++-
>   xen/arch/arm/pci/pci-host-zynqmp.c |   1 +
>   xen/arch/arm/vpci.c                |  85 ++++++++++++++++---
>   xen/arch/arm/vpci.h                |   6 ++
>   xen/include/asm-arm/pci.h          |  22 +++++
>   xen/include/asm-arm/setup.h        |  13 +++

As a FYI, Jan pushed today a commit that moved the headers from 
xen/include/asm-arm to xen/arch/arm/include/asm/.

I have handled the clash for this series while committing.

Thank you for the contribution.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 18:00:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 18:00:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247523.426815 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYZa-0003gt-2k; Wed, 15 Dec 2021 18:00:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247523.426815; Wed, 15 Dec 2021 18:00:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYZZ-0003gm-Vj; Wed, 15 Dec 2021 18:00:13 +0000
Received: by outflank-mailman (input) for mailman id 247523;
 Wed, 15 Dec 2021 18:00:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9HFQ=RA=epam.com=prvs=2983c13036=oleksandr_andrushchenko@srs-se1.protection.inumbo.net>)
 id 1mxYZY-0003gg-54
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 18:00:12 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d78f5d03-5dd0-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 19:00:10 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFFEViS024119;
 Wed, 15 Dec 2021 18:00:06 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cyjh6rp8j-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 18:00:06 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17)
 by AM0PR03MB6065.eurprd03.prod.outlook.com (2603:10a6:208:15c::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec
 2021 18:00:02 +0000
Received: from AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55]) by AM0PR03MB6324.eurprd03.prod.outlook.com
 ([fe80::7593:b5e4:6534:5e55%6]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021
 18:00:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d78f5d03-5dd0-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jktSMo4HL0mgCrEux1SX6+UdpvZIHKO7NgtzUIkVWZ2N3wRFDcYxjdv99vaJPx2dT7i9JL9Rw7YKXbRGrxhbDavNEEYnVSPy7pOEh7Xx6fYyi8TuVfEDeiqV/IsgzxXfRZWGrP5e+iAfqYkn7h4JMspCxf2/9BGPYBbbvxMcXaUIYzfXNYUARQQjzSq0XNI9MfaMkkUzxvlzSsm021mR+6YDUh1AugYeJMWkS0x3hZ551dGl5Cienysh+KsM++FawEKAvOAUhXi6CSpzSfE0GA51dwY/+jGYqsuFZfyuXObVKJI66tFYSBYdG12/+dfBXIfXnsFUBAw9HKdEQ9KCGw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FBZ0WjRYw7ztx2TEcfgsACygr4F8867E8Ng6HhwkZpA=;
 b=ESINfCA1g4mTFqVOtqgQXxRdWnDH4U9R1rHkKWkA7lhEA9Z0d5To0Jtcink694fj1tVRp72ku37ScgTXp2ZaCsKEIXu20gG3QBOgbcPnZ4if3l6/fAD1LbQqagV1hlmZjamnxu9diehvFKxlJmknJL5CEuCdb1slXKzdwi5FaWEQSTLSE/ieJ0r8JIAthyftvAQ+8RlxfXYWpQpq5vs2CyFmctpDcwhGR+TElw1ytzq9exE+s8e3hfVBRvni2EvSP4xCtJyiSZMECrgRaTGXy82qoWJlUQvUsbktKwpXvlHpg2OhGvFsf9SH6E7Oc12l8MH/4PxbvQ655x/vhBX0BA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FBZ0WjRYw7ztx2TEcfgsACygr4F8867E8Ng6HhwkZpA=;
 b=MWmqkKjAZ/ZUDogqamVLjKng++bdRYLTP6Q7Eiywb7STs4ABtw/xn9SJsg5g5d/IK0U8GnbrQsN1357S/OMLcqP+mZz2KA5Q7Z+I7kSjp23idRPAutBEzAcRCVIStCET45a/di5HXk9uIqENso0PB5V1c3x8XCNEc5EY6thQg2LFvDQyweIpve9c7uQN5Ry19aFUk6vFomQdOznanJarwFHb9Bw3f8drQnKIQhg3D1bIEPeEcD2CVaVHKlVAJJubGD9sy+qZvNZxaocFaK/9XUrS3/KXXmAQvXGJrMPgShIW5U1e4sOEeCI426tE0OWQUMQSML+kwJQQu2S2Ig+tUA==
From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Julien Grall <julien@xen.org>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>,
        Oleksandr Tyshchenko
	<Oleksandr_Tyshchenko@epam.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Artem Mygaiev <Artem_Mygaiev@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Rahul Singh
	<rahul.singh@arm.com>,
        Oleksandr Andrushchenko
	<Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v8 0/4] PCI devices passthrough on Arm, part 2
Thread-Topic: [PATCH v8 0/4] PCI devices passthrough on Arm, part 2
Thread-Index: AQHX7M5/eWAVb5SkUEuZj2suH/4dRawz3lKAgAADOYA=
Date: Wed, 15 Dec 2021 18:00:01 +0000
Message-ID: <83cb4029-276d-7851-1535-819deb3ba69e@epam.com>
References: <20211209072918.460902-1-andr2000@gmail.com>
 <17e4ce2b-be61-8fdb-d742-ea6ddf8fa996@xen.org>
In-Reply-To: <17e4ce2b-be61-8fdb-d742-ea6ddf8fa996@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 47fd8b4b-5075-4ae7-2583-08d9bff4b779
x-ms-traffictypediagnostic: AM0PR03MB6065:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <AM0PR03MB6065E5332A7FF55CF48471BDE7769@AM0PR03MB6065.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4502;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 oWh8a8bdDz+1BkmWN7ZQszzfssah8WLsvcWz59FKiMCOzkqj2eqxEkHfYs9gcS1I6h4SX0lWYZtPeFmaXAXOcW7/VY1VQqDf9IijF7VqF+G+LSU8hab2fkQYj5mlI3IQJL01LFXHB+xMtzcv6oYoE8NaAB6hwT1pzM5uAytbXM1CE2+EKQvgJeNVHZLFUVAU0k5gGK8J/aMwhVxvXS/YbQnnotHlj3KaAJlQF13MiwZfGJLJnj2/ly53HUawMLIHJBOrGGdSeTBhfN1GxtBjeDudw1axuvG9r9aWKryEVmhvlczDfBaMf4SmL2oX10kuAp30KNs+xSs3z3GkqGWCGLMuM8HWLt1zh1zpnC6vR8CIA5Iizh+dUvphP/ACLTSXcfh60soBb9OFoDgV35FnPk6+Y5PdP42YAXanv3kQV0UHJuQ9z1Rummq6S0X6eTWEu/jc8elH776lPNdmcG0dXi7stmTfb4oHTgUc7vYO1G3W0u4T7oxmK2Bj9rKxZuVgwUQgesBGv9mHFWsJny5uRw/jcjSv8oMORO/19TDy5aNRvZKOUNUf779k0myNIzZ8NkdnsU7WNQH7/j0R9Et9oYoiHSvaRnTnm7KeAOrDJqkCKIgxxlkOcvlKt4xmHQsT8AougXS/1mIDXkWeXtwTbINzmmC8C/xt3iyLTjM3YTCLajiCqvT5K+oKuU/ybxcdNnqpOkXIITKlvW3TwzrSSGnSAO8xRHb7yLjIDGp1h7DeKpz2PNmWEvTNLYHhIRMIdkqre73geOX8Vzcf1UhA82CoDuMDnpvIbiTUQ6LzII4R9C4lJPG2VqtVbI883eI29s0UTHB7b7p6VmB6Vpr6EVIbUiLScD34mIPD/td6Ohg=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(86362001)(508600001)(6512007)(316002)(110136005)(8676002)(38100700002)(966005)(83380400001)(6486002)(31696002)(38070700005)(66446008)(186003)(71200400001)(26005)(53546011)(107886003)(2906002)(55236004)(76116006)(91956017)(122000001)(54906003)(6506007)(8936002)(66476007)(66946007)(64756008)(66556008)(36756003)(2616005)(4326008)(31686004)(45980500001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?bElwMi9oYnd4YXNrS25TeW1EdURiejdsbGZkNm82aHNNbnNyelJzbU8wWUpw?=
 =?utf-8?B?LzBkcjdjejFpRGNsbS9EL2JLMjlFZXFGS2Y3UzZIcUxUcVJhSmdSRUM4NS8y?=
 =?utf-8?B?VzlmemtPYkE4MjhOY1Z2K0lzNWwwVVpUWXBKOVh4cGp4cGoyNjBkcytUVGxy?=
 =?utf-8?B?aXlhU3lxVUx5bHRWdmlYTHZBWER1SHdHc2hidHBHc2lHZnBFdGdXNTExV2NO?=
 =?utf-8?B?WnNPTUJsSXJmZjhvdjRVcVNsVHlrRzM2UE1WYnNmWDd2MVZqeWJRK2RWVFRp?=
 =?utf-8?B?MFJiYlJlS3ZDeXZsMzFIZXptWnRjVm94U09kOFBFQ2Z5cG1HaGFOUFhQcFMy?=
 =?utf-8?B?dUVWaVdMcC81dFRhcVVVQmYvME1sQ3JFd0M5MXNSUVNzaml0dGJjMWdsQWt3?=
 =?utf-8?B?Rmx6WU0wR1pqSGN3d040VXA2M1pUY0IyTjBlWGllS3cva2JaTjRRZzAyQ21V?=
 =?utf-8?B?MFNHWjFkSmp2N0hwNkZrSFl0L0xhV2R4Z0RFYXcwUXJxcmJWOUtCTVRMTkVq?=
 =?utf-8?B?V29NMEZkc1picUQxSWtiOGhkK1VubHhOeUk3Z2wzZ1JwWUlQLzNLQlFmT2Fs?=
 =?utf-8?B?dHZKOUEwWVU5QVFlSk50MWNpOERXOHI4dXRlRURNZnYzcEp2V3NaYW5nODlJ?=
 =?utf-8?B?QnVmWDZBK0dML0tzalYxWW9pM3hVaHBxUGNtU0l5YTNkV080ZTZjcURUM2Ft?=
 =?utf-8?B?aGQyUWx2dHluV1U0cWNJTzdxdnB3elRrOFJRQjA0emhRaWxrUnZ1c1g0R1lr?=
 =?utf-8?B?c2ZSOUtwQWtCWjJyeGM5VDUvSkhnZ2cxQy9md3NNanF6NXN3YWhTQTlDdlpF?=
 =?utf-8?B?eGwzYXNGNERFSTFXbnduTkNPRDlOYVhGQjc1ZEI4VDRRcEdNOWVxai80YVg3?=
 =?utf-8?B?Nm0vdFh5djNOdERETUFhRExCbnh4allQQUtrWUdKT2hUT1QyOGhxUnhZSGp2?=
 =?utf-8?B?YWh1ZWJPQjY2aVhjcTloRmdHWGwyekpDRVFadzVLaG83L3ZuYzJTb0dCM0Nj?=
 =?utf-8?B?UVFrNk11SDNIVXpIdW4rRW05WSt3TU5TNFlreHBJemFrRVordHBvSHQ4MWxp?=
 =?utf-8?B?THI5SktTTUV6OWJSRzhqYzlpejJhTWNoQUU2SDlVSkU2bVd3OW9VVUViR1RG?=
 =?utf-8?B?MWdHT0JQTlZBRVljZGZCRjEzYmkxSHpESTMra0N2cms5V2I1UnhCWnloL3Uz?=
 =?utf-8?B?Ry9uem05eVlJTmpVUVMvWno1bzJPaG85YzVZWmU3dXk4T1E2QmxoNWJidm5G?=
 =?utf-8?B?Zm1vZFpEd3RvQll1bHVjSnZ4OVRPV0s5L04xZXdqTlpwRk1HVmU3VnpUMkZO?=
 =?utf-8?B?NmN1QXlqYXhVdzJFQlRJWnJ6ZklGWkxBRERVUFdpYXY5NG93YjBUTmE0RTlP?=
 =?utf-8?B?a1k1V0Q3SFRGb0hsTCtEeXcyUUVBYXpxLzdzZHROMzFXbkJlUlFlU2RsYVFT?=
 =?utf-8?B?YmVRemFyUHpaVmQ2dWxxQkFmcmRQSmd0QjAvK0dBRE5SbDZKMzBKVkxRUGd3?=
 =?utf-8?B?ZU0vRXUrT2NaaE02ang0UDRYK1pycyswZ2JvV0RTMXRSS3A5SG1oTzJuWmFx?=
 =?utf-8?B?M1ZqV2lvUGJLaWRmQUFWaWIvZjVqUjFJZWlSNXdFdko2MDYvYVRnLzVSQ1FS?=
 =?utf-8?B?WVNKUFdoaEd2UW80ZGRKbUh1UjlROFNkekdIOFZlMjV2NDRVMGxLeUs3dDNO?=
 =?utf-8?B?cWtjNWNlT25RMHlTdXE2M0E4TVY4QlgyeG9zcWZZL2VhV1BteGtzN0ZSbHVT?=
 =?utf-8?B?YWpOdkRHNEM3K00rd1BSOTlBaEhGMnI4ZFBJMy9aRFZVWXg4UkthdW5IQ1Rz?=
 =?utf-8?B?V1pyYSt0V3V3a2V0WXkxS0JaUUpsLzFHYXU3M242cmgyNXEzMmZoS0RHYnBX?=
 =?utf-8?B?T292d0lLQml6Z3NBL1lnM1VScVNXS3NLYk1zVlByQjdDS2h6c1BkR2sxd1VM?=
 =?utf-8?B?WlBJTXpjNEpQQVNRSHdEMjg3eERQMDhBcnlYVXRMK1JKSFJOYVRhRnh0cjdL?=
 =?utf-8?B?b05rb2NWNXRNSEptMGMwWlV4dHMxOTdDWW1pTWJaZzQwSjBNSEhVUzZvSWdM?=
 =?utf-8?B?ZmQxMkUwNU9SZDFvZUZlY1lKazFrd0xlV3M1ZEZvNGd6c1UyQ0NHL2szMUha?=
 =?utf-8?B?T3pCNFFUUU5JcUFJSjlCdGN3OGZzaUpqSHcwdjhxaTEwTlRyVFJaZWJyUHpa?=
 =?utf-8?B?dlBMMVhaTTU3cUlzZTU4elF4MHJZUlNYaTVOR0Y1clQvKzNTTmEzV3N1WGRw?=
 =?utf-8?B?RHk5ZE4wVUdiU3BpRkZPOEsySlFYa1F4azJkdnA5N3F3QjdqTGRham1xWHNz?=
 =?utf-8?B?djlianJtNHQ5ZmZNM3dOM2FrMjRIcHRndTNwTFc0OGMxZVZReVg0QT09?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <2630DD1CF5CFB447AD2A9FEA7D831DFC@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47fd8b4b-5075-4ae7-2583-08d9bff4b779
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 18:00:01.9637
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jvX6sVdtC5F1uKdJNR7PQg9Ht12cz7XIVZ/vwVkKa4Z7uE4isQDRor8h8TH63FVhAgUYukt5hZq6IsM6hwwMqhkoivz9s0lfjExCjyJnkHm1piMmulPgxwSheqnOfVSs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6065
X-Proofpoint-GUID: PC9ASQ8DAKmA2fu61_MDcWkyCPnoW_Gb
X-Proofpoint-ORIG-GUID: PC9ASQ8DAKmA2fu61_MDcWkyCPnoW_Gb
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_10,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0
 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0
 bulkscore=0 clxscore=1015 spamscore=0 mlxscore=0 mlxlogscore=999
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112150101

SGksIEp1bGllbiENCg0KT24gMTUuMTIuMjEgMTk6NDgsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g
T24gMDkvMTIvMjAyMSAwNzoyOSwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+PiBG
cm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBh
bS5jb20+DQo+Pg0KPj4gSGksIGFsbCENCj4NCj4gSGkgT2xla3NhbmRyLA0KPg0KPj4gVGhpcyBp
cyBhbiBhc3NvcnRlZCBzZXJpZXMgb2YgcGF0Y2hlcyB3aGljaCBhaW0gaXMgdG8gbWFrZSBzb21l
IGZ1cnRoZXINCj4+IGJhc2lzIGZvciBQQ0kgcGFzc3Rocm91Z2ggb24gQXJtIHN1cHBvcnQuIFRo
ZSBzZXJpZXMgY29udGludWVzIHRoZSB3b3JrDQo+PiBwdWJsaXNoZWQgZWFybGllciBieSBBcm0g
WzFdIGFuZCBhZGRzIG5ldyBoZWxwZXJzIGFuZCBjbGVhcnMgdGhlIHdheSBmb3INCj4+IHZQQ0kg
Y2hhbmdlcyB3aGljaCB3aWxsIGZvbGxvdy4NCj4+DQo+PiBSRkMgaXMgYXQgWzJdLCBbM10uIERl
c2lnbiBwcmVzZW50YXRpb24gY2FuIGJlIGZvdW5kIGF0IFs0XS5IaQ0KPj4NCj4+IEkgaGF2ZSBy
ZW1vdmVkIHBhdGNoDQo+PiBbUEFUQ0ggdjYgNS83XSB4ZW4vYXJtOiBkbyBub3QgbWFwIElSUXMg
YW5kIG1lbW9yeSBmb3IgZGlzYWJsZWQgZGV2aWNlcw0KPj4gYXMgaXQgc2VlbXMgdGhhdCB0aGlz
IG5lZWRzIG1vcmUgdGltZSBmb3IgZGVjaXNpb24gb24gaG93IHRvIGFjaGl2ZQ0KPj4gdGhhdC4N
Cj4+DQo+PiBJIGhhdmUgYWxzbyBhZGRlZCBhIG5ldyBwYXRjaA0KPj4gW1BBVENIIHY3IDQvN10g
eGVuL2FybTogYWNjb3VudCBJTyBoYW5kbGVyIGZvciBlbXVsYXRlZCBQQ0kgaG9zdCBicmlkZ2UN
Cj4+IHdpdGggYSB0aW55IGxhdGVudCBidWcgZml4Lg0KPj4NCj4+IFRoaXMgc2VyaWVzIGNvbnRh
aW5zIGFsbCB0aGUgcGF0Y2hlcyB3aGljaCBhcmUgbGVmdCB1bi1jb21taXR0ZWQgeWV0Lg0KPj4N
Cj4+IFRoYW5rIHlvdSwNCj4+IE9sZWtzYW5kcg0KPj4NCj4+IFsxXSBodHRwczovL3VybGRlZmVu
c2UuY29tL3YzL19faHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L3hlbi1kZXZl
bC9saXN0Lz9zZXJpZXM9NTU4NjgxX187ISFHRl8yOWRiY1FJVUJQQSFncXo1ZTNkTC02VXJzY0pz
NlpvcktnRE9NcFlzZmlQTkZuMGZmb3J0S3JjR0JraWw5U01LamJEY1g3Vl9UOVJWSURfdnJVMWlV
QSQgW3BhdGNod29ya1suXWtlcm5lbFsuXW9yZ10NCj4+IFsyXSBodHRwczovL3VybGRlZmVuc2Uu
Y29tL3YzL19faHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9odG1sL3hlbi1k
ZXZlbC8yMDIwLTA3L21zZzAxMTg0Lmh0bWxfXzshIUdGXzI5ZGJjUUlVQlBBIWdxejVlM2RMLTZV
cnNjSnM2Wm9yS2dET01wWXNmaVBORm4wZmZvcnRLcmNHQmtpbDlTTUtqYkRjWDdWX1Q5UlZJRC1H
QVl2MjlRJCBbbGlzdHNbLl14ZW5wcm9qZWN0Wy5db3JnXQ0KPj4gWzNdIGh0dHBzOi8vdXJsZGVm
ZW5zZS5jb20vdjMvX19odHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwv
eGVuLWRldmVsLzIwMjAtMDcvdGhyZWFkcy5odG1sKjAxMTg0X187SXchIUdGXzI5ZGJjUUlVQlBB
IWdxejVlM2RMLTZVcnNjSnM2Wm9yS2dET01wWXNmaVBORm4wZmZvcnRLcmNHQmtpbDlTTUtqYkRj
WDdWX1Q5UlZJRF9QV2staFJBJCBbbGlzdHNbLl14ZW5wcm9qZWN0Wy5db3JnXQ0KPj4gWzRdIGh0
dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL3N0YXRpYy5zY2hlZC5jb20vaG9zdGVk
X2ZpbGVzL3hlbjIwMjEvZTQvUENJX0RldmljZV9QYXNzdGhyb3VnaF9Pbl9Bcm0ucGRmX187ISFH
Rl8yOWRiY1FJVUJQQSFncXo1ZTNkTC02VXJzY0pzNlpvcktnRE9NcFlzZmlQTkZuMGZmb3J0S3Jj
R0JraWw5U01LamJEY1g3Vl9UOVJWSUQ5U3poSzRidyQgW3N0YXRpY1suXXNjaGVkWy5dY29tXQ0K
Pj4NCj4+IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvICg0KToNCj4+IMKgwqAgeGVuL2FybTogYWRk
IHBjaS1kb21haW4gZm9yIGRpc2FibGVkIGRldmljZXMNCj4+IMKgwqAgeGVuL2FybTogc2V0dXAg
TU1JTyByYW5nZSB0cmFwIGhhbmRsZXJzIGZvciBoYXJkd2FyZSBkb21haW4NCj4+IMKgwqAgeGVu
L2FybTogYWNjb3VudCBJTyBoYW5kbGVyIGZvciBlbXVsYXRlZCBQQ0kgaG9zdCBicmlkZ2UNCj4+
IMKgwqAgeGVuL2FybTogZG8gbm90IG1hcCBQQ0kgRUNBTSBhbmQgTU1JTyBzcGFjZSB0byBEb21h
aW4tMCdzIHAybQ0KPj4NCj4+IMKgIHhlbi9hcmNoL2FybS9kb21haW4uY8KgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIHzCoMKgIDIgKw0KPj4gwqAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5j
wqDCoMKgwqDCoMKgwqAgfCAxMzIgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0NCj4+IMKg
IHhlbi9hcmNoL2FybS9wY2kvZWNhbS5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqAgMTQgKysr
DQo+PiDCoCB4ZW4vYXJjaC9hcm0vcGNpL3BjaS1ob3N0LWNvbW1vbi5jIHzCoCA3NyArKysrKysr
KysrKysrKysrLQ0KPj4gwqAgeGVuL2FyY2gvYXJtL3BjaS9wY2ktaG9zdC16eW5xbXAuYyB8wqDC
oCAxICsNCj4+IMKgIHhlbi9hcmNoL2FybS92cGNpLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgfMKgIDg1ICsrKysrKysrKysrKysrKystLS0NCj4+IMKgIHhlbi9hcmNoL2FybS92cGNp
LmjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfMKgwqAgNiArKw0KPj4gwqAgeGVuL2lu
Y2x1ZGUvYXNtLWFybS9wY2kuaMKgwqDCoMKgwqDCoMKgwqDCoCB8wqAgMjIgKysrKysNCj4+IMKg
IHhlbi9pbmNsdWRlL2FzbS1hcm0vc2V0dXAuaMKgwqDCoMKgwqDCoMKgIHzCoCAxMyArKysNCj4N
Cj4gQXMgYSBGWUksIEphbiBwdXNoZWQgdG9kYXkgYSBjb21taXQgdGhhdCBtb3ZlZCB0aGUgaGVh
ZGVycyBmcm9tIHhlbi9pbmNsdWRlL2FzbS1hcm0gdG8geGVuL2FyY2gvYXJtL2luY2x1ZGUvYXNt
Ly4NCj4NCj4gSSBoYXZlIGhhbmRsZWQgdGhlIGNsYXNoIGZvciB0aGlzIHNlcmllcyB3aGlsZSBj
b21taXR0aW5nLg0KVGhhbmsgeW91IGZvciBkb2luZyB0aGF0IQ0KPg0KPiBUaGFuayB5b3UgZm9y
IHRoZSBjb250cmlidXRpb24uDQpUaGFuayB5b3UgYWxsIGZvciBzdXBwb3J0aW5nIHRoaXMgd29y
ayENCk9sZWtzYW5kcg0KPg0KPiBDaGVlcnMsDQo+DQo=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 18:09:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 18:09:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247529.426826 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYia-0004c8-3v; Wed, 15 Dec 2021 18:09:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247529.426826; Wed, 15 Dec 2021 18:09:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYiZ-0004c1-Vg; Wed, 15 Dec 2021 18:09:31 +0000
Received: by outflank-mailman (input) for mailman id 247529;
 Wed, 15 Dec 2021 18:09:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=iCU/=RA=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mxYiY-0004bv-Ht
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 18:09:30 +0000
Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 231c3e41-5dd2-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 19:09:27 +0100 (CET)
Received: from fllv0034.itg.ti.com ([10.64.40.246])
 by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BFI88bl043534;
 Wed, 15 Dec 2021 12:08:08 -0600
Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38])
 by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BFI88vw126883
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Wed, 15 Dec 2021 12:08:08 -0600
Received: from DLEE108.ent.ti.com (157.170.170.38) by DLEE108.ent.ti.com
 (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 15
 Dec 2021 12:08:08 -0600
Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE108.ent.ti.com
 (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Wed, 15 Dec 2021 12:08:08 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BFI88Qh046197;
 Wed, 15 Dec 2021 12:08:08 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 231c3e41-5dd2-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639591688;
	bh=BV8tFNoGMdbcKerU49fpsuE5DGB0rVHqEXWJvvEf+r4=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=ZwqpP5UcZ1QWZv7AGAa1OzwwMFuadbbEsAGtDSo4cB6se3FtCbc4klSGqC2fqQUFh
	 7fdnNyE4equbUr+rG0skddv/tns2YRzZhL47ljnzM9aYF4NAG10iKPsf5O271LpT8+
	 rYNDI3ur5+NLeKk/dEPjErvLTfSPXspbsCCTNhzw=
Date: Wed, 15 Dec 2021 12:08:08 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Juergen Gross
	<jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann
	<arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin
 Herrenschmidt <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, Mark Rutland
	<mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>, <linux-wireless@vger.kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Message-ID: <20211215180808.dpdlkoheulsnrs65@balcony>
References: <20211213182958.ytj4m6gsg35u77cv@detonator>
 <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider>
 <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx>
 <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly>
 <87h7basx36.ffs@tglx>
 <87zgp1rge4.ffs@tglx>
 <87wnk5rfkt.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87wnk5rfkt.ffs@tglx>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

On 17:35-20211215, Thomas Gleixner wrote:
>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.1-part-2
[...]

> That should cure the problem.

And it sure does. Thanks for looking closer and providing a fix.

https://gist.github.com/nmenon/9862a1c31b17fd6dfe0a30c54d396187
(msi-v4.1-part-2) looks clean

Also while I had detected pointer corruption in the previous v4
https://gist.github.com/nmenon/ce4d12f460db5cd511185c047d5d35d0

Running it again on v4.1 does indicate the fix is in place.
https://gist.github.com/nmenon/3231fbb0faa1b9c827b40d1ae6160626


please feel free to add:

Tested-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 18:20:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 18:20:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247534.426836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYst-0006xB-2U; Wed, 15 Dec 2021 18:20:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247534.426836; Wed, 15 Dec 2021 18:20:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYss-0006x4-Vh; Wed, 15 Dec 2021 18:20:10 +0000
Received: by outflank-mailman (input) for mailman id 247534;
 Wed, 15 Dec 2021 18:20:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxYsr-0006wy-VP
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 18:20:09 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYsp-0001Rb-2g; Wed, 15 Dec 2021 18:20:07 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYso-0002qF-T2; Wed, 15 Dec 2021 18:20:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xLie/Mw7cBNpOtimSu1MzWXhmLpKaFsDMG2FMwhsBgU=; b=P9AudKy20WbvQbQkRliH983+20
	AnAZyxCcwsLeotn6MP8lZBmfasx5qfO0NeqRCd7Q1jkAo4JDItTanEL8D9o6pr6+rdSrXNLVqKN4x
	13bafwS1Dyn5hev3PJdN52qJuDGHeWUqh9pQ3nJ8xMDaaApNwRmFpszK9chClGcu+6Qc=;
Message-ID: <917e0157-11f4-acf5-05cd-920cbc8e6399@xen.org>
Date: Wed, 15 Dec 2021 18:20:04 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 15/12/2021 09:35, Jan Beulich wrote:
>> 1. Regarding save_x0_x1, it is 0 only for guest_sync_slowpath, which is called by guest_sync.
>> So as we are dealing only with compat=1, save_x0_x1 cannot be 0.
>> The conclusion is that we do not need to worry about it.
> 
> Oh, good point. I guess you may want to add a build time check to
> avoid silently introducing a user of the macro violating that
> assumption.

+1

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 18:25:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 18:25:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247539.426848 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYyE-0007c2-MW; Wed, 15 Dec 2021 18:25:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247539.426848; Wed, 15 Dec 2021 18:25:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxYyE-0007bv-Ja; Wed, 15 Dec 2021 18:25:42 +0000
Received: by outflank-mailman (input) for mailman id 247539;
 Wed, 15 Dec 2021 18:25:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxYyD-0007bp-AF
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 18:25:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYyA-0001X8-NS; Wed, 15 Dec 2021 18:25:38 +0000
Received: from [54.239.6.190] (helo=[10.85.97.145])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxYyA-0003HU-H6; Wed, 15 Dec 2021 18:25:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=S5tQfAIKkuATzyaKtKEK1++P0nF1HSnJSfdCOM/Va7k=; b=KVhS9/l//JSXxFIcHZM0JwV+IS
	D0CoaB/9ULEd+MsrsYdyRhAu4u2D0jqS+kRGZgTLrLLD20sn0mTNuPSF7Ea6EBfWXFIWBw62JHDZ6
	wnHHOtHlxHrrlL84Z3tiEWnkgaibQTsUDE9VVazVBt0mP198OYb31kHItRhczHBY9RWQ=;
Message-ID: <4b6c1865-5ded-fe6d-aead-bcd2e5cd4125@xen.org>
Date: Wed, 15 Dec 2021 18:25:36 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
 <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
 <6e54f971-84c3-3635-12c8-643b619b2b53@suse.com>
 <219d27fe-4e77-59f5-b559-4bc70c2a0399@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <219d27fe-4e77-59f5-b559-4bc70c2a0399@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Michal,

On 15/12/2021 10:40, Michal Orzel wrote:
> On 15.12.2021 11:32, Jan Beulich wrote:
>> (Re-sending an abridged version, as apparently spam filters didn't like
>> the original message with more retained context; I'll have to see whether
>> this one also isn't liked. Sorry.)
>>
>> On 15.12.2021 10:48, Michal Orzel wrote:
>>> This patch and the problem it solves is about clearing top 32bits of all gp registers so not only x0,x1.
>>
>> That's well understood. Yet for everything still in registers simply
>> using mov ahead of the respective push (as you had it) is still
>> preferable imo.
>>
>> Jan
>>
> 
> In that case let's wait for Julien's opinion to decide whether I should get back to the previous
> solution with mov or to the stack solution.

IIUC, your proposal is to:
    1) Push all the 64-bit registers
    2) Zero the top 32-bit

Jan's suggestion is to:
    1) clobber the top 32-bit using mov wX, wX
    2) Push all the registers

My preference is for the latter because there will be less memory/cache 
access.

So, this would be your original patch + a compile time check to ensure 
save_x0_x1 is 0 when compat=1.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 18:43:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 18:43:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247545.426859 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxZEn-0001oR-7j; Wed, 15 Dec 2021 18:42:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247545.426859; Wed, 15 Dec 2021 18:42:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxZEn-0001oK-4E; Wed, 15 Dec 2021 18:42:49 +0000
Received: by outflank-mailman (input) for mailman id 247545;
 Wed, 15 Dec 2021 18:42:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxZEm-0001oA-4F; Wed, 15 Dec 2021 18:42:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxZEl-0001qW-Jv; Wed, 15 Dec 2021 18:42:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxZEl-0000Gg-9m; Wed, 15 Dec 2021 18:42:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxZEl-0003SP-9K; Wed, 15 Dec 2021 18:42:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tw/iS2Su1/CEjhCa9HxETXNxd6QOgoVMixmDvuYdkcQ=; b=Eu7yPScjaZXukdFW7XmaCT+Va5
	58MFyWSpiv3IZCD7qk9RYOwFJTz/oQVtBf1sSPrC4sh56VrsVP9IBA5Xh50aHkPtZIhxOz5PfdwjN
	28d57AylXiCQ0AAm1KbjyO+yOPMbW/NJt7cBW2ZtlCr/TJ1GnNbRg//OkDSaKF19BjHk=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167435-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167435: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8b3cbdbe782cae972e9a47cf22620ebee61a96a6
X-Osstest-Versions-That:
    xen=9956fdc70f99b0f133be7f16f62417928a84622c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 18:42:47 +0000

flight 167435 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167435/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8b3cbdbe782cae972e9a47cf22620ebee61a96a6
baseline version:
 xen                  9956fdc70f99b0f133be7f16f62417928a84622c

Last test of basis   167429  2021-12-15 10:02:58 Z    0 days
Testing same since   167435  2021-12-15 15:03:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Julien Grall <jgrall@amazon.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   9956fdc70f..8b3cbdbe78  8b3cbdbe782cae972e9a47cf22620ebee61a96a6 -> smoke


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 20:09:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 20:09:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247551.426873 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxaZt-0002Mn-MR; Wed, 15 Dec 2021 20:08:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247551.426873; Wed, 15 Dec 2021 20:08:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxaZt-0002Mg-Iz; Wed, 15 Dec 2021 20:08:41 +0000
Received: by outflank-mailman (input) for mailman id 247551;
 Wed, 15 Dec 2021 20:08:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RPoj=RA=epam.com=prvs=29839f4640=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mxaZr-0002Ma-Vo
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 20:08:40 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c97ac6ee-5de2-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 21:08:37 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BFJNtCB004716;
 Wed, 15 Dec 2021 20:08:34 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3cypfsg46w-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 15 Dec 2021 20:08:34 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6896.eurprd03.prod.outlook.com (2603:10a6:102:f0::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Wed, 15 Dec
 2021 20:08:25 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Wed, 15 Dec 2021
 20:08:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c97ac6ee-5de2-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Dq1Uv6HeBGuw3xvyHr3GWhD313wrdozu8dNIPiGMqzEhl5CKcw6Ux/RJ84rUtHhadAUHgUaxQYqilZ8LUf9lbtkRiUM1AC+tWz3hHkxnqely/Myy+OXvoCck8IQsPTBEgcHGfoCVoXaeRQZEXGMniXPUmEaB1xsxnZg9guKugKH3MP333rT0lrpCBxlIbkGc8IU3yONaEdQxEbsXvAP/bx1egwB0aoHto7Y1R07bYCw7WIHnWp2bx4GfFyTDVssKK/aT2lLKiPm0F/QEdu0JCN+oq7hyYlIxavZ8C+Rc4EfgokLxS6hTglaGhb6iGleWhRjxPPXOjBBCwREvI2GnAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=i9gLp6jqYVwp/qjEnQqTuO2dPYJAqmREZ989xP/LZNM=;
 b=YvC4tI/bYnoXZ9tLu5+leD/5+xfVY7gxnXLzFG2e3zxaY3YRc/ayFyq8HJxHO6duXByhPGY/oezySVT57cMp2t6610QNkv5qItSwovO4bDFmfEYP3g88n+h3d3DLvi+XO6zI00ywO0WLM62bLX7Si47Wgm+gtiHVdw73mexuH9gY5IF1aOBk9+tD99fb23ZdQrNPDuezglgiG+/d/0MPeeZvXX7NbL8QUcKhbIlHIGchX4xKjOEpYpVHgGDCKXrQUX/DZfKjJhr8yKw/b/hNPOB377ZRv3l7wiNp3n1nsMh2VW/kV+ipVoCiggHOiRkHPZveE3k+1Oc614EAPMulTA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=i9gLp6jqYVwp/qjEnQqTuO2dPYJAqmREZ989xP/LZNM=;
 b=CLoNtUzSvZVt5gd1MCZiIH96KvF1M+ckl6/Wdz4T7s0hEtSan5Lf4j01TMTYhMUKu4Vun2JJbNCH1vwOvn7v763sXFeYBN3395Y31SAYRPd3CdqshyvpIjDHcBKfVFz3H8puGTREkj/Sv6fJiPMXj6PdFrdhEN81T441VBYxMCGqn4NKEAjbqehzHMuq6qb0TNYO02V1mZYWeHvtmSqE1Ki02rYVYO1kwlA6n1FXijlJCl1gnXrOzCVETDF0rygk4oeWFPESqgpZ+GtTC2mDrnbFwPn6K9H1UtDLivxZeZvg2nIe8aMtcVWovzMrcu8zCwzvRY6/sf+ii/GGUX4vOw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
Thread-Topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3
 platform
Thread-Index: AQHX8M3HLq8qFfw2eU2jxqbriRiMpawzGv8AgADibAA=
Date: Wed, 15 Dec 2021 20:08:24 +0000
Message-ID: <20211215200824.GA2923921@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
 <e6087283-063f-bd4b-060b-e366c30add64@epam.com>
In-Reply-To: <e6087283-063f-bd4b-060b-e366c30add64@epam.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cabb48a9-b764-4ae2-b786-08d9c006a6a7
x-ms-traffictypediagnostic: PA4PR03MB6896:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB6896CF8F55F9E30A9FD59403E3769@PA4PR03MB6896.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 06GXjNDDD5vU3GrxTFmFIkJ1pyJwOAQL+0T0bZbaQmXal3r64mAItllHRx4zYYyMphI2tc48IDuLElLyriWvWqQ1G08eNUXC1TfPKC2Nd5B43n/vD5r1kVNlD3T5u+CkenZMDEiF939kDo6Wk6IleZLlSETQCGt+CqSEg6t7aWWUtlguvm7x0BPg5D87JmoH16YxPlz5dFdQRzQwMxMmdTVB7HIfMXUd1c3YZJKBl7jaOVMCKkTV5I7hbzoMzpFBIGjU4Y+nZ6t9wr6XBpTqpA8ZGxAG93dz7zDbbzFmINACVrMeu6HgrbkR9De+W+ZW8AwxdPhec9rRNZPI82r3JNjfC17/xDSaRORoUGBbsiJQIzHbg/jtomEyqzv2w1+t0ga/zXDEWskJbNMDDsi1nz3R/VlWj0HxPtANYsJMpxwZW6RWwCaTs7Ldn/S90m/3ejLZiZEcgx50mD0H2ShZjRozrpHz9HM0VLJ6YFUQ2T8HIdWR47kN1I9VLvIKdBbPGeW5WkluzjYQuHp+DmUbNtD5L58T2x7LZCKogXtJ6er19BtfoFHNCiyxI7Mxt7c4fW+N6e5reN2+Q6uvGxMAzWIz4XU4fznUSD3lNDW5weyL1AraGZMoRQquz7yEqgqmD/Mem+8jM5AmG3TZVkdLQBfvrQ3+6D+T0datwyCBdkRp5ZdLZ14y+czUIColxpTzMVhguPD8QLZlEW91jpiDwZoWlz+Lbnyu0zA5xZV7TRo=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(86362001)(122000001)(38070700005)(316002)(5660300002)(6862004)(66556008)(9686003)(64756008)(1076003)(38100700002)(53546011)(508600001)(6512007)(91956017)(8936002)(6636002)(33716001)(33656002)(66946007)(76116006)(54906003)(4326008)(6506007)(66476007)(71200400001)(66446008)(8676002)(2906002)(26005)(6486002)(186003)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?d2bStpfh7eBQwly2Mmo4UcyOt3eXCetD85fcf3AgHux93auj58NtKwn5Zdci?=
 =?us-ascii?Q?IUmaFzFwurD/Caa4ClE7cgCDVusvSXaJrqHXz8k5D2FB48cfED8ZQzRfn076?=
 =?us-ascii?Q?L1qzpynG9GNej2HqZl1MkBjsnIPwnbM7h/sHIeMxjN0Zz6dn6ZZ+AKinhIZ9?=
 =?us-ascii?Q?RuWoP0X1169eSroXJW3H0h2SDn/GKlVHkwVZ4/xlS+pSIxOWW1RGh/gUiPbO?=
 =?us-ascii?Q?FA0qGQl7yyHuQE+XVLWRfqAiZvTd6+JeLJsCamVjkOs00eBwciuV8+JkQy9F?=
 =?us-ascii?Q?C265IpY4lfUFZp707iVugyA1dXB7xqntbAfKynKZE0HZ0HAoSsKIEkZ5H8Nf?=
 =?us-ascii?Q?sb+xIIqjgOg4weBvUOBaM9WNhQ7lI9NtXImHmj0eNT7U8DLQP9Vmp9JKL+rX?=
 =?us-ascii?Q?9w2cr4/e1htIUyGV7rCtoGS/c0oMop4Ggcc6NP3Is8+Wn0IBL/G+SJqzu9t5?=
 =?us-ascii?Q?FOdvEgTYW5T9KHFLYJKf/YOXVXcXaht6f8ElCAfvaPZQqGIX6ZfhtDeLg0wN?=
 =?us-ascii?Q?sts3IuBBXsYRQXvkE7QkiAgv8tM4Ux7LJP0fkymTpJgzqI56TuO1CRGaKJOb?=
 =?us-ascii?Q?B5RJrFxD7Glv7lfj43RhYi91lTT34xUXoREFZfWBkiPH09ZmAEIFlejUKzTV?=
 =?us-ascii?Q?sksE7+4J2W7cIVHuIlv7ZvaTuA8aMIyZAcbYf8vYtmWdVeqieO4NtduPvuAW?=
 =?us-ascii?Q?zgBT+c7Npwk6rtq+jdF8QpGGm9G8sjHxVeKi3b9MnIwCuSRHL/JbYP9uQm6p?=
 =?us-ascii?Q?KVsTlGqOmhgCQoNZbk6wQDambvxJ9cTwGqmbiltgaQ0HHf9bjNSEGR4I2ghP?=
 =?us-ascii?Q?IfvqRImtA4R8yOm6jFY4btcGWSXHSZ1NJiNvPr0hc8PLkkNgz0UGPGKsvn1x?=
 =?us-ascii?Q?tBJtwDyS40GUfXK1SSUWYll6zMX6A5MOt14PLWR6qL5Bt+IBUJayHKogdRwy?=
 =?us-ascii?Q?B2zhQA4UM8XTe6cBQubfK+FLNghi28Bk5oE9km/Jh/gnSX6prlL7JaLIryQM?=
 =?us-ascii?Q?1vHt7ZBkdDL9/Fac8mVRrSye5B9Vbkvn2cp75Tn457facHuyRm57RikgKGVT?=
 =?us-ascii?Q?5V8TDCVZVqlbRUS52mrIqqd/dZauGvk8l8n7+c8NQiC1jMFyQaUgNX/MMM1B?=
 =?us-ascii?Q?ksLrt+SCYSi1Za4Ru11JDIbKchWtvWlASxbBjmwUk80KIs4Fx+vGKN9rXjTE?=
 =?us-ascii?Q?l/z8M6HBNFfQQtDMCRoaLMMUXPhUBBaCBNcw09BRE27ZPDFypNqHS0zAeh4c?=
 =?us-ascii?Q?aDRR+oBCv0HsaMw74b8tdeYxjD9MwpQnsbCnUpTFQ6jvnJs5KLe0nBXsXYab?=
 =?us-ascii?Q?NEyH47U/1ei4cnxlrCxilYReXPLIxICmov2xHrbel0CCOf4yvxf/J6cUa1wP?=
 =?us-ascii?Q?C9FNIxV+127hrAnWsz6/SWwkIdnxZzv+CG7slTT2dxexOMLXiwZzngQ8zzor?=
 =?us-ascii?Q?Cj7Mvy3SXzQzTgWnnvesd5kqEKSBS11UxpLGfoWIrGmlAMP/FAUDAgL1NS8h?=
 =?us-ascii?Q?ajIPWZhNe9Byf31T1uwN7l6HnJ8L4dBaI7BVzfiJK26SevfvNhsDDFmyA/9B?=
 =?us-ascii?Q?C1Vhgqk1dMpHKcosaGB0o/ckDqbgHSpfMNLKIXkk4pjy0cbbBSAyu6z8KlTO?=
 =?us-ascii?Q?us24r/DK/mLBhEa62r1QxSDKJZjY3GxYR0TO6a9MkD577UBJC22KUkKdghuT?=
 =?us-ascii?Q?ApXRQygWsaDKLapRHAy7Hr+USCs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21BCBA49A57A6943B913A04035FEC0A7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cabb48a9-b764-4ae2-b786-08d9c006a6a7
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 20:08:24.6888
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ODm0WS/s4XmiLQyXdKIynyiOx1B8tS2s4O5ljp6CqlIEgGXmf/dk+OMX/kX+Na8vQusXly9pRiFjpDVsSM4x8JnrD4jQqZN0flYTUq0gnZs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6896
X-Proofpoint-ORIG-GUID: gPr90shcKY3nj3efbwFEzNUKrKhZeJaH
X-Proofpoint-GUID: gPr90shcKY3nj3efbwFEzNUKrKhZeJaH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-15_12,2021-12-14_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0
 priorityscore=1501 mlxscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0
 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112150112

Hi Oleksandr,

Thank you for the point.
I will add it to the next patch version.

Best regards,
Oleksii=20

On Wed, Dec 15, 2021 at 06:38:00AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Oleksii!
>=20
> On 14.12.21 11:34, Oleksii Moisieiev wrote:
> > Implementation includes platform-specific smc handler for rcar3 platfor=
m.
> >
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>=20
> > ---
> >   xen/arch/arm/platforms/Makefile |  1 +
> >   xen/arch/arm/platforms/rcar3.c  | 46 ++++++++++++++++++++++++++++++++=
+
> >   2 files changed, 47 insertions(+)
> >   create mode 100644 xen/arch/arm/platforms/rcar3.c
> >
> > diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/M=
akefile
> > index 8632f4115f..b64c25de6c 100644
> > --- a/xen/arch/arm/platforms/Makefile
> > +++ b/xen/arch/arm/platforms/Makefile
> > @@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) +=3D exynos5.o
> >   obj-$(CONFIG_ALL32_PLAT) +=3D midway.o
> >   obj-$(CONFIG_ALL32_PLAT) +=3D omap5.o
> >   obj-$(CONFIG_ALL32_PLAT) +=3D rcar2.o
> > +obj-$(CONFIG_RCAR3) +=3D rcar3.o
> >   obj-$(CONFIG_ALL64_PLAT) +=3D seattle.o
> >   obj-$(CONFIG_ALL_PLAT)   +=3D sunxi.o
> >   obj-$(CONFIG_ALL64_PLAT) +=3D thunderx.o
> > diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rc=
ar3.c
> > new file mode 100644
> > index 0000000000..d740145c71
> > --- /dev/null
> > +++ b/xen/arch/arm/platforms/rcar3.c
> > @@ -0,0 +1,46 @@
> > +/*
> > + * xen/arch/arm/platforms/rcar3.c
> > + *
> > + * Renesas R-Car Gen3 specific settings
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021 EPAM Systems
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <asm/platform.h>
> > +
> > +static bool rcar3_smc(struct cpu_user_regs *regs)
> > +{
> > +    return false;
> > +}
> > +
> > +static const char *const rcar3_dt_compat[] __initconst =3D
> > +{
> > +    "renesas,r8a7795",
> > +    "renesas,r8a7796",
> > +    NULL
> > +};
> > +
> > +PLATFORM_START(rcar3, "Renesas R-Car Gen3")
> > +    .compatible =3D rcar3_dt_compat,
> > +    .smc =3D rcar3_smc
> > +PLATFORM_END
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */=


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 20:51:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 20:51:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247573.426902 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbEt-0000YN-8R; Wed, 15 Dec 2021 20:51:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247573.426902; Wed, 15 Dec 2021 20:51:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbEt-0000YG-5J; Wed, 15 Dec 2021 20:51:03 +0000
Received: by outflank-mailman (input) for mailman id 247573;
 Wed, 15 Dec 2021 20:51:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EjzN=RA=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxbEs-0000Y6-0Z
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 20:51:02 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b5b10ffa-5de8-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 21:51:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b5b10ffa-5de8-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639601459;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=77DCNiXl9B9x9ao8a3ckFicR+A7/8jsezE822YCoYkI=;
	b=0MC08SjOyHUSb632XivZnR6xp+J+lhdSt8dO4cVV21Usd+LFkCWMDMI5c2zqdprtPX8VcT
	Z63tf+3EiGKcUHte1/483d4Z/hf6cKDNCZfSHwK0n7HeyH7/U5ccqzZJxTdJSRVkjhfdtR
	IiH4xihB3g4E9MBjV2NktVFtgbdOo75IOpoHPIb3/7VdumCnWORcJgrzfHtGplNM5fxLCo
	lWD8Oek/DpAbTtzS5eZ0f2xj6cql1OA57lGXY/RPOvZpVY8gxierMi9GKVnemFayVy076Y
	M6+9Lfqa20tO87mNob/FrOG2y8clrn6urg7hwKRz/nQ9j3qTabd4wVqNL/bu2w==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639601459;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=77DCNiXl9B9x9ao8a3ckFicR+A7/8jsezE822YCoYkI=;
	b=SDPAxqej8tM3beNMTA3MRfQgMQzvFbRgGCzPLoilB6fEB/QgGtIDQRto0CY8QP/ghtYPeu
	cjbHVwPoa9R9VUCQ==
To: LKML <linux-kernel@vger.kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>, Marc Zygnier <maz@kernel.org>, Alex
 Williamson <alex.williamson@redhat.com>, Kevin Tian
 <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha Dey
 <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
 linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
 xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Niklas Schnelle
 <schnelle@linux.ibm.com>, linux-s390@vger.kernel.org, Heiko Carstens
 <hca@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Logan
 Gunthorpe <logang@deltatee.com>, Jon Mason <jdmason@kudzu.us>, Dave Jiang
 <dave.jiang@intel.com>, Allen Hubbe <allenbh@gmail.com>,
 linux-ntb@googlegroups.com, Nishanth Menon <nm@ti.com>
Subject: Re: [patch V2 21/31] soc: ti: ti_sci_inta_msi: Rework MSI
 descriptor allocation
In-Reply-To: <20211206210748.737904583@linutronix.de>
References: <20211206210600.123171746@linutronix.de>
 <20211206210748.737904583@linutronix.de>
Date: Wed, 15 Dec 2021 21:50:58 +0100
Message-ID: <87a6h1r3rh.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Dec 06 2021 at 23:51, Thomas Gleixner wrote:
>
> No functional change intended.

Famous last words.

>  static int ti_sci_inta_msi_alloc_descs(struct device *dev,
>  				       struct ti_sci_resource *res)
>  {
> -	struct msi_desc *msi_desc;
> +	struct msi_desc msi_desc;
>  	int set, i, count = 0;
>  
> +	memset(&msi_desc, 0, sizeof(msi_desc));

This fails to initialize msi_desc.nvec_used which makes the subsequent
interrupt allocation fail. Delta fix below.

Thanks,

        tglx
---
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -68,6 +68,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 	int set, i, count = 0;
 
 	memset(&msi_desc, 0, sizeof(msi_desc));
+	msi_desc.nvec_used = 1;
 
 	for (set = 0; set < res->sets; set++) {
 		for (i = 0; i < res->desc[set].num; i++, count++) {


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 21:33:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 21:33:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247582.426913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbtL-0005SJ-IL; Wed, 15 Dec 2021 21:32:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247582.426913; Wed, 15 Dec 2021 21:32:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbtL-0005SC-FD; Wed, 15 Dec 2021 21:32:51 +0000
Received: by outflank-mailman (input) for mailman id 247582;
 Wed, 15 Dec 2021 21:32:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxbtJ-0005S2-Jd; Wed, 15 Dec 2021 21:32:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxbtJ-0004lo-1p; Wed, 15 Dec 2021 21:32:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxbtI-0001le-NE; Wed, 15 Dec 2021 21:32:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxbtI-0001FR-Mm; Wed, 15 Dec 2021 21:32:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=AzjIkAkd9VklK4C8YB30U/jFy56PIQrQeOS6u8ciamI=; b=raM70szTcXAoUipIHEH4iojfze
	ykJGvyLh8jzabquBQaDiqFZaLRztLFvZ5AuU2jZ5v6Kjhde34dl1+Q6rOkR66eSdC5dPNw0whQoIf
	POEWQusrkzPfuVMLIG2YO3g7HP1uESnRTwshtm5hSL93hYY22NzdDbB2gCbaEEi1zkuo=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167423-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167423: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=7826148a72c97367fc6aaa76397fe92d32169723
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 21:32:48 +0000

flight 167423 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167423/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              7826148a72c97367fc6aaa76397fe92d32169723
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  523 days
Failing since        151818  2020-07-11 04:18:52 Z  522 days  504 attempts
Testing same since   167423  2021-12-15 04:20:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 89269 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 21:36:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 21:36:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247588.426926 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbx9-00064l-4J; Wed, 15 Dec 2021 21:36:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247588.426926; Wed, 15 Dec 2021 21:36:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxbx9-00064e-1J; Wed, 15 Dec 2021 21:36:47 +0000
Received: by outflank-mailman (input) for mailman id 247588;
 Wed, 15 Dec 2021 21:36:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxbx7-00064Y-Uq
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 21:36:46 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1925007f-5def-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 22:36:44 +0100 (CET)
Received: by mail-lj1-x22b.google.com with SMTP id 207so35327198ljf.10
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 13:36:44 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id m15sm506367lfp.9.2021.12.15.13.36.42
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 13:36:43 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1925007f-5def-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=uvAYJJO/yaMsslbNsLas3eYctpidKRGYCe1+j8gscng=;
        b=nlQGk6jukmLPrNG4Bh7ktrtG5gbmVo758Nyy6zSGUsiLIImLyTFqddACKdm/7tSHBs
         41tbLt+BGSUdR38UBThvdhjzl4lf/wQmy2i8AHb6xFpEc6th1wryxyo8mSGJteiVuEeB
         OpITSmXI2PI6kuoRnoKZnRTWA2yNIyvS+bkM47eLT/AHzXLBA1KotsMKaNkK5Ei/Z6A7
         gr0l7FqwY9SATZ6JoHeLKpr9Cdf0Ske3zQNLrL3Qr3oqOW754kFr/C7PzOI2RYy7qDSK
         +gS1rDwnWS+j1n7c+4x0dDZrl/i6NGDf/gnw3RY65chYjPyaEoh5q/6g55L+XpYF6WEF
         Pg9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=uvAYJJO/yaMsslbNsLas3eYctpidKRGYCe1+j8gscng=;
        b=RT980l+y+PgLE3ZcUXEFYdVl7NGkd9zWSJivHJRqEzDYMX+L+gjLDASMQ8KGuY/2X3
         XoMgbyRHdmQh9F6+O9AK7RsEZ7D9Pm7aTptg+86LdlYVV5dhaCq84d/yQowLCCpLTT2h
         GZK1b1h6X+JTGoZkib2/OtcENdjyZb1hMGZuZh0FO7fBUiTk1JGUM3XR/HtZ3CcpoFZw
         GeuBSnvX8Yx8JenMpasRf1wYjZNqEDtWBntn3CiWnz18t1KFPzN/t13mCmas6Vd9RvRh
         J0p4OkTgBjF2NR0JGJJJQlrAxS9FMA3+cvzomi8ENfO61hMc9aKrsHLJn3rlyKfZq/pj
         g1pA==
X-Gm-Message-State: AOAM5315D8phNdZbG8SpCPA6Rgqhd+8flQVl7Gz33C+LdkrqYrOY21GM
	HSnhB1NFzhkGgJ9NuQ0Xefo=
X-Google-Smtp-Source: ABdhPJx1C/qQ5FxwhxU+sa3wZVtYHVfLUj3iwst6+xkky0xm115khluyv+ccSh2QKazn1OdwbPbVDA==
X-Received: by 2002:a2e:b8d1:: with SMTP id s17mr12077313ljp.446.1639604203715;
        Wed, 15 Dec 2021 13:36:43 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
To: Juergen Gross <jgross@suse.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
Date: Wed, 15 Dec 2021 23:36:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 15.12.21 17:58, Juergen Gross wrote:


Hi Juergen


> On 15.12.21 16:02, Oleksandr wrote:
>>
>> On 15.12.21 08:08, Juergen Gross wrote:
>>
>> Hi Juergen
>>
>>> On 14.12.21 18:44, Oleksandr wrote:
>>>>
>>>> On 14.12.21 18:03, Anthony PERARD wrote:
>>>>
>>>> Hi Anthony
>>>>
>>>>
>>>>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wrote:
>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>
>>>>>> This patch adds basic support for configuring and assisting 
>>>>>> virtio-disk
>>>>>> backend (emualator) which is intended to run out of Qemu and 
>>>>>> could be
>>>>>> run in any domain.
>>>>>> Although the Virtio block device is quite different from traditional
>>>>>> Xen PV block device (vbd) from the toolstack point of view:
>>>>>>   - as the frontend is virtio-blk which is not a Xenbus driver, 
>>>>>> nothing
>>>>>>     written to Xenstore are fetched by the frontend (the vdev is not
>>>>>>     passed to the frontend)
>>>>>>   - the ring-ref/event-channel are not used for the 
>>>>>> backend<->frontend
>>>>>>     communication, the proposed IPC for Virtio is IOREQ/DM
>>>>>> it is still a "block device" and ought to be integrated in existing
>>>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration
>>>>>> logic to deal with Virtio devices as well.
>>>>> How backend are intended to be created? Is there something 
>>>>> listening on
>>>>> xenstore?
>>>>>
>>>>> You mention QEMU as been the backend, do you intend to have QEMU
>>>>> listening on xenstore to create a virtio backend? Or maybe it is 
>>>>> on the
>>>>> command line? There is QMP as well, but it's probably a lot more
>>>>> complicated as I think libxl needs refactoring for that.
>>>>
>>>>
>>>> No, QEMU is not involved there. The backend is a standalone 
>>>> application,
>>>> it is launched from the command line. The backend reads the 
>>>> Xenstore to get
>>>> the configuration and to detect when guest with the frontend is 
>>>> created/destroyed.
>>>
>>> I think this should be reflected somehow in the configuration, as I
>>> expect qemu might gain this functionality in the future.
>>
>> I understand this and agree in general (however I am wondering 
>> whether this can be postponed until it is actually needed), but ...
>
> This might lead to the need to support some "legacy" options in future.
> I think we should at least think whether these scheme will cover (or
> prohibit) extensions which are already on the horizon.

ok


>
>
>>> I'm wondering whether we shouldn't split the backend from the protocol
>>> (or specification?). Something like "protocol=virtio" (default would be
>>> e.g. "xen") and then you could add "backend=external" for your use 
>>> case?
>>
>> ... I am afraid, I didn't get the idea. Are we speaking about the 
>> (new?) disk configuration options
>> here or these are not disk specific things at all and to be 
>> applicable for all possible backends?
>
> I was talking of a general approach using the disk as an example. For
> disks it is just rather obvious.
>
>> If the former, then could the new backendtype simply do the job? For 
>> example, "backendtype=virtio_external" for our current use-case and 
>> "backendtype=virtio_qemu"
>> for the possible future use-cases? Could you please clarify the idea.
>
> I want to avoid overloading the backendtype with information which is
> in general not really related by the backend. You can have a qemu based
> qdisk backend serving a Xen PV-disk (like today) or a virtio disk.
>
> A similar approach has been chosen for the disk format: it is not part
> of the backend, but a parameter of its own. This way e.g. the qdisk
> backend can use the original qdisk format, or the qcow format.
>
> In practice we are having something like the "protocol" already today:
> the disk device name is encoding that ("xvd*" is a Xen PV disk, while
> "sd*" is an emulated SCSI disk, which happens to be presented to the
> guest as "xvd*", too). And this is an additional information not
> related to the backendtype.
>
> So we have basically the following configuration items, which are
> orthogonal to each other (some combinations might not make sense,
> but in theory most would be possible):
>
> 1. protocol: emulated (not PV), Xen (like today), virtio
>
> 2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)
>
> 3. format: raw, qcow, qcow2, vhd, qed
>
> The combination virtio+phy would be equivalent to vhost, BTW. And
> virtio+other might even use vhost-user, depending on the daemon.
yes, BTW the combination virtio+other is close to our use-case.


Thank you for the detailed explanation, now I see your point why using 
backendtype=virtio is not flexible option in the long term
and why we would want/need to an extra configuration option such as 
protocol, etc. I think, it makes sense and would be correct.

If we take a disk as an example, then from the configuration PoV we will 
need to:
- add an optional "protocol" option
- add new backendtype: external/other/daemon/etc.
This seems to cover all possible combinations describe above (although I 
agree that some of them might not make sense). Is my understanding correct?

Unfortunately, disk configuration/management code is spread over 
multiple sources (including auto-generated) in the toolstack which is 
not so easy to follow (at least to me
who is not familiar enough with all this stuff), but anyway may I please 
clarify what is the minimum required amount of things that I need to do 
in order to get this basic virtio-mmio
support series accepted?


>
>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 21:51:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 21:51:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247594.426938 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcAz-0000I3-Fs; Wed, 15 Dec 2021 21:51:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247594.426938; Wed, 15 Dec 2021 21:51:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcAz-0000Hw-Cr; Wed, 15 Dec 2021 21:51:05 +0000
Received: by outflank-mailman (input) for mailman id 247594;
 Wed, 15 Dec 2021 21:51:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=uCzL=RA=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxcAx-0000Hq-Rz
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 21:51:03 +0000
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
 [2a00:1450:4864:20::22a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 18d217e2-5df1-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 22:51:02 +0100 (CET)
Received: by mail-lj1-x22a.google.com with SMTP id v15so35500671ljc.0
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 13:51:02 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id g4sm506559lfv.288.2021.12.15.13.51.01
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 13:51:01 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 18d217e2-5df1-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=8O4J/UkN625MCM8eP8JBhOC2AERJVO0d+hzUxg4cM7A=;
        b=CzHvo9caOUp/6mGaZh7vCACLSHw8VH9F4npPF+D/alP1iugILNStvh1KjX2aRFPFRH
         6mHzqOXWeZXwKZK5zDebytNGmL6RgxS6I4Apdq6d/VNZcAEjhHM//t0QjyP9iyV8qJIk
         A6Pv3FXJ8VHLRLIfcRm0irASt8CiK5CKSYZ660HB78aMIpmBFMqfmMtbfRyj6cEJ8J6r
         k//uwR1d/trO0HOSt3x17ErEOP7zlTpcHonA8QLJe/FlLON/PUyxYt+vQd8TlrYeigmL
         T4EACiCPNazMZX1tCuyLLbRqISEAGI+mmRGP5OrEMtP8tpN79yA+vjj9orztJBTcDO8n
         mDXg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=8O4J/UkN625MCM8eP8JBhOC2AERJVO0d+hzUxg4cM7A=;
        b=r/F4OMuFiSsH1o8aphES32ILha4UUPi1kz9Sq4jIsjY3YrJcMl9eZNUyFJuGE1ncZY
         W3CI4CdHaxVPR9/VbGNLFAWWpNJTBXj2kTP+BneN1ANZsE6HtEJxJlAuT1N0C4r8WsXg
         gwyu58Lj4F5VM9uN2/iVSYILbiYW+3x6F1b59YxHhNjmOOVSveIatsNVI/GJK0Dsy8km
         Ly4pjMgpGO8yGst8lVF1GxPS1ekojhgAFpHNd/bTMClHp+v6HvaSbX5eXawYF1fXl+oe
         WxV8DcC7VdvTTErqvsKox6ZvkKDSplHEIJEssbLZ/7OZof/z198APZcqzhFxYDo/ZLLN
         i7TA==
X-Gm-Message-State: AOAM531F3qUhS3r/aJtGp6fk9He0MARxtzlX/OoZEi+9jAnh4mjkKBRP
	KkFnvElBOTG3vNGRpI/kNsE=
X-Google-Smtp-Source: ABdhPJzupP0E/ypx+DBPQWHcdsRqkcWgZoMe5QO5Eyujt7MBgWcO49ejLCu6//tiDHbR8Y+fkwmT/A==
X-Received: by 2002:a2e:81d0:: with SMTP id s16mr12379761ljg.265.1639605062289;
        Wed, 15 Dec 2021 13:51:02 -0800 (PST)
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <eaed4dac-219f-39ae-7237-0ae67c77869a@gmail.com>
Date: Wed, 15 Dec 2021 23:51:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 11:34, Oleksii Moisieiev wrote:


Hi Oleksii

> This enumeration sets SCI type for the domain. Currently there is
> two possible options: either 'none' or 'scmi_smc'.
>
> 'none' is the default value and it disables SCI support at all.
>
> 'scmi_smc' enables access to the Firmware from the domains using SCMI
> protocol and SMC as transport.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
>   tools/include/libxl.h            |  5 +++++
>   tools/libs/light/libxl_types.idl |  6 ++++++
>   tools/xl/xl_parse.c              |  9 +++++++++
>   4 files changed, 42 insertions(+)
>
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b98d161398..92d0593875 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
>   
>   =back
>   
> +=item B<sci="STRING">
> +
> +B<Arm only> Set SCI type for the guest. SCI is System Control Protocol -
> +allows domain to manage various functions that are provided by HW platform.
> +
> +=over 4
> +
> +=item B<none>
> +
> +Don't allow guest to use SCI if present on the platform. This is the default
> +value.
> +
> +=item B<scmi_smc>
> +
> +Enables SCMI-SMC support for the guest. SCMI is System Control Management
> +Inferface - allows domain to manage various functions that are provided by HW
> +platform, such as clocks, resets and power-domains. Xen will mediate access to
> +clocks, power-domains and resets between Domains and ATF. Disabled by default.
> +SMC is used as transport.
> +
> +=back
> +
>   =back
>   
>   =head2 Paravirtualised (PV) Guest Specific Options
> diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> index 2bbbd21f0b..30e5aee119 100644
> --- a/tools/include/libxl.h
> +++ b/tools/include/libxl.h
> @@ -278,6 +278,11 @@
>    */
>   #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
>   
> +/*
> + * libxl_domain_build_info has the arch_arm.sci field.
> + */
> +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SCI 1
> +
>   /*
>    * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
>    * 'soft reset' for domains and there is 'soft_reset' shutdown reason
> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl
> index 2a42da2f7d..9067b509f4 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl

I assume that at least goland bindings want updating.


> @@ -480,6 +480,11 @@ libxl_tee_type = Enumeration("tee_type", [
>       (1, "optee")
>       ], init_val = "LIBXL_TEE_TYPE_NONE")
>   
> +libxl_sci_type = Enumeration("sci_type", [
> +    (0, "none"),
> +    (1, "scmi_smc")
> +    ], init_val = "LIBXL_SCI_TYPE_NONE")
> +
>   libxl_rdm_reserve = Struct("rdm_reserve", [
>       ("strategy",    libxl_rdm_reserve_strategy),
>       ("policy",      libxl_rdm_reserve_policy),
> @@ -564,6 +569,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>       ("apic",             libxl_defbool),
>       ("dm_restrict",      libxl_defbool),
>       ("tee",              libxl_tee_type),
> +    ("sci",              libxl_sci_type),
>       ("u", KeyedUnion(None, libxl_domain_type, "type",
>                   [("hvm", Struct(None, [("firmware",         string),
>                                          ("bios",             libxl_bios_type),
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index 117fcdcb2b..c37bf6298b 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -2747,6 +2747,15 @@ skip_usbdev:
>           }
>       }
>   
> +    if (!xlu_cfg_get_string (config, "sci", &buf, 1)) {
> +        e = libxl_sci_type_from_string(buf, &b_info->sci);
> +        if (e) {
> +            fprintf(stderr,
> +                    "Unknown sci \"%s\" specified\n", buf);
> +            exit(-ERROR_FAIL);
> +        }
> +    }
> +
>       parse_vkb_list(config, d_config);
>   
>       xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 21:58:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 21:58:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247599.426948 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcIL-0000zf-7t; Wed, 15 Dec 2021 21:58:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247599.426948; Wed, 15 Dec 2021 21:58:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcIL-0000zY-4s; Wed, 15 Dec 2021 21:58:41 +0000
Received: by outflank-mailman (input) for mailman id 247599;
 Wed, 15 Dec 2021 21:58:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcIJ-0000zO-RO; Wed, 15 Dec 2021 21:58:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcIJ-0005Bu-7a; Wed, 15 Dec 2021 21:58:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcII-0002hZ-S2; Wed, 15 Dec 2021 21:58:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcII-0001nz-RY; Wed, 15 Dec 2021 21:58:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ogbLgdCK8mnu6t7yV0MkGQklbteJWU/k8d0VUOys+ns=; b=UxgCIbMeyJKdQrdCjjxpWEhbwu
	SjeuU3Vyr52Oh8jTE5keGIzAllUYw39ikZip1UPGlhzPc2QNkkjnpEEex+I/i8rdhCPQ13IkS/Qws
	JRTJOt2s1ZNJakFerQ2vAcW9G+E4lvQjy6eF2scV5+LmkHyYXQmBQx7PvxSrPyv+fvok=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167422-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167422: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7f70428f0109470aa9177d1a9e5ce02de736f480
X-Osstest-Versions-That:
    linux=e3c95128def1c937754a5cdc3d297fa47968e9f6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 21:58:38 +0000

flight 167422 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167422/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail in 167413 pass in 167422
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail in 167413 pass in 167422
 test-arm64-arm64-libvirt-raw 13 guest-start                fail pass in 167413

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167413 like 167230
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 167413 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 167413 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167230
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167230
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167230
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167230
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167230
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167230
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167230
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167230
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167230
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167230
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167230
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167230
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                7f70428f0109470aa9177d1a9e5ce02de736f480
baseline version:
 linux                e3c95128def1c937754a5cdc3d297fa47968e9f6

Last test of basis   167230  2021-12-08 08:12:55 Z    7 days
Testing same since   167413  2021-12-14 14:15:06 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alan Stern <stern@rowland.harvard.edu>
  Alan Young <consult.awy@gmail.com>
  Alexander Stein <alexander.stein@ew.tq-group.com>
  Alexander Sverdlin <alexander.sverdlin@nokia.com>
  Alok Prasad <palok@marvell.com>
  Alyssa Ross <hi@alyssa.is>
  Andrea Mayer <andrea.mayer@uniroma2.it>
  Andrew Morton <akpm@linux-foundation.org>
  Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
  Anton Altaparmakov <anton@tuxera.com>
  Ard Biesheuvel <ardb@kernel.org>
  Ariel Elior <aelior@marvell.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Bindushree P <Bindushree.p@intel.com>
  Brian Silverman <brian.silverman@bluerivertech.com>
  Chen-Yu Tsai <wens@csie.org>
  Christian König <christian.koenig@amd.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  David Sterba <dsterba@suse.com>
  Davidlohr Bueso <dave@stgolabs.net>
  Davidlohr Bueso <dbueso@suse.de>
  Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
  Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Eric Biggers <ebiggers@google.com>
  Eric Dumazet <edumazet@google.com>
  Evgeny Boger <boger@wirenboard.com>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Westphal <fw@strlen.de>
  freak07 <michalechner92@googlemail.com>
  George Kuruvinakunnel <george.kuruvinakunnel@intel.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
  Guenter Roeck <linux@roeck-us.net>
  Gurucharan G <gurucharanx.g@intel.com>
  Gwendal Grignou <gwendal@chromium.org>
  Hannes Reinecke <hare@suse.de>
  Hans de Goede <hdegoede@redhat.com>
  Herve Codina <herve.codina@bootlin.com>
  J. Bruce Fields <bfields@redhat.com>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jens Axboe <axboe@kernel.dk>
  Jesse Brandeburg <jesse.brandeburg@intel.com>
  Jeya R <jeyr@codeaurora.org>
  Jianglei Nie <niejianglei2021@163.com>
  Jianguo Wu <wujianguo@chinatelecom.cn>
  Jimmy Assarsson <extja@kvaser.com>
  Jiri Kosina <jkosina@suse.cz>
  Joakim Zhang <qiangqing.zhang@nxp.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Josef Bacik <josef@toxicpanda.com>
  Kai-Heng Feng <kai.heng.feng@canonical.com>
  Kailang Yang <kailang@realtek.com>
  Karen Sornek <karen.sornek@intel.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Lars-Peter Clausen <lars@metafoo.de>
  Lee Jones <lee.jones@linaro.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Lionel Landwerlin <lionel.g.landwerlin@intel.com>
  Luca Stefani <luca.stefani.ge1@gmail.com>
  Manish Chopra <manishc@marvell.com>
  Manjong Lee <mj0123.lee@samsung.com>
  Marc Kleine-Budde <mkl@pengutronix.de>
  Marc Zyngier <maz@kernel.org>
  Mark Brown <broonie@kernel.org>
  Mateusz Palczewski <mateusz.palczewski@intel.com>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Michal Maloszewski <michal.maloszewski@intel.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Miquel Raynal <miquel.raynal@bootlin.com>
  Mitch Williams <mitch.a.williams@intel.com>
  Nicolas Dichtel <nicolas.dichtel@6wind.com>
  Noralf Trønnes <noralf@tronnes.org>
  Nuno Sá <nuno.sa@analog.com>
  Oleg Nesterov <oleg@redhat.com>
  Oliver Hartkopp <socketcan@hartkopp.net>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Pali Rohár <pali@kernel.org>
  Patrik John <patrik.john@u-blox.com>
  Pavel Hofman <pavel.hofman@ivitera.com>
  Peilin Ye <peilin.ye@bytedance.com>
  Peter Zijlstra (Intel) <peterz@infradead.org>
  Prabhakar Kushwaha <pkushwaha@marvell.com>
  Qu Wenruo <wqu@suse.com>
  Rob Herring <robh@kernel.org>
  Shaokun Zhang <zhangshaokun@hisilicon.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <simon.horman@corigine.com>
  Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
  Stephen Boyd <sboyd@kernel.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Szymon Heidrich <szymon.heidrich@gmail.com>
  Takashi Iwai <tiwai@suse.de>
  Tom Lendacky <thomas.lendacky@amd.com>
  Tony Brelinski <tony.brelinski@intel.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vincent Mailhol <mailhol.vincent@wanadoo.fr>
  Vladimir Murzin <vladimir.murzin@arm.com>
  Wudi Wang <wangwudi@hisilicon.com>
  xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com>
  Yang Yingliang <yangyingliang@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e3c95128def1..7f70428f0109  7f70428f0109470aa9177d1a9e5ce02de736f480 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:05:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:05:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247607.426963 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcOc-0002g0-52; Wed, 15 Dec 2021 22:05:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247607.426963; Wed, 15 Dec 2021 22:05:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcOc-0002fs-1M; Wed, 15 Dec 2021 22:05:10 +0000
Received: by outflank-mailman (input) for mailman id 247607;
 Wed, 15 Dec 2021 22:05:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcOb-0002fj-Od; Wed, 15 Dec 2021 22:05:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcOb-0005KK-4K; Wed, 15 Dec 2021 22:05:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcOa-0002vf-OC; Wed, 15 Dec 2021 22:05:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcOa-0006ds-Ni; Wed, 15 Dec 2021 22:05:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WCkMpeVZFtNWh6x2BZFXRis1zCtOAd1ptyWWIHqDAS0=; b=3+iHr38eHqQSIxRzQ4umQBTjJI
	ZNBP1FKd+oqoqbF1oLC49GskutbT62Rq7CfN9pbDTErObrADZ7B7E6aHsX6dZSz3RFUHtOhOqZJN+
	C13anZABWUeookRacsvYubzQolKnonOLx1dELqWeqY/N5cCyMSwfJtW7Afpna0V5maHw=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167418-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167418: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:guest-start/redhat.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=249e0f1d8f203188ccdcced5a05c2149739e1566
X-Osstest-Versions-That:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 22:05:08 +0000

flight 167418 xen-unstable real [real]
flight 167439 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167418/
http://logs.test-lab.xenproject.org/osstest/logs/167439/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167411

Tests which are failing intermittently (not blocking):
 test-amd64-i386-qemuu-rhel6hvm-amd 14 guest-start/redhat.repeat fail pass in 167439-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167411
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167411
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167411
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167411
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167411
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167411
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167411
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  249e0f1d8f203188ccdcced5a05c2149739e1566
baseline version:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f

Last test of basis   167411  2021-12-14 12:17:05 Z    1 days
Testing same since   167418  2021-12-14 21:38:12 Z    1 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit 249e0f1d8f203188ccdcced5a05c2149739e1566
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Dec 13 20:33:42 2021 +0000

    x86/cpuid: Fix TSXLDTRK definition
    
    TSXLDTRK lives in CPUID leaf 7[0].edx, not 7[0].ecx.
    
    Bit 16 in ecx is LA57.
    
    Fixes: a6d1b558471f ("x86emul: support X{SUS,RES}LDTRK")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 1382241fe880d48e109f2056cec052bb3919a9d1
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:50:07 2021 +0100

    perfc: drop calls_to_multicall performance counter
    
    The calls_to_multicall performance counter is basically redundant to
    the multicall hypercall counter. The only difference is the counting
    of continuation calls, which isn't really that interesting.
    
    Drop the calls_to_multicall performance counter.
    
    Suggested-by: Jan Beulich <jbeulich@suse.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 668dd44902bbaf52f8e7214e0da060b6ec962e88
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:49:23 2021 +0100

    x86/perfc: add hypercall performance counters for hvm, correct pv
    
    The HVM hypercall handler is missing incrementing the per hypercall
    counters. Add that.
    
    The counters for PV are handled wrong, as they are not using
    perf_incra() with the number of the hypercall as index, but are
    incrementing the first hypercall entry (set_trap_table) for each
    hypercall. Fix that.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 7b99e7258559c9caa235d9faf323b22c68e4a581
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:48:17 2021 +0100

    x86emul: drop "seg" parameter from insn_fetch() hook
    
    This is specified (and asserted for in a number of places) to always be
    CS. Passing this as an argument in various places is therefore
    pointless. The price to pay is two simple new functions, with the
    benefit of the PTWR case now gaining a more appropriate error code.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Paul Durrant <paul@xen.org>

commit c49ee0329ff3de98722fd74ed5ba6d9665701e54
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:47:31 2021 +0100

    SUPPORT.md: limit security support for hosts with very much memory
    
    Sufficient and in particular regular testing on very large hosts cannot
    currently be guaranteed. Anyone wanting us to support larger hosts is
    free to propose so, but will need to supply not only test results, but
    also a test plan.
    
    This is a follow-up to XSA-385.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 53ed194539ddbea4f6aecb1b7c2f33aa8c0201d9
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:46:48 2021 +0100

    x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed by: Alexandru Isaila <aisaila@bitdefender.com>

commit 7dc0233f534f64e7f3ee71e74e05dd5ab8a24808
Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Date:   Tue Dec 14 09:44:44 2021 +0100

    vpci: fix function attributes for vpci_process_pending
    
    vpci_process_pending is defined with different attributes, e.g.
    with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
    Fix this by defining both of the definitions with __must_check.
    
    Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
    Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247617.426991 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcef-0005aC-2v; Wed, 15 Dec 2021 22:21:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247617.426991; Wed, 15 Dec 2021 22:21:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcee-0005a2-Vl; Wed, 15 Dec 2021 22:21:44 +0000
Received: by outflank-mailman (input) for mailman id 247617;
 Wed, 15 Dec 2021 22:21:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LTfI=RA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxced-0005ZJ-TT
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 22:21:43 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6030be57-5df5-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 23:21:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6030be57-5df5-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639606902;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=iPJtlo52ZPRCJ/j6YuQ5J89j4lSVCx0r858GzTa2D6o=;
  b=R5xhXNxSytcr0JpZyWQGb+nXW0PJAyq8UlSeQyYBiGwTWE0Adsc3ABUA
   TzWwIg9HNvps9N6//fB3oPvW++dhFiR4ESAj+pL4I9sbTNZwo2bAwHKej
   yF5ue0N/AO94v5Bv6UI5Z18M1Ykm1sIzYAhMPBmsn7Yjq/XMDV/M+djgN
   Q=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Ab2mhAzUfyqKtvN8idDjc+9VpWqjge9+qxScC9caDqN0NgD83MQ66M+eI6k+j+xEMY3urLanuA
 sHxy3xomF7KBLtqn5vvO3KFuWNbtIoK7C9GBDWplFF+0awmPmlu9UCktkbV71ny018nvOb+YK3
 yc2v9aYrRrcRPYOL9FK3LFhJ8L+2SjHtWVItB98NVBsQ6Zl75hIrrlzBAfckYfkiAUi/RlQvMa
 IJrqrJzjig2AFgxZyHr632FIFMEthrFbsO0fjI9zeNn9ve2SlkOK2TaltyJW7VcH6pohtjhIay
 cl/NSZ8MOjck8KJrOE+dicta
X-SBRS: 5.1
X-MesageID: 59629091
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:okY9PqAVrPRdoBVW/+Tkw5YqxClBgxIJ4kV8jS/XYbTApD531DZUx
 2IXCG6HaPbeZDegKdlyPYzk/UgOsMWHnNdnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX570E87wIbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/mhqAmtx+5
 cpxk5nuRkQnMq2Poe8xXEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFjWlq15gfRJ4yY
 eIBNyNgfDD9XSRJBXRMWY0Ypbjvh1rwJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiG+rtxsQVPdPL8s/tg7OxKbUoD+SKmdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl8pDGJGT9bxgbQ+0RqmBNzDJrVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtENsWohdBozap1sldrVj
 Kn741k5CHh7ZiTCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2l3hW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyil08CDbagO3aPqub+7zkidBAGOHw/kOQPHsbrH+asMDtJ5yb5zexzdop7sb5Sk+uUr
 HixVlUBkAj0hGHdKBXMYXdmMeu9UZF6pHM9HCotIVf3hCRzPdfxtP8SJ8ktYL0q1O1/1vooH
 fMLTNqNX6ZUQTPd9jVDMZSk9N5+dA6mjB6lNja+ZGRtZIZpQgHEo4e2fgbm+CQUIDCwsM8y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg6Zucc8WKBjFyj+L7
 CqsAE8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYwq2uMPADm1oW4YNwH6wykPA77trr4bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFt3Z+uO4vgYhz3O4KlnO079/iJ2oOKKXEg608NgU8CBwG+Z6L8Y/
 No=
IronPort-HdrOrdr: A9a23:KjFac6+ZytPU5PRwBrJuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P
 re+8jztCWE7Ar5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslvd8kbFl9K1u5
 0OT0EHMqyTMWRH
X-IronPort-AV: E=Sophos;i="5.88,209,1635220800"; 
   d="scan'208";a="59629091"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 0/4] x86/cpuid: Introduce dom0-cpuid=
Date: Wed, 15 Dec 2021 22:21:11 +0000
Message-ID: <20211215222115.6829-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Andrew Cooper (4):
  x86/cpuid: Split dom0 handling out of init_domain_cpuid_policy()
  x86/cpuid: Factor common parsing out of parse_xen_cpuid()
  x86/cpuid: Introduce dom0-cpuid command line option
  x86/cpuid: Advertise SERIALIZE by default to guests

 docs/misc/xen-command-line.pandoc           |  17 +++++
 xen/arch/x86/cpuid.c                        | 100 ++++++++++++++++++++++------
 xen/arch/x86/include/asm/cpuid.h            |   3 +
 xen/arch/x86/setup.c                        |  15 +++--
 xen/include/public/arch-x86/cpufeatureset.h |   2 +-
 5 files changed, 112 insertions(+), 25 deletions(-)

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247616.426980 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcea-0005J8-MI; Wed, 15 Dec 2021 22:21:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247616.426980; Wed, 15 Dec 2021 22:21:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcea-0005J1-JK; Wed, 15 Dec 2021 22:21:40 +0000
Received: by outflank-mailman (input) for mailman id 247616;
 Wed, 15 Dec 2021 22:21:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LTfI=RA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxceZ-0005Iv-6h
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 22:21:39 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5d6815eb-5df5-11ec-85d3-df6b77346a89;
 Wed, 15 Dec 2021 23:21:37 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d6815eb-5df5-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639606897;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=WS7TqjZJbtgUipE6pePfwgLxq9oaFQsVTAwBm5aBAdY=;
  b=caaZPpe9V1lnqVaAsPV2Gl4ObbMZ0hn8h5unxxQW4eVM9Geq9yeqr4Ug
   mTUbIOLldFwnUXUBB9VjwRRVFC73BR/b0cxDle3kvcZdRNYzE6LJfw1v/
   6CPj8mp04ei6EktKxzrOLCivE8Pa7VAZO7N/oWfYxATXV0ba8ZKG5kqCq
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: CIghVhnnSCByUBP/iUbUGkqFldz5Ml1iaGVjnjha/bNdwNGXWiiJlyBagz3YpSZpFB01MIwTgr
 o10nqib/3NdcT7Swd8M1J5Fw0rEb9udkY6uGsmJEjIhNQ0HWZOJWL7ZoY0FXA4VChDob47zJkd
 akwCBa2I/iUbWUe6gcQtGzahT6XYPrFXELIiyWFPi87fKOFIGRdJ1Jppg+Asol4E71n8ytvV8w
 nUk8nOuxawuYYkqnMPrgymcLB1hdqyXIsOuIEAwfC2Us2fWN76tmEl0++1a5DOY06YM39zIMUv
 IZqHcUR2u4SmPB7eMnsrV++g
X-SBRS: 5.1
X-MesageID: 62205277
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:+RoyF6+3nB6vw2SGn8ppDrUDTXmTJUtcMsCJ2f8bNWPcYEJGY0x3m
 zMcD2mEPKqIN2ume91ybNuw8BlUvcTQy95iGwFqqik8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRg39Yz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPgr9
 s1MhcSaWTx4EfOQucBFajoASnhHaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4UR66DP
 ZVGAdZpRD/DRyRpAVAdM4N9ke2Eu3DbYTFg73vA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq
 Qru3U70HxUbP9y30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLpix
 1c8o3R06/JorQryE4e7D0bQTGO4UgA0AeRIEt1iwhG2m4WKvye9XlEnFmcYUYlz3CMpfgAC2
 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPft1oWdJN3m/
 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO9zABbvzt68owGOlor+p5
 iJsdy+2tr9mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ldRo4aZlUJGWxO
 yc/XD+9ArcJZhNGioctPOqM5zkCl/C8RbwJqNiKBjaxXnSBXFDep3w/DaJh92vsjFItgckC1
 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6CHfjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H
 hc2H5bi9iizp8WiOHSKqtBKcghRRZX5bLivw/Fqmie4ClIOMAkc5zX5mNvNoqRpwPZYkPnm5
 Ha4VhMKwVbznySfew6LdmpiePXkWpMm9SA3OiklPFCJ3Xk/YNnwsPdDJsVvJbR3pvZ+yfNUT
 uUef5nSCPp4VTmaqS8WaoPwrdI+eU3z1x6OJSesfBM2Y4VkG17S4tbhcwa2rHsOAyO7uNEQu
 bql0g+HE5MPSx47VJTdae61zkP3tn8YwbogU0zNK9hVWUPt7Ik1dHCh0q5pe5kBcEyRyCGb2
 gCaBQYjidPM+4JlosPUga2krpuyF7csFERtAGSGv629MjPX/zT/zNYYAvqIZz3USEj95L6mO
 bdO1/j5PfAKwARKvo57H+o5xK4y/YKy9bpTzwAiF3TXdVW7TLhnJyDej8VIs6RMwJ5fuBe3B
 R3TqoULZ+3RNZO3CkMVKSokcv+HhKMdlTTl5PgoJFn3uX1s972dXEQOZxSBhUSx9leu3F/JF
 Qv5hPMr1g==
IronPort-HdrOrdr: A9a23:p9s7Ya0Zlyq/sjgJC8wRuAqjBIgkLtp133Aq2lEZdPRUGvb4qy
 nIpoVi6faUskdpZJhOo6HiBEDtexzhHNtOkO0s1NSZLW/bUQmTXeNfBOLZqlWKcUCTygce79
 YGT0EXMqyKMbEQt6bHCWeDferIuOP3lZyVuQ==
X-IronPort-AV: E=Sophos;i="5.88,209,1635220800"; 
   d="scan'208";a="62205277"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 4/4] x86/cpuid: Advertise SERIALIZE by default to guests
Date: Wed, 15 Dec 2021 22:21:15 +0000
Message-ID: <20211215222115.6829-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211215222115.6829-1-andrew.cooper3@citrix.com>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

I've played with SERIALIZE, TSXLDTRK, MOVDIRI and MOVDIR64 on real hardware,
and they all seem fine, including emulation support.

SERIALIZE exists specifically to have a userspace usable serialising operation
without other side effects.  (The only other two choices are CPUID which is a
VMExit under virt and clobbers 4 registers, and IRET-to-self which very slow
and consumes content from the stack.)

TSXLDTRK is a niche TSX feature, and TSX itself is niche outside of demos of
speculative sidechannels.  Leave the feature opt-in until a usecase is found,
in an effort to preempt the multiple person years of effort it has taken to
mop up TSX issues impacting every processor line.

MOVDIRI and MOVDIR64 are harder to judge.  They're architectural building
blocks towards ENQCMD{,S} without obvious usecases on their own.  They're of
no use to domains without PCI devices, so leave them opt-in for now.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * New
---
 xen/include/public/arch-x86/cpufeatureset.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 647ee9e5e277..0b399375566f 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -278,7 +278,7 @@ XEN_CPUFEATURE(SRBDS_CTRL,    9*32+ 9) /*   MSR_MCU_OPT_CTRL and RNGDS_MITG_DIS.
 XEN_CPUFEATURE(MD_CLEAR,      9*32+10) /*A  VERW clears microarchitectural buffers */
 XEN_CPUFEATURE(RTM_ALWAYS_ABORT, 9*32+11) /*! June 2021 TSX defeaturing in microcode. */
 XEN_CPUFEATURE(TSX_FORCE_ABORT, 9*32+13) /* MSR_TSX_FORCE_ABORT.RTM_ABORT */
-XEN_CPUFEATURE(SERIALIZE,     9*32+14) /*a  SERIALIZE insn */
+XEN_CPUFEATURE(SERIALIZE,     9*32+14) /*A  SERIALIZE insn */
 XEN_CPUFEATURE(TSXLDTRK,      9*32+16) /*a  TSX load tracking suspend/resume insns */
 XEN_CPUFEATURE(CET_IBT,       9*32+20) /*   CET - Indirect Branch Tracking */
 XEN_CPUFEATURE(IBRSB,         9*32+26) /*A  IBRS and IBPB support (used by Intel) */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247618.427002 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxceg-0005qz-BJ; Wed, 15 Dec 2021 22:21:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247618.427002; Wed, 15 Dec 2021 22:21:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxceg-0005qs-7l; Wed, 15 Dec 2021 22:21:46 +0000
Received: by outflank-mailman (input) for mailman id 247618;
 Wed, 15 Dec 2021 22:21:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LTfI=RA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxcee-0005ZJ-SV
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 22:21:44 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6126f12c-5df5-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 23:21:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6126f12c-5df5-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639606903;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=c3nwmG65CWTnQUe9tR5dWZEN9Clal0P82PcG0VxhhM8=;
  b=XMct5QXU6v3nLwcMmXZEsJ00/YnwGaeLFfDcrTtg6kO+4NEf1H1V+nsB
   QY1yKu7e7kDyYQxX3RNFDifugS9Wi/7dwTvxRWp0FVp0TU/fX/ZS+ifvE
   Isb4MsVIVWKzkWjWrK310EVjDsloCGDc727MyXFIy9FLnoH3+ws1hMhKv
   U=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: TG0n8gseO5urC0LOd2LjCDg+z6mA+gozGQQsqlgUe7rePI4OdEoTy4053vuUdDrZxSRmtZtICC
 I/5otxeUTpK4RVC2ZY7UZ2Wg19KtQpRbYFFfLivoHFoZ0lwhhnlejj5DWIzM9t8Nvkv2pIdjpC
 V2gtmZ8qgD3empa2k9NiGfU3i5EEOTRqQm9JSp0kNqgs5qRISuOhmYoR8/SSx885PnMgJRDIX7
 FZZSuNWO/kGHNId3iDPdETdsjLiTWPIlfjiP2LFuYY1Iz0q8mH6MsBYaaJFGtQ0iCcUR95XkEk
 RzD8hOSrU/wYEt13xfs9Si6N
X-SBRS: 5.1
X-MesageID: 60126719
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:h2QDza1llxiymrqL0vbD5R52kn2cJEfYwER7XKvMYLTBsI5bp2MOy
 GMZWmnVPPreMWb0co0nO4+0pktX7JLRn9U1QQpupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt
 Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCanAZqTNMEn970Es5wrNh2eaEvPDia++zk
 YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq
 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhof1a8
 MtBsLWKUCwRHrCPgNk0bwNXOnQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr
 6VecW1TKEDY7w616OvTpu1Er8IvNsT0eqgYvWlt12rxBvc6W5HTBa7N4Le02R9u3pkUQ6mHN
 qL1bxJXY0niPDZrOG4ON5QYreKsiUvdTABx/Qf9Sa0fvDGIkV0ZPKLWGMXRUsyHQ4NShEnwj
 kDs8nn9AxoaHMeC0jfD+XWp7sffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWZj5EA
 xVKoGx09/F0rRH1CImmN/GlnJKaliAxcOJOH+gT0him8orJoB6kL1QeQRcUPbTKq/QKbTAt0
 1aImfbgCjpurKCZRBqhy1uEkd+hEXNLdDFfPEfoWSNAuoC++99r0nojW/46SPbt5uAZDw0c1
 NxjQMIWo7wIxfAG2Kyglbwsq2L9/8OZJuLZC+i+Y45E0u+bTNL1D2BLwQKChRqlEGp/ZgPb1
 JTjs5LBhN3i9bnXyESwrBwlRdlFHcqtPjzGmkJIFJI87Tmr8HPLVdkOu2AjdRw2YpteIWSBj
 KrvVeV5vsU70JyCN/AfXm5MI55ykfiI+SrNCJg4keaikrAuLVTarUmClGab3nz3kVhErE3ME
 czzTCpYNl5DUf4P5GPvH481iOZ3rghjlDu7bc2qlHyPjOvBDEN5vJ9YaTNimMhit/jayOgUm
 v4CX/a3J+J3DLejP3KJqNFLdjjn7xETXPjLliCeTcbbSiIOJY3rI6W5LWoJd9M3kqJLuP3P+
 33hCEZUxECm3S/MKBmQa2AlY7TqBM4toXU+NC0qHFCpx3l8Ptr/sPZBL8M6Les96ehu7f9oV
 P1ZKc+ONetCF2bc8DMHYJij8IE7LEa3hRiDNjaOaSQke8IyXBTA/9LpJ1O99CQHAietm9E5p
 rmsilHSTZYZHlwwB8fKcvO/iVi2uCFFyu51WkLJJPhVeVntr9c2e3Cg0KdvLphVexvZxzac2
 wKHOjsipLHA890v7d3EpaGYtIP1QeFwKVVXQjvA5rGsOCiEomf6md1cUPyFdCz2XX/v/Pnwf
 v1cyvzxPaFVnFtOtIYgQb9nwbhnuonqrr5eiA9lAG/KfxKgDbY5eiuK2sxGt6tswL5FuFTpB
 hLTq4cCYbjZatn4FFMxJRY+arXR3P4ZrTDe8PApLRio/yRw5reGDR1fMhTkZPax91ep3FfJG
 dschfM=
IronPort-HdrOrdr: A9a23:U/F/Y62kDMbbDxTYFliKuQqjBEgkLtp133Aq2lEZdPU0SKGlfg
 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5
 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq
 a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
X-IronPort-AV: E=Sophos;i="5.88,209,1635220800"; 
   d="scan'208";a="60126719"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of init_domain_cpuid_policy()
Date: Wed, 15 Dec 2021 22:21:12 +0000
Message-ID: <20211215222115.6829-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211215222115.6829-1-andrew.cooper3@citrix.com>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

To implement dom0-cpuid= support, the special cases would need extending.
However there is already a problem with late hwdom where the special cases
override toolstack settings, which is unintended and poor behaviour.

Introduce a new init_dom0_cpuid_policy() for the purpose, moving the ITSC and
ARCH_CAPS logic.  The is_hardware_domain() can be dropped, and for now there
is no need to rerun recalculate_cpuid_policy(); this is a relatively expensive
operation, and will become more-so over time.

Rearrange the logic in create_dom0() to make room for a call to
init_dom0_cpuid_policy().  The AMX plans for having variable sized XSAVE
states require that modifications to the policy happen before vCPUs are
created.

Additionally, factor out domid into a variable so we can be slightly more
correct in the case of a failure, and also print the error from
domain_create().  This will at least help distinguish -EINVAL from -ENOMEM.

No practical change in behaviour.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * New

It is slightly weird now having CPUID split into two helpers, while the MSR
side of things remains as a special case.  It doesn't actually matter right
now, and it is going to have to change anyway in due course, so I've decided
to go with the simple option for now.
---
 xen/arch/x86/cpuid.c             | 25 +++++++++++++++----------
 xen/arch/x86/include/asm/cpuid.h |  3 +++
 xen/arch/x86/setup.c             | 15 +++++++++++----
 3 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 151944f65702..f63f5efc17f5 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -727,23 +727,28 @@ int init_domain_cpuid_policy(struct domain *d)
     if ( !p )
         return -ENOMEM;
 
-    /* The hardware domain can't migrate.  Give it ITSC if available. */
-    if ( is_hardware_domain(d) )
-        p->extd.itsc = cpu_has_itsc;
+    d->arch.cpuid = p;
+
+    recalculate_cpuid_policy(d);
+
+    return 0;
+}
+
+void __init init_dom0_cpuid_policy(struct domain *d)
+{
+    struct cpuid_policy *p = d->arch.cpuid;
+
+    /* dom0 can't migrate.  Give it ITSC if available. */
+    if ( cpu_has_itsc )
+        p->extd.itsc = true;
 
     /*
      * Expose the "hardware speculation behaviour" bits of ARCH_CAPS to dom0,
      * so dom0 can turn off workarounds as appropriate.  Temporary, until the
      * domain policy logic gains a better understanding of MSRs.
      */
-    if ( is_hardware_domain(d) && cpu_has_arch_caps )
+    if ( cpu_has_arch_caps )
         p->feat.arch_caps = true;
-
-    d->arch.cpuid = p;
-
-    recalculate_cpuid_policy(d);
-
-    return 0;
 }
 
 void guest_cpuid(const struct vcpu *v, uint32_t leaf,
diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h
index 46904061d0ef..9c3637549a10 100644
--- a/xen/arch/x86/include/asm/cpuid.h
+++ b/xen/arch/x86/include/asm/cpuid.h
@@ -59,6 +59,9 @@ bool recheck_cpu_features(unsigned int cpu);
 /* Allocate and initialise a CPUID policy suitable for the domain. */
 int init_domain_cpuid_policy(struct domain *d);
 
+/* Apply dom0-specific tweaks to the CPUID policy. */
+void init_dom0_cpuid_policy(struct domain *d);
+
 /* Clamp the CPUID policy to reality. */
 void recalculate_cpuid_policy(struct domain *d);
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f40a9fe5d351..e716005145d3 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -772,6 +772,7 @@ static struct domain *__init create_dom0(const module_t *image,
     };
     struct domain *d;
     char *cmdline;
+    domid_t domid;
 
     if ( opt_dom0_pvh )
     {
@@ -786,10 +787,16 @@ static struct domain *__init create_dom0(const module_t *image,
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    /* Create initial domain 0. */
-    d = domain_create(get_initial_domain_id(), &dom0_cfg, !pv_shim);
-    if ( IS_ERR(d) || (alloc_dom0_vcpu0(d) == NULL) )
-        panic("Error creating domain 0\n");
+    /* Create initial domain.  Not d0 for pvshim. */
+    domid = get_initial_domain_id();
+    d = domain_create(domid, &dom0_cfg, !pv_shim);
+    if ( IS_ERR(d) )
+        panic("Error creating d%u: %ld\n", domid, PTR_ERR(d));
+
+    init_dom0_cpuid_policy(d);
+
+    if ( alloc_dom0_vcpu0(d) == NULL )
+        panic("Error creating d%uv0\n", domid);
 
     /* Grab the DOM0 command line. */
     cmdline = image->string ? __va(image->string) : NULL;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247619.427007 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxceg-0005ut-Pa; Wed, 15 Dec 2021 22:21:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247619.427007; Wed, 15 Dec 2021 22:21:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxceg-0005ug-Jk; Wed, 15 Dec 2021 22:21:46 +0000
Received: by outflank-mailman (input) for mailman id 247619;
 Wed, 15 Dec 2021 22:21:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LTfI=RA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxcef-0005ZJ-Mx
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 22:21:45 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 620a7ecf-5df5-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 23:21:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 620a7ecf-5df5-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639606904;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=x7dgLyygTieu5IPGh9PaNnQdDucWMUK0ck0vN46ZQe0=;
  b=byCEMiZw4MKNEKkANXCa6N9y3etkM51+1/2PWZ6mi5+0G/A6QIOlHVmY
   E1qi3qCqUCiM/wDLF0c3wn4p3UD1U+NIp+OQk/E9je0cfn/P7fM9OY5rz
   m7wClo85gFnXEeVA/pxYGvReUehJgmTAzvPJtBpFQql1y474SbQektdZr
   A=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: B+uNPfy2nMfU3sOoyVOiRequXFFuiYR57zcsfX2zsEcXeV68gNmZpJ8hf+DjDYi84FjSZkA7EN
 fX9y/MZDBnh91QVIJ4g1gnpdApt7WTW65Aq7kCLPhD8YCKzOQlxF4tkSTA3l7hHRGSwW9mRO91
 QczXBawPOQlibfduiGaw2ChaSIigxA2RJd/5qoTyRoFM7Nt0eX9JvhNA8FsKuqDijlOcoeEmcA
 rRKr17PS16a+RL9fQ8d0DQuch+QAeMzo911F+WJbzt1mo9OA7pPc5J88ggAjFGwUNs843GXe5v
 pvaYM8ySv+2IoasRIEjZr9GX
X-SBRS: 5.1
X-MesageID: 59629092
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iQAcgKAEp/YpWxVW/+Tkw5YqxClBgxIJ4kV8jS/XYbTApG5z1TAAx
 mQcUDrVPfiKZzakKY0jPIXi9E5QvpDcnIBnQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX570E87wIbVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/kinYkvpek
 4l2v4GOeTcwHPyUm6MSTEwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTY+9gnMk8auLsO5sSoCpIxjDFF/c2B5vERs0m4PcFjWlq15gfR54yY
 eIcZDxXMlffRCFjPws4JYM8meGCunrWJmgwRFW9+vNsvjm7IBZK+KfpGMrYfJqNX8o9tmSyq
 3/C/m/5KgoHL9HZwj2Amlq8i+mKkS7lVYY6ELyj6uUskFCV3nYUChAdSR28u/bRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiGeY7xM2dIEMKOcn1jG904iFuwXeCXdRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl8pDGJGT9bxgbQ+0RqmBNzDJrVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9JtENsWohdBozap1sldrVj
 Kn741k5CHh7ZiTCUEOKS9jpV5RCIVbIS7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2l3hW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyil08CDbagO3aPqub+7zkidBAGOHw/kOQPHsbrH+asMDhJ5yb5zexzdop7sb5Sk+uUr
 HixVlUBkAj0hGHdKBXMYXdmMeu9UZF6pHM9HCotIVf3hCRzPdfxtP8SJ8ktYL0q1O1/1vooH
 fMLTNqNX6ZUQTPd9jVDMZSk9N5+dA6mjB6lNja+ZGRtZIZpQgHEo4e2fgbm+CQUIDCwsM8y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg6Zucc8WKBjFyj+L7
 CqsAE8V9bvXvos40NjVnqTY/Y2nJPRzQxhBFG7B4LfoaSSDpji/wZVNWfqjdCzGUD+m472rY
 OhYwq2uMPADm1oW4YNwH6wykPA77trr4bRb0h5lDDPAaFHyUuFsJXyP3M9usKxRx+AG5VvqC
 xzXotQKa6+UPM7FEUIKIFt3Z+uO4vgYhz3O4KlnO079/iJ2oOKKXEg608NgU8CBwG+Z6L8Y/
 No=
IronPort-HdrOrdr: A9a23:hufbQq9tjKQRhlZMxPJuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P
 re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM
 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6
X-IronPort-AV: E=Sophos;i="5.88,209,1635220800"; 
   d="scan'208";a="59629092"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 2/4] x86/cpuid: Factor common parsing out of parse_xen_cpuid()
Date: Wed, 15 Dec 2021 22:21:13 +0000
Message-ID: <20211215222115.6829-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211215222115.6829-1-andrew.cooper3@citrix.com>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

dom0-cpuid= is going to want to reuse the common parsing loop, so factor it
out into parse_cpuid().

Irritatingly, despite being static const, the features[] array gets duplicated
each time parse_cpuid() is inlined.  As it is a large (and ever growing with
new CPU features) datastructure, move it to being file scope so all inlines
use the same single object.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * New

We probably want to be wary of fallout from this pattern elsewhere.  I only
noticed it by chance.
---
 xen/arch/x86/cpuid.c | 45 ++++++++++++++++++++++++++++++++-------------
 1 file changed, 32 insertions(+), 13 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index f63f5efc17f5..e11f5a3c9a6b 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -26,17 +26,26 @@ static const uint32_t __initconst hvm_hap_def_featuremask[] =
     INIT_HVM_HAP_DEF_FEATURES;
 static const uint32_t deep_features[] = INIT_DEEP_FEATURES;
 
-static int __init parse_xen_cpuid(const char *s)
+static const struct feature_name {
+    const char *name;
+    unsigned int bit;
+} feature_names[] __initconstrel = INIT_FEATURE_NAMES;
+
+/*
+ * Parse a list of cpuid feature names -> bool, calling the callback for any
+ * matches found.
+ *
+ * always_inline, because this is init code only and we really don't want a
+ * function pointer call in the middle of the loop.
+ */
+static int __init always_inline parse_cpuid(
+    const char *s, void (*callback)(unsigned int feat, bool val))
 {
     const char *ss;
     int val, rc = 0;
 
     do {
-        static const struct feature {
-            const char *name;
-            unsigned int bit;
-        } features[] __initconstrel = INIT_FEATURE_NAMES;
-        const struct feature *lhs, *rhs, *mid = NULL /* GCC... */;
+        const struct feature_name *lhs, *rhs, *mid = NULL /* GCC... */;
         const char *feat;
 
         ss = strchr(s, ',');
@@ -49,8 +58,8 @@ static int __init parse_xen_cpuid(const char *s)
             feat += 3;
 
         /* (Re)initalise lhs and rhs for binary search. */
-        lhs = features;
-        rhs = features + ARRAY_SIZE(features);
+        lhs = feature_names;
+        rhs = feature_names + ARRAY_SIZE(feature_names);
 
         while ( lhs < rhs )
         {
@@ -72,11 +81,7 @@ static int __init parse_xen_cpuid(const char *s)
 
             if ( (val = parse_boolean(mid->name, s, ss)) >= 0 )
             {
-                if ( !val )
-                    setup_clear_cpu_cap(mid->bit);
-                else if ( mid->bit == X86_FEATURE_RDRAND &&
-                          (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) )
-                    setup_force_cpu_cap(X86_FEATURE_RDRAND);
+                callback(mid->bit, val);
                 mid = NULL;
             }
 
@@ -95,6 +100,20 @@ static int __init parse_xen_cpuid(const char *s)
 
     return rc;
 }
+
+static void __init _parse_xen_cpuid(unsigned int feat, bool val)
+{
+    if ( !val )
+        setup_clear_cpu_cap(feat);
+    else if ( feat == X86_FEATURE_RDRAND &&
+              (cpuid_ecx(1) & cpufeat_mask(X86_FEATURE_RDRAND)) )
+        setup_force_cpu_cap(X86_FEATURE_RDRAND);
+}
+
+static int __init parse_xen_cpuid(const char *s)
+{
+    return parse_cpuid(s, _parse_xen_cpuid);
+}
 custom_param("cpuid", parse_xen_cpuid);
 
 #define EMPTY_LEAF ((struct cpuid_leaf){})
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247620.427022 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcei-0006Mw-4n; Wed, 15 Dec 2021 22:21:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247620.427022; Wed, 15 Dec 2021 22:21:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcei-0006MT-1M; Wed, 15 Dec 2021 22:21:48 +0000
Received: by outflank-mailman (input) for mailman id 247620;
 Wed, 15 Dec 2021 22:21:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=LTfI=RA=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxceg-0005ZJ-Mu
 for xen-devel@lists.xenproject.org; Wed, 15 Dec 2021 22:21:46 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 62bea4b9-5df5-11ec-9e60-abaf8a552007;
 Wed, 15 Dec 2021 23:21:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 62bea4b9-5df5-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639606904;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=1sJTP2vFe7TUxYv8fxcjX4sbJWFBPyrCwJr81dmHE5A=;
  b=QZlKSctVc7MTYak1OnqQnE1rJ+kPqbYcnj8AIElwLlb1oOERCo4OCu1l
   VsStOEmPf8xgpYShKkK3f8ycDfgs7/2SufZBtXUAoSI0o93s3WI4Sz1CW
   diN4uXMYqwseUYdZzdrcpCQW6ORzmgWtNKQeof7dioQ5I5j6+z8+Zp5NN
   s=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bfkV+bUSFRfie8G58yskNAm4RdSahQqULovzT5f9dhAknp/T5GNtOf8ZeXBSQKfRdy3v1vVCBq
 lQK2SsfV1r9xKzD0gbdWMD1TfhIb/Wt9qpEZLfSGLNk+aATyywmS8tpmCzl8ElI6mCPdoXxPe+
 vuFMuj6LGgeodUm6Lw6ZCCVqS2kQEMxy+r970Wzlq01hhdeuJ05wS0Q0KJSJ9q+1Qhd4HdIgC+
 Syt+Kx6eWE3oUW5ox8NazXPJqyPbZLHWRAUvE2I0JW1Xf/ZJArYF4nxOJdso9Q72ECeVqvqvVd
 kQSH6MxtmU0pvDCYpg3fpFzv
X-SBRS: 5.1
X-MesageID: 60126720
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:2F+FPqMM72hx4RrvrR1okMFynXyQoLVcMsEvi/4bfWQNrUp01TEFz
 TccWWyCPf6LYWDwL48latvgo0MH7JLSn9FmQQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s+w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowuktOhvx
 NBkj4WbcSc0fbXxsdgHXDANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgm9p3J4RR662i
 8wxSjVORx38PjB1BFYcLpYgt9imgHf9WmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m66j
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvla6kzUkRdZVOtcjwzmt1+nM3i+lHGctG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DFDFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBvWAlexc0aJ5fEdMMX
 KM1kVkLjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3FmrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMI6b9+KYFjgYpPkeLEo
 iO0VkNCkQKtjnzbMwSaLHtkbeq3D5p4qHs6Ow0qPEqphCd/Mdr+sv9HestlZ6Qj+cxi0eVwE
 6sPdfKfD6kdUT/A4TkcM8Xw9dQwaBSxiAuSFCO5ezxjLYV4TgnE94a8LAvi/SUDFAStss46r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJuepMCMxTOwDeex
 j26OxZAqLmfuZIx/fnImbuA89WjHdxhExcIBGLc97u3a3XXpzLx3Y9aXe+UVjnBT2eoqr66b
 OBYwvygYv0KmFFG79h1H7pxlP9s4tLuo/lRzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXaeeTJcfoMF8NPw50PO2M2MYdliTW8flocl7x4zV6/ebfXEhfV/VWZPex8Feh3FsZ/
 Noc
IronPort-HdrOrdr: A9a23:EaD/Nqp0yV2NSod8zw6W+rcaV5rReYIsimQD101hICG9Evb0qy
 lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM
 VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf
 yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
X-IronPort-AV: E=Sophos;i="5.88,209,1635220800"; 
   d="scan'208";a="60126720"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH v2 3/4] x86/cpuid: Introduce dom0-cpuid command line option
Date: Wed, 15 Dec 2021 22:21:14 +0000
Message-ID: <20211215222115.6829-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211215222115.6829-1-andrew.cooper3@citrix.com>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Specifically, this lets the user opt in to non-default for dom0.

Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply it
to dom0's policy when other tweaks are being made.

As recalculate_cpuid_policy() is an expensive action, and dom0-cpuid= is
likely to only be used by the x86 maintainers for development purposes, forgo
the recalculation in the general case.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>

v2:
 * Rework almost from scratch, on top of broken-out changes.
---
 docs/misc/xen-command-line.pandoc | 17 +++++++++++++++++
 xen/arch/x86/cpuid.c              | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index f7797ea233f9..383a854dec60 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -801,6 +801,23 @@ Controls for how dom0 is constructed on x86 systems.
 
     If using this option is necessary to fix an issue, please report a bug.
 
+### dom0-cpuid
+    = List of comma separated booleans
+
+    Applicability: x86
+
+This option allows for fine tuning of the facilities dom0 will use, after
+accounting for hardware capabilities and Xen settings as enumerated via CPUID.
+
+Options are accepted in positive and negative form, to enable or disable
+specific features, but specify both forms of the same option is undefined.
+All selections via this mechanism are subject to normal CPU Policy safety and
+dependency logic.
+
+This option is intended for developers to opt dom0 into non-default features,
+and is not intended for use in production circumstances.  If using this option
+is necessary to fix an issue, please report a bug.
+
 ### dom0-iommu
     = List of [ passthrough=<bool>, strict=<bool>, map-inclusive=<bool>,
                 map-reserved=<bool>, none ]
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index e11f5a3c9a6b..83a80ba6de70 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -116,6 +116,23 @@ static int __init parse_xen_cpuid(const char *s)
 }
 custom_param("cpuid", parse_xen_cpuid);
 
+static bool __initdata dom0_cpuid_cmdline;
+static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
+static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
+
+static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
+{
+    __set_bit(feat, val ? dom0_enable_feat : dom0_disable_feat);
+}
+
+static int __init parse_dom0_cpuid(const char *s)
+{
+    dom0_cpuid_cmdline = true;
+
+    return parse_cpuid(s, _parse_dom0_cpuid);
+}
+custom_param("dom0-cpuid", parse_dom0_cpuid);
+
 #define EMPTY_LEAF ((struct cpuid_leaf){})
 static void zero_leaves(struct cpuid_leaf *l,
                         unsigned int first, unsigned int last)
@@ -768,6 +785,25 @@ void __init init_dom0_cpuid_policy(struct domain *d)
      */
     if ( cpu_has_arch_caps )
         p->feat.arch_caps = true;
+
+    /* Apply dom0-cpuid= command line settings, if provided. */
+    if ( dom0_cpuid_cmdline )
+    {
+        uint32_t fs[FSCAPINTS];
+        unsigned int i;
+
+        cpuid_policy_to_featureset(p, fs);
+
+        for ( i = 0; i < ARRAY_SIZE(fs); ++i )
+        {
+            fs[i] |= dom0_enable_feat[i];
+            fs[i] &= ~dom0_disable_feat[i];
+        }
+
+        cpuid_featureset_to_policy(fs, p);
+
+        recalculate_cpuid_policy(d);
+    }
 }
 
 void guest_cpuid(const struct vcpu *v, uint32_t leaf,
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Wed Dec 15 22:22:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 15 Dec 2021 22:22:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247634.427035 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcf5-0007yO-Mt; Wed, 15 Dec 2021 22:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247634.427035; Wed, 15 Dec 2021 22:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxcf5-0007yH-J1; Wed, 15 Dec 2021 22:22:11 +0000
Received: by outflank-mailman (input) for mailman id 247634;
 Wed, 15 Dec 2021 22:22:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcf4-0007uO-Kt; Wed, 15 Dec 2021 22:22:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcf4-0005bj-6t; Wed, 15 Dec 2021 22:22:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcf3-0003mc-RR; Wed, 15 Dec 2021 22:22:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxcf3-0007xD-Qt; Wed, 15 Dec 2021 22:22:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=3cdGZjbis7WFFnySsTHn60tZ1kwlTNpAFAUuSvEeFmA=; b=TWXhXs4v1TFj6tn+wuBlGz8uF7
	G6zyp/p13aBOeaSC7o6VEfp66TTeZVbVqStq6LndoBECVO6Nh+Sp8SSYoWzs9l2dcDCP+gCCS3YTV
	9Ra+ptGyfGRyF77NcVpemBSSAg6Wr8mJLsavFkzboklmwhW7hW/2z3IQJN0SsGDOu+T0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167437-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167437: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
X-Osstest-Versions-That:
    xen=8b3cbdbe782cae972e9a47cf22620ebee61a96a6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 15 Dec 2021 22:22:09 +0000

flight 167437 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167437/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24
baseline version:
 xen                  8b3cbdbe782cae972e9a47cf22620ebee61a96a6

Last test of basis   167435  2021-12-15 15:03:05 Z    0 days
Testing same since   167437  2021-12-15 19:01:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8b3cbdbe78..dc27c174b2  dc27c174b2fc1ba0697ed96dc96066c272e09c24 -> smoke


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 00:05:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 00:05:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247660.427054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxeGJ-0003Ih-0i; Thu, 16 Dec 2021 00:04:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247660.427054; Thu, 16 Dec 2021 00:04:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxeGI-0003Ia-U3; Thu, 16 Dec 2021 00:04:42 +0000
Received: by outflank-mailman (input) for mailman id 247660;
 Thu, 16 Dec 2021 00:04:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CQEQ=RB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxeGG-0003IU-MD
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 00:04:40 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c2233ce4-5e03-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 01:04:37 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id i63so35808459lji.3
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 16:04:37 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b2sm552291lfj.280.2021.12.15.16.04.36
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 16:04:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c2233ce4-5e03-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=unsWTcBD4DsgOjFgBqsvdUgt9cZBme6pVJXbQpvys9k=;
        b=jlUamhZkHi6VtvIQgaugk/bYek/ibNYFyrOrinf/gYWc2vbD3BY3j0EoTBiOKSGl4D
         k7wEzX7tR5foMsP3FGrKOXGL4lYpChjk378xNqEqh04kcdX1UNhK8CIhaeMCHgXHB1uc
         7MXX/opLtv/QclFCK09yiuqKpPIfW9n3tWatD7bngnGjs+HeD6Bzqi7CsSJgrS1A0x7Q
         5DV/n6Li/rxenJLsAtUjNOuiONxxgtnP3OxcXZmy5oqcJHaVikVgUHD+stx0SP2z3jrb
         g38as/4mNb1j+uzuACcezYtCNMeCc6TK+kUl1H17+7yZfIRjP8q+SlDHn3ogxV9fip8G
         Z9Og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=unsWTcBD4DsgOjFgBqsvdUgt9cZBme6pVJXbQpvys9k=;
        b=CdyjB/hot/nlspMDPfVqnc6w9E0CMUtrg8tWt9sJej+JFlbfKHx96RQpjxFsdZam6p
         8b3b8eTNAXT+Moc5YBa29Rgz8sq1x5xpyaP4O8okHCqoNc1KWKYEV4DufKkk1jqy5gY6
         WD5yN9b41+nUlB2myOkRZRQ7UVOz1izx2HodKGju+KOEddA8OV/xNAazS13dLCZWUw7M
         taIm32iopuRkxMxVCjF94E4AFFStRmGwfs77BQyHFKHExcz2TqYrQefrtIhlBfLazJb+
         +sNrDFHzylDWpYQCu7xoHd15QijOAZ+waoQb9oMxRUn4R5nkSO6XOUm/kMtTzaMufc/w
         2ZwA==
X-Gm-Message-State: AOAM531w1D7KZE+gDgvSBY7Vk2q/0GwubLHtX4b27myz/X6cZ/6pchl1
	+nWFJdZuMea1u2JiQP8KOQk=
X-Google-Smtp-Source: ABdhPJz/9XsJtFnaF3H0rEufoV1fCBlsfoSDKm/SRlTkvu4ZeEVtRs/FinxHfU6Ldsb6atwIoRfbEA==
X-Received: by 2002:a2e:e09:: with SMTP id 9mr12411742ljo.172.1639613077175;
        Wed, 15 Dec 2021 16:04:37 -0800 (PST)
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
Date: Thu, 16 Dec 2021 02:04:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 14.12.21 11:34, Oleksii Moisieiev wrote:

Hi Oleksii

> Integration of the SCMI mediator with xen libs:
> - add hypercalls to aquire SCI channel and set device permissions
> for DomUs;
> - add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
> - SCI requests redirection from DomUs to Firmware.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   tools/include/xenctrl.h           |   3 +
>   tools/include/xenguest.h          |   2 +
>   tools/libs/ctrl/xc_domain.c       |  23 ++++++
>   tools/libs/guest/xg_dom_arm.c     |   5 +-
>   tools/libs/light/libxl_arm.c      | 122 +++++++++++++++++++++++++++---
>   tools/libs/light/libxl_create.c   |  54 ++++++++++++-
>   tools/libs/light/libxl_dom.c      |   1 +
>   tools/libs/light/libxl_internal.h |   4 +
>   xen/arch/arm/domctl.c             |  15 ++++
>   xen/include/public/domctl.h       |   9 +++
>   10 files changed, 223 insertions(+), 15 deletions(-)
>
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index 07b96e6671..cdd14f465f 100644
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
>   int xc_domain_soft_reset(xc_interface *xch,
>                            uint32_t domid);
>   
> +int xc_domain_add_sci_device(xc_interface *xch,
> +                              uint32_t domid, char *path);
> +
>   #if defined(__i386__) || defined(__x86_64__)
>   /*
>    * PC BIOS standard E820 types and structure.
> diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h
> index 61d0a82f48..35c611ac73 100644
> --- a/tools/include/xenguest.h
> +++ b/tools/include/xenguest.h
> @@ -242,6 +242,8 @@ struct xc_dom_image {
>   
>       /* Number of vCPUs */
>       unsigned int max_vcpus;
> +
> +    xen_pfn_t sci_shmem_gfn;
>   };
>   
>   /* --- arch specific hooks ----------------------------------------- */
> diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> index b155d6afd2..07bb390e17 100644
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -2206,6 +2206,29 @@ int xc_domain_soft_reset(xc_interface *xch,
>       domctl.domain = domid;
>       return do_domctl(xch, &domctl);
>   }
> +
> +int xc_domain_add_sci_device(xc_interface *xch,
> +                              uint32_t domid, char *path)
> +{
> +    size_t size = strlen(path);
> +    int rc;
> +    DECLARE_DOMCTL;
> +    DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN);
> +
> +    if ( xc_hypercall_bounce_pre(xch, path) )
> +        return -1;
> +
> +    domctl.cmd = XEN_DOMCTL_add_sci_device;
> +    domctl.domain = domid;
> +    domctl.u.sci_device_op.size = size;
> +    set_xen_guest_handle(domctl.u.sci_device_op.path, path);
> +    rc = do_domctl(xch, &domctl);
> +
> +    xc_hypercall_bounce_post(xch, path);
> +
> +    return rc;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c
> index 5e3b76355e..368a670c46 100644
> --- a/tools/libs/guest/xg_dom_arm.c
> +++ b/tools/libs/guest/xg_dom_arm.c
> @@ -25,11 +25,12 @@
>   
>   #include "xg_private.h"
>   
> -#define NR_MAGIC_PAGES 4
> +#define NR_MAGIC_PAGES 5
>   #define CONSOLE_PFN_OFFSET 0
>   #define XENSTORE_PFN_OFFSET 1
>   #define MEMACCESS_PFN_OFFSET 2
>   #define VUART_PFN_OFFSET 3
> +#define SCI_SHMEM_OFFSET 4
>   
>   #define LPAE_SHIFT 9
>   
> @@ -69,11 +70,13 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
>       dom->console_pfn = base + CONSOLE_PFN_OFFSET;
>       dom->xenstore_pfn = base + XENSTORE_PFN_OFFSET;
>       dom->vuart_gfn = base + VUART_PFN_OFFSET;
> +    dom->sci_shmem_gfn = base + SCI_SHMEM_OFFSET;
>   
>       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
>       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
>       xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET);
>       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn);
> +    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->sci_shmem_gfn);
>   
>       xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
>               dom->console_pfn);
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index eef1de0939..73ef591822 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -8,6 +8,8 @@
>   #include <assert.h>
>   #include <xen/device_tree_defs.h>
>   
> +#define SCMI_NODE_PATH      "/firmware/scmi"
> +
>   static const char *gicv_to_string(libxl_gic_version gic_version)
>   {
>       switch (gic_version) {
> @@ -101,6 +103,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>           return ERROR_FAIL;
>       }
>   
> +    switch (d_config->b_info.sci) {
> +    case LIBXL_SCI_TYPE_NONE:
> +        config->arch.sci_type = XEN_DOMCTL_CONFIG_SCI_NONE;
> +        break;
> +    case LIBXL_SCI_TYPE_SCMI_SMC:
> +        config->arch.sci_type = XEN_DOMCTL_CONFIG_SCI_SCMI_SMC;
> +        break;
> +    default:
> +        LOG(ERROR, "Unknown SCI type %d",
> +            d_config->b_info.sci);
> +        return ERROR_FAIL;
> +    }
> +
>       return 0;
>   }
>   
> @@ -122,6 +137,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
>       }
>   
>       state->clock_frequency = config->arch.clock_frequency;
> +    state->sci_agent_paddr = config->arch.sci_agent_paddr;
>   
>       return 0;
>   }
> @@ -502,9 +518,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
>       int res;
>       LOG(DEBUG, "Creating OP-TEE node in dtb");
>   
> -    res = fdt_begin_node(fdt, "firmware");
> -    if (res) return res;
> -
>       res = fdt_begin_node(fdt, "optee");
>       if (res) return res;
>   
> @@ -517,9 +530,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
>       res = fdt_end_node(fdt);
>       if (res) return res;
>   
> -    res = fdt_end_node(fdt);
> -    if (res) return res;
> -
>       return 0;
>   }
>   
> @@ -902,10 +912,9 @@ static int copy_node(libxl__gc *gc, void *fdt, void *pfdt,
>       return 0;
>   }
>   
> -static int copy_node_by_path(libxl__gc *gc, const char *path,
> -                             void *fdt, void *pfdt)
> +static int get_path_nodeoff(const char *path, void *pfdt)
>   {
> -    int nodeoff, r;
> +    int nodeoff;
>       const char *name = strrchr(path, '/');
>   
>       if (!name)
> @@ -925,12 +934,101 @@ static int copy_node_by_path(libxl__gc *gc, const char *path,
>       if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
>           return -FDT_ERR_NOTFOUND;
>   
> +    return nodeoff;
> +}
> +
> +static int copy_node_by_path(libxl__gc *gc, const char *path,
> +                             void *fdt, void *pfdt)
> +{
> +    int nodeoff, r;
> +
> +    nodeoff = get_path_nodeoff(path, pfdt);
> +    if (nodeoff < 0)
> +        return nodeoff;
> +
>       r = copy_node(gc, fdt, pfdt, nodeoff, 0);
>       if (r) return r;
>   
>       return 0;
>   }
>   
> +static int get_node_phandle(const char *path, void *pfdt, uint32_t *phandle)
> +{
> +    int nodeoff;
> +    const char *name = strrchr(path, '/');
> +
> +    if (!name)
> +        return -FDT_ERR_INTERNAL;
> +
> +    name++;
> +    nodeoff = fdt_path_offset(pfdt, path);
> +    if (nodeoff < 0)
> +        return nodeoff;
> +
> +    *phandle = fdt_get_phandle(pfdt, nodeoff);
> +    return 0;
> +}
> +
> +static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt,
> +                           struct xc_dom_image *dom)
> +{
> +    int res;
> +    char buf[64];
> +    uint32_t phandle = 0;
> +
> +    res = get_node_phandle("/scp-shmem", pfdt, &phandle);
> +    if (res) return res;
> +
> +    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
> +             dom->sci_shmem_gfn << XC_PAGE_SHIFT);
> +    res = fdt_begin_node(fdt, buf);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 1, "arm,scmi-shmem");
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +                    GUEST_ROOT_SIZE_CELLS, 1,
> +                    dom->sci_shmem_gfn << XC_PAGE_SHIFT, XC_PAGE_SHIFT);
> +    if (res) return res;
> +
> +    LOG(DEBUG, "scmi: setting phandle = %u\n", phandle);
> +    res = fdt_property_cell(fdt, "phandle", phandle);
> +    if (res) return res;
> +
> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
> +static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, int tee,
> +                              int sci)
> +{
> +    int res;
> +
> +    if ((tee != LIBXL_TEE_TYPE_OPTEE) && (sci != LIBXL_SCI_TYPE_NONE))
> +        return 0;
> +
> +    res = fdt_begin_node(fdt, "firmware");
> +    if (res) return res;
> +
> +    if (tee == LIBXL_TEE_TYPE_OPTEE) {
> +       res = make_optee_node(gc, fdt);
> +       if (res) return res;
> +    }
> +
> +    if (sci == LIBXL_SCI_TYPE_SCMI_SMC) {
> +        res = copy_node_by_path(gc, SCMI_NODE_PATH, fdt, pfdt);
> +        if (res) return res;
> +    }
> +
> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
>   /*
>    * The partial device tree is not copied entirely. Only the relevant bits are
>    * copied to the guest device tree:
> @@ -1088,8 +1186,10 @@ next_resize:
>           if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>               FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
>   
> -        if (info->tee == LIBXL_TEE_TYPE_OPTEE)
> -            FDT( make_optee_node(gc, fdt) );
> +        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->sci) );
> +
> +        if (info->sci == LIBXL_SCI_TYPE_SCMI_SMC)
> +            FDT( make_scmi_shmem_node(gc, fdt, pfdt, dom) );
>   
>           if (d_config->num_pcidevs)
>               FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index dcd09d32ba..c7372fd344 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -596,6 +596,37 @@ out:
>       return ret;
>   }
>   
> +static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
> +                         uint64_t guest_addr)
> +{
> +    int ret;
> +    uint64_t _paddr_pfn = paddr >> XC_PAGE_SHIFT;
> +    uint64_t _guest_pfn = guest_addr >> XC_PAGE_SHIFT;
> +
> +    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
> +
> +    ret = xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1, 1);
> +    if (ret < 0) {
> +        LOG(ERROR,
> +              "failed give domain access to iomem page %"PRIx64,
> +             _paddr_pfn);
> +        return ret;
> +    }
> +
> +    ret = xc_domain_memory_mapping(CTX->xch, domid,
> +                                   _guest_pfn, _paddr_pfn,
> +                                   1, 1);
> +    if (ret < 0) {
> +        LOG(ERROR,
> +              "failed to map to domain iomem page %"PRIx64
> +              " to guest address %"PRIx64,
> +              _paddr_pfn, _guest_pfn);
> +        return ret;
> +    }
> +
> +    return 0;
> +}
> +
>   int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>                          libxl__domain_build_state *state,
>                          uint32_t *domid, bool soft_reset)
> @@ -762,6 +793,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>           goto out;
>       }
>   
> +    if (state->sci_agent_paddr != 0) {
> +        ret = map_sci_page(gc, *domid, state->sci_agent_paddr,
> +                            state->sci_shmem_gfn << XC_PAGE_SHIFT);
> +        if (ret < 0) {
> +            LOGED(ERROR, *domid, "map SCI page fail");
> +            rc = ERROR_FAIL;
> +            goto out;
> +        }
> +    }
> +
>       dom_path = libxl__xs_get_dompath(gc, *domid);
>       if (!dom_path) {
>           rc = ERROR_FAIL;
> @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
>   {
>       AO_GC;
>       libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
> -    int i, rc = 0;
> +    int i, rc = 0, rc_sci = 0;
>   
>       for (i = 0; i < d_config->num_dtdevs; i++) {
>           const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
>   
>           LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
>           rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> -        if (rc < 0) {
> -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
> +
> +        if ((rc < 0) && (rc_sci < 0)) {
> +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> +                 "xc_domain_add_sci_device failed: %d",
> +                 rc, rc_sci);
>               goto out;
>           }
> +
> +        if (rc)
> +            rc = rc_sci;


If I get this code right, it sounds like the dom.cfg's dtdev property is 
reused to describe sci devices as well, but the libxl__add_dtdevs() does 
not (and can not) differentiate them. So it has no option but to send 
two domctls for each device in dtdevs[] hoping to at least one domctl to 
succeeded. Or I really missed something?

It feels to me that:
  - either new dom.cfg's property could be introduced (scidev?) to 
describe sci devices together with new parsing logic/management code, so 
you will end up having new libxl__add_scidevs() to invoke 
XEN_DOMCTL_add_sci_device,
so no mixing things.
  - or indeed dtdev logic could be *completely* reused including 
extending XEN_DOMCTL_assign_device to cover your use-case, although 
sounds generic, it is used to describe devices for the passthrough (to 
configure an IOMMU for the device), in that case you wouldn't need an 
extra XEN_DOMCTL_add_sci_device introduced by current patch.

Personally I would use the first option as I am not sure that second 
option is conceptually correct && possible. I would leave this for the 
maintainers to clarify.




>       }
>   
>   out:
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index fe9f760f71..b1d288a8b9 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -710,6 +710,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>           state->console_mfn = dom->console_pfn;
>           state->store_mfn = dom->xenstore_pfn;
>           state->vuart_gfn = dom->vuart_gfn;
> +        state->sci_shmem_gfn = dom->sci_shmem_gfn;
>       } else {
>           state->console_mfn = xc_dom_p2m(dom, dom->console_pfn);
>           state->store_mfn = xc_dom_p2m(dom, dom->xenstore_pfn);
> diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
> index 0b4671318c..f9f9cc633a 100644
> --- a/tools/libs/light/libxl_internal.h
> +++ b/tools/libs/light/libxl_internal.h
> @@ -1407,6 +1407,10 @@ typedef struct {
>       /* Whether this domain is being migrated/restored, or booting fresh.  Only
>        * applicable to the primary domain, not support domains (e.g. stub QEMU). */
>       bool restore;
> +
> +    /* sci channel paddr to be set to device-tree node */
> +    uint64_t sci_agent_paddr;
> +    xen_pfn_t sci_shmem_gfn;
>   } libxl__domain_build_state;
>   
>   _hidden void libxl__domain_build_state_init(libxl__domain_build_state *s);
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 6245af6d0b..ba200407da 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -4,6 +4,7 @@
>    * Copyright (c) 2012, Citrix Systems
>    */
>   
> +#include <asm/sci/sci.h>
>   #include <xen/errno.h>
>   #include <xen/guest_access.h>
>   #include <xen/hypercall.h>
> @@ -175,6 +176,20 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>   
>           return rc;
>       }
> +    case XEN_DOMCTL_add_sci_device:
> +    {
> +        int rc;
> +        struct dt_device_node *dev;
> +
> +        rc = dt_find_node_by_gpath(domctl->u.sci_device_op.path,
> +                                   domctl->u.sci_device_op.size,
> +                                   &dev);
> +        if ( rc )
> +            return rc;
> +
> +        return sci_add_dt_device(d, dev);
> +    }
> +
>       default:
>       {
>           int rc;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b85e6170b0..671c72c3e8 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>   #define XEN_DOMCTL_vmtrace_get_option         5
>   #define XEN_DOMCTL_vmtrace_set_option         6
>   };
> +
> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> +struct xen_domctl_sci_device_op {
> +    uint32_t size; /* Length of the path */
> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> +};
> +
>   typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
>   DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
>   
> @@ -1265,6 +1272,7 @@ struct xen_domctl {
>   #define XEN_DOMCTL_get_cpu_policy                82
>   #define XEN_DOMCTL_set_cpu_policy                83
>   #define XEN_DOMCTL_vmtrace_op                    84
> +#define XEN_DOMCTL_add_sci_device                85
>   #define XEN_DOMCTL_gdbsx_guestmemio            1000
>   #define XEN_DOMCTL_gdbsx_pausevcpu             1001
>   #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
> @@ -1326,6 +1334,7 @@ struct xen_domctl {
>           struct xen_domctl_psr_alloc         psr_alloc;
>           struct xen_domctl_vuart_op          vuart_op;
>           struct xen_domctl_vmtrace_op        vmtrace_op;
> +        struct xen_domctl_sci_device_op     sci_device_op;
>           uint8_t                             pad[128];
>       } u;
>   };

I assume the XSM needs updating (adding new hook, etc).


-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 00:34:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 00:34:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247669.427065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxeiD-00070L-BP; Thu, 16 Dec 2021 00:33:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247669.427065; Thu, 16 Dec 2021 00:33:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxeiD-00070E-8A; Thu, 16 Dec 2021 00:33:33 +0000
Received: by outflank-mailman (input) for mailman id 247669;
 Thu, 16 Dec 2021 00:33:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CQEQ=RB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxeiC-000708-45
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 00:33:32 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id caf50057-5e07-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 01:33:30 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id u22so35831103lju.7
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 16:33:30 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id f24sm561471lfe.247.2021.12.15.16.33.28
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 15 Dec 2021 16:33:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: caf50057-5e07-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=uXIYr6m+OUKat4C/s5i8qxUUG7WvMYSYMLbIJZbMcgI=;
        b=kHafZPqOZ/mX2oUWNkuUpOF//35rshoQpX2/iD7LbxROT5mUGJxthEDUKfrpfVkZP7
         E0N+Ps6V+2VbamZeKA9kVrVy3++/Wy2RenQqxbT0X6WRo+yqdXqd2m/sLzwM56AF7Lgc
         Qz2hgYYCpZT1Bb7ekAE31pgfeg4fIwwm0/FvIy48IZ6x7Ob5GsF4ESj846hMlatOiMGh
         kQw6Q6DJhlWozksrszGY50O8GOB7v5RlVgURGlsvlYYeQ/OKOYOUdBnc/5dai+3nugqL
         untmgCtfoHdaEp8U1YBIxgy8eVf0DYCE10ondjFKmAzle+najBWcB0u8J7ckCmno9850
         xtgQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=uXIYr6m+OUKat4C/s5i8qxUUG7WvMYSYMLbIJZbMcgI=;
        b=Vs32QcI0u5IeZJoDSkrEO80yFiaqMOFRNcyvgcdHMKetFzJt7hwc0ta3TIDHz3BDsD
         NP5MV/I+Ai7Le0qqLycEXElXdLFPsA19JOZK2uSWdlQUijDzKE4c+ANXf+Y9fKrG8B0u
         bea1tLHBhetR/CsLt478kS1Hux+jObPMOMJCpvihFHcrax8lzot9r5M3O23/aichwdPh
         8rbnJ+L3I1EGdXHicWDDAXhnK29uzNBcAzHZjQVENcvEWmeukL+dAJrmQJPFH41c2xuF
         Yowig+lrf9SFL75xxK5H3cx/0aGzIfx0HtWI9D4Ua5ezbHH+qtGAyVQDn/sJymh5F66H
         wMrQ==
X-Gm-Message-State: AOAM533Wc/CTjrez4U7rqWS9zGN6RIekwKIsxhjQpCBF8ZuNioE/KfPH
	8lulYjoJgJrb4c7mwSQFYC8=
X-Google-Smtp-Source: ABdhPJxjifhiEgt4xyU2JYf8aLBNVZI/qPOyYkj4qC/pnDIusDdnFlOfClyr6dPG/YDKJbmfjuwp8Q==
X-Received: by 2002:a2e:bf05:: with SMTP id c5mr13436830ljr.104.1639614810070;
        Wed, 15 Dec 2021 16:33:30 -0800 (PST)
Subject: Re: [RFC v1 0/5] Introduce SCI-mediator feature
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <c8739251-3e13-2337-0ae8-cfae59397251@gmail.com>
Date: Thu, 16 Dec 2021 02:33:28 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <cover.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 14.12.21 11:34, Oleksii Moisieiev wrote:


Hi Oleksii

> Introducing the feature, called SCI mediator.
> It's purpose is to redirect SCMI requests from the domains to firmware
> (SCP, ATF etc), which controls the power/clock/resets etc.
> The idea is to make SCP firmware (or similar, such as AT-F) responsible for
> control power/clock/resets and provide SCMI interface so controls can be shared
> between the Domains.
> Originally, we've met a problem, that the devices, shared between different
> Domains, can't have an access to HW registers to work with clocks/resets/power
> etc. You have to pass cpg to the Domain, so the devices can access HW directly.
> The solution for this is to move HW controls over power/clock/resets to
> SCP firmware and use Linux-kernel SCMI drivers to pass requests to SCP.
> Xen is responsible for permissions setting, so Domain can access only to
> power/clock/resets which are related to this Domain. Also XEN is the mediator
> which redirects SCMI requests, adding agentID so firmware should know the
> sender.
> SMC is currently used as transport, but this should be configurable.
>
> Here is the high level design:
>
> SCI (System Control Interface) feature can be enabled in xen_config:
>> CONFIG_SCI=y
> Mediator can be configured:
>> CONFIG_SCMI_SMC=y
> Currently, only SCMI_SMC mediator is implemented, which using shared memory
> region to communicate with firmware and SMC as transport.
>
> Xen scmi should be configured in the device-tree.
> Format is the following:
> 	cpu_scp_shm: scp-shmem@0x53FF0000 {
> 		compatible = "arm,scmi-shmem";
> 		reg = <0x0 0x53FF0000 0x0 0x1000>;
> 	};
>
> 	firmware {
> 		scmi {
> 			compatible = "arm,scmi-smc";
> 			arm,smc-id = <0x82000002>;
> 			shmem = <&cpu_scp_shm>;
> 			#address-cells = <1>;
> 			#size-cells = <0>;
>
> 			scmi_power: protocol@11 {
> 				reg = <0x11>;
> 				#power-domain-cells = <1>;
> 			};
>
> 			scmi_clock: protocol@14 {
> 				reg = <0x14>;
> 				#clock-cells = <1>;
> 			};
>
> 			scmi_reset: protocol@16 {
> 				reg = <0x16>;
> 				#reset-cells = <1>;
> 			};
> 		};
> 	};
>
> Where:
> &cpu_scp_shm is the shared memory for scmi buffers;
> 0x53FF0000, size 0x1000 is the platform specific free address, which provide
> space for the communication.
> &scmi node, which should be copied to Dom0 device-tree.
>
> Device configured to use scmi:
> &avb {
> 	scmi_devid = <0>;
> 	clocks = <&scmi_clock 0>;
> 	power-domains = <&scmi_power 0>;
> 	resets = <&scmi_reset 0>;
> };
>
> Where:
> scmi_devid - id from the firmware, which is assigned for AVB.
>
> During initialization, XEN scans probes the first SCI-mediator driver which has
> matching node in the device-tree. If no device-tree was provided, then the
> first registered mediator driver should be probed.
>
> DomX should be configured:
> Device-tree should include the same nodes, described above.
> &cpu_scp_shm should be altered during domain creation. Xen allocates free page
> from the memory region, provided in &cpu_scp_shm in XEN device-tree, so each
> domain should have unique page. Nodes &cpu_scp_shm and /firmware/scmi should be
> copied from partial device-tree to domain device-tree, so kernel can initialize
> scmi driver.
>
> SCI mediator can be enabled in dom.cfg the following way:
>> sci = "scmi_smc"
> which sets scmi_smc to be used for the domain.


Great work! I can imagine this is going to be nice feature once upstreamed.

I am wondering, would the Xen (with the required updates of course) also 
be able to send it's own requests to the SCP? For example, to control 
overall system performance (CPU frequency)

or other let's say important power management task.


>
> Oleksii Moisieiev (5):
>    xen/arm: add support for Renesas R-Car Gen3 platform
>    xen/arm: add generic SCI mediator framework
>    xen/arm: introduce SCMI-SMC mediator driver
>    tools/arm: add "scmi_smc" option to xl.cfg
>    xen/arm: add SCI mediator support for DomUs
>
>   MAINTAINERS                       |   6 +
>   docs/man/xl.cfg.5.pod.in          |  22 +
>   tools/include/libxl.h             |   5 +
>   tools/include/xenctrl.h           |   3 +
>   tools/include/xenguest.h          |   2 +
>   tools/libs/ctrl/xc_domain.c       |  23 +
>   tools/libs/guest/xg_dom_arm.c     |   5 +-
>   tools/libs/light/libxl_arm.c      | 122 ++++-
>   tools/libs/light/libxl_create.c   |  54 +-
>   tools/libs/light/libxl_dom.c      |   1 +
>   tools/libs/light/libxl_internal.h |   4 +
>   tools/libs/light/libxl_types.idl  |   6 +
>   tools/xl/xl_parse.c               |   9 +
>   xen/arch/arm/Kconfig              |  10 +
>   xen/arch/arm/Makefile             |   1 +
>   xen/arch/arm/domain.c             |  24 +
>   xen/arch/arm/domain_build.c       |  11 +
>   xen/arch/arm/domctl.c             |  15 +
>   xen/arch/arm/platforms/Makefile   |   1 +
>   xen/arch/arm/platforms/rcar3.c    |  47 ++
>   xen/arch/arm/sci/Kconfig          |  10 +
>   xen/arch/arm/sci/Makefile         |   2 +
>   xen/arch/arm/sci/sci.c            | 128 +++++
>   xen/arch/arm/sci/scmi_smc.c       | 795 ++++++++++++++++++++++++++++++
>   xen/arch/arm/setup.c              |   1 +
>   xen/arch/arm/xen.lds.S            |   7 +
>   xen/include/asm-arm/domain.h      |   4 +
>   xen/include/asm-arm/sci/sci.h     | 162 ++++++
>   xen/include/public/arch-arm.h     |  11 +
>   xen/include/public/domctl.h       |   9 +
>   30 files changed, 1485 insertions(+), 15 deletions(-)
>   create mode 100644 xen/arch/arm/platforms/rcar3.c
>   create mode 100644 xen/arch/arm/sci/Kconfig
>   create mode 100644 xen/arch/arm/sci/Makefile
>   create mode 100644 xen/arch/arm/sci/sci.c
>   create mode 100644 xen/arch/arm/sci/scmi_smc.c
>   create mode 100644 xen/include/asm-arm/sci/sci.h
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 01:46:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 01:46:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247681.427077 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxfqj-00008P-Uf; Thu, 16 Dec 2021 01:46:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247681.427077; Thu, 16 Dec 2021 01:46:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxfqj-00008G-PQ; Thu, 16 Dec 2021 01:46:25 +0000
Received: by outflank-mailman (input) for mailman id 247681;
 Thu, 16 Dec 2021 01:46:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=LurM=RB=ti.com=nm@srs-se1.protection.inumbo.net>)
 id 1mxfqh-00008A-Tf
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 01:46:24 +0000
Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f6bdd44c-5e11-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 02:46:20 +0100 (CET)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
 by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BG1jRfh031919;
 Wed, 15 Dec 2021 19:45:27 -0600
Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26])
 by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BG1jRfp012888
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Wed, 15 Dec 2021 19:45:27 -0600
Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE115.ent.ti.com
 (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 15
 Dec 2021 19:45:27 -0600
Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE101.ent.ti.com
 (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via
 Frontend Transport; Wed, 15 Dec 2021 19:45:27 -0600
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153])
 by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BG1jRLZ081996;
 Wed, 15 Dec 2021 19:45:27 -0600
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6bdd44c-5e11-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;
	s=ti-com-17Q1; t=1639619127;
	bh=x5y0W7NcQu8KFCCs6SOY3R1ieqDIaIpGqjfY0/mf1aE=;
	h=Date:From:To:CC:Subject:References:In-Reply-To;
	b=J5phN9h68zO6NinAKtCP/hmHaPgLgmqEGVPSbOywTVyespzsahOYEMGicemzLRq2Y
	 21pPWpguPw6fDybn84tKdvQctjmv68Dr1n2Jr/sg63dZkF5qXYf/uErtLqrDj5vXPI
	 1ZEaLuHXnc4osJDl09QfWl3URXAzeFJSZ4FNP8zc=
Date: Wed, 15 Dec 2021 19:45:27 -0600
From: Nishanth Menon <nm@ti.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
        Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
        <linux-pci@vger.kernel.org>, Cedric Le Goater <clg@kaod.org>,
        Juergen Gross
	<jgross@suse.com>, <xen-devel@lists.xenproject.org>,
        Arnd Bergmann
	<arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin
 Herrenschmidt <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas
	<bhelgaas@google.com>,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor
	<laurentiu.tudor@nxp.com>,
        Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar
	<ssantosh@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, Vinod Koul
	<vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>, Mark Rutland
	<mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>,
        Joerg Roedel <joro@8bytes.org>, <iommu@lists.linux-foundation.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>,
        Sinan Kaya <okaya@kernel.org>, <linux-wireless@vger.kernel.org>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Message-ID: <20211216014527.5d3sqs2klrqjmm2k@lunacy>
References: <20211213182958.ytj4m6gsg35u77cv@detonator>
 <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider>
 <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx>
 <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly>
 <87h7basx36.ffs@tglx>
 <87zgp1rge4.ffs@tglx>
 <87wnk5rfkt.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87wnk5rfkt.ffs@tglx>
User-Agent: NeoMutt/20171215
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180

Hi Thomas,

On 17:35-20211215, Thomas Gleixner wrote:
>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.2-part-3

As you helped offline, summarizing the details on part3 of the series:

I was seeing failure[1] of NFS(DMA) on all TI K3 platforms:

[    1.013258] ti-bcdma 485c0100.dma-controller: Number of rings: 68
[    1.019963] ti-bcdma 485c0100.dma-controller: Failed to allocate IRQs -28
[    1.026938] ti-bcdma 485c0100.dma-controller: Failed to allocate MSI interrupts

Rationale as you explained:
"
-28 is ENOSPC, which is returned when the interrupt allocation in the
 MSI domain fails. Fix below.
"

Which turned out to be the fixup[2] you suggested and I confirm that
fixes the problem for me.

With the fixup in place:

Tested-by: Nishanth Menon <nm@ti.com>

for part 3 of the series as well.

Thanks once again for your help. Hope we can roll in the fixes for
part3.

[1] https://gist.github.com/nmenon/5971ab27aa626c022e276cc946e4b6c3
[2]
--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -68,6 +68,7 @@ static int ti_sci_inta_msi_alloc_descs(s
 	int set, i, count = 0;
 
 	memset(&msi_desc, 0, sizeof(msi_desc));
+	msi_desc.nvec_used = 1;
 
 	for (set = 0; set < res->sets; set++) {
 		for (i = 0; i < res->desc[set].num; i++, count++) {
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 02:11:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 02:11:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247686.427091 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxgEV-0004DM-SH; Thu, 16 Dec 2021 02:10:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247686.427091; Thu, 16 Dec 2021 02:10:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxgEV-0004DF-Or; Thu, 16 Dec 2021 02:10:59 +0000
Received: by outflank-mailman (input) for mailman id 247686;
 Thu, 16 Dec 2021 02:10:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxgET-0004D9-QN
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 02:10:57 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 66ead2cb-5e15-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 03:10:56 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 4917DB81ECE;
 Thu, 16 Dec 2021 02:10:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9044BC36AE0;
 Thu, 16 Dec 2021 02:10:53 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66ead2cb-5e15-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639620654;
	bh=y5Ec8S/n/WE66K67y3922wUWtJSDkKPWi0sFUJg8h+A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=on4vKIpR0OsAKsnlUUt01No+4hrQnJwqjsFHQx/tCbtrrW6gTgv2DE9flIeheJiYi
	 SWGkxr2W85x8ivCRF6z+tYiIOgIU/Sq2oSrdZbsTvsoIYzF8/bOxwIkQwRKFOMvWl6
	 iC5rbid0Nu0yGDxkxHM1Gr5ktd17HVtRR5NTW0U7Ri/Nma62EL8vVLvj2lfikxRFmi
	 hIYccVUWlhwYT7xygtrOJyta/cQcOQBUOb5LakZ8QGxEZdV9NVGyeylCtites0PRU1
	 vrORkqLIhKgUnGcgwt6k1gJ1WlKQP9Tl+UaGB8ecrwcP4IyA1LeASMdBbis4fM0YLP
	 PHFaH/sG8Y5Pw==
Date: Wed, 15 Dec 2021 18:10:53 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 15 Dec 2021, Juergen Gross wrote:
> On 14.12.21 18:36, Julien Grall wrote:
> > Hi,
> > 
> > On 08/12/2021 15:55, Juergen Gross wrote:
> > > Today most hypercall handlers have a return type of long, while the
> > > compat ones return an int. There are a few exceptions from that rule,
> > > however.
> > 
> > So on Arm64, I don't think you can make use of the full 64-bit because a
> > 32-bit domain would not be able to see the top 32-bit.
> > 
> > In fact, this could potentially cause us some trouble (see [1]) in Xen.
> > So it feels like the hypercalls should always return a 32-bit signed value
> > on Arm.
> 
> This would break hypercalls like XENMEM_maximum_ram_page which are able
> to return larger values, right?
> 
> > The other advantage is it would be clear that the top 32-bit are not
> > usuable. Stefano, what do you think?
> 
> Wouldn't it make more sense to check the return value to be a sign
> extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
> 
> The question is what to return if this is not the case. -EDOM?


I can see where Julien is coming from: we have been trying to keep the
arm32 and arm64 ABIs identical since the beginning of the project. So,
like Julien, my preference would be to always return 32-bit on ARM, both
aarch32 and aarch64. It would make things simple.

The case of XENMEM_maximum_ram_page is interesting but it is not a
problem in reality because the max physical address size is only 40-bit
for aarch32 guests, so 32-bit are always enough to return the highest
page in memory for 32-bit guests.

So XENMEM_maximum_ram_page could be the exception and return "long"
which is 4 bytes on aarch32 and 8 bytes on aarch64, and it is exactly
what we need.


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 02:34:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 02:34:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247691.427101 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxgah-0006k6-PS; Thu, 16 Dec 2021 02:33:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247691.427101; Thu, 16 Dec 2021 02:33:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxgah-0006jz-Lx; Thu, 16 Dec 2021 02:33:55 +0000
Received: by outflank-mailman (input) for mailman id 247691;
 Thu, 16 Dec 2021 02:33:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxgag-0006jt-O8
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 02:33:54 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9b147d60-5e18-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 03:33:52 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C9CEC61BA6;
 Thu, 16 Dec 2021 02:33:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1AC7C36AE0;
 Thu, 16 Dec 2021 02:33:49 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9b147d60-5e18-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639622030;
	bh=t1dWWSlrI6fTqyle3hnf4XwkyWVvbdivW135Nv5Dkyk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=NuN/Nf+8Wa65Kpxo2xkFVWZLZoiHymEmkG0FoRzRHKhbT0hnHY5s3bDCcVu4sHmo1
	 oW+4+lqphoct6XDKiJwsAbomkG5VOKBOJ7J2869OmiDtjWIRHFJM/ouKodBem4okAL
	 CTpTyI3KZ0nwtSOUIjZaz4c3tY1o8vL5hoXJDJ3cdPX+gvxbHMeO8RANhpjdppnzWp
	 STMQ2+7HK5IFzrJdNvaGW2X4w6F2SbRFt2M1Bwy8BVaqA+1cLSkdRBMAG9ONnIO7Zm
	 VyRLz6YR5K2EqEdCiZqzt48ekx6upV6gdewymKaC0WNce3iqONjBNnX+paaF3MVY1f
	 nMopGdHY591ag==
Date: Wed, 15 Dec 2021 18:33:50 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <rahul.singh@arm.com>
cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
In-Reply-To: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
Message-ID: <alpine.DEB.2.22.394.2112151817190.3376@ubuntu-linux-20-04-desktop>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 14 Dec 2021, Rahul Singh wrote:
> IO ports on ARM don't exist so all IO ports related hypercalls are going
> to fail on ARM when we passthrough a PCI device.
> Failure of xc_domain_ioport_permission(..) would turn into a critical
> failure at domain creation. We need to avoid this outcome, instead we
> want to continue with domain creation as normal even if
> xc_domain_ioport_permission(..) fails. XEN_DOMCTL_ioport_permission
> is not implemented on ARM so it would return -ENOSYS.
> 
> To solve above issue remove PCI I/O ranges property value from dom0
> device tree node so that dom0 linux will not allocate I/O space for PCI
> devices if pci-passthrough is enabled.
> 
> Another valid reason to remove I/O ranges is that PCI I/O space are not
> mapped to dom0 when PCI passthrough is enabled, also there is no vpci
> trap handler register for IO bar.
> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>  xen/arch/arm/domain_build.c   | 14 +++++++
>  xen/common/device_tree.c      | 72 +++++++++++++++++++++++++++++++++++
>  xen/include/xen/device_tree.h | 10 +++++
>  3 files changed, 96 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d02bacbcd1..60f6b2c73b 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -749,6 +749,11 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>                  continue;
>          }
>  
> +        if ( is_pci_passthrough_enabled() &&
> +                dt_device_type_is_equal(node, "pci") )
> +            if ( dt_property_name_is_equal(prop, "ranges") )
> +                continue;

It looks like we are skipping the "ranges" property entirely for the PCI
node, is that right? Wouldn't that also remove the other (not ioports)
address ranges?


>          res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
>  
>          if ( res )
> @@ -769,6 +774,15 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>              if ( res )
>                  return res;
>          }
> +
> +        /*
> +         * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled,
> +         * also there is no trap handler registered for IO bar therefor remove
> +         * the IO range property from the device tree node for dom0.
> +         */
> +        res = dt_pci_remove_io_ranges(kinfo->fdt, node);
> +        if ( res )
> +            return res;

I tried to apply this patch to staging to make it easier to review but I
think this chuck got applied wrongly: I can see
dt_pci_remove_io_ranges() added to the function "handle_prop_pfdt" which
is for guest partial DTBs and not for dom0.

Is dt_pci_remove_io_ranges() meant to be called from write_properties
instead? It looks like it would be best to call it from
write_properties, maybe it could be combined with the other new check
just above in this patch?


>      /*
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..9fa25f6723 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -2195,6 +2195,78 @@ int dt_get_pci_domain_nr(struct dt_device_node *node)
>      return (u16)domain;
>  }
>  
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *dev)
> +{
> +    const struct dt_device_node *parent = NULL;
> +    const struct dt_bus *bus, *pbus;
> +    unsigned int rlen;
> +    int na, ns, pna, pns, rone, ret;
> +    const __be32 *ranges;
> +    __be32 regs[((GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS + 1)
> +               * 2];
> +    __be32 *addr = &regs[0];
> +
> +    bus = dt_match_bus(dev);
> +    if ( !bus )
> +        return 0; /* device is not a bus */
> +
> +    parent = dt_get_parent(dev);
> +    if ( parent == NULL )
> +        return -EINVAL;
> +
> +    ranges = dt_get_property(dev, "ranges", &rlen);
> +    if ( ranges == NULL )
> +    {
> +        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +    if ( rlen == 0 ) /* Nothing to do */
> +        return 0;
> +
> +    bus->count_cells(dev, &na, &ns);
> +    if ( !DT_CHECK_COUNTS(na, ns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
> +                  dev->full_name);
> +        return -EINVAL;
> +    }
> +    pbus = dt_match_bus(parent);
> +    if ( pbus == NULL )
> +    {
> +        printk("DT: %s is not a valid bus\n", parent->full_name);
> +        return -EINVAL;
> +    }
> +
> +    pbus->count_cells(dev, &pna, &pns);
> +    if ( !DT_CHECK_COUNTS(pna, pns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +    /* Now walk through the ranges */
> +    rlen /= 4;
> +    rone = na + pna + ns;
> +
> +    for ( ; rlen >= rone; rlen -= rone, ranges += rone )
> +    {
> +        unsigned int flags = bus->get_flags(ranges);
> +        if ( flags & IORESOURCE_IO )
> +            continue;
> +
> +        memcpy(addr, ranges, 4 * rone);
> +
> +        addr += rone;
> +    }
> +
> +    ret = fdt_property(fdt, "ranges", regs, sizeof(regs));
> +    if ( ret )
> +        return ret;
> +
> +    return 0;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index fd6cd00b43..ad2e905595 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -849,6 +849,16 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
>   */
>  int dt_get_pci_domain_nr(struct dt_device_node *node);
>  
> +/**
> + * dt_get_remove_io_range - Remove the PCI I/O range property value.
> + * @fdt: Pointer to the file descriptor tree.
> + * @node: Device tree node.
> + *
> + * This function will remove the PCI IO range property from the PCI device tree
> + * node.
> + */
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *node);
> +
>  struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
>  
>  #ifdef CONFIG_DEVICE_TREE_DEBUG
> -- 
> 2.25.1
> 


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 03:06:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 03:06:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247696.427112 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxh5Y-0002Fe-AU; Thu, 16 Dec 2021 03:05:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247696.427112; Thu, 16 Dec 2021 03:05:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxh5Y-0002FX-7I; Thu, 16 Dec 2021 03:05:48 +0000
Received: by outflank-mailman (input) for mailman id 247696;
 Thu, 16 Dec 2021 03:05:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxh5W-0002FN-Fo; Thu, 16 Dec 2021 03:05:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxh5V-0004a3-4n; Thu, 16 Dec 2021 03:05:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxh5U-0002ME-Qm; Thu, 16 Dec 2021 03:05:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxh5U-0006bm-QJ; Thu, 16 Dec 2021 03:05:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fwTisshXzND2myPB+9StPteB5VTZTHmGob2Cqfg5ptg=; b=h83Hfuyw88FVUCMzSiEAObbYxp
	RKngpuSvPI7KrMI6teMxDomGgZdw+EJFciGkKUrR+N7ocKt+taJxWtZ08ljEmLvIK3ZcnFiQYKDj9
	C9udauU9BlEyCsZslJOZxrxnO3TnvaHy7Oz0jlcxnku86h6DSIl1u1CcESCHsRAfGqhY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167426-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167426: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=76b56fdfc9fa43ec6e5986aee33f108c6c6a511e
X-Osstest-Versions-That:
    qemuu=a3607def89f9cd68c1b994e1030527df33aa91d0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 03:05:44 +0000

flight 167426 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167426/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167228
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167228
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167228
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167228
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167228
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167228
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167228
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167228
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                76b56fdfc9fa43ec6e5986aee33f108c6c6a511e
baseline version:
 qemuu                a3607def89f9cd68c1b994e1030527df33aa91d0

Last test of basis   167228  2021-12-08 05:42:12 Z    7 days
Failing since        167417  2021-12-14 21:09:04 Z    1 days    2 attempts
Testing same since   167426  2021-12-15 09:11:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   a3607def89..76b56fdfc9  76b56fdfc9fa43ec6e5986aee33f108c6c6a511e -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 03:36:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 03:36:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247704.427127 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxhZ9-00062t-Rp; Thu, 16 Dec 2021 03:36:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247704.427127; Thu, 16 Dec 2021 03:36:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxhZ9-00062m-OS; Thu, 16 Dec 2021 03:36:23 +0000
Received: by outflank-mailman (input) for mailman id 247704;
 Thu, 16 Dec 2021 03:36:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxhZ7-00062g-O3
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 03:36:21 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 54831a1b-5e21-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 04:36:19 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 10F1E61C30;
 Thu, 16 Dec 2021 03:36:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20F98C36AE0;
 Thu, 16 Dec 2021 03:36:17 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54831a1b-5e21-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639625777;
	bh=jsbmh/YSViBrJWd77PbjaEFpB2PpeMBDwQ/M2ML5Rz0=;
	h=Date:From:To:cc:Subject:From;
	b=b5hUTFYq2OhYxvWWxbds0qYJL93rD5dXU3pPunz8/2mCEvMYgIPOiKT7BrUbuRyQB
	 hviuVOnv2M7HoHPekumRgZyzl7pBJadIndh4vxLGpqTeI9Qf0b9Rpe5Zr6/DsjJaKi
	 HBjAUdykundy+AJQ86G7CWlQBvbjjnm/VYKRzcE/yIuYWuRv3dEov7vWZbzGOW1hHe
	 A+NGzEO8m8wO2lt4lRzLoDgNGD4oYBkjKXnijcvtxUu8qNenp0fGrKEMArC/opj9tC
	 2YuCI8Ye4ORdd9BQGjXaWmY1DX1p5dz4vdgYKh4a39M03bo/K+HhrGB7gikwQVlP3S
	 OkNBfXVNLMZBA==
Date: Wed, 15 Dec 2021 19:36:17 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: jbeulich@suse.com, luca.fancellu@arm.com
cc: sstabellini@kernel.org, xen-devel@lists.xenproject.org, julien@xen.org, 
    bertrand.marquis@arm.com, Volodymyr_Babchuk@epam.com, amc96@srcf.net
Subject: arm32 randconfig failure
Message-ID: <alpine.DEB.2.22.394.2112151926390.3376@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-66828897-1639625409=:3376"
Content-ID: <alpine.DEB.2.22.394.2112151930140.3376@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-66828897-1639625409=:3376
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2112151930141.3376@ubuntu-linux-20-04-desktop>

Hi all,

gitlab-ci spotted another randconfig build issue on arm32. To repro, use
the attached Xen config file and build with XEN_TARGET_ARCH=arm32 (you
need an appropriate cross-compiler.)  This is the error:

https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/1888385010

Also appended below for your convenience. It affects the null scheduler.
I couldn't spot anything obvious so I ran a bisection.  This is the
offending commit:

commit ab6ba8c6753fa7642de2ffc84f6decadc6c40c2c
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Dec 10 10:25:44 2021 +0100

    perfc: conditionalize credit/credit2 counters
    
    There's no point including them when the respective scheduler isn't
    enabled in the build.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

 xen/include/xen/perfc_defn.h | 4 ++++
 1 file changed, 4 insertions(+)


Ideas on how to fix it?

Cheers,

Stefano



In file included from /local/repos/xen-upstream/xen/include/xen/mm.h:58,
                 from /local/repos/xen-upstream/xen/arch/arm/include/asm/p2m.h:4,
                 from /local/repos/xen-upstream/xen/arch/arm/include/asm/domain.h:7,
                 from /local/repos/xen-upstream/xen/include/xen/domain.h:8,
                 from /local/repos/xen-upstream/xen/include/xen/sched.h:11,
                 from null.c:31:
null.c: In function ‘null_unit_migrate’:
/local/repos/xen-upstream/xen/include/xen/perfc.h:65:53: error: ‘PERFC_migrate_on_runq’ undeclared (first use in this function); did you mean ‘PERFC_migrate_running’?
   65 | #define perfc_incr(x)     (++this_cpu(perfcounters)[PERFC_ ## x])
      |                                                     ^~~~~~
/local/repos/xen-upstream/xen/include/xen/sched.h:47:46: note: in expansion of macro ‘perfc_incr’
   47 | #define SCHED_STAT_CRANK(_X)                (perfc_incr(_X))
      |                                              ^~~~~~~~~~
null.c:713:9: note: in expansion of macro ‘SCHED_STAT_CRANK’
  713 |         SCHED_STAT_CRANK(migrate_on_runq);
      |         ^~~~~~~~~~~~~~~~
/local/repos/xen-upstream/xen/include/xen/perfc.h:65:53: note: each undeclared identifier is reported only once for each function it appears in
   65 | #define perfc_incr(x)     (++this_cpu(perfcounters)[PERFC_ ## x])
      |                                                     ^~~~~~
/local/repos/xen-upstream/xen/include/xen/sched.h:47:46: note: in expansion of macro ‘perfc_incr’
   47 | #define SCHED_STAT_CRANK(_X)                (perfc_incr(_X))
      |                                              ^~~~~~~~~~
null.c:713:9: note: in expansion of macro ‘SCHED_STAT_CRANK’
  713 |         SCHED_STAT_CRANK(migrate_on_runq);
      |         ^~~~~~~~~~~~~~~~
/local/repos/xen-upstream/xen/include/xen/perfc.h:65:53: error: ‘PERFC_migrated’ undeclared (first use in this function); did you mean ‘PSCI_migrate’?
   65 | #define perfc_incr(x)     (++this_cpu(perfcounters)[PERFC_ ## x])
      |                                                     ^~~~~~
/local/repos/xen-upstream/xen/include/xen/sched.h:47:46: note: in expansion of macro ‘perfc_incr’
   47 | #define SCHED_STAT_CRANK(_X)                (perfc_incr(_X))
      |                                              ^~~~~~~~~~
null.c:715:5: note: in expansion of macro ‘SCHED_STAT_CRANK’
  715 |     SCHED_STAT_CRANK(migrated);
      |     ^~~~~~~~~~~~~~~~
  LD      built_in.o
make[4]: *** [/local/repos/xen-upstream/xen/Rules.mk:197: null.o] Error 1
--8323329-66828897-1639625409=:3376
Content-Type: text/plain; CHARSET=US-ASCII; NAME=xen-config
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.2.22.394.2112151934540.3376@ubuntu-linux-20-04-desktop>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME=xen-config

Iw0KIyBBdXRvbWF0aWNhbGx5IGdlbmVyYXRlZCBmaWxlOyBETyBOT1QgRURJ
VC4NCiMgWGVuL2FybSA0LjE3LXVuc3RhYmxlIENvbmZpZ3VyYXRpb24NCiMN
CkNPTkZJR19DQ19JU19HQ0M9eQ0KQ09ORklHX0dDQ19WRVJTSU9OPTEwMDIw
MQ0KQ09ORklHX0NMQU5HX1ZFUlNJT049MA0KQ09ORklHX0NDX0hBU19WSVNJ
QklMSVRZX0FUVFJJQlVURT15DQpDT05GSUdfQVJNXzMyPXkNCkNPTkZJR19B
Uk09eQ0KQ09ORklHX0FSQ0hfREVGQ09ORklHPSJhcmNoL2FybS9jb25maWdz
L2FybTMyX2RlZmNvbmZpZyINCg0KIw0KIyBBcmNoaXRlY3R1cmUgRmVhdHVy
ZXMNCiMNCkNPTkZJR19OUl9DUFVTPTEyOA0KQ09ORklHX0hWTT15DQpDT05G
SUdfTkVXX1ZHSUM9eQ0KIyBDT05GSUdfU0JTQV9WVUFSVF9DT05TT0xFIGlz
IG5vdCBzZXQNCiMgQ09ORklHX0FSTV9TU0JEIGlzIG5vdCBzZXQNCkNPTkZJ
R19IQVJERU5fQlJBTkNIX1BSRURJQ1RPUj15DQpDT05GSUdfVEVFPXkNCkNP
TkZJR19PUFRFRT15DQojIGVuZCBvZiBBcmNoaXRlY3R1cmUgRmVhdHVyZXMN
Cg0KIw0KIyBBUk0gZXJyYXRhIHdvcmthcm91bmQgdmlhIHRoZSBhbHRlcm5h
dGl2ZSBmcmFtZXdvcmsNCiMNCiMgQ09ORklHX0FSTV9FUlJBVFVNXzg1ODky
MSBpcyBub3Qgc2V0DQojIGVuZCBvZiBBUk0gZXJyYXRhIHdvcmthcm91bmQg
dmlhIHRoZSBhbHRlcm5hdGl2ZSBmcmFtZXdvcmsNCg0KQ09ORklHX0FSTTMy
X0hBUkRFTl9CUkFOQ0hfUFJFRElDVE9SPXkNCkNPTkZJR19BTExfUExBVD15
DQojIENPTkZJR19OT19QTEFUIGlzIG5vdCBzZXQNCkNPTkZJR19BTEwzMl9Q
TEFUPXkNCg0KIw0KIyBDb21tb24gRmVhdHVyZXMNCiMNCiMgQ09ORklHX0dS
QU5UX1RBQkxFIGlzIG5vdCBzZXQNCkNPTkZJR19IQVNfQUxURVJOQVRJVkU9
eQ0KQ09ORklHX0hBU19ERVZJQ0VfVFJFRT15DQpDT05GSUdfSEFTX1BEWD15
DQpDT05GSUdfTUVNX0FDQ0VTUz15DQojIENPTkZJR19TVEFUSUNfTUVNT1JZ
IGlzIG5vdCBzZXQNCg0KIw0KIyBTcGVjdWxhdGl2ZSBoYXJkZW5pbmcNCiMN
CkNPTkZJR19TUEVDVUxBVElWRV9IQVJERU5fQVJSQVk9eQ0KIyBlbmQgb2Yg
U3BlY3VsYXRpdmUgaGFyZGVuaW5nDQoNCkNPTkZJR19IWVBGUz15DQojIENP
TkZJR19IWVBGU19DT05GSUcgaXMgbm90IHNldA0KQ09ORklHX0lPUkVRX1NF
UlZFUj15DQpDT05GSUdfRUZJX1NFVF9WSVJUVUFMX0FERFJFU1NfTUFQPXkN
CiMgQ09ORklHX1hTTSBpcyBub3Qgc2V0DQpDT05GSUdfQVJHTz15DQoNCiMN
CiMgU2NoZWR1bGVycw0KIw0KQ09ORklHX1NDSEVEX0NSRURJVD15DQojIENP
TkZJR19TQ0hFRF9DUkVESVQyIGlzIG5vdCBzZXQNCiMgQ09ORklHX1NDSEVE
X1JURFMgaXMgbm90IHNldA0KIyBDT05GSUdfU0NIRURfQVJJTkM2NTMgaXMg
bm90IHNldA0KQ09ORklHX1NDSEVEX05VTEw9eQ0KQ09ORklHX1NDSEVEX0NS
RURJVF9ERUZBVUxUPXkNCiMgQ09ORklHX1NDSEVEX05VTExfREVGQVVMVCBp
cyBub3Qgc2V0DQpDT05GSUdfU0NIRURfREVGQVVMVD0iY3JlZGl0Ig0KIyBl
bmQgb2YgU2NoZWR1bGVycw0KDQojIENPTkZJR19MSVZFUEFUQ0ggaXMgbm90
IHNldA0KIyBDT05GSUdfRU5GT1JDRV9VTklRVUVfU1lNQk9MUyBpcyBub3Qg
c2V0DQpDT05GSUdfU1VQUFJFU1NfRFVQTElDQVRFX1NZTUJPTF9XQVJOSU5H
Uz15DQpDT05GSUdfQ01ETElORT0iIg0KQ09ORklHX0RPTTBfTUVNPSIiDQpD
T05GSUdfRFRCX0ZJTEU9IiINCkNPTkZJR19UUkFDRUJVRkZFUj15DQojIGVu
ZCBvZiBDb21tb24gRmVhdHVyZXMNCg0KIw0KIyBEZXZpY2UgRHJpdmVycw0K
Iw0KQ09ORklHX0hBU19OUzE2NTUwPXkNCiMgQ09ORklHX0hBU19QTDAxMSBp
cyBub3Qgc2V0DQpDT05GSUdfSEFTX0VYWU5PUzQyMTA9eQ0KQ09ORklHX0hB
U19PTUFQPXkNCiMgQ09ORklHX0hBU19TQ0lGIGlzIG5vdCBzZXQNCkNPTkZJ
R19IQVNfUEFTU1RIUk9VR0g9eQ0KQ09ORklHX0FSTV9TTU1VPXkNCkNPTkZJ
R19JT01NVV9GT1JDRV9QVF9TSEFSRT15DQojIGVuZCBvZiBEZXZpY2UgRHJp
dmVycw0KDQpDT05GSUdfRVhQRVJUPXkNCkNPTkZJR19VTlNVUFBPUlRFRD15
DQoNCiMNCiMgRGVidWdnaW5nIE9wdGlvbnMNCiMNCkNPTkZJR19ERUJVRz15
DQojIENPTkZJR19ERUJVR19JTkZPIGlzIG5vdCBzZXQNCiMgQ09ORklHX0ZS
QU1FX1BPSU5URVIgaXMgbm90IHNldA0KIyBDT05GSUdfQ09WRVJBR0UgaXMg
bm90IHNldA0KIyBDT05GSUdfREVCVUdfTE9DS19QUk9GSUxFIGlzIG5vdCBz
ZXQNCiMgQ09ORklHX0RFQlVHX0xPQ0tTIGlzIG5vdCBzZXQNCkNPTkZJR19Q
RVJGX0NPVU5URVJTPXkNCkNPTkZJR19QRVJGX0FSUkFZUz15DQojIENPTkZJ
R19WRVJCT1NFX0RFQlVHIGlzIG5vdCBzZXQNCkNPTkZJR19ERVZJQ0VfVFJF
RV9ERUJVRz15DQpDT05GSUdfU0NSVUJfREVCVUc9eQ0KIyBDT05GSUdfREVC
VUdfVFJBQ0UgaXMgbm90IHNldA0KIyBDT05GSUdfWE1FTV9QT09MX1BPSVNP
TiBpcyBub3Qgc2V0DQojIGVuZCBvZiBEZWJ1Z2dpbmcgT3B0aW9ucw0K

--8323329-66828897-1639625409=:3376--


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 04:44:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 04:44:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247709.427138 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxicS-0005j9-Tk; Thu, 16 Dec 2021 04:43:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247709.427138; Thu, 16 Dec 2021 04:43:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxicS-0005j2-Qt; Thu, 16 Dec 2021 04:43:52 +0000
Received: by outflank-mailman (input) for mailman id 247709;
 Thu, 16 Dec 2021 04:43:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxicS-0005is-04; Thu, 16 Dec 2021 04:43:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxicR-0006Og-DT; Thu, 16 Dec 2021 04:43:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxicR-0007Mm-44; Thu, 16 Dec 2021 04:43:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxicR-0005Mw-3F; Thu, 16 Dec 2021 04:43:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=f1xh+1pdMicSv/oGb94IdOfS+4FTLn11xO6HprR0CFU=; b=MRXzNw0crdrjwdSunBh1y81HyU
	z7+HyEAOXAYIf7rWkSO7zJnCziS8lFxwGS6Ekyoa4r5nr2qXr0OAtVeTT+vswaXX7CeKDyUZzxM/t
	7f/noESiZHdfyS+vNFLmv/whQNpIFcyLjH2MC7PNaEhyEVJDLLoPk0gfwwPn0QUz08yg=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167436-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167436: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=f14fff513540757bef62923ee4aeca4bf3ea8081
X-Osstest-Versions-That:
    ovmf=38f6d78c3b62f8825e7d802697b7992418a72da7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 04:43:51 +0000

flight 167436 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167436/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 f14fff513540757bef62923ee4aeca4bf3ea8081
baseline version:
 ovmf                 38f6d78c3b62f8825e7d802697b7992418a72da7

Last test of basis   167419  2021-12-14 23:11:46 Z    1 days
Testing same since   167436  2021-12-15 15:38:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Wei6 Xu <wei6.xu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   38f6d78c3b..f14fff5135  f14fff513540757bef62923ee4aeca4bf3ea8081 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 05:13:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 05:13:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247715.427152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxj54-0001LH-AT; Thu, 16 Dec 2021 05:13:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247715.427152; Thu, 16 Dec 2021 05:13:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxj54-0001LA-6k; Thu, 16 Dec 2021 05:13:26 +0000
Received: by outflank-mailman (input) for mailman id 247715;
 Thu, 16 Dec 2021 05:13:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=edRR=RB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxj53-0001L4-2P
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 05:13:25 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e4018ebb-5e2e-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 06:13:23 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9889A210FE;
 Thu, 16 Dec 2021 05:13:22 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E84013BFD;
 Thu, 16 Dec 2021 05:13:22 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id EGZxEfLKumFnBQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 16 Dec 2021 05:13:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4018ebb-5e2e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639631602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=uC9tykHxC/e+1nOG+UXY3mFjCKhJSQXn/qf/DOQkm84=;
	b=sN+Un354ZMuVTQDZlY/hct1kBzFyCuV16BIdIVpJ54RpFrfmW7go7T4Op0LenXlhUBdfyR
	UHTj5ryJqe35p3ypqFpx8i/oP9GHHhyWUFEGZfMZKC+RH1RSOXsNuKIMcWFeKjFk05mttD
	fPIjSvfbI6aTkXfkFqEUlYnjx2Uk48g=
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
Message-ID: <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
Date: Thu, 16 Dec 2021 06:13:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="cKdxQx09uPLSFfOLXGbKAmf7yAtYXSOq2"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--cKdxQx09uPLSFfOLXGbKAmf7yAtYXSOq2
Content-Type: multipart/mixed; boundary="2DvwhwW2UhiVQIMt3PjVrtUWdJeJNWa5a";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
Message-ID: <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>

--2DvwhwW2UhiVQIMt3PjVrtUWdJeJNWa5a
Content-Type: multipart/mixed;
 boundary="------------39CD9263BFF5C97F1954ED0A"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------39CD9263BFF5C97F1954ED0A
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 16.12.21 03:10, Stefano Stabellini wrote:
> On Wed, 15 Dec 2021, Juergen Gross wrote:
>> On 14.12.21 18:36, Julien Grall wrote:
>>> Hi,
>>>
>>> On 08/12/2021 15:55, Juergen Gross wrote:
>>>> Today most hypercall handlers have a return type of long, while the
>>>> compat ones return an int. There are a few exceptions from that rule=
,
>>>> however.
>>>
>>> So on Arm64, I don't think you can make use of the full 64-bit becaus=
e a
>>> 32-bit domain would not be able to see the top 32-bit.
>>>
>>> In fact, this could potentially cause us some trouble (see [1]) in Xe=
n.
>>> So it feels like the hypercalls should always return a 32-bit signed =
value
>>> on Arm.
>>
>> This would break hypercalls like XENMEM_maximum_ram_page which are abl=
e
>> to return larger values, right?
>>
>>> The other advantage is it would be clear that the top 32-bit are not
>>> usuable. Stefano, what do you think?
>>
>> Wouldn't it make more sense to check the return value to be a sign
>> extended 32-bit value for 32-bit guests in do_trap_hypercall() instead=
?
>>
>> The question is what to return if this is not the case. -EDOM?
>=20
>=20
> I can see where Julien is coming from: we have been trying to keep the
> arm32 and arm64 ABIs identical since the beginning of the project. So,
> like Julien, my preference would be to always return 32-bit on ARM, bot=
h
> aarch32 and aarch64. It would make things simple.
>=20
> The case of XENMEM_maximum_ram_page is interesting but it is not a
> problem in reality because the max physical address size is only 40-bit=

> for aarch32 guests, so 32-bit are always enough to return the highest
> page in memory for 32-bit guests.

You are aware that this isn't the guest's max page, but the host's?

And all of this is about a 32-bit guest on a 64-bit host.


Juergen

--------------39CD9263BFF5C97F1954ED0A
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------39CD9263BFF5C97F1954ED0A--

--2DvwhwW2UhiVQIMt3PjVrtUWdJeJNWa5a--

--cKdxQx09uPLSFfOLXGbKAmf7yAtYXSOq2
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG6yvEFAwAAAAAACgkQsN6d1ii/Ey8q
UAf/ekXR4hXzhPNRYZ31HpSluABmRIe2Tgiq+Kfp2bDE+1c0uQdWsZMYB1ozWEWtuEGueUo0nvnz
f3QYeJQcE0Wkmj6ProBQr85roChdvA/+H0saPDacen0FIA4aSvvCDteEUEtxaRvxNhVL2RU3qgWD
JxgOmMX3MRCjHI0nYNiwof+kAC9c3Yx/UHU5GS7Nr9RLE8UQ7ySSsUsFlhCJZn8MqSipF5AJNlaV
D3f+jy1aEA3bXrL7GUzv7rv+3lQ0/394bTYhTeJC4BlC89editPIcT6J2RkK26c1ug/DHz7oaBvr
31KI/2BN9vArcRqXGjDB1XZVX0w2zwoe/XyBAZinDA==
=dUQM
-----END PGP SIGNATURE-----

--cKdxQx09uPLSFfOLXGbKAmf7yAtYXSOq2--


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 05:45:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 05:45:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247720.427163 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxjZm-00054k-RT; Thu, 16 Dec 2021 05:45:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247720.427163; Thu, 16 Dec 2021 05:45:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxjZm-00054d-OS; Thu, 16 Dec 2021 05:45:10 +0000
Received: by outflank-mailman (input) for mailman id 247720;
 Thu, 16 Dec 2021 05:45:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=edRR=RB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxjZl-00054V-5l
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 05:45:09 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 52b0bcf5-5e33-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 06:45:06 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3B99B212C8;
 Thu, 16 Dec 2021 05:45:06 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EFFBC13BE1;
 Thu, 16 Dec 2021 05:45:05 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mzKOOGHSumHbDQAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 16 Dec 2021 05:45:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 52b0bcf5-5e33-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639633506; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=7oolKMpaSQxd85FFwYfxPvPQTAnBdWoIFTsi9p/rRdw=;
	b=UOol0YEz+0/MWvzrQvIE+kJXYxegUV4G222i78uCPMuN4d3tZa/jKch/bkJypjlnFmsLGd
	bzjFjAMEySmAfliUjHGuTJGAhsb6J6/E5S3/y344sOWxZABmKfod/6frjHdvWZezZ1FGLH
	Nrh1CCBBTmZOkzZk4cuRSSf/FnhPN88=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] xen: make some per-scheduler performance counters sched global ones
Date: Thu, 16 Dec 2021 06:45:02 +0100
Message-Id: <20211216054502.14085-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Some performance counters listed to be credit or credit2 specific are
being used by the null scheduler, too.

Make those sched global ones.

Fixes: ab6ba8c6753fa76 ("perfc: conditionalize credit/credit2 counters")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/include/xen/perfc_defn.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/include/xen/perfc_defn.h b/xen/include/xen/perfc_defn.h
index 672b51c456..0027d95a60 100644
--- a/xen/include/xen/perfc_defn.h
+++ b/xen/include/xen/perfc_defn.h
@@ -34,6 +34,9 @@ PERFCOUNTER(tickled_idle_cpu,       "sched: tickled_idle_cpu")
 PERFCOUNTER(tickled_idle_cpu_excl,  "sched: tickled_idle_cpu_exclusive")
 PERFCOUNTER(tickled_busy_cpu,       "sched: tickled_busy_cpu")
 PERFCOUNTER(unit_check,             "sched: unit_check")
+PERFCOUNTER(migrate_running,        "sched: migrate_running")
+PERFCOUNTER(migrate_on_runq,        "sched: migrate_on_runq")
+PERFCOUNTER(migrated,               "sched: migrated")
 
 /* credit specific counters */
 #ifdef CONFIG_SCHED_CREDIT
@@ -55,7 +58,6 @@ PERFCOUNTER(steal_trylock,          "csched: steal_trylock")
 PERFCOUNTER(steal_trylock_failed,   "csched: steal_trylock_failed")
 PERFCOUNTER(steal_peer_idle,        "csched: steal_peer_idle")
 PERFCOUNTER(migrate_queued,         "csched: migrate_queued")
-PERFCOUNTER(migrate_running,        "csched: migrate_running")
 PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
 PERFCOUNTER(unit_hot,               "csched: unit_hot")
 #endif
@@ -67,13 +69,11 @@ PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
 PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
 PERFCOUNTER(upd_max_weight_full,    "csched2: update_max_weight_full")
 PERFCOUNTER(migrate_requested,      "csched2: migrate_requested")
-PERFCOUNTER(migrate_on_runq,        "csched2: migrate_on_runq")
 PERFCOUNTER(migrate_no_runq,        "csched2: migrate_no_runq")
 PERFCOUNTER(runtime_min_timer,      "csched2: runtime_min_timer")
 PERFCOUNTER(runtime_max_timer,      "csched2: runtime_max_timer")
 PERFCOUNTER(pick_resource,          "csched2: pick_resource")
 PERFCOUNTER(need_fallback_cpu,      "csched2: need_fallback_cpu")
-PERFCOUNTER(migrated,               "csched2: migrated")
 PERFCOUNTER(migrate_resisted,       "csched2: migrate_resisted")
 PERFCOUNTER(credit_reset,           "csched2: credit_reset")
 PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu")
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 06:15:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 06:15:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247728.427174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxk2Z-0000Wj-DA; Thu, 16 Dec 2021 06:14:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247728.427174; Thu, 16 Dec 2021 06:14:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxk2Z-0000Wc-9z; Thu, 16 Dec 2021 06:14:55 +0000
Received: by outflank-mailman (input) for mailman id 247728;
 Thu, 16 Dec 2021 06:14:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=p9yO=RB=microsoft.com=mikelley@srs-se1.protection.inumbo.net>)
 id 1mxk2X-0000WV-V8
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 06:14:54 +0000
Received: from na01-obe.outbound.protection.outlook.com (unknown
 [2a01:111:f403:c110::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7a56a81a-5e37-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 07:14:52 +0100 (CET)
Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11)
 by DM6PR21MB1273.namprd21.prod.outlook.com (2603:10b6:5:16c::27) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.8; Thu, 16 Dec
 2021 06:14:38 +0000
Received: from MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::e9ea:fc3b:df77:af3e]) by MWHPR21MB1593.namprd21.prod.outlook.com
 ([fe80::e9ea:fc3b:df77:af3e%6]) with mapi id 15.20.4823.005; Thu, 16 Dec 2021
 06:14:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7a56a81a-5e37-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ImnwxWgJfJNOTow3iwSqSIHmRBr2j0oZerUh01KmbrfVRjfOCU1Ifxyk3ngB041EDVhed+FqHYQzKiyxj6y/Z/mii1LJK8D4FpyjDfLQSYAp4YzZRg5xK3MBjTU2F3PCK4Ib85pdGKWh2cKR8q2lhQCSEpmjp+kllK/wQy8O5lhrXhE5vbrXKx3tsU80jdDJIRhjPT5ulB7lCwps/mSKobxO7eAP3vb4XZTUO7mveLDbFMxIPe6ch2GOWCG+hKb5NSFvMb9MUA4X7Ok/iYl3BOxoEAjzOz+GWB7aQWuA3lTqWVo6BOFNzfsNRNu6hR/h4PApY9d9fEzoaTDeap5paA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Zj6f1cHHbnyHLhg4aA25mqY9UgdPFT817BJ+fttssdo=;
 b=FilI8fEv1FliLEwa0/pDU5wFg0ADI47DATLaijYE1KCLbAD2YR0b+V0WXkYAojlYJk8Qq0bk/lkgMdPTJX0jrQifP9dSwZDehRWhBNlEt9guHHxajoVUVuy60CEX9rfmB3tmPkr8TF6/QSBwzWqV43nMUGlnMoNEd9e9JwmQDmcWoeXInYj8RwFgcviHuLFMSRnmnnXh8vsVKIn+/JOZzoFBRGmxzkQmnfsDXf9oNRN3jM7lC2Q6D9ssuUOFEnzEdw1UVwpqfr4jViGAAIsU+iMf5/wUJz6DX8Km2/vUmz3d59YIT7FVZZwK0zKW8Xg9aC5C7q2UkoIsc2+7gwU2Iw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Zj6f1cHHbnyHLhg4aA25mqY9UgdPFT817BJ+fttssdo=;
 b=Ycav6qsZKWLy+JhjK3iVGvddk44Zk+7uznPkQuMUf3Mz+5319ZF2hY+ae9QcoSCb0FI9WALjwRqJbgbTuYMbIm6vpr+ygF/TttTlBJxEv2AVFCiME8BbVTsOPYVgzNlhWtal0jWH24O3ZuwB0AXhBmLyqTU/dQBx/G+bsQuLotk=
From: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
To: Thomas Gleixner <tglx@linutronix.de>, Nishanth Menon <nm@ti.com>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Cedric Le Goater
	<clg@kaod.org>, Juergen Gross <jgross@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Arnd
 Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, "linuxppc-dev@lists.ozlabs.org"
	<linuxppc-dev@lists.ozlabs.org>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Bjorn Helgaas <bhelgaas@google.com>, Stuart
 Yoder <stuyoder@gmail.com>, Laurentiu Tudor <laurentiu.tudor@nxp.com>, Tero
 Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, Vinod Koul <vkoul@kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, Mark Rutland
	<Mark.Rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
	<robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
	"iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, Jassi
 Brar <jassisinghbrar@gmail.com>, Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>, "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>, Johannes Berg <johannes.berg@intel.com>
Subject: RE: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Thread-Topic: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
Thread-Index:
 AQHX7hP2OO+j8bTrKUC182AbgaxaDKwwwrUAgAD+lACAAHA4gIAAA7EAgAAHxwCAADWSAIAAC2sAgAAGkoCAAT4FgIAABOkAgADieNA=
Date: Thu, 16 Dec 2021 06:14:38 +0000
Message-ID:
 <MWHPR21MB159301D63518283F813FC32ED7779@MWHPR21MB1593.namprd21.prod.outlook.com>
References: <20211210221642.869015045@linutronix.de>
 <20211213182958.ytj4m6gsg35u77cv@detonator> <87fsqvttfv.ffs@tglx>
 <20211214162247.ocjm7ihg5oi7uiuv@slider> <87wnk7rvnz.ffs@tglx>
 <87tufbrudl.ffs@tglx> <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly> <87h7basx36.ffs@tglx>
 <87zgp1rge4.ffs@tglx> <87wnk5rfkt.ffs@tglx>
In-Reply-To: <87wnk5rfkt.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7cb534aa-630b-47e6-8e34-abedba89cdec;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-12-16T06:06:19Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=microsoft.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 65d6e4d5-65ed-4dc2-c83e-08d9c05b5726
x-ms-traffictypediagnostic: DM6PR21MB1273:EE_
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs:
 <DM6PR21MB12735C192931744515825898D7779@DM6PR21MB1273.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3383;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 vw+EVdznUWr5SaD5O6qTtFR5BytWYLHPOS18p7fOBcUblvxmnzsbXMDN+r0H4I7/46nVIt460P4ESXtZmrqIirY+pv20dQZe/jP2lcdX1WQkHnzzxqGGHG1f0vddrveujsNj5i0fbr9GxZM+9+wmX7m5ZdD3cRH8V4/7lpwgDT0pjedY6NjwndqvmD+lI+YiarRn/IS1hAKVBS3njOSmfLzq+ujEFxJFZ3ootq6dcEi7VPTYiXIhx8IRTDKtq2xJysCeZrGorCgU+xCuT2/Op9nqPfKC0R+ilDj80QuE1CD+zP56/bKu0zh74BH3+A6LHJuwlfGlxsGSkqurPU84MTJETlwOxxlbYVh8596NA0Xet/LlvkmpCSk9cmxxXT7Ga1xWvEqr3iz5+DWpa0K09EzhxwXFo2fx7OiP2HE0NcFEhUK2wtRCQ5LJk6WqOYQC2wUG+cz+Dl8tUhjBi99N/ixetupG713cV4Iau4QujA14IUs1buEcHZsaJcH2CSxmnyxETfgwbhybKz0+sjyRhNdCYC/oEDKETsIJhNT1WO9i9azpB9X6g3yhrZt739wxZFMDrozdmNz92+/n/d4Iv5ubwF0dKcakaaM50cLIR54MfBJoAS2Td+gOaGcp1JXLWIqZqdS4+yCWgw2gyjtBV9BuiWcpkU1ISWZV5CMyvW2hjbIrEXVyyvh3N/bTkSOqDAL0bWgWeJZnyPJ0fuadzapohKxLzx5O3aArglXLgnFvqEaEZhfreBMj7+RjvxCz
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(86362001)(71200400001)(8936002)(82960400001)(82950400001)(8990500004)(4326008)(66446008)(66556008)(64756008)(66476007)(7696005)(316002)(54906003)(6506007)(66946007)(76116006)(110136005)(10290500003)(55016003)(38100700002)(7406005)(508600001)(7416002)(26005)(2906002)(186003)(9686003)(52536014)(33656002)(38070700005)(83380400001)(122000001)(5660300002)(20210929001);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?BGfwAzFUCiYmI4pdlWbqMKpDx7KnUGggEv9dV+jkLJjVyikFT2zkhP1lCA4T?=
 =?us-ascii?Q?dxR0UOYjdUceWffccPhbHnififYqpK+FB/DeatLhAI1ZIadtjo/RFAk0+X9p?=
 =?us-ascii?Q?sE7nAfuNzGqlX0+HIyX0s3GLKNsVaCgMiIkGJ9rAkHxWe5WTAu2rzS4ouyz8?=
 =?us-ascii?Q?25qPl+kEmF2rkScYzZBJ6tbrAJFtg+aHqTNAIL+J1Y7Y5sSIqf2tzEPn9dYP?=
 =?us-ascii?Q?buZ/0Q/OSY+H92ImKO0jbP+0DL/SphmyW15qzquT7hRTC1KJaj2bNM3u3ZTF?=
 =?us-ascii?Q?s5q7dqubC9KTFLe4LI18oLM5TwRmkyl58znio8uOqffRZxxECB5YixedJ+NK?=
 =?us-ascii?Q?bQ5E9GLXe56e0p773dghG8lUN5iEyHJCeLf7HTFnxUMCDpMYBThmM/rid/9Z?=
 =?us-ascii?Q?TeZUV6K+ZtvtFJfQApeIPi/T6qe3rCj0EGjuoe82MAus32AJCmGSRxE7Nw3u?=
 =?us-ascii?Q?xWrVG9ye8C8EJdMS+pX+DJpynnHzEQELIMvCwZ2P04/fPVU0nCNGE8sblfPF?=
 =?us-ascii?Q?2Ltk+2hQFL9XBiS6tjj1202ADc57jfF7Son3HDOTvdcUphZVABeVtHMeqvEr?=
 =?us-ascii?Q?5iIY6UPhAqT266bPKkMMZ16xIuwn3HbR2AP5jwfnFOLe2Z0wfmV57hcKHyb9?=
 =?us-ascii?Q?3ihBuNkGIv88KqLAjPkVsF5krlcg+gtJKQYrlTtKEpsNSgiK6vbEg3FxPYB6?=
 =?us-ascii?Q?rXgnrdWZ0EBuuffi0To63vXVC8l4duhxnbLO59mMoMZ9Go0eKJ/IyQYV58aq?=
 =?us-ascii?Q?+wWeErwHSlTjA+Hjs2QdLFHK4rET4yHb2gWKitLcG1QyyUgn4nL3cgX4Ymio?=
 =?us-ascii?Q?WtfcM+rb/GhR/Fnp0ygaOAnHoESSHWOuezccSmpbnUfdAQoeKPhw66TPzsSh?=
 =?us-ascii?Q?N/o98VanUQNxhbnPi/fvfie8mUxc6JHHTrUeZEWBc6By5lDrVLpCICk4JH4G?=
 =?us-ascii?Q?sUdKA8oLToxQ+C2uaJ7JoAuwPiopTACT2GmyZm623obOHuma0PB/weQ9tPS1?=
 =?us-ascii?Q?IuBQ8E7hYlO/JeMpmXv8dPY7Iu5zLuhUgpYLwYdHTM9osnvVEmfkdxjNQYIu?=
 =?us-ascii?Q?DfxrWI2iF9rNBynZZt7qu+dZPTnF9z+O2RZPt6o1zpxZYDrq5MbDKqqzujIj?=
 =?us-ascii?Q?uaDqFMVWAYPVK8/VERQpE7RLbtbEQ6gis0P0+5b+hzsd+Jcy6FwnHc1Hrohz?=
 =?us-ascii?Q?0Dct2sE2xGwLTTh0dRxCVVMIU36S3L9L/ORD0NRoimAlmQM5DrJYlnxv4i9d?=
 =?us-ascii?Q?dRvg2ZR/nNZIrRnYEKOHM4qFhL3SBNSCQ710WizmN3UokN/pzVw79coDnBF4?=
 =?us-ascii?Q?P/ncARRTMjVGndaOgQFq5kFbNRhJaX6v5nMmI1GNKDo/7Cv03LB5Ut8Ay+cs?=
 =?us-ascii?Q?LXAoO4GOzxysV8JxtEajV8P0XY57juB4YJxgMGZCocop99tvRoaJG72CGRN9?=
 =?us-ascii?Q?cJJZXzHQlLKOfrtdy6i0V7W1sfKH6YPvMTeUQDOqK9W6WX0c3QT16xdG8Reo?=
 =?us-ascii?Q?fAneX49GPvY6gAsPdtVawydbwwX6Zkkqkx5WqfXHAnY5RhmKccsOkcihhVoT?=
 =?us-ascii?Q?8SmE/jZR9ZWotlCOWwQptC+37oLRwWNVefQdGqpywzleTRawgXfKqgDV3Lnb?=
 =?us-ascii?Q?Bjo3cKPj1m8gXGEBIiFylnRzOQdqsEB9wF1LTrdCYgttayieSbTCJxmIL66d?=
 =?us-ascii?Q?caZu2w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65d6e4d5-65ed-4dc2-c83e-08d9c05b5726
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 06:14:38.4102
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eZ6pq4A7PkIMdqcGP/0mVivXlhB7Zm5ttEPN0eB5RBMFkYw7pr1902VJm30AU6kAFZ3r11LxYBi0TMYOCPy30l0AVasWxzJ11tgrlS3mR20=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR21MB1273

From: Thomas Gleixner <tglx@linutronix.de> Sent: Wednesday, December 15, 20=
21 8:36 AM
>=20
> On Wed, Dec 15 2021 at 17:18, Thomas Gleixner wrote:
>=20
> > On Tue, Dec 14 2021 at 22:19, Thomas Gleixner wrote:
> >> On Tue, Dec 14 2021 at 14:56, Nishanth Menon wrote:
> >>
> >> thanks for trying. I'll have a look again with brain awake tomorrow
> >> morning.
> >
> > Morning was busy with other things, but I found what my sleepy brain
> > managed to do wrong yesterday evening.
> >
> > Let me reintegrate the pile and I'll send you an update.
>=20
>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.1-=
part-2
>    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git msi-v4.2-=
part-3
>=20
> That should cure the problem.

Tested the msi-v4.2-part-3 tag in two different Azure/Hyper-V VMs.  One
is a Generation 1 VM that has legacy PCI devices and one is a Generation 2
VM with no legacy PCI devices.   Tested hot add and remove of Mellanox
CX-3 and CX-4 SR-IOV NIC virtual functions that are directly mapped into th=
e
VM.  Also tested local NVMe devices directly mapped into one of the VMs.

No issues encountered.  So for Azure/Hyper-V specifically,

Tested-by: Michael Kelley <mikelley@microsoft.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 06:58:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 06:58:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247735.427187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkii-0005Ne-KG; Thu, 16 Dec 2021 06:58:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247735.427187; Thu, 16 Dec 2021 06:58:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkii-0005NX-HS; Thu, 16 Dec 2021 06:58:28 +0000
Received: by outflank-mailman (input) for mailman id 247735;
 Thu, 16 Dec 2021 06:58:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=SM1R=RB=gmail.com=lukas.bulwahn@srs-se1.protection.inumbo.net>)
 id 1mxkih-0005NR-FR
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 06:58:27 +0000
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com
 [2a00:1450:4864:20::42c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91027f4e-5e3d-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 07:58:26 +0100 (CET)
Received: by mail-wr1-x42c.google.com with SMTP id t18so42230131wrg.11
 for <xen-devel@lists.xenproject.org>; Wed, 15 Dec 2021 22:58:26 -0800 (PST)
Received: from felia.fritz.box ([2001:16b8:267b:1200:18af:bb55:aabf:94a8])
 by smtp.gmail.com with ESMTPSA id p12sm4718037wrr.10.2021.12.15.22.58.24
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 15 Dec 2021 22:58:25 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91027f4e-5e3d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id;
        bh=XpWcs0XbMlH4VQ6hw7+xSPVWX4q7iEBGmSQA5LzJK08=;
        b=KpLR7KdZfjR1YsZpZau7nel5Iov1BHZulmr50C0qi8+Nbz1/3tGosxKZWpnCjfDjJP
         cHrU29k1qR4/+2sv8mtbR0yh7GguxoRObfc8GfFRIdt0tlFlCe/H43MIO/9llMIQZR4a
         P/7cJFbA3QbWtEOfz9gQfoOROKeDZGs6cR/gCW5eRWCHkf6uMHyOQ754hi3SulDtn0zn
         8WHRgIar51da3O5T/pAZHFfYoMPu87tPxSTDnnDnLFAv3jliGB1etnUgN+1F5dLPv/hO
         WwgV/y7yAU7Pg2q3sziYrKd0g9/nbDkI+l3iRfHsoiSFVeShEEFi20gzh+PgEpx3pDye
         UEfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id;
        bh=XpWcs0XbMlH4VQ6hw7+xSPVWX4q7iEBGmSQA5LzJK08=;
        b=TTScIW5+qViHXS8gHYzX3iHkDaGWT3nR8s5vUHx27UeQFaGqPD4d6iizqqDtFSa71R
         oQaPqaXGQi26k61PrfqprCczytIXd3nNg++PIbZ2P+EFN7WJlbedSgQyWR0+QDXWNCt3
         9Tsop8jmLVw3w6WaWzbN58Z7NRzKhQBJ15Y1ungZwCe/rX7k9+iEKsbwSo6v0QaRyZro
         uCY5yglHU3Jy1h0Z0j+wRSbGWb4BlDUokzfjUJ2o3z2BBLCFiUOhgHuAWv5gSEeuugck
         JqI1qPaj6WGS8QQeoA+Ezl51RNskK6OdO5gVOkNi/Z5JiNpZZH7Wu2QYWT23JsmYQA/7
         DSig==
X-Gm-Message-State: AOAM530iDzXKWuuSKGxcXHpzt/l0TI3rRfVO2pq0F3rbvH1JPVhpa3/E
	LU1KU2k50jBlKfUK8uMlNCo=
X-Google-Smtp-Source: ABdhPJxp3ZXrPoJwzqsVZMOfkSKa2WxiAB5H8OKvSTfGLSvtRhguEnwUBykdSnxasAlAEmi4KJ+XCA==
X-Received: by 2002:adf:97c2:: with SMTP id t2mr7512331wrb.577.1639637905795;
        Wed, 15 Dec 2021 22:58:25 -0800 (PST)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org,
	linux-usb@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>,
	kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] MAINTAINERS: remove typo from XEN PVUSB DRIVER section
Date: Thu, 16 Dec 2021 07:55:47 +0100
Message-Id: <20211216065547.18619-1-lukas.bulwahn@gmail.com>
X-Mailer: git-send-email 2.17.1

Commit a92548f90fa6 ("xen: add Xen pvUSB maintainer") adds the new XEN
PVUSB DRIVER section, but one file entry contains an obvious typo.

Fortunately, ./scripts/get_maintainer.pl --self-test=patterns warns:

  warning: no file matches    F:    divers/usb/host/xen*

Remove this obvious typo.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies on next-20211215

Juergen, please ack.

Greg, please pick this minor clean-up on top of the commit above.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 97215d89df4e..a5df6e1219b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21007,7 +21007,7 @@ M:	Juergen Gross <jgross@suse.com>
 L:	xen-devel@lists.xenproject.org (moderated for non-subscribers)
 L:	linux-usb@vger.kernel.org
 S:	Supported
-F:	divers/usb/host/xen*
+F:	drivers/usb/host/xen*
 F:	include/xen/interface/io/usbif.h
 
 XEN SOUND FRONTEND DRIVER
-- 
2.17.1



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 07:10:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 07:10:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247739.427198 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkuX-00081U-OD; Thu, 16 Dec 2021 07:10:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247739.427198; Thu, 16 Dec 2021 07:10:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkuX-00081N-Kq; Thu, 16 Dec 2021 07:10:41 +0000
Received: by outflank-mailman (input) for mailman id 247739;
 Thu, 16 Dec 2021 07:10:39 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=edRR=RB=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mxkuV-00081H-QG
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 07:10:39 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 45743e02-5e3f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 08:10:38 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E39FD1F3A4;
 Thu, 16 Dec 2021 07:10:37 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B7BD713C1B;
 Thu, 16 Dec 2021 07:10:37 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id sixlK23mumFaJwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 16 Dec 2021 07:10:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 45743e02-5e3f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639638637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qCkcqvF9ZV5zi1CC7eBkQItURUugCPnjiYcr2/qywYs=;
	b=iuFPK3+8ZhXKnBOIVnK5LrOkr0yExBdNmZjeV4fSfc1xMj70vi2LtKTVrvvrLOSh3pLyPz
	7w7UxPgrSd7PGsb55itJXLi42JbuGUiUCp5EGwQEd38QU8TznI0mPpziAfXxR6ZFRTdv/z
	PeQNfDis7pwAowv0Nkw9eHH4o5daGMg=
Subject: Re: [PATCH] MAINTAINERS: remove typo from XEN PVUSB DRIVER section
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211216065547.18619-1-lukas.bulwahn@gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <d86ed0cf-698c-6462-2877-00015df5a204@suse.com>
Date: Thu, 16 Dec 2021 08:10:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211216065547.18619-1-lukas.bulwahn@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="4iVM68FSkIJBfaBUV71d702BO6JaNb7Iu"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--4iVM68FSkIJBfaBUV71d702BO6JaNb7Iu
Content-Type: multipart/mixed; boundary="gB9ezN0rR4fKuVo87l2lXEQIGX2utGDm5";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <d86ed0cf-698c-6462-2877-00015df5a204@suse.com>
Subject: Re: [PATCH] MAINTAINERS: remove typo from XEN PVUSB DRIVER section
References: <20211216065547.18619-1-lukas.bulwahn@gmail.com>
In-Reply-To: <20211216065547.18619-1-lukas.bulwahn@gmail.com>

--gB9ezN0rR4fKuVo87l2lXEQIGX2utGDm5
Content-Type: multipart/mixed;
 boundary="------------2A921CC5D89A4F8DD335E719"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------2A921CC5D89A4F8DD335E719
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 16.12.21 07:55, Lukas Bulwahn wrote:
> Commit a92548f90fa6 ("xen: add Xen pvUSB maintainer") adds the new XEN
> PVUSB DRIVER section, but one file entry contains an obvious typo.
>=20
> Fortunately, ./scripts/get_maintainer.pl --self-test=3Dpatterns warns:
>=20
>    warning: no file matches    F:    divers/usb/host/xen*
>=20
> Remove this obvious typo.
>=20
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

--------------2A921CC5D89A4F8DD335E719
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2A921CC5D89A4F8DD335E719--

--gB9ezN0rR4fKuVo87l2lXEQIGX2utGDm5--

--4iVM68FSkIJBfaBUV71d702BO6JaNb7Iu
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG65m0FAwAAAAAACgkQsN6d1ii/Ey9V
Ugf+OKlTUHAGiykjOaxuOegitBXlBKHnsEBnTEKJxOULM6xCfCyTOevhjI8hE1TcD0tfog5spMtt
6HQqPL4NZ1hNMP78FiLZg3Werq0BE3pxchcY0UiO99YQPmBpsuIDfMQ6XLBztWLW8tCJU5nRdOUm
F0JNpxA8ueUfjHJ63D8px+wBUcZDd+YgzwMVDjRY/FtJi7bVZEspIxFioDcxydhl/MeRq4CJntbg
7hzgQR+JRJyqwV24elpk+1D6MlkecaPHDiPviG0nm1f5S2srHAMNWDEq1V+1FzGAVzdIruk5C3Ai
deYTKo1Y0HTIyHBJPLNCBgZfQpSyv/o1TOvZLNNDfA==
=mAWr
-----END PGP SIGNATURE-----

--4iVM68FSkIJBfaBUV71d702BO6JaNb7Iu--


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 07:15:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 07:15:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247745.427212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkyk-0000H9-9x; Thu, 16 Dec 2021 07:15:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247745.427212; Thu, 16 Dec 2021 07:15:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxkyk-0000H2-6t; Thu, 16 Dec 2021 07:15:02 +0000
Received: by outflank-mailman (input) for mailman id 247745;
 Thu, 16 Dec 2021 07:15:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0wh=RB=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxkyi-0000Gw-Kn
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 07:15:00 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e0a26c88-5e3f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 08:14:59 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 278031435;
 Wed, 15 Dec 2021 23:14:58 -0800 (PST)
Received: from [10.57.5.90] (unknown [10.57.5.90])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B88713F73B;
 Wed, 15 Dec 2021 23:14:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e0a26c88-5e3f-11ec-9e60-abaf8a552007
Subject: Re: [PATCH] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211206142032.27536-1-michal.orzel@arm.com>
 <f3573439-4893-440f-54e1-fdeba3eb4508@xen.org>
 <dc114877-b9da-7a5b-260d-b9438cddd777@arm.com>
 <b7a53384-39cb-f368-f39b-9b560336226b@xen.org>
 <6ab797ce-86dc-2c32-1cd0-417fab7516c7@suse.com>
 <73913bdf-7449-34fb-b86b-662774cb3e62@xen.org>
 <865fb3a7-76fc-24da-e07d-c6e59e3e1abe@arm.com>
 <3aae0020-938e-d5fe-7d7f-d5d1c8335a24@xen.org>
 <447b6c54-7d0c-132f-6202-c1ae7fb16e5d@arm.com>
 <871bda7e-3f94-a5bd-3caa-16b0c8f6d693@suse.com>
 <87080c9d-803d-608a-1c5a-2102f014d2bc@xen.org>
 <1fcc18d4-70ce-12d1-6d54-ae82e511a4d7@xen.org>
 <040a1871-08ee-00e9-b46f-ca4854e8a541@arm.com>
 <82557218-539b-204a-a1a7-7c796a2baa8a@suse.com>
 <9dc003f8-4dd0-282f-61ce-6ca74c543f20@arm.com>
 <6e54f971-84c3-3635-12c8-643b619b2b53@suse.com>
 <219d27fe-4e77-59f5-b559-4bc70c2a0399@arm.com>
 <4b6c1865-5ded-fe6d-aead-bcd2e5cd4125@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <45d78e8e-8adb-e70c-40ca-9473cb58d918@arm.com>
Date: Thu, 16 Dec 2021 08:14:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <4b6c1865-5ded-fe6d-aead-bcd2e5cd4125@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 15.12.2021 19:25, Julien Grall wrote:
> Hi Michal,
> 
> On 15/12/2021 10:40, Michal Orzel wrote:
>> On 15.12.2021 11:32, Jan Beulich wrote:
>>> (Re-sending an abridged version, as apparently spam filters didn't like
>>> the original message with more retained context; I'll have to see whether
>>> this one also isn't liked. Sorry.)
>>>
>>> On 15.12.2021 10:48, Michal Orzel wrote:
>>>> This patch and the problem it solves is about clearing top 32bits of all gp registers so not only x0,x1.
>>>
>>> That's well understood. Yet for everything still in registers simply
>>> using mov ahead of the respective push (as you had it) is still
>>> preferable imo.
>>>
>>> Jan
>>>
>>
>> In that case let's wait for Julien's opinion to decide whether I should get back to the previous
>> solution with mov or to the stack solution.
> 
> IIUC, your proposal is to:
>    1) Push all the 64-bit registers
>    2) Zero the top 32-bit
> 
> Jan's suggestion is to:
>    1) clobber the top 32-bit using mov wX, wX
>    2) Push all the registers
> 
> My preference is for the latter because there will be less memory/cache access.
> 
> So, this would be your original patch + a compile time check to ensure save_x0_x1 is 0 when compat=1.
> 
That is exactly what I would like to do. I will send this as v2.

> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 08:20:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 08:20:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247756.427224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxlzy-0000DC-FR; Thu, 16 Dec 2021 08:20:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247756.427224; Thu, 16 Dec 2021 08:20:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxlzy-0000D5-CG; Thu, 16 Dec 2021 08:20:22 +0000
Received: by outflank-mailman (input) for mailman id 247756;
 Thu, 16 Dec 2021 08:20:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxlzx-0000Cz-HR
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 08:20:21 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00d0120a-5e49-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 09:20:18 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27--xuTyexDMkii2xQbfIcWLg-1; Thu, 16 Dec 2021 09:20:17 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5326.eurprd04.prod.outlook.com (2603:10a6:803:57::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Thu, 16 Dec
 2021 08:20:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 08:20:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00d0120a-5e49-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639642818;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=LTfFCr2+4IWUIwCXpW+B7oWvdRfx5RdM/OXQuzVwbhE=;
	b=O8CVwa1vhydLnF+jeiZNFIpTbCdthmR5PV2Tr1z0gdqzcPHZBI36pS7jNJJ6f4eCxb8w3f
	6//BXE2s2qZM2BvPt5Zs6F72bHxdD/+4Bk3xPuW/zZwAgTRDKA8VOew7hEU1FPSJqklYLs
	boW4TtxFAGj6A+BKqNZbCcclvP9dM4M=
X-MC-Unique: -xuTyexDMkii2xQbfIcWLg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gsCUup+yD186z3q+v1jJtFgv8bmTd+5e8qUrHlgo97zPrPtbj64lWS9lUpbWESn9kYKAwPq5kLzWWtYZDdC9r1K7pImEbIXf0qGUraxpmYEzARLKiLlxjkqeORQ5M+I9VljLZ37TORXznbJlDPlcKP315GL3zSFtSSE7dNmathqYphqcT0jmc2PxbAVGMykRVXDPNagJ29v3Xv5FKHgzdQYsTNgK1SCUwYqzA6xpvFFgGuV9WJFGl9lFS2zrdFrl3SHcsBjIUNQ24O44/CXmPtyOfvk7zyst0zYdl21Y/E2buMcm0wGTbQLZu3HtcYgNMSnD9EPp8Z4eP9yTZfgywQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kNvgtSniZ8bZ4mekxxI8cWsVmTiwNR4T/2Sb4VG8PR0=;
 b=NiKcAAihE3V3Gnxra4jK4unYvb4nkwYoyZfcDMx8kDkBkBa8ABo48AH2fef5WUaPK9KZGzVmuNdglqnPgKwTtVy3PeE1pxgyw1FieT+KPm4ucazqOsX+V9T+z0Zax8JKKQg4JTXSsNpsxGUkaTxIMcD0Lb39jnm914C3rEejjxoETcYO3so7H/LNDY99NSN3x2q2bfjUTPJlhmAVuTjn6fhefDxdxIt1sskTmnTsW6gmzgY+oThJ+usHDq9dDtuj3b1XmVDzzNFFbZglQCeTdn9iU6hiBuhtMeMUnmCR+xQ3SBoVgasJSSlC9yjUllk9ukZ7jfDmphqyYqSnEw1dDw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a44e6eeb-f803-11b0-da78-d4437ce1a59e@suse.com>
Date: Thu, 16 Dec 2021 09:20:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] x86/cpuid: Introduce dom0-cpuid command line option
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Daniel Smith <dpsmith@apertussolutions.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211214211600.2751-1-andrew.cooper3@citrix.com>
 <b187ef25-bbfa-1880-0a10-462c2ba64e72@suse.com>
 <1d937a49-e0a2-58a2-b51c-495a957adb0d@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <1d937a49-e0a2-58a2-b51c-495a957adb0d@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR10CA0042.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:80::19) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3f182b9b-3f82-4012-32f8-08d9c06ce3a7
X-MS-TrafficTypeDiagnostic: VI1PR04MB5326:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53266465AED2471692F6ECD2B3779@VI1PR04MB5326.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UCT7aT/CnohxhHDiNLmkl32tUedX52JBpc7x1pWtpLy8s+rNq/4pzd8JnDKajOw6SuozfXgS4SbzuaRyrLIOmKNV22Xd72a7SC8x+wizhoZU52E7Z0+aIHceKY8zNQO5mnBNx5biRnNog3yI4FvyIelWVMGIb5d5DAV2Wjsgr5lbXsjQzf9Rnu4rorkiKhW2Va0AzW7wz2aJvQzyHYaOy39GVun0O6ZVW3s7FxlRfmFmDhUo+OtVM5Bz5Yo0DiLCA8/at1w9vHaWv6I+i283MhCeoD7bLF8f69BuAQNbajZSro8F3BJmtPhcjw2BWtYIhRxgk6MvQC3igkjEML3WbWpN773MAc4cqEoR9xdZ5iRC82Iq0xwAqujyWWzV3qyeoiT21TB+GX3iH5EaBZrgS8F3jvN2cLafQv/rmddAjUjA+dCaPmFSa3I/GH6HlwwwJy1zjDRfBZOrR4mHuWSwM7HEyZOmCR6k6EzRq2N+GpWyrKGA7CoBa11E97soW5A+iNfd5t8VzkiTi35Mtvu9tAYh3r6LY5JGW14XZc7u4Zow/6Lz5wNQggQ5EkKifasl/8WDfcWbyHN6Uod7Ynu/qs6xI0EAC/QlHDR3XFa5UUQ7rIWRDBccsbqKRVBW+jQhswqRebjl/cQuCcy592JhHIVzXtTJ1rUX2ySpXdUyv8kPQ8Hrus/mcxhKy8mKkDL+ugWmkv021BNluiJpNL7oPZBU94QpHgSO1MYwv1Bp84w=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(110136005)(6486002)(2906002)(66946007)(4326008)(316002)(8936002)(54906003)(8676002)(86362001)(508600001)(31686004)(2616005)(5660300002)(66556008)(66476007)(6512007)(186003)(38100700002)(31696002)(53546011)(6506007)(26005)(36756003)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?igzmotjWa9ecx/kDE9Dn4GVD3yb3IRaUyKWYSel9PtfGxXh6CYVMXOeMUcpx?=
 =?us-ascii?Q?lHUMfhJ8yyFyPCdbD/oo+Ro5DBcMiera6qLsK67JF/bjwgkhAyt2EuM1iX94?=
 =?us-ascii?Q?q1L37HMF0sQSbqEN+qLMThMWJzP0JVXwppofqTOW+kGKHym9Nn5nvkW/gV6/?=
 =?us-ascii?Q?VnlKdTATJ9hHrjMCQy3jBC0FOs5BmHS0jHOJO6qFpfySrU/x9N/Lv59zU+yO?=
 =?us-ascii?Q?1M+MPbsU6l0KQHAs2kVxpfZXrzZ+dt5S2HG7V9Rtqp55KZTlI8dBlb6Ne/bw?=
 =?us-ascii?Q?tIRCEQD4vk0InQ5GwnQVq9IwjhI9qO3ea05YDRsVFYBJdsCYdbO58YJNXKnE?=
 =?us-ascii?Q?12HK0bVmCKHsDvA+4UxXtPXx3FgPlZleTarXj91Fkkn2V+UWv3gUK/hPK8zs?=
 =?us-ascii?Q?hTqnRoGzS22BafRqMLQsqNg1F4+NqUEARbdM78pXwpJDLtYPlEcpjzvZSXgp?=
 =?us-ascii?Q?6lcOzmpcDLq70V+SZyr3GRKBwIx4h7u2x5wF9FtpD1/Dei1xWeDxFGisb3kZ?=
 =?us-ascii?Q?VlFYpkVF9exlxIeHhKGjapTp3G2IgNx+VqG7NzOD3scHIG7v1yUQDf84j9fC?=
 =?us-ascii?Q?8779ePzTmAoYvyIZy0TLpPk6EZ0blXLsTZ2vIblP4KOhJeK2DJwLtczTnyhh?=
 =?us-ascii?Q?DP7XfQB2Xq1t9ccOBjOSKJZ0ZCtgfvYQVXCjhcVo8n02XQoNiuwF5M1WhJwn?=
 =?us-ascii?Q?Zr7W4XbAE8CpOhSmbeCGFem2mEHJCkqractsSeEhOIN1bPqmXOmobOfWfB2c?=
 =?us-ascii?Q?mlcn8efrgeaaM6aNfY1S0Y0gE4VRknG4yslYxj5PAlEO9rZzmzp6b9IErYrR?=
 =?us-ascii?Q?7DcdvBo6U8lZGm6iZRrfetMkbk+V7HgA2GkQSDIvgydEhnaNe2MES+71EXbQ?=
 =?us-ascii?Q?GrBHRHw4RDL/98SOce67mCsnSIY1DjW9qE9yEVM2WsNPZAGiS73M4m3J+sML?=
 =?us-ascii?Q?5RbwOR8UXO3tVjW1BZDaJkstmEnbPpeNMHSkPZXyDc8NhQ2xFd5arhWttZS0?=
 =?us-ascii?Q?1+XudJgB8Wj6SarxoDWaCbL3ulgyV8obCEJMn8zyadopOJ+CXcXfgD7dKv8j?=
 =?us-ascii?Q?uK2UBf6exPZZea2uzdUhK7scC/b4eAixRblMAX8QGJtlJYcNtZ+4O7LAGIHW?=
 =?us-ascii?Q?g9Qghqs7j2q4xNjg0oKQgzk1WwxW/yvNtrfkCS+QaMJy0zt9bPSHhdh+0tEY?=
 =?us-ascii?Q?jC6h3bjRU6FtETS6gLaZFiAtLn6cV7dAaEcyYE8uhQnbnArTJk8PWf6v80xJ?=
 =?us-ascii?Q?zahAUge4LgTwi5VwVuRwv8IV6zbHa65xhQye+2Pf7hfBxV1X5Iiuv8X5oeGS?=
 =?us-ascii?Q?HpKuRKhQnr91o5YCQo1c/i5su6QLaOvi4SS4NHUEbSyPTOpLCLIzKALAlFzE?=
 =?us-ascii?Q?989WhzcD6pUKMMn3nc29vr8e+0iHsyADjUpyuZiC7Lo2mNPPONpIndgmU4J1?=
 =?us-ascii?Q?Rk+tMn5KlK7uQOxEtjGwpwpUmF4kl9shkYULylPx8H4eLCI5UU1Qj9ZUakii?=
 =?us-ascii?Q?cbQDTKZnEteA+1YQPt1PICxgVj6EKFJlcNNGoJqvl6ha87+L8D41ff8NVFdO?=
 =?us-ascii?Q?7iGeDJN+C5SY+/FwTD8KsVpaaXLJAtmiKrv6Yr2bSt4axLv4oMF8P19qTCHp?=
 =?us-ascii?Q?RoXfXZarJboPyP9VdrtJgJE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f182b9b-3f82-4012-32f8-08d9c06ce3a7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 08:20:15.9681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kdmd9z85bb4Vn64TJJRV1fUUKUGzx/f4vHVmmqKj3OHsI9/RVwuX1UHUvh9cpYuaSL5CcHYe/lb6NrCDMI9A0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5326

On 15.12.2021 13:13, Andrew Cooper wrote:
> On 15/12/2021 08:34, Jan Beulich wrote:
>> On 14.12.2021 22:16, Andrew Cooper wrote:
>>> RFC, because I think we've got a preexisting error with late hwdom here=
.  We
>>> really should not be cobbering a late hwdom's settings (which were prov=
ided in
>>> the usual way by the toolstack in dom0).
>> For ITSC I think also covering late hwdom is at least acceptable. For th=
e
>> speculation controls I'm less certain (but as per the comment there they=
're
>> temporary only anyway), and I agree the command line option here should
>> strictly only apply to Dom0 (or else, as a minor aspect, the option also
>> would better be named "hwdom-cpuid=3D").
>>
>>> Furthermore, the distinction gets more murky in a hyperlaunch future wh=
ere
>>> multiple domains may be constructed by Xen, and there is reason to expe=
ct that
>>> a full toolstack-like configuration is made available for them.
>> Like above, anything created via the toolstack interfaces should use the
>> toolstack controls. If there was something dom0less-like on x86, domains
>> created that way (without toolstack involvement) would instead want to
>> have another way of controlling their CPUID settings.
>>
>>> One option might be to remove the special case from init_domain_cpuid_p=
olicy()
>>> and instead make a call into the cpuid code from create_dom0().  It wou=
ld have
>>> to be placed between domain_create() and alloc_dom0_vcpu0() for dynamic=
 sizing
>>> of the FPU block to work.  Thoughts?
>> As said above, I think the ITSC special case could stay. But apart from
>> this I agree.
>=20
> So I disagree with keeping the ITSC special case.
>=20
> I do agree that a non-dom0 hwdom probably wants ITSC, but ITSC
> explicitly can be controlled by the toolstack, and therefore Xen should
> not be overriding the toolstack's decision.

Well, fair enough as long as there actually is a tool stack side equivalent
of this.

>>> --- a/docs/misc/xen-command-line.pandoc
>>> +++ b/docs/misc/xen-command-line.pandoc
>>> @@ -801,6 +801,22 @@ Controls for how dom0 is constructed on x86 system=
s.
>>> =20
>>>      If using this option is necessary to fix an issue, please report a=
 bug.
>>> =20
>>> +### dom0-cpuid
>>> +    =3D List of comma separated booleans
>>> +
>>> +    Applicability: x86
>>> +
>>> +This option allows for fine tuning of the facilities dom0 will use, af=
ter
>>> +accounting for hardware capabilities and Xen settings as enumerated vi=
a CPUID.
>>> +
>>> +Options are accepted in positive and negative form, to enable or disab=
le
>>> +specific features.  All selections via this mechanism are subject to n=
ormal
>>> +CPU Policy safety logic.
>>> +
>>> +This option is intended for developers to opt dom0 into non-default fe=
atures,
>>> +and is not intended for use in production circumstances.  If using thi=
s option
>>> +is necessary to fix an issue, please report a bug.
>> You may want to state explicitly that disables take priority over enable=
s,
>> as per the present implementation. Personally I would find it better if =
the
>> item specified last took effect. This is, as mentioned in other contexts=
,
>> so one can override earlier settings (e.g. in a xen.cfg file used with
>> xen.efi) by simply appending to the command line.
>=20
> Order of enabled/disabled I feel is an implementation detail.=C2=A0 Perha=
ps
> what to put in the docs is that specifying both forms is unsupported,
> but "this is for developers only" is already a fairly big hint.
>=20
> The only way to make a latest-takes-priority scheme work is to use
> string_param() (creating an arbitrary upper bound limit), and parsing
> the list during dom0 construction.

Why? Simply accompany __set_bit() by a __clear_bit() accessing the
opposite array.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 08:44:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 08:44:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247761.427235 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmNW-0002t6-Fo; Thu, 16 Dec 2021 08:44:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247761.427235; Thu, 16 Dec 2021 08:44:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmNW-0002sz-B2; Thu, 16 Dec 2021 08:44:42 +0000
Received: by outflank-mailman (input) for mailman id 247761;
 Thu, 16 Dec 2021 08:44:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxmNV-0002st-3M
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 08:44:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 677f7a22-5e4c-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 09:44:39 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-nP_8vMQQP1uVV5yc7_wOnA-2; Thu, 16 Dec 2021 09:44:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 08:44:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 08:44:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 677f7a22-5e4c-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639644279;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sDUb8ehC0Gnq0bpbJxJyV3kjbUYoINg1gHPuM/ErDoU=;
	b=l4ltGMJb4wkbfj30r5w6fVxWRTFyMVs+Ei2FvO+O31CXBP+sH7btjF2D0EXlAeQjXE7eM4
	C8OYVC0hTEYgqOWsbfVV/ekRVMmLQTBsykKid5+PrTrEZoCt1OvTpiWLkmw4ZxFzsSCd9q
	8PVcF7aEhU8SoUWJk82NTjOgrqiy96s=
X-MC-Unique: nP_8vMQQP1uVV5yc7_wOnA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GEpdXKP1nOJOsC98+sGtmlZ7lYdEiChgypPoQkppTMGHSVeTv1ckzTCXgo4mpRosFGOdKDLUaKW1k8KsQ7XCSsAUFfFkJKENbacFd416rcvAolrfTfFClSgg5WymccfIQIp3i0HzlWMEbv2PI2mAXIpZL4KBd4iZ4Rh/G/zaIiHpnRJu8joW3f0wmx9d9ZVCuYk1HJLDrAUlo94YYm6usORPH33kxITFgrsW1VCXHO/GMNVGzrNN/5VB298ee1Kh9ZRvaTXdYZfnmNFyfJx5vB7Op3uQSFhlprOwbx2BkgMSdpS/PENlA7EkgY4JxOiTodMJozq5S+SIFlJNTdPJuQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sDUb8ehC0Gnq0bpbJxJyV3kjbUYoINg1gHPuM/ErDoU=;
 b=eb0DSvlghldXTx0HkL+jPBn64C6YV3mYkujsDFQX403CshTQcYFI9sW7EslmszPYR9iZquoZRbgHnafB7CX9eXONDwHq30lfF4SK0lBI4jkUrF0z0DlA+JeWYgLXwe2v9sgwjwSZ7iaQhEu/H/KIsOScqzp1VTpL9GcC1VVLia7DiUv0ON/1tjI1DemTm0w9kLsVAjMLK1JLQnk0M4ESjhjEBEAwwOb/fAFFPtw6pZ9ZSjRiNgYK6oypnP8I8zYBE0BdS3zDxOrFcmWijy8vBZuZEjghqwjGY0soDFuzu508g7/Ul0dB/VPbtwIQxGY0gdKSTC1mrxNOr6VjuS65ag==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <91fabc88-f4d5-aa0d-be8d-1f1ebf465360@suse.com>
Date: Thu, 16 Dec 2021 09:44:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen: make some per-scheduler performance counters sched
 global ones
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
References: <20211216054502.14085-1-jgross@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216054502.14085-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR05CA0019.eurprd05.prod.outlook.com
 (2603:10a6:20b:311::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f0f00638-17e3-4c35-96c0-08d9c07048a5
X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41902BC6F7B5A7B8B13EE938B3779@VI1PR04MB4190.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MOwgZ3vy9RvEXQqEhGMOstMOVNYAeSngV7yy9999D7ennfC7hsxBX2LPB6YdlflxgdSY+esD3ZRhC1V32cDZ+lQiH3Xaiqi8F9Ix/Zt/4MRI3ZAdprCX/b+Mhwdgyrin3ws04v++wER/81kSt3Bbf4ytOGfpmLAyYkwLX4tzOcwb/QEgb0aatBzEN1Ddu12wC34654CG/TphD6W+p8OCZpTQtRdzcCkbr+TYU7UQpED80PgaZxkl50UiTMZS6SEj/WcJtAIiS0gY6UjobKPgdK2Zv+NDzcIQv1ynYwvJKF6GNcPuyDHIwdaSW/B7bIP0fNwvfDTdmSLuO7RXEvpohTOnosutaYHlG08Y0EpUJY/cOgDh/XTVM4rZtkdVGo3jpX9tcLOyg0zMJ7qxmOaP5uChVJTFPpNFaW9ekfI6fxZmydLHaM+KW+pmLTGVv547b8ERF8Ywz6+Tjd2m8BwKLCrCLbGH/OzPAQn5bdiIaXeQ1UOK82Ebvl3V22VxGxaTZgib/yoTa7JgDGn/YpmEg1BrRR3Gz0Y79QXAeDHszOSOLNp22qyeGfIFMZjg01K6ufk5dBVbyvpvSpi+rt08ht0X3PIG7gCoau5PFKLQn7W1IDXbGY1AcEzyUIjoE1M+4x8ZeeXGDhTKBckLDx/alCUMKH/+M16vPx9Cp7H0isnTN4gFPrZnWBnhlYn/+1kR+46u6IZfD82PNB2wDYJqFevJ59+vvz8fGO9Ve3oP157ZOZkL+5hWfQLXyDKgWKoA
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(38100700002)(66476007)(66556008)(86362001)(31696002)(2906002)(37006003)(4326008)(83380400001)(316002)(6862004)(36756003)(6506007)(31686004)(508600001)(6486002)(53546011)(2616005)(186003)(6512007)(5660300002)(26005)(54906003)(8676002)(8936002)(6636002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cm5GcWFVV2ZKTllNUi9BUUxlOTF5eHFlNkZhNHAyLzlLaHVBYVBhSmYycFZl?=
 =?utf-8?B?SEJRY3BHZldPMU82M2VOcHBqN0s2VFQ0cUNWb1JxL2I1ZkhYTzNiNVZOZ1Zv?=
 =?utf-8?B?SUltMXdNa2RDWVZ0aE1VaTZ0aG1mZno0TGcxOEV1QUZody9JY1dLVUtGTzdy?=
 =?utf-8?B?amEzcnl2ZGVmSUp4OS9nejU3dFhGVkdTcFU5RzBSSUJXY1k2eXhTZW0xODAr?=
 =?utf-8?B?ZG1xUXdDOEZYWmJJclRkZU9CbjBqOFUySW4zUlNrRWtISEViRUFrZ3BkOG1i?=
 =?utf-8?B?Mk00aXBmQjZDV0NxREpodGNkd0xURTRHWHdRZEZKOFBGRDFwVjRpblVzNGw2?=
 =?utf-8?B?eFV4MUJSMk1UNjRvcmErNUwvMUR4b1N5TTJYQ2Q2RDcxRHFTcUlWd2IwV1g5?=
 =?utf-8?B?eGc0R2oySWtCY2FtMDQ0Y3hpc0J3am1NdmdRN3VSUDJUYUhLbGZ2aU5CZkJm?=
 =?utf-8?B?TlNkU0NsOE11VTFzK0EwbUNSa1YweFB2OFB0QmROM0tUZUxHU2RjQ21KZko2?=
 =?utf-8?B?ZlRHSkplUGtPK203Zy9JbGdCUnNBOFJKaWdMQzJwQ3FyRHVQa1hJS3lOanBv?=
 =?utf-8?B?MVZjdzFSV0NYZjIrenR0UmdOamFlOFdaaEVRK1JKck5wWDZpNUpqa3AzWmJH?=
 =?utf-8?B?NnhLVjJzcWxjK2NlL3QyL0FpczNLUDJ3aEV0VFo4ZitQUUQ0L1lKVythVFBm?=
 =?utf-8?B?N1JBU3B5Q1NYckQ4cXJGNzIxaGpmSU9vdnZQUEg5WmNSQ3BTRXIvS25ZeUJh?=
 =?utf-8?B?NHZzanlrSW5wUEJJQzhERUhva2xyTVpVWFhKbWpnU1JaVlp5R0cvR0s5M3pm?=
 =?utf-8?B?cnZaNTJIYno1TG92Yjh1U2gzOXF2VHdEb2ZrdDdnK0xYWkV4ZEw5bzZWUUNm?=
 =?utf-8?B?bzRFVW14b25OcU1lTkV1L3hwUXVoV3FqRVFiSUpESHNIRTdlYXVXSlNSYjR2?=
 =?utf-8?B?dnlJeEJFTFFvQjZ1bzAxTzVJMUc0Ni9EbVEzaGhnUXBuYXllN0IrTllwRUZi?=
 =?utf-8?B?YXdiNDZNenFiUXR6WXZsTnI4VGtnZTJyMWpYRUh0OXhZY3hGSVAwakJVNFJi?=
 =?utf-8?B?eStOc3ZlL3RLcVZ2WncrY1VLS1AzRTBWck5QSC9JaTlSUXQvWTlpeVlaSHd0?=
 =?utf-8?B?Mkg5THl5ZUtxQ3ZYUEQxSlNtdTNLVG9LYysyWUdUSnFBUkJHa0duSHR4Ym1a?=
 =?utf-8?B?d3RxS2dFTlduamovT0hERmNTYjhRaWJvNllWWTNtZGpLNk9ZeWkvL3M4Z1Rk?=
 =?utf-8?B?d3F3ZlJ4eG5LVnRSdkdPdE1QQ1Q5cXNyNHl1aFFTVU04eVNvanpoTzJ6WjdZ?=
 =?utf-8?B?RzU1NHI2Q1FneG5DMHBBN3U2QzF5N0ZsckhaTG1XUFpqeThSUFV4WUZmT0tF?=
 =?utf-8?B?bnN1YTJUdGZQN3FKZXA2cXhFMndiK0NmSDBMMEl3dnNQdHF1c1FKMWZlUFNw?=
 =?utf-8?B?NFZBOFJjNWR5WHhFMlZOWXJ3NmhzekIwVVdLcW13ZTdMMEt2bXdWL3dQSm5B?=
 =?utf-8?B?VWJ3WUdQa2szYk5GRUV4bTJ2RkluN3ovRE1BY3NRcWs4TVdaK1BpNHlIY1Rq?=
 =?utf-8?B?NEd1d3lTTlBneEZwZHdsc2RqVVhkcWRHNUppOGVZUlIveittUjlyTCtFbWUw?=
 =?utf-8?B?VFRTY3FRcXA2ellZeXo2KytuMnE5MzMzRGhvaVJuTTlqeVk0WVBkYWZlUXBS?=
 =?utf-8?B?ZFczRjlaVlJ4KzlVSXFJM1R3bjZMbml5Ky81R2JqV3hjZzZjTHFTL05DWml6?=
 =?utf-8?B?NFQ0WkR6TTF6Nzd6Y2RRZ3QydzZSdU4yZDVJYnlHLzVzOFZDeFRSaHVmSWJn?=
 =?utf-8?B?WjFZd005RnEyUFh3ZmpuNU02OSs5bFdNZDEzNENwQUE3UHN1VWx4c1dTQW1q?=
 =?utf-8?B?VUZyeDRVenJTOVhnU2wwdFA0enBDKzRZbmNaQ3hacjhMcUZ5NllhbC9RNHVw?=
 =?utf-8?B?Ym1HN2w4OFlKcmt6UjR6RUhJZzBSRTluSmxNSG84UGtCSWtQTitnQ3c3MTM0?=
 =?utf-8?B?ZXAvS2UrZVBvNXUwUHVFTWhlM0N6UVZjNjduTVErRDY1UXNwNUtRUU1GOCtR?=
 =?utf-8?B?V3JjVXlSeHZMb2hoS0FEYW5VQmZjaEZzeU1pRFN6WS9oTkVOcGdMWS9sNVdM?=
 =?utf-8?B?Yllka2t2NkdFZjZqYnZYTG04SGRjS0NPRnRxTmJFTld4NXZ2VDFWT1ZrNnFw?=
 =?utf-8?Q?YYt8tHYAlfdUxueWOoi5z4k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0f00638-17e3-4c35-96c0-08d9c07048a5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 08:44:33.9006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L7+sQvIahQzQPbFcQoQl4IH5TzGUoxRNt4c9gqjVb0boMuNoKXdHvhb7GngWciIYIfb039HuzaCcOXbImy20/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190

On 16.12.2021 06:45, Juergen Gross wrote:
> Some performance counters listed to be credit or credit2 specific are
> being used by the null scheduler, too.
> 
> Make those sched global ones.
> 
> Fixes: ab6ba8c6753fa76 ("perfc: conditionalize credit/credit2 counters")
> Signed-off-by: Juergen Gross <jgross@suse.com>

As an immediate fix
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks for doing this so quickly.

However, ...

> @@ -55,7 +58,6 @@ PERFCOUNTER(steal_trylock,          "csched: steal_trylock")
>  PERFCOUNTER(steal_trylock_failed,   "csched: steal_trylock_failed")
>  PERFCOUNTER(steal_peer_idle,        "csched: steal_peer_idle")
>  PERFCOUNTER(migrate_queued,         "csched: migrate_queued")
> -PERFCOUNTER(migrate_running,        "csched: migrate_running")
>  PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
>  PERFCOUNTER(unit_hot,               "csched: unit_hot")
>  #endif
> @@ -67,13 +69,11 @@ PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
>  PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
>  PERFCOUNTER(upd_max_weight_full,    "csched2: update_max_weight_full")
>  PERFCOUNTER(migrate_requested,      "csched2: migrate_requested")
> -PERFCOUNTER(migrate_on_runq,        "csched2: migrate_on_runq")
>  PERFCOUNTER(migrate_no_runq,        "csched2: migrate_no_runq")
>  PERFCOUNTER(runtime_min_timer,      "csched2: runtime_min_timer")
>  PERFCOUNTER(runtime_max_timer,      "csched2: runtime_max_timer")
>  PERFCOUNTER(pick_resource,          "csched2: pick_resource")
>  PERFCOUNTER(need_fallback_cpu,      "csched2: need_fallback_cpu")
> -PERFCOUNTER(migrated,               "csched2: migrated")

... at least for this one I question the use in the null scheduler:
At the very least I'd expect it shouldn't count what's being counted
by the other two already (i.e. there would be an "else" missing).
But then I'm confused by the the use of these three anyway: Why do
things migrate under null in the first place? This looks to be
contrary to the comment at the top of the file:

 * The 'null' scheduler always choose to run, on each pCPU, either nothing
 * (i.e., the pCPU stays idle) or always the same unit.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 08:49:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 08:49:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247766.427246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmRr-0003gr-WA; Thu, 16 Dec 2021 08:49:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247766.427246; Thu, 16 Dec 2021 08:49:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmRr-0003gk-Su; Thu, 16 Dec 2021 08:49:11 +0000
Received: by outflank-mailman (input) for mailman id 247766;
 Thu, 16 Dec 2021 08:49:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxmRq-0003ge-0O
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 08:49:10 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 08041317-5e4d-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 09:49:08 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-5MQUPt5cPTGG2V6SJk8UOw-1; Thu, 16 Dec 2021 09:49:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB6479.eurprd04.prod.outlook.com (2603:10a6:803:11c::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 08:49:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 08:49:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08041317-5e4d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639644548;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OgVqy+ZO4hFO4L3NRgHooX0BNsJdR5eIfqOi4Gc7GL0=;
	b=iLkNjEKy8hZqNcYVd8hC/mSfEc1SRjV+94GYLO3KgLxpSsHOicD2lRSAHpxaTOX9H3v+uo
	PPjy1XlKJ8y8Mrsyxr+1viu1KqQSY93Q/GaoisveiJ3Voa4RyHR3pmLogLlUSC/Xe2Jm4y
	4bZtuE3x5B3togdCD89blJNi4sXIvjI=
X-MC-Unique: 5MQUPt5cPTGG2V6SJk8UOw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MTFF2rCzwXGPx35+1g7plWZveIZnDsqzxvCUh8PbuByhOYrZ31WWdWGedSggyqW4zKWDK5uMnJMzZYH4pviJoFYmglbgdB5QInEIYyVltNlCmsWzYv996jscwVkPbLvjbpP3Vb3HhGUVuchxymhQkdIHTM8FUeFIALH8IAzd+ZPTMH3MkITrmF3h7jB/RnSZyZScu/kt1YlnPiBuepG4FRQnArKcF/y47ZZATyn0fqspBv0tABYsEphyMXmRN2tMNvCRTDkPlMYG4ge2sBYPt7YuoJKsLULzUT8uhxXBxSzhjjL31aYBSaxoU1gbnSlTDvyACGnZqH51HGJSLg1GYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OgVqy+ZO4hFO4L3NRgHooX0BNsJdR5eIfqOi4Gc7GL0=;
 b=FCyQL1+r0idpeBQJj5VN0TS//mVk+HZmPaqvOFFRvJzktuoa2ey/p8kK/P1sXZA+/egWxwUbG/3Gqjc82xqdaXPrmajfPq08OM6EY9B7lwqOlAYTrkj8PkCDptS6dIpWHZsiHmWBRfxL8QgFuaLAc+MLl86/dXMcq1Y9lZIeDswjKEH3CdY4wa4fKJxkaA7+OlnKU4HcPBCFZU4q2+PzdwQKhmRqzEn88kLcBpIH+DR3Lu4ua8tFyqX8JR0BAyS9Ya+JTfiWMfiZ688taDtbZKJxd3SjIfVju22l2swWxtTfjs3hNdxsEJZrGCrjYfB02n+ckPX+3CCWrji/pM+V2g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <ae7ba1bc-44cf-9b7f-87e7-f962807ab508@suse.com>
Date: Thu, 16 Dec 2021 09:49:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
 <d0c860ea-2134-d8dd-9bf8-87cd9c1a9305@gmail.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d0c860ea-2134-d8dd-9bf8-87cd9c1a9305@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0502CA0005.eurprd05.prod.outlook.com
 (2603:10a6:203:91::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 970e747d-209f-4fbf-cf2a-08d9c070ea8c
X-MS-TrafficTypeDiagnostic: VE1PR04MB6479:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB6479FC1E2B4A18844944C8C7B3779@VE1PR04MB6479.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LE/bffupFQYvhDJryyIPnPpw2S4Kwss5byB9x2ZAY++Hp6vLnppxeHjsn6v6cEwjpWi41KzRr8U7dngmaJ82/rB9ZNuYoyzFC+RnliAb2BZZAIfGZb9Q802R4/QzJMPqK2N7asHUkyg9+9+7a6pWNhHR9EVOo4f0ZusZLfjRIumoKRgNxhLSnMWjVSMLGWHplCNLTejIN6BgxrX+P3xp6KNlFCCqnMQJ0cdbuZI5mzXzEynL5v63PKCaXj1jtu19YksoVnnO9jUUT7ldNU8+8C58c67ECWoBldmRfbz26yI8b73+DOZ08RDjK/cGmLRVPyE9KSL79ANyODqEz2Pv+wH2lflsAfmNKgazaaRNrkvLoO30AVjWQdlILuH+i2RyM3i6KfLJ3rESaVSGu+vWyF8huckWh0fNr3nr5FSBusJuJF04LuKP+/3xOPdhMrlecjMSniZRyoxgqHnK9Mzv9I8BoPpPY4762NCf75XF56e0nJ+GjtyphBe5j+EiYxcN8CuC7EZxcmp59Guh6ku8CatbULDr3D9B/dnKfiwSAK/dPjFYBOJ5pz2pmygle3zlaPX3ZYXztnlCm3v4WVve6HY+RuIVAnXijLfGgHsRK5xX7aFwi+QITrc29B9yPpeW14C3xrBXcrM+cR35y3IG00AkfDX7zj9MJ7R0ldiKn58Yehc9QNFUDusZlWgER0ZDmHhjmsj2IQJXvmh1oEvWCcFJr5aXblmBEuKEazIoAfDBMkumXM09Un7yCFKQoqlv
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(26005)(316002)(54906003)(31696002)(36756003)(86362001)(31686004)(53546011)(6506007)(8936002)(7416002)(508600001)(5660300002)(66946007)(6486002)(8676002)(66556008)(6916009)(186003)(2616005)(4744005)(4326008)(6512007)(38100700002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cWd3ZWN5TDM0MHJiYkQ4T1RaZCtrZnFKMTh1aitaclhFT1NLK2x0VEVBVkJH?=
 =?utf-8?B?WWdhVWlTMitRekc1OTJQbU5DQ2RZRHlYRjRYNndYK1NZK3U3RUdCdGRzdllS?=
 =?utf-8?B?VFhLWi9YWkNWYTdybmtDSDBEaUljKzhEbTdlNVBzMmhaeWdFZURCSHZadVU1?=
 =?utf-8?B?NlVFZFRmeEhxbkhlR2h2TkdSV0ZyQWRXT0NhNmpHMGZQNHl1bEhGa3J6V0Vm?=
 =?utf-8?B?eS81REZyL01laG44T0NIWUkvTjFQU1Z1YUpYNEJNNXh2MXJtbGdvdFNvWk1Q?=
 =?utf-8?B?dkZYSWhvR3FzRHpsVkp0UXgxSHp5WW5FUXhKQ3Q4cTdCbDBTUEl6WmJzN1ZM?=
 =?utf-8?B?VXVaczhXeVE3OG9NY1ZhS3NVTnZaUXh5MG54VGlacDdHekZYK0Q5blNTUndi?=
 =?utf-8?B?MXNiWUdxT0xqVEJwdzY5amVsQnB3M20zZzl2ZVZGUUN2S3RUTVhiOWY3Vnpx?=
 =?utf-8?B?bU5IYnZnOWtNY2Zpd2RJamxXVXU3Ymd4dnZUTzg3SEZFRlNqbWJSaXNSVmZI?=
 =?utf-8?B?VDhQa0UrckNWREhIOHVCNFJ1REE5L1NxaWUzelljMS9Qb0ZldkE5MUtyNGVl?=
 =?utf-8?B?WHdtZHZYMzd1NlZJVm93RGNWa0VLTUltWkVnMHk5czQyM1VJS1J1bjJJcDlD?=
 =?utf-8?B?ZUQwdE9qNVp4Wllta3pIak5mZnpOak5TZzdXSHU1NkF4T0g2bkN0T055Rmd1?=
 =?utf-8?B?VTRUVGk0Um9oSGNaVTdTWUNJYlUxQ2M1ckpLN2FmOFNnbjE5RGxTdTJFWFZI?=
 =?utf-8?B?bEVWMkwvMXUwa3FxT01GempaanBXdWJVbGx0R09kNzliT3dCMGJZL3pMeEdG?=
 =?utf-8?B?OEpWaGtHUHMxcUpyM1JEVUptU3Y3QWRGdDloeUliM25JTnc5ZlZoTVJteFpk?=
 =?utf-8?B?OVBid1JuaDdwd0cvYnFUb1NjcXJndVBHdUFhWHBab0FwRG5yUVZJTmF5Y1d4?=
 =?utf-8?B?N1BGSUx1cytZM3ltVlVzb09TSTl5dTB0MEVBejVoVjFLRldTNEkvWE5zYU9J?=
 =?utf-8?B?MzZqSlJHLzlLdEdPa2tVN2QvVzhBU0gvVkw0TEQzU0d0T3dzQ2R3eWxJUmhk?=
 =?utf-8?B?aEI2MUhKck1reTdTRDdJLy9jaTV5c1VxY3BVNEp3elBIa3lkUkpiZndwOWZD?=
 =?utf-8?B?aGtVNEtuWEpQSEppaC9hd3Q0aDA1R0svQUE1MGRHZkZxa2VQQ1ZDUU1Wcytw?=
 =?utf-8?B?NUFNb3F3SFF3OXRxSk1wNE1CMW5rMzF5bDZIUStiYXExS3dTRkU2bVNpL2pX?=
 =?utf-8?B?Q0FZSW5BRjNndUVEOCswaWkvalNGNGlJcDNGcy9NNG1HMmJTYUVBVmlsMXdT?=
 =?utf-8?B?VTFvdkREUnh3Tnc1MXRPM0p6TkVQK2tlbDJ1V2dFM1paQnA0VHdxS3I1Z2Z3?=
 =?utf-8?B?a09VUWZrb0JjZHlFcHpwNUhxdjBRY0t1ZzU0Umh0M2JVMTU5ODlFNTh2bW83?=
 =?utf-8?B?ZmVGM05Xd0NlZit3b3UwQ1kwQXNwZGRybW02WWYwNU45bnhZKzhXOTAxYmRF?=
 =?utf-8?B?emkzWGFIaDFncjA3djYzSjNYYkJIc01oQ2l1U3F1K3B0MGgxdXB5OHQ4czJT?=
 =?utf-8?B?S1J0cW9oTHZHYXFIa1Z6V3A3Q2dJMUtmcUZ1UGxZVUlRK2RrSWlXcXFMNG9G?=
 =?utf-8?B?TUplSm02QVo2VTBpN2I1bUlobzZKVzZHRTEwZkdlclR3cVhSU05HcWc5VnNC?=
 =?utf-8?B?SEkybmpGamt5SjcySEF3MC9MRFFwTGFqWmUvazAwNWFKcEN1b0kyL3hYWXpO?=
 =?utf-8?B?Q0dKWTNMUlpxRC9nV2c1Wmd6N09DWUhLa2t3dUlEZklDRzQ2Q09SUU8zek5K?=
 =?utf-8?B?TEllTjNMbWpUZ0pmK3FGODlZY213Yk0rdllSQTRkSGwxWWZhQWxXaGdyR2VW?=
 =?utf-8?B?TTdoVVo4QnovNjdUaFJJSmEyZGZJdEtaQnRkYkRucVhXVHpGbVhCUVVGd3dH?=
 =?utf-8?B?ZjlQdlZ4TndtUzg5dHpTSnl4c2NmQjR1U2lYZGNiaTFzSkhqS3FyTkUvTFRs?=
 =?utf-8?B?YXkzaEY0Vnp1Tjk3azhzWlIwcCs2b0JQRjhxL0FiKzFhcG5wa0t0azVTbEpG?=
 =?utf-8?B?a052UXZyV2owV3pVY2RNcWkrV3kwWkthSjY3bmxjbFNkbFVLaVNybVRCTU94?=
 =?utf-8?B?bStkMlNCV0o4cnF0VnBBaEdIZXR5UTM5WFhmSzlwLzVJbHFlVWMzRHQ0QVBz?=
 =?utf-8?Q?llKLjQ1FBsKUY80B6rN5yfI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 970e747d-209f-4fbf-cf2a-08d9c070ea8c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 08:49:05.5511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yboQ/6B7xA8x9jJL79g/RQ2HKNpoE9yLA2AD8Ldro24ADRtScxLiQQQsKM/MFBZgQuIuxpXxgMeK709gvZOF9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479

On 15.12.2021 16:28, Oleksandr wrote:
> On 24.09.21 12:53, Jan Beulich wrote:
>> Having a separate flush-all hook has always been puzzling me some. We
>> will want to be able to force a full flush via accumulated flush flags
>> from the map/unmap functions. Introduce a respective new flag and fold
>> all flush handling to use the single remaining hook.
>>
>> Note that because of the respective comments in SMMU and IPMMU-VMSA
>> code, I've folded the two prior hook functions into one.
> 
> Changes to IPMMU-VMSA lgtm, for SMMU-v2 I think the same.

Thanks; I wonder whether I may transform this into some kind of tag.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:21:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247775.427260 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmwO-0008Bo-L9; Thu, 16 Dec 2021 09:20:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247775.427260; Thu, 16 Dec 2021 09:20:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmwO-0008Bh-Hq; Thu, 16 Dec 2021 09:20:44 +0000
Received: by outflank-mailman (input) for mailman id 247775;
 Thu, 16 Dec 2021 09:20:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxmwN-0008Bb-Vr
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:20:44 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6f878b22-5e51-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:20:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6f878b22-5e51-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639646441;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=Eenr6lVD8mBTFntcyKC5oakyauxRxLv4WtMuAgZ9/Ls=;
  b=ZYvLpJxIgdceuXz/l95s5nUrb/iAvcr/bvyJ+hdEWhWXhN/nePvf45hZ
   6q8G+m53llCRYi6N3SsKMzs7ILEG9/P92MWyLS8Vjr5bxuU7Ji+EFKYJO
   fRlvGIy5BxVRU/xrIsPRthgb1JMycURSxi4Y4a09Wy9CBLlNjGx2Lrc13
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: EPJrtohJ8BvwO4jZmg+19QEbZHVQU9XnQqndS0RlQysaEVXV731Fz/mjNvyVMokAk0I8K0E5SG
 mXGLuq3ZLV8/90mRrZW4YYvzZlUVA5TJoVp2iNUuhmr83mAgID8gnOHBpysbCbpFruYPKWrDZP
 lGZLi374vmxQSrgfc8V8Dd9AXG4KXdeOH3XT2AmTFoeOXtnqnPPIyj2vSmQ8t9WoHSnKtRsQV5
 0QczDLZ6p4V/0GqW3rRDX1l4nojIBqSasPFhZgiFo8OCV9zN+f14di7zTYw8wJilWBbPzx80Fc
 wR1j/jQ/l7j1aKpQSBNHBngf
X-SBRS: 5.1
X-MesageID: 60104168
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HvPiOKOyF+Puxr7vrR0GkMFynXyQoLVcMsEvi/4bfWQNrUoi1mMEy
 GYbX2vQbvbYZ2Cmc95xad6y8k4Hv5TUnNIySgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo2SXvtRSx
 cxSjKPqdgl1D4TFp9wjSzANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgm9p3pwXQ6a2i
 8wxaTlNVwyYPxZ1CE5QM7Zuuva4j37fSmgNwL6SjfVuuDWCpOBr65DvLd7Ud9qiVchT2EGCq
 QruwWP9BR0LMc2F/hCM+Hmsm+znkDvyXcQZE7jQ3vRnmkGJz2ofThgfT0KmoOKRg1S7HdlYL
 iQ85S4GvaU0skuxQbHVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQEnsIrQT0h1
 neSgsjkQzdotdW9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHeTJob10yVCIw5Sejs04OzSWqYL
 y22QDYW1qsyie0GzrqCwgr4jW6dj5H2djAtz1CCNo661T9RaImgbo2uzFHU6/dcMYqUJmW8U
 Gg4d9u2t75XU8zU/MCZaKBURezyua7ZWNHJqQc3R8FJyti7x5K0kWm8ChlaLVwhDMsLcCSBj
 KT76VIIv8870JdHgMZKj2ON5yYCkfiI+TfNDKm8gj9yjn5ZLlXvEMZGPxH44owVuBJw+ZzTw
 L/CGSpWMV4UCL580B29TPoH3Lkgy0gWnD2IFM2qlEv3jODGPxZ5rIvp1nPUNIjVC4ve/23oH
 yt3bZPWm32zrsWgCsUozWLjBQ9TdiVqbXwHg8dWavSCMmJb9JIJUJfsLUcaU9U9xcx9z76Ql
 lnkAxMw4Aev1BXvdFTRAlg+OeyHYHqKhS9iVcDaFQ3zgCZLjEfGxPp3SqbbipF7rrE+lqAtE
 KFeEyhCa9wWIgn6F/0mRcGVhORfmN6D3Gpi5gKpP2oyeYBOXQvM9oO2dwfj7nBWXCG2qdE/s
 /ur0QaCGcgPQAFrDcD3bvOzzgzu4ShBybwqB0aYcMNOfEjM8ZRxL3CjhPEAPMxRew7IwSGX1
 ljKDE5A9/XNuYI87PLAmbuA89WyC+J7E0cDRzvb4L+6ODP05G2mxYMcAu+EcSqEDDH/+bm4Z
 PUTxPb5aaVVkFFPuot6MrBq0aNhuIe/++4EllxpRSyZYU6qB7VsJmi98fNO7qAdlKVEvQaWW
 16U/oUIM7u+J864QkUaIxAob7rf2KhMyCXS9/k8PG7z+DRzoOicSUxXMhSB1H5dIb9yPN93y
 OstopdLuQm2ix5sOdealCFEsW+LKyVYAakgs5gbBq7tixYqlQ4eMcCNVHeu7cHdcchIP2krP
 iSQ1fjLiLlrz0bfd2Y+SCrW1u1HiJVS4B1HwTfu/bhSdgYpUhPv4CBszA==
IronPort-HdrOrdr: A9a23:9+iBW64RUYRvDIzaOQPXwMTXdLJyesId70hD6qhwISY6TiX+rb
 HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78
 hdmtBFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60104168"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Jan Beulich <JBeulich@suse.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>, Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
	<julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "Bertrand
 Marquis" <bertrand.marquis@arm.com>
Subject: [PATCH] xen/build: Fix `make cscope` rune
Date: Thu, 16 Dec 2021 09:20:14 +0000
Message-ID: <20211216092014.707-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

There are two problems, both in the all_sources definition.

First, everything in arch/*/include gets double hits with cscope queries,
because they end up getting listed twice in cscope.files.

Drop the first `find` rune of the three, because it's redundant with the third
rune following c/s 725381a5eab3 ("xen: move include/asm-* to
arch/*/include/asm").

Second, and this way for a long time:

  $ make cscope
  ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
  find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
  cscope.files
  cscope -k -b -q
  cscope: cannot find file arch/x86/efi/efi.h
  cscope: cannot find file arch/x86/efi/ebmalloc.c
  cscope: cannot find file arch/x86/efi/compat.c
  cscope: cannot find file arch/x86/efi/pe.c
  cscope: cannot find file arch/x86/efi/boot.c
  cscope: cannot find file arch/x86/efi/runtime.c

This is caused by these being symlinks to common/efi.  Restrict all find runes
to `-type f` to skip symlinks, because common/efi/*.c are already listed.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>

Anthony: I looked through the remainder of your build series and I cant spot
any edits to all_sources.  Apologies if I missed it.
---
 xen/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/Makefile b/xen/Makefile
index 2ad7da7ad67b..dc6bdc44c7a2 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -468,9 +468,8 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
 
 SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
 define all_sources
-    ( find arch/$(TARGET_ARCH)/include -name '*.h' -print; \
-      find include -name '*.h' -print; \
-      find $(SUBDIRS) -name '*.[chS]' -print )
+    ( find include -type f -name '*.h' -print; \
+      find $(SUBDIRS) -type f -name '*.[chS]' -print )
 endef
 
 define set_exuberant_flags
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:22:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:22:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247778.427271 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmxN-0000Hq-Ut; Thu, 16 Dec 2021 09:21:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247778.427271; Thu, 16 Dec 2021 09:21:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxmxN-0000Hj-Ra; Thu, 16 Dec 2021 09:21:45 +0000
Received: by outflank-mailman (input) for mailman id 247778;
 Thu, 16 Dec 2021 09:21:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0wh=RB=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxmxM-0000HZ-Rw
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:21:44 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 94e36c82-5e51-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:21:43 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F30E1042;
 Thu, 16 Dec 2021 01:21:42 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.5.90])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 895EC3F774;
 Thu, 16 Dec 2021 01:21:40 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 94e36c82-5e51-11ec-9e60-abaf8a552007
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on entry...
Date: Thu, 16 Dec 2021 10:21:34 +0100
Message-Id: <20211216092134.579-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

to hypervisor when switching from AArch32 state.

According to section D1.20.2 of Arm Arm(DDI 0487A.j):
"If the general-purpose register was accessible from AArch32 state the
upper 32 bits either become zero, or hold the value that the same
architectural register held before any AArch32 execution.
The choice between these two options is IMPLEMENTATION DEFINED"

Currently Xen does not ensure that the top 32 bits are zeroed and this
needs to be fixed. The reason why is that there are places in Xen
where we assume that top 32bits are zero for AArch32 guests.
If they are not, this can lead to misinterpretation of Xen regarding
what the guest requested. For example hypercalls returning an error
encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
would return -ENOSYS if the command passed as the first argument was
clobbered.

Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
Add a compile time check to ensure that save_x0_x1 == 1 if
compat == 1.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
 xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index fc3811ad0a..01f32324d0 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -102,6 +102,30 @@
         .endif
 
         .endm
+
+/*
+ * Clobber top 32 bits of gp registers when switching from AArch32
+ */
+        .macro clobber_gp_top_halves, compat, save_x0_x1
+
+        .if \compat == 1      /* AArch32 mode */
+
+        /*
+         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
+         * Add a compile time check to avoid violating this rule.
+         */
+        .if \save_x0_x1 == 0
+        .error "save_x0_x1 is 0 but compat is 1"
+        .endif
+
+        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
+        mov w\n, w\n
+        .endr
+
+        .endif
+
+        .endm
+
 /*
  * Save state on entry to hypervisor, restore on exit
  *
@@ -111,6 +135,11 @@
  */
         .macro  entry, hyp, compat, save_x0_x1=1
         sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
+
+        .if \hyp == 0         /* Guest mode */
+        clobber_gp_top_halves compat=\compat, save_x0_x1=\save_x0_x1
+        .endif
+
         push    x28, x29
         push    x26, x27
         push    x24, x25
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:39:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:39:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247785.427282 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnEd-0002GF-FC; Thu, 16 Dec 2021 09:39:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247785.427282; Thu, 16 Dec 2021 09:39:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnEd-0002G8-C6; Thu, 16 Dec 2021 09:39:35 +0000
Received: by outflank-mailman (input) for mailman id 247785;
 Thu, 16 Dec 2021 09:39:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxnEb-0002Fy-Rl; Thu, 16 Dec 2021 09:39:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxnEb-0003pp-A5; Thu, 16 Dec 2021 09:39:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxnEb-00061H-02; Thu, 16 Dec 2021 09:39:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxnEa-0000rI-Vl; Thu, 16 Dec 2021 09:39:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=VapJndg0JH2CUbs1+aCYae9WrmnXJ6BnrOoQ9IgZH78=; b=S+sZnNsPPmQDT18qNBAUKo3f7b
	Xm/65Qf75kb95NNPxTbIlYCyq87FF6Gfi/Gm2UXUtXy5j6R/8ZR5RkGBCd3wD1KoC9HIJTVsOmeJD
	7jC3uKcMn5mLf1EAxQF87foc1QrSdjEzA5cHVJ+88gKTilYA8H4Hvu3DnPWAlStiTTr0=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167438-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167438: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2b14864acbaaf03d9c01982e243a84632524c3ac
X-Osstest-Versions-That:
    linux=5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 09:39:32 +0000

flight 167438 linux-linus real [real]
flight 167447 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167438/
http://logs.test-lab.xenproject.org/osstest/logs/167447/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 167447-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167404
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167404
 test-armhf-armhf-xl-rtds     14 guest-start                  fail  like 167404
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167404
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167404
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167404
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167404
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167404
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167404
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167404
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                2b14864acbaaf03d9c01982e243a84632524c3ac
baseline version:
 linux                5472f14a37421d1bca3dddf33cabd3bd6dbefbbc

Last test of basis   167404  2021-12-14 04:11:09 Z    2 days
Testing same since   167438  2021-12-15 19:40:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexander Egorenkov <egorenar@linux.ibm.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Heiko Carstens <hca@linux.ibm.com>
  Hu Weiwen <sehuww@mail.scut.edu.cn>
  Ilya Dryomov <idryomov@gmail.com>
  Jeff Layton <jlayton@kernel.org>
  Jerome Marchand <jmarchan@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Niklas Schnelle <schnelle@linux.ibm.com>
  Philipp Rudo <prudo@redhat.com>
  Randy Dunlap <rdunlap@infradead.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sven Schnelle <svens@linux.ibm.com>
  Wei Liu <wei.liu@kernel.org>
  Xiubo Li <xiubli@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   5472f14a3742..2b14864acbaa  2b14864acbaaf03d9c01982e243a84632524c3ac -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247793.427295 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnSw-0004jW-Pw; Thu, 16 Dec 2021 09:54:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247793.427295; Thu, 16 Dec 2021 09:54:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnSw-0004jP-Mx; Thu, 16 Dec 2021 09:54:22 +0000
Received: by outflank-mailman (input) for mailman id 247793;
 Thu, 16 Dec 2021 09:54:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0Qa=RB=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxnSv-0004jJ-4W
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:21 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2292947c-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:54:19 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2292947c-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648459;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=szLyY7DcmobVGvk5LYxgpYXRbR5JQrtZcU/lfNYs3mw=;
  b=Ibvb81ZA73Kejn5FaekfJbCTn6/HrQjdi0cGo3tBWQeQmGxFFU7Uqy10
   f+VRszzNB7Qn9NMcikgaS1a9Y77hWCqpwF6og8UCk0gAf+7aEHFSCWJpZ
   oBYT2wXAm0J/AnKk58vYzNdXxMbH45uA9c+Gt0M8K/k2w791DTafWEXBt
   0=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Tzt7NAjVVgNBoVIYh6zSQtyS4gQ3eikQCezd7CyUkZ9NOhJYtbsajZO8Xn3Fu6CtCxVg88cLfY
 ONOFai215HYN1ji+HtCJfkaoyNeJIYSGKnmisAoNMrR1EdrX7x7mkXBEdy4TZ/4ZxwtMK8UOSj
 /YgcaGV6sY+kIYTcgqVQyX0t6jx9sDKx6zV6zQlzxbI0eFPO7F3IlGsvoi7v0RXNI+rWYwfXmk
 rOQdOW66ORQx942/fEepFDh+0NsN2lBMuzZGhj2wGF2ziV6mNr+lZeWtb8qmjMeu2m9nDTCcuH
 7h5n3C7JTGN6NI2DNAWQgbeO
X-SBRS: 5.1
X-MesageID: 60159700
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Tma9hq4MIkrWborL5kQcVAxRtOfAchMFZxGqfqrLsTDasY5as4F+v
 mVOXW2Db66MZ2uhfIwkYI2/8kIP6J/Vn4diTARvryo1Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Aw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7
 9FO6o2PTAoTMfP+o8EHfiVHMDk9IvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgm9p25ERRa62i
 8wxZxhpLzfGUk11JmwlC5AiuMHvvXCkSmgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6Iq
 2SD82nnDxUyMN2E1SHD4n+qnvXIny7wRMQVDrLQ3vxgjUCXx2cTIAYLTlb9qv684nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlajuh1DSuVVHtc1tjO277D53xm6HisbG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DFDFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBvWAlexc0aJ5fEdMMX
 KM1kVkLjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+
 XTVZ6OS4AOXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:2RBusKEtWV+WEPDvpLqFcJHXdLJyesId70hD6qkvc3Nom52j+/
 xGws536faVslcssHFJo6HmBEClewKnyXcT2/htAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO
 JbAtRD4b7LfClHZKTBkXCF+r8bqbHtmsDY5ts2jU0dNT2CA5sQkTuRYTzrdHGeKjM2YabQQ/
 Gnl7V6TnebCD8qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPof2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0auSwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7vvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WrAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 ZT5fnnlbZrmG6hHjPkVjEF+q3vYp1zJGbLfqE6gL3V79AM90oJinfxx6Qk7wA9HdwGOt15Dt
 //Q9dVfYd1P7srhJJGdZc8qPSMex7wqDL3QSuvyAfcZek600ykke+D3Fxy3pDsRKA1
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60159700"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eEQJIdOer2jQA/vN2sblRFwPC7/F/0Z1Ql/0Gbck0R07gDc2MkEdvg3YgOu8eP/3uZDSjzE+8nvNKFEwHTwLREYUSw5BZoVLOwz84CLrcZ7e+6Srtv6dywUhHzkVcC4DszP+uvuOF3Xe+48eokk6U9g6iUQ0Xwh0BU5ylOhGd6LHuP1g2o9h4EMzvztbeMIx5bYbWXqckdz5lRitIDAPtfhRqiAQ79oInKMolFNzudZXgYffzR+7WR4a6tJHMaksKMLR5buXgllCVZYEovG4Cjz2c7TL0x1FzDKt5AAc3nk1Gl4MCQJSCBDQ/znj6P1y/5XxCmHxPDyN8+ZODP8FTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ifj/s1+DTiS4db5Jgx1vQe5DmXzeizJkdHFj9VeABKc=;
 b=aA+BiQJsLPBZLvYDFZ7DUh0FYTPkM+yAzCV48hmGWyzH0uf/GDPiwHhqKwmWaJQC6cERyxpjjgR2KwPtZLfQxZYtzthCrs5D1dQgLtpL1VAGOKpoYUsaKgQxncC6lhk83an+FFOF2UpoT6OE2ijo6YyDw3nVzw+sVKUqMIM6m/XcZofciJWB0SgyHSFieuphvTmUeL4bmF67I53MXEme3uHFhGf9leZiomCuo20QfIR4aL0GF+fxNT/Et9v2XHGUb0xwb6ZkyKCTlajAw1Qv9ysebv+T8DA4AMuS7G4FirFyis8VCmXGHEzKN2yHS6tVH06Kjpl6t6yVeRvAQhX/oA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ifj/s1+DTiS4db5Jgx1vQe5DmXzeizJkdHFj9VeABKc=;
 b=ewKFQQDW4S540UWNHmtP7YfR/BhsvzCNOuI0JehTvTlFdadUD7S0iPUo+BILEct8R2VbMsv45kasbmFvYFn4PvsHnYRc0kXORraIH6Mwgmrtb5G6p+rryTasIVgjgMxfh/PEPMiknXBorqnUaDmcOoCvVCMA2Y7o7nZJDTIaosg=
Date: Thu, 16 Dec 2021 10:54:08 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should
 be UC"
Message-ID: <YbsMwIYFULP5sXQP@Air-de-Roger>
References: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
X-ClientProxiedBy: MR2P264CA0183.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::22)
 To SA0PR03MB5610.namprd03.prod.outlook.com (2603:10b6:806:b2::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4a76e934-6e81-45dc-15f6-08d9c07a0411
X-MS-TrafficTypeDiagnostic: SA2PR03MB5818:EE_
X-Microsoft-Antispam-PRVS: <SA2PR03MB58185E2581F96275840BED118F779@SA2PR03MB5818.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YykwrkjkImRN72yrOqKn6+OMg3KFkUwobIOQnBzB/6c7uf/heyidLjpou4qyqpjJ1IgIaQ25CUkCZYDqbYjqAJCFADqf+pPFZGpLfV4hxnTF1r8fKhjWoF23Dh/0eC+a7kkKEs/dyZSajLBdYYuoIDGF5NPLKfd4mq01fdARHngTHY9G/FXdtkqi5SjtWlCT9HvcyN3nn5Mgj21nNRidwMhJe3RIQcHRPgBCH/fbqn60sD8qbpDbGJe/z5M/NML/DIV/j8N8U4o+bYguodOYjmF0RO2Eo/63lLpYNAZ2ZxwmLbV6+mHpho8dDrQ05ua9i+aPSTKltV/9bYgNmHcWohn+C1aHjvqUDGYMzCAgip93G8s4aADol6+a+Dikk5xUFkB1hvLJn0vMlRayD0Kh+POoWMVeuabGZwtLj61qpbElkjipAmsDoNaAgcxZLRwxSJmZ/vXpldrsB71immpgvucDfr2Wm3UpUMIhuBUgq8LbB3kWtRaKcjVrOU8LH7S8F5wGWYbX45yMK6o1hjHsAJTo2TDuBLrGd/jg70TowKGIYxiB9tLCgvjp/jSlEy53HGy09jVJBD8NxSLmX96Bx99+im8Dt0r6Kqv6fhJ57FJfPilLfTZFgCZRSkh2C2TcrHcaeywg2yfXhdaWz9qp8A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR03MB5610.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(2906002)(33716001)(66476007)(6486002)(8676002)(85182001)(508600001)(26005)(186003)(66946007)(83380400001)(6506007)(6666004)(66556008)(5660300002)(9686003)(8936002)(4326008)(82960400001)(316002)(6512007)(38100700002)(86362001)(54906003)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2oyV2ppUnZhSmtySWFNRHI2U1VxaWRkVUc5TnUzcGtpK3hNMS94V08wV3FX?=
 =?utf-8?B?QXVrZHpVdTFKWE01Rk5OUXFZMmZjOXVYbEFGeVpaejZyRFJIY09MMVh4dWZH?=
 =?utf-8?B?M2pjQXNKTnRWWGhySlpFY3VlN3lxTlNhcHhqL0dwamxtdFI5WFlPRzA1Smt0?=
 =?utf-8?B?OXJURTY5NFhBRVFzUGFKTDcyWmRvM3oxRVRxUEtkTkZrMHhLRHpIdEd2dWxt?=
 =?utf-8?B?MlovbDkwQXJCdVpaNjRpZk02a1NmQThybHltcGorSEtQRjkycTZ4aVJ6dWEr?=
 =?utf-8?B?Qzl1SkJMTFR0QStqazFFMUkxSUt5NkwzUEdPNWphNWJFYmhSNUZNcU9KM1Vk?=
 =?utf-8?B?cVQ3ajcyWlpyR2g4WmphMHBHT3RSdWJxT1FvbXBRbWNwemdtRlQxRkNNT2JR?=
 =?utf-8?B?b3NlNVJoc1FHV29DYWlWdlpYRWNCTUd0aUc2Uk5ZMmZ4OHpDZzVLOTIxUDhj?=
 =?utf-8?B?Mnp3bXF2NEZ4bEg2YTBTNDZTTlQvTk9lUWZUc0l6UkxhWURxbk45VmhLd3dG?=
 =?utf-8?B?MUhqem80aHkxNjROUWJ2QXJoVDZrZUZEZjkwaGgybmNjd0lwK2YzZFZteG9I?=
 =?utf-8?B?c2RNSkFkMjBPR2krMzdxRndoMUFwRE5Cc2xtVXFibWYyc1UvNE85MXNzUkhx?=
 =?utf-8?B?STh1VUdSQTdQTHRUTHB2eE8zam1mN20rNTdLNVE0aXpjbEkwajVSVk5OREJM?=
 =?utf-8?B?SXNlYThnK2ljU3BNN1g3bmwrTFQvU3JncjJsNjFjOTRDUEk5UmlPYnZNc1Jz?=
 =?utf-8?B?Vk9STzQxc0dZMGdSUGt0QVBCK2hHL09SNkQyU2lwRElRam8ydExSZnFhVW14?=
 =?utf-8?B?R09DK0l4akJiQWVsdUJZckQveEZSeHJvS2svcDIxaFltb3dxcTU1RGkzQVJp?=
 =?utf-8?B?QnNma2l1VWlwQ21TaWw0VlQyQmsxSnpvMDZXTjYyNS9QbXllV1EyMG9BYzhm?=
 =?utf-8?B?WlR6T2VndGtadlBEWWw2c3ppM1doZHVVTGxndUpUaVFNbXpMSEg5VlRtSWln?=
 =?utf-8?B?dEk2a1I3allHU0srOVRSbVJCN1A3QVlxM0VlY0lNbWtjYm9mUG5nOGNOcHFL?=
 =?utf-8?B?S1h5cmhHbEczeGw2ZlZFbzFxUFMvM3ZkOVhzNWhndnJLb3dUR3krMzhFWWZN?=
 =?utf-8?B?N2x4OFZobHVHT0hnd0VMU0xBaW92N01sYVZOOXpTWnRqVjVOQklIMDFyemJU?=
 =?utf-8?B?cEFUd3BBTGRlSS9QbjRpdkFkcXY4M3l5eEJONXdmQzErdGZZbmcyR2xMUCs5?=
 =?utf-8?B?Q2pmenVHUG83NUhMWVBmbEV0UEk1RUlyZDlVN2FkVEFXVzVyUlVWdmtVc2N4?=
 =?utf-8?B?ZTJsMkdTcHdYbFAvRC9vUWMyeEQrY0p2K0hJcEhYaU9XZ281YlBEaStEOCtu?=
 =?utf-8?B?OWlYQzk3Q0VtMERhRjd0NXc2NE9WcnR6dUszdGpSaVpjNUI2bU9SWDhrMHhv?=
 =?utf-8?B?YlVIemtsQ2hZZEkrcTlOVVRoZFo3azkvd2J2NHpXa01ZaUpSN2pvUXh5cHdZ?=
 =?utf-8?B?WSt1ZXNUWVZnbE10UGw5Vit3WHdmTVkrTHhvM095UjZFdHV2d2tEWmdOQ0Vi?=
 =?utf-8?B?elYxZU01VitiVkdxbUtOdk5NR1JQcjFkcmtoV2Q0Nll4cTRWczVLQUJhNUU4?=
 =?utf-8?B?eUtabis5T01EeE1lUUt4T0JLaTFralBPQ3BKbXV4SEloL0pZT3JJRGVEN0Zh?=
 =?utf-8?B?U3NaZER1YUNPOTJZNHVMNVE3N2xDMkVXOWlRU3JJYUNCNFdKOCtiTm00RUV3?=
 =?utf-8?B?am8ybE9lRnhBd2grMjdiS3JZTHlveWJheEdQazk1ekxKb2JEQ1pqRFl1ZlVO?=
 =?utf-8?B?OWdodFdwelhuSVp6VWRNQlZsTW4yb3FiK2UvRlpid09YQm5ISTFheVdyVmxx?=
 =?utf-8?B?a1hMa2dYSU13RHkwbjViWi9QZ2ZIdzBPV05Nd3pBZ0ZCanJ4Q1lQZVBObGRx?=
 =?utf-8?B?aHFXNC9xMmFqZXhBVlh3NFl1RDhTSmVyTGdlY3d6L2d4UENjY1oveWZINTdh?=
 =?utf-8?B?d3RVbjRJaVEvYlpiOUM0alU3dXpGaWozQVhWTGtZaVgrMEdYTWtFT1p0YkNj?=
 =?utf-8?B?ZTUyQ2JaZlJ2MXpHQ0tUSmV2aVZXTVN4eE14TWNzOEE1NUpaTXhDQ0drMk0r?=
 =?utf-8?B?d2h2ZHoyMDRVMmpCd0p1SmtOdUpnK3g4SC9DQndld28vVVA0OWdXTjBTNUdU?=
 =?utf-8?Q?L2rjzF1yAfHMg/zmAQBEfz0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a76e934-6e81-45dc-15f6-08d9c07a0411
X-MS-Exchange-CrossTenant-AuthSource: SA0PR03MB5610.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 09:54:13.7970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dW2clUITJrXs+pnKeCq2irK7+eND8B//jsySA6ijHHtWSZacnH3B6Sw/rNlqJv6MmaSSQ8f9C6goBFHaENAfpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5818
X-OriginatorOrg: citrix.com

On Tue, Dec 14, 2021 at 09:21:22AM +0100, Jan Beulich wrote:
> This reverts commit c22bd567ce22f6ad9bd93318ad0d7fd1c2eadb0d.
> 
> While its description is correct from an abstract or real hardware pov,
> the range is special inside HVM guests. The range being UC in particular
> gets in the way of OVMF, which places itself at [FFE00000,FFFFFFFF].

I would assume this range to be unpopulated? Does hvmloader populate
it in order to place ovmf?

> While this is benign to epte_get_entry_emt() as long as the IOMMU isn't
> enabled for a guest, it becomes a very noticable problem otherwise: It
> takes about half a minute for OVMF to decompress itself into its
> designated address range.
> 
> And even beyond OVMF there's no reason to have e.g. the ACPI memory
> range marked UC.
> 
> Fixes: c22bd567ce22 ("hvmloader: PA range 0xfc000000-0xffffffff should be UC")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

This is just a hole from hvmloader PoV, so it's fine to not apply any
specific MTRR attributes.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247794.427307 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTJ-0005A3-3Y; Thu, 16 Dec 2021 09:54:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247794.427307; Thu, 16 Dec 2021 09:54:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTI-00059w-Vp; Thu, 16 Dec 2021 09:54:44 +0000
Received: by outflank-mailman (input) for mailman id 247794;
 Thu, 16 Dec 2021 09:54:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTI-00058M-JP
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:44 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 3070c026-5e56-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 10:54:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3070c026-5e56-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648482;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=ihpelIPg6Kn5U7wqbrqGt9VXxmF63gDVFbDxvOc0uT0=;
  b=d16DqkhE4Ug2SSVDn/vDRHYlvSYliVxymRpXB1geJjgoTL10qdRZwR3z
   T9goOdYkjw5OA9OrpLY4hCaq+umdXviXcdrQg+ZAYLDGjOSLf4P90mYFn
   AQgPTCUQ9kQJkzv2ZuR2BsuG4O4TXp6rSMCKZ3YzmNWub3zgewTBmU+oD
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 8mJNhzLqrse/pUMk4lmSKtVCbNxIRcPVqSRHnU04+4QVkbCaNgtMpdIZnPrQOuJRV2onTGUI+D
 yb6jLXj+oP4kQO7xN7LqguwBn3k/D3abfMAbjrQdnY9fP1ck5igdTcGV/YIv5zYr2St4ljfXbO
 75u4ULpsj3BPomrZfcLQp8HtMARCfh+q/AqTFA61fdxD3e/UGbwgYIj8CEng2w5q3fXogNnpHM
 gnDpgit0lLczdtZUI9BEyiSfk+pK+xiD9dbg7p6ScwZQAE1L3VfIddg9APUmAQUxMpk+pyk9OT
 HLen+MHlam8XSVRz/N1VrVjr
X-SBRS: 5.1
X-MesageID: 60174026
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:C1JfhaP3PMAQYWjvrR1okMFynXyQoLVcMsEvi/4bfWQNrUon0zJVn
 DQZDGqAa66KZzb9eNFzaN/goBkD6MKEm95lSQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYowyUn4Bq7
 upijre1azg3EuqTibw5ChYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgm9p2ZwWR6i2i
 8wxYCRwYErhXTh1Zmg4EL4PoeGq1l7mfGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m66j
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvla9ox5MQPxvPNYR7SOy1IaTvBfBIjELG2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DFDFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBvWAlexc0aJ5fEdMMX
 KM1kVkLjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMI6b9+KYFjgYpPkeLEo
 iO0VkNCkQKtjnzbMwSaLHtkbeq3D5p4qHs6Ow0qPEqphCd/Mdr+sv9HestlZ6Qj+cxi0eVwE
 6sPdfKfD6kdUT/A4TkcM8Xw9dQwaBSxiAuSFCO5ezxjLYV4TgnE94a8LAvi/SUDFAStss46r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJuepMCMxTOwDeex
 j26OxZAqLmfuZIx/fnImbuA89WjHdxhExcIBGLc97u3a3XXpzLx3Y9aXe+UVjnBT2eoqr66b
 OBYwvygYv0KmFFG79h1H7pxlP9s4tLuo/lRzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXaeeTJcfoMF8NPw50PO2M2MYdliTW8flocl7x4zV6/ebfXEhfV/VWZPex8Feh3FsZ/
 Noc
IronPort-HdrOrdr: A9a23:M3O/iK12XQQWbJZW+n+3UQqjBIokLtp133Aq2lEZdPRUGvb3qy
 nIpoVj6faUskd2ZJhOo7C90cW7LU80sKQFhLX5Xo3SOzUO2lHYT72KhLGKq1aLdhEWtNQtsZ
 uIG5IOcOEYZmIasS+V2maF+q4bsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60174026"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 1/6] x86/prot-key: Enumeration for Protection Key Supervisor
Date: Thu, 16 Dec 2021 09:54:16 +0000
Message-ID: <20211216095421.12871-2-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Protection Key Supervisor works in a very similar way to Protection Key User,
except that instead of a PKRU register used by the {RD,WR}PKRU instructions,
the supervisor protection settings live in MSR_PKRS and is accessed using
normal {RD,WR}MSR instructions.

PKS has the same problematic interactions with PV guests as PKU (more infact,
given the guest kernel's CPL), so we'll only support this for HVM guests for
now.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 tools/libs/light/libxl_cpuid.c              | 1 +
 tools/misc/xen-cpuid.c                      | 2 +-
 xen/arch/x86/include/asm/msr-index.h        | 2 ++
 xen/arch/x86/include/asm/x86-defns.h        | 1 +
 xen/include/public/arch-x86/cpufeatureset.h | 1 +
 5 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
index e1acf6648db4..efd01fd5c5b5 100644
--- a/tools/libs/light/libxl_cpuid.c
+++ b/tools/libs/light/libxl_cpuid.c
@@ -211,6 +211,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str)
         {"avx512-vpopcntdq",0x00000007,0,CPUID_REG_ECX, 14,  1},
         {"rdpid",        0x00000007,  0, CPUID_REG_ECX, 22,  1},
         {"cldemote",     0x00000007,  0, CPUID_REG_ECX, 25,  1},
+        {"pks",          0x00000007,  0, CPUID_REG_ECX, 31,  1},
 
         {"avx512-4vnniw",0x00000007,  0, CPUID_REG_EDX,  2,  1},
         {"avx512-4fmaps",0x00000007,  0, CPUID_REG_EDX,  3,  1},
diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index fb36cac07baa..f5b67acacc48 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -133,7 +133,7 @@ static const char *const str_7c0[32] =
     /* 24 */                   [25] = "cldemote",
     /* 26 */                   [27] = "movdiri",
     [28] = "movdir64b",        [29] = "enqcmd",
-    [30] = "sgx-lc",
+    [30] = "sgx-lc",           [31] = "pks",
 };
 
 static const char *const str_e7d[32] =
diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h
index ab68ef2681a9..3a1b4438e939 100644
--- a/xen/arch/x86/include/asm/msr-index.h
+++ b/xen/arch/x86/include/asm/msr-index.h
@@ -122,6 +122,8 @@
 #define MSR_PL3_SSP                         0x000006a7
 #define MSR_INTERRUPT_SSP_TABLE             0x000006a8
 
+#define MSR_PKRS                            0x000006e1
+
 #define MSR_X2APIC_FIRST                    0x00000800
 #define MSR_X2APIC_LAST                     0x00000bff
 
diff --git a/xen/arch/x86/include/asm/x86-defns.h b/xen/arch/x86/include/asm/x86-defns.h
index 28628807cb98..37bbb3594e88 100644
--- a/xen/arch/x86/include/asm/x86-defns.h
+++ b/xen/arch/x86/include/asm/x86-defns.h
@@ -74,6 +74,7 @@
 #define X86_CR4_SMAP       0x00200000 /* enable SMAP */
 #define X86_CR4_PKE        0x00400000 /* enable PKE */
 #define X86_CR4_CET        0x00800000 /* Control-flow Enforcement Technology */
+#define X86_CR4_PKS        0x01000000 /* Protection Key Supervisor */
 
 /*
  * XSTATE component flags in XCR0
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 647ee9e5e277..79a8f244d88a 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -244,6 +244,7 @@ XEN_CPUFEATURE(CLDEMOTE,      6*32+25) /*A  CLDEMOTE instruction */
 XEN_CPUFEATURE(MOVDIRI,       6*32+27) /*a  MOVDIRI instruction */
 XEN_CPUFEATURE(MOVDIR64B,     6*32+28) /*a  MOVDIR64B instruction */
 XEN_CPUFEATURE(ENQCMD,        6*32+29) /*   ENQCMD{,S} instructions */
+XEN_CPUFEATURE(PKS,           6*32+31) /*   Protection Key for Supervisor */
 
 /* AMD-defined CPU features, CPUID level 0x80000007.edx, word 7 */
 XEN_CPUFEATURE(HW_PSTATE,     7*32+ 7) /*   Hardware Pstates */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247795.427318 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTK-0005QG-Dz; Thu, 16 Dec 2021 09:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247795.427318; Thu, 16 Dec 2021 09:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTK-0005Q2-98; Thu, 16 Dec 2021 09:54:46 +0000
Received: by outflank-mailman (input) for mailman id 247795;
 Thu, 16 Dec 2021 09:54:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTI-0004jJ-Ow
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:44 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 30615369-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:54:42 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 30615369-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648482;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Ae8VnZhKfVIJXZyU4tX0YidXELQ0uGAsP7dO6F/9lBo=;
  b=ijAJlpjXbJ6A7qyX8POIlR/cZ/8+QcaBB/EP2dc3AgeMImOpR4IbdF4v
   T3h3+r9ces6pBttqOXOC2TJOOBISF2OiM9CJovFpFf0BV/fnkcJRer6As
   8rtfhSEPg1iMkQt395DS9H/TZ3JfiCJ6F5xFKUiRE6CMBKprGiMTYWcWc
   k=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: oPSgKXn5gvwA0PjAUBXdp0/z7/udOEeedCojYGqvBNersRBRCzF/GrQCIKlFmt6v5PSBeZpeJm
 oB2toC1NqD5jSrTr+EKvWiIXfUF/7wEKU/RKdmXIWsTV92VSVwH0sNWYnyDFMA4CuxBCZM3+xe
 ip0h7lMBp8RQnqWtVcxBh7Mrel9cqfGLh9cVnzFhetGcE0XmsVxosiQAm+t6+nIZY4hiPgdRtV
 6rEyomDVby5JgxMU8o1w8ps2eUITmS/lMNtrIcpzHA7YHtqLH6tKs2aQ2tBtaRf12AdQD1ec9i
 m9Zz6DhT8955rELdOOWwwyCD
X-SBRS: 5.1
X-MesageID: 60560087
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OOyyaqgUSL58IBPJ6KUMh5hvX161rRcKZh0ujC45NGQN5FlHY01je
 htvWjjXa/7YZTPyfYglOtiyp04E7JHUnNM2SFY4rHswEC4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /13qrCZDhtwYZHHv+4FWQt/SA0lGfBvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiGO
 pRBMWowBPjGSzBlfWUYU6sepb6tnkDRYzRp60mfnINitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRIDsXKdiewjqt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ
 CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4KfIWwUaRk/Xo6CGTHmIWaWVtM/h7nZpjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoStQWmY/
 tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi26AtQizARVodt/xory9U
 J4swZL2AAcmV87lqcB1aL9RdIxFHt7cWNEmvXZhHoM66xOm8GO5cIZb7VlWfRkyY5tVImC5P
 RWL4mu9AaO/2lPwN8ebhKrrVKwXIVXIT4y5Bpg4kPIQCnSOSON31H43PhPBt4wcuEMtjbs+K
 f+mnTWEVh4n5VBc5GPuHY81iOZzrghnnD+7bc2rnnyPjOvFDFbIGOhtDbd7Rr1ghE9yiF6Oq
 Ig32grj40g3bdASlQGLq9NOdg5TciBgbX00wuQOHtO+zsNdMDlJI5fsLXkJIeSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:N1IwCauPSf2HguweFz2Ts00i7skDRtV00zEX/kB9WHVpm5Sj5q
 STdYcgpHjJYVcqKQodcL+7Scu9qB/nmqKdgrNhR4tKPjOW3VdARbsKheCJrlHd8kbFl9K1oJ
 0QEJSWf+eRMbEVt6jHCUKDYrAdKZG8gdmVbcy39QYUcT1X
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60560087"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 6/6] x86/hvm: Support PKS
Date: Thu, 16 Dec 2021 09:54:21 +0000
Message-ID: <20211216095421.12871-7-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

With all infrastructure in place, advertise the PKS CPUID bit to guests, and
let them set CR4.PKS.

Experiment with a tweak to the layout of hvm_cr4_guest_valid_bits() so future
additions will be just a single added line.

The current context switching behaviour is tied to how VT-x works, so leave a
safety check in the short term.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/cpuid.c                        | 9 +++++++++
 xen/arch/x86/hvm/hvm.c                      | 4 +++-
 xen/include/public/arch-x86/cpufeatureset.h | 2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 151944f65702..03653d3766f4 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -512,6 +512,15 @@ static void __init calculate_hvm_max_policy(void)
             __clear_bit(X86_FEATURE_XSAVES, hvm_featureset);
     }
 
+    /*
+     * Xen doesn't use PKS, so the guest support for it has opted to not use
+     * the VMCS load/save controls for efficiency reasons.  This depends on
+     * the exact vmentry/exit behaviour, so don't expose PKS in other
+     * situations until someone has cross-checked the behaviour for safety.
+     */
+    if ( !cpu_has_vmx )
+        __clear_bit(X86_FEATURE_PKS, hvm_featureset);
+
     guest_common_feature_adjustments(hvm_featureset);
 
     sanitise_featureset(hvm_featureset);
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index e75245f36dce..2552e7f45499 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1010,7 +1010,9 @@ unsigned long hvm_cr4_guest_valid_bits(const struct domain *d)
             (p->feat.smep     ? X86_CR4_SMEP              : 0) |
             (p->feat.smap     ? X86_CR4_SMAP              : 0) |
             (p->feat.pku      ? X86_CR4_PKE               : 0) |
-            (cet              ? X86_CR4_CET               : 0));
+            (cet              ? X86_CR4_CET               : 0) |
+            (p->feat.pks      ? X86_CR4_PKS               : 0) |
+            0);
 }
 
 static int hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h
index 79a8f244d88a..92ec9eed3fd1 100644
--- a/xen/include/public/arch-x86/cpufeatureset.h
+++ b/xen/include/public/arch-x86/cpufeatureset.h
@@ -244,7 +244,7 @@ XEN_CPUFEATURE(CLDEMOTE,      6*32+25) /*A  CLDEMOTE instruction */
 XEN_CPUFEATURE(MOVDIRI,       6*32+27) /*a  MOVDIRI instruction */
 XEN_CPUFEATURE(MOVDIR64B,     6*32+28) /*a  MOVDIR64B instruction */
 XEN_CPUFEATURE(ENQCMD,        6*32+29) /*   ENQCMD{,S} instructions */
-XEN_CPUFEATURE(PKS,           6*32+31) /*   Protection Key for Supervisor */
+XEN_CPUFEATURE(PKS,           6*32+31) /*H  Protection Key for Supervisor */
 
 /* AMD-defined CPU features, CPUID level 0x80000007.edx, word 7 */
 XEN_CPUFEATURE(HW_PSTATE,     7*32+ 7) /*   Hardware Pstates */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247796.427323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTK-0005Tc-SI; Thu, 16 Dec 2021 09:54:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247796.427323; Thu, 16 Dec 2021 09:54:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTK-0005TF-Jv; Thu, 16 Dec 2021 09:54:46 +0000
Received: by outflank-mailman (input) for mailman id 247796;
 Thu, 16 Dec 2021 09:54:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTJ-00058M-Bu
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:45 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 31e158ae-5e56-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 10:54:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31e158ae-5e56-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648484;
  h=from:to:cc:subject:date:message-id:mime-version:
   content-transfer-encoding;
  bh=Ypf6yGKzcUnb+pq7N7OneCROKxixqXUrpk4X+7avZrc=;
  b=Mm9OxxBuVTM8KUGkdoBHOioSWVt4M/EZsgklqoBCbG0yh8Ye4jeomWeI
   wDJDIaUVAKYfbx4oXuwfS8nBchDFlCwshIUylK8JK/GATEVYlaHQlFobq
   uXEDpa+E7xUkqgNVxpPa+JfF+oprTiQ8qQPDvODz+22V84urM3w6uzRdm
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 7OjQsFR0nhXs1vmGSztLReQ6LHCYzTPymL54QNEmr/p42OlMkXTiqobBV4ovAdVtbPG2qncoHA
 6CuFLQwdSQ3G1JHlff40ukV7yVCbwRrRQJKDQ95qqeHXKG8/psuyjAjh+v11DOdHWIZg03zLK+
 1qukGLQmxwPJBW0ZbLwPKwWIFroBP1Sh1NCOnxrWSQm+CMMPQ9MJo8tPQxQxVyQyP6O3t8CiTd
 jpgBIWeiVpBDodvkoqaYKFPVsLXXQKDofDUbocXHvu5K+ye4SG0ueKHiDQQOQzUqTDVJ0ts9yh
 Ori/+zvOXsh+tlSizzFh7yY+
X-SBRS: 5.1
X-MesageID: 60174027
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:d/2796gcH9GdAljl8WXxQWdPX161uxcKZh0ujC45NGQN5FlHY01je
 htvUG7SMv3fYWP8KIslPty29kxVvJaEy4I2TlE+qnwxRCIb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /0OiKXzbl0PMJbmxuU6SiBHNjwiLYR/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiGP
 pVFMWAwBPjGSwQXAHNKA6oTpr6Tn0jHIiNAo2KM+7VitgA/yyQuieOwYbI5YOeiWsF9jkue4
 GXc8AzRARwENdrZ1TuM9FqtgPPCmWXwX4d6PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb
 UsO9UIGj4I/6UiqRdnVRACjrTiPuRt0ZjZLO7RkskfXkPOSulvHQDhfJtJcVDA4nIwLfH8Nj
 HmHpPm3BBt2iaKwVC6N347B+FteJhMpBWMFYCYFSy4M7N/ivJw/g3rzczpzLEKmpoarQG+tm
 lhmuAB73uxO1pBTi81X6Hie22r0zqUlWDLZ8ek+soiNygpiLLCoaIWzgbQwxaYRdd3JJrVtU
 ZVtpiR/0AzsJc3d/MBuaL9UdF1M2xpjGGeG6bKIN8N+nwlBA1b5IehtDMhWfS+FyPosdz7ze
 1P0sghM/pJVN3bCRfYpONPsWp91nfW6TY+NuhXogjxmOMIZmOivpn4GWKJt9zq1zBhEfV8XZ
 /93jvpA/V5FUP86nVJats8W0KMxxzBW+I8gbcuT8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92
 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1ORDt8VqSPmOx5IOSIXc19z4/1w
 510YWcAoHKXuJENAV/ihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:DPEI2awLHmOJqw60l0IlKrPwIL1zdoMgy1knxilNoRw8SKKlfq
 eV7ZMmPH7P+VIssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyHJ8SUzI9gPM
 lbHJSWcOeAb2RHsQ==
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60174027"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: [PATCH 0/6] x86: Support PKS
Date: Thu, 16 Dec 2021 09:54:15 +0000
Message-ID: <20211216095421.12871-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

I found a spare half hour, and this turned out to go very smoothly.

It's tentatively RFC right now, because I'm still adding PKS support to the
XTF comprehensive pagewalk test, but the series is definitely fit for review
at this point.

Andrew Cooper (6):
  x86/prot-key: Enumeration for Protection Key Supervisor
  x86/prot-key: Split PKRU infrastructure out of asm/processor.h
  x86/hvm: Context switch MSR_PKRS
  x86/hvm: Enable guest access to MSR_PKRS
  x86/pagewalk: Support PKS
  x86/hvm: Support PKS

 tools/libs/light/libxl_cpuid.c              |  1 +
 tools/misc/xen-cpuid.c                      |  2 +-
 xen/arch/x86/cpuid.c                        |  9 +++
 xen/arch/x86/hvm/hvm.c                      |  8 ++-
 xen/arch/x86/hvm/vmx/vmx.c                  | 14 +++++
 xen/arch/x86/include/asm/guest_pt.h         |  5 ++
 xen/arch/x86/include/asm/hvm/hvm.h          |  3 +
 xen/arch/x86/include/asm/msr-index.h        |  2 +
 xen/arch/x86/include/asm/msr.h              |  8 +++
 xen/arch/x86/include/asm/processor.h        | 38 ------------
 xen/arch/x86/include/asm/prot-key.h         | 93 +++++++++++++++++++++++++++++
 xen/arch/x86/include/asm/x86-defns.h        |  1 +
 xen/arch/x86/mm/guest_walk.c                | 16 +++--
 xen/arch/x86/msr.c                          | 17 ++++++
 xen/arch/x86/x86_emulate.c                  |  2 +
 xen/include/public/arch-x86/cpufeatureset.h |  1 +
 16 files changed, 174 insertions(+), 46 deletions(-)
 create mode 100644 xen/arch/x86/include/asm/prot-key.h

-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247797.427340 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTN-000631-Ah; Thu, 16 Dec 2021 09:54:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247797.427340; Thu, 16 Dec 2021 09:54:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTN-00062k-5c; Thu, 16 Dec 2021 09:54:49 +0000
Received: by outflank-mailman (input) for mailman id 247797;
 Thu, 16 Dec 2021 09:54:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTJ-0004jJ-PA
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:45 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 31040c06-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:54:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31040c06-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648483;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=v9bw6OTYe4GMK9r+ci/619JzYrUtHb0Orn0SUhf+1FU=;
  b=MridvwzDq9A4Syj+4pxI06L4DOjmlPSaDXdeUJWlwha2gVYYUcuOrTu2
   8ZNraDKSKXAmUUu3hxWEGNgY4IZJAYWihmuYuG6dpfzHO9GrDystvnYwy
   wbi1OpRbYlXnhZMyf7m0Vnn65HTIZUbzdMAOd+z4T9nFACtrN5Sua6Y8u
   Q=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: C4+7FJeYr4zePLeQRlSaazB/lvsCFpm+foHbA2xrM+AIlHCh1mUUbEx0AN9MxdsD7bVMQEgSnt
 x6831LE3SJtYJmoxXmmoiYG2koTMGKtku+o88WXt/FGS9kiGZsdLeE1LKFnk9KgrVJaO0uRxy6
 0IMLQpLDcKi2pj03rhr+0Fd44S/SFfLBIObo+cVdVR1635qX7576hW4kpWSOyO+nD+yyrMcCdz
 SZWk8z/qzex2eAu0EMbBFU5/uH+C8gof15WtAS+DujlEKHJSr1m7aLMXrjMX8o+Bh2zEpIvUVD
 EPaf+baT0JiMaBlxGnsWl9P0
X-SBRS: 5.1
X-MesageID: 62240014
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:MpXo06kaIxkJOppWx7QvUBLo5gxaIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIaDWuPPPfeajPxfo9yOt7n9h9Sv5OGzoBnTQNl+Co2ESMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2Nc22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NJH9puIY1lyBJP3od5adhpELBpGB5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6yEO
 5JBMGYHgBLoR0JhZ30GAq8Hv8DxtHXUfDtolgiQqv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z6Dw8bMpqDyDOD2nOqmuLL2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIMh6Uv8E2gTvHmQga15nWDu3Yht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIOs8V1QgQAi
 ASzoejQP3tKs6Gqckqnz+LBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Qmf22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUcHleM+lGrxl8FSVCxCtame0bblHRcZJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPEsMt/gUJt6kPK4TrwJs8w4iPIUOPCdkyfdo0lTibO4hTixwCDAb4lhU
 XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r
 ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI6Qjx8UKGInut6E2Gn9owM/tr1E
 riGchcw4DLCabfvcm1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:lTYAJq6hEAuCDw6D0gPXwPLXdLJyesId70hD6qhwISY1TiX+rb
 HXoB17726MtN9/YgBCpTntAsa9qDbnhPpICOoqTNGftWvdyQmVxehZhOOIqVCNJ8S9zJ876U
 4JSdkENDSaNzhHZKjBjjVQa+xQpeW6zA==
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="62240014"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: [PATCH 3/6] x86/hvm: Context switch MSR_PKRS
Date: Thu, 16 Dec 2021 09:54:18 +0000
Message-ID: <20211216095421.12871-4-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Under PKS, MSR_PKRS is available and based on the CPUID policy alone, and
usable independently of CR4.PKS.  See the large comment in prot-key.h for
details of the context switching arrangement.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Kevin Tian <kevin.tian@intel.com>

At a guess, we're likely to see PKS on AMD eventually, hence not putting the
DEFINE_PER_CPU() in vmx.c, but I'm at a total loss to find anywhere better to
put it than hvm.c.  Suggestions welcome.
---
 xen/arch/x86/hvm/hvm.c              |  3 +++
 xen/arch/x86/hvm/vmx/vmx.c          |  9 +++++++
 xen/arch/x86/include/asm/msr.h      |  8 +++++++
 xen/arch/x86/include/asm/prot-key.h | 48 +++++++++++++++++++++++++++++++++++++
 4 files changed, 68 insertions(+)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 350dc396e37c..63eaa3c5a66b 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -69,6 +69,7 @@
 #include <asm/hvm/vm_event.h>
 #include <asm/altp2m.h>
 #include <asm/mtrr.h>
+#include <asm/prot-key.h>
 #include <asm/apic.h>
 #include <asm/vm_event.h>
 #include <public/sched.h>
@@ -117,6 +118,8 @@ static const char __initconst warning_hvm_fep[] =
 static bool_t __initdata opt_altp2m_enabled = 0;
 boolean_param("altp2m", opt_altp2m_enabled);
 
+DEFINE_PER_CPU(uint32_t, pkrs);
+
 static int cpu_callback(
     struct notifier_block *nfb, unsigned long action, void *hcpu)
 {
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index a7a0d662342a..2e6af1e1c033 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -58,6 +58,7 @@
 #include <asm/event.h>
 #include <asm/mce.h>
 #include <asm/monitor.h>
+#include <asm/prot-key.h>
 #include <public/arch-x86/cpuid.h>
 
 static bool_t __initdata opt_force_ept;
@@ -525,6 +526,7 @@ static void vmx_restore_host_msrs(void)
 
 static void vmx_save_guest_msrs(struct vcpu *v)
 {
+    const struct cpuid_policy *cp = v->domain->arch.cpuid;
     struct vcpu_msrs *msrs = v->arch.msrs;
 
     /*
@@ -538,10 +540,14 @@ static void vmx_save_guest_msrs(struct vcpu *v)
         rdmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask);
         rdmsrl(MSR_RTIT_STATUS, msrs->rtit.status);
     }
+
+    if ( cp->feat.pks )
+        msrs->pkrs = rdpkrs_and_cache();
 }
 
 static void vmx_restore_guest_msrs(struct vcpu *v)
 {
+    const struct cpuid_policy *cp = v->domain->arch.cpuid;
     const struct vcpu_msrs *msrs = v->arch.msrs;
 
     write_gs_shadow(v->arch.hvm.vmx.shadow_gs);
@@ -558,6 +564,9 @@ static void vmx_restore_guest_msrs(struct vcpu *v)
         wrmsrl(MSR_RTIT_OUTPUT_MASK, msrs->rtit.output_mask);
         wrmsrl(MSR_RTIT_STATUS, msrs->rtit.status);
     }
+
+    if ( cp->feat.pks )
+        wrpkrs(msrs->pkrs);
 }
 
 void vmx_update_cpu_exec_control(struct vcpu *v)
diff --git a/xen/arch/x86/include/asm/msr.h b/xen/arch/x86/include/asm/msr.h
index 1d3eca9063a2..2ee0b68100c9 100644
--- a/xen/arch/x86/include/asm/msr.h
+++ b/xen/arch/x86/include/asm/msr.h
@@ -338,6 +338,14 @@ struct vcpu_msrs
         };
     } rtit;
 
+    /*
+     * 0x000006e1 - MSR_PKRS - Protection Key Supervisor.
+     *
+     * Exposed R/W to guests.  Xen doesn't use PKS yet, so only context
+     * switched per vcpu.  When in current context, live value is in hardware.
+     */
+    uint32_t pkrs;
+
     /* 0x00000da0 - MSR_IA32_XSS */
     struct {
         uint64_t raw;
diff --git a/xen/arch/x86/include/asm/prot-key.h b/xen/arch/x86/include/asm/prot-key.h
index 084b248d81a5..4387c27b7ec5 100644
--- a/xen/arch/x86/include/asm/prot-key.h
+++ b/xen/arch/x86/include/asm/prot-key.h
@@ -19,8 +19,11 @@
 #ifndef ASM_PROT_KEY_H
 #define ASM_PROT_KEY_H
 
+#include <xen/percpu.h>
 #include <xen/types.h>
 
+#include <asm/msr.h>
+
 #define PKEY_AD 1 /* Access Disable */
 #define PKEY_WD 2 /* Write Disable */
 
@@ -42,4 +45,49 @@ static inline void wrpkru(uint32_t pkru)
                    :: "a" (pkru), "d" (0), "c" (0) );
 }
 
+/*
+ * Xen does not use PKS.
+ *
+ * Guest kernel use is expected to be one default key, except for tiny windows
+ * with a double write to switch to a non-default key in a permitted critical
+ * section.
+ *
+ * As such, we want MSR_PKRS un-intercepted.  Furthermore, as we only need it
+ * in Xen for emulation or migration purposes (i.e. possibly never in a
+ * domain's lifetime), we don't want to re-sync the hardware value on every
+ * vmexit.
+ *
+ * Therefore, we read and cache the guest value in ctxt_switch_from(), in the
+ * expectation that we can short-circuit the write in ctxt_switch_to().
+ * During regular operations in current context, the guest value is in
+ * hardware and the per-cpu cache is stale.
+ */
+DECLARE_PER_CPU(uint32_t, pkrs);
+
+static inline uint32_t rdpkrs(void)
+{
+    uint32_t pkrs, tmp;
+
+    rdmsr(MSR_PKRS, pkrs, tmp);
+
+    return pkrs;
+}
+
+static inline uint32_t rdpkrs_and_cache(void)
+{
+    return this_cpu(pkrs) = rdpkrs();
+}
+
+static inline void wrpkrs(uint32_t pkrs)
+{
+    uint32_t *this_pkrs = &this_cpu(pkrs);
+
+    if ( *this_pkrs != pkrs )
+    {
+        *this_pkrs = pkrs;
+
+        wrmsr(MSR_PKRS, pkrs, 0);
+    }
+}
+
 #endif /* ASM_PROT_KEY_H */
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247798.427347 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTN-00067N-Sn; Thu, 16 Dec 2021 09:54:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247798.427347; Thu, 16 Dec 2021 09:54:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTN-00065i-ID; Thu, 16 Dec 2021 09:54:49 +0000
Received: by outflank-mailman (input) for mailman id 247798;
 Thu, 16 Dec 2021 09:54:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTK-00058M-C9
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:46 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 328129be-5e56-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 10:54:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 328129be-5e56-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648485;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=Y7yij6K+XUWatRCxO0dFSLXD8ZxBgFCf9pYhU1zZkmY=;
  b=X9i4S3rXzH4D8sxr9SIL0wKe05bz7JlgxJZvVLSQGgAvoP4w8tXLZEBG
   1a8gGvgNDxgs9JgBnSHrotrkcJSGZB4BmXE4jr+LLohMNJOoWADcTlhoQ
   ibQl7vYUEsedsXu+K5iriWD4/+YMejVlqnr9rxYnMINkLYaBQWoIoVMrR
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 4QpB0e8eTB9eFeUQMI67lhP8GTDW39DEZtsCOZrcQAvzVpALrBVM42xR1ia0MjPQPLDwNvGVSI
 FcTvbiAhIywEOmkLv1l9gzHQN6ZtWrUt0f/0SRKHI8DT5Bk1htJ8Ru7PY12qxpNd8AHUegrZlq
 s9BNXvQbnJgdAtf0O5e2DzoiwE8Xy95mVbkdXkCeYaOD6unz1i8G65pOCisHLUdy4b9FrZgVTC
 8SW4QxDGjZ14KYEc4sjmap1Ly3k6K2FeV2YNRrInRqGJMjV656rJTBYiJmsuLpqQL1aBmAMs/5
 vh2WxkWGEcEszJiTfoeuPuVA
X-SBRS: 5.1
X-MesageID: 60174028
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:kc5xpqmAxX+Uz5JzJ+jYPbro5gxaIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xJKDGuGPv7eZDbzKot0Oti1oxkBuZCDnNIwSgZsqixnFCMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2Nc22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 JZwjN+XEyEnBYeSmcMEagZ9Dn1uFJQTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ66HO
 JZBM2oHgBLoZERPA20lS4AEuKSkmimiUAQCqHSVjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0z6Dw8bMpqDyDOD2nOqmuLL2yj8Xeo6BLC+s/JnnlCX7mgSEwENE0u2p+GjjUyzUM4ZL
 FYbkgIMh6Uv8E2gTvHmQga15nWDu3Yht8F4SrNgrlvXk+yNvljfVjNsoiN9hMIO9/IPBhtw8
 FGytY3oIiVWr5iIFWK0z+LBxd+tAhQ9IWgHbC4CaAIK5dj/vY0+5i7yosZf/L2d1YOsR2ypq
 9yehG1n3uhI05ZXv0mu1Qmf22rEm3TfcuIiCuw7tEqB5xgxWoOqbpfABbPzvacZd9bxorVsU
 RE5dymiAAImUcHleM+lGrxl8FSVCxCtame0bblHRcZJythV0yT/Fb28GRknTKuTDu4KeCXyf
 GjYsh5L6ZlYMROCNPEsMt/gUJt6kPK4TrwJs8w4iPIUOPCdkyfdo0lTibO4hTixwCDAb4lhU
 XtkTSpcJSlDUvk2pNZHb+wczaUq1kgDKZD7HvjGI+Cc+ePGPha9EO5dWHPXN7xRxP7U8W39r
 ocEX+PXmko3bQELSnSOmWLlBQtRdiZT6FGfg5E/S9Nv1SI6Qjx8UKGInut6E2Gn9owM/tr1E
 riGchcw4DLCabfvc21ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:wo+oN6tZO3Ll6TngaX67xfiW7skDTtV00zEX/kB9WHVpmszxra
 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79
 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ==
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60174028"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Kevin Tian
	<kevin.tian@intel.com>
Subject: [PATCH 4/6] x86/hvm: Enable guest access to MSR_PKRS
Date: Thu, 16 Dec 2021 09:54:19 +0000
Message-ID: <20211216095421.12871-5-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Have guest_{rd,wr}msr() access either the live register, or stashed state,
depending on context.  Include MSR_PKRS for migration, and let the guest have
full access.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Kevin Tian <kevin.tian@intel.com>
---
 xen/arch/x86/hvm/hvm.c     |  1 +
 xen/arch/x86/hvm/vmx/vmx.c |  5 +++++
 xen/arch/x86/msr.c         | 17 +++++++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 63eaa3c5a66b..e75245f36dce 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1372,6 +1372,7 @@ static int hvm_load_cpu_xsave_states(struct domain *d, hvm_domain_context_t *h)
 static const uint32_t msrs_to_send[] = {
     MSR_SPEC_CTRL,
     MSR_INTEL_MISC_FEATURES_ENABLES,
+    MSR_PKRS,
     MSR_IA32_BNDCFGS,
     MSR_IA32_XSS,
     MSR_AMD64_DR0_ADDRESS_MASK,
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 2e6af1e1c033..2288ea54f0b5 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -632,6 +632,11 @@ static void vmx_cpuid_policy_changed(struct vcpu *v)
         vmx_clear_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW);
     else
         vmx_set_msr_intercept(v, MSR_FLUSH_CMD, VMX_MSR_RW);
+
+    if ( cp->feat.pks )
+        vmx_clear_msr_intercept(v, MSR_PKRS, VMX_MSR_RW);
+    else
+        vmx_set_msr_intercept(v, MSR_PKRS, VMX_MSR_RW);
 }
 
 int vmx_guest_x86_mode(struct vcpu *v)
diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c
index b834456c7b02..d2569a81b7ba 100644
--- a/xen/arch/x86/msr.c
+++ b/xen/arch/x86/msr.c
@@ -28,6 +28,7 @@
 #include <asm/hvm/nestedhvm.h>
 #include <asm/hvm/viridian.h>
 #include <asm/msr.h>
+#include <asm/prot-key.h>
 #include <asm/setup.h>
 
 #include <public/hvm/params.h>
@@ -315,6 +316,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
         *val = 0;
         break;
 
+    case MSR_PKRS:
+        if ( !cp->feat.pks )
+            goto gp_fault;
+
+        *val = (v == curr) ? rdpkrs() : msrs->pkrs;
+        break;
+
     case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST:
         if ( !is_hvm_domain(d) || v != curr )
             goto gp_fault;
@@ -581,6 +589,15 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t val)
             break;
         goto gp_fault;
 
+    case MSR_PKRS:
+        if ( !cp->feat.pks || val != (uint32_t)val )
+            goto gp_fault;
+
+        msrs->pkrs = val;
+        if ( v == curr )
+            wrmsr(MSR_PKRS, val, 0);
+        break;
+
     case MSR_X2APIC_FIRST ... MSR_X2APIC_LAST:
         if ( !is_hvm_domain(d) || v != curr )
             goto gp_fault;
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247799.427350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTO-0006GT-9b; Thu, 16 Dec 2021 09:54:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247799.427350; Thu, 16 Dec 2021 09:54:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTO-0006Cb-1i; Thu, 16 Dec 2021 09:54:50 +0000
Received: by outflank-mailman (input) for mailman id 247799;
 Thu, 16 Dec 2021 09:54:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTK-0004jJ-PG
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:46 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 324ce813-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:54:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 324ce813-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648484;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=xtRI3BLk7ZWqiz6X+MMatMX66rJ6BEiGCj6erUpx/jo=;
  b=Z9XJ/wjxf5YLR9MvDJ/GwAsKeFocdRWCCeueVBuigLNHsNL9zZQhT67j
   KctgfL/9WXsFHF8L9GE7+KUVw0wQOeqZb1QnYgOaO+A9JK2icJ5QMPOqe
   tPWl6qOKUcr8yU9UFdWFjsQDuiUJbQ2UGIm+vArwyqHewC7WJ7g/K29Ky
   8=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 488ouJ4q8rmljPTJrBrg+TTe2yYP5NDrzKwZf1W36Q3wNYaakrD6Oew+sxZQTeP2WQsLjR5Yz9
 jEnQOaCzVj/ZS2Lp79cqscwyNwnQmdxIhhFvit4+PsO0DTPiiVuRr6vAAqyK3tx0K73AzDOeVx
 QXg6IY5Jk5PHIa2zDNaXqPpOxj4LtetyBZfATxXtJ5mmsagevylpsYam1sRltcYlDtGAGqAQMW
 D0GH9PsHmIQ1ceRbx2ei0wjhrAEUh2iVT9oYapNsyRNs9TxaALQNaVvZdUy7CmxV2Pv/xrcsjg
 s5WGHp4lbl3nT4M59HyV9m58
X-SBRS: 5.1
X-MesageID: 60560088
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:JZgV7anz8PgCRWCkYKjQBv/o5gxMIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIdXTvQb/jfM2GnLtggbtvg8R5SuJ+AyoIxQVBr+y5jFSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2Nc22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 NZzi5rzd1l2BaGPo8k8YgdILQUnZ5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ66DO
 ZJBOWoHgBLoZxx1FBRPV7QCo9iFpUXcfRNR9EiMnP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo
 XjJl0zbKBwHMN2UyRKe72mhwOTImEvTSI8UUbG16PNuqFmS3XAITg0bU0Ohpvu0gVL4XMhQQ
 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJTLdM8qz/TlZHYoD20J1kaXgBlMYYf4ZpeqSMR6
 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud14WtQVnNL
 ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhaT0uTA3Dt4ade51q2VtW
 lBewaByC8hUUvmweNSlGrllIV1Qz6/t3MfgqVBuBYI90D+m5mSue4tdiBknehw4b5dfJm+0O
 heI0e+02HO1FCHwBUOQS9juY/nGMIC6TYi1PhwqRoQmjmdNmP+vo3g1OB/4M5HFm0kwi6AvU
 ap3gu73ZUv2/Z9PlWLsL89EiOdD7nlnmQv7GMCqpzz6gOH2TCPEFt843K6mM7lRAFWs+16Or
 b6y9qKiln1ibQEJSnWNrNNIcwlVdSNT6FKfg5U/S9Nv6zFOQAkJY8I9C5t7E2C8t6gKxOrO4
 F+nXUpUlAj2iXHdcF3YYXF/crL/G514qCtjbyArOF+p3VklYJqus/hDJ8dmI+F/+bwx1+NwQ
 tkEZ96EXqZFRAPY9mlPdpL6toFjKkim3FrcIyq/bTEjVJd8XAiVqMT8dw7i+XBWXCq6vMczu
 ZO60QbfTcZRTghuFp+OOvmu00mwrT4Wn+crBxnEJdxaeUPN9ol2KnOu0q9rcp9UcRian2mUz
 QebBxsctNLhmY5t/Ymbn72AoqeoD/B6QhhQEV7E4OvkLiLd5Gein9NNCb7aYTDHWWro06y+f
 uEJnerkOfgKkVsW4YpxF7FnkfA369f1/uIIyw1lGDPAbkixC6MmKX6DhJEduqpIz75fmA23R
 kPQpYUKZeTXYJvoQAwLOQ4oTuWfzvVFyDDd4MM8LFj++CIqrqGMVl9fPkXUhSFQRFev3FjJH
 Qv1VBYq1jGC
IronPort-HdrOrdr: A9a23:4C42k637vEXiIF7oVo7hDQqjBIIkLtp133Aq2lEZdPUMSL39qy
 ncpoV96faUskdrZJhOo6HjBEDtexzhHP1OkPMs1NWZLWzbUQKTRekIh+aP/9SKIUzDH5tmpM
 Rdmt9FaOEYY2IVsS+w2njfLz9p+qj/zEiC7d2ut0tQcQ==
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60560088"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 5/6] x86/pagewalk: Support PKS
Date: Thu, 16 Dec 2021 09:54:20 +0000
Message-ID: <20211216095421.12871-6-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

PKS is incredibly similar to the existing PKU behaviour, operating on
pagewalks for any supervisor mapping.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/include/asm/guest_pt.h | 5 +++++
 xen/arch/x86/include/asm/hvm/hvm.h  | 3 +++
 xen/arch/x86/mm/guest_walk.c        | 9 +++++----
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/include/asm/guest_pt.h b/xen/arch/x86/include/asm/guest_pt.h
index 6647ccfb8520..6802db2a415a 100644
--- a/xen/arch/x86/include/asm/guest_pt.h
+++ b/xen/arch/x86/include/asm/guest_pt.h
@@ -282,6 +282,11 @@ static always_inline bool guest_pku_enabled(const struct vcpu *v)
     return !is_pv_vcpu(v) && hvm_pku_enabled(v);
 }
 
+static always_inline bool guest_pks_enabled(const struct vcpu *v)
+{
+    return !is_pv_vcpu(v) && hvm_pks_enabled(v);
+}
+
 /* Helpers for identifying whether guest entries have reserved bits set. */
 
 /* Bits reserved because of maxphysaddr, and (lack of) EFER.NX */
diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h
index bd2cbb0e7baf..ffef7ed075a7 100644
--- a/xen/arch/x86/include/asm/hvm/hvm.h
+++ b/xen/arch/x86/include/asm/hvm/hvm.h
@@ -394,6 +394,8 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value);
     ((v)->arch.hvm.guest_efer & EFER_NXE)
 #define hvm_pku_enabled(v) \
     (hvm_paging_enabled(v) && ((v)->arch.hvm.guest_cr[4] & X86_CR4_PKE))
+#define hvm_pks_enabled(v) \
+    (hvm_paging_enabled(v) && ((v)->arch.hvm.guest_cr[4] & X86_CR4_PKS))
 
 /* Can we use superpages in the HAP p2m table? */
 #define hap_has_1gb (!!(hvm_funcs.hap_capabilities & HVM_HAP_SUPERPAGE_1GB))
@@ -868,6 +870,7 @@ static inline int hvm_vmtrace_get_option(
 #define hvm_smap_enabled(v) ((void)(v), false)
 #define hvm_nx_enabled(v) ((void)(v), false)
 #define hvm_pku_enabled(v) ((void)(v), false)
+#define hvm_pks_enabled(v) ((void)(v), false)
 
 #define arch_vcpu_block(v) ((void)(v))
 
diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c
index dc8fdde0212e..8670d4990a11 100644
--- a/xen/arch/x86/mm/guest_walk.c
+++ b/xen/arch/x86/mm/guest_walk.c
@@ -406,16 +406,17 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m,
 #if GUEST_PAGING_LEVELS >= 4 /* 64-bit only... */
     /*
      * If all access checks are thus far ok, check Protection Key for 64bit
-     * data accesses to user mappings.
+     * data accesses.
      *
      * N.B. In the case that the walk ended with a superpage, the fabricated
      * gw->l1e contains the appropriate leaf pkey.
      */
-    if ( (ar & _PAGE_USER) && !(walk & PFEC_insn_fetch) &&
-         guest_pku_enabled(v) )
+    if ( !(walk & PFEC_insn_fetch) &&
+         ((ar & _PAGE_USER) ? guest_pku_enabled(v)
+                            : guest_pks_enabled(v)) )
     {
         unsigned int pkey = guest_l1e_get_pkey(gw->l1e);
-        unsigned int pkr = rdpkru();
+        unsigned int pkr = (ar & _PAGE_USER) ? rdpkru() : rdpkrs();
         unsigned int pk_ar = pkr >> (pkey * PKEY_WIDTH);
 
         if ( (pk_ar & PKEY_AD) ||
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:54:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:54:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247800.427359 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTP-0006Q9-5D; Thu, 16 Dec 2021 09:54:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247800.427359; Thu, 16 Dec 2021 09:54:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnTO-0006ML-K6; Thu, 16 Dec 2021 09:54:50 +0000
Received: by outflank-mailman (input) for mailman id 247800;
 Thu, 16 Dec 2021 09:54:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VCpR=RB=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1mxnTL-0004jJ-Pb
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:54:47 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 32a17c47-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:54:45 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 32a17c47-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639648485;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=bFNQanPdXABbQVU+6GCRr2U4dROyJOhmm2L/RcJtAp0=;
  b=Muc/dkvAcrTooGORKPmYEeFtjm+pbrIVUZQ/0vFF4pAVylnAsMIephU0
   lybFZH2XBjsD5omhX+vyggYWg+/+UJWUPc0zyxCQ9Pu/gU8MbLKabLaj3
   QNtIHxiC3KZsQSAXmxLeMptxAnqPlYjhhceO2rQVMYkLmbTKy0wHDGazC
   E=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Vc2006kljhkzR6RljOr7vQ0+5e5qjt133yt9idvu0E8fqdSEFWKeklfakbl6z+nhDOfxFgl4Xh
 ntyDbeuCnpOwttQULoLbtqFWs9QmF7ZBeLpzmfmSIyrt//BYz3RxJwZdCgym0S2BWipE8MdTrh
 f6rs6Ael0K1Yu5o/NwXX+bnxx0Pd1P40MQxQgLCzmH5C5TOZOlDNP1XAK3XRlH6/YCLI9UtvkD
 9leoRgsWeOs70IdENbqqdNWjmh0pN1UaUw4fzjAeZ7uOmIvFpUCNwEq7TE6THhP39fhf0zBhSo
 HKv3J1Q0ETTC/M4fqKxvgnlD
X-SBRS: 5.1
X-MesageID: 62240013
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:HANQWaOlgn0i+rrvrR1okMFynXyQoLVcMsEvi/4bfWQNrUp012QAy
 TEfUD+DOqqCZGemf49xPozl9UoPsZGEnNBrGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozKD3NdJ4
 osWj6KLcD1uG67Qp98laSANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YsBqit4uM4/AO4QHt2s75TrYEewnUdbIRKCiCdpwgm1q2pgWRK22i
 8wxTBZkXhqDSB52Cw0pFZgzwsT4gnnebGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m66j
 G/b+2XyAjkBKceSjzGC9xqEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24nNSQPoGd
 RZSoHB36/Fvqgr7FbERQiFUvlaDtF0bY/AOSNcE0zi3jY/X/zmiPlI9G2sphMMdiOc6Qjkj1
 1msltzvBCByvLD9dU9x5ot4vhvpZ3FLcDZqiTssCFJcvoK9+N1bYgfnF447SMaIYsvJ9SYcK
 txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDCslNOZJhKTysDA3CMqsyq7DFDFtW
 1BexKCjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sBvWAlexc0aJ5fEdMMX
 KM1kVkLjHO0FCH1BZKbnqrrU5h6pUQePYqNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU
 ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r
 r5iCid940kFDbClPHCIqdV7wJJjBSFTOK0aYvd/LoarSjeK0kl7YxMI6b9+KYFjgYpPkeLEo
 iO0VkNCkQKtjnzbMwSaLHtkbeq3D5p4qHs6Ow0qPEqphCd/Mdr+sv9HestlZ6Qj+cxi0eVwE
 6sPdfKfD6kdUT/A4TkcM8Xw9dQwaBSxiAuSFCO5ezxjLYV4TgnE94a8LAvi/SUDFAStss46r
 +Hy3w/XW8NbFQ9jENzXeLSkyFbo5SoRn+d7Xk3pJNhPeRqzrNg2enKp1vJuepMCMxTOwDeex
 j26OxZAqLmfuZIx/fnImbuA89WjHdxhExcIBGLc97u3a3XXpzLx3Y9aXe+UVjnBT2eoqr66b
 OBYwvygYv0KmFFG79h1H7pxlP9s4tLuo/lRzxh+HWWNZFOuU+syLn6D1MhJl6tM2r4G5lfmB
 hPRooFXaeeTJcfoMF8NPw50PO2M2MYdliTW8flocl7x4zV6/ebfXEhfV/VWZPex8Feh3FsZ/
 Noc
IronPort-HdrOrdr: A9a23:ijdemKyemQREHMg1p0nYKrPwFr1zdoMgy1knxilNoRw8SK2lfq
 eV7YwmPH7P+U8ssR4b6LO90cW7Lk80sKQFhbX5Xo3SOjUO2lHYTr2KhLGKq1aLdkHDH6xmpM
 BdmsBFeabN5DNB7foSjjPXLz9Z+qjjzJyV
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="62240013"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich
	<JBeulich@suse.com>, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>
Subject: [PATCH 2/6] x86/prot-key: Split PKRU infrastructure out of asm/processor.h
Date: Thu, 16 Dec 2021 09:54:17 +0000
Message-ID: <20211216095421.12871-3-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

asm/processor.h is in desperate need of splitting up, and protection key
functionality in only used in the emulator and pagewalk.  Introduce a new
asm/prot-key.h and move the relevant content over.

Rename the PKRU_* constants to drop the user part and to use the architectural
terminology.

Drop the read_pkru_{ad,wd}() helpers entirely.  The pkru infix is about to
become wrong, and the sole user is shorter and easier to follow without the
helpers.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
---
 xen/arch/x86/include/asm/processor.h | 38 ------------------------------
 xen/arch/x86/include/asm/prot-key.h  | 45 ++++++++++++++++++++++++++++++++++++
 xen/arch/x86/mm/guest_walk.c         |  9 +++++---
 xen/arch/x86/x86_emulate.c           |  2 ++
 4 files changed, 53 insertions(+), 41 deletions(-)
 create mode 100644 xen/arch/x86/include/asm/prot-key.h

diff --git a/xen/arch/x86/include/asm/processor.h b/xen/arch/x86/include/asm/processor.h
index 400b4fac5ed4..eb1687d0795c 100644
--- a/xen/arch/x86/include/asm/processor.h
+++ b/xen/arch/x86/include/asm/processor.h
@@ -367,44 +367,6 @@ static always_inline void set_in_cr4 (unsigned long mask)
     write_cr4(read_cr4() | mask);
 }
 
-static inline unsigned int rdpkru(void)
-{
-    unsigned int pkru;
-
-    asm volatile (".byte 0x0f,0x01,0xee"
-        : "=a" (pkru) : "c" (0) : "dx");
-
-    return pkru;
-}
-
-static inline void wrpkru(unsigned int pkru)
-{
-    asm volatile ( ".byte 0x0f, 0x01, 0xef"
-                   :: "a" (pkru), "d" (0), "c" (0) );
-}
-
-/* Macros for PKRU domain */
-#define PKRU_READ  (0)
-#define PKRU_WRITE (1)
-#define PKRU_ATTRS (2)
-
-/*
- * PKRU defines 32 bits, there are 16 domains and 2 attribute bits per
- * domain in pkru, pkeys is index to a defined domain, so the value of
- * pte_pkeys * PKRU_ATTRS + R/W is offset of a defined domain attribute.
- */
-static inline bool_t read_pkru_ad(uint32_t pkru, unsigned int pkey)
-{
-    ASSERT(pkey < 16);
-    return (pkru >> (pkey * PKRU_ATTRS + PKRU_READ)) & 1;
-}
-
-static inline bool_t read_pkru_wd(uint32_t pkru, unsigned int pkey)
-{
-    ASSERT(pkey < 16);
-    return (pkru >> (pkey * PKRU_ATTRS + PKRU_WRITE)) & 1;
-}
-
 static always_inline void __monitor(const void *eax, unsigned long ecx,
                                     unsigned long edx)
 {
diff --git a/xen/arch/x86/include/asm/prot-key.h b/xen/arch/x86/include/asm/prot-key.h
new file mode 100644
index 000000000000..084b248d81a5
--- /dev/null
+++ b/xen/arch/x86/include/asm/prot-key.h
@@ -0,0 +1,45 @@
+/******************************************************************************
+ * arch/x86/include/asm/spec_ctrl.h
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Copyright (c) 2021 Citrix Systems Ltd.
+ */
+#ifndef ASM_PROT_KEY_H
+#define ASM_PROT_KEY_H
+
+#include <xen/types.h>
+
+#define PKEY_AD 1 /* Access Disable */
+#define PKEY_WD 2 /* Write Disable */
+
+#define PKEY_WIDTH 2 /* Two bits per protection key */
+
+static inline uint32_t rdpkru(void)
+{
+    uint32_t pkru;
+
+    asm volatile ( ".byte 0x0f,0x01,0xee"
+                   : "=a" (pkru) : "c" (0) : "dx" );
+
+    return pkru;
+}
+
+static inline void wrpkru(uint32_t pkru)
+{
+    asm volatile ( ".byte 0x0f, 0x01, 0xef"
+                   :: "a" (pkru), "d" (0), "c" (0) );
+}
+
+#endif /* ASM_PROT_KEY_H */
diff --git a/xen/arch/x86/mm/guest_walk.c b/xen/arch/x86/mm/guest_walk.c
index b9f607272c39..dc8fdde0212e 100644
--- a/xen/arch/x86/mm/guest_walk.c
+++ b/xen/arch/x86/mm/guest_walk.c
@@ -26,7 +26,9 @@
 #include <xen/paging.h>
 #include <xen/domain_page.h>
 #include <xen/sched.h>
+
 #include <asm/page.h>
+#include <asm/prot-key.h>
 #include <asm/guest_pt.h>
 #include <asm/hvm/emulate.h>
 
@@ -413,10 +415,11 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m,
          guest_pku_enabled(v) )
     {
         unsigned int pkey = guest_l1e_get_pkey(gw->l1e);
-        unsigned int pkru = rdpkru();
+        unsigned int pkr = rdpkru();
+        unsigned int pk_ar = pkr >> (pkey * PKEY_WIDTH);
 
-        if ( read_pkru_ad(pkru, pkey) ||
-             ((walk & PFEC_write_access) && read_pkru_wd(pkru, pkey) &&
+        if ( (pk_ar & PKEY_AD) ||
+             ((walk & PFEC_write_access) && (pk_ar & PKEY_WD) &&
               ((walk & PFEC_user_mode) || guest_wp_enabled(v))) )
         {
             gw->pfec |= PFEC_prot_key;
diff --git a/xen/arch/x86/x86_emulate.c b/xen/arch/x86/x86_emulate.c
index 1e082e6f3b2d..551ad0f7b303 100644
--- a/xen/arch/x86/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate.c
@@ -12,8 +12,10 @@
 #include <xen/domain_page.h>
 #include <xen/err.h>
 #include <xen/event.h>
+
 #include <asm/x86_emulate.h>
 #include <asm/processor.h> /* current_cpu_info */
+#include <asm/prot-key.h>
 #include <asm/xstate.h>
 #include <asm/amd.h> /* cpu_has_amd_erratum() */
 #include <asm/debugreg.h>
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 09:57:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 09:57:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247823.427384 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnW5-000195-M6; Thu, 16 Dec 2021 09:57:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247823.427384; Thu, 16 Dec 2021 09:57:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnW5-00018y-Ig; Thu, 16 Dec 2021 09:57:37 +0000
Received: by outflank-mailman (input) for mailman id 247823;
 Thu, 16 Dec 2021 09:57:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HYuw=RB=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mxnW3-00018s-Bn
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 09:57:35 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::61b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 96a586dd-5e56-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 10:57:33 +0100 (CET)
Received: from DU2P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::25)
 by AS8PR08MB6040.eurprd08.prod.outlook.com (2603:10a6:20b:296::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Thu, 16 Dec
 2021 09:57:31 +0000
Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:230:cafe::e0) by DU2P251CA0010.outlook.office365.com
 (2603:10a6:10:230::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Thu, 16 Dec 2021 09:57:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Thu, 16 Dec 2021 09:57:31 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Thu, 16 Dec 2021 09:57:31 +0000
Received: from 399ba925db51.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 41B3BAEC-D6B9-4A09-A416-64FF89A5630F.1; 
 Thu, 16 Dec 2021 09:57:17 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 399ba925db51.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 16 Dec 2021 09:57:17 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com (2603:10a6:20b:307::13)
 by AM8PR08MB5732.eurprd08.prod.outlook.com (2603:10a6:20b:1d4::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 09:57:14 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13]) by AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13%6]) with mapi id 15.20.4801.015; Thu, 16 Dec 2021
 09:57:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 96a586dd-5e56-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JTr32IhtOpI0DMpewFFRmpDZYkBAEYJFzNkVsLqr4Vo=;
 b=b4wccVPn8RbiyyqvGmw3OQeeaaVuDiQH4/R7X3L4lCseop5Q5N/SoCtIGhIe4QGjeCGgRcEl2xTJShlqAxDQB+xWguh53IJfkvzCU/fqQnZQXlfsv8yOIj65VpSStqp0GAdRqITy6csZaP2gi7QMm/bWck8Ic3s1PDk4KB+DkMM=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: d427460f0eb312dc
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IHgyW0b2kYbl9iU1N/378vCB2F5KIKh6LMd4fbVpau8HZNY4+7/W7RZoqZ7I1Qr2R4Q8WipzhFKxJ0sUvjT+kRQfbsJ2/ofmM7QLWsaeQWPKuNLq34eA4C3wbqBmIGOwVYfiryJ+m0pmznXgBUgtzVHqNqFX0qmOdWKojwRaU+5Ub1liyJv2Ez1Ex+Rd79saxOVCTKiJti3AF+WStrW57cgRtjLxUGLTVs+iRqhRDx0mfhn94pl6TJ5KaeoiCNknV6s1e6Bw/8w+4QW0+k98Ayij2f7kj/0ggRQss1wOrIYFBnbGrmAzp0mpmouqAWnvrDzxkZuOIjuv3zdGNpCaBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JTr32IhtOpI0DMpewFFRmpDZYkBAEYJFzNkVsLqr4Vo=;
 b=ZthYkBKGwRtTCOVKOI8banh++mjs5dqjuqL/J/ck9Aow5RCA08n1j/SYNKWmF/DuCDwjgL/Sn7tRZQ30emqHTaiCOBdntfMjKXYsH/gpg88JwGgMjR6QJUrFiBf9q9jNZItqiKC9VehkSQxLjDkoIS/1lWE6BBW/caZupuzY/oZw9ee5VN+PaOE4l2tO6/njdxjUGMozoKvph+GUcEu/ixJn+zOWC5VoqjhBC+QUeQi9Wteu088ziVwxK3Rcy6Kld+8gPREos8sge2wxbB5ZNOC3PBsJPYqqCKZ7w8MRXSbwOHadLVFewCswxs03abJBMG8WK7WST4hs+f+RqAUwWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JTr32IhtOpI0DMpewFFRmpDZYkBAEYJFzNkVsLqr4Vo=;
 b=b4wccVPn8RbiyyqvGmw3OQeeaaVuDiQH4/R7X3L4lCseop5Q5N/SoCtIGhIe4QGjeCGgRcEl2xTJShlqAxDQB+xWguh53IJfkvzCU/fqQnZQXlfsv8yOIj65VpSStqp0GAdRqITy6csZaP2gi7QMm/bWck8Ic3s1PDk4KB+DkMM=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
Thread-Topic: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
Thread-Index: AQHX8NfE0k+LAAwoDUiQfCEULp9EE6w0aQgAgAB74AA=
Date: Thu, 16 Dec 2021 09:57:13 +0000
Message-ID: <AA684EED-5631-4036-ABF1-596AD61787CC@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2112151817190.3376@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2112151817190.3376@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 4a7ddaba-a9ee-48bf-4506-08d9c07a79df
x-ms-traffictypediagnostic:
	AM8PR08MB5732:EE_|DB5EUR03FT038:EE_|AS8PR08MB6040:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB60405880A0F3F20171AA5DA1FC779@AS8PR08MB6040.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 RoJO0tnm6ixlukKfu8dopoHPi0mvk8AoRblBvr7DvRvfASpOe3z6ZV28pt2nuvC3nhlwMy2d7iTX276DuH3qZWQWRN1vb+bouuW8NtAOp7mDqm35PvMcQMBRf41zcEGkrzXsJAEKy7W8JioqeXfAOyI3mHqKWF7bCOmPWTO6G3gz1z6ZojPPnhhydkprYTPq4EVsQ1n672Y3jCMZy9FABcVV9PdhNCuBqVhdgTeMJVLL1pzeuoqnAJRK/dkITVjaR4CH9j1ED5Ik7iHdm7DFv04JRF9oU4C6kX4qOshUYH5TjEJBgBkfrjKZ8maAX5pANBh5Ef1aNK0NIvUYSRqUgDW6usj9bFOPFbZR0P8u3wqvSX029hdROp6Ejp6kta90iZ8FrBWekT76JWyIQil7AdGNM+BpC0a+9sO8HQVy/H2y7yRnKvWAacyj+wr19q8CSMinDu5iyaGL0eDswAhLV0LVUWYVxxyLPwqyov2jlrnq8Mj3Nj9pfzdaGXWiCWXqSAuITeSFjWIvfz4w9qByCWT8aDBa+yypQqrysdYbQNU1Ac/jB67tukD+Ii9v97scP9ATsfEIq3tdICrweT5/aAKdiHKCmujpDpLEfJ5rhrg3LLjtqdWU+CJKQdDhfBiUlslFqJRVktY24vOIw0+XLQzGiOiaNeJaDsifWdIpNwf/SlujtDzn9wZok7QkWGO17C+egZXM6N63eN1eNh2KoP5u6zrFKZol4Yv5U5p9KnXHZaqMAjjmBSE1QjsAbtJN
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB6914.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(2906002)(316002)(6916009)(186003)(36756003)(122000001)(2616005)(6486002)(6506007)(53546011)(4326008)(91956017)(26005)(76116006)(66946007)(508600001)(66476007)(66556008)(6512007)(8936002)(66446008)(54906003)(64756008)(83380400001)(86362001)(71200400001)(5660300002)(38070700005)(33656002)(8676002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <401A4A3CA823174081EF4121D7ADE7AA@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5732
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6a0c412b-6ec8-4bde-d7b5-08d9c07a6f34
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7YPQ+pErUDPmgYMw1x9Qaj5jM2gKiaJggUXmKuEpkjcFZlRhsgEZJlfLAQ+kO0JiwAurDGrkhBC3ulxnv1/GdMIOqc0p//9/zzLjgtAj5+zDkEVBZMYDnVfW7RTyAdYCO+lrFoWS3KqaIfjH5qeoGCB5nZljUAuo6kSWcdXyX6m05Qz96pBadM5tfGE5GG1cpROg3/Gw3K1ABAzsOC7E1FFNiU5/Fe9tiIzxifNNKSFyKahsxLEj/crSl2DzL/WIVnxQgwuV9pxGSUhVRwFrIOvoxZQUX3lMRyLVnh6qsUsconLFA7n2k28QxJL1FuUDyz36ssapdb8tCEJiiGUCvlanDuvQi31aVbtCBgz2cmstOZAIGUpUTl9LziiTVRVAv2ZM2Ab9DON/uLBqVLZXuJTtDUM3PYityvkRobRd0dh12LkKM1c+rCqLoGM/8zi25ffj+Z08NfSGqh/sBjDJC38S7hiFCSEBLM5CV2ah420AlrUFc2CPYyM8UiRIOMTvqFaWJOxk3w4RDRDA9njssoB2zCLoPz0PcSzv/4IOnfsGWDLOHaWFvDdpILQncEBTIqfIl5AFaY7PKcyqutseptmySFi7CzYHbdCsoHtn53UdsZX/JDPTD+RyJ0uEnlQVgbVbLxooddU3lWvxjSTi1Wh3YBF77/rpCF5hNocL02885IgwOMoSO1WNPltEb+ELewkdE/r1NbUMAqGbO56TOyI5UdxpMHYfz4xSFIBUuX9ro3aUiturSo+EjT7Z/9XUKyh01CwotXov5peFHZDhEw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(54906003)(36756003)(356005)(2616005)(5660300002)(33656002)(36860700001)(86362001)(4326008)(82310400004)(6862004)(107886003)(186003)(40460700001)(336012)(2906002)(83380400001)(47076005)(6506007)(26005)(53546011)(81166007)(8676002)(8936002)(508600001)(6512007)(316002)(6486002)(70586007)(70206006);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 09:57:31.2759
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a7ddaba-a9ee-48bf-4506-08d9c07a79df
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6040

SGkgU3RlZmFubywNCg0KPiBPbiAxNiBEZWMgMjAyMSwgYXQgMjozMyBhbSwgU3RlZmFubyBTdGFi
ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIFR1ZSwgMTQg
RGVjIDIwMjEsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4gSU8gcG9ydHMgb24gQVJNIGRvbid0IGV4
aXN0IHNvIGFsbCBJTyBwb3J0cyByZWxhdGVkIGh5cGVyY2FsbHMgYXJlIGdvaW5nDQo+PiB0byBm
YWlsIG9uIEFSTSB3aGVuIHdlIHBhc3N0aHJvdWdoIGEgUENJIGRldmljZS4NCj4+IEZhaWx1cmUg
b2YgeGNfZG9tYWluX2lvcG9ydF9wZXJtaXNzaW9uKC4uKSB3b3VsZCB0dXJuIGludG8gYSBjcml0
aWNhbA0KPj4gZmFpbHVyZSBhdCBkb21haW4gY3JlYXRpb24uIFdlIG5lZWQgdG8gYXZvaWQgdGhp
cyBvdXRjb21lLCBpbnN0ZWFkIHdlDQo+PiB3YW50IHRvIGNvbnRpbnVlIHdpdGggZG9tYWluIGNy
ZWF0aW9uIGFzIG5vcm1hbCBldmVuIGlmDQo+PiB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24o
Li4pIGZhaWxzLiBYRU5fRE9NQ1RMX2lvcG9ydF9wZXJtaXNzaW9uDQo+PiBpcyBub3QgaW1wbGVt
ZW50ZWQgb24gQVJNIHNvIGl0IHdvdWxkIHJldHVybiAtRU5PU1lTLg0KPj4gDQo+PiBUbyBzb2x2
ZSBhYm92ZSBpc3N1ZSByZW1vdmUgUENJIEkvTyByYW5nZXMgcHJvcGVydHkgdmFsdWUgZnJvbSBk
b20wDQo+PiBkZXZpY2UgdHJlZSBub2RlIHNvIHRoYXQgZG9tMCBsaW51eCB3aWxsIG5vdCBhbGxv
Y2F0ZSBJL08gc3BhY2UgZm9yIFBDSQ0KPj4gZGV2aWNlcyBpZiBwY2ktcGFzc3Rocm91Z2ggaXMg
ZW5hYmxlZC4NCj4+IA0KPj4gQW5vdGhlciB2YWxpZCByZWFzb24gdG8gcmVtb3ZlIEkvTyByYW5n
ZXMgaXMgdGhhdCBQQ0kgSS9PIHNwYWNlIGFyZSBub3QNCj4+IG1hcHBlZCB0byBkb20wIHdoZW4g
UENJIHBhc3N0aHJvdWdoIGlzIGVuYWJsZWQsIGFsc28gdGhlcmUgaXMgbm8gdnBjaQ0KPj4gdHJh
cCBoYW5kbGVyIHJlZ2lzdGVyIGZvciBJTyBiYXIuDQo+PiANCj4+IFNpZ25lZC1vZmYtYnk6IFJh
aHVsIFNpbmdoIDxyYWh1bC5zaW5naEBhcm0uY29tPg0KPj4gLS0tDQo+PiB4ZW4vYXJjaC9hcm0v
ZG9tYWluX2J1aWxkLmMgICB8IDE0ICsrKysrKysNCj4+IHhlbi9jb21tb24vZGV2aWNlX3RyZWUu
YyAgICAgIHwgNzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4+IHhlbi9p
bmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oIHwgMTAgKysrKysNCj4+IDMgZmlsZXMgY2hhbmdlZCwg
OTYgaW5zZXJ0aW9ucygrKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFp
bl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+PiBpbmRleCBkMDJiYWNi
Y2QxLi42MGY2YjJjNzNiIDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWls
ZC5jDQo+PiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+IEBAIC03NDksNiAr
NzQ5LDExIEBAIHN0YXRpYyBpbnQgX19pbml0IHdyaXRlX3Byb3BlcnRpZXMoc3RydWN0IGRvbWFp
biAqZCwgc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywNCj4+ICAgICAgICAgICAgICAgICBjb250
aW51ZTsNCj4+ICAgICAgICAgfQ0KPj4gDQo+PiArICAgICAgICBpZiAoIGlzX3BjaV9wYXNzdGhy
b3VnaF9lbmFibGVkKCkgJiYNCj4+ICsgICAgICAgICAgICAgICAgZHRfZGV2aWNlX3R5cGVfaXNf
ZXF1YWwobm9kZSwgInBjaSIpICkNCj4+ICsgICAgICAgICAgICBpZiAoIGR0X3Byb3BlcnR5X25h
bWVfaXNfZXF1YWwocHJvcCwgInJhbmdlcyIpICkNCj4+ICsgICAgICAgICAgICAgICAgY29udGlu
dWU7DQo+IA0KPiBJdCBsb29rcyBsaWtlIHdlIGFyZSBza2lwcGluZyB0aGUgInJhbmdlcyIgcHJv
cGVydHkgZW50aXJlbHkgZm9yIHRoZSBQQ0kNCj4gbm9kZSwgaXMgdGhhdCByaWdodD8gV291bGRu
J3QgdGhhdCBhbHNvIHJlbW92ZSB0aGUgb3RoZXIgKG5vdCBpb3BvcnRzKQ0KPiBhZGRyZXNzIHJh
bmdlcz8NCg0KV2UgYXJlIHNraXBwaW5nIHRoZSDigJxyYW5nZXPigJ0gcHJvcGVydHkgaGVyZSB0
byBhdm9pZCBzZXR0aW5nIHRoZSDigJxyYW5nZXPigJ0gcHJvcGVydHkgd2hlbg0KcGNpX3Bhc3N0
aHJvdWdoIGlzIGVuYWJsZWQuIFdlIHdpbGwgcmVtb3ZlIG9ubHkgcmVtb3ZlIElPIHBvcnQgYW5k
IHNldCB0aGUgb3RoZXIg4oCYcmFuZ2Vz4oCdIHByb3BlcnR5IA0KdmFsdWUgaW4gZHRfcGNpX3Jl
bW92ZV9pb19yYW5nZXMoKSBpbiBuZXh0IGlmKCkgY29uZGl0aW9uLg0KIA0KDQo+PiAgICAgICAg
IHJlcyA9IGZkdF9wcm9wZXJ0eShraW5mby0+ZmR0LCBwcm9wLT5uYW1lLCBwcm9wX2RhdGEsIHBy
b3BfbGVuKTsNCj4+IA0KPj4gICAgICAgICBpZiAoIHJlcyApDQo+PiBAQCAtNzY5LDYgKzc3NCwx
NSBAQCBzdGF0aWMgaW50IF9faW5pdCB3cml0ZV9wcm9wZXJ0aWVzKHN0cnVjdCBkb21haW4gKmQs
IHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sDQo+PiAgICAgICAgICAgICBpZiAoIHJlcyApDQo+
PiAgICAgICAgICAgICAgICAgcmV0dXJuIHJlczsNCj4+ICAgICAgICAgfQ0KPj4gKw0KPj4gKyAg
ICAgICAgLyoNCj4+ICsgICAgICAgICAqIFBDSSBJTyBiYXIgYXJlIG5vdCBtYXBwZWQgdG8gZG9t
MCB3aGVuIFBDSSBwYXNzdGhyb3VnaCBpcyBlbmFibGVkLA0KPj4gKyAgICAgICAgICogYWxzbyB0
aGVyZSBpcyBubyB0cmFwIGhhbmRsZXIgcmVnaXN0ZXJlZCBmb3IgSU8gYmFyIHRoZXJlZm9yIHJl
bW92ZQ0KPj4gKyAgICAgICAgICogdGhlIElPIHJhbmdlIHByb3BlcnR5IGZyb20gdGhlIGRldmlj
ZSB0cmVlIG5vZGUgZm9yIGRvbTAuDQo+PiArICAgICAgICAgKi8NCj4+ICsgICAgICAgIHJlcyA9
IGR0X3BjaV9yZW1vdmVfaW9fcmFuZ2VzKGtpbmZvLT5mZHQsIG5vZGUpOw0KPj4gKyAgICAgICAg
aWYgKCByZXMgKQ0KPj4gKyAgICAgICAgICAgIHJldHVybiByZXM7DQo+IA0KPiBJIHRyaWVkIHRv
IGFwcGx5IHRoaXMgcGF0Y2ggdG8gc3RhZ2luZyB0byBtYWtlIGl0IGVhc2llciB0byByZXZpZXcg
YnV0IEkNCj4gdGhpbmsgdGhpcyBjaHVjayBnb3QgYXBwbGllZCB3cm9uZ2x5OiBJIGNhbiBzZWUN
Cj4gZHRfcGNpX3JlbW92ZV9pb19yYW5nZXMoKSBhZGRlZCB0byB0aGUgZnVuY3Rpb24gImhhbmRs
ZV9wcm9wX3BmZHQiIHdoaWNoDQo+IGlzIGZvciBndWVzdCBwYXJ0aWFsIERUQnMgYW5kIG5vdCBm
b3IgZG9tMC4NCg0KT2xla3NhbmRy4oCZcyBwYXRjaCBzZXJpZXMgd2FzIG1lcmdlZCB5ZXN0ZXJk
YXkgYmVjYXVzZSBvZiB0aGF0IHRoZXJlIGlzIGNvbmZsaWN0IGluIGFwcGx5aW5nIA0KdGhpcyBw
YXRjaC4gSSB3aWxsIHJlYmFzZSB0aGUgcGF0Y2ggYW5kIHdpbGwgc2VuZCBpdCBhZ2FpbiBmb3Ig
cmV2aWV3Lg0KDQo+IA0KPiBJcyBkdF9wY2lfcmVtb3ZlX2lvX3JhbmdlcygpIG1lYW50IHRvIGJl
IGNhbGxlZCBmcm9tIHdyaXRlX3Byb3BlcnRpZXMNCj4gaW5zdGVhZD8gSXQgbG9va3MgbGlrZSBp
dCB3b3VsZCBiZSBiZXN0IHRvIGNhbGwgaXQgZnJvbQ0KPiB3cml0ZV9wcm9wZXJ0aWVzLCBtYXli
ZSBpdCBjb3VsZCBiZSBjb21iaW5lZCB3aXRoIHRoZSBvdGhlciBuZXcgY2hlY2sNCj4ganVzdCBh
Ym92ZSBpbiB0aGlzIHBhdGNoPw0KDQpZZXMgZHRfcGNpX3JlbW92ZV9pb19yYW5nZXMoKSBpcyB0
byBiZSBjYWxsZWQgZnJvbSB3cml0ZV9wcm9wZXJ0aWVzKCkuDQoNClJlZ2FyZHMsDQpSYWh1bA0K
PiANCj4gDQo+PiAgICAgLyoNCj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2RldmljZV90cmVl
LmMgYi94ZW4vY29tbW9uL2RldmljZV90cmVlLmMNCj4+IGluZGV4IDRhYWUyODFlODkuLjlmYTI1
ZjY3MjMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vY29tbW9uL2RldmljZV90cmVlLmMNCj4+ICsrKyBi
L3hlbi9jb21tb24vZGV2aWNlX3RyZWUuYw0KPj4gQEAgLTIxOTUsNiArMjE5NSw3OCBAQCBpbnQg
ZHRfZ2V0X3BjaV9kb21haW5fbnIoc3RydWN0IGR0X2RldmljZV9ub2RlICpub2RlKQ0KPj4gICAg
IHJldHVybiAodTE2KWRvbWFpbjsNCj4+IH0NCj4+IA0KPj4gK2ludCBkdF9wY2lfcmVtb3ZlX2lv
X3Jhbmdlcyh2b2lkICpmZHQsIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZGV2KQ0KPj4g
K3sNCj4+ICsgICAgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpwYXJlbnQgPSBOVUxMOw0K
Pj4gKyAgICBjb25zdCBzdHJ1Y3QgZHRfYnVzICpidXMsICpwYnVzOw0KPj4gKyAgICB1bnNpZ25l
ZCBpbnQgcmxlbjsNCj4+ICsgICAgaW50IG5hLCBucywgcG5hLCBwbnMsIHJvbmUsIHJldDsNCj4+
ICsgICAgY29uc3QgX19iZTMyICpyYW5nZXM7DQo+PiArICAgIF9fYmUzMiByZWdzWygoR1VFU1Rf
Uk9PVF9BRERSRVNTX0NFTExTICogMikgKyBHVUVTVF9ST09UX1NJWkVfQ0VMTFMgKyAxKQ0KPj4g
KyAgICAgICAgICAgICAgICogMl07DQo+PiArICAgIF9fYmUzMiAqYWRkciA9ICZyZWdzWzBdOw0K
Pj4gKw0KPj4gKyAgICBidXMgPSBkdF9tYXRjaF9idXMoZGV2KTsNCj4+ICsgICAgaWYgKCAhYnVz
ICkNCj4+ICsgICAgICAgIHJldHVybiAwOyAvKiBkZXZpY2UgaXMgbm90IGEgYnVzICovDQo+PiAr
DQo+PiArICAgIHBhcmVudCA9IGR0X2dldF9wYXJlbnQoZGV2KTsNCj4+ICsgICAgaWYgKCBwYXJl
bnQgPT0gTlVMTCApDQo+PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+ICsNCj4+ICsgICAg
cmFuZ2VzID0gZHRfZ2V0X3Byb3BlcnR5KGRldiwgInJhbmdlcyIsICZybGVuKTsNCj4+ICsgICAg
aWYgKCByYW5nZXMgPT0gTlVMTCApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIHByaW50ayhYRU5M
T0dfRVJSICJEVDogbm8gcmFuZ2VzOyBjYW5ub3QgZW51bWVyYXRlICVzXG4iLA0KPj4gKyAgICAg
ICAgICAgICAgIGRldi0+ZnVsbF9uYW1lKTsNCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0K
Pj4gKyAgICB9DQo+PiArICAgIGlmICggcmxlbiA9PSAwICkgLyogTm90aGluZyB0byBkbyAqLw0K
Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+PiArDQo+PiArICAgIGJ1cy0+Y291bnRfY2VsbHMoZGV2
LCAmbmEsICZucyk7DQo+PiArICAgIGlmICggIURUX0NIRUNLX0NPVU5UUyhuYSwgbnMpICkNCj4+
ICsgICAgew0KPj4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgImR0X3BhcnNlOiBCYWQgY2Vs
bCBjb3VudCBmb3IgZGV2aWNlICVzXG4iLA0KPj4gKyAgICAgICAgICAgICAgICAgIGRldi0+ZnVs
bF9uYW1lKTsNCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPj4gKyAgICB9DQo+PiArICAg
IHBidXMgPSBkdF9tYXRjaF9idXMocGFyZW50KTsNCj4+ICsgICAgaWYgKCBwYnVzID09IE5VTEwg
KQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBwcmludGsoIkRUOiAlcyBpcyBub3QgYSB2YWxpZCBi
dXNcbiIsIHBhcmVudC0+ZnVsbF9uYW1lKTsNCj4+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0K
Pj4gKyAgICB9DQo+PiArDQo+PiArICAgIHBidXMtPmNvdW50X2NlbGxzKGRldiwgJnBuYSwgJnBu
cyk7DQo+PiArICAgIGlmICggIURUX0NIRUNLX0NPVU5UUyhwbmEsIHBucykgKQ0KPj4gKyAgICB7
DQo+PiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAiZHRfcGFyc2U6IEJhZCBjZWxsIGNvdW50
IGZvciBwYXJlbnQgJXNcbiIsDQo+PiArICAgICAgICAgICAgICAgZGV2LT5mdWxsX25hbWUpOw0K
Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+PiArICAgIH0NCj4+ICsgICAgLyogTm93IHdh
bGsgdGhyb3VnaCB0aGUgcmFuZ2VzICovDQo+PiArICAgIHJsZW4gLz0gNDsNCj4+ICsgICAgcm9u
ZSA9IG5hICsgcG5hICsgbnM7DQo+PiArDQo+PiArICAgIGZvciAoIDsgcmxlbiA+PSByb25lOyBy
bGVuIC09IHJvbmUsIHJhbmdlcyArPSByb25lICkNCj4+ICsgICAgew0KPj4gKyAgICAgICAgdW5z
aWduZWQgaW50IGZsYWdzID0gYnVzLT5nZXRfZmxhZ3MocmFuZ2VzKTsNCj4+ICsgICAgICAgIGlm
ICggZmxhZ3MgJiBJT1JFU09VUkNFX0lPICkNCj4+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4+
ICsNCj4+ICsgICAgICAgIG1lbWNweShhZGRyLCByYW5nZXMsIDQgKiByb25lKTsNCj4+ICsNCj4+
ICsgICAgICAgIGFkZHIgKz0gcm9uZTsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gKyAgICByZXQgPSBm
ZHRfcHJvcGVydHkoZmR0LCAicmFuZ2VzIiwgcmVncywgc2l6ZW9mKHJlZ3MpKTsNCj4+ICsgICAg
aWYgKCByZXQgKQ0KPj4gKyAgICAgICAgcmV0dXJuIHJldDsNCj4+ICsNCj4+ICsgICAgcmV0dXJu
IDA7DQo+PiArfQ0KPj4gKw0KPj4gLyoNCj4+ICAqIExvY2FsIHZhcmlhYmxlczoNCj4+ICAqIG1v
ZGU6IEMNCj4+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vZGV2aWNlX3RyZWUuaCBiL3hl
bi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+PiBpbmRleCBmZDZjZDAwYjQzLi5hZDJlOTA1
NTk1IDEwMDY0NA0KPj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL2RldmljZV90cmVlLmgNCj4+ICsr
KyBiL3hlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oDQo+PiBAQCAtODQ5LDYgKzg0OSwxNiBA
QCBpbnQgZHRfY291bnRfcGhhbmRsZV93aXRoX2FyZ3MoY29uc3Qgc3RydWN0IGR0X2RldmljZV9u
b2RlICpucCwNCj4+ICAqLw0KPj4gaW50IGR0X2dldF9wY2lfZG9tYWluX25yKHN0cnVjdCBkdF9k
ZXZpY2Vfbm9kZSAqbm9kZSk7DQo+PiANCj4+ICsvKioNCj4+ICsgKiBkdF9nZXRfcmVtb3ZlX2lv
X3JhbmdlIC0gUmVtb3ZlIHRoZSBQQ0kgSS9PIHJhbmdlIHByb3BlcnR5IHZhbHVlLg0KPj4gKyAq
IEBmZHQ6IFBvaW50ZXIgdG8gdGhlIGZpbGUgZGVzY3JpcHRvciB0cmVlLg0KPj4gKyAqIEBub2Rl
OiBEZXZpY2UgdHJlZSBub2RlLg0KPj4gKyAqDQo+PiArICogVGhpcyBmdW5jdGlvbiB3aWxsIHJl
bW92ZSB0aGUgUENJIElPIHJhbmdlIHByb3BlcnR5IGZyb20gdGhlIFBDSSBkZXZpY2UgdHJlZQ0K
Pj4gKyAqIG5vZGUuDQo+PiArICovDQo+PiAraW50IGR0X3BjaV9yZW1vdmVfaW9fcmFuZ2VzKHZv
aWQgKmZkdCwgY29uc3Qgc3RydWN0IGR0X2RldmljZV9ub2RlICpub2RlKTsNCj4+ICsNCj4+IHN0
cnVjdCBkdF9kZXZpY2Vfbm9kZSAqZHRfZmluZF9ub2RlX2J5X3BoYW5kbGUoZHRfcGhhbmRsZSBo
YW5kbGUpOw0KPj4gDQo+PiAjaWZkZWYgQ09ORklHX0RFVklDRV9UUkVFX0RFQlVHDQo+PiAtLSAN
Cj4+IDIuMjUuMQ0KDQo=


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 10:18:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 10:18:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247843.427395 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnqa-0003u4-Gg; Thu, 16 Dec 2021 10:18:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247843.427395; Thu, 16 Dec 2021 10:18:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxnqa-0003tx-DK; Thu, 16 Dec 2021 10:18:48 +0000
Received: by outflank-mailman (input) for mailman id 247843;
 Thu, 16 Dec 2021 10:18:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HYuw=RB=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mxnqZ-0003tr-29
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 10:18:47 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20606.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::606])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c14501b-5e59-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 11:18:44 +0100 (CET)
Received: from AM6P192CA0072.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::49)
 by AM0PR08MB5363.eurprd08.prod.outlook.com (2603:10a6:208:188::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Thu, 16 Dec
 2021 10:18:41 +0000
Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:82:cafe::39) by AM6P192CA0072.outlook.office365.com
 (2603:10a6:209:82::49) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Thu, 16 Dec 2021 10:18:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Thu, 16 Dec 2021 10:18:41 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Thu, 16 Dec 2021 10:18:41 +0000
Received: from a6c78744220e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9133820E-8B9C-4D9C-BD68-E428C6E6B88E.1; 
 Thu, 16 Dec 2021 10:18:34 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a6c78744220e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 16 Dec 2021 10:18:34 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com (2603:10a6:20b:307::13)
 by AM0PR08MB3043.eurprd08.prod.outlook.com (2603:10a6:208:5f::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 10:18:33 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13]) by AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13%6]) with mapi id 15.20.4801.015; Thu, 16 Dec 2021
 10:18:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c14501b-5e59-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HmrlPbWYo0z6bPIkkb0DEA0k0UEdDuhKVlfP8LScv9E=;
 b=K+a0iFXkeD6dzYIZhI+WR+hO7kiGflacXdevVltm6yaI4LCadu+ledTWyX0Mqx7X37y9+32luJ12Utboveage2fq+IB+ue7WLVjYoBjxJPhU7Zo5JoNRDMcDJKHq4FKpyzJlBYP8SwQFKn3tzgMX0e2cXR8R2HAzzDWRyyteGQU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 9c6c30e9803b26e8
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Lqy0jHZaVsiHeIhwMxFyLlQH2hnm1OkG8MLUFSLDTxuuOslwbTf7q+bG7+qgZ6apF9wt3msTmk9zUzd6GfG3Ol2slbQdYHu3TZ1vzXdK0XPavMOKOaGFaM6ob70rIW552szdmBZNHvL4teY9TMRkacExXwcJ3Woe11OHNlLvkT6wb93/D8NLUegMFdkFUflD+iIf/gNOxBs369kczp5j1M0yxdyIFPCbXuPtrfV0zZ4ZYtkD4N1/sa8BMp/GBWjohd8uY9tlnzdjlu1KYz0szIuONNvNEPon05e8qxivH26CRkxuufpCYG7GC4DSh6h9eAJl4QY2N4O/o0+692yWEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HmrlPbWYo0z6bPIkkb0DEA0k0UEdDuhKVlfP8LScv9E=;
 b=I/6Ot2x1bMRgxK4hq+ihV0GCFENwNTGOeIAeFH9r/CHUYaD7NwfsSZ8Ngk4icCSQs/E/0cR/5N3IUdMGm9Z2WQGwzPTw0PnxbIsNss7j8OelSpDh7lROZSOsF9UKcOGio6QT6fuN+wUg1F/KWyfEatl/xbMryukHCcJf4O/tt8O3Pc20JZwac/bFK/53RBTpmXsiMffYRxXvk0ArodLJnyuraeuZjodAggWRp6HQoiVKTrV22XFVWBtPR65vbA2qhzQFK5RDQeoVZPBa+miWCDA91bC51hVuiLsBtucvmtsObLW4AkCq5U+xYi9UtT2i7IDSUKQKEoGHe8uRlN9eKQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HmrlPbWYo0z6bPIkkb0DEA0k0UEdDuhKVlfP8LScv9E=;
 b=K+a0iFXkeD6dzYIZhI+WR+hO7kiGflacXdevVltm6yaI4LCadu+ledTWyX0Mqx7X37y9+32luJ12Utboveage2fq+IB+ue7WLVjYoBjxJPhU7Zo5JoNRDMcDJKHq4FKpyzJlBYP8SwQFKn3tzgMX0e2cXR8R2HAzzDWRyyteGQU=
From: Rahul Singh <Rahul.Singh@arm.com>
To: =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Topic: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Index: AQHX8NfN625eD/1es0eaHkpOvTmQ3Kwx7OWAgAL9+QA=
Date: Thu, 16 Dec 2021 10:18:32 +0000
Message-ID: <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
In-Reply-To: <YbiP7YlpY22llB5Y@Air-de-Roger>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 80592a52-ba68-4542-628a-08d9c07d6eec
x-ms-traffictypediagnostic:
	AM0PR08MB3043:EE_|AM5EUR03FT004:EE_|AM0PR08MB5363:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB5363A1989E7CC616047CEEF6FC779@AM0PR08MB5363.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Zj1DyQdgrREFrlYJ9yjx75o8eZAslh1Kf5Kp73UJgPkNVBofxvbaXV+3/Zy0EydIrOg+4A8IVKjETb2y/Iz0NyIRxzI9xR011DEYVVP7Pqxpk7cpXivR+PDw2F19yL8trLdt9f4+vre5Wihi57XeYwGiQEPM2qJP4jhA7iTJJKAzWpx1yv0+NXH+Eylrs1ZBoW1lvyuIkTQC1EHIKeaMobs4CMoQ8Vz4eKZ+e12KfkklpUVVsO04WUDxHyoYFHth2DbTwdM6uT51O2VkHihgZdWIm7uxi8HeZ1NsoLbh8fRwkTPRryCAy9XeCt203MjInnYH8+iqY2Q4lS55DDHpNjqhWUhaBorBtbCjzAWI42YqQe9pYq+ZNxuP6VtupBVjwvNPCspa+qOzVK9cynGeg+QMM5rz4+eOZLbV3IGoIT55IIh83/oGJTkSm51Q9txypsRUhD3AnjC73GbkX2R82WehZ8qs0g6cHBrChzwWffYaWDtS0UCzTdZvShqXE50S/+UcWoCMyeUecCruWMJtlzx7bhS5vApV9q04DpkTMKhDDHNXjhgkMKaqo3I5hr5LuW82NtFzcbHPutLKeOX5zta07ApZ2gIhOKPia4rS2DfOj7323WgVaSBtKkCFrefujEYG8y9LHg4mAa/yn/oDniBu4TmQWto+ojkpKLjg47Ap9pCsUpT9BifEBmpM6SzBuST+FmCX4Ox5p8BaPQt2gGvcJ49dlALp1+AiuT4Ba0UH91z1jPcqRbEXS8aQvl2ND9xeTTYIe7x5f5Ls4hkySg+tsilxFDLUdxpQBNoeguPVFDWe8iVVDUedSaE7qSGpXxjrqQiHGuj1KPtIPfTYkLGB7eudExxwdJKgsjXUrBA=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB6914.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(122000001)(71200400001)(6512007)(66446008)(66556008)(2906002)(36756003)(66946007)(26005)(2616005)(6916009)(33656002)(508600001)(4326008)(86362001)(8936002)(186003)(53546011)(6506007)(30864003)(64756008)(66476007)(8676002)(38100700002)(6486002)(76116006)(91956017)(38070700005)(5660300002)(54906003)(316002)(45980500001)(309714004);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <4992BD3E6C911848BFB81898FCF7D0C8@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3043
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d2e0b2f7-5943-4cc8-9771-08d9c07d69de
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Y0R/BLuc6Zx2zFebXTKzKuhXbzgViDgx4PkuZ39XLgd8cCLBeTPG8UV5NjMZzmN4FQpfp2qOspgPJrWFV+CqGjaUUXXFQwtWevCNWoK8hYF9TZxsvMg6Z9cLrE+PElgmblqAkE6oJ0uFZxDqjAWOX/MrzscYci9h/8/TFg+DfsW1s5HkJW1uYwNe+N+pT+y+b6CFT8X5wIG1kaXo3r10uDZwCC0aXPXjrc2pL2EjBCpe1CJGljV8gM1xOYX3/VrXrLpDki2o7ROM2koXtINeSIx85+TT6qC5i7u0x3e0bHzzcpnsxhs4J/lhUi0YpeXBBSVAftOTQYXM36DHjLe4cC75UD31LpbAV3xmEnzD1EfyNlRM3ZZhlXU0k2UZpsSLVwTEmZOoF4cJG2rW24/l3RCdoBXNwp+2bnI87asP0byJeBL9vYu4/Qr8mhHRW4QKh3JrtZLXnVFdyxmjq3YOKvnYTYygVlp9Qh4xeadmKFeRRQBURKZrwMe4VQI3kyx7G1TlqBGBzcJWPYrE/GkAm0KgeZjcExTKDnBBeEqKmhWbVYiZsG5z9kSjjRsr/9nOxXfgQq/RMptT3Kl+JltlctKx0Nt7yFTd3JVR4TEm3gtEyRhxX03DgTLNdKFN9z+8x4Kyb7yc8RaAeZp3IsxVyNRTiIzETDvvgmMi4SWxlpamMLoKaUdIKhXIadVftl8qrR2jscFgS5f0OWbd6+iIl0raKbBTy1UCbTW9zQfp5jSp6gM6KIj9xjf8QmBlZ2LztvVOE8DKjDJXg8niS/yeUrruoxIiAoJI4BqzrWZWAx52tDvXmbCS4uvkLL/xrU1nqwsUjsNjuabV8C3OevT5lRafy4N7pkboBbY8fNbBcjlA9Ryp4/2Xj98jOp86dPET
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(47076005)(30864003)(33656002)(53546011)(107886003)(6506007)(356005)(336012)(81166007)(36756003)(8936002)(26005)(8676002)(83380400001)(4326008)(186003)(36860700001)(2616005)(2906002)(508600001)(6862004)(86362001)(70206006)(70586007)(6486002)(40460700001)(5660300002)(6512007)(82310400004)(316002)(54906003)(309714004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 10:18:41.3285
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 80592a52-ba68-4542-628a-08d9c07d6eec
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5363

SGkgUm9nZXIsDQoNClRoYW5rcyBmb3IgcmV2aWV3aW5nIHRoZSBjb2RlLg0KDQo+IE9uIDE0IERl
YyAyMDIxLCBhdCAxMjozNyBwbSwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5j
b20+IHdyb3RlOg0KPiANCj4gT24gVHVlLCBEZWMgMTQsIDIwMjEgYXQgMTA6NDU6MTdBTSArMDAw
MCwgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiB2cGNpL21zaXguYyBmaWxlIHdpbGwgYmUgdXNlZCBm
b3IgYXJtIGFyY2hpdGVjdHVyZSB3aGVuIHZwY2kgbXNpeA0KPj4gc3VwcG9ydCB3aWxsIGJlIGFk
ZGVkIHRvIEFSTSwgYnV0IHRoZXJlIGlzIHg4NiBzcGVjaWZpYyBjb2RlIGluIHRoaXMNCj4+IGZp
bGUuDQo+PiANCj4+IE1vdmUgeDg2IHNwZWNpZmljIGNvZGUgdG8gdGhlIHg4Nl9tc2l4LmMgZmls
ZSB0byBtYWtlIHN1cmUgY29tbW9uIGNvZGUNCj4+IHdpbGwgYmUgdXNlZCBmb3Igb3RoZXIgYXJj
aGl0ZWN0dXJlLg0KPj4gDQo+PiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZC4NCj4+IA0K
Pj4gU2lnbmVkLW9mZi1ieTogUmFodWwgU2luZ2ggPHJhaHVsLnNpbmdoQGFybS5jb20+DQo+PiAt
LS0NCj4+IHhlbi9hcmNoL3g4Ni9tc2kuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0N
Cj4+IHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9pbml0LmMgfCAgIDEgKw0KPj4g
eGVuL2RyaXZlcnMvdnBjaS9NYWtlZmlsZSAgICAgICAgICAgICAgICB8ICAgMSArDQo+PiB4ZW4v
ZHJpdmVycy92cGNpL21zaS5jICAgICAgICAgICAgICAgICAgIHwgICAzICstDQo+PiB4ZW4vZHJp
dmVycy92cGNpL21zaXguYyAgICAgICAgICAgICAgICAgIHwgMTM0ICsrKysrLS0tLS0tLS0tLS0t
LS0tDQo+PiB4ZW4vZHJpdmVycy92cGNpL3g4Nl9tc2l4LmMgICAgICAgICAgICAgIHwgMTU1ICsr
KysrKysrKysrKysrKysrKysrKysrDQo+IA0KPiBUaGlzIHNob3VsZCBnbyBpbnRvIHhlbi9hcmNo
L3g4Ni9odm0vdm1zaS5jIHRoZXJlJ3MgYWxyZWFkeSB2UENJIE1TSQ0KPiBzcGVjaWZpYyBjb2Rl
IGluIHRoZXJlLg0KT2suDQo+PiB4ZW4vaW5jbHVkZS9hc20teDg2L21zaS5oICAgICAgICAgICAg
ICAgIHwgIDI4IC0tLS0NCj4+IHhlbi9pbmNsdWRlL3hlbi9tc2kuaCAgICAgICAgICAgICAgICAg
ICAgfCAgMjggKysrKw0KPj4geGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgICAgICAgICAgICAgICAg
ICB8ICAyMSArKysNCj4+IDkgZmlsZXMgY2hhbmdlZCwgMjM5IGluc2VydGlvbnMoKyksIDEzNCBk
ZWxldGlvbnMoLSkNCj4+IGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vZHJpdmVycy92cGNpL3g4Nl9t
c2l4LmMNCj4+IA0KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tc2kuYyBiL3hlbi9hcmNo
L3g4Ni9tc2kuYw0KPj4gaW5kZXggNWZlYmMwZWE0Yi4uMmIxMjBmODk3ZiAxMDA2NDQNCj4+IC0t
LSBhL3hlbi9hcmNoL3g4Ni9tc2kuYw0KPj4gKysrIGIveGVuL2FyY2gveDg2L21zaS5jDQo+PiBA
QCAtMjMsNyArMjMsNyBAQA0KPj4gI2luY2x1ZGUgPGFzbS9pby5oPg0KPj4gI2luY2x1ZGUgPGFz
bS9zbXAuaD4NCj4+ICNpbmNsdWRlIDxhc20vZGVzYy5oPg0KPj4gLSNpbmNsdWRlIDxhc20vbXNp
Lmg+DQo+PiArI2luY2x1ZGUgPHhlbi9tc2kuaD4NCj4gDQo+IFlvdSBsaWtlbHkgbmVlZCB0byBt
b3ZlIHRoaXMgdXAgdG8gdGhlIHhlbi8gcHJlZml4ZWQgaW5jbHVkZSBibG9jay4NCk9rLg0KPiAN
Cj4+ICNpbmNsdWRlIDxhc20vZml4bWFwLmg+DQo+PiAjaW5jbHVkZSA8YXNtL3AybS5oPg0KPj4g
I2luY2x1ZGUgPG1hY2hfYXBpYy5oPg0KPj4gZGlmZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0
aHJvdWdoL2FtZC9pb21tdV9pbml0LmMgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t
bXVfaW5pdC5jDQo+PiBpbmRleCA1NTlhNzM0YmRhLi5mYzM4NTk1OWM3IDEwMDY0NA0KPj4gLS0t
IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPj4gKysrIGIveGVu
L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQuYw0KPj4gQEAgLTIwLDYgKzIwLDcg
QEANCj4+ICNpbmNsdWRlIDx4ZW4vYWNwaS5oPg0KPj4gI2luY2x1ZGUgPHhlbi9kZWxheS5oPg0K
Pj4gI2luY2x1ZGUgPHhlbi9rZXloYW5kbGVyLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9tc2kuaD4N
Cj4+IA0KPj4gI2luY2x1ZGUgImlvbW11LmgiDQo+IA0KPiBNaWdodCBiZSBiZXR0ZXIgdG8gcmVw
bGFjZSB0aGUgYXNtL21zaS5oIGluIGluY2x1ZGUgaW4gaW9tbXUuaCB3aXRoDQo+IHhlbi9tc2ku
aCBpbnN0ZWFkIChvciBqdXN0IGFkZCB0aGUgeGVuL21zaS5oIGluY2x1ZGUgaW5zdGVhZCBvZg0K
PiByZXBsYWNlKS4NCg0KT2suDQo+IA0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMv
dnBjaS9NYWtlZmlsZSBiL3hlbi9kcml2ZXJzL3ZwY2kvTWFrZWZpbGUNCj4+IGluZGV4IDFhMTQx
M2I5M2UuLjU0M2MyNjUxOTkgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL01ha2Vm
aWxlDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL01ha2VmaWxlDQo+PiBAQCAtMSwyICsxLDMg
QEANCj4+IG9iai15ICs9IHZwY2kubyBoZWFkZXIubw0KPj4gb2JqLSQoQ09ORklHX0hBU19QQ0lf
TVNJKSArPSBtc2kubyBtc2l4Lm8NCj4+ICtvYmotJChDT05GSUdfWDg2KSArPSB4ODZfbXNpeC5v
DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9tc2kuYyBiL3hlbi9kcml2ZXJzL3Zw
Y2kvbXNpLmMNCj4+IGluZGV4IDU3NTdhN2FlZDIuLjhmYzgyYTliOGQgMTAwNjQ0DQo+PiAtLS0g
YS94ZW4vZHJpdmVycy92cGNpL21zaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL21zaS5j
DQo+PiBAQCAtMTYsMTIgKzE2LDExIEBADQo+PiAgKiBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBw
cm9ncmFtOyBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uDQo+PiAg
Ki8NCj4+IA0KPj4gKyNpbmNsdWRlIDx4ZW4vbXNpLmg+DQo+PiAjaW5jbHVkZSA8eGVuL3NjaGVk
Lmg+DQo+PiAjaW5jbHVkZSA8eGVuL3NvZnRpcnEuaD4NCj4+ICNpbmNsdWRlIDx4ZW4vdnBjaS5o
Pg0KPj4gDQo+PiAtI2luY2x1ZGUgPGFzbS9tc2kuaD4NCj4+IC0NCj4+IHN0YXRpYyB1aW50MzJf
dCBjb250cm9sX3JlYWQoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCBy
ZWcsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQgKmRhdGEpDQo+PiB7DQo+
PiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvdnBjaS9tc2l4LmMgYi94ZW4vZHJpdmVycy92cGNp
L21zaXguYw0KPj4gaW5kZXggODQ2ZjFiOGQ3MC4uN2E5YjAyZjFhNSAxMDA2NDQNCj4+IC0tLSBh
L3hlbi9kcml2ZXJzL3ZwY2kvbXNpeC5jDQo+PiArKysgYi94ZW4vZHJpdmVycy92cGNpL21zaXgu
Yw0KPj4gQEAgLTE3LDE1ICsxNywyNCBAQA0KPj4gICogTGljZW5zZSBhbG9uZyB3aXRoIHRoaXMg
cHJvZ3JhbTsgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+Lg0KPj4g
ICovDQo+PiANCj4+ICsjaW5jbHVkZSA8eGVuL21zaS5oPg0KPj4gI2luY2x1ZGUgPHhlbi9zY2hl
ZC5oPg0KPj4gI2luY2x1ZGUgPHhlbi92cGNpLmg+DQo+PiANCj4+IC0jaW5jbHVkZSA8YXNtL21z
aS5oPg0KPj4gI2luY2x1ZGUgPGFzbS9wMm0uaD4NCj4+IA0KPj4gLSNkZWZpbmUgVk1TSVhfQURE
Ul9JTl9SQU5HRShhZGRyLCB2cGNpLCBucikgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
XA0KPj4gLSAgICAoKGFkZHIpID49IHZtc2l4X3RhYmxlX2FkZHIodnBjaSwgbnIpICYmICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgXA0KPj4gLSAgICAgKGFkZHIpIDwgdm1zaXhfdGFibGVf
YWRkcih2cGNpLCBucikgKyB2bXNpeF90YWJsZV9zaXplKHZwY2ksIG5yKSkNCj4+ICsvKg0KPj4g
KyAqIFRoZSByZXR1cm4gdmFsdWUgaXMgZGlmZmVyZW50IGZvciB0aGUgTU1JTyBoYW5kbGVyIG9u
IEFSTSBhbmQgeDg2DQo+PiArICogYXJjaGl0ZWN0dXJlLiBUbyBtYWtlIHRoZSBjb2RlIGNvbW1v
biBmb3IgYm90aCBhcmNoaXRlY3R1cmVzIGNyZWF0ZQ0KPj4gKyAqIGdlbmVyaWMgcmV0dXJuIGNv
ZGUgd2l0aCBhcmNoaXRlY3R1cmUgZGVwZW5kZW50IHZhbHVlcy4NCj4+ICsgKi8NCj4+ICsjaWZk
ZWYgQ09ORklHX1g4Ng0KPj4gKyNkZWZpbmUgVlBDSV9FTVVMX09LQVkgICAgICBYODZFTVVMX09L
QVkNCj4+ICsjZGVmaW5lIFZQQ0lfRU1VTF9SRVRSWSAgICAgWDg2RU1VTF9SRVRSWQ0KPj4gKyNl
bHNlDQo+PiArI2RlZmluZSBWUENJX0VNVUxfT0tBWSAgICAgIDENCj4+ICsjZGVmaW5lIFZQQ0lf
RU1VTF9SRVRSWSAgICAgVlBDSV9FTVVMX09LQVkNCj4+ICsjZW5kaWYNCj4gDQo+IFNpbmNlIG1z
aXhfe3JlYWQvd3JpdGV9IGFyZSBubyBsb25nZXIgZGlyZWN0bHkgdXNlZCBieSB0aGUgTU1JTw0K
PiBoYW5kbGVycyB5b3UgbWlnaHQgYXMgd2VsbCBqdXN0IHJldHVybiBhbiBlcnJvciBjb2RlIChv
ciBhIGJvb2xlYW4pDQo+IGFuZCBsZXQgdGhlIGNhbGxlciB0cmFuc2xhdGUgdGhhdCBpbnRvIHRo
ZSBwZXItYXJjaCByZXR1cm4gY29kZS4NCg0KT2suDQo+IA0KPj4gDQo+PiBzdGF0aWMgdWludDMy
X3QgY29udHJvbF9yZWFkKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQg
cmVnLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpkYXRhKQ0KPj4gQEAg
LTEzOCwyOSArMTQ3LDYgQEAgc3RhdGljIHZvaWQgY29udHJvbF93cml0ZShjb25zdCBzdHJ1Y3Qg
cGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICAgICAgICAgcGNpX2NvbmZfd3Jp
dGUxNihwZGV2LT5zYmRmLCByZWcsIHZhbCk7DQo+PiB9DQo+PiANCj4+IC1zdGF0aWMgc3RydWN0
IHZwY2lfbXNpeCAqbXNpeF9maW5kKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxv
bmcgYWRkcikNCj4+IC17DQo+PiAtICAgIHN0cnVjdCB2cGNpX21zaXggKm1zaXg7DQo+PiAtDQo+
PiAtICAgIGxpc3RfZm9yX2VhY2hfZW50cnkgKCBtc2l4LCAmZC0+YXJjaC5odm0ubXNpeF90YWJs
ZXMsIG5leHQgKQ0KPj4gLSAgICB7DQo+PiAtICAgICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9iYXIg
KmJhcnMgPSBtc2l4LT5wZGV2LT52cGNpLT5oZWFkZXIuYmFyczsNCj4+IC0gICAgICAgIHVuc2ln
bmVkIGludCBpOw0KPj4gLQ0KPj4gLSAgICAgICAgZm9yICggaSA9IDA7IGkgPCBBUlJBWV9TSVpF
KG1zaXgtPnRhYmxlcyk7IGkrKyApDQo+PiAtICAgICAgICAgICAgaWYgKCBiYXJzW21zaXgtPnRh
Ymxlc1tpXSAmIFBDSV9NU0lYX0JJUk1BU0tdLmVuYWJsZWQgJiYNCj4+IC0gICAgICAgICAgICAg
ICAgIFZNU0lYX0FERFJfSU5fUkFOR0UoYWRkciwgbXNpeC0+cGRldi0+dnBjaSwgaSkgKQ0KPj4g
LSAgICAgICAgICAgICAgICByZXR1cm4gbXNpeDsNCj4+IC0gICAgfQ0KPj4gLQ0KPj4gLSAgICBy
ZXR1cm4gTlVMTDsNCj4+IC19DQo+PiAtDQo+PiAtc3RhdGljIGludCBtc2l4X2FjY2VwdChzdHJ1
Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRyKQ0KPj4gLXsNCj4+IC0gICAgcmV0dXJuICEh
bXNpeF9maW5kKHYtPmRvbWFpbiwgYWRkcik7DQo+PiAtfQ0KPj4gLQ0KPj4gc3RhdGljIGJvb2wg
YWNjZXNzX2FsbG93ZWQoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGxvbmcg
YWRkciwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBsZW4pDQo+
PiB7DQo+PiBAQCAtMTgyLDIxICsxNjgsMTkgQEAgc3RhdGljIHN0cnVjdCB2cGNpX21zaXhfZW50
cnkgKmdldF9lbnRyeShzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4LA0KPj4gICAgIHJldHVybiAmbXNp
eC0+ZW50cmllc1soYWRkciAtIHN0YXJ0KSAvIFBDSV9NU0lYX0VOVFJZX1NJWkVdOw0KPj4gfQ0K
Pj4gDQo+PiAtc3RhdGljIGludCBtc2l4X3JlYWQoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxv
bmcgYWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4+IC0gICAgICAgICAgICAgICAgICAgICB1bnNp
Z25lZCBsb25nICpkYXRhKQ0KPj4gK2ludCBtc2l4X3JlYWQoc3RydWN0IHZwY2lfbXNpeCAqbXNp
eCwgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQgbGVuLA0KPiANCj4gVGhpcyBub3cg
cmVxdWlyZXMgYSB2cGNpXyBwcmVmaXgsIHNpbmNlIGl0J3MgYSBnbG9iYWwgZnVuY3Rpb24uDQo+
IFBsYWluIG1zaXhfe3JlYWQsd3JpdGV9IGlzIHdheSB0byBnZW5lcmljLg0KQWNrLiANCj4gDQo+
PiArICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nICpkYXRhKQ0KPj4gew0KPj4gLSAgICBjb25z
dCBzdHJ1Y3QgZG9tYWluICpkID0gdi0+ZG9tYWluOw0KPj4gLSAgICBzdHJ1Y3QgdnBjaV9tc2l4
ICptc2l4ID0gbXNpeF9maW5kKGQsIGFkZHIpOw0KPj4gICAgIGNvbnN0IHN0cnVjdCB2cGNpX21z
aXhfZW50cnkgKmVudHJ5Ow0KPj4gICAgIHVuc2lnbmVkIGludCBvZmZzZXQ7DQo+PiANCj4+ICAg
ICAqZGF0YSA9IH4wdWw7DQo+PiANCj4+ICAgICBpZiAoICFtc2l4ICkNCj4+IC0gICAgICAgIHJl
dHVybiBYODZFTVVMX1JFVFJZOw0KPj4gKyAgICAgICAgcmV0dXJuIFZQQ0lfRU1VTF9SRVRSWTsN
Cj4+IA0KPj4gICAgIGlmICggIWFjY2Vzc19hbGxvd2VkKG1zaXgtPnBkZXYsIGFkZHIsIGxlbikg
KQ0KPj4gLSAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+ICsgICAgICAgIHJldHVybiBW
UENJX0VNVUxfT0tBWTsNCj4+IA0KPj4gICAgIGlmICggVk1TSVhfQUREUl9JTl9SQU5HRShhZGRy
LCBtc2l4LT5wZGV2LT52cGNpLCBWUENJX01TSVhfUEJBKSApDQo+PiAgICAgew0KPj4gQEAgLTIx
MCwxMSArMTk0LDExIEBAIHN0YXRpYyBpbnQgbXNpeF9yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1bnNp
Z25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGludCBsZW4sDQo+PiAgICAgICAgIHN3aXRjaCAoIGxl
biApDQo+PiAgICAgICAgIHsNCj4+ICAgICAgICAgY2FzZSA0Og0KPj4gLSAgICAgICAgICAgICpk
YXRhID0gcmVhZGwoYWRkcik7DQo+PiArICAgICAgICAgICAgKmRhdGEgPSB2cGNpX2FyY2hfcmVh
ZGwoYWRkcik7DQo+IA0KPiBXaHkgZG8geW91IG5lZWQgYSB2cGNpIHdyYXBwZXIgYXJvdW5kIHRo
ZSByZWFkL3dyaXRlIGhhbmRsZXJzPyBBRkFJQ1QNCj4gYXJtNjQgYWxzbyBoYXMge3JlYWQsd3Jp
dGV9e2wscX0uIEFuZCB5b3UgbGlrZWx5IHdhbnQgdG8gcHJvdGVjdCB0aGUNCj4gNjRiaXQgcmVh
ZCB3aXRoIENPTkZJR182NEJJVCBpZiB0aGlzIGNvZGUgaXMgdG8gYmUgbWFkZSBhdmFpbGFibGUg
dG8NCj4gYXJtMzIuDQoNCkkgbmVlZCB0aGUgd3JhcHBlciBiZWNhdXNlIHtyZWFkLHdyaXRlfXts
LHF9IGZ1bmN0aW9uIGFyZ3VtZW50IGlzIGRpZmZlcmVudCBmb3IgQVJNIGFuZCB4ODYuDQpBUk0g
e3JlYWQsd3JpZX0obCxxfSAgZnVuY3Rpb24gYXJndW1lbnQgaXMgcG9pbnRlciB0byB0aGUgYWRk
cmVzcyB3aGVyZWFzIFg4NiAge3JlYWQsd3JpZX0obCxxfSANCmZ1bmN0aW9uIGFyZ3VtZW50IGlz
IGFkZHJlc3MgaXRzZWxmLg0KDQo+IA0KPj4gICAgICAgICAgICAgYnJlYWs7DQo+PiANCj4+ICAg
ICAgICAgY2FzZSA4Og0KPj4gLSAgICAgICAgICAgICpkYXRhID0gcmVhZHEoYWRkcik7DQo+PiAr
ICAgICAgICAgICAgKmRhdGEgPSB2cGNpX2FyY2hfcmVhZHEoYWRkcik7DQo+PiAgICAgICAgICAg
ICBicmVhazsNCj4+IA0KPj4gICAgICAgICBkZWZhdWx0Og0KPj4gQEAgLTIyMiw3ICsyMDYsNyBA
QCBzdGF0aWMgaW50IG1zaXhfcmVhZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQgbG9uZyBhZGRy
LCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4gICAgICAgICAgICAgYnJlYWs7DQo+PiAgICAgICAgIH0N
Cj4+IA0KPj4gLSAgICAgICAgcmV0dXJuIFg4NkVNVUxfT0tBWTsNCj4+ICsgICAgICAgIHJldHVy
biBWUENJX0VNVUxfT0tBWTsNCj4+ICAgICB9DQo+PiANCj4+ICAgICBzcGluX2xvY2soJm1zaXgt
PnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gQEAgLTI1NiwyMiArMjQwLDIwIEBAIHN0YXRpYyBpbnQg
bXNpeF9yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGlu
dCBsZW4sDQo+PiAgICAgfQ0KPj4gICAgIHNwaW5fdW5sb2NrKCZtc2l4LT5wZGV2LT52cGNpLT5s
b2NrKTsNCj4+IA0KPj4gLSAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPj4gKyAgICByZXR1cm4g
VlBDSV9FTVVMX09LQVk7DQo+PiB9DQo+PiANCj4+IC1zdGF0aWMgaW50IG1zaXhfd3JpdGUoc3Ry
dWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4+IC0g
ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBkYXRhKQ0KPj4gK2ludCBtc2l4X3dy
aXRlKGNvbnN0IHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCB2cGNpX21zaXggKm1zaXgsDQo+PiAr
ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQgbGVuLCB1bnNp
Z25lZCBsb25nIGRhdGEpDQo+PiB7DQo+PiAtICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmQgPSB2
LT5kb21haW47DQo+PiAtICAgIHN0cnVjdCB2cGNpX21zaXggKm1zaXggPSBtc2l4X2ZpbmQoZCwg
YWRkcik7DQo+PiAgICAgc3RydWN0IHZwY2lfbXNpeF9lbnRyeSAqZW50cnk7DQo+PiAgICAgdW5z
aWduZWQgaW50IG9mZnNldDsNCj4+IA0KPj4gICAgIGlmICggIW1zaXggKQ0KPj4gLSAgICAgICAg
cmV0dXJuIFg4NkVNVUxfUkVUUlk7DQo+PiArICAgICAgICByZXR1cm4gVlBDSV9FTVVMX1JFVFJZ
Ow0KPj4gDQo+PiAgICAgaWYgKCAhYWNjZXNzX2FsbG93ZWQobXNpeC0+cGRldiwgYWRkciwgbGVu
KSApDQo+PiAtICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPj4gKyAgICAgICAgcmV0dXJu
IFZQQ0lfRU1VTF9PS0FZOw0KPj4gDQo+PiAgICAgaWYgKCBWTVNJWF9BRERSX0lOX1JBTkdFKGFk
ZHIsIG1zaXgtPnBkZXYtPnZwY2ksIFZQQ0lfTVNJWF9QQkEpICkNCj4+ICAgICB7DQo+PiBAQCAt
MjgxLDExICsyNjMsMTEgQEAgc3RhdGljIGludCBtc2l4X3dyaXRlKHN0cnVjdCB2Y3B1ICp2LCB1
bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGludCBsZW4sDQo+PiAgICAgICAgICAgICBzd2l0
Y2ggKCBsZW4gKQ0KPj4gICAgICAgICAgICAgew0KPj4gICAgICAgICAgICAgY2FzZSA0Og0KPj4g
LSAgICAgICAgICAgICAgICB3cml0ZWwoZGF0YSwgYWRkcik7DQo+PiArICAgICAgICAgICAgICAg
IHZwY2lfYXJjaF93cml0ZWwoZGF0YSwgYWRkcik7DQo+PiAgICAgICAgICAgICAgICAgYnJlYWs7
DQo+PiANCj4+ICAgICAgICAgICAgIGNhc2UgODoNCj4+IC0gICAgICAgICAgICAgICAgd3JpdGVx
KGRhdGEsIGFkZHIpOw0KPj4gKyAgICAgICAgICAgICAgICB2cGNpX2FyY2hfd3JpdGVxKGRhdGEs
IGFkZHIpOw0KPj4gICAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gDQo+PiAgICAgICAgICAgICBk
ZWZhdWx0Og0KPj4gQEAgLTI5NCw3ICsyNzYsNyBAQCBzdGF0aWMgaW50IG1zaXhfd3JpdGUoc3Ry
dWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4+ICAg
ICAgICAgICAgIH0NCj4+ICAgICAgICAgfQ0KPj4gDQo+PiAtICAgICAgICByZXR1cm4gWDg2RU1V
TF9PS0FZOw0KPj4gKyAgICAgICAgcmV0dXJuIFZQQ0lfRU1VTF9PS0FZOw0KPj4gICAgIH0NCj4+
IA0KPj4gICAgIHNwaW5fbG9jaygmbXNpeC0+cGRldi0+dnBjaS0+bG9jayk7DQo+PiBAQCAtMzcy
LDYwICszNTQsNyBAQCBzdGF0aWMgaW50IG1zaXhfd3JpdGUoc3RydWN0IHZjcHUgKnYsIHVuc2ln
bmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGxlbiwNCj4+ICAgICB9DQo+PiAgICAgc3Bpbl91
bmxvY2soJm1zaXgtPnBkZXYtPnZwY2ktPmxvY2spOw0KPj4gDQo+PiAtICAgIHJldHVybiBYODZF
TVVMX09LQVk7DQo+PiAtfQ0KPj4gLQ0KPj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgaHZtX21taW9f
b3BzIHZwY2lfbXNpeF90YWJsZV9vcHMgPSB7DQo+PiAtICAgIC5jaGVjayA9IG1zaXhfYWNjZXB0
LA0KPj4gLSAgICAucmVhZCA9IG1zaXhfcmVhZCwNCj4+IC0gICAgLndyaXRlID0gbXNpeF93cml0
ZSwNCj4+IC19Ow0KPj4gLQ0KPj4gLWludCB2cGNpX21ha2VfbXNpeF9ob2xlKGNvbnN0IHN0cnVj
dCBwY2lfZGV2ICpwZGV2KQ0KPj4gLXsNCj4+IC0gICAgc3RydWN0IGRvbWFpbiAqZCA9IHBkZXYt
PmRvbWFpbjsNCj4+IC0gICAgdW5zaWduZWQgaW50IGk7DQo+PiAtDQo+PiAtICAgIGlmICggIXBk
ZXYtPnZwY2ktPm1zaXggKQ0KPj4gLSAgICAgICAgcmV0dXJuIDA7DQo+PiAtDQo+PiAtICAgIC8q
IE1ha2Ugc3VyZSB0aGVyZSdzIGEgaG9sZSBmb3IgdGhlIE1TSVggdGFibGUvUEJBIGluIHRoZSBw
Mm0uICovDQo+PiAtICAgIGZvciAoIGkgPSAwOyBpIDwgQVJSQVlfU0laRShwZGV2LT52cGNpLT5t
c2l4LT50YWJsZXMpOyBpKysgKQ0KPj4gLSAgICB7DQo+PiAtICAgICAgICB1bnNpZ25lZCBsb25n
IHN0YXJ0ID0gUEZOX0RPV04odm1zaXhfdGFibGVfYWRkcihwZGV2LT52cGNpLCBpKSk7DQo+PiAt
ICAgICAgICB1bnNpZ25lZCBsb25nIGVuZCA9IFBGTl9ET1dOKHZtc2l4X3RhYmxlX2FkZHIocGRl
di0+dnBjaSwgaSkgKw0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2
bXNpeF90YWJsZV9zaXplKHBkZXYtPnZwY2ksIGkpIC0gMSk7DQo+PiAtDQo+PiAtICAgICAgICBm
b3IgKCA7IHN0YXJ0IDw9IGVuZDsgc3RhcnQrKyApDQo+PiAtICAgICAgICB7DQo+PiAtICAgICAg
ICAgICAgcDJtX3R5cGVfdCB0Ow0KPj4gLSAgICAgICAgICAgIG1mbl90IG1mbiA9IGdldF9nZm5f
cXVlcnkoZCwgc3RhcnQsICZ0KTsNCj4+IC0NCj4+IC0gICAgICAgICAgICBzd2l0Y2ggKCB0ICkN
Cj4+IC0gICAgICAgICAgICB7DQo+PiAtICAgICAgICAgICAgY2FzZSBwMm1fbW1pb19kbToNCj4+
IC0gICAgICAgICAgICBjYXNlIHAybV9pbnZhbGlkOg0KPj4gLSAgICAgICAgICAgICAgICBicmVh
azsNCj4+IC0gICAgICAgICAgICBjYXNlIHAybV9tbWlvX2RpcmVjdDoNCj4+IC0gICAgICAgICAg
ICAgICAgaWYgKCBtZm5feChtZm4pID09IHN0YXJ0ICkNCj4+IC0gICAgICAgICAgICAgICAgew0K
Pj4gLSAgICAgICAgICAgICAgICAgICAgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KGQsIHN0YXJ0
KTsNCj4+IC0gICAgICAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gLSAgICAgICAgICAgICAgICB9
DQo+PiAtICAgICAgICAgICAgICAgIC8qIGZhbGx0aHJvdWdoLiAqLw0KPj4gLSAgICAgICAgICAg
IGRlZmF1bHQ6DQo+PiAtICAgICAgICAgICAgICAgIHB1dF9nZm4oZCwgc3RhcnQpOw0KPj4gLSAg
ICAgICAgICAgICAgICBncHJpbnRrKFhFTkxPR19XQVJOSU5HLA0KPj4gLSAgICAgICAgICAgICAg
ICAgICAgICAgICIlcHA6IGV4aXN0aW5nIG1hcHBpbmcgKG1mbjogJSIgUFJJX21mbg0KPj4gLSAg
ICAgICAgICAgICAgICAgICAgICAgICJ0eXBlOiAlZCkgYXQgJSNseCBjbG9iYmVycyBNU0lYIE1N
SU8gYXJlYVxuIiwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAmcGRldi0+c2JkZiwgbWZu
X3gobWZuKSwgdCwgc3RhcnQpOw0KPj4gLSAgICAgICAgICAgICAgICByZXR1cm4gLUVFWElTVDsN
Cj4+IC0gICAgICAgICAgICB9DQo+PiAtICAgICAgICAgICAgcHV0X2dmbihkLCBzdGFydCk7DQo+
PiAtICAgICAgICB9DQo+PiAtICAgIH0NCj4+IC0NCj4+IC0gICAgcmV0dXJuIDA7DQo+PiArICAg
IHJldHVybiBWUENJX0VNVUxfT0tBWTsNCj4+IH0NCj4+IA0KPj4gc3RhdGljIGludCBpbml0X21z
aXgoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiBAQCAtNDcyLDExICs0MDEsMTAgQEAgc3RhdGlj
IGludCBpbml0X21zaXgoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgICAgICAgIHZwY2lfbXNp
eF9hcmNoX2luaXRfZW50cnkoJm1zaXgtPmVudHJpZXNbaV0pOw0KPj4gICAgIH0NCj4+IA0KPj4g
LSAgICBpZiAoIGxpc3RfZW1wdHkoJmQtPmFyY2guaHZtLm1zaXhfdGFibGVzKSApDQo+PiAtICAg
ICAgICByZWdpc3Rlcl9tbWlvX2hhbmRsZXIoZCwgJnZwY2lfbXNpeF90YWJsZV9vcHMpOw0KPj4g
KyAgICByZWdpc3Rlcl9tc2l4X21taW9faGFuZGxlcihkKTsNCj4+ICsgICAgdnBjaV9tc2l4X2Fk
ZF90b19tc2l4X3RhYmxlKG1zaXgsIGQpOw0KPj4gDQo+PiAgICAgcGRldi0+dnBjaS0+bXNpeCA9
IG1zaXg7DQo+PiAtICAgIGxpc3RfYWRkKCZtc2l4LT5uZXh0LCAmZC0+YXJjaC5odm0ubXNpeF90
YWJsZXMpOw0KPiANCj4gWW91IGNvdWxkIGxpa2VseSBkbyB0aGUgcmVnaXN0ZXJpbmcgb2YgdGhl
IGhhbmRsZXIgYW5kIHRoZSBhZGRpdGlvbiBvZg0KPiB0aGUgdGFibGUgaW4gdGhlIHNhbWUgaGFu
ZGxlcjogdnBjaV9tc2l4X2FyY2hfcmVnaXN0ZXIgb3Igc2ltaWxhci4NCg0KT2suDQoNClJlZ2Fy
ZHMsDQpSYWh1bA0KPiANCj4gVGhhbmtzLCBSb2dlci4NCg0K


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 10:28:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 10:28:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247850.427406 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxo04-0005aB-GR; Thu, 16 Dec 2021 10:28:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247850.427406; Thu, 16 Dec 2021 10:28:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxo04-0005a4-DH; Thu, 16 Dec 2021 10:28:36 +0000
Received: by outflank-mailman (input) for mailman id 247850;
 Thu, 16 Dec 2021 10:28:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HYuw=RB=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mxo03-0005Zy-FO
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 10:28:35 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0602.outbound.protection.outlook.com
 [2a01:111:f400:fe07::602])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb4ad5f7-5e5a-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 11:28:33 +0100 (CET)
Received: from AM5PR0301CA0001.eurprd03.prod.outlook.com
 (2603:10a6:206:14::14) by AM6PR08MB5254.eurprd08.prod.outlook.com
 (2603:10a6:20b:d6::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Thu, 16 Dec
 2021 10:28:31 +0000
Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:14:cafe::b7) by AM5PR0301CA0001.outlook.office365.com
 (2603:10a6:206:14::14) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Thu, 16 Dec 2021 10:28:31 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4778.12 via Frontend Transport; Thu, 16 Dec 2021 10:28:30 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Thu, 16 Dec 2021 10:28:30 +0000
Received: from 9865fd34e82f.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 373FB4C4-00B2-4B0D-A488-D6F5C4CFF43E.1; 
 Thu, 16 Dec 2021 10:28:07 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9865fd34e82f.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 16 Dec 2021 10:28:07 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com (2603:10a6:20b:307::13)
 by AM0PR08MB4564.eurprd08.prod.outlook.com (2603:10a6:208:12f::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 10:28:05 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13]) by AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13%6]) with mapi id 15.20.4801.015; Thu, 16 Dec 2021
 10:28:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb4ad5f7-5e5a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XeOHfYJ8kW8bVJULprGG952kbFMUNaCYl+nA7VT8RTE=;
 b=yTIXz7B0G+GbcZM70GJ1DpogsmKePAkioGAQpZCidyhTtSFc7YzJmWRNjBo+CBJjZS3++CG4iaMQ2SEx0ClEt5FUPB17xc9Q/ueWmUfdEwFSQH7WoXr83ZnLGqXy4XExLqk8pKtKwdYOkL3cZZeLDACwc3dVX9XlNvqQlOiwZqg=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: 80009d3dd59d6319
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KsWfjVMsMJJdY66Tfl+CbgCGgkn8QNAZhERsshIeK+P9prayxB0EN4mb9fuShltPFsqTVpd7EBOJd1sG6kduRsdsz46pTG1NWfPvGdQMvkYdSCrpIFAH6KbBQzPgPzQisI0GqoIXDrYfV7bbOWZcw6vEMXgDUZBkTFK69V2ZRr+36EV54PL7JzjD14u4hNRDt/O810X0P+9heu0yNJ4yl2djbWjsPs0Y1pmhfBw/IY/UCEtBmea9O47pz6RDyUGCtpHRlLNK+xTw1TcrxknHddinavsDUyYabeG7gEkgof55OWbYExkjipbLNMtvA+cU9WD0K7Pi3ZEA4Kkb9Um7tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XeOHfYJ8kW8bVJULprGG952kbFMUNaCYl+nA7VT8RTE=;
 b=AptksQgobJ6WK1qXkrUlOmlHV4TwURT6p/xmN1U8NQnLOIPLJfNbSFpYoCkf2lELEEX4ZFyDwEHnrypurWEt3OUI2x9LIHVPxd0A6VqeVPp4J89yOmfuAKzNEdEJNWjUH+cc2tanTiTn3rTuvqbgryVp0iH6WL5smnLsZkloSiyeKDT2l5iuQZ2V/zMenAQm8ftWvZMv0NM37pjUHua5FaSWFMoPB0LloWxMLDeYGBK2nKiDDtIrf2UAvlivwjVJkLMr+eS7TVHx1rofLnYSFXxJMUYDYMSiNEn9wsL0qUq3lbUqZmVTxp+xRTi9ccYcjHzoUb3GOVW69dMguNFYCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XeOHfYJ8kW8bVJULprGG952kbFMUNaCYl+nA7VT8RTE=;
 b=yTIXz7B0G+GbcZM70GJ1DpogsmKePAkioGAQpZCidyhTtSFc7YzJmWRNjBo+CBJjZS3++CG4iaMQ2SEx0ClEt5FUPB17xc9Q/ueWmUfdEwFSQH7WoXr83ZnLGqXy4XExLqk8pKtKwdYOkL3cZZeLDACwc3dVX9XlNvqQlOiwZqg=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bertrand Marquis <Bertrand.Marquis@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, =?iso-8859-1?Q?Roger_Pau_Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Topic: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Index: AQHX8NfN625eD/1es0eaHkpOvTmQ3KwyCGqAgALlHQA=
Date: Thu, 16 Dec 2021 10:28:05 +0000
Message-ID: <E3B171DA-E199-435D-8582-22A155E5C16F@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <90c66d68-4939-f203-de2a-caebd0d6fc6c@suse.com>
In-Reply-To: <90c66d68-4939-f203-de2a-caebd0d6fc6c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 30fc4960-ef97-46f4-a501-08d9c07ece09
x-ms-traffictypediagnostic:
	AM0PR08MB4564:EE_|AM5EUR03FT009:EE_|AM6PR08MB5254:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB5254F8CF33AC1B6DF5AA17B7FC779@AM6PR08MB5254.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 XfnzUdhryxq8jBZmelhInlFzMUDdyn9ElpZPxEoBRGWLNh2BHBAcd5YvCmLUSu5TUvc11mdorBrjjmlV/J+oBPyEqYkgElYwc/j/jUxlwAqBwqaC7rXDmVFwaZ+ggxy628xVE3hNXTUzdmwWbf5F1OyBqJMr3RlJw6uYgW/QaUk9qTCADQ4v8BZV93XaxAGLwC4bci9f8pmwlFa+9mDPos51TkpjTiSrWYRmvtxSV2cEBrUUf0Mw7D8oGucBtnBEbD0gJZ2deqajG1oVgvb+HpZ2X7zAftFasv8B1BaUHBr5nIIT4yB7hqWGn7C1lWh+ZJHRjLg3dzI7R6tiIBv+u/4Ya1+6DrC3K8SE0r9bQ1vRpe0hozrP86QeDujJjHliw9si0Zy/QwtqyfWLK0xErUOiQrdtxf/mpQ2R3XPsOO5aTILAeiItp5W6IeFCbIwvMhIB2s9lwhyHDHu/ysYM1kgEywfK5vxelnp3Cyws/MOR9Bhq7ikKGcESafnWR/EW45HVwKv/jG/dshjXzVIIMfSzy4THg5E4iFr3zV8Fbqvs1hNXYgU6JrdRX/BQASNh5JhrbPRBU7ALNlmJ1Zy0vfwaIJX/z89yqCrL+rakI2UajlYnLiRyjFqTyVNs+fzKxsyTbiAf90UKCbsBXU93s3JatKWibvkvTfG0FCo4RTXcURsvD3jX6FxY7mkdsnwzta7hhQu0L+qQoLDKyULy2R6oUd+isoNN9dIA7+sXte7lsHJzhS9464qTXL9yOSV5JFY+GFAIooKUMzj+SAfKpYbdapRIFFdqyv6jwRbsQaoaxnqu60v3d5AtRWp4je4gQdsOK/oKsIkhHUFn8weNMQ==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB6914.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(33656002)(66556008)(4326008)(122000001)(66446008)(64756008)(6512007)(6506007)(86362001)(53546011)(2616005)(36756003)(38070700005)(6486002)(186003)(8936002)(26005)(2906002)(6916009)(38100700002)(316002)(76116006)(91956017)(66946007)(83380400001)(8676002)(66476007)(71200400001)(54906003)(508600001)(2004002)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <D317FB7F9329E74B9AD75D69C3E6B448@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4564
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	ff6e5d00-0881-4098-0e29-08d9c07ebeeb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	D4CaxvASQb6d4ro/IKZfAYKYCvfxubU/KFWkI/ry0pD6BA7I+CGRF7AfZKKe49ghiu6B5tGTNtD5KXSRgve7Gm83ypFUon4sbK/JrHcgPJRJCxYJkG7kvX8tfNJvDNb1FU+GGe5CctNLcabYQPC+Tat+xSurt6qlRo8c16qv9omLtuXtHUqRJdr+a/u111o3S2StbyVoZrYLAyWqgnRThLM5vNxpaiOJKsfMvE/d949mDHTwIYCvuy9D2NDIJfbm+b1dzpC1pkhA0TLfTR1wxpoZjfstcZFgz/Z7kqB+WG74NwRh5FLBRqLpzg2biog0FtNKhST2jLiAtyhnDJc2fd73av+APL+GPS056rr4x0YC+HijEdqbElDVC8cF7QVXG/icMetrFA3LZsNfN1XyFae1Ae/qDV6sODWse3tNywVJ1pDy/jcrAlRvM41uoX4StpNp9NEaVo5bfD/07my83Koz7w4zw+NxvkpEHKAMMJ8hdHym9PdzPHg/By+GWoCeD5LcbL9WKGdW/jQSFeRnUZ8/CTHhAaKcGlCjMQE0vsmY9tHXXfbu3NJnrQzMgZRxxN0pFn14/GJDw8KRDAcW2j9O/3Hp+tQ5rYPJ+MXEKQFD+ujGvTqp6/gL6OqDxXGSC6qJByZXPq+T8WvKYuYq2ZItnhxRgfvL7Iv56DCe59HvLrqtQL1QqbruycHi5ctWfZfmP1snfGhzbh1bInNhKiS0act4jSSf6QHFnHdtqNUo3eECex7R8RcS9mUt2mXF+vPCeytKpRe75jiZWZb5akOwEic5CWopgkbenLIXhsoCZxGirs8GfQckyRYXj1y5hqzprIxx4c7GveT3VnWEF5R4lhWGwxE2jyJyW70N86p5vUoJfjCnFOdyOo6hnLb+86EPKajNwr9wtifvrN+CVQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(8936002)(47076005)(40460700001)(33656002)(5660300002)(356005)(54906003)(63350400001)(63370400001)(6862004)(6512007)(316002)(36860700001)(336012)(81166007)(86362001)(508600001)(4326008)(26005)(8676002)(70586007)(6506007)(53546011)(82310400004)(70206006)(2616005)(36756003)(186003)(2906002)(6486002)(83380400001)(2004002)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 10:28:30.4005
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 30fc4960-ef97-46f4-a501-08d9c07ece09
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5254

Hi Jan,

Thanks for reviewing the code.

> On 14 Dec 2021, at 2:15 pm, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> On 14.12.2021 11:45, Rahul Singh wrote:
>> --- a/xen/drivers/vpci/msix.c
>> +++ b/xen/drivers/vpci/msix.c
>> @@ -17,15 +17,24 @@
>>  * License along with this program; If not, see <http://www.gnu.org/lice=
nses/>.
>>  */
>>=20
>> +#include <xen/msi.h>
>> #include <xen/sched.h>
>> #include <xen/vpci.h>
>>=20
>> -#include <asm/msi.h>
>> #include <asm/p2m.h>
>>=20
>> -#define VMSIX_ADDR_IN_RANGE(addr, vpci, nr)                            =
   \
>> -    ((addr) >=3D vmsix_table_addr(vpci, nr) &&                         =
     \
>> -     (addr) < vmsix_table_addr(vpci, nr) + vmsix_table_size(vpci, nr))
>> +/*
>> + * The return value is different for the MMIO handler on ARM and x86
>> + * architecture. To make the code common for both architectures create
>> + * generic return code with architecture dependent values.
>> + */
>> +#ifdef CONFIG_X86
>> +#define VPCI_EMUL_OKAY      X86EMUL_OKAY
>> +#define VPCI_EMUL_RETRY     X86EMUL_RETRY
>> +#else
>> +#define VPCI_EMUL_OKAY      1
>> +#define VPCI_EMUL_RETRY     VPCI_EMUL_OKAY
>> +#endif
>=20
> In addition to what Roger has said, at the example of the above I think
> you want to split this change. The change in return value naming could
> likely quite well be a separate thing. And then it'll be easier to see
> which other suggested changes are really movement of x86-specific stuff
> (looking over it I wasn't convinced everything you move really is).
>=20

Ack. I will split the changes in next version.

>> @@ -472,11 +401,10 @@ static int init_msix(struct pci_dev *pdev)
>>         vpci_msix_arch_init_entry(&msix->entries[i]);
>>     }
>>=20
>> -    if ( list_empty(&d->arch.hvm.msix_tables) )
>> -        register_mmio_handler(d, &vpci_msix_table_ops);
>> +    register_msix_mmio_handler(d);
>> +    vpci_msix_add_to_msix_table(msix, d);
>>=20
>>     pdev->vpci->msix =3D msix;
>> -    list_add(&msix->next, &d->arch.hvm.msix_tables);
>>=20
>>     return 0;
>=20
> May I ask that you don't alter the order of operations? I take it that
> vpci_msix_add_to_msix_table() is the replacement of the list_add().
> That should occur only after pdev->vcpi has been updated. I could in
> fact imagine that in cases like this one for Arm barriers may need
> adding.

Yes I will not change the order I will fix this in next version.
>=20
>> --- /dev/null
>> +++ b/xen/drivers/vpci/x86_msix.c
>> @@ -0,0 +1,155 @@
>> +/*
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms and conditions of the GNU General Public
>> + * License, version 2, as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> + * General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public
>> + * License along with this program; If not, see <http://www.gnu.org/lic=
enses/>.
>> + */
>> +
>> +#include <xen/sched.h>
>> +#include <xen/vpci.h>
>> +
>> +#include <asm/msi.h>
>> +#include <asm/p2m.h>
>> +
>> +u32 vpci_arch_readl(unsigned long addr)
>=20
> Nit: No new uses of u<N> please; these are being phased out, with
> uint<N>_t being the intended types.

Ack .
>=20
>> +{
>> +    return readl(addr);
>> +}
>> +
>> +u64 vpci_arch_readq(unsigned long addr)
>> +{
>> +    return readq(addr);
>> +}
>> +
>> +void vpci_arch_writel(u32 data, unsigned long addr)
>> +{
>> +    writel(data, addr);
>> +}
>> +
>> +void vpci_arch_writeq(u64 data, unsigned long addr)
>> +{
>> +    writeq(data, addr);
>> +}
>=20
> Functions like these (if, as Roger said, they need abstracting in the
> first place) or ...
>=20
>> +void register_msix_mmio_handler(struct domain *d)
>> +{
>> +    if ( list_empty(&d->arch.hvm.msix_tables) )
>> +        register_mmio_handler(d, &vpci_msix_table_ops);
>> +}
>> +
>> +void vpci_msix_add_to_msix_table(struct vpci_msix *msix,
>> +                                 struct domain *d)
>> +{
>> +    list_add(&msix->next, &d->arch.hvm.msix_tables);
>> +}
>=20
> ... these would imo better be inline helpers.

Ack.
>=20
>> --- a/xen/include/asm-x86/msi.h
>> +++ b/xen/include/asm-x86/msi.h
>> @@ -148,34 +148,6 @@ int msi_free_irq(struct msi_desc *entry);
>>  */
>> #define NR_HP_RESERVED_VECTORS 	20
>>=20
>> -#define msi_control_reg(base)		(base + PCI_MSI_FLAGS)
>> -#define msi_lower_address_reg(base)	(base + PCI_MSI_ADDRESS_LO)
>> -#define msi_upper_address_reg(base)	(base + PCI_MSI_ADDRESS_HI)
>> -#define msi_data_reg(base, is64bit)	\
>> -	( (is64bit =3D=3D 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
>> -#define msi_mask_bits_reg(base, is64bit) \
>> -	( (is64bit =3D=3D 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4=
)
>> -#define msi_pending_bits_reg(base, is64bit) \
>> -	((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
>> -#define msi_disable(control)		control &=3D ~PCI_MSI_FLAGS_ENABLE
>> -#define multi_msi_capable(control) \
>> -	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
>> -#define multi_msi_enable(control, num) \
>> -	control |=3D (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
>> -#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))
>> -#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBI=
T))
>> -#define msi_enable(control, num) multi_msi_enable(control, num); \
>> -	control |=3D PCI_MSI_FLAGS_ENABLE
>> -
>> -#define msix_control_reg(base)		(base + PCI_MSIX_FLAGS)
>> -#define msix_table_offset_reg(base)	(base + PCI_MSIX_TABLE)
>> -#define msix_pba_offset_reg(base)	(base + PCI_MSIX_PBA)
>> -#define msix_enable(control)	 	control |=3D PCI_MSIX_FLAGS_ENABLE
>> -#define msix_disable(control)	 	control &=3D ~PCI_MSIX_FLAGS_ENABLE
>> -#define msix_table_size(control) 	((control & PCI_MSIX_FLAGS_QSIZE)+1)
>> -#define msix_unmask(address)	 	(address & ~PCI_MSIX_VECTOR_BITMASK)
>> -#define msix_mask(address)		(address | PCI_MSIX_VECTOR_BITMASK)
>> -
>> /*
>>  * MSI Defined Data Structures
>>  */
>> diff --git a/xen/include/xen/msi.h b/xen/include/xen/msi.h
>> index c903d0050c..1c22c9a4a7 100644
>> --- a/xen/include/xen/msi.h
>> +++ b/xen/include/xen/msi.h
>> @@ -3,6 +3,34 @@
>>=20
>> #include <xen/pci.h>
>>=20
>> +#define msi_control_reg(base)       (base + PCI_MSI_FLAGS)
>> +#define msi_lower_address_reg(base) (base + PCI_MSI_ADDRESS_LO)
>> +#define msi_upper_address_reg(base) (base + PCI_MSI_ADDRESS_HI)
>> +#define msi_data_reg(base, is64bit) \
>> +	( (is64bit =3D=3D 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
>=20
> As you move this code, please tidy is style-wise. For the construct
> here, for example this would mean
>=20
> #define msi_data_reg(base, is64bit) \
>    ((is64bit) ? (base) + PCI_MSI_DATA_64 : (base) + PCI_MSI_DATA_32)
>=20
> or perhaps even
>=20
> #define msi_data_reg(base, is64bit) \
>    ((base) + ((is64bit) ? PCI_MSI_DATA_64 : PCI_MSI_DATA_32))
>=20
> Further items would want similar adjustments.

Ok . Let me try to fix this in next version

Regards,
Rahul
>=20
> Jan
>=20



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 10:39:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 10:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247854.427417 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoAd-0007OR-In; Thu, 16 Dec 2021 10:39:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247854.427417; Thu, 16 Dec 2021 10:39:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoAd-0007OK-Ei; Thu, 16 Dec 2021 10:39:31 +0000
Received: by outflank-mailman (input) for mailman id 247854;
 Thu, 16 Dec 2021 10:39:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CQEQ=RB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxoAb-0007OE-Mm
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 10:39:29 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 721daaf8-5e5c-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 11:39:28 +0100 (CET)
Received: by mail-lj1-x235.google.com with SMTP id k23so37876450lje.1
 for <xen-devel@lists.xenproject.org>; Thu, 16 Dec 2021 02:39:28 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id v19sm1057662ljg.8.2021.12.16.02.39.27
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 16 Dec 2021 02:39:27 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 721daaf8-5e5c-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=S9gPEvO2N0R3SennJHgX65rGApE7aq/6AsLKv+zK+iQ=;
        b=akD4OTh/XVYX5GqjKC1KRmMihJOhlZMlHxrQQkxQLd7CEK3GH2hPfkGhHPQg+cnkuM
         YBnUBXK0Qomf2avCzZ33YlgHbgCjVUtAsn36PdSFMLPf7Z91UQmqOvJo8vb1Cjk2Yzdk
         M8dFY5VU/hI5pBWu7YnTAopyVJ0y4ahQ48H3r5kiJDst+mgMv9ZkI9hgTt3GhmDcOGdY
         IXS2DNDXfBmYYSSljGTiaXWPyduiorpAMO4pgij6YJcUGeihSiKuICv0/2ot3eT/9jc1
         OXfiyJk6RFBf2eJ/92Bim/W2ON+n0ct8jNIj5Nk6cmkmy6xq1MRfYyfN8rrAjDrVCkg5
         P4/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=S9gPEvO2N0R3SennJHgX65rGApE7aq/6AsLKv+zK+iQ=;
        b=fdgF6JjJCgjym2FmaBQG9oSvJy7/9Konvwdsrs7NDNkWPvoHd5PdRC3AlG18P1oyd3
         Ltz8f4bCVsH4OvV/b7T4Ak69GudNU0yG+a5ocB+/F29I2vWsZyxNNPP+6MwJJCTbFSjm
         HkEO4Xv2VlRKvl5ztQ3Upb3H58o6dHmWJupi54cn4q1BZ4wVIG4RPwoRAkeLnq85VKrL
         BPskJoV355yU3cmym3ARiE/2uVqrtUUS/gsWfVXy9yuhn4ixBh9Yg/DRdeQb3ARCBjMG
         XqelX6K/oTULooI2a5JSKYOP7YOjGfRkdFCI/AK5o8XfCBb6w4AH4dGp8sSQ9o9W5Ayd
         tLVA==
X-Gm-Message-State: AOAM532T0qRMdlWvw7nyl01Th172swlEoRADgJ79RbmqlTHM/egm2H0Z
	R08wWnV7+MN0no9RxTXI95c=
X-Google-Smtp-Source: ABdhPJxGWr1dMPBdXJtO5Peo58fCIy0G/TQd4vKlsz2PjOw6pZ9igzzjIkUZ0bblTF9g9+57iAshzg==
X-Received: by 2002:a2e:948:: with SMTP id 69mr14863025ljj.82.1639651168180;
        Thu, 16 Dec 2021 02:39:28 -0800 (PST)
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
 <d0c860ea-2134-d8dd-9bf8-87cd9c1a9305@gmail.com>
 <ae7ba1bc-44cf-9b7f-87e7-f962807ab508@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <890b2930-04d2-6024-30bb-bb6a3c752cf4@gmail.com>
Date: Thu, 16 Dec 2021 12:39:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ae7ba1bc-44cf-9b7f-87e7-f962807ab508@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 16.12.21 10:49, Jan Beulich wrote:

Hi Jan


> On 15.12.2021 16:28, Oleksandr wrote:
>> On 24.09.21 12:53, Jan Beulich wrote:
>>> Having a separate flush-all hook has always been puzzling me some. We
>>> will want to be able to force a full flush via accumulated flush flags
>>> from the map/unmap functions. Introduce a respective new flag and fold
>>> all flush handling to use the single remaining hook.
>>>
>>> Note that because of the respective comments in SMMU and IPMMU-VMSA
>>> code, I've folded the two prior hook functions into one.
>> Changes to IPMMU-VMSA lgtm, for SMMU-v2 I think the same.
> Thanks; I wonder whether I may transform this into some kind of tag.


[IPMMU-VMSA and SMMU-V2 bits]

Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>


>
> Jan
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:00:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:00:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247859.427428 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoUp-0002PP-9N; Thu, 16 Dec 2021 11:00:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247859.427428; Thu, 16 Dec 2021 11:00:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoUp-0002PI-5t; Thu, 16 Dec 2021 11:00:23 +0000
Received: by outflank-mailman (input) for mailman id 247859;
 Thu, 16 Dec 2021 11:00:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxoUn-0002PC-JQ
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:00:21 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b12132c-5e5f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:00:19 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43862)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxoUk-000aVM-gZ (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:00:18 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 01E271FA47;
 Thu, 16 Dec 2021 11:00:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b12132c-5e5f-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <cb9bea36-9feb-dbc7-ce36-38fd42792f11@srcf.net>
Date: Thu, 16 Dec 2021 11:00:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should
 be UC"
Content-Language: en-GB
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
 <YbsMwIYFULP5sXQP@Air-de-Roger>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <YbsMwIYFULP5sXQP@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 09:54, Roger Pau Monné wrote:
> On Tue, Dec 14, 2021 at 09:21:22AM +0100, Jan Beulich wrote:
>> This reverts commit c22bd567ce22f6ad9bd93318ad0d7fd1c2eadb0d.
>>
>> While its description is correct from an abstract or real hardware pov,
>> the range is special inside HVM guests. The range being UC in particular
>> gets in the way of OVMF, which places itself at [FFE00000,FFFFFFFF].
> I would assume this range to be unpopulated? Does hvmloader populate
> it in order to place ovmf?

It's generally not unpopulated.  The video RAM lives there until the VGA
BAR is reprogrammed.

The reason OVMF places itself there is because it is where the real SPI
ROM is mapped in address space on a real system.

>> While this is benign to epte_get_entry_emt() as long as the IOMMU isn't
>> enabled for a guest, it becomes a very noticable problem otherwise: It
>> takes about half a minute for OVMF to decompress itself into its
>> designated address range.
>>
>> And even beyond OVMF there's no reason to have e.g. the ACPI memory
>> range marked UC.
>>
>> Fixes: c22bd567ce22 ("hvmloader: PA range 0xfc000000-0xffffffff should be UC")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

~Andrew




From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:02:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:02:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247864.427439 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoWf-00031E-Kz; Thu, 16 Dec 2021 11:02:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247864.427439; Thu, 16 Dec 2021 11:02:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoWf-000317-Hs; Thu, 16 Dec 2021 11:02:17 +0000
Received: by outflank-mailman (input) for mailman id 247864;
 Thu, 16 Dec 2021 11:02:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0Qa=RB=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxoWd-000311-T0
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:02:16 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9e5c35ac-5e5f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:02:13 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9e5c35ac-5e5f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639652533;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=Fg+uEPbE7VxBG+JbUTGhgFYzYxgIXiJQuP/1CtUFeWU=;
  b=ErAQ1wAFeUXjd8uOz3sexoKYkZdShKfzaj5eVncDD1x64Ce8u11wrU2h
   2tKmOi3zt3V9EJlfhu8v1Mz5emidAxbPlESv+hVUf0Ia8Er23AR2+Ml3d
   8NFHDPAdssVbI6IfKKb9ezHEbwouZIeObFTou0jf9czT8k517tpYov6dd
   8=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: iy+1pHLQXsSOFkeJ7lx+DgCGH3Wcuu6jzTTUmkkv/HCKvziH0qvV+x4Cfreljdo1rf0HHVKeaU
 y8wvQi8dUQhJLSQIsVvMg0fS8oC999B6fjEcC+gRXQgwcE6ja+tt60qGxDhr4Z+Yq4hRTXWsB6
 fxkJnFy3/jEjSEDzMMn6bOSS6XufhIPAv/FtkwX1lq5T5U9iVOo0KSC9BDnLa5hLr9E1SFxrRI
 NPAAIJLcfej2LacaWWp58bi08x/799Q0KtWQ8L997/xfbYgaoyRxC9OLb9aWC4MlQogAWvfs32
 C69GQJ7xpXvKBofUVx9Pzgi3
X-SBRS: 5.1
X-MesageID: 60178179
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:67Af4KzWNeCzVoK+EfZ6t+eDwSrEfRIJ4+MujC+fZmUNrF6WrkUGm
 GdOXGCPMv6KMGP1coh2aI6+9B9T75Lcyt82TwQ+ryAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbdn2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/tqj
 49jibyVdRUGGbPNqOI+FElpEBgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEAhWhg358fdRrYT
 /Q0MGR+fTn4XxBWGmcsEMMR3/+vt2aqJlW0r3rK/PFqsgA/1jdZz7zFINfTPNuQSq19nFucp
 2/A13T0BFcdLtP34SGe7numi+vLnCX6cIEfDru18rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ
 2Qu8yozqe4J9UqkTvH0RRj+q3mB1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/
 nWEhc/zDDpj9picU2uA96y8pCm3fyMSKAc/iTQsFFVfpYO5+cdq00yJHo0L/LOJYsPdMiq3m
 R62jA0ClZo0k8870Yb8rWHEumf5znTWdTId6gLSV2Ojywp2Yo+5eoClgWTmAeZ8wJWxFQfY4
 iVd8ySKxKVXVMzWynTRKAkYNOjxv67tDdHKvbJ483DNHRyJ8mXrQ41f6SoWyKxBYpddIm+Bj
 KM+VGpsCH5v0JmCMf8fj2GZUZ1CIU3c+TLNDKq8gj1mOMcZSeN/1HsyDXN8Jki0+KTWrYkxO
 I2AbeGnBmsABKJswVKeHrlGgOJ6nX9umDmLHvgXKihLN5LEPhZ5rp9fbzOzgh0RtvvY8G05D
 f4BXyd19/mveLKnOXSGmWLiBVsLMWI6FfjLRz9/LYa+zv5dMDh5UZf5mOp5E6Q8xvg9vrqYr
 xmVBx4DoHKi1CKvFOl/Qi06AF8Zdc0k9ixT0O1FFQvA5kXPlq7ztvpCLMVuIuF8nAGhpNYtJ
 8Q4lwy7Kq0nYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSTkjM9VgewpiQIEAStss4y/
 ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg69lOdwIJDXC2iCei
 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzNYYAuaFdDzQTk3u/6Cma
 bkHxv3wKqRfzl1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQW7/9D3L5UvweyS
 3mjwNgCNOXbIt7hHX4QOBEhMraJ28YLl2SA9v8yOkj7unN6peLVTUVIMhCQoyVBN78pYpg9y
 OIstcNKuQyyjh0mboSPgixOrjneK3UBV+Mst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f
 m7K3PLP1+ZG207PU3svDnycj+NSiKMHtA1O0FJfdU+CncDIh6Nv0RBcmdjtot+5EvmTPzpPB
 1VW
IronPort-HdrOrdr: A9a23:+LcxyKOYb7suu8BcT1v155DYdb4zR+YMi2TDiHoedfUFSKOlfp
 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79
 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY59s2jU0dNj2CA5sQnjuRYTzra3GeKjM2YqbQQ/
 Gnl7R6TnebCD4qR/X+IkNAc/nIptXNmp6jSRkaByQ/4A3LqT+z8rb1HzWRwx9bClp0sPsf2F
 mAtza8yrSosvm9xBOZ/2jP765OkN+k7tdYHsSDhuUcNz2poAe1Y4ZKXaGEoVkO0aySwWdvtO
 OJjwYrPsx15X+UVmapoSH10w2l6zoq42+K8y7QvVLT5ejCAB4qActIgoxUNjHD7VA7gd162K
 VXm0qEqpt+F3r77WXAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEa0HADnx5OkcYa
 dT5fnnlbVrmG6hHjLkVjEF+q3oYp1zJGbIfqE6gL3U79AM90oJi3fxx6Qk7wE9HdwGOt55Dt
 //Q9ZVfYd1P7grhJJGdZQ8qPSMexnwqDL3QSqvyAfcZeo600ykke+C3Fxy3pDtRKA1
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60178179"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=InrnOGRyhI4ELYPL8hYZZroLnBuxwhHv7H4U0aRyGHiNQL4A/n3FExI2ZkdYDi1q6YMQOf69ngDTqwug2FMUDrYg/h5kjHLETMBghkMv1MC86kVAADksL0K7/he2cdm6pzJ9WEAxljmK1slNtdNkIjtzASsIDKo+ayr1LekNpt4yQIdcOfN+adDK9E8OEMIxBcam+atQpqj6V+CkoCyPFgvTFO8I7l6hg8v8jTkHZB1YL2lNjAeG1ywMVgcxMviduKbZon/o877lBfHK6Wc5hSJzlIYoHT3+1RR5CwcJeVx1OQsXBzeBQ8vnqcwHUIrYEr0mO0nvw0DkL9pg4gqgIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=RWiGSycncAROXKRaDPiBtui2T+NsU8mFODxhu+cqg/E=;
 b=NwpEH9mPoE+nETjstaIEWqr8VN7OFm1apoGpvdxKQExiDsVEYRM+xG4r3USbAyks95t846SI9XH2fjMKJDvoyQU7RmxvI3PxocUFnIG8r7mpYz8sJtb9TiMfe922pf9i4Vqyq20vGZxL7ThlgQc7IJaomPubtotiG8VJU51lvoO8PFIVNc8wOmE/JXEzpA0vozG3ag+yKiKbtg7I5p6hBP+/UeFrVg6z6XBPK6pax+X6TZQ8XDXfR664fpecFfEdS38o+IixCeLBFc+6ogB7rXJkfgK5tqXoul1+s+NS0CnEaMzBdXQI+OTwOngoswh3u+5rfYAukAmGFCyA2RJuqA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=RWiGSycncAROXKRaDPiBtui2T+NsU8mFODxhu+cqg/E=;
 b=Bcjq7A5Hm1rNwqL6Vl2vmgphTxhoNoXNJMSB76DSlPPj4dsFkHYVH9RRlDQIw76Js90AdD+5Geq7oXdZZUU50dOwZwaaCCWpDCr6W+WRcErRgAir4BwC5jIueWUMQJ7X29qUULs1WMzQKQwhw9cwO4mF1K2ZmUicr7gB6W6KUBc=
Date: Thu, 16 Dec 2021 12:01:53 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Rahul Singh <Rahul.Singh@arm.com>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Message-ID: <YbscoZG/NRP6lMof@Air-de-Roger>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
X-ClientProxiedBy: MR2P264CA0075.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e0375f9f-dd35-43ff-aa53-08d9c0837edf
X-MS-TrafficTypeDiagnostic: DM6PR03MB4394:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB439462600B5355C5CC36908D8F779@DM6PR03MB4394.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HOx6zbdQ8OyWE/x3VlY6/t2Pe29C2y9zLIcrFAw5barGZJbZPVxVCLOzr5UxFhnOYMNaOUfX5Q6A+nVMRf6m1Y2xyTIwiIW87Fhy3wn29A34ytf4xOPXQ7NTX4LYK1dMac9Osplc3qax5zSxdekQOYlXfQzZRTUj+l/Bo+sk1+KeGsP117uDzozp6vsinrxaX0Vfv/dFWLSy6I321F8OKoZypnQ5BvPbQNg08Z+L18EFNwvZhFZo/mbJOT9dUvbddSRLcJNXI+MXLJcK3wN1OfOSfTiqVwETWOvNtvkftwzzdcLhde79g8k7nsGKrey/wonEQdm3F6VGpbF9QB+lKXo+jdSJ1fjxJmAfTpuldsd3Df7QkvM9WAdozb9G+3Ai5RkOS0ukv5WrzROFHJFHmk09jECnRed4qs4tL2MrUZnuiUNEe5bXvTO3ZcM7CgGbOm63PRPqFR07dh2ZXPynpXVM3TES2aaKJyu1sC8JoZZfsqYT/hNhUjBHo76+2lSFuLQSTldcpOsuYHhGd4k9qqkgJFx+IuPCtaVJpHBK7rniSgt9lV66sClFSe0r48KlTL7YtwqqDa8TVhER9IGL4ZMrPnX5xEV/DhI2Mw2BNRiBR7Ee5TWkAEhJjPf2x539soasTtKoc6x+/8DUIHTAGQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(85182001)(82960400001)(6916009)(66476007)(66556008)(66946007)(8676002)(8936002)(6506007)(83380400001)(38100700002)(33716001)(5660300002)(6486002)(86362001)(6512007)(316002)(2906002)(4326008)(53546011)(6666004)(9686003)(54906003)(186003)(26005)(508600001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmpJalJBMUtQMWVmRHI1Y3JraVV5VkxZL2lxaTFkZXZDK0NLa2E1SXlrLzgw?=
 =?utf-8?B?eHJZc0E4a0prTFZEWGsyV2pFZGJLVVBhVWtoK0YySUVzczJObG51S0dJMlN1?=
 =?utf-8?B?VjIzVnRBSlVPRVZiT0lTQ1NuNVBJaHVXSHR4Ums0Q0wrZjkwNFRoMk5jUG55?=
 =?utf-8?B?VnM3VGNBbUloVW02YlRIOVVFeWVkTUxzTkZ2NzFsNWFWUVh5elMzREluSE9S?=
 =?utf-8?B?Tk9wWEk0dW1lMENEcVhaa1J2aVBHNjQ1cDhSdzY3NE1ubVFrdk9JRFg1ZU92?=
 =?utf-8?B?NFVtZmFjOVR2ZUNuVmtZUTZYdWNrV2NtQ3ovRnVOdU9rbjAwYXQrYkFlK1NB?=
 =?utf-8?B?dmtNQWFLMGlJRzNCdGs3L2Rja0pwUVZVbStQUGhNQ1NVOXY4bXl3bUVDcDdE?=
 =?utf-8?B?MUhrQWJMM3hXaWNKUlQ3NVZ6WHcxSDdsdzJKTndCSk01MlZrS3BSVng1dTdi?=
 =?utf-8?B?NGIrQ1hWOTFnNU8rR240T09RelkvSWJjZ0FnOTNPY2tkTGRROEluaGtHdG1Y?=
 =?utf-8?B?Y3FoS2dkaW5IbXhSd2d6ZkpDbkU3ZDNIVEhmZUppNXljd3c2VUxJb2M4VEVO?=
 =?utf-8?B?YzdmdXZxQUdVZXFYSHNBdG1QU09vclFLWHFGbFJ2bzdKN0pxcDlkQk1xNTZy?=
 =?utf-8?B?MExZc0pRNHVtWmUzeElaTzFNT0pSVWd5aWVYWmdqZlhQSmFsTW9WZlo2ekg0?=
 =?utf-8?B?eFlzTXdRaTFyUHJYYTJyNkV6Q3o0eDdkZ2hocWZSVWdUdEJFM2tIM3lON1Vx?=
 =?utf-8?B?OW5wSk9qbTFnMWFjcS9YR0N0WTRiQWNYcXByS2dqblBWSVVxRG9HdWM1cEsx?=
 =?utf-8?B?RkhrOXVQYnBjV1JuR0RZQURKL2kwY1dobXducEhIanpMMncra2h2bklORy9C?=
 =?utf-8?B?RHl6VCthRGUya2ZXYXBaRldvWHlvWlFTQ05pRjJ5NTlDaDR0ekF2L3lXWkl6?=
 =?utf-8?B?RTdFcUF6VmFpanY1RkVxSUI0bmJLSWFSbDJpSEc4S2s0U0U0c1dSTFdYemVX?=
 =?utf-8?B?dFF6d1lnVTBsMzhPckhTUnNuRXpqRWVHMWxJQy9pdTdiRHluS3hyOEJJQ3dX?=
 =?utf-8?B?Yi95Q0ZTZmxoNVl3SzlBUWVtMG5UTlBrYnBxR3MrYnZtK25ocm82TitGVW5L?=
 =?utf-8?B?anZZeWcxLzQ3dDZpL2c1RkU4dXcxYy9TTWExME5SWkltb1N2YlVHc1RqKzAy?=
 =?utf-8?B?cEs2cEllSExTWDUrRDEwMSt4YlovYm1BTlRyOWY5dFNoQjhQaFpnMVhEOG5Y?=
 =?utf-8?B?UUtBYlJnK0R2SDR5R09XeUF3bUE5Ui9mYWNiNzZBLzkza0NDTExjMFBHbDFX?=
 =?utf-8?B?UUMvTGRFSXN6dk5WUmpaMnppc3RFVnBBN0ZreVFpSm11UjdWczZkOVg0YjFO?=
 =?utf-8?B?QnNqOWgxUlFGS1NWTlhCS3R2aHI3Zk1VaW9xYWFxbytnRW9GTm0zQnY4bkJk?=
 =?utf-8?B?a013RXJ5ZEtFM3VneHZCdGFKb0F2MVpOaU9idzQyY242dVkvWDZCQzhmUmc5?=
 =?utf-8?B?TUJrL0JkWmpkZTdseWU1a2dVZUVHNDJ2V25KQml5Q2dKcTdmeFhRelFVZ0ta?=
 =?utf-8?B?N0oyWVNlUE1CTkgrem5oQjVDVUt2ZkZHNG1SU21XYnB6K0NQbXNPREl0MXoy?=
 =?utf-8?B?OUFGbVhBYWtrd0Jkc3ZIZjhqUXdXUk9pd2hGTFRwRXRGV1FZS1NjTEREeElG?=
 =?utf-8?B?WXlVWjJtY29QSDJIWkpRRWZPR3FNNGxWVjg4VXcwMUd2OTNubmRUd1JxbHJw?=
 =?utf-8?B?VDBDUnQ5OFZlOWhHeTdCd2c3aU91Mi9iV2p5aFhrRk9aTENnRmFvRnJ0RXJj?=
 =?utf-8?B?dGFHMTcvcjJiQ1laYmNKWVNCa3J5ZWR1MFFFK3FjV3Y5Z2xVYmE2d1Z2KzI5?=
 =?utf-8?B?K2F4WDE1cjFCV0RlL3U5aFdMWmlqS0FkTnRGcVdIb1ZONVJ4SHF1NlVaRUh3?=
 =?utf-8?B?N3JyVnJTZmpBcEFxZzUxS0t0cGRoUHduNjV4QXg0eHJFdWVQbmg2KzdlWXFh?=
 =?utf-8?B?REtVWUZuREpDQjMzcjdENnRjbWw3UWFwTTJFWjNRTzJrVGRUcTJFenVsOHpS?=
 =?utf-8?B?NGdFdE5yaWU0R2RoRUFIRWJxMXFVSVVVVEcrVTVjQVZXYy83a0Y5cFdEU203?=
 =?utf-8?B?azFtYWVRZ0NXUFlZYXlZTkw4N3lLRFZrRVBsa2o4SnJJWkY5OURuTGdMZkRG?=
 =?utf-8?Q?8JjGB9Dn79VyPZ+J9PsZijE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e0375f9f-dd35-43ff-aa53-08d9c0837edf
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 11:02:05.4127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ToVVFlnq7ozeRtIwyJQHitI/EXGCfgUzNNOK2kACxTII16r5CviNT38mA0DuSeIReA2w8BShIFYfeoeB9rIQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4394
X-OriginatorOrg: citrix.com

On Thu, Dec 16, 2021 at 10:18:32AM +0000, Rahul Singh wrote:
> Hi Roger,
> 
> Thanks for reviewing the code.
> 
> > On 14 Dec 2021, at 12:37 pm, Roger Pau Monné <roger.pau@citrix.com> wrote:
> > 
> > On Tue, Dec 14, 2021 at 10:45:17AM +0000, Rahul Singh wrote:
> >> +              unsigned long *data)
> >> {
> >> -    const struct domain *d = v->domain;
> >> -    struct vpci_msix *msix = msix_find(d, addr);
> >>     const struct vpci_msix_entry *entry;
> >>     unsigned int offset;
> >> 
> >>     *data = ~0ul;
> >> 
> >>     if ( !msix )
> >> -        return X86EMUL_RETRY;
> >> +        return VPCI_EMUL_RETRY;
> >> 
> >>     if ( !access_allowed(msix->pdev, addr, len) )
> >> -        return X86EMUL_OKAY;
> >> +        return VPCI_EMUL_OKAY;
> >> 
> >>     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
> >>     {
> >> @@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
> >>         switch ( len )
> >>         {
> >>         case 4:
> >> -            *data = readl(addr);
> >> +            *data = vpci_arch_readl(addr);
> > 
> > Why do you need a vpci wrapper around the read/write handlers? AFAICT
> > arm64 also has {read,write}{l,q}. And you likely want to protect the
> > 64bit read with CONFIG_64BIT if this code is to be made available to
> > arm32.
> 
> I need the wrapper because {read,write}{l,q} function argument is different for ARM and x86.
> ARM {read,wrie}(l,q}  function argument is pointer to the address whereas X86  {read,wrie}(l,q} 
> function argument is address itself.

Oh, that's a shame. I don't think there's a need to tag those helpers
with the vpci_ prefix though. Could we maybe introduce
bus_{read,write}{b,w,l,q} helpers that take the same parameters on all
arches?

It would be even better to fix the current ones so they take the same
parameters on x86 and Arm, but that would mean changing all the call
places in one of the arches.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:08:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:08:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247870.427450 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxod3-0003ke-GH; Thu, 16 Dec 2021 11:08:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247870.427450; Thu, 16 Dec 2021 11:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxod3-0003kX-D1; Thu, 16 Dec 2021 11:08:53 +0000
Received: by outflank-mailman (input) for mailman id 247870;
 Thu, 16 Dec 2021 11:08:52 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2y9W=RB=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxod2-0003kR-7w
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:08:52 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b76311a-5e60-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:08:50 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b76311a-5e60-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639652930;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=9iZdtPj5vZ9x0d0wIZ0ocqoZnXi4nksY56Q8y+mWS9Q=;
  b=bY0DxF706XGO6AiT+z9fBLZMbPA6kzUCqYrrGU7xO/Cs2zdc9oghPE16
   GNz+QfgZ/2l/W0yURdtufGTovbUTr6zsXk/AqH7W00xqLU3dmGgoEU/oM
   e1HmovkkzQbyFOmgQNMW51kY9SdJ3jgAAq1OZWY7pXmsNyRhaMr6LApHa
   U=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 6sp4iTeQjyyOiR/ZRIuPxr0bZ3QLUELytv75XTqWgDu1L2AkptO5r6yqNsD7eKT2FI6kk0IQRh
 FX8PIZDS2vj0m8VkjOqeBq+2GkxuZ/mZh66uhWq13zJ8/Hg+fkqNGsYCdKsmdw1xpO3Jwgqq4k
 hk2V7cVBMnbFArzurNc4mO7GI1SzUIp0DhHmmNbxpEZfKSkYxq5CSzFaIVxv4RnP76qlF2Qz+K
 j7RlxEpr/sYDkMO/p6qg37LDbDF2OXvyKBlIcbTiMxj+7nh79fQ5p31ze7fyxgGIw2TZE0BPV6
 uzTu4JyiBKKvbE6AoLKAcD/A
X-SBRS: 5.1
X-MesageID: 60178587
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:YsAfQamf81pnD1qs0HXUvnzo5gxVIERdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZWG2GO66PYWuhfdp0O4vloB4Eu8LdnIc2Hlc6qSo0RSMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2Nc22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PtRka66UgokBfPRovsvUBdWDR5FE5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ66HO
 JpEOWUHgBLoMx1KKwxUNcICpty1onugVjtko3K7uv9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt
 m/AuWPjDXkyL8eDwDCI9natgO7nni7hXo8WUrqi+ZZCn1m71mEVThoMWjOToOa7ol6zXcpFL
 E4Z8TZoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsZjJZc9knqM8eTCQnz
 EOUhMjuASFzsbqTUjSW8bL8hTm1MyIEIHQCYSIBRA0t7NzqoYV1hRXKJv5gF6ivh9GzBjD0w
 BiNtiE1g7hVhskOv4238lzKjCiljoTYRQ4yoAPMVySq6R0RTIyvapGs6FPbxe1dN4vfRV6E1
 FAPnM6Y6+ICBI+MjwSCRewMGPei4PPtGAPbhVljDpww7QOH8nSofZ1TyDxmLUIvOcEBERfjb
 VXPowpX6NlWNWGzcK5sS4urDoIhyq2IPd3hV+vIZ9tUJJZrfQmM/TpGekKbmWvqlSARfboXY
 MnBN5z2VDBDVPohnGHeq/ohPaED6Dwa92nISJ3AkQmdzoidanCLdowrCQ7bBgwm15+srALQ+
 tdZEsKFzRRDTeHzChXqHZ4vwUMidiZiW82vwyBDXqvae1c9Rjl9YxPE6ep5I9QNokhDqgvfE
 phRsGd8wUG3u3DIIB7ihptLOOK2BsYXQZ7W0EUR0beUN5oLPdbHAEQ3LcJfkVwbGApLl6Qco
 x4tIZroPxi3Ym6bkwnxlLGkxGCYSDylhBiVIw2uayUlcphrSmTho4G/L1a+r3ZeU3Dv7qPSR
 oFMMCuBG/LvoCw4U67rhA+HlQvt7RDxZsosN6c3HjWjUBq1q9U7Q8AApvQ2P9sNOX3+Ksiyj
 G6r7eMjjbCV+ecdqYCR7Yjd9tvBO7YuTyJyQjiAhZ7rZHayw4ZW6dIZOAp+VWuGDz2cFWTLT
 bg98swQx9VbxgsX6NQlTO4wpU/8jvO2z4JnIs1fNC2jRzyW5nlIexFqBOFD6f9AwKF3owyzV
 h7d89VWI+zRasjkDEQQNEwuaeHajaMYnTzb7PIUJkTm5XAooOrbABsKZxTc2jZAKLZVMZ8+x
 btzssAh9AHi2AEhNcyLj34I+j3UfGAASaguqroTHJTv1lgw0lhHbJGFUn327ZiDZs9iKE4vJ
 jPI1qPOi64FnhjJcmYpFGiL1u1Y3MxctBdPxV4EBlKIhtua2aNngEwPqWw6F10HwA9G3uR/P
 nlQG3d0fajerS11gMVjXny3H10TDhOu5UGsmUACk3fUThf0WzWVfnE9I+uE4GsQ73lYImpA5
 LidxWvoDWTqccX20ndgUEJpsaW+H9l49wmEk8G7BcWVWZI9ZGO90KOpYGMJrTrhAN8w2xKb9
 bU7or4oZP2pLzMUro06F5KehOYZRx2zLWBfRe1sofESFmbGdTDugTWDJihdoC+WyyAmJaNgN
 /FTGw==
IronPort-HdrOrdr: A9a23:W9Ke4Km360EPkFyGRSbgYjYvBk/pDfIu3DAbv31ZSRFFG/Fxl6
 iV/cjz8SWE7wr5OUtQ/exoV5PtfZqxz/FICMwqTNGftWrdyQ6VxeNZnOjfKlTbckWUnINgPO
 VbAspD4bXLfCFHZK3BgDVQfexP/OW6
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60178587"
Date: Thu, 16 Dec 2021 11:08:42 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Alistair Francis <alistair.francis@wdc.com>, Connor Davis
	<connojdavis@gmail.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
Message-ID: <YbseOtj7prFqViyV@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
 <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com>

On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
> On 25.11.2021 14:39, Anthony PERARD wrote:
> > A subdirectory is now built by setting "$(obj)" instead of changing
> > directory. "$(obj)" should always be set when using "Rules.mk" and
> > thus a shortcut "$(build)" is introduced and should be used.
> > 
> > A new variable "$(need-builtin)" is introduce. It is to be used
> > whenever a "built_in.o" is wanted from a subdirectory. "built_in.o"
> > isn't the main target anymore, and thus only needs to depends on the
> > objects that should be part of "built_in.o".
> > 
> > Introduce $(srctree) and $(objtree) to replace $(BASEDIR) in cases a
> > relative path is better, and $(abs_srctree) and $(abs_objtree) which
> > have an absolute path.
> > 
> > DEPS is updated as the existing macro to deal with it doesn't know
> > about $(obj).
> > 
> > There's some changes in "Rules.mk" which in addition to deal with
> > "$(obj)" also make it's looks more like "Makefile.build" from Linux
> > v5.12.
> > 
> > test/Makefile doesn't need special handling in order to build
> > everything under test/, Rules.mk will visit test/livepatch via
> > $(subdir-y), thus "tests" "all" and "build" target are removed.
> > "subtree-force-update" target isn't useful so it is removed as well.
> > 
> > test/livepatch/Makefile doesn't need default target anymore, Rules.mk
> > will build everything in $(extra-y) and thus all *.livepatch.
> > 
> > Adjust cloc recipe: dependency files generated by CC will now have the
> > full path to the source file, so we don't need to prepend the
> > subdirectory. This fix some issue with source not been parsed by cloc
> > before. Also source from tools/kconfig would be listed with changes in
> > this patch so adjust the find command to stop listing the "tools"
> > directory and thus kconfig. With a default build of Xen on X86, they
> > are a few new files parsed by cloc:
> >     arch/x86/x86_64/compat/mm.c
> >     arch/x86/x86_64/mm.c
> >     common/compat/domain.c
> >     common/compat/memory.c
> >     common/compat/xlat.c
> > 
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > Acked-by: Bob Eshleman <bobbyeshleman@gmail.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with one nit and a remark:
> 
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -22,6 +22,15 @@ export CHECKPOLICY	?= checkpolicy
> >  export BASEDIR := $(CURDIR)
> >  export XEN_ROOT := $(BASEDIR)/..
> >  
> > +abs_objtree := $(CURDIR)
> > +abs_srctree := $(CURDIR)
> 
> Nit: In line with e.g. obj-y I think these would better be abs-srctree and
> abs-objtree.

I guess that would be fine, we don't need to keep the same spelling that
Kbuild does.

> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -80,6 +80,9 @@ endif
> >  extra-y += asm-macros.i
> >  extra-y += xen.lds
> >  
> > +# Allows usercopy.c to include itself
> > +$(obj)/usercopy.o: CFLAGS-y += -iquote .
> > +
> >  ifneq ($(CONFIG_HVM),y)
> >  $(obj)/x86_emulate.o: CFLAGS-y += -Wno-unused-label
> >  endif
> > @@ -129,13 +132,13 @@ $(TARGET)-syms: $(BASEDIR)/prelink.o $(obj)/xen.lds
> >  	$(NM) -pa --format=sysv $(@D)/.$(@F).0 \
> >  		| $(BASEDIR)/tools/symbols $(all_symbols) --sysv --sort \
> >  		>$(@D)/.$(@F).0.S
> > -	$(MAKE) -f $(BASEDIR)/Rules.mk efi-y= $(@D)/.$(@F).0.o
> > +	$(MAKE) $(build)=$(@D) efi-y= $(@D)/.$(@F).0.o
> 
> Hmm, hasn't the efi-y= become unnecessary already by patch 6?

I think since patch 4 "build: set XEN_BUILD_EFI earlier". I'll remove
these there then.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:09:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:09:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247872.427461 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxodk-0004TO-Pw; Thu, 16 Dec 2021 11:09:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247872.427461; Thu, 16 Dec 2021 11:09:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxodk-0004TH-Ml; Thu, 16 Dec 2021 11:09:36 +0000
Received: by outflank-mailman (input) for mailman id 247872;
 Thu, 16 Dec 2021 11:09:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=d0Qa=RB=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mxodj-0003kR-FB
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:09:35 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a5211ec3-5e60-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:09:34 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a5211ec3-5e60-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639652974;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=38YnxexaKSLiwNmcvIkCImRQ28BYCqUx8n0/pWWTWx4=;
  b=iMywv3y+7AbPKmiECRn+44B6k3fcQ5yL/sYOSFhX5QsFubsUbI4H7D6r
   Ep5eXDptSIE0v1AxOBgpaPs+0WzkgckbLlaozn8mvrrXlomMrOdY5F969
   gkL3+JtplLYxScrYX+PRzEj075CYcvVN5yuFnciMwIqgfZXH3plQs8NRV
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: Ln9HIEBabr0E0ZSky9HoJW/u+CqLCGGcG4OsvMtWj5uo51dfqWaWOmGrHB0i/3hiQ/lPMUfr9P
 lMkNCJLUeRUdznIerK1i0xJ82HFNMyQjpC7y5dBD+UN6PKliVVM1XW/HkcHJMETF+pnL3BZBue
 E7wPJWqifj/Er09ehnHQa+obsAYS85GdwWBm3h3bG/YYwWSk5nK9rOuUDq2QyBVGdWTfMN/4Ln
 pamlkHUW0X0+satxafCBfgr0/cIm25M8dirrbPXCMKXlkzscHmqdDWu8/8X4LdZQZPuzLa7qVM
 fT8KWpQ+GyIaiUrOdTTD2Efh
X-SBRS: 5.1
X-MesageID: 60164149
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:TAT09anxaX6RznRnHXxZCUjo5gxuIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIZWz3UPqyOZmD3Kop+aNmwoE9VvMfTxoIyGVQ5qX8xEyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2Nc22YLR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 PpQiMa7TQwbBa73tu8WEBdBGTElBrITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Glo354SRKqPD
 yYfQTZuNw/lTwVUAFlUAao+oumX22v9fQQN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv
 X7duXT0BAkAM96SwibD9Wij7sfQmQvrVYRUE6e3ntZjhVbCmEQIEhYYE122vZGRiESzRtZeI
 Ew84Tc1oO4580nDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyymEOzIPSjVzU98dmsQ9BjIz3
 E/SpMy8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBn3+1L5fPnwZlX6rwub9iEgpHSBjA46QzMNo5OxlMoPdX1D2BEBLWy0BqhEGp7ZgXR1
 JTns5LHhAzrMX1rvHbXKAnqNOv2j8tpyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS
 BaN4lIMtcQMbCbwNfQfj2eN5yICl/KI+TPNDK+8UzazSsIpKF/vEN9GOyZ8IFwBYGBzyPpia
 P93gO6nDGoACLQP8dZFb7x17FPf/QhnnTm7bcmil3yPiOPCDFbIGeZtGAbfNYgRsfLbyDg5B
 v4CbqNmPT0EC7agCsQWmKZORW03wY8TWcqr9pcJL7HbeWKL2ggJUpfs/F/oQKQ894x9nebU5
 HCtHEhezVv0n3rcLguWLHtkbdvSsVxX9hrX5AQgYgSl3WYNe4Gq4PtNfpc7Z+B/pudi0eR1X
 78OfMDZWqZDTTHO+jI8a5jhrdM9KET31FzWZyf1MiIie5NARhDS/oO2dAXY6yRTXDG8stEzo
 uP821qDE4YDXQlrEO3fdOmrkwGqpXEYle8rBxnIL9BfdV/C6o9vLyCt3PY7L9tVcUfIxyeA1
 hbQChAd/LGfr4gw+djPpKaFs4b2TLcuQhsERzHWtO/kOzPb82yvxZ57fNyJJT2NBnnp/KiCZ
 PlOy62uOvMwg1sX4ZF3FKxmzPxi6oK39aNa1AltAF7Cc0+vVuF7OnCD0MRC6v9Ny7tetVfkU
 06D4IAHa7CAOcejG18NPgs1KO+E0KhMyDXV6P00JmT85TN2o+XbARkDYUHUhXwPNqZxPaMk3
 fwl6Zwf5AGIgxY3NsqL03JP/GOWI31cC6gqu/n22mMwZtbHHr2aXaHhNw==
IronPort-HdrOrdr: A9a23:WujjvarQ8l1FiOmi3NVauiYaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60164149"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ItFlQyXQO1Hwh9NlVh2Rat+nTCEDoQPEyQk1aix/Ah82NfT+1694xtHkk39t2/9flp3kQODdGomqfJiCGiAQQ2afNL/wACzsjubmxKLx6OCOixGh2+8OXvpLkEzozmwXzn4bIfviM8Iq34kyUIM2YEZV3679p0QcCJi8rME9GRDsOlK2v/oV4Ud2B+n4UyHmqxLFfUHgqiEdcifwgs/ZVqseneUGsGp6Py+HQg4AC7K3Jw6Ymgd8NA0/ZHFM4qky/2guYRvCdLfL4TqFmzDefEZp6dz2OjZ3CT5YkMDk3rr1dnXdY0c1kO+Vw/ZXS0PoQrbbeC9WUT66n1enwsKpaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hji2z3QqydBhhpIzlLRwVcOrjCHh9Pg5U8XVhBYmkmE=;
 b=oN2ZjhZ1lUmscfPw6tj3mr3T/JszyJz9WK1R7MPX1mLh6p9UY49NmCc2ab6viZ3a0uqbK0YSnBbdL+pHiYhV3N4m/UTxu/InD3TBAhkDS5soJZ8zeaAq9crBeAzU5lxua1ChFSRoCLqjgkO50CHvSydv6deC3BBvVFFG35mPNjKSkxrczca9ywxYk62nBeDpfoZxnPJPKIQTCh4Rm/KFerSB7Gw2aFYtAX3YXb5fj0C7setvQEcnQRySa9EjQBecy/BgXzSF1rJYhlZQKqc/M4w7qGPRo4n3rKmHxJ1DYQ68gjJt2XpR03e9LsHP3aa6W0M8GfkWqbug4DWxFyWKpQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hji2z3QqydBhhpIzlLRwVcOrjCHh9Pg5U8XVhBYmkmE=;
 b=LEUz/uTEhqxCKIvL7jFewUuiw8JemRngVFl4cH3Kf9SleMMNYHM/pmDj3pqyhG0pep+inkXEE4c50BBHUwJWYSdYuNqhL2OL050BLDBRH4BjVv3tw20GB08c4Kg4b2IBrifnJh9ChN9JboB8etaqpHNpaTJURL0rrVY7acftm4E=
Date: Thu, 16 Dec 2021 12:09:17 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: Jan Beulich <jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should
 be UC"
Message-ID: <YbseXUE0byGJCzsy@Air-de-Roger>
References: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
 <YbsMwIYFULP5sXQP@Air-de-Roger>
 <cb9bea36-9feb-dbc7-ce36-38fd42792f11@srcf.net>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cb9bea36-9feb-dbc7-ce36-38fd42792f11@srcf.net>
X-ClientProxiedBy: MRXP264CA0022.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:15::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 82912828-3476-47a0-b922-08d9c0848454
X-MS-TrafficTypeDiagnostic: DM6PR03MB3737:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB37379A1AE9DBF1CAF829519F8F779@DM6PR03MB3737.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: J3NRh7ek5jRzE4R4zYfZVIqUvI2VAwer82W/wYiNTJy92ldtnnrszSsMyhWqpKd43Xg2S2dqbu+8mSKsuHLlEVfopGw8pmU0atyG3cIP22ESxRCULDQGsZcnWd8vapN56G2H0MktbrwTUuWWrhwl7a+Zi2927VFOrA//sbfMl5/TW7TC/CmyMJY9SzrYoGtPu1PCIVD6JqwVVW+Kv1UZTe9ON2ft+whEAXDxmvjFup4OiDIt0Rxjjfi3rzGqwAJBzkqO/e5fX4x1TsvFfR9sDoN7R11OKlEEMobkMJ8TRqOBx2tzgk2z3hkx26hjFx9kxJfoNr7XY+K0X+kh3qtoC35MT1T6iZrm5XZczdHwc3/gUyAoQ7OcrlLDlVf0tshCI0tCUq0s8tfUgSHy7Z0f6hdlboYfBtiX/6q1rcDqfPmmiVZXctkLjCHbmVJJVnPBC7IACp6Wv7egUNSy0DvN49FSgzdJukm0W1eOWyEe2/HzvFy+/gWxWyf9vyac1GMoTzHbUPYj0DY99Akhsju8VPyEXBWTUQc8r1LRDtcoh49uqgFaw4D6NdwNLet3HGUMWcNV3a8X4oJmBLjdYR00QBmi0GH3jBhMmd2Ftn9LFinQG3DTqfMX09JjTzp5QjIRuPWG50MPOQRpLmY6WlqEmA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(38100700002)(26005)(8676002)(86362001)(5660300002)(6486002)(186003)(66476007)(6916009)(66556008)(8936002)(33716001)(9686003)(6512007)(6666004)(53546011)(6506007)(83380400001)(85182001)(82960400001)(66946007)(508600001)(54906003)(316002)(4326008)(2906002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmJPN21NRGNYNDVFL3I5QnpYZUNvVDNndTAzRlFvNHNQSkg1ZmM0dVlTak56?=
 =?utf-8?B?bjA4eFd4bVA0NTlIUzZ3UmFjaG83Y2lBcmMwcWFFWFFmRjd6Wmg5ejg3b3lW?=
 =?utf-8?B?cjFlNkNyN3VVdnZvOTNLU25Fc3k3ZWpyM1U4YTdFZHBhN2RyUU02Q1VrVS9O?=
 =?utf-8?B?MzVTSnVYWUF1cjdkcVRqeU1MTWFITGtVZ3gyM1E0RUt2Q2RFMk5iWDZUM2NP?=
 =?utf-8?B?YjYreElqKzBlNkp4UTUyTkxpcGNtOEtDSngvWFZIajNwUjI5Z25QUnZ3aHFH?=
 =?utf-8?B?MXBKY0hQaEgxR0EzQVBESzkvZmpqYllmekhOWktHUFM1RlNNUDllSjJWaWpV?=
 =?utf-8?B?VFZaS2NOOStXRzdTeTZoMXYxOEFzeFBzZmJXQUs5WnJzQXZkY0lSOUtVZHJ3?=
 =?utf-8?B?WUtzb25hb0ZzZUZpd2ZoWTdzK24yb0JnN0dUb2lwaWZLR1hncUEweEt4bDNX?=
 =?utf-8?B?M0Z6aXJ0cVVVQzV5ai9BWlByYVZTY2hKNUNlZUlwMDZDTjhqSHU3ZEVRWGVF?=
 =?utf-8?B?dEh0S0hrRndZUUQ1YzZ3SEhXMmdVS1o3a3JhQ3h5Wkw2L0J5STV5aUpzQ3Fo?=
 =?utf-8?B?SldvNlIwWmpGWjBRd1VaUGpaYWdXOVg5U2o3N0JDNDdSMDBiaXVuTDRISjRF?=
 =?utf-8?B?WEVBMzFLTnBSYXRqdVRsSms1a3hXanE1V25rZWtueTlmU2ppVldPdGkyaWdX?=
 =?utf-8?B?RU14NW10aXl6QVg5QzhrWkZvK2JoUjlLd2NhNEVDWjRPcVl6ZjlQSCtyVWl5?=
 =?utf-8?B?R2w1WHNSdkZRUEtGZUtXZDJkNldDc21hMnZQOG9HSGRWTTdWUGR4T3pSaC9n?=
 =?utf-8?B?cGE2YjNTVDBsYWhpNkc0aWtreUpBeWdBdVE1STl5MHF1MmRva200blNySnhN?=
 =?utf-8?B?K1R1V0R2YnA3RWlJSHRrS3UwNjJNL3dJWFhHR1g4Skw2V0FMSEI2dFlTTlVK?=
 =?utf-8?B?VU1sNEE5MU5lUFIwUFY5d0wwT05jcmlsTTV0U3MvMnNzWUZSOUpJKzkzSW5r?=
 =?utf-8?B?WWpQSERZSnAyeGlENVBhVEg1T2lJYVRzNEZ3YWYybVFCQXVJTmJkSC9UbUZZ?=
 =?utf-8?B?cE93WndQNFI5RS9MQ3ppT2x6OXovcGpKTVZ1WWhjcmd0NkRkUUZQcHhuZXlK?=
 =?utf-8?B?dmdsQzdmZUFUTHFCYWkvazJwN1FabUJtSTBDQ0tZaGZ0TndnN0VwTlI2RWhK?=
 =?utf-8?B?aURDdXNFTUJUaElVQkRGd3FGREdMQ3pWSnFhYXprNmowWXNUTTY1b0lidWN4?=
 =?utf-8?B?VkxBUVA1b2NlUTI5WWJYOURtTmxtUnVFbjhHdHY5SUdQSjQweFJKeHB0YW1s?=
 =?utf-8?B?NUViWnpidzhKNUxDM0F5a3JIdDdLT29URm03V25aYkFKMk9VUFE2ZU5Caysz?=
 =?utf-8?B?ODVXb3ZRWk90ZmFGOXVzQlM5QjJqc1RSMm5yTGh0RlE5eWhIeWRCdm9iMThP?=
 =?utf-8?B?NXhqdncySG5jZ0ZPdkxua1pUNmo2aThMYUt2dkF1ODc3RU5uR2RXVkY3OWNh?=
 =?utf-8?B?OTJMank4QVI3UjE4elVEeXVnazVwMzZQVDg1Z1FuT1RwN2VTOFM1bzNkMk1P?=
 =?utf-8?B?WU8zZ3E1SGNSVlNHeVJnSVNOdzNPamxoMlc0TUVzcVpic2FhdEdBck5XVUxJ?=
 =?utf-8?B?Z0NXS25PdkdMYWljWXBJaENkYXJud0grMzRqejEyT2d0Q2tWcXZiZVA4Ulpz?=
 =?utf-8?B?cUZaM0lvM2ZPaEtvMnFnU2VOWjl0eW16NS8zNk9RVElqMENSWlMyL3J3aFZv?=
 =?utf-8?B?M3huMVVkdW80UTkyZnFqUFl0UU9jYmEyQ2RmalJ1eDRqY0s1OVVqRDFza2Fa?=
 =?utf-8?B?cFdXMkRTaTd4ekpXMkRhbDhva2tOUU41cVUzMUs3RFErVFlhTHJibFRpSkox?=
 =?utf-8?B?c1l5TFRwa2lKTmt4TndTSjB6d1loWjAvRUo5VHF5ZEVBVWMrdUxCRlU3c0hI?=
 =?utf-8?B?cU4yQWJxb3RqWlNEYkltME0zNVVLQTdRa1dFbnVOdEpFNjN5UnViQkRYWENs?=
 =?utf-8?B?U2Z5WFExTTJFVjdzUVVtQ1dnMGEyQ2xiR2QwTm9aR3lMNFpHOFVHLzRZb21Z?=
 =?utf-8?B?S294ZDdUNHg0NWJST2prbzhPSG4xcTFrTlEwRzNkd2FCVjl5dHlvUzkzdFlm?=
 =?utf-8?B?QmpVR0d3OVlPUXBpSStNNVY5aXJ3ZWFNbnpLMzNnMmh4WGVXZERON0JhaGtE?=
 =?utf-8?Q?bMlptVwLgQySgy5SBOsaoZs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82912828-3476-47a0-b922-08d9c0848454
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 11:09:24.0183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5p3cahkSMHGqL2wy+2DBsKBtzED96JPtgX5Qp+FxXmZqq5UKeK1jOjT9uYD+CWAw7ZVMUdki5Q6l/6RK8DtDhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3737
X-OriginatorOrg: citrix.com

On Thu, Dec 16, 2021 at 11:00:17AM +0000, Andrew Cooper wrote:
> On 16/12/2021 09:54, Roger Pau Monné wrote:
> > On Tue, Dec 14, 2021 at 09:21:22AM +0100, Jan Beulich wrote:
> >> This reverts commit c22bd567ce22f6ad9bd93318ad0d7fd1c2eadb0d.
> >>
> >> While its description is correct from an abstract or real hardware pov,
> >> the range is special inside HVM guests. The range being UC in particular
> >> gets in the way of OVMF, which places itself at [FFE00000,FFFFFFFF].
> > I would assume this range to be unpopulated? Does hvmloader populate
> > it in order to place ovmf?
> 
> It's generally not unpopulated.  The video RAM lives there until the VGA
> BAR is reprogrammed.

Right, but that's an MMIO area from guests PoV, even if in our
implementation is backed by RAM pages.

> The reason OVMF places itself there is because it is where the real SPI
> ROM is mapped in address space on a real system.

Just to clarify my understanding, this is not reported as a RAM region
to guests? So hvmloader or the domain builder populates this with RAM
to place OVMF, even if not reported as a RAM region in the memory map
(much like with ACPI tables for example).

I wonder whether we should have some kind of document or code comment
about the guest memory layout (maybe there's one and I'm missing it).

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:17:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:17:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247879.427472 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxolA-0005wK-Iz; Thu, 16 Dec 2021 11:17:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247879.427472; Thu, 16 Dec 2021 11:17:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxolA-0005wD-Fo; Thu, 16 Dec 2021 11:17:16 +0000
Received: by outflank-mailman (input) for mailman id 247879;
 Thu, 16 Dec 2021 11:17:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxol9-0005w7-7f
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:17:15 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b7db1f22-5e61-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:17:13 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44402)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxol6-000M1T-2i (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:17:12 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 985681FAC8;
 Thu, 16 Dec 2021 11:17:12 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b7db1f22-5e61-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <e4c8e8e7-b326-c201-24bc-44c25c0aafe0@srcf.net>
Date: Thu, 16 Dec 2021 11:17:12 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
References: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
 <YbsMwIYFULP5sXQP@Air-de-Roger>
 <cb9bea36-9feb-dbc7-ce36-38fd42792f11@srcf.net>
 <YbseXUE0byGJCzsy@Air-de-Roger>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should
 be UC"
In-Reply-To: <YbseXUE0byGJCzsy@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 11:09, Roger Pau Monné wrote:
> On Thu, Dec 16, 2021 at 11:00:17AM +0000, Andrew Cooper wrote:
>> On 16/12/2021 09:54, Roger Pau Monné wrote:
>>> On Tue, Dec 14, 2021 at 09:21:22AM +0100, Jan Beulich wrote:
>>>> This reverts commit c22bd567ce22f6ad9bd93318ad0d7fd1c2eadb0d.
>>>>
>>>> While its description is correct from an abstract or real hardware pov,
>>>> the range is special inside HVM guests. The range being UC in particular
>>>> gets in the way of OVMF, which places itself at [FFE00000,FFFFFFFF].
>>> I would assume this range to be unpopulated? Does hvmloader populate
>>> it in order to place ovmf?
>> It's generally not unpopulated.  The video RAM lives there until the VGA
>> BAR is reprogrammed.
> Right, but that's an MMIO area from guests PoV, even if in our
> implementation is backed by RAM pages.
>
>> The reason OVMF places itself there is because it is where the real SPI
>> ROM is mapped in address space on a real system.
> Just to clarify my understanding, this is not reported as a RAM region
> to guests? So hvmloader or the domain builder populates this with RAM
> to place OVMF, even if not reported as a RAM region in the memory map
> (much like with ACPI tables for example).
>
> I wonder whether we should have some kind of document or code comment
> about the guest memory layout (maybe there's one and I'm missing it).

Like most things with guest physmap handling, it's broken and held
together with hope.

Yes, it's logically an MMIO region, but actually "just plain RAM" under
the hood.

What should happen is the domain builder place OVMF there directly. 
OVMF is linked to run there, and there ought to be no hvmloader involved
for UEFI guests, and there shouldn't be any copying into place
required.  That was a very short sited move on behalf of the OVMF
support logic, and I guarantee you that it creates more problems than it
allegedly solves.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:18:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:18:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247883.427482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxomC-0006V0-So; Thu, 16 Dec 2021 11:18:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247883.427482; Thu, 16 Dec 2021 11:18:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxomC-0006Ut-Pi; Thu, 16 Dec 2021 11:18:20 +0000
Received: by outflank-mailman (input) for mailman id 247883;
 Thu, 16 Dec 2021 11:18:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxomB-0006Uf-Jj
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:18:19 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id de41b533-5e61-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 12:18:18 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44406)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxom1-000MFY-01 (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:18:09 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id AC7B51FAC8;
 Thu, 16 Dec 2021 11:18:08 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: de41b533-5e61-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <f8709d9b-cda0-323d-4e06-dc21ee3093c5@srcf.net>
Date: Thu, 16 Dec 2021 11:18:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-35-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [XEN PATCH v8 34/47] build: add %.E targets
In-Reply-To: <20211125134006.1076646-35-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 25/11/2021 13:39, Anthony PERARD wrote:
> I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  xen/Makefile | 4 ++--
>  xen/Rules.mk | 5 +++++
>  2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/xen/Makefile b/xen/Makefile
> index 995815e82235..e39a6f82859a 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -609,10 +609,10 @@ cscope:
>  _MAP:
>  	$(NM) -n $(TARGET)-syms | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' > System.map
>  
> -%.o %.i %.s: %.c tools_fixdep FORCE
> +%.o %.i %.s %.E: %.c tools_fixdep FORCE
>  	$(Q)$(MAKE) $(build)=$(*D) $(*D)/$(@F)

So what I hadn't realised when asking was that Linux calls this .i and
we've already got support for what I wanted.  Sorry :)

Thus, I suspect we probably don't want to take an extra %.E alias to the
existing %.i, although...

>  
> -%.o %.s: %.S tools_fixdep FORCE
> +%.o %.s %.E: %.S tools_fixdep FORCE
>  	$(Q)$(MAKE) $(build)=$(*D) $(*D)/$(@F)
>  
>  %/: tools_fixdep FORCE
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 73d5b82ab2e7..745d892d0707 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -287,6 +287,11 @@ $(obj)/%.s: $(src)/%.c FORCE
>  $(obj)/%.s: $(src)/%.S FORCE
>  	$(call if_changed_dep,cpp_s_S)
>  
> +$(obj)/%.E: $(src)/%.c FORCE
> +	$(call if_changed_dep,cpp_i_c)
> +$(obj)/%.E: $(src)/%.S FORCE
> +	$(call if_changed_dep,cpp_s_S)

... I don't currently see support for %.i from %.S in the tree.  That
one probably would be useful to introduce.

~Andrew

> +
>  # Linker scripts, .lds.S -> .lds
>  quiet_cmd_cpp_lds_S = LDS     $@
>  cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -DLINKER_SCRIPT -MQ $@ -o $@ $<



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:28:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:28:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247889.427493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxovn-0008EL-Tv; Thu, 16 Dec 2021 11:28:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247889.427493; Thu, 16 Dec 2021 11:28:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxovn-0008EE-R0; Thu, 16 Dec 2021 11:28:15 +0000
Received: by outflank-mailman (input) for mailman id 247889;
 Thu, 16 Dec 2021 11:28:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxovm-0008E8-Qr
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:28:14 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 41aeb9bd-5e63-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:28:14 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44412)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxovl-000Pbq-1g (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:28:13 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 4B8B51FA9B;
 Thu, 16 Dec 2021 11:28:13 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 41aeb9bd-5e63-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <31e80b07-9352-b122-da06-3a73ce0dc426@srcf.net>
Date: Thu, 16 Dec 2021 11:28:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] hvmloader: tidy pci_mem_{start,end}
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <35cc5395-f88e-f08a-cbaf-5938a508ff29@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <35cc5395-f88e-f08a-cbaf-5938a508ff29@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 14/12/2021 08:24, Jan Beulich wrote:
> For one at least pci_mem_start has to be precisely 32 bits wide, so use
> uint32_t for both. Otherwise expressions like "pci_mem_start <<= 1"
> won't have the intended effect (in their context).
>
> Further since its introduction pci_mem_end was never written to. Mark it
> const to make this explicit.
>
> Finally drop PCI_MEM_END: It is used just once and needlessly
> disconnected from the other constant (RESERVED_MEMBASE) it needs to
> match. Use RESERVED_MEMBASE as initializer of pci_mem_end instead.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:31:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:31:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247894.427505 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoyW-0001KZ-CA; Thu, 16 Dec 2021 11:31:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247894.427505; Thu, 16 Dec 2021 11:31:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxoyW-0001KS-8k; Thu, 16 Dec 2021 11:31:04 +0000
Received: by outflank-mailman (input) for mailman id 247894;
 Thu, 16 Dec 2021 11:31:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HYuw=RB=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mxoyU-0001KM-T2
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:31:03 +0000
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02on0601.outbound.protection.outlook.com
 [2a01:111:f400:fe06::601])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a46f5d2d-5e63-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:31:00 +0100 (CET)
Received: from DB6PR0301CA0059.eurprd03.prod.outlook.com (2603:10a6:4:54::27)
 by DB7PR08MB3289.eurprd08.prod.outlook.com (2603:10a6:5:26::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 11:30:55 +0000
Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:54:cafe::de) by DB6PR0301CA0059.outlook.office365.com
 (2603:10a6:4:54::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Thu, 16 Dec 2021 11:30:55 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Thu, 16 Dec 2021 11:30:55 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Thu, 16 Dec 2021 11:30:55 +0000
Received: from c8f0b5e383f0.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 099F4F28-9D2B-4340-8C96-FAA677DEE524.1; 
 Thu, 16 Dec 2021 11:30:34 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c8f0b5e383f0.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Thu, 16 Dec 2021 11:30:34 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com (2603:10a6:20b:307::13)
 by AM0PR08MB5476.eurprd08.prod.outlook.com (2603:10a6:208:18d::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.12; Thu, 16 Dec
 2021 11:30:32 +0000
Received: from AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13]) by AM9PR08MB6914.eurprd08.prod.outlook.com
 ([fe80::b1d3:4778:2574:bc13%6]) with mapi id 15.20.4801.015; Thu, 16 Dec 2021
 11:30:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a46f5d2d-5e63-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u7u5O+e1vbBK78KSwulSnpVGctIkElmTLUFIdTFYTZk=;
 b=XQz0IF3loNkKRrnIb0t5o7K7wvT/jfWP7WNrtylRElJNEpzFxzOuZWeya9L8GSDoZRfNjVg4M6L04G2REloeNdIiYZdUzFwfbiLsVrNP1Db36B0auvNwHeGL2MatD91VMbWr3J9bSkNOHIbmRkQ3K14PMCnEn+Gg4hin3efJlcc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f4f597e78484f184
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=eI8GMKvKyKZKgopZeyWhJCwzxBGBahf1d61IANTJqC/2XOYgY/6jrxF4XZdOoqKuGBX0o+xYHOPePQKL3hReiQXqY8+Mo00aMIDyVYVNAKJ1oS8K8wsUmcDu3mVQ+2LraUlL8BH1o+bnnD8ceh/qT0Mdle4AgW9MiL88VuUGoc8Q/RItQxhbebfyOSoUl/KFnNpuMbpu88s5lYgyo23h4nyVKGqovuHmRa1GHKZbWME5/2XjBdd4wH3IMWIgvQVYElFNAwknkkiO5LPd//x0UXBdb6KHyWe7PX+Rycc2411RYj4tAXNd59u+9JYSMkvsshz6IB3t/spZtDEUmXzR8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=u7u5O+e1vbBK78KSwulSnpVGctIkElmTLUFIdTFYTZk=;
 b=jEcN0BEo7V3ETAmaG+jqbffOelrko4EJmmlJfvEVihYZQx0LOSJ22xULcDN2I5Bj6MpvzCxuLjhrppaJMbhZenYpSi0W6iR+Q30YNJE12deR4CTQMtnyXTQFRZPgsNxIctp6j3zC+lZ/a6PGQbgXnn0aGEEz2OobU0NdfqVKDN+HuF2VLUT3Rbeic4hPrCHbq28olCz/Mel8nXIjIYskDHs9Hq/0IeUR374shCD8EpZhUmwSBFpKyu5M5CwISTpaGKgU/x3YUIqWUJQh+VEg5AahB/CHuQ0I9sYNAkEjbwfBBPZaMS3/qi6A8rWB1ycA5KYgc/iEPN5Vq1nxSUUYmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=u7u5O+e1vbBK78KSwulSnpVGctIkElmTLUFIdTFYTZk=;
 b=XQz0IF3loNkKRrnIb0t5o7K7wvT/jfWP7WNrtylRElJNEpzFxzOuZWeya9L8GSDoZRfNjVg4M6L04G2REloeNdIiYZdUzFwfbiLsVrNP1Db36B0auvNwHeGL2MatD91VMbWr3J9bSkNOHIbmRkQ3K14PMCnEn+Gg4hin3efJlcc=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Thread-Topic: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Thread-Index: AQHXsSolt8slMIplQ0OX3IGr7nYpn6w1flcA
Date: Thu, 16 Dec 2021 11:30:32 +0000
Message-ID: <40CD83D3-4D85-44BA-8F21-969B544267CA@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
In-Reply-To: <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: f777f524-aee3-4a90-4084-08d9c0878642
x-ms-traffictypediagnostic:
	AM0PR08MB5476:EE_|DB5EUR03FT034:EE_|DB7PR08MB3289:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3289E440D0D5500877898076FC779@DB7PR08MB3289.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 uFbmvoYRH9k+vQDgCjj9zOeAwF1QfiPSXxWvwpszAZybP5MvEBwtuNczVlDTLsvbygDQWV5GqMz56+72kLZSUpDe5gLeulvyHm67FOkXmX3pUbusLbXMDuEuW+9xnD42CvDvrMBuaUUJXEGa5yWJUQ1rWnWtUyeVAxAObebUzBtUsjvAKDvMrw5ofVZSv4NSJbDvH+BbvNG/8XESYi9tB+cXfdUgNzI9/eH5rNFAx1l7PSLQqj3558RLVZqnWCXt+9DGm7P5R7POLQm+KeQ1EEopixyEaehAmk5UhhCbTI4tzgnPzXNRDOD9z9RF/sPKtUspwk+OCxsDqfKqzWDrxX25YSKbK1JjjkPSWpUWHMKxk9IoJ9Ajsxt+h26pVQcS732sh2JJQVzcZj++7vQa76mR/PlOV3FZLjwe1Jog1gYLbb31AcCLrkcz5sx0WmPh4khh1osr3VCW0pZPnbpvEhDVWxpMghJIQJRBdEEgwZCECJkG6kh9xxsi91d/yHgjVdQSVv4EluE0KboWixv68BGLbP+Oh6TC83H1eictvwOoxbMZEyQHeddBazYqjibmwQ0cHTK55jQ7s2LYBAXGSo+SWVBwi4131IsAgk0Ymahhjbb8Ws29CNoJT6bG6Kq/niqZ+kLE9o41WtPqpmH/csmtDjsH8tBaxyKAMHmaNrgzPZCf/7q3xmTyEGUD+S5b7A4pDTq6sGHTBXxj02RlpIIJZcc4qwFiOs5PYt1N8Yt69MBLcYK61UjJPSSoV9LR
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB6914.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(33656002)(66446008)(76116006)(64756008)(91956017)(66476007)(66556008)(6512007)(508600001)(71200400001)(186003)(26005)(5660300002)(2616005)(2906002)(86362001)(66946007)(38100700002)(316002)(38070700005)(6506007)(4326008)(8676002)(6916009)(36756003)(8936002)(53546011)(6486002)(54906003)(83380400001)(122000001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15DE69ED21EAAC4A98DE9282C74F0DC2@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5476
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6684a356-09e1-4cca-6983-08d9c087788b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QPYGdJXCgzGPc8GH4IvkCEwBr1u1diFCY8ZfCrUbjTEwWudsL/fIwE6bwB4WjMGyF8CdDEqQx4FnKKIxZqndJtPsxXVLLPSHPU30N3vF1r+VWLQ6vq1NAujD2Y/ByliO/SJwySqM3aw4NMCidFJKbR15S5Kfy+KmbJ0ys/WCviiXEPWMLBo+bPKNI92AJ7hXGmXy/fYrHQrSxQMpVkP/Ilayj8ynrxXBBXq3tYxojnyHGxDYnCvNhK/OPaUF2ALEtlkjqN3SWMsOOi8xF7mJt1y0FvPQrhv9EaDxaO85MhFZZZHzQNnFbgxxye4yLHWP4GeMdVrstNcmjRQQ0Bc2A2CnMXGOdkRjWSmcH1ZQ06rrl9BpBLXLxxq+Tm9CRgKtwJ6V4A91gQFdg2HeFVlvXCFXGHtLvJW04Eg7qRhC9aZ7M8/O24Ga2ROOfQflfRz6wY+ME9Zfu4eH3IJ2+lV3CHAT//iaQCd3NsR082Upe+6CcSkYqXvza1jtYpIR5FNHHYaAqG+zyvN/wFy8+iZ4Aloie4l8VpzsUYzglnRynk/aqwgJODPdFeepFJbEyouhMJ4n+oVhCpbxSzeKyWLpuUvCyk+0Z5FkbP4JYD2++qx3ya8Ja4ybE2B77p3kpNCSdCtbV+N4wGyc9T1hCgaYM4Bv8XIstOoYIgjC9ufFHbYMmj0wrq+bi+OhYBuk+gC2G+hds4b/moqZ4cFyWEuNGz/32+ibk1Dbz1K9W3IQ19yLJvi8ATz710e6RlLs52NXDQ5UsJp1PYI2/wmxZuDhOg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(36860700001)(86362001)(356005)(2906002)(83380400001)(40460700001)(508600001)(53546011)(316002)(82310400004)(54906003)(5660300002)(81166007)(70206006)(47076005)(33656002)(4326008)(8936002)(6486002)(26005)(8676002)(36756003)(186003)(6862004)(336012)(2616005)(6512007)(70586007)(6506007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 11:30:55.5242
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f777f524-aee3-4a90-4084-08d9c0878642
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3289

Hi Jan

> On 24 Sep 2021, at 10:53 am, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> Having a separate flush-all hook has always been puzzling me some. We
> will want to be able to force a full flush via accumulated flush flags
> from the map/unmap functions. Introduce a respective new flag and fold
> all flush handling to use the single remaining hook.
>=20
> Note that because of the respective comments in SMMU and IPMMU-VMSA
> code, I've folded the two prior hook functions into one. For SMMU-v3,
> which lacks a comment towards incapable hardware, I've left both
> functions in place on the assumption that selective and full flushes
> will eventually want separating.


For SMMUv3 related Changs:
Reviewed-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> TBD: What we really are going to need is for the map/unmap functions to
>     specify that a wider region needs flushing than just the one
>     covered by the present set of (un)maps. This may still be less than
>     a full flush, but at least as a first step it seemed better to me
>     to keep things simple and go the flush-all route.
> ---
> v2: New.
>=20
> --- a/xen/drivers/passthrough/amd/iommu.h
> +++ b/xen/drivers/passthrough/amd/iommu.h
> @@ -242,7 +242,6 @@ int amd_iommu_get_reserved_device_memory
> int __must_check amd_iommu_flush_iotlb_pages(struct domain *d, dfn_t dfn,
>                                              unsigned long page_count,
>                                              unsigned int flush_flags);
> -int __must_check amd_iommu_flush_iotlb_all(struct domain *d);
> void amd_iommu_print_entries(const struct amd_iommu *iommu, unsigned int =
dev_id,
>                              dfn_t dfn);
>=20
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -475,15 +475,18 @@ int amd_iommu_flush_iotlb_pages(struct d
> {
>     unsigned long dfn_l =3D dfn_x(dfn);
>=20
> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> -    ASSERT(flush_flags);
> +    if ( !(flush_flags & IOMMU_FLUSHF_all) )
> +    {
> +        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> +        ASSERT(flush_flags);
> +    }
>=20
>     /* Unless a PTE was modified, no flush is required */
>     if ( !(flush_flags & IOMMU_FLUSHF_modified) )
>         return 0;
>=20
> -    /* If the range wraps then just flush everything */
> -    if ( dfn_l + page_count < dfn_l )
> +    /* If so requested or if the range wraps then just flush everything.=
 */
> +    if ( (flush_flags & IOMMU_FLUSHF_all) || dfn_l + page_count < dfn_l =
)
>     {
>         amd_iommu_flush_all_pages(d);
>         return 0;
> @@ -508,13 +511,6 @@ int amd_iommu_flush_iotlb_pages(struct d
>=20
>     return 0;
> }
> -
> -int amd_iommu_flush_iotlb_all(struct domain *d)
> -{
> -    amd_iommu_flush_all_pages(d);
> -
> -    return 0;
> -}
>=20
> int amd_iommu_reserve_domain_unity_map(struct domain *d,
>                                        const struct ivrs_unity_map *map,
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -642,7 +642,6 @@ static const struct iommu_ops __initcons
>     .map_page =3D amd_iommu_map_page,
>     .unmap_page =3D amd_iommu_unmap_page,
>     .iotlb_flush =3D amd_iommu_flush_iotlb_pages,
> -    .iotlb_flush_all =3D amd_iommu_flush_iotlb_all,
>     .reassign_device =3D reassign_device,
>     .get_device_group_id =3D amd_iommu_group_id,
>     .enable_x2apic =3D iov_enable_xt,
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -930,13 +930,19 @@ out:
> }
>=20
> /* Xen IOMMU ops */
> -static int __must_check ipmmu_iotlb_flush_all(struct domain *d)
> +static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
> +                                          unsigned long page_count,
> +                                          unsigned int flush_flags)
> {
>     struct ipmmu_vmsa_xen_domain *xen_domain =3D dom_iommu(d)->arch.priv;
>=20
> +    ASSERT(flush_flags);
> +
>     if ( !xen_domain || !xen_domain->root_domain )
>         return 0;
>=20
> +    /* The hardware doesn't support selective TLB flush. */
> +
>     spin_lock(&xen_domain->lock);
>     ipmmu_tlb_invalidate(xen_domain->root_domain);
>     spin_unlock(&xen_domain->lock);
> @@ -944,16 +950,6 @@ static int __must_check ipmmu_iotlb_flus
>     return 0;
> }
>=20
> -static int __must_check ipmmu_iotlb_flush(struct domain *d, dfn_t dfn,
> -                                          unsigned long page_count,
> -                                          unsigned int flush_flags)
> -{
> -    ASSERT(flush_flags);
> -
> -    /* The hardware doesn't support selective TLB flush. */
> -    return ipmmu_iotlb_flush_all(d);
> -}
> -
> static struct ipmmu_vmsa_domain *ipmmu_get_cache_domain(struct domain *d,
>                                                         struct device *de=
v)
> {
> @@ -1303,7 +1299,6 @@ static const struct iommu_ops ipmmu_iomm
>     .hwdom_init      =3D ipmmu_iommu_hwdom_init,
>     .teardown        =3D ipmmu_iommu_domain_teardown,
>     .iotlb_flush     =3D ipmmu_iotlb_flush,
> -    .iotlb_flush_all =3D ipmmu_iotlb_flush_all,
>     .assign_device   =3D ipmmu_assign_device,
>     .reassign_device =3D ipmmu_reassign_device,
>     .map_page        =3D arm_iommu_map_page,
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2649,11 +2649,17 @@ static int force_stage =3D 2;
>  */
> static u32 platform_features =3D ARM_SMMU_FEAT_COHERENT_WALK;
>=20
> -static int __must_check arm_smmu_iotlb_flush_all(struct domain *d)
> +static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn=
,
> +					     unsigned long page_count,
> +					     unsigned int flush_flags)
> {
> 	struct arm_smmu_xen_domain *smmu_domain =3D dom_iommu(d)->arch.priv;
> 	struct iommu_domain *cfg;
>=20
> +	ASSERT(flush_flags);
> +
> +	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
> +
> 	spin_lock(&smmu_domain->lock);
> 	list_for_each_entry(cfg, &smmu_domain->contexts, list) {
> 		/*
> @@ -2670,16 +2676,6 @@ static int __must_check arm_smmu_iotlb_f
> 	return 0;
> }
>=20
> -static int __must_check arm_smmu_iotlb_flush(struct domain *d, dfn_t dfn=
,
> -					     unsigned long page_count,
> -					     unsigned int flush_flags)
> -{
> -	ASSERT(flush_flags);
> -
> -	/* ARM SMMU v1 doesn't have flush by VMA and VMID */
> -	return arm_smmu_iotlb_flush_all(d);
> -}
> -
> static struct iommu_domain *arm_smmu_get_domain(struct domain *d,
> 						struct device *dev)
> {
> @@ -2879,7 +2875,6 @@ static const struct iommu_ops arm_smmu_i
>     .add_device =3D arm_smmu_dt_add_device_generic,
>     .teardown =3D arm_smmu_iommu_domain_teardown,
>     .iotlb_flush =3D arm_smmu_iotlb_flush,
> -    .iotlb_flush_all =3D arm_smmu_iotlb_flush_all,
>     .assign_device =3D arm_smmu_assign_dev,
>     .reassign_device =3D arm_smmu_reassign_dev,
>     .map_page =3D arm_iommu_map_page,
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -3431,7 +3431,6 @@ static const struct iommu_ops arm_smmu_i
> 	.hwdom_init		=3D arm_smmu_iommu_hwdom_init,
> 	.teardown		=3D arm_smmu_iommu_xen_domain_teardown,
> 	.iotlb_flush		=3D arm_smmu_iotlb_flush,
> -	.iotlb_flush_all	=3D arm_smmu_iotlb_flush_all,
> 	.assign_device		=3D arm_smmu_assign_dev,
> 	.reassign_device	=3D arm_smmu_reassign_dev,
> 	.map_page		=3D arm_iommu_map_page,
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -463,15 +463,12 @@ int iommu_iotlb_flush_all(struct domain
>     const struct domain_iommu *hd =3D dom_iommu(d);
>     int rc;
>=20
> -    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush_all ||
> +    if ( !is_iommu_enabled(d) || !hd->platform_ops->iotlb_flush ||
>          !flush_flags )
>         return 0;
>=20
> -    /*
> -     * The operation does a full flush so we don't need to pass the
> -     * flush_flags in.
> -     */
> -    rc =3D iommu_call(hd->platform_ops, iotlb_flush_all, d);
> +    rc =3D iommu_call(hd->platform_ops, iotlb_flush, d, INVALID_DFN, 0,
> +                    flush_flags | IOMMU_FLUSHF_all);
>     if ( unlikely(rc) )
>     {
>         if ( !d->is_shutting_down && printk_ratelimit() )
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -731,18 +731,21 @@ static int __must_check iommu_flush_iotl
>                                                 unsigned long page_count,
>                                                 unsigned int flush_flags)
> {
> -    ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> -    ASSERT(flush_flags);
> +    if ( flush_flags & IOMMU_FLUSHF_all )
> +    {
> +        dfn =3D INVALID_DFN;
> +        page_count =3D 0;
> +    }
> +    else
> +    {
> +        ASSERT(page_count && !dfn_eq(dfn, INVALID_DFN));
> +        ASSERT(flush_flags);
> +    }
>=20
>     return iommu_flush_iotlb(d, dfn, flush_flags & IOMMU_FLUSHF_modified,
>                              page_count);
> }
>=20
> -static int __must_check iommu_flush_iotlb_all(struct domain *d)
> -{
> -    return iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
> -}
> -
> static void queue_free_pt(struct domain *d, mfn_t mfn, unsigned int next_=
level)
> {
>     if ( next_level > 1 )
> @@ -2841,7 +2844,7 @@ static int __init intel_iommu_quarantine
>     spin_unlock(&hd->arch.mapping_lock);
>=20
>     if ( !rc )
> -        rc =3D iommu_flush_iotlb_all(d);
> +        rc =3D iommu_flush_iotlb(d, INVALID_DFN, 0, 0);
>=20
>     /* Pages may be leaked in failure case */
>     return rc;
> @@ -2874,7 +2877,6 @@ static struct iommu_ops __initdata vtd_o
>     .resume =3D vtd_resume,
>     .crash_shutdown =3D vtd_crash_shutdown,
>     .iotlb_flush =3D iommu_flush_iotlb_pages,
> -    .iotlb_flush_all =3D iommu_flush_iotlb_all,
>     .get_reserved_device_memory =3D intel_iommu_get_reserved_device_memor=
y,
>     .dump_page_tables =3D vtd_dump_page_tables,
> };
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -147,9 +147,11 @@ enum
> {
>     _IOMMU_FLUSHF_added,
>     _IOMMU_FLUSHF_modified,
> +    _IOMMU_FLUSHF_all,
> };
> #define IOMMU_FLUSHF_added (1u << _IOMMU_FLUSHF_added)
> #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified)
> +#define IOMMU_FLUSHF_all (1u << _IOMMU_FLUSHF_all)
>=20
> int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn,
>                            unsigned long page_count, unsigned int flags,
> @@ -282,7 +284,6 @@ struct iommu_ops {
>     int __must_check (*iotlb_flush)(struct domain *d, dfn_t dfn,
>                                     unsigned long page_count,
>                                     unsigned int flush_flags);
> -    int __must_check (*iotlb_flush_all)(struct domain *d);
>     int (*get_reserved_device_memory)(iommu_grdm_t *, void *);
>     void (*dump_page_tables)(struct domain *d);
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:47:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:47:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247898.427516 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpEU-00033e-Ri; Thu, 16 Dec 2021 11:47:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247898.427516; Thu, 16 Dec 2021 11:47:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpEU-00033X-NY; Thu, 16 Dec 2021 11:47:34 +0000
Received: by outflank-mailman (input) for mailman id 247898;
 Thu, 16 Dec 2021 11:47:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxpET-00033R-2Y
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:47:33 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id f3c44a7b-5e65-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:47:31 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43884)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxpEQ-000rt9-if (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:47:30 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A5DB11FA9B;
 Thu, 16 Dec 2021 11:47:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f3c44a7b-5e65-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <0d19228e-e2c1-03cb-d78a-c7cd1c4c4866@srcf.net>
Date: Thu, 16 Dec 2021 11:47:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 15/57] tools/libacpi: cleanup Makefile, don't check
 for iasl binary
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>, Jan Beulich
 <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-16-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-16-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:01, Anthony PERARD wrote:
> iasl is been check for presence by ./configure, so this Makefile
> doesn't have to do it. Also start to use $(IASL) that ./configure
> generate.
>
> iasl hasn't been download by our build system for a while and the
> dependency on iasl is in the main xen.git README.
>
> Make use of $< in one rule instead of spelling the %.asl file again.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:54:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:54:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247904.427527 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpLF-0004dw-Hd; Thu, 16 Dec 2021 11:54:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247904.427527; Thu, 16 Dec 2021 11:54:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpLF-0004dp-Dn; Thu, 16 Dec 2021 11:54:33 +0000
Received: by outflank-mailman (input) for mailman id 247904;
 Thu, 16 Dec 2021 11:54:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxpLD-0004dj-9W
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:54:31 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ece3a03e-5e66-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:54:30 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47032)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxpLB-00077X-mt (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:54:29 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D83041FA47;
 Thu, 16 Dec 2021 11:54:28 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ece3a03e-5e66-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <ff12f0df-a2c4-ae9b-b956-a602cc0bb844@srcf.net>
Date: Thu, 16 Dec 2021 11:54:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <e717897f-980d-ad44-31d9-39f5e7e1c45e@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] x86: enable interrupts around dump_execstate()
In-Reply-To: <e717897f-980d-ad44-31d9-39f5e7e1c45e@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 13/12/2021 15:12, Jan Beulich wrote:
> show_hvm_stack() requires interrupts to be enabled to avoids triggering
> the consistency check in check_lock() for the p2m lock. To do so in
> spurious_interrupt() requires adding reentrancy protection / handling
> there.
>
> Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_state()")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> The obvious (but imo undesirable) alternative is to suppress the call to
> show_hvm_stack() when interrupts are disabled.

show_execution_state() need to work in any context including the #DF
handler, and

    /*
     * Stop interleaving prevention: The necessary P2M lookups
     * involve locking, which has to occur with IRQs enabled.
     */
    console_unlock_recursive_irqrestore(flags);
    
    show_hvm_stack(curr, regs);

is looking distinctly dodgy...

For these kinds of purposes, it ought to be entirely fine to do a
lockless pagewalk of the p2m, because we have to maintain atomicity of
updates vs the hardware pagewalk anyway.  We do not care about any side
effects if the target isn't a RAM page.

That ought to remove any IRQ problems from the equation.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:56:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:56:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247910.427538 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpNS-0005Hs-0p; Thu, 16 Dec 2021 11:56:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247910.427538; Thu, 16 Dec 2021 11:56:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpNR-0005Hl-UF; Thu, 16 Dec 2021 11:56:49 +0000
Received: by outflank-mailman (input) for mailman id 247910;
 Thu, 16 Dec 2021 11:56:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxpNQ-0005Hf-Vz
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:56:48 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3df9fb42-5e67-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:56:48 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43346)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxpNN-000LCm-7d (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 11:56:45 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 201301FAC8;
 Thu, 16 Dec 2021 11:56:45 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3df9fb42-5e67-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <948d4e68-5c8d-77c7-7ec1-56908248b185@srcf.net>
Date: Thu, 16 Dec 2021 11:56:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 3/4] x86/cpuid: Introduce dom0-cpuid command line
 option
Content-Language: en-GB
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-4-andrew.cooper3@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211215222115.6829-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 15/12/2021 22:21, Andrew Cooper wrote:
> diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
> index e11f5a3c9a6b..83a80ba6de70 100644
> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -116,6 +116,23 @@ static int __init parse_xen_cpuid(const char *s)
>  }
>  custom_param("cpuid", parse_xen_cpuid);
>  
> +static bool __initdata dom0_cpuid_cmdline;
> +static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
> +static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
> +
> +static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
> +{
> +    __set_bit(feat, val ? dom0_enable_feat : dom0_disable_feat);

Based on Jan's observation in v1, I've folded this delta in:

diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 83a80ba6de70..39baeae9a6cd 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -122,7 +122,8 @@ static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
 
 static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
 {
-    __set_bit(feat, val ? dom0_enable_feat : dom0_disable_feat);
+    __set_bit  (feat, val ? dom0_enable_feat  : dom0_disable_feat);
+    __clear_bit(feat, val ? dom0_disable_feat : dom0_enable_feat );
 }
 
 static int __init parse_dom0_cpuid(const char *s)

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 11:57:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 11:57:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247911.427549 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpNg-0005ff-A2; Thu, 16 Dec 2021 11:57:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247911.427549; Thu, 16 Dec 2021 11:57:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpNg-0005fY-6F; Thu, 16 Dec 2021 11:57:04 +0000
Received: by outflank-mailman (input) for mailman id 247911;
 Thu, 16 Dec 2021 11:57:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2y9W=RB=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxpNf-0005Hf-2I
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 11:57:03 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 46685283-5e67-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 12:57:01 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 46685283-5e67-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639655821;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=TS9DeW0CdUisb2Wk49Zp6N9aFoSWkq05wyetL3iYFyk=;
  b=CO3XnesXpsWncaTtayB/ff72ZhUxFYT1q7Xa69aJJmG+OQlJGmLBKd9T
   sz+iiDqnrGdv9C0h1MNdQ6+lp6EjU1hNSDWmxSHGI1CeSTAR0voWjsgHn
   Wby5yR83MlMXSxGdJSczRV1rBjUOgQlmndWI3w8zbOUkNHpJH7GZSR/9o
   I=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: YdpmVzQH6masygScM8zQm0FbxP628vEcNRd2xen9+kOKrPgxc9Alfe8f5F/UP99gv7SNB0ONNO
 YgjzSbr2Xe2JNJ3UEeanifeIGUDu+Tdl5eYvoFn8gXDlninLSlr3MfhHtPUJwq//BQbCusfUyS
 5Af8wdvfHF60G0fHh3X+hC8oRDR53G5hrJqGVZJqJs0jPjT8E2DSE4RpROxDpJeGU/E1M16dr2
 DtQ0y7lbnmGrHnrSd4zWxIDT+UB1A0DskLYl2+LumwHN9FmU+FJBXQL+eG7FQCsJMDY/O565DP
 yDD9WUJWWRgydTHbHAb3YKdR
X-SBRS: 5.1
X-MesageID: 59671004
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:fgOjuKMJLPkZm9vvrR01kMFynXyQoLVcMsEvi/4bfWQNrUoigTEHz
 GMbC2jQMq2Na2Shc98kbI/koRkOvJGAmtBkQAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400s9w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozG1huEuk
 PFPjrmXVT0PEavLoLwxYwYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgWZu2ZkWRaq2i
 8wxaiEyaybncThzPGw0S5llsOuEhiC8fGgNwL6SjfVuuDWCpOBr65DvLd7Ud9qiVchT2EGCq
 Qru5H/lCxsXMNiezzut8X+2gOLL2yThV+o6C7mQ5vNsxlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El80iMrpvls3FexRde7WRCkyFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebT011
 HeZktXxHzttvbaJD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznSup6IfHtqt/OPBbs+
 Ralqi8G35kjkptev0mkxmzvjzWpr5nPawc64ATLQ26ohj9EiJ6Zi5+AsgaCs6sZRGqNZhzY5
 SVfxZDChAwbJcjVzHTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj
 K375VM5CHx7ZiLCgUpLj2SZUZ5CIU/IT4uNaxwsRoASCqWdjSfelM2UWWae3nr2jG8nmrwlN
 JGQfK6EVChBWPk2l2XmGr1FitfHIxzSI0uJH/gXKDz9jtKjiIO9E+9ZYDNikMhnhE97nOkl2
 4kGbJbbo/mueOb/fjPW4eYuwaMidhAG6WTNg5UPLIare1M+cEl4UqO56e5xKuRNwvUO/s+Vr
 y7VZ6Ot4Aem7ZExAV7RMS4LhXKGdcsXkE/XygRwZwv1gCZ6Pt70hErdHrNuFYQaGCVY5aYcZ
 5E4lw+oW60npu3v92tPYJ/jgpZlcRj31wuCMzD8OGo0foJ6RhyP8djhJ1O9+C4LByuxlM0/v
 7z/iV+LHctdH1xvXJTMdfai71KtpnxByuh8aFTFf4tIc0L2/Yk0dyGo1q0rI9sBIAnozyeB0
 1rEGg8RoOTA+tdn8NTAia2egZ2uFu9yQhhTE2XBtO7kPijG5Guzh4RHVb/QLzzaUWr1/oSkZ
 PlUkK6gYKFWwg4SvtMlQbhxzK8469/+nJNgz1xpTCfRclCmKrJ8OX3aj8NBgbJAm+1CsgysV
 0PRptQDYeeVONnoGUI6LRY+arjRzukdnzTf4KhnIEj+4yMrrrOLXV8LYkuJgS1ZarB0LJkk0
 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxKUpX2jgcLy01ZZc2OAyD715iDdtFQPxR4O
 TSTnqfD2+xRy0eqn6DfzpQRMT6xXagzhS0=
IronPort-HdrOrdr: A9a23:fw5vn6vc4jln8uO0P80aIIRb7skDTtV00zEX/kB9WHVpmszxra
 GTddAgpHjJYVEqKRcdcLG7Sc29qBznmaKdjbN/AV7mZniehILKFvAG0WKB+UyCJ8SWzIc0vs
 0MT0E9MqyTMbETt7eD3ODSKbYdKbe8npyVuQ==
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="59671004"
Date: Thu, 16 Dec 2021 11:56:36 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH v8 34/47] build: add %.E targets
Message-ID: <YbspdIfG8P9FK99W@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-35-anthony.perard@citrix.com>
 <f8709d9b-cda0-323d-4e06-dc21ee3093c5@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f8709d9b-cda0-323d-4e06-dc21ee3093c5@srcf.net>

On Thu, Dec 16, 2021 at 11:18:08AM +0000, Andrew Cooper wrote:
> On 25/11/2021 13:39, Anthony PERARD wrote:
> > I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".
> >
> > -%.o %.i %.s: %.c tools_fixdep FORCE
> > +%.o %.i %.s %.E: %.c tools_fixdep FORCE
> >  	$(Q)$(MAKE) $(build)=$(*D) $(*D)/$(@F)
> 
> So what I hadn't realised when asking was that Linux calls this .i and
> we've already got support for what I wanted.� Sorry :)
> 
> Thus, I suspect we probably don't want to take an extra %.E alias to the
> existing %.i, although...
> 
> >  
> > -%.o %.s: %.S tools_fixdep FORCE
> > +%.o %.s %.E: %.S tools_fixdep FORCE

> > +$(obj)/%.E: $(src)/%.c FORCE
> > +	$(call if_changed_dep,cpp_i_c)
> > +$(obj)/%.E: $(src)/%.S FORCE
> > +	$(call if_changed_dep,cpp_s_S)
> 
> ... I don't currently see support for %.i from %.S in the tree.� That
> one probably would be useful to introduce.

It's %.s for %.S, easy ;-)

Yep, %.s may run `gcc -S` or `gcc -E`.
And %.i may run `gcc -E` or may not run at all.

It seems that Linux have the same rules.

So, I guess to run gcc -E, one have to run `make dir/target.i || make
dir/target.s` currently, :-).

Another thing, %.s:%.S was broken for a while, and no one complained.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 12:36:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 12:36:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247927.427560 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpzO-0002Xf-LM; Thu, 16 Dec 2021 12:36:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247927.427560; Thu, 16 Dec 2021 12:36:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxpzO-0002XY-IB; Thu, 16 Dec 2021 12:36:02 +0000
Received: by outflank-mailman (input) for mailman id 247927;
 Thu, 16 Dec 2021 12:36:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UvFT=RB=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mxpzN-0002XS-VI
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 12:36:02 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b85616e2-5e6c-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 13:35:59 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 163965815283657.3094722243668;
 Thu, 16 Dec 2021 04:35:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b85616e2-5e6c-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639658153; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=GtJEsSGxYF9WleIW3w7Bl+PHB9YkSVbKf3C9Y/uevIGmaV3Juxeo0+92slmRUZDjOObQ5AfKKRboyPZbgFvOgeS8OhCxuM/45Dv5WpHYIA+OB/80mQU3RqcGDJpXc7c3mvWJlDBtwmr/KSk2/V2M/UxY+Yo0Gm5piDyy0VQ0dVA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639658153; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=W0m9LoOjMMMtUDWn/i5djot6EpVNM5tkM0hp3ugHTH8=; 
	b=bViq2EfrPo9eK4hHm4dWQp3DzVAY5S3o/OaitjrDSFLWjT+9TEit93Mw1DbTEZK7OMfSOPKGXhhxXz932yvCaJY8w8VXmAqnaSTe7YLq2qHvMKUzcKGmEYdBYnAVVJVIj+AVvVydeCkoaOWXICEJU6eiLmMfvA3XoHx1iRAkANI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639658153;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=W0m9LoOjMMMtUDWn/i5djot6EpVNM5tkM0hp3ugHTH8=;
	b=F7A/mkoZ8+YEUMWi8wAwRIh8ODKH2UB7jr5IiV+OToPimQ/x/PXKjiOBx2XfiAKK
	9kOUeFz3KMOSGDrbbIiLdIDZKBUtt7Y+/xDykOYwov/l8DkPPRqB512H1CGGV8i51C5
	kSx2CIHiRgkdWsj4mjLa0sOfZ5NIaiZe7LUEq2fQ=
Subject: Re: [XEN PATCH 14/57] tools/flask/utils: remove unused
 variables/targets from Makefile
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-15-anthony.perard@citrix.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <2c3e4435-3cf9-b3bb-bdd1-090b8ece2473@apertussolutions.com>
Date: Thu, 16 Dec 2021 07:35:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211206170241.13165-15-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 12/6/21 12:01 PM, Anthony PERARD wrote:
> They are no *.opic or *.so in this subdir, so no need to clean them.
> 
> The TEST* variables doesn't seems to be used anywhere, and they weren't
> used by xen.git when introduced.
> Both CLIENTS_* variables aren't used.
> Both target "print-dir" and "print-end" only exist in this directory
> and are probably not used anywhere.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---

Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 12:36:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 12:36:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247930.427570 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxq0E-00034u-Uo; Thu, 16 Dec 2021 12:36:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247930.427570; Thu, 16 Dec 2021 12:36:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxq0E-00034n-Rm; Thu, 16 Dec 2021 12:36:54 +0000
Received: by outflank-mailman (input) for mailman id 247930;
 Thu, 16 Dec 2021 12:36:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxq0D-000337-HY
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 12:36:53 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d6e8c251-5e6c-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 13:36:50 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44428)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxq02-000qN8-0P (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 12:36:42 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CBE6A1FAC8;
 Thu, 16 Dec 2021 12:36:41 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d6e8c251-5e6c-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5286a1b7-3db5-1e00-f9bf-36fa537871b1@srcf.net>
Date: Thu, 16 Dec 2021 12:36:41 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 14/57] tools/flask/utils: remove unused
 variables/targets from Makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-15-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-15-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:01, Anthony PERARD wrote:
> @@ -35,21 +29,13 @@ flask-set-bool: set-bool.o
>  
>  .PHONY: clean
>  clean: 
> -	rm -f *.o *.opic *.so
> +	rm -f *.o
>  	rm -f $(CLIENTS)
>  	$(RM) $(DEPS_RM)

Can we collapse this to $(RM) *.o $(CLIENTS) $(DEPS_RM) ?

Here and in plenty of subsequent patches, there's manipulation of raw
`rm -f`'s which ought to be cleaned up to $(RM)

I can fix this on commit if you're happy.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 12:49:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 12:49:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247936.427582 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqBx-0004y4-4B; Thu, 16 Dec 2021 12:49:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247936.427582; Thu, 16 Dec 2021 12:49:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqBw-0004x9-VN; Thu, 16 Dec 2021 12:49:00 +0000
Received: by outflank-mailman (input) for mailman id 247936;
 Thu, 16 Dec 2021 12:48:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mgi2=RB=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mxqBv-0004nw-E6
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 12:48:59 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on2072e.outbound.protection.outlook.com
 [2a01:111:f403:700c::72e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 85a60279-5e6e-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 13:48:54 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB4028.jpnprd01.prod.outlook.com (2603:1096:404:d5::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 12:48:49 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 12:48:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 85a60279-5e6e-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gmTGM8oQndh1TL3c24BAP5nAKoz72hhLC+MKlE9AWswK027sVAxnFgtzHV6xLbdGwb+ONY2ln5ynJGTxL53CvZ6eEDJji111e1kvWszWOGIzyRv8w1Wyb/E7UPAIYMNGipBdQGa99FJI3dvovlmtAqOtVLLZQu8wZfDLLOc0gDgqOy1gRrWEp93yZMxrVoMoJkCgTeB6T+jQms/m1BlNBGUs6qc0iufoC4OwX/vMYWt9ff1/FyxkpKG57BBekieaNTYGgaQZo9C8HWysPQ3Tdt8CvXD188Bqq0vg1sRS4cNxkK6LF5gKygBMG4WsJ2axXjXl7qyUL/vik/VcXNCuSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xanxDHtOVtoK9RcZrvDb+Ma9XAGVsvX5rnDtcN8uZIs=;
 b=Zd5J8hOzLQbEe7qBiMQxkfg+tOnS6hGzmjMgieOF6BFrS6VuV/V0ML5ySGEW6In56mKzE8rTBUw5mK17mkPs0WZ4h98BI5xctQUqN2kwYFV+lw7mCN1PhyJ0yVC3j3wE4fchREvJl2OXCvpMXu6l4NvSx5RR+3F6QEqDhhjknAzoaSdCfTMZoLDgK/6QDaw64vnNbeOhQxJ8efQaqGc1a2vjScAyM6GkgN2RKZFOjvICYSXSxmgK8nzC70wURlt99WbElUVUHvCZwPDVBdtO4pwNEnTYlQ+7LbN4RvOjZu3lyVQzhvKfnIphCsiJsLls+jovqIyR2ZDpaYMhVWJi8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xanxDHtOVtoK9RcZrvDb+Ma9XAGVsvX5rnDtcN8uZIs=;
 b=X7BAK+3QQUY9piyUH2Mj0MBtmvsxXdTYKdPi+6JtOqv4kar5WQvyjT3QKBIali2cJeyk+lFK7yoPdjDF6+3JL8nqk8bs+nVGPJxbhkVdUnBBHIM24rB7+d4NP664bzBYxgFQ3Uq5UFtpWZSP1R1ws5zCpUL/o4FF4OAcXDe/pTo=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP
 to 0
Thread-Topic: [PATCH 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP
 to 0
Thread-Index: AQHX47d7pBbIZZ/820Cis1eK882Bi6w1KKuw
Date: Thu, 16 Dec 2021 12:48:49 +0000
Message-ID:
 <TY2PR01MB369226FC51154F6E9BA37886D8779@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-9-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-9-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 455c85e9-c145-4ffb-dd74-08d9c092687a
x-ms-traffictypediagnostic: TY2PR01MB4028:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB402838E7B59FC7D80CDF3686D8779@TY2PR01MB4028.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 bEtjfEyy2ExsS2oc0/OLzWoLkY+vMhfAriDIs7CUoZwDrkJSKqDsz70Ev+NgQ9zVzo/UieT/amF0e+YrShccJwoJPQr+aeqouH5A/Dq7/VJNXFIjwnu+Vhxs7053fee0R8uLBRORyA/98QyXyS/YhWhJs7VFr2JfDlnx5sz3h2dMW96kLYq1bcGwr/SQ0JFUhQfd0/Vre0qqw3/JTDy4w9haeNeaQwJRcYQQplhZfg/TsLVXZIqf/uOl0/8MjeOoiedA7B4Jno9nCGxZq7A0N4e7KfkQiQcsG5rqJzNIGppzdxe7T44ugoFe0ouF5D0lJ7XXpsJ1cMiBXHeDA3Xzj7X/ajO65A2GO26eQVhlYP7A0XNZasSnMryieMkQ4AdBxdOKclfcCArHlhxWgloQxDWHNozpVuSStkYTcnVMTTHWIv2ToMbYbV06i9DRDE6mFHvgAM7wNqlIVmR9l6QbSxc8Vdl49C+O8D01zv9Df6hNB+olhk3J6lduw9BQRRkogvduHwHpCuxsBM4tCbI9aMXCufU0zelNWSYVJIPuKxM9lcblaICuWuoA6XyExpLe/ZpV/SRgb2yoU8GxDwBqrURtRsPGNGDa47E0P8RRtVhcWFGFFXVpiZpEKLNDKcesBCrE/5yNktPbzTkM8DUTqemDmScADb0NHBYNeSsUdYBcFNnBxsp+kzkP7ZOtXkYEpLjqqN15jph6a3pbp+06vQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(55016003)(26005)(38100700002)(33656002)(316002)(71200400001)(5660300002)(2906002)(38070700005)(186003)(52536014)(8676002)(83380400001)(9686003)(4326008)(508600001)(64756008)(6506007)(76116006)(122000001)(8936002)(66556008)(7696005)(110136005)(54906003)(86362001)(66476007)(66446008)(66946007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Pmta+/zm1epbCIor+rdr+lJJS0DS9ZZ7WEOLYEdWHWBOuo914U+59YqCkb+9?=
 =?us-ascii?Q?6xe3XcVSwZHLIkFHKZFO74BtUvTuBinMNR56zaysrXqD7Yo6vo4FZrgF0Rlm?=
 =?us-ascii?Q?3cyJkGv33mIsTohU5w7P5wD9wYMJY2sS/TCtuC9c5Zb+SeZfHY1B90RkVFl2?=
 =?us-ascii?Q?2FuSWyGAIaEghJvFm1nYGyJ2VdERJ06XpFATy60Bz+lQp5wXaSyuAOA0N3lM?=
 =?us-ascii?Q?5QBRITV+YNmaIRO1a2sqizSA6cYaS+fhCLWHPtEpA2HQRzPg88z5q9nxjkI0?=
 =?us-ascii?Q?w9i/viQy10fD4z00sUFSCIzIxFj9EfKOz8NvJ8LfDRCFQDYLTsjC4Qqd7CDw?=
 =?us-ascii?Q?Gt5vtvntYUFqNQTSQlNtEyu8HcBeZ2C3Q7UkEFBsADc4t5Gyefgz6NNx84xC?=
 =?us-ascii?Q?bjBPAN153Josru/XEj1FlTewxPa2kbbViDntL3pjORV5PXkmhA/5h32kuD17?=
 =?us-ascii?Q?nsvtfY4+Pz009SCgI8bwlTBYvnBfu/wBAuO9A+4KEiq0oEke2rC84dnjPzdX?=
 =?us-ascii?Q?ob6tMAX+SAOUJkeKw76yFbUP4l4wtbNXrM3z6j9rNOgKB/E7NGq14UPqeDmC?=
 =?us-ascii?Q?imjOpxPBJLaupShDOwrWBkP2jrMfutO25LYHNrLZ8f/uksSEXoKAz1oNfjwM?=
 =?us-ascii?Q?a45b5KjoNdI67AhCwidsxBSdjrYyl23ARUihbmAJn0+aUI/atoaxlkH15PSm?=
 =?us-ascii?Q?7qej8oijWsVDrhxgn+pubXtIrfzwTEHeA96FT6Vek0DJdikLCvRO4BbwUFZJ?=
 =?us-ascii?Q?a0nC12LDgq+mLAS+EvfUFKPaOrPEdRj9rhcUqISepwuCCvwsjhNNprEeWDJb?=
 =?us-ascii?Q?lQSMJzfid5k23mrzG9/IpiWRPVUYPAMhB9A0K2jdSWMjGBGf86IpbDYkl7PW?=
 =?us-ascii?Q?kEKbBX68RQhT5eP4bFM6RPoNuzF3Agi0dPeWs4k8OL6wekSTXi+dCke/RhzR?=
 =?us-ascii?Q?wgiLn1kLAlKaBvvAB5z9POcy/Eo9ZzqYYz2UXX9GFNEzWho8+PcWjswQsLqZ?=
 =?us-ascii?Q?IUzd1tJmFqNOIoj0rkkifHM3X3Ix/kl0aaORTTyfInq/yerl00TU5/azunPq?=
 =?us-ascii?Q?r/MId43occolwXzsf4US4LuqI50cxqPZJQF8N04Y5mq7aWhE/6jwA+9/tg5C?=
 =?us-ascii?Q?KbPo6aHNX+4tTSCDmV3Q3afRmPU+rp11xbk7y9O4kma46Q0Ce+6BhNLJcxyx?=
 =?us-ascii?Q?wAqEFEvrOiUaaocez3e6eFhZMWlLbYQrBPVDrp3PXgPGcHWt3Y2MqHmljEg+?=
 =?us-ascii?Q?6QxkSZ0qPsHCzIet3Mkd6VaA2s8ovInVRrYhYz4bCEV1mzGY/fVvVzQs38Ae?=
 =?us-ascii?Q?rTTSUwmKSorAIBTnUcf7n9z4twQpvi4BYgzNIVuLz/mZAAiFklx3jsY8Vknd?=
 =?us-ascii?Q?MQ7TpNu0FucxkILXRYBp/0TRMoii+7Qw2H83krQbWYUd7Hi6m7RJw/mfWBn3?=
 =?us-ascii?Q?Po4Zfv3e73+u4OOcRUUSjBVyRc7qlPXA5JLtZt5CWVsnv7QUYu2bFOASiyHu?=
 =?us-ascii?Q?9CWqBXB0LR5tGfQbQH6SlkYzwreKDuJiAyXYbdwiC8o1WNxt1snfiiH5ochm?=
 =?us-ascii?Q?2ieGFdTdNXLehDOAEQOk7xhABNk88aY3mxUmXIGN8fSDlp0e3ag7LXHVt1gU?=
 =?us-ascii?Q?PlufZRYsmPbKeMKvmykDsW2PcSxi4U3viuA/1XLmryAzeYdM9MJ8HgJMez9Q?=
 =?us-ascii?Q?hCzo8zVIjCd9fRB9LP1uCjO5HQYwqasfrZRAR6k4ZW9Q5GSt2wXd9UQ8t/ef?=
 =?us-ascii?Q?ZESd+46zbg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 455c85e9-c145-4ffb-dd74-08d9c092687a
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 12:48:49.9127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x9Pw3tkOiwS2O0aayWqFFVat/MFFYxQKmqkgcGWRLdmsy7FSOF5/zetgQ0m+1eEDtEcQrGitxoxBF5QcAJg99nkq2LkIJOHrBf3Af+x1c+fhYoWj20S85lyxY3YwLCjM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB4028

Hello Oleksandr-san,

Thank you for the patch!

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Based on the following commits from the Renesas BSP:
> 8fba83d97cca709a05139c38e29408e81ed4cf62
> a8d93bc07da89a7fcf4d85f34d119a030310efa5
> located at:
<snip>
>=20
> Original commit messages:
>  commit 8fba83d97cca709a05139c38e29408e81ed4cf62
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Wed Apr 28 18:54:44 2021 +0700
>=20
>   iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
>=20
>   Need to set bit IMSCTLR_USE_SECGRP to 0
>   because H/W initial value is unknown, without this
>   dma-transfer cannot be done due to address translation doesn't work.
>=20
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>=20
>  commit a8d93bc07da89a7fcf4d85f34d119a030310efa5
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Tue Sep 7 14:46:12 2021 +0700
>=20
>   iommu/ipmmu-vmsa: Update IMSCTLR register offset address for R-Car S4
>=20
>   Update IMSCTLR register offset address to align with R-Car S4 H/W UM.
>=20
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>=20
> **********
>=20
> It is still a question whether this really needs to be done in Xen,
> rather in firmware, but better to be on the safe side. After all,
> if firmware already takes care of clearing this bit, nothing bad
> will happen.

IIUC, we need this for IPMMU-DS0.

> Please note the following:
> 1. I decided to squash both commits since the first commit adds clearing
> code and only the second one makes it functional on S4. Moreover, this is
> not a direct port. So it would be better to introduce complete solution
> by a single patch.

I agree.
However, I realized IMSCTLR and IMSAUXCTLR registers' offset differs
between Gen3 and Gen4. About BSP patch of 07/10, it seems to take care
of the offset. But, Linux upstream based code doesn't take care of it.
So, we have to add a new member (maybe "control_offset_base" is a good name=
?)
to calculate the address.

> 2. Although patch indeed does what it claims in the subject,
> the implementation is different in comparison with original changes.
> On Linux the clearing is done at runtime in ipmmu_domain_setup_context().
> On Xen the clearing is done at boot time in ipmmu_probe().
>=20
> The IMSCTLR is not a MMU "context" register at all, so I think there is
> no point in performing the clearing each time we initialize the context,
> instead perform the clearing at once during initialization.

ipmmu_domain_setup_context() is called in probing and resuming.
So, it's enough to clear in ipmmu_probe() I think.

> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  xen/drivers/passthrough/arm/ipmmu-vmsa.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passt=
hrough/arm/ipmmu-vmsa.c
> index 8dfdae8..22dd84e 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -229,6 +229,9 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
>  #define IMUASID0(n)            (0x0308 + ((n) * 16))
>  #define IMUASID32(n)           (0x0608 + (((n) - 32) * 16))
>=20
> +#define IMSCTLR             0x0500
> +#define IMSCTLR_USE_SECGRP  (1 << 28)
> +
>  #define IMSAUXCTLR          0x0504
>  #define IMSAUXCTLR_S2PTE    (1 << 3)

As I mentioned above, we have to adjust these registers' offset for
both Gen3 (+0) and Gen4 (+0x1000) somehow.

> @@ -979,6 +982,10 @@ static int ipmmu_probe(struct dt_device_node *node)
>          set_bit(0, mmu->ctx);
>      }
>=20
> +    /* Do not use security group function. */
> +    reg =3D IMSCTLR + mmu->features->ctx_offset_stride_adj;
> +    ipmmu_write(mmu, reg, ipmmu_read(mmu, reg) & ~IMSCTLR_USE_SECGRP);

If we modify the 07/10 patch, we cannot use ctx_offset_stride_adj.
# But, using "ctx_offset" here seems to be abused though because
# the register is not context.

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:02:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:02:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247941.427593 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqOG-0007QB-7J; Thu, 16 Dec 2021 13:01:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247941.427593; Thu, 16 Dec 2021 13:01:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqOG-0007Q4-2S; Thu, 16 Dec 2021 13:01:44 +0000
Received: by outflank-mailman (input) for mailman id 247941;
 Thu, 16 Dec 2021 13:01:42 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxqOE-0007Pu-K6; Thu, 16 Dec 2021 13:01:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxqOE-0007TJ-2V; Thu, 16 Dec 2021 13:01:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxqOD-0000xg-P1; Thu, 16 Dec 2021 13:01:41 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxqOD-0000K6-OW; Thu, 16 Dec 2021 13:01:41 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F2ruPA49gUvoGeF1MFQA5D1MrGFa00GvJlcO5eZDLBM=; b=f5/aAGHiXvmcbbfNr0ZnvahIwq
	thBMrV0Tr4raaDMaElc4wf3o1WeNm3nUXv6BltUPguARFafe4BJNsrTRYfFrtcnuQwGCbUMRjCLIh
	EmAZCAJ8a0SaZfyYNhHMLHiE4KO4MXcN+sCqctlZoAKrhz207L3y2B7A30+SuH2iQISY=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167440-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167440: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-libvirt:<job status>:broken:regression
    xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:regression
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8b3cbdbe782cae972e9a47cf22620ebee61a96a6
X-Osstest-Versions-That:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 13:01:41 +0000

flight 167440 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167440/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-libvirt        <job status>                 broken
 test-armhf-armhf-libvirt      5 host-install(5)        broken REGR. vs. 167411

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167411

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167411
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167411
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167411
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167411
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167411
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167411
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  8b3cbdbe782cae972e9a47cf22620ebee61a96a6
baseline version:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f

Last test of basis   167411  2021-12-14 12:17:05 Z    2 days
Failing since        167418  2021-12-14 21:38:12 Z    1 days    2 attempts
Testing same since   167440  2021-12-15 22:09:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     broken  
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-libvirt broken
broken-step test-armhf-armhf-libvirt host-install(5)

Not pushing.

------------------------------------------------------------
commit 8b3cbdbe782cae972e9a47cf22620ebee61a96a6
Author: Bobby Eshleman <bobby.eshleman@gmail.com>
Date:   Tue Sep 28 13:30:24 2021 -0700

    arm/traps: remove debugger_trap_fatal() calls
    
    ARM doesn't actually use debugger_trap_* anything, and is stubbed out.
    
    This commit simply removes the unneeded calls.
    
    Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 9956fdc70f99b0f133be7f16f62417928a84622c
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Dec 15 10:24:45 2021 +0100

    Arm: drop memguard_{,un}guard_range() stubs
    
    These exist for no reason: The code using them is only ever built for
    Arm32. And memguard_guard_stack() has no use outside of x86-specific
    code at all.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit fdf01494560219d10f92ce3419a5551e3ce5fe4f
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Dec 15 10:23:51 2021 +0100

    x86: drop MEMORY_GUARD
    
    The functions it guards are dead code. Worse, while intended to exist in
    debug builds only, as of commit bacbf0cb7349 ("build: convert debug to
    Kconfig") they also get compiled in release builds.
    
    The remaining uses in show_stack_overflow() aren't really related to any
    memory guarding anymore - with CET-SS support the stacks now get set up
    the same in debug and release builds. Drop them as well; there's no harm
    providing the information there in all cases.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 163db6a72b660f0f3c9fe1d34e8f6b07ae6bd77d
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Dec 15 10:20:35 2021 +0100

    x86/PVH: permit more physdevop-s to be used by Dom0
    
    Certain notifications of Dom0 to Xen are independent of the mode Dom0 is
    running in. Permit further PCI related ones (only their modern forms).
    Also include the USB2 debug port operation at this occasion. While
    largely relevant for the latter, drop the has_vpci() part of the
    conditional as redundant with is_hardware_domain(): There's no PVH Dom0
    without vPCI.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit 5b226ca74bb2c5cd84ede5c1f2b859c2e3bcd8a0
Author: Jan Beulich <jbeulich@suse.com>
Date:   Wed Dec 15 10:19:54 2021 +0100

    x86/PVH: improve Dom0 memory size calculation
    
    Assuming that the accounting for IOMMU page tables will also take care
    of the P2M needs was wrong: dom0_paging_pages() can determine a far
    higher value, high enough for the system to run out of memory while
    setting up Dom0. Hence in the case of shared page tables the larger of
    the two values needs to be used (without shared page tables the sum of
    both continues to be applicable).
    
    To not further complicate the logic, eliminate the up-to-2-iteration
    loop in favor of doing a few calculations twice (before and after
    calling dom0_paging_pages()). While this will lead to slightly too high
    a value in "cpu_pages", it is deemed better to account a few too many
    than a few too little.
    
    As a result the calculation is now deemed good enough to no longer
    warrant the warning message, which therefore gets dropped.
    
    Also uniformly use paging_mode_enabled(), not is_hvm_domain().
    
    While there also account for two further aspects in the PV case: With
    "iommu=dom0-passthrough" no IOMMU page tables would get allocated, so
    none need accounting for. And if shadow mode is to be enabled (including
    only potentially, because of "pv-l1tf=dom0"), setting aside a suitable
    amount for the P2M pool to get populated is also necessary (i.e. similar
    to the non-shared-page-tables case of PVH).
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

commit a6d21af4a12d310fec72ca3e87e2a3b045643a25
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Wed Dec 15 10:17:34 2021 +0100

    build: adjust $(TARGET).efi creation in arch/arm
    
    There is no need to try to guess a relative path to the "xen.efi" file,
    we can simply use $@. Also, there's no need to use `notdir`, make
    already do that work via $(@F).
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 19427e439e01715c1a493c1528122234346efe38
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Wed Dec 15 10:16:51 2021 +0100

    build: generate "include/xen/compile.h" with if_changed
    
    This will avoid regenerating "compile.h" if the content hasn't changed.
    
    As it's currently the case, the file isn't regenerated during `sudo
    make install` if it exist and does belong to a different user, thus we
    can remove the target "delete-unfresh-files". Target "$(TARGET)" still
    need a phony dependency, so add "FORCE".
    
    Use "$(dot-target).tmp" as temporary file as this is already cover by
    ".*.tmp" partern in ".gitconfig".
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Acked-by: Jan Beulich <jbeulich@suse.com>

commit 725381a5eab35227ef0099a43e05034def42bb77
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Wed Dec 15 10:14:13 2021 +0100

    xen: move include/asm-* to arch/*/include/asm
    
    This avoid the need to create the symbolic link "include/asm".
    
    Whenever a comment refer to an "asm" headers, this patch avoid
    spelling the arch when not needed to avoid some code churn.
    
    One unrelated change is to sort entries in MAINTAINERS for "INTEL(R)
    VT FOR X86 (VT-X)"
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Acked-by: Paul Durrant <paul@xen.org>
    Acked-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Julien Grall <jgrall@amazon.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

commit 72f12ac6a36d5aa0567fd7abc2856e3bf054c4ef
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Wed Dec 15 10:08:38 2021 +0100

    build: factorise generation of the linker scripts
    
    In Arm and X86 makefile, generating the linker script is the same, so
    we can simply have both call the same macro.
    
    We need to add *.lds files into extra-y so that Rules.mk can find the
    .*.cmd dependency file and load it.
    
    Change made to the command line:
    - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags).
    - Added -D__LINKER__ even it is only used by Arm's lds.
    
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 249e0f1d8f203188ccdcced5a05c2149739e1566
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date:   Mon Dec 13 20:33:42 2021 +0000

    x86/cpuid: Fix TSXLDTRK definition
    
    TSXLDTRK lives in CPUID leaf 7[0].edx, not 7[0].ecx.
    
    Bit 16 in ecx is LA57.
    
    Fixes: a6d1b558471f ("x86emul: support X{SUS,RES}LDTRK")
    Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 1382241fe880d48e109f2056cec052bb3919a9d1
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:50:07 2021 +0100

    perfc: drop calls_to_multicall performance counter
    
    The calls_to_multicall performance counter is basically redundant to
    the multicall hypercall counter. The only difference is the counting
    of continuation calls, which isn't really that interesting.
    
    Drop the calls_to_multicall performance counter.
    
    Suggested-by: Jan Beulich <jbeulich@suse.com>
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 668dd44902bbaf52f8e7214e0da060b6ec962e88
Author: Juergen Gross <jgross@suse.com>
Date:   Tue Dec 14 09:49:23 2021 +0100

    x86/perfc: add hypercall performance counters for hvm, correct pv
    
    The HVM hypercall handler is missing incrementing the per hypercall
    counters. Add that.
    
    The counters for PV are handled wrong, as they are not using
    perf_incra() with the number of the hypercall as index, but are
    incrementing the first hypercall entry (set_trap_table) for each
    hypercall. Fix that.
    
    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Jan Beulich <jbeulich@suse.com>

commit 7b99e7258559c9caa235d9faf323b22c68e4a581
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:48:17 2021 +0100

    x86emul: drop "seg" parameter from insn_fetch() hook
    
    This is specified (and asserted for in a number of places) to always be
    CS. Passing this as an argument in various places is therefore
    pointless. The price to pay is two simple new functions, with the
    benefit of the PTWR case now gaining a more appropriate error code.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Paul Durrant <paul@xen.org>

commit c49ee0329ff3de98722fd74ed5ba6d9665701e54
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:47:31 2021 +0100

    SUPPORT.md: limit security support for hosts with very much memory
    
    Sufficient and in particular regular testing on very large hosts cannot
    currently be guaranteed. Anyone wanting us to support larger hosts is
    free to propose so, but will need to supply not only test results, but
    also a test plan.
    
    This is a follow-up to XSA-385.
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Acked-by: Julien Grall <jgrall@amazon.com>

commit 53ed194539ddbea4f6aecb1b7c2f33aa8c0201d9
Author: Jan Beulich <jbeulich@suse.com>
Date:   Tue Dec 14 09:46:48 2021 +0100

    x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()
    
    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
    Reviewed by: Alexandru Isaila <aisaila@bitdefender.com>

commit 7dc0233f534f64e7f3ee71e74e05dd5ab8a24808
Author: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Date:   Tue Dec 14 09:44:44 2021 +0100

    vpci: fix function attributes for vpci_process_pending
    
    vpci_process_pending is defined with different attributes, e.g.
    with __must_check if CONFIG_HAS_VPCI enabled and not otherwise.
    Fix this by defining both of the definitions with __must_check.
    
    Fixes: 14583a590783 ("7fbb096bf345 kconfig: don't select VPCI if building a shim-only binary")
    Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
    Reviewed-by: Julien Grall <jgrall@amazon.com>
    Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
(qemu changes not included)


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:21:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:21:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247948.427606 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqgw-0001kI-W1; Thu, 16 Dec 2021 13:21:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247948.427606; Thu, 16 Dec 2021 13:21:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqgw-0001kB-S6; Thu, 16 Dec 2021 13:21:02 +0000
Received: by outflank-mailman (input) for mailman id 247948;
 Thu, 16 Dec 2021 13:21:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mgi2=RB=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mxqgv-0001k5-Ux
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 13:21:02 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20723.outbound.protection.outlook.com
 [2a01:111:f403:700c::723])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 00ec496b-5e73-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 14:20:59 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB2345.jpnprd01.prod.outlook.com (2603:1096:404:72::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Thu, 16 Dec
 2021 13:20:55 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 13:20:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 00ec496b-5e73-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=OCo5nAUS9xeHwaxZPLGDfiuLEwJEhHsTnXJ+IZaifHkyu7K6sNCYlpqj05WGcQ/4yKmhQrbnDZxH5AmRG9tlhbF5QKTpUZKun9iAHXk9BTBIMO+gHSixEpqOmsRfzjxmEEZhAvnmJwF0H7cz0QkTHY5+u2+S8ZlhaYl/y9Hs+RpTaCJQhkjlUSeq+Vmj99vs4r9OYyi4sX/O6nsxgmmB+YNNwtMiF3nxdgEb9LgEho2Y7qOl51Bodo3HU0+lWflFlkqzvO13VjAqqz2lYtfdrjdDvCwjzAendjUddwXRS80O5fTkovNUWTO5ef3HN8OmX/uah6uP77CoQTEYwi3RZw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nlyheXEXQjyolMa/KTrQIsnDMzW4nqwVgdNxyAfoyYQ=;
 b=bgyEtwZouTDsy2rCKAF64vUOArUODIw25RTQYJofOq8EKW+wWNY2JTZzeF5DDnUB0mcBIsnmqDmY07AoVmqWNf9whXxgPSlNyXDhyun2dK3+0jNvPMSi8iTaQVMDALUv8v3xNKjzFDdB7m9AtZviD9e9v2Sqr4k5cxpzBt7ZSuO6JGEcZZl4hoUKMTC1zha9+t4fY4HSOqriCxTPJVOBFdaanPR+AMDmdmNbH484vN+W8FUU++4B4BXnKImKNDRiEFPoU3GR3mJSJ4WuhBhqV+YpBCCgBJnCsRosWd0pA6JwVsu4hJc5RzxQItlipPJWy1FfEO6t5XtVudlYk+7DiA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nlyheXEXQjyolMa/KTrQIsnDMzW4nqwVgdNxyAfoyYQ=;
 b=ih6avbPSgqPP3RfdqYvIIh8Ck+OtLlDUgMCZ3o+8STWWeD3O4hadyXMIu1YlUoqPAf/SrJfggmswKib4nKgY0/A+QMTq1xqTM7e8p3wskcuAdsamieGJwKL28Nzru6VAl1aPqcpQpNvUFjnm2wtWYULA4u3nApC3vqBB5vmo8WE=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: RE: [PATCH 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
Thread-Topic: [PATCH 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
Thread-Index: AQHX47d7s26TeYK9j0qz+isKX7yf4Kw1N4gQ
Date: Thu, 16 Dec 2021 13:20:54 +0000
Message-ID:
 <TY2PR01MB3692A9686B4C239945A1954CD8779@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-10-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-10-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b44bc370-235f-4250-bd1c-08d9c096e3e7
x-ms-traffictypediagnostic: TY2PR01MB2345:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB2345EE4F4515052A39B92E06D8779@TY2PR01MB2345.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 aI9U2y9LwbDKcoddU3iJQohPXiWwH6+xJY/O84puTMGJJfwwrVaB0Cbgv3skXlIE12cMyUIMfhBG7rAeiAxP2tqPOfZoaVynYLFfJ6jONZisnVlGnZheKlh3z83tuDQrzXk1A1p/ljejfUzg34fRit6JhMVrUXb2CJ3HBjSRhAg81CXeotPfzHbBMIi50bWpzh0Km6XC/ksQEpJ0gnDVvGzrL3oUd6wvNr8fevTUUi5OnLpJYytwwFbIk9MGPFACciXHnLc9ukA8KnigGA0MRBDy+TK6F3Ry18nV51biZ509iHpfloN2bd8EohlI8dIaTb8uS+5gU+h69Od/DJ4r0zx54mxawyhs86VB6AfTRgw7KQw/+Qel8aFQNtQDpiaYgT5kqWtwcIvlEBpVA6ECm9lruW9Zb88nb3eE4r93f5+9KDJb8+AOpb0NccFiLVgYb7nozZDQsAhwqL6I7YRNU/e5r/Sz/regFHOlHyfQM/XZiLIJsdqOGReRyXI7YnyqOsqW1HtHIAX00P+POC42PClk5qIEyy/rq5TC0ow9hzwOSaj5wqvcOWHW89Wn/zpy7/t23HHTh/YioOz9wN041KePyrxkePBfZ5GR+qLNVFBvp4Rl7CgOmYHDwUHTiursdHzk3Came/Hvg28cKxRrN+pvomwNObqEuTygaMWhrCUYPFCiOsMV66rllY1atYrv+OH8/6PTVII1svnS6qejnQ==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(55016003)(2906002)(316002)(76116006)(33656002)(66476007)(7696005)(110136005)(71200400001)(186003)(122000001)(38070700005)(66946007)(54906003)(66556008)(66446008)(38100700002)(64756008)(6506007)(9686003)(52536014)(5660300002)(86362001)(8936002)(83380400001)(26005)(4326008)(8676002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?kSeUO/14BNQ0/eyXkZIj1eLD7ke2HGluhsMKBW3/jGcLdkdhC/gjc0/xZk2z?=
 =?us-ascii?Q?L3904rsmaxW5WkVhQCPCNJJhF8l8RND6FI2uQgi0az9lWKP9JXlrv8YNBs9+?=
 =?us-ascii?Q?z9IajSwlest9ynwkBFtBi/UyFG5CIc719Wlw6+EBSkAarudJ+8OJDO66Okem?=
 =?us-ascii?Q?m+fCMPlfF1stRdT4IxsrFR084StcYe8YjmkLlkum3jSvDOjLYWyTaK9wooHk?=
 =?us-ascii?Q?2TCxHb/ypQUW6AN6iDLor6UAHp8sjpHk81e/pds0GxuHBMIFYOxXEB/UHoIR?=
 =?us-ascii?Q?keG/sHcCtiLyVPcmmomDcQNZT4SBWx8l3i7AjP/238YtIrGaIYRzQD2oGo3b?=
 =?us-ascii?Q?pcvvSzCxaAithfbiTFGtIIivhv3q4OCq8FbNbVB89fBKt0DMmsqiV+bLmmHl?=
 =?us-ascii?Q?R5vWnIrUyC58PfL5XliCyJwrfWHyBRaEETo4RIlyEsoAacjA9sYhP7Ysed3e?=
 =?us-ascii?Q?7J0CHRRlnkyoVRh8HWvv3QqZV5UbMo/1vhTUEZFfyqYnwY0eXfHvQLPUYQuW?=
 =?us-ascii?Q?Kmyl/aXKGB5Bqj8RAtVv14NgsKme6sitAiR5E9D+K7kQNHrs3IHIVz+oa3Ng?=
 =?us-ascii?Q?6rtq3Uwi2XSKezB9IGP1xxAVQR3CCzV264ZQUMa2AXP16TTFtWdgEcnbGk5I?=
 =?us-ascii?Q?VL+34IZURxLtFAOWSVaaNsW7WQEGL3MZGCSiIxHO94YZFbbjZ9NnZ9XHkiXF?=
 =?us-ascii?Q?XHHixMJo08oRbXsTYKQ7NrUqokekUldx60E8ClxG4hogtWT+PrC1Y6rCCdbc?=
 =?us-ascii?Q?1h+Bp3QDu6y0y+3I0EW1Gg+kDTi0BLirUfqpxQ1XviRpiw7KaXB93c4ruCs2?=
 =?us-ascii?Q?kUBm85IE64edJp33j5go9/AsWbK4hl/uv8i2d5QJIc/lnnTji7I29LZNclht?=
 =?us-ascii?Q?uEOqHTqZ9pua7VAu8xHot0+TzbTM2OsFqB7kA28yW+55BaQPWiuRblT0uoAU?=
 =?us-ascii?Q?CJSTssShIZpa/Gh2TJLZlpBJhs/decBl9UaXqvDRf0wquaUogUn6t+CK92WL?=
 =?us-ascii?Q?5TdEWM3SXLpvE6onTV3/hzV1LZU2g0MJQLq7MssNuUC+yM+2tjnEWzQhwZjO?=
 =?us-ascii?Q?shiGeRahjeDPmoLMUeSiSSCjpdjRoIZOEIXZBHITCW6njw++zCTzCf66rUTw?=
 =?us-ascii?Q?y26wQSh9SxyqqU9MyPik9GPVPBjHPWnEw7kfabtH/xPm5Am0JfQkm/gOD/OK?=
 =?us-ascii?Q?+daLFioLKtnlbTzBucGTwWL7cutld0cFEvwq2JyHRisHT4kEKaIquKDpTOxB?=
 =?us-ascii?Q?hpdjbI3UWUNV/jbctJYYcERl2VvZnUXIxbODhr9WVWx1CEUEVAhYIYpUO5sz?=
 =?us-ascii?Q?PN/iRlRPCbgw+40thSaxlhn3gg7C+uAcINa4bK6YIFfjexnmvyjqo1RVO5TN?=
 =?us-ascii?Q?b6rjTImK11rmivDv/n+zKlPQEAdLbMeMf/uD154ap8UxmER409P5zJ1o+YgN?=
 =?us-ascii?Q?NB9k3fdCBj6pj4lWR7st8IkyRs7wFdDiSlQmtSq/LfcKLPEpIoezcH4rAmNX?=
 =?us-ascii?Q?kbRlUT4P1OQ7tlYgYkL6GN43V0Xfy8sHyUebZtny0SY0ogf4NjaRkfdz9F+W?=
 =?us-ascii?Q?poeUfbJsogGv/5ni6uPKosPQFLDpKjsE5ejZ4kLOSNQvt/BTtE38UcsKACFV?=
 =?us-ascii?Q?yaYuZ9AayrzlWb3IB8pTF3QzSTrKExJRPNiQO+9gu0hn/SDash1hbYjf1MTJ?=
 =?us-ascii?Q?oW+DlkRhMBkNzhubML1DCi7AeZp4JIPozG01lnomG1E0g4Vh8KAiucJRX4i1?=
 =?us-ascii?Q?N1ZxPnHQSA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b44bc370-235f-4250-bd1c-08d9c096e3e7
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 13:20:55.0048
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5FS9qWodGEwEDrmowwU97fuC/cxZDHqogs2BIWCZM77H2SxKj4Un76CSfeKrqe4GXzocklSigDW31wYBmg6LLYXFakm671+lsYPQihZGhZbBE+Rd46J/P9wcEoLMfgCQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB2345

Hello Oleksandr-san,

Thank you for the patch!

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Reference-count the micro-TLBs as several bus masters can be
> connected to the same micro-TLB (and drop TODO comment).
> This wasn't an issue so far, since the platform devices
> (this driver deals with) get assigned/deassigned together during
> domain creation/destruction. But, in order to support PCI devices
> (which are hot-pluggable) in the near future we will need to
> take care of.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
>  xen/drivers/passthrough/arm/ipmmu-vmsa.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>=20
> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passt=
hrough/arm/ipmmu-vmsa.c
> index 22dd84e..32609f8 100644
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -134,6 +134,7 @@ struct ipmmu_vmsa_device {
>      spinlock_t lock;    /* Protects ctx and domains[] */
>      DECLARE_BITMAP(ctx, IPMMU_CTX_MAX);
>      struct ipmmu_vmsa_domain *domains[IPMMU_CTX_MAX];
> +    unsigned int utlb_refcount[IPMMU_UTLB_MAX];
>      const struct ipmmu_features *features;
>  };
>=20
> @@ -477,13 +478,12 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_doma=
in *domain,
>          }
>      }
>=20
> -    /*
> -     * TODO: Reference-count the micro-TLB as several bus masters can be
> -     * connected to the same micro-TLB.
> -     */
> -    ipmmu_imuasid_write(mmu, utlb, 0);
> -    ipmmu_imuctr_write(mmu, utlb, imuctr |
> -                       IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMU=
EN);
> +    if ( mmu->utlb_refcount[utlb]++ =3D=3D 0 )
> +    {
> +        ipmmu_imuasid_write(mmu, utlb, 0);
> +        ipmmu_imuctr_write(mmu, utlb, imuctr |
> +                           IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR=
_MMUEN);
> +    }
>=20
>      return 0;
>  }
> @@ -494,7 +494,8 @@ static void ipmmu_utlb_disable(struct ipmmu_vmsa_doma=
in *domain,
>  {
>      struct ipmmu_vmsa_device *mmu =3D domain->mmu;
>=20
> -    ipmmu_imuctr_write(mmu, utlb, 0);

As Volodymyr-san mentioned before, after we added ASSERT(),

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:22:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:22:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247953.427618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqii-0002LZ-Cc; Thu, 16 Dec 2021 13:22:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247953.427618; Thu, 16 Dec 2021 13:22:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqii-0002LS-9U; Thu, 16 Dec 2021 13:22:52 +0000
Received: by outflank-mailman (input) for mailman id 247953;
 Thu, 16 Dec 2021 13:22:50 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mgi2=RB=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1mxqig-0002LK-R8
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 13:22:50 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on2070b.outbound.protection.outlook.com
 [2a01:111:f403:700c::70b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42a58ec6-5e73-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 14:22:49 +0100 (CET)
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com (2603:1096:404:d5::22)
 by TY2PR01MB5276.jpnprd01.prod.outlook.com (2603:1096:404:d9::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 13:22:44 +0000
Received: from TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408]) by TY2PR01MB3692.jpnprd01.prod.outlook.com
 ([fe80::b0dd:ed1e:5cfc:f408%3]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 13:22:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42a58ec6-5e73-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CKyjFRVKFlXbdEOxl94a5ek2NWadOtp8nv1G3WR1QeJdTgDgevPk2NS98qIACMVNNGqNrilrgFfFoqcjh/ON6aCo963f7tl/XTn9/7nxP7fjzGdqPmt/TH97OA8LVkkreMkdKdQgIxFWWiLcPwoj9TekZFibdf8O7YAx0VLobkOZBR3tugAfebsH0sMYCXVHG3Yf1HpdM+n7+Xey86JXzrHDovbXfiYk0LzqR5TvOvezm/RZbGAVmHpxfmqDh8aEtp6sjDUNlJysu5USpFVe7Wop7uS2Ki4CfqWPNx9gn5jaXi3oHlMzdZCZptjc3BlfX3SJpTgKNES+Z8sv686zhg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Vqyomesbs3vI62kJf/1Pj5mkg/98gtIPgExvewx5RU0=;
 b=GdNE9rfdpb81f+vSVGTIfnW4+907NAc7VEtl0whKFyD45UcptZyzQPscveh3unbyp+qh+IcqkoYWJ7EDo9IU/G5eRYvHXRFbKHc2M/dH27S3d66Ne6G0elklT6O7vQJCe3IR1KHEY27pRG+myCJvVxvcvUMvh4nUIUpVhWBSGaMS3ctIt/F8FDDBMkCxZDTJ48PQlQ20S22bdu/VUrapz11hUK9HNVJywTzuEZF5I9aXRRBiIzt7jAD8iBbgsf8d5mmFAPqAzoI/EHnXyBC6EwzHWXvw/b0t0WC1rJfxSE1i2yNeNlBp13zERcgs8psuOyaWk0GYlMKo15Wu9tyN9Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Vqyomesbs3vI62kJf/1Pj5mkg/98gtIPgExvewx5RU0=;
 b=pqb8xypAzJNRzhqVBHVW4SuFiE8QrWLiMii9zWj374pJ/9VCE0WsrtzXmxDVzWsks8n2S0qvAn4bjPZ+HQukalWLyk8zly3TheDSSP6mYESBTBcFKTPqZvsMzK+eGddlc8woRpe9ncj05ZwQZbMCEOvAYezxABSNkNszPAJe6Uw=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Rahul Singh <rahul.singh@arm.com>
Subject: RE: [PATCH 10/10] iommu/arm: Remove code duplication in all IOMMU
 drivers
Thread-Topic: [PATCH 10/10] iommu/arm: Remove code duplication in all IOMMU
 drivers
Thread-Index: AQHX47d7gvrVCe55h0msi5zMEOFD6Kw1OHOQ
Date: Thu, 16 Dec 2021 13:22:43 +0000
Message-ID:
 <TY2PR01MB36927506C2BCE0F0C58C736BD8779@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-11-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1638035505-16931-11-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b7fbcec8-31d5-4061-8aa3-08d9c09724e9
x-ms-traffictypediagnostic: TY2PR01MB5276:EE_
x-microsoft-antispam-prvs:
 <TY2PR01MB527653FA8DC6F51CA135716CD8779@TY2PR01MB5276.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5236;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 oxbKaZLZj+yK+5a7hyYGIhDuzCrYKhonbKQjl0lQIoDGQf2MSCQ9qNgdQNV2a1roYPboZHGFw3S+tqJbyDtUJPkmPGirzlO7IqNgoMZ/MfSJX3/BnExF9pd/YIUN2b/h9dpVK6Fafnmtsy24RJntnXASMI/euesCdc2/aE4Vt2JQ6Z4KuDQ1g4UiiI/V98E1BWTJ6Z5jGzmKC70hrlf0hjmcRlC3C7XP1h3YvVDUbIgVKUe+sqJjZHOJrN64m0amI5/daQgc89LeZiZM8xzIktDFFq+frWsZwePGUTo2V+x2gN0TRiJeOx7eS9PhU7E7dnXD+tOlYEJZtocXvOL4Bxd54AtpBjKSktpFCpzM3vaDXjFdymALt/uTUUyhNL67nFOYNnXld9FoTB17sEEaHQdqqDa94UpZd/ZG3sw9Argw6W77wBXAIlMbr+NW0y5dhW1QO+uaLBxuLIZBWRvajsfiZEiJ7+cNmH8sL9hafpJTLIMNZ1f9w1KqQOpMLlOAEWf6SEZZYcU7p3UQvxgaq7lSerVioEEVsmkc0mYOWEFJ+gPa3PUkqBy08o2ZgrV6xabgwyBQUPxkATxR2N/c4Fn9G7fPy5U6dwau+KHztDtLJj9SKg7Pw2esZ79wndCt4Ux+pA+DP5b3r5Uwy9nnFYD5MCO1hE9GzaL4bfocbVvheS9CwvuWu/wBhCJI968ghKyJW5Ud8xEFfLKELY4j/w==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR01MB3692.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(64756008)(122000001)(66556008)(54906003)(52536014)(7696005)(8936002)(66476007)(8676002)(86362001)(66446008)(55016003)(38100700002)(4744005)(9686003)(4326008)(26005)(76116006)(71200400001)(83380400001)(186003)(66946007)(6506007)(316002)(508600001)(5660300002)(38070700005)(110136005)(33656002)(2906002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ic+5x4+s3vb4y6YHxtOEx1jPY7rqoQfHxs8JZl0hbMfYcfxyxgcoSInaDvLB?=
 =?us-ascii?Q?mIEi33VvND3sIBoyFHL35CJUsgHIC42IPJBWvV/b+nV7F/fJoV0gpmOery3T?=
 =?us-ascii?Q?uwoUkzPTs0r0vJo1xrfZWFKrCvwLNp/BDZFMYZyqtnBLbi2j/FrxHuvpPEsE?=
 =?us-ascii?Q?+M1qV7dGBDr5RQCAau9jSfrMfQrtq9Or2oMNlJVcyddmspaZChxWyAetpFLF?=
 =?us-ascii?Q?CQRVUk5MLobSx/yMzEaAm7IfA858tu4p/0x2QOYRK1vEGH58+ErHS+bfvQM9?=
 =?us-ascii?Q?zqHzKpK5ixHohRZi9Oz+XhGw8oDpHeHMUKVyLoVJc6GvMAcoVvRy3c0P0i+J?=
 =?us-ascii?Q?GDVir/LGMnHwvdPRaJz2/cnCzm8GEcg6bUQKRdpS+Xs8TiSiW8PNms18B6/2?=
 =?us-ascii?Q?n8vd3GN2YoP3UQPm/4x+hSoxUyLOQAQjB32mdSCccqPGLo0a9Nmm5crV8LnG?=
 =?us-ascii?Q?lRqMnxaCNKBNy2YaYVMeokKEW+p/krrDOEfHBGoNAp1e6VsKsQLHKJErhQxT?=
 =?us-ascii?Q?4y8kYj4YvusuK68VUgwvqjDprzcCPJYC6HYhNH6ef4c/bhS5Akjv17gsLi4Q?=
 =?us-ascii?Q?Mi+iG3HkGA/7/fQn85tIBATW2dlap7qhGNHz9OKyl2nhhk2BIg1f3mSqxB/h?=
 =?us-ascii?Q?xGeTOY3h2B2vCLVe+7suzd6kx2jBmC3NGe/WNdUPY3sDewvcntP34cMs229Z?=
 =?us-ascii?Q?Hb26XhI0/opELUWmIB76O3qnlErIsKU2d0fuK4lCU7jnagrCFwH634OmwU+3?=
 =?us-ascii?Q?rXTbu7QVcniD5UUX+HJM8ElN4cDk0x1p1cYVxVRa7Go0LQexj1jCcrvT4Uoe?=
 =?us-ascii?Q?pozcgefJUU/XxvQ97esmFFYfpCwoMAKiRplJ386zNuVknFDSiNdY3ZBSgGFK?=
 =?us-ascii?Q?etRCRavq6EctUvN9mQh5ORUZwzixJCat2jw6tk/NjvMy+3wvgcT/nU71CnLm?=
 =?us-ascii?Q?439vqy+z6BxlGd8YU829UniV8/8oJIVWJkc1TkSVn8eISCSpiH3UluwsmymI?=
 =?us-ascii?Q?gZVDI6jIdZINmopyy0hyKnVr2BMawBSB0di3tOusx9BOVxkR4cpRPUxYoIfv?=
 =?us-ascii?Q?s1jXhJWQneh6tytRyXQJk00xDmTTZe+Suzj97rXihibslt+Glh2uS0anF5G4?=
 =?us-ascii?Q?iYq15DUR9kQ983US5B/63laecoVG4SCMGmvVjDsJJyxVLTa1tadTGs9ZwIEv?=
 =?us-ascii?Q?txM20afgSsxwVTXj8g0IJ6gsZKierL9WlWW1CkjdqAoy3bm+xq0Fi9fxZ8KB?=
 =?us-ascii?Q?PtJ/Cx/ZMIA3FxBun4KnGqw7VZmBOXRG5aMzPcdBbCrlyvVYVLs2xvnGDAUc?=
 =?us-ascii?Q?YDSlFCO7MURL9lXgU6a0KHH4x+izc+O4clMf7+/UhLMP1/qHH8palitnV/oH?=
 =?us-ascii?Q?VC40JYcuDTONlfC0SuTcwav2WHBcpG65+C/oVMYvoCfOEEcIvPXUwNmZOcr3?=
 =?us-ascii?Q?kM0PVv/lMMA4lwPZkbcovwWVe0dAuIl8AU6kXrAnoQF5QXycZmmaKnZRrvOs?=
 =?us-ascii?Q?w9yG95HLQVr+q1G2X9ExBIe4zmnA0qy/T19AD69kN1FyzXlsp4j68Eqxgpgr?=
 =?us-ascii?Q?Zw/ZY/x50npl/LzBvhrYov0fLHG/6lh6fQ9fkCTxfOTcCmhGyN7nYRZz1z/+?=
 =?us-ascii?Q?JoCJVWTfmdTgIEa2ESFXjob426cDMr6GO4lvQzV/eLHKvzJ8WvzSLFPRnLJU?=
 =?us-ascii?Q?ihCbMpF7ZMSnr845rRpJM+RMyC2eyI6RDoiXfabMPYMuAHJl1BBaJlUrUkk/?=
 =?us-ascii?Q?ZDaH2bDTCw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TY2PR01MB3692.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7fbcec8-31d5-4061-8aa3-08d9c09724e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 13:22:44.0126
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /IuDmmvht+sgO/WySlwMlBogifWXjKT3cB2kov6Jq3fgZb2k87A9Qv20Lhntyw7e4VVK46hxkwr1ksCRs+de9zC7QmKmmOow4p7HBqBENd+yv+7ebekhVCEyZLjNywas
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB5276

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> All IOMMU drivers on Arm perform almost the same generic actions in
> hwdom_init callback. Move this code to common arch_iommu_hwdom_init()
> in order to get rid of code duplication.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:33:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:33:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247958.427629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqsy-0003zM-D8; Thu, 16 Dec 2021 13:33:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247958.427629; Thu, 16 Dec 2021 13:33:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqsy-0003zF-9l; Thu, 16 Dec 2021 13:33:28 +0000
Received: by outflank-mailman (input) for mailman id 247958;
 Thu, 16 Dec 2021 13:33:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxqsw-0003z9-HB
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 13:33:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id be976df2-5e74-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 14:33:25 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-9-hMoLfpgEPcKG0w5PWC5bBA-1; Thu, 16 Dec 2021 14:33:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 13:33:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 13:33:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be976df2-5e74-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639661604;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tyY3YTRTq9k9vYPfUizzSfU0OK46V7J0vRZxKOr2WwU=;
	b=jCp2whlbhb6KQbEd0gvdWsTwGuDBg7HpZRLKGzE4nQd7kZNq+1rPflnJX/SaRw9+GKRga8
	Xd5PluOsRXErRVdQtEf0UzUsCwVOkl6pwy4Vh+74huOFxad8mgFjbbddoEzmm3mNQml/HQ
	y08m+VvLYDtgW0plSbggJNmBvxUX93Q=
X-MC-Unique: hMoLfpgEPcKG0w5PWC5bBA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=FOAm/RkZMg5O8gyjDGXmZx6quz0SAt6cJ/RPG46thzNlUJLoVu1vlpr2oLlj/lH+w8PiPou1ZPH1I2lihWDQFyiKFhxaTlf7miP3EiHjhlO/Ym/onhsiuIWL2HAY64q89bmjmXLIZ6n3RVEsiRzE2wmTC+ecREbgOGsZ+DwaB3C1z7Mq1evDO2uABiVMSXcptdvS80mjkoDeRMN3QluxKwOnNcy6ktwkNtdYmMQ1KlH4e8ztAyOo7Kj4VonEf659vJuACXdJygXDSUzLp17VC9RHGxGYYLfMVIoWJazLCOsq1mfCgWn2BlQShPXDdv9bKS+pvCreOAO3mRJReHC/HA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f++dYPPioHlXlt3NfMV6kobxpdWr5FyNTo0G7BlRj5M=;
 b=X6FL4DwD2JpXUqh1h4EBT56aLzaTdiERMbUjRa8S0SO8mRFlLMhN0FEo3saDPmdJSr3DdNmi9wAAtjWTrFfnl3OH6DXwLiKtZmxHoQv4Q8Dr7x8zSEbGzLa3Js2ZPBmSMn7Gu0Ba14RN09zYi8XTiSYdGT1pPjgZTgtw9wFL+bajtsdZPM0vodxK1TYV6H1LfhkfkhvqoGWc2/GMp8FoPyasqhvIy52eTX7jhT8uFfjt2Ei6JvMv2yAfzEvfitYrrD7dIYaVVRVzCf+WfnkG6+2DI6wIsy3yCnLEALRZaNlQRY9TB8QhSEebfuYgOcvZ2zSQrAVqOa1nR5ptSqt43w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f0ca952c-1d44-56ab-6b81-6bba3fe1c016@suse.com>
Date: Thu, 16 Dec 2021 14:33:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] x86: enable interrupts around dump_execstate()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <e717897f-980d-ad44-31d9-39f5e7e1c45e@suse.com>
 <ff12f0df-a2c4-ae9b-b956-a602cc0bb844@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ff12f0df-a2c4-ae9b-b956-a602cc0bb844@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P250CA0025.EURP250.PROD.OUTLOOK.COM
 (2603:10a6:20b:330::30) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2d95d627-fad1-4ac3-dc3f-08d9c098a0dc
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4848DEA05A7FDDD43B9D0CE3B3779@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PNP5/ocs9/LjcR2VJKTF+6SMkavNWosVyjOsCXFsDUu8VDIm5r/3qK4ZUKCz5knbDzSSY7wk3iuin5OLKyUFjYjLfFSkUOsB4jzrEGcMqFAHZx/je1TGvCr58eWc4Lp2j1q6s2n5v76QP+h3jbPoDfWvATDmdnGrQeCGOOpDeYY15npXBAMyRnuDWdx8WzTaJFAqIbaEvrll+KzCnVOypK+b0I+Vd3eINCapgxgi6Zj7uwYMiqQhrJq2l8e1vY4SkPcqIvBWCqF8H2ctAPCytkUwr/aqv1o69QW/mVyLA2OrWZX33xGN/7ss2gN2l4mwWFNjJgIt6t/YVOaZfHLoxgjak5qR3tGDm41Y3RS8lE7LQtB5WXbKjv4ci1uOAnLqmGxyV39b2fXMYAg8N8k9XQokrGa8P5ZWkS0/HVGxi198dhLBmqu3HAbCwOwEBpwqxqZj30aPh3rQJ9BPzgCUhCRcRj3h/6ezlgWugQ+49cLtqTNBEnNCMEHRkuO8wjg4je8DVUx45ZfVO8zjKlYJEY8maK5qSeCjMaed8ZjpFng7+2RxPLX0trkmC1xogp2qYixL54GckSqzZ6vPp7QnhIGWwsqYeIUWBzWdYFgiytUohdIJ2HUlcAqxo+1JdX3IwgLTuoMFzTUV1jnobFdO/Zo3jiZiPIrEYiRunUo+/ppWDw5J5iWj+ThcZCP6ysAe9/63Q/16nxJ/JqeROPQ8GP9b8g7rxHj2DrpGNPqiJ70=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8936002)(4326008)(36756003)(31696002)(6916009)(508600001)(2906002)(38100700002)(6486002)(26005)(2616005)(31686004)(66476007)(66556008)(66946007)(54906003)(83380400001)(6512007)(53546011)(316002)(86362001)(8676002)(5660300002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jdCLOHSs5T8dPT6qFhwAfaEXJXxa9Qu4MbKpJ/R4du05mp5CQoUpsv/ubRQi?=
 =?us-ascii?Q?hcqg4Xj3vCkNA4BZRllkI1uycjHeESdfR1xiR3FM2+atjj561C2V9IVRbCdT?=
 =?us-ascii?Q?gU2xzr1+anAPjrwdKgstlE/in9PaUdXQD1EYFmYKUE4+I8LtpTEM+Q0mfZn8?=
 =?us-ascii?Q?VnAkWnGWMlUrECkuwG2KoaAGee9CJ3ptsBLPD6z0Y1Zhw4XCHj05FLsbF/+P?=
 =?us-ascii?Q?RGNBqEOTXwEPF08W2m4tuR2c9uSmUxDmABHc3D/+LpgY/7hDl8Uhm+L00/UC?=
 =?us-ascii?Q?D6a1xAVO0wq+2vyq1VuzCHj85SjUh/3hT0Snaa3NQEJJD/JkRzUVlgO+gF0f?=
 =?us-ascii?Q?NyQ34rmY5qfeE8gYtkXaFhAz+5yOxd+C7cVVmwFZucj3mIOm7zMVQkGiUrMm?=
 =?us-ascii?Q?ZzsnDdb1Mb0gqxqexBkHhPLXAoqmNYAeGFmAHnLXjP/YR8cVUffY4n5/wydR?=
 =?us-ascii?Q?opPIKHidLNlEmmkJN6cWzo3dt7HdF+6xKknbN02ZvE2PAKpT0RWwhpkhd8Nh?=
 =?us-ascii?Q?HB6rSdgbzxi/fU7vdm6NtWjD7wQKJJN1CoTB/YZC7ObyRg86D0ovyAu+F42f?=
 =?us-ascii?Q?zxwD6waf/dLMvuUzOj8TWKiaYM4zgXdXES0w2KzQmSSV5RzKVx2V79FfGQMn?=
 =?us-ascii?Q?4UySaGVSOY5J5/H1lDOOdsoBO0/Yn87C4V6c68nayz/ejQf9HMFkKP+Vt7bO?=
 =?us-ascii?Q?PbbQYC7Bu0c8vvSk/AycFU9AfQuyHofniH74AORVxkqD/V1HbPRGOO6fNxIR?=
 =?us-ascii?Q?jsgtjYIy3WKr1w0AL17kxGRdIrN9zp+IIUJD+2cd94pazdXEOsrF5u8mu/7K?=
 =?us-ascii?Q?KMimW0DbjP4b8mRtFsBeRBwUmb0u42dFqyJZ9TzTGGyJ0qxS2YAolVOiymrM?=
 =?us-ascii?Q?4QOHxZaNRJQfci/udunRN1vyMQUn0LUZyJeP2ya2coauexogZ2Hbulc/Es71?=
 =?us-ascii?Q?7esUTaeUdLbJc8Gu+piCaxtfXBcp77yEh78yhRAKCVo0Vya79vpKy3R8+WPC?=
 =?us-ascii?Q?ZjvcJA48w3mhK6yb32DTR9JbbJ+AObBuDmT5B32FFrhS7I5SdtSNWU5xctur?=
 =?us-ascii?Q?qfMH7J2X5JxcoEzoZE8zLD4Pv4QwuGBytDXEc2bmMV1lgiE9Ck9UACJlWVkU?=
 =?us-ascii?Q?5JfaMZjX4hXtqFD/nSbWH2tFIEoNsWCnCpJ2EMr3plrrh1QW/wNw+jY3S5VG?=
 =?us-ascii?Q?Tlv3ycYKz9TrhXiGLGfOo6yBmgVKLnXwIrujzT4CTcJNhl9p1fM28a8/zUxR?=
 =?us-ascii?Q?KRdldMRmKWXzcjn0w/kVsXZc+ioVPdvWZ4nuSBSk41YQ41VOzwLEcuZU+12m?=
 =?us-ascii?Q?YXrRtJ9KB7H2xffWcmh0ajRhBrXdwO4NuHMkGo0xOwC/e7COV0zDG/5Q1NWL?=
 =?us-ascii?Q?FYY0wPO2Ues+auckXd1FzRgIVKCyEXUY8zwuE3LYTdQRYkdAINq+ctftYcnX?=
 =?us-ascii?Q?ibl+g4ooujTVs9zNJULiyUCHpZcNiqdESQSz1zNUaKw2SegE4ecGfoE5EKNo?=
 =?us-ascii?Q?NFhZX39keXY7rc2IBO15E18x/O5FbJKXxfP/E+5GQECi8I3oxrkWoxutqm0A?=
 =?us-ascii?Q?R3sX2JQ15jS8K2J30YSQCHWbBNHwJQucxclG5bo10Xb4yvFD/yPSoNq0iYr4?=
 =?us-ascii?Q?Gyr5iGFRKevp7ud/d4k+Q+E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d95d627-fad1-4ac3-dc3f-08d9c098a0dc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 13:33:21.7655
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WQfCEiFaZ54xBsKBQbsBCn7MDoqkJbdPOfuSKzyr9F0O7I14H5zYm0hJcm1T1EH/tm1jI6MCKoQKmAVowwGBVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 16.12.2021 12:54, Andrew Cooper wrote:
> On 13/12/2021 15:12, Jan Beulich wrote:
>> show_hvm_stack() requires interrupts to be enabled to avoids triggering
>> the consistency check in check_lock() for the p2m lock. To do so in
>> spurious_interrupt() requires adding reentrancy protection / handling
>> there.
>>
>> Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_stat=
e()")
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> The obvious (but imo undesirable) alternative is to suppress the call to
>> show_hvm_stack() when interrupts are disabled.
>=20
> show_execution_state() need to work in any context including the #DF
> handler,

Why? There's no show_execution_state() on that path.

> and
>=20
> =C2=A0=C2=A0=C2=A0 /*
> =C2=A0=C2=A0=C2=A0=C2=A0 * Stop interleaving prevention: The necessary P2=
M lookups
> =C2=A0=C2=A0=C2=A0=C2=A0 * involve locking, which has to occur with IRQs =
enabled.
> =C2=A0=C2=A0=C2=A0=C2=A0 */
> =C2=A0=C2=A0=C2=A0 console_unlock_recursive_irqrestore(flags);
> =C2=A0=C2=A0 =C2=A0
> =C2=A0=C2=A0=C2=A0 show_hvm_stack(curr, regs);
>=20
> is looking distinctly dodgy...

Well, yes, it does. If you have any better idea ...

> For these kinds of purposes, it ought to be entirely fine to do a
> lockless pagewalk of the p2m, because we have to maintain atomicity of
> updates vs the hardware pagewalk anyway.=C2=A0 We do not care about any s=
ide
> effects if the target isn't a RAM page.
>=20
> That ought to remove any IRQ problems from the equation.

First - how do you suggest to signal to the page walk logic that there
should be no lock acquired? And then I don't think there's a direct
relationship here with what we need to guarantee correct hardware page
walk behavior. Unless you mean to suggest that here we want to rely on
either locking or interrupts being off (the latter guaranteeing that
flush IPIs wouldn't complete while we're still doing software walking
here).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:37:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:37:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247965.427640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqwc-0004ge-2K; Thu, 16 Dec 2021 13:37:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247965.427640; Thu, 16 Dec 2021 13:37:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxqwb-0004gX-VO; Thu, 16 Dec 2021 13:37:13 +0000
Received: by outflank-mailman (input) for mailman id 247965;
 Thu, 16 Dec 2021 13:37:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxqwZ-0004gR-Nu
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 13:37:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 42b333f8-5e75-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 14:37:07 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-26-uIp0xxvcO_mK_aUYrGSewg-1; Thu, 16 Dec 2021 14:37:05 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 13:37:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 13:37:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42b333f8-5e75-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639661826;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=e+dG3AcOhEuEPZHSzaBzdnp78uBlkrDTLtnnmzTW6hM=;
	b=glmPhV7Ct3j0KkxWaAta60w0WbWZAjGxHFVieLANTHCVGJXr/0BX/bj1oVLKXTzgEWWQ2x
	APZaMSw+9kbbLwpixxr7h1I1Px5H9Nb5+UoX4rdQCtkuMl8th5d9o8TOB+4OYbYz5D4OAe
	baFkAFRdpzh2xjbbzsom+HRrE1O8T60=
X-MC-Unique: uIp0xxvcO_mK_aUYrGSewg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MACzCuYsFnXM6L7WpKa6uDN5Gw/Hy/F2d8V70QlFHWgytLFFJIRYpn9WioaLp1jy7oBA+fpbyDXaX/Gu4ary7OR6CghsnX4ECJavsoefimHy6h40Sqgv6TVazx8RcB3q70aJL2DiMMzXp8gnAylJR8X0mO3mzvK136TTgev5UB7MjClTkTiiWrDfTxcFzqWI5lXoDkLQo9qNkLiAB0yRdVO7jbNqIOwfBLmbP3yMo7TjBkMPJHbjd+jbSE7NW+Qftj+uFGyLGeGOeJ9lOvlDEX7sn5DqXoXs7S8NqylnnZZA9dT3+aprj2jT2EHJfjtj0wRDKsj9I/YZP9r0j1VPHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qT7xr7hdGE4XxBPRqmeo2STYje58FlwKMlEugnsgRpE=;
 b=nvrhnWjO9/7a3y+2BHHhLQs9yDa3drsvjInY49gEE/AHRlmGTc3TwwmS+IWSJyvhSBOI6OAxkOP/TYz26mYkM1fzop+UyxTq3f5jtA4xJil6XxBB6MR6Kye7LSahmRa0U7e14V7FIyaCxSD7FWdl0kNIZyeifwztAxZ34VrMyng3tO384oMXaV/NvgnrFLVlp2GUFzkCI+uVckQHKsTe6YL0cZDbiAJ5kJKQX03IUApkUjc2Ju0DIEU9xBJccSknA8yR8uI24GqMSjUDrD9NdG6zl1eYFk84p0ucW1C1U1Zjv3PSCR/o8WElXN27qa91trTl99GVwRsH7z9H2vi6gQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
Date: Thu, 16 Dec 2021 14:37:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Rahul Singh <Rahul.Singh@arm.com>
CC: xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
 <YbscoZG/NRP6lMof@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YbscoZG/NRP6lMof@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0259.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::24) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 529c1df1-e74f-4b66-723d-08d9c0992575
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB484867AC775E03C51B0BFE32B3779@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pMKi5AhiX+2/O1/5wsUV10e5VFvXifF2wXAzPvNm3Px153FgsT5KS+SRHw0YlRNje7Y5qGFVROZqQWijwpW2ZKqoOw1JeHx5YUN2A+ZyEGFYVk6NL1IFt5+25B8DtguSJ7PZFTJuOkTvrjSzVHjWnTDSRJ3kqbHz6H4YL6MAcraG3OfzWFDTsNZ6Yt6qiqeoAEKr5W66ppHDLsSG8HK7isYsSJMur6OQAeE5Hyslj9BvIsp+zRGnTXFis/GGZHGpJAADC5msNkD++wLroT6Okz5Fg1COtMxmSogK2dQPfaDM3H/A0cZlOh4OWlnrihJOXqge9nnNvPmJxY9VNZ1Cwj7wndXhTVixdzuWgs/pNqOLDbjN6IT4dV+D/T0xNk42V9BzInlKq0NXkBdIfZt0T9xywb7itGAujqCVQXwuAPRQgg2iGBrxlskIFzX57LsadehbBIzlZocyxV6xvTQ7HDKWgvVm5Qlz0Ay/m63nWzvRZRinhNejFnADw7D7Akz2tFFkQAgGha1+4iETFCjXACKREqT1mUevdbOuxiMHEMJ8KxW66/WpNX9S7McBdjAd2vk2XXKr8LvP7C8Ec+/8Gke238HVZoRbPSw2K/LtpLWRj05CIugoIcvFAKG84+DrAliD6S0ESbgOc4auY+G6DiqRy468MzEMV30gchfVUg+C8ZT86vSovZVcwRwbgS2kMF5xoE/nSBLpGzWunVG5wm+7Pn1qOE8skmJV8WBCfjR2dZzLeVsWwzX8jPBpz70a
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8936002)(4326008)(36756003)(31696002)(508600001)(2906002)(38100700002)(6486002)(26005)(2616005)(31686004)(66476007)(66556008)(66946007)(110136005)(54906003)(83380400001)(6512007)(53546011)(316002)(86362001)(8676002)(5660300002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vqDt2v8wKFVOIUDH205pEFD/Welg3w9Yc3w7AxExLSt0gJoxjEqQ3+FPs01B?=
 =?us-ascii?Q?t5odD6Mr4E4vCZO3hFnjnpIiFUffpkdo17wUK+9eyAhQFdSN+IiYhUM5Ixv+?=
 =?us-ascii?Q?H/m8tCqSMwGqnyBgwZOICPPnbbN2GcHimJk4J3gg/WicueIY3k/S7zd3WI1y?=
 =?us-ascii?Q?a6vBFFpRzcOXCi74rWZzaw8sTuanfaYGdPahlD/o4zs0KqeJVKsf8i9pz6fM?=
 =?us-ascii?Q?kJXQY98/xpFPf4WfHaPwjhHuxxin4F9vPdb/hxCMqsTUfeDdfy7nkFlmWMYd?=
 =?us-ascii?Q?89qJpSucsQl9P73X8NhF7xKEghhXr/rA1p6lY3+7cqf64yQblcPgNQHS2evZ?=
 =?us-ascii?Q?J1mf764PLrzjAfj31oR9zgBCmlqrm0ZEWQ2Ns3IM7D85qfLJBxg/0/AXAfUm?=
 =?us-ascii?Q?+Ze4sr8feDlo556lGZQuc5fAQ+xPwAU/3fsra8n/o3QdvAhPSBNFJfkT4nn4?=
 =?us-ascii?Q?7uXHohOmM20C+bM9pcgvdclKFIXwvJOLLAbUKWRbxgyc0heYxx94d6dhHk0D?=
 =?us-ascii?Q?RhvtoscNfH/l0/4/2AAa7pesKr7LqNoFub8WgRiqKNZcQd427mdYwIpOxTZg?=
 =?us-ascii?Q?2rmV0Pv4pjQ/hkaX9CvaoCzJkoPtrb0She9yVQUAKhj/Sb1EHVTmcX52Lx2t?=
 =?us-ascii?Q?NvAFUzjp4SFEkH7MZm1vu9RIeZWr4t/Wlb6YxM8zDansQAvFNjt/lCTqqMa5?=
 =?us-ascii?Q?OP67K9BpCApYBxuph5LC3GOP1Ld3Rdt/x/fharr0rRVFlviCp/6deC+EVR54?=
 =?us-ascii?Q?E0q6pXi4IY3d3c6ss1zkirGjYU79pSliqRl5rLED73Vugkh6cs7Mj+9BjrGa?=
 =?us-ascii?Q?yu55NFrVXmnvjRfO9QMd9bXzUfzviPIYBDHVZcMPp2KlEJE6fHmQHWK9Fs9w?=
 =?us-ascii?Q?YNNH9MFdP0DKhEBAbbv0EW3G7w+RZHM8locp4GlVP1obbfjzc0ng0z2GPOpB?=
 =?us-ascii?Q?qHOfRmLAJfW5Y6lMnkXQMHZhniONL+XnnHtBS29JXQEGhfbw/oxRYq7U2UZI?=
 =?us-ascii?Q?oBP8/wjVaT4jpu+4YKwsZkCzyvyVGnYrb5xoxb0ChP4GO7JJK8IoRRjRdFQK?=
 =?us-ascii?Q?P4s5xTNM0aL3kROtgn2R8BQy+trJE66FSTIU4K1jphispbVs56dzUtYJjbif?=
 =?us-ascii?Q?akOZH+bxbGvxd8Z9FRlnBkJluqH2agDbRlUQj6Jq5RSv/3uZeZm0tNoVIYbh?=
 =?us-ascii?Q?MM5ZjXo0J++lno/pbdJehQ0ulOSAI5ff2/Q/K/yRZKtssWfRQNQL37wvqWt1?=
 =?us-ascii?Q?SjJJOlJLSp1i5nkErhnZ/ePmgeXHyaAkCHG0mX59k6xkDTTbPZkWDyX2ODYG?=
 =?us-ascii?Q?k5vy2D0a/s/DcuOblFdp35PYOTdXpdhPLpp0Ofr5HP+jBrbPgNdw19Kxcn89?=
 =?us-ascii?Q?SOCF6mI25KN0K0WX8BngNuWBBBUzFYjE9FYfJKTV86EjInKpDI0psx80jTuZ?=
 =?us-ascii?Q?U4IoOMWJbrlo6nnOAfw/ryfU5JEWMABoC6Ww4sZmTx4qFHxrzzzCWHjyPFuV?=
 =?us-ascii?Q?yC2+3XlnSL/RLMZI5B1Rtg8uwaXLdTFHpwCJnZQptn15tp3nnzS1kC67UqYF?=
 =?us-ascii?Q?rFJAgfcqNhAFcSd1YWxP1dHXE5zTimYOxX8rZl/sj06vYa21gefXvN5pllgm?=
 =?us-ascii?Q?SyQnUIzPflERqtQcB3Yu27Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 529c1df1-e74f-4b66-723d-08d9c0992575
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 13:37:04.2118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qKRTy9dYd8uEpK+ZSEIQlEGs0wtGfodp5AkMCs3NOZuZ3CsNsV7w86lT1kn3U2jlx3SMWORUc4k5gVudhAy0cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 16.12.2021 12:01, Roger Pau Monn=C3=A9 wrote:
> On Thu, Dec 16, 2021 at 10:18:32AM +0000, Rahul Singh wrote:
>> Hi Roger,
>>
>> Thanks for reviewing the code.
>>
>>> On 14 Dec 2021, at 12:37 pm, Roger Pau Monn=C3=A9 <roger.pau@citrix.com=
> wrote:
>>>
>>> On Tue, Dec 14, 2021 at 10:45:17AM +0000, Rahul Singh wrote:
>>>> +              unsigned long *data)
>>>> {
>>>> -    const struct domain *d =3D v->domain;
>>>> -    struct vpci_msix *msix =3D msix_find(d, addr);
>>>>     const struct vpci_msix_entry *entry;
>>>>     unsigned int offset;
>>>>
>>>>     *data =3D ~0ul;
>>>>
>>>>     if ( !msix )
>>>> -        return X86EMUL_RETRY;
>>>> +        return VPCI_EMUL_RETRY;
>>>>
>>>>     if ( !access_allowed(msix->pdev, addr, len) )
>>>> -        return X86EMUL_OKAY;
>>>> +        return VPCI_EMUL_OKAY;
>>>>
>>>>     if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>>>>     {
>>>> @@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned lo=
ng addr, unsigned int len,
>>>>         switch ( len )
>>>>         {
>>>>         case 4:
>>>> -            *data =3D readl(addr);
>>>> +            *data =3D vpci_arch_readl(addr);
>>>
>>> Why do you need a vpci wrapper around the read/write handlers? AFAICT
>>> arm64 also has {read,write}{l,q}. And you likely want to protect the
>>> 64bit read with CONFIG_64BIT if this code is to be made available to
>>> arm32.
>>
>> I need the wrapper because {read,write}{l,q} function argument is differ=
ent for ARM and x86.
>> ARM {read,wrie}(l,q}  function argument is pointer to the address wherea=
s X86  {read,wrie}(l,q}=20
>> function argument is address itself.
>=20
> Oh, that's a shame. I don't think there's a need to tag those helpers
> with the vpci_ prefix though. Could we maybe introduce
> bus_{read,write}{b,w,l,q} helpers that take the same parameters on all
> arches?
>=20
> It would be even better to fix the current ones so they take the same
> parameters on x86 and Arm, but that would mean changing all the call
> places in one of the arches.

Yet still: +1 for removing the extra level of indirection. Imo these
trivial helpers should never have diverged between arches; I have
always been under the impression that on Linux they can be used by
arch-independent code (or else drivers would be quite hard to write).

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 13:50:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 13:50:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247970.427651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxr97-0007Ee-6i; Thu, 16 Dec 2021 13:50:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247970.427651; Thu, 16 Dec 2021 13:50:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxr97-0007EX-3Y; Thu, 16 Dec 2021 13:50:09 +0000
Received: by outflank-mailman (input) for mailman id 247970;
 Thu, 16 Dec 2021 13:50:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxr95-0007Bl-SV
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 13:50:07 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1352bb40-5e77-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 14:50:06 +0100 (CET)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-5Eh3yvklNAaomexX3-lprQ-1; Thu, 16 Dec 2021 14:50:04 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Thu, 16 Dec
 2021 13:50:03 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 13:50:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1352bb40-5e77-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639662605;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=uA6tRfloT3vh9c7MuLZ1zE6HnbJN/MKTiqJ/rO3B1FU=;
	b=hdrQ2wp/VonDOzwXq+5GTFeRYPezCsS4dT820mZ6/JMHXFunv4iLuhuNn0cRlgTIqXVt46
	rXDJK6AQtRXjKwJ9GKM56ev6FFLdSDaEEjy7MqXqh6BLCKYzJ66gooq/5gckrDEW+sQxZf
	b4n4Yei2K0XC8rB3gdecDfCljKqubmQ=
X-MC-Unique: 5Eh3yvklNAaomexX3-lprQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kSex8uAYQhj2neENTZpduxeICUVIh8Ll31xxTFWsaeD8V/hAJq3MzT7NgLIAK3s9kJFI1xMoLpzgtaKu3fyjCK/g7MRPe2wskmRwJ9l3ADh5C29N/gi+votyPRAWfAVgmAtnTea6EvfzqzUeI3NOs7GWJ69e1MgQZkHkx915HyNmgvNHoT8/Yiu5cl/TdWFfaifVYX2gFAdGedol8FkxwLmiPwfxr25RDpChSownzr08273dIBD5I05oXmOEjdwjtIEleaGmH/IP56jnT5849yEm7a+pAwKmgyo13/E0uIogEg75fUvbxjRuggsxIXBpGWSLxLFbgph5y5jZc+/New==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uA6tRfloT3vh9c7MuLZ1zE6HnbJN/MKTiqJ/rO3B1FU=;
 b=hVBTRDoY6rqwprZHByhFt3jEeHn2BAL3UL+5BZo43OoDAe7AZkxaJe+C30wqxz6YhAMYOO+PED6HbmNHeaHR+24I6iHwN34vJhUgxDG9qg4Z5a0Ey/YV+qIOPUfKcSIAmuyLgCE0WWrvjlozwGDvLuIdNMOyQwdQEp1VJ6dwniLVPi0VIGp80zyCt7qk+mS6myoN6av8vvruAkVZpdBrijG7VbqsKvZiDT/4S6xk9+mHUKlj5PeFS9E4ph5bIz7mQjP/SGMJPDp+xi9jCYDSpsnhVsH8lcaaO+chy15gBCD0B0tvMuFbbVUOCR3USt1//PJBeEp2WFmOR59PVu2hzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
Date: Thu, 16 Dec 2021 14:50:01 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216092134.579-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0106.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::47) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9b5b1c29-7869-4c8c-46ec-08d9c09af5ba
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB26071805856CC661A07AB630B3779@VI1PR0401MB2607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YXFSa2Rd3dV7uS1mdVMHCj4Rb0a7aDjMXWNKssv7RmclXZFKN9NdU9IoiI5xOiGXW0e+C73Fgxot4HsN67bfE7XiiulewfBUANvAH2BjhQk31qyCW5oNmBvGLwc3EscsUSs0fZZZnlikwMTTt+9qtS7ATBQai6mTurksf4pcML2fkQzhXcO2yaD3Vf28rqBMW1A+jcwBeN3eJGDRrZt+TCKn2yD0LMOcGTWrH/5e56m5YpLbNwEozJiLg2+90llmkvTW3L9ti4mN8uc0/4NTzvbjE3P39fpO+tSB/zgWBNMk7vZ6oDFGCw+72Y/cp/c0HpXo8QhiBPTpSBUfJ8XG2/FNWRCH3LSHog2Cnp7ANTrkcY9x5VRmL8xd91KCRNGP3g3kwElszA4r3/bVoNnemq5JIv8dCtrOlqVUqkZ4y7wswA0q1HDjhIp7hnAk0faoMrL+blJ9pLHa7n4xv45v8Az2oxSaaaUlgqtmba8umchQeIXkIATgUd8riSfymghZNVn+3sxpJk38F24uWUJbIB6IBOnMmcli7v1xRNIE32bMi+e+6rZrz6jRlTPRJGiJkFZBY5OFjPIvExWjbYlI8EZMoCYrSm43ufOmNTW5gQvY3EC3CdE4HNIsFWwlfEIlm9E8Ny3tJLfp5cOqaUSxM5Hj9AvoSbPNdy3DONRl0K5DEs1ANti+7h9vvUDFa674XF/vxoB3xRRnaJxNgxlLpbzt3VAJAxZnrJNvTIOYzqk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(26005)(186003)(6512007)(2616005)(53546011)(316002)(6506007)(8676002)(38100700002)(54906003)(2906002)(36756003)(86362001)(6486002)(508600001)(83380400001)(31686004)(66946007)(66476007)(6916009)(4326008)(8936002)(66556008)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YnlWMHc2WEpPbW1tc1hyZm04STEybUcxMndQZWl3TmY4cnhnWVNXQ2dHdDhL?=
 =?utf-8?B?ZVE0T0U0R2Q1QU5MUzhMOHlKQWNxVjFhcHhGUlFtNzFzUkNkV2VJYWUrazIr?=
 =?utf-8?B?WkRZdS9sVUFiSU1ENWpUNVlXTTFoWEU2T3BSTUZJNGZndndVQTVNZ3FrOWhT?=
 =?utf-8?B?RUJqMnhEVHNnS2FYaE9kbEhBSVB5M0ozdEtOODlUUWJjeFpyZkNlbnErQ2Za?=
 =?utf-8?B?cmN2dDYveHBFTDJxTGhPN3NtN2xya3MxdFAybDQrY1VwRVJwdmJ1L2RKRnpx?=
 =?utf-8?B?TUNQYjZ4OWdBUjVENWI2YUV4b1JpQ0paaTZjaG1STkI0TzVKYlNiUlFhdnNj?=
 =?utf-8?B?VVVpb3JjZmFrWllMUFhXYmp1QkF4aWdtTExFTklheXNmaEh5alZ0OG1rSWdm?=
 =?utf-8?B?aEtZTmJPUXIwbExFSDFsUnk4WGZCV0ZXVytkNVZod3hvWmtiWFNqM0FXVVJw?=
 =?utf-8?B?WXVObVp4M2R3YXRZWllWcGo2ZnJxTXJkZUMxMXFnR3IxeUtkQUxtSHBncDNs?=
 =?utf-8?B?Q0RLc21VbVRmNjdmTGcvUjI4MEpLWmxmZllFY09MM1BtbGxBZEh6K2JMbzJs?=
 =?utf-8?B?Qk40UjlaWW1UeGh2QktQY2FTd01VTWtOUkhCVEFZVFVRMXpkYjFEckZNTk9u?=
 =?utf-8?B?djlUQ1ZnTktKbkM2d3VVZnZrYkhNY0ZGcGQ0SnNIWVhpLy81QjhQUVoyNnFs?=
 =?utf-8?B?QmViZS9uYmdZdDFnemw3ZmNVekwrVDVoVXY3ZmRWcEVvT1FKVG1hNkVMaTRi?=
 =?utf-8?B?blE2NVhwZEg2bnNUTEErVExsUnU2M0J2aHZweEFJT2xDZTFVZWZ2NWZGSnc1?=
 =?utf-8?B?eU9SZmZXbDVpeG41NUJmTXBjZXc1b0xNdSsxV09Vb1lrd0RtSzY2WFJWYmtJ?=
 =?utf-8?B?eUxjbnZNVEpBRlZVY0NScDhjKy9EQkRnK2hHVEVPYzkrc1hBOURCYkhhVkhF?=
 =?utf-8?B?TnI4U3F6Mmx1SGpZRHBJOWhrTE9TOXVQOFpPejhyZGlOWkh2RHZXWUtyRVRx?=
 =?utf-8?B?MmFla1cyWlpjNFQ0TjM2TjY4bFRqMlRPRUFtMXEveENzb0ZiTUVxWXdOQXpP?=
 =?utf-8?B?QWNEbUNSMkxwbS9mb2J1Q25OamFpR2ZXQjRKQnlrN2cvUEFTK2N6S1VudlFX?=
 =?utf-8?B?bDRzNjdQeW56R2RKY2wxV216WDFpY3llWVM1a1lGakYxZ1J3WlBlY1NKUUZ4?=
 =?utf-8?B?ZGtRaGllZitTS2xIMnJwcHduZ2tTSWxLUUo1SkEvd2RtTTM1T3lDUGdqZjRQ?=
 =?utf-8?B?VFN2NnFSSmJwMytySkdrV3Q1WkFScUtGR1YzTFFDMHB2eGhvenJFSGlRU2JF?=
 =?utf-8?B?MkJIdTMxeE9mVkJxdlVtUVRJSTFhUjk4c2ozQ0FMUGFSM2dtNkh1M2huQlo2?=
 =?utf-8?B?ZFRwcVh4WXQ5b295YjZkWDNCZTZscDBNVVEzbnFLLzMyS3BNdC9SRTNyYUR0?=
 =?utf-8?B?K2c5cVBUeWh2K01XeEVMNDNheUJRdVhJVXJpWVlwbzNaS0Rid0hkY0FDeTNS?=
 =?utf-8?B?YUNqRTNzaC9MVGc4MTZpaExwV1FCTGZ4SmI1OExLdElBeEdvb0k2SjMvdnRQ?=
 =?utf-8?B?MCtMdzV3UnVvaythYjBXdGF1VjRYcjlUSmxZdTd4M3lqTUNYYUFoV2ZBWjZo?=
 =?utf-8?B?eVk4ZDVoQU1xUkZHeUk3U0RlMzFZM3ZUT05mSjRLUFdWRWhoNWZ4aHZEYngx?=
 =?utf-8?B?Z3p2SmNRUzlrblJQQm5yWERJb3N3VnFvdE12WnR5YWpPTlIwUnk3OFF0MG1h?=
 =?utf-8?B?djhjdXFzekZwVmZSRC9McFFTa3llU1F1Q3JmdUgrVS9GeHBQdEU5WDUrT0FL?=
 =?utf-8?B?VS9QOTZlbi92OWF6YnM4ZmRRSGp6SzhxQUdlbTJSZjd1UVhjU1ZtM3NON1ZS?=
 =?utf-8?B?UnZwUGsrSFpqZjJDbHRESWVBbXVhdHgxM1h4MWFyTVZPdjRxVmZ1ZmphVmNU?=
 =?utf-8?B?RnMyaWtIZzQwWnQvTk9kazNUb0NnVGl4SkNaUXhxb21FY2d6eUZ4RWg4bzJy?=
 =?utf-8?B?d2E1d1ppUWllQVUrbFVySW1ZT3dBak5BSVlFL2ZqeUw0dGpGY0QzUXBrZElt?=
 =?utf-8?B?bndnQ0JGQ2FtR1NibEVlY0hJemtKU0c3eVpBc0NGd1U3QWZYT1ZpK0N3MTR6?=
 =?utf-8?B?bmJHc3M5eitBd1VzeDJPaHVnbnZwZkpoTlYzY3V1bE9KeHJEY1kvYU5GbzFE?=
 =?utf-8?Q?LW/RmSljwsL5BSRM9aKfD1M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5b1c29-7869-4c8c-46ec-08d9c09af5ba
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 13:50:03.1467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4S2eMgSsEiHcr8SYFQ4FBFEXjWdWKvdZacQ86xm5yT993Fip6l/OPzcP+pVJpUV09QpwTUQlgcytcAlavbSyVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607

On 16.12.2021 10:21, Michal Orzel wrote:
> to hypervisor when switching from AArch32 state.
> 
> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
> "If the general-purpose register was accessible from AArch32 state the
> upper 32 bits either become zero, or hold the value that the same
> architectural register held before any AArch32 execution.
> The choice between these two options is IMPLEMENTATION DEFINED"
> 
> Currently Xen does not ensure that the top 32 bits are zeroed and this
> needs to be fixed. The reason why is that there are places in Xen
> where we assume that top 32bits are zero for AArch32 guests.
> If they are not, this can lead to misinterpretation of Xen regarding
> what the guest requested. For example hypercalls returning an error
> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
> would return -ENOSYS if the command passed as the first argument was
> clobbered.
> 
> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
> Add a compile time check to ensure that save_x0_x1 == 1 if
> compat == 1.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
>  xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
> index fc3811ad0a..01f32324d0 100644
> --- a/xen/arch/arm/arm64/entry.S
> +++ b/xen/arch/arm/arm64/entry.S
> @@ -102,6 +102,30 @@
>          .endif
>  
>          .endm
> +
> +/*
> + * Clobber top 32 bits of gp registers when switching from AArch32
> + */
> +        .macro clobber_gp_top_halves, compat, save_x0_x1
> +
> +        .if \compat == 1      /* AArch32 mode */
> +
> +        /*
> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
> +         * Add a compile time check to avoid violating this rule.
> +         */
> +        .if \save_x0_x1 == 0
> +        .error "save_x0_x1 is 0 but compat is 1"
> +        .endif
> +
> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
> +        mov w\n, w\n
> +        .endr

What about x30 (aka lr)?

For values read from elr_el2, spsr_el2, and esr_el2 I guess the
hardware takes care of the high halves getting zeroed?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:00:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247976.427662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrJH-0000W0-6I; Thu, 16 Dec 2021 14:00:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247976.427662; Thu, 16 Dec 2021 14:00:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrJH-0000Vt-31; Thu, 16 Dec 2021 14:00:39 +0000
Received: by outflank-mailman (input) for mailman id 247976;
 Thu, 16 Dec 2021 14:00:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxrJF-0000Vh-Uy
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:00:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b3fd471-5e78-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 15:00:36 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-ixWsouYaP-ioJc9jZna7rw-1; Thu, 16 Dec 2021 15:00:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 14:00:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 14:00:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b3fd471-5e78-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639663236;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8UE9ysZnnZMtzNOvo68CEBc6e1obdUMxjlIfpT34rqQ=;
	b=nc4dYqYeTglf4GfmHJy9S3xMMrsX3plZnvKw23HKOjAHb4l8Ttk9E9CoD8YnVrpPiVRrSM
	bHcVZsEIv0qabPHOAI8fGFNXKMMXwyBrBAdOPEV1OXlFehdPCXoOQcVOR7iTxn5Bf3T4Ru
	rt9GQsh+ZgoL5fMBj0nrXXfV8Qig5yY=
X-MC-Unique: ixWsouYaP-ioJc9jZna7rw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JxAA4Siv8aY9nK7C3eSJAvJfpcT78kPwYkJMch0XRiOwOi21eWoDwgYPIQ41xBL7zNyTcCcjQcxfZ36QaloQWEvX1dG3BlGIhcsxgD91na8qF7W9UKwMO/U0lGbQed3mEZEGSohILFgKNmzAyAQs1Gc3PDcaG18GovN8EWAIbRJgCGAikFBFzqV5J8DsoeboFp5Sjnm17IRn/xlpmYgSJAY47tLZILrNeBgNAKsskfk15v1N38lgIcUE2W6vP769XC06QZRUmLSB5O9CAvZ9pQbx2ZAT3Ah+5N9JbeDKv582yn9E2Qu4UUaCcu7oIbf4Nzog33zudxCq6FZDwT4f1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=8UE9ysZnnZMtzNOvo68CEBc6e1obdUMxjlIfpT34rqQ=;
 b=ciKovPzCI8sk2RGEK/8yQ5PSWO8naF6bTwLm2YRX+0LHAI9WP/zG+fCtDNleHaOsYupDkdxxHMdZrqlCNU+C8M2D5FryvR805HOz8+i88IQ5bxCQLQJbALc51YiMGa6l2MJaCbDeBTnt2zL0buLYWERS2kRZjKOOFHq6fMPwg4hHCs5IgCcDjAENcrmCkXECLzuKd1+fSnaBG+9rMIolAFj9k3xLZojJPrLDdYU7rMSrRncxE/Qql/pgfbJUFWG6R648xGO3d5mxnkQbVTcHl9zmsMh9nt5M+/qhYzoQVCHhUhL1m6AZsuQPgEX1ABMvMc1v04KBwLznUhqPk5edcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a6dab969-ce3e-a328-03bc-c27abbba0448@suse.com>
Date: Thu, 16 Dec 2021 15:00:29 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216092014.707-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0009.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:2::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: abb1fd67-501c-4ae5-a89c-08d9c09c6d1f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4848:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB484811E7FA6C43DF5FB27AC8B3779@VI1PR04MB4848.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	S3r0WakVH8XnP6hSHAMICvmdtWA7ean1Ir9KwC5AUfTHf0voiBEZREMJXcZcwcuC6by8UkdARDF1JEn/wGicOsfhPRtPBoWqEKJskXRCpp7sRRZwTsrBgKU/oqcxIK0IIurZFepQe7eHohwwB8daAGRfZA0BVw3Wph9NWj1s/89lVnC4YjJB+Ja+M0hXa5eZdMtcQvohCrUQH7tAStldGCHiaZ1W5buGaW5wIdWBRGd7yDAOoi5P7fATBJ+Kdxqt2j7IJ6P29aOSGj5gauYz4AYho0wpmWb74+a8auKGeGZM/WJ4jAx+bvOUifijLo6HgTK4IrqOD9xfoAUh3OVzjLfok1gKqYMrTAwX3z638UnfrB0Cpz8qJlgMaCayVpKpvC5GEiO0VB6KfksXoWi85LDMED85j2Upd3XISZ1CCT5I8vACWRQfbXh3JLJnmHDv/IFgmaeJLV94NA0pLjyF4EsAZ9tGIfkq1jm6+ApznZG8bbnei6lMj+qpsqpjc+oZqTMu0rzFHYYkVagCjZ4Oe6KGTSMVFiIOJWMdJUZHI1RVkmir+7y4QCS8tAoeQm7NWauyA39HUQpK/8l6eEbGBjNFwtGVGdbvGMRKsr6/VR1vNMvXqfGYO+/hCq9Fem60d9prafgxXiAZ4hElzlvzl1RsxNSZsTDtAyYDUnx/R3eMPFS2fAv/zjfRlhCz+KOMEdfx8UO4CXPXSXNG1svUk61rnQqM36dlGKGmvxBCZbBMsm4qFgND8dSfoOrmV6HmQla0fz/QloZe7vC657CLwg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(6512007)(54906003)(6666004)(8676002)(86362001)(5660300002)(6506007)(53546011)(316002)(508600001)(6916009)(36756003)(31696002)(38100700002)(2906002)(4326008)(186003)(8936002)(66946007)(6486002)(26005)(2616005)(66476007)(66556008)(31686004)(81973001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VUw4STRrVXEzcTRrWFZzbTlxeWxLVTZKR2hYdUJqdFNHNXBBM2xSdG1PRUE5?=
 =?utf-8?B?YXlJa1hVL0hDOUFQR1lOQzYwOE52eWRIY2lYQm8wVG9qWUM1enUyN1hOVzNS?=
 =?utf-8?B?RHBTZ1lNblhFbU16cXFsZXptZUFBRUYrQ0ozVG16bXA1eWh2Y0NHRHkxK3F4?=
 =?utf-8?B?bUgvS1NBUi9WdGgzZnExd2VNbW16RlpTaUVwRklUNWxHdERkdVRHdTJxWFBV?=
 =?utf-8?B?Mzk2M3hZc0phd1ZjTzlUd3J0eS8zNTJ6d3dzdVo4dTEzelZidDRNelJYUlIz?=
 =?utf-8?B?Kzk5bFpHVU9EWGVzTG5SY2ZkVVRwL1h0SkpVVzJlMm9KM1JiMHVuZFlud1Vz?=
 =?utf-8?B?bFYxbFlxRW0rS1duUjhUWDdGN2lrdk1jMUI2ZXBzZ09ESkw2UEF0SGtIREFj?=
 =?utf-8?B?MWtmNzRHdFVOd1VRU3UyUk1RMENJeXBQTXN2MXFORFdDcTBDVm10cmhxR25T?=
 =?utf-8?B?Zkl6SDJxQTkxZzVCYkE2bTJYYTJLWkpVdHdxaWt5SlpncXJ6UDJNZ3ZlTWxZ?=
 =?utf-8?B?d2hzc1lZRWxpK1p1eTRaVGNRRW1yYzVsdmsyN3E3d1hFWUVhWWtBdGl1RVJz?=
 =?utf-8?B?YmlxSjRNejZJYmN0R0IyK2MyUzBUWG5zRXgzNVRhbVU5eUZWOFM0d05PTDgy?=
 =?utf-8?B?ZDkrSDVkMEs5TFNmRWwrR0d2dlpjR3ZjTnczWlpXVExHbWRGUFlKdVR3cElt?=
 =?utf-8?B?bjVVTlpjMGtYdVVOS0FVbXp2b2xHUUpBWWhjSW9wQmZ3a25lNGg5eHpqMld2?=
 =?utf-8?B?Tng3K3FzNzQ5YlJaMWlBSzMyakcyZDA2L0Q3TEhvUEYxaC9XajFma1BobTB2?=
 =?utf-8?B?bVRnYTZiWGh5Y1AvR3JKTDV1eUFiZFpseUpucjJTazduQWxMSUZjZVg4L0U5?=
 =?utf-8?B?dEpWVUFKVkJZUzU4YTZXY3hRcmgwcTNpbENwcjd4UkhweWRjUFpmS2hQWlV5?=
 =?utf-8?B?dHV4WW5zZzVSL3IwR3d4a09pTmh0VGVXM2tqR3dDSktmVGFaQnJ0TkVkL3hY?=
 =?utf-8?B?UndVbEhza2srQmhaZUNSUG1FQXBsMnNQTWpuVU8wQlBHbjIxYzdrQTdKcndW?=
 =?utf-8?B?Qzc4TmVWa3hoTytmWUhreTdUUk1kU1cwSENWaDQvY0ZTVHo0bUNXZFZIQjhw?=
 =?utf-8?B?bmovalFYL0VXSzRlN1RBQkUwdWl1REdPRlVvOGh0djVrNFRURk8yZFNvV0xF?=
 =?utf-8?B?UDEzbVhrU082QjQyUEVMYUxmVDBXbEpwY1dIWTRKNzh5RXk3T0hDY1hkL2Vv?=
 =?utf-8?B?V0poWlZ4RThMT1dUUERaRmdJNnhXSlFic0JnMGlxS3Vrc2w0RjlNclRVb2Uy?=
 =?utf-8?B?SG4zQnQ1SDNyYWwyT21vdk5RQkpnczFhZnlQa0hzQ0ZIVWsyL2ZGbmlCM0NR?=
 =?utf-8?B?NndKVStGWHkwaEpUaytuN2xDS0NuNzF6eW5jZldhOWZ5UHJQTG5SMmZVVHZw?=
 =?utf-8?B?andSSlYyZWJrRjdVT1VwclFaNzBiNWthRlpxOTEzUTBOVlo5WER6OUk5V3Zk?=
 =?utf-8?B?ZmlaSnU5MHptb29TbjlLdUFQTE5Bb0psQU5MTHJvZmhTMkVCUUZiSW5ZdzNp?=
 =?utf-8?B?ZTdJRWFiN3ZwTWVzWXBGWFlLWlkwWGlSMWNHWEJodTdPdWRyOHVJV1BNaWx3?=
 =?utf-8?B?dmJpZXU2VjE5eVFwdVRFKzZTdTJiUC8xcHpDSkljT1VGVXREc1VRaGNNMUpU?=
 =?utf-8?B?RW9TZ0JkYlZEYnBVRlNaMHZuK1pDVTd4aUo1cmc5a0xLeWE2Sk84Q1puZ2xs?=
 =?utf-8?B?RmJIQUJidnVYQ2FoNVdPdytMWWtMK1h4VjBodnBvc0pvUEVKQUkxd0QwWFA1?=
 =?utf-8?B?ZnRQQTZYYnJaZmRScUFNZS9mUnF4bGxEa0M1RW9HVXRDOTBwRmQyRXM5VkRV?=
 =?utf-8?B?ZzAwUTMrNWt2YXBIT2xidkF2UG5SVkRCY2lTQmVOK0htcm14T0VDbjBCYnRs?=
 =?utf-8?B?MjlJcDFsNm1zZmJhbkkvOHV4VzV4MVBUWmVWOW54ei9wdW5EWVZSSFQrank4?=
 =?utf-8?B?K1ZjRkh5Qk9HbDIrbXFzUDhSS3dZWEdEQUxRakVkMWVxUy9rN3hQSHVhQmlL?=
 =?utf-8?B?bHlYVWZ3UkMrNG10T0l2NmJhNUpQdk9LMExpY2t2VE9uU0hFMUs2bVpLUXNP?=
 =?utf-8?B?K2l0eFBRTnJUdkV6M2tIVmZCcjIybmFhbUtnQlNwa2pZcjI1TGs0b0c1TFBm?=
 =?utf-8?Q?HEL80TmeBxI12TSxXBmYpDw=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abb1fd67-501c-4ae5-a89c-08d9c09c6d1f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 14:00:32.9817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L6s5PC//6ZDjGoPKcsDWHCH+O+BROspjlXJ9Z119qOnl7h8ecIA4qGW7iIyOFcGrp1Gn/vKe/ENDV6yosMpGnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848

On 16.12.2021 10:20, Andrew Cooper wrote:
> There are two problems, both in the all_sources definition.
> 
> First, everything in arch/*/include gets double hits with cscope queries,
> because they end up getting listed twice in cscope.files.
> 
> Drop the first `find` rune of the three, because it's redundant with the third
> rune following c/s 725381a5eab3 ("xen: move include/asm-* to
> arch/*/include/asm").

I'm certainly fine with this part.

> Second, and this way for a long time:
> 
>   $ make cscope
>   ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
>   find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
>   cscope.files
>   cscope -k -b -q
>   cscope: cannot find file arch/x86/efi/efi.h
>   cscope: cannot find file arch/x86/efi/ebmalloc.c
>   cscope: cannot find file arch/x86/efi/compat.c
>   cscope: cannot find file arch/x86/efi/pe.c
>   cscope: cannot find file arch/x86/efi/boot.c
>   cscope: cannot find file arch/x86/efi/runtime.c
> 
> This is caused by these being symlinks to common/efi.  Restrict all find runes
> to `-type f` to skip symlinks, because common/efi/*.c are already listed.

I have reservations here, albeit of theoretical nature as long as only
the csope target is affected (simply because I don't use it): Make
rules should really be independent of a dir entry being a real file or
a symlink. I did run into problems with that already years ago when
the shim was introduced. My arrangements heavily use symlinking, and
any assumption on files being "real" ones will break this. At the very
least symlink checks should be restricted to cover only relative ones;
ideally one would distinguish ones staying within the tree vs ones
reaching to the "outside".

> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -468,9 +468,8 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
>  
>  SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
>  define all_sources
> -    ( find arch/$(TARGET_ARCH)/include -name '*.h' -print; \
> -      find include -name '*.h' -print; \
> -      find $(SUBDIRS) -name '*.[chS]' -print )
> +    ( find include -type f -name '*.h' -print; \
> +      find $(SUBDIRS) -type f -name '*.[chS]' -print )
>  endef

I further wonder how use of $(TARGET_ARCH) can be correct here. Why
would the enumeration of items here be limited to a particular arch?
When you edit files in the source tree, everything should be covered.
Restriction to a particular arch only makes sense in a build tree.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:00:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:00:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247977.427672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrJI-0000lr-HT; Thu, 16 Dec 2021 14:00:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247977.427672; Thu, 16 Dec 2021 14:00:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrJI-0000lk-E4; Thu, 16 Dec 2021 14:00:40 +0000
Received: by outflank-mailman (input) for mailman id 247977;
 Thu, 16 Dec 2021 14:00:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2y9W=RB=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxrJG-0000Vi-Dm
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:00:38 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 89cb69ac-5e78-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 15:00:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89cb69ac-5e78-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639663236;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=onc6RKMX6b6QatWjD4qy9333pi45dXCJHzlBh+xanWY=;
  b=VYMROdsXmpefuPPaDWKYRGdqChL/L5EGU1ktoTg2GgUzanZ5izh9aOWH
   fyicxGsucdQRsjBhqnHUxgHSQWL09TIqOz18cV7K3HoTmz800VN9X13Vd
   fxH7cim1bhjtDUSVlEssht7yIPYMH7j50sGm7P2vQczpG6wSYv2dJNhMy
   c=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: W9RAFJwuYRCP6sqYIfE0ttagshVE81tbyoXy/U6J2cm4eBQo2ytEYckeZmHZzftU1hpeMaMD6u
 Ts+AWwLMJYW1ou7gxYGD/wlEWqM3q5m0ovTBaFgw5wTKb5MduIB7v/iUfLch06E6JZTYgpMlDk
 pPHwOHKG6xPLvl9RkbNOV3QjQVa7xTosgVq1lI4trAXul5ul9jC1KAFeqlYcpoNuCBJOczNidq
 yKPVRUo5LDCNO8+R+NNa3jZHictgFIapaT9aRaSzS2rIWJYnAOPURPnp1HTtzXESZvp278IeWX
 jM+wYtC95Wb4PGwW0CfPmu1K
X-SBRS: 5.1
X-MesageID: 60124941
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:xSQSc6gk+KYVCdPA29zvO3SgX161vRcKZh0ujC45NGQN5FlHY01je
 htvCGDVOfaJamT1Lo1/b46/oxkFuJLRzoQwS1Blqy9gRH4b9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qx34Dja++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /1qrpvraBkYBJTSp7UsVhdFSR1VIpxZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHiOp8fvXdxiynUF/88TbjIQrnQ5M8e1zA17ixLNaiGP
 pBFOGY2BPjGSz5CIxRUV58Yp9mPlmHgXzFZl3CHoLVitgA/yyQuieOwYbI5YOeiVchT20qVu
 G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoNEJWo+/gsh0ecrkQaDRZHC3Ogu/K3zEizR7p3K
 UYZ5y4vpqga71GwQ5/2WBjQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZhlab4cHqv4MfCIVh
 26Mkc6zORdwgaLAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfnW0jsv7cZo09SfDo17UZDRm1m
 mnX93Zm293/mOZSj/3jlW0rlQ5AsXQgouQdwgzMFlyo4QpiDGJOT9z5sAOLhRqswWvwc7Vgg
 JTms5TOhAztJcvU/MBofAnrNOvzjxpiGGeD6WOD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e
 kLVsg45zMYNZyr3PPQoM9/rU59CIU3c+TLNDKq8gj1mOMcZSeN61Hs2OR74M57FziDAbp3Ty
 b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r
 ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/KrTef1E4QT55UJc8A9oJIuRYokicrc+Ql
 lnVZ6OS4AeXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U
 /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp
 +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1
 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a
 OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532
 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
IronPort-HdrOrdr: A9a23:bYeECaqcitZTO5/PHbuLuekaV5oveYIsimQD101hICG9Ffbo8P
 xG/c5rsSMc7Qx7ZJhOo7y90cW7Lk80lqQU3WByB9mftWDd0QPDQb2KhrGC/xTQXwH46+5Bxe
 NBXsFFebjN5IFB/KXHCd+DYrQd/OU=
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60124941"
Date: Thu, 16 Dec 2021 14:00:25 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, Jan Beulich
	<jbeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>
Subject: Re: [PATCH] revert "hvmloader: PA range 0xfc000000-0xffffffff should
 be UC"
Message-ID: <YbtGeXpAMNSDJ3gi@perard>
References: <036c6899-dbfe-eca8-7974-5a13d20455a7@suse.com>
 <YbsMwIYFULP5sXQP@Air-de-Roger>
 <cb9bea36-9feb-dbc7-ce36-38fd42792f11@srcf.net>
 <YbseXUE0byGJCzsy@Air-de-Roger>
 <e4c8e8e7-b326-c201-24bc-44c25c0aafe0@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e4c8e8e7-b326-c201-24bc-44c25c0aafe0@srcf.net>

On Thu, Dec 16, 2021 at 11:17:12AM +0000, Andrew Cooper wrote:
> What should happen is the domain builder place OVMF there directly.�
> OVMF is linked to run there, and there ought to be no hvmloader involved
> for UEFI guests, and there shouldn't be any copying into place
> required.� That was a very short sited move on behalf of the OVMF
> support logic, and I guarantee you that it creates more problems than it
> allegedly solves.

FYI, OVMF been copied there is due to how KVM/QEMU make use of OVMF, so
it was probably the easiest thing to do at the time.

Now, we have OvmfXen with support for PVH (still a few thing to fix),
which doesn't need to be loaded from hvmloader, and doesn't need to run
from that address (~4GB). Most of OVMF is linked to run at 8MB anyway (I
think, if I remember the address).

We aren't far from been able to run UEFI HVM guests without hvmloader,
we need to fix the logic in OVMF to take care of the PCI bars, and maybe
one or two other things, then load OVMF as a PVH kernel and hopefully no
more hvmloader on HVM guests.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:02:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:02:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247988.427684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrL8-0001kk-St; Thu, 16 Dec 2021 14:02:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247988.427684; Thu, 16 Dec 2021 14:02:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrL8-0001kd-Pn; Thu, 16 Dec 2021 14:02:34 +0000
Received: by outflank-mailman (input) for mailman id 247988;
 Thu, 16 Dec 2021 14:02:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxrL7-0001kP-TN; Thu, 16 Dec 2021 14:02:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxrL7-0000Bz-I6; Thu, 16 Dec 2021 14:02:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxrL7-0004co-9N; Thu, 16 Dec 2021 14:02:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxrL7-0003F4-8t; Thu, 16 Dec 2021 14:02:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=RT4AKL0nn69YnqkJ/JWeA37eoUB95xWHBVt2uutkFAI=; b=wixP2uEDBDIMfuCnDZaxskR2RO
	RJEH1SFayPoDMRQsZybq6d4h9pn3fUPhJRkWFyG56rR98z5Rqz2pST06cN0U123lLTDyhMOXENvbv
	kwtmYorpnGooQafkcHbI7KWJsQf+6QLL575eDElRCCg0q/MzjYg2AktvnC+4Xy7g89H4=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167445-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167445: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e6ea1464a846b3f012a9ca07d92924c2e1b88334
X-Osstest-Versions-That:
    ovmf=f14fff513540757bef62923ee4aeca4bf3ea8081
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 14:02:33 +0000

flight 167445 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167445/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e6ea1464a846b3f012a9ca07d92924c2e1b88334
baseline version:
 ovmf                 f14fff513540757bef62923ee4aeca4bf3ea8081

Last test of basis   167436  2021-12-15 15:38:44 Z    0 days
Testing same since   167445  2021-12-16 04:45:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Gerd Hoffmann <kraxel@redhat.com>
  Stefan Berger <stefanb@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   f14fff5135..e6ea1464a8  e6ea1464a846b3f012a9ca07d92924c2e1b88334 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:09:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:09:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247994.427698 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrRf-0002dg-JW; Thu, 16 Dec 2021 14:09:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247994.427698; Thu, 16 Dec 2021 14:09:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrRf-0002dQ-Gf; Thu, 16 Dec 2021 14:09:19 +0000
Received: by outflank-mailman (input) for mailman id 247994;
 Thu, 16 Dec 2021 14:09:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxrRf-0002dD-1a
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:09:19 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c0dae5a6-5e79-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 15:09:17 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47054)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxrRT-000vL1-oN (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 14:09:07 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2F2CE1FA9B;
 Thu, 16 Dec 2021 14:09:07 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0dae5a6-5e79-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <272e223d-e2b0-5bf9-9f7f-f0b8d772eeec@srcf.net>
Date: Thu, 16 Dec 2021 14:09:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 16/57] tools/ocaml: Remove generation of _paths.h
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 Christian Lindig <christian.lindig@citrix.com>, David Scott <dave@recoil.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-17-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-17-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:01, Anthony PERARD wrote:
> _paths.h isn't useful anymore in systemd_stubs.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I poked Christian, who's looked at this and given it an ack.  For some
reason, he doesn't appear to have this email in his inbox.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:26:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:26:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.247999.427709 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxriB-00055b-1Q; Thu, 16 Dec 2021 14:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 247999.427709; Thu, 16 Dec 2021 14:26:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxriA-00055U-Uh; Thu, 16 Dec 2021 14:26:22 +0000
Received: by outflank-mailman (input) for mailman id 247999;
 Thu, 16 Dec 2021 14:26:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=c0wh=RB=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1mxriA-00055O-28
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:26:22 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 22507b04-5e7c-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 15:26:19 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 318FE1435;
 Thu, 16 Dec 2021 06:26:18 -0800 (PST)
Received: from [10.57.5.90] (unknown [10.57.5.90])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E988D3F73B;
 Thu, 16 Dec 2021 06:26:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 22507b04-5e7c-11ec-9e60-abaf8a552007
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
 <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
Date: Thu, 16 Dec 2021 15:26:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit



On 16.12.2021 14:50, Jan Beulich wrote:
> On 16.12.2021 10:21, Michal Orzel wrote:
>> to hypervisor when switching from AArch32 state.
>>
>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>> "If the general-purpose register was accessible from AArch32 state the
>> upper 32 bits either become zero, or hold the value that the same
>> architectural register held before any AArch32 execution.
>> The choice between these two options is IMPLEMENTATION DEFINED"
>>
>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>> needs to be fixed. The reason why is that there are places in Xen
>> where we assume that top 32bits are zero for AArch32 guests.
>> If they are not, this can lead to misinterpretation of Xen regarding
>> what the guest requested. For example hypercalls returning an error
>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>> would return -ENOSYS if the command passed as the first argument was
>> clobbered.
>>
>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>> Add a compile time check to ensure that save_x0_x1 == 1 if
>> compat == 1.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>>  xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>
>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>> index fc3811ad0a..01f32324d0 100644
>> --- a/xen/arch/arm/arm64/entry.S
>> +++ b/xen/arch/arm/arm64/entry.S
>> @@ -102,6 +102,30 @@
>>          .endif
>>  
>>          .endm
>> +
>> +/*
>> + * Clobber top 32 bits of gp registers when switching from AArch32
>> + */
>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>> +
>> +        .if \compat == 1      /* AArch32 mode */
>> +
>> +        /*
>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>> +         * Add a compile time check to avoid violating this rule.
>> +         */
>> +        .if \save_x0_x1 == 0
>> +        .error "save_x0_x1 is 0 but compat is 1"
>> +        .endif
>> +
>> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>> +        mov w\n, w\n
>> +        .endr
> 
> What about x30 (aka lr)?
> 
Well the docs says about gp registers as a whole so including lr.
However I do not see how clobbering lr would impact Xen.
lr is not used to pass any data.

> For values read from elr_el2, spsr_el2, and esr_el2 I guess the
> hardware takes care of the high halves getting zeroed?
> 
>From the docs:
"On exception entry to an Exception level using AArch64 state from an Exception level using AArch32 state,
the AArch64 Stack Pointers and Exception Link Registers associated with an Exception level that are not
accessible during execution in AArch32 state at that Exception level, retain the state that they had before
the execution in AArch32 state."

So basically they retain the state. It is a different model than the gp registers model.
> Jan
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:35:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:35:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248004.427719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrr6-0006iH-RL; Thu, 16 Dec 2021 14:35:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248004.427719; Thu, 16 Dec 2021 14:35:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrr6-0006iA-OE; Thu, 16 Dec 2021 14:35:36 +0000
Received: by outflank-mailman (input) for mailman id 248004;
 Thu, 16 Dec 2021 14:35:35 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxrr5-0006i4-PS
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:35:35 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6d9ed4a3-5e7d-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 15:35:34 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-4-zi31XWl5Mz6nQ4UrXqL6Yw-1; Thu, 16 Dec 2021 15:35:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4847.eurprd04.prod.outlook.com (2603:10a6:803:54::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 14:35:30 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 14:35:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d9ed4a3-5e7d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639665334;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qR/ojdJ7y1LyZctuqeg8xMofnWyJGnwbjLdx2T9ZW4w=;
	b=nSjFrSHsI1g6zOLnaYYLFDBqwrg1PJU9kt5g6Ie//imWGVmXvu7DvWmpFBvQ6QeDU9g/N+
	f4UwLVj7d5LsdqBazzQzeI0gUblC3pyma1sPp9Z4/fI042AbY0sUSCa1+Ott1svPAMMABA
	hwaDHOJ6EdG4WOk52fPk+ymLqLImwwo=
X-MC-Unique: zi31XWl5Mz6nQ4UrXqL6Yw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aabHoy7AGekg3hXo9n6dFFHWsAqcf9XF4QqzZetRn6RCLxGOLT/wV8Tp/Tfa8rIVoUtcLeu2+JtfJCCOAP6NDpkNmJ8IOEONzCsEPdmG0ybYwA6EIKugCa/Pxj81vFW+9XeiTMqDBbLi8tZpHk0DrWx7KmKa+OZXoVxSL0VfpPdjvFLLZHEvXcrYAqzF4MAPewsMrdpFAmuPt0hjEUssBGi810IOlDrfDm85Z+Rhoj6cUmXqKpM5f+JrkeyH3kERNhQwiPLwOpB80vZMOnnNSIH5O5FXJkvYsl9VP/hNDWoi9IIuGEveuMOPVpAiMI4VZas4fnonOZvqZM4JZS0T2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qR/ojdJ7y1LyZctuqeg8xMofnWyJGnwbjLdx2T9ZW4w=;
 b=GTSamvqIr9CpE3hg8Ymiwo4YBJGclXLK80ntPZ60NX12emCoca6ZOvDgwdsyZxKli4oeD446DK5fiYhXy8c99rVupybgaakaM85u8BuNUph1CsXMGhnDj3L4Box21Fh+cYEprJt+onQfDemavefPFah09bYem8MGZ9P/hl0WgB3WaviikE6ESwONoqkucCfIVhMpRVR4McckwlI+NmXWrXb3FBkaogAiPykksATGGdTIBlfaAC2RerJp8IX9vctFtr7Rxv1hCsD1DuDqdACXKvvlhiGGmZ2an+IgFSf/ODMgli2McfqkHxpZvUBZiDQFAcY88g7KQ0uDg83rnWKuhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1367a957-79f9-fc37-9f70-0523084258d3@suse.com>
Date: Thu, 16 Dec 2021 15:35:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall
 <julien@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
 <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
 <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0075.eurprd06.prod.outlook.com
 (2603:10a6:20b:464::23) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f3c62bbc-f045-4dcf-e2a2-08d9c0a14f55
X-MS-TrafficTypeDiagnostic: VI1PR04MB4847:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4847466F4787999C711F97A1B3779@VI1PR04MB4847.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	vF4A/iZSJVUu3OaTktbfR/MOlenqyxl/lGiXUgzfYMWQhbcX7BCPejT/O2yC/AA04MaGa6MG4kh6qOVe/ENxJg5ks6+CrrfVwxOC0b+Or1KRMmI4xbKXyFEgbcMvOZ0zpp1jtz89Z9HBBeHj31PiPeWexLCmEn41b6DQ41xLx0A7iq6kxvUtx5RqbxA2DG8M535Yetnz+YItcUv8U1XaglA5PyHDuKGK4DAZIRN2gG1ickV7N2w9HvTzhwt/RomH3cDGg3hSTtqLCbjfJblvL+Vhhor7BGPk3jycIS2VLE+tVt3Jq1ii1CIi2aHlNraB/GnAsDa2CZlPjakCxOy7jCDLy58E7Py6WRKwzmXMWwdl2lF2g3i2lnluxGU6b5IYmGHHlbC9PFM2sFB2DhhMw3wkyCg7uhG7osJ2NJA7lJvdoPqZ4vOPHn79u5Xva+JNLSr51FSji+7jFUn6B0GEzEmE1PMCjMS7EB7yvZqLXnovPnBWOWkoWB8iwLVpRnDdg1JFII/LrBppk7jioltYLEya+5tXX8R7Waf3tS1JEEXkMOsfysORCNheja5nAmnwb6AEYEuWicGE8+IbN7O/+8v2unECiTz+hL8Af1JKmz2hbCQnKFsGwblGW444Evqb6b9/Ymqe//Tkmj/lbZCH9t2CPwwP+FnG859JuVYTVSiTJlRYeDrklt1bQ2MaZIlsMmnVEEBCIf8vrJQIVXq6Mn3nu0vorNnGhKcak+YTOLM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(6666004)(4326008)(5660300002)(38100700002)(36756003)(2906002)(31686004)(66476007)(6916009)(31696002)(6506007)(2616005)(54906003)(86362001)(66556008)(26005)(316002)(8936002)(66946007)(186003)(508600001)(6486002)(83380400001)(8676002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZzFnejdHMG5ObkpoeXZFdnoyVjJwM05DSGlaUUVFdEQ2UUNmRWFVVzNMSTFZ?=
 =?utf-8?B?dUJ4VGFGZlZrRHl5bnR6bVBoN2NzOXYyb2diZVJDY243TFZKckprUlRTdkRq?=
 =?utf-8?B?dzVVQm9JdEtqQUxVR2lLcGphbmVNNTlZelI3cGVLb2F2blRWZlhSai9TQmdT?=
 =?utf-8?B?REZlK1FsUWptNE5rM05iWmNNRVVGWHNjM1gxOHNLOW9lelJhVUVvUDlkSS9W?=
 =?utf-8?B?OU91OU5rakc4UXI5Nmt6V3JqQytmMlpGZmgydnhFTUpYOW9yYW0rV28yK1Vk?=
 =?utf-8?B?eUJNWUNXbUZkaXhBZUpIS0pDTlVob2FCTzB5MnVwYk9tRi8zcHBRZnI5VHFk?=
 =?utf-8?B?eW1zc1AyZ1FmNThMZnJaOFpNQzFqekZXVi8vY3FxWFQ1UXAxWHB3eGJYYU9X?=
 =?utf-8?B?TEI4ZHY1dldWNW5MTnZFWHMweVNxc0IvMXY5cjNXem9KV3RkdnZoaDE3dTlq?=
 =?utf-8?B?MW9MN3NYRUk1d2JEUFpLell2ZnFFOFBMd1NXOXFnb1pMYWZtVngxZGpSMFpz?=
 =?utf-8?B?ZFU5b2ZkNlJaQjJDQXdwV2J1ZmRKbUhuN3p3T3FGOHFldWJuUGZoVHkzZE8w?=
 =?utf-8?B?QWRaT0I5MTBUZW41VFJnSEY1dnRienAvZ082OWhMZWwzRDIxbkJsaVduRFZj?=
 =?utf-8?B?Z3ZmSGJjdk5jdDhBelJ1bWFwazNxZzFKeFJaMW15b0Zyai9XRS9QOHJyNkdB?=
 =?utf-8?B?QUp2dnBDb3FWaXpOY1l3bkRQWEdTQkthcnRCWFRCaS9HTXFFT0dOUzlUYUhD?=
 =?utf-8?B?a2VWSXFneXI5UW9KUko5bitNVlg1Z3JsSHhkbjdubUd1cTA3cEhkWlNkT2Ro?=
 =?utf-8?B?Wm1veVhDcFRna2V2OXB4aUNQN0d6eE53SVBITVk0bVdsQUZQMUtHTTU1OTU1?=
 =?utf-8?B?dnoxREc5eEtqZTFNczJpK2c4RCtwaG9qVlZJZjIxT3VhUlRVKzNrT0lnSG9x?=
 =?utf-8?B?dEU3a2U0QlZ2UGEvT1Rpemtzb2MwTVlFaVg4a1BaVmtib0JiUnYvc2Q1R0xw?=
 =?utf-8?B?UzNFOUNIUTBiMTM2T1VuNldKdmhsekZPZ0xYcWpTam9JWmdhQlFsM3FjTm9E?=
 =?utf-8?B?cmVjeWx3ZC9oNnBUOUl5OEJxRXp3a1RWZ3ZxMVFaZGgvdENRdXA3OERsQlVo?=
 =?utf-8?B?dk42UzdZZC9KNjhoOE5EMmprckcvRk4yS1Y0VitXekliUVRBZEQ1OHhVWjNW?=
 =?utf-8?B?SGdJNVB6KzJqYUdDL2t3dXZWZHFzRWxudzZvMUpiV3hiVlIyS04zeUV0Z3dY?=
 =?utf-8?B?bzBHekZhMDJwckJQdW54c3UxU0xodzltR2dIaHlIUVJWNVRXUUlmVmVjV2Jr?=
 =?utf-8?B?LythdE5lN05yaWNoNnhWZ3Z2a2xHamY3MDdXdVFuR3l3eVBwZ0dBeTV4T3hX?=
 =?utf-8?B?ditYQnpxelExOEI0ZTMxZDdFSU1ubEZHRXd6SUdKeXBCU3ZyRUd6UE5tRHVD?=
 =?utf-8?B?Y01uSHUxbWt3eFozVTB3U3VhRHk0WmYwWmpLTlJobnhBTityZHpLRXU1dE9m?=
 =?utf-8?B?WDNJclNENmU5bFEzVHdacnByN0NiTWFtcFc0b3FYbGZPeWNUaXQxOEpxVjVB?=
 =?utf-8?B?OEgxdksxSjhadG84VHFESlhDSVQ5dnJQaFVPbnhqczRhZENka1JtelRnaE9x?=
 =?utf-8?B?dUVJZ1ZwZEZORVFaaTgzd3hFL2plQ2FwM2NWZTJuajdOZ1B6QXpIc2tsT09a?=
 =?utf-8?B?OVF5V3lBdE93anFsb09NcHg1Y2VueTdkeG9WaFMyN0FWUWVoMldLVFlLdUhr?=
 =?utf-8?B?YlRyTkhlL0s4a2JjbnE0OVdXdjFxbWYxNHFQZDFDamJNZ0hVUVh1UGovNHpk?=
 =?utf-8?B?TmVDaWRkUDJqZ3I5UUJPejNVdXViME1qL3lxNi9sc084MjUwTFowRDdrcEFV?=
 =?utf-8?B?L0FvVVpORWNmQ1pWbDNndjA2eG1nWTYyb2pOdlR2TEN5SlF2KytXUi9HTTM3?=
 =?utf-8?B?V1BoTXBwSko3MnFLQVI2VkxGaWZMaDJtOXN3ZmxLYlhnS3FERFdhbEQ5NGxw?=
 =?utf-8?B?Qnp1bVAzZmNtd3FiZzB2ZG1iSjk5eDRqWUFudG1ERHZnbUtlNVVINzVYUHM3?=
 =?utf-8?B?QVN4ZVpHTERPYUIwb0dENklvWTR1NHJJNjJDcWZuc0hiQVF0U0hJdXVIRlMy?=
 =?utf-8?B?VmRhUjBSdHJZcTNMYW00UVlENERGMlpJekZCait5TU1aMlZpMWRMSGdsVzlG?=
 =?utf-8?Q?UfanDU3rZ5WBtqCsW1+Z8wI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3c62bbc-f045-4dcf-e2a2-08d9c0a14f55
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 14:35:30.4331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: exG5f7TdiyAiJDYo/MHWdmfeiuoiiZAASjLhjDTycFSRoyZuEtbNkQwuYtV6K4WTgz8yUUPsU+XB6mjiytS4Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4847

On 16.12.2021 15:26, Michal Orzel wrote:
> 
> 
> On 16.12.2021 14:50, Jan Beulich wrote:
>> On 16.12.2021 10:21, Michal Orzel wrote:
>>> to hypervisor when switching from AArch32 state.
>>>
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATION DEFINED"
>>>
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed. The reason why is that there are places in Xen
>>> where we assume that top 32bits are zero for AArch32 guests.
>>> If they are not, this can lead to misinterpretation of Xen regarding
>>> what the guest requested. For example hypercalls returning an error
>>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>>> would return -ENOSYS if the command passed as the first argument was
>>> clobbered.
>>>
>>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>>> Add a compile time check to ensure that save_x0_x1 == 1 if
>>> compat == 1.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> ---
>>>  xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>>  1 file changed, 29 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>> index fc3811ad0a..01f32324d0 100644
>>> --- a/xen/arch/arm/arm64/entry.S
>>> +++ b/xen/arch/arm/arm64/entry.S
>>> @@ -102,6 +102,30 @@
>>>          .endif
>>>  
>>>          .endm
>>> +
>>> +/*
>>> + * Clobber top 32 bits of gp registers when switching from AArch32
>>> + */
>>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>>> +
>>> +        .if \compat == 1      /* AArch32 mode */
>>> +
>>> +        /*
>>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>>> +         * Add a compile time check to avoid violating this rule.
>>> +         */
>>> +        .if \save_x0_x1 == 0
>>> +        .error "save_x0_x1 is 0 but compat is 1"
>>> +        .endif
>>> +
>>> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>> +        mov w\n, w\n
>>> +        .endr
>>
>> What about x30 (aka lr)?
>>
> Well the docs says about gp registers as a whole so including lr.
> However I do not see how clobbering lr would impact Xen.
> lr is not used to pass any data.

And all of x0...x29 are used (somewhere) to pass data?

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:41:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:41:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248011.427731 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrwg-0008Ls-Ky; Thu, 16 Dec 2021 14:41:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248011.427731; Thu, 16 Dec 2021 14:41:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxrwg-0008Ll-Hd; Thu, 16 Dec 2021 14:41:22 +0000
Received: by outflank-mailman (input) for mailman id 248011;
 Thu, 16 Dec 2021 14:41:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2y9W=RB=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mxrwe-0008Lf-IS
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:41:20 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 38d45292-5e7e-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 15:41:17 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 38d45292-5e7e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639665677;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=0JiiNvjhTe5vdgk3BPz4HCdNzr/rQSjc6pWc7sHjoOI=;
  b=XqSRdS1n6equFSuOAUcG2Qj6XioWLrdijZ2cqVJMFVJqBhSV9Jf3eQKh
   qcqguGPBjidbKFfcMiPhBmQdq2Q1+Imfz0NpUB+C/a+jFooLyQw0Gl4VY
   wi1ug3onIYH7O6XW+yfmTIjq4MolKX1hIeuoPJB4M8+Ac7YJ/qsPm8ElY
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: g2rJlTRZQtGInIc4zQlKQxyOZ0N/EyjD7aX6YFB2W1+k6/GTUDP+nvw+MgVvAnBkXrS7MZ0t2K
 qd3AoxMTeKkhUAGoXtvcwlOxs4VYH2XnbaVhx/Kp1t+UvZCK4K7XxEMAYKr6R+ENH1mknTe6X/
 AhB+/ITQGeSx7lpNh2d6TgBY38MJo3O2fK/6WM36wquiAPTHYV+xS22WJZUU1K6eYZ86DtoLyE
 8liZDh6NVnixLMzY6D0mb7Mbb5u4BkIq+2ZbwaaiTX/aSgeAH6Sv344MGRP/0NaoYhgS5Xr9xo
 jnN4s+Qyb5S3/xKHlCwOIhTm
X-SBRS: 5.1
X-MesageID: 60196343
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:zQInk6oUv9hbMGa5TIdlDBpHTY5eBmK7YhIvgKrLsJaIsI4StFCzt
 garIBmDPq2Kamfxf4p+Odu1oB8AvZTXm95nSwo/+C5kRCxHopuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24HnW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnbm2dVgNAfPqofUyCRVTQzp7HvFJpaCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ZJAOGQ0ME+ojxtnNUg8CJ4kv/qTunj5LRZzlVSTiIYP2j2GpOB2+Oe0a4eEEjCQfu1Xg0KZq
 2Tu72n/RBYAO7S39z2B9X69g/7VqgnyUokSCb6Q++ZjhRuYwWl7IBcbT0ehqP+1zEu3QctCK
 lc88zAr66M18SSDVcLhVhe1pHqFuB80WNdKFeA+rgaXxcL88wufQ2QJUDNFQNgnr9MtAywn0
 EeTmNHkDiApt6eaIVq/3LqJqTK5OQAOMHQPIyQDSGMt/N3LsIw1yBXVQb5e/LWd14OvX2uqm
 nbT8XZ41+57YdM3O7uT2Fb73BaT+L7wXyFv6g6HRWeGsgwke9vwD2C30mTz4fFFJYefa1COu
 nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yf7Jdg43d1oGKt+3i/okxfNa
 VSbhw5e7YQ70JCCPf4uONLZ5yjHIMHd+TXZuhL8MoomjntZLlbvEMRSiai4hTqFfK8Ey/5XB
 HtjWZzwZUv28Iw+pNZMe88T0KUw2gc1zn7JSJbwwnyPiOTFNSPEEuhVbQHWNYjVCZ9oRi2Pq
 b6z0OPQlH1ivBDWOHGLoeb/03hURZTEOXwGg5MOLbPSSuaXMGogF+XQ0dscl39NxMxoehPz1
 ijlACdwkQOn7VWecFniQi0zOdvHAMckxVpmbHNEALpd8yV6CWpZxPxELMVfkHhO3LEL8MOYu
 NFZIZjdWaoWFWyck9nfBLGkxLFfmN2QrVrmF0KYjPIXI/aMniTFpY3peBXB7i4LAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIU6eTbsivIXIt0XLUmRzDWty
 AvLUwwTovPAotFp/YCR17yEtYqgD8B3AlFeQzvA9b+zOCSDpjijzIZMXfymZzfYUG+oqqyua
 f8Ml6P3MeEdnUYMuI15Su45waU77trphrlb0gU7QymbMwX1UutteyDU09NOu6tBwq5ilTG3A
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY4on
 bUhtcoR51DtgxYmKI/b3CVd9mDKJX0cSaQ38JodBdaz2AYsz1hDZ73aCzP3v87TO4kdbBFyL
 2/GnrfGipRd2lHGIig6GnX61OZAgYgD5UJRx1gYKlXVwtfIi5fbBvGKHejbmuiN8ih67g==
IronPort-HdrOrdr: A9a23:ACV2P62RzX690pdSEQQGNQqjBLAkLtp133Aq2lEZdPRUGvb4qy
 mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5
 uIG5IOceEYZmIbsS+V2meFL+o=
X-IronPort-AV: E=Sophos;i="5.88,211,1635220800"; 
   d="scan'208";a="60196343"
Date: Thu, 16 Dec 2021 14:41:05 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich
	<JBeulich@suse.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
Message-ID: <YbtQARdhTgju72lF@perard>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211216092014.707-1-andrew.cooper3@citrix.com>

On Thu, Dec 16, 2021 at 09:20:14AM +0000, Andrew Cooper wrote:
> There are two problems, both in the all_sources definition.
> 
> First, everything in arch/*/include gets double hits with cscope queries,
> because they end up getting listed twice in cscope.files.
> 
> Drop the first `find` rune of the three, because it's redundant with the third
> rune following c/s 725381a5eab3 ("xen: move include/asm-* to
> arch/*/include/asm").
> 
> Second, and this way for a long time:
> 
>   $ make cscope
>   ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
>   find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
>   cscope.files
>   cscope -k -b -q
>   cscope: cannot find file arch/x86/efi/efi.h
>   cscope: cannot find file arch/x86/efi/ebmalloc.c
>   cscope: cannot find file arch/x86/efi/compat.c
>   cscope: cannot find file arch/x86/efi/pe.c
>   cscope: cannot find file arch/x86/efi/boot.c
>   cscope: cannot find file arch/x86/efi/runtime.c

It's kind of weird that cscope can't read symlinks, but I guess that the
way it is.

> This is caused by these being symlinks to common/efi.  Restrict all find runes
> to `-type f` to skip symlinks, because common/efi/*.c are already listed.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

> Anthony: I looked through the remainder of your build series and I cant spot
> any edits to all_sources.  Apologies if I missed it.

I don't think I've made further edit of this.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:56:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:56:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248016.427742 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsAq-0001bj-Qw; Thu, 16 Dec 2021 14:56:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248016.427742; Thu, 16 Dec 2021 14:56:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsAq-0001bc-NH; Thu, 16 Dec 2021 14:56:00 +0000
Received: by outflank-mailman (input) for mailman id 248016;
 Thu, 16 Dec 2021 14:55:58 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxsAo-0001bW-P9
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:55:58 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxsAl-00019k-L4; Thu, 16 Dec 2021 14:55:55 +0000
Received: from [54.239.6.186] (helo=[192.168.25.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxsAl-0001Hi-F0; Thu, 16 Dec 2021 14:55:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=3+PmK0RJKYZ+RBqp0LyHRZGqE6OzPUZ4vn2aGNwpMzM=; b=cR1NmF3YDMS+Ciiioj7wtcPYPe
	3hVeEI7lfwYSl7maWqbgzuIsKCdSDh26ZOZdfwXv6HZ5FT0LRrkrZ7NMiikyxTk7uxa7SKZVCPJ07
	Wr0fvmSFFTFfuVlbkj5h9QgHNt6qIJn8tgD1cFBrBEfMGldxZ1ACeHTwOozWZA+5jnYY=;
Message-ID: <0ddf5147-1f72-37e2-ca56-72307800463b@xen.org>
Date: Thu, 16 Dec 2021 14:55:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
 <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
 <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 16/12/2021 14:26, Michal Orzel wrote:
> On 16.12.2021 14:50, Jan Beulich wrote:
>> On 16.12.2021 10:21, Michal Orzel wrote:
>>> to hypervisor when switching from AArch32 state.
>>>
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATION DEFINED"
>>>
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed. The reason why is that there are places in Xen
>>> where we assume that top 32bits are zero for AArch32 guests.
>>> If they are not, this can lead to misinterpretation of Xen regarding
>>> what the guest requested. For example hypercalls returning an error
>>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>>> would return -ENOSYS if the command passed as the first argument was
>>> clobbered.
>>>
>>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>>> Add a compile time check to ensure that save_x0_x1 == 1 if
>>> compat == 1.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> ---
>>>   xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>>   1 file changed, 29 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>> index fc3811ad0a..01f32324d0 100644
>>> --- a/xen/arch/arm/arm64/entry.S
>>> +++ b/xen/arch/arm/arm64/entry.S
>>> @@ -102,6 +102,30 @@
>>>           .endif
>>>   
>>>           .endm
>>> +
>>> +/*
>>> + * Clobber top 32 bits of gp registers when switching from AArch32
>>> + */
>>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>>> +
>>> +        .if \compat == 1      /* AArch32 mode */
>>> +
>>> +        /*
>>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>>> +         * Add a compile time check to avoid violating this rule.
>>> +         */
>>> +        .if \save_x0_x1 == 0
>>> +        .error "save_x0_x1 is 0 but compat is 1"
>>> +        .endif
>>> +
>>> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>> +        mov w\n, w\n
>>> +        .endr
>>
>> What about x30 (aka lr)?
>>
> Well the docs says about gp registers as a whole so including lr.
> However I do not see how clobbering lr would impact Xen.

Xen may not be directly impacted. However this may be used by some 
userspace application (such as for VM introspection) and could be dumped 
on the console.

So I would cover all the GPR to give a consistent view to everyone.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 14:58:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 14:58:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248021.427753 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsD5-0002Dw-89; Thu, 16 Dec 2021 14:58:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248021.427753; Thu, 16 Dec 2021 14:58:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsD5-0002Dp-3g; Thu, 16 Dec 2021 14:58:19 +0000
Received: by outflank-mailman (input) for mailman id 248021;
 Thu, 16 Dec 2021 14:58:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxsD4-0002Di-Mm
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 14:58:18 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 996a2762-5e80-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 15:58:17 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43374)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxsCs-000OpR-8v (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 14:58:06 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 7446F1FAC8;
 Thu, 16 Dec 2021 14:58:06 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 996a2762-5e80-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d8b5d939-0682-f8e1-9392-2ea9748282cf@srcf.net>
Date: Thu, 16 Dec 2021 14:58:06 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
 <a6dab969-ce3e-a328-03bc-c27abbba0448@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
In-Reply-To: <a6dab969-ce3e-a328-03bc-c27abbba0448@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 14:00, Jan Beulich wrote:
> On 16.12.2021 10:20, Andrew Cooper wrote:
>> Second, and this way for a long time:
>>
>>   $ make cscope
>>   ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
>>   find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
>>   cscope.files
>>   cscope -k -b -q
>>   cscope: cannot find file arch/x86/efi/efi.h
>>   cscope: cannot find file arch/x86/efi/ebmalloc.c
>>   cscope: cannot find file arch/x86/efi/compat.c
>>   cscope: cannot find file arch/x86/efi/pe.c
>>   cscope: cannot find file arch/x86/efi/boot.c
>>   cscope: cannot find file arch/x86/efi/runtime.c
>>
>> This is caused by these being symlinks to common/efi.  Restrict all find runes
>> to `-type f` to skip symlinks, because common/efi/*.c are already listed.
> I have reservations here, albeit of theoretical nature as long as only
> the csope target is affected (simply because I don't use it): Make
> rules should really be independent of a dir entry being a real file or
> a symlink. I did run into problems with that already years ago when
> the shim was introduced. My arrangements heavily use symlinking, and
> any assumption on files being "real" ones will break this. At the very
> least symlink checks should be restricted to cover only relative ones;
> ideally one would distinguish ones staying within the tree vs ones
> reaching to the "outside".

all_sources is used exclusively for "tags" purposes; the
TAGS/tags/gtags/cscope targets.

Personally, I'd prefer there to not be symlinks in the first place.  The
EFI logic is unnecessarily complicated to navigate.

But the reality is that inter-xen/ symlinks for source files are also a
duplication as far as these `find` runes are concerned.

Apparently tags et al will follow symlinks, while there's no obviously
help online about cscope, other than "resolve your symlinks first".

In either case, you don't want to end up with both the regular path, and
the symlink, ending up in the file list.


I don't anticipate the usecase for all_source changing, nor the way we
symlink things, so I think sticking with `-type f` is the appropriate
action.

Furthermore, you really don't want a directory (e.g. include/foo.d )
getting into the file list either.

>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -468,9 +468,8 @@ arch/$(TARGET_ARCH)/include/asm/asm-offsets.h: asm-offsets.s
>>  
>>  SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
>>  define all_sources
>> -    ( find arch/$(TARGET_ARCH)/include -name '*.h' -print; \
>> -      find include -name '*.h' -print; \
>> -      find $(SUBDIRS) -name '*.[chS]' -print )
>> +    ( find include -type f -name '*.h' -print; \
>> +      find $(SUBDIRS) -type f -name '*.[chS]' -print )
>>  endef
> I further wonder how use of $(TARGET_ARCH) can be correct here. Why
> would the enumeration of items here be limited to a particular arch?
> When you edit files in the source tree, everything should be covered.
> Restriction to a particular arch only makes sense in a build tree.

I'd say that's a matter of opinion.  There are times when I'd quite like
it to be all arch's, and there are other times when I'm very glad it's not.

Either way, I don't intend to address that rats nest in this patch.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:15:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:15:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248026.427764 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsTe-0004sl-NS; Thu, 16 Dec 2021 15:15:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248026.427764; Thu, 16 Dec 2021 15:15:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsTe-0004se-JY; Thu, 16 Dec 2021 15:15:26 +0000
Received: by outflank-mailman (input) for mailman id 248026;
 Thu, 16 Dec 2021 15:15:25 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxsTd-0004sY-Cf
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:15:25 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fdd2100b-5e82-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 16:15:24 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-QgA81-P3PXyrc7JjKpX70w-1; Thu, 16 Dec 2021 16:15:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 16 Dec
 2021 15:15:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 15:15:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fdd2100b-5e82-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639667723;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=WBuna3sUWfypxfKGttV//Yn0A8Mar2E8GUFCkwofBqc=;
	b=BtyA3Vb/cyRJ257PwXQ6/wqWaepi8kUf7mDjXCq1UiGDu8+nmv/kfbWjlhLPmKje5ouu8W
	CZY0nmi7Ca69XzViZt5ecA39pkb7pBzNY/mXuyrQbjNd/XPWaWkOtA2ttMA2GKI8MiHPc4
	mk0RVEi00+0l8KgT/cHkIwYk6uj5i8k=
X-MC-Unique: QgA81-P3PXyrc7JjKpX70w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J4AJq1AYTfxuwKXC3AEB2RAkgrDVytfVqM9aZl3oiGnGyQE6qNmJis1eoDTk3lqZIkmvCyRPCCIV55xdSh39P7wdN39ty0ipBV+yO5HO654XSSa6hnKE/Qprr94cKEyBnAsaXj9gM25dAqk3ictOfVn1iRsvcqxe0NVb/nHn/9X3jyNQcJP1UCo+2aKKCDy7sHJolMKcjBJ7MlzOvQAVgpo62nhG02Ejn7E1wDcOsit9CxD4RL1HxCvDqm16nfff7b+Kx+Y+H0kRk4+OXqmX82OdkAgSE4DwcOQZFLyLl47SUfZIJOAIlgBHyY5njlUprVGlNofxQapFVPonD5IAMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bubbYSp+rLrksIJwv3J3gi332AdAKd0RX6X9fxKhp/g=;
 b=A2En2iVklL8kj6jVG13NEaK+lOUqYPpu/nNOXnjNlhH5k9VBHSoaXO85A65/IbY0bqwg/hdvon5oR6iqTfmMKsU1YTUrrcn5OawLfY+RXELhKLedU63/Yvuj/BF60BnbWv7Vgwv6vR/c+75azlitMJFch8KHdNCDzuXRxZhXmGkZ6Mx17eUr85qM/QEF9CBNj4iWK/Dm68tBzun5v+gGcUL6dbrFzgC+3qf3k4OYmlmfXBKu8QIx/cznRMe0jAN/kNG34wruUGl4fMuaWFqJrCbL9uSfkMIxGkjpyQCizvHZz0f58IUdIthP6ccg22dnz1wWW8qH1fSGJ27so6eP9A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a8993520-ab01-f462-9b95-318171cf411a@suse.com>
Date: Thu, 16 Dec 2021 16:15:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: Anthony PERARD <anthony.perard@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
 <a6dab969-ce3e-a328-03bc-c27abbba0448@suse.com>
 <d8b5d939-0682-f8e1-9392-2ea9748282cf@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <d8b5d939-0682-f8e1-9392-2ea9748282cf@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0030.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::35) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 302ddd94-b125-4be7-d863-08d9c0a6e06f
X-MS-TrafficTypeDiagnostic: VI1PR04MB5744:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB57447EDDC6C82BA6758BE184B3779@VI1PR04MB5744.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Ho1FhTMw647bCRzTDk+//L90nQ+P9t9bBctrD0ikIlfVerLh4JfwAP+pEY/a6cN9IBhc2JPvFVrZz/gbJwXJsJJim/DH0d4sm6hfvCSDFVok9okzqqtbzh3nMVxvqaE2KASXc8p3ILFFSsvpjFPbmZcdmz30hlluZF1jWwEaEapcLtR3IaTU3bjLcw5sCP5QoiS1NJFk6i37CGyaHoULcrs/zUUsFPtkh7O5hSFCPTLQR6htVyyT/paXNxeMzS/9sQvOnD7Mva4Qclk+iHqi60sBLamQckP+sdyzWckZUY4BVOjqHRMEpUsVXsefieJOEUuokKPehAnPMIndKEQu6VatdklG98EPckw4BoPj/2G+y2YcJo3EjtS3gajhOk2WsddIcxI6Z5Z6kV5+m1eg6Z6ezih87hwlgoL6FJJsiUgkmXzLD9Cs4UsXWjZGeOPX5rgetLcFsz3c8/cBovgC6T6wXmFG2m0gQmUbPcdCeNmyY0xpP1Tr0JxRoT1fXlcPfaLYXsk6pkaUazSV0Z48A4EeVIZQjJ3szR/vdQpT/Y63EVaGpxwp1CEyHA5WMjSOiksfzMWrugerTZdY3IgqHGrhkxJWM55OWKQG1cYjb0J/v6Zv6XyFRX3P/Z8t3I8qDP51q2mCA9tY6bt5PauQKEDpovoH2LON1MHaFyOSFG3TxGyvGLk+SYwwNPie0m8fGdQ4g/+N4oB/sI2G1Yee5oNhttkmkwrKXb/GTPchv38QZifc4c4Z2bTdwyuVvxUfAKQYM/JUrbp8XC4jmEiyHg==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(31696002)(66556008)(6512007)(86362001)(2616005)(186003)(83380400001)(508600001)(66946007)(110136005)(8936002)(66476007)(316002)(26005)(5660300002)(31686004)(7416002)(6666004)(4326008)(6486002)(38100700002)(36756003)(2906002)(53546011)(8676002)(6506007)(81973001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?bPicpdd9oMWBfqqAghFatkSr3D2jXtFKwmqy+NDBvyTmW1ld9Kwjnt4u+7xB?=
 =?us-ascii?Q?3mkDJPZN47pZDAIBEoUSfwcje3RQ89A5cEKTiE1yMzot3QOoOqnIppmTZwUp?=
 =?us-ascii?Q?FKPMCMGnB2S80snGMmliTxLqsohpKozI53xCKxl3Q7muLRfsTwzgVS17uWjp?=
 =?us-ascii?Q?Y/aHqHlNzAvhus/RZyuwZcARaL0hmN1VUQ4vG1UrJPYzvjnhHr+MSIOmc3aH?=
 =?us-ascii?Q?BNXeOECi3UCMOTOtz88jQz91zKExFTL6ErOdGhLYBV4UNpgZKqJ5xSLUMIVJ?=
 =?us-ascii?Q?XrAYn1d4UUFXCX91pGAyIGPkyY9qRw7VK/j20t7SIDKwuqSAhoX/IuuJqji6?=
 =?us-ascii?Q?vwtL660+N+toAuNbAT9B/yeLVoCOoNtgLiqMn2AWiOmCBeBySEte+/3i2idY?=
 =?us-ascii?Q?W0UtoZvPTFEvaNGw7Ow8a0Z8jQwH3Zaqu7uU5fom9ArbiqkJSS2jxfPgN6Zu?=
 =?us-ascii?Q?+okLyCgnpgi/TsFH0pVcKhD/wVhsTihtZtvGYX8oOCEYLGQ+vSKe+I8+k9HP?=
 =?us-ascii?Q?Rsgifs+Gw2Ve/4ZOLvQwnqdwIjj178RpCMXO1dRaDZW1xss4K5EyMSaG75Tk?=
 =?us-ascii?Q?1tfTfZt+4OPDvKY6atM8U8k3Y/ovbPDrXg3ZEmSBZPBdZ2rI6Ch5iXI8v/QC?=
 =?us-ascii?Q?zv2gLBB76jqOdESX54XQMjNnQ3qZRuxVLvhV5wpphy+iNMCngjGYBXbuCjOY?=
 =?us-ascii?Q?8OAmzR77VPTmSyfo38O6KOWLQ6dHreJykmVoBZLeYlSDswJ6YOQIrLw+rTDX?=
 =?us-ascii?Q?B8FGpQam0JLkxl4ua/7i+6n3EmUlke0cJAmhuomaBFutV0UKP0Ujp04alq0o?=
 =?us-ascii?Q?ngJvbSdsHw+5gQyPBGYNw8MISzwQynP9DhGxBHfiRhCxlRu/5+W/CO6xAkEl?=
 =?us-ascii?Q?suuFyhbo8XL86TiB2LAOmUc9ExQuzDJOAluwwFu6ciYxKcr+GHaWw4Y/pwQH?=
 =?us-ascii?Q?QwvFJkGQr5LfHT/pr6PmZiT0fhLMAbTTnK64Qcaxc1jZUMnbZbl0AWrjNfrw?=
 =?us-ascii?Q?BpwVoLFvR8A10XSfl4tnUJ82dlVCatZz9uowztfyqA5B+VY0w2gXrYIZ2WC5?=
 =?us-ascii?Q?T/pFwphVQBl3L2Otq6QO3Sqxw0b+95sZeAsz0awEX1mtmHGumb2JmdgxTWNE?=
 =?us-ascii?Q?k/hMlaL3gSHjDzHltUf+AgQUZ5uoGl97zpBYST6mTGp0iX8RtcZlKz/j0dci?=
 =?us-ascii?Q?c5kmuxZQmG3QkPZlHCeu9I8N1tduSVL9wLYcUD3D1QpaT5KexIRO2WjpnMqB?=
 =?us-ascii?Q?ZG1ddFdSJoarj/sL+C1weTeQR8urTvJilqeZufA0DtS4ycuuCo0bLfJjWTc8?=
 =?us-ascii?Q?rQOzsXxO2KmUEs60G+Zko9XcRXmr3LxMRD25ajFAu9tasQvnF1TLIWXXdfcm?=
 =?us-ascii?Q?r5w8neiR6SQPonrm/dLIj1NwGQ0TjjKmgJNyiOjKB1dIW4DOsk4RxU3pmp/l?=
 =?us-ascii?Q?0TnFrK7L/frNyXdrELOM/hf4n2zceg+/kpDVswsD87WW5N7udhkZ0zydMrKG?=
 =?us-ascii?Q?ynfA7u9yTZBy5aIhkMKQ4jaSnzpWqKTXqrEr9HTImO8eh6iaJlM3IBB3i1Bs?=
 =?us-ascii?Q?xsfrcUJCeIyW984E/k98q3Wme7phwJljSl9r7KTa6ZMEMum4fS4TS1Ex76EU?=
 =?us-ascii?Q?K83gNyt8ZWf8GgASt3jZ45E=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 302ddd94-b125-4be7-d863-08d9c0a6e06f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 15:15:21.4065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iG4N2Uq1EEKUd91jtxYID3GZBhn14yiQm3Pz8ODLgkV57UaShgyLV2iDT01waZHEljBVnA+XFGvb8Ip7nHTQqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744

On 16.12.2021 15:58, Andrew Cooper wrote:
> On 16/12/2021 14:00, Jan Beulich wrote:
>> On 16.12.2021 10:20, Andrew Cooper wrote:
>>> Second, and this way for a long time:
>>>
>>>   $ make cscope
>>>   ( find arch/x86/include -name '*.h' -print; find include -name '*.h' =
-print;
>>>   find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
>>>   cscope.files
>>>   cscope -k -b -q
>>>   cscope: cannot find file arch/x86/efi/efi.h
>>>   cscope: cannot find file arch/x86/efi/ebmalloc.c
>>>   cscope: cannot find file arch/x86/efi/compat.c
>>>   cscope: cannot find file arch/x86/efi/pe.c
>>>   cscope: cannot find file arch/x86/efi/boot.c
>>>   cscope: cannot find file arch/x86/efi/runtime.c
>>>
>>> This is caused by these being symlinks to common/efi.  Restrict all fin=
d runes
>>> to `-type f` to skip symlinks, because common/efi/*.c are already liste=
d.
>> I have reservations here, albeit of theoretical nature as long as only
>> the csope target is affected (simply because I don't use it): Make
>> rules should really be independent of a dir entry being a real file or
>> a symlink. I did run into problems with that already years ago when
>> the shim was introduced. My arrangements heavily use symlinking, and
>> any assumption on files being "real" ones will break this. At the very
>> least symlink checks should be restricted to cover only relative ones;
>> ideally one would distinguish ones staying within the tree vs ones
>> reaching to the "outside".
>=20
> all_sources is used exclusively for "tags" purposes; the
> TAGS/tags/gtags/cscope targets.
>=20
> Personally, I'd prefer there to not be symlinks in the first place.=C2=A0=
 The
> EFI logic is unnecessarily complicated to navigate.
>=20
> But the reality is that inter-xen/ symlinks for source files are also a
> duplication as far as these `find` runes are concerned.

DYM intra-xen/ symlinks? Else I'm afraid I'm not following.

> Apparently tags et al will follow symlinks, while there's no obviously
> help online about cscope, other than "resolve your symlinks first".
>=20
> In either case, you don't want to end up with both the regular path, and
> the symlink, ending up in the file list.
>=20
>=20
> I don't anticipate the usecase for all_source changing, nor the way we
> symlink things, so I think sticking with `-type f` is the appropriate
> action.

Well, as said - I disagree, but as long as only targets I don't care
about are affected, I guess I'll let you do what you want done.

> Furthermore, you really don't want a directory (e.g. include/foo.d )
> getting into the file list either.

I certainly agree with you here.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:17:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:17:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248033.427775 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsW4-0005Z8-7k; Thu, 16 Dec 2021 15:17:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248033.427775; Thu, 16 Dec 2021 15:17:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsW4-0005Z1-3l; Thu, 16 Dec 2021 15:17:56 +0000
Received: by outflank-mailman (input) for mailman id 248033;
 Thu, 16 Dec 2021 15:17:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxsW3-0005Yt-2E
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:17:55 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 56b475e4-5e83-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 16:17:54 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-24-FdqhgrD1OVe8ueBNzLcn9g-1; Thu, 16 Dec 2021 16:17:52 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5597.eurprd04.prod.outlook.com (2603:10a6:803:dd::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 15:17:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 15:17:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 56b475e4-5e83-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639667872;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KNn1epMrWUAiW9CZeXc+YGt54V/Wkg59uwUIDGnVrD4=;
	b=Fu34LIqJBnIG79b10FtHcyrFwD9wDf2gU76ELMVj+w7CdNGXsxKSswAbygyZ4+LhEIWwrs
	Yf0D2ZkZLoIHyUBMVMgEHwY7zpYxodgYZktqP9C/qNUuPWXs/7yWvuhi34eMkpvbSI8dmI
	Wc5kvgNkQ+g3F5TX/xlzdhVGCjg+RD8=
X-MC-Unique: FdqhgrD1OVe8ueBNzLcn9g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=evP2OVBLEML+2Xfm0pW+RENoX0YrGZ66m8hsMRBZFXj9aTQwWEiCKd4sjfh09XMxzTv/ZP5/bSRpL4P2vVHDEPMu6EoEhdo4OtIWOUN25DU5cZW9WbVpCb0UaR+OZ3DlXwK+Rs3GS+OgwKuapi+7eRGDneq7RcPnXESn4PuRgjGgIOdAKhWyEGuQnCryC8TAKRZHIHzrwKWzLgVcgLZrG+l0kdkd82CGBJPsZqIDXggW2diPwk+TC3JMkt2xFDhEzFO7uoCiOqlYtLs1TVf9568fJYbYDVIFNKiNGVYC09kGRRmqAZHphPD5PCoiX+S2CF946/lNdlBv1DuH7XVZpg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KNn1epMrWUAiW9CZeXc+YGt54V/Wkg59uwUIDGnVrD4=;
 b=MEtFPH/3tkkUX01hq8hiDGU/klWX0gY0JbNVxQwNtdwYDx8PTBhXGyFiLyWZWhLuDOhzW0kqixtxa9mMObNzpJ5ASclW0eVBWiEw8sJcbFpcOS5ZVjpQIFmULufZy6fqMxrp1WCpjqKnQVshm6oXcLmchmwAuVPcPnvIeOQ+L7K/6DwsIfiOJiOAY8WGbRAP+UzT+ZQjDjtwZkF0L9u72njQQn51xq8gmj4Vpsj3N3rL1cX12n6XVT0OuCi82yuJ8je+z6BojXAphAZEy2GMWatv7TEUbFPjJV+hsSbZN2HwWlQxn1n4vqtCvjm0N64eRSWswxAJuJWr0MFqGh05Kw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cc3d5968-a9dd-dd52-fe5b-89c5fbff5a1b@suse.com>
Date: Thu, 16 Dec 2021 16:17:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
 <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
 <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
 <0ddf5147-1f72-37e2-ca56-72307800463b@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <0ddf5147-1f72-37e2-ca56-72307800463b@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0012.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::25) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 601df591-0671-4552-3939-08d9c0a738fd
X-MS-TrafficTypeDiagnostic: VI1PR04MB5597:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB559764AD6DC54ACEF99E3172B3779@VI1PR04MB5597.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YtSZaIFqZLJ5kliH15Uq2lG+sI7MlzOLdyfaukZdJduX/jrpRPuQZWlPSoIdAkDeVgbCkiK5NwuCN7XaFsm4q5rwZ2FtgNbyafczoODZEM5JFX/AfKa39ZpVrg5cofu1+JET5BuhWh2YJlLzsiKlehbJrDp+YM+z5bHkxf4lXMmJO9I414R9JRu/QtznuIAVy781hRgejrH8QlDq67eb782o5DiQQpgond2jjKJ+FuIxSEsfI+uauFsl36qyB89yaLJbiOX8RnxQlUvLZRal/zgABTU3ruFkR6g7BrSCNlEIeIEOOkClCrh8IRnQYy6wMYjyYQzPohz/V47xDQC6P2MN4koAlbDl7c2FeC20ZPcQ1OhfWIil8x1E4XZrH9SufLD4wF8zSijSX66sdq8VV49mZ7hr34jalTdoEg3ehEKnft8saWrOmwZaLkz5pl3QXcRxmVjHQj68CZCyHJuM/PHYBTeJfh76rNFOx0xpcfNrOiVc2/dF1jV1UnsdT6lEXOucyviYklR4mzjkKvlIAHaj467P+07Yra0CLSXxo9MdhH/KnWPNDBazuDz48FEw8VwP4hbO6yTQF7jUH6x+tzPjcs7b2yH08e68Xl9dAwTM/3H7gRwCqXTxEaKDnfhrE2oObRyVfL3/K8Mq4ciBurJsNhaObviIXOpLqcp07G7BCHso/m4HZvdejWlUStn/bmiUSD5Lr3PnuCclnYYfzd2MmLXjBkzJUDFuQlbEW8SbHjGGJanERMLJ1OHZjnzz
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(66476007)(53546011)(31686004)(54906003)(2906002)(2616005)(26005)(31696002)(316002)(6512007)(8936002)(110136005)(5660300002)(86362001)(186003)(8676002)(6506007)(36756003)(508600001)(4326008)(83380400001)(66946007)(6486002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHRHSDZPS0NUdlh3VWFXV1ljTzQ2c0krOXA2cmRjSytBd1A1WjJlNnRsL2lj?=
 =?utf-8?B?U3p0emJLdmE5UEcwaGpsWG1GK0tqbFdJUlMyaitmT2t5bUNYU09qTVdHRmFj?=
 =?utf-8?B?WG0zWHBDZlh6ZnJOVXhncjR4UWZaVHBMS3MzbDVVczkyczlYSlV6MGFvSEpI?=
 =?utf-8?B?N0JOSVBTQzZzbWlQN1JMVjVMaGFmRUMwdlA1UFYyb2UwNEViNkFLU0lTbTYv?=
 =?utf-8?B?ZVR0cHpxaU9WYnJPYzB1VTI3M21sZmF0MzZ6bmQ0cnBSamRuMFFVeDhFR08y?=
 =?utf-8?B?QUdyWW5WdCtWOFYwR09Ta2Vxb3AwSkM0RytHdmVGaFhkYWJkSFVmU1BhUWl3?=
 =?utf-8?B?OVhZdHNUR2pleXlPbHZib3pjYTNIQTNidFlHbkFnQUVzaHFZVFpMM0dGSE1Z?=
 =?utf-8?B?T1Q4WTFwZ2YwOEdFQlBhNGxSZjd4eWQ0V3F0K0g3MXQ5RXE0MVZ6ektCVFFm?=
 =?utf-8?B?N3dlQjk2NVFkbk1lVW9SbjcreDdWYWZCWW5QaXp5MHYzNVFWRHlHNmg1QnY1?=
 =?utf-8?B?cmV2UFAvaVFObTNWRTNSY2hKMDJxNHFDV3BnS1VWTjBOU3I5MWUxWE9GN1pa?=
 =?utf-8?B?aEJMTXExZTJhTUZ1QWZwa2Z3Q01JTUJqRXBkTVhBOTl0ZlRnTEc1MGhWUTRU?=
 =?utf-8?B?UTRnMEg1aGpkZE1jZ1IzMEl0aHZSUlVMQ1Q2aDFzMFhkSlYzMG1aUEs4WXNs?=
 =?utf-8?B?aTl1SmpqVGQ3dVpnc0R6YWtSTkdQR0F6cWpsRWsvaHNDdXhEL1lCQ29UVGVI?=
 =?utf-8?B?M1UvemQvMjZxN3Fub1lsMjBzNi9FWUQvR1pYcmtJbnRHYWZxT0pmUEtLQW55?=
 =?utf-8?B?MVVrbXpRaERjaGZibkdGdmRwNHpEQVFMTkx6cGpqckJhd0RseDlyNXdDTS9n?=
 =?utf-8?B?UUtxeHpnVlMzc3RmMUQzZTVYZjFEZldlTndreXdtWm5UQ3R2VUxmL2hqWjJJ?=
 =?utf-8?B?RUF4c1N5SnY3N1BJVnFuNU1kVE5rbkp4QU9kcFFsK3V4Q3dNc2d0d3hzTkdW?=
 =?utf-8?B?b1dEaE94a3JPa3dDYTA5SFM5dDRJakp4ZnRPbG9DN09rdVpjYTNYV3N1ajcy?=
 =?utf-8?B?U3p1ZmliQ21oOUMwS0dBa3cyWk04dXBKTkVtYUUxK21GMldtU1QzbnJjN2w5?=
 =?utf-8?B?eDY5eCs0YmR2VzFzWUwyRkltWXNHNVNGTHFScm41bjFmZk1vYTBXRUswdUNp?=
 =?utf-8?B?akdkV0NnTnVWZmE5Y2F4dVJCaEpxK0NvS1NCcW85V1lSRzMyT3FGK2d2N1pV?=
 =?utf-8?B?elhmc05XSklVLytZeWdDWGo5SFVxUUpXOTM5YldsVUdJMjhob0l6LzNJOXVk?=
 =?utf-8?B?c1pjeDBkb2xKaGt6NEQ3UDR6NVRhUUt6Wktma3NOSWJacEtnZjdmdE4vMnBO?=
 =?utf-8?B?d0pRT0MvWGkweEhRZnFPQzBjVFZESXBTYVVBSzFCb3BUckU2b2dsdTdSUTNB?=
 =?utf-8?B?bC9EazRaUUtCT0d1VDdPS2xrd3hrcHAyZEVFNzlsblkrNnpIZGdieDRTcUs1?=
 =?utf-8?B?RTZ5dFZ3ckUybXZaczlnMDh5dVBhQThQaFc0T3hwaGtkbnp2YWM4UjRNSm1O?=
 =?utf-8?B?ZjlQVUxyQ0I1TlB2MzNjcTZISlJka3R1SHNhLyt0dXE3dmo0eEN1eEV4S3hy?=
 =?utf-8?B?ODB2eW5qL3VtdUE2eVBpMGdtUHlKY1ZSQkZnaTJlWXFGODdtM2k0RmZwbS9H?=
 =?utf-8?B?S1dZUStaUUFTUlNMV1dPdG5DWkZtZGEzbmJ0NlJGZU15UUFTUHFpZGt6ODg0?=
 =?utf-8?B?VW1pVEJNWHVvZTYralhOOUYySjhLWWxMMjdmK1NVb0k2aXUyYW1PbERZQmVP?=
 =?utf-8?B?VDRzRXJPdU1tb0hGRnZNL3F0aXUvekpuZlJBMnpxOWVPMzlRN1laejl6d3hw?=
 =?utf-8?B?ZU1SQVcxeFA3alY4WHZpMC9oYW5FTDZUY0Fob3FZb09ZOVdlTGtET3ZwT3JZ?=
 =?utf-8?B?WEkrejhuM0tyRWM1WHJTZ3p0QUltdjBzT1lrUUE2V0ZHMXlWRDByRnpjN2hZ?=
 =?utf-8?B?YkdOdUtYR0RLOFQxQ0JFYUVYWW1nR1VqRlFLZGhQZkE0dklrRkhHbU5kSGFu?=
 =?utf-8?B?ZXFVSDBEQjZwNkcwQTI4OFlacmxrTjR5aXJvYlFOSTVCc3NoTWlnRy9OZlVK?=
 =?utf-8?B?QXBiU3VHdVdhMEtrTGpjVDVkcUZ4QkFnOUM1MU1nSXdBMVJPUVRZUnVzTGda?=
 =?utf-8?Q?FpleT7Co6IjkScHDjm654XU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 601df591-0671-4552-3939-08d9c0a738fd
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 15:17:49.9185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WUgdLs/81dopGS0JJ3Z7AP8tJW9U7uuOtxBZTQdfccGbnC16h7hhoddkZg9f99EpEqElf5bsU3or+oDbkP9low==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5597

On 16.12.2021 15:55, Julien Grall wrote:
> Hi,
> 
> On 16/12/2021 14:26, Michal Orzel wrote:
>> On 16.12.2021 14:50, Jan Beulich wrote:
>>> On 16.12.2021 10:21, Michal Orzel wrote:
>>>> to hypervisor when switching from AArch32 state.
>>>>
>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>> "If the general-purpose register was accessible from AArch32 state the
>>>> upper 32 bits either become zero, or hold the value that the same
>>>> architectural register held before any AArch32 execution.
>>>> The choice between these two options is IMPLEMENTATION DEFINED"
>>>>
>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>> needs to be fixed. The reason why is that there are places in Xen
>>>> where we assume that top 32bits are zero for AArch32 guests.
>>>> If they are not, this can lead to misinterpretation of Xen regarding
>>>> what the guest requested. For example hypercalls returning an error
>>>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>>>> would return -ENOSYS if the command passed as the first argument was
>>>> clobbered.
>>>>
>>>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>>>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>>>> Add a compile time check to ensure that save_x0_x1 == 1 if
>>>> compat == 1.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>>> ---
>>>>   xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>>>   1 file changed, 29 insertions(+)
>>>>
>>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>>> index fc3811ad0a..01f32324d0 100644
>>>> --- a/xen/arch/arm/arm64/entry.S
>>>> +++ b/xen/arch/arm/arm64/entry.S
>>>> @@ -102,6 +102,30 @@
>>>>           .endif
>>>>   
>>>>           .endm
>>>> +
>>>> +/*
>>>> + * Clobber top 32 bits of gp registers when switching from AArch32
>>>> + */
>>>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>>>> +
>>>> +        .if \compat == 1      /* AArch32 mode */
>>>> +
>>>> +        /*
>>>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>>>> +         * Add a compile time check to avoid violating this rule.
>>>> +         */
>>>> +        .if \save_x0_x1 == 0
>>>> +        .error "save_x0_x1 is 0 but compat is 1"
>>>> +        .endif
>>>> +
>>>> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>>> +        mov w\n, w\n
>>>> +        .endr
>>>
>>> What about x30 (aka lr)?
>>>
>> Well the docs says about gp registers as a whole so including lr.
>> However I do not see how clobbering lr would impact Xen.
> 
> Xen may not be directly impacted. However this may be used by some 
> userspace application (such as for VM introspection) and could be dumped 
> on the console.
> 
> So I would cover all the GPR to give a consistent view to everyone.

Consistency is how I came to think of x30.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:18:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:18:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248036.427785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsWc-000676-Ft; Thu, 16 Dec 2021 15:18:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248036.427785; Thu, 16 Dec 2021 15:18:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsWc-00066z-Ci; Thu, 16 Dec 2021 15:18:30 +0000
Received: by outflank-mailman (input) for mailman id 248036;
 Thu, 16 Dec 2021 15:18:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxsWb-00066p-30
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:18:29 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6a7bd50e-5e83-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 16:18:27 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44450)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxsWP-000neB-2Q (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 15:18:17 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 575261FAC8;
 Thu, 16 Dec 2021 15:18:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a7bd50e-5e83-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <80f43714-2fdd-b014-0b2d-dbd7a8e4785e@srcf.net>
Date: Thu, 16 Dec 2021 15:18:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Julien Grall <julien@xen.org>, Volodymyr Babchuk
 <Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
 <a6dab969-ce3e-a328-03bc-c27abbba0448@suse.com>
 <d8b5d939-0682-f8e1-9392-2ea9748282cf@srcf.net>
 <a8993520-ab01-f462-9b95-318171cf411a@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <a8993520-ab01-f462-9b95-318171cf411a@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 15:15, Jan Beulich wrote:
> On 16.12.2021 15:58, Andrew Cooper wrote:
>> On 16/12/2021 14:00, Jan Beulich wrote:
>>> On 16.12.2021 10:20, Andrew Cooper wrote:
>>>> Second, and this way for a long time:
>>>>
>>>>   $ make cscope
>>>>   ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
>>>>   find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
>>>>   cscope.files
>>>>   cscope -k -b -q
>>>>   cscope: cannot find file arch/x86/efi/efi.h
>>>>   cscope: cannot find file arch/x86/efi/ebmalloc.c
>>>>   cscope: cannot find file arch/x86/efi/compat.c
>>>>   cscope: cannot find file arch/x86/efi/pe.c
>>>>   cscope: cannot find file arch/x86/efi/boot.c
>>>>   cscope: cannot find file arch/x86/efi/runtime.c
>>>>
>>>> This is caused by these being symlinks to common/efi.  Restrict all find runes
>>>> to `-type f` to skip symlinks, because common/efi/*.c are already listed.
>>> I have reservations here, albeit of theoretical nature as long as only
>>> the csope target is affected (simply because I don't use it): Make
>>> rules should really be independent of a dir entry being a real file or
>>> a symlink. I did run into problems with that already years ago when
>>> the shim was introduced. My arrangements heavily use symlinking, and
>>> any assumption on files being "real" ones will break this. At the very
>>> least symlink checks should be restricted to cover only relative ones;
>>> ideally one would distinguish ones staying within the tree vs ones
>>> reaching to the "outside".
>> all_sources is used exclusively for "tags" purposes; the
>> TAGS/tags/gtags/cscope targets.
>>
>> Personally, I'd prefer there to not be symlinks in the first place.  The
>> EFI logic is unnecessarily complicated to navigate.
>>
>> But the reality is that inter-xen/ symlinks for source files are also a
>> duplication as far as these `find` runes are concerned.
> DYM intra-xen/ symlinks? Else I'm afraid I'm not following.

I do, yes.  I'll find some more coffee.

>
>> Apparently tags et al will follow symlinks, while there's no obviously
>> help online about cscope, other than "resolve your symlinks first".
>>
>> In either case, you don't want to end up with both the regular path, and
>> the symlink, ending up in the file list.
>>
>>
>> I don't anticipate the usecase for all_source changing, nor the way we
>> symlink things, so I think sticking with `-type f` is the appropriate
>> action.
> Well, as said - I disagree, but as long as only targets I don't care
> about are affected, I guess I'll let you do what you want done.

Thanks.

>
>> Furthermore, you really don't want a directory (e.g. include/foo.d )
>> getting into the file list either.
> I certainly agree with you here.

Reading back, I actually meant foo.h/ as a dir, but the intent wasn't lost.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:22:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:22:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248043.427797 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsaf-0007jL-0F; Thu, 16 Dec 2021 15:22:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248043.427797; Thu, 16 Dec 2021 15:22:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsae-0007jE-T3; Thu, 16 Dec 2021 15:22:40 +0000
Received: by outflank-mailman (input) for mailman id 248043;
 Thu, 16 Dec 2021 15:22:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxsad-0007j8-R6
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:22:39 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxsad-0001f3-MG; Thu, 16 Dec 2021 15:22:39 +0000
Received: from 54-240-197-224.amazon.com ([54.240.197.224]
 helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com)
 by xenbits.xenproject.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxsad-0002un-Dr; Thu, 16 Dec 2021 15:22:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:
	Subject:Cc:To:From; bh=JJmEh3TREYUIxqaWvyym6nwfJKMOMaOfV5meepyUfKU=; b=4GzHnI
	htSodtFul/w7NZFYQK4tSDWZzKn5wxiruV+gi1JMCf8baDB/Yo58a9H7c/CzeMTT9jLEvsSlyK7nR
	NtbZTfGaCBYo96FeezhAJR5p4yf0rrEF9jowrc5LUXCDBAM9NxsbN+j6OtGs2EQ5M0agKPPhDjsrK
	QSqSfcbJHx8=;
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org,
	Julien Grall <jgrall@amazon.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen: arch_mfn_in_directmap: Reconciliate the name and the implementation
Date: Thu, 16 Dec 2021 15:22:20 +0000
Message-Id: <20211216152220.3317-1-julien@xen.org>
X-Mailer: git-send-email 2.32.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

From: Julien Grall <jgrall@amazon.com>

The name of arch_mfn_in_directmap() suggests that it will check against
that the passed MFN should be in the directmap.

However, the current callers are passing the next MFN and the
implementation will return true for up to one MFN past the directmap.

It would be more meaningful to test the exact MFN rather than the
next one. So rework the implementation and the caller to match the
name.

Signed-off-by: Julien Grall <jgrall@amazon.com>

---

Looking at the history, it looks like the check in init_node_heap()
was <= and it was simply moved to a new helper without any adjustment
as part of c6fdc9696a "boot allocator: use arch helper for virt_to_mfn
on DIRECTMAP_VIRT region".
---
 xen/arch/x86/include/asm/mm.h | 2 +-
 xen/common/page_alloc.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h
index 5dbcee869624..a38e13e3c11e 100644
--- a/xen/arch/x86/include/asm/mm.h
+++ b/xen/arch/x86/include/asm/mm.h
@@ -641,7 +641,7 @@ static inline bool arch_mfn_in_directmap(unsigned long mfn)
 {
     unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);
 
-    return mfn <= (virt_to_mfn(eva - 1) + 1);
+    return mfn < (virt_to_mfn(eva - 1) + 1);
 }
 
 #endif /* __ASM_X86_MM_H__ */
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 38eea879c04a..d4789f81cd31 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -588,7 +588,7 @@ static unsigned long init_node_heap(int node, unsigned long mfn,
         needed = 0;
     }
     else if ( *use_tail && nr >= needed &&
-              arch_mfn_in_directmap(mfn + nr) &&
+              arch_mfn_in_directmap(mfn + nr - 1) &&
               (!xenheap_bits ||
                !((mfn + nr - 1) >> (xenheap_bits - PAGE_SHIFT))) )
     {
@@ -597,7 +597,7 @@ static unsigned long init_node_heap(int node, unsigned long mfn,
                       PAGE_SIZE - sizeof(**avail) * NR_ZONES;
     }
     else if ( nr >= needed &&
-              arch_mfn_in_directmap(mfn + needed) &&
+              arch_mfn_in_directmap(mfn + needed - 1) &&
               (!xenheap_bits ||
                !((mfn + needed - 1) >> (xenheap_bits - PAGE_SHIFT))) )
     {
-- 
2.32.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:48:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:48:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248048.427807 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsyo-00021s-Vk; Thu, 16 Dec 2021 15:47:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248048.427807; Thu, 16 Dec 2021 15:47:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxsyo-00021l-Su; Thu, 16 Dec 2021 15:47:38 +0000
Received: by outflank-mailman (input) for mailman id 248048;
 Thu, 16 Dec 2021 15:47:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxsyn-00021f-BY
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:47:37 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7cc955ba-5e87-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 16:47:35 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-41-9pX9A2f4NliRNsWn-MogDw-1; Thu, 16 Dec 2021 16:47:33 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 15:47:32 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 15:47:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7cc955ba-5e87-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639669654;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KQGer4lm9RghDJHbY3h8ab57Mz6LF3pXAal506c8Dl0=;
	b=VKIxeknp3rJcWJ3p4YVFgGgFh2zsKZHgk84nwByu7pJS0J0LOA6ECcvbYCoiVNP6eruIEU
	WUGdqyxiCPWYXYSFK8PSgoxdtaNweWdf/AuHEwhoiuBVG7sL4VRkfCOIQurtrRKSDa4GTU
	IEsB/XvStx28NSIx73LFviwcdse6yLA=
X-MC-Unique: 9pX9A2f4NliRNsWn-MogDw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S5IEuGs7OrC++DW6XJnglDrhRYqSXCm/a9ZyaI5UQEZY/7z7gBDRH1fQKvKNkt7Mj/FMKDHRaLFRSvhrvjgOUwI8L+kIIfGU/da+UDoQQFOccDD6vQKLJXXQ+vGJvclIm6yNFv/XYWE/0WxH4Gfd4mNPywI9+NDfCaDji4fqrUN9f9qtn6zIw8hjKw/B5BzkZ3O/Z1hyoVzED5PlCWFYLBdAfNVpp4vaKecylQFtfdTnQUbaMh0OHaVmZu+byE/QpPi25OhcS4c0WggztB1svYXX6BgwHUZYGPZl8ewBBz/569NBWa+jgIbmmJ4UO6ICTjwUj+VLnHVIoStlA0QdWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/rpWSAOGphzfiTMMNmh0k3Xs0pyubg3Wvw+kJiaHEOc=;
 b=Pg6IOrDIwmSdO1wYqX6Dl7LT31CNi524ia/FoUVzAzKLQf4jzlBtBLdNVtHbVV96C23Cx2cyfQPLEHEyC095Vh+C/NmqwYnhEagPkfKFvI5KzJKphQeeCLPEAdI0kVtCldE7PFq0LdCy1maBmBB2PyZbxiLUUyPZZhP7gNbKtup1YAqapicvoeNZf5oQb9ji7MhiuxEFEMHTff7PkCNWifkxq2TdL8nz5ENCPOKa5ZoTbjknFOKUS3cT7mAEg2TOOSatvAgZOeyZDgvmndb0UVCgHcIbI4rZzW74cV8Ae6srn1wpMpidIR9uo4+Z+mqkk5y4gtqQ+ryf91w3cixgeg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bbcbd938-170d-94dc-4fa3-49766fb2a9c3@suse.com>
Date: Thu, 16 Dec 2021 16:47:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 16/18] x86: introduce helper for recording degree of
 contiguity in page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <aab0b88b-7643-cc08-756b-0684f93be257@suse.com>
 <Ybn0LaRuFpUfcmoU@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <Ybn0LaRuFpUfcmoU@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM6PR02CA0008.eurprd02.prod.outlook.com
 (2603:10a6:20b:6e::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3b05bf2e-eee6-4b79-eb85-08d9c0ab5f1f
X-MS-TrafficTypeDiagnostic: VI1PR04MB4608:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4608550B7494F338F3102895B3779@VI1PR04MB4608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	R0UkUXl0M0pE09R+EjDhoHH+3xHmp4vyV5FB1fqTBJSJhspRBlvYqVxbb8+y6urtarbKUWRIFbVGdoXQzVHBJEkedRgXT6HTDbo1KZbGylRzX5GCCgXucZvP5FXrhW4NzK++gvue91nEuCvKlXlsqH7sHuARE9xi7TTLPUHFPk/lCnZPEZEHtxjQa7PMeOHIwIHrdnR5gWC1ApmJSKGLohkFoKdbNTq7OM4xEfach3C8KzWl06HOr4k89ASX0mFj//V4KntTBv0hSMvsNmwBP4Efu9aBJpnZDMRGT4FZItQhGmlLIaznUluTa7geuG6rO2LOXtRm3pWJjD2BepteSMiHn528NtWsUDTWNtGtHiAzt22ivLk6xG1ryX1gmWArefNIqjTx1fd1vGR1dFFKDCNoplAdoTf8uDetAWczgRcRvnWiQN58/g8W9YDP3D7S7+EgcaLP7A/biZmS8cu7r7mxf0FyTNJM25Ac3zEL4YpqRsbv6CXpQ++hGBXCCJgdmhMe73Wx7BA8mZL6EdzrxNcKdBsoXz59lmDQV+BuLs2SlTvPavfUuF8/3ailKGMjjYU5AsTP6txeLDddBqsGenCmLoKbB2eBDptIMqUI3sRW+zVtOCaspyJxZoGhtpi6m9Y/4JNoWMnyody+0VhV9cN+DBL8hCwTDD7w1z9w43QSsEfiCaTg8RuxQO4SNAnbOh7310XV6x0ZLs8XzJ73CDyPJZWevyrl+LDUzm1NxEg=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(31696002)(38100700002)(186003)(36756003)(6512007)(31686004)(6486002)(2616005)(53546011)(316002)(86362001)(26005)(83380400001)(6506007)(54906003)(8936002)(66946007)(8676002)(4326008)(5660300002)(2906002)(6916009)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jVVDhnUQXme3dyDGxspjBUkxkL/BVE6X+/g0PCR5AVS/MM5mZ1PhFxlgNZoD?=
 =?us-ascii?Q?zJAqIt9H5YWfi86GrCZdIg6Qaj3rtVyn5Hg75AqJpxsp5C8bhI3iINRbd2HT?=
 =?us-ascii?Q?Zok1nwXH9RUApwNycxJzoNvvoiVJuPw7rPQKIHh++cEHYr6vyYCtqmQGjPbn?=
 =?us-ascii?Q?QUrSRrgFoLLr1hGPXFuBYo2XUA/7GZaHgnxzZ7XcXN6Hqc3qncic+tmxzVtA?=
 =?us-ascii?Q?N10CIymsAJzUToTlZfV1AXfdRRvEVnlfxhU3e3t8cscgFfPtUWHeX8fulvuc?=
 =?us-ascii?Q?rOPUUV1W9wYR9dfoVyyJLBlKzkYPd0b04WaGiqA4aWisHHB91OS2w/jZ0dR0?=
 =?us-ascii?Q?nJac5NBvwkN55tvNHSz6WbzMg7avrGdMBRDySiDX3NNoDQXgaLHyIRiD5WJ0?=
 =?us-ascii?Q?XpnI0jUU+OC18s8/FssKDBKVmU7HadchMvUXgsBC/6kX3I+GK/8IUVPAZ2+2?=
 =?us-ascii?Q?YO6Yaxwi7iQlCJM8c9bQ4dwMHdJc7bvcwo1KE6C17u+RqdhACmzChlE53QpY?=
 =?us-ascii?Q?Cfo0xWaSk/B5nBXNUmRQ+MbMz08/3AszGlrDwdpEuzG4BRuneuDhXrb2OfhP?=
 =?us-ascii?Q?TJrFotPN61hSfEDP1UW4hN+6Xl+1jUDpKjn9PRwUVixIGo07Jqj3uXT+yMso?=
 =?us-ascii?Q?6PckHLnRfUfKRR5Iy2XvhTGa/8H0ZVrdD75C9LwTeZIHVKj+O+elOPG0H1rr?=
 =?us-ascii?Q?AsUgGA3Yngg+2GoYWZjEAnEYBlTXpCBQTjGofnBzncWBW7PWVeAVOOIzUcur?=
 =?us-ascii?Q?64ZpcEzY2QfMX/1L5J6xeuJo6tjkveY39K1DL8ftDjpA02gtrwNbCoeYqLs4?=
 =?us-ascii?Q?u4TSgJlClQNbMHr019xIMB6gX/sqYc7gVm0PxEHlwaRcnyEWBo9i4OCMv2Ct?=
 =?us-ascii?Q?5OuJRt20Y91BOue0hoignhjL99a4SRajJNU9ZMFjJRLZTPsAvaFyEC/+2pso?=
 =?us-ascii?Q?cQ40mrHKDSkhqST7gp3tXHwQGZdLCLaab9UQCpH6p4GB98ErSC9MWHtuII0f?=
 =?us-ascii?Q?rjXEYLEPgPtNfS+bFMquIPixWNys1Ca2uVecoUdvVs/NAf8CbBA1ng9B+jPh?=
 =?us-ascii?Q?ao3yPv3RE+0SIoCeTmhzBIzTiocnmiEmBzHQgJnLxwEs3PZ2disoZhSymB0e?=
 =?us-ascii?Q?DI5h2xARpg0VHoFRMkbS0YtkzlFPCW53wwZ88vw5zYLWMiKK4qeRZo//zgAb?=
 =?us-ascii?Q?jD4l1x8UD3/pzODvcCY/kfzHV/V0UmsykdVM/Uj8NhDeurAIXQ3idpBUAQdf?=
 =?us-ascii?Q?v0dHcnDB5aW845hQ7mMnpVURWI/hJbjuPRiT+zjGaNMa7nIcNSHOKbiQWWdU?=
 =?us-ascii?Q?sgG7egaosWlv9KBMpNbts2EuzYv3HmSqbQewxUN7kDIbWC0okS6aO2d8Z5YD?=
 =?us-ascii?Q?cB6KB8CNNzRgJHys1BHYJ8B8oAJp6FohhBsT5KdV4awNXlknRTGAUEBc5Xdz?=
 =?us-ascii?Q?KPKWd6MM7iXHjwtMjhdsolMtb/hfHaAGrAO0OP+0L/Y4mI83lU1wA7QqwjuX?=
 =?us-ascii?Q?oDtDXCJeik7VRlTBfm5xsSM17frv3T89qubfELptBH9xIO+Xx7tPWFWXMAyf?=
 =?us-ascii?Q?6NGkmmugqRXwVuwFzSXKIZYUcUrksv33Cx0EwsDSQ2dGZ4DbKEgQKl+2/lYd?=
 =?us-ascii?Q?vMFTxU4s0rPSjj0TyyK5x3k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b05bf2e-eee6-4b79-eb85-08d9c0ab5f1f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 15:47:31.8853
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wr635kHxZjVutMI978L1HrbFbdNU+4jNqqRbWQ9/jcb0j6xBVTW8hipmOMBmCn4/oNYEYlNI2BO05pqLEue6cg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608

On 15.12.2021 14:57, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:55:30AM +0200, Jan Beulich wrote:
>> --- /dev/null
>> +++ b/xen/include/asm-x86/contig-marker.h
>> @@ -0,0 +1,105 @@
>> +#ifndef __ASM_X86_CONTIG_MARKER_H
>> +#define __ASM_X86_CONTIG_MARKER_H
>> +
>> +/*
>> + * Short of having function templates in C, the function defined below =
is
>> + * intended to be used by multiple parties interested in recording the
>> + * degree of contiguity in mappings by a single page table.
>> + *
>> + * Scheme: Every entry records the order of contiguous successive entri=
es,
>> + * up to the maximum order covered by that entry (which is the number o=
f
>> + * clear low bits in its index, with entry 0 being the exception using
>> + * the base-2 logarithm of the number of entries in a single page table=
).
>> + * While a few entries need touching upon update, knowing whether the
>> + * table is fully contiguous (and can hence be replaced by a higher lev=
el
>> + * leaf entry) is then possible by simply looking at entry 0's marker.
>> + *
>> + * Prereqs:
>> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4
>> + *   contiguous bits (ignored by hardware), before including this file,
>> + * - page tables to be passed here need to be initialized with correct
>> + *   markers.
>=20
> Given this requirement I think it would make sense to place the page
> table marker initialization currently placed in iommu_alloc_pgtable as
> a helper here also?

I would be nice, yes, but it would also cause problems. I specifically do
not want to make the function here "inline". Hence a source file including
it would need to be given a way to suppress its visibility to the compiler.
Which would mean #ifdef-ary I'd prefer to avoid. Yet by saying "prefer" I
mean to leave open that I could be talked into doing what you suggest.

>> + */
>> +
>> +#include <xen/bitops.h>
>> +#include <xen/lib.h>
>> +#include <xen/page-size.h>
>> +
>> +/* This is the same for all anticipated users, so doesn't need passing =
in. */
>> +#define CONTIG_LEVEL_SHIFT 9
>> +#define CONTIG_NR          (1 << CONTIG_LEVEL_SHIFT)
>> +
>> +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK)
>> +#define SET_MARKER(e, m) \
>> +    ((void)(e =3D ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK)))
>> +
>> +enum PTE_kind {
>> +    PTE_kind_null,
>> +    PTE_kind_leaf,
>> +    PTE_kind_table,
>> +};
>> +
>> +static bool update_contig_markers(uint64_t *pt, unsigned int idx,
>=20
> Maybe pt_update_contig_markers, so it's not such a generic name.

I can do that. The header may then want to be named pt-contig-marker.h
or pt-contig-markers.h. Thoughts?

>> +                                  unsigned int level, enum PTE_kind kin=
d)
>> +{
>> +    unsigned int b, i =3D idx;
>> +    unsigned int shift =3D (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIF=
T;
>> +
>> +    ASSERT(idx < CONTIG_NR);
>> +    ASSERT(!(pt[idx] & CONTIG_MASK));
>> +
>> +    /* Step 1: Reduce markers in lower numbered entries. */
>> +    while ( i )
>> +    {
>> +        b =3D find_first_set_bit(i);
>> +        i &=3D ~(1U << b);
>> +        if ( GET_MARKER(pt[i]) > b )
>> +            SET_MARKER(pt[i], b);
>> +    }
>> +
>> +    /* An intermediate table is never contiguous with anything. */
>> +    if ( kind =3D=3D PTE_kind_table )
>> +        return false;
>> +
>> +    /*
>> +     * Present entries need in sync index and address to be a candidate
>> +     * for being contiguous: What we're after is whether ultimately the
>> +     * intermediate table can be replaced by a superpage.
>> +     */
>> +    if ( kind !=3D PTE_kind_null &&
>> +         idx !=3D ((pt[idx] >> shift) & (CONTIG_NR - 1)) )
>=20
> Don't you just need to check that the address is aligned to at least
> idx, not that it's exactly aligned?

No, that wouldn't be sufficient. We're not after a general "is
contiguous" here, but strictly after "is this slot meeting the
requirements for the whole table eventually getting replaced by a
superpage".

>> +        return false;
>> +
>> +    /* Step 2: Check higher numbered entries for contiguity. */
>> +    for ( b =3D 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b )
>> +    {
>> +        i =3D idx | (1U << b);
>> +        if ( (kind =3D=3D PTE_kind_leaf
>> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) !=3D (1ULL << (b + s=
hift))
>=20
> Maybe this could be a macro, CHECK_CONTIG or some such? It's also used
> below.

Hmm, yes, this might indeed help readability. There's going to be a
lot of parameters though; not sure whether omitting all(?) parameters
for such a locally used macro would be considered acceptable.

> I would also think this would be clearer as:
>=20
> (pt[idx] & ~CONTIG_MASK) + (1ULL << (shift + b)) =3D=3D (pt[i] & ~CONTIG_=
MASK)

By using + we'd consider entries contiguous which for our purposes
shouldn't be considered so. Yes, the earlier check should already
have caught that case, but I'd like the checks to be as tight as
possible.

>> +              : pt[i] & ~CONTIG_MASK) ||
>=20
> Isn't PTE_kind_null always supposed to be empty?

Yes (albeit this could be relaxed, but then the logic here would
need to know where the "present" bit(s) is/are).

> (ie: wouldn't this check always succeed?)

No - "kind" describes pt[idx], not pt[i].

>> +             GET_MARKER(pt[i]) !=3D b )
>> +            break;
>> +    }
>> +
>> +    /* Step 3: Update markers in this and lower numbered entries. */
>> +    for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b )
>> +    {
>> +        i =3D idx ^ (1U << b);
>> +        if ( (kind =3D=3D PTE_kind_leaf
>> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) !=3D (1ULL << (b + s=
hift))
>> +              : pt[i] & ~CONTIG_MASK) ||
>> +             GET_MARKER(pt[i]) !=3D b )
>> +            break;
>> +        idx &=3D ~(1U << b);
>=20
> There's an iteration where idx will be 0, and then there's no further
> point in doing the & anymore?

Yes, but doing the & anyway is cheaper than adding a conditional.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 15:54:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 15:54:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248055.427819 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxt5P-0003fn-T1; Thu, 16 Dec 2021 15:54:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248055.427819; Thu, 16 Dec 2021 15:54:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxt5P-0003fg-P7; Thu, 16 Dec 2021 15:54:27 +0000
Received: by outflank-mailman (input) for mailman id 248055;
 Thu, 16 Dec 2021 15:54:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxt5O-0003fX-3v
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 15:54:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 711da740-5e88-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 16:54:25 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-4wkPwgemNEKDhlmW7MGbFg-2; Thu, 16 Dec 2021 16:54:23 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5168.eurprd04.prod.outlook.com (2603:10a6:803:56::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.18; Thu, 16 Dec
 2021 15:54:21 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 15:54:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 711da740-5e88-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639670064;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=EAekPYbp9sH2QX5o7Ez5afHWt/ZrWPM/Zx0fWwm3C24=;
	b=XVlBmqfTsIJ7Nhztg2VVZ5VMsHU1Uk0eA6T0wd5/QhJKQtELZ6k3RPEGgwle5J1sOY5mND
	oIDLJUpMUbC5bzM4ufc1F1RJ3R7ssrZryPKvobscE5QsM+uQJkPacVNghL8uWZUEgog9Ng
	xoSH8oJvR7iUK5dQtLP2C17cXmmicwc=
X-MC-Unique: 4wkPwgemNEKDhlmW7MGbFg-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ByVTBbdTT04RIZkR7YsM4oSymkybQu6dgl8Byh9x7yOcXk/X0DdEJTqbcZvyhlKKhfzpUjiLL7IENvo4jXNn2mzvxNCH4OXoLv8levCdHFLNyg5TuPXjo8LaVg0sSyZHPNeR5w/nf5ae8in8PzRSZTO8d2PMOOHDj9hRhhj+tAihTukISq8a3RbRq1kjIqVVGL2GHoXK6bPPYQe1BfKUhsxrTUBYHjKMkCft+o2zmjdw7+qfsqwEA6wz4b2IyDKrVNJ3ggJI3c7YU+UWFLfIT4l0r5Pz/+fd0Qft/unqgJt/RjszX5RiQRFogJetSSYtac0GY09Ij4Ei7RjGy24R5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kolHVCKRISc55qMUa98tPsqjb33uk16OcDO37vM/GuY=;
 b=RiwoAiNy9orVKZzZycPsO8a4B9b4MbLnS9BO31JwRaKS+WDwIRhyOcO6w2X6K+IB5eRB8fa0kX0URhWXBfNDZ77eIlvblWcplmjIRnHg61Hudq2TSknirbeVZXAjPPDhdTlJcmiTDsOCsJOetPEQJsR6fU4BBZLRC8/by4JHXeEIUHS1WVeiAgrBhhQ0uBKMnvFLIApbLXOgKDXhfq2tICtpRGBME/t+LMGWAp1kYYr7SpMM/DdwyA5j5crpIpZdFa5tVdkl+P9Ueh7v9uw4q0NQ8HrsU6sSC6JpTcpnQWOxXGENwRBXiBdFAB8DUfTLTOS+kAely5PGD/HbspQQVw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <bdf38cfb-2de6-7443-33b4-11f0a135ad49@suse.com>
Date: Thu, 16 Dec 2021 16:54:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 17/18] AMD/IOMMU: free all-empty page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <ef31b6f4-09f5-cded-a235-5dce3c5399ce@suse.com>
 <YboGXiHaAO1cuUnd@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YboGXiHaAO1cuUnd@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0601CA0051.eurprd06.prod.outlook.com
 (2603:10a6:206::16) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ef667b80-26ba-4090-3d31-08d9c0ac5328
X-MS-TrafficTypeDiagnostic: VI1PR04MB5168:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51687128BD2AA329F9469F33B3779@VI1PR04MB5168.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yp54cAxJC5iz7qi+dHLTPzht2cyJ6kEf20v0S3TNn3+IyR7qmpU8q56xtjduQJURhaW8gBBd/qUP6YnhbGBqNi18fL04qVeSgPBDUJ4rM/nhA0HkFH7V8qJr/zgC4+4OvYePYvJvhwQCjIkdL5IxgP+mA37REifOFHUjLEQGKXgixstvmBC78kaYrPFa54uayQdwAlX6qRg7UVWDMYM33C5+neToY24DUEo8TTG9SmNWK84oowJm67VGr4aKiduonmYnjPOvbp9MtAegHKfVkgA8vFKAKHgnDeepmQFkZdMjqeF0TEYXU+ZajXRJItW5yVFstmkmvfsfuV2a5VW6JXGURcTDa9Twu9tYAKQthcR2stuS5U2yQ6+oHMoSwTbaijZzP2NlcidpvA5x2/s/S9EsImeUp8lku9ebhTWXr6tW84lDdWKcbdqvB8ZYAiDI6Ml5U/TKv9apOXBN+IaLtA1TIdzWaugRV6T4D6BYzdUVY6KAgh8PFreJVBrQ/RKjo+tEc5sVcmEQh7q7PNxs1UfxS9Ol/XvWep2xlOFBN4HkUyR/LgPkZPJ8o6EPcy/mTrInMhgKzclsQiS954EIEOVf6RUEL+puQrjcJ6f+hCGnsnlx/0barfVIHTWNXPBYhYUO3tLxBH3GEC+NWU49PGWL1AWl8Rmi+bJ4RJR4+4/jH/vQxpB1M2jYoTx+l9In7qoKUrzr9aD3Km2CROOURETX8VJ71ryQmvtC3FwsO5o=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(508600001)(6916009)(5660300002)(54906003)(66476007)(2616005)(66946007)(316002)(6486002)(66556008)(53546011)(38100700002)(36756003)(31696002)(2906002)(8676002)(8936002)(26005)(83380400001)(31686004)(6512007)(4326008)(6506007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Yu0mKUTz10Y0xEDSuMjHGx1zyuYYW5nNLM+g5jXOjdMiQt0wP/9rkuqA9I3n?=
 =?us-ascii?Q?KO0DbBG0VGFjDXsvaT73uyUlZJNRhDzDNU38EAKbr8oODVpDQzJuOjj2AiPl?=
 =?us-ascii?Q?b7v+L7BzCP/5SnMPfFk4NlhJbYHDOzY3Mds3IrVAa/mglNLRSI4ke9ow10NE?=
 =?us-ascii?Q?m83YuwASBA2vgbD68cSOBBGwxk0wsuisV+Z6iow2TP0tjfH26UuGLklnQram?=
 =?us-ascii?Q?z4QOWPmn3YQYJsaqyn7aTTXXNhIjmMT7enlRZItM++u6fiZDplbstYedvBq+?=
 =?us-ascii?Q?mtU8cMtegUM+h22UxdMFZJqsRiUOeRoAHWf6U5EgwChGXWpLCdvEXjYGQJcD?=
 =?us-ascii?Q?xkctcrtHWT6hBz+LXsLHa1xSvpGGFTZHMRagapvXngd/QJYuD6JMh6kbxv7K?=
 =?us-ascii?Q?4mCtTFaTE8KiRnCdfS1lghdXXpCcewCdt20Dzodlf3kfnXw+bqwUMCG4ZJtf?=
 =?us-ascii?Q?H6ZUKwnHKAug8Wf3kYspql/7blnqHn8p8HSjZ+AB5A4PvQElMS8+0RcyD5VZ?=
 =?us-ascii?Q?6O00M+H+74rLrO/h/OIk64+EretwEazxIkN0lEvNXCG0r/6Eyv4tgR7EYQJG?=
 =?us-ascii?Q?GrqgeH2GkaSH5Y5Q0nfyPsG0k6FngdJobjnK26Vnxmpk4sGmf7w9v1imVfRe?=
 =?us-ascii?Q?xgmEDhgm1zc9pHM8DRJdLypU/YHGSEKRQkVi35iEoncsWVB8NuGe8F4vSWGJ?=
 =?us-ascii?Q?6GKbzBt8uQv9c2Jci1iBTJzWkl82oQzsI90uwacAHnRl2/R6WTHSVGlFBIk4?=
 =?us-ascii?Q?qLYJQgMxXtk8GZxs9AHG9Vkw1pfJ0Yk5egsiaonICAIwxOH2Q2kQD3vaDwxY?=
 =?us-ascii?Q?ffGBO9bS5xxtpDzKZMUJVMpL76oGeY8wg3lW57N3D+9x0rdAXmvTWfBPJa0e?=
 =?us-ascii?Q?HMk64mtyduIJIMJZj9GiV+ldCnoaX2HGkFmv1+vSEoTsZIsDXDGxdC71Ce6e?=
 =?us-ascii?Q?/eR+vpSTzb9f6mmaIiHAO7GOD/bCf/3b0gsHbxHndAww5RlFPVSCXqpnxPAy?=
 =?us-ascii?Q?c6KRcucDDW7A0wIeLBmGU3QbQRXB8yNbHaTpS4VKU0fLA3bBqhpXjhI26oZc?=
 =?us-ascii?Q?i4+d4mMcAvv8DyrtqYF8LrS2xze6kWjJtTZufsyIj5GlQtriFHS5q0J3mjtC?=
 =?us-ascii?Q?uihneiwxHW/WqNjSt1tlHpcu299jXNuFQN4SQ3BKgEJuSu+S2SMOVpnz4/KH?=
 =?us-ascii?Q?biIwpJfclEgmQw6Lvq5tIaOrLPxx5fipcJkmqzAQeo0Nd/rswlmc6qz6pY3I?=
 =?us-ascii?Q?RgykrQiHPqvn4w/+H6uIwHDquAz3WttaU27gdz+sc/MHdkFKQYsDv9gzMpk1?=
 =?us-ascii?Q?i82ATQ8ekJk12Y4tmapC/a2PrhdrZrjqwkQgyERkQqftzY+fIRjhfqiYHsuS?=
 =?us-ascii?Q?KHpKABSpCcLH9DUlN+7HVEZLBfuNOV9lnJhIRatoBcsoeIaZw61kSHvFSAEE?=
 =?us-ascii?Q?PmQzjAajn1VhFx5qfYV/KfPB9a9QS6Y6ITEigGPPL4HBoGNSYBogcqhrTwVI?=
 =?us-ascii?Q?Det6tJ49A8uihM0MIrStClGxY/3r1e2/lcT4vi39qdeySL1O6+UfYdG/J6Cb?=
 =?us-ascii?Q?tDvCLqcD1A8EweTBe0WsrZGkpnMD0Waoxn/V3561EZoK6ExkbKH8Dh4i4xbO?=
 =?us-ascii?Q?Yl+bdkOtNUhVukLfS7ASIqI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef667b80-26ba-4090-3d31-08d9c0ac5328
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 15:54:21.3148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zuBCc+1StfDnAmWQXNBuxGGk0eNJ8z3OexGeQN7hNrvwVZBScoeUkn4KjaTBNynnUIzeMiVzgFtlXZNQJBz9bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5168

On 15.12.2021 16:14, Roger Pau Monn=C3=A9 wrote:
> On Fri, Sep 24, 2021 at 11:55:57AM +0200, Jan Beulich wrote:
>> When a page table ends up with no present entries left, it can be
>> replaced by a non-present entry at the next higher level. The page table
>> itself can then be scheduled for freeing.
>>
>> Note that while its output isn't used there yet, update_contig_markers()
>> right away needs to be called in all places where entries get updated,
>> not just the one where entries get cleared.
>=20
> Couldn't you also coalesce all contiguous page tables into a
> super-page entry at the higher level? (not that should be done here,
> it's just that I'm not seeing any patch to that effect in the series)

Yes I could. And in v3 I will (but before getting to that I first
had to work around what looks to be an erratum on very old VT-d
hardware). See the cover letter.

>> @@ -33,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig
>> =20
>>  static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn=
,
>>                                                     unsigned long dfn,
>> -                                                   unsigned int level)
>> +                                                   unsigned int level,
>> +                                                   bool *free)
>>  {
>>      union amd_iommu_pte *table, *pte, old;
>> +    unsigned int idx =3D pfn_to_pde_idx(dfn, level);
>> =20
>>      table =3D map_domain_page(_mfn(l1_mfn));
>> -    pte =3D &table[pfn_to_pde_idx(dfn, level)];
>> +    pte =3D &table[idx];
>>      old =3D *pte;
>> =20
>>      write_atomic(&pte->raw, 0);
>> =20
>> +    *free =3D update_contig_markers(&table->raw, idx, level, PTE_kind_n=
ull);
>> +
>>      unmap_domain_page(table);
>> =20
>>      return old;
>> @@ -85,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte
>>      if ( !old.pr || old.next_level ||
>>           old.mfn !=3D next_mfn ||
>>           old.iw !=3D iw || old.ir !=3D ir )
>> +    {
>>          set_iommu_pde_present(pde, next_mfn, 0, iw, ir);
>> +        update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), =
level,
>> +                              PTE_kind_leaf);
>> +    }
>>      else
>>          old.pr =3D false; /* signal "no change" to the caller */
>> =20
>> @@ -259,6 +270,9 @@ static int iommu_pde_from_dfn(struct dom
>>              smp_wmb();
>>              set_iommu_pde_present(pde, next_table_mfn, next_level, true=
,
>>                                    true);
>> +            update_contig_markers(&next_table_vaddr->raw,
>> +                                  pfn_to_pde_idx(dfn, level),
>> +                                  level, PTE_kind_table);
>> =20
>>              *flush_flags |=3D IOMMU_FLUSHF_modified;
>>          }
>> @@ -284,6 +298,9 @@ static int iommu_pde_from_dfn(struct dom
>>                  next_table_mfn =3D mfn_x(page_to_mfn(table));
>>                  set_iommu_pde_present(pde, next_table_mfn, next_level, =
true,
>>                                        true);
>> +                update_contig_markers(&next_table_vaddr->raw,
>> +                                      pfn_to_pde_idx(dfn, level),
>> +                                      level, PTE_kind_table);
>=20
> Would be nice if we could pack the update_contig_markers in
> set_iommu_pde_present (like you do for clear_iommu_pte_present).

I'm actually viewing things the other way around: I would have liked
to avoid placing the call in clear_iommu_pte_present(), but that's
where the mapping gets established and torn down.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:11:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:11:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248060.427830 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtLj-0006rJ-Av; Thu, 16 Dec 2021 16:11:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248060.427830; Thu, 16 Dec 2021 16:11:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtLj-0006rC-7q; Thu, 16 Dec 2021 16:11:19 +0000
Received: by outflank-mailman (input) for mailman id 248060;
 Thu, 16 Dec 2021 16:11:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtLh-0006r6-J8
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:11:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cbe22609-5e8a-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:11:16 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-31-IDoZ6GCFPFaXd--Mh6cKDQ-1; Thu, 16 Dec 2021 17:11:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7024.eurprd04.prod.outlook.com (2603:10a6:800:124::8)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Thu, 16 Dec
 2021 16:11:14 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:11:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cbe22609-5e8a-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639671076;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=I92ZBA85YhkaIz1utKS+c48AvSwviGrRAUr86FhXOpg=;
	b=QQiHu2EJSbf6peT/K6XatVU5FgmqGX54j3uE04Px3SKdoqoeIgXglYwR1Gb8kZ/3JbEBE2
	fEq770gZnI9cMC9JbYm0ktr2X0Oyzdm7lxTxn0h6/oc0Gb0aj4mixXETozrm28LU1DI3QD
	dKYRsRG+2mP4yxI5I6zDDFziVXbfjBo=
X-MC-Unique: IDoZ6GCFPFaXd--Mh6cKDQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dk0bkO0Cydb9fz8uym0hW7FkWyohMRGgUWmxL9DAFsEWGWfSxcmNSZIdRSL3KX40n9FA/Dt8/NYZmkgTnCd6UkVq++RohcSJirwyjR4zCOkZ05k2KWF8xB2Q/EOo8qnfC1f/560v47zV86bUCiHz88/VI0pcwIn+TGW5hviPGSRBuoUkgWOmLhKt576iT441p+DDJu7BX/ZSoXOnkr99t1gp/o8STPZ+ZyluApYAMzrFLrw9QaKV5l/xZhFVIyyzA6d6IJG3qWASfg+HXVhttrGduKW/yh/LDE4PEgtlMWK2Febc1Yg807qxlHDySFirS13G/wO4X31nx7yd2x5jLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I92ZBA85YhkaIz1utKS+c48AvSwviGrRAUr86FhXOpg=;
 b=GK5xe2LKseTW18K7y9kUr90vQZ4hqiKrnxGb2RVqfswKx6wyfHCioqR8G6jZXqQPmdazuFL5LmRhuWE89OxdKNDFoJ0BX3au74otBBWpME9aVsRmSa+Mi5ltEwV5u+a3CMO2yzxGCeB4pEdpD1K4Mm83cmrbky4LTKIntxarg2w49jzfNfXy2XkxGKTD3tLABactwxhAPp203quT7erA2Pblut3UDmeNkneGf5cxoTYC4B3rbHrNKZ/bTYW5whS4oRERYJXtxziKXddMqUo9ibeQ3fp1INQ7EPTySgtIgxsYxy6Xz+Ul1RX71FIsvR4e5/GnXvGjAgswKG7BI4VwGQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <75446682-7f6a-d8c2-d30f-977096209a26@suse.com>
Date: Thu, 16 Dec 2021 17:11:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen: arch_mfn_in_directmap: Reconciliate the name and the
 implementation
Content-Language: en-US
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20211216152220.3317-1-julien@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216152220.3317-1-julien@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0033.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5a399538-9366-4f80-502d-08d9c0aeaeb5
X-MS-TrafficTypeDiagnostic: VI1PR04MB7024:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB7024796FF38D1AF09326E2F8B3779@VI1PR04MB7024.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	mZBZEhtZnnvThzi6plB9IcQkdwy13RLAs8FXIFnchsYpxFxAodk1FbSc1fq0pluNnvxSzL6aKsthwDR/kht2wCiA0HxcufoT4at0hZI0Q2cx7Omr+ndjK2GFkcBV3HvOCGPf3Q7KDALcAvnfG1c8vXkc87m072XJV5Tx7s3UBiPUsg92pYD8da9zC66iV8UjnmGP6I6Ji1W2bCw4SMiuqZPzi98+9PLu5ce8o2ZRuYxweInlSZM5v3COTYjvrg8n9wtok1vteJ7rHk4gEZhZ5EK40oxp+hmdJ3EUq4p1LdNB1xjJGprhSoKXlGzMCXFbGAROxHyT4KbXMMzESNtg3p334NntNkgfEbEybwqRkoDhsYZSkkn/yeWN28ml9sE0sOEEojHbjgoWUsB7/IwHh2PZWi+SOG/HvU/rJ0gFfJb/HVBk+cOh5LC3olcUYh5ybKGC9mfNAWi4LxSeVDjg42u6YLCLGLr32GFRwdSVSP+EH+ZTwVubH3bKbjlVvhZYGaawfHCTpU5UNrEUZc8ZOF1MvMXpdgRXmvyzBFxK/yD2vJLePOAr3NVivMAo4MhzPnRPnB5TYfpZHemLCHBrCjbFz73Lbz1QM1aXBxZY+Z90t6o9X0ns4lFO5mZ7KYPILNwylaSBjO7moseRpn1Y6Ol3YVNBA0lm4GjqdjMZ4LrGSvJ6oxfJh1nL0hea0KJB9P8eTJoRc5vKHRP0RmMvoGyuvUqWWpCcHB1yMtY7Yn7dupiTF17fXnsmQKhY3kUT
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(26005)(31686004)(6486002)(86362001)(83380400001)(6512007)(186003)(508600001)(4326008)(36756003)(66556008)(66946007)(66476007)(6916009)(2616005)(54906003)(38100700002)(53546011)(316002)(31696002)(2906002)(5660300002)(6506007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cyt1Z3V1dVFZREwwZkNCNWdteS9Va05yM2U4TzNCUXhQNnUreUhYSXJUNno0?=
 =?utf-8?B?ZTQ2RHpvTHEzV1VTUVdGMWF1aXJPMHdnNDhHeEZXckFqK0RxS01iSGR3YzZY?=
 =?utf-8?B?TkkxVEgxZkxCZzJZVmVubDJMMGp6cy8rdEdpQlFRK3NLSXVNbGJlcnVpR2RR?=
 =?utf-8?B?bUk1OGZIdGc4cUUzT04xOW9tRWIwc2I1RDg3S3lTNjlKVkJabHVJcE9hc045?=
 =?utf-8?B?R0t1MHZMc2pONDVlejFzVm5maDBjTU1YMnZBL2FEUGZIbHQ1c3NvYjY2L01Y?=
 =?utf-8?B?VkVFQWRyUnlndFBGdnh1aEtkazREK1k3Q1JQaFRpcURNZDNHb05MdkV3K0h4?=
 =?utf-8?B?d2pZWmswWUlYWVZndjVpOW9TL2hiK3ZpeWphcW5SQmhQWHBZU2tURVc3Z1pV?=
 =?utf-8?B?U1hHK3NyWmdQYy9XaEhpR3phaGRNdUc0NWRXUW1xd1A0S3NyQktQVm93Mms0?=
 =?utf-8?B?Y2JBUlhEMmJ2cXIrZmR1YWNwbU96eHBoamlRS1RER2dUY0JCNVc1R2ZpcVM2?=
 =?utf-8?B?K2xEWUpoT1ZJckFhMWhBdkIreWhiMmFRbklxMEdndVQ5MUZsVGxJZFN0VTVD?=
 =?utf-8?B?QWI5RERvTGxJOFM3MzFHQzVDWG11bFFwQVpuS3EzSURqM1pOZktmelE5ZG9C?=
 =?utf-8?B?M3J0Um84OFZQS1VkRWFPckFJem1UU0FzWWk3aUdjNUF1Ni9DRlRKVkZyWnpV?=
 =?utf-8?B?U0FUREZlNnNaVWZCVitRd1lkSHFWRlhlVWE0VGxhOHYyejlsejhBa3FzaHRM?=
 =?utf-8?B?Z3V2RFpXenVrVVJsdHB6L0RVaS9JYWZaWktTcHhCU3dtZnNRbFV6bEt1TFVI?=
 =?utf-8?B?ZUdvRUg3eXFZdFUxVzY1UUQ5bGNtQncwN3FrNTd5RWwxekZjeXM0b3R0M1BS?=
 =?utf-8?B?UDFkRHNRZWNSOGJlU1pGd3FWby8vYjZ1Y2tTRjgyQUxDZ2F0NFNncVBJOVcz?=
 =?utf-8?B?VCtXallKWFE3aU5KU09ZMXBTUXRvZDQzeUxxb2thdktjemZmdlRDalM2alFn?=
 =?utf-8?B?OUQ1a2VWQ3dZakM3ZmhvdTNUdVNIRFprUHpVeU5JbU55QnYzeGZzbVYyRDZn?=
 =?utf-8?B?OEVob0MrNnlVeVE2TnYrZU9IMHgzcncrSE5QOE9kT25NZ1NvZDJHTlZNaUJn?=
 =?utf-8?B?YzBVUjVrekJRZGw4djlnb04yVGhPZ3U5YkpDVWNJeFVDZmUyczdGVmhucmZy?=
 =?utf-8?B?THZxUyt0VDRsYWlMUHR0dGc5QmVUVXZvMXhLTDZ4d0NZSW1RSTl1eFJqd2Rw?=
 =?utf-8?B?UUdzVlBETWxCZDJFbDJGK3l5MlNidHh5N1ZpSk5CdjhjWkIrdGhkK0ZBUjdO?=
 =?utf-8?B?Q3BpUWhPWXBZRnQ0MTBUUnFzVVd6bVBQUE9xN1I1NXZCVk4vUSswYnJVS0dY?=
 =?utf-8?B?a3J3YlE3cHRKNGZuRU9yMlVsVHZkenVIc09DdXhMZkJXTllmQkNIOW1OakIx?=
 =?utf-8?B?UmNDaVh0ZjU3d3JMYnJPbWVkYk5POXorTWFIY0dtS2ovd25xQytiMG13aFJ0?=
 =?utf-8?B?RE5uMnI0eGxHOHhMQng2OVl1WnB3Q0VUV0hYNCtzVEZNQlV6M1RTUk5BSWtJ?=
 =?utf-8?B?ZmxLK3RlMGc3Z2k2S3B5T29vVGpreTBjNURaUW5JUGNCdHcxQlNjV0x0LzdM?=
 =?utf-8?B?UjhYeFJScDNFUFp5d2VlWlQ0SEtNaXJJOUtDSE5iUVBzSmIzclFpYllLME4v?=
 =?utf-8?B?Nm9WZlJIRDlscUxsQ0xqM0dnd2dZQUswWEQrNVR5eGZnYStsZkFiaGlkeUpU?=
 =?utf-8?B?NnBNQmhId3NQWXNaVDRPZzc5bGU4WHViV3AzWDlRT3liTk5vQllWSitMNGd3?=
 =?utf-8?B?RUR3SkM5aWpUWWRUOFVoTDZmdDR4OG9sb25QdE0wT1c1U0NzTUQxWE83cGM5?=
 =?utf-8?B?S3BBSlNFaXNYZHFFT1o4dGxBWCtsN0U5S2hNM2xnbkVuTFF6V2tXT2M0UXdw?=
 =?utf-8?B?QU9SYWhKWFZPQ2xoREdmbVVxd0tTekp1YUJRUFpMczJLMnNoS2xMVi9uMk0z?=
 =?utf-8?B?VldWZmRBT0hRMTRqdjRSRFFFRC9vRENNM0NzN3E2eUhuaDVYeVhVaGQxdWN4?=
 =?utf-8?B?eVIvR2lNOUxucmI0eTlzMm52MWRBaU93OTgwZ0J1M2lrb09yTkszbW5xblVW?=
 =?utf-8?B?ZUVBWkFWTE9tUDZZcVNKak9sNWJacE8xSmFndHJiL3JJRkNadmcxZElmK3JN?=
 =?utf-8?Q?dew07yzMNPSKnEKg1MBg4ss=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a399538-9366-4f80-502d-08d9c0aeaeb5
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:11:13.9105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KVqEJRoHfnVOMQ7s5nKXVEXJ/2Q/mUG+GYmTy26bB5cSTSq4Y46N+tYrXL76lhNG2qgOCMY+0N//H2PZgabMHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7024

On 16.12.2021 16:22, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The name of arch_mfn_in_directmap() suggests that it will check against
> that the passed MFN should be in the directmap.
> 
> However, the current callers are passing the next MFN and the
> implementation will return true for up to one MFN past the directmap.
> 
> It would be more meaningful to test the exact MFN rather than the
> next one. So rework the implementation and the caller to match the
> name.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> ---
> 
> Looking at the history, it looks like the check in init_node_heap()
> was <= and it was simply moved to a new helper without any adjustment
> as part of c6fdc9696a "boot allocator: use arch helper for virt_to_mfn
> on DIRECTMAP_VIRT region".

Really the original intention was to check the entire range; maybe it
would be better to express this again by ...

> --- a/xen/arch/x86/include/asm/mm.h
> +++ b/xen/arch/x86/include/asm/mm.h
> @@ -641,7 +641,7 @@ static inline bool arch_mfn_in_directmap(unsigned long mfn)
>  {
>      unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);
>  
> -    return mfn <= (virt_to_mfn(eva - 1) + 1);
> +    return mfn < (virt_to_mfn(eva - 1) + 1);
>  }

... this instead:

static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
{
    unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);

    return mfn + nr <= (virt_to_mfn(eva - 1) + 1);
}

This would allow an arch hook to also go beyond verifying just the last
MFN.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:13:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:13:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248067.427841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtNy-0007Tu-Ps; Thu, 16 Dec 2021 16:13:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248067.427841; Thu, 16 Dec 2021 16:13:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtNy-0007Tn-M8; Thu, 16 Dec 2021 16:13:38 +0000
Received: by outflank-mailman (input) for mailman id 248067;
 Thu, 16 Dec 2021 16:13:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mxtNx-0007Tc-5e
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:13:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxtNt-00034I-FP; Thu, 16 Dec 2021 16:13:33 +0000
Received: from [54.239.6.186] (helo=[192.168.25.129])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mxtNt-0005uq-8u; Thu, 16 Dec 2021 16:13:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=jA6zvzySjIArLTmgl5+j69qsnV+6ozNjjQFFbbY/s78=; b=tAoe/csIDXy9m5pfHPSwYukuZj
	n8l+GQZPjEMRs2hvZi4dRLiLbqmqBRbYsDZwJ1KGItXLz7KJ8EUdT328eUidmX057SPzlP0pLrgLN
	wpSCL7I1FN9mGKWH9rUAysTWXZ4L/bTtcRL6vsaFzUILQXwi+jUlquN0BdMJtU+6LFPQ=;
Message-ID: <4a6a9e51-1878-9c47-f8df-b561b14fd5f8@xen.org>
Date: Thu, 16 Dec 2021 16:13:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen: arch_mfn_in_directmap: Reconciliate the name and the
 implementation
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <jgrall@amazon.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org
References: <20211216152220.3317-1-julien@xen.org>
 <75446682-7f6a-d8c2-d30f-977096209a26@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <75446682-7f6a-d8c2-d30f-977096209a26@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 16/12/2021 16:11, Jan Beulich wrote:
> On 16.12.2021 16:22, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>>
>> The name of arch_mfn_in_directmap() suggests that it will check against
>> that the passed MFN should be in the directmap.
>>
>> However, the current callers are passing the next MFN and the
>> implementation will return true for up to one MFN past the directmap.
>>
>> It would be more meaningful to test the exact MFN rather than the
>> next one. So rework the implementation and the caller to match the
>> name.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>
>> ---
>>
>> Looking at the history, it looks like the check in init_node_heap()
>> was <= and it was simply moved to a new helper without any adjustment
>> as part of c6fdc9696a "boot allocator: use arch helper for virt_to_mfn
>> on DIRECTMAP_VIRT region".
> 
> Really the original intention was to check the entire range; maybe it
> would be better to express this again by ...
> 
>> --- a/xen/arch/x86/include/asm/mm.h
>> +++ b/xen/arch/x86/include/asm/mm.h
>> @@ -641,7 +641,7 @@ static inline bool arch_mfn_in_directmap(unsigned long mfn)
>>   {
>>       unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);
>>   
>> -    return mfn <= (virt_to_mfn(eva - 1) + 1);
>> +    return mfn < (virt_to_mfn(eva - 1) + 1);
>>   }
> 
> ... this instead:
> 
> static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr)
> {
>      unsigned long eva = min(DIRECTMAP_VIRT_END, HYPERVISOR_VIRT_END);
> 
>      return mfn + nr <= (virt_to_mfn(eva - 1) + 1);
> }
> 
> This would allow an arch hook to also go beyond verifying just the last
> MFN.

I am fine with this approach. I will respin the patch.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:15:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:15:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248072.427852 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtPx-00087H-5m; Thu, 16 Dec 2021 16:15:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248072.427852; Thu, 16 Dec 2021 16:15:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtPx-00087A-1s; Thu, 16 Dec 2021 16:15:41 +0000
Received: by outflank-mailman (input) for mailman id 248072;
 Thu, 16 Dec 2021 16:15:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxtPw-00086w-1v; Thu, 16 Dec 2021 16:15:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxtPu-00036S-RZ; Thu, 16 Dec 2021 16:15:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxtPu-0003G8-GQ; Thu, 16 Dec 2021 16:15:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxtPu-0000s2-Fx; Thu, 16 Dec 2021 16:15:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=67Y8clOJ2pl4yfP9rf36z/V1Qew4+tO59i0vXUFK14s=; b=rlPX8B4kDqNbL4FDWXo27UwKta
	oEHY2OaTfCRQc6THBrt42cD33pJFYv2UQdrIqiI3hEvsr1fnrwMbWDYFnuqYlxz2lJlsr6IvlrY5B
	tLmaP9kmm3RKviEEehwI0f77Yn1g3i8zxkt4ECCTrOqJBch/hhMKQVetDlgvDsvFoWao=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167444-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167444: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=856e6f0b341b19536443fd395878d9a63790d218
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 16:15:38 +0000

flight 167444 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167444/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              856e6f0b341b19536443fd395878d9a63790d218
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  524 days
Failing since        151818  2020-07-11 04:18:52 Z  523 days  505 attempts
Testing same since   167444  2021-12-16 04:20:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 89650 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:38:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:38:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248080.427866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtlq-0002Xj-4X; Thu, 16 Dec 2021 16:38:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248080.427866; Thu, 16 Dec 2021 16:38:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtlp-0002Xc-W4; Thu, 16 Dec 2021 16:38:17 +0000
Received: by outflank-mailman (input) for mailman id 248080;
 Thu, 16 Dec 2021 16:38:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtlo-0002XW-SB
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:38:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 90dabfd2-5e8e-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 17:38:15 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2177.outbound.protection.outlook.com [104.47.17.177]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-35-dNV_sfdJOlOKnHSYONrufg-1; Thu, 16 Dec 2021 17:38:13 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR0402MB3780.eurprd04.prod.outlook.com (2603:10a6:208:f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 16:38:12 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:38:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 90dabfd2-5e8e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639672694;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=o9fVBrIu8Eyy5mI7mHuVMZhP/7KqArnv20cCL6W0zP0=;
	b=KwmnA68wJPxQCVnd+ZU3KaTB1xfcDkFs1FSLNAF5fnVh+Fz1fLANrfWfl61M1ymYF0q8Gy
	8mVY7pzRu3loNSwRJTg8F9hbrtDLEPPhFsJT1xE32WTg1JaXI6zTt+aBMrVduWM4YvAz7y
	J3nu70Bfis1KLTmNWJnOnTLEFbkhRoA=
X-MC-Unique: dNV_sfdJOlOKnHSYONrufg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=B8FD3GVQ5MvkNb8CRhaNKAms8lWvAuci5gCtIe8wyXLwSQL6c8kRT+G8LJCjEveJY2Sgysz3eZcM2y/h8OEdexn29cqOks0MuXVeg7bJgeFXy/+1ny/Byu4TCMrY8gWQeBrA4pi9Z35KkVst6CkLWDXh0uYG59ggzKjH6KnydbXxm0bCrKpIKVnYdfwzR/Cr9XBnWYKvZmj7K+k0w4+sJGU4eKHo5WA/EK/T4PjtkGyzpK87FWmMyWT1hujmyffV40NktJpVJBUxLdOV1Zz7fmRikbP4Cz7XGxIiov/pqlLueVXvf6LdIaGi7W7qY7z/FkeGxloKxdemHwyVQqtt1Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=o9fVBrIu8Eyy5mI7mHuVMZhP/7KqArnv20cCL6W0zP0=;
 b=T4zXE2DbRl6rr/V4CMGijAQy8sHAEFou6VsUE9db6zXSPK6IbFT5BDVs3i8XhwoKmns7tHAZKrsHZ7CEbA3sL9KqkwUGrnz1U9QAvTNWrGktRhvt1mnyDPq99tPqHy2/KW1XH+YBBTuzaOG2MW1t4d2e9NkUcin8FaAZ8nkHNZTy4cuY06/TooXD6f3u2EwZLBgVCgK97Pn+SfGxqoF9wHdH2LVsWb1EP1k5eisCRJUJR+HRFr+iDj3DDfyIGOe3l0rB+ePY8dYAhHGfoLJsSIrcNQUrbE2Icn3bqzyZ+bwD6G+RaZ//Q3RSE20lhGssLAlb9Qezu/i72mBiwcUxrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b95bc243-c4ca-824f-1812-1f0a74e22193@suse.com>
Date: Thu, 16 Dec 2021 17:38:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of
 init_domain_cpuid_policy()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211215222115.6829-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0147.eurprd06.prod.outlook.com
 (2603:10a6:20b:467::19) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 37789c90-3a1f-4b87-dbe2-08d9c0b27342
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3780:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB37808066C560E7A21FD962B4B3779@AM0PR0402MB3780.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	15p2kZYuwVpGqd4MHGkjF98wgonHgSfdsPHb1tREX0riOCGaeFY6z65rncOOwIsGL3Z52VjtZhcN187k8g3EPYq+Tdc55mdiSKJN6TuzyhisOHx4t49qO8ny3RUF07TO9lLsPorzTX4CNCW9j4ezrRn0Q285Q8RFgLaKS3m0SwZGEIqazjg1DRv6RaoDIzLrGQTcbrAa8p5XTrV+caCIdDvn+4b8v6HfcDub8gliK8qM//Wcu6cagXbeZxWdBXsDFsryHiNi00PIGSFZjb6s7UastpsMeUhCW+9qqzuXrLPQyWdtDJ13/Q8gQUQdmRn+ek0ziFnGbNaQCsCBT1J3ASjWBDC5XYSsU2kwV5Xycq/oJhPlF4dJqdKzHBurMjXFpqfSDlNCQHsHGmpz7t/1nHAxHGavodO189PvE+fHdmSnfObb1ydz2biPLImVvPIfmCSPi5guQE/tpe0UHlO9XZkT1+yr7nz/LP2Im9AFhHkHZx8cs2S8LZTPisxwAjYD3N5Fdb5PmRO+YqU4V4jjLII1xgGb5Cs0RqE0MHdzvXwF99Z9nk5DRb1jZZZQ9IDi09vJ0oco+XPUvs8jWCx2m/lAi12V1aM7rzv9y+u/zdiY3nSRdgcBxXwKa/i2VgGgqGQdAyoUNfKxyzc/M+8/ajrZwB5AA0BfvSeVhoJsF5BFbt4jDCMKIofXBQ7ouqcc5AouRXPFJfuo58zUoZhacHRqE5VFrNvqxmxdxz+UukK7WHPUBVTi1DbnWsL0OQJ6I23XkUGMPfAPwujui70ma/cNYUayAoB6HpM907UoVYc=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(508600001)(66556008)(66476007)(2906002)(186003)(6486002)(26005)(6916009)(316002)(36756003)(86362001)(31686004)(54906003)(31696002)(8936002)(6512007)(66946007)(53546011)(38100700002)(8676002)(4326008)(6506007)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dTloSmlidm9TQWlNb1BwVUQzMkNST2pXcmtKS0thZERtUy9yT1pwSEtuSEpC?=
 =?utf-8?B?QzBUQ3A5cWhKcTJTN3dVQTExUzNSMkNGcVViQWZENWRQUUpLYVZ5MFRmZDBy?=
 =?utf-8?B?SDl5UGVoSEJBL3ByWUJMWUdHdUljdm93Njd0UTBRUXZZQ3E1eHFvZXc1OGpU?=
 =?utf-8?B?blIrMDhHTmE0OTRuc3R1bEVDTGlvalZtaEdNcnFJbE5QNHVYQ3I4ZElzU1Fr?=
 =?utf-8?B?NmF2TnpRVHBJZ0lLRUxobDZCaU91aWJuQU1nUXdLdE41Uzl6RGowWWpxMUZm?=
 =?utf-8?B?MDdHWDExZEU1N1JyRHdYSHNtdEI1di9paDkvb3JmWm9JZk5nL05pcS9sVHdJ?=
 =?utf-8?B?bGhkdW1yZFVmVytkZ0lwL3M0c2pGWWNSUDY2ZW5uSVh1azBxV3B4ZkwrYXpD?=
 =?utf-8?B?Zi9SOXd2TDFSZlB0ZnY4RExvWmZ4MXFXMUNSWXRUTTVFWnJlK3A0SE9Od3Ro?=
 =?utf-8?B?Vk5OTDJJRXZtZFE2ak91WG1PKzZGbUVPVjU2ZU4zOEtmNmNZNVlHSWJNcGky?=
 =?utf-8?B?TlpadXVpZGVTdXFsNFA4dm16SHRUQ0psanlqdzlpS2hTL29qcVFkZE1wOXJx?=
 =?utf-8?B?MzlaT1c0anBPeXI5YkNRMTEwTHRMREpQa3JMSEkxc3EweXlxZkJNaDBaZjVS?=
 =?utf-8?B?bVRhT3lOWDVxQWNpNHN1citTRnpIU0pGRTdYMWxTcWxteDVQUE4rTGN0aWp1?=
 =?utf-8?B?Mjkxc0d5c1FUdFZpNHd5d3BISWQwWUxDMGVhM0tZOVBNQjQ3ZDRWdWtaTWwx?=
 =?utf-8?B?WVZFYWp5RWhOV2ViNEp1dlJNVWh5MmFaaU83MlFWMmo1SEtvZFpFMWtESGIy?=
 =?utf-8?B?bzBUZVgyUVBRdUhvM055WDJ6VHFia3lmNmNISUxqTE85KzdZcnlmOXhxYWFm?=
 =?utf-8?B?eEx5M2pZM3lRYnJLby9ydEVOaURpcHJhRGFjdE0zc3FaVHZ2Q285R3Rmblp0?=
 =?utf-8?B?TmgyMmdIWmhKS0NJREJVeGJJZk1PRjd6WDZPSEhLT0xkWk5ncXcrNHBKNnpO?=
 =?utf-8?B?ZjVzK0x4aGFDdnhwZDd2S09oYXg4NlZOVzI1NTNjNTIxampxRnBJNDVuN2lx?=
 =?utf-8?B?YjUvUHZJbGVVU2VrVHZTRUpjME95RndVRUk5dGF6TU55RkQ1eGhiVWtOMDNo?=
 =?utf-8?B?VEdPM0VnLy9HYytJak9yRm1mTnVTVHdpVEVqenJraXBtTnBIc1M1dG94WVlS?=
 =?utf-8?B?bC93Szd3b0xmNGx4MElWY0lJN0NFLyt4YjJLWGdaby9nbXg3Z3dqNWxzTk1M?=
 =?utf-8?B?bWF6amdsUWFGNG9pbXVPUDRRUDNyaGVrRzBsZmtzSE9NU2Mza01STGxQN3VD?=
 =?utf-8?B?eUZ2VnJjNVZnSEw5eGcrQ1k5bUFFNkNscEM1SUVnYVR6ZnZqVXFDQmNHYzFj?=
 =?utf-8?B?M3BTM2JLSTZLeC9Fa2FTV1JIWFloRzZIdHZPbHI3bUpmZUJRWHVYYzB0Y1h5?=
 =?utf-8?B?ZDlac2NSQnY5SjJyOVdEZU9Qc3lFU0xTSENOQzR4K2RCZ0paNXZwTnZqQnJW?=
 =?utf-8?B?aDJRTXZlS1Q2MkUrNlZDbHBPOWZtMUxwZlFnOWxxQ2JKYXMrUjJWZGZ1VFl2?=
 =?utf-8?B?TWNMNkJFZUxIb0hZekR3Y0dVNFh5R1F3b2RFSXpWaGttMjZqcXgxRnQybEJP?=
 =?utf-8?B?VDZudFpOSzVkSzZMaVQ0cWhRdHZjcnZLcW1vdm1vYmhrWEU1QW1NaDZIN0l2?=
 =?utf-8?B?dmdUSlJKb0Y5Sk1ET09SVUNxWWNQSlIxNHZReHA5UXJaY2NwUnRzY0JGOFVJ?=
 =?utf-8?B?WXFrY3hkVVRyZmhzRG92aGFWdVk3UXliVFlDeGIzR2ltTG52M2NOa2svazho?=
 =?utf-8?B?QXE1ZUl3YmZIaUJhSW9YYW5iV3JzNElvalp6UEhCY0daSU1Pd295bHJKZHVX?=
 =?utf-8?B?K21NVXRXZnZRaUlCTU9YYlBZTzF6eWEwNE8xUlo4SktPRk5sQ1ZiQzYvK2Za?=
 =?utf-8?B?WnhFZ1JVcitvSEo4U2EzVks0RFVXNUx5MEFWZHJORUdCUmh4cmVkVGk4QmJE?=
 =?utf-8?B?eDhGVklQR1c0TlFCbGNUbXZhOHlQSVhxZzd5d1FwMXcvT2Vpd013amNUUkhD?=
 =?utf-8?B?bEZ6aXBOWGd4RTZOYWx4UzlROElEVnNYYTNmQlpVSk1tQXV1OHJZb0ZVeVpL?=
 =?utf-8?B?ZHBvWVBVbHVvVjhnTjBVamNKLzhhVk9lY2VSdzZXS2l3VHkxOGcvZlcxd3RH?=
 =?utf-8?Q?PcTE0TuDQJSC5G1ycrPL1lo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37789c90-3a1f-4b87-dbe2-08d9c0b27342
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:38:12.3858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bXaUpau4Gd5ev5ylbCv6ZozeuWiE3cK5niD1Zb12I5UL0wBx/1IwEgkgJk88f2BGeB7YuSjCiV0Q7gzo5EGcWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3780

On 15.12.2021 23:21, Andrew Cooper wrote:
> To implement dom0-cpuid= support, the special cases would need extending.
> However there is already a problem with late hwdom where the special cases
> override toolstack settings, which is unintended and poor behaviour.
> 
> Introduce a new init_dom0_cpuid_policy() for the purpose, moving the ITSC and
> ARCH_CAPS logic.  The is_hardware_domain() can be dropped, and for now there
> is no need to rerun recalculate_cpuid_policy(); this is a relatively expensive
> operation, and will become more-so over time.

Would you mind leaving it there in a commented out form, hinting at when
it may need re-enabling?

> Rearrange the logic in create_dom0() to make room for a call to
> init_dom0_cpuid_policy().  The AMX plans for having variable sized XSAVE
> states require that modifications to the policy happen before vCPUs are
> created.
> 
> Additionally, factor out domid into a variable so we can be slightly more
> correct in the case of a failure, and also print the error from
> domain_create().  This will at least help distinguish -EINVAL from -ENOMEM.
> 
> No practical change in behaviour.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Preferably with said comment added:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:41:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:41:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248085.427877 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtp3-00044Y-IR; Thu, 16 Dec 2021 16:41:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248085.427877; Thu, 16 Dec 2021 16:41:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtp3-00044R-FJ; Thu, 16 Dec 2021 16:41:37 +0000
Received: by outflank-mailman (input) for mailman id 248085;
 Thu, 16 Dec 2021 16:41:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtp2-00044L-87
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:41:36 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 080d39ee-5e8f-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:41:35 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-6ovnGGmgMl-a_GW1CjFfxA-1; Thu, 16 Dec 2021 17:41:33 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR0402MB3780.eurprd04.prod.outlook.com (2603:10a6:208:f::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 16:41:32 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:41:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 080d39ee-5e8f-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639672894;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=luB+Mf7pJjnqPCitBgL8p9zUUUYOQDkRsBJj5q8aClE=;
	b=DIfGj6rEqcH93DiT1bgEtVXdm/+EWWCsVNMa1ew0CR/dB4YaFPl/ridMfl2onB3CTVMAdc
	F18Et84hiSx5cQEUpYjjy4v3bHSAGRvE4uEQx+Nii2CCVnAXiZIKBC3Wd2Sg9BGtmSQe+r
	6Tt5QnW3kAWvl/nnxuAsUy18E+uBwlY=
X-MC-Unique: 6ovnGGmgMl-a_GW1CjFfxA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ROtTL+gZukwPxFeDPeC/Bw5P3VubSPx9/Rncx7fgd2c3HdnnTk6tLCVWoVcsTyw2TEuNwN7DrHA3gEqFgNfoWNXHOSOiW9x45wVtPEkkl9YC8fovveMASV3pwSgAew5a9GJYd0xNfI3ofURKP0nwVEboxFfup8qq2GHHKmprkAER3HMKHIaCd6DP5r+YZEqmpWsciTeu6cnVmXPyzmJaLY808WdW5agYrRG6IRkDzyK539CUIehpMlxxbc6q9Mg1b2rJCy3cx0/HwONoizCYcFBMmB3oe/GQzKIYNkE5AWVb8ZlioAb43wsh3xBiCF6FoS3mHgxjNlAEgiudDKF0cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=luB+Mf7pJjnqPCitBgL8p9zUUUYOQDkRsBJj5q8aClE=;
 b=cWSXFw61HYh7v74i80Xl9FgE5ADRFHyH6U1Rtlkx2vp4pZsAuNv90idiuKoOsWNB5QFcbD2KbKmK+wuD50qmzWI6zzBvod12dsg7zjEstGPCb+MvOz/T4KTBuLKWkbBiHlcOrOYKfGrI3ABV6Rog8+KtnZqHKJtwdns+mPrmIVcSdjD/LGCJRuTAcvFXhbLJ+yj3jI9BP0VeThTTpQCdmbRCroCtzLN1MWAPJXkoqqpw0SL1MmjNll0r5T70wRuyNXh6OqSrpduhgDt3qYoDWRVOKPVfrT5r8qNlddIGEFChlI1AL/VOOF00JkO+TP/IzutznhZZ4whasE8LP5ihyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <49a6035e-9291-7a67-ad78-be6ebde79def@suse.com>
Date: Thu, 16 Dec 2021 17:41:30 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 2/4] x86/cpuid: Factor common parsing out of
 parse_xen_cpuid()
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211215222115.6829-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR08CA0037.eurprd08.prod.outlook.com
 (2603:10a6:20b:c0::25) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bf05c5a0-887c-4ff1-2d03-08d9c0b2eaa6
X-MS-TrafficTypeDiagnostic: AM0PR0402MB3780:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR0402MB378068092DFDB75E3412F234B3779@AM0PR0402MB3780.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UQPMZb9e58ep8deNMqQNIEZGnAJ7zX+WA5ypVYxoX++/B20xugTyWLhVlGbhG3eR+6R92t5zasvlVVhf7677s1uRygUHfJXRXfQ/l0gm3RLz/UUzrnbdufn29G8duGYILZW7uTrJhWwf4+WqyzmI5dXE8vCJreqqmE/R78RKBeAGF7f80Fursf/8SIl4DR0ueqX23SoMpJzgourfes1va1/mBlm3nuanUXAbKZxrbdoM/7gzyA25JiIFweiOlaGeZZceylqOtZSkrmtMxAUQazDY0Ve3MKSB9iqD/w2ska2ASMlptUPcoq7JgegJWHM6Iaz/q4UnRWlqkMpGy78DOI+y9rxbXG/F6DWR8eelafGILuavNX8BQiTd58FqfEB1/9lrZzwXsd7LnzoV0waiwKVs3Dq9pQPEqfaXWZzFS8X9heuzwTSq/EDAbgN2yjHqm0TrueBWWFISv7ysE4muEOHHhsGoFWYDrSaIFTxqgzlBFfyKjDGtooLE4iZe0ioPLYAE+OWFIJ118o74s8FE1iN0B3Ia+W714Er1eEC7ixjBCHttgYD5YZrSbjzuMgUuv9Ez4ma3Rv/geVQawuiVuMSNhM/LpS64pHGVOgpHLQHrIt0X1DTX6hRh5LlrS3Sv2fJf+PaEw9qHjMb60Ylv7GCrSmeTwB0tqtB5B44iKbbABvbNtso7ho3y0JPS+Us4uFJC8yjHtwHKhvNy82GpvgWagKYa8uLtZbFdirPYJQgKrhdOkSQFN3xvG5PPUC+VIANZV/7IJH26YBen/9oEc9kDVenLne8n5OIRp1mht4U=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(4744005)(508600001)(66556008)(66476007)(2906002)(186003)(6486002)(26005)(6916009)(316002)(36756003)(86362001)(31686004)(54906003)(31696002)(8936002)(6512007)(66946007)(53546011)(38100700002)(8676002)(4326008)(6506007)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXRQUzNMNXVDUTkyZUV4SkZ4UzZvZGVJbThRRittT3lucnBnb043bytyS0Jj?=
 =?utf-8?B?bnNFeE1sNUFOcFd0ZW91WTRZR0tVZEMrT2E3S01GQ1RaNGJubDJ2U0VKa1NH?=
 =?utf-8?B?RlV1MjVraXVTdEZsdzV2Zmp4SU82aUp5eTR3bVJsdGJOcktlMzJlbmhFUWdK?=
 =?utf-8?B?dm9JN2xJem8zYUhTajhwWllrb3BNWFM3eTNzU1dEOG5ycVB6dHJpY3RxdGFa?=
 =?utf-8?B?aHY2SWZ4MUtpY2hJUFdnbHZmeVlianl0QjZJeDNDb2dOUklCSVFFaXNzcWVz?=
 =?utf-8?B?Vy9tQjFiNEROcmQ0Y3BYakhCL2hCTkhJRTl3UlQ4aEYvcHBUSmdSaTVFcEUv?=
 =?utf-8?B?bWozOHBFN1FKSTdkVmxHd0dqMGFmRW9PTmJDNGZRb0VoY3ZXMDhRenRaR3Rq?=
 =?utf-8?B?M1RCbjFWQmV3VjhOQzFkZTMxcUVWb0d0cEp4d2I5RGwrbEhCbDJWTDdwd1Nr?=
 =?utf-8?B?YldHR0dzS040amw5N1Fxc2hqQm1CYXJsL3NKOW14bXRaU3hwckZPM1MyYkJJ?=
 =?utf-8?B?M0hxSStDZzV3cHJIaWgrTnpLOXhkRFkrNC9PcVhOSS84ejBlZzJjRG5NZzdI?=
 =?utf-8?B?R2c3d2tQMUtEMW8wUWt5anZKa29BOFc2TnZnUlJIaHduT1VuRGx2Smx1dkVN?=
 =?utf-8?B?a2JTYnV1K3lQdEZHekdhVUlCZno4ZldMZ1JqWU9Yb1p3djQ5eThnbUdKeFN4?=
 =?utf-8?B?cGxYNExwd00yOGRJbllYZFkvSWhhSjNNSm9YdzAvaitYb2tNdXVjM2RES0dj?=
 =?utf-8?B?OWNYclFUcEJ0N3dXY01LelRnWHRiRU1OMHpWN2NoMjdIamphd0RoVEtEeVZM?=
 =?utf-8?B?K3BLYVduVVhWUjNDWWxWNVRFdFdZd0NxZUFaOUd2VmlwbmpERWgzbEpReEsw?=
 =?utf-8?B?TWZHYzNUVGtSd2d0NHNXaUVNL0VrQjFyNVB2a081RktuR21kVldITHZvazVJ?=
 =?utf-8?B?a0lrbWg5MUZOSWp3SGFXS3lySzdpU0VBVS9VeGRJY2U5bHpQc1JjMzFIMVNY?=
 =?utf-8?B?N3I3QUprTm9jRDQvc0RjV2J0TFkyTVBkZ2ErV3NMV250NTR5Q2hxR0thT2xI?=
 =?utf-8?B?VVVDS1JQVjdLanBqZVhVdWR4NnR3RVU5NWcrNUpzSHNXVC9TYWg2OVR2Wmdp?=
 =?utf-8?B?L0Z2YmZTYndXd05vUXpOOFM4TUJQTE9aYllkeFRIZUJVU2gvMXFLNld5Yitm?=
 =?utf-8?B?Z1k4OXhheFl4YWRMMk00OGRkc1lXN0RMUzBYSXBUWXQ0VDlJbnRIbFNWZ29Z?=
 =?utf-8?B?M3pJZXBsMHdJMTI0N05BUHg0YTBkZnV6TmQzN3lvUFZFZTcwYTA3clFuZ2Fn?=
 =?utf-8?B?MCt0anlJZEZucGt1Q292Sm9aV21JQVRWUzdnMXRKSlZTZHlyaloxdi92VkN3?=
 =?utf-8?B?NFBtMjRJOUlqL0NUMjZWY1ZWRGtXOU9aUFgwZmh4Ui9LNFUrbVZIRUg3VkVZ?=
 =?utf-8?B?SGdFRWVjcVZYT2MySFJybTRVWnlPanNYeTZVZDdFaDFPZjBaeFpxNEVkL3Zq?=
 =?utf-8?B?TlR0QkR5R2hFc1FZZkdzakhUU2lPM01KaC9EQUFTaFk1OUJTUUc1c21CYWpN?=
 =?utf-8?B?YUVKNTNsR2t0Z01sWDE5bW5VS2lxMVpmNHpJQVd6c1dsSitGbEtqdWRRMVZW?=
 =?utf-8?B?eWwzNzdMeExuSFQzOEhCRjJSaWw4NVZGMXduUFE2Y3J2QVdOWS9GcGdUdEND?=
 =?utf-8?B?YWlzSHk2elFOYU9kU2dmN3I4V2t3OFhFV041aDBNYXdEcmkwbmR5bGZpTnA2?=
 =?utf-8?B?aUFBT3JkZlBFV3NTWHpxV2RHREErcVZTdkluOU9pRm1Qdk5tNlo3ZnFVa1JF?=
 =?utf-8?B?L0JSZENBSG5GakVtUjFldlN6RUxZeDdvSXhnSFJHbGxuOVdmZ1c3ZHIzNS91?=
 =?utf-8?B?MVkrelUyOXg2cHdyMCt0WVZEMDFPNE5kWUIxeUV2djNMZ0QvVndpOTZ5TXJ2?=
 =?utf-8?B?L2s0RmprYnhpbUxSUlZBbFRNVmNQNjVTclVCYjdMcUxYK1kxUHY1RUw5T2hU?=
 =?utf-8?B?bndsd1ZobSttdDJ2VzlZblZGVzB1cGtESTRRVlZhckpkZXNYcVRMS2Rua1N2?=
 =?utf-8?B?SnRRRU54RFkvbGswTjZVaDhTNGdXaHR0N1YzMytkK3JuSm93MFYyMmwzb2hh?=
 =?utf-8?B?d3VyVlNVb1lZa3daaEpwWTV2bk8rNVhsb1ZlMVpDaTZtcjFRMytZcjgyd0Q3?=
 =?utf-8?Q?+jBVC/8bPyzpw5Xn9YvlU2k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf05c5a0-887c-4ff1-2d03-08d9c0b2eaa6
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:41:32.5137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UVg2z3LLlrWpm7WNc1XOT9fnDmxS44Rs/9q4PWx8qWrJ31O5XnGV6j4xh3VPEdGHxjUyiow7KYcI4nOxKq8jTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3780

On 15.12.2021 23:21, Andrew Cooper wrote:
> dom0-cpuid= is going to want to reuse the common parsing loop, so factor it
> out into parse_cpuid().
> 
> Irritatingly, despite being static const, the features[] array gets duplicated
> each time parse_cpuid() is inlined.  As it is a large (and ever growing with
> new CPU features) datastructure, move it to being file scope so all inlines
> use the same single object.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> We probably want to be wary of fallout from this pattern elsewhere.  I only
> noticed it by chance.

While that sounds at least close to a bug, there might by some subtle reason
for why they have to do it that way.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:41:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:41:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248087.427887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtpK-0004YI-QD; Thu, 16 Dec 2021 16:41:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248087.427887; Thu, 16 Dec 2021 16:41:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtpK-0004YA-N9; Thu, 16 Dec 2021 16:41:54 +0000
Received: by outflank-mailman (input) for mailman id 248087;
 Thu, 16 Dec 2021 16:41:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxtpJ-00044L-1f
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:41:53 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11824273-5e8f-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:41:51 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44476)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxtpG-000IYz-1v (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 16:41:50 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 566351FB21;
 Thu, 16 Dec 2021 16:41:50 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11824273-5e8f-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8e648c7b-33a6-642c-e4ff-78f17a35dbe3@srcf.net>
Date: Thu, 16 Dec 2021 16:41:50 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of
 init_domain_cpuid_policy()
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-2-andrew.cooper3@citrix.com>
 <b95bc243-c4ca-824f-1812-1f0a74e22193@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <b95bc243-c4ca-824f-1812-1f0a74e22193@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 16:38, Jan Beulich wrote:
> On 15.12.2021 23:21, Andrew Cooper wrote:
>> To implement dom0-cpuid= support, the special cases would need extending.
>> However there is already a problem with late hwdom where the special cases
>> override toolstack settings, which is unintended and poor behaviour.
>>
>> Introduce a new init_dom0_cpuid_policy() for the purpose, moving the ITSC and
>> ARCH_CAPS logic.  The is_hardware_domain() can be dropped, and for now there
>> is no need to rerun recalculate_cpuid_policy(); this is a relatively expensive
>> operation, and will become more-so over time.
> Would you mind leaving it there in a commented out form, hinting at when
> it may need re-enabling?

Leave what?  The recalculate_cpuid_policy()?  That comes back in later
in the series.

~Andrew

>
>> Rearrange the logic in create_dom0() to make room for a call to
>> init_dom0_cpuid_policy().  The AMX plans for having variable sized XSAVE
>> states require that modifications to the policy happen before vCPUs are
>> created.
>>
>> Additionally, factor out domid into a variable so we can be slightly more
>> correct in the case of a failure, and also print the error from
>> domain_create().  This will at least help distinguish -EINVAL from -ENOMEM.
>>
>> No practical change in behaviour.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Preferably with said comment added:
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> Jan
>
>



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:46:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:46:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248095.427899 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxttF-0005IL-Bh; Thu, 16 Dec 2021 16:45:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248095.427899; Thu, 16 Dec 2021 16:45:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxttF-0005IE-7z; Thu, 16 Dec 2021 16:45:57 +0000
Received: by outflank-mailman (input) for mailman id 248095;
 Thu, 16 Dec 2021 16:45:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CQEQ=RB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxttE-0005I8-Dg
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:45:56 +0000
Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com
 [2a00:1450:4864:20::32a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a2cf7118-5e8f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 17:45:54 +0100 (CET)
Received: by mail-wm1-x32a.google.com with SMTP id
 bg2-20020a05600c3c8200b0034565c2be15so2218647wmb.0
 for <xen-devel@lists.xenproject.org>; Thu, 16 Dec 2021 08:45:54 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id c7sm6245964wrq.81.2021.12.16.08.45.53
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 16 Dec 2021 08:45:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a2cf7118-5e8f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=+etdRS/daZdfb1kFunIAs+E4JtTtbruMLbJELxTBUH4=;
        b=MrDuzVVdPXhJYwE7iIUbjH0/jQk5ILZP5e0VgnaAn+g+Ous1eTZvL0pLpMfB6UOg5y
         kk83oTvtwDZOF01VyC12Jx8OoydW8fk6+1EMUuEz8sBvoJIC5ooSIIUdRlW1jVzdYtAK
         wwuQh00ha6FUI+W3fsRAWDPHgd/OPD+cltbPe8RhGK5nG2QzztErbJdBZJHI9oZkynb+
         Aky+XTubPhParojArPgqUBNqMaePhgquYm2VTbrAxYROQSOWFqFXXAf2ZsMW6rgxeyN5
         dKWSb37S4YdiSoDhzrwBhs6eXlS2f435OJCsm05yDBeZg5uPc1mGYEbDyACpPlTFPpCO
         zfRg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=+etdRS/daZdfb1kFunIAs+E4JtTtbruMLbJELxTBUH4=;
        b=72q51LSnFA8lCHpiNC3SMea1zH2+zeXtNlMU95QLL9nQ8HQzT7R0njdbD1Rl0pnxiu
         SZnGFGZ+r7hB4kPjwAobsp6KDYO73aDy5y5CqOD8U7bfFg0Txc+SHRQnjgsCoVBU1KH6
         BjKfrci/V5/DgfSo61PuXHj/nyjjK6+5GQQXmvrckv7E6SLJIvXc4gH0yTMtylcDuc42
         AXgGjupQnBjMnxTuUFJ5XIqWdxDsX/eJpA059u9H5rGXDAhND37OfCGJMV1RUhkdVXxe
         bsDgftrH+hCMCTfY8cpXDuTZOd21A9HfT/uohi3A11nrQHb57mKp532lphisANeEUlYr
         upcg==
X-Gm-Message-State: AOAM533v3+E3Z0TC8IVQJcs9I6G1QyB9uwzXyzlvj0upr/5uDJBIEfSq
	QDNYvzGa0B/Vw0sQGKvPtznlb8+CkP4=
X-Google-Smtp-Source: ABdhPJyTwEMkuooS+OVJiIAsQWhsyVnTl6tkPtWi5tAz9DdnZauYDouEZZQFaWx+G0YE2G2zWZdqGQ==
X-Received: by 2002:a05:600c:3486:: with SMTP id a6mr5767899wmq.32.1639673154301;
        Thu, 16 Dec 2021 08:45:54 -0800 (PST)
Subject: Re: [PATCH 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP
 to 0
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638035505-16931-1-git-send-email-olekstysh@gmail.com>
 <1638035505-16931-9-git-send-email-olekstysh@gmail.com>
 <TY2PR01MB369226FC51154F6E9BA37886D8779@TY2PR01MB3692.jpnprd01.prod.outlook.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <80abfe7e-154c-6698-465b-e317d8f5c156@gmail.com>
Date: Thu, 16 Dec 2021 18:45:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <TY2PR01MB369226FC51154F6E9BA37886D8779@TY2PR01MB3692.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 16.12.21 14:48, Yoshihiro Shimoda wrote:
> Hello Oleksandr-san,

Hello Shimoda-san,


>
> Thank you for the patch!

Thank you for the review!


>
>> From: Oleksandr Tyshchenko, Sent: Sunday, November 28, 2021 2:52 AM
>>
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Based on the following commits from the Renesas BSP:
>> 8fba83d97cca709a05139c38e29408e81ed4cf62
>> a8d93bc07da89a7fcf4d85f34d119a030310efa5
>> located at:
> <snip>
>> Original commit messages:
>>   commit 8fba83d97cca709a05139c38e29408e81ed4cf62
>>   Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>>   Date:   Wed Apr 28 18:54:44 2021 +0700
>>
>>    iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
>>
>>    Need to set bit IMSCTLR_USE_SECGRP to 0
>>    because H/W initial value is unknown, without this
>>    dma-transfer cannot be done due to address translation doesn't work.
>>
>>    Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>>
>>   commit a8d93bc07da89a7fcf4d85f34d119a030310efa5
>>   Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>>   Date:   Tue Sep 7 14:46:12 2021 +0700
>>
>>    iommu/ipmmu-vmsa: Update IMSCTLR register offset address for R-Car S4
>>
>>    Update IMSCTLR register offset address to align with R-Car S4 H/W UM.
>>
>>    Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>>
>> **********
>>
>> It is still a question whether this really needs to be done in Xen,
>> rather in firmware, but better to be on the safe side. After all,
>> if firmware already takes care of clearing this bit, nothing bad
>> will happen.
> IIUC, we need this for IPMMU-DS0.

Yes, we have confirmed that by running dmatest app over SYS-DMAC1/2 
channels in the Guest on S4 w/ and w/o current patch.
So this clearing is definitely needed.


>
>> Please note the following:
>> 1. I decided to squash both commits since the first commit adds clearing
>> code and only the second one makes it functional on S4. Moreover, this is
>> not a direct port. So it would be better to introduce complete solution
>> by a single patch.
> I agree.
> However, I realized IMSCTLR and IMSAUXCTLR registers' offset differs
> between Gen3 and Gen4. About BSP patch of 07/10, it seems to take care
> of the offset. But, Linux upstream based code doesn't take care of it.


Yes, I assume this is because Linux upstream driver doesn't support S4 
yet, so there is no need to clear the USE_SECGRP bit in IMSCTLR so far
and Linux upstream driver doesn't use stage2 translation table format, 
so there is no need to set the S2PTE bit in IMSAUXCTLR.


> So, we have to add a new member (maybe "control_offset_base" is a good name?)
> to calculate the address.

Agree here, control_offset_base sounds perfectly fine to me, will do. I 
already had to diverge from Linux in 07/10 patch by introducing 
imuctr_ttsel_mask member (which is (15 << 4) on Gen3
and (31 << 4) on S4 due to the larger number of context supported by the 
latter) as Xen driver has an additional hardening code in 
ipmmu_utlb_enable().


>
>> 2. Although patch indeed does what it claims in the subject,
>> the implementation is different in comparison with original changes.
>> On Linux the clearing is done at runtime in ipmmu_domain_setup_context().
>> On Xen the clearing is done at boot time in ipmmu_probe().
>>
>> The IMSCTLR is not a MMU "context" register at all, so I think there is
>> no point in performing the clearing each time we initialize the context,
>> instead perform the clearing at once during initialization.
> ipmmu_domain_setup_context() is called in probing and resuming.
> So, it's enough to clear in ipmmu_probe() I think.

great, thank you for confirming.


>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>>   xen/drivers/passthrough/arm/ipmmu-vmsa.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> index 8dfdae8..22dd84e 100644
>> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
>> @@ -229,6 +229,9 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
>>   #define IMUASID0(n)            (0x0308 + ((n) * 16))
>>   #define IMUASID32(n)           (0x0608 + (((n) - 32) * 16))
>>
>> +#define IMSCTLR             0x0500
>> +#define IMSCTLR_USE_SECGRP  (1 << 28)
>> +
>>   #define IMSAUXCTLR          0x0504
>>   #define IMSAUXCTLR_S2PTE    (1 << 3)
> As I mentioned above, we have to adjust these registers' offset for
> both Gen3 (+0) and Gen4 (+0x1000) somehow.

Yes, I will take care of it.


>
>> @@ -979,6 +982,10 @@ static int ipmmu_probe(struct dt_device_node *node)
>>           set_bit(0, mmu->ctx);
>>       }
>>
>> +    /* Do not use security group function. */
>> +    reg = IMSCTLR + mmu->features->ctx_offset_stride_adj;
>> +    ipmmu_write(mmu, reg, ipmmu_read(mmu, reg) & ~IMSCTLR_USE_SECGRP);
> If we modify the 07/10 patch, we cannot use ctx_offset_stride_adj.
> # But, using "ctx_offset" here seems to be abused though because
> # the register is not context.

I agree, it is an abuse. I believe, this will be solved by your 
suggestion to introduce control_offset_base member with proper values 
for Gen3 and S4, will do.


>
> Best regards,
> Yoshihiro Shimoda
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:46:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:46:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248096.427910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxttN-0005bm-Oi; Thu, 16 Dec 2021 16:46:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248096.427910; Thu, 16 Dec 2021 16:46:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxttN-0005bf-KB; Thu, 16 Dec 2021 16:46:05 +0000
Received: by outflank-mailman (input) for mailman id 248096;
 Thu, 16 Dec 2021 16:46:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxttL-0005I8-Vj
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:46:04 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a79b7e07-5e8f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 17:46:03 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2055.outbound.protection.outlook.com [104.47.13.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-W92wN3llPqOgmPpkdyuwtQ-1; Thu, 16 Dec 2021 17:46:01 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB4787.eurprd04.prod.outlook.com (2603:10a6:208:c8::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 16:46:00 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:45:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a79b7e07-5e8f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639673162;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=I5oa3OCi82tSIPEPIb9pAdy2lDg3SCyuLi91/DtcXSY=;
	b=mnYjLmfH10mQXviv4MCYT8VSaREhQj0idLIUkLqqXeOyqrrVImccE8Q4ffycBFiSbsyzaA
	rPFead+eoxw1Q6BKIauPcEl3TT1pr6E0jetVMRZYywYIaQkoNvG1izYTxYL/gh8HQ7FY91
	lYoIgrImMnNXr811vImdJ8+RT8X5ShM=
X-MC-Unique: W92wN3llPqOgmPpkdyuwtQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e9ovmu//guZPzwWygURPyCp7NbrInc6QYWSX5saps8eY+Jhkzgz2e0OVa55ALWghpVh7dajKQ+ljenZZSNBQX+xPwdqnb4JEckf7GZ6tCGS2IT5Ie3A7jPqgurqT8L0tAnkiTVw9Fzod3RK0hNO3lKeevXqj1QWf6BMpNa2v30K01+ZIgGWRNRNkbjXGcZumhZ+585UWprF6F8nwbj8O0z33DUuBlaCKiNhEo4IUOqjfsRNYSz1xnTxIGVJadd0jFtlYup8faXe5j0v4bxZ4TCmGtda55o2jtyb7q4WwWz0ufwBPooexZyNSlck8vbnGsKu2fkPgfgBDYGSp5wciCQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I5oa3OCi82tSIPEPIb9pAdy2lDg3SCyuLi91/DtcXSY=;
 b=cxZuI/zc1Hc3fov69KpK/TLaNKvGHQXeImOQolcMs+gweMxzbUon3Zdnv2O+hCW0+8uZEsbNor17Dpn24GX/3+QPFPWb7Cv10Gi9NL6hk8JKhxKAMwthbz8A+lT0cajEuF24NivFqN7TyFFrgT2vHwWzHmCWlrlhE+Ybi85+iTTEQiD1yRvPRgi9pFt7Sq8IpCyyRlBeBIGq6jtw0OgefMICh9sVm7j0J3kvAkx7HQityH1mwI+z7UdOY0vdo785eqiwFjytj0uJDOAJpY7sF4kOW5K4tNGC/6z0cybUMNxP7k1KOyDSzN8Pgdz74J2G89JZDrcxxceenVeBaokx+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e0533588-6455-2824-f959-90d3c60f57f9@suse.com>
Date: Thu, 16 Dec 2021 17:45:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 3/4] x86/cpuid: Introduce dom0-cpuid command line
 option
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211215222115.6829-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:1e::9) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 915ccf8b-9d19-4a5e-12a3-08d9c0b38a10
X-MS-TrafficTypeDiagnostic: AM0PR04MB4787:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4787916E8566C1F28A37515DB3779@AM0PR04MB4787.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Od4QMZSrkd99qREO5yFbGN7LAhTa576ykRUIf5/AvrqkEppxUg3dBFZAEySymxHOxgdeH1YpsJ8zDPFzBKVHszE3XeZP0mhTAbZQy0yPTuHwGqTps50tfgaTZhXThPud3/Ng+WShNb4nUc147r82yIWpHe6Nz+uuu8n528UaUkplkLerIrc8KU3BzZOedmGUYFEuUl3kg6Ej9fuEQusJWmgF/7eX1e5vsa7XF8lry4BkSABoUoeQKSUIOCWhAEK8GB7CALWyzMly4Ohkd7OSVlAEEt5RgLedcqTmqaJoVr7i0Gx/NnKvd+LK7Bd2EEIAsX75Go3et7erc1XmdLWjiH1j9Hfqo+RFok7FduCGbtwJQofNI8KxEaO8thIxwu1Iu3CUd02cu8ZkH3H4SvVHzzYPfxPl0608O0Dm2s3j9DoX6x5LPHdZ5V8wr4pDwuA4b+2zXRVmuMrLNkzu60OwrqkrjJxEMjYrvmKX7c+FrjSPpAzzF7/5cQbOi1+dIz/jzl4iJcTeG4IW3QOeVhLjhXMlvZvOorKf3IpTBuWxjEpPm5l5iiIdecf+xz3VmdcX6fLwWg5soWvNeCF7KsH/NlBZtV8hzFLwxgM80rszgjiWWET0UoswM0/BdTzbfxmDjSal8fBU0cGRzOXhDZU8LCh71sVd+Sn56Kbv+HozE7aD85isssmBlPaP3LHLXS47FDKHMT00kHPu79eM8qPAKGvt9YPAtg3NO5KWKNoFGF4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2906002)(66556008)(316002)(4744005)(31686004)(31696002)(38100700002)(6916009)(54906003)(6506007)(53546011)(86362001)(6486002)(4326008)(8676002)(36756003)(508600001)(5660300002)(186003)(2616005)(66946007)(6512007)(26005)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R2xBcFYrQmFMWGxhMk5mTWlLUDYwS1lvbDM2dkx0VlhrSnpiSVB2SjRiTytH?=
 =?utf-8?B?ckVLOFRkeHIxOExJSHhhdFpiNmViT1pMRzdKVlhtVTE0a3lPK1lGU1JneFh2?=
 =?utf-8?B?ZlBib0p4QzJFTC9tZ1N1RUZpL0hwbnlZV0VSYm1MSEQrZ3NvLzBOMlUvV3Nj?=
 =?utf-8?B?SFRWN3ROVW92eXFtQVlmcXVpQnY5cldHclZzWUk2azlQTHpYRGtkVDc1R0w3?=
 =?utf-8?B?Um5TTmhpQ1VzT1J4NVVocS82UkRHdDNMK1V2RlNacU9remtReUJlMm9WY1lx?=
 =?utf-8?B?OTNxRmlkd2ozdFhyYi9yYnNkMHBWdGMzMG1hMElrKzd1UFJwR3JOQTM2aFBt?=
 =?utf-8?B?WW5ObUNhNlJpQTlvT1V5d1FLbmE3SW5nSDd3Z1R6SjBpbGR1Yk5yWUdTQzYv?=
 =?utf-8?B?aVQ3TzlFd04waWhMVTVjSHNQa0IxN1ZFQVJkUDJud25EV0VQWFZRcDhoWEZl?=
 =?utf-8?B?RjRKY1QwaTVFYzBCNnFJNXhSUmkzaFlKUXl2MnFUVUFudHJTVGZ1UXRQM01r?=
 =?utf-8?B?UEdZWWM2YWM1TmxSdzRvY0w3dXJIWVZUTEtGZGdnSkhwZ1lIQ2crNitMa0x0?=
 =?utf-8?B?YncyakJPVkE5T1Nub3lGbko4WVFERS94QWVReU5UUDM2VGdvV3NYd0w2ZG1E?=
 =?utf-8?B?Z2wrb3ZyUHVMQ2F2c3R0SVBMSTEwaEFTdGd5ZHdTNDdKdlRGdEZVT1VRSC9h?=
 =?utf-8?B?OG5DdUR5NE5Pd3ZFcVZubWxLYytYZXZDd1RGTXZ3TlpkN1dOOU1EcnlKTnhF?=
 =?utf-8?B?cHpUT2Q3b0Fxd0JjYW1mV0JjeTZUVFAzTUhjTWV4RzVwanFjdSsxMXJXQk5N?=
 =?utf-8?B?cmtWNXhTRk5oOXg2SW1zellPbkh2UE9JN0lxSlNLcTh4ZER4dnJmQW8yMTQ4?=
 =?utf-8?B?VWRuT3F0MGdJVGl0aEJ2MzF4bHJnTnUvQ1FndTRIejVhT2hmN3JYeGt3NVpB?=
 =?utf-8?B?K0kxaG5HUVE2MkY5ZnBRc1lyZjVFcC9iZCtYMEhaRm91Vlp5blVNd2trWUwr?=
 =?utf-8?B?NUcyRGxET3JZaVJyOWpyNnZwQVhQRlhzZ2VrUTFUeUwvRWFlNnA0b3cxd3d0?=
 =?utf-8?B?NnlLR0RtaHZZbW8vVExXYVdWRnc3YTBLa0FwdWJOeTNwc0V2YklsUHRCekF5?=
 =?utf-8?B?L3JVSGRmaFYzcXcvNHFHdDJjOS9FUVlETERjSzVPcWoyVUllWVpiMFJpbERL?=
 =?utf-8?B?QXdhbGQ1OVJzOStMQnowTVovUkZBMWJjZFdqTVNQYjdETk9vdGFlZno2SU1m?=
 =?utf-8?B?ZnAvZkNRL0VQYWcwUFRETXc1UW5EOStWWDYrNEpBM3gvMEFpdWt4VGo4NG1Q?=
 =?utf-8?B?T252ZTliYmNGeTk2OWRPRkhLMlRGNU1zY3BiaDVFcHhYTStBN1RKTGhMeFdl?=
 =?utf-8?B?eFpOb041MC96d21zSVplb3RFTm5JV01mWmU4OHo1QkgrMlZrOE03UmxsZmd4?=
 =?utf-8?B?blE3R3lDVGlvUlk4SzRNTE1qeVdRODZNS0VYOGdIWXd1WVo4UXpXUkhmaTdw?=
 =?utf-8?B?dEhVZmlrYlIwdTlEY1kxQ3JVME9jZmhzYnYyaE5BR1pHSFd5ZlpwUmNlT3BW?=
 =?utf-8?B?NENBdTNpVkNwTmJZWnZCNU9HZHowNmYvUU5tdHA5U3lJME1uYVNNU0pZMmFT?=
 =?utf-8?B?UHorWWlWeWlRSXBIYmZZcHFReGtIeDQwNVAzQ29TN0Jubk5OMUlCdk90T3Bm?=
 =?utf-8?B?OUJGRmNmaituUjROSHU1T2l1dUVHSVY3dWNuZEdid2RvWENaWlJsOWw2ejU0?=
 =?utf-8?B?RExWd3YxaTVsaTlDS1BGazBGTTU1WUo0RnNEOExQTmxHZU8rbE8zMTYrdk1w?=
 =?utf-8?B?NXZKK0ZibXJBdWczR0RLcVRWTkR5NWJ4aTYzV0o4bWxOVFdxOWJmd3NnS1hU?=
 =?utf-8?B?S0lJajJJVVQzanNtRlNrRGg2aXVydGRmUE9QM3ZFOE9TUWt5N2p2dkhYaHl1?=
 =?utf-8?B?KzlaSHF4VmVwd2ljZkczNittRS9Ec3M0YzRSZUw2V3hVR1lXWG5tMkM3VDhF?=
 =?utf-8?B?SFJrL1hGVUtUUlFLQzhqbkF0RGVPVXJVeDA2RkpHV1VhR1gxUlZIdFJ2bHYx?=
 =?utf-8?B?SGNVMFgwT1BuY0N2QnhQYkFxZTRRazlrTk1sek5iSVdBSXBlM0orUFdiSis1?=
 =?utf-8?B?cVRMcHNiQXkxejhhOG03QURXUElaRm45RGZsTGcwc0ZvUEYzelhMOS9MT1Zi?=
 =?utf-8?Q?GSGn/2eDVCzNXeo9g4euzeA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 915ccf8b-9d19-4a5e-12a3-08d9c0b38a10
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:45:59.9342
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v9TWG4s3c0te25PMNq6ezaF2TC/U/RAVpIqBBl6ksa+Js08ssvH/T1wJfY/HXNj4NyTkzfC1dIv/JAqoDQHGWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4787

On 15.12.2021 23:21, Andrew Cooper wrote:
> Specifically, this lets the user opt in to non-default for dom0.
> 
> Collect all dom0 settings together in dom0_{en,dis}able_feat[], and apply it
> to dom0's policy when other tweaks are being made.
> 
> As recalculate_cpuid_policy() is an expensive action, and dom0-cpuid= is
> likely to only be used by the x86 maintainers for development purposes, forgo
> the recalculation in the general case.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:47:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:47:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248104.427920 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtuL-0006V8-2h; Thu, 16 Dec 2021 16:47:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248104.427920; Thu, 16 Dec 2021 16:47:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtuK-0006V1-Vs; Thu, 16 Dec 2021 16:47:04 +0000
Received: by outflank-mailman (input) for mailman id 248104;
 Thu, 16 Dec 2021 16:47:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtuJ-0006RG-Kb
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:47:03 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cb6b4168-5e8f-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:47:02 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-JRrC9mYbPKu7vpmq7wFx4Q-1; Thu, 16 Dec 2021 17:47:01 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB4787.eurprd04.prod.outlook.com (2603:10a6:208:c8::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 16:47:00 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:47:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cb6b4168-5e8f-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639673222;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KnGlSChn3FCFh2+3l9wve+HBR/UW9dbN+wRydJsB8ok=;
	b=AKSHXZYpyRFTOkORMZJZ5jgkGAf0/VIswmNNezUwBlkRrVtn3vce4X/k+pCM8q39EjRMLk
	+Fe20VRMacxt/YqOyI6P2o9zeFsDmCePdfJMds5ne3WG0xCW7RndiYcvh1GtuS9fc/WOy+
	IOq8h+HM12ZZeOH/qyJo8DA7fgHYytI=
X-MC-Unique: JRrC9mYbPKu7vpmq7wFx4Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ImaCDlMh3m7Ma2W/QKo9chBl8TbLMnk4aWrS5H2oVzIhRMPN9B5D7Sr5FJ7jZrh7NoZpC0Ych7wgPgFZ5ZIF3/+BfLO71RXxxcE4DAWzBeQ91/Vqwbnyw6fdkt4D4/UAI9uAwtPUMY+DRbOJwkbF5XxPsG7IergnzQmJA81SZLHTgly1aTWq26BKOJQkAE5VFfthaQOaahF0syrbO/+AEBbVrzC9oE05KFXIstwTAJi1VtsaNksRj9bO1UuLMfJEat6enBgMKNFMcmY+1crroSikuf02rA9vXnC7bHfo5kR6CzyubUOxbG/uwdhz5pmAjJTTe5lMWwEDUofLmgXLzg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YGpcZsPmfXm7FS1GQnBbqGFm0AnbIrTeSIAIwCWe9R0=;
 b=fTpp3cjfvc/ttDe78wghCuz/vutErA3Sw08I+dLFqn5xEWUoeHte0UqZl3RCodNN5vaGqiZRCDCTE2IEt0GV8cWfg+QuSgbhO9yJJvwRh7jB4zwsI6xL0loTCTffOhLG3iOE9UF9mvvkeDpI6nepe6mAwKQeAZSo5eQOmtea3jak15vj1PphrQ9wRcNhQSbR5jfnBaY9cLogbOg3/ehJB1jvMat/Ma+WCPSxRVJXwoT+kQgucUJnWDYOHV4iU86RHtfAyF1ZxB5+RrK6Z8BHc+/jIHlnr4zLyrRwg40b0kT0o0ogoMIRCLLLiORPZEAJEFu5wPNX8hItkWqeNWqXBw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a37ac95c-6756-7ac5-48a0-be7228eb4376@suse.com>
Date: Thu, 16 Dec 2021 17:46:59 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 3/4] x86/cpuid: Introduce dom0-cpuid command line
 option
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-4-andrew.cooper3@citrix.com>
 <948d4e68-5c8d-77c7-7ec1-56908248b185@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <948d4e68-5c8d-77c7-7ec1-56908248b185@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR3P281CA0039.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4a::11) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6d226f10-632d-4c4e-0bac-08d9c0b3ae3e
X-MS-TrafficTypeDiagnostic: AM0PR04MB4787:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB4787D000B5C0ACD01CE0BB78B3779@AM0PR04MB4787.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FUZvKPg9I2DYH0Ax71n3gLrfKaVwxkzrlC6x3CA8Tg3gTImYLgqPuE+SDP+tMVaASy1ik3CsztEI00rkLV0iOVerK3fHZ+G6ZrlhyQ/a4EAjfGLbEh/ZEtQ0yI3nCuCpMoeNPpeSQMv32mDcSWlvBvqkot9B4dQoLZu650iRrwJ0301xjD3UdQdR2/N1IlRsP61jXwev6ISEnU/dZDNERbYFOEOGUUyp9AqbSbwITy07rzJVTKnRRaFbaZVyqXh1gviTfYo5TrcIiPsinsdbWxzR6B7a4j3qHgb2WmhC9WAohXvwMTeMPnth7pSRdWd+W4+5+1H66MUTlBvuRUWIQYn0BZoTKJS4jOJ0cUbsO2/0/UA4ubp9nWoTbqrh3M0oYaJx+woXoXn4e2uByHRRF7zDTo/P52tggZsLBW3ScFMhAyAneBqbQlZC+QehfbrUzVGocZr3qqBudz4ezS/SbZTpOvpwPlgzVq/kgzuYE+0+IoSqOz90yyMOqhRpAlnR/jPLEITZnD7ZTVXwtf5cFFYK6hJgw8evL1Q1Q5QO7ynhgYPWJh11h+/FN22/ab4aQR8uww/zqc6L26fwzpYgTmB/6PznNJ8PpaAIDks1q6YUsaFvW3MYCGgLAvtCarAWuJwinsQjhE+jJkQ+kiXaWpf7GXW9PeFBvRJ20OYUy1muOxOj49831JuuFf0vuqItibmtRB7HJ5eg5awhDV3tsi5k97QBmjHISPh+crsf2UqfeiX/eNFHxNQfhuLmn7+Q
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2906002)(66556008)(316002)(31686004)(31696002)(38100700002)(54906003)(6506007)(53546011)(110136005)(86362001)(6486002)(4326008)(8676002)(36756003)(508600001)(5660300002)(186003)(2616005)(66946007)(6512007)(26005)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LAaMpZOOXooD1bVnAkYbdMwHmwn5tYNrJdoKinRWTMydsdP+E6SlE5h6+nfo?=
 =?us-ascii?Q?qGO3EOspR6TH/jeQwVEOVgV9+wSKNG50d+SYrZPD66F2LCXu3IJX7mXEGtus?=
 =?us-ascii?Q?KQVUfxv0OhFTxt0Fh+0tGoh8I+UIz6CtLFeo+O5pT6Y3S33ouSecGf4pUG45?=
 =?us-ascii?Q?+dcwV/RO/C3cttN7s+rapHZqDSBQX51aSA9cNie+VGEJ+dumBtb/mOPitd7a?=
 =?us-ascii?Q?8iw6kmuBEgaNgMlHnulBSsSix5BaDTtnBj5XS0dKeI2q2TYKcYQPEVYTId+z?=
 =?us-ascii?Q?fQwxdhc4srMSYUX/tss9ye5I9Pxf7prjBRWbTgL28bmTcf5HTlrqp3RLEEpl?=
 =?us-ascii?Q?SuTne4U32kgYkwva5PTWFx1AQtm1iV28lCHcPJzhglVFOjV+vEUCFrBa12ZN?=
 =?us-ascii?Q?WxM3qXBdsjZP/iTCBvLuJHQOh/MyMO0Lb3roSiJSc2N9b7z9rTE4crqZ5yxn?=
 =?us-ascii?Q?xZlLVCVzxCy1Ixe5Rnt05HoZErbPjIBxFpdfdz2P8j8y8E7OoWO0jj4gaQVG?=
 =?us-ascii?Q?gwnD23chGPQxYqEyhqQXIFBm4+OB7bsM08qq5j+HPv5CIhwkFXt2piSYEIIu?=
 =?us-ascii?Q?o6In/mbilV4XNW5zZhPPBE84HhhghoC9hdWgDtPdUT3zgM2xSuTqMrDTaca2?=
 =?us-ascii?Q?L5DmA5kSGbcjmJKCNBmsCzFY6orcdktCsHXQ0GzwfkR5btY3gnUQ43ywgnYo?=
 =?us-ascii?Q?10hi7070mHTm2sLqUBQbH0raJXO0nVFMPQftYmcW20ImAfi5Cn7xWIwbFKDl?=
 =?us-ascii?Q?vIoOzrhUibpK4+/slsTOIRxSdxZ2MnJOtu8XSqspL/rro6zzIFkTw9Lxsvxh?=
 =?us-ascii?Q?XB93hN9CKGpygJH1H1c8iZUrgO0/+kjss3FXJD7WZe7VxSzmdmH+C5kEO/6m?=
 =?us-ascii?Q?gp5DzJB58xjK1qbQFlsMNvCSntvUS7vi3XxhoYDLwM5tJZsp6N9FYtiK/vWJ?=
 =?us-ascii?Q?C42i+7NKDwt/qvWm/Qkph4YKpIRNeC2vH9XPE5w9BSfM/z3+TJ8lDnoN7HpV?=
 =?us-ascii?Q?PKFOMzVnA3maFXL1iRJoGbGgLAnL0uqzUIl6KN//U9Qqd0bRd2IknqxMs8e2?=
 =?us-ascii?Q?kAJg562WcRYQDHSt/akCh2AxHIyN2sJ54F8KR6nXYqjgMGSsWZm1gQKjFkZm?=
 =?us-ascii?Q?AZca0I/RqAHB5H3kdAb8IAIaDfEzBlPq3tXJ5eOddeFG8ezg57R/EMSpO3RY?=
 =?us-ascii?Q?7agR2V2edzD5AHZ85VC0V+WuOMrL4rcjumDdtj4BWthhNwUA17XthU1EjY5r?=
 =?us-ascii?Q?zK2SoZLkG62y407asyVJ0x+4H7LuzQSwyneSd2acxJV6L2qYw3TAQaGBMxIN?=
 =?us-ascii?Q?Sn36ooSNB+dyFlj7iKB4R7pxMt6bVo0tR5SZBGt4X9UEmceTDT5PBW9eXku2?=
 =?us-ascii?Q?yB1Vg2FX1TUakPArZ4wFR4Qo4xXbCzD4tuZ+IRFxPRCHMCH5BIESGFhbuGEn?=
 =?us-ascii?Q?+TNlSW2FVNJZN5aXIKw8K0lNnzH+/m9Kk56Mdl1liR3Q4eLEUEXbGuAHOQGQ?=
 =?us-ascii?Q?ljQqBc8SyhxW34gGyQGPLj4uebyAS+ojaZQKo/Pj7C/W9SSXFsMlos5dPwHu?=
 =?us-ascii?Q?1pCbEqMIwI9ZqbzZePHq4RoIccCEYoivpACpPT35ju9y09nD0VKnuXRqLZ/R?=
 =?us-ascii?Q?Tx+2j+dOphCNCw8PZp6hP1A=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d226f10-632d-4c4e-0bac-08d9c0b3ae3e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:47:00.5710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AWjTaXKc7ZLImMygwDGnFcjr4JJwBdCJOsFnXTpZas5h5p7azOtanjAjO4SOSlDI+M7IVeDKt0GeaEvEc9TycA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4787

On 16.12.2021 12:56, Andrew Cooper wrote:
> On 15/12/2021 22:21, Andrew Cooper wrote:
>> diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
>> index e11f5a3c9a6b..83a80ba6de70 100644
>> --- a/xen/arch/x86/cpuid.c
>> +++ b/xen/arch/x86/cpuid.c
>> @@ -116,6 +116,23 @@ static int __init parse_xen_cpuid(const char *s)
>>  }
>>  custom_param("cpuid", parse_xen_cpuid);
>> =20
>> +static bool __initdata dom0_cpuid_cmdline;
>> +static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
>> +static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
>> +
>> +static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
>> +{
>> +    __set_bit(feat, val ? dom0_enable_feat : dom0_disable_feat);
>=20
> Based on Jan's observation in v1, I've folded this delta in:
>=20
> diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
> index 83a80ba6de70..39baeae9a6cd 100644
> --- a/xen/arch/x86/cpuid.c
> +++ b/xen/arch/x86/cpuid.c
> @@ -122,7 +122,8 @@ static uint32_t __initdata dom0_disable_feat[FSCAPINT=
S];
> =C2=A0
> =C2=A0static void __init _parse_dom0_cpuid(unsigned int feat, bool val)
> =C2=A0{
> -=C2=A0=C2=A0=C2=A0 __set_bit(feat, val ? dom0_enable_feat : dom0_disable=
_feat);
> +=C2=A0=C2=A0=C2=A0 __set_bit=C2=A0 (feat, val ? dom0_enable_feat=C2=A0 :=
 dom0_disable_feat);
> +=C2=A0=C2=A0=C2=A0 __clear_bit(feat, val ? dom0_disable_feat : dom0_enab=
le_feat );
> =C2=A0}

FAOD my R-b applies with this included; I had meant to reply here
but then replied to the original patch.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:47:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:47:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248105.427932 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtuS-0006pR-AJ; Thu, 16 Dec 2021 16:47:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248105.427932; Thu, 16 Dec 2021 16:47:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtuS-0006pK-6r; Thu, 16 Dec 2021 16:47:12 +0000
Received: by outflank-mailman (input) for mailman id 248105;
 Thu, 16 Dec 2021 16:47:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxtuQ-0006RG-Vr
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:47:10 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cef113d7-5e8f-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:47:09 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47092)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxtuO-000sSc-ne (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 16:47:08 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 21BBA1FA9B;
 Thu, 16 Dec 2021 16:47:08 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cef113d7-5e8f-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <430620c8-2181-296f-6fe6-bc83d86114c8@srcf.net>
Date: Thu, 16 Dec 2021 16:47:07 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 2/4] x86/cpuid: Factor common parsing out of
 parse_xen_cpuid()
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-3-andrew.cooper3@citrix.com>
 <49a6035e-9291-7a67-ad78-be6ebde79def@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <49a6035e-9291-7a67-ad78-be6ebde79def@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 16/12/2021 16:41, Jan Beulich wrote:
> On 15.12.2021 23:21, Andrew Cooper wrote:
>> dom0-cpuid= is going to want to reuse the common parsing loop, so factor it
>> out into parse_cpuid().
>>
>> Irritatingly, despite being static const, the features[] array gets duplicated
>> each time parse_cpuid() is inlined.  As it is a large (and ever growing with
>> new CPU features) datastructure, move it to being file scope so all inlines
>> use the same single object.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

>
>> We probably want to be wary of fallout from this pattern elsewhere.  I only
>> noticed it by chance.
> While that sounds at least close to a bug, there might by some subtle reason
> for why they have to do it that way.

Now I've thought about this more, probably C's "every object has a
unique address" rule.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:49:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:49:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248113.427943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtw2-0007iu-Lq; Thu, 16 Dec 2021 16:48:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248113.427943; Thu, 16 Dec 2021 16:48:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtw2-0007in-Ia; Thu, 16 Dec 2021 16:48:50 +0000
Received: by outflank-mailman (input) for mailman id 248113;
 Thu, 16 Dec 2021 16:48:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtw1-0007iE-LL
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:48:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 09b5d842-5e90-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 17:48:47 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-_iyWVJgFOFqjq_uviesjcA-2; Thu, 16 Dec 2021 17:48:46 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB4787.eurprd04.prod.outlook.com (2603:10a6:208:c8::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 16:48:45 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:48:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 09b5d842-5e90-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639673327;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TqfQa9/wCrVuMkcpcsVM8531BUDQnVWVKZxdU3YhBW4=;
	b=XcCf59XG+eoGxrQ3grJbsqfWJO3LkYe6ml587Yhl15jHSeaZK5CjzyqzVomJl++iKqckaj
	FPhq1TKOx5wNOhoi0gRBmz+CqFWGsdFbdPza4Del9VMO06w/GpGJY07yhgFxevcIcDqPxv
	oe/HxcZQ+B02wAPpOzpQvWxHBKNj6eI=
X-MC-Unique: _iyWVJgFOFqjq_uviesjcA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fHpE1GTRSj8cH4AH9tM3bZJZPq2xxJ1k7krHw/nQtL6ia/21V53eILK7EopM55VPCzq7LbtAxDI1GJqsVLFLA3QPVTs+kJr+WVNIBVR19N1FeFx+OSYeinAPCbe1u/9B1rkA/09jvxt1SpbQZW+hnEpLr1Rg0NPBn5jdgA4wPwAEhtP/hA9L8PebDcUb+5ZNMDQfTZwOTByjWkeFIIMll6hbu0b02hBD7mznttfzP0heZ+9rqtetZBuA6Dfx8BcXlHziJx03x1mVTZvqrOmxPugBBjXh3Z+QuT3spYInBff+lmOUX6UXmWcHqUiFbzYtz8vHay+O3cFL/bAruIlFYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=TqfQa9/wCrVuMkcpcsVM8531BUDQnVWVKZxdU3YhBW4=;
 b=B+bfYG4tTvzBZJR5I8cQnJFQ86Ax6wnIIgSj4Sjh3GyhJ8TCUSBBUU5mvjTA+g3okLfcQtMHa9w0jrHM0DvOnAuxiK7+IUyopeaKsf6mmz73ylQDd+jNxsFBFwNNMe0Gdi6s52KWIZZ0mb/IaM4I8j77QzmOMwm1I14+mOPodcPITmI6vQySFZIHPyclQ7/DOeMWC8BEZr0ER53ftCpzrk+WBiA39ieioFw4scTkA+ITl2/ETnyNs5r0nuwTs0GGQ9JWRKSKE0MnaUZCwUM0LiT+pSPZ2LLwwbD8NCAcaui+SfIj4oOoleEUcX3li/X1h4HWNk1VRtWYCAH1tHEJFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <aa22681b-4cd8-4cc2-109b-53fda66c4946@suse.com>
Date: Thu, 16 Dec 2021 17:48:43 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 4/4] x86/cpuid: Advertise SERIALIZE by default to
 guests
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211215222115.6829-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0103.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::44) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 86159d57-8d0b-4c85-0282-08d9c0b3ec71
X-MS-TrafficTypeDiagnostic: AM0PR04MB4787:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB478737C76D8D64CE6D097900B3779@AM0PR04MB4787.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	IccCePtwVg6sMImpmPF3of+Q17SxMyAM6t3vO8LgpWjMG9nh7FbNYeibysxJN9LIevvOdmQ3NcBAGV2gLnIWTWdkPp3UW0eSERYjl4Bv1EXpzviHfSSZwDY1NRvBCiq5Zm2zjHdzjWpEOAQXSof3nHiVk3YsSMLjUcWaR3+qjGU5otJWGRE4wEtGQbWdtg+XT0HTLfQJlK04ZJXyUAgQToFaszKmJ8YsPqAKGEXJ85qCnUIcPARoahF7jKOFNxrzrsjc9ebkUav7LClNG4HXPxWQ2MAaoA60iD6kSmBAMKm5qnGuvfyR0Jc+IIaTCEYBGKGMgWvkzO1UbgTKPBRm0AAcLNodp2P7z5jzUzOW7ryH2+ldZ45J8dmZonkxMxGfFQtpFy45/U4rnfa3AipwueuPDd2gu5sHvI4NHKTa18CIZ6LZuEFUhkEKjAr6wRYtj2SQopHO/SOvcO0P0ci3/HDkYSg9dqC7350wqS+4YxEdap07e9fCgjrzyh67GxWOhQdIFXTj5rlOh/BbzmNMCiXphKDtI9L72bYdjVo23aLCxlpCccoZCFaOwh47Rvx9+ThoaxXDe8AnRs7Q/7ybb0ni3bIVeUB5g+sT5yTODzDdp/mzbEqMYC/zXAi10t6CX8yLxc6zOVaceD1BDzmbrYsserXq6s4rnMMgT43AFnK5BIGp6DqzOm23jynb335EpIIVgnF0TdNHdGTGo7uP/vNa/2rbBD5FodvNjZPFVJ2+OAcRH6OitB7/YBncLcs3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(2906002)(66556008)(316002)(31686004)(31696002)(38100700002)(6916009)(54906003)(6506007)(53546011)(86362001)(6486002)(4326008)(83380400001)(8676002)(36756003)(508600001)(5660300002)(186003)(2616005)(66946007)(6512007)(26005)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bFBBV3k2TFZtdHE3YnB2dEp2YVVYeU8wTm5OTlZuUEc0T2VFNGgzOWxuRVU4?=
 =?utf-8?B?VDdXWHY5K01id0dHblNYZ01JMXZacEptK2ExTlEyN29MOFA3VjN3eVhvaWd4?=
 =?utf-8?B?QVhuSGlPU3NUNWwxQTJNZUFxeTJTRkp3K2Z6a1NzcUR6ZUJrdE44TGJNclhq?=
 =?utf-8?B?dUdBNU9raDE5ditEaHdHL0R3bStDWi9NSjI3SytjbGtzeHI5TUVNbUsxdWRE?=
 =?utf-8?B?QmxKaGJlWXdDejZyODN6d0hNcktBLzVaUC9RdUE3N1pXa3hhNlE2WjMwUUp5?=
 =?utf-8?B?ZEhaak9IZVhrVGZ6MG5Sc2cyaHJXQWpPdktGdWlaUmdubUd5UjZZb1FGRGpW?=
 =?utf-8?B?YmJwMktHMmZhcFQ3c3ptaTV2Y3lEY0pRa0hYVDRLeUpUNTA3U3czM0dqSWpK?=
 =?utf-8?B?WEh2Z0xjMldpMFU4N1VqS0cxUTIyMDc1UmRTWk1RS3ZyTlNTZFhXSkpPT1ZF?=
 =?utf-8?B?QnpWdVgxdUY0b2Z4RzhzTlJueDZVMVYwTTVESE1LcFRxbzlLcEFEd2xkajNM?=
 =?utf-8?B?VWdHbFZxNHNMbVZZQWdpMTJ3Z3MxVVRINzUzaThJeDdvMDBLako1ZzdtVUlV?=
 =?utf-8?B?aTJCOFRodE1adHlNaHZPOWtOLzZ3OHd0ZlgrTGdhWCtpajJ4Z0grVUhqUVBV?=
 =?utf-8?B?Z0VYcUJsZndudStGdGJvUnlyWTBLVUgxM0ZMZU9zTUk4MHJEU0lnajRxVzJu?=
 =?utf-8?B?czUzajQveTF3VHV2RkQvQ1NoSG1ENllJV3ZUbUxkc3RtdFZBRVd5WkFGcDhy?=
 =?utf-8?B?Z29IWDAzMi9TdjhzZXJoWXpCb1VwWHJCUlZyQ3Vmem5yeVp2cFlPZlNhWlBK?=
 =?utf-8?B?eWlMV1hXV3B4WGtvc2dFQmVBdldIUUVOYm1tcis4ZW4vMkRoK3VrT0tzVnQ0?=
 =?utf-8?B?cG93blQwYVNIMCs5akdGQ2FQR0dxdVk1OFdwRzN5ekkrTjNBVTJJNk5KOEpk?=
 =?utf-8?B?WWRtWVZxWFkrY0NCbnplT0NTT0JWRDk2MVVUTzRscG41SzQ0aTU4VGx1M3JP?=
 =?utf-8?B?cWphemtvUzFDRkFYc0JCdGtqZkFiVUQ1ekJmcmMydU1QZnZQb2FKbmpqMWJz?=
 =?utf-8?B?Wktzdnp2bGc4ckZORFpSTEYyT1U3TW9GVXUxRWNNU0VtN3ZQU1pEeFNFMnQ2?=
 =?utf-8?B?Q3JCNytGa2owMUJ1UkZTSGtIaDVjQlpIWDd2U3dxNng5Qk9zS3F0WGU1V1kw?=
 =?utf-8?B?QnVKOVFpWGdkb05NTEpVNWVaRTNoZXdOZ2NRQzU4T3Y2a1lnb0YxV2lMc3Ro?=
 =?utf-8?B?L3l0UGg2T2xTWFBjKzFqYUxnMElqZGYyY1ptVEI2TUFPYXRlOXR3MkQ2eHZ0?=
 =?utf-8?B?cThIY0UrOU5Qb01UZExYQ1V3alZzbjh1YzFyZU1EeUdtZXdGTW01WkJhMjVC?=
 =?utf-8?B?UDg2N1RYbjNkSExENmxyVVZNSFRHMDZoNS9RbGxQTWRlMVl4QlJEYjlpNURN?=
 =?utf-8?B?amQzTis3UXZQUHozVjV5bXFzZ0E3akpKbWlJblk1OExoQzM0bVQ2OEhOVkht?=
 =?utf-8?B?dFFZV2czRTcvMVEwVUk4YTF4aEFYenZadjlJY1RyNTF5Vkhmdld4K292Nkty?=
 =?utf-8?B?RTdMMEFTVVpaV1IyVDZ2d3MxRnlaZUF3enIxalhDMGNmYkF4Um04RmRvNlA0?=
 =?utf-8?B?UEtxYW45Ui9sZmtkZ0J4MGVuNkx6eHk3UjYxYUdjNGhjRENGSWpmZjJhTGlC?=
 =?utf-8?B?WEhoQk1HY0UxZ1VsejFHRVV3akl6OXFzd1NjeXRLWWwxdnhyakQreU9OR2V0?=
 =?utf-8?B?UlRBRENPUmJRRFREVmZTcXgvZ09PclZmdVhVb01JMTRwUFpmalJ2TnhpOUFI?=
 =?utf-8?B?Rys5M2xMMnNtLzFwMGhwbHVqeVY4bVFjK3R4R3UrNzVqdGcxNkZSSlNSMStz?=
 =?utf-8?B?WE10SlRaN2krdDYrRERFR3J3ZGs2djZ6Rys2Q0R0S3NoV1dFZE5RUnNHSmNh?=
 =?utf-8?B?bkg1ZE0vY1BnZFFBZG9TODZnUUw2OHFvbENqeGpPcnBYZDlhMUg0N2tJRDlj?=
 =?utf-8?B?UC9YL095SHNKMkkrOGJ3MVpsWTRWRjRwandJNmFQWGZGVnZzVEpkSDZqbS9X?=
 =?utf-8?B?a0RhM0oxMHNPaWlGSkZKMXhBQ0FNOG9HSU9yVE5zZ3NYQ1FLUENwcUV1a2FR?=
 =?utf-8?B?NzlhYUg5M3JpakpLZVhEZCtqeklCOFhsaVVVa2lIcVNZUlQwMVc3STRLZExH?=
 =?utf-8?Q?730/coRflTq9CZo2d77l/3s=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86159d57-8d0b-4c85-0282-08d9c0b3ec71
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:48:44.9237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cx2s1cDFutFKKX7avH6Cpm5szMGzHm9A+eO7pXl8PakUoBnwR5ddLpGWy9KjPXtCK3phMPibMQ5SqkbatkQMSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4787

On 15.12.2021 23:21, Andrew Cooper wrote:
> I've played with SERIALIZE, TSXLDTRK, MOVDIRI and MOVDIR64 on real hardware,
> and they all seem fine, including emulation support.
> 
> SERIALIZE exists specifically to have a userspace usable serialising operation
> without other side effects.  (The only other two choices are CPUID which is a
> VMExit under virt and clobbers 4 registers, and IRET-to-self which very slow
> and consumes content from the stack.)
> 
> TSXLDTRK is a niche TSX feature, and TSX itself is niche outside of demos of
> speculative sidechannels.  Leave the feature opt-in until a usecase is found,
> in an effort to preempt the multiple person years of effort it has taken to
> mop up TSX issues impacting every processor line.
> 
> MOVDIRI and MOVDIR64 are harder to judge.  They're architectural building
> blocks towards ENQCMD{,S} without obvious usecases on their own.  They're of
> no use to domains without PCI devices, so leave them opt-in for now.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:52:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:52:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248124.427953 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtz5-0000x5-8N; Thu, 16 Dec 2021 16:51:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248124.427953; Thu, 16 Dec 2021 16:51:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxtz5-0000wy-5N; Thu, 16 Dec 2021 16:51:59 +0000
Received: by outflank-mailman (input) for mailman id 248124;
 Thu, 16 Dec 2021 16:51:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=VxGf=RB=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mxtz4-0000ws-3t
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:51:58 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7abbaa36-5e90-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 17:51:57 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-7AQEfiK9OHiglFBUQAi8fg-1; Thu, 16 Dec 2021 17:51:55 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (20.178.117.140) by
 AM0PR04MB5425.eurprd04.prod.outlook.com (20.178.113.155) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14; Thu, 16 Dec 2021 16:51:54 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 16:51:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7abbaa36-5e90-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639673516;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=vuaUmAsGB003oqz4ptURcvIftIaj6wHZf1eZY5oO/aU=;
	b=fCThSMgEfEZn3HMHOpV3qf56BHmbQIIm14yBiYK0uOQrtJjbxybjfS9W5Q1DlwgHFniVro
	0RfFEnwoNZg4SKWq0pnMSD8KfbZdrpLoDkLlQuNWUkW0hSLX227ByR3ZunczHYCW/72BiB
	JcjPuHW3H4FagWTfEvW/PpUwzXa4KEM=
X-MC-Unique: 7AQEfiK9OHiglFBUQAi8fg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=T0ndosO4lWNpgfcJFQWnkwg8DaTAwbO5U3avPgo6ceAUZwqYaJJ5gDnCjrDiRH6Sa8p1BN1M3qaVs3FrKUaTW9LDdghiw7eake4kvKMIlZAY0HJi94Hn3lzr4awWJPEXVqM3000XAS5oG8+KGL4938y35feoyNRVP8zdTSQeAHp3qafzMvCYb5Nhnx/kfueGfSPebk/CGGxU8P3Ur2mKngjp2ivomXZ2K7eMRPv/cPQzVeo+H0EhjPtyu9awpHrAX4ND1XBqYJBb9+YNmSh+raT2BdQVUMTC9UfhVt83x2OAlLWPw9Qpo0u5gW2arGyAjAywYEmtadzsGtO8LFDqHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=0Q9OXD/V6ENbTcfIZntNoC/5RQhsoM1AKICGpX+iqrM=;
 b=lCAhNU2SJWz6wd87kk2bcB1K33V6mX5VfB2IMKCHECkv4NwmTjI8rhNQPIAQdLNU+NP3MxzuzHNz9l/L9g3PIZrJ3/zRTHK4NO6jq2vAJJy5PNczxUsm2smt+IUjC15TXhaOJcBlS1Qqw41galh5v6DkQUoddF1cvZKPBob1D+6rUf5T8LoMrzk1LMUd1vTWtCUk/L67PFh+GAMUyE4qbDavRAg8sBqpdGQLpD2J8KlQlglLR7sxSrYQvjsAa07Ig6c0L2eGXQ0crR/ttITjN4HJ13sLAGN55GxR+7HJKVIV8Y+z9l/m/U3mtGLgQkqqFtFosbqbTsKdbqGjuJ0c9g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <df85e82a-1b9c-7d1b-1574-ae3ebd11a101@suse.com>
Date: Thu, 16 Dec 2021 17:51:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of
 init_domain_cpuid_policy()
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>, Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-2-andrew.cooper3@citrix.com>
 <b95bc243-c4ca-824f-1812-1f0a74e22193@suse.com>
 <8e648c7b-33a6-642c-e4ff-78f17a35dbe3@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <8e648c7b-33a6-642c-e4ff-78f17a35dbe3@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR04CA0039.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::33) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 5ea09e4f-9f0c-43d0-e552-08d9c0b45d32
X-MS-TrafficTypeDiagnostic: AM0PR04MB5425:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB5425A08DF0FD8574C34A3242B3779@AM0PR04MB5425.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dI2C8pmNGfd0ztfv0R5OsYXNprIK3wxExJ+ZuoceE6HOAQUpPPgNuMbQW9bS7wyI8NiYbHfauKP6wsDJCOUhuXENsX36Iv6YU3GwL3tq+2W0yzd/dHrxX+eg5Z/mA4lsF3xxfAB+bbFD/FcB/G2zllYsIRVwSzlvDzz+e32c9ECAv+r3WQDtVw1ry7TfU2PRv0UighD2K1WTJj/FTs2TG803ReAZSnSZgW/XQmS5EytWdpAC6azqWqXglKJFQmEi2NeibAwcpYyOQS37jk+qff9kHnFgdv5rmfl5YZ2tE1E1knkLOQbpfPGJ1ZpUuH3LLaKlp2sEGFoSH6pPbBz5P5nsZIB6ClrUF+rPDqTcIo+Wafhj4+jzTHV6HUKtzK2958vNkC0rfWOmbqJlVBhyt1mauk85ryfMQ4NdIpHAF75m4PmgmNvojDS+tFFUumFevlqVgHgMxxazRSL/Mj8cDX2kVmXyWuugui2AbfqMc4AQjlqNG+ttnyTYYNRIeJtOip7ACagowkyHtCUkmacj+/5W8Sgj1ZBg/odJKccdrXuixrQXU0WW5x9nBTFqeMLPQ6q3zEC3x9kflS14fQMfVUXMOUdULfrJxlFsBD8N/2ZXgs272VdDvKVFl4K4K9CIw8FJsUORrlK5vvRyKgkz789NfnInVaWzGD61ZGs8qNEoRz6Cg2Bg/A5rkFfY6r0eSANcPmdDbGtdnlyYj2gT5tbqANVHPjT21bYQJ3Cdb3HK/ndJsWYN4mdyExxF8JsB
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(186003)(38100700002)(66556008)(316002)(31696002)(6512007)(31686004)(86362001)(26005)(2906002)(36756003)(5660300002)(4326008)(6506007)(8936002)(110136005)(54906003)(6486002)(8676002)(66946007)(2616005)(53546011)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?R8LSTXnx8rbj8lfq4qoaUXveip+JYcbFkSbXxoez9calcpC43vyz6PbrJIu0?=
 =?us-ascii?Q?NPz89ayS4BiSFrCqt+O5+nL5WPGds3r6754XEGhjS4p14YCT1k3K/9wxWkXx?=
 =?us-ascii?Q?KpX7Mec8sAmXspWGghGzh7K8kXf2aQgaV1aA/NXTPWEKNOurSfOy6/bla5a2?=
 =?us-ascii?Q?0spxsFwkYXlwET5rL9l2r7Q3FLjwfasqiJEPjPzRcVXCJWu3dsybxSmNI+ss?=
 =?us-ascii?Q?c4I8oD+OjxsG97UDpVUVRKzA4DPXAobDEg1jVj30UgNZixc7QEJuM7sKd8oA?=
 =?us-ascii?Q?76L0QX9lH76kNtdTMQQkGJij0Wr1dQyi90UrKWgFjBK5ceD8O+2kjVOSm8RU?=
 =?us-ascii?Q?lQz4G4Cvy5spMKgZU5mY/3tzN+utHitJ/KZ0XTB2RsQcXaUrtEnNWlMkdyiP?=
 =?us-ascii?Q?7d1Q0jBGUSX9Mc3AutEpAB+iYcV302VFZiz+GmFF+2M2tAOXvrtKVAdH2pSR?=
 =?us-ascii?Q?GIU2K6Q67k0brftHe9cajl94oh1OmMHxK5YOyNDc28ZIEOEwkYfXIAYdRZQ+?=
 =?us-ascii?Q?TvFBb3CJ7D3aca7VWm3yr9W8YPKZHmOXuuwPzuCJ7JTpEg4tpCvorYJOrjJb?=
 =?us-ascii?Q?lybHdzzPB/htHc7eNnnxP5pS44qkAjSQQeT9rVGXpdwba+MMSEsdI8weBwlX?=
 =?us-ascii?Q?9jNOsXZQu/M/PKMRRbT6LWLZqKgVqPdedRWB1x8640crpqadt2ZfK8psUVwo?=
 =?us-ascii?Q?jIV7JPjrRQSz5fCM60+8VHzivsf60BNGBrkflrQNZlvWFixl2o+JpomdyR66?=
 =?us-ascii?Q?HUPBHIYOoPXSL6O0mDwDDyZQUfRXff88eI9O7iiOhlo5cIVv2vuNg0SQfc+V?=
 =?us-ascii?Q?PQyMdz3McojOXDODxMlakHmzWvePzR24+ZIxVSP4ZvQ37AaJhuUeTikbf34q?=
 =?us-ascii?Q?gnHEDfAak5cCaqClivtdlK+VFf1AUsstswqLo7n8d+yLQcdby6ao4TmUwgvU?=
 =?us-ascii?Q?t8AVwpmEkUzn27etb2s2Kclhoz8G0mP2BjoWQKjz6cLmyIvwwzjD9zeGkO9C?=
 =?us-ascii?Q?L7JL9SYGj1sxdbnLzOPRI6oFKwtyQyP8I0xHRMwU8jnJq3PU/jaMIcmPL920?=
 =?us-ascii?Q?aBtyZCyAZ6itk09bbq20pTEGr6GO4+AH9sLenKVA939hU9p0WEvZ42ibiNG9?=
 =?us-ascii?Q?gEu4mWuQz6WhHYBUnbduKsOoTt+PhZfKRI3fvc8sD2VAZHRo0OssU25dp6oB?=
 =?us-ascii?Q?fsFa2RRzRAfXeFUSzXPupheIr7DHm9jVnnUo2SCF9elbR2wNXL3S0aMoD5oF?=
 =?us-ascii?Q?xnAORZTLXyYLhSUtOvRQmH68dB1apG6HrE89fFqRVYRkIJi73GY95E6Q7uxm?=
 =?us-ascii?Q?MAjsBEYVwt/8dhlRHXr6lBQp/wRhlQ8/QwMKabc1d7SqHZAgrOzxUyqIKJGW?=
 =?us-ascii?Q?sEk7wqQrJVgxDXMT17vsvL8ndcdWHn5ok8LWs6+252XbsE/wjvyTCOwrgX7G?=
 =?us-ascii?Q?LjvmZyJkY4WzvUeLP2WPvWr+gPFHlLWLVPfIpqO7OEj7xliDpWrfA2GoSwyI?=
 =?us-ascii?Q?wof19eVyn8YorFrnpamZHvWtEcoDTndmgR+0tYa+uUriTt4dDktR0a769iHe?=
 =?us-ascii?Q?A5/HcJ86eBU4jmkBMwEUZlp4imYQSDVJroaDy0+UY7GCmYDQvzbl8eF7rgJF?=
 =?us-ascii?Q?CRZKdpDEYp4ujXX3+iLJVWI=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea09e4f-9f0c-43d0-e552-08d9c0b45d32
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 16:51:54.0992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rXklzGJQhR8gjAXMLGMKTXgriAQoR/ggzXFDmlamJY8AB0U409vvcAxGLhJq3lzmeP2I+lNxgVJ01URvq7VqvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5425

On 16.12.2021 17:41, Andrew Cooper wrote:
> On 16/12/2021 16:38, Jan Beulich wrote:
>> On 15.12.2021 23:21, Andrew Cooper wrote:
>>> To implement dom0-cpuid=3D support, the special cases would need extend=
ing.
>>> However there is already a problem with late hwdom where the special ca=
ses
>>> override toolstack settings, which is unintended and poor behaviour.
>>>
>>> Introduce a new init_dom0_cpuid_policy() for the purpose, moving the IT=
SC and
>>> ARCH_CAPS logic.  The is_hardware_domain() can be dropped, and for now =
there
>>> is no need to rerun recalculate_cpuid_policy(); this is a relatively ex=
pensive
>>> operation, and will become more-so over time.
>> Would you mind leaving it there in a commented out form, hinting at when
>> it may need re-enabling?
>=20
> Leave what?=C2=A0 The recalculate_cpuid_policy()?=C2=A0 That comes back i=
n later
> in the series.

I've meanwhile spotted it, yes. Let's hope its conditional invocation
there makes clear enough that with certain other changes it may also
be needed.

Jan



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 16:54:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 16:54:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248129.427964 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxu1Y-0001YH-MJ; Thu, 16 Dec 2021 16:54:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248129.427964; Thu, 16 Dec 2021 16:54:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxu1Y-0001YA-Ig; Thu, 16 Dec 2021 16:54:32 +0000
Received: by outflank-mailman (input) for mailman id 248129;
 Thu, 16 Dec 2021 16:54:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxu1X-0001Y4-If
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 16:54:31 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d5632107-5e90-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 17:54:30 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47098)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxu1U-000vc3-pF (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 16:54:28 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id B236A1FB36;
 Thu, 16 Dec 2021 16:54:28 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d5632107-5e90-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <f10d4a12-c6fd-fa46-d00d-8c39ecddde7e@srcf.net>
Date: Thu, 16 Dec 2021 16:54:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/4] x86/cpuid: Split dom0 handling out of
 init_domain_cpuid_policy()
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211215222115.6829-1-andrew.cooper3@citrix.com>
 <20211215222115.6829-2-andrew.cooper3@citrix.com>
 <b95bc243-c4ca-824f-1812-1f0a74e22193@suse.com>
 <8e648c7b-33a6-642c-e4ff-78f17a35dbe3@srcf.net>
 <df85e82a-1b9c-7d1b-1574-ae3ebd11a101@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <df85e82a-1b9c-7d1b-1574-ae3ebd11a101@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 16:51, Jan Beulich wrote:
> On 16.12.2021 17:41, Andrew Cooper wrote:
>> On 16/12/2021 16:38, Jan Beulich wrote:
>>> On 15.12.2021 23:21, Andrew Cooper wrote:
>>>> To implement dom0-cpuid= support, the special cases would need extending.
>>>> However there is already a problem with late hwdom where the special cases
>>>> override toolstack settings, which is unintended and poor behaviour.
>>>>
>>>> Introduce a new init_dom0_cpuid_policy() for the purpose, moving the ITSC and
>>>> ARCH_CAPS logic.  The is_hardware_domain() can be dropped, and for now there
>>>> is no need to rerun recalculate_cpuid_policy(); this is a relatively expensive
>>>> operation, and will become more-so over time.
>>> Would you mind leaving it there in a commented out form, hinting at when
>>> it may need re-enabling?
>> Leave what?  The recalculate_cpuid_policy()?  That comes back in later
>> in the series.
> I've meanwhile spotted it, yes. Let's hope its conditional invocation
> there makes clear enough that with certain other changes it may also
> be needed.

In reality, I expect ITSC never to need a recalc, and ARCH_CAPS is going
to turn into not-a-special-case just as soon as I can possibly make it
happen.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:16:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:16:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248134.427976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuMW-0004I5-Ew; Thu, 16 Dec 2021 17:16:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248134.427976; Thu, 16 Dec 2021 17:16:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuMW-0004Hy-BY; Thu, 16 Dec 2021 17:16:12 +0000
Received: by outflank-mailman (input) for mailman id 248134;
 Thu, 16 Dec 2021 17:16:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxuMU-0004Hs-Ke
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:16:10 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id dada93bf-5e93-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 18:16:07 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43416)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxuMP-000Eiw-98 (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 17:16:05 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 88E1C1FAC8;
 Thu, 16 Dec 2021 17:16:05 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dada93bf-5e93-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <6af001a9-75a2-2992-59ea-170af8d1627e@srcf.net>
Date: Thu, 16 Dec 2021 17:16:05 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 19/57] tools/configure.ac: Create ZLIB_LIBS and
 ZLIB_CFLAGS
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-20-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-20-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
> index 8f5f3acd21..1f4b7f7c58 100644
> --- a/tools/libs/guest/Makefile
> +++ b/tools/libs/guest/Makefile
> @@ -103,8 +102,7 @@ NO_HEADERS_CHK := y
>  
>  include $(XEN_ROOT)/tools/libs/libs.mk
>  
> -libxenguest.so.$(MAJOR).$(MINOR): COMPRESSION_LIBS = $(filter -l%,$(zlib-options))
> -libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
> +libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(ZLIB_LIBS) -lz

Looking ZLIB vs the other compression libs, shouldn't -lz be inside
$(ZLIB_LIBS) ?

Also, shouldn't this be LDLIBS rather than APPEND_LDFLAGS ?

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:19:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:19:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248138.427987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuPc-00055X-V9; Thu, 16 Dec 2021 17:19:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248138.427987; Thu, 16 Dec 2021 17:19:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuPc-00055Q-Qe; Thu, 16 Dec 2021 17:19:24 +0000
Received: by outflank-mailman (input) for mailman id 248138;
 Thu, 16 Dec 2021 17:19:24 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxuPc-00055K-4K
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:19:24 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f95723c-5e94-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 18:19:22 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47108)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxuPZ-0002v8-p9 (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 17:19:21 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 798E01FAC8;
 Thu, 16 Dec 2021 17:19:21 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f95723c-5e94-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <9cd576e2-956d-a61f-f840-d1dcdfdae2a6@srcf.net>
Date: Thu, 16 Dec 2021 17:19:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-37-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Regroup *FLAGS together, use $(LDLIBS).
>
> Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't
> decribe how to link to a potential libxenstored.so, instead add the
> value to $(LDLIBS) of xenstored.
>
> Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).
>
> Remove the "-I." from $(CFLAGS), it shouldn't be needed.
>
> Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
> in $(CFLAGS) and both aren't used anyway.
>
> Rename ALL_TARGETS to TARGETS.
> Only add programmes we want to build in $(TARGETS), not phony-targets
> (replace "clients").
>
> Store all `xenstored` objs into $(XENSTORED_OBJS-y).
>
> Replace one $< by $^ even if there's only one dependency,
> (xenstore-control).
>
> clean: "init-xenstore-domain" isn't built here, so stop trying to
> remove it, remove $(TARGETS).

"isn't built here any more".  It was, until c/s 89bf86d1eb4a4

I'll tweak on commit.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:23:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:23:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248144.427997 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuTq-0006UG-Du; Thu, 16 Dec 2021 17:23:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248144.427997; Thu, 16 Dec 2021 17:23:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuTq-0006U9-B2; Thu, 16 Dec 2021 17:23:46 +0000
Received: by outflank-mailman (input) for mailman id 248144;
 Thu, 16 Dec 2021 17:23:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=VBzi=RB=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mxuTo-0006U3-Qx
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:23:44 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ead23690-5e94-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 18:23:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ead23690-5e94-11ec-85d3-df6b77346a89
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639675422;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ih3MOpW/yCW+x5F+uZuuVRHaDZ9exo66WfrPCFsrhAY=;
	b=OMVjennJ3dIFrwVfMs8MzDcb41Xr30oKty6fkqZ9/dg2KPX2j01Itd6kvCYu1225sOnYuo
	IeaHw/JoJkXrtGr3oWwJMzzEwGmbkJFG3vgu9mNytV1jkcv4dag6oBGHon+mbf9Ogyak6J
	JF0hQ4F7JA1yDzHNDLmTJM8en1l9nh0l4RtyKkhJNdGp1qF+PkIKoY49IEUHTkOsVif77X
	EDZmJYVvTSc9g7y9TRGoIHjKz9B63drgsnnIlXTKDk1IKqeYDrXtl+Qq6LpiQy1hqLdDie
	mG/yWvrQXdNGXa7j6B8oNi6M8Sbe5B02MnwHdqWu6fekNoxcotWWNW+EPmJPkg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639675422;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Ih3MOpW/yCW+x5F+uZuuVRHaDZ9exo66WfrPCFsrhAY=;
	b=KLmanqyVLTn1a9p7GzpJVoRlRAGdDGqehRu/zZHojbSx8/zpp5uAkFxpqxeluTK3IDEpyQ
	hmWFXp91ZBiOKlBQ==
To: Nishanth Menon <nm@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Tero Kristo <kristo@kernel.org>, Santosh
 Shilimkar <ssantosh@kernel.org>, linux-arm-kernel@lists.infradead.org,
 Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org, Mark Rutland
 <mark.rutland@arm.com>, Will Deacon <will@kernel.org>, Robin Murphy
 <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>,
 iommu@lists.linux-foundation.org, Jassi Brar <jassisinghbrar@gmail.com>,
 Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan Kaya <okaya@kernel.org>,
 linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [patch V3 00/35] genirq/msi, PCI/MSI: Spring cleaning - Part 2
In-Reply-To: <20211216014527.5d3sqs2klrqjmm2k@lunacy>
References: <20211213182958.ytj4m6gsg35u77cv@detonator>
 <87fsqvttfv.ffs@tglx> <20211214162247.ocjm7ihg5oi7uiuv@slider>
 <87wnk7rvnz.ffs@tglx> <87tufbrudl.ffs@tglx> <87mtl3rli1.ffs@tglx>
 <20211214205626.lrnddha6bd6d6es5@possibly> <87h7basx36.ffs@tglx>
 <87zgp1rge4.ffs@tglx> <87wnk5rfkt.ffs@tglx>
 <20211216014527.5d3sqs2klrqjmm2k@lunacy>
Date: Thu, 16 Dec 2021 18:23:41 +0100
Message-ID: <87wnk4cvky.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

Nishanth,

On Wed, Dec 15 2021 at 19:45, Nishanth Menon wrote:
> On 17:35-20211215, Thomas Gleixner wrote:
> Thanks once again for your help. Hope we can roll in the fixes for
> part3.

Sure, it's only the one-liner for ti sci. Got it folded already.

Thanks for your help and testing!

       tglx


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:24:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:24:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248147.428009 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuUF-0006zP-NG; Thu, 16 Dec 2021 17:24:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248147.428009; Thu, 16 Dec 2021 17:24:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuUF-0006zI-KE; Thu, 16 Dec 2021 17:24:11 +0000
Received: by outflank-mailman (input) for mailman id 248147;
 Thu, 16 Dec 2021 17:24:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Da8C=RB=epam.com=prvs=2984c96734=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mxuUE-0006U3-28
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:24:10 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f9857ab2-5e94-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 18:24:08 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BGGcpYT003956;
 Thu, 16 Dec 2021 17:23:58 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d03vjsec3-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 16 Dec 2021 17:23:58 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7981.eurprd03.prod.outlook.com (2603:10a6:102:21b::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 17:23:54 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%5]) with mapi id 15.20.4801.014; Thu, 16 Dec 2021
 17:23:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f9857ab2-5e94-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=COMXH+sHUPrDxXWJol9l5ENFBPLyvGN5YlGkZxxmDygOj0pQ2bzMbCrvr9ckJAuGamchxZC9AUDy6H5d5uZZ5/0/ycJ4iE9W4DlXitIv9gY0ok6eVUzbHz20AACt3iNtArG0tXkw4ebU6klDVcskS+W+oBD8OGqFt7IXNjJuquHHuSzZ6G+rKYo2JOZ0ekSjKPBRLsW3YXIgLNKtkycV/KkzBA3aMF2v9OH7nFB66E0kjndVrb5A0qeO/zhPToKjlANs2kp+DNBfQACOubkHOxWdIyLbdzKRj6C0NgHhIO2aEeRNOnZgXjHQ3yUXHJ9p5qPTW9FlJzKW9fX549ikEg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AuI2KGAqDErX4MmrWfJBNYCP34DijAEa7Ex8WTqHu8w=;
 b=eYvBth8zQa8HqWIRQfjMkYEyRPIIcfe1Ih0RJHteKbnlzKJLP/u/Lh0iTmDBdynZRdNJbqLGAVDUq1nc72ZwW+vysK75HHQ1C6QfUQuvK4CI4mXWoZKTXNrC25Y10DKiFKumMhSkUhpDDDAnfs3hc11FMf3JwR+p0kXS1ox0o8IGriCM9x/0OIoJy5VOiMONjeJybQykhO5Ih+sKPTbX7qPmGJj2YZjM0Eg7tPo91PSV1I1+k2zRw+Pb5Zj+gmQ3azMj5uFc47x50eNOl02KH6Oidr9DjIJ3vltj4CFef/vJxPjMAEp3zhdbNB1Hzsmq1D6bMtM9fZZJoUj+IBGiVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AuI2KGAqDErX4MmrWfJBNYCP34DijAEa7Ex8WTqHu8w=;
 b=H4CYYKm2yVlyR6+20gVOimT0r3Y0bIf7OgO8IF8ByT0KLJ4wsaoJ9rH87b7yOB3o+GQuwKhY2MvLuypHMaiyik4Tn64mBTzh3D34+QMzTHgjnl1jugiDgrp/X3YtdlmUbzKg+L7K2g6+y195LoOCERApgUm0YDd4wAR279jiXRLDikynSWv1hb2vIZm6l5on0dyLHMMhoE5PhhiN/UDDb+R2TnWu/klh1ZjMH7Ci2u6Y0fNjHfnKHENTBeOSU8fTRns+qH+Btra+ctCsHFc1JBIiIikP8bLRluNUM/GfsOkkX4CecGadIGCiMFuuIVBfimgo9RAql4/ji9D+f2mBLA==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Xen-devel <xen-devel@lists.xenproject.org>,
        Anthony PERARD
	<anthony.perard@citrix.com>,
        Jan Beulich <JBeulich@suse.com>,
        =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>,
        Wei Liu
	<wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
        Julien Grall
	<julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH] xen/build: Fix `make cscope` rune
Thread-Topic: [PATCH] xen/build: Fix `make cscope` rune
Thread-Index: AQHX8l40WACp9tX7JUSJrSNPlqLfbaw1WHYA
Date: Thu, 16 Dec 2021 17:23:54 +0000
Message-ID: <87sfuswjiu.fsf@epam.com>
References: <20211216092014.707-1-andrew.cooper3@citrix.com>
In-Reply-To: <20211216092014.707-1-andrew.cooper3@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6fcb9251-da27-441d-2548-08d9c0b8d5f5
x-ms-traffictypediagnostic: PAXPR03MB7981:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB7981B9993DD7FE5548F34751E6779@PAXPR03MB7981.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2657;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Fc23qjaN3cE8b1Ul27PTNYugT4w0fvussOFENawSk0159lURa/eaIKsKr/TRKq2AmkX/GZDfy8q0OaJzd+0YUmYDJRUYSlEdRZcpl6oe5a0cCfEEkMhW0MtxGqgqa9vAQdDZZq7XUogc+6Ty57Yt/cBH1wK9ua/36G+ZYP9JZopJYkc8qgmmkwOtT/20vXbt1hlNIAEUMvABSaaupb0s0Xe2lzKACST8cRgsMSQZDnz5vhzKcK0ZhujfsOpnv85SBJp7kxhXsmtKD96yrdbbpEjQbtHCkWR330dX76Rmkyy6L+yMwNU0dhs8ouMrKcKFIJSL1wrzPzgNbs3q7X34+2rhMvnozfMEq3kjYoGCKMt28zkWs+Us7KFbLxGg0vVHB5u5K8Hfc/KwXqIg6mQRtDDkWKXFhq8ModLlpcV4uLzyjGvpy3NE4yC7VjQCRr3uINyTOMp1hNBc/DMP0nU65GEHuVJG6h5ADqMAmwofmT3DAX9u9EJawbPF52g5t9Hi+nTcY47vifo7Ic5yfTRM9nEC0QbbF2VQryjq5dQXB9AwwBdJT185PZdDEcUGdxchN3X0DW9nGK0nw4XEvvdm1HHMEwWKjz+/KfXEyiRKusS5gkzRlzUQ+mc/+V16AtSSSbbzZcZAlyGfzo4D/W7by3kuMUNKPkpIhC1Lc77YFvaUg9EtsITHgnaakw16FxoiSAlZle7RdlpmZeht8xt3MkR1081v5YeS7lIqSiwyvPQ=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(71200400001)(86362001)(508600001)(6916009)(76116006)(91956017)(66476007)(64756008)(5660300002)(36756003)(38100700002)(122000001)(6512007)(66556008)(66446008)(66946007)(4326008)(186003)(26005)(55236004)(6486002)(38070700005)(2616005)(83380400001)(54906003)(6506007)(8936002)(2906002)(316002)(81973001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?YWhacDF1blJkVmxycWNDekJmeWxoWFVyUzVNYlNWSE1YMWIvNXpLdHdtcERr?=
 =?utf-8?B?VXBRVmk4SE52aFJrT3RxMlJjQXpmaGJmdTRWelFaQllHYVZyZTNVcnZnMTJn?=
 =?utf-8?B?UEcrVTAzd0pta09kcU9jMnBNUFVEaWVJZUorZEdKRWp3aVVkbEExcFdlamFE?=
 =?utf-8?B?RHpDbVRTVHpJblF1eXFHdWJIOGFJWjBzUDhEeHk2Zks5MDRYbzdKLzMyV2sr?=
 =?utf-8?B?WDBGMXpOVHRQWnJyUG5vUjBwU0pRQllKUENxWmt4dEN2bVVWcjFYZ0FIbXo2?=
 =?utf-8?B?Rk1HSmgvYnNIL0FYbkNBcFpUZEpSNXpGeFNLdWc3Vmw0UnNaL1V1Mk45MUhC?=
 =?utf-8?B?V3Rvbkx6cmQvOTBiZktvcXdCRDBEbm9jdCs1YUQwR0FrUEovMmswdENwZ2xQ?=
 =?utf-8?B?S1M2K1dsTmNtMnp1OEpYa21BczlNUCtqZlUwbW5sYTFZRlVzbW44S0oxZlAz?=
 =?utf-8?B?UG12Q0FjRkZONHM4S0VaQ1gvSWRKK3Iwb3pnL0dnWmZ4aFRVa2QwS1pYSGE5?=
 =?utf-8?B?ZnB2eDBZVlowayt3OXM5K2JDU3NJcUpFelpkT1ZEd3pIUGIxa3dtWitIb1d1?=
 =?utf-8?B?SUtSOUFTL3J1Q2JsRkZQRUhlRVlWVFllTTc2NGRpM0pCODUwSnZFVFdCWUNT?=
 =?utf-8?B?d2JJRk85OGJZNlV1YVNLejBIN3R5a2pMUnc5a1diQWFzbTVibXdpMTd2WkhH?=
 =?utf-8?B?Y0oyUVRoOXBHT01FeWM0MnZVT2RxM0xKcjd0WDBtMkN2NU1XSzA1NFo3Tis3?=
 =?utf-8?B?MmpKaCszeDNOSGUxdXBKWXZpRm42Um1FOHZJdnFaN21HUUs5Y3VwMW1wbEF2?=
 =?utf-8?B?MmFvV1FaeTdvL0sxOVY2SmdGc2NlaGpycDMwUjJzb3lQdTVzU2c2RGdlY1pN?=
 =?utf-8?B?UHFiOUxZY3NKTGFjcEZQRk0wb1NUYVdiTWdNL1FnQlhJQ0VFWGdQdnRIbEMz?=
 =?utf-8?B?T2RaeG9YK1lYaXRIRXVVU0kwMEFjdk5mdXQ4RUtFa3lvWXBSWXRQalJkRGRT?=
 =?utf-8?B?TXJkQU5Rd0YzQnBIZ3BaNnRtUXJTSG44M3h1MkdxaXZjUTllQUJ5OTllbmhw?=
 =?utf-8?B?RG9kbjFZSE83blNNdkJPSTJxODBmWXZQVHhPUWh6YUhnRUJXbGlCclJtbUU2?=
 =?utf-8?B?NDZJOFp4UnUzeWk0Ynh4cW5CVHJIRkl4SEx2b1lJNDVycGNBSkxtejEybThv?=
 =?utf-8?B?QW1YRG9sSWZTRTI4TVJZSm0vdEdqdVh3cWdhY0l2V2VyOURJRHRyTTBJbENv?=
 =?utf-8?B?MGZScWpXbER4bTgzNXNRL2dBc1N1MjhiUU5DdjdhOU5ueU9qTmdWN2VVMVBN?=
 =?utf-8?B?blN5V0svWGtiT1NwRG82N2g5Z3l5d0NCRFBCWVZCN0c0NUVVSGtsa3V6YndG?=
 =?utf-8?B?YzEvS0Z2MjJ1U2ZoVHZQTHl4Z2oxMXhWWXovUmtmZTNzanZ5S3VhMjVyMFpT?=
 =?utf-8?B?UTFUaklBN3B2WjNkZ0xjL3hseXNjam53NHFHNFlZTVU4eWZIN1VDU1RKS25F?=
 =?utf-8?B?R3BlQXZwTmdkbGtWdWJQNmx5L01HV1hiTmtOWnNjbWVoNWxRUHVDWmZEdHZH?=
 =?utf-8?B?SUJIVnNlVW1HbFZIVlNDS1dVaWlpMXgvOER2Rkhsa2FHaFRxdjZxRm1QRFBa?=
 =?utf-8?B?RHgrTlhibXkrV2hLU3Ntd1doUzU4YmVFVnpsT1MrM3dsVEhqVmpMR0E2Z3JB?=
 =?utf-8?B?NVpxZ0dwby9iUE9zWUVsUkFCQ1ZOTGRFQzA0RTRld3J3SmVEK2U5U1ZDZ2hQ?=
 =?utf-8?B?aEtsazUvMzkxbDJkTjhOMWVCOTl3RSsyUjFnd0dVWlRFbldRV2lrVEhqeEF1?=
 =?utf-8?B?bXY0MGpHc1JIV004U3h6bUVkSW1RdU0wWS9IOU8wRndnTzlRays5TDhOaUYv?=
 =?utf-8?B?T3gxQVdENjV6RWI2eSt2R2Q5bkI3M2diMlNsK2dUMGR1T2dWNlFjb1J0RzFa?=
 =?utf-8?B?cmUwNGQ1T0tJYS9RbW1XbHNMQ2dMZENPQ1JqeGc1Sm1QYjBYMWozUEM0RzZL?=
 =?utf-8?B?RlNMVlpkbTZJdU4xSlFCejVBRmlNREZscU5NNzJjYWhaOFhUK0k0ei83VXpE?=
 =?utf-8?B?cjgrNHljN3VzQ1FnSW1peFM5R3BmOFNXcDFMMjdSUUR3c0tUMlNNRHI5Z2hS?=
 =?utf-8?B?VHd1YnJRSEV0anU5RHRWTFJDM0RhQmVTaDlCdDkxWUlpZnFYRmVWa1Z1R1Rv?=
 =?utf-8?B?b3lycXNVSHdWSHFkR3Q4c0h6emptcVo2MUVDTzF2eEt1UkR3cFN4K2FRTkJB?=
 =?utf-8?Q?s1WbGX6rwDOzlAt9qrnX4HVJKuO/bdRQP8JrCrw6aQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <58D90F746CE9E54784953571D4E98188@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fcb9251-da27-441d-2548-08d9c0b8d5f5
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 17:23:54.4983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8CiJu6tg7WWz4BFu6tP2y+p3TLJvNGFBNcWDcMtHTm0Hsaj8ypDPJ6LXon8xoB3hLe1RrqybYvEF4b3O2Lde5NGO9BnyLdfbt+2QuOW1WR8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7981
X-Proofpoint-GUID: 8RHjfh51FKJC0Uzfl0UCXvCJKAjxks-Z
X-Proofpoint-ORIG-GUID: 8RHjfh51FKJC0Uzfl0UCXvCJKAjxks-Z
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-16_05,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1011
 mlxscore=0 impostorscore=0 priorityscore=1501 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160097

DQpIaSBBbmRyZXcsDQoNCkFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+
IHdyaXRlczoNCg0KPiBUaGVyZSBhcmUgdHdvIHByb2JsZW1zLCBib3RoIGluIHRoZSBhbGxfc291
cmNlcyBkZWZpbml0aW9uLg0KDQpBcyBhIGNzY29wZSB1c2VyIEkgd2FudCB0byB0aGFuayB5b3Ug
Zm9yIHRoZSBmaXguDQoNCj4NCj4gRmlyc3QsIGV2ZXJ5dGhpbmcgaW4gYXJjaC8qL2luY2x1ZGUg
Z2V0cyBkb3VibGUgaGl0cyB3aXRoIGNzY29wZSBxdWVyaWVzLA0KPiBiZWNhdXNlIHRoZXkgZW5k
IHVwIGdldHRpbmcgbGlzdGVkIHR3aWNlIGluIGNzY29wZS5maWxlcy4NCj4NCj4gRHJvcCB0aGUg
Zmlyc3QgYGZpbmRgIHJ1bmUgb2YgdGhlIHRocmVlLCBiZWNhdXNlIGl0J3MgcmVkdW5kYW50IHdp
dGggdGhlIHRoaXJkDQo+IHJ1bmUgZm9sbG93aW5nIGMvcyA3MjUzODFhNWVhYjMgKCJ4ZW46IG1v
dmUgaW5jbHVkZS9hc20tKiB0bw0KPiBhcmNoLyovaW5jbHVkZS9hc20iKS4NCj4NCj4gU2Vjb25k
LCBhbmQgdGhpcyB3YXkgZm9yIGEgbG9uZyB0aW1lOg0KPg0KPiAgICQgbWFrZSBjc2NvcGUNCj4g
ICAoIGZpbmQgYXJjaC94ODYvaW5jbHVkZSAtbmFtZSAnKi5oJyAtcHJpbnQ7IGZpbmQgaW5jbHVk
ZSAtbmFtZSAnKi5oJyAtcHJpbnQ7DQo+ICAgZmluZCB4c20gYXJjaC94ODYgY29tbW9uIGRyaXZl
cnMgbGliIHRlc3QgLW5hbWUgJyouW2NoU10nIC1wcmludCApID4NCj4gICBjc2NvcGUuZmlsZXMN
Cj4gICBjc2NvcGUgLWsgLWIgLXENCj4gICBjc2NvcGU6IGNhbm5vdCBmaW5kIGZpbGUgYXJjaC94
ODYvZWZpL2VmaS5oDQo+ICAgY3Njb3BlOiBjYW5ub3QgZmluZCBmaWxlIGFyY2gveDg2L2VmaS9l
Ym1hbGxvYy5jDQo+ICAgY3Njb3BlOiBjYW5ub3QgZmluZCBmaWxlIGFyY2gveDg2L2VmaS9jb21w
YXQuYw0KPiAgIGNzY29wZTogY2Fubm90IGZpbmQgZmlsZSBhcmNoL3g4Ni9lZmkvcGUuYw0KPiAg
IGNzY29wZTogY2Fubm90IGZpbmQgZmlsZSBhcmNoL3g4Ni9lZmkvYm9vdC5jDQo+ICAgY3Njb3Bl
OiBjYW5ub3QgZmluZCBmaWxlIGFyY2gveDg2L2VmaS9ydW50aW1lLmMNCj4NCj4gVGhpcyBpcyBj
YXVzZWQgYnkgdGhlc2UgYmVpbmcgc3ltbGlua3MgdG8gY29tbW9uL2VmaS4gIFJlc3RyaWN0IGFs
bCBmaW5kIHJ1bmVzDQo+IHRvIGAtdHlwZSBmYCB0byBza2lwIHN5bWxpbmtzLCBiZWNhdXNlIGNv
bW1vbi9lZmkvKi5jIGFyZSBhbHJlYWR5IGxpc3RlZC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogQW5k
cmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg0KUmV2aWV3ZWQtYnk6IFZv
bG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCg0KPiAtLS0NCj4g
Q0M6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPiBDQzogSmFu
IEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPg0KPiBDQzogUm9nZXIgUGF1IE1vbm7DqSA8cm9n
ZXIucGF1QGNpdHJpeC5jb20+DQo+IENDOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPg0KPiBDQzogU3Rl
ZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBDQzogSnVsaWVuIEdy
YWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gQ0M6IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJf
QmFiY2h1a0BlcGFtLmNvbT4NCj4gQ0M6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1
aXNAYXJtLmNvbT4NCj4NCj4gQW50aG9ueTogSSBsb29rZWQgdGhyb3VnaCB0aGUgcmVtYWluZGVy
IG9mIHlvdXIgYnVpbGQgc2VyaWVzIGFuZCBJIGNhbnQgc3BvdA0KPiBhbnkgZWRpdHMgdG8gYWxs
X3NvdXJjZXMuICBBcG9sb2dpZXMgaWYgSSBtaXNzZWQgaXQuDQo+IC0tLQ0KPiAgeGVuL01ha2Vm
aWxlIHwgNSArKy0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxl
dGlvbnMoLSkNCj4NCj4gZGlmZiAtLWdpdCBhL3hlbi9NYWtlZmlsZSBiL3hlbi9NYWtlZmlsZQ0K
PiBpbmRleCAyYWQ3ZGE3YWQ2N2IuLmRjNmJkYzQ0YzdhMiAxMDA2NDQNCj4gLS0tIGEveGVuL01h
a2VmaWxlDQo+ICsrKyBiL3hlbi9NYWtlZmlsZQ0KPiBAQCAtNDY4LDkgKzQ2OCw4IEBAIGFyY2gv
JChUQVJHRVRfQVJDSCkvaW5jbHVkZS9hc20vYXNtLW9mZnNldHMuaDogYXNtLW9mZnNldHMucw0K
PiAgDQo+ICBTVUJESVJTID0geHNtIGFyY2gvJChUQVJHRVRfQVJDSCkgY29tbW9uIGRyaXZlcnMg
bGliIHRlc3QNCj4gIGRlZmluZSBhbGxfc291cmNlcw0KPiAtICAgICggZmluZCBhcmNoLyQoVEFS
R0VUX0FSQ0gpL2luY2x1ZGUgLW5hbWUgJyouaCcgLXByaW50OyBcDQo+IC0gICAgICBmaW5kIGlu
Y2x1ZGUgLW5hbWUgJyouaCcgLXByaW50OyBcDQo+IC0gICAgICBmaW5kICQoU1VCRElSUykgLW5h
bWUgJyouW2NoU10nIC1wcmludCApDQo+ICsgICAgKCBmaW5kIGluY2x1ZGUgLXR5cGUgZiAtbmFt
ZSAnKi5oJyAtcHJpbnQ7IFwNCj4gKyAgICAgIGZpbmQgJChTVUJESVJTKSAtdHlwZSBmIC1uYW1l
ICcqLltjaFNdJyAtcHJpbnQgKQ0KDQpJbiBteSB0b29saW5nIEknbSB1c2luZyAtcHJpbnRmICJc
IiVwXCJcbiIgYmVjYXVzZSBnZW5lcmFsbHkgdGhlcmUgbWlnaHQNCmJlIGZpbGVzIHdpdGggZnVu
bnkgbmFtZXMuDQoNCj4gIGVuZGVmDQo+ICANCj4gIGRlZmluZSBzZXRfZXh1YmVyYW50X2ZsYWdz
DQoNCg0KLS0gDQpWb2xvZHlteXIgQmFiY2h1ayBhdCBFUEFN


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:27:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:27:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248156.428019 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuWu-0007m8-9g; Thu, 16 Dec 2021 17:26:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248156.428019; Thu, 16 Dec 2021 17:26:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuWu-0007m1-6a; Thu, 16 Dec 2021 17:26:56 +0000
Received: by outflank-mailman (input) for mailman id 248156;
 Thu, 16 Dec 2021 17:26:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxuWs-0007l9-E8
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:26:54 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c4de27d-5e95-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 18:26:53 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44498)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxuWo-000Y8o-1h (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 17:26:50 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 384EA1FA9B;
 Thu, 16 Dec 2021 17:26:50 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c4de27d-5e95-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <edcb690b-c21c-137f-0bda-79eda64a0164@srcf.net>
Date: Thu, 16 Dec 2021 17:26:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-23-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [XEN PATCH 22/57] tools/console: have one Makefile per
 program/directory
In-Reply-To: <20211206170241.13165-23-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Sources of both xenconsoled and xenconsole are already separated into
> different directory and don't share anything in common. Having two
> different Makefile means it's easier to deal with *FLAGS.
>
> Some common changes:
> Rename $(BIN) to $(TARGETS), this will be useful later.
> Stop removing *.so *.rpm *.a as they aren't created here.
> Use $(OBJS-y) to list objects.
> Update $(CFLAGS) for the directory rather than a single object.
>
> daemon:
>     Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
>     Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
> 	instead.
>
> client:
>     Remove the unused $(LDLIBS_xenconsole)
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  .gitignore                    |  4 +--
>  tools/console/Makefile        | 49 +++-------------------------------
>  tools/console/client/Makefile | 39 +++++++++++++++++++++++++++
>  tools/console/daemon/Makefile | 50 +++++++++++++++++++++++++++++++++++
>  4 files changed, 94 insertions(+), 48 deletions(-)
>  create mode 100644 tools/console/client/Makefile
>  create mode 100644 tools/console/daemon/Makefile
>
> diff --git a/.gitignore b/.gitignore
> index b39b996718..c31fa9b841 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -159,8 +159,8 @@ tools/libs/util/libxenutil.map
>  tools/libs/vchan/headers.chk
>  tools/libs/vchan/libxenvchan.map
>  tools/libs/vchan/xenvchan.pc
> -tools/console/xenconsole
> -tools/console/xenconsoled
> +tools/console/client/xenconsole
> +tools/console/daemon/xenconsoled

$ git ls-files -- :/ | grep gitignore
../.gitignore
../tools/fuzz/cpu-policy/.gitignore
../tools/libs/.gitignore
../tools/misc/.gitignore
../tools/tests/cpu-policy/.gitignore
../tools/tests/resource/.gitignore
../tools/tests/tsx/.gitignore
../tools/tests/vhpet/.gitignore
../tools/tests/xenstore/.gitignore
tools/kconfig/.gitignore
xsm/flask/.gitignore


We're starting to use per-dir gitignores, because it has far less
problematic behaviour for code movement.

I think we ought to take this opportunity to clean things up for the better.

> diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
> new file mode 100644
> index 0000000000..44176c6d93
> --- /dev/null
> +++ b/tools/console/client/Makefile
> @@ -0,0 +1,39 @@
> +XEN_ROOT=$(CURDIR)/../../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +CFLAGS += -Werror

-Werror really ought to come from somewhere common, seeing as we expect
it to be unilaterally set.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:36:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:36:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248161.428031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxugI-0000wc-9E; Thu, 16 Dec 2021 17:36:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248161.428031; Thu, 16 Dec 2021 17:36:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxugI-0000wU-4s; Thu, 16 Dec 2021 17:36:38 +0000
Received: by outflank-mailman (input) for mailman id 248161;
 Thu, 16 Dec 2021 17:36:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Lkuu=RB=epam.com=prvs=29842dc016=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mxugH-0000wO-0t
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:36:37 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b6c9f256-5e96-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 18:36:35 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BGGcpaZ003956;
 Thu, 16 Dec 2021 17:36:31 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d03vjsfee-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 16 Dec 2021 17:36:30 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7134.eurprd03.prod.outlook.com (2603:10a6:102:f3::7) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Thu, 16 Dec
 2021 17:36:26 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.018; Thu, 16 Dec 2021
 17:36:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b6c9f256-5e96-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ito8HJK5VA8sfgX7n+QjP6UPNDTfrjneJGzA90jgqK3zOvg7xYRn5GwjdR/tzHcaRH6MppMhNfd9Tv0CBNH1EFHfSnwcwZxcyUS/bu+tidoiWpqybzqNoeAzjLljYyme0NrYHkqcxLkGSoh1Af0GDSB/cmdNKvJYD2DS1rDdsV+OMatK4lSTJuKTpRl5IVjrWFj26iqz7VMycZwNjjTM3vMA5Q+14iDmqEpDfaq/7T4TDdQXx4uLaXLCDQTgb79t3D0WUT2+TSVMVpTW6n9HzZh5LBTWXw1tbYrfl4AU2JPWGs/fi3B/Agbs06GPMRPtDNZgxqoe2m+KOENQxzaboQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=G+/XOKd7wnHe2drRKI7fLT7N1/71vl1GnG/k+ljNB1E=;
 b=D7OQ724V3I474IHxqF6ata5/ACQzMF3GTv7JW2R/zfl7utYH0xFJtLGZ8VbOkZXC4RU5Lb52zf3FoF6xdRk/WXlbyeFxc8stloKpzZcrUEHF7EQiqXpjlJxdnzHus1S3wnrB425RCNG95hMw59PCGuGO94buFLUZxQGlltFHOKddvmlWio/oqEsr2sLVXFtNiDf4YPUwjxwdJ3BNsF8GBoYiV10eKPo755GFy8TW77tmwNSrQE4qisyqnXyejDga7kpZp1hu6sYR//YKNvHPC/SZmdqgEgioFN73QIKnUeQnAaAsENNdz2nWDNftrM/KheR7594gDyqFHSFl4yrf3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=G+/XOKd7wnHe2drRKI7fLT7N1/71vl1GnG/k+ljNB1E=;
 b=qIOplq+qc5bF39RTUse64z4RMNOHmPeJwBq5mkD0IysVKuICygu952SuxOkAkS7/6w3wK+3I5BZPLDNgUQ3JVHaLSvesxq1JBU87vlOgcxXEeMYecW533+Eu/Ywxm+J/fe/KbR3NcbbujdaCMyzEvC2FQLPyIX4BD/KZmVpIg/GLZPzAIXJELts3C4QYMsF1r3hb5b+HLcslqk7FCMUtgIu/9XEVeZSF+ARL4575iyb46yOTiDuFUQ388qvJpVVNV0m/U+OBy94yq0mi4PB1ONAHu8a940d/4aXbo16aQ9hfg8KJYG7mN9Imq6mdM4y/BhF92honZa35pOY5kP/rSw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Julien
 Grall <julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Anthony
 PERARD <anthony.perard@citrix.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qwxu+8AgAOpWoA=
Date: Thu, 16 Dec 2021 17:36:26 +0000
Message-ID: <20211216173625.GA3623693@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
In-Reply-To: <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9095e362-39c6-4343-c7cf-08d9c0ba9633
x-ms-traffictypediagnostic: PA4PR03MB7134:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7134641028B395054B53DCF8E3779@PA4PR03MB7134.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 g2YAfKcO1BlUWR2Txnn8elX8/jfTtAJN/Zqot96lZ/yuUo6b/q821jwDoH/OQYKwTgX3CRxEIyst3bFJVHnhzjiEOsvRfcq3g4qvapSVtIxIett6rEpcoLHpNhdnXyyaUdoOeRPTZ6Z4WCWRpoE2d5qm33J77iIglOLk25rjJjrNSN96lJcqSDM7RfaOTB6QwtwovR0XpeVmtV8TMiL+aZ35CiVfiRne3AmiN9+0BXq4ALaJlLmLSw+nBQY2SgMVKn61uaShu0Nvaa30pjwo1gd6ZmEhuP5un+cpdfzQ3+N5JzwtNXUu0+qVPaU0VolPWhjQaLza8cr2p2fJ2N8TGE//WL4K7ocZqZTIuq/BsvyLPU5lonvZ/bc/xxr92CsRyK2HQ3JlelkzpwnP2YqwSPKlsM/QIKHArndtT18+wqBnod6IqXpnchBodu8OydVVafeyJNtcoldi/uLqNZnyiht9DsvMykh0faZCljkIdbfBlrxZHZvW/WnDg5rxjZoqkBVMargH895pz+uAqySOTyRNpsuFla9Rxrliwm27P+sML66McU7E5xQRdZIqC51UV49YkNRcl4XCtIlGuhzED120vtmI4JrgIxgc+8x8thQ11mtoh+nJGwQBYt8vZpAfGlX7mSMn9+B7SePld2VE4GPVqjVmQhCiaqRgnc/oEuJbhsWF3Es4NpT2/tU+Ym/QvDOIUODTFJNYhDqHtTNUwA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66946007)(4326008)(6916009)(76116006)(8936002)(91956017)(508600001)(83380400001)(1076003)(66446008)(66556008)(66476007)(86362001)(8676002)(71200400001)(26005)(6506007)(33656002)(5660300002)(9686003)(54906003)(38070700005)(53546011)(7416002)(2906002)(122000001)(38100700002)(64756008)(186003)(6486002)(6512007)(316002)(33716001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?xISiWmuCa4i510E2RoaAhw8Y1DGw2+GLPnQKLtDRQjTW7VLhP6ug2YyprYrr?=
 =?us-ascii?Q?sNghiatRAKyIEClObbOgi5QsU26qFiHh08zXoAP4r9cwnfhwtknWA1Bu7H95?=
 =?us-ascii?Q?6iQaEXA8MgEAKSVLdNOQdLf+TmJDGcrt5aJWqFOs7hSj/kso4rSctA5Dqpi9?=
 =?us-ascii?Q?8Kuqor30yVsg7wDJCu/frc4/B7y1LDQ9longosxuD1heT6RSkLI9Jm2jCbae?=
 =?us-ascii?Q?eUB7N91FkYxIGl6/E/kwSoJwjPbo4prxSe3epAN4EaUs7EznaC1oepBXPv6D?=
 =?us-ascii?Q?pUW9Ed0hGaxybuYYlm7zvTutyQxI8wjus97AEoWWE9A51CfX+l0ZVbJQ+2iR?=
 =?us-ascii?Q?b+QeAg4AO3lyQeB4PlAx5XD8dOg1z/Kt/tZ527jno+XOVInitrQFW94rX9pT?=
 =?us-ascii?Q?z6h1Le8AaznCKH2Z/Usa1esgO6Qrpoao4wj+14to0NAeqA9rszq0ztvjZw8n?=
 =?us-ascii?Q?kzrfDEA+ce7IEyitNBqzh0h4dUFupdL9wbHfhl9xLxz6H7koIeMA+LSKmXZC?=
 =?us-ascii?Q?EvkKiXSHbTDMBZ/DgOi72V+VLkPxgcjXGWHgVBdpgwrIq4c5gssRmJKf/whl?=
 =?us-ascii?Q?noT21CMBtiojay5QZssQONqEWBCpXGsffK+YC8G250p4Ztm5iaqgRDEwJxh+?=
 =?us-ascii?Q?Tm+944JZG2hcWazcBLDX2q53ZIp7qL21BTNmGyDK4K7IrXPLyVFSGIfkOC33?=
 =?us-ascii?Q?Y3qFdKOUjQTohrEbneYi6kwY8CvWEnpCjX2JnEbjhNLgUAfPhKz5zAI8wmlu?=
 =?us-ascii?Q?h4AqPUurX7fTb5RstgndPnmfYVxAOx5O3n6bBKwz2fqEMoAWY38TSqbvm6Zi?=
 =?us-ascii?Q?/A1KLHWrA0WSDGrT3IxgfxgrxCEQKTRReypz1Dbp2gaOgN9UyYdIMoMYndqO?=
 =?us-ascii?Q?EURqaS5Tp9GOYgyHQzCuc5ODeTThCdnjK0x3OUQPDANjI5DDO30dnSMZ5LV6?=
 =?us-ascii?Q?hV08iaMWURTvLTIeIA8PiKLUKfi/YG9a8mAxZDZNwO+CIT6c4SXyt+qIPaiH?=
 =?us-ascii?Q?YQisqLpwyrxoWLrEZ+KOHv96kEzO4ZWdY5xlT61xwqV+v0m59Uof/HYg+H+i?=
 =?us-ascii?Q?X37U75wwsIYGGfY6aA8TcSbw2H6WckOZUgmakH/fISCQ/BhQY5U76MFFzQ+9?=
 =?us-ascii?Q?YPaiOVt6BY+04BJIQlRgWL2vKZj0TsNiPTVosBJtj4cp5/p6bJMtdAQHjzm8?=
 =?us-ascii?Q?+cALsqS6KKsVU5V0lS+7hKV+jvG+C9gndrCo36723YEayW7tb46uDdxTByPa?=
 =?us-ascii?Q?pXNtzgEDYBZNCN3S7ayO2hkVW4ljGEn/8a6rhHKy6iN9QtbmowL+oipnMjk5?=
 =?us-ascii?Q?/irdrhLbq2OZm1JjotIpv0vB9G26ImXz9W7Y+2AytCAoruGZs4uW+TZeOW0b?=
 =?us-ascii?Q?TXvRNsq4AoqAesDp6wnR7UwT+1LP2DWhee6rMeXlXbq6KEeIhJfbLRlZ1+l4?=
 =?us-ascii?Q?w/4fRaOreu0BXF6zrpwb3jaV0Ba3cvXEjXwHgDdGyYvBMUkE7g1nmqM4iN4E?=
 =?us-ascii?Q?M3oFLIJiINRbZXKZkyy7yRkFhP58bnMspQ5pMFm9vSl6zGZ+cku+MN0mFTBQ?=
 =?us-ascii?Q?vIDjICImFau4/QVEnFUpjXOy4mRy4POK8yXTF3raXw+45Tp7Yq5fqT0XF+Aq?=
 =?us-ascii?Q?/xoqxxPg9qMqXbFfH8cm+cvmao23CesftB0AowDspTFCPnmPiD6DodgM/zy4?=
 =?us-ascii?Q?SW6aGFvcC340DeTnXu0yFycibI4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <61DEE95302E2804AB1178E73018D8213@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9095e362-39c6-4343-c7cf-08d9c0ba9633
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2021 17:36:26.5436
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: slVLyRHmOG0u/3CxW8IYZ1OcSGWMKl+m+EC2XyC8OKaHabh3VR1QL/p98+5uhZ7c1bo+ns2k0AejezXhvtVc+pkb1GGnz8z4/pv3SGiaCic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7134
X-Proofpoint-GUID: zMrqiE1m4Zk3-Tu1Cm1EzTO00Sh9HXLf
X-Proofpoint-ORIG-GUID: zMrqiE1m4Zk3-Tu1Cm1EzTO00Sh9HXLf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-16_05,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=825 clxscore=1015
 mlxscore=0 impostorscore=0 priorityscore=1501 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160098

Hi Jan,

On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> >  #define XEN_DOMCTL_vmtrace_get_option         5
> >  #define XEN_DOMCTL_vmtrace_set_option         6
> >  };
> > +
> > +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> > +struct xen_domctl_sci_device_op {
> > +    uint32_t size; /* Length of the path */
> > +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> > +};
>=20
> This being - aiui - Arm-only, please enclose it by respective #if,
> just like we do for certain x86-only ops.
>=20

I agree. I will add #ifdefs in v2.

> I'm further afraid the term "SCI" is ambiguous with ACPI's System
> Control Interrupt, so there's some further tag needed in the names
> used here.
>=20

Thank you for remark. I'm thinking about SC as System Control.
What do you think?

> Finally please make padding explicit and check that it's zero on
> input.
>=20

I will align the comments in functions and structures in v2.

Best regards,
Oleksii.


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:56:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:56:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248166.428041 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuyd-0003cS-Rs; Thu, 16 Dec 2021 17:55:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248166.428041; Thu, 16 Dec 2021 17:55:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxuyd-0003cL-On; Thu, 16 Dec 2021 17:55:35 +0000
Received: by outflank-mailman (input) for mailman id 248166;
 Thu, 16 Dec 2021 17:55:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxuyd-0003cF-4v
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:55:35 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5c84aafd-5e99-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 18:55:32 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47118)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxuyY-000ERh-oO (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 17:55:30 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 5F3281FAC8;
 Thu, 16 Dec 2021 17:55:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c84aafd-5e99-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <ec048161-a117-36cf-b84f-e537a300d35b@srcf.net>
Date: Thu, 16 Dec 2021 17:55:29 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Elena Ufimtseva <elena.ufimtseva@oracle.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-25-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [XEN PATCH 24/57] tools/debugger/gdbsx: Fix and cleanup makefiles
In-Reply-To: <20211206170241.13165-25-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
> index 8d7cd94a31..4aaf427c45 100644
> --- a/tools/debugger/gdbsx/Makefile
> +++ b/tools/debugger/gdbsx/Makefile
> @@ -28,7 +28,7 @@ uninstall:
>  gdbsx: gx/gx_all.a xg/xg_all.a 
>  	$(CC) $(LDFLAGS) -o $@ $^
>  
> -xg/xg_all.a:
> +xg/xg_all.a: FORCE
>  	$(MAKE) -C xg
> -gx/gx_all.a:
> +gx/gx_all.a: FORCE
>  	$(MAKE) -C gx

Shouldn't these be in the sub Make's ?

> diff --git a/tools/debugger/gdbsx/gx/Makefile b/tools/debugger/gdbsx/gx/Makefile
> index 3b8467f799..ff5c8e9e6e 100644
> --- a/tools/debugger/gdbsx/gx/Makefile
> +++ b/tools/debugger/gdbsx/gx/Makefile
> @@ -2,21 +2,20 @@ XEN_ROOT = $(CURDIR)/../../../..
>  include ../Rules.mk
>  
>  GX_OBJS := gx_comm.o gx_main.o gx_utils.o gx_local.o
> -GX_HDRS := $(wildcard *.h)
> +
> +TARGETS := gx_all.a
>  
>  .PHONY: all
> -all: gx_all.a
> +all: $(TARGETS)
>  
>  .PHONY: clean
>  clean:
> -	rm -rf gx_all.a *.o .*.d
> +	rm -f *.o $(TARGETS) $(DEPS_RM)

$(RM)

>  
>  .PHONY: distclean
>  distclean: clean
>  
> -#%.o: %.c $(GX_HDRS) Makefile
> -#	$(CC) -c $(CFLAGS) -o $@ $<
> -
> -gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS)
> -	ar cr $@ $(GX_OBJS)        # problem with ld using -m32 
> +gx_all.a: $(GX_OBJS) Makefile
> +	ar cr $@ $(GX_OBJS)

There's probably an $(AR) we ought to be using.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 17:57:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 17:57:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248170.428053 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxv0m-0004Do-7G; Thu, 16 Dec 2021 17:57:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248170.428053; Thu, 16 Dec 2021 17:57:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxv0m-0004Dh-4Q; Thu, 16 Dec 2021 17:57:48 +0000
Received: by outflank-mailman (input) for mailman id 248170;
 Thu, 16 Dec 2021 17:57:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxv0k-0004DD-FJ
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 17:57:46 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ac118028-5e99-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 18:57:45 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47120)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxv0h-000Exx-oW (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 17:57:43 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 635661FAC8;
 Thu, 16 Dec 2021 17:57:43 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ac118028-5e99-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <76b1346c-b42b-46d7-943d-01019e95b60c@srcf.net>
Date: Thu, 16 Dec 2021 17:57:43 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 25/57] tools/examples: cleanup Makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-26-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-26-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> diff --git a/tools/examples/Makefile b/tools/examples/Makefile
> index 14e24f4cb3..48b520e133 100644
> --- a/tools/examples/Makefile
> +++ b/tools/examples/Makefile
> @@ -26,10 +22,8 @@ uninstall: uninstall-readmes uninstall-configs
>  
>  .PHONY: install-readmes
>  install-readmes:
> -	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
> -		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> -	set -e; for i in $(XEN_READMES); \
> -	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
> +	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> +	set -e; for i in $(XEN_READMES); do \
>  	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \

Hmm.  Do we need a shell loop here at all?  Can't $(INSTALL_DATA) take
multiple $i's at the same time?

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:04:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:04:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248174.428063 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxv6l-0005u2-Sx; Thu, 16 Dec 2021 18:03:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248174.428063; Thu, 16 Dec 2021 18:03:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxv6l-0005tv-Q4; Thu, 16 Dec 2021 18:03:59 +0000
Received: by outflank-mailman (input) for mailman id 248174;
 Thu, 16 Dec 2021 18:03:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxv6k-0005tp-8T
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:03:58 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8970f1e9-5e9a-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 19:03:57 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44510)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxv6g-000kEg-2o (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:03:54 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 985121FB21;
 Thu, 16 Dec 2021 18:03:54 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8970f1e9-5e9a-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d10d6034-f0a3-12fd-47f6-daf3333dc5c4@srcf.net>
Date: Thu, 16 Dec 2021 18:03:54 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Ian Jackson <iwj@xenproject.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-27-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [XEN PATCH 26/57] tools/firmware/hvmloader: rework Makefile
In-Reply-To: <20211206170241.13165-27-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Setup proper dependencies with libacpi so we don't need to run "make
> hvmloader" in the "all" target. ("build.o" new prerequisite isn't
> exactly proper but a side effect of building the $(DSDT_FILES) is to
> generate the "ssdt_*.h" needed by "build.o".)
>
> Make use if "-iquote" instead of a plain "-I".

So I've read up on what this means, but is it really that important in
the grand scheme of things?

Can't we actually make our problems go away by turning libacpi into a
real static library?  (Also, the "kill hvmloader plans" will turn
libacpi back into only having one single user, so that too)

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:21:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:21:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248179.428074 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvN9-00007r-BF; Thu, 16 Dec 2021 18:20:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248179.428074; Thu, 16 Dec 2021 18:20:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvN9-00007k-8I; Thu, 16 Dec 2021 18:20:55 +0000
Received: by outflank-mailman (input) for mailman id 248179;
 Thu, 16 Dec 2021 18:20:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvN7-00007e-Te
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:20:53 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e71b6754-5e9c-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 19:20:52 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44512)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxvN6-000pwn-0D (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:20:52 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id D37C41FAB5;
 Thu, 16 Dec 2021 18:20:51 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e71b6754-5e9c-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5ba424c0-22c3-0c4a-af87-3346027260b6@srcf.net>
Date: Thu, 16 Dec 2021 18:20:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 34/57] tools/xcutils: rework Makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-35-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-35-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Use TARGETS to collect targets to build
>
> Remove "build" target.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  tools/xcutils/Makefile | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/tools/xcutils/Makefile b/tools/xcutils/Makefile
> index 82d42624c8..198be22a5a 100644
> --- a/tools/xcutils/Makefile
> +++ b/tools/xcutils/Makefile
> @@ -11,7 +11,7 @@
>  XEN_ROOT	= $(CURDIR)/../..
>  include $(XEN_ROOT)/tools/Rules.mk
>  
> -PROGRAMS = readnotes lsevtchn
> +TARGETS := readnotes lsevtchn

(For the future, because I'll commit this patch nowish)

We have at least

tools/xcutils
tools/misc
tools/helpers

of "misc random crap".  We ought to consolidate, and rethink which
binaries get installed where, because there is no coherent logic for
which end up on $PATH by default, and which don't.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:25:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:25:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248184.428085 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvRa-0000q6-0P; Thu, 16 Dec 2021 18:25:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248184.428085; Thu, 16 Dec 2021 18:25:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvRZ-0000pz-Th; Thu, 16 Dec 2021 18:25:29 +0000
Received: by outflank-mailman (input) for mailman id 248184;
 Thu, 16 Dec 2021 18:25:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvRZ-0000pt-6H
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:25:29 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8af80767-5e9d-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 19:25:28 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43982)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxvRW-00082G-iz (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:25:26 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id B66821FA9B;
 Thu, 16 Dec 2021 18:25:26 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8af80767-5e9d-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <9a452b7b-abaf-53bc-0b09-f41bcdb0b470@srcf.net>
Date: Thu, 16 Dec 2021 18:25:26 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 35/57] tools/xenpaging: Rework makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-36-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-36-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> @@ -39,6 +39,6 @@ distclean: clean
>  
>  .PHONY: TAGS
>  TAGS:
> -	etags -t $(SRCS) *.h
> +	etags -t *.c *.h

/local/xen.git/xen$ git grep -w TAGS: -- :/
../tools/libs/libs.mk:129:TAGS:
../tools/xenpaging/Makefile:41:TAGS:
../tools/xenstore/Makefile:102:TAGS:
Makefile:487:TAGS:

Facilities like this ought to be organised by tools/Makefile, or perhaps
even the root Makefile.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:34:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:34:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248188.428096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvaE-0002Sj-TV; Thu, 16 Dec 2021 18:34:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248188.428096; Thu, 16 Dec 2021 18:34:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvaE-0002Sc-Qa; Thu, 16 Dec 2021 18:34:26 +0000
Received: by outflank-mailman (input) for mailman id 248188;
 Thu, 16 Dec 2021 18:34:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvaD-0002ST-L2
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:34:25 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c95be621-5e9e-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 19:34:23 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43986)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxva9-000Bqy-i4 (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:34:21 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 2B2201FB86;
 Thu, 16 Dec 2021 18:34:21 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c95be621-5e9e-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <42048d21-c02e-9fea-b228-7ffc60009be9@srcf.net>
Date: Thu, 16 Dec 2021 18:34:20 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
In-Reply-To: <20211206170241.13165-37-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Regroup *FLAGS together, use $(LDLIBS).
>
> Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't
> decribe how to link to a potential libxenstored.so, instead add the
> value to $(LDLIBS) of xenstored.
>
> Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).
>
> Remove the "-I." from $(CFLAGS), it shouldn't be needed.
>
> Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
> in $(CFLAGS) and both aren't used anyway.
>
> Rename ALL_TARGETS to TARGETS.
> Only add programmes we want to build in $(TARGETS), not phony-targets
> (replace "clients").
>
> Store all `xenstored` objs into $(XENSTORED_OBJS-y).
>
> Replace one $< by $^ even if there's only one dependency,
> (xenstore-control).
>
> clean: "init-xenstore-domain" isn't built here, so stop trying to
> remove it, remove $(TARGETS).
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  tools/xenstore/Makefile | 81 ++++++++++++++++++++++-------------------
>  1 file changed, 44 insertions(+), 37 deletions(-)
>
> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> index 292b478fa1..7fe1d9c1e2 100644
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -5,7 +5,6 @@ MAJOR = 3.0
>  MINOR = 3

Actually, shouldn't this MAJOR/MINOR be dropped now that libxenstore
moved to tools/libs ?

It's definitely wrong now, seeing as we bumped to 4.0 for Xen 4.16.

>  
>  CFLAGS += -Werror
> -CFLAGS += -I.
>  # Include configure output (config.h)
>  CFLAGS += -include $(XEN_ROOT)/tools/config.h
>  CFLAGS += -I./include
> @@ -16,36 +15,53 @@ CFLAGS += $(CFLAGS_libxentoolcore)
>  CFLAGS += -DXEN_LIB_STORED="\"$(XEN_LIB_STORED)\""
>  CFLAGS += -DXEN_RUN_STORED="\"$(XEN_RUN_STORED)\""
>  
> -CFLAGS  += $(CFLAGS-y)
> -LDFLAGS += $(LDFLAGS-y)
> +ifdef CONFIG_STUBDOM
> +CFLAGS += -DNO_SOCKETS=1
> +endif
>  
> -CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
> -CLIENTS += xenstore-write xenstore-ls xenstore-watch
> +XENSTORED_OBJS-y := xenstored_core.o xenstored_watch.o xenstored_domain.o
> +XENSTORED_OBJS-y += xenstored_transaction.o xenstored_control.o
> +XENSTORED_OBJS-y += xs_lib.o talloc.o utils.o tdb.o hashtable.o
>  
> -XENSTORED_OBJS = xenstored_core.o xenstored_watch.o xenstored_domain.o
> -XENSTORED_OBJS += xenstored_transaction.o xenstored_control.o
> -XENSTORED_OBJS += xs_lib.o talloc.o utils.o tdb.o hashtable.o
> +XENSTORED_OBJS-$(CONFIG_Linux) += xenstored_posix.o
> +XENSTORED_OBJS-$(CONFIG_SunOS) += xenstored_solaris.o xenstored_posix.o xenstored_probes.o
> +XENSTORED_OBJS-$(CONFIG_NetBSD) += xenstored_posix.o
> +XENSTORED_OBJS-$(CONFIG_FreeBSD) += xenstored_posix.o
> +XENSTORED_OBJS-$(CONFIG_MiniOS) += xenstored_minios.o
>  
> -XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_posix.o
> -XENSTORED_OBJS_$(CONFIG_SunOS) = xenstored_solaris.o xenstored_posix.o xenstored_probes.o
> -XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_posix.o
> -XENSTORED_OBJS_$(CONFIG_FreeBSD) = xenstored_posix.o
> -XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o
> +$(XENSTORED_OBJS-y): CFLAGS += $(CFLAGS_libxengnttab)
>  
> -XENSTORED_OBJS += $(XENSTORED_OBJS_y)
> -LDLIBS_xenstored += -lrt
> +xenstored: LDLIBS += $(LDLIBS_libxenevtchn)
> +xenstored: LDLIBS += $(LDLIBS_libxengnttab)
> +xenstored: LDLIBS += $(LDLIBS_libxenctrl)
> +xenstored: LDLIBS += -lrt
> +xenstored: LDLIBS += $(SOCKET_LIBS)
>  
> -ALL_TARGETS = clients
> -ifeq ($(XENSTORE_XENSTORED),y)
> -ALL_TARGETS += xs_tdb_dump xenstored
> +ifeq ($(CONFIG_SYSTEMD),y)
> +$(XENSTORED_OBJS-y): CFLAGS += $(SYSTEMD_CFLAGS)
> +xenstored: LDLIBS += $(SYSTEMD_LIBS)
>  endif
>  
> -ifdef CONFIG_STUBDOM
> -CFLAGS += -DNO_SOCKETS=1
> +xenstore: LDLIBS += $(LDLIBS_libxenstore)
> +xenstore: LDLIBS += $(LDLIBS_libxentoolcore)
> +xenstore: LDLIBS += $(SOCKET_LIBS)
> +
> +xenstore-control: LDLIBS += $(LDLIBS_libxenstore)
> +xenstore-control: LDLIBS += $(LDLIBS_libxenctrl)
> +xenstore-control: LDLIBS += $(LDLIBS_libxenguest)
> +xenstore-control: LDLIBS += $(LDLIBS_libxentoolcore)
> +xenstore-control: LDLIBS += $(SOCKET_LIBS)
> +
> +CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm xenstore-chmod
> +CLIENTS += xenstore-write xenstore-ls xenstore-watch
> +
> +TARGETS := xenstore $(CLIENTS) xenstore-control
> +ifeq ($(XENSTORE_XENSTORED),y)
> +TARGETS += xs_tdb_dump xenstored
>  endif
>  
>  .PHONY: all
> -all: $(ALL_TARGETS)
> +all: $(TARGETS)
>  
>  .PHONY: clients
>  clients: xenstore $(CLIENTS) xenstore-control
> @@ -62,37 +78,28 @@ xenstored_probes.o: xenstored_solaris.o

Urgh - there's a mess in here.

the `dtrace` line has trailing whitespace, but xenstored_probes.d is
going to be clobbered by the dependency file logic.

Given this is utterly broken, perhaps better to drop the CONFIG_SunOS
chunk entirely?

>  CFLAGS += -DHAVE_DTRACE=1
>  endif
>  
> -ifeq ($(CONFIG_SYSTEMD),y)
> -$(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
> -xenstored: LDFLAGS += $(SYSTEMD_LIBS)
> -endif
> -
> -$(XENSTORED_OBJS): CFLAGS += $(CFLAGS_libxengnttab)
> -
> -xenstored: $(XENSTORED_OBJS)
> -	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenevtchn) $(LDLIBS_libxengnttab) $(LDLIBS_libxenctrl) $(LDLIBS_xenstored) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +xenstored: $(XENSTORED_OBJS-y)
> +	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
>  
> -xenstored.a: $(XENSTORED_OBJS)
> +xenstored.a: $(XENSTORED_OBJS-y)
>  	$(AR) cr $@ $^
>  
>  $(CLIENTS): xenstore
>  	ln -f xenstore $@
>  
>  xenstore: xenstore_client.o xs_lib.o
> -	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
>  
>  xenstore-control: xenstore_control.o
> -	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ $(APPEND_LDFLAGS)
>  
>  xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
> -	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
>  
>  .PHONY: clean
>  clean:
>  	rm -f *.a *.o xenstored_probes.h

This header file looks wonky to be cleaning.

> -	rm -f xenstored
> -	rm -f xs_tdb_dump xenstore-control init-xenstore-domain
> -	rm -f xenstore $(CLIENTS)
> +	rm -f $(TARGETS)
>  	$(RM) $(DEPS_RM)
>  
>  .PHONY: distclean

There is some abuse lower down too.  Another local TAGS, but also a
tarball rule too, and we probably don't want to be using .SECONDARY:
right at the bottom.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:36:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:36:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248192.428108 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvby-00032z-8s; Thu, 16 Dec 2021 18:36:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248192.428108; Thu, 16 Dec 2021 18:36:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvby-00032s-5d; Thu, 16 Dec 2021 18:36:14 +0000
Received: by outflank-mailman (input) for mailman id 248192;
 Thu, 16 Dec 2021 18:36:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvbw-00032k-TC
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:36:12 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0927451b-5e9f-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 19:36:10 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47134)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxvbs-000SVO-n7 (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:36:08 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id DACF61FAC8;
 Thu, 16 Dec 2021 18:36:07 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0927451b-5e9f-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <1f7e6887-a1ef-ec08-6bbf-fa6ca3e83259@srcf.net>
Date: Thu, 16 Dec 2021 18:36:07 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 37/57] tools/xentop: rework makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-38-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-38-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> diff --git a/tools/xentop/Makefile b/tools/xentop/Makefile
> index 0034114684..1e52b29b37 100644
> --- a/tools/xentop/Makefile
> +++ b/tools/xentop/Makefile
> @@ -13,24 +13,23 @@
>  XEN_ROOT=$(CURDIR)/../..
>  include $(XEN_ROOT)/tools/Rules.mk
>  
> -ifneq ($(XENSTAT_XENTOP),y)
> -.PHONY: all install xentop uninstall
> -all install xentop uninstall:
> -else
> -
>  CFLAGS += -DGCC_PRINTF -Werror $(CFLAGS_libxenstat)
>  LDLIBS += $(LDLIBS_libxenstat) $(CURSES_LIBS) $(TINFO_LIBS) $(SOCKET_LIBS) -lm
>  CFLAGS += -DHOST_$(XEN_OS)
>  
>  # Include configure output (config.h)
>  CFLAGS += -include $(XEN_ROOT)/tools/config.h
> -LDFLAGS += $(APPEND_LDFLAGS)
> +
> +TARGETS := xentop
>  
>  .PHONY: all
> -all: xentop
> +all: $(TARGETS)
> +
> +xentop: xentop.o
> +	$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) $(APPEND_LDFLAGS)
>  
>  .PHONY: install
> -install: xentop
> +install: all
>  	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
>  	$(INSTALL_PROG) xentop $(DESTDIR)$(sbindir)/xentop

$(TARGETS) ?

>  
> @@ -38,11 +37,9 @@ install: xentop
>  uninstall:
>  	rm -f $(DESTDIR)$(sbindir)/xentop
>  
> -endif
> -
>  .PHONY: clean
>  clean:
> -	rm -f xentop xentop.o $(DEPS_RM)
> +	rm -f $(TARGETS) xentop.o $(DEPS_RM)

$(RM) *.o ?

~Andrew

>  
>  .PHONY: distclean
>  distclean: clean



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:38:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:38:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248196.428119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxveP-0003gW-M6; Thu, 16 Dec 2021 18:38:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248196.428119; Thu, 16 Dec 2021 18:38:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxveP-0003gP-Ig; Thu, 16 Dec 2021 18:38:45 +0000
Received: by outflank-mailman (input) for mailman id 248196;
 Thu, 16 Dec 2021 18:38:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxveN-0003gJ-WD
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:38:44 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63ab1727-5e9f-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 19:38:42 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43448)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxveK-000gGp-8X (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:38:40 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 6A09A1FAC8;
 Thu, 16 Dec 2021 18:38:40 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63ab1727-5e9f-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8d157a2b-2174-8ee9-b269-3f7223217b9b@srcf.net>
Date: Thu, 16 Dec 2021 18:38:40 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 38/57] tools/xenstrace: rework Makefile
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-39-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-39-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
>  .PHONY: install
> -install: build
> +install: all
>  	$(INSTALL_DIR) $(DESTDIR)$(bindir)
>  	$(INSTALL_DIR) $(DESTDIR)$(sbindir)
>  	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)

Doesn't this conditional mkdir want to be dropped?

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:47:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:47:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248201.428129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvmk-0005JM-FQ; Thu, 16 Dec 2021 18:47:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248201.428129; Thu, 16 Dec 2021 18:47:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvmk-0005JF-CU; Thu, 16 Dec 2021 18:47:22 +0000
Received: by outflank-mailman (input) for mailman id 248201;
 Thu, 16 Dec 2021 18:47:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvmi-0005J9-TB
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:47:20 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 98c8d617-5ea0-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 19:47:19 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43450)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxvmf-000j6C-9a (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:47:17 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id B77281FA9B;
 Thu, 16 Dec 2021 18:47:17 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 98c8d617-5ea0-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <edc0491b-a778-0ca1-88c6-c7076db3a14b@srcf.net>
Date: Thu, 16 Dec 2021 18:47:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 47/57] libs/stat: Fix and rework python-bindings build
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Juergen Gross <jgross@suse.com>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-48-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-48-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> Fix the dependency on the library, $(SHLIB) variable doesn't exist
> anymore.
>
> Rework dependency on the include file, we can let `swig` generate the
> dependency for us with the use of "-M*" flags.

Hmm.  At no point is swig mentioned in README/etc, and it's not in any
of the CI logic.  I wasn't even aware that we had python bindings here.

Unless someone tries and confirms them not to be broken, I'd be tempted
to drop it all.  I bet this has been dead since we dropped Xend.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 18:51:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 18:51:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248206.428141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvqp-0006rG-0L; Thu, 16 Dec 2021 18:51:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248206.428141; Thu, 16 Dec 2021 18:51:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxvqo-0006r9-TF; Thu, 16 Dec 2021 18:51:34 +0000
Received: by outflank-mailman (input) for mailman id 248206;
 Thu, 16 Dec 2021 18:51:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxvqo-0006r3-65
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 18:51:34 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 300e5136-5ea1-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 19:51:33 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47142)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxvqk-000XVK-nv (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 18:51:30 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 427041FB86;
 Thu, 16 Dec 2021 18:51:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 300e5136-5ea1-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <c9987beb-8470-ecdf-4ac1-e1ab9e73e515@srcf.net>
Date: Thu, 16 Dec 2021 18:51:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH 50/57] tools/Rules.mk: Cleanup %.pc rules
Content-Language: en-GB
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-51-anthony.perard@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <20211206170241.13165-51-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 06/12/2021 17:02, Anthony PERARD wrote:
> PKG_CONFIG_VARS isn't used anymore.

isn't set any more, so is dead logic.

Will tweak on commit.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 19:39:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 19:39:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248211.428152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxwax-0003Zb-Jm; Thu, 16 Dec 2021 19:39:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248211.428152; Thu, 16 Dec 2021 19:39:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxwax-0003ZU-Ec; Thu, 16 Dec 2021 19:39:15 +0000
Received: by outflank-mailman (input) for mailman id 248211;
 Thu, 16 Dec 2021 19:39:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxwaw-0003ZK-41; Thu, 16 Dec 2021 19:39:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxwav-0006jy-Ip; Thu, 16 Dec 2021 19:39:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mxwav-0005gT-8N; Thu, 16 Dec 2021 19:39:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mxwav-0003Z0-3U; Thu, 16 Dec 2021 19:39:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=+YwqVf9hve96WO/WFxLhyS4yUnS318pXEzC32uwqdj0=; b=amDw5acSBCYPHM1HgQ2it0HELq
	FxAYTJrYR92Kcgn5W2j1BBWxeB7U3FamHdlP6Wy+sPF2fM6lUbOhttWtzK6sBRHVScG5koanGlATm
	iiFk+9RRsBXvlKX+CYaavMPMOxXK7Y39qK1uDl6yd2A+W47gYwAhqvj0y4Cy5U5MGkP8=;
To: xen-devel@lists.xenproject.org,
    osstest-admin@xenproject.org
Message-ID: <osstest-167443-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167443: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=e630bc7ec9dda656a452ed28cac4d1e9ed605d71
X-Osstest-Versions-That:
    qemuu=76b56fdfc9fa43ec6e5986aee33f108c6c6a511e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 19:39:13 +0000

flight 167443 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167443/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167426
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167426
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167426
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167426
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167426
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167426
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167426
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167426
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                e630bc7ec9dda656a452ed28cac4d1e9ed605d71
baseline version:
 qemuu                76b56fdfc9fa43ec6e5986aee33f108c6c6a511e

Last test of basis   167426  2021-12-15 09:11:59 Z    1 days
Testing same since   167443  2021-12-16 03:09:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Ani Sinha <ani@anisinha.ca>
  Edgar E. Iglesias <edgar.iglesias@xilinx.com>
  Eric Auger <eric.auger@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Joel Stanley <joel@jms.id.au>
  John Snow <jsnow@redhat.com>
  Juan Quintela <quintela@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Lei Rao <lei.rao@intel.com>
  Li Zhang <lizhang@suse.de>
  Markus Armbruster <armbru@redhat.com>
  Olivier Hériveaux <olivier.heriveaux@ledger.fr>
  Patrick Venture <venture@google.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Rao, Lei <lei.rao@intel.com>
  Richard Henderson <richard.henderson@linaro.org>
  Richard W.M. Jones <rjones@redhat.com>
  Thomas Huth <thuth@redhat.com>
  Zhang Chen <chen.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   76b56fdfc9..e630bc7ec9  e630bc7ec9dda656a452ed28cac4d1e9ed605d71 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 20:26:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 20:26:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248218.428166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxxJn-0000uD-Bk; Thu, 16 Dec 2021 20:25:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248218.428166; Thu, 16 Dec 2021 20:25:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxxJn-0000u6-7r; Thu, 16 Dec 2021 20:25:35 +0000
Received: by outflank-mailman (input) for mailman id 248218;
 Thu, 16 Dec 2021 20:25:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxxJl-0000u0-IT
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 20:25:33 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 50546c84-5eae-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 21:25:31 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 401FF61F60;
 Thu, 16 Dec 2021 20:25:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 464D8C36AE8;
 Thu, 16 Dec 2021 20:25:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50546c84-5eae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639686329;
	bh=r27tcHp5Z6CKNNW9/L7PAoVWyywZ/pyOu14nV40CaCk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=mg1/zZ5GwnmTtZ2czI0MEokpabt4cajVBEljIuqHe4YqRaZH9zRAW2TRJrSRxmV8a
	 qHJBzGcns1Edt/bXvhvAHVTETDEuUIpZNUr1et+HUs8vEgTLAEB5A3SU2mD6RrFl1w
	 XNbTszClh3zyog8+4kr4/UxmdeH2LQfLYk3gt3SBaZ1ksdVi3tai2x4jQdmIUxpezE
	 013TraAPE3sbydlYIAZa5VNr87lCuQjUADSV/4cXqX1SUlvPu25OkEjstJ/DJo7Lk/
	 AW4Vp36rPI56fmw/hyyzJGSUFFXQrYIWyRwCPD5a1CdonM6Zi2nl8a1oiQX01dbej1
	 bV8vgATe7y73Q==
Date: Thu, 16 Dec 2021 12:25:29 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Jan Beulich <jbeulich@suse.com>
cc: Juergen Gross <jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: make some per-scheduler performance counters sched
 global ones
In-Reply-To: <91fabc88-f4d5-aa0d-be8d-1f1ebf465360@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112161225020.3376@ubuntu-linux-20-04-desktop>
References: <20211216054502.14085-1-jgross@suse.com> <91fabc88-f4d5-aa0d-be8d-1f1ebf465360@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 16 Dec 2021, Jan Beulich wrote:
> On 16.12.2021 06:45, Juergen Gross wrote:
> > Some performance counters listed to be credit or credit2 specific are
> > being used by the null scheduler, too.
> > 
> > Make those sched global ones.
> > 
> > Fixes: ab6ba8c6753fa76 ("perfc: conditionalize credit/credit2 counters")
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> As an immediate fix
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

I tested the patch and it fixes the issue

Tested-by: Stefano Stabellini <sstabellini@kernel.org>


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 20:43:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 20:43:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248223.428177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxxb2-0003aS-TL; Thu, 16 Dec 2021 20:43:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248223.428177; Thu, 16 Dec 2021 20:43:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxxb2-0003aL-O8; Thu, 16 Dec 2021 20:43:24 +0000
Received: by outflank-mailman (input) for mailman id 248223;
 Thu, 16 Dec 2021 20:43:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxxb1-0003aF-8l
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 20:43:23 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ce15fc83-5eb0-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 21:43:21 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2769761F01;
 Thu, 16 Dec 2021 20:43:20 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02EA7C36AE2;
 Thu, 16 Dec 2021 20:43:18 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce15fc83-5eb0-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639687399;
	bh=wswyCZLNWyM9Qop/hW0Z+bnxMrXenkcm3O3d0sXA/u8=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=aJgSfgnJYUGx+ua/YmngOMLexKa34GLcrwUhHelQHuJAKIq+vxoxQy6fUU3NSm+DT
	 GBWsrl8oRw7Kr+4wc3lX0zp7nDMXFiykoj9YaIAKgJGMpUziizVpkuyjhqb4wYiP5K
	 t3htL04eALCTpkHmIzv3yPj/GHW6QLH/OFvyAI8dmxJawDkXR5GChy1PRe0+kDAAUk
	 shA9ek74omvRVGTW5a/mkBPmqxKt3T2X+KL0Ee0epBDzAajvG1owytW+JiMhP1QVGc
	 Zgzih0GfvPH2Z7TnoSxm/mNRoFm1847YMIkRfY7gAkHLh39nuhp/MKdj6agI+vxHSG
	 LID7naSZTLAGw==
Date: Thu, 16 Dec 2021 12:43:19 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com> <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 16 Dec 2021, Juergen Gross wrote:
> On 16.12.21 03:10, Stefano Stabellini wrote:
> > On Wed, 15 Dec 2021, Juergen Gross wrote:
> > > On 14.12.21 18:36, Julien Grall wrote:
> > > > Hi,
> > > > 
> > > > On 08/12/2021 15:55, Juergen Gross wrote:
> > > > > Today most hypercall handlers have a return type of long, while the
> > > > > compat ones return an int. There are a few exceptions from that rule,
> > > > > however.
> > > > 
> > > > So on Arm64, I don't think you can make use of the full 64-bit because a
> > > > 32-bit domain would not be able to see the top 32-bit.
> > > > 
> > > > In fact, this could potentially cause us some trouble (see [1]) in Xen.
> > > > So it feels like the hypercalls should always return a 32-bit signed
> > > > value
> > > > on Arm.
> > > 
> > > This would break hypercalls like XENMEM_maximum_ram_page which are able
> > > to return larger values, right?
> > > 
> > > > The other advantage is it would be clear that the top 32-bit are not
> > > > usuable. Stefano, what do you think?
> > > 
> > > Wouldn't it make more sense to check the return value to be a sign
> > > extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
> > > 
> > > The question is what to return if this is not the case. -EDOM?
> > 
> > 
> > I can see where Julien is coming from: we have been trying to keep the
> > arm32 and arm64 ABIs identical since the beginning of the project. So,
> > like Julien, my preference would be to always return 32-bit on ARM, both
> > aarch32 and aarch64. It would make things simple.
> > 
> > The case of XENMEM_maximum_ram_page is interesting but it is not a
> > problem in reality because the max physical address size is only 40-bit
> > for aarch32 guests, so 32-bit are always enough to return the highest
> > page in memory for 32-bit guests.
> 
> You are aware that this isn't the guest's max page, but the host's?
> 
> And all of this is about a 32-bit guest on a 64-bit host.

Yes, I am following, and it is always difficult to get the right
information out of the ARM Reference Manual, but from my search
ARMv8/aarch32 (which is 32-bit mode on 64-bit capable hardware) supports
max 40 bits.

>From G5.1.3 (ARM DDI 0487G.a):

---
For execution in AArch32 state, the Armv8 architecture supports:

- A VA space of up to 32 bits. The actual width is IMPLEMENTATION DEFINED .

- An IPA space of up to 40 bits. The translation tables and associated System registers define the width of the
implemented address space.
---

Julien, Bertrand, am I reading this right?


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 21:10:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 21:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248244.428187 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxy0z-0007Ji-TO; Thu, 16 Dec 2021 21:10:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248244.428187; Thu, 16 Dec 2021 21:10:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxy0z-0007Jb-QR; Thu, 16 Dec 2021 21:10:13 +0000
Received: by outflank-mailman (input) for mailman id 248244;
 Thu, 16 Dec 2021 21:10:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=sk45=RB=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1mxy0y-0007JV-RL
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 21:10:12 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d29fdab-5eb4-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 22:10:11 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47262)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1mxy0m-000AoV-nf (Exim 4.95) (return-path <amc96@srcf.net>);
 Thu, 16 Dec 2021 21:10:00 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 299521FC68;
 Thu, 16 Dec 2021 21:10:00 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d29fdab-5eb4-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <d75ef96c-ab0a-adb9-ca15-70e1c9c5e27e@srcf.net>
Date: Thu, 16 Dec 2021 21:09:59 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
Cc: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 0/6] x86: Support PKS
In-Reply-To: <20211216095421.12871-1-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/12/2021 09:54, Andrew Cooper wrote:
> I found a spare half hour, and this turned out to go very smoothly.
>
> It's tentatively RFC right now, because I'm still adding PKS support to the
> XTF comprehensive pagewalk test, but the series is definitely fit for review
> at this point.

I suppose it's worth expanding on this a little.  What I've proposed
here is the most efficient option, and it is very non-invasive but comes
with the downside that Xen can't set CR4.PKS.

It is tied to VT-x behaviour, so I've left a deliberate clobber so it
won't engage automatically if AMD add support on future CPUs.


If we want Xen to be able to use PKS, then a couple of things change.

1) PV32 needs inhibiting.  This is likely the case anyway, due to CET.
2) VT-x will need to start using the PKRS load/save controls
2a) Need new get/set_pkrs hvm_funcs accessors to abstract the
VMREAD/WRITE out of common code.
2b) guest_{rd,wr}msr() and pagewalk updated to cope
3) Whatever AMD needs (if applicable).


In terms of Xen using PKS, the first piece of low hanging fruit is
removing access to the stubs by default, to prevent stray writes from
interfering with other CPUs.

Changing PKEY is a WRMSR, so not the fastest action in the world even if
it is well optimised in microcode, but modification of the stubs is not
a fastpath, so this would be entirely fine.

~Andrew


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 21:16:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 21:16:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248265.428199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxy6c-00081S-HF; Thu, 16 Dec 2021 21:16:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248265.428199; Thu, 16 Dec 2021 21:16:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxy6c-00081L-EG; Thu, 16 Dec 2021 21:16:02 +0000
Received: by outflank-mailman (input) for mailman id 248265;
 Thu, 16 Dec 2021 21:16:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxy6b-00081F-30
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 21:16:01 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5cf2feba-5eb5-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 22:15:59 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C9601618B3;
 Thu, 16 Dec 2021 21:15:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id AECE0C36AE7;
 Thu, 16 Dec 2021 21:15:56 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5cf2feba-5eb5-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639689357;
	bh=7rRmfTrToD4jqpF7Ax6Xi68uwKeLH0FDxcLqsWl3p7o=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EI69Mofl7T1nECNowTigZChE8x97q66y36IhWkmVeTtdhzmq6+TbZU3Tel8hGV2vH
	 XK6xzjVX6NhPX2P1Yy40yOXjIQiCcExG/stRAKmezN31IOsEaV8RlYTmvv0x+BZICD
	 LyGG84+shiuZCXzYuMblDCQUSIqEp3btprpIlGIlkDvaHaXRkUdF2oXSN57re+GHaR
	 zpIJZtD7En7/PM+2bqiA+e4RQ3tMRve3+f8jjpKw10xVj6zJ2a0ss7BtsvpQTV/Da9
	 0Sx41vFpMgqquEAzu25boyuxSMj1YzHp2KGbF8P/bSN01XxLQPoNYfK3TCxwKO6Plv
	 cNjyexby7Jg6A==
Date: Thu, 16 Dec 2021 13:15:56 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>, 
    xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com> <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com> <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 16 Dec 2021, Stefano Stabellini wrote:
> On Thu, 16 Dec 2021, Juergen Gross wrote:
> > On 16.12.21 03:10, Stefano Stabellini wrote:
> > > On Wed, 15 Dec 2021, Juergen Gross wrote:
> > > > On 14.12.21 18:36, Julien Grall wrote:
> > > > > Hi,
> > > > > 
> > > > > On 08/12/2021 15:55, Juergen Gross wrote:
> > > > > > Today most hypercall handlers have a return type of long, while the
> > > > > > compat ones return an int. There are a few exceptions from that rule,
> > > > > > however.
> > > > > 
> > > > > So on Arm64, I don't think you can make use of the full 64-bit because a
> > > > > 32-bit domain would not be able to see the top 32-bit.
> > > > > 
> > > > > In fact, this could potentially cause us some trouble (see [1]) in Xen.
> > > > > So it feels like the hypercalls should always return a 32-bit signed
> > > > > value
> > > > > on Arm.
> > > > 
> > > > This would break hypercalls like XENMEM_maximum_ram_page which are able
> > > > to return larger values, right?
> > > > 
> > > > > The other advantage is it would be clear that the top 32-bit are not
> > > > > usuable. Stefano, what do you think?
> > > > 
> > > > Wouldn't it make more sense to check the return value to be a sign
> > > > extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
> > > > 
> > > > The question is what to return if this is not the case. -EDOM?
> > > 
> > > 
> > > I can see where Julien is coming from: we have been trying to keep the
> > > arm32 and arm64 ABIs identical since the beginning of the project. So,
> > > like Julien, my preference would be to always return 32-bit on ARM, both
> > > aarch32 and aarch64. It would make things simple.
> > > 
> > > The case of XENMEM_maximum_ram_page is interesting but it is not a
> > > problem in reality because the max physical address size is only 40-bit
> > > for aarch32 guests, so 32-bit are always enough to return the highest
> > > page in memory for 32-bit guests.
> > 
> > You are aware that this isn't the guest's max page, but the host's?

I can see now that you meant to say that, no matter what is the max
pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
supposed to return the max memory page, which could go above the
addressibility limit of the VM.

So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
even when called by an aarch32 VM, with max IPA 40-bit.

I would imagine it could be useful if dom0 is 32-bit but domUs are
64-bit on a 64-bit hypervisor (which I think it would be a very rare
configuration on ARM.)

Then it looks like XENMEM_maximum_ram_page needs to be able to return a
value > 32-bit when called by a 32-bit guest.

The hypercall ABI follows the ARM C calling convention, so a 64-bit
value should be returned using r0 and r1. But looking at
xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets r1
today. Only r0 is set, so effectively we only support 32-bit return
values on aarch32 and for aarch32 guests.

In other words, today all hypercalls on ARM return 64-bit to 64-bit
guests and 32-bit to 32-bit guests. Which in the case of memory_op is
"technically" the correct thing to do because it matches the C
declaration in xen/include/xen/hypercall.h:

extern long
do_memory_op(
    unsigned long cmd,
    XEN_GUEST_HANDLE_PARAM(void) arg);

So...  I guess the conclusion is that on ARM do_memory_op should return
"long" although it is not actually enough for a correct implementation
of XENMEM_maximum_ram_page for aarch32 guests ?


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 21:49:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 21:49:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248284.428210 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxycP-0003N6-Q1; Thu, 16 Dec 2021 21:48:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248284.428210; Thu, 16 Dec 2021 21:48:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxycP-0003Mz-M6; Thu, 16 Dec 2021 21:48:53 +0000
Received: by outflank-mailman (input) for mailman id 248284;
 Thu, 16 Dec 2021 21:48:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxycO-0003Mt-RA
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 21:48:52 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f4a32496-5eb9-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 22:48:51 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 3ED30B8258A;
 Thu, 16 Dec 2021 21:48:50 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC109C36AE2;
 Thu, 16 Dec 2021 21:48:48 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f4a32496-5eb9-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639691329;
	bh=Yoyh1DV3KwFq9mM/Yd933A0PDob0YqJL+V1fH/zN4W4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=QGLMaCaeYO9csKB+F4wKaCUv17ElO0WUnD7ufNxurpQg3wdwksGxnLHOBMTaStoUP
	 aciEhohoZIv1gLwmeKbcu9zSDI/+HL/OXGLjnOcRcbVFVYsYb4kssJwSvNHioFiJSe
	 kEf8Df9UY0DXkiCalENIg7k9hI0STxFx4e4Z2zCAcFPHcs245KIrqESm8AqxOiMmgP
	 gMGlrMWsTrKa19caVawzXryCz4YgsPc9LJoR+M7TaichoT1Cqj0wXvWfHA4wmkx3Ww
	 /AjRXZzy5saxsTXtFAP+Zk2cMwJEItJjY8KoC6OyJ+JTnkLnXCcZaJ9Mcu7eLtB6bA
	 DbMb8II/ysAHQ==
Date: Thu, 16 Dec 2021 13:48:48 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Rahul Singh <Rahul.Singh@arm.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    xen-devel <xen-devel@lists.xenproject.org>, 
    Bertrand Marquis <Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
In-Reply-To: <AA684EED-5631-4036-ABF1-596AD61787CC@arm.com>
Message-ID: <alpine.DEB.2.22.394.2112161347320.3376@ubuntu-linux-20-04-desktop>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com> <alpine.DEB.2.22.394.2112151817190.3376@ubuntu-linux-20-04-desktop> <AA684EED-5631-4036-ABF1-596AD61787CC@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1158973397-1639691329=:3376"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1158973397-1639691329=:3376
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 16 Dec 2021, Rahul Singh wrote:
> Hi Stefano,
> 
> > On 16 Dec 2021, at 2:33 am, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > 
> > On Tue, 14 Dec 2021, Rahul Singh wrote:
> >> IO ports on ARM don't exist so all IO ports related hypercalls are going
> >> to fail on ARM when we passthrough a PCI device.
> >> Failure of xc_domain_ioport_permission(..) would turn into a critical
> >> failure at domain creation. We need to avoid this outcome, instead we
> >> want to continue with domain creation as normal even if
> >> xc_domain_ioport_permission(..) fails. XEN_DOMCTL_ioport_permission
> >> is not implemented on ARM so it would return -ENOSYS.
> >> 
> >> To solve above issue remove PCI I/O ranges property value from dom0
> >> device tree node so that dom0 linux will not allocate I/O space for PCI
> >> devices if pci-passthrough is enabled.
> >> 
> >> Another valid reason to remove I/O ranges is that PCI I/O space are not
> >> mapped to dom0 when PCI passthrough is enabled, also there is no vpci
> >> trap handler register for IO bar.
> >> 
> >> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> >> ---
> >> xen/arch/arm/domain_build.c   | 14 +++++++
> >> xen/common/device_tree.c      | 72 +++++++++++++++++++++++++++++++++++
> >> xen/include/xen/device_tree.h | 10 +++++
> >> 3 files changed, 96 insertions(+)
> >> 
> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> >> index d02bacbcd1..60f6b2c73b 100644
> >> --- a/xen/arch/arm/domain_build.c
> >> +++ b/xen/arch/arm/domain_build.c
> >> @@ -749,6 +749,11 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
> >>                 continue;
> >>         }
> >> 
> >> +        if ( is_pci_passthrough_enabled() &&
> >> +                dt_device_type_is_equal(node, "pci") )
> >> +            if ( dt_property_name_is_equal(prop, "ranges") )
> >> +                continue;
> > 
> > It looks like we are skipping the "ranges" property entirely for the PCI
> > node, is that right? Wouldn't that also remove the other (not ioports)
> > address ranges?
> 
> We are skipping the “ranges” property here to avoid setting the “ranges” property when
> pci_passthrough is enabled. We will remove only remove IO port and set the other ‘ranges” property 
> value in dt_pci_remove_io_ranges() in next if() condition.
>  
> 
> >>         res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
> >> 
> >>         if ( res )
> >> @@ -769,6 +774,15 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
> >>             if ( res )
> >>                 return res;
> >>         }
> >> +
> >> +        /*
> >> +         * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled,
> >> +         * also there is no trap handler registered for IO bar therefor remove
> >> +         * the IO range property from the device tree node for dom0.
> >> +         */
> >> +        res = dt_pci_remove_io_ranges(kinfo->fdt, node);
> >> +        if ( res )
> >> +            return res;
> > 
> > I tried to apply this patch to staging to make it easier to review but I
> > think this chuck got applied wrongly: I can see
> > dt_pci_remove_io_ranges() added to the function "handle_prop_pfdt" which
> > is for guest partial DTBs and not for dom0.
> 
> Oleksandr’s patch series was merged yesterday because of that there is conflict in applying 
> this patch. I will rebase the patch and will send it again for review.
> 
> > 
> > Is dt_pci_remove_io_ranges() meant to be called from write_properties
> > instead? It looks like it would be best to call it from
> > write_properties, maybe it could be combined with the other new check
> > just above in this patch?
> 
> Yes dt_pci_remove_io_ranges() is to be called from write_properties().

OK. In that case the only feedback that is I have is that it might be
possible to avoid the first change of this patch to skip "ranges" by
moving the call to dt_pci_remove_io_ranges() earlier in the
write_properties function.
--8323329-1158973397-1639691329=:3376--


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 21:52:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 21:52:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248289.428220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxyfQ-0004vJ-7N; Thu, 16 Dec 2021 21:52:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248289.428220; Thu, 16 Dec 2021 21:52:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxyfQ-0004vC-3Q; Thu, 16 Dec 2021 21:52:00 +0000
Received: by outflank-mailman (input) for mailman id 248289;
 Thu, 16 Dec 2021 21:51:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CyNJ=RB=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mxyfP-0004v4-9k
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 21:51:59 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63848bcf-5eba-11ec-9e60-abaf8a552007;
 Thu, 16 Dec 2021 22:51:57 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 44B1661EEF;
 Thu, 16 Dec 2021 21:51:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F3DDC36AE7;
 Thu, 16 Dec 2021 21:51:55 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63848bcf-5eba-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639691515;
	bh=bk75P97h4nWD6jek//UN5pHtK2Op57RnCQgGYyF+oTw=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=npjXcb/pbjuFvIu3l0WqxOakxucYPCJx8fZD3vZyqVptasTKuJOfXgxq+1j7IoFB7
	 2ZD+vCp+8zu4L5lVLr7rqdwABN5MvVIL+Ax39qtMnM14Re3pV7aStFrjraTREd/0CC
	 rDcGqkT0zHdADDowlNaRYYll2wRZFH3ksm+VUDVYTeLk8ww+IMXZMN8dAntbwM03hG
	 FpUn3LpeqS82d5wlbSYpHHp3OcHIez3jT2jUHgJzKrZUVx4nxTRA/fvhaP7QQjwRCD
	 AooNNwJ9OKRTVFLZXO+WGTLZOk90ARoVw3RTkjwkyKOGkPknMNyEHQnQ++di1s1sre
	 PwIAEUL5b7u+Q==
Date: Thu, 16 Dec 2021 13:51:55 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
cc: xen-devel@lists.xenproject.org, devicetree@vger.kernel.org, 
    linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, 
    Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Subject: Re: [PATCH V4 6/6] dt-bindings: xen: Clarify "reg" purpose
In-Reply-To: <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2112161351470.3376@ubuntu-linux-20-04-desktop>
References: <35ee3534-9e24-5a11-0bf1-a5dd0b640186@gmail.com> <1639136201-27530-1-git-send-email-olekstysh@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 10 Dec 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> 
> Xen on Arm has gained new support recently to calculate and report
> extended regions (unused address space) safe to use for external
> mappings. These regions are reported via "reg" property under
> "hypervisor" node in the guest device-tree. As region 0 is reserved
> for grant table space (always present), the indexes for extended
> regions are 1...N.
> 
> No device-tree bindings update is needed (except clarifying the text)
> as guest infers the presence of extended regions from the number
> of regions in "reg" property.
> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes V2 -> V3:
>    - new patch
> 
> Changes V3 -> V4:
>    - add Stefano's R-b and Rob's A-b
>    - remove sentence about ACPI for "reg" and "interrupts"
>      properties
> 
> Changes V4 -> V4.1
>    - bring the mentioning of ACPI back which, as was pointed out by Julien,
>      fits in the context:
>      https://lore.kernel.org/xen-devel/9602b019-6c20-cdc7-23f3-9e4f8fd720f6@xen.org/T/#t
>      so technically restore V3 state
>    - remove Stefano's R-b and Rob's A-b as I am not 100% sure they are
>      happy with that
> ---
>  Documentation/devicetree/bindings/arm/xen.txt | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/xen.txt b/Documentation/devicetree/bindings/arm/xen.txt
> index db5c56d..156fe10b 100644
> --- a/Documentation/devicetree/bindings/arm/xen.txt
> +++ b/Documentation/devicetree/bindings/arm/xen.txt
> @@ -7,10 +7,14 @@ the following properties:
>  	compatible = "xen,xen-<version>", "xen,xen";
>    where <version> is the version of the Xen ABI of the platform.
>  
> -- reg: specifies the base physical address and size of a region in
> -  memory where the grant table should be mapped to, using an
> -  HYPERVISOR_memory_op hypercall. The memory region is large enough to map
> -  the whole grant table (it is larger or equal to gnttab_max_grant_frames()).
> +- reg: specifies the base physical address and size of the regions in memory
> +  where the special resources should be mapped to, using an HYPERVISOR_memory_op
> +  hypercall.
> +  Region 0 is reserved for mapping grant table, it must be always present.
> +  The memory region is large enough to map the whole grant table (it is larger
> +  or equal to gnttab_max_grant_frames()).
> +  Regions 1...N are extended regions (unused address space) for mapping foreign
> +  GFNs and grants, they might be absent if there is nothing to expose.
>    This property is unnecessary when booting Dom0 using ACPI.
>  
>  - interrupts: the interrupt used by Xen to inject event notifications.
> -- 
> 2.7.4
> 


From xen-devel-bounces@lists.xenproject.org Thu Dec 16 22:03:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 22:03:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248320.428324 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxyq4-0007iB-BK; Thu, 16 Dec 2021 22:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248320.428324; Thu, 16 Dec 2021 22:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mxyq4-0007i4-8C; Thu, 16 Dec 2021 22:03:00 +0000
Received: by outflank-mailman (input) for mailman id 248320;
 Thu, 16 Dec 2021 22:02:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CQEQ=RB=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mxyq2-0007hy-GF
 for xen-devel@lists.xenproject.org; Thu, 16 Dec 2021 22:02:58 +0000
Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com
 [2a00:1450:4864:20::436])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ed1c3469-5ebb-11ec-85d3-df6b77346a89;
 Thu, 16 Dec 2021 23:02:57 +0100 (CET)
Received: by mail-wr1-x436.google.com with SMTP id a9so495813wrr.8
 for <xen-devel@lists.xenproject.org>; Thu, 16 Dec 2021 14:02:57 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id d2sm5543428wmb.31.2021.12.16.14.02.52
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 16 Dec 2021 14:02:53 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ed1c3469-5ebb-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:from:to:cc:references:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=jr113sD2CvAYYaqrKJ2RFq/931IUT0YAFGFLLTKtGbE=;
        b=Wcjg5ik9dcrXPAnVnn3yL9Bzo7AhRdMp/iBvZY/qIPLoLk0v9w99kx9EylPs7yiEcO
         gN5SJkXEjUIU0/YQQNVUOt5vP7MJDNicq9qK02n7Yx0MYOJS4+xPGHMvKvqsy9y8iaeY
         bzxVUdYKKjnC6brqYUd+odEP6YA8pKLE6pF0aS5sF8TLkcnxBj/bQfJMcf1nXcHnE8kq
         d6ZoaxYAK5vekUNNjYV0gXS1Q4qLDRVZ8NzR9rQFJCmOCZtKwd44V8Lc1HbMopSw/eik
         URiF7PqdwOSfwNWHeLxuM3Dqa4aEEspEjK8BZsIysbbbhY66h5CAqODUm0g6XMFYR8um
         pI8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:from:to:cc:references:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=jr113sD2CvAYYaqrKJ2RFq/931IUT0YAFGFLLTKtGbE=;
        b=NKvZX3VJKiTKtJ2udKBKe7z3Ud2nLAAawLf5rGglPPO+yQQIR9nV4ie/xB76aAMI45
         3nnUi566/hnsvH6S+e2gNuizmSQofSk+d1lk/52OiNPa5JPEjGGBTvf9MHhcYifzr0CL
         BhOpZXDKEJILO5ErqduFhLr0Uul1GvrirE+ev3jmp9NVx1piDmqvqFLhvgPrK9qrHgaj
         SjuJ6L7Fr0HppJLFtyjKwFe23PsjqY4FyU7Wla+cM7NJMvdh4kNvXgKirzJsOZ2XeZfZ
         jfDCGit181gQriRaauHbBHSDfWnxzQ9eybhppJLpLE12kZlUVbWhezD7hHLNOKP5jNSa
         CrkQ==
X-Gm-Message-State: AOAM5305sEylDsnmIzMUvIWVXU573iAfqmf6IS5e42dcMV4vwucc0fkW
	tn9RnMYJDx58SFo1NDJXLvQ=
X-Google-Smtp-Source: ABdhPJy46xui0iaw81h/rHG30m0c96KJf69/+cIlCYxG4WAy2Gr4Rhla2NZ9aAZgaym0KofijEzPXA==
X-Received: by 2002:a5d:456e:: with SMTP id a14mr26199wrc.256.1639692173852;
        Thu, 16 Dec 2021 14:02:53 -0800 (PST)
Subject: Re: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges)
 on Arm
From: Oleksandr <olekstysh@gmail.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
 Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Kaly Xin <Kaly.Xin@arm.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
Message-ID: <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
Date: Fri, 17 Dec 2021 00:02:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 09.12.21 22:05, Oleksandr Tyshchenko wrote:


Hello Juergen, Boris


May I please ask, are you happy (or otherwise) with current patch series 
(I assume, especially with commits #3-4)?

For the convenience:

   1. xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
- Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

   2. arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
- Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

   3. xen/balloon: Bring alloc(free)_xenballooned_pages helpers back
- Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

   4. xen/unpopulated-alloc: Add mechanism to use Xen resource
- Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

   5. arm/xen: Read extended regions from DT and init Xen resource
- Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

   6. dt-bindings: xen: Clarify "reg" purpose
- Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
- Acked-by: Rob Herring <robh@kernel.org>
- Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Hello all.
>
> You can find the RFC-V3 patch series at [1],[2] and [3].
>
> The corresponding Xen support (for both Dom0 and DomU) is already committed and
> is available in mainline Xen since the following commit:
> 57f87857dc2de452a796d6bad4f476510efd2aba libxl/arm: Add handling of extended regions for DomU
>
> The extended region (safe range) is a region of guest physical address space
> which is unused and could be safely used to create grant/foreign mappings instead
> of ballooning out real RAM pages to obtain a physical address space for creating
> these mappings (which simply results in wasting domain memory and shattering super
> pages in P2M table).
>
> The problem is that we cannot follow Linux advise which memory ranges are unused
> on Arm as there might be some identity mappings in P2M table (stage 2) the guest is not
> aware of or not all device I/O regions might be known (registered) by the time the guest
> starts creating grant/foreign mappings. This is why we need some hints from the hypervisor
> which knows all details in advance to be able to choose extended regions (which won't
> clash with other resources).
>
> The extended regions are chosen at the domain creation time and advertised to it via
> "reg" property under hypervisor node in the guest device-tree [4]. As region 0 is reserved
> for grant table space (always present), the indexes for extended regions are 1...N.
> No device tree bindings update is needed, guest infers the presence of extended regions
> from the number of regions in "reg" property.
>
> Please note the following:
> - The ACPI case is not covered for now
> - patch series was created in a way to retain existing behavior on x86
>
> The patch series is based on v5.16-rc3 and also available at [5], it was fully
> tested on Arm64 and only compile tested on x86.
>
> [1] https://lore.kernel.org/all/1627490656-1267-1-git-send-email-olekstysh@gmail.com/
>      https://lore.kernel.org/all/1627490656-1267-2-git-send-email-olekstysh@gmail.com/
> [2] https://lore.kernel.org/all/1635264312-3796-1-git-send-email-olekstysh@gmail.com/
> [3] https://lore.kernel.org/all/1637787223-21129-1-git-send-email-olekstysh@gmail.com/
> [4] https://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=docs/misc/arm/device-tree/guest.txt;hb=refs/heads/master
> [5] https://github.com/otyshchenko1/linux/commits/map_opt_ml7
>
> Oleksandr Tyshchenko (6):
>    xen/unpopulated-alloc: Drop check for virt_addr_valid() in fill_list()
>    arm/xen: Switch to use gnttab_setup_auto_xlat_frames() for DT
>    xen/balloon: Bring alloc(free)_xenballooned_pages helpers back
>    xen/unpopulated-alloc: Add mechanism to use Xen resource
>    arm/xen: Read extended regions from DT and init Xen resource
>    dt-bindings: xen: Clarify "reg" purpose
>
>   Documentation/devicetree/bindings/arm/xen.txt |  14 +--
>   arch/arm/xen/enlighten.c                      | 132 ++++++++++++++++++++++++--
>   drivers/xen/Kconfig                           |   2 +-
>   drivers/xen/balloon.c                         |  20 ++--
>   drivers/xen/unpopulated-alloc.c               |  87 ++++++++++++++++-
>   include/xen/balloon.h                         |   3 +
>   include/xen/xen.h                             |  16 ++++
>   7 files changed, 245 insertions(+), 29 deletions(-)
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Thu Dec 16 23:35:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 16 Dec 2021 23:35:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248337.428383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my0Gn-0001PD-K7; Thu, 16 Dec 2021 23:34:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248337.428383; Thu, 16 Dec 2021 23:34:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my0Gn-0001P6-Gh; Thu, 16 Dec 2021 23:34:41 +0000
Received: by outflank-mailman (input) for mailman id 248337;
 Thu, 16 Dec 2021 23:34:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my0Gm-0001Or-81; Thu, 16 Dec 2021 23:34:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my0Gm-0002Tz-5k; Thu, 16 Dec 2021 23:34:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my0Gl-0001qP-QS; Thu, 16 Dec 2021 23:34:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1my0Gl-0001cH-Py; Thu, 16 Dec 2021 23:34:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kRjyB8/TI+jdV9cx4l5D9dm3K2zAWETgMccbnTY15fI=; b=f9oX9IQTUk1iMKsuca0wNtma+q
	uBNwOgPDpWgv/AHsX1GjHS9pezFKkrw23p7E18pTa5sganiWJTBIgVt/3l/3i0R8DOrXJgGk/BwDD
	vpybIa8WLdHDMqBk5PaRGJTAb+s/yIW1ZjWxRaMIX7ZNc0KnwwEOrqPTgEAFgG2ljk2Y=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167448-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167448: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:guest-localmigrate/x10:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
X-Osstest-Versions-That:
    xen=d828caa9aeee80c59a35f662f875f6573e9b532f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 16 Dec 2021 23:34:39 +0000

flight 167448 xen-unstable real [real]
flight 167453 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167448/
http://logs.test-lab.xenproject.org/osstest/logs/167453/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167453-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167411

Tests which did not succeed, but are not blocking:
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 18 guest-localmigrate/x10 fail like 167402
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167411
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167411
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167411
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167411
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167411
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167411
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167411
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167411
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167411
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167411
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24
baseline version:
 xen                  d828caa9aeee80c59a35f662f875f6573e9b532f

Last test of basis   167411  2021-12-14 12:17:05 Z    2 days
Failing since        167418  2021-12-14 21:38:12 Z    2 days    3 attempts
Testing same since   167448  2021-12-16 13:05:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>
  Rahul Singh <rahul.singh@arm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              fail    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   d828caa9ae..dc27c174b2  dc27c174b2fc1ba0697ed96dc96066c272e09c24 -> master


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 00:33:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 00:33:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248358.428433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my1Bc-00012K-AY; Fri, 17 Dec 2021 00:33:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248358.428433; Fri, 17 Dec 2021 00:33:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my1Bc-00012D-7i; Fri, 17 Dec 2021 00:33:24 +0000
Received: by outflank-mailman (input) for mailman id 248358;
 Fri, 17 Dec 2021 00:33:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my1Ba-000123-6S; Fri, 17 Dec 2021 00:33:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my1Ba-00046l-3g; Fri, 17 Dec 2021 00:33:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my1BZ-0004lg-LH; Fri, 17 Dec 2021 00:33:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1my1BZ-0004nP-Kf; Fri, 17 Dec 2021 00:33:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=G7022vhqjJiBMMMa2wMwWtiEv1JrR00ttVVfr72jp9w=; b=j/DhATiugBJW/8LM62qT+VM4fC
	sNwa8A3spw+deLtI6lCjMNOlAHCRAAo/4Ozm2vacQ37O57lW727n5k4ZFLNJfH9n6jiLcneDiwDWb
	rUEHi2DJFeNKhzqeYHG6aMOHW2Aj7Ld48yFZAunAkIOK64pKOsaetKT/4CzAdUlojPvc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167450-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167450: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=b451c6908878c448c2a2aa6e9ca2a2dfe078fbb8
X-Osstest-Versions-That:
    ovmf=e6ea1464a846b3f012a9ca07d92924c2e1b88334
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 00:33:21 +0000

flight 167450 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167450/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 b451c6908878c448c2a2aa6e9ca2a2dfe078fbb8
baseline version:
 ovmf                 e6ea1464a846b3f012a9ca07d92924c2e1b88334

Last test of basis   167445  2021-12-16 04:45:51 Z    0 days
Testing same since   167450  2021-12-16 18:10:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Nhi Pham <nhi@os.amperecomputing.com>
  Nhi Pham via groups.io <nhi=os.amperecomputing.com@groups.io>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e6ea1464a8..b451c69088  b451c6908878c448c2a2aa6e9ca2a2dfe078fbb8 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 02:46:00 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 02:46:00 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248367.428445 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3FO-0000pO-20; Fri, 17 Dec 2021 02:45:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248367.428445; Fri, 17 Dec 2021 02:45:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3FN-0000pG-Sk; Fri, 17 Dec 2021 02:45:25 +0000
Received: by outflank-mailman (input) for mailman id 248367;
 Fri, 17 Dec 2021 02:45:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W3Ie=RC=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1my3FM-0000pA-KE
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 02:45:24 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 60ef3376-5ee3-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 03:45:22 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 2B24FB826A3;
 Fri, 17 Dec 2021 02:45:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BB4CC36AE2;
 Fri, 17 Dec 2021 02:45:19 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 60ef3376-5ee3-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639709119;
	bh=8QVZJDOPniwAZkXBcz6X6ZxsEmS3i2SJkY6aH8/wrxM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=FvHVulrBF2PZnoKMwJjpIIalITMg7lTPrXSLnZphvnOGpsI9m4w4b96wMaChm+wlC
	 TbuTwtOKSdnrzFgpCGF8hln3569lvscDCetHa6evcatJHhmUHPZNSpLy/WkmtTBl8t
	 PA3gSAM7THPr2Ek9/ZXSbgrcQL+0tmJjgF5ahtHeD3tko64KDK5H3XP765AHEuPAq4
	 ka/Q9BHSyk4unwg02GN02afaYeNZOIqtKr+rULrDS7mergCjJksRP9VPH+HSNnGvTk
	 5pd3GllbFyvOF628sSvbmjs991aBKIta8wDEfsCkuvXd7QYejSejBWO8lHclcK49tO
	 nshgtqCmGtzrA==
Date: Thu, 16 Dec 2021 18:45:11 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 2/5] xen/arm: add generic SCI mediator framework
In-Reply-To: <c0afe4837fe99e7f7921fc43b130aa2234f234be.1639472078.git.oleksii_moisieiev@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112161831230.1662642@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <c0afe4837fe99e7f7921fc43b130aa2234f234be.1639472078.git.oleksii_moisieiev@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> This patch adds the basic framework for SCI mediator.
> SCI is System Control Interface, which is designed to redirect
> requests for the Hardware (such as power-domain/clock/resets etc)
> from the Domains to the firmware. Originally, cpg should be passed
> to the domain so it can work with power-domains/clocks/resets etc.
> Considering that cpg can't be split between the Domains, we get the
> limitation that the devices, which are using power-domains/clocks/resets
> etc, couldn't be split between the domains.
> The solution is to move the power-domain/clock/resets etc to the
> Firmware (such as SCP firmware or ATF) and provide interface for the Domains.
> XEN shoud have an entity, caled SCI-Mediator, which is responsible for messages
> redirection between Domains and Firmware and for permission handling.
> 
> This is how it works: user can build XEN with multiple SCI mediators.
> See the next patches, where SCMI-SMC mediator is introduced.
> SCI mediator register itself with REGISTER_SCI_MEDIATOR() macro.
> 
> At run-time, during initialization, framework calls probe for the first
> matching device in the device-tree. When no device-tree is present - the
> first registered mediator should be probed.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>  MAINTAINERS                    |   6 ++
>  xen/arch/arm/Kconfig           |   8 ++
>  xen/arch/arm/Makefile          |   1 +
>  xen/arch/arm/domain.c          |  24 +++++
>  xen/arch/arm/domain_build.c    |  11 +++
>  xen/arch/arm/platforms/rcar3.c |   3 +-
>  xen/arch/arm/sci/Makefile      |   1 +
>  xen/arch/arm/sci/sci.c         | 128 ++++++++++++++++++++++++++
>  xen/arch/arm/setup.c           |   1 +
>  xen/arch/arm/xen.lds.S         |   7 ++
>  xen/include/asm-arm/domain.h   |   4 +
>  xen/include/asm-arm/sci/sci.h  | 162 +++++++++++++++++++++++++++++++++
>  xen/include/public/arch-arm.h  |  10 ++
>  13 files changed, 365 insertions(+), 1 deletion(-)
>  create mode 100644 xen/arch/arm/sci/Makefile
>  create mode 100644 xen/arch/arm/sci/sci.c
>  create mode 100644 xen/include/asm-arm/sci/sci.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e43dc0edce..5f96ea35ba 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -512,6 +512,12 @@ S:	Supported
>  F:	xen/arch/arm/tee/
>  F:	xen/include/asm-arm/tee
>  
> +SCI MEDIATORS
> +M:	Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> +S:	Supported
> +F:	xen/arch/arm/sci
> +F:	xen/include/asm-arm/sci
> +
>  TOOLSTACK
>  M:	Wei Liu <wl@xen.org>
>  S:	Supported
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..186e1db389 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -106,6 +106,14 @@ config TEE
>  
>  source "arch/arm/tee/Kconfig"
>  
> +config SCI
> +	bool "Enable SCI mediators support"
> +	default n
> +	help
> +	  This option enables generic SCI (System Control Interface) mediators
> +	  support. It allows guests to control system resourcess via one of
> +	  SCI mediators implemented in XEN.
> +
>  endmenu
>  
>  menu "ARM errata workaround via the alternative framework"
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 07f634508e..6366ff55e5 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -8,6 +8,7 @@ obj-y += platforms/
>  endif
>  obj-$(CONFIG_TEE) += tee/
>  obj-$(CONFIG_HAS_VPCI) += vpci.o
> +obj-$(CONFIG_SCI) += sci/
>  
>  obj-$(CONFIG_HAS_ALTERNATIVE) += alternative.o
>  obj-y += bootfdt.init.o
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 96e1b23550..80d0a23767 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -34,6 +34,7 @@
>  #include <asm/platform.h>
>  #include <asm/procinfo.h>
>  #include <asm/regs.h>
> +#include <asm/sci/sci.h>
>  #include <asm/tee/tee.h>
>  #include <asm/vfp.h>
>  #include <asm/vgic.h>
> @@ -688,6 +689,13 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
>          return -EINVAL;
>      }
>  
> +    if ( config->arch.sci_type != XEN_DOMCTL_CONFIG_SCI_NONE &&
> +         config->arch.sci_type != sci_get_type() )
> +    {
> +        dprintk(XENLOG_INFO, "Unsupported SCI type\n");
> +        return -EINVAL;
> +    }
> +
>      return 0;
>  }
>  
> @@ -764,6 +772,15 @@ int arch_domain_create(struct domain *d,
>          /* At this stage vgic_reserve_virq should never fail */
>          if ( !vgic_reserve_virq(d, GUEST_EVTCHN_PPI) )
>              BUG();
> +
> +        if ( config->arch.sci_type != XEN_DOMCTL_CONFIG_SCI_NONE )
> +        {
> +            if ( (rc = sci_domain_init(d, config->arch.sci_type)) != 0)
> +                goto fail;
> +
> +            if ( (rc = sci_get_channel_info(d, &config->arch)) != 0)
> +                goto fail;
> +        }
>      }
>  
>      /*
> @@ -796,6 +813,7 @@ void arch_domain_destroy(struct domain *d)
>      domain_vgic_free(d);
>      domain_vuart_free(d);
>      free_xenheap_page(d->shared_info);
> +    sci_domain_destroy(d);
>  #ifdef CONFIG_ACPI
>      free_xenheap_pages(d->arch.efi_acpi_table,
>                         get_order_from_bytes(d->arch.efi_acpi_len));
> @@ -996,6 +1014,7 @@ enum {
>      PROG_xen,
>      PROG_page,
>      PROG_mapping,
> +    PROG_sci,
>      PROG_done,
>  };
>  
> @@ -1056,6 +1075,11 @@ int domain_relinquish_resources(struct domain *d)
>          if ( ret )
>              return ret;
>  
> +    PROGRESS(sci):
> +        ret = sci_relinquish_resources(d);
> +        if ( ret )
> +            return ret;
> +
>      PROGRESS(done):
>          break;
>  
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d02bacbcd1..38874615dd 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -22,6 +22,7 @@
>  #include <asm/kernel.h>
>  #include <asm/setup.h>
>  #include <asm/tee/tee.h>
> +#include <asm/sci/sci.h>
>  #include <asm/platform.h>
>  #include <asm/psci.h>
>  #include <asm/setup.h>
> @@ -1894,6 +1895,10 @@ static int __init handle_device(struct domain *d, struct dt_device_node *dev,
>                  return res;
>              }
>          }
> +
> +        res = sci_add_dt_device(d, dev);
> +        if ( res < 0 )
> +            return res;
>      }

It would be good to add the call to dom0less domUs too


>      res = handle_device_interrupts(d, dev, need_mapping);
> @@ -3075,6 +3080,10 @@ static int __init construct_dom0(struct domain *d)
>      if ( rc < 0 )
>          return rc;
>  
> +    rc = sci_domain_init(d, sci_get_type());
> +    if ( rc < 0 )
> +        return rc;

same here


>      if ( acpi_disabled )
>          rc = prepare_dtb_hwdom(d, &kinfo);
>      else
> @@ -3109,6 +3118,8 @@ void __init create_dom0(void)
>      dom0_cfg.arch.tee_type = tee_get_type();
>      dom0_cfg.max_vcpus = dom0_max_vcpus();
>  
> +    dom0_cfg.arch.sci_type = sci_get_type();

and here


>      if ( iommu_enabled )
>          dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
>  
> diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.c
> index d740145c71..a268b09454 100644
> --- a/xen/arch/arm/platforms/rcar3.c
> +++ b/xen/arch/arm/platforms/rcar3.c
> @@ -18,10 +18,11 @@
>   */
>  
>  #include <asm/platform.h>
> +#include <asm/sci/sci.h>
>  
>  static bool rcar3_smc(struct cpu_user_regs *regs)
>  {
> -    return false;
> +    return sci_handle_call(current->domain, regs);
>  }
>  
>  static const char *const rcar3_dt_compat[] __initconst =
> diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> new file mode 100644
> index 0000000000..837dc7492b
> --- /dev/null
> +++ b/xen/arch/arm/sci/Makefile
> @@ -0,0 +1 @@
> +obj-y += sci.o
> diff --git a/xen/arch/arm/sci/sci.c b/xen/arch/arm/sci/sci.c
> new file mode 100644
> index 0000000000..5961b4cd5d
> --- /dev/null
> +++ b/xen/arch/arm/sci/sci.c
> @@ -0,0 +1,128 @@
> +/*
> + * xen/arch/arm/sci/sci.c
> + *
> + * Generic part of SCI mediator driver
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021, EPAM Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <xen/errno.h>
> +#include <xen/init.h>
> +#include <xen/sched.h>
> +#include <xen/types.h>
> +
> +#include <asm/sci/sci.h>
> +
> +extern const struct sci_mediator_desc _sscimediator[], _escimediator[];
> +static const struct sci_mediator_desc __read_mostly *cur_mediator;
> +
> +bool sci_handle_call(struct domain *d, void *args)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return false;
> +
> +    return cur_mediator->ops->handle_call(d, args);
> +}
> +
> +int sci_domain_init(struct domain *d, uint16_t sci_type)
> +{
> +    if ( sci_type == XEN_DOMCTL_CONFIG_SCI_NONE )
> +        return 0;
> +
> +    if ( unlikely(!cur_mediator) )
> +        return -ENODEV;
> +
> +    if ( cur_mediator->sci_type != sci_type )
> +        return -EINVAL;
> +
> +    return cur_mediator->ops->domain_init(d);
> +}
> +
> +void sci_domain_destroy(struct domain *d)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return;
> +
> +    cur_mediator->ops->domain_destroy(d);
> +}
> +
> +int sci_relinquish_resources(struct domain *d)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return 0;
> +
> +    return cur_mediator->ops->relinquish_resources(d);
> +}
> +
> +
> +int sci_add_dt_device(struct domain *d, struct dt_device_node *dev)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return 0;
> +
> +    return cur_mediator->ops->add_dt_device(d, dev);
> +}
> +
> +int sci_get_channel_info(struct domain *d,
> +                         struct xen_arch_domainconfig *config)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return 0;
> +
> +    return cur_mediator->ops->get_channel_info(d->arch.sci, config);
> +}
> +
> +uint16_t sci_get_type(void)
> +{
> +    if ( unlikely(!cur_mediator) )
> +        return XEN_DOMCTL_CONFIG_SCI_NONE;
> +
> +    return cur_mediator->sci_type;
> +}
> +
> +static int __init sci_init(void)
> +{
> +    const struct sci_mediator_desc *desc;
> +    struct dt_device_node *dt = NULL;
> +
> +    for ( desc = _sscimediator; desc != _escimediator; desc++ )
> +    {
> +        if ( likely(dt_host) )

I think you can assume that dt_host is correctly set, right?
Instead of this check, I would just add:

    if ( !acpi_disabled )
        return -ENODEV;

at the beginning of sci_init


> +        {
> +            dt = dt_find_matching_node(dt_host, desc->dt_match);
> +            if ( !dt )
> +                continue;
> +        }
> +
> +        if ( desc->ops->probe(dt) )
> +        {
> +            printk(XENLOG_INFO "Using SCI mediator for %s\n", desc->name);
> +            cur_mediator = desc;
> +            return 0;
> +        }
> +    }
> +
> +    return 0;
> +}
> +
> +__initcall(sci_init);
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index d5d0792ed4..201de01411 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -50,6 +50,7 @@
>  #include <asm/cpufeature.h>
>  #include <asm/platform.h>
>  #include <asm/procinfo.h>
> +#include <asm/sci/sci.h>
>  #include <asm/setup.h>
>  #include <xsm/xsm.h>
>  #include <asm/acpi.h>
> diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> index 08016948ab..3683f4821f 100644
> --- a/xen/arch/arm/xen.lds.S
> +++ b/xen/arch/arm/xen.lds.S
> @@ -142,6 +142,13 @@ SECTIONS
>        _eteemediator = .;
>    } :text
>  
> +  . = ALIGN(8);
> +  .scimediator.info : {
> +      _sscimediator = .;
> +      *(.scimediator.info)
> +      _escimediator = .;
> +  } :text
> +
>    . = ALIGN(PAGE_SIZE);             /* Init code and data */
>    __init_begin = .;
>    .init.text : {
> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index 9b3647587a..d9b164017f 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -89,6 +89,10 @@ struct arch_domain
>  #ifdef CONFIG_TEE
>      void *tee;
>  #endif
> +
> +#ifdef CONFIG_SCI
> +    void *sci;
> +#endif
>  }  __cacheline_aligned;
>  
>  struct arch_vcpu
> diff --git a/xen/include/asm-arm/sci/sci.h b/xen/include/asm-arm/sci/sci.h
> new file mode 100644
> index 0000000000..aeff689c72
> --- /dev/null
> +++ b/xen/include/asm-arm/sci/sci.h
> @@ -0,0 +1,162 @@
> +/*
> + * xen/include/asm-arm/sci/sci.h
> + *
> + * Generic part of the SCI (System Control Interface) subsystem.
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021, EPAM Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef __ASM_ARM_SCI_H
> +#define __ASM_ARM_SCI_H
> +
> +#include <xen/lib.h>
> +#include <xen/types.h>
> +#include <xen/device_tree.h>
> +
> +#ifdef CONFIG_SCI
> +
> +struct sci_mediator_ops {
> +
> +    /*
> +     * Probe for SCI. Should return true if SCI found and
> +     * mediator is initialized.
> +     */
> +    bool (*probe)(struct dt_device_node *scmi_node);
> +
> +    /*
> +     * Called during domain construction if toolstack requests to enable
> +     * SCI support so mediator can inform SCP-firmware about new
> +     * guest and create own structures for the new domain.
> +     */
> +    int (*domain_init)(struct domain *d);
> +
> +    /*
> +     * Called during domain destruction, releases all resources, that
> +     * were allocated by the mediator.
> +     */
> +    void (*domain_destroy)(struct domain *d);
> +
> +    /*
> +     * Called during parsing partial device-sci for the domain.
> +     * Passing device_node so mediator could process the device and
> +     * mark the device as related to the domain if needed.
> +     */
> +    int (*add_dt_device)(struct domain *d, struct dt_device_node *dev);
> +
> +    /*
> +     * Called during domain destruction to relinquish resources used
> +     * by mediator itself. This function can return -ERESTART to indicate
> +     * that it does not finished work and should be called again.
> +     */
> +    int (*relinquish_resources)(struct domain *d);
> +
> +    /* Handle call for current domain */
> +    bool (*handle_call)(struct domain *d, void *regs);
> +
> +    /* Gets channel configuration and store it in domainconfig */
> +    int (*get_channel_info)(void *sci_ops,
> +                            struct xen_arch_domainconfig *config);

get_channel_info is the only function I don't understand among these...
what is supposed to be stored in struct xen_arch_domainconfig, just
sci_agent_paddr?

Also, it seems to be only called right after sci_domain_init, so can't
the "get_channel_info" operation just be done as part of domain_init?



> +};
> +
> +struct sci_mediator_desc {
> +    /* Printable name of the SCI. */
> +    const char *name;
> +
> +    /* Mediator callbacks as described above. */
> +    const struct sci_mediator_ops *ops;
> +
> +    /*
> +     * ID of SCI. Corresponds to xen_arch_domainconfig.sci_type.
> +     * Should be one of XEN_DOMCTL_CONFIG_SCI_xxx
> +     */
> +    uint16_t sci_type;
> +
> +    /* Match structure to init mediator */
> +    const struct dt_device_match *dt_match;
> +
> +};
> +
> +int sci_domain_init(struct domain *d, uint16_t sci_type);
> +void sci_domain_destroy(struct domain *d);
> +int sci_add_dt_device(struct domain *d, struct dt_device_node *dev);
> +int sci_relinquish_resources(struct domain *d);
> +bool sci_handle_call(struct domain *d, void *args);
> +int sci_get_channel_info(struct domain *d,
> +                         struct xen_arch_domainconfig *config);
> +uint16_t sci_get_type(void);
> +
> +#define REGISTER_SCI_MEDIATOR(_name, _namestr, _type, _match, _ops) \
> +static const struct sci_mediator_desc __sci_desc_##_name __used     \
> +__section(".scimediator.info") = {                                  \
> +    .name = _namestr,                                               \
> +    .ops = _ops,                                                    \
> +    .sci_type = _type,                                              \
> +    .dt_match = _match                                              \
> +}
> +
> +#else
> +#include <public/errno.h>
> +
> +static inline int sci_domain_init(struct domain *d, uint16_t sci_type)
> +{
> +    if ( likely(sci_type == XEN_DOMCTL_CONFIG_SCI_NONE) )
> +        return 0;
> +
> +    return -XEN_ENODEV;
> +}
> +
> +static inline void sci_domain_destroy(struct domain *d)
> +{
> +}
> +
> +static inline int sci_add_dt_device(struct domain *d,
> +                                    struct dt_device_node *dev)
> +{
> +    return 0;
> +}
> +
> +static inline int sci_relinquish_resources(struct domain *d)
> +{
> +    return 0;
> +}
> +
> +static inline bool sci_handle_call(struct domain *d, void *args)
> +{
> +    return false;
> +}
> +
> +static inline int sci_get_channel_info(struct domain *d,
> +                                       struct xen_arch_domainconfig *config)
> +{
> +    return 0;
> +}
> +
> +static inline uint16_t sci_get_type(void)
> +{
> +    return XEN_DOMCTL_CONFIG_SCI_NONE;
> +}
> +
> +#endif  /* CONFIG_SCI */
> +
> +#endif /* __ASM_ARM_SCI_H */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 94b31511dd..9180be5e86 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -314,12 +314,16 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>  #define XEN_DOMCTL_CONFIG_TEE_NONE      0
>  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>  
> +#define XEN_DOMCTL_CONFIG_SCI_NONE      0
> +
>  struct xen_arch_domainconfig {
>      /* IN/OUT */
>      uint8_t gic_version;
>      /* IN */
>      uint16_t tee_type;
>      /* IN */
> +    uint8_t sci_type;

sci_type is uint16_t everywhere else


> +    /* IN */
>      uint32_t nr_spis;
>      /*
>       * OUT
> @@ -335,6 +339,12 @@ struct xen_arch_domainconfig {
>       *
>       */
>      uint32_t clock_frequency;
> +
> +    /* Sets shared address to sw domains.
> +     * This information is needed to set correct channel in Domain partial
> +     * device-tree
> +     */
> +    uint64_t sci_agent_paddr;
>  };
>  #endif /* __XEN__ || __XEN_TOOLS__ */



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 02:47:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 02:47:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248371.428456 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3Ha-0001QM-Cb; Fri, 17 Dec 2021 02:47:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248371.428456; Fri, 17 Dec 2021 02:47:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3Ha-0001QF-9O; Fri, 17 Dec 2021 02:47:42 +0000
Received: by outflank-mailman (input) for mailman id 248371;
 Fri, 17 Dec 2021 02:47:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3HY-0001Q4-IQ; Fri, 17 Dec 2021 02:47:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3HY-0008Lu-Gj; Fri, 17 Dec 2021 02:47:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3HY-0002gO-6e; Fri, 17 Dec 2021 02:47:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1my3HY-0000i7-6D; Fri, 17 Dec 2021 02:47:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Mv+UjpG4VqCMNm9Y91mHkKQcsl1YOgIBQXaX4+fhSUc=; b=eLuRb3BKGUobmXNJU0JOBaRV3P
	vdb9FxsV/QsEHjCwlcWBZOyo8T8Lj8wSJwnu+mZowc711WeR+oG9Q/CTph6hLOs9hoz1GWcqR94U1
	UikB4+FNoR4jvB2R5FLGBPs/MSCkqNR3ceyK6fXBZC8FTimWMnGc+TDRwhdP74bXE/CI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167454-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167454: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=4feacc95265a3d786753ed1532c77eb382630f78
X-Osstest-Versions-That:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 02:47:40 +0000

flight 167454 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167454/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  4feacc95265a3d786753ed1532c77eb382630f78
baseline version:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24

Last test of basis   167437  2021-12-15 19:01:40 Z    1 days
Testing same since   167454  2021-12-16 22:00:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   dc27c174b2..4feacc9526  4feacc95265a3d786753ed1532c77eb382630f78 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 02:55:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 02:55:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248381.428467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3Oo-00037R-DO; Fri, 17 Dec 2021 02:55:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248381.428467; Fri, 17 Dec 2021 02:55:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my3Oo-00037K-90; Fri, 17 Dec 2021 02:55:10 +0000
Received: by outflank-mailman (input) for mailman id 248381;
 Fri, 17 Dec 2021 02:55:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3On-00037A-5U; Fri, 17 Dec 2021 02:55:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3Om-0008Sq-Uo; Fri, 17 Dec 2021 02:55:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my3Om-0002zi-Ky; Fri, 17 Dec 2021 02:55:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1my3Om-0006l6-KW; Fri, 17 Dec 2021 02:55:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=90Hjyu7jMK25GOjq2srKe/a0rJuQBx1i4Xy4Wj1jphs=; b=q0KvGJkmzYMabIiYKui7lvjNB6
	iSSbbvDGAdJpVltn5KxlZwf/oNc/AN5beGSvrQy/dPancRZCob051R5+URZfsy1q0b/nyuBQosIQp
	T50pNCzUaFYJlLjraRgG6pLpjF5Sc2KPnE7Mh6y0Lx5PqtrkVXKro1eed+lKyk9GnIEI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167449-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167449: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=c32c40ff80928cfcea7435e27330cb995f6bfb67
X-Osstest-Versions-That:
    linux=7f70428f0109470aa9177d1a9e5ce02de736f480
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 02:55:08 +0000

flight 167449 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167449/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167422
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167422
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167422
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167422
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167422
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167422
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167422
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167422
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167422
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167422
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167422
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167422
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                c32c40ff80928cfcea7435e27330cb995f6bfb67
baseline version:
 linux                7f70428f0109470aa9177d1a9e5ce02de736f480

Last test of basis   167422  2021-12-15 01:11:38 Z    2 days
Testing same since   167449  2021-12-16 16:13:05 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7f70428f0109..c32c40ff8092  c32c40ff80928cfcea7435e27330cb995f6bfb67 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 05:25:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 05:25:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248394.428478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my5jl-0003B7-IR; Fri, 17 Dec 2021 05:24:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248394.428478; Fri, 17 Dec 2021 05:24:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my5jl-0003B0-FL; Fri, 17 Dec 2021 05:24:57 +0000
Received: by outflank-mailman (input) for mailman id 248394;
 Fri, 17 Dec 2021 05:24:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1my5jj-0003Ae-LA
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 05:24:55 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a9f1ed38-5ef9-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 06:24:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EDC641F3A1;
 Fri, 17 Dec 2021 05:24:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B4FB613C60;
 Fri, 17 Dec 2021 05:24:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iwtUKiQfvGFRNQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 05:24:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a9f1ed38-5ef9-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639718692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KrLwFXrOXNgdZGzFcZIgGi/2ArwW6pwqm5lJFKjfhSU=;
	b=Jlo0evCcAMtD0Q0VJxCyj0YkI3i8H5AjHwF0G0dcfqLL1ZQD3oeke2ImMQn7W8gmLs6nU9
	uI6v1KGfGHot4OrDNAEX3VL3P1Ajn9ym1psgYbC1RGJi0T29lw5VI6f6iSHfpPM4r4eV4d
	vbXHiO1crxmaMrdK+9BLsbZOIDXvniE=
To: Andrew Cooper <amc96@srcf.net>, Anthony PERARD
 <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
 <42048d21-c02e-9fea-b228-7ffc60009be9@srcf.net>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
Message-ID: <ed48b603-b484-4544-f12a-1e816b6c007d@suse.com>
Date: Fri, 17 Dec 2021 06:24:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <42048d21-c02e-9fea-b228-7ffc60009be9@srcf.net>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="vbbsecW2qHdYBEwt65FPxQuc8YOsffWK9"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--vbbsecW2qHdYBEwt65FPxQuc8YOsffWK9
Content-Type: multipart/mixed; boundary="xCGTv6OJ3oygMCpknu4fYg2mLOy6FyHvT";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <amc96@srcf.net>, Anthony PERARD
 <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
 Julien Grall <julien@xen.org>
Message-ID: <ed48b603-b484-4544-f12a-1e816b6c007d@suse.com>
Subject: Re: [XEN PATCH 36/57] tools/xenstore: Cleanup makefile
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-37-anthony.perard@citrix.com>
 <42048d21-c02e-9fea-b228-7ffc60009be9@srcf.net>
In-Reply-To: <42048d21-c02e-9fea-b228-7ffc60009be9@srcf.net>

--xCGTv6OJ3oygMCpknu4fYg2mLOy6FyHvT
Content-Type: multipart/mixed;
 boundary="------------7254733AC05BA0E70E6D90C5"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------7254733AC05BA0E70E6D90C5
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 16.12.21 19:34, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
>> Regroup *FLAGS together, use $(LDLIBS).
>>
>> Remove $(LDLIBS_xenstored) which was the wrong name name as it doesn't=

>> decribe how to link to a potential libxenstored.so, instead add the
>> value to $(LDLIBS) of xenstored.
>>
>> Add SYSTEMD_LIBS into $(LDLIBS) instead of $(LDFLAGS).
>>
>> Remove the "-I." from $(CFLAGS), it shouldn't be needed.
>>
>> Removed $(CFLAGS-y) and $(LDFLAGS-y). $(CFLAGS-y) is already included
>> in $(CFLAGS) and both aren't used anyway.
>>
>> Rename ALL_TARGETS to TARGETS.
>> Only add programmes we want to build in $(TARGETS), not phony-targets
>> (replace "clients").
>>
>> Store all `xenstored` objs into $(XENSTORED_OBJS-y).
>>
>> Replace one $< by $^ even if there's only one dependency,
>> (xenstore-control).
>>
>> clean: "init-xenstore-domain" isn't built here, so stop trying to
>> remove it, remove $(TARGETS).
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>> ---
>>   tools/xenstore/Makefile | 81 ++++++++++++++++++++++-----------------=
--
>>   1 file changed, 44 insertions(+), 37 deletions(-)
>>
>> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
>> index 292b478fa1..7fe1d9c1e2 100644
>> --- a/tools/xenstore/Makefile
>> +++ b/tools/xenstore/Makefile
>> @@ -5,7 +5,6 @@ MAJOR =3D 3.0
>>   MINOR =3D 3
>=20
> Actually, shouldn't this MAJOR/MINOR be dropped now that libxenstore
> moved to tools/libs ?

Yes, you are right. They should be dropped.

>=20
> It's definitely wrong now, seeing as we bumped to 4.0 for Xen 4.16.
>=20
>>  =20
>>   CFLAGS +=3D -Werror
>> -CFLAGS +=3D -I.
>>   # Include configure output (config.h)
>>   CFLAGS +=3D -include $(XEN_ROOT)/tools/config.h
>>   CFLAGS +=3D -I./include
>> @@ -16,36 +15,53 @@ CFLAGS +=3D $(CFLAGS_libxentoolcore)
>>   CFLAGS +=3D -DXEN_LIB_STORED=3D"\"$(XEN_LIB_STORED)\""
>>   CFLAGS +=3D -DXEN_RUN_STORED=3D"\"$(XEN_RUN_STORED)\""
>>  =20
>> -CFLAGS  +=3D $(CFLAGS-y)
>> -LDFLAGS +=3D $(LDFLAGS-y)
>> +ifdef CONFIG_STUBDOM
>> +CFLAGS +=3D -DNO_SOCKETS=3D1
>> +endif
>>  =20
>> -CLIENTS :=3D xenstore-exists xenstore-list xenstore-read xenstore-rm =
xenstore-chmod
>> -CLIENTS +=3D xenstore-write xenstore-ls xenstore-watch
>> +XENSTORED_OBJS-y :=3D xenstored_core.o xenstored_watch.o xenstored_do=
main.o
>> +XENSTORED_OBJS-y +=3D xenstored_transaction.o xenstored_control.o
>> +XENSTORED_OBJS-y +=3D xs_lib.o talloc.o utils.o tdb.o hashtable.o
>>  =20
>> -XENSTORED_OBJS =3D xenstored_core.o xenstored_watch.o xenstored_domai=
n.o
>> -XENSTORED_OBJS +=3D xenstored_transaction.o xenstored_control.o
>> -XENSTORED_OBJS +=3D xs_lib.o talloc.o utils.o tdb.o hashtable.o
>> +XENSTORED_OBJS-$(CONFIG_Linux) +=3D xenstored_posix.o
>> +XENSTORED_OBJS-$(CONFIG_SunOS) +=3D xenstored_solaris.o xenstored_pos=
ix.o xenstored_probes.o
>> +XENSTORED_OBJS-$(CONFIG_NetBSD) +=3D xenstored_posix.o
>> +XENSTORED_OBJS-$(CONFIG_FreeBSD) +=3D xenstored_posix.o
>> +XENSTORED_OBJS-$(CONFIG_MiniOS) +=3D xenstored_minios.o
>>  =20
>> -XENSTORED_OBJS_$(CONFIG_Linux) =3D xenstored_posix.o
>> -XENSTORED_OBJS_$(CONFIG_SunOS) =3D xenstored_solaris.o xenstored_posi=
x.o xenstored_probes.o
>> -XENSTORED_OBJS_$(CONFIG_NetBSD) =3D xenstored_posix.o
>> -XENSTORED_OBJS_$(CONFIG_FreeBSD) =3D xenstored_posix.o
>> -XENSTORED_OBJS_$(CONFIG_MiniOS) =3D xenstored_minios.o
>> +$(XENSTORED_OBJS-y): CFLAGS +=3D $(CFLAGS_libxengnttab)
>>  =20
>> -XENSTORED_OBJS +=3D $(XENSTORED_OBJS_y)
>> -LDLIBS_xenstored +=3D -lrt
>> +xenstored: LDLIBS +=3D $(LDLIBS_libxenevtchn)
>> +xenstored: LDLIBS +=3D $(LDLIBS_libxengnttab)
>> +xenstored: LDLIBS +=3D $(LDLIBS_libxenctrl)
>> +xenstored: LDLIBS +=3D -lrt
>> +xenstored: LDLIBS +=3D $(SOCKET_LIBS)
>>  =20
>> -ALL_TARGETS =3D clients
>> -ifeq ($(XENSTORE_XENSTORED),y)
>> -ALL_TARGETS +=3D xs_tdb_dump xenstored
>> +ifeq ($(CONFIG_SYSTEMD),y)
>> +$(XENSTORED_OBJS-y): CFLAGS +=3D $(SYSTEMD_CFLAGS)
>> +xenstored: LDLIBS +=3D $(SYSTEMD_LIBS)
>>   endif
>>  =20
>> -ifdef CONFIG_STUBDOM
>> -CFLAGS +=3D -DNO_SOCKETS=3D1
>> +xenstore: LDLIBS +=3D $(LDLIBS_libxenstore)
>> +xenstore: LDLIBS +=3D $(LDLIBS_libxentoolcore)
>> +xenstore: LDLIBS +=3D $(SOCKET_LIBS)
>> +
>> +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenstore)
>> +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenctrl)
>> +xenstore-control: LDLIBS +=3D $(LDLIBS_libxenguest)
>> +xenstore-control: LDLIBS +=3D $(LDLIBS_libxentoolcore)
>> +xenstore-control: LDLIBS +=3D $(SOCKET_LIBS)
>> +
>> +CLIENTS :=3D xenstore-exists xenstore-list xenstore-read xenstore-rm =
xenstore-chmod
>> +CLIENTS +=3D xenstore-write xenstore-ls xenstore-watch
>> +
>> +TARGETS :=3D xenstore $(CLIENTS) xenstore-control
>> +ifeq ($(XENSTORE_XENSTORED),y)
>> +TARGETS +=3D xs_tdb_dump xenstored
>>   endif
>>  =20
>>   .PHONY: all
>> -all: $(ALL_TARGETS)
>> +all: $(TARGETS)
>>  =20
>>   .PHONY: clients
>>   clients: xenstore $(CLIENTS) xenstore-control
>> @@ -62,37 +78,28 @@ xenstored_probes.o: xenstored_solaris.o
>=20
> Urgh - there's a mess in here.
>=20
> the `dtrace` line has trailing whitespace, but xenstored_probes.d is
> going to be clobbered by the dependency file logic.
>=20
> Given this is utterly broken, perhaps better to drop the CONFIG_SunOS
> chunk entirely?

I've basically asking to do so since 5 years now. Last try wast last
year and the DilOS reply was:

   we have plans for XEN on 2021 year, but all depends on business needs
   and investments."

So the same as in 2016 (not there yet, but planning to do so):

   i have plans try to return back and look at latest Xen.

At least running xenstored in SunOS has been broken since years now, and
I'd like to suggest removing the CONFIG_SunOS parts from it (again).


Juergen

--------------7254733AC05BA0E70E6D90C5
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------7254733AC05BA0E70E6D90C5--

--xCGTv6OJ3oygMCpknu4fYg2mLOy6FyHvT--

--vbbsecW2qHdYBEwt65FPxQuc8YOsffWK9
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG8HyQFAwAAAAAACgkQsN6d1ii/Ey+y
uwgAjyBPUOZxamXde9IehwlnsXkpxSmyFPrWDiVFynVPX7oMNpsSJn7UjuIBGWa/zYOgBXyvOQUW
suVC13QWqn44n17gGBz2SXSJJC9Ff7fatUEUYjg4JGpvfm9ANec3b/0dlB/r/d/FzoyNA1BxEjeF
hNlzvjdIdtki6k81BZHWjq85tpj/dfXFOKH7CmM1im9MEBBjOR1zz/yetl+QlG9qAeoDvgZrZus3
ehFyCvD/tewtgC2fHur7NwzPH6ierifyNVjlFPN0KkG5jBLqQkzxIXzbOh0oJyUHWrMteuqbSM82
iySL2jzkY2fLJnLrIGBwifgxrbNEB2COYNc42/DEkw==
=4hry
-----END PGP SIGNATURE-----

--vbbsecW2qHdYBEwt65FPxQuc8YOsffWK9--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 05:34:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 05:34:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248401.428488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my5t1-0004rm-JL; Fri, 17 Dec 2021 05:34:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248401.428488; Fri, 17 Dec 2021 05:34:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my5t1-0004rf-GF; Fri, 17 Dec 2021 05:34:31 +0000
Received: by outflank-mailman (input) for mailman id 248401;
 Fri, 17 Dec 2021 05:34:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1my5t0-0004rZ-Ar
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 05:34:30 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0130272c-5efb-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 06:34:29 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BFEC41F3AD;
 Fri, 17 Dec 2021 05:34:28 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 71EE613C60;
 Fri, 17 Dec 2021 05:34:28 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id iExeGmQhvGHmNwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 05:34:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0130272c-5efb-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639719268; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=YcH0jzoC4b9G3KmWyozyQVNW62xzy6XMHAH08rY/dCI=;
	b=R0A9eh7itflrKMl7dNxjuuRdvth4UPYeTwyyDEByIi3sUtuUTf+0ci8ngRh+GVZovwg22k
	fbQuScVgfQsTQhNKaV1PbW3EsZrAWUsflOcgi6TL4brdQKZve7R2P7hyI/+ERXpYY2+ua3
	8uA90ZgnnXzxlQpBPyImYbHvsGaVLxg=
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Message-ID: <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
Date: Fri, 17 Dec 2021 06:34:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="x1iMal0fjSZI1bHyXVZhzqc6QLjc8JERf"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--x1iMal0fjSZI1bHyXVZhzqc6QLjc8JERf
Content-Type: multipart/mixed; boundary="md8bdlXHIF8S4R0tim3Ym7UfFi2sfPFU1";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
Message-ID: <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>

--md8bdlXHIF8S4R0tim3Ym7UfFi2sfPFU1
Content-Type: multipart/mixed;
 boundary="------------2D3ACA15B5BCE521C04AECF6"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------2D3ACA15B5BCE521C04AECF6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 16.12.21 22:15, Stefano Stabellini wrote:
> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>> On Wed, 15 Dec 2021, Juergen Gross wrote:
>>>>> On 14.12.21 18:36, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 08/12/2021 15:55, Juergen Gross wrote:
>>>>>>> Today most hypercall handlers have a return type of long, while t=
he
>>>>>>> compat ones return an int. There are a few exceptions from that r=
ule,
>>>>>>> however.
>>>>>>
>>>>>> So on Arm64, I don't think you can make use of the full 64-bit bec=
ause a
>>>>>> 32-bit domain would not be able to see the top 32-bit.
>>>>>>
>>>>>> In fact, this could potentially cause us some trouble (see [1]) in=
 Xen.
>>>>>> So it feels like the hypercalls should always return a 32-bit sign=
ed
>>>>>> value
>>>>>> on Arm.
>>>>>
>>>>> This would break hypercalls like XENMEM_maximum_ram_page which are =
able
>>>>> to return larger values, right?
>>>>>
>>>>>> The other advantage is it would be clear that the top 32-bit are n=
ot
>>>>>> usuable. Stefano, what do you think?
>>>>>
>>>>> Wouldn't it make more sense to check the return value to be a sign
>>>>> extended 32-bit value for 32-bit guests in do_trap_hypercall() inst=
ead?
>>>>>
>>>>> The question is what to return if this is not the case. -EDOM?
>>>>
>>>>
>>>> I can see where Julien is coming from: we have been trying to keep t=
he
>>>> arm32 and arm64 ABIs identical since the beginning of the project. S=
o,
>>>> like Julien, my preference would be to always return 32-bit on ARM, =
both
>>>> aarch32 and aarch64. It would make things simple.
>>>>
>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a
>>>> problem in reality because the max physical address size is only 40-=
bit
>>>> for aarch32 guests, so 32-bit are always enough to return the highes=
t
>>>> page in memory for 32-bit guests.
>>>
>>> You are aware that this isn't the guest's max page, but the host's?
>=20
> I can see now that you meant to say that, no matter what is the max
> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is=

> supposed to return the max memory page, which could go above the
> addressibility limit of the VM.
>=20
> So XENMEM_maximum_ram_page should potentially be able to return (1<<44)=

> even when called by an aarch32 VM, with max IPA 40-bit.
>=20
> I would imagine it could be useful if dom0 is 32-bit but domUs are
> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
> configuration on ARM.)
>=20
> Then it looks like XENMEM_maximum_ram_page needs to be able to return a=

> value > 32-bit when called by a 32-bit guest.
>=20
> The hypercall ABI follows the ARM C calling convention, so a 64-bit
> value should be returned using r0 and r1. But looking at
> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets r1=

> today. Only r0 is set, so effectively we only support 32-bit return
> values on aarch32 and for aarch32 guests.
>=20
> In other words, today all hypercalls on ARM return 64-bit to 64-bit
> guests and 32-bit to 32-bit guests. Which in the case of memory_op is
> "technically" the correct thing to do because it matches the C
> declaration in xen/include/xen/hypercall.h:
>=20
> extern long
> do_memory_op(
>      unsigned long cmd,
>      XEN_GUEST_HANDLE_PARAM(void) arg);
>=20
> So...  I guess the conclusion is that on ARM do_memory_op should return=

> "long" although it is not actually enough for a correct implementation
> of XENMEM_maximum_ram_page for aarch32 guests ?
>=20

Hence my suggestion to check the return value of _all_ hypercalls to be
proper sign extended int values for 32-bit guests. This would fix all
potential issues without silently returning truncated values.


Juergen

--------------2D3ACA15B5BCE521C04AECF6
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------2D3ACA15B5BCE521C04AECF6--

--md8bdlXHIF8S4R0tim3Ym7UfFi2sfPFU1--

--x1iMal0fjSZI1bHyXVZhzqc6QLjc8JERf
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG8IWMFAwAAAAAACgkQsN6d1ii/Ey8F
Pwf/SSSDY6/2yo23wLD7SyHFQ+Iu+MZthUJNvZKk+o5mUwcIYJ2w832SMqMYYFBy0Pl6f49tCKM/
BVBI1k/0NYDdMpRq+JcVQdeoWKaOPx8iwRIN8IOx97tiKpE7scfABFAUhkfYM7Oefm0GqHDj/19y
oG+qSR/gD0WA4bPNhi2q1/w+WEaxait6U48UHszDmUQj11GqkvgC0SHSe3DreTcXjvLm9YUOxr0r
ymBA66Rd/p6T8Or5uOSJI/fDKAbm/papc98TSoAD4K1rbHisVzAiLYdc+zFHXmKw1Kh34qY1ZtRa
5XBSdD0t1nCOIv9y4jdWxXRNWVfA/2HgKElc2pTYUg==
=EMMN
-----END PGP SIGNATURE-----

--x1iMal0fjSZI1bHyXVZhzqc6QLjc8JERf--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 05:56:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 05:56:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248406.428500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my6E0-0007Zx-DK; Fri, 17 Dec 2021 05:56:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248406.428500; Fri, 17 Dec 2021 05:56:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my6E0-0007Zq-AO; Fri, 17 Dec 2021 05:56:12 +0000
Received: by outflank-mailman (input) for mailman id 248406;
 Fri, 17 Dec 2021 05:56:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my6Dz-0007Zg-4e; Fri, 17 Dec 2021 05:56:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my6Dz-0003aa-2M; Fri, 17 Dec 2021 05:56:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1my6Dy-0003O5-Q3; Fri, 17 Dec 2021 05:56:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1my6Dy-0002EP-Pc; Fri, 17 Dec 2021 05:56:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=avVmOLdGIOmgXSpgJ41Ner8CuC8XvX4IA5H05GVCbX8=; b=ZcWFikq5gtA/rs1Cd+2mU7A5gg
	+tY8QuD7I+dvnHHPN6oYuL3BjERJE8mRDaRPyIWRkslPVoJfY8eJew42V78jG+IKKILFoc4GkrEG7
	P4/yByvM0JYOmeqxM+RTsWo2o0g6ud404duQyY1UFrJuYhD8ps4DEO92yWc5lSfLqlbY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167456-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167456: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f3999bc2e099c571e4583bff8f494b834b2f5f76
X-Osstest-Versions-That:
    xen=4feacc95265a3d786753ed1532c77eb382630f78
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 05:56:10 +0000

flight 167456 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167456/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f3999bc2e099c571e4583bff8f494b834b2f5f76
baseline version:
 xen                  4feacc95265a3d786753ed1532c77eb382630f78

Last test of basis   167454  2021-12-16 22:00:27 Z    0 days
Testing same since   167456  2021-12-17 03:02:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Luca Fancellu <luca.fancellu@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   4feacc9526..f3999bc2e0  f3999bc2e099c571e4583bff8f494b834b2f5f76 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:01:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:01:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248415.428510 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7Ea-000790-99; Fri, 17 Dec 2021 07:00:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248415.428510; Fri, 17 Dec 2021 07:00:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7Ea-00078t-60; Fri, 17 Dec 2021 07:00:52 +0000
Received: by outflank-mailman (input) for mailman id 248415;
 Fri, 17 Dec 2021 07:00:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cq30=RC=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1my7EY-00078n-SW
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:00:50 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0fa700c1-5f07-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 08:00:48 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F209312FC;
 Thu, 16 Dec 2021 23:00:46 -0800 (PST)
Received: from [10.57.7.107] (unknown [10.57.7.107])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 752ED3F73B;
 Thu, 16 Dec 2021 23:00:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0fa700c1-5f07-11ec-9e60-abaf8a552007
Subject: Re: [PATCH v2] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel@lists.xenproject.org
References: <20211216092134.579-1-michal.orzel@arm.com>
 <58061d10-7299-6aec-5cb4-4c2d54f0043d@suse.com>
 <56435926-e091-fe33-9044-b669ecba23f1@arm.com>
 <0ddf5147-1f72-37e2-ca56-72307800463b@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <fbcb9459-878a-de52-a1cc-fe1009491385@arm.com>
Date: Fri, 17 Dec 2021 08:00:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <0ddf5147-1f72-37e2-ca56-72307800463b@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit



On 16.12.2021 15:55, Julien Grall wrote:
> Hi,
> 
> On 16/12/2021 14:26, Michal Orzel wrote:
>> On 16.12.2021 14:50, Jan Beulich wrote:
>>> On 16.12.2021 10:21, Michal Orzel wrote:
>>>> to hypervisor when switching from AArch32 state.
>>>>
>>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>>> "If the general-purpose register was accessible from AArch32 state the
>>>> upper 32 bits either become zero, or hold the value that the same
>>>> architectural register held before any AArch32 execution.
>>>> The choice between these two options is IMPLEMENTATION DEFINED"
>>>>
>>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>>> needs to be fixed. The reason why is that there are places in Xen
>>>> where we assume that top 32bits are zero for AArch32 guests.
>>>> If they are not, this can lead to misinterpretation of Xen regarding
>>>> what the guest requested. For example hypercalls returning an error
>>>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>>>> would return -ENOSYS if the command passed as the first argument was
>>>> clobbered.
>>>>
>>>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>>>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>>>> Add a compile time check to ensure that save_x0_x1 == 1 if
>>>> compat == 1.
>>>>
>>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>>> ---
>>>>   xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>>>   1 file changed, 29 insertions(+)
>>>>
>>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>>> index fc3811ad0a..01f32324d0 100644
>>>> --- a/xen/arch/arm/arm64/entry.S
>>>> +++ b/xen/arch/arm/arm64/entry.S
>>>> @@ -102,6 +102,30 @@
>>>>           .endif
>>>>             .endm
>>>> +
>>>> +/*
>>>> + * Clobber top 32 bits of gp registers when switching from AArch32
>>>> + */
>>>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>>>> +
>>>> +        .if \compat == 1      /* AArch32 mode */
>>>> +
>>>> +        /*
>>>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>>>> +         * Add a compile time check to avoid violating this rule.
>>>> +         */
>>>> +        .if \save_x0_x1 == 0
>>>> +        .error "save_x0_x1 is 0 but compat is 1"
>>>> +        .endif
>>>> +
>>>> +        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29
>>>> +        mov w\n, w\n
>>>> +        .endr
>>>
>>> What about x30 (aka lr)?
>>>
>> Well the docs says about gp registers as a whole so including lr.
>> However I do not see how clobbering lr would impact Xen.
> 
> Xen may not be directly impacted. However this may be used by some userspace application (such as for VM introspection) and could be dumped on the console.
> 
> So I would cover all the GPR to give a consistent view to everyone.
> 
Ok I fully understand. I will send this change as v3.

> Cheers,
> 
Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:12:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:12:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248420.428522 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7Pv-0000PX-BG; Fri, 17 Dec 2021 07:12:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248420.428522; Fri, 17 Dec 2021 07:12:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7Pv-0000PQ-8L; Fri, 17 Dec 2021 07:12:35 +0000
Received: by outflank-mailman (input) for mailman id 248420;
 Fri, 17 Dec 2021 07:12:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zqed=RC=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1my7Pu-0000PK-8l
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:12:34 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b361c40d-5f08-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 08:12:31 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2050.outbound.protection.outlook.com [104.47.2.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-dVS8qkvmNJiBNc9g7dtobQ-1; Fri, 17 Dec 2021 08:12:30 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 07:12:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.016; Fri, 17 Dec 2021
 07:12:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b361c40d-5f08-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639725151;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SmHn+CnE6itoxRgrD97ITmCMKimndrn8qe9Do/IYSzU=;
	b=E0OKB3u5hXKVUvXabrUIkZlLZu1muau1A5SXw5lpI/kSZZtJOxtsNyHljMK2RLofWqmQSY
	VP6/L1sZQruRtuSVvv/J47H630i1aGQKMGA4SIGQ6hUmM/ralirY5sQpyQFl1jSzUzI4L2
	74rWQqubK3Iz1IpG55RReYT/7Roz7bI=
X-MC-Unique: dVS8qkvmNJiBNc9g7dtobQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=k0h9SYulNKY2rwcVrBUy9CRVkDZGUTmTQIApR0EkoG0nXKM/XXOt3sEL/OwODgfuZgSHmQviQJQ7z0F5Ykg7jUZmNFvlt3u7EuwX/CCghLhHuDwZbScAjysY62ijNjh4gfcpro2fkyyNzh4L6lZMwNV1ff+l/QRtclD4jWdFFyiJwZ55pth8RaatuGUgoHmQ7C5VWjy8j4+k73kX8ZvM/0NiGa5FmxbtvsANokydBAhDWBuSezIL+alOKyX+CXfDawGpa5gMt7JZXjoemGHCHQuIMr4m5B56Pu719IvdlhakuknOowDt3Vsn1LLwLeWuDru5NKnrI+NNvBsCPixAtw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=SmHn+CnE6itoxRgrD97ITmCMKimndrn8qe9Do/IYSzU=;
 b=Zxa07Dpp1QMduhlGeibYuWr5DFVZgwoN3JShHHxPUBw2y0OFpYyLnPtdF0Hp1UjBBmpsJbdto/m9NCTXoI7XOUqaY8kqtYqqURlfE8jEuJhfXOg9KxaOfstzfkYuR9Ezpr162gQYpCZ2w0ZBzHTNUWakaM07Xqc7yYMcjeNV133uGC+F/e4JGtkmv1t9JiPzyHMjLjt3ZDiidM6/6kTlj34U7t95Opp87PaX3WGWU7qAN+RZetW7SgsPpzwUMiBUwitzgMDmyPGN4Qs7fSZ0+k2ZecvufLYJmMXpLfErrnlCqMUlFLlS20UoVvW0vb1GWEEtSVM6y239IzTGzSB8Sw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <08488d6e-3bb5-71e3-2e07-aafb912d69f5@suse.com>
Date: Fri, 17 Dec 2021 08:12:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Content-Language: en-US
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
 <20211216173625.GA3623693@EPUAKYIW015D>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216173625.GA3623693@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0073.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::18) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c2dceac4-ae9b-4d15-247c-08d9c12c93fc
X-MS-TrafficTypeDiagnostic: VI1PR04MB5166:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5166721DA472316191220412B3789@VI1PR04MB5166.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	XwqLLcnRdNPMyFiHsESi8w50Zgigkg2zj3Lu4/Nw2BlZ12LMG9gXa5GixT8tH5poxJVjocE+vwB3Qh3HgyZ+tHyh2WSOipD9p+fac4K2FhLefdQKS9QbSRkVs563MfNexb2USpw4ajxwb8bQx9H2NPtf96Kku8otT3tT/dyGvZrGXWqNh0PfCchAGDQSYzhKeyiXvyphP6OCOCckOXmNWwMmhrJgvp6Fc5A9emEktFJxloBeZrILbWxcZ540uoNltmIpAsEJgOrMyWUgINl/I0W286m4Fo6P3JTQCwtNpYV6SIrUz6TyZiZJm4IB2oh2BtR5K+I/+XAUvudpOz/fYH17+ZbRsbxogUX0nobL3j5U1gLP6wluXwXUIed2HGGNfNeVsKbCtO6gUMmFUTbpH6lMPBedECuZ3+tIUy2+A7r3fp6kvSeMnPbo2yZvBEjDVphkTW/keeIzP3LTP6paApn2Sgh0Hb54vHHs9FN4qkc81PBWqRUYF9gzrkot5vJtrtCDkgHXAKEwEl5B3+KqUgjjhehY132pLUzzRXvrCdYPaVJUrNyzPDaj0m1YvY1SkMD5Lk7QqNwlmPZqt8xrk68jEyfi9Ophi6+S4negzeF6nSWkwpQHOhJgBWv8sdQTDGVePzJhHg5nw4PXCNYxFPxts3h8+Dev/fvj1kXcm1gmIA+M3aIR+ngEn/eFYE4FBJW+KG5cU3EvUiShPaQfdvs1bkqm+tJalN8o70vso18=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(5660300002)(38100700002)(4326008)(31686004)(6512007)(53546011)(6506007)(8936002)(66946007)(6486002)(8676002)(54906003)(66476007)(66556008)(2616005)(186003)(6916009)(86362001)(316002)(26005)(83380400001)(2906002)(508600001)(7416002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WWlBeWRWSWl1YThYSHl2TzhxUzMxSFV0Y2pHVjdIOVNWdjZkNDlQMWxGaFFo?=
 =?utf-8?B?NkMrY3M0M2lPMzZJK3hxYUxhYmFkOEwxY0p1SFpvTng3dWlEYytENnNPNjZY?=
 =?utf-8?B?djh0cGhhZnduUzB5cEpSZGNFTDhLZUovSGtoWkRBeGtUTXQ5ZjN4cDlaejdX?=
 =?utf-8?B?SUlFQVlWRzc3d2h6ZVVDMVVEOG5DNXB0WS9EZks3c09yc1FQMGpJRmxWREky?=
 =?utf-8?B?cDdnU0pXSEozSzdQcXlpQytaNVdEeEUyTWZYWkd6OEs4dGZ3NTlPNGFhdDIw?=
 =?utf-8?B?ZU0xMkticXRzSElpZXkzTEw4b1N0cVp2d0gyU2owcE5yMzNNMlpCMm4veHdY?=
 =?utf-8?B?TjJOU1ZhU3FZTmRlVU5GMHFzK2dZZll4Z2w4azVEd1lRQ2ZzZVBwQjdsdktq?=
 =?utf-8?B?RXpDSWJuSnkyemZNQ0hTUlJLUUlzK0xDcnZkSEdLQkhVdFI5K2hKUUp1NTMr?=
 =?utf-8?B?Y0dqQnFTb3p5V1BpNHR3QUVEUVBzZ2VGWjFXS3BsR3Q1Rk9HbTNDZUVMQmw1?=
 =?utf-8?B?RzUzQ3ltVFREdVNsRGhJZ0k5VG1McXNMaXhCeXh6Y1NrMGM5Y2dJaVFvZ0Ix?=
 =?utf-8?B?NUd2a1pKcWVLWThTbVZxUUxwTEtMSENyQi9OZlBZQ0cydU9saWcvWlgvSmNE?=
 =?utf-8?B?bVdvdmdBQ0JYOTRhOFlKQm0rR283a29VL1g5Z0tITGo2S1ZOZk5tNk9JN29n?=
 =?utf-8?B?Q1JFSTF6SW1xUnZJTjBOL29EOW9Ycnk4Yk41emtYZjUxR1h5TStWMDYwd21H?=
 =?utf-8?B?QmJPMFZ1UHBXdlRvamRHTEY3MkprTnNKSmRoWXFnNEJuV2cxODhzeUdRVnc3?=
 =?utf-8?B?K3FydHFLa0JUci9IRngyWXpkR3ZyYTVNa09pdlU3MldhdGdRajFaZUc2dk40?=
 =?utf-8?B?d2tjTk1HRVZjVVBnZkxJUG5Uc0w2RTVLTmt0a1lTZ2gyUC9MUWZsbXRMVE1K?=
 =?utf-8?B?NUR6ODBxbHlzNTVmRC9oQ2dyMWJEcmtYY1Nyb3NjVmR0NGNxYTBDeWlMZ1gz?=
 =?utf-8?B?MWlSMnhNekxSbzI1U1FqQjlGT1RnM1RXUXA2bUxiV1A4WlNvckp3Unl5L3or?=
 =?utf-8?B?YkVFYlJYVzZNYUptYWp4OUdtN2kyd2xjaFN0ekdNR0tQM3I0c1RCTVRVczNJ?=
 =?utf-8?B?YjBVcHRPYnNoL2lhVHdpQmJXdjFxeWhtL1JNdHJXQlZMa281cll0eEhXZ2dx?=
 =?utf-8?B?dm1CenIrMXNKVXp5SFl4UUhSeHNwYUVpSzZMSkVDRXJ0eko4b2IxeFJmY3M2?=
 =?utf-8?B?L3FWWHZZUUlGWVdaZ1p2ODQvUVNQMDY2Nm4xbFNKZmRZVkFvLzV0NjZ5bEJv?=
 =?utf-8?B?QjIwbCt5dFZ6eUUxSUx6RDNXVmRwLzkrUzliME9oVDJEZWNlUm1zeEdxS3ht?=
 =?utf-8?B?MzR4YVFHT0dkbEhHaE1iR1dlVFZhbjFqVEF0ODgybVRpMG52aHBzbGNHK3lR?=
 =?utf-8?B?ekZFbGVmZTdZMm4zcll3dmFiNzUwQjczS1YvY0NmeWhWdXRiRTkrblpuRmU0?=
 =?utf-8?B?YXZLRFcwS3ZoU0Y4OGI2Ull1cm0xdCt0bkZSY2lxSlVrRlJ3NGpVNFNySUd5?=
 =?utf-8?B?UkVBM1hCMGxyVExEeTR6TTFRamtzRmlZMnlxZ0JuTjBvUzJ3ZFA2TTBNbnY2?=
 =?utf-8?B?QzFXVlhkYkpnUGVCdUpzQ1NaOFRCZmM1YW5ZWG0vbWg1MkFMeWlFaDMxK2s4?=
 =?utf-8?B?a3NPN2t6emhNWnNTRzVwL0NUMnlmL1U3N1o2am9DbzRuNUREeTNibVNsY1Jl?=
 =?utf-8?B?aVR2aGRBeTAra3JNNjJkKzBtYkZMVFU3REg3Q3lRSi9tSTJMSm1QVGR3ZTZu?=
 =?utf-8?B?TU1mOGxPczlCVGNQWnNoSlZZQ29hTUlBdmlXdytMUDMvdE1mOXVrUWNEV29a?=
 =?utf-8?B?ZlNWUVBCSjFIejdEdFBmZy90L0ZxWEU0ODdrKzdCT1N1TnhIWjdnbU1ZaDFV?=
 =?utf-8?B?aE81dW9lbVdqcE1YZFg0OUdiL3ZIcFFMRkx5dTZlQzFtR0s0YWVSRUw3TjFF?=
 =?utf-8?B?Y1pnMHliS29XSU83V0lVSFd2UE9LODlncGNQaHMvY0grVk1jMGJwZ1NIWEtK?=
 =?utf-8?B?MHdrd2hNSjdXaC9uMFErY2lhb0xMNmd5V1dzamlSYTdqUTBrd1FLS0o2NGpT?=
 =?utf-8?B?ZkxNc3RNMkVSZ09udXJxc3N1MHVrbGs4SnUxZktUR2psbjZTbzJUUFlQUGhE?=
 =?utf-8?Q?z6AsPBbsMnrmeeun09pBnA8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2dceac4-ae9b-4d15-247c-08d9c12c93fc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:12:25.6851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kPnjOLY4QiyYCxeMe9R+7l6xuRIOZvSuBRJITIK0LdX6idbnpvG1DW0kjjd3xl6d7sVdZYSuKOuz036Oe6a6hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166

On 16.12.2021 18:36, Oleksii Moisieiev wrote:
> On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
>> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
>>> --- a/xen/include/public/domctl.h
>>> +++ b/xen/include/public/domctl.h
>>> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>>>  #define XEN_DOMCTL_vmtrace_get_option         5
>>>  #define XEN_DOMCTL_vmtrace_set_option         6
>>>  };
>>> +
>>> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
>>> +struct xen_domctl_sci_device_op {
>>> +    uint32_t size; /* Length of the path */
>>> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
>>> +};
>>
>> This being - aiui - Arm-only, please enclose it by respective #if,
>> just like we do for certain x86-only ops.
>>
> 
> I agree. I will add #ifdefs in v2.
> 
>> I'm further afraid the term "SCI" is ambiguous with ACPI's System
>> Control Interrupt, so there's some further tag needed in the names
>> used here.
>>
> 
> Thank you for remark. I'm thinking about SC as System Control.
> What do you think?

I guess "SC" could even more so stand for various things. Even the
spelled out "System Control" looks overly generic. If this isn't
Arm-specific (in which case adding "arm" into the name might at least
help the situation a little), then I guess some further disambiguation
is going to be wanted. Since I don't know any of the context of this,
I'm afraid you're in a far better position than me to come up with a
non-ambiguous name.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:16:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:16:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248427.428532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7TR-00015L-Vh; Fri, 17 Dec 2021 07:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248427.428532; Fri, 17 Dec 2021 07:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7TR-00015E-SU; Fri, 17 Dec 2021 07:16:13 +0000
Received: by outflank-mailman (input) for mailman id 248427;
 Fri, 17 Dec 2021 07:16:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zqed=RC=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1my7TQ-000158-J5
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:16:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 367dec9d-5f09-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 08:16:11 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-33-UR5Q7ZVrOM6Ql92KhlkJCQ-2; Fri, 17 Dec 2021 08:16:10 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 07:16:08 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.016; Fri, 17 Dec 2021
 07:16:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 367dec9d-5f09-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639725371;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=+cgXeaQYlj9zBzYETpbHa1RaUsPD+c7C14MJa0nUwH4=;
	b=Mw0zKg7Tg5NK0GJLiSPcDl8FMFizQ4W0FXGKKI9BkQoX7eNakyBvCVjAQVgLTTKVpaNlXr
	TVNbIHAJEb1yh/EIdq5dJJ7vEsF+R0rN64iPRlW6uQ/ZC7pFiSRh/tLaIACawTESgxt8v0
	Z1+lO9OX/PhKduIHk6VyTqMosLJdJGw=
X-MC-Unique: UR5Q7ZVrOM6Ql92KhlkJCQ-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fwfu59WMYBhZ8xUB5pqkrCocKsHFwE71lFmPf8OHXpR8wfJmrRUDQzVgKvcdU+yjyWQ4sM3twOgw9pEFssSST4QXQXJCk+/4brgg2BSX/VxXtvTSLYu1NWmpTzMSJi58uJq61La8UaZgBw6SxtU0YB4evYIl5eum5bEQpkqsr5k4YIf9oGr80XhVyLtAgxtMUIDn60lZlRB+qzEz2SjcMGWjMGPGfX9CWSzhJ1O1p3upDrWtYd5aYFa9/digxW9abD38essikVkOeJ0mNvIr8Tt6jx1DBdjhgXNPjBL1apgNhzaawiuvjRQE2MTYq29i/9Oku0QlO2T7DN6mb0FU5Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+cgXeaQYlj9zBzYETpbHa1RaUsPD+c7C14MJa0nUwH4=;
 b=Bzxtn3VAuGRUdy4IxysnbAmN5g0oFY1Xh3TciV7Ycy0D++cTeLVmZex8An7fWor9vT1mL9HTspKpZmOyHVQPIn/iKK5gDW05NK/E79ErDbJkydssRurRKksx4FnukfvjVxJwGwfQrHRedZz7cv/YVakrojFAZ2eCFlT0UXvZcloxXT+XRimY067C4/GmEZLja/BJqHoGFjhY46RlNxb1BnzzlpT2D1yNqGYHrT9RR3I8vZVZqNoaISmZ75z+aJnmRJjcEGSmw111Nr5vFY+EWXepyiQ8eJP7j4TtbbT+bvWtqELwTCTZLX45fMkgj+8bMnG2tr2KzN8BGZGiLAqlvw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e86974f6-dde3-20dc-1748-962d9122a05e@suse.com>
Date: Fri, 17 Dec 2021 08:16:05 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
 <20211216173625.GA3623693@EPUAKYIW015D>
 <08488d6e-3bb5-71e3-2e07-aafb912d69f5@suse.com>
In-Reply-To: <08488d6e-3bb5-71e3-2e07-aafb912d69f5@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P251CA0026.EURP251.PROD.OUTLOOK.COM
 (2603:10a6:20b:2f2::17) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2fcd049e-d788-4488-f9e7-08d9c12d18a2
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2445CCF674D84F863385318CB3789@VI1PR0401MB2445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Zq5kQDBJMXE5pqtX6OMD6eT5nJ2KJ6KtRBcC9tfIppRbX91SCKW0l08EDQhHd3Qs92AbA8xWM3wB59VXBLO7snrfX5PzeCjNp4w3BVRSHAL4TIJ5efI4ZpBsqfoy5+l7v5Ihe6XBcrREVliiZCufDqblt8e0+mQUcEkMwVapsQofN1S30h1l0kIB1SozUoPPD1e0sLG+m8hTLZSahNDYr/5AaD0R2xsK2cgBSlvxLwzYOEzcARgwFVwuLZibU/4S0gtIMVCHGWkEgdYzaey99XujMXqUwwBPDc02k6SvBN0J1rkEixc4nWVLVBDTc4186B61j7z9ANh8Cuh9XPuihWeh4eJ8ljAB077xovBTDWXAePcX1YcA2WPctydGGVijJabFVeEgi55jp1TrNkZ54HERv1Ycr1PMkhW4iQxBu+pdGkyOqa69BHAeFfQmL664nMMsgYSIY9HrhpfyRjZBL1utwmuokxJGgyYL17/WV8IQxlYqNP9nIPa4YC6e6DTlnypNFa6V2TjTYcSt0fpXq7VrPFRONh1pfzivDfe/1mc9SLys/Z4T8jek6qWV5tvViTyJQN/ErrgRZUs8ag02GckAJSrQ6lwOx0ngb7igshASLOnXbbE25R8svXzRGYHKueLIIvgAkVfBj3RwPOglkEXkjcuTqADzJtkU3QwZ/xPCD5H7c+TPVVO1Yf9awITKG3ySkT4rh8umDdwmiMsWX5I45m6TCY7dRbkuEEdsNh1YmTJhIVvZMVap85Lco3WM
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(8936002)(8676002)(2616005)(7416002)(6916009)(4326008)(2906002)(316002)(86362001)(53546011)(6486002)(6506007)(6512007)(66946007)(66556008)(66476007)(6666004)(5660300002)(31686004)(36756003)(38100700002)(83380400001)(26005)(54906003)(186003)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Ykt1bzBEZmY4Z0FwVURKeFo2NUtZR2hPK0ptdjZlVmpVa1NuMUJzbExPTUtq?=
 =?utf-8?B?WlJGMVdMSjg1Q3pNVHRZZG14cmhhUE41VjUxKzFsOTdOaGdqblEwejRIT1Bq?=
 =?utf-8?B?MWpvUjZWVzAzYTVjWGVvNHVmYytzN0p5Z1paLzNGTXg2K1lwS0hFUlpjTmVt?=
 =?utf-8?B?SUltUzdvNDY0eEE1WHo2VHY3dXVJVkgvU3psemFzVUFEeG9ieURnd01pWmw0?=
 =?utf-8?B?dzBSU1JPdHlGc216Z2MyYStKMDJMT2FiUTBBY2RKTVd4bmtXVkJvSnowdEs1?=
 =?utf-8?B?eVF6VkI1RWRnSitEbk5ERmxzN3VqWEM0bVplZUlXMEdmK050U0FiNWJwaCs3?=
 =?utf-8?B?c1crc200d0dlemZpWitocUJpU0VMK0kvVHdoM2lBWHdOZjhUa3E4MDhKYXRO?=
 =?utf-8?B?V2FJZjM3THFNeGNvODhMcmVNdU9yTTZUVHE3cUhpQytVMUI5WGlHNjlScy83?=
 =?utf-8?B?a3psRS81cnY4MjB6cjFXQWxKOUZBMWhnN1NoWUpkSWVmV2kwR1VOWmcwczVY?=
 =?utf-8?B?b0JzNWovZlg3bElQUUIvZTVFVFloQTZZaU9qZUJSb1NjbzdkRFlzeXNmb0N6?=
 =?utf-8?B?VVI4T1FHa3ArMUV5M0FTclBETy9YN2ZESU5ldjYvRGc5a1dxVlE2c3hyeVJ5?=
 =?utf-8?B?VG1CMUxiMkJzNE1pR0w5N2pscFl4Qit2ZW5kVjg3VXBXVDFhenpqSTZVS3N2?=
 =?utf-8?B?OWVTLzZQa2UvbDRmRXBzRXNEaFc3V0lwSVFKR1c0cWtjelRSUUxCNm9LOFBk?=
 =?utf-8?B?SmJWWVZWbE9MWStlNG5uajlRL2lBa3htNkwxd2xJdVJtcmVYMDVzRm9VSU1C?=
 =?utf-8?B?QldOQ1RrV204dGRZOEhncmRDNUZ0R3RWYVUwRWRJc2ZGb3R3YlJTYmxTU2ov?=
 =?utf-8?B?c1ErZjdjOFlYQ1ZSZUdLZkc1cEdybGVOckgzZjQ2Nm9TWkVTQ0R5SnAzd2ZR?=
 =?utf-8?B?NWhPWnZTRXcxcmU1SzlDMStObmZ4bkJuWHFQMTdTR3JoTk5ob1hHSjNleFFp?=
 =?utf-8?B?cUdVOUxaRXc2L3FNZHFpRkZOYzYzSGxjb1V2NmNvYVVnM1VDQ0d0azY4VmJN?=
 =?utf-8?B?VWw3bHNQZTlMUGZTNkhYZlRyTS93dW9DWGpRT05CcjJDNWllQ2VwNXVoRm5M?=
 =?utf-8?B?YkxoMEQ2VWwvcklUU0NTN1dmVm5lcXcvNWJyWERWYzMxbWZVSlhXOTY3UTVs?=
 =?utf-8?B?UGxpb2hhZGFzbUFsUG56aC93VUhaZ3JneXJ1YjZ6cys0RXJIUGlYNnZDSkFL?=
 =?utf-8?B?a0pNb1lTVnMxYUVzS2ZEU0FtdlRJV0ZDUWQrbXhDRTBqTTlTcm1LVHcwbDU0?=
 =?utf-8?B?RThGbTg5TVlHN2U1dDJiRndYNnJxbFZaMmp0L0dqdGgwVVNVczVNSEJGS20v?=
 =?utf-8?B?ZkJLYUdIOTRIenBReHI3UFJuNjFmY2RFT0N3OEY0WVVVTmxLTE0reE5BQlpx?=
 =?utf-8?B?SUhwVW1sMVNOYXVoL1MxRGlDOXhkbjJzbVU2VHEyNmZiamxCVndBTnlsWXF2?=
 =?utf-8?B?NnVZcUZqc0ljZStHSWIxWjdoaEhRL0FlRk45ZG02cVE1NFBCYjY3Y1I4NmVz?=
 =?utf-8?B?UXV6WGE1TUdBSkc5MEpwZlR0dURCZmRrTUNBTnZOc2E4ZGw3UEpiQUtJMTF5?=
 =?utf-8?B?R2pMeFFqeEpiRzM1SE11NDM5NFcvK0hiWFdndDk3aE9TK0lQR1Ryci92aGFw?=
 =?utf-8?B?U1htNTc4aWQxVWhyVEpzU0R3RUJLSFM1U0I0UWxWU0xXWEpnSjU3eWNDRnRN?=
 =?utf-8?B?dWhTVlo0dkw4eTlQOW1nTXcxZmJZL3lqWXJQcHhNU0diM3N2eGtWTEd1cWM5?=
 =?utf-8?B?aXZEOTlldHozbjhzRSsvd0RuTk55WlRWWWtnY05sdnZZWFU2L0lkbTRwbjds?=
 =?utf-8?B?MVovc1ArOEU0aXhqc2NxNzdVMUU4T0dMV1B0RXgrYkw1clpqQkIzSWw5djRi?=
 =?utf-8?B?S1lkQ09ndjh5MVNBOGY3SFo2QnpPeTBlb010Y0RONFRwTXNza3JtbDVFcFNa?=
 =?utf-8?B?MGM1WGxDaXlIRFd4QnJvR28vRzlOTG1MUjNDTTZnRmFjUytmeHNoK1ZJOHZn?=
 =?utf-8?B?ck9FNFFQbVZGQldEUitKck5wa0kwaUdUMGk3Y1RqaHBHNjRlZDlXVUZYWFZT?=
 =?utf-8?B?MXlwNWNCQ0ViZ1RXdE9OTFpxSGJicW9jS2FCd1pFdzdNRHFNc21meDBRWlU4?=
 =?utf-8?Q?1Xy21ZkbDAO5+NUNn3Bpc5Q=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fcd049e-d788-4488-f9e7-08d9c12d18a2
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:16:08.1338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QYaVCqTZPOj3be3WzLQOybhhqj/uHTQEDQnguwh8LXqrKQ7RmWbSA9mssMy9YK87cAEWFOyHCUWgu+MJZUsEpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445

On 17.12.2021 08:12, Jan Beulich wrote:
> On 16.12.2021 18:36, Oleksii Moisieiev wrote:
>> On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
>>> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
>>>> --- a/xen/include/public/domctl.h
>>>> +++ b/xen/include/public/domctl.h
>>>> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>>>>  #define XEN_DOMCTL_vmtrace_get_option         5
>>>>  #define XEN_DOMCTL_vmtrace_set_option         6
>>>>  };
>>>> +
>>>> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
>>>> +struct xen_domctl_sci_device_op {
>>>> +    uint32_t size; /* Length of the path */
>>>> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
>>>> +};
>>>
>>> This being - aiui - Arm-only, please enclose it by respective #if,
>>> just like we do for certain x86-only ops.
>>>
>>
>> I agree. I will add #ifdefs in v2.
>>
>>> I'm further afraid the term "SCI" is ambiguous with ACPI's System
>>> Control Interrupt, so there's some further tag needed in the names
>>> used here.
>>>
>>
>> Thank you for remark. I'm thinking about SC as System Control.
>> What do you think?
> 
> I guess "SC" could even more so stand for various things. Even the
> spelled out "System Control" looks overly generic. If this isn't
> Arm-specific (in which case adding "arm" into the name might at least
> help the situation a little), then I guess some further disambiguation
> is going to be wanted. Since I don't know any of the context of this,
> I'm afraid you're in a far better position than me to come up with a
> non-ambiguous name.

Actually, looking at the title again - any reason not to add "mediator"
into the name? While I have no idea whether there could be other
mediators with an ambiguous acronym, this would at least address the
ACPI related concern (I don't expect anything mediator-like to appear
there, but then again I might be wrong).

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:22:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:22:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248432.428544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7ZD-0002go-Kp; Fri, 17 Dec 2021 07:22:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248432.428544; Fri, 17 Dec 2021 07:22:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7ZD-0002gh-HW; Fri, 17 Dec 2021 07:22:11 +0000
Received: by outflank-mailman (input) for mailman id 248432;
 Fri, 17 Dec 2021 07:22:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cq30=RC=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1my7ZC-0002gb-Dh
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:22:10 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id 0b3cd0a4-5f0a-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 08:22:08 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 410DE12FC;
 Thu, 16 Dec 2021 23:22:08 -0800 (PST)
Received: from e123311-lin.arm.com (unknown [10.57.7.107])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 036FD3F73B;
 Thu, 16 Dec 2021 23:22:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0b3cd0a4-5f0a-11ec-9e60-abaf8a552007
From: Michal Orzel <michal.orzel@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>
Subject: [PATCH v3] xen/arm64: Zero the top 32 bits of gp registers on entry...
Date: Fri, 17 Dec 2021 08:21:59 +0100
Message-Id: <20211217072159.3464-1-michal.orzel@arm.com>
X-Mailer: git-send-email 2.29.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

to hypervisor when switching from AArch32 state.

According to section D1.20.2 of Arm Arm(DDI 0487A.j):
"If the general-purpose register was accessible from AArch32 state the
upper 32 bits either become zero, or hold the value that the same
architectural register held before any AArch32 execution.
The choice between these two options is IMPLEMENTATION DEFINED"

Currently Xen does not ensure that the top 32 bits are zeroed and this
needs to be fixed. The reason why is that there are places in Xen
where we assume that top 32bits are zero for AArch32 guests.
If they are not, this can lead to misinterpretation of Xen regarding
what the guest requested. For example hypercalls returning an error
encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
would return -ENOSYS if the command passed as the first argument was
clobbered.

Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
Add a compile time check to ensure that save_x0_x1 == 1 if
compat == 1.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
---
Changes since v2:
-add clobbering of w30
Changes since v1:
-put new code into macro
-add compile time check for save_x0_x1
---
 xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
index fc3811ad0a..e351ef8639 100644
--- a/xen/arch/arm/arm64/entry.S
+++ b/xen/arch/arm/arm64/entry.S
@@ -102,6 +102,30 @@
         .endif
 
         .endm
+
+/*
+ * Clobber top 32 bits of gp registers when switching from AArch32
+ */
+        .macro clobber_gp_top_halves, compat, save_x0_x1
+
+        .if \compat == 1      /* AArch32 mode */
+
+        /*
+         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
+         * Add a compile time check to avoid violating this rule.
+         */
+        .if \save_x0_x1 == 0
+        .error "save_x0_x1 is 0 but compat is 1"
+        .endif
+
+        .irp n,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30
+        mov w\n, w\n
+        .endr
+
+        .endif
+
+        .endm
+
 /*
  * Save state on entry to hypervisor, restore on exit
  *
@@ -111,6 +135,11 @@
  */
         .macro  entry, hyp, compat, save_x0_x1=1
         sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */
+
+        .if \hyp == 0         /* Guest mode */
+        clobber_gp_top_halves compat=\compat, save_x0_x1=\save_x0_x1
+        .endif
+
         push    x28, x29
         push    x26, x27
         push    x24, x25
-- 
2.29.0



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:40:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:40:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248443.428555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7qI-0004ba-5Q; Fri, 17 Dec 2021 07:39:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248443.428555; Fri, 17 Dec 2021 07:39:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7qI-0004bT-1G; Fri, 17 Dec 2021 07:39:50 +0000
Received: by outflank-mailman (input) for mailman id 248443;
 Fri, 17 Dec 2021 07:39:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zqed=RC=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1my7qG-0004bN-Ic
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:39:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81c48e62-5f0c-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 08:39:46 +0100 (CET)
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2057.outbound.protection.outlook.com [104.47.2.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-nA_pG-tcPO6tmjM2807BdA-1; Fri, 17 Dec 2021 08:39:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 07:39:43 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.016; Fri, 17 Dec 2021
 07:39:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81c48e62-5f0c-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639726786;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZdQgE6pD11VLa2w58nTAWrowaNXWfX2MqQAbRI165VI=;
	b=eqam6ZotYmRHcQPsnGRixB9vr1aR1JlWn/9UtCUgzq2Xzl9QYykkmTL+KwV+mshmBgIgLC
	9rgKR8JcSJ4m5MZESfVB8+vEjeVZ3hrWXx9lgXXj3tfL4ltcAGGxxSmrnCnWcdDwIHqBQI
	7mGjtuicJVLIb4zsrybCnc/K/TxDAZY=
X-MC-Unique: nA_pG-tcPO6tmjM2807BdA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EpoP1nSWVwo/z8WqXtRQsdYuHb/7a600GCmDGo1qGOrrHvIdxr1dJt+RHFopG2u1fKurJ9Gcz75CMMDcmzyglyaTOuIZT/lUXerv3j0nz2vinPiuyqS6/3nI655rbVIh+OChJXLeslI2crVRcS4k9lQnFt6ROl+zWQlFfFeq9ycspDmgM3xbupvYjYSlq3i9+0H6SBtMyIhD4T80Kpl3lL+wGkdePOlcjLEJkM2EiOZtEb5I270LbGnUI6WQQLfn1VWVX0qge2j1EenmXAB/AAC3pMtY8hkYdKpX1LuWYT/GkgkJnzrT9yS/5L8SAmDEcrwGYWrxpafkfRaWnxGoNQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ZdQgE6pD11VLa2w58nTAWrowaNXWfX2MqQAbRI165VI=;
 b=BDW8tX24o9RgPgn7NYtODW6ELJXG0zageDtaeabKIl9IvTAh/qIud1aNpBrr2OMsqwgG5pjXsWMLGNzOPeBNGdNqr46wiWiG0ZADvAsdhs7x+c3EuGz43Mr46u3wdoRPcya+Arw5yd9w2WC1IQlfX+ID+DVmCT6ZcjFjM/tt/xPa/RXnHAYCQX19bzrOeBwMFvxYs/VYMPD9i19q0x5zTE1+vda9DnmaJrnwuquKoGSmwHKfbBmV2lSH/+Fe3MuCe3EidXONHbW7eor35RZxVXCadRyVB7erLMb/btdKkDSy5FmHhva92pTC8dVfnIbL8YI2Fi4+5z+q7j664fnWmw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1a23f21d-57e3-9f9f-6447-82731f7c0b22@suse.com>
Date: Fri, 17 Dec 2021 08:39:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Content-Language: en-US
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, Julien Grall <julien@xen.org>,
 xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: FR3P281CA0067.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:4b::14) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 53ed3f08-c87a-4ff8-8967-08d9c1306417
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB63019CB62B8D0EF5BF4156C4B3789@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	bc890s+l0I7KS2WTtyF36yxT2iRGX1eg4U7+hWh9eYU0tDhSkiTwW0rl6H1N+1LzGnX/Rc98F4R8oiDNh/WKW9NvnyuEpohiogVM8LIbDndtRJj16DKdmg2VM0kec9WgRve0qXDyE1JwI89IE8e79/rqVWNbiZboIcio/zz8CWVGqxiBfGXm6IFQkoKushkP6L73TcJZu6Xa/3Daj63YBnnGkAu40gDqw0l2Zvv0vQxOCHzF6HNoP+7v7+VGJuC9eBEUzGCAGwgIaqb+Q+iyg+FEV7joCWcBvNgoJuqBXxHDV+E5B7jT8676+yWOihkFEw37UqFzotUjVCXTcXqmXzBADsEm02VWm2rQGFp4IRFicPPKYXa7G0d/T77QAFXDuqOnNCEyWEXh8ohpVF/2QsskKqBhWhuqerTx2um354iGYxqdefjW42Pa1uEO9sONYxKk77BwPxzKCpqkC7GWjh558xMsjx2qmyawKg2IGaxLkbOcvOltPiOJ78wPQi1uLn0zunwqvoYr4YIxdd7N4iV+BTd6LeKWtkkESE/XlX4ikqpFY7tckLBkA9+BiUwiOcRWVoSnOy4q97dTLiMBW+qFXq8n3xaSYH0sus7uAIwYtFfMv7L6RCxz7m2/5/hX82KBSOZknp4pirhgU9h8/RcF+1vLZdbElNIUKiw+wjMKaH07AeNMFqJM/KXp6Gsoh3f1T7DnRT16E9+lg1+TPuNG4o8e902TK3NMkD8xadl+lqx5mh13bH0ys5gUaahD
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(2616005)(5660300002)(6486002)(66476007)(66556008)(66946007)(26005)(8676002)(6916009)(54906003)(4326008)(508600001)(8936002)(7416002)(2906002)(53546011)(316002)(6506007)(31696002)(186003)(36756003)(6512007)(83380400001)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MU4zcjJ5d2dDeE1RdGQwSFZrYkR4RDExNGlUSHpHRzY3WUcxV0lIRkRCVVJW?=
 =?utf-8?B?Wk5jbDVOODNhcUlWMUg1YmNTYnN0N0tJWlQ1d1NmdUNyTG9ESjZ2SCtja3h3?=
 =?utf-8?B?dEUvYmxIUTNDYzB5TUk1b2N5V1o0bGkzNFZoSnAzQm5Cd0ZwcTdEMFBLK014?=
 =?utf-8?B?N1hDUEZUZTc3MlQ4Z3FNRDdpNXBLamlseGdFbkNuMGt5bEJYbkp2M28wY3hO?=
 =?utf-8?B?SzgzRXo0Yzhrb3dwY0xHeHNqdmNqN0FJT3diN1RGMTF4SjdHK0o0dE5BRDg2?=
 =?utf-8?B?bE9LVkZlYTdya0xSL2k4d3BIaks4cGJrWmt4UThmUm5sdDJSN2hWQWl1Qy9G?=
 =?utf-8?B?eTkwNFdrRkVmbmIyWjljbHd2WnVkWlcxcEtyZWhXS282R2pFOHljNXJHaktT?=
 =?utf-8?B?NEhRMnkzTWJZUC9LN2hiMnNKU3h2cjNOWlFpdFAvalA4MVp2Vm1DaEVXQlFQ?=
 =?utf-8?B?OGNYU1d0b0ZDa2pTeU5oazM3eFJzWGJsbFNKRjI1OVJUNDVZckJUV2wraXF3?=
 =?utf-8?B?VjVrU2twK0wrTm9BeGNZNHFGSHRvay9ySHplcFFOWWprWHppYVIxeVFsbFFJ?=
 =?utf-8?B?dzJOb1lrRk01bEhqYkN2YUlkK3BTcWVxZXkxcGhObkR4Z045VnZQSGlsaVh0?=
 =?utf-8?B?S2pUSHhkeUtOcjQ2S09RNWhLMm4zVExWMlFmbzZMcjFXZ0xIYzg1VTlCVS9r?=
 =?utf-8?B?WXdXaENnUE5WVk1jWDhDRjdwY2sxT0M1a2dqNTh4c1BVWmNUTXVndWFraVlw?=
 =?utf-8?B?U05SRWFMdGdTZThqZUR3aUU5R1VNS1BvMXlCb3kyK29Rb252TEdHTmFlWnQ4?=
 =?utf-8?B?b3ZDU0VYenpqRWdPeFp5ckZxVVZTbjBVN3hkbW1yV3ZES3krUjdaZ1ZpU3k0?=
 =?utf-8?B?QTh6TEpUcDIyOEJwNnRiUlBmWHVTOVlXT25JUWRJb3A0c0VqVE9rR0dYTGZY?=
 =?utf-8?B?ekZrSzhadTlDdEkwcDBPZ0FLTTl6SmIrVy95eUJiOWUyTHQwK3NkZUJGNldB?=
 =?utf-8?B?RGUxdjVNOHFGUTBCV1JTMzQyNW5MTENlRlo4bW5VamRKSmtvd1Zyc1RKWWVW?=
 =?utf-8?B?UVdsVkU3ekY2K1plbHF2djBqVTdCUXBaVWJPZldqb2FSWVAzYnhDU2s2bmQ3?=
 =?utf-8?B?SDlPVU5TNGhOd1VLZE1uUHBVMUt1dGZLWXR4dVUxb2tzNysyd2RBb1VQZVV3?=
 =?utf-8?B?OERudVdYTFAxcVpBcHlicE82SEFSM3Y4M1ZSNmxqd08zWkpteHVlZDJ1SHJX?=
 =?utf-8?B?dHloeHBkeGljbG93cU40SlZhak9NWmRoZmNWL21CcTFLTjdxOEk4ZGNldnFP?=
 =?utf-8?B?ZFNUM05peTB3Sk5Ub2JlRnViUERiajlRK2tyRnF2VVkvWVk2Y3BRdFZ3RXFr?=
 =?utf-8?B?Z0NDTEpqbGtzYTFKMFlWN3czSmF3QWRtbFdKV0hHOXBDK3hNdFRITjQ2ditT?=
 =?utf-8?B?YXJSVVVDUzkxSkVKR0FaZEg1cUZQSThQRCs1cllUZk5NOVlDUE1MRng1eFRD?=
 =?utf-8?B?Y3pDbkdjOEZFT1V4VXVtMHFHYnVObFlCNWJlQ1VlLzEzeUpSWnJrTS9HVjlI?=
 =?utf-8?B?ZUd6U2EzTGd4NS90b0NnRDgxRkRPckhDQ1lQdmxqWGllSlBGSEUvK1k1R2lX?=
 =?utf-8?B?UFEvTHAzNHVEdVY4L3JCMWhJdmorUkM4dzgvTzRKc0lKYUNGL2dwUXZJY0FK?=
 =?utf-8?B?Q2MyWHpoanUrRWUrQ3E5bjBhMG9XMlQ5Z2MyYVNSWjdpWTA1WkZoTnRXV0Iz?=
 =?utf-8?B?eXBCR09wbld4MXFjNm4zNFNBLzVnaStCYmtKNnl4bWVQRi9TTlc4L2txRis0?=
 =?utf-8?B?TTVzbXNpaU02b1QxL2ZoWHJSb2J2VnQ1NE5PWVhQWFl1UjJpekdkSUJ6cFc2?=
 =?utf-8?B?YnYxczRtZG9BTzdIelY1UFBsUUtQVUhVZlg0ZnlGVUFYNm92S25HeU0vN1NB?=
 =?utf-8?B?WitKOGhFZjE1RTN6eWxqMWk5ZUhVL0ZZdTdKb2svaFVySHFXUDhHV2Y0ZVVN?=
 =?utf-8?B?NmttR0p1UWNoc2xLdDREUjFsL3U3Zks5N2FkZHNtMHd0aVJuK0dacDJDZmpm?=
 =?utf-8?B?cjV5S0U3TXdZMFVFTnVPd0NXeGtlQ2NxZlZIREQ3RjRTOERpdEI5M0R0TkV4?=
 =?utf-8?B?YUxDZVJPTk85NTJPMGJlYm5JajQzUFh0cDkxU0VCOC93U2hDV3lHNnY4Mkgv?=
 =?utf-8?Q?empnn1p4silIhaYy+dAUf3k=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53ed3f08-c87a-4ff8-8967-08d9c1306417
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:39:43.2560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x90NWk8orPEDcX81oJDSJEhUI8fnUOIiSF+FfQS1HuLNvyvYA22TBMUqvRUa3tkbx7M5l903LXNyhxfO1NVcNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 16.12.2021 22:15, Stefano Stabellini wrote:
> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>> On Wed, 15 Dec 2021, Juergen Gross wrote:
>>>>> On 14.12.21 18:36, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 08/12/2021 15:55, Juergen Gross wrote:
>>>>>>> Today most hypercall handlers have a return type of long, while the
>>>>>>> compat ones return an int. There are a few exceptions from that rule,
>>>>>>> however.
>>>>>>
>>>>>> So on Arm64, I don't think you can make use of the full 64-bit because a
>>>>>> 32-bit domain would not be able to see the top 32-bit.
>>>>>>
>>>>>> In fact, this could potentially cause us some trouble (see [1]) in Xen.
>>>>>> So it feels like the hypercalls should always return a 32-bit signed
>>>>>> value
>>>>>> on Arm.
>>>>>
>>>>> This would break hypercalls like XENMEM_maximum_ram_page which are able
>>>>> to return larger values, right?
>>>>>
>>>>>> The other advantage is it would be clear that the top 32-bit are not
>>>>>> usuable. Stefano, what do you think?
>>>>>
>>>>> Wouldn't it make more sense to check the return value to be a sign
>>>>> extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
>>>>>
>>>>> The question is what to return if this is not the case. -EDOM?
>>>>
>>>>
>>>> I can see where Julien is coming from: we have been trying to keep the
>>>> arm32 and arm64 ABIs identical since the beginning of the project. So,
>>>> like Julien, my preference would be to always return 32-bit on ARM, both
>>>> aarch32 and aarch64. It would make things simple.
>>>>
>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a
>>>> problem in reality because the max physical address size is only 40-bit
>>>> for aarch32 guests, so 32-bit are always enough to return the highest
>>>> page in memory for 32-bit guests.
>>>
>>> You are aware that this isn't the guest's max page, but the host's?
> 
> I can see now that you meant to say that, no matter what is the max
> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
> supposed to return the max memory page, which could go above the
> addressibility limit of the VM.
> 
> So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
> even when called by an aarch32 VM, with max IPA 40-bit.
> 
> I would imagine it could be useful if dom0 is 32-bit but domUs are
> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
> configuration on ARM.)
> 
> Then it looks like XENMEM_maximum_ram_page needs to be able to return a
> value > 32-bit when called by a 32-bit guest.
> 
> The hypercall ABI follows the ARM C calling convention, so a 64-bit
> value should be returned using r0 and r1. But looking at
> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets r1
> today. Only r0 is set, so effectively we only support 32-bit return
> values on aarch32 and for aarch32 guests.
> 
> In other words, today all hypercalls on ARM return 64-bit to 64-bit
> guests and 32-bit to 32-bit guests. Which in the case of memory_op is
> "technically" the correct thing to do because it matches the C
> declaration in xen/include/xen/hypercall.h:
> 
> extern long
> do_memory_op(
>     unsigned long cmd,
>     XEN_GUEST_HANDLE_PARAM(void) arg);
> 
> So...  I guess the conclusion is that on ARM do_memory_op should return
> "long" although it is not actually enough for a correct implementation
> of XENMEM_maximum_ram_page for aarch32 guests ?

For 32-bit guests the value needs to be saturated and allocations be
restricted to the "visible" part of physical address space. Just like
we do on x86. Except of course for Arm the question is in how far
knowledge of the largest physical address in the system is actually
relevant to guests (i.e. like for HVM on x86): This isn't transparent
only for PV, or at least it better would be restricted to PV.

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:45:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:45:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248450.428566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7w0-00063z-TU; Fri, 17 Dec 2021 07:45:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248450.428566; Fri, 17 Dec 2021 07:45:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my7w0-00063s-Oq; Fri, 17 Dec 2021 07:45:44 +0000
Received: by outflank-mailman (input) for mailman id 248450;
 Fri, 17 Dec 2021 07:45:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=zqed=RC=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1my7vz-00063m-05
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:45:43 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 556867e7-5f0d-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 08:45:41 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2054.outbound.protection.outlook.com [104.47.12.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-SRvdX3doMpeHhn2cOvbgag-1; Fri, 17 Dec 2021 08:45:40 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Fri, 17 Dec
 2021 07:45:38 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.016; Fri, 17 Dec 2021
 07:45:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 556867e7-5f0d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1639727141;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=qcUuXRJge8RWhJbZRHFg8OMe8tfU/g5vm435YLV2DEw=;
	b=GmxxdIcq4/dhdQJmLYwDWps0FHEWsCw/wFYSTeVB1n+diLLSNE/dFdKOaPh2b8/pGhxsfy
	aUerMJVQwPPcxMpD655mYa8AbKqsaooWQhINYoCmMGTCfXosHsoF0LukkutzEmI/rrMx1L
	okn6nYoRouanf08EkMaabPBJEooVw6I=
X-MC-Unique: SRvdX3doMpeHhn2cOvbgag-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=lVu0FHmLwsdjT3lRV1s1qUuuiZgXiuv+4JlUiREON3L66hT59fKXsHJ2rfq2p2JmvodV0dsarMvWM/OcsbswWHOeX4VOdpItEQdg7qx9hZ1ctSOA5axyRtRWz/6kMvOJAM+rVRWG1EhwhAZpnttp1IvXMlx8BU9Z1rkDDETqTPZS/LKSWLctyzdPjrC0Kemj6b3AJOpmJNnJR12Ux5PKyHLa0/0cIH/6hN4Vd+CZxOyuvktGdfkeKRpLvGn1+hoabvV5n49l8rilfYrIvG1C0NtnKYTt7b1Y83Sy1WYp2VYMTelfbPPSkgprZzLEB3y9QR+NEkl6FFoe/sYMFbxCXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qcUuXRJge8RWhJbZRHFg8OMe8tfU/g5vm435YLV2DEw=;
 b=Bk34KXFISe+4EsRKvbt8HW0GQLWwx327GlfUjuE4u6yLXGpcR6YbOuc8thdoMIW/DOgBTo7cvg4fRfdPqfKkE4hxRXd9FHR0nXyhOrVffG5DPrt0TjtbvKGoZp/DjPvocD4xx7tWYy10Qrgmm2dE59FUylNBvCCp4BTimuzB4avxzJKLlfGKpUiCfZRGcdjlJhMoVXUuQoj/s6nT4kOZwQcpYNqoU6xofGzpLv6h7/JtBCquUYwbnkdzeJHF96pJrwHye0YePmEbRK7gyVQPSqyja8tkwjXvTu1tcBYGM7cCDKUozGyvA97V5rWAkFM37nbjsd4+K4DPTL6+/YUn+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
Date: Fri, 17 Dec 2021 08:45:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Content-Language: en-US
To: Juergen Gross <jgross@suse.com>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR04CA0039.eurprd04.prod.outlook.com
 (2603:10a6:20b:46a::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 304fc689-83e6-48bf-edea-08d9c1313788
X-MS-TrafficTypeDiagnostic: VI1PR04MB7150:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB71502250D8ECD90ADC73AC16B3789@VI1PR04MB7150.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PmLdjnfuuIv7y7decwER5DWKKcA5B+Kd/g/gSzP8neTJ+srLfQSiDJ4MAaQ9deIPxrmzDAJf7k7+seMC0+IK/a/8lG/roipDQJAtly5jHct92tRH/Hjq+0rY15fHNYbzQxptBjMAQL0+8hBIanZuXpftlJyULY0wk2zdwFQHv7/2XvjQLsUoBi6rlEtSIl4pEidbxRx5pBx3oAUKypJEOk8ElwIc/3tYsP2ccrZjvh65Ga73Ly4PqXOA3hFVDlTYwW2qjc5ihYD2ja+NtDG91mvFFUXSW6mIZmValEpCWEbdxTuokpxQy2wXfTpmm3XBQQr2Jr2UtZO89FzpS5BuuU0PUoBiQLGyzpqIgIrm7MQFIVTaSAFae5zmgWIOAaBzt/2dtjVeX8NzXQG/pg9xEIVmAjDCREEGZ+MmMvVqae5+iMtf/z/89k107avrd6UwhUvh4mCvLTh+b6IhyK7tJG9lO24s7xgRMbrhLSmCaKUSxiBtZQzUSz+3JjBGGXwZsk7RG0qI0z3wYLtuftEuQn6D7IS997cQOASGvHrLWoGOMMFyLGlnaR09oKNubYpC7jBKedfs1fBmMwT1IH4AQ61qZLe8fNMzvsmH/UhmR1N92/drr41f2S9hHUSfNkB1nfwTyMLybcup40XxbQfHep7X7AIbDAkgeM5YWOGWyYD3aqiYypDgGL85VcR+yZ99+7wS/qbf4EFYFMayQCsd8DWHC3Ctq9D9FggikMgLKRhJ6At9ErszQb1IQ2piAhKj
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(6512007)(37006003)(5660300002)(4326008)(66946007)(8676002)(66476007)(31696002)(66556008)(2906002)(316002)(6862004)(38100700002)(36756003)(8936002)(54906003)(53546011)(31686004)(508600001)(26005)(7416002)(6506007)(83380400001)(2616005)(6636002)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFJzRk1UMmRSenVLTGh4MUFZR2pXZ3ZWZ0VKKzlINUZaU3czZ2Fkc3ZWWHZK?=
 =?utf-8?B?eTlaOC8raWk0YmliZE8yNGxjSGVXd1dzUWRaS1Y5TmJkQVBjWlBzSXArT2t0?=
 =?utf-8?B?V3lCYXJTL1ZXYjRBT0c4alBmQmZvS3ZjN0RIaXpNZW9yNkdoZU5OZHdNTkpO?=
 =?utf-8?B?RFRhQ2tRdURFZ0ZvSzB1YllRbnU2akFSUnNrQnVJSHJZaDNDS0huaFMyU0Qz?=
 =?utf-8?B?Skp5SzFmaFRzK2xFRFVuZmtMVEMzbDJxaUd3WG00VnF4aTBId0Y5T211RXl5?=
 =?utf-8?B?alNIci92c0ZyVmdmbWNpWUU5eVlRNDRhWnA5cXBTNkVtMjZxdi9qbWdSbTl1?=
 =?utf-8?B?TVd1cVFETC9JMWNKS1MzQ2RjUVNXYjZ2bTdsOUdTdkZyQVR5Z2pxNUNHdmVi?=
 =?utf-8?B?cGI2WDIyUnQ0OEVTVnAxNlNSblBtWHlHTEFaN3R1dytHWXoycjdoRWNvaUxK?=
 =?utf-8?B?dFczVUgvZ3BoOTY4cUlUUE9nWjRrOVlDYnB2N3MrV3ZGTXJEaWdvWGpBMEw5?=
 =?utf-8?B?cncweDhCZ0VFTmlUVThGWE1HU25UN2hjWEZFOHM5ZjMwTmZSS2N4Qy9naXVG?=
 =?utf-8?B?MDZPRDZ5L2lEY2l1YUpzRzBndjRvRmtKSGs3RVNFQkhpSG1oeDc2Lzl2ZGRl?=
 =?utf-8?B?ZFlUQTh0aWxUcURTV0ZIcWpyUU92dVlsd3pabmFmUkFzZEtFNm9rKzllOXdD?=
 =?utf-8?B?YVI3dHZjOUxBdStiY2ZPQ3IySmhUalFaN1FnVlRZaTV5byswTzVHajhidytt?=
 =?utf-8?B?cWFHazE2ckw0Y0pKYmVSRDErR0xFdTNpWFhuVTdtMjdIc2pTWkRsWlB5Rm1J?=
 =?utf-8?B?YUlNN2FKMnNiZUtWOVA2azg4SEx3T0ZKbCtGMjlFcWtwK1lBcjRLUDcyZG5B?=
 =?utf-8?B?ek1FdFR3aVhFakt4bXVISTR2SG1iK04valdlcUNUbnRnUjFtQTNnZCtOQm9p?=
 =?utf-8?B?cThoTlI3aTNmTHlydFZPK0FLSHNieVdSQTBUcmhyOTRGRk82blgxZlk0dzEy?=
 =?utf-8?B?cWEzWTBzaXRCd2pZZWlaNXl5ZzBPUzNmelNvdEp0VFN3N3pTOW1IZnJGbXF3?=
 =?utf-8?B?Ujl1Nld2Q2ozR25NNlpjYWRjcW5pZEFaN1UweWRJeWdmRGZFeUhXZ0NuamNS?=
 =?utf-8?B?bFQvMzl5ZzdpK1I0R2ZIRElITlVSS2ZhWFZ0ZFNiT012VDBBSzFCamZIOFE0?=
 =?utf-8?B?YXpReHBjUDFoVExSTFIxdkVRNWFYNE9Ta3JQdC9vck51OW43R2h4MUZGa2V0?=
 =?utf-8?B?ZEdOdmRJd2dZSE9LQktxWHBmWkRjdE5pYU9RVUV2RkVzeTlmQ28wdzgxL3NL?=
 =?utf-8?B?S0FQUVhTTDcwNUp2amx0ZzZBM1haT3JQUSt4WVdWZXlwR010blVucGh4eEd6?=
 =?utf-8?B?RFplOWFCOTZOZEE4Vkh5aW1XQWs5NnhGcGlBWGxndHJtT1NaWWdKYzlVYjdE?=
 =?utf-8?B?K3RlN1RBaEoyQjBaN2ZhTHFMa2V6OGJPTUh2RjNaUzVhU1QxVXRjdVhjYjhx?=
 =?utf-8?B?eXp3S3laU1doNVYwQjZMRXlhRmlJUVdsR3NyWkZZYzFVNHgzRzBLSTZONmR6?=
 =?utf-8?B?cHBmNGlKWTZ2cFVLbC9DSjdsZSttb05oOUlyOFhqNE1aOGw3VXY4TG5GVURI?=
 =?utf-8?B?bkNhS1VMM0VjOHFMZUwyUVlMKzkwWXA2YVN4ei9VbUdIL01mVHJKbk5CU1NK?=
 =?utf-8?B?RFhCVjNETHdGdUlJemMxMTk5N29KWUFYV3lpU2dGZ0haQVlXZ2Z6a3dzWHNJ?=
 =?utf-8?B?SmJibkVaVCs0RWUzcFdkdWNKMVZaN0JmamhGbmdwS0c3UVkydHFlSXFFWmVM?=
 =?utf-8?B?ODgwSG5wSDVCTmp1SE92K1dTb1hQbW85NUhCaFFMS0w1Rm1ZNGZ4T1JQMnUr?=
 =?utf-8?B?cXpGTGFmY3RKcXoyWnVpYU5pSUQ4NC85aGtWVkh5bEpJMWVqZm1CWklmbVd2?=
 =?utf-8?B?WEJhQ0Z2cDZVdjV3VTUySG9EbnlZcjNwK3JrOGlJYitpYVpUN1VyOXZNbksx?=
 =?utf-8?B?MEpNUmhiYyszRitmaDNoaU9GZnZkQkEyQnJtN1pJNllsRHpmQUExQVhYbHUx?=
 =?utf-8?B?aUpqVCtRV0cyVWxPRFI0UzdpSmdzR0xxZm5FcG9nRW9PQnZhWnRuTTN6YmxQ?=
 =?utf-8?B?NjJvKzljMkVsUEZGMXY2dHF0MEFJT2NrNVBDZU1FcTBDQkJObW85ZWhqQjNM?=
 =?utf-8?Q?Mu1Dl5bCKZ2Pap4Xt1Gw/CQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 304fc689-83e6-48bf-edea-08d9c1313788
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 07:45:38.0423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZdeA7laYw9gqAPQI6xOjEIHqwpzOGsHvRAZK13EMqt2CaqP3uLwfMSGarIM20RxtSODz89crY4+4pCrFBYwnxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150

On 17.12.2021 06:34, Juergen Gross wrote:
> On 16.12.21 22:15, Stefano Stabellini wrote:
>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a
>>>>> problem in reality because the max physical address size is only 40-bit
>>>>> for aarch32 guests, so 32-bit are always enough to return the highest
>>>>> page in memory for 32-bit guests.
>>>>
>>>> You are aware that this isn't the guest's max page, but the host's?
>>
>> I can see now that you meant to say that, no matter what is the max
>> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
>> supposed to return the max memory page, which could go above the
>> addressibility limit of the VM.
>>
>> So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
>> even when called by an aarch32 VM, with max IPA 40-bit.
>>
>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
>> configuration on ARM.)
>>
>> Then it looks like XENMEM_maximum_ram_page needs to be able to return a
>> value > 32-bit when called by a 32-bit guest.
>>
>> The hypercall ABI follows the ARM C calling convention, so a 64-bit
>> value should be returned using r0 and r1. But looking at
>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets r1
>> today. Only r0 is set, so effectively we only support 32-bit return
>> values on aarch32 and for aarch32 guests.
>>
>> In other words, today all hypercalls on ARM return 64-bit to 64-bit
>> guests and 32-bit to 32-bit guests. Which in the case of memory_op is
>> "technically" the correct thing to do because it matches the C
>> declaration in xen/include/xen/hypercall.h:
>>
>> extern long
>> do_memory_op(
>>      unsigned long cmd,
>>      XEN_GUEST_HANDLE_PARAM(void) arg);
>>
>> So...  I guess the conclusion is that on ARM do_memory_op should return
>> "long" although it is not actually enough for a correct implementation
>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>
> 
> Hence my suggestion to check the return value of _all_ hypercalls to be
> proper sign extended int values for 32-bit guests. This would fix all
> potential issues without silently returning truncated values.

Are we absolutely certain we have no other paths left where a possibly
large unsigned values might be returned? In fact while
compat_memory_op() does the necessary saturation, I've never been fully
convinced of this being the best way of dealing with things. The range
of error indicators is much smaller than [-INT_MIN,-1], so almost
double the range of effectively unsigned values could be passed back
fine. (Obviously we can't change existing interfaces, so this mem-op
will need to remain as is.)

Jan



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 07:51:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 07:51:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248456.428577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my81B-0007eB-H1; Fri, 17 Dec 2021 07:51:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248456.428577; Fri, 17 Dec 2021 07:51:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my81B-0007e4-Dk; Fri, 17 Dec 2021 07:51:05 +0000
Received: by outflank-mailman (input) for mailman id 248456;
 Fri, 17 Dec 2021 07:51:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1my819-0007dy-QQ
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 07:51:03 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 149a42a2-5f0e-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 08:51:02 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id E0A171F3AD;
 Fri, 17 Dec 2021 07:51:01 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B0BFB13F21;
 Fri, 17 Dec 2021 07:51:01 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id jrLdKWVBvGFWZQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 07:51:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 149a42a2-5f0e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639727461; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=Ge/T7sfWxdaImWMIF/IC9l8ofgbDkde6Zgt9g58mXQs=;
	b=mc6XG7Xx3c4gssU/JCCnlbwMieWQYmYFZxhyT/UnUwG0Cxmdd3wZVMrE6FJ/dw0SsYw3wu
	rckMdGcrQ5NSlnEW1wgNqPrlxMP+2B9V+VJPKLpswpRNSqtCXH+HFG7gkuPVHxasX3e8uy
	Lcf85BSiqIcKTgMLPUdkAan5VucdaiE=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Wei Liu <wl@xen.org>,
	Julien Grall <julien@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH] tools/xenstore: drop support for running under SunOS
Date: Fri, 17 Dec 2021 08:50:59 +0100
Message-Id: <20211217075059.14466-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Since several years now xenstored is no longer capable to run under
SunOS, as the needed libxengnttab interfaces are not available there.

Several attempts to let the SunOS maintainers address this situation
didn't change anything in this regard.

For those reasons drop SunOS support in xenstored by removing the SunOS
specific code.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/Makefile            |  15 +--
 tools/xenstore/xenstored_core.c    |   7 --
 tools/xenstore/xenstored_core.h    |   4 -
 tools/xenstore/xenstored_minios.c  |   4 -
 tools/xenstore/xenstored_posix.c   |   6 --
 tools/xenstore/xenstored_probes.d  |  28 -----
 tools/xenstore/xenstored_solaris.c | 168 -----------------------------
 7 files changed, 1 insertion(+), 231 deletions(-)
 delete mode 100644 tools/xenstore/xenstored_probes.d
 delete mode 100644 tools/xenstore/xenstored_solaris.c

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 292b478fa1..c86278fdb1 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -27,7 +27,6 @@ XENSTORED_OBJS += xenstored_transaction.o xenstored_control.o
 XENSTORED_OBJS += xs_lib.o talloc.o utils.o tdb.o hashtable.o
 
 XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_posix.o
-XENSTORED_OBJS_$(CONFIG_SunOS) = xenstored_solaris.o xenstored_posix.o xenstored_probes.o
 XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_posix.o
 XENSTORED_OBJS_$(CONFIG_FreeBSD) = xenstored_posix.o
 XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o
@@ -50,18 +49,6 @@ all: $(ALL_TARGETS)
 .PHONY: clients
 clients: xenstore $(CLIENTS) xenstore-control
 
-ifeq ($(CONFIG_SunOS),y)
-xenstored_probes.h: xenstored_probes.d
-	dtrace -C -h -s xenstored_probes.d
-
-xenstored_solaris.o: xenstored_probes.h
-
-xenstored_probes.o: xenstored_solaris.o
-	dtrace -C -G -s xenstored_probes.d xenstored_solaris.o 
-
-CFLAGS += -DHAVE_DTRACE=1
-endif
-
 ifeq ($(CONFIG_SYSTEMD),y)
 $(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
 xenstored: LDFLAGS += $(SYSTEMD_LIBS)
@@ -89,7 +76,7 @@ xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
 
 .PHONY: clean
 clean:
-	rm -f *.a *.o xenstored_probes.h
+	rm -f *.a *.o
 	rm -f xenstored
 	rm -f xs_tdb_dump xenstore-control init-xenstore-domain
 	rm -f xenstore $(CLIENTS)
diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 91d093a12e..c386ae6129 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -146,10 +146,6 @@ static void trace_io(const struct connection *conn,
 	time_t now;
 	struct tm *tm;
 
-#ifdef HAVE_DTRACE
-	dtrace_io(conn, data, out);
-#endif
-
 	if (tracefd < 0)
 		return;
 
@@ -2337,9 +2333,6 @@ int main(int argc, char *argv[])
 	/* Get ready to listen to the tools. */
 	initialize_fds(&sock_pollfd_idx, &timeout);
 
-	/* Tell the kernel we're up and running. */
-	xenbus_notify_running();
-
 #if defined(XEN_SYSTEMD_ENABLED)
 	if (!live_update) {
 		sd_notify(1, "READY=1");
diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
index 07d861d924..190d2447cd 100644
--- a/tools/xenstore/xenstored_core.h
+++ b/tools/xenstore/xenstored_core.h
@@ -225,7 +225,6 @@ int delay_request(struct connection *conn, struct buffered_data *in,
 void trace_create(const void *data, const char *type);
 void trace_destroy(const void *data, const char *type);
 void trace(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
-void dtrace_io(const struct connection *conn, const struct buffered_data *data, int out);
 void reopen_log(void);
 void close_log(void);
 
@@ -250,9 +249,6 @@ static inline int xenbus_master_domid(void) { return dom0_domid; }
 /* Return the event channel used by xenbus. */
 evtchn_port_t xenbus_evtchn(void);
 
-/* Tell the kernel xenstored is running. */
-void xenbus_notify_running(void);
-
 /* Write out the pidfile */
 void write_pidfile(const char *pidfile);
 
diff --git a/tools/xenstore/xenstored_minios.c b/tools/xenstore/xenstored_minios.c
index c94493e52a..aa384e50c8 100644
--- a/tools/xenstore/xenstored_minios.c
+++ b/tools/xenstore/xenstored_minios.c
@@ -38,10 +38,6 @@ void init_pipe(int reopen_log_pipe[2])
 	reopen_log_pipe[1] = -1;
 }
 
-void xenbus_notify_running(void)
-{
-}
-
 evtchn_port_t xenbus_evtchn(void)
 {
 	return dom0_event;
diff --git a/tools/xenstore/xenstored_posix.c b/tools/xenstore/xenstored_posix.c
index 48c37ffe3e..b20504d1b6 100644
--- a/tools/xenstore/xenstored_posix.c
+++ b/tools/xenstore/xenstored_posix.c
@@ -111,7 +111,6 @@ void unmap_xenbus(void *interface)
 	munmap(interface, getpagesize());
 }
 
-#ifndef __sun__
 evtchn_port_t xenbus_evtchn(void)
 {
 	int fd;
@@ -158,8 +157,3 @@ void *xenbus_map(void)
 
 	return addr;
 }
-
-void xenbus_notify_running(void)
-{
-}
-#endif /* !__sun__ */
diff --git a/tools/xenstore/xenstored_probes.d b/tools/xenstore/xenstored_probes.d
deleted file mode 100644
index f72d38f935..0000000000
--- a/tools/xenstore/xenstored_probes.d
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
- * Use is subject to license terms.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 2 of the License.
- */
-
-#include <sys/types.h>
-
-provider xenstore {
-	/* tx id, dom id, pid, type, msg */
-	probe msg(uint32_t, unsigned int, pid_t, int, const char *);
-	/* tx id, dom id, pid, type, reply */
-	probe reply(uint32_t, unsigned int, pid_t, int, const char *);
-	/* tx id, dom id, pid, reply */
-	probe error(uint32_t, unsigned int, pid_t, const char *);
-	/* dom id, pid, watch details */
-	probe watch_event(unsigned int, pid_t, const char *);
-};
-
-#pragma D attributes Evolving/Evolving/Common provider xenstore provider
-#pragma D attributes Private/Private/Unknown provider xenstore module
-#pragma D attributes Private/Private/Unknown provider xenstore function
-#pragma D attributes Evolving/Evolving/Common provider xenstore name
-#pragma D attributes Evolving/Evolving/Common provider xenstore args
-
diff --git a/tools/xenstore/xenstored_solaris.c b/tools/xenstore/xenstored_solaris.c
deleted file mode 100644
index 06052d124a..0000000000
--- a/tools/xenstore/xenstored_solaris.c
+++ /dev/null
@@ -1,168 +0,0 @@
-/******************************************************************************
- *
- * Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
- * Use is subject to license terms.
- *
- * Copyright (C) 2005 Rusty Russell IBM Corporation
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation, version 2 of the
- * License.
- */
-
-#include <fcntl.h>
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdarg.h>
-#include <sys/mman.h>
-#include <strings.h>
-#include <ucred.h>
-#include <stdio.h>
-
-#include <xen/sys/xenbus.h>
-
-#include "talloc.h"
-#include "xenstored_core.h"
-#include "xenstored_probes.h"
-
-evtchn_port_t xenbus_evtchn(void)
-{
-	int fd;
-	evtchn_port_t port; 
-
-	fd = open("/dev/xen/xenbus", O_RDONLY); 
-	if (fd == -1)
-		return -1;
-
-	port = ioctl(fd, IOCTL_XENBUS_XENSTORE_EVTCHN);
-
-	close(fd); 
-	return port;
-}
-
-void *xenbus_map(void)
-{
-	int fd;
-	void *addr;
-
-	fd = open("/dev/xen/xenbus", O_RDWR);
-	if (fd == -1)
-		return NULL;
-
-	addr = mmap(NULL, getpagesize(), PROT_READ|PROT_WRITE,
-		MAP_SHARED, fd, 0);
-
-	if (addr == MAP_FAILED)
-		addr = NULL;
-
-	close(fd);
-
-	return addr;
-}
-
-void xenbus_notify_running(void)
-{
-	int fd;
-
-	fd = open("/dev/xen/xenbus", O_RDONLY);
-
-	(void) ioctl(fd, IOCTL_XENBUS_NOTIFY_UP);
-
-	close(fd);
-}
-
-static pid_t cred(const struct connection *conn)
-{
-	ucred_t *ucred = NULL;
-	pid_t pid;
-
-	if (conn->domain)
-		return (0);
-
-	if (getpeerucred(conn->fd, &ucred) == -1)
-		return (0);
-
-	pid = ucred_getpid(ucred);
-
-	ucred_free(ucred);
-	return (pid);
-}
-
-/*
- * The strings are often a number of nil-separated strings. We'll just
- * replace the separators with spaces - not quite right, but good
- * enough.
- */
-static char *
-mangle(const struct connection *conn, const struct buffered_data *in)
-{
-	char *str;
-	int i;
-
-	if (in->hdr.msg.len == 0)
-		return (talloc_strdup(conn, ""));
-
-	if ((str = talloc_zero_size(conn, in->hdr.msg.len + 1)) == NULL)
-		return (NULL);
-
-	memcpy(str, in->buffer, in->hdr.msg.len);
-	
-	/*
-	 * The protocol is absurdly inconsistent in whether the length
-	 * includes the terminating nil or not; replace all nils that
-	 * aren't the last one.
-	 */
-	for (i = 0; i < (in->hdr.msg.len - 1); i++) {
-		if (str[i] == '\0')
-			str[i] = ' ';
-	}
-
-	return (str);
-}
-
-void
-dtrace_io(const struct connection *conn, const struct buffered_data *in,
-    int io_out)
-{
-	if (!io_out) {
-		if (XENSTORE_MSG_ENABLED()) {
-			char *mangled = mangle(conn, in);
-			XENSTORE_MSG(in->hdr.msg.tx_id, conn->id, cred(conn),
-			    in->hdr.msg.type, mangled);
-		}
-
-		goto out;
-	}
-
-	switch (in->hdr.msg.type) {
-	case XS_ERROR:
-		if (XENSTORE_ERROR_ENABLED()) {
-			char *mangled = mangle(conn, in);
-			XENSTORE_ERROR(in->hdr.msg.tx_id, conn->id,
-			    cred(conn), mangled);
-		}
-		break;
-
-	case XS_WATCH_EVENT:
-		if (XENSTORE_WATCH_EVENT_ENABLED()) {
-			char *mangled = mangle(conn, in);
-			XENSTORE_WATCH_EVENT(conn->id, cred(conn), mangled);
-		}
-		break;
-
-	default:
-		if (XENSTORE_REPLY_ENABLED()) {
-			char *mangled = mangle(conn, in);
-			XENSTORE_REPLY(in->hdr.msg.tx_id, conn->id, cred(conn),
-			    in->hdr.msg.type, mangled);
-		}
-		break;
-	}
-
-out:
-	/*
-	 * 6589130 dtrace -G fails for certain tail-calls on x86
-	 */
-	asm("nop");
-}
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 08:51:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 08:51:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248472.428596 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my8wl-0006sQ-3w; Fri, 17 Dec 2021 08:50:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248472.428596; Fri, 17 Dec 2021 08:50:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my8wl-0006sJ-0J; Fri, 17 Dec 2021 08:50:35 +0000
Received: by outflank-mailman (input) for mailman id 248472;
 Fri, 17 Dec 2021 08:50:34 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1my8wk-0006sD-B6
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 08:50:34 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 64bddf76-5f16-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 09:50:32 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 470921F389;
 Fri, 17 Dec 2021 08:50:32 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E0DCE13F28;
 Fri, 17 Dec 2021 08:50:31 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id axsmNVdPvGEnfwAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 08:50:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 64bddf76-5f16-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639731032; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TXFADIgzw9rdlZGES3wfOqa/Ue6nqk8bvW3dwfzWNw0=;
	b=BvyTD8jbWdBfubzqEDepuFw/gMIYVA2Pkhoh8hx8/g7ql+TIXmI2vw5K1J2o75P5wqxjwY
	lpRnNpM2tdmAGReqMVwqnyg/kwxfUe3ztJruSbXYem+nIlIrNqpVHCRk5SXwenZBUP78hJ
	ArvxpoEOY4sLIvuScYusYVLum4w1g+Q=
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Message-ID: <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
Date: Fri, 17 Dec 2021 09:50:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="nasBDvb8IM7iEBsstkrk6ROKYs2XsboOK"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--nasBDvb8IM7iEBsstkrk6ROKYs2XsboOK
Content-Type: multipart/mixed; boundary="1E8sqgQO64EoiDLARRryPRlSx9qCBvQvO";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
In-Reply-To: <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>

--1E8sqgQO64EoiDLARRryPRlSx9qCBvQvO
Content-Type: multipart/mixed;
 boundary="------------9EB6E965C5C34C296DC064CB"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------9EB6E965C5C34C296DC064CB
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 17.12.21 08:45, Jan Beulich wrote:
> On 17.12.2021 06:34, Juergen Gross wrote:
>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a=

>>>>>> problem in reality because the max physical address size is only 4=
0-bit
>>>>>> for aarch32 guests, so 32-bit are always enough to return the high=
est
>>>>>> page in memory for 32-bit guests.
>>>>>
>>>>> You are aware that this isn't the guest's max page, but the host's?=

>>>
>>> I can see now that you meant to say that, no matter what is the max
>>> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page =
is
>>> supposed to return the max memory page, which could go above the
>>> addressibility limit of the VM.
>>>
>>> So XENMEM_maximum_ram_page should potentially be able to return (1<<4=
4)
>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>
>>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>>> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
>>> configuration on ARM.)
>>>
>>> Then it looks like XENMEM_maximum_ram_page needs to be able to return=
 a
>>> value > 32-bit when called by a 32-bit guest.
>>>
>>> The hypercall ABI follows the ARM C calling convention, so a 64-bit
>>> value should be returned using r0 and r1. But looking at
>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets =
r1
>>> today. Only r0 is set, so effectively we only support 32-bit return
>>> values on aarch32 and for aarch32 guests.
>>>
>>> In other words, today all hypercalls on ARM return 64-bit to 64-bit
>>> guests and 32-bit to 32-bit guests. Which in the case of memory_op is=

>>> "technically" the correct thing to do because it matches the C
>>> declaration in xen/include/xen/hypercall.h:
>>>
>>> extern long
>>> do_memory_op(
>>>       unsigned long cmd,
>>>       XEN_GUEST_HANDLE_PARAM(void) arg);
>>>
>>> So...  I guess the conclusion is that on ARM do_memory_op should retu=
rn
>>> "long" although it is not actually enough for a correct implementatio=
n
>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>
>>
>> Hence my suggestion to check the return value of _all_ hypercalls to b=
e
>> proper sign extended int values for 32-bit guests. This would fix all
>> potential issues without silently returning truncated values.
>=20
> Are we absolutely certain we have no other paths left where a possibly
> large unsigned values might be returned? In fact while
> compat_memory_op() does the necessary saturation, I've never been fully=

> convinced of this being the best way of dealing with things. The range
> of error indicators is much smaller than [-INT_MIN,-1], so almost
> double the range of effectively unsigned values could be passed back
> fine. (Obviously we can't change existing interfaces, so this mem-op
> will need to remain as is.)

In fact libxenctrl tries do deal with this fact by wrapping a memory_op
for a 32-bit environment into a multicall. This will work fine for a
32-bit Arm guest, as xen_ulong_t is a uint64 there.

So do_memory_op should return long on Arm, yes. OTOH doing so will
continue to be a problem in case a 32-bit guest doesn't use the
multicall technique for handling possible 64-bit return values.

So I continue to argue that on Arm the return value of a hypercall
should be tested to fit into 32 bits. The only really clean alternative
would be to have separate hypercall function classes for Arm 32- and
64-bit guests (which still could share most of the functions by letting
those return "int"). This would allow to use the 64-bit variant even for
32-bit guests in multicall (fine as the return field is 64-bit wide),
and a probably saturating compat version for the 32-bit guest direct
hypercall.

The needed adaptions in my series would be rather limited (an additional
column in the hypercall table, a split which macro to use in
do_trap_hypercall() on Arm depending on the bitness of the guest, the
addition of the Arm compat variant of do_memory_op()).

Thoughts?


Juergen

--------------9EB6E965C5C34C296DC064CB
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------9EB6E965C5C34C296DC064CB--

--1E8sqgQO64EoiDLARRryPRlSx9qCBvQvO--

--nasBDvb8IM7iEBsstkrk6ROKYs2XsboOK
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG8T1cFAwAAAAAACgkQsN6d1ii/Ey9Z
ngf9HY7Ldi1QjPIx9kDYWrbqCIzbuKPe8UKKvTqvGoPvh8tGXTGr1/OpAQQMXE7OypUpmf/DGAvQ
gFU6p6IR47pCrkTdTS78LLmDR6LS85SYmqr0Ym6/8up0VVZ8wJDVEdX4uJYhvxakTPDB+CnpdaPy
PXu7DyeI8NNVyZ2p79/ovpdzkmqFVagsjKUNcnsp6mCoOesvQA94MFeDid/fTRZK2UKcGNcCLquJ
liDzmHbANVMryP7liXpebKRGdc39jTSwBSLkIs+88kPQCzL+OyNNeaKnZzBILvcCG676OY+q2pwP
uKcNYSPxYOMKhczKutnzrXmVQgSn/8/U0Vut+NOo9w==
=2tT+
-----END PGP SIGNATURE-----

--nasBDvb8IM7iEBsstkrk6ROKYs2XsboOK--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 09:20:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 09:20:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248485.428607 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my9PD-0001YK-MX; Fri, 17 Dec 2021 09:19:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248485.428607; Fri, 17 Dec 2021 09:19:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my9PD-0001YD-JM; Fri, 17 Dec 2021 09:19:59 +0000
Received: by outflank-mailman (input) for mailman id 248485;
 Fri, 17 Dec 2021 09:19:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+ZwG=RC=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1my9PC-0001Xo-Ah
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 09:19:58 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on0611.outbound.protection.outlook.com
 [2a01:111:f400:fe05::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7f152144-5f1a-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 10:19:56 +0100 (CET)
Received: from DB6PR1001CA0022.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::32)
 by PAXPR08MB7383.eurprd08.prod.outlook.com (2603:10a6:102:22e::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 09:19:52 +0000
Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:b7:cafe::8a) by DB6PR1001CA0022.outlook.office365.com
 (2603:10a6:4:b7::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Fri, 17 Dec 2021 09:19:52 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 09:19:51 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Fri, 17 Dec 2021 09:19:51 +0000
Received: from 4f91257770a7.2
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 FEB87DB5-4C48-49D1-ACAF-B7038D204BD4.1; 
 Fri, 17 Dec 2021 09:19:44 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4f91257770a7.2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 17 Dec 2021 09:19:44 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6648.eurprd08.prod.outlook.com (2603:10a6:20b:38e::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 09:19:43 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%9]) with mapi id 15.20.4778.018; Fri, 17 Dec 2021
 09:19:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f152144-5f1a-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Txg9Jaq3eKDnyB6browgzLyrTGasYQusrflRASZqvZo=;
 b=i47VcVoM90t065fJaiu1fRa5mWrBxaRfucd8F9xb6Ne271KMllfDw2ziNWdLTmiVqJzT/fZ0zmej2GDA8P6rHqtFOA7zCA6PdhxlYIElKb/SxvmY3xu2VoPpEg762uJ7YKTtopufztFJdWlbiL4qkWWR2VsDONuqjWAIJxHncS0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 98f72cb22384e04a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IUjXbCLWgOm/hfzUlijPTmGwGg/RfGkv1DBB4VnPNPU54/Q+Qkawz/op9l/tYamZDIKpPlqXeAbM2c0CQnLdNUQBtVMh/HWdDhvX/e2N959/cUPfgGrB3SdQOkGo0X0LvL2nGcoe2MpYWMTo9H2Kt9yrvDcxhi7kb3jTKIlruVUot2IqGAum8853Y8cDppVJCOnxxjzaiw7WZfBBe2zKT91QMX42WFTtEo+01U9Sz4GcSOcApqefTHQWSWp1A1CAKBKsHT2qRgD/qnLUMeU+0lIaJ9SWCQjsGkK45F+a42/SckjpfYDHwoCsbfTsE2xs4I6nJNcvwSr0tsfCcaMWgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Txg9Jaq3eKDnyB6browgzLyrTGasYQusrflRASZqvZo=;
 b=LRMxvHMP385ls1oYaH9o8rUZ7zNtp1KqZALX3vPMu/cuTJv78ShjOt9y0tfCCFHFRmGgAcHX8zU3IWZkFt7/smqtJxGQ+gZnT72zzCx40w9Yccn/0XaQZSQCxwNNsCBxx7qUv5UUYtMH8AyOzlUT3xj+TgOEyy9+w1Veuc2VOVrcIBK/l7UD3ldMOe9zE5jfLm1UWT5hfU1UezE+CVhwGOPgF5isCzOTb5gO1IWenjlG7LLFAgXmhfuJo9FqGnpPLlt+oAagf2wjJjjliV9rssCIRKGClw8bRgCXWirRVMlJhFIobnnw7OCk1U4FqRbSuKEI8RQp50VFiBF344SnXQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Txg9Jaq3eKDnyB6browgzLyrTGasYQusrflRASZqvZo=;
 b=i47VcVoM90t065fJaiu1fRa5mWrBxaRfucd8F9xb6Ne271KMllfDw2ziNWdLTmiVqJzT/fZ0zmej2GDA8P6rHqtFOA7zCA6PdhxlYIElKb/SxvmY3xu2VoPpEg762uJ7YKTtopufztFJdWlbiL4qkWWR2VsDONuqjWAIJxHncS0=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: xen-devel <xen-devel@lists.xenproject.org>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
Thread-Topic: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
Thread-Index: AQHX8NfE0k+LAAwoDUiQfCEULp9EE6w0aQgAgAB74ACAAMbRAIAAwQkA
Date: Fri, 17 Dec 2021 09:19:43 +0000
Message-ID: <73F40E1F-0569-4F09-A105-6F67A5584D67@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <alpine.DEB.2.22.394.2112151817190.3376@ubuntu-linux-20-04-desktop>
 <AA684EED-5631-4036-ABF1-596AD61787CC@arm.com>
 <alpine.DEB.2.22.394.2112161347320.3376@ubuntu-linux-20-04-desktop>
In-Reply-To:
 <alpine.DEB.2.22.394.2112161347320.3376@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: cd374c12-9eb9-4574-143c-08d9c13e616c
x-ms-traffictypediagnostic:
	AS8PR08MB6648:EE_|DB5EUR03FT031:EE_|PAXPR08MB7383:EE_
X-Microsoft-Antispam-PRVS:
	<PAXPR08MB7383F770BDB90C90558E6D72FC789@PAXPR08MB7383.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 4pLDsmmup+ge5Li5rjI3SXVppfzeUjE/7H0RZ2aVIDyifCoJeq/IivPl/Qfk+MXMq8U6jk9p/Tihv4LPreXPcqaMAnT2/TULUfMjMo/eRyxTvKJYlAWJIpcmtCSWyPqXJ3tq6qa1Je0doa9MA4DaVoFJO0RTTKo8D86h5xb1ZhrJaNJsLvYWL+ukXSNrfZLX0LINJctQogVM5mBM42GjhrG5rtXMYJwMzMiv2olHWck/0F9XAhMsDDK7R1qoIe+UT8HzEH+5+NMCTe/9ZCyyis3tVGjtTzTK9w+ecWXj3VztYmQFoCCpIMq6tsnw1i6ycWYAEyxA/n8fpNHNL0SBtXRodnbLZJ2POjIxYb9ekP94IXbYMZZ9UH04qV5h7V4Fq+zNYa3EqT/qSm3BJB9Eymk9+iwLLaIzhhpRIB0kfOPOvTcT+M4XCHC25wZIfCPgudcuUJcn0WmxpiDE7hLSEGSMNGvdSZRAhESrNNkSSn/39m41vXpsHXWxNcDjQY8uEk1LvM++WEXzv1AR5b4gK6CaE6yb76orqQrgRPqcUZLXyY5EehdNClKvQZCtFA546TD94Qg5sQXaHmQb5f6M6c+SGwygKvzBZZMnzX8W6MD0JRF3LbfZTaqOqStygGmeA7QTjTDENJyk1jbnZE+VqThRPucQlULxNHc/LylhBFaBMALj5/HoMLW95yGdrEkH7fOO4RmwlJvEliSmglBZz7Y9g4dXmZ0/IkoxbgFyws77bbYRDbb3X8so1zO57rgZ
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8676002)(76116006)(91956017)(6512007)(64756008)(83380400001)(71200400001)(122000001)(53546011)(6506007)(2906002)(38100700002)(6486002)(26005)(66446008)(316002)(36756003)(508600001)(2616005)(6916009)(33656002)(66476007)(8936002)(86362001)(5660300002)(66946007)(66556008)(186003)(4326008)(54906003)(38070700005)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <A0D193A5B1583F4CADD76C5005B4610E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6648
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	94b6eb4b-4626-4be7-20e1-08d9c13e5c78
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	14VHZNTKEtyme4noDXS6W6ZXL5+k9+eIZSkYlikRom+8hhlhk6NRUwXzkY1K8FRajRaNlclcU7AvWRjLWLjg796OK5ofdC5206W5xtIIjxz1UNQxWCIBBXpw7k3mULtPqsBtcD+3LNf/rBbGBRatn4JLor1eTkAR0pGirzf+q6a4wej6WrCnaxoIFIMmh9aA/LPixqTu2jrXU8MdDkYyJtQ8xf20rRO9k6bNXITG2jfDHL4bdZwXYrgURabAOPQL8Ru9EvAzdPnkZjoQY2BWGkquXfWt21gnCMwnFxWhjS34vmmB6zpHhBV4q3ZEHfc4sa7ln1ggnflSW6CP3I9Pp85slb7DKFdKR6MSRQpr3eX6G7xvgqUVokGvzFHF5AbW+xqSdkHPoyYpSakI2LiGhxXs1bM+zs0dN6eL6SQSo6raT5ucvZtlnGaKzHQ7d/PpZ5XAfnJ7I6p7xAvlDJOUgCNJFLBInv+5cenln+WJrlwQU/Z5ZiwIK1st8DKJSgEE5jkIbHxGNeLv5+RyAaHAZYmKoQNAtzvk/zoWZUufyWWaptsl/J/Toaxe8VbcNZVQ1UXSlvUUPIr7dYohDeb2gkJwj7hXS1VMiFdK/mXoVXQbtCjmyaeWOXJNZmtgidMowZQnl/tb+qpsJl8cHOONmFASGvPO+MO5wsq0+JtDKC+id2QQpT2hKQlPYaUrYjRgKuM64CplvH0LZnmwGEfqCYKZRHNZ0Se4CFbMoV6dKipG/IH26h3BYUSFaBsHzaSefWOT6Yv/SO1HjeIMG8/1vA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(316002)(47076005)(2616005)(107886003)(36756003)(83380400001)(26005)(53546011)(54906003)(508600001)(6506007)(186003)(336012)(8676002)(6486002)(36860700001)(8936002)(86362001)(33656002)(356005)(5660300002)(4326008)(6512007)(70206006)(2906002)(6862004)(70586007)(82310400004)(40460700001)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 09:19:51.6241
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cd374c12-9eb9-4574-143c-08d9c13e616c
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7383

SGkgU3RlZmFubywNCg0KPiBPbiAxNiBEZWMgMjAyMSwgYXQgOTo0OCBwbSwgU3RlZmFubyBTdGFi
ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIFRodSwgMTYg
RGVjIDIwMjEsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4gSGkgU3RlZmFubywNCj4+IA0KPj4+IE9u
IDE2IERlYyAyMDIxLCBhdCAyOjMzIGFtLCBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5p
QGtlcm5lbC5vcmc+IHdyb3RlOg0KPj4+IA0KPj4+IE9uIFR1ZSwgMTQgRGVjIDIwMjEsIFJhaHVs
IFNpbmdoIHdyb3RlOg0KPj4+PiBJTyBwb3J0cyBvbiBBUk0gZG9uJ3QgZXhpc3Qgc28gYWxsIElP
IHBvcnRzIHJlbGF0ZWQgaHlwZXJjYWxscyBhcmUgZ29pbmcNCj4+Pj4gdG8gZmFpbCBvbiBBUk0g
d2hlbiB3ZSBwYXNzdGhyb3VnaCBhIFBDSSBkZXZpY2UuDQo+Pj4+IEZhaWx1cmUgb2YgeGNfZG9t
YWluX2lvcG9ydF9wZXJtaXNzaW9uKC4uKSB3b3VsZCB0dXJuIGludG8gYSBjcml0aWNhbA0KPj4+
PiBmYWlsdXJlIGF0IGRvbWFpbiBjcmVhdGlvbi4gV2UgbmVlZCB0byBhdm9pZCB0aGlzIG91dGNv
bWUsIGluc3RlYWQgd2UNCj4+Pj4gd2FudCB0byBjb250aW51ZSB3aXRoIGRvbWFpbiBjcmVhdGlv
biBhcyBub3JtYWwgZXZlbiBpZg0KPj4+PiB4Y19kb21haW5faW9wb3J0X3Blcm1pc3Npb24oLi4p
IGZhaWxzLiBYRU5fRE9NQ1RMX2lvcG9ydF9wZXJtaXNzaW9uDQo+Pj4+IGlzIG5vdCBpbXBsZW1l
bnRlZCBvbiBBUk0gc28gaXQgd291bGQgcmV0dXJuIC1FTk9TWVMuDQo+Pj4+IA0KPj4+PiBUbyBz
b2x2ZSBhYm92ZSBpc3N1ZSByZW1vdmUgUENJIEkvTyByYW5nZXMgcHJvcGVydHkgdmFsdWUgZnJv
bSBkb20wDQo+Pj4+IGRldmljZSB0cmVlIG5vZGUgc28gdGhhdCBkb20wIGxpbnV4IHdpbGwgbm90
IGFsbG9jYXRlIEkvTyBzcGFjZSBmb3IgUENJDQo+Pj4+IGRldmljZXMgaWYgcGNpLXBhc3N0aHJv
dWdoIGlzIGVuYWJsZWQuDQo+Pj4+IA0KPj4+PiBBbm90aGVyIHZhbGlkIHJlYXNvbiB0byByZW1v
dmUgSS9PIHJhbmdlcyBpcyB0aGF0IFBDSSBJL08gc3BhY2UgYXJlIG5vdA0KPj4+PiBtYXBwZWQg
dG8gZG9tMCB3aGVuIFBDSSBwYXNzdGhyb3VnaCBpcyBlbmFibGVkLCBhbHNvIHRoZXJlIGlzIG5v
IHZwY2kNCj4+Pj4gdHJhcCBoYW5kbGVyIHJlZ2lzdGVyIGZvciBJTyBiYXIuDQo+Pj4+IA0KPj4+
PiBTaWduZWQtb2ZmLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hAYXJtLmNvbT4NCj4+Pj4g
LS0tDQo+Pj4+IHhlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyAgIHwgMTQgKysrKysrKw0KPj4+
PiB4ZW4vY29tbW9uL2RldmljZV90cmVlLmMgICAgICB8IDcyICsrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrDQo+Pj4+IHhlbi9pbmNsdWRlL3hlbi9kZXZpY2VfdHJlZS5oIHwgMTAg
KysrKysNCj4+Pj4gMyBmaWxlcyBjaGFuZ2VkLCA5NiBpbnNlcnRpb25zKCspDQo+Pj4+IA0KPj4+
PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJt
L2RvbWFpbl9idWlsZC5jDQo+Pj4+IGluZGV4IGQwMmJhY2JjZDEuLjYwZjZiMmM3M2IgMTAwNjQ0
DQo+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYw0KPj4+PiArKysgYi94ZW4v
YXJjaC9hcm0vZG9tYWluX2J1aWxkLmMNCj4+Pj4gQEAgLTc0OSw2ICs3NDksMTEgQEAgc3RhdGlj
IGludCBfX2luaXQgd3JpdGVfcHJvcGVydGllcyhzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2Vy
bmVsX2luZm8gKmtpbmZvLA0KPj4+PiAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4+Pj4gICAg
ICAgIH0NCj4+Pj4gDQo+Pj4+ICsgICAgICAgIGlmICggaXNfcGNpX3Bhc3N0aHJvdWdoX2VuYWJs
ZWQoKSAmJg0KPj4+PiArICAgICAgICAgICAgICAgIGR0X2RldmljZV90eXBlX2lzX2VxdWFsKG5v
ZGUsICJwY2kiKSApDQo+Pj4+ICsgICAgICAgICAgICBpZiAoIGR0X3Byb3BlcnR5X25hbWVfaXNf
ZXF1YWwocHJvcCwgInJhbmdlcyIpICkNCj4+Pj4gKyAgICAgICAgICAgICAgICBjb250aW51ZTsN
Cj4+PiANCj4+PiBJdCBsb29rcyBsaWtlIHdlIGFyZSBza2lwcGluZyB0aGUgInJhbmdlcyIgcHJv
cGVydHkgZW50aXJlbHkgZm9yIHRoZSBQQ0kNCj4+PiBub2RlLCBpcyB0aGF0IHJpZ2h0PyBXb3Vs
ZG4ndCB0aGF0IGFsc28gcmVtb3ZlIHRoZSBvdGhlciAobm90IGlvcG9ydHMpDQo+Pj4gYWRkcmVz
cyByYW5nZXM/DQo+PiANCj4+IFdlIGFyZSBza2lwcGluZyB0aGUg4oCccmFuZ2Vz4oCdIHByb3Bl
cnR5IGhlcmUgdG8gYXZvaWQgc2V0dGluZyB0aGUg4oCccmFuZ2Vz4oCdIHByb3BlcnR5IHdoZW4N
Cj4+IHBjaV9wYXNzdGhyb3VnaCBpcyBlbmFibGVkLiBXZSB3aWxsIHJlbW92ZSBvbmx5IHJlbW92
ZSBJTyBwb3J0IGFuZCBzZXQgdGhlIG90aGVyIOKAmHJhbmdlc+KAnSBwcm9wZXJ0eSANCj4+IHZh
bHVlIGluIGR0X3BjaV9yZW1vdmVfaW9fcmFuZ2VzKCkgaW4gbmV4dCBpZigpIGNvbmRpdGlvbi4N
Cj4+IA0KPj4gDQo+Pj4+ICAgICAgICByZXMgPSBmZHRfcHJvcGVydHkoa2luZm8tPmZkdCwgcHJv
cC0+bmFtZSwgcHJvcF9kYXRhLCBwcm9wX2xlbik7DQo+Pj4+IA0KPj4+PiAgICAgICAgaWYgKCBy
ZXMgKQ0KPj4+PiBAQCAtNzY5LDYgKzc3NCwxNSBAQCBzdGF0aWMgaW50IF9faW5pdCB3cml0ZV9w
cm9wZXJ0aWVzKHN0cnVjdCBkb21haW4gKmQsIHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sDQo+
Pj4+ICAgICAgICAgICAgaWYgKCByZXMgKQ0KPj4+PiAgICAgICAgICAgICAgICByZXR1cm4gcmVz
Ow0KPj4+PiAgICAgICAgfQ0KPj4+PiArDQo+Pj4+ICsgICAgICAgIC8qDQo+Pj4+ICsgICAgICAg
ICAqIFBDSSBJTyBiYXIgYXJlIG5vdCBtYXBwZWQgdG8gZG9tMCB3aGVuIFBDSSBwYXNzdGhyb3Vn
aCBpcyBlbmFibGVkLA0KPj4+PiArICAgICAgICAgKiBhbHNvIHRoZXJlIGlzIG5vIHRyYXAgaGFu
ZGxlciByZWdpc3RlcmVkIGZvciBJTyBiYXIgdGhlcmVmb3IgcmVtb3ZlDQo+Pj4+ICsgICAgICAg
ICAqIHRoZSBJTyByYW5nZSBwcm9wZXJ0eSBmcm9tIHRoZSBkZXZpY2UgdHJlZSBub2RlIGZvciBk
b20wLg0KPj4+PiArICAgICAgICAgKi8NCj4+Pj4gKyAgICAgICAgcmVzID0gZHRfcGNpX3JlbW92
ZV9pb19yYW5nZXMoa2luZm8tPmZkdCwgbm9kZSk7DQo+Pj4+ICsgICAgICAgIGlmICggcmVzICkN
Cj4+Pj4gKyAgICAgICAgICAgIHJldHVybiByZXM7DQo+Pj4gDQo+Pj4gSSB0cmllZCB0byBhcHBs
eSB0aGlzIHBhdGNoIHRvIHN0YWdpbmcgdG8gbWFrZSBpdCBlYXNpZXIgdG8gcmV2aWV3IGJ1dCBJ
DQo+Pj4gdGhpbmsgdGhpcyBjaHVjayBnb3QgYXBwbGllZCB3cm9uZ2x5OiBJIGNhbiBzZWUNCj4+
PiBkdF9wY2lfcmVtb3ZlX2lvX3JhbmdlcygpIGFkZGVkIHRvIHRoZSBmdW5jdGlvbiAiaGFuZGxl
X3Byb3BfcGZkdCIgd2hpY2gNCj4+PiBpcyBmb3IgZ3Vlc3QgcGFydGlhbCBEVEJzIGFuZCBub3Qg
Zm9yIGRvbTAuDQo+PiANCj4+IE9sZWtzYW5kcuKAmXMgcGF0Y2ggc2VyaWVzIHdhcyBtZXJnZWQg
eWVzdGVyZGF5IGJlY2F1c2Ugb2YgdGhhdCB0aGVyZSBpcyBjb25mbGljdCBpbiBhcHBseWluZyAN
Cj4+IHRoaXMgcGF0Y2guIEkgd2lsbCByZWJhc2UgdGhlIHBhdGNoIGFuZCB3aWxsIHNlbmQgaXQg
YWdhaW4gZm9yIHJldmlldy4NCj4+IA0KPj4+IA0KPj4+IElzIGR0X3BjaV9yZW1vdmVfaW9fcmFu
Z2VzKCkgbWVhbnQgdG8gYmUgY2FsbGVkIGZyb20gd3JpdGVfcHJvcGVydGllcw0KPj4+IGluc3Rl
YWQ/IEl0IGxvb2tzIGxpa2UgaXQgd291bGQgYmUgYmVzdCB0byBjYWxsIGl0IGZyb20NCj4+PiB3
cml0ZV9wcm9wZXJ0aWVzLCBtYXliZSBpdCBjb3VsZCBiZSBjb21iaW5lZCB3aXRoIHRoZSBvdGhl
ciBuZXcgY2hlY2sNCj4+PiBqdXN0IGFib3ZlIGluIHRoaXMgcGF0Y2g/DQo+PiANCj4+IFllcyBk
dF9wY2lfcmVtb3ZlX2lvX3JhbmdlcygpIGlzIHRvIGJlIGNhbGxlZCBmcm9tIHdyaXRlX3Byb3Bl
cnRpZXMoKS4NCj4gDQo+IE9LLiBJbiB0aGF0IGNhc2UgdGhlIG9ubHkgZmVlZGJhY2sgdGhhdCBp
cyBJIGhhdmUgaXMgdGhhdCBpdCBtaWdodCBiZQ0KPiBwb3NzaWJsZSB0byBhdm9pZCB0aGUgZmly
c3QgY2hhbmdlIG9mIHRoaXMgcGF0Y2ggdG8gc2tpcCAicmFuZ2VzIiBieQ0KPiBtb3ZpbmcgdGhl
IGNhbGwgdG8gZHRfcGNpX3JlbW92ZV9pb19yYW5nZXMoKSBlYXJsaWVyIGluIHRoZQ0KPiB3cml0
ZV9wcm9wZXJ0aWVzIGZ1bmN0aW9uLg0KDQpPay4gSSB3aWxsIG1vZGlmeSB0aGUgY29kZSBiYXNl
ZCBvbiB5b3VyIGNvbW1lbnQuDQoNClJlZ2FyZHMsDQpSYWh1bA0KDQo=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 09:40:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 09:40:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248492.428618 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my9iW-0004Gl-D8; Fri, 17 Dec 2021 09:39:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248492.428618; Fri, 17 Dec 2021 09:39:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1my9iW-0004Ge-98; Fri, 17 Dec 2021 09:39:56 +0000
Received: by outflank-mailman (input) for mailman id 248492;
 Fri, 17 Dec 2021 09:39:55 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1my9iV-0004GY-2P
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 09:39:55 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4919bcb0-5f1d-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 10:39:53 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44750)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1my9iS-000XUT-1J (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 09:39:52 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 275B71FA77;
 Fri, 17 Dec 2021 09:39:52 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4919bcb0-5f1d-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <59705f15-3f9b-cd28-ad60-1f033933840f@srcf.net>
Date: Fri, 17 Dec 2021 09:39:51 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
References: <20211217075059.14466-1-jgross@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH] tools/xenstore: drop support for running under SunOS
In-Reply-To: <20211217075059.14466-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 17/12/2021 07:50, Juergen Gross wrote:
> Since several years now xenstored is no longer capable to run under
> SunOS, as the needed libxengnttab interfaces are not available there.
>
> Several attempts to let the SunOS maintainers address this situation
> didn't change anything in this regard.
>
> For those reasons drop SunOS support in xenstored by removing the SunOS
> specific code.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

FWIW, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

> -out:
> -	/*
> -	 * 6589130 dtrace -G fails for certain tail-calls on x86
> -	 */
> -	asm("nop");
> -}

Code like this makes me extra sad... It only works for the same reasons
as why asm ("") would be fine as well.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:01:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:01:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248500.428629 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myA3K-0007oJ-8D; Fri, 17 Dec 2021 10:01:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248500.428629; Fri, 17 Dec 2021 10:01:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myA3K-0007oC-3H; Fri, 17 Dec 2021 10:01:26 +0000
Received: by outflank-mailman (input) for mailman id 248500;
 Fri, 17 Dec 2021 10:01:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myA3I-0007o5-S8
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:01:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myA3I-0008Vf-ID; Fri, 17 Dec 2021 10:01:24 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myA3I-0005qu-C4; Fri, 17 Dec 2021 10:01:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=z8V44etTx8ljcpiMN+pKJ0etQtpFz4XxrA/r7bY2gog=; b=jX5jV6NCYZISbWfxImc5odnEuV
	cF2wM6LRH9UcOoGUoF6D5AHUULfp3BbT9y0/7K/PATkb5IhDxzpt+jsWncRN/HgLnsTZsB700hmNm
	S4Z9R99wPbU6hZVGVPalaR3HphSPBcBNRFmwp54nFsbJSOJO64rawnrhm8qUa/HB10o0=;
Message-ID: <48666542-6647-d1ec-78df-2fbb43efcc0d@xen.org>
Date: Fri, 17 Dec 2021 10:01:22 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211217072159.3464-1-michal.orzel@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211217072159.3464-1-michal.orzel@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 17/12/2021 07:21, Michal Orzel wrote:
> to hypervisor when switching from AArch32 state.
> 
> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
> "If the general-purpose register was accessible from AArch32 state the
> upper 32 bits either become zero, or hold the value that the same
> architectural register held before any AArch32 execution.
> The choice between these two options is IMPLEMENTATION DEFINED"
> 
> Currently Xen does not ensure that the top 32 bits are zeroed and this
> needs to be fixed. The reason why is that there are places in Xen
> where we assume that top 32bits are zero for AArch32 guests.
> If they are not, this can lead to misinterpretation of Xen regarding
> what the guest requested. For example hypercalls returning an error
> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
> would return -ENOSYS if the command passed as the first argument was
> clobbered.
> 
> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
> Add a compile time check to ensure that save_x0_x1 == 1 if
> compat == 1.
> 
> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
> ---
> Changes since v2:
> -add clobbering of w30
> Changes since v1:
> -put new code into macro
> -add compile time check for save_x0_x1
> ---
>   xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
> index fc3811ad0a..e351ef8639 100644
> --- a/xen/arch/arm/arm64/entry.S
> +++ b/xen/arch/arm/arm64/entry.S
> @@ -102,6 +102,30 @@
>           .endif
>   
>           .endm
> +
> +/*
> + * Clobber top 32 bits of gp registers when switching from AArch32
> + */
> +        .macro clobber_gp_top_halves, compat, save_x0_x1
> +
> +        .if \compat == 1      /* AArch32 mode */
> +
> +        /*
> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
> +         * Add a compile time check to avoid violating this rule.
> +         */

We may want in the future to allow save_x0_x1 == 1 with compat == 1 if 
we need to create fastpath like we did when entering AArch64.

So I would reword the comment to make clear this is an implementation 
decision. How about:

"At the moment, no-one is using save_x0_x1 == 0 with compat == 1. So the 
code is not handling it to simplify the implementation."

If you are happy with the new comment, I can update it on commit:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:04:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:04:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248505.428640 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myA6P-0008RU-IZ; Fri, 17 Dec 2021 10:04:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248505.428640; Fri, 17 Dec 2021 10:04:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myA6P-0008RN-FZ; Fri, 17 Dec 2021 10:04:37 +0000
Received: by outflank-mailman (input) for mailman id 248505;
 Fri, 17 Dec 2021 10:04:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myA6O-0008RH-2F
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:04:36 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myA6N-00008A-IH; Fri, 17 Dec 2021 10:04:35 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myA6N-000653-BV; Fri, 17 Dec 2021 10:04:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ltUrKqxg7Rrs5B08vwtBxjk5+qE/OzTO6BfBtdfTBxA=; b=hO0jFN3uMUtBIG3NxqwEcDajxY
	b/DmDzsYEikvHoFQtchGJzRy/fG5kACbuYU2gMEBM7DkNmV8j/o3hLYuGecHCU6CsHia8DtQ2uqfO
	SCAFDYL3FXo976CGzspgfIL4WtjmREIZEt7V51WhclV8UXm70j0CDwM6ZexM5tBAKpy4=;
Message-ID: <4345eaf9-d7fd-7ec8-fc98-33fa8a6b07b5@xen.org>
Date: Fri, 17 Dec 2021 10:04:33 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 15/12/2021 07:03, Juergen Gross wrote:
> On 14.12.21 18:36, Julien Grall wrote:
>> Hi,
>>
>> On 08/12/2021 15:55, Juergen Gross wrote:
>>> Today most hypercall handlers have a return type of long, while the
>>> compat ones return an int. There are a few exceptions from that rule,
>>> however.
>>
>> So on Arm64, I don't think you can make use of the full 64-bit because 
>> a 32-bit domain would not be able to see the top 32-bit.
>>
>> In fact, this could potentially cause us some trouble (see [1]) in Xen.
>> So it feels like the hypercalls should always return a 32-bit signed 
>> value on Arm.
> 
> This would break hypercalls like XENMEM_maximum_ram_page which are able
> to return larger values, right?
> 
>> The other advantage is it would be clear that the top 32-bit are not 
>> usuable. Stefano, what do you think?
> 
> Wouldn't it make more sense to check the return value to be a sign
> extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
> 
> The question is what to return if this is not the case. -EDOM?

It looks like there was a lot of discussion afterwards. I will read 
everything and answer on the last part of the thread :).

> 
>>
>>>
>>> Get rid of the exceptions by letting compat handlers always return int
>>> and others always return long.
>>>
>>> For the compat hvm case use eax instead of rax for the stored result as
>>> it should have been from the beginning.
>>>
>>> Additionally move some prototypes to include/asm-x86/hypercall.h
>>> as they are x86 specific. Move the do_physdev_op() prototype from both
>>> architecture dependant headers to the common one. Move the
>>> compat_platform_op() prototype to the common header.
>>>
>>> Switch some non style compliant types (u32, s32, s64) to style compliant
>>> ones.
>>
>> TBH, I think this should have been split because the modifications are 
>> done on lines that are untouched.
>>
>> The extra patch would have made the review easier (even if this patch 
>> is still quite small).
> 
> I can split the patch if you want.

I have already reviewed this patch. So it is not going to help me :). 
However, I would appreciate if in the future the coding style changes 
are separated at least when they are not meant to be untouched.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:38:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248518.428651 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAdM-0003sL-FY; Fri, 17 Dec 2021 10:38:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248518.428651; Fri, 17 Dec 2021 10:38:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAdM-0003sE-Bs; Fri, 17 Dec 2021 10:38:40 +0000
Received: by outflank-mailman (input) for mailman id 248518;
 Fri, 17 Dec 2021 10:38:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myAdK-0003s8-ST
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:38:38 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAdJ-0000jB-9J; Fri, 17 Dec 2021 10:38:37 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAdJ-0008Ho-2h; Fri, 17 Dec 2021 10:38:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=7K6eAiiDcErzq2mOiW8bjA1OTuybw/egfbb/jVma7cU=; b=s249YIwMwRCfJT73sB95S1m45k
	5y2tHTsHQZNRL1CRpJPnXUGe8deMF9SGF1EsESpOopD8ojXErNSjEqJOj51QmFtv+GfMeif2rvM+M
	FTJ6nGTp+pyOxlNFRQ1G63Iy3EoBq+wAl2zJMcAKblzU/MzS1+MwMztiRizIMcUZf2bE=;
Message-ID: <7cabbc0b-f6bd-04a1-9552-8cecf7639b15@xen.org>
Date: Fri, 17 Dec 2021 10:38:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stefano,

On 16/12/2021 21:15, Stefano Stabellini wrote:
> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>> On Wed, 15 Dec 2021, Juergen Gross wrote:
>>>>> On 14.12.21 18:36, Julien Grall wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 08/12/2021 15:55, Juergen Gross wrote:
>>>>>>> Today most hypercall handlers have a return type of long, while the
>>>>>>> compat ones return an int. There are a few exceptions from that rule,
>>>>>>> however.
>>>>>>
>>>>>> So on Arm64, I don't think you can make use of the full 64-bit because a
>>>>>> 32-bit domain would not be able to see the top 32-bit.
>>>>>>
>>>>>> In fact, this could potentially cause us some trouble (see [1]) in Xen.
>>>>>> So it feels like the hypercalls should always return a 32-bit signed
>>>>>> value
>>>>>> on Arm.
>>>>>
>>>>> This would break hypercalls like XENMEM_maximum_ram_page which are able
>>>>> to return larger values, right?
>>>>>
>>>>>> The other advantage is it would be clear that the top 32-bit are not
>>>>>> usuable. Stefano, what do you think?
>>>>>
>>>>> Wouldn't it make more sense to check the return value to be a sign
>>>>> extended 32-bit value for 32-bit guests in do_trap_hypercall() instead?
>>>>>
>>>>> The question is what to return if this is not the case. -EDOM?
>>>>
>>>>
>>>> I can see where Julien is coming from: we have been trying to keep the
>>>> arm32 and arm64 ABIs identical since the beginning of the project. So,
>>>> like Julien, my preference would be to always return 32-bit on ARM, both
>>>> aarch32 and aarch64. It would make things simple.
>>>>
>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a
>>>> problem in reality because the max physical address size is only 40-bit
>>>> for aarch32 guests, so 32-bit are always enough to return the highest
>>>> page in memory for 32-bit guests.
>>>
>>> You are aware that this isn't the guest's max page, but the host's?
> 
> I can see now that you meant to say that, no matter what is the max
> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
> supposed to return the max memory page, which could go above the
> addressibility limit of the VM.
> 
> So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
> even when called by an aarch32 VM, with max IPA 40-bit.

I am a bit confused with what you wrote. Yes, 32-bit VM can only address 
40-bit, but this is only limiting its own (guest) physical address 
space. Such VM would still be able to map any host physical address 
(assuming GFN != MFN).

> 
> I would imagine it could be useful if dom0 is 32-bit but domUs are
> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
> configuration on ARM.)

Looking at the implementation, the hypercall is accessible by any 
domain. IOW a domU 32-bit could read a wrong value.

That said, it is not clear to me why an Arm or HVM x86 guest would want 
to read the value.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:41:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:41:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248525.428661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAgF-0005PS-Tt; Fri, 17 Dec 2021 10:41:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248525.428661; Fri, 17 Dec 2021 10:41:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAgF-0005PL-Qv; Fri, 17 Dec 2021 10:41:39 +0000
Received: by outflank-mailman (input) for mailman id 248525;
 Fri, 17 Dec 2021 10:41:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myAgD-0005P9-TQ
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:41:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAgC-0000lq-NE; Fri, 17 Dec 2021 10:41:36 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAgC-0008Rz-GL; Fri, 17 Dec 2021 10:41:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=+DSlKcqz5UghBfJ4MjSqzMZh0tJ+riPkrTWTHi1auhY=; b=VH++78QQWGyo46Ek7qeg5AGLSb
	u3IDFhjtsF8IAoO8Uw95xHLajUOyomYWEsSqgTMLIZHYybPGfPWJJhqAkQ9/729f/+3wMtnEo8TFf
	FdCPsuZR6dQtH6pRw5oCcF9fRehMnAda841NjMROdeEJvGjX6JEQ7TlDhFeTx6d0c4Pw=;
Message-ID: <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
Date: Fri, 17 Dec 2021 10:41:34 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Juergen,

On 17/12/2021 08:50, Juergen Gross wrote:
> On 17.12.21 08:45, Jan Beulich wrote:
>> On 17.12.2021 06:34, Juergen Gross wrote:
>>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is not a
>>>>>>> problem in reality because the max physical address size is only 
>>>>>>> 40-bit
>>>>>>> for aarch32 guests, so 32-bit are always enough to return the 
>>>>>>> highest
>>>>>>> page in memory for 32-bit guests.
>>>>>>
>>>>>> You are aware that this isn't the guest's max page, but the host's?
>>>>
>>>> I can see now that you meant to say that, no matter what is the max
>>>> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
>>>> supposed to return the max memory page, which could go above the
>>>> addressibility limit of the VM.
>>>>
>>>> So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
>>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>>
>>>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>>>> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
>>>> configuration on ARM.)
>>>>
>>>> Then it looks like XENMEM_maximum_ram_page needs to be able to return a
>>>> value > 32-bit when called by a 32-bit guest.
>>>>
>>>> The hypercall ABI follows the ARM C calling convention, so a 64-bit
>>>> value should be returned using r0 and r1. But looking at
>>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets r1
>>>> today. Only r0 is set, so effectively we only support 32-bit return
>>>> values on aarch32 and for aarch32 guests.
>>>>
>>>> In other words, today all hypercalls on ARM return 64-bit to 64-bit
>>>> guests and 32-bit to 32-bit guests. Which in the case of memory_op is
>>>> "technically" the correct thing to do because it matches the C
>>>> declaration in xen/include/xen/hypercall.h:
>>>>
>>>> extern long
>>>> do_memory_op(
>>>>       unsigned long cmd,
>>>>       XEN_GUEST_HANDLE_PARAM(void) arg);
>>>>
>>>> So...  I guess the conclusion is that on ARM do_memory_op should return
>>>> "long" although it is not actually enough for a correct implementation
>>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>>
>>>
>>> Hence my suggestion to check the return value of _all_ hypercalls to be
>>> proper sign extended int values for 32-bit guests. This would fix all
>>> potential issues without silently returning truncated values.
>>
>> Are we absolutely certain we have no other paths left where a possibly
>> large unsigned values might be returned? In fact while
>> compat_memory_op() does the necessary saturation, I've never been fully
>> convinced of this being the best way of dealing with things. The range
>> of error indicators is much smaller than [-INT_MIN,-1], so almost
>> double the range of effectively unsigned values could be passed back
>> fine. (Obviously we can't change existing interfaces, so this mem-op
>> will need to remain as is.)
> 
> In fact libxenctrl tries do deal with this fact by wrapping a memory_op
> for a 32-bit environment into a multicall. This will work fine for a
> 32-bit Arm guest, as xen_ulong_t is a uint64 there.
> 
> So do_memory_op should return long on Arm, yes. OTOH doing so will
> continue to be a problem in case a 32-bit guest doesn't use the
> multicall technique for handling possible 64-bit return values.
> 
> So I continue to argue that on Arm the return value of a hypercall
> should be tested to fit into 32 bits. 

It would make sense. But what would you return if the value doesn't fit?

> The only really clean alternative
> would be to have separate hypercall function classes for Arm 32- and
> 64-bit guests (which still could share most of the functions by letting
> those return "int"). This would allow to use the 64-bit variant even for
> 32-bit guests in multicall (fine as the return field is 64-bit wide),
> and a probably saturating compat version for the 32-bit guest direct
> hypercall.

I am not entirely sure to understand this proposal. Can you clarify it?

> 
> The needed adaptions in my series would be rather limited (an additional
> column in the hypercall table, a split which macro to use in
> do_trap_hypercall() on Arm depending on the bitness of the guest, the
> addition of the Arm compat variant of do_memory_op()).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:45:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:45:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248530.428673 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAkE-00063k-DJ; Fri, 17 Dec 2021 10:45:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248530.428673; Fri, 17 Dec 2021 10:45:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAkE-00063d-A0; Fri, 17 Dec 2021 10:45:46 +0000
Received: by outflank-mailman (input) for mailman id 248530;
 Fri, 17 Dec 2021 10:45:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myAkC-00063X-Lx
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:45:44 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAkB-0000qj-SH; Fri, 17 Dec 2021 10:45:43 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myAkB-0000Qa-ME; Fri, 17 Dec 2021 10:45:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZImgGO/brywYhb+ZeCGEPyjUyTuRi+12VbxmFZXUN9A=; b=loc0p02E0QjiX0dk44JFSW83ya
	wL/+Ydk0sdrep0AwETMVv+TfT5amyaTMp1bC1eF3fpnUzwqD7W6WwR61wqqp4Yg/KYLFA6WYtbko/
	eGUV1L+FG4MZ5/VvD+IPwacMKkqx50uROMYE+F9yYVqyjNQhcZRH7bl6TgCo9Z8Jho9k=;
Message-ID: <a7523051-267c-1ac5-e160-25f4d903420a@xen.org>
Date: Fri, 17 Dec 2021 10:45:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] tools/xenstore: drop support for running under SunOS
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>
References: <20211217075059.14466-1-jgross@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211217075059.14466-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Juergen,

On 17/12/2021 07:50, Juergen Gross wrote:
> Since several years now xenstored is no longer capable to run under
> SunOS, as the needed libxengnttab interfaces are not available there.
> 
> Several attempts to let the SunOS maintainers address this situation
> didn't change anything in this regard.
> 
> For those reasons drop SunOS support in xenstored by removing the SunOS
> specific code.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
>   tools/xenstore/Makefile            |  15 +--
>   tools/xenstore/xenstored_core.c    |   7 --
>   tools/xenstore/xenstored_core.h    |   4 -
>   tools/xenstore/xenstored_minios.c  |   4 -
>   tools/xenstore/xenstored_posix.c   |   6 --
>   tools/xenstore/xenstored_probes.d  |  28 -----
>   tools/xenstore/xenstored_solaris.c | 168 -----------------------------
>   7 files changed, 1 insertion(+), 231 deletions(-)
>   delete mode 100644 tools/xenstore/xenstored_probes.d
>   delete mode 100644 tools/xenstore/xenstored_solaris.c
> 
> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> index 292b478fa1..c86278fdb1 100644
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -27,7 +27,6 @@ XENSTORED_OBJS += xenstored_transaction.o xenstored_control.o
>   XENSTORED_OBJS += xs_lib.o talloc.o utils.o tdb.o hashtable.o
>   
>   XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_posix.o
> -XENSTORED_OBJS_$(CONFIG_SunOS) = xenstored_solaris.o xenstored_posix.o xenstored_probes.o
>   XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_posix.o
>   XENSTORED_OBJS_$(CONFIG_FreeBSD) = xenstored_posix.o
>   XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o
> @@ -50,18 +49,6 @@ all: $(ALL_TARGETS)
>   .PHONY: clients
>   clients: xenstore $(CLIENTS) xenstore-control
>   
> -ifeq ($(CONFIG_SunOS),y)
> -xenstored_probes.h: xenstored_probes.d
> -	dtrace -C -h -s xenstored_probes.d
> -
> -xenstored_solaris.o: xenstored_probes.h
> -
> -xenstored_probes.o: xenstored_solaris.o
> -	dtrace -C -G -s xenstored_probes.d xenstored_solaris.o
> -
> -CFLAGS += -DHAVE_DTRACE=1
> -endif
> -
>   ifeq ($(CONFIG_SYSTEMD),y)
>   $(XENSTORED_OBJS): CFLAGS += $(SYSTEMD_CFLAGS)
>   xenstored: LDFLAGS += $(SYSTEMD_LIBS)
> @@ -89,7 +76,7 @@ xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
>   
>   .PHONY: clean
>   clean:
> -	rm -f *.a *.o xenstored_probes.h
> +	rm -f *.a *.o
>   	rm -f xenstored
>   	rm -f xs_tdb_dump xenstore-control init-xenstore-domain
>   	rm -f xenstore $(CLIENTS)
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
> index 91d093a12e..c386ae6129 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -146,10 +146,6 @@ static void trace_io(const struct connection *conn,
>   	time_t now;
>   	struct tm *tm;
>   
> -#ifdef HAVE_DTRACE
> -	dtrace_io(conn, data, out);
> -#endif
> -
>   	if (tracefd < 0)
>   		return;
>   
> @@ -2337,9 +2333,6 @@ int main(int argc, char *argv[])
>   	/* Get ready to listen to the tools. */
>   	initialize_fds(&sock_pollfd_idx, &timeout);
>   
> -	/* Tell the kernel we're up and running. */
> -	xenbus_notify_running();
> -
>   #if defined(XEN_SYSTEMD_ENABLED)
>   	if (!live_update) {
>   		sd_notify(1, "READY=1");
> diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
> index 07d861d924..190d2447cd 100644
> --- a/tools/xenstore/xenstored_core.h
> +++ b/tools/xenstore/xenstored_core.h
> @@ -225,7 +225,6 @@ int delay_request(struct connection *conn, struct buffered_data *in,
>   void trace_create(const void *data, const char *type);
>   void trace_destroy(const void *data, const char *type);
>   void trace(const char *fmt, ...) __attribute__ ((format (printf, 1, 2)));
> -void dtrace_io(const struct connection *conn, const struct buffered_data *data, int out);
>   void reopen_log(void);
>   void close_log(void);
>   
> @@ -250,9 +249,6 @@ static inline int xenbus_master_domid(void) { return dom0_domid; }
>   /* Return the event channel used by xenbus. */
>   evtchn_port_t xenbus_evtchn(void);
>   
> -/* Tell the kernel xenstored is running. */
> -void xenbus_notify_running(void);
> -
>   /* Write out the pidfile */
>   void write_pidfile(const char *pidfile);
>   
> diff --git a/tools/xenstore/xenstored_minios.c b/tools/xenstore/xenstored_minios.c
> index c94493e52a..aa384e50c8 100644
> --- a/tools/xenstore/xenstored_minios.c
> +++ b/tools/xenstore/xenstored_minios.c
> @@ -38,10 +38,6 @@ void init_pipe(int reopen_log_pipe[2])
>   	reopen_log_pipe[1] = -1;
>   }
>   
> -void xenbus_notify_running(void)
> -{
> -}
> -
>   evtchn_port_t xenbus_evtchn(void)
>   {
>   	return dom0_event;
> diff --git a/tools/xenstore/xenstored_posix.c b/tools/xenstore/xenstored_posix.c
> index 48c37ffe3e..b20504d1b6 100644
> --- a/tools/xenstore/xenstored_posix.c
> +++ b/tools/xenstore/xenstored_posix.c
> @@ -111,7 +111,6 @@ void unmap_xenbus(void *interface)
>   	munmap(interface, getpagesize());
>   }
>   
> -#ifndef __sun__
>   evtchn_port_t xenbus_evtchn(void)
>   {
>   	int fd;
> @@ -158,8 +157,3 @@ void *xenbus_map(void)
>   
>   	return addr;
>   }
> -
> -void xenbus_notify_running(void)
> -{
> -}
> -#endif /* !__sun__ */
> diff --git a/tools/xenstore/xenstored_probes.d b/tools/xenstore/xenstored_probes.d
> deleted file mode 100644
> index f72d38f935..0000000000
> --- a/tools/xenstore/xenstored_probes.d
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -/*
> - * Copyright 2007 Sun Microsystems, Inc.  All rights reserved.
> - * Use is subject to license terms.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation, version 2 of the License.
> - */
> -
> -#include <sys/types.h>
> -
> -provider xenstore {
> -	/* tx id, dom id, pid, type, msg */
> -	probe msg(uint32_t, unsigned int, pid_t, int, const char *);
> -	/* tx id, dom id, pid, type, reply */
> -	probe reply(uint32_t, unsigned int, pid_t, int, const char *);
> -	/* tx id, dom id, pid, reply */
> -	probe error(uint32_t, unsigned int, pid_t, const char *);
> -	/* dom id, pid, watch details */
> -	probe watch_event(unsigned int, pid_t, const char *);
> -};
> -
> -#pragma D attributes Evolving/Evolving/Common provider xenstore provider
> -#pragma D attributes Private/Private/Unknown provider xenstore module
> -#pragma D attributes Private/Private/Unknown provider xenstore function
> -#pragma D attributes Evolving/Evolving/Common provider xenstore name
> -#pragma D attributes Evolving/Evolving/Common provider xenstore args
> -
> diff --git a/tools/xenstore/xenstored_solaris.c b/tools/xenstore/xenstored_solaris.c
> deleted file mode 100644
> index 06052d124a..0000000000
> --- a/tools/xenstore/xenstored_solaris.c
> +++ /dev/null
> @@ -1,168 +0,0 @@
> -/******************************************************************************
> - *
> - * Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
> - * Use is subject to license terms.
> - *
> - * Copyright (C) 2005 Rusty Russell IBM Corporation
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation, version 2 of the
> - * License.
> - */
> -
> -#include <fcntl.h>
> -#include <unistd.h>
> -#include <stdlib.h>
> -#include <stdarg.h>
> -#include <sys/mman.h>
> -#include <strings.h>
> -#include <ucred.h>
> -#include <stdio.h>
> -
> -#include <xen/sys/xenbus.h>
> -
> -#include "talloc.h"
> -#include "xenstored_core.h"
> -#include "xenstored_probes.h"
> -
> -evtchn_port_t xenbus_evtchn(void)
> -{
> -	int fd;
> -	evtchn_port_t port;
> -
> -	fd = open("/dev/xen/xenbus", O_RDONLY);
> -	if (fd == -1)
> -		return -1;
> -
> -	port = ioctl(fd, IOCTL_XENBUS_XENSTORE_EVTCHN);
> -
> -	close(fd);
> -	return port;
> -}
> -
> -void *xenbus_map(void)
> -{
> -	int fd;
> -	void *addr;
> -
> -	fd = open("/dev/xen/xenbus", O_RDWR);
> -	if (fd == -1)
> -		return NULL;
> -
> -	addr = mmap(NULL, getpagesize(), PROT_READ|PROT_WRITE,
> -		MAP_SHARED, fd, 0);
> -
> -	if (addr == MAP_FAILED)
> -		addr = NULL;
> -
> -	close(fd);
> -
> -	return addr;
> -}
> -
> -void xenbus_notify_running(void)
> -{
> -	int fd;
> -
> -	fd = open("/dev/xen/xenbus", O_RDONLY);
> -
> -	(void) ioctl(fd, IOCTL_XENBUS_NOTIFY_UP);
> -
> -	close(fd);
> -}
> -
> -static pid_t cred(const struct connection *conn)
> -{
> -	ucred_t *ucred = NULL;
> -	pid_t pid;
> -
> -	if (conn->domain)
> -		return (0);
> -
> -	if (getpeerucred(conn->fd, &ucred) == -1)
> -		return (0);
> -
> -	pid = ucred_getpid(ucred);
> -
> -	ucred_free(ucred);
> -	return (pid);
> -}
> -
> -/*
> - * The strings are often a number of nil-separated strings. We'll just
> - * replace the separators with spaces - not quite right, but good
> - * enough.
> - */
> -static char *
> -mangle(const struct connection *conn, const struct buffered_data *in)
> -{
> -	char *str;
> -	int i;
> -
> -	if (in->hdr.msg.len == 0)
> -		return (talloc_strdup(conn, ""));
> -
> -	if ((str = talloc_zero_size(conn, in->hdr.msg.len + 1)) == NULL)
> -		return (NULL);
> -
> -	memcpy(str, in->buffer, in->hdr.msg.len);
> -	
> -	/*
> -	 * The protocol is absurdly inconsistent in whether the length
> -	 * includes the terminating nil or not; replace all nils that
> -	 * aren't the last one.
> -	 */
> -	for (i = 0; i < (in->hdr.msg.len - 1); i++) {
> -		if (str[i] == '\0')
> -			str[i] = ' ';
> -	}
> -
> -	return (str);
> -}
> -
> -void
> -dtrace_io(const struct connection *conn, const struct buffered_data *in,
> -    int io_out)
> -{
> -	if (!io_out) {
> -		if (XENSTORE_MSG_ENABLED()) {
> -			char *mangled = mangle(conn, in);
> -			XENSTORE_MSG(in->hdr.msg.tx_id, conn->id, cred(conn),
> -			    in->hdr.msg.type, mangled);
> -		}
> -
> -		goto out;
> -	}
> -
> -	switch (in->hdr.msg.type) {
> -	case XS_ERROR:
> -		if (XENSTORE_ERROR_ENABLED()) {
> -			char *mangled = mangle(conn, in);
> -			XENSTORE_ERROR(in->hdr.msg.tx_id, conn->id,
> -			    cred(conn), mangled);
> -		}
> -		break;
> -
> -	case XS_WATCH_EVENT:
> -		if (XENSTORE_WATCH_EVENT_ENABLED()) {
> -			char *mangled = mangle(conn, in);
> -			XENSTORE_WATCH_EVENT(conn->id, cred(conn), mangled);
> -		}
> -		break;
> -
> -	default:
> -		if (XENSTORE_REPLY_ENABLED()) {
> -			char *mangled = mangle(conn, in);
> -			XENSTORE_REPLY(in->hdr.msg.tx_id, conn->id, cred(conn),
> -			    in->hdr.msg.type, mangled);
> -		}
> -		break;
> -	}
> -
> -out:
> -	/*
> -	 * 6589130 dtrace -G fails for certain tail-calls on x86
> -	 */
> -	asm("nop");
> -}

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:49:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:49:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248535.428684 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAnR-0006mE-SV; Fri, 17 Dec 2021 10:49:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248535.428684; Fri, 17 Dec 2021 10:49:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAnR-0006m7-Oc; Fri, 17 Dec 2021 10:49:05 +0000
Received: by outflank-mailman (input) for mailman id 248535;
 Fri, 17 Dec 2021 10:49:05 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myAnQ-0006m1-UY
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:49:05 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f2606591-5f26-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 11:49:03 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BH9m0D7032012;
 Fri, 17 Dec 2021 10:48:59 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d0as79xv1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 10:48:59 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7054.eurprd03.prod.outlook.com (2603:10a6:102:e9::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Fri, 17 Dec
 2021 10:48:51 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 10:48:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f2606591-5f26-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Pl+lIYrjntDrXMCkXShiqa1Ok4jnp4pvtCycccPPK2e9noGyI2Ijb2EkVH7AIjj5qdh52GjISoQYOxvOnbYnXI7AygVdKdzHAXW6Q3NIb8fmC9xkLE9B2W9pzwNAr3PoPTXFJ1j5ZX/hF4IxKS00fBodCjSBDURLRKm5jtnb3eaqgM9OesvwFTMk6lX279pUc75Qc4SQ9MoK3ugm88mycnpTq3S9ng+nQuNRdDLRhw0obVKNXdmBYBD4gRux86sV5f+4i3AIJUdnm75m88OOlJXJg/eN3cNNMrQSTIJnfgGEtHaQQkOOEgcOUut82TSgpnL2Asa1i2EfizmKAceeIA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=P6v4UI4Sdb8ZSGPH0XO3ltm2HNG6ZO4ThTLPKFRcAUo=;
 b=JwLI4rckJhsgpMmgrvm70NPqfHEdE1Hvr8BJdFR9FmQsF4hVAAoWzv2SpmrAcWSTYYo4CdU2WH24Ertk0XLsbPyL7ZJ5ksSy3mAM90T6wkmhdIIBfGfYpExEFR9J89h9wkesGGOBPulquHvEkSgHHcQzb377p7BIdNB+DHVjCB/Hrw4MpMQgHzwSgPguVvFr8e2VI4mTzcpM+TcKJI5CF9pVKe6o7ci6CxCV2prEbTgnM6TQiHsKnoLeGpkrtOUjIyXcyCBcOoyAZ9a5TOEQ7cbDxZuH1QHPT+jU0dGHHTD11ynF91ZQNm+J9yGLxczwkvsKyeJKGSntXnQh6+x9Yg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=P6v4UI4Sdb8ZSGPH0XO3ltm2HNG6ZO4ThTLPKFRcAUo=;
 b=R+DjoEJ9fx6ZWWw1Hoz27FoOKAlmBa3rapeEKAti78JOH0Fbjr1GdVd2iPzlCB0Ndnj6xm2lyicvRQVZWnahOe9BeSBof3SMlzU+fErSMqfFUKvNthndNomWuNcch/L7r0Hc2ENP2xU/U0phpelHQwHDuWmcBdZN9F9JsMnFVMdT9js7fxmc+NzvR99Z2pdWZnEWpVx71Kg6PsgOop4LlzX9/Abx7XnU4g5X/WkFsH87H1l414CwZRBWe82dumMzYCQfA8U9gWyBL1+OKflSiIGScIk/d4rkjJGJa4/il8fKy9gdPnlratmbX29PQW5yVxDmYa+HEqLL8/ZlrtU99Q==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
Thread-Topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3
 platform
Thread-Index: AQHX8M3HLq8qFfw2eU2jxqbriRiMpawzTbcAgAM4BwA=
Date: Fri, 17 Dec 2021 10:48:51 +0000
Message-ID: <20211217104850.GA3974874@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
 <35435638-a132-1b46-6add-b923f9f2785f@xen.org>
In-Reply-To: <35435638-a132-1b46-6add-b923f9f2785f@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 02a1a092-708d-42e0-006d-08d9c14ad04e
x-ms-traffictypediagnostic: PA4PR03MB7054:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7054CCD50F753AC79815BA09E3789@PA4PR03MB7054.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 26gpuw33ScWreuKU6+VkGoHMYs1+O4rOsWIB8QWf2lz/ySM5tk/t4nEgQ0U/NLs4MFgS36LgCPEofvfNXsbubdS3ze5foXxKH0diYwekfXbRCHHrmyudyIfQ10Sf8Izg1DaWAqEhKlzM4gpgAyYq3kEmkxGmQOF/OvYUoJPCM/Ehr710JzBx4bOD3t7mX73Tz1TlN4kweY4Qy+KVMpRZOyC7M3uamkNPvs9fmGicZiVPKOPwo7VA7mqem0m74SwcEyaiwm79JIaUsyfnTxaPxy45k5g59PSPbgHCPMVSiuPxZfazhdwdZQTuCuzTEXO+MyxNsPMgwJqKWOWPrdlBQI0Qw35AmuA0laWIxo4Jh1Ygr1MTtWwRrtmHFu//a/aSwCLvFyE5QmNDWADQtBAkXIOpK/Zemgkv1qGYuEeU+l2AgLAGdUW/s005jRqImZqHHlo9+nlcFU5W2D0pLSYD/+A6Yhz7Fy93LDOsne/Loa66r0qBL0JUmj1dhY1BQn7nwqCYnbnfPpxOzdXk9dM2py0JE7Wbccj0IkQgWgOPdheclhtiZT4CKa+el5criCm2MPlIF0P9q+U0MARwblwDzDwlH0+Ri3KKlj3/K48UCqAMSlPgB4KPtnr2PrQzjP4gS+RI5tuMCM+vqlDfO/X3I5jCPx09wb467a+S7vuo5flWhTNZwinZzlwjQsfMVFPBKjSJZ4tnCnpPYxYY4bw4PA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(4326008)(5660300002)(6916009)(6506007)(8936002)(186003)(76116006)(33716001)(66446008)(91956017)(66556008)(83380400001)(2906002)(33656002)(1076003)(9686003)(6512007)(316002)(66476007)(64756008)(66946007)(38100700002)(38070700005)(86362001)(6486002)(8676002)(26005)(54906003)(122000001)(508600001)(71200400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?f1CYU2N86Z75Iy0CjWdKbEsApOrQt8rqDgrX5mzQe6ds/IVb5fbubiasvBYh?=
 =?us-ascii?Q?++S9xSV/7CyzY1b6RwI4OJpw+Exv2zs8MfoUAoZqdfKxvXAOYC/GWIjodpJY?=
 =?us-ascii?Q?8Re5kUIcBc0hIBwgV4Xx3PSovw++Z9pccpTQ1227dvxUWLDW6JWUjKI4KzIy?=
 =?us-ascii?Q?mVPf/4Zn7DhKzJXPnNty5E14Ru0HpyDiwmYL7k64pkEij7z2jsZ1Mk5wCLCq?=
 =?us-ascii?Q?M/7f9XKUF4w0iPAS90Efy9vFMwcEtMcclBsDayTA65lBmKWbARouxs56oyP6?=
 =?us-ascii?Q?UEmYhvt5kaFiJpwlX1fq7Ht+o/rxRprNHrd3TJmBGMbkUAoMIAEWLL5pXec0?=
 =?us-ascii?Q?keh6gkll31unaSUuN0eBv477jBae1Yl+rK9olY8SZtB0UDIfMvaD4Vg049ij?=
 =?us-ascii?Q?6PVhccoBfLl7UR5tlmL7lS2Qy+yea8skrRJMLF14YH/jUw6NTgYZdoGOq7iK?=
 =?us-ascii?Q?WkDzCbXSJkOehjj4nlE/tPMN/yX5OjE9yoyGAzRdTTjreqAaCUGUDfVjsiAW?=
 =?us-ascii?Q?NEGUsL7kwDmN/b6VPWLacQsUCErUW1b1M2ST704kjeza1GVIPSizh4S7aJjO?=
 =?us-ascii?Q?q4KmrDg2LN+dMY0z12e3VsdM6UCgYWZQJcUfyxFc3CntejS0ZSkUrYytBg5m?=
 =?us-ascii?Q?/Lm/lYKo3pzi8EEVFzDLwG5q4vUTwRr+IgQf04h2HO64uDNJKP4TxaelPddy?=
 =?us-ascii?Q?PO7qTa7Po64a0LZbbr7ipYI6rLCjLlPpHTacJ88AZJ06AeGBC4H6dOaMSnqA?=
 =?us-ascii?Q?K3xUNInlnn/fJdoKTQ31jfmZlFwIUN0pakQWXOuJ2pimylYpK4FJwtsGkjns?=
 =?us-ascii?Q?WftlkjjX92bmiCAfYOJgF6kVnOGGnIYOXhaGn5ZgfsDzjhd7gaEy4Jp/yGzx?=
 =?us-ascii?Q?jAouZBOYOtHkpoELMSpZLEIe6mwt40yu+roekBfk0mborJNbqjRH1cXfHSpv?=
 =?us-ascii?Q?PKt4iNRss4lp7otdS+UfBCdXBOy8HKueqFnNDUmbtjuU/IE5RKQ3bx4+mLtN?=
 =?us-ascii?Q?LNUeUZ/kvTJZhKHaJIiYzzUJWymbl5zrkRbnzceVDA3UbQbxYZrl067EVtuZ?=
 =?us-ascii?Q?ZlRpN502JBJzmHAAPnguSBAsSr2ruH73pRxbOjyyZ9+5Gj1GVp4ohnrERRT1?=
 =?us-ascii?Q?fD3Gth5S2x9tDVvuvIU7TvLjEA03SSQLuk60tfvDMDpFReDOboamCtNTQ06r?=
 =?us-ascii?Q?K0wPRSx+PHiA2xjGJ4R6z+O5oiHl2bFqbmWoOF4D4x9vX6jNP36QMurPf7ig?=
 =?us-ascii?Q?3iE4AlklMIyuET8JJPuP2InMiV4bHcF7rYFMXN6jjGEpyXBGCT9+/lkrKUoF?=
 =?us-ascii?Q?kIeZQJK0kS4AdJQEI8ntlZDD7dQ0v2qNHcx0fmTtaZt3Lv3P0mc28QTNqrlN?=
 =?us-ascii?Q?2/eN/ga7WXaWRg6F1EP8nsE0PseymbD8hiUPfl4Sm6y8BkZ4Hf/Ea9o/RwUg?=
 =?us-ascii?Q?iO+RofagzCM5QKhYBfNN4NgEeiwYnHBG56TOyAA9+hI7pfM9s/d/q0mJwTF1?=
 =?us-ascii?Q?o7NFBdwpnLv7C73vwYpaSAN521Za4cEGQP9Svf1Z+dZQGz/OolEZPdY876/W?=
 =?us-ascii?Q?ZYAVe731389undQ/IEgE7zwpOP0iR0WixvcAiPiYz0YCxKbdNAmpybPEjifP?=
 =?us-ascii?Q?/cLqTEjXdsn2mlw1T0pUSXxC2AeGAm6HsmnxURjHlhXbbibj3tYNtM99YJnn?=
 =?us-ascii?Q?KEl/Dj9AoPaPsK3B5RPqTiXNDoc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <41C85C2E30260C4DBF59DB48C75D0234@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02a1a092-708d-42e0-006d-08d9c14ad04e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 10:48:51.5055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3gVqC08hIq7ULx7vC34eOnIBf9e5wQW6KU6ZpojdQku6GK8SlDJskxz/nts9zzOd43e7UbnTkom8RH2QylqiqaN8S6J2P8RwGRTJVitE1hk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7054
X-Proofpoint-GUID: TsM692HUlpl9_6NC1Npg1EXj8-O_qtK9
X-Proofpoint-ORIG-GUID: TsM692HUlpl9_6NC1Npg1EXj8-O_qtK9
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 malwarescore=0 bulkscore=0 mlxlogscore=576 spamscore=0 suspectscore=0
 phishscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0
 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112170062

Hi Julien,

On Wed, Dec 15, 2021 at 09:39:32AM +0000, Julien Grall wrote:
> Hi,
>=20
> Looking at the rest of the series, this is going to be replaced in patch =
#2
> with:
>=20
> return sci_handle_call();
>=20
> SCMI is not specific to RCAR3. So I would expect the function to be calle=
d
> from common code.
>=20
> If it still needs some platform specific code, then I think it would be b=
est
> to introduce rcar3.c at the end of the series. So we don't introduce a du=
mmy
> platform and not hook the code in the middle of patch#2 which is meant to=
 be
> generic.
>=20
> I will have a proper review of the rest of the series in the new year.
>=20
> Cheers,
>=20
> --=20
> Julien Grall

That's sound reasonable. My first thought was to move SCM func_id to the
different section, such as Arm Architecture Service (see Section 6
of DEN0028D). But I think that SiP service func_id fits best in this
case because from guest standpoint all clocks\resets\power-domain ids
are SoC implementation specific.

I'm going to leave SMC func_id in SiP range, but refactor SIP smc
handler, so no RCAR3 specific code will be needed. So there will be no
need to introduce rcar3.c in this patch series.

What do you think about that?=20

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 10:52:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 10:52:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248543.428695 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAr4-0008KS-Fn; Fri, 17 Dec 2021 10:52:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248543.428695; Fri, 17 Dec 2021 10:52:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAr4-0008KL-CH; Fri, 17 Dec 2021 10:52:50 +0000
Received: by outflank-mailman (input) for mailman id 248543;
 Fri, 17 Dec 2021 10:52:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myAr3-0008KF-9n
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 10:52:49 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77f9112c-5f27-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 11:52:47 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BH9pipi002660;
 Fri, 17 Dec 2021 10:52:37 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d0jxw90ka-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 10:52:37 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR3PR03MB6362.eurprd03.prod.outlook.com (2603:10a6:102:7e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec
 2021 10:52:33 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 10:52:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77f9112c-5f27-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dSlqhmf2mbFhfwjkSwuhQ6iqS6mGAg9Dtl8FRfTE8PLHfldj4obSELjP+wFVZycxzIPsjEMG4dpblT1SLrvMP3gAgy+PnU8XPFGEjJTa6DnS1wh+jnWYANUPkHdmR2x+Sei8s+1+AH5o+lkfbIxfDLw8llJB5w8oFzKBNMD8XNv6Xvf2Kqu09B84vL2ohXDnshnH7b1rRl/s3JhThHI+nveQHj0xh/dpXJfyQpsHy4vd3FoP8esBgV8HJ4yIKdZMLPUJiIWChJ3nWcfy+B4tUeIszvMZz+gHunW6tJydn8qAyIm3m2ZtjfD2Aehm3CqnFSMbTSI3efVjP0pXpp0XKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pk+Gk4ItT6RvNhHyYJbyNOPGL3wFDVyDsHbr7R3sP4g=;
 b=DU1CslgN5LL0JDFs61R37lJ0ilFdkdjIp7V5EBk5cXFne6a5Ohh5cCtcswGnSdPSMWANE4Qm5rw93a8JqbZwzrvSMcsM/N/mnqo7wNaewMkx8Mg9IgWJmkFOYC5fzg0bmnFi+OUJPq86ID2joN29R+q9WCYwwirkRSJ3cHvfUEY3lyjEVlBaqbxO19amJ3D3S0Ym/RTxIiPrD7HwqFI0v73WdYALMEbtRBw2s5vPS3k/CXo2yY5gyaveM1uWyNOACgMFBdKwi5OfHR+VsOT5U33lULrBALAqg0a8C8kdJCUKCteU7acVb9kMz8pABjK3U8c71Jj/xif+4rSuHuXLvg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pk+Gk4ItT6RvNhHyYJbyNOPGL3wFDVyDsHbr7R3sP4g=;
 b=ZyhUcM1KEGyRsYNYSVi+pHwPZzr8oOle9nVXFzAGBu1dA6dfOoMaW3S6dKf2XC/r5Z98URVUvBsGh6RrJkCxkumWUjGB3Aa6KkEyxvqZ6/j0TYo/5HyaGvUczsVoHtV5JttXT9YXHdAaTpGbK17P3C7+PFc4Sy5iPxdh5BokisBUsaQqkeskBBfwdwyqmlKZ3CLQzXN4J2LtQSEiRpngfyeDYLtj8EngYOgOordM3hiWSlJPLTYPT4TBPV/3ZrvbURT2KnWpOtVXh5r0uMf+RdNJizJTlrRZy3cI6mal6NrNEOv5QvUMzQLbFoJ0hF66t6LxFBGglU46ZLuj8P5QAQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform
Thread-Topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3
 platform
Thread-Index: AQHX8M3HLq8qFfw2eU2jxqbriRiMpawzUruAgAM0DYA=
Date: Fri, 17 Dec 2021 10:52:33 +0000
Message-ID: <20211217105233.GA3998068@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7ac8512b5479cf192b4aa399fa2501d0bccaaf48.1639472078.git.oleksii_moisieiev@epam.com>
 <CAPD2p-mWWUT=kLFDOfsYrZp7hGLLbbU4SiPaFg1SKjF3Tkj5kQ@mail.gmail.com>
In-Reply-To: 
 <CAPD2p-mWWUT=kLFDOfsYrZp7hGLLbbU4SiPaFg1SKjF3Tkj5kQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 51cd320b-9e74-480e-2d13-08d9c14b54b2
x-ms-traffictypediagnostic: PR3PR03MB6362:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6362BBBB34B4F84F916842ABE3789@PR3PR03MB6362.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2399;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 YGtVLJ+IWyY7yS/ZzRW4EbrHdW37a0bqb8LPjlUNUYrl6YRX2UrbGAGioNViPyevL24VtIdEeHqIhyna4pcRW0+frk7JKylk1PzFnAjo2fs1ajYLK2Z9BWToDoj4zSnH0haBfOCQL0GRfUOuBRVCwTnGR2utBoarMVLQffQr23NDF8OXeb8vuO8COzC2Jip0R365AwMTTGv2kI1Sf7MSo4Ugjp7vwsjUDaq7CAPy/mjsGkXhT4GPwU0fQknJaI5lR8qL96O1NvOGUdg9LpPUwFwvOrVUH/ReLdoGM0NABd9RT1f8pD8vDsBrQ6GZA8QxFXHwK8zciDbRIiM8JMrCVP07VIaQeu+Bgz4mgCXo3e/T+2f92jRlVV6ApqKuLYLiwsvusQUJAPL1KvOzxXiEDOZIWZFiIXBZpNgO1WA4Q1vxdubezlP3CCtdWPvAi03pnaFg6dVlQEjPXgHCf537gs2EeSnRgsPjz0G2zoGNyHQ0fbNRfuWahZEKZNOaiJH/5rs9O2x1XbtneuY9kEYuPYLqOMFDNUGCdS49UGXycj9vJVfscBIB/i6oYTYAfdT7p2byqD7/0+oK6Sw2MqVoQSzlLCL51WL5+dfPlDBT71oGix1wmjpond9zLS9m6pNWzMUlruktfZS1aD77AxRx+sgRAiF/Za3PsrWG55yz0lZSBCY2J+4tIDZdCY4OkqhQwhHwKWCBycKPkTsOQNhfd/VzzsnRiWHrcDB2OOgdvgI=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(71200400001)(66446008)(6486002)(54906003)(4326008)(8676002)(186003)(91956017)(64756008)(38100700002)(316002)(508600001)(33656002)(38070700005)(6512007)(76116006)(53546011)(122000001)(6506007)(66556008)(66946007)(9686003)(26005)(8936002)(86362001)(66476007)(1076003)(6916009)(5660300002)(33716001)(2906002)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?nFMDU0ZvZuccIpnjpe0IVeXMOkmCsO1ET8iWDSs0Fh0baQJ8Ajos/b1zXZgD?=
 =?us-ascii?Q?VoRQwlF/UOWZJk+EREITK99ln+vRglZGq7NqnGkPmmpNYQI1vw9x6ok79xLP?=
 =?us-ascii?Q?vJNFDU21NGziqizOJ/Bdp5J2NYeDEyKS7De9AFdbdhjcmY+Bj6/eqnygzMJq?=
 =?us-ascii?Q?uOcBYmBxDeAryKY3Z87/dMslJMU+obuEzN0yxQIUK5ciANPL4tC8DQfMuXjd?=
 =?us-ascii?Q?Euu2Fdt+VL1hk+EXEwh40TbPxlYyawDt2bcB05FucbofwhCQD1hcXEdZwSLE?=
 =?us-ascii?Q?wn/5NLyFGJo+1XAkhywQzLA5EtVknM3q92oqEno4sIIdIFZTgr6yq7JdS61T?=
 =?us-ascii?Q?JDMml66A/NL7Kt1Q3lvZrddAsAJ6EQyWWsreRl2gI0EK7xPYvKTecite2mOl?=
 =?us-ascii?Q?NE/ce3Vq2MvPKbpnwKk/K6j1HLOqfqQn+Uib86yxw9Km2yNx8bG6FznOwKZg?=
 =?us-ascii?Q?NcvXF+y/JVy3EXqZBiYgOTA9P/awuM1m9dVXX7zosD2CSBWUUBj4uTzOh6xt?=
 =?us-ascii?Q?Z51H+b+ygNR/xAiLPP3P/3c4Evl5pake5YIEjZBKsJidL66i/sKOoR6eT3C4?=
 =?us-ascii?Q?m70LqAN/AVvIMU2YxwsznSN5qOzzMi7ZeejCl2HR+JhAVC2jLWW8mNS3NRka?=
 =?us-ascii?Q?+cEaWLFPHH7VXJTdRiE1dr0B1ER5CHtnnseMJ5673z3bEcaclDq78+rT8gKj?=
 =?us-ascii?Q?7vF+nnOzSZwCmk+Ed5AFuBTa1IKHF7cAj9XSYBwXfNjW7wrOnZj+60qbsrAc?=
 =?us-ascii?Q?dLqCljQq767WJPByZv8briTe+Ab9rN93yAyJ/URG2HDVICIkjuy9MTBpScho?=
 =?us-ascii?Q?Vo6ZHsffZ8UsqAI+BEmVDP/PuRSLgHrqa9KRcfeoq1MeOi8fwXmmnoB9jKe9?=
 =?us-ascii?Q?ICqqOuKoQDxmMreG0QxazoIpPGUI2q/rvph2MAXls2XxoXGa2ieMB2tFgyVg?=
 =?us-ascii?Q?spkMd2PZJpR0FqIn9RyZ0oUg4QJNmT6AE3APZDA7Zl2YdDx1K4EdM2QPDcI2?=
 =?us-ascii?Q?jAy02DX/cvYBE3PkJHOCtD9XBG+uObD6xDBSF7VaTORhvAfTyN6K/1FaH2pv?=
 =?us-ascii?Q?63VTL7ynimWUyFPyhbrRYxJN2HJBp68S6BtQEkOINiO2RP32XF1G6d4Lh5/9?=
 =?us-ascii?Q?NEwYI4aQBmJwS6DRPPe/q1JYPn261vUQXhagm4Y//3uexLgMXC+v0YXPCGXW?=
 =?us-ascii?Q?FoESdY21W7EJbgwO6HkEblal4o1HOWsjjFKyJPM7f1NtQBNUqvAKHXapcTv/?=
 =?us-ascii?Q?WcJtjB6h2N2/Rhw9bzrK36T53+r9WCW0BCafg7xzrRCI0cpwR4UFxWrcT6bn?=
 =?us-ascii?Q?2/H+08UGkI1E1tvxtxoUtA4u3FsAk7OknvRff3nuVf0XsolsyKMcSseunT7E?=
 =?us-ascii?Q?pkAYpEVO9uVm1dEtg712FstAa3eKQ9j5vixOvL6HXIXWPi0g0xSvMcJguMty?=
 =?us-ascii?Q?N/NwPX2sd1a9vmueAFEPPHkrdDVoe1es18pvufWGWAA+3zJpz593Gmvk5eFa?=
 =?us-ascii?Q?+BOImMk6OSX1WZ40c/zmnT+6lylnuZ1aJMLp8hAYb1PaWwN8JD9cEKnRkBIZ?=
 =?us-ascii?Q?8TRpEiAOygTmcqXlkhiPB5U00xO5Wdt28XcCv0N8xfoR+DIvTiu/qWHsSTI+?=
 =?us-ascii?Q?dTCKgD4VXp4tEbLj9mMfZg28JF3xB5mJGOS/Z7C3FFz2uMitbMpn8x937jWA?=
 =?us-ascii?Q?yfKmPMtHFNaTYmy3JWEmQ63Cs8Q=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <77776A29A8345D4686ACBFD141C2A9A2@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51cd320b-9e74-480e-2d13-08d9c14b54b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 10:52:33.6055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OSDGlmlLp3h5qjRYDOv6ZErV9zEybF1gaWI783XRJhBoRwwLN339Tfy+Gy++GPq9DQmpLSkJJloduwLkRT0gddcnVeF4VLd9rV+q93CCRPc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6362
X-Proofpoint-GUID: mXngbbr5TWDIZdQgk8ue0SsExWx4eyO1
X-Proofpoint-ORIG-GUID: mXngbbr5TWDIZdQgk8ue0SsExWx4eyO1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 mlxlogscore=999 spamscore=0 suspectscore=0 lowpriorityscore=0
 clxscore=1011 mlxscore=0 bulkscore=0 malwarescore=0 adultscore=0
 priorityscore=1501 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2112170062

Hi Oleksandr,

On Wed, Dec 15, 2021 at 11:57:29AM +0200, Oleksandr Tyshchenko wrote:
> On Tue, Dec 14, 2021 at 11:35 AM Oleksii Moisieiev <
> Oleksii_Moisieiev@epam.com> wrote:
>=20
> Hi Oleksii
>=20
> [sorry for the possible format issues]
>=20
> Implementation includes platform-specific smc handler for rcar3 platform.
> >
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >  xen/arch/arm/platforms/Makefile |  1 +
> >  xen/arch/arm/platforms/rcar3.c  | 46 +++++++++++++++++++++++++++++++++
> >  2 files changed, 47 insertions(+)
> >  create mode 100644 xen/arch/arm/platforms/rcar3.c
> >
> > diff --git a/xen/arch/arm/platforms/Makefile
> > b/xen/arch/arm/platforms/Makefile
> > index 8632f4115f..b64c25de6c 100644
> > --- a/xen/arch/arm/platforms/Makefile
> > +++ b/xen/arch/arm/platforms/Makefile
> > @@ -4,6 +4,7 @@ obj-$(CONFIG_ALL32_PLAT) +=3D exynos5.o
> >  obj-$(CONFIG_ALL32_PLAT) +=3D midway.o
> >  obj-$(CONFIG_ALL32_PLAT) +=3D omap5.o
> >  obj-$(CONFIG_ALL32_PLAT) +=3D rcar2.o
> > +obj-$(CONFIG_RCAR3) +=3D rcar3.o
> >  obj-$(CONFIG_ALL64_PLAT) +=3D seattle.o
> >  obj-$(CONFIG_ALL_PLAT)   +=3D sunxi.o
> >  obj-$(CONFIG_ALL64_PLAT) +=3D thunderx.o
> > diff --git a/xen/arch/arm/platforms/rcar3.c
> > b/xen/arch/arm/platforms/rcar3.c
> > new file mode 100644
> > index 0000000000..d740145c71
> > --- /dev/null
> > +++ b/xen/arch/arm/platforms/rcar3.c
> > @@ -0,0 +1,46 @@
> > +/*
> > + * xen/arch/arm/platforms/rcar3.c
> > + *
> > + * Renesas R-Car Gen3 specific settings
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021 EPAM Systems
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <asm/platform.h>
> > +
> > +static bool rcar3_smc(struct cpu_user_regs *regs)
> > +{
> > +    return false;
> > +}
> > +
> > +static const char *const rcar3_dt_compat[] __initconst =3D
> > +{
> > +    "renesas,r8a7795",
> > +    "renesas,r8a7796",
> >
>=20
>=20
> Please note that since Linux commit:
> "9c9f7891093b02eb64ca4e1c7ab776a4296c058f soc: renesas: Identify R-Car
> M3-W+"
> the compatible string for R-Car M3-W+ (ES3.0) SoC is "renesas,r8a77961". =
So
> in case we want to have vSCMI feature on this new SoC revision as well we
> will need
> to extend the compatible list.
>=20

Thank you for the point, this will be fixed in v2.

Best regards,
Oleksii

>=20
> +    NULL
> > +};
> > +
> > +PLATFORM_START(rcar3, "Renesas R-Car Gen3")
> > +    .compatible =3D rcar3_dt_compat,
> > +    .smc =3D rcar3_smc
> > +PLATFORM_END
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > --
> > 2.27.0
> >
> >
>=20
> --=20
> Regards,
>=20
> Oleksandr Tyshchenko=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:01:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:01:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248548.428706 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAyj-0001WN-Ag; Fri, 17 Dec 2021 11:00:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248548.428706; Fri, 17 Dec 2021 11:00:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myAyj-0001WG-61; Fri, 17 Dec 2021 11:00:45 +0000
Received: by outflank-mailman (input) for mailman id 248548;
 Fri, 17 Dec 2021 11:00:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myAyh-0001WA-Hh
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 11:00:43 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 92f20469-5f28-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 12:00:42 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHAmIed021131;
 Fri, 17 Dec 2021 11:00:38 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d0s44818p-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 11:00:38 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7135.eurprd03.prod.outlook.com (2603:10a6:102:ec::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 11:00:34 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 11:00:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92f20469-5f28-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fHJijGYD/+Y7X1wiK6O9OVYf35xZTpMChdXXeqiXBpdZZdycKHKVgejIaMLhZXunvr9QrXByrYN8qU6J1KzifkfMvdL9wkpCa6yZqItEurt4FUovrwhyalrjGd9z4et0H9RKsiK4vtDu/wKbewDsvVCzuNgxceXVzhCr6uRPFZ4/IuXi1BmhCgNrlImpGDnsIjJIoUG5A44h+xgEKh2/dmK6lS4uxMZAcymC1lVhiAwKq0EQE2hzsChbZ5xy87aNm8aCSPmqWGt1ICDNEXvNrT5DeptTvispBU4r2TbYtPSAHkQEnXTZkDNyyeGj6DjgxlP8uCjkQrUw3xY+22hxnA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=slWg4g/yF2h8UtMXIgfp5KuwYyf+5AYnIrB2mZ05rvU=;
 b=avXA2hm7MA6Nas+l8k8ElEVkup3KpBUmW17X9NVy7h5s5NyiY8/GBCABIkt2HZUWa3qZ1NJ8SQf3QXNXlu5eOjahY7adPcpJ3YUraRxp5YzgiXbKGyaoVN0m3kLT9D9Z5JhEME6JEg5W9EWvcmI2ORjoLR2w8CchkJkJaRdhbZbl4PCFza8TqSoDtXqxs/scml8rgJEXuaX7I96yiwiwtw2s+X0jSmsa5pGRZXuo5T/xyhbwMT7qBt6e7FubwqV4adSfln9NbiUpVwpVldCPdpPFQ8Qg7jbiydfcbF4MOWtmbN4cqzkUmHhYYfDJw2rZW8UL+MYFvd+CcblS24ValQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=slWg4g/yF2h8UtMXIgfp5KuwYyf+5AYnIrB2mZ05rvU=;
 b=qo66cMryGAd/tm271Rzmw3Fzz2JrfPcgpOPRkOomG5uec4xTOL1V4vylZ/wwvdnx6D1GWkR2FszEcoKf89QXUM4UP5oojdJKuXuehVYGx182x6zACOj5WfC6CPw+AHHRCbMLbgFgyBOrUAzov2pFvd69kPIyUvJzOaW4KF3maO6XugQhOP/UmLEHERnJktpHf1YE1CV2eFoXfypx6mR39JXU0Xsx+N/+verFZp6kyM9n0a9BxMl0/mySTJXwVrU04Z/dtmI7Ld0H8Qt+rxzL52Lq+176b3MqPHBURGGqXGv/xe0JScEkbt2luGCm2V5M6n6qsvDJkitpv+b+tbtsfA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owqw0GheAgAJu7YA=
Date: Fri, 17 Dec 2021 11:00:33 +0000
Message-ID: <20211217110033.GB3998068@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
 <eaed4dac-219f-39ae-7237-0ae67c77869a@gmail.com>
In-Reply-To: <eaed4dac-219f-39ae-7237-0ae67c77869a@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8544fcef-b829-456c-5558-08d9c14c72f1
x-ms-traffictypediagnostic: PA4PR03MB7135:EE_
x-microsoft-antispam-prvs: 
 <PA4PR03MB71355356D6BCB9D97D70E8F9E3789@PA4PR03MB7135.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Y6V/U2OqWqVSdP0B2wCZSqE86tGOlnl5sVNZvuwnHo6zpmG6UXtm+Ss1Q/+6GcWE0Ui7oUw8M+e5NeTMhJcWwx98w/+lwXTHDFFEgrVeDM13L/kEgDr7tcLO4XHKpwX6Aj9f7AtBZJSlDDAYqDL5mvsiCKlIHFyCjXNxHza/oHG+wI58TNrAZMk8XhXGIj5AXmICpvAv9vYy0x0JXgvJHWFQ1FNmZNBNN30uyT7ZsZblbFNalcw5TMtvX4QLzfmSHHFxvhd4uCUB2dy/QyEj1VERdGSnOIkSh7lM6kd8xmvSxqq3RdJoQMev/OptDKWRW3hZ/nAc21GAqzJYLcVdCB5U3h53gyrdSdEda7AqZFnhYXJZmH2T9R3CiXDaVV1+UdF/VeWllgzpPrPc4qt+bg9zSjCXtQAmDCewH/vHPqxNNH5tisAT8JENf3GtQ6u868XtZJzZnqby5fCU7/CqAmq5fvs37ueFukBmaO25F1o4U7JNwUwR7Jm1lzd4gtBQljZNup1cVmH9Km/fNuIsHikgw3yziCG/6yV504gTqdJB4dbUQ4CMJcKqcQLvdgyga2cE1uURNqq3IuzIadxANYhgl9pLn7icKpglZXaXvlh5SaLMZFR+ss+O4yZzuWo1DKMwcVx1TMLEVEoK0de5S1KnoLNmfy0x38V05c9nB7sWrZcXtgeeyAs/93DUPV8MR1pHk86jMI5oowZBcWvItw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(1076003)(5660300002)(54906003)(2906002)(71200400001)(6916009)(83380400001)(76116006)(6486002)(91956017)(38100700002)(8676002)(9686003)(66946007)(66556008)(64756008)(66446008)(6512007)(33716001)(122000001)(33656002)(66476007)(53546011)(38070700005)(508600001)(6506007)(186003)(86362001)(4326008)(26005)(8936002)(316002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ZjKjjZCgAPFR4keXTMQgBJaiyctdnDEA+5CrGOybALm4J/ky+0zwss6CTf1t?=
 =?us-ascii?Q?9xMcbnQurr3T399tG47emVYmdW6J1PghtwDHL36edY0OLJeE/AdTWv5Gw/R+?=
 =?us-ascii?Q?DG/nqJ8iEEJp+gJVyI0jSTDZkhYIz/1AgVJJ+GEk3Xas9ofnR1aTC4R5EKWH?=
 =?us-ascii?Q?CWgzzvcCezAMaSgPL+vw64hEGWVdwvsE5ldEJbNMIU6Dsm8zsydEJgdwDTUI?=
 =?us-ascii?Q?CmlsyxRiLlEO7wtresHQ9G/ztTrR2+Rn3XYZ8RqRkonR5NUkADASEE+5J/Xj?=
 =?us-ascii?Q?B6BzTeEoCWhOX7CCDYt08aHT2OOo3DsFEt3mo9WCq2LB53a/dEAcwDhkrb72?=
 =?us-ascii?Q?/LMvTYr+Eiu4NgDGmlTfgev9RGzOuMRdG9vx1ASrdKxaWSP+MQ4fhx9uh7Ln?=
 =?us-ascii?Q?OSrqWwULm/g+zprU1U0UjIBOhJ8AePqsi/O8vdwqEkeKDmL9ZvtiUwdrwWfW?=
 =?us-ascii?Q?Z4Bv1/fMNK6SSs9YIaVcnQ3ok+na2C3oVsQpGRY6UI4gFi6JPMjwgdDRzFxJ?=
 =?us-ascii?Q?zKZS3U4yAL6QGEh4vaqanKo9yPILCXj1+AQgFpcXllSUcDUwlsWr3ZWtLlUX?=
 =?us-ascii?Q?aZPCk+7+hTH1nsrqY8fUExeDJK9ENoRDBi0OPbePRW4DLfcG/5lVZjJtkE8y?=
 =?us-ascii?Q?CEW5g8r2OrMxkqR5ijDdMvuzewo2j3yHcOjcSYrx45ZQSV16MUzuh2gyC4yH?=
 =?us-ascii?Q?zagpIVlak+Aqo9iFM08o3KdhxjeK99XV2uT1F48EOIjoJKtCdoa1RA6jFAya?=
 =?us-ascii?Q?7vZEl8ppZPYl1h0/7ckE4ocgZGQBKiimWOAUel10Z/ZQe/t5/nzl3LViV3w3?=
 =?us-ascii?Q?rALsCig313Dq/KZno+DlJrZs/fNVHPlveLxXQA21cO5lxU/bBzjnoDAAwKd+?=
 =?us-ascii?Q?XKtH+y2cXft+R3OLxltYaWaPyTA1iLtEa6Ten74b4NVK2Jzr1TtSGXs4o0Hg?=
 =?us-ascii?Q?HdLg4tk3QVtncrTkYuVBOkZFpyueO3C+RDDRVPwy/BGesDI/L9v0TimbEc2/?=
 =?us-ascii?Q?ushfYVh4Ae7SXWdC5fhTQocHNZJblKb49tQBVpjLPedF/Qo7EP6MAGG4PRlQ?=
 =?us-ascii?Q?ueXcnDcpfq1ycB54zqg3FplMf7q3B12kP/weZnPh1AnbwxzwGZJcvy1a1www?=
 =?us-ascii?Q?LKlJCmIOdGakM1xBcUS1qmyLhn2uPleGwR8kdKWdygfw+i4S8fF5kBt9rW2L?=
 =?us-ascii?Q?ZPmWljg6wPqEcA5yGKXpRO7pfQ23nkAqfmsN9k9igYIH+tDTB86S7ZiX7/eS?=
 =?us-ascii?Q?RjsBOdZjxzNVjABtyIUhchTHHSk4PFUAS5No4Ih7H/2fk9qa+iizCiJ/LmPp?=
 =?us-ascii?Q?mtiS+H4AlO6gLwi9RaXdyJImRVC27hdwTXOu6ZTAKKPYMil4k0GJex9UK+G3?=
 =?us-ascii?Q?Yxhsl/GpWsohtd04M0q3dlBlyAjbhL6qPPSv6B78b+feLIZpQp9SL54a2BjG?=
 =?us-ascii?Q?2mPxTRpPBjVEH8Rq+Dzn2VvLVx1hWQ1hOu329NRumGtIOuvW307ny2ZSqtyQ?=
 =?us-ascii?Q?IkB8I4DYzCXE1voI/6Lk1v8u/zj+0TfXcG+cZjJvtoJUfSaD9fQF2G3OFR/l?=
 =?us-ascii?Q?zqCZwwIzLMsHgEwJq8CTTH0F3BYlPp2484DqF1kfhnIcKp8+s13OOkSsDjID?=
 =?us-ascii?Q?k86Jvk4RQY7IBRJhHh9nlskodqO0Qqc4D708ppV1IFbW8POyhYgYZx5jqr3j?=
 =?us-ascii?Q?HnpcvzlV8oOBWaEnYqnDka36qWU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <76EF263E9D7C2A4FAC6EC37EFBE67F1E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8544fcef-b829-456c-5558-08d9c14c72f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 11:00:33.8792
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7qA+ck0ZJ4uXlOUOJ4OaYWyiaDy8EL+iE2hOM9AyvKu6nRZUjL2XOVjQvKcrL9He+UtpxYEvhRBwd60M7ISRI0zOwiw1iBEEq24IwOpbZlk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7135
X-Proofpoint-GUID: E3v3FsiF0yCAeqv9GPxIuRqDafCvM43u
X-Proofpoint-ORIG-GUID: E3v3FsiF0yCAeqv9GPxIuRqDafCvM43u
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 spamscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 clxscore=1015 phishscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170063

Hi Oleksandr,

On Wed, Dec 15, 2021 at 11:51:01PM +0200, Oleksandr wrote:
>=20
> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>=20
>=20
> Hi Oleksii
>=20
> > This enumeration sets SCI type for the domain. Currently there is
> > two possible options: either 'none' or 'scmi_smc'.
> >=20
> > 'none' is the default value and it disables SCI support at all.
> >=20
> > 'scmi_smc' enables access to the Firmware from the domains using SCMI
> > protocol and SMC as transport.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >   docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
> >   tools/include/libxl.h            |  5 +++++
> >   tools/libs/light/libxl_types.idl |  6 ++++++
> >   tools/xl/xl_parse.c              |  9 +++++++++
> >   4 files changed, 42 insertions(+)
> >=20
> > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > index b98d161398..92d0593875 100644
> > --- a/docs/man/xl.cfg.5.pod.in
> > +++ b/docs/man/xl.cfg.5.pod.in
> > @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
> >   =3Dback
> > +=3Ditem B<sci=3D"STRING">
> > +
> > +B<Arm only> Set SCI type for the guest. SCI is System Control Protocol=
 -
> > +allows domain to manage various functions that are provided by HW plat=
form.
> > +
> > +=3Dover 4
> > +
> > +=3Ditem B<none>
> > +
> > +Don't allow guest to use SCI if present on the platform. This is the d=
efault
> > +value.
> > +
> > +=3Ditem B<scmi_smc>
> > +
> > +Enables SCMI-SMC support for the guest. SCMI is System Control Managem=
ent
> > +Inferface - allows domain to manage various functions that are provide=
d by HW
> > +platform, such as clocks, resets and power-domains. Xen will mediate a=
ccess to
> > +clocks, power-domains and resets between Domains and ATF. Disabled by =
default.
> > +SMC is used as transport.
> > +
> > +=3Dback
> > +
> >   =3Dback
> >   =3Dhead2 Paravirtualised (PV) Guest Specific Options
> > diff --git a/tools/include/libxl.h b/tools/include/libxl.h
> > index 2bbbd21f0b..30e5aee119 100644
> > --- a/tools/include/libxl.h
> > +++ b/tools/include/libxl.h
> > @@ -278,6 +278,11 @@
> >    */
> >   #define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE 1
> > +/*
> > + * libxl_domain_build_info has the arch_arm.sci field.
> > + */
> > +#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_SCI 1
> > +
> >   /*
> >    * LIBXL_HAVE_SOFT_RESET indicates that libxl supports performing
> >    * 'soft reset' for domains and there is 'soft_reset' shutdown reason
> > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_=
types.idl
> > index 2a42da2f7d..9067b509f4 100644
> > --- a/tools/libs/light/libxl_types.idl
> > +++ b/tools/libs/light/libxl_types.idl
>=20
> I assume that at least goland bindings want updating.
>=20

Thanks for the notice. I will fix that in v2.

>=20
> > @@ -480,6 +480,11 @@ libxl_tee_type =3D Enumeration("tee_type", [
> >       (1, "optee")
> >       ], init_val =3D "LIBXL_TEE_TYPE_NONE")
> > +libxl_sci_type =3D Enumeration("sci_type", [
> > +    (0, "none"),
> > +    (1, "scmi_smc")
> > +    ], init_val =3D "LIBXL_SCI_TYPE_NONE")
> > +
> >   libxl_rdm_reserve =3D Struct("rdm_reserve", [
> >       ("strategy",    libxl_rdm_reserve_strategy),
> >       ("policy",      libxl_rdm_reserve_policy),
> > @@ -564,6 +569,7 @@ libxl_domain_build_info =3D Struct("domain_build_in=
fo",[
> >       ("apic",             libxl_defbool),
> >       ("dm_restrict",      libxl_defbool),
> >       ("tee",              libxl_tee_type),
> > +    ("sci",              libxl_sci_type),
> >       ("u", KeyedUnion(None, libxl_domain_type, "type",
> >                   [("hvm", Struct(None, [("firmware",         string),
> >                                          ("bios",             libxl_bio=
s_type),
> > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> > index 117fcdcb2b..c37bf6298b 100644
> > --- a/tools/xl/xl_parse.c
> > +++ b/tools/xl/xl_parse.c
> > @@ -2747,6 +2747,15 @@ skip_usbdev:
> >           }
> >       }
> > +    if (!xlu_cfg_get_string (config, "sci", &buf, 1)) {
> > +        e =3D libxl_sci_type_from_string(buf, &b_info->sci);
> > +        if (e) {
> > +            fprintf(stderr,
> > +                    "Unknown sci \"%s\" specified\n", buf);
> > +            exit(-ERROR_FAIL);
> > +        }
> > +    }
> > +
> >       parse_vkb_list(config, d_config);
> >       xlu_cfg_get_defbool(config, "xend_suspend_evtchn_compat",
>=20
> --=20
> Regards,
>=20
> Oleksandr Tyshchenko
> =


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:12:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:12:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248553.428717 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBAA-0003CJ-AT; Fri, 17 Dec 2021 11:12:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248553.428717; Fri, 17 Dec 2021 11:12:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBAA-0003CC-7X; Fri, 17 Dec 2021 11:12:34 +0000
Received: by outflank-mailman (input) for mailman id 248553;
 Fri, 17 Dec 2021 11:12:32 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1myBA8-0003C6-BZ
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 11:12:32 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 39e22d97-5f2a-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 12:12:30 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 61DD021115;
 Fri, 17 Dec 2021 11:12:30 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1813913DC1;
 Fri, 17 Dec 2021 11:12:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id JK2BBJ5wvGHyQgAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 11:12:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39e22d97-5f2a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639739550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QX2w6H9s04ofNrM2nkdF+F1SZFw7leVbGd2JhJcnoQc=;
	b=ECGGtFVJCOqUslqyvRd4BmrubAutIZpC5ko6ibaddcotAQg05o5tzP9chpmeoAHNDryTuF
	MaJH/PGEeXpjLAHD756/OMSq7bP/T2pA0SnAD2X83FwEDapQ4hfTerwn5e99a+Nc7u3zV9
	07dQWu2PKJV6iKmU8CXSR+KskYa1Hnk=
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Message-ID: <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
Date: Fri, 17 Dec 2021 12:12:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="IoDOwhz3q6ZxpmhMJNlX4RzT3LAF6f2Nv"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--IoDOwhz3q6ZxpmhMJNlX4RzT3LAF6f2Nv
Content-Type: multipart/mixed; boundary="fKTrddbMzShsGJXe1srn4K7HK1sHn75es";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Message-ID: <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
In-Reply-To: <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>

--fKTrddbMzShsGJXe1srn4K7HK1sHn75es
Content-Type: multipart/mixed;
 boundary="------------6C299E3B67F103C2A1546EC0"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6C299E3B67F103C2A1546EC0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 17.12.21 11:41, Julien Grall wrote:
> Hi Juergen,
>=20
> On 17/12/2021 08:50, Juergen Gross wrote:
>> On 17.12.21 08:45, Jan Beulich wrote:
>>> On 17.12.2021 06:34, Juergen Gross wrote:
>>>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is not=
 a
>>>>>>>> problem in reality because the max physical address size is only=
=20
>>>>>>>> 40-bit
>>>>>>>> for aarch32 guests, so 32-bit are always enough to return the=20
>>>>>>>> highest
>>>>>>>> page in memory for 32-bit guests.
>>>>>>>
>>>>>>> You are aware that this isn't the guest's max page, but the host'=
s?
>>>>>
>>>>> I can see now that you meant to say that, no matter what is the max=

>>>>> pseudo-physical address supported by the VM,=20
>>>>> XENMEM_maximum_ram_page is
>>>>> supposed to return the max memory page, which could go above the
>>>>> addressibility limit of the VM.
>>>>>
>>>>> So XENMEM_maximum_ram_page should potentially be able to return=20
>>>>> (1<<44)
>>>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>>>
>>>>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>>>>> 64-bit on a 64-bit hypervisor (which I think it would be a very rar=
e
>>>>> configuration on ARM.)
>>>>>
>>>>> Then it looks like XENMEM_maximum_ram_page needs to be able to=20
>>>>> return a
>>>>> value > 32-bit when called by a 32-bit guest.
>>>>>
>>>>> The hypercall ABI follows the ARM C calling convention, so a 64-bit=

>>>>> value should be returned using r0 and r1. But looking at
>>>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever=20
>>>>> sets r1
>>>>> today. Only r0 is set, so effectively we only support 32-bit return=

>>>>> values on aarch32 and for aarch32 guests.
>>>>>
>>>>> In other words, today all hypercalls on ARM return 64-bit to 64-bit=

>>>>> guests and 32-bit to 32-bit guests. Which in the case of memory_op =
is
>>>>> "technically" the correct thing to do because it matches the C
>>>>> declaration in xen/include/xen/hypercall.h:
>>>>>
>>>>> extern long
>>>>> do_memory_op(
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long cmd,
>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 XEN_GUEST_HANDLE_PARAM(void) arg);
>>>>>
>>>>> So...=C2=A0 I guess the conclusion is that on ARM do_memory_op shou=
ld=20
>>>>> return
>>>>> "long" although it is not actually enough for a correct implementat=
ion
>>>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>>>
>>>>
>>>> Hence my suggestion to check the return value of _all_ hypercalls to=
 be
>>>> proper sign extended int values for 32-bit guests. This would fix al=
l
>>>> potential issues without silently returning truncated values.
>>>
>>> Are we absolutely certain we have no other paths left where a possibl=
y
>>> large unsigned values might be returned? In fact while
>>> compat_memory_op() does the necessary saturation, I've never been ful=
ly
>>> convinced of this being the best way of dealing with things. The rang=
e
>>> of error indicators is much smaller than [-INT_MIN,-1], so almost
>>> double the range of effectively unsigned values could be passed back
>>> fine. (Obviously we can't change existing interfaces, so this mem-op
>>> will need to remain as is.)
>>
>> In fact libxenctrl tries do deal with this fact by wrapping a memory_o=
p
>> for a 32-bit environment into a multicall. This will work fine for a
>> 32-bit Arm guest, as xen_ulong_t is a uint64 there.
>>
>> So do_memory_op should return long on Arm, yes. OTOH doing so will
>> continue to be a problem in case a 32-bit guest doesn't use the
>> multicall technique for handling possible 64-bit return values.
>>
>> So I continue to argue that on Arm the return value of a hypercall
>> should be tested to fit into 32 bits.=20
>=20
> It would make sense. But what would you return if the value doesn't fit=
?

I guess some errno value would be appropriate, like -EDOM, -ERANGE or
-E2BIG.

>=20
>> The only really clean alternative
>> would be to have separate hypercall function classes for Arm 32- and
>> 64-bit guests (which still could share most of the functions by lettin=
g
>> those return "int"). This would allow to use the 64-bit variant even f=
or
>> 32-bit guests in multicall (fine as the return field is 64-bit wide),
>> and a probably saturating compat version for the 32-bit guest direct
>> hypercall.
>=20
> I am not entirely sure to understand this proposal. Can you clarify it?=


1. In patch 5 modify the hypercall table by adding another column, so
    instead of:
    +table:           pv32     pv64     hvm32    hvm64    arm
    use:
    +table:           pv32     pv64     hvm32    hvm64    arm32    arm64

2. Let most of the hypercalls just return int instead of long:
    +rettype: do int

3. Have an explicit 64-bit variant of memory_op (the 32-bit one is the
    compat variant existing already):
    +rettype: do64 long
    +prefix: do64 PREFIX_hvm
    +memory_op(unsigned long cmd, void *arg)

4. Use the appropriate calls in each column:
    +memory_op         compat   do64     hvm      hvm      compat  do64

5. In the Arm hypercall trap handler do:
    if ( is_32bit_domain(current->domain) )
        call_handlers_arm32(...);
    else
        call_handlers_arm64(...);

6. In the multicall handler always do:
    call_handlers_arm64(...);


Juergen

--------------6C299E3B67F103C2A1546EC0
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6C299E3B67F103C2A1546EC0--

--fKTrddbMzShsGJXe1srn4K7HK1sHn75es--

--IoDOwhz3q6ZxpmhMJNlX4RzT3LAF6f2Nv
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG8cJ0FAwAAAAAACgkQsN6d1ii/Ey9R
xAf+N68tC5wCHVsegfQBmziXerz9AcMzdxZUg8AkNLZ63LitFew02WzCwWNaFc0PpLB4O9q6LjCS
e4prRjZg8EEwClW2iG7tYICYHhQ1Lr/2yeEhcHhJ+9gNCxoRGJaitUyU6SisFPsvhQ4/R2DyUrNP
8oufR614YLIF4sD8dIQ/UGvfeHWNk+VtivKKA9kUN1Nsp1hhtWr55ENWlGqZi/GOZaTxU/vYXdWE
040rn1Tgy9teUscvjejP9X7M4yyLSDJOFvvZMSC93Lb3ZU4nDaGeBBbUCSpCQtXABPNY625+SQIs
+RM8+SK4eigYerK4nG4F1gBm6ETsm/hJ8WOJVvQ3JQ==
=8Cyj
-----END PGP SIGNATURE-----

--IoDOwhz3q6ZxpmhMJNlX4RzT3LAF6f2Nv--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:29:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:29:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248560.428727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBPz-0004x7-SX; Fri, 17 Dec 2021 11:28:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248560.428727; Fri, 17 Dec 2021 11:28:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBPz-0004x0-P8; Fri, 17 Dec 2021 11:28:55 +0000
Received: by outflank-mailman (input) for mailman id 248560;
 Fri, 17 Dec 2021 11:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myBPz-0004wu-BV
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 11:28:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myBPz-0001b7-2f; Fri, 17 Dec 2021 11:28:55 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myBPy-0002wM-Rx; Fri, 17 Dec 2021 11:28:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=em4RYBL4Lxqd+uULuXokpAIN3CGatXGSAgyNydl6u/E=; b=D6X7VDVIwPTVX0FnX4ATI60++J
	VYzE5PvNIrIBX9FKX2XMyI/ZmVfxWdBZT1biAmb+p/IMfXQ6LUZCLnpuNiE57mivJckNA5vxtz+v1
	gyGmhl3RAVVzvOn6+cVV23+48InG+4snElWiC8AB5kQWQu0GUqeJw6R64yyQ3aSX0VnE=;
Message-ID: <417bacad-0600-f566-3110-faca8f18b3ea@xen.org>
Date: Fri, 17 Dec 2021 11:28:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm: vpci: Remove PCI I/O ranges property value
To: Rahul Singh <rahul.singh@arm.com>, xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rahul,

I have a few comments on top of what Stefano already wrote.

On 14/12/2021 10:45, Rahul Singh wrote:
> IO ports on ARM don't exist so all IO ports related hypercalls are going
> to fail on ARM when we passthrough a PCI device.

Well. Arm doesn't have specific instructions to access I/O port. But 
they still exists because they are mapped in the memory address space.

It is quite likely we would need the xc_domain_ioport_permission() & co 
to work on Arm once we decide to expose the I/O region to the guest.

> Failure of xc_domain_ioport_permission(..) would turn into a critical
> failure at domain creation. We need to avoid this outcome, instead we
> want to continue with domain creation as normal even if
> xc_domain_ioport_permission(..) fails. XEN_DOMCTL_ioport_permission
> is not implemented on ARM so it would return -ENOSYS.
> 
> To solve above issue remove PCI I/O ranges property value from dom0
> device tree node so that dom0 linux will not allocate I/O space for PCI
> devices if pci-passthrough is enabled.
> 
> Another valid reason to remove I/O ranges is that PCI I/O space are not
> mapped to dom0 when PCI passthrough is enabled, also there is no vpci
> trap handler register for IO bar.

TBH, this should be the main reason of this change. We should not expose 
the PCI I/O space because the vPCI is not supporting it.

The rest is just an implementation details to avoid major refactoring 
that may need some revert in the future.

> 
> Signed-off-by: Rahul Singh <rahul.singh@arm.com>
> ---
>   xen/arch/arm/domain_build.c   | 14 +++++++
>   xen/common/device_tree.c      | 72 +++++++++++++++++++++++++++++++++++
>   xen/include/xen/device_tree.h | 10 +++++
>   3 files changed, 96 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index d02bacbcd1..60f6b2c73b 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -749,6 +749,11 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>                   continue;
>           }
>   
> +        if ( is_pci_passthrough_enabled() &&
> +                dt_device_type_is_equal(node, "pci") )

This check is not going to change for a given node. So I think this 
wants to be moved outside of the loop to avoid expensive check.

In addition to that, this may also cover PCI devices. I think we want to 
use the same heuristic as in handle_linux_pci_domain(). So I would move 
the logic in a separate helper.

> +            if ( dt_property_name_is_equal(prop, "ranges") )
> +                continue;
> +
>           res = fdt_property(kinfo->fdt, prop->name, prop_data, prop_len);
>   
>           if ( res )
> @@ -769,6 +774,15 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>               if ( res )
>                   return res;
>           }
> +
> +        /*
> +         * PCI IO bar are not mapped to dom0 when PCI passthrough is enabled,
> +         * also there is no trap handler registered for IO bar therefor remove

Typo: s/therefor/therefore/

> +         * the IO range property from the device tree node for dom0.
> +         */
> +        res = dt_pci_remove_io_ranges(kinfo->fdt, node);

This is called unconditionally. Couldn't this potentially misinterpret 
some node?

> +        if ( res )
> +            return res;
>       }
>   
>       /*
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 4aae281e89..9fa25f6723 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -2195,6 +2195,78 @@ int dt_get_pci_domain_nr(struct dt_device_node *node)
>       return (u16)domain;
>   }
>   
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *dev)
> +{
> +    const struct dt_device_node *parent = NULL;
> +    const struct dt_bus *bus, *pbus;
> +    unsigned int rlen;
> +    int na, ns, pna, pns, rone, ret;
> +    const __be32 *ranges;
> +    __be32 regs[((GUEST_ROOT_ADDRESS_CELLS * 2) + GUEST_ROOT_SIZE_CELLS + 1)
> +               * 2];
> +    __be32 *addr = &regs[0];
> +
> +    bus = dt_match_bus(dev);
> +    if ( !bus )

NIT: I don't particularly care whether we use !bus or bus == 0 but it 
would be nice to stay consistent at least within a function (below you 
use rlen == 0).

> +        return 0; /* device is not a bus */
> +
> +    parent = dt_get_parent(dev);
> +    if ( parent == NULL )
> +        return -EINVAL;
> +
> +    ranges = dt_get_property(dev, "ranges", &rlen);
> +    if ( ranges == NULL )
> +    {
> +        printk(XENLOG_ERR "DT: no ranges; cannot enumerate %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +    if ( rlen == 0 ) /* Nothing to do */
> +        return 0;
> +
> +    bus->count_cells(dev, &na, &ns);
> +    if ( !DT_CHECK_COUNTS(na, ns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for device %s\n",
> +                  dev->full_name);
> +        return -EINVAL;
> +    }
> +    pbus = dt_match_bus(parent);
> +    if ( pbus == NULL )
> +    {
> +        printk("DT: %s is not a valid bus\n", parent->full_name);
> +        return -EINVAL;
> +    }
> +
> +    pbus->count_cells(dev, &pna, &pns);
> +    if ( !DT_CHECK_COUNTS(pna, pns) )
> +    {
> +        printk(XENLOG_ERR "dt_parse: Bad cell count for parent %s\n",
> +               dev->full_name);
> +        return -EINVAL;
> +    }
> +    /* Now walk through the ranges */
> +    rlen /= 4;
> +    rone = na + pna + ns;
> +
> +    for ( ; rlen >= rone; rlen -= rone, ranges += rone )
> +    {
> +        unsigned int flags = bus->get_flags(ranges);
> +        if ( flags & IORESOURCE_IO )
> +            continue;
> +
> +        memcpy(addr, ranges, 4 * rone);
> +
> +        addr += rone;
> +    }
> +
> +    ret = fdt_property(fdt, "ranges", regs, sizeof(regs));
> +    if ( ret )
> +        return ret;
> +
> +    return 0;
> +}
> +
>   /*
>    * Local variables:
>    * mode: C
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index fd6cd00b43..ad2e905595 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -849,6 +849,16 @@ int dt_count_phandle_with_args(const struct dt_device_node *np,
>    */
>   int dt_get_pci_domain_nr(struct dt_device_node *node);
>   
> +/**
> + * dt_get_remove_io_range - Remove the PCI I/O range property value.
> + * @fdt: Pointer to the file descriptor tree.
> + * @node: Device tree node.
> + *
> + * This function will remove the PCI IO range property from the PCI device tree
> + * node.
> + */
> +int dt_pci_remove_io_ranges(void *fdt, const struct dt_device_node *node);
> +
>   struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle);
>   
>   #ifdef CONFIG_DEVICE_TREE_DEBUG

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:35:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:35:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248565.428738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBWX-0006YP-HY; Fri, 17 Dec 2021 11:35:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248565.428738; Fri, 17 Dec 2021 11:35:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBWX-0006YI-EW; Fri, 17 Dec 2021 11:35:41 +0000
Received: by outflank-mailman (input) for mailman id 248565;
 Fri, 17 Dec 2021 11:35:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EyUW=RC=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1myBWW-0006YC-Ep
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 11:35:40 +0000
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com
 [2a00:1450:4864:20::235])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 74fca667-5f2d-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 12:35:38 +0100 (CET)
Received: by mail-lj1-x235.google.com with SMTP id p8so2853897ljo.5
 for <xen-devel@lists.xenproject.org>; Fri, 17 Dec 2021 03:35:38 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id i11sm1343787lfu.141.2021.12.17.03.35.36
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 17 Dec 2021 03:35:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 74fca667-5f2d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=TRsbbo4ViPYIqyZsosgMrz34Dc6G+Do/bUC21W9CMys=;
        b=cKCt3corFe2k6AFdXzkqZBSRUmlquV2vkE2dyctC0V7nBsuvjkK/cN6MfMWviS8Smh
         1OMrBewWFHNfNe848pRT6eTg4R4Sq1D6GL34sVCSnzseGbxgz9l0clRLqlOztk6oIE6m
         kC56eeyvL7j1ODgi7+0kuNB0c0/sqxRSfljrtraZsJ2eEukgq1eLXuAj1iYf9K2+qnMm
         CxyKKka9nsw31l+MAZUuN0sll/20hlK7ayvpPFkdDOf2BJXM/L6/BoiuCRrrz6ABMrcm
         N5r/Hgn0wJ7zKt5/AtMwzCx8EsmSDSfG9rgtBS0h+/PCXbI3H0Otda+WLqdZ7FW8yrep
         3oZw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=TRsbbo4ViPYIqyZsosgMrz34Dc6G+Do/bUC21W9CMys=;
        b=RXEnlkImL6GAJX2Vu675otBAsqZRKZm7FYeDnfT+vS3mHPDrfpWxY+d/2yZT/m/a8+
         NvsS17sL1RnmJzEVCrjheUly6IuN5D6ADqnoS5uI8jFa/t2ZREK3rldaZ3jYbguagoQH
         DZHJBDOfXCN/Pt0csoCdWkWfmewbFrIFFI9ord6DODIuRXpar27+3u4+jBDK91Rtf9F2
         UFmv4QVblZl9/5YHJYpaSfivwEH0GO/AwQ3kmpaNAJTMYsj736IC4KijZCTYH4kiw/dl
         3sXDrOdWzMfntipnNJk6jLnqQcMzTikJSe9LLUY77UyD1ZKUDssZQXESiXVOZKxkzdsi
         q7vg==
X-Gm-Message-State: AOAM530TpfmzpaiNjA0qlllsdJvsDNCXJ40wwEge2FNmdIs0b2Ose+xh
	JJHRlpEV1KD1+iWBX6gIVD8=
X-Google-Smtp-Source: ABdhPJzyK0b3JaDV4IP0MAyBGSIlExgQrKagJ30l5eF8229ZaFXkQXt1a3xHCYiO/rGeeVr2ytZK+A==
X-Received: by 2002:a2e:94d7:: with SMTP id r23mr2343698ljh.11.1639740937546;
        Fri, 17 Dec 2021 03:35:37 -0800 (PST)
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
Date: Fri, 17 Dec 2021 13:35:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 14.12.21 11:34, Oleksii Moisieiev wrote:


Hi Oleksii

> This is the implementation of SCI interface, called SCMI-SMC driver,
> which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> This allows devices from the Domains to work with clocks, resets and
> power-domains without access to CPG.
>
> The following features are implemented:
> - request SCMI channels from ATF and pass channels to Domains;
> - set device permissions for Domains based on the Domain partial
> device-tree. Devices with permissions are able to work with clocks,
> resets and power-domains via SCMI;
> - redirect scmi messages from Domains to ATF.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>   xen/arch/arm/Kconfig          |   2 +
>   xen/arch/arm/sci/Kconfig      |  10 +
>   xen/arch/arm/sci/Makefile     |   1 +
>   xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
>   xen/include/public/arch-arm.h |   1 +
>   5 files changed, 809 insertions(+)
>   create mode 100644 xen/arch/arm/sci/Kconfig
>   create mode 100644 xen/arch/arm/sci/scmi_smc.c
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 186e1db389..02d96c6cfc 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -114,6 +114,8 @@ config SCI
>   	  support. It allows guests to control system resourcess via one of
>   	  SCI mediators implemented in XEN.
>   
> +source "arch/arm/sci/Kconfig"
> +
>   endmenu
>   
>   menu "ARM errata workaround via the alternative framework"
> diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> new file mode 100644
> index 0000000000..9563067ddc
> --- /dev/null
> +++ b/xen/arch/arm/sci/Kconfig
> @@ -0,0 +1,10 @@
> +config SCMI_SMC
> +	bool "Enable SCMI-SMC mediator driver"
> +	default n
> +	depends on SCI
> +	---help---
> +
> +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> +	This feature allows drivers from Domains to work with System
> +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> +	for communication.
> diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> index 837dc7492b..67f2611872 100644
> --- a/xen/arch/arm/sci/Makefile
> +++ b/xen/arch/arm/sci/Makefile
> @@ -1 +1,2 @@
>   obj-y += sci.o
> +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> new file mode 100644
> index 0000000000..2eb01ea82d
> --- /dev/null
> +++ b/xen/arch/arm/sci/scmi_smc.c
> @@ -0,0 +1,795 @@
> +/*
> + * xen/arch/arm/sci/scmi_smc.c
> + *
> + * SCMI mediator driver, using SCP as transport.
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021, EPAM Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/sci/sci.h>
> +#include <asm/smccc.h>
> +#include <asm/io.h>
> +#include <xen/bitops.h>
> +#include <xen/config.h>
> +#include <xen/sched.h>
> +#include <xen/device_tree.h>
> +#include <xen/iocap.h>
> +#include <xen/init.h>
> +#include <xen/err.h>
> +#include <xen/lib.h>
> +#include <xen/list.h>
> +#include <xen/mm.h>
> +#include <xen/string.h>
> +#include <xen/time.h>
> +#include <xen/vmap.h>
> +
> +#define SCMI_BASE_PROTOCOL                  0x10
> +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> +#define SCMI_BASE_DISCOVER_AGENT            0x7
> +
> +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> +#define SCMI_SUCCESS              0
> +#define SCMI_NOT_SUPPORTED      (-1)
> +#define SCMI_INVALID_PARAMETERS (-2)
> +#define SCMI_DENIED             (-3)
> +#define SCMI_NOT_FOUND          (-4)
> +#define SCMI_OUT_OF_RANGE       (-5)
> +#define SCMI_BUSY               (-6)
> +#define SCMI_COMMS_ERROR        (-7)
> +#define SCMI_GENERIC_ERROR      (-8)
> +#define SCMI_HARDWARE_ERROR     (-9)
> +#define SCMI_PROTOCOL_ERROR     (-10)
> +
> +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> +
> +#define SCMI_SMC_ID                        "arm,smc-id"
> +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> +#define SCMI_SHMEM                         "shmem"
> +
> +#define HYP_CHANNEL                          0x0
> +
> +#define HDR_ID                             GENMASK(7,0)
> +#define HDR_TYPE                           GENMASK(9, 8)
> +#define HDR_PROTO                          GENMASK(17, 10)
> +
> +/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
> +#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
> +
> +#define FIELD_GET(_mask, _reg)\
> +    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
> +#define FIELD_PREP(_mask, _val)\
> +    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
> +
> +typedef struct scmi_msg_header {
> +    uint8_t id;
> +    uint8_t type;
> +    uint8_t protocol;
> +} scmi_msg_header_t;
> +
> +typedef struct scmi_perms_tx {
> +    uint32_t agent_id;
> +    uint32_t device_id;
> +    uint32_t flags;
> +} scmi_perms_tx_t;
> +
> +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
> +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
> +
> +#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
> +
> +struct scmi_shared_mem {
> +    uint32_t reserved;
> +    uint32_t channel_status;
> +    uint32_t reserved1[2];
> +    uint32_t flags;
> +    uint32_t length;
> +    uint32_t msg_header;
> +    uint8_t msg_payload[];
> +};
> +
> +struct scmi_channel {
> +    int chan_id;
> +    int agent_id;
> +    uint32_t func_id;
> +    int domain_id;
> +    uint64_t paddr;
> +    struct scmi_shared_mem *shmem;
> +    spinlock_t lock;
> +    struct list_head list;
> +};
> +
> +struct scmi_data {
> +    struct list_head channel_list;
> +    spinlock_t channel_list_lock;
> +    bool initialized;
> +    u64 shmem_addr, shmem_size;
> +};
> +
> +static struct scmi_data scmi_data;
> +
> +/*
> + * pack_scmi_header() - packs and returns 32-bit header
> + *
> + * @hdr: pointer to header containing all the information on message id,
> + *    protocol id and type id.
> + *
> + * Return: 32-bit packed message header to be sent to the platform.
> + */
> +static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
> +{
> +    return FIELD_PREP(HDR_ID, hdr->id) |
> +        FIELD_PREP(HDR_TYPE, hdr->type) |
> +        FIELD_PREP(HDR_PROTO, hdr->protocol);
> +}
> +
> +/*
> + * unpack_scmi_header() - unpacks and records message and protocol id
> + *
> + * @msg_hdr: 32-bit packed message header sent from the platform
> + * @hdr: pointer to header to fetch message and protocol id.
> + */
> +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t *hdr)
> +{
> +    hdr->id = FIELD_GET(HDR_ID, msg_hdr);
> +    hdr->type = FIELD_GET(HDR_TYPE, msg_hdr);
> +    hdr->protocol = FIELD_GET(HDR_PROTO, msg_hdr);
> +}
> +
> +static inline int channel_is_free(struct scmi_channel *chan_info)
> +{
> +    return ( chan_info->shmem->channel_status
> +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
> +}
> +
> +static int send_smc_message(struct scmi_channel *chan_info,
> +                            scmi_msg_header_t *hdr, void *data, int len)
> +{
> +    struct arm_smccc_res resp;
> +    int ret;
> +
> +    printk(XENLOG_DEBUG "scmi: status =%d len=%d\n",
> +           chan_info->shmem->channel_status, len);
> +    printk(XENLOG_DEBUG "scmi: header id = %d type = %d, proto = %d\n",
> +           hdr->id, hdr->type, hdr->protocol);
> +
> +    ret = channel_is_free(chan_info);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    chan_info->shmem->channel_status = 0x0;
> +    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be set */
> +    chan_info->shmem->flags = 0x0;
> +    chan_info->shmem->length = sizeof(chan_info->shmem->msg_header) + len;
> +    chan_info->shmem->msg_header = pack_scmi_header(hdr);
> +
> +    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
> +           chan_info->shmem);
> +    if ( len > 0 && data )
> +        memcpy((void *)(chan_info->shmem->msg_payload), data, len);
> +
> +    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->chan_id,
> +                  &resp);
> +
> +    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a0));
> +
> +    if ( resp.a0 )
> +        return -EOPNOTSUPP;
> +
> +    return 0;
> +}
> +
> +static int check_scmi_status(int scmi_status)
> +{
> +    if ( scmi_status == SCMI_SUCCESS )
> +        return 0;
> +
> +    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
> +
> +    switch ( scmi_status )
> +    {
> +    case SCMI_NOT_SUPPORTED:
> +        return -EOPNOTSUPP;
> +    case SCMI_INVALID_PARAMETERS:
> +        return -EINVAL;
> +    case SCMI_DENIED:
> +        return -EACCES;
> +    case SCMI_NOT_FOUND:
> +        return -ENOENT;
> +    case SCMI_OUT_OF_RANGE:
> +        return -ERANGE;
> +    case SCMI_BUSY:
> +        return -EBUSY;
> +    case SCMI_COMMS_ERROR:
> +        return -ENOTCONN;
> +    case SCMI_GENERIC_ERROR:
> +        return -EIO;
> +    case SCMI_HARDWARE_ERROR:
> +        return -ENXIO;
> +    case SCMI_PROTOCOL_ERROR:
> +        return -EBADMSG;

Probably we should add a default: here?


> +    }
> +
> +    return -EINVAL;
> +}
> +
> +static int get_smc_response(struct scmi_channel *chan_info,
> +                            scmi_msg_header_t *hdr, void *data, int len)
> +{
> +    int recv_len;
> +    int ret;
> +
> +    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
> +
> +    ret = channel_is_free(chan_info);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    recv_len = chan_info->shmem->length - sizeof(chan_info->shmem->msg_header);
> +
> +    if ( recv_len < 0 )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Wrong size of smc message. Data may be invalid\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( recv_len > len )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Not enough buffer for message %d, expecting %d\n",
> +               recv_len, len);
> +        return -EINVAL;
> +    }
> +
> +    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
> +
> +    if ( recv_len > 0 )
> +    {
> +        memcpy(data, chan_info->shmem->msg_payload, recv_len);
> +    }
> +
> +    return 0;
> +}
> +
> +static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t *hdr, void *tx_data, int tx_size,
> +                       void *rx_data, int rx_size)
> +{
> +    int ret = 0;
> +
> +    if ( !hdr )
> +        return -EINVAL;
> +
> +    spin_lock(&channel->lock);
> +
> +    ret = send_smc_message(channel, hdr, tx_data, tx_size);
> +    if ( ret )
> +        goto clean;
> +
> +    ret = get_smc_response(channel, hdr, rx_data, rx_size);
> +clean:
> +    spin_unlock(&channel->lock);
> +
> +    return ret;
> +}
> +
> +static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> +        if ( curr->chan_id == chan_id )
> +        {
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static struct scmi_channel *get_channel_by_domain(uint8_t domain_id)
> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> +        if ( curr->domain_id == domain_id )
> +        {
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static struct scmi_channel *aquire_scmi_channel(int domain_id)
> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    ASSERT(domain_id != DOMID_INVALID && domain_id >= 0);
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> +        if ( (curr->domain_id == DOMID_INVALID)
> +            && (curr->chan_id != HYP_CHANNEL) )
> +        {
> +            curr->domain_id = domain_id;
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static void relinquish_scmi_channel(struct scmi_channel *channel)
> +{
> +    spin_lock(&scmi_data.channel_list_lock);
> +    ASSERT(channel != NULL);
> +    channel->domain_id = DOMID_INVALID;
> +    spin_unlock(&scmi_data.channel_list_lock);
> +}
> +
> +static struct scmi_channel *smc_create_channel(uint8_t chan_id,
> +                                               uint32_t func_id, uint64_t addr)
> +{
> +    struct scmi_channel *channel;
> +    mfn_t mfn;
> +
> +    channel = get_channel_by_id(chan_id);
> +    if ( channel )
> +        return ERR_PTR(EEXIST);
> +
> +    channel = xmalloc(struct scmi_channel);
> +    if ( !channel )
> +        return ERR_PTR(ENOMEM);
> +
> +    channel->chan_id = chan_id;
> +    channel->func_id = func_id;
> +    channel->domain_id = DOMID_INVALID;
> +    mfn = maddr_to_mfn(addr);
> +    channel->shmem = vmap(&mfn, 1);
> +    if ( !channel->shmem )
> +    {
> +        xfree(channel);
> +        return ERR_PTR(ENOMEM);
> +    }
> +
> +    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->shmem);
> +    channel->paddr = addr;
> +    channel->shmem->channel_status = SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE;
> +    spin_lock_init(&channel->lock);
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_add(&channel->list, &scmi_data.channel_list);
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    return channel;
> +}
> +
> +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
> +{
> +    return iomem_permit_access(d, paddr_to_pfn(addr),
> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> +}
> +
> +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
> +                                     uint64_t len)
> +{
> +    return iomem_deny_access(d, paddr_to_pfn(addr),
> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> +}

I wonder, why we need an extra level of indirection here. And if this is 
really needed, I wonder why map(unmap)_memory* name was chosen, as there 
is no memory mapping/unmapping really happens here.


> +
> +static int dt_update_domain_range(struct domain *d, uint64_t addr,
> +                                  uint64_t size)

Looks like *d is not used in this function.


> +{
> +    struct dt_device_node *shmem_node;
> +    __be32 *hw_reg;
> +    const struct dt_property *pp;
> +    uint32_t len;
> +
> +    shmem_node = dt_find_compatible_node(NULL, NULL, "arm,scmi-shmem");
> +
> +    if ( !shmem_node )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI_SHMEM);
> +        return -EINVAL;
> +    }
> +
> +    pp = dt_find_property(shmem_node, "reg", &len);
> +    if ( !pp )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem node\n");
> +        return -ENOENT;
> +    }
> +
> +    hw_reg = pp->value;
> +    dt_set_range(&hw_reg, shmem_node, addr, size);
> +
> +    return 0;
> +}
> +
> +static void free_channel_list(void)
> +{
> +    struct scmi_channel *curr, *_curr;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, list)
> +    {
> +        vunmap(curr->shmem);
> +        list_del(&curr->list);
> +        xfree(curr);
> +    }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +}
> +
> +static __init bool scmi_probe(struct dt_device_node *scmi_node)


Generic question to consider ...
If probe fails for some reason (so we cannot use mediator in Xen) what 
should we do with SCMI nodes in domain's device-tree (leave as is, drop, 
etc)?


> +{
> +    struct dt_device_node *shmem_node;
> +    int ret, i;
> +    struct scmi_channel *channel, *agent_channel;
> +    int n_agents;
> +    scmi_msg_header_t hdr;
> +    struct rx_t {
> +        int32_t status;
> +        uint32_t attributes;
> +    } rx;
> +
> +    uint32_t func_id;
> +
> +    ASSERT(scmi_node != NULL);
> +
> +    INIT_LIST_HEAD(&scmi_data.channel_list);
> +    spin_lock_init(&scmi_data.channel_list_lock);
> +
> +    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
> +        return false;
> +    }
> +
> +    shmem_node = dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);
> +    if ( IS_ERR_OR_NULL(shmem_node) )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Device tree error, can't parse shmem phandle %ld\n",
> +               PTR_ERR(shmem_node));
> +        return false;
> +    }
> +
> +    ret = dt_device_get_address(shmem_node, 0, &scmi_data.shmem_addr,
> +                                &scmi_data.shmem_size);
> +    if ( IS_ERR_VALUE(ret) )
> +        return false;
> +
> +    channel = smc_create_channel(HYP_CHANNEL, func_id, scmi_data.shmem_addr);
> +    if ( IS_ERR(channel) )
> +        return false;
> +
> +    hdr.id = SCMI_BASE_PROTOCOL_ATTIBUTES;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    ret = do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
> +    if ( ret )
> +        goto clean;
> +
> +    ret = check_scmi_status(rx.status);
> +    if ( ret )
> +        goto clean;
> +
> +    n_agents = FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
> +    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
> +
> +    n_agents = (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
> +        scmi_data.shmem_size / PAGE_SIZE : n_agents;
> +
> +    for ( i = 1; i < n_agents; i++ )
> +    {
> +        uint32_t tx_agent_id = 0xFFFFFFFF;
> +        struct {
> +            int32_t status;
> +            uint32_t agent_id;
> +            char name[16];
> +        } da_rx;
> +
> +        agent_channel = smc_create_channel(i, func_id, scmi_data.shmem_addr +
> +                                           i * PAGE_SIZE);
> +        if ( IS_ERR(agent_channel) )
> +        {
> +            ret = PTR_ERR(agent_channel);
> +            goto clean;
> +        }
> +
> +        hdr.id = SCMI_BASE_DISCOVER_AGENT;
> +        hdr.type = 0;
> +        hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +        ret = do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
> +                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
> +        if ( ret )
> +            goto clean;
> +
> +        ret = check_scmi_status(da_rx.status);
> +        if ( ret )
> +            goto clean;
> +
> +        printk(XENLOG_DEBUG "scmi: status=0x%x id=0x%x name=%s\n",
> +                da_rx.status, da_rx.agent_id, da_rx.name);
> +
> +        agent_channel->agent_id = da_rx.agent_id;
> +    }
> +
> +    scmi_data.initialized = true;
> +    return true;
> +
> +clean:
> +    free_channel_list();
> +    return ret == 0;
> +}
> +
> +static int scmi_domain_init(struct domain *d)
> +{
> +    struct scmi_channel *channel;
> +    int ret;
> +
> +    if ( !scmi_data.initialized )
> +        return 0;
> +
> +    channel = aquire_scmi_channel(d->domain_id);
> +    if ( IS_ERR_OR_NULL(channel) )
> +        return -ENOENT;
> +
> +    printk(XENLOG_INFO "scmi: Aquire SCMI channel id = 0x%x , domain_id = %d"
> +           "paddr = 0x%lx\n", channel->chan_id, channel->domain_id,
> +           channel->paddr);


It seems this breaks build on Arm32:

scmi_smc.c: In function ‘scmi_domain_init’:
/home/otyshchenko/xen/xen/include/xen/config.h:53:24: error: format 
‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has 
type ‘uint64_t {aka long long unsigned int}’ [-Werror=format=]
  #define XENLOG_INFO    "<2>"
                         ^
scmi_smc.c:569:12: note: in expansion of macro ‘XENLOG_INFO’
      printk(XENLOG_INFO "scmi: Aquire SCMI channel id = 0x%x , 
domain_id = %d"
             ^~~~~~~~~~~
scmi_smc.c:570:25: note: format string is defined here
             "paddr = 0x%lx\n", channel->chan_id, channel->domain_id,
                        ~~^
                        %llx



> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        ret = map_memory_to_domain(d, scmi_data.shmem_addr,
> +                                   scmi_data.shmem_size);
> +        if ( IS_ERR_VALUE(ret) )
> +            goto error;
> +
> +        ret = dt_update_domain_range(d, channel->paddr, PAGE_SIZE);
> +        if ( IS_ERR_VALUE(ret) )
> +        {
> +            int rc = unmap_memory_from_domain(d, scmi_data.shmem_addr,
> +                                              scmi_data.shmem_size);
> +            if ( rc )
> +                printk(XENLOG_ERR "Unable to unmap_memory_from_domain\n");
> +
> +            goto error;
> +        }
> +    }
> +
> +    d->arch.sci = channel;
> +
> +    return 0;
> +error:
> +    relinquish_scmi_channel(channel);
> +
> +    return ret;
> +}
> +
> +static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_devid)
> +{
> +    struct scmi_channel *channel, *agent_channel;
> +    scmi_msg_header_t hdr;
> +    scmi_perms_tx_t tx;
> +    struct rx_t {
> +        int32_t status;
> +        uint32_t attributes;
> +    } rx;
> +    int ret;
> +
> +    if ( !scmi_data.initialized )
> +        return 0;
> +
> +    printk(XENLOG_DEBUG "scmi: scmi_devid = %d\n", scmi_devid);
> +
> +    agent_channel = get_channel_by_domain(d->domain_id);
> +    if ( IS_ERR_OR_NULL(agent_channel) )
> +        return PTR_ERR(agent_channel);
> +
> +    channel = get_channel_by_id(HYP_CHANNEL);
> +    if ( IS_ERR_OR_NULL(channel) )
> +        return PTR_ERR(channel);
> +
> +    hdr.id = SCMI_BASE_SET_DEVICE_PERMISSIONS;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    tx.agent_id = agent_channel->agent_id;
> +    tx.device_id = scmi_devid;
> +    tx.flags = SCMI_ALLOW_ACCESS;
> +
> +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&rx));
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    ret = check_scmi_status(rx.status);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    return 0;
> +}
> +
> +static int scmi_add_dt_device(struct domain *d, struct dt_device_node *dev)
> +{
> +    uint32_t scmi_devid;
> +
> +    if ( (!scmi_data.initialized) || (!d->arch.sci) )
> +        return 0;
> +
> +    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
> +        return 0;
> +
> +    printk(XENLOG_INFO "scmi: dt_node = %s\n", dt_node_full_name(dev));
> +
> +    return scmi_add_device_by_devid(d, scmi_devid);
> +}
> +
> +static int scmi_relinquish_resources(struct domain *d)
> +{
> +    int ret;
> +    struct scmi_channel *channel, *agent_channel;
> +    scmi_msg_header_t hdr;
> +    struct reset_agent_tx {
> +        uint32_t agent_id;
> +        uint32_t flags;
> +    } tx;
> +    uint32_t rx;
> +
> +    if ( !d->arch.sci )
> +        return 0;
> +
> +    agent_channel = d->arch.sci;
> +
> +    spin_lock(&agent_channel->lock);
> +    tx.agent_id = agent_channel->agent_id;
> +    spin_unlock(&agent_channel->lock);
> +
> +    channel = get_channel_by_id(HYP_CHANNEL);
> +    if ( !channel )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Unable to get Hypervisor scmi channel for domain %d\n",
> +               d->domain_id);
> +        return -EINVAL;
> +    }
> +
> +    hdr.id = SCMI_BASE_RESET_AGENT_CONFIGURATION;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    tx.flags = 0;
> +
> +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx));
> +    if ( ret )
> +        return ret;
> +
> +    ret = check_scmi_status(rx);
> +
> +    return ret;
> +}
> +
> +static void scmi_domain_destroy(struct domain *d)
> +{
> +    struct scmi_channel *channel;
> +
> +    if ( !d->arch.sci )
> +        return;
> +
> +    channel = d->arch.sci;
> +    spin_lock(&channel->lock);
> +
> +    relinquish_scmi_channel(channel);
> +    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
> +
> +    d->arch.sci = NULL;
> +
> +    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
I didn't manage to find where corresponding map_memory_from_domain() is 
called for a non-hardware domain (it seems that scmi_domain_init() only 
directly handles hardware domain case).
Or perhaps, it is called indirectly at do_domctl(): case 
XEN_DOMCTL_iomem_permission:?


I wonder, do we really need to call this here? Taking into the account 
that unmap_memory_from_domain() doesn't actually unmap anything, but 
only removes a range from the iomem_caps rangeset
for the domain to be destroyed and all involved rangesets (including 
iomem_caps) will be removed soon at rangeset_domain_destroy() anyway. Or 
I missed something?


> +    spin_unlock(&channel->lock);
> +    return;

empty return could be dropped, I think.


> +}
> +
> +static bool scmi_handle_call(struct domain *d, void *args)
> +{
> +    bool res = false;
> +    struct scmi_channel *agent_channel;
> +    struct arm_smccc_res resp;
> +    struct cpu_user_regs *regs = args;
> +
> +    if ( !d->arch.sci )
> +        return false;
> +
> +    agent_channel = d->arch.sci;
> +    spin_lock(&agent_channel->lock);
> +
> +    if ( agent_channel->func_id != regs->x0 )

This also breaks build on Arm32:

scmi_smc.c: In function ‘scmi_handle_call’:
scmi_smc.c:736:42: error: ‘struct cpu_user_regs’ has no member named 
‘x0’; did you mean ‘r0’?
      if ( agent_channel->func_id != regs->x0 )
                                           ^~
                                           r0
cc1: all warnings being treated as errors

***

BTW, I noticed that xen/arch/arm/traps.c contains the following 
construct, probably we might want something similar here?

#ifdef CONFIG_ARM_64
#define HYPERCALL_RESULT_REG(r) (r)->x0
[snip]
#else
#define HYPERCALL_RESULT_REG(r) (r)->r0
[snip]
#endif


This RFC patch series, so I think, there is no serious issues at the 
moment, this is rather to let you know for the future (when you drop RFC 
tag).
I have to admit, I often forget to build-test on Arm32 also))


> +    {
> +        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
> +        goto unlock;
> +    }
> +
> +    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
> +                  agent_channel->chan_id, &resp);
> +
> +    set_user_reg(regs, 0, resp.a0);
> +    set_user_reg(regs, 1, resp.a1);
> +    set_user_reg(regs, 2, resp.a2);
> +    set_user_reg(regs, 3, resp.a3);
> +    res = true;
> +unlock:
> +    spin_unlock(&agent_channel->lock);
> +
> +    return res;
> +}
> +
> +static int scmi_get_channel_paddr(void *scmi_ops,
> +                           struct xen_arch_domainconfig *config)
> +{
> +    struct scmi_channel *agent_channel = scmi_ops;
> +
> +    if ( !agent_channel )
> +        return -EINVAL;
> +
> +    config->sci_agent_paddr = agent_channel->paddr;
> +    return 0;
> +}
> +
> +static const struct dt_device_match scmi_smc_match[] __initconst =
> +{
> +    DT_MATCH_SCMI_SMC,
> +    { /* sentinel */ },
> +};
> +
> +static const struct sci_mediator_ops scmi_ops =
> +{
> +    .probe = scmi_probe,
> +    .domain_init = scmi_domain_init,
> +    .domain_destroy = scmi_domain_destroy,
> +    .add_dt_device = scmi_add_dt_device,
> +    .relinquish_resources = scmi_relinquish_resources,
> +    .handle_call = scmi_handle_call,
> +    .get_channel_info = scmi_get_channel_paddr
> +};
> +
> +REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_SCMI_SMC,
> +                      scmi_smc_match, &scmi_ops);
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 9180be5e86..a67237942d 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>   #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>   
>   #define XEN_DOMCTL_CONFIG_SCI_NONE      0
> +#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
>   
>   struct xen_arch_domainconfig {
>       /* IN/OUT */

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:46:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:46:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248572.428750 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBh3-0008GO-M4; Fri, 17 Dec 2021 11:46:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248572.428750; Fri, 17 Dec 2021 11:46:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBh3-0008GH-IU; Fri, 17 Dec 2021 11:46:33 +0000
Received: by outflank-mailman (input) for mailman id 248572;
 Fri, 17 Dec 2021 11:46:32 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myBh2-0008G7-BT; Fri, 17 Dec 2021 11:46:32 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myBh2-0001tj-9j; Fri, 17 Dec 2021 11:46:32 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myBh1-0003Ug-WE; Fri, 17 Dec 2021 11:46:32 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myBh1-0006in-Vq; Fri, 17 Dec 2021 11:46:31 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zixDi5Y/4wuJSp1Qj9j1sLmNtiFv5sHhg9qksECTnAw=; b=SeV17IsysLlkUORY1KjMAY4DQN
	JjZtYUE5Kkmrqjk6MwRGk3ldf+wGgB2HV3Gy2IaEA2DgoTMdblkS3Hx4IzbcJKTuAW2g/vfI1lDGQ
	c/9PH5dMCHpneac3VNXuLE/6p5zAXnZQPz4rxHB7aQtQVWuHMwgDQZzNuKg/OJozqPYk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167458-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167458: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=1c4589280ae4e9ba34266e674459fffd6f0282dc
X-Osstest-Versions-That:
    xen=f3999bc2e099c571e4583bff8f494b834b2f5f76
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 11:46:31 +0000

flight 167458 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167458/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  1c4589280ae4e9ba34266e674459fffd6f0282dc
baseline version:
 xen                  f3999bc2e099c571e4583bff8f494b834b2f5f76

Last test of basis   167456  2021-12-17 03:02:55 Z    0 days
Testing same since   167458  2021-12-17 08:01:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   f3999bc2e0..1c4589280a  1c4589280ae4e9ba34266e674459fffd6f0282dc -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 11:53:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 11:53:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248581.428761 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBnN-0001SI-DY; Fri, 17 Dec 2021 11:53:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248581.428761; Fri, 17 Dec 2021 11:53:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myBnN-0001SB-9s; Fri, 17 Dec 2021 11:53:05 +0000
Received: by outflank-mailman (input) for mailman id 248581;
 Fri, 17 Dec 2021 11:53:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Cq30=RC=arm.com=michal.orzel@srs-se1.protection.inumbo.net>)
 id 1myBnL-0001S5-BA
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 11:53:03 +0000
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTP
 id e2787f47-5f2f-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 12:53:01 +0100 (CET)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8661A1435;
 Fri, 17 Dec 2021 03:53:00 -0800 (PST)
Received: from [10.57.7.107] (unknown [10.57.7.107])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 516403F5A1;
 Fri, 17 Dec 2021 03:52:59 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2787f47-5f2f-11ec-9e60-abaf8a552007
Subject: Re: [PATCH v3] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211217072159.3464-1-michal.orzel@arm.com>
 <48666542-6647-d1ec-78df-2fbb43efcc0d@xen.org>
From: Michal Orzel <michal.orzel@arm.com>
Message-ID: <f05fadce-3d7b-9564-0865-de683c0baaa8@arm.com>
Date: Fri, 17 Dec 2021 12:52:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <48666542-6647-d1ec-78df-2fbb43efcc0d@xen.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Julien,

On 17.12.2021 11:01, Julien Grall wrote:
> Hi,
> 
> On 17/12/2021 07:21, Michal Orzel wrote:
>> to hypervisor when switching from AArch32 state.
>>
>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>> "If the general-purpose register was accessible from AArch32 state the
>> upper 32 bits either become zero, or hold the value that the same
>> architectural register held before any AArch32 execution.
>> The choice between these two options is IMPLEMENTATION DEFINED"
>>
>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>> needs to be fixed. The reason why is that there are places in Xen
>> where we assume that top 32bits are zero for AArch32 guests.
>> If they are not, this can lead to misinterpretation of Xen regarding
>> what the guest requested. For example hypercalls returning an error
>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>> would return -ENOSYS if the command passed as the first argument was
>> clobbered.
>>
>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>> Add a compile time check to ensure that save_x0_x1 == 1 if
>> compat == 1.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>> ---
>> Changes since v2:
>> -add clobbering of w30
>> Changes since v1:
>> -put new code into macro
>> -add compile time check for save_x0_x1
>> ---
>>   xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>
>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>> index fc3811ad0a..e351ef8639 100644
>> --- a/xen/arch/arm/arm64/entry.S
>> +++ b/xen/arch/arm/arm64/entry.S
>> @@ -102,6 +102,30 @@
>>           .endif
>>             .endm
>> +
>> +/*
>> + * Clobber top 32 bits of gp registers when switching from AArch32
>> + */
>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>> +
>> +        .if \compat == 1      /* AArch32 mode */
>> +
>> +        /*
>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>> +         * Add a compile time check to avoid violating this rule.
>> +         */
> 
> We may want in the future to allow save_x0_x1 == 1 with compat == 1 if we need to create fastpath like we did when entering AArch64.
> 
> So I would reword the comment to make clear this is an implementation decision. How about:
> 
> "At the moment, no-one is using save_x0_x1 == 0 with compat == 1. So the code is not handling it to simplify the implementation."
> 
> If you are happy with the new comment, I can update it on commit:
> 
Please do. The comment looks ok.

> Acked-by: Julien Grall <jgrall@amazon.com>
> 
> Cheers,
> 

Cheers,
Michal


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:10:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:10:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248590.428776 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myC42-0004Ez-Qg; Fri, 17 Dec 2021 12:10:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248590.428776; Fri, 17 Dec 2021 12:10:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myC42-0004Er-Ms; Fri, 17 Dec 2021 12:10:18 +0000
Received: by outflank-mailman (input) for mailman id 248590;
 Fri, 17 Dec 2021 12:10:18 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myC42-0004Ei-D0; Fri, 17 Dec 2021 12:10:18 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myC42-0002KP-5S; Fri, 17 Dec 2021 12:10:18 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myC41-0004M6-Sh; Fri, 17 Dec 2021 12:10:17 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myC41-0001F0-SF; Fri, 17 Dec 2021 12:10:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WNJuoyhlkP6iZBlh9iSgimg/TI5lT+2nH+q21fHeHcE=; b=pjzdZFEfWxPxAuHGXGByyb/K28
	NI4PgMmlhVh6FAcQuoLAemi0kZfRQ3pete7xutsWQXYL8OjNlyrB6qC2YTtAe4Ax5oEdGbO1joFUk
	rXN1AckJznMFwlHdcphlp6A3I9uAt65hTPnPO0eYNIiqKZmu5NxPR9p4+547E5YKrWpQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167457-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167457: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=e4e873e9b653f4b8aa8c2ed64ce2d607e619e93d
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 12:10:17 +0000

flight 167457 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167457/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              e4e873e9b653f4b8aa8c2ed64ce2d607e619e93d
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  525 days
Failing since        151818  2020-07-11 04:18:52 Z  524 days  506 attempts
Testing same since   167457  2021-12-17 04:18:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 89844 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:15:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:15:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248598.428787 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myC9C-0004tW-Eq; Fri, 17 Dec 2021 12:15:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248598.428787; Fri, 17 Dec 2021 12:15:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myC9C-0004tP-Bp; Fri, 17 Dec 2021 12:15:38 +0000
Received: by outflank-mailman (input) for mailman id 248598;
 Fri, 17 Dec 2021 12:15:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myC9B-0004tJ-1o
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 12:15:37 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0888efbb-5f33-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 13:15:34 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHBvvul011488;
 Fri, 17 Dec 2021 12:15:29 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d0t3g82ee-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 12:15:28 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6733.eurprd03.prod.outlook.com (2603:10a6:102:f3::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec
 2021 12:15:25 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 12:15:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0888efbb-5f33-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WxJexuFKq/n5bcPuwKwmfwu0DyEW/9lZD1HB/FK6Rj3WPXdb9tiLd+2wNC37tvu+6YV8RcWAHbaSBC8RypeKFFDrW3AgqCVhqMC9J2qqMacJ/H/mBcwNuwwwCURkADSJfqUFtUWQUkIYzKEWEWw/Fwu51lWV8JhBw5nGEQt984cLvZ12O+9vXoz/hTGMgajrFZhQsV50PVmcb1n4lRHU4cr4xb1ZE5dQ9cs9l5s9eoc9ta4WlI7juaS+uE8Uu5eiwGT7vzomairAw7h18Ljp4yf6n6QKjeFPdoXZ3iThfBYgbleiabUJfYr8+BCduZVKuFo7w0Yv5bdRJWHWiOUODg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2W5m6cbG7JZpPykxLDKpaDOPGPQ+cc6ARQ0iZvLeMvg=;
 b=iqTim7/bvvp1YPFxpqeRjrl9gFFAflIt9qEvPjaBfl7p5N+IZnbwxN87S24iHWFza9pX7wxIdXzHf7npuqNmz1zyGJHDUy4peC1GoLlFnJQPCMzrRL/uL/oWhgwkeqVBruZ8U8zu4TZSb7Ox11C7enmNGUzzKjr4V5YvtfVGp8Ml3HTrWkPRGvCr7kTIgk9021rV8nW2gGDvm+6T0FRJtVX6QYU21MsGxJexvLoMgy6GoTpIBQleCt9PcM+64jveaA1832bUKR4XvsClDAp4WiF/n2xjCJt+mWhhG1khMtdYJ6e2IprSy17oiu8AcvHKrR7eZnfOfv06v3JRkgxhsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2W5m6cbG7JZpPykxLDKpaDOPGPQ+cc6ARQ0iZvLeMvg=;
 b=SD7kQ0Sfes0qrkJvvtK/C+I9KiiiBPb+9ge/za202V20iBZ4bLEOrNwMhC30X3ZDGAtGab9/RGilnAWkV56llld6prO5bOU5iHEWEoCieWzjzZZFX5zbaxk+U+tYqXVmPBB9lngelPk9AZAohe5MYHa1ZYj7E0phP1KvrHU+dfbydurSJlwHxrndHlx8QnbfYO1RciH1PG3D79/uI17pjS7dFYRUt4k81Uj4reWdXGf/y/JlE0KXJc9RpBzszgU8jMuh6jd3CaWBkZ/4L3Jb2e+43pwcRRhTp6kJa0FOk5g30OvCtZaabrxXgTz17z/zJTVLVHGe6FpmAYzCmfckdg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Anthony PERARD
	<anthony.perard@citrix.com>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qw0P2iAgAJehQA=
Date: Fri, 17 Dec 2021 12:15:25 +0000
Message-ID: <20211217121524.GA4021162@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
In-Reply-To: <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 95e8ebfb-a938-4692-71d1-08d9c156e811
x-ms-traffictypediagnostic: PA4PR03MB6733:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB673378BFA6E7BD3F8337E899E3789@PA4PR03MB6733.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2043;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 O+H3y0rS1bW8eElNL8opLTbBPzddME0a9K2r1WoQdDDNMFriWZMBlR3/pzqBuTiCQgLkQWa9dCFrnZIovYlyynei1p9CRqcOPjljRmpM4fpeKflRgQBcGaZXkZk8mx34j0IgD0qcGofdRwa0zHXNH+xs0TYwt22EWwpFNLJ4OWIvU7fa3NCLrudJswHc9et+SyKvXeAJM51P5ma5qCSISEbdZLAVSJbHTu2u0cdbmtbaQQuM0Shahx0okFM7tSWqzL25JGJ7rkiP6sLvE/1ZeC2GeaGZxdWb//F3UCvwTzh2uDus+UeMEwnLupmRg4Me88VW6XvYCkWm2CsAHe7cx0ACSj61M54vJ0kpIcbMjbHcssnmMhZqHKe4LVXDG+XjzAT7mfkZtds1V6QHExb7EL0k5J4PPpc8fpg2neRrcHjapP5H4LORXVbv4ma6N65w9mOhPnWtKTuzHkTwst6XgLB3v7YnO8EfGbnbDkPD1XBhchTbsmhmZrtIEVSlonUqoYgZhdvDV+iaESocXY25vRgmeXvovg3hGEkH08AAP8jmYWHMBGLizpzQFkIQquihdS4EkrJoVaqJFwGchHyGpv288S+ITjrG8TCnVqVfYukq3IEiwJjW/K1SkFOMxuhvKbuL54U2dNfqVQdh9WXzEjiwk0fqh/2V8bP+5JpwfpR/g3d9Nk0Aq3phdboY4p0r9FBvVEvPavSiJFumRUzoXw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(38070700005)(8936002)(4326008)(33656002)(9686003)(38100700002)(86362001)(54906003)(6512007)(7416002)(122000001)(186003)(316002)(71200400001)(76116006)(8676002)(6506007)(1076003)(5660300002)(64756008)(66946007)(2906002)(91956017)(66476007)(6486002)(33716001)(6916009)(83380400001)(53546011)(508600001)(26005)(30864003)(66446008)(66556008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?7+wDrgxjk06xxTosY56lrv0wAsAQDL9P9iAChm/fWgDjJhwVOwP++HgIXb?=
 =?iso-8859-1?Q?Unqsebl8GRKtqFhqMbOVKb1yRYO23kDBBbHKDWc3t5fFYPJ7ub4Kioovlh?=
 =?iso-8859-1?Q?gzyA79kvCao5FhcfHs4PwjFM97WhiPMPV5k0sPi8hkvg4JJ99L4PM4OxKz?=
 =?iso-8859-1?Q?+w4hMAZXug6dG3yLujXBKi7DULU7YEMSKZKcJ6W1fOdFUCeHXiL6tBUKNN?=
 =?iso-8859-1?Q?XECN2zmZ6oDb3tYBIdBuw34QiWTtq3Jg9hZaESdvsT5DJT425ZLbVTvox/?=
 =?iso-8859-1?Q?i3EEHjnyIWP0of7HAPEiTHQPWkB8zvxtaqmIfNNJAqp6PchJIIqKhhaXm2?=
 =?iso-8859-1?Q?tj9IcnfcEUe+HBdX0NYYoP0q43H+/TteK1EvatDSlpa2dMeI7MiBoCOS87?=
 =?iso-8859-1?Q?MqjIkXqI2M0Wq0jP3zs3waK2nqoam9dN44xVpRme5v0MSrzpnk+oU0yk5h?=
 =?iso-8859-1?Q?/eE/9Na81AdUdTtImvkNugR9y7+eF//ZV8SfQMjIgC3366klN/G09FdTlP?=
 =?iso-8859-1?Q?An3z4GU+Rikn177jkyiF0k7jyNn2hGUU9mkNlRli8eq4q7wxFATGzI/x9Z?=
 =?iso-8859-1?Q?x8TK41Egn0j/dppd/elxfskdAauT5Za77KxiDRG39cW8fNdMIZQkvgIinb?=
 =?iso-8859-1?Q?/RLeDEVw51huUCIOE3t+/2FY0qo45RuodFzyQbaU4EJputVjW2A9rJ0bnF?=
 =?iso-8859-1?Q?d7BYrVmwr6LM9z9JUvib96eXIEZre48COwS2DYpGNP04IToXwljF5W8vl5?=
 =?iso-8859-1?Q?iTA76inqsaoS38jKgqkC8IU2LGqflUUYeutCIrEkdwO/qNW/SQ1ji9H0Ac?=
 =?iso-8859-1?Q?rC/7oAxAa2j9B0Nt0+PDkOUg8VtPIEwPbBMLhFNTeey8QXUjbdqxNSf5KS?=
 =?iso-8859-1?Q?+zvu9+CEtHieAhYUDETgR3mA4fuWSv+xKPyqyG2vq4BCAXM/wDf1VCMixT?=
 =?iso-8859-1?Q?rObI4iJRONXVfl2AijiNsI6aQ1vwhD/pfHAuMf9JDlUX+PR12fXMs6UTmD?=
 =?iso-8859-1?Q?f2iWGVg9C4o1OI9TkRxGxpvTEjXI93dZc8JAQVPn1sQYSACGIJ25cHBOCe?=
 =?iso-8859-1?Q?aPggYCsRm4862OBrtNAfrUMhNZQD42qBMGznTJrA2oCfXwWDOx3Hlt+RSU?=
 =?iso-8859-1?Q?LlSqzCthd79ZD4zOZF7Hb3nTpNPzpxo3E91Kv9ljgT2dyWs0fvDGWy7yzV?=
 =?iso-8859-1?Q?9zpg9A6tOhtVGS7TEiGuKA6MqSxIK/avO9gur7Enj+/sJTHTse9eRTemDN?=
 =?iso-8859-1?Q?OWoGxYafwm4APU0Pz4Shh4RwwYjSXL2fcPhO/cgeXLzesNTBswDQudIFrV?=
 =?iso-8859-1?Q?EJCNC94/x0NL5VIZBIQCZyC3+G9+e8mrZIKyO5hORU7u0y5ghMJ5jfnRSm?=
 =?iso-8859-1?Q?gtzvXjm77KJ9d1cDocb4pp9qO+dACX0OUU4hCN5jFov8zbBnQQNDv4npZx?=
 =?iso-8859-1?Q?JMpg59EUcF8pUE98dXACjmqOfVa6pZ0M3ZEP8ind90spf6lP5ChQBOTMCL?=
 =?iso-8859-1?Q?HKRdXBc21Ucahd2M1oQvvZbM0hssSuRcvyXH6TOo8FAGsPseWEyYI/kqaU?=
 =?iso-8859-1?Q?nw8AKRhBdkm7wj+Us80NTe32k7vws/jJFNkTUa/j8zIzu6f/xDZh/dFyuQ?=
 =?iso-8859-1?Q?A0HUtRBq7nPEhmJoaVbsFExMhtWcEOcrdGdi9xGCMq01DmGIzJKaZXwSR/?=
 =?iso-8859-1?Q?J4h0l7gklx3qDg2XWrZGV/hfO2fSQXR0G0CJ95MCAqOz0e9SUEWYgdRgR6?=
 =?iso-8859-1?Q?a2DIL93V0Qkg/Xhfo5m6Zlwz8=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <3987041BFC93194F9F17E38D502FC10D@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95e8ebfb-a938-4692-71d1-08d9c156e811
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 12:15:25.3347
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ppnP+m9iW6OwMj36RhXciSW8haHp3TNv4rtfXCe9hfrH6vUkDOnnv/lwJ1A6J0rADppE4wlaz6/8w8iPeVDW9ZoVrV8sKYd4xkLqfs+dN7k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6733
X-Proofpoint-GUID: fyQkm6s4HX2Xyq0Tes4BycE7EuNe07r6
X-Proofpoint-ORIG-GUID: fyQkm6s4HX2Xyq0Tes4BycE7EuNe07r6
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0
 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999
 priorityscore=1501 bulkscore=0 lowpriorityscore=0 clxscore=1015
 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170071

Hi Oleksandr,

On Thu, Dec 16, 2021 at 02:04:35AM +0200, Oleksandr wrote:
>=20
> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>=20
> Hi Oleksii
>=20
> > Integration of the SCMI mediator with xen libs:
> > - add hypercalls to aquire SCI channel and set device permissions
> > for DomUs;
> > - add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
> > - SCI requests redirection from DomUs to Firmware.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >   tools/include/xenctrl.h           |   3 +
> >   tools/include/xenguest.h          |   2 +
> >   tools/libs/ctrl/xc_domain.c       |  23 ++++++
> >   tools/libs/guest/xg_dom_arm.c     |   5 +-
> >   tools/libs/light/libxl_arm.c      | 122 +++++++++++++++++++++++++++--=
-
> >   tools/libs/light/libxl_create.c   |  54 ++++++++++++-
> >   tools/libs/light/libxl_dom.c      |   1 +
> >   tools/libs/light/libxl_internal.h |   4 +
> >   xen/arch/arm/domctl.c             |  15 ++++
> >   xen/include/public/domctl.h       |   9 +++
> >   10 files changed, 223 insertions(+), 15 deletions(-)
> >=20
> > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > index 07b96e6671..cdd14f465f 100644
> > --- a/tools/include/xenctrl.h
> > +++ b/tools/include/xenctrl.h
> > @@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
> >   int xc_domain_soft_reset(xc_interface *xch,
> >                            uint32_t domid);
> > +int xc_domain_add_sci_device(xc_interface *xch,
> > +                              uint32_t domid, char *path);
> > +
> >   #if defined(__i386__) || defined(__x86_64__)
> >   /*
> >    * PC BIOS standard E820 types and structure.
> > diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h
> > index 61d0a82f48..35c611ac73 100644
> > --- a/tools/include/xenguest.h
> > +++ b/tools/include/xenguest.h
> > @@ -242,6 +242,8 @@ struct xc_dom_image {
> >       /* Number of vCPUs */
> >       unsigned int max_vcpus;
> > +
> > +    xen_pfn_t sci_shmem_gfn;
> >   };
> >   /* --- arch specific hooks ----------------------------------------- =
*/
> > diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> > index b155d6afd2..07bb390e17 100644
> > --- a/tools/libs/ctrl/xc_domain.c
> > +++ b/tools/libs/ctrl/xc_domain.c
> > @@ -2206,6 +2206,29 @@ int xc_domain_soft_reset(xc_interface *xch,
> >       domctl.domain =3D domid;
> >       return do_domctl(xch, &domctl);
> >   }
> > +
> > +int xc_domain_add_sci_device(xc_interface *xch,
> > +                              uint32_t domid, char *path)
> > +{
> > +    size_t size =3D strlen(path);
> > +    int rc;
> > +    DECLARE_DOMCTL;
> > +    DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN=
);
> > +
> > +    if ( xc_hypercall_bounce_pre(xch, path) )
> > +        return -1;
> > +
> > +    domctl.cmd =3D XEN_DOMCTL_add_sci_device;
> > +    domctl.domain =3D domid;
> > +    domctl.u.sci_device_op.size =3D size;
> > +    set_xen_guest_handle(domctl.u.sci_device_op.path, path);
> > +    rc =3D do_domctl(xch, &domctl);
> > +
> > +    xc_hypercall_bounce_post(xch, path);
> > +
> > +    return rc;
> > +}
> > +
> >   /*
> >    * Local variables:
> >    * mode: C
> > diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_ar=
m.c
> > index 5e3b76355e..368a670c46 100644
> > --- a/tools/libs/guest/xg_dom_arm.c
> > +++ b/tools/libs/guest/xg_dom_arm.c
> > @@ -25,11 +25,12 @@
> >   #include "xg_private.h"
> > -#define NR_MAGIC_PAGES 4
> > +#define NR_MAGIC_PAGES 5
> >   #define CONSOLE_PFN_OFFSET 0
> >   #define XENSTORE_PFN_OFFSET 1
> >   #define MEMACCESS_PFN_OFFSET 2
> >   #define VUART_PFN_OFFSET 3
> > +#define SCI_SHMEM_OFFSET 4
> >   #define LPAE_SHIFT 9
> > @@ -69,11 +70,13 @@ static int alloc_magic_pages(struct xc_dom_image *d=
om)
> >       dom->console_pfn =3D base + CONSOLE_PFN_OFFSET;
> >       dom->xenstore_pfn =3D base + XENSTORE_PFN_OFFSET;
> >       dom->vuart_gfn =3D base + VUART_PFN_OFFSET;
> > +    dom->sci_shmem_gfn =3D base + SCI_SHMEM_OFFSET;
> >       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn=
);
> >       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pf=
n);
> >       xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS=
_PFN_OFFSET);
> >       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn);
> > +    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->sci_shmem_gf=
n);
> >       xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PF=
N,
> >               dom->console_pfn);
> > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.=
c
> > index eef1de0939..73ef591822 100644
> > --- a/tools/libs/light/libxl_arm.c
> > +++ b/tools/libs/light/libxl_arm.c
> > @@ -8,6 +8,8 @@
> >   #include <assert.h>
> >   #include <xen/device_tree_defs.h>
> > +#define SCMI_NODE_PATH      "/firmware/scmi"
> > +
> >   static const char *gicv_to_string(libxl_gic_version gic_version)
> >   {
> >       switch (gic_version) {
> > @@ -101,6 +103,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *g=
c,
> >           return ERROR_FAIL;
> >       }
> > +    switch (d_config->b_info.sci) {
> > +    case LIBXL_SCI_TYPE_NONE:
> > +        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_NONE;
> > +        break;
> > +    case LIBXL_SCI_TYPE_SCMI_SMC:
> > +        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_SCMI_SMC;
> > +        break;
> > +    default:
> > +        LOG(ERROR, "Unknown SCI type %d",
> > +            d_config->b_info.sci);
> > +        return ERROR_FAIL;
> > +    }
> > +
> >       return 0;
> >   }
> > @@ -122,6 +137,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
> >       }
> >       state->clock_frequency =3D config->arch.clock_frequency;
> > +    state->sci_agent_paddr =3D config->arch.sci_agent_paddr;
> >       return 0;
> >   }
> > @@ -502,9 +518,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt=
)
> >       int res;
> >       LOG(DEBUG, "Creating OP-TEE node in dtb");
> > -    res =3D fdt_begin_node(fdt, "firmware");
> > -    if (res) return res;
> > -
> >       res =3D fdt_begin_node(fdt, "optee");
> >       if (res) return res;
> > @@ -517,9 +530,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt=
)
> >       res =3D fdt_end_node(fdt);
> >       if (res) return res;
> > -    res =3D fdt_end_node(fdt);
> > -    if (res) return res;
> > -
> >       return 0;
> >   }
> > @@ -902,10 +912,9 @@ static int copy_node(libxl__gc *gc, void *fdt, voi=
d *pfdt,
> >       return 0;
> >   }
> > -static int copy_node_by_path(libxl__gc *gc, const char *path,
> > -                             void *fdt, void *pfdt)
> > +static int get_path_nodeoff(const char *path, void *pfdt)
> >   {
> > -    int nodeoff, r;
> > +    int nodeoff;
> >       const char *name =3D strrchr(path, '/');
> >       if (!name)
> > @@ -925,12 +934,101 @@ static int copy_node_by_path(libxl__gc *gc, cons=
t char *path,
> >       if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
> >           return -FDT_ERR_NOTFOUND;
> > +    return nodeoff;
> > +}
> > +
> > +static int copy_node_by_path(libxl__gc *gc, const char *path,
> > +                             void *fdt, void *pfdt)
> > +{
> > +    int nodeoff, r;
> > +
> > +    nodeoff =3D get_path_nodeoff(path, pfdt);
> > +    if (nodeoff < 0)
> > +        return nodeoff;
> > +
> >       r =3D copy_node(gc, fdt, pfdt, nodeoff, 0);
> >       if (r) return r;
> >       return 0;
> >   }
> > +static int get_node_phandle(const char *path, void *pfdt, uint32_t *ph=
andle)
> > +{
> > +    int nodeoff;
> > +    const char *name =3D strrchr(path, '/');
> > +
> > +    if (!name)
> > +        return -FDT_ERR_INTERNAL;
> > +
> > +    name++;
> > +    nodeoff =3D fdt_path_offset(pfdt, path);
> > +    if (nodeoff < 0)
> > +        return nodeoff;
> > +
> > +    *phandle =3D fdt_get_phandle(pfdt, nodeoff);
> > +    return 0;
> > +}
> > +
> > +static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt,
> > +                           struct xc_dom_image *dom)
> > +{
> > +    int res;
> > +    char buf[64];
> > +    uint32_t phandle =3D 0;
> > +
> > +    res =3D get_node_phandle("/scp-shmem", pfdt, &phandle);
> > +    if (res) return res;
> > +
> > +    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
> > +             dom->sci_shmem_gfn << XC_PAGE_SHIFT);
> > +    res =3D fdt_begin_node(fdt, buf);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_compat(gc, fdt, 1, "arm,scmi-shmem");
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > +                    GUEST_ROOT_SIZE_CELLS, 1,
> > +                    dom->sci_shmem_gfn << XC_PAGE_SHIFT, XC_PAGE_SHIFT=
);
> > +    if (res) return res;
> > +
> > +    LOG(DEBUG, "scmi: setting phandle =3D %u\n", phandle);
> > +    res =3D fdt_property_cell(fdt, "phandle", phandle);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_end_node(fdt);
> > +    if (res) return res;
> > +
> > +    return 0;
> > +}
> > +
> > +static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, in=
t tee,
> > +                              int sci)
> > +{
> > +    int res;
> > +
> > +    if ((tee !=3D LIBXL_TEE_TYPE_OPTEE) && (sci !=3D LIBXL_SCI_TYPE_NO=
NE))
> > +        return 0;
> > +
> > +    res =3D fdt_begin_node(fdt, "firmware");
> > +    if (res) return res;
> > +
> > +    if (tee =3D=3D LIBXL_TEE_TYPE_OPTEE) {
> > +       res =3D make_optee_node(gc, fdt);
> > +       if (res) return res;
> > +    }
> > +
> > +    if (sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC) {
> > +        res =3D copy_node_by_path(gc, SCMI_NODE_PATH, fdt, pfdt);
> > +        if (res) return res;
> > +    }
> > +
> > +    res =3D fdt_end_node(fdt);
> > +    if (res) return res;
> > +
> > +    return 0;
> > +}
> > +
> >   /*
> >    * The partial device tree is not copied entirely. Only the relevant =
bits are
> >    * copied to the guest device tree:
> > @@ -1088,8 +1186,10 @@ next_resize:
> >           if (info->arch_arm.vuart =3D=3D LIBXL_VUART_TYPE_SBSA_UART)
> >               FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
> > -        if (info->tee =3D=3D LIBXL_TEE_TYPE_OPTEE)
> > -            FDT( make_optee_node(gc, fdt) );
> > +        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->sci) )=
;
> > +
> > +        if (info->sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC)
> > +            FDT( make_scmi_shmem_node(gc, fdt, pfdt, dom) );
> >           if (d_config->num_pcidevs)
> >               FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_c=
reate.c
> > index dcd09d32ba..c7372fd344 100644
> > --- a/tools/libs/light/libxl_create.c
> > +++ b/tools/libs/light/libxl_create.c
> > @@ -596,6 +596,37 @@ out:
> >       return ret;
> >   }
> > +static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
> > +                         uint64_t guest_addr)
> > +{
> > +    int ret;
> > +    uint64_t _paddr_pfn =3D paddr >> XC_PAGE_SHIFT;
> > +    uint64_t _guest_pfn =3D guest_addr >> XC_PAGE_SHIFT;
> > +
> > +    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
> > +
> > +    ret =3D xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1,=
 1);
> > +    if (ret < 0) {
> > +        LOG(ERROR,
> > +              "failed give domain access to iomem page %"PRIx64,
> > +             _paddr_pfn);
> > +        return ret;
> > +    }
> > +
> > +    ret =3D xc_domain_memory_mapping(CTX->xch, domid,
> > +                                   _guest_pfn, _paddr_pfn,
> > +                                   1, 1);
> > +    if (ret < 0) {
> > +        LOG(ERROR,
> > +              "failed to map to domain iomem page %"PRIx64
> > +              " to guest address %"PRIx64,
> > +              _paddr_pfn, _guest_pfn);
> > +        return ret;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> >   int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
> >                          libxl__domain_build_state *state,
> >                          uint32_t *domid, bool soft_reset)
> > @@ -762,6 +793,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain=
_config *d_config,
> >           goto out;
> >       }
> > +    if (state->sci_agent_paddr !=3D 0) {
> > +        ret =3D map_sci_page(gc, *domid, state->sci_agent_paddr,
> > +                            state->sci_shmem_gfn << XC_PAGE_SHIFT);
> > +        if (ret < 0) {
> > +            LOGED(ERROR, *domid, "map SCI page fail");
> > +            rc =3D ERROR_FAIL;
> > +            goto out;
> > +        }
> > +    }
> > +
> >       dom_path =3D libxl__xs_get_dompath(gc, *domid);
> >       if (!dom_path) {
> >           rc =3D ERROR_FAIL;
> > @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, =
libxl__ao *ao, uint32_t domid,
> >   {
> >       AO_GC;
> >       libxl__ao_device *aodev =3D libxl__multidev_prepare(multidev);
> > -    int i, rc =3D 0;
> > +    int i, rc =3D 0, rc_sci =3D 0;
> >       for (i =3D 0; i < d_config->num_dtdevs; i++) {
> >           const libxl_device_dtdev *dtdev =3D &d_config->dtdevs[i];
> >           LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->p=
ath);
> >           rc =3D xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> > -        if (rc < 0) {
> > -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> > +        rc_sci =3D xc_domain_add_sci_device(CTX->xch, domid, dtdev->pa=
th);
> > +
> > +        if ((rc < 0) && (rc_sci < 0)) {
> > +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> > +                 "xc_domain_add_sci_device failed: %d",
> > +                 rc, rc_sci);
> >               goto out;
> >           }
> > +
> > +        if (rc)
> > +            rc =3D rc_sci;
>=20
>=20
> If I get this code right, it sounds like the dom.cfg's dtdev property is
> reused to describe sci devices as well, but the libxl__add_dtdevs() does =
not
> (and can not) differentiate them. So it has no option but to send two
> domctls for each device in dtdevs[] hoping to at least one domctl to
> succeeded. Or I really missed something?
>=20
> It feels to me that:
> =A0- either new dom.cfg's property could be introduced (scidev?) to descr=
ibe
> sci devices together with new parsing logic/management code, so you will =
end
> up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
> so no mixing things.
> =A0- or indeed dtdev logic could be *completely* reused including extendi=
ng
> XEN_DOMCTL_assign_device to cover your use-case, although sounds generic,=
 it
> is used to describe devices for the passthrough (to configure an IOMMU fo=
r
> the device), in that case you wouldn't need an extra
> XEN_DOMCTL_add_sci_device introduced by current patch.
>=20
> Personally I would use the first option as I am not sure that second opti=
on
> is conceptually correct && possible. I would leave this for the maintaine=
rs
> to clarify.
>=20

Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
seems not to be conceptually correct. Introducing new dom.cfg property
seems to be the only way to avoid extra Domctl calls.
I will handle this in v2 if there will be no complains from Maintainers.

---
Oleksii.

>=20
>=20
> >       }
> >   out:
> > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.=
c
> > index fe9f760f71..b1d288a8b9 100644
> > --- a/tools/libs/light/libxl_dom.c
> > +++ b/tools/libs/light/libxl_dom.c
> > @@ -710,6 +710,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
> >           state->console_mfn =3D dom->console_pfn;
> >           state->store_mfn =3D dom->xenstore_pfn;
> >           state->vuart_gfn =3D dom->vuart_gfn;
> > +        state->sci_shmem_gfn =3D dom->sci_shmem_gfn;
> >       } else {
> >           state->console_mfn =3D xc_dom_p2m(dom, dom->console_pfn);
> >           state->store_mfn =3D xc_dom_p2m(dom, dom->xenstore_pfn);
> > diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl=
_internal.h
> > index 0b4671318c..f9f9cc633a 100644
> > --- a/tools/libs/light/libxl_internal.h
> > +++ b/tools/libs/light/libxl_internal.h
> > @@ -1407,6 +1407,10 @@ typedef struct {
> >       /* Whether this domain is being migrated/restored, or booting fre=
sh.  Only
> >        * applicable to the primary domain, not support domains (e.g. st=
ub QEMU). */
> >       bool restore;
> > +
> > +    /* sci channel paddr to be set to device-tree node */
> > +    uint64_t sci_agent_paddr;
> > +    xen_pfn_t sci_shmem_gfn;
> >   } libxl__domain_build_state;
> >   _hidden void libxl__domain_build_state_init(libxl__domain_build_state=
 *s);
> > diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> > index 6245af6d0b..ba200407da 100644
> > --- a/xen/arch/arm/domctl.c
> > +++ b/xen/arch/arm/domctl.c
> > @@ -4,6 +4,7 @@
> >    * Copyright (c) 2012, Citrix Systems
> >    */
> > +#include <asm/sci/sci.h>
> >   #include <xen/errno.h>
> >   #include <xen/guest_access.h>
> >   #include <xen/hypercall.h>
> > @@ -175,6 +176,20 @@ long arch_do_domctl(struct xen_domctl *domctl, str=
uct domain *d,
> >           return rc;
> >       }
> > +    case XEN_DOMCTL_add_sci_device:
> > +    {
> > +        int rc;
> > +        struct dt_device_node *dev;
> > +
> > +        rc =3D dt_find_node_by_gpath(domctl->u.sci_device_op.path,
> > +                                   domctl->u.sci_device_op.size,
> > +                                   &dev);
> > +        if ( rc )
> > +            return rc;
> > +
> > +        return sci_add_dt_device(d, dev);
> > +    }
> > +
> >       default:
> >       {
> >           int rc;
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index b85e6170b0..671c72c3e8 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> >   #define XEN_DOMCTL_vmtrace_get_option         5
> >   #define XEN_DOMCTL_vmtrace_set_option         6
> >   };
> > +
> > +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> > +struct xen_domctl_sci_device_op {
> > +    uint32_t size; /* Length of the path */
> > +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> > +};
> > +
> >   typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
> >   DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
> > @@ -1265,6 +1272,7 @@ struct xen_domctl {
> >   #define XEN_DOMCTL_get_cpu_policy                82
> >   #define XEN_DOMCTL_set_cpu_policy                83
> >   #define XEN_DOMCTL_vmtrace_op                    84
> > +#define XEN_DOMCTL_add_sci_device                85
> >   #define XEN_DOMCTL_gdbsx_guestmemio            1000
> >   #define XEN_DOMCTL_gdbsx_pausevcpu             1001
> >   #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
> > @@ -1326,6 +1334,7 @@ struct xen_domctl {
> >           struct xen_domctl_psr_alloc         psr_alloc;
> >           struct xen_domctl_vuart_op          vuart_op;
> >           struct xen_domctl_vmtrace_op        vmtrace_op;
> > +        struct xen_domctl_sci_device_op     sci_device_op;
> >           uint8_t                             pad[128];
> >       } u;
> >   };
>=20
> I assume the XSM needs updating (adding new hook, etc).
>=20
>=20
> --=20
> Regards,
>=20
> Oleksandr Tyshchenko
> =


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:24:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:24:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248605.428798 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCHg-0006cg-Dz; Fri, 17 Dec 2021 12:24:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248605.428798; Fri, 17 Dec 2021 12:24:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCHg-0006cZ-Ax; Fri, 17 Dec 2021 12:24:24 +0000
Received: by outflank-mailman (input) for mailman id 248605;
 Fri, 17 Dec 2021 12:24:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myCHe-0006cT-QK
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 12:24:22 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 42360b8c-5f34-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 13:24:20 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHC8JaZ015046;
 Fri, 17 Dec 2021 12:24:16 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d0smvg9bb-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 12:24:15 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR3PR03MB6460.eurprd03.prod.outlook.com (2603:10a6:102:7f::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec
 2021 12:24:09 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 12:24:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42360b8c-5f34-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j+IhnQYTfF1T1LxKT4xPxLuM3DfPXdzCpI/YG/qHwjS7uBZmAHP6usRceGxjzv8d6NtNcvzMy3jkZvUm8WzVrtMDMbsghsHCN1Zaen6cUYuF8wfOHKKz/WgwKl87s+yeQzQkw3WJBfxH0C/t29XgBSoC2tiGSbXv2vlvubp8NcNPi15GY2k18m7jOfxk7OUUYuWv4A2DK0GRIpLCcLsDjR9R/JwFcZ2UCUADG+63Y9i52DX7+uDovW6e8XvBm8zRsLK4LT/RzIaWswK0clisdPlXCqkEhZJpmT0ErTTFXwqDjDYw79YXXk62EMvnLcf4hkLhW9l1lvMm3+Ai+ptDgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Azdg69faNgmsBcOs2BhmE2AbZt+RVJBB0ZDap45MS3s=;
 b=ToVNUHZGANV5cA+wG+RHpRr+S9kCeyz2Ev5uaEi3TCEVqnTGNZ3fhVuumHwHhM0E9YUNWkaw0a1AH9RpWb9cLYW+xt4WZ32hG3UWK45EZCXqvOQNYdyckJxaBf5t2r4ZXhyQbD2Se9a06S+dQ7j5H367HJggIBgpW49/YNY/NJ0Wv0CoYUPgAjaQNeilcj+vT7uygJ1lZsEgQ+SY8t32RzVbMfZm0LA7mM5vM3XUmfQpNXlEXmWwVOBsa+R1G5+EUmN9/rnFLh8+i7uMP+I4bYktpJNFIoC81iFud4D/3NquHnyaZ3vPA88KYePv9pZ48SjTbdVp/o3zeqAvy3VqsA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Azdg69faNgmsBcOs2BhmE2AbZt+RVJBB0ZDap45MS3s=;
 b=bWmQziRdngw4o6GVCLP+qDCoE391mLj9/qNGu7DPYfvpz4xBuRdhceFrk5ShVnSmhVg8tr57GXn9jIL3UIzXL1Eq0+j19Ykwao6/V7BM9ZwzJmmKZ2H81CHcoZvVZcp8djPA2QtWpprBktTWoh3mVpHtFZt7+LBmc1hFkyeD3e/EYC0I95qochSvWOqekZP/csaU25cQarJ6PVW6Kuvh04X/cUdEiXLLsJ4eu7X8nxm16HKjEvbWevBV4f9uyM5Yw7aeArnAyxTET2ap2Lq5qhX0RE8zdY1ZOzftH1asRg9uv9KvDIHxpztnofXW6AeSxp2oUc4zfaDhjsC+9CCrBQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George
 Dunlap <george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Wei Liu
	<wl@xen.org>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [RFC v1 0/5] Introduce SCI-mediator feature
Thread-Topic: [RFC v1 0/5] Introduce SCI-mediator feature
Thread-Index: AQHX8M3EbPa1dWpku0ybFf1q9+Bnxaw0R3oAgAJY5AA=
Date: Fri, 17 Dec 2021 12:24:09 +0000
Message-ID: <20211217122408.GA4023239@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <c8739251-3e13-2337-0ae8-cfae59397251@gmail.com>
In-Reply-To: <c8739251-3e13-2337-0ae8-cfae59397251@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d335c0c5-7fb1-4c10-7166-08d9c1582045
x-ms-traffictypediagnostic: PR3PR03MB6460:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB646053CE24D202DA29D5B10AE3789@PR3PR03MB6460.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 qbJH4M29YeaF96VmKyyQFx3Zae/u68kgrGs/jjoyPAAI8Jd2hQzzex3QFHOnoNcvHsvTftcGHbdKYEK8+9m96ZwSxppunlnpDMLt3oy53W4tF1absvtToaUTo6dMesqBuPCC4AfQOunibv2x4+ukBGcN1p8zTFix6z1gWjvkwgh4L2lJEyILuZnshWekr1g83Wrqh5dJ5J8pue4NFiWLiMLbfElTQeDscKhPmubPmJqBjT5rvpdEg4l//HdHwFrqiJvFrACRwXLN+m/uVdi2N26/FGtM6xW61HKMfxQTgb40uAExgMs09C/+6WsfpWL3pj7PtmYzckUM4apiWaDxXihBF3LBeHLMYx78whzaCA7YCaNlFPiJ+bOKTd6qT9LxyavFFYSF1aENMvDKoV8YTYVQf9Vjbx9/HyVeTQTx2Ydst7IxxqHQYrEAybj9By37oeEeM6M0tHwND92nnK/Q3TntFD1R6pgL/j0xwBiRZeQHGAecHDkmnjCAOXJM2aFwkYdZ8ioK4GZXbhs0ntbAMpuioznVQ/rExNX49JASHynGQExUW0pW3nyHYliYX3Cg3IEhAOa7sftumS+0XO1HZus5D81+YSIqbgByp/t19LoGfMXWzuHXTgwWHQcSTCaHnhUa/4aEXFytUBVBzLXkusi/BhEw5I7K6zmtnm2uahQNYpngxZu/cAaNyUUEwvqUdOYP5rBrusOyFt1PmCnkjQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(33716001)(8676002)(1076003)(5660300002)(33656002)(2906002)(38070700005)(6506007)(6916009)(316002)(122000001)(8936002)(38100700002)(83380400001)(66556008)(54906003)(64756008)(76116006)(71200400001)(66946007)(66446008)(7416002)(66476007)(53546011)(508600001)(91956017)(186003)(26005)(4326008)(6486002)(6512007)(9686003)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?157cJKdZkVruoP0suA5dR+u4M5yMvnc1dz2VaL9C2hftyoWWLX1UXIAWKlrV?=
 =?us-ascii?Q?sTRyxiy2FHqV/Hmzs/iTR/clxajrKOd1IufYn0E+nxzMlNjGDQ0p1LX/1L07?=
 =?us-ascii?Q?NzraEt5nbFlbhTdLFGUvsjTewlAh0EqXB5YfYFFmnXVBUMa2eFShFcdq7kv5?=
 =?us-ascii?Q?jVdC0LHVFwIakAoMLZHoOh/5qGmD1YArdAjDrwoN3pb5WLJMhgHReEvc+d4p?=
 =?us-ascii?Q?7yvFEIYfKPK7mz/5TWVdVhC73WCbSsx4SI+zlONOESxIAJulKhSNfTlBJfiV?=
 =?us-ascii?Q?hXnVUMinoRZotXgCneqi4zm53wHScrK2AUXlIBB06rerPI0fkgBUE5LhCzyd?=
 =?us-ascii?Q?TtIPmTEgTK2H9Ik7uf0xvZzlIE8arc6OLNJvNdfPUkm+miD9vndSaa0+4Fz8?=
 =?us-ascii?Q?+AIN63rOly7aPzI+d48mliWAjIKPxOqC2zaijRN8S9DouabAdV7ShVUrWF+U?=
 =?us-ascii?Q?rVah2R7lG9QfJmBzrB8wQSgxGf0tVpbzASnDXWYYvnjZ2hLxStT/R5b6cRvT?=
 =?us-ascii?Q?rMgt+BCQEsCMdlWfPprig7S2NFiNbPdZdo1j107fxTwgC+IrkZXoykD7keN/?=
 =?us-ascii?Q?wn2MTXVx1TNnqnsoMqjurHN0jkutD+VrhoQUKoz7In/wBjSbC9LPGpkZtpz1?=
 =?us-ascii?Q?ybTLdTinktDtFwwFTWFQ0tVpFr06p0tXA7PPSGDGxn8F3e+IZh046IynUb4l?=
 =?us-ascii?Q?dei/W2j9DtIqzKtVAOWIVAeu2JETuiNFOpcMlSDVCWsIirXUTbEUf/6UQJrg?=
 =?us-ascii?Q?Q+USHP27mn0H5NW6vUgMU8IlfQNTtNrCa2QyfoehFGalEkDX3TBR8yoGFWu7?=
 =?us-ascii?Q?3s0+y94zwWp+trO8OmDTA1w416mJ8+w3jYmDYtk0ry4hZnEbcT+sehjrt5Iz?=
 =?us-ascii?Q?BR0foKxr8ELBXyVK2OB88LpLIRqp757uiNDVXi67roAKjnx+wKrcAKNFuLGG?=
 =?us-ascii?Q?WbYMLV4kbYOOg2+7DlSKxEkbgreZJk9Xaq9zyKGu+pXvro9NhjH9WJUJiod/?=
 =?us-ascii?Q?4Ms1z7azJTPwwtxMEiqEl8WLK7pXFO3Dop525qsvjctKN3LT7oRdr7ZtIJoS?=
 =?us-ascii?Q?EzbIFUgkpoT3JPxNnd/PK0SwaqqfUer10COVUuScRmc6S08SFWrOIBAJytFE?=
 =?us-ascii?Q?2rAznJkl3dYR6PGq4quiKJOceBmR+iR3oOx/P/LYXKOsUXB5/yAmtEdYhdww?=
 =?us-ascii?Q?sVhfZhxkMhiYldt/FD4kdhEKQ3msv5cm3MENl9eD6QGFNuxI1aUn7bv1krk6?=
 =?us-ascii?Q?uVIqI/BlTaB/6XAhtYh8LNZYicSPx+jANWaDblfwKD/3k+abJcRPt9CFYjTG?=
 =?us-ascii?Q?6LO4LBrIRbd+INZtSmaFdABGHd6OuSLrVDAihU31fzKljClHN6H8nTWsy9Ku?=
 =?us-ascii?Q?FaAXJN5SH6lEdVyVmHB67KVLt6LVv+oy2HRzMcqOP2bEKLYvcbirgQAl2yiZ?=
 =?us-ascii?Q?f5jftMVigeCLtyOk3Uz7HO+Gqf+u9E57mQwQoDnEy8NdAgs09H2odoNAn7ZL?=
 =?us-ascii?Q?d/0tlPUVlXnEe9Bcaix9b8VhoC6wDYhX655Jg3erkZbmzRyrV9aQZeBIaNgI?=
 =?us-ascii?Q?9J3MfqW15dCf+cwVKzvcXOXL+ds7x6Jr8qCLR2rm9FMRW40aN5OpJtcWnmBb?=
 =?us-ascii?Q?lf8/G+ulR1/eXahWJk1Q/MUErf1uvtWSGQJk2sSqTH8NWKlpOdvWU3sh8l+g?=
 =?us-ascii?Q?OJNK3DFCYdDNSHyxSQsGDiXg5LY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1D594ECE64A71349BD54F986085210F5@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d335c0c5-7fb1-4c10-7166-08d9c1582045
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 12:24:09.1403
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tPiiohyQr9hIyVDKODEQcRnUbNjsEj8N1rZzRk2IeyqniFxiBYCFPLolflCSXzX4fCgh585VJPfomVsyg67gCHYh9bA3TBkKgSerRSvqanY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6460
X-Proofpoint-GUID: YfAqsaVos9rx4HEd2PexSV-LTmzjCz5y
X-Proofpoint-ORIG-GUID: YfAqsaVos9rx4HEd2PexSV-LTmzjCz5y
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999
 mlxscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 malwarescore=0
 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112170071

Hi Oleksandr,

On Thu, Dec 16, 2021 at 02:33:28AM +0200, Oleksandr wrote:
>=20
> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>=20
>=20
> Hi Oleksii
>=20
> > Introducing the feature, called SCI mediator.
> > It's purpose is to redirect SCMI requests from the domains to firmware
> > (SCP, ATF etc), which controls the power/clock/resets etc.
> > The idea is to make SCP firmware (or similar, such as AT-F) responsible=
 for
> > control power/clock/resets and provide SCMI interface so controls can b=
e shared
> > between the Domains.
> > Originally, we've met a problem, that the devices, shared between diffe=
rent
> > Domains, can't have an access to HW registers to work with clocks/reset=
s/power
> > etc. You have to pass cpg to the Domain, so the devices can access HW d=
irectly.
> > The solution for this is to move HW controls over power/clock/resets to
> > SCP firmware and use Linux-kernel SCMI drivers to pass requests to SCP.
> > Xen is responsible for permissions setting, so Domain can access only t=
o
> > power/clock/resets which are related to this Domain. Also XEN is the me=
diator
> > which redirects SCMI requests, adding agentID so firmware should know t=
he
> > sender.
> > SMC is currently used as transport, but this should be configurable.
> >=20
> > Here is the high level design:
> >=20
> > SCI (System Control Interface) feature can be enabled in xen_config:
> > > CONFIG_SCI=3Dy
> > Mediator can be configured:
> > > CONFIG_SCMI_SMC=3Dy
> > Currently, only SCMI_SMC mediator is implemented, which using shared me=
mory
> > region to communicate with firmware and SMC as transport.
> >=20
> > Xen scmi should be configured in the device-tree.
> > Format is the following:
> > 	cpu_scp_shm: scp-shmem@0x53FF0000 {
> > 		compatible =3D "arm,scmi-shmem";
> > 		reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > 	};
> >=20
> > 	firmware {
> > 		scmi {
> > 			compatible =3D "arm,scmi-smc";
> > 			arm,smc-id =3D <0x82000002>;
> > 			shmem =3D <&cpu_scp_shm>;
> > 			#address-cells =3D <1>;
> > 			#size-cells =3D <0>;
> >=20
> > 			scmi_power: protocol@11 {
> > 				reg =3D <0x11>;
> > 				#power-domain-cells =3D <1>;
> > 			};
> >=20
> > 			scmi_clock: protocol@14 {
> > 				reg =3D <0x14>;
> > 				#clock-cells =3D <1>;
> > 			};
> >=20
> > 			scmi_reset: protocol@16 {
> > 				reg =3D <0x16>;
> > 				#reset-cells =3D <1>;
> > 			};
> > 		};
> > 	};
> >=20
> > Where:
> > &cpu_scp_shm is the shared memory for scmi buffers;
> > 0x53FF0000, size 0x1000 is the platform specific free address, which pr=
ovide
> > space for the communication.
> > &scmi node, which should be copied to Dom0 device-tree.
> >=20
> > Device configured to use scmi:
> > &avb {
> > 	scmi_devid =3D <0>;
> > 	clocks =3D <&scmi_clock 0>;
> > 	power-domains =3D <&scmi_power 0>;
> > 	resets =3D <&scmi_reset 0>;
> > };
> >=20
> > Where:
> > scmi_devid - id from the firmware, which is assigned for AVB.
> >=20
> > During initialization, XEN scans probes the first SCI-mediator driver w=
hich has
> > matching node in the device-tree. If no device-tree was provided, then =
the
> > first registered mediator driver should be probed.
> >=20
> > DomX should be configured:
> > Device-tree should include the same nodes, described above.
> > &cpu_scp_shm should be altered during domain creation. Xen allocates fr=
ee page
> > from the memory region, provided in &cpu_scp_shm in XEN device-tree, so=
 each
> > domain should have unique page. Nodes &cpu_scp_shm and /firmware/scmi s=
hould be
> > copied from partial device-tree to domain device-tree, so kernel can in=
itialize
> > scmi driver.
> >=20
> > SCI mediator can be enabled in dom.cfg the following way:
> > > sci =3D "scmi_smc"
> > which sets scmi_smc to be used for the domain.
>=20
>=20
> Great work! I can imagine this is going to be nice feature once upstreame=
d.
>=20
> I am wondering, would the Xen (with the required updates of course) also =
be
> able to send it's own requests to the SCP? For example, to control overal=
l
> system performance (CPU frequency)
>=20
> or other let's say important power management task.
>=20

I think yes. In current implementation Xen register itself as
privilleged agent and use it's own channel to request=20
which is used to get agent configuration and process device permissions.
I think this channel can also be used to do some configuration tasks
via SCMI. But this will require updates.

--
Oleksii.
>=20
> >=20
> > Oleksii Moisieiev (5):
> >    xen/arm: add support for Renesas R-Car Gen3 platform
> >    xen/arm: add generic SCI mediator framework
> >    xen/arm: introduce SCMI-SMC mediator driver
> >    tools/arm: add "scmi_smc" option to xl.cfg
> >    xen/arm: add SCI mediator support for DomUs
> >=20
> >   MAINTAINERS                       |   6 +
> >   docs/man/xl.cfg.5.pod.in          |  22 +
> >   tools/include/libxl.h             |   5 +
> >   tools/include/xenctrl.h           |   3 +
> >   tools/include/xenguest.h          |   2 +
> >   tools/libs/ctrl/xc_domain.c       |  23 +
> >   tools/libs/guest/xg_dom_arm.c     |   5 +-
> >   tools/libs/light/libxl_arm.c      | 122 ++++-
> >   tools/libs/light/libxl_create.c   |  54 +-
> >   tools/libs/light/libxl_dom.c      |   1 +
> >   tools/libs/light/libxl_internal.h |   4 +
> >   tools/libs/light/libxl_types.idl  |   6 +
> >   tools/xl/xl_parse.c               |   9 +
> >   xen/arch/arm/Kconfig              |  10 +
> >   xen/arch/arm/Makefile             |   1 +
> >   xen/arch/arm/domain.c             |  24 +
> >   xen/arch/arm/domain_build.c       |  11 +
> >   xen/arch/arm/domctl.c             |  15 +
> >   xen/arch/arm/platforms/Makefile   |   1 +
> >   xen/arch/arm/platforms/rcar3.c    |  47 ++
> >   xen/arch/arm/sci/Kconfig          |  10 +
> >   xen/arch/arm/sci/Makefile         |   2 +
> >   xen/arch/arm/sci/sci.c            | 128 +++++
> >   xen/arch/arm/sci/scmi_smc.c       | 795 +++++++++++++++++++++++++++++=
+
> >   xen/arch/arm/setup.c              |   1 +
> >   xen/arch/arm/xen.lds.S            |   7 +
> >   xen/include/asm-arm/domain.h      |   4 +
> >   xen/include/asm-arm/sci/sci.h     | 162 ++++++
> >   xen/include/public/arch-arm.h     |  11 +
> >   xen/include/public/domctl.h       |   9 +
> >   30 files changed, 1485 insertions(+), 15 deletions(-)
> >   create mode 100644 xen/arch/arm/platforms/rcar3.c
> >   create mode 100644 xen/arch/arm/sci/Kconfig
> >   create mode 100644 xen/arch/arm/sci/Makefile
> >   create mode 100644 xen/arch/arm/sci/sci.c
> >   create mode 100644 xen/arch/arm/sci/scmi_smc.c
> >   create mode 100644 xen/include/asm-arm/sci/sci.h
> >=20
> --=20
> Regards,
>=20
> Oleksandr Tyshchenko
> =


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:51:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:51:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248609.428809 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myChe-0001v3-HH; Fri, 17 Dec 2021 12:51:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248609.428809; Fri, 17 Dec 2021 12:51:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myChe-0001uw-E7; Fri, 17 Dec 2021 12:51:14 +0000
Received: by outflank-mailman (input) for mailman id 248609;
 Fri, 17 Dec 2021 12:51:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myChd-0001uq-1W
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 12:51:13 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffbd2053-5f37-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 13:51:06 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHBvw6T015344;
 Fri, 17 Dec 2021 12:51:01 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d0ryq8hsg-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 12:51:01 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6784.eurprd03.prod.outlook.com (2603:10a6:102:f0::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 12:50:56 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 12:50:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffbd2053-5f37-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=F3+IJnp3U4lHyI8iLCQGEyfzp+aHceYHE8k3n17MPG+UOt3/yTaU1MZTPrG5aysBFA6042yD0jupWBmeknzFqaMUGNXdeXlwmtABIlqBoazPMcchgv9HaYHwkRZSejM0b4kXuKU9sqKxl8em2/1UcF7dlm3xPE3P/tqQXaJ3Je/209W3VM4wi/ojUbBJ9CFVQ49jGJ8NPKR6oDh5f/v4JCybFzGsrh1PcQx6CEYBUpgqdM1rzZ7Qs4C8R+oGPPx4Q1LNk6ri/utRURYCkHAyOZJO+kkNGxWVoEGLFd2+RsRAUQrSnBOqiPBxeG1ZwfykCwvZ3nSxl98FZoOZdom3HQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OzssSX9VZGpFxi8yNv19MUmcBjVLw/gpV4xwVtgpp+8=;
 b=V86DLh1U3FuAYFFZIbKLUfEVfaD7WvumQLb+SEaonjpwSdI+nTorZoubmXYEy2na9qTY2LZIjrX9LGCHbV/9SSqNE6ozRbT0/XkPbUgHljLrGXROwk1TddwL2eXrL/qC5KPTgaI9gVmbrNDg4MAxRAjhXOHVI1DBthzAUlLFjFQOzBjMuwdcDze0IqjaPvWIVnvTXhpGGGqyGrzHUhnjnsceHprf5UCAvBrtT646yXPs1ymJ5PTotLLX8P8qhlt6G80v/bVhiWgdkAYj3IBYGsvmFtnANXU7TNxHTLVEXy0aRPbi1Qm3C6dK9hIu5ZbXMazLf3aoQljKldLMsi344g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OzssSX9VZGpFxi8yNv19MUmcBjVLw/gpV4xwVtgpp+8=;
 b=QUZbkitPIqk4O3voWAYRdBJVXh/6AfF1opvYemZ61sjrJSvcvHrmYkxIW+tz9Cix4P9bAKXTz9Htwa5wD1vjycXdJkKhD/FV7lAZThRFjkJg6RM5nCdKasITLiaYAY+7Qh+W2ScpqfCRxzTXm3dNAXKcguKRBHh+oPeCXQapnccuTk0pGVyTt+yztLwvlrVAdBLU3Aw7SPtwzCnblElmtiK6IutJTDGogUJu3jVQgN2iXf/RexKy8tAhvH+oSdZpt81LkZJcGk5e3Y76SIPYQRACuG8EE7TQZpbK5idzDOdpBsQl86oSHfKC/EByk75yIcTyeouKaB5SD2WxbrrpWQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Andrew
 Cooper <andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Wei Liu
	<wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand
 Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 2/5] xen/arm: add generic SCI mediator framework
Thread-Topic: [RFC v1 2/5] xen/arm: add generic SCI mediator framework
Thread-Index: AQHX8M3IB9WR9OXgbE2xll7qsLGWC6w1/pyAgACpPoA=
Date: Fri, 17 Dec 2021 12:50:55 +0000
Message-ID: <20211217125055.GA4026247@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <c0afe4837fe99e7f7921fc43b130aa2234f234be.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112161831230.1662642@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112161831230.1662642@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 9ca6a4bc-cec8-466a-2d5b-08d9c15bde15
x-ms-traffictypediagnostic: PA4PR03MB6784:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB67841818F6D0C4956663B14CE3789@PA4PR03MB6784.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 802uWNboODdJnD6s336gInI0GpFthtKcLnL0oNaVM1oiMJIAPTkA4PXM3VxMLoN0UBoV4SVtVAKKekur2QmKBZQS+6hkiPzkc83IYgGJvbtyN6KKDFt/3tv2hio1o1zd0qn/IrTyfh9SArnlPN/2H011bxeUXVYm5nSBTCY+EMP8E6W9Y6WRxyDh2r1JGYPUTMSA+5pIUx2Jk29Tf6XseO66hxkgZ1wj8ILaxsYSWeiTCPO/UoR3uUsDVAojPl5oVy2jbn4D+zgDLiQk8ZJASvPT/evKr3vXQV5apFHx5zmBtrWIcmZv5ZF6Gl6/PUxsB724nI4AZg+kdk/I6mPVS5x0FQGPU3QVtWIIfyhKI+7zsfnOlyqlKn1AuG0BubWFYsKW1ZIGkjwBTY87gesxV0/7i8YgfCTipvHCOOLpA7VzTfg2JNekptsR1BndMNfAC9gnZfIAecmTKQSbIjtnWJbCwV6TqwqFeZ3bFRu/55NY4BOHlNCM8ET0KzIXLO3HIQ+gMD+K1ITBoiH0PTbnY8uhy5075BUnu4IY6C5LPiWDB+vh26Cb6gPkkLa65TIa2vigXNR+wClrM17h4rcDEWzTzbk3qa+Fb0gJ/M7YewX/cAUAKlo12wpmbElLMNohDIWO+2IZ+5n3LfIoYMQGtgZq1HZNq46gvF7w/tr9SVOepNIKiJnDf/AFXwjQWObINnU3aSu1fyGYzpx0M6/JriV6CK8gvUtDPoTaYH25IzAcydt6R59+DyK6JItd/VcBRXnAv2I7YDmSRq3v6eu63w==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6512007)(122000001)(66556008)(66446008)(64756008)(1076003)(9686003)(38100700002)(71200400001)(6506007)(5660300002)(8936002)(6486002)(83380400001)(8676002)(38070700005)(66476007)(33716001)(508600001)(54906003)(30864003)(316002)(66946007)(86362001)(33656002)(26005)(76116006)(4326008)(186003)(91956017)(6916009)(2906002)(41533002)(2004002)(21314003)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?sQG4HypCwgqUx9gYT+K7yVwl/MpOUT9MVWc+ELadE9kHOyGwUdKsGcxjijiv?=
 =?us-ascii?Q?khXj66yUObsRcry4NZD1Vr40T3oMlS8XCpFbc9WfVhC1qQlNmgTH5tTbSvjM?=
 =?us-ascii?Q?CGI9ul65z5moaL/8fe69NLSM6YNT7+eDS+02vpuYB/afBd7i5n20R+VAoage?=
 =?us-ascii?Q?rP6nXfaqxV3Bdi9E5H5iUzIbFUX3mhJO1rMV+mbQjj4Mzs0H3CJ9NwYPaz+x?=
 =?us-ascii?Q?142v4o/+neHQQd0qiZRtKdX1SPzW5lZAxQ0xymCo5pQiItVQ38t2GjwtlDtR?=
 =?us-ascii?Q?r6Y8ti73Dt3XaoHUSYBDoOG9KtQc9Cn8AsMlHmZ1t9rpp81lrx+hwTq6/YdP?=
 =?us-ascii?Q?KkeugN6xRNLPP/Cc+FwubtIBorMNoCisS1h6gNc8MoUVBMWEKO010e2StnBt?=
 =?us-ascii?Q?6rb6oLWejVDKFssn88OzIwyGAzArug7owXIaaBuoLeomLfZxZgsNFQCYSH47?=
 =?us-ascii?Q?t3mFtJIyZRkFzbVBseII/g6eXyFJphgdEZhw09zqoQ9PO4REjKGkXS36KnM5?=
 =?us-ascii?Q?f6jM9v2UxZgGVPYXmhNJRXKvwdkKXId2k88YyfZLVOlDnBQXLQzOOEYHoqiq?=
 =?us-ascii?Q?FPRLRqMrwWqnOaL9HRQ4pJrjT3l6sYfs2bFc4jLR3kZOPJZmPpyhNDmfENRA?=
 =?us-ascii?Q?umDK5QnvXH6/M96842loeFkh/E4ETWACy60xPdc8ZElEdee8DUVd2J064W6n?=
 =?us-ascii?Q?+0rOHwsEaWhySvbh2mCfim8t8w+8GquXF1h9kXH32Ufdd3E8Gp/oQwOZvMXu?=
 =?us-ascii?Q?zrC6DXNVlnwe4O5Qiwqz11uCR7kpG19UYoW/4UdXsV6dreCbX80Sa495b4JI?=
 =?us-ascii?Q?JfTR4bNN0lcVdCdYdaQSM9PUuWHcFjRrzdUz/bw8CkmffBHLPl0jiQu5TiVS?=
 =?us-ascii?Q?dPXJLjVcA4+umYq/HXtkKRf9oYmjDOUUyXFd0Mnd8ZOq01Z83ENIO/PxOR0H?=
 =?us-ascii?Q?LKRm8I/1bWu/4XRd+UQo0drE8Vo2bwZ5EkZwTLUjKLXyG9rMxANXsK582SKE?=
 =?us-ascii?Q?Ieb+Kswz+L0Pe7+n0uDi8YwvUSKF9YLAOlKz2gEv3BqlFkDSNJqVKwyTDBOB?=
 =?us-ascii?Q?O/l9bo8S4+CHA3iAaDQK8S9eIaFq7H3Ra98sznkTEGZGQq4AdHGvcLXZnVaK?=
 =?us-ascii?Q?JuT+xAliDZDhi9O+gzaZN5OLgWIlkNM59D8bALaz49Xs9GZ4qr4W58b/9wTX?=
 =?us-ascii?Q?JpJ4Pnp71IadE+fR0z9TpySxuSWk3fra3BsjJorLGPdRk/ZpnyQoNkn5lhR2?=
 =?us-ascii?Q?cu2EQiM3rsjNoz86K9ZryKvItrFO5kFLFo6Qinc/ssLp5QlFaIUdrJihlNh0?=
 =?us-ascii?Q?GdhK0xXQLdTbHsqZbvgwPnt7Q95uA12MOs5B9DcdBPPWqwuMbFcgLeiJfaD+?=
 =?us-ascii?Q?GtLKURQe20qc33kkkfaQPSTr2uyrv5W5zrSa6ZQfWwmoyth8AaHYZCtbHnqn?=
 =?us-ascii?Q?mDfTCqvN49ar1WObd6BEoqe0/ub4pCDSlpbft7GndP8+QlZd0rt4bMMBl1IV?=
 =?us-ascii?Q?nFvGIlmhhopks+Xd2Tip0Fjl6dLRfWiV3ogFM2Lwkj9KgeWCECNV2kb3Cz0T?=
 =?us-ascii?Q?FOc//0kyx7kX914bh3kF63u9NN7R2otUg7xyk3ozEm2brCEQ1SzlQETsOVKd?=
 =?us-ascii?Q?3SjtsVD/nk922BkzMe2ISPT03BGEG1VLDzUPHJjmJ+BOZilxXUmKa3HCIoZ8?=
 =?us-ascii?Q?RL0v9IkSU5Ggw1UpLuyr3PM/ZXw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AB0671866C6816489318214C672E185A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ca6a4bc-cec8-466a-2d5b-08d9c15bde15
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 12:50:55.9563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IA1ExPeaL/h9GmgyFMT9TjPmAyJg/lQsEhywwZNMuuEdVqbmmjG5IvQdcJOjnWEPovNDgA7hlM88iF93Fo0drrO0ncdK7kuctr7BEpogP8U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6784
X-Proofpoint-ORIG-GUID: 9JYDl3zOswziQplMrPwghEecQypaFILo
X-Proofpoint-GUID: 9JYDl3zOswziQplMrPwghEecQypaFILo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999
 adultscore=0 suspectscore=0 priorityscore=1501 phishscore=0 malwarescore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170074

Hi Stefano,

On Thu, Dec 16, 2021 at 06:45:11PM -0800, Stefano Stabellini wrote:
> On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > This patch adds the basic framework for SCI mediator.
> > SCI is System Control Interface, which is designed to redirect
> > requests for the Hardware (such as power-domain/clock/resets etc)
> > from the Domains to the firmware. Originally, cpg should be passed
> > to the domain so it can work with power-domains/clocks/resets etc.
> > Considering that cpg can't be split between the Domains, we get the
> > limitation that the devices, which are using power-domains/clocks/reset=
s
> > etc, couldn't be split between the domains.
> > The solution is to move the power-domain/clock/resets etc to the
> > Firmware (such as SCP firmware or ATF) and provide interface for the Do=
mains.
> > XEN shoud have an entity, caled SCI-Mediator, which is responsible for =
messages
> > redirection between Domains and Firmware and for permission handling.
> >=20
> > This is how it works: user can build XEN with multiple SCI mediators.
> > See the next patches, where SCMI-SMC mediator is introduced.
> > SCI mediator register itself with REGISTER_SCI_MEDIATOR() macro.
> >=20
> > At run-time, during initialization, framework calls probe for the first
> > matching device in the device-tree. When no device-tree is present - th=
e
> > first registered mediator should be probed.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >  MAINTAINERS                    |   6 ++
> >  xen/arch/arm/Kconfig           |   8 ++
> >  xen/arch/arm/Makefile          |   1 +
> >  xen/arch/arm/domain.c          |  24 +++++
> >  xen/arch/arm/domain_build.c    |  11 +++
> >  xen/arch/arm/platforms/rcar3.c |   3 +-
> >  xen/arch/arm/sci/Makefile      |   1 +
> >  xen/arch/arm/sci/sci.c         | 128 ++++++++++++++++++++++++++
> >  xen/arch/arm/setup.c           |   1 +
> >  xen/arch/arm/xen.lds.S         |   7 ++
> >  xen/include/asm-arm/domain.h   |   4 +
> >  xen/include/asm-arm/sci/sci.h  | 162 +++++++++++++++++++++++++++++++++
> >  xen/include/public/arch-arm.h  |  10 ++
> >  13 files changed, 365 insertions(+), 1 deletion(-)
> >  create mode 100644 xen/arch/arm/sci/Makefile
> >  create mode 100644 xen/arch/arm/sci/sci.c
> >  create mode 100644 xen/include/asm-arm/sci/sci.h
> >=20
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e43dc0edce..5f96ea35ba 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -512,6 +512,12 @@ S:	Supported
> >  F:	xen/arch/arm/tee/
> >  F:	xen/include/asm-arm/tee
> > =20
> > +SCI MEDIATORS
> > +M:	Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > +S:	Supported
> > +F:	xen/arch/arm/sci
> > +F:	xen/include/asm-arm/sci
> > +
> >  TOOLSTACK
> >  M:	Wei Liu <wl@xen.org>
> >  S:	Supported
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > index ecfa6822e4..186e1db389 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -106,6 +106,14 @@ config TEE
> > =20
> >  source "arch/arm/tee/Kconfig"
> > =20
> > +config SCI
> > +	bool "Enable SCI mediators support"
> > +	default n
> > +	help
> > +	  This option enables generic SCI (System Control Interface) mediator=
s
> > +	  support. It allows guests to control system resourcess via one of
> > +	  SCI mediators implemented in XEN.
> > +
> >  endmenu
> > =20
> >  menu "ARM errata workaround via the alternative framework"
> > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > index 07f634508e..6366ff55e5 100644
> > --- a/xen/arch/arm/Makefile
> > +++ b/xen/arch/arm/Makefile
> > @@ -8,6 +8,7 @@ obj-y +=3D platforms/
> >  endif
> >  obj-$(CONFIG_TEE) +=3D tee/
> >  obj-$(CONFIG_HAS_VPCI) +=3D vpci.o
> > +obj-$(CONFIG_SCI) +=3D sci/
> > =20
> >  obj-$(CONFIG_HAS_ALTERNATIVE) +=3D alternative.o
> >  obj-y +=3D bootfdt.init.o
> > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> > index 96e1b23550..80d0a23767 100644
> > --- a/xen/arch/arm/domain.c
> > +++ b/xen/arch/arm/domain.c
> > @@ -34,6 +34,7 @@
> >  #include <asm/platform.h>
> >  #include <asm/procinfo.h>
> >  #include <asm/regs.h>
> > +#include <asm/sci/sci.h>
> >  #include <asm/tee/tee.h>
> >  #include <asm/vfp.h>
> >  #include <asm/vgic.h>
> > @@ -688,6 +689,13 @@ int arch_sanitise_domain_config(struct xen_domctl_=
createdomain *config)
> >          return -EINVAL;
> >      }
> > =20
> > +    if ( config->arch.sci_type !=3D XEN_DOMCTL_CONFIG_SCI_NONE &&
> > +         config->arch.sci_type !=3D sci_get_type() )
> > +    {
> > +        dprintk(XENLOG_INFO, "Unsupported SCI type\n");
> > +        return -EINVAL;
> > +    }
> > +
> >      return 0;
> >  }
> > =20
> > @@ -764,6 +772,15 @@ int arch_domain_create(struct domain *d,
> >          /* At this stage vgic_reserve_virq should never fail */
> >          if ( !vgic_reserve_virq(d, GUEST_EVTCHN_PPI) )
> >              BUG();
> > +
> > +        if ( config->arch.sci_type !=3D XEN_DOMCTL_CONFIG_SCI_NONE )
> > +        {
> > +            if ( (rc =3D sci_domain_init(d, config->arch.sci_type)) !=
=3D 0)
> > +                goto fail;
> > +
> > +            if ( (rc =3D sci_get_channel_info(d, &config->arch)) !=3D =
0)
> > +                goto fail;
> > +        }
> >      }
> > =20
> >      /*
> > @@ -796,6 +813,7 @@ void arch_domain_destroy(struct domain *d)
> >      domain_vgic_free(d);
> >      domain_vuart_free(d);
> >      free_xenheap_page(d->shared_info);
> > +    sci_domain_destroy(d);
> >  #ifdef CONFIG_ACPI
> >      free_xenheap_pages(d->arch.efi_acpi_table,
> >                         get_order_from_bytes(d->arch.efi_acpi_len));
> > @@ -996,6 +1014,7 @@ enum {
> >      PROG_xen,
> >      PROG_page,
> >      PROG_mapping,
> > +    PROG_sci,
> >      PROG_done,
> >  };
> > =20
> > @@ -1056,6 +1075,11 @@ int domain_relinquish_resources(struct domain *d=
)
> >          if ( ret )
> >              return ret;
> > =20
> > +    PROGRESS(sci):
> > +        ret =3D sci_relinquish_resources(d);
> > +        if ( ret )
> > +            return ret;
> > +
> >      PROGRESS(done):
> >          break;
> > =20
> > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> > index d02bacbcd1..38874615dd 100644
> > --- a/xen/arch/arm/domain_build.c
> > +++ b/xen/arch/arm/domain_build.c
> > @@ -22,6 +22,7 @@
> >  #include <asm/kernel.h>
> >  #include <asm/setup.h>
> >  #include <asm/tee/tee.h>
> > +#include <asm/sci/sci.h>
> >  #include <asm/platform.h>
> >  #include <asm/psci.h>
> >  #include <asm/setup.h>
> > @@ -1894,6 +1895,10 @@ static int __init handle_device(struct domain *d=
, struct dt_device_node *dev,
> >                  return res;
> >              }
> >          }
> > +
> > +        res =3D sci_add_dt_device(d, dev);
> > +        if ( res < 0 )
> > +            return res;
> >      }
>=20
> It would be good to add the call to dom0less domUs too
>=20

Thank you, I will fix all mentioned places in v2.

>=20
> >      res =3D handle_device_interrupts(d, dev, need_mapping);
> > @@ -3075,6 +3080,10 @@ static int __init construct_dom0(struct domain *=
d)
> >      if ( rc < 0 )
> >          return rc;
> > =20
> > +    rc =3D sci_domain_init(d, sci_get_type());
> > +    if ( rc < 0 )
> > +        return rc;
>=20
> same here
>=20

TBD in v2

>=20
> >      if ( acpi_disabled )
> >          rc =3D prepare_dtb_hwdom(d, &kinfo);
> >      else
> > @@ -3109,6 +3118,8 @@ void __init create_dom0(void)
> >      dom0_cfg.arch.tee_type =3D tee_get_type();
> >      dom0_cfg.max_vcpus =3D dom0_max_vcpus();
> > =20
> > +    dom0_cfg.arch.sci_type =3D sci_get_type();
>=20
> and here
>=20
TBD in v2
>=20
> >      if ( iommu_enabled )
> >          dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu;
> > =20
> > diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rc=
ar3.c
> > index d740145c71..a268b09454 100644
> > --- a/xen/arch/arm/platforms/rcar3.c
> > +++ b/xen/arch/arm/platforms/rcar3.c
> > @@ -18,10 +18,11 @@
> >   */
> > =20
> >  #include <asm/platform.h>
> > +#include <asm/sci/sci.h>
> > =20
> >  static bool rcar3_smc(struct cpu_user_regs *regs)
> >  {
> > -    return false;
> > +    return sci_handle_call(current->domain, regs);
> >  }
> > =20
> >  static const char *const rcar3_dt_compat[] __initconst =3D
> > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > new file mode 100644
> > index 0000000000..837dc7492b
> > --- /dev/null
> > +++ b/xen/arch/arm/sci/Makefile
> > @@ -0,0 +1 @@
> > +obj-y +=3D sci.o
> > diff --git a/xen/arch/arm/sci/sci.c b/xen/arch/arm/sci/sci.c
> > new file mode 100644
> > index 0000000000..5961b4cd5d
> > --- /dev/null
> > +++ b/xen/arch/arm/sci/sci.c
> > @@ -0,0 +1,128 @@
> > +/*
> > + * xen/arch/arm/sci/sci.c
> > + *
> > + * Generic part of SCI mediator driver
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021, EPAM Systems.
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <xen/errno.h>
> > +#include <xen/init.h>
> > +#include <xen/sched.h>
> > +#include <xen/types.h>
> > +
> > +#include <asm/sci/sci.h>
> > +
> > +extern const struct sci_mediator_desc _sscimediator[], _escimediator[]=
;
> > +static const struct sci_mediator_desc __read_mostly *cur_mediator;
> > +
> > +bool sci_handle_call(struct domain *d, void *args)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return false;
> > +
> > +    return cur_mediator->ops->handle_call(d, args);
> > +}
> > +
> > +int sci_domain_init(struct domain *d, uint16_t sci_type)
> > +{
> > +    if ( sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_NONE )
> > +        return 0;
> > +
> > +    if ( unlikely(!cur_mediator) )
> > +        return -ENODEV;
> > +
> > +    if ( cur_mediator->sci_type !=3D sci_type )
> > +        return -EINVAL;
> > +
> > +    return cur_mediator->ops->domain_init(d);
> > +}
> > +
> > +void sci_domain_destroy(struct domain *d)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return;
> > +
> > +    cur_mediator->ops->domain_destroy(d);
> > +}
> > +
> > +int sci_relinquish_resources(struct domain *d)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return 0;
> > +
> > +    return cur_mediator->ops->relinquish_resources(d);
> > +}
> > +
> > +
> > +int sci_add_dt_device(struct domain *d, struct dt_device_node *dev)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return 0;
> > +
> > +    return cur_mediator->ops->add_dt_device(d, dev);
> > +}
> > +
> > +int sci_get_channel_info(struct domain *d,
> > +                         struct xen_arch_domainconfig *config)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return 0;
> > +
> > +    return cur_mediator->ops->get_channel_info(d->arch.sci, config);
> > +}
> > +
> > +uint16_t sci_get_type(void)
> > +{
> > +    if ( unlikely(!cur_mediator) )
> > +        return XEN_DOMCTL_CONFIG_SCI_NONE;
> > +
> > +    return cur_mediator->sci_type;
> > +}
> > +
> > +static int __init sci_init(void)
> > +{
> > +    const struct sci_mediator_desc *desc;
> > +    struct dt_device_node *dt =3D NULL;
> > +
> > +    for ( desc =3D _sscimediator; desc !=3D _escimediator; desc++ )
> > +    {
> > +        if ( likely(dt_host) )
>=20
> I think you can assume that dt_host is correctly set, right?
> Instead of this check, I would just add:
>=20
>     if ( !acpi_disabled )
>         return -ENODEV;
>=20
> at the beginning of sci_init
>=20

Good point! I will it in v2. Thanks.

>=20
> > +        {
> > +            dt =3D dt_find_matching_node(dt_host, desc->dt_match);
> > +            if ( !dt )
> > +                continue;
> > +        }
> > +
> > +        if ( desc->ops->probe(dt) )
> > +        {
> > +            printk(XENLOG_INFO "Using SCI mediator for %s\n", desc->na=
me);
> > +            cur_mediator =3D desc;
> > +            return 0;
> > +        }
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +__initcall(sci_init);
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> > index d5d0792ed4..201de01411 100644
> > --- a/xen/arch/arm/setup.c
> > +++ b/xen/arch/arm/setup.c
> > @@ -50,6 +50,7 @@
> >  #include <asm/cpufeature.h>
> >  #include <asm/platform.h>
> >  #include <asm/procinfo.h>
> > +#include <asm/sci/sci.h>
> >  #include <asm/setup.h>
> >  #include <xsm/xsm.h>
> >  #include <asm/acpi.h>
> > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> > index 08016948ab..3683f4821f 100644
> > --- a/xen/arch/arm/xen.lds.S
> > +++ b/xen/arch/arm/xen.lds.S
> > @@ -142,6 +142,13 @@ SECTIONS
> >        _eteemediator =3D .;
> >    } :text
> > =20
> > +  . =3D ALIGN(8);
> > +  .scimediator.info : {
> > +      _sscimediator =3D .;
> > +      *(.scimediator.info)
> > +      _escimediator =3D .;
> > +  } :text
> > +
> >    . =3D ALIGN(PAGE_SIZE);             /* Init code and data */
> >    __init_begin =3D .;
> >    .init.text : {
> > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.=
h
> > index 9b3647587a..d9b164017f 100644
> > --- a/xen/include/asm-arm/domain.h
> > +++ b/xen/include/asm-arm/domain.h
> > @@ -89,6 +89,10 @@ struct arch_domain
> >  #ifdef CONFIG_TEE
> >      void *tee;
> >  #endif
> > +
> > +#ifdef CONFIG_SCI
> > +    void *sci;
> > +#endif
> >  }  __cacheline_aligned;
> > =20
> >  struct arch_vcpu
> > diff --git a/xen/include/asm-arm/sci/sci.h b/xen/include/asm-arm/sci/sc=
i.h
> > new file mode 100644
> > index 0000000000..aeff689c72
> > --- /dev/null
> > +++ b/xen/include/asm-arm/sci/sci.h
> > @@ -0,0 +1,162 @@
> > +/*
> > + * xen/include/asm-arm/sci/sci.h
> > + *
> > + * Generic part of the SCI (System Control Interface) subsystem.
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021, EPAM Systems.
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#ifndef __ASM_ARM_SCI_H
> > +#define __ASM_ARM_SCI_H
> > +
> > +#include <xen/lib.h>
> > +#include <xen/types.h>
> > +#include <xen/device_tree.h>
> > +
> > +#ifdef CONFIG_SCI
> > +
> > +struct sci_mediator_ops {
> > +
> > +    /*
> > +     * Probe for SCI. Should return true if SCI found and
> > +     * mediator is initialized.
> > +     */
> > +    bool (*probe)(struct dt_device_node *scmi_node);
> > +
> > +    /*
> > +     * Called during domain construction if toolstack requests to enab=
le
> > +     * SCI support so mediator can inform SCP-firmware about new
> > +     * guest and create own structures for the new domain.
> > +     */
> > +    int (*domain_init)(struct domain *d);
> > +
> > +    /*
> > +     * Called during domain destruction, releases all resources, that
> > +     * were allocated by the mediator.
> > +     */
> > +    void (*domain_destroy)(struct domain *d);
> > +
> > +    /*
> > +     * Called during parsing partial device-sci for the domain.
> > +     * Passing device_node so mediator could process the device and
> > +     * mark the device as related to the domain if needed.
> > +     */
> > +    int (*add_dt_device)(struct domain *d, struct dt_device_node *dev)=
;
> > +
> > +    /*
> > +     * Called during domain destruction to relinquish resources used
> > +     * by mediator itself. This function can return -ERESTART to indic=
ate
> > +     * that it does not finished work and should be called again.
> > +     */
> > +    int (*relinquish_resources)(struct domain *d);
> > +
> > +    /* Handle call for current domain */
> > +    bool (*handle_call)(struct domain *d, void *regs);
> > +
> > +    /* Gets channel configuration and store it in domainconfig */
> > +    int (*get_channel_info)(void *sci_ops,
> > +                            struct xen_arch_domainconfig *config);
>=20
> get_channel_info is the only function I don't understand among these...
> what is supposed to be stored in struct xen_arch_domainconfig, just
> sci_agent_paddr?
>=20
> Also, it seems to be only called right after sci_domain_init, so can't
> the "get_channel_info" operation just be done as part of domain_init?
>=20

We need sci_agent_paddr for Domains. It represents shmem address which
should be mapped to guest Domain. We also don't need paddr when we do
sci_domain_init for dom0. That's why I've made it as separate call.

Also I named it get_channel_info, not get_channel_paddr, because
potentially, the different information can be needed from different SCI
implementation, which doesn't need shared memory to pass data for
exapmle.

>=20
>=20
> > +};
> > +
> > +struct sci_mediator_desc {
> > +    /* Printable name of the SCI. */
> > +    const char *name;
> > +
> > +    /* Mediator callbacks as described above. */
> > +    const struct sci_mediator_ops *ops;
> > +
> > +    /*
> > +     * ID of SCI. Corresponds to xen_arch_domainconfig.sci_type.
> > +     * Should be one of XEN_DOMCTL_CONFIG_SCI_xxx
> > +     */
> > +    uint16_t sci_type;
> > +
> > +    /* Match structure to init mediator */
> > +    const struct dt_device_match *dt_match;
> > +
> > +};
> > +
> > +int sci_domain_init(struct domain *d, uint16_t sci_type);
> > +void sci_domain_destroy(struct domain *d);
> > +int sci_add_dt_device(struct domain *d, struct dt_device_node *dev);
> > +int sci_relinquish_resources(struct domain *d);
> > +bool sci_handle_call(struct domain *d, void *args);
> > +int sci_get_channel_info(struct domain *d,
> > +                         struct xen_arch_domainconfig *config);
> > +uint16_t sci_get_type(void);
> > +
> > +#define REGISTER_SCI_MEDIATOR(_name, _namestr, _type, _match, _ops) \
> > +static const struct sci_mediator_desc __sci_desc_##_name __used     \
> > +__section(".scimediator.info") =3D {                                  =
\
> > +    .name =3D _namestr,                                               =
\
> > +    .ops =3D _ops,                                                    =
\
> > +    .sci_type =3D _type,                                              =
\
> > +    .dt_match =3D _match                                              =
\
> > +}
> > +
> > +#else
> > +#include <public/errno.h>
> > +
> > +static inline int sci_domain_init(struct domain *d, uint16_t sci_type)
> > +{
> > +    if ( likely(sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_NONE) )
> > +        return 0;
> > +
> > +    return -XEN_ENODEV;
> > +}
> > +
> > +static inline void sci_domain_destroy(struct domain *d)
> > +{
> > +}
> > +
> > +static inline int sci_add_dt_device(struct domain *d,
> > +                                    struct dt_device_node *dev)
> > +{
> > +    return 0;
> > +}
> > +
> > +static inline int sci_relinquish_resources(struct domain *d)
> > +{
> > +    return 0;
> > +}
> > +
> > +static inline bool sci_handle_call(struct domain *d, void *args)
> > +{
> > +    return false;
> > +}
> > +
> > +static inline int sci_get_channel_info(struct domain *d,
> > +                                       struct xen_arch_domainconfig *c=
onfig)
> > +{
> > +    return 0;
> > +}
> > +
> > +static inline uint16_t sci_get_type(void)
> > +{
> > +    return XEN_DOMCTL_CONFIG_SCI_NONE;
> > +}
> > +
> > +#endif  /* CONFIG_SCI */
> > +
> > +#endif /* __ASM_ARM_SCI_H */
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-ar=
m.h
> > index 94b31511dd..9180be5e86 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -314,12 +314,16 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> >  #define XEN_DOMCTL_CONFIG_TEE_NONE      0
> >  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> > =20
> > +#define XEN_DOMCTL_CONFIG_SCI_NONE      0
> > +
> >  struct xen_arch_domainconfig {
> >      /* IN/OUT */
> >      uint8_t gic_version;
> >      /* IN */
> >      uint16_t tee_type;
> >      /* IN */
> > +    uint8_t sci_type;
>=20
> sci_type is uint16_t everywhere else
>=20
>=20
> > +    /* IN */
> >      uint32_t nr_spis;
> >      /*
> >       * OUT
> > @@ -335,6 +339,12 @@ struct xen_arch_domainconfig {
> >       *
> >       */
> >      uint32_t clock_frequency;
> > +
> > +    /* Sets shared address to sw domains.
> > +     * This information is needed to set correct channel in Domain par=
tial
> > +     * device-tree
> > +     */
> > +    uint64_t sci_agent_paddr;
> >  };
> >  #endif /* __XEN__ || __XEN_TOOLS__ */
> =


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:53:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:53:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248613.428820 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCjS-0002aO-1T; Fri, 17 Dec 2021 12:53:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248613.428820; Fri, 17 Dec 2021 12:53:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCjR-0002aG-Ue; Fri, 17 Dec 2021 12:53:05 +0000
Received: by outflank-mailman (input) for mailman id 248613;
 Fri, 17 Dec 2021 12:53:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCjR-0002a7-Kf; Fri, 17 Dec 2021 12:53:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCjR-00032l-Hf; Fri, 17 Dec 2021 12:53:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCjR-0006Om-6E; Fri, 17 Dec 2021 12:53:05 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myCjR-00035K-5l; Fri, 17 Dec 2021 12:53:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WvAzZx9i3qXzKpGxx5q1CoOlBu79QvOnDZHngfxdxsQ=; b=DBnGktk8zKUfOu1Qgf7+HdBUlg
	Wuv36fLsPYRP+7U9dflr1TvVYOIlruRXJZXMupeBfiV0ug/X3eM/dbVESbXnJQwqizqljrrmKDfkg
	app0aJ4QTqrIcBdHxNL7dO5BYBo0XW1Y3vXMLXUmq7WlRYYRWx1ZhyPS7N6325p7Skm4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167452-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167452: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=29eb5c2c86f935b0e9700fad2ecfe8a32b011d57
X-Osstest-Versions-That:
    qemuu=e630bc7ec9dda656a452ed28cac4d1e9ed605d71
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 12:53:05 +0000

flight 167452 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167452/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167443

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167443
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167443
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167443
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167443
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167443
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167443
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167443
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167443
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                29eb5c2c86f935b0e9700fad2ecfe8a32b011d57
baseline version:
 qemuu                e630bc7ec9dda656a452ed28cac4d1e9ed605d71

Last test of basis   167443  2021-12-16 03:09:44 Z    1 days
Testing same since   167452  2021-12-16 20:09:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Cornelia Huck <cohuck@redhat.com>
  Evan Miller <emmiller@gmail.com>
  Jean-Philippe Brucker <jean-philippe@linaro.org>
  Maxim Levitsky <mlevitsk@redhat.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Yanan Wang <wangyanan55@huawei.com>
  Yang Zhong <yang.zhong@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   e630bc7ec9..29eb5c2c86  29eb5c2c86f935b0e9700fad2ecfe8a32b011d57 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 12:57:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 12:57:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248621.428831 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCnz-0003G9-LC; Fri, 17 Dec 2021 12:57:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248621.428831; Fri, 17 Dec 2021 12:57:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myCnz-0003G2-IJ; Fri, 17 Dec 2021 12:57:47 +0000
Received: by outflank-mailman (input) for mailman id 248621;
 Fri, 17 Dec 2021 12:57:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCny-0003Fs-Sk; Fri, 17 Dec 2021 12:57:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCny-00037w-PO; Fri, 17 Dec 2021 12:57:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myCny-0006ao-Dt; Fri, 17 Dec 2021 12:57:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myCny-00078E-DQ; Fri, 17 Dec 2021 12:57:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0k0QtSSUD8UGYFZX4k1Uc89wmm/E9dbo4zHcjXMyb7k=; b=MvjDw7WtFoCQ6D0WzCxO+7fzBf
	WSWD3OdNBMBGRn/VE5XPV+jE8DDNUR2APiL2Nles0cAu19/cLCsi0T6AOrp7lhnSVYyq3FgLQh0jT
	zqOd7we4n4ZUCn2w/TAh10YyL8JsiRdTfWY2QZQNDqEfJsiXBvLxcXavg/h3ZnHNILuE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167451-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167451: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fa36bbe6d43f3bbce1f10a187e153587c7584d83
X-Osstest-Versions-That:
    linux=2b14864acbaaf03d9c01982e243a84632524c3ac
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 12:57:46 +0000

flight 167451 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167451/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167438
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167438
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167438
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167438
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167438
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167438
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167438
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167438
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                fa36bbe6d43f3bbce1f10a187e153587c7584d83
baseline version:
 linux                2b14864acbaaf03d9c01982e243a84632524c3ac

Last test of basis   167438  2021-12-15 19:40:05 Z    1 days
Testing same since   167451  2021-12-16 19:11:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Catalin Marinas <catalin.marinas@arm.com>
  David Howells <dhowells@redhat.com>
  Joe Thornber <ejt@redhat.com>
  kafs-testing+fedora34_64checkkafs-build-300@auristor.com
  Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mike Snitzer <snitzer@redhat.com>
  Will Deacon <will@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2b14864acbaa..fa36bbe6d43f  fa36bbe6d43f3bbce1f10a187e153587c7584d83 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 13:23:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 13:23:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248633.428842 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDCj-00074l-SL; Fri, 17 Dec 2021 13:23:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248633.428842; Fri, 17 Dec 2021 13:23:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDCj-00074e-P4; Fri, 17 Dec 2021 13:23:21 +0000
Received: by outflank-mailman (input) for mailman id 248633;
 Fri, 17 Dec 2021 13:23:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myDCh-00074Y-NQ
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 13:23:20 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d60f464-5f3c-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 14:23:15 +0100 (CET)
Received: from pps.filterd (m0174683.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHD42cr026985;
 Fri, 17 Dec 2021 13:23:11 GMT
Received: from eur01-he1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2055.outbound.protection.outlook.com [104.47.0.55])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d0u3rg22k-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 13:23:10 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR2PR03MB5369.eurprd03.prod.outlook.com (2603:10a6:101:1c::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 13:23:06 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 13:23:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d60f464-5f3c-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Osna9QKuhhLrYAytJoNzxKwvzCFh58zHKMBoEr2RSJKPiF6j/b/9DD35qddd6XnL3G/3RZZ9P61boN5pXiFxG6NgavdyUDJKbgWriatDiEEgezpyPqJ8zVUgq5pzVurj5ZQFsJ2rkK5DfRl9uZIIwjLf3PNVBqz81mtxXypbZCkoNXhTYFbPE++YBQlcBpJuhnM2hg6tJWoc9tP5RIjqSGUusoBQ1T+QudYYYE6+AI7RDMiOc9qcCI2UtAupk/uX5T4v458qi/xbIRqJv+ldlYEU7Poz1HES+BXz16p957OQECusvBa3pNu6a6h9x5NRpggQvJBiVSEw4OcTkGMsLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UH+NjDhP/uEvllh6uMV2buh2S06FkrHsL1mjDSqY8EQ=;
 b=W3h4uua9YQoxsZZeltlY1He0uyYuzk8BVMIAm+27N/T+XdSiy5dAYYiafU7qcUH9jLZDLena1nrYrr9b9U1QyTibN0ApG0cYxaERO3w8OmT77nLxDFAixccn82k1uctNnhlZfAGL0Lid3zByc/RGLNof4/FGjdipVCnHvBiXbWAxPRVsZakv2q+cb/wEXInHP+HWP2CqYVf1kW0h5qTMkyQJFsLz9BrjhNXoO9EwOxoy7U624KzpnCEwzuICPAcXJ8Evni6IBNaOSo00ah67Mbb+HKCx/PBwC1UzKJkL2ajYJfQ5/uqdKgHyoxGioXLJPj0ZAmPhooo48AaqdmejcQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UH+NjDhP/uEvllh6uMV2buh2S06FkrHsL1mjDSqY8EQ=;
 b=ZpPkml/GRnDt8ypLTQccxL/5zpZdXGwjYakpAQAYrzpoTO6qUgPFb7A51V4WNA0muDR+1jLMBpp1xVt8PQ5qEYb3Qcal36UrVJIVLrcEKSj8Yiu7Nw4QMdTk1h/EQQj/FchvTTaKgHBYg7HdThm9uuOyegbjrzx/hGa2x/hhtHuVl2WlF8snuG6dhyLZhRkasCjfp86oAvo+w1hPoo57+ASse4I6F6jSyq/YM2xAMmOd5HKIcecH7KwTZwdVQLvIuE+TV4kXuiP3AB+CPPutfLGGfZWjDQn1BM34xNXgK5Dea7L66E+a8VSUxB31Jp99uWCxmot3OhFaWbHh1nSb8Q==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Oleksandr <olekstysh@gmail.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Stefano
 Stabellini <sstabellini@kernel.org>,
        Julien Grall <julien@xen.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw2ks6AgAAeBwA=
Date: Fri, 17 Dec 2021 13:23:06 +0000
Message-ID: <20211217132304.GA4041869@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
In-Reply-To: <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 19f1b16b-7efc-4cf3-8119-08d9c1605c83
x-ms-traffictypediagnostic: PR2PR03MB5369:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB5369AF18895A885356A73BF9E3789@PR2PR03MB5369.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 vJRdV0j/ONfzID9EnvbJ0pynZdLgEtTahPQsCQqxD0pvOmKPHsFJAFtKXpE1mi55BkrIk1KQORc341nw6RrAHxYi+9D9agPv21qU+75RjHK/elP2PJv1aJPAxPJAZXQwZOb39BLTyK32VdAovJHqCOGEiw3MPVt4FjHYFObQuVT+yPS4Ci4Z5eu+xQi+A2qt0JBUN9epgEjC4nQZv+VDUgkdUuD6S4ZO1z80GDQKEtH1/ro1VqjpmcddZZsLGxHoO04BBrUQiwdW4odXPXE+InMIqFXqipdzsuvodxt6v+YyXkaUhQ1khf4qSDrEAhQz3BxCIwpcmdlwjzigKoDOkhrD5w3970ieiPNcFHSYdn83p2KZaA4FHKq83AV3+N3ZmwVxyGJwFIyg9EZuxHbcmKnFwBwxn4fR7QmYxwQc36ssGDnzXCaLXYNUSs6ZVyz91K2GT6B+DSvfigjneu31LtijYuPOjMCAZZj3FxHQZa08rm9K+1Zo5/Nm1ww8JhPstEaR1fiiJ5/dEdb8fZb0ayDhNS7GArcz1lb7ohHgHiGtXlxYtgDCFvCmL87E12wlduhx6hOHIJHWnIlj8O3hws64SnWScIuDNn9DhH+N8sdhWra45E9tae0ZlO0DmYocSu1VgAxCyO/xCXPfyfclSsQTE4FIvo+imDhznd5u+9RJbV1OUhiDazppv1Dxh54jb49v19AlSz2Oo8IyDw7BcQKevg9aFI2FIV4Fw3mglic=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(508600001)(6486002)(91956017)(66946007)(5660300002)(6506007)(54906003)(4326008)(30864003)(53546011)(66556008)(66476007)(64756008)(83380400001)(66446008)(33656002)(76116006)(186003)(71200400001)(6512007)(38100700002)(9686003)(122000001)(1076003)(86362001)(26005)(8676002)(6916009)(316002)(8936002)(38070700005)(2906002)(33716001)(2004002)(559001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UENqM0ZzWnVsdEQzODJFK0M4alVBK2lqNVpPYXkxYjl6bi9GVjRMUEo2aDJp?=
 =?utf-8?B?V1NsZjVrbnZpK2s3ZkNKLzM5bFhHM2hBTVNkSlE4emk0Umo0cFFUd0ZTRzZJ?=
 =?utf-8?B?Ynl5U1UwRmxIMDQva3ZDNEpYc0l3aXhiMEt1Tko2VDB2WVZnWmxSUm1FRFFu?=
 =?utf-8?B?Z3RqaXZoOUhwNXptalNucGRpQWxlRTZ4M0RkUkVmM2duOEFEMzFjUUhIYStM?=
 =?utf-8?B?bzl3WVlOck9TcDdrRmkrSlB4Skk5M2NhKzBFcVl4VzBzbEVxbStFK3VCVC9O?=
 =?utf-8?B?YW9kZjJEU0J0MExuQi92SXdNeUt3bjFML1VKUUxWQ2ZOci9mamt3R3dFUSt6?=
 =?utf-8?B?NEpucmFZK0M0WXAvZ3I2dzdRK1paaTdPc01TcnRnR0ZTcDFITSt6ZjZjWlU0?=
 =?utf-8?B?ZGdkUUh0Q1lCZlVLaDZUMEplbnVtQUFadUdYODZraGkwWHkvRU91V1dESkh3?=
 =?utf-8?B?Z0ZONUhiVC9xT3J6WE45eDQrL0w3anVCSGZLL3hab1p2RWZMRWFUOFNNa3VK?=
 =?utf-8?B?N3gzazNIUnVlTE9ZcUdWZjJMa2RickhtNjhpR0FkcDcrU250dlFzeUJQd05q?=
 =?utf-8?B?UHZSUWlac1BTTjNWbXpCT0MyaGpFcHBHUm92dDl2ckp1V2tqMUZYVm9TVzBj?=
 =?utf-8?B?RHFoZHNTbEsyYXVwVVRBWkRTYStSc3I0MUw1S2syVGVpY3psZTRyc1lvb2pi?=
 =?utf-8?B?QytDVTAyRi9uQzVTZjhKdndNL3c3SHRVcUxmY0xQemhYRWUxcnhFSUx1MHBn?=
 =?utf-8?B?WEdwUlZkRllYeWppNUNxdytuWXoxZWdiYUgvVHlBWmJXMVBVMlJhcWl3NnVF?=
 =?utf-8?B?NjdNaFNjUzkrcGYvRkhxNXJlM0xmZHhSVUlhMGxadjlFTWdXeWRGYzd3aTNI?=
 =?utf-8?B?SzBIWnZNSkdpWmVKeXY2dk1PVnJSQ3VJemZEUDRGWlJYUlFEajlIMmFlS2hF?=
 =?utf-8?B?VmNkZHBPblhIZW9vZkpmcEtlb3ZaR1RkMjAxdmk5UHFIeHEzNW1RWmk1cm1W?=
 =?utf-8?B?dGhub1k3alkvZlBOY0VLWnZ6N3NhWEYxNlJCU084dytPNEVTQjJ1MTloUWd4?=
 =?utf-8?B?dU9QcHVBQXpJK3FwSlp4Vk9jaHU4cFhmRmE3LytCdjBSazFJbmhuVktWRmN4?=
 =?utf-8?B?QTgzczVqdWppbmVLUmZHU3NwcmJkcXlvY2RvYk5vV2FsNFExRUEzZXdzcndN?=
 =?utf-8?B?akM4VlRiNk9TTHh6dkJBMi9vdUFvelcvUUJKVDZnNlBWTEN1THJsT1dZRWZG?=
 =?utf-8?B?VVZJKzBHRjFHUmptQWVvc2g5YXBvTTVoV2R0WVNLSTl0a1BSTmVOeW1OSFg5?=
 =?utf-8?B?MkRVbHJtUitEYmVSSE9PdG91SEY3aTVkMDFJcWtxMzdtTldLNWFDOUdwN25H?=
 =?utf-8?B?Nmg1c0UwajkxL1U4NzhoaTU3NzdhR1VWTlBRazBvVXhLUElSRmNYRG9UNGdY?=
 =?utf-8?B?R2ZxanNHVG9weG9aQUVBQ2FtcmNKTzhldGdLd0lZL3dNdUVIWXV3S1hPYTlW?=
 =?utf-8?B?dnIrN3BEK1Bna1J1TFh6T0k0TnByaG10ZHFPU1UwQ21Wa2tTZk53NVAxNExZ?=
 =?utf-8?B?YjNzK1pkZFdMd294WTNFVExTZlk0dEpXWnFRSDB1VUlYckIySm9TL1ZRWmNQ?=
 =?utf-8?B?T2pPQlFlejA4cTRzY01CZmcwaDlNQ3l0UEhYa2VLZ254NnhCQkl4RFBRV0dr?=
 =?utf-8?B?MjVNaDE2YnIxcUhYc0F2QlZQTysrdE9NODFuVVBGRlVmcXdJWDk3RWhwdFl6?=
 =?utf-8?B?SkU1QjBZeUxnaDBuTlJYL2QxbVk5RlplN0Zjc0RQOGVNZUczMm9TRjhrNUor?=
 =?utf-8?B?VlFrRGcvWFdwQjhlTDVzb0RTZlhWaUh0YXJyK3RqOWgzMDNOMHVaL2xBTkEz?=
 =?utf-8?B?R2xzUVAzaFNqWjV4aWdUNG5LVHpBdUFxR1hwTi8ydjFndDhaWjVTeUsxSHVh?=
 =?utf-8?B?VjNnVlcvelpBZE16S2ZMUDYwRUpmbGFXenN3dHBYOUJRS3VCNjBIZGtmOFB0?=
 =?utf-8?B?L2o2b1RFR0w5VDRwd2lNdVpPTjZPcUUxcjlhWUhzckx5UGtWM0pZOHFIVUYr?=
 =?utf-8?B?NFllZzBhaFpZVVpqY0tCVEpaTTNIYlRRYXh2Q1FFRnhDQ1RicE1KVk5qbXJK?=
 =?utf-8?B?ZEJkL1puY2hGZytxWEhCOHRZdlJBZEVqL3VrNmoxSm52Rit1ZTNDU1I5Mk94?=
 =?utf-8?B?R1hjS3VFMXZHcXBWb3pJeWdGbVNaY3duTURzZiszTFVNbGszR3FOVDlkcW1P?=
 =?utf-8?Q?fPVaFKj+Va9l76JqWqaQWhn6ll0xM/P2ag60nj3u3U=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C061EBADB881514BBF62F21826599104@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19f1b16b-7efc-4cf3-8119-08d9c1605c83
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 13:23:06.1529
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jgZkt99MRw4EYRfzDX54j0tz0unng4W4ZLBbyME/wvFgvl8jGJfZYyLCfViDjB2rg8LyytnZqrZ7Oaoo+jXgaPrx9Dt3ozGkeeuqfErI1bM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5369
X-Proofpoint-GUID: UTKVOIKeEFeHB8uqCiATXt6SsmcqNj_n
X-Proofpoint-ORIG-GUID: UTKVOIKeEFeHB8uqCiATXt6SsmcqNj_n
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_04,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 malwarescore=0 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0
 phishscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 lowpriorityscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170077

SGkgT2xla3NhbmRyLA0KDQpPbiBGcmksIERlYyAxNywgMjAyMSBhdCAwMTozNTozNVBNICswMjAw
LCBPbGVrc2FuZHIgd3JvdGU6DQo+IA0KPiBPbiAxNC4xMi4yMSAxMTozNCwgT2xla3NpaSBNb2lz
aWVpZXYgd3JvdGU6DQo+IA0KPiANCj4gSGkgT2xla3NpaQ0KPiANCj4gPiBUaGlzIGlzIHRoZSBp
bXBsZW1lbnRhdGlvbiBvZiBTQ0kgaW50ZXJmYWNlLCBjYWxsZWQgU0NNSS1TTUMgZHJpdmVyLA0K
PiA+IHdoaWNoIHdvcmtzIGFzIHRoZSBtZWRpYXRvciBiZXR3ZWVuIFhFTiBEb21haW5zIGFuZCBG
aXJtd2FyZSAoU0NQLCBBVEYgZXRjKS4NCj4gPiBUaGlzIGFsbG93cyBkZXZpY2VzIGZyb20gdGhl
IERvbWFpbnMgdG8gd29yayB3aXRoIGNsb2NrcywgcmVzZXRzIGFuZA0KPiA+IHBvd2VyLWRvbWFp
bnMgd2l0aG91dCBhY2Nlc3MgdG8gQ1BHLg0KPiA+IA0KPiA+IFRoZSBmb2xsb3dpbmcgZmVhdHVy
ZXMgYXJlIGltcGxlbWVudGVkOg0KPiA+IC0gcmVxdWVzdCBTQ01JIGNoYW5uZWxzIGZyb20gQVRG
IGFuZCBwYXNzIGNoYW5uZWxzIHRvIERvbWFpbnM7DQo+ID4gLSBzZXQgZGV2aWNlIHBlcm1pc3Np
b25zIGZvciBEb21haW5zIGJhc2VkIG9uIHRoZSBEb21haW4gcGFydGlhbA0KPiA+IGRldmljZS10
cmVlLiBEZXZpY2VzIHdpdGggcGVybWlzc2lvbnMgYXJlIGFibGUgdG8gd29yayB3aXRoIGNsb2Nr
cywNCj4gPiByZXNldHMgYW5kIHBvd2VyLWRvbWFpbnMgdmlhIFNDTUk7DQo+ID4gLSByZWRpcmVj
dCBzY21pIG1lc3NhZ2VzIGZyb20gRG9tYWlucyB0byBBVEYuDQo+ID4gDQo+ID4gU2lnbmVkLW9m
Zi1ieTogT2xla3NpaSBNb2lzaWVpZXYgPG9sZWtzaWlfbW9pc2llaWV2QGVwYW0uY29tPg0KPiA+
IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL0tjb25maWcgICAgICAgICAgfCAgIDIgKw0KPiA+ICAg
eGVuL2FyY2gvYXJtL3NjaS9LY29uZmlnICAgICAgfCAgMTAgKw0KPiA+ICAgeGVuL2FyY2gvYXJt
L3NjaS9NYWtlZmlsZSAgICAgfCAgIDEgKw0KPiA+ICAgeGVuL2FyY2gvYXJtL3NjaS9zY21pX3Nt
Yy5jICAgfCA3OTUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPiA+ICAgeGVu
L2luY2x1ZGUvcHVibGljL2FyY2gtYXJtLmggfCAgIDEgKw0KPiA+ICAgNSBmaWxlcyBjaGFuZ2Vk
LCA4MDkgaW5zZXJ0aW9ucygrKQ0KPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2Fy
bS9zY2kvS2NvbmZpZw0KPiA+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9hcmNoL2FybS9zY2kv
c2NtaV9zbWMuYw0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBi
L3hlbi9hcmNoL2FybS9LY29uZmlnDQo+ID4gaW5kZXggMTg2ZTFkYjM4OS4uMDJkOTZjNmNmYyAx
MDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9hcmNo
L2FybS9LY29uZmlnDQo+ID4gQEAgLTExNCw2ICsxMTQsOCBAQCBjb25maWcgU0NJDQo+ID4gICAJ
ICBzdXBwb3J0LiBJdCBhbGxvd3MgZ3Vlc3RzIHRvIGNvbnRyb2wgc3lzdGVtIHJlc291cmNlc3Mg
dmlhIG9uZSBvZg0KPiA+ICAgCSAgU0NJIG1lZGlhdG9ycyBpbXBsZW1lbnRlZCBpbiBYRU4uDQo+
ID4gK3NvdXJjZSAiYXJjaC9hcm0vc2NpL0tjb25maWciDQo+ID4gKw0KPiA+ICAgZW5kbWVudQ0K
PiA+ICAgbWVudSAiQVJNIGVycmF0YSB3b3JrYXJvdW5kIHZpYSB0aGUgYWx0ZXJuYXRpdmUgZnJh
bWV3b3JrIg0KPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vc2NpL0tjb25maWcgYi94ZW4v
YXJjaC9hcm0vc2NpL0tjb25maWcNCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4
IDAwMDAwMDAwMDAuLjk1NjMwNjdkZGMNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIveGVu
L2FyY2gvYXJtL3NjaS9LY29uZmlnDQo+ID4gQEAgLTAsMCArMSwxMCBAQA0KPiA+ICtjb25maWcg
U0NNSV9TTUMNCj4gPiArCWJvb2wgIkVuYWJsZSBTQ01JLVNNQyBtZWRpYXRvciBkcml2ZXIiDQo+
ID4gKwlkZWZhdWx0IG4NCj4gPiArCWRlcGVuZHMgb24gU0NJDQo+ID4gKwktLS1oZWxwLS0tDQo+
ID4gKw0KPiA+ICsJRW5hYmxlcyBtZWRpYXRvciBpbiBYRU4gdG8gcGFzcyBTQ01JIHJlcXVlc3Rz
IGZyb20gRG9tYWlucyB0byBBVEYuDQo+ID4gKwlUaGlzIGZlYXR1cmUgYWxsb3dzIGRyaXZlcnMg
ZnJvbSBEb21haW5zIHRvIHdvcmsgd2l0aCBTeXN0ZW0NCj4gPiArCUNvbnRyb2xsZXJzIChzdWNo
IGFzIHBvd2VyLHJlc2V0cyxjbG9jayBldGMuKS4gU0NQIGlzIHVzZWQgYXMgdHJhbnNwb3J0DQo+
ID4gKwlmb3IgY29tbXVuaWNhdGlvbi4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3Nj
aS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9zY2kvTWFrZWZpbGUNCj4gPiBpbmRleCA4MzdkYzc0
OTJiLi42N2YyNjExODcyIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9zY2kvTWFrZWZp
bGUNCj4gPiArKysgYi94ZW4vYXJjaC9hcm0vc2NpL01ha2VmaWxlDQo+ID4gQEAgLTEgKzEsMiBA
QA0KPiA+ICAgb2JqLXkgKz0gc2NpLm8NCj4gPiArb2JqLSQoQ09ORklHX1NDTUlfU01DKSArPSBz
Y21pX3NtYy5vDQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYyBi
L3hlbi9hcmNoL2FybS9zY2kvc2NtaV9zbWMuYw0KPiA+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+
ID4gaW5kZXggMDAwMDAwMDAwMC4uMmViMDFlYTgyZA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiAr
KysgYi94ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMNCj4gPiBAQCAtMCwwICsxLDc5NSBAQA0K
PiA+ICsvKg0KPiA+ICsgKiB4ZW4vYXJjaC9hcm0vc2NpL3NjbWlfc21jLmMNCj4gPiArICoNCj4g
PiArICogU0NNSSBtZWRpYXRvciBkcml2ZXIsIHVzaW5nIFNDUCBhcyB0cmFuc3BvcnQuDQo+ID4g
KyAqDQo+ID4gKyAqIE9sZWtzaWkgTW9pc2llaWV2IDxvbGVrc2lpX21vaXNpZWlldkBlcGFtLmNv
bT4NCj4gPiArICogQ29weXJpZ2h0IChDKSAyMDIxLCBFUEFNIFN5c3RlbXMuDQo+ID4gKyAqDQo+
ID4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0
ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ID4gKyAqIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V
IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5DQo+ID4gKyAqIHRoZSBGcmVl
IFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9y
DQo+ID4gKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ID4gKyAqDQo+
ID4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdp
bGwgYmUgdXNlZnVsLA0KPiA+ICsgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg
ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZg0KPiA+ICsgKiBNRVJDSEFOVEFCSUxJVFkgb3Ig
RklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlDQo+ID4gKyAqIEdOVSBH
ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+ID4gKyAqLw0KPiA+ICsN
Cj4gPiArI2luY2x1ZGUgPGFzbS9zY2kvc2NpLmg+DQo+ID4gKyNpbmNsdWRlIDxhc20vc21jY2Mu
aD4NCj4gPiArI2luY2x1ZGUgPGFzbS9pby5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2JpdG9wcy5o
Pg0KPiA+ICsjaW5jbHVkZSA8eGVuL2NvbmZpZy5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3NjaGVk
Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vZGV2aWNlX3RyZWUuaD4NCj4gPiArI2luY2x1ZGUgPHhl
bi9pb2NhcC5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL2luaXQuaD4NCj4gPiArI2luY2x1ZGUgPHhl
bi9lcnIuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9saWIuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9s
aXN0Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vbW0uaD4NCj4gPiArI2luY2x1ZGUgPHhlbi9zdHJp
bmcuaD4NCj4gPiArI2luY2x1ZGUgPHhlbi90aW1lLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vdm1h
cC5oPg0KPiA+ICsNCj4gPiArI2RlZmluZSBTQ01JX0JBU0VfUFJPVE9DT0wgICAgICAgICAgICAg
ICAgICAweDEwDQo+ID4gKyNkZWZpbmUgU0NNSV9CQVNFX1BST1RPQ09MX0FUVElCVVRFUyAgICAg
ICAgMHgxDQo+ID4gKyNkZWZpbmUgU0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlMgICAg
MHg5DQo+ID4gKyNkZWZpbmUgU0NNSV9CQVNFX1JFU0VUX0FHRU5UX0NPTkZJR1VSQVRJT04gMHhC
DQo+ID4gKyNkZWZpbmUgU0NNSV9CQVNFX0RJU0NPVkVSX0FHRU5UICAgICAgICAgICAgMHg3DQo+
ID4gKw0KPiA+ICsvKiBTQ01JIHJldHVybiBjb2Rlcy4gU2VlIHNlY3Rpb24gNC4xLjQgb2YgU0NN
SSBzcGVjIChERU4wMDU2QykgKi8NCj4gPiArI2RlZmluZSBTQ01JX1NVQ0NFU1MgICAgICAgICAg
ICAgIDANCj4gPiArI2RlZmluZSBTQ01JX05PVF9TVVBQT1JURUQgICAgICAoLTEpDQo+ID4gKyNk
ZWZpbmUgU0NNSV9JTlZBTElEX1BBUkFNRVRFUlMgKC0yKQ0KPiA+ICsjZGVmaW5lIFNDTUlfREVO
SUVEICAgICAgICAgICAgICgtMykNCj4gPiArI2RlZmluZSBTQ01JX05PVF9GT1VORCAgICAgICAg
ICAoLTQpDQo+ID4gKyNkZWZpbmUgU0NNSV9PVVRfT0ZfUkFOR0UgICAgICAgKC01KQ0KPiA+ICsj
ZGVmaW5lIFNDTUlfQlVTWSAgICAgICAgICAgICAgICgtNikNCj4gPiArI2RlZmluZSBTQ01JX0NP
TU1TX0VSUk9SICAgICAgICAoLTcpDQo+ID4gKyNkZWZpbmUgU0NNSV9HRU5FUklDX0VSUk9SICAg
ICAgKC04KQ0KPiA+ICsjZGVmaW5lIFNDTUlfSEFSRFdBUkVfRVJST1IgICAgICgtOSkNCj4gPiAr
I2RlZmluZSBTQ01JX1BST1RPQ09MX0VSUk9SICAgICAoLTEwKQ0KPiA+ICsNCj4gPiArI2RlZmlu
ZSBEVF9NQVRDSF9TQ01JX1NNQyBEVF9NQVRDSF9DT01QQVRJQkxFKCJhcm0sc2NtaS1zbWMiKQ0K
PiA+ICsNCj4gPiArI2RlZmluZSBTQ01JX1NNQ19JRCAgICAgICAgICAgICAgICAgICAgICAgICJh
cm0sc21jLWlkIg0KPiA+ICsjZGVmaW5lIFNDTUlfU0hBUkVEX01FTU9SWSAgICAgICAgICAgICAg
ICAgImxpbnV4LHNjbWlfbWVtIg0KPiA+ICsjZGVmaW5lIFNDTUlfU0hNRU0gICAgICAgICAgICAg
ICAgICAgICAgICAgInNobWVtIg0KPiA+ICsNCj4gPiArI2RlZmluZSBIWVBfQ0hBTk5FTCAgICAg
ICAgICAgICAgICAgICAgICAgICAgMHgwDQo+ID4gKw0KPiA+ICsjZGVmaW5lIEhEUl9JRCAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgR0VOTUFTSyg3LDApDQo+ID4gKyNkZWZpbmUgSERSX1RZ
UEUgICAgICAgICAgICAgICAgICAgICAgICAgICBHRU5NQVNLKDksIDgpDQo+ID4gKyNkZWZpbmUg
SERSX1BST1RPICAgICAgICAgICAgICAgICAgICAgICAgICBHRU5NQVNLKDE3LCAxMCkNCj4gPiAr
DQo+ID4gKy8qIFNDTUkgcHJvdG9jb2wsIHJlZmVyIHRvIHNlY3Rpb24gNC4yLjIuMiAoREVOMDA1
NkMpICovDQo+ID4gKyNkZWZpbmUgTVNHX05fQUdFTlRTX01BU0sgICAgICAgICAgICAgICAgICBH
RU5NQVNLKDE1LCA4KQ0KPiA+ICsNCj4gPiArI2RlZmluZSBGSUVMRF9HRVQoX21hc2ssIF9yZWcp
XA0KPiA+ICsgICAgKCh0eXBlb2YoX21hc2spKSgoKF9yZWcpICYgKF9tYXNrKSkgPj4gKGZmczY0
KF9tYXNrKSAtIDEpKSkNCj4gPiArI2RlZmluZSBGSUVMRF9QUkVQKF9tYXNrLCBfdmFsKVwNCj4g
PiArICAgICgoKHR5cGVvZihfbWFzaykpKF92YWwpIDw8IChmZnM2NChfbWFzaykgLSAxKSkgJiAo
X21hc2spKQ0KPiA+ICsNCj4gPiArdHlwZWRlZiBzdHJ1Y3Qgc2NtaV9tc2dfaGVhZGVyIHsNCj4g
PiArICAgIHVpbnQ4X3QgaWQ7DQo+ID4gKyAgICB1aW50OF90IHR5cGU7DQo+ID4gKyAgICB1aW50
OF90IHByb3RvY29sOw0KPiA+ICt9IHNjbWlfbXNnX2hlYWRlcl90Ow0KPiA+ICsNCj4gPiArdHlw
ZWRlZiBzdHJ1Y3Qgc2NtaV9wZXJtc190eCB7DQo+ID4gKyAgICB1aW50MzJfdCBhZ2VudF9pZDsN
Cj4gPiArICAgIHVpbnQzMl90IGRldmljZV9pZDsNCj4gPiArICAgIHVpbnQzMl90IGZsYWdzOw0K
PiA+ICt9IHNjbWlfcGVybXNfdHhfdDsNCj4gPiArDQo+ID4gKyNkZWZpbmUgU0NNSV9TSE1FTV9D
SEFOX1NUQVRfQ0hBTk5FTF9GUkVFICAgQklUKDAsIFVMKQ0KPiA+ICsjZGVmaW5lIFNDTUlfU0hN
RU1fQ0hBTl9TVEFUX0NIQU5ORUxfRVJST1IgIEJJVCgxLCBVTCkNCj4gPiArDQo+ID4gKyNkZWZp
bmUgU0NNSV9BTExPV19BQ0NFU1MgICAgICAgICAgICAgICAgICAgQklUKDAsIFVMKQ0KPiA+ICsN
Cj4gPiArc3RydWN0IHNjbWlfc2hhcmVkX21lbSB7DQo+ID4gKyAgICB1aW50MzJfdCByZXNlcnZl
ZDsNCj4gPiArICAgIHVpbnQzMl90IGNoYW5uZWxfc3RhdHVzOw0KPiA+ICsgICAgdWludDMyX3Qg
cmVzZXJ2ZWQxWzJdOw0KPiA+ICsgICAgdWludDMyX3QgZmxhZ3M7DQo+ID4gKyAgICB1aW50MzJf
dCBsZW5ndGg7DQo+ID4gKyAgICB1aW50MzJfdCBtc2dfaGVhZGVyOw0KPiA+ICsgICAgdWludDhf
dCBtc2dfcGF5bG9hZFtdOw0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArc3RydWN0IHNjbWlfY2hhbm5l
bCB7DQo+ID4gKyAgICBpbnQgY2hhbl9pZDsNCj4gPiArICAgIGludCBhZ2VudF9pZDsNCj4gPiAr
ICAgIHVpbnQzMl90IGZ1bmNfaWQ7DQo+ID4gKyAgICBpbnQgZG9tYWluX2lkOw0KPiA+ICsgICAg
dWludDY0X3QgcGFkZHI7DQo+ID4gKyAgICBzdHJ1Y3Qgc2NtaV9zaGFyZWRfbWVtICpzaG1lbTsN
Cj4gPiArICAgIHNwaW5sb2NrX3QgbG9jazsNCj4gPiArICAgIHN0cnVjdCBsaXN0X2hlYWQgbGlz
dDsNCj4gPiArfTsNCj4gPiArDQo+ID4gK3N0cnVjdCBzY21pX2RhdGEgew0KPiA+ICsgICAgc3Ry
dWN0IGxpc3RfaGVhZCBjaGFubmVsX2xpc3Q7DQo+ID4gKyAgICBzcGlubG9ja190IGNoYW5uZWxf
bGlzdF9sb2NrOw0KPiA+ICsgICAgYm9vbCBpbml0aWFsaXplZDsNCj4gPiArICAgIHU2NCBzaG1l
bV9hZGRyLCBzaG1lbV9zaXplOw0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArc3RhdGljIHN0cnVjdCBz
Y21pX2RhdGEgc2NtaV9kYXRhOw0KPiA+ICsNCj4gPiArLyoNCj4gPiArICogcGFja19zY21pX2hl
YWRlcigpIC0gcGFja3MgYW5kIHJldHVybnMgMzItYml0IGhlYWRlcg0KPiA+ICsgKg0KPiA+ICsg
KiBAaGRyOiBwb2ludGVyIHRvIGhlYWRlciBjb250YWluaW5nIGFsbCB0aGUgaW5mb3JtYXRpb24g
b24gbWVzc2FnZSBpZCwNCj4gPiArICogICAgcHJvdG9jb2wgaWQgYW5kIHR5cGUgaWQuDQo+ID4g
KyAqDQo+ID4gKyAqIFJldHVybjogMzItYml0IHBhY2tlZCBtZXNzYWdlIGhlYWRlciB0byBiZSBz
ZW50IHRvIHRoZSBwbGF0Zm9ybS4NCj4gPiArICovDQo+ID4gK3N0YXRpYyBpbmxpbmUgdWludDMy
X3QgcGFja19zY21pX2hlYWRlcihzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPiA+ICt7DQo+ID4g
KyAgICByZXR1cm4gRklFTERfUFJFUChIRFJfSUQsIGhkci0+aWQpIHwNCj4gPiArICAgICAgICBG
SUVMRF9QUkVQKEhEUl9UWVBFLCBoZHItPnR5cGUpIHwNCj4gPiArICAgICAgICBGSUVMRF9QUkVQ
KEhEUl9QUk9UTywgaGRyLT5wcm90b2NvbCk7DQo+ID4gK30NCj4gPiArDQo+ID4gKy8qDQo+ID4g
KyAqIHVucGFja19zY21pX2hlYWRlcigpIC0gdW5wYWNrcyBhbmQgcmVjb3JkcyBtZXNzYWdlIGFu
ZCBwcm90b2NvbCBpZA0KPiA+ICsgKg0KPiA+ICsgKiBAbXNnX2hkcjogMzItYml0IHBhY2tlZCBt
ZXNzYWdlIGhlYWRlciBzZW50IGZyb20gdGhlIHBsYXRmb3JtDQo+ID4gKyAqIEBoZHI6IHBvaW50
ZXIgdG8gaGVhZGVyIHRvIGZldGNoIG1lc3NhZ2UgYW5kIHByb3RvY29sIGlkLg0KPiA+ICsgKi8N
Cj4gPiArc3RhdGljIGlubGluZSB2b2lkIHVucGFja19zY21pX2hlYWRlcih1aW50MzJfdCBtc2df
aGRyLCBzY21pX21zZ19oZWFkZXJfdCAqaGRyKQ0KPiA+ICt7DQo+ID4gKyAgICBoZHItPmlkID0g
RklFTERfR0VUKEhEUl9JRCwgbXNnX2hkcik7DQo+ID4gKyAgICBoZHItPnR5cGUgPSBGSUVMRF9H
RVQoSERSX1RZUEUsIG1zZ19oZHIpOw0KPiA+ICsgICAgaGRyLT5wcm90b2NvbCA9IEZJRUxEX0dF
VChIRFJfUFJPVE8sIG1zZ19oZHIpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5saW5l
IGludCBjaGFubmVsX2lzX2ZyZWUoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbl9pbmZvKQ0KPiA+
ICt7DQo+ID4gKyAgICByZXR1cm4gKCBjaGFuX2luZm8tPnNobWVtLT5jaGFubmVsX3N0YXR1cw0K
PiA+ICsgICAgICAgICAgICAmIFNDTUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxfRlJFRSApID8g
MCA6IC1FQlVTWTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBzZW5kX3NtY19tZXNz
YWdlKHN0cnVjdCBzY21pX2NoYW5uZWwgKmNoYW5faW5mbywNCj4gPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIHNjbWlfbXNnX2hlYWRlcl90ICpoZHIsIHZvaWQgKmRhdGEsIGludCBsZW4p
DQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBhcm1fc21jY2NfcmVzIHJlc3A7DQo+ID4gKyAgICBp
bnQgcmV0Ow0KPiA+ICsNCj4gPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IHN0YXR1
cyA9JWQgbGVuPSVkXG4iLA0KPiA+ICsgICAgICAgICAgIGNoYW5faW5mby0+c2htZW0tPmNoYW5u
ZWxfc3RhdHVzLCBsZW4pOw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogaGVh
ZGVyIGlkID0gJWQgdHlwZSA9ICVkLCBwcm90byA9ICVkXG4iLA0KPiA+ICsgICAgICAgICAgIGhk
ci0+aWQsIGhkci0+dHlwZSwgaGRyLT5wcm90b2NvbCk7DQo+ID4gKw0KPiA+ICsgICAgcmV0ID0g
Y2hhbm5lbF9pc19mcmVlKGNoYW5faW5mbyk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShy
ZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAgIGNoYW5faW5m
by0+c2htZW0tPmNoYW5uZWxfc3RhdHVzID0gMHgwOw0KPiA+ICsgICAgLyogV3JpdGluZyAweDAg
cmlnaHQgbm93LCBidXQgU0NNSV9TSE1FTV9GTEFHX0lOVFJfRU5BQkxFRCBjYW4gYmUgc2V0ICov
DQo+ID4gKyAgICBjaGFuX2luZm8tPnNobWVtLT5mbGFncyA9IDB4MDsNCj4gPiArICAgIGNoYW5f
aW5mby0+c2htZW0tPmxlbmd0aCA9IHNpemVvZihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVy
KSArIGxlbjsNCj4gPiArICAgIGNoYW5faW5mby0+c2htZW0tPm1zZ19oZWFkZXIgPSBwYWNrX3Nj
bWlfaGVhZGVyKGhkcik7DQo+ID4gKw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2Nt
aTogV3JpdGluZyB0byBzaG1lbSBhZGRyZXNzICVwXG4iLA0KPiA+ICsgICAgICAgICAgIGNoYW5f
aW5mby0+c2htZW0pOw0KPiA+ICsgICAgaWYgKCBsZW4gPiAwICYmIGRhdGEgKQ0KPiA+ICsgICAg
ICAgIG1lbWNweSgodm9pZCAqKShjaGFuX2luZm8tPnNobWVtLT5tc2dfcGF5bG9hZCksIGRhdGEs
IGxlbik7DQo+ID4gKw0KPiA+ICsgICAgYXJtX3NtY2NjX3NtYyhjaGFuX2luZm8tPmZ1bmNfaWQs
IDAsIDAsIDAsIDAsIDAsIDAsIGNoYW5faW5mby0+Y2hhbl9pZCwNCj4gPiArICAgICAgICAgICAg
ICAgICAgJnJlc3ApOw0KPiA+ICsNCj4gPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6
IHNjbWNjY19zbWMgcmVzcG9uc2UgJWRcbiIsIChpbnQpKHJlc3AuYTApKTsNCj4gPiArDQo+ID4g
KyAgICBpZiAoIHJlc3AuYTAgKQ0KPiA+ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsNCj4g
PiArDQo+ID4gKyAgICByZXR1cm4gMDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBj
aGVja19zY21pX3N0YXR1cyhpbnQgc2NtaV9zdGF0dXMpDQo+ID4gK3sNCj4gPiArICAgIGlmICgg
c2NtaV9zdGF0dXMgPT0gU0NNSV9TVUNDRVNTICkNCj4gPiArICAgICAgICByZXR1cm4gMDsNCj4g
PiArDQo+ID4gKyAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21pOiBFcnJvciByZWNlaXZlZDog
JWRcbiIsIHNjbWlfc3RhdHVzKTsNCj4gPiArDQo+ID4gKyAgICBzd2l0Y2ggKCBzY21pX3N0YXR1
cyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICBjYXNlIFNDTUlfTk9UX1NVUFBPUlRFRDoNCj4gPiAr
ICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7DQo+ID4gKyAgICBjYXNlIFNDTUlfSU5WQUxJRF9Q
QVJBTUVURVJTOg0KPiA+ICsgICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsgICAgY2FzZSBT
Q01JX0RFTklFRDoNCj4gPiArICAgICAgICByZXR1cm4gLUVBQ0NFUzsNCj4gPiArICAgIGNhc2Ug
U0NNSV9OT1RfRk9VTkQ6DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7DQo+ID4gKyAgICBj
YXNlIFNDTUlfT1VUX09GX1JBTkdFOg0KPiA+ICsgICAgICAgIHJldHVybiAtRVJBTkdFOw0KPiA+
ICsgICAgY2FzZSBTQ01JX0JVU1k6DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FQlVTWTsNCj4gPiAr
ICAgIGNhc2UgU0NNSV9DT01NU19FUlJPUjoNCj4gPiArICAgICAgICByZXR1cm4gLUVOT1RDT05O
Ow0KPiA+ICsgICAgY2FzZSBTQ01JX0dFTkVSSUNfRVJST1I6DQo+ID4gKyAgICAgICAgcmV0dXJu
IC1FSU87DQo+ID4gKyAgICBjYXNlIFNDTUlfSEFSRFdBUkVfRVJST1I6DQo+ID4gKyAgICAgICAg
cmV0dXJuIC1FTlhJTzsNCj4gPiArICAgIGNhc2UgU0NNSV9QUk9UT0NPTF9FUlJPUjoNCj4gPiAr
ICAgICAgICByZXR1cm4gLUVCQURNU0c7DQo+IA0KPiBQcm9iYWJseSB3ZSBzaG91bGQgYWRkIGEg
ZGVmYXVsdDogaGVyZT8NCj4gDQoNClRoYW5rcywgSSB3aWxsIGFkZCB0aGUgZGVmYXVsdCwgc28g
ZnVjbnRpb24gd2lsbCBsb29rIGxpa2UgdGhpczoNCnN0YXRpYyBpbnQgY2hlY2tfc2NtaV9zdGF0
dXMoaW50IHNjbWlfc3RhdHVzKQ0Kew0KICAgIC4uLg0KICAgIHN3aXRjaCAoIHNjbWlfc3RhdHVz
ICkNCiAgICB7DQogICAgICAgLi4uDQogICAgICAgZGVmYXVsdDoNCiAgICAgICAgICByZXR1cm4g
LUVJTlZBTDsNCiAgICB9DQp9DQoNCj4gDQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgcmV0
dXJuIC1FSU5WQUw7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBpbnQgZ2V0X3NtY19yZXNw
b25zZShzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFuX2luZm8sDQo+ID4gKyAgICAgICAgICAgICAg
ICAgICAgICAgICAgICBzY21pX21zZ19oZWFkZXJfdCAqaGRyLCB2b2lkICpkYXRhLCBpbnQgbGVu
KQ0KPiA+ICt7DQo+ID4gKyAgICBpbnQgcmVjdl9sZW47DQo+ID4gKyAgICBpbnQgcmV0Ow0KPiA+
ICsNCj4gPiArICAgIHByaW50ayhYRU5MT0dfREVCVUcgInNjbWk6IGdldCBzbWMgcmVzcG9uY2Ug
bXNnaWQgJWRcbiIsIGhkci0+aWQpOw0KPiA+ICsNCj4gPiArICAgIHJldCA9IGNoYW5uZWxfaXNf
ZnJlZShjaGFuX2luZm8pOw0KPiA+ICsgICAgaWYgKCBJU19FUlJfVkFMVUUocmV0KSApDQo+ID4g
KyAgICAgICAgcmV0dXJuIHJldDsNCj4gPiArDQo+ID4gKyAgICByZWN2X2xlbiA9IGNoYW5faW5m
by0+c2htZW0tPmxlbmd0aCAtIHNpemVvZihjaGFuX2luZm8tPnNobWVtLT5tc2dfaGVhZGVyKTsN
Cj4gPiArDQo+ID4gKyAgICBpZiAoIHJlY3ZfbGVuIDwgMCApDQo+ID4gKyAgICB7DQo+ID4gKyAg
ICAgICAgcHJpbnRrKFhFTkxPR19FUlINCj4gPiArICAgICAgICAgICAgICAgInNjbWk6IFdyb25n
IHNpemUgb2Ygc21jIG1lc3NhZ2UuIERhdGEgbWF5IGJlIGludmFsaWRcbiIpOw0KPiA+ICsgICAg
ICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIGlmICggcmVj
dl9sZW4gPiBsZW4gKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJS
DQo+ID4gKyAgICAgICAgICAgICAgICJzY21pOiBOb3QgZW5vdWdoIGJ1ZmZlciBmb3IgbWVzc2Fn
ZSAlZCwgZXhwZWN0aW5nICVkXG4iLA0KPiA+ICsgICAgICAgICAgICAgICByZWN2X2xlbiwgbGVu
KTsNCj4gPiArICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4g
KyAgICB1bnBhY2tfc2NtaV9oZWFkZXIoY2hhbl9pbmZvLT5zaG1lbS0+bXNnX2hlYWRlciwgaGRy
KTsNCj4gPiArDQo+ID4gKyAgICBpZiAoIHJlY3ZfbGVuID4gMCApDQo+ID4gKyAgICB7DQo+ID4g
KyAgICAgICAgbWVtY3B5KGRhdGEsIGNoYW5faW5mby0+c2htZW0tPm1zZ19wYXlsb2FkLCByZWN2
X2xlbik7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+ID4gK30NCj4g
PiArDQo+ID4gK3N0YXRpYyBpbnQgZG9fc21jX3hmZXIoc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hh
bm5lbCwgc2NtaV9tc2dfaGVhZGVyX3QgKmhkciwgdm9pZCAqdHhfZGF0YSwgaW50IHR4X3NpemUs
DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgdm9pZCAqcnhfZGF0YSwgaW50IHJ4X3NpemUp
DQo+ID4gK3sNCj4gPiArICAgIGludCByZXQgPSAwOw0KPiA+ICsNCj4gPiArICAgIGlmICggIWhk
ciApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsgICAgc3Bpbl9s
b2NrKCZjaGFubmVsLT5sb2NrKTsNCj4gPiArDQo+ID4gKyAgICByZXQgPSBzZW5kX3NtY19tZXNz
YWdlKGNoYW5uZWwsIGhkciwgdHhfZGF0YSwgdHhfc2l6ZSk7DQo+ID4gKyAgICBpZiAoIHJldCAp
DQo+ID4gKyAgICAgICAgZ290byBjbGVhbjsNCj4gPiArDQo+ID4gKyAgICByZXQgPSBnZXRfc21j
X3Jlc3BvbnNlKGNoYW5uZWwsIGhkciwgcnhfZGF0YSwgcnhfc2l6ZSk7DQo+ID4gK2NsZWFuOg0K
PiA+ICsgICAgc3Bpbl91bmxvY2soJmNoYW5uZWwtPmxvY2spOw0KPiA+ICsNCj4gPiArICAgIHJl
dHVybiByZXQ7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVs
ICpnZXRfY2hhbm5lbF9ieV9pZCh1aW50OF90IGNoYW5faWQpDQo+ID4gK3sNCj4gPiArICAgIHN0
cnVjdCBzY21pX2NoYW5uZWwgKmN1cnI7DQo+ID4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+
ID4gKw0KPiA+ICsgICAgc3Bpbl9sb2NrKCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0K
PiA+ICsgICAgbGlzdF9mb3JfZWFjaF9lbnRyeShjdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlz
dCwgbGlzdCkNCj4gPiArICAgICAgICBpZiAoIGN1cnItPmNoYW5faWQgPT0gY2hhbl9pZCApDQo+
ID4gKyAgICAgICAgew0KPiA+ICsgICAgICAgICAgICBmb3VuZCA9IHRydWU7DQo+ID4gKyAgICAg
ICAgICAgIGJyZWFrOw0KPiA+ICsgICAgICAgIH0NCj4gPiArDQo+ID4gKyAgICBzcGluX3VubG9j
aygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArICAgIGlmICggZm91bmQgKQ0K
PiA+ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiBOVUxMOw0K
PiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgc3RydWN0IHNjbWlfY2hhbm5lbCAqZ2V0X2NoYW5u
ZWxfYnlfZG9tYWluKHVpbnQ4X3QgZG9tYWluX2lkKQ0KPiA+ICt7DQo+ID4gKyAgICBzdHJ1Y3Qg
c2NtaV9jaGFubmVsICpjdXJyOw0KPiA+ICsgICAgYm9vbCBmb3VuZCA9IGZhbHNlOw0KPiA+ICsN
Cj4gPiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiAr
ICAgIGxpc3RfZm9yX2VhY2hfZW50cnkoY3VyciwgJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QsIGxp
c3QpDQo+ID4gKyAgICAgICAgaWYgKCBjdXJyLT5kb21haW5faWQgPT0gZG9tYWluX2lkICkNCj4g
PiArICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIGZvdW5kID0gdHJ1ZTsNCj4gPiArICAgICAg
ICAgICAgYnJlYWs7DQo+ID4gKyAgICAgICAgfQ0KPiA+ICsNCj4gPiArICAgIHNwaW5fdW5sb2Nr
KCZzY21pX2RhdGEuY2hhbm5lbF9saXN0X2xvY2spOw0KPiA+ICsgICAgaWYgKCBmb3VuZCApDQo+
ID4gKyAgICAgICAgcmV0dXJuIGN1cnI7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIE5VTEw7DQo+
ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgc2NtaV9jaGFubmVsICphcXVpcmVfc2Nt
aV9jaGFubmVsKGludCBkb21haW5faWQpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVjdCBzY21pX2No
YW5uZWwgKmN1cnI7DQo+ID4gKyAgICBib29sIGZvdW5kID0gZmFsc2U7DQo+ID4gKw0KPiA+ICsg
ICAgQVNTRVJUKGRvbWFpbl9pZCAhPSBET01JRF9JTlZBTElEICYmIGRvbWFpbl9pZCA+PSAwKTsN
Cj4gPiArDQo+ID4gKyAgICBzcGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7
DQo+ID4gKyAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KGN1cnIsICZzY21pX2RhdGEuY2hhbm5lbF9s
aXN0LCBsaXN0KQ0KPiA+ICsgICAgICAgIGlmICggKGN1cnItPmRvbWFpbl9pZCA9PSBET01JRF9J
TlZBTElEKQ0KPiA+ICsgICAgICAgICAgICAmJiAoY3Vyci0+Y2hhbl9pZCAhPSBIWVBfQ0hBTk5F
TCkgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgY3Vyci0+ZG9tYWluX2lkID0g
ZG9tYWluX2lkOw0KPiA+ICsgICAgICAgICAgICBmb3VuZCA9IHRydWU7DQo+ID4gKyAgICAgICAg
ICAgIGJyZWFrOw0KPiA+ICsgICAgICAgIH0NCj4gPiArDQo+ID4gKyAgICBzcGluX3VubG9jaygm
c2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArICAgIGlmICggZm91bmQgKQ0KPiA+
ICsgICAgICAgIHJldHVybiBjdXJyOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiBOVUxMOw0KPiA+
ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCByZWxpbnF1aXNoX3NjbWlfY2hhbm5lbChzdHJ1
Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsKQ0KPiA+ICt7DQo+ID4gKyAgICBzcGluX2xvY2soJnNj
bWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKyAgICBBU1NFUlQoY2hhbm5lbCAhPSBO
VUxMKTsNCj4gPiArICAgIGNoYW5uZWwtPmRvbWFpbl9pZCA9IERPTUlEX0lOVkFMSUQ7DQo+ID4g
KyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArfQ0K
PiA+ICsNCj4gPiArc3RhdGljIHN0cnVjdCBzY21pX2NoYW5uZWwgKnNtY19jcmVhdGVfY2hhbm5l
bCh1aW50OF90IGNoYW5faWQsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgdWludDMyX3QgZnVuY19pZCwgdWludDY0X3QgYWRkcikNCj4gPiArew0K
PiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hhbm5lbDsNCj4gPiArICAgIG1mbl90IG1m
bjsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsID0gZ2V0X2NoYW5uZWxfYnlfaWQoY2hhbl9pZCk7
DQo+ID4gKyAgICBpZiAoIGNoYW5uZWwgKQ0KPiA+ICsgICAgICAgIHJldHVybiBFUlJfUFRSKEVF
WElTVCk7DQo+ID4gKw0KPiA+ICsgICAgY2hhbm5lbCA9IHhtYWxsb2Moc3RydWN0IHNjbWlfY2hh
bm5lbCk7DQo+ID4gKyAgICBpZiAoICFjaGFubmVsICkNCj4gPiArICAgICAgICByZXR1cm4gRVJS
X1BUUihFTk9NRU0pOw0KPiA+ICsNCj4gPiArICAgIGNoYW5uZWwtPmNoYW5faWQgPSBjaGFuX2lk
Ow0KPiA+ICsgICAgY2hhbm5lbC0+ZnVuY19pZCA9IGZ1bmNfaWQ7DQo+ID4gKyAgICBjaGFubmVs
LT5kb21haW5faWQgPSBET01JRF9JTlZBTElEOw0KPiA+ICsgICAgbWZuID0gbWFkZHJfdG9fbWZu
KGFkZHIpOw0KPiA+ICsgICAgY2hhbm5lbC0+c2htZW0gPSB2bWFwKCZtZm4sIDEpOw0KPiA+ICsg
ICAgaWYgKCAhY2hhbm5lbC0+c2htZW0gKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHhmcmVl
KGNoYW5uZWwpOw0KPiA+ICsgICAgICAgIHJldHVybiBFUlJfUFRSKEVOT01FTSk7DQo+ID4gKyAg
ICB9DQo+ID4gKw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogR290IHNobWVt
IGFmdGVyIHZtYXAgJXBcbiIsIGNoYW5uZWwtPnNobWVtKTsNCj4gPiArICAgIGNoYW5uZWwtPnBh
ZGRyID0gYWRkcjsNCj4gPiArICAgIGNoYW5uZWwtPnNobWVtLT5jaGFubmVsX3N0YXR1cyA9IFND
TUlfU0hNRU1fQ0hBTl9TVEFUX0NIQU5ORUxfRlJFRTsNCj4gPiArICAgIHNwaW5fbG9ja19pbml0
KCZjaGFubmVsLT5sb2NrKTsNCj4gPiArICAgIHNwaW5fbG9jaygmc2NtaV9kYXRhLmNoYW5uZWxf
bGlzdF9sb2NrKTsNCj4gPiArICAgIGxpc3RfYWRkKCZjaGFubmVsLT5saXN0LCAmc2NtaV9kYXRh
LmNoYW5uZWxfbGlzdCk7DQo+ID4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNoYW5uZWxf
bGlzdF9sb2NrKTsNCj4gPiArICAgIHJldHVybiBjaGFubmVsOw0KPiA+ICt9DQo+ID4gKw0KPiA+
ICtzdGF0aWMgaW50IG1hcF9tZW1vcnlfdG9fZG9tYWluKHN0cnVjdCBkb21haW4gKmQsIHVpbnQ2
NF90IGFkZHIsIHVpbnQ2NF90IGxlbikNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIGlvbWVtX3Bl
cm1pdF9hY2Nlc3MoZCwgcGFkZHJfdG9fcGZuKGFkZHIpLA0KPiA+ICsgICAgICAgICAgICAgICAg
cGFkZHJfdG9fcGZuKFBBR0VfQUxJR04oYWRkciArIGxlbiAtMSkpKTsNCj4gPiArfQ0KPiA+ICsN
Cj4gPiArc3RhdGljIGludCB1bm1hcF9tZW1vcnlfZnJvbV9kb21haW4oc3RydWN0IGRvbWFpbiAq
ZCwgdWludDY0X3QgYWRkciwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIHVpbnQ2NF90IGxlbikNCj4gPiArew0KPiA+ICsgICAgcmV0dXJuIGlvbWVtX2RlbnlfYWNj
ZXNzKGQsIHBhZGRyX3RvX3BmbihhZGRyKSwNCj4gPiArICAgICAgICAgICAgICAgIHBhZGRyX3Rv
X3BmbihQQUdFX0FMSUdOKGFkZHIgKyBsZW4gLTEpKSk7DQo+ID4gK30NCj4gDQo+IEkgd29uZGVy
LCB3aHkgd2UgbmVlZCBhbiBleHRyYSBsZXZlbCBvZiBpbmRpcmVjdGlvbiBoZXJlLiBBbmQgaWYg
dGhpcyBpcw0KPiByZWFsbHkgbmVlZGVkLCBJIHdvbmRlciB3aHkgbWFwKHVubWFwKV9tZW1vcnkq
IG5hbWUgd2FzIGNob3NlbiwgYXMgdGhlcmUgaXMNCj4gbm8gbWVtb3J5IG1hcHBpbmcvdW5tYXBw
aW5nIHJlYWxseSBoYXBwZW5zIGhlcmUuDQo+IA0KDQpJJ3ZlIGFkZGVkIGV4dHJhIGluZGlyZWN0
aW9uIHRvIGhpZGUgbWF0aCBsaWtlDQpwYWRkcl90b19wZm4oUEFHRV9BTElHTihhZGRyICsgbGVu
IC0xKQ0Kc28geW91IGRvbid0IGhhdmUgdG8gbWF0aCBpbiBlYWNoIGNhbGwuIHVubWFwX21lbW9y
eV9mcm9tX2RvbWFpbiBjYWxsZWQNCmZyb20gMiBwbGFjZXMsIHNvIEkgbW92ZWQgYm90aCBjYWxs
cyB0byBzZXBhcmF0ZSBmdW5jdGlvbi4NCkFsdGhvdWdoLCBJIGFncmVlIHRoYXQgbWFwL3VubWFw
IGlzIG5vdCBwZXJmZWN0IG5hbWUuIEkgY29uc2lkZXINCnJlbmFtaW5nIGl0IHRvIG1lbV9wZXJt
aXRfYWNjZXMgYW5kIG1hbV9kZW55X2FjY2Vzcy4NCg0KPiANCj4gPiArDQo+ID4gK3N0YXRpYyBp
bnQgZHRfdXBkYXRlX2RvbWFpbl9yYW5nZShzdHJ1Y3QgZG9tYWluICpkLCB1aW50NjRfdCBhZGRy
LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3Qgc2l6ZSkN
Cj4gDQo+IExvb2tzIGxpa2UgKmQgaXMgbm90IHVzZWQgaW4gdGhpcyBmdW5jdGlvbi4NCj4NCg0K
WWVwIEkgd2lsbCByZW1vdmUgaXQuIFRoYW5rcy4NCg0KPiANCj4gPiArew0KPiA+ICsgICAgc3Ry
dWN0IGR0X2RldmljZV9ub2RlICpzaG1lbV9ub2RlOw0KPiA+ICsgICAgX19iZTMyICpod19yZWc7
DQo+ID4gKyAgICBjb25zdCBzdHJ1Y3QgZHRfcHJvcGVydHkgKnBwOw0KPiA+ICsgICAgdWludDMy
X3QgbGVuOw0KPiA+ICsNCj4gPiArICAgIHNobWVtX25vZGUgPSBkdF9maW5kX2NvbXBhdGlibGVf
bm9kZShOVUxMLCBOVUxMLCAiYXJtLHNjbWktc2htZW0iKTsNCj4gPiArDQo+ID4gKyAgICBpZiAo
ICFzaG1lbV9ub2RlICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VS
UiAic2NtaTogVW5hYmxlIHRvIGZpbmQgJXMgbm9kZSBpbiBEVFxuIiwgU0NNSV9TSE1FTSk7DQo+
ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0KPiA+ICsgICAg
cHAgPSBkdF9maW5kX3Byb3BlcnR5KHNobWVtX25vZGUsICJyZWciLCAmbGVuKTsNCj4gPiArICAg
IGlmICggIXBwICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAi
c2NtaTogVW5hYmxlIHRvIGZpbmQgcmVncyBlbnRyeSBpbiBzaG1lbSBub2RlXG4iKTsNCj4gPiAr
ICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAgICBod19y
ZWcgPSBwcC0+dmFsdWU7DQo+ID4gKyAgICBkdF9zZXRfcmFuZ2UoJmh3X3JlZywgc2htZW1fbm9k
ZSwgYWRkciwgc2l6ZSk7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+ID4gK30NCj4gPiAr
DQo+ID4gK3N0YXRpYyB2b2lkIGZyZWVfY2hhbm5lbF9saXN0KHZvaWQpDQo+ID4gK3sNCj4gPiAr
ICAgIHN0cnVjdCBzY21pX2NoYW5uZWwgKmN1cnIsICpfY3VycjsNCj4gPiArDQo+ID4gKyAgICBz
cGluX2xvY2soJnNjbWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKyAgICBsaXN0X2Zv
cl9lYWNoX2VudHJ5X3NhZmUgKGN1cnIsIF9jdXJyLCAmc2NtaV9kYXRhLmNoYW5uZWxfbGlzdCwg
bGlzdCkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICB2dW5tYXAoY3Vyci0+c2htZW0pOw0KPiA+
ICsgICAgICAgIGxpc3RfZGVsKCZjdXJyLT5saXN0KTsNCj4gPiArICAgICAgICB4ZnJlZShjdXJy
KTsNCj4gPiArICAgIH0NCj4gPiArDQo+ID4gKyAgICBzcGluX3VubG9jaygmc2NtaV9kYXRhLmNo
YW5uZWxfbGlzdF9sb2NrKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIF9faW5pdCBib29s
IHNjbWlfcHJvYmUoc3RydWN0IGR0X2RldmljZV9ub2RlICpzY21pX25vZGUpDQo+IA0KPiANCj4g
R2VuZXJpYyBxdWVzdGlvbiB0byBjb25zaWRlciAuLi4NCj4gSWYgcHJvYmUgZmFpbHMgZm9yIHNv
bWUgcmVhc29uIChzbyB3ZSBjYW5ub3QgdXNlIG1lZGlhdG9yIGluIFhlbikgd2hhdA0KPiBzaG91
bGQgd2UgZG8gd2l0aCBTQ01JIG5vZGVzIGluIGRvbWFpbidzIGRldmljZS10cmVlIChsZWF2ZSBh
cyBpcywgZHJvcCwNCj4gZXRjKT8NCj4gDQoNCklmIHByb2JlIGZhaWxzIC0gdGhlbiB0aGUgZGV2
aWNlcywgd2hpY2ggd2VyZSBjb25maWd1cmVkIHRvIHVzZSBzY21pDQpjbG9ja3NccmVzZXRzXHBv
d2VyLWRvbWFpbnMgd2lsbCBub3Qgd29yayBwcm9wZXJseS4gSWYgRG9tYWluDQpjb25maWd1cmF0
aW9uIGRvIG5vdCB1c2UgU0NNSSAtIHRoZW4gaXQgd2lsbCBub3QgaGF2ZSB0aGUgc2NtaSBub2Rl
Lg0KU28gZnJvbSBteSBzdGFuZHBvaW50LCBubyBhZGRpdGlvbmFsIGNoZWNrIGlzIG5lZWRlZCBi
ZWZvcmUgY29weWluZyBzY21pDQpub2RlcyB0byBEb21haW4gZGV2aWNlLXRyZWUuDQoNCj4gDQo+
ID4gK3sNCj4gPiArICAgIHN0cnVjdCBkdF9kZXZpY2Vfbm9kZSAqc2htZW1fbm9kZTsNCj4gPiAr
ICAgIGludCByZXQsIGk7DQo+ID4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsLCAq
YWdlbnRfY2hhbm5lbDsNCj4gPiArICAgIGludCBuX2FnZW50czsNCj4gPiArICAgIHNjbWlfbXNn
X2hlYWRlcl90IGhkcjsNCj4gPiArICAgIHN0cnVjdCByeF90IHsNCj4gPiArICAgICAgICBpbnQz
Ml90IHN0YXR1czsNCj4gPiArICAgICAgICB1aW50MzJfdCBhdHRyaWJ1dGVzOw0KPiA+ICsgICAg
fSByeDsNCj4gPiArDQo+ID4gKyAgICB1aW50MzJfdCBmdW5jX2lkOw0KPiA+ICsNCj4gPiArICAg
IEFTU0VSVChzY21pX25vZGUgIT0gTlVMTCk7DQo+ID4gKw0KPiA+ICsgICAgSU5JVF9MSVNUX0hF
QUQoJnNjbWlfZGF0YS5jaGFubmVsX2xpc3QpOw0KPiA+ICsgICAgc3Bpbl9sb2NrX2luaXQoJnNj
bWlfZGF0YS5jaGFubmVsX2xpc3RfbG9jayk7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhZHRfcHJv
cGVydHlfcmVhZF91MzIoc2NtaV9ub2RlLCBTQ01JX1NNQ19JRCwgJmZ1bmNfaWQpICkNCj4gPiAr
ICAgIHsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0VSUiAic2NtaTogVW5hYmxlIHRvIHJl
YWQgc21jLWlkIGZyb20gRFRcbiIpOw0KPiA+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiAr
ICAgIH0NCj4gPiArDQo+ID4gKyAgICBzaG1lbV9ub2RlID0gZHRfZmluZF9ub2RlX2J5X25hbWUo
TlVMTCwgU0NNSV9TSEFSRURfTUVNT1JZKTsNCj4gPiArICAgIGlmICggSVNfRVJSX09SX05VTEwo
c2htZW1fbm9kZSkgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJS
DQo+ID4gKyAgICAgICAgICAgICAgICJzY21pOiBEZXZpY2UgdHJlZSBlcnJvciwgY2FuJ3QgcGFy
c2Ugc2htZW0gcGhhbmRsZSAlbGRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgIFBUUl9FUlIoc2ht
ZW1fbm9kZSkpOw0KPiA+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gPiArICAgIH0NCj4gPiAr
DQo+ID4gKyAgICByZXQgPSBkdF9kZXZpY2VfZ2V0X2FkZHJlc3Moc2htZW1fbm9kZSwgMCwgJnNj
bWlfZGF0YS5zaG1lbV9hZGRyLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICZzY21pX2RhdGEuc2htZW1fc2l6ZSk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQp
ICkNCj4gPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ID4gKw0KPiA+ICsgICAgY2hhbm5lbCA9
IHNtY19jcmVhdGVfY2hhbm5lbChIWVBfQ0hBTk5FTCwgZnVuY19pZCwgc2NtaV9kYXRhLnNobWVt
X2FkZHIpOw0KPiA+ICsgICAgaWYgKCBJU19FUlIoY2hhbm5lbCkgKQ0KPiA+ICsgICAgICAgIHJl
dHVybiBmYWxzZTsNCj4gPiArDQo+ID4gKyAgICBoZHIuaWQgPSBTQ01JX0JBU0VfUFJPVE9DT0xf
QVRUSUJVVEVTOw0KPiA+ICsgICAgaGRyLnR5cGUgPSAwOw0KPiA+ICsgICAgaGRyLnByb3RvY29s
ID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+ICsNCj4gPiArICAgIHJldCA9IGRvX3NtY194ZmVy
KGNoYW5uZWwsICZoZHIsIE5VTEwsIDAsICZyeCwgc2l6ZW9mKHJ4KSk7DQo+ID4gKyAgICBpZiAo
IHJldCApDQo+ID4gKyAgICAgICAgZ290byBjbGVhbjsNCj4gPiArDQo+ID4gKyAgICByZXQgPSBj
aGVja19zY21pX3N0YXR1cyhyeC5zdGF0dXMpOw0KPiA+ICsgICAgaWYgKCByZXQgKQ0KPiA+ICsg
ICAgICAgIGdvdG8gY2xlYW47DQo+ID4gKw0KPiA+ICsgICAgbl9hZ2VudHMgPSBGSUVMRF9HRVQo
TVNHX05fQUdFTlRTX01BU0ssIHJ4LmF0dHJpYnV0ZXMpOw0KPiA+ICsgICAgcHJpbnRrKFhFTkxP
R19ERUJVRyAic2NtaTogR290IGFnZW50IGNvdW50ICVkXG4iLCBuX2FnZW50cyk7DQo+ID4gKw0K
PiA+ICsgICAgbl9hZ2VudHMgPSAobl9hZ2VudHMgPiBzY21pX2RhdGEuc2htZW1fc2l6ZSAvIFBB
R0VfU0laRSkgPw0KPiA+ICsgICAgICAgIHNjbWlfZGF0YS5zaG1lbV9zaXplIC8gUEFHRV9TSVpF
IDogbl9hZ2VudHM7DQo+ID4gKw0KPiA+ICsgICAgZm9yICggaSA9IDE7IGkgPCBuX2FnZW50czsg
aSsrICkNCj4gPiArICAgIHsNCj4gPiArICAgICAgICB1aW50MzJfdCB0eF9hZ2VudF9pZCA9IDB4
RkZGRkZGRkY7DQo+ID4gKyAgICAgICAgc3RydWN0IHsNCj4gPiArICAgICAgICAgICAgaW50MzJf
dCBzdGF0dXM7DQo+ID4gKyAgICAgICAgICAgIHVpbnQzMl90IGFnZW50X2lkOw0KPiA+ICsgICAg
ICAgICAgICBjaGFyIG5hbWVbMTZdOw0KPiA+ICsgICAgICAgIH0gZGFfcng7DQo+ID4gKw0KPiA+
ICsgICAgICAgIGFnZW50X2NoYW5uZWwgPSBzbWNfY3JlYXRlX2NoYW5uZWwoaSwgZnVuY19pZCwg
c2NtaV9kYXRhLnNobWVtX2FkZHIgKw0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgaSAqIFBBR0VfU0laRSk7DQo+ID4gKyAgICAgICAgaWYgKCBJU19FUlIo
YWdlbnRfY2hhbm5lbCkgKQ0KPiA+ICsgICAgICAgIHsNCj4gPiArICAgICAgICAgICAgcmV0ID0g
UFRSX0VSUihhZ2VudF9jaGFubmVsKTsNCj4gPiArICAgICAgICAgICAgZ290byBjbGVhbjsNCj4g
PiArICAgICAgICB9DQo+ID4gKw0KPiA+ICsgICAgICAgIGhkci5pZCA9IFNDTUlfQkFTRV9ESVND
T1ZFUl9BR0VOVDsNCj4gPiArICAgICAgICBoZHIudHlwZSA9IDA7DQo+ID4gKyAgICAgICAgaGRy
LnByb3RvY29sID0gU0NNSV9CQVNFX1BST1RPQ09MOw0KPiA+ICsNCj4gPiArICAgICAgICByZXQg
PSBkb19zbWNfeGZlcihhZ2VudF9jaGFubmVsLCAmaGRyLCAmdHhfYWdlbnRfaWQsDQo+ID4gKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKHR4X2FnZW50X2lkKSwgJmRhX3J4LCBzaXpl
b2YoZGFfcngpKTsNCj4gPiArICAgICAgICBpZiAoIHJldCApDQo+ID4gKyAgICAgICAgICAgIGdv
dG8gY2xlYW47DQo+ID4gKw0KPiA+ICsgICAgICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKGRh
X3J4LnN0YXR1cyk7DQo+ID4gKyAgICAgICAgaWYgKCByZXQgKQ0KPiA+ICsgICAgICAgICAgICBn
b3RvIGNsZWFuOw0KPiA+ICsNCj4gPiArICAgICAgICBwcmludGsoWEVOTE9HX0RFQlVHICJzY21p
OiBzdGF0dXM9MHgleCBpZD0weCV4IG5hbWU9JXNcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICBk
YV9yeC5zdGF0dXMsIGRhX3J4LmFnZW50X2lkLCBkYV9yeC5uYW1lKTsNCj4gPiArDQo+ID4gKyAg
ICAgICAgYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQgPSBkYV9yeC5hZ2VudF9pZDsNCj4gPiArICAg
IH0NCj4gPiArDQo+ID4gKyAgICBzY21pX2RhdGEuaW5pdGlhbGl6ZWQgPSB0cnVlOw0KPiA+ICsg
ICAgcmV0dXJuIHRydWU7DQo+ID4gKw0KPiA+ICtjbGVhbjoNCj4gPiArICAgIGZyZWVfY2hhbm5l
bF9saXN0KCk7DQo+ID4gKyAgICByZXR1cm4gcmV0ID09IDA7DQo+ID4gK30NCj4gPiArDQo+ID4g
K3N0YXRpYyBpbnQgc2NtaV9kb21haW5faW5pdChzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+ICt7DQo+
ID4gKyAgICBzdHJ1Y3Qgc2NtaV9jaGFubmVsICpjaGFubmVsOw0KPiA+ICsgICAgaW50IHJldDsN
Cj4gPiArDQo+ID4gKyAgICBpZiAoICFzY21pX2RhdGEuaW5pdGlhbGl6ZWQgKQ0KPiA+ICsgICAg
ICAgIHJldHVybiAwOw0KPiA+ICsNCj4gPiArICAgIGNoYW5uZWwgPSBhcXVpcmVfc2NtaV9jaGFu
bmVsKGQtPmRvbWFpbl9pZCk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9PUl9OVUxMKGNoYW5uZWwp
ICkNCj4gPiArICAgICAgICByZXR1cm4gLUVOT0VOVDsNCj4gPiArDQo+ID4gKyAgICBwcmludGso
WEVOTE9HX0lORk8gInNjbWk6IEFxdWlyZSBTQ01JIGNoYW5uZWwgaWQgPSAweCV4ICwgZG9tYWlu
X2lkID0gJWQiDQo+ID4gKyAgICAgICAgICAgInBhZGRyID0gMHglbHhcbiIsIGNoYW5uZWwtPmNo
YW5faWQsIGNoYW5uZWwtPmRvbWFpbl9pZCwNCj4gPiArICAgICAgICAgICBjaGFubmVsLT5wYWRk
cik7DQo+IA0KPiANCj4gSXQgc2VlbXMgdGhpcyBicmVha3MgYnVpbGQgb24gQXJtMzI6DQo+IA0K
PiBzY21pX3NtYy5jOiBJbiBmdW5jdGlvbiDigJhzY21pX2RvbWFpbl9pbml04oCZOg0KPiAvaG9t
ZS9vdHlzaGNoZW5rby94ZW4veGVuL2luY2x1ZGUveGVuL2NvbmZpZy5oOjUzOjI0OiBlcnJvcjog
Zm9ybWF0IOKAmCVseOKAmQ0KPiBleHBlY3RzIGFyZ3VtZW50IG9mIHR5cGUg4oCYbG9uZyB1bnNp
Z25lZCBpbnTigJksIGJ1dCBhcmd1bWVudCA0IGhhcyB0eXBlDQo+IOKAmHVpbnQ2NF90IHtha2Eg
bG9uZyBsb25nIHVuc2lnbmVkIGludH3igJkgWy1XZXJyb3I9Zm9ybWF0PV0NCj4gwqAjZGVmaW5l
IFhFTkxPR19JTkZPwqDCoMKgICI8Mj4iDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqAgXg0KPiBzY21pX3NtYy5jOjU2OToxMjogbm90ZTogaW4gZXhwYW5z
aW9uIG9mIG1hY3JvIOKAmFhFTkxPR19JTkZP4oCZDQo+IMKgwqDCoMKgIHByaW50ayhYRU5MT0df
SU5GTyAic2NtaTogQXF1aXJlIFNDTUkgY2hhbm5lbCBpZCA9IDB4JXggLCBkb21haW5faWQgPQ0K
PiAlZCINCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBefn5+fn5+fn5+fg0KPiBzY21pX3NtYy5j
OjU3MDoyNTogbm90ZTogZm9ybWF0IHN0cmluZyBpcyBkZWZpbmVkIGhlcmUNCj4gwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoCAicGFkZHIgPSAweCVseFxuIiwgY2hhbm5lbC0+Y2hhbl9pZCwgY2hhbm5l
bC0+ZG9tYWluX2lkLA0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCB+fl4NCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg
JWxseA0KPiANCg0KVGhhbmtzIGEgbG90LiBJIHdpbGwgd29yayB0aHJvdWdoIGFsbCBidWlkcyBp
biB2Mi4NCg0KPiANCj4gDQo+ID4gKw0KPiA+ICsgICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4o
ZCkgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHJldCA9IG1hcF9tZW1vcnlfdG9fZG9tYWlu
KGQsIHNjbWlfZGF0YS5zaG1lbV9hZGRyLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHNjbWlfZGF0YS5zaG1lbV9zaXplKTsNCj4gPiArICAgICAgICBpZiAoIElTX0VS
Ul9WQUxVRShyZXQpICkNCj4gPiArICAgICAgICAgICAgZ290byBlcnJvcjsNCj4gPiArDQo+ID4g
KyAgICAgICAgcmV0ID0gZHRfdXBkYXRlX2RvbWFpbl9yYW5nZShkLCBjaGFubmVsLT5wYWRkciwg
UEFHRV9TSVpFKTsNCj4gPiArICAgICAgICBpZiAoIElTX0VSUl9WQUxVRShyZXQpICkNCj4gPiAr
ICAgICAgICB7DQo+ID4gKyAgICAgICAgICAgIGludCByYyA9IHVubWFwX21lbW9yeV9mcm9tX2Rv
bWFpbihkLCBzY21pX2RhdGEuc2htZW1fYWRkciwNCj4gPiArICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHNjbWlfZGF0YS5zaG1lbV9zaXplKTsNCj4gPiArICAg
ICAgICAgICAgaWYgKCByYyApDQo+ID4gKyAgICAgICAgICAgICAgICBwcmludGsoWEVOTE9HX0VS
UiAiVW5hYmxlIHRvIHVubWFwX21lbW9yeV9mcm9tX2RvbWFpblxuIik7DQo+ID4gKw0KPiA+ICsg
ICAgICAgICAgICBnb3RvIGVycm9yOw0KPiA+ICsgICAgICAgIH0NCj4gPiArICAgIH0NCj4gPiAr
DQo+ID4gKyAgICBkLT5hcmNoLnNjaSA9IGNoYW5uZWw7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJu
IDA7DQo+ID4gK2Vycm9yOg0KPiA+ICsgICAgcmVsaW5xdWlzaF9zY21pX2NoYW5uZWwoY2hhbm5l
bCk7DQo+ID4gKw0KPiA+ICsgICAgcmV0dXJuIHJldDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3Rh
dGljIGludCBzY21pX2FkZF9kZXZpY2VfYnlfZGV2aWQoc3RydWN0IGRvbWFpbiAqZCwgdWludDMy
X3Qgc2NtaV9kZXZpZCkNCj4gPiArew0KPiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hh
bm5lbCwgKmFnZW50X2NoYW5uZWw7DQo+ID4gKyAgICBzY21pX21zZ19oZWFkZXJfdCBoZHI7DQo+
ID4gKyAgICBzY21pX3Blcm1zX3R4X3QgdHg7DQo+ID4gKyAgICBzdHJ1Y3QgcnhfdCB7DQo+ID4g
KyAgICAgICAgaW50MzJfdCBzdGF0dXM7DQo+ID4gKyAgICAgICAgdWludDMyX3QgYXR0cmlidXRl
czsNCj4gPiArICAgIH0gcng7DQo+ID4gKyAgICBpbnQgcmV0Ow0KPiA+ICsNCj4gPiArICAgIGlm
ICggIXNjbWlfZGF0YS5pbml0aWFsaXplZCApDQo+ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+ID4g
Kw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19ERUJVRyAic2NtaTogc2NtaV9kZXZpZCA9ICVkXG4i
LCBzY21pX2RldmlkKTsNCj4gPiArDQo+ID4gKyAgICBhZ2VudF9jaGFubmVsID0gZ2V0X2NoYW5u
ZWxfYnlfZG9tYWluKGQtPmRvbWFpbl9pZCk7DQo+ID4gKyAgICBpZiAoIElTX0VSUl9PUl9OVUxM
KGFnZW50X2NoYW5uZWwpICkNCj4gPiArICAgICAgICByZXR1cm4gUFRSX0VSUihhZ2VudF9jaGFu
bmVsKTsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsID0gZ2V0X2NoYW5uZWxfYnlfaWQoSFlQX0NI
QU5ORUwpOw0KPiA+ICsgICAgaWYgKCBJU19FUlJfT1JfTlVMTChjaGFubmVsKSApDQo+ID4gKyAg
ICAgICAgcmV0dXJuIFBUUl9FUlIoY2hhbm5lbCk7DQo+ID4gKw0KPiA+ICsgICAgaGRyLmlkID0g
U0NNSV9CQVNFX1NFVF9ERVZJQ0VfUEVSTUlTU0lPTlM7DQo+ID4gKyAgICBoZHIudHlwZSA9IDA7
DQo+ID4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0VfUFJPVE9DT0w7DQo+ID4gKw0KPiA+
ICsgICAgdHguYWdlbnRfaWQgPSBhZ2VudF9jaGFubmVsLT5hZ2VudF9pZDsNCj4gPiArICAgIHR4
LmRldmljZV9pZCA9IHNjbWlfZGV2aWQ7DQo+ID4gKyAgICB0eC5mbGFncyA9IFNDTUlfQUxMT1df
QUNDRVNTOw0KPiA+ICsNCj4gPiArICAgIHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIs
ICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBzaXplb2YoJnJ4KSk7DQo+ID4gKyAgICBpZiAoIElTX0VS
Ul9WQUxVRShyZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAg
IHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4LnN0YXR1cyk7DQo+ID4gKyAgICBpZiAoIElTX0VS
Ul9WQUxVRShyZXQpICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ICsNCj4gPiArICAg
IHJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IHNjbWlfYWRkX2R0X2Rl
dmljZShzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgZHRfZGV2aWNlX25vZGUgKmRldikNCj4gPiAr
ew0KPiA+ICsgICAgdWludDMyX3Qgc2NtaV9kZXZpZDsNCj4gPiArDQo+ID4gKyAgICBpZiAoICgh
c2NtaV9kYXRhLmluaXRpYWxpemVkKSB8fCAoIWQtPmFyY2guc2NpKSApDQo+ID4gKyAgICAgICAg
cmV0dXJuIDA7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhZHRfcHJvcGVydHlfcmVhZF91MzIoZGV2
LCAic2NtaV9kZXZpZCIsICZzY21pX2RldmlkKSApDQo+ID4gKyAgICAgICAgcmV0dXJuIDA7DQo+
ID4gKw0KPiA+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJzY21pOiBkdF9ub2RlID0gJXNcbiIs
IGR0X25vZGVfZnVsbF9uYW1lKGRldikpOw0KPiA+ICsNCj4gPiArICAgIHJldHVybiBzY21pX2Fk
ZF9kZXZpY2VfYnlfZGV2aWQoZCwgc2NtaV9kZXZpZCk7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0
YXRpYyBpbnQgc2NtaV9yZWxpbnF1aXNoX3Jlc291cmNlcyhzdHJ1Y3QgZG9tYWluICpkKQ0KPiA+
ICt7DQo+ID4gKyAgICBpbnQgcmV0Ow0KPiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqY2hh
bm5lbCwgKmFnZW50X2NoYW5uZWw7DQo+ID4gKyAgICBzY21pX21zZ19oZWFkZXJfdCBoZHI7DQo+
ID4gKyAgICBzdHJ1Y3QgcmVzZXRfYWdlbnRfdHggew0KPiA+ICsgICAgICAgIHVpbnQzMl90IGFn
ZW50X2lkOw0KPiA+ICsgICAgICAgIHVpbnQzMl90IGZsYWdzOw0KPiA+ICsgICAgfSB0eDsNCj4g
PiArICAgIHVpbnQzMl90IHJ4Ow0KPiA+ICsNCj4gPiArICAgIGlmICggIWQtPmFyY2guc2NpICkN
Cj4gPiArICAgICAgICByZXR1cm4gMDsNCj4gPiArDQo+ID4gKyAgICBhZ2VudF9jaGFubmVsID0g
ZC0+YXJjaC5zY2k7DQo+ID4gKw0KPiA+ICsgICAgc3Bpbl9sb2NrKCZhZ2VudF9jaGFubmVsLT5s
b2NrKTsNCj4gPiArICAgIHR4LmFnZW50X2lkID0gYWdlbnRfY2hhbm5lbC0+YWdlbnRfaWQ7DQo+
ID4gKyAgICBzcGluX3VubG9jaygmYWdlbnRfY2hhbm5lbC0+bG9jayk7DQo+ID4gKw0KPiA+ICsg
ICAgY2hhbm5lbCA9IGdldF9jaGFubmVsX2J5X2lkKEhZUF9DSEFOTkVMKTsNCj4gPiArICAgIGlm
ICggIWNoYW5uZWwgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJS
DQo+ID4gKyAgICAgICAgICAgICAgICJzY21pOiBVbmFibGUgdG8gZ2V0IEh5cGVydmlzb3Igc2Nt
aSBjaGFubmVsIGZvciBkb21haW4gJWRcbiIsDQo+ID4gKyAgICAgICAgICAgICAgIGQtPmRvbWFp
bl9pZCk7DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gKyAgICB9DQo+ID4gKw0K
PiA+ICsgICAgaGRyLmlkID0gU0NNSV9CQVNFX1JFU0VUX0FHRU5UX0NPTkZJR1VSQVRJT047DQo+
ID4gKyAgICBoZHIudHlwZSA9IDA7DQo+ID4gKyAgICBoZHIucHJvdG9jb2wgPSBTQ01JX0JBU0Vf
UFJPVE9DT0w7DQo+ID4gKw0KPiA+ICsgICAgdHguZmxhZ3MgPSAwOw0KPiA+ICsNCj4gPiArICAg
IHJldCA9IGRvX3NtY194ZmVyKGNoYW5uZWwsICZoZHIsICZ0eCwgc2l6ZW9mKHR4KSwgJnJ4LCBz
aXplb2YocngpKTsNCj4gPiArICAgIGlmICggcmV0ICkNCj4gPiArICAgICAgICByZXR1cm4gcmV0
Ow0KPiA+ICsNCj4gPiArICAgIHJldCA9IGNoZWNrX3NjbWlfc3RhdHVzKHJ4KTsNCj4gPiArDQo+
ID4gKyAgICByZXR1cm4gcmV0Ow0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBzY21p
X2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpDQo+ID4gK3sNCj4gPiArICAgIHN0cnVj
dCBzY21pX2NoYW5uZWwgKmNoYW5uZWw7DQo+ID4gKw0KPiA+ICsgICAgaWYgKCAhZC0+YXJjaC5z
Y2kgKQ0KPiA+ICsgICAgICAgIHJldHVybjsNCj4gPiArDQo+ID4gKyAgICBjaGFubmVsID0gZC0+
YXJjaC5zY2k7DQo+ID4gKyAgICBzcGluX2xvY2soJmNoYW5uZWwtPmxvY2spOw0KPiA+ICsNCj4g
PiArICAgIHJlbGlucXVpc2hfc2NtaV9jaGFubmVsKGNoYW5uZWwpOw0KPiA+ICsgICAgcHJpbnRr
KFhFTkxPR19ERUJVRyAic2NtaTogRnJlZSBkb21haW4gJWRcbiIsIGQtPmRvbWFpbl9pZCk7DQo+
ID4gKw0KPiA+ICsgICAgZC0+YXJjaC5zY2kgPSBOVUxMOw0KPiA+ICsNCj4gPiArICAgIHVubWFw
X21lbW9yeV9mcm9tX2RvbWFpbihkLCBjaGFubmVsLT5wYWRkciwgUEFHRV9TSVpFKTsNCj4gSSBk
aWRuJ3QgbWFuYWdlIHRvIGZpbmQgd2hlcmUgY29ycmVzcG9uZGluZyBtYXBfbWVtb3J5X2Zyb21f
ZG9tYWluKCkgaXMNCj4gY2FsbGVkIGZvciBhIG5vbi1oYXJkd2FyZSBkb21haW4gKGl0IHNlZW1z
IHRoYXQgc2NtaV9kb21haW5faW5pdCgpIG9ubHkNCj4gZGlyZWN0bHkgaGFuZGxlcyBoYXJkd2Fy
ZSBkb21haW4gY2FzZSkuDQo+IE9yIHBlcmhhcHMsIGl0IGlzIGNhbGxlZCBpbmRpcmVjdGx5IGF0
IGRvX2RvbWN0bCgpOiBjYXNlDQo+IFhFTl9ET01DVExfaW9tZW1fcGVybWlzc2lvbjo/DQo+IA0K
DQpZb3Ugd2VyZSByaWdodC4gV2UgbmVlZCB0byBwZXJtaXQgYWNjZXNzIG9ubHkgZm9yIHRoZSBI
YXJkd2FyZSBkb21haW4uIA0KDQo+IA0KPiBJIHdvbmRlciwgZG8gd2UgcmVhbGx5IG5lZWQgdG8g
Y2FsbCB0aGlzIGhlcmU/IFRha2luZyBpbnRvIHRoZSBhY2NvdW50IHRoYXQNCj4gdW5tYXBfbWVt
b3J5X2Zyb21fZG9tYWluKCkgZG9lc24ndCBhY3R1YWxseSB1bm1hcCBhbnl0aGluZywgYnV0IG9u
bHkgcmVtb3Zlcw0KPiBhIHJhbmdlIGZyb20gdGhlIGlvbWVtX2NhcHMgcmFuZ2VzZXQNCj4gZm9y
IHRoZSBkb21haW4gdG8gYmUgZGVzdHJveWVkIGFuZCBhbGwgaW52b2x2ZWQgcmFuZ2VzZXRzIChp
bmNsdWRpbmcNCj4gaW9tZW1fY2Fwcykgd2lsbCBiZSByZW1vdmVkIHNvb24gYXQgcmFuZ2VzZXRf
ZG9tYWluX2Rlc3Ryb3koKSBhbnl3YXkuIE9yIEkNCj4gbWlzc2VkIHNvbWV0aGluZz8NCj4gDQoN
CnVubWFwX21lbW9yeV9mcm9tX2RvbWFpbiBpcyBhbHNvIHVzZWQgaW4gc2NtaV9kb21haW5faW5p
dCBpZiBlcnJvcg0Kb2NjdXJlZCBhZnRlciBzdWNjZXNzZnVsbCBtYXBfbWVtb3J5X3RvX2RvbWFp
biBjYWxsLg0KQnV0IHRoaXMgaXMgYSBnb29kIHBvaW50LiBJIHRoaW5rIGl0IHdpbGwgYmUgYSBn
b29kIGlkZWEgdG8gbWFrZQ0KdW5tYXBfbWVtb3J5X2Zyb21fZG9tYWluIGluIHNjbWlfZG9tYWlu
X2Rlc3Ryb3kgb25seSBmb3IgaGFyZHdhcmUNCmRvbWFpbi4gQW5kIG1ha2Ugc3VyZSB0aGF0IGZv
ciBTb2Z0d2FyZSBkb21haW5zIHJhbmdlIGlzIHVubWFwcGVkIHVzaW5nDQpYRU5fRE9NQ1RMX2lv
bWVtX3Blcm1pc3Npb24gY2FsbC4NCg0KSSdsbCBtYWtlIHRob3NlIGNoYW5nZXMgaW4gdjIuDQoN
Cj4gDQo+ID4gKyAgICBzcGluX3VubG9jaygmY2hhbm5lbC0+bG9jayk7DQo+ID4gKyAgICByZXR1
cm47DQo+IA0KPiBlbXB0eSByZXR1cm4gY291bGQgYmUgZHJvcHBlZCwgSSB0aGluay4NCj4gDQpB
Z3JlZS4gV2lsbCBiZSBmaXhlZC4NCj4gDQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRpYyBib29s
IHNjbWlfaGFuZGxlX2NhbGwoc3RydWN0IGRvbWFpbiAqZCwgdm9pZCAqYXJncykNCj4gPiArew0K
PiA+ICsgICAgYm9vbCByZXMgPSBmYWxzZTsNCj4gPiArICAgIHN0cnVjdCBzY21pX2NoYW5uZWwg
KmFnZW50X2NoYW5uZWw7DQo+ID4gKyAgICBzdHJ1Y3QgYXJtX3NtY2NjX3JlcyByZXNwOw0KPiA+
ICsgICAgc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3MgPSBhcmdzOw0KPiA+ICsNCj4gPiArICAg
IGlmICggIWQtPmFyY2guc2NpICkNCj4gPiArICAgICAgICByZXR1cm4gZmFsc2U7DQo+ID4gKw0K
PiA+ICsgICAgYWdlbnRfY2hhbm5lbCA9IGQtPmFyY2guc2NpOw0KPiA+ICsgICAgc3Bpbl9sb2Nr
KCZhZ2VudF9jaGFubmVsLT5sb2NrKTsNCj4gPiArDQo+ID4gKyAgICBpZiAoIGFnZW50X2NoYW5u
ZWwtPmZ1bmNfaWQgIT0gcmVncy0+eDAgKQ0KPiANCj4gVGhpcyBhbHNvIGJyZWFrcyBidWlsZCBv
biBBcm0zMjoNCj4gDQo+IHNjbWlfc21jLmM6IEluIGZ1bmN0aW9uIOKAmHNjbWlfaGFuZGxlX2Nh
bGzigJk6DQo+IHNjbWlfc21jLmM6NzM2OjQyOiBlcnJvcjog4oCYc3RydWN0IGNwdV91c2VyX3Jl
Z3PigJkgaGFzIG5vIG1lbWJlciBuYW1lZCDigJh4MOKAmTsNCj4gZGlkIHlvdSBtZWFuIOKAmHIw
4oCZPw0KPiDCoMKgwqDCoCBpZiAoIGFnZW50X2NoYW5uZWwtPmZ1bmNfaWQgIT0gcmVncy0+eDAg
KQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF5+DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAgcjANCj4gY2MxOiBhbGwgd2FybmluZ3MgYmVpbmcgdHJlYXRlZCBhcyBlcnJvcnMNCj4g
DQoNClRoYW5rcywgSSB3aWxsIGZpeCBpdCBpbiB2Mi4NCg0KPiAqKioNCj4gDQo+IEJUVywgSSBu
b3RpY2VkIHRoYXQgeGVuL2FyY2gvYXJtL3RyYXBzLmMgY29udGFpbnMgdGhlIGZvbGxvd2luZyBj
b25zdHJ1Y3QsDQo+IHByb2JhYmx5IHdlIG1pZ2h0IHdhbnQgc29tZXRoaW5nIHNpbWlsYXIgaGVy
ZT8NCj4gDQo+ICNpZmRlZiBDT05GSUdfQVJNXzY0DQo+ICNkZWZpbmUgSFlQRVJDQUxMX1JFU1VM
VF9SRUcocikgKHIpLT54MA0KPiBbc25pcF0NCj4gI2Vsc2UNCj4gI2RlZmluZSBIWVBFUkNBTExf
UkVTVUxUX1JFRyhyKSAociktPnIwDQo+IFtzbmlwXQ0KPiAjZW5kaWYNCj4gDQo+IA0KPiBUaGlz
IFJGQyBwYXRjaCBzZXJpZXMsIHNvIEkgdGhpbmssIHRoZXJlIGlzIG5vIHNlcmlvdXMgaXNzdWVz
IGF0IHRoZSBtb21lbnQsDQo+IHRoaXMgaXMgcmF0aGVyIHRvIGxldCB5b3Uga25vdyBmb3IgdGhl
IGZ1dHVyZSAod2hlbiB5b3UgZHJvcCBSRkMgdGFnKS4NCj4gSSBoYXZlIHRvIGFkbWl0LCBJIG9m
dGVuIGZvcmdldCB0byBidWlsZC10ZXN0IG9uIEFybTMyIGFsc28pKQ0KPiANCg0KVGhhbmsgeW91
IGZvciB1bmRlcnN0YW5kaW5nLiBCdXQgd2lsbCB0cnkgdG8gY292ZXIgYWxsIGFyY2hpdGVjdHVy
ZXMuDQoNCj4gDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInNj
bWk6IGZ1bmNfaWQgbWlzbWF0Y2gsIGV4aXRpbmdcbiIpOw0KPiA+ICsgICAgICAgIGdvdG8gdW5s
b2NrOw0KPiA+ICsgICAgfQ0KPiA+ICsNCj4gPiArICAgIGFybV9zbWNjY19zbWMoYWdlbnRfY2hh
bm5lbC0+ZnVuY19pZCwgMCwgMCwgMCwgMCwgMCwgMCwNCj4gPiArICAgICAgICAgICAgICAgICAg
YWdlbnRfY2hhbm5lbC0+Y2hhbl9pZCwgJnJlc3ApOw0KPiA+ICsNCj4gPiArICAgIHNldF91c2Vy
X3JlZyhyZWdzLCAwLCByZXNwLmEwKTsNCj4gPiArICAgIHNldF91c2VyX3JlZyhyZWdzLCAxLCBy
ZXNwLmExKTsNCj4gPiArICAgIHNldF91c2VyX3JlZyhyZWdzLCAyLCByZXNwLmEyKTsNCj4gPiAr
ICAgIHNldF91c2VyX3JlZyhyZWdzLCAzLCByZXNwLmEzKTsNCj4gPiArICAgIHJlcyA9IHRydWU7
DQo+ID4gK3VubG9jazoNCj4gPiArICAgIHNwaW5fdW5sb2NrKCZhZ2VudF9jaGFubmVsLT5sb2Nr
KTsNCj4gPiArDQo+ID4gKyAgICByZXR1cm4gcmVzOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0
aWMgaW50IHNjbWlfZ2V0X2NoYW5uZWxfcGFkZHIodm9pZCAqc2NtaV9vcHMsDQo+ID4gKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB4ZW5fYXJjaF9kb21haW5jb25maWcgKmNvbmZp
ZykNCj4gPiArew0KPiA+ICsgICAgc3RydWN0IHNjbWlfY2hhbm5lbCAqYWdlbnRfY2hhbm5lbCA9
IHNjbWlfb3BzOw0KPiA+ICsNCj4gPiArICAgIGlmICggIWFnZW50X2NoYW5uZWwgKQ0KPiA+ICsg
ICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ICsNCj4gPiArICAgIGNvbmZpZy0+c2NpX2FnZW50
X3BhZGRyID0gYWdlbnRfY2hhbm5lbC0+cGFkZHI7DQo+ID4gKyAgICByZXR1cm4gMDsNCj4gPiAr
fQ0KPiA+ICsNCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkdF9kZXZpY2VfbWF0Y2ggc2NtaV9z
bWNfbWF0Y2hbXSBfX2luaXRjb25zdCA9DQo+ID4gK3sNCj4gPiArICAgIERUX01BVENIX1NDTUlf
U01DLA0KPiA+ICsgICAgeyAvKiBzZW50aW5lbCAqLyB9LA0KPiA+ICt9Ow0KPiA+ICsNCj4gPiAr
c3RhdGljIGNvbnN0IHN0cnVjdCBzY2lfbWVkaWF0b3Jfb3BzIHNjbWlfb3BzID0NCj4gPiArew0K
PiA+ICsgICAgLnByb2JlID0gc2NtaV9wcm9iZSwNCj4gPiArICAgIC5kb21haW5faW5pdCA9IHNj
bWlfZG9tYWluX2luaXQsDQo+ID4gKyAgICAuZG9tYWluX2Rlc3Ryb3kgPSBzY21pX2RvbWFpbl9k
ZXN0cm95LA0KPiA+ICsgICAgLmFkZF9kdF9kZXZpY2UgPSBzY21pX2FkZF9kdF9kZXZpY2UsDQo+
ID4gKyAgICAucmVsaW5xdWlzaF9yZXNvdXJjZXMgPSBzY21pX3JlbGlucXVpc2hfcmVzb3VyY2Vz
LA0KPiA+ICsgICAgLmhhbmRsZV9jYWxsID0gc2NtaV9oYW5kbGVfY2FsbCwNCj4gPiArICAgIC5n
ZXRfY2hhbm5lbF9pbmZvID0gc2NtaV9nZXRfY2hhbm5lbF9wYWRkcg0KPiA+ICt9Ow0KPiA+ICsN
Cj4gPiArUkVHSVNURVJfU0NJX01FRElBVE9SKHNjbWlfc21jLCAiU0NNSS1TTUMiLCBYRU5fRE9N
Q1RMX0NPTkZJR19TQ0lfU0NNSV9TTUMsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICBzY21p
X3NtY19tYXRjaCwgJnNjbWlfb3BzKTsNCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIExvY2FsIHZh
cmlhYmxlczoNCj4gPiArICogbW9kZTogQw0KPiA+ICsgKiBjLWZpbGUtc3R5bGU6ICJCU0QiDQo+
ID4gKyAqIGMtYmFzaWMtb2Zmc2V0OiA0DQo+ID4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5pbA0K
PiA+ICsgKiBFbmQ6DQo+ID4gKyAqLw0KPiA+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9wdWJs
aWMvYXJjaC1hcm0uaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+ID4gaW5kZXgg
OTE4MGJlNWU4Ni4uYTY3MjM3OTQyZCAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vaW5jbHVkZS9wdWJs
aWMvYXJjaC1hcm0uaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLWFybS5oDQo+
ID4gQEAgLTMxNSw2ICszMTUsNyBAQCBERUZJTkVfWEVOX0dVRVNUX0hBTkRMRSh2Y3B1X2d1ZXN0
X2NvbnRleHRfdCk7DQo+ID4gICAjZGVmaW5lIFhFTl9ET01DVExfQ09ORklHX1RFRV9PUFRFRSAg
ICAgMQ0KPiA+ICAgI2RlZmluZSBYRU5fRE9NQ1RMX0NPTkZJR19TQ0lfTk9ORSAgICAgIDANCj4g
PiArI2RlZmluZSBYRU5fRE9NQ1RMX0NPTkZJR19TQ0lfU0NNSV9TTUMgIDENCj4gPiAgIHN0cnVj
dCB4ZW5fYXJjaF9kb21haW5jb25maWcgew0KPiA+ICAgICAgIC8qIElOL09VVCAqLw0KPiANCj4g
LS0gDQo+IFJlZ2FyZHMsDQo+IA0KPiBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 13:27:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 13:27:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248638.428853 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDGe-0007lx-GR; Fri, 17 Dec 2021 13:27:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248638.428853; Fri, 17 Dec 2021 13:27:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDGe-0007lq-DB; Fri, 17 Dec 2021 13:27:24 +0000
Received: by outflank-mailman (input) for mailman id 248638;
 Fri, 17 Dec 2021 13:27:23 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myDGd-0007lk-Nn
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 13:27:23 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myDGd-0003ct-Dv; Fri, 17 Dec 2021 13:27:23 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myDGd-0002U2-84; Fri, 17 Dec 2021 13:27:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=41MSgebp+CtXX4sJt7rZediQ97blds8NTSnl59fis7g=; b=MXBXCA0aR3VIhvi6Xcw+O2ogcJ
	zwGqGoswwLLxjAw3IqqaDy7b7CynbmegCX3ADtwFE+MvAqWbZlaWF5OCO9Ysplp/TsxTzMpKH4Scn
	g3BH7KGQcc3OollkO1Ghe21Ot1K3h4XKeO9tUaVjp3yjTuLa4qOv00aZ+0R+DpVZRl6w=;
Message-ID: <6007a75d-4450-a0f8-c7b0-c557d8ae424c@xen.org>
Date: Fri, 17 Dec 2021 13:27:21 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3] xen/arm64: Zero the top 32 bits of gp registers on
 entry...
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211217072159.3464-1-michal.orzel@arm.com>
 <48666542-6647-d1ec-78df-2fbb43efcc0d@xen.org>
 <f05fadce-3d7b-9564-0865-de683c0baaa8@arm.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <f05fadce-3d7b-9564-0865-de683c0baaa8@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Michal,

On 17/12/2021 11:52, Michal Orzel wrote:
> On 17.12.2021 11:01, Julien Grall wrote:
>> On 17/12/2021 07:21, Michal Orzel wrote:
>>> to hypervisor when switching from AArch32 state.
>>>
>>> According to section D1.20.2 of Arm Arm(DDI 0487A.j):
>>> "If the general-purpose register was accessible from AArch32 state the
>>> upper 32 bits either become zero, or hold the value that the same
>>> architectural register held before any AArch32 execution.
>>> The choice between these two options is IMPLEMENTATION DEFINED"
>>>
>>> Currently Xen does not ensure that the top 32 bits are zeroed and this
>>> needs to be fixed. The reason why is that there are places in Xen
>>> where we assume that top 32bits are zero for AArch32 guests.
>>> If they are not, this can lead to misinterpretation of Xen regarding
>>> what the guest requested. For example hypercalls returning an error
>>> encoded in a signed long like do_sched_op, do_hmv_op, do_memory_op
>>> would return -ENOSYS if the command passed as the first argument was
>>> clobbered.
>>>
>>> Create a macro clobber_gp_top_halves to clobber top 32 bits of gp
>>> registers when hyp == 0 (guest mode) and compat == 1 (AArch32 mode).
>>> Add a compile time check to ensure that save_x0_x1 == 1 if
>>> compat == 1.
>>>
>>> Signed-off-by: Michal Orzel <michal.orzel@arm.com>
>>> ---
>>> Changes since v2:
>>> -add clobbering of w30
>>> Changes since v1:
>>> -put new code into macro
>>> -add compile time check for save_x0_x1
>>> ---
>>>    xen/arch/arm/arm64/entry.S | 29 +++++++++++++++++++++++++++++
>>>    1 file changed, 29 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
>>> index fc3811ad0a..e351ef8639 100644
>>> --- a/xen/arch/arm/arm64/entry.S
>>> +++ b/xen/arch/arm/arm64/entry.S
>>> @@ -102,6 +102,30 @@
>>>            .endif
>>>              .endm
>>> +
>>> +/*
>>> + * Clobber top 32 bits of gp registers when switching from AArch32
>>> + */
>>> +        .macro clobber_gp_top_halves, compat, save_x0_x1
>>> +
>>> +        .if \compat == 1      /* AArch32 mode */
>>> +
>>> +        /*
>>> +         * save_x0_x1 is equal to 0 only for guest_sync (compat == 0).
>>> +         * Add a compile time check to avoid violating this rule.
>>> +         */
>>
>> We may want in the future to allow save_x0_x1 == 1 with compat == 1 if we need to create fastpath like we did when entering AArch64.
>>
>> So I would reword the comment to make clear this is an implementation decision. How about:
>>
>> "At the moment, no-one is using save_x0_x1 == 0 with compat == 1. So the code is not handling it to simplify the implementation."
>>
>> If you are happy with the new comment, I can update it on commit:
>>
> Please do. The comment looks ok.

Done. It is now committed.

Thanks for the fix!

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 13:37:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 13:37:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248643.428868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDQZ-00011R-Hw; Fri, 17 Dec 2021 13:37:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248643.428868; Fri, 17 Dec 2021 13:37:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDQZ-00011K-Dn; Fri, 17 Dec 2021 13:37:39 +0000
Received: by outflank-mailman (input) for mailman id 248643;
 Fri, 17 Dec 2021 13:37:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myDQX-00011E-Vs
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 13:37:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myDQX-0003od-Nq; Fri, 17 Dec 2021 13:37:37 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myDQX-0003AM-HY; Fri, 17 Dec 2021 13:37:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=difhpwWhOVdVIGhA5PVLpgFFxogfn/LcSrtVo9Re0BI=; b=qeA4NJPc87FFGHtO/gMIpstuyW
	faluuij9N1AcJA9n5zUZF4bQnxoFTgBxMj+aF0ymZOgMZkUJ9iWd9rQq65zt8dpg3sTa4vHjH7Hcu
	9MMlfUhbhfBI+jwq77gxeK/WNaVUyIPc0NGeIDHW+48A7CWpxOxH9p3j9Z8VRj2791JA=;
Message-ID: <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
Date: Fri, 17 Dec 2021 13:37:35 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 Oleksandr <olekstysh@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211217132304.GA4041869@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 17/12/2021 13:23, Oleksii Moisieiev wrote:
>>> +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
>>> +{
>>> +    return iomem_permit_access(d, paddr_to_pfn(addr),
>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>> +}
>>> +
>>> +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
>>> +                                     uint64_t len)
>>> +{
>>> +    return iomem_deny_access(d, paddr_to_pfn(addr),
>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>> +}
>>
>> I wonder, why we need an extra level of indirection here. And if this is
>> really needed, I wonder why map(unmap)_memory* name was chosen, as there is
>> no memory mapping/unmapping really happens here.
>>
> 
> I've added extra indirection to hide math like
> paddr_to_pfn(PAGE_ALIGN(addr + len -1)
> so you don't have to math in each call. unmap_memory_from_domain called
> from 2 places, so I moved both calls to separate function.
> Although, I agree that map/unmap is not perfect name. I consider
> renaming it to mem_permit_acces and mam_deny_access.

I haven't looked at the rest of the series. But this discussion caught 
my eye. This code implies that the address is page-aligned but the 
length not. Is that intended?

That said, if you give permission to the domain on a full page then it 
means it may be able to access address it should not. Can you explain 
why this is fine?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 13:40:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 13:40:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248648.428878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDTC-0002Yp-VX; Fri, 17 Dec 2021 13:40:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248648.428878; Fri, 17 Dec 2021 13:40:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDTC-0002Yi-Sh; Fri, 17 Dec 2021 13:40:22 +0000
Received: by outflank-mailman (input) for mailman id 248648;
 Fri, 17 Dec 2021 13:40:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myDTB-0002Yc-Rb
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 13:40:21 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id dfb05162-5f3e-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 14:40:20 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHC974K024282;
 Fri, 17 Dec 2021 13:40:16 GMT
Received: from eur03-ve1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2054.outbound.protection.outlook.com [104.47.9.54])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d0t9w8ccj-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 13:40:15 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR2PR03MB5419.eurprd03.prod.outlook.com (2603:10a6:101:20::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.14; Fri, 17 Dec
 2021 13:40:12 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 13:40:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: dfb05162-5f3e-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=a52w2df6wD0x3W5ef9TVC67xbR6CkiZKfDX1rzlVRAvt7SRrCFCQlLDzs/Et95ovT9tvfcAKqqqA1RAlxXQyk1QD84W4Gi4mfVpcbCNzGtZJ7j6sM85oqn6KN/ogAmubZseSQgt62XMZp+/wTGVHr0hrnrOvYW1mlKxNDVh8ULoJvu6PRvG0qSzOdtgyIaEHMVdHRa42ta58ezfbFmaQHlYGzeamEaCMisO1hSgg2n7XWreG3wns3LmLUic+FcnZhvlK3AxfPJ40U0A/N6o5HVyQhjFWs9PZC+HlrfF/08JwfW3U1ltheqaHg2EIqJpwEjksW0c3vOE2LT+0l4oR6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=E5mhhUT6+36aJ6DOKmaJJI17X6TlMsM4nh5bF5/mN3E=;
 b=W1/7WNOi9RB1S6NsJzh6jWM4yltE33loLJWIwV/PFyIJuW2D85XwnA89FRNLnTvf38puCSPa7M9PyRXojs94gYRQUb/MaJUITasJhOLi54NCvEUNBiWtCt/KcLevJub0h2p5WbNwxAzy6OnEWQK8Vx3d1H8toPpSWPkrHjFRQctjR//lFMPMIjqwFUjb92/6TcuIurmWMoJufFAOYqBlkVhtL7F12uIiECKDQm+jEfmH+Dwj58hJ3wRG+WGPWDYQe3P1hSD5Fv/vb7nqx6h43JlshSdvPW9+9hu0w1aTiZwkRPC4M3DeFwmrFbfyVZrsH7fg/VGi9k5oHIziBnuT8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=E5mhhUT6+36aJ6DOKmaJJI17X6TlMsM4nh5bF5/mN3E=;
 b=Dwjr6coByq09z9TW19GFqgSFkSS+w9oZW9jrGObbBbv54HGukIMuzmHg9o4QodO6UWU0wmSuBph5Kg07isjZ0kJmdvqiOw4iuRBGELpPuSIjU1FtERVPQQffrSsRMAfdZrx0tjoUhoTRBzs7NR66OkW558qUrgLEr1HydynE3EdGODsPFfxJIaRVG1RBM+LnQdVJC6FwWN/X6OBl47pHenqaOWoLooWYkMBvjhYzCjzzuBE7PooPYkol2x/p1/5hZHKAlv+upSI+e2PhtgRGuHU0SoLb5Rw/M9GkWjmHMdCtZfWFzAn0j7AOY7mykewalurk0h9ekStGLyc3J45j8w==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Julien
 Grall <julien@xen.org>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Anthony
 PERARD <anthony.perard@citrix.com>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qwxu+8AgAOpWoCAAOP7gIAAAQmAgABrUYA=
Date: Fri, 17 Dec 2021 13:40:12 +0000
Message-ID: <20211217134011.GA4065065@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <5876e66a-9a12-6a69-989f-a5ba6709886c@suse.com>
 <20211216173625.GA3623693@EPUAKYIW015D>
 <08488d6e-3bb5-71e3-2e07-aafb912d69f5@suse.com>
 <e86974f6-dde3-20dc-1748-962d9122a05e@suse.com>
In-Reply-To: <e86974f6-dde3-20dc-1748-962d9122a05e@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e5e057ea-25bc-40ed-e96e-08d9c162c02e
x-ms-traffictypediagnostic: PR2PR03MB5419:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB5419911F3C30AAB3D21B2CBBE3789@PR2PR03MB5419.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 gn0lYFP6UEnjg9Mhy+LK47fJwVknTTF61QxA0gB6Y6sAd+RZO+jLmUIaCeH8j6fl7Uy0vAOCCTVv1fwXeQnC9nKcngDBJhs5E84w7/maYmNRdO/WExQ7vb6C/mrlooZlFjJN9sUCB+OsqJxIGEycbilTjRYWeBg0iGeWRyrqH9914t3vqKY55OX+Z3T3ggNyEz7KaH1PQAudHtx8L+Tma2w+L9caP8hnlWkkCJraxc56sR26cxIm8+AwEWSqAiC5Qkq19lxlsHNP9ttQGMIlZfv0VjsXJ3/paQYpqhRFsx88AYJhCVnOeoqK233jEqYCxtXsNVZvUIxttgiPe9JqQFsvS4WdmDy0yCxJ/DH8HuucVdmFA5G/8wGLPRA53jx478f+niIWFsgzsNE2QEl6IT910ikjHyOuw/0MQBbfaPZ+7GweFzx69ifBPsHF7557DwJhM11Km+AQ74Iu5iLGg3nZ7E1gyyaHRRb5aQmh07r088G26Z8xsw5WBdDu2Im3Lo7ABpJoQrP1H2hbUTrlxOfS8zsJjppJ2+A2I2vn8wr4TatqaoANOmzFolBjdIDSZg2KY6bvkHfrHvNJ/ftogLGVWpHVoxf0aqHUzbue1HGvTzAEen3/ty5525SRdh1uQgoYddi2/n3TryA0ierUAauY3vM4Zed73IXlM3SX02UU3aAD3kfCT58ZLew5+8H+TK7pi+oaaUg78YCLo/O/+w==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(1076003)(66476007)(6506007)(66946007)(66556008)(64756008)(66446008)(38070700005)(122000001)(53546011)(4326008)(38100700002)(76116006)(91956017)(71200400001)(83380400001)(2906002)(33656002)(26005)(186003)(8676002)(86362001)(8936002)(33716001)(9686003)(7416002)(6512007)(508600001)(6916009)(5660300002)(316002)(6486002)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?9y6+MM+0v4eVq97M4oOyJIO72RMVvANFpMo1AcZKh2+/a+I6QlhacGGJ1Adz?=
 =?us-ascii?Q?i7+P9fY5NA7z9vAq/chAsmyqennN7OMCx0ORQBw5KU/571HqVcf6CvGdF71d?=
 =?us-ascii?Q?EQ3DKAN/I7wbUGdz1CKWd2VG+vn459BsSaI5TFxDvi7WkSGCPLTfs049I0oC?=
 =?us-ascii?Q?WdapDUoLR2dNrX90yNuEB3QJf6mfqOvTi+gXX3EoCvnfzzDZns44fWMeqrwd?=
 =?us-ascii?Q?eX9I8ngk1JM2fOxPyolCPdNHlqF66mnEI0YbjpGav/+ITRuwF/jZ9GWa5I5e?=
 =?us-ascii?Q?AXm38CZQX6TlCjNkabSEx13KQiowLzKsWPgCyN55+RxLRMx7E5+HLD9JZ/9j?=
 =?us-ascii?Q?fb6G2crFbR6fz5bO3okRKQP5iU5nNPaEwQC3C/94mOoTStvZFNrhb1AM8szG?=
 =?us-ascii?Q?zqAcs1hvsu3LkRTqGcoPu6O6s4Ad10pOtnR3P3Uvy1sbkEkTcGEow7H5PdL8?=
 =?us-ascii?Q?5wBZRzBApcL+vvxjBDC2V4EBerovDmSJPwR/ySRbEhmjHYhYE0Tvcqfpf1Qf?=
 =?us-ascii?Q?Jw2PayLxulTzDJs920VNavoj46QN5mZyi5nXbsfqLR9QFJNYkFxxPYondsh0?=
 =?us-ascii?Q?wFcqOwcNkxxOedvjouxg+yQTBR6ZAQcf+2t0x7TlI6LXL/nS7LqmNKifvUs6?=
 =?us-ascii?Q?5v+CiD9rhTRmAqRvHYYuFNrXFMkWihM1eRFpeUpoH6lJbOZLr/5iHJ8EG5ln?=
 =?us-ascii?Q?eKRwGaUjua53cv5EBEKHfenk8RsjY297PtlRuzCReo1NoJuECU/1trvuaP9Q?=
 =?us-ascii?Q?1RWMcLYhJwnvdDXMHMPUMQKR0vrEabQtE8s8mJc63yemhjhretzW3c/vLrMh?=
 =?us-ascii?Q?2AlWU+vmIjAQee/2TqtTmJphEndYUSImMePH/B1lKD6IusFnACnvzI+GP64P?=
 =?us-ascii?Q?tCL25D3bgqICjMRJEBw7dV5Boh1sKrJKjrsfjqjyM6lhSSLLMTZKB7rnNDQ6?=
 =?us-ascii?Q?Hy13dNfM5UeQo3v1LMzVz2BHBAYS011d4BG4dsTgTfc3IsU7VLCz1sg7/aw+?=
 =?us-ascii?Q?8L0PUp+VUULZ+HJRPwx8995H6njwK68ZCis7C5H9n6Y6x7rFLjcKg3u+hA8C?=
 =?us-ascii?Q?AYtqDJP3AQ9hSbiWsB9wXUNb2GiO9OaU/BVkXrOUpoqllZJWffzICDYCxywz?=
 =?us-ascii?Q?TLS9djnV8RTCek/w2Ywtm8i4tt9vXmcEJ8Rbe7Px7MYjlksl1qVTQn3O6n+x?=
 =?us-ascii?Q?cZP76zGiwerqAwX+KCEnCdDc/Zf8Ge8ruN9xZ5itM54NowV2+2peRmI7febi?=
 =?us-ascii?Q?t6XNRZUgqxenqUGciYBCxUBxFa09t2jeVTdQPdfcH1hXgLeAsC0M8HHoyZeP?=
 =?us-ascii?Q?9y5ihmECMAfo3B5da5vLgDqKutqOR/UvXK+QSeNQfkH6aSRPVtwWazcYISjB?=
 =?us-ascii?Q?c1zjdlHClXCj788IP1GrkW8hr6SvqBgVJNJD9Zns6MJToqUzsmfBtxg6AS7q?=
 =?us-ascii?Q?FeBW/iTNTjAVgu+cWBdIGRNSY0UA5lhsPR63FuUUylyjGIpVQsQCdLqvHjMN?=
 =?us-ascii?Q?gMybAZznDdyPChxsrjkcrDJm/LF7pMa1KwTtr1SLuLrzPqNHOQ5TZhexnlzG?=
 =?us-ascii?Q?g0PYt8CS5lrSwhZV7EqUPOF3VWyEam/ao/ewj0/fr51OOHqg7/SfPvd8AoiO?=
 =?us-ascii?Q?GRD3dfzvVZc46VVn0Cx+WLYKW/jnvetSIWpD3nbOupsfq8oI1q8S+obKT1qs?=
 =?us-ascii?Q?TNv19UNxkEFkqLr3nXjR7K+V+Eo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D9C80DACF7843742A10906831A3ED202@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5e057ea-25bc-40ed-e96e-08d9c162c02e
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 13:40:12.4266
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PqQw/pWjFJaC5i0H863r343cGNPf5y5+6Ujn6SCFcjalrpwf+0ImKRjbGfqcV7qjmnlHmfVxWmhhqmHGjwSs0CE0fsuX/GNEmJot/6Sq6XE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5419
X-Proofpoint-GUID: 9cfbSjKRXJbiru3r3O4iR-1MvKTQX6Dw
X-Proofpoint-ORIG-GUID: 9cfbSjKRXJbiru3r3O4iR-1MvKTQX6Dw
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_05,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 impostorscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 mlxscore=0
 malwarescore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=969
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170079

Hi Jan,

On Fri, Dec 17, 2021 at 08:16:05AM +0100, Jan Beulich wrote:
> On 17.12.2021 08:12, Jan Beulich wrote:
> > On 16.12.2021 18:36, Oleksii Moisieiev wrote:
> >> On Tue, Dec 14, 2021 at 10:41:30AM +0100, Jan Beulich wrote:
> >>> On 14.12.2021 10:34, Oleksii Moisieiev wrote:
> >>>> --- a/xen/include/public/domctl.h
> >>>> +++ b/xen/include/public/domctl.h
> >>>> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> >>>>  #define XEN_DOMCTL_vmtrace_get_option         5
> >>>>  #define XEN_DOMCTL_vmtrace_set_option         6
> >>>>  };
> >>>> +
> >>>> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> >>>> +struct xen_domctl_sci_device_op {
> >>>> +    uint32_t size; /* Length of the path */
> >>>> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node=
 */
> >>>> +};
> >>>
> >>> This being - aiui - Arm-only, please enclose it by respective #if,
> >>> just like we do for certain x86-only ops.
> >>>
> >>
> >> I agree. I will add #ifdefs in v2.
> >>
> >>> I'm further afraid the term "SCI" is ambiguous with ACPI's System
> >>> Control Interrupt, so there's some further tag needed in the names
> >>> used here.
> >>>
> >>
> >> Thank you for remark. I'm thinking about SC as System Control.
> >> What do you think?
> >=20
> > I guess "SC" could even more so stand for various things. Even the
> > spelled out "System Control" looks overly generic. If this isn't
> > Arm-specific (in which case adding "arm" into the name might at least
> > help the situation a little), then I guess some further disambiguation
> > is going to be wanted. Since I don't know any of the context of this,
> > I'm afraid you're in a far better position than me to come up with a
> > non-ambiguous name.
>=20
> Actually, looking at the title again - any reason not to add "mediator"
> into the name? While I have no idea whether there could be other
> mediators with an ambiguous acronym, this would at least address the
> ACPI related concern (I don't expect anything mediator-like to appear
> there, but then again I might be wrong).
>=20
> Jan
>=20

I wanted the name to be abbriveation. Also tee option in xen doesn't
have "mediator" in it's name either. As for the SC - the only 2 uses I
found are - Spreadsheet Calculator and some script name for
traffic-shaper.
But I think name still need to be discussed.

--
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 13:59:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 13:59:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248655.428889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDlQ-0004LQ-Kt; Fri, 17 Dec 2021 13:59:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248655.428889; Fri, 17 Dec 2021 13:59:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myDlQ-0004LJ-Hz; Fri, 17 Dec 2021 13:59:12 +0000
Received: by outflank-mailman (input) for mailman id 248655;
 Fri, 17 Dec 2021 13:59:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qsGH=RC=epam.com=prvs=29854569c1=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1myDlO-0004LC-IR
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 13:59:10 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 801b07a3-5f41-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 14:59:08 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BHDwBhi020552;
 Fri, 17 Dec 2021 13:59:04 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d0uang4a7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 17 Dec 2021 13:59:03 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7486.eurprd03.prod.outlook.com (2603:10a6:102:10e::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Fri, 17 Dec
 2021 13:58:56 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021
 13:58:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 801b07a3-5f41-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iHZG88eDrMQULTV9sBNc9p2GUSpj5YakKD2h7a4rmUR6h86A0EMUOmXel3FC2wuWe8aft4HsIKAQT6eTX5DZ+5q7YhfYCCNIkU5f0lYaR5g6UNMZCyc0oS7EUVwdFHxWyOL28t0HCnAux7Xtrp82m6u90Na8UUbs/w7xnn/y8mxNVsxfX8xXrmeq7NMKpghM458lsGb7C4Ru1oTGOel5gnW0PrUBuB4YitvJWsTwIluhTJEI8uF7LaC7baBmLl4PEDyqN0WpV1QyH35kfOgA94D5iy4XPgoxB6PNWQkuO7azpxQUSB/0/+WPeVfTJB8nv8BfJfNGz/RthoP9wy7P8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T9raHJaVzXottLrjlJKE8XrEr3Amie7Jgf9biIHBeL4=;
 b=juzSeI8a49ycjtobV6XIxuqTUZNuDfhtSzMfbH3VYZtiWos+udD6yqtCfNvnmpDhkzpMzrvCkfucYyOAIOkjQMQZq2K+siHurm44dwAWrKxeYUG2kbWVOosNnUQCZmxutSXHn2e57OXch4tDmoImRKJjFk9hPkIhJOQnwVPDYVHkAO1HcAs5Z4Mau4RW3cjtLMjiigJYnk7h9JhyBPt0U9OslgOC6qn6weA0W6uHpPuVPCg5FKNV7KKfG3BxY8qrTX/JIjvOhv+uaKtfZFkK6Y8b49EjieAmj8peelpqaA6GO4+ZgDuFalZUL9maFTcwqrDG6guFQxY/CLpIq9CsOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=T9raHJaVzXottLrjlJKE8XrEr3Amie7Jgf9biIHBeL4=;
 b=edSJ8DyktB3cuZ/g5gzRNFKyljrwHmfxaXK5jCdNLvVwSlSnhqeKXAtHlM4livuTGjYFun+8StrPvYEY8N+qApQEnEfFdUdHLpPRawWaKoiNRzT18nuNkHWNeiIHB8l9quS/r94WmjdYHu8nqONs1uaFlaAKUTdZvn0bTTLdgtlvfAKMWP5eRX5+SBM+1lxrrPtjIvQWpZlNg8v7y1VjdUBrMq4JE+ahC/BVUeaxXLVO79HPSvI81n8dXL7FXqWJHCjyOcr4FxgaUNVOrmZxff0fFf3Znk12ft3tJsRTwYxC3rrGjmf/5ShrQCfn67OdABxH7+lIAssXwRMu3IBbMg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw2ks6AgAAeBwCAAAQPgIAABfaA
Date: Fri, 17 Dec 2021 13:58:56 +0000
Message-ID: <20211217135855.GA4072899@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
 <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
In-Reply-To: <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66108e4e-1b7a-427f-3f02-08d9c1655e13
x-ms-traffictypediagnostic: PA4PR03MB7486:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7486CE798D87B2829842E905E3789@PA4PR03MB7486.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 gFCYt1S2heNfAaU+smwTSj8NzQdNpL3VITcb3wDgmM/eexNUCC4eKlNynsadR3SWmqXzXKUkdQnWsX678Vqpv+deRnj2bNSximhP5gF1QhlVD+jSrjx3RTonRrVHPOFg3SDRDnn8qwGCBnn/v1kG8yQt/vyO0+htRRMX8XmET1WBQCQ1+FjU78wCPbk38ARDQxsxh1P2bilc/ltxJYnR8+HAq8+py5uCc7/WsrZYYwO5ZxSGtBf2Gmt4kUKYsJB0faLRJM6oGis3AJ9vC5b2sAkXbR09DDAPmOyRB0k5GloFn9sWjqBENirRYzHsiGpKzw4bnj7zDGZPrWYAiScDGdIHSF5g+WGNTE+w/3S8pBMU1xNiwJMN6c37H33DmOermh61WUOMP60Ji/e+6E4W3SGY+4IjfD9ImnjmFEH78dtbAFdEsgYjAbX8iwz7nmgtjQPn0eQjknz1pQdX9EzHxAW91vv23Wsfn4xJPBitJWs+knLyP5d6PWHIQ3Dx/FRqK3fpaUTFelqh4TiBo8wNpPjRqamRy0m4CEK6u6CftGYCPTlmChz7aG0ajZdXXqdTXciP42zxDmZ3dx3rojZ4+epiZvCLBK0VIaAAZf6JgSWe6jsZQtlFrZgR7mT0Cw9QePV+iBud7RsQnaJZEiQMht0DqG9SjJgM7UIGWGvLPM5edVwQJ1vzby6/6eGHjilK6zKtg8avH9NP/J+O20jYJg==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(1076003)(2906002)(6486002)(9686003)(71200400001)(122000001)(38100700002)(508600001)(8676002)(54906003)(83380400001)(33716001)(5660300002)(4326008)(8936002)(6512007)(33656002)(316002)(91956017)(53546011)(6506007)(26005)(76116006)(38070700005)(66556008)(66476007)(64756008)(66446008)(6916009)(66946007)(86362001)(186003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?f4c+5fRvAzjHd55AhKqzBKUUw19FzBwEU89tOej5yD3s+e7l6/aWVfZwAANe?=
 =?us-ascii?Q?rVZUprcTvAnJpZq6mLgaSlC3PlcjgZNS6y/j6b2wbcN40DTFZ1+EpyhHxCwC?=
 =?us-ascii?Q?2FvEHpCvsQxbo65S5MALiONqDRE9KUrzxhQUYYpAy0aTh0IVKXjVG+qbkmZN?=
 =?us-ascii?Q?hlY/vhF0pZ0tfUF3wNxMfaKJjkMMUf/BW6CDeZOMCHIWvR1JFSixfMIaZpBU?=
 =?us-ascii?Q?dsXTNL0NVlbvcGm+LoUfBz8OIOMSCu9UiawmOUVJC6h+mnyZ2BurF/Saq70f?=
 =?us-ascii?Q?uT2ghxT1HYDmChrtz6Ez2sbROZBeIK2c5noMyz3g3flMfwkj4rZDvZ9+3vzW?=
 =?us-ascii?Q?YfC+gy+CYZ1ImLlxuhEGSek3xIZ5dDbODe4EQCpfxwlCTLv74J+rWwbsfic7?=
 =?us-ascii?Q?nUuB5sAgEaYzgG/cygOP1DzJRIM1A0mkzpBbh7bQrMoo23/sgbYHJZGLGN2F?=
 =?us-ascii?Q?bwNk4LgkIYcsRpERRUhFbnXH96UTJvgG9MyBTl7Qf/t2o6mgh0193b3Eiyd0?=
 =?us-ascii?Q?wkX16WrufKcoGIguE1kClOiw4LVeNa9gtmRZgmnsq4jynaLGdQMfVXcTDOcU?=
 =?us-ascii?Q?CnSQOwomRSP28QCvHVCiEN34nc28PqWFGsdF9bQ5C2o85biSgRgL1x4YsuOF?=
 =?us-ascii?Q?eLpa4jRZ8D5VhUUTwvWSccU+dzW6gG9fdZFKq53KhXLe7LW4wbQu9/h9yNgX?=
 =?us-ascii?Q?UJG2Wynsx4Dy8P7b+CAAr+3rsHU3jPAl0xTV8/AxcmpYbo276wIvHy1Q12fM?=
 =?us-ascii?Q?SYu7xFJVt5sicMygbFXkAdlL+ClLxt87ZyL4Pqk4sormj3UKzek3M60fL9qL?=
 =?us-ascii?Q?aWjE/h3xlVJupl07E5EparNaq1bDqSx8qdfL12Gjd74GccDeNZi5PMJ58BzH?=
 =?us-ascii?Q?LL7QJXSkOBebSmEJdSEcOTyP6zHqj1iyTgNMwSoozlA1t3GyZVxciNlWLlpp?=
 =?us-ascii?Q?aOQ3jB1P2SumwpIbfR8q/jst0ul8guPHTkqcSNWwVlZ4zSRZ+NMioK+jdga+?=
 =?us-ascii?Q?n5PgDaLIlaHz3Q2U57ij3kq80VUAXEREj72LNPM7G1oERBgzhNc1HQBlGLRD?=
 =?us-ascii?Q?PpV5Y1UikJaDSuLgJCKe3bqNenBvZ7+6ZQLQhQ97xktiKxcIUbuxE98/G+gK?=
 =?us-ascii?Q?zzwHLvR/LgqbB62Hp2uHzdDqBdDQT6iyZCJpAcLCrhBMm5wYegeERUgM2Fi/?=
 =?us-ascii?Q?R21BAYJITZChX7SL+4LeL9h/Ln4WyRg1j+IZpDcoklLBl+7eust2+qpOQQeX?=
 =?us-ascii?Q?Mg5+M1IHEub9REABA2o1vG/CRbG8TM1LucdG/Pq9K1BcRyqae5vKeGBdUybT?=
 =?us-ascii?Q?984hLt2CqfAUI8kHg8jNH8bygiCpuYhSxE/W6ZI/tJmGymhm2iUcMp7OX4eS?=
 =?us-ascii?Q?RjkGu0R0pKgkofpFwAR2EWTaxg5qRs2fzZ7aN0PKShnnXb4dUhfvp5mA7LbQ?=
 =?us-ascii?Q?SzagJBxdylV5gJeoIWz76+oLSURY06mIDQVaBk8Gsi7VrKecFmXdSWIE08t4?=
 =?us-ascii?Q?Wn7BVhz7cDbtqHyqm1bjoQb39kqcAX2SrJoxHzxyP1Vs6UH455yqMsPs9Iyj?=
 =?us-ascii?Q?z1yteIeOofeKHsMgh+aRFxhmPrwR7FI3LTCrsNZSkWyZEgvmjh/eWn0nQ+1j?=
 =?us-ascii?Q?Ohd9YaLqzF36eaWmZGUtVIe8jbE2uD35rt58a7YPlx6vgXukc3NepfRFgDIb?=
 =?us-ascii?Q?qdcTHYg7WLPyW2FH3JSStuTKypI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0B48FC53700B4F43BA3D3B94888C322A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66108e4e-1b7a-427f-3f02-08d9c1655e13
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 13:58:56.2875
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KnpbqXeBeK8h2YJxXAwhyoGZ3P3MxBQp6+LZGbW5pbWOAzpiLdce4ZDS8UasZu6mRtdsaFItp0CogMdsS2J7wh++YdUTISJKd1vOF11qgoY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7486
X-Proofpoint-GUID: u3G8F0o5Kka6-cFRIyk4_8YW21ayPyPE
X-Proofpoint-ORIG-GUID: u3G8F0o5Kka6-cFRIyk4_8YW21ayPyPE
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-17_05,2021-12-16_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 priorityscore=1501 lowpriorityscore=0 adultscore=0 mlxlogscore=751
 phishscore=0 mlxscore=0 clxscore=1015 spamscore=0 suspectscore=0
 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170082

Hi Julien,

On Fri, Dec 17, 2021 at 01:37:35PM +0000, Julien Grall wrote:
> Hi,
>=20
> On 17/12/2021 13:23, Oleksii Moisieiev wrote:
> > > > +static int map_memory_to_domain(struct domain *d, uint64_t addr, u=
int64_t len)
> > > > +{
> > > > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > +}
> > > > +
> > > > +static int unmap_memory_from_domain(struct domain *d, uint64_t add=
r,
> > > > +                                     uint64_t len)
> > > > +{
> > > > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > +}
> > >=20
> > > I wonder, why we need an extra level of indirection here. And if this=
 is
> > > really needed, I wonder why map(unmap)_memory* name was chosen, as th=
ere is
> > > no memory mapping/unmapping really happens here.
> > >=20
> >=20
> > I've added extra indirection to hide math like
> > paddr_to_pfn(PAGE_ALIGN(addr + len -1)
> > so you don't have to math in each call. unmap_memory_from_domain called
> > from 2 places, so I moved both calls to separate function.
> > Although, I agree that map/unmap is not perfect name. I consider
> > renaming it to mem_permit_acces and mam_deny_access.
>=20
> I haven't looked at the rest of the series. But this discussion caught my
> eye. This code implies that the address is page-aligned but the length no=
t.
> Is that intended?
>=20
> That said, if you give permission to the domain on a full page then it me=
ans
> it may be able to access address it should not. Can you explain why this =
is
> fine?
>=20

The idea was that xen receives some memory from the dt_node linux,scmi_mem,
then we split memory between the agents, so each agent get 1 page (we
allocate 0x10 pages right now).
But this is a good point, I think we should check length to be aligned
before making any permission changes.
I will add it in v2.=20
Thank you for remark.

Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:20:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:20:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248667.428901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE5P-0007Pu-EN; Fri, 17 Dec 2021 14:19:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248667.428901; Fri, 17 Dec 2021 14:19:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE5P-0007Pn-Am; Fri, 17 Dec 2021 14:19:51 +0000
Received: by outflank-mailman (input) for mailman id 248667;
 Fri, 17 Dec 2021 14:19:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myE5O-0007Ph-Us
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:19:50 +0000
Received: from ppsw-32.csi.cam.ac.uk (ppsw-32.csi.cam.ac.uk [131.111.8.132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 63d5da0d-5f44-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 15:19:48 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44794)
 by ppsw-32.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.136]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myE59-000FQm-2e (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 14:19:35 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 5CAB71FA77;
 Fri, 17 Dec 2021 14:19:35 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 63d5da0d-5f44-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <b49a9f16-a556-723f-5ec5-0642f919b7f1@srcf.net>
Date: Fri, 17 Dec 2021 14:19:35 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers
Content-Language: en-GB
To: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "joshua.c.whitehead@gmail.com" <joshua.c.whitehead@gmail.com>
References: <20211122141742.3075-1-stewart.hildebrand@dornerworks.com>
 <c0228394-2dfe-717d-e35e-7120621df27f@suse.com>
 <BN3P110MB0484716C62279B1525F351E88C9F9@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <BN3P110MB0484716C62279B1525F351E88C9F9@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 22/11/2021 14:54, Stewart Hildebrand wrote:
> On Monday, November 22, 2021 9:39 AM, From: Jan Beulich wrote:
>> On 22.11.2021 15:17, Stewart Hildebrand wrote:
>>> Josh works at another company now
>> You don't happen to know his email there, do you? Else if would have been
>> good to Cc him so he could confirm.
>>
>> Jan
> I added Josh in CC. Josh - will you confirm?

Given the request was made by an existing maintainer and there's been no
reply for almost a month, I'm going to commit this patch now.

If further adjustments are wanted/needed in the future, we can accommodate.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:23:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:23:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248671.428912 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE8b-0000Lu-Ud; Fri, 17 Dec 2021 14:23:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248671.428912; Fri, 17 Dec 2021 14:23:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE8b-0000Ln-Qx; Fri, 17 Dec 2021 14:23:09 +0000
Received: by outflank-mailman (input) for mailman id 248671;
 Fri, 17 Dec 2021 14:23:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Vth8=RC=dornerworks.com=Stewart.Hildebrand@srs-se1.protection.inumbo.net>)
 id 1myE8a-0000Lf-Es
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:23:08 +0000
Received: from USG02-BN3-obe.outbound.protection.office365.us
 (mail-bn3usg02on0616.outbound.protection.office365.us
 [2001:489a:2202:c::616])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d818a67c-5f44-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 15:23:05 +0100 (CET)
Received: from BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:40b::16)
 by BN3P110MB0561.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:40c::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec
 2021 14:22:58 +0000
Received: from BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM
 ([fe80::44b1:45a8:f0a5:d0f8]) by BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM
 ([fe80::44b1:45a8:f0a5:d0f8%12]) with mapi id 15.20.4801.016; Fri, 17 Dec
 2021 14:22:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d818a67c-5f44-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none;
 b=xCIw4X7qfAJ2q57Nu6MDtrZmHoBJjX0lZhVUVyNLPjtRq3g1a8thLKNj84O3as6CFlOy0qRpNFMbKk6ilg9MleLy6CgFsKEnfDndFmQO8AlW0YwMbizCidB7BLXtrEUnJoOT1F48v+gZ6Z2qTqDFYyr27MKO1gVegl350ePmv4dSA1OMWDmPZrK18Ldz+TuyuIZ+hKjzaC1IarstE6lApwZND7Q9hYPF8d/ZN2f6rI/nrvBd02PJAvn/V+YGoJ9VCKFJ3wGI8O1Ub2g3I0LXggaEz7XjRp6fLUwJOEIIPTCwgbXIOljKJ8poQrf9+o1JbETnehD1uc1QSML2SJBnEA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector5401;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JyW97FmFoVTbqLxXSjICLh3aCDNqjYKKaaYNC4zMmBI=;
 b=BYejgBtqjhMrEmcysiANmzDpS0swDJxp/oOwBo/0wZR1NHdBbi+nM3yoQcr/yQgVCfuMB8+iMiy6clYWQxNhGUC1tlmL1NUZY9JsvG0oy5lgBuqkre2k88Ypp+0+2g+hjCCb4oMNaaJHdgZf3YgUwhglsdmzG011epp/p/Vj9pwUzydDNoXT7o91Q6QD7c9DzFA6Sdv/7SPwzK+6NHOswzCnMcpQjm01JfU0rjd2GN2KKfCKhlX15s2tLCP7bmSDSn/LAq8GeVq9gJfVgn4+NDH5Up8EyCc0z+8fUa+Xd0vKH9rB3nEanNMT0I8EI9XxTK+ITAljgbA2N5HUbeYHsQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=dornerworks.com; dmarc=pass action=none
 header.from=dornerworks.com; dkim=pass header.d=dornerworks.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dornerworks.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JyW97FmFoVTbqLxXSjICLh3aCDNqjYKKaaYNC4zMmBI=;
 b=lzjviGlX4SDz3RWW0Qol01lgqXAf6cTXL+I4TUoVa+BlQb33N+Gj9WlbEjgqN24FHuXvi0MW2CUSjCfVyZt0xZpgkjKUGSUie37YH/RYOG2p+cZ6ZQJ5wCuPdmusgAuEskdkl2EUPPthpgHtqsV74vT6ZgcoIp4ZyNowZ8TmjSNE4lo7r2I+C4sQ6WbOPHINLxIb52JUJYv9DVLlHPSxGLslQGH17VNSrNmZqTQtBdcUXrO113h1Qdz+kfSm/g0lC7GAEY3H91JW+z+b6WQaasDKGPKhcQdrRslgpCzxblKYp+HCuEY5kHMs2T0BDSg9vTDxdnonUtC3azoE16JCSg==
From: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>
To: Andrew Cooper <amc96@srcf.net>, Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu
	<wl@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, "joshua.c.whitehead@gmail.com"
	<joshua.c.whitehead@gmail.com>
Subject: RE: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers
Thread-Topic: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers
Thread-Index: AQHX36vD17guMUdgIUiaApgKD9n8y6wPng8AgAADJpCAJ0GvgIAAAGSg
Date: Fri, 17 Dec 2021 14:22:58 +0000
Message-ID:
 <BN3P110MB04842B6455384AC2C2D5524F8C789@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
References: <20211122141742.3075-1-stewart.hildebrand@dornerworks.com>
 <c0228394-2dfe-717d-e35e-7120621df27f@suse.com>
 <BN3P110MB0484716C62279B1525F351E88C9F9@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
 <b49a9f16-a556-723f-5ec5-0642f919b7f1@srcf.net>
In-Reply-To: <b49a9f16-a556-723f-5ec5-0642f919b7f1@srcf.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=dornerworks.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7831d3c4-70ac-4b5e-fcd4-08d9c168b9cd
x-ms-traffictypediagnostic: BN3P110MB0561:
x-microsoft-antispam-prvs:
 <BN3P110MB0561807F8ABB0EC60814E6188C789@BN3P110MB0561.NAMP110.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 CnPSexTLR2DwcsmtoeMIkH5W9WEm9H2tnCjztC0H5s8N2Ozzx4FXOeB5LNyvMdIKmSCWOXn7/C1w2c18PitImFxsQzs49lfR+ndns3zksj1VPog1umP/v6PhTxhCFiHsHlRf+0h0Maj0VODoi0YYh7sKK1tRgNl33QOwKBWJ5IUnXJRiFDXspdfULigqoiIvE3kf1VMEAsYLs/h9PoooFKQ3lovKsIq1Agp7FYLtdo6sEd4I5/3FLmAh2nBA+BY0RMJKZ2dpeLDy72bY4lYZZQ70pOKdpVEKrC3ZxSuzCtKhKOWWfUnzfk21jZk0nNJ9wOhfWu2FW3jYF6hdFJuXlbvGBj8dhooP0qSFyPoxWlvVHlTQ0FYwEyCSu8kmHkT6LoR+RRBsaQTUYmBDMxQOm/mC5OxsTK9IUGwTclu3+zW2CuGaY4ESamHNMi3SFWJKJMSgzxS8X9EaGQKZ4QGM3fkyAqRgLNz3ozhQCbDf59ZJtbJU5FG0pAuM4nP3CTzGVCOKhYSwV8Q6YSremHhqDcvThQPnnNqOhl3lxB0UXvMiiNCb536B7urR8kNg6PIp59Xj++EmPNAM32vw9wHwqGdhz8gdeoygzSjt1YK+WmCHGjh1aeoxQBEGkUhdHehz
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39830400003)(136003)(346002)(396003)(33656002)(55016003)(66476007)(7416002)(76116006)(186003)(52536014)(7696005)(54906003)(2906002)(86362001)(316002)(83380400001)(110136005)(38070700005)(66946007)(8676002)(38100700002)(6506007)(9686003)(66556008)(66446008)(122000001)(8936002)(4326008)(53546011)(64756008)(5660300002)(71200400001)(4744005)(508600001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 vf+dZmNQPc0PSzW3wfgV/mn69dxKuPjL7riKehNyXboiOGHPetasLE0rc/4f7CEFgrFq+L4vA3Kb9rIkETAmWm4BIcKjAeKMmC+1zMnKrt9mj7RnKVQjriB5tz92czo4s/yDrQCKpnYB+Flu+NMwErrpibmtKuEa5rDQBTmNn9nPIwJ/htTrTY5KjKQMeS1b2na6K/MYDB5tvX/MrEKsWw==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: dornerworks.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 7831d3c4-70ac-4b5e-fcd4-08d9c168b9cd
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2021 14:22:58.5023
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 097cf9aa-db69-4b12-aeab-ab5f513dbff9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3P110MB0561

T24gRnJpZGF5LCBEZWNlbWJlciAxNywgMjAyMSA5OjIwIEFNLCBBbmRyZXcgQ29vcGVyIHdyb3Rl
Og0KPiBPbiAyMi8xMS8yMDIxIDE0OjU0LCBTdGV3YXJ0IEhpbGRlYnJhbmQgd3JvdGU6DQo+ID4g
T24gTW9uZGF5LCBOb3ZlbWJlciAyMiwgMjAyMSA5OjM5IEFNLCBGcm9tOiBKYW4gQmV1bGljaCB3
cm90ZToNCj4gPj4gT24gMjIuMTEuMjAyMSAxNToxNywgU3Rld2FydCBIaWxkZWJyYW5kIHdyb3Rl
Og0KPiA+Pj4gSm9zaCB3b3JrcyBhdCBhbm90aGVyIGNvbXBhbnkgbm93DQo+ID4+IFlvdSBkb24n
dCBoYXBwZW4gdG8ga25vdyBoaXMgZW1haWwgdGhlcmUsIGRvIHlvdT8gRWxzZSBpZiB3b3VsZCBo
YXZlDQo+ID4+IGJlZW4gZ29vZCB0byBDYyBoaW0gc28gaGUgY291bGQgY29uZmlybS4NCj4gPj4N
Cj4gPj4gSmFuDQo+ID4gSSBhZGRlZCBKb3NoIGluIENDLiBKb3NoIC0gd2lsbCB5b3UgY29uZmly
bT8NCj4gDQo+IEdpdmVuIHRoZSByZXF1ZXN0IHdhcyBtYWRlIGJ5IGFuIGV4aXN0aW5nIG1haW50
YWluZXIgYW5kIHRoZXJlJ3MgYmVlbiBubw0KPiByZXBseSBmb3IgYWxtb3N0IGEgbW9udGgsIEkn
bSBnb2luZyB0byBjb21taXQgdGhpcyBwYXRjaCBub3cuDQoNClRoYW5rIHlvdSwgdGhvdWdoIGl0
IGFwcGVhcnMgdGhlIHBhdGNoIHdhcyBhbHJlYWR5IGNvbW1pdHRlZC4NCg0KU3Rldw0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:24:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:24:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248674.428922 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE9o-0000vD-9M; Fri, 17 Dec 2021 14:24:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248674.428922; Fri, 17 Dec 2021 14:24:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myE9o-0000v6-6H; Fri, 17 Dec 2021 14:24:24 +0000
Received: by outflank-mailman (input) for mailman id 248674;
 Fri, 17 Dec 2021 14:24:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myE9n-0000ur-3a
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:24:23 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 06c43691-5f45-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 15:24:22 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44264)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myE9a-000HQd-is (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 14:24:10 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 85D8A1FD00;
 Fri, 17 Dec 2021 14:24:10 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 06c43691-5f45-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <5cb9d91e-4b2a-97a3-ca65-550e5c3b5648@srcf.net>
Date: Fri, 17 Dec 2021 14:24:10 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] MAINTAINERS: remove Josh from ARINC 653 maintainers
Content-Language: en-GB
To: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
 Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 "joshua.c.whitehead@gmail.com" <joshua.c.whitehead@gmail.com>
References: <20211122141742.3075-1-stewart.hildebrand@dornerworks.com>
 <c0228394-2dfe-717d-e35e-7120621df27f@suse.com>
 <BN3P110MB0484716C62279B1525F351E88C9F9@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
 <b49a9f16-a556-723f-5ec5-0642f919b7f1@srcf.net>
 <BN3P110MB04842B6455384AC2C2D5524F8C789@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <BN3P110MB04842B6455384AC2C2D5524F8C789@BN3P110MB0484.NAMP110.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 17/12/2021 14:22, Stewart Hildebrand wrote:
> On Friday, December 17, 2021 9:20 AM, Andrew Cooper wrote:
>> On 22/11/2021 14:54, Stewart Hildebrand wrote:
>>> On Monday, November 22, 2021 9:39 AM, From: Jan Beulich wrote:
>>>> On 22.11.2021 15:17, Stewart Hildebrand wrote:
>>>>> Josh works at another company now
>>>> You don't happen to know his email there, do you? Else if would have
>>>> been good to Cc him so he could confirm.
>>>>
>>>> Jan
>>> I added Josh in CC. Josh - will you confirm?
>> Given the request was made by an existing maintainer and there's been no
>> reply for almost a month, I'm going to commit this patch now.
> Thank you, though it appears the patch was already committed.

Yeah - just spotted that while pulling it off the list.

Sorry for the noise.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:32:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:32:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248681.428934 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEHT-0002ZU-3H; Fri, 17 Dec 2021 14:32:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248681.428934; Fri, 17 Dec 2021 14:32:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEHS-0002ZN-Uf; Fri, 17 Dec 2021 14:32:18 +0000
Received: by outflank-mailman (input) for mailman id 248681;
 Fri, 17 Dec 2021 14:32:17 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myEHR-0002ZF-1g
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:32:17 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEHQ-0004pK-1Y; Fri, 17 Dec 2021 14:32:16 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEHP-0006ul-Qb; Fri, 17 Dec 2021 14:32:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=9VH/9nmlB4Q+cyXAeg+bYjc0+mIFUQZWDLjdYR2MDvM=; b=YYT2ca54LMSXk2kNMVcfSn3tZU
	VdoXaCqktMf6RUnCWp1Xk26cCupIKvFVYK8RTZzjXT422ebzdC0L4lWGr9UeqD6RpCjKhjEKfh9Ck
	cQw+g0ZQ1c4q4+pwBvmayqLD/1qrMtp00Nqk/+8RRCa0KgxhIT4z9tvL7mocpNE6ldQ8=;
Message-ID: <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
Date: Fri, 17 Dec 2021 14:32:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
To: Jan Beulich <jbeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Rahul Singh <Rahul.Singh@arm.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
 <YbscoZG/NRP6lMof@Air-de-Roger>
 <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jan,

On 16/12/2021 13:37, Jan Beulich wrote:
> On 16.12.2021 12:01, Roger Pau Monné wrote:
>> On Thu, Dec 16, 2021 at 10:18:32AM +0000, Rahul Singh wrote:
>>> Hi Roger,
>>>
>>> Thanks for reviewing the code.
>>>
>>>> On 14 Dec 2021, at 12:37 pm, Roger Pau Monné <roger.pau@citrix.com> wrote:
>>>>
>>>> On Tue, Dec 14, 2021 at 10:45:17AM +0000, Rahul Singh wrote:
>>>>> +              unsigned long *data)
>>>>> {
>>>>> -    const struct domain *d = v->domain;
>>>>> -    struct vpci_msix *msix = msix_find(d, addr);
>>>>>      const struct vpci_msix_entry *entry;
>>>>>      unsigned int offset;
>>>>>
>>>>>      *data = ~0ul;
>>>>>
>>>>>      if ( !msix )
>>>>> -        return X86EMUL_RETRY;
>>>>> +        return VPCI_EMUL_RETRY;
>>>>>
>>>>>      if ( !access_allowed(msix->pdev, addr, len) )
>>>>> -        return X86EMUL_OKAY;
>>>>> +        return VPCI_EMUL_OKAY;
>>>>>
>>>>>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) )
>>>>>      {
>>>>> @@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
>>>>>          switch ( len )
>>>>>          {
>>>>>          case 4:
>>>>> -            *data = readl(addr);
>>>>> +            *data = vpci_arch_readl(addr);
>>>>
>>>> Why do you need a vpci wrapper around the read/write handlers? AFAICT
>>>> arm64 also has {read,write}{l,q}. And you likely want to protect the
>>>> 64bit read with CONFIG_64BIT if this code is to be made available to
>>>> arm32.
>>>
>>> I need the wrapper because {read,write}{l,q} function argument is different for ARM and x86.
>>> ARM {read,wrie}(l,q}  function argument is pointer to the address whereas X86  {read,wrie}(l,q}
>>> function argument is address itself.
>>
>> Oh, that's a shame. I don't think there's a need to tag those helpers
>> with the vpci_ prefix though. Could we maybe introduce
>> bus_{read,write}{b,w,l,q} helpers that take the same parameters on all
>> arches?
>>
>> It would be even better to fix the current ones so they take the same
>> parameters on x86 and Arm, but that would mean changing all the call
>> places in one of the arches.
> 
> Yet still: +1 for removing the extra level of indirection. Imo these
> trivial helpers should never have diverged between arches; I have
> always been under the impression that on Linux they can be used by
> arch-independent code (or else drivers would be quite hard to write).

So technically both helpers are able to cope with pointer. The x86 one 
is also allowing to pass an address.

 From a brief look at the x86, it looks like most of the users are using 
a pointer. However, the vPCI msix code is one example where addresses 
are passed.

AFAICT, the read*/write* helpers on Linux only works with pointers. So I 
think the actions should be:
    1) Modify the vPCI MSIx code to use pointer
    2) Modify the x86 read*/write* helpers to forbid any access other 
than pointer.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:35:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248685.428944 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEKG-0003Ao-FK; Fri, 17 Dec 2021 14:35:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248685.428944; Fri, 17 Dec 2021 14:35:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEKG-0003Ah-CP; Fri, 17 Dec 2021 14:35:12 +0000
Received: by outflank-mailman (input) for mailman id 248685;
 Fri, 17 Dec 2021 14:35:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myEKE-0003Ab-AN
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:35:10 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 88f8dda6-5f46-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 15:35:09 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44266)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myEKD-000L8n-fz (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 14:35:09 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id B86191FC34;
 Fri, 17 Dec 2021 14:35:08 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88f8dda6-5f46-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <50374739-2051-1b9b-b2e7-30eef69e0673@srcf.net>
Date: Fri, 17 Dec 2021 14:35:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 2/5] x86/perfc: conditionalize HVM and shadow counters
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <ea513864-58c0-fb90-cee6-f668309fcc38@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <ea513864-58c0-fb90-cee6-f668309fcc38@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 03/12/2021 12:04, Jan Beulich wrote:
> There's no point including them when the respective functionality isn't
> enabled in the build. Note that this covers only larger groups; more
> fine grained exclusion may want to be done later on.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:38:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:38:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248689.428956 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myENE-0003ni-Uf; Fri, 17 Dec 2021 14:38:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248689.428956; Fri, 17 Dec 2021 14:38:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myENE-0003nb-Qw; Fri, 17 Dec 2021 14:38:16 +0000
Received: by outflank-mailman (input) for mailman id 248689;
 Fri, 17 Dec 2021 14:38:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myEND-0003nV-Sl
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:38:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myENB-0004xV-Gk; Fri, 17 Dec 2021 14:38:13 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myENB-0007QW-9v; Fri, 17 Dec 2021 14:38:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=va8QdcEuX8heMXQFbIFEbAYGFnGL8UWhRlJJRpBp/vA=; b=3N1owOzH7jEbyP8dRuyBPxIa6d
	kMVw6qW/XKcnYXYv0A2nTQm6OTVIjPZ5pfq8XNGjf49FT4Ny0IoGR45pwc1x/LkUMyUXQCH39+Vrt
	xEh5dNK5JB23zooPU9d8qyMt0fWUChxO++1ChKM31+nsy7hlgrcNqQR0MHgbU2f9IF9o=;
Message-ID: <c3fbd191-df91-1c4b-5bff-6df33bf57554@xen.org>
Date: Fri, 17 Dec 2021 14:38:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 24/09/2021 10:53, Jan Beulich wrote:
> Having a separate flush-all hook has always been puzzling me some. We
> will want to be able to force a full flush via accumulated flush flags
> from the map/unmap functions. Introduce a respective new flag and fold
> all flush handling to use the single remaining hook.
> 
> Note that because of the respective comments in SMMU and IPMMU-VMSA
> code, I've folded the two prior hook functions into one. For SMMU-v3,
> which lacks a comment towards incapable hardware, I've left both
> functions in place on the assumption that selective and full flushes
> will eventually want separating.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

For the Arm part:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:42:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:42:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248693.428967 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEQw-0005N5-E9; Fri, 17 Dec 2021 14:42:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248693.428967; Fri, 17 Dec 2021 14:42:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEQw-0005My-Ac; Fri, 17 Dec 2021 14:42:06 +0000
Received: by outflank-mailman (input) for mailman id 248693;
 Fri, 17 Dec 2021 14:42:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myEQv-0005Ms-2k
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:42:05 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEQs-00051C-O0; Fri, 17 Dec 2021 14:42:02 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEQs-0007cQ-ID; Fri, 17 Dec 2021 14:42:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=fOvVGrdGzqfCcKMwSSZQjwGBe5L71b2NBoZ5IlFxmA8=; b=YO4Uay7g3UEEoIMv7hTwb3LRZ8
	0+N7WYpe52r3JW6ohN07wylI9Tc8Pvd5+8g48rPJhNDwcy7GVoGTAEE1iedMB8WdCLcbYIeOfJeGi
	jF+CxglBK3BSenTrFe8d1aSYm0KfqShPXf0DxWP5eKBNmjO9ql7/tdZSCLiuNrJfxE4o=;
Message-ID: <4ac00ca3-6db8-d16f-8e86-b4c8d5e93f60@xen.org>
Date: Fri, 17 Dec 2021 14:42:00 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page()
 hooks
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <7500296c-588e-983e-35ac-39048a72cb47@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <7500296c-588e-983e-35ac-39048a72cb47@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 24/09/2021 10:44, Jan Beulich wrote:
> Or really, in the case of ->map_page(), accommodate it in the existing
> "flags" parameter. All call sites will pass 0 for now.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

For the Arm bits:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:43:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:43:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248698.428978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myESD-00061a-T5; Fri, 17 Dec 2021 14:43:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248698.428978; Fri, 17 Dec 2021 14:43:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myESD-00061T-Pz; Fri, 17 Dec 2021 14:43:25 +0000
Received: by outflank-mailman (input) for mailman id 248698;
 Fri, 17 Dec 2021 14:43:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myESC-00061N-8y
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:43:24 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myES9-00054C-UG; Fri, 17 Dec 2021 14:43:21 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myES9-0007gr-N8; Fri, 17 Dec 2021 14:43:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=45fT3HZdmHIyU5+qdTRu8J/nl+vxCT+pYN8JBODCuFA=; b=BbfoiSIQsDLab2mm7B0wosAHPH
	8dvN3mfu7RoTQIPeHF0ZCWnIa4YpSTwGSjHP/7AedZhIIyUzhA4I7PHHsxWaeGagmPfoJMi1dzXWz
	5ewLpSeUiBjuow7AnexmhbEBQ1MRIAsvM2l9Z3jiTIBLDOn1obEWpeLriO+heb/RLJH4=;
Message-ID: <efe0c869-e88f-eb14-93a9-866cb99cb1a8@xen.org>
Date: Fri, 17 Dec 2021 14:43:19 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v2 03/18] IOMMU: have vendor code announce supported page
 sizes
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Rahul Singh <Rahul.Singh@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <3f0adf5b-cc2a-1b72-8376-baad574fa824@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <3f0adf5b-cc2a-1b72-8376-baad574fa824@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 24/09/2021 10:43, Jan Beulich wrote:
> Generic code will use this information to determine what order values
> can legitimately be passed to the ->{,un}map_page() hooks. For now all
> ops structures simply get to announce 4k mappings (as base page size),
> and there is (and always has been) an assumption that this matches the
> CPU's MMU base page size (eventually we will want to permit IOMMUs with
> a base page size smaller than the CPU MMU's).
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:47:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:47:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248703.428988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEVe-0006g1-Cq; Fri, 17 Dec 2021 14:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248703.428988; Fri, 17 Dec 2021 14:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEVe-0006fu-9R; Fri, 17 Dec 2021 14:46:58 +0000
Received: by outflank-mailman (input) for mailman id 248703;
 Fri, 17 Dec 2021 14:46:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myEVc-0006fo-8y
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:46:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEVb-00057P-OM; Fri, 17 Dec 2021 14:46:55 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myEVb-00085O-Hk; Fri, 17 Dec 2021 14:46:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=mBIQsXzTBAEeE8FPJ7ujCFjv5Sg6MjFfq6mR8MsqQDc=; b=So3qbaWT0EY/SA9rZ68SpcAYea
	EYYJd5iJXhc8xfadiKWg1CBmMWEUtRY3FTu5keRd7O2p4srrgSUTbDTbCB2Ar+iGxsq5zEsStYcKb
	sh6G+fCecoBrCY4d4FrDRc+kZnax4PVKZuz+64t7nJy6UOtZIuqAtYkR6bi7MPKngJPc=;
Message-ID: <0ab6d208-c290-72d9-4e0c-2c86d1280d44@xen.org>
Date: Fri, 17 Dec 2021 14:46:53 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/2] mm: introduce INVALID_{G,M}FN_RAW
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
References: <9725c93e-c227-f29f-07a4-65e383bb7858@suse.com>
 <6d2d29ca-0495-5029-afc8-7248f462db06@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6d2d29ca-0495-5029-afc8-7248f462db06@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 10/12/2021 09:39, Jan Beulich wrote:
> This allows properly tying together INVALID_{G,M}FN and
> INVALID_{G,M}FN_INITIALIZER as well as using the actual values in
> compile time constant expressions (or even preprocessor dirctives).
> 
> Since INVALID_PFN is unused, and with x86'es paging_mark_pfn_dirty()
> being the only user of pfn_t it also doesn't seem likely that new uses
> would appear, remove that one at this same occasion.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:51:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:51:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248707.428999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEZZ-0008Dk-Tb; Fri, 17 Dec 2021 14:51:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248707.428999; Fri, 17 Dec 2021 14:51:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEZZ-0008Dd-Qb; Fri, 17 Dec 2021 14:51:01 +0000
Received: by outflank-mailman (input) for mailman id 248707;
 Fri, 17 Dec 2021 14:51:01 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEZZ-0008DT-15; Fri, 17 Dec 2021 14:51:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEZY-0005CA-V5; Fri, 17 Dec 2021 14:51:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEZY-0004BK-Lz; Fri, 17 Dec 2021 14:51:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myEZY-0004BC-LX; Fri, 17 Dec 2021 14:51:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ilH1n/2/lGEtVReAAS0b/2TJjbV7FQxoWHQDRbv0cvA=; b=0kJCBc8dvPG51emKUqFSR60RpO
	PbCa0wg25BGoPBiabYkZLITO2d5K0LjCzzwDuF06eEt3dEDptZX3ltsYaI0JygPpmIPhvk+P1l5ua
	lvO58IbGrSS3WmXC2r/Qe3Aj/WRgYGpWijAdyDVJbHf9uOedZ4kgnaMeUQ/GLR9RmrMo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167460-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167460: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c81fc9f313c031f1201181cfb40e3c3ee599e04f
X-Osstest-Versions-That:
    xen=1c4589280ae4e9ba34266e674459fffd6f0282dc
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 14:51:00 +0000

flight 167460 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167460/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  c81fc9f313c031f1201181cfb40e3c3ee599e04f
baseline version:
 xen                  1c4589280ae4e9ba34266e674459fffd6f0282dc

Last test of basis   167458  2021-12-17 08:01:39 Z    0 days
Testing same since   167460  2021-12-17 12:01:45 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Juergen Gross <jgross@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   1c4589280a..c81fc9f313  c81fc9f313c031f1201181cfb40e3c3ee599e04f -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 14:58:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 14:58:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248715.429011 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEgp-0000UR-Nt; Fri, 17 Dec 2021 14:58:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248715.429011; Fri, 17 Dec 2021 14:58:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEgp-0000UK-Kp; Fri, 17 Dec 2021 14:58:31 +0000
Received: by outflank-mailman (input) for mailman id 248715;
 Fri, 17 Dec 2021 14:58:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+ZwG=RC=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1myEgn-0000UE-Og
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 14:58:30 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on061e.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::61e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca895d27-5f49-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 15:58:28 +0100 (CET)
Received: from AS9PR06CA0156.eurprd06.prod.outlook.com (2603:10a6:20b:45c::13)
 by DBBPR08MB4856.eurprd08.prod.outlook.com (2603:10a6:10:f6::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.16; Fri, 17 Dec
 2021 14:58:24 +0000
Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:45c:cafe::f3) by AS9PR06CA0156.outlook.office365.com
 (2603:10a6:20b:45c::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Fri, 17 Dec 2021 14:58:24 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:58:24 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Fri, 17 Dec 2021 14:58:23 +0000
Received: from fa00f089c449.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 33AB29AA-D6AD-4912-8FB0-51C7224D9DE7.1; 
 Fri, 17 Dec 2021 14:58:12 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa00f089c449.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Fri, 17 Dec 2021 14:58:12 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB4966.eurprd08.prod.outlook.com (2603:10a6:20b:d4::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec
 2021 14:58:10 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%9]) with mapi id 15.20.4778.018; Fri, 17 Dec 2021
 14:58:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca895d27-5f49-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r9H+v4v13vyVx3PBnO9+FeLGyfSE/g37ryQFf6eq9rw=;
 b=AaeyIHAY3n/c52degxyXTcNbIabESleddNrHOI2+FCcb0GKNC2VFWCfloXrQSwYTwnsahFv49cshqmf9n3oUuReTYt2gGMCLx2rV6AsL3+2IbDfGg1IqmtCevLgZhLS3Tl6XVWh7dA02IVAJO5qDvWEluAL+aPSq/zrXWJhvxiA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: db78547aade3ac43
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=S+kYfuWtKHXt1yHSVE5VePQVR4o2XZn8NlZwvepYZeHq+kk6N/HgWdIrNcgVGsJq5KryAAMPQsKN7I6fXsQwsTvmedYf6uJVsapF5I11jIBQZjUWsoYGruPked5v5PUFFTa/A7qV/+sSbrGHIqtoSw7t8wmjrEUguWYYsB+MZuTSCX4Gd3Hs1gdtfNHB8ysogV0g1zX8S6HxK1oQBHysBqbnFvu2vNY3dCTkHCChWcD7Zm6mkPuF7HbgYwuahxv+T5mCM5Hkk8Bt11QEN5y1gIjXxZ1m1vzVfiHFMWj4jw1AlNH6xTw1f0Srfj48D+i3os2K/Ak9606N4+KE2PmdvA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=r9H+v4v13vyVx3PBnO9+FeLGyfSE/g37ryQFf6eq9rw=;
 b=Y8d87kG1n7L2vjEViINafvAf2iN56SEA1BGF2N8GoTmdJYDlrBatnGT/uoEPS2+K1yB4mlyDydPfUiBYvuY4hO0TE/kJg01whTRmyJ8PgVfG8/ymS/kuFnCnNejgApRFNzs3pw18IUcX7FpX9vgJCe1UwaAvDBqglfMrjhRRs9O1JsBN4gDLOU1QNdwxj/MKrq4Yv/0YVBrZwqvdijXhFZAikMvTqRXekxFpCWfjIavmxi1Yc/0ZHayhDDMUdTkByU8YT9aW9P6ENLc7PMdffqTvDzG2cRR0O/3DedW97W49Q0wVA7+zQdfhBZPLfPqD+T5pK83Dx9/ilZ/Y4pxlhw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=r9H+v4v13vyVx3PBnO9+FeLGyfSE/g37ryQFf6eq9rw=;
 b=AaeyIHAY3n/c52degxyXTcNbIabESleddNrHOI2+FCcb0GKNC2VFWCfloXrQSwYTwnsahFv49cshqmf9n3oUuReTYt2gGMCLx2rV6AsL3+2IbDfGg1IqmtCevLgZhLS3Tl6XVWh7dA02IVAJO5qDvWEluAL+aPSq/zrXWJhvxiA=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Julien Grall <julien@xen.org>
CC: Jan Beulich <jbeulich@suse.com>, =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?=
	<roger.pau@citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Bertrand
 Marquis <Bertrand.Marquis@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Topic: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Index:
 AQHX8NfN625eD/1es0eaHkpOvTmQ3Kwx7OWAgAL9+QCAAAwcgIAAK1kAgAGhwICAAAc/gA==
Date: Fri, 17 Dec 2021 14:58:10 +0000
Message-ID: <F52E11FE-2AE5-423C-879E-B6BFFF348C91@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
 <YbscoZG/NRP6lMof@Air-de-Roger>
 <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
 <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
In-Reply-To: <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 1855d596-d2ae-490b-b5ff-08d9c16dacb1
x-ms-traffictypediagnostic:
	AM6PR08MB4966:EE_|VE1EUR03FT013:EE_|DBBPR08MB4856:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB48560CF3661CFEF026690925FC789@DBBPR08MB4856.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 SH/57zHlSBphpkxoqkfNX3vDV4i5bjaezeN6Oxe6giO14uokCUJhJpelytieg6+IoBcYUfS1gqusvdJwjM1DEEeHY6SC9jNuKYCsTFN4O6s3iUtVhcbuRXcaGt/8YVBWfLv5REiclSojheFDve4HCo8pYOEQ3KAJE3hjE2c24pFjnStjetuz2dx8kKjUAeyTY2qWSbV49PhC4VImj0eZVNyNdWuOl7LHadMqMfZdklIZEdvEWuS3zsz7VeSREThcrhAatW8OCbRcLYWbUeLT1//LeU8CjrQrNpnBHW7VHgRyLOKEXeXqnPER2rGCAFZwxTs+0kvOysJB2oaDS6Y9N0c+4T+xCeHKCmKe1o67QqBSTPFT2FzUOIsldeLW1AMj//pO5rKcn6dr666+HUk6sSO/n93YCMRotrE71tUnCAs2ZQ+Xvov4fBFXEHpcUOuhNwb7pK3pu5r5czBMnWDjcnX4PzrjmWjvJxXymeTlOh4yleI6j4ImXgQX1XEn/SmtnHOdwV/00IdxaCgBC+jG7hHht0dFDirxVw0/X/2u0MT8LDa2/kA7AlWk32OyGcsaDaQG36jrQL5yHY2IQVzl71btrOfCrtSalQUm5brnWMPXmE8czyAhvTcPznkarziJPLPKLPWKEEpClUZs4VrqLieGvCm9zcd+W1YgE2PADVbq7r0GmrYMy/4DzlL6RRROVBHu+UmF431sa05UDdf+mH3G+yHSgEhYhMCeyJC3yE+iT7CLIPC5riLNu3wGwB3C
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(53546011)(71200400001)(6512007)(6916009)(26005)(6506007)(64756008)(8936002)(186003)(66446008)(2616005)(38070700005)(54906003)(5660300002)(2906002)(83380400001)(8676002)(508600001)(76116006)(66946007)(66476007)(91956017)(66556008)(86362001)(122000001)(316002)(38100700002)(33656002)(36756003)(4326008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <BCC1383811B4A6499C4F9661055AB9DD@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4966
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	73f80da3-dece-45e3-4041-08d9c16da44e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1tfWHVCteabuiONCv5Djk6zgfTEXmLsx2ITYUrEEJKDrejm99RCDOttPxOR1aAfMAJWaKCOMT5xJJnnHTVfZ0xSNGPof1xYE5b2zM89yL76amlSeIg7NLW6t0OO20By29zDkFBhFTZa3p4KSu2VowP1lX84OVglNSEb4goA6/9ko8+mFmP/chlDeE7pFU1YhdU7NPsL8MGmH8wfyK9SWOMry2Gc0qtyzS21EaHnthV/b+sByLnfTMvgUIBiognkQrPhmQrZku29vcpwhklxqAWrx71zE7wgKmkqZehepq9YK1YtvoVQSPcfCThCahkeEhQ4lzf2eAk8iGKrptLylVxdkervse43kh6ihZ22KIvzjSyVrd5YFtgTzzTxLSl+y1vYNMi7UVjeDXxMJEJNJMH8sGAui0RmqqYfVT0tg2+fdoz4Pkx+5n2zMhmhHelE9o0GiFyK2S1MeaiiBQbgtF94oHF5u6ehQpSTUGynTr/82+pqH5SgA9PLeyBiQ2f0VkjnLxvwJ98x/pv3o/VnEnwJeTzo1c3TD/4VuyhQ2ibhUeLLt7hu7M+dVo7p/OVz4aTV5gwsGqZdsGUV62PxsFso9bO0H01zZk1t9T35YeDwToU8LcyUI8DlKihEPcYszq2IdAn0XX2CGh7UzqEltx86kWdU0XUBUA5y6sDOGU2v7E568GRe8iSbGYAykmYOSctBpdQXjEbatdmdwohC6y03Qk2VLiIRPmBrmCn3+ByubVu/7u+ihuP4gF2P9gOOtO/A+hRN58fJKM28cjuWbLg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(40460700001)(6512007)(2616005)(6506007)(33656002)(336012)(107886003)(508600001)(83380400001)(186003)(6862004)(82310400004)(26005)(36860700001)(70206006)(6486002)(47076005)(54906003)(36756003)(356005)(5660300002)(53546011)(316002)(4326008)(2906002)(8676002)(8936002)(81166007)(70586007)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:58:24.1431
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1855d596-d2ae-490b-b5ff-08d9c16dacb1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4856

SGkgSnVsaWVuDQoNCj4gT24gMTcgRGVjIDIwMjEsIGF0IDI6MzIgcG0sIEp1bGllbiBHcmFsbCA8
anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgSmFuLA0KPiANCj4gT24gMTYvMTIvMjAy
MSAxMzozNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBPbiAxNi4xMi4yMDIxIDEyOjAxLCBSb2dl
ciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+IE9uIFRodSwgRGVjIDE2LCAyMDIxIGF0IDEwOjE4OjMy
QU0gKzAwMDAsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+PiBIaSBSb2dlciwNCj4+Pj4gDQo+Pj4+
IFRoYW5rcyBmb3IgcmV2aWV3aW5nIHRoZSBjb2RlLg0KPj4+PiANCj4+Pj4+IE9uIDE0IERlYyAy
MDIxLCBhdCAxMjozNyBwbSwgUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiBPbiBUdWUsIERlYyAxNCwgMjAyMSBhdCAxMDo0NToxN0FN
ICswMDAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+Pj4+PiArICAgICAgICAgICAgICB1bnNpZ25l
ZCBsb25nICpkYXRhKQ0KPj4+Pj4+IHsNCj4+Pj4+PiAtICAgIGNvbnN0IHN0cnVjdCBkb21haW4g
KmQgPSB2LT5kb21haW47DQo+Pj4+Pj4gLSAgICBzdHJ1Y3QgdnBjaV9tc2l4ICptc2l4ID0gbXNp
eF9maW5kKGQsIGFkZHIpOw0KPj4+Pj4+ICAgICBjb25zdCBzdHJ1Y3QgdnBjaV9tc2l4X2VudHJ5
ICplbnRyeTsNCj4+Pj4+PiAgICAgdW5zaWduZWQgaW50IG9mZnNldDsNCj4+Pj4+PiANCj4+Pj4+
PiAgICAgKmRhdGEgPSB+MHVsOw0KPj4+Pj4+IA0KPj4+Pj4+ICAgICBpZiAoICFtc2l4ICkNCj4+
Pj4+PiAtICAgICAgICByZXR1cm4gWDg2RU1VTF9SRVRSWTsNCj4+Pj4+PiArICAgICAgICByZXR1
cm4gVlBDSV9FTVVMX1JFVFJZOw0KPj4+Pj4+IA0KPj4+Pj4+ICAgICBpZiAoICFhY2Nlc3NfYWxs
b3dlZChtc2l4LT5wZGV2LCBhZGRyLCBsZW4pICkNCj4+Pj4+PiAtICAgICAgICByZXR1cm4gWDg2
RU1VTF9PS0FZOw0KPj4+Pj4+ICsgICAgICAgIHJldHVybiBWUENJX0VNVUxfT0tBWTsNCj4+Pj4+
PiANCj4+Pj4+PiAgICAgaWYgKCBWTVNJWF9BRERSX0lOX1JBTkdFKGFkZHIsIG1zaXgtPnBkZXYt
PnZwY2ksIFZQQ0lfTVNJWF9QQkEpICkNCj4+Pj4+PiAgICAgew0KPj4+Pj4+IEBAIC0yMTAsMTEg
KzE5NCwxMSBAQCBzdGF0aWMgaW50IG1zaXhfcmVhZChzdHJ1Y3QgdmNwdSAqdiwgdW5zaWduZWQg
bG9uZyBhZGRyLCB1bnNpZ25lZCBpbnQgbGVuLA0KPj4+Pj4+ICAgICAgICAgc3dpdGNoICggbGVu
ICkNCj4+Pj4+PiAgICAgICAgIHsNCj4+Pj4+PiAgICAgICAgIGNhc2UgNDoNCj4+Pj4+PiAtICAg
ICAgICAgICAgKmRhdGEgPSByZWFkbChhZGRyKTsNCj4+Pj4+PiArICAgICAgICAgICAgKmRhdGEg
PSB2cGNpX2FyY2hfcmVhZGwoYWRkcik7DQo+Pj4+PiANCj4+Pj4+IFdoeSBkbyB5b3UgbmVlZCBh
IHZwY2kgd3JhcHBlciBhcm91bmQgdGhlIHJlYWQvd3JpdGUgaGFuZGxlcnM/IEFGQUlDVA0KPj4+
Pj4gYXJtNjQgYWxzbyBoYXMge3JlYWQsd3JpdGV9e2wscX0uIEFuZCB5b3UgbGlrZWx5IHdhbnQg
dG8gcHJvdGVjdCB0aGUNCj4+Pj4+IDY0Yml0IHJlYWQgd2l0aCBDT05GSUdfNjRCSVQgaWYgdGhp
cyBjb2RlIGlzIHRvIGJlIG1hZGUgYXZhaWxhYmxlIHRvDQo+Pj4+PiBhcm0zMi4NCj4+Pj4gDQo+
Pj4+IEkgbmVlZCB0aGUgd3JhcHBlciBiZWNhdXNlIHtyZWFkLHdyaXRlfXtsLHF9IGZ1bmN0aW9u
IGFyZ3VtZW50IGlzIGRpZmZlcmVudCBmb3IgQVJNIGFuZCB4ODYuDQo+Pj4+IEFSTSB7cmVhZCx3
cmllfShsLHF9ICBmdW5jdGlvbiBhcmd1bWVudCBpcyBwb2ludGVyIHRvIHRoZSBhZGRyZXNzIHdo
ZXJlYXMgWDg2ICB7cmVhZCx3cmllfShsLHF9DQo+Pj4+IGZ1bmN0aW9uIGFyZ3VtZW50IGlzIGFk
ZHJlc3MgaXRzZWxmLg0KPj4+IA0KPj4+IE9oLCB0aGF0J3MgYSBzaGFtZS4gSSBkb24ndCB0aGlu
ayB0aGVyZSdzIGEgbmVlZCB0byB0YWcgdGhvc2UgaGVscGVycw0KPj4+IHdpdGggdGhlIHZwY2lf
IHByZWZpeCB0aG91Z2guIENvdWxkIHdlIG1heWJlIGludHJvZHVjZQ0KPj4+IGJ1c197cmVhZCx3
cml0ZX17Yix3LGwscX0gaGVscGVycyB0aGF0IHRha2UgdGhlIHNhbWUgcGFyYW1ldGVycyBvbiBh
bGwNCj4+PiBhcmNoZXM/DQo+Pj4gDQo+Pj4gSXQgd291bGQgYmUgZXZlbiBiZXR0ZXIgdG8gZml4
IHRoZSBjdXJyZW50IG9uZXMgc28gdGhleSB0YWtlIHRoZSBzYW1lDQo+Pj4gcGFyYW1ldGVycyBv
biB4ODYgYW5kIEFybSwgYnV0IHRoYXQgd291bGQgbWVhbiBjaGFuZ2luZyBhbGwgdGhlIGNhbGwN
Cj4+PiBwbGFjZXMgaW4gb25lIG9mIHRoZSBhcmNoZXMuDQo+PiBZZXQgc3RpbGw6ICsxIGZvciBy
ZW1vdmluZyB0aGUgZXh0cmEgbGV2ZWwgb2YgaW5kaXJlY3Rpb24uIEltbyB0aGVzZQ0KPj4gdHJp
dmlhbCBoZWxwZXJzIHNob3VsZCBuZXZlciBoYXZlIGRpdmVyZ2VkIGJldHdlZW4gYXJjaGVzOyBJ
IGhhdmUNCj4+IGFsd2F5cyBiZWVuIHVuZGVyIHRoZSBpbXByZXNzaW9uIHRoYXQgb24gTGludXgg
dGhleSBjYW4gYmUgdXNlZCBieQ0KPj4gYXJjaC1pbmRlcGVuZGVudCBjb2RlIChvciBlbHNlIGRy
aXZlcnMgd291bGQgYmUgcXVpdGUgaGFyZCB0byB3cml0ZSkuDQo+IA0KPiBTbyB0ZWNobmljYWxs
eSBib3RoIGhlbHBlcnMgYXJlIGFibGUgdG8gY29wZSB3aXRoIHBvaW50ZXIuIFRoZSB4ODYgb25l
IGlzIGFsc28gYWxsb3dpbmcgdG8gcGFzcyBhbiBhZGRyZXNzLg0KPiANCj4gRnJvbSBhIGJyaWVm
IGxvb2sgYXQgdGhlIHg4NiwgaXQgbG9va3MgbGlrZSBtb3N0IG9mIHRoZSB1c2VycyBhcmUgdXNp
bmcgYSBwb2ludGVyLiBIb3dldmVyLCB0aGUgdlBDSSBtc2l4IGNvZGUgaXMgb25lIGV4YW1wbGUg
d2hlcmUgYWRkcmVzc2VzIGFyZSBwYXNzZWQuDQoNClllcyB5b3UgYXJlIHJpZ2h0Lg0KPiANCj4g
QUZBSUNULCB0aGUgcmVhZCovd3JpdGUqIGhlbHBlcnMgb24gTGludXggb25seSB3b3JrcyB3aXRo
IHBvaW50ZXJzLiBTbyBJIHRoaW5rIHRoZSBhY3Rpb25zIHNob3VsZCBiZToNCj4gICAxKSBNb2Rp
ZnkgdGhlIHZQQ0kgTVNJeCBjb2RlIHRvIHVzZSBwb2ludGVyDQoNCkkgYW0gYWxzbyB0aGlua2lu
ZyB0byBjaGFuZ2UgdGhlIG1pc3hfcmVhZC93cml0ZSB0byB1c2UgYSBwb2ludGVyIHRvIGFkZHJl
c3MgdG8gYXZvaWQgY2hhbmdlIGluIHtyZWFkLHdyaXRlfXtiLHcsbCxxfQ0KSWYgZXZlcnlvbmUg
aXMgb2sgSSB3aWxsIHNlbmQgdGhlIG5leHQgdmVyc2lvbiB0byBtb2RpZnkgdGhlIHNhbWUuDQoN
ClJlZ2FyZHMsDQpSYWh1bA0KPiAgIDIpIE1vZGlmeSB0aGUgeDg2IHJlYWQqL3dyaXRlKiBoZWxw
ZXJzIHRvIGZvcmJpZCBhbnkgYWNjZXNzIG90aGVyIHRoYW4gcG9pbnRlci4NCj4gDQo+IENoZWVy
cywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:00:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:00:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248725.429021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEj7-00023M-57; Fri, 17 Dec 2021 15:00:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248725.429021; Fri, 17 Dec 2021 15:00:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEj7-00023F-26; Fri, 17 Dec 2021 15:00:53 +0000
Received: by outflank-mailman (input) for mailman id 248725;
 Fri, 17 Dec 2021 15:00:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myEj6-000234-9R
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:00:52 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1e2da664-5f4a-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 16:00:50 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43732)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myEiw-000AuQ-9Y (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 15:00:42 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id AF8921FD00;
 Fri, 17 Dec 2021 15:00:42 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1e2da664-5f4a-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <b083029a-6669-d03c-4b8c-c3b1ed28143c@srcf.net>
Date: Fri, 17 Dec 2021 15:00:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <efb282e9-4ddd-22d1-a2e4-36a4d0964ada@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/5] VMX: sync VM-exit perf counters with known VM-exit
 reasons
In-Reply-To: <efb282e9-4ddd-22d1-a2e4-36a4d0964ada@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 12:05, Jan Beulich wrote:
> --- a/xen/include/asm-x86/hvm/vmx/vmx.h
> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h
> @@ -220,6 +220,8 @@ static inline void pi_clear_sn(struct pi
>  #define EXIT_REASON_XSAVES              63
>  #define EXIT_REASON_XRSTORS             64
>  
> +#define EXIT_REASON_LAST                EXIT_REASON_XRSTORS
> +

Given the problems with sentinals like this in the domctl/sysctl
headers, I think this scheme would be less fragile if EXIT_REASON was an
enum.  (Also, we seriously need to reduce the scope of these headers. 
It's only just dawned on me why Intel uses EXIT_* and AMD uses VMEXIT_*)

Alternatively, what about simply this:

 #define EXIT_REASON_XSAVES              63
 #define EXIT_REASON_XRSTORS             64
+/* Remember to update VMX_PERF_EXIT_REASON_SIZE too. */

?

This avoids having yet another sentinel in the mix, and will be visible
in *every* patch review.  It also gets rid of the ifdefary in the vmexit
handler.

Another good move might be to have perfc_incra() have a printk_once()
for out-of-range indices.  That way, people using perfcounters will have
an easier time noticing if something is wrong.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:03:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:03:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248731.429032 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myElA-0002kL-Ki; Fri, 17 Dec 2021 15:03:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248731.429032; Fri, 17 Dec 2021 15:03:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myElA-0002kE-HP; Fri, 17 Dec 2021 15:03:00 +0000
Received: by outflank-mailman (input) for mailman id 248731;
 Fri, 17 Dec 2021 15:02:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myEl9-0002k6-45
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:02:59 +0000
Received: from ppsw-42.csi.cam.ac.uk (ppsw-42.csi.cam.ac.uk [131.111.8.142])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6b97f011-5f4a-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 16:02:58 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:43734)
 by ppsw-42.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myEl7-000BxV-97 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 15:02:57 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 92DE41FD00;
 Fri, 17 Dec 2021 15:02:57 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b97f011-5f4a-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <60deae51-6ccd-dd90-869a-db6099e21002@srcf.net>
Date: Fri, 17 Dec 2021 15:02:57 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <c94bc336-fdee-43af-540e-06e0904d8db7@suse.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 4/5] SVM: sync VM-exit perf counters with known VM-exit
 reasons
In-Reply-To: <c94bc336-fdee-43af-540e-06e0904d8db7@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 12:06, Jan Beulich wrote:
> This has gone out of sync over time, resulting in NPF and XSETBV exits
> incrementing the same counter. Introduce a simplistic mechanism to
> hopefully keep things in better sync going forward.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Given their large (and growing) number, I wonder whether we shouldn't
> fold "SVMexits" and "vmexits". They can't both be active at the same
> time.

Oh yeah - that's just silly having them split like this, especially as
there's no associated element name.

> --- a/xen/include/asm-x86/perfc_defn.h
> +++ b/xen/include/asm-x86/perfc_defn.h
> @@ -11,8 +11,8 @@ PERFCOUNTER_ARRAY(exceptions,
>  PERFCOUNTER_ARRAY(vmexits,              "vmexits", VMX_PERF_EXIT_REASON_SIZE)
>  PERFCOUNTER_ARRAY(cause_vector,         "cause vector", VMX_PERF_VECTOR_SIZE)
>  
> -#define VMEXIT_NPF_PERFC 141
> -#define SVM_PERF_EXIT_REASON_SIZE (1+141)
> +#define VMEXIT_NPF_PERFC 143
> +#define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1)

How does this work in the first place?  perfc_incra() is still passed 1024.

Furthermore, it's already worse than this.

401/402 are AVIC exits, and 403 is an SEV exit.  We've also gained -2 as
"busy" for transient SEV events too.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:06:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:06:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248733.429043 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEoi-0003Mg-5l; Fri, 17 Dec 2021 15:06:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248733.429043; Fri, 17 Dec 2021 15:06:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEoi-0003MZ-2t; Fri, 17 Dec 2021 15:06:40 +0000
Received: by outflank-mailman (input) for mailman id 248733;
 Fri, 17 Dec 2021 15:03:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=FZAj=RC=amazon.de=prvs=978e394f9=ahmeddan@srs-se1.protection.inumbo.net>)
 id 1myEld-00034H-Pp
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:03:29 +0000
Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7d6e7959-5f4a-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 16:03:28 +0100 (CET)
Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO
 email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com) ([10.43.8.2])
 by smtp-border-fw-2101.iad2.amazon.com with ESMTP; 17 Dec 2021 15:03:16 +0000
Received: from EX13D37EUA002.ant.amazon.com
 (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198])
 by email-inbound-relay-pdx-2a-ff3df2fe.us-west-2.amazon.com (Postfix) with
 ESMTPS id 8B7294276B; Fri, 17 Dec 2021 15:03:15 +0000 (UTC)
Received: from EX13D24EUA001.ant.amazon.com (10.43.165.233) by
 EX13D37EUA002.ant.amazon.com (10.43.165.200) with Microsoft SMTP Server (TLS)
 id 15.0.1497.26; Fri, 17 Dec 2021 15:03:14 +0000
Received: from EX13D24EUA001.ant.amazon.com ([10.43.165.233]) by
 EX13D24EUA001.ant.amazon.com ([10.43.165.233]) with mapi id 15.00.1497.026;
 Fri, 17 Dec 2021 15:03:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d6e7959-5f4a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209;
  t=1639753409; x=1671289409;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-id:mime-version:
   content-transfer-encoding;
  bh=Yckn2KgfMGO7T3K9/oAY9UiekEi0KqltBEAUWO9+7Ko=;
  b=STYWcz6TvBKQ3R1ZYKsywV1W0QX6KRCXR0mp1l/i2J4V3S0t5wizYKRf
   1Cdf2oG/6Do79Oqa5fhtL8YRJRyIggODeBsEe53YnBM1N4ib/R2sZGDrK
   /ZZ3OCh0MqJHB68PUTbKGGNDvqYlcDuajc8Nx/qouHuej9kHaLHaAIP/S
   8=;
X-IronPort-AV: E=Sophos;i="5.88,213,1635206400"; 
   d="scan'208";a="159724705"
From: "Ahmed, Daniele" <ahmeddan@amazon.de>
To: Dario Faggioli <dfaggioli@suse.com>, "julien@xen.org" <julien@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: "sstabellini@kernel.org" <sstabellini@kernel.org>, "Grall, Julien"
	<jgrall@amazon.co.uk>
Subject: Re: NULL scheduler DoS
Thread-Topic: NULL scheduler DoS
Thread-Index: AQHX81c2Y/9DsiP900CdkkESOHPjGA==
Date: Fri, 17 Dec 2021 15:03:14 +0000
Message-ID: <3125A8D2-9299-4C31-8222-B20DC35AE241@amazon.com>
References: <ED25BE5E-D695-4763-B97A-78D6040E2341@amazon.com>
 <8193a685-3ab1-9407-75f3-e335ea4406e4@xen.org>
 <f3082b8c-1388-c92b-6175-e6d8b9d4cab4@xen.org>
 <6b5e28f427ccd89505a4448f2b9e5be992a08292.camel@suse.com>
In-Reply-To: <6b5e28f427ccd89505a4448f2b9e5be992a08292.camel@suse.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.43.165.70]
Content-Type: text/plain; charset="utf-8"
Content-ID: <FD47BD1DFF7A02479D72E4179EEC7939@amazon.com>
MIME-Version: 1.0
Precedence: Bulk
Content-Transfer-Encoding: base64

SGkhDQoNCklzIHRoZXJlIGFueSB1cGRhdGUgb24gdGhpcyBpc3N1ZT8gSG93IHNob3VsZCB3ZSBt
b3ZlIGZvcndhcmQ/DQoNClRoYW5rIHlvdSwNCg0KDQrvu79PbiAxMS8wOC8yMDIxLCAxMjowOSwg
IkRhcmlvIEZhZ2dpb2xpIiA8ZGZhZ2dpb2xpQHN1c2UuY29tPiB3cm90ZToNCg0KICAgIE9uIE1v
biwgMjAyMS0wOC0wOSBhdCAyMTozOCArMDEwMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KICAgID4g
T24gMDkvMDgvMjAyMSAxODozNSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KICAgID4gPiANCiAgICA+
ID4gVGhpcyBpbXBsaWVzIHRoYXQgYSBwQ1BVIG1heSB0ZW1wb3JhcmlseSBiZSBhc3NpZ25lZCB0
byB0d28gdkNQVXMNCiAgICA+ID4gYW5kIHdlIA0KICAgID4gPiBleHBlY3QgdG8gYmUgZml4ZWQg
dXAgYWZ0ZXJ3YXJkcy4gSG93ZXZlciwgYSBkb21haW4gbWF5IGJlDQogICAgPiA+IGRlc3Ryb3ll
ZCANCiAgICA+ID4gYmVmb3JlIHRoaXMgaXMgaGFwcGVuaW5nLg0KICAgID4gPiANCiAgICA+ID4g
U28gaXQgbG9va3MgbGlrZSB0aGF0IHVuaXRfZGVhc3NpZ24oKSBpcyBub3QgYWJsZSB0byBjb3Bl
IHdpdGggdGhpcw0KICAgID4gPiBjYXNlLiBGcm9tIGEgYnJpZWYgbG9vaywgSSB0aGluayB3ZSBt
YXkgd2FudCB0byBjaGVjayBpZiB0aGUgcENQVQ0KICAgID4gPiBpcyBpbiANCiAgICA+ID4gdGhl
IHdhaXQgbGlzdC4gSWYgaXQgaXMsIHRoZW4gd2Ugc2hvdWxkIGJhaWwgb3V0Lg0KICAgID4gDQog
ICAgPiBBY3R1YWxseSwgSSB3YXMgd3JvbmcuIEl0IGxvb2tzIGxpa2UgbnVsbF91bml0X3JlbW92
ZSgpIGlzIGFscmVhZHkgDQogICAgPiBjaGVja2luZyB0aGlzIGNvbmRpdGlvbi4gQWxzbywgdGhl
IHZDUFUgc2hvdWxkIGJlIG9mZmxpbmUgKGFuZCB0aGUNCiAgICA+IHVuaXQgDQogICAgPiBhcyB3
ZWxsKSBiZWNhdXNlIHRoZXkgaGF2ZW4ndCBjb21lIG9ubGluZSB5ZXQ6DQogICAgPiANCiAgICBU
aGF0J3Mgd2hhdCBpcyBjdXJyZW50bHkgcHV6emxpbmcgbWUuDQoNCiAgICBJIG1lYW4sIHRoZSBj
cmFzaCBoYXBwZW5zIGluIHVuaXRfZGVhc3NpZ24oKSwgY2FsbGVkIGJ5DQogICAgbnVsbF91bml0
X3JlbW92ZSgpLCBjYWxsZWQgYnkgc2NoZWRfZGVzdHJveV92Y3B1KCkuDQoNCiAgICBBbmQgSSBh
Z3JlZSB0aGF0IHRoZSB1bml0IHNob3VsZCBiZSBvZmZsaW5lLCBidXQgbnVsbF91bml0X3JlbW92
ZSgpDQogICAgY2FsbHMgdW5pdF9kZWFzc2lnbigpIG9ubHkgaWYgdGhlIHVuaXQgKmlzKiBvbmxp
bmUsIHNvLi4uIFdoYXQncyBnb2luZw0KICAgIG9uPyA6LS8NCg0KICAgIFJlZ2FyZHMNCiAgICAt
LSANCiAgICBEYXJpbyBGYWdnaW9saSwgUGguRA0KICAgIGh0dHA6Ly9hYm91dC5tZS9kYXJpby5m
YWdnaW9saQ0KICAgIFZpcnR1YWxpemF0aW9uIFNvZnR3YXJlIEVuZ2luZWVyDQogICAgU1VTRSBM
YWJzLCBTVVNFIGh0dHBzOi8vd3d3LnN1c2UuY29tLw0KICAgIC0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiAgICA8PFRo
aXMgaGFwcGVucyBiZWNhdXNlIF9JXyBjaG9vc2UgaXQgdG8gaGFwcGVuIT4+IChSYWlzdGxpbiBN
YWplcmUpDQoNCgoKCkFtYXpvbiBEZXZlbG9wbWVudCBDZW50ZXIgR2VybWFueSBHbWJICktyYXVz
ZW5zdHIuIDM4CjEwMTE3IEJlcmxpbgpHZXNjaGFlZnRzZnVlaHJ1bmc6IENocmlzdGlhbiBTY2hs
YWVnZXIsIEpvbmF0aGFuIFdlaXNzCkVpbmdldHJhZ2VuIGFtIEFtdHNnZXJpY2h0IENoYXJsb3R0
ZW5idXJnIHVudGVyIEhSQiAxNDkxNzMgQgpTaXR6OiBCZXJsaW4KVXN0LUlEOiBERSAyODkgMjM3
IDg3OQoKCg==



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:07:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:07:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248739.429055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEpn-0003wY-Gg; Fri, 17 Dec 2021 15:07:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248739.429055; Fri, 17 Dec 2021 15:07:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEpn-0003wR-DU; Fri, 17 Dec 2021 15:07:47 +0000
Received: by outflank-mailman (input) for mailman id 248739;
 Fri, 17 Dec 2021 15:07:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myEpm-0003wJ-Nz
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:07:46 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 16d6beee-5f4b-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 16:07:45 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47424)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myEpk-0001wj-pR (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 15:07:44 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A62061FF1D;
 Fri, 17 Dec 2021 15:07:44 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 16d6beee-5f4b-11ec-85d3-df6b77346a89
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <b14a518b-504a-9135-e11d-0f774cc02572@srcf.net>
Date: Fri, 17 Dec 2021 15:07:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 5/5] xenperf: name "newer" hypercalls
Content-Language: en-GB
To: Jan Beulich <jbeulich@suse.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@citrix.com>, Ian Jackson
 <iwj@xenproject.org>, Wei Liu <wl@xen.org>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <dcded1c5-85c8-dd43-6662-115652ce7932@suse.com>
From: Andrew Cooper <amc96@srcf.net>
In-Reply-To: <dcded1c5-85c8-dd43-6662-115652ce7932@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 03/12/2021 12:07, Jan Beulich wrote:
> This table must not have got updated in quite a while; tmem_op for
> example has managed to not only appear since then, but also disappear
> again (adding a name for it nevertheless, to make more obvious that
> something strange is going on if the slot would ever have a non-zero
> value).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> I wasn't really sure about x86's real names for arch_0 and arch_1. The
> tool runs on the same host as the hypervisor, so __i386__ / __x86_64__
> conditionals wouldn't be inappropriate to use ...

This is a developer tool.  Noone is going to have a perfcounter enabled
hypervisor in production.

Therefore, I think the ifdef's will be fine.

Preferably with, but either way, Acked-by: Andrew Cooper
<andrew.cooper3@citrix.com>


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:17:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:17:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248746.429066 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEyl-0005cx-Eg; Fri, 17 Dec 2021 15:17:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248746.429066; Fri, 17 Dec 2021 15:17:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myEyl-0005cq-9w; Fri, 17 Dec 2021 15:17:03 +0000
Received: by outflank-mailman (input) for mailman id 248746;
 Fri, 17 Dec 2021 15:17:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEyj-0005cQ-UR; Fri, 17 Dec 2021 15:17:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEyj-0005gE-Qa; Fri, 17 Dec 2021 15:17:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myEyj-0005WG-BB; Fri, 17 Dec 2021 15:17:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myEyj-0000gC-Ak; Fri, 17 Dec 2021 15:17:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=SAbcSXywX0vBrKgJPfmXnm9DZ2I73KP6mK/c5knGKdY=; b=xUkMGjwwM6Vvuy5gcNlSw6fH98
	WJOHXcNVo5ABTP3wEO/vgmmv7ITmhgORL0e1hWoRNsPUHqNz7WZKjbJ7R2NRHSMdk45JT4ypBISZI
	RqVmHtP3NsSi4vvZOcv66+JtzSCdN0CSP0vINBTdb3HKX1ldp61O0xM6pD2GAyyo2Kr4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167455-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167455: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
X-Osstest-Versions-That:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 15:17:01 +0000

flight 167455 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167455/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167448
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167448
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167448
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167448
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167448
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail like 167448
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167448
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167448
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167448
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167448
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167448
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167448
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167448
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24
baseline version:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24

Last test of basis   167455  2021-12-17 01:54:15 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:26:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:26:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248761.429077 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myF7Z-0007K6-Ej; Fri, 17 Dec 2021 15:26:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248761.429077; Fri, 17 Dec 2021 15:26:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myF7Z-0007Jz-BR; Fri, 17 Dec 2021 15:26:09 +0000
Received: by outflank-mailman (input) for mailman id 248761;
 Fri, 17 Dec 2021 15:26:08 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=NBDy=RC=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1myF7X-0007Jt-QS
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:26:08 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a622008c-5f4d-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 16:26:04 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 608011F389;
 Fri, 17 Dec 2021 15:26:04 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 12DF513BF1;
 Fri, 17 Dec 2021 15:26:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id lfJAAwysvGGsPQAAMHmgww
 (envelope-from <jgross@suse.com>); Fri, 17 Dec 2021 15:26:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a622008c-5f4d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639754764; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=m7vbYo/MipNzFzK88GLr+dHK8w930a4ZnGRjRgwTsnE=;
	b=n126FRULMw85dtfxqWBXoVIN5njrALXFyXeIHtp4SY70ofGsqNp/m5/vA/3vuxx6g2isqL
	0wGcL9WVIX7RRtAjBuuoH+bJCGZ3QNuF7Xbt03hQd+BzMjzw0pvnI3Cofp8qlh5Soq3lY8
	BiiMWYTEagkWrP/7EcMUxMYQNJj4KOQ=
To: Oleksandr <olekstysh@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
 <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
Date: Fri, 17 Dec 2021 16:26:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="zfdQqTAeHA5DSQuydaXayzq8Td61s5NeY"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--zfdQqTAeHA5DSQuydaXayzq8Td61s5NeY
Content-Type: multipart/mixed; boundary="xju9h4oIXBxCmCgwm6EXMekceuVOtZlVG";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Oleksandr <olekstysh@gmail.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
Message-ID: <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
 <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
In-Reply-To: <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>

--xju9h4oIXBxCmCgwm6EXMekceuVOtZlVG
Content-Type: multipart/mixed;
 boundary="------------762C6C5BDD49D64352C970DE"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------762C6C5BDD49D64352C970DE
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 15.12.21 22:36, Oleksandr wrote:
>=20
> On 15.12.21 17:58, Juergen Gross wrote:
>=20
>=20
> Hi Juergen
>=20
>=20
>> On 15.12.21 16:02, Oleksandr wrote:
>>>
>>> On 15.12.21 08:08, Juergen Gross wrote:
>>>
>>> Hi Juergen
>>>
>>>> On 14.12.21 18:44, Oleksandr wrote:
>>>>>
>>>>> On 14.12.21 18:03, Anthony PERARD wrote:
>>>>>
>>>>> Hi Anthony
>>>>>
>>>>>
>>>>>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko wro=
te:
>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>
>>>>>>> This patch adds basic support for configuring and assisting=20
>>>>>>> virtio-disk
>>>>>>> backend (emualator) which is intended to run out of Qemu and=20
>>>>>>> could be
>>>>>>> run in any domain.
>>>>>>> Although the Virtio block device is quite different from traditio=
nal
>>>>>>> Xen PV block device (vbd) from the toolstack point of view:
>>>>>>> =C2=A0 - as the frontend is virtio-blk which is not a Xenbus driv=
er,=20
>>>>>>> nothing
>>>>>>> =C2=A0=C2=A0=C2=A0 written to Xenstore are fetched by the fronten=
d (the vdev is not
>>>>>>> =C2=A0=C2=A0=C2=A0 passed to the frontend)
>>>>>>> =C2=A0 - the ring-ref/event-channel are not used for the=20
>>>>>>> backend<->frontend
>>>>>>> =C2=A0=C2=A0=C2=A0 communication, the proposed IPC for Virtio is =
IOREQ/DM
>>>>>>> it is still a "block device" and ought to be integrated in existi=
ng
>>>>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configurat=
ion
>>>>>>> logic to deal with Virtio devices as well.
>>>>>> How backend are intended to be created? Is there something=20
>>>>>> listening on
>>>>>> xenstore?
>>>>>>
>>>>>> You mention QEMU as been the backend, do you intend to have QEMU
>>>>>> listening on xenstore to create a virtio backend? Or maybe it is=20
>>>>>> on the
>>>>>> command line? There is QMP as well, but it's probably a lot more
>>>>>> complicated as I think libxl needs refactoring for that.
>>>>>
>>>>>
>>>>> No, QEMU is not involved there. The backend is a standalone=20
>>>>> application,
>>>>> it is launched from the command line. The backend reads the=20
>>>>> Xenstore to get
>>>>> the configuration and to detect when guest with the frontend is=20
>>>>> created/destroyed.
>>>>
>>>> I think this should be reflected somehow in the configuration, as I
>>>> expect qemu might gain this functionality in the future.
>>>
>>> I understand this and agree in general (however I am wondering=20
>>> whether this can be postponed until it is actually needed), but ...
>>
>> This might lead to the need to support some "legacy" options in future=
=2E
>> I think we should at least think whether these scheme will cover (or
>> prohibit) extensions which are already on the horizon.
>=20
> ok
>=20
>=20
>>
>>
>>>> I'm wondering whether we shouldn't split the backend from the protoc=
ol
>>>> (or specification?). Something like "protocol=3Dvirtio" (default wou=
ld be
>>>> e.g. "xen") and then you could add "backend=3Dexternal" for your use=
=20
>>>> case?
>>>
>>> ... I am afraid, I didn't get the idea. Are we speaking about the=20
>>> (new?) disk configuration options
>>> here or these are not disk specific things at all and to be=20
>>> applicable for all possible backends?
>>
>> I was talking of a general approach using the disk as an example. For
>> disks it is just rather obvious.
>>
>>> If the former, then could the new backendtype simply do the job? For =

>>> example, "backendtype=3Dvirtio_external" for our current use-case and=
=20
>>> "backendtype=3Dvirtio_qemu"
>>> for the possible future use-cases? Could you please clarify the idea.=

>>
>> I want to avoid overloading the backendtype with information which is
>> in general not really related by the backend. You can have a qemu base=
d
>> qdisk backend serving a Xen PV-disk (like today) or a virtio disk.
>>
>> A similar approach has been chosen for the disk format: it is not part=

>> of the backend, but a parameter of its own. This way e.g. the qdisk
>> backend can use the original qdisk format, or the qcow format.
>>
>> In practice we are having something like the "protocol" already today:=

>> the disk device name is encoding that ("xvd*" is a Xen PV disk, while
>> "sd*" is an emulated SCSI disk, which happens to be presented to the
>> guest as "xvd*", too). And this is an additional information not
>> related to the backendtype.
>>
>> So we have basically the following configuration items, which are
>> orthogonal to each other (some combinations might not make sense,
>> but in theory most would be possible):
>>
>> 1. protocol: emulated (not PV), Xen (like today), virtio
>>
>> 2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)
>>
>> 3. format: raw, qcow, qcow2, vhd, qed
>>
>> The combination virtio+phy would be equivalent to vhost, BTW. And
>> virtio+other might even use vhost-user, depending on the daemon.
> yes, BTW the combination virtio+other is close to our use-case.
>=20
>=20
> Thank you for the detailed explanation, now I see your point why using =

> backendtype=3Dvirtio is not flexible option in the long term
> and why we would want/need to an extra configuration option such as=20
> protocol, etc. I think, it makes sense and would be correct.
>=20
> If we take a disk as an example, then from the configuration PoV we wil=
l=20
> need to:
> - add an optional "protocol" option

I'm not sure regarding the name of the option. "protocol" was just a
suggestion by me.

> - add new backendtype: external/other/daemon/etc.
> This seems to cover all possible combinations describe above (although =
I=20
> agree that some of them might not make sense). Is my understanding corr=
ect?

Yes.

> Unfortunately, disk configuration/management code is spread over=20
> multiple sources (including auto-generated) in the toolstack which is=20
> not so easy to follow (at least to me
> who is not familiar enough with all this stuff), but anyway may I pleas=
e=20
> clarify what is the minimum required amount of things that I need to do=
=20
> in order to get this basic virtio-mmio
> support series accepted?

I'd say we should first get consensus that others agree with my
suggestion. If so, I guess adding a general "protocol" (or whatever
the name will be) attribute to struct libxl_device_disk (and maybe
to other devices, too?) should be the first step.

It might even be a godd idea to use "virtio-mmio" as the protocol string
for differentiating it from e.g. "virtio-pci".

The rest should be rather straight forward similar to your current
approach.


Juergen

--------------762C6C5BDD49D64352C970DE
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------762C6C5BDD49D64352C970DE--

--xju9h4oIXBxCmCgwm6EXMekceuVOtZlVG--

--zfdQqTAeHA5DSQuydaXayzq8Td61s5NeY
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG8rAsFAwAAAAAACgkQsN6d1ii/Ey85
qwf9FHqrmV/RNdN8KjKbvbGEX2XR2E2EFyZN8K0WCPS0IJrl5eH/bbPZ/dnxM8uwJLdRa1VfkBhG
ZZHgHIWTQTgDA79XNeInc6bJExNgtSxwbYMdTvkmCFAGmMtueuFPqyz6eGKIaJOh4GuRfD0hIgPV
N1rhDy5hnBl8UQhtIXdXod6W1PsSmItQ5WVPcjhknod5eroAB9NrJ/pw8UBffpOA3iWmdZSeRkPG
NoqnEowuVeZhRSMZ8HjgS9j1mAl4PElS5VkMpeFuqC5yjVPCcOFSLLjWeJJYtjEelECQG+ToYzM0
paNHfd0w4C2k/o8VglV6rb8UIvwSVhyvKClP6YLiyQ==
=gqIh
-----END PGP SIGNATURE-----

--zfdQqTAeHA5DSQuydaXayzq8Td61s5NeY--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 15:56:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 15:56:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248765.429088 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myFb9-0002co-VS; Fri, 17 Dec 2021 15:56:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248765.429088; Fri, 17 Dec 2021 15:56:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myFb9-0002ch-Q8; Fri, 17 Dec 2021 15:56:43 +0000
Received: by outflank-mailman (input) for mailman id 248765;
 Fri, 17 Dec 2021 15:56:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myFb9-0002cb-2k
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 15:56:43 +0000
Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id eb3ec0fd-5f51-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 16:56:41 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:47448)
 by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myFax-000Ksb-n1 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 15:56:31 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id CA4DE1FA77;
 Fri, 17 Dec 2021 15:56:30 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb3ec0fd-5f51-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <8edd5817-f4bd-7246-21ac-f289f2f1bcdd@srcf.net>
Date: Fri, 17 Dec 2021 15:56:30 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <JBeulich@suse.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211111175740.23480-1-andrew.cooper3@citrix.com>
 <20211111175740.23480-4-andrew.cooper3@citrix.com>
 <409d2c17-d1e7-40b3-226a-b6ca4c0a15bf@xen.org>
 <alpine.DEB.2.22.394.2111151632160.1412361@ubuntu-linux-20-04-desktop>
 <5816e643-450e-1433-d58c-b12a286fb237@srcf.net>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [PATCH 3/5] xen/sort: Switch to an extern inline implementation
In-Reply-To: <5816e643-450e-1433-d58c-b12a286fb237@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 16/11/2021 00:41, Andrew Cooper wrote:
> On 16/11/2021 00:36, Stefano Stabellini wrote:
>> On Thu, 11 Nov 2021, Julien Grall wrote:
>>> On 11/11/2021 17:57, Andrew Cooper wrote:
>>>> There are exactly 3 callers of sort() in the hypervisor.
>>>>
>>>> Both arm callers pass in NULL for the swap function.  While this might seem
>>>> like an attractive option at first, it causes generic_swap() to be used
>>>> which
>>>> forced a byte-wise copy.  Provide real swap functions which the compiler can
>>>> optimise sensibly.
>>> I understand the theory, but none of the two calls are in hot paths or deal
>>> with large set on Arm. So I am rather hesitant to introduce specialised swap
>>> in each case as it doesn't seem we will gain much from this change.
>> While I like Andrew's optimization, like Julien, I would also rather not
>> have to introduce specialized swap functions any time a sort() is
>> called. Why not keeping around generic_swap as extern gnu_inline in
>> sort.h as well so that the ARM callers can simply:
>>
>>     sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank),
>>          cmp_memory_node, generic_swap);
>>
>> ?
>>
>> That looks like a good option, although it would still result in a
>> small increase in bloat.
> That is basically what Jan suggested.
>
> I'm still unconvinced that you actually want to be doing byte-wise
> swapping, even if it isn't a hotpath.  A custom swap function will
> compile to less code than using generic_swap() like this, and run faster.

ARM Ping.

I really think this is a bad course of action.  If you're going to
insist on it, I want something in writing.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 16:15:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 16:15:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248772.429099 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myFtO-0005qw-Gj; Fri, 17 Dec 2021 16:15:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248772.429099; Fri, 17 Dec 2021 16:15:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myFtO-0005qp-DT; Fri, 17 Dec 2021 16:15:34 +0000
Received: by outflank-mailman (input) for mailman id 248772;
 Fri, 17 Dec 2021 16:15:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myFtN-0005qj-AB
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 16:15:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myFtK-0007DO-Pw; Fri, 17 Dec 2021 16:15:30 +0000
Received: from 54-240-197-231.amazon.com ([54.240.197.231]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myFtK-0005oZ-Id; Fri, 17 Dec 2021 16:15:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4wfbgSlQUWpKxpFTfS9D4d+xPEi+WEmdkN3Ru56UIlw=; b=sbI4FS5V+hFOAq3SyNui0ZLL/A
	NQ8DcQjsuBLLDx5IBSIRH4K8/fQsnFAqRv+Jr4QZPYZ9Fnj+9xFHkZ7cvKDLMHq7qNMIc5wbLfC4E
	pTs07WD9E/pdKQpd3I0SZSMKlrs5L4OCz1nfkg/crQDhmmpP+8EMxbdGQpo0OCD0gjUM=;
Message-ID: <f7bb7a08-4721-f2a8-8602-0cd1baf1f083@xen.org>
Date: Fri, 17 Dec 2021 16:15:28 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH 3/5] xen/sort: Switch to an extern inline implementation
To: Andrew Cooper <amc96@srcf.net>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 Xen-devel <xen-devel@lists.xenproject.org>, Jan Beulich <JBeulich@suse.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>, Wei Liu
 <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <20211111175740.23480-1-andrew.cooper3@citrix.com>
 <20211111175740.23480-4-andrew.cooper3@citrix.com>
 <409d2c17-d1e7-40b3-226a-b6ca4c0a15bf@xen.org>
 <alpine.DEB.2.22.394.2111151632160.1412361@ubuntu-linux-20-04-desktop>
 <5816e643-450e-1433-d58c-b12a286fb237@srcf.net>
 <8edd5817-f4bd-7246-21ac-f289f2f1bcdd@srcf.net>
From: Julien Grall <julien@xen.org>
In-Reply-To: <8edd5817-f4bd-7246-21ac-f289f2f1bcdd@srcf.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

On 17/12/2021 15:56, Andrew Cooper wrote:
> On 16/11/2021 00:41, Andrew Cooper wrote:
>> On 16/11/2021 00:36, Stefano Stabellini wrote:
>>> On Thu, 11 Nov 2021, Julien Grall wrote:
>>>> On 11/11/2021 17:57, Andrew Cooper wrote:
>>>>> There are exactly 3 callers of sort() in the hypervisor.
>>>>>
>>>>> Both arm callers pass in NULL for the swap function.  While this might seem
>>>>> like an attractive option at first, it causes generic_swap() to be used
>>>>> which
>>>>> forced a byte-wise copy.  Provide real swap functions which the compiler can
>>>>> optimise sensibly.
>>>> I understand the theory, but none of the two calls are in hot paths or deal
>>>> with large set on Arm. So I am rather hesitant to introduce specialised swap
>>>> in each case as it doesn't seem we will gain much from this change.
>>> While I like Andrew's optimization, like Julien, I would also rather not
>>> have to introduce specialized swap functions any time a sort() is
>>> called. Why not keeping around generic_swap as extern gnu_inline in
>>> sort.h as well so that the ARM callers can simply:
>>>
>>>      sort(bootinfo.mem.bank, bootinfo.mem.nr_banks, sizeof(struct membank),
>>>           cmp_memory_node, generic_swap);
>>>
>>> ?
>>>
>>> That looks like a good option, although it would still result in a
>>> small increase in bloat.
>> That is basically what Jan suggested.
>>
>> I'm still unconvinced that you actually want to be doing byte-wise
>> swapping, even if it isn't a hotpath.  A custom swap function will
>> compile to less code than using generic_swap() like this, and run faster.
> 
> ARM Ping.
> 
> I really think this is a bad course of action.  If you're going to
> insist on it, I want something in writing.

I agree with all the points you wrote. However, you also have to put 
into perspective how this is used. On Arm, the two callers happen either 
during boot a domain creation. Neither of them have a significant impact 
on the time spent. In fact, I would be surprised if you notice the change.

So unless there are other (good) reasons to suppress generic_swap(), I 
still want to be able to use generic_swap() when the performance doesn't 
matter (like the two Arm callers).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 16:38:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 16:38:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248776.429110 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGFf-00008Y-Cm; Fri, 17 Dec 2021 16:38:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248776.429110; Fri, 17 Dec 2021 16:38:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGFf-00008R-9J; Fri, 17 Dec 2021 16:38:35 +0000
Received: by outflank-mailman (input) for mailman id 248776;
 Fri, 17 Dec 2021 16:38:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1myGFd-00008K-TX
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 16:38:33 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myGFd-0007cD-EL; Fri, 17 Dec 2021 16:38:33 +0000
Received: from 54-240-197-239.amazon.com ([54.240.197.239]
 helo=[192.168.25.72]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1myGFd-0007UU-8X; Fri, 17 Dec 2021 16:38:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
	References:Cc:To:Subject:From:MIME-Version:Date:Message-ID;
	bh=72RA8RN7x9oWhqH1wtwABHZoPIY36UP9aF+QWShOjpQ=; b=P08QKMI5RhlwXb5hqPgF7VacWo
	UdQRaDf+PoyU2fO5qHd051AfGD0eNDAtt2+meIrgR+bmO39Oi3gWmWhtUxQN2/0d+MdP0XQwtX4xg
	4wZWBPTrZpsvyAXiCK2wJzhvQcUmGAQMiD2Zq7IyyyY7XBjjUiovCVamoGdRMxF/2Wys=;
Message-ID: <7924e699-5e70-6fdc-8633-6a15894d66db@xen.org>
Date: Fri, 17 Dec 2021 16:38:31 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
From: Julien Grall <julien@xen.org>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
 <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
 <20211217135855.GA4072899@EPUAKYIW015D>
In-Reply-To: <20211217135855.GA4072899@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 17/12/2021 13:58, Oleksii Moisieiev wrote:
> Hi Julien,

Hi,

> On Fri, Dec 17, 2021 at 01:37:35PM +0000, Julien Grall wrote:
>> Hi,
>>
>> On 17/12/2021 13:23, Oleksii Moisieiev wrote:
>>>>> +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
>>>>> +{
>>>>> +    return iomem_permit_access(d, paddr_to_pfn(addr),
>>>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>>>> +}
>>>>> +
>>>>> +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
>>>>> +                                     uint64_t len)
>>>>> +{
>>>>> +    return iomem_deny_access(d, paddr_to_pfn(addr),
>>>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>>>> +}
>>>>
>>>> I wonder, why we need an extra level of indirection here. And if this is
>>>> really needed, I wonder why map(unmap)_memory* name was chosen, as there is
>>>> no memory mapping/unmapping really happens here.
>>>>
>>>
>>> I've added extra indirection to hide math like
>>> paddr_to_pfn(PAGE_ALIGN(addr + len -1)
>>> so you don't have to math in each call. unmap_memory_from_domain called
>>> from 2 places, so I moved both calls to separate function.
>>> Although, I agree that map/unmap is not perfect name. I consider
>>> renaming it to mem_permit_acces and mam_deny_access.
>>
>> I haven't looked at the rest of the series. But this discussion caught my
>> eye. This code implies that the address is page-aligned but the length not.
>> Is that intended?
>>
>> That said, if you give permission to the domain on a full page then it means
>> it may be able to access address it should not. Can you explain why this is
>> fine?
>>
> 
> The idea was that xen receives some memory from the dt_node linux,scmi_mem,
> then we split memory between the agents, so each agent get 1 page (we
> allocate 0x10 pages right now).

Thanks for the clarification. Does this imply the guest will be able to 
write message directly to the firmware?

If so, this brings a few more questions:
   1) What will the guest write in it? Can it contains addresses?
   2) What are the expected memory attribute for the regions?
   3) What's the threat model for the firmware? Will it verify every 
request?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 16:50:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 16:50:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248782.429121 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGQy-0002pO-HM; Fri, 17 Dec 2021 16:50:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248782.429121; Fri, 17 Dec 2021 16:50:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGQy-0002pH-Do; Fri, 17 Dec 2021 16:50:16 +0000
Received: by outflank-mailman (input) for mailman id 248782;
 Fri, 17 Dec 2021 16:50:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EyUW=RC=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1myGQx-0002pB-6c
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 16:50:15 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 67b3cb4d-5f59-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 17:50:13 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id l22so5869949lfg.7
 for <xen-devel@lists.xenproject.org>; Fri, 17 Dec 2021 08:50:13 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id bt18sm384281lfb.50.2021.12.17.08.50.07
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 17 Dec 2021 08:50:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67b3cb4d-5f59-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=JRxht2kaQ51s5BnEnRmm/sgkC3ogtNKIzqiJk2qXWac=;
        b=EGvYn9PwkKtSxOqc4c/zOCcIRnpZTvaNeQ25eKta/ILkZYlt5+/UFeXK9rikykIaYu
         ULOJRp2nBNr9NMKUHCejhiFGGElT2NkUHVMzinIJksMNfVs6QkzhxAJJktz8UQsbISGi
         E91Kms4XPZNzyFVqcp6fnC/2GyaWrO06g8TggM4OA4N4tgbEFmCHrXdqvtj249TNA3Xa
         XxiVT4ITLt6MdYYG5jLI5QIs72xpZXzX6LrlzxlPuDqw1OOubjDCT6WfpC4WDu/vcJnf
         iyyNi5zB35dlgiVrR+M5gktChdnXYgH+/tnPlXn7yzHTIGMmiGLqGpcXBCa0S4/6mE20
         4FvQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=JRxht2kaQ51s5BnEnRmm/sgkC3ogtNKIzqiJk2qXWac=;
        b=5+jHbQIJeOqkAb3If/+EQ0px0qnX3g4yidGOSYgSB2KVZB4Z6G8bfZyqJtgZc+qBQ9
         sKOJGmmEx+vpAeLgcZKmDwqT48F18NDlmIcDKgnMjnAn3MZhUoXHIxjF9IqCigypcT88
         VC8D6F7v26g17UeoMhuakErEhMwng+XNKYFzRZpl3UjGRvXmVKqEUzJFv5K/g8gRFZC4
         qy5ULwVQZaytJ+XbR+zb9RzWczDAJJkPtktLFvaasV3RuuYlPZz40b4O/s31PVTxTw11
         E6lO34wnPkquHP3psE2JrfI673x/dPox6rrdM/4xIMVkha1BA90YN16erC3Sbm/AsnXr
         pUFw==
X-Gm-Message-State: AOAM531h4k2k5Ah2hZnvGcGXb8VnzSUnYsrStJjsN15h1MxFq9DIu+cU
	L42Yd5xBak7GgCi3DF+55oA=
X-Google-Smtp-Source: ABdhPJzFyjlh2a17NmZaUl+5+StbymFvBnAff3k+lk1B13sfD8jLIKNwgeBYFFXMEgVwRF94zZMZ2Q==
X-Received: by 2002:a05:6512:50c:: with SMTP id o12mr3524797lfb.41.1639759813351;
        Fri, 17 Dec 2021 08:50:13 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: Anthony PERARD <anthony.perard@citrix.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
 <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
 <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <44885d7e-c5a0-5b7c-144d-b9e6c7e54715@gmail.com>
Date: Fri, 17 Dec 2021 18:50:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 17.12.21 17:26, Juergen Gross wrote:


Hi Juergen, all.


> On 15.12.21 22:36, Oleksandr wrote:
>>
>> On 15.12.21 17:58, Juergen Gross wrote:
>>
>>
>> Hi Juergen
>>
>>
>>> On 15.12.21 16:02, Oleksandr wrote:
>>>>
>>>> On 15.12.21 08:08, Juergen Gross wrote:
>>>>
>>>> Hi Juergen
>>>>
>>>>> On 14.12.21 18:44, Oleksandr wrote:
>>>>>>
>>>>>> On 14.12.21 18:03, Anthony PERARD wrote:
>>>>>>
>>>>>> Hi Anthony
>>>>>>
>>>>>>
>>>>>>> On Wed, Dec 08, 2021 at 06:59:43PM +0200, Oleksandr Tyshchenko 
>>>>>>> wrote:
>>>>>>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>>>>>>
>>>>>>>> This patch adds basic support for configuring and assisting 
>>>>>>>> virtio-disk
>>>>>>>> backend (emualator) which is intended to run out of Qemu and 
>>>>>>>> could be
>>>>>>>> run in any domain.
>>>>>>>> Although the Virtio block device is quite different from 
>>>>>>>> traditional
>>>>>>>> Xen PV block device (vbd) from the toolstack point of view:
>>>>>>>>   - as the frontend is virtio-blk which is not a Xenbus driver, 
>>>>>>>> nothing
>>>>>>>>     written to Xenstore are fetched by the frontend (the vdev 
>>>>>>>> is not
>>>>>>>>     passed to the frontend)
>>>>>>>>   - the ring-ref/event-channel are not used for the 
>>>>>>>> backend<->frontend
>>>>>>>>     communication, the proposed IPC for Virtio is IOREQ/DM
>>>>>>>> it is still a "block device" and ought to be integrated in 
>>>>>>>> existing
>>>>>>>> "disk" handling. So, re-use (and adapt) "disk" 
>>>>>>>> parsing/configuration
>>>>>>>> logic to deal with Virtio devices as well.
>>>>>>> How backend are intended to be created? Is there something 
>>>>>>> listening on
>>>>>>> xenstore?
>>>>>>>
>>>>>>> You mention QEMU as been the backend, do you intend to have QEMU
>>>>>>> listening on xenstore to create a virtio backend? Or maybe it is 
>>>>>>> on the
>>>>>>> command line? There is QMP as well, but it's probably a lot more
>>>>>>> complicated as I think libxl needs refactoring for that.
>>>>>>
>>>>>>
>>>>>> No, QEMU is not involved there. The backend is a standalone 
>>>>>> application,
>>>>>> it is launched from the command line. The backend reads the 
>>>>>> Xenstore to get
>>>>>> the configuration and to detect when guest with the frontend is 
>>>>>> created/destroyed.
>>>>>
>>>>> I think this should be reflected somehow in the configuration, as I
>>>>> expect qemu might gain this functionality in the future.
>>>>
>>>> I understand this and agree in general (however I am wondering 
>>>> whether this can be postponed until it is actually needed), but ...
>>>
>>> This might lead to the need to support some "legacy" options in future.
>>> I think we should at least think whether these scheme will cover (or
>>> prohibit) extensions which are already on the horizon.
>>
>> ok
>>
>>
>>>
>>>
>>>>> I'm wondering whether we shouldn't split the backend from the 
>>>>> protocol
>>>>> (or specification?). Something like "protocol=virtio" (default 
>>>>> would be
>>>>> e.g. "xen") and then you could add "backend=external" for your use 
>>>>> case?
>>>>
>>>> ... I am afraid, I didn't get the idea. Are we speaking about the 
>>>> (new?) disk configuration options
>>>> here or these are not disk specific things at all and to be 
>>>> applicable for all possible backends?
>>>
>>> I was talking of a general approach using the disk as an example. For
>>> disks it is just rather obvious.
>>>
>>>> If the former, then could the new backendtype simply do the job? 
>>>> For example, "backendtype=virtio_external" for our current use-case 
>>>> and "backendtype=virtio_qemu"
>>>> for the possible future use-cases? Could you please clarify the idea.
>>>
>>> I want to avoid overloading the backendtype with information which is
>>> in general not really related by the backend. You can have a qemu based
>>> qdisk backend serving a Xen PV-disk (like today) or a virtio disk.
>>>
>>> A similar approach has been chosen for the disk format: it is not part
>>> of the backend, but a parameter of its own. This way e.g. the qdisk
>>> backend can use the original qdisk format, or the qcow format.
>>>
>>> In practice we are having something like the "protocol" already today:
>>> the disk device name is encoding that ("xvd*" is a Xen PV disk, while
>>> "sd*" is an emulated SCSI disk, which happens to be presented to the
>>> guest as "xvd*", too). And this is an additional information not
>>> related to the backendtype.
>>>
>>> So we have basically the following configuration items, which are
>>> orthogonal to each other (some combinations might not make sense,
>>> but in theory most would be possible):
>>>
>>> 1. protocol: emulated (not PV), Xen (like today), virtio
>>>
>>> 2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)
>>>
>>> 3. format: raw, qcow, qcow2, vhd, qed
>>>
>>> The combination virtio+phy would be equivalent to vhost, BTW. And
>>> virtio+other might even use vhost-user, depending on the daemon.
>> yes, BTW the combination virtio+other is close to our use-case.
>>
>>
>> Thank you for the detailed explanation, now I see your point why 
>> using backendtype=virtio is not flexible option in the long term
>> and why we would want/need to an extra configuration option such as 
>> protocol, etc. I think, it makes sense and would be correct.
>>
>> If we take a disk as an example, then from the configuration PoV we 
>> will need to:
>> - add an optional "protocol" option
>
> I'm not sure regarding the name of the option. "protocol" was just a
> suggestion by me.

Yes, personally I would be fine with either "protocol" or 
"specification", with a little preference for the former. What other 
people think of the name?


>
>> - add new backendtype: external/other/daemon/etc.
>> This seems to cover all possible combinations describe above 
>> (although I agree that some of them might not make sense). Is my 
>> understanding correct?
>
> Yes.

ok, thank you for confirming.


>
>> Unfortunately, disk configuration/management code is spread over 
>> multiple sources (including auto-generated) in the toolstack which is 
>> not so easy to follow (at least to me
>> who is not familiar enough with all this stuff), but anyway may I 
>> please clarify what is the minimum required amount of things that I 
>> need to do in order to get this basic virtio-mmio
>> support series accepted?
>
> I'd say we should first get consensus that others agree with my
> suggestion.
This is fair. Personally I share your opinion (what you propose sounds 
reasonable to me in general). Are there any other opinions? Any feedback 
would be highly appreciated.


> If so, I guess adding a general "protocol" (or whatever
> the name will be) attribute to struct libxl_device_disk (and maybe
> to other devices, too?) should be the first step.

Agree, I would start with the disk and see how it would look like.


>
> It might even be a godd idea to use "virtio-mmio" as the protocol string
> for differentiating it from e.g. "virtio-pci".

Makes sense, I thought the same.


>
> The rest should be rather straight forward similar to your current
> approach.

Good.


Thank you.


>
>
> Juergen

-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 17:24:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 17:24:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248789.429143 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGxV-0006lx-3K; Fri, 17 Dec 2021 17:23:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248789.429143; Fri, 17 Dec 2021 17:23:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myGxV-0006lq-0M; Fri, 17 Dec 2021 17:23:53 +0000
Received: by outflank-mailman (input) for mailman id 248789;
 Fri, 17 Dec 2021 17:23:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myGxT-0006lg-V6; Fri, 17 Dec 2021 17:23:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myGxT-0008PZ-Sm; Fri, 17 Dec 2021 17:23:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myGxT-0002mM-Ix; Fri, 17 Dec 2021 17:23:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myGxT-0003EW-IT; Fri, 17 Dec 2021 17:23:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ZtexqQI8YwDMXM5UcXfKf/ISEJS3yOPxjko8K/s9Xt0=; b=jDUJu8wMmhQXIKDs3m6OkLKcoy
	slOwqmNRKiiU3eqeu4zw46sSum6NO4vLGUjQL6yi4U0I4IZlJ23+wL75Axzl/losntu9JuaRV7+iF
	T/l7/QRmM7CDPmWcePgo9RdOTf6pcWbgA0ayHi8ebvKfqRndV/M3sKysoHdFqwpsAMSg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167463-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167463: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1
X-Osstest-Versions-That:
    ovmf=b451c6908878c448c2a2aa6e9ca2a2dfe078fbb8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 17:23:51 +0000

flight 167463 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167463/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1
baseline version:
 ovmf                 b451c6908878c448c2a2aa6e9ca2a2dfe078fbb8

Last test of basis   167450  2021-12-16 18:10:32 Z    0 days
Testing same since   167463  2021-12-17 15:10:34 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rodrigo Gonzalez del Cueto <rodrigo.gonzalez.del.cueto@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   b451c69088..ab5ab2f603  ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 18:26:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 18:26:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248800.429155 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myHvM-0005M1-Jx; Fri, 17 Dec 2021 18:25:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248800.429155; Fri, 17 Dec 2021 18:25:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myHvM-0005Lu-Eu; Fri, 17 Dec 2021 18:25:44 +0000
Received: by outflank-mailman (input) for mailman id 248800;
 Fri, 17 Dec 2021 18:25:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myHvL-0005Lk-6g; Fri, 17 Dec 2021 18:25:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myHvL-00014m-3V; Fri, 17 Dec 2021 18:25:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myHvK-0005c0-QZ; Fri, 17 Dec 2021 18:25:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myHvK-00005n-Q8; Fri, 17 Dec 2021 18:25:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kZLDMxP2QoGhaG0T528o6HeFm5eckusu8dXkoE4Rq1w=; b=ZJ96tk+xiJsQ6f5YdH7G/D1g8l
	n3/m+n8oJ0aJSF9rbAE6zeowPO9buCEoFjfdEBGkrVXrb2WDxDkKbh6ApAY9aA1YLBwoVLb7eUVZ0
	rwvfn2d1Z0aNw5AIkNGG4l5GQo2fW2aftqH1zxvTUoV9/mVSVz6PJg+7ZqoaKFXeYwrs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167462-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167462: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=32365f3476ac4655f2f26111cd7879912808cd77
X-Osstest-Versions-That:
    xen=c81fc9f313c031f1201181cfb40e3c3ee599e04f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 18:25:42 +0000

flight 167462 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167462/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  32365f3476ac4655f2f26111cd7879912808cd77
baseline version:
 xen                  c81fc9f313c031f1201181cfb40e3c3ee599e04f

Last test of basis   167460  2021-12-17 12:01:45 Z    0 days
Testing same since   167462  2021-12-17 15:01:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Julien Grall <jgrall@amazon.com>
  Michal Orzel <michal.orzel@arm.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   c81fc9f313..32365f3476  32365f3476ac4655f2f26111cd7879912808cd77 -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:14:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:14:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248815.429166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIgW-0002t7-Cx; Fri, 17 Dec 2021 19:14:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248815.429166; Fri, 17 Dec 2021 19:14:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIgW-0002t0-9d; Fri, 17 Dec 2021 19:14:28 +0000
Received: by outflank-mailman (input) for mailman id 248815;
 Fri, 17 Dec 2021 19:14:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8jqe=RC=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1myIgU-0002su-OH
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:14:26 +0000
Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com
 [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b7361aa-5f6d-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:14:24 +0100 (CET)
Received: from pps.filterd (m0246627.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BHGYLih013129; 
 Fri, 17 Dec 2021 19:13:58 GMT
Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cyknp6kcn-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:13:57 +0000
Received: from pps.filterd (userp3020.oracle.com [127.0.0.1])
 by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BHJ5vmp133833;
 Fri, 17 Dec 2021 19:13:56 GMT
Received: from nam11-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam11lp2171.outbound.protection.outlook.com [104.47.57.171])
 by userp3020.oracle.com with ESMTP id 3cvnevwu87-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:13:56 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BL0PR10MB3043.namprd10.prod.outlook.com (2603:10b6:208:31::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Fri, 17 Dec
 2021 19:13:54 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4801.017; Fri, 17 Dec 2021
 19:13:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b7361aa-5f6d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=yRUvy4Egen/QoS3mQOGQLXmSh0t2R1/eqYgoZCXyKcM=;
 b=rNwkXvlQ2AhP+EVVbvttz0KC6ngDP16yKC+EeQ2Cwo61kl6aTgXmVhTH9xpTeXWJRZb2
 pc0IM4pEfHoZy2fSs4h6c9ALUiDk9r3q4d8pXw+rUIRKKPbeRD42GYLV3JQzt1sTFfQ6
 /yPxSG621cLBoaMovXV5lJIgHS/yzTCUKkuKp353uewCkb74ynu8ZMGyCGcf0dRtkn5a
 vuTXll/5twNmqXgL4KiX6VLN4WpOrnmdfIbKBKc9qpcLBbO9y1Mhx9Li4SY0ii0b+aou
 YRc3moxIZE9sxxOhJO/f5+IEq5Z5LymkhMH/aG/JlQjDxy/6XaxxDWPdqHmM+ZdUA32r cw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jPZnBki4LTG7bUh2QzlRLkmzJE1WxNtYQvKAO4v/cWTvUNdRi0XrKr2Nh8wu6MPxhU3SkeuceE1aP/1S8kTeC62cZCDKEuFtcJWP91TruAc/xibzpAJJfEvhg1iT3oTfjZxjPfKVo46/4Ljk9kccfBcRlLt5U/pJGOrTdwWkOjsQ7en391NAbvy7cbzGJF0UpHoY+eI5fOX+Y6neAzuiPy+gpIWBhQPth2Gzbfcsh/JNZ6Kw3EMKXWltyFHC+GrqAr+bihUXK43j1BqXsZbbE75NlpE4LNHE9REDytT7iyoXMVt0U5DLP5/Vmj3ducDZnPdyUoPHrJaNmL/x/egAvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=yRUvy4Egen/QoS3mQOGQLXmSh0t2R1/eqYgoZCXyKcM=;
 b=PWuGCCE2vsmCga5P4qkO3FhWk2MVuuaztrmWWMT4TF8mOMnjUzppwYuslJ/9aJwCRQGrtTHDBxPxqLEPpuwcz3uMXRllvcCrdU3y3O3I+t1xxuv7B5Hxf6OXWB9iPbDnHttvkJ622rLSoehsViux0ViJ9HUZ8NBy0W8kn9+efSlC2+mN/gKir1HyzO0OtP6AssInDJeWyTvZM8rIFc3+WNJQAUpeMeHfHWBSUJXBE+3Gf3bbkfBJDj/fcBEDz9tqAQFZo+pSwU7cKPYNR3Ii9IC0LSZh+gypTkf8a9HiLofWZDApT3MWjKqSJgeojqU8H8M5oOUx8mthUeK5DT77mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=yRUvy4Egen/QoS3mQOGQLXmSh0t2R1/eqYgoZCXyKcM=;
 b=zWMrpgRyh3AIkGCFii78F+I3ykxS0ypjmBiaSFtTK1aCpesEJQAjU/n6/THaGr6twFTBMLKesfTZW9F8hb9eblLnD6+/JyNSrS4uIOUDcTbmkMwGIO04lYUkOg/5/XFWsFWubBvuMgkXXVPGOKPM2lV3VuS8htB5JGh7ltNPGMI=
Message-ID: <81c97e6a-f5e3-3f5d-c9ae-a35933cf4e61@oracle.com>
Date: Fri, 17 Dec 2021 14:13:44 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges)
 on Arm
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>, Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
        Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SJ0PR05CA0060.namprd05.prod.outlook.com
 (2603:10b6:a03:33f::35) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d3915c82-3f03-472d-357d-08d9c1915dc9
X-MS-TrafficTypeDiagnostic: BL0PR10MB3043:EE_
X-Microsoft-Antispam-PRVS: 
	<BL0PR10MB3043F1A5AC239C6B8453D3338A789@BL0PR10MB3043.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2803;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	bwGwf4FzUH6241ypqTUE/nxETehcdcVW8+9Z9MVSG68rdYr44b7h5wqZK7D+fwEl4rHYYAiNGADVfdiU5Q9Vt2nj/DoqQ8N0JsdEtTUzQVyphPOd6wG61jElNqWrelod/nTTkVllco7bh3YxgooMiD6iQnRPKLp1Tdh6dDslLzcVNx/eKVtbMRro4gnnLH463/VY36Tu/Tj3+wrp3EulNTskaNY2TrC+Elyqs7583F98JDej3eQz7PvBbyeLa2qSvC6XvLNXV6mWiHs+Y96mx3vnCnJt6MTquhUbo3tPV4RbzHd4OGR7drD61W2m40laPUkkc0LnSugKZoRzd9AWnaO3ChEtiMRFl/1vu0nWl29ZKtzho/ARYobOD5f6vw2W482jOCx23qsI00af1jzjA8T+EQGYq7obVxgBd5RirjU+R8yhOD+KvbW6T5pWA3R+1ip3tpqDz6z+4PYlhSn7I7DBHyLQmwZA3zLghEIyViyvEt0jG2x0LWvc4hBnaTePtPgLkgOMDHQ0R67m1ZTcmvOBK2XhQUTpDYTK3njQHmsrUqkK8B0C9fj9tx9Y79ywz6VObqAA6NphARI9YIC/9XLJaPj96YJYZS/2p3z09I5KCBBOJ/49At3DqsgfXBAuscahee9wO6XlF7rQESHlAtVRl+1+gkIzNNfBknHWWaypr7o3FXRsPUqBm26xtdLG1ezHr5IXpmCXKJFdeQaHT/iY5OZ9jWBV2FyyHQvWdgY=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(186003)(54906003)(110136005)(8676002)(6506007)(4744005)(6666004)(31696002)(4326008)(38100700002)(2906002)(66476007)(53546011)(8936002)(66946007)(66556008)(6512007)(508600001)(36756003)(44832011)(2616005)(5660300002)(26005)(86362001)(31686004)(6486002)(7416002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MmRDRUlzQzVCdnZOK1JDVFkwQ3BnaEZJWEpHcHJUa1lLNzVMdG4rUmhIMlJC?=
 =?utf-8?B?U2hrT0dBbVp6b0ltUkZ5b1RYcEZkSVlJbFkrbmtxZzZZOFJ0MzV3cW00WlVL?=
 =?utf-8?B?bEdHenFQc1VEdWQwNGhpV21nbmYzWWpwVEJGaEZ5bEZlV3ZwekVEU0p0K2dv?=
 =?utf-8?B?d0RYN1Vmb2NWZUxLMkRVMklRdmYrMFFTN2hGQU81ZisrK0xqRE8rWXBaelo0?=
 =?utf-8?B?MFBrZXV6dk9rVWhkVEN1NjZWdTlZSDV5VWhBcUV1TlRxY29uNGxKOGg2ZkJR?=
 =?utf-8?B?b1pHakZWUE8yNDRUMGE4VFpYbld0QXJTMFhBOUNJcUx1a0d6L1U4K3poTzdx?=
 =?utf-8?B?QkQ3VFpBd2pGV1l5azhNMkxBcFJ4bzdQYUlqTGhoOGdNWGpsK3Z6Qm1FZkQy?=
 =?utf-8?B?cnNlKzBVWVdNbDhJYlQ3d3lMRjROVHY1ZlNGUmkwb0F0a2MxK0RPeTMwV0JE?=
 =?utf-8?B?bDZVY2ttRmhpNXhub1VXdVpyVWo3RmQyKzBKU0U2YVdYYm5sYUhRRjlSb3NL?=
 =?utf-8?B?cC9JdWp6OUVmVUNmMnM1c05PWFhvUnU5a2M1RUc4T2ZGK242NVd2ZlRrdGdu?=
 =?utf-8?B?ZWFtdENJWElGOHA2NW4wRGFBV2h0UmdmRHlIQ1phWFVSZSthOVgzczZTTnNy?=
 =?utf-8?B?WTlydExEeVM3QzRHYlNuWDVGQjZNUW5rUGJhV2JsSERuL1I3S1oxU3IweDNB?=
 =?utf-8?B?RytQVng5N0tETWZCQWpIYm1HNzRMaFBCTUNQLzR4Z3VHN01rd0ovUjQxTkRk?=
 =?utf-8?B?RC8xWGRFTGJvZnB5NGsyRFRwbEt0U0orZlJYNThnNXJUZzdHZTZWOEVSbmRy?=
 =?utf-8?B?eVhyWW9RcXYrTUNGdk82MUJJL0d5ZWVNa3UvMlZuNXdrRnVadGZvNkE3NnB1?=
 =?utf-8?B?dC9KZ1dMZFo2VlhrMmdRV0FvaHQwVGRiK2cxMzcxZ0pHSVdnNDVRMUFCcFRa?=
 =?utf-8?B?T2Z2d01hNnBKU0MrTkRLQ25tVVFsd1o1czZxMk1KYm8vOExYVVErSDRGOGQw?=
 =?utf-8?B?V1BiYXdvaFE1d3ZLY0dqdjNLNEhKMnhpZEwxY2V3UWtqeHZ6STlvbnRaSjFp?=
 =?utf-8?B?d2dCQ0o0VDR2MWlWSGlITFBvSHRJUnNQdUdnRGJlZlpKZ21SVDZIclNGcEJO?=
 =?utf-8?B?cVdqa1FRWW4rOUExenB3aU93Q3ZabnhZSXRwTzgzckY5NnNLUHpyZ2Z4YWVE?=
 =?utf-8?B?VEJYRSsxcmRDaExwdnhldDgyOVdjYnlWVjhnbTVlQm54Z2JjdmxZbkxCZG9V?=
 =?utf-8?B?RXF6MUsyR1hiakJ5ZVZCMitFd1UvdE4zUTROSU1VclJmL1k1ZHBVSXpiK0Q5?=
 =?utf-8?B?N01WRVF1Q3N2b2Q1MXd2RWZEOEVOdVlLN2FwK0pGdE9NN0cwbmdSblc4QVJs?=
 =?utf-8?B?bi8vQjhqUDRVVG50QXo4U2Jhd24zUTlaMFlURFduRDJhREhKN0pPSHlMQnEr?=
 =?utf-8?B?SmdRaFZGS2lwbFA5SzBmMGorUlFseFFIREJrT1JZeGR6ZmZ1Y0Z2Q0lDZXpt?=
 =?utf-8?B?TjRPWTRDaW9JMHRQTVdOQjU2SXJQd3BGeUROSTdCZVQvbDRnN1praXJEL1h6?=
 =?utf-8?B?VTlLZEFrNW9NSHA2TXhyNU92RE9TalB2SGViUWR4VWlKemFlSGk1R21NakFJ?=
 =?utf-8?B?NGhLMytVbnR3NDNmOWd5Q1ZFRzVJWitXeEd4Nk5pSG9kSnpOTndOQ0s4QkJv?=
 =?utf-8?B?aWZPV0EzV0pxdDN4cjFWcDEyYnBpNFBmYjlCeHJTMHMwTWpNU2dEUG12bEpp?=
 =?utf-8?B?NzdCeURHRDcwYWcyTXl4TENTakJmVXJZcWRYN1hjNDFRMnFsQnRJQkV4RllM?=
 =?utf-8?B?VW4yQUhsbENZUW1BSThoSzJ0SkdXQ2NTNUtUZXUzV1diV25PbkU4QStXeGhD?=
 =?utf-8?B?RTB0TUw1NlZ1a3pINWlzTHFpK0t4Uk50Q3doclRaYm8yTmJnWlhia2J6a3NX?=
 =?utf-8?B?dW8wdXo4WHdESTNmSHpZNXNGMHNIYmxxOElXOVlwQXRCd04zblI2ditjODVX?=
 =?utf-8?B?bEd0dXdpWnBCaXRDMFRtTzh5bnl6cmEvcVdINFBwTmJSWEZoNXJJSjJEdm1W?=
 =?utf-8?B?OFdyeG5kWGFPREk3YlNPaG9SaUJlOXdOb29FMVdlY3JaUlFET0dlZm5VdnZ5?=
 =?utf-8?B?MmQwZ3BDckcvSXAzNnMwK1IyRnVwSnF5QzBxN2NwNXdkMTNabVdOVFFISUlt?=
 =?utf-8?B?SkZxT2dMOFdkSmI1bGp0S2p3MDQ1NGJ4TVhaK3BFRW5zcnNGWmw0bU5UTzlW?=
 =?utf-8?B?NUR6T3FuR1llVGVRUXRpakNBcEpnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3915c82-3f03-472d-357d-08d9c1915dc9
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 19:13:54.0090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VPC4AxeABJ2JWoLw8v5yF3VmYs6vUy0OqTLtFqct6OKDU7Ds8EFLLUKSxQxShEgHWgLc1ynVDqgceTXZ5hH+/MymwiQgMcuTUSTZkyWnWh0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB3043
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10201 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112170109
X-Proofpoint-ORIG-GUID: 5B3jgs5mnv_TE7aw-EtQjKJ7RwoJULb9
X-Proofpoint-GUID: 5B3jgs5mnv_TE7aw-EtQjKJ7RwoJULb9


On 12/16/21 5:02 PM, Oleksandr wrote:
>
> On 09.12.21 22:05, Oleksandr Tyshchenko wrote:
>
>
> Hello Juergen, Boris
>
>
> May I please ask, are you happy (or otherwise) with current patch series (I assume, especially with commits #3-4)?


I think I mentioned last time, in patch 4:


+	if (target_resource != &iomem_resource) {
+		tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
+		if (!res) {


Other than that --- LGTM.


-boris



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:17:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:17:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248819.429176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIjW-0003Zo-UA; Fri, 17 Dec 2021 19:17:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248819.429176; Fri, 17 Dec 2021 19:17:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIjW-0003Zh-R8; Fri, 17 Dec 2021 19:17:34 +0000
Received: by outflank-mailman (input) for mailman id 248819;
 Fri, 17 Dec 2021 19:17:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8jqe=RC=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1myIjV-0003ZZ-E0
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:17:33 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fb5cd63e-5f6d-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:17:32 +0100 (CET)
Received: from pps.filterd (m0246631.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BHGXtnA027776; 
 Fri, 17 Dec 2021 19:17:17 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cykmbpmen-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:17:17 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BHJGeRq034451;
 Fri, 17 Dec 2021 19:17:16 GMT
Received: from nam11-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175])
 by aserp3020.oracle.com with ESMTP id 3cxmrfa09u-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:17:16 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by MN2PR10MB4157.namprd10.prod.outlook.com (2603:10b6:208:1dc::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Fri, 17 Dec
 2021 19:17:14 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4801.017; Fri, 17 Dec 2021
 19:17:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fb5cd63e-5f6d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=d0TFOMFv8dxG01rJQp4drUaupPlzT89PH9sQ22SAG+0=;
 b=HUndmENenvkmubfk0Mropp5C8mhZ6y0jnTjxjT9tgY36uCwokHC/knGq7ou3uULLRqR0
 jOwRp9ix/GCT+YeMgkVSKyXXxm9Cd9y1Gm8vzj/vLvj+u0Ol5PNZNyspUTK7U4MTc+eA
 Kvfu/zNoC+cZcCvc4VmE+Ol0Tl0Xf5/Z50ouVC4BXMXBdlVVyOLtC0CBH6mO2xy/ddCS
 EmUKXZ4s5isrNHT3fBZnUX5N1SowGZrNWpwf8qeZU0fEWTXot8fJx+oK0//9XkqG0lxO
 WeTKyWdmo0ZIc5UavlkXaUkAPTdtspV5ayaLG/rRLU6UeUl5XUyJpNXUfEFXYHqCU3En jQ== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XNC4MWN9/YbAQpahy5CnYfI409V96D2BgZoXluETtxahAe+MXxtn95ER8DyU3jhibIgpFNbtHHEm4R5BeprUsyJqhWL6gAPi7tk9qIYsEpMrJ+fo0FyrW096Ac0/2qNTO+I+L+V49DS9etVKmhAyrHZnGcaWXahq0ase269TH5xonBRVPkNR0S2sXK2wLdAzV3qc0jhmqykKnwJdim8qnfTxNqXCsFdUH3cSoWqX59lpWGZehkjKDtK/7UJCLAB23vMJ6QQPHkD69QCN9Me1tgL8Jmjwoy13EDiFe3N+Lw9vajumP0U5/VzCdVzhaFT2V5pa0TybY/BJTO6z2iwm2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=d0TFOMFv8dxG01rJQp4drUaupPlzT89PH9sQ22SAG+0=;
 b=jQjnyghuiOoTywsxw7tq37Aqq+EM0kzp/OH/E3y2zFKIiA8DrevX+rd/VXWIcKX+3v33xc/4U5RBPUzBzvZQDkZbBcml3P5QQ9EyBjMfATZSZc7Y5TlfGPDTpM1fUnv27fbA1tCIHMiHSMaN5JJLVP0gBNRVPS7T97dMJo26sRGGIk49J/xIrukoscgIUYiyZLJflnIXHWwpzhgXf5kkKut0GbNbqb4Z6MAVUjTUOjVTenw5RThkBMyHfx1nClgSJr2q6hl+bU6uFqjKgr7kaFXk4L7K9DRMOwgeGBciQsAMOWRFloq5+Xe3B6LqKiyqkbH1Mgb4pXius2sfLOO1sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=d0TFOMFv8dxG01rJQp4drUaupPlzT89PH9sQ22SAG+0=;
 b=jbJ7lerKwoe3d+12MglEQcMFH+eLavMyvTCPKPsaP6UW7AS20lhHNociCJ2CXKA3DHoQIvMrf1fa4kT/VxCdJaF6dge6d+N1/tmog+w/K//iMAejIMfESrmWddcHez/DAxy1qNnBBn0gTzlaYWxOBxhC9tOiHzvqFO7QHhLRGTY=
Message-ID: <c6308cae-837d-1a77-cb93-6c9ad4bcd714@oracle.com>
Date: Fri, 17 Dec 2021 14:17:08 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges)
 on Arm
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>, Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
        Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: SA9PR11CA0004.namprd11.prod.outlook.com
 (2603:10b6:806:6e::9) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cc54b8c8-ba7b-4393-703e-08d9c191d55c
X-MS-TrafficTypeDiagnostic: MN2PR10MB4157:EE_
X-Microsoft-Antispam-PRVS: 
	<MN2PR10MB4157AFF5005A5EF31771E26C8A789@MN2PR10MB4157.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1247;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	wPB8NBp+f+thuIKY3YU/g3AurSLPi5BrWsuZJeXtPR9H4syKDPIWshAAMEwXohJBinv1zGpth+9PFBd8ST0GvbJyIkwNo/eYpz29SNxLXEH3HhExbwUckdrwB7AvZmBPzIguaVQ2pI8mLfoUK1Unsof5R2fAHYsGWD/2gaWKJiU2kHAefaXR+WBBiFzyY46dJmlkrdTpVDQiUnHC1IrXWsyS6/kgaZ/muc8v6s6DyUes+vaUIISEj7kIm1a3jISGQ3ZVZekb00HrKPR+eitgF8NXf1CqR2ukwlOvAtUqFRw3IjwkF8K8T1F1hJYBrWuI2dwKv0NJGxyMJmAcPWrY5UzU23Qvl4g9asIKbZtagNw+z2xi6PNXzLVdk+JyJeI3wWEcXZMSmG5/4GI1qNXoxa8jLXCetxn6XLi4Q93ZWGC14POQcnqHMhFybTljt+vAjKq2NGGuS4LHrvf4mtBspXcZXtsGHcs4cFEGwSspp72UQ0J59o/U00pEugwTOw5xGUx/QAHx0W+RRiRHlvEjZavIHE6bOXRtCbW0LICcaYnxgEb32zDOncHxnYJ9EE52ponQZu9b9x43YVciTpk8FT0QkZQ05x3jy5m3szzZCPygb2swC+GGP83SDMLfEo3bXPRpZgMF/bWYrDOa5OEC7aSafrUtB7GSzbyZ0d0NXPTYSSZvT19600kLNmU+RKQOxMY3O20mmIsp+Jfnz+jh5foMWq5+5dOk/d0H0G4by5E=
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31696002)(8936002)(6666004)(558084003)(86362001)(44832011)(2616005)(36756003)(6512007)(38100700002)(6486002)(8676002)(186003)(54906003)(31686004)(7416002)(5660300002)(508600001)(2906002)(26005)(110136005)(66946007)(4326008)(66476007)(66556008)(53546011)(6506007)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VVlvZUEvNHNqZWVjdndvL2NtYmNKc3g2L2Ficm9LdFd5UUFHUHNIMElBYnhq?=
 =?utf-8?B?SGRBaVVQeFg3b1Q4RW9idEVvdlBRWmowT0IvUnAyRGZ2YWQvYmtPcWRCVjFB?=
 =?utf-8?B?WXFkYWV1N0Q5T2JWVFhiQk8vZ1ZhdC9acjRXaVF4TmRMQWJqdnd3akdoNFJs?=
 =?utf-8?B?Yk5jKzJrV1JMOGY4OVNkVC9Ua1cyMkpDSVVBUndMRDBoR1RWcS9ZWTQ1ZFYx?=
 =?utf-8?B?LzYvSlhUY3ZHclFKaW5xenlGSWEzV1VGeWlCMkVHV3RjeENGZ21YbjVMSDVv?=
 =?utf-8?B?RE9nNVZkR2thWndnSXM1K3hMWmFpWTVvYXpjQ2xKemZMU25JRjZoYm94bnBP?=
 =?utf-8?B?NW1YS3dyaTJBUWFkYWY4bys1MlgzeTRQRmVYeHJJeFlHbHQwSFlsNC9sejNx?=
 =?utf-8?B?eXJSYlBCT3RrNlQzdHdFT1k3Tms3ZTRFcDRndjBlQVo1TVZaTmlDYi84RUVp?=
 =?utf-8?B?SWMxaFJJeFUzL2lUcSs0cld1K1lLd3lTOGRnbktmYlE4a0svcGJZYjE3aVdE?=
 =?utf-8?B?dCtCQVp4aUoxUW1DZ2YvRkRpaVYxSjBVVDhzLzlVbDFvNXJuZEhsM3FwZW9U?=
 =?utf-8?B?ZjExZXFFVWRsaGtGZC9vTnlmK3BBTUIvV2E2UzY4b2wxWE9mR3ovQ1dzbkZz?=
 =?utf-8?B?ZmFVMHZsb1NvaGZ6ZXpvTHF3UFR1RloyZi80d3hLS0tCcDdBMjJuSERiQlBX?=
 =?utf-8?B?eXBKTm4wYm9RS1dlUFg5N1kwOTJJSGtYb2hLVC9HSXZzYWc5cmpYWWlBQWR1?=
 =?utf-8?B?UTF3WStkNFlVWnNURW9mQmNnOTQvV2NjL3JwSWMwWXlUNjRiQ1J2TURqQ1Bt?=
 =?utf-8?B?a0VCTGc5cUNoT3orVktxVXc0SnhjMjF1VDZBWjFsejN0ZmVWN200bGJSYjZs?=
 =?utf-8?B?bC9RMDdzdXlFUzVrSllsdzhOQVpsRERYRHlPaU1BbEhzRmZGdnUyTkw5UjJ2?=
 =?utf-8?B?VStvaXpTcDBmOUZ5dThRSGVQTlJTUjhwWldHUjVNOW90MjNVQ05UMWRaTXo2?=
 =?utf-8?B?YnV0NlBrM0QzMGxWMzlLdWxZWjBiQzFDUXJNeGFralp5OWh5YWNEcThwMysw?=
 =?utf-8?B?b0ZFTFA3UEljZjN4N2RVUVFrOHdKRURZSlA2RDFlT2p3ZTVRRDdGdk5YTjRh?=
 =?utf-8?B?akRrN2kxWFVuZlBoVFd4bW1UbG1ybG85Z3JjVVF4UnlIcG5Ub1FyWFBEd0RR?=
 =?utf-8?B?WG5laUg5UlE3SXk5L2NvS3ZnZmlTQUV3UzNjeERIaVQzVW1TVHJMNzUvRTVT?=
 =?utf-8?B?VTJOSVovMWtEa093Zm9pNURRdW5YdVExV2RGRFJLdVl6cVpMTERabFlVR08x?=
 =?utf-8?B?ZHNKR2dwMU1hcVh4MW9pRENyRHY3WU1lV0JPem4zWExMWTkxMDc2TVdsVmtj?=
 =?utf-8?B?MElEU1lLbmxzaEp1Uzhia1pYVS9XcFZzWVV5Tlo2TGZmeDB5bE54SE4wM2VW?=
 =?utf-8?B?TW53dGJOc1NUOHpsY0JaTmZrZVQyczJpT2xVcm51NWpVeG9oempZejRQZ0VF?=
 =?utf-8?B?NTljU2swSTNkbDdLdmFoT2tYbzlwRUNVNFJsbFlLdEFjNHlpeEpMSTI5QnVt?=
 =?utf-8?B?aXNmaXVJTWlJV21UbkQ0MnlrTGRoazNxNUIyTzVXYW1vdzVwS0tTdjRHUmg5?=
 =?utf-8?B?cG1JbXpaWVNIYTZLcmFmOFNDOFQ2L0VvYTZNWXlLVW1vKzNUM0RxeUV5VDd2?=
 =?utf-8?B?QW01Z0VrYjlHejYrWkRtM3Y0Z3FXYlZ4anZWSVZyUXM5aDE4R2JZbzdqd2Uw?=
 =?utf-8?B?bHZNcURlaFNleGkrSFFESjBaYmRNWFgyY0ZIRWVQM1lUNU5aVGV5ZmpULzRB?=
 =?utf-8?B?Rk9zQmswb0hxa2cxUG5ZZm9WazRBalUwZkxKZjcwUVdGeXFobitCbE5La1Ni?=
 =?utf-8?B?QWRaL00xMXF3dGJNQzBiTWVXaC80alUranlHQmc3Qlo1U2NUSTJnRWFlRUx2?=
 =?utf-8?B?V2MyY3ZGTlNpNWxibnQzL2x3SlNRK0NSY0ZCMm9KeVo5MjFPY0tEWDhSekhY?=
 =?utf-8?B?bnorREluczhCVXNEdmR2ZkFNd1NOZk84dHloZnpCWTU1VUJzL3dhRnlnbmd2?=
 =?utf-8?B?bTExWGhLNUlXb3JwQkd5WGJrWXBCQ0k3dUdsNDUwaWdtOHZJRUovY2Q3TTND?=
 =?utf-8?B?aE41OThST1padHRGK1p3Ung0QXJ3MFNSd1Foa1VEdU1QYk40b2w5OGd6YXc5?=
 =?utf-8?B?WTg3VVFmVVdsR1VmcmlHajcwNnNEaWdKTjZkeStoYW1xZUZjYm1pWlN5VmRG?=
 =?utf-8?B?RzQ1dlZVU0IxZDh2czE1ek13ckhRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc54b8c8-ba7b-4393-703e-08d9c191d55c
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 19:17:14.5252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AF07ZQu1qH5RSAE3QNHRjWADtqIUA8igivlt07RnsD/9OAdaHr3wMbiD6wyAXd5AsrekYM/0UPd7WPR671ZzOtnwUxBBWWs64ftNJ57d8K4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4157
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10201 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 mlxlogscore=916 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112170110
X-Proofpoint-ORIG-GUID: DwkldegeRpsqFL5iPXEaxN3MjOJEWuIs
X-Proofpoint-GUID: DwkldegeRpsqFL5iPXEaxN3MjOJEWuIs


On 12/16/21 5:02 PM, Oleksandr wrote:
>
> On 09.12.21 22:05, Oleksandr Tyshchenko wrote:
>
>
> Hello Juergen, Boris
>
>
> May I please ask, are you happy (or otherwise) with current patch series (I assume, especially with commits #3-4)?


LGTM, I have no more comments.


-boris





From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:20:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:20:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248823.429188 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIlv-0004fK-DA; Fri, 17 Dec 2021 19:20:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248823.429188; Fri, 17 Dec 2021 19:20:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIlv-0004ef-9T; Fri, 17 Dec 2021 19:20:03 +0000
Received: by outflank-mailman (input) for mailman id 248823;
 Fri, 17 Dec 2021 19:20:02 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EyUW=RC=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1myIlu-0004WC-M3
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:20:02 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54d50434-5f6e-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:20:01 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id p8so4910832ljo.5
 for <xen-devel@lists.xenproject.org>; Fri, 17 Dec 2021 11:20:01 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id a24sm339941lff.207.2021.12.17.11.20.00
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 17 Dec 2021 11:20:01 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54d50434-5f6e-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=avniy9qb4J011EGRN+LaM7W8paozVJQP0KxTT2YMfaI=;
        b=MmZZ46PcYUUcsjmI/6xOuddxmuVgQ6bMgQ0ASaTyyLNeKGdg9ol6X343+95usrqR75
         H4KcFPS2cQArCZfqlpcoIOIV3uhcxJa2ClF8JD61FYZjPxF+HMsg6+8y/3e4mye3hgkW
         oD25yg67te8Tr2gjxgmNiAOND35jg195cag2g103GmdxE73fC9AUDaaBEEehYiWWvL0E
         /FFHnTk5Qt3WL7s24klLc2g5qpcHEvOfz1XEHcC2PCufm47sgIjZG1Fw/Mat7Bs8sd9v
         9bf2N6AzMn4fP9DoS8aH0zsi1xRARwwqm0Jj+K0Dpp9llPi2H61rgYWfPAoaaDnCrjxy
         +62w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=avniy9qb4J011EGRN+LaM7W8paozVJQP0KxTT2YMfaI=;
        b=2GPpT0Xg7wnoZkbkKLXf5AaXBJSS5BIOIVPJ+9bRe6+bugLf6zZvHK+g4D9fhQfTXV
         y17TDOkGHBu+lg+jfVPKR3MCztlSBk6ML8gpv0M7SfR4opWzFQTDoW/OtHtIuf/vCxvc
         LZojdX/FsRRCo5YsZptzPLe+B6gPKDHaZnx9Qqs3ehxoXgiRPe108gXIT0weCDj0mrdn
         TtZxaBquAo4VL+gGY83+uUfY8SZRQrvTu4pv/zKrX/jHLsUYAhGWJAcAgiYrT+WNNx/J
         H+uD/k/5KiGPymKx4Op88YRzseXIt1oDRQfAxW5LhdbfeudOUCbRaIfzMkOzQ6SCJoFW
         sXIg==
X-Gm-Message-State: AOAM533IWjqX/tp4bWM6UHv8X/6kGBTWVBVt1ZzmDCmi/F3Opezy92IX
	tZ3/7KB/BLyEq0Mk9PkG03Q=
X-Google-Smtp-Source: ABdhPJy7CxY1qWp/EPeAjEl66DV9k+C/gmL7Ac9Rt9DdSeaIt1InGxFiQfFj9ED1FOvrVTa+NN711Q==
X-Received: by 2002:a2e:b169:: with SMTP id a9mr4031507ljm.369.1639768801238;
        Fri, 17 Dec 2021 11:20:01 -0800 (PST)
Subject: Re: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges)
 on Arm
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>,
 Bertrand Marquis <bertrand.marquis@arm.com>, Wei Chen <Wei.Chen@arm.com>,
 Henry Wang <Henry.Wang@arm.com>, Kaly Xin <Kaly.Xin@arm.com>,
 Jiamei Xie <Jiamei.Xie@arm.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
 <81c97e6a-f5e3-3f5d-c9ae-a35933cf4e61@oracle.com>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <4cc296cc-c7d5-1bce-4074-b708a18d9304@gmail.com>
Date: Fri, 17 Dec 2021 21:19:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <81c97e6a-f5e3-3f5d-c9ae-a35933cf4e61@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 17.12.21 21:13, Boris Ostrovsky wrote:

Hi Boris

>
> On 12/16/21 5:02 PM, Oleksandr wrote:
>>
>> On 09.12.21 22:05, Oleksandr Tyshchenko wrote:
>>
>>
>> Hello Juergen, Boris
>>
>>
>> May I please ask, are you happy (or otherwise) with current patch 
>> series (I assume, especially with commits #3-4)?
>
>
> I think I mentioned last time, in patch 4:
>
>
> +    if (target_resource != &iomem_resource) {
> +        tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
> +        if (!res) {

Yes, this is already fixed in V4 of patch [1]



>
>
> Other than that --- LGTM.
Thank you!


[1] 
https://lore.kernel.org/xen-devel/1639080336-26573-5-git-send-email-olekstysh@gmail.com/


>
>
> -boris
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:23:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:23:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248827.429199 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIpD-0005jo-Sf; Fri, 17 Dec 2021 19:23:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248827.429199; Fri, 17 Dec 2021 19:23:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIpD-0005jh-PR; Fri, 17 Dec 2021 19:23:27 +0000
Received: by outflank-mailman (input) for mailman id 248827;
 Fri, 17 Dec 2021 19:23:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8jqe=RC=oracle.com=boris.ostrovsky@srs-se1.protection.inumbo.net>)
 id 1myIpC-0005jb-Qu
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:23:26 +0000
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com
 [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ce091cec-5f6e-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:23:25 +0100 (CET)
Received: from pps.filterd (m0246630.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BHGXpfx022569; 
 Fri, 17 Dec 2021 19:23:12 GMT
Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70])
 by mx0b-00069f02.pphosted.com with ESMTP id 3cykmcpffh-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:23:12 +0000
Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1])
 by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1BHJGeeC034448;
 Fri, 17 Dec 2021 19:23:11 GMT
Received: from nam10-dm6-obe.outbound.protection.outlook.com
 (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102])
 by aserp3020.oracle.com with ESMTP id 3cxmrfa60m-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Fri, 17 Dec 2021 19:23:11 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10)
 by BLAPR10MB5252.namprd10.prod.outlook.com (2603:10b6:208:328::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.11; Fri, 17 Dec
 2021 19:23:08 +0000
Received: from BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12]) by BLAPR10MB5009.namprd10.prod.outlook.com
 ([fe80::8d84:1f40:881:7b12%4]) with mapi id 15.20.4801.017; Fri, 17 Dec 2021
 19:23:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ce091cec-5f6e-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date :
 subject : to : cc : references : from : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2021-07-09;
 bh=mXfL+A6zgLm4BS/AQO87DgZdNs/jv8rFGFxDoWbkGXE=;
 b=mmtXlYthItXWg0QBWXmNgTJQ2x7+RIA8KvaNyfVwfa4ERK6y1EE/rPWzCbzlwEydXsGF
 SVdhGjweZcNXp7+oD0/XNFqOkOamomop1aESHYwIdVmW7JaMVRy3a7FXr7Q9gcRZpq5X
 ZBOY+3U0ZsNSkq4znMqOvhJSlS672vWL+QPLLEEmuFWae6v3GC+5AZAbGet+24ffBZKX
 HMut8g6bRkfQFwwpmE48A5kSz/zIcqYjrmhKDz3lsJhyuGn+U9zO7YVqGbATKdDj4okj
 ePGjK5dN+vmm+JzibRp2hzIeJZRE9uA/YdlRxma6WbdQ3K5j87yjAAz37i6aDAjTqfLO Sw== 
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SAfJocytaOGzI/SWcEFPyos8c8X3Prq0CQ1AIMVds9sGko2BrnvTIBnN1ssOCh64+bg1AIoh96I8+DXoYTpou2b9P5DWVy2MwN/U7nwRVlq8GGQ4oZjazRzOO4W6gVwZBhH8M5gkMuAWs2u2gIvt8fDAtB6nwzAKE4AnhCAhb3+h+2YeqMLbvLajPQonnQtyPWxJtbsiDqHZsR6ig+GPt3Jql79qWegNLZ2sjztD2Sg3CnMye4eknbKgyyo4x4Q1xZU8KCy3EhMvvMiaa/WpQGfq1uAZsjiiM2y4n1pHMhXzhF3yRZES3knEF1WarYsb3WBST3vrjBjpUbpd3biRqA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mXfL+A6zgLm4BS/AQO87DgZdNs/jv8rFGFxDoWbkGXE=;
 b=DdWm0Ky5+wesfKh9sr18obo4F0/glTI0b0qBrqgPvwweFJUkDNZbunx3LYovUQsPwdTXqe8j89N/ZV3Y2zZmjBaDPf4tsrn75NKaHpOn99kJb1aXXoq5SFpa8xp/L0F/eYWYRFU3UpH5oF4bn/LmKh/o8YV5h45KZj1IZ9Zwyj805362QEaU/NXPqn1ciTu4pfc0YZmdsRHDgtkvV/cBO//UtYpTLDWYEPg9PvmLqQKvA2LJteplvH5D71TXmtT6BjqFmSs2Hh/gA/9SSUmOCqoDj17fukVlNAwJMwu7/uGnMcNVguJsmjRs1wEwooAOuwfbrOPDIs6dTzer4acHDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mXfL+A6zgLm4BS/AQO87DgZdNs/jv8rFGFxDoWbkGXE=;
 b=ERKnlQ9WmA97pLxaPsyaxgonVUGe7GMBsOvJr1rAlZIiNZLE8UGgpU94TOCzdXJIHuJ4Ad40bIyl7L6Elhzy0NoWNGCq5Tm/nsDE2zo1pCigoJbY2XpKh/ufZX4ZDv0CMJk+wRSayd5MCf/I3NN9N2bOxqCNyo+T0p/S3tE8ozg=
Message-ID: <9a01e87c-9c03-ea72-4115-0cdeb064d1e3@oracle.com>
Date: Fri, 17 Dec 2021 14:23:02 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4 0/6] xen: Add support of extended regions (safe ranges)
 on Arm
Content-Language: en-US
To: Oleksandr <olekstysh@gmail.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Russell King <linux@armlinux.org.uk>, Julien Grall <julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>,
        Wei Chen <Wei.Chen@arm.com>, Henry Wang <Henry.Wang@arm.com>,
        Kaly Xin <Kaly.Xin@arm.com>, Jiamei Xie <Jiamei.Xie@arm.com>
References: <1639080336-26573-1-git-send-email-olekstysh@gmail.com>
 <1428a0be-b80c-f996-1f72-6545dd66c1bf@gmail.com>
 <81c97e6a-f5e3-3f5d-c9ae-a35933cf4e61@oracle.com>
 <4cc296cc-c7d5-1bce-4074-b708a18d9304@gmail.com>
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <4cc296cc-c7d5-1bce-4074-b708a18d9304@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: SJ0PR05CA0177.namprd05.prod.outlook.com
 (2603:10b6:a03:339::32) To BLAPR10MB5009.namprd10.prod.outlook.com
 (2603:10b6:208:321::10)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0a43832a-8294-4ed1-2abe-08d9c192a869
X-MS-TrafficTypeDiagnostic: BLAPR10MB5252:EE_
X-Microsoft-Antispam-PRVS: 
	<BLAPR10MB5252B724B7D43C76AFE8A57F8A789@BLAPR10MB5252.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
	/h9nIpcJey4AjLxWVU+x5uh9Cy6gQhYMialXmxnhyzqSqa6YojUwGKCQQlUrfKG5eSHZUA9p77V/ZY+oZxeFCpDZgmVSQLbwezsmj4BHNONDZJTOVtlosAM3j1KBPCp52S0RTKtvmU3+g8/1FXuSsoi/BJ2tbhXOnPBdhVBMWrzUd3A4Ohlu99XNEGYBmbt5eGqDWk0esWa7XYybBIFUhGoMmrppm78IfqXMh5wmXj8P/khWHyfLRWWmVIcbmExeMNSLjVRnx1Jg43SdWlOqM6ii4vHfLEg3UEtLn6ND2JlkmkGBDyqAdEJgwhO6qnez3+8LfFSzAyGIuU6igllu4uZ3NZohMaixZCW9CB7pSox/JUGcn6k2mePDO76cneTneoddH67Ixv9/1wRSfmU8DYIHMua5iWEkKaIG3d2NmTwZm4tyk3gdCkCUknVDcCNJV13uC1AEAJQLb1ODJ+OiCXYWxn5mUrovuC+XrHf35XnVxhPKyLeW/NShnH6aiLx93e46bt5d/Ry5pZnfUEyJXI0p/RrKYhJ6udih0VDyj6gyGNNf1X+vkm6cdI0Deism29WcTsxy1oYAqb3S8o/H19Qtx4RN1XneFNWX73juhToVZ+s8Km5x/muvAIqJbi7nD7Zcr51+Msh3rLlEJogAJWPL5O+hoxXhwI3S01T66NsHA+cTP+RJ7CjsEKb6oz0C/e+zORSqn1uZ5HriOebrbIrgnt5JDc0YqPyksealu7TzK4Ol7Zy5pi2//5gAjIuZ
X-Forefront-Antispam-Report: 
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(44832011)(6666004)(2616005)(31696002)(8936002)(54906003)(8676002)(6486002)(86362001)(2906002)(26005)(4326008)(186003)(38100700002)(5660300002)(6916009)(31686004)(66556008)(66476007)(66946007)(508600001)(7416002)(53546011)(36756003)(6512007)(4744005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RTRvY1B2cUllZTJiNkNqd210V1dkVjF0VWRERkVmajZoK1NKWnh1ZkJRcE1M?=
 =?utf-8?B?djlPVGkwY3FYK0p6MmxOVXNtVndJTWtWSmxQTjJldEliVUw0TzAwcnlOK1A0?=
 =?utf-8?B?UlRUTzVDWGkzMHEyUHdVUlIvU0hIZ3U3TEpXQlBFZzl0aU5VdGZKZzM3ZEVj?=
 =?utf-8?B?RTRSMGlLZGNMZnBVVmpoaWNRQUU0YnFIYm5ZcUFwdFk4dG9SbFJkRmpHWk1l?=
 =?utf-8?B?NFVBaU56eUhocXNzbDVza0ROOGNZRjZ0SURaajFEbjIybjZldjl2dUliamdG?=
 =?utf-8?B?dno4TlUwaTFBallGa3RSNUpORC9FMkZndXJKRzhucmVVZCtKRjNRNnhoT2FZ?=
 =?utf-8?B?aC9pQStMUVl3WXJwUFhNa0ovV0c2UHR1MGx5R28rdVhYNVM3TFdLMzErVmdt?=
 =?utf-8?B?RXgreGoyNGt4Y2h4L0VlcTY1cHM0UXhDdGdoTEtPRzRkbVdSZGh3ejUySmpS?=
 =?utf-8?B?bGhYS0hzOTZwOWUrM2QzVFF5S0FERCtsbzlocmhpZkpDazZGWTE3QVdDVnNJ?=
 =?utf-8?B?cnprcGEwTDVxVGtmV0hKVHpDVXpLaEI1Q1YvWXFVN0pLbkswNmVTa3I3Tmxv?=
 =?utf-8?B?TG44a2RPQ0JqbEJjcnRKUzhMNnhXM1FLTGxxWlpMNkhXSm02QkhaMGQyVU8x?=
 =?utf-8?B?R05uN1p5UWZKNFhTUjRieWMyMldVWis4OXd6b1YwanNSRkZTcXp2NnVkTWwz?=
 =?utf-8?B?WXFTMk9XZk9VTkwxNjRDTmVXbTBuUE5lYWlOV2hwVURoSmRENGpGL1NGQkJs?=
 =?utf-8?B?TFZnQjRSV3lxREZscnVqa1FFQkM3KzcrbUN6WktGOS9HNnltTURYbWlPM3Nl?=
 =?utf-8?B?cS85RTNzUXYvT2dmdElXaGZiQ0ZIK09pbWhyMTJWMDM5TE01c2RHa21MQnFX?=
 =?utf-8?B?d1d4a3F1RXJDOXBrZUhxajNJRHdIVTQ3UnduTjEzdS91cXVQV1RDK1BoTDJ0?=
 =?utf-8?B?UEhNenM0dllYVW9iQStMdzZkYkhVRGxNNkxpSzUyZE16bFRqQ2R5dlg0MUZm?=
 =?utf-8?B?TjdscnJ2RWdibXMrSmhnL1FQcmJaK29OcG9QSTFkVER3cWNQR3dyMzNSRUYy?=
 =?utf-8?B?aHhuV2lYQmNYQmdKVmt3MnBlNHZoKzFSUnBuM1RxRFNDLzZhbWdRWVRhNVdT?=
 =?utf-8?B?NWl4aDFUVWNwL0p5cXJYM0JPQ01XK1Y4SE50OC94N0diVUNJTjh4elAxbFVm?=
 =?utf-8?B?ZkR5Rm0vcXpXcmxWMEZGVXZWVlQvZllhMTVHVjNjOWpXNEZHcEZsRWxYVXox?=
 =?utf-8?B?c1k5WC9EMjFrcWJUKzBUeVNrUjBvODV2SzZ3MGZqdFVLYmRteng5c1hRQ1JJ?=
 =?utf-8?B?eDRrQXlPOE9iODNjdzRRZWwyMFpEY0ZoenM4S0xOTVV2RW8zaUJCdzNqdVFK?=
 =?utf-8?B?WFdTampESmtoa0h5bHFNZ2ovcEExZTFIMDJiOERLRHJrZVU4enV1U0RCUTlx?=
 =?utf-8?B?S0JOSGtEWDArdXgvSmNmWUlhdUhtaHBmSDhrLzRibUpCbjNGWFV5MFdaRGRa?=
 =?utf-8?B?K0JCR2tMY1lKZ0pYWWdHQTJDbE9xdUsrNCtKdi8vOHpFSGlDcmJOT2k5Nkcw?=
 =?utf-8?B?ZGlqS3ZaMWsvN0NkNXJvRFR0dzVWVldPTnRvMEVtMTRyZnNRNE9MVXRvOUo0?=
 =?utf-8?B?T1Jvam12QW5QTWhRY0ZsSlpkTjlDUHVhNzZwcGVFektQM1B5U05xQmFVWm9z?=
 =?utf-8?B?THJGZExxRWgzdG1YSG5xUEI3SGxtZVRSUDh3MzN1VWtzbG5iTm52WEQ4M2Jh?=
 =?utf-8?B?aVNxMXJoeVpRNHRnT0tvbklFUHZNdjkrMUprNHBSelQ0eXJlcW9nM3BickV5?=
 =?utf-8?B?ZkVLSU5OSEt4UUxVSUJyN3lNMjhvUnY1NFJFMXZoR2lFTG5KOE1uRUZFVmt6?=
 =?utf-8?B?UzBXTVA3VjQ0aFo3MFJIemd0ZTJudElZWVpFRlFmQlRDVXhKeW52NllKUlk4?=
 =?utf-8?B?ZnBCdVJoM3hIYzBaSkZtVFlqbFFjeDFFRWZqVHVaQ0dJcXNDSndKanJpQkZQ?=
 =?utf-8?B?am5sejVXQ1c3ZW1XV2ZGTlErcWFVMmZDU3hTYlQ0aTF4Z3FQZXVKcXpueVFW?=
 =?utf-8?B?SWtQbTVqV1RnRElGQzV0NkFXTW44VWdpa0hmY0graDV1blQ4bTFmZ0ppcUtp?=
 =?utf-8?B?LzdSdTNxQ0ExKzFPTG1Ya0NQVTBxRzdiQkZDekV5THlRRzd2NXFYZlRYZ0NR?=
 =?utf-8?B?UUM0eHU1MDZ1bkRjNUkrVDNST09rWTh2aHBMV1AyVDUyVHhYYXVuVFdPL1RF?=
 =?utf-8?B?Tm1halpBMUxYRjZJVTVwRkhETnZnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a43832a-8294-4ed1-2abe-08d9c192a869
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 19:23:08.6417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RAkp6soNi4anjumKYtlfY1UUtH6v1Woe1k+HEeSlI7zX0QA0mAUAoj8mU4dXiG/pah8I8pU0/+z6Qr8RgwFl1QpEs+7A4pPA8M/cDJIlnfQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5252
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10201 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112170110
X-Proofpoint-ORIG-GUID: HAN_Fd2cJPnzTnC7mERx-z50_X9d0FKR
X-Proofpoint-GUID: HAN_Fd2cJPnzTnC7mERx-z50_X9d0FKR


On 12/17/21 2:19 PM, Oleksandr wrote:
>
> On 17.12.21 21:13, Boris Ostrovsky wrote:
>
> Hi Boris
>
>>
>> On 12/16/21 5:02 PM, Oleksandr wrote:
>>>
>>> On 09.12.21 22:05, Oleksandr Tyshchenko wrote:
>>>
>>>
>>> Hello Juergen, Boris
>>>
>>>
>>> May I please ask, are you happy (or otherwise) with current patch series (I assume, especially with commits #3-4)?
>>
>>
>> I think I mentioned last time, in patch 4:
>>
>>
>> +    if (target_resource != &iomem_resource) {
>> +        tmp_res = kzalloc(sizeof(*tmp_res), GFP_KERNEL);
>> +        if (!res) {
>
> Yes, this is already fixed in V4 of patch [1]



So this email did escape. Yes, I realized I was looking at V3 but apparently didn't hit ^C quickly enough ;-)



-boris






From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:32:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:32:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248831.429209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIxh-0007ML-OL; Fri, 17 Dec 2021 19:32:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248831.429209; Fri, 17 Dec 2021 19:32:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIxh-0007ME-LI; Fri, 17 Dec 2021 19:32:13 +0000
Received: by outflank-mailman (input) for mailman id 248831;
 Fri, 17 Dec 2021 19:32:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIxf-0007M8-MV
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:32:12 +0000
Received: from sender3-of-o52.zoho.com (sender3-of-o52.zoho.com
 [136.143.184.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 05d0fe18-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:32:09 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769522844320.4261730992407;
 Fri, 17 Dec 2021 11:32:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 05d0fe18-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769525; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=ZnnYkCGvNy1IMBK7HZQhZxKLEhAiDZoT8A2Gm/V02WKcwczYudXJZWP6gOP65E5jV/ytYq/zf908cMAuLfRAA66/HNvQQWWlrmacX2ZN+AN4XtB1OH0avGCrAcAUMngSikTDitlb4orcOewsH1xeC7As+mm9j1qlqbR3o/H2XQ0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769525; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=fa0wW/29nJurPMLwiV2rnoDa2hoPbWTa1Hg41W4npRw=; 
	b=JaCo0cT93rl4UAvZ32ReMGoqnM87o4UO/vFYi/Cad6Kk9f7Uj7WzQkrowbZXETT8KmEleND4E7bPDda4M64YhqBOuEJYBJoMCf0hwJy67QkXTg5QCZlrHHo7l0CWjS1h/qe+wdcXkaBRT5iQwSLKdlvicyDidTfvhzHqjJnQHwM=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769525;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding;
	bh=fa0wW/29nJurPMLwiV2rnoDa2hoPbWTa1Hg41W4npRw=;
	b=JUDRoFf8M6mQ8J1xWe7bC//JADa6eCocRw+DHXGMXPEhu8/07qcxzBWX8KDdvbGQ
	ZNxi3REIz8Kq7Zb5vwWzHOlwccohW6toHol6KmDDim3lRWUCuYWAo0lDqDJPMoQaFUQ
	ytZyNOrJ3xmVTGjLaEvH26HTzRilQ0lEdv3uJDOo=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Christopher Clark" <christopher.w.clark@gmail.com>,
	"Julien Grall" <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Bertrand Marquis" <bertrand.marquis@arm.com>
Subject: [RFC 00/10] Hyperlaunch x86 Dom0 launch
Date: Fri, 17 Dec 2021 18:34:26 -0500
Message-Id: <20211217233437.13791-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This RFC is to provide the base approach of how hyperlaunch would integrate
into the x86 start sequence with the specific intention to vet the
implementation approach early. What this RFC provides is a working
implementation of hyperlaunch for x86 that is capable of strictly starting a
Dom0 configuration. Even so the majority of the remaining hyperlaunch work will
be focused on domain construction and enabling the transient boot domain (DomB)
ability.

It is important to note that for this RFC patch set the work was split into
smaller commits to ease review. When the first hyperlaunch patch set is
submitted for acceptance, it is expected to see 5-7 rolled up and 9 & 10 also
rolled up.

There are a couple of areas that explicitly need review and discussion and the
commit message for a patch with one of these in them has the details, which
will be repeated here for them to also all be centralized for comment.

- For hyperlaunch it has become necessary to track decompression headroom at an
individual boot module level. The most sensible place for this information on
x86 is in the module_t structure. The challenge encountered with this is that
Xen's multiboot support is implemented by reusing MB module_t structure as a
common structure for MB and MB2. Early in Xen's x86 startup the multiboot chain
is copied(MB)/converted(MB2) into the trampoline data heap. To minimize change
for this RFC the MB module_t reserved field was split into a bitfield to allow
it to serve the existing usage of the field (relocation flag) and for headroom
tracking. While this provided a clean solution, it is viewed as a short term
solution. A suggestion might be to unify the existing architectures'
representation of a boot module and refactor x86's reloc.c to convert MB and
MB2 module descriptions into this common representation. This would have the
added benefit of reducing the static allocations currently being used for
hyperlaunch.

- When enabling device tree for use with x86, it exposed some arch specific
code in the device tree code in common and shared includes. Specifically both
Arm and x86 define a `struct device` but are totally different structures. The
device tree code uses references to Arm's version of `struct device` which
creates a conflict when the device tree code is used under x86. It was also
found that generic device tree code was currently in the Arm arch tree. Patch 4
contains a work around for the first issue and patch 7 copies the reusable
device tree parsing code from Arm arch for local/internal usage. Each patch
provides a few additional details and ultimately a generalized solution for
both problems is the preferable approach versus a minimal solution for enabling
hyperlaunch 

- To ease getting a Dom0 construction working under hyperlaunch the existing
`create_dom0()` function was exposed and reused. This was for the RFC only
and will be dropped in lieu of hyperlaunch gaining its own more general domain
creation function.
 
Christopher Clark (2):
  introduce hyperlaunch kconfig and core
  is_system_domain: replace open-coded instances

Daniel P. Smith (8):
  multiboot: moving headroom to per module_t
  device-tree: split agnostic device-tree from arm
  hyperlaunch: update device tree documentation
  hyperlaunch: add structures to hold parsed dtb
  hyperlaunch: add parsing of dtb
  hyperlaunch: make create_dom0 externally callable
  hyperlaunch: add domain creation logic
  hyperlaunch: integrate dtb parse and domain creation

 .../designs/launch/hyperlaunch-devicetree.rst | 448 ++++++++++-------
 xen/arch/x86/boot/reloc.c                     |   1 +
 xen/arch/x86/cpu/vpmu.c                       |   2 +-
 xen/arch/x86/include/asm/setup.h              |   5 +
 xen/arch/x86/setup.c                          |  75 +--
 xen/common/Kconfig                            |  15 +
 xen/common/Makefile                           |   5 +-
 xen/common/device_tree.c                      |   2 +
 xen/common/domctl.c                           |   2 +-
 xen/common/sched/core.c                       |   4 +-
 xen/common/setup.c                            | 450 ++++++++++++++++++
 xen/include/xen/device_tree.h                 |   4 +
 xen/include/xen/multiboot.h                   |   3 +-
 xen/include/xen/sched.h                       |   5 +
 xen/include/xen/setup.h                       | 131 +++++
 15 files changed, 948 insertions(+), 204 deletions(-)
 create mode 100644 xen/common/setup.c
 create mode 100644 xen/include/xen/setup.h

-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:32:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:32:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248832.429221 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIxw-0007hp-4r; Fri, 17 Dec 2021 19:32:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248832.429221; Fri, 17 Dec 2021 19:32:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIxw-0007hg-1H; Fri, 17 Dec 2021 19:32:28 +0000
Received: by outflank-mailman (input) for mailman id 248832;
 Fri, 17 Dec 2021 19:32:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIxt-0007M8-T0
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:32:26 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f0f9589-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:32:25 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769524862112.54010405527049;
 Fri, 17 Dec 2021 11:32:04 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f0f9589-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769527; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=ljqU0Yxk3HOkGSLVjYIS2HhHILvsIGXieSamAN+iNBVQ9PVTmH6ko/dwbVmzJb9uWWixOY8DncM+cOj1W3e3Q8BrI49IAr4u7ozv0kwr81VrKhCPmqs+R6PBRJK6kLHsbqN0mH9lccbTQ9ewTLLOg3x7ueCupcTvjz1+ujXLpfo=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769527; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=/VbuytX0Q+D4LsMewdpZJiBY6pOL9LLoWZ6MNlm7AeU=; 
	b=acWHGoec9Ohbik9eZLOlMvS1ou5Gi8WYhZjPTx6gfGGSEsksx5C0HdGmXEHdBllp1SPBa1jIt4SJpFKuC+3DXswaeJeZ85Nl5BV4xDDktK7L7dDTsJ54UPxf4fTx9vsjdu9pWwaqbgwvcmF7CyEcwtl7uh0CIA5W3BEwRZ4i+A8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769527;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=/VbuytX0Q+D4LsMewdpZJiBY6pOL9LLoWZ6MNlm7AeU=;
	b=asPoXZYjr1hLb56DR0cGtZIIuASHvFviAHV2eIRSizQBKqfv6dt2v462I/kFZ/TS
	ZWPP8zdV2w3nbXHrvewYoT7HmxiD3mDxoC1J3LPuwWs6Lu125ss8+ThOK2KDdHPziNU
	ioD2dR5f7aARK0SL+M1F4z4aRVdAgRpL5BkMQoEY=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [RFC 01/10] introduce hyperlaunch kconfig and core
Date: Fri, 17 Dec 2021 18:34:27 -0500
Message-Id: <20211217233437.13791-2-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

From: Christopher Clark <christopher.w.clark@gmail.com>

Add a CONFIG_HYPERLAUNCH to allow enabling/disabling the hyperlaunch code
paths. Introduce an initial use of the hyperlaunch_enabled variable to suppress
the warning about multiple initrd candidates when multiboot modules are
detected when the hyperlaunch boolean is true.

Added to common code since this option will apply to all architectures.

Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/x86/setup.c    |  4 +++-
 xen/common/Kconfig      | 10 ++++++++++
 xen/common/Makefile     |  1 +
 xen/common/setup.c      |  8 ++++++++
 xen/include/xen/setup.h | 14 ++++++++++++++
 5 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 xen/common/setup.c
 create mode 100644 xen/include/xen/setup.h

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f40a9fe5d3..190d7aefb5 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -26,6 +26,7 @@
 #include <xen/nodemask.h>
 #include <xen/virtual_region.h>
 #include <xen/watchdog.h>
+#include <xen/setup.h>
 #include <public/version.h>
 #ifdef CONFIG_COMPAT
 #include <compat/platform.h>
@@ -1891,7 +1892,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
            cpu_has_nx ? "" : "not ");
 
     initrdidx = find_first_bit(module_map, mbi->mods_count);
-    if ( bitmap_weight(module_map, mbi->mods_count) > 1 )
+    if ( !hyperlaunch_enabled &&
+         bitmap_weight(module_map, mbi->mods_count) > 1 )
         printk(XENLOG_WARNING
                "Multiple initrd candidates, picking module #%u\n",
                initrdidx);
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index db687b1785..5e6aad644e 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -331,6 +331,16 @@ config ARGO
 
 	  If unsure, say N.
 
+config HYPERLAUNCH
+	bool "Hyperlaunch support (UNSUPPORTED)" if UNSUPPORTED
+	---help---
+	  Enables launch of multiple VMs at host boot as an alternative
+	  method of starting a Xen system.
+
+	  This feature is currently experimental.
+
+	  If unsure, say N.
+
 source "common/sched/Kconfig"
 
 config CRYPTO
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 141d7d40d3..a6337e065a 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -35,6 +35,7 @@ obj-y += rangeset.o
 obj-y += radix-tree.o
 obj-y += rcupdate.o
 obj-y += rwlock.o
+obj-y += setup.o
 obj-y += shutdown.o
 obj-y += softirq.o
 obj-y += smp.o
diff --git a/xen/common/setup.c b/xen/common/setup.c
new file mode 100644
index 0000000000..e18ea14fe0
--- /dev/null
+++ b/xen/common/setup.c
@@ -0,0 +1,8 @@
+#include <xen/types.h>
+#include <xen/init.h>
+
+#ifdef CONFIG_HYPERLAUNCH
+
+bool __initdata hyperlaunch_enabled;
+
+#endif
diff --git a/xen/include/xen/setup.h b/xen/include/xen/setup.h
new file mode 100644
index 0000000000..6fbe87860e
--- /dev/null
+++ b/xen/include/xen/setup.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef XEN_SETUP_H
+#define XEN_SETUP_H
+
+#include <asm/setup.h>
+
+#ifdef CONFIG_HYPERLAUNCH
+extern bool hyperlaunch_enabled;
+#else
+#define hyperlaunch_enabled false
+#endif
+
+#endif /* XEN_SETUP_H */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:33:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:33:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248838.429232 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyE-0008NS-FW; Fri, 17 Dec 2021 19:32:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248838.429232; Fri, 17 Dec 2021 19:32:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyE-0008NI-Bz; Fri, 17 Dec 2021 19:32:46 +0000
Received: by outflank-mailman (input) for mailman id 248838;
 Fri, 17 Dec 2021 19:32:46 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIyD-0007M8-SX
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:32:45 +0000
Received: from sender3-of-o52.zoho.com (sender3-of-o52.zoho.com
 [136.143.184.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1afcfdc4-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:32:44 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769526620437.16843681891885;
 Fri, 17 Dec 2021 11:32:06 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1afcfdc4-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769529; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=Bo7rv4wId/5VhflcAuS0iCH2o0c3/9MGoimLxmZKC41fY6+GNf31ArfsQuIkOu3SuV4Zo+eZXoFI8a9yKMAoehdKq239GDtVKz2kCZPgBhjZJ/8G8+pmm0X+h2lbUuZsy8yqH7clwVDYB969ZVzsQCanur7+vJaX81Wo7smmg88=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769529; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=5e0WDt0b0QAR/Q3VrnOoU5NuGPw9wyZBF+wd2t/YYDo=; 
	b=UIYLiIm3BrxcIojqPMcvhZ/DtO7qpVs84maSSpKBsHu4ON9OMwbUVX6mR1vO4yITL1ej/LJ/TKLzfvpMliBkrH8e/n5fW9SmfkLo+s3hAp8a4RH6t8v7LfqobWoUYBdrKPwV95XnhbfyYVCCgl9AaSGw8Kh+2vE1ZnsC5R1EcN0=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769529;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=5e0WDt0b0QAR/Q3VrnOoU5NuGPw9wyZBF+wd2t/YYDo=;
	b=kX0pUUiV6zJydj03YUKM73B8KyuPotHqDosj6sBAE8dh1DUc+Y1F9kjojmKlvLsF
	icdmqNyYo+EYHHlAueXw+Ivhckxh1Er1WxaO5zSqeVN9r5MSygS0iHcHPRtR6qZvKXn
	+wZpEqT5zQuj2hwjNJZ1CtmSrrzdRr6BV28BwqLw=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: [RFC 02/10] is_system_domain: replace open-coded instances
Date: Fri, 17 Dec 2021 18:34:28 -0500
Message-Id: <20211217233437.13791-3-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

From: Christopher Clark <christopher.w.clark@gmail.com>

There were several instances of open-coded domid range checking. This commit
replaces those with the is_system_domain inline function.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/x86/cpu/vpmu.c | 2 +-
 xen/common/domctl.c     | 2 +-
 xen/common/sched/core.c | 4 ++--
 xen/include/xen/sched.h | 5 +++++
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bed..179f3dcc5a 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
      * in XENPMU_MODE_ALL, for everyone.
      */
     if ( (vpmu_mode & XENPMU_MODE_ALL) ||
-         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
+         (is_system_domain(sampled->domain)) )
     {
         sampling = choose_hwdom_vcpu();
         if ( !sampling )
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 879a2adcbe..67021cc54b 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -536,7 +536,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( !d )
         {
             ret = -EINVAL;
-            if ( op->domain >= DOMID_FIRST_RESERVED )
+            if ( is_system_domain_id(op->domain) )
                 break;
 
             rcu_read_lock(&domlist_read_lock);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..6ea8bcf62f 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -821,7 +821,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
     int ret;
 
     ASSERT(d->cpupool == NULL);
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( (ret = cpupool_add_domain(d, poolid)) )
         return ret;
@@ -845,7 +845,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
 
 void sched_destroy_domain(struct domain *d)
 {
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( d->cpupool )
     {
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 28146ee404..1df09bcb77 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -613,6 +613,11 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
 #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
 #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
 
+static inline bool is_system_domain_id(domid_t id)
+{
+    return (id >= DOMID_FIRST_RESERVED);
+}
+
 static inline bool is_system_domain(const struct domain *d)
 {
     return d->domain_id >= DOMID_FIRST_RESERVED;
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:33:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:33:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248839.429243 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyQ-0000Mx-OC; Fri, 17 Dec 2021 19:32:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248839.429243; Fri, 17 Dec 2021 19:32:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyQ-0000Mq-Kh; Fri, 17 Dec 2021 19:32:58 +0000
Received: by outflank-mailman (input) for mailman id 248839;
 Fri, 17 Dec 2021 19:32:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIyP-0007M8-ET
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:32:57 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 218b60b9-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:32:56 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769528258456.9306457825601;
 Fri, 17 Dec 2021 11:32:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 218b60b9-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769530; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=I6IAsMH+jipuMqQCj76mdQ7T9EyWFmW64zRMD1bJXD7ClPf7PcMXJZ9QGGzZaAadxhBVhcFjcvTiogX2AfkRuESNdmj6y6aH7g2v2ZgvsbtEuJ1hVU3UxUjLU0x5pwlzpSlM8zPq1BZUjhYmhPFPjEwSesElfzwFvywscOSWzL0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769530; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=g9oPwlQgKMT2hXPARb/PayeIcKtxhGTeD4xffzn8NTM=; 
	b=hQ1/+LhqdE9UaRKlKfiz7YCM+E0fa6PSB4/dDcWWebRhbXW5Nxw9iQHq65Zwh6gt70WQisAhSZwFr6Q91bOxe/ga50Gmk1vMdwXO/So8yf5Ef28X11udIxdutVmdxAMoqSu+5VrCvtJ0Vk/P7F9cfsvWp55kq/pBNXR+rUHbKxw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769530;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=g9oPwlQgKMT2hXPARb/PayeIcKtxhGTeD4xffzn8NTM=;
	b=Khcyh8d1Ra5MFSxWdiC+y3TVEtTDzTTg71udOgNLXTO2ntt5u2DeyIJnoPyQK63/
	uo58/IngQ158gWI7eUfLhCtf2+y6ChkQHnjnfmCK9rhIhc9guXD9kt47q2kntshBaPp
	mOhFXF5YzkxX4xi4+NSQZ8BxoxN6b4tlpVVZBtgo=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [RFC 03/10] multiboot: moving headroom to per module_t
Date: Fri, 17 Dec 2021 18:34:29 -0500
Message-Id: <20211217233437.13791-4-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

Hyperlaunch will require multiple modules to be allocated headroom. Therefore a
headroom variable has been added to module_t for tracking headroom on a per
module_t basis. To provide backwards compatibility with multiboot, the
reserved field was bitfield split to allow it to continue to be used to flag
module was relocated and to add to track the headroom needed when being
relocated.

RFC Note: The approach taken here was to produce something that was acceptable
but likely not the ultimate solution. A more complete solution would likely be
one that looked to unify a cross-architecture approach to represent the
material provided by bootloaders.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/arch/x86/boot/reloc.c   |  1 +
 xen/arch/x86/setup.c        | 17 ++++++++---------
 xen/include/xen/multiboot.h |  3 ++-
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
index 4f4039bb7c..9c68777db3 100644
--- a/xen/arch/x86/boot/reloc.c
+++ b/xen/arch/x86/boot/reloc.c
@@ -250,6 +250,7 @@ static multiboot_info_t *mbi2_reloc(u32 mbi_in)
             mbi_out_mods[mod_idx].mod_end = get_mb2_data(tag, module, mod_end);
             ptr = get_mb2_string(tag, module, cmdline);
             mbi_out_mods[mod_idx].string = copy_string(ptr);
+            mbi_out_mods[mod_idx].headroom = 0;
             mbi_out_mods[mod_idx].reserved = 0;
             ++mod_idx;
             break;
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 190d7aefb5..4bf84c17e4 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -855,7 +855,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
     unsigned int initrdidx, num_parked = 0;
     multiboot_info_t *mbi;
     module_t *mod;
-    unsigned long nr_pages, raw_max_page, modules_headroom, module_map[1];
+    unsigned long nr_pages, raw_max_page, module_map[1];
     int i, j, e820_warn = 0, bytes = 0;
     unsigned long eb_start, eb_end;
     bool acpi_boot_table_init_done = false, relocated = false;
@@ -1158,7 +1158,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
         mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext;
     }
 
-    modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end);
+    mod->headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end);
     bootstrap_map(NULL);
 
 #ifndef highmem_start
@@ -1321,8 +1321,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
         /* Is the region suitable for relocating the multiboot modules? */
         for ( j = mbi->mods_count - 1; j >= 0; j-- )
         {
-            unsigned long headroom = j ? 0 : modules_headroom;
-            unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end);
+            unsigned long size = PAGE_ALIGN(mod[j].headroom + mod[j].mod_end);
 
             if ( mod[j].reserved )
                 continue;
@@ -1335,14 +1334,14 @@ void __init noreturn __start_xen(unsigned long mbi_p)
                 continue;
 
             if ( s < end &&
-                 (headroom ||
+                 (mod[j].headroom ||
                   ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) )
             {
-                move_memory(end - size + headroom,
+                move_memory(end - size + mod[j].headroom,
                             (uint64_t)mod[j].mod_start << PAGE_SHIFT,
                             mod[j].mod_end, 0);
                 mod[j].mod_start = (end - size) >> PAGE_SHIFT;
-                mod[j].mod_end += headroom;
+                mod[j].mod_end += mod[j].headroom;
                 mod[j].reserved = 1;
             }
         }
@@ -1369,7 +1368,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
 #endif
     }
 
-    if ( modules_headroom && !mod->reserved )
+    if ( mod->headroom && !mod->reserved )
         panic("Not enough memory to relocate the dom0 kernel image\n");
     for ( i = 0; i < mbi->mods_count; ++i )
     {
@@ -1902,7 +1901,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
      * We're going to setup domain0 using the module(s) that we stashed safely
      * above our heap. The second module, if present, is an initrd ramdisk.
      */
-    dom0 = create_dom0(mod, modules_headroom,
+    dom0 = create_dom0(mod, mod->headroom,
                        initrdidx < mbi->mods_count ? mod + initrdidx : NULL,
                        kextra, loader);
     if ( !dom0 )
diff --git a/xen/include/xen/multiboot.h b/xen/include/xen/multiboot.h
index d1b43e1183..0ae37dfa2b 100644
--- a/xen/include/xen/multiboot.h
+++ b/xen/include/xen/multiboot.h
@@ -108,7 +108,8 @@ typedef struct {
     u32 mod_start;
     u32 mod_end;
     u32 string;
-    u32 reserved;
+    u32 reserved:1;
+    u32 headroom:31;
 } module_t;
 
 /* The memory map. Be careful that the offset 0 is base_addr_low
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:33:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:33:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248845.429253 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyd-0000wA-VW; Fri, 17 Dec 2021 19:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248845.429253; Fri, 17 Dec 2021 19:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIyd-0000vd-SW; Fri, 17 Dec 2021 19:33:11 +0000
Received: by outflank-mailman (input) for mailman id 248845;
 Fri, 17 Dec 2021 19:33:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIyc-0007M8-JW
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:33:10 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 29af6198-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:33:09 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769529700190.38888754714014;
 Fri, 17 Dec 2021 11:32:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29af6198-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769531; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=FtIm41ruqTOp600k8iYbUBpQv3WAX7IwUdUHTw7zP4Z0Zwww4S0m8CW6zUfCts269WM9CieFWRUQVe3faX4y4abhxKuTRBXvqpjK9P7nEabSfs3lDZFLc4xzFCdPWwumDGXJSRIyhJIgCTR6BVOazSZZtj4OQnBca3fJIbyEhOI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769531; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=UFJoq4z4heOloPDSzW6Y95pMjws+Z0IPoCLVo0DLBwc=; 
	b=TknipIJcJuInWq7Qo2q68MJViEys3ao5EbmBT6NiLaUK0O4p4uVbVDdqlPLucI2CaUPc+lZLmzafA8lXZz1xh655dwNMe5TWhDnaomqJV9GXWL8UBYyGx9CHMjWMxjNGDejz0eNi+hTpmXXMbedTfLDkTPgSJjl2Ly5jU2l0C9U=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769531;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=UFJoq4z4heOloPDSzW6Y95pMjws+Z0IPoCLVo0DLBwc=;
	b=AfK9C+bK4+ZpY4RCIV0wq23hN8eXzLZLpn3LTPAcd5/vOsKyJ/knuJh6yOYfKNtt
	gnm/Bb1RFzSVY6PwuUKaFQGukqaLbXUrpGM09GOBxYUjq1XQFDsc7f5Paa5+Phtgul5
	HZPG8poVOpgUNE1ZWCINdpIeFTO6KtNUChS1a5v4=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC 04/10] device-tree: split agnostic device-tree from arm
Date: Fri, 17 Dec 2021 18:34:30 -0500
Message-Id: <20211217233437.13791-5-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit is purely for RFC to highlight some concerns and changes necessary
in order for hyperlaunch to utilize device tree as the boot configuration
container.

Despite being in common, the core device tree support enabled through
CONFIG_HAS_DEVICE_TREE will not build for an x86 configuration. This is due to
the fact that despite `struct device` appearing to be intended as a common data
structure is in fact unique on x86 and Arm. There is code in
xen/common/device_tree.c and include/xen/iommu.h that uses struct members found
in Arm's `struct device` that are not present in x86's version. This obviously
ends in compilation errors when enabling CONFIG_HAS_DEVICE_TREE on x86.

As a result this commit seeks to separate between requiring the ability to
parse DTB files and obtaining hardware definition from those DTB files. The
Kconfig parameter CORE_DEVICE_TREE was introduced for when only the former is
necessary and not the latter. It specifically allows for the inclusion of the
device tree parsing code without enabling the areas that make use of Arm
specific `struct device`.

For the RFC when the Arm specific `struct device` is referenced within device
tree parsing code, check for Arm has been added as an interim solution until a
long term solution, that is beyond the scope of the hyperlaunch patch set, can
be proposed and implemented.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/common/Kconfig            | 5 +++++
 xen/common/Makefile           | 4 ++--
 xen/common/device_tree.c      | 2 ++
 xen/include/xen/device_tree.h | 4 ++++
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 5e6aad644e..aece21c9e5 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -31,8 +31,12 @@ config HAS_ALTERNATIVE
 config HAS_COMPAT
 	bool
 
+config CORE_DEVICE_TREE
+	bool
+
 config HAS_DEVICE_TREE
 	bool
+	select CORE_DEVICE_TREE
 
 config HAS_EX_TABLE
 	bool
@@ -333,6 +337,7 @@ config ARGO
 
 config HYPERLAUNCH
 	bool "Hyperlaunch support (UNSUPPORTED)" if UNSUPPORTED
+	select CORE_DEVICE_TREE
 	---help---
 	  Enables launch of multiple VMs at host boot as an alternative
 	  method of starting a Xen system.
diff --git a/xen/common/Makefile b/xen/common/Makefile
index a6337e065a..f22aec72a0 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -4,7 +4,7 @@ obj-$(CONFIG_HYPFS_CONFIG) += config_data.o
 obj-$(CONFIG_CORE_PARKING) += core_parking.o
 obj-y += cpu.o
 obj-$(CONFIG_DEBUG_TRACE) += debugtrace.o
-obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o
+obj-$(CONFIG_CORE_DEVICE_TREE) += device_tree.o
 obj-$(CONFIG_IOREQ_SERVER) += dm.o
 obj-y += domain.o
 obj-y += event_2l.o
@@ -73,7 +73,7 @@ obj-y += sched/
 obj-$(CONFIG_UBSAN) += ubsan/
 
 obj-$(CONFIG_NEEDS_LIBELF) += libelf/
-obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/
+obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/
 
 CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(BASEDIR)/)$(KCONFIG_CONFIG)
 config.gz: $(CONF_FILE)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 4aae281e89..d92fad2998 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -2012,9 +2012,11 @@ static unsigned long __init unflatten_dt_node(const void *fdt,
             ((char *)pp->value)[sz - 1] = 0;
             dt_dprintk("fixed up name for %s -> %s\n", pathp,
                        (char *)pp->value);
+#ifdef CONFIG_ARM
             /* Generic device initialization */
             np->dev.type = DEV_DT;
             np->dev.of_node = np;
+#endif
         }
     }
     if ( allnextpp )
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index fd6cd00b43..ca9f7672e9 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -101,9 +101,12 @@ struct dt_device_node {
      */
     struct list_head domain_list;
 
+#ifdef CONFIG_ARM
     struct device dev;
+#endif
 };
 
+#ifdef CONFIG_ARM
 #define dt_to_dev(dt_node)  (&(dt_node)->dev)
 
 static inline struct dt_device_node *dev_to_dt(struct device *dev)
@@ -112,6 +115,7 @@ static inline struct dt_device_node *dev_to_dt(struct device *dev)
 
     return container_of(dev, struct dt_device_node, dev);
 }
+#endif
 
 #define MAX_PHANDLE_ARGS 16
 struct dt_phandle_args {
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:33:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:33:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248849.429265 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIys-0001XN-8E; Fri, 17 Dec 2021 19:33:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248849.429265; Fri, 17 Dec 2021 19:33:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIys-0001XG-4O; Fri, 17 Dec 2021 19:33:26 +0000
Received: by outflank-mailman (input) for mailman id 248849;
 Fri, 17 Dec 2021 19:33:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIyq-0008Bq-GY
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:33:24 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 312618c5-5f70-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:33:22 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769531248290.15386002298237;
 Fri, 17 Dec 2021 11:32:11 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 312618c5-5f70-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1639769533; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=S1WP2VhZWvhzFP6tk+Q1Z5DrHfDScNEbww9/HIlXTa5CjAeb6PNtM4J+00V0ci7PqedGQMgvIV/+YqNB5otjQ7kzQMvJ0TzPDfr2rVFVirsjirjjd/37j2f1xDE+805Rr16YHxtr8u4X69Z6sJYBaAWrL1Fb+anCP/E7q3+TJ3Y=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769533; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=dgVuUxEl8OumX6DLPxWMvtc2xvBs3iAgOedwV7CzitI=; 
	b=bcnGg3v25vmjbRwpoBU1bBaNh/G5WUtdbl875fx43lAfjx1o1qYGDHf+TPQgM0CkKXaeUcKpRXQr7nWh1wJCgd7Wf/SLcuSpqimrBfBhNROO3Dl+w/mOooSy2l0XkyBaRMHa0mLiznVuTvPXnsI8SuJ5YYhy+8QGQCrLqI38JPI=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769533;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding;
	bh=dgVuUxEl8OumX6DLPxWMvtc2xvBs3iAgOedwV7CzitI=;
	b=TBb79mk266UzrVZPm2hGWQiyNemQDWE9QLbBiLcbbXO4UY2VfHHSd9kUak/tI6ED
	A+1vNL7D1lu2Z68eqvSjZBqLilOuATlWuNtF+wItR4fnItpCtmN5DnYZuDZA/E8RLEC
	vjOOxLPEfecmnKNedRuOhhpi8+uvUy1HzFRmbEtc=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC 05/10] hyperlaunch: update device tree documentation
Date: Fri, 17 Dec 2021 18:34:31 -0500
Message-Id: <20211217233437.13791-6-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit is to update the hyperlaunch device tree documentation to align
with the DTB parsing implementation.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 .../designs/launch/hyperlaunch-devicetree.rst | 448 +++++++++++-------
 1 file changed, 278 insertions(+), 170 deletions(-)

diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst
index b49c98cfbd..7be23b9e71 100644
--- a/docs/designs/launch/hyperlaunch-devicetree.rst
+++ b/docs/designs/launch/hyperlaunch-devicetree.rst
@@ -13,12 +13,263 @@ difference is the introduction of the ``hypervisor`` node that is under the
 2. Allows for the domain construction information to easily be sanitized by
    simple removing the ``/chosen/hypervisor`` node.
 
+
+The Hypervisor node
+-------------------
+
+The ``hypervisor`` node is a top level container for the domains that will be built
+by hypervisor on start up. The node will be named ``hypervisor``  with a ``compatible``
+property to identify which hypervisors the configuration is intended. The hypervisor
+node will consist of one or more config nodes and one or more domain nodes.
+
+Properties
+""""""""""
+
+compatible
+  Identifies which hypervisors the configuration is compatible. Required.
+
+  Format: "hypervisor,<hypervisor name>", e.g "hypervisor,xen"
+
+Child Nodes
+"""""""""""
+
+* config
+* domain
+
+Config Node
+-----------
+
+A ``config`` node is for passing configuration data and identifying any boot
+modules that is of interest to the hypervisor.  For example this would be where
+Xen would be informed of microcode or XSM policy locations. Each ``config``
+node will require a unique device-tree compliant name as there may be one or
+more ``config`` nodes present in a single dtb file. To identify which
+hypervisor the configuration is intended, the required ``compatible`` property
+must be present.
+
+While the config node is not meant to replace the hypervisor commandline, there
+may be cases where it is better suited for passing configuration details at
+boot time.  This additional information may be carried in properties assigned
+to a ``config`` node. If there are any boot modules that are intended for the
+hypervisor, then a ``module`` child node should be provided to identify the
+boot module.
+
+Properties
+""""""""""
+
+compatible
+  Identifies the hypervisor the confiugration is intended. Required.
+
+  Format: "<hypervisor name>,config", e.g "xen,config"
+
+Child Nodes
+"""""""""""
+
+* module
+
+Domain Node
+-----------
+
+A ``domain`` node is for describing the construction of a domain. Since there
+may be one or more domain nodes, each one requires a unique, DTB compliant name
+and a ``compatible`` property to identify as a domain node.
+
+A ``domain`` node  may provide a ``domid`` property which will be used as the
+requested domain id for the domain with a value of “0” signifying to use the
+next available domain id, which is the default behavior if omitted. It should
+be noted that a domain configuration is not able to request a domid of “0”.
+Beyond that a domain node may have any of the following optional properties.
+
+Properties
+""""""""""
+
+compatible
+  Identifies the node as a domain node and for which hypervisor. Required.
+
+  Format: "<hypervisor name>,domain", e.g "xen,domain"
+
+domid
+  Identifies the domid requested to assign to the domain.
+
+  Format: Integer, e.g <0>
+
+permissions
+  This sets what Discretionary Access Control permissions
+  a domain is assigned. Optional, default is none.
+
+  Format: Bitfield, e.g <3> or <0x00000003>
+
+          PERMISSION_NONE          (0)
+          PERMISSION_CONTROL       (1 << 0)
+          PERMISSION_HARDWARE      (1 << 1)
+
+functions
+  This identifies what system functions a domain will fulfill.
+  Optional, the default is none.
+
+  Format: Bitfield, e.g <3221225487> or <0xC0000007>
+
+          FUNCTION_NONE            (0)
+          FUNCTION_BOOT            (1 << 0)
+          FUNCTION_CRASH           (1 << 1)
+          FUNCTION_CONSOLE         (1 << 2)
+          FUNCTION_XENSTORE        (1 << 30)
+          FUNCTION_LEGACY_DOM0     (1 << 31)
+
+.. note::  The `functions` bits that have been selected to indicate
+   ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits
+   (30, 31) such that should these features ever be fully replaced or retired,
+   the flags may be dropped without leaving a gap in the flag set.
+
+mode
+  The mode the domain will be executed under. Required.
+
+  Format: Bitfield, e.g <5> or <0x00000005>
+
+          MODE_PARAVIRTUALIZED     (1 << 0) PV | PVH/HVM
+          MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH
+          MODE_LONG                (1 << 2) 64 BIT | 32 BIT
+
+domain-uuid
+  A globally unique identifier for the domain. Optional,
+  the default is NULL.
+
+  Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3]
+
+cpus
+  The number of vCPUs to be assigned to the domain. Optional,
+  the default is “1”.
+
+  Format: Integer, e.g <0>
+
+memory
+  The amount of memory to assign to the domain, in KBs. This field uses a DTB
+  Reg which contains a start and size. For memory allocation start may or may
+  not have significance but size will always be used for the amount of memory
+  Required.
+
+  Format: DTB Reg <min:start size>, [<max: start size>], e.g. <0x0 0x20000>
+
+security-id
+  The security identity to be assigned to the domain when XSM
+  is the access control mechanism being used. Optional,
+  the default is “system_u:system_r:domU_t”.
+
+  Format: string, e.g. "system_u:system_r:domU_t"
+
+Child Nodes
+"""""""""""
+
+* module
+
+Module node
+-----------
+
+This node describes a boot module loaded by the boot loader. A ``module`` node
+will often appear repeatedly and will require a unique and DTB compliant name
+for each instance. The compatible property is required to identify that the
+node is a ``module`` node, the type of boot module, and what it represents.
+
+Depending on the type of boot module, the ``module`` node will require either a
+``mb-index`` or ``module-addr`` property must be present. They provide the boot
+module specific way of locating the boot module in memory.
+
+Properties
+""""""""""
+
+compatible
+  This identifies what the module is and thus what the hypervisor
+  should use the module for during domain construction. Required.
+
+  Format: "module,<module type>"[, "<boot module type>,module"]
+          module type: kernel, ramdisk, device-tree, microcode, xsm-policy,
+                       config
+
+          boot module type: multiboot
+
+mb-index
+  This identifies the index for this module in the multiboot module chain.
+  Required for multiboot environments.
+
+  Format: Integer, e.g. <0>
+
+module-addr
+  This identifies where in memory this module is located. Required for
+  non-multiboot environments.
+
+  Format: DTB Reg <start size>, e.g. <0x0 0x20000>
+
+bootargs
+  This is used to provide the boot params to kernel modules.
+
+  Format: String, e.g. "ro quiet"
+
+.. note::  The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain.
+
 Example Configuration
 ---------------------
 
-Below are two example device tree definitions for the hypervisor node. The
-first is an example of a multiboot-based configuration for x86 and the second
-is a module-based configuration for Arm.
+Below are examples device tree definitions for the hypervisor node. The first
+is an example of booting a dom0 only configuration. Afterh that are a
+multiboot-based configuration for x86 and a module-based configuration for Arm.
+
+Multiboot x86 Configuration Dom0-only:
+""""""""""""""""""""""""""""""""""""""
+The following dts file can be provided to the Device Tree compiler, ``dtc``, to
+produce a dtb file. 
+::
+
+  /dts-v1/;
+
+  / {
+      chosen {
+          hypervisor {
+              compatible = "hypervisor,xen";
+
+              dom0 {
+                  compatible = "xen,domain";
+
+                  domid = <0>;
+
+                  permissions = <3>;
+                  functions = <0xC000000F>;
+                  mode = <5>;
+
+                  domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 13 F0 8C];                                               
+
+                  cpus = <1>;
+                  memory = <0x0 0x20000000>;
+
+                  kernel {
+                      compatible = "module,kernel", "multiboot,module";
+                      mb-index = <1>;
+                  };
+              };
+
+          };
+      };
+  };
+
+The resulting dtb file, in this case dom0-only.dtb, can then be used with a
+GRUB menuentry as such,
+::
+
+  menuentry 'Devuan GNU/Linux, with Xen hyperlaunch' {
+        insmod part_gpt
+        insmod ext2
+        set root='hd0,gpt2'
+
+        echo    'Loading Xen hyperlaunch ...'
+
+        multiboot2      /xen.gz placeholder sync_console
+        echo    'Loading Dom0 hyperlaunch dtb ...'
+        module2 --nounzip   /dom0-only.dtb
+        echo    'Loading Linux 5.4.36+ ...'
+        module2 /vmlinuz-5.4.36+ placeholder root=/dev/mapper/test01--vg-root ro  quiet
+        echo    'Loading initial ramdisk ...'
+        module2 --nounzip   /initrd.img-5.4.36+
+  }
+
 
 Multiboot x86 Configuration:
 """"""""""""""""""""""""""""
@@ -31,87 +282,66 @@ Multiboot x86 Configuration:
         compatible = “hypervisor,xen”
 
         // Configuration container
-        config {
+        xen-config {
             compatible = "xen,config";
 
-            module {
+            microcode {
                 compatible = "module,microcode", "multiboot,module";
                 mb-index = <1>;
             };
 
-            module {
+            policy {
                 compatible = "module,xsm-policy", "multiboot,module";
                 mb-index = <2>;
             };
         };
 
         // Boot Domain definition
-        domain {
+        domB {
             compatible = "xen,domain";
 
             domid = <0x7FF5>;
 
-            // FUNCTION_NONE            (0)
-            // FUNCTION_BOOT            (1 << 0)
-            // FUNCTION_CRASH           (1 << 1)
-            // FUNCTION_CONSOLE         (1 << 2)
-            // FUNCTION_XENSTORE        (1 << 30)
-            // FUNCTION_LEGACY_DOM0     (1 << 31)
             functions = <0x00000001>;
 
             memory = <0x0 0x20000>;
             cpus = <1>;
-            module {
+
+            kernel {
                 compatible = "module,kernel", "multiboot,module";
                 mb-index = <3>;
             };
-
-            module {
+            initrd {
                 compatible = "module,ramdisk", "multiboot,module";
                 mb-index = <4>;
             };
-            module {
+            dom-config {
                 compatible = "module,config", "multiboot,module";
                 mb-index = <5>;
             };
 
         // Classic Dom0 definition
-        domain {
+        dom0 {
             compatible = "xen,domain";
 
             domid = <0>;
 
-            // PERMISSION_NONE          (0)
-            // PERMISSION_CONTROL       (1 << 0)
-            // PERMISSION_HARDWARE      (1 << 1)
             permissions = <3>;
-
-            // FUNCTION_NONE            (0)
-            // FUNCTION_BOOT            (1 << 0)
-            // FUNCTION_CRASH           (1 << 1)
-            // FUNCTION_CONSOLE         (1 << 2)
-            // FUNCTION_XENSTORE        (1 << 30)
-            // FUNCTION_LEGACY_DOM0     (1 << 31)
             functions = <0xC0000006>;
-
-            // MODE_PARAVIRTUALIZED     (1 << 0) /* PV | PVH/HVM */
-            // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */
-            // MODE_LONG                (1 << 2) /* 64 BIT | 32 BIT */
             mode = <5>; /* 64 BIT, PV */
 
-            // UUID
             domain-uuid = [B3 FB 98 FB 8F 9F 67 A3];
 
             cpus = <1>;
             memory = <0x0 0x20000>;
-            security-id = “dom0_t;
+            security-id = “system_u:system_r:dom0_t;
 
-            module {
+            kernel {
                 compatible = "module,kernel", "multiboot,module";
                 mb-index = <6>;
                 bootargs = "console=hvc0";
             };
-            module {
+            initrd {
                 compatible = "module,ramdisk", "multiboot,module";
                 mb-index = <7>;
             };
@@ -137,15 +367,15 @@ Module Arm Configuration:
         compatible = “hypervisor,xen”
 
         // Configuration container
-        config {
+        xen-config {
             compatible = "xen,config";
 
-            module {
+            microcode {
                 compatible = "module,microcode”;
                 module-addr = <0x0000ff00 0x80>;
             };
 
-            module {
+            policy {
                 compatible = "module,xsm-policy";
                 module-addr = <0x0000ff00 0x80>;
 
@@ -153,72 +383,51 @@ Module Arm Configuration:
         };
 
         // Boot Domain definition
-        domain {
+        domB {
             compatible = "xen,domain";
 
             domid = <0x7FF5>;
 
-            // FUNCTION_NONE            (0)
-            // FUNCTION_BOOT            (1 << 0)
-            // FUNCTION_CRASH           (1 << 1)
-            // FUNCTION_CONSOLE         (1 << 2)
-            // FUNCTION_XENSTORE        (1 << 30)
-            // FUNCTION_LEGACY_DOM0     (1 << 31)
             functions = <0x00000001>;
 
             memory = <0x0 0x20000>;
             cpus = <1>;
-            module {
+
+            kernel {
                 compatible = "module,kernel";
                 module-addr = <0x0000ff00 0x80>;
             };
-
-            module {
+            initrd {
                 compatible = "module,ramdisk";
                 module-addr = <0x0000ff00 0x80>;
             };
-            module {
+            dom-config {
                 compatible = "module,config";
                 module-addr = <0x0000ff00 0x80>;
             };
 
         // Classic Dom0 definition
-        domain@0 {
+        dom0 {
             compatible = "xen,domain";
 
             domid = <0>;
 
-            // PERMISSION_NONE          (0)
-            // PERMISSION_CONTROL       (1 << 0)
-            // PERMISSION_HARDWARE      (1 << 1)
             permissions = <3>;
-
-            // FUNCTION_NONE            (0)
-            // FUNCTION_BOOT            (1 << 0)
-            // FUNCTION_CRASH           (1 << 1)
-            // FUNCTION_CONSOLE         (1 << 2)
-            // FUNCTION_XENSTORE        (1 << 30)
-            // FUNCTION_LEGACY_DOM0     (1 << 31)
             functions = <0xC0000006>;
-
-            // MODE_PARAVIRTUALIZED     (1 << 0) /* PV | PVH/HVM */
-            // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */
-            // MODE_LONG                (1 << 2) /* 64 BIT | 32 BIT */
             mode = <5>; /* 64 BIT, PV */
 
-            // UUID
             domain-uuid = [B3 FB 98 FB 8F 9F 67 A3];
 
             cpus = <1>;
             memory = <0x0 0x20000>;
-            security-id = “dom0_t”;
+            security-id = “system_u:system_r:dom0_t”;
 
-            module {
+            kernel {
                 compatible = "module,kernel";
                 module-addr = <0x0000ff00 0x80>;
                 bootargs = "console=hvc0";
             };
-            module {
+            intird {
                 compatible = "module,ramdisk";
                 module-addr = <0x0000ff00 0x80>;
             };
@@ -240,104 +449,3 @@ provided to Xen using the standard method currently in use. The remaining
 modules would need to be loaded in the respective addresses specified in the
 `module-addr` property.
 
-
-The Hypervisor node
--------------------
-
-The hypervisor node is a top level container for the domains that will be built
-by hypervisor on start up. On the ``hypervisor`` node the ``compatible``
-property is used to identify the type of hypervisor node present..
-
-compatible
-  Identifies the type of node. Required.
-
-The Config node
----------------
-
-A config node is for detailing any modules that are of interest to Xen itself.
-For example this would be where Xen would be informed of microcode or XSM
-policy locations. If the modules are multiboot modules and are able to be
-located by index within the module chain, the ``mb-index`` property should be
-used to specify the index in the multiboot module chain.. If the module will be
-located by physical memory address, then the ``module-addr`` property should be
-used to identify the location and size of the module.
-
-compatible
-  Identifies the type of node. Required.
-
-The Domain node
----------------
-
-A domain node is for describing the construction of a domain. It may provide a
-domid property which will be used as the requested domain id for the domain
-with a value of “0” signifying to use the next available domain id, which is
-the default behavior if omitted. A domain configuration is not able to request
-a domid of “0”. After that a domain node may have any of the following
-parameters,
-
-compatible
-  Identifies the type of node. Required.
-
-domid
-  Identifies the domid requested to assign to the domain. Required.
-
-permissions
-  This sets what Discretionary Access Control permissions
-  a domain is assigned. Optional, default is none.
-
-functions
-  This identifies what system functions a domain will fulfill.
-  Optional, the default is none.
-
-.. note::  The `functions` bits that have been selected to indicate
-   ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits
-   (30, 31) such that should these features ever be fully retired, the flags may
-   be dropped without leaving a gap in the flag set.
-
-mode
-  The mode the domain will be executed under. Required.
-
-domain-uuid
-  A globally unique identifier for the domain. Optional,
-  the default is NULL.
-
-cpus
-  The number of vCPUs to be assigned to the domain. Optional,
-  the default is “1”.
-
-memory
-  The amount of memory to assign to the domain, in KBs.
-  Required.
-
-security-id
-  The security identity to be assigned to the domain when XSM
-  is the access control mechanism being used. Optional,
-  the default is “domu_t”.
-
-The Module node
----------------
-
-This node describes a boot module loaded by the boot loader. The required
-compatible property follows the format: module,<type> where type can be
-“kernel”, “ramdisk”, “device-tree”, “microcode”, “xsm-policy” or “config”. In
-the case the module is a multiboot module, the additional property string
-“multiboot,module” may be present. One of two properties is required and
-identifies how to locate the module. They are the mb-index, used for multiboot
-modules, and the module-addr for memory address based location.
-
-compatible
-  This identifies what the module is and thus what the hypervisor
-  should use the module for during domain construction. Required.
-
-mb-index
-  This identifies the index for this module in the multiboot module chain.
-  Required for multiboot environments.
-
-module-addr
-  This identifies where in memory this module is located. Required for
-  non-multiboot environments.
-
-bootargs
-  This is used to provide the boot params to kernel modules.
-
-.. note::  The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain.
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:33:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:33:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248853.429276 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIz5-00026N-Ly; Fri, 17 Dec 2021 19:33:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248853.429276; Fri, 17 Dec 2021 19:33:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIz5-00026C-IS; Fri, 17 Dec 2021 19:33:39 +0000
Received: by outflank-mailman (input) for mailman id 248853;
 Fri, 17 Dec 2021 19:33:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIz4-0008Bq-Fr
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:33:38 +0000
Received: from sender3-of-o52.zoho.com (sender3-of-o52.zoho.com
 [136.143.184.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 39de5f15-5f70-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:33:37 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769532601760.2898655813524;
 Fri, 17 Dec 2021 11:32:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 39de5f15-5f70-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1639769534; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=WRGpN1segHzywaEb9+PBaysX05z/rI3teEUy1Kv24Ijdp2khAt0UzmaJiy+mD70gE2HqZs2I/sqmCFfKG+iQ0CSgOqHdYpjDVWQNlNzwYRXwpxA4qQ4ALLdls31u3BLPd/SS1eithyjL/G5nTpOGGeMkDoMZ1qM678nY8KTDdDA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769534; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=em6dzW9XaL2Yw7Hp9YltudsddXj7DesXGxfaC/g+vO8=; 
	b=IzrMpgK7REYjo70CQH9CLdKSaYFKtU9j2yk97O8eKiBr72j3Nu+oFleaHiKLYJtmky8yHYyPMISHgqEVDr3ddNxLKFNsNGmqnCoVwdWXdNQ0jw9uaC4lrBobLrW5HUSfQG//vI5isga6JMyfTH33szAxN7yQ/5ZYLO223AKNJyY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769534;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=em6dzW9XaL2Yw7Hp9YltudsddXj7DesXGxfaC/g+vO8=;
	b=VDHAS+pXWoOfkL4eBwAyLMMY4vFpQWDhabubQrg1pKDe3EYe6aABzeAhlF1bqHer
	CJDrV+KdjGlVq8y7mhuhB+tQf/X8LIB4e5M35X0IiWQ9m2PnWKWpuaPz7AGHnlrJcva
	xxgOwyGA3DhkYxwEO5z3d0HpMXti25xvauWgzE1I=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC 06/10] hyperlaunch: add structures to hold parsed dtb
Date: Fri, 17 Dec 2021 18:34:32 -0500
Message-Id: <20211217233437.13791-7-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

Hyperlaunch builds from dom0less' `struct bootmodule` as the representation of
a boot module provided by a bootloader. From there it expands to cover the
representations proposed in the hyperlaunch design documentation.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/include/xen/setup.h | 81 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 81 insertions(+)

diff --git a/xen/include/xen/setup.h b/xen/include/xen/setup.h
index 6fbe87860e..69ea042716 100644
--- a/xen/include/xen/setup.h
+++ b/xen/include/xen/setup.h
@@ -5,6 +5,87 @@
 
 #include <asm/setup.h>
 
+/* Reusing Dom0less definitions */
+typedef enum {
+    BOOTMOD_XEN,
+    BOOTMOD_FDT,
+    BOOTMOD_KERNEL,
+    BOOTMOD_RAMDISK,
+    BOOTMOD_MICROCODE,
+    BOOTMOD_XSM,
+    BOOTMOD_GUEST_DTB,
+    BOOTMOD_GUEST_CONF,
+    BOOTMOD_UNKNOWN
+}  bootmodule_kind;
+
+struct bootmodule {
+    bootmodule_kind kind;
+    bool domU;
+    paddr_t start;
+    paddr_t size;
+};
+
+/* End reuse */
+
+struct memrange {
+    paddr_t start;
+    paddr_t size;
+};
+
+/* Currently only two config modules supported, microcode and xsm policy */
+#define HL_MAX_CONFIG_MODULES 2
+struct bootconfig {
+    uint16_t nr_mods;
+    struct bootmodule mods[HL_MAX_CONFIG_MODULES];
+};
+
+struct bootdomain {
+#define HL_PERMISSION_NONE          (0)
+#define HL_PERMISSION_CONTROL       (1 << 0)
+#define HL_PERMISSION_HARDWARE      (1 << 1)
+    uint32_t permissions;
+
+#define HL_FUNCTION_NONE            (0)
+#define HL_FUNCTION_BOOT            (1 << 0)
+#define HL_FUNCTION_CRASH           (1 << 1)
+#define HL_FUNCTION_CONSOLE         (1 << 2)
+#define HL_FUNCTION_XENSTORE        (1 << 30)
+#define HL_FUNCTION_LEGACY_DOM0     (1 << 31)
+    uint32_t functions;
+
+#define HL_MODE_PARAVIRTUALIZED     (1 << 0) /* PV | PVH/HVM */
+#define HL_MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */
+#define HL_MODE_LONG                (1 << 2) /* 64 BIT | 32 BIT */
+    uint32_t mode;
+
+    domid_t domid;
+    uint8_t uuid[16];
+
+    uint32_t ncpus;
+    bool maxmem_set;
+    struct memrange memrange[2]; /* 0: min; 1: max */
+
+#define HL_MAX_SECID_LEN 64
+    unsigned char secid[HL_MAX_SECID_LEN];
+
+#define HL_MAX_DOMAIN_MODULES 3
+    uint16_t nr_mods;
+    struct bootmodule modules[HL_MAX_DOMAIN_MODULES];
+#define HL_MAX_CMDLINE_LEN 1024
+    unsigned char cmdline[HL_MAX_CMDLINE_LEN];
+};
+
+struct hyperlaunch_config {
+    const void *fdt;
+#ifdef CONFIG_MULTIBOOT
+    module_t *mods;
+#endif
+    struct bootconfig config;
+#define HL_MAX_BOOT_DOMAINS 64
+    uint16_t nr_doms;
+    struct bootdomain domains[HL_MAX_BOOT_DOMAINS];
+};
+
 #ifdef CONFIG_HYPERLAUNCH
 extern bool hyperlaunch_enabled;
 #else
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:34:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:34:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248856.429287 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIzH-0002eK-VX; Fri, 17 Dec 2021 19:33:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248856.429287; Fri, 17 Dec 2021 19:33:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myIzH-0002eD-RD; Fri, 17 Dec 2021 19:33:51 +0000
Received: by outflank-mailman (input) for mailman id 248856;
 Fri, 17 Dec 2021 19:33:51 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIzG-0008Bq-RP
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:33:51 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 414180b7-5f70-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:33:49 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769533980515.4791303301643;
 Fri, 17 Dec 2021 11:32:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 414180b7-5f70-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1639769536; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=LRwyF7YjPUIvDIKpwNgdKqs0A5QpKDYz1hbsgNq0OlauuTnag0Juut2BDpHxuKM4N8N4vcPvpEpCAtbFSBmJfnr8ZRAz07gzKbpkhIVX9XB1+GCDWOaHKMsBm3HkZEpDmnAcHSv2v3maxU/iN2s232XcgkdpE6xMfIOwpICToQQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769536; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=7qK/q8L3Dj8oS1Z+e7fSt0NndhOrav9jTYYOlCWbcqs=; 
	b=NuhQmMUy4u9uhT32kbAEhrxNEG57dkBmNvi1+QIqmu2UM/mWuT0lIquTSQ8EwJ2aHTTyzgE1pSkYR7o37S/SanD9UB2ddvuwS1vYJ6/7s3xMdJx3U8z4u7s1qa4wv/xMoehiAooD8S7wbXApUb4Cnm7x0ONqi0iOBroPbDpvGB8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769536;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=7qK/q8L3Dj8oS1Z+e7fSt0NndhOrav9jTYYOlCWbcqs=;
	b=WfbS9O5T4z2pvcJtWcCoS119bQSahtxTXzmbptpSuh5zuruYweQmyNdNTfcK8OEl
	zqLTXiQcBwomOZnX3+pBicc8JnjspQNwhGYsLYjV6qt4+32rKxReDz2xML2qDPqL2jf
	q2a1QKVS0AD3hzWDwO4zLWYKqgnX7DzsysmRH3m4=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC 07/10] hyperlaunch: add parsing of dtb
Date: Fri, 17 Dec 2021 18:34:33 -0500
Message-Id: <20211217233437.13791-8-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit implements the parsing of a hyperlaunch device tree. It is
implemented to support a device tree containing any number of Config nodes and
Domain nodes.

RFC Note: Xen supports working with flattened device trees (FDT), DTB files,
and unflattened device trees, in-memory structures. The library libfdt provides
low-level interaction with FDTs with higher order functions spread between
arch/arm/bootfdt.c and a few in device_tree.c. While there are some FDT
handlers in device_tree.c, it primarily provides the functionality for handling
unflattened device trees.

For this RFC the general higher order FDT functions in bootfdt.c usable by
hyperlaunch were duplicated into common/setup.c for hyperlaunch usage. Longer
term it would be desired to see all reusable FDT functions centralized in
common separate from the unflattened device tree handling code in
device_tree.c.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/common/setup.c      | 367 +++++++++++++++++++++++++++++++++++++++-
 xen/include/xen/setup.h |  22 ++-
 2 files changed, 387 insertions(+), 2 deletions(-)

diff --git a/xen/common/setup.c b/xen/common/setup.c
index e18ea14fe0..af2b1a422d 100644
--- a/xen/common/setup.c
+++ b/xen/common/setup.c
@@ -1,8 +1,373 @@
-#include <xen/types.h>
+#include <xen/pci.h> /* needed by device_tree.h */
+#include <xen/device_tree.h>
 #include <xen/init.h>
+#include <xen/libfdt/libfdt.h>
+#include <xen/multiboot.h>
+#include <xen/setup.h>
+#include <xen/types.h>
 
 #ifdef CONFIG_HYPERLAUNCH
 
 bool __initdata hyperlaunch_enabled;
+static struct hyperlaunch_config __initdata hl_config;
+
+/* Reusing from arch/arm/bootfdt.c */
+
+static bool __init device_tree_node_compatible(const void *fdt, int node,
+                                               const char *match)
+{
+    int len, l;
+    int mlen;
+    const void *prop;
+
+    mlen = strlen(match);
+
+    prop = fdt_getprop(fdt, node, "compatible", &len);
+    if ( prop == NULL )
+        return false;
+
+    while ( len > 0 ) {
+        if ( !dt_compat_cmp(prop, match) )
+            return true;
+        l = strlen(prop) + 1;
+        prop += l;
+        len -= l;
+    }
+
+    return false;
+}
+
+static void __init device_tree_get_reg(
+    const __be32 **cell, uint32_t address_cells, uint32_t size_cells,
+    uint64_t *start, uint64_t *size)
+{
+    *start = dt_next_cell(address_cells, cell);
+    *size = dt_next_cell(size_cells, cell);
+}
+
+static uint32_t __init device_tree_get_u32(
+    const void *fdt, int node, const char *prop_name, u32 dflt)
+{
+    const struct fdt_property *prop;
+
+    prop = fdt_get_property(fdt, node, prop_name, NULL);
+    if ( !prop || prop->len < sizeof(u32) )
+        return dflt;
+
+    return fdt32_to_cpu(*(uint32_t*)prop->data);
+}
+
+/**
+ * device_tree_for_each_node - iterate over all device tree sub-nodes
+ * @fdt: flat device tree.
+ * @node: parent node to start the search from
+ * @func: function to call for each sub-node.
+ * @data: data to pass to @func.
+ *
+ * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored.
+ *
+ * Returns 0 if all nodes were iterated over successfully.  If @func
+ * returns a value different from 0, that value is returned immediately.
+ */
+int __init device_tree_for_each_node(
+    const void *fdt, int node, device_tree_node_func func, void *data)
+{
+    /*
+     * We only care about relative depth increments, assume depth of
+     * node is 0 for simplicity.
+     */
+    int depth = 0;
+    const int first_node = node;
+    u32 address_cells[DEVICE_TREE_MAX_DEPTH];
+    u32 size_cells[DEVICE_TREE_MAX_DEPTH];
+    int ret;
+
+    do {
+        const char *name = fdt_get_name(fdt, node, NULL);
+        u32 as, ss;
+
+        if ( depth >= DEVICE_TREE_MAX_DEPTH )
+        {
+            printk("Warning: device tree node `%s' is nested too deep\n",
+                   name);
+            continue;
+        }
+
+        as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT;
+        ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT;
+
+        address_cells[depth] = device_tree_get_u32(fdt, node,
+                                                   "#address-cells", as);
+        size_cells[depth] = device_tree_get_u32(fdt, node,
+                                                "#size-cells", ss);
+
+        /* skip the first node */
+        if ( node != first_node )
+        {
+            ret = func(fdt, node, name, depth, as, ss, data);
+            if ( ret != 0 )
+                return ret;
+        }
+
+        node = fdt_next_node(fdt, node, &depth);
+    } while ( node >= 0 && depth > 0 );
+
+    return 0;
+}
+
+/* End reuse */
+
+static bool read_module(
+    const void *fdt, int node, uint32_t address_cells, uint32_t size_cells,
+    struct hyperlaunch_config *config, struct bootmodule *bm)
+{
+    const struct fdt_property *prop;
+    const __be32 *cell;
+    bootmodule_kind kind = BOOTMOD_UNKNOWN;
+    int len;
+
+    if ( device_tree_node_compatible(fdt, node, "module,kernel") )
+        kind = BOOTMOD_KERNEL;
+
+    if ( device_tree_node_compatible(fdt, node, "module,ramdisk") )
+        kind = BOOTMOD_RAMDISK;
+
+    if ( device_tree_node_compatible(fdt, node, "module,microcode") )
+        kind = BOOTMOD_MICROCODE;
+
+    if ( device_tree_node_compatible(fdt, node, "module,xsm-policy") )
+        kind = BOOTMOD_XSM;
+
+    if ( device_tree_node_compatible(fdt, node, "module,config") )
+        kind = BOOTMOD_GUEST_CONF;
+
+    if ( device_tree_node_compatible(fdt, node, "multiboot,module") )
+    {
+#ifdef CONFIG_MULTIBOOT
+        uint32_t idx;
+
+        idx = (uint32_t)device_tree_get_u32(fdt, node, "mb-index", 0);
+        if ( idx == 0 )
+            return false;
+
+        bm->kind = kind;
+        /* under multiboot, start will just hold pointer to module entry */
+        bm->start = (paddr_t)(&config->mods[idx]);
+
+        return true;
+#else
+        return false;
+#endif
+    }
+
+    prop = fdt_get_property(fdt, node, "module-addr", &len);
+    if ( !prop )
+        return false;
+
+    if ( len < dt_cells_to_size(address_cells + size_cells) )
+        return false;
+
+    cell = (const __be32 *)prop->data;
+    device_tree_get_reg(
+        &cell, address_cells, size_cells, &(bm->start), &(bm->size));
+    bm->kind = kind;
+
+    return true;
+}
+
+static int process_config_node(
+    const void *fdt, int node, const char *name, int depth,
+    uint32_t address_cells, uint32_t size_cells, void *data)
+{
+    struct hyperlaunch_config *config = (struct hyperlaunch_config *)data;
+    uint16_t *count;
+    int node_next;
+
+    if ( !config )
+        return -1;
+
+    for ( node_next = fdt_first_subnode(fdt, node),
+          count = &(config->config.nr_mods);
+          node_next > 0;
+          node_next = fdt_next_subnode(fdt, node_next),
+          (*count)++ )
+    {
+        struct bootmodule *next_bm;
+
+        if ( *count >= HL_MAX_CONFIG_MODULES )
+        {
+            printk("Warning: truncating to %d hyperlaunch config modules\n",
+                   HL_MAX_CONFIG_MODULES);
+            return 0;
+        }
+
+        next_bm = &config->config.mods[*count];
+        read_module(fdt, node_next, address_cells, size_cells, config, next_bm);
+    }
+
+    return 0;
+}
+
+static int process_domain_node(
+    const void *fdt, int node, const char *name, int depth,
+    uint32_t address_cells, uint32_t size_cells, void *data)
+{
+    struct hyperlaunch_config *config = (struct hyperlaunch_config *)data;
+    const struct fdt_property *prop;
+    struct bootdomain *domain;
+    uint16_t *count;
+    const __be32 *cell;
+    int node_next, i, plen;
+
+    if ( !config )
+        return -1;
+
+    domain = &config->domains[config->nr_doms];
+
+    domain->domid = (domid_t)device_tree_get_u32(fdt, node, "domid", 0);
+    domain->permissions = device_tree_get_u32(fdt, node, "permissions", 0);
+    domain->functions = device_tree_get_u32(fdt, node, "functions", 0);
+    domain->mode = device_tree_get_u32(fdt, node, "mode", 0);
+
+    prop = fdt_get_property(fdt, node, "domain-uuid", &plen);
+    if ( prop )
+        for ( i=0; i < sizeof(domain->uuid) % sizeof(uint32_t); i++ )
+            *(domain->uuid + i) = fdt32_to_cpu((uint32_t)prop->data[i]);
+
+    domain->ncpus = device_tree_get_u32(fdt, node, "cpus", 1);
+
+    prop = fdt_get_property(fdt, node, "memory", &plen);
+    if ( !prop )
+        panic("node %s missing `memory' property\n", name);
+
+    /* TODO: convert to support reading up to two values from mem prop, min and max */
+    cell = (const __be32 *)prop->data;
+    device_tree_get_reg(&cell, address_cells, size_cells,
+                        &domain->memrange[0].start, &domain->memrange[0].size);
+
+    prop = fdt_get_property(fdt, node, "security-id",
+                                &plen);
+    if ( prop )
+    {
+        int size = fdt32_to_cpu(prop->len);
+        size = size > HL_MAX_SECID_LEN ?
+                HL_MAX_SECID_LEN : size;
+        memcpy(domain->secid, prop->data, size);
+    }
+
+    for ( node_next = fdt_first_subnode(fdt, node),
+          count = &(domain->nr_mods);
+          node_next > 0;
+          node_next = fdt_next_subnode(fdt, node_next),
+          (*count)++ )
+    {
+        struct bootmodule *next_bm;
+
+        if ( name == NULL )
+            continue;
+
+        if ( *count >= HL_MAX_DOMAIN_MODULES )
+        {
+            printk("Warning: truncating to %d hyperlaunch domain modules"
+                   " for %dth domain\n", HL_MAX_DOMAIN_MODULES,
+                   config->nr_doms);
+            break;
+        }
+
+        if ( device_tree_node_compatible(fdt, node_next, "module,kernel") )
+        {
+            prop = fdt_get_property(fdt, node_next, "bootargs", &plen);
+            if ( prop )
+            {
+                int size = fdt32_to_cpu(prop->len);
+                size = size > HL_MAX_CMDLINE_LEN ? HL_MAX_CMDLINE_LEN : size;
+                memcpy(domain->cmdline, prop->data, size);
+            }
+        }
+
+        next_bm = &domain->modules[*count];
+        read_module(fdt, node_next, address_cells, size_cells, config, next_bm);
+    }
+
+    config->nr_doms++;
+
+    return 0;
+}
+
+static int __init hl_scan_node(
+    const void *fdt, int node, const char *name, int depth, u32 address_cells,
+    u32 size_cells, void *data)
+{
+    int rc = -1;
+
+    /* skip nodes that are not direct children of the hyperlaunch node */
+    if ( depth > 1 )
+        return 0;
+
+    if ( device_tree_node_compatible(fdt, node, "xen,config") )
+        rc = process_config_node(fdt, node, name, depth,
+                                 address_cells, size_cells, data);
+    else if ( device_tree_node_compatible(fdt, node, "xen,domain") )
+        rc = process_domain_node(fdt, node, name, depth,
+                                 address_cells, size_cells, data);
+
+    if ( rc < 0 )
+        printk("hyperlaunch fdt: node `%s': parsing failed\n", name);
+
+    return rc;
+}
+
+/* hyperlaunch_init:
+ *   Attempts to initialize hyperlaunch config
+ *
+ * Returns:
+ *   -1: Not a valid DTB
+ *    0: Valid DTB but not a valid hyperlaunch device tree
+ *    1: Valid hyperlaunch device tree
+ */
+int __init hyperlaunch_init(const void *fdt)
+{
+    int hl_node, ret;
+
+    ret = fdt_check_header(fdt);
+    if ( ret < 0 )
+        return -1;
+
+    hl_node = fdt_path_offset(fdt, "/chosen/hypervisor");
+    if ( hl_node < 0 )
+        return 0;
+
+    ret = device_tree_for_each_node(fdt, hl_node, hl_scan_node, &hl_config);
+    if ( ret > 0 )
+        return 0;
+
+    hyperlaunch_enabled = true;
+
+    return 1;
+}
+
+#ifdef CONFIG_MULTIBOOT
+bool __init hyperlaunch_mb_init(module_t *mods)
+{
+    bool ret = false;
+    /* fdt is required to be module 0 */
+    void *fdt = _p(mods->mod_start);
+
+    hl_config.mods = mods;
+
+    switch ( hyperlaunch_init(fdt) )
+    {
+    case 1:
+        ret = true;
+    case -1:
+        break;
+    case 0:
+    default:
+        panic("HYPERLAUNCH: nonrecoverable error occured processing DTB\n");
+    }
+
+    return ret;
+}
+#endif
 
 #endif
diff --git a/xen/include/xen/setup.h b/xen/include/xen/setup.h
index 69ea042716..fd4c23c08f 100644
--- a/xen/include/xen/setup.h
+++ b/xen/include/xen/setup.h
@@ -88,8 +88,28 @@ struct hyperlaunch_config {
 
 #ifdef CONFIG_HYPERLAUNCH
 extern bool hyperlaunch_enabled;
-#else
+
+int __init hyperlaunch_init(const void *fdt);
+
+#ifdef CONFIG_MULTIBOOT
+bool __init hyperlaunch_mb_init(module_t *mods);
+#endif
+
+#else /* CONFIG_HYPERLAUNCH */
+
 #define hyperlaunch_enabled false
+
+static inline int __init hyperlaunch_init(const void *fdt)
+{
+    return 0;
+}
+
+#ifdef CONFIG_MULTIBOOT
+static inline bool __init hyperlaunch_mb_init(module_t *mods)
+{
+    return false;
+}
 #endif
 
+#endif /* CONFIG_HYPERLAUNCH */
 #endif /* XEN_SETUP_H */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:39:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:39:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248881.429297 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4c-0003um-JH; Fri, 17 Dec 2021 19:39:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248881.429297; Fri, 17 Dec 2021 19:39:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4c-0003uf-GI; Fri, 17 Dec 2021 19:39:22 +0000
Received: by outflank-mailman (input) for mailman id 248881;
 Fri, 17 Dec 2021 19:39:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIze-0007M8-AB
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:34:14 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4fb49dad-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:34:13 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769536692979.2933938584735;
 Fri, 17 Dec 2021 11:32:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4fb49dad-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769538; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=RDK9IwhFyLlcrau1HLkiCLie1koVD68x2sxkYoIienDSzl0T5QeSv85CMMBq0dlzN6O4nyMS9oB8MV9CSuLp0z098cUrbpY/1IQRxdDO0AykeBgcZd5SU5uI6lP7Oc0z7D0fZnmTejPaDCcKm2uOOFnJlxX9lioZC2lmqPlSGV0=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769538; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=1+rH6E1T2X2GXGjtweKYSNPXNycy0FvEQLaaEz+oWec=; 
	b=mS9lXSLSCN/7pBwxZs/wY+XHHQu1yfNx0xtU0jHjNWk9rx3HwqE6427IFEkhW4xa15wh2hYuh5I1dwzolT4gawqSF+J4j1v5yB79V0mgezkrTtkakD2/t2goTRUEv0CzqXOkVFi93UptEHs48PurzO1dqBjdTnvSPYTkqyPlmxg=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769538;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=1+rH6E1T2X2GXGjtweKYSNPXNycy0FvEQLaaEz+oWec=;
	b=D5L0hz30hKsnOfgdwYKqhAawyQ1rRzL4ODgjTMERvyW/9hGTNCrlmuJmNcI6xiYY
	rzo05LpNV3f66ZRmIfYW/FjYCAtZAFfWIm0N3AIGQQRY4QSsnuA7FQwZ6KAMCm/mGLQ
	HtW0Bln9Ut7a1TVDGIaRp4UiKZVIu4hCpEyEv4TM=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [RFC 09/10] hyperlaunch: add domain creation logic
Date: Fri, 17 Dec 2021 18:34:35 -0500
Message-Id: <20211217233437.13791-10-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit introduces the skeleton of hyperlaunch domain construction
mechanics and adds the preliminary ability to construct dom0.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/common/setup.c      | 77 +++++++++++++++++++++++++++++++++++++++++
 xen/include/xen/setup.h | 16 +++++++++
 2 files changed, 93 insertions(+)

diff --git a/xen/common/setup.c b/xen/common/setup.c
index af2b1a422d..cd24f60297 100644
--- a/xen/common/setup.c
+++ b/xen/common/setup.c
@@ -1,3 +1,4 @@
+#include <asm/bzimage.h> /* for bzimage_headroom */
 #include <xen/pci.h> /* needed by device_tree.h */
 #include <xen/device_tree.h>
 #include <xen/init.h>
@@ -368,6 +369,82 @@ bool __init hyperlaunch_mb_init(module_t *mods)
 
     return ret;
 }
+
+void __init hyperlaunch_mb_headroom(void)
+{
+    int i,j;
+
+    for( i = 0; i < hl_config.nr_doms; i++ )
+    {
+        for ( j = 0; j < hl_config.domains[i].nr_mods; j++ )
+        {
+            if ( hl_config.domains[i].modules[j].kind == BOOTMOD_KERNEL )
+            {
+                module_t *kern =
+                    (module_t *)_p(hl_config.domains[i].modules[j].start);
+
+                kern->headroom = bzimage_headroom(bootstrap_map(kern),
+                                                  kern->mod_end);
+                bootstrap_map(NULL);
+            }
+        }
+    }
+}
 #endif
 
+uint32_t __init hyperlaunch_create_domains(
+    struct domain **hwdom, const char *kextra, const char *loader)
+{
+    uint32_t dom_count = 0, functions_used = 0;
+    int i;
+
+    *hwdom = NULL;
+
+    for ( i = 0; i < hl_config.nr_doms; i++ )
+    {
+        struct bootdomain *d = &(hl_config.domains[i]);
+
+        /* build a legacy dom0 and set it as the hwdom */
+        if ( (d->functions & HL_FUNCTION_LEGACY_DOM0) &&
+             !(functions_used & HL_FUNCTION_LEGACY_DOM0) )
+        {
+            module_t *image = NULL, *initrd = NULL;
+            int j;
+
+            for ( j = 0; j < d->nr_mods; j++ )
+            {
+                if ( d->modules[j].kind == BOOTMOD_KERNEL )
+                    image = (module_t *)_p(d->modules[j].start);
+
+                if ( d->modules[j].kind == BOOTMOD_RAMDISK )
+                    initrd = (module_t *)_p(d->modules[j].start);
+
+                if ( image && initrd )
+                    break;
+            }
+
+            if ( image == NULL )
+                return 0;
+
+#ifdef CONFIG_MULTIBOOT
+            *hwdom = create_dom0(image, image->headroom, initrd, kextra,
+                                 loader);
+#endif
+            if ( *hwdom )
+            {
+                functions_used |= HL_FUNCTION_LEGACY_DOM0;
+                dom_count++;
+            }
+            else
+                panic("HYPERLAUNCH: "
+                      "Dom0 config present but dom0 construction failed\n");
+        }
+        else
+            printk(XENLOG_WARNING "hyperlaunch: "
+                   "currently only supports classic dom0 construction");
+    }
+
+    return dom_count;
+}
+
 #endif
diff --git a/xen/include/xen/setup.h b/xen/include/xen/setup.h
index fd4c23c08f..3833867470 100644
--- a/xen/include/xen/setup.h
+++ b/xen/include/xen/setup.h
@@ -93,8 +93,12 @@ int __init hyperlaunch_init(const void *fdt);
 
 #ifdef CONFIG_MULTIBOOT
 bool __init hyperlaunch_mb_init(module_t *mods);
+void __init hyperlaunch_mb_headroom(void);
 #endif
 
+uint32_t __init hyperlaunch_create_domains(
+    struct domain **hwdom, const char *kextra, const char *loader);
+
 #else /* CONFIG_HYPERLAUNCH */
 
 #define hyperlaunch_enabled false
@@ -109,7 +113,19 @@ static inline bool __init hyperlaunch_mb_init(module_t *mods)
 {
     return false;
 }
+
+void __init hyperlaunch_mb_headroom(void)
+{
+    return;
+}
 #endif
 
+static inline uint32_t __init hyperlaunch_create_domains(
+    struct domain **hwdom, const char *kextra, const char *loader)
+{
+    return 0;
+}
+
 #endif /* CONFIG_HYPERLAUNCH */
+
 #endif /* XEN_SETUP_H */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:39:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:39:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248883.429309 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4n-0004Gb-0I; Fri, 17 Dec 2021 19:39:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248883.429309; Fri, 17 Dec 2021 19:39:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4m-0004GS-S6; Fri, 17 Dec 2021 19:39:32 +0000
Received: by outflank-mailman (input) for mailman id 248883;
 Fri, 17 Dec 2021 19:39:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIzT-0007M8-BN
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:34:03 +0000
Received: from sender3-of-o51.zoho.com (sender3-of-o51.zoho.com
 [136.143.184.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4931a961-5f70-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:34:02 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 163976953529295.99852145326895;
 Fri, 17 Dec 2021 11:32:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4931a961-5f70-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639769537; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=OsGAQ/VNAFE26cjZThMusRRk78fqvUF8U7Et/uxu+6oyDS6nW4jHhfXr4zuhIHr0szS5SsSiR9oIXFDs6Lx5xmza2lbJKnN2DvfVqTLwxkKPAIo+Hw22Eyg6TzFayGWiyFeW3Pc3tUKpfSXhkJtA+jswn1Y8FjoplrBGM6mb7eM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769537; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=NYrY0kc0PHr/rCAcUSGijUpEU56IAIoRqii3V14eoTI=; 
	b=BxQlmzT/teJ8KfB46gnAETi7ncIf62r89zV6IKm5BcazW98ua2SBnQszyltqWHZ9BiNH1Gz8kVgNfF9MC0kk3SDWmmE+NiGQaFAmuS8BOsB6gfelW1w7P0pWTMrxnzJ+L4YIPLHGd816QfyOLAXJpv9Rg3k47/mXXSDYcOcipUY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769537;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=NYrY0kc0PHr/rCAcUSGijUpEU56IAIoRqii3V14eoTI=;
	b=LTuaPz0JcHmplgWTnsuuMsR/I2EMgchC0q8Veq6nJgvsgTpAYeW3EtCf29KzeNze
	rKbfYyDgcz1fuPVO2SWg2LqYIyv/uVskEhDyJY3O+72R7bCTvMMj7qidDgxGjl8YH6m
	x+nJD/MhWIHB3HfH2boGizdWwmhVmVIMll3oAcL4=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [RFC 08/10] hyperlaunch: make create_dom0 externally callable
Date: Fri, 17 Dec 2021 18:34:34 -0500
Message-Id: <20211217233437.13791-9-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit is for the RFC only to enable a quick demonstration of starting Xen
via hyperlaunch. Final version of hyperlaunch will have its own domain
construction function that will replace the RFC usage of create_dom0.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/arch/x86/include/asm/setup.h | 5 +++++
 xen/arch/x86/setup.c             | 8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h
index 7dc03b6b8d..71f5aaa9b1 100644
--- a/xen/arch/x86/include/asm/setup.h
+++ b/xen/arch/x86/include/asm/setup.h
@@ -34,6 +34,11 @@ static inline void vesa_init(void) {};
 static inline void vesa_mtrr_init(void) {};
 #endif
 
+struct domain *__init create_dom0(const module_t *image,
+                                  unsigned long headroom,
+                                  module_t *initrd, const char *kextra,
+                                  const char *loader);
+
 int construct_dom0(
     struct domain *d,
     const module_t *kernel, unsigned long kernel_headroom,
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index 4bf84c17e4..bee221d5ee 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -755,10 +755,10 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li
     return n;
 }
 
-static struct domain *__init create_dom0(const module_t *image,
-                                         unsigned long headroom,
-                                         module_t *initrd, const char *kextra,
-                                         const char *loader)
+struct domain *__init create_dom0(const module_t *image,
+                                  unsigned long headroom,
+                                  module_t *initrd, const char *kextra,
+                                  const char *loader)
 {
     struct xen_domctl_createdomain dom0_cfg = {
         .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0,
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:39:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:39:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248885.429320 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4o-0004Xr-A5; Fri, 17 Dec 2021 19:39:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248885.429320; Fri, 17 Dec 2021 19:39:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJ4o-0004Xj-5K; Fri, 17 Dec 2021 19:39:34 +0000
Received: by outflank-mailman (input) for mailman id 248885;
 Fri, 17 Dec 2021 19:39:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=qR5E=RC=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1myIzq-0008Bq-Nq
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:34:26 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5730ecc9-5f70-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 20:34:25 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639769537988673.3922656446274;
 Fri, 17 Dec 2021 11:32:17 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5730ecc9-5f70-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1639769539; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=SN9tTyT2zwY2lOr0z0ysHo/VS/72rE5opud8fZhI77td4LQ144T48gZMOuw/PnS2bJuPu0i6LPr6AmLr353q/cnvg5FQJ4dZ7EwtbDjFvYbBmu6h2S77kH2jwes5PTRscxOqmA3g8BXmtTqLqoK8IlZ9y+AbrL2xW7EiFs1/MeA=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639769539; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=jwECCbUo2nQZxRvb7JqeHbk/5gA0ySBH1Pa0syLScWY=; 
	b=CLXiw5Pjg2JnmotSAxt/N/xJsY6kXNuhQL8lxceZwp3IHFnXEkWx8PSQe5UnWhaolTtXRCnkAj1ch3rmdyEIh9smWojjI6sHWsObViLU28Cbsm4QO0d+di6rcYjQjO/L7uz5sBBlpFmfEGy3F0gVdLEIXfM7DG/ISIrWrxugm9A=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639769539;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;
	bh=jwECCbUo2nQZxRvb7JqeHbk/5gA0ySBH1Pa0syLScWY=;
	b=L258LMmqN+sntWZC+xo0y75MDFpm1U/v8NR/PlZiv3+LP0ZazyMffu3KprdcN5qF
	XjS/C+z4rmFYg4q/jE6ZXTUaMc3SgDxHYD6oR2uqkVYPb+YRsqRPrngK+aj8tQigM+j
	xawyLUYmZUj5xv8XL3Ms9aZzIR5gHQPTxltrYVA0=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	Christopher Clark <christopher.clark@starlab.io>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>
Subject: [RFC 10/10] hyperlaunch: integrate dtb parse and domain creation
Date: Fri, 17 Dec 2021 18:34:36 -0500
Message-Id: <20211217233437.13791-11-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20211217233437.13791-1-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

This commit introduces into x86 start_xen the detection and parsing of a
hyperlaunch DTB file and then using that information to construct the domains
contained in the hyperlaunch configuration.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Christopher Clark <christopher.clark@starlab.io>
---
 xen/arch/x86/setup.c | 54 ++++++++++++++++++++++++++++++--------------
 1 file changed, 37 insertions(+), 17 deletions(-)

diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index bee221d5ee..c007c421b0 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1020,6 +1020,9 @@ void __init noreturn __start_xen(unsigned long mbi_p)
     bitmap_fill(module_map, mbi->mods_count);
     __clear_bit(0, module_map); /* Dom0 kernel is always first */
 
+    if ( hyperlaunch_mb_init(mod) )
+        printk(XENLOG_INFO "Hyperlaunch enabled\n");
+
     if ( pvh_boot )
     {
         /* pvh_init() already filled in e820_raw */
@@ -1142,6 +1145,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
             panic("Bootloader didn't honor module alignment request\n");
         mod[i].mod_end -= mod[i].mod_start;
         mod[i].mod_start >>= PAGE_SHIFT;
+        mod[i].headroom = 0;
         mod[i].reserved = 0;
     }
 
@@ -1158,8 +1162,12 @@ void __init noreturn __start_xen(unsigned long mbi_p)
         mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext;
     }
 
-    mod->headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end);
-    bootstrap_map(NULL);
+    if ( hyperlaunch_enabled ) {
+        hyperlaunch_mb_headroom();
+    } else {
+        mod->headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end);
+        bootstrap_map(NULL);
+    }
 
 #ifndef highmem_start
     /* Don't allow split below 4Gb. */
@@ -1890,22 +1898,34 @@ void __init noreturn __start_xen(unsigned long mbi_p)
            cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ",
            cpu_has_nx ? "" : "not ");
 
-    initrdidx = find_first_bit(module_map, mbi->mods_count);
-    if ( !hyperlaunch_enabled &&
-         bitmap_weight(module_map, mbi->mods_count) > 1 )
-        printk(XENLOG_WARNING
-               "Multiple initrd candidates, picking module #%u\n",
-               initrdidx);
+    if ( hyperlaunch_enabled )
+    {
+        uint32_t ndoms;
 
-    /*
-     * We're going to setup domain0 using the module(s) that we stashed safely
-     * above our heap. The second module, if present, is an initrd ramdisk.
-     */
-    dom0 = create_dom0(mod, mod->headroom,
-                       initrdidx < mbi->mods_count ? mod + initrdidx : NULL,
-                       kextra, loader);
-    if ( !dom0 )
-        panic("Could not set up DOM0 guest OS\n");
+        printk(XENLOG_INFO "Hyperlaunch starting domain construction...\n");
+        ndoms = hyperlaunch_create_domains(&dom0, kextra, loader);
+        if ( ndoms == 0 )
+            panic("Hyperlaunch could not set up the domains\n");
+
+        printk(XENLOG_INFO "Hyperlaunch created %u domains\n", ndoms);
+    } else {
+        initrdidx = find_first_bit(module_map, mbi->mods_count);
+        if ( bitmap_weight(module_map, mbi->mods_count) > 1 )
+            printk(XENLOG_WARNING
+                   "Multiple initrd candidates, picking module #%u\n",
+                   initrdidx);
+
+        /*
+         * We're going to setup domain0 using the module(s) that we stashed
+         * safely above our heap. The second module, if present, is an initrd
+         * ramdisk.
+         */
+        dom0 = create_dom0(mod, mod->headroom,
+                           initrdidx < mbi->mods_count ? mod + initrdidx : NULL,
+                           kextra, loader);
+        if ( !dom0 )
+            panic("Could not set up DOM0 guest OS\n");
+    }
 
     heap_init_late();
 
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 17 19:50:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 19:50:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248911.429330 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJFL-0007gY-A4; Fri, 17 Dec 2021 19:50:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248911.429330; Fri, 17 Dec 2021 19:50:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myJFL-0007gR-75; Fri, 17 Dec 2021 19:50:27 +0000
Received: by outflank-mailman (input) for mailman id 248911;
 Fri, 17 Dec 2021 19:50:25 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=6k1w=RC=srcf.net=amc96@srs-se1.protection.inumbo.net>)
 id 1myJFJ-0007gL-R2
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 19:50:25 +0000
Received: from ppsw-33.csi.cam.ac.uk (ppsw-33.csi.cam.ac.uk [131.111.8.133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9270bec2-5f72-11ec-9e60-abaf8a552007;
 Fri, 17 Dec 2021 20:50:23 +0100 (CET)
Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:44372)
 by ppsw-33.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25)
 with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
 id 1myJF9-000y9u-h4 (Exim 4.95) (return-path <amc96@srcf.net>);
 Fri, 17 Dec 2021 19:50:15 +0000
Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86])
 (Authenticated sender: amc96)
 by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 089D41FC34;
 Fri, 17 Dec 2021 19:50:14 +0000 (GMT)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9270bec2-5f72-11ec-9e60-abaf8a552007
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus
Message-ID: <4382c02a-4207-729b-67b8-c9a8bf65b921@srcf.net>
Date: Fri, 17 Dec 2021 19:50:14 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-GB
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
 Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
 <20211217233437.13791-3-dpsmith@apertussolutions.com>
From: Andrew Cooper <amc96@srcf.net>
Subject: Re: [RFC 02/10] is_system_domain: replace open-coded instances
In-Reply-To: <20211217233437.13791-3-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 17/12/2021 23:34, Daniel P. Smith wrote:
> From: Christopher Clark <christopher.w.clark@gmail.com>
>
> There were several instances of open-coded domid range checking. This commit
> replaces those with the is_system_domain inline function.
>
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>

Ah - probably my fault.  When I added is_system_domain(), I didn't think
to scan for other opencodes - I was guts deep in the domain creation logic.

In addition to the ones you've got here...

xen/arch/x86/cpu/mcheck/mce.c:1521
xen/common/domain.c:586
common/domctl.c:55, 411 and 421

according to `git grep DOMID_FIRST_RESERVED`

> diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
> index 8ec4547bed..179f3dcc5a 100644
> --- a/xen/arch/x86/cpu/vpmu.c
> +++ b/xen/arch/x86/cpu/vpmu.c
> @@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
>       * in XENPMU_MODE_ALL, for everyone.
>       */
>      if ( (vpmu_mode & XENPMU_MODE_ALL) ||
> -         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
> +         (is_system_domain(sampled->domain)) )

Can drop one set of brackets now.

> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 28146ee404..1df09bcb77 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -613,6 +613,11 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
>  #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
>  #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
>  
> +static inline bool is_system_domain_id(domid_t id)
> +{
> +    return (id >= DOMID_FIRST_RESERVED);
> +}
> +
>  static inline bool is_system_domain(const struct domain *d)
>  {
>      return d->domain_id >= DOMID_FIRST_RESERVED;

is_system_domain() wants implementing in terms of is_system_domain_id().

That said, could I talk you into is_system_domid() as a better name?

This is all sufficiently trivial that I'm tempted to fix on commit if
you'd like.  This patch is cleanup that stands on its own merit, and
isn't tied to hyperlaunch specifically.

~Andrew


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 21:40:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 21:40:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248918.429342 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myKxY-0003Cj-6M; Fri, 17 Dec 2021 21:40:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248918.429342; Fri, 17 Dec 2021 21:40:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myKxY-0003Cc-2Z; Fri, 17 Dec 2021 21:40:12 +0000
Received: by outflank-mailman (input) for mailman id 248918;
 Fri, 17 Dec 2021 21:40:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myKxX-0003CS-FT; Fri, 17 Dec 2021 21:40:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myKxX-0004VV-9s; Fri, 17 Dec 2021 21:40:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myKxW-0006Kw-V9; Fri, 17 Dec 2021 21:40:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myKxW-0006GP-Ug; Fri, 17 Dec 2021 21:40:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=384vxr4878ntAZfzG1r5FZS+y52Jp6WM+U+1U3AchNA=; b=XKCeKbmUXnF8QfU/18JPH17Cgu
	4Pkevt4LKU3t/TjrFigGPM+SFC++o9W1ms5lH9ozaJvEfGIeILDZ1g8HzdS9YkEZ3rmAMUdkVJ4rY
	btU0ucLMqsUD7DmhU49UKKybOL55B7yPMlRZfbflwafywKAn97st6xJkYFbsh65DabFk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167465-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167465: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=ee1f8262b83dd88b30091e6e81221ff299796099
X-Osstest-Versions-That:
    ovmf=ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 21:40:10 +0000

flight 167465 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167465/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 ee1f8262b83dd88b30091e6e81221ff299796099
baseline version:
 ovmf                 ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1

Last test of basis   167463  2021-12-17 15:10:34 Z    0 days
Testing same since   167465  2021-12-17 17:41:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Jiewen Yao <jiewen.yao@intel.com>
  Leif Lindholm <leif@nuviainc.com>
  Nhi Pham <nhi@os.amperecomputing.com>
  Shivanshu Goyal <shivanshu3@gmail.com>
  Stefan Berger <stefanb@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   ab5ab2f603..ee1f8262b8  ee1f8262b83dd88b30091e6e81221ff299796099 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 21:49:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 21:49:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248926.429353 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myL5m-0003tv-2Z; Fri, 17 Dec 2021 21:48:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248926.429353; Fri, 17 Dec 2021 21:48:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myL5l-0003to-Vg; Fri, 17 Dec 2021 21:48:41 +0000
Received: by outflank-mailman (input) for mailman id 248926;
 Fri, 17 Dec 2021 21:48:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myL5k-0003te-RX; Fri, 17 Dec 2021 21:48:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myL5k-0004eD-L9; Fri, 17 Dec 2021 21:48:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myL5k-0006fw-Br; Fri, 17 Dec 2021 21:48:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myL5k-0001Vw-BN; Fri, 17 Dec 2021 21:48:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ie3+PG6C06Cy5o10Almh4AtgPmRKQAk9oDiD5XTL/HU=; b=JjHzHHFrpHX+y9RDizTekLhq0I
	phyMYfzNUhpxcEQa4lZg3uQvZp0WCUomB2X1XpI8gB3YzKzhVYyZ22khyi07ProfY02rJg85Bu0A7
	+9nGpELfAT69xPM48fTXnGH0hgRkF90dVvQ9DzfDHNjk4RERsyZ0jntQSUGwqWZaDRa4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167467-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167467: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=32365f3476ac4655f2f26111cd7879912808cd77
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 17 Dec 2021 21:48:40 +0000

flight 167467 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167467/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  32365f3476ac4655f2f26111cd7879912808cd77

Last test of basis   167462  2021-12-17 15:01:42 Z    0 days
Testing same since   167467  2021-12-17 19:01:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   32365f3476..8e3edefb88  8e3edefb880caeeaaf80123d5599139e8c2c9ecf -> smoke


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 22:30:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 22:30:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248935.429364 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myLjz-0001Hr-Bf; Fri, 17 Dec 2021 22:30:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248935.429364; Fri, 17 Dec 2021 22:30:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myLjz-0001Hk-8j; Fri, 17 Dec 2021 22:30:15 +0000
Received: by outflank-mailman (input) for mailman id 248935;
 Fri, 17 Dec 2021 22:30:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=5AUT=RC=kernel.org=nathan@srs-se1.protection.inumbo.net>)
 id 1myLjx-0001He-Jz
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 22:30:13 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e5a2354a-5f88-11ec-85d3-df6b77346a89;
 Fri, 17 Dec 2021 23:30:11 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AEC59B82B21;
 Fri, 17 Dec 2021 22:30:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E46BC36AE2;
 Fri, 17 Dec 2021 22:30:03 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e5a2354a-5f88-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639780209;
	bh=8wwtNzd+gqMtJWZe56YrMEoqcAh58nCen38oaJYWaO8=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=iEDPDsKO98XO/jvJbm+yFgRmQxDl4CmwNCCZ9O7HpbCSEXJA25pw5YHPwb3s5TQNN
	 i9BY1ubFlnf5uG9DhdB1upZgn3wBZ2U7zEKoZbzzSqONfP1iWr0lR/mc6vKNukUu4Y
	 v3rmzZ7PuTCgGnrM38gn5DW9gYtmVN5J+BeNUM4EZYyS4A+dHs/rlpxPuADA19S0dn
	 neVNoMO0dY5ql14VUQ62/P1PHlq3AtDvEc5p5JSO8vS0wwfJA0S0NhJ71hctL2lZr6
	 u+JH0mJiYdoKOw4PkNyE8E1OMgv4ObOm4BwqrAiECJ8clDjSowxx7LeV6ApqW7P8A6
	 w01dCRvRkkngQ==
Date: Fri, 17 Dec 2021 15:30:00 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
Message-ID: <Yb0PaCyo/6z3XOlf@archlinux-ax161>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.900929381@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210221814.900929381@linutronix.de>

Hi Thomas,

On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Replace open coded MSI descriptor chasing and use the proper accessor
> functions instead.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Apologies if this has already been reported somewhere else or already
fixed, I did a search of all of lore and did not see anything similar to
it and I did not see any new commits in -tip around this.

I just bisected a boot failure on my AMD test desktop to this patch as
commit f48235900182 ("PCI/MSI: Simplify pci_irq_get_affinity()") in
-next. It looks like there is a problem with the NVMe drive after this
change according to the logs. Given that the hard drive is not getting
mounted for journald to write logs to, I am not really sure how to get
them from the machine so I have at least taken a picture of what I see
on my screen; open to ideas on that front!

https://github.com/nathanchance/bug-files/blob/0d25d78b5bc1d5e9c15192b3bc80676364de8287/f48235900182/crash.jpg

Please let me know what information I can provide to make debugging this
easier and I am more than happy to apply and test patches as needed.

Cheers,
Nathan


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 23:01:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 23:01:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248940.429374 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myMDN-0005Cg-TS; Fri, 17 Dec 2021 23:00:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248940.429374; Fri, 17 Dec 2021 23:00:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myMDN-0005CZ-Pm; Fri, 17 Dec 2021 23:00:37 +0000
Received: by outflank-mailman (input) for mailman id 248940;
 Fri, 17 Dec 2021 23:00:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W3Ie=RC=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1myMDN-0005CT-1H
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 23:00:37 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 23f3d7a6-5f8d-11ec-85d3-df6b77346a89;
 Sat, 18 Dec 2021 00:00:34 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 3FAF4B82965;
 Fri, 17 Dec 2021 23:00:33 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9F41C36AE5;
 Fri, 17 Dec 2021 23:00:30 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 23f3d7a6-5f8d-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639782032;
	bh=LejTMhU48Mx2jabxuDIJBTn6qqK8+Mpi6EV5/yAQURQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=S1BZDPLP7LPQN1JR8QMZz+eg9J7JRdDoPI3OW9NrINqWXKIhRadZic5GepYuy79Dc
	 pwqmDCH/lwl37q6jhc+9byS6qde7/8ZkMJRsC+PqtL9WksLYL/yrbNLux4Ooleq0C3
	 6L7WlT8vTMdr7nBDqPnwE7hNAdQKHuoshGV1wepoajfC5+/qOycugqcSeD6hd+9/Fe
	 SkI5Oe1/uVPdW0M0iaMMvsz7XfElPqdX2Rsjgk+DplwOCeQeXAMwTDtqKnsBbIosne
	 HpLKvgIjTU8OoF0P4Lvh/hm35nZocw+a8eXiIl+1iJhZggUDbj9NcHQrz9Ri5kNIzY
	 8fjQxRMcfbC+w==
Date: Fri, 17 Dec 2021 15:00:29 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Juergen Gross <jgross@suse.com>
cc: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>, 
    xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>, 
    Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
Message-ID: <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com> <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com> <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop> <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com> <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com> <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org> <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-651976584-1639782032=:1662642"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-651976584-1639782032=:1662642
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 17 Dec 2021, Juergen Gross wrote:
> On 17.12.21 11:41, Julien Grall wrote:
> > Hi Juergen,
> > 
> > On 17/12/2021 08:50, Juergen Gross wrote:
> > > On 17.12.21 08:45, Jan Beulich wrote:
> > > > On 17.12.2021 06:34, Juergen Gross wrote:
> > > > > On 16.12.21 22:15, Stefano Stabellini wrote:
> > > > > > On Thu, 16 Dec 2021, Stefano Stabellini wrote:
> > > > > > > On Thu, 16 Dec 2021, Juergen Gross wrote:
> > > > > > > > On 16.12.21 03:10, Stefano Stabellini wrote:
> > > > > > > > > The case of XENMEM_maximum_ram_page is interesting but it is
> > > > > > > > > not a
> > > > > > > > > problem in reality because the max physical address size is
> > > > > > > > > only 40-bit
> > > > > > > > > for aarch32 guests, so 32-bit are always enough to return the
> > > > > > > > > highest
> > > > > > > > > page in memory for 32-bit guests.
> > > > > > > > 
> > > > > > > > You are aware that this isn't the guest's max page, but the
> > > > > > > > host's?
> > > > > > 
> > > > > > I can see now that you meant to say that, no matter what is the max
> > > > > > pseudo-physical address supported by the VM, XENMEM_maximum_ram_page
> > > > > > is
> > > > > > supposed to return the max memory page, which could go above the
> > > > > > addressibility limit of the VM.
> > > > > > 
> > > > > > So XENMEM_maximum_ram_page should potentially be able to return
> > > > > > (1<<44)
> > > > > > even when called by an aarch32 VM, with max IPA 40-bit.
> > > > > > 
> > > > > > I would imagine it could be useful if dom0 is 32-bit but domUs are
> > > > > > 64-bit on a 64-bit hypervisor (which I think it would be a very rare
> > > > > > configuration on ARM.)
> > > > > > 
> > > > > > Then it looks like XENMEM_maximum_ram_page needs to be able to
> > > > > > return a
> > > > > > value > 32-bit when called by a 32-bit guest.
> > > > > > 
> > > > > > The hypercall ABI follows the ARM C calling convention, so a 64-bit
> > > > > > value should be returned using r0 and r1. But looking at
> > > > > > xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets
> > > > > > r1
> > > > > > today. Only r0 is set, so effectively we only support 32-bit return
> > > > > > values on aarch32 and for aarch32 guests.
> > > > > > 
> > > > > > In other words, today all hypercalls on ARM return 64-bit to 64-bit
> > > > > > guests and 32-bit to 32-bit guests. Which in the case of memory_op
> > > > > > is
> > > > > > "technically" the correct thing to do because it matches the C
> > > > > > declaration in xen/include/xen/hypercall.h:
> > > > > > 
> > > > > > extern long
> > > > > > do_memory_op(
> > > > > >       unsigned long cmd,
> > > > > >       XEN_GUEST_HANDLE_PARAM(void) arg);
> > > > > > 
> > > > > > So...  I guess the conclusion is that on ARM do_memory_op should
> > > > > > return
> > > > > > "long" although it is not actually enough for a correct
> > > > > > implementation
> > > > > > of XENMEM_maximum_ram_page for aarch32 guests ?
> > > > > > 
> > > > > 
> > > > > Hence my suggestion to check the return value of _all_ hypercalls to
> > > > > be
> > > > > proper sign extended int values for 32-bit guests. This would fix all
> > > > > potential issues without silently returning truncated values.
> > > > 
> > > > Are we absolutely certain we have no other paths left where a possibly
> > > > large unsigned values might be returned? In fact while
> > > > compat_memory_op() does the necessary saturation, I've never been fully
> > > > convinced of this being the best way of dealing with things. The range
> > > > of error indicators is much smaller than [-INT_MIN,-1], so almost
> > > > double the range of effectively unsigned values could be passed back
> > > > fine. (Obviously we can't change existing interfaces, so this mem-op
> > > > will need to remain as is.)
> > > 
> > > In fact libxenctrl tries do deal with this fact by wrapping a memory_op
> > > for a 32-bit environment into a multicall. This will work fine for a
> > > 32-bit Arm guest, as xen_ulong_t is a uint64 there.
> > > 
> > > So do_memory_op should return long on Arm, yes. OTOH doing so will
> > > continue to be a problem in case a 32-bit guest doesn't use the
> > > multicall technique for handling possible 64-bit return values.
> > > 
> > > So I continue to argue that on Arm the return value of a hypercall
> > > should be tested to fit into 32 bits. 
> > 
> > It would make sense. But what would you return if the value doesn't fit?
> 
> I guess some errno value would be appropriate, like -EDOM, -ERANGE or
> -E2BIG.

This seems to be better than the alternative below as it is a lot
simpler.


> > > The only really clean alternative
> > > would be to have separate hypercall function classes for Arm 32- and
> > > 64-bit guests (which still could share most of the functions by letting
> > > those return "int"). This would allow to use the 64-bit variant even for
> > > 32-bit guests in multicall (fine as the return field is 64-bit wide),
> > > and a probably saturating compat version for the 32-bit guest direct
> > > hypercall.
> > 
> > I am not entirely sure to understand this proposal. Can you clarify it?
> 
> 1. In patch 5 modify the hypercall table by adding another column, so
>    instead of:
>    +table:           pv32     pv64     hvm32    hvm64    arm
>    use:
>    +table:           pv32     pv64     hvm32    hvm64    arm32    arm64
> 
> 2. Let most of the hypercalls just return int instead of long:
>    +rettype: do int
> 
> 3. Have an explicit 64-bit variant of memory_op (the 32-bit one is the
>    compat variant existing already):
>    +rettype: do64 long
>    +prefix: do64 PREFIX_hvm
>    +memory_op(unsigned long cmd, void *arg)
> 
> 4. Use the appropriate calls in each column:
>    +memory_op         compat   do64     hvm      hvm      compat  do64
> 
> 5. In the Arm hypercall trap handler do:
>    if ( is_32bit_domain(current->domain) )
>        call_handlers_arm32(...);
>    else
>        call_handlers_arm64(...);
> 
> 6. In the multicall handler always do:
>    call_handlers_arm64(...);

--8323329-651976584-1639782032=:1662642--


From xen-devel-bounces@lists.xenproject.org Fri Dec 17 23:06:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 17 Dec 2021 23:06:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248944.429386 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myMIY-0005sQ-GL; Fri, 17 Dec 2021 23:05:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248944.429386; Fri, 17 Dec 2021 23:05:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myMIY-0005sJ-D6; Fri, 17 Dec 2021 23:05:58 +0000
Received: by outflank-mailman (input) for mailman id 248944;
 Fri, 17 Dec 2021 23:05:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=W3Ie=RC=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1myMIW-0005sB-S3
 for xen-devel@lists.xenproject.org; Fri, 17 Dec 2021 23:05:56 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e2a6b073-5f8d-11ec-9e60-abaf8a552007;
 Sat, 18 Dec 2021 00:05:55 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7E3F962420;
 Fri, 17 Dec 2021 23:05:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68A36C36AE2;
 Fri, 17 Dec 2021 23:05:52 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e2a6b073-5f8d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639782352;
	bh=3Z9YdgFITzvF0joTJMlOEus/bWvGEmDXNpA1XgVLSgE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=peZwlui2RfjQ6OiY7BwjvO+qbI1FMFlBEfwZFopCpTMKgxPv88FlSBqOD1CBMLOtB
	 0DDCshFFbFIIrjznV4AdvRKbxQF6c6x8PMBlotBb0JDPgqZ5IP0G8wCcuwh56dkA4g
	 DVQ6B8XxuIU1qlcI78/PYNZSrql7VZ5KxnO+PEKUU5oFGkafGusZLZVTy/1WsOEsgH
	 /Mpd/s6mPuzcQ1f9ziEMuoUjMNSzmelAH3MmeCBVIn2OMoHwhyaRh6r64MpTrk1+be
	 8mZjdr83e3X7OlN4UVnM0vYKUxfY+nz5IK+zB8m4YzWRRzpVcvCptDUq4NEeUzqLFS
	 N6u6qdklxzfGw==
Date: Fri, 17 Dec 2021 15:05:52 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <7cabbc0b-f6bd-04a1-9552-8cecf7639b15@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112171500360.1662642@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com> <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com> <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop> <7cabbc0b-f6bd-04a1-9552-8cecf7639b15@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Fri, 17 Dec 2021, Julien Grall wrote:
> Hi Stefano,
> 
> On 16/12/2021 21:15, Stefano Stabellini wrote:
> > On Thu, 16 Dec 2021, Stefano Stabellini wrote:
> > > On Thu, 16 Dec 2021, Juergen Gross wrote:
> > > > On 16.12.21 03:10, Stefano Stabellini wrote:
> > > > > On Wed, 15 Dec 2021, Juergen Gross wrote:
> > > > > > On 14.12.21 18:36, Julien Grall wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > On 08/12/2021 15:55, Juergen Gross wrote:
> > > > > > > > Today most hypercall handlers have a return type of long, while
> > > > > > > > the
> > > > > > > > compat ones return an int. There are a few exceptions from that
> > > > > > > > rule,
> > > > > > > > however.
> > > > > > > 
> > > > > > > So on Arm64, I don't think you can make use of the full 64-bit
> > > > > > > because a
> > > > > > > 32-bit domain would not be able to see the top 32-bit.
> > > > > > > 
> > > > > > > In fact, this could potentially cause us some trouble (see [1]) in
> > > > > > > Xen.
> > > > > > > So it feels like the hypercalls should always return a 32-bit
> > > > > > > signed
> > > > > > > value
> > > > > > > on Arm.
> > > > > > 
> > > > > > This would break hypercalls like XENMEM_maximum_ram_page which are
> > > > > > able
> > > > > > to return larger values, right?
> > > > > > 
> > > > > > > The other advantage is it would be clear that the top 32-bit are
> > > > > > > not
> > > > > > > usuable. Stefano, what do you think?
> > > > > > 
> > > > > > Wouldn't it make more sense to check the return value to be a sign
> > > > > > extended 32-bit value for 32-bit guests in do_trap_hypercall()
> > > > > > instead?
> > > > > > 
> > > > > > The question is what to return if this is not the case. -EDOM?
> > > > > 
> > > > > 
> > > > > I can see where Julien is coming from: we have been trying to keep the
> > > > > arm32 and arm64 ABIs identical since the beginning of the project. So,
> > > > > like Julien, my preference would be to always return 32-bit on ARM,
> > > > > both
> > > > > aarch32 and aarch64. It would make things simple.
> > > > > 
> > > > > The case of XENMEM_maximum_ram_page is interesting but it is not a
> > > > > problem in reality because the max physical address size is only
> > > > > 40-bit
> > > > > for aarch32 guests, so 32-bit are always enough to return the highest
> > > > > page in memory for 32-bit guests.
> > > > 
> > > > You are aware that this isn't the guest's max page, but the host's?
> > 
> > I can see now that you meant to say that, no matter what is the max
> > pseudo-physical address supported by the VM, XENMEM_maximum_ram_page is
> > supposed to return the max memory page, which could go above the
> > addressibility limit of the VM.
> > 
> > So XENMEM_maximum_ram_page should potentially be able to return (1<<44)
> > even when called by an aarch32 VM, with max IPA 40-bit.
> 
> I am a bit confused with what you wrote. Yes, 32-bit VM can only address
> 40-bit, but this is only limiting its own (guest) physical address space. Such
> VM would still be able to map any host physical address (assuming GFN != MFN).
 
I meant to say the same thing that you wrote, sorry it wasn't clear

 
> > I would imagine it could be useful if dom0 is 32-bit but domUs are
> > 64-bit on a 64-bit hypervisor (which I think it would be a very rare
> > configuration on ARM.)
> 
> Looking at the implementation, the hypercall is accessible by any domain. IOW
> a domU 32-bit could read a wrong value.
> 
> That said, it is not clear to me why an Arm or HVM x86 guest would want to
> read the value.

Right, indeed. AFAICT it is currently unused on ARM.

Going through the code, the only caller that could potentially use it on
ARM is libxl_domain_core_dump and xc_maximum_ram_page is called on the
if ( !auto_translated_physmap ) code path.


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 00:31:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 00:31:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248948.429397 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myNct-0008BP-KE; Sat, 18 Dec 2021 00:31:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248948.429397; Sat, 18 Dec 2021 00:31:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myNct-0008BI-Gd; Sat, 18 Dec 2021 00:31:03 +0000
Received: by outflank-mailman (input) for mailman id 248948;
 Sat, 18 Dec 2021 00:31:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myNcr-0008B8-Uz; Sat, 18 Dec 2021 00:31:01 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myNcr-0007x3-Ro; Sat, 18 Dec 2021 00:31:01 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myNcr-0005tt-Id; Sat, 18 Dec 2021 00:31:01 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myNcr-0004PK-IC; Sat, 18 Dec 2021 00:31:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ufezabRf0pGMjCIH9Ab402bmSzArj9ydGSZAAyybh0E=; b=cZUSJRCkkLyf+fAsBKKQlJcihD
	KMJlsadcij6IXP6nZtwn4vmdCXHxSRoGFvLg3SUQLdfULs0yJbBlZdBh5JLQdX3J/oUyQEH2tAh7v
	r44oyeRwLcEC5s87HHAVVNb9l8crwBx+3hbvu76xmcZu5CBZf7G31skHC4kIFiUuy9oU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167459-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167459: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e8ef940326efd17ca7fdd3cb8791c29a24b04f28
X-Osstest-Versions-That:
    linux=c32c40ff80928cfcea7435e27330cb995f6bfb67
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 00:31:01 +0000

flight 167459 linux-5.4 real [real]
flight 167468 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167459/
http://logs.test-lab.xenproject.org/osstest/logs/167468/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167468-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167449
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167449
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167449
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167449
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167449
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167449
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167449
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167449
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167449
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167449
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167449
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167449
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e8ef940326efd17ca7fdd3cb8791c29a24b04f28
baseline version:
 linux                c32c40ff80928cfcea7435e27330cb995f6bfb67

Last test of basis   167449  2021-12-16 16:13:05 Z    1 days
Testing same since   167459  2021-12-17 09:41:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Deucher <alexander.deucher@amd.com>
  Alexei Starovoitov <ast@kernel.org>
  Armin Wolf <W_Armin@gmx.de>
  Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
  Bui Quang Minh <minhquangbui99@gmail.com>
  Chen Jun <chenjun102@huawei.com>
  Connor O'Brien <connoro@google.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  David S. Miller <davem@davemloft.net>
  Erik Ekman <erik@kryo.se>
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Jakub Kicinski <kuba@kernel.org>
  Jon Hunter <jonathanh@nvidia.com>
  Kefeng Wang <wangkefeng.wang@huawei.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Mark-PK Tsai <mark-pk.tsai@mediatek.com>
  Michael Stapelberg <michael@stapelberg.ch>
  Mike Rapoport <rppt@linux.ibm.com>
  Mustapha Ghaddar <mghaddar@amd.com>
  Mustapha Ghaddar <mustapha.ghaddar@amd.com>
  Ondrej Jirman <megous@megous.com>
  Ondrej Mosnacek <omosnace@redhat.com>
  Pali Rohár <pali@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul Moore <paul@paul-moore.com>
  Perry Yuan <Perry.Yuan@amd.com>
  Philip Chen <philipchen@chromium.org>
  Rob Clark <robdclark@chromium.org>
  Sasha Levin <sashal@kernel.org>
  Sean Christopherson <seanjc@google.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Tadeusz Struk <tadeusz.struk@linaro.org>
  Tony Lindgren <tony@atomide.com>
  Vijay Balakrishna <vijayb@linux.microsoft.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Wolfram Sang <wsa@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   c32c40ff8092..e8ef940326ef  e8ef940326efd17ca7fdd3cb8791c29a24b04f28 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 02:01:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 02:01:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248959.429408 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myP2D-00045q-I6; Sat, 18 Dec 2021 02:01:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248959.429408; Sat, 18 Dec 2021 02:01:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myP2D-00045i-DA; Sat, 18 Dec 2021 02:01:17 +0000
Received: by outflank-mailman (input) for mailman id 248959;
 Sat, 18 Dec 2021 02:01:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myP2C-00045Y-7a; Sat, 18 Dec 2021 02:01:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myP2C-00032c-4y; Sat, 18 Dec 2021 02:01:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myP2B-0008Jx-S4; Sat, 18 Dec 2021 02:01:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myP2B-0007qu-RY; Sat, 18 Dec 2021 02:01:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=D6WykvuPqsncUv5pDAiuSzVzZo+09D20dTe7qqhtOVs=; b=3lbKCTI8lVuhqPusSqsVkeqmFd
	05o4/MMtHgE7hbtn27QMycu42cNtOL8QsQncN2uvepZDY8f3+HmpWV7a7utJWkWjDeazl8RcMDO9R
	gBYIYeADH1Y+4lS6dIFztin99n0lQlx08KZe8Z4LGLfVwsQl/XRzQZlI76DFH2jRpl28=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167461-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167461: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-vhd:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=6441998e2e37131b0a4c310af9156d79d3351c16
X-Osstest-Versions-That:
    linux=fa36bbe6d43f3bbce1f10a187e153587c7584d83
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 02:01:15 +0000

flight 167461 linux-linus real [real]
flight 167469 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167461/
http://logs.test-lab.xenproject.org/osstest/logs/167469/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-vhd       8 xen-boot            fail pass in 167469-retest
 test-amd64-amd64-xl    22 guest-start/debian.repeat fail pass in 167469-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 167469 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 167469 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167451
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167451
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167451
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167451
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167451
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167451
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167451
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167451
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                6441998e2e37131b0a4c310af9156d79d3351c16
baseline version:
 linux                fa36bbe6d43f3bbce1f10a187e153587c7584d83

Last test of basis   167451  2021-12-16 19:11:06 Z    1 days
Testing same since   167461  2021-12-17 13:00:28 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aaro Koskinen <aaro.koskinen@iki.fi>
  Adam Ford <aford173@gmail.com>
  Ahmed Zaki <anzaki@gmail.com>
  Alex Bee <knaerzche@gmail.com>
  Alexei Starovoitov <ast@kernel.org>
  Andrey Eremeev <Axtone4all@yandex.ru>
  Arnd Bergmann <arnd@arndb.de>
  Artem Lapkin <art@khadas.com>
  Artem Lapkin <email2tema@gmail.com>
  Baowen Zheng <baowen.zheng@corigine.com>
  Bjørn Mork <bjorn@mork.no>
  Brendan Jackman <jackmanb@google.com>
  Cyril Novikov <cnovikov@lynx.com>
  D. Wythe <alibuda@linux.alibaba.com>
  Dan Carpenter <dan.carpenter@oracle.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniele Palmas <dnlplm@gmail.com>
  Danielle Ratson <danieller@nvidia.com>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  David Wu <david.wu@rock-chips.com>
  Davide Caratti <dcaratti@redhat.com>
  Dennis Gilmore <dgilmore@redhat.com>
  Dinh Nguyen <dinguyen@kernel.org>
  Dust Li <dust.li@linux.alibaba.com>
  Eric Dumazet <edumazet@google.com>
  Fabio Estevam <festevam@gmail.com>
  Felix Fietkau <nbd@nbd.name>
  Filip Pokryvka <fpokryvk@redhat.com>
  Finn Behrens <fin@nyantec.com>
  Finn Behrens <me@kloenk.de>
  Finn Behrens <me@kloenk.dev>
  Florian Fainelli <f.fainelli@gmail.com>
  Florian Klink <flokli@flokli.de>
  Florian Westphal <fw@strlen.de>
  Frank Wunderlich <frank-w@public-files.de>
  Gal Pressman <gal@nvidia.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  Greg Jesionowski <jesionowskigreg@gmail.com>
  Guangbin Huang <huangguangbin2@huawei.com>
  Gurucharan G <gurucharanx.g@intel.com>
  Haimin Zhang <tcs.kernel@gmail.com>
  Hangbin Liu <liuhangbin@gmail.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hector Martin <marcan@marcan.st>
  Heiko Stuebner <heiko@sntech.de>
  Ido Schimmel <idosch@nvidia.com>
  Ilan Peer <ilan.peer@intel.com>
  Ioana Ciornei <ioana.ciornei@nxp.com>
  Ivan T. Ivanov <iivanov@suse.de>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  Janne Grunau <j@jannau.net>
  Jason Wang <jasowang@redhat.com>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jerome Brunet <jbrunet@baylibre.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Jie Wang <wangjie125@huawei.com>
  Jie2x Zhou <jie2x.zhou@intel.com>
  Johannes Berg <johannes.berg@intel.com>
  John Keeping <john@metanate.com>
  Jon Hunter <jonathanh@nvidia.com>
  Kalle Valo <kvalo@kernel.org>
  Karen Sornek <karen.sornek@intel.com>
  Karol Kolacinski <karol.kolacinski@intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Kumar Kartikeya Dwivedi <memxor@gmail.com>
  Kurt Kanzenbach <kurt@linutronix.de>
  Letu Ren <fantasquex@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Luca Coelho <luciano.coelho@intel.com>
  Lv Ruyi <lv.ruyi@zte.com.cn>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Maksym Yaremchuk <maksymy@nvidia.com>
  Marek Behún <kabel@kernel.org>
  Martin KaFai Lau <kafai@fb.com>
  Martin Kepplinger <martin.kepplinger@puri.sm>
  Mat Martineau <mathew.j.martineau@linux.intel.com>
  Mathew McBride <matt@traverse.com.au>
  Matthieu Baerts <matthieu.baerts@tessares.net>
  Maxim Galaganov <max@internet.ru>
  Maxime Bizon <mbizon@freebox.fr>
  Miaoqian Lin <linmq006@gmail.com>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Tipton <quic_mdtipton@quicinc.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  Nathan Chancellor <nathan@kernel.org>
  Nechama Kraus <nechamax.kraus@linux.intel.com>
  Neil Armstrong <narmstrong@baylibre.com>
  Ong Boon Leong <boon.leong.ong@intel.com>
  Paolo Abeni <pabeni@redhat.com>
  Paul Chaignon <paul@isovalent.com>
  Paul Moore <paul@paul-moore.com>
  Philipp Zabel <p.zabel@pengutronix.de>
  Po-Hsu Lin <po-hsu.lin@canonical.com>
  Rijo Thomas <Rijo-john.Thomas@amd.com>
  Rob Herring <robh@kernel.org>
  Robert Schlabbach <robert_s@gmx.net>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Sasha Neftin <sasha.neftin@intel.com>
  Shawn Guo <shawnguo@kernel.org>
  Simon Horman <simon.horman@corigine.com>
  Stefan Assmann <sassmann@kpanic.de>
  Stephan Gerhold <stephan@gerhold.net>
  Stephen Boyd <sboyd@kernel.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Thierry Reding <treding@nvidia.com>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vladimir Oltean <vladimir.oltean@nxp.com>
  Vyacheslav Bocharov <adeep@lexina.in>
  Wang Qing <wangqing@vivo.com>
  Wenliang Wang <wangwenliang.1995@bytedance.com>
  Willem de Bruijn <willemb@google.com>
  Wolfram Sang <wsa@kernel.org>
  Xing Song <xing.song@mediatek.com>
  Yufeng Mo <moyufeng@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          fail    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fa36bbe6d43f..6441998e2e37  6441998e2e37131b0a4c310af9156d79d3351c16 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 02:15:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 02:15:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248967.429419 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myPFf-0005oo-PN; Sat, 18 Dec 2021 02:15:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248967.429419; Sat, 18 Dec 2021 02:15:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myPFf-0005oh-MJ; Sat, 18 Dec 2021 02:15:11 +0000
Received: by outflank-mailman (input) for mailman id 248967;
 Sat, 18 Dec 2021 02:15:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=QHG9=RD=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1myPFe-0005oL-9L
 for xen-devel@lists.xenproject.org; Sat, 18 Dec 2021 02:15:10 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 515698cd-5fa8-11ec-85d3-df6b77346a89;
 Sat, 18 Dec 2021 03:15:07 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id AFCFDB82B51;
 Sat, 18 Dec 2021 02:15:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CBC7C36AE1;
 Sat, 18 Dec 2021 02:15:04 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 515698cd-5fa8-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639793704;
	bh=y6WcV/dJDk1yuDRMffLHm88qf1YS4EK0udgwiYkITlY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=YL/WlC76FYz5AM/JVrjDBwCyArqigxADo/WphWt+ySV0HSkdyL4v5unM1B0VosY4S
	 CZa/xrPp2EPujCyvbk5Gx5mJaH+zuJv5+zS5wSGolzkX9w4gB3k9woJZvg3Eq9yL7s
	 ZfyfieXV0p2q+fcBs06aeFMXh5bnXep4fLoD3myHRypWG7b1ZsV/KNxKPoZ8nVqam4
	 1ansxqtjAUvnaS8YgO0TSKrsqdyuqBSlv9iojJxzUUVQo/0zAM2dYYMbU3f6iniu0t
	 CGPg/rq3Bqpbtnr1TnyqSz15UV2o6ddI/QdiXyj/z6h1C8cCt9qZq15rcVJBcSPRx3
	 p4pxAWq5c6Eyg==
Date: Fri, 17 Dec 2021 18:14:55 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> This is the implementation of SCI interface, called SCMI-SMC driver,
> which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> This allows devices from the Domains to work with clocks, resets and
> power-domains without access to CPG.
> 
> The following features are implemented:
> - request SCMI channels from ATF and pass channels to Domains;
> - set device permissions for Domains based on the Domain partial
> device-tree. Devices with permissions are able to work with clocks,
> resets and power-domains via SCMI;
> - redirect scmi messages from Domains to ATF.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>  xen/arch/arm/Kconfig          |   2 +
>  xen/arch/arm/sci/Kconfig      |  10 +
>  xen/arch/arm/sci/Makefile     |   1 +
>  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
>  xen/include/public/arch-arm.h |   1 +
>  5 files changed, 809 insertions(+)
>  create mode 100644 xen/arch/arm/sci/Kconfig
>  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 186e1db389..02d96c6cfc 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -114,6 +114,8 @@ config SCI
>  	  support. It allows guests to control system resourcess via one of
>  	  SCI mediators implemented in XEN.
>  
> +source "arch/arm/sci/Kconfig"
> +
>  endmenu
>  
>  menu "ARM errata workaround via the alternative framework"
> diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> new file mode 100644
> index 0000000000..9563067ddc
> --- /dev/null
> +++ b/xen/arch/arm/sci/Kconfig
> @@ -0,0 +1,10 @@
> +config SCMI_SMC
> +	bool "Enable SCMI-SMC mediator driver"
> +	default n
> +	depends on SCI
> +	---help---
> +
> +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> +	This feature allows drivers from Domains to work with System
> +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> +	for communication.
> diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> index 837dc7492b..67f2611872 100644
> --- a/xen/arch/arm/sci/Makefile
> +++ b/xen/arch/arm/sci/Makefile
> @@ -1 +1,2 @@
>  obj-y += sci.o
> +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> new file mode 100644
> index 0000000000..2eb01ea82d
> --- /dev/null
> +++ b/xen/arch/arm/sci/scmi_smc.c
> @@ -0,0 +1,795 @@
> +/*
> + * xen/arch/arm/sci/scmi_smc.c
> + *
> + * SCMI mediator driver, using SCP as transport.
> + *
> + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> + * Copyright (C) 2021, EPAM Systems.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/sci/sci.h>
> +#include <asm/smccc.h>
> +#include <asm/io.h>
> +#include <xen/bitops.h>
> +#include <xen/config.h>
> +#include <xen/sched.h>
> +#include <xen/device_tree.h>
> +#include <xen/iocap.h>
> +#include <xen/init.h>
> +#include <xen/err.h>
> +#include <xen/lib.h>
> +#include <xen/list.h>
> +#include <xen/mm.h>
> +#include <xen/string.h>
> +#include <xen/time.h>
> +#include <xen/vmap.h>
> +
> +#define SCMI_BASE_PROTOCOL                  0x10
> +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> +#define SCMI_BASE_DISCOVER_AGENT            0x7
> +
> +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> +#define SCMI_SUCCESS              0
> +#define SCMI_NOT_SUPPORTED      (-1)
> +#define SCMI_INVALID_PARAMETERS (-2)
> +#define SCMI_DENIED             (-3)
> +#define SCMI_NOT_FOUND          (-4)
> +#define SCMI_OUT_OF_RANGE       (-5)
> +#define SCMI_BUSY               (-6)
> +#define SCMI_COMMS_ERROR        (-7)
> +#define SCMI_GENERIC_ERROR      (-8)
> +#define SCMI_HARDWARE_ERROR     (-9)
> +#define SCMI_PROTOCOL_ERROR     (-10)
> +
> +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> +
> +#define SCMI_SMC_ID                        "arm,smc-id"
> +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"

I could find the following SCMI binding in Linux, which describes
the arm,scmi-smc compatible and the arm,smc-id property:

Documentation/devicetree/bindings/firmware/arm,scmi.yaml

However, linux,scmi_mem is not described. Aren't you supposed to read
the "shmem" property instead? And the compatible string used for this
seems to be "arm,scmi-shmem".


> +#define SCMI_SHMEM                         "shmem"
> +
> +#define HYP_CHANNEL                          0x0
> +
> +#define HDR_ID                             GENMASK(7,0)
> +#define HDR_TYPE                           GENMASK(9, 8)
> +#define HDR_PROTO                          GENMASK(17, 10)
> +
> +/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
> +#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
> +
> +#define FIELD_GET(_mask, _reg)\
> +    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
> +#define FIELD_PREP(_mask, _val)\
> +    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
> +
> +typedef struct scmi_msg_header {
> +    uint8_t id;
> +    uint8_t type;
> +    uint8_t protocol;
> +} scmi_msg_header_t;
> +
> +typedef struct scmi_perms_tx {
> +    uint32_t agent_id;
> +    uint32_t device_id;
> +    uint32_t flags;
> +} scmi_perms_tx_t;
> +
> +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
> +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
> +
> +#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
> +
> +struct scmi_shared_mem {
> +    uint32_t reserved;
> +    uint32_t channel_status;
> +    uint32_t reserved1[2];
> +    uint32_t flags;
> +    uint32_t length;
> +    uint32_t msg_header;
> +    uint8_t msg_payload[];
> +};
> +
> +struct scmi_channel {
> +    int chan_id;
> +    int agent_id;
> +    uint32_t func_id;
> +    int domain_id;
> +    uint64_t paddr;
> +    struct scmi_shared_mem *shmem;
> +    spinlock_t lock;
> +    struct list_head list;
> +};
> +
> +struct scmi_data {
> +    struct list_head channel_list;
> +    spinlock_t channel_list_lock;
> +    bool initialized;
> +    u64 shmem_addr, shmem_size;
> +};
> +
> +static struct scmi_data scmi_data;
> +
> +/*
> + * pack_scmi_header() - packs and returns 32-bit header
> + *
> + * @hdr: pointer to header containing all the information on message id,
> + *    protocol id and type id.
> + *
> + * Return: 32-bit packed message header to be sent to the platform.
> + */
> +static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
> +{
> +    return FIELD_PREP(HDR_ID, hdr->id) |
> +        FIELD_PREP(HDR_TYPE, hdr->type) |
> +        FIELD_PREP(HDR_PROTO, hdr->protocol);
> +}
> +
> +/*
> + * unpack_scmi_header() - unpacks and records message and protocol id
> + *
> + * @msg_hdr: 32-bit packed message header sent from the platform
> + * @hdr: pointer to header to fetch message and protocol id.
> + */
> +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t *hdr)
> +{
> +    hdr->id = FIELD_GET(HDR_ID, msg_hdr);
> +    hdr->type = FIELD_GET(HDR_TYPE, msg_hdr);
> +    hdr->protocol = FIELD_GET(HDR_PROTO, msg_hdr);
> +}
> +
> +static inline int channel_is_free(struct scmi_channel *chan_info)
> +{
> +    return ( chan_info->shmem->channel_status
> +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;

Does this need a memory barrier? Or not, because the other end always
runs on the same CPU at a different execution level so the
channel_status would be always guaranteed to be read as updated?


> +}
> +
> +static int send_smc_message(struct scmi_channel *chan_info,
> +                            scmi_msg_header_t *hdr, void *data, int len)
> +{
> +    struct arm_smccc_res resp;
> +    int ret;
> +
> +    printk(XENLOG_DEBUG "scmi: status =%d len=%d\n",
> +           chan_info->shmem->channel_status, len);
> +    printk(XENLOG_DEBUG "scmi: header id = %d type = %d, proto = %d\n",
> +           hdr->id, hdr->type, hdr->protocol);
> +
> +    ret = channel_is_free(chan_info);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    chan_info->shmem->channel_status = 0x0;
> +    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be set */
> +    chan_info->shmem->flags = 0x0;
> +    chan_info->shmem->length = sizeof(chan_info->shmem->msg_header) + len;
> +    chan_info->shmem->msg_header = pack_scmi_header(hdr);
> +
> +    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
> +           chan_info->shmem);
> +    if ( len > 0 && data )
> +        memcpy((void *)(chan_info->shmem->msg_payload), data, len);

Again, here we don't need a barrier because it is implicit in the SMC?

Don't we need to check that "len" fits in the shared memory?


> +    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->chan_id,
> +                  &resp);
> +
> +    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a0));
> +
> +    if ( resp.a0 )
> +        return -EOPNOTSUPP;

Why is that?


> +    return 0;
> +}
> +
> +static int check_scmi_status(int scmi_status)
> +{
> +    if ( scmi_status == SCMI_SUCCESS )
> +        return 0;
> +
> +    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
> +
> +    switch ( scmi_status )
> +    {
> +    case SCMI_NOT_SUPPORTED:
> +        return -EOPNOTSUPP;
> +    case SCMI_INVALID_PARAMETERS:
> +        return -EINVAL;
> +    case SCMI_DENIED:
> +        return -EACCES;
> +    case SCMI_NOT_FOUND:
> +        return -ENOENT;
> +    case SCMI_OUT_OF_RANGE:
> +        return -ERANGE;
> +    case SCMI_BUSY:
> +        return -EBUSY;
> +    case SCMI_COMMS_ERROR:
> +        return -ENOTCONN;
> +    case SCMI_GENERIC_ERROR:
> +        return -EIO;
> +    case SCMI_HARDWARE_ERROR:
> +        return -ENXIO;
> +    case SCMI_PROTOCOL_ERROR:
> +        return -EBADMSG;
> +    }
> +
> +    return -EINVAL;
> +}
> +
> +static int get_smc_response(struct scmi_channel *chan_info,
> +                            scmi_msg_header_t *hdr, void *data, int len)
> +{
> +    int recv_len;
> +    int ret;
> +
> +    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
> +
> +    ret = channel_is_free(chan_info);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;

I am not familiar with the spec (do you have a link?) but is it expected
that the channel is "free" when actually we want to read a message on
the channel?



> +    recv_len = chan_info->shmem->length - sizeof(chan_info->shmem->msg_header);
> +
> +    if ( recv_len < 0 )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Wrong size of smc message. Data may be invalid\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( recv_len > len )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Not enough buffer for message %d, expecting %d\n",
> +               recv_len, len);
> +        return -EINVAL;
> +    }
> +
> +    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
> +
> +    if ( recv_len > 0 )
> +    {
> +        memcpy(data, chan_info->shmem->msg_payload, recv_len);
> +    }
> +
> +    return 0;
> +}
> +
> +static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t *hdr, void *tx_data, int tx_size,
> +                       void *rx_data, int rx_size)
> +{
> +    int ret = 0;
> +
> +    if ( !hdr )
> +        return -EINVAL;
> +
> +    spin_lock(&channel->lock);
> +
> +    ret = send_smc_message(channel, hdr, tx_data, tx_size);
> +    if ( ret )
> +        goto clean;
> +
> +    ret = get_smc_response(channel, hdr, rx_data, rx_size);
> +clean:
> +    spin_unlock(&channel->lock);
> +
> +    return ret;
> +}
> +
> +static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)

please use parenthesis around the inner if (also in other places)


> +        if ( curr->chan_id == chan_id )
> +        {
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static struct scmi_channel *get_channel_by_domain(uint8_t domain_id)

Use domid_t for domain ids.

Also, wouldn't it be better to implement it as:

static inline struct scmi_channel *get_channel_by_domain(struct domain *d) {
    return d->arch.sci
}


> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> +        if ( curr->domain_id == domain_id )
> +        {
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static struct scmi_channel *aquire_scmi_channel(int domain_id)
> +{
> +    struct scmi_channel *curr;
> +    bool found = false;
> +
> +    ASSERT(domain_id != DOMID_INVALID && domain_id >= 0);
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> +        if ( (curr->domain_id == DOMID_INVALID)
> +            && (curr->chan_id != HYP_CHANNEL) )

If you use DOMID_XEN for HYP_CHANNEL, then this check becomes more
intuitive


> +        {
> +            curr->domain_id = domain_id;
> +            found = true;
> +            break;
> +        }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    if ( found )
> +        return curr;
> +
> +    return NULL;
> +}
> +
> +static void relinquish_scmi_channel(struct scmi_channel *channel)
> +{
> +    spin_lock(&scmi_data.channel_list_lock);
> +    ASSERT(channel != NULL);

the ASSERT could be before the spin_lock


> +    channel->domain_id = DOMID_INVALID;
> +    spin_unlock(&scmi_data.channel_list_lock);
> +}
> +
> +static struct scmi_channel *smc_create_channel(uint8_t chan_id,
> +                                               uint32_t func_id, uint64_t addr)
> +{
> +    struct scmi_channel *channel;
> +    mfn_t mfn;
> +
> +    channel = get_channel_by_id(chan_id);
> +    if ( channel )
> +        return ERR_PTR(EEXIST);
> +
> +    channel = xmalloc(struct scmi_channel);
> +    if ( !channel )
> +        return ERR_PTR(ENOMEM);
> +
> +    channel->chan_id = chan_id;
> +    channel->func_id = func_id;
> +    channel->domain_id = DOMID_INVALID;

I take you are using DOMID_INVALID to mark a channel used by Xen itself?
If so, then DOMID_XEN would be more appropriate.


> +    mfn = maddr_to_mfn(addr);
> +    channel->shmem = vmap(&mfn, 1);

One thing to be careful is the mapping attributes, for a couple of
reasons. As you might be aware, the ARM architecture forbids mismatching
attributes for mapping memory in different places in the system. So the
attributes that we use here must be the same used by the firmware
(and/or the guest.)

The second reason to be careful is that in the bindings example
Documentation/devicetree/bindings/firmware/arm,scmi.yaml the shared
memory is "mmio-sram", which is special. It is not supposed to be normal
memory, but it is OK to map it cacheable. Still, it might be more
appropriate to use ioremap_cache.


> +    if ( !channel->shmem )
> +    {
> +        xfree(channel);
> +        return ERR_PTR(ENOMEM);
> +    }
> +
> +    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->shmem);
> +    channel->paddr = addr;
> +    channel->shmem->channel_status = SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE;
> +    spin_lock_init(&channel->lock);
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_add(&channel->list, &scmi_data.channel_list);
> +    spin_unlock(&scmi_data.channel_list_lock);
> +    return channel;
> +}
> +
> +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
> +{
> +    return iomem_permit_access(d, paddr_to_pfn(addr),
> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> +}
> +
> +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
> +                                     uint64_t len)
> +{
> +    return iomem_deny_access(d, paddr_to_pfn(addr),
> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> +}
> +
> +static int dt_update_domain_range(struct domain *d, uint64_t addr,
> +                                  uint64_t size)
> +{
> +    struct dt_device_node *shmem_node;
> +    __be32 *hw_reg;
> +    const struct dt_property *pp;
> +    uint32_t len;
> +
> +    shmem_node = dt_find_compatible_node(NULL, NULL, "arm,scmi-shmem");

Here we are using "arm,scmi-shmem" while below we are checking for
"linux,scmi_mem". What's the difference?

Also, this function is looking for "arm,scmi-shmem" in dt_host and
replaces its value. For dom0less domUs we'll probably need a
make_scmi_node function to create the node from scratch like for
instance xen/arch/arm/domain_build.c:make_gic_domU_node.

I wonder if we had such a function whether it wouldn't be better to also
use it for dom0 (and blacklist the physical "arm,scmi-shmem" in
handle_node so that dom0 doesn't get the real shared memory information
by accident).


> +
> +    if ( !shmem_node )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI_SHMEM);
> +        return -EINVAL;
> +    }
> +
> +    pp = dt_find_property(shmem_node, "reg", &len);
> +    if ( !pp )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem node\n");
> +        return -ENOENT;
> +    }
> +
> +    hw_reg = pp->value;
> +    dt_set_range(&hw_reg, shmem_node, addr, size);
> +
> +    return 0;
> +}
> +
> +static void free_channel_list(void)
> +{
> +    struct scmi_channel *curr, *_curr;
> +
> +    spin_lock(&scmi_data.channel_list_lock);
> +    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, list)
> +    {
> +        vunmap(curr->shmem);
> +        list_del(&curr->list);
> +        xfree(curr);
> +    }
> +
> +    spin_unlock(&scmi_data.channel_list_lock);
> +}
> +
> +static __init bool scmi_probe(struct dt_device_node *scmi_node)
> +{
> +    struct dt_device_node *shmem_node;
> +    int ret, i;
> +    struct scmi_channel *channel, *agent_channel;
> +    int n_agents;
> +    scmi_msg_header_t hdr;
> +    struct rx_t {
> +        int32_t status;
> +        uint32_t attributes;
> +    } rx;

Should rx be defined at the top together with scmi_perms_tx_t and
others?


> +    uint32_t func_id;
> +
> +    ASSERT(scmi_node != NULL);
> +
> +    INIT_LIST_HEAD(&scmi_data.channel_list);
> +    spin_lock_init(&scmi_data.channel_list_lock);
> +
> +    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
> +    {
> +        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
> +        return false;
> +    }
> +
> +    shmem_node = dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);

>From the spec, it looks like you should be getting the shared memory
area from the phandle list "shmem".


> +    if ( IS_ERR_OR_NULL(shmem_node) )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Device tree error, can't parse shmem phandle %ld\n",
> +               PTR_ERR(shmem_node));
> +        return false;
> +    }
> +
> +    ret = dt_device_get_address(shmem_node, 0, &scmi_data.shmem_addr,
> +                                &scmi_data.shmem_size);
> +    if ( IS_ERR_VALUE(ret) )
> +        return false;
> +
> +    channel = smc_create_channel(HYP_CHANNEL, func_id, scmi_data.shmem_addr);
> +    if ( IS_ERR(channel) )
> +        return false;
> +
> +    hdr.id = SCMI_BASE_PROTOCOL_ATTIBUTES;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    ret = do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
> +    if ( ret )
> +        goto clean;
> +
> +    ret = check_scmi_status(rx.status);
> +    if ( ret )
> +        goto clean;
> +
> +    n_agents = FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
> +    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
> +
> +    n_agents = (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
> +        scmi_data.shmem_size / PAGE_SIZE : n_agents;
> +
> +    for ( i = 1; i < n_agents; i++ )
> +    {

Given that HYP_CHANNEL is actually zero, it looks like we could do
everything here in this loop but starting from i=0?


> +        uint32_t tx_agent_id = 0xFFFFFFFF;
> +        struct {
> +            int32_t status;
> +            uint32_t agent_id;
> +            char name[16];
> +        } da_rx;
> +
> +        agent_channel = smc_create_channel(i, func_id, scmi_data.shmem_addr +
> +                                           i * PAGE_SIZE);
> +        if ( IS_ERR(agent_channel) )
> +        {
> +            ret = PTR_ERR(agent_channel);
> +            goto clean;
> +        }
> +
> +        hdr.id = SCMI_BASE_DISCOVER_AGENT;
> +        hdr.type = 0;
> +        hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +        ret = do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
> +                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
> +        if ( ret )
> +            goto clean;
> +
> +        ret = check_scmi_status(da_rx.status);
> +        if ( ret )
> +            goto clean;
> +
> +        printk(XENLOG_DEBUG "scmi: status=0x%x id=0x%x name=%s\n",
> +                da_rx.status, da_rx.agent_id, da_rx.name);
> +
> +        agent_channel->agent_id = da_rx.agent_id;
> +    }
> +
> +    scmi_data.initialized = true;
> +    return true;
> +
> +clean:
> +    free_channel_list();
> +    return ret == 0;
> +}
> +
> +static int scmi_domain_init(struct domain *d)
> +{
> +    struct scmi_channel *channel;
> +    int ret;
> +
> +    if ( !scmi_data.initialized )
> +        return 0;
> +
> +    channel = aquire_scmi_channel(d->domain_id);
> +    if ( IS_ERR_OR_NULL(channel) )
> +        return -ENOENT;
> +
> +    printk(XENLOG_INFO "scmi: Aquire SCMI channel id = 0x%x , domain_id = %d"
> +           "paddr = 0x%lx\n", channel->chan_id, channel->domain_id,
> +           channel->paddr);
> +
> +    if ( is_hardware_domain(d) )
> +    {
> +        ret = map_memory_to_domain(d, scmi_data.shmem_addr,
> +                                   scmi_data.shmem_size);
> +        if ( IS_ERR_VALUE(ret) )
> +            goto error;
> +
> +        ret = dt_update_domain_range(d, channel->paddr, PAGE_SIZE);
> +        if ( IS_ERR_VALUE(ret) )
> +        {
> +            int rc = unmap_memory_from_domain(d, scmi_data.shmem_addr,
> +                                              scmi_data.shmem_size);
> +            if ( rc )
> +                printk(XENLOG_ERR "Unable to unmap_memory_from_domain\n");
> +
> +            goto error;
> +        }
> +    }

Is dom0 the only domain to get direct access to the shared memory
region? If so, I don't think it is a good idea to make Dom0 "special" in
this case.

Let me make an example: if we assign a device to a domU since boot, and
dom0 wants to change the frequency of a clock that affects the assigned
device (likely because it doesn't know it is assigned), then dom0
shouldn't be able to.  We might have to perform checks in Xen to make
sure dom0 cannot stop the clock for the assigned device. 

So I think it would be better if all domains are treated the same way in
the mediator unless really necessary.

On the other hand, if all domains get access to the shared memory
region, then I don't think this is likely the right place to create the
dom0 mapping. We probably want to do it in domain_build.c in a way that
can be reused for dom0less domUs.


In regards to shared memory: it looks like the only two functions to
access the real shared memory are send_smc_message and get_smc_response.
If that is the case, then we actually don't need to expose the real
shared memory to any of the domains.

We could simply:

- expose a regular normal memory region as dom0/domU channel memory
- on SMC trap, read from the "fake" shared memory and set the
  corresponding real shared memory on the appropriate channel
- issue the SMC call
- on return from SMC, copy over data from the real shared memory to the
  "fake" channel reagion

This is useful if we need to "filter" any of the SCMI commands and
options from the domains to the firmware, and also it is useful if the
channel memory is not page aligned. But if the permissions are
fine-grained enough and also the channel memory is page aligned (and
multiple of 4K in size) then we could map the memory.


> +
> +    d->arch.sci = channel;
> +
> +    return 0;
> +error:
> +    relinquish_scmi_channel(channel);
> +
> +    return ret;
> +}
> +
> +static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_devid)
> +{
> +    struct scmi_channel *channel, *agent_channel;
> +    scmi_msg_header_t hdr;
> +    scmi_perms_tx_t tx;
> +    struct rx_t {
> +        int32_t status;
> +        uint32_t attributes;
> +    } rx;
> +    int ret;
> +
> +    if ( !scmi_data.initialized )
> +        return 0;
> +
> +    printk(XENLOG_DEBUG "scmi: scmi_devid = %d\n", scmi_devid);
> +
> +    agent_channel = get_channel_by_domain(d->domain_id);
> +    if ( IS_ERR_OR_NULL(agent_channel) )
> +        return PTR_ERR(agent_channel);
> +
> +    channel = get_channel_by_id(HYP_CHANNEL);
> +    if ( IS_ERR_OR_NULL(channel) )
> +        return PTR_ERR(channel);
> +
> +    hdr.id = SCMI_BASE_SET_DEVICE_PERMISSIONS;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    tx.agent_id = agent_channel->agent_id;
> +    tx.device_id = scmi_devid;
> +    tx.flags = SCMI_ALLOW_ACCESS;
> +
> +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&rx));
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    ret = check_scmi_status(rx.status);
> +    if ( IS_ERR_VALUE(ret) )
> +        return ret;
> +
> +    return 0;
> +}
> +
> +static int scmi_add_dt_device(struct domain *d, struct dt_device_node *dev)
> +{
> +    uint32_t scmi_devid;
> +
> +    if ( (!scmi_data.initialized) || (!d->arch.sci) )
> +        return 0;
> +
> +    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
> +        return 0;

scmi_devid is another property that is not documented in the binding.


> +    printk(XENLOG_INFO "scmi: dt_node = %s\n", dt_node_full_name(dev));
> +
> +    return scmi_add_device_by_devid(d, scmi_devid);
> +}
> +
> +static int scmi_relinquish_resources(struct domain *d)
> +{
> +    int ret;
> +    struct scmi_channel *channel, *agent_channel;
> +    scmi_msg_header_t hdr;
> +    struct reset_agent_tx {
> +        uint32_t agent_id;
> +        uint32_t flags;
> +    } tx;
> +    uint32_t rx;
> +
> +    if ( !d->arch.sci )
> +        return 0;
> +
> +    agent_channel = d->arch.sci;
> +
> +    spin_lock(&agent_channel->lock);
> +    tx.agent_id = agent_channel->agent_id;
> +    spin_unlock(&agent_channel->lock);
> +
> +    channel = get_channel_by_id(HYP_CHANNEL);
> +    if ( !channel )
> +    {
> +        printk(XENLOG_ERR
> +               "scmi: Unable to get Hypervisor scmi channel for domain %d\n",
> +               d->domain_id);
> +        return -EINVAL;
> +    }
> +
> +    hdr.id = SCMI_BASE_RESET_AGENT_CONFIGURATION;
> +    hdr.type = 0;
> +    hdr.protocol = SCMI_BASE_PROTOCOL;
> +
> +    tx.flags = 0;
> +
> +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx));
> +    if ( ret )
> +        return ret;
> +
> +    ret = check_scmi_status(rx);
> +
> +    return ret;
> +}
> +
> +static void scmi_domain_destroy(struct domain *d)
> +{
> +    struct scmi_channel *channel;
> +
> +    if ( !d->arch.sci )
> +        return;
> +
> +    channel = d->arch.sci;
> +    spin_lock(&channel->lock);
> +
> +    relinquish_scmi_channel(channel);
> +    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
> +
> +    d->arch.sci = NULL;
> +
> +    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
> +    spin_unlock(&channel->lock);
> +    return;
> +}
> +
> +static bool scmi_handle_call(struct domain *d, void *args)
> +{
> +    bool res = false;
> +    struct scmi_channel *agent_channel;
> +    struct arm_smccc_res resp;
> +    struct cpu_user_regs *regs = args;
> +
> +    if ( !d->arch.sci )
> +        return false;
> +
> +    agent_channel = d->arch.sci;
> +    spin_lock(&agent_channel->lock);
> +
> +    if ( agent_channel->func_id != regs->x0 )
> +    {
> +        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
> +        goto unlock;
> +    }
> +
> +    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
> +                  agent_channel->chan_id, &resp);
> +
> +    set_user_reg(regs, 0, resp.a0);
> +    set_user_reg(regs, 1, resp.a1);
> +    set_user_reg(regs, 2, resp.a2);
> +    set_user_reg(regs, 3, resp.a3);
> +    res = true;
> +unlock:
> +    spin_unlock(&agent_channel->lock);
> +
> +    return res;
> +}
> +
> +static int scmi_get_channel_paddr(void *scmi_ops,
> +                           struct xen_arch_domainconfig *config)
> +{
> +    struct scmi_channel *agent_channel = scmi_ops;
> +
> +    if ( !agent_channel )
> +        return -EINVAL;
> +
> +    config->sci_agent_paddr = agent_channel->paddr;
> +    return 0;
> +}

I am still not sure why it couldn't be done by scmi_domain_init.


> +static const struct dt_device_match scmi_smc_match[] __initconst =
> +{
> +    DT_MATCH_SCMI_SMC,
> +    { /* sentinel */ },
> +};
> +
> +static const struct sci_mediator_ops scmi_ops =
> +{
> +    .probe = scmi_probe,
> +    .domain_init = scmi_domain_init,
> +    .domain_destroy = scmi_domain_destroy,
> +    .add_dt_device = scmi_add_dt_device,
> +    .relinquish_resources = scmi_relinquish_resources,
> +    .handle_call = scmi_handle_call,
> +    .get_channel_info = scmi_get_channel_paddr
> +};
> +
> +REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_SCMI_SMC,
> +                      scmi_smc_match, &scmi_ops);
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index 9180be5e86..a67237942d 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
>  
>  #define XEN_DOMCTL_CONFIG_SCI_NONE      0
> +#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
>  
>  struct xen_arch_domainconfig {
>      /* IN/OUT */
> -- 
> 2.27.0
> 


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 03:19:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 03:19:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248971.429430 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myQFh-0004Xp-OF; Sat, 18 Dec 2021 03:19:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248971.429430; Sat, 18 Dec 2021 03:19:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myQFh-0004Xi-Kz; Sat, 18 Dec 2021 03:19:17 +0000
Received: by outflank-mailman (input) for mailman id 248971;
 Sat, 18 Dec 2021 03:19:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myQFg-0004XY-Qn; Sat, 18 Dec 2021 03:19:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myQFg-0004KH-NW; Sat, 18 Dec 2021 03:19:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myQFg-0002w4-Ct; Sat, 18 Dec 2021 03:19:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myQFg-0003mA-CP; Sat, 18 Dec 2021 03:19:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lM3hekbU3Lec+Chq0MbR8OsRxJcRXpwQbDVfGy4umXY=; b=y5gxw6Pqre/IKgZwiXYfFDHlOH
	VdywGLyKwf9Uj1Zwql1bmNfPqbS22QQZN4MIhdTasmex6z8nswN+VjEhGmeTFnZwlM/4g3EtcScLX
	HfvnBHfa1oHgH7E37QvGh4/nsfin3Btjr9yYkt88IaIMmIPigwIlOleSbHjDe+nO3O4k=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167464-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167464: regressions - FAIL
X-Osstest-Failures:
    xen-unstable:build-i386:xen-build:fail:regression
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking
    xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=c81fc9f313c031f1201181cfb40e3c3ee599e04f
X-Osstest-Versions-That:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 03:19:16 +0000

flight 167464 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167464/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-i386                    6 xen-build                fail REGR. vs. 167455
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167455

Tests which did not succeed, but are not blocking:
 test-amd64-i386-livepatch     1 build-check(1)               blocked  n/a
 test-amd64-i386-migrupgrade   1 build-check(1)               blocked  n/a
 test-amd64-i386-pair          1 build-check(1)               blocked  n/a
 test-amd64-i386-qemut-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemut-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-amd  1 build-check(1)               blocked n/a
 test-amd64-i386-qemuu-rhel6hvm-intel  1 build-check(1)             blocked n/a
 test-amd64-i386-xl            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-pvshim     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64  1 build-check(1)         blocked n/a
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow  1 build-check(1)  blocked n/a
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a
 test-amd64-i386-xl-qemuu-ovmf-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemuu-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-shadow     1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-vhd        1 build-check(1)               blocked  n/a
 build-i386-libvirt            1 build-check(1)               blocked  n/a
 test-amd64-i386-xl-qemut-ws16-amd64  1 build-check(1)              blocked n/a
 test-amd64-i386-xl-qemut-win7-amd64  1 build-check(1)              blocked n/a
 test-amd64-coresched-i386-xl  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine       1 build-check(1)               blocked  n/a
 test-amd64-i386-examine-bios  1 build-check(1)               blocked  n/a
 test-amd64-i386-examine-uefi  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-amd64  1 build-check(1)               blocked  n/a
 test-amd64-i386-freebsd10-i386  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167455
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167455
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167455
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167455
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167455
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167455
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167455
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167455
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  c81fc9f313c031f1201181cfb40e3c3ee599e04f
baseline version:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24

Last test of basis   167455  2021-12-17 01:54:15 Z    1 days
Testing same since   167464  2021-12-17 15:38:22 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   fail    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           blocked 
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           blocked 
 test-amd64-coresched-i386-xl                                 blocked 
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           blocked 
 test-amd64-i386-qemuu-rhel6hvm-amd                           blocked 
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     blocked 
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     blocked 
 test-amd64-i386-freebsd10-amd64                              blocked 
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          blocked 
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          blocked 
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          blocked 
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          blocked 
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 blocked 
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         blocked 
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      blocked 
 test-amd64-i386-freebsd10-i386                               blocked 
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         blocked 
 test-amd64-i386-qemuu-rhel6hvm-intel                         blocked 
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    blocked 
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  blocked 
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         blocked 
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 blocked 
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    blocked 
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              blocked 
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    blocked 
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 blocked 
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 500 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 04:55:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 04:55:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.248983.429449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myRk5-0007aC-Ue; Sat, 18 Dec 2021 04:54:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 248983.429449; Sat, 18 Dec 2021 04:54:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myRk5-0007a5-Rg; Sat, 18 Dec 2021 04:54:45 +0000
Received: by outflank-mailman (input) for mailman id 248983;
 Sat, 18 Dec 2021 04:54:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myRk3-0007Zv-Vc; Sat, 18 Dec 2021 04:54:43 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myRk3-000651-Nj; Sat, 18 Dec 2021 04:54:43 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myRk3-0007Um-C3; Sat, 18 Dec 2021 04:54:43 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myRk3-0002NL-BZ; Sat, 18 Dec 2021 04:54:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=21WoneqsTSJDShR/xS4uypC6qAYb/v+xVJhSd/w9Lss=; b=QOuxikt4LILlBfQcOYnnULy9Ed
	AGdhlE+/pLeFeJudt31ViX1DSg+gEdiqJzFxqr6zsgIu7pxjXky4eYFht97GLmpSWEwdutuwxFfj7
	aG8sB94G3Qo/v1l1xz/5eMDi8ikNaSr3Scl7DKsw3YUmYQxJMfxRvHvJgRwTG1aQMfyk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167466-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167466: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=48c03a0e13f49e8dff9a8ac37fff43e00a0a9bb3
X-Osstest-Versions-That:
    qemuu=29eb5c2c86f935b0e9700fad2ecfe8a32b011d57
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 04:54:43 +0000

flight 167466 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167466/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167452
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167452
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167452
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167452
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167452
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167452
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167452
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167452
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                48c03a0e13f49e8dff9a8ac37fff43e00a0a9bb3
baseline version:
 qemuu                29eb5c2c86f935b0e9700fad2ecfe8a32b011d57

Last test of basis   167452  2021-12-16 20:09:29 Z    1 days
Testing same since   167466  2021-12-17 18:07:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Christian Borntraeger <borntraeger@linux.ibm.com>
  Collin Walling <walling@linux.ibm.com>
  Matthew Rosato <mjrosato@linux.ibm.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   29eb5c2c86..48c03a0e13  48c03a0e13f49e8dff9a8ac37fff43e00a0a9bb3 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 09:22:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 09:22:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249019.429467 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myVud-0004Qm-Ri; Sat, 18 Dec 2021 09:21:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249019.429467; Sat, 18 Dec 2021 09:21:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myVud-0004Qf-OS; Sat, 18 Dec 2021 09:21:55 +0000
Received: by outflank-mailman (input) for mailman id 249019;
 Sat, 18 Dec 2021 09:21:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Apz5=RD=suse.com=dfaggioli@srs-se1.protection.inumbo.net>)
 id 1myVub-0004P2-OR
 for xen-devel@lists.xenproject.org; Sat, 18 Dec 2021 09:21:53 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ee88b5aa-5fe3-11ec-85d3-df6b77346a89;
 Sat, 18 Dec 2021 10:21:51 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 036F41F387;
 Sat, 18 Dec 2021 09:21:50 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7245E1377E;
 Sat, 18 Dec 2021 09:21:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id GGnQGC2ovWGxAwAAMHmgww
 (envelope-from <dfaggioli@suse.com>); Sat, 18 Dec 2021 09:21:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee88b5aa-5fe3-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639819310; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=qWIpqQ866jaqBxBIGJbQdm5RkjAgGGMyg6WyGXAlqpA=;
	b=gaEBgoRt8SvtaKJq0BE9Bmw1M6IO0KnsP7Cv8zcqMCeGD/Qp6BkS9sDBQ8Bq9+5Dq4uGc8
	YFl9gZy6DoCQGHIc2QD+pkQ7Y6kTcmDuEoR4nhm9F4ruvn6zAsLxWt8tp8IL0DCiTRLy94
	n5Yn8O9br+8Ea17PrVERY5X+yyEh9lY=
Message-ID: <cc45051d695cb3f4ca0cc89f9e610c9e289bfe1c.camel@suse.com>
Subject: Re: [RFC 02/10] is_system_domain: replace open-coded instances
From: Dario Faggioli <dfaggioli@suse.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>, Wei Liu <wl@xen.org>, 
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>, Jan Beulich
 <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Roger Pau
 =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>, George Dunlap
 <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>, Stefano
 Stabellini <sstabellini@kernel.org>
Date: Sat, 18 Dec 2021 10:21:48 +0100
In-Reply-To: <20211217233437.13791-3-dpsmith@apertussolutions.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
	 <20211217233437.13791-3-dpsmith@apertussolutions.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-HFVG00BBEm3OMmMr9mAZ"
User-Agent: Evolution 3.42.1 (by Flathub.org) 
MIME-Version: 1.0


--=-HFVG00BBEm3OMmMr9mAZ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2021-12-17 at 18:34 -0500, Daniel P. Smith wrote:
> From: Christopher Clark <christopher.w.clark@gmail.com>
>=20
> There were several instances of open-coded domid range checking. This
> commit
> replaces those with the is_system_domain inline function.
>=20
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> ---
> =C2=A0xen/arch/x86/cpu/vpmu.c | 2 +-
> =C2=A0xen/common/domctl.c=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +-
> =C2=A0xen/common/sched/core.c | 4 ++--
> =C2=A0xen/include/xen/sched.h | 5 +++++
>
The */sched* bits:

Acked-by: Dario Faggioli <dfaggioli@suse.com>

But with a strong preference for renaming=20
is_system_domain_id() to is_system_domid(), as Andrew suggested.

Regards
--=20
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

--=-HFVG00BBEm3OMmMr9mAZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAmG9qCwACgkQFkJ4iaW4
c+7VaxAAonRSx3rLYJCFEN48KjyPjXrIKn7Cyz4GOR10PW1XlqfTW/hI2Tdr7N2H
KyBJ74Pe+b784Lljj/6IeihxdgIEjQTa2S8/lOJtbH9CpkiVLJI+woEqQ9rnHm0Y
nK3p+DGALsWWIwmVjtyE/q1lbcAC9bzrWwsBphbCUhuCxSdVC5OWzkGqyRp0Yt+F
Wu1tinCpHUGFVMhiy9dAeFHvNjpKSvOZTTUvKuk0mUQI6uSosRnZQ8dq+udn+x90
lC0pRseFbcGPO5/UbFnE1AYccm32+y/vYOXDla3jWSfLDAM3IfdsNpSGBGLKUZcE
Tjeb56m74vj7H73efrtXV1quwjszQOleBgxZo3aE63Xpcs30BqGX6MeBRn5fE0GV
eEnOnk0ToO4n2kkLhussFU0Sz1vuJDDgqFLZF7qmddh+57/vOGBFFAGM+A64EipE
6PieGnRUa4VOmbpVMCNiTq175KQI5zdiv6fpdqku+gLGSC+bw1yh0sqwdB20x2BP
Kai41bTfsZKLVfPC6In4Ty/y6RZGKZzuNzR6jFnmKhWZ/e3uCuYqx3BFFkfYtpwx
4OaM91xLOQRtP8j8EyWmFdRyla9xHnOzVL4PFhWa6B3DVPNeHChYwy+5QP2yGq50
QbNr5n6x5b+WZPVaYeR28elYp7AEltcI4MLO5f2M3pSaA8z2t68=
=pfhO
-----END PGP SIGNATURE-----

--=-HFVG00BBEm3OMmMr9mAZ--


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 09:53:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 09:53:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249035.429478 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myWOX-0008Ei-B2; Sat, 18 Dec 2021 09:52:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249035.429478; Sat, 18 Dec 2021 09:52:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myWOX-0008Eb-7R; Sat, 18 Dec 2021 09:52:49 +0000
Received: by outflank-mailman (input) for mailman id 249035;
 Sat, 18 Dec 2021 09:52:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myWOV-0008ER-Cx; Sat, 18 Dec 2021 09:52:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myWOV-0003UD-AQ; Sat, 18 Dec 2021 09:52:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myWOU-0006FX-W5; Sat, 18 Dec 2021 09:52:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myWOU-0001xK-Vb; Sat, 18 Dec 2021 09:52:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Ql6PjffVT8Wgdnx9WMyZrwiQHXLbYogn88qs9Q8qvck=; b=ukc1x/uDtGZHzx4fmM/wuXeGS7
	DIT01LpEqT2Bok4MwqbB2T19gbaIXR2zsQFJC2QTe2eB9ZozAaDT/qOwdG+E7ZJFzpnBSis0Rq+Qp
	12RIxJIchbNPf0KjzpCwOZcrhFdUEBkURU9JHN1lNP+UCBfQzMqbEGhhuCMCbY0ERvH0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167473-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167473: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=354644feb4914511413c7d177bbaf18be3216d13
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 09:52:46 +0000

flight 167473 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167473/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              354644feb4914511413c7d177bbaf18be3216d13
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  526 days
Failing since        151818  2020-07-11 04:18:52 Z  525 days  507 attempts
Testing same since   167473  2021-12-18 04:18:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90068 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 10:25:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 10:25:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249046.429489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myWty-0003fU-UO; Sat, 18 Dec 2021 10:25:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249046.429489; Sat, 18 Dec 2021 10:25:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myWty-0003fN-Qc; Sat, 18 Dec 2021 10:25:18 +0000
Received: by outflank-mailman (input) for mailman id 249046;
 Sat, 18 Dec 2021 10:25:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=v971=RD=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1myWty-0003fH-2C
 for xen-devel@lists.xenproject.org; Sat, 18 Dec 2021 10:25:18 +0000
Received: from galois.linutronix.de (galois.linutronix.de [193.142.43.55])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cab50059-5fec-11ec-9e60-abaf8a552007;
 Sat, 18 Dec 2021 11:25:16 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cab50059-5fec-11ec-9e60-abaf8a552007
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1639823115;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=nl4ddDnB1oKo0fcoNLd0K0Xuyht31044PvDVab+sRz0=;
	b=tn5AlMplZSyHPZ4eu4NMTH2tosi8XfO1/mNklSs+ImTlR8P5gfKJgKJLi6NJ4TFAklevD0
	1avFcMo8k3hGWDd1Iy/rc1ZPeM7eACV1BbuVnX4QY/eXDhd48j/Sh4CvcSDSL9IbisUp7z
	caDqaSpU9ud+i2NkshpSak1RSaSSAW8O+tSdpPZC1vhiTXp+kGqQePG8eL1c519ZMa10bj
	4A/PikhGc/SgM12CbM14omQUZtwMCPY58ymXGe2D8aFAWliD8DPNhbbTAoxPao+HsDqHhF
	X3Af3aTvpYn3Z94vxqiwZNOhBtC+RdSsTPCSCauo8T9TOXtM5vssh7kfd7kvGQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1639823115;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=nl4ddDnB1oKo0fcoNLd0K0Xuyht31044PvDVab+sRz0=;
	b=rrfck+zS5tliLA0jRIoJ5g0PCCswYFJD7whCSlQHRXayW7rMo7mOMzACWAo8/AkVTaI5km
	I03oaHuan7mQiiAA==
To: Nathan Chancellor <nathan@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Cedric Le Goater
 <clg@kaod.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Juergen
 Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, Arnd Bergmann
 <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org,
 Bjorn Helgaas <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>,
 Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>,
 Tero Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, Will
 Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Joerg
 Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org, Jassi Brar
 <jassisinghbrar@gmail.com>, Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
In-Reply-To: <Yb0PaCyo/6z3XOlf@archlinux-ax161>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.900929381@linutronix.de>
 <Yb0PaCyo/6z3XOlf@archlinux-ax161>
Date: Sat, 18 Dec 2021 11:25:14 +0100
Message-ID: <87v8zm9pmd.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Dec 17 2021 at 15:30, Nathan Chancellor wrote:
> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote:
> I just bisected a boot failure on my AMD test desktop to this patch as
> commit f48235900182 ("PCI/MSI: Simplify pci_irq_get_affinity()") in
> -next. It looks like there is a problem with the NVMe drive after this
> change according to the logs. Given that the hard drive is not getting
> mounted for journald to write logs to, I am not really sure how to get
> them from the machine so I have at least taken a picture of what I see
> on my screen; open to ideas on that front!

Bah. Fix below.

Thanks,

        tglx
---
diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
index 71802410e2ab..9b4910befeda 100644
--- a/drivers/pci/msi/msi.c
+++ b/drivers/pci/msi/msi.c
@@ -1100,7 +1100,7 @@ EXPORT_SYMBOL(pci_irq_vector);
  */
 const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
 {
-	int irq = pci_irq_vector(dev, nr);
+	int idx, irq = pci_irq_vector(dev, nr);
 	struct msi_desc *desc;
 
 	if (WARN_ON_ONCE(irq <= 0))
@@ -1113,7 +1113,10 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
 
 	if (WARN_ON_ONCE(!desc->affinity))
 		return NULL;
-	return &desc->affinity[nr].mask;
+
+	/* MSI has a mask array in the descriptor. */
+	idx = dev->msi_enabled ? nr : 0;
+	return &desc->affinity[idx].mask;
 }
 EXPORT_SYMBOL(pci_irq_get_affinity);
 



From xen-devel-bounces@lists.xenproject.org Sat Dec 18 10:40:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 10:40:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249049.429500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myX8h-0006JQ-9G; Sat, 18 Dec 2021 10:40:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249049.429500; Sat, 18 Dec 2021 10:40:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myX8h-0006JJ-5w; Sat, 18 Dec 2021 10:40:31 +0000
Received: by outflank-mailman (input) for mailman id 249049;
 Sat, 18 Dec 2021 10:40:30 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myX8g-0006J9-22; Sat, 18 Dec 2021 10:40:30 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myX8f-0004Mt-Qp; Sat, 18 Dec 2021 10:40:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myX8f-000837-EJ; Sat, 18 Dec 2021 10:40:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myX8f-00009z-Do; Sat, 18 Dec 2021 10:40:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Zq9kTX2f3uY5N0r6f1/S38QOadhha29mNzYkq9bG3T0=; b=DQLBkYtgOm2zUTj9GUCNpEgPkZ
	vCdG3CiAtuQaL/MmzWVFnNwfDEb2r6SglNn/E4imDcvqLeLbjb7LxHV3Nu4yghW9WDk4XezHeuqgz
	iQlgL+CJAMNujc1z7gVghrB0pyfVFmoLQCt8kMZSSA3QaE4awnrIh3rOLpqJblCaxfB8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167470-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167470: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9eaa88c7036eda3f6c215f87ca693594cf90559b
X-Osstest-Versions-That:
    linux=6441998e2e37131b0a4c310af9156d79d3351c16
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 10:40:29 +0000

flight 167470 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167470/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167461
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167461
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167461
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167461
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167461
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167461
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167461
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167461
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                9eaa88c7036eda3f6c215f87ca693594cf90559b
baseline version:
 linux                6441998e2e37131b0a4c310af9156d79d3351c16

Last test of basis   167461  2021-12-17 13:00:28 Z    0 days
Testing same since   167470  2021-12-18 02:04:27 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alejandro Concepcion-Rodriguez <asconcepcion@acoro.eu>
  Alex Deucher <alexander.deucher@amd.com>
  Alyssa Ross <hi@alyssa.is>
  Bin Meng <bin.meng@windriver.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Coly Li <colyli@suse.de>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Dave Jiang <dave.jiang@intel.com>
  David Sterba <dsterba@suse.com>
  Evan Quan <evan.quan@amd.com>
  Filipe Manana <fdmanana@suse.com>
  George Kennedy <george.kennedy@oracle.com>
  George Kennedy<george.kennedy@oracle.com>
  Guchun Chen <guchun.chen@amd.com>
  Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
  Hawking Zhang <Hawking.Zhang@amd.com>
  Javier Martinez Canillas <javierm@redhat.com>
  Jens Axboe <axboe@kernel.dk>
  Jianglei Nie <niejianglei2021@163.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  John Garry <john.garry@huawei.com>
  Josef Bacik <josef@toxicpanda.com>
  Lang Yu <lang.yu@amd.com>
  Le Ma <le.ma@amd.com>
  Lin Feng <linf@wangsu.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Lucas De Marchi <lucas.demarchi@intel.com>
  Mario Limonciello <mario.limonciello@amd.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Maxime Ripard <maxime@cerno.tech>
  Naohiro Aota <naohiro.aota@wdc.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Palmer Dabbelt <palmer@rivosinc.com>
  Paul Moore <paul@paul-moore.com>
  Pavle Kotarac <Pavle.Kotarac@amd.com>
  Peter Ujfalusi <peter.ujfalusi@gmail.com>
  Rodrigo Vivi <rodrigo.vivi@intel.com>
  Scott Mayhew <smayhew@redhat.com>
  Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
  Tejun Heo <tj@kernel.org>
  Thomas Zimmermann <tzimmermann@suse.de>
  Tim Gardner <tim.gardner@canonical.com>
  Vignesh Raghavendra <vigneshr@ti.com>
  Vincent Pelletier <plr.vincent@gmail.com>
  Vinod Koul <vkoul@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6441998e2e37..9eaa88c7036e  9eaa88c7036eda3f6c215f87ca693594cf90559b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 13:35:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 13:35:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249098.429558 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myZrX-0000MS-U4; Sat, 18 Dec 2021 13:34:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249098.429558; Sat, 18 Dec 2021 13:34:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myZrX-0000ML-Qr; Sat, 18 Dec 2021 13:34:59 +0000
Received: by outflank-mailman (input) for mailman id 249098;
 Sat, 18 Dec 2021 13:34:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myZrX-0000M0-2q; Sat, 18 Dec 2021 13:34:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myZrX-0007De-0j; Sat, 18 Dec 2021 13:34:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myZrW-0007iU-NJ; Sat, 18 Dec 2021 13:34:58 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myZrW-0008SQ-Me; Sat, 18 Dec 2021 13:34:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WmUnGm/JK4Y1XTku+EqyqFZSB/x8s/BkKQluSZMsm30=; b=Q93FyUeoaI8bxkHweHhUZiZjUF
	6bNtIN40jlGoWYhbiEJ5XyarWsyk11OhCtP21vlLZOjmOQZnlJcka0O9bEOkARad5E9Qr61JGooTj
	JXANrEBtmZHKF94DF1JzTC81w5nlkXTMyFeNbP1L/LkHlpVNeJ2T1z4T+Cj5zEUXFyw8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167471-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167471: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=dc27c174b2fc1ba0697ed96dc96066c272e09c24
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 13:34:58 +0000

flight 167471 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167471/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167455
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167455
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167455
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167455
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167455
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167455
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167455
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167455
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167455
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167455
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167455
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167455
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  dc27c174b2fc1ba0697ed96dc96066c272e09c24

Last test of basis   167455  2021-12-17 01:54:15 Z    1 days
Failing since        167464  2021-12-17 15:38:22 Z    0 days    2 attempts
Testing same since   167471  2021-12-18 03:23:00 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Christian Lindig <christian.lindig@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   dc27c174b2..8e3edefb88  8e3edefb880caeeaaf80123d5599139e8c2c9ecf -> master


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 16:18:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 16:18:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249150.429649 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mycPh-0002O3-So; Sat, 18 Dec 2021 16:18:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249150.429649; Sat, 18 Dec 2021 16:18:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mycPh-0002Nw-Pt; Sat, 18 Dec 2021 16:18:25 +0000
Received: by outflank-mailman (input) for mailman id 249150;
 Sat, 18 Dec 2021 16:18:24 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mycPg-0002Nm-CH; Sat, 18 Dec 2021 16:18:24 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mycPg-00029X-7z; Sat, 18 Dec 2021 16:18:24 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mycPf-0003Vs-Rb; Sat, 18 Dec 2021 16:18:23 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mycPf-0003kZ-RB; Sat, 18 Dec 2021 16:18:23 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=mFqkkm/2zduSTah52IgXphE6OD5EjMQMfWOgNEfLn9o=; b=QGDA2WvRv/KlkoqQDq1mQ/2aVT
	z4v9E35lRduoMdoI1E++Z2RBaoMdwi932FZ0G8VmFOLrtReZh5+NpoMtqosBWZkFgg5+UqcBsnaMC
	Yb3DFFYL4g5L4OmRknMYzBu3W6l8JtpySxWltmyqQhKkA9YpuUJ2BBGT/Q/5530iZo/o=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167475-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167475: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-i386-libvirt-pair:guest-migrate/dst_host/src_host/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=90978e15bc9a23c208b25bf7ea697a5d0925562b
X-Osstest-Versions-That:
    qemuu=48c03a0e13f49e8dff9a8ac37fff43e00a0a9bb3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 16:18:23 +0000

flight 167475 qemu-mainline real [real]
flight 167477 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167475/
http://logs.test-lab.xenproject.org/osstest/logs/167477/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-pair 28 guest-migrate/dst_host/src_host/debian.repeat fail pass in 167477-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167466
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167466
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167466
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167466
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167466
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167466
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167466
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167466
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                90978e15bc9a23c208b25bf7ea697a5d0925562b
baseline version:
 qemuu                48c03a0e13f49e8dff9a8ac37fff43e00a0a9bb3

Last test of basis   167466  2021-12-17 18:07:11 Z    0 days
Testing same since   167475  2021-12-18 04:56:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alexey Kardashevskiy <aik@ozlabs.ru>
  Christophe Lombard <clombard@linux.vnet.ibm.com>
  Cédric Le Goater <clg@kaod.org>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Fabiano Rosas <farosas@linux.ibm.com>
  Laurent Vivier <laurent@vivier.eu>
  Leonardo Garcia <lagarcia@br.ibm.com>
  Lucas Mateus Castro (alqotel) <lucas.araujo@eldorado.org.br>
  Matheus Ferst <matheus.ferst@eldorado.org.br>
  Paolo Bonzini <pbonzini@redhat.com>
  Peter Maydell <peter.maydell@linaro.org>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>
  Victor Colombo <victor.colombo@eldorado.org.br>
  Zhang Chen <chen.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 fail    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   48c03a0e13..90978e15bc  90978e15bc9a23c208b25bf7ea697a5d0925562b -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 19:05:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 19:05:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249187.429661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myf19-0003h5-GL; Sat, 18 Dec 2021 19:05:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249187.429661; Sat, 18 Dec 2021 19:05:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myf19-0003gy-Ct; Sat, 18 Dec 2021 19:05:15 +0000
Received: by outflank-mailman (input) for mailman id 249187;
 Sat, 18 Dec 2021 19:05:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=WtF6=RD=kernel.org=nathan@srs-se1.protection.inumbo.net>)
 id 1myf18-0003gs-43
 for xen-devel@lists.xenproject.org; Sat, 18 Dec 2021 19:05:14 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6c68c27a-6035-11ec-9e60-abaf8a552007;
 Sat, 18 Dec 2021 20:05:12 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 5D7DCB80781;
 Sat, 18 Dec 2021 19:05:10 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1B24C36AE1;
 Sat, 18 Dec 2021 19:05:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6c68c27a-6035-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1639854309;
	bh=I6eVKACPJvnI+llvjluP6wdaS6TfkgpPNWmOCTJo2Tw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=UMWo6BEBXL2vg9tHjb81KQokUbnD5ds+HV7ckML33awGfTpej3ik5Kh3h6cfpyyqb
	 iFD4s+bZZ21aukh38a1Cdxv3Q680qbPDCrFRz4IUjxJcGtElf80NOxI08WBU35o5KO
	 DNmZrv9Ka1wwC0RRN+bNzFNGCbR++Trade1JV0IXvYj4pEQ88pbWel1kl4y4dka9Vy
	 v30sM76UJThM+xQ2PiEuVOz+Jtb0pMSsUUbW+ySVU2WJmK0RZD3dGbXyS/PYo1GOwF
	 IJYYSA0Plrin3iwRee9bWx/w6bJtImnOGvLxXhdQqwr2xAa+xaDpfppDhnDsxbFplJ
	 vGcX7+wVGtViQ==
Date: Sat, 18 Dec 2021 12:04:59 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>,
	Megha Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	linux-pci@vger.kernel.org, Cedric Le Goater <clg@kaod.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas <bhelgaas@google.com>,
	Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Peter Ujfalusi <peter.ujfalusi@gmail.com>,
	Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
Message-ID: <Yb4w2wVvIwN7qaNy@archlinux-ax161>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.900929381@linutronix.de>
 <Yb0PaCyo/6z3XOlf@archlinux-ax161>
 <87v8zm9pmd.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87v8zm9pmd.ffs@tglx>

On Sat, Dec 18, 2021 at 11:25:14AM +0100, Thomas Gleixner wrote:
> On Fri, Dec 17 2021 at 15:30, Nathan Chancellor wrote:
> > On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote:
> > I just bisected a boot failure on my AMD test desktop to this patch as
> > commit f48235900182 ("PCI/MSI: Simplify pci_irq_get_affinity()") in
> > -next. It looks like there is a problem with the NVMe drive after this
> > change according to the logs. Given that the hard drive is not getting
> > mounted for journald to write logs to, I am not really sure how to get
> > them from the machine so I have at least taken a picture of what I see
> > on my screen; open to ideas on that front!
> 
> Bah. Fix below.

Tested-by: Nathan Chancellor <nathan@kernel.org>

> Thanks,
> 
>         tglx
> ---
> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> index 71802410e2ab..9b4910befeda 100644
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -1100,7 +1100,7 @@ EXPORT_SYMBOL(pci_irq_vector);
>   */
>  const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>  {
> -	int irq = pci_irq_vector(dev, nr);
> +	int idx, irq = pci_irq_vector(dev, nr);
>  	struct msi_desc *desc;
>  
>  	if (WARN_ON_ONCE(irq <= 0))
> @@ -1113,7 +1113,10 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>  
>  	if (WARN_ON_ONCE(!desc->affinity))
>  		return NULL;
> -	return &desc->affinity[nr].mask;
> +
> +	/* MSI has a mask array in the descriptor. */
> +	idx = dev->msi_enabled ? nr : 0;
> +	return &desc->affinity[idx].mask;
>  }
>  EXPORT_SYMBOL(pci_irq_get_affinity);
>  
> 


From xen-devel-bounces@lists.xenproject.org Sat Dec 18 20:26:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 20:26:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249192.429672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mygH9-00044f-Dk; Sat, 18 Dec 2021 20:25:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249192.429672; Sat, 18 Dec 2021 20:25:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mygH9-00044Y-AE; Sat, 18 Dec 2021 20:25:51 +0000
Received: by outflank-mailman (input) for mailman id 249192;
 Sat, 18 Dec 2021 20:25:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=0T15=RD=kaod.org=clg@srs-se1.protection.inumbo.net>)
 id 1mygH7-00044S-MX
 for xen-devel@lists.xenproject.org; Sat, 18 Dec 2021 20:25:49 +0000
Received: from 3.mo548.mail-out.ovh.net (3.mo548.mail-out.ovh.net
 [188.165.32.156]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ae9468fc-6040-11ec-9e60-abaf8a552007;
 Sat, 18 Dec 2021 21:25:47 +0100 (CET)
Received: from mxplan5.mail.ovh.net (unknown [10.109.138.121])
 by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 3A38A20143;
 Sat, 18 Dec 2021 20:25:43 +0000 (UTC)
Received: from kaod.org (37.59.142.97) by DAG4EX1.mxp5.local (172.16.2.31)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Sat, 18 Dec
 2021 21:25:41 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ae9468fc-6040-11ec-9e60-abaf8a552007
Authentication-Results: garm.ovh; auth=pass (GARM-97G0022d2cf51f-56be-41f7-b9ac-2c271cc1d1bb,
                    B1F2FCB93787BB0875C07E604CDE73E7ADF677F7) smtp.auth=clg@kaod.org
X-OVh-ClientIp: 90.11.79.163
Message-ID: <ee5db32f-c21e-287f-2a19-94c1ba6e8217@kaod.org>
Date: Sat, 18 Dec 2021 21:25:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
Content-Language: en-US
To: Thomas Gleixner <tglx@linutronix.de>, Nathan Chancellor
	<nathan@kernel.org>
CC: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
	Marc Zygnier <maz@kernel.org>, Alex Williamson <alex.williamson@redhat.com>,
	Kevin Tian <kevin.tian@intel.com>, Jason Gunthorpe <jgg@nvidia.com>, Megha
 Dey <megha.dey@intel.com>, Ashok Raj <ashok.raj@intel.com>,
	<linux-pci@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>, Arnd
 Bergmann <arnd@arndb.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin
 Herrenschmidt <benh@kernel.crashing.org>, <linuxppc-dev@lists.ozlabs.org>,
	Bjorn Helgaas <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero
 Kristo <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, Vinod Koul <vkoul@kernel.org>,
	<dmaengine@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>, Will Deacon
	<will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Joerg Roedel
	<joro@8bytes.org>, <iommu@lists.linux-foundation.org>, Jassi Brar
	<jassisinghbrar@gmail.com>, Peter Ujfalusi <peter.ujfalusi@gmail.com>, Sinan
 Kaya <okaya@kernel.org>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.900929381@linutronix.de> <Yb0PaCyo/6z3XOlf@archlinux-ax161>
 <87v8zm9pmd.ffs@tglx>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
In-Reply-To: <87v8zm9pmd.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [37.59.142.97]
X-ClientProxiedBy: DAG1EX1.mxp5.local (172.16.2.1) To DAG4EX1.mxp5.local
 (172.16.2.31)
X-Ovh-Tracer-GUID: 2aa807ab-02a3-4ad6-8447-d206fc92c88e
X-Ovh-Tracer-Id: 4883872323797683005
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: -100
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrleekgddufeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepieegvdffkeegfeetuddttddtveduiefhgeduffekiedtkeekteekhfffleevleelnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdeljeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehokhgrhigrsehkvghrnhgvlhdrohhrgh

On 12/18/21 11:25, Thomas Gleixner wrote:
> On Fri, Dec 17 2021 at 15:30, Nathan Chancellor wrote:
>> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote:
>> I just bisected a boot failure on my AMD test desktop to this patch as
>> commit f48235900182 ("PCI/MSI: Simplify pci_irq_get_affinity()") in
>> -next. It looks like there is a problem with the NVMe drive after this
>> change according to the logs. Given that the hard drive is not getting
>> mounted for journald to write logs to, I am not really sure how to get
>> them from the machine so I have at least taken a picture of what I see
>> on my screen; open to ideas on that front!
> 
> Bah. Fix below.

That's a fix for the issue I was seeing on pseries with NVMe.

Tested-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> Thanks,
> 
>          tglx
> ---
> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> index 71802410e2ab..9b4910befeda 100644
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -1100,7 +1100,7 @@ EXPORT_SYMBOL(pci_irq_vector);
>    */
>   const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>   {
> -	int irq = pci_irq_vector(dev, nr);
> +	int idx, irq = pci_irq_vector(dev, nr);
>   	struct msi_desc *desc;
>   
>   	if (WARN_ON_ONCE(irq <= 0))
> @@ -1113,7 +1113,10 @@ const struct cpumask *pci_irq_get_affinity(struct pci_dev *dev, int nr)
>   
>   	if (WARN_ON_ONCE(!desc->affinity))
>   		return NULL;
> -	return &desc->affinity[nr].mask;
> +
> +	/* MSI has a mask array in the descriptor. */
> +	idx = dev->msi_enabled ? nr : 0;
> +	return &desc->affinity[idx].mask;
>   }
>   EXPORT_SYMBOL(pci_irq_get_affinity);
>   
> 



From xen-devel-bounces@lists.xenproject.org Sat Dec 18 21:29:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 18 Dec 2021 21:29:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249198.429682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myhFu-0002OP-4M; Sat, 18 Dec 2021 21:28:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249198.429682; Sat, 18 Dec 2021 21:28:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myhFu-0002OI-1P; Sat, 18 Dec 2021 21:28:38 +0000
Received: by outflank-mailman (input) for mailman id 249198;
 Sat, 18 Dec 2021 21:28:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myhFs-0002O8-VT; Sat, 18 Dec 2021 21:28:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myhFs-0007Rc-Tq; Sat, 18 Dec 2021 21:28:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myhFs-0004rZ-Hw; Sat, 18 Dec 2021 21:28:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myhFs-0007Ly-HU; Sat, 18 Dec 2021 21:28:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=UgmJQ4WSFxDIrv59eCnFbmXz6Q8ErUxZA5o8bmaK/gk=; b=4kronvUnmHmZRpKwdq2WkyX/8A
	U82Zxuepl7Uay+4xkVLNYVkei6M/mk/bAaTW//ZmYVEg3EGyuSx4oH3m/UdnzE5kk8Szmu+d3fmaW
	h8Uo+mgWW+CWFQ/Yd5NroVDTKByHbNdUDObQNqX+2lCdz9XprvyXvqrh4nSIFKhdBEZs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167478-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 167478: tolerable FAIL - PUSHED
X-Osstest-Failures:
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=f9af71744a9f9a5d4804edcfcd14fd85e2d8a83b
X-Osstest-Versions-That:
    seabios=2dd4b9b3f84019668719344b40dba79d681be41c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 18 Dec 2021 21:28:36 +0000

flight 167478 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167478/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167120
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167120
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167120
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167120
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167120
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              f9af71744a9f9a5d4804edcfcd14fd85e2d8a83b
baseline version:
 seabios              2dd4b9b3f84019668719344b40dba79d681be41c

Last test of basis   167120  2021-12-04 23:14:34 Z   13 days
Testing same since   167478  2021-12-18 17:11:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Pei <andy.pei@intel.com>
  Ding Limin <dinglimin@cmss.chinamobile.com>
  Eduardo Habkost <ehabkost@redhat.com>
  Gerd Hoffmann <kraxel@redhat.com>
  Igor Mammedov <imammedo@redhat.com>
  Igor Mammedov imammedo@redhat.com
  Laurent Vivier <lvivier@redhat.com>
  Michael S. Tsirkin <mst@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/seabios.git
   2dd4b9b..f9af717  f9af71744a9f9a5d4804edcfcd14fd85e2d8a83b -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 05:47:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 05:47:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249184.429694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myp1k-0006ep-LP; Sun, 19 Dec 2021 05:46:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249184.429694; Sun, 19 Dec 2021 05:46:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1myp1k-0006eO-Dq; Sun, 19 Dec 2021 05:46:32 +0000
Received: by outflank-mailman (input) for mailman id 249184;
 Sat, 18 Dec 2021 18:36:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wRCJ=RD=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1myeZ1-0000cX-TY
 for xen-devel@lists.xen.org; Sat, 18 Dec 2021 18:36:11 +0000
Received: from mail-io1-f47.google.com (mail-io1-f47.google.com
 [209.85.166.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5d68cd8e-6031-11ec-9e60-abaf8a552007;
 Sat, 18 Dec 2021 19:36:10 +0100 (CET)
Received: by mail-io1-f47.google.com with SMTP id e128so7755911iof.1
 for <xen-devel@lists.xen.org>; Sat, 18 Dec 2021 10:36:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5d68cd8e-6031-11ec-9e60-abaf8a552007
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=6ceRzcVhEh6kFYWkjslDz9MBwsAZbmz99HyxNoE48zA=;
        b=hABV3h5Wdg5Ar8LXPB+heXGfWGRjgDYDotW1oPAz5v/0bNz6rS8nGCay9rB+/jBF5q
         KrAj1E1lOJsADWJ/IOZ5hIx6h1jOuiDNahX8tk4W0sQOkDGOF37EYsn4cCAdVmeVcDAC
         yopB7eJ2gdhDf3xQV1t1x5l/k0GaP7NIwPwkJtQO1qnrNSlPAGf9c1SXXtHfqcbCT5Zk
         kDuZ6YNXJsDh/J0c0YpIT4sJXJW3s7WQ7WUVrEV72qXm6UZxgkAPfhbcVaphWDgpAEjv
         eTrlOYAKnvOn5NL7Rt+YX0b2ejerB9aYMNyHbO78e2suK55fGlBMTuRafkUGGE5xHije
         v+sQ==
X-Gm-Message-State: AOAM530F5qB4BnAlQqh0Nosux6BQfTadSqbFQ+ZJKgf/0UEGVMMAil8l
	U04E4RrAuEsZ6y7mZPKbUzd0vd+FwWGpqLuFY2F9GH/kDpdWcQ==
X-Google-Smtp-Source: ABdhPJyczt3ZsZgeCwXSLpjsLfFKg1AY0D4omnYVn4Bmz1Uzf1CpJvnXRPOJAScfudDMhDME4u4djOMQOIOLlpsyIGw=
X-Received: by 2002:a6b:b886:: with SMTP id i128mr4638128iof.151.1639852567066;
 Sat, 18 Dec 2021 10:36:07 -0800 (PST)
MIME-Version: 1.0
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Sun, 19 Dec 2021 02:35:56 +0800
Message-ID: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
Subject: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

Hi all,

I ran into the following error report in the DOM0 kernel after a recent upgrade:
[  501.840816] vif vif-1-0 vif1.0: Cross page boundary, txp->offset:
2872, size: 1460
[  501.840828] vif vif-1-0 vif1.0: fatal error; disabling device
[  501.841076] xenbr0: port 2(vif1.0) entered disabled state
Once this error happens, the DOM-U behind this vif is no-longer
accessible. And recreating the same DOM-U does not fix the problem.
Only a reboot on the physical host machine helps.

The problem showed up after a recent upgrade on the DOM-U OS from
FreeNAS 11.3 to TrueNAS 12.0U7 and breaks the iSCSI service while
leaving other services like NFS intact.
The underlying OS for the NAS is FreeBSD, version 11.3 and 12.2 respectively.
So far I have tried the following combos:
- Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 11.3 DOM-U: Good
- Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
- Linux 5.10 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
- Linux 5.10 DOM0 + XEN 4.11 + FreeBSD 12.2 DOM-U: Regressed

I plan to try out the XEN 4.14 version which is the latest I can get
from the distro (Debian).
If that still does not fix the problem, I would build the 4.16 version
from source as my last resort.

I have to admit that this trial process is blind as I have no idea
which component in the combo is to be blamed. Is it a bug in the
backend-driver, frontend-driver or the hypervisor itself? Or due to
incompatible versions? Any suggestion on other diagnose ideas (e.g.
debug logs) will be welcome, while I work on the planned experiments.

Thanks,
G.R.


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 06:10:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 06:10:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249223.429704 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mypOu-0001qx-FD; Sun, 19 Dec 2021 06:10:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249223.429704; Sun, 19 Dec 2021 06:10:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mypOu-0001qq-CL; Sun, 19 Dec 2021 06:10:28 +0000
Received: by outflank-mailman (input) for mailman id 249223;
 Sun, 19 Dec 2021 06:10:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=CgLP=RE=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mypOt-0001qk-Kl
 for xen-devel@lists.xen.org; Sun, 19 Dec 2021 06:10:27 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b7f8103-6092-11ec-9e60-abaf8a552007;
 Sun, 19 Dec 2021 07:10:26 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 63A8B21108;
 Sun, 19 Dec 2021 06:10:25 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 459DC13A8A;
 Sun, 19 Dec 2021 06:10:25 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OrX8DtHMvmHWTQAAMHmgww
 (envelope-from <jgross@suse.com>); Sun, 19 Dec 2021 06:10:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b7f8103-6092-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1639894225; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BHNimrZGb8uhPmDjX+gXjo/vE9VEc0DBrDH+CA3VnpQ=;
	b=pNMQzk7XeWhfJrqEUxz0xT0YMD0JSB3KmcvRbm5jp4ZN60yhlbM/aw1isMPDu+vRmFNRF2
	zg07B1MD4LCv8Dx4mbxDHPj02h+DwipxuMbWY9hjgSU+gjMHwU1+CLFsDV1ZyMqWnT9tvx
	vrLK2n+et/COYvxzyaeLTgzJl8XWjNk=
To: "G.R." <firemeteor@users.sourceforge.net>,
 xen-devel <xen-devel@lists.xen.org>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <be77e398-7d0b-ceb0-4dac-d5456c9800c4@suse.com>
Date: Sun, 19 Dec 2021 07:10:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="uMsSwA2CT25mX5P50N0gBF5OnSglFqAZs"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--uMsSwA2CT25mX5P50N0gBF5OnSglFqAZs
Content-Type: multipart/mixed; boundary="O8l6cQNr5w3QZ7Fg27OH8aHbNgEazLysa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: "G.R." <firemeteor@users.sourceforge.net>,
 xen-devel <xen-devel@lists.xen.org>
Message-ID: <be77e398-7d0b-ceb0-4dac-d5456c9800c4@suse.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
In-Reply-To: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>

--O8l6cQNr5w3QZ7Fg27OH8aHbNgEazLysa
Content-Type: multipart/mixed;
 boundary="------------6EA7CEFA39964D99A1C8CA13"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------6EA7CEFA39964D99A1C8CA13
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 18.12.21 19:35, G.R. wrote:
> Hi all,
>=20
> I ran into the following error report in the DOM0 kernel after a recent=
 upgrade:
> [  501.840816] vif vif-1-0 vif1.0: Cross page boundary, txp->offset:
> 2872, size: 1460
> [  501.840828] vif vif-1-0 vif1.0: fatal error; disabling device

The dom0 network backend has detected an inconsistency in the data
received from the domU's frontend. In this case a request's memory
buffer crossed a page boundary, which is not allowed.

There has been a recent change in the xen netback driver to stop the
interface in such conditions, as such invalid requests are regarded to
be malicious and might lead to crashes in dom0.

So this issue should be reported to FreeBSD maintainers in order to
have the Xen netfornt driver fixed there.

> [  501.841076] xenbr0: port 2(vif1.0) entered disabled state
> Once this error happens, the DOM-U behind this vif is no-longer
> accessible. And recreating the same DOM-U does not fix the problem.
> Only a reboot on the physical host machine helps.
>=20
> The problem showed up after a recent upgrade on the DOM-U OS from
> FreeNAS 11.3 to TrueNAS 12.0U7 and breaks the iSCSI service while
> leaving other services like NFS intact.
> The underlying OS for the NAS is FreeBSD, version 11.3 and 12.2 respect=
ively.
> So far I have tried the following combos:
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 11.3 DOM-U: Good
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.11 + FreeBSD 12.2 DOM-U: Regressed

This information (especially the FreeBSD version affected) is
probably important for the FreeBSD maintainers.

>=20
> I plan to try out the XEN 4.14 version which is the latest I can get
> from the distro (Debian).
> If that still does not fix the problem, I would build the 4.16 version
> from source as my last resort.

Xen is NOT to blame here.


Juergen


--------------6EA7CEFA39964D99A1C8CA13
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------6EA7CEFA39964D99A1C8CA13--

--O8l6cQNr5w3QZ7Fg27OH8aHbNgEazLysa--

--uMsSwA2CT25mX5P50N0gBF5OnSglFqAZs
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmG+zNAFAwAAAAAACgkQsN6d1ii/Ey//
iwf/Zx6A9K1BXyqkPvWpRnsSoCPxu/gPbr/UKHxgCl7YqxIfjnm+rrToO+5xfotAhpsblfq9xhi2
oPn23TjPOvl2YWKHLO5zx5MnYlnKWNv/NXAGeV0ZLe003ITv82mX3qiJMKeK0qAvoEhhyMVstmtk
H0ykuTn7fcQsIxcWcLhbbq4mh7aujJA+PGHZfV/RhfOC/GZX7b5Jy6IclWr1OTYPx5bvomTl3J02
k0pcizqgXh6zx86YN/kej/hVE17bJnGpmY0sj2x8U1dBMFLx7RBp1oBOi6db+Og9q2pYGbRyT25l
3IuMZP7thfbn+0aQUr/l77saPNKEd01e5/AQxrkp1A==
=tSss
-----END PGP SIGNATURE-----

--uMsSwA2CT25mX5P50N0gBF5OnSglFqAZs--


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 06:23:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 06:23:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249228.429716 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mypbS-0003Yp-Q3; Sun, 19 Dec 2021 06:23:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249228.429716; Sun, 19 Dec 2021 06:23:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mypbS-0003Yi-Mc; Sun, 19 Dec 2021 06:23:26 +0000
Received: by outflank-mailman (input) for mailman id 249228;
 Sun, 19 Dec 2021 06:23:25 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mypbR-0003YY-6v; Sun, 19 Dec 2021 06:23:25 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mypbQ-0002X4-Vq; Sun, 19 Dec 2021 06:23:25 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mypbQ-0000eJ-Cb; Sun, 19 Dec 2021 06:23:24 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mypbQ-0007xy-Bf; Sun, 19 Dec 2021 06:23:24 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Hnm4GDIV98N8dFRldFIPKRgrhCDJd3F4NxdAencpumk=; b=gxP8RjtaQKhSgjF+T2H50y9Pk+
	3K2j00p6jDpSvRoArKz05TRTVag90fVeLI5S22Vcbwm1/rCs2om6/dpUeVuHkDORakVpn/BirlThi
	sClt3W4RgUEVb0GDtoZdRzqjIFi23Qlj4lMm3ZbwX0uaucnAp9Gjghxpjk+9QZnLtYDc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167479-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167479: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-freebsd12-amd64:guest-saverestore:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3f667b5d4053ad54aee13dab5c94f04ff75ddfdf
X-Osstest-Versions-That:
    linux=9eaa88c7036eda3f6c215f87ca693594cf90559b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 19 Dec 2021 06:23:24 +0000

flight 167479 linux-linus real [real]
flight 167482 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167479/
http://logs.test-lab.xenproject.org/osstest/logs/167482/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-freebsd12-amd64 16 guest-saverestore fail pass in 167482-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167470
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167470
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167470
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167470
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167470
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167470
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167470
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167470
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass

version targeted for testing:
 linux                3f667b5d4053ad54aee13dab5c94f04ff75ddfdf
baseline version:
 linux                9eaa88c7036eda3f6c215f87ca693594cf90559b

Last test of basis   167470  2021-12-18 02:04:27 Z    1 days
Testing same since   167479  2021-12-18 22:42:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Amelie Delaunay <amelie.delaunay@foss.st.com>
  Arnaldo Carvalho de Melo <acme@redhat.com>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Daniele Palmas <dnlplm@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
  Ji-Ze Hong (Peter Hong) <hpeter@gmail.com>
  Jimmy Wang <wangjm221@gmail.com>
  Johan Hovold <johan@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maarten Brock <m.brock@vanmierlo.com>
  Marian Postevca <posteuca@mutex.one>
  Miaoqian Lin <linmq006@gmail.com>
  Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
  Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
  Pawel Laszczak <pawell@cadence.com>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Xu Yang <xu.yang_2@nxp.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             fail    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9eaa88c7036e..3f667b5d4053  3f667b5d4053ad54aee13dab5c94f04ff75ddfdf -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 09:11:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 09:11:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249254.429727 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mysDl-00052K-O8; Sun, 19 Dec 2021 09:11:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249254.429727; Sun, 19 Dec 2021 09:11:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mysDl-00052D-KV; Sun, 19 Dec 2021 09:11:09 +0000
Received: by outflank-mailman (input) for mailman id 249254;
 Sun, 19 Dec 2021 09:11:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mysDl-000523-5C; Sun, 19 Dec 2021 09:11:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mysDl-0005oT-28; Sun, 19 Dec 2021 09:11:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mysDk-00073y-NS; Sun, 19 Dec 2021 09:11:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mysDk-0008WC-N1; Sun, 19 Dec 2021 09:11:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=na6OVOLek6t2aR+cys9adhnxNTFaonD3U1+OPdbFl0s=; b=gsz3f52hZz8zs2ooajTHCt650p
	IfjdDseSG9iLFSNZIdHFRGSRxaUmZ41wzsB3GdFvcXoOkxlqSWPGyQ89b+26/Gr8lXblHf16gTYPy
	INOWDt7/J0QULw/QY47i8FL5ms91UNzlcC0h7eA7CbU9NuIiesY8/B+8QzSP4VOuuIv0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167481-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167481: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=354644feb4914511413c7d177bbaf18be3216d13
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 19 Dec 2021 09:11:08 +0000

flight 167481 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167481/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              354644feb4914511413c7d177bbaf18be3216d13
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  527 days
Failing since        151818  2020-07-11 04:18:52 Z  526 days  508 attempts
Testing same since   167473  2021-12-18 04:18:52 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90068 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 09:51:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 09:51:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249271.429738 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mysq0-0001IL-KV; Sun, 19 Dec 2021 09:50:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249271.429738; Sun, 19 Dec 2021 09:50:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mysq0-0001IE-Gq; Sun, 19 Dec 2021 09:50:40 +0000
Received: by outflank-mailman (input) for mailman id 249271;
 Sun, 19 Dec 2021 09:50:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myspz-0001I4-4E; Sun, 19 Dec 2021 09:50:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myspz-0006Sk-1h; Sun, 19 Dec 2021 09:50:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1myspy-0007vD-OM; Sun, 19 Dec 2021 09:50:38 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1myspy-0007jg-Nu; Sun, 19 Dec 2021 09:50:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YjmcyjM1Z51S6JQr6rWS89BK/03yByXb5gSCEUL87Ac=; b=MgJgeqqyaTJwVcZGIurDu+aHdG
	w7Zoo86J/DJeNQARGhKeBpDD3kG1ELJsrTbMrsQtUsLkArooUwsqVsVsr+0sPHULDjQXKgFIelvmK
	4Aau/EkmrxtoX1PavN0rBQ2LYe6mRrQrp8xOnK9iD8DGd4tbI41bB7vW8xoCqR9tlV4A=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167483-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167483: all pass - PUSHED
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=df3e1a5efe700a9f59eced801cac73f9fd02a0e2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 19 Dec 2021 09:50:38 +0000

flight 167483 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167483/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  df3e1a5efe700a9f59eced801cac73f9fd02a0e2

Last test of basis   167384  2021-12-12 09:20:52 Z    7 days
Failing since        167428  2021-12-15 09:21:06 Z    4 days    2 attempts
Testing same since   167483  2021-12-19 09:20:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Anthony PERARD <anthony.perard@citrix.com>
  Bobby Eshleman <bobby.eshleman@gmail.com>
  Christian Lindig <christian.lindig@citrix.com>
  Jan Beulich <jbeulich@suse.com>
  Juergen Gross <jgross@suse.com>
  Julien Grall <jgrall@amazon.com>
  Luca Fancellu <luca.fancellu@arm.com>
  Michal Orzel <michal.orzel@arm.com>
  Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
  Paul Durrant <paul@xen.org>
  Rahul Singh <rahul.singh@arm.com>
  Stefano Stabellini <sstabellini@kernel.org>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   df3e1a5efe..8e3edefb88  8e3edefb880caeeaaf80123d5599139e8c2c9ecf -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Sun Dec 19 10:45:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 10:45:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249282.429748 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mytgo-000726-OB; Sun, 19 Dec 2021 10:45:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249282.429748; Sun, 19 Dec 2021 10:45:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mytgo-00071z-L2; Sun, 19 Dec 2021 10:45:14 +0000
Received: by outflank-mailman (input) for mailman id 249282;
 Sun, 19 Dec 2021 10:45:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mytgm-00071p-Ls; Sun, 19 Dec 2021 10:45:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mytgm-0007QL-ID; Sun, 19 Dec 2021 10:45:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mytgm-0000iR-50; Sun, 19 Dec 2021 10:45:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mytgm-0003uO-4Z; Sun, 19 Dec 2021 10:45:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9mglGaG+6yyltArCTN9InqR4B+DWCSZtZNuSTAfHw/8=; b=XrWAWpsBf1EotHcUo9PbbRPjVV
	Y0gh3E9w5ngib41KOPkSxxaFCRZYl1+tpbRHK1FzPSDICW2wCxmjDqO7PgjvN75Ld+/eGKINfnHch
	oIer/vfIv6QlRv4rd6l/vYnfcwmCqT9lUE+tF9JtZCOveXaceG1+dc3MCBSgy05iZTb0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167480-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167480: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 19 Dec 2021 10:45:12 +0000

flight 167480 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167480/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167471
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167471
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167471
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167471
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167471
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167471
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167471
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167471
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167471
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167471
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167471
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167471
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167480  2021-12-19 01:52:20 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Dec 19 17:32:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 19 Dec 2021 17:32:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249326.429759 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mz02Q-00079c-G6; Sun, 19 Dec 2021 17:31:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249326.429759; Sun, 19 Dec 2021 17:31:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mz02Q-00079V-DB; Sun, 19 Dec 2021 17:31:58 +0000
Received: by outflank-mailman (input) for mailman id 249326;
 Sun, 19 Dec 2021 17:31:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=pryn=RE=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1mz02Q-00079P-0K
 for xen-devel@lists.xen.org; Sun, 19 Dec 2021 17:31:58 +0000
Received: from mail-io1-f46.google.com (mail-io1-f46.google.com
 [209.85.166.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8ea95be7-60f1-11ec-9e60-abaf8a552007;
 Sun, 19 Dec 2021 18:31:56 +0100 (CET)
Received: by mail-io1-f46.google.com with SMTP id b187so10439065iof.11
 for <xen-devel@lists.xen.org>; Sun, 19 Dec 2021 09:31:54 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ea95be7-60f1-11ec-9e60-abaf8a552007
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=hLZyWateaNhomaPRkzIvsUXw4EF+E9NSaVSjVkcOAso=;
        b=g6darX+Ev0OJhGrmzFdjIaCvZN4J2gOpLXR3qg36rceKCnvV69V1csqj5i13bIiHDs
         WGsxiV7Mrk2w0U7vxkRCOVJMvcKCpnaaEOVKnc86BudvGgdQQFzNQ7TWwYfPk/m/Rjmh
         a9mXJxGo4gRLoIMObaNzLOwmqviPRgsHgtmvT4JCf93BsP73NuLphi+HbcTeypXlbF39
         e0klG0hfXNfCvoPQunmQwanTPDNGwMj06V6Np8LRdrAaKUogqUrzu71mlIfYcDT32T8v
         jA/yAndmHCLRWwp0P8f07jSrWD34hHHEzDj7if/rspLPEhltm0EYPUwmx8y+giwoEfii
         pRpQ==
X-Gm-Message-State: AOAM53200SkokDZpKcrk0ZtwwzoljFkSL1yqN2AdSzHrC8oxOGCM70R2
	pBU9pBpw/AN/uj/GtVAiem//jEJKC0M1Fc3Omk4SPwf5N5homg==
X-Google-Smtp-Source: ABdhPJzt7ZJE/Qo2fn59b/a3vQoDFQPOdiJucYzrGzjmzTQdZY8bSFHCONnfrdPfYVwI8PSgoeL1CPt1CyH+eI1dkYA=
X-Received: by 2002:a05:6638:410b:: with SMTP id ay11mr7787766jab.183.1639935113042;
 Sun, 19 Dec 2021 09:31:53 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
In-Reply-To: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Mon, 20 Dec 2021 01:31:41 +0800
Message-ID: <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

On Sun, Dec 19, 2021 at 2:35 AM G.R. <firemeteor@users.sourceforge.net> wrote:
>
> Hi all,
>
> I ran into the following error report in the DOM0 kernel after a recent upgrade:
> [  501.840816] vif vif-1-0 vif1.0: Cross page boundary, txp->offset:
> 2872, size: 1460
> [  501.840828] vif vif-1-0 vif1.0: fatal error; disabling device
> [  501.841076] xenbr0: port 2(vif1.0) entered disabled state
> Once this error happens, the DOM-U behind this vif is no-longer
> accessible. And recreating the same DOM-U does not fix the problem.
> Only a reboot on the physical host machine helps.
>
> The problem showed up after a recent upgrade on the DOM-U OS from
> FreeNAS 11.3 to TrueNAS 12.0U7 and breaks the iSCSI service while
> leaving other services like NFS intact.
To clarify -- mounting iSCSI disk will cause the problem immediately.

> The underlying OS for the NAS is FreeBSD, version 11.3 and 12.2 respectively.
> So far I have tried the following combos:
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 11.3 DOM-U: Good
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.11 + FreeBSD 12.2 DOM-U: Regressed
- Linux 5.10 DOM0 + XEN 4.14 + FreeBSD 12.2 DOM-U: Regressed
>
> I plan to try out the XEN 4.14 version which is the latest I can get
> from the distro (Debian).
I just upgraded to Debian bullseye (11) from buster (10) and migrated
to XEN4.14 as a result.
The syndrome persists, unfortunately.
BTW, my Dom0 kernel is a custom built version. Does any kernel config
could contribute to this problem?

> If that still does not fix the problem, I would build the 4.16 version
> from source as my last resort.
>
> I have to admit that this trial process is blind as I have no idea
> which component in the combo is to be blamed. Is it a bug in the
> backend-driver, frontend-driver or the hypervisor itself? Or due to
> incompatible versions? Any suggestion on other diagnose ideas (e.g.
> debug logs) will be welcome, while I work on the planned experiments.
>
> Thanks,
> G.R.


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 02:29:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 02:29:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249386.429789 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mz8Q4-0005Sz-1C; Mon, 20 Dec 2021 02:28:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249386.429789; Mon, 20 Dec 2021 02:28:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mz8Q3-0005SY-Qq; Mon, 20 Dec 2021 02:28:55 +0000
Received: by outflank-mailman (input) for mailman id 249386;
 Mon, 20 Dec 2021 02:28:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mz8Q3-0005SO-7q; Mon, 20 Dec 2021 02:28:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mz8Q3-00017s-3v; Mon, 20 Dec 2021 02:28:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mz8Q2-0008Px-Lj; Mon, 20 Dec 2021 02:28:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mz8Q2-0001lT-LI; Mon, 20 Dec 2021 02:28:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lKIubu5S9IVO9DaArodnj8412l3xOsKF7E3i7YCwKUM=; b=hL5q43MawzmgSFi+z1AaI3VKsB
	z/vQgRicmf0/g4becsMxq7HL9h5585XmbO/fhJH5AJuH4tQ6E7QyiHtVJHSEMJ+aMgvByDt4sU5qo
	Dh+LcT4Z2gr2Tx67X97AmPPtAL65K4mjSwaAEui8+RM5thZ276tj539YoAF8gT/XTRW0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167484-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167484: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a76c3d035872bf390d2fd92d8e5badc5ee28b17d
X-Osstest-Versions-That:
    linux=3f667b5d4053ad54aee13dab5c94f04ff75ddfdf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 02:28:54 +0000

flight 167484 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167484/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 167479

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167479
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167479
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167479
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167479
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167479
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167479
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167479
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167479
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                a76c3d035872bf390d2fd92d8e5badc5ee28b17d
baseline version:
 linux                3f667b5d4053ad54aee13dab5c94f04ff75ddfdf

Last test of basis   167479  2021-12-18 22:42:06 Z    1 days
Testing same since   167484  2021-12-19 20:40:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chang S. Bae <chang.seok.bae@intel.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  Joe Lawrence <joe.lawrence@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Martin Kennedy <hurricos@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Ronnie Sahlberg <lsahlber@redhat.com>
  Russell Currey <ruscur@russell.cc>
  Sergio Paracuellos <sergio.paracuellos@gmail.com>
  Shyam Prasad N <sprasad@microsoft.com>
  Stefan Roese <sr@denx.de>
  Steve French <stfrench@microsoft.com>
  Thiago Rafael Becker <trbecker@gmail.com>
  Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  Thomas Gleixner <tglx@linutronix.de>
  Tiezhu Yang <yangtiezhu@loongson.cn>
  Xiaoming Ni <nixiaoming@huawei.com>
  Yu Liao <liaoyu15@huawei.com>
  Zqiang <qiang1.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3f667b5d4053..a76c3d035872  a76c3d035872bf390d2fd92d8e5badc5ee28b17d -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249402.429800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7V-0007eU-IA; Mon, 20 Dec 2021 05:21:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249402.429800; Mon, 20 Dec 2021 05:21:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7V-0007eN-Ep; Mon, 20 Dec 2021 05:21:57 +0000
Received: by outflank-mailman (input) for mailman id 249402;
 Mon, 20 Dec 2021 05:21:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7T-0007eG-LQ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:21:56 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0619.outbound.protection.outlook.com
 [2a01:111:f400:fe02::619])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bc91936c-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:21:52 +0100 (CET)
Received: from AM5PR0101CA0026.eurprd01.prod.exchangelabs.com
 (2603:10a6:206:16::39) by AM0PR08MB3587.eurprd08.prod.outlook.com
 (2603:10a6:208:dd::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec
 2021 05:21:48 +0000
Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:16:cafe::67) by AM5PR0101CA0026.outlook.office365.com
 (2603:10a6:206:16::39) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:48 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:47 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Mon, 20 Dec 2021 05:21:47 +0000
Received: from 15a868e231fc.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 7955E9D2-6AF5-4EFB-9FF9-8D47464FDDC2.1; 
 Mon, 20 Dec 2021 05:21:41 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 15a868e231fc.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:41 +0000
Received: from DB7PR05CA0043.eurprd05.prod.outlook.com (2603:10a6:10:2e::20)
 by PR3PR08MB5850.eurprd08.prod.outlook.com (2603:10a6:102:92::8) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:39 +0000
Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e::4) by DB7PR05CA0043.outlook.office365.com
 (2603:10a6:10:2e::20) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:39 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:38 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:38 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bc91936c-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VI2S3WrwoHVYVm8HTqP/yL+yoeOQEd8YqDWRYEzzS+g=;
 b=DQAKuV5g+TzsjZDy+Vlt+0Fxrd57RC+Lumf4ZGg10mtkZEOAGNj7p/qFTym+V03+pwaF51alYCnLsbHsmeLXA4D4u7dtirUpAQe7mt1QK6Q0RjT5LfbrV2Ms/8XT7cYFa+oN02abUjsxqi+ox76HWYBzVFtGAdI6aE8u/X3Ya+U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 30303dda52213c14
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hpuFtM862LG7VOxRK7N2ULxdwEbOf2rJaQccg890le5APglEwHx14DCZ5H3NP7bc4/Inlb7WAuDlG3Z39Enovwwe1WLq7scfIVctO3A+X+RjNo+1qYjNy8JlEmF2pHLBEMSdbkwZGkSVPdH0rdz8B3jvjDUbr6mhM0xkBsWleAEVQzAapncHWqfAl7bwpTRIcQltVCHIEUw/gOg/GPXM+dFXhfaMq5ayOG2mrZ+/VFupcSjKgnVo9QJxBpMWSOIAeiFLaGzPLAXdt1md6dMpkPRRd9yRiJe8WxnNQTvgQpro95+0fiDQYSI4Efk5iWdw1vkLyRrcMU3wD/l+E87nog==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VI2S3WrwoHVYVm8HTqP/yL+yoeOQEd8YqDWRYEzzS+g=;
 b=jRNINBx6fjatPgwumgPdWmHzh22W9jkbmHKzK+069+Sg6KoM/Iq3qeAeD9Q872Z3X64f37mUNrcTKOROqglIrfS9J9NIuKM7sAHemK25WQAoFuy0c/gN+B5KjPkkpY0s9rd9a1eA4v2c08oZOh2IuyTugpbz5ArC4DHYYn0G/si/QLUMnC+3oyf1cZ/U1tWQsu12AK45M3ksH63qACP4CGJcK5MgAL3PHuZFrKTYf7gbVZ3s2BSy7EGZAMdd3dMeWqyp8SqEhrtyy6Ua+WJowVZkVG4ypl+7PMtVDMNJgCOWaIUOr2MUne8V5B1Tof8q3S1WAk1bKByJ4D6l7pv3dw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VI2S3WrwoHVYVm8HTqP/yL+yoeOQEd8YqDWRYEzzS+g=;
 b=DQAKuV5g+TzsjZDy+Vlt+0Fxrd57RC+Lumf4ZGg10mtkZEOAGNj7p/qFTym+V03+pwaF51alYCnLsbHsmeLXA4D4u7dtirUpAQe7mt1QK6Q0RjT5LfbrV2Ms/8XT7cYFa+oN02abUjsxqi+ox76HWYBzVFtGAdI6aE8u/X3Ya+U=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 00/11] direct-map memory map
Date: Mon, 20 Dec 2021 05:21:12 +0000
Message-ID: <20211220052123.969876-1-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 0bca1365-3f02-43a4-7259-08d9c3789efb
X-MS-TrafficTypeDiagnostic:
	PR3PR08MB5850:EE_|VE1EUR03FT044:EE_|AM0PR08MB3587:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3587ADA35AA37894604CDCDCF77B9@AM0PR08MB3587.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 =?utf-8?B?NDN6eEc1TTdRZlV5bDJEWlJSMEp0VklORVNweEZvVnd5R3JsV2VjNlBwMUdG?=
 =?utf-8?B?N3dZTVprdjZhdkhyUnlnV3lzZXE3enk2QWlWUTZpQ2k4YWl6Ym5NcVZhTW5G?=
 =?utf-8?B?cG03Z3JiWlVoWEtFb1lPNTBpZEJBMXNPRDVsVnk2SVpsbGt0cStmVVVMbHda?=
 =?utf-8?B?cVpmSXlxYTdlWGY3ZjlGbEVEaXYxdlRmV3JRVXpkdCsxc3lCa0VFbDJqVlRC?=
 =?utf-8?B?b3lxdzVoSFZxUEN5QVhSN3EzeDlRY1IxeUZHVVJ6V1FnMzl3eExjSWNwZENq?=
 =?utf-8?B?OUMvOVMzUjE0eWFLNzA3cU5ZKzJXKzZ3UEx1cE4rcEQrVDdNQmxTeWV0VEMz?=
 =?utf-8?B?RlhCd0doVVBFWXdiY1QvdytWTXlxMzh4YSsyU1M3RitzWkMwbWtFRDdJalNo?=
 =?utf-8?B?dmZxZmVzb1YxRko0QnlEdGFieEpoQ2dId3V1alc0WmhSWkpFZkxPeUcydi9J?=
 =?utf-8?B?cElBZmlEZEEvUGE5VlZTL3JkeTNBSktacDNrK0pCY3VBYk1aVy9ORG5ldkpR?=
 =?utf-8?B?RitHT09QUzJ3Mi9ncGFjdDNUQzQzRUVwWGZwZWV1ODFSbXViYmVFanl4bTFC?=
 =?utf-8?B?RWY0OHJ4aEt6NG5RYlAwWnF5Mms4WFBKNVNkY0RmbGxmWXgzK0p1T090ZnA2?=
 =?utf-8?B?eENyY0J6MjF3SnM5SkxzQ2RYWGk4dkwvTmtMdmxKem9HWFh1b1pSTFhqOEFS?=
 =?utf-8?B?cnV1REw2OHJjOStSMm9TcjBWRlVMc0kwMFNwa3diZGtlTDFjL2xwWDVqZEps?=
 =?utf-8?B?QVhESnIxdm1GMmpZWTlKWU92dkZoUkZzMUxNQzN0UUJXRElBdURuWFFiUytH?=
 =?utf-8?B?NGNnZmVKSm9FSGZRQmV4dkFQc2kvRDhQeldTc0VLQmNvd1JlQnRRNWZEQUdF?=
 =?utf-8?B?aGZmTGdKNUl4aGxRYWhZOHpjTCtVVFZNbWU4c3ZKRlgwNWZobEU5NERreGVx?=
 =?utf-8?B?VWhCdE1GczZPbGt1dURnRU8wU2gySXJFejVoOUVnb1pVMktyTDRENTlDbmEv?=
 =?utf-8?B?ZGlENTNCRUMxandZbitpRUpUM0p3L1VSVnBNSDZGSzMyZ2lMeit1OTBRZTVG?=
 =?utf-8?B?cTd2L09jVzNYekVJeDFlQ3pMNzN0cHY3SHdTU2FiZDBudUliV3kwQm9wWGNG?=
 =?utf-8?B?dVBMdVZlcGcxbStVdUppQWtQTW1YR29Ta2dnTHExTnNLVVJhRm5DRlZBWUdM?=
 =?utf-8?B?QUdHWU8vOElnQkRtNWZPRldCNlFncEJDc3lSWDlJTExqSDl4WnVTT0YzTHhX?=
 =?utf-8?Q?hQ7gKbarJmxMUA1?=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(81166007)(2906002)(966005)(70206006)(8936002)(70586007)(356005)(508600001)(83380400001)(47076005)(44832011)(2616005)(5660300002)(1076003)(336012)(426003)(26005)(6666004)(186003)(7696005)(8676002)(4326008)(86362001)(36756003)(110136005)(54906003)(36860700001)(40460700001)(316002)(82310400004)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5850
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b086600c-cc1d-4cbc-fd93-08d9c378998a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Yta5XsGH9Ly20L4hQwTtcwihlf60Cqpqho+iGCqOh3tDHxdG5yb310gQd21sQrrZ0tB7aQFdGeDxMIEaXV8Nf6SN3lw9D6/E9exEuUMBzMuccGI2l0rEwtvCm92n/t+T/1/SJHKzIAMQ127b6/d2EuDVzt2BdNttg1iGqR3gX+NTtIJlFkgxcrP77Y6Mm0eC2SbizA2oTebHmDQwAR/dWH+ptWmlcjIqRNnt0DwTTRE0GQeWZ7yF3ufCuEMofMcVxJerXZqnsa0TjnkhNtxmePM1MRJLpW1bGUC4a1JI+ehqxkyTXK0nL8PHcHx4pZRz5VepPueqOTa7Ocktzhh1N0vEd+nS4AsOn/kuteAUS2f1tqeF4VxGXA/yokHrGMi35iaCq7sVS77vIFQHH0DKZmYwCOVAweWfM/sU+RtrnXxhCUdFta5vhsdye2jsuR5ToN/1wDQa+fYpCwFe566pgLVIkTknMgpbWLAsY65ZtHD/+Q0ngxKuMUT2LKjIRGPs/Ky7b17E+Ff5kAGipW3Fgiq8xZ2+EiZCt63Dftab8Eqa7vI/ApeHu+IYIRbW95COFTWW8qo5JfgAsbo94UNXBVhGOpFimaWleLFciLAgYsAYQQIzKomyeZAx81ds5LtOsp6vgi9etubGZBxFcKBZY3Owk2uub9z6ft542CLCH+paTFXHGREkvqwUjn0sT35So/XwYClgt7awYfESTQfDnFcnyP7lVLjtCXhBC68+/O+P8VABqdQxHIMNKaTVMzwaKWZp4yhRmwx6xKBYg6yC7lI+U2yfNyCXivvoaBiSEblGtPD/EVI1h2jZE3ecxvti/SHpEshRESELlil363Z3NyGlvgDQzjV5JBQ451DBewg=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(426003)(2616005)(2906002)(336012)(508600001)(36860700001)(54906003)(110136005)(70586007)(5660300002)(966005)(86362001)(36756003)(316002)(4326008)(83380400001)(44832011)(47076005)(186003)(70206006)(6666004)(8676002)(82310400004)(26005)(7696005)(8936002)(1076003)(81166007)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:47.9156
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bca1365-3f02-43a4-7259-08d9c3789efb
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3587

Cases where domU needs direct-map memory map:
  * IOMMU not present in the system.
  * IOMMU disabled if it doesn't cover a specific device and all the guests
are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
a few without, then guest DMA security still could not be totally guaranteed.
So users may want to disable the IOMMU, to at least gain some performance
improvement from IOMMU disabled.
  * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
To be specific, in a few extreme situation, when multiple devices do DMA
concurrently, these requests may exceed IOMMU's transmission capacity.
  * IOMMU disabled when it adds too much latency on DMA. For example,
TLB may be missing in some IOMMU hardware, which may bring latency in DMA
progress, so users may want to disable it in some realtime scenario.
  * Guest OS relies on the host memory layout

"direct-map" property shall be added under the appropriate domain node,
when users requesting direct-map memory mapping for the domain.

Right now, direct-map is only supported when domain on Static Allocation,
that is, "xen,static-mem" is also necessary in the domain configuration.

Looking into related [design link](
https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg00882.html)
for more details.

The whole design is about Static Allocation and direct-map, and this
Patch Serie only covers parts of it, which are direct-map memory map.
Other features will be delievered through different patch series.

See https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg00855.html
for Domain on Static Allocation.

This patch serie is based on
https://lists.xenproject.org/archives/html/xen-devel/2021-10/msg00822.html\
---
v4 changes:
- introduce internal const CDF_xxx flags for domain creation
- introduce internal flag CDF_privileged
- introduce new internal flag CDF_directmap
- add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.
- expand arch_domain_create/domain_create to include internal-only parameter
"const unsigned int flags"
- use mfn_eq() instead, because it is the only value used to indicate
there is an error and this is more lightweight than mfn_valid()
- rename function allocate_static_memory_11() to assign_static_memory_11()
to make clear there is actually no allocation done. Instead we are only
mapping pre-defined host regions to pre-defined guest regions.
- remove tot_size to directly substract psize from kinfo->unassigned_mem
- check kinfo->unassigned_mem doesn't underflow or overflow
- remove nested if/else
- remove ASSERT_UNREACHABLE() to avoid breaking compilation on prod build with
CONFIG_GICV3=n
- comment and commit message refinement
---
v3 changes:
- move flag XEN_DOMCTL_CDF_INTERNAL_directmap back to xen/include/xen/domain.h,
to let it be only available for domain created by XEN.
- name it with extra "INTERNAL" and add comments to warn developers not
to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
- reject this flag in x86'es arch_sanitise_domain_config()
- add ASSERT_UNREACHABLE to catch any misuse in allocate_static_memory()
and allocate_static_memory_11()
- add another check of validating flag XEN_DOMCTL_CDF_INTERNAL_directmap only
when CONFIG_STATIC_MEMORY is set.
- simply map the CPU interface at the GPA vgic_v2_hw.cbase
- drop 'cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS)'
- rename 'is_domain_use_host_layout()' to 'domain_use_host_layout()'
---
v2 changes:
- remove the introduce of internal flag
- Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set
- reword "1:1 direct-map" to just "direct-map"
- split the common codes into two helpers: parse_static_mem_prop and
acquire_static_memory_bank to deduce complexity.
- introduce a new helper allocate_static_memory_11 for allocating static
memory for direct-map guests
- remove panic action since it is fine to assign a non-DMA capable device when
IOMMU and direct-map both off
- remove redistributor accessor
- introduce new helper "is_domain_use_host_layout()"
- explain why vpl011 initialization before creating its device tree node
- error out if the domain is direct-mapped and the IRQ is not found
- harden the code and add a check/comment when the hardware UART region
is smaller than CUEST_VPL011_SIZE.
Penny Zheng (4):
  xen/arm: introduce new helper parse_static_mem_prop and
    acquire_static_memory_bank
  xen/arm: introduce direct-map for domUs
  xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory
  xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3

Stefano Stabellini (7):
  xen: introduce internal CDF_xxx flags for domain creation
  xen: introduce CDF_directmap
  xen/arm: avoid setting XEN_DOMCTL_CDF_iommu when IOMMU off
  xen/arm: if direct-map domain use native addresses for GICv2
  xen/arm: if direct-map domain use native addresses for GICv3
  xen/arm: if direct-map domain use native UART address and IRQ number
    for vPL011
  xen/docs: Document how to do passthrough without IOMMU

 docs/misc/arm/device-tree/booting.txt |   6 +
 docs/misc/arm/passthrough-noiommu.txt |  52 +++++
 xen/arch/arm/domain.c                 |   5 +-
 xen/arch/arm/domain_build.c           | 308 +++++++++++++++++++++-----
 xen/arch/arm/include/asm/domain.h     |  19 +-
 xen/arch/arm/include/asm/new_vgic.h   |  10 +
 xen/arch/arm/include/asm/vgic.h       |  11 +
 xen/arch/arm/include/asm/vpl011.h     |   2 +
 xen/arch/arm/vgic-v2.c                |  34 ++-
 xen/arch/arm/vgic-v3.c                |  26 ++-
 xen/arch/arm/vgic/vgic-v2.c           |  34 ++-
 xen/arch/arm/vpl011.c                 |  60 ++++-
 xen/arch/x86/domain.c                 |   3 +-
 xen/arch/x86/setup.c                  |   2 +-
 xen/common/domain.c                   |  12 +-
 xen/common/sched/core.c               |   2 +-
 xen/include/xen/domain.h              |   9 +-
 xen/include/xen/sched.h               |   2 +-
 18 files changed, 490 insertions(+), 107 deletions(-)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249403.429811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7W-0007uV-Ug; Mon, 20 Dec 2021 05:21:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249403.429811; Mon, 20 Dec 2021 05:21:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7W-0007uO-RJ; Mon, 20 Dec 2021 05:21:58 +0000
Received: by outflank-mailman (input) for mailman id 249403;
 Mon, 20 Dec 2021 05:21:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7V-0007eH-Ck
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:21:57 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on2061a.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::61a])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id be5153e2-6154-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 06:21:54 +0100 (CET)
Received: from AM0PR03CA0072.eurprd03.prod.outlook.com (2603:10a6:208::49) by
 AM0PR08MB3556.eurprd08.prod.outlook.com (2603:10a6:208:e0::28) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.20; Mon, 20 Dec 2021 05:21:51 +0000
Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:208::4) by AM0PR03CA0072.outlook.office365.com (2603:10a6:208::49)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:51 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:50 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Mon, 20 Dec 2021 05:21:50 +0000
Received: from 7e834618be2a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 C3D74A82-786C-41D0-BFD4-9F027FA1875D.1; 
 Mon, 20 Dec 2021 05:21:43 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7e834618be2a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:43 +0000
Received: from AM6PR04CA0021.eurprd04.prod.outlook.com (2603:10a6:20b:92::34)
 by AM0PR08MB5171.eurprd08.prod.outlook.com (2603:10a6:208:159::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:42 +0000
Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:92:cafe::f2) by AM6PR04CA0021.outlook.office365.com
 (2603:10a6:20b:92::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:42 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:42 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:41 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 20
 Dec 2021 05:21:40 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: be5153e2-6154-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9I2u4PJrCQRBxGQhxWYRRIb9q1SoLzaGmtVIyf4dcec=;
 b=GbgfPhHR1jasgDCqOs76S/SEPXsz8Vgi49O1OTa+knS87Kj/pm+Ih5J7knC31o+Zd33lUx0IWWfei9OzCBKg+8Di4B/o1CJdyXFg/7fE/AZNwVLg7KGyqKhY7tmM+jg2qOVplZBiVR/jsFqhDmbGIx2vhlMd44gC5PV3AZRjdIo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 143133e7f72db2b2
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aW4KUYathsaeIKrHvJiQtWXWn2BWKZBxz5N3OY3s595+jA4xGycOZTCpvQTEFM7nb8EznTeaFMkDcGT6xQzA6i0gty1MhOmgapZq2055kZPjYeHG09+QTk+3HSuFJr8urjGmLeM1JQyfSQJqwvGF37PadhhZknoGVW+MV4cAwHaDloxs18xpZa5B/mf8uNDLIoH6NHpmdVqEjBGN5QOZ6j+WcjIuXjT6fzo8+NFcHNypB8D69knb4IWhhjA/iTUBNKgJFu7vcHGIi1xmZoBHgm/Xo5KJVr0OJDmS5wSyAYVqHtzi6cRLxZ5ajUYRD01hXMrmKOkArCP3Ph9PI2nNbw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9I2u4PJrCQRBxGQhxWYRRIb9q1SoLzaGmtVIyf4dcec=;
 b=kAKAUEelhb/c39PG4mAvdTyPJ71W96dW2yHIgXrwkR9t4GWGMVaBy4irZ2Yl+Ho2ivYjZvDVIGShg3UH5qi2VlQZt6xZ1OWSwkCl6F+hJp21IYdJlL6Q1UawfLpE5hvCSHkuni3+FeF9QWyc89dZHxb7wA/WZE4dqxNBsNeg4iFnxXLlpEnZkkTu+xxoam1T7yPLTUMZAz2U0pZV0k65lG+2AWc4FVOHEX77QTi+7TKu9B/feWsAImCAvqhaz1DaZfruiaCufXhd6LN2BdzSkMGfiirBcGkflLkBYw47ds317nr56vsloFbYvQpFF9npBnbGp9/dGXeGZFhzvkwavg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=9I2u4PJrCQRBxGQhxWYRRIb9q1SoLzaGmtVIyf4dcec=;
 b=GbgfPhHR1jasgDCqOs76S/SEPXsz8Vgi49O1OTa+knS87Kj/pm+Ih5J7knC31o+Zd33lUx0IWWfei9OzCBKg+8Di4B/o1CJdyXFg/7fE/AZNwVLg7KGyqKhY7tmM+jg2qOVplZBiVR/jsFqhDmbGIx2vhlMd44gC5PV3AZRjdIo=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 01/11] xen: introduce internal CDF_xxx flags for domain creation
Date: Mon, 20 Dec 2021 05:21:13 +0000
Message-ID: <20211220052123.969876-2-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 08bb28af-c0da-43d2-bf6b-08d9c378a0a5
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB5171:EE_|VE1EUR03FT010:EE_|AM0PR08MB3556:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB3556201EA370BE0327624A16F77B9@AM0PR08MB3556.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Rj+kn3NOwfWJBF/+eC3AcCvxedWz9G30IUXa6w3xkEPQ7I0ptTxdUWvjtXEu/qgzto29IGzVTiufuqANNRILHdycHd9eYKad7udSNqQ99hUI+i9LuMvnxjk6H8ybnoNJrKkRyznFR3gZJVIljqvUfr0o4cBJ2vjWqoksE9ONGD8tFO+hcWbg4j/Get92NJePNOkmeWH4ZEJFM1UaP9iLa4fXqYAsEmi4CCykP0hcrLnQm/3EbWVOyOSr/kZhzRItkMVIJmwkdCHyL9dxsuN3q4LUpBQsElZy82WHULB3zdzAp/UvtVa/BdnOAypq1Qu5kGPdB17j11rKCQhqwzRzSkGw5f+7EFjQlw1fC40cfR896vPylXcv4YiHWUYaGBjy4n08wUBWB/wBAs/r2gAMjTS0fohge0691sQMyjkCi1HdWJ2+rzygfGGl0e+65FhW3gO9ZPLXADfH1yx66ha3PnnVpgMTm/1L4Gn9s4RBO9qs4/14ZMKA1uoqPncfIudRpycsLsBRpkRWcAFpWh1JueNgaUIeivKpmnxoXeXlU/rRC0yiK9v7BuQPUZtdiECm404G8ucZj4LNtNp6dBEKHb0dYrbXbT6xgT5QEIHDcIh19PkOAoMZ3Qj7WUxcaL744dRTUxI0HYDDpqydch2Ly30UGeUhDsN8l+8Y2BJcktApNtDRe/fwHwDNvsEEvmLWQwojln+Rl5dWKuHIoi8ytUngc5w7JeikiGEXEeBZ2T4CHvu4vXzJ6zdHVRKvg25olsNNW1xNHTolrc+OAeWFgch2qvaGA7LF+aY7UObOyc+j8U4Jv7dC0zAwRlFEqvBm
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(36756003)(1076003)(36860700001)(2906002)(47076005)(81166007)(2616005)(44832011)(86362001)(83380400001)(356005)(5660300002)(54906003)(426003)(82310400004)(336012)(186003)(110136005)(4326008)(8676002)(8936002)(26005)(316002)(70586007)(7696005)(70206006)(40460700001)(6666004)(508600001)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5171
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6c493641-511b-45b1-2662-08d9c3789b87
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	MCt4ZbktHrO3+qqvtRdpmRkJtr2rBtbdPLWQjWXzDG9hwxTRIy/A5Ps49E7/YkTakk+PScqiobY0aNr/62FzAhAogmLuMzKmmx1zwynBo2g+QebBwdUF4WXIQP2IbYCfUWrJ2HExvoGrSGIzV1i7DwklpeaNrW/QQUNWn2sy9fVZOT/K6UX6993l7Odr9mipx5bSyRw3/cQPbmU9TvgpuP8DgcZ1ZbLsM06pIuKudM37guzLKDQ5lMbiLkyUPEanDukI/vXywUE6uyyufJLYr0/UA6pWUo39q6ixKvVcLK9/4ZkuRn5BKaD6Mg0HR/WeEPYqFZAiTiKRlBDhGnFGh+in/tBA1xcbfqddVOvseLQcOz18eGNngamhlgvW/Cx0rp9Hwwa42fGM46NESaoBjl8fL3OsJwgC//v/O8WjeWe4nTd+ughNEt55mlU9nL/zDYYLFhO7QV73A34i6t0/QSTxEDm1/m8BYz4KWvYF1wyxnkCQcpeL+ScHVpPKN9jjWBtAygUJJF3vybnqvT0AK4rQkwsVKG4EchFdhZUc20qftsh3HuLdNEoQHX9w8VMu6lmQlqEPhoVqU/qNUiQYKWKzOavY/p9wx/35NocEwXY64lxFSM8b4CTcD0LrwVt4Vo+7BiNs4TKw3my51O1M+0HxpbbycQzyg9x/tr4bOE/EeIj0Yhcz0LtkS1rZZrbEqv/C1WWYvqzwtPaAP23iACYSnIOlL5FXUHPzMDOtVKk=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(110136005)(508600001)(83380400001)(316002)(44832011)(86362001)(6666004)(7696005)(82310400004)(5660300002)(81166007)(70586007)(70206006)(2906002)(36756003)(1076003)(8936002)(336012)(26005)(47076005)(186003)(2616005)(8676002)(4326008)(426003)(36860700001)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:50.7266
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 08bb28af-c0da-43d2-bf6b-08d9c378a0a5
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3556

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

We are passing an internal-only boolean flag at domain creation to
specify whether we want the domain to be privileged (i.e. dom0) or
not. Another flag will be introduced later in this series.

This commit extends original "boolean" to an "unsigned int" covering both
the existing "is_priv" and our new "directmap", which will be introduced later.

To make visible the relationship, we name the respective constants CDF_xxx
(with no XEN_DOMCTL_ prefix) to represent the difference with the public
constants XEN_DOMCTL_CDF_xxx.

Allocate bit 0 as CDF_privileged: whether a domain is privileged or not.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v4 changes:
- new commit
---
 xen/arch/arm/domain_build.c |  4 ++--
 xen/arch/x86/setup.c        |  2 +-
 xen/common/domain.c         | 10 +++++-----
 xen/common/sched/core.c     |  2 +-
 xen/include/xen/domain.h    |  4 ++++
 xen/include/xen/sched.h     |  2 +-
 6 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6931c022a2..0fab8604de 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3058,7 +3058,7 @@ void __init create_domUs(void)
          * very important to use the pre-increment operator to call
          * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0)
          */
-        d = domain_create(++max_init_domid, &d_cfg, false);
+        d = domain_create(++max_init_domid, &d_cfg, 0);
         if ( IS_ERR(d) )
             panic("Error creating domain %s\n", dt_node_name(node));
 
@@ -3160,7 +3160,7 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    dom0 = domain_create(0, &dom0_cfg, true);
+    dom0 = domain_create(0, &dom0_cfg, CDF_privileged);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
 
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index e716005145..a14271488c 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -789,7 +789,7 @@ static struct domain *__init create_dom0(const module_t *image,
 
     /* Create initial domain.  Not d0 for pvshim. */
     domid = get_initial_domain_id();
-    d = domain_create(domid, &dom0_cfg, !pv_shim);
+    d = domain_create(domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged);
     if ( IS_ERR(d) )
         panic("Error creating d%u: %ld\n", domid, PTR_ERR(d));
 
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 2048ebad86..023c89c0ea 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -552,7 +552,7 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config)
 
 struct domain *domain_create(domid_t domid,
                              struct xen_domctl_createdomain *config,
-                             bool is_priv)
+                             const unsigned int flags)
 {
     struct domain *d, **pd, *old_hwdom = NULL;
     enum { INIT_watchdog = 1u<<1,
@@ -578,7 +578,7 @@ struct domain *domain_create(domid_t domid,
     }
 
     /* Sort out our idea of is_control_domain(). */
-    d->is_privileged = is_priv;
+    d->is_privileged = flags & CDF_privileged;
 
     /* Sort out our idea of is_hardware_domain(). */
     if ( domid == 0 || domid == hardware_domid )
@@ -772,7 +772,7 @@ void __init setup_system_domains(void)
      * Hidden PCI devices will also be associated with this domain
      * (but be [partly] controlled by Dom0 nevertheless).
      */
-    dom_xen = domain_create(DOMID_XEN, NULL, false);
+    dom_xen = domain_create(DOMID_XEN, NULL, 0);
     if ( IS_ERR(dom_xen) )
         panic("Failed to create d[XEN]: %ld\n", PTR_ERR(dom_xen));
 
@@ -782,7 +782,7 @@ void __init setup_system_domains(void)
      * array. Mappings occur at the priv of the caller.
      * Quarantined PCI devices will be associated with this domain.
      */
-    dom_io = domain_create(DOMID_IO, NULL, false);
+    dom_io = domain_create(DOMID_IO, NULL, 0);
     if ( IS_ERR(dom_io) )
         panic("Failed to create d[IO]: %ld\n", PTR_ERR(dom_io));
 
@@ -791,7 +791,7 @@ void __init setup_system_domains(void)
      * Initialise our COW domain.
      * This domain owns sharable pages.
      */
-    dom_cow = domain_create(DOMID_COW, NULL, false);
+    dom_cow = domain_create(DOMID_COW, NULL, 0);
     if ( IS_ERR(dom_cow) )
         panic("Failed to create d[COW]: %ld\n", PTR_ERR(dom_cow));
 #endif
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..f5c819349b 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -3021,7 +3021,7 @@ void __init scheduler_init(void)
         sched_ratelimit_us = SCHED_DEFAULT_RATELIMIT_US;
     }
 
-    idle_domain = domain_create(DOMID_IDLE, NULL, false);
+    idle_domain = domain_create(DOMID_IDLE, NULL, 0);
     BUG_ON(IS_ERR(idle_domain));
     BUG_ON(nr_cpu_ids > ARRAY_SIZE(idle_vcpu));
     idle_domain->vcpu = idle_vcpu;
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 160c8dbdab..cfb0b47f13 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -28,6 +28,10 @@ void getdomaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info);
 void arch_get_domain_info(const struct domain *d,
                           struct xen_domctl_getdomaininfo *info);
 
+/* CDF_* constant. Internal flags for domain creation. */
+/* Is this a privileged domain? */
+#define CDF_privileged           (1U << 0)
+
 /*
  * Arch-specifics.
  */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 37f78cc4c4..972877bc28 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -665,7 +665,7 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config);
  */
 struct domain *domain_create(domid_t domid,
                              struct xen_domctl_createdomain *config,
-                             bool is_priv);
+                             const unsigned int flags);
 
 /*
  * rcu_lock_domain_by_id() is more efficient than get_domain_by_id().
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249406.429844 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7d-0000LT-66; Mon, 20 Dec 2021 05:22:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249406.429844; Mon, 20 Dec 2021 05:22:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7d-0000LM-2L; Mon, 20 Dec 2021 05:22:05 +0000
Received: by outflank-mailman (input) for mailman id 249406;
 Mon, 20 Dec 2021 05:22:04 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7c-0007eH-3d
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:04 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on2061e.outbound.protection.outlook.com
 [2a01:111:f400:7d00::61e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c35552d3-6154-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 06:22:03 +0100 (CET)
Received: from DB6PR1001CA0041.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::27)
 by DB9PR08MB6505.eurprd08.prod.outlook.com (2603:10a6:10:23e::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Mon, 20 Dec
 2021 05:21:59 +0000
Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:55:cafe::80) by DB6PR1001CA0041.outlook.office365.com
 (2603:10a6:4:55::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:59 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:58 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Mon, 20 Dec 2021 05:21:58 +0000
Received: from b3702eb2c8a6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 20A7C294-D398-43D1-9268-F691ACF9B383.1; 
 Mon, 20 Dec 2021 05:21:52 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3702eb2c8a6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:52 +0000
Received: from DB6P191CA0022.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::32) by
 VI1PR0801MB1984.eurprd08.prod.outlook.com (2603:10a6:800:8a::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:51 +0000
Received: from DB5EUR03FT018.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::6f) by DB6P191CA0022.outlook.office365.com
 (2603:10a6:6:28::32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:51 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT018.mail.protection.outlook.com (10.152.20.69) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:50 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:49 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c35552d3-6154-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1hGYW3cDcntczIjI51Up0+xBrq/unJHTNMFNvnTH4eo=;
 b=PRV0RRANcn2Lti8sVlkIStcF4YT72ivZ7tnLdytfQmcpo+Xe7bUqQSisLzHy+H1ZGxZhJzi4Jl0ETvBjXbgtY3VFyIwVROREvJuWPYvUcV/n7cdDcnb+hmh9Ogb8zABHyQvCfGtXN4oLd1sg58M6y82xw/8oUVrv3O3CtW4ivGA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4d69331a78b09114
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=IqfJc4/x/bjv3W486RTD19ZK3dad4zdIGOQATtiVklaVOup0j7eiUKl25VWNooxV6kMLNUiZN2bnVT62FTjyoX3TCuAN9MzH8XCmkL8KHoQJTKTI/NEub282zi14DEStzSjxeIlRbm6J2kBOmudNF4DJOVcKzq5yFviiVOiAHaBeglhngZygb6GHSaGIS/uFkVBqHpsn/k4zOOjY6FvcvMbw56IeUALQueE+swZ4lNR886E1MhVnJJmLQMxoWiFfj4ntNBHeWORcm+r3mqFoWHV5JFq4JrnWI2sQjYO6xEaQuiCPigDcjQdl1y/bB1E1W/a8io/o4ZuBg3loLHSApQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=1hGYW3cDcntczIjI51Up0+xBrq/unJHTNMFNvnTH4eo=;
 b=PLLw8IW1TTeEaA0Kg+QwZ1Ja8vSOD/+d4mAsD7cA+tQTMGMBXkKBXm06D68n9dQQgRxzb5WkSpS9LGky9iPVtdrwIjaMfAibVXQ4N1gNVGTsBt3G6ul2giAsIdOw9vxdaAjTi62VDslHkb9HrQ4O61SGsHrp/hgCZxR4wXgDgsW/qOLCaV0NPJqAFzqISX4JJD71M+A7f/vR8zhUGhU+fcfQUmQ9TAp+e2cXj9TIx2WcvderFqM/rxxbSLdzBEBNvDb31bWv/9jUIM76JpnbhAQ3xcTZC8k9bm8A+LSvmCfmLvVer+Kb6UZB9v4oGGr2mZHSGC/U6eoaKJqcJ0VQlQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=1hGYW3cDcntczIjI51Up0+xBrq/unJHTNMFNvnTH4eo=;
 b=PRV0RRANcn2Lti8sVlkIStcF4YT72ivZ7tnLdytfQmcpo+Xe7bUqQSisLzHy+H1ZGxZhJzi4Jl0ETvBjXbgtY3VFyIwVROREvJuWPYvUcV/n7cdDcnb+hmh9Ogb8zABHyQvCfGtXN4oLd1sg58M6y82xw/8oUVrv3O3CtW4ivGA=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 05/11] xen/arm: introduce direct-map for domUs
Date: Mon, 20 Dec 2021 05:21:17 +0000
Message-ID: <20211220052123.969876-6-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: c8d1b557-70e5-418b-c94d-08d9c378a582
X-MS-TrafficTypeDiagnostic:
	VI1PR0801MB1984:EE_|DB5EUR03FT006:EE_|DB9PR08MB6505:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6505ABBA4F921317168C6669F77B9@DB9PR08MB6505.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 5rkz5Th8QweEvQeJmmx0hY4JHXNUg5CjH3Ve03QWZzMRHcs6aFlhHC6aH2dEUlSiEJHAyriNAgZpfY3JyGLLtpaD1EQgYrSoT6/r27tbqjnyzHJrFI4Ha9gTSE2F7rmWaz/DQm57PpRp3Vu1LLHRR4dDe2UygpKVg7EVCOTghod1jPgbi/vdi/Isu4cs64e7X0kYH4gOwaYhbbjHduYXq9Zz1vwqA6xxxsM81uucpj/Dubd8lQWvpy2Yk8MoiGT7JDhNQ1QPWkYDORqz0udg+F3ztjM0c2l3xLAziXCaCKBcL+xnayaExlesZXLYDT0y32jXv/JHdQZgPVdXAXKk/WWktTcr5nEdRlxuw3vjvpwa1OwcAihGStVpbk+a0seixQ1yvj3XPyJIxTstuIghDQKgU+FQDEpSTz/aqnAJlPHA9D/c+fBg5qqKnX+BGglzRuIs5jMJQXoJFo4CUVWHW0etyIM7lEXQrkzbmzyWLER3/s5JoCIVKUf+Tuhzt5oJ+t44XdjOfu9DDWUZj3z4Qp7TxfiNho9NZjs7SrmP90lvY3Jjd0QBmiyRCm0JVI7LIkaQZhPDt4tPhyZEZUhwFiI8qZBMBU5XIeJaM2yrwG5bplwfIQlZV8IKm+VvzJwF6AbkAiICXPNl2l7pK8BiA8FcCjDi0/A+abFGaFbGsay4EDp2vxDbdfEhcY6cll4hbGAECLRpQUUS0Njg2snBfK1PElorGksCKmj4J+6tCiAgDYvQXun01zKgomGsKpIZKDC8IumOJd6g4qYEie84w4d9toJQWuxXVe9cJ3MGcyw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(356005)(81166007)(44832011)(70586007)(36860700001)(47076005)(110136005)(54906003)(70206006)(82310400004)(36756003)(316002)(4326008)(5660300002)(508600001)(8936002)(8676002)(2906002)(2616005)(7696005)(1076003)(83380400001)(26005)(426003)(86362001)(186003)(336012)(6666004)(40460700001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1984
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2a3d8c7a-4392-41c9-0eae-08d9c378a095
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	slYPvGZXMicot24FPLZbhg5P8ZjCopFqZMkd8L1nj+mEC0gyWRexkA/tLU2KGLto0PxTSQ8E+Ej56cj+ckmG5m1bsChl3ydfB1UBis/cW/fx7vuwRbfVRzhwEYnYK3mO0i9n8W2bvuGLojAkQq5bap9VoQXC71ms8ZXwNCRhJr2XmWUv26rbaIDWAsUCwb4UA6aK9QgsFq6JusCIv1JJ/NOInOrB+57mt7wOj5Im+z+6LACQHm8BBHfVdLZGcTZJyK5UCHdigW7ji0N0quvI25KzB/Jj1k5VRZtL11fRJmKfL11LKvqSfS6JTOfDMnLp0aFBCF4v/+uDwcWu930KLu/w2d4VxRBL3Wg+YTcO5idCXpwlnePRFotFBIDmh0pBDvWV4P2lJetn0m8sfQv+Fyu+t5/apXI7aW3EalqhipJ/NTnOof05YIcvYdsPYoEfs/8MjDWI+d3EiG58sqKPtpY0x2KrDO1C1QzedyhouHq4KVUTj8DR+YPPDK00LsLapSL6C0Fd3KsVxOyFRNp2iX3AgIXup3aIKT7FDg00kS0AHmoBuA42gofWb2mq0FE0WS7qC+5wccy8hDixmOIk3naGTF0tCp93uWqUbgj1P5bpR3j5FfPF/WLopoE2m1FVMk9K/QwX7t6HJs7PKZgZCHB1hOFhC+nCFxq8JtvYi9fxinCnK7RhHMZERFWbni4OdJ5B63i1vy0Df6zWTGb2ZQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(7696005)(316002)(186003)(54906003)(8936002)(36756003)(26005)(110136005)(44832011)(70206006)(70586007)(2906002)(6666004)(47076005)(5660300002)(426003)(36860700001)(81166007)(83380400001)(1076003)(508600001)(4326008)(336012)(82310400004)(8676002)(86362001)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:58.9939
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d1b557-70e5-418b-c94d-08d9c378a582
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6505

Cases where domU needs direct-map memory map:
  * IOMMU not present in the system.
  * IOMMU disabled if it doesn't cover a specific device and all the guests
are trusted. Thinking a mixed scenario, where a few devices with IOMMU and
a few without, then guest DMA security still could not be totally guaranteed.
So users may want to disable the IOMMU, to at least gain some performance
improvement from IOMMU disabled.
  * IOMMU disabled as a workaround when it doesn't have enough bandwidth.
To be specific, in a few extreme situation, when multiple devices do DMA
concurrently, these requests may exceed IOMMU's transmission capacity.
  * IOMMU disabled when it adds too much latency on DMA. For example,
TLB may be missing in some IOMMU hardware, which may bring latency in DMA
progress, so users may want to disable it in some realtime scenario.
  * Guest OS relies on the host memory layout

This commit introduces a new helper assign_static_memory_11 to allocate
static memory as guest RAM for direct-map domain.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- split the common codes into two helpers: parse_static_mem_prop and
acquire_static_memory_bank to deduce complexity.
- introduce a new helper allocate_static_memory_11 for allocating static
memory for direct-map guests
- remove redundant use "bool direct_map", to be replaced by
d_cfg.flags & XEN_DOMCTL_CDF_directmap
- remove panic action since it is fine to assign a non-DMA capable device when
IOMMU and direct-map both off
---
v3 changes:
- doc refinement
- drop the pointless gbank
- add check of the size of nr_banks shall not exceed NR_MEM_BANKS
- add ASSERT_UNREACHABLE to catch any misuse
- add another check of validating flag XEN_DOMCTL_CDF_INTERNAL_directmap only
when CONFIG_STATIC_MEMORY is set.
---
v4 changes:
- comment refinement
- rename function allocate_static_memory_11() to assign_static_memory_11()
to make clear there is actually no allocation done. Instead we are only
mapping pre-defined host regions to pre-defined guest regions.
- remove tot_size to directly substract psize from kinfo->unassigned_mem
- check kinfo->unassigned_mem doesn't underflow or overflow
- remove nested if/else
- refine "panic" info
---
 xen/arch/arm/domain_build.c | 97 +++++++++++++++++++++++++++++++++++--
 1 file changed, 94 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 9206ec908d..d74a3eb908 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -494,8 +494,17 @@ static bool __init append_static_memory_to_bank(struct domain *d,
 {
     int res;
     unsigned int nr_pages = PFN_DOWN(size);
-    /* Infer next GFN. */
-    gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size);
+    gfn_t sgfn;
+
+    /*
+     * For direct-mapped domain, the GFN match the MFN.
+     * Otherwise, this is inferred on what has already been allocated
+     * in the bank.
+     */
+    if ( !is_domain_direct_mapped(d) )
+        sgfn = gaddr_to_gfn(bank->start + bank->size);
+    else
+        sgfn = gaddr_to_gfn(mfn_to_maddr(smfn));
 
     res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages);
     if ( res )
@@ -668,12 +677,92 @@ static void __init allocate_static_memory(struct domain *d,
  fail:
     panic("Failed to allocate requested static memory for domain %pd.", d);
 }
+
+/*
+ * Allocate static memory as RAM for one specific domain d.
+ * The static memory will be directly mapped in the guest(Guest Physical
+ * Address == Physical Address).
+ */
+static void __init assign_static_memory_11(struct domain *d,
+                                             struct kernel_info *kinfo,
+                                             const struct dt_device_node *node)
+{
+    u32 addr_cells, size_cells, reg_cells;
+    unsigned int nr_banks, bank = 0;
+    const __be32 *cell;
+    paddr_t pbase, psize;
+    mfn_t smfn;
+    int length;
+
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to parse \"xen,static-mem\" property.\n", d);
+        goto fail;
+    }
+    reg_cells = addr_cells + size_cells;
+    nr_banks = length / (reg_cells * sizeof (u32));
+
+    if ( nr_banks > NR_MEM_BANKS )
+    {
+        printk(XENLOG_ERR
+               "%pd: exceed max number of supported guest memory banks.\n", d);
+        goto fail;
+    }
+
+    for ( ; bank < nr_banks; bank++ )
+    {
+        smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                          &pbase, &psize);
+        if ( mfn_eq(smfn, INVALID_MFN) )
+            goto fail;
+
+        printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
+               d, bank, pbase, pbase + psize);
+
+        /* One guest memory bank is matched with one physical memory bank. */
+        kinfo->mem.bank[bank].start = pbase;
+        if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[bank],
+                                           smfn, psize) )
+            goto fail;
+
+        kinfo->unassigned_mem -= psize;
+    }
+
+    kinfo->mem.nr_banks = nr_banks;
+
+    /*
+     * The property 'memory' should match the amount of memory given to
+     * the guest.
+     * Currently, it is only possible to either acquire static memory or
+     * let Xen allocate. *Mixing* is not supported.
+     */
+    if ( kinfo->unassigned_mem != 0 )
+    {
+        printk(XENLOG_ERR
+               "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n");
+        goto fail;
+    }
+
+    return;
+
+ fail:
+    panic("Failed to assign requested static memory for direct-map domain %pd.",
+          d);
+}
 #else
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
 }
+
+static void __init assign_static_memory_11(struct domain *d,
+                                             struct kernel_info *kinfo,
+                                             const struct dt_device_node *node)
+{
+    ASSERT_UNREACHABLE();
+}
 #endif
 
 /*
@@ -3023,8 +3112,10 @@ static int __init construct_domU(struct domain *d,
 #endif
     if ( !dt_find_property(node, "xen,static-mem", NULL) )
         allocate_memory(d, &kinfo);
-    else
+    else if ( !is_domain_direct_mapped(d) )
         allocate_static_memory(d, &kinfo, node);
+    else
+        assign_static_memory_11(d, &kinfo, node);
 
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249407.429855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7f-0000ge-PU; Mon, 20 Dec 2021 05:22:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249407.429855; Mon, 20 Dec 2021 05:22:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7f-0000gV-I9; Mon, 20 Dec 2021 05:22:07 +0000
Received: by outflank-mailman (input) for mailman id 249407;
 Mon, 20 Dec 2021 05:22:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7d-0007eG-Dx
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:05 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20613.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::613])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c459ccad-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:04 +0100 (CET)
Received: from AM6P195CA0023.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::36)
 by AS1PR08MB7498.eurprd08.prod.outlook.com (2603:10a6:20b:4dd::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 20 Dec
 2021 05:21:54 +0000
Received: from VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:81:cafe::89) by AM6P195CA0023.outlook.office365.com
 (2603:10a6:209:81::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT061.mail.protection.outlook.com (10.152.19.220) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:53 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Mon, 20 Dec 2021 05:21:52 +0000
Received: from 49c66bd62061.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 48B64E95-1A58-4E68-B05D-87C73FE415ED.1; 
 Mon, 20 Dec 2021 05:21:47 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 49c66bd62061.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:47 +0000
Received: from DB8PR06CA0035.eurprd06.prod.outlook.com (2603:10a6:10:100::48)
 by AS8PR08MB7208.eurprd08.prod.outlook.com (2603:10a6:20b:407::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:46 +0000
Received: from DB5EUR03FT057.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:100:cafe::ee) by DB8PR06CA0035.outlook.office365.com
 (2603:10a6:10:100::48) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:46 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT057.mail.protection.outlook.com (10.152.20.235) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:45 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:44 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:43 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c459ccad-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tJcd0gELplO85ZW04E9W1750ifu69iwOym9xLUkG6o0=;
 b=5TrO9k244YUK0olDaLzypP7VFlJsvCqE2RvU+0vjpNAv7khTc+LyU27W1N/uSQKjwSWrbLnnqkRCUhZafdqdQHjCr4kEBl9Hl5E0K+xk1YjHJD7zOlk4IYCp9eMhYhBdEjsN6eMM3lB5hNdD0+mZbpLJlBIEf81D0l1Dgy2ClZU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 00ae99ad4c9d5654
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Np0BPpnXvpx8yKQ/ZlcSWHAuDhL76qXAh8d+YdtKPpJfWQEwy8tRiSHvJMFMQRNwWQSc5p8ViTxpCRJJJKSRb4047/H246KLqfW46uUqrTYFkKV9+Kn/c7BIDD33jguSP5qLRrtHU2QsQaBSQzC8TeaXZqpSccVWB7Oc0+TxO5nuEqD+tGlxV0aQya5FHvUrz+eOlhVfsPOxKpD+jVEgrlRnMbys6vlXBGITgIb1gXAyRlh0GfTUXvCyXiTN2phOH05h+Rfxpn9+KuEDBXgOmaWJtTLwJER+Wep/BFLSBmdQ5uO3fqy2zcKT2gEPAGG3g8E7mVUcUghBzPYMSHCmlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tJcd0gELplO85ZW04E9W1750ifu69iwOym9xLUkG6o0=;
 b=jZfXI7sb4f1fQVJnyK+w7FjGVnJQgZKEDEA/t0sWliqBI2KE6wasT/8ouksVfnY/+qchWkhYA//fZagj7cxdpVT0qdvrY1nikVSEGB6UQJ6eRVaLi2+wk1xSlad6cfAgdiuGdKqt8BLeDJNuswAMj4xRzl32N7csplQZ92wnV4ylLB1uOG672Lngd6rd4yQA09c/B4bvIT3s+mxhZwLFZUZYMpmjVa2Td/qWHTgsyPYn32SC/SfvbFemP6pIOYCSuRz8DgaCJPieN3Gl31/LkEr4GAagEB/n4WZuKvxiZ5gfdidYSlXMW5PiAe24kq7UOdSStCWherl3Jl4wkPOw/w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tJcd0gELplO85ZW04E9W1750ifu69iwOym9xLUkG6o0=;
 b=5TrO9k244YUK0olDaLzypP7VFlJsvCqE2RvU+0vjpNAv7khTc+LyU27W1N/uSQKjwSWrbLnnqkRCUhZafdqdQHjCr4kEBl9Hl5E0K+xk1YjHJD7zOlk4IYCp9eMhYhBdEjsN6eMM3lB5hNdD0+mZbpLJlBIEf81D0l1Dgy2ClZU=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 03/11] xen/arm: avoid setting XEN_DOMCTL_CDF_iommu when IOMMU off
Date: Mon, 20 Dec 2021 05:21:15 +0000
Message-ID: <20211220052123.969876-4-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 41fa8410-e15a-4553-d70a-08d9c378a233
X-MS-TrafficTypeDiagnostic:
	AS8PR08MB7208:EE_|VE1EUR03FT061:EE_|AS1PR08MB7498:EE_
X-Microsoft-Antispam-PRVS:
	<AS1PR08MB7498F2A18C07D617A9D64EFBF77B9@AS1PR08MB7498.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 mAFfSfnjbYNHj3J3X8WcYAhmRpGfR0nNYGBDuZk1UAbApkUZ3kYsOQ/S7tWF6hlw9/623+dEierTYuOxDzvmEMfqZmpRwtwjjDQX/ARo8gqpl4QcRYhfpyLi4DJw1hEoz9yCel7PZnqpGuHfjV72/RrIWEjrNC9MZ10jYohsiHMTbMP/XWT28+Gds2AZ2jIpkPijj1hf/HrQb/N9kJtypbTB3gE3Wzl7TX2OPuLWKXwXqDn1RfiEcRmSsUi6rub9wder5iFs5WXgtXjcMvt+lTFYmsy+DPuAM0uhaSzSavkZ7Wlnok9IniOQtv79d8SAYdqOwk40aAM6dI3+DUCsrbVchJ2r2GXZ4OlUOfMQ3XKdnz8WHFxNsJZzm7M56rYzQvzp2RCvwDHuJIuaIEhd3RFBOUg0Fh0KcDuY08jU0JbEPBNuVnxDo1xzD+wIwkfs9Wf8l/gtgE289NLu0TScFho+CILhLrh/CrNjkRsYh253FRpKR+EFZwO87bbvlV5ITSBgnXK0oAoeQYfjqLElVSUcLyB6mie5hLa/asyXAmvvZj07gfNHzlT1azQLrxyS1pfnJzxxX0BYkhc6o1o6lXIELuShS/o7a1O1fCpQVua0+RmmqB++KOAjsZbQmyBb1fR0N695SvKZ24Dr1lV9r+XWdgWT6NQWn0klbJy3dee5fL7xOgOO9pzsTvISNDMD4WcXMnuxkG7MUl1qX8K1cFwtxtNeThS1OkYHArmnz2Z5B4AJaa2GcIKV6UywB5LoTp4nrNkCR1rN6wuGDf00iyfMQLUoHNzbFyb0O6I63QE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(110136005)(7696005)(44832011)(26005)(1076003)(356005)(47076005)(36756003)(508600001)(5660300002)(36860700001)(86362001)(70586007)(81166007)(2906002)(54906003)(70206006)(426003)(82310400004)(8936002)(40460700001)(83380400001)(316002)(336012)(4326008)(2616005)(186003)(6666004)(8676002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7208
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	71631a5b-98f5-454c-5f5c-08d9c3789d8d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	rqTHN8NRFfiWaZJMMoUWBIpJujAmeBvf5qaSY5Rxo3kGW43Kp/x3fYyfJdUBz/R7IcpTcu1TqFmM1dOqn5J7EdugkZJNTr1hnNL1DOla11tCESXh2EfMHfutjwkUAgpwDIGMgGyhU6mDoRP55YClTg+esVH8j6fdCxxstx2XT3K0snrqHPm9TJpN7+tKKmfjrR9Es1oD7vrNOv2dvLzxzcEi4RtE9isG6G2SvxQuSBlE8tLEi1Bt7XuB6ZY2k+44875++paF81nJLp/WhKCi8UdL1mUmA2JKSj38sTUvZzedZqbMU9puuOBmHjgFwZbBiSYBGRRN0wYxtBC+yLm+XNaoK8FalnrgoKGN+jXIdch5QKv2nlx5LDCrjkJwn1532mDAXjp00XZpslumolmP9dUuJcZlMBGb8UyIVl6X7We43338IuW96TjnYdqfa4yRIOvMSY1u9uqS7gqQWUmKoekg4LWKBahrEPkZjq16rJp/vxHVYXRGnevI/QVwu7TLHQB8I1B8FCLuOWfbVhgihfR3uHX1s9qbFt1dhtpF6bt6zegg4JQAvaa7edRKLi86g9fE2lhVhSB9m9jHSmfh+E7fhN+o421a6b4+2dCLUs/hj57NxgbwCoQOFwau3Cq0wVEjQ6r3b44LqxM9M7U0y3134L+fpBrMUNcMDL6iRGc1kEWlnXKcKzOLMiHwN4kmU6DPRf+EHS4GildUka5lvg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(36756003)(36860700001)(2616005)(47076005)(82310400004)(83380400001)(2906002)(1076003)(44832011)(81166007)(336012)(110136005)(5660300002)(4326008)(86362001)(508600001)(6666004)(8936002)(54906003)(8676002)(426003)(26005)(70586007)(186003)(70206006)(7696005)(316002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:53.3496
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 41fa8410-e15a-4553-d70a-08d9c378a233
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7498

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

When IOMMU is absent or shall not be used (trusted domain, performance,
hardware limitation, ..., etc), in which cases this commit avoids setting
XEN_DOMCTL_CDF_iommu to make those user cases possible and prevent failure
later during device assignment.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- new commit, split from the original "[PATCH v2 2/6] xen/arm: introduce
direct-map for domUs"
---
v4 changes
- explain briefly in the commit message why we want to do device assignment
without IOMMU.
---
 xen/arch/arm/domain_build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 9b1a5e38d3..5a106a977c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3047,7 +3047,8 @@ void __init create_domUs(void)
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
 
-        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
+        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") &&
+             iommu_enabled )
             d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249404.429816 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7X-0007y3-An; Mon, 20 Dec 2021 05:21:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249404.429816; Mon, 20 Dec 2021 05:21:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7X-0007xi-4r; Mon, 20 Dec 2021 05:21:59 +0000
Received: by outflank-mailman (input) for mailman id 249404;
 Mon, 20 Dec 2021 05:21:58 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7W-0007eH-1E
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:21:58 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20601.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::601])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id bec83e5c-6154-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 06:21:55 +0100 (CET)
Received: from AS9P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::10)
 by VE1PR08MB5711.eurprd08.prod.outlook.com (2603:10a6:800:1ae::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:53 +0000
Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:46d:cafe::9c) by AS9P194CA0010.outlook.office365.com
 (2603:10a6:20b:46d::10) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:53 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:52 +0000
Received: ("Tessian outbound 1cd1a01725a6:v110");
 Mon, 20 Dec 2021 05:21:52 +0000
Received: from 8e9c536f6494.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 637C877E-C4B1-46CF-8277-3D64D7876232.1; 
 Mon, 20 Dec 2021 05:21:45 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e9c536f6494.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:45 +0000
Received: from DB8PR09CA0014.eurprd09.prod.outlook.com (2603:10a6:10:a0::27)
 by PA4PR08MB7387.eurprd08.prod.outlook.com (2603:10a6:102:2a2::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Mon, 20 Dec
 2021 05:21:44 +0000
Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::3e) by DB8PR09CA0014.outlook.office365.com
 (2603:10a6:10:a0::27) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:44 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:43 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:42 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bec83e5c-6154-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tiySk4xA5Oqc3oS1dWNHaJuJFN9T1T0igsh/4hIN4eo=;
 b=1Hl/4qQUOvKzXUnj9tHA6xrTibo4VvEAyk6lzRan7UJpFJ4UUD2Yc+qbtGeATNz0BLljX+A8iKDOEn7KAzWGMcCDqL7QMWfC+XNXC3kyH4Aom2xI1WMG5nuUjGXzXbnIXjWM8057V5V5t4CvceNZOPuh0jcATNCaUOWYlTzKRXw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7d936d5487e872fb
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fdSVI4isv318ixqlTIGFyaeEpoaM6T/Rb4aBiGl18QpL6FeR6V+7PZoFZfWO3RN3gDVEHOLCRe039/lQXRqrJwn/82rZK6d3vetKgKA6W17KJPjWYVyMnmL9ZnfrmixcwI1I8jg5CwA3Bf9hQBjbDmMbBMwDwRgQ86pj8OI56W8SZUQHMtOv18rpK03Ffwl5Dx2MWIkpIBsdMT7EAL75VqVGkjXm0gFwp5U6Ab5Jk9vBaQ9rv+jnnCskeoYMLwG47xN0IGrZHx2uFsqfGSuBV0vFJXbOn34V3SMwN0rbwvqVLKBajBlLNl86eBbPPqBwlXlj2WasGGHnqqteblFiPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tiySk4xA5Oqc3oS1dWNHaJuJFN9T1T0igsh/4hIN4eo=;
 b=i4nlxq8jZCL28497QodJdJFSvjV48xe1WdGc6e3I55eUgUvsda6+HmhNYvDCWNajmE+H9l+1FXk2rzxluTswRQ2hGehih3YdV1AZJ20Ae+6+FoqBKE0tWpH/T9a84P+Qo9rumtvPkF0UN+Wi8Sr5MuTcjxo5ESDiyPWwmRHC47ER2L2jIfuT/Ajqr43Tx7O9a10s+doaB+ywsItHrEKfCu3MO9QKJmYvAyGlWasYI1o0Eg6ylTaVlrDvhqVWb9jd0h2uT/WHAraQ1spPOr+xq8gjf4nEnvVAJq8FleCCDDsQM/CiKCxI68LWcF6wLY1eRjnpIf34GMF5YrPVC0Hcfw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=tiySk4xA5Oqc3oS1dWNHaJuJFN9T1T0igsh/4hIN4eo=;
 b=1Hl/4qQUOvKzXUnj9tHA6xrTibo4VvEAyk6lzRan7UJpFJ4UUD2Yc+qbtGeATNz0BLljX+A8iKDOEn7KAzWGMcCDqL7QMWfC+XNXC3kyH4Aom2xI1WMG5nuUjGXzXbnIXjWM8057V5V5t4CvceNZOPuh0jcATNCaUOWYlTzKRXw=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 02/11] xen: introduce CDF_directmap
Date: Mon, 20 Dec 2021 05:21:14 +0000
Message-ID: <20211220052123.969876-3-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 24063700-3c33-4182-a20f-08d9c378a1c4
X-MS-TrafficTypeDiagnostic:
	PA4PR08MB7387:EE_|AM5EUR03FT058:EE_|VE1PR08MB5711:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR08MB57115A77B76F5777E2E18B46F77B9@VE1PR08MB5711.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:213;OLM:213;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 dlT7MlLDfJ7fxFemb/DixGnFdNf5hAh84eby4G7OrwxDpwD+7djHEAhDZcUvc015JUIk73oCerAgXoNjXWuv7tYioQQSzYHbfwzYPv9VCX/PP7KdpWG/bqS5tn6OLO/VHmap+rUvu2s/RT3XBUFztroquxqieBKH7gLBl3VJJ36UUaG1mrmygLklmIPf5OgHtfvDJ1kpA5YqxJt1ijCuetv2diiP2uYseaX/lmpsBLbVQ9gYFQG15smb9LXemmiVKAQEqzi4r1FQUhda4ES8k+1kYWKFQ3r8n9I6g6ODl8xzpqRi6RxPcAOGV7Wk19epfwZ3wlc5C+r+U1bcdW1RmIj2soMrZchAwuCeLL+38nok5TylNMmWdrcrxvdAGnJQA79yzehgPtPe5fV8ACEL8RaiVDKiNURK56DyLeUvAddiRw/RiSWzblfzGRjDV4j53+vQQWzvE99PewZaq2cUMzi/R1bDvVVhs18ZCl29NEg9tM/PV3TNBLYgH4LKRHgag9tb1CWc2WiIPPG30GbJma1jiq9UTtfEZ3eJW1cVt9U3WMKgbgF52WRpZci0aiCta/eDR99Fyo3gR9COcnVEOFPdBjSqyeNaQ9Q6oU+14x5RdN+Vkswxh/QoBkQDthvpKcCSRJaxYUzgfVDMIZHc0j4alaHs53f+LFk54DIm73wbkZZI6q1vnc2aK48heh4oTPlgZCsr6JG+D7Rj8QA84DpAW2dY7XCCkW5IyHGtgAW3POL4+5Scb40XQ8FuCTkYgLgsLAuu81vaGEOqmc+tG9wf8Jgdcu3w2yU+XttSv7LYawlgXYaHVXava6B0F5JFLJNgouaRVkx38XTBWk2dRA==
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(336012)(54906003)(110136005)(316002)(8936002)(26005)(83380400001)(36860700001)(7696005)(186003)(36756003)(8676002)(70206006)(70586007)(44832011)(426003)(1076003)(2616005)(356005)(40460700001)(82310400004)(508600001)(86362001)(81166007)(4326008)(47076005)(6666004)(5660300002)(2906002)(21314003)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7387
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	f0424a7c-b615-4b5f-0271-08d9c3789c5a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	G8sAh/27n143Id5t5DtdWSamDPeg1ef2Tb/QttDRJxmJNhPZQXoLlDRLRUruTfuDgoZMAJusnTCwi/QYDitNyt+4L4v349IMXIS+Y0eTyN3S0mr/Gtixx4qj1j7EbVY7MaFlrVq2KctAuN/xCiZ5qSbcLDHOdgnyBqNpkodDLkk5+nwFZCBwhL+tEpqfSWAjYLYgLoF3XRWtTojhY+Kz+GRFVFT6wUKmR/1EkypXYgHY+9EWKJrsV1UH7SUYVZoh7OlN6xdnJ6UJzoBDJy74KEOJVrLg0YcjM7jwWPKNcUJef5pWQOggdpspNxnVwujCyYc6p8/HCW7n+yQlMLmn4IaxtAohkZCwcdVwhNIjDzBSFLcFclEaLH1pXc9ZbC1/WG39QMyoTbby0MXx7UpKvWypCbSd+BPIKBAKTMHgZsahEPdkrmgdYmDKIZNwcF2ojzuljICPWphmoImFuclwauiiuBQMqC5XpxYehJSm9o9qDE+hu0wu5cdZLsH0Y3dy7+TrUHSvUEksrOvKnB8BFXtPb9Wj+dZBJaBE5D67vQpuMI1QUI20H8WEq9CLz2+OilTnVQXEnjm0ZCvB4l6oVJv4RE4wUBUEp+LcDLLBwxXC5E9hTLW5oxpZdVQqS6mohUIbncTjVYSECBjrW8PUPW86T2VYvu3i5eVys38o+BZUjZwzwFGl0CWJBfBwkgfi52KMtLP/HyKuMtGh1LUPNq2d1d/FpnCgbv1eDnT9DY4=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(81166007)(83380400001)(5660300002)(26005)(186003)(36756003)(508600001)(8936002)(8676002)(54906003)(316002)(82310400004)(86362001)(110136005)(2906002)(2616005)(1076003)(7696005)(6666004)(426003)(336012)(70206006)(70586007)(4326008)(36860700001)(44832011)(47076005)(21314003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:52.6208
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 24063700-3c33-4182-a20f-08d9c378a1c4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5711

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

This commit introduces a new arm-specific flag CDF_directmap to specify
that a domain should have its memory direct-map(guest physical address
== physical address) at domain creation.

Also, add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.

For now, direct-map is only available when statically allocated memory is
used for the domain, that is, "xen,static-mem" must be also defined in the
domain configuration.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes
- remove the introduce of internal flag
- remove flag direct_map since we already store this flag in d->options
- Refine is_domain_direct_mapped to check whether the flag
XEN_DOMCTL_CDF_directmap is set
- reword "1:1 direct-map" to just "direct-map"
---
v3 changes
- move flag back to xen/include/xen/domain.h, to let it be only available for
domain created by XEN.
- name it with extra "INTERNAL" and add comments to warn developers not
to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
- reject this flag in x86'es arch_sanitise_domain_config()
---
v4 changes
- introduce new internal flag CDF_directmap
- add a directmap flag under struct arch_domain and use it to
reimplement is_domain_direct_mapped.
- expand arch_domain_create to include internal-only parameter "const unsigned
int flags" for domain creation
---
 docs/misc/arm/device-tree/booting.txt |  6 ++++++
 xen/arch/arm/domain.c                 |  5 ++++-
 xen/arch/arm/domain_build.c           | 14 ++++++++++++--
 xen/arch/arm/include/asm/domain.h     |  5 +++--
 xen/arch/x86/domain.c                 |  3 ++-
 xen/common/domain.c                   |  2 +-
 xen/include/xen/domain.h              |  5 ++++-
 7 files changed, 32 insertions(+), 8 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 71895663a4..a94125394e 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -182,6 +182,12 @@ with the following properties:
     Both #address-cells and #size-cells need to be specified because
     both sub-nodes (described shortly) have reg properties.
 
+- direct-map
+
+    Only available when statically allocated memory is used for the domain.
+    An empty property to request the memory of the domain to be
+    direct-map (guest physical address == physical address).
+
 Under the "xen,domain" compatible node, one or more sub-nodes are present
 for the DomU kernel and ramdisk.
 
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 92a6c509e5..fa18dfa544 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -692,7 +692,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config)
 }
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config)
+                       struct xen_domctl_createdomain *config,
+                       const unsigned int flags)
 {
     int rc, count = 0;
 
@@ -708,6 +709,8 @@ int arch_domain_create(struct domain *d,
     ioreq_domain_init(d);
 #endif
 
+    d->arch.directmap = flags & CDF_directmap;
+
     /* p2m_init relies on some value initialized by the IOMMU subsystem */
     if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 )
         goto fail;
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0fab8604de..9b1a5e38d3 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3029,10 +3029,20 @@ void __init create_domUs(void)
             .max_maptrack_frames = -1,
             .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version),
         };
+        unsigned int flags = 0U;
 
         if ( !dt_device_is_compatible(node, "xen,domain") )
             continue;
 
+        if ( dt_property_read_bool(node, "direct-map") )
+        {
+            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) )
+                panic("direct-map is not valid for domain %s without CONFIG_STATIC_MEMORY\n",
+                      dt_node_name(node));
+
+            flags |= CDF_directmap;
+        }
+
         if ( !dt_property_read_u32(node, "cpus", &d_cfg.max_vcpus) )
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
@@ -3058,7 +3068,7 @@ void __init create_domUs(void)
          * very important to use the pre-increment operator to call
          * domain_create() with a domid > 0. (domid == 0 is reserved for Dom0)
          */
-        d = domain_create(++max_init_domid, &d_cfg, 0);
+        d = domain_create(++max_init_domid, &d_cfg, flags);
         if ( IS_ERR(d) )
             panic("Error creating domain %s\n", dt_node_name(node));
 
@@ -3160,7 +3170,7 @@ void __init create_dom0(void)
     if ( iommu_enabled )
         dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
-    dom0 = domain_create(0, &dom0_cfg, CDF_privileged);
+    dom0 = domain_create(0, &dom0_cfg, CDF_privileged | CDF_directmap);
     if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) == NULL) )
         panic("Error creating domain 0\n");
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index 9b3647587a..cb37ce89ec 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -29,8 +29,7 @@ enum domain_type {
 #define is_64bit_domain(d) (0)
 #endif
 
-/* The hardware domain has always its memory direct mapped. */
-#define is_domain_direct_mapped(d) is_hardware_domain(d)
+#define is_domain_direct_mapped(d) (d->arch.directmap)
 
 struct vtimer {
     struct vcpu *v;
@@ -89,6 +88,8 @@ struct arch_domain
 #ifdef CONFIG_TEE
     void *tee;
 #endif
+
+    bool directmap;
 }  __cacheline_aligned;
 
 struct arch_vcpu
diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index ef1812dc14..f6de7a9697 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -722,7 +722,8 @@ static bool emulation_flags_ok(const struct domain *d, uint32_t emflags)
 }
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config)
+                       struct xen_domctl_createdomain *config,
+                       const unsigned int flags)
 {
     bool paging_initialised = false;
     uint32_t emflags;
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 023c89c0ea..c9bcd77e00 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -659,7 +659,7 @@ struct domain *domain_create(domid_t domid,
         radix_tree_init(&d->pirq_tree);
     }
 
-    if ( (err = arch_domain_create(d, config)) != 0 )
+    if ( (err = arch_domain_create(d, config, flags)) != 0 )
         goto fail;
     init_status |= INIT_arch;
 
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index cfb0b47f13..2f1e172957 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -31,6 +31,8 @@ void arch_get_domain_info(const struct domain *d,
 /* CDF_* constant. Internal flags for domain creation. */
 /* Is this a privileged domain? */
 #define CDF_privileged           (1U << 0)
+/* Should domain memory be directly mapped? */
+#define CDF_directmap            (1U << 1)
 
 /*
  * Arch-specifics.
@@ -65,7 +67,8 @@ int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned offset);
 void unmap_vcpu_info(struct vcpu *v);
 
 int arch_domain_create(struct domain *d,
-                       struct xen_domctl_createdomain *config);
+                       struct xen_domctl_createdomain *config,
+                       const unsigned int flags);
 
 void arch_domain_destroy(struct domain *d);
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249405.429833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7Z-0008Re-Ra; Mon, 20 Dec 2021 05:22:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249405.429833; Mon, 20 Dec 2021 05:22:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7Z-0008RV-M8; Mon, 20 Dec 2021 05:22:01 +0000
Received: by outflank-mailman (input) for mailman id 249405;
 Mon, 20 Dec 2021 05:22:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7X-0007eG-Uq
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:00 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0611.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::611])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c0e3d545-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:21:59 +0100 (CET)
Received: from AS8PR04CA0208.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::33)
 by DBBPR08MB6170.eurprd08.prod.outlook.com (2603:10a6:10:200::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec
 2021 05:21:56 +0000
Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:2f3:cafe::2b) by AS8PR04CA0208.outlook.office365.com
 (2603:10a6:20b:2f3::33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:56 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Mon, 20 Dec 2021 05:21:56 +0000
Received: from d2444726bbb5.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 47CDFF00-939B-410A-9EDA-B8AB5901C771.1; 
 Mon, 20 Dec 2021 05:21:49 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2444726bbb5.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:49 +0000
Received: from DU2PR04CA0170.eurprd04.prod.outlook.com (2603:10a6:10:2b0::25)
 by AM7PR08MB5365.eurprd08.prod.outlook.com (2603:10a6:20b:109::9)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:21:48 +0000
Received: from DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b0:cafe::e4) by DU2PR04CA0170.outlook.office365.com
 (2603:10a6:10:2b0::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:48 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT022.mail.protection.outlook.com (10.152.20.171) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:47 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:47 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c0e3d545-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OhckbP+ZZBCq/1yalr4ay9gb/vsT94ZQVv4mh/pGOJs=;
 b=MtTvE1oEKQDVPx9VeEh8SmOmnLfATIVfLmm9/0z77ojylkaZYMeAmSPAHFQgkKgykMB/pc8KJ0kcqXWm8wzEsXf7HBHueSX5wXcSrrHABL1QVUo2qImF3Wg2xKN9IBT2id/Slg/Nr3jtxAjXfoYAJvDIhmZgCQWtCUgaWfJ+oJY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: ce3110d1358fcd53
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=SmQL8wwvslR6wNZEx9T2399lFz3SWb46Pcz4Kd+HRKDLcYtqCV2kgLAzPGb6chNWvZH6HRrfydJs4OuLo+p2kxC9rZBGx90YXYdgF8iilEg0Lnnyh7h9v1Bu6RVyEXdEIs9zDBKkr9SOlqce/40Uav3lYPznO2CJo6/1HkjfiyK0LXWPKowgm3ta2IXdbYwnZQyAd3J3wvDPJJtXTdK7oUqtm/Ll3lyOKsNEF27GRskVo/sKR1PthZ3tWA0UHw1XKKLU9ueJBk9BNsURQOowmWFIZ14ThUSb1i+VgI64ZG+/z7fFLA1Rr7juKBKuRbww1iajmeNTkfZLyCWW3tCicA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OhckbP+ZZBCq/1yalr4ay9gb/vsT94ZQVv4mh/pGOJs=;
 b=eFlVLLhtmBwKIvhKGxH6uK9reuGoVP0L1VTGvZbP0EBVigYOg42+kQj1bq7Mfrmdr7pFX884u6edVT/fabED22uxWkuuK7PEy6d+rZcpMsTBV6GH1U8/c9w7Pt5V1ux/nTpQoRRd96g6fOQO+ynC7rdoluVvmUJX9fxtWWm9XByqHLcvr91c/vKg+eFBNcM70c40WHoOZSEpa+Z+uaAJDDBmQXkl0KAweMwgTKt3pnBaB4rZQaBUguAGD6zLsoknsOOawfk+nKOxMn+wj2l+EQGt+L8f/LRuKSZ/Z7kkwtmi1t/smhjnBNsA1CCZIyYq/EyYPxCgcq+jU5DYO1TcLQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=OhckbP+ZZBCq/1yalr4ay9gb/vsT94ZQVv4mh/pGOJs=;
 b=MtTvE1oEKQDVPx9VeEh8SmOmnLfATIVfLmm9/0z77ojylkaZYMeAmSPAHFQgkKgykMB/pc8KJ0kcqXWm8wzEsXf7HBHueSX5wXcSrrHABL1QVUo2qImF3Wg2xKN9IBT2id/Slg/Nr3jtxAjXfoYAJvDIhmZgCQWtCUgaWfJ+oJY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 04/11] xen/arm: introduce new helper parse_static_mem_prop and acquire_static_memory_bank
Date: Mon, 20 Dec 2021 05:21:16 +0000
Message-ID: <20211220052123.969876-5-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: cbfcf30c-3c23-4aad-3dfd-08d9c378a404
X-MS-TrafficTypeDiagnostic:
	AM7PR08MB5365:EE_|AM5EUR03FT025:EE_|DBBPR08MB6170:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB617072E0AA0C077D4AC005AAF77B9@DBBPR08MB6170.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:331;OLM:331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 wnSEqD9lVm2ZFN6rwrINuxgHk46MWk/V+umzCzOY0l2/TQUPExkKxBoXX2pujpRIMAhPYC5SjpOsFkX6fzTRISFy08dBu9s56wanH3KP5LTK5R2IPrBfzU/9eZpgp8oafbbWo9Ek/Ixz7TDJ+dB+UoB82LpnQwG86EwE3l/exLzgxjtI6UEuYrdiMWLG9OAqsc2xyRun8e70UE4N0jVpdtwbYKkT8/Qir7FP0QfrgfvbKHGVggJm2mqeQygXgapd4NpklbuLGFGim+LNlxdI6h/nkpMbuMPqOF9jGMT2uba6r8A2OOWBAJEIbzEwYE1cdd1gGV+ez1Kldr93r/mBxB0xLqOHc5eVVVQe+/HDAtHwYMAmeGfDms86h7dslnvgmwNbRGbeJYZbo9dOCGgO8MsTsyTl5aW2D+sMorW7ZjlLE9tCTlOAHck8KH77w5vMmkus81R1EJoyreR8iLXTEM7F5OG8kCQvKjOW8zQhsrPTAUiy0AZr6gRH43KbtkmI57MyxQxwGthZAS6hHRCp/m8kbXmpnPzWQr/pQXSM+Kg2ubcLv6cZ9uxMEgBth1UAGteZAU26ODrW4G0KNFs7l+Vtxib7IoYTYgp/W5v28qUUwGdpRe/1IgpXMFjEP1YQBgowEv6RDSQAZBnFEdKMcSFXyL7l6yBpVSQe3FlYAr29+IlGMitsrDd76O3gZJWkzd5N/FzJVcWA5K2SuoBcfnwrhLUjnsNfSzrKddiK37QBvi+f9tIEXasgyLKhDF1+l0qC7Gc/KXH9iZa8tVIdQ70XpzJZxNzhGt0hqgAACgE=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(7696005)(110136005)(44832011)(356005)(26005)(1076003)(47076005)(36756003)(86362001)(70586007)(81166007)(54906003)(70206006)(2906002)(8676002)(82310400004)(426003)(6666004)(8936002)(83380400001)(40460700001)(316002)(36860700001)(5660300002)(336012)(4326008)(2616005)(186003)(508600001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5365
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c416d4b9-94de-4a74-1470-08d9c3789ef6
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	y0jlUJSUjRKfJUVPIvOnVJTrQ3VH6CPan83TEr5QzVGg+X+YHYcB2n5OmxuxOeTeZcJ5A99huTOyRq4M31XBkuXhRn2382SFVMzT4jnJqeQVaT6cjcC6E5ojjPVNOj+dX6zqaXFjniZ8qAYkDGdWYKzyLM8OJiW/WwDY2SJmMNgQuH5KcW32jFmu8b5ZuFg9/81ADcC5kIj7o0uRnre0Fe48a52FAtyc+5sk3Uc2VP4gtbPMFTyKE4r87+WM2FibED+bLFZflS5Ff1nK7ifnYTxK3605Lf3fdfReTrf218SiI2opH7zDKMMnBXhoi+QNYMvjNpcsgN4zrA+d58xTEYsDioCw7CQMh6dcvYbAP6yLxBjMQ57yut6lSxRWHQU2XllvQQBVKrJos7anSPXcaS5bgCeBX6SBLYDeK4cBhIAV7rOaX5DUJ9WSbjKDAGjzWfBTuHklfq21ezSlxr0no2B5BgTm8x32VMee51sOJgVsZfOtfbtAsbLoB1/G+ZtpR8Mb6W1xxAdR6/LEIKVmBPdcJLCQ7cJe+EbTvf1KwH1KJHCBIr+BJMucjHRtJo0RgrphVdO8fqpd2jnJ1D2Qp5GKIH5JRKKs2bmyF3JV9Dh5Q8jFTPzU7g/oqWPn8YHy9lrHOIQvXBH9aPKZ4B8PfTTWKukNZdusrbR5Pvft1s/LgidT50kuwEvCzeW+eGNyDdoMfGhJRUIXXtMpcFpLpw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(110136005)(36756003)(54906003)(82310400004)(1076003)(186003)(70206006)(47076005)(2906002)(81166007)(4326008)(44832011)(2616005)(86362001)(6666004)(336012)(316002)(8936002)(36860700001)(7696005)(508600001)(5660300002)(83380400001)(8676002)(70586007)(426003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:21:56.4244
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cbfcf30c-3c23-4aad-3dfd-08d9c378a404
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6170

Later, we will introduce allocate_static_memory_11 for allocating static
memory for direct-map domains, and it will share a lot common codes with
the existing allocate_static_memory.

In order not to bring a lot of duplicate codes, and also to make the whole
code more readable, this commit extracts common codes into two new helpers
parse_static_mem_prop and acquire_static_memory_bank.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v3 changes:
- new commit to move the split off of the code outside in a separate patch
---
v4 changes:
- use mfn_eq() instead, because it is the only value used to indicate
there is an error and this is more lightweight than mfn_valid()
---
 xen/arch/arm/domain_build.c | 100 +++++++++++++++++++++++-------------
 1 file changed, 64 insertions(+), 36 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 5a106a977c..9206ec908d 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -509,12 +509,69 @@ static bool __init append_static_memory_to_bank(struct domain *d,
     return true;
 }
 
+static mfn_t __init acquire_static_memory_bank(struct domain *d,
+                                             const __be32 **cell,
+                                             u32 addr_cells, u32 size_cells,
+                                             paddr_t *pbase, paddr_t *psize)
+{
+    mfn_t smfn;
+    int res;
+
+    device_tree_get_reg(cell, addr_cells, size_cells, pbase, psize);
+    ASSERT(IS_ALIGNED(*pbase, PAGE_SIZE) && IS_ALIGNED(*psize, PAGE_SIZE));
+    if ( PFN_DOWN(*psize) > UINT_MAX )
+    {
+        printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
+               d, *psize);
+        return INVALID_MFN;
+    }
+
+    smfn = maddr_to_mfn(*pbase);
+    res = acquire_domstatic_pages(d, smfn, PFN_DOWN(*psize), 0);
+    if ( res )
+    {
+        printk(XENLOG_ERR
+               "%pd: failed to acquire static memory: %d.\n", d, res);
+        return INVALID_MFN;
+    }
+
+    return smfn;
+}
+
+static int __init parse_static_mem_prop(const struct dt_device_node *node,
+                                        u32 *addr_cells, u32 *size_cells,
+                                        int *length, const __be32 **cell)
+{
+    const struct dt_property *prop;
+
+    prop = dt_find_property(node, "xen,static-mem", NULL);
+    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
+                               addr_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-address-cells\".\n");
+        return -EINVAL;
+    }
+
+    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
+                               size_cells) )
+    {
+        printk(XENLOG_ERR
+               "failed to read \"#xen,static-mem-size-cells\".\n");
+        return -EINVAL;
+    }
+
+    *cell = (const __be32 *)prop->value;
+    *length = prop->length;
+
+    return 0;
+}
+
 /* Allocate memory from static memory as RAM for one specific domain d. */
 static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
-    const struct dt_property *prop;
     u32 addr_cells, size_cells, reg_cells;
     unsigned int nr_banks, gbank, bank = 0;
     const uint64_t rambase[] = GUEST_RAM_BANK_BASES;
@@ -523,24 +580,10 @@ static void __init allocate_static_memory(struct domain *d,
     u64 tot_size = 0;
     paddr_t pbase, psize, gsize;
     mfn_t smfn;
-    int res;
-
-    prop = dt_find_property(node, "xen,static-mem", NULL);
-    if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells",
-                               &addr_cells) )
-    {
-        printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d);
-        goto fail;
-    }
+    int length;
 
-    if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells",
-                               &size_cells) )
-    {
-        printk(XENLOG_ERR
-               "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d);
+    if ( parse_static_mem_prop(node, &addr_cells, &size_cells, &length, &cell) )
         goto fail;
-    }
     reg_cells = addr_cells + size_cells;
 
     /*
@@ -551,29 +594,14 @@ static void __init allocate_static_memory(struct domain *d,
     gbank = 0;
     gsize = ramsize[gbank];
     kinfo->mem.bank[gbank].start = rambase[gbank];
-
-    cell = (const __be32 *)prop->value;
-    nr_banks = (prop->length) / (reg_cells * sizeof (u32));
+    nr_banks = length / (reg_cells * sizeof (u32));
 
     for ( ; bank < nr_banks; bank++ )
     {
-        device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize);
-        ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE));
-
-        if ( PFN_DOWN(psize) > UINT_MAX )
-        {
-            printk(XENLOG_ERR "%pd: static memory size too large: %#"PRIpaddr,
-                   d, psize);
+        smfn = acquire_static_memory_bank(d, &cell, addr_cells, size_cells,
+                                          &pbase, &psize);
+        if ( mfn_eq(smfn, INVALID_MFN) )
             goto fail;
-        }
-        smfn = maddr_to_mfn(pbase);
-        res = acquire_domstatic_pages(d, smfn, PFN_DOWN(psize), 0);
-        if ( res )
-        {
-            printk(XENLOG_ERR
-                   "%pd: failed to acquire static memory: %d.\n", d, res);
-            goto fail;
-        }
 
         printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n",
                d, bank, pbase, pbase + psize);
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249408.429866 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7h-0000xS-3q; Mon, 20 Dec 2021 05:22:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249408.429866; Mon, 20 Dec 2021 05:22:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7g-0000x3-TQ; Mon, 20 Dec 2021 05:22:08 +0000
Received: by outflank-mailman (input) for mailman id 249408;
 Mon, 20 Dec 2021 05:22:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7f-0007eG-8g
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:07 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04on0630.outbound.protection.outlook.com
 [2a01:111:f400:fe0d::630])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c5905775-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:06 +0100 (CET)
Received: from AS9PR06CA0409.eurprd06.prod.outlook.com (2603:10a6:20b:461::18)
 by AM4PR08MB2641.eurprd08.prod.outlook.com (2603:10a6:205:b::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Mon, 20 Dec
 2021 05:22:03 +0000
Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::8) by AS9PR06CA0409.outlook.office365.com
 (2603:10a6:20b:461::18) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:03 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:03 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Mon, 20 Dec 2021 05:22:03 +0000
Received: from 7ecc23afb9a2.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 27C33F61-8E1D-4D7C-ABA5-597E9ED1D61C.1; 
 Mon, 20 Dec 2021 05:21:56 +0000
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ecc23afb9a2.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:56 +0000
Received: from DU2PR04CA0174.eurprd04.prod.outlook.com (2603:10a6:10:2b0::29)
 by DB9PR08MB7147.eurprd08.prod.outlook.com (2603:10a6:10:2cb::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec
 2021 05:21:52 +0000
Received: from DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2b0:cafe::d4) by DU2PR04CA0174.outlook.office365.com
 (2603:10a6:10:2b0::29) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:52 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT055.mail.protection.outlook.com (10.152.21.30) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:52 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:51 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c5905775-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wuR6YNjrEFjB7To66TkH4pIiwei4ENNply2Pgid4MnQ=;
 b=v6DPc39QIXTwlMGd7SCvJl0Uo3Q7Zxokq2GxmMp7uHdeBWZAgJxuEjrL1tGZCXtY8pzk2s1NuaQfxXPwFi/316sNqu+yuJltgX/dCgvIqPcGOhZkCeCzlvksF1U+BVehB3YGDM6OKcfIwdJ//mvyYZCvyGj/5+pcwh5vEnuxa3Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: c1e044a67c50ebe5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GF0w3iZ7zgT3EQONOqrLbL31XAjPDtieQnfBrfD2Ax3h80UuXQHK/uD29V/YSp5JSXMPU9vSLQo2PbUNkA49tE8LSYoTuroTr1odioTB0Tjy089tYXZ9+U/OmyB9GULrnp4q6ANyJUYcaD7lypsKf1dOAY0N8f2snaI1aLvCnh+Eqc7df6Y0N4060SBnvU3qTwpzYkTI/drKZvoEbXyqzVE+ckhXQpVPTWqDLSOBTPZp2jH6aO9nwSPAun2YCd8D5vhvzlTPpuGgk2SXKWk58bp+SaQP6P0IBx1rd5hUY91eVdPmTdVgenK5QTADUCwf53f/Hn5Oz3p0GNaAbZLOUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=wuR6YNjrEFjB7To66TkH4pIiwei4ENNply2Pgid4MnQ=;
 b=AjpU0U/V+WsaroPq88wwQyRKJwYzZrIVaLqMeSKD9s94wDGvBiqfahH5KRWvg3ARy47TwZJDd2LlEy3VM1aJnc42b0do0qu+u/N+RJ+qSYr0ocKw+pv9g6RQLVmIYFps6aFvnrbawj/KaIKoFH1NIxqSI+nvpTFnI7kZs4Kk/a2RqTUE3RVJjyMGBoecn8XA0yBj1w16vgvoKQh5+33x3mBbrtfD23tMLO4y7Jw4YP2paQ0xO/CMUjnLJvAMd/RhTqgpXcotbvRUqgKA165jFe5fhS7kx8OlfzzvvpnjQEiV/f5oCH9MzQ4/r5grgO/e1Sc/FKciFUkWlxStoKIEtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=wuR6YNjrEFjB7To66TkH4pIiwei4ENNply2Pgid4MnQ=;
 b=v6DPc39QIXTwlMGd7SCvJl0Uo3Q7Zxokq2GxmMp7uHdeBWZAgJxuEjrL1tGZCXtY8pzk2s1NuaQfxXPwFi/316sNqu+yuJltgX/dCgvIqPcGOhZkCeCzlvksF1U+BVehB3YGDM6OKcfIwdJ//mvyYZCvyGj/5+pcwh5vEnuxa3Q=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 06/11] xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory
Date: Mon, 20 Dec 2021 05:21:18 +0000
Message-ID: <20211220052123.969876-7-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: bd8877a3-9b4d-4e02-3189-08d9c378a7fa
X-MS-TrafficTypeDiagnostic:
	DB9PR08MB7147:EE_|AM5EUR03FT040:EE_|AM4PR08MB2641:EE_
X-Microsoft-Antispam-PRVS:
	<AM4PR08MB264184252976D154C98FD551F77B9@AM4PR08MB2641.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:326;OLM:326;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 0Zs4f0UwIqYxF88zbt4weHSwIDHtVqFlgU8QWkxXbXPSu7YqFTcg812DbuCWiLfwHPjCRJeLo9kOJ4i2SvFygj1TVX+RQVKr4Bha5Mi52czEYQiQPydrhQJmtrV7mxUk+VcM7/EgWvS4weQcuIemp567vo9KODpZF1kg48zIucgkN7vx+u/JldRn5ZarmN18eypetaF8Od5uDKjMvtaqEqDB/FYUK99mX0tpYPTluMjGR+r9tu89g/7PgJ6DVhR/ll6JUvj2M+uTGjZVMt+CnF3/eESOPkzZrDu+tRbt+Ln4X8Od0NI9eentx4458ec9QMw8acx/+vIh7VRzirmGTrOxy6VVXIjY2afIYZh5lRpuZmWghwdYq/Cj5xGPO2lyx4Dq1dIIvNI0ceSercNQZY5+97qIx5A9kgIg9ii8U5avoASTof7jdm0TPDieNNd3TiwyMmchm7awpIGBjdBateNCFBk7niXrfntLb+fzalAPToZIiHM5bDBHXN9LUfctNnK+hDrq5DAVoz8mmXPDteF2bP3oBAr+eWFBP2AvwGIMYlHhz2EOCRmrm7kjLWnV2tAkfuAFeenAZYyQr/KE9xQWOpls64mxlxDm7qXIQd1jy+doC020GShmCNBV9pPDd06Klx4Juyn3asQljdYNnDbE/RTeyn73wIHOLpqV4k6sU2+aftCd+vqLTsjbqnfJrE+kHQpQGbWquyh5wLKuV/59rqLad2j2jZ+OE19AJBaK+7KGhE7nIySIjft0VxAB3yZafBhMa6ZhLogMSkmvDykJe0kAEwImyOdJri9RGTQ=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(44832011)(8676002)(5660300002)(40460700001)(70206006)(1076003)(81166007)(2616005)(6666004)(186003)(4744005)(82310400004)(4326008)(26005)(426003)(356005)(336012)(70586007)(110136005)(54906003)(36860700001)(86362001)(47076005)(316002)(36756003)(508600001)(7696005)(2906002)(8936002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7147
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	57eac46d-9b56-4c7b-c7df-08d9c378a1b8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SocTDhisUc6YxZXTKcqpo57snoUnlPcbTK0mTv0OuvvJr6ZUwzHva+w5ayhIpy8xJfOdOLy2AJuCw7wXlhybQM++nE9aW2aJyu2JHl0pBumAVEahKrFG39xr7SjlZxnICh+/ncMdgHp4VtV0AoiKAZ51mzDGjxLxsAOcUcQF6ZUJHsUFzPQ5qkPFexSXpMEk4TK7o5s018xh+lQobkfm0JXCuLeX9QkfoXePBy5awH14ofGeEsiShq6kh17A908wFzesC1enoa+hb0slaIpJ56H6dT/En3HCLDS0VFBFpJQD1LRHWfLzHTXYMrCS3QjRD03O7m4rbw6+vkITSPsn54Sm2MUI8f8KUpgna1ymnVxtoN7S942wQXgqjn78FvD8Ll1CilFp8CXSBVCqkp4ySSdnr6naNwEjOZ4ygWTliXKm42VmLo0lQDuapijll8FtOYWq55njuMvVm9m92qmfbBC09+XbKxMCQLcgHOxswrGUb62T49G4/5UMd3xdKUn9Rz1MQZqGn0PAeK/HiLNDhPIygoguuJt5QQQX+PYGtQ+beLjQB4GTJDcWecy8FO5jC2YcMMGhUISyKAU6Yi3d1d5XtLVIM9FeabfLmoy28Vt47Q+bbRMKLzkAZG/UwaC/CuIsUDTIyaOFe+UFsy3S9dJoCoBHCLNNc9kTXCK2+qJIgLDgxfKtCo+RA4jhW/4APYptFJwjNJT7epaCF4yhpw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(26005)(8936002)(47076005)(186003)(1076003)(336012)(426003)(4326008)(36860700001)(4744005)(82310400004)(2616005)(8676002)(316002)(86362001)(44832011)(6666004)(508600001)(54906003)(110136005)(81166007)(36756003)(70206006)(70586007)(2906002)(7696005)(5660300002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:03.0694
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bd8877a3-9b4d-4e02-3189-08d9c378a7fa
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2641

Helper allocate_static_memory is not meant to be reachable when built with
!CONFIG_STATIC_MEMORY, so this commit adds ASSERT_UNREACHABLE in it to catch
potential misuse.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
---
v3 changes:
- new commit
---
 xen/arch/arm/domain_build.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index d74a3eb908..b706e674c9 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -755,6 +755,7 @@ static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
+    ASSERT_UNREACHABLE();
 }
 
 static void __init assign_static_memory_11(struct domain *d,
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249409.429876 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7i-0001GZ-GA; Mon, 20 Dec 2021 05:22:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249409.429876; Mon, 20 Dec 2021 05:22:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7i-0001F4-9B; Mon, 20 Dec 2021 05:22:10 +0000
Received: by outflank-mailman (input) for mailman id 249409;
 Mon, 20 Dec 2021 05:22:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7h-0007eG-0Q
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:09 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0629.outbound.protection.outlook.com
 [2a01:111:f400:fe02::629])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c66df3f3-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:08 +0100 (CET)
Received: from AM5PR04CA0025.eurprd04.prod.outlook.com (2603:10a6:206:1::38)
 by DBAPR08MB5845.eurprd08.prod.outlook.com (2603:10a6:10:1a5::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 05:22:05 +0000
Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:206:1:cafe::ba) by AM5PR04CA0025.outlook.office365.com
 (2603:10a6:206:1::38) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:05 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4755.23 via Frontend Transport; Mon, 20 Dec 2021 05:22:05 +0000
Received: ("Tessian outbound de6049708a0a:v110");
 Mon, 20 Dec 2021 05:22:05 +0000
Received: from 532f716b7bd6.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 B38C9A55-19C4-49AE-9C0C-740960FCFA4C.1; 
 Mon, 20 Dec 2021 05:21:59 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 532f716b7bd6.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:59 +0000
Received: from DB6P191CA0006.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::16) by
 AS8PR08MB6613.eurprd08.prod.outlook.com (2603:10a6:20b:339::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Mon, 20 Dec
 2021 05:21:57 +0000
Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::10) by DB6P191CA0006.outlook.office365.com
 (2603:10a6:6:28::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:57 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:56 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:56 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c66df3f3-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QS564yQkFbORxrHAzkwHkRpIJHS3ZaGMDAAY7ObgxuM=;
 b=TmUHiyuGArEyjWAV5EQuGFTuL6LOaBzrRejx83HHAp62m+l+rbmJusU2vIqW1aunItVnwnwLizCJlTYiTmSCVMJCcIGnGDn9YJzok4g+KtBEy9xpTvg5NvIo6gGqCVT7cj67mM0UP5O3mHXgoE48wQqalub4blQiBsscFAYuLb8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: be6038fb2697d877
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L58t8p6J9UEsDAy1hm+DLriwej0nVRJnQfOISweW3g9Vg/wWqlMNy1TA1bbElr1tob2tLs0y5NDL2CLpYsGqskGGDV0DvdImMqyWjKfCs9s/Te7ZwIhe+7b+jM/u72hdbvL7Mxtz5d/EwdVRYHdG/1+WSxNei543p/D67otoJG4Sa80sK3nnbhFHKwFbKYygZzOVNTr6ugyPczojwJbCfa7LUs43auzn6cYwfNLO1pyA6LBBwVP4fW3jAbaN/BapIuQknDeJnglc0QidawI7Nh9fgFzK6lODF2mnxCBLpIZsINsD+JgqMYfKmC5nt+Q/T3K3oQEFd/mh28V1Vtk53w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QS564yQkFbORxrHAzkwHkRpIJHS3ZaGMDAAY7ObgxuM=;
 b=ZV11EUrHxfCRIKWjYymCDCftaKYw/Uw/bsrtrwdngp+4lGHBA7UPGsukrGzMF6indeJJ94DQqE0/UxbBiNLo8wqf7eXrhjmhyh0Odux1Z3u8oPxeV1UWhuznKVX3y6lfzRRhVK9gxLMPD7/IVHECK2EYc0D0fLxumdBIp1XtEmC2gAui96upss4MSVKCbIj5j1HxCbhh28pKgOSq8yuf6fYgdTUk9a+mLpDlsvcaO/9jrTWcd2AaQvXloRYaL8+rsm1PcXD/26eIdLqLQloyfjSJ7AlLRnyLJoYdCN6fvXyrND1qpr9cmrfv5p31KKkYA02u7ByvOCeZsstH60jhIQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=QS564yQkFbORxrHAzkwHkRpIJHS3ZaGMDAAY7ObgxuM=;
 b=TmUHiyuGArEyjWAV5EQuGFTuL6LOaBzrRejx83HHAp62m+l+rbmJusU2vIqW1aunItVnwnwLizCJlTYiTmSCVMJCcIGnGDn9YJzok4g+KtBEy9xpTvg5NvIo6gGqCVT7cj67mM0UP5O3mHXgoE48wQqalub4blQiBsscFAYuLb8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 08/11] xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3
Date: Mon, 20 Dec 2021 05:21:20 +0000
Message-ID: <20211220052123.969876-9-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: ffe050a7-054a-49d9-d009-08d9c378a957
X-MS-TrafficTypeDiagnostic:
	AS8PR08MB6613:EE_|AM5EUR03FT064:EE_|DBAPR08MB5845:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB58453244E116137421BF0C7BF77B9@DBAPR08MB5845.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:78;OLM:78;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 gwrFkjdqjCRbi+RYjAdKpkIPsn/OR+Y1Mn4e3RRJkRukaihoYv+HaevKJYtcIMEJxA29W76UGflvEQ0oMHAkGr3Jyl61XH+SkfPzewHPT/0niLy7/1gj9EYuYpKqu6g8EmAN7LOlkfc2h7DkV1BhpUTeyvVdgbiaDp25AaxkZAJeoqCvd7pRSdGmX1UIisPKpSLMIwkWSiHgaX5QNAz3O0C1AFZ2MVdUWvlmMdBgQmSUwxajABeWN+aCm0hIG7D/ZHqGAGWBAOaBWHHEbmPDKV5mJHCN0k7wZfy+nTITMQcDIRPXUgIseHH3aA1/q1zbVi7WOx3pxrblps+J677cXaMXQ//yLg9IkRjTK++8DNYGW0iiKo1B1v0vaJwRfkt2eQYN6cQV3Y/3F3wMEivJilU3yF+o4s4Q/ayQ6dZ3wmI5O3TTmE8rAKXLWdOwD61O/nAtUg0hTIxYvkYfhTd5zNMKZXvZwcbhJ6c32Xvn88GkWPP9FPj0nDYMVtu/1cw8DYmvy7ac4FjUzrJeCWrmg9yRy5JsEKOc37AoAfmyp3n4P+ZIOzRGn0FeCcS5A0b/zlS5n8ZFjuT1g6UySAzwPRxSE+RmwAahYGI3WyvqHfINojLEmVUCSpcAztd19a9hxTC/y1CRQLZYyz708aeLA4zG7EPgKYvWM0XlXSCaBpVcEQtUtGWlaR11VNeWLYprdpidDRMxbKWYZJRgBl617IpPhnKSuJiIKhGrPq2aw770ughUQLOyVnlzZEC0/FcEvSugJ/f8F1DFvn81LBG7RA3APkbC7eod0bElcmhs4t8=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(8676002)(2616005)(336012)(508600001)(6666004)(2906002)(81166007)(47076005)(5660300002)(186003)(36756003)(356005)(36860700001)(54906003)(44832011)(40460700001)(8936002)(4326008)(1076003)(7696005)(426003)(110136005)(82310400004)(316002)(70586007)(86362001)(26005)(70206006)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6613
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	099f781f-64d9-4d8b-c0ea-08d9c378a446
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	jwEn7YzCU+nm0KLv7lIZaPQVn4NFhA50LabcttI9sPnQTeIWTWfia+wL4nm20egSv8a8OmsWhvFiV+EWOgqEEEXPm/37HJU47As9vwwldJRXTtnqrpLWfqowitUe0yCkSgX43aZq9e8R4E7Hq+aWUcW6mpsORT2xr1b79Cf7Vvk+2oChOE9VsNvqu0txOXt4MpWEUeQKr65u0pseHaM8sk7wGrkbL039zqzBnyYBei8HZgmJJ8O0ISm+emsA6eT+MyZZX5gxaz6d6XpBaE1307sddacglpiXYNtq5M3BmBBTg0yOuWwYCOlvWTJChty8cgRiB4rsRVpkQGNOanbCgsjphMB9ZX2MmP+zIMFEJ/60KXoHyVEeSL01eZTCJ9c7H97SR4Dm0wE9lirOgOQtl7+cWq8orkwli8S9zbuZP4FAQXDGDCemwBk56lAAkZ9a7JLQOXRL/qxfed4Ml582AUMgtSKhG7MvYTUskS8kkJrttpww+zV0HDTcgz+QcffOW1u+yCYPAG/fyonKJaVVYkEYusrDxjXmpgJEyol4HesmdV8umFJvQfWqpAQv1uTzG2nor+ezWM6vryid1H3CbpjcelD6K0SkLAuvA9JAj9c+TLoNWMZl6TlprOX8kJHdj3+kMsXeTkQKsGTc1xQomdg/ttyzcRhmQW687gyW0Wpp3DkcKeMOSPp9KAzFtksNqDYAjtlChonN08gxXwaxoQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(1076003)(110136005)(54906003)(6666004)(86362001)(36756003)(186003)(82310400004)(47076005)(81166007)(70586007)(36860700001)(7696005)(5660300002)(2616005)(70206006)(26005)(2906002)(44832011)(508600001)(8676002)(4326008)(426003)(8936002)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:05.3607
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ffe050a7-054a-49d9-d009-08d9c378a957
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5845

This commit gates function make_gicv3_domU_node with CONFIG_GICV3.

Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v4 changes:
- remove ASSERT_UNREACHABLE() to avoid breaking compilation on prod build with
CONFIG_GICV3=n
---
 xen/arch/arm/domain_build.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 4788b03d8b..139d428524 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2322,6 +2322,7 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     return res;
 }
 
+#ifdef CONFIG_GICV3
 static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 {
     void *fdt = kinfo->fdt;
@@ -2371,13 +2372,16 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 
     return res;
 }
+#endif
 
 static int __init make_gic_domU_node(struct kernel_info *kinfo)
 {
     switch ( kinfo->d->arch.vgic.version )
     {
+#ifdef CONFIG_GICV3
     case GIC_V3:
         return make_gicv3_domU_node(kinfo);
+#endif
     case GIC_V2:
         return make_gicv2_domU_node(kinfo);
     default:
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249410.429887 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7k-0001bS-E4; Mon, 20 Dec 2021 05:22:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249410.429887; Mon, 20 Dec 2021 05:22:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7k-0001aP-3V; Mon, 20 Dec 2021 05:22:12 +0000
Received: by outflank-mailman (input) for mailman id 249410;
 Mon, 20 Dec 2021 05:22:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7h-0007eG-NP
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:09 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on2062a.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c67d4210-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:08 +0100 (CET)
Received: from DB6P191CA0005.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::15) by
 AM6PR08MB4280.eurprd08.prod.outlook.com (2603:10a6:20b:b6::19) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.17; Mon, 20 Dec 2021 05:22:04 +0000
Received: from DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:28:cafe::22) by DB6P191CA0005.outlook.office365.com
 (2603:10a6:6:28::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:04 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT043.mail.protection.outlook.com (10.152.20.236) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:04 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Mon, 20 Dec 2021 05:22:04 +0000
Received: from 8c2dfc853f4e.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 9E9EF06F-E9BD-4E3D-A601-BBA77A94BF25.1; 
 Mon, 20 Dec 2021 05:21:58 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8c2dfc853f4e.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:21:58 +0000
Received: from AM6P193CA0132.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::37)
 by PR3PR08MB5705.eurprd08.prod.outlook.com (2603:10a6:102:93::23) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec
 2021 05:21:56 +0000
Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:85:cafe::1d) by AM6P193CA0132.outlook.office365.com
 (2603:10a6:209:85::37) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:56 +0000
Received: from nebula.arm.com (40.67.248.234) by
 VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:55 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com
 (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:54 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 20
 Dec 2021 05:21:53 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c67d4210-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5suzMass5gOg79pAHzTEDhmZbMp9xyKiX7pr/HGQF0Q=;
 b=EHosA4cnsU+YWALe/pVYff2EVhMu4JpImWPMq0tBvR+Mlfije0vMCxNGB+T1PRuk5jeaEG1yig0z7uBYsqe6lr29LU89XOR1OJ6iigTksvZVb6cUcWVk0u9fovvk0LKFTD9sjWZywWk8D3O9X5SsmHRxO95GFJOn4HtiB0Vzyfs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6922bb3ad85c04fd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Gi+urszbpnlw+ucy3g+Mj7KlDpolOWlLwGSReXhkRRHbR6XK3qXZOyJ39h06PsZkumpufzBOHeF0HB+faPHNX4RtTt/x8tidP9TjYKTAHDmqoraJZVrTS7GpzYcumx7KvPclJ2R52Srfm+Ko98aLzh5UTzXQjldp6Q2b0DdziY/ju003HInrrvQ6Q0gjl9Zv0zKgmF/vE2I/N9wJUhB6H6DXqIT0oO63md/kH64znSWvxkO2RqT0tCmt++2Od+2DYI4owRj58RKHbyeSZwafQReS7cbPgNtYLvY15jNYUN1fC61g83bF974+HfiJ2gV9jyAnQikZ5jXxzn/JiejWnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5suzMass5gOg79pAHzTEDhmZbMp9xyKiX7pr/HGQF0Q=;
 b=e2XrdXp/Vqa9s2BYpQDaULRGqzZYTHIYkdpwCqxnGa4Unxxmq6I6Fea+ObEbcf++fbEEL3wGg1rsxnQhHJLi6SmTpQSSBztD8o89mfRrJniGetN/6sk3Ow9cO331F2zpw3Eyp0jUTRWBGvVSwtXqPcibvV1+u1if+/90BtVetdmZBZaN4pJmTyFgvtDOBuedbwsjD8bEAcBgBt2wPrqpCh3Nc9+hr4fYthGSMrNAEkzLV+OL6v4453PQQuWwCZYjZ/gtIgKAwOlVFpvhBAj7jHGR8UZ54fxO7b+2OAqDoRvS9v171m2a9tYncFlKn6ZCaFkYfhOYgulJlwrd/m3GFg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5suzMass5gOg79pAHzTEDhmZbMp9xyKiX7pr/HGQF0Q=;
 b=EHosA4cnsU+YWALe/pVYff2EVhMu4JpImWPMq0tBvR+Mlfije0vMCxNGB+T1PRuk5jeaEG1yig0z7uBYsqe6lr29LU89XOR1OJ6iigTksvZVb6cUcWVk0u9fovvk0LKFTD9sjWZywWk8D3O9X5SsmHRxO95GFJOn4HtiB0Vzyfs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 07/11] xen/arm: if direct-map domain use native addresses for GICv2
Date: Mon, 20 Dec 2021 05:21:19 +0000
Message-ID: <20211220052123.969876-8-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: b645d35f-e08a-4f75-521c-08d9c378a8f8
X-MS-TrafficTypeDiagnostic:
	PR3PR08MB5705:EE_|DB5EUR03FT043:EE_|AM6PR08MB4280:EE_
X-Microsoft-Antispam-PRVS:
	<AM6PR08MB4280107EFCBA8F7B72432AECF77B9@AM6PR08MB4280.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /0kL8LQHnspemuLNv/coXD+8MO3dwDVlLci8MUFdswrNtjjhDOhIxGjnYbd0co6+LZx6eK0yK8uMHeNv5lftZd5FE5A+UpOOdklL26ueZWTEHj6BxOnJw2lcK6wMcKLE+475YHrT2jLk1tYqulO45zYisM+IWbqQlfU5g7L9fJrY010tie+6oIwObAvbBMHsG1g4+z/HcIECofNc4t7dbaWvqG79fmyeB/KhikWBsu75W4VYPsie0K2TcoezyUb5fMQk1Z04xXdxvT9CiS0vlqpzUIBDpQp9XguMJ+2HIC1SNCkH8Dv7yruwhxQWQUqftgut8IWzQaD1+ojMdQebAiHDY5uKk14DidwGdbUGjOMSX6/CV7xc/5jbnGKAAehJetAngWnvuswJb15SvKDMBu1OhftX7ejVll/1JCGfFl5ND53lGCSoAWg/ShNwbawV3lMVceg4doXsgvx880yG45PbOP1q/uFC5ucUQKKHgTgUDCPkse0xlzTwk2ft9PYIBJvKUsLOSCc3BZO1eMRWu2DHtK/lEhOZPiTkhkaTSK4/tZRQgovzMhojnp8ZDyOzZNri1hEg/tVuzacHLw14cTJdat3542/u6go4nB7ziks2NpPqAvrZZOR32bDXu8Dj9Oeun5f1fnVG4rbITF/KwTM3yhbqbRxpNM5GTrRnK8U1mjXXmrN00mbNk1d6GFQc/x9I/EWbhZzQphUh7BYDeRDks3BsVrVchGh3L/MPO8J4uXyxgl+H4IONyaCelqQCmFrno2O5EYxZxDlrimU3x7i3dxMQXyXiD9AMyHfWhgw=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(36860700001)(1076003)(508600001)(54906003)(4326008)(186003)(86362001)(336012)(316002)(356005)(110136005)(6666004)(81166007)(82310400004)(36756003)(47076005)(44832011)(7696005)(40460700001)(83380400001)(2616005)(5660300002)(426003)(2906002)(8936002)(8676002)(70586007)(70206006)(26005)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5705
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	b6a3eb34-ec49-4f6f-9eb9-08d9c378a396
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	FtGB+r2R25c1Umray4noId0hKTOmj1KmZTpmcvro2Mz5HsjcWenwUs8ydjhVCOYKKBbzWdVS63jmtv/mvo2Ng5SCqNjJx7HUD7mf0PSYHxOQ2xPDPXH9ljhYvjQyYO7WbaA62Ar/XZFJjA/y/9aKfsO1ft8Kn61JDCkj1nV1vTfd1yUDSLgy6MxwR24D+Z2oU/PUN31FoOldmhokPUEfUpZ3aktWJKHK5JUvpj7sR60DQxL3N304/nfJQCk7pWDe3S3buQY5LX7JgG8eiwHu35pF+q1See0hawB15180EmftchIsMjicgsm296mn40wwNt22RFhAV0HQxLDcShGJUM4JV1884sbcoLIfFRKHlbvuVVBIe64aI+yc4sJ+In5CMthvWYrsTVTWQ7Zb3PoNQPRQBXJSxS5d7G2kDBNu37Df5b/yVQ89BPYvreqUN27vkMWAZ0rOpzt5rLESLLy5dEcZM9t9kDw1f74DRpte9KgseRbdN+L/gZbCMxY/dYPPG2m220HSam7uGOkrtumC3QOszrh9yJejzJz918V634WBhUKFgbuKcWFnkge9LYqPXKgc1MLcHWCafB9K+HWdXADEO3RgtIE7QWss4jrRJ2IAvwY/BHmkXlAm0egwO7rFIw5nnqCorJScUralOBN7vvPwP1KUGp3YY+WDrGrXBA9kk+LJrepnAn4uN6k2BWaos1gRFzoL2KwE7PfaQelM9Q==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2906002)(316002)(1076003)(5660300002)(2616005)(110136005)(36860700001)(86362001)(36756003)(70586007)(4326008)(70206006)(508600001)(81166007)(8936002)(47076005)(82310400004)(83380400001)(186003)(6666004)(26005)(54906003)(7696005)(44832011)(426003)(8676002)(336012);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:04.7817
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b645d35f-e08a-4f75-521c-08d9c378a8f8
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT043.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4280

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Today we use native addresses to map the GICv2 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all domains that are direct-mapped.

NEW VGIC has different naming schemes, like referring distributor base
address as vgic_dist_base, other than the dbase. So this patch also introduces
vgic_dist_base/vgic_cpu_base accessor to access correct distributor base
address/cpu interface base address on varied scenarios,

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes
- combine all changes in patch 4-6 here
---
v3 changes
- refine comment message
- add a comment explaining how the 38 was found of "char buf[38]"
- simply map the CPU interface at the GPA vgic_v2_hw.cbase
- remove a spurious change
---
v4 changes:
- refine comment to let it be a summary of the if/else if/else.
---
 xen/arch/arm/domain_build.c         | 11 +++++++---
 xen/arch/arm/include/asm/new_vgic.h | 10 +++++++++
 xen/arch/arm/include/asm/vgic.h     | 11 ++++++++++
 xen/arch/arm/vgic-v2.c              | 34 +++++++++++++++++++++++------
 xen/arch/arm/vgic/vgic-v2.c         | 34 +++++++++++++++++++++++------
 5 files changed, 83 insertions(+), 17 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index b706e674c9..4788b03d8b 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2273,8 +2273,13 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
     int res = 0;
     __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
     __be32 *cells;
+    const struct domain *d = kinfo->d;
+    /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */
+    char buf[38];
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICD_BASE));
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2296,9 +2301,9 @@ static int __init make_gicv2_domU_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICD_BASE, GUEST_GICD_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICD_SIZE);
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICC_BASE, GUEST_GICC_SIZE);
+                       vgic_cpu_base(&d->arch.vgic), GUEST_GICC_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if (res)
diff --git a/xen/arch/arm/include/asm/new_vgic.h b/xen/arch/arm/include/asm/new_vgic.h
index 97d622bff6..ab57fcd91d 100644
--- a/xen/arch/arm/include/asm/new_vgic.h
+++ b/xen/arch/arm/include/asm/new_vgic.h
@@ -186,6 +186,16 @@ struct vgic_cpu {
     uint32_t num_id_bits;
 };
 
+static inline paddr_t vgic_cpu_base(const struct vgic_dist *vgic)
+{
+    return vgic->vgic_cpu_base;
+}
+
+static inline paddr_t vgic_dist_base(const struct vgic_dist *vgic)
+{
+    return vgic->vgic_dist_base;
+}
+
 #endif /* __ASM_ARM_NEW_VGIC_H */
 
 /*
diff --git a/xen/arch/arm/include/asm/vgic.h b/xen/arch/arm/include/asm/vgic.h
index ade427a808..d2a9fc7d83 100644
--- a/xen/arch/arm/include/asm/vgic.h
+++ b/xen/arch/arm/include/asm/vgic.h
@@ -152,6 +152,7 @@ struct vgic_dist {
     struct pending_irq *pending_irqs;
     /* Base address for guest GIC */
     paddr_t dbase; /* Distributor base address */
+    paddr_t cbase; /* CPU interface base address */
 #ifdef CONFIG_GICV3
     /* GIC V3 addressing */
     /* List of contiguous occupied by the redistributors */
@@ -271,6 +272,16 @@ static inline int REG_RANK_NR(int b, uint32_t n)
 
 enum gic_sgi_mode;
 
+static inline paddr_t vgic_cpu_base(const struct vgic_dist *vgic)
+{
+    return vgic->cbase;
+}
+
+static inline paddr_t vgic_dist_base(const struct vgic_dist *vgic)
+{
+    return vgic->dbase;
+}
+
 /*
  * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size <s> with
  * <b>-bits-per-interrupt.
diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c
index 589c033eda..b1bd7a46ad 100644
--- a/xen/arch/arm/vgic-v2.c
+++ b/xen/arch/arm/vgic-v2.c
@@ -654,12 +654,16 @@ static int vgic_v2_vcpu_init(struct vcpu *v)
 static int vgic_v2_domain_init(struct domain *d)
 {
     int ret;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
 
     /*
-     * The hardware domain gets the hardware address.
-     * Guests get the virtual platform layout.
+     * The hardware domain and direct-mapped domain both get the hardware
+     * address.
+     * We have to handle them separately because the hwdom is re-using the
+     * same Device-Tree as the host (see more details below).
+     *
+     * Other domains get the virtual platform layout.
      */
     if ( is_hardware_domain(d) )
     {
@@ -671,10 +675,26 @@ static int vgic_v2_domain_init(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = vgic_v2_hw.cbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase;
         csize = vgic_v2_hw.csize;
         vbase = vgic_v2_hw.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        /*
+         * For all the direct-mapped domain other than the hardware domain,
+         * we only map a 8kB CPU interface but we make sure it is at a
+         * location occupied by the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.dbase = vgic_v2_hw.dbase;
+        d->arch.vgic.cbase = vgic_v2_hw.cbase;
+        csize = GUEST_GICC_SIZE;
+        vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
+    }
     else
     {
         d->arch.vgic.dbase = GUEST_GICD_BASE;
@@ -685,7 +705,7 @@ static int vgic_v2_domain_init(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.cbase = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = vgic_v2_hw.vbase + vgic_v2_hw.aliased_offset;
     }
@@ -694,8 +714,8 @@ static int vgic_v2_domain_init(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.cbase),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
         return ret;
 
diff --git a/xen/arch/arm/vgic/vgic-v2.c b/xen/arch/arm/vgic/vgic-v2.c
index b5ba4ace87..1a99d3a8b4 100644
--- a/xen/arch/arm/vgic/vgic-v2.c
+++ b/xen/arch/arm/vgic/vgic-v2.c
@@ -258,13 +258,17 @@ void vgic_v2_enable(struct vcpu *vcpu)
 int vgic_v2_map_resources(struct domain *d)
 {
     struct vgic_dist *dist = &d->arch.vgic;
-    paddr_t cbase, csize;
+    paddr_t csize;
     paddr_t vbase;
     int ret;
 
     /*
-     * The hardware domain gets the hardware address.
-     * Guests get the virtual platform layout.
+     * The hardware domain and direct-mapped domain both get the hardware
+     * address.
+     * We have to handle them separately because the hwdom is re-using the
+     * same Device-Tree as the host (see more details below).
+     *
+     * Other domains get the virtual platform layout.
      */
     if ( is_hardware_domain(d) )
     {
@@ -276,10 +280,26 @@ int vgic_v2_map_resources(struct domain *d)
          * Note that we assume the size of the CPU interface is always
          * aligned to PAGE_SIZE.
          */
-        cbase = gic_v2_hw_data.cbase;
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
         csize = gic_v2_hw_data.csize;
         vbase = gic_v2_hw_data.vbase;
     }
+    else if ( is_domain_direct_mapped(d) )
+    {
+        d->arch.vgic.vgic_dist_base = gic_v2_hw_data.dbase;
+        /*
+         * For all the direct-mapped domain other than the hardware domain,
+         * we only map a 8kB CPU interface but we make sure it is at a location
+         * occupied by the physical GIC in the host device tree.
+         *
+         * We need to add an offset to the virtual CPU interface base
+         * address when the GIC is aliased to get a 8kB contiguous
+         * region.
+         */
+        d->arch.vgic.vgic_cpu_base = gic_v2_hw_data.cbase;
+        csize = GUEST_GICC_SIZE;
+        vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
+    }
     else
     {
         d->arch.vgic.vgic_dist_base = GUEST_GICD_BASE;
@@ -290,7 +310,7 @@ int vgic_v2_map_resources(struct domain *d)
          * region.
          */
         BUILD_BUG_ON(GUEST_GICC_SIZE != SZ_8K);
-        cbase = GUEST_GICC_BASE;
+        d->arch.vgic.vgic_cpu_base = GUEST_GICC_BASE;
         csize = GUEST_GICC_SIZE;
         vbase = gic_v2_hw_data.vbase + gic_v2_hw_data.aliased_offset;
     }
@@ -308,8 +328,8 @@ int vgic_v2_map_resources(struct domain *d)
      * Map the gic virtual cpu interface in the gic cpu interface
      * region of the guest.
      */
-    ret = map_mmio_regions(d, gaddr_to_gfn(cbase), csize / PAGE_SIZE,
-                           maddr_to_mfn(vbase));
+    ret = map_mmio_regions(d, gaddr_to_gfn(d->arch.vgic.vgic_cpu_base),
+                           csize / PAGE_SIZE, maddr_to_mfn(vbase));
     if ( ret )
     {
         gdprintk(XENLOG_ERR, "Unable to remap VGIC CPU to VCPU\n");
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249412.429893 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7l-0001gR-71; Mon, 20 Dec 2021 05:22:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249412.429893; Mon, 20 Dec 2021 05:22:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7k-0001ex-LW; Mon, 20 Dec 2021 05:22:12 +0000
Received: by outflank-mailman (input) for mailman id 249412;
 Mon, 20 Dec 2021 05:22:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7j-0007eG-38
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:11 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on0625.outbound.protection.outlook.com
 [2a01:111:f400:fe09::625])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c78408e1-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:10 +0100 (CET)
Received: from DB6PR0601CA0018.eurprd06.prod.outlook.com (2603:10a6:4:7b::28)
 by DBAPR08MB5831.eurprd08.prod.outlook.com (2603:10a6:10:1a8::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Mon, 20 Dec
 2021 05:22:07 +0000
Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:7b:cafe::44) by DB6PR0601CA0018.outlook.office365.com
 (2603:10a6:4:7b::28) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:07 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Mon, 20 Dec 2021 05:22:07 +0000
Received: from b30482bb96e9.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E845E1C8-1905-4984-88DF-C32639B7C62A.1; 
 Mon, 20 Dec 2021 05:22:01 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b30482bb96e9.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:22:01 +0000
Received: from DB6P193CA0024.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::34) by
 AM0PR08MB3201.eurprd08.prod.outlook.com (2603:10a6:208:59::27) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.17; Mon, 20 Dec 2021 05:21:59 +0000
Received: from DB5EUR03FT051.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:6:29:cafe::a1) by DB6P193CA0024.outlook.office365.com
 (2603:10a6:6:29::34) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:59 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT051.mail.protection.outlook.com (10.152.21.19) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:21:59 +0000
Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:21:58 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com
 (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Mon, 20
 Dec 2021 05:21:58 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c78408e1-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yu1JL9lQaWyoBKQlyQJnoC/QTGNH9xLBeVUjcOwrfBE=;
 b=hRS/6WzX2PBVakxrUpxlSrHDO1D6zMjVRLm6/hTk+pEGSLBGazlNiQ3GKqSqIkX0TNhSLKTIcIOPj+GBhXZ5hn650DA5rkqdIXMlMDumqoWFgKceLtZINltmbx/MrsMKfKmwO9kkATEHE35+4lpjm5Pk+Mcb22QEA8zpAxSagzY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 7015131ac0f81868
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RrPIdh7AfTolG0Z9aTUHfMVXjwwQ2G+RrbxkKt9+qxYy8qD6VOTu5KYjq5o/BSob8s+HKFwHEignsAL2iyDWj4y65xMLKGztf5IajSQDwvER+1BkdYg81TPGV6hxfaOKDCVTVZcKEPJu8DnZuylK4d13ZlKJRMbPWQGkZEuCz+clLJbr0BMEDojwkP7XX/zNclZL/ElJ8Po0IT08Asuxl8SG3/6xWZeFTkgzHIx6Gjss9ZfPdMfnpYs0nVongIdqu3s4hHA2NgMJqU5xRCg9PiBC6rI9WcuxMR0siTOnvVfqUezCLeziTLc+pm4hPCBAg1jVjLsuIiLLFiZ+ylDH2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Yu1JL9lQaWyoBKQlyQJnoC/QTGNH9xLBeVUjcOwrfBE=;
 b=iP4tKC3WD/86gG0DBPAeWftXgdJe4FGl7bwGDXVA5x7z0TcVkGJLtTg/sdGH/XribEF7lrczauvW+8KHEduRDRyISQOEQB79kQzpaqjEtLFwHE+BaCtfrlEjZipnnumfVcNklhkhYjJcSQ1anLMkUqK0oitUK/Odm9gJJA7p1Oqak8w14E5fH6ewYr6Kbgq5m0dt+uxvA6p97xa52a72izGq2+1x1aeh0sShWu1Mq6vilYu/q3ynEgvbjJgYlSL8B1fmbv2AMzbAl02HG2IajFcoB1Pqb9nn86bHnYWczsQNfsm8t5I4mN69ryjzUxfeu7DeaG2PwhmYjLLEfG7SkA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yu1JL9lQaWyoBKQlyQJnoC/QTGNH9xLBeVUjcOwrfBE=;
 b=hRS/6WzX2PBVakxrUpxlSrHDO1D6zMjVRLm6/hTk+pEGSLBGazlNiQ3GKqSqIkX0TNhSLKTIcIOPj+GBhXZ5hn650DA5rkqdIXMlMDumqoWFgKceLtZINltmbx/MrsMKfKmwO9kkATEHE35+4lpjm5Pk+Mcb22QEA8zpAxSagzY=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 09/11] xen/arm: if direct-map domain use native addresses for GICv3
Date: Mon, 20 Dec 2021 05:21:21 +0000
Message-ID: <20211220052123.969876-10-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: fe50a42e-41a9-4512-52cd-08d9c378aacd
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB3201:EE_|DB5EUR03FT013:EE_|DBAPR08MB5831:EE_
X-Microsoft-Antispam-PRVS:
	<DBAPR08MB583183246AF428A4C86A7304F77B9@DBAPR08MB5831.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 /+9Aj73JQ4bd5Uop/CVWYPd7Gbvp0bTJM+SvUIow1pwVDQLClxnboo/d2gtdLx9IBD+vELazK0SuhgvCVwHW8I4oB8Lvwd4dssmSpFhhmxancKQiyL72n8os5hrov2BlsOa/PK0VY/nSA2O15MycEWPOR/uxPmk9VIeibSY0jGI/tPvQpxugjA/brY886GEkCdRslCiz8FITsbNi7UYxrSctJQXBxtU9FRQTwMpaIduxY8wiJguiVtEB046AyIeHpZpT+7rXw+P9zv5GLz6vwRzxueu5VEqm7apkx4Pzma6HL4239dBq3kJBVwWVYkdNSpJMQ+NYTzDt6iy0gS2VQSF0HlXLbCMVZ6rvPHUE04J74Yy8/doCQjcqaYuolpw3zpEN+QDLCqRQbeZHW/ray+reKHMm7R5acEbenqYs+WW0vdWV4rrKzW3NxXcE5PLUpnKUfwgeckzU4Dbs7uTtymWnmiTb4vwgIY0uAqeQ8Ez5pEgl4toCkrMFouEcjfJBPXJVJtJBE3XJwsRkC6FobM8cUtjKw4ctdYQpmWJLdQDo9vUWwflgh0OFAAQKFirxwazYc9uA7H8TTnQCp/HrBa1d4naPGPmeNQYq6tRiTu2GoKIjNrC2JzJZgWfsq0rRFPQz9UGstr/RFtdd7B4bfU6keyu5oh0Znlf/MlfGLLK7WdFot2h/hTtw2YaB6yHG3b9IdINsTy0rbvj1CyEnSLn4xT8KD4w36SZ53xUxtgPec5xLs5ANyQD6hMlKcS+nKz50SWq8e3vx7N1fMafVi+JkgmY04oFqv4ZszET5n30=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(40470700001)(336012)(426003)(6666004)(70586007)(2616005)(1076003)(70206006)(44832011)(47076005)(36756003)(4326008)(36860700001)(5660300002)(356005)(81166007)(83380400001)(54906003)(82310400004)(8676002)(8936002)(40460700001)(86362001)(2906002)(110136005)(316002)(26005)(186003)(7696005)(508600001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3201
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	dd95e688-21cc-4427-081d-08d9c378a5a3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	2e2Q2SuMNCZJLUl2Hjveyi3vdV98WD5fPV9ADelgq21FQ8rB8WDilwIlLNDsFuVCqhqwNdtSVI/7d6DQwDAB7aQqey76l4k4ucUyhwki/IygD9Cpv1G95RtP/OOYh5biC6E+ZUwVyVexe2NLGkGlh3c67k83CvbnQd9Iuo5yr5EYM4ZQ3nRYZBB5rLuiTWM5OyAKXr2rFlC6syzvkHSmD2yP/zhNZPFD8GK1b5z+HLyDDuYuHhq/CxYPksBEJ7zhPhRW4FgcfEQYfz+J/VjUMr6dYquif/16p8ZWWAU0MywQMYtN3cANPBD29Ip3qCrGZPHPjCWsPOyZNyecmw0hHExsJC3vLEKTNMtvCE6NrdOm64RqEp/DvVVQdjAUQRm7WdAHKL7ZcxKnOiC+VtTTJi7rHiL2EIUR26DdYHZcX7wdErEUkynGNcOJrsn58YvZ2MGv99pQ3GhAUjWd0n6EXWImxx0z+VVmeRSTPaqjFme+f5lGXAitFRL70b0ObUbsjE/Gl22r1Wjv1IAgX+ZzcY3/G6xtHwRZ8h+/nmsvOkWfQOdevqc2bF0DeYqpcYS1OlfpA8zf/SQelRx9ulTx19QSoDDmKM0yUlQReim8ZHFaIwNw0Ep5DoJ/6h7tRO2gW1Nf03GCKXEMPGFjRHhd5pIl1Y7W286MjoDMvLGD9fm2nmwoDVDx/snsmtkyuQgOTYmGpIrod4yaDi0ve6UzIQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(54906003)(83380400001)(86362001)(110136005)(81166007)(44832011)(82310400004)(8676002)(316002)(6666004)(70586007)(70206006)(508600001)(2906002)(186003)(36756003)(336012)(5660300002)(7696005)(26005)(47076005)(8936002)(2616005)(1076003)(36860700001)(4326008)(426003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:07.8554
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: fe50a42e-41a9-4512-52cd-08d9c378aacd
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5831

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

Today we use native addresses to map the GICv3 for Dom0 and fixed
addresses for DomUs.

This patch changes the behavior so that native addresses are used for
all domain which is using the host memory layout

Considering that DOM0 may not always be directly mapped in the future,
this patch introduces a new helper "domain_use_host_layout()" that
wraps both two check "is_domain_direct_mapped(d) || is_hardware_domain(d)"
for more flexible usage.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- remove redistributor accessor
- introduce new helper "is_domain_use_host_layout()"
- comment fix
---
v3 changes:
- the comment on top of 'buf' to explain how 38 was found
- fix res getting overwritten
- drop 'cells += (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS)'
- free 'reg' right way
- fix comment
- rename 'is_domain_use_host_layout()' to 'domain_use_host_layout()'
---
v4 changes:
- refine comment
---
 xen/arch/arm/domain_build.c       | 34 +++++++++++++++++++++++--------
 xen/arch/arm/include/asm/domain.h | 14 +++++++++++++
 xen/arch/arm/vgic-v3.c            | 26 ++++++++++++-----------
 3 files changed, 54 insertions(+), 20 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 139d428524..9a7145b3ee 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -2327,10 +2327,16 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
 {
     void *fdt = kinfo->fdt;
     int res = 0;
-    __be32 reg[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2];
-    __be32 *cells;
+    __be32 *reg, *cells;
+    const struct domain *d = kinfo->d;
+    /* Placeholder for interrupt-controller@ + a 64-bit number + \0 */
+    char buf[38];
+    unsigned int i, len = 0;
+
+    snprintf(buf, sizeof(buf), "interrupt-controller@%"PRIx64,
+             vgic_dist_base(&d->arch.vgic));
 
-    res = fdt_begin_node(fdt, "interrupt-controller@"__stringify(GUEST_GICV3_GICD_BASE));
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2350,13 +2356,25 @@ static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
     if ( res )
         return res;
 
-    cells = &reg[0];
-    dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICD_BASE, GUEST_GICV3_GICD_SIZE);
+    /* reg specifies all re-distributors and Distributor. */
+    len = (GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) *
+          (d->arch.vgic.nr_regions + 1) * sizeof(__be32);
+    reg = xmalloc_bytes(len);
+    if ( reg == NULL )
+        return -ENOMEM;
+    cells = reg;
+
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
-                       GUEST_GICV3_GICR0_BASE, GUEST_GICV3_GICR0_SIZE);
+                       vgic_dist_base(&d->arch.vgic), GUEST_GICV3_GICD_SIZE);
 
-    res = fdt_property(fdt, "reg", reg, sizeof(reg));
+    for ( i = 0; i < d->arch.vgic.nr_regions; i++)
+        dt_child_set_range(&cells,
+                           GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS,
+                           d->arch.vgic.rdist_regions[i].base,
+                           d->arch.vgic.rdist_regions[i].size);
+
+    res = fdt_property(fdt, "reg", reg, len);
+    xfree(reg);
     if (res)
         return res;
 
diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h
index cb37ce89ec..848fec8a0f 100644
--- a/xen/arch/arm/include/asm/domain.h
+++ b/xen/arch/arm/include/asm/domain.h
@@ -31,6 +31,20 @@ enum domain_type {
 
 #define is_domain_direct_mapped(d) (d->arch.directmap)
 
+/*
+ * Is the domain using the host memory layout?
+ *
+ * Direct-mapped domain will always have the RAM mapped with GFN == MFN.
+ * To avoid any trouble finding space, it is easier to force using the
+ * host memory layout.
+ *
+ * The hardware domain will use the host layout regardless of
+ * direct-mapped because some OS may rely on a specific address ranges
+ * for the devices.
+ */
+#define domain_use_host_layout(d) (is_domain_direct_mapped(d) || \
+                                   is_hardware_domain(d))
+
 struct vtimer {
     struct vcpu *v;
     int irq;
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 65bb7991a6..144089a7b6 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1640,14 +1640,15 @@ static inline unsigned int vgic_v3_max_rdist_count(struct domain *d)
      * Normally there is only one GICv3 redistributor region.
      * The GICv3 DT binding provisions for multiple regions, since there are
      * platforms out there which need those (multi-socket systems).
-     * For Dom0 we have to live with the MMIO layout the hardware provides,
-     * so we have to copy the multiple regions - as the first region may not
-     * provide enough space to hold all redistributors we need.
+     * For domain using the host memory layout, we have to live with the MMIO
+     * layout the hardware provides, so we have to copy the multiple regions
+     * - as the first region may not provide enough space to hold all
+     * redistributors we need.
      * However DomU get a constructed memory map, so we can go with
      * the architected single redistributor region.
      */
-    return is_hardware_domain(d) ? vgic_v3_hw.nr_rdist_regions :
-               GUEST_GICV3_RDIST_REGIONS;
+    return domain_use_host_layout(d) ? vgic_v3_hw.nr_rdist_regions :
+                                       GUEST_GICV3_RDIST_REGIONS;
 }
 
 static int vgic_v3_domain_init(struct domain *d)
@@ -1669,10 +1670,11 @@ static int vgic_v3_domain_init(struct domain *d)
     radix_tree_init(&d->arch.vgic.pend_lpi_tree);
 
     /*
-     * Domain 0 gets the hardware address.
-     * Guests get the virtual platform layout.
+     * For domain using the host memory layout, it gets the hardware
+     * address.
+     * Other domains get the virtual platform layout.
      */
-    if ( is_hardware_domain(d) )
+    if ( domain_use_host_layout(d) )
     {
         unsigned int first_cpu = 0;
 
@@ -1695,10 +1697,10 @@ static int vgic_v3_domain_init(struct domain *d)
         }
 
         /*
-         * The hardware domain may not use all the re-distributors
-         * regions (e.g when the number of vCPUs does not match the
-         * number of pCPUs). Update the number of regions to avoid
-         * exposing unused region as they will not get emulated.
+         * For domain using the host memory layout, it may not use all
+         * the re-distributors regions (e.g when the number of vCPUs does
+         * not match the number of pCPUs). Update the number of regions to
+         * avoid exposing unused region as they will not get emulated.
          */
         d->arch.vgic.nr_regions = i + 1;
 
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:22:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:22:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249417.429910 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7r-0002v9-Qf; Mon, 20 Dec 2021 05:22:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249417.429910; Mon, 20 Dec 2021 05:22:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzB7r-0002um-KP; Mon, 20 Dec 2021 05:22:19 +0000
Received: by outflank-mailman (input) for mailman id 249417;
 Mon, 20 Dec 2021 05:22:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7q-0007eH-7r
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:18 +0000
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03on062e.outbound.protection.outlook.com
 [2a01:111:f400:fe09::62e])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id cad04c9b-6154-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 06:22:15 +0100 (CET)
Received: from DB8PR03CA0003.eurprd03.prod.outlook.com (2603:10a6:10:be::16)
 by DB9PR08MB6474.eurprd08.prod.outlook.com (2603:10a6:10:255::17) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Mon, 20 Dec
 2021 05:22:11 +0000
Received: from DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:be:cafe::94) by DB8PR03CA0003.outlook.office365.com
 (2603:10a6:10:be::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:11 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT017.mail.protection.outlook.com (10.152.20.114) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:11 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Mon, 20 Dec 2021 05:22:11 +0000
Received: from f12c4f60432a.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 E634AF5C-8CD2-4994-8058-C71DCFF15596.1; 
 Mon, 20 Dec 2021 05:22:05 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f12c4f60432a.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:22:05 +0000
Received: from DB8PR09CA0030.eurprd09.prod.outlook.com (2603:10a6:10:a0::43)
 by AM0PR08MB3697.eurprd08.prod.outlook.com (2603:10a6:208:103::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Mon, 20 Dec
 2021 05:22:03 +0000
Received: from DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::51) by DB8PR09CA0030.outlook.office365.com
 (2603:10a6:10:a0::43) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:03 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT050.mail.protection.outlook.com (10.152.21.128) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:02 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:22:00 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:21:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cad04c9b-6154-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ztI108Injf1XAV21Go3AKAH/1s8azeMVIu7K0T9uGCk=;
 b=LH2WgRmeRhpRFCJFTVGCG7EeTqDQLyd/Tz+F7V/PdcaKUGnjfnoqC6fSdER3MkXSTekWNwpDG9yH0DgbslMewCC13IC8xuMU9BPSxiFqG1XiJddEfjmN36IIPlV8utbY4b1AsGmDNhHOyH84oo9jRtsfo/jJpta5ZXzQOMOp0Ms=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 95b085677d276f6f
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=XXSEV/vuJPbgt0ovwSKpGpLJWwV2o7DNqV9Ca8Wp753KM31ETYVi5c+RXzPTNRG2zM/j8Her1t6bvWWb8XYN+jq5tsdZ9uVDVr54xOeRcQE8fw9dv+pG75foiwtA5UJ2CrGb1I9sus8FLhzLizzrUKCSyzbkJgnwE61WeypKMYafwZVHtZvv8nHSwgflS8Cz4CtUpEj06N6RbqH88pZ14n6UkI9qSWwWQ2aWrf4J/6UfKS9KUWG9mVQRMOHxRCJ4/NJrib+qW5qby8EgQQEH8r8g77L9NXqoxP8w9PhMJ9tWGIyHNWsKpFJSu7VXwP6kAayoCVaEh0Rz4lwU9sjVGQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ztI108Injf1XAV21Go3AKAH/1s8azeMVIu7K0T9uGCk=;
 b=ELteTaD3LJgav+QzdYjWDDa5+EVyL3FyRLKWOEGaPdtZIi6H5b+swKmL/S/EaQrv+2HWjwTSOpm4OrVTBnqNyM8wRLLpHxtEg0rYHN4MRE6UxemrOozTIYFc+bd8WtYCma+DRwryalYS6qEeGUBBYmd/lYq38cE9A/hZtF74z50WS7hytcEle/eQ9znEyDMGAACr90yCbum9loKbgDOEH+gFT0IHwr/QmF/tb/rMCzyTY8TOBMuQzKcePVO1WsHyfNAthVL/p0ksAbd+jMi92FeVwRZ0RH9Pfe0ZdKTePMzmxWmeeCQTAmyDfYqJjVRem9fhK1CebYgeJDAg6hfTeA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ztI108Injf1XAV21Go3AKAH/1s8azeMVIu7K0T9uGCk=;
 b=LH2WgRmeRhpRFCJFTVGCG7EeTqDQLyd/Tz+F7V/PdcaKUGnjfnoqC6fSdER3MkXSTekWNwpDG9yH0DgbslMewCC13IC8xuMU9BPSxiFqG1XiJddEfjmN36IIPlV8utbY4b1AsGmDNhHOyH84oo9jRtsfo/jJpta5ZXzQOMOp0Ms=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 10/11] xen/arm: if direct-map domain use native UART address and IRQ number for vPL011
Date: Mon, 20 Dec 2021 05:21:22 +0000
Message-ID: <20211220052123.969876-11-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 10d9e2d1-f2f8-4703-3510-08d9c378acee
X-MS-TrafficTypeDiagnostic:
	AM0PR08MB3697:EE_|DB5EUR03FT017:EE_|DB9PR08MB6474:EE_
X-Microsoft-Antispam-PRVS:
	<DB9PR08MB6474A891AAAFAAE48B033130F77B9@DB9PR08MB6474.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 ozBGj7WK7zeVxW2xL1KiKYOgd8sY9qqGmcDn8JVnd0U0gUI4HsJ01c2N+2ykgNj/tKTkv+r+T9iwDByaLD4RoFt/pCzOfXp0HZPp60BGXYrh/8PfpZKPPQ7uurZmRMStYjAMH8yh1ItvnzHkEOLvO6+F97HH0bkr+FNMcfWaZGyA4y2c8kdlC71H4fB+OgtRW8Jd5gCe/UpolnPwmoG4T5IIRWICkFfIILgs8WW3S88jtwAAas+YrZPuLoVX3lDzPnFpnndlcNSNl+fXF7TBO9hSnf2Ca9oXFGABiuORXH5b7oXJUacCHBNx1dSAjfbBCv54keHosNW2HaXimYMLfIckEQ1/8Rau2wfltzUEgz5JU7BUxiEIzGFcV4BdouiYrH8mGerFfRSzwKm0uEwIIsdWXm/G+vGb4lRhCpHmLjHIjkzevrLRO6WyVw99K0Z2QcNlk3u8r7tGoZBe8e/j0CGJYykYYyZpuX+Bgbnp6kKmvhab6AQIKKtoUV3WjIDeS17AtkmAlaDNL1OlEJE15BiowjM+FBrUV99ldn9uEx3p5eF66J61lu7mWQJuHU+2qzD1f9MAIdmPDpYxS0EwBc+UjWUKM1gxy/MVp0KNB1vqDv9nk/zp4vYJIAKlrwHNwAvPvr5ASf4tBcEgUbw7nh2FfGigNAKrnMRfO/dC+89XUXWNDoMfpplyz+Hn/o4kOn30paxiHRPliSW17phfZb0pDUbfRjC6xhAqhie8jdsXOLQGx+Ic8c4iXTM8NKNldG9Q8JtVSfd6idiD55xIoIJQ7JU8ma1HhN+62GEIcFo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(70586007)(2906002)(110136005)(8936002)(47076005)(70206006)(7696005)(316002)(54906003)(36756003)(426003)(44832011)(6666004)(36860700001)(8676002)(26005)(81166007)(356005)(86362001)(82310400004)(336012)(83380400001)(4326008)(1076003)(2616005)(186003)(508600001)(40460700001)(5660300002)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3697
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	7d824209-9343-4e5b-8c14-08d9c378a7c4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Mgur4cy9IrIg9hX2AiKJSwWoOe6Z20n76yKLqAdEix6fTJ+AgqwMUglbxTeZpwhlKSkW2jbq84TJmqhCPG+dpsUumgrfdKfchf73U4hie+CSOfqMa6rLfe/hBSdt2jmWue8gE7QjaiuFGEjEibAsE6PK57oL0SbJF1eanpVOTq+GDKGB7BPcydGUaLkKmvc9KgfoNmLdxNyZWndQpVaE7sfU4O2vcZyM86UjxmZUp538WEVwpPexAObN0skk739maw9Td0boI2jUDzceYhOS/EoIe0GapnSfb5fA3237bk/x3fm+jghZ2VejDSNGkYuUXH+ECO3YsFQVWzS9UXCxeIT319GQ88+34U5OUDvg8f7U9MzxNC87saANZ9oeB0iq1BAFKr4E9yjQzTW72l7TlCk/Tz8feAqbIdjIb1aGW3lXOAo/9zzoKLX6YaAugPYlqx/6Dp4XZUVO6wy/y7VqABOm9HAwa6benHD48IQdLLVJKb9xsDxlS8zPl6ZMEn68TpDpQQMcA5vuIwq6j8yYSxJDLAVct88NUkPSKSK1M9+OxAVh0IfE151h+mpt/tJUMLGkztRDI0QaJ3t7gCZChB972VVV0OgI7q3rluWoZHRXDLdJW++uaqvt1nugcLiUENovFEHWLKcQ6gv8Mrp0qXNdJudQAunw5hRuhmRGl2q1AopZDPaDdk7rPrlyQ01SNW4vvhgijzreW8ImAc/HHQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(54906003)(316002)(5660300002)(4326008)(8936002)(110136005)(70586007)(26005)(70206006)(44832011)(2906002)(36860700001)(7696005)(186003)(6666004)(508600001)(336012)(83380400001)(47076005)(86362001)(8676002)(81166007)(426003)(82310400004)(1076003)(2616005)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:11.4263
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 10d9e2d1-f2f8-4703-3510-08d9c378acee
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT017.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6474

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

We always use a fix address to map the vPL011 to domains. The address
could be a problem for direct-map domains.

So, for domains that are directly mapped, reuse the address of the
physical UART on the platform to avoid potential clashes.

Do the same for the virtual IRQ number: instead of always using
GUEST_VPL011_SPI, try to reuse the physical SPI number if possible.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
v2 changes:
- explain why vpl011 initialization before creating its device tree node
- error out if the domain is direct-mapped and the IRQ is not found
- harden the code and add a check/comment when the hardware UART region
is smaller than GUEST_VPL011_SIZE.
---
v3 changes:
- explain how the '27' was found for 'buf'
- fix checking before dereferencing
- refine comment message
---
v4 changes:
- refine comment message
---
 xen/arch/arm/domain_build.c       | 44 +++++++++++++++++++----
 xen/arch/arm/include/asm/vpl011.h |  2 ++
 xen/arch/arm/vpl011.c             | 60 +++++++++++++++++++++++++++----
 3 files changed, 92 insertions(+), 14 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 9a7145b3ee..a3196a4545 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -30,6 +30,7 @@
 
 #include <xen/irq.h>
 #include <xen/grant_table.h>
+#include <xen/serial.h>
 
 static unsigned int __initdata opt_dom0_max_vcpus;
 integer_param("dom0_max_vcpus", opt_dom0_max_vcpus);
@@ -2415,8 +2416,12 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
     gic_interrupt_t intr;
     __be32 reg[GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS];
     __be32 *cells;
+    struct domain *d = kinfo->d;
+    /* Placeholder for sbsa-uart@ + a 64-bit number + \0 */
+    char buf[27];
 
-    res = fdt_begin_node(fdt, "sbsa-uart@"__stringify(GUEST_PL011_BASE));
+    snprintf(buf, sizeof(buf), "sbsa-uart@%"PRIx64, d->arch.vpl011.base_addr);
+    res = fdt_begin_node(fdt, buf);
     if ( res )
         return res;
 
@@ -2426,14 +2431,14 @@ static int __init make_vpl011_uart_node(struct kernel_info *kinfo)
 
     cells = &reg[0];
     dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
-                       GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
+                       GUEST_ROOT_SIZE_CELLS, d->arch.vpl011.base_addr,
                        GUEST_PL011_SIZE);
 
     res = fdt_property(fdt, "reg", reg, sizeof(reg));
     if ( res )
         return res;
 
-    set_interrupt(intr, GUEST_VPL011_SPI, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
+    set_interrupt(intr, d->arch.vpl011.virq, 0xf, DT_IRQ_TYPE_LEVEL_HIGH);
 
     res = fdt_property(fdt, "interrupts", intr, sizeof (intr));
     if ( res )
@@ -3145,6 +3150,14 @@ static int __init construct_domU(struct domain *d,
     else
         assign_static_memory_11(d, &kinfo, node);
 
+    /*
+     * Base address and irq number are needed when creating vpl011 device
+     * tree node in prepare_dtb_domU, so initialization on related variables
+     * shall be done first.
+     */
+    if ( kinfo.vpl011 )
+        rc = domain_vpl011_init(d, NULL);
+
     rc = prepare_dtb_domU(d, &kinfo);
     if ( rc < 0 )
         return rc;
@@ -3153,9 +3166,6 @@ static int __init construct_domU(struct domain *d,
     if ( rc < 0 )
         return rc;
 
-    if ( kinfo.vpl011 )
-        rc = domain_vpl011_init(d, NULL);
-
     return rc;
 }
 
@@ -3200,15 +3210,35 @@ void __init create_domUs(void)
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
         {
+            unsigned int vpl011_virq = GUEST_VPL011_SPI;
+
             d_cfg.arch.nr_spis = gic_number_lines() - 32;
 
+            /*
+             * The VPL011 virq is GUEST_VPL011_SPI, unless direct-map is
+             * set, in which case it'll match the hardware.
+             *
+             * Since the domain is not yet created, we can't use
+             * d->arch.vpl011.irq. So the logic to find the vIRQ has to
+             * be hardcoded.
+             * The logic here shall be consistent with the one in
+             * domain_vpl011_init().
+             */
+            if ( flags & CDF_directmap )
+            {
+                vpl011_virq = serial_irq(SERHND_DTUART);
+                if ( vpl011_virq < 0 )
+                    panic("Error getting IRQ number for this serial port %d\n",
+                          SERHND_DTUART);
+            }
+
             /*
              * vpl011 uses one emulated SPI. If vpl011 is requested, make
              * sure that we allocate enough SPIs for it.
              */
             if ( dt_property_read_bool(node, "vpl011") )
                 d_cfg.arch.nr_spis = MAX(d_cfg.arch.nr_spis,
-                                         GUEST_VPL011_SPI - 32 + 1);
+                                         vpl011_virq - 32 + 1);
         }
 
         /*
diff --git a/xen/arch/arm/include/asm/vpl011.h b/xen/arch/arm/include/asm/vpl011.h
index e6c7ab7381..c09abcd7a9 100644
--- a/xen/arch/arm/include/asm/vpl011.h
+++ b/xen/arch/arm/include/asm/vpl011.h
@@ -53,6 +53,8 @@ struct vpl011 {
     uint32_t    uarticr;        /* Interrupt clear register */
     uint32_t    uartris;        /* Raw interrupt status register */
     uint32_t    shadow_uartmis; /* shadow masked interrupt register */
+    paddr_t     base_addr;
+    unsigned int virq;
     spinlock_t  lock;
     evtchn_port_t evtchn;
 };
diff --git a/xen/arch/arm/vpl011.c b/xen/arch/arm/vpl011.c
index 895f436cc4..43522d48fd 100644
--- a/xen/arch/arm/vpl011.c
+++ b/xen/arch/arm/vpl011.c
@@ -29,6 +29,7 @@
 #include <xen/mm.h>
 #include <xen/sched.h>
 #include <xen/console.h>
+#include <xen/serial.h>
 #include <public/domctl.h>
 #include <public/io/console.h>
 #include <asm/pl011-uart.h>
@@ -71,11 +72,11 @@ static void vpl011_update_interrupt_status(struct domain *d)
      * status bit has been set since the last time.
      */
     if ( uartmis & ~vpl011->shadow_uartmis )
-        vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, true);
+        vgic_inject_irq(d, NULL, vpl011->virq, true);
 
     vpl011->shadow_uartmis = uartmis;
 #else
-    vgic_inject_irq(d, NULL, GUEST_VPL011_SPI, uartmis);
+    vgic_inject_irq(d, NULL, vpl011->virq, uartmis);
 #endif
 }
 
@@ -347,7 +348,8 @@ static int vpl011_mmio_read(struct vcpu *v,
                             void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -430,7 +432,8 @@ static int vpl011_mmio_write(struct vcpu *v,
                              void *priv)
 {
     struct hsr_dabt dabt = info->dabt;
-    uint32_t vpl011_reg = (uint32_t)(info->gpa - GUEST_PL011_BASE);
+    uint32_t vpl011_reg = (uint32_t)(info->gpa -
+                                     v->domain->arch.vpl011.base_addr);
     struct vpl011 *vpl011 = &v->domain->arch.vpl011;
     struct domain *d = v->domain;
     unsigned long flags;
@@ -626,6 +629,49 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     if ( vpl011->backend.dom.ring_buf )
         return -EINVAL;
 
+    /*
+     * The VPL011 virq is GUEST_VPL011_SPI, except for direct-map domains
+     * where the hardware value shall be used.
+     * The logic here should stay in sync with the one in
+     * create_domUs().
+     */
+    if ( is_domain_direct_mapped(d) )
+    {
+        const struct vuart_info *uart = serial_vuart_info(SERHND_DTUART);
+        int vpl011_irq = serial_irq(SERHND_DTUART);
+
+        if ( (uart != NULL) && (vpl011_irq > 0) )
+        {
+            vpl011->base_addr = uart->base_addr;
+            vpl011->virq = vpl011_irq;
+        }
+        else
+        {
+            printk(XENLOG_ERR
+                   "vpl011: Unable to re-use the Xen UART information.\n");
+            return -EINVAL;
+        }
+
+        /*
+         * Since the PL011 we emulate for the guest requires a 4KB region,
+         * and on some Hardware (e.g. on some sunxi SoC), the UART MMIO
+         * region is less than 4KB, in which case, there may exist multiple
+         * devices within the same 4KB region, here adds the following check to
+         * prevent potential known pitfalls
+         */
+        if ( uart->size < GUEST_PL011_SIZE )
+        {
+            printk(XENLOG_ERR
+                   "vpl011: Can't re-use the Xen UART MMIO region as it is too small.\n");
+            return -EINVAL;
+        }
+    }
+    else
+    {
+        vpl011->base_addr = GUEST_PL011_BASE;
+        vpl011->virq = GUEST_VPL011_SPI;
+    }
+
     /*
      * info is NULL when the backend is in Xen.
      * info is != NULL when the backend is in a domain.
@@ -661,7 +707,7 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
         }
     }
 
-    rc = vgic_reserve_virq(d, GUEST_VPL011_SPI);
+    rc = vgic_reserve_virq(d, vpl011->virq);
     if ( !rc )
     {
         rc = -EINVAL;
@@ -673,12 +719,12 @@ int domain_vpl011_init(struct domain *d, struct vpl011_init_info *info)
     spin_lock_init(&vpl011->lock);
 
     register_mmio_handler(d, &vpl011_mmio_handler,
-                          GUEST_PL011_BASE, GUEST_PL011_SIZE, NULL);
+                          vpl011->base_addr, GUEST_PL011_SIZE, NULL);
 
     return 0;
 
 out2:
-    vgic_free_virq(d, GUEST_VPL011_SPI);
+    vgic_free_virq(d, vpl011->virq);
 
 out1:
     if ( vpl011->backend_in_domain )
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 05:29:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 05:29:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249455.429921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzBES-000669-Gi; Mon, 20 Dec 2021 05:29:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249455.429921; Mon, 20 Dec 2021 05:29:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzBES-000662-Df; Mon, 20 Dec 2021 05:29:08 +0000
Received: by outflank-mailman (input) for mailman id 249455;
 Mon, 20 Dec 2021 05:29:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ajqg=RF=arm.com=Penny.Zheng@srs-se1.protection.inumbo.net>)
 id 1mzB7x-0007eG-0b
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 05:22:25 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0607.outbound.protection.outlook.com
 [2a01:111:f400:fe07::607])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cfca89a9-6154-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 06:22:23 +0100 (CET)
Received: from AM6P194CA0023.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::36)
 by PA4PR08MB7386.eurprd08.prod.outlook.com (2603:10a6:102:2a1::13) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Mon, 20 Dec
 2021 05:22:21 +0000
Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:90:cafe::46) by AM6P194CA0023.outlook.office365.com
 (2603:10a6:209:90::36) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:21 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:20 +0000
Received: ("Tessian outbound a33f292be81b:v110");
 Mon, 20 Dec 2021 05:22:20 +0000
Received: from aed54ac085ac.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 55BB4AAD-2D96-4A28-8183-1BA4183CD9EE.1; 
 Mon, 20 Dec 2021 05:22:14 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aed54ac085ac.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Mon, 20 Dec 2021 05:22:14 +0000
Received: from DB8PR09CA0029.eurprd09.prod.outlook.com (2603:10a6:10:a0::42)
 by AM9PR08MB5892.eurprd08.prod.outlook.com (2603:10a6:20b:2dd::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Mon, 20 Dec
 2021 05:22:04 +0000
Received: from DB5EUR03FT050.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:a0:cafe::f5) by DB8PR09CA0029.outlook.office365.com
 (2603:10a6:10:a0::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:04 +0000
Received: from nebula.arm.com (40.67.248.234) by
 DB5EUR03FT050.mail.protection.outlook.com (10.152.21.128) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.20.4801.14 via Frontend Transport; Mon, 20 Dec 2021 05:22:04 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com
 (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 20 Dec
 2021 05:22:02 +0000
Received: from penny.shanghai.arm.com (10.169.188.91) by mail.arm.com
 (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.20 via Frontend
 Transport; Mon, 20 Dec 2021 05:22:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cfca89a9-6154-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VoG3f1Km9oFGa5vmtcmGleQgdrI0y3/dqorS3WOWRUE=;
 b=spxvrevom+33Si6xWHULujnKJTY7jo/M5yL5FjpBc1Rd8mt/TXCg4qbBL/C3zLBLUxZF/pFL8hp2ZDIdcU4QY5AgzkCsALqizHkjRrfKo+KGbXT4w7L3b9XQRG3vbFWtzlV5InGHfgGVeac4xxayvfgplaXAlcGDpO0FS8AtaeI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6cc640bca0a1ec7a
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RBpaNefUIsRsvFmgA1NnvTbPQd4PT5X6Se46rvMHoQcM/OLzvr67F/SFSb0WqiLcWSMVI+8/i4xDfaQCyl9KniSr0Wf2pW/fNRpMtypN1lWXnlN6LCcJcO00pSZMHZMMKewYsILUFXsEYy5gmcbafm8kP4+rAMt59kWvLBJUV8ILmPhcegNCaUke4JqAgaZZth/yBIkFo6W/p7tf2ai2WGn8aTZIGbSrRU5U0OztpkRqJsY6WaVoQ4OiAQnSjepX2P4G7kMEiHrQ/zYnxrAGX2QvtCPpBINfk7SIsWfoy6QPbF/35UDhIGZ2TSWx/VVz+vMcoZnEFEAGLiGsISMmgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=VoG3f1Km9oFGa5vmtcmGleQgdrI0y3/dqorS3WOWRUE=;
 b=M/05YB5nBkas9llZQWocVRfgphJp14Nl8kEiYEq7V2D7n+lDy7rA66scATB3IZOrZXzlOHHESFjdtgF0Ve01MkknfsQhf0j0d3qLr2qOpfKS9RD2f+B9LTU8AVAorVFpLwRZlwhGetbMhi26B9hQgXlqs/7QBQIvacti9tqKwBsyLfHtJAHEFVpTLo7TYLT6cXFI1odxjY45AmuTaVrDK84S3hB3J/Ajv6Xom/I+cK3Tm6DrA4HCdRgUNPXUmLSJ9PdtNkY2RA++gwdM93wS+eKI0ofZ3tPyqYrxXsMETjegjBTmDUfzo4o+uAc1W+/xVbPG2XoBAysaCj4AVrqhcA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com;
 dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com;
 dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=VoG3f1Km9oFGa5vmtcmGleQgdrI0y3/dqorS3WOWRUE=;
 b=spxvrevom+33Si6xWHULujnKJTY7jo/M5yL5FjpBc1Rd8mt/TXCg4qbBL/C3zLBLUxZF/pFL8hp2ZDIdcU4QY5AgzkCsALqizHkjRrfKo+KGbXT4w7L3b9XQRG3vbFWtzlV5InGHfgGVeac4xxayvfgplaXAlcGDpO0FS8AtaeI=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234)
 smtp.mailfrom=arm.com; dkim=none (message not signed)
 header.d=none;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 40.67.248.234 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.67.248.234; helo=nebula.arm.com;
From: Penny Zheng <penny.zheng@arm.com>
To: <xen-devel@lists.xenproject.org>, <sstabellini@kernel.org>,
	<julien@xen.org>
CC: <Bertrand.Marquis@arm.com>, <Wei.Chen@arm.com>
Subject: [PATCH v4 11/11] xen/docs: Document how to do passthrough without IOMMU
Date: Mon, 20 Dec 2021 05:21:23 +0000
Message-ID: <20211220052123.969876-12-penny.zheng@arm.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211220052123.969876-1-penny.zheng@arm.com>
References: <20211220052123.969876-1-penny.zheng@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 1
X-MS-Office365-Filtering-Correlation-Id: 3538d98f-5961-45e6-02d8-08d9c378b2a9
X-MS-TrafficTypeDiagnostic:
	AM9PR08MB5892:EE_|AM5EUR03FT004:EE_|PA4PR08MB7386:EE_
X-Microsoft-Antispam-PRVS:
	<PA4PR08MB7386752082F26FD605D93FB3F77B9@PA4PR08MB7386.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1751;OLM:1751;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Xh8+scXtx6hjAb9d3K95WinV5/qfWhUWBtb7FK8U5NR8FV/8WEesRWcbCwUDw50wOIdi6PA+0t1vjux/ty2sS2TGPAtaI7W7qqlLk3/ZZ4NS21hq6tAturoXY4YfaG3fGj7OO4XgUcBKl2BvMViY18nw+nhKE5p+vvaRO5bheGOtZuU8J9udRSGaBOrchU1UThngfxve4JPDYAqC43in/g9KuU796PW7v5kVdMXKQlEdhlWcZPUrzT8qcKjJdMQIDDbdZTk4vKsg5zMc7zB4fGY/mub3I646swz5YxJAabn+Uz1Ajq7VuwYkpKimmK4LHxMxQSCVIhOHg431optACxeKDi/lvfwt+jrFeiTASg3yZjSlfm6uARuvMGEjcNKT0K9TL94fx0YFhLoqPRyXavZWsG8ElukluDE7f5BJ0mdi6eDaLkyoyuHAT86qbcfSyvQEbi4si3kCinLk4UN4Ks90xgVwk40dIMQ4z2KgbJl9tuDYzDD8ymYG+oh3iMoua4TvYOFKbZlYh4tiztrKbQH+TBNSFoDEXnjwPeSSu8QRAnKCtT7KrD9Pv3AAPlKyObkVm7SfLY2HLmjw+jmVbLbAtQmydHDjYLxvp0zHJf1YVzErjsa6gdTWXAU1DttezUvleEeXhPt3TeLEmfEdDhNJgfsbOXqhMUx+p3a+zo29Q5w78xNaOdo85HMQxSJC/Y3Jl9sM/pYEERS6IStEzZ4IfsmSjwjlLFPjMFp/LfqiuitGTfYHi+o0OwN+kj/ySPy0ZRH+F2IlbSita4FvvyC6I5oiQlaWE1PS6/6msUI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(40470700001)(356005)(54906003)(81166007)(110136005)(70206006)(70586007)(36756003)(26005)(7696005)(316002)(2906002)(86362001)(1076003)(426003)(336012)(2616005)(4326008)(83380400001)(44832011)(186003)(36860700001)(508600001)(82310400004)(5660300002)(6666004)(47076005)(8936002)(8676002)(40460700001)(36900700001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5892
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	005b0956-b353-430d-b627-08d9c378a8bf
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	yTd5q/rpzXZNQFov5rUPKaT9VR3OW54+y3IRMtbm6m1LlRgX2r9w1MgIUQNLUBcs/VGnCp6fwA/tn+EgjhSDYPsGMXk7/bXQkIXnApEJc/8uy5iQQYobWgqkKfL5fMHZNla5oyKUArkR3qPeNN3i2vQ2KGDyHOKoPZLMjmVYtwmPdiLKPqe0Sgf3Y7/94PHTfEb828oZrkJHTpcxEAj7lmGyFgH8MGlm08QvmCP++muONf7m68H1V0MfJdqslhFCPmcDeOclA8nJBZ4PjarhD2D+HSY17ifDm+QVvtfTkv0BS1t0bTTI6W219mJva9c2HhPXVr9kjJjPB7jTPsXZhaSOkqy6xYKxql5qp0eKQ1pyy2TZ958VdUrS+rnLm7Rjj4ml/qRv1Frs7fePXGWF1J615Ur732HkbFzP8SWGfgrXi/WKL7qgQyfUa6B2R+42zktovJcdvu0wxQrBS5Wbz4I0r+WXuDh2L3KPwjw8OWhbpyDTSIaXOlDSW3EZzWXQVJzjNMceeZ2lV88bWFCiMMM8ymu51iCyzfm2xLhfMpbLrO69rVL0Rk9u6sJDPJ1kV3LeKyx48q1YgXh8W8Ttn3eQzgJsE3QVLixA2+KZOzePEvtpoR+Yb7s9ujGIgM4rUZbPpm1bGV1O+Fa60STm8VEduE4k2iD5VEfDI/zGCHOtRL+++Xa8B9wj5Ys+w5BJPKMiHfeau9yjNvyquTVjxg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(336012)(110136005)(316002)(54906003)(8936002)(26005)(83380400001)(36860700001)(7696005)(186003)(8676002)(36756003)(70206006)(70586007)(44832011)(426003)(1076003)(2616005)(86362001)(82310400004)(508600001)(81166007)(4326008)(47076005)(6666004)(5660300002)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 05:22:20.9923
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3538d98f-5961-45e6-02d8-08d9c378b2a9
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7386

From: Stefano Stabellini <stefano.stabellini@xilinx.com>

This commit creates a new doc to document how to do passthrough without IOMMU.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Signed-off-by: Penny Zheng <penny.zheng@arm.com>
---
 docs/misc/arm/passthrough-noiommu.txt | 52 +++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 docs/misc/arm/passthrough-noiommu.txt

diff --git a/docs/misc/arm/passthrough-noiommu.txt b/docs/misc/arm/passthrough-noiommu.txt
new file mode 100644
index 0000000000..3e2ef21ad7
--- /dev/null
+++ b/docs/misc/arm/passthrough-noiommu.txt
@@ -0,0 +1,52 @@
+Request Device Assignment without IOMMU support
+===============================================
+
+*WARNING:
+Users should be aware that it is not always secure to assign a device without
+IOMMU protection.
+When the device is not protected by the IOMMU, the administrator should make
+sure that:
+ 1. The device is assigned to a trusted guest.
+ 2. Users have additional security mechanism on the platform.
+
+This document assumes that the IOMMU is absent from the system or it is
+disabled (status = "disabled" in device tree).
+
+Add xen,force-assign-without-iommu; to the device tree snippet:
+
+ethernet: ethernet@ff0e0000 {
+	compatible = "cdns,zynqmp-gem";
+	xen,path = "/amba/ethernet@ff0e0000";
+	xen,reg = <0x0 0xff0e0000 0x1000 0x0 0xff0e0000>;
+	xen,force-assign-without-iommu;
+};
+
+Request 1:1 memory mapping for the domain on static allocation
+==============================================================
+
+Add a direct-map property under the appropriate /chosen/domU node which
+is also statically allocated with physical memory ranges through
+xen,static-mem property as its guest RAM.
+
+Below is an example on how to specify the 1:1 memory mapping for the domain
+on static allocation in the device-tree:
+
+/ {
+	chosen {
+		domU1 {
+			compatible = "xen,domain";
+			#address-cells = <0x2>;
+			#size-cells = <0x2>;
+			cpus = <2>;
+			memory = <0x0 0x80000>;
+			#xen,static-mem-address-cells = <0x1>;
+			#xen,static-mem-size-cells = <0x1>;
+			xen,static-mem = <0x30000000 0x20000000>;
+			direct-map;
+			...
+		};
+	};
+};
+
+Besides reserving a 512MB region starting at the host physical address
+0x30000000 to DomU1, it also requests 1:1 memory mapping.
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 10:16:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 10:16:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249536.429950 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzFi6-0003KR-1U; Mon, 20 Dec 2021 10:16:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249536.429950; Mon, 20 Dec 2021 10:16:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzFi5-0003KK-U1; Mon, 20 Dec 2021 10:16:01 +0000
Received: by outflank-mailman (input) for mailman id 249536;
 Mon, 20 Dec 2021 10:15:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzFi3-0003KA-TK; Mon, 20 Dec 2021 10:15:59 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzFi3-00026V-Qn; Mon, 20 Dec 2021 10:15:59 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzFi3-0005ib-GM; Mon, 20 Dec 2021 10:15:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzFi3-0008Se-Fq; Mon, 20 Dec 2021 10:15:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MbxaxkWVSBdFU2QF1DbeuULApURTDjmtZYkNuWY86tc=; b=bUOYHTJX1UUq09kCoJc1v3fDKY
	JY4LvljdGtBDHOwy/FL9VVrNjvkeFJyD2rxXBYDtJwDB+kHEmyfI53JmkIegp28IGkfNiSylmNUJn
	rtefIeofD3c/0Ym8pwqKhJAJ0RE8GnIs235ZQlMjT8BXkM+l9/+L5Pgca8Os4mwYntNQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167488-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167488: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=adc0eaead0ebe11f38798e431d2748bfe9b54a30
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 10:15:59 +0000

flight 167488 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167488/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              adc0eaead0ebe11f38798e431d2748bfe9b54a30
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  528 days
Failing since        151818  2020-07-11 04:18:52 Z  527 days  509 attempts
Testing same since   167488  2021-12-20 04:19:01 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90082 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 10:35:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 10:35:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249546.429961 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzG0u-0005sK-PC; Mon, 20 Dec 2021 10:35:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249546.429961; Mon, 20 Dec 2021 10:35:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzG0u-0005sD-Lt; Mon, 20 Dec 2021 10:35:28 +0000
Received: by outflank-mailman (input) for mailman id 249546;
 Mon, 20 Dec 2021 10:35:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzG0t-0005s3-BH; Mon, 20 Dec 2021 10:35:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzG0t-0002Pk-9Q; Mon, 20 Dec 2021 10:35:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzG0s-0006I7-TM; Mon, 20 Dec 2021 10:35:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzG0s-0001Oa-Sr; Mon, 20 Dec 2021 10:35:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kIjYD02txWq2NB3a/j0dEfURBSq619q3LKPp8K+rIvM=; b=hCeeiCEtLlfx8cGEAMXHNsmVbv
	6neFqEcCBSJefwzVQkywYdYv06RFcD95EviE3QDB5F2Db0eYqP1buV0JdA+ypMAa8JoDgrKz4cL6R
	MtMbw4AK1NT40bid7ZxAa8T6tQe4PTnAxwL/fa4JR3aBt4PSxIDo+8zQyDx6NnrzXhFg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167487-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167487: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=de9e5b7dc721d4ca319c0455cf83577347e0abef
X-Osstest-Versions-That:
    ovmf=ee1f8262b83dd88b30091e6e81221ff299796099
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 10:35:26 +0000

flight 167487 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167487/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 de9e5b7dc721d4ca319c0455cf83577347e0abef
baseline version:
 ovmf                 ee1f8262b83dd88b30091e6e81221ff299796099

Last test of basis   167465  2021-12-17 17:41:43 Z    2 days
Testing same since   167487  2021-12-20 04:11:39 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ashraf Ali S <ashraf.ali.s@intel.com>
  S, Ashraf Ali <ashraf.ali.s@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   ee1f8262b8..de9e5b7dc7  de9e5b7dc721d4ca319c0455cf83577347e0abef -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 11:02:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 11:02:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249556.429972 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGR0-0000zH-Uc; Mon, 20 Dec 2021 11:02:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249556.429972; Mon, 20 Dec 2021 11:02:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGR0-0000zA-Qm; Mon, 20 Dec 2021 11:02:26 +0000
Received: by outflank-mailman (input) for mailman id 249556;
 Mon, 20 Dec 2021 11:02:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzGR0-0000z0-3w; Mon, 20 Dec 2021 11:02:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzGR0-0002sc-0e; Mon, 20 Dec 2021 11:02:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzGQz-0007SW-M2; Mon, 20 Dec 2021 11:02:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzGQz-0001n1-La; Mon, 20 Dec 2021 11:02:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MsPaF/tTl7hlvd/Yv8KURk4oa2dDr4ze7onuRD2sDCk=; b=NWM4DoH7nY8Aw3v2GJnPNL2YpI
	/P42vYZ0FvVDorcmuS6FBODpO3iWhQ1G1r1HYZVp1GaIMU8n/FkgQyf7AeoJEGzRmObfVS7ZkzUpz
	X+D4BOcOB1AWaNGOv89pkyZrmZErG+uG2iIgzD2zbiSyBGWLlLEXm/SXyMMCOSSyaYYo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167485-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167485: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 11:02:25 +0000

flight 167485 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167485/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167480
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167480

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167480
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167480
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167480
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167480
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167480
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167480
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167480
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167480
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167480
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167480
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167480
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167480
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167485  2021-12-20 01:53:01 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 11:27:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 11:27:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249572.429983 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGpG-0003fm-2u; Mon, 20 Dec 2021 11:27:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249572.429983; Mon, 20 Dec 2021 11:27:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGpF-0003ff-Vh; Mon, 20 Dec 2021 11:27:29 +0000
Received: by outflank-mailman (input) for mailman id 249572;
 Mon, 20 Dec 2021 11:27:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hnIC=RF=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzGpD-0003fZ-RD
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 11:27:28 +0000
Received: from sender4-of-o55.zoho.com (sender4-of-o55.zoho.com
 [136.143.188.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cd788c62-6187-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 12:27:25 +0100 (CET)
Received: from [10.10.1.134] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1639999637782645.8866626246403;
 Mon, 20 Dec 2021 03:27:17 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cd788c62-6187-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1639999640; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=XF2uHJqOzyJHyCdY7fyNmThjBXIiRpXIh96P0WVGw5L67Oe3XTXgo/AIwP1J7HU1odW62PnOlyEnaV2jzrO/XXyc7n62IbMkX7NmbRkQ5szhYjoRYneUEIHMp+c4No3qS3u0epA1dpn+ak7fGRhsZki9LyrHqqBV8t0TDmwfWgM=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1639999640; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=Hv+H1s+UslAGqxdcjNXqFCh6/8E+pjLOZ/BlnDB3hxs=; 
	b=mtsmzKsN9NvsnWBwGARNY0hXUemNlDykV9Z4O4oayE7OUH9aR3uYaRJGKHKHPB/Osp2d1sS4BYtogGbjXvwr53Z8INX+uO/c4HJkMNx1QZ0H2a+DB+oqBSpP0tbpgpTBEQtiaK5UyafIydQwOU5gIGK0EPSkUx7BwAA23eT4+XE=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1639999640;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=Hv+H1s+UslAGqxdcjNXqFCh6/8E+pjLOZ/BlnDB3hxs=;
	b=gip956wRS2yKELRaSyF0gQ1lXTHvF+/n1bOonTlay0Rn7bDIySfa9GFJ3+jkJ/a5
	T42PpJP40aSe3qqnua+GTgGg3V7P6eX8FMbxbhO2zYjcfUUejBejtHjdtZCI1l09ck0
	uBWJ1JBPrhfpzQOrUxgHfZAqLG7uAQsl95sruVK0=
Subject: Re: [RFC 02/10] is_system_domain: replace open-coded instances
To: Andrew Cooper <amc96@srcf.net>, Wei Liu <wl@xen.org>,
 xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
 Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Dario Faggioli <dfaggioli@suse.com>
References: <20211217233437.13791-1-dpsmith@apertussolutions.com>
 <20211217233437.13791-3-dpsmith@apertussolutions.com>
 <4382c02a-4207-729b-67b8-c9a8bf65b921@srcf.net>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <a3daa13e-cf30-e83d-2b14-427ee060ced8@apertussolutions.com>
Date: Mon, 20 Dec 2021 06:26:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <4382c02a-4207-729b-67b8-c9a8bf65b921@srcf.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

On 12/17/21 2:50 PM, Andrew Cooper wrote:
> On 17/12/2021 23:34, Daniel P. Smith wrote:
>> From: Christopher Clark <christopher.w.clark@gmail.com>
>>
>> There were several instances of open-coded domid range checking. This commit
>> replaces those with the is_system_domain inline function.
>>
>> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> 
> Ah - probably my fault.  When I added is_system_domain(), I didn't think
> to scan for other opencodes - I was guts deep in the domain creation logic.
> 
> In addition to the ones you've got here...
> 
> xen/arch/x86/cpu/mcheck/mce.c:1521
> xen/common/domain.c:586
> common/domctl.c:55, 411 and 421
> 
> according to `git grep DOMID_FIRST_RESERVED`

confirmed and replaced

>> diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
>> index 8ec4547bed..179f3dcc5a 100644
>> --- a/xen/arch/x86/cpu/vpmu.c
>> +++ b/xen/arch/x86/cpu/vpmu.c
>> @@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
>>        * in XENPMU_MODE_ALL, for everyone.
>>        */
>>       if ( (vpmu_mode & XENPMU_MODE_ALL) ||
>> -         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
>> +         (is_system_domain(sampled->domain)) )
> 
> Can drop one set of brackets now.

ack

>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index 28146ee404..1df09bcb77 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -613,6 +613,11 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
>>   #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
>>   #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
>>   
>> +static inline bool is_system_domain_id(domid_t id)
>> +{
>> +    return (id >= DOMID_FIRST_RESERVED);
>> +}
>> +
>>   static inline bool is_system_domain(const struct domain *d)
>>   {
>>       return d->domain_id >= DOMID_FIRST_RESERVED;
> 
> is_system_domain() wants implementing in terms of is_system_domain_id().

ack

> That said, could I talk you into is_system_domid() as a better name?

ack

> This is all sufficiently trivial that I'm tempted to fix on commit if
> you'd like.  This patch is cleanup that stands on its own merit, and
> isn't tied to hyperlaunch specifically.

I will send the revised version later today as a standalone patch.

v/r,
dps


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 11:30:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 11:30:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249577.429994 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGru-00057M-HG; Mon, 20 Dec 2021 11:30:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249577.429994; Mon, 20 Dec 2021 11:30:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzGru-00057F-Cb; Mon, 20 Dec 2021 11:30:14 +0000
Received: by outflank-mailman (input) for mailman id 249577;
 Mon, 20 Dec 2021 11:30:12 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=z3/4=RF=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzGrs-000577-KQ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 11:30:12 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2fd77a34-6188-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 12:30:10 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2fd77a34-6188-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1639999810;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=/D88mqBITTXMf/VBV8UnfOMshYaRwDqkACSK4Uj/CSE=;
  b=UqtCuH9SEDQy8ffZxSSgNq1OXFSUk6hQ370+z3RIz+eT7uk5mtM9aQeS
   IJZDVWvvxzoj+fJn0MFOnFmIBRqTcpMbOnlkyvLnaqA6OTrGUuMNmds3M
   1td06xzSikZuI7E/a+3Tg4VFtnunt4lLlbbVeoqKv+MWRgD/p1E7ePtfK
   4=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 3QrXlcC0EBd1phBKZ1jkitkQhhyZngPjit6JiCph5yVSqWel5MQOa7BGWrjdg3t8BCCb0N2a1B
 dNX9v2FFCB8T+XppA2stuX5MNL7MDcJCaRvCbkluRvU5jnEBBP+qcpLyCjYqp7+TRksBKPC2YL
 z4X3WkwzCoWu0KlYkxsaCpAdlKv5gstZVKydJnu/rMcdudOSVemwWyJhsqfOWM+j4yFo0qRh7d
 L8TzhwW2VuP9eeH45qhhVGFh9zQ8pwiWPOdLzICnveJceDyDgXy4uM0Zp34IjlqrZ/Kdapg0pm
 iBqChNrHKKaJgwNgzbyG5adm
X-SBRS: 5.1
X-MesageID: 60418457
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:IUXO16zN5cw5YPh9+6R6t+f3wCrEfRIJ4+MujC+fZmUNrF6WrkUGz
 2dOXTrXP6yINzCmKop3YYq28h4GuMPTn98ySApo+SAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbRh2tcAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt+t4z
 99StJKzcgEoDPWWiudDbQZZMT4raMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JgSRKaCO
 pVxhTxHTDL4cSxzB1ArUp89wc2agWL5XRxZpwfAzUYwyzeKl1EguFT3C/LefdqMQsdZl1iZv
 UrJ+m34BlcRM9n34TOB82mwj+7V2y3hUYQZFaaQ6fJhxlaUwwQ7AhAMSUGyp/X/j0ekQs9eM
 GQd4C9opq83nGSoSd/nVhH+v3+AvTYbQdNbF+B84waIooLE7gDcCmUaQzppbN09qNRwVTEsz
 kWOnd7iGXpoqrL9YX6F7bKVsTOaMDAYN3MffjQDSRYZ4t7lu8c4iRenZtpsHKO6lNTdBSD7w
 zfMqjM3wboUk6Yj1rq51UDKhSq2oZrERRJz4R/YNkqv6QlzdYO+Z4il7FHdxflFJYedCFKGu
 RAsmcKT8eQPBpGljzGWTaMGG7TBz/SYNDzRh3Z/Ep9n8C6ik1adeoRX7CB7NV1eGM8Ocj/0Y
 2feoQpUopRUOROCcqtfc4+3TcMwwsDIDs/5X/rZat5PZJlZdwKd+ixqI0mK0AjQfFMEyP9lf
 83BKID1UChcWf8PICeKq/k16rYszD8/y2DoQ5HJl0610uSge3+3VuJQWLeRVdwR4KSBqQTT1
 t9QMcqW1hlSONHDjjnrHZ07dg5TcyVibXzig4kOL7PYfFI6cI00I6aJmetJRmBzo0hCeg4kF
 FmZU1QQ9lfwjGavxe6iOiE6M+OHsXqSQBsG0c0Q0bSAhiFLjWWHtv53m34LkV4PrrML8BKMZ
 6NZE/hs+9wWItg9xxwTbIPmsKtpfwmxiASFMkKNOWZkLs87FlCXpIW1IWMDERXi6QLt6qMDT
 0CIjFuHEfLvuSw/ZCopVB5f5wzo5iVM8A6Dd0DJPsNSaC3RHHtCcETMYgsMC5hUc33rn2LCv
 y7PWEtwjbSd8ucdrYiS7YjZ/tjBLgeLNhcDd4Utxe3tbneyE6vK6dIobdtkihiBDj6po/v7O
 r0Opxw+WdVe9Gt3X0NHO+4D5coDCxHH/de2FyxoQyfGaUqFELRlLiXU1MVDrPQVlLRYpRG3S
 gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRkANRe7lyEAfqB+N5kow
 Ll9tZdOuRC/kBcjLv2PkjtQqzaXNnUFXqh+7sMaDYbnhxAF0FZHZZCAWCb67IvWM4dHM1UwI
 y/Sj63H3uwOyk3Hens1NH7MwesC2she5EEUlAcPfg3blMDEi/k72Axq3Q42FgkFnA9a1+9TO
 3RwMxEnL6u54Do11tNIWHqhGl8dCUTBqFDx0VYAiEbQU1KsCj7WNGQ4NOuAoBIZ/mZbcmQJ9
 b2U0j+4AzPjfcW31SouQ0917ffkSIUppAHFncmmGeWDHoU7PmW50vP/OzJQpku1G941iW3Gu
 fJurbR5ZqDMPCINp7E2VtuB3rMKRRHYfGFPTJmNJk/S8b0wrN1q5QWzFg==
IronPort-HdrOrdr: A9a23:mOS0aaqObfW3FQoypBFVsOUaV5oWeYIsimQD101hICG9JPbo8f
 xG/c5rtyMd6l4qMk3I9ursBEDtex/hHP1OkOos1NWZPTUO41HYS72KhLGKq1bd8kvFmdK1vp
 0BT0ERMrPN5fcRt7eC3OEVeexQpeVuUcqT9IPj80s=
X-IronPort-AV: E=Sophos;i="5.88,220,1635220800"; 
   d="scan'208";a="60418457"
Date: Mon, 20 Dec 2021 11:29:49 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Alistair Francis <alistair.francis@wdc.com>, Connor Davis
	<connojdavis@gmail.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
Message-ID: <YcBpLbxObugQ3doZ@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
 <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com>
 <YbseOtj7prFqViyV@perard>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YbseOtj7prFqViyV@perard>

On Thu, Dec 16, 2021 at 11:08:47AM +0000, Anthony PERARD wrote:
> On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
> > On 25.11.2021 14:39, Anthony PERARD wrote:
> > > --- a/xen/Makefile
> > > +++ b/xen/Makefile
> > > @@ -22,6 +22,15 @@ export CHECKPOLICY	?= checkpolicy
> > >  export BASEDIR := $(CURDIR)
> > >  export XEN_ROOT := $(BASEDIR)/..
> > >  
> > > +abs_objtree := $(CURDIR)
> > > +abs_srctree := $(CURDIR)
> > 
> > Nit: In line with e.g. obj-y I think these would better be abs-srctree and
> > abs-objtree.
> 
> I guess that would be fine, we don't need to keep the same spelling that
> Kbuild does.

Actually, those two variables are exported, as it appear in the next two
lines. Exporting a variable with a dash doesn't work very well as shells
may not be able to use them. When make find a variable with a dash in
it in the environment, it unexport them.

So, for those two variable, we need to avoid using a dash, so I think
keeping the current name is better. (And now, I've find out that there's
an issue in the build system, I'll prepare a patch.)

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 11:48:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 11:48:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249582.430004 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzH9H-0006pv-0w; Mon, 20 Dec 2021 11:48:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249582.430004; Mon, 20 Dec 2021 11:48:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzH9G-0006po-UG; Mon, 20 Dec 2021 11:48:10 +0000
Received: by outflank-mailman (input) for mailman id 249582;
 Mon, 20 Dec 2021 11:48:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hnIC=RF=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzH9G-0006pi-3H
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 11:48:10 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b208fefa-618a-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 12:48:07 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1640000861742943.2120228389215;
 Mon, 20 Dec 2021 03:47:41 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b208fefa-618a-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; t=1640000885; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=VF3CXsJj54wbz6wP+KNz4JHAZKcptCyEV8xfNWQx6YF962I5rerxpS2gZ3s3lQo4fB2rxvX/Ca8oOBy2bnK5Oy5hv1YibFcX4VXjqczstJahlMYt2Hzkv5RDkVh2itVtlxx5wPhhcqTPNR65ifitvQ7sYXPx6/PsAhErSHPUtV8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1640000885; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=0s4Vuqs7ufyKC/tb7lLUJ5CNxSzJesKBdHhoKh0EG+M=; 
	b=OHttxzaARGkIPM6solDNMq05QrdMJ+9R67r4l5C3OK0SnOMytJvMPOUsyFTZ/3+RSKJypbmYIGh+oG1AWKSnlpoa7sUoYel0fYwQRwaPsM0n74pZAuW3N/fx2UWHwgViF8IBwsT2N7PA2+B+yOy/miDf1aHAO7xhhZthS9l44Rg=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640000885;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding;
	bh=0s4Vuqs7ufyKC/tb7lLUJ5CNxSzJesKBdHhoKh0EG+M=;
	b=MXB7F3T7pPjCNBQcbPmtE33pzItAH26nIDESMlw4cks5Gh8t6D2EDI3eGAmcNIuG
	VYwIjZ8UqFtTw0xA6OyIx/jkAGgfYyNH5A00NFc++Wfi3+PWJaZrQeN8s8fvMsHImtj
	5qiVZK/zUFT4Q+b3/bP8AxtqDOx7lcXw1r8lSkJw=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH V2] is_system_domain: replace open-coded instances
Date: Mon, 20 Dec 2021 10:50:13 -0500
Message-Id: <20211220155013.28896-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

From: Christopher Clark <christopher.w.clark@gmail.com>

This is a split out of the hyperlaunch dom0 series.

There were several instances of open-coded domid range checking. This commit
replaces those with the is_system_domain or is_system_domid inline function.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
---
 xen/arch/x86/cpu/mcheck/mce.c     |   2 +-
 xen/arch/x86/cpu/vpmu.c           |   2 +-
 xen/common/domain.c               |   2 +-
 xen/common/domctl.c               |   4 +-
 xen/common/sched/core.c           |   4 +-
 xen/include/asm-x86/asm-macros.h  |  86 ++++++++++++++++++++
 xen/include/asm-x86/asm-offsets.h | 127 ++++++++++++++++++++++++++++++
 xen/include/xen/sched.h           |   7 +-
 8 files changed, 226 insertions(+), 8 deletions(-)
 create mode 100644 xen/include/asm-x86/asm-macros.h
 create mode 100644 xen/include/asm-x86/asm-offsets.h

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 7f433343bc..5c1df39075 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1518,7 +1518,7 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
             d = rcu_lock_domain_by_any_id(mc_msrinject->mcinj_domid);
             if ( d == NULL )
             {
-                if ( mc_msrinject->mcinj_domid >= DOMID_FIRST_RESERVED )
+                if ( is_system_domid(mc_msrinject->mcinj_domid) )
                     return x86_mcerr("do_mca inject: incompatible flag "
                                      "MC_MSRINJ_F_GPADDR with domain %d",
                                      -EINVAL, domid);
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bed..c6bfa5a00e 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
      * in XENPMU_MODE_ALL, for everyone.
      */
     if ( (vpmu_mode & XENPMU_MODE_ALL) ||
-         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
+         is_system_domain(sampled->domain) )
     {
         sampling = choose_hwdom_vcpu();
         if ( !sampling )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 093bb4403f..347cc073aa 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -583,7 +583,7 @@ struct domain *domain_create(domid_t domid,
     /* Sort out our idea of is_hardware_domain(). */
     if ( domid == 0 || domid == hardware_domid )
     {
-        if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED )
+        if ( hardware_domid < 0 || is_system_domid(hardware_domid) )
             panic("The value of hardware_dom must be a valid domain ID\n");
 
         old_hwdom = hardware_domain;
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 879a2adcbe..a3ad1f62b6 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -52,7 +52,7 @@ static inline int is_free_domid(domid_t dom)
 {
     struct domain *d;
 
-    if ( dom >= DOMID_FIRST_RESERVED )
+    if ( is_system_domid(dom) )
         return 0;
 
     if ( (d = rcu_lock_domain_by_id(dom)) == NULL )
@@ -536,7 +536,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( !d )
         {
             ret = -EINVAL;
-            if ( op->domain >= DOMID_FIRST_RESERVED )
+            if ( is_system_domid(op->domain) )
                 break;
 
             rcu_read_lock(&domlist_read_lock);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..6ea8bcf62f 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -821,7 +821,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
     int ret;
 
     ASSERT(d->cpupool == NULL);
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( (ret = cpupool_add_domain(d, poolid)) )
         return ret;
@@ -845,7 +845,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
 
 void sched_destroy_domain(struct domain *d)
 {
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( d->cpupool )
     {
diff --git a/xen/include/asm-x86/asm-macros.h b/xen/include/asm-x86/asm-macros.h
new file mode 100644
index 0000000000..0c3d538b5c
--- /dev/null
+++ b/xen/include/asm-x86/asm-macros.h
@@ -0,0 +1,86 @@
+#if 0
+.if 0
+#endif
+#ifndef __ASM_MACROS_H__
+#define __ASM_MACROS_H__
+asm ( ".include \"/home/build/projects/starlab/xen-private/xen/include/asm-x86/asm-macros.h\"" );
+#endif /* __ASM_MACROS_H__ */
+#if 0
+.endif
+.macro vmrun
+    .byte 0x0f, 0x01, 0xd8
+.endm
+.macro stgi
+    .byte 0x0f, 0x01, 0xdc
+.endm
+.macro clgi
+    .byte 0x0f, 0x01, 0xdd
+.endm
+.macro INDIRECT_BRANCH insn:req arg:req
+    .if 1 == 1
+        $done = 0
+        .irp reg, ax, cx, dx, bx, bp, si, di, 8, 9, 10, 11, 12, 13, 14, 15
+        .ifeqs "\arg", "%r\reg"
+            \insn __x86_indirect_thunk_r\reg
+            $done = 1
+           .exitm
+        .endif
+        .endr
+        .if $done != 1
+            .error "Bad register arg \arg"
+        .endif
+    .else
+        \insn *\arg
+    .endif
+.endm
+.macro INDIRECT_CALL arg:req
+    INDIRECT_BRANCH call \arg
+.endm
+.macro INDIRECT_JMP arg:req
+    INDIRECT_BRANCH jmp \arg
+.endm
+.macro guest_access_mask_ptr ptr:req, scratch1:req, scratch2:req
+    mov $((((((256 >> 8) * 0xffff000000000000) | (256 << 39))) + (1 << 39)*16) - 1), \scratch1
+    mov $~0, \scratch2
+    cmp \ptr, \scratch1
+    rcr $1, \scratch2
+    and \scratch2, \ptr
+.endm
+.macro altinstruction_entry orig repl feature orig_len repl_len pad_len
+    .long \orig - .
+    .long \repl - .
+    .word \feature
+    .byte \orig_len
+    .byte \repl_len
+    .byte \pad_len
+    .byte 0
+.endm
+.macro mknops nr_bytes
+    .nops \nr_bytes, 9
+.endm
+.macro ALTERNATIVE oldinstr, newinstr, feature
+    .L\@_orig_s: \oldinstr; .L\@_orig_e: .L\@_diff = (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_e - .L\@_orig_s); mknops ((-(.L\@_diff > 0)) * .L\@_diff); .L\@_orig_p:
+    .pushsection .altinstructions, "a", @progbits
+    altinstruction_entry .L\@_orig_s, .L\@_repl_s1, \feature, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()1 - .L\@_repl_s\()1), (.L\@_orig_p - .L\@_orig_e)
+    .section .discard, "a", @progbits
+    .byte (.L\@_orig_p - .L\@_orig_s)
+    .byte 0xff + (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_p - .L\@_orig_s)
+    .section .altinstr_replacement, "ax", @progbits
+    .L\@_repl_s\()1: \newinstr; .L\@_repl_e\()1:
+    .popsection
+.endm
+.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2
+    .L\@_orig_s: \oldinstr; .L\@_orig_e: .L\@_diff = (((.L\@_repl_e\()1 - .L\@_repl_s\()1)) ^ ((((.L\@_repl_e\()1 - .L\@_repl_s\()1)) ^ ((.L\@_repl_e\()2 - .L\@_repl_s\()2))) & -(-(((.L\@_repl_e\()1 - .L\@_repl_s\()1)) < ((.L\@_repl_e\()2 - .L\@_repl_s\()2)))))) - (.L\@_orig_e - .L\@_orig_s); mknops ((-(.L\@_diff > 0)) * .L\@_diff); .L\@_orig_p:
+    .pushsection .altinstructions, "a", @progbits
+    altinstruction_entry .L\@_orig_s, .L\@_repl_s1, \feature1, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()1 - .L\@_repl_s\()1), (.L\@_orig_p - .L\@_orig_e)
+    altinstruction_entry .L\@_orig_s, .L\@_repl_s2, \feature2, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()2 - .L\@_repl_s\()2), (.L\@_orig_p - .L\@_orig_e)
+    .section .discard, "a", @progbits
+    .byte (.L\@_orig_p - .L\@_orig_s)
+    .byte 0xff + (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_p - .L\@_orig_s)
+    .byte 0xff + (.L\@_repl_e\()2 - .L\@_repl_s\()2) - (.L\@_orig_p - .L\@_orig_s)
+    .section .altinstr_replacement, "ax", @progbits
+    .L\@_repl_s\()1: \newinstr1; .L\@_repl_e\()1:
+    .L\@_repl_s\()2: \newinstr2; .L\@_repl_e\()2:
+    .popsection
+.endm
+#endif
diff --git a/xen/include/asm-x86/asm-offsets.h b/xen/include/asm-x86/asm-offsets.h
new file mode 100644
index 0000000000..5eeced15ec
--- /dev/null
+++ b/xen/include/asm-x86/asm-offsets.h
@@ -0,0 +1,127 @@
+/*
+ * DO NOT MODIFY.
+ *
+ * This file was auto-generated from asm-offsets.s
+ *
+ */
+
+#ifndef __ASM_OFFSETS_H__
+#define __ASM_OFFSETS_H__
+
+#define UREGS_r15 0 /* offsetof(struct cpu_user_regs, r15) */
+#define UREGS_r14 8 /* offsetof(struct cpu_user_regs, r14) */
+#define UREGS_r13 16 /* offsetof(struct cpu_user_regs, r13) */
+#define UREGS_r12 24 /* offsetof(struct cpu_user_regs, r12) */
+#define UREGS_rbp 32 /* offsetof(struct cpu_user_regs, rbp) */
+#define UREGS_rbx 40 /* offsetof(struct cpu_user_regs, rbx) */
+#define UREGS_r11 48 /* offsetof(struct cpu_user_regs, r11) */
+#define UREGS_r10 56 /* offsetof(struct cpu_user_regs, r10) */
+#define UREGS_r9 64 /* offsetof(struct cpu_user_regs, r9) */
+#define UREGS_r8 72 /* offsetof(struct cpu_user_regs, r8) */
+#define UREGS_rax 80 /* offsetof(struct cpu_user_regs, rax) */
+#define UREGS_rcx 88 /* offsetof(struct cpu_user_regs, rcx) */
+#define UREGS_rdx 96 /* offsetof(struct cpu_user_regs, rdx) */
+#define UREGS_rsi 104 /* offsetof(struct cpu_user_regs, rsi) */
+#define UREGS_rdi 112 /* offsetof(struct cpu_user_regs, rdi) */
+#define UREGS_error_code 120 /* offsetof(struct cpu_user_regs, error_code) */
+#define UREGS_entry_vector 124 /* offsetof(struct cpu_user_regs, entry_vector) */
+#define UREGS_rip 128 /* offsetof(struct cpu_user_regs, rip) */
+#define UREGS_cs 136 /* offsetof(struct cpu_user_regs, cs) */
+#define UREGS_eflags 144 /* offsetof(struct cpu_user_regs, rflags) */
+#define UREGS_rsp 152 /* offsetof(struct cpu_user_regs, rsp) */
+#define UREGS_ss 160 /* offsetof(struct cpu_user_regs, ss) */
+#define UREGS_kernel_sizeof 168 /* offsetof(struct cpu_user_regs, es) */
+
+#define VCPU_processor 4 /* offsetof(struct vcpu, processor) */
+#define VCPU_domain 16 /* offsetof(struct vcpu, domain) */
+#define VCPU_vcpu_info 8 /* offsetof(struct vcpu, vcpu_info) */
+#define VCPU_trap_bounce 1456 /* offsetof(struct vcpu, arch.pv.trap_bounce) */
+#define VCPU_thread_flags 896 /* offsetof(struct vcpu, arch.flags) */
+#define VCPU_event_addr 1384 /* offsetof(struct vcpu, arch.pv.event_callback_eip) */
+#define VCPU_event_sel 1400 /* offsetof(struct vcpu, arch.pv.event_callback_cs) */
+#define VCPU_syscall_addr 1400 /* offsetof(struct vcpu, arch.pv.syscall_callback_eip) */
+#define VCPU_syscall32_addr 1408 /* offsetof(struct vcpu, arch.pv.syscall32_callback_eip) */
+#define VCPU_syscall32_sel 1424 /* offsetof(struct vcpu, arch.pv.syscall32_callback_cs) */
+#define VCPU_syscall32_disables_events 1428 /* offsetof(struct vcpu, arch.pv.syscall32_disables_events) */
+#define VCPU_sysenter_addr 1416 /* offsetof(struct vcpu, arch.pv.sysenter_callback_eip) */
+#define VCPU_sysenter_sel 1426 /* offsetof(struct vcpu, arch.pv.sysenter_callback_cs) */
+#define VCPU_sysenter_disables_events 1429 /* offsetof(struct vcpu, arch.pv.sysenter_disables_events) */
+#define VCPU_trap_ctxt 1168 /* offsetof(struct vcpu, arch.pv.trap_ctxt) */
+#define VCPU_kernel_sp 1312 /* offsetof(struct vcpu, arch.pv.kernel_sp) */
+#define VCPU_kernel_ss 1304 /* offsetof(struct vcpu, arch.pv.kernel_ss) */
+#define VCPU_iopl 1484 /* offsetof(struct vcpu, arch.pv.iopl) */
+#define VCPU_guest_context_flags 1160 /* offsetof(struct vcpu, arch.pv.vgc_flags) */
+#define VCPU_cr3 2856 /* offsetof(struct vcpu, arch.cr3) */
+#define VCPU_arch_msrs 3416 /* offsetof(struct vcpu, arch.msrs) */
+#define VCPU_nmi_pending 960 /* offsetof(struct vcpu, arch.async_exception_state[(1)-1].pending) */
+#define VCPU_mce_pending 962 /* offsetof(struct vcpu, arch.async_exception_state[(2)-1].pending) */
+#define VCPU_nmi_old_mask 961 /* offsetof(struct vcpu, arch.async_exception_state[(1)-1].old_mask) */
+#define VCPU_mce_old_mask 963 /* offsetof(struct vcpu, arch.async_exception_state[(2)-1].old_mask) */
+#define VCPU_async_exception_mask 964 /* offsetof(struct vcpu, arch.async_exception_mask) */
+#define VCPU_TRAP_NMI 1 /* VCPU_TRAP_NMI */
+#define VCPU_TRAP_MCE 2 /* VCPU_TRAP_MCE */
+#define _VGCF_syscall_disables_events 4 /* _VGCF_syscall_disables_events */
+
+#define VCPU_svm_vmcb_pa 1480 /* offsetof(struct vcpu, arch.hvm.svm.vmcb_pa) */
+#define VCPU_svm_vmcb 1472 /* offsetof(struct vcpu, arch.hvm.svm.vmcb) */
+
+#define VCPU_vmx_launched 1516 /* offsetof(struct vcpu, arch.hvm.vmx.launched) */
+#define VCPU_vmx_realmode 1738 /* offsetof(struct vcpu, arch.hvm.vmx.vmx_realmode) */
+#define VCPU_vmx_emulate 1739 /* offsetof(struct vcpu, arch.hvm.vmx.vmx_emulate) */
+#define VCPU_vm86_seg_mask 1742 /* offsetof(struct vcpu, arch.hvm.vmx.vm86_segment_mask) */
+#define VCPU_hvm_guest_cr2 1040 /* offsetof(struct vcpu, arch.hvm.guest_cr[2]) */
+
+#define VCPU_nhvm_guestmode 1960 /* offsetof(struct vcpu, arch.hvm.nvcpu.nv_guestmode) */
+#define VCPU_nhvm_p2m 2192 /* offsetof(struct vcpu, arch.hvm.nvcpu.nv_p2m) */
+#define VCPU_nsvm_hap_enabled 2148 /* offsetof(struct vcpu, arch.hvm.nvcpu.u.nsvm.ns_hap_enabled) */
+
+#define VCPUINFO_upcall_pending 0 /* offsetof(struct vcpu_info, evtchn_upcall_pending) */
+#define VCPUINFO_upcall_mask 1 /* offsetof(struct vcpu_info, evtchn_upcall_mask) */
+
+#define CPUINFO_guest_cpu_user_regs 0 /* offsetof(struct cpu_info, guest_cpu_user_regs) */
+#define CPUINFO_verw_sel 204 /* offsetof(struct cpu_info, verw_sel) */
+#define CPUINFO_current_vcpu 208 /* offsetof(struct cpu_info, current_vcpu) */
+#define CPUINFO_per_cpu_offset 216 /* offsetof(struct cpu_info, per_cpu_offset) */
+#define CPUINFO_cr4 224 /* offsetof(struct cpu_info, cr4) */
+#define CPUINFO_xen_cr3 232 /* offsetof(struct cpu_info, xen_cr3) */
+#define CPUINFO_pv_cr3 240 /* offsetof(struct cpu_info, pv_cr3) */
+#define CPUINFO_shadow_spec_ctrl 248 /* offsetof(struct cpu_info, shadow_spec_ctrl) */
+#define CPUINFO_xen_spec_ctrl 252 /* offsetof(struct cpu_info, xen_spec_ctrl) */
+#define CPUINFO_spec_ctrl_flags 253 /* offsetof(struct cpu_info, spec_ctrl_flags) */
+#define CPUINFO_root_pgt_changed 254 /* offsetof(struct cpu_info, root_pgt_changed) */
+#define CPUINFO_use_pv_cr3 255 /* offsetof(struct cpu_info, use_pv_cr3) */
+#define CPUINFO_sizeof 264 /* sizeof(struct cpu_info) */
+
+#define TRAPINFO_eip 8 /* offsetof(struct trap_info, address) */
+#define TRAPINFO_cs 2 /* offsetof(struct trap_info, cs) */
+#define TRAPINFO_flags 1 /* offsetof(struct trap_info, flags) */
+#define TRAPINFO_sizeof 16 /* sizeof(struct trap_info) */
+
+#define TRAPBOUNCE_error_code 0 /* offsetof(struct trap_bounce, error_code) */
+#define TRAPBOUNCE_flags 4 /* offsetof(struct trap_bounce, flags) */
+#define TRAPBOUNCE_cs 6 /* offsetof(struct trap_bounce, cs) */
+#define TRAPBOUNCE_eip 8 /* offsetof(struct trap_bounce, eip) */
+
+#define VCPUMSR_spec_ctrl_raw 0 /* offsetof(struct vcpu_msrs, spec_ctrl.raw) */
+
+#define IRQSTAT_shift 7 /* ilog2(sizeof(irq_cpustat_t)) */
+#define IRQSTAT_softirq_pending 0 /* offsetof(irq_cpustat_t, __softirq_pending) */
+
+#define CPUINFO_features 12 /* offsetof(struct cpuinfo_x86, x86_capability) */
+
+#define MB_flags 0 /* offsetof(multiboot_info_t, flags) */
+#define MB_cmdline 16 /* offsetof(multiboot_info_t, cmdline) */
+#define MB_mem_lower 4 /* offsetof(multiboot_info_t, mem_lower) */
+
+#define MB2_fixed_sizeof 8 /* sizeof(multiboot2_fixed_t) */
+#define MB2_fixed_total_size 0 /* offsetof(multiboot2_fixed_t, total_size) */
+#define MB2_tag_type 0 /* offsetof(multiboot2_tag_t, type) */
+#define MB2_tag_size 4 /* offsetof(multiboot2_tag_t, size) */
+#define MB2_load_base_addr 8 /* offsetof(multiboot2_tag_load_base_addr_t, load_base_addr) */
+#define MB2_mem_lower 8 /* offsetof(multiboot2_tag_basic_meminfo_t, mem_lower) */
+#define MB2_efi64_st 8 /* offsetof(multiboot2_tag_efi64_t, pointer) */
+#define MB2_efi64_ih 8 /* offsetof(multiboot2_tag_efi64_ih_t, pointer) */
+
+#define DOMAIN_vm_assist 544 /* offsetof(struct domain, vm_assist) */
+
+#endif
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 28146ee404..0df72baf2e 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
 #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
 #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
 
+static inline bool is_system_domid(domid_t id)
+{
+    return (id >= DOMID_FIRST_RESERVED);
+}
+
 static inline bool is_system_domain(const struct domain *d)
 {
-    return d->domain_id >= DOMID_FIRST_RESERVED;
+    return is_system_domid(d->domain_id);
 }
 
 #define DOMAIN_DESTROYED (1u << 31) /* assumes atomic_t is >= 32 bits */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 11:56:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 11:56:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249591.430016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHGo-0008Q9-TX; Mon, 20 Dec 2021 11:55:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249591.430016; Mon, 20 Dec 2021 11:55:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHGo-0008Q2-QR; Mon, 20 Dec 2021 11:55:58 +0000
Received: by outflank-mailman (input) for mailman id 249591;
 Mon, 20 Dec 2021 11:55:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=efIU=RF=linutronix.de=tglx@srs-se1.protection.inumbo.net>)
 id 1mzHGn-0008Pv-0b
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 11:55:57 +0000
Received: from galois.linutronix.de (galois.linutronix.de
 [2a0a:51c0:0:12e:550::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c8674213-618b-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 12:55:55 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c8674213-618b-11ec-9e60-abaf8a552007
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1640001352;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/CUTvkF0ZJD/0bUX2KphRLF8+ED9CK1uoT06irTMlA8=;
	b=HSeZ4MSHoOtA7+F6FETI6mp8k3+faOYIGAz2lfvwDy1sSASh6hTd2VQBM/xtD9dWQ6/+it
	Xx1QiktSyrVJW+s/MoE14UBVxgCvvz4QKIShLntOLlYBJxOVA077qH2vgT/zKoawye+Uqx
	snVV6hWDoQFRr82vrxuTiQA6fWGNWW8AQwrmHtXAqARcz5dCEF253M2O/8L7qxll49Y14E
	5fSXcstjpAFKPqGx7Ea82OtzbwbxPCD/3HPgDpfoxqEWUh14UdrFA6upqctLwnFjwYbD3a
	oi0s+ejfwagnJisgRBLJVVnUWCRjx+V6vSjMsZE6J9vLkzoXsCRI261DIG6qXg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1640001352;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=/CUTvkF0ZJD/0bUX2KphRLF8+ED9CK1uoT06irTMlA8=;
	b=xrSZ1J5EcwueXFBw2+PxkXfD7FQuFpsVSXWU/APxdJHshmEM2RfAp9OAgcYlk78X64Avva
	QQ/LsT2krF+p+kDg==
To: =?utf-8?Q?C=C3=A9dric?= Le Goater <clg@kaod.org>, Nathan Chancellor
 <nathan@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>,
 Marc Zygnier <maz@kernel.org>, Alex Williamson
 <alex.williamson@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Jason
 Gunthorpe <jgg@nvidia.com>, Megha Dey <megha.dey@intel.com>, Ashok Raj
 <ashok.raj@intel.com>, linux-pci@vger.kernel.org, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, Juergen Gross <jgross@suse.com>,
 xen-devel@lists.xenproject.org, Arnd Bergmann <arnd@arndb.de>, Michael
 Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt
 <benh@kernel.crashing.org>, linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas
 <bhelgaas@google.com>, Stuart Yoder <stuyoder@gmail.com>, Laurentiu Tudor
 <laurentiu.tudor@nxp.com>, Nishanth Menon <nm@ti.com>, Tero Kristo
 <kristo@kernel.org>, Santosh Shilimkar <ssantosh@kernel.org>,
 linux-arm-kernel@lists.infradead.org, Vinod Koul <vkoul@kernel.org>,
 dmaengine@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, Will
 Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Joerg
 Roedel <joro@8bytes.org>, iommu@lists.linux-foundation.org, Jassi Brar
 <jassisinghbrar@gmail.com>, Peter Ujfalusi <peter.ujfalusi@gmail.com>,
 Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()
In-Reply-To: <ee5db32f-c21e-287f-2a19-94c1ba6e8217@kaod.org>
References: <20211210221642.869015045@linutronix.de>
 <20211210221814.900929381@linutronix.de>
 <Yb0PaCyo/6z3XOlf@archlinux-ax161> <87v8zm9pmd.ffs@tglx>
 <ee5db32f-c21e-287f-2a19-94c1ba6e8217@kaod.org>
Date: Mon, 20 Dec 2021 12:55:51 +0100
Message-ID: <87pmpra3so.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 18 2021 at 21:25, C=C3=A9dric Le Goater wrote:

> On 12/18/21 11:25, Thomas Gleixner wrote:
>> On Fri, Dec 17 2021 at 15:30, Nathan Chancellor wrote:
>>> On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote:
>>> I just bisected a boot failure on my AMD test desktop to this patch as
>>> commit f48235900182 ("PCI/MSI: Simplify pci_irq_get_affinity()") in
>>> -next. It looks like there is a problem with the NVMe drive after this
>>> change according to the logs. Given that the hard drive is not getting
>>> mounted for journald to write logs to, I am not really sure how to get
>>> them from the machine so I have at least taken a picture of what I see
>>> on my screen; open to ideas on that front!
>>=20
>> Bah. Fix below.
>
> That's a fix for the issue I was seeing on pseries with NVMe.
>
> Tested-by: C=C3=A9dric Le Goater <clg@kaod.org>

I had a faint memory that I've seen that issue before, but couldn't find
the mail in those massive threads.

Thanks for confirming!

       tglx


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:03:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:03:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249608.430044 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHNi-00029L-7T; Mon, 20 Dec 2021 12:03:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249608.430044; Mon, 20 Dec 2021 12:03:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHNi-00029E-4J; Mon, 20 Dec 2021 12:03:06 +0000
Received: by outflank-mailman (input) for mailman id 249608;
 Mon, 20 Dec 2021 12:03:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IL3F=RF=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1mzHNh-0001of-4w
 for xen-devel@lists.xen.org; Mon, 20 Dec 2021 12:03:05 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c6667e80-618c-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 13:03:02 +0100 (CET)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHNS-0003uF-GG; Mon, 20 Dec 2021 12:02:50 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHNS-0001sS-ET; Mon, 20 Dec 2021 12:02:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c6667e80-618c-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=6BgNg28SI0s4sHVA7BGjvIm38wGcrHCuw5I+hdnWL+0=; b=4fYTwlkfU8bRO8FQ3SAmexRmXG
	4SBU+P0elAzk3jh+TBftM966KYeguYhwzA3xx1tPJmCTwYoghsLB1FTCtq7acDCLx6rGoxihH3YKq
	Qb19oHiHBQr5hraLO3uFaUj7vOHpc8ZbpIP+b6OXXvwaAGfMfUU/29w/YZSa7cKq3VYo=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 391 v3 (CVE-2021-28711,CVE-2021-28712,CVE-2021-28713)
 - Rogue backends can cause DoS of guests via high frequency events
Message-Id: <E1mzHNS-0001sS-ET@xenbits.xenproject.org>
Date: Mon, 20 Dec 2021 12:02:50 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

 Xen Security Advisory CVE-2021-28711,CVE-2021-28712,CVE-2021-28713 / XSA-391
                                   version 3

   Rogue backends can cause DoS of guests via high frequency events

UPDATES IN VERSION 3
====================

Public release

ISSUE DESCRIPTION
=================

Xen offers the ability to run PV backends in regular unprivileged
guests, typically referred to as "driver domains". Running PV backends
in driver domains has one primary security advantage: if a driver domain
gets compromised, it doesn't have the privileges to take over the
system.

However, a malicious driver domain could try to attack other guests via
sending events at a high frequency leading to a Denial of Service in the
guest due to trying to service interrupts for elongated amounts of time.

There are three affected backends:
 * blkfront          patch 1, CVE-2021-28711
 * netfront          patch 2, CVE-2021-28712
 * hvc_xen (console) patch 3, CVE-2021-28713

IMPACT
======

Potentially malicious PV backends can cause guest DoS due to unhardened
frontends in the guests, even though this ought to have been prevented by
containing them within a driver domain.

VULNERABLE SYSTEMS
==================

All guests being serviced by potentially malicious backends are vulnerable,
even if those backends are running in a less privileged environment. The
vulnerability is not affecting the host, but the guests.

MITIGATION
==========

There is no known mitigation available.

RESOLUTION
==========

Applying the attached patches resolves this issue.

xsa391-linux-1.patch   Linux 5.15
xsa391-linux-2.patch   Linux 5.15
xsa391-linux-3.patch   Linux 5.15

$ sha256sum xsa391*
e55d3f15a85ff31e62a291981de89f7b0c08da807db9b2a6a2b9cbb2e29847cd  xsa391-linux-1.patch
163fc4b9966768eb74e3bc1858a0b0254eff771898bd5f4d71806beeae0ffd2a  xsa391-linux-2.patch
de888abe8d11d3204b4033b304cf3d66104a65956089e23f1736db682d3cedc4  xsa391-linux-3.patch
$

CREDITS
=======

This issue was discovered by Jürgen Groß of SUSE.

DEPLOYMENT DURING EMBARGO
=========================

Deployment of patches or mitigations is NOT permitted (except where
all the affected systems and VMs are administered and used only by
organisations which are members of the Xen Project Security Issues
Predisclosure List).  Specifically, deployment on public cloud systems
is NOT permitted.

This is because the patches need to be applied to the guests, which will
be visible by the guest administrators.

Deployment is permitted only AFTER the embargo ends.

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmG8srwMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZz/kH/RFI60D9qJnbNmDMgtbvihwn+jeHI0ejS7en8Ojf
CL9QftZ2+YdyxjMISOHCCaWgUKQQyF/n9chF5sMMOkWRfUPL2TDPPKTmEnC9XMOq
MYIftwT0OoMAVVhrRU3FZUZtpvTeQstofOYhBGhElmeEibYU+DbjKiv4agTEE3+8
9M3cxDk3Zw9cO1/6tU3kYtPkbxVP3r6kZQSHnpRnKLbABXWJB3Y02cX09tU//mV7
2REisCWKViLcKoupYTUOQHPWOD+VFE48mwKB4D9H9t9aTyn5PVjH/jVhiGrqbbic
ia8a0AKi5F9l8xIKha81+TGIbjCY+HCuLbaShRDnaU9/2Qc=
=wKo2
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa391-linux-1.patch"
Content-Disposition: attachment; filename="xsa391-linux-1.patch"
Content-Transfer-Encoding: base64

RnJvbSAyNmIyYmQxMDc3YjgxMWE1ZmFlOTJmZGQ5NTg2NzAzZmQ4MWE3YWQx
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFdlZCwgMSBEZWMgMjAyMSAxMzow
MDowNCArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMS8zXSB4ZW4vYmxrZnJvbnQ6
IGhhcmRlbiBibGtmcm9udCBhZ2FpbnN0IGV2ZW50IGNoYW5uZWwKIHN0b3Jt
cwoKVGhlIFhlbiBibGtmcm9udCBkcml2ZXIgaXMgc3RpbGwgdnVsbmVyYWJs
ZSBmb3IgYW4gYXR0YWNrIHZpYSBleGNlc3NpdmUKbnVtYmVyIG9mIGV2ZW50
cyBzZW50IGJ5IHRoZSBiYWNrZW5kLiBGaXggdGhhdCBieSB1c2luZyBsYXRl
ZW9pIGV2ZW50CmNoYW5uZWxzLgoKVGhpcyBpcyBDVkUtMjAyMS0yODcxMSwg
cGFydCBvZiBYU0EtMzkxCgpTaWduZWQtb2ZmLWJ5OiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8
amJldWxpY2hAc3VzZS5jb20+Ci0tLQogZHJpdmVycy9ibG9jay94ZW4tYmxr
ZnJvbnQuYyB8IDE1ICsrKysrKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQs
IDEyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYyBiL2RyaXZlcnMvYmxv
Y2sveGVuLWJsa2Zyb250LmMKaW5kZXggOGUzOTgzZTQ1NmYzLi4yODZjZjFh
ZmFkNzggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250
LmMKKysrIGIvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYwpAQCAtMTUx
Miw5ICsxNTEyLDEyIEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBibGtpZl9pbnRl
cnJ1cHQoaW50IGlycSwgdm9pZCAqZGV2X2lkKQogCXVuc2lnbmVkIGxvbmcg
ZmxhZ3M7CiAJc3RydWN0IGJsa2Zyb250X3JpbmdfaW5mbyAqcmluZm8gPSAo
c3RydWN0IGJsa2Zyb250X3JpbmdfaW5mbyAqKWRldl9pZDsKIAlzdHJ1Y3Qg
YmxrZnJvbnRfaW5mbyAqaW5mbyA9IHJpbmZvLT5kZXZfaW5mbzsKKwl1bnNp
Z25lZCBpbnQgZW9pZmxhZyA9IFhFTl9FT0lfRkxBR19TUFVSSU9VUzsKIAot
CWlmICh1bmxpa2VseShpbmZvLT5jb25uZWN0ZWQgIT0gQkxLSUZfU1RBVEVf
Q09OTkVDVEVEKSkKKwlpZiAodW5saWtlbHkoaW5mby0+Y29ubmVjdGVkICE9
IEJMS0lGX1NUQVRFX0NPTk5FQ1RFRCkpIHsKKwkJeGVuX2lycV9sYXRlZW9p
KGlycSwgWEVOX0VPSV9GTEFHX1NQVVJJT1VTKTsKIAkJcmV0dXJuIElSUV9I
QU5ETEVEOworCX0KIAogCXNwaW5fbG9ja19pcnFzYXZlKCZyaW5mby0+cmlu
Z19sb2NrLCBmbGFncyk7CiAgYWdhaW46CkBAIC0xNTMwLDYgKzE1MzMsOCBA
QCBzdGF0aWMgaXJxcmV0dXJuX3QgYmxraWZfaW50ZXJydXB0KGludCBpcnEs
IHZvaWQgKmRldl9pZCkKIAkJdW5zaWduZWQgbG9uZyBpZDsKIAkJdW5zaWdu
ZWQgaW50IG9wOwogCisJCWVvaWZsYWcgPSAwOworCiAJCVJJTkdfQ09QWV9S
RVNQT05TRSgmcmluZm8tPnJpbmcsIGksICZicmV0KTsKIAkJaWQgPSBicmV0
LmlkOwogCkBAIC0xNjQ2LDYgKzE2NTEsOCBAQCBzdGF0aWMgaXJxcmV0dXJu
X3QgYmxraWZfaW50ZXJydXB0KGludCBpcnEsIHZvaWQgKmRldl9pZCkKIAog
CXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnJpbmZvLT5yaW5nX2xvY2ssIGZs
YWdzKTsKIAorCXhlbl9pcnFfbGF0ZWVvaShpcnEsIGVvaWZsYWcpOworCiAJ
cmV0dXJuIElSUV9IQU5ETEVEOwogCiAgZXJyOgpAQCAtMTY1Myw2ICsxNjYw
LDggQEAgc3RhdGljIGlycXJldHVybl90IGJsa2lmX2ludGVycnVwdChpbnQg
aXJxLCB2b2lkICpkZXZfaWQpCiAKIAlzcGluX3VubG9ja19pcnFyZXN0b3Jl
KCZyaW5mby0+cmluZ19sb2NrLCBmbGFncyk7CiAKKwkvKiBObyBFT0kgaW4g
b3JkZXIgdG8gYXZvaWQgZnVydGhlciBpbnRlcnJ1cHRzLiAqLworCiAJcHJf
YWxlcnQoIiVzIGRpc2FibGVkIGZvciBmdXJ0aGVyIHVzZVxuIiwgaW5mby0+
Z2QtPmRpc2tfbmFtZSk7CiAJcmV0dXJuIElSUV9IQU5ETEVEOwogfQpAQCAt
MTY5Miw4ICsxNzAxLDggQEAgc3RhdGljIGludCBzZXR1cF9ibGtyaW5nKHN0
cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsCiAJaWYgKGVycikKIAkJZ290byBm
YWlsOwogCi0JZXJyID0gYmluZF9ldnRjaG5fdG9faXJxaGFuZGxlcihyaW5m
by0+ZXZ0Y2huLCBibGtpZl9pbnRlcnJ1cHQsIDAsCi0JCQkJCSJibGtpZiIs
IHJpbmZvKTsKKwllcnIgPSBiaW5kX2V2dGNobl90b19pcnFoYW5kbGVyX2xh
dGVlb2kocmluZm8tPmV2dGNobiwgYmxraWZfaW50ZXJydXB0LAorCQkJCQkJ
MCwgImJsa2lmIiwgcmluZm8pOwogCWlmIChlcnIgPD0gMCkgewogCQl4ZW5i
dXNfZGV2X2ZhdGFsKGRldiwgZXJyLAogCQkJCSAiYmluZF9ldnRjaG5fdG9f
aXJxaGFuZGxlciBmYWlsZWQiKTsKLS0gCjIuMjYuMgoK

--=separator
Content-Type: application/octet-stream; name="xsa391-linux-2.patch"
Content-Disposition: attachment; filename="xsa391-linux-2.patch"
Content-Transfer-Encoding: base64

RnJvbSA4MDVlNjMwMmVlMzgzMTNkNmM0ZTYxNjIzMzJlYzNhNjY4MmNhMDY4
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFdlZCwgMSBEZWMgMjAyMSAxMzow
MDowNCArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMi8zXSB4ZW4vbmV0ZnJvbnQ6
IGhhcmRlbiBuZXRmcm9udCBhZ2FpbnN0IGV2ZW50IGNoYW5uZWwKIHN0b3Jt
cwoKVGhlIFhlbiBuZXRmcm9udCBkcml2ZXIgaXMgc3RpbGwgdnVsbmVyYWJs
ZSBmb3IgYW4gYXR0YWNrIHZpYSBleGNlc3NpdmUKbnVtYmVyIG9mIGV2ZW50
cyBzZW50IGJ5IHRoZSBiYWNrZW5kLiBGaXggdGhhdCBieSB1c2luZyBsYXRl
ZW9pIGV2ZW50CmNoYW5uZWxzLgoKRm9yIGJlaW5nIGFibGUgdG8gZGV0ZWN0
IHRoZSBjYXNlIG9mIG5vIHJ4IHJlc3BvbnNlcyBiZWluZyBhZGRlZCB3aGls
ZQp0aGUgY2FycmllciBpcyBkb3duIGEgbmV3IGxvY2sgaXMgbmVlZGVkIGlu
IG9yZGVyIHRvIHVwZGF0ZSBhbmQgdGVzdApyc3BfY29ucyBhbmQgdGhlIG51
bWJlciBvZiBzZWVuIHVuY29uc3VtZWQgcmVzcG9uc2VzIGF0b21pY2FsbHku
CgpUaGlzIGlzIENWRS0yMDIxLTI4NzEyLCBwYXJ0IG9mIFhTQS0zOTEKClNp
Z25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4K
UmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4K
LS0tCiBkcml2ZXJzL25ldC94ZW4tbmV0ZnJvbnQuYyB8IDEyNSArKysrKysr
KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl
ZCwgOTQgaW5zZXJ0aW9ucygrKSwgMzEgZGVsZXRpb25zKC0pCgpkaWZmIC0t
Z2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMgYi9kcml2ZXJzL25l
dC94ZW4tbmV0ZnJvbnQuYwppbmRleCA5MTFmNDM5ODZhOGMuLmQ1MTRkOTYw
MjdhNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMK
KysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMKQEAgLTE0OCw2ICsx
NDgsOSBAQCBzdHJ1Y3QgbmV0ZnJvbnRfcXVldWUgewogCWdyYW50X3JlZl90
IGdyZWZfcnhfaGVhZDsKIAlncmFudF9yZWZfdCBncmFudF9yeF9yZWZbTkVU
X1JYX1JJTkdfU0laRV07CiAKKwl1bnNpZ25lZCBpbnQgcnhfcnNwX3VuY29u
c3VtZWQ7CisJc3BpbmxvY2tfdCByeF9jb25zX2xvY2s7CisKIAlzdHJ1Y3Qg
cGFnZV9wb29sICpwYWdlX3Bvb2w7CiAJc3RydWN0IHhkcF9yeHFfaW5mbyB4
ZHBfcnhxOwogfTsKQEAgLTM3NiwxMiArMzc5LDEzIEBAIHN0YXRpYyBpbnQg
eGVubmV0X29wZW4oc3RydWN0IG5ldF9kZXZpY2UgKmRldikKIAlyZXR1cm4g
MDsKIH0KIAotc3RhdGljIHZvaWQgeGVubmV0X3R4X2J1Zl9nYyhzdHJ1Y3Qg
bmV0ZnJvbnRfcXVldWUgKnF1ZXVlKQorc3RhdGljIGJvb2wgeGVubmV0X3R4
X2J1Zl9nYyhzdHJ1Y3QgbmV0ZnJvbnRfcXVldWUgKnF1ZXVlKQogewogCVJJ
TkdfSURYIGNvbnMsIHByb2Q7CiAJdW5zaWduZWQgc2hvcnQgaWQ7CiAJc3Ry
dWN0IHNrX2J1ZmYgKnNrYjsKIAlib29sIG1vcmVfdG9fZG87CisJYm9vbCB3
b3JrX2RvbmUgPSBmYWxzZTsKIAljb25zdCBzdHJ1Y3QgZGV2aWNlICpkZXYg
PSAmcXVldWUtPmluZm8tPm5ldGRldi0+ZGV2OwogCiAJQlVHX09OKCFuZXRp
Zl9jYXJyaWVyX29rKHF1ZXVlLT5pbmZvLT5uZXRkZXYpKTsKQEAgLTM5OCw2
ICs0MDIsOCBAQCBzdGF0aWMgdm9pZCB4ZW5uZXRfdHhfYnVmX2djKHN0cnVj
dCBuZXRmcm9udF9xdWV1ZSAqcXVldWUpCiAJCWZvciAoY29ucyA9IHF1ZXVl
LT50eC5yc3BfY29uczsgY29ucyAhPSBwcm9kOyBjb25zKyspIHsKIAkJCXN0
cnVjdCB4ZW5fbmV0aWZfdHhfcmVzcG9uc2UgdHhyc3A7CiAKKwkJCXdvcmtf
ZG9uZSA9IHRydWU7CisKIAkJCVJJTkdfQ09QWV9SRVNQT05TRSgmcXVldWUt
PnR4LCBjb25zLCAmdHhyc3ApOwogCQkJaWYgKHR4cnNwLnN0YXR1cyA9PSBY
RU5fTkVUSUZfUlNQX05VTEwpCiAJCQkJY29udGludWU7CkBAIC00NDEsMTEg
KzQ0NywxMyBAQCBzdGF0aWMgdm9pZCB4ZW5uZXRfdHhfYnVmX2djKHN0cnVj
dCBuZXRmcm9udF9xdWV1ZSAqcXVldWUpCiAKIAl4ZW5uZXRfbWF5YmVfd2Fr
ZV90eChxdWV1ZSk7CiAKLQlyZXR1cm47CisJcmV0dXJuIHdvcmtfZG9uZTsK
IAogIGVycjoKIAlxdWV1ZS0+aW5mby0+YnJva2VuID0gdHJ1ZTsKIAlkZXZf
YWxlcnQoZGV2LCAiRGlzYWJsZWQgZm9yIGZ1cnRoZXIgdXNlXG4iKTsKKwor
CXJldHVybiB3b3JrX2RvbmU7CiB9CiAKIHN0cnVjdCB4ZW5uZXRfZ250dGFi
X21ha2VfdHhyZXEgewpAQCAtODM0LDYgKzg0MiwxNiBAQCBzdGF0aWMgaW50
IHhlbm5ldF9jbG9zZShzdHJ1Y3QgbmV0X2RldmljZSAqZGV2KQogCXJldHVy
biAwOwogfQogCitzdGF0aWMgdm9pZCB4ZW5uZXRfc2V0X3J4X3JzcF9jb25z
KHN0cnVjdCBuZXRmcm9udF9xdWV1ZSAqcXVldWUsIFJJTkdfSURYIHZhbCkK
K3sKKwl1bnNpZ25lZCBsb25nIGZsYWdzOworCisJc3Bpbl9sb2NrX2lycXNh
dmUoJnF1ZXVlLT5yeF9jb25zX2xvY2ssIGZsYWdzKTsKKwlxdWV1ZS0+cngu
cnNwX2NvbnMgPSB2YWw7CisJcXVldWUtPnJ4X3JzcF91bmNvbnN1bWVkID0g
UklOR19IQVNfVU5DT05TVU1FRF9SRVNQT05TRVMoJnF1ZXVlLT5yeCk7CisJ
c3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmcXVldWUtPnJ4X2NvbnNfbG9jaywg
ZmxhZ3MpOworfQorCiBzdGF0aWMgdm9pZCB4ZW5uZXRfbW92ZV9yeF9zbG90
KHN0cnVjdCBuZXRmcm9udF9xdWV1ZSAqcXVldWUsIHN0cnVjdCBza19idWZm
ICpza2IsCiAJCQkJZ3JhbnRfcmVmX3QgcmVmKQogewpAQCAtODg1LDcgKzkw
Myw3IEBAIHN0YXRpYyBpbnQgeGVubmV0X2dldF9leHRyYXMoc3RydWN0IG5l
dGZyb250X3F1ZXVlICpxdWV1ZSwKIAkJeGVubmV0X21vdmVfcnhfc2xvdChx
dWV1ZSwgc2tiLCByZWYpOwogCX0gd2hpbGUgKGV4dHJhLmZsYWdzICYgWEVO
X05FVElGX0VYVFJBX0ZMQUdfTU9SRSk7CiAKLQlxdWV1ZS0+cngucnNwX2Nv
bnMgPSBjb25zOworCXhlbm5ldF9zZXRfcnhfcnNwX2NvbnMocXVldWUsIGNv
bnMpOwogCXJldHVybiBlcnI7CiB9CiAKQEAgLTEwMzksNyArMTA1Nyw3IEBA
IHN0YXRpYyBpbnQgeGVubmV0X2dldF9yZXNwb25zZXMoc3RydWN0IG5ldGZy
b250X3F1ZXVlICpxdWV1ZSwKIAl9CiAKIAlpZiAodW5saWtlbHkoZXJyKSkK
LQkJcXVldWUtPnJ4LnJzcF9jb25zID0gY29ucyArIHNsb3RzOworCQl4ZW5u
ZXRfc2V0X3J4X3JzcF9jb25zKHF1ZXVlLCBjb25zICsgc2xvdHMpOwogCiAJ
cmV0dXJuIGVycjsKIH0KQEAgLTEwOTMsNyArMTExMSw4IEBAIHN0YXRpYyBp
bnQgeGVubmV0X2ZpbGxfZnJhZ3Moc3RydWN0IG5ldGZyb250X3F1ZXVlICpx
dWV1ZSwKIAkJCV9fcHNrYl9wdWxsX3RhaWwoc2tiLCBwdWxsX3RvIC0gc2ti
X2hlYWRsZW4oc2tiKSk7CiAJCX0KIAkJaWYgKHVubGlrZWx5KHNrYl9zaGlu
Zm8oc2tiKS0+bnJfZnJhZ3MgPj0gTUFYX1NLQl9GUkFHUykpIHsKLQkJCXF1
ZXVlLT5yeC5yc3BfY29ucyA9ICsrY29ucyArIHNrYl9xdWV1ZV9sZW4obGlz
dCk7CisJCQl4ZW5uZXRfc2V0X3J4X3JzcF9jb25zKHF1ZXVlLAorCQkJCQkg
ICAgICAgKytjb25zICsgc2tiX3F1ZXVlX2xlbihsaXN0KSk7CiAJCQlrZnJl
ZV9za2IobnNrYik7CiAJCQlyZXR1cm4gLUVOT0VOVDsKIAkJfQpAQCAtMTEw
Niw3ICsxMTI1LDcgQEAgc3RhdGljIGludCB4ZW5uZXRfZmlsbF9mcmFncyhz
dHJ1Y3QgbmV0ZnJvbnRfcXVldWUgKnF1ZXVlLAogCQlrZnJlZV9za2IobnNr
Yik7CiAJfQogCi0JcXVldWUtPnJ4LnJzcF9jb25zID0gY29uczsKKwl4ZW5u
ZXRfc2V0X3J4X3JzcF9jb25zKHF1ZXVlLCBjb25zKTsKIAogCXJldHVybiAw
OwogfQpAQCAtMTIyOSw3ICsxMjQ4LDkgQEAgc3RhdGljIGludCB4ZW5uZXRf
cG9sbChzdHJ1Y3QgbmFwaV9zdHJ1Y3QgKm5hcGksIGludCBidWRnZXQpCiAK
IAkJCWlmICh1bmxpa2VseSh4ZW5uZXRfc2V0X3NrYl9nc28oc2tiLCBnc28p
KSkgewogCQkJCV9fc2tiX3F1ZXVlX2hlYWQoJnRtcHEsIHNrYik7Ci0JCQkJ
cXVldWUtPnJ4LnJzcF9jb25zICs9IHNrYl9xdWV1ZV9sZW4oJnRtcHEpOwor
CQkJCXhlbm5ldF9zZXRfcnhfcnNwX2NvbnMocXVldWUsCisJCQkJCQkgICAg
ICAgcXVldWUtPnJ4LnJzcF9jb25zICsKKwkJCQkJCSAgICAgICBza2JfcXVl
dWVfbGVuKCZ0bXBxKSk7CiAJCQkJZ290byBlcnI7CiAJCQl9CiAJCX0KQEAg
LTEyNTMsNyArMTI3NCw4IEBAIHN0YXRpYyBpbnQgeGVubmV0X3BvbGwoc3Ry
dWN0IG5hcGlfc3RydWN0ICpuYXBpLCBpbnQgYnVkZ2V0KQogCiAJCV9fc2ti
X3F1ZXVlX3RhaWwoJnJ4cSwgc2tiKTsKIAotCQlpID0gKytxdWV1ZS0+cngu
cnNwX2NvbnM7CisJCWkgPSBxdWV1ZS0+cngucnNwX2NvbnMgKyAxOworCQl4
ZW5uZXRfc2V0X3J4X3JzcF9jb25zKHF1ZXVlLCBpKTsKIAkJd29ya19kb25l
Kys7CiAJfQogCWlmIChuZWVkX3hkcF9mbHVzaCkKQEAgLTE0MTcsNDAgKzE0
MzksNzkgQEAgc3RhdGljIGludCB4ZW5uZXRfc2V0X2ZlYXR1cmVzKHN0cnVj
dCBuZXRfZGV2aWNlICpkZXYsCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBp
cnFyZXR1cm5fdCB4ZW5uZXRfdHhfaW50ZXJydXB0KGludCBpcnEsIHZvaWQg
KmRldl9pZCkKK3N0YXRpYyBib29sIHhlbm5ldF9oYW5kbGVfdHgoc3RydWN0
IG5ldGZyb250X3F1ZXVlICpxdWV1ZSwgdW5zaWduZWQgaW50ICplb2kpCiB7
Ci0Jc3RydWN0IG5ldGZyb250X3F1ZXVlICpxdWV1ZSA9IGRldl9pZDsKIAl1
bnNpZ25lZCBsb25nIGZsYWdzOwogCi0JaWYgKHF1ZXVlLT5pbmZvLT5icm9r
ZW4pCi0JCXJldHVybiBJUlFfSEFORExFRDsKKwlpZiAodW5saWtlbHkocXVl
dWUtPmluZm8tPmJyb2tlbikpCisJCXJldHVybiBmYWxzZTsKIAogCXNwaW5f
bG9ja19pcnFzYXZlKCZxdWV1ZS0+dHhfbG9jaywgZmxhZ3MpOwotCXhlbm5l
dF90eF9idWZfZ2MocXVldWUpOworCWlmICh4ZW5uZXRfdHhfYnVmX2djKHF1
ZXVlKSkKKwkJKmVvaSA9IDA7CiAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgm
cXVldWUtPnR4X2xvY2ssIGZsYWdzKTsKIAorCXJldHVybiB0cnVlOworfQor
CitzdGF0aWMgaXJxcmV0dXJuX3QgeGVubmV0X3R4X2ludGVycnVwdChpbnQg
aXJxLCB2b2lkICpkZXZfaWQpCit7CisJdW5zaWduZWQgaW50IGVvaWZsYWcg
PSBYRU5fRU9JX0ZMQUdfU1BVUklPVVM7CisKKwlpZiAobGlrZWx5KHhlbm5l
dF9oYW5kbGVfdHgoZGV2X2lkLCAmZW9pZmxhZykpKQorCQl4ZW5faXJxX2xh
dGVlb2koaXJxLCBlb2lmbGFnKTsKKwogCXJldHVybiBJUlFfSEFORExFRDsK
IH0KIAotc3RhdGljIGlycXJldHVybl90IHhlbm5ldF9yeF9pbnRlcnJ1cHQo
aW50IGlycSwgdm9pZCAqZGV2X2lkKQorc3RhdGljIGJvb2wgeGVubmV0X2hh
bmRsZV9yeChzdHJ1Y3QgbmV0ZnJvbnRfcXVldWUgKnF1ZXVlLCB1bnNpZ25l
ZCBpbnQgKmVvaSkKIHsKLQlzdHJ1Y3QgbmV0ZnJvbnRfcXVldWUgKnF1ZXVl
ID0gZGV2X2lkOwotCXN0cnVjdCBuZXRfZGV2aWNlICpkZXYgPSBxdWV1ZS0+
aW5mby0+bmV0ZGV2OworCXVuc2lnbmVkIGludCB3b3JrX3F1ZXVlZDsKKwl1
bnNpZ25lZCBsb25nIGZsYWdzOwogCi0JaWYgKHF1ZXVlLT5pbmZvLT5icm9r
ZW4pCi0JCXJldHVybiBJUlFfSEFORExFRDsKKwlpZiAodW5saWtlbHkocXVl
dWUtPmluZm8tPmJyb2tlbikpCisJCXJldHVybiBmYWxzZTsKKworCXNwaW5f
bG9ja19pcnFzYXZlKCZxdWV1ZS0+cnhfY29uc19sb2NrLCBmbGFncyk7CisJ
d29ya19xdWV1ZWQgPSBSSU5HX0hBU19VTkNPTlNVTUVEX1JFU1BPTlNFUygm
cXVldWUtPnJ4KTsKKwlpZiAod29ya19xdWV1ZWQgPiBxdWV1ZS0+cnhfcnNw
X3VuY29uc3VtZWQpIHsKKwkJcXVldWUtPnJ4X3JzcF91bmNvbnN1bWVkID0g
d29ya19xdWV1ZWQ7CisJCSplb2kgPSAwOworCX0gZWxzZSBpZiAodW5saWtl
bHkod29ya19xdWV1ZWQgPCBxdWV1ZS0+cnhfcnNwX3VuY29uc3VtZWQpKSB7
CisJCWNvbnN0IHN0cnVjdCBkZXZpY2UgKmRldiA9ICZxdWV1ZS0+aW5mby0+
bmV0ZGV2LT5kZXY7CisKKwkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmcXVl
dWUtPnJ4X2NvbnNfbG9jaywgZmxhZ3MpOworCQlkZXZfYWxlcnQoZGV2LCAi
UlggcHJvZHVjZXIgaW5kZXggZ29pbmcgYmFja3dhcmRzXG4iKTsKKwkJZGV2
X2FsZXJ0KGRldiwgIkRpc2FibGVkIGZvciBmdXJ0aGVyIHVzZVxuIik7CisJ
CXF1ZXVlLT5pbmZvLT5icm9rZW4gPSB0cnVlOworCQlyZXR1cm4gZmFsc2U7
CisJfQorCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnF1ZXVlLT5yeF9jb25z
X2xvY2ssIGZsYWdzKTsKIAotCWlmIChsaWtlbHkobmV0aWZfY2Fycmllcl9v
ayhkZXYpICYmCi0JCSAgIFJJTkdfSEFTX1VOQ09OU1VNRURfUkVTUE9OU0VT
KCZxdWV1ZS0+cngpKSkKKwlpZiAobGlrZWx5KG5ldGlmX2NhcnJpZXJfb2so
cXVldWUtPmluZm8tPm5ldGRldikgJiYgd29ya19xdWV1ZWQpKQogCQluYXBp
X3NjaGVkdWxlKCZxdWV1ZS0+bmFwaSk7CiAKKwlyZXR1cm4gdHJ1ZTsKK30K
Kworc3RhdGljIGlycXJldHVybl90IHhlbm5ldF9yeF9pbnRlcnJ1cHQoaW50
IGlycSwgdm9pZCAqZGV2X2lkKQoreworCXVuc2lnbmVkIGludCBlb2lmbGFn
ID0gWEVOX0VPSV9GTEFHX1NQVVJJT1VTOworCisJaWYgKGxpa2VseSh4ZW5u
ZXRfaGFuZGxlX3J4KGRldl9pZCwgJmVvaWZsYWcpKSkKKwkJeGVuX2lycV9s
YXRlZW9pKGlycSwgZW9pZmxhZyk7CisKIAlyZXR1cm4gSVJRX0hBTkRMRUQ7
CiB9CiAKIHN0YXRpYyBpcnFyZXR1cm5fdCB4ZW5uZXRfaW50ZXJydXB0KGlu
dCBpcnEsIHZvaWQgKmRldl9pZCkKIHsKLQl4ZW5uZXRfdHhfaW50ZXJydXB0
KGlycSwgZGV2X2lkKTsKLQl4ZW5uZXRfcnhfaW50ZXJydXB0KGlycSwgZGV2
X2lkKTsKKwl1bnNpZ25lZCBpbnQgZW9pZmxhZyA9IFhFTl9FT0lfRkxBR19T
UFVSSU9VUzsKKworCWlmICh4ZW5uZXRfaGFuZGxlX3R4KGRldl9pZCwgJmVv
aWZsYWcpICYmCisJICAgIHhlbm5ldF9oYW5kbGVfcngoZGV2X2lkLCAmZW9p
ZmxhZykpCisJCXhlbl9pcnFfbGF0ZWVvaShpcnEsIGVvaWZsYWcpOworCiAJ
cmV0dXJuIElSUV9IQU5ETEVEOwogfQogCkBAIC0xNzY4LDkgKzE4MjksMTAg
QEAgc3RhdGljIGludCBzZXR1cF9uZXRmcm9udF9zaW5nbGUoc3RydWN0IG5l
dGZyb250X3F1ZXVlICpxdWV1ZSkKIAlpZiAoZXJyIDwgMCkKIAkJZ290byBm
YWlsOwogCi0JZXJyID0gYmluZF9ldnRjaG5fdG9faXJxaGFuZGxlcihxdWV1
ZS0+dHhfZXZ0Y2huLAotCQkJCQl4ZW5uZXRfaW50ZXJydXB0LAotCQkJCQkw
LCBxdWV1ZS0+aW5mby0+bmV0ZGV2LT5uYW1lLCBxdWV1ZSk7CisJZXJyID0g
YmluZF9ldnRjaG5fdG9faXJxaGFuZGxlcl9sYXRlZW9pKHF1ZXVlLT50eF9l
dnRjaG4sCisJCQkJCQl4ZW5uZXRfaW50ZXJydXB0LCAwLAorCQkJCQkJcXVl
dWUtPmluZm8tPm5ldGRldi0+bmFtZSwKKwkJCQkJCXF1ZXVlKTsKIAlpZiAo
ZXJyIDwgMCkKIAkJZ290byBiaW5kX2ZhaWw7CiAJcXVldWUtPnJ4X2V2dGNo
biA9IHF1ZXVlLT50eF9ldnRjaG47CkBAIC0xNzk4LDE4ICsxODYwLDE4IEBA
IHN0YXRpYyBpbnQgc2V0dXBfbmV0ZnJvbnRfc3BsaXQoc3RydWN0IG5ldGZy
b250X3F1ZXVlICpxdWV1ZSkKIAogCXNucHJpbnRmKHF1ZXVlLT50eF9pcnFf
bmFtZSwgc2l6ZW9mKHF1ZXVlLT50eF9pcnFfbmFtZSksCiAJCSAiJXMtdHgi
LCBxdWV1ZS0+bmFtZSk7Ci0JZXJyID0gYmluZF9ldnRjaG5fdG9faXJxaGFu
ZGxlcihxdWV1ZS0+dHhfZXZ0Y2huLAotCQkJCQl4ZW5uZXRfdHhfaW50ZXJy
dXB0LAotCQkJCQkwLCBxdWV1ZS0+dHhfaXJxX25hbWUsIHF1ZXVlKTsKKwll
cnIgPSBiaW5kX2V2dGNobl90b19pcnFoYW5kbGVyX2xhdGVlb2kocXVldWUt
PnR4X2V2dGNobiwKKwkJCQkJCXhlbm5ldF90eF9pbnRlcnJ1cHQsIDAsCisJ
CQkJCQlxdWV1ZS0+dHhfaXJxX25hbWUsIHF1ZXVlKTsKIAlpZiAoZXJyIDwg
MCkKIAkJZ290byBiaW5kX3R4X2ZhaWw7CiAJcXVldWUtPnR4X2lycSA9IGVy
cjsKIAogCXNucHJpbnRmKHF1ZXVlLT5yeF9pcnFfbmFtZSwgc2l6ZW9mKHF1
ZXVlLT5yeF9pcnFfbmFtZSksCiAJCSAiJXMtcngiLCBxdWV1ZS0+bmFtZSk7
Ci0JZXJyID0gYmluZF9ldnRjaG5fdG9faXJxaGFuZGxlcihxdWV1ZS0+cnhf
ZXZ0Y2huLAotCQkJCQl4ZW5uZXRfcnhfaW50ZXJydXB0LAotCQkJCQkwLCBx
dWV1ZS0+cnhfaXJxX25hbWUsIHF1ZXVlKTsKKwllcnIgPSBiaW5kX2V2dGNo
bl90b19pcnFoYW5kbGVyX2xhdGVlb2kocXVldWUtPnJ4X2V2dGNobiwKKwkJ
CQkJCXhlbm5ldF9yeF9pbnRlcnJ1cHQsIDAsCisJCQkJCQlxdWV1ZS0+cnhf
aXJxX25hbWUsIHF1ZXVlKTsKIAlpZiAoZXJyIDwgMCkKIAkJZ290byBiaW5k
X3J4X2ZhaWw7CiAJcXVldWUtPnJ4X2lycSA9IGVycjsKQEAgLTE5MTEsNiAr
MTk3Myw3IEBAIHN0YXRpYyBpbnQgeGVubmV0X2luaXRfcXVldWUoc3RydWN0
IG5ldGZyb250X3F1ZXVlICpxdWV1ZSkKIAogCXNwaW5fbG9ja19pbml0KCZx
dWV1ZS0+dHhfbG9jayk7CiAJc3Bpbl9sb2NrX2luaXQoJnF1ZXVlLT5yeF9s
b2NrKTsKKwlzcGluX2xvY2tfaW5pdCgmcXVldWUtPnJ4X2NvbnNfbG9jayk7
CiAKIAl0aW1lcl9zZXR1cCgmcXVldWUtPnJ4X3JlZmlsbF90aW1lciwgcnhf
cmVmaWxsX3RpbWVvdXQsIDApOwogCi0tIAoyLjI2LjIKCg==

--=separator
Content-Type: application/octet-stream; name="xsa391-linux-3.patch"
Content-Disposition: attachment; filename="xsa391-linux-3.patch"
Content-Transfer-Encoding: base64

RnJvbSBhOTNkYmQwM2U4YTNlMmZhMGUxMDM5ZGVlMTIyZTQ3ODE5NzA4NzU5
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFdlZCwgMSBEZWMgMjAyMSAxMzow
MDowNCArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSB4ZW4vY29uc29sZTog
aGFyZGVuIGh2Y194ZW4gYWdhaW5zdCBldmVudCBjaGFubmVsCiBzdG9ybXMK
ClRoZSBYZW4gY29uc29sZSBkcml2ZXIgaXMgc3RpbGwgdnVsbmVyYWJsZSBm
b3IgYW4gYXR0YWNrIHZpYSBleGNlc3NpdmUKbnVtYmVyIG9mIGV2ZW50cyBz
ZW50IGJ5IHRoZSBiYWNrZW5kLiBGaXggdGhhdCBieSB1c2luZyBhIGxhdGVl
b2kgZXZlbnQKY2hhbm5lbC4KCkZvciB0aGUgbm9ybWFsIGRvbVUgaW5pdGlh
bCBjb25zb2xlIHRoaXMgcmVxdWlyZXMgdGhlIGludHJvZHVjdGlvbiBvZgpi
aW5kX2V2dGNobl90b19pcnFfbGF0ZWVvaSgpIGFzIHRoZXJlIGlzIG5vIHhl
bmJ1cyBkZXZpY2UgYXZhaWxhYmxlCmF0IHRoZSB0aW1lIHRoZSBldmVudCBj
aGFubmVsIGlzIGJvdW5kIHRvIHRoZSBpcnEuCgpBcyB0aGUgZGVjaXNpb24g
d2hldGhlciBhbiBpbnRlcnJ1cHQgd2FzIHNwdXJpb3VzIG9yIG5vdCByZXF1
aXJlcyB0bwp0ZXN0IGZvciBieXRlcyBoYXZpbmcgYmVlbiByZWFkIGZyb20g
dGhlIGJhY2tlbmQsIG1vdmUgc2VuZGluZyB0aGUKZXZlbnQgaW50byB0aGUg
aWYgc3RhdGVtZW50LCBhcyBzZW5kaW5nIGFuIGV2ZW50IHdpdGhvdXQgaGF2
aW5nIGZvdW5kCmFueSBieXRlcyB0byBiZSByZWFkIGlzIG1ha2luZyBubyBz
ZW5zZSBhdCBhbGwuCgpUaGlzIGlzIENWRS0yMDIxLTI4NzEzLCBwYXJ0IG9m
IFhTQS0zOTEKClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z
c0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj
aEBzdXNlLmNvbT4KLS0tCiBkcml2ZXJzL3R0eS9odmMvaHZjX3hlbi5jICAg
ICAgICB8IDMwICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQogZHJp
dmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMgfCAgNiArKysrKysKIGlu
Y2x1ZGUveGVuL2V2ZW50cy5oICAgICAgICAgICAgIHwgIDEgKwogMyBmaWxl
cyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoK
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdHR5L2h2Yy9odmNfeGVuLmMgYi9kcml2
ZXJzL3R0eS9odmMvaHZjX3hlbi5jCmluZGV4IDcxZTBkZDJjMGNlNS4uZWJh
Zjc1MDBmNDhmIDEwMDY0NAotLS0gYS9kcml2ZXJzL3R0eS9odmMvaHZjX3hl
bi5jCisrKyBiL2RyaXZlcnMvdHR5L2h2Yy9odmNfeGVuLmMKQEAgLTM3LDYg
KzM3LDggQEAgc3RydWN0IHhlbmNvbnNfaW5mbyB7CiAJc3RydWN0IHhlbmJ1
c19kZXZpY2UgKnhiZGV2OwogCXN0cnVjdCB4ZW5jb25zX2ludGVyZmFjZSAq
aW50ZjsKIAl1bnNpZ25lZCBpbnQgZXZ0Y2huOworCVhFTkNPTlNfUklOR19J
RFggb3V0X2NvbnM7CisJdW5zaWduZWQgaW50IG91dF9jb25zX3NhbWU7CiAJ
c3RydWN0IGh2Y19zdHJ1Y3QgKmh2YzsKIAlpbnQgaXJxOwogCWludCB2dGVy
bW5vOwpAQCAtMTM4LDYgKzE0MCw4IEBAIHN0YXRpYyBpbnQgZG9tVV9yZWFk
X2NvbnNvbGUodWludDMyX3QgdnRlcm1ubywgY2hhciAqYnVmLCBpbnQgbGVu
KQogCVhFTkNPTlNfUklOR19JRFggY29ucywgcHJvZDsKIAlpbnQgcmVjdiA9
IDA7CiAJc3RydWN0IHhlbmNvbnNfaW5mbyAqeGVuY29ucyA9IHZ0ZXJtbm9f
dG9feGVuY29ucyh2dGVybW5vKTsKKwl1bnNpZ25lZCBpbnQgZW9pZmxhZyA9
IDA7CisKIAlpZiAoeGVuY29ucyA9PSBOVUxMKQogCQlyZXR1cm4gLUVJTlZB
TDsKIAlpbnRmID0geGVuY29ucy0+aW50ZjsKQEAgLTE1Nyw3ICsxNjEsMjcg
QEAgc3RhdGljIGludCBkb21VX3JlYWRfY29uc29sZSh1aW50MzJfdCB2dGVy
bW5vLCBjaGFyICpidWYsIGludCBsZW4pCiAJbWIoKTsJCQkvKiByZWFkIHJp
bmcgYmVmb3JlIGNvbnN1bWluZyAqLwogCWludGYtPmluX2NvbnMgPSBjb25z
OwogCi0Jbm90aWZ5X2RhZW1vbih4ZW5jb25zKTsKKwkvKgorCSAqIFdoZW4g
dG8gbWFyayBpbnRlcnJ1cHQgaGF2aW5nIGJlZW4gc3B1cmlvdXM6CisJICog
LSB0aGVyZSB3YXMgbm8gbmV3IGRhdGEgdG8gYmUgcmVhZCwgYW5kCisJICog
LSB0aGUgYmFja2VuZCBkaWQgbm90IGNvbnN1bWUgc29tZSBvdXRwdXQgYnl0
ZXMsIGFuZAorCSAqIC0gdGhlIHByZXZpb3VzIHJvdW5kIHdpdGggbm8gcmVh
ZCBkYXRhIGRpZG4ndCBzZWUgY29uc3VtZWQgYnl0ZXMKKwkgKiAgICh3ZSBt
aWdodCBoYXZlIGEgcmFjZSB3aXRoIGFuIGludGVycnVwdCBiZWluZyBpbiBm
bGlnaHQgd2hpbGUKKwkgKiAgIHVwZGF0aW5nIHhlbmNvbnMtPm91dF9jb25z
LCBzbyBhY2NvdW50IGZvciB0aGF0IGJ5IGFsbG93aW5nIG9uZQorCSAqICAg
cm91bmQgd2l0aG91dCBhbnkgdmlzaWJsZSByZWFzb24pCisJICovCisJaWYg
KGludGYtPm91dF9jb25zICE9IHhlbmNvbnMtPm91dF9jb25zKSB7CisJCXhl
bmNvbnMtPm91dF9jb25zID0gaW50Zi0+b3V0X2NvbnM7CisJCXhlbmNvbnMt
Pm91dF9jb25zX3NhbWUgPSAwOworCX0KKwlpZiAocmVjdikgeworCQlub3Rp
ZnlfZGFlbW9uKHhlbmNvbnMpOworCX0gZWxzZSBpZiAoeGVuY29ucy0+b3V0
X2NvbnNfc2FtZSsrID4gMSkgeworCQllb2lmbGFnID0gWEVOX0VPSV9GTEFH
X1NQVVJJT1VTOworCX0KKworCXhlbl9pcnFfbGF0ZWVvaSh4ZW5jb25zLT5p
cnEsIGVvaWZsYWcpOworCiAJcmV0dXJuIHJlY3Y7CiB9CiAKQEAgLTM4Niw3
ICs0MTAsNyBAQCBzdGF0aWMgaW50IHhlbmNvbnNfY29ubmVjdF9iYWNrZW5k
KHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsCiAJaWYgKHJldCkKIAkJcmV0
dXJuIHJldDsKIAlpbmZvLT5ldnRjaG4gPSBldnRjaG47Ci0JaXJxID0gYmlu
ZF9ldnRjaG5fdG9faXJxKGV2dGNobik7CisJaXJxID0gYmluZF9pbnRlcmRv
bWFpbl9ldnRjaG5fdG9faXJxX2xhdGVlb2koZGV2LCBldnRjaG4pOwogCWlm
IChpcnEgPCAwKQogCQlyZXR1cm4gaXJxOwogCWluZm8tPmlycSA9IGlycTsK
QEAgLTU1MSw3ICs1NzUsNyBAQCBzdGF0aWMgaW50IF9faW5pdCB4ZW5faHZj
X2luaXQodm9pZCkKIAkJCXJldHVybiByOwogCiAJCWluZm8gPSB2dGVybW5v
X3RvX3hlbmNvbnMoSFZDX0NPT0tJRSk7Ci0JCWluZm8tPmlycSA9IGJpbmRf
ZXZ0Y2huX3RvX2lycShpbmZvLT5ldnRjaG4pOworCQlpbmZvLT5pcnEgPSBi
aW5kX2V2dGNobl90b19pcnFfbGF0ZWVvaShpbmZvLT5ldnRjaG4pOwogCX0K
IAlpZiAoaW5mby0+aXJxIDwgMCkKIAkJaW5mby0+aXJxID0gMDsgLyogTk9f
SVJRICovCmRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRz
X2Jhc2UuYyBiL2RyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jCmlu
ZGV4IGE3ODcwNGFlMzYxOC4uNDZkOTI5NWQ5YTZlIDEwMDY0NAotLS0gYS9k
cml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYworKysgYi9kcml2ZXJz
L3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYwpAQCAtMTI1MSw2ICsxMjUxLDEy
IEBAIGludCBiaW5kX2V2dGNobl90b19pcnEoZXZ0Y2huX3BvcnRfdCBldnRj
aG4pCiB9CiBFWFBPUlRfU1lNQk9MX0dQTChiaW5kX2V2dGNobl90b19pcnEp
OwogCitpbnQgYmluZF9ldnRjaG5fdG9faXJxX2xhdGVlb2koZXZ0Y2huX3Bv
cnRfdCBldnRjaG4pCit7CisJcmV0dXJuIGJpbmRfZXZ0Y2huX3RvX2lycV9j
aGlwKGV2dGNobiwgJnhlbl9sYXRlZW9pX2NoaXAsIE5VTEwpOworfQorRVhQ
T1JUX1NZTUJPTF9HUEwoYmluZF9ldnRjaG5fdG9faXJxX2xhdGVlb2kpOwor
CiBzdGF0aWMgaW50IGJpbmRfaXBpX3RvX2lycSh1bnNpZ25lZCBpbnQgaXBp
LCB1bnNpZ25lZCBpbnQgY3B1KQogewogCXN0cnVjdCBldnRjaG5fYmluZF9p
cGkgYmluZF9pcGk7CmRpZmYgLS1naXQgYS9pbmNsdWRlL3hlbi9ldmVudHMu
aCBiL2luY2x1ZGUveGVuL2V2ZW50cy5oCmluZGV4IGMyMDQyNjJkOWZjMi4u
MzQ0MDgxZTcxNTg0IDEwMDY0NAotLS0gYS9pbmNsdWRlL3hlbi9ldmVudHMu
aAorKysgYi9pbmNsdWRlL3hlbi9ldmVudHMuaApAQCAtMTcsNiArMTcsNyBA
QCBzdHJ1Y3QgeGVuYnVzX2RldmljZTsKIHVuc2lnbmVkIHhlbl9ldnRjaG5f
bnJfY2hhbm5lbHModm9pZCk7CiAKIGludCBiaW5kX2V2dGNobl90b19pcnEo
ZXZ0Y2huX3BvcnRfdCBldnRjaG4pOworaW50IGJpbmRfZXZ0Y2huX3RvX2ly
cV9sYXRlZW9pKGV2dGNobl9wb3J0X3QgZXZ0Y2huKTsKIGludCBiaW5kX2V2
dGNobl90b19pcnFoYW5kbGVyKGV2dGNobl9wb3J0X3QgZXZ0Y2huLAogCQkJ
ICAgICAgaXJxX2hhbmRsZXJfdCBoYW5kbGVyLAogCQkJICAgICAgdW5zaWdu
ZWQgbG9uZyBpcnFmbGFncywgY29uc3QgY2hhciAqZGV2bmFtZSwKLS0gCjIu
MjYuMgoK

--=separator--


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:03:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:03:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249613.430082 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHNz-00039s-EJ; Mon, 20 Dec 2021 12:03:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249613.430082; Mon, 20 Dec 2021 12:03:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHNz-000393-6r; Mon, 20 Dec 2021 12:03:23 +0000
Received: by outflank-mailman (input) for mailman id 249613;
 Mon, 20 Dec 2021 12:03:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IL3F=RF=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1mzHNx-0001n7-JB
 for xen-devel@lists.xen.org; Mon, 20 Dec 2021 12:03:21 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d19f504e-618c-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 13:03:20 +0100 (CET)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHNl-0003vK-1Z; Mon, 20 Dec 2021 12:03:09 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHNl-0002XV-04; Mon, 20 Dec 2021 12:03:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d19f504e-618c-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=6Hw5fE7cUwe2ArMj2R1FdsYTBEwKvx7jgxqt04XTWtc=; b=aGUxZCr2r6wBmy6x4WMy8Vs9ST
	zKHtMdDRqXWhFDaFW6meUtNig+mbivEN1SHjLSoE7EZz+Z1xn5DUnKtJP/eAnUktZ9X+H0aQFH0Lj
	lLY/FUKUhB170rFZ5dayr+1UMky9X0XwXgj4qdOiVpwZk5iNesZxpbWqGwKGM80w8X0I=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 392 v4 (CVE-2021-28714,CVE-2021-28715) -
 Guest can force Linux netback driver to hog large amounts of kernel memory
Message-Id: <E1mzHNl-0002XV-04@xenbits.xenproject.org>
Date: Mon, 20 Dec 2021 12:03:09 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

     Xen Security Advisory CVE-2021-28714,CVE-2021-28715 / XSA-392
                               version 4

 Guest can force Linux netback driver to hog large amounts of kernel memory

UPDATES IN VERSION 4
====================

Public release

ISSUE DESCRIPTION
=================

Incoming data packets for a guest in the Linux kernel's netback driver
are buffered until the guest is ready to process them. There are some
measures taken for avoiding to pile up too much data, but those can
be bypassed by the guest:

There is a timeout how long the client side of an interface can stop
consuming new packets before it is assumed to have stalled, but this
timeout is rather long (60 seconds by default). Using a UDP connection
on a fast interface can easily accumulate gigabytes of data in that
time.  (CVE-2021-28715)

The timeout could even never trigger if the guest manages to have only
one free slot in its RX queue ring page and the next package would
require more than one free slot, which may be the case when using GSO,
XDP, or software hashing.  (CVE-2021-28714)

IMPACT
======

The Linux kernel's xen-netback backend driver can be forced by guests
to queue arbitrary amounts of network data, finally causing an out of
memory situation in the domain the backend is running in (usually dom0).

VULNERABLE SYSTEMS
==================

All systems using the Linux kernel based network backend xen-netback
are vulnerable.

MITIGATION
==========

Using another PV network backend (e.g. the qemu based "qnic" backend)
will mitigate the problem.

Using a dedicated network driver domain per guest will mitigate the
problem.

RESOLUTION
==========

Applying the attached patches resolves this issue.

xsa392-linux-1.patch   Linux 5.15
xsa392-linux-2.patch   Linux 5.15

$ sha256sum xsa392*
9cf75e9919415267266a7f69ca0f3dbbafc1c55d4243cff1cb26072e28bb6e26  xsa392-linux-1.patch
f390da9723ed03948855bfc3b112fc11bcc794fc59502d4fc5e8e358321e8684  xsa392-linux-2.patch
$

CREDITS
=======

This issue was discovered by  Jürgen Groß of SUSE.

DEPLOYMENT DURING EMBARGO
=========================

Deployment of the *patches* is permitted during the embargo, even on
public-facing systems with untrusted guest users and administrators.

But: Distribution of updated software is prohibited (except to other
members of the predisclosure list).


Deployment of the *mitigations* (switching to driver domains or using
a qemu based backend) is NOT permitted (except where all the affected
systems and VMs are administered and used only by organisations which
are members of the Xen Project Security Issues Predisclosure List).
Specifically, deployment of the mitigations on public cloud systems is
NOT permitted.

This is because the mitigations will result in discoverable changes of
Xenstore entries for the guest.

Deployment of the mitigations is permitted only AFTER the embargo ends.


Predisclosure list members who wish to deploy significantly different
patches and/or mitigations, please contact the Xen Project Security
Team.

(Note: this during-embargo deployment notice is retained in
post-embargo publicly released Xen Project advisories, even though it
is then no longer applicable.  This is to enable the community to have
oversight of the Xen Project Security Team's decisionmaking.)

For more information about permissible uses of embargoed information,
consult the Xen Project community's agreed Security Policy:
  http://www.xenproject.org/security-policy.html
-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmG8sr8MHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZQGsH/igyavZ/s8jbiANP/jVW9/4wegsqqaeaQBEyhP0o
P2wEwX30taFmT+kC/7Rf+62O2vdOJKow4C+JouCKcigDH2+nvkki/gd65cpKLkk4
BKBuSnkTkagdokTPqpQ57zKTe9R5OP4Iw8B01YCI0k08aKE782xbxLr+pac3dw2C
3tB24fdFibrzlXeMbYXM2Aw8aeSWkVjJ40XrW+Xo6k8GdgTZY9SDgTqGAv71g+bJ
liCQheGkQIQPDjFUf6S/ykRCwaQVtnHqThASPoWOwzYto3uvjyMJm74Rr9n6TLzz
WvJLQPDgObyU9RUlUXU3fgCaYgvh2ufuNreQt1d1NY01s04=
=54ve
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa392-linux-1.patch"
Content-Disposition: attachment; filename="xsa392-linux-1.patch"
Content-Transfer-Encoding: base64

RnJvbSA4YjAxZWMyNmI2OWRmYjhmYzAzMzYwMDQ1NmM3NTIyNzc3YzhlMTgz
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IEZyaSwgMjYgTm92IDIwMjEgMTA6
MzY6NTcgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvMl0geGVuL25ldGJhY2s6
IGZpeCByeCBxdWV1ZSBzdGFsbCBkZXRlY3Rpb24KCkNvbW1pdCAxZDVkNDg1
MjM5MDBhNGIgKCJ4ZW4tbmV0YmFjazogcmVxdWlyZSBmZXdlciBndWVzdCBS
eCBzbG90cyB3aGVuCm5vdCB1c2luZyBHU08iKSBpbnRyb2R1Y2VkIGEgc2Vj
dXJpdHkgcHJvYmxlbSBpbiBuZXRiYWNrLCBhcyBhbgppbnRlcmZhY2Ugd291
bGQgb25seSBiZSByZWdhcmRlZCB0byBiZSBzdGFsbGVkIGlmIG5vIHNsb3Qg
aXMgYXZhaWxhYmxlCmluIHRoZSByeCBxdWV1ZSByaW5nIHBhZ2UuIEluIGNh
c2UgdGhlIFNLQiBhdCB0aGUgaGVhZCBvZiB0aGUgcXVldWVkCnJlcXVlc3Rz
IHdpbGwgbmVlZCBtb3JlIHRoYW4gb25lIHJ4IHNsb3QgYW5kIG9ubHkgb25l
IHNsb3QgaXMgZnJlZSB0aGUKc3RhbGwgZGV0ZWN0aW9uIGxvZ2ljIHdpbGwg
bmV2ZXIgdHJpZ2dlciwgYXMgdGhlIHRlc3QgZm9yIHRoYXQgaXMgb25seQps
b29raW5nIGZvciBhdCBsZWFzdCBvbmUgc2xvdCB0byBiZSBmcmVlLgoKRml4
IHRoYXQgYnkgdGVzdGluZyBmb3IgdGhlIG5lZWRlZCBudW1iZXIgb2Ygc2xv
dHMgaW5zdGVhZCBvZiBvbmx5IG9uZQpzbG90IGJlaW5nIGF2YWlsYWJsZS4K
CkluIG9yZGVyIHRvIG5vdCBoYXZlIHRvIHRha2UgdGhlIHJ4IHF1ZXVlIGxv
Y2sgdGhhdCBvZnRlbiwgc3RvcmUgdGhlCm51bWJlciBvZiBuZWVkZWQgc2xv
dHMgaW4gdGhlIHF1ZXVlIGRhdGEuIEFzIGFsbCBTS0IgZGVxdWV1ZSBvcGVy
YXRpb25zCmhhcHBlbiBpbiB0aGUgcnggcXVldWUga2VybmVsIHRocmVhZCB0
aGlzIGlzIHNhZmUsIGFzIGxvbmcgYXMgdGhlCm51bWJlciBvZiBuZWVkZWQg
c2xvdHMgaXMgYWNjZXNzZWQgdmlhIFJFQUQvV1JJVEVfT05DRSgpIG9ubHkg
YW5kCnVwZGF0ZXMgYXJlIGFsd2F5cyBkb25lIHdpdGggdGhlIHJ4IHF1ZXVl
IGxvY2sgaGVsZC4KCkFkZCBhIHNtYWxsIGhlbHBlciBmb3Igb2J0YWluaW5n
IHRoZSBudW1iZXIgb2YgZnJlZSBzbG90cy4KClRoaXMgaXMgQ1ZFLTIwMjEt
Mjg3MTQsIHBhcnQgb2YgWFNBLTM5MgoKRml4ZXM6IDFkNWQ0ODUyMzkwMGE0
YiAoInhlbi1uZXRiYWNrOiByZXF1aXJlIGZld2VyIGd1ZXN0IFJ4IHNsb3Rz
IHdoZW4gbm90IHVzaW5nIEdTTyIpClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4g
R3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVs
aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KLS0tCiBkcml2ZXJzL25ldC94ZW4t
bmV0YmFjay9jb21tb24uaCB8ICAxICsKIGRyaXZlcnMvbmV0L3hlbi1uZXRi
YWNrL3J4LmMgICAgIHwgNjUgKysrKysrKysrKysrKysrKysrKystLS0tLS0t
LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMjQg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5l
dGJhY2svY29tbW9uLmggYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21t
b24uaAppbmRleCA0YTE2ZDZlMzNjMDkuLmQ5ZGVhNDgyOWM4NiAxMDA2NDQK
LS0tIGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmgKKysrIGIv
ZHJpdmVycy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmgKQEAgLTIwMyw2ICsy
MDMsNyBAQCBzdHJ1Y3QgeGVudmlmX3F1ZXVlIHsgLyogUGVyLXF1ZXVlIGRh
dGEgZm9yIHhlbnZpZiAqLwogCXVuc2lnbmVkIGludCByeF9xdWV1ZV9tYXg7
CiAJdW5zaWduZWQgaW50IHJ4X3F1ZXVlX2xlbjsKIAl1bnNpZ25lZCBsb25n
IGxhc3RfcnhfdGltZTsKKwl1bnNpZ25lZCBpbnQgcnhfc2xvdHNfbmVlZGVk
OwogCWJvb2wgc3RhbGxlZDsKIAogCXN0cnVjdCB4ZW52aWZfY29weV9zdGF0
ZSByeF9jb3B5OwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJh
Y2svcnguYyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3J4LmMKaW5kZXgg
YWNjYzk5MWQxNTNmLi5hODUxMWUyN2Q2YzEgMTAwNjQ0Ci0tLSBhL2RyaXZl
cnMvbmV0L3hlbi1uZXRiYWNrL3J4LmMKKysrIGIvZHJpdmVycy9uZXQveGVu
LW5ldGJhY2svcnguYwpAQCAtMzMsMjggKzMzLDM2IEBACiAjaW5jbHVkZSA8
eGVuL3hlbi5oPgogI2luY2x1ZGUgPHhlbi9ldmVudHMuaD4KIAotc3RhdGlj
IGJvb2wgeGVudmlmX3J4X3Jpbmdfc2xvdHNfYXZhaWxhYmxlKHN0cnVjdCB4
ZW52aWZfcXVldWUgKnF1ZXVlKQorLyoKKyAqIFVwZGF0ZSB0aGUgbmVlZGVk
IHJpbmcgcGFnZSBzbG90cyBmb3IgdGhlIGZpcnN0IFNLQiBxdWV1ZWQuCisg
KiBOb3RlIHRoYXQgYW55IGNhbGwgc2VxdWVuY2Ugb3V0c2lkZSB0aGUgUlgg
dGhyZWFkIGNhbGxpbmcgdGhpcyBmdW5jdGlvbgorICogbmVlZHMgdG8gd2Fr
ZSB1cCB0aGUgUlggdGhyZWFkIHZpYSBhIGNhbGwgb2YgeGVudmlmX2tpY2tf
dGhyZWFkKCkKKyAqIGFmdGVyd2FyZHMgaW4gb3JkZXIgdG8gYXZvaWQgYSBy
YWNlIHdpdGggcHV0dGluZyB0aGUgdGhyZWFkIHRvIHNsZWVwLgorICovCitz
dGF0aWMgdm9pZCB4ZW52aWZfdXBkYXRlX25lZWRlZF9zbG90cyhzdHJ1Y3Qg
eGVudmlmX3F1ZXVlICpxdWV1ZSwKKwkJCQkgICAgICAgY29uc3Qgc3RydWN0
IHNrX2J1ZmYgKnNrYikKIHsKLQlSSU5HX0lEWCBwcm9kLCBjb25zOwotCXN0
cnVjdCBza19idWZmICpza2I7Ci0JaW50IG5lZWRlZDsKLQl1bnNpZ25lZCBs
b25nIGZsYWdzOwotCi0Jc3Bpbl9sb2NrX2lycXNhdmUoJnF1ZXVlLT5yeF9x
dWV1ZS5sb2NrLCBmbGFncyk7CisJdW5zaWduZWQgaW50IG5lZWRlZCA9IDA7
CiAKLQlza2IgPSBza2JfcGVlaygmcXVldWUtPnJ4X3F1ZXVlKTsKLQlpZiAo
IXNrYikgewotCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZxdWV1ZS0+cnhf
cXVldWUubG9jaywgZmxhZ3MpOwotCQlyZXR1cm4gZmFsc2U7CisJaWYgKHNr
YikgeworCQluZWVkZWQgPSBESVZfUk9VTkRfVVAoc2tiLT5sZW4sIFhFTl9Q
QUdFX1NJWkUpOworCQlpZiAoc2tiX2lzX2dzbyhza2IpKQorCQkJbmVlZGVk
Kys7CisJCWlmIChza2ItPnN3X2hhc2gpCisJCQluZWVkZWQrKzsKIAl9CiAK
LQluZWVkZWQgPSBESVZfUk9VTkRfVVAoc2tiLT5sZW4sIFhFTl9QQUdFX1NJ
WkUpOwotCWlmIChza2JfaXNfZ3NvKHNrYikpCi0JCW5lZWRlZCsrOwotCWlm
IChza2ItPnN3X2hhc2gpCi0JCW5lZWRlZCsrOworCVdSSVRFX09OQ0UocXVl
dWUtPnJ4X3Nsb3RzX25lZWRlZCwgbmVlZGVkKTsKK30KIAotCXNwaW5fdW5s
b2NrX2lycXJlc3RvcmUoJnF1ZXVlLT5yeF9xdWV1ZS5sb2NrLCBmbGFncyk7
CitzdGF0aWMgYm9vbCB4ZW52aWZfcnhfcmluZ19zbG90c19hdmFpbGFibGUo
c3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpCit7CisJUklOR19JRFggcHJv
ZCwgY29uczsKKwl1bnNpZ25lZCBpbnQgbmVlZGVkOworCisJbmVlZGVkID0g
UkVBRF9PTkNFKHF1ZXVlLT5yeF9zbG90c19uZWVkZWQpOworCWlmICghbmVl
ZGVkKQorCQlyZXR1cm4gZmFsc2U7CiAKIAlkbyB7CiAJCXByb2QgPSBxdWV1
ZS0+cnguc3JpbmctPnJlcV9wcm9kOwpAQCAtODAsNiArODgsOSBAQCB2b2lk
IHhlbnZpZl9yeF9xdWV1ZV90YWlsKHN0cnVjdCB4ZW52aWZfcXVldWUgKnF1
ZXVlLCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQogCiAJc3Bpbl9sb2NrX2lycXNh
dmUoJnF1ZXVlLT5yeF9xdWV1ZS5sb2NrLCBmbGFncyk7CiAKKwlpZiAoc2ti
X3F1ZXVlX2VtcHR5KCZxdWV1ZS0+cnhfcXVldWUpKQorCQl4ZW52aWZfdXBk
YXRlX25lZWRlZF9zbG90cyhxdWV1ZSwgc2tiKTsKKwogCV9fc2tiX3F1ZXVl
X3RhaWwoJnF1ZXVlLT5yeF9xdWV1ZSwgc2tiKTsKIAogCXF1ZXVlLT5yeF9x
dWV1ZV9sZW4gKz0gc2tiLT5sZW47CkBAIC0xMDAsNiArMTExLDggQEAgc3Rh
dGljIHN0cnVjdCBza19idWZmICp4ZW52aWZfcnhfZGVxdWV1ZShzdHJ1Y3Qg
eGVudmlmX3F1ZXVlICpxdWV1ZSkKIAogCXNrYiA9IF9fc2tiX2RlcXVldWUo
JnF1ZXVlLT5yeF9xdWV1ZSk7CiAJaWYgKHNrYikgeworCQl4ZW52aWZfdXBk
YXRlX25lZWRlZF9zbG90cyhxdWV1ZSwgc2tiX3BlZWsoJnF1ZXVlLT5yeF9x
dWV1ZSkpOworCiAJCXF1ZXVlLT5yeF9xdWV1ZV9sZW4gLT0gc2tiLT5sZW47
CiAJCWlmIChxdWV1ZS0+cnhfcXVldWVfbGVuIDwgcXVldWUtPnJ4X3F1ZXVl
X21heCkgewogCQkJc3RydWN0IG5ldGRldl9xdWV1ZSAqdHhxOwpAQCAtNDg3
LDI3ICs1MDAsMzEgQEAgdm9pZCB4ZW52aWZfcnhfYWN0aW9uKHN0cnVjdCB4
ZW52aWZfcXVldWUgKnF1ZXVlKQogCXhlbnZpZl9yeF9jb3B5X2ZsdXNoKHF1
ZXVlKTsKIH0KIAotc3RhdGljIGJvb2wgeGVudmlmX3J4X3F1ZXVlX3N0YWxs
ZWQoc3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpCitzdGF0aWMgUklOR19J
RFggeGVudmlmX3J4X3F1ZXVlX3Nsb3RzKGNvbnN0IHN0cnVjdCB4ZW52aWZf
cXVldWUgKnF1ZXVlKQogewogCVJJTkdfSURYIHByb2QsIGNvbnM7CiAKIAlw
cm9kID0gcXVldWUtPnJ4LnNyaW5nLT5yZXFfcHJvZDsKIAljb25zID0gcXVl
dWUtPnJ4LnJlcV9jb25zOwogCisJcmV0dXJuIHByb2QgLSBjb25zOworfQor
CitzdGF0aWMgYm9vbCB4ZW52aWZfcnhfcXVldWVfc3RhbGxlZChjb25zdCBz
dHJ1Y3QgeGVudmlmX3F1ZXVlICpxdWV1ZSkKK3sKKwl1bnNpZ25lZCBpbnQg
bmVlZGVkID0gUkVBRF9PTkNFKHF1ZXVlLT5yeF9zbG90c19uZWVkZWQpOwor
CiAJcmV0dXJuICFxdWV1ZS0+c3RhbGxlZCAmJgotCQlwcm9kIC0gY29ucyA8
IDEgJiYKKwkJeGVudmlmX3J4X3F1ZXVlX3Nsb3RzKHF1ZXVlKSA8IG5lZWRl
ZCAmJgogCQl0aW1lX2FmdGVyKGppZmZpZXMsCiAJCQkgICBxdWV1ZS0+bGFz
dF9yeF90aW1lICsgcXVldWUtPnZpZi0+c3RhbGxfdGltZW91dCk7CiB9CiAK
IHN0YXRpYyBib29sIHhlbnZpZl9yeF9xdWV1ZV9yZWFkeShzdHJ1Y3QgeGVu
dmlmX3F1ZXVlICpxdWV1ZSkKIHsKLQlSSU5HX0lEWCBwcm9kLCBjb25zOwot
Ci0JcHJvZCA9IHF1ZXVlLT5yeC5zcmluZy0+cmVxX3Byb2Q7Ci0JY29ucyA9
IHF1ZXVlLT5yeC5yZXFfY29uczsKKwl1bnNpZ25lZCBpbnQgbmVlZGVkID0g
UkVBRF9PTkNFKHF1ZXVlLT5yeF9zbG90c19uZWVkZWQpOwogCi0JcmV0dXJu
IHF1ZXVlLT5zdGFsbGVkICYmIHByb2QgLSBjb25zID49IDE7CisJcmV0dXJu
IHF1ZXVlLT5zdGFsbGVkICYmIHhlbnZpZl9yeF9xdWV1ZV9zbG90cyhxdWV1
ZSkgPj0gbmVlZGVkOwogfQogCiBib29sIHhlbnZpZl9oYXZlX3J4X3dvcmso
c3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUsIGJvb2wgdGVzdF9rdGhyZWFk
KQotLSAKMi4yNi4yCgo=

--=separator
Content-Type: application/octet-stream; name="xsa392-linux-2.patch"
Content-Disposition: attachment; filename="xsa392-linux-2.patch"
Content-Transfer-Encoding: base64

RnJvbSA3MTQ5MmYxZjEyZGI5NTZhOWViNDllNzI3ZDEyYjIyNWRhZDc0MjA1
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IEZyaSwgMjYgTm92IDIwMjEgMTA6
MzY6NTcgKzAxMDAKU3ViamVjdDogW1BBVENIIDIvMl0geGVuL25ldGJhY2s6
IGRvbid0IHF1ZXVlIHVubGltaXRlZCBudW1iZXIgb2YgcGFja2FnZXMKCklu
IGNhc2UgYSBndWVzdCBpc24ndCBjb25zdW1pbmcgaW5jb21pbmcgbmV0d29y
ayB0cmFmZmljIGFzIGZhc3QgYXMgaXQKaXMgY29taW5nIGluLCB4ZW4tbmV0
YmFjayBpcyBidWZmZXJpbmcgbmV0d29yayBwYWNrYWdlcyBpbiB1bmxpbWl0
ZWQKbnVtYmVycyB0b2RheS4gVGhpcyBjYW4gcmVzdWx0IGluIGhvc3QgT09N
IHNpdHVhdGlvbnMuCgpDb21taXQgZjQ4ZGE4YjE0ZDA0Y2E4ICgieGVuLW5l
dGJhY2s6IGZpeCB1bmxpbWl0ZWQgZ3Vlc3QgUnggaW50ZXJuYWwKcXVldWUg
YW5kIGNhcnJpZXIgZmxhcHBpbmciKSBtZWFudCB0byBpbnRyb2R1Y2UgYSBt
ZWNoYW5pc20gdG8gbGltaXQKdGhlIGFtb3VudCBvZiBidWZmZXJlZCBkYXRh
IGJ5IHN0b3BwaW5nIHRoZSBUeCBxdWV1ZSB3aGVuIHJlYWNoaW5nIHRoZQpk
YXRhIGxpbWl0LCBidXQgdGhpcyBkb2Vzbid0IHdvcmsgZm9yIGNhc2VzIGxp
a2UgVURQLgoKV2hlbiBoaXR0aW5nIHRoZSBsaW1pdCBkb24ndCBxdWV1ZSBm
dXJ0aGVyIFNLQnMsIGJ1dCBkcm9wIHRoZW0gaW5zdGVhZC4KSW4gb3JkZXIg
dG8gYmUgYWJsZSB0byB0ZWxsIFJ4IHBhY2thZ2VzIGhhdmUgYmVlbiBkcm9w
cGVkIGluY3JlbWVudCB0aGUKcnhfZHJvcHBlZCBzdGF0aXN0aWNzIGNvdW50
ZXIgaW4gdGhpcyBjYXNlLgoKSXQgc2hvdWxkIGJlIG5vdGVkIHRoYXQgdGhl
IG9sZCBzb2x1dGlvbiB0byBjb250aW51ZSBxdWV1ZWluZyBTS0JzIGhhZAp0
aGUgYWRkaXRpb25hbCBwcm9ibGVtIG9mIGFuIG92ZXJmbG93IG9mIHRoZSAz
Mi1iaXQgcnhfcXVldWVfbGVuIHZhbHVlCndvdWxkIHJlc3VsdCBpbiBpbnRl
cm1pdHRlbnQgVHggcXVldWUgZW5hYmxpbmcuCgpUaGlzIGlzIENWRS0yMDIx
LTI4NzE1LCBwYXJ0IG9mIFhTQS0zOTIKCkZpeGVzOiBmNDhkYThiMTRkMDRj
YTggKCJ4ZW4tbmV0YmFjazogZml4IHVubGltaXRlZCBndWVzdCBSeCBpbnRl
cm5hbCBxdWV1ZSBhbmQgY2FycmllciBmbGFwcGluZyIpClNpZ25lZC1vZmYt
Ynk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KUmV2aWV3ZWQt
Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KLS0tCiBkcml2
ZXJzL25ldC94ZW4tbmV0YmFjay9yeC5jIHwgMTggKysrKysrKysrKystLS0t
LS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgNyBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFj
ay9yeC5jIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svcnguYwppbmRleCBh
ODUxMWUyN2Q2YzEuLmRiYWM0YzAzZDIxYSAxMDA2NDQKLS0tIGEvZHJpdmVy
cy9uZXQveGVuLW5ldGJhY2svcnguYworKysgYi9kcml2ZXJzL25ldC94ZW4t
bmV0YmFjay9yeC5jCkBAIC04OCwxNiArODgsMTkgQEAgdm9pZCB4ZW52aWZf
cnhfcXVldWVfdGFpbChzdHJ1Y3QgeGVudmlmX3F1ZXVlICpxdWV1ZSwgc3Ry
dWN0IHNrX2J1ZmYgKnNrYikKIAogCXNwaW5fbG9ja19pcnFzYXZlKCZxdWV1
ZS0+cnhfcXVldWUubG9jaywgZmxhZ3MpOwogCi0JaWYgKHNrYl9xdWV1ZV9l
bXB0eSgmcXVldWUtPnJ4X3F1ZXVlKSkKLQkJeGVudmlmX3VwZGF0ZV9uZWVk
ZWRfc2xvdHMocXVldWUsIHNrYik7Ci0KLQlfX3NrYl9xdWV1ZV90YWlsKCZx
dWV1ZS0+cnhfcXVldWUsIHNrYik7Ci0KLQlxdWV1ZS0+cnhfcXVldWVfbGVu
ICs9IHNrYi0+bGVuOwotCWlmIChxdWV1ZS0+cnhfcXVldWVfbGVuID4gcXVl
dWUtPnJ4X3F1ZXVlX21heCkgeworCWlmIChxdWV1ZS0+cnhfcXVldWVfbGVu
ID49IHF1ZXVlLT5yeF9xdWV1ZV9tYXgpIHsKIAkJc3RydWN0IG5ldF9kZXZp
Y2UgKmRldiA9IHF1ZXVlLT52aWYtPmRldjsKIAogCQluZXRpZl90eF9zdG9w
X3F1ZXVlKG5ldGRldl9nZXRfdHhfcXVldWUoZGV2LCBxdWV1ZS0+aWQpKTsK
KwkJa2ZyZWVfc2tiKHNrYik7CisJCXF1ZXVlLT52aWYtPmRldi0+c3RhdHMu
cnhfZHJvcHBlZCsrOworCX0gZWxzZSB7CisJCWlmIChza2JfcXVldWVfZW1w
dHkoJnF1ZXVlLT5yeF9xdWV1ZSkpCisJCQl4ZW52aWZfdXBkYXRlX25lZWRl
ZF9zbG90cyhxdWV1ZSwgc2tiKTsKKworCQlfX3NrYl9xdWV1ZV90YWlsKCZx
dWV1ZS0+cnhfcXVldWUsIHNrYik7CisKKwkJcXVldWUtPnJ4X3F1ZXVlX2xl
biArPSBza2ItPmxlbjsKIAl9CiAKIAlzcGluX3VubG9ja19pcnFyZXN0b3Jl
KCZxdWV1ZS0+cnhfcXVldWUubG9jaywgZmxhZ3MpOwpAQCAtMTQ3LDYgKzE1
MCw3IEBAIHN0YXRpYyB2b2lkIHhlbnZpZl9yeF9xdWV1ZV9kcm9wX2V4cGly
ZWQoc3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpCiAJCQlicmVhazsKIAkJ
eGVudmlmX3J4X2RlcXVldWUocXVldWUpOwogCQlrZnJlZV9za2Ioc2tiKTsK
KwkJcXVldWUtPnZpZi0+ZGV2LT5zdGF0cy5yeF9kcm9wcGVkKys7CiAJfQog
fQogCi0tIAoyLjI2LjIKCg==

--=separator--


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:09:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:09:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249692.430118 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHTS-0007Bj-4R; Mon, 20 Dec 2021 12:09:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249692.430118; Mon, 20 Dec 2021 12:09:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHTS-0007Bc-1U; Mon, 20 Dec 2021 12:09:02 +0000
Received: by outflank-mailman (input) for mailman id 249692;
 Mon, 20 Dec 2021 12:09:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=IL3F=RF=xenbits.xen.org=julieng@srs-se1.protection.inumbo.net>)
 id 1mzHP5-0001n7-TM
 for xen-devel@lists.xen.org; Mon, 20 Dec 2021 12:04:32 +0000
Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id fbb55bba-618c-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 13:04:29 +0100 (CET)
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHOv-0003yB-SM; Mon, 20 Dec 2021 12:04:21 +0000
Received: from julieng by xenbits.xenproject.org with local (Exim 4.92)
 (envelope-from <julieng@xenbits.xen.org>)
 id 1mzHOv-0005Fc-RG; Mon, 20 Dec 2021 12:04:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fbb55bba-618c-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version:
	Content-Transfer-Encoding:Content-Type;
	bh=BOtpR7DrIJgh8IGhaIB9OInkz3uQZEba6oQe/UkxA5c=; b=0a7UZPGnpK3+cPCZ1MDGZNIONu
	dFsiIB0MUBQOax8OkYxTHDrSWB2jmsaaE85qnfoWeBFFijMaMUBP+2+6gK8zoPVj6mI+M76czKtPE
	s9qSzgcSiVERzE1nna4MTa/ashVlhEjECNy/KUMNax25IrdYj6N4bUVZbZNwNrd8Vmdc=;
Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8"
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
To: xen-announce@lists.xen.org, xen-devel@lists.xen.org,
 xen-users@lists.xen.org, oss-security@lists.openwall.com
From: Xen.org security team <security@xen.org>
CC: Xen.org security team <security-team-members@xen.org>
Subject: Xen Security Advisory 376 v1 - frontends vulnerable to backends
Message-Id: <E1mzHOv-0005Fc-RG@xenbits.xenproject.org>
Date: Mon, 20 Dec 2021 12:04:21 +0000

--=separator
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

                    Xen Security Advisory XSA-376

                   frontends vulnerable to backends

ISSUE DESCRIPTION
=================

Xen offers the ability to run PV backends in regular unprivileged
guests, typically referred to as "driver domains". Running PV backends
in driver domains has one primary security advantage: if a driver domain
gets compromised, it doesn't have the privileges to take over the
system.

However, a malicious driver domain could try to attack other guests via
the PV protocol. Many PV frontends are hardened against misbehaving PV
backends, but a few of them are not and might be susceptible to Denial
of Service attacks and metadata manipulation triggered by malicious PV
backends.

IMPACT
======

Potentially malicious PV backends can cause guest DoS due to unhardened
frontends in the guests, even though this ought to have been prevented by
containing them within a driver domain.

VULNERABLE SYSTEMS
==================

All guests with non-hardened frontends being serviced by potentially
malicious backends are vulnerable, even if those backends are running in a
less privileged environment. The vulnerability is not affecting the host,
but the guests using non-hardened frontends.

The console, block and net frontends have been hardened in the Linux kernel
5.16, so guests running Linux with kernel 5.16 or newer are not currently
known to be vulnerable to potentially malicious console, block or net
backends.

MITIGATION
==========

In case of running potentially malicious backends, using only hardened
frontend counterparts in guests will mitigate the problem.

NOTE REGARDING LACK OF EMBARGO
==============================

This issue was discussed in public already.

RESOLUTION
==========

The related patch is just a clarification of the security statement,
so it will NOT mitigate anything.

As there is no urgent need for this patch to go into the Xen tree it
will be posted on the xen-devel mailing list after disclosure of this
advisory.

xsa376.patch           xen-unstable

$ sha256sum xsa376*
b18551f7800d5a232bbe6953b1222ecb2c5a2058285c6fbc8d64f9b7dea2415f  xsa376.patch
$

-----BEGIN PGP SIGNATURE-----

iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmG8rFMMHHBncEB4ZW4u
b3JnAAoJEIP+FMlX6CvZSP4H/RcD4WLHi3TuSeNspsv/+dNb906LIueHFn/3U5Pg
5Jv8EHjv16apUhzgwTfTtx0pcCCDY2aEq0rdCziGpnTKiYzEarhTuVvc5igy9U0p
jqazRTyUkU1pV6HwFIGi/kHXTUpO60amWgKoFzyM9ZMl6WKDejb2rTu6TJC5FyiE
cxpe79GC98ECw8d131EfQgRx2/TIZuVQmKZlx3vVNG1lBlMZpFX2iioR7ajCQmdu
XWt14kDYdLvmZ1UzlrOH9+jhMRIyFZ1jBZXtXEUN0zSC+aTje6nPO3WSf/gXbmNF
COUrd7JPIMEO8PvnjzM3l1PS3XltIf2wTaVr5LjmkyBoMyM=
=J4gx
-----END PGP SIGNATURE-----

--=separator
Content-Type: application/octet-stream; name="xsa376.patch"
Content-Disposition: attachment; filename="xsa376.patch"
Content-Transfer-Encoding: base64

RnJvbSAwMmQzYTU3ZDY0NjYzNjNiMzE2YjYwZmZiYmE0MTRhNGEyY2I5MGM1
IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdWVyZ2VuIEdyb3Nz
IDxqZ3Jvc3NAc3VzZS5jb20+CkRhdGU6IFRodSwgMjUgTm92IDIwMjEgMTM6
Mzg6MjkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBTVVBQT1JULm1kOiBsaW1p
dCBzdXBwb3J0IHN0YXRlbWVudCBmb3IgTGludXggYW5kIFdpbmRvd3MKIGZy
b250ZW5kcwoKQ2hhbmdlIHRoZSBzdXBwb3J0IHN0YXRlIG9mIExpbnV4IGFu
ZCBXaW5kb3dzIHB2IGZyb250ZW5kcyBmcm9tCiJzdXBwb3J0ZWQiIHRvICJz
dXBwb3J0ZWQgd2l0aCBjYXZlYXRzIiBpbiBvcmRlciB0byByZWZsZWN0IHRo
YXQgdGhlCmZyb250ZW5kcyBjYW4gcHJvYmFibHkgYmUgaGFybWVkIGJ5IHRo
ZWlyIHJlc3BlY3RpdmUgYmFja2VuZHMuCgpTb21lIG9mIHRoZSBMaW51eCBm
cm9udGVuZHMgaGF2ZSBiZWVuIGhhcmRlbmVkIGFscmVhZHkuCgpUaGlzIGlz
IFhTQS0zNzYKClNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9z
c0BzdXNlLmNvbT4KLS0tCiBTVVBQT1JULm1kIHwgNTcgKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAx
IGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo
LSkKCmRpZmYgLS1naXQgYS9TVVBQT1JULm1kIGIvU1VQUE9SVC5tZAppbmRl
eCAzYTM0OTMzYzg5Li42ZTNlMzA1YjAxIDEwMDY0NAotLS0gYS9TVVBQT1JU
Lm1kCisrKyBiL1NVUFBPUlQubWQKQEAgLTQxMSw3ICs0MTEsMTEgQEAgR3Vl
c3Qtc2lkZSBkcml2ZXIgY2FwYWJsZSBvZiBzcGVha2luZyB0aGUgWGVuIFBW
IGJsb2NrIHByb3RvY29sCiAgICAgU3RhdHVzLCBGcmVlQlNEOiBTdXBwb3J0
ZWQsIFNlY3VyaXR5IHN1cHBvcnQgZXh0ZXJuYWwKICAgICBTdGF0dXMsIE5l
dEJTRDogU3VwcG9ydGVkLCBTZWN1cml0eSBzdXBwb3J0IGV4dGVybmFsCiAg
ICAgU3RhdHVzLCBPcGVuQlNEOiBTdXBwb3J0ZWQsIFNlY3VyaXR5IHN1cHBv
cnQgZXh0ZXJuYWwKLSAgICBTdGF0dXMsIFdpbmRvd3M6IFN1cHBvcnRlZAor
ICAgIFN0YXR1cywgV2luZG93czogU3VwcG9ydGVkLCB3aXRoIGNhdmVhdHMK
KworV2luZG93cyBmcm9udGVuZCBjdXJyZW50bHkgdHJ1c3RzIHRoZSBiYWNr
ZW5kOworYnVncyBpbiB0aGUgZnJvbnRlbmQgd2hpY2ggYWxsb3cgYmFja2Vu
ZCB0byBjYXVzZSBtaXNjaGllZiB3aWxsIG5vdCBiZQorY29uc2lkZXJlZCBz
ZWN1cml0eSB2dWxuZXJhYmlsaXRpZXMuCiAKICMjIyBOZXRmcm9udAogCkBA
IC00MjEsMjAgKzQyNSwzMiBAQCBHdWVzdC1zaWRlIGRyaXZlciBjYXBhYmxl
IG9mIHNwZWFraW5nIHRoZSBYZW4gUFYgbmV0d29ya2luZyBwcm90b2NvbAog
ICAgIFN0YXR1cywgRnJlZUJTRDogU3VwcG9ydGVkLCBTZWN1cml0eSBzdXBw
b3J0IGV4dGVybmFsCiAgICAgU3RhdHVzLCBOZXRCU0Q6IFN1cHBvcnRlZCwg
U2VjdXJpdHkgc3VwcG9ydCBleHRlcm5hbAogICAgIFN0YXR1cywgT3BlbkJT
RDogU3VwcG9ydGVkLCBTZWN1cml0eSBzdXBwb3J0IGV4dGVybmFsCi0gICAg
U3RhdHVzLCBXaW5kb3dzOiBTdXBwb3J0ZWQKKyAgICBTdGF0dXMsIFdpbmRv
d3M6IFN1cHBvcnRlZCwgd2l0aCBjYXZlYXRzCisKK1dpbmRvd3MgZnJvbnRl
bmQgY3VycmVudGx5IHRydXN0cyB0aGUgYmFja2VuZDsKK2J1Z3MgaW4gdGhl
IGZyb250ZW5kIHdoaWNoIGFsbG93IGJhY2tlbmQgdG8gY2F1c2UgbWlzY2hp
ZWYgd2lsbCBub3QgYmUKK2NvbnNpZGVyZWQgc2VjdXJpdHkgdnVsbmVyYWJp
bGl0aWVzLgogCiAjIyMgUFYgRnJhbWVidWZmZXIgKGZyb250ZW5kKQogCiBH
dWVzdC1zaWRlIGRyaXZlciBjYXBhYmxlIG9mIHNwZWFraW5nIHRoZSBYZW4g
UFYgRnJhbWVidWZmZXIgcHJvdG9jb2wKIAotICAgIFN0YXR1cywgTGludXgg
KHhlbi1mYmZyb250KTogU3VwcG9ydGVkCisgICAgU3RhdHVzLCBMaW51eCAo
eGVuLWZiZnJvbnQpOiBTdXBwb3J0ZWQsIHdpdGggY2F2ZWF0cworCitMaW51
eCBmcm9udGVuZCBjdXJyZW50bHkgdHJ1c3RzIHRoZSBiYWNrZW5kOworYnVn
cyBpbiB0aGUgZnJvbnRlbmQgd2hpY2ggYWxsb3cgYmFja2VuZCB0byBjYXVz
ZSBtaXNjaGllZiB3aWxsIG5vdCBiZQorY29uc2lkZXJlZCBzZWN1cml0eSB2
dWxuZXJhYmlsaXRpZXMuCiAKICMjIyBQViBkaXNwbGF5IChmcm9udGVuZCkK
IAogR3Vlc3Qtc2lkZSBkcml2ZXIgY2FwYWJsZSBvZiBzcGVha2luZyB0aGUg
WGVuIFBWIGRpc3BsYXkgcHJvdG9jb2wKIAotICAgIFN0YXR1cywgTGludXg6
IFN1cHBvcnRlZCAob3V0c2lkZSBvZiAiYmFja2VuZCBhbGxvY2F0aW9uIiBt
b2RlKQotICAgIFN0YXR1cywgTGludXg6IEV4cGVyaW1lbnRhbCAoaW4gImJh
Y2tlbmQgYWxsb2NhdGlvbiIgbW9kZSkKKyAgICBTdGF0dXMsIExpbnV4LCBv
dXRzaWRlIG9mICJiYWNrZW5kIGFsbG9jYXRpb24iIG1vZGU6IFN1cHBvcnRl
ZCwgd2l0aCBjYXZlYXRzCisgICAgU3RhdHVzLCBMaW51eCwgImJhY2tlbmQg
YWxsb2NhdGlvbiIgbW9kZTogRXhwZXJpbWVudGFsCisKK0xpbnV4IGZyb250
ZW5kIGN1cnJlbnRseSB0cnVzdHMgdGhlIGJhY2tlbmQ7CitidWdzIGluIHRo
ZSBmcm9udGVuZCB3aGljaCBhbGxvdyBiYWNrZW5kIHRvIGNhdXNlIG1pc2No
aWVmIHdpbGwgbm90IGJlCitjb25zaWRlcmVkIHNlY3VyaXR5IHZ1bG5lcmFi
aWxpdGllcy4KIAogIyMjIFBWIENvbnNvbGUgKGZyb250ZW5kKQogCkBAIC00
NDMsNyArNDU5LDExIEBAIEd1ZXN0LXNpZGUgZHJpdmVyIGNhcGFibGUgb2Yg
c3BlYWtpbmcgdGhlIFhlbiBQViBjb25zb2xlIHByb3RvY29sCiAgICAgU3Rh
dHVzLCBMaW51eCAoaHZjX3hlbik6IFN1cHBvcnRlZAogICAgIFN0YXR1cywg
RnJlZUJTRDogU3VwcG9ydGVkLCBTZWN1cml0eSBzdXBwb3J0IGV4dGVybmFs
CiAgICAgU3RhdHVzLCBOZXRCU0Q6IFN1cHBvcnRlZCwgU2VjdXJpdHkgc3Vw
cG9ydCBleHRlcm5hbAotICAgIFN0YXR1cywgV2luZG93czogU3VwcG9ydGVk
CisgICAgU3RhdHVzLCBXaW5kb3dzOiBTdXBwb3J0ZWQsIHdpdGggY2F2ZWF0
cworCitXaW5kb3dzIGZyb250ZW5kIGN1cnJlbnRseSB0cnVzdHMgdGhlIGJh
Y2tlbmQ7CitidWdzIGluIHRoZSBmcm9udGVuZCB3aGljaCBhbGxvdyBiYWNr
ZW5kIHRvIGNhdXNlIG1pc2NoaWVmIHdpbGwgbm90IGJlCitjb25zaWRlcmVk
IHNlY3VyaXR5IHZ1bG5lcmFiaWxpdGllcy4KIAogIyMjIFBWIGtleWJvYXJk
IChmcm9udGVuZCkKIApAQCAtNDUxLDExICs0NzEsMTkgQEAgR3Vlc3Qtc2lk
ZSBkcml2ZXIgY2FwYWJsZSBvZiBzcGVha2luZyB0aGUgWGVuIFBWIGtleWJv
YXJkIHByb3RvY29sLgogTm90ZSB0aGF0IHRoZSAia2V5Ym9hcmQgcHJvdG9j
b2wiIGluY2x1ZGVzIG1vdXNlIC8gcG9pbnRlciAvCiBtdWx0aS10b3VjaCBz
dXBwb3J0IGFzIHdlbGwuCiAKLSAgICBTdGF0dXMsIExpbnV4ICh4ZW4ta2Jk
ZnJvbnQpOiBTdXBwb3J0ZWQKKyAgICBTdGF0dXMsIExpbnV4ICh4ZW4ta2Jk
ZnJvbnQpOiBTdXBwb3J0ZWQsIHdpdGggY2F2ZWF0cworCitMaW51eCBmcm9u
dGVuZCBjdXJyZW50bHkgdHJ1c3RzIHRoZSBiYWNrZW5kOworYnVncyBpbiB0
aGUgZnJvbnRlbmQgd2hpY2ggYWxsb3cgYmFja2VuZCB0byBjYXVzZSBtaXNj
aGllZiB3aWxsIG5vdCBiZQorY29uc2lkZXJlZCBzZWN1cml0eSB2dWxuZXJh
YmlsaXRpZXMuCiAKICMjIyBQViBVU0IgKGZyb250ZW5kKQogCi0gICAgU3Rh
dHVzLCBMaW51eDogU3VwcG9ydGVkCisgICAgU3RhdHVzLCBMaW51eDogU3Vw
cG9ydGVkLCB3aXRoIGNhdmVhdHMKKworTGludXggZnJvbnRlbmQgY3VycmVu
dGx5IHRydXN0cyB0aGUgYmFja2VuZDsKK2J1Z3MgaW4gdGhlIGZyb250ZW5k
IHdoaWNoIGFsbG93IGJhY2tlbmQgdG8gY2F1c2UgbWlzY2hpZWYgd2lsbCBu
b3QgYmUKK2NvbnNpZGVyZWQgc2VjdXJpdHkgdnVsbmVyYWJpbGl0aWVzLgog
CiAjIyMgUFYgU0NTSSBwcm90b2NvbCAoZnJvbnRlbmQpCiAKQEAgLTQ2NCw2
ICs0OTIsMTAgQEAgbXVsdGktdG91Y2ggc3VwcG9ydCBhcyB3ZWxsLgogTkIg
dGhhdCB3aGlsZSB0aGUgUFYgU0NTSSBmcm9udGVuZCBpcyBpbiBMaW51eCBh
bmQgdGVzdGVkIHJlZ3VsYXJseSwKIHRoZXJlIGlzIGN1cnJlbnRseSBubyB4
bCBzdXBwb3J0LgogCitMaW51eCBmcm9udGVuZCBjdXJyZW50bHkgdHJ1c3Rz
IHRoZSBiYWNrZW5kOworYnVncyBpbiB0aGUgZnJvbnRlbmQgd2hpY2ggYWxs
b3cgYmFja2VuZCB0byBjYXVzZSBtaXNjaGllZiB3aWxsIG5vdCBiZQorY29u
c2lkZXJlZCBzZWN1cml0eSB2dWxuZXJhYmlsaXRpZXMuCisKICMjIyBQViBU
UE0gKGZyb250ZW5kKQogCiBHdWVzdC1zaWRlIGRyaXZlciBjYXBhYmxlIG9m
IHNwZWFraW5nIHRoZSBYZW4gUFYgVFBNIHByb3RvY29sCkBAIC00ODYsNyAr
NTE4LDExIEBAIEd1ZXN0LXNpZGUgZHJpdmVyIGNhcGFibGUgb2YgbWFraW5n
IHB2IHN5c3RlbSBjYWxscwogCiBHdWVzdC1zaWRlIGRyaXZlciBjYXBhYmxl
IG9mIHNwZWFraW5nIHRoZSBYZW4gUFYgc291bmQgcHJvdG9jb2wKIAotICAg
IFN0YXR1cywgTGludXg6IFN1cHBvcnRlZAorICAgIFN0YXR1cywgTGludXg6
IFN1cHBvcnRlZCwgd2l0aCBjYXZlYXRzCisKK0xpbnV4IGZyb250ZW5kIGN1
cnJlbnRseSB0cnVzdHMgdGhlIGJhY2tlbmQ7CitidWdzIGluIHRoZSBmcm9u
dGVuZCB3aGljaCBhbGxvdyBiYWNrZW5kIHRvIGNhdXNlIG1pc2NoaWVmIHdp
bGwgbm90IGJlCitjb25zaWRlcmVkIHNlY3VyaXR5IHZ1bG5lcmFiaWxpdGll
cy4KIAogIyMgVmlydHVhbCBkZXZpY2Ugc3VwcG9ydCwgaG9zdCBzaWRlCiAK
QEAgLTk4Nyw2ICsxMDIzLDkgQEAgYXJlIGdpdmVuIHRoZSBmb2xsb3dpbmcg
bGFiZWxzOgogCiAgICAgVGhpcyBmZWF0dXJlIGlzIHNlY3VyaXR5IHN1cHBv
cnRlZAogICAgIGJ5IGEgZGlmZmVyZW50IG9yZ2FuaXphdGlvbiAobm90IHRo
ZSBYZW5Qcm9qZWN0KS4KKyAgICBUaGUgZXh0ZW50IG9mIHN1cHBvcnQgaXMg
ZGVmaW5lZCBieSB0aGF0IG9yZ2FuaXphdGlvbi4KKyAgICBJdCBtaWdodCBi
ZSBsaW1pdGVkLCBlLmcuIGxpa2UgZGVzY3JpYmVkIGluICoqU3VwcG9ydGVk
LCB3aXRoIGNhdmVhdHMqKgorICAgIGJlbG93LgogICAgIFNlZSAqKkV4dGVy
bmFsIHNlY3VyaXR5IHN1cHBvcnQqKiBiZWxvdy4KIAogICAqICoqU3VwcG9y
dGVkLCB3aXRoIGNhdmVhdHMqKgotLSAKMi4yNi4yCgo=

--=separator--


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:21:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:21:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249768.430165 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHfM-00037S-2N; Mon, 20 Dec 2021 12:21:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249768.430165; Mon, 20 Dec 2021 12:21:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHfL-00037L-UR; Mon, 20 Dec 2021 12:21:19 +0000
Received: by outflank-mailman (input) for mailman id 249768;
 Mon, 20 Dec 2021 12:21:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hnIC=RF=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzHfK-00036x-02
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 12:21:18 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5293f1de-618f-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 13:21:15 +0100 (CET)
Received: from [10.10.1.134] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1640002868271788.2233964185755;
 Mon, 20 Dec 2021 04:21:08 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5293f1de-618f-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1640002870; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=KvkKmzjlL7Nt+WuCxmL3a4Be4e7FiZU5lcjEUB2F76oCOc4AfI4NxAijwWakFTmva0pnDRx+D5aa4JrhXx+3hn09X30WzyMKjVMKvrB+L8p+t5t8MNyUANJ9QqxtRi4SKDHcDN0WcojQCNOkme7ZF5Fc/NSpvwYUnIUFtC0kNTI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1640002870; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=6z3zVB4je1tfOCA8ftObRRWDwBZuTez9TiDYMdMrmfQ=; 
	b=G+YjL3kY4mWu72g9wf0iGJcNS3VDV1BzoAYd5PX8n4PhvpJNy38E4ISy0wo60za5bJKGBpxgtaxUp6pVnmO8GYi6IyFpfghCSbiLbPmmd6fqQHTkzkPe0gux0Nfk0l2zR/FIJwy8iCcZPnkHEi8ThI/T759l9FHSIaz+r5e9FWY=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640002870;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=6z3zVB4je1tfOCA8ftObRRWDwBZuTez9TiDYMdMrmfQ=;
	b=t/j04sJ7nid5+iRTZ3O8Z8w+TDvlN/vgRjKzc81fZXI/BZb3xc5Qpk+u8DWSPLsA
	aSk1BdV3A5pDO8JygRJf3OKhK5nT/d1GM1/CdfiPoMwF8bdjBscWMVCUrFotqfAKiJb
	5bk2uu9N8ez10A9RCa7HlIxMb6J9j+bz5Hek7DVM=
Subject: Re: [PATCH V2] is_system_domain: replace open-coded instances
To: Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
 Dario Faggioli <dfaggioli@suse.com>, Jan Beulich <jbeulich@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>
References: <20211220155013.28896-1-dpsmith@apertussolutions.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <f8637ace-43df-ffa6-5d6b-e8b4d70b74c9@apertussolutions.com>
Date: Mon, 20 Dec 2021 07:20:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211220155013.28896-1-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

Please disregard, I inadvertant picked up a couple of build artifacts. 
My sincere apologies on that, I will be resending shortly without them.

v/r
dps

On 12/20/21 10:50 AM, Daniel P. Smith wrote:
> From: Christopher Clark <christopher.w.clark@gmail.com>
> 
> This is a split out of the hyperlaunch dom0 series.
> 
> There were several instances of open-coded domid range checking. This commit
> replaces those with the is_system_domain or is_system_domid inline function.
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> Acked-by: Dario Faggioli <dfaggioli@suse.com>
> ---
>   xen/arch/x86/cpu/mcheck/mce.c     |   2 +-
>   xen/arch/x86/cpu/vpmu.c           |   2 +-
>   xen/common/domain.c               |   2 +-
>   xen/common/domctl.c               |   4 +-
>   xen/common/sched/core.c           |   4 +-
>   xen/include/asm-x86/asm-macros.h  |  86 ++++++++++++++++++++
>   xen/include/asm-x86/asm-offsets.h | 127 ++++++++++++++++++++++++++++++
>   xen/include/xen/sched.h           |   7 +-
>   8 files changed, 226 insertions(+), 8 deletions(-)
>   create mode 100644 xen/include/asm-x86/asm-macros.h
>   create mode 100644 xen/include/asm-x86/asm-offsets.h
> 
> diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
> index 7f433343bc..5c1df39075 100644
> --- a/xen/arch/x86/cpu/mcheck/mce.c
> +++ b/xen/arch/x86/cpu/mcheck/mce.c
> @@ -1518,7 +1518,7 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
>               d = rcu_lock_domain_by_any_id(mc_msrinject->mcinj_domid);
>               if ( d == NULL )
>               {
> -                if ( mc_msrinject->mcinj_domid >= DOMID_FIRST_RESERVED )
> +                if ( is_system_domid(mc_msrinject->mcinj_domid) )
>                       return x86_mcerr("do_mca inject: incompatible flag "
>                                        "MC_MSRINJ_F_GPADDR with domain %d",
>                                        -EINVAL, domid);
> diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
> index 8ec4547bed..c6bfa5a00e 100644
> --- a/xen/arch/x86/cpu/vpmu.c
> +++ b/xen/arch/x86/cpu/vpmu.c
> @@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
>        * in XENPMU_MODE_ALL, for everyone.
>        */
>       if ( (vpmu_mode & XENPMU_MODE_ALL) ||
> -         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
> +         is_system_domain(sampled->domain) )
>       {
>           sampling = choose_hwdom_vcpu();
>           if ( !sampling )
> diff --git a/xen/common/domain.c b/xen/common/domain.c
> index 093bb4403f..347cc073aa 100644
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -583,7 +583,7 @@ struct domain *domain_create(domid_t domid,
>       /* Sort out our idea of is_hardware_domain(). */
>       if ( domid == 0 || domid == hardware_domid )
>       {
> -        if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED )
> +        if ( hardware_domid < 0 || is_system_domid(hardware_domid) )
>               panic("The value of hardware_dom must be a valid domain ID\n");
>   
>           old_hwdom = hardware_domain;
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 879a2adcbe..a3ad1f62b6 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -52,7 +52,7 @@ static inline int is_free_domid(domid_t dom)
>   {
>       struct domain *d;
>   
> -    if ( dom >= DOMID_FIRST_RESERVED )
> +    if ( is_system_domid(dom) )
>           return 0;
>   
>       if ( (d = rcu_lock_domain_by_id(dom)) == NULL )
> @@ -536,7 +536,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>           if ( !d )
>           {
>               ret = -EINVAL;
> -            if ( op->domain >= DOMID_FIRST_RESERVED )
> +            if ( is_system_domid(op->domain) )
>                   break;
>   
>               rcu_read_lock(&domlist_read_lock);
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index 8f4b1ca10d..6ea8bcf62f 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -821,7 +821,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
>       int ret;
>   
>       ASSERT(d->cpupool == NULL);
> -    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
> +    ASSERT(!is_system_domain(d));
>   
>       if ( (ret = cpupool_add_domain(d, poolid)) )
>           return ret;
> @@ -845,7 +845,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
>   
>   void sched_destroy_domain(struct domain *d)
>   {
> -    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
> +    ASSERT(!is_system_domain(d));
>   
>       if ( d->cpupool )
>       {
> diff --git a/xen/include/asm-x86/asm-macros.h b/xen/include/asm-x86/asm-macros.h
> new file mode 100644
> index 0000000000..0c3d538b5c
> --- /dev/null
> +++ b/xen/include/asm-x86/asm-macros.h
> @@ -0,0 +1,86 @@
> +#if 0
> +.if 0
> +#endif
> +#ifndef __ASM_MACROS_H__
> +#define __ASM_MACROS_H__
> +asm ( ".include \"/home/build/projects/starlab/xen-private/xen/include/asm-x86/asm-macros.h\"" );
> +#endif /* __ASM_MACROS_H__ */
> +#if 0
> +.endif
> +.macro vmrun
> +    .byte 0x0f, 0x01, 0xd8
> +.endm
> +.macro stgi
> +    .byte 0x0f, 0x01, 0xdc
> +.endm
> +.macro clgi
> +    .byte 0x0f, 0x01, 0xdd
> +.endm
> +.macro INDIRECT_BRANCH insn:req arg:req
> +    .if 1 == 1
> +        $done = 0
> +        .irp reg, ax, cx, dx, bx, bp, si, di, 8, 9, 10, 11, 12, 13, 14, 15
> +        .ifeqs "\arg", "%r\reg"
> +            \insn __x86_indirect_thunk_r\reg
> +            $done = 1
> +           .exitm
> +        .endif
> +        .endr
> +        .if $done != 1
> +            .error "Bad register arg \arg"
> +        .endif
> +    .else
> +        \insn *\arg
> +    .endif
> +.endm
> +.macro INDIRECT_CALL arg:req
> +    INDIRECT_BRANCH call \arg
> +.endm
> +.macro INDIRECT_JMP arg:req
> +    INDIRECT_BRANCH jmp \arg
> +.endm
> +.macro guest_access_mask_ptr ptr:req, scratch1:req, scratch2:req
> +    mov $((((((256 >> 8) * 0xffff000000000000) | (256 << 39))) + (1 << 39)*16) - 1), \scratch1
> +    mov $~0, \scratch2
> +    cmp \ptr, \scratch1
> +    rcr $1, \scratch2
> +    and \scratch2, \ptr
> +.endm
> +.macro altinstruction_entry orig repl feature orig_len repl_len pad_len
> +    .long \orig - .
> +    .long \repl - .
> +    .word \feature
> +    .byte \orig_len
> +    .byte \repl_len
> +    .byte \pad_len
> +    .byte 0
> +.endm
> +.macro mknops nr_bytes
> +    .nops \nr_bytes, 9
> +.endm
> +.macro ALTERNATIVE oldinstr, newinstr, feature
> +    .L\@_orig_s: \oldinstr; .L\@_orig_e: .L\@_diff = (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_e - .L\@_orig_s); mknops ((-(.L\@_diff > 0)) * .L\@_diff); .L\@_orig_p:
> +    .pushsection .altinstructions, "a", @progbits
> +    altinstruction_entry .L\@_orig_s, .L\@_repl_s1, \feature, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()1 - .L\@_repl_s\()1), (.L\@_orig_p - .L\@_orig_e)
> +    .section .discard, "a", @progbits
> +    .byte (.L\@_orig_p - .L\@_orig_s)
> +    .byte 0xff + (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_p - .L\@_orig_s)
> +    .section .altinstr_replacement, "ax", @progbits
> +    .L\@_repl_s\()1: \newinstr; .L\@_repl_e\()1:
> +    .popsection
> +.endm
> +.macro ALTERNATIVE_2 oldinstr, newinstr1, feature1, newinstr2, feature2
> +    .L\@_orig_s: \oldinstr; .L\@_orig_e: .L\@_diff = (((.L\@_repl_e\()1 - .L\@_repl_s\()1)) ^ ((((.L\@_repl_e\()1 - .L\@_repl_s\()1)) ^ ((.L\@_repl_e\()2 - .L\@_repl_s\()2))) & -(-(((.L\@_repl_e\()1 - .L\@_repl_s\()1)) < ((.L\@_repl_e\()2 - .L\@_repl_s\()2)))))) - (.L\@_orig_e - .L\@_orig_s); mknops ((-(.L\@_diff > 0)) * .L\@_diff); .L\@_orig_p:
> +    .pushsection .altinstructions, "a", @progbits
> +    altinstruction_entry .L\@_orig_s, .L\@_repl_s1, \feature1, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()1 - .L\@_repl_s\()1), (.L\@_orig_p - .L\@_orig_e)
> +    altinstruction_entry .L\@_orig_s, .L\@_repl_s2, \feature2, (.L\@_orig_e - .L\@_orig_s), (.L\@_repl_e\()2 - .L\@_repl_s\()2), (.L\@_orig_p - .L\@_orig_e)
> +    .section .discard, "a", @progbits
> +    .byte (.L\@_orig_p - .L\@_orig_s)
> +    .byte 0xff + (.L\@_repl_e\()1 - .L\@_repl_s\()1) - (.L\@_orig_p - .L\@_orig_s)
> +    .byte 0xff + (.L\@_repl_e\()2 - .L\@_repl_s\()2) - (.L\@_orig_p - .L\@_orig_s)
> +    .section .altinstr_replacement, "ax", @progbits
> +    .L\@_repl_s\()1: \newinstr1; .L\@_repl_e\()1:
> +    .L\@_repl_s\()2: \newinstr2; .L\@_repl_e\()2:
> +    .popsection
> +.endm
> +#endif
> diff --git a/xen/include/asm-x86/asm-offsets.h b/xen/include/asm-x86/asm-offsets.h
> new file mode 100644
> index 0000000000..5eeced15ec
> --- /dev/null
> +++ b/xen/include/asm-x86/asm-offsets.h
> @@ -0,0 +1,127 @@
> +/*
> + * DO NOT MODIFY.
> + *
> + * This file was auto-generated from asm-offsets.s
> + *
> + */
> +
> +#ifndef __ASM_OFFSETS_H__
> +#define __ASM_OFFSETS_H__
> +
> +#define UREGS_r15 0 /* offsetof(struct cpu_user_regs, r15) */
> +#define UREGS_r14 8 /* offsetof(struct cpu_user_regs, r14) */
> +#define UREGS_r13 16 /* offsetof(struct cpu_user_regs, r13) */
> +#define UREGS_r12 24 /* offsetof(struct cpu_user_regs, r12) */
> +#define UREGS_rbp 32 /* offsetof(struct cpu_user_regs, rbp) */
> +#define UREGS_rbx 40 /* offsetof(struct cpu_user_regs, rbx) */
> +#define UREGS_r11 48 /* offsetof(struct cpu_user_regs, r11) */
> +#define UREGS_r10 56 /* offsetof(struct cpu_user_regs, r10) */
> +#define UREGS_r9 64 /* offsetof(struct cpu_user_regs, r9) */
> +#define UREGS_r8 72 /* offsetof(struct cpu_user_regs, r8) */
> +#define UREGS_rax 80 /* offsetof(struct cpu_user_regs, rax) */
> +#define UREGS_rcx 88 /* offsetof(struct cpu_user_regs, rcx) */
> +#define UREGS_rdx 96 /* offsetof(struct cpu_user_regs, rdx) */
> +#define UREGS_rsi 104 /* offsetof(struct cpu_user_regs, rsi) */
> +#define UREGS_rdi 112 /* offsetof(struct cpu_user_regs, rdi) */
> +#define UREGS_error_code 120 /* offsetof(struct cpu_user_regs, error_code) */
> +#define UREGS_entry_vector 124 /* offsetof(struct cpu_user_regs, entry_vector) */
> +#define UREGS_rip 128 /* offsetof(struct cpu_user_regs, rip) */
> +#define UREGS_cs 136 /* offsetof(struct cpu_user_regs, cs) */
> +#define UREGS_eflags 144 /* offsetof(struct cpu_user_regs, rflags) */
> +#define UREGS_rsp 152 /* offsetof(struct cpu_user_regs, rsp) */
> +#define UREGS_ss 160 /* offsetof(struct cpu_user_regs, ss) */
> +#define UREGS_kernel_sizeof 168 /* offsetof(struct cpu_user_regs, es) */
> +
> +#define VCPU_processor 4 /* offsetof(struct vcpu, processor) */
> +#define VCPU_domain 16 /* offsetof(struct vcpu, domain) */
> +#define VCPU_vcpu_info 8 /* offsetof(struct vcpu, vcpu_info) */
> +#define VCPU_trap_bounce 1456 /* offsetof(struct vcpu, arch.pv.trap_bounce) */
> +#define VCPU_thread_flags 896 /* offsetof(struct vcpu, arch.flags) */
> +#define VCPU_event_addr 1384 /* offsetof(struct vcpu, arch.pv.event_callback_eip) */
> +#define VCPU_event_sel 1400 /* offsetof(struct vcpu, arch.pv.event_callback_cs) */
> +#define VCPU_syscall_addr 1400 /* offsetof(struct vcpu, arch.pv.syscall_callback_eip) */
> +#define VCPU_syscall32_addr 1408 /* offsetof(struct vcpu, arch.pv.syscall32_callback_eip) */
> +#define VCPU_syscall32_sel 1424 /* offsetof(struct vcpu, arch.pv.syscall32_callback_cs) */
> +#define VCPU_syscall32_disables_events 1428 /* offsetof(struct vcpu, arch.pv.syscall32_disables_events) */
> +#define VCPU_sysenter_addr 1416 /* offsetof(struct vcpu, arch.pv.sysenter_callback_eip) */
> +#define VCPU_sysenter_sel 1426 /* offsetof(struct vcpu, arch.pv.sysenter_callback_cs) */
> +#define VCPU_sysenter_disables_events 1429 /* offsetof(struct vcpu, arch.pv.sysenter_disables_events) */
> +#define VCPU_trap_ctxt 1168 /* offsetof(struct vcpu, arch.pv.trap_ctxt) */
> +#define VCPU_kernel_sp 1312 /* offsetof(struct vcpu, arch.pv.kernel_sp) */
> +#define VCPU_kernel_ss 1304 /* offsetof(struct vcpu, arch.pv.kernel_ss) */
> +#define VCPU_iopl 1484 /* offsetof(struct vcpu, arch.pv.iopl) */
> +#define VCPU_guest_context_flags 1160 /* offsetof(struct vcpu, arch.pv.vgc_flags) */
> +#define VCPU_cr3 2856 /* offsetof(struct vcpu, arch.cr3) */
> +#define VCPU_arch_msrs 3416 /* offsetof(struct vcpu, arch.msrs) */
> +#define VCPU_nmi_pending 960 /* offsetof(struct vcpu, arch.async_exception_state[(1)-1].pending) */
> +#define VCPU_mce_pending 962 /* offsetof(struct vcpu, arch.async_exception_state[(2)-1].pending) */
> +#define VCPU_nmi_old_mask 961 /* offsetof(struct vcpu, arch.async_exception_state[(1)-1].old_mask) */
> +#define VCPU_mce_old_mask 963 /* offsetof(struct vcpu, arch.async_exception_state[(2)-1].old_mask) */
> +#define VCPU_async_exception_mask 964 /* offsetof(struct vcpu, arch.async_exception_mask) */
> +#define VCPU_TRAP_NMI 1 /* VCPU_TRAP_NMI */
> +#define VCPU_TRAP_MCE 2 /* VCPU_TRAP_MCE */
> +#define _VGCF_syscall_disables_events 4 /* _VGCF_syscall_disables_events */
> +
> +#define VCPU_svm_vmcb_pa 1480 /* offsetof(struct vcpu, arch.hvm.svm.vmcb_pa) */
> +#define VCPU_svm_vmcb 1472 /* offsetof(struct vcpu, arch.hvm.svm.vmcb) */
> +
> +#define VCPU_vmx_launched 1516 /* offsetof(struct vcpu, arch.hvm.vmx.launched) */
> +#define VCPU_vmx_realmode 1738 /* offsetof(struct vcpu, arch.hvm.vmx.vmx_realmode) */
> +#define VCPU_vmx_emulate 1739 /* offsetof(struct vcpu, arch.hvm.vmx.vmx_emulate) */
> +#define VCPU_vm86_seg_mask 1742 /* offsetof(struct vcpu, arch.hvm.vmx.vm86_segment_mask) */
> +#define VCPU_hvm_guest_cr2 1040 /* offsetof(struct vcpu, arch.hvm.guest_cr[2]) */
> +
> +#define VCPU_nhvm_guestmode 1960 /* offsetof(struct vcpu, arch.hvm.nvcpu.nv_guestmode) */
> +#define VCPU_nhvm_p2m 2192 /* offsetof(struct vcpu, arch.hvm.nvcpu.nv_p2m) */
> +#define VCPU_nsvm_hap_enabled 2148 /* offsetof(struct vcpu, arch.hvm.nvcpu.u.nsvm.ns_hap_enabled) */
> +
> +#define VCPUINFO_upcall_pending 0 /* offsetof(struct vcpu_info, evtchn_upcall_pending) */
> +#define VCPUINFO_upcall_mask 1 /* offsetof(struct vcpu_info, evtchn_upcall_mask) */
> +
> +#define CPUINFO_guest_cpu_user_regs 0 /* offsetof(struct cpu_info, guest_cpu_user_regs) */
> +#define CPUINFO_verw_sel 204 /* offsetof(struct cpu_info, verw_sel) */
> +#define CPUINFO_current_vcpu 208 /* offsetof(struct cpu_info, current_vcpu) */
> +#define CPUINFO_per_cpu_offset 216 /* offsetof(struct cpu_info, per_cpu_offset) */
> +#define CPUINFO_cr4 224 /* offsetof(struct cpu_info, cr4) */
> +#define CPUINFO_xen_cr3 232 /* offsetof(struct cpu_info, xen_cr3) */
> +#define CPUINFO_pv_cr3 240 /* offsetof(struct cpu_info, pv_cr3) */
> +#define CPUINFO_shadow_spec_ctrl 248 /* offsetof(struct cpu_info, shadow_spec_ctrl) */
> +#define CPUINFO_xen_spec_ctrl 252 /* offsetof(struct cpu_info, xen_spec_ctrl) */
> +#define CPUINFO_spec_ctrl_flags 253 /* offsetof(struct cpu_info, spec_ctrl_flags) */
> +#define CPUINFO_root_pgt_changed 254 /* offsetof(struct cpu_info, root_pgt_changed) */
> +#define CPUINFO_use_pv_cr3 255 /* offsetof(struct cpu_info, use_pv_cr3) */
> +#define CPUINFO_sizeof 264 /* sizeof(struct cpu_info) */
> +
> +#define TRAPINFO_eip 8 /* offsetof(struct trap_info, address) */
> +#define TRAPINFO_cs 2 /* offsetof(struct trap_info, cs) */
> +#define TRAPINFO_flags 1 /* offsetof(struct trap_info, flags) */
> +#define TRAPINFO_sizeof 16 /* sizeof(struct trap_info) */
> +
> +#define TRAPBOUNCE_error_code 0 /* offsetof(struct trap_bounce, error_code) */
> +#define TRAPBOUNCE_flags 4 /* offsetof(struct trap_bounce, flags) */
> +#define TRAPBOUNCE_cs 6 /* offsetof(struct trap_bounce, cs) */
> +#define TRAPBOUNCE_eip 8 /* offsetof(struct trap_bounce, eip) */
> +
> +#define VCPUMSR_spec_ctrl_raw 0 /* offsetof(struct vcpu_msrs, spec_ctrl.raw) */
> +
> +#define IRQSTAT_shift 7 /* ilog2(sizeof(irq_cpustat_t)) */
> +#define IRQSTAT_softirq_pending 0 /* offsetof(irq_cpustat_t, __softirq_pending) */
> +
> +#define CPUINFO_features 12 /* offsetof(struct cpuinfo_x86, x86_capability) */
> +
> +#define MB_flags 0 /* offsetof(multiboot_info_t, flags) */
> +#define MB_cmdline 16 /* offsetof(multiboot_info_t, cmdline) */
> +#define MB_mem_lower 4 /* offsetof(multiboot_info_t, mem_lower) */
> +
> +#define MB2_fixed_sizeof 8 /* sizeof(multiboot2_fixed_t) */
> +#define MB2_fixed_total_size 0 /* offsetof(multiboot2_fixed_t, total_size) */
> +#define MB2_tag_type 0 /* offsetof(multiboot2_tag_t, type) */
> +#define MB2_tag_size 4 /* offsetof(multiboot2_tag_t, size) */
> +#define MB2_load_base_addr 8 /* offsetof(multiboot2_tag_load_base_addr_t, load_base_addr) */
> +#define MB2_mem_lower 8 /* offsetof(multiboot2_tag_basic_meminfo_t, mem_lower) */
> +#define MB2_efi64_st 8 /* offsetof(multiboot2_tag_efi64_t, pointer) */
> +#define MB2_efi64_ih 8 /* offsetof(multiboot2_tag_efi64_ih_t, pointer) */
> +
> +#define DOMAIN_vm_assist 544 /* offsetof(struct domain, vm_assist) */
> +
> +#endif
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 28146ee404..0df72baf2e 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
>   #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
>   #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
>   
> +static inline bool is_system_domid(domid_t id)
> +{
> +    return (id >= DOMID_FIRST_RESERVED);
> +}
> +
>   static inline bool is_system_domain(const struct domain *d)
>   {
> -    return d->domain_id >= DOMID_FIRST_RESERVED;
> +    return is_system_domid(d->domain_id);
>   }
>   
>   #define DOMAIN_DESTROYED (1u << 31) /* assumes atomic_t is >= 32 bits */
> 


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:23:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:23:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249774.430176 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHhD-0003q1-Ht; Mon, 20 Dec 2021 12:23:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249774.430176; Mon, 20 Dec 2021 12:23:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHhD-0003pu-Eu; Mon, 20 Dec 2021 12:23:15 +0000
Received: by outflank-mailman (input) for mailman id 249774;
 Mon, 20 Dec 2021 12:23:14 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzHhC-0003po-0O
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 12:23:14 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 99847ef8-618f-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 13:23:12 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 4F75A1F381;
 Mon, 20 Dec 2021 12:23:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AA2913B73;
 Mon, 20 Dec 2021 12:23:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id vTU6AbB1wGGcXgAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 12:23:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 99847ef8-618f-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640002992; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=YRYWL+pcD9RCGtbrKXaiFbyVniio1feA2fOKmPxZ3iY=;
	b=nQd2+JVoUWop9K8BDkEhZIiYLy5SauFYtCAtUsYTGRuKhza6fuKDAHcNcZTSA5lCYxd01P
	H7INbl5kLwTl1jlmRChW2c2xm4vPdCyeTKNEGSFB9KCGDm2d6xqFKQMmQSzK9W9KRjE72i
	ctOglbmxdK7DrFmsRqNaGg8zv/NJX2w=
From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>
Subject: [PATCH] SUPPORT.md: limit support statement for Linux and Windows frontends
Date: Mon, 20 Dec 2021 13:22:48 +0100
Message-Id: <20211220122248.18332-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Change the support state of Linux and Windows pv frontends from
"supported" to "supported with caveats" in order to reflect that the
frontends can probably be harmed by their respective backends.

Some of the Linux frontends have been hardened already.

This is XSA-376

Signed-off-by: Juergen Gross <jgross@suse.com>
---
As there is no immediate fix associated with this XSA it was decided
to send the patch modifying the support statement once again to
xen-devel before applying it, allowing the community to discuss the
modified support.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 SUPPORT.md | 57 +++++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 48 insertions(+), 9 deletions(-)

diff --git a/SUPPORT.md b/SUPPORT.md
index 3a1fd1ba39..32fb0aa8de 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -417,7 +417,11 @@ Guest-side driver capable of speaking the Xen PV block protocol
     Status, FreeBSD: Supported, Security support external
     Status, NetBSD: Supported, Security support external
     Status, OpenBSD: Supported, Security support external
-    Status, Windows: Supported
+    Status, Windows: Supported, with caveats
+
+Windows frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### Netfront
 
@@ -427,20 +431,32 @@ Guest-side driver capable of speaking the Xen PV networking protocol
     Status, FreeBSD: Supported, Security support external
     Status, NetBSD: Supported, Security support external
     Status, OpenBSD: Supported, Security support external
-    Status, Windows: Supported
+    Status, Windows: Supported, with caveats
+
+Windows frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV Framebuffer (frontend)
 
 Guest-side driver capable of speaking the Xen PV Framebuffer protocol
 
-    Status, Linux (xen-fbfront): Supported
+    Status, Linux (xen-fbfront): Supported, with caveats
+
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV display (frontend)
 
 Guest-side driver capable of speaking the Xen PV display protocol
 
-    Status, Linux: Supported (outside of "backend allocation" mode)
-    Status, Linux: Experimental (in "backend allocation" mode)
+    Status, Linux, outside of "backend allocation" mode: Supported, with caveats
+    Status, Linux, "backend allocation" mode: Experimental
+
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV Console (frontend)
 
@@ -449,7 +465,11 @@ Guest-side driver capable of speaking the Xen PV console protocol
     Status, Linux (hvc_xen): Supported
     Status, FreeBSD: Supported, Security support external
     Status, NetBSD: Supported, Security support external
-    Status, Windows: Supported
+    Status, Windows: Supported, with caveats
+
+Windows frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV keyboard (frontend)
 
@@ -457,11 +477,19 @@ Guest-side driver capable of speaking the Xen PV keyboard protocol.
 Note that the "keyboard protocol" includes mouse / pointer /
 multi-touch support as well.
 
-    Status, Linux (xen-kbdfront): Supported
+    Status, Linux (xen-kbdfront): Supported, with caveats
+
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV USB (frontend)
 
-    Status, Linux: Supported
+    Status, Linux: Supported, with caveats
+
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ### PV SCSI protocol (frontend)
 
@@ -470,6 +498,10 @@ multi-touch support as well.
 NB that while the PV SCSI frontend is in Linux and tested regularly,
 there is currently no xl support.
 
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
+
 ### PV TPM (frontend)
 
 Guest-side driver capable of speaking the Xen PV TPM protocol
@@ -492,7 +524,11 @@ Guest-side driver capable of making pv system calls
 
 Guest-side driver capable of speaking the Xen PV sound protocol
 
-    Status, Linux: Supported
+    Status, Linux: Supported, with caveats
+
+Linux frontend currently trusts the backend;
+bugs in the frontend which allow backend to cause mischief will not be
+considered security vulnerabilities.
 
 ## Virtual device support, host side
 
@@ -993,6 +1029,9 @@ are given the following labels:
 
     This feature is security supported
     by a different organization (not the XenProject).
+    The extent of support is defined by that organization.
+    It might be limited, e.g. like described in **Supported, with caveats**
+    below.
     See **External security support** below.
 
   * **Supported, with caveats**
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 12:26:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 12:26:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249782.430186 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHkE-0004WH-WD; Mon, 20 Dec 2021 12:26:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249782.430186; Mon, 20 Dec 2021 12:26:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzHkE-0004WA-TK; Mon, 20 Dec 2021 12:26:22 +0000
Received: by outflank-mailman (input) for mailman id 249782;
 Mon, 20 Dec 2021 12:26:21 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=hnIC=RF=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzHkD-0004W4-5u
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 12:26:21 +0000
Received: from sender3-of-o50.zoho.com (sender3-of-o50.zoho.com
 [136.143.184.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 084a1642-6190-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 13:26:19 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1640003174372547.9730149426596;
 Mon, 20 Dec 2021 04:26:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 084a1642-6190-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1640003175; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=h5QG/f6FdbGkDmCKZ9cgDGepgdD0ozJW+DayZ87UUIQkOSPdJlE/iFSue0lWcW7i833xY2mJ0Yk07AoeUy+H7GNzcGRJH8qsIYHagFyMG8NK11jA0qPdKdIOm94Hz62llKzhyJhRHVgmXbnR7GROEtBnFa2JWR1gfsL2lpdoeGE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1640003175; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=wfNf9AYcu5cI6Pjc5sAav3xuf03fkML/AM4sJnjWfjw=; 
	b=h2U3T+c73OdaoinCFA912h8jiTE6DY7zX504FmMVT5ACrWWwu5csohZHTnK4s/JsG8iATMr8+9VxccdXRHPkJg1p5SgDmld8WVt3AZHRXrxnpz5WRRi/2+/wyqvt7NQUZMeriR+/C6w2YHupeqHmgK/c1u6WAbbhwZXlb4U4EXs=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640003175;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding;
	bh=wfNf9AYcu5cI6Pjc5sAav3xuf03fkML/AM4sJnjWfjw=;
	b=jJwIHg71GPmaPho4yfVmktUy4rEW1FWzbhRo1NRdKNPyR1x6w8gLx7u+mYW+LMIS
	z1D4BFZA0sYHP4Y2nXaDvLVR9Cp53ha9EBJGZAoFO1Z6QUrEhdds8SUBQc0PQuKwf4M
	PY3z67QtuDFCG7irCwaYj2d6VUgfT7RLFnlje+Ts=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v3] is_system_domain: replace open-coded instances
Date: Mon, 20 Dec 2021 11:28:53 -0500
Message-Id: <20211220162853.10603-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

From: Christopher Clark <christopher.w.clark@gmail.com>

This is a split out of the hyperlaunch dom0 series.

There were several instances of open-coded domid range checking. This commit
replaces those with the is_system_domain or is_system_domid inline function.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
---
 xen/arch/x86/cpu/mcheck/mce.c | 2 +-
 xen/arch/x86/cpu/vpmu.c       | 2 +-
 xen/common/domain.c           | 2 +-
 xen/common/domctl.c           | 4 ++--
 xen/common/sched/core.c       | 4 ++--
 xen/include/xen/sched.h       | 7 ++++++-
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 7f433343bc..5c1df39075 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1518,7 +1518,7 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
             d = rcu_lock_domain_by_any_id(mc_msrinject->mcinj_domid);
             if ( d == NULL )
             {
-                if ( mc_msrinject->mcinj_domid >= DOMID_FIRST_RESERVED )
+                if ( is_system_domid(mc_msrinject->mcinj_domid) )
                     return x86_mcerr("do_mca inject: incompatible flag "
                                      "MC_MSRINJ_F_GPADDR with domain %d",
                                      -EINVAL, domid);
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bed..c6bfa5a00e 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
      * in XENPMU_MODE_ALL, for everyone.
      */
     if ( (vpmu_mode & XENPMU_MODE_ALL) ||
-         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
+         is_system_domain(sampled->domain) )
     {
         sampling = choose_hwdom_vcpu();
         if ( !sampling )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 093bb4403f..347cc073aa 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -583,7 +583,7 @@ struct domain *domain_create(domid_t domid,
     /* Sort out our idea of is_hardware_domain(). */
     if ( domid == 0 || domid == hardware_domid )
     {
-        if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED )
+        if ( hardware_domid < 0 || is_system_domid(hardware_domid) )
             panic("The value of hardware_dom must be a valid domain ID\n");
 
         old_hwdom = hardware_domain;
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 879a2adcbe..a3ad1f62b6 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -52,7 +52,7 @@ static inline int is_free_domid(domid_t dom)
 {
     struct domain *d;
 
-    if ( dom >= DOMID_FIRST_RESERVED )
+    if ( is_system_domid(dom) )
         return 0;
 
     if ( (d = rcu_lock_domain_by_id(dom)) == NULL )
@@ -536,7 +536,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( !d )
         {
             ret = -EINVAL;
-            if ( op->domain >= DOMID_FIRST_RESERVED )
+            if ( is_system_domid(op->domain) )
                 break;
 
             rcu_read_lock(&domlist_read_lock);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..6ea8bcf62f 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -821,7 +821,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
     int ret;
 
     ASSERT(d->cpupool == NULL);
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( (ret = cpupool_add_domain(d, poolid)) )
         return ret;
@@ -845,7 +845,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
 
 void sched_destroy_domain(struct domain *d)
 {
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( d->cpupool )
     {
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 28146ee404..0df72baf2e 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
 #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
 #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
 
+static inline bool is_system_domid(domid_t id)
+{
+    return (id >= DOMID_FIRST_RESERVED);
+}
+
 static inline bool is_system_domain(const struct domain *d)
 {
-    return d->domain_id >= DOMID_FIRST_RESERVED;
+    return is_system_domid(d->domain_id);
 }
 
 #define DOMAIN_DESTROYED (1u << 31) /* assumes atomic_t is >= 32 bits */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 13:52:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 13:52:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249810.430197 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzJ5b-0005kV-AT; Mon, 20 Dec 2021 13:52:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249810.430197; Mon, 20 Dec 2021 13:52:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzJ5b-0005kO-7Y; Mon, 20 Dec 2021 13:52:31 +0000
Received: by outflank-mailman (input) for mailman id 249810;
 Mon, 20 Dec 2021 13:52:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rfhU=RF=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mzJ5Y-0005kI-Ho
 for xen-devel@lists.xen.org; Mon, 20 Dec 2021 13:52:29 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f126fda-619c-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 14:52:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f126fda-619c-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640008345;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=91cR3m/NxJYXyxZ1l2TtTmYuELnfSj6Nff2IWOSUKFU=;
  b=LT2sDJ0kWR4iCsUskoVNwGHNNuCBVTpJy+cN0CI82uTDg/JYM59Xe1wk
   NzvKBQQltPlN7h3MQq/FIYSHtofNuxIyHQs0TzQApgcWBFcWcIEkG8B6f
   EwBKyX96s8gS0elDm/d+A/7S7xmS3ifhsxJelaUClfzCnct5VkzeqUD6x
   c=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: v6J7V0aeymLCUi+aXGJM6GGy6qJXtzPIRDygLsUFLu0V+MXaHR3+gSkm5JxXPbqt8BBFWYpS2I
 VL6D4pL9bO2p1al7nTIPYNdR0qSDdW5oky2rqdkctSx+kYVW5o+u6XXD+hzS9QDwOz9IDpSJ3o
 gCIYdd8XYpyko2PyviWuoWUXW4WNsrYRZN45SIFULa7P+v7xy/9t+epJKm0iGUp8NUvYv0s4Eo
 1wxxa+by1a2f2zXbm4ejfEJUvZ5Nw2fpgUfl8O/BRv71pwNnG8h8CNgzjmqPvP6FptbpeVGb1W
 OI9GU7GCHGIJFEhv5zsESV7h
X-SBRS: 5.1
X-MesageID: 62505232
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VPGmlaBJ5RgWYBVW/+fkw5YqxClBgxIJ4kV8jS/XYbTApDIj0zUCx
 mtMWjyBaauCZ2qjeN1xYY61oRsFscSHndFiQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+EX5700o7wobVv6Yz6TSHK1LV0
 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5
 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/jBWMkO5w5
 s53iYWTagdyMvHWuf0gekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr
 KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf+XvYICh21YasZmLM/aR
 ZMAMWVVUBGcfiBRGFMSV70CpbL97pX4W2IB8w/EzUYt2EDDwQo03LXzPd79ft2RWd4Tjkue4
 GXc8AzRDBAAOdmS1TeC6FqxneLVhmXgX58IH7C28eRljRuVy3B7NfENfQLl+7/j0Bf4Ao8Bb
 RxPksYzkUQs3EuLS9bDXjOjmkKdnT0cANYMCcwj1SjYn8I4/D2lLmQDSzdAbvkvu8k3WSEm2
 ze1oj/5OdB8mObLECzAr994uRv3YHFIdjFaOUfoWCNcu4G7yLzfmC4jWTqK/ESdqtTuUQ/9z
 DmRxMTVr+VC1JVbv0lXEL2uvt5NmnQrZlNsjuk0djj8hu+cWGJCT9b3gWU3Fd4acO6koqCp5
 RDoYfS24uEUFo2qnyeQWugLF7zBz6/ba2yN2g8zQcd7pmvFF5ufkWd4um4WGauUGpxcJW+Bj
 LH75Gu9G6O/zFP1NPQqMupd+uwhzLT6FMSNaxwnRoEmX3SFTyfepHsGTRfJhwjFyRFw+Ylia
 cbzWZv9Vh4yVPU4pAdass9AiNfHMAhlnjiNLX06pjz6uYejiIm9Fe1YbQDQN79ht8tpYmz9q
 r5iCidD8D0GOMXWaSjL648Da1cMKHkwH5ftrMJLMOWEJ2Jb9KsJUae5LWoJd9M3kqJLuP3P+
 33hCEZUxECm3S/MKBmQa2AlY7TqBM4toXU+NC0qHFCpx3l8Ptr/sPZBL8M6Les96ehu7f9oV
 P1ZKc+ONetCF2bc8DMHYJij8IE7LEa3hRiDNjaOaSQke8IyXBTA/9LpJ1O99CQHAietm9E5p
 rmsilHSTZYZHlwwB8fKcvO/iVi2uCFFyu51WkLJJPhVeVntr9c2e3Cg0KdvLphVexvZxzac2
 wKHOjsipLHA890v7d3EpaGYtIP1QeFwKVVXQjvA5rGsOCiEomf6md1cUPyFdCz2XX/v/Pnwf
 v1cyvzxPaFVnFtOtIYgQb9nwbhnuonqrr5eiA9lAG/KfxKgDbY5eiuK2sxGt6tswL5FuFTpB
 hLTq4cCYbjZatn4FFMxJRY+arXR3P4ZrTDe8PApLRio/yRw5reGDR1fMhTkZPax91ep3FfJG
 dschfM=
IronPort-HdrOrdr: A9a23:r25Yga2RWN8KBpNRNOI5EQqjBVByeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79
 YcT0EcMqyPMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt5dBmxCe2Cm+yNNNW177c1TLu
 vh2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU
 z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P
 XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze
 Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA
 BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z
 W1Dk1frsA6ciYnV9MNOA4/e7rFNoXse2O7DIvAGyWvKEk4U0i92aIfpo9FoN2XRA==
X-IronPort-AV: E=Sophos;i="5.88,220,1635220800"; 
   d="scan'208";a="62505232"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=I1O817cJsLtGb2t9hvCnTh+e0EBKpeE361UN+H7ROPuEm1cuCq5XSp/1wgvKDFxW4mnJhycYHVJ3oqhbNcsIl05IQiB4BJCAcQ+VGtiMAEU1QNeJQSfdxW4pOzTUheePBtFcnakAXdugEcd/fxuF+x3Gu7icZVFbQDe/0/ky7p7pe2L/pBImJaNDgkjom2M9ettMiAn83gAQ4giVG1NQRD906KwgG629tijZ+iYRBHh/xoHpRoJTpbuFtPuYWIjlrt3dGNsqF/XEPvWGYaDhYiWMMMXgh6lutUymi/aX0qCAL6frKa+qfUf1BcEBzbQZB802KRgJxgZRUlyGK84p6g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mv0+3kzokXdmEQ/Fdh+QFho2JUgAqqg1nHlzm3hkPWg=;
 b=b9aUdgQ3MDe1OmOdjCRYEEyD4wd6oJy+keEhQrEvSielTIXbj6ERAPfy/k2FHlZdS0hebi+4rhJB8QeEHmFcIJGgp+uarlc2fJFU5D74zjZ/N76+RLcrAmDodJcsrdIaWEbjB7jLsotCssAFufVcYRDiDCtXypI2lWuWnnZ6nzYj82/gnas6xRi6fHst82mLfTeFuN9xR/UHt2CXUoUr5Z9AoreaEwSBzlRH/Kqx5rodWoGtV279Q4bmFH8j9PWtewaxrJVxzk4e4OvaUF4bOYIkoOh6xnFw7lJcUN+h6RLaSIFJafzaDCDgofgzuSaxZVDQApBsXVA1i3HvoeCZ5w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=mv0+3kzokXdmEQ/Fdh+QFho2JUgAqqg1nHlzm3hkPWg=;
 b=CXkFR0ecy7SaYsZK6qEyaUpDzD4SsbzWImFh7waGeunNugk7vfytLNiIiTuPhbacYoNLElbR+Lm4Kz484OS8Mqf4C5YjWRtDF7gsYS7KkNpl5zu1Su1rFM4yAl455X9dTjh/uRNiLPxn0tChGh6CXWfvxyBSddI922F2Maz0F/Q=
Date: Mon, 20 Dec 2021 14:51:59 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcCKfx4YivB4U0FP@Air-de-Roger>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
X-ClientProxiedBy: MR1P264CA0015.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::20) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71f9a257-3629-4c68-93c1-08d9c3bfe752
X-MS-TrafficTypeDiagnostic: DM6PR03MB3915:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB39154A654A7B882E77464DCF8F7B9@DM6PR03MB3915.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: C+t4Qxn7h0rltQWwChQ5mKoPSTq7fUfCcaXvBN2yb6UhZV8SI0qPVVEhjp+1HAk6rhMRVibbYvt6SFkq1yOyGv5SjBoUfhCIM/Pz8e1W28X5i+RlF1hS5ccMVAJHmOShwy5ast6Fji3PMo1u7f9DlEUzrVM1E04WpSGaql3aAVbBZuE9y20WrBUkmi4J5c3kg3opy2ILk1DNhlZkEHYHXEO26yXubF5beuF5PtcF4SosXkxhOIw1xCJudwC1bVlBpgMXgO4woSpz+e62eO6AkWC7cvFGQJyXnUsOCE5SjN/jzG/kyubzLUv5GNSCN+c/MJEiIkYmOgk6wXS0xRHAzvXwcTVIe00u865F1/x4RJKPFR7l7QHtoYZRXMk9R71uNjCLlESZQihmF1IT7ye5EJeqPk3sS1CorISJTzj3msqfYJTiHhVnJP8scojDAV8DVVUT1q/HR3MgSkh1FBWaa406V1CNdtdNYOwfiiy9AUsTFdrHMk4EsNCGCk4F0uDPlfvb+CHLXQrOd/dQaCGEqtYIkbklDbqz27ev+8icuWukMgTCuabY/0ftWojy2/mJPkyXj69dnmsJgRy8Y/Db4YfDucPpbiv1wUFFTQj4CZ/5e7x0oBRPven9ooQ27v1yopuyuvZ/XUx4oHDKPSIc/Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(4326008)(82960400001)(9686003)(6512007)(508600001)(5660300002)(26005)(85182001)(86362001)(83380400001)(6666004)(8676002)(8936002)(6916009)(316002)(2906002)(66476007)(6486002)(66556008)(66946007)(6506007)(33716001)(38100700002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnQyZDh2TXJpYlMwMFpFZmFrUEtSaGZ6QXBxZk0zT1QzN1NUUlVxd2ZDOWxQ?=
 =?utf-8?B?YWRYdTFPSEYrbktkaHNYSStFVENvL0pSZ0syWDZkYlQ1dVZ6RE5WY1FTSWpn?=
 =?utf-8?B?UDJSZ2ZtVGladktNTVlxMWhrNy9sUHpOQTNEcU5NTDFPbjNxdVM2NEdCQ0FP?=
 =?utf-8?B?dUdzWm1iQXp2aEZCbGpoUUxWRU5EUVdhRmVnL3lOQmJrR0ZTWG9VeUZnN3BM?=
 =?utf-8?B?UnVEMTh6MHZEaXpRaWd6Vm9maGp3c3ZCQUc4WFBVVnM3Z2lvbHlDeVgrMEM5?=
 =?utf-8?B?dS9MNE5vUVRVSThSR2FtZ0trUmZUL2ZHdUlVMVpVclRDcnhpd3pLZFNOcC8z?=
 =?utf-8?B?d3VsL0VLNTV4N0N2ZUhFekhqS1JxZFJEcWZWeUhxaEdvMk5DTVVUWitUM2tx?=
 =?utf-8?B?TWQ5VlFGSk9CZGY2L25ic093Y01iU2RReUNxMCtFaXhTTkI3RGZYeHMrTCtI?=
 =?utf-8?B?M0NRaTVXRWhnQlA0amt5OWZWZlk0N1VreVNKVlgyUlNXSXpmMHkzSlBlWHN2?=
 =?utf-8?B?aHFsWGlpb080ZFgvUGpRajlaUzEwUnRMZmFsaTJpa3BlWlhDOUVQbGxZWUpB?=
 =?utf-8?B?QXhQRVA4N3VldEdKV0VTNlQrbFVFSi83N3l3UlBWbkk2Umo1WlFGVVo0TEgy?=
 =?utf-8?B?K2RLL3RpMHhpbGwxaE9ZdndCWGlxNzNIeHdHZ1B0QVhqeDlibG5LYXVPdFBv?=
 =?utf-8?B?RzVtVzF6QlVlcW5DQ0FKaTU2ZEhpUkd3QXZVV1VBcC90MFMxaXdKd3VGWHVr?=
 =?utf-8?B?ZnBlb1RGTm5ISzhhUXFuMWlOaW5yVGhCZjYxaTY2S0NjYWlaNUdVVk9yYXZM?=
 =?utf-8?B?SmhqVXE2bXBGSysvSmhDcFlOeWkrblJ2bGsvdVBoRFc2elVqOU5vbWp5YVJQ?=
 =?utf-8?B?UU1LQUt5VGtjLzRZdlIzM3ZZU1JOTHNHVWhpTlA1NWpuTTU3OGYvdkFFZUdz?=
 =?utf-8?B?QXdvNHFuN3gyMnM0K2VROTBqQ3c2Y0t2TkllK3V0VWpVcG5OSWkvMnpsRkRC?=
 =?utf-8?B?SW9OODhPTWJVWDR5TmlhNmtiL0NpS3hmYzFzK2FFVFhudDBXaUUzeSs5ZVQ4?=
 =?utf-8?B?ZklRQzJwc3QrSDRpMGllYm5RNXRQU3pDc1c5dHFLR3NiL1ErZ05CWlovV01a?=
 =?utf-8?B?V2VTUG1nVkd6V2ZRWWwvVFMyVGk4L3JFUjJTSm1reW5NZ3VuSitXQWFnNG1o?=
 =?utf-8?B?WFBTaU5zRUhYcEFPMzAyOWpjUmNtRG56TTdHSkN6bmpyZGVOZkdxNEQxbDJt?=
 =?utf-8?B?eVp5ME9wUWRaVE5FVXYzNi9PZHJDY09vQjdzVTVGNXltWU5sUThFSEM1QWJr?=
 =?utf-8?B?NGJJT3BPT0ZkT0lLTmVjM1JZRXY5WUQzdE5QVDZQT3IvaXZjM1BNZENrdVRx?=
 =?utf-8?B?Z1VjeFg2M3dEYUk1OFlGbm5ncXFVM3AweFZORTVRKzg5bWhKTlU3Um9jbVEz?=
 =?utf-8?B?dmswTUd0ZS9qdG1PeExYcHkvN3ZsN3FNVHVqTHBnOGtEaGlSNDJsOThBTFVF?=
 =?utf-8?B?UVFKRGMrUC8wRVBxNXBLRFRLSHIrclI1aXNBckxhT1hnZExaSWhMdkZzUmY4?=
 =?utf-8?B?VHlmN0Z6Q1JBNnlnRlJGUThHM3l2THdsR0YxS0dmMEFUdk44b2RmTjZRYmRT?=
 =?utf-8?B?MEo1cFBuS2M1dzAycGUzeWt2elFQd3ZHM1JrMjhYeUkwbitoNm5JZG1PM1hs?=
 =?utf-8?B?b3k0SDhscnlsbDF2VHBYVHpyY2xLK1Q2YVFaN2pTdWtPQ29kcjRPMmVqMEhP?=
 =?utf-8?B?b2txd0oycFVEN2t3ZWhvUW4rOHdDUzRqcjFXbG8zUXF0UG8vcllwVmtZZnNH?=
 =?utf-8?B?OEpLUFVKNlVPd3JZVlkwVTV1bmZnY0FUOEgrZ1o1S1BoUk1ONnNEUnF0NkRr?=
 =?utf-8?B?QkpmWHFieENvRjg1K2pRT2d5Y0drcUFJd2xqUTJwNVpaZkp3cTdSS0tvWjBw?=
 =?utf-8?B?TTJoejZGUEdDSWhtT2VXRmFXbU1Cd1hEanU1bXhiTVRvakxZY0ZJZGM0SVR0?=
 =?utf-8?B?V0kvdVZMVytOTGJvTjg4Yk5xWTVvZHJQY3BiOU01SHZZSnF0bXhqamdXbEpI?=
 =?utf-8?B?VXhSMWxGUW5Deks5cGJjNFZwNjFoV2Z6YWJTNTJTTTlSSmRsbkNPZDBWeGJx?=
 =?utf-8?B?U1lQV1prenlyMFRVY2I3bzZKMW5Ia1Qrd3AxaEZ6dUVPOXdTeFU5WUIrMHZa?=
 =?utf-8?Q?ZA3KS9JFzPdkYTKP/Jvzotw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71f9a257-3629-4c68-93c1-08d9c3bfe752
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 13:52:03.9253
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ovug9emfI4p36gRcVLGGUBW8+ZWmEZwOSJOiGOFhuM6hBFy6Dcpf1mUmyKHHY5X+ECHoWYS/tuDO7e1RmYIb4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3915
X-OriginatorOrg: citrix.com

On Sun, Dec 19, 2021 at 02:35:56AM +0800, G.R. wrote:
> Hi all,
> 
> I ran into the following error report in the DOM0 kernel after a recent upgrade:
> [  501.840816] vif vif-1-0 vif1.0: Cross page boundary, txp->offset:
> 2872, size: 1460
> [  501.840828] vif vif-1-0 vif1.0: fatal error; disabling device
> [  501.841076] xenbr0: port 2(vif1.0) entered disabled state
> Once this error happens, the DOM-U behind this vif is no-longer
> accessible. And recreating the same DOM-U does not fix the problem.
> Only a reboot on the physical host machine helps.
> 
> The problem showed up after a recent upgrade on the DOM-U OS from
> FreeNAS 11.3 to TrueNAS 12.0U7 and breaks the iSCSI service while
> leaving other services like NFS intact.
> The underlying OS for the NAS is FreeBSD, version 11.3 and 12.2 respectively.
> So far I have tried the following combos:
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 11.3 DOM-U: Good
> - Linux 4.19 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.8 + FreeBSD 12.2 DOM-U: Regressed
> - Linux 5.10 DOM0 + XEN 4.11 + FreeBSD 12.2 DOM-U: Regressed
> 
> I plan to try out the XEN 4.14 version which is the latest I can get
> from the distro (Debian).
> If that still does not fix the problem, I would build the 4.16 version
> from source as my last resort.
> 
> I have to admit that this trial process is blind as I have no idea
> which component in the combo is to be blamed. Is it a bug in the
> backend-driver, frontend-driver or the hypervisor itself? Or due to
> incompatible versions? Any suggestion on other diagnose ideas (e.g.
> debug logs) will be welcome, while I work on the planned experiments.

This is a bug in FreeBSD netfront, so no matter which Linux or Xen
version you use.

Does it make a difference if you disable TSO and LRO from netfront?

$ ifconfig xn0 -tso -lro

Do you have instructions I can follow in order to try to reproduce the
issue?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 13:55:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 13:55:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249815.430209 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzJ8m-0006PL-SP; Mon, 20 Dec 2021 13:55:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249815.430209; Mon, 20 Dec 2021 13:55:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzJ8m-0006PE-PA; Mon, 20 Dec 2021 13:55:48 +0000
Received: by outflank-mailman (input) for mailman id 249815;
 Mon, 20 Dec 2021 13:55:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzJ8l-0006P4-P4; Mon, 20 Dec 2021 13:55:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzJ8l-0005rY-MQ; Mon, 20 Dec 2021 13:55:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzJ8l-00071T-BL; Mon, 20 Dec 2021 13:55:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzJ8l-0005jT-An; Mon, 20 Dec 2021 13:55:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=MVKD/AjEd8ErMA0IGpTQCtmx/R5Blc8J1MO328jlnKk=; b=Ife+DJbDwG/OpAeZ0o8UQJFxRZ
	iPW2AraGJcJT2RoGSV1Rvs8QMTzBpBJbdoUEJsLkjvOXIMs/eujOlWwgvAcmGVVDNNiAKvO5Ci1jk
	tqe3rCrg/maDewKoLs6E4qNqmfFxAH+YKbjDzcuOEwz2Ve3oBA6lnob8d6MRn127r11I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167486-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167486: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a7904a538933c525096ca2ccde1e60d0ee62c08e
X-Osstest-Versions-That:
    linux=a76c3d035872bf390d2fd92d8e5badc5ee28b17d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 13:55:47 +0000

flight 167486 linux-linus real [real]
flight 167490 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167486/
http://logs.test-lab.xenproject.org/osstest/logs/167490/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167484

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      8 xen-boot            fail pass in 167490-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 167490 like 167484
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 167490 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167484
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167484
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167484
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167484
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167484
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                a7904a538933c525096ca2ccde1e60d0ee62c08e
baseline version:
 linux                a76c3d035872bf390d2fd92d8e5badc5ee28b17d

Last test of basis   167484  2021-12-19 20:40:59 Z    0 days
Testing same since   167486  2021-12-20 02:31:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jens Axboe <axboe@kernel.dk>
  Linus Torvalds <torvalds@linux-foundation.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Sean Christopherson <seanjc@google.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit a7904a538933c525096ca2ccde1e60d0ee62c08e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 14:14:33 2021 -0800

    Linux 5.16-rc6

commit f291e2d899d120880bfe8e0fa6fe22a97a54e054
Merge: 2da09da4ae5e 18c841e1f411
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 12:44:03 2021 -0800

    Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
    
    Pull kvm fixes from Paolo Bonzini:
     "Two small fixes, one of which was being worked around in selftests"
    
    * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
      KVM: x86: Retry page fault if MMU reload is pending and root has no sp
      KVM: selftests: vmx_pmu_msrs_test: Drop tests mangling guest visible CPUIDs
      KVM: x86: Drop guest CPUID check for host initiated writes to MSR_IA32_PERF_CAPABILITIES

commit 2da09da4ae5e1714606668bdb145806b0afe9c90
Merge: a76c3d035872 87959fa16cfb
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 12:38:53 2021 -0800

    Merge tag 'block-5.16-2021-12-19' of git://git.kernel.dk/linux-block
    
    Pull block revert from Jens Axboe:
     "It turns out that the fix for not hammering on the delayed work timer
      too much caused a performance regression for BFQ, so let's revert the
      change for now.
    
      I've got some ideas on how to fix it appropriately, but they should
      wait for 5.17"
    
    * tag 'block-5.16-2021-12-19' of git://git.kernel.dk/linux-block:
      Revert "block: reduce kblockd_mod_delayed_work_on() CPU consumption"

commit 18c841e1f4112d3fb742aca3429e84117fcb1e1c
Author: Sean Christopherson <seanjc@google.com>
Date:   Thu Dec 9 06:05:46 2021 +0000

    KVM: x86: Retry page fault if MMU reload is pending and root has no sp
    
    Play nice with a NULL shadow page when checking for an obsolete root in
    the page fault handler by flagging the page fault as stale if there's no
    shadow page associated with the root and KVM_REQ_MMU_RELOAD is pending.
    Invalidating memslots, which is the only case where _all_ roots need to
    be reloaded, requests all vCPUs to reload their MMUs while holding
    mmu_lock for lock.
    
    The "special" roots, e.g. pae_root when KVM uses PAE paging, are not
    backed by a shadow page.  Running with TDP disabled or with nested NPT
    explodes spectaculary due to dereferencing a NULL shadow page pointer.
    
    Skip the KVM_REQ_MMU_RELOAD check if there is a valid shadow page for the
    root.  Zapping shadow pages in response to guest activity, e.g. when the
    guest frees a PGD, can trigger KVM_REQ_MMU_RELOAD even if the current
    vCPU isn't using the affected root.  I.e. KVM_REQ_MMU_RELOAD can be seen
    with a completely valid root shadow page.  This is a bit of a moot point
    as KVM currently unloads all roots on KVM_REQ_MMU_RELOAD, but that will
    be cleaned up in the future.
    
    Fixes: a955cad84cda ("KVM: x86/mmu: Retry page fault if root is invalidated by memslot update")
    Cc: stable@vger.kernel.org
    Cc: Maxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    Message-Id: <20211209060552.2956723-2-seanjc@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 0b091a43d704997789c6d812b02167c8f5f9f061
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date:   Thu Dec 16 17:52:12 2021 +0100

    KVM: selftests: vmx_pmu_msrs_test: Drop tests mangling guest visible CPUIDs
    
    Host initiated writes to MSR_IA32_PERF_CAPABILITIES should not depend
    on guest visible CPUIDs and (incorrect) KVM logic implementing it is
    about to change. Also, KVM_SET_CPUID{,2} after KVM_RUN is now forbidden
    and causes test to fail.
    
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Fixes: feb627e8d6f6 ("KVM: x86: Forbid KVM_SET_CPUID{,2} after KVM_RUN")
    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Message-Id: <20211216165213.338923-2-vkuznets@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 1aa2abb33a419090c7c87d4ae842a6347078ee12
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date:   Thu Dec 16 17:52:13 2021 +0100

    KVM: x86: Drop guest CPUID check for host initiated writes to MSR_IA32_PERF_CAPABILITIES
    
    The ability to write to MSR_IA32_PERF_CAPABILITIES from the host should
    not depend on guest visible CPUID entries, even if just to allow
    creating/restoring guest MSRs and CPUIDs in any sequence.
    
    Fixes: 27461da31089 ("KVM: x86/pmu: Support full width counting")
    Suggested-by: Sean Christopherson <seanjc@google.com>
    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Message-Id: <20211216165213.338923-3-vkuznets@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 87959fa16cfbcf76245c11559db1940069621274
Author: Jens Axboe <axboe@kernel.dk>
Date:   Sun Dec 19 07:58:44 2021 -0700

    Revert "block: reduce kblockd_mod_delayed_work_on() CPU consumption"
    
    This reverts commit cb2ac2912a9ca7d3d26291c511939a41361d2d83.
    
    Alex and the kernel test robot report that this causes a significant
    performance regression with BFQ. I can reproduce that result, so let's
    revert this one as we're close to -rc6 and we there's no point in trying
    to rush a fix.
    
    Link: https://lore.kernel.org/linux-block/1639853092.524jxfaem2.none@localhost/
    Link: https://lore.kernel.org/lkml/20211219141852.GH14057@xsang-OptiPlex-9020/
    Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 15:26:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 15:26:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249837.430220 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzKYH-0007jM-I0; Mon, 20 Dec 2021 15:26:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249837.430220; Mon, 20 Dec 2021 15:26:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzKYH-0007jF-Ej; Mon, 20 Dec 2021 15:26:13 +0000
Received: by outflank-mailman (input) for mailman id 249837;
 Mon, 20 Dec 2021 15:26:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=rfhU=RF=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mzKYG-0007j9-4q
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 15:26:12 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 226bda90-61a9-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 16:26:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 226bda90-61a9-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640013962;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=AAiWOlqSj02Wk513cGcuIKrmLzCaM/a1oKkBNjD359w=;
  b=IohGtJDLYZglf2CuQoytSYrdUkiI6d1r62l0hSkdhgx0DppkSfXQnPJq
   S6vTQqX9AzSkUVVj7xypkRVdZPcv2aRCaYa25asNIrS5855jF3vkEaG1j
   HwaQG/+poTIzLXfc6imhmOyZxpvLWrKuMnoz8n2kFIo/GnMzLAhBDuMkV
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 2QWbXfMpdHUxY5OH6WOhiwhtmRCtG2+XBb+5HNbwGe3JLLEt9XoMaHYTba7QFJEnSu05N777FG
 u/oIkDZTVKCWp7ISMbr/OOAbEdXPCPz0mkOWJhbywqM+eNWVs9iDMPtxpKxOgMR6/Ddd1Dy4p0
 hFMOrO90GNxK38SfEYEt4bNGrcJGHYfgKS/qVRA9W2uiUfwSbcoNqa9oGlIXYFOqr8ENO0N5a7
 5RHCDOIuimYxi5xyT7U7p8V8pWo/Rg8H6zV6XDSuGI4rqSLkQjdVHWnDhbTRzK6uxDsz8WffMO
 SI1r6nS6pwp/rFU+mpGVLEB/
X-SBRS: 5.1
X-MesageID: 60823926
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:SyKIF6soV/mmgMfbIYseTHq9eufnVI5ZMUV32f8akzHdYApBsoF/q
 tZmKWuEPPnbZmWnfdwjYIW28k9SvpLTmtdkSwtk/C43RSsT+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24DhWmthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplmK2sZ1o1ZY72yOE2agUBNQYgO6FU0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JgeR62PP
 ZRxhTxHTQ/ueT9IBmouK4sgvc6smmu8UgVKkQfAzUYwyzeKl1EguFT3C/LNc8GObdVYmACfv
 G2u13v9KgEXMpqY0zXt2nCmi/LLnCj7cJkPD7D+/flv6HWDy2pWBBAIWF+TpfiillX4S99ZM
 1YT+Cclse417kPDczXmd0Tm+jje5EdaAocOVb1hgO2Q9kbKyyuoGkZZUmViUowjn/YqHBoNi
 FmFjfq8UFSDr4apYX6a876Vqxa7Ni4UMXIOaEc4cOcV3zXwiNpt10ySF76PBIbw14SoQm+on
 1hmuQBn3+1L5fPnwZlX6rwub9iEgpHSBjA46QzMNo5OxlMoPdX1D2BEBLWy0BqhEGp7ZgTY1
 JTns5LHhAzrMX1qvHbSKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aIm64O
 x6P510LtcA70J6WgUhfOd3ZNijX5fK4SYSNug78M7KinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWPnOKrNVNdA9SdhDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+
 X+hHERfzTLCabfvc1zihqlLZOy9UJBhg2g8OCBwb1+k12J6OdSk7bsFdotxdr4irbQxwflxR
 vgDWsOBHvUQFWiXp2VDNcHw/N54aRCmpQOSJC75MjIxSIFtGl7S8dj+cwqxqCRXVnirtdEzq
 qGL3x/ARcZRXBxrCcvbMar9z164sXUHtvh1Wk/EfotadEn2qdA4IC3tlP4nZcoLLEyblDed0
 g+XBzYepPXM/NBpoIWY2/jcot7wQeVkH0dcE23K1pqMNHHXrji53ItNcOeUZjSBBmn6z7qvO
 LdOxPbmPfxZwFsT69hgE6xmxL4V7sf0o+MI1RxtGXjGYgj5Cr5kJXXaj8BDurcUm+1csAqyH
 EmO5sNbKfOCP8a8SAwdIw8sb+Ki0/AIm2aNsaRpcRuivCInrqCaVUhyPgWXjH0PJbR4B4op3
 OM9tZNE8Ae4kBcrbo6Lgy08G75g9ZDcv3HLbq0nPbI=
IronPort-HdrOrdr: A9a23:Ws6C9KAKyWWun03lHeg2sceALOsnbusQ8zAXPh9KJyC9I/b2qy
 nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ
 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M
 323Ls4m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU
 H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P
 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16
 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp
 ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w
 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
X-IronPort-AV: E=Sophos;i="5.88,220,1635220800"; 
   d="scan'208";a="60823926"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UBYCt+Ysv6wihteTRvi1qnA0mfuYel1dWnYr2+vWvJezeezkIbAdAMdn67Acj7TLUZbGyIbbDRJABzC6wF0WgwhikFStD1Gu2hdnuSbZVZBjBh+j+lfCgxgQVaZqiqSxXOtLefHmwAshqFA28eD4peTCch5ixHpT+hws4sXURlcxsOwFsowx2J5yCCK2Q9k4RlJhgroDSyIuHZZEwLvH/qgIVcThV+I49GBTQG3UVSOIBg7NSdeeRB2bKp09w3jitZXvjLxDZlZXxCScecwpyG6sWbqhDB6ouRE5zxfZDKh4TMBMAf5Hbt1n3tBW2B+D4znjavr1YdDylL0VbudbjA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=6r9yazLJ7J3E/Km7y/bxviJ5JNZbO7ImVN3JZKYD1PQ=;
 b=ABtRYRQwU80BXl6cfIO8laWhJO0OjeHPxSBcOhIJC+t7Q68IZRymlskfdW7EqX6K6JN9XJ41LJzja1jNEXCA+YseLbrhGYQfeeD2O/V1zRX4UEkog3rmloZqfZH53TMAMiayEhj5CEIetBTaSee7wK/8Hxx+oOhgf7LdXmcKY2/ZU8fk9eyKrzCkPtf84wyf9tm6X7uXr985s2mH4+X95IhEaJTyuBrek0WMRnl+G50yHrmTURNOkDX/er8Oe47QAguaj91nk8FVC2EkNhdldm2nMtY/c8/6TPIcCm2lS/joQCFa1PK/pAtucN44InVs3L5qmVqIjErjpBAnsAuD4g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=6r9yazLJ7J3E/Km7y/bxviJ5JNZbO7ImVN3JZKYD1PQ=;
 b=iz7QtJvYFJjQwaLbFM2AHKhpF1JUyBNWfJAm9uI1wk3Bchl6MEnzbjKgLT+8kTyULycwWtrHbJM6kxKYC3lQ84D/BQBxV6Z2j5h7F9NzHAO2NknN99/xmruIOXgVa2ZyYrCP1OF9gdiFyioTYFzGb4hDuQuUU1Io06o8dVIwbSs=
Date: Mon, 20 Dec 2021 16:25:11 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, "Andrew
 Cooper" <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH v2 16/18] x86: introduce helper for recording degree of
 contiguity in page tables
Message-ID: <YcCgV/o+1I0qry+q@Air-de-Roger>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <aab0b88b-7643-cc08-756b-0684f93be257@suse.com>
 <Ybn0LaRuFpUfcmoU@Air-de-Roger>
 <bbcbd938-170d-94dc-4fa3-49766fb2a9c3@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bbcbd938-170d-94dc-4fa3-49766fb2a9c3@suse.com>
X-ClientProxiedBy: MR2P264CA0100.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:33::16) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 34b6c63d-c0b0-4e28-823b-08d9c3ccecec
X-MS-TrafficTypeDiagnostic: DM6PR03MB3577:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB3577AEB7F361A91B3E78039D8F7B9@DM6PR03MB3577.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: o2ysqp0Ju4gvRqYb3+4EbNuiXw30QcY+Dzz2qYVRtyW537Qo+jvMus7FjNwwXh6OfqE47mu39acpJwHzQvo2iLCa/n7QPoOfpTot2nn7/YEEgXrgCxIpfAkfDgTfuUJtIwrSs++kUQiqVnIwo/oypuj1VQU4kll5AgSDech8yjyWy2jTBxNlXJiAwG9vwac3q/9wgzS0cCW0IQuvmfMkUbJ7/GyxRCduY8kwbpCe1LoNOOsX0vPB0yRKapadNGU/toLpH02yZKW65WqSDUjsK7wgdObgACzqzWI+GWdwtsLoJX+jkiz1AXOLwkZOIiu/JvZRXmYkBXtqNvDZiC1z0orzLNO8RTCTYdchFWNaGbxecNXS07OisYGoGoXUHNFk08bGlXkW4hhCYxNidCAeY7o08zQ/w5ZGI+Vrvy403KHMbPrK+jJjgFYDwhYJ8H+R1XBR5FyXxPROe+Y5fBlQ25znwTk5klQ/UmYbdWG2iHOWxYanSI+XmbuwK+Q9k49QSRJA3zxt+TAgJI3CbHp5+D/nlQj3RZBiK9o4CDUcg3vtUwlDRzk7XoByLJpvPERHxyhWndO5Tg4CuWxh91sBa+kOgzFvbc1mz2jXUn43M8VeCQNM7ACC+5HK6pFcFs0eY4EhXKJwQ5rzjtg/AWEO1w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(33716001)(83380400001)(5660300002)(6512007)(9686003)(6486002)(26005)(186003)(53546011)(508600001)(6506007)(8936002)(86362001)(82960400001)(8676002)(54906003)(316002)(2906002)(85182001)(66556008)(6666004)(66476007)(6916009)(66946007)(4326008)(38100700002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVNyT29xVEdPc0ljcGZZNDVXR25aTGcxK0tYSmRIa1IvK3ZiMDg5Snd0TFRs?=
 =?utf-8?B?V3E1bTNFMzh3cG1OMXYyVlFFTlB5RDVwTVRqYjltYlBKMzcveGNORld6YXBw?=
 =?utf-8?B?R1FRRWcrVWFjNzJ4N01iZzQ0di9FTW4xMFpWdjFydGdQOWU5R3NKZXQwWDJz?=
 =?utf-8?B?enE3M092bjVkQUdYVklxZi8wV0JUWVF6L0dINXFreXl0czAzM1NsZHYwWGFz?=
 =?utf-8?B?TjJTTloxV3kwSU5iWUh2WXMvbUJTK2x2L015UE1JM0JKUnlLRS9wdjFZajFJ?=
 =?utf-8?B?THc0TFdvNUw1VVVuMDVSUm9Ga0I2YkFkbGx5UFphZGo1bm1FOUcwc2ZUSFh2?=
 =?utf-8?B?eUlXRU1Mdkl0cCtPT3ZUYkNRRStGcnRQVy9tYy92S2tjSG11NkZLbHJGeXBi?=
 =?utf-8?B?TzBsN1hGVGVNTS8xTkJQKzRKMHNTa0U0bktYSHF6SGhEQ3lIb3N1WTZpMlh1?=
 =?utf-8?B?Nm4xL21sRDIxb2F6ZXgvVE4rMm42RTV2OU9QOTR2T3NHb3UwbEV3OHRFR25u?=
 =?utf-8?B?S3BZRWZ0dGtTcDJTM3FBM2ltUjU4dzgvc3plSWpxbVZUamQzUElpYmh5cCta?=
 =?utf-8?B?cjJtUVVlam43V3U5TGs4eFpQNlI1UjlxMWFJbWp4cHo3UHJ4WFJKTDlPRTY5?=
 =?utf-8?B?WkFJWTNBSGZuRVBZZGNQdk12Z2krd2pNZWh6MHkrU1NDOHBRb1MwNXB6enlm?=
 =?utf-8?B?QS90RWVieHMva2p5SUMxSnhrS0tFQ2pTeFJZUFVrdHB3OWdEbit6N21Xakht?=
 =?utf-8?B?RDlscW5HMUo2eXdqSkR4UkdzeVZCaFc4b0FGbXU3d3d5VXdQdXU2VG9KbWtk?=
 =?utf-8?B?aFlaOUhncnlycW9MZ3VLSnVlTWp6VG02S0NLRDBNZFhMMWpwYkNLdEU2clB5?=
 =?utf-8?B?bkl6WUoycjRhQ20rVUpwM0tLTWNIdWZPeWUySDhCZWRSSkVHZWpiNi8xblBo?=
 =?utf-8?B?TThra1ZYbHRqQVpaWlFmdnBNakQwTm1IVlZuc0lqZXBHSW9zUklsTytvYkFz?=
 =?utf-8?B?WmNvSjhwUFd6THRiNmc0N0E3VW9jbnJaSmFlNnRmTHJ3a0E2SHAwQVplc3A5?=
 =?utf-8?B?RTZjZHdKdnV5NHFnMVVoUjBPOUt0WnBWc3VMMERRemlrWlI5T1NMcG96MmNU?=
 =?utf-8?B?Q3lSYUczd0FacndvbGJGOFY3T0JhZ2xKeFY0Tjg1bngybmEyZE90MS9aNE5F?=
 =?utf-8?B?ZXBDQmxZYzFVeFkvV3NZQlRialFaU2htb0hZODRubTFpQmVhUFhoaW1YWVJJ?=
 =?utf-8?B?SjZ1SGowZXlnNldUcHVNUGl4YnNZVHBDZmE4aGVsWWp3YnlVZkYycTE3UTNV?=
 =?utf-8?B?b2RyTDRrRlNLRWlBRXRwaFo0NEIvUFdvUnpKY0hoUEhqeE9XMmpOVGJMN3RY?=
 =?utf-8?B?NE1mRlgwWW9Jb2p4TmVDbHhCU3FvLzFnQm42emFwbDdYUk10MUFPNmpGS3Ax?=
 =?utf-8?B?NDhmbHo1OWQ5U0E3YmZXbTR3UnozUldHL0o1NDhERng0akZlYmJTbkkzeFZm?=
 =?utf-8?B?ZnhnUVpDcXp3ZHlEMC9VNVpPM1o2S0lvc0x5SXRUbk5oS1FpNFAvZFB2SXU1?=
 =?utf-8?B?V2ZzbDRvRWppeHlnZTVEdXVtbEhHSDE5eUgyQmx5RTRnbnNNdDdaTGV0UDBp?=
 =?utf-8?B?dHVIVVBhYW5UYVZ4a3F3Q1JTaFdoWTFtZ2NaRGdxR2ptbUNUdmYwU2dqVlBp?=
 =?utf-8?B?YTl6eHhid1MxNW5IUXlxaTdCdCsyeUNzS2NtK0xud1MreDFGdFNXeG1iWUdV?=
 =?utf-8?B?RmFPcnlvd3dJOEhpaEZaMVpkYk5RbkRsVmVIczBsRWNWcHAzUzR3a0ozS1My?=
 =?utf-8?B?VG91ODFmNGlhYURIbnpjVlovcytZa1VIbG4wYmUrMDN6V2tyOFJadG1iWlFF?=
 =?utf-8?B?WVVSMnZ5SDZVaVduaFQzUTd1NjJvWEJiZVRWTEp1MXVRQTZmeE1jMEZRU2Z4?=
 =?utf-8?B?QUJONTMzRlFBS21HOUg0YlJ2MjNWdDRCT1NTeThLOXN2SU9XTWp4VHNvNnZ6?=
 =?utf-8?B?YlRkS3JvVFRycFN6OTlZazlUSFlLK3VzcTRNZ1N2Z1NNNGRSNnEweEpwZytr?=
 =?utf-8?B?VnhmVnYzSklyQTA2N1REWmg4MzhadlZySjJHZG40dFd1MGdxZHpWOThGYlAr?=
 =?utf-8?B?ajFER2h0VjZMUEhZOHZKRCtiZ1BTdWZMUUEzUXlHZjBld3VrcVlZb2s4NFEz?=
 =?utf-8?Q?w0K7bfN39sxzCc4NzfUXzBI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34b6c63d-c0b0-4e28-823b-08d9c3ccecec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2021 15:25:16.7802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RPheXbsSvNGUSSjFuuPtAuL2TcRmgU6iar+zxpx8Eej33w0x3vaz0C7hVvumppyEjU4zot2eb/tvbsZF8QvBvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB3577
X-OriginatorOrg: citrix.com

On Thu, Dec 16, 2021 at 04:47:30PM +0100, Jan Beulich wrote:
> On 15.12.2021 14:57, Roger Pau Monné wrote:
> > On Fri, Sep 24, 2021 at 11:55:30AM +0200, Jan Beulich wrote:
> >> --- /dev/null
> >> +++ b/xen/include/asm-x86/contig-marker.h
> >> @@ -0,0 +1,105 @@
> >> +#ifndef __ASM_X86_CONTIG_MARKER_H
> >> +#define __ASM_X86_CONTIG_MARKER_H
> >> +
> >> +/*
> >> + * Short of having function templates in C, the function defined below is
> >> + * intended to be used by multiple parties interested in recording the
> >> + * degree of contiguity in mappings by a single page table.
> >> + *
> >> + * Scheme: Every entry records the order of contiguous successive entries,
> >> + * up to the maximum order covered by that entry (which is the number of
> >> + * clear low bits in its index, with entry 0 being the exception using
> >> + * the base-2 logarithm of the number of entries in a single page table).
> >> + * While a few entries need touching upon update, knowing whether the
> >> + * table is fully contiguous (and can hence be replaced by a higher level
> >> + * leaf entry) is then possible by simply looking at entry 0's marker.
> >> + *
> >> + * Prereqs:
> >> + * - CONTIG_MASK needs to be #define-d, to a value having at least 4
> >> + *   contiguous bits (ignored by hardware), before including this file,
> >> + * - page tables to be passed here need to be initialized with correct
> >> + *   markers.
> > 
> > Given this requirement I think it would make sense to place the page
> > table marker initialization currently placed in iommu_alloc_pgtable as
> > a helper here also?
> 
> I would be nice, yes, but it would also cause problems. I specifically do
> not want to make the function here "inline". Hence a source file including
> it would need to be given a way to suppress its visibility to the compiler.
> Which would mean #ifdef-ary I'd prefer to avoid. Yet by saying "prefer" I
> mean to leave open that I could be talked into doing what you suggest.

Could you mark those as __maybe_unused? Or would you rather like to
assert that they are used when included?

> >> + */
> >> +
> >> +#include <xen/bitops.h>
> >> +#include <xen/lib.h>
> >> +#include <xen/page-size.h>
> >> +
> >> +/* This is the same for all anticipated users, so doesn't need passing in. */
> >> +#define CONTIG_LEVEL_SHIFT 9
> >> +#define CONTIG_NR          (1 << CONTIG_LEVEL_SHIFT)
> >> +
> >> +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK)
> >> +#define SET_MARKER(e, m) \
> >> +    ((void)(e = ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK)))
> >> +
> >> +enum PTE_kind {
> >> +    PTE_kind_null,
> >> +    PTE_kind_leaf,
> >> +    PTE_kind_table,
> >> +};
> >> +
> >> +static bool update_contig_markers(uint64_t *pt, unsigned int idx,
> > 
> > Maybe pt_update_contig_markers, so it's not such a generic name.
> 
> I can do that. The header may then want to be named pt-contig-marker.h
> or pt-contig-markers.h. Thoughts?

Seems fine to me.

> >> +                                  unsigned int level, enum PTE_kind kind)
> >> +{
> >> +    unsigned int b, i = idx;
> >> +    unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT;
> >> +
> >> +    ASSERT(idx < CONTIG_NR);
> >> +    ASSERT(!(pt[idx] & CONTIG_MASK));
> >> +
> >> +    /* Step 1: Reduce markers in lower numbered entries. */
> >> +    while ( i )
> >> +    {
> >> +        b = find_first_set_bit(i);
> >> +        i &= ~(1U << b);
> >> +        if ( GET_MARKER(pt[i]) > b )
> >> +            SET_MARKER(pt[i], b);
> >> +    }
> >> +
> >> +    /* An intermediate table is never contiguous with anything. */
> >> +    if ( kind == PTE_kind_table )
> >> +        return false;
> >> +
> >> +    /*
> >> +     * Present entries need in sync index and address to be a candidate
> >> +     * for being contiguous: What we're after is whether ultimately the
> >> +     * intermediate table can be replaced by a superpage.
> >> +     */
> >> +    if ( kind != PTE_kind_null &&
> >> +         idx != ((pt[idx] >> shift) & (CONTIG_NR - 1)) )
> > 
> > Don't you just need to check that the address is aligned to at least
> > idx, not that it's exactly aligned?
> 
> No, that wouldn't be sufficient. We're not after a general "is
> contiguous" here, but strictly after "is this slot meeting the
> requirements for the whole table eventually getting replaced by a
> superpage".

I see, makes sense. I didn't relate this check to the 'replaced by a
superpage' part of the comment.

> >> +        return false;
> >> +
> >> +    /* Step 2: Check higher numbered entries for contiguity. */
> >> +    for ( b = 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b )
> >> +    {
> >> +        i = idx | (1U << b);
> >> +        if ( (kind == PTE_kind_leaf
> >> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) != (1ULL << (b + shift))
> > 
> > Maybe this could be a macro, CHECK_CONTIG or some such? It's also used
> > below.
> 
> Hmm, yes, this might indeed help readability. There's going to be a
> lot of parameters though; not sure whether omitting all(?) parameters
> for such a locally used macro would be considered acceptable.
> 
> > I would also think this would be clearer as:
> > 
> > (pt[idx] & ~CONTIG_MASK) + (1ULL << (shift + b)) == (pt[i] & ~CONTIG_MASK)
> 
> By using + we'd consider entries contiguous which for our purposes
> shouldn't be considered so. Yes, the earlier check should already
> have caught that case, but I'd like the checks to be as tight as
> possible.
> 
> >> +              : pt[i] & ~CONTIG_MASK) ||
> > 
> > Isn't PTE_kind_null always supposed to be empty?
> 
> Yes (albeit this could be relaxed, but then the logic here would
> need to know where the "present" bit(s) is/are).
> 
> > (ie: wouldn't this check always succeed?)
> 
> No - "kind" describes pt[idx], not pt[i].
> 
> >> +             GET_MARKER(pt[i]) != b )
> >> +            break;
> >> +    }
> >> +
> >> +    /* Step 3: Update markers in this and lower numbered entries. */
> >> +    for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b )
> >> +    {
> >> +        i = idx ^ (1U << b);
> >> +        if ( (kind == PTE_kind_leaf
> >> +              ? ((pt[i] ^ pt[idx]) & ~CONTIG_MASK) != (1ULL << (b + shift))
> >> +              : pt[i] & ~CONTIG_MASK) ||
> >> +             GET_MARKER(pt[i]) != b )
> >> +            break;
> >> +        idx &= ~(1U << b);
> > 
> > There's an iteration where idx will be 0, and then there's no further
> > point in doing the & anymore?
> 
> Yes, but doing the & anyway is cheaper than adding a conditional.

I think it might be interesting to add some kind of unit testing to
this code in tools/tests. It's a standalone piece of code that could
be easily tested for correct functionality. Not that you should do it
here, in fact it might be interesting for me to do so in order to
better understand the code.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 15:42:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 15:42:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249844.430231 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzKnJ-0001sg-0y; Mon, 20 Dec 2021 15:41:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249844.430231; Mon, 20 Dec 2021 15:41:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzKnI-0001sZ-U8; Mon, 20 Dec 2021 15:41:44 +0000
Received: by outflank-mailman (input) for mailman id 249844;
 Mon, 20 Dec 2021 15:41:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CBxd=RF=epam.com=prvs=298802dd99=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mzKnH-0001sT-BG
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 15:41:43 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5301c3fc-61ab-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 16:41:41 +0100 (CET)
Received: from pps.filterd (m0174682.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BKEpO5K024258;
 Mon, 20 Dec 2021 15:41:30 GMT
Received: from eur01-db5-obe.outbound.protection.outlook.com
 (mail-db5eur01lp2053.outbound.protection.outlook.com [104.47.2.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d2uy2072t-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 20 Dec 2021 15:41:30 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR3PR03MB6571.eurprd03.prod.outlook.com (2603:10a6:102:7b::6) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 15:41:28 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.020; Mon, 20 Dec 2021
 15:41:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5301c3fc-61ab-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M7HvTTWPPFNuA/TaJXOqkwyNU9qsY2f/LmcYiSLbt4JJAea3o+y5KGOWULmm0i7QgJFryP6j4WOiMWJcm2iWGsqXvs+KqglgEQfoX6OqpFJP2XO1N8ivGbc83peYVnhL2qSySw5rv+Hw1CsaY62OqyvY7Rs4+1EW1ghYhqpifIUGcQQhzJxZJ4iTNh1KU3GeaHL3rEGan1KWLAzJy5qQYmBga45bAtvQMZAbzQhCjGYY71lJ68zzyxtuvF4NPclJZEADnYfevA1fiOVU2gCZki2GgH96fi1vJmV0snpH7aWOCF3DIbGxPjQ4rygIw3F6t2aUBNlyiiJPYLsxtJ2KRg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=q3BXmTVfE+kfGVHoYLtw7B2qCfY0BKvJ951kywdyNCA=;
 b=c9yhNGGtI/WYyz9yzleUVKNlaBdmzG3v1LxEbJYubdyK/NrP26TV4zgwh0hbQn5mtWyOgLDHTIhbhE1rrz5U72M4RAROZltDfcKlkzk6aRqNjrPinQQUBRl3KzXlXLsRVk53btBXFeVxo141QTJ6qJVfsDs3Ap+aKnIvc36mMRlX5H80eztpwCgqYYM5EnSMHGRUDdrMkBfHQhHZd8Q3hFqHdJqFZFc+1MwW/RTj01neF8ulsK+cuaCdI9rnIJVP35u8E1SZl2byPYS10rxvy53S8W6jFJGQKUOEphQP/tyqCLgmU2mLFp6USWW6OxXZ5R/4Iq/2ZZ2kw7fdFmZJOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=q3BXmTVfE+kfGVHoYLtw7B2qCfY0BKvJ951kywdyNCA=;
 b=M2lUF2ErYbnNhuZvEm2esSeeEAhKLmzj8jf13asreYSEC/PpwYout2H77PLWRy9QDtVZhYxBI8juxFcFacxtOtotE3gH4olRZO5tYVYsVQgJ8qZDzsEKvs2xUBU+nn9sxQTPqD/Htwn/kNAo5bRxCjdZX9ht55N3VZihAu0K3VtbeVuD5sh5jrpE/+2chUva0+gwwX6v7Z4X07NHu5KGOG3RlE1X/deESZI/6MLNU4U2b0QJuqb6E5APaXYsDWJ/BV1bQwbb/6Gb3+Pkb/g4j8j9dJsexsq7cazr8I/xkDcly5ERrEKdrazDd5/zVQbSQph1t70YtO6IvbDb+IOi6w==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw2ks6AgAAeBwCAAAQPgIAABfaAgAAsl4CABKcNgA==
Date: Mon, 20 Dec 2021 15:41:27 +0000
Message-ID: <20211220154127.GA1688861@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
 <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
 <20211217135855.GA4072899@EPUAKYIW015D>
 <7924e699-5e70-6fdc-8633-6a15894d66db@xen.org>
In-Reply-To: <7924e699-5e70-6fdc-8633-6a15894d66db@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 856e9850-27c1-4b5c-39fb-08d9c3cf3007
x-ms-traffictypediagnostic: PR3PR03MB6571:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6571CB5CB9D50FAB5CECDCC5E37B9@PR3PR03MB6571.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 6raLqfe2oYGX3AIDYln6rbl+1Ye0Ro9IVv2+vLc1/691A+QCtHpv8YBqTVKq9P4+oCFiW+VdPkirouBAz7HtLa78Ljuw+UMtKLEV9jJ619ubzOn6f2PpyGR7WH0f5r3rmQctdfzBmaNhzd8TrxYceiJFvi4pVxpoTOLiXqY+ydhLspWzOUOBnz4YBE+PW2HJKxbRXEJ0ZN+v1oeLNwykDbR/2IU+3LUqcgHxIr/7O/qOpyz0eICk3mb5Gt3aS3drVBTZ0Oarxia27+6YNlh/yHjFsVz5rXQv8+gHS07tR739aUGR+OkDcugOk/ZziG8vtOlBsRL3iNnSqrwG+M59PVpU1CfiBslCF0PeK7TsK4hKB7Ju9BZp+8n+d2OqZCdjskEIaGxPqmojdi7ceZijrOsUuJGS+BSYd5dTnbino192PsfObVklJJilnTrTMlBsvXowG+2m8V9XiamZkfdqjodv/W9T7d0Tv+ZxmSnK/EF3IH6twPCcn4cc63fcxAZIw+cW7+nAGCvxnZ+wPAKVWsADbQyQewFpzB+pd6S30sTquNRtbAZeeb95vmmwIQWRm0isSrTfcf+uy8VpWNyRxX70YPWjwD0n5c2VmnOyW5eSPiknvgcHFw4Vh7IBb/LZDsvuXXxurEDuB2f+Hhk5Szknoa+vinMJrvQ7oK8wZUUT2HvrcGOQZI7Re3Fdh1Ya1ITokUzass5VmSubFQuwPIm4HoY2XSnYhYuqcf4hG/+Q5fmROu/oFL1cOD5al/m3LkkH+qs//hsewgFIFVP70NemFyy8GHj4MtvrU3/yRY0=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(76116006)(66946007)(66556008)(6486002)(66446008)(66476007)(91956017)(1076003)(38100700002)(8676002)(83380400001)(122000001)(33716001)(64756008)(86362001)(8936002)(5660300002)(6916009)(4326008)(6506007)(508600001)(966005)(33656002)(38070700005)(53546011)(26005)(186003)(316002)(6512007)(71200400001)(2906002)(9686003)(54906003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?c8CJa1KMUaydDpTbefczwHubDUiJ9Iit3rnVsl8x8pIn+uEkgOD7OPegWyh7?=
 =?us-ascii?Q?TRUBX3tf4nNz+ahFHCq1hbSTrtRSt6Bi2a4cXjK+lKpZs4JPZDGYa7fbfWlq?=
 =?us-ascii?Q?w2A8ubIz/EZLmHggx/GkFbR61XccBWwttUJBw8V0qrv6U/TJ3ybSj5XF22AN?=
 =?us-ascii?Q?eojWhq4FKLyjS8uN3IJLSpxt2NMQtCVDFzyC/MT0uZRfPIVtCqRsHaL6z+IS?=
 =?us-ascii?Q?jzyMFKXrdQ+zeWgrjOo7JLtsQfSQry8S2LHCFMseJVOHf1uR4BRK5G9ZB6pH?=
 =?us-ascii?Q?l9MX/GVlmPhxBwgVs16de3QFBo+a7nM6RzuEJMnxYgki78i5b1hFqI8xVP+d?=
 =?us-ascii?Q?QTmVD1+hMdakdWSweTw0lZI+uYOBG7Re6Sqm6+6ZaYLRn5//eUo4MWRW6Xe4?=
 =?us-ascii?Q?GH+J5at+CD3yts3v905dYvEfEW8IxXjonu/0tRJBs4XR8iQvJ3BTqoGW3+CZ?=
 =?us-ascii?Q?r8WABxC3h/ZJ+AnZgdUsRMl9S1pR3Q02eSU6kFnx6uIuOEwIVKK0PduiStNc?=
 =?us-ascii?Q?3OPiggHPE27Y4a5YqcH/xdESdVLKQ0HaTDexBJ8YgtXXVTZxZSm8wo/DIQHM?=
 =?us-ascii?Q?h669omrCmOlmLFTcUo7txWz88HeBk6DURfSCsAy0EmKoJ/VI+hTFpSxNqURl?=
 =?us-ascii?Q?w/SJWP+LeZhydT3A+pCUxdwjGe1w84MpR/RsMpslLAd4uwTDhXyJnBTh8/3Y?=
 =?us-ascii?Q?RfdA/QOCrEoO8Eeuf3yZb/LvmXeprVay1smye5uvMNNL6CByr61lzLPQUYMf?=
 =?us-ascii?Q?hLCZFnjgX0870kz2y9XEXiXeDX84ihu/JDx7KT1fCan5ef7artw6gawpJtp1?=
 =?us-ascii?Q?49Ry21kTw5z7ntUH+P8OV58wi5j++prROUGCCw8gCjBCHU3C+mprAZUAbq4X?=
 =?us-ascii?Q?rVanmZlMVHKS2xLY+7+e7XlPi+vdybTAHSg5qfDR+GMp5P1kRrJarykaQD3x?=
 =?us-ascii?Q?OAXHxktaq7n+tHmf7PaQV/yG2jrYWRPPobH4TBLqACTL90Y1pxFqIMK/H61x?=
 =?us-ascii?Q?3SPFHqI9Sk/h1kn1KkuoWPvUW2vKvqP+0JL2K99O+rNgXUycQPrbMNv3WH3Q?=
 =?us-ascii?Q?gNnwGN7cI74TNz9hY20oBJGLt2VAn+C9+rFDFRUs1g9haTaz4t7E88FwfQep?=
 =?us-ascii?Q?FId0Ig5kH/DAP9+F/OOhuYAkX5D7k5E5FhpHoXS3jYHMFQEm+igy/IR4PBDq?=
 =?us-ascii?Q?wtsucfE+Q3U7om2cNZa7KJhbOYahqVsVbVgkZMkouBwNLGJgU+osYz9u/HI6?=
 =?us-ascii?Q?IvbPbtiYYFb5VCjEfIrg4UAi3Y4TTkAkdTsOcSM8WWlyq3jzMYaO8KXdwv01?=
 =?us-ascii?Q?cXxF4LhhvN2CnSVJ/FKBo6f/lFd+9Xu6DrCpjzXXY4uwHizPFiZlpKb+elOh?=
 =?us-ascii?Q?Kj8ifDtx8QBo7Dy5eGHv6JJQtgYiyYGubSgWa1FwCWrxM+zh6sfZyEqVyiX+?=
 =?us-ascii?Q?YJiltSD4VEn+JPLkuTUMh7po4y4msmrziaFUVtVOJLwAJ/krjFMUnbQlqQ38?=
 =?us-ascii?Q?8Ui0WLt4GmnAI7cbM0TUWuw+TkqqgXxSuM8n9pBGngZDSNjXInR98wUqZk8y?=
 =?us-ascii?Q?zwG7QkyxxDsl/nCOyQmJURd+Se7qbNjWRLy/d2sFsC1gUapkwbPfyyI9Ld5f?=
 =?us-ascii?Q?qc5KNK28O6XuemjD6TwgM4Vw2/FRexiVAy7Qr/PBwsb6hxtmIE9g3htB7Kh2?=
 =?us-ascii?Q?XZsuE6ovJSh+SWkp2yuHlKuo9t8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6444D2EEE436094A9681C56B515E527B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 856e9850-27c1-4b5c-39fb-08d9c3cf3007
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 15:41:27.9812
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: b51BmA5yP5qqbORpv/KPj73QhTrbsfeJeZOiBwJqw97vy7Hdv4LG9qkEemBx7+g2/h58aqITWldIDY/8nXUZvu4kmR0oCo4diYekZb3XfTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6571
X-Proofpoint-ORIG-GUID: vI70oUhGMdjH46lYfnaBUrsjA9Cflq5E
X-Proofpoint-GUID: vI70oUhGMdjH46lYfnaBUrsjA9Cflq5E
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-20_06,2021-12-20_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0
 spamscore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112200089

Hi Julien,

On Fri, Dec 17, 2021 at 04:38:31PM +0000, Julien Grall wrote:
>=20
>=20
> On 17/12/2021 13:58, Oleksii Moisieiev wrote:
> > Hi Julien,
>=20
> Hi,
>=20
> > On Fri, Dec 17, 2021 at 01:37:35PM +0000, Julien Grall wrote:
> > > Hi,
> > >=20
> > > On 17/12/2021 13:23, Oleksii Moisieiev wrote:
> > > > > > +static int map_memory_to_domain(struct domain *d, uint64_t add=
r, uint64_t len)
> > > > > > +{
> > > > > > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > > > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > > > +}
> > > > > > +
> > > > > > +static int unmap_memory_from_domain(struct domain *d, uint64_t=
 addr,
> > > > > > +                                     uint64_t len)
> > > > > > +{
> > > > > > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > > > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > > > +}
> > > > >=20
> > > > > I wonder, why we need an extra level of indirection here. And if =
this is
> > > > > really needed, I wonder why map(unmap)_memory* name was chosen, a=
s there is
> > > > > no memory mapping/unmapping really happens here.
> > > > >=20
> > > >=20
> > > > I've added extra indirection to hide math like
> > > > paddr_to_pfn(PAGE_ALIGN(addr + len -1)
> > > > so you don't have to math in each call. unmap_memory_from_domain ca=
lled
> > > > from 2 places, so I moved both calls to separate function.
> > > > Although, I agree that map/unmap is not perfect name. I consider
> > > > renaming it to mem_permit_acces and mam_deny_access.
> > >=20
> > > I haven't looked at the rest of the series. But this discussion caugh=
t my
> > > eye. This code implies that the address is page-aligned but the lengt=
h not.
> > > Is that intended?
> > >=20
> > > That said, if you give permission to the domain on a full page then i=
t means
> > > it may be able to access address it should not. Can you explain why t=
his is
> > > fine?
> > >=20
> >=20
> > The idea was that xen receives some memory from the dt_node linux,scmi_=
mem,
> > then we split memory between the agents, so each agent get 1 page (we
> > allocate 0x10 pages right now).
>=20
> Thanks for the clarification. Does this imply the guest will be able to
> write message directly to the firmware?

We used DEN0056C Specification as base. Available on: https://developer.arm=
.com/documentation/den0056/latest.
SCMI transport is described in Section 5.1. We implemented Shared Memory tr=
ansport.
Firmware has N pages of the shared memory, used to communicate with Agents.
It allocates N agents and assign a page for each agent, such as:
-------------------------------------
| Agent H | Agent 1 | Agent 2 | ... |
-------------------------------------
Agent H is the privilleged Hypervisor agent, which is used to do the base c=
ommands,
such as getting Agent list, set\unset permissions etc.
Hypervisor assign agent to the guest and maps page, related to the agent to=
 the Guest.
So the Guest, which is Agent 1 will get an access to Agent 1 page.

Guest places SCMI message to Agent 1 memory, then sends SMC message.
Hypervisor process SMC request, add agent id to the message parameters and =
redirects it to the Firmware.
Based on the agent_id Firmware knows which page it should read.=20
Then after permission check ( if the resetId/clockID/powerID etc from messa=
ge
is assigned to agent_id ) it does changes to the HW and places response to =
Agent
shared memory and marks channel as FREE ( by setting free bit in shared mem=
ory ).
Once channel is marked as free - Guest read response from the shared memory=
.

Non-virtualized systems will work as well. OS should send SMC directly to t=
he Firmware.=20

>=20
> If so, this brings a few more questions:
>   1) What will the guest write in it? Can it contains addresses?
Guest can write scmi request to the shared memory, which include the follow=
ing data:=20
1) protocol_id - which protocol is requested, such as clock, power, reset e=
tc
2) message_id - action that should be done to HW, such as do_reset or get_c=
lock
3) message data - which includes reset_id/clock_id/power_id etc. that shoul=
d be changed.
Reset IDs and Clock IDs are assigned in Firmware. Guest receives ID, corres=
ponding to the device from the device-tree.=20
dt_node as an example:=20
&avb { =20
	scmi_devid =3D <0>;
	clocks =3D <&scmi_clock 0>;
	power-domains =3D <&scmi_power 0>;
	resets =3D <&scmi_reset 0>;
};

>   2) What are the expected memory attribute for the regions?

xen uses iommu_permit_access to pass agent page to the guest. So guest can =
access the page directly.

>   3) What's the threat model for the firmware? Will it verify every reque=
st?

Firmware reads data from agent page, then makes check if clockid/resetid/po=
werid
etc is assigned to agent.
During building guest, Xen sends permission request to the firmware for eac=
h device,
which is passed-through to the guest. So for avb from previous example the
device_id 0 permission request will be sent. Based on the device_id firmwar=
e will
set permission for clockid 0, resetid 0 and powerid 0.=20

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249865.430339 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCF-0006vX-L6; Mon, 20 Dec 2021 16:07:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249865.430339; Mon, 20 Dec 2021 16:07:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCF-0006tV-0Q; Mon, 20 Dec 2021 16:07:31 +0000
Received: by outflank-mailman (input) for mailman id 249865;
 Mon, 20 Dec 2021 16:07:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCC-00055x-M2
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:28 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e994da1d-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 964191F3B2;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6B20A13D6B;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id WF3cGDiqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e994da1d-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NwQ4mRiosEanvExB6LuAnyU1/Dqqja/tWJzhJY5Y3Ms=;
	b=fHEmzq/8xHjjE8HlcsZAhETWt6xchVyelqjXalZEawE5P2CesILBUlsexQGDAgwxM+PkCb
	fszdw2vuUHFFe49W4v4AsgaCYhYm6bhruP2/Iz3zsYKPY6x0XV65JzElA4X34mMFIQE5Eb
	WxQb8SqipT8QPtMfbAL58Zu4qkIek3w=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 08/10] mini-os: add proper pvh grant table handling
Date: Mon, 20 Dec 2021 17:07:14 +0100
Message-Id: <20211220160716.4159-9-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Grant table initialization for PVH requires some additional actions
compared to PV mode. Add those.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/gnttab.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
index 56e59d7..281c207 100644
--- a/arch/x86/gnttab.c
+++ b/arch/x86/gnttab.c
@@ -22,11 +22,15 @@
  */
 
 #include <mini-os/os.h>
+#include <mini-os/console.h>
+#include <mini-os/e820.h>
 #include <mini-os/hypervisor.h>
 #include <mini-os/gnttab.h>
 #include <mini-os/mm.h>
 #include <mini-os/types.h>
+#include <xen/memory.h>
 
+#ifdef CONFIG_PARAVIRT
 grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
 {
     struct gnttab_setup_table setup;
@@ -39,6 +43,33 @@ grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
     HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
     return map_frames(frames, nr_grant_frames);
 }
+#else
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    int i, rc;
+    struct xen_add_to_physmap xatp;
+    unsigned long pfn;
+    unsigned long frames[nr_grant_frames];
+
+    pfn = e820_get_reserved_pfns(nr_grant_frames);
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        xatp.domid = DOMID_SELF;
+        xatp.idx = i;
+        xatp.space = XENMAPSPACE_grant_table;
+        xatp.gpfn = pfn + i;
+        rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp);
+        if ( rc )
+        {
+            xprintk("could not init grant table\n");
+            do_exit();
+        }
+        frames[i] = pfn + i;
+    }
+
+    return map_frames(frames, nr_grant_frames);
+}
+#endif
 
 void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
 {
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249853.430261 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC8-0005Q6-Df; Mon, 20 Dec 2021 16:07:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249853.430261; Mon, 20 Dec 2021 16:07:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC8-0005Pz-9J; Mon, 20 Dec 2021 16:07:24 +0000
Received: by outflank-mailman (input) for mailman id 249853;
 Mon, 20 Dec 2021 16:07:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLC6-00055x-LN
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:22 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e85c9543-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id EA8421F388;
 Mon, 20 Dec 2021 16:07:18 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BD02A13D6B;
 Mon, 20 Dec 2021 16:07:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id bXrPLDaqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e85c9543-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016438; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=37GUwbt+l3ZVL4jQWufvayPNooM23G4fn2Y2pwcBTd8=;
	b=pLzh4Dw4DOnfMVbr2vm6cwzAB9IE033KwtlpQtMwAiHPpjGIAL9C6eSiYLHE1NiNhCz2nZ
	k9Fjs5T6aLd3cwRfDrvYZneMm4qbidd3Xsvi+DdtIvyQdodSh+4aMZeiIdd6n7PYWdVzc+
	q0/izJaMAdQYN4JeLk10qnTZaNT9KY8=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 00/10] mini-os: add missing PVH features
Date: Mon, 20 Dec 2021 17:07:06 +0100
Message-Id: <20211220160716.4159-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Mini-OS in PVH mode is missing some features, especially in the areas
of ballooning and grant tables.

With this series I am able to run Xenstore stubdom in PVH mode.

Changes in V2:
- multiple comments addressed

Juergen Gross (10):
  mini-os: split e820 map handling into new source file
  mini-os: sort and sanitize e820 memory map
  mini-os: don't assume contiguous RAM when initializing in PVH mode
  mini-os: respect memory map when ballooning up
  mini-os: don't repeat definition available via header file
  mini-os: add memory map service functions
  mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
  mini-os: add proper pvh grant table handling
  mini-os: prepare grantmap entry interface for use by PVH mode
  mini-os: modify grant mappings to work in PVH mode

 Makefile           |   1 +
 arch/arm/mm.c      |  11 +-
 arch/x86/balloon.c |   4 +-
 arch/x86/gnttab.c  | 109 +++++++++++++
 arch/x86/mm.c      | 121 +--------------
 arch/x86/setup.c   |   8 +-
 balloon.c          |  33 ++--
 e820.c             | 376 +++++++++++++++++++++++++++++++++++++++++++++
 gntmap.c           | 125 +++++++++------
 include/balloon.h  |   5 +-
 include/e820.h     |  11 ++
 include/gntmap.h   |   1 +
 mm.c               |   7 +-
 13 files changed, 615 insertions(+), 197 deletions(-)
 create mode 100644 arch/x86/gnttab.c
 create mode 100644 e820.c

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249855.430281 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCA-0005uJ-3P; Mon, 20 Dec 2021 16:07:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249855.430281; Mon, 20 Dec 2021 16:07:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC9-0005so-Rw; Mon, 20 Dec 2021 16:07:25 +0000
Received: by outflank-mailman (input) for mailman id 249855;
 Mon, 20 Dec 2021 16:07:23 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLC7-00055x-LQ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:23 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e8f9097a-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 2F11D1F3B0;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 026CA13D6B;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id eIh+OjeqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8f9097a-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=0KigAZz9hYluMyaBKPARA/gJpt6ihPK6ZX8SoZiA/8c=;
	b=BGZCu+VhIL6E6RPcvOccUnBg36tJGuE8MKAUkblyrPPxIhFgMUC38Vgxam65yTOA/6etGK
	1FUXdp7oY5jJHkWxYtQhUDTxHM39/P+EDR++VaRNe4xOm49JXsEe9ojD4wWqCTrJmz3XsL
	+rS9zMb5p5OENE6OL0+w6RPfCDe3EvY=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 06/10] mini-os: add memory map service functions
Date: Mon, 20 Dec 2021 17:07:12 +0100
Message-Id: <20211220160716.4159-7-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add two functions for adding reserved areas to the memory map and
for removing them again.

Those will be needed for proper grant table/mapping support in PVH
mode.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- fix e820_put_reserved_pfns() (Samuel Thibault)
---
 e820.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |  4 ++++
 2 files changed, 54 insertions(+)

diff --git a/e820.c b/e820.c
index 659f71c..25e2f9d 100644
--- a/e820.c
+++ b/e820.c
@@ -283,6 +283,56 @@ void arch_print_memmap(void)
         printk("%012lx-%012lx: %s\n", from, to, type);
     }
 }
+
+unsigned long e820_get_reserved_pfns(int pages)
+{
+    int i;
+    unsigned long last = 0, needed = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0; i < e820_entries && e820_map[i].addr < last + needed; i++ )
+        last = e820_map[i].addr + e820_map[i].size;
+
+    if ( i == 0 || e820_map[i - 1].type != E820_RESERVED )
+        e820_insert_entry_at(i, last, needed, E820_RESERVED);
+    else
+        e820_map[i - 1].size += needed;
+
+    return last >> PAGE_SHIFT;
+}
+
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages)
+{
+    int i;
+    unsigned long addr = start_pfn << PAGE_SHIFT;
+    unsigned long size = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0;
+          i < e820_entries && addr >= e820_map[i].addr + e820_map[i].size;
+          i++ );
+
+    BUG_ON(i == e820_entries || e820_map[i].type != E820_RESERVED ||
+           addr + size > e820_map[i].addr + e820_map[i].size);
+
+    if ( addr == e820_map[i].addr )
+    {
+        e820_map[i].addr += size;
+        e820_map[i].size -= size;
+        if ( e820_map[i].size == 0 )
+            e820_remove_entry(i);
+        return;
+    }
+
+    if ( addr + size == e820_map[i].addr + e820_map[i].size )
+    {
+        e820_map[i].size -= size;
+        return;
+    }
+
+    e820_insert_entry_at(i + 1, addr + size,
+                         e820_map[i].addr + e820_map[i].size - addr - size,
+                         E820_RESERVED);
+    e820_map[i].size = addr - e820_map[i].addr;
+}
 #endif
 
 unsigned long e820_get_maxpfn(unsigned long pages)
diff --git a/include/e820.h b/include/e820.h
index 8d4d371..aaf2f2c 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -51,5 +51,9 @@ extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
 unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages);
+#ifndef CONFIG_E820_TRIVIAL
+unsigned long e820_get_reserved_pfns(int pages);
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages);
+#endif
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249864.430333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCE-0006qI-QA; Mon, 20 Dec 2021 16:07:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249864.430333; Mon, 20 Dec 2021 16:07:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCE-0006pF-Fd; Mon, 20 Dec 2021 16:07:30 +0000
Received: by outflank-mailman (input) for mailman id 249864;
 Mon, 20 Dec 2021 16:07:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCC-00055w-9i
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:28 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8682008-61ae-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 17:07:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 27F6D1F3A0;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F143313D6B;
 Mon, 20 Dec 2021 16:07:18 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 2BiUOTaqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:18 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8682008-61ae-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Cvjzn61nlQz/5cNRGk/V3qCPy6sEZi3f9w8y3gbMdqw=;
	b=b9kSDOD54CjbEdJV0hisvDcPiih19/6ZkGnbHGHR3e43ywtVC4E7DbvckDK2pby5sfe7dg
	CoxJj6F1lFGjiywDODLGuE3h32KgsGtOC6OY2CQd24DyzVA4V4VYA8GXSAnQByvl7lwxEz
	ag3iL+3lDG3nsoXlzpQSjLuE0N0kTS0=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 01/10] mini-os: split e820 map handling into new source file
Date: Mon, 20 Dec 2021 17:07:07 +0100
Message-Id: <20211220160716.4159-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce e820.c containing all the E820 memory map handling.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 Makefile       |   1 +
 arch/arm/mm.c  |   8 ----
 arch/x86/mm.c  |  70 +----------------------------
 e820.c         | 119 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |   6 +++
 5 files changed, 128 insertions(+), 76 deletions(-)
 create mode 100644 e820.c

diff --git a/Makefile b/Makefile
index 4b76b55..06b60fc 100644
--- a/Makefile
+++ b/Makefile
@@ -41,6 +41,7 @@ src-$(CONFIG_TPMFRONT) += tpmfront.c
 src-$(CONFIG_TPM_TIS) += tpm_tis.c
 src-$(CONFIG_TPMBACK) += tpmback.c
 src-y += daytime.c
+src-y += e820.c
 src-y += events.c
 src-$(CONFIG_FBFRONT) += fbfront.c
 src-y += gntmap.c
diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index f806c9f..9068166 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -7,14 +7,6 @@
 #include <lib.h>
 
 uint32_t physical_address_offset;
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
 
 unsigned long allocate_ondemand(unsigned long n, unsigned long alignment)
 {
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8ba14a5..8df93da 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -64,15 +64,6 @@ extern char stack[];
 extern void page_walk(unsigned long va);
 
 #ifdef CONFIG_PARAVIRT
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
-
 void arch_mm_preinit(void *p)
 {
     start_info_t *si = p;
@@ -112,25 +103,11 @@ desc_ptr idt_ptr =
     .base = (unsigned long)&idt,
 };
 
-struct e820entry e820_map[E820_MAX];
-unsigned e820_entries;
-
-static char *e820_types[E820_TYPES] = {
-    [E820_RAM]      = "RAM",
-    [E820_RESERVED] = "Reserved",
-    [E820_ACPI]     = "ACPI",
-    [E820_NVS]      = "NVS",
-    [E820_UNUSABLE] = "Unusable",
-    [E820_PMEM]     = "PMEM"
-};
-
 void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    struct xen_memory_map memmap;
-    int i;
-    unsigned long pfn, max = 0;
+    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -142,53 +119,10 @@ void arch_mm_preinit(void *p)
     }
     last_free_pfn = ret;
 
-    memmap.nr_entries = E820_MAX;
-    set_xen_guest_handle(memmap.buffer, e820_map);
-    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
-    if ( ret < 0 )
-    {
-        xprintk("could not get memory map\n");
-        do_exit();
-    }
-    e820_entries = memmap.nr_entries;
-
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type != E820_RAM )
-            continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
-    }
-
+    max = e820_get_maxpfn();
     if ( max < last_free_pfn )
         last_free_pfn = max;
 }
-
-void arch_print_memmap(void)
-{
-    int i;
-    unsigned long from, to;
-    char *type;
-    char buf[12];
-
-    printk("Memory map:\n");
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
-        {
-            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
-            type = buf;
-        }
-        else
-        {
-            type = e820_types[e820_map[i].type];
-        }
-        from = e820_map[i].addr;
-        to = from + e820_map[i].size - 1;
-        printk("%012lx-%012lx: %s\n", from, to, type);
-    }
-}
 #endif
 
 /*
diff --git a/e820.c b/e820.c
new file mode 100644
index 0000000..2165280
--- /dev/null
+++ b/e820.c
@@ -0,0 +1,119 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/types.h>
+#include <mini-os/lib.h>
+#include <mini-os/console.h>
+#include <mini-os/os.h>
+#include <mini-os/posix/limits.h>
+#include <mini-os/e820.h>
+#include <xen/memory.h>
+
+#ifdef CONFIG_E820_TRIVIAL
+struct e820entry e820_map[1] = {
+    {
+        .addr = 0,
+        .size = ULONG_MAX - 1,
+        .type = E820_RAM
+    }
+};
+
+unsigned e820_entries = 1;
+
+static void e820_get_memmap(void)
+{
+}
+
+#else
+struct e820entry e820_map[E820_MAX];
+unsigned e820_entries;
+
+static char *e820_types[E820_TYPES] = {
+    [E820_RAM]      = "RAM",
+    [E820_RESERVED] = "Reserved",
+    [E820_ACPI]     = "ACPI",
+    [E820_NVS]      = "NVS",
+    [E820_UNUSABLE] = "Unusable",
+    [E820_PMEM]     = "PMEM"
+};
+
+static void e820_get_memmap(void)
+{
+    long ret;
+    struct xen_memory_map memmap;
+
+    memmap.nr_entries = E820_MAX;
+    set_xen_guest_handle(memmap.buffer, e820_map);
+    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
+    if ( ret < 0 )
+    {
+        xprintk("could not get memory map\n");
+        do_exit();
+    }
+    e820_entries = memmap.nr_entries;
+}
+
+void arch_print_memmap(void)
+{
+    int i;
+    unsigned long from, to;
+    char *type;
+    char buf[12];
+
+    printk("Memory map:\n");
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
+        {
+            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
+            type = buf;
+        }
+        else
+        {
+            type = e820_types[e820_map[i].type];
+        }
+        from = e820_map[i].addr;
+        to = from + e820_map[i].size - 1;
+        printk("%012lx-%012lx: %s\n", from, to, type);
+    }
+}
+#endif
+
+unsigned long e820_get_maxpfn(void)
+{
+    int i;
+    unsigned long pfn, max = 0;
+
+    e820_get_memmap();
+
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type != E820_RAM )
+            continue;
+        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        if ( pfn > max )
+            max = pfn;
+    }
+
+    return max;
+}
diff --git a/include/e820.h b/include/e820.h
index 920551c..af2129f 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -24,6 +24,10 @@
 #ifndef __E820_HEADER
 #define __E820_HEADER
 
+#if defined(__arm__) || defined(__aarch64__) || defined(CONFIG_PARAVIRT)
+#define CONFIG_E820_TRIVIAL
+#endif
+
 /* PC BIOS standard E820 types and structure. */
 #define E820_RAM          1
 #define E820_RESERVED     2
@@ -45,4 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
+unsigned long e820_get_maxpfn(void);
+
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249854.430263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC8-0005Sy-MX; Mon, 20 Dec 2021 16:07:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249854.430263; Mon, 20 Dec 2021 16:07:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC8-0005RG-HJ; Mon, 20 Dec 2021 16:07:24 +0000
Received: by outflank-mailman (input) for mailman id 249854;
 Mon, 20 Dec 2021 16:07:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLC7-00055w-8c
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:23 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e89f5515-61ae-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 17:07:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 8C06B218F9;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 60D7B13DAC;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gIdVFjeqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e89f5515-61ae-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=POjxJaAzzZfNKLwq8GHwwKNxLxPxY05Rtom00f9HoLs=;
	b=DWDOfJA+puFbtAWZuJ7ORNsrBHHByIxVt5Ct3fW6WHOQwjgHh5Mct3pwvJBCgcxZ/gHkFe
	t1m8cf7IjZuS5omEBLcxBOJBVlNi3KG5Wb6mqSwxK+zr6/bD75NROoCs9H5MZ/6/X6Ehwp
	Z+3h7ZW693CQz7mU/TpRqUO+ViHT35c=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode
Date: Mon, 20 Dec 2021 17:07:09 +0100
Message-Id: <20211220160716.4159-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Sizing the available memory should respect memory holes, so look at
the memory map when setting the boundary for the memory allocator.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- rename "max" to "start" (Samuel Thibault)
---
 arch/x86/mm.c  |  6 +-----
 e820.c         | 14 ++++++++------
 include/e820.h |  2 +-
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8df93da..3bf6170 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -107,7 +107,6 @@ void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -117,11 +116,8 @@ void arch_mm_preinit(void *p)
         xprintk("could not get memory size\n");
         do_exit();
     }
-    last_free_pfn = ret;
 
-    max = e820_get_maxpfn();
-    if ( max < last_free_pfn )
-        last_free_pfn = max;
+    last_free_pfn = e820_get_maxpfn(ret);
 }
 #endif
 
diff --git a/e820.c b/e820.c
index 1770158..6d15cdf 100644
--- a/e820.c
+++ b/e820.c
@@ -285,10 +285,10 @@ void arch_print_memmap(void)
 }
 #endif
 
-unsigned long e820_get_maxpfn(void)
+unsigned long e820_get_maxpfn(unsigned long pages)
 {
     int i;
-    unsigned long pfn, max = 0;
+    unsigned long pfns, start = 0;
 
     e820_get_memmap();
 
@@ -296,10 +296,12 @@ unsigned long e820_get_maxpfn(void)
     {
         if ( e820_map[i].type != E820_RAM )
             continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
+        pfns = e820_map[i].size >> PAGE_SHIFT;
+        start = e820_map[i].addr >> PAGE_SHIFT;
+        if ( pages <= pfns )
+            return start + pages;
+        pages -= pfns;
     }
 
-    return max;
+    return start + pfns;
 }
diff --git a/include/e820.h b/include/e820.h
index af2129f..6a57f05 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -49,6 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
-unsigned long e820_get_maxpfn(void);
+unsigned long e820_get_maxpfn(unsigned long pages);
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249852.430247 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC7-00058f-5n; Mon, 20 Dec 2021 16:07:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249852.430247; Mon, 20 Dec 2021 16:07:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLC7-00058Q-1Y; Mon, 20 Dec 2021 16:07:23 +0000
Received: by outflank-mailman (input) for mailman id 249852;
 Mon, 20 Dec 2021 16:07:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLC6-00055w-8b
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:22 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8dda842-61ae-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 17:07:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id EE279218FC;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C321013D6B;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KFlaLjeqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8dda842-61ae-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VPgUZQEXWMjuiDqJWRTGWtw72dHgK1/ZM2te4tasytk=;
	b=mq8DOsnesC1v2dMnluoobHNTmIK5fdEb4eiejWMKxSn3+Gfha/rG2sCSv3YuIuqxi21u7p
	Tk5gC55nVa8Kx+4o4rHH3dRf9EkZ3v/KmKPhNz/wPgb4HPiPCSmZOClV7oXq1S/78vuwT+
	8cxFGqBOaAsqWn97WKARaNazRkyj+eo=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 05/10] mini-os: don't repeat definition available via header file
Date: Mon, 20 Dec 2021 17:07:11 +0100
Message-Id: <20211220160716.4159-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

arch/x86/setup.c is repeating the definition of __pte() instead using
the appropriate header. Fix that.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/setup.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/x86/setup.c b/arch/x86/setup.c
index 1ec68d3..b27bbed 100644
--- a/arch/x86/setup.c
+++ b/arch/x86/setup.c
@@ -29,6 +29,7 @@
 #include <mini-os/os.h>
 #include <mini-os/lib.h> /* for printk, memcpy */
 #include <mini-os/kernel.h>
+#include <mini-os/hypervisor.h>
 #include <xen/xen.h>
 #include <xen/arch-x86/cpuid.h>
 #include <xen/arch-x86/hvm/start_info.h>
@@ -61,13 +62,6 @@ char stack[2*STACK_SIZE];
 
 extern char shared_info[PAGE_SIZE];
 
-#if defined(__x86_64__)
-#define __pte(x) ((pte_t) { (x) } )
-#else
-#define __pte(x) ({ unsigned long long _x = (x);        \
-    ((pte_t) {(unsigned long)(_x), (unsigned long)(_x>>32)}); })
-#endif
-
 static inline void fpu_init(void) {
 	asm volatile("fninit");
 }
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249860.430308 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCC-0006N1-9V; Mon, 20 Dec 2021 16:07:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249860.430308; Mon, 20 Dec 2021 16:07:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCC-0006Mm-4j; Mon, 20 Dec 2021 16:07:28 +0000
Received: by outflank-mailman (input) for mailman id 249860;
 Mon, 20 Dec 2021 16:07:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCA-00055w-9I
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:26 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e8c303e1-61ae-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 17:07:20 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id BD8AE1F3A3;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9272213D6B;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id YJl6IjeqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e8c303e1-61ae-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZJxJEFiHs3uH1jT5/e24KC56tHdpQMXoWtlkInpMjy4=;
	b=Ho/HSDwECpZMfw9sIrvOOQyj1wHST8peaJ8xVzPJ2EmXuE9djCKi4FimsP/eHMj59LJqqr
	Lj8Pqib5o0Bm8YL+ud/YPtReFbuIcKgoaJzykS3ElqlXNTXL6ZJaw7UZmeJqR+MmwqRebN
	NPe4jzUxPGPluWhRinGt5oV+w8cFf2Q=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 04/10] mini-os: respect memory map when ballooning up
Date: Mon, 20 Dec 2021 17:07:10 +0100
Message-Id: <20211220160716.4159-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today Mini-OS won't look at the memory map when ballooning up. This can
result in problems for PVH domains with more than 4 GB of RAM, as
ballooning will happily run into the ACPI area.

Fix that by adding only pages being marked as RAM in the memory map and
by distinguishing between the current number of RAM pages and the first
unallocated page.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- rename and fix e820_get_max_pages() (Samuel Thibault)
---
 arch/arm/mm.c      |  3 +++
 arch/x86/balloon.c |  4 ++--
 arch/x86/mm.c      |  2 ++
 balloon.c          | 33 ++++++++++++++++++++++++---------
 e820.c             | 21 ++++++++++++++++++++-
 include/balloon.h  |  5 +++--
 include/e820.h     |  1 +
 mm.c               |  7 ++-----
 8 files changed, 57 insertions(+), 19 deletions(-)

diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index 9068166..11962f8 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -3,6 +3,7 @@
 #include <arch_mm.h>
 #include <mini-os/errno.h>
 #include <mini-os/hypervisor.h>
+#include <mini-os/balloon.h>
 #include <libfdt.h>
 #include <lib.h>
 
@@ -70,6 +71,8 @@ void arch_init_mm(unsigned long *start_pfn_p, unsigned long *max_pfn_p)
     }
     device_tree = new_device_tree;
     *max_pfn_p = to_phys(new_device_tree) >> PAGE_SHIFT;
+
+    balloon_set_nr_pages(*max_pfn_p, *max_pfn_p);
 }
 
 void arch_init_demand_mapping_area(void)
diff --git a/arch/x86/balloon.c b/arch/x86/balloon.c
index 10b440c..fe79644 100644
--- a/arch/x86/balloon.c
+++ b/arch/x86/balloon.c
@@ -61,10 +61,10 @@ void arch_remap_p2m(unsigned long max_pfn)
     p2m_invalidate(l2_list, L2_P2M_IDX(max_pfn - 1) + 1);
     p2m_invalidate(l1_list, L1_P2M_IDX(max_pfn - 1) + 1);
 
-    if ( p2m_pages(nr_max_pages) <= p2m_pages(max_pfn) )
+    if ( p2m_pages(nr_max_pfn) <= p2m_pages(max_pfn) )
         return;
 
-    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pages));
+    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pfn));
     for ( pfn = 0; pfn < max_pfn; pfn += P2M_ENTRIES )
     {
         map_frame_rw(new_p2m + PAGE_SIZE * (pfn / P2M_ENTRIES),
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 3bf6170..c30d8bc 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -72,6 +72,7 @@ void arch_mm_preinit(void *p)
     pt_base = (pgentry_t *)si->pt_base;
     first_free_pfn = PFN_UP(to_phys(pt_base)) + si->nr_pt_frames;
     last_free_pfn = si->nr_pages;
+    balloon_set_nr_pages(last_free_pfn, last_free_pfn);
 }
 #else
 #include <mini-os/desc.h>
@@ -118,6 +119,7 @@ void arch_mm_preinit(void *p)
     }
 
     last_free_pfn = e820_get_maxpfn(ret);
+    balloon_set_nr_pages(ret, last_free_pfn);
 }
 #endif
 
diff --git a/balloon.c b/balloon.c
index 5676d3b..9dc77c5 100644
--- a/balloon.c
+++ b/balloon.c
@@ -23,14 +23,24 @@
 
 #include <mini-os/os.h>
 #include <mini-os/balloon.h>
+#include <mini-os/e820.h>
 #include <mini-os/errno.h>
 #include <mini-os/lib.h>
 #include <mini-os/paravirt.h>
 #include <xen/xen.h>
 #include <xen/memory.h>
 
-unsigned long nr_max_pages;
-unsigned long nr_mem_pages;
+unsigned long nr_max_pfn;
+
+static unsigned long nr_max_pages;
+static unsigned long nr_mem_pfn;
+static unsigned long nr_mem_pages;
+
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn)
+{
+    nr_mem_pages = pages;
+    nr_mem_pfn = pfn;
+}
 
 void get_max_pages(void)
 {
@@ -46,16 +56,18 @@ void get_max_pages(void)
 
     nr_max_pages = ret;
     printk("Maximum memory size: %ld pages\n", nr_max_pages);
+
+    nr_max_pfn = e820_get_maxpfn(nr_max_pages);
 }
 
 void mm_alloc_bitmap_remap(void)
 {
     unsigned long i, new_bitmap;
 
-    if ( mm_alloc_bitmap_size >= ((nr_max_pages + 1) >> 3) )
+    if ( mm_alloc_bitmap_size >= ((nr_max_pfn + 1) >> 3) )
         return;
 
-    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pages + 1) >> 3));
+    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pfn + 1) >> 3));
     for ( i = 0; i < mm_alloc_bitmap_size; i += PAGE_SIZE )
     {
         map_frame_rw(new_bitmap + i,
@@ -70,7 +82,7 @@ static unsigned long balloon_frames[N_BALLOON_FRAMES];
 
 int balloon_up(unsigned long n_pages)
 {
-    unsigned long page, pfn;
+    unsigned long page, pfn, start_pfn;
     int rc;
     struct xen_memory_reservation reservation = {
         .domid        = DOMID_SELF
@@ -81,8 +93,11 @@ int balloon_up(unsigned long n_pages)
     if ( n_pages > N_BALLOON_FRAMES )
         n_pages = N_BALLOON_FRAMES;
 
+    start_pfn = e820_get_maxpfn(nr_mem_pages + 1) - 1;
+    n_pages = e820_get_max_contig_pages(start_pfn, n_pages);
+
     /* Resize alloc_bitmap if necessary. */
-    while ( mm_alloc_bitmap_size * 8 < nr_mem_pages + n_pages )
+    while ( mm_alloc_bitmap_size * 8 < start_pfn + n_pages )
     {
         page = alloc_page();
         if ( !page )
@@ -99,14 +114,14 @@ int balloon_up(unsigned long n_pages)
         mm_alloc_bitmap_size += PAGE_SIZE;
     }
 
-    rc = arch_expand_p2m(nr_mem_pages + n_pages);
+    rc = arch_expand_p2m(start_pfn + n_pages);
     if ( rc )
         return rc;
 
     /* Get new memory from hypervisor. */
     for ( pfn = 0; pfn < n_pages; pfn++ )
     {
-        balloon_frames[pfn] = nr_mem_pages + pfn;
+        balloon_frames[pfn] = start_pfn + pfn;
     }
     set_xen_guest_handle(reservation.extent_start, balloon_frames);
     reservation.nr_extents = n_pages;
@@ -116,7 +131,7 @@ int balloon_up(unsigned long n_pages)
 
     for ( pfn = 0; pfn < rc; pfn++ )
     {
-        arch_pfn_add(nr_mem_pages + pfn, balloon_frames[pfn]);
+        arch_pfn_add(start_pfn + pfn, balloon_frames[pfn]);
         free_page(pfn_to_virt(nr_mem_pages + pfn));
     }
 
diff --git a/e820.c b/e820.c
index 6d15cdf..659f71c 100644
--- a/e820.c
+++ b/e820.c
@@ -290,7 +290,8 @@ unsigned long e820_get_maxpfn(unsigned long pages)
     int i;
     unsigned long pfns, start = 0;
 
-    e820_get_memmap();
+    if ( !e820_entries )
+        e820_get_memmap();
 
     for ( i = 0; i < e820_entries; i++ )
     {
@@ -305,3 +306,21 @@ unsigned long e820_get_maxpfn(unsigned long pages)
 
     return start + pfns;
 }
+
+unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages)
+{
+    int i;
+    unsigned long end;
+
+    for ( i = 0; i < e820_entries && e820_map[i].addr < (pfn << PAGE_SHIFT);
+          i++ )
+    {
+        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        if ( e820_map[i].type != E820_RAM || end <= pfn )
+            continue;
+
+        return ((end - pfn) > pages) ? pages : end - pfn;
+    }
+
+    return 0;
+}
diff --git a/include/balloon.h b/include/balloon.h
index 6cfec4f..8f7c8bd 100644
--- a/include/balloon.h
+++ b/include/balloon.h
@@ -32,11 +32,11 @@
  */
 #define BALLOON_EMERGENCY_PAGES   64
 
-extern unsigned long nr_max_pages;
-extern unsigned long nr_mem_pages;
+extern unsigned long nr_max_pfn;
 
 void get_max_pages(void);
 int balloon_up(unsigned long n_pages);
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn);
 
 void mm_alloc_bitmap_remap(void);
 void arch_pfn_add(unsigned long pfn, unsigned long mfn);
@@ -50,6 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
 {
     return needed <= nr_free_pages;
 }
+static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
 
 #endif /* CONFIG_BALLOON */
 #endif /* _BALLOON_H_ */
diff --git a/include/e820.h b/include/e820.h
index 6a57f05..8d4d371 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -50,5 +50,6 @@ extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
+unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages);
 
 #endif /*__E820_HEADER*/
diff --git a/mm.c b/mm.c
index 932ceeb..6493bdd 100644
--- a/mm.c
+++ b/mm.c
@@ -396,8 +396,9 @@ void init_mm(void)
 
     printk("MM: Init\n");
 
-    get_max_pages();
     arch_init_mm(&start_pfn, &max_pfn);
+    get_max_pages();
+
     /*
      * now we can initialise the page allocator
      */
@@ -407,10 +408,6 @@ void init_mm(void)
     arch_init_p2m(max_pfn);
     
     arch_init_demand_mapping_area();
-
-#ifdef CONFIG_BALLOON
-    nr_mem_pages = max_pfn;
-#endif
 }
 
 void fini_mm(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249861.430315 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCD-0006Te-0h; Mon, 20 Dec 2021 16:07:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249861.430315; Mon, 20 Dec 2021 16:07:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCC-0006RZ-OU; Mon, 20 Dec 2021 16:07:28 +0000
Received: by outflank-mailman (input) for mailman id 249861;
 Mon, 20 Dec 2021 16:07:27 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCA-00055x-M5
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:26 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e882fae1-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 5C6E21F3A2;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2EBAC13D6B;
 Mon, 20 Dec 2021 16:07:19 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id QLsnCjeqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:19 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e882fae1-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016439; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Cv003J0xi/p+K/xvrdTTejHNr9Au2kqIdVjkJGzcq9s=;
	b=CKeX6VviJeP816wpS1Rj6o9fD+i+6fsB3sa7bc+GY2FusiNziIREux6JNomUDXC3LDdwcw
	rtyjynefgFUAj3U4HLU/bwGrgKeBEX73nlrF1maMpRt/HxfAH43Um52sEUPxPGS50LoD/Z
	1crt9EVyXV1jnYG4mpdS7w9naF85M+E=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 02/10] mini-os: sort and sanitize e820 memory map
Date: Mon, 20 Dec 2021 17:07:08 +0100
Message-Id: <20211220160716.4159-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Do some processing of the E820 memory map obtained from the hypervisor:

- align the entries to page boundaries
- sort the entries by their start address
- merge adjacent entries of same type

This is relevant for PVH mode only.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- correct page boundary rounding
- handle overlaps after rounding (Samuel Thibault)
- improve sorting (Samuel Thibault)
---
 e820.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 186 insertions(+)

diff --git a/e820.c b/e820.c
index 2165280..1770158 100644
--- a/e820.c
+++ b/e820.c
@@ -57,6 +57,190 @@ static char *e820_types[E820_TYPES] = {
     [E820_PMEM]     = "PMEM"
 };
 
+/*
+ * E820 type based bitmask for deciding how to round entries to page
+ * boundaries: A set bit means the type relates to a resource managed by
+ * Mini-OS (e.g. RAM), so rounding needs to be done to only include pages
+ * completely of the related type (narrowing). All other types need to be
+ * rounded to include all pages with parts of that type (widening).
+ */
+#define E820_NARROW ((1U << E820_RAM) | (1U << E820_NVS) | (1 << E820_PMEM))
+
+/* Private type used to mark a range temporarily as reserved (lowest prio). */
+#define E820_TMP_RESERVED    0
+
+static void e820_remove_entry(int idx)
+{
+    int i;
+
+    e820_entries--;
+    for ( i = idx; i < e820_entries; i++ )
+        e820_map[i] = e820_map[i + 1];
+}
+
+static void e820_insert_entry_at(int idx, unsigned long addr,
+                                 unsigned long size, unsigned int type)
+{
+    int i;
+
+    if ( e820_entries == E820_MAX )
+    {
+        xprintk("E820 memory map overflow\n");
+        do_exit();
+    }
+
+    e820_entries++;
+    for ( i = e820_entries - 1; i > idx; i-- )
+        e820_map[i] = e820_map[i - 1];
+
+    e820_map[idx].addr = addr;
+    e820_map[idx].size = size;
+    e820_map[idx].type = type;
+}
+
+static void e820_insert_entry(unsigned long addr, unsigned long size,
+                              unsigned int type)
+{
+    int i;
+
+    for ( i = 0; i < e820_entries && addr > e820_map[i].addr; i++ );
+
+    e820_insert_entry_at(i, addr, size, type);
+}
+
+static void e820_swap_entries(int idx1, int idx2)
+{
+    struct e820entry entry;
+
+    entry = e820_map[idx1];
+    e820_map[idx1] = e820_map[idx2];
+    e820_map[idx2] = entry;
+}
+
+/*
+ * Do a memory map sanitizing sweep:
+ * - sort the entries by start address
+ * - remove overlaps of entries (higher type value wins)
+ * - merge adjacent entries of same type
+ */
+static void e820_process_entries(void)
+{
+    int i, j;
+    unsigned long end, start;
+    unsigned int type;
+
+    /* Sort entries. */
+    for ( i = 1; i < e820_entries; i++ )
+        for ( j = i; j > 0 && e820_map[j - 1].addr > e820_map[j].addr; j-- )
+            e820_swap_entries(j - 1, j);
+
+    /* Handle overlapping entries (higher type values win). */
+    for ( i = 1; i < e820_entries; i++ )
+    {
+        if ( e820_map[i - 1].addr + e820_map[i - 1].size <= e820_map[i].addr )
+            continue;
+        if ( e820_map[i - 1].addr < e820_map[i].addr )
+        {
+            e820_insert_entry_at(i - 1, e820_map[i - 1].addr,
+                                 e820_map[i].addr - e820_map[i - 1].addr,
+                                 e820_map[i - 1].type);
+            e820_map[i].addr += e820_map[i - 1].size;
+            e820_map[i].size -= e820_map[i - 1].size;
+            i++;
+        }
+        if ( e820_map[i - 1].type < e820_map[i].type )
+            e820_swap_entries(i - 1, i);
+        if ( e820_map[i - 1].size >= e820_map[i].size )
+        {
+            e820_remove_entry(i);
+            i--;
+        }
+        else
+        {
+            start = e820_map[i].addr + e820_map[i - 1].size;
+            end = e820_map[i].addr + e820_map[i].size;
+            type = e820_map[i].type;
+            e820_remove_entry(i);
+            e820_insert_entry(start, end - start, type);
+        }
+    }
+
+    /* Merge adjacent entries. */
+    for ( i = 0; i < e820_entries - 1; i++ )
+    {
+        if ( e820_map[i].type == e820_map[i + 1].type &&
+             e820_map[i].addr + e820_map[i].size >= e820_map[i + 1].addr )
+        {
+            if ( e820_map[i].addr + e820_map[i].size <
+                 e820_map[i + 1].addr + e820_map[i + 1].size )
+            {
+                e820_map[i].size = e820_map[i + 1].addr - e820_map[i].addr +
+                                   e820_map[i + 1].size;
+            }
+            e820_remove_entry(i + 1);
+            i--;
+        }
+    }
+}
+
+/*
+ * Transform memory map into a well sorted map without any overlaps.
+ * - sort map entries by start address
+ * - handle overlaps
+ * - merge adjacent entries of same type (possibly removing boundary in the
+ *   middle of a page)
+ * - trim entries to page boundaries (depending on type either expanding
+ *   the entry or narrowing it down)
+ * - repeat first 3 sanitizing steps
+ * - make remaining temporarily reserved entries permanently reserved
+ */
+static void e820_sanitize(void)
+{
+    int i;
+    unsigned long end, start;
+
+    /* Sanitize memory map in current form. */
+    e820_process_entries();
+
+    /* Adjust map entries to page boundaries. */
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        start = e820_map[i].addr;
+        end = start + e820_map[i].size;
+        if ( (1U << e820_map[i].type) & E820_NARROW )
+        {
+            if ( start & (PAGE_SIZE - 1) )
+            {
+                start = round_pgup(start);
+                e820_insert_entry_at(i, start - PAGE_SIZE, PAGE_SIZE,
+                                     E820_TMP_RESERVED);
+                i++;
+            }
+            if ( end & (PAGE_SIZE - 1) )
+            {
+                end = round_pgdown(end);
+                e820_insert_entry_at(i, end, PAGE_SIZE, E820_TMP_RESERVED);
+                i++;
+            }
+        }
+        else
+        {
+            start = round_pgdown(start);
+            end = round_pgup(end);
+        }
+        e820_map[i].addr = start;
+        e820_map[i].size = end - start;
+    }
+
+    /* Sanitize memory map (again). */
+    e820_process_entries();
+
+    /* Make remaining temporarily reserved entries permanently reserved. */
+    for ( i = 0; i < e820_entries; i++ )
+        if ( e820_map[i].type == E820_TMP_RESERVED )
+            e820_map[i].type = E820_RESERVED;
+}
+
 static void e820_get_memmap(void)
 {
     long ret;
@@ -71,6 +255,8 @@ static void e820_get_memmap(void)
         do_exit();
     }
     e820_entries = memmap.nr_entries;
+
+    e820_sanitize();
 }
 
 void arch_print_memmap(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249867.430351 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCH-0007Ed-1F; Mon, 20 Dec 2021 16:07:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249867.430351; Mon, 20 Dec 2021 16:07:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCG-0007AI-Au; Mon, 20 Dec 2021 16:07:32 +0000
Received: by outflank-mailman (input) for mailman id 249867;
 Mon, 20 Dec 2021 16:07:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCD-00055x-MC
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:29 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e994c24c-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 64E341F3B1;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3632913D6B;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OOncCziqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e994c24c-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ce+N1zGKQYy8hCldpOth9Bm5wXCCEJvD9D9LhUj9MqQ=;
	b=cWUUXYQwUV2VTvC9d9SQ9id2mBJZNdCT3LP25oCPV00TvQZE9kaOz3Azd9AskgY4CNA0Dv
	dQ28BZ8n0gQWEnarVEmdCAcJclsluUIV7kvfpR8bfO4/Xo2sXSbzGgYq2GLpQiTKSeqcsK
	bA1PDGndrRJ8nQviz8883vQuZGuk4nc=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 07/10] mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
Date: Mon, 20 Dec 2021 17:07:13 +0100
Message-Id: <20211220160716.4159-8-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Having grant table code in arch/x86/mm.c seems wrong. Move it to the
new file arch/x86/gnttab.c, especially as the amount of code is
expected to grow further.

While doing that replace  type casts to pte_t with the more appropriate
__pte() macro.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/gnttab.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++
 arch/x86/mm.c     | 47 ----------------------------
 2 files changed, 78 insertions(+), 47 deletions(-)
 create mode 100644 arch/x86/gnttab.c

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
new file mode 100644
index 0000000..56e59d7
--- /dev/null
+++ b/arch/x86/gnttab.c
@@ -0,0 +1,78 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/os.h>
+#include <mini-os/hypervisor.h>
+#include <mini-os/gnttab.h>
+#include <mini-os/mm.h>
+#include <mini-os/types.h>
+
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+    return map_frames(frames, nr_grant_frames);
+}
+
+void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+#ifdef CONFIG_PARAVIRT
+    int i;
+
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte(0x0 << PAGE_SHIFT), UVMF_INVLPG);
+    }
+#endif
+    return;
+}
+
+void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+#ifdef CONFIG_PARAVIRT
+    int i;
+#endif
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+
+#ifdef CONFIG_PARAVIRT
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte((frames[i] << PAGE_SHIFT) | L1_PROT), UVMF_INVLPG);
+    }
+#endif
+}
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index c30d8bc..220c0b4 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -837,53 +837,6 @@ void arch_init_mm(unsigned long* start_pfn_p, unsigned long* max_pfn_p)
 #endif
 }
 
-grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-    return map_frames(frames, nr_grant_frames);
-}
-
-void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-#ifdef CONFIG_PARAVIRT
-    int i;
-
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){0x0<<PAGE_SHIFT}, UVMF_INVLPG);
-    }
-#endif
-    return;
-}
-
-void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-#ifdef CONFIG_PARAVIRT
-    int i;
-#endif
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-
-#ifdef CONFIG_PARAVIRT
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){(frames[i] << PAGE_SHIFT) | L1_PROT}, UVMF_INVLPG);
-    }
-#endif
-}
-
 unsigned long alloc_virt_kernel(unsigned n_pages)
 {
     unsigned long addr;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:07:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:07:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249868.430361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCI-0007SP-7F; Mon, 20 Dec 2021 16:07:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249868.430361; Mon, 20 Dec 2021 16:07:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLCH-0007OY-9u; Mon, 20 Dec 2021 16:07:33 +0000
Received: by outflank-mailman (input) for mailman id 249868;
 Mon, 20 Dec 2021 16:07:30 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCE-00055w-9y
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:30 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e95ea199-61ae-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id C9E35218FD;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D6D913D6B;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id IBMRJTiqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e95ea199-61ae-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016440; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VFqq/QNK2D+xIQFRd42TWwa5OQ2iSim/015QEF+tkx0=;
	b=raxQRDTsz+PEwKz8cqE8gFusgSjw7umtA/NC6kZo3TyDhlKqnpxL3RkcIr1m58M8RLw3YL
	PAcwPavo0qZmknQsfDyg2XHWqUZqn5Xep6xznNY/lWZtnYQTpCWx9Wm437zz9DpC5ybOAq
	8Cfty8nb4eVMNMfMPZPvaNpG73hzk6U=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 09/10] mini-os: prepare grantmap entry interface for use by PVH mode
Date: Mon, 20 Dec 2021 17:07:15 +0100
Message-Id: <20211220160716.4159-10-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of passing the pointer of a grantmap entry to the
_gntmap_[un]map_grant_ref() sub-functions use the map pointer and the
entry index instead. This will be needed for PVH mode usage.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 gntmap.c | 48 +++++++++++++++++++++++-------------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index f6ab3ad..7ae8fe6 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -55,36 +55,34 @@ struct gntmap_entry {
 };
 
 static inline int
-gntmap_entry_used(struct gntmap_entry *entry)
+gntmap_entry_used(struct gntmap *map, int idx)
 {
-    return entry->host_addr != 0;
+    return map->entries[idx].host_addr != 0;
 }
 
-static struct gntmap_entry*
-gntmap_find_free_entry(struct gntmap *map)
+static int gntmap_find_free_entry(struct gntmap *map)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
-        if (!gntmap_entry_used(&map->entries[i]))
-            return &map->entries[i];
+        if (!gntmap_entry_used(map, i))
+            return i;
     }
 
     DEBUG("(map=%p): all %d entries full",
            map, map->nentries);
-    return NULL;
+    return -1;
 }
 
-static struct gntmap_entry*
-gntmap_find_entry(struct gntmap *map, unsigned long addr)
+static int gntmap_find_entry(struct gntmap *map, unsigned long addr)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
         if (map->entries[i].host_addr == addr)
-            return &map->entries[i];
+            return i;
     }
-    return NULL;
+    return -1;
 }
 
 int
@@ -105,12 +103,13 @@ gntmap_set_max_grants(struct gntmap *map, int count)
 }
 
 static int
-_gntmap_map_grant_ref(struct gntmap_entry *entry, 
+_gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
                       uint32_t domid,
                       uint32_t ref,
                       int writable)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
 
@@ -135,8 +134,9 @@ _gntmap_map_grant_ref(struct gntmap_entry *entry,
 }
 
 static int
-_gntmap_unmap_grant_ref(struct gntmap_entry *entry)
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_unmap_grant_ref op;
     int rc;
 
@@ -160,19 +160,19 @@ int
 gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
 {
     int i, rc;
-    struct gntmap_entry *ent;
+    int idx;
 
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
-        if (ent == NULL) {
+        idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
+        if (idx < 0) {
             printk("gntmap: tried to munmap unknown page\n");
             return -EINVAL;
         }
 
-        rc = _gntmap_unmap_grant_ref(ent);
+        rc = _gntmap_unmap_grant_ref(map, idx);
         if (rc != 0)
             return rc;
     }
@@ -189,7 +189,7 @@ gntmap_map_grant_refs(struct gntmap *map,
                       int writable)
 {
     unsigned long addr;
-    struct gntmap_entry *ent;
+    int idx;
     int i;
 
     DEBUG("(map=%p, count=%" PRIu32 ", "
@@ -206,9 +206,9 @@ gntmap_map_grant_refs(struct gntmap *map,
         return NULL;
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_free_entry(map);
-        if (ent == NULL ||
-            _gntmap_map_grant_ref(ent,
+        idx = gntmap_find_free_entry(map);
+        if (idx < 0 ||
+            _gntmap_map_grant_ref(map, idx,
                                   addr + PAGE_SIZE * i,
                                   domids[i * domids_stride],
                                   refs[i],
@@ -233,15 +233,13 @@ gntmap_init(struct gntmap *map)
 void
 gntmap_fini(struct gntmap *map)
 {
-    struct gntmap_entry *ent;
     int i;
 
     DEBUG("(map=%p)", map);
 
     for (i = 0; i < map->nentries; i++) {
-        ent = &map->entries[i];
-        if (gntmap_entry_used(ent))
-            (void) _gntmap_unmap_grant_ref(ent);
+        if (gntmap_entry_used(map, i))
+            (void) _gntmap_unmap_grant_ref(map, i);
     }
 
     xfree(map->entries);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 16:09:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 16:09:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249883.430392 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLEF-0003LZ-A4; Mon, 20 Dec 2021 16:09:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249883.430392; Mon, 20 Dec 2021 16:09:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzLEF-0003LS-78; Mon, 20 Dec 2021 16:09:35 +0000
Received: by outflank-mailman (input) for mailman id 249883;
 Mon, 20 Dec 2021 16:09:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=DqEV=RF=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzLCG-00055x-Mv
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 16:07:32 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e99c05da-61ae-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 17:07:21 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0B0E61F3B3;
 Mon, 20 Dec 2021 16:07:21 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D252713D6B;
 Mon, 20 Dec 2021 16:07:20 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kBDxMTiqwGEUTAAAMHmgww
 (envelope-from <jgross@suse.com>); Mon, 20 Dec 2021 16:07:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e99c05da-61ae-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640016441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2zdQgzlV0Lz7UQXRFdnEwu37UxJwIePFbmpJgrcmrrs=;
	b=cIrE1NZbVnDGYkqyRper8jcEWCZAJdk3Br9r1GRzza5OM5fPT4kXfv0ngZHUl4fn0iZ6tW
	h+sq6ZsGnP6RsLm13byTnCo1CZ/lDlcTRnxfrTeHnM0uZeZ0+Vt8185UPLyFFrxJrZ/wCp
	aTJZL567BK5Z4U1aCMcRfCtgiowLuQA=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v2 10/10] mini-os: modify grant mappings to work in PVH mode
Date: Mon, 20 Dec 2021 17:07:16 +0100
Message-Id: <20211220160716.4159-11-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211220160716.4159-1-jgross@suse.com>
References: <20211220160716.4159-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

For being able to use the grant mapping interface in PVH mode some
changes are required, as the guest needs to specify a physical address
in the hypercall interface.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 gntmap.c         | 81 ++++++++++++++++++++++++++++++++++--------------
 include/gntmap.h |  1 +
 2 files changed, 59 insertions(+), 23 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index 7ae8fe6..126b04f 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -32,6 +32,7 @@
 
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
+#include <mini-os/e820.h>
 #include <mini-os/xmalloc.h>
 #include <errno.h>
 #include <xen/grant_table.h>
@@ -97,11 +98,42 @@ gntmap_set_max_grants(struct gntmap *map, int count)
     if (map->entries == NULL)
         return -ENOMEM;
 
+#ifndef CONFIG_PARAVIRT
+    map->start_pfn = e820_get_reserved_pfns(count);
+#endif
+
     memset(map->entries, 0, sizeof(struct gntmap_entry) * count);
     map->nentries = count;
     return 0;
 }
 
+static int
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
+{
+    struct gntmap_entry *entry = map->entries + idx;
+    struct gnttab_unmap_grant_ref op;
+    int rc;
+
+#ifdef CONFIG_PARAVIRT
+    op.host_addr    = (uint64_t) entry->host_addr;
+#else
+    op.host_addr    = (uint64_t)(map->start_pfn + idx) << PAGE_SHIFT;
+#endif
+    op.dev_bus_addr = 0;
+    op.handle       = entry->handle;
+
+    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
+    if (rc != 0 || op.status != GNTST_okay) {
+        printk("GNTTABOP_unmap_grant_ref failed: "
+               "returned %d, status %" PRId16 "\n",
+               rc, op.status);
+        return rc != 0 ? rc : op.status;
+    }
+
+    entry->host_addr = 0;
+    return 0;
+}
+
 static int
 _gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
@@ -112,10 +144,17 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
     struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
+#ifndef CONFIG_PARAVIRT
+    unsigned long pfn = map->start_pfn + idx;
+#endif
 
     op.ref = (grant_ref_t) ref;
     op.dom = (domid_t) domid;
+#ifdef CONFIG_PARAVIRT
     op.host_addr = (uint64_t) host_addr;
+#else
+    op.host_addr = (uint64_t)pfn << PAGE_SHIFT; 
+#endif
     op.flags = GNTMAP_host_map;
     if (!writable)
         op.flags |= GNTMAP_readonly;
@@ -128,31 +167,18 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
         return rc != 0 ? rc : op.status;
     }
 
-    entry->host_addr = host_addr;
-    entry->handle = op.handle;
-    return 0;
-}
-
-static int
-_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
-{
-    struct gntmap_entry *entry = map->entries + idx;
-    struct gnttab_unmap_grant_ref op;
-    int rc;
-
-    op.host_addr    = (uint64_t) entry->host_addr;
-    op.dev_bus_addr = 0;
-    op.handle       = entry->handle;
-
-    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
-    if (rc != 0 || op.status != GNTST_okay) {
-        printk("GNTTABOP_unmap_grant_ref failed: "
-               "returned %d, status %" PRId16 "\n",
-               rc, op.status);
-        return rc != 0 ? rc : op.status;
+#ifndef CONFIG_PARAVIRT
+    rc = do_map_frames(host_addr, &pfn, 1, 0, 0, DOMID_SELF, NULL,
+                       writable ? L1_PROT : L1_PROT_RO);
+    if ( rc )
+    {
+        _gntmap_unmap_grant_ref(map, idx);
+        return rc;
     }
+#endif
 
-    entry->host_addr = 0;
+    entry->host_addr = host_addr;
+    entry->handle = op.handle;
     return 0;
 }
 
@@ -165,6 +191,10 @@ gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
+#ifndef CONFIG_PARAVIRT
+    unmap_frames(start_address, count);
+#endif
+
     for (i = 0; i < count; i++) {
         idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
         if (idx < 0) {
@@ -242,6 +272,11 @@ gntmap_fini(struct gntmap *map)
             (void) _gntmap_unmap_grant_ref(map, i);
     }
 
+#ifndef CONFIG_PARAVIRT
+    e820_put_reserved_pfns(map->start_pfn, map->nentries);
+    map->start_pfn = 0;
+#endif
+
     xfree(map->entries);
     map->entries = NULL;
     map->nentries = 0;
diff --git a/include/gntmap.h b/include/gntmap.h
index fde53f3..d3d7e88 100644
--- a/include/gntmap.h
+++ b/include/gntmap.h
@@ -10,6 +10,7 @@
 struct gntmap {
     int nentries;
     struct gntmap_entry *entries;
+    unsigned long start_pfn;
 };
 
 int
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 17:14:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 17:14:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249921.430407 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMEa-0002l7-OE; Mon, 20 Dec 2021 17:14:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249921.430407; Mon, 20 Dec 2021 17:14:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMEa-0002l0-Kz; Mon, 20 Dec 2021 17:14:00 +0000
Received: by outflank-mailman (input) for mailman id 249921;
 Mon, 20 Dec 2021 17:13:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=D44S=RF=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1mzMEZ-0002ku-DI
 for xen-devel@lists.xen.org; Mon, 20 Dec 2021 17:13:59 +0000
Received: from mail-io1-f41.google.com (mail-io1-f41.google.com
 [209.85.166.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36c84863-61b8-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 18:13:57 +0100 (CET)
Received: by mail-io1-f41.google.com with SMTP id b187so14183845iof.11
 for <xen-devel@lists.xen.org>; Mon, 20 Dec 2021 09:13:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36c84863-61b8-11ec-85d3-df6b77346a89
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=9Z86u/eYv90k7dQ52gyj/BqP0l/kowECwRY5YIzP74Y=;
        b=Ku7PhNfztlsHg40t/VM99telGuW02R3x+FjgpMzXQVME/HawF1Bb3bGsv0PaHwMeUm
         XdIYEc1JCu9vd85JNjIRxNTNtNkXnSuo9O6iG5w1kYoecSCCXrgo4oZk7qoZ9gdTLgz2
         3cS91StxUPaLzZRJthKRb4DK7K+yHjqjm2zW54WjlwRh0JVwJSY2xmRSLmknErb2nBcP
         4E5D0IvzAAQVxjghMI9wOizKp0nBrrfiIg78juHDMcI1jBwefpR+u6lqzuRq32CAUeKJ
         25XpYP0VxmCQ/PzhRiWwvx+/cELxMB6fDbjl4ypJg6F2c56HpWH5rG29i8n4X4BMDr72
         WgFg==
X-Gm-Message-State: AOAM530gCbTh9vnWVF1+t1bcCR2jE2zeQfBnq6IdgA9Znj5pI//0pIXf
	JWFMhfZNQSIu06ApyNuAat4u6UarYviHJraLubAEpcT7zgSdLw==
X-Google-Smtp-Source: ABdhPJza7/162JEYtwTrJZzxa5Cj4SKBusS0LTjdBRO5Ju33CFQ7ocBu5BOyBBCSGp36EVCTPWJA5aTQtbQul7AtKdo=
X-Received: by 2002:a6b:7f04:: with SMTP id l4mr8666403ioq.62.1640020435440;
 Mon, 20 Dec 2021 09:13:55 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
In-Reply-To: <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Tue, 21 Dec 2021 01:13:43 +0800
Message-ID: <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

First of all, thank you for your quick response, Juergen and Roger.
I just realized that I run into mail forwarding issue from sourceforge
mail alias service, and only found the responses when I checked the
list archive. As a result, I have to manually merge Roger's response
to reply...

> > I have to admit that this trial process is blind as I have no idea
> > which component in the combo is to be blamed. Is it a bug in the
> > backend-driver, frontend-driver or the hypervisor itself? Or due to
> > incompatible versions? Any suggestion on other diagnose ideas (e.g.
> > debug logs) will be welcome, while I work on the planned experiments.
>
> This is a bug in FreeBSD netfront, so no matter which Linux or Xen
> version you use.
>
> Does it make a difference if you disable TSO and LRO from netfront?
>
> $ ifconfig xn0 -tso -lro
It does not, the fatal error still show up after this command.

>
> Do you have instructions I can follow in order to try to reproduce the
> issue?
I don't know if there are any special details in my setup.
Hopefully I don't miss anything useful:
1. Build a TrueNAS 12.0U7 DOM-U by flushing the OS image into a vdisk
2. Create / import a zfs pool to the DOM-U
3. Create and share some file based iSCSI extents on the pool
4. Mount the iSCSI extent through some initiator clients.
The domU xn0 should be disabled immediately after step #4.

I omitted all operational details with the assumption that you are familiar
with TrueNAS and iSCSI setup.
For step #4, I can reproduce it with both ipxe initiator and the win7
built-in client.
As a result, I assume the client version does not matter.
For #2, I actually have a physical disk and controller assigned to DOM-U.
But I suspect this is probably irrelevant.
For #3, I'm not sure if the content in the extent matters.
So far I have been testing the same extent, which is formatted as an NTFS disk.

>
> Thanks, Roger.

> >
> > Thanks,
> > G.R.


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 17:14:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 17:14:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249923.430418 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMEu-00038X-4w; Mon, 20 Dec 2021 17:14:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249923.430418; Mon, 20 Dec 2021 17:14:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMEu-00038Q-1o; Mon, 20 Dec 2021 17:14:20 +0000
Received: by outflank-mailman (input) for mailman id 249923;
 Mon, 20 Dec 2021 17:14:19 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzMEt-00037y-6K
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 17:14:19 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzMEq-0001Sw-J8; Mon, 20 Dec 2021 17:14:16 +0000
Received: from [54.239.6.189] (helo=[192.168.16.72])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzMEq-0006El-8h; Mon, 20 Dec 2021 17:14:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=kT5/DuaZntvxRNXMDV0ddY2qC25IBFOAs/5OhpObHRM=; b=RH9aPOwgA5sO65mu11Lj+EkDlU
	QzKG0x6AsCnR1NOOy84tdZZwQELOB1OcuAAn/KPH574R+g0zOsu49D5RYyY8cN5264y1sLpv2eE3j
	7zIxRI50nVmbie8G5KqZif+R5uNcrkO0mrQLA6wjHcE1w2hJaD4Ck8wFKOxVWnFcB9oI=;
Message-ID: <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
Date: Mon, 20 Dec 2021 18:14:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Stefano Stabellini <sstabellini@kernel.org>,
 Juergen Gross <jgross@suse.com>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
 <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
 <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 18/12/2021 00:00, Stefano Stabellini wrote:
> On Fri, 17 Dec 2021, Juergen Gross wrote:
>> On 17.12.21 11:41, Julien Grall wrote:
>>> Hi Juergen,
>>>
>>> On 17/12/2021 08:50, Juergen Gross wrote:
>>>> On 17.12.21 08:45, Jan Beulich wrote:
>>>>> On 17.12.2021 06:34, Juergen Gross wrote:
>>>>>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>>>>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>>>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is
>>>>>>>>>> not a
>>>>>>>>>> problem in reality because the max physical address size is
>>>>>>>>>> only 40-bit
>>>>>>>>>> for aarch32 guests, so 32-bit are always enough to return the
>>>>>>>>>> highest
>>>>>>>>>> page in memory for 32-bit guests.
>>>>>>>>>
>>>>>>>>> You are aware that this isn't the guest's max page, but the
>>>>>>>>> host's?
>>>>>>>
>>>>>>> I can see now that you meant to say that, no matter what is the max
>>>>>>> pseudo-physical address supported by the VM, XENMEM_maximum_ram_page
>>>>>>> is
>>>>>>> supposed to return the max memory page, which could go above the
>>>>>>> addressibility limit of the VM.
>>>>>>>
>>>>>>> So XENMEM_maximum_ram_page should potentially be able to return
>>>>>>> (1<<44)
>>>>>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>>>>>
>>>>>>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>>>>>>> 64-bit on a 64-bit hypervisor (which I think it would be a very rare
>>>>>>> configuration on ARM.)
>>>>>>>
>>>>>>> Then it looks like XENMEM_maximum_ram_page needs to be able to
>>>>>>> return a
>>>>>>> value > 32-bit when called by a 32-bit guest.
>>>>>>>
>>>>>>> The hypercall ABI follows the ARM C calling convention, so a 64-bit
>>>>>>> value should be returned using r0 and r1. But looking at
>>>>>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever sets
>>>>>>> r1
>>>>>>> today. Only r0 is set, so effectively we only support 32-bit return
>>>>>>> values on aarch32 and for aarch32 guests.
>>>>>>>
>>>>>>> In other words, today all hypercalls on ARM return 64-bit to 64-bit
>>>>>>> guests and 32-bit to 32-bit guests. Which in the case of memory_op
>>>>>>> is
>>>>>>> "technically" the correct thing to do because it matches the C
>>>>>>> declaration in xen/include/xen/hypercall.h:
>>>>>>>
>>>>>>> extern long
>>>>>>> do_memory_op(
>>>>>>>        unsigned long cmd,
>>>>>>>        XEN_GUEST_HANDLE_PARAM(void) arg);
>>>>>>>
>>>>>>> So...  I guess the conclusion is that on ARM do_memory_op should
>>>>>>> return
>>>>>>> "long" although it is not actually enough for a correct
>>>>>>> implementation
>>>>>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>>>>>
>>>>>>
>>>>>> Hence my suggestion to check the return value of _all_ hypercalls to
>>>>>> be
>>>>>> proper sign extended int values for 32-bit guests. This would fix all
>>>>>> potential issues without silently returning truncated values.
>>>>>
>>>>> Are we absolutely certain we have no other paths left where a possibly
>>>>> large unsigned values might be returned? In fact while
>>>>> compat_memory_op() does the necessary saturation, I've never been fully
>>>>> convinced of this being the best way of dealing with things. The range
>>>>> of error indicators is much smaller than [-INT_MIN,-1], so almost
>>>>> double the range of effectively unsigned values could be passed back
>>>>> fine. (Obviously we can't change existing interfaces, so this mem-op
>>>>> will need to remain as is.)
>>>>
>>>> In fact libxenctrl tries do deal with this fact by wrapping a memory_op
>>>> for a 32-bit environment into a multicall. This will work fine for a
>>>> 32-bit Arm guest, as xen_ulong_t is a uint64 there.
>>>>
>>>> So do_memory_op should return long on Arm, yes. OTOH doing so will
>>>> continue to be a problem in case a 32-bit guest doesn't use the
>>>> multicall technique for handling possible 64-bit return values.
>>>>
>>>> So I continue to argue that on Arm the return value of a hypercall
>>>> should be tested to fit into 32 bits.
>>>
>>> It would make sense. But what would you return if the value doesn't fit?
>>
>> I guess some errno value would be appropriate, like -EDOM, -ERANGE or
>> -E2BIG.
> 
> This seems to be better than the alternative below as it is a lot
> simpler.

We would still need to special case XENMEM_maximum_reservation (or 
rework the implementation of the sub-op) because the value returned is 
an unsigned long. So technically, the unsigned value for -EDOM & co 
could be interpreted as the maximum host frame number.

I also would like to see the hypercall returning 'int' when they are 
only meant to return 32-bit value. This will make easier to spot someone 
that decide to return a 64-bit value.

> 
> 
>>>> The only really clean alternative
>>>> would be to have separate hypercall function classes for Arm 32- and
>>>> 64-bit guests (which still could share most of the functions by letting
>>>> those return "int"). This would allow to use the 64-bit variant even for
>>>> 32-bit guests in multicall (fine as the return field is 64-bit wide),
>>>> and a probably saturating compat version for the 32-bit guest direct
>>>> hypercall.
>>>
>>> I am not entirely sure to understand this proposal. Can you clarify it?
>>
>> 1. In patch 5 modify the hypercall table by adding another column, so
>>     instead of:
>>     +table:           pv32     pv64     hvm32    hvm64    arm
>>     use:
>>     +table:           pv32     pv64     hvm32    hvm64    arm32    arm64
>>
>> 2. Let most of the hypercalls just return int instead of long:
>>     +rettype: do int
>>
>> 3. Have an explicit 64-bit variant of memory_op (the 32-bit one is the
>>     compat variant existing already):
>>     +rettype: do64 long
>>     +prefix: do64 PREFIX_hvm
>>     +memory_op(unsigned long cmd, void *arg)
>>
>> 4. Use the appropriate calls in each column:
>>     +memory_op         compat   do64     hvm      hvm      compat  do64
>>
>> 5. In the Arm hypercall trap handler do:
>>     if ( is_32bit_domain(current->domain) )
>>         call_handlers_arm32(...);
>>     else
>>         call_handlers_arm64(...);
>>
>> 6. In the multicall handler always do:
>>     call_handlers_arm64(...);
I am probably missing something. But why do we need to have separate 
call handlers for arm32/arm64?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 18:02:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 18:02:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249961.430447 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMzT-0001h7-7g; Mon, 20 Dec 2021 18:02:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249961.430447; Mon, 20 Dec 2021 18:02:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzMzT-0001h0-3w; Mon, 20 Dec 2021 18:02:27 +0000
Received: by outflank-mailman (input) for mailman id 249961;
 Mon, 20 Dec 2021 18:02:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzMzS-0001gq-6Q; Mon, 20 Dec 2021 18:02:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzMzS-0002Jh-39; Mon, 20 Dec 2021 18:02:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzMzR-0007qH-OX; Mon, 20 Dec 2021 18:02:25 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzMzR-0001wm-Nv; Mon, 20 Dec 2021 18:02:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Crxb1sRVhCk9Ef+/m5FD6LHdh47q5RTo+cL+JkcqTRY=; b=hgWGhKImOEOBiZIT6ppt+sUHUW
	8UXmidnjirfB45CJF9E1OfoOGDCmmduQ30QFoL63ygQgdlc3FytIMuHb9qnZvWonvOkIgqMjnL0fR
	yFKHoYPQVNdWh/gtOfaFUnLV5WYBmTg1lha4uQB7uVLe2E+Lc57jvsUOi4AGQyNZ3vac=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167489-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167489: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=212a33d3b0c65ae2583bb1d06cb140cd0890894c
X-Osstest-Versions-That:
    qemuu=90978e15bc9a23c208b25bf7ea697a5d0925562b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 18:02:25 +0000

flight 167489 qemu-mainline real [real]
flight 167493 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167489/
http://logs.test-lab.xenproject.org/osstest/logs/167493/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail pass in 167493-retest

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 167475

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167475
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167475
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167475
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167475
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167475
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167475
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167475
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167475
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                212a33d3b0c65ae2583bb1d06cb140cd0890894c
baseline version:
 qemuu                90978e15bc9a23c208b25bf7ea697a5d0925562b

Last test of basis   167475  2021-12-18 04:56:51 Z    2 days
Testing same since   167489  2021-12-20 05:08:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bennée <alex.bennee@linaro.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Philippe Mathieu-Daudé <f4bug@amsat.org>
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  fail    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   90978e15bc..212a33d3b0  212a33d3b0c65ae2583bb1d06cb140cd0890894c -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 18:12:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 18:12:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249970.430458 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzN9K-0003Gg-8A; Mon, 20 Dec 2021 18:12:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249970.430458; Mon, 20 Dec 2021 18:12:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzN9K-0003GZ-4i; Mon, 20 Dec 2021 18:12:38 +0000
Received: by outflank-mailman (input) for mailman id 249970;
 Mon, 20 Dec 2021 18:12:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=CBxd=RF=epam.com=prvs=298802dd99=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mzN9I-0003GT-Jv
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 18:12:37 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 66103fef-61c0-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 19:12:32 +0100 (CET)
Received: from pps.filterd (m0174676.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BKI36qa022368;
 Mon, 20 Dec 2021 18:12:22 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d2vej8kgm-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 20 Dec 2021 18:12:21 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR2PR03MB5354.eurprd03.prod.outlook.com (2603:10a6:101:28::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Mon, 20 Dec
 2021 18:12:16 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.020; Mon, 20 Dec 2021
 18:12:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 66103fef-61c0-11ec-85d3-df6b77346a89
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UXs0Hx4hzKyyQ/mp1PdGBZg9Z/jqbllOya+KVBjQOTgsT/n11xIWIJ5fFkmSE6obHv+BgcAjtl8VBHzIUwuL24Cg+X5ZsmZLlGfatpOauuBWzQzI3ShT7PO7gNWGuhgcnSdRqMtTRoamZZc1uzvM7m11lT799AOGjXGnyO+EO2ESx+VMEA3uTJAxd1vvmciooTWnae8aDMfil/Qgk6DRDk3cVHGLHSed1TaTDrPx7g+Y2ENnJoy7Hi08wsSNtVC36Ybd4aogUZIBteO7aUc2N5rHF1kikRHoko6OQ3k4qSoEj3V3WZ4glE70RmY9UF69wWviGRERkQcQxaEuepH0og==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=e3ZwHBIC4ASGlC74Me+Rzf7ijqWXi3nDUvPrZ87PfWU=;
 b=fiVwdDlOv+gk4+HJMNKD6zKbCe6WYvS/I16vSjneaD7NgNMy36IuGWQYfQNo88S2ySJyN6aaXeKx4eIrYb2gkbiqP/CEbkaTIbVhOo0a8lXV2n41JGWAJ/DInezqSc8Z13XOx85Da+lb5gOgrX0QxG9J8XZzIxE9N4RxmiQQ27DYUmLeNFB8y1ufsc7NAz4dtZbWEGnJt2U30ihBOWwx7jU35XmYR59byvK+X0t7BPnJbAK+J+X/KWIUzmjV52ZsLTBQUsyWFHKsN3WrfvEmxU8YWoEIoIFKDyykWePFbRnUa6jdti0tbjbQ0Bl+hS1dt4oDuNkB5Q3Ys9PMP7PCSw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=e3ZwHBIC4ASGlC74Me+Rzf7ijqWXi3nDUvPrZ87PfWU=;
 b=Io65+Lhtv/xvxUKZt/Ini3fQIot+vvy/oleI6FhBpvEQqEzkRy58mFNBCwLCznnw8phyxq9vvxtrSOePYjMVo6fHUdvNF9GlyCYg2ylQsuejAdVSZxO503c9SipROPviSiOwxA1usA/cCvsBj/saCBgZpKj8W+mNV+N2QR0q8zNccEpSK5xYCmSrR8Ox2lqpFPXCHixd9Y3jWqkFy71VlJP1Ux8+tzOGM3Ia11Ew1rGLmjwqQ11ynERZvuGCHiVGQR8tIBYlAtlUKm9R1iQF+LhNfP7tIYePtV6zt3i2vLXbvybH5JtxPQWxAUerb+ifeKT168f+d1gl4z/N7iemXQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJIA=
Date: Mon, 20 Dec 2021 18:12:16 +0000
Message-ID: <20211220181215.GA1702335@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ad6b5f11-8648-44d3-9041-08d9c3e4416f
x-ms-traffictypediagnostic: PR2PR03MB5354:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB53548E835D0D670CEE402CB1E37B9@PR2PR03MB5354.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 mlWcwBOwm+D88zZr7LOjiEzDQG0xBJCyxdfJGUjxjxO3/c3Mt5JahuEbYK4eJI2RhPvJzXWBmOPKYdAdOBunA3TST99KY82UzRWHrWmYvUIJZJeNBaFry7T3oQxS/MxlwoBDXNzRPpSslwUtZhmver0iYkhpOv2I9mQHrK3rcxwtdTepCZ/ywnEuGFzjgY9ejTp7KlRfMMYHRu4Trz0+g9SGFCfXWoIguJ7scl6z9P2A31IaVk0qYoDMXxOoRf35fptWSeHBHkAIvWRQd6ZL9EPjD+8T/2IuCX3UdHbkfv9GFTZF+LplRV7Xkf+bw7yf5EbcoRvBzLgqz2NfkgvqnyqwPlSS0tZpp0UobZMMmQuYLd8EvCoyTiy/1r0fS8Ps1yAZb8ErhUPZIdvsyI2wdmTX41SEVOG8iwa3k0w5q5dqrC4K3joOeF3Tnq67na4pTONZkxz9KfIGMUZ55+kr8qQcIrCx52E2q7u0HOBbzaA9e7n45X3lf0hgFwnYBTjoY4QvJmIaYkAxIUZopH7NvFIORCHSKA7hqmBAhUqw3YledrsXK3DKLsjH2nRwoKswQLkqfqAnFufMXHC5zZb4gquZeLJgpL+RFQb7lWz1lOu55AeoTMD9LnJMwN5G+Kzh7hRmkubjGCzG29nsKCJnDXRclNVtKvHQiWlwOlhMBdaIsbEI5Ay81FzjJ+8huY9LdEtmSiGhn3GSxh/lehkY0hHX7/OG/6Sq69cMAA6157sgoipKmEzM29mc173wwTf8hN2ejEj1/uhgUZhiha/37YOS2YK1P6Q50PZe7NmsGLteag7+2DGStfJgql6Sxcq2
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(2906002)(64756008)(66446008)(5660300002)(66476007)(76116006)(91956017)(66556008)(66946007)(26005)(4326008)(6506007)(8936002)(33716001)(6486002)(508600001)(966005)(71200400001)(6916009)(8676002)(54906003)(86362001)(30864003)(1076003)(9686003)(6512007)(316002)(38100700002)(122000001)(83380400001)(186003)(38070700005)(33656002)(2004002)(559001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?BmxSPLaZw3oWa8/rQloVbe1/eh6qsUXQNagDnJMWbrp5k+v/V+5toSbPqtoO?=
 =?us-ascii?Q?eoPj4BiAXi0ZtC4W5tyoAEOo/u0S0NVfqn83Ndgc2fw/Nbl7ZXYMaAXw4r5z?=
 =?us-ascii?Q?TMkSMQUdZFGPQPMoCew7FFhABujon4GRahzKkhuG5jGlFn79HCeR2aWugbh3?=
 =?us-ascii?Q?HHRQHr6AYg5iFxB138BLxqaDgs9XzRSR2go8HfL1I+v4c/9/xqitLE02BGMn?=
 =?us-ascii?Q?2tMNTBzdFCItqxaJs4r8zWAuVJ2uMgupDdu8Ve/2GEMBvHgMyGLgsrLwIwTh?=
 =?us-ascii?Q?HHUzqbF2W0v/bo16NQtseTx6rRf+J2hiCd70syPz7g9hmInu+7hdHOd5V93I?=
 =?us-ascii?Q?06dAsn0vez4th1D4ESikRyK/XQ9DlIQA0c9KCe8+ALlJsKiakQi8a9brymex?=
 =?us-ascii?Q?0iyk2pAv04KUBq17gvwoRZ1BwHgjM+sI70epVs5uRatx3xI31WiazhW/8svk?=
 =?us-ascii?Q?8NLS5DNbZUiMfnTBLt59IGQgHSW3hb/Kf20Iu0oSFGLZMFdEYesbcALdQfFd?=
 =?us-ascii?Q?j+PfLdnrQE1QFxikxEGIQ9fDZvj5yYQSj1ZC3idvFWKLNhmcqnFssuIiLrZ0?=
 =?us-ascii?Q?ia4AJNWfPrSaEaHmnx5lAmn1weM3H03Y+KPl6cYY0FMH+Jp89nqsu+HDK/Jf?=
 =?us-ascii?Q?5RpXGSFMUehyP4fRKQW+a8NERYQCAZCUMzx3Y2G+Jnnu6TWVEP2N4ORiGOIP?=
 =?us-ascii?Q?AATscfsPbcgScfzvQYntr2T2GP6alGRbM9o/SCdD3Bf2iSeSgTASaQ5R9xmV?=
 =?us-ascii?Q?Zm9H53xLDav+21Dd8NGtiZetFDGqjDh02a5OHB6ijSfqOqCcgrMFHkd4GAgx?=
 =?us-ascii?Q?NkHSokreXwpJsbWnFQh6rzGjLMqZcN8wdSq4X8uSTrOI5cX74EiiDjKNAIPA?=
 =?us-ascii?Q?sWuTc7iqcU4yZGQUNZIeodEPH2qTvvoaIQ9iOeFB+9cU7vv93C64oKNV99xJ?=
 =?us-ascii?Q?a/jt5ZOGz1QUO7g4wpj5aXS82taS0WkDgE31Zj0rMkSwA3e4vaczieSFOhs/?=
 =?us-ascii?Q?slYe74UWRub6fQcU7kCwMlWLx0EyodnNCbQZBNqJ4BDnSxxT4ucVpRUGvtKG?=
 =?us-ascii?Q?fa8dviSH/KdKfvdE6dWV7fu1NXLeo77wny4jHVARvChiqQVkjvNIzZL193LT?=
 =?us-ascii?Q?u6nA5ImbJHcAO+BkOhq9gmeOe3VRxsR1NV7L8/i+M/Zq6VPU6X1Z0KbV3FqY?=
 =?us-ascii?Q?denGMAP30s8SE119okfTn6boUGi4a5kvlmlkJth8dPOt5Q+Ew1rKedsq01JL?=
 =?us-ascii?Q?RX7XrQIisTS/Wc68b1sI0OcQMfAqWtc135oqhsq1iBUNRcTvKIaU94vlHI+S?=
 =?us-ascii?Q?e9fRPF8b7GEDDtkZ2G811ZE7+1tvMLnGEQl/KnB8Xlh66PcnHoVaM/VLVuHu?=
 =?us-ascii?Q?8p7snQvxnbX8jRikHi3+sH88AQ47sxOoHxAXTmRE6bKotraoxosZ1rfn7SRs?=
 =?us-ascii?Q?o9M8yXCKJvEa7ZEfqT/e323FqRgzJsbCOC9CMsX9MFqGCZFqrFQlM+ZJx0PB?=
 =?us-ascii?Q?j71Hu8B6BWi0KzanF4vR4+owCb7fP34YsCZMkXvX1kclizzhMV+7pG76gB3/?=
 =?us-ascii?Q?SI7gz72cHUr866ZIQAVhGkT3HZenwPYVHhIzz7cvJY3OqZ3hj18dgaqNEugJ?=
 =?us-ascii?Q?WqLDDAEaM2wG3fyFVd0/ymNj0LVh/Fx/4yOk5je8TUabLYBVt9qv+jaqyrm3?=
 =?us-ascii?Q?1jg1s5FLXxunzPttedS79xMMZRc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F65CB8B5DE76EC4286565B9E8018A38A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad6b5f11-8648-44d3-9041-08d9c3e4416f
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2021 18:12:16.6645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: alFveK+RCbaZfD1JCKiC6cuWA//PoTReHzsEzVPPfweb7UrADgbhY3AIPXcTZSaegMDzyierLPaBrwKrQIKecZ+JNFOMXCqjjcdRhyrE2OM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5354
X-Proofpoint-ORIG-GUID: npSuQ-vhL_RozXgoq9vU5HIL3FWdXYIA
X-Proofpoint-GUID: npSuQ-vhL_RozXgoq9vU5HIL3FWdXYIA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-20_08,2021-12-20_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0
 bulkscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 mlxlogscore=999
 clxscore=1015 priorityscore=1501 mlxscore=0 impostorscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112200102

Hi Stefano,

On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > This is the implementation of SCI interface, called SCMI-SMC driver,
> > which works as the mediator between XEN Domains and Firmware (SCP, ATF =
etc).
> > This allows devices from the Domains to work with clocks, resets and
> > power-domains without access to CPG.
> >=20
> > The following features are implemented:
> > - request SCMI channels from ATF and pass channels to Domains;
> > - set device permissions for Domains based on the Domain partial
> > device-tree. Devices with permissions are able to work with clocks,
> > resets and power-domains via SCMI;
> > - redirect scmi messages from Domains to ATF.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >  xen/arch/arm/Kconfig          |   2 +
> >  xen/arch/arm/sci/Kconfig      |  10 +
> >  xen/arch/arm/sci/Makefile     |   1 +
> >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
> >  xen/include/public/arch-arm.h |   1 +
> >  5 files changed, 809 insertions(+)
> >  create mode 100644 xen/arch/arm/sci/Kconfig
> >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> >=20
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > index 186e1db389..02d96c6cfc 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -114,6 +114,8 @@ config SCI
> >  	  support. It allows guests to control system resourcess via one of
> >  	  SCI mediators implemented in XEN.
> > =20
> > +source "arch/arm/sci/Kconfig"
> > +
> >  endmenu
> > =20
> >  menu "ARM errata workaround via the alternative framework"
> > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > new file mode 100644
> > index 0000000000..9563067ddc
> > --- /dev/null
> > +++ b/xen/arch/arm/sci/Kconfig
> > @@ -0,0 +1,10 @@
> > +config SCMI_SMC
> > +	bool "Enable SCMI-SMC mediator driver"
> > +	default n
> > +	depends on SCI
> > +	---help---
> > +
> > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> > +	This feature allows drivers from Domains to work with System
> > +	Controllers (such as power,resets,clock etc.). SCP is used as transpo=
rt
> > +	for communication.
> > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > index 837dc7492b..67f2611872 100644
> > --- a/xen/arch/arm/sci/Makefile
> > +++ b/xen/arch/arm/sci/Makefile
> > @@ -1 +1,2 @@
> >  obj-y +=3D sci.o
> > +obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
> > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> > new file mode 100644
> > index 0000000000..2eb01ea82d
> > --- /dev/null
> > +++ b/xen/arch/arm/sci/scmi_smc.c
> > @@ -0,0 +1,795 @@
> > +/*
> > + * xen/arch/arm/sci/scmi_smc.c
> > + *
> > + * SCMI mediator driver, using SCP as transport.
> > + *
> > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > + * Copyright (C) 2021, EPAM Systems.
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y
> > + * it under the terms of the GNU General Public License as published b=
y
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <asm/sci/sci.h>
> > +#include <asm/smccc.h>
> > +#include <asm/io.h>
> > +#include <xen/bitops.h>
> > +#include <xen/config.h>
> > +#include <xen/sched.h>
> > +#include <xen/device_tree.h>
> > +#include <xen/iocap.h>
> > +#include <xen/init.h>
> > +#include <xen/err.h>
> > +#include <xen/lib.h>
> > +#include <xen/list.h>
> > +#include <xen/mm.h>
> > +#include <xen/string.h>
> > +#include <xen/time.h>
> > +#include <xen/vmap.h>
> > +
> > +#define SCMI_BASE_PROTOCOL                  0x10
> > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > +
> > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > +#define SCMI_SUCCESS              0
> > +#define SCMI_NOT_SUPPORTED      (-1)
> > +#define SCMI_INVALID_PARAMETERS (-2)
> > +#define SCMI_DENIED             (-3)
> > +#define SCMI_NOT_FOUND          (-4)
> > +#define SCMI_OUT_OF_RANGE       (-5)
> > +#define SCMI_BUSY               (-6)
> > +#define SCMI_COMMS_ERROR        (-7)
> > +#define SCMI_GENERIC_ERROR      (-8)
> > +#define SCMI_HARDWARE_ERROR     (-9)
> > +#define SCMI_PROTOCOL_ERROR     (-10)
> > +
> > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > +
> > +#define SCMI_SMC_ID                        "arm,smc-id"
> > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
>=20
> I could find the following SCMI binding in Linux, which describes
> the arm,scmi-smc compatible and the arm,smc-id property:
>=20
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>=20
> However, linux,scmi_mem is not described. Aren't you supposed to read
> the "shmem" property instead? And the compatible string used for this
> seems to be "arm,scmi-shmem".
>=20

We use linux,scmi_mem node to reserve memory, needed for all
channels:

reserved-memory {
    /* reserved region for scmi channels*/
    scmi_memory: linux,scmi_mem@53FF0000 {
        no-map;
        reg =3D <0x0 0x53FF0000 0x0 0x10000>;
    };
};

arm,scmi-shmem node used in shmem property defines only 1 page needed to
the current scmi channel:

cpu_scp_shm: scp-shmem@0x53FF0000 {
    compatible =3D "arm,scmi-shmem";
    reg =3D <0x0 0x53FF0000 0x0 0x1000>;
};

For each Domain reg points to unigue page from linux,scmi_mem region,
assigned to this agent.

>=20
> > +#define SCMI_SHMEM                         "shmem"
> > +
> > +#define HYP_CHANNEL                          0x0
> > +
> > +#define HDR_ID                             GENMASK(7,0)
> > +#define HDR_TYPE                           GENMASK(9, 8)
> > +#define HDR_PROTO                          GENMASK(17, 10)
> > +
> > +/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
> > +#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
> > +
> > +#define FIELD_GET(_mask, _reg)\
> > +    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
> > +#define FIELD_PREP(_mask, _val)\
> > +    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
> > +
> > +typedef struct scmi_msg_header {
> > +    uint8_t id;
> > +    uint8_t type;
> > +    uint8_t protocol;
> > +} scmi_msg_header_t;
> > +
> > +typedef struct scmi_perms_tx {
> > +    uint32_t agent_id;
> > +    uint32_t device_id;
> > +    uint32_t flags;
> > +} scmi_perms_tx_t;
> > +
> > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
> > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
> > +
> > +#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
> > +
> > +struct scmi_shared_mem {
> > +    uint32_t reserved;
> > +    uint32_t channel_status;
> > +    uint32_t reserved1[2];
> > +    uint32_t flags;
> > +    uint32_t length;
> > +    uint32_t msg_header;
> > +    uint8_t msg_payload[];
> > +};
> > +
> > +struct scmi_channel {
> > +    int chan_id;
> > +    int agent_id;
> > +    uint32_t func_id;
> > +    int domain_id;
> > +    uint64_t paddr;
> > +    struct scmi_shared_mem *shmem;
> > +    spinlock_t lock;
> > +    struct list_head list;
> > +};
> > +
> > +struct scmi_data {
> > +    struct list_head channel_list;
> > +    spinlock_t channel_list_lock;
> > +    bool initialized;
> > +    u64 shmem_addr, shmem_size;
> > +};
> > +
> > +static struct scmi_data scmi_data;
> > +
> > +/*
> > + * pack_scmi_header() - packs and returns 32-bit header
> > + *
> > + * @hdr: pointer to header containing all the information on message i=
d,
> > + *    protocol id and type id.
> > + *
> > + * Return: 32-bit packed message header to be sent to the platform.
> > + */
> > +static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
> > +{
> > +    return FIELD_PREP(HDR_ID, hdr->id) |
> > +        FIELD_PREP(HDR_TYPE, hdr->type) |
> > +        FIELD_PREP(HDR_PROTO, hdr->protocol);
> > +}
> > +
> > +/*
> > + * unpack_scmi_header() - unpacks and records message and protocol id
> > + *
> > + * @msg_hdr: 32-bit packed message header sent from the platform
> > + * @hdr: pointer to header to fetch message and protocol id.
> > + */
> > +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_heade=
r_t *hdr)
> > +{
> > +    hdr->id =3D FIELD_GET(HDR_ID, msg_hdr);
> > +    hdr->type =3D FIELD_GET(HDR_TYPE, msg_hdr);
> > +    hdr->protocol =3D FIELD_GET(HDR_PROTO, msg_hdr);
> > +}
> > +
> > +static inline int channel_is_free(struct scmi_channel *chan_info)
> > +{
> > +    return ( chan_info->shmem->channel_status
> > +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
>=20
> Does this need a memory barrier? Or not, because the other end always
> runs on the same CPU at a different execution level so the
> channel_status would be always guaranteed to be read as updated?
>=20

It don't because the other end runs on the same CPU. Other mediator
implemetaions, which uses different areas may need memory barrier.

>=20
> > +}
> > +
> > +static int send_smc_message(struct scmi_channel *chan_info,
> > +                            scmi_msg_header_t *hdr, void *data, int le=
n)
> > +{
> > +    struct arm_smccc_res resp;
> > +    int ret;
> > +
> > +    printk(XENLOG_DEBUG "scmi: status =3D%d len=3D%d\n",
> > +           chan_info->shmem->channel_status, len);
> > +    printk(XENLOG_DEBUG "scmi: header id =3D %d type =3D %d, proto =3D=
 %d\n",
> > +           hdr->id, hdr->type, hdr->protocol);
> > +
> > +    ret =3D channel_is_free(chan_info);
> > +    if ( IS_ERR_VALUE(ret) )
> > +        return ret;
> > +
> > +    chan_info->shmem->channel_status =3D 0x0;
> > +    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be =
set */
> > +    chan_info->shmem->flags =3D 0x0;
> > +    chan_info->shmem->length =3D sizeof(chan_info->shmem->msg_header) =
+ len;
> > +    chan_info->shmem->msg_header =3D pack_scmi_header(hdr);
> > +
> > +    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
> > +           chan_info->shmem);
> > +    if ( len > 0 && data )
> > +        memcpy((void *)(chan_info->shmem->msg_payload), data, len);
>=20
> Again, here we don't need a barrier because it is implicit in the SMC?
>=20

As I mentioned before, the other end runs on the same CPU.

> Don't we need to check that "len" fits in the shared memory?
>=20

I think it's a good point. I'll add len check in v2.

>=20
> > +    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->cha=
n_id,
> > +                  &resp);
> > +
> > +    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a=
0));
> > +
> > +    if ( resp.a0 )
> > +        return -EOPNOTSUPP;
>=20
> Why is that?
>=20

This change was presented in kernel by Sudeep Holla in commit:
f7199cf489027ae38a9a82312d13025f7aefa0b8

However, link posted in the commit:
https://lore.kernel.org/r/20200417103232.6896-1-sudeep.holla@arm.com

Leads to slightly different patch:

+	if (res.a0 =3D=3D SMCCC_RET_NOT_SUPPORTED)
+		return -EOPNOTSUPP;
+	else if (res.a0)
+		return -EINVAL;
+	return 0;

I don't know why it differs from the original commit, but I'll check and pl=
ace
the correct implementation in v2.

>=20
> > +    return 0;
> > +}
> > +
> > +static int check_scmi_status(int scmi_status)
> > +{
> > +    if ( scmi_status =3D=3D SCMI_SUCCESS )
> > +        return 0;
> > +
> > +    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
> > +
> > +    switch ( scmi_status )
> > +    {
> > +    case SCMI_NOT_SUPPORTED:
> > +        return -EOPNOTSUPP;
> > +    case SCMI_INVALID_PARAMETERS:
> > +        return -EINVAL;
> > +    case SCMI_DENIED:
> > +        return -EACCES;
> > +    case SCMI_NOT_FOUND:
> > +        return -ENOENT;
> > +    case SCMI_OUT_OF_RANGE:
> > +        return -ERANGE;
> > +    case SCMI_BUSY:
> > +        return -EBUSY;
> > +    case SCMI_COMMS_ERROR:
> > +        return -ENOTCONN;
> > +    case SCMI_GENERIC_ERROR:
> > +        return -EIO;
> > +    case SCMI_HARDWARE_ERROR:
> > +        return -ENXIO;
> > +    case SCMI_PROTOCOL_ERROR:
> > +        return -EBADMSG;
> > +    }
> > +
> > +    return -EINVAL;
> > +}
> > +
> > +static int get_smc_response(struct scmi_channel *chan_info,
> > +                            scmi_msg_header_t *hdr, void *data, int le=
n)
> > +{
> > +    int recv_len;
> > +    int ret;
> > +
> > +    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
> > +
> > +    ret =3D channel_is_free(chan_info);
> > +    if ( IS_ERR_VALUE(ret) )
> > +        return ret;
>=20
> I am not familiar with the spec (do you have a link?) but is it expected
> that the channel is "free" when actually we want to read a message on
> the channel?
>=20

Here is the link https://developer.arm.com/documentation/den0056/latest
Figure 6 in Section 5.1.1.
Caller marks channel as busy, then callee process message and marks channel=
 as free.
We are implementing polling based communication flow.

>=20
>=20
> > +    recv_len =3D chan_info->shmem->length - sizeof(chan_info->shmem->m=
sg_header);
> > +
> > +    if ( recv_len < 0 )
> > +    {
> > +        printk(XENLOG_ERR
> > +               "scmi: Wrong size of smc message. Data may be invalid\n=
");
> > +        return -EINVAL;
> > +    }
> > +
> > +    if ( recv_len > len )
> > +    {
> > +        printk(XENLOG_ERR
> > +               "scmi: Not enough buffer for message %d, expecting %d\n=
",
> > +               recv_len, len);
> > +        return -EINVAL;
> > +    }
> > +
> > +    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
> > +
> > +    if ( recv_len > 0 )
> > +    {
> > +        memcpy(data, chan_info->shmem->msg_payload, recv_len);
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t=
 *hdr, void *tx_data, int tx_size,
> > +                       void *rx_data, int rx_size)
> > +{
> > +    int ret =3D 0;
> > +
> > +    if ( !hdr )
> > +        return -EINVAL;
> > +
> > +    spin_lock(&channel->lock);
> > +
> > +    ret =3D send_smc_message(channel, hdr, tx_data, tx_size);
> > +    if ( ret )
> > +        goto clean;
> > +
> > +    ret =3D get_smc_response(channel, hdr, rx_data, rx_size);
> > +clean:
> > +    spin_unlock(&channel->lock);
> > +
> > +    return ret;
> > +}
> > +
> > +static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
> > +{
> > +    struct scmi_channel *curr;
> > +    bool found =3D false;
> > +
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
>=20
> please use parenthesis around the inner if (also in other places)
>=20

Thank you for the remark. I will fix it in v2.

>=20
> > +        if ( curr->chan_id =3D=3D chan_id )
> > +        {
> > +            found =3D true;
> > +            break;
> > +        }
> > +
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +    if ( found )
> > +        return curr;
> > +
> > +    return NULL;
> > +}
> > +
> > +static struct scmi_channel *get_channel_by_domain(uint8_t domain_id)
>=20
> Use domid_t for domain ids.

Thanks, I will fix it in v2.
>=20
> Also, wouldn't it be better to implement it as:
>=20
> static inline struct scmi_channel *get_channel_by_domain(struct domain *d=
) {
>     return d->arch.sci
> }
>=20
That's a good point. I will take a look on it and fix in v2.
>=20
> > +{
> > +    struct scmi_channel *curr;
> > +    bool found =3D false;
> > +
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > +        if ( curr->domain_id =3D=3D domain_id )
> > +        {
> > +            found =3D true;
> > +            break;
> > +        }
> > +
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +    if ( found )
> > +        return curr;
> > +
> > +    return NULL;
> > +}
> > +
> > +static struct scmi_channel *aquire_scmi_channel(int domain_id)
> > +{
> > +    struct scmi_channel *curr;
> > +    bool found =3D false;
> > +
> > +    ASSERT(domain_id !=3D DOMID_INVALID && domain_id >=3D 0);
> > +
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > +        if ( (curr->domain_id =3D=3D DOMID_INVALID)
> > +            && (curr->chan_id !=3D HYP_CHANNEL) )
>=20
> If you use DOMID_XEN for HYP_CHANNEL, then this check becomes more
> intuitive
>=20

We do not have direct relation between channel id and domain id.
One channel id can be reused by different domain_ids. So from my standpoint=
,
DOMID_XEN doesn't fit here.

>=20
> > +        {
> > +            curr->domain_id =3D domain_id;
> > +            found =3D true;
> > +            break;
> > +        }
> > +
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +    if ( found )
> > +        return curr;
> > +
> > +    return NULL;
> > +}
> > +
> > +static void relinquish_scmi_channel(struct scmi_channel *channel)
> > +{
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    ASSERT(channel !=3D NULL);
>=20
> the ASSERT could be before the spin_lock
>=20

Thank you. I will fix it in v2.

>=20
> > +    channel->domain_id =3D DOMID_INVALID;
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +}
> > +
> > +static struct scmi_channel *smc_create_channel(uint8_t chan_id,
> > +                                               uint32_t func_id, uint6=
4_t addr)
> > +{
> > +    struct scmi_channel *channel;
> > +    mfn_t mfn;
> > +
> > +    channel =3D get_channel_by_id(chan_id);
> > +    if ( channel )
> > +        return ERR_PTR(EEXIST);
> > +
> > +    channel =3D xmalloc(struct scmi_channel);
> > +    if ( !channel )
> > +        return ERR_PTR(ENOMEM);
> > +
> > +    channel->chan_id =3D chan_id;
> > +    channel->func_id =3D func_id;
> > +    channel->domain_id =3D DOMID_INVALID;
>=20
> I take you are using DOMID_INVALID to mark a channel used by Xen itself?
> If so, then DOMID_XEN would be more appropriate.
>=20

I use DOMID_INVALID to mark channel as free.

>=20
> > +    mfn =3D maddr_to_mfn(addr);
> > +    channel->shmem =3D vmap(&mfn, 1);
>=20
> One thing to be careful is the mapping attributes, for a couple of
> reasons. As you might be aware, the ARM architecture forbids mismatching
> attributes for mapping memory in different places in the system. So the
> attributes that we use here must be the same used by the firmware
> (and/or the guest.)
>=20
> The second reason to be careful is that in the bindings example
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml the shared
> memory is "mmio-sram", which is special. It is not supposed to be normal
> memory, but it is OK to map it cacheable. Still, it might be more
> appropriate to use ioremap_cache.
>=20

Originally, I used vmap here to have memcpy and it works fine in our
setup. But I will do some research and email you with the results.

>=20
> > +    if ( !channel->shmem )
> > +    {
> > +        xfree(channel);
> > +        return ERR_PTR(ENOMEM);
> > +    }
> > +
> > +    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->sh=
mem);
> > +    channel->paddr =3D addr;
> > +    channel->shmem->channel_status =3D SCMI_SHMEM_CHAN_STAT_CHANNEL_FR=
EE;
> > +    spin_lock_init(&channel->lock);
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    list_add(&channel->list, &scmi_data.channel_list);
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +    return channel;
> > +}
> > +
> > +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint6=
4_t len)
> > +{
> > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > +}
> > +
> > +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
> > +                                     uint64_t len)
> > +{
> > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > +}
> > +
> > +static int dt_update_domain_range(struct domain *d, uint64_t addr,
> > +                                  uint64_t size)
> > +{
> > +    struct dt_device_node *shmem_node;
> > +    __be32 *hw_reg;
> > +    const struct dt_property *pp;
> > +    uint32_t len;
> > +
> > +    shmem_node =3D dt_find_compatible_node(NULL, NULL, "arm,scmi-shmem=
");
>=20
> Here we are using "arm,scmi-shmem" while below we are checking for
> "linux,scmi_mem". What's the difference?

linux,scmi_mem (I posted nodes examples above) describes memory region, all=
ocated
for all channels, while arm,scmi-shmem points to the exact channel (page in
linux,scmi_mem region).

>=20
> Also, this function is looking for "arm,scmi-shmem" in dt_host and
> replaces its value. For dom0less domUs we'll probably need a
> make_scmi_node function to create the node from scratch like for
> instance xen/arch/arm/domain_build.c:make_gic_domU_node.
>=20
> I wonder if we had such a function whether it wouldn't be better to also
> use it for dom0 (and blacklist the physical "arm,scmi-shmem" in
> handle_node so that dom0 doesn't get the real shared memory information
> by accident).
>=20

Thank you for the remark. I will rework this in v2.

>=20
> > +
> > +    if ( !shmem_node )
> > +    {
> > +        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI=
_SHMEM);
> > +        return -EINVAL;
> > +    }
> > +
> > +    pp =3D dt_find_property(shmem_node, "reg", &len);
> > +    if ( !pp )
> > +    {
> > +        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem no=
de\n");
> > +        return -ENOENT;
> > +    }
> > +
> > +    hw_reg =3D pp->value;
> > +    dt_set_range(&hw_reg, shmem_node, addr, size);
> > +
> > +    return 0;
> > +}
> > +
> > +static void free_channel_list(void)
> > +{
> > +    struct scmi_channel *curr, *_curr;
> > +
> > +    spin_lock(&scmi_data.channel_list_lock);
> > +    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, li=
st)
> > +    {
> > +        vunmap(curr->shmem);
> > +        list_del(&curr->list);
> > +        xfree(curr);
> > +    }
> > +
> > +    spin_unlock(&scmi_data.channel_list_lock);
> > +}
> > +
> > +static __init bool scmi_probe(struct dt_device_node *scmi_node)
> > +{
> > +    struct dt_device_node *shmem_node;
> > +    int ret, i;
> > +    struct scmi_channel *channel, *agent_channel;
> > +    int n_agents;
> > +    scmi_msg_header_t hdr;
> > +    struct rx_t {
> > +        int32_t status;
> > +        uint32_t attributes;
> > +    } rx;
>=20
> Should rx be defined at the top together with scmi_perms_tx_t and
> others?
>=20

I'd rather move scmi_perms_tx_t to scmi_add_device_by_devid because it's
used only in 1 place.
So we will have rx and tx in scmi_add_device_by_devid and rx ( which
differs from rx in scmi_add_device_by_devid ) in scmi_probe.
I think it will be more understandable and no need to make unique names.
What do you think about that?

>=20
> > +    uint32_t func_id;
> > +
> > +    ASSERT(scmi_node !=3D NULL);
> > +
> > +    INIT_LIST_HEAD(&scmi_data.channel_list);
> > +    spin_lock_init(&scmi_data.channel_list_lock);
> > +
> > +    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
> > +    {
> > +        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
> > +        return false;
> > +    }
> > +
> > +    shmem_node =3D dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);
>=20
> From the spec, it looks like you should be getting the shared memory
> area from the phandle list "shmem".
>=20

We use SCMI_SHARED_MEMORY to get whole memory region (0x10 pages in my case=
),
we can use for the agents. As you can see below - Hypervisor received numbe=
r of
agents from Firmware and split this region between agents.

>=20
> > +    if ( IS_ERR_OR_NULL(shmem_node) )
> > +    {
> > +        printk(XENLOG_ERR
> > +               "scmi: Device tree error, can't parse shmem phandle %ld=
\n",
> > +               PTR_ERR(shmem_node));
> > +        return false;
> > +    }
> > +
> > +    ret =3D dt_device_get_address(shmem_node, 0, &scmi_data.shmem_addr=
,
> > +                                &scmi_data.shmem_size);
> > +    if ( IS_ERR_VALUE(ret) )
> > +        return false;
> > +
> > +    channel =3D smc_create_channel(HYP_CHANNEL, func_id, scmi_data.shm=
em_addr);
> > +    if ( IS_ERR(channel) )
> > +        return false;
> > +
> > +    hdr.id =3D SCMI_BASE_PROTOCOL_ATTIBUTES;
> > +    hdr.type =3D 0;
> > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > +
> > +    ret =3D do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
> > +    if ( ret )
> > +        goto clean;
> > +
> > +    ret =3D check_scmi_status(rx.status);
> > +    if ( ret )
> > +        goto clean;
> > +
> > +    n_agents =3D FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
> > +    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
> > +
> > +    n_agents =3D (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
> > +        scmi_data.shmem_size / PAGE_SIZE : n_agents;
> > +
> > +    for ( i =3D 1; i < n_agents; i++ )
> > +    {
>=20
> Given that HYP_CHANNEL is actually zero, it looks like we could do
> everything here in this loop but starting from i=3D0?
>=20

We allocate HYP_CHANNEL before loop because we need it to request number
of agents. And we don't need to send SCMI_BASE_DISCOVER_AGENT to
HYP_CHANNEL.

>=20
> > +        uint32_t tx_agent_id =3D 0xFFFFFFFF;
> > +        struct {
> > +            int32_t status;
> > +            uint32_t agent_id;
> > +            char name[16];
> > +        } da_rx;
> > +
> > +        agent_channel =3D smc_create_channel(i, func_id, scmi_data.shm=
em_addr +
> > +                                           i * PAGE_SIZE);
> > +        if ( IS_ERR(agent_channel) )
> > +        {
> > +            ret =3D PTR_ERR(agent_channel);
> > +            goto clean;
> > +        }
> > +
> > +        hdr.id =3D SCMI_BASE_DISCOVER_AGENT;
> > +        hdr.type =3D 0;
> > +        hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > +
> > +        ret =3D do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
> > +                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
> > +        if ( ret )
> > +            goto clean;
> > +
> > +        ret =3D check_scmi_status(da_rx.status);
> > +        if ( ret )
> > +            goto clean;
> > +
> > +        printk(XENLOG_DEBUG "scmi: status=3D0x%x id=3D0x%x name=3D%s\n=
",
> > +                da_rx.status, da_rx.agent_id, da_rx.name);
> > +
> > +        agent_channel->agent_id =3D da_rx.agent_id;
> > +    }
> > +
> > +    scmi_data.initialized =3D true;
> > +    return true;
> > +
> > +clean:
> > +    free_channel_list();
> > +    return ret =3D=3D 0;
> > +}
> > +
> > +static int scmi_domain_init(struct domain *d)
> > +{
> > +    struct scmi_channel *channel;
> > +    int ret;
> > +
> > +    if ( !scmi_data.initialized )
> > +        return 0;
> > +
> > +    channel =3D aquire_scmi_channel(d->domain_id);
> > +    if ( IS_ERR_OR_NULL(channel) )
> > +        return -ENOENT;
> > +
> > +    printk(XENLOG_INFO "scmi: Aquire SCMI channel id =3D 0x%x , domain=
_id =3D %d"
> > +           "paddr =3D 0x%lx\n", channel->chan_id, channel->domain_id,
> > +           channel->paddr);
> > +
> > +    if ( is_hardware_domain(d) )
> > +    {
> > +        ret =3D map_memory_to_domain(d, scmi_data.shmem_addr,
> > +                                   scmi_data.shmem_size);
> > +        if ( IS_ERR_VALUE(ret) )
> > +            goto error;
> > +
> > +        ret =3D dt_update_domain_range(d, channel->paddr, PAGE_SIZE);
> > +        if ( IS_ERR_VALUE(ret) )
> > +        {
> > +            int rc =3D unmap_memory_from_domain(d, scmi_data.shmem_add=
r,
> > +                                              scmi_data.shmem_size);
> > +            if ( rc )
> > +                printk(XENLOG_ERR "Unable to unmap_memory_from_domain\=
n");
> > +
> > +            goto error;
> > +        }
> > +    }
>=20
> Is dom0 the only domain to get direct access to the shared memory
> region? If so, I don't think it is a good idea to make Dom0 "special" in
> this case.
>=20
> Let me make an example: if we assign a device to a domU since boot, and
> dom0 wants to change the frequency of a clock that affects the assigned
> device (likely because it doesn't know it is assigned), then dom0
> shouldn't be able to.  We might have to perform checks in Xen to make
> sure dom0 cannot stop the clock for the assigned device.=20
>=20
> So I think it would be better if all domains are treated the same way in
> the mediator unless really necessary.
>=20
> On the other hand, if all domains get access to the shared memory
> region, then I don't think this is likely the right place to create the
> dom0 mapping. We probably want to do it in domain_build.c in a way that
> can be reused for dom0less domUs.
>=20

The idea is that all domains have their own page in shared memory
region and unigue agent_id. Agent_id is used to set permissions for
clocks\resets\power-domains etc. So during creation of domain (domUs or
dom0) device-tree is processed using scmi_add_dt_device and
clocks\resets\power-domains which are related to dom0 devices will be
requested by using SCMI_BASE_SET_DEVICE_PERMISSIONS message.
All passed-through devices will be requested during DomU creation. Which
means dom0 do not have an access to clocks\resets\power-domains, which
are related to DomU.
>=20
> In regards to shared memory: it looks like the only two functions to
> access the real shared memory are send_smc_message and get_smc_response.
> If that is the case, then we actually don't need to expose the real
> shared memory to any of the domains.
>=20
> We could simply:
>=20
> - expose a regular normal memory region as dom0/domU channel memory
> - on SMC trap, read from the "fake" shared memory and set the
>   corresponding real shared memory on the appropriate channel
> - issue the SMC call
> - on return from SMC, copy over data from the real shared memory to the
>   "fake" channel reagion

Hypervisor redirects only SMC calls from guests and set agent_id to SMC
parameters as a7. The idea was to give page for each agent, so we don't
need to make additional read/write each time we receive SMC call.
All we povide from hypervisor is agent_id. Firmware is responsible for
reading memory from the correct address and place the response.

>=20
> This is useful if we need to "filter" any of the SCMI commands and
> options from the domains to the firmware, and also it is useful if the
> channel memory is not page aligned. But if the permissions are
> fine-grained enough and also the channel memory is page aligned (and
> multiple of 4K in size) then we could map the memory.
>=20

In current implementation we suppose that channel memory is page aligned.
I think that Firmware should be responsible for permissions handling and
"filtering", that's why permission calls were added to SCMI spec.
I tried to make mediator as thin as possible.

>=20
> > +
> > +    d->arch.sci =3D channel;
> > +
> > +    return 0;
> > +error:
> > +    relinquish_scmi_channel(channel);
> > +
> > +    return ret;
> > +}
> > +
> > +static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_de=
vid)
> > +{
> > +    struct scmi_channel *channel, *agent_channel;
> > +    scmi_msg_header_t hdr;
> > +    scmi_perms_tx_t tx;
> > +    struct rx_t {
> > +        int32_t status;
> > +        uint32_t attributes;
> > +    } rx;
> > +    int ret;
> > +
> > +    if ( !scmi_data.initialized )
> > +        return 0;
> > +
> > +    printk(XENLOG_DEBUG "scmi: scmi_devid =3D %d\n", scmi_devid);
> > +
> > +    agent_channel =3D get_channel_by_domain(d->domain_id);
> > +    if ( IS_ERR_OR_NULL(agent_channel) )
> > +        return PTR_ERR(agent_channel);
> > +
> > +    channel =3D get_channel_by_id(HYP_CHANNEL);
> > +    if ( IS_ERR_OR_NULL(channel) )
> > +        return PTR_ERR(channel);
> > +
> > +    hdr.id =3D SCMI_BASE_SET_DEVICE_PERMISSIONS;
> > +    hdr.type =3D 0;
> > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > +
> > +    tx.agent_id =3D agent_channel->agent_id;
> > +    tx.device_id =3D scmi_devid;
> > +    tx.flags =3D SCMI_ALLOW_ACCESS;
> > +
> > +    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&r=
x));
> > +    if ( IS_ERR_VALUE(ret) )
> > +        return ret;
> > +
> > +    ret =3D check_scmi_status(rx.status);
> > +    if ( IS_ERR_VALUE(ret) )
> > +        return ret;
> > +
> > +    return 0;
> > +}
> > +
> > +static int scmi_add_dt_device(struct domain *d, struct dt_device_node =
*dev)
> > +{
> > +    uint32_t scmi_devid;
> > +
> > +    if ( (!scmi_data.initialized) || (!d->arch.sci) )
> > +        return 0;
> > +
> > +    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
> > +        return 0;
>=20
> scmi_devid is another property that is not documented in the binding.
>=20

This property should be added to the device nodes, which are using scmi
to work with clocks\resets\power-domains etc. This id should match the
device_id, defined in Firmware. Hypervisor send this device_id to the Firmw=
are
as parameter to the permission request. Firmware set permissions to
clocks\resets\power-domains, related to this device.

>=20
> > +    printk(XENLOG_INFO "scmi: dt_node =3D %s\n", dt_node_full_name(dev=
));
> > +
> > +    return scmi_add_device_by_devid(d, scmi_devid);
> > +}
> > +
> > +static int scmi_relinquish_resources(struct domain *d)
> > +{
> > +    int ret;
> > +    struct scmi_channel *channel, *agent_channel;
> > +    scmi_msg_header_t hdr;
> > +    struct reset_agent_tx {
> > +        uint32_t agent_id;
> > +        uint32_t flags;
> > +    } tx;
> > +    uint32_t rx;
> > +
> > +    if ( !d->arch.sci )
> > +        return 0;
> > +
> > +    agent_channel =3D d->arch.sci;
> > +
> > +    spin_lock(&agent_channel->lock);
> > +    tx.agent_id =3D agent_channel->agent_id;
> > +    spin_unlock(&agent_channel->lock);
> > +
> > +    channel =3D get_channel_by_id(HYP_CHANNEL);
> > +    if ( !channel )
> > +    {
> > +        printk(XENLOG_ERR
> > +               "scmi: Unable to get Hypervisor scmi channel for domain=
 %d\n",
> > +               d->domain_id);
> > +        return -EINVAL;
> > +    }
> > +
> > +    hdr.id =3D SCMI_BASE_RESET_AGENT_CONFIGURATION;
> > +    hdr.type =3D 0;
> > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > +
> > +    tx.flags =3D 0;
> > +
> > +    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx=
));
> > +    if ( ret )
> > +        return ret;
> > +
> > +    ret =3D check_scmi_status(rx);
> > +
> > +    return ret;
> > +}
> > +
> > +static void scmi_domain_destroy(struct domain *d)
> > +{
> > +    struct scmi_channel *channel;
> > +
> > +    if ( !d->arch.sci )
> > +        return;
> > +
> > +    channel =3D d->arch.sci;
> > +    spin_lock(&channel->lock);
> > +
> > +    relinquish_scmi_channel(channel);
> > +    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
> > +
> > +    d->arch.sci =3D NULL;
> > +
> > +    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
> > +    spin_unlock(&channel->lock);
> > +    return;
> > +}
> > +
> > +static bool scmi_handle_call(struct domain *d, void *args)
> > +{
> > +    bool res =3D false;
> > +    struct scmi_channel *agent_channel;
> > +    struct arm_smccc_res resp;
> > +    struct cpu_user_regs *regs =3D args;
> > +
> > +    if ( !d->arch.sci )
> > +        return false;
> > +
> > +    agent_channel =3D d->arch.sci;
> > +    spin_lock(&agent_channel->lock);
> > +
> > +    if ( agent_channel->func_id !=3D regs->x0 )
> > +    {
> > +        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
> > +        goto unlock;
> > +    }
> > +
> > +    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
> > +                  agent_channel->chan_id, &resp);
> > +
> > +    set_user_reg(regs, 0, resp.a0);
> > +    set_user_reg(regs, 1, resp.a1);
> > +    set_user_reg(regs, 2, resp.a2);
> > +    set_user_reg(regs, 3, resp.a3);
> > +    res =3D true;
> > +unlock:
> > +    spin_unlock(&agent_channel->lock);
> > +
> > +    return res;
> > +}
> > +
> > +static int scmi_get_channel_paddr(void *scmi_ops,
> > +                           struct xen_arch_domainconfig *config)
> > +{
> > +    struct scmi_channel *agent_channel =3D scmi_ops;
> > +
> > +    if ( !agent_channel )
> > +        return -EINVAL;
> > +
> > +    config->sci_agent_paddr =3D agent_channel->paddr;
> > +    return 0;
> > +}
>=20
> I am still not sure why it couldn't be done by scmi_domain_init.
>

I can move this logic to scmi_domain_init, but in this case I have to add
struct xen_arch_domainconfig *config as input parameter to
scmi_domain_init and pass NULL from construct_dom0.
Do you think this approach would be better?

Also I think it's reasonable to pass xen_arch_domainconfig so different
implementations could set another data they would probably need.

>=20
> > +static const struct dt_device_match scmi_smc_match[] __initconst =3D
> > +{
> > +    DT_MATCH_SCMI_SMC,
> > +    { /* sentinel */ },
> > +};
> > +
> > +static const struct sci_mediator_ops scmi_ops =3D
> > +{
> > +    .probe =3D scmi_probe,
> > +    .domain_init =3D scmi_domain_init,
> > +    .domain_destroy =3D scmi_domain_destroy,
> > +    .add_dt_device =3D scmi_add_dt_device,
> > +    .relinquish_resources =3D scmi_relinquish_resources,
> > +    .handle_call =3D scmi_handle_call,
> > +    .get_channel_info =3D scmi_get_channel_paddr
> > +};
> > +
> > +REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_SCMI=
_SMC,
> > +                      scmi_smc_match, &scmi_ops);
> > +
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-ar=
m.h
> > index 9180be5e86..a67237942d 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> >  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> > =20
> >  #define XEN_DOMCTL_CONFIG_SCI_NONE      0
> > +#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
> > =20
> >  struct xen_arch_domainconfig {
> >      /* IN/OUT */
> > --=20
> > 2.27.0
> > =


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 20:39:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 20:39:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249983.430468 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzPRE-0000yH-0h; Mon, 20 Dec 2021 20:39:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249983.430468; Mon, 20 Dec 2021 20:39:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzPRD-0000yA-Tq; Mon, 20 Dec 2021 20:39:15 +0000
Received: by outflank-mailman (input) for mailman id 249983;
 Mon, 20 Dec 2021 20:39:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzPRC-0000y0-0w; Mon, 20 Dec 2021 20:39:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzPRB-00057N-SS; Mon, 20 Dec 2021 20:39:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzPRB-0003JM-Gx; Mon, 20 Dec 2021 20:39:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzPRB-0005A6-GS; Mon, 20 Dec 2021 20:39:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hTXOrJhqREJ8L1NKY6DFn+DufbU51+yISQR0V1fi3Yw=; b=lFQ8gMRCJpfrGhf7IJf1ZfrqAU
	TfUjQmBWgvYmAIjuJ2Dw8CJ9YMB9MM8r85H57rP5SX/hC1TNazBGKkKxOMVEnDmnaTbszTJ2LYxkH
	WmElD/aQvAF1eDAZ3vWLSK7uI6XMTEk0p2wd7GAurjiWzwxeCTukEtno8yGZwsJzYbGs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167492-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167492: regressions - FAIL
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression
    linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-linus:test-amd64-amd64-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a7904a538933c525096ca2ccde1e60d0ee62c08e
X-Osstest-Versions-That:
    linux=a76c3d035872bf390d2fd92d8e5badc5ee28b17d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 20 Dec 2021 20:39:13 +0000

flight 167492 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167492/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 167484

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      8 xen-boot         fail in 167486 pass in 167492
 test-amd64-amd64-xl-rtds     18 guest-localmigrate         fail pass in 167486
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail pass in 167486
 test-amd64-amd64-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 167486

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds  20 guest-localmigrate/x10 fail in 167486 like 167484
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167484
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167484
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167484
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167484
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167484
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                a7904a538933c525096ca2ccde1e60d0ee62c08e
baseline version:
 linux                a76c3d035872bf390d2fd92d8e5badc5ee28b17d

Last test of basis   167484  2021-12-19 20:40:59 Z    0 days
Testing same since   167486  2021-12-20 02:31:29 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jens Axboe <axboe@kernel.dk>
  Linus Torvalds <torvalds@linux-foundation.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Sean Christopherson <seanjc@google.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             fail    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

------------------------------------------------------------
commit a7904a538933c525096ca2ccde1e60d0ee62c08e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 14:14:33 2021 -0800

    Linux 5.16-rc6

commit f291e2d899d120880bfe8e0fa6fe22a97a54e054
Merge: 2da09da4ae5e 18c841e1f411
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 12:44:03 2021 -0800

    Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
    
    Pull kvm fixes from Paolo Bonzini:
     "Two small fixes, one of which was being worked around in selftests"
    
    * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm:
      KVM: x86: Retry page fault if MMU reload is pending and root has no sp
      KVM: selftests: vmx_pmu_msrs_test: Drop tests mangling guest visible CPUIDs
      KVM: x86: Drop guest CPUID check for host initiated writes to MSR_IA32_PERF_CAPABILITIES

commit 2da09da4ae5e1714606668bdb145806b0afe9c90
Merge: a76c3d035872 87959fa16cfb
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun Dec 19 12:38:53 2021 -0800

    Merge tag 'block-5.16-2021-12-19' of git://git.kernel.dk/linux-block
    
    Pull block revert from Jens Axboe:
     "It turns out that the fix for not hammering on the delayed work timer
      too much caused a performance regression for BFQ, so let's revert the
      change for now.
    
      I've got some ideas on how to fix it appropriately, but they should
      wait for 5.17"
    
    * tag 'block-5.16-2021-12-19' of git://git.kernel.dk/linux-block:
      Revert "block: reduce kblockd_mod_delayed_work_on() CPU consumption"

commit 18c841e1f4112d3fb742aca3429e84117fcb1e1c
Author: Sean Christopherson <seanjc@google.com>
Date:   Thu Dec 9 06:05:46 2021 +0000

    KVM: x86: Retry page fault if MMU reload is pending and root has no sp
    
    Play nice with a NULL shadow page when checking for an obsolete root in
    the page fault handler by flagging the page fault as stale if there's no
    shadow page associated with the root and KVM_REQ_MMU_RELOAD is pending.
    Invalidating memslots, which is the only case where _all_ roots need to
    be reloaded, requests all vCPUs to reload their MMUs while holding
    mmu_lock for lock.
    
    The "special" roots, e.g. pae_root when KVM uses PAE paging, are not
    backed by a shadow page.  Running with TDP disabled or with nested NPT
    explodes spectaculary due to dereferencing a NULL shadow page pointer.
    
    Skip the KVM_REQ_MMU_RELOAD check if there is a valid shadow page for the
    root.  Zapping shadow pages in response to guest activity, e.g. when the
    guest frees a PGD, can trigger KVM_REQ_MMU_RELOAD even if the current
    vCPU isn't using the affected root.  I.e. KVM_REQ_MMU_RELOAD can be seen
    with a completely valid root shadow page.  This is a bit of a moot point
    as KVM currently unloads all roots on KVM_REQ_MMU_RELOAD, but that will
    be cleaned up in the future.
    
    Fixes: a955cad84cda ("KVM: x86/mmu: Retry page fault if root is invalidated by memslot update")
    Cc: stable@vger.kernel.org
    Cc: Maxim Levitsky <mlevitsk@redhat.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    Message-Id: <20211209060552.2956723-2-seanjc@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 0b091a43d704997789c6d812b02167c8f5f9f061
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date:   Thu Dec 16 17:52:12 2021 +0100

    KVM: selftests: vmx_pmu_msrs_test: Drop tests mangling guest visible CPUIDs
    
    Host initiated writes to MSR_IA32_PERF_CAPABILITIES should not depend
    on guest visible CPUIDs and (incorrect) KVM logic implementing it is
    about to change. Also, KVM_SET_CPUID{,2} after KVM_RUN is now forbidden
    and causes test to fail.
    
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Fixes: feb627e8d6f6 ("KVM: x86: Forbid KVM_SET_CPUID{,2} after KVM_RUN")
    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Message-Id: <20211216165213.338923-2-vkuznets@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 1aa2abb33a419090c7c87d4ae842a6347078ee12
Author: Vitaly Kuznetsov <vkuznets@redhat.com>
Date:   Thu Dec 16 17:52:13 2021 +0100

    KVM: x86: Drop guest CPUID check for host initiated writes to MSR_IA32_PERF_CAPABILITIES
    
    The ability to write to MSR_IA32_PERF_CAPABILITIES from the host should
    not depend on guest visible CPUID entries, even if just to allow
    creating/restoring guest MSRs and CPUIDs in any sequence.
    
    Fixes: 27461da31089 ("KVM: x86/pmu: Support full width counting")
    Suggested-by: Sean Christopherson <seanjc@google.com>
    Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    Message-Id: <20211216165213.338923-3-vkuznets@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

commit 87959fa16cfbcf76245c11559db1940069621274
Author: Jens Axboe <axboe@kernel.dk>
Date:   Sun Dec 19 07:58:44 2021 -0700

    Revert "block: reduce kblockd_mod_delayed_work_on() CPU consumption"
    
    This reverts commit cb2ac2912a9ca7d3d26291c511939a41361d2d83.
    
    Alex and the kernel test robot report that this causes a significant
    performance regression with BFQ. I can reproduce that result, so let's
    revert this one as we're close to -rc6 and we there's no point in trying
    to rush a fix.
    
    Link: https://lore.kernel.org/linux-block/1639853092.524jxfaem2.none@localhost/
    Link: https://lore.kernel.org/lkml/20211219141852.GH14057@xsang-OptiPlex-9020/
    Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
    Reported-by: kernel test robot <oliver.sang@intel.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249995.430502 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ16-0005gn-7I; Mon, 20 Dec 2021 21:16:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249995.430502; Mon, 20 Dec 2021 21:16:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ15-0005eI-VZ; Mon, 20 Dec 2021 21:16:19 +0000
Received: by outflank-mailman (input) for mailman id 249995;
 Mon, 20 Dec 2021 21:16:18 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ14-0005IB-EW
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:18 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 11ee8156-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:17 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id bt1so24502703lfb.13
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:17 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.16
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 11ee8156-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=hajm4OA2mR1rqKBWo1oPRyQ75UieT0Vx1ZnO7YitzIM=;
        b=qIXmN3ldE/ZN74+4YThza4AYid4jpygjX+xdmfkD6EAA5y37CvzdUbPtTSqP+1hezy
         FbateqQKdPFMOjjVuW3VU6Std4HufcBhyTDj+OTVAdRyBwkZNr0k/MHwOk9aYF+ijU1z
         50fNGe+Ij8QFC6URM0g//2mLElYzbjnUFC4cs4myBgUpaHWUG9fB3EfSmWFmWIlCqG/R
         e4uCVxbL6WrKLuyi/hgXa5dpUx1cVncs8xDJoil1jpJPbOdHZiQEuTIpBnDUonl6P6kI
         Pweo79tXZ5V1g8p0e8nexsWb8XlHgeuno1/k/jxl3Sp9RBn9Su9HDg01r8kaK3EVMhWF
         v9FQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=hajm4OA2mR1rqKBWo1oPRyQ75UieT0Vx1ZnO7YitzIM=;
        b=z70XkiH2NGmtAtHattaH6UB4GV+988PBJwoQYJkJ/iftam1D068s1rOKIH2QzwNclj
         f2aFUt11kE1nijbcMIwGi3Nq7FHIfHkTY8VmHbYtMaxV+jjhsQ0snJjQudsvwsCosidR
         BVoC7jzgkBS1YXBugV3SSBKKveizofBmaa3fvTYICxLbXnVfWWkeedP6dVdoITEyHo+L
         00fg8A2H+jSqIq0cHjf1tR7lf6hUFWwW1otP+WaD6d1Zz3CYvqtERFmcJJikhBULr13f
         aylHy1la0tACvfplAoDUeIGZMs7mDNQfh88GzO6UpamNjEptV6Z5X5ob/eWWEmFQ5qcv
         tpSQ==
X-Gm-Message-State: AOAM531Lbzhh+U4WQqfkTdGpUmznGyNfrAK73Ufvjd1m2gzZrjoNzB9h
	A9sBooliReySq1WWltcpt5+QucRfkOY=
X-Google-Smtp-Source: ABdhPJxzTfRun3YkUwibQaiDMstuUa+taVcJp9VRWabBxAHUy/4zPZawhc2OjDWcR5BYP0Abgva61g==
X-Received: by 2002:a05:6512:3054:: with SMTP id b20mr2857353lfb.359.1640034976971;
        Mon, 20 Dec 2021 13:16:16 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 03/10] iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
Date: Mon, 20 Dec 2021 23:15:50 +0200
Message-Id: <1640034957-19764-4-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a non-verbatim port of corresponding Linux upsteam commit:
3667c9978b2911dc1ded77f5971df477885409c4

Original commit message:
 commit 3667c9978b2911dc1ded77f5971df477885409c4
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Wed Nov 6 11:35:49 2019 +0900

  iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers

  Since we will have changed memory mapping of the IPMMU in the future,
  This patch adds helper functions ipmmu_utlb_reg() and
  ipmmu_imu{asid,ctr}_write() for "uTLB" registers. No behavior change.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
  Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

This is a prereq work needed to add support for S4 series easily
in the future.

Besides changes done in the original commit, we also need to introduce
ipmmu_imuctr_read() since Xen driver contains an additional logic in
ipmmu_utlb_enable() to prevent the use cases where devices which use
the same micro-TLB are assigned to different Xen domains.

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 33 +++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index ce5c3bc..1b94af2 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -366,6 +366,29 @@ static void ipmmu_ctx_write_all(struct ipmmu_vmsa_domain *domain,
     ipmmu_ctx_write_root(domain, reg, data);
 }
 
+static uint32_t ipmmu_utlb_reg(struct ipmmu_vmsa_device *mmu, uint32_t reg)
+{
+    return reg;
+}
+
+static void ipmmu_imuasid_write(struct ipmmu_vmsa_device *mmu,
+                                unsigned int utlb, uint32_t data)
+{
+    ipmmu_write(mmu, ipmmu_utlb_reg(mmu, IMUASID(utlb)), data);
+}
+
+static void ipmmu_imuctr_write(struct ipmmu_vmsa_device *mmu,
+                               unsigned int utlb, uint32_t data)
+{
+    ipmmu_write(mmu, ipmmu_utlb_reg(mmu, IMUCTR(utlb)), data);
+}
+
+static uint32_t ipmmu_imuctr_read(struct ipmmu_vmsa_device *mmu,
+                                  unsigned int utlb)
+{
+    return ipmmu_read(mmu, ipmmu_utlb_reg(mmu, IMUCTR(utlb)));
+}
+
 /* TLB and micro-TLB Management */
 
 /* Wait for any pending TLB invalidations to complete. */
@@ -413,7 +436,7 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_domain *domain,
      * context_id for already enabled micro-TLB and prevent different context
      * bank from being set.
      */
-    imuctr = ipmmu_read(mmu, IMUCTR(utlb));
+    imuctr = ipmmu_imuctr_read(mmu, utlb);
     if ( imuctr & IMUCTR_MMUEN )
     {
         unsigned int context_id;
@@ -431,9 +454,9 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_domain *domain,
      * TODO: Reference-count the micro-TLB as several bus masters can be
      * connected to the same micro-TLB.
      */
-    ipmmu_write(mmu, IMUASID(utlb), 0);
-    ipmmu_write(mmu, IMUCTR(utlb), imuctr |
-                IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
+    ipmmu_imuasid_write(mmu, utlb, 0);
+    ipmmu_imuctr_write(mmu, utlb, imuctr |
+                       IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
 
     return 0;
 }
@@ -444,7 +467,7 @@ static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain,
 {
     struct ipmmu_vmsa_device *mmu = domain->mmu;
 
-    ipmmu_write(mmu, IMUCTR(utlb), 0);
+    ipmmu_imuctr_write(mmu, utlb, 0);
 }
 
 /* Domain/Context Management */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249992.430479 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ14-0005Ie-Vm; Mon, 20 Dec 2021 21:16:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249992.430479; Mon, 20 Dec 2021 21:16:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ14-0005IX-Sn; Mon, 20 Dec 2021 21:16:18 +0000
Received: by outflank-mailman (input) for mailman id 249992;
 Mon, 20 Dec 2021 21:16:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ12-0005IB-MZ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:16 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 10c50902-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:15 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id g26so8788848lfv.11
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:15 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.13
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:14 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 10c50902-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=j5Q/RJPdWh4bqdcFuIxinpJzK9wtUT2GDpjgf/iTPpg=;
        b=E9vW99Y32bkWLVqZmQ9NdpzkoCrOi03+Qwqa00Db3aBzO9e8ZYb91fhnjItOAqC2fv
         eoMkrNaqYxfNKge378AeVZi8JPGneZUQ5Y5mIcGwZvg3aBEdp8htJIO3mbuVaJEr2iJu
         Z5GXL+bbqIct1IvvLZTFCILaQLaw6OLbb8B9igd0x+M2a2wCiDvV/rnrzoqiRp8UYY+6
         dKwy4Z8H4aLKIKgvh8to/t1WKD6SpiPRohNB9NwF6iB25jMqkppPna8Fy5b114j6Dm7e
         mIJ4OuEZrv772a1Pfx5XpgW2w1hP1MsFZB4GAO7GCvSA6OIMcO4buGRC4JttjAhs+qLl
         xocA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=j5Q/RJPdWh4bqdcFuIxinpJzK9wtUT2GDpjgf/iTPpg=;
        b=NlNLNDWgQtClSoRp0o4R9WXyqgPlTFfsIuWezilToGwbUE2pADO5bbQv50KNwvEDza
         jv9eoaAtTKAXdFRmeLttI2C2r/PnuKYqiIhvctE1DeNhvOorslbdrqjOrpyfXr7/w0BX
         n7CC35V7j/Asn+ejOvphBBKDeDST4mJwV1Bl0TzkxS6XL+Wl4IolsHjbrN1NEjvYWM5b
         d2UjgFIUNl022CBk/XuZVXVTg6toOe4bULtLaswVSl7dAGDWD6qEttyDcbpVKQakabRM
         EdaKLU0dc5xH9ghzq7+F7MG6r2+j0dPfvEn67jyCvaAJaKO+uwTTwiDNQ/ycpjTC54dg
         9JZQ==
X-Gm-Message-State: AOAM531UknhfJVe12gb5Na6wzsvbtRG6RjGa+i7kYTBSYRn8BX2MSzy/
	/ZmN9SXNytF3sblFpe3Y1qx61KB/sxY=
X-Google-Smtp-Source: ABdhPJw589wFRXA12CoYbgrgbr52n6Y7D7X9JfaFVgt5iK3d/rDLsSnX8r2/aXzU70vF8mYTf203Rw==
X-Received: by 2002:a05:6512:b81:: with SMTP id b1mr15523800lfv.301.1640034974578;
        Mon, 20 Dec 2021 13:16:14 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>,
	Rahul Singh <rahul.singh@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 00/10] Add support for Renesas R-Car S4 IPMMU and other misc changes
Date: Mon, 20 Dec 2021 23:15:47 +0200
Message-Id: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Hello all.

You can find the V1 patch series at [1].

The R-Car S4 is an automotive System-on-Chip (SoC) for Car Server/Communication
Gateway and is one of the first products in Renesas’ 4th-generation R-Car Family.

The integrated IOMMU HW is also VMSA-compatible and supports stage 2 translation
table format, therefore can be used with current R-Car Gen3 driver with slight
modifications.

In the context of Xen driver the main differences between Gen3 and Gen4 are
the following:
 - HW capacity was enlarged to support up to 16 IPMMU contexts (sets of page table)
   and up to 64 micro-TLBs per IPMMU device
 - the memory mapped registers have different bases and offset

The first part (commits #1-6) is a non-verbatim port of Linux upstream commits
needed to add support for S4 series easily (prereq work).
The second part (commits #7-8) is based on the code from the Renesas BSP and
actually introduces support for R-Car S4 IPMMU.
The third part (commits #9-10) is misc changes I have locally.

The patch series is based on the latest staging branch 
"f3999bc2e099 arm/efi: Handle Xen bootargs from both xen.cfg and DT"
and also available at [2].

Tested on Renesas Salvator-X board with H3 ES3.0 SoC (Gen3) and Renesas Spider
board with S4 SoC (Gen4).

[1] https://lore.kernel.org/all/1638035505-16931-1-git-send-email-olekstysh@gmail.com/
[2] https://github.com/otyshchenko1/xen/commits/s4_ipmmu_ml2


Oleksandr Tyshchenko (10):
  iommu/ipmmu-vmsa: Remove all unused register definitions
  iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers
  iommu/ipmmu-vmsa: Add helper functions for "uTLB" registers
  iommu/ipmmu-vmsa: Add light version of Linux's ipmmu_features
  iommu/ipmmu-vmsa: Calculate context registers' offset instead of a
    macro
  iommu/ipmmu-vmsa: Add utlb_offset_base
  iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
  iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
  iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
  iommu/arm: Remove code duplication in all IOMMU drivers

 xen/drivers/passthrough/Kconfig          |   6 +-
 xen/drivers/passthrough/arm/iommu.c      |   7 +
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 267 ++++++++++++++++++-------------
 xen/drivers/passthrough/arm/smmu-v3.c    |  10 --
 xen/drivers/passthrough/arm/smmu.c       |  10 --
 5 files changed, 167 insertions(+), 133 deletions(-)

-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249993.430485 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ15-0005LD-Bx; Mon, 20 Dec 2021 21:16:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249993.430485; Mon, 20 Dec 2021 21:16:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ15-0005Kp-59; Mon, 20 Dec 2021 21:16:19 +0000
Received: by outflank-mailman (input) for mailman id 249993;
 Mon, 20 Dec 2021 21:16:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ13-0005IG-AV
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:17 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1119e5da-61da-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 22:16:16 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id x21so16375186lfa.5
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:15 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.14
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1119e5da-61da-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=5gytA2pLllrFj6CH99Xdk/Opt3jWfGlT8ShBqhaNetg=;
        b=Cdq4GjJ/2iK2iIIDzgHUFWhpcJBt2NTM2SeUjG+PuWAccmKfbquvFCKrO8Ez+FFwHY
         j111WBq0jRNFONhvtOulyEGsd1uE8GrmfipXT25rC/jzrCa/2mWJxkbPiNiNFvtwYjts
         GGa0E43hrhogNSeQPjJhaorFWWucTU2cQtt1RbtbkyzjF9wjvM0c5XxbMs8TJxBxcIK9
         UuGDvoU+OfsP7bPu8VX5JmKNzsOxXb+US2eNpRCaEtd/6WHXFfa2XK7GToLiBlQGvOX8
         JHwdxdmuFUmDT5SQm/OzzoKiDS8kJVoCL7P9GjMK2l4CrMaEb9O9qu2+EE7ZVSa1AmYD
         Q1dA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=5gytA2pLllrFj6CH99Xdk/Opt3jWfGlT8ShBqhaNetg=;
        b=KNQUR3+RpFwnnt8fZ/R+g94yd7NWIM+7jeWnVkgMiVVcPR/YoLdjwdANn+cZiCjA73
         PyAk6iobzS2ITOFvmUPV9NwRasuUfClNtQUPoTJS9cH4g/th8kNOTJS+3+UcbQhoTEnC
         NnFacY9BzGeOSW4l5yPlR+yxZ9qqz2VNvMkYUtp6xal7ITPfYYt3/eSj5BHOiimn2M/D
         DGcoeB1Ww+WY+MLQkaTyyfs12ZsLY72+U1Uc5TkrvM8lS0mYGFTT3azhHdLTVUOAgJez
         /ux2Nr+cts4jPM6tc7X6JbaxNhrCs/3FItaSVLdYqgor7XF/LOEoP2FzsOS7zayWOTPd
         8mGw==
X-Gm-Message-State: AOAM531ZW/1jAxzCTefvA8eYem2CtNUh+zU28J+ro/ptbKZ5Pu55iRkn
	as1eTakfBbL10jhYapxquavUcqonBoE=
X-Google-Smtp-Source: ABdhPJxaDOs+TBKah+ukRAfspi33bXHs6F6TXrKYX+7z3geOaurnZi1gkTrB2n7oqg3+F9pCzFg0Wg==
X-Received: by 2002:a05:6512:3054:: with SMTP id b20mr2857265lfb.359.1640034975570;
        Mon, 20 Dec 2021 13:16:15 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 01/10] iommu/ipmmu-vmsa: Remove all unused register definitions
Date: Mon, 20 Dec 2021 23:15:48 +0200
Message-Id: <1640034957-19764-2-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a non-verbatim port of corresponding Linux upsteam commit:
77cf983892b2e0d40dc256b784930a9ffaad4fc8

Original commit message:
 commit 77cf983892b2e0d40dc256b784930a9ffaad4fc8
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Wed Nov 6 11:35:45 2019 +0900

  iommu/ipmmu-vmsa: Remove all unused register definitions

  To support different registers memory mapping hardware easily
  in the future, this patch removes all unused register
  definitions.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

This is a prereq work needed to add support for S4 series easily
in the future.

Although Linux and Xen drivers have a lot in common, the main
differences are in translation stages (table formats), VMSAv8 modes,
supported SoC generations, etc, therefore that's why there is
a slight difference in registers/bits each driver considers unused.

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 59 ++------------------------------
 1 file changed, 2 insertions(+), 57 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 1255b0d..4a8a974 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -166,15 +166,11 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 
 #define IMCTR                0x0000
 /*
- * These fields are implemented in IPMMU-MM only. So, can be set for
+ * This field is implemented in IPMMU-MM only. So, can be set for
  * Root IPMMU only.
  */
 #define IMCTR_VA64           (1 << 29)
-#define IMCTR_TRE            (1 << 17)
-#define IMCTR_AFE            (1 << 16)
-#define IMCTR_RTSEL_MASK     (3 << 4)
-#define IMCTR_RTSEL_SHIFT    4
-#define IMCTR_TREN           (1 << 3)
+
 /*
  * These fields are common for all IPMMU devices. So, can be set for
  * Cache IPMMUs as well.
@@ -184,42 +180,9 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMCTR_MMUEN          (1 << 0)
 #define IMCTR_COMMON_MASK    (7 << 0)
 
-#define IMCAAR               0x0004
-
 #define IMTTBCR                        0x0008
 #define IMTTBCR_EAE                    (1U << 31)
 #define IMTTBCR_PMB                    (1 << 30)
-#define IMTTBCR_SH1_NON_SHAREABLE      (0 << 28)
-#define IMTTBCR_SH1_OUTER_SHAREABLE    (2 << 28)
-#define IMTTBCR_SH1_INNER_SHAREABLE    (3 << 28)
-#define IMTTBCR_SH1_MASK               (3 << 28)
-#define IMTTBCR_ORGN1_NC               (0 << 26)
-#define IMTTBCR_ORGN1_WB_WA            (1 << 26)
-#define IMTTBCR_ORGN1_WT               (2 << 26)
-#define IMTTBCR_ORGN1_WB               (3 << 26)
-#define IMTTBCR_ORGN1_MASK             (3 << 26)
-#define IMTTBCR_IRGN1_NC               (0 << 24)
-#define IMTTBCR_IRGN1_WB_WA            (1 << 24)
-#define IMTTBCR_IRGN1_WT               (2 << 24)
-#define IMTTBCR_IRGN1_WB               (3 << 24)
-#define IMTTBCR_IRGN1_MASK             (3 << 24)
-#define IMTTBCR_TSZ1_MASK              (0x1f << 16)
-#define IMTTBCR_TSZ1_SHIFT             16
-#define IMTTBCR_SH0_NON_SHAREABLE      (0 << 12)
-#define IMTTBCR_SH0_OUTER_SHAREABLE    (2 << 12)
-#define IMTTBCR_SH0_INNER_SHAREABLE    (3 << 12)
-#define IMTTBCR_SH0_MASK               (3 << 12)
-#define IMTTBCR_ORGN0_NC               (0 << 10)
-#define IMTTBCR_ORGN0_WB_WA            (1 << 10)
-#define IMTTBCR_ORGN0_WT               (2 << 10)
-#define IMTTBCR_ORGN0_WB               (3 << 10)
-#define IMTTBCR_ORGN0_MASK             (3 << 10)
-#define IMTTBCR_IRGN0_NC               (0 << 8)
-#define IMTTBCR_IRGN0_WB_WA            (1 << 8)
-#define IMTTBCR_IRGN0_WT               (2 << 8)
-#define IMTTBCR_IRGN0_WB               (3 << 8)
-#define IMTTBCR_IRGN0_MASK             (3 << 8)
-#define IMTTBCR_SL0_LVL_2              (0 << 6)
 #define IMTTBCR_SL0_LVL_1              (1 << 6)
 #define IMTTBCR_TSZ0_MASK              (0x1f << 0)
 #define IMTTBCR_TSZ0_SHIFT             0
@@ -228,18 +191,8 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMTTLBR0_TTBR_MASK    (0xfffff << 12)
 #define IMTTUBR0              0x0014
 #define IMTTUBR0_TTBR_MASK    (0xff << 0)
-#define IMTTLBR1              0x0018
-#define IMTTLBR1_TTBR_MASK    (0xfffff << 12)
-#define IMTTUBR1              0x001c
-#define IMTTUBR1_TTBR_MASK    (0xff << 0)
 
 #define IMSTR                          0x0020
-#define IMSTR_ERRLVL_MASK              (3 << 12)
-#define IMSTR_ERRLVL_SHIFT             12
-#define IMSTR_ERRCODE_TLB_FORMAT       (1 << 8)
-#define IMSTR_ERRCODE_ACCESS_PERM      (4 << 8)
-#define IMSTR_ERRCODE_SECURE_ACCESS    (5 << 8)
-#define IMSTR_ERRCODE_MASK             (7 << 8)
 #define IMSTR_MHIT                     (1 << 4)
 #define IMSTR_ABORT                    (1 << 2)
 #define IMSTR_PF                       (1 << 1)
@@ -251,11 +204,7 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMUCTR(n)              ((n) < 32 ? IMUCTR0(n) : IMUCTR32(n))
 #define IMUCTR0(n)             (0x0300 + ((n) * 16))
 #define IMUCTR32(n)            (0x0600 + (((n) - 32) * 16))
-#define IMUCTR_FIXADDEN        (1U << 31)
-#define IMUCTR_FIXADD_MASK     (0xff << 16)
-#define IMUCTR_FIXADD_SHIFT    16
 #define IMUCTR_TTSEL_MMU(n)    ((n) << 4)
-#define IMUCTR_TTSEL_PMB       (8 << 4)
 #define IMUCTR_TTSEL_MASK      (15 << 4)
 #define IMUCTR_TTSEL_SHIFT     4
 #define IMUCTR_FLUSH           (1 << 1)
@@ -264,10 +213,6 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMUASID(n)             ((n) < 32 ? IMUASID0(n) : IMUASID32(n))
 #define IMUASID0(n)            (0x0308 + ((n) * 16))
 #define IMUASID32(n)           (0x0608 + (((n) - 32) * 16))
-#define IMUASID_ASID8_MASK     (0xff << 8)
-#define IMUASID_ASID8_SHIFT    8
-#define IMUASID_ASID0_MASK     (0xff << 0)
-#define IMUASID_ASID0_SHIFT    0
 
 #define IMSAUXCTLR          0x0504
 #define IMSAUXCTLR_S2PTE    (1 << 3)
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249998.430539 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ18-0006eA-U9; Mon, 20 Dec 2021 21:16:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249998.430539; Mon, 20 Dec 2021 21:16:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ18-0006aW-LE; Mon, 20 Dec 2021 21:16:22 +0000
Received: by outflank-mailman (input) for mailman id 249998;
 Mon, 20 Dec 2021 21:16:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ16-0005IB-Dq
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:20 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13523567-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:19 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id x7so63029lfu.8
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:19 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.18
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:18 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13523567-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=87T9wZal9/PpckvFihuEE4uSOyOrETTBOP9Ojac4rmQ=;
        b=lm/UwovJiZ2A0shy8on5i1ls/8SdPLOeJgsONiV+OnXuTRDbCHZSaTi1SVmXyF3DC5
         bHHt7lF3q1aAfQSuuGe0OH9IGb5m+X3iinBjYBihd2XqsxftqKzWTHFS2KBwBWGWtVWQ
         U85NZU+PmJeqBJY1fAGUkb0UVuQ3AImVOCSe5hv3VhiIF9yTH9bXI48A7lWcTk/NuNjg
         nDEg001M6hMYrGFoUiEz4YQ3m5kp7E9tMgE5RB6XgExlJN0X3ArrP6vIu7nQZKupAdzN
         hBNmtkgA6mY8X72r122WfilD7nY+iVCVsR2EDN6CdF1+jqmLKXJgH0MngZw2+WpxOZg3
         SG7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=87T9wZal9/PpckvFihuEE4uSOyOrETTBOP9Ojac4rmQ=;
        b=Mihs2RE0gY8g7PSsRHPtICEqdlGfoa6eXBTbaVbRtoiBYtScyTyDz+snQPz4ZJ0F/b
         bG6BMH/0JFrn/NGQWVDrz2/FTND3Khtt77XDey6oJ2FGgwMVu/mGpql7+YJaK6YRW8UD
         KULVibL+7rslLxRORxY80HCdz6cLP51IOyl5ZS3awUnYBWox1tRhn7NyRYgUsycilTBD
         m1j8dzYSPfVnePXRlubaxi23PZNc7U7k6//PjCJ4dSliyZM4s0wRzlBQf9UFIZErSADG
         SBeJoWuJH30+A0ObSAuzhn0Uh+xZtcuqcp6LTawB07nfVeMYulqpC3XFKfSWkw7npXJv
         tI0w==
X-Gm-Message-State: AOAM530WtNLeSjAukE4PRcFZbLoQH6EWv9iQrQV88TJ9HX14adzz1+Wt
	qDJRFzPotfGONd5wHqIFTKeXC5PzH5Y=
X-Google-Smtp-Source: ABdhPJwCNkbhTcm5bsmmqZ29yWpUf5zoMFKKU17b6heYFWrAoMSYvi/3Cd/DsQK+ZG+g3LKFDRzqNg==
X-Received: by 2002:a05:6512:695:: with SMTP id t21mr6375lfe.390.1640034979130;
        Mon, 20 Dec 2021 13:16:19 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 06/10] iommu/ipmmu-vmsa: Add utlb_offset_base
Date: Mon, 20 Dec 2021 23:15:53 +0200
Message-Id: <1640034957-19764-7-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a non-verbatim port of corresponding Linux upsteam commit:
1289f7f15001c7ed36be6d23cb145c1d5feacdc8

Original commit message:
 commit 1289f7f15001c7ed36be6d23cb145c1d5feacdc8
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Wed Nov 6 11:35:50 2019 +0900

  iommu/ipmmu-vmsa: Add utlb_offset_base

  Since we will have changed memory mapping of the IPMMU in the future,
  this patch adds a utlb_offset_base into struct ipmmu_features
  for IMUCTR and IMUASID registers. No behavior change.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

This is a prereq work needed to add support for S4 series easily
in the future.

Almost the same change as original commit makes, but without updating
struct ipmmu_features_default which Xen driver doesn't have (there is
no support of old Arm32 based Gen2 SoCs).

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index ca33456..d8f96fc 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -111,6 +111,7 @@ struct ipmmu_features {
     unsigned int num_utlbs;
     unsigned int ctx_offset_base;
     unsigned int ctx_offset_stride;
+    unsigned int utlb_offset_base;
 };
 
 /* Root/Cache IPMMU device's information */
@@ -374,7 +375,7 @@ static void ipmmu_ctx_write_all(struct ipmmu_vmsa_domain *domain,
 
 static uint32_t ipmmu_utlb_reg(struct ipmmu_vmsa_device *mmu, uint32_t reg)
 {
-    return reg;
+    return mmu->features->utlb_offset_base + reg;
 }
 
 static void ipmmu_imuasid_write(struct ipmmu_vmsa_device *mmu,
@@ -738,6 +739,7 @@ static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
     .num_utlbs = 48,
     .ctx_offset_base = 0,
     .ctx_offset_stride = 0x40,
+    .utlb_offset_base = 0,
 };
 
 static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249994.430493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ15-0005Qi-Lo; Mon, 20 Dec 2021 21:16:19 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249994.430493; Mon, 20 Dec 2021 21:16:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ15-0005Pt-Da; Mon, 20 Dec 2021 21:16:19 +0000
Received: by outflank-mailman (input) for mailman id 249994;
 Mon, 20 Dec 2021 21:16:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ13-0005IB-FC
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:17 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 117e7a93-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:16 +0100 (CET)
Received: by mail-lf1-x136.google.com with SMTP id b22so24579611lfb.9
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:16 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.15
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 117e7a93-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=IcYUSZSwq8KqsYZymm7EDYV5w0Nvikp7Q2gZniejYm0=;
        b=AyKxPiiJPVhC/7JOQ/aRq6rTrMS0jzHgIDPh5CteMINaaQk//DlcT8W2eCtp5t/ruD
         1OXJneoc0AWC/P3AG9DbIijvwHyh00kh4GfqxyxmQlz67ZMubIFHMpPcMKqEMTN96bdJ
         5rLX1Jqgkjv9k6jaQI/ZCJqFPxrxaBoK6rYL5PgngX2Oo447nXOdeee4Vl9OfFXzscbV
         ZlUkBkjHNVpY6T01xqZWLDoxqlDkk5wMkirGNL20txR5uYuMUw/FzF+El1SSmT47c6KY
         Ra6G5ul4X6aEKW7mlCyY/c+lpNkbSTxM1qdfZuUY0sm5Vraz4yIvGinZad7uLx/KYJgn
         IQAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=IcYUSZSwq8KqsYZymm7EDYV5w0Nvikp7Q2gZniejYm0=;
        b=ZJRSB/e1IAQXcGpBpuJZhqszCOMbmwXTDF+kmH47KHlegiCy3Zb8ogprGtGVrOwC2k
         9XNTO1Ap9Rir1+VSz+5SK6ZCg322OAuZlf0kshGbE6QDVY+8IpzQ7oVBMWQC9PMImjYF
         wIa4jj7IV6bSMyqy0QmBBIvwOX/YCQn4HRiJfPORcy5F4yaRjADiWaq+Hf8xO0UqA9RM
         roQWKvQJOn49ZRkB7XMqYW/OhqcVhvVB8nZSGHTDhR02DXOraas9q8Fx5WfHCUifajvm
         Dr/gwgtGYxvT12e9H3/HpABqhDk6Y4iL2m2XoPSLmMEVG7x9kFX5N4jQBQAsaAR3yMdN
         peDQ==
X-Gm-Message-State: AOAM530hCVHktdr1gZpoLMXFPWFgWbhn0H8PyLSDY7IcsoezhOlrD6bf
	fXGD+iREaVVvNy3IrkFXZHMql6gmKdc=
X-Google-Smtp-Source: ABdhPJxtcms+sAXHt2sK2O2BBuG/He6QCMgCPzr3nG5Rz21E4S6lu+3lxbKwcZQsk5kkqukgFKw33A==
X-Received: by 2002:a05:6512:b81:: with SMTP id b1mr15523896lfv.301.1640034976255;
        Mon, 20 Dec 2021 13:16:16 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 02/10] iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers
Date: Mon, 20 Dec 2021 23:15:49 +0200
Message-Id: <1640034957-19764-3-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a non-verbatim port of corresponding Linux upsteam commit:
16d9454f5e0447f9c19cbf350b35ed377b9f64eb

Original commit message:
 commit 16d9454f5e0447f9c19cbf350b35ed377b9f64eb
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Wed Nov 6 11:35:47 2019 +0900

  iommu/ipmmu-vmsa: Add helper functions for MMU "context" registers

  Since we will have changed memory mapping of the IPMMU in the future,
  This patch adds helper functions ipmmu_ctx_{reg,read,write}()
  for MMU "context" registers. No behavior change.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
  Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

This is a prereq work needed to add support for S4 series easily
in the future.

Besides changes done in the original commit, we also need to update
an extra call sites which Linux driver doesn't have, but Xen driver
has such as ipmmu_ctx_write_cache(), etc.

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 4a8a974..ce5c3bc 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -307,18 +307,35 @@ static void ipmmu_write(struct ipmmu_vmsa_device *mmu, uint32_t offset,
     writel(data, mmu->base + offset);
 }
 
+static unsigned int ipmmu_ctx_reg(struct ipmmu_vmsa_device *mmu,
+                                  unsigned int context_id, uint32_t reg)
+{
+    return context_id * IM_CTX_SIZE + reg;
+}
+
+static uint32_t ipmmu_ctx_read(struct ipmmu_vmsa_device *mmu,
+                               unsigned int context_id, uint32_t reg)
+{
+    return ipmmu_read(mmu, ipmmu_ctx_reg(mmu, context_id, reg));
+}
+
+static void ipmmu_ctx_write(struct ipmmu_vmsa_device *mmu,
+                            unsigned int context_id, uint32_t reg,
+                            uint32_t data)
+{
+    ipmmu_write(mmu, ipmmu_ctx_reg(mmu, context_id, reg), data);
+}
+
 static uint32_t ipmmu_ctx_read_root(struct ipmmu_vmsa_domain *domain,
                                     uint32_t reg)
 {
-    return ipmmu_read(domain->mmu->root,
-                      domain->context_id * IM_CTX_SIZE + reg);
+    return ipmmu_ctx_read(domain->mmu->root, domain->context_id, reg);
 }
 
 static void ipmmu_ctx_write_root(struct ipmmu_vmsa_domain *domain,
                                  uint32_t reg, uint32_t data)
 {
-    ipmmu_write(domain->mmu->root,
-                domain->context_id * IM_CTX_SIZE + reg, data);
+    ipmmu_ctx_write(domain->mmu->root, domain->context_id, reg, data);
 }
 
 static void ipmmu_ctx_write_cache(struct ipmmu_vmsa_domain *domain,
@@ -329,8 +346,8 @@ static void ipmmu_ctx_write_cache(struct ipmmu_vmsa_domain *domain,
 
     /* Mask fields which are implemented in IPMMU-MM only. */
     if ( !ipmmu_is_root(domain->mmu) )
-        ipmmu_write(domain->mmu, domain->context_id * IM_CTX_SIZE + reg,
-                    data & IMCTR_COMMON_MASK);
+        ipmmu_ctx_write(domain->mmu, domain->context_id, reg,
+                        data & IMCTR_COMMON_MASK);
 }
 
 /*
@@ -693,7 +710,7 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
 
     /* Disable all contexts. */
     for ( i = 0; i < mmu->num_ctx; ++i )
-        ipmmu_write(mmu, i * IM_CTX_SIZE + IMCTR, 0);
+        ipmmu_ctx_write(mmu, i, IMCTR, 0);
 }
 
 /* R-Car Gen3 SoCs product and cut information. */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249997.430514 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ17-0005uL-3h; Mon, 20 Dec 2021 21:16:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249997.430514; Mon, 20 Dec 2021 21:16:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ16-0005s8-NX; Mon, 20 Dec 2021 21:16:20 +0000
Received: by outflank-mailman (input) for mailman id 249997;
 Mon, 20 Dec 2021 21:16:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ15-0005IG-EK
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:19 +0000
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
 [2a00:1450:4864:20::12b])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12c2dda6-61da-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 22:16:18 +0100 (CET)
Received: by mail-lf1-x12b.google.com with SMTP id g26so8789170lfv.11
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:18 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.17
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:18 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12c2dda6-61da-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=pEksiNlvmWwQkzdEtzPAm9Nfk2gTNz+eLaCmNe+DTYo=;
        b=am8z/7Yob+H2UTGTjya6uTQa7rUdvCbUngOkebg+qKaeSpYGyzSIrvJ7EMwWj1XoKr
         K06N30dXH4Ya6r5NRkfP7Kbq3AUyovcKRlhFAifLaKFjh0wpyqlA1CCvMqnxUIP300XO
         qPZHBw7A3XMfUzY98CqLsXjq4rblPZMW+izlcDchQkkG2Ln7nOn6fsDI3TZmCPIevUhi
         7xTDEfKfOl/tPU8p4Uf4B5yltkAugzAGRcCMG04YsLopZJVabFguruqaafRE5EZUtxdf
         hINrPiF0dBUdgotgLlJGIxiu4AYpO5s6VDf4TTk6b30x2gtrFxSdDjmEYM1T7PqlRLhK
         tasQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=pEksiNlvmWwQkzdEtzPAm9Nfk2gTNz+eLaCmNe+DTYo=;
        b=dDuPw21a8x04vSHfw12wt1DQx7QLg40m1FXsnEOFvqhNJgi026dsKrqrIH+GJ1W+VU
         BkVC4iCRQ0RSV1OtW/zyMlQ0kV4POB3Z2QymLYwJ7trc8Oczf9xUo05fBKf8IdmhRUKb
         7IMD7UahJ5OHTrQ3f0oOvNYlu3mmelFhQ4t7HZRk7tCuyC1I3h90w78cVrMsyFDrtj9d
         cprcCdY1aT38LZdkdSF83QVifZKSVdkzTq9ZoEv9o6UGxdMMtQJYKtCFMjHZ2s/QeDxm
         aaf/rm4PtSWFMESgfgWFtqhljZX3vXU5ZCgNnaVYSc4EY8K3l11bnQxm1gPPcR6DHnE0
         Wqyg==
X-Gm-Message-State: AOAM530GVZ+ZtNg9BpCTMV2kA/+vEdiET7qFmqwRkkVtQg07DlNQPvlZ
	6Oy7H+B8Izj5PvHifGBXsv13biq9Fos=
X-Google-Smtp-Source: ABdhPJw93aoMRmely2aqCzGAJO09jqMJYElGYtnjBWYvpkqFmTS/JmHJB974Po0oKy9cfrYkXDq3kQ==
X-Received: by 2002:a19:690e:: with SMTP id e14mr9186lfc.298.1640034978409;
        Mon, 20 Dec 2021 13:16:18 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 05/10] iommu/ipmmu-vmsa: Calculate context registers' offset instead of a macro
Date: Mon, 20 Dec 2021 23:15:52 +0200
Message-Id: <1640034957-19764-6-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a non-verbatim port of corresponding Linux upsteam commit:
3dc28d9f59eaae41461542b27afe70339347ebb3

Original commit message:
 commit 3dc28d9f59eaae41461542b27afe70339347ebb3
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Wed Nov 6 11:35:48 2019 +0900

  iommu/ipmmu-vmsa: Calculate context registers' offset instead of a macro

  Since we will have changed memory mapping of the IPMMU in the future,
  this patch uses ipmmu_features values instead of a macro to
  calculate context registers offset. No behavior change.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
  Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

This is a prereq work needed to add support for S4 series easily
in the future.

Almost the same change as original commit makes, but without updating
struct ipmmu_features_default which Xen driver doesn't have (there is
no support of old Arm32 based Gen2 SoCs).

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 369be4c..ca33456 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -109,6 +109,8 @@ struct ipmmu_vmsa_xen_device {
 struct ipmmu_features {
     unsigned int number_of_contexts;
     unsigned int num_utlbs;
+    unsigned int ctx_offset_base;
+    unsigned int ctx_offset_stride;
 };
 
 /* Root/Cache IPMMU device's information */
@@ -167,8 +169,6 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define TLB_LOOP_TIMEOUT    100 /* 100us */
 
 /* Registers Definition */
-#define IM_CTX_SIZE    0x40
-
 #define IMCTR                0x0000
 /*
  * This field is implemented in IPMMU-MM only. So, can be set for
@@ -315,7 +315,8 @@ static void ipmmu_write(struct ipmmu_vmsa_device *mmu, uint32_t offset,
 static unsigned int ipmmu_ctx_reg(struct ipmmu_vmsa_device *mmu,
                                   unsigned int context_id, uint32_t reg)
 {
-    return context_id * IM_CTX_SIZE + reg;
+    return mmu->features->ctx_offset_base +
+        context_id * mmu->features->ctx_offset_stride + reg;
 }
 
 static uint32_t ipmmu_ctx_read(struct ipmmu_vmsa_device *mmu,
@@ -735,6 +736,8 @@ static int ipmmu_init_platform_device(struct device *dev,
 static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
     .number_of_contexts = 8,
     .num_utlbs = 48,
+    .ctx_offset_base = 0,
+    .ctx_offset_stride = 0x40,
 };
 
 static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249996.430507 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ16-0005p6-Iz; Mon, 20 Dec 2021 21:16:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249996.430507; Mon, 20 Dec 2021 21:16:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ16-0005nM-By; Mon, 20 Dec 2021 21:16:20 +0000
Received: by outflank-mailman (input) for mailman id 249996;
 Mon, 20 Dec 2021 21:16:19 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ14-0005IG-RZ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:18 +0000
Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com
 [2a00:1450:4864:20::130])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 125b3604-61da-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 22:16:18 +0100 (CET)
Received: by mail-lf1-x130.google.com with SMTP id b22so24579781lfb.9
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:18 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.17
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:17 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 125b3604-61da-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=KJJAXoBnqeeexsUsPrxE65JqoMaWk11lTyVByXKTYSU=;
        b=gOLATyKm4zSuOWV9E6Se+183dJv3dZ4/1hi1dCnT5d0xz/p49ipsWk4V+62Um9IuBV
         rXA6KY/y9/6AbhC7qupKNiWW2cVU68mDGL7tetdBNNv1EtYpiFMhUVL2ihZ7sGQxh3M9
         cVb7anEJhQ2h3n6Z2f32MmLl6TWR+uugTRwLnidi1KpP4CFIO0Dn9ztq49JAzMtWx/nZ
         OI/iBvIwdtbUhiX81WTHj1fvg+TJi10f6qqRdn0KEmkhI9SHbfRvkevt71a8XedKaQkc
         IV1Kjwr0YxIQZvKezY9U/6U5tg4DhurweX+Yna+L9OBmffGONeFCvmXZoW6Ktzu8f5UH
         phqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=KJJAXoBnqeeexsUsPrxE65JqoMaWk11lTyVByXKTYSU=;
        b=JeaTIAcOoi00fNUCrMfXj9FnPM0kHTd6CxIKb3c9VR7/brW90m1WLx0GWmF+IebHjQ
         6A6QYWcY+q9xkOpHF1HAE8jSAJ/WOpybjubcD9XYh6hnrOa9j6g/TFjAAjhne3OIR/fX
         ybIAbxsH5VZncI9SXpKV0xohWOh0qXxcmVhZ49oaIuMjMqqjZQgTV4CdAEclY9WjKUFW
         Yr6mkAPQjbhO9e/MQHM/ilxrhKnB1x/StnxfI/DBkFop52Fy/Ma5NKUoKyv2WC8N6k3E
         blWqh/5JtC+5Rd+/Gclyf1bf2H48wAxGR1ccqgI94SqDpwZzPv8Gv5T65AC5gJ12RsrT
         btwA==
X-Gm-Message-State: AOAM530Lfr0WFzL/C+WqWtc/c8mzry2i9tb+7vKIdqdMJzqawPgFdQXW
	lsGzCoC0lPd2/jGDEsROR4cEudD+bZE=
X-Google-Smtp-Source: ABdhPJzeapJ3eaEjC6WFLDArDArLz+er0iTpagcYpbad82rG1wadmR8bGLj+UfFhkSAmAEukK9hM2w==
X-Received: by 2002:a19:dc4b:: with SMTP id f11mr17029793lfj.585.1640034977686;
        Mon, 20 Dec 2021 13:16:17 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 04/10] iommu/ipmmu-vmsa: Add light version of Linux's ipmmu_features
Date: Mon, 20 Dec 2021 23:15:51 +0200
Message-Id: <1640034957-19764-5-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This is a prereq work needed to add support for S4 series easily
in the future.

We don't need to pull the whole struct and all instances as Xen
driver doesn't support old Arm32 based Gen2 SoCs, so there is no
point in keeping all differences between Gen2 and Gen3 here.
All what we need is a minimal support to be able to operate with
Gen3 and new S4.

Add Gen3 specific info with only two fields (number_of_contexts and
num_utlbs) for now, the subsequent patches will add remaining bits.

No change in behavior.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 54 +++++++++++++++++++++++---------
 1 file changed, 40 insertions(+), 14 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 1b94af2..369be4c 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -71,9 +71,9 @@
  * R-Car Gen3 SoCs make use of up to 8 IPMMU contexts (sets of page table) and
  * these can be managed independently. Each context is mapped to one Xen domain.
  */
-#define IPMMU_CTX_MAX     8
+#define IPMMU_CTX_MAX     8U
 /* R-Car Gen3 SoCs make use of up to 48 micro-TLBs per IPMMU device. */
-#define IPMMU_UTLB_MAX    48
+#define IPMMU_UTLB_MAX    48U
 
 /* IPMMU context supports IPA size up to 40 bit. */
 #define IPMMU_MAX_P2M_IPA_BITS    40
@@ -106,17 +106,22 @@ struct ipmmu_vmsa_xen_device {
     struct ipmmu_vmsa_device *mmu;
 };
 
+struct ipmmu_features {
+    unsigned int number_of_contexts;
+    unsigned int num_utlbs;
+};
+
 /* Root/Cache IPMMU device's information */
 struct ipmmu_vmsa_device {
     struct device *dev;
     void __iomem *base;
     struct ipmmu_vmsa_device *root;
     struct list_head list;
-    unsigned int num_utlbs;
     unsigned int num_ctx;
     spinlock_t lock;    /* Protects ctx and domains[] */
     DECLARE_BITMAP(ctx, IPMMU_CTX_MAX);
     struct ipmmu_vmsa_domain *domains[IPMMU_CTX_MAX];
+    const struct ipmmu_features *features;
 };
 
 /*
@@ -727,6 +732,11 @@ static int ipmmu_init_platform_device(struct device *dev,
     return 0;
 }
 
+static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
+    .number_of_contexts = 8,
+    .num_utlbs = 48,
+};
+
 static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
 {
     unsigned int i;
@@ -798,6 +808,27 @@ static __init bool ipmmu_stage2_supported(void)
     return stage2_supported;
 }
 
+static const struct dt_device_match ipmmu_dt_match[] __initconst =
+{
+    {
+        .compatible = "renesas,ipmmu-r8a7795",
+        .data = &ipmmu_features_rcar_gen3,
+    },
+    {
+        .compatible = "renesas,ipmmu-r8a77965",
+        .data = &ipmmu_features_rcar_gen3,
+    },
+    {
+        .compatible = "renesas,ipmmu-r8a7796",
+        .data = &ipmmu_features_rcar_gen3,
+    },
+    {
+        .compatible = "renesas,ipmmu-r8a77961",
+        .data = &ipmmu_features_rcar_gen3,
+    },
+    { /* sentinel */ },
+};
+
 /*
  * This function relies on the fact that Root IPMMU device is being probed
  * the first. If not the case, it denies further Cache IPMMU device probes
@@ -806,6 +837,7 @@ static __init bool ipmmu_stage2_supported(void)
  */
 static int ipmmu_probe(struct dt_device_node *node)
 {
+    const struct dt_device_match *match;
     struct ipmmu_vmsa_device *mmu;
     uint64_t addr, size;
     int irq, ret;
@@ -817,9 +849,12 @@ static int ipmmu_probe(struct dt_device_node *node)
         return -ENOMEM;
     }
 
+    match = dt_match_node(ipmmu_dt_match, node);
+    ASSERT(match);
+    mmu->features = match->data;
+
     mmu->dev = &node->dev;
-    mmu->num_utlbs = IPMMU_UTLB_MAX;
-    mmu->num_ctx = IPMMU_CTX_MAX;
+    mmu->num_ctx = min(IPMMU_CTX_MAX, mmu->features->number_of_contexts);
     spin_lock_init(&mmu->lock);
     bitmap_zero(mmu->ctx, IPMMU_CTX_MAX);
 
@@ -1296,15 +1331,6 @@ static const struct iommu_ops ipmmu_iommu_ops =
     .add_device      = ipmmu_add_device,
 };
 
-static const struct dt_device_match ipmmu_dt_match[] __initconst =
-{
-    DT_MATCH_COMPATIBLE("renesas,ipmmu-r8a7795"),
-    DT_MATCH_COMPATIBLE("renesas,ipmmu-r8a77965"),
-    DT_MATCH_COMPATIBLE("renesas,ipmmu-r8a7796"),
-    DT_MATCH_COMPATIBLE("renesas,ipmmu-r8a77961"),
-    { /* sentinel */ },
-};
-
 static __init int ipmmu_init(struct dt_device_node *node, const void *data)
 {
     int ret;
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250000.430546 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ19-0006la-IF; Mon, 20 Dec 2021 21:16:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250000.430546; Mon, 20 Dec 2021 21:16:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ19-0006jw-7Z; Mon, 20 Dec 2021 21:16:23 +0000
Received: by outflank-mailman (input) for mailman id 250000;
 Mon, 20 Dec 2021 21:16:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ17-0005IG-Om
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:21 +0000
Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com
 [2a00:1450:4864:20::134])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1421b50b-61da-11ec-9e60-abaf8a552007;
 Mon, 20 Dec 2021 22:16:21 +0100 (CET)
Received: by mail-lf1-x134.google.com with SMTP id bt1so24503094lfb.13
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:21 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.20
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1421b50b-61da-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=WeHEjPAzdPl1ntiWMAL8hlkKvubzizi7P4jP/3KCTl4=;
        b=YjBJFHQOwM4G+wWsfiqU7jf8lspX3+GX5u0wGwI9QDNRrnUG37FpFNMnM1cc6K6rhn
         XmU7t5q7Nk7JAbqU7CRjCoBcil1ps5xvhznTAjDjEiwLj4zOfKWyfSR1ESeJ9iGnj83+
         JEX+wfDmcKHrY4zymy0DHdyH5LIiDKr7UNHvhT3nQ261hO7XmBla8rE5H0xso4xhIJ9x
         0dn/xgV0gKpOD6M9uTPWC1f2O2zrqDXRlLjfwhBLv/V0yG4+3sS5YTnEC/7Cz823K4N0
         7LHknbZNDIfZViUKwMJ6vSCW9/ZQkROAunoZdOcjHEFvx84l/HfrYCNWrn1tn5aqXgcY
         TC2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=WeHEjPAzdPl1ntiWMAL8hlkKvubzizi7P4jP/3KCTl4=;
        b=8DQjMwfUpcQg0Peaqjg6kjiKYJvb4xdQLpA1pQ9NMij3Vc84SS80xUu/Bccmq55Ns3
         SXR9gaUmDrws8oza/glDC6btlp+gD/B5snDbp7SvTOOsAvStvNYBa64903lmwJqka1fg
         xN7I1nT0ymvADVXT35GkER1MDC+AYPVBPt4mhh5G8w0GHIY8HzwEVjznsc8wkPfmp5Jq
         J4/YhVTnUftQo8ttFql1GFnGRConWwhaPauG9sx0vvzR+8ze9cRFF7xT37sTDqxWzQK5
         FszMZHYnDz5NkpMqZPA7LUuJlqlHoWCtCsfvx3uWYuCOHcemCoDBAnplnHDHEpv6BpR0
         XIwQ==
X-Gm-Message-State: AOAM530JHvDNW1yWoN7m0KfE78VT7vQG1kozKfOk601uz9VHiTRtRdVg
	ltH23VQMWtv6h6uY5Zbq6e1E39c/vmk=
X-Google-Smtp-Source: ABdhPJzpSS1SrTorcSVD6F21ky5lwYz7Lq/x4dTSm0jmtZAUI5674vxgWrEY49t/rUCfC3QXJWnRhQ==
X-Received: by 2002:a19:8c4b:: with SMTP id i11mr3428387lfj.81.1640034980647;
        Mon, 20 Dec 2021 13:16:20 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 08/10] iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
Date: Mon, 20 Dec 2021 23:15:55 +0200
Message-Id: <1640034957-19764-9-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Based on the following commits from the Renesas BSP:
8fba83d97cca709a05139c38e29408e81ed4cf62
a8d93bc07da89a7fcf4d85f34d119a030310efa5
located at:
https://github.com/renesas-rcar/linux-bsp/tree/v5.10.41/rcar-5.1.3.rc5

Original commit messages:
 commit 8fba83d97cca709a05139c38e29408e81ed4cf62
 Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
 Date:   Wed Apr 28 18:54:44 2021 +0700

  iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0

  Need to set bit IMSCTLR_USE_SECGRP to 0
  because H/W initial value is unknown, without this
  dma-transfer cannot be done due to address translation doesn't work.

  Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>

 commit a8d93bc07da89a7fcf4d85f34d119a030310efa5
 Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
 Date:   Tue Sep 7 14:46:12 2021 +0700

  iommu/ipmmu-vmsa: Update IMSCTLR register offset address for R-Car S4

  Update IMSCTLR register offset address to align with R-Car S4 H/W UM.

  Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>

**********

It is still a question whether this really needs to be done in Xen,
rather in firmware, but better to be on the safe side. After all,
if firmware already takes care of clearing this bit, nothing bad
will happen.

Please note the following:
1. I decided to squash both commits since the first commit adds clearing
code and only the second one makes it functional on S4. Moreover, this is
not a direct port. So it would be better to introduce complete solution
by a single patch.
2. Although patch indeed does what it claims in the subject,
the implementation is different in comparison with original changes.
On Linux the clearing is done at runtime in ipmmu_domain_setup_context().
On Xen the clearing is done at boot time in ipmmu_probe().
The IMSCTLR is not a MMU "context" register at all, so I think there is
no point in performing the clearing each time we initialize the context,
instead perform the clearing at once during initialization. Also do not
abuse ctx_offset_stride_adj field for the register's offset calculation,
instead use recently added control_offset_base field.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
---
Changes V1 -> V2:
   - add R-b
   - update patch description
   - replace ctx_offset_stride_adj with control_offset_base for
     register's offset calculation
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 14848ce..649b9f6 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -222,6 +222,9 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMUASID0(n)            (0x0308 + ((n) * 16))
 #define IMUASID32(n)           (0x0608 + (((n) - 32) * 16))
 
+#define IMSCTLR             0x0500
+#define IMSCTLR_USE_SECGRP  (1 << 28)
+
 #define IMSAUXCTLR          0x0504
 #define IMSAUXCTLR_S2PTE    (1 << 3)
 
@@ -966,6 +969,10 @@ static int ipmmu_probe(struct dt_device_node *node)
         set_bit(0, mmu->ctx);
     }
 
+    /* Do not use security group function. */
+    reg = IMSCTLR + mmu->features->control_offset_base;
+    ipmmu_write(mmu, reg, ipmmu_read(mmu, reg) & ~IMSCTLR_USE_SECGRP);
+
     spin_lock(&ipmmu_devices_lock);
     list_add(&mmu->list, &ipmmu_devices);
     spin_unlock(&ipmmu_devices_lock);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.249999.430553 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ1A-0006wV-EP; Mon, 20 Dec 2021 21:16:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 249999.430553; Mon, 20 Dec 2021 21:16:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ19-0006sE-UQ; Mon, 20 Dec 2021 21:16:23 +0000
Received: by outflank-mailman (input) for mailman id 249999;
 Mon, 20 Dec 2021 21:16:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ17-0005IB-KY
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:21 +0000
Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com
 [2a00:1450:4864:20::22c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13d17607-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:20 +0100 (CET)
Received: by mail-lj1-x22c.google.com with SMTP id a37so18017962ljq.13
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:20 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.19
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:19 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13d17607-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=qvpXNTLTS2Ou2xoiYRMuZM4a44G4SigTrlNi3wejEhU=;
        b=f4oJF2gkVGsK6/9ewRqi+f5aAOA1Nb1HZ8Q04mKakwVTxo62yuJLYRYDebhnjBSZcx
         GIlAslICYpPvlevexgjuP4Ar64EhJZ7U+pIeHTQDvR1m7i0Dmv/R3AV26YqzjvPLdAt0
         Dl8gdT6iXKtLSVIwlAKH9YXHIzc9b61vZrPC5hEQPO2KXk26Ix7KtRMJS0q6HVZIHB1q
         98lNyRZXUK0y23oqhTOJXN8t5p8mEL5tQN9Ms3SfqFpZMTI3XCqvQug5kQOxPyfBXRao
         VYyJVi7hR/BXOausPApKYjuWxS+Dq+Ka+yIrUM32SDTKj8ofNhqRZtDPiREKFc/9jSk/
         +RJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=qvpXNTLTS2Ou2xoiYRMuZM4a44G4SigTrlNi3wejEhU=;
        b=pNvYMXpecA7F+ll9zstPr48ra3OEGE6CCYoS5LS178ufaUo49mDl0ljOis4FXPUR2o
         9xdlmM2k6c8kfHKelopr0aWZAje942LHsHzPOzJVSvp0TQPkMwc+Pioga61mc0h00oB8
         +w8cnXtZVaCn31ZLtBYNHiYHmTXOvQPrcMQhrSGMwoFTl3gtANI+gDo/heJYSszXWO+K
         7csa1uCvnNAI9siQDPAIryHtzz1JBzyzO2uY7cBOPkZrZKCmKnYnSEXanNaJxHPH4+DV
         LROdNwTmi9cLfds4g3LytzHrdkXK6fj6h9nqP2BiAh/ZgpBeASDPZGWGTzPYuKSBo//D
         CUBw==
X-Gm-Message-State: AOAM5329SApkWWV4hfDd0flPlFxT8qx3ZI8einM4BrueFRUmhSFUtqJb
	XN6wU0GLlHDYnK8/VeufR0LsXep3+gA=
X-Google-Smtp-Source: ABdhPJxWPezQF6NbeQ18VRNYks8+OCfDkLbPeHBRDUAWe/GGifNO9f82mjeawDjmJjCu/EpwKVrHsQ==
X-Received: by 2002:a2e:a482:: with SMTP id h2mr15951927lji.87.1640034979903;
        Mon, 20 Dec 2021 13:16:19 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Jan Beulich <jbeulich@suse.com>,
	Paul Durrant <paul@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
Date: Mon, 20 Dec 2021 23:15:54 +0200
Message-Id: <1640034957-19764-8-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Based on the following Linux upsteam commit:
7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792

Original commit message:
 commit 7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
 Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 Date:   Tue Sep 7 17:30:20 2021 +0900

  iommu/ipmmu-vmsa: Add support for r8a779a0

  Add support for r8a779a0 (R-Car V3U). The IPMMU hardware design
  of this SoC differs than others. So, add a new ipmmu_features for it.

  Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
  Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
  Link: https://lore.kernel.org/r/20210907083020.907648-3-yoshihiro.shimoda.uh@renesas.com
  Signed-off-by: Joerg Roedel <jroedel@suse.de>

**********

The R-Car S4 is an automotive System-on-Chip (SoC) for Car
Server/Communication Gateway and is one of the first products
in Renesas’ 4th-generation R-Car Family.

The integrated IOMMU HW is also VMSA-compatible and supports
stage 2 translation table format, therefore can be used with
current driver with slight modifications (thanks to the prereq
work).

In the context of Xen driver the main differences between Gen3
and Gen4 are the following:
- HW capacity was enlarged to support up to 16 IPMMU contexts
  (sets of page table) and up to 64 micro-TLBs per IPMMU device
- the memory mapped registers have different bases and offsets

Please note that Linux upstream doesn't support R-Car S4 SoC
yet unlike Renesas BSP [1], but it was decided to reuse upstream
patch for R-Car V3U anyway as the IPMMU HW settings are similar.

[1]
7003b9f732cf iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
https://github.com/renesas-rcar/linux-bsp/tree/v5.10.41/rcar-5.1.3.rc5

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
Changes V1 -> V2:
   - base on the Linux upsteam patch instead of BSP's one
   - update patch description and comments in code
   - replace ipmmu_features_rcar_s4 with ipmmu_features_rcar_gen4
   - introduce control_offset_base field
---
 xen/drivers/passthrough/Kconfig          |  6 +--
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 63 +++++++++++++++++++++++---------
 2 files changed, 49 insertions(+), 20 deletions(-)

diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
index 09505aa..479d7de 100644
--- a/xen/drivers/passthrough/Kconfig
+++ b/xen/drivers/passthrough/Kconfig
@@ -25,14 +25,14 @@ config ARM_SMMU_V3
 	 the ARM SMMUv3 architecture.
 
 config IPMMU_VMSA
-	bool "Renesas IPMMU-VMSA found in R-Car Gen3 SoCs"
+	bool "Renesas IPMMU-VMSA found in R-Car Gen3/Gen4 SoCs"
 	depends on ARM_64
 	---help---
 	  Support for implementations of the Renesas IPMMU-VMSA found
-	  in R-Car Gen3 SoCs.
+	  in R-Car Gen3/Gen4 SoCs.
 
 	  Say Y here if you are using newest R-Car Gen3 SoCs revisions
-	  (H3 ES3.0, M3-W+, etc) which IPMMU hardware supports stage 2
+	  (H3 ES3.0, M3-W+, etc) or Gen4 SoCs which IPMMU hardware supports stage 2
 	  translation table format and is able to use CPU's P2M table as is.
 
 endif
diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index d8f96fc..14848ce 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -1,15 +1,15 @@
 /*
  * xen/drivers/passthrough/arm/ipmmu-vmsa.c
  *
- * Driver for the Renesas IPMMU-VMSA found in R-Car Gen3 SoCs.
+ * Driver for the Renesas IPMMU-VMSA found in R-Car Gen3/Gen4 SoCs.
  *
  * The IPMMU-VMSA is VMSA-compatible I/O Memory Management Unit (IOMMU)
  * which provides address translation and access protection functionalities
  * to processing units and interconnect networks.
  *
  * Please note, current driver is supposed to work only with newest
- * R-Car Gen3 SoCs revisions which IPMMU hardware supports stage 2 translation
- * table format and is able to use CPU's P2M table as is.
+ * R-Car Gen3/Gen4 SoCs revisions which IPMMU hardware supports stage 2
+ * translation table format and is able to use CPU's P2M table as is.
  *
  * Based on Linux's IPMMU-VMSA driver from Renesas BSP:
  *    drivers/iommu/ipmmu-vmsa.c
@@ -20,9 +20,9 @@
  * and Xen's SMMU driver:
  *    xen/drivers/passthrough/arm/smmu.c
  *
- * Copyright (C) 2014-2019 Renesas Electronics Corporation
+ * Copyright (C) 2014-2021 Renesas Electronics Corporation
  *
- * Copyright (C) 2016-2019 EPAM Systems Inc.
+ * Copyright (C) 2016-2021 EPAM Systems Inc.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms and conditions of the GNU General Public
@@ -68,12 +68,13 @@
     dev_print(dev, XENLOG_ERR, fmt, ## __VA_ARGS__)
 
 /*
- * R-Car Gen3 SoCs make use of up to 8 IPMMU contexts (sets of page table) and
- * these can be managed independently. Each context is mapped to one Xen domain.
+ * R-Car Gen3/Gen4 SoCs make use of up to 16 IPMMU contexts (sets of page table)
+ * and these can be managed independently. Each context is mapped to one Xen
+ * domain.
  */
-#define IPMMU_CTX_MAX     8U
-/* R-Car Gen3 SoCs make use of up to 48 micro-TLBs per IPMMU device. */
-#define IPMMU_UTLB_MAX    48U
+#define IPMMU_CTX_MAX     16U
+/* R-Car Gen3/Gen4 SoCs make use of up to 64 micro-TLBs per IPMMU device. */
+#define IPMMU_UTLB_MAX    64U
 
 /* IPMMU context supports IPA size up to 40 bit. */
 #define IPMMU_MAX_P2M_IPA_BITS    40
@@ -112,6 +113,8 @@ struct ipmmu_features {
     unsigned int ctx_offset_base;
     unsigned int ctx_offset_stride;
     unsigned int utlb_offset_base;
+    unsigned int control_offset_base;
+    unsigned int imuctr_ttsel_mask;
 };
 
 /* Root/Cache IPMMU device's information */
@@ -211,7 +214,6 @@ static DEFINE_SPINLOCK(ipmmu_devices_lock);
 #define IMUCTR0(n)             (0x0300 + ((n) * 16))
 #define IMUCTR32(n)            (0x0600 + (((n) - 32) * 16))
 #define IMUCTR_TTSEL_MMU(n)    ((n) << 4)
-#define IMUCTR_TTSEL_MASK      (15 << 4)
 #define IMUCTR_TTSEL_SHIFT     4
 #define IMUCTR_FLUSH           (1 << 1)
 #define IMUCTR_MMUEN           (1 << 0)
@@ -316,8 +318,12 @@ static void ipmmu_write(struct ipmmu_vmsa_device *mmu, uint32_t offset,
 static unsigned int ipmmu_ctx_reg(struct ipmmu_vmsa_device *mmu,
                                   unsigned int context_id, uint32_t reg)
 {
-    return mmu->features->ctx_offset_base +
-        context_id * mmu->features->ctx_offset_stride + reg;
+    unsigned int base = mmu->features->ctx_offset_base;
+
+    if ( context_id > 7 )
+        base += 0x800 - 8 * 0x40;
+
+    return base + context_id * mmu->features->ctx_offset_stride + reg;
 }
 
 static uint32_t ipmmu_ctx_read(struct ipmmu_vmsa_device *mmu,
@@ -448,7 +454,8 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_domain *domain,
     {
         unsigned int context_id;
 
-        context_id = (imuctr & IMUCTR_TTSEL_MASK) >> IMUCTR_TTSEL_SHIFT;
+        context_id = (imuctr & mmu->features->imuctr_ttsel_mask) >>
+            IMUCTR_TTSEL_SHIFT;
         if ( domain->context_id != context_id )
         {
             dev_err(mmu->dev, "Micro-TLB %u already assigned to IPMMU context %u\n",
@@ -740,6 +747,18 @@ static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
     .ctx_offset_base = 0,
     .ctx_offset_stride = 0x40,
     .utlb_offset_base = 0,
+    .control_offset_base = 0,
+    .imuctr_ttsel_mask = (15 << 4),
+};
+
+static const struct ipmmu_features ipmmu_features_rcar_gen4 = {
+    .number_of_contexts = 16,
+    .num_utlbs = 64,
+    .ctx_offset_base = 0x10000,
+    .ctx_offset_stride = 0x1040,
+    .utlb_offset_base = 0x3000,
+    .control_offset_base = 0x1000,
+    .imuctr_ttsel_mask = (31 << 4),
 };
 
 static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
@@ -751,11 +770,12 @@ static void ipmmu_device_reset(struct ipmmu_vmsa_device *mmu)
         ipmmu_ctx_write(mmu, i, IMCTR, 0);
 }
 
-/* R-Car Gen3 SoCs product and cut information. */
+/* R-Car Gen3/Gen4 SoCs product and cut information. */
 #define RCAR_PRODUCT_MASK    0x00007F00
 #define RCAR_PRODUCT_H3      0x00004F00
 #define RCAR_PRODUCT_M3W     0x00005200
 #define RCAR_PRODUCT_M3N     0x00005500
+#define RCAR_PRODUCT_S4      0x00005A00
 #define RCAR_CUT_MASK        0x000000FF
 #define RCAR_CUT_VER30       0x00000020
 
@@ -803,6 +823,10 @@ static __init bool ipmmu_stage2_supported(void)
         stage2_supported = true;
         break;
 
+    case RCAR_PRODUCT_S4:
+        stage2_supported = true;
+        break;
+
     default:
         printk(XENLOG_ERR "ipmmu: Unsupported SoC version\n");
         break;
@@ -831,6 +855,10 @@ static const struct dt_device_match ipmmu_dt_match[] __initconst =
         .compatible = "renesas,ipmmu-r8a77961",
         .data = &ipmmu_features_rcar_gen3,
     },
+    {
+        .compatible = "renesas,ipmmu-r8a779f0",
+        .data = &ipmmu_features_rcar_gen4,
+    },
     { /* sentinel */ },
 };
 
@@ -845,6 +873,7 @@ static int ipmmu_probe(struct dt_device_node *node)
     const struct dt_device_match *match;
     struct ipmmu_vmsa_device *mmu;
     uint64_t addr, size;
+    uint32_t reg;
     int irq, ret;
 
     mmu = xzalloc(struct ipmmu_vmsa_device);
@@ -930,8 +959,8 @@ static int ipmmu_probe(struct dt_device_node *node)
          * Use stage 2 translation table format when stage 2 translation
          * enabled.
          */
-        ipmmu_write(mmu, IMSAUXCTLR,
-                    ipmmu_read(mmu, IMSAUXCTLR) | IMSAUXCTLR_S2PTE);
+        reg = IMSAUXCTLR + mmu->features->control_offset_base;
+        ipmmu_write(mmu, reg, ipmmu_read(mmu, reg) | IMSAUXCTLR_S2PTE);
 
         dev_info(&node->dev, "IPMMU context 0 is reserved\n");
         set_bit(0, mmu->ctx);
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250001.430567 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ1B-0007KU-R4; Mon, 20 Dec 2021 21:16:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250001.430567; Mon, 20 Dec 2021 21:16:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ1B-0007Gz-FG; Mon, 20 Dec 2021 21:16:25 +0000
Received: by outflank-mailman (input) for mailman id 250001;
 Mon, 20 Dec 2021 21:16:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ18-0005IB-Ra
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:22 +0000
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com
 [2a00:1450:4864:20::232])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 14a0a55c-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:22 +0100 (CET)
Received: by mail-lj1-x232.google.com with SMTP id u22so18047883lju.7
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:22 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.20
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:21 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 14a0a55c-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=ruH/ZtUTmX8iN6zofPsz6r1KAf8lKOAgjKOqJDL6kwU=;
        b=CDMSfqEUyrVBM25MEGIzHLeoHcUFlBF7AVUEDESUE2sPkWXL1Pj7uRg78VNv5JoKuc
         54fvBdonm1Nq4ZFPMqV5wAT0Burub2MDNaPv3jjEddM4NEa4TLhHI/nQIAGNranFaIv3
         +JXNyPkx9D5HBA/g/4ar7r/RDoZ3Z9N8I6JA/QgJNtlJRziKacOOxL/xiKvpeibC6htM
         JnUDFzpcJqsHwPYmUrz2IxA+MQSteMNkPsvdiRFcYB9H28gvILoJVOoqN6Cl3MK0ajI3
         CfgvX7UrBZdqSEGs4wwbU/zALJm1rUmGQOGszcuDxqlTITemRI+rvjGe9AsDNfT+0ccm
         HwnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=ruH/ZtUTmX8iN6zofPsz6r1KAf8lKOAgjKOqJDL6kwU=;
        b=zhjPMWyp+8AOBFtbc+e+Z2nfiME/orkJ5Yx2V/kfJ79Rj/M5THNnsDJWidNJ7y+MgO
         VfqEAujqKsDYqDEBlAWxjsDECF9KvWmFWbpYPx3L/vWWkYWurJ0c8A8DhtHRmkw5nEKg
         Ahdm62dSqQ7iuDhrylDTJOuBBHi7yAc+jCdzL+SN8QRa4A8xj+Td3lgGill1DZ5ZqvgC
         06uWkULJiZ5Ab3m9dABvcfzovdKDe7hLt7XC0AhOQpq2GyiTthGYAI5uMBMeHdhf4Ke3
         LvUMZWXlWGWnqNuLvEEykF9Gt1YSRNb13a0tJ97mh9cSgA6FIMnylKAioBbZBEFc9/9V
         5RMg==
X-Gm-Message-State: AOAM5318VfgoU2m2ST7N8KYvOdK4spF3QC1W4sch8EWFkAx9jtn8QLg8
	tJUQtC+6XQDB4crs9pLVetr7Tuf2MvY=
X-Google-Smtp-Source: ABdhPJygzn941uf9Tjg3K5YR8Nj0KXaAS2tnW+3lvktFAgQUqXlC3Yrmbyf+ZosfHupnIONO+S2H8g==
X-Received: by 2002:a2e:3c17:: with SMTP id j23mr16332638lja.391.1640034981391;
        Mon, 20 Dec 2021 13:16:21 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 09/10] iommu/ipmmu-vmsa: Use refcount for the micro-TLBs
Date: Mon, 20 Dec 2021 23:15:56 +0200
Message-Id: <1640034957-19764-10-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

Reference-count the micro-TLBs as several bus masters can be
connected to the same micro-TLB (and drop TODO comment).
This wasn't an issue so far, since the platform devices
(this driver deals with) get assigned/deassigned together during
domain creation/destruction. But, in order to support PCI devices
(which are hot-pluggable) in the near future we will need to
take care of.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
   - add ASSERT() in ipmmu_utlb_disable()
---
 xen/drivers/passthrough/arm/ipmmu-vmsa.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 649b9f6..1224ea4 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -127,6 +127,7 @@ struct ipmmu_vmsa_device {
     spinlock_t lock;    /* Protects ctx and domains[] */
     DECLARE_BITMAP(ctx, IPMMU_CTX_MAX);
     struct ipmmu_vmsa_domain *domains[IPMMU_CTX_MAX];
+    unsigned int utlb_refcount[IPMMU_UTLB_MAX];
     const struct ipmmu_features *features;
 };
 
@@ -467,13 +468,12 @@ static int ipmmu_utlb_enable(struct ipmmu_vmsa_domain *domain,
         }
     }
 
-    /*
-     * TODO: Reference-count the micro-TLB as several bus masters can be
-     * connected to the same micro-TLB.
-     */
-    ipmmu_imuasid_write(mmu, utlb, 0);
-    ipmmu_imuctr_write(mmu, utlb, imuctr |
-                       IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
+    if ( mmu->utlb_refcount[utlb]++ == 0 )
+    {
+        ipmmu_imuasid_write(mmu, utlb, 0);
+        ipmmu_imuctr_write(mmu, utlb, imuctr |
+                           IMUCTR_TTSEL_MMU(domain->context_id) | IMUCTR_MMUEN);
+    }
 
     return 0;
 }
@@ -484,7 +484,10 @@ static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain,
 {
     struct ipmmu_vmsa_device *mmu = domain->mmu;
 
-    ipmmu_imuctr_write(mmu, utlb, 0);
+    ASSERT(mmu->utlb_refcount[utlb] > 0);
+
+    if ( --mmu->utlb_refcount[utlb] == 0 )
+        ipmmu_imuctr_write(mmu, utlb, 0);
 }
 
 /* Domain/Context Management */
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 21:16:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 21:16:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250002.430576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ1C-0007c8-Nh; Mon, 20 Dec 2021 21:16:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250002.430576; Mon, 20 Dec 2021 21:16:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzQ1C-0007Yr-CA; Mon, 20 Dec 2021 21:16:26 +0000
Received: by outflank-mailman (input) for mailman id 250002;
 Mon, 20 Dec 2021 21:16:23 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=6gYK=RF=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzQ19-0005IB-CZ
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 21:16:23 +0000
Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com
 [2a00:1450:4864:20::22b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 150591d1-61da-11ec-85d3-df6b77346a89;
 Mon, 20 Dec 2021 22:16:22 +0100 (CET)
Received: by mail-lj1-x22b.google.com with SMTP id k2so18068267lji.4
 for <xen-devel@lists.xenproject.org>; Mon, 20 Dec 2021 13:16:22 -0800 (PST)
Received: from otyshchenko.router ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id b35sm635132lfv.209.2021.12.20.13.16.21
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Dec 2021 13:16:21 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 150591d1-61da-11ec-85d3-df6b77346a89
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:in-reply-to:references;
        bh=xEJ/as6c2Y3IKG5DtZXdMpOhtzqpglhGl1VKpLommlg=;
        b=bxGK8XoFncudNK8ijCfMDVnV8Ugd3evS/gun5assQK01IdDTTme9eoHJ9hn01SFBFu
         AglMLMZsDwZF494RmxroKyz+LkoZvL4H3hWk6eHKtXJFBFN9ljmb5FLihHMDLjvK9+zu
         MLZjTH4KUGfOiiCfUGP59Mi0Z9kvU3jr7wNbq1ltfjVhTSG2J2kMAXLzEhKoFLGl4HhI
         vuSS+Uvn9aM4f51YSyEZRq+t8bpIPxF+7NZlbqxtu/2gDgIeecz+9T3Gi3u7d9nz1dBY
         yuZvB7C/HuHIomIzdNWAru9+rn+N4KoZRdPJUKK53zPXIg1NkAm0zmAmEe9iNvSJfmdQ
         FjcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
         :references;
        bh=xEJ/as6c2Y3IKG5DtZXdMpOhtzqpglhGl1VKpLommlg=;
        b=G99CQAMJF5CAmUSMQ0wbf47w+OgCmyC0EMGmPQVC9R3mDt6RkUVF78kTQwvb2hcgyr
         Xyh394pKbCoiacuFLRSo9gktKtili9B/XOvoHlpNGI7RXHPR6Gdau3MLGnW5g5BCDze3
         7LU2cZvQUHzWmf+QZJsJgwBMfdGTgDrz5vlhpBPQ88RRK6+OAsGzrN19/hfnji7jfK9g
         hkz0v43GFLI5VmHz2ijuhm1Ht3I8NSXrPFARGyatI70PgRdvIpoeeudUHFzWhYmCia0s
         nvPmJKwaVVeiWmVjR9ra88HYjxdaIH07byva8sWEIkulCUWzrLttC2Y8NadrQpUYIqfW
         dGTQ==
X-Gm-Message-State: AOAM533xVYwIaVwTYOLS4proYFpqX2t7Qod4jmwUphtQswtt07LRF08R
	2M1xR2rB/cRGseX3Emtdn6FMcE55qCE=
X-Google-Smtp-Source: ABdhPJyHVZaNSJHo2OIPrA0WgJpGUxpjHQvokrcmd6B6Dh+19rKeup/HjUJRLxpz11VTIqNQv4POKA==
X-Received: by 2002:a05:651c:1696:: with SMTP id bd22mr15878925ljb.57.1640034982132;
        Mon, 20 Dec 2021 13:16:22 -0800 (PST)
From: Oleksandr Tyshchenko <olekstysh@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Bertrand Marquis <bertrand.marquis@arm.com>,
	Rahul Singh <rahul.singh@arm.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH V2 10/10] iommu/arm: Remove code duplication in all IOMMU drivers
Date: Mon, 20 Dec 2021 23:15:57 +0200
Message-Id: <1640034957-19764-11-git-send-email-olekstysh@gmail.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

All IOMMU drivers on Arm perform almost the same generic actions in
hwdom_init callback. Move this code to common arch_iommu_hwdom_init()
in order to get rid of code duplication.

Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Changes V1 -> V2:
   - add R-b
---
 xen/drivers/passthrough/arm/iommu.c      |  7 +++++++
 xen/drivers/passthrough/arm/ipmmu-vmsa.c |  8 --------
 xen/drivers/passthrough/arm/smmu-v3.c    | 10 ----------
 xen/drivers/passthrough/arm/smmu.c       | 10 ----------
 4 files changed, 7 insertions(+), 28 deletions(-)

diff --git a/xen/drivers/passthrough/arm/iommu.c b/xen/drivers/passthrough/arm/iommu.c
index ee653a9..fc45318 100644
--- a/xen/drivers/passthrough/arm/iommu.c
+++ b/xen/drivers/passthrough/arm/iommu.c
@@ -134,6 +134,13 @@ void arch_iommu_domain_destroy(struct domain *d)
 
 void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
 {
+    /* Set to false options not supported on ARM. */
+    if ( iommu_hwdom_inclusive )
+        printk(XENLOG_WARNING "map-inclusive dom0-iommu option is not supported on ARM\n");
+    iommu_hwdom_inclusive = false;
+    if ( iommu_hwdom_reserved == 1 )
+        printk(XENLOG_WARNING "map-reserved dom0-iommu option is not supported on ARM\n");
+    iommu_hwdom_reserved = 0;
 }
 
 /*
diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
index 1224ea4..64d8ddc 100644
--- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
+++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
@@ -1325,14 +1325,6 @@ static int ipmmu_iommu_domain_init(struct domain *d)
 
 static void __hwdom_init ipmmu_iommu_hwdom_init(struct domain *d)
 {
-    /* Set to false options not supported on ARM. */
-    if ( iommu_hwdom_inclusive )
-        printk(XENLOG_WARNING "ipmmu: map-inclusive dom0-iommu option is not supported on ARM\n");
-    iommu_hwdom_inclusive = false;
-    if ( iommu_hwdom_reserved == 1 )
-        printk(XENLOG_WARNING "ipmmu: map-reserved dom0-iommu option is not supported on ARM\n");
-    iommu_hwdom_reserved = 0;
-
     arch_iommu_hwdom_init(d);
 }
 
diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthrough/arm/smmu-v3.c
index d115df7..ca8b5c7 100644
--- a/xen/drivers/passthrough/arm/smmu-v3.c
+++ b/xen/drivers/passthrough/arm/smmu-v3.c
@@ -3404,16 +3404,6 @@ static int arm_smmu_iommu_xen_domain_init(struct domain *d)
 
 static void __hwdom_init arm_smmu_iommu_hwdom_init(struct domain *d)
 {
-	/* Set to false options not supported on ARM. */
-	if (iommu_hwdom_inclusive)
-		printk(XENLOG_WARNING
-		"map-inclusive dom0-iommu option is not supported on ARM\n");
-	iommu_hwdom_inclusive = false;
-	if (iommu_hwdom_reserved == 1)
-		printk(XENLOG_WARNING
-		"map-reserved dom0-iommu option is not supported on ARM\n");
-	iommu_hwdom_reserved = 0;
-
 	arch_iommu_hwdom_init(d);
 }
 
diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
index c9dfc4c..ec18df7 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2851,16 +2851,6 @@ static int arm_smmu_iommu_domain_init(struct domain *d)
 
 static void __hwdom_init arm_smmu_iommu_hwdom_init(struct domain *d)
 {
-	/* Set to false options not supported on ARM. */
-	if ( iommu_hwdom_inclusive )
-		printk(XENLOG_WARNING
-		"map-inclusive dom0-iommu option is not supported on ARM\n");
-	iommu_hwdom_inclusive = false;
-	if ( iommu_hwdom_reserved == 1 )
-		printk(XENLOG_WARNING
-		"map-reserved dom0-iommu option is not supported on ARM\n");
-	iommu_hwdom_reserved = 0;
-
 	arch_iommu_hwdom_init(d);
 }
 
-- 
2.7.4



From xen-devel-bounces@lists.xenproject.org Mon Dec 20 23:18:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 23:18:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250045.430601 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRuT-0006xz-M9; Mon, 20 Dec 2021 23:17:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250045.430601; Mon, 20 Dec 2021 23:17:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRuT-0006xr-JC; Mon, 20 Dec 2021 23:17:37 +0000
Received: by outflank-mailman (input) for mailman id 250045;
 Mon, 20 Dec 2021 23:17:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lA0=RF=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mzRuT-0006xl-2x
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 23:17:37 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0328e659-61eb-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 00:17:34 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 31D4E4EC;
 Tue, 21 Dec 2021 00:17:33 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id xn2FJjRoLvxK; Tue, 21 Dec 2021 00:17:32 +0100 (CET)
Received: from begin.home (2a01cb0088600700de41a9fffe47ec49.ipv6.abo.wanadoo.fr
 [IPv6:2a01:cb00:8860:700:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 7BB4E63;
 Tue, 21 Dec 2021 00:17:32 +0100 (CET)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mzRuN-00065d-0B;
 Tue, 21 Dec 2021 00:17:31 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0328e659-61eb-11ec-9e60-abaf8a552007
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 21 Dec 2021 00:17:30 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH v2 02/10] mini-os: sort and sanitize e820 memory map
Message-ID: <20211220231730.nivaq6vgtlyfqhng@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-3-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211220160716.4159-3-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 31D4E4EC
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 20 déc. 2021 17:07:08 +0100, a ecrit:
> +static void e820_sanitize(void)
> +{
> +    int i;
> +    unsigned long end, start;
> +
> +    /* Sanitize memory map in current form. */
> +    e820_process_entries();
> +
> +    /* Adjust map entries to page boundaries. */
> +    for ( i = 0; i < e820_entries; i++ )
> +    {
> +        start = e820_map[i].addr;
> +        end = start + e820_map[i].size;
> +        if ( (1U << e820_map[i].type) & E820_NARROW )
> +        {
> +            if ( start & (PAGE_SIZE - 1) )
> +            {
> +                start = round_pgup(start);
> +                e820_insert_entry_at(i, start - PAGE_SIZE, PAGE_SIZE,
> +                                     E820_TMP_RESERVED);
> +                i++;
> +            }
> +            if ( end & (PAGE_SIZE - 1) )
> +            {
> +                end = round_pgdown(end);
> +                e820_insert_entry_at(i, end, PAGE_SIZE, E820_TMP_RESERVED);

Rather i+1 so it's most probably already sorted?

Apart from that,

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Samuel


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 23:18:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 23:18:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250050.430620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRvG-0007aT-2L; Mon, 20 Dec 2021 23:18:26 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250050.430620; Mon, 20 Dec 2021 23:18:26 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRvF-0007aJ-VP; Mon, 20 Dec 2021 23:18:25 +0000
Received: by outflank-mailman (input) for mailman id 250050;
 Mon, 20 Dec 2021 23:18:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lA0=RF=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mzRvE-0007Xv-9h
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 23:18:24 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1d1b6645-61eb-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 00:18:21 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 596134EE;
 Tue, 21 Dec 2021 00:18:17 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ZYOuiuRNWbd9; Tue, 21 Dec 2021 00:18:16 +0100 (CET)
Received: from begin.home (2a01cb0088600700de41a9fffe47ec49.ipv6.abo.wanadoo.fr
 [IPv6:2a01:cb00:8860:700:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 9306E199;
 Tue, 21 Dec 2021 00:18:16 +0100 (CET)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mzRv6-00065u-5N;
 Tue, 21 Dec 2021 00:18:16 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1d1b6645-61eb-11ec-8d39-b1a4ed000e3e
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 21 Dec 2021 00:18:16 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH v2 03/10] mini-os: don't assume contiguous RAM when
 initializing in PVH mode
Message-ID: <20211220231816.pnimrlsfbs2lorik@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-4-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211220160716.4159-4-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 596134EE
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 20 déc. 2021 17:07:09 +0100, a ecrit:
> Sizing the available memory should respect memory holes, so look at
> the memory map when setting the boundary for the memory allocator.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
> V2:
> - rename "max" to "start" (Samuel Thibault)
> ---
>  arch/x86/mm.c  |  6 +-----
>  e820.c         | 14 ++++++++------
>  include/e820.h |  2 +-
>  3 files changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index 8df93da..3bf6170 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -107,7 +107,6 @@ void arch_mm_preinit(void *p)
>  {
>      long ret;
>      domid_t domid = DOMID_SELF;
> -    unsigned long max;
>  
>      pt_base = page_table_base;
>      first_free_pfn = PFN_UP(to_phys(&_end));
> @@ -117,11 +116,8 @@ void arch_mm_preinit(void *p)
>          xprintk("could not get memory size\n");
>          do_exit();
>      }
> -    last_free_pfn = ret;
>  
> -    max = e820_get_maxpfn();
> -    if ( max < last_free_pfn )
> -        last_free_pfn = max;
> +    last_free_pfn = e820_get_maxpfn(ret);
>  }
>  #endif
>  
> diff --git a/e820.c b/e820.c
> index 1770158..6d15cdf 100644
> --- a/e820.c
> +++ b/e820.c
> @@ -285,10 +285,10 @@ void arch_print_memmap(void)
>  }
>  #endif
>  
> -unsigned long e820_get_maxpfn(void)
> +unsigned long e820_get_maxpfn(unsigned long pages)
>  {
>      int i;
> -    unsigned long pfn, max = 0;
> +    unsigned long pfns, start = 0;
>  
>      e820_get_memmap();
>  
> @@ -296,10 +296,12 @@ unsigned long e820_get_maxpfn(void)
>      {
>          if ( e820_map[i].type != E820_RAM )
>              continue;
> -        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> -        if ( pfn > max )
> -            max = pfn;
> +        pfns = e820_map[i].size >> PAGE_SHIFT;
> +        start = e820_map[i].addr >> PAGE_SHIFT;
> +        if ( pages <= pfns )
> +            return start + pages;
> +        pages -= pfns;
>      }
>  
> -    return max;
> +    return start + pfns;
>  }
> diff --git a/include/e820.h b/include/e820.h
> index af2129f..6a57f05 100644
> --- a/include/e820.h
> +++ b/include/e820.h
> @@ -49,6 +49,6 @@ struct __packed e820entry {
>  extern struct e820entry e820_map[];
>  extern unsigned e820_entries;
>  
> -unsigned long e820_get_maxpfn(void);
> +unsigned long e820_get_maxpfn(unsigned long pages);
>  
>  #endif /*__E820_HEADER*/
> -- 
> 2.26.2
> 

-- 
Samuel
Now I know someone out there is going to claim, "Well then, UNIX is intuitive,
because you only need to learn 5000 commands, and then everything else follows
from that! Har har har!"
(Andy Bates in comp.os.linux.misc, on "intuitive interfaces", slightly
defending Macs.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 23:22:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 23:22:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250056.430634 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRzJ-0000lo-MN; Mon, 20 Dec 2021 23:22:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250056.430634; Mon, 20 Dec 2021 23:22:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzRzJ-0000lZ-Hq; Mon, 20 Dec 2021 23:22:37 +0000
Received: by outflank-mailman (input) for mailman id 250056;
 Mon, 20 Dec 2021 23:22:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lA0=RF=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mzRzI-0000lC-In
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 23:22:36 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [2a0c:e300::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b56776d1-61eb-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 00:22:34 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id CB62C4EC;
 Tue, 21 Dec 2021 00:22:32 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 7FQ-1_piAvVs; Tue, 21 Dec 2021 00:22:32 +0100 (CET)
Received: from begin.home (2a01cb0088600700de41a9fffe47ec49.ipv6.abo.wanadoo.fr
 [IPv6:2a01:cb00:8860:700:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 2741A199;
 Tue, 21 Dec 2021 00:22:32 +0100 (CET)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mzRzD-00069H-GA;
 Tue, 21 Dec 2021 00:22:31 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b56776d1-61eb-11ec-8d39-b1a4ed000e3e
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 21 Dec 2021 00:22:31 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up
Message-ID: <20211220232231.sylwjfk6rsjrgeqi@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-5-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211220160716.4159-5-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: CB62C4EC
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 20 déc. 2021 17:07:10 +0100, a ecrit:
> +unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages)
> +{
> +    int i;
> +    unsigned long end;
> +
> +    for ( i = 0; i < e820_entries && e820_map[i].addr < (pfn << PAGE_SHIFT);

Shouldn't that be addr+size? Otherwise if pfn is in the middle of an
e820 entry, we will miss picking up that.

> +          i++ )
> +    {
> +        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
> +        if ( e820_map[i].type != E820_RAM || end <= pfn )
> +            continue;
> +
> +        return ((end - pfn) > pages) ? pages : end - pfn;
> +    }
> +
> +    return 0;
> +}


From xen-devel-bounces@lists.xenproject.org Mon Dec 20 23:30:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 20 Dec 2021 23:30:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250061.430650 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzS6c-0002Ot-HZ; Mon, 20 Dec 2021 23:30:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250061.430650; Mon, 20 Dec 2021 23:30:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzS6c-0002Om-EE; Mon, 20 Dec 2021 23:30:10 +0000
Received: by outflank-mailman (input) for mailman id 250061;
 Mon, 20 Dec 2021 23:30:08 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8lA0=RF=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mzS6a-0002IS-MS
 for xen-devel@lists.xenproject.org; Mon, 20 Dec 2021 23:30:08 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c3b4ef65-61ec-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 00:30:06 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 1715E25E;
 Tue, 21 Dec 2021 00:30:06 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id oa-M3gAE_cT6; Tue, 21 Dec 2021 00:30:05 +0100 (CET)
Received: from begin.home (2a01cb0088600700de41a9fffe47ec49.ipv6.abo.wanadoo.fr
 [IPv6:2a01:cb00:8860:700:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 006CB199;
 Tue, 21 Dec 2021 00:30:04 +0100 (CET)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mzS6W-0006Bz-Cp;
 Tue, 21 Dec 2021 00:30:04 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c3b4ef65-61ec-11ec-9e60-abaf8a552007
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 21 Dec 2021 00:30:04 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH v2 06/10] mini-os: add memory map service functions
Message-ID: <20211220233004.kyvlnh5nlk2nfs5q@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-7-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211220160716.4159-7-jgross@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 1715E25E
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le lun. 20 déc. 2021 17:07:12 +0100, a ecrit:
> Add two functions for adding reserved areas to the memory map and
> for removing them again.
> 
> Those will be needed for proper grant table/mapping support in PVH
> mode.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
> V2:
> - fix e820_put_reserved_pfns() (Samuel Thibault)
> ---
>  e820.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/e820.h |  4 ++++
>  2 files changed, 54 insertions(+)
> 
> diff --git a/e820.c b/e820.c
> index 659f71c..25e2f9d 100644
> --- a/e820.c
> +++ b/e820.c
> @@ -283,6 +283,56 @@ void arch_print_memmap(void)
>          printk("%012lx-%012lx: %s\n", from, to, type);
>      }
>  }
> +
> +unsigned long e820_get_reserved_pfns(int pages)
> +{
> +    int i;
> +    unsigned long last = 0, needed = (long)pages << PAGE_SHIFT;
> +
> +    for ( i = 0; i < e820_entries && e820_map[i].addr < last + needed; i++ )
> +        last = e820_map[i].addr + e820_map[i].size;
> +
> +    if ( i == 0 || e820_map[i - 1].type != E820_RESERVED )
> +        e820_insert_entry_at(i, last, needed, E820_RESERVED);
> +    else
> +        e820_map[i - 1].size += needed;
> +
> +    return last >> PAGE_SHIFT;
> +}
> +
> +void e820_put_reserved_pfns(unsigned long start_pfn, int pages)
> +{
> +    int i;
> +    unsigned long addr = start_pfn << PAGE_SHIFT;
> +    unsigned long size = (long)pages << PAGE_SHIFT;
> +
> +    for ( i = 0;
> +          i < e820_entries && addr >= e820_map[i].addr + e820_map[i].size;
> +          i++ );
> +
> +    BUG_ON(i == e820_entries || e820_map[i].type != E820_RESERVED ||
> +           addr + size > e820_map[i].addr + e820_map[i].size);
> +
> +    if ( addr == e820_map[i].addr )
> +    {
> +        e820_map[i].addr += size;
> +        e820_map[i].size -= size;
> +        if ( e820_map[i].size == 0 )
> +            e820_remove_entry(i);
> +        return;
> +    }
> +
> +    if ( addr + size == e820_map[i].addr + e820_map[i].size )
> +    {
> +        e820_map[i].size -= size;
> +        return;
> +    }
> +
> +    e820_insert_entry_at(i + 1, addr + size,
> +                         e820_map[i].addr + e820_map[i].size - addr - size,
> +                         E820_RESERVED);
> +    e820_map[i].size = addr - e820_map[i].addr;
> +}
>  #endif
>  
>  unsigned long e820_get_maxpfn(unsigned long pages)
> diff --git a/include/e820.h b/include/e820.h
> index 8d4d371..aaf2f2c 100644
> --- a/include/e820.h
> +++ b/include/e820.h
> @@ -51,5 +51,9 @@ extern unsigned e820_entries;
>  
>  unsigned long e820_get_maxpfn(unsigned long pages);
>  unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages);
> +#ifndef CONFIG_E820_TRIVIAL
> +unsigned long e820_get_reserved_pfns(int pages);
> +void e820_put_reserved_pfns(unsigned long start_pfn, int pages);
> +#endif
>  
>  #endif /*__E820_HEADER*/
> -- 
> 2.26.2
> 

-- 
Samuel
<A> sauf que le firewall bloque tout sauf internet
 -+- ben ouais, il bloque ipx/spx ! -+-


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 00:08:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 00:08:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250067.430661 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzShQ-0006iq-2b; Tue, 21 Dec 2021 00:08:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250067.430661; Tue, 21 Dec 2021 00:08:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzShP-0006ij-VS; Tue, 21 Dec 2021 00:08:11 +0000
Received: by outflank-mailman (input) for mailman id 250067;
 Tue, 21 Dec 2021 00:08:10 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzShO-0006id-3W
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 00:08:10 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 12fc7957-61f2-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 01:08:08 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7AADA61312;
 Tue, 21 Dec 2021 00:08:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51DEEC36AE5;
 Tue, 21 Dec 2021 00:08:05 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12fc7957-61f2-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640045285;
	bh=m/V69/L3GRumk/tGw24ozKLLORhjpngJJBJb+1eSo9A=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=GljYABVYuQWMLH0kC+Ylq4wje+KXupo1JxS8T/nmTZyLA/9+/o+LhDaRPh+rZd2yR
	 RT7BUWIrwO4wd/FgsRahBxmU3/WBMnCOW9rSynPddR/9TQEiipxVdDrzKCHyySTl+Z
	 RiLP2hkqypBLTp/Ot+DxxH+2WY7v1hLLHzfoY+a1fedoR7mzu9oL7ZSf+U1X7ktLqj
	 EvT+SLIqfGtRWId5O7BAGzE5ooB7/HSFzPwSO493O5wLwqia7LAOr3N1Sg5Cu1xc2+
	 YcFRJzj6Qh+g5loAxYDoklOnJMd3Ys0r9eytuGi3JLVa4ZS7K8OvMGUnWjmvymF+zS
	 H4WJ9zrTH0UBg==
Date: Mon, 20 Dec 2021 16:08:04 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    Juergen Gross <jgross@suse.com>, Jan Beulich <jbeulich@suse.com>, 
    xen-devel@lists.xenproject.org, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, 
    =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, 
    Christopher Clark <christopher.w.clark@gmail.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
In-Reply-To: <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112201545360.2060010@ubuntu-linux-20-04-desktop>
References: <20211208155606.20029-1-jgross@suse.com> <20211208155606.20029-3-jgross@suse.com> <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org> <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com> <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com> <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop> <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop> <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com> <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com> <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org> <a91217dc-8f97-2882-ce08-2a408654295e@suse.com> <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
 <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1340185955-1640044016=:2060010"
Content-ID: <alpine.DEB.2.22.394.2112201551360.2060010@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1340185955-1640044016=:2060010
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2112201551361.2060010@ubuntu-linux-20-04-desktop>

On Mon, 20 Dec 2021, Julien Grall wrote:
> On 18/12/2021 00:00, Stefano Stabellini wrote:
> > On Fri, 17 Dec 2021, Juergen Gross wrote:
> > > On 17.12.21 11:41, Julien Grall wrote:
> > > > Hi Juergen,
> > > > 
> > > > On 17/12/2021 08:50, Juergen Gross wrote:
> > > > > On 17.12.21 08:45, Jan Beulich wrote:
> > > > > > On 17.12.2021 06:34, Juergen Gross wrote:
> > > > > > > On 16.12.21 22:15, Stefano Stabellini wrote:
> > > > > > > > On Thu, 16 Dec 2021, Stefano Stabellini wrote:
> > > > > > > > > On Thu, 16 Dec 2021, Juergen Gross wrote:
> > > > > > > > > > On 16.12.21 03:10, Stefano Stabellini wrote:
> > > > > > > > > > > The case of XENMEM_maximum_ram_page is interesting but it
> > > > > > > > > > > is
> > > > > > > > > > > not a
> > > > > > > > > > > problem in reality because the max physical address size
> > > > > > > > > > > is
> > > > > > > > > > > only 40-bit
> > > > > > > > > > > for aarch32 guests, so 32-bit are always enough to return
> > > > > > > > > > > the
> > > > > > > > > > > highest
> > > > > > > > > > > page in memory for 32-bit guests.
> > > > > > > > > > 
> > > > > > > > > > You are aware that this isn't the guest's max page, but the
> > > > > > > > > > host's?
> > > > > > > > 
> > > > > > > > I can see now that you meant to say that, no matter what is the
> > > > > > > > max
> > > > > > > > pseudo-physical address supported by the VM,
> > > > > > > > XENMEM_maximum_ram_page
> > > > > > > > is
> > > > > > > > supposed to return the max memory page, which could go above the
> > > > > > > > addressibility limit of the VM.
> > > > > > > > 
> > > > > > > > So XENMEM_maximum_ram_page should potentially be able to return
> > > > > > > > (1<<44)
> > > > > > > > even when called by an aarch32 VM, with max IPA 40-bit.
> > > > > > > > 
> > > > > > > > I would imagine it could be useful if dom0 is 32-bit but domUs
> > > > > > > > are
> > > > > > > > 64-bit on a 64-bit hypervisor (which I think it would be a very
> > > > > > > > rare
> > > > > > > > configuration on ARM.)
> > > > > > > > 
> > > > > > > > Then it looks like XENMEM_maximum_ram_page needs to be able to
> > > > > > > > return a
> > > > > > > > value > 32-bit when called by a 32-bit guest.
> > > > > > > > 
> > > > > > > > The hypercall ABI follows the ARM C calling convention, so a
> > > > > > > > 64-bit
> > > > > > > > value should be returned using r0 and r1. But looking at
> > > > > > > > xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever
> > > > > > > > sets
> > > > > > > > r1
> > > > > > > > today. Only r0 is set, so effectively we only support 32-bit
> > > > > > > > return
> > > > > > > > values on aarch32 and for aarch32 guests.
> > > > > > > > 
> > > > > > > > In other words, today all hypercalls on ARM return 64-bit to
> > > > > > > > 64-bit
> > > > > > > > guests and 32-bit to 32-bit guests. Which in the case of
> > > > > > > > memory_op
> > > > > > > > is
> > > > > > > > "technically" the correct thing to do because it matches the C
> > > > > > > > declaration in xen/include/xen/hypercall.h:
> > > > > > > > 
> > > > > > > > extern long
> > > > > > > > do_memory_op(
> > > > > > > >        unsigned long cmd,
> > > > > > > >        XEN_GUEST_HANDLE_PARAM(void) arg);
> > > > > > > > 
> > > > > > > > So...  I guess the conclusion is that on ARM do_memory_op should
> > > > > > > > return
> > > > > > > > "long" although it is not actually enough for a correct
> > > > > > > > implementation
> > > > > > > > of XENMEM_maximum_ram_page for aarch32 guests ?
> > > > > > > > 
> > > > > > > 
> > > > > > > Hence my suggestion to check the return value of _all_ hypercalls
> > > > > > > to
> > > > > > > be
> > > > > > > proper sign extended int values for 32-bit guests. This would fix
> > > > > > > all
> > > > > > > potential issues without silently returning truncated values.
> > > > > > 
> > > > > > Are we absolutely certain we have no other paths left where a
> > > > > > possibly
> > > > > > large unsigned values might be returned? In fact while
> > > > > > compat_memory_op() does the necessary saturation, I've never been
> > > > > > fully
> > > > > > convinced of this being the best way of dealing with things. The
> > > > > > range
> > > > > > of error indicators is much smaller than [-INT_MIN,-1], so almost
> > > > > > double the range of effectively unsigned values could be passed back
> > > > > > fine. (Obviously we can't change existing interfaces, so this mem-op
> > > > > > will need to remain as is.)
> > > > > 
> > > > > In fact libxenctrl tries do deal with this fact by wrapping a
> > > > > memory_op
> > > > > for a 32-bit environment into a multicall. This will work fine for a
> > > > > 32-bit Arm guest, as xen_ulong_t is a uint64 there.
> > > > > 
> > > > > So do_memory_op should return long on Arm, yes. OTOH doing so will
> > > > > continue to be a problem in case a 32-bit guest doesn't use the
> > > > > multicall technique for handling possible 64-bit return values.
> > > > > 
> > > > > So I continue to argue that on Arm the return value of a hypercall
> > > > > should be tested to fit into 32 bits.
> > > > 
> > > > It would make sense. But what would you return if the value doesn't fit?
> > > 
> > > I guess some errno value would be appropriate, like -EDOM, -ERANGE or
> > > -E2BIG.
> > 
> > This seems to be better than the alternative below as it is a lot
> > simpler.
> 
> We would still need to special case XENMEM_maximum_reservation (or rework the
> implementation of the sub-op) because the value returned is an unsigned long.
> So technically, the unsigned value for -EDOM & co could be interpreted as the
> maximum host frame number.
> 
> I also would like to see the hypercall returning 'int' when they are only
> meant to return 32-bit value. This will make easier to spot someone that
> decide to return a 64-bit value.

I am completely aligned with you on both points.

XENMEM_maximum_reservation is a bit of a distraction given that is
unused (even unsupported?) on ARM. In general, to switch to "int" as
return type we would have to (manually) check that all the sub-ops of a
given hypercall return 32-bit values, right? Otherwise, how can we be
sure that we don't start to silently truncate the top 32-bit on a sub-op
on arm64?

In theory we could use -Wconversion to automatically spot any
truncations but unfortunately -Wconversion breaks the build at the
moment.
--8323329-1340185955-1640044016=:2060010--


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 00:52:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 00:52:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250074.430672 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzTNy-0003eb-H5; Tue, 21 Dec 2021 00:52:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250074.430672; Tue, 21 Dec 2021 00:52:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzTNy-0003eU-Du; Tue, 21 Dec 2021 00:52:10 +0000
Received: by outflank-mailman (input) for mailman id 250074;
 Tue, 21 Dec 2021 00:52:09 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzTNw-0003eO-SD
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 00:52:09 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 36c1d28c-61f8-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 01:52:04 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 7A3CE61337;
 Tue, 21 Dec 2021 00:52:03 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30F1FC36AE5;
 Tue, 21 Dec 2021 00:52:02 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 36c1d28c-61f8-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640047922;
	bh=y9+plNEu0iWWUibxZCd8BP7tpO6BWv4xRbZTgYb5JVY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=M8DqjpNvDBKLQ/NbhO7MvtszgaYVDW4gvNucwusg8cZhZXyODD54BUwu/I8JbvObA
	 Ng4ayNzZexMpBEnPrCSOGN0k62RlvfOuNwcmsbtVjVbjHmgx8Bm/Nt7bR1xh7iaqUV
	 lrsUBtxmMdI9L32tXs049ZG/e6bwUch29AM2Wb7K5psZRUNwUA6mG7Twi+0G/fgJx+
	 5d98U5xtzjsgi+nhIrdEf+fzc3uF9VCfWdsMdD/D0f3n2geX0hP5JeUmjc4NhyxJ5c
	 pdt5O7E/P6Lo6FWR/lWb7tckLyVvj8aBGzyOuMyKNbP5bTcfqJCjGlhqAJtJbQkPvM
	 rqchcwqfpbPVw==
Date: Mon, 20 Dec 2021 16:52:01 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20211220181215.GA1702335@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com> <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> Hi Stefano,
> 
> On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > This is the implementation of SCI interface, called SCMI-SMC driver,
> > > which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> > > This allows devices from the Domains to work with clocks, resets and
> > > power-domains without access to CPG.
> > > 
> > > The following features are implemented:
> > > - request SCMI channels from ATF and pass channels to Domains;
> > > - set device permissions for Domains based on the Domain partial
> > > device-tree. Devices with permissions are able to work with clocks,
> > > resets and power-domains via SCMI;
> > > - redirect scmi messages from Domains to ATF.
> > > 
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > ---
> > >  xen/arch/arm/Kconfig          |   2 +
> > >  xen/arch/arm/sci/Kconfig      |  10 +
> > >  xen/arch/arm/sci/Makefile     |   1 +
> > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
> > >  xen/include/public/arch-arm.h |   1 +
> > >  5 files changed, 809 insertions(+)
> > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > 
> > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > index 186e1db389..02d96c6cfc 100644
> > > --- a/xen/arch/arm/Kconfig
> > > +++ b/xen/arch/arm/Kconfig
> > > @@ -114,6 +114,8 @@ config SCI
> > >  	  support. It allows guests to control system resourcess via one of
> > >  	  SCI mediators implemented in XEN.
> > >  
> > > +source "arch/arm/sci/Kconfig"
> > > +
> > >  endmenu
> > >  
> > >  menu "ARM errata workaround via the alternative framework"
> > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > > new file mode 100644
> > > index 0000000000..9563067ddc
> > > --- /dev/null
> > > +++ b/xen/arch/arm/sci/Kconfig
> > > @@ -0,0 +1,10 @@
> > > +config SCMI_SMC
> > > +	bool "Enable SCMI-SMC mediator driver"
> > > +	default n
> > > +	depends on SCI
> > > +	---help---
> > > +
> > > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> > > +	This feature allows drivers from Domains to work with System
> > > +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> > > +	for communication.
> > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > > index 837dc7492b..67f2611872 100644
> > > --- a/xen/arch/arm/sci/Makefile
> > > +++ b/xen/arch/arm/sci/Makefile
> > > @@ -1 +1,2 @@
> > >  obj-y += sci.o
> > > +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> > > new file mode 100644
> > > index 0000000000..2eb01ea82d
> > > --- /dev/null
> > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > @@ -0,0 +1,795 @@
> > > +/*
> > > + * xen/arch/arm/sci/scmi_smc.c
> > > + *
> > > + * SCMI mediator driver, using SCP as transport.
> > > + *
> > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > + * Copyright (C) 2021, EPAM Systems.
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + */
> > > +
> > > +#include <asm/sci/sci.h>
> > > +#include <asm/smccc.h>
> > > +#include <asm/io.h>
> > > +#include <xen/bitops.h>
> > > +#include <xen/config.h>
> > > +#include <xen/sched.h>
> > > +#include <xen/device_tree.h>
> > > +#include <xen/iocap.h>
> > > +#include <xen/init.h>
> > > +#include <xen/err.h>
> > > +#include <xen/lib.h>
> > > +#include <xen/list.h>
> > > +#include <xen/mm.h>
> > > +#include <xen/string.h>
> > > +#include <xen/time.h>
> > > +#include <xen/vmap.h>
> > > +
> > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > +
> > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > > +#define SCMI_SUCCESS              0
> > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > +#define SCMI_DENIED             (-3)
> > > +#define SCMI_NOT_FOUND          (-4)
> > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > +#define SCMI_BUSY               (-6)
> > > +#define SCMI_COMMS_ERROR        (-7)
> > > +#define SCMI_GENERIC_ERROR      (-8)
> > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > +
> > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > +
> > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > 
> > I could find the following SCMI binding in Linux, which describes
> > the arm,scmi-smc compatible and the arm,smc-id property:
> > 
> > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > 
> > However, linux,scmi_mem is not described. Aren't you supposed to read
> > the "shmem" property instead? And the compatible string used for this
> > seems to be "arm,scmi-shmem".
> > 
> 
> We use linux,scmi_mem node to reserve memory, needed for all
> channels:
> 
> reserved-memory {
>     /* reserved region for scmi channels*/
>     scmi_memory: linux,scmi_mem@53FF0000 {
>         no-map;
>         reg = <0x0 0x53FF0000 0x0 0x10000>;
>     };
> };
> 
> arm,scmi-shmem node used in shmem property defines only 1 page needed to
> the current scmi channel:
> 
> cpu_scp_shm: scp-shmem@0x53FF0000 {
>     compatible = "arm,scmi-shmem";
>     reg = <0x0 0x53FF0000 0x0 0x1000>;
> };
> 
> For each Domain reg points to unigue page from linux,scmi_mem region,
> assigned to this agent.

If we were to use "linux,scmi_mem" we would have to introduce it as a
compatible string, not as a node name, and it would need to be described
in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.

But from your description I don't think it is necessary. We can just use
"arm,scmi-shmem" to describe all the required regions:

reserved-memory {
    scp-shmem@0x53FF0000 {
        compatible = "arm,scmi-shmem";
        reg = <0x0 0x53FF0000 0x0 0x1000>;
    };
    scp-shmem@0x53FF1000 {
        compatible = "arm,scmi-shmem";
        reg = <0x0 0x53FF1000 0x0 0x1000>;
    };
    scp-shmem@0x53FF2000 {
        compatible = "arm,scmi-shmem";
        reg = <0x0 0x53FF2000 0x0 0x1000>;
    };
    ...

In other words, if all the individual channel pages are described as
"arm,scmi-shmem", why do we also need a single larger region as
"linux,scmi_mem"?

 
> > > +#define SCMI_SHMEM                         "shmem"
> > > +
> > > +#define HYP_CHANNEL                          0x0
> > > +
> > > +#define HDR_ID                             GENMASK(7,0)
> > > +#define HDR_TYPE                           GENMASK(9, 8)
> > > +#define HDR_PROTO                          GENMASK(17, 10)
> > > +
> > > +/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
> > > +#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
> > > +
> > > +#define FIELD_GET(_mask, _reg)\
> > > +    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
> > > +#define FIELD_PREP(_mask, _val)\
> > > +    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
> > > +
> > > +typedef struct scmi_msg_header {
> > > +    uint8_t id;
> > > +    uint8_t type;
> > > +    uint8_t protocol;
> > > +} scmi_msg_header_t;
> > > +
> > > +typedef struct scmi_perms_tx {
> > > +    uint32_t agent_id;
> > > +    uint32_t device_id;
> > > +    uint32_t flags;
> > > +} scmi_perms_tx_t;
> > > +
> > > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
> > > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
> > > +
> > > +#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
> > > +
> > > +struct scmi_shared_mem {
> > > +    uint32_t reserved;
> > > +    uint32_t channel_status;
> > > +    uint32_t reserved1[2];
> > > +    uint32_t flags;
> > > +    uint32_t length;
> > > +    uint32_t msg_header;
> > > +    uint8_t msg_payload[];
> > > +};
> > > +
> > > +struct scmi_channel {
> > > +    int chan_id;
> > > +    int agent_id;
> > > +    uint32_t func_id;
> > > +    int domain_id;
> > > +    uint64_t paddr;
> > > +    struct scmi_shared_mem *shmem;
> > > +    spinlock_t lock;
> > > +    struct list_head list;
> > > +};
> > > +
> > > +struct scmi_data {
> > > +    struct list_head channel_list;
> > > +    spinlock_t channel_list_lock;
> > > +    bool initialized;
> > > +    u64 shmem_addr, shmem_size;
> > > +};
> > > +
> > > +static struct scmi_data scmi_data;
> > > +
> > > +/*
> > > + * pack_scmi_header() - packs and returns 32-bit header
> > > + *
> > > + * @hdr: pointer to header containing all the information on message id,
> > > + *    protocol id and type id.
> > > + *
> > > + * Return: 32-bit packed message header to be sent to the platform.
> > > + */
> > > +static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
> > > +{
> > > +    return FIELD_PREP(HDR_ID, hdr->id) |
> > > +        FIELD_PREP(HDR_TYPE, hdr->type) |
> > > +        FIELD_PREP(HDR_PROTO, hdr->protocol);
> > > +}
> > > +
> > > +/*
> > > + * unpack_scmi_header() - unpacks and records message and protocol id
> > > + *
> > > + * @msg_hdr: 32-bit packed message header sent from the platform
> > > + * @hdr: pointer to header to fetch message and protocol id.
> > > + */
> > > +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_header_t *hdr)
> > > +{
> > > +    hdr->id = FIELD_GET(HDR_ID, msg_hdr);
> > > +    hdr->type = FIELD_GET(HDR_TYPE, msg_hdr);
> > > +    hdr->protocol = FIELD_GET(HDR_PROTO, msg_hdr);
> > > +}
> > > +
> > > +static inline int channel_is_free(struct scmi_channel *chan_info)
> > > +{
> > > +    return ( chan_info->shmem->channel_status
> > > +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
> > 
> > Does this need a memory barrier? Or not, because the other end always
> > runs on the same CPU at a different execution level so the
> > channel_status would be always guaranteed to be read as updated?
> > 
> 
> It don't because the other end runs on the same CPU. Other mediator
> implemetaions, which uses different areas may need memory barrier.
> 
> > 
> > > +}
> > > +
> > > +static int send_smc_message(struct scmi_channel *chan_info,
> > > +                            scmi_msg_header_t *hdr, void *data, int len)
> > > +{
> > > +    struct arm_smccc_res resp;
> > > +    int ret;
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: status =%d len=%d\n",
> > > +           chan_info->shmem->channel_status, len);
> > > +    printk(XENLOG_DEBUG "scmi: header id = %d type = %d, proto = %d\n",
> > > +           hdr->id, hdr->type, hdr->protocol);
> > > +
> > > +    ret = channel_is_free(chan_info);
> > > +    if ( IS_ERR_VALUE(ret) )
> > > +        return ret;
> > > +
> > > +    chan_info->shmem->channel_status = 0x0;
> > > +    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can be set */
> > > +    chan_info->shmem->flags = 0x0;
> > > +    chan_info->shmem->length = sizeof(chan_info->shmem->msg_header) + len;
> > > +    chan_info->shmem->msg_header = pack_scmi_header(hdr);
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
> > > +           chan_info->shmem);
> > > +    if ( len > 0 && data )
> > > +        memcpy((void *)(chan_info->shmem->msg_payload), data, len);
> > 
> > Again, here we don't need a barrier because it is implicit in the SMC?
> > 
> 
> As I mentioned before, the other end runs on the same CPU.
> 
> > Don't we need to check that "len" fits in the shared memory?
> > 
> 
> I think it's a good point. I'll add len check in v2.
> 
> > 
> > > +    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info->chan_id,
> > > +                  &resp);
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(resp.a0));
> > > +
> > > +    if ( resp.a0 )
> > > +        return -EOPNOTSUPP;
> > 
> > Why is that?
> > 
> 
> This change was presented in kernel by Sudeep Holla in commit:
> f7199cf489027ae38a9a82312d13025f7aefa0b8
> 
> However, link posted in the commit:
> https://lore.kernel.org/r/20200417103232.6896-1-sudeep.holla@arm.com
> 
> Leads to slightly different patch:
> 
> +	if (res.a0 == SMCCC_RET_NOT_SUPPORTED)
> +		return -EOPNOTSUPP;
> +	else if (res.a0)
> +		return -EINVAL;
> +	return 0;
> 
> I don't know why it differs from the original commit, but I'll check and place
> the correct implementation in v2.
> 
> > 
> > > +    return 0;
> > > +}
> > > +
> > > +static int check_scmi_status(int scmi_status)
> > > +{
> > > +    if ( scmi_status == SCMI_SUCCESS )
> > > +        return 0;
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status);
> > > +
> > > +    switch ( scmi_status )
> > > +    {
> > > +    case SCMI_NOT_SUPPORTED:
> > > +        return -EOPNOTSUPP;
> > > +    case SCMI_INVALID_PARAMETERS:
> > > +        return -EINVAL;
> > > +    case SCMI_DENIED:
> > > +        return -EACCES;
> > > +    case SCMI_NOT_FOUND:
> > > +        return -ENOENT;
> > > +    case SCMI_OUT_OF_RANGE:
> > > +        return -ERANGE;
> > > +    case SCMI_BUSY:
> > > +        return -EBUSY;
> > > +    case SCMI_COMMS_ERROR:
> > > +        return -ENOTCONN;
> > > +    case SCMI_GENERIC_ERROR:
> > > +        return -EIO;
> > > +    case SCMI_HARDWARE_ERROR:
> > > +        return -ENXIO;
> > > +    case SCMI_PROTOCOL_ERROR:
> > > +        return -EBADMSG;
> > > +    }
> > > +
> > > +    return -EINVAL;
> > > +}
> > > +
> > > +static int get_smc_response(struct scmi_channel *chan_info,
> > > +                            scmi_msg_header_t *hdr, void *data, int len)
> > > +{
> > > +    int recv_len;
> > > +    int ret;
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->id);
> > > +
> > > +    ret = channel_is_free(chan_info);
> > > +    if ( IS_ERR_VALUE(ret) )
> > > +        return ret;
> > 
> > I am not familiar with the spec (do you have a link?) but is it expected
> > that the channel is "free" when actually we want to read a message on
> > the channel?
> > 
> 
> Here is the link https://developer.arm.com/documentation/den0056/latest
> Figure 6 in Section 5.1.1.
> Caller marks channel as busy, then callee process message and marks channel as free.
> We are implementing polling based communication flow.

OK


> > > +    recv_len = chan_info->shmem->length - sizeof(chan_info->shmem->msg_header);
> > > +
> > > +    if ( recv_len < 0 )
> > > +    {
> > > +        printk(XENLOG_ERR
> > > +               "scmi: Wrong size of smc message. Data may be invalid\n");
> > > +        return -EINVAL;
> > > +    }
> > > +
> > > +    if ( recv_len > len )
> > > +    {
> > > +        printk(XENLOG_ERR
> > > +               "scmi: Not enough buffer for message %d, expecting %d\n",
> > > +               recv_len, len);
> > > +        return -EINVAL;
> > > +    }
> > > +
> > > +    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
> > > +
> > > +    if ( recv_len > 0 )
> > > +    {
> > > +        memcpy(data, chan_info->shmem->msg_payload, recv_len);
> > > +    }
> > > +
> > > +    return 0;
> > > +}
> > > +
> > > +static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_header_t *hdr, void *tx_data, int tx_size,
> > > +                       void *rx_data, int rx_size)
> > > +{
> > > +    int ret = 0;
> > > +
> > > +    if ( !hdr )
> > > +        return -EINVAL;
> > > +
> > > +    spin_lock(&channel->lock);
> > > +
> > > +    ret = send_smc_message(channel, hdr, tx_data, tx_size);
> > > +    if ( ret )
> > > +        goto clean;
> > > +
> > > +    ret = get_smc_response(channel, hdr, rx_data, rx_size);
> > > +clean:
> > > +    spin_unlock(&channel->lock);
> > > +
> > > +    return ret;
> > > +}
> > > +
> > > +static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
> > > +{
> > > +    struct scmi_channel *curr;
> > > +    bool found = false;
> > > +
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > 
> > please use parenthesis around the inner if (also in other places)
> > 
> 
> Thank you for the remark. I will fix it in v2.
> 
> > 
> > > +        if ( curr->chan_id == chan_id )
> > > +        {
> > > +            found = true;
> > > +            break;
> > > +        }
> > > +
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +    if ( found )
> > > +        return curr;
> > > +
> > > +    return NULL;
> > > +}
> > > +
> > > +static struct scmi_channel *get_channel_by_domain(uint8_t domain_id)
> > 
> > Use domid_t for domain ids.
> 
> Thanks, I will fix it in v2.
> > 
> > Also, wouldn't it be better to implement it as:
> > 
> > static inline struct scmi_channel *get_channel_by_domain(struct domain *d) {
> >     return d->arch.sci
> > }
> > 
> That's a good point. I will take a look on it and fix in v2.
> > 
> > > +{
> > > +    struct scmi_channel *curr;
> > > +    bool found = false;
> > > +
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > > +        if ( curr->domain_id == domain_id )
> > > +        {
> > > +            found = true;
> > > +            break;
> > > +        }
> > > +
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +    if ( found )
> > > +        return curr;
> > > +
> > > +    return NULL;
> > > +}
> > > +
> > > +static struct scmi_channel *aquire_scmi_channel(int domain_id)
> > > +{
> > > +    struct scmi_channel *curr;
> > > +    bool found = false;
> > > +
> > > +    ASSERT(domain_id != DOMID_INVALID && domain_id >= 0);
> > > +
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > > +        if ( (curr->domain_id == DOMID_INVALID)
> > > +            && (curr->chan_id != HYP_CHANNEL) )
> > 
> > If you use DOMID_XEN for HYP_CHANNEL, then this check becomes more
> > intuitive
> > 
> 
> We do not have direct relation between channel id and domain id.
> One channel id can be reused by different domain_ids. So from my standpoint,
> DOMID_XEN doesn't fit here.
 
Below you wrote that you used DOMID_INVALID to mark a channel as free.
That is fine, but then DOMID_INVALID shouldn't be used for HYP_CHANNEL
because HYP_CHANNEL is not "free". In this function the check for
curr->chan_id != HYP_CHANNEL should be unnecessary and I think the code
would look as follows:

    list_for_each_entry(curr, &scmi_data.channel_list, list)
    {
        if ( (curr->domain_id == DOMID_INVALID) )
        {

 
> > > +        {
> > > +            curr->domain_id = domain_id;
> > > +            found = true;
> > > +            break;
> > > +        }
> > > +
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +    if ( found )
> > > +        return curr;
> > > +
> > > +    return NULL;
> > > +}
> > > +
> > > +static void relinquish_scmi_channel(struct scmi_channel *channel)
> > > +{
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    ASSERT(channel != NULL);
> > 
> > the ASSERT could be before the spin_lock
> > 
> 
> Thank you. I will fix it in v2.
> 
> > 
> > > +    channel->domain_id = DOMID_INVALID;
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +}
> > > +
> > > +static struct scmi_channel *smc_create_channel(uint8_t chan_id,
> > > +                                               uint32_t func_id, uint64_t addr)
> > > +{
> > > +    struct scmi_channel *channel;
> > > +    mfn_t mfn;
> > > +
> > > +    channel = get_channel_by_id(chan_id);
> > > +    if ( channel )
> > > +        return ERR_PTR(EEXIST);
> > > +
> > > +    channel = xmalloc(struct scmi_channel);
> > > +    if ( !channel )
> > > +        return ERR_PTR(ENOMEM);
> > > +
> > > +    channel->chan_id = chan_id;
> > > +    channel->func_id = func_id;
> > > +    channel->domain_id = DOMID_INVALID;
> > 
> > I take you are using DOMID_INVALID to mark a channel used by Xen itself?
> > If so, then DOMID_XEN would be more appropriate.
> > 
> 
> I use DOMID_INVALID to mark channel as free.
> 
> > 
> > > +    mfn = maddr_to_mfn(addr);
> > > +    channel->shmem = vmap(&mfn, 1);
> > 
> > One thing to be careful is the mapping attributes, for a couple of
> > reasons. As you might be aware, the ARM architecture forbids mismatching
> > attributes for mapping memory in different places in the system. So the
> > attributes that we use here must be the same used by the firmware
> > (and/or the guest.)
> > 
> > The second reason to be careful is that in the bindings example
> > Documentation/devicetree/bindings/firmware/arm,scmi.yaml the shared
> > memory is "mmio-sram", which is special. It is not supposed to be normal
> > memory, but it is OK to map it cacheable. Still, it might be more
> > appropriate to use ioremap_cache.
> > 
> 
> Originally, I used vmap here to have memcpy and it works fine in our
> setup. But I will do some research and email you with the results.
> 
> > 
> > > +    if ( !channel->shmem )
> > > +    {
> > > +        xfree(channel);
> > > +        return ERR_PTR(ENOMEM);
> > > +    }
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel->shmem);
> > > +    channel->paddr = addr;
> > > +    channel->shmem->channel_status = SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE;
> > > +    spin_lock_init(&channel->lock);
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    list_add(&channel->list, &scmi_data.channel_list);
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +    return channel;
> > > +}
> > > +
> > > +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
> > > +{
> > > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > +}
> > > +
> > > +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
> > > +                                     uint64_t len)
> > > +{
> > > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > +}
> > > +
> > > +static int dt_update_domain_range(struct domain *d, uint64_t addr,
> > > +                                  uint64_t size)
> > > +{
> > > +    struct dt_device_node *shmem_node;
> > > +    __be32 *hw_reg;
> > > +    const struct dt_property *pp;
> > > +    uint32_t len;
> > > +
> > > +    shmem_node = dt_find_compatible_node(NULL, NULL, "arm,scmi-shmem");
> > 
> > Here we are using "arm,scmi-shmem" while below we are checking for
> > "linux,scmi_mem". What's the difference?
> 
> linux,scmi_mem (I posted nodes examples above) describes memory region, allocated
> for all channels, while arm,scmi-shmem points to the exact channel (page in
> linux,scmi_mem region).
>
> 
> > Also, this function is looking for "arm,scmi-shmem" in dt_host and
> > replaces its value. For dom0less domUs we'll probably need a
> > make_scmi_node function to create the node from scratch like for
> > instance xen/arch/arm/domain_build.c:make_gic_domU_node.
> > 
> > I wonder if we had such a function whether it wouldn't be better to also
> > use it for dom0 (and blacklist the physical "arm,scmi-shmem" in
> > handle_node so that dom0 doesn't get the real shared memory information
> > by accident).
> > 
> 
> Thank you for the remark. I will rework this in v2.
> 
> > 
> > > +
> > > +    if ( !shmem_node )
> > > +    {
> > > +        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", SCMI_SHMEM);
> > > +        return -EINVAL;
> > > +    }
> > > +
> > > +    pp = dt_find_property(shmem_node, "reg", &len);
> > > +    if ( !pp )
> > > +    {
> > > +        printk(XENLOG_ERR "scmi: Unable to find regs entry in shmem node\n");
> > > +        return -ENOENT;
> > > +    }
> > > +
> > > +    hw_reg = pp->value;
> > > +    dt_set_range(&hw_reg, shmem_node, addr, size);
> > > +
> > > +    return 0;
> > > +}
> > > +
> > > +static void free_channel_list(void)
> > > +{
> > > +    struct scmi_channel *curr, *_curr;
> > > +
> > > +    spin_lock(&scmi_data.channel_list_lock);
> > > +    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list, list)
> > > +    {
> > > +        vunmap(curr->shmem);
> > > +        list_del(&curr->list);
> > > +        xfree(curr);
> > > +    }
> > > +
> > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > +}
> > > +
> > > +static __init bool scmi_probe(struct dt_device_node *scmi_node)
> > > +{
> > > +    struct dt_device_node *shmem_node;
> > > +    int ret, i;
> > > +    struct scmi_channel *channel, *agent_channel;
> > > +    int n_agents;
> > > +    scmi_msg_header_t hdr;
> > > +    struct rx_t {
> > > +        int32_t status;
> > > +        uint32_t attributes;
> > > +    } rx;
> > 
> > Should rx be defined at the top together with scmi_perms_tx_t and
> > others?
> > 
> 
> I'd rather move scmi_perms_tx_t to scmi_add_device_by_devid because it's
> used only in 1 place.
> So we will have rx and tx in scmi_add_device_by_devid and rx ( which
> differs from rx in scmi_add_device_by_devid ) in scmi_probe.
> I think it will be more understandable and no need to make unique names.
> What do you think about that?

I think that's OK

 
> > > +    uint32_t func_id;
> > > +
> > > +    ASSERT(scmi_node != NULL);
> > > +
> > > +    INIT_LIST_HEAD(&scmi_data.channel_list);
> > > +    spin_lock_init(&scmi_data.channel_list_lock);
> > > +
> > > +    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
> > > +    {
> > > +        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n");
> > > +        return false;
> > > +    }
> > > +
> > > +    shmem_node = dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);
> > 
> > From the spec, it looks like you should be getting the shared memory
> > area from the phandle list "shmem".
> > 
> 
> We use SCMI_SHARED_MEMORY to get whole memory region (0x10 pages in my case),
> we can use for the agents. As you can see below - Hypervisor received number of
> agents from Firmware and split this region between agents.

In general we can't use properties that are not part of the device tree
spec, either https://www.devicetree.org/specifications/ or
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings

"linux,scmi_mem" is currently absent. Are you aware of any upstreaming
activities to get "linux,scmi_mem" upstream under
Documentation/devicetree/bindings in Linux?

If "linux,scmi_mem" is going upstream in Linux, then we could use it.
Otherwise, first "linux,scmi_mem" needs to be added somewhere under
Documentation/devicetree/bindings (probably
Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we can
work on the Xen code that makes use of it.

Does it make sense?

 
> > > +    if ( IS_ERR_OR_NULL(shmem_node) )
> > > +    {
> > > +        printk(XENLOG_ERR
> > > +               "scmi: Device tree error, can't parse shmem phandle %ld\n",
> > > +               PTR_ERR(shmem_node));
> > > +        return false;
> > > +    }
> > > +
> > > +    ret = dt_device_get_address(shmem_node, 0, &scmi_data.shmem_addr,
> > > +                                &scmi_data.shmem_size);
> > > +    if ( IS_ERR_VALUE(ret) )
> > > +        return false;
> > > +
> > > +    channel = smc_create_channel(HYP_CHANNEL, func_id, scmi_data.shmem_addr);
> > > +    if ( IS_ERR(channel) )
> > > +        return false;
> > > +
> > > +    hdr.id = SCMI_BASE_PROTOCOL_ATTIBUTES;
> > > +    hdr.type = 0;
> > > +    hdr.protocol = SCMI_BASE_PROTOCOL;
> > > +
> > > +    ret = do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
> > > +    if ( ret )
> > > +        goto clean;
> > > +
> > > +    ret = check_scmi_status(rx.status);
> > > +    if ( ret )
> > > +        goto clean;
> > > +
> > > +    n_agents = FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
> > > +    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
> > > +
> > > +    n_agents = (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
> > > +        scmi_data.shmem_size / PAGE_SIZE : n_agents;
> > > +
> > > +    for ( i = 1; i < n_agents; i++ )
> > > +    {
> > 
> > Given that HYP_CHANNEL is actually zero, it looks like we could do
> > everything here in this loop but starting from i=0?
> > 
> 
> We allocate HYP_CHANNEL before loop because we need it to request number
> of agents. And we don't need to send SCMI_BASE_DISCOVER_AGENT to
> HYP_CHANNEL.
 
OK

 
> > > +        uint32_t tx_agent_id = 0xFFFFFFFF;
> > > +        struct {
> > > +            int32_t status;
> > > +            uint32_t agent_id;
> > > +            char name[16];
> > > +        } da_rx;
> > > +
> > > +        agent_channel = smc_create_channel(i, func_id, scmi_data.shmem_addr +
> > > +                                           i * PAGE_SIZE);
> > > +        if ( IS_ERR(agent_channel) )
> > > +        {
> > > +            ret = PTR_ERR(agent_channel);
> > > +            goto clean;
> > > +        }
> > > +
> > > +        hdr.id = SCMI_BASE_DISCOVER_AGENT;
> > > +        hdr.type = 0;
> > > +        hdr.protocol = SCMI_BASE_PROTOCOL;
> > > +
> > > +        ret = do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
> > > +                          sizeof(tx_agent_id), &da_rx, sizeof(da_rx));
> > > +        if ( ret )
> > > +            goto clean;
> > > +
> > > +        ret = check_scmi_status(da_rx.status);
> > > +        if ( ret )
> > > +            goto clean;
> > > +
> > > +        printk(XENLOG_DEBUG "scmi: status=0x%x id=0x%x name=%s\n",
> > > +                da_rx.status, da_rx.agent_id, da_rx.name);
> > > +
> > > +        agent_channel->agent_id = da_rx.agent_id;
> > > +    }
> > > +
> > > +    scmi_data.initialized = true;
> > > +    return true;
> > > +
> > > +clean:
> > > +    free_channel_list();
> > > +    return ret == 0;
> > > +}
> > > +
> > > +static int scmi_domain_init(struct domain *d)
> > > +{
> > > +    struct scmi_channel *channel;
> > > +    int ret;
> > > +
> > > +    if ( !scmi_data.initialized )
> > > +        return 0;
> > > +
> > > +    channel = aquire_scmi_channel(d->domain_id);
> > > +    if ( IS_ERR_OR_NULL(channel) )
> > > +        return -ENOENT;
> > > +
> > > +    printk(XENLOG_INFO "scmi: Aquire SCMI channel id = 0x%x , domain_id = %d"
> > > +           "paddr = 0x%lx\n", channel->chan_id, channel->domain_id,
> > > +           channel->paddr);
> > > +
> > > +    if ( is_hardware_domain(d) )
> > > +    {
> > > +        ret = map_memory_to_domain(d, scmi_data.shmem_addr,
> > > +                                   scmi_data.shmem_size);
> > > +        if ( IS_ERR_VALUE(ret) )
> > > +            goto error;
> > > +
> > > +        ret = dt_update_domain_range(d, channel->paddr, PAGE_SIZE);
> > > +        if ( IS_ERR_VALUE(ret) )
> > > +        {
> > > +            int rc = unmap_memory_from_domain(d, scmi_data.shmem_addr,
> > > +                                              scmi_data.shmem_size);
> > > +            if ( rc )
> > > +                printk(XENLOG_ERR "Unable to unmap_memory_from_domain\n");
> > > +
> > > +            goto error;
> > > +        }
> > > +    }
> > 
> > Is dom0 the only domain to get direct access to the shared memory
> > region? If so, I don't think it is a good idea to make Dom0 "special" in
> > this case.
> > 
> > Let me make an example: if we assign a device to a domU since boot, and
> > dom0 wants to change the frequency of a clock that affects the assigned
> > device (likely because it doesn't know it is assigned), then dom0
> > shouldn't be able to.  We might have to perform checks in Xen to make
> > sure dom0 cannot stop the clock for the assigned device. 
> > 
> > So I think it would be better if all domains are treated the same way in
> > the mediator unless really necessary.
> > 
> > On the other hand, if all domains get access to the shared memory
> > region, then I don't think this is likely the right place to create the
> > dom0 mapping. We probably want to do it in domain_build.c in a way that
> > can be reused for dom0less domUs.
> > 
> 
> The idea is that all domains have their own page in shared memory
> region and unigue agent_id. Agent_id is used to set permissions for
> clocks\resets\power-domains etc. So during creation of domain (domUs or
> dom0) device-tree is processed using scmi_add_dt_device and
> clocks\resets\power-domains which are related to dom0 devices will be
> requested by using SCMI_BASE_SET_DEVICE_PERMISSIONS message.
> All passed-through devices will be requested during DomU creation. Which
> means dom0 do not have an access to clocks\resets\power-domains, which
> are related to DomU.

OK, excellent


> > In regards to shared memory: it looks like the only two functions to
> > access the real shared memory are send_smc_message and get_smc_response.
> > If that is the case, then we actually don't need to expose the real
> > shared memory to any of the domains.
> > 
> > We could simply:
> > 
> > - expose a regular normal memory region as dom0/domU channel memory
> > - on SMC trap, read from the "fake" shared memory and set the
> >   corresponding real shared memory on the appropriate channel
> > - issue the SMC call
> > - on return from SMC, copy over data from the real shared memory to the
> >   "fake" channel reagion
> 
> Hypervisor redirects only SMC calls from guests and set agent_id to SMC
> parameters as a7. The idea was to give page for each agent, so we don't
> need to make additional read/write each time we receive SMC call.
> All we povide from hypervisor is agent_id. Firmware is responsible for
> reading memory from the correct address and place the response.
> 
> > 
> > This is useful if we need to "filter" any of the SCMI commands and
> > options from the domains to the firmware, and also it is useful if the
> > channel memory is not page aligned. But if the permissions are
> > fine-grained enough and also the channel memory is page aligned (and
> > multiple of 4K in size) then we could map the memory.
> > 
> 
> In current implementation we suppose that channel memory is page aligned.
> I think that Firmware should be responsible for permissions handling and
> "filtering", that's why permission calls were added to SCMI spec.
> I tried to make mediator as thin as possible.

OK. Can we check that the channel memory is page aligned at init time
and throw an error if it is not the case?


> > > +
> > > +    d->arch.sci = channel;
> > > +
> > > +    return 0;
> > > +error:
> > > +    relinquish_scmi_channel(channel);
> > > +
> > > +    return ret;
> > > +}
> > > +
> > > +static int scmi_add_device_by_devid(struct domain *d, uint32_t scmi_devid)
> > > +{
> > > +    struct scmi_channel *channel, *agent_channel;
> > > +    scmi_msg_header_t hdr;
> > > +    scmi_perms_tx_t tx;
> > > +    struct rx_t {
> > > +        int32_t status;
> > > +        uint32_t attributes;
> > > +    } rx;
> > > +    int ret;
> > > +
> > > +    if ( !scmi_data.initialized )
> > > +        return 0;
> > > +
> > > +    printk(XENLOG_DEBUG "scmi: scmi_devid = %d\n", scmi_devid);
> > > +
> > > +    agent_channel = get_channel_by_domain(d->domain_id);
> > > +    if ( IS_ERR_OR_NULL(agent_channel) )
> > > +        return PTR_ERR(agent_channel);
> > > +
> > > +    channel = get_channel_by_id(HYP_CHANNEL);
> > > +    if ( IS_ERR_OR_NULL(channel) )
> > > +        return PTR_ERR(channel);
> > > +
> > > +    hdr.id = SCMI_BASE_SET_DEVICE_PERMISSIONS;
> > > +    hdr.type = 0;
> > > +    hdr.protocol = SCMI_BASE_PROTOCOL;
> > > +
> > > +    tx.agent_id = agent_channel->agent_id;
> > > +    tx.device_id = scmi_devid;
> > > +    tx.flags = SCMI_ALLOW_ACCESS;
> > > +
> > > +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(&rx));
> > > +    if ( IS_ERR_VALUE(ret) )
> > > +        return ret;
> > > +
> > > +    ret = check_scmi_status(rx.status);
> > > +    if ( IS_ERR_VALUE(ret) )
> > > +        return ret;
> > > +
> > > +    return 0;
> > > +}
> > > +
> > > +static int scmi_add_dt_device(struct domain *d, struct dt_device_node *dev)
> > > +{
> > > +    uint32_t scmi_devid;
> > > +
> > > +    if ( (!scmi_data.initialized) || (!d->arch.sci) )
> > > +        return 0;
> > > +
> > > +    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
> > > +        return 0;
> > 
> > scmi_devid is another property that is not documented in the binding.
> > 
> 
> This property should be added to the device nodes, which are using scmi
> to work with clocks\resets\power-domains etc. This id should match the
> device_id, defined in Firmware. Hypervisor send this device_id to the Firmware
> as parameter to the permission request. Firmware set permissions to
> clocks\resets\power-domains, related to this device.

OK, I see. Unfortunately, scmi_devid is also not described under
Documentation/devicetree/bindings/.

This property seems to be actually required for the system to work
correctly.

Unless somebody else is already working on this, please send a patch to
the Linux kernel mailing list CCing the SCMI maintainers and Rob Herring
to introduce scmi_devid as a new property.


> > > +    printk(XENLOG_INFO "scmi: dt_node = %s\n", dt_node_full_name(dev));
> > > +
> > > +    return scmi_add_device_by_devid(d, scmi_devid);
> > > +}
> > > +
> > > +static int scmi_relinquish_resources(struct domain *d)
> > > +{
> > > +    int ret;
> > > +    struct scmi_channel *channel, *agent_channel;
> > > +    scmi_msg_header_t hdr;
> > > +    struct reset_agent_tx {
> > > +        uint32_t agent_id;
> > > +        uint32_t flags;
> > > +    } tx;
> > > +    uint32_t rx;
> > > +
> > > +    if ( !d->arch.sci )
> > > +        return 0;
> > > +
> > > +    agent_channel = d->arch.sci;
> > > +
> > > +    spin_lock(&agent_channel->lock);
> > > +    tx.agent_id = agent_channel->agent_id;
> > > +    spin_unlock(&agent_channel->lock);
> > > +
> > > +    channel = get_channel_by_id(HYP_CHANNEL);
> > > +    if ( !channel )
> > > +    {
> > > +        printk(XENLOG_ERR
> > > +               "scmi: Unable to get Hypervisor scmi channel for domain %d\n",
> > > +               d->domain_id);
> > > +        return -EINVAL;
> > > +    }
> > > +
> > > +    hdr.id = SCMI_BASE_RESET_AGENT_CONFIGURATION;
> > > +    hdr.type = 0;
> > > +    hdr.protocol = SCMI_BASE_PROTOCOL;
> > > +
> > > +    tx.flags = 0;
> > > +
> > > +    ret = do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeof(rx));
> > > +    if ( ret )
> > > +        return ret;
> > > +
> > > +    ret = check_scmi_status(rx);
> > > +
> > > +    return ret;
> > > +}
> > > +
> > > +static void scmi_domain_destroy(struct domain *d)
> > > +{
> > > +    struct scmi_channel *channel;
> > > +
> > > +    if ( !d->arch.sci )
> > > +        return;
> > > +
> > > +    channel = d->arch.sci;
> > > +    spin_lock(&channel->lock);
> > > +
> > > +    relinquish_scmi_channel(channel);
> > > +    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
> > > +
> > > +    d->arch.sci = NULL;
> > > +
> > > +    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
> > > +    spin_unlock(&channel->lock);
> > > +    return;
> > > +}
> > > +
> > > +static bool scmi_handle_call(struct domain *d, void *args)
> > > +{
> > > +    bool res = false;
> > > +    struct scmi_channel *agent_channel;
> > > +    struct arm_smccc_res resp;
> > > +    struct cpu_user_regs *regs = args;
> > > +
> > > +    if ( !d->arch.sci )
> > > +        return false;
> > > +
> > > +    agent_channel = d->arch.sci;
> > > +    spin_lock(&agent_channel->lock);
> > > +
> > > +    if ( agent_channel->func_id != regs->x0 )
> > > +    {
> > > +        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
> > > +        goto unlock;
> > > +    }
> > > +
> > > +    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
> > > +                  agent_channel->chan_id, &resp);
> > > +
> > > +    set_user_reg(regs, 0, resp.a0);
> > > +    set_user_reg(regs, 1, resp.a1);
> > > +    set_user_reg(regs, 2, resp.a2);
> > > +    set_user_reg(regs, 3, resp.a3);
> > > +    res = true;
> > > +unlock:
> > > +    spin_unlock(&agent_channel->lock);
> > > +
> > > +    return res;
> > > +}
> > > +
> > > +static int scmi_get_channel_paddr(void *scmi_ops,
> > > +                           struct xen_arch_domainconfig *config)
> > > +{
> > > +    struct scmi_channel *agent_channel = scmi_ops;
> > > +
> > > +    if ( !agent_channel )
> > > +        return -EINVAL;
> > > +
> > > +    config->sci_agent_paddr = agent_channel->paddr;
> > > +    return 0;
> > > +}
> > 
> > I am still not sure why it couldn't be done by scmi_domain_init.
> >
> 
> I can move this logic to scmi_domain_init, but in this case I have to add
> struct xen_arch_domainconfig *config as input parameter to
> scmi_domain_init and pass NULL from construct_dom0.
> Do you think this approach would be better?

I think it is OK to pass struct xen_arch_domainconfig *config as input
parameter to scmi_domain_init.

For dom0, why is sci_agent_paddr not supposed to be set?



> Also I think it's reasonable to pass xen_arch_domainconfig so different
> implementations could set another data they would probably need.
> 
> > 
> > > +static const struct dt_device_match scmi_smc_match[] __initconst =
> > > +{
> > > +    DT_MATCH_SCMI_SMC,
> > > +    { /* sentinel */ },
> > > +};
> > > +
> > > +static const struct sci_mediator_ops scmi_ops =
> > > +{
> > > +    .probe = scmi_probe,
> > > +    .domain_init = scmi_domain_init,
> > > +    .domain_destroy = scmi_domain_destroy,
> > > +    .add_dt_device = scmi_add_dt_device,
> > > +    .relinquish_resources = scmi_relinquish_resources,
> > > +    .handle_call = scmi_handle_call,
> > > +    .get_channel_info = scmi_get_channel_paddr
> > > +};
> > > +
> > > +REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_SCMI_SMC,
> > > +                      scmi_smc_match, &scmi_ops);
> > > +
> > > +/*
> > > + * Local variables:
> > > + * mode: C
> > > + * c-file-style: "BSD"
> > > + * c-basic-offset: 4
> > > + * indent-tabs-mode: nil
> > > + * End:
> > > + */
> > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > > index 9180be5e86..a67237942d 100644
> > > --- a/xen/include/public/arch-arm.h
> > > +++ b/xen/include/public/arch-arm.h
> > > @@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> > >  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> > >  
> > >  #define XEN_DOMCTL_CONFIG_SCI_NONE      0
> > > +#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
> > >  
> > >  struct xen_arch_domainconfig {
> > >      /* IN/OUT */


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 00:54:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 00:54:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250078.430682 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzTQE-0004I6-4S; Tue, 21 Dec 2021 00:54:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250078.430682; Tue, 21 Dec 2021 00:54:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzTQE-0004Hz-1P; Tue, 21 Dec 2021 00:54:30 +0000
Received: by outflank-mailman (input) for mailman id 250078;
 Tue, 21 Dec 2021 00:54:29 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzTQC-0004Ht-Ux
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 00:54:28 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8c101334-61f8-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 01:54:28 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id CB72561312;
 Tue, 21 Dec 2021 00:54:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA9CC36AE5;
 Tue, 21 Dec 2021 00:54:25 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c101334-61f8-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640048066;
	bh=dgbaOUeuqqsjuv9beSywo5m2obZqLKj27sugTVKKYIY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=dRBHrZ8PF1p3jSNZWgu3cbpEhz6z39/5LlvNDqWA7001zAvvBmThXtQbgMJ/FeioF
	 rgRnhxidVUgLxHBej7PwwEEm+QBvRCfddN8nkZeGA6DBk24z7ug9i+L87gUi+eqRxg
	 baMsJc8EX01GyI2YLCzMVMOeqnPcoSNgqUgQEM1Tez4BFBVwq8vcoUuaV+D+RJoCJh
	 pbTDlO1Oezpu2Yp/W7bdVLXYdJJ1Z8PmtYSnOIxhuo64PcX0tFC6gBxHkym8FTPKdO
	 kb2omg8xQ61z04d3J93z3tZTDDC2mXS4JeaOOdTLzLX5vSl2waNcWyqHm0XEQVf9Us
	 HLkJS366s3AYQ==
Date: Mon, 20 Dec 2021 16:54:25 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
In-Reply-To: <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112201653500.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> This enumeration sets SCI type for the domain. Currently there is
> two possible options: either 'none' or 'scmi_smc'.
> 
> 'none' is the default value and it disables SCI support at all.
> 
> 'scmi_smc' enables access to the Firmware from the domains using SCMI
> protocol and SMC as transport.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>  docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
>  tools/include/libxl.h            |  5 +++++
>  tools/libs/light/libxl_types.idl |  6 ++++++
>  tools/xl/xl_parse.c              |  9 +++++++++
>  4 files changed, 42 insertions(+)
> 
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index b98d161398..92d0593875 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
>  
>  =back
>  
> +=item B<sci="STRING">
> +
> +B<Arm only> Set SCI type for the guest. SCI is System Control Protocol -
> +allows domain to manage various functions that are provided by HW platform.
> +
> +=over 4
> +
> +=item B<none>
> +
> +Don't allow guest to use SCI if present on the platform. This is the default
> +value.
> +
> +=item B<scmi_smc>
> +
> +Enables SCMI-SMC support for the guest. SCMI is System Control Management
> +Inferface - allows domain to manage various functions that are provided by HW
> +platform, such as clocks, resets and power-domains. Xen will mediate access to
> +clocks, power-domains and resets between Domains and ATF. Disabled by default.
> +SMC is used as transport.

Would it make sense to actually enable SCMI-SMC support for the guest by
default if the guest has any devices directly assigned?


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 01:38:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 01:38:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250084.430694 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzU6I-0002R4-F2; Tue, 21 Dec 2021 01:37:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250084.430694; Tue, 21 Dec 2021 01:37:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzU6I-0002Qx-AV; Tue, 21 Dec 2021 01:37:58 +0000
Received: by outflank-mailman (input) for mailman id 250084;
 Tue, 21 Dec 2021 01:37:57 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzU6H-0002Qb-5Z
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 01:37:57 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9de20094-61fe-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 02:37:55 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 8EDBEB81103;
 Tue, 21 Dec 2021 01:37:53 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DF37C36AE8;
 Tue, 21 Dec 2021 01:37:51 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9de20094-61fe-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640050672;
	bh=gyJUfUIO40WYUae6Xa3az1Mhe/TOTgOQj4ue4qzZwpM=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=UrlX+xfpDCyFs0oD4Q5wtSdGavFy0zFaMyLclWp0a2Rj0COIaiqd0snAzvbTOIWq2
	 AEFmKtzxFcRR0YHlLQpG9zdrCHVA/+0KxFwvzHhX6JiVaC7YQp+o1lZOsf7Y/UuGni
	 gh0GckY/zikpDUTVPVzUn7mt8lVERAmP2UT2tdTQwgbGicVQE4FWThm/qQVT0J6npR
	 mNz3HPMJ+E5Q2bhjwSPLZkWPyWaUPbwXexVbIWPkNj/ttV7/zpqUIg6CvgCkZVl4lZ
	 N7+aQooe3HpjEVS0Lo2QQMNenWvKI6OeOHPIUIQ9zXSxjFLS16Hx6okBLbrs8LWaSK
	 faG4wFs1e4edg==
Date: Mon, 20 Dec 2021 17:37:50 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
In-Reply-To: <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112201703310.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> Integration of the SCMI mediator with xen libs:
> - add hypercalls to aquire SCI channel and set device permissions
> for DomUs;
> - add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
> - SCI requests redirection from DomUs to Firmware.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---
>  tools/include/xenctrl.h           |   3 +
>  tools/include/xenguest.h          |   2 +
>  tools/libs/ctrl/xc_domain.c       |  23 ++++++
>  tools/libs/guest/xg_dom_arm.c     |   5 +-
>  tools/libs/light/libxl_arm.c      | 122 +++++++++++++++++++++++++++---
>  tools/libs/light/libxl_create.c   |  54 ++++++++++++-
>  tools/libs/light/libxl_dom.c      |   1 +
>  tools/libs/light/libxl_internal.h |   4 +
>  xen/arch/arm/domctl.c             |  15 ++++
>  xen/include/public/domctl.h       |   9 +++
>  10 files changed, 223 insertions(+), 15 deletions(-)
> 
> diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> index 07b96e6671..cdd14f465f 100644
> --- a/tools/include/xenctrl.h
> +++ b/tools/include/xenctrl.h
> @@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
>  int xc_domain_soft_reset(xc_interface *xch,
>                           uint32_t domid);
>  
> +int xc_domain_add_sci_device(xc_interface *xch,
> +                              uint32_t domid, char *path);
> +
>  #if defined(__i386__) || defined(__x86_64__)
>  /*
>   * PC BIOS standard E820 types and structure.
> diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h
> index 61d0a82f48..35c611ac73 100644
> --- a/tools/include/xenguest.h
> +++ b/tools/include/xenguest.h
> @@ -242,6 +242,8 @@ struct xc_dom_image {
>  
>      /* Number of vCPUs */
>      unsigned int max_vcpus;
> +
> +    xen_pfn_t sci_shmem_gfn;

We should be able to avoid introducing sci_shmem_gfn (more below)


>  };
>  
>  /* --- arch specific hooks ----------------------------------------- */
> diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> index b155d6afd2..07bb390e17 100644
> --- a/tools/libs/ctrl/xc_domain.c
> +++ b/tools/libs/ctrl/xc_domain.c
> @@ -2206,6 +2206,29 @@ int xc_domain_soft_reset(xc_interface *xch,
>      domctl.domain = domid;
>      return do_domctl(xch, &domctl);
>  }
> +
> +int xc_domain_add_sci_device(xc_interface *xch,
> +                              uint32_t domid, char *path)
> +{
> +    size_t size = strlen(path);
> +    int rc;
> +    DECLARE_DOMCTL;
> +    DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN);
> +
> +    if ( xc_hypercall_bounce_pre(xch, path) )
> +        return -1;
> +
> +    domctl.cmd = XEN_DOMCTL_add_sci_device;
> +    domctl.domain = domid;
> +    domctl.u.sci_device_op.size = size;
> +    set_xen_guest_handle(domctl.u.sci_device_op.path, path);
> +    rc = do_domctl(xch, &domctl);
> +
> +    xc_hypercall_bounce_post(xch, path);
> +
> +    return rc;
> +}

I'd skip this xc_ function and hypercall (more below)


>  /*
>   * Local variables:
>   * mode: C
> diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c
> index 5e3b76355e..368a670c46 100644
> --- a/tools/libs/guest/xg_dom_arm.c
> +++ b/tools/libs/guest/xg_dom_arm.c
> @@ -25,11 +25,12 @@
>  
>  #include "xg_private.h"
>  
> -#define NR_MAGIC_PAGES 4
> +#define NR_MAGIC_PAGES 5
>  #define CONSOLE_PFN_OFFSET 0
>  #define XENSTORE_PFN_OFFSET 1
>  #define MEMACCESS_PFN_OFFSET 2
>  #define VUART_PFN_OFFSET 3
> +#define SCI_SHMEM_OFFSET 4
>  
>  #define LPAE_SHIFT 9
>  
> @@ -69,11 +70,13 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
>      dom->console_pfn = base + CONSOLE_PFN_OFFSET;
>      dom->xenstore_pfn = base + XENSTORE_PFN_OFFSET;
>      dom->vuart_gfn = base + VUART_PFN_OFFSET;
> +    dom->sci_shmem_gfn = base + SCI_SHMEM_OFFSET;
>  
>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
>      xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET);
>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn);
> +    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->sci_shmem_gfn);

Given that sci_shmem_gfn doesn't actually require any allocations, just
a remapping of an existing and already specified physical page, then I
don't think we need to add a new page to alloc_magic_pages for it.

We can just #define a static address for the SCMI page in the domU
addres space and use it for the mapping. No need to allocate a new
page.


>      xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
>              dom->console_pfn);
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index eef1de0939..73ef591822 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -8,6 +8,8 @@
>  #include <assert.h>
>  #include <xen/device_tree_defs.h>
>  
> +#define SCMI_NODE_PATH      "/firmware/scmi"
> +
>  static const char *gicv_to_string(libxl_gic_version gic_version)
>  {
>      switch (gic_version) {
> @@ -101,6 +103,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
>          return ERROR_FAIL;
>      }
>  
> +    switch (d_config->b_info.sci) {
> +    case LIBXL_SCI_TYPE_NONE:
> +        config->arch.sci_type = XEN_DOMCTL_CONFIG_SCI_NONE;
> +        break;
> +    case LIBXL_SCI_TYPE_SCMI_SMC:
> +        config->arch.sci_type = XEN_DOMCTL_CONFIG_SCI_SCMI_SMC;
> +        break;
> +    default:
> +        LOG(ERROR, "Unknown SCI type %d",
> +            d_config->b_info.sci);
> +        return ERROR_FAIL;
> +    }
> +
>      return 0;
>  }
>  
> @@ -122,6 +137,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
>      }
>  
>      state->clock_frequency = config->arch.clock_frequency;
> +    state->sci_agent_paddr = config->arch.sci_agent_paddr;
>  
>      return 0;
>  }
> @@ -502,9 +518,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
>      int res;
>      LOG(DEBUG, "Creating OP-TEE node in dtb");
>  
> -    res = fdt_begin_node(fdt, "firmware");
> -    if (res) return res;
> -
>      res = fdt_begin_node(fdt, "optee");
>      if (res) return res;
>  
> @@ -517,9 +530,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt)
>      res = fdt_end_node(fdt);
>      if (res) return res;
>  
> -    res = fdt_end_node(fdt);
> -    if (res) return res;
> -
>      return 0;
>  }
>  
> @@ -902,10 +912,9 @@ static int copy_node(libxl__gc *gc, void *fdt, void *pfdt,
>      return 0;
>  }
>  
> -static int copy_node_by_path(libxl__gc *gc, const char *path,
> -                             void *fdt, void *pfdt)
> +static int get_path_nodeoff(const char *path, void *pfdt)
>  {
> -    int nodeoff, r;
> +    int nodeoff;
>      const char *name = strrchr(path, '/');
>  
>      if (!name)
> @@ -925,12 +934,101 @@ static int copy_node_by_path(libxl__gc *gc, const char *path,
>      if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
>          return -FDT_ERR_NOTFOUND;
>  
> +    return nodeoff;
> +}
> +
> +static int copy_node_by_path(libxl__gc *gc, const char *path,
> +                             void *fdt, void *pfdt)
> +{
> +    int nodeoff, r;
> +
> +    nodeoff = get_path_nodeoff(path, pfdt);
> +    if (nodeoff < 0)
> +        return nodeoff;
> +
>      r = copy_node(gc, fdt, pfdt, nodeoff, 0);
>      if (r) return r;
>  
>      return 0;
>  }
>  
> +static int get_node_phandle(const char *path, void *pfdt, uint32_t *phandle)
> +{
> +    int nodeoff;
> +    const char *name = strrchr(path, '/');
> +
> +    if (!name)
> +        return -FDT_ERR_INTERNAL;
> +
> +    name++;
> +    nodeoff = fdt_path_offset(pfdt, path);
> +    if (nodeoff < 0)
> +        return nodeoff;
> +
> +    *phandle = fdt_get_phandle(pfdt, nodeoff);
> +    return 0;
> +}
> +
> +static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt,
> +                           struct xc_dom_image *dom)
> +{
> +    int res;
> +    char buf[64];
> +    uint32_t phandle = 0;
> +
> +    res = get_node_phandle("/scp-shmem", pfdt, &phandle);
> +    if (res) return res;

I hope we'll be able to avoid requiring the user to write a partial
device tree with SCMI info in order to use it.

But if we have to go down this route, then we need to add a description
of scp-shmem under docs/misc/arm/

Also, in general, we cannot mandate or require specific paths in device
tree and instead we should find nodes based on the compatible string.
(There are exceptions like /reserved-memory and /firmware but they are
only a couple.)


> +    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
> +             dom->sci_shmem_gfn << XC_PAGE_SHIFT);
> +    res = fdt_begin_node(fdt, buf);
> +    if (res) return res;
> +
> +    res = fdt_property_compat(gc, fdt, 1, "arm,scmi-shmem");
> +    if (res) return res;
> +
> +    res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> +                    GUEST_ROOT_SIZE_CELLS, 1,
> +                    dom->sci_shmem_gfn << XC_PAGE_SHIFT, XC_PAGE_SHIFT);
> +    if (res) return res;
> +
> +    LOG(DEBUG, "scmi: setting phandle = %u\n", phandle);
> +    res = fdt_property_cell(fdt, "phandle", phandle);
> +    if (res) return res;
> +
> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
> +static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, int tee,
> +                              int sci)
> +{
> +    int res;
> +
> +    if ((tee != LIBXL_TEE_TYPE_OPTEE) && (sci != LIBXL_SCI_TYPE_NONE))
> +        return 0;

Shouldn't this be:

    if ((tee != LIBXL_TEE_TYPE_OPTEE) && (sci == LIBXL_SCI_TYPE_NONE))


> +    res = fdt_begin_node(fdt, "firmware");
> +    if (res) return res;
> +
> +    if (tee == LIBXL_TEE_TYPE_OPTEE) {
> +       res = make_optee_node(gc, fdt);
> +       if (res) return res;
> +    }
> +
> +    if (sci == LIBXL_SCI_TYPE_SCMI_SMC) {
> +        res = copy_node_by_path(gc, SCMI_NODE_PATH, fdt, pfdt);
> +        if (res) return res;
> +    }

Do we really need to copy the node from the partial device tree? That
makes it a lot harder to use for the user. Ideally a user would only
need to specify sci = "scmi_smc" and everything else should be done
automatically.

Can we automatically generate the SCMI device tree node instead? It
looks like we should have all the information to be able to do it. If
not, what is missing?


> +    res = fdt_end_node(fdt);
> +    if (res) return res;
> +
> +    return 0;
> +}
> +
>  /*
>   * The partial device tree is not copied entirely. Only the relevant bits are
>   * copied to the guest device tree:
> @@ -1088,8 +1186,10 @@ next_resize:
>          if (info->arch_arm.vuart == LIBXL_VUART_TYPE_SBSA_UART)
>              FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
>  
> -        if (info->tee == LIBXL_TEE_TYPE_OPTEE)
> -            FDT( make_optee_node(gc, fdt) );
> +        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->sci) );
> +
> +        if (info->sci == LIBXL_SCI_TYPE_SCMI_SMC)
> +            FDT( make_scmi_shmem_node(gc, fdt, pfdt, dom) );
>  
>          if (d_config->num_pcidevs)
>              FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index dcd09d32ba..c7372fd344 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -596,6 +596,37 @@ out:
>      return ret;
>  }
>  
> +static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
> +                         uint64_t guest_addr)
> +{
> +    int ret;
> +    uint64_t _paddr_pfn = paddr >> XC_PAGE_SHIFT;
> +    uint64_t _guest_pfn = guest_addr >> XC_PAGE_SHIFT;
> +
> +    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
> +
> +    ret = xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1, 1);
> +    if (ret < 0) {
> +        LOG(ERROR,
> +              "failed give domain access to iomem page %"PRIx64,
> +             _paddr_pfn);
> +        return ret;
> +    }
> +
> +    ret = xc_domain_memory_mapping(CTX->xch, domid,
> +                                   _guest_pfn, _paddr_pfn,
> +                                   1, 1);
> +    if (ret < 0) {
> +        LOG(ERROR,
> +              "failed to map to domain iomem page %"PRIx64
> +              " to guest address %"PRIx64,
> +              _paddr_pfn, _guest_pfn);
> +        return ret;
> +    }
> +
> +    return 0;
> +}
> +
>  int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>                         libxl__domain_build_state *state,
>                         uint32_t *domid, bool soft_reset)
> @@ -762,6 +793,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
>          goto out;
>      }
>  
> +    if (state->sci_agent_paddr != 0) {

Shouldn't we also check for sci_type == XEN_DOMCTL_CONFIG_SCI_NONE ?

If the user specifies sci_type == XEN_DOMCTL_CONFIG_SCI_SCMI_SMC, we
shouldn't automatically map any SCMI channels to the guest, right?


> +        ret = map_sci_page(gc, *domid, state->sci_agent_paddr,
> +                            state->sci_shmem_gfn << XC_PAGE_SHIFT);
> +        if (ret < 0) {
> +            LOGED(ERROR, *domid, "map SCI page fail");
> +            rc = ERROR_FAIL;
> +            goto out;
> +        }
> +    }
> +
>      dom_path = libxl__xs_get_dompath(gc, *domid);
>      if (!dom_path) {
>          rc = ERROR_FAIL;
> @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
>  {
>      AO_GC;
>      libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
> -    int i, rc = 0;
> +    int i, rc = 0, rc_sci = 0;
>  
>      for (i = 0; i < d_config->num_dtdevs; i++) {
>          const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
>  
>          LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
>          rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> -        if (rc < 0) {
> -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
> +
> +        if ((rc < 0) && (rc_sci < 0)) {
> +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> +                 "xc_domain_add_sci_device failed: %d",
> +                 rc, rc_sci);
>              goto out;
>          }
> +
> +        if (rc)
> +            rc = rc_sci;

I would make this simpler actually. Do we need to pass dtdev->path
twice, once for xc_assign_dt_device and a second time for
xc_domain_add_sci_device?

I would skip adding xc_domain_add_sci_device altogether. A general SCMI
enable/disable for the domain is necessary, but then we can just get the
directly assigned devices from xc_assign_dt_device. There is no need to
specify the list twice. If a device is not manageable via SCMI we can
detect it automatically because it is going to be missing scmi_devid on
device tree.


>      }
>  
>  out:
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index fe9f760f71..b1d288a8b9 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -710,6 +710,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
>          state->console_mfn = dom->console_pfn;
>          state->store_mfn = dom->xenstore_pfn;
>          state->vuart_gfn = dom->vuart_gfn;
> +        state->sci_shmem_gfn = dom->sci_shmem_gfn;
>      } else {
>          state->console_mfn = xc_dom_p2m(dom, dom->console_pfn);
>          state->store_mfn = xc_dom_p2m(dom, dom->xenstore_pfn);
> diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
> index 0b4671318c..f9f9cc633a 100644
> --- a/tools/libs/light/libxl_internal.h
> +++ b/tools/libs/light/libxl_internal.h
> @@ -1407,6 +1407,10 @@ typedef struct {
>      /* Whether this domain is being migrated/restored, or booting fresh.  Only
>       * applicable to the primary domain, not support domains (e.g. stub QEMU). */
>      bool restore;
> +
> +    /* sci channel paddr to be set to device-tree node */
> +    uint64_t sci_agent_paddr;
> +    xen_pfn_t sci_shmem_gfn;
>  } libxl__domain_build_state;
>  
>  _hidden void libxl__domain_build_state_init(libxl__domain_build_state *s);
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 6245af6d0b..ba200407da 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -4,6 +4,7 @@
>   * Copyright (c) 2012, Citrix Systems
>   */
>  
> +#include <asm/sci/sci.h>
>  #include <xen/errno.h>
>  #include <xen/guest_access.h>
>  #include <xen/hypercall.h>
> @@ -175,6 +176,20 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>  
>          return rc;
>      }
> +    case XEN_DOMCTL_add_sci_device:
> +    {
> +        int rc;
> +        struct dt_device_node *dev;
> +
> +        rc = dt_find_node_by_gpath(domctl->u.sci_device_op.path,
> +                                   domctl->u.sci_device_op.size,
> +                                   &dev);
> +        if ( rc )
> +            return rc;
> +
> +        return sci_add_dt_device(d, dev);
> +    }

I would skip it and instead I would add a call to sci_add_dt_device in
the implementation of XEN_DOMCTL_assign_device.


>      default:
>      {
>          int rc;
> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> index b85e6170b0..671c72c3e8 100644
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
>  #define XEN_DOMCTL_vmtrace_get_option         5
>  #define XEN_DOMCTL_vmtrace_set_option         6
>  };
> +
> +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> +struct xen_domctl_sci_device_op {
> +    uint32_t size; /* Length of the path */
> +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> +};
> +
>  typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
>  
> @@ -1265,6 +1272,7 @@ struct xen_domctl {
>  #define XEN_DOMCTL_get_cpu_policy                82
>  #define XEN_DOMCTL_set_cpu_policy                83
>  #define XEN_DOMCTL_vmtrace_op                    84
> +#define XEN_DOMCTL_add_sci_device                85
>  #define XEN_DOMCTL_gdbsx_guestmemio            1000
>  #define XEN_DOMCTL_gdbsx_pausevcpu             1001
>  #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
> @@ -1326,6 +1334,7 @@ struct xen_domctl {
>          struct xen_domctl_psr_alloc         psr_alloc;
>          struct xen_domctl_vuart_op          vuart_op;
>          struct xen_domctl_vmtrace_op        vmtrace_op;
> +        struct xen_domctl_sci_device_op     sci_device_op;
>          uint8_t                             pad[128];
>      } u;
>  };
> -- 
> 2.27.0
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 05:27:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 05:27:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250091.430705 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzXgX-00012h-5O; Tue, 21 Dec 2021 05:27:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250091.430705; Tue, 21 Dec 2021 05:27:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzXgX-00012a-1F; Tue, 21 Dec 2021 05:27:37 +0000
Received: by outflank-mailman (input) for mailman id 250091;
 Tue, 21 Dec 2021 05:27:36 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzXgW-00012Q-GS; Tue, 21 Dec 2021 05:27:36 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzXgW-00008I-DB; Tue, 21 Dec 2021 05:27:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzXgW-0001B4-3T; Tue, 21 Dec 2021 05:27:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzXgW-0004xC-1a; Tue, 21 Dec 2021 05:27:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YRtbsq4/VuFkYmpFgPOZCZcgZ3y1obis5VpdM0dUOWs=; b=NVAp7oHvyZ5KqkHj+Uu/UvpnFT
	hcnYpZblbG0vqFwR7nZZ5lNqvaRneaVhIIMogwNrtkE3ZY6u3xGa8EeRflLJf6vcJkM0DWl1iG1gO
	4eyIQbySu0IaXAJk76LI2oZ3Nh8Octe6f3s4N/5pgCgT7HSEO+P7Vc6mVfR4nE/vSzB4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167495-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167495: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=86085fe79e3c1a66e32f2acae0ae64f4cceb8d28
X-Osstest-Versions-That:
    linux=a76c3d035872bf390d2fd92d8e5badc5ee28b17d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 05:27:36 +0000

flight 167495 linux-linus real [real]
flight 167498 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167495/
http://logs.test-lab.xenproject.org/osstest/logs/167498/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 167498-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167484
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167484
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167484
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167484
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167484
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167484
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167484
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                86085fe79e3c1a66e32f2acae0ae64f4cceb8d28
baseline version:
 linux                a76c3d035872bf390d2fd92d8e5badc5ee28b17d

Last test of basis   167484  2021-12-19 20:40:59 Z    1 days
Failing since        167486  2021-12-20 02:31:29 Z    1 days    3 attempts
Testing same since   167495  2021-12-20 21:12:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Dongliang Mu <mudongliangabcd@gmail.com>
  Jens Axboe <axboe@kernel.dk>
  Juergen Gross <jgross@suse.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Sean Christopherson <seanjc@google.com>
  Vitaly Kuznetsov <vkuznets@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a76c3d035872..86085fe79e3c  86085fe79e3c1a66e32f2acae0ae64f4cceb8d28 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 06:11:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 06:11:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250105.430720 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYMZ-0006cU-Rd; Tue, 21 Dec 2021 06:11:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250105.430720; Tue, 21 Dec 2021 06:11:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYMZ-0006cE-LL; Tue, 21 Dec 2021 06:11:03 +0000
Received: by outflank-mailman (input) for mailman id 250105;
 Tue, 21 Dec 2021 06:11:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzYMY-0006bs-Bl
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 06:11:02 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c4307c56-6224-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 07:11:00 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D9CB81F388;
 Tue, 21 Dec 2021 06:10:58 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B653613BEC;
 Tue, 21 Dec 2021 06:10:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id 0PU/K/JvwWGpcQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 06:10:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c4307c56-6224-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640067058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=+BCGWtcrwcZjd1gTY6yMO7hvlsZU7ZjX2+zQpiK62SA=;
	b=EkDpu1dBgVO0DRk4iQsQDCF4Kl+0mx5Mi5troK5G4d6F5Cx7xmUHc08j0QcycF2VbdFjPG
	tz8miKMtxcvLnDqWHQp0BYp/O/3V1DARUVxU4ugsuretWsjNWXwCy+85YKiY5smhk6mTw+
	LRLW6FOHSIkp89kS4fcZ9Dg3v1/sCuY=
Subject: Re: [PATCH v2 02/10] mini-os: sort and sanitize e820 memory map
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-3-jgross@suse.com>
 <20211220231730.nivaq6vgtlyfqhng@begin>
From: Juergen Gross <jgross@suse.com>
Message-ID: <cb114a22-f795-6d55-7101-84bd201f3dd8@suse.com>
Date: Tue, 21 Dec 2021 07:10:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211220231730.nivaq6vgtlyfqhng@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="EmIQs1fIhx0bqgUGFs2mZ38AM4ITK67AQ"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EmIQs1fIhx0bqgUGFs2mZ38AM4ITK67AQ
Content-Type: multipart/mixed; boundary="DXQcuAgICIldR3Cl4iRbQZIN2pHSvcgAa";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <cb114a22-f795-6d55-7101-84bd201f3dd8@suse.com>
Subject: Re: [PATCH v2 02/10] mini-os: sort and sanitize e820 memory map
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-3-jgross@suse.com>
 <20211220231730.nivaq6vgtlyfqhng@begin>
In-Reply-To: <20211220231730.nivaq6vgtlyfqhng@begin>

--DXQcuAgICIldR3Cl4iRbQZIN2pHSvcgAa
Content-Type: multipart/mixed;
 boundary="------------851CCEB259C389291C020CC8"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------851CCEB259C389291C020CC8
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 21.12.21 00:17, Samuel Thibault wrote:
> Juergen Gross, le lun. 20 d=C3=A9c. 2021 17:07:08 +0100, a ecrit:
>> +static void e820_sanitize(void)
>> +{
>> +    int i;
>> +    unsigned long end, start;
>> +
>> +    /* Sanitize memory map in current form. */
>> +    e820_process_entries();
>> +
>> +    /* Adjust map entries to page boundaries. */
>> +    for ( i =3D 0; i < e820_entries; i++ )
>> +    {
>> +        start =3D e820_map[i].addr;
>> +        end =3D start + e820_map[i].size;
>> +        if ( (1U << e820_map[i].type) & E820_NARROW )
>> +        {
>> +            if ( start & (PAGE_SIZE - 1) )
>> +            {
>> +                start =3D round_pgup(start);
>> +                e820_insert_entry_at(i, start - PAGE_SIZE, PAGE_SIZE,=

>> +                                     E820_TMP_RESERVED);
>> +                i++;
>> +            }
>> +            if ( end & (PAGE_SIZE - 1) )
>> +            {
>> +                end =3D round_pgdown(end);
>> +                e820_insert_entry_at(i, end, PAGE_SIZE, E820_TMP_RESE=
RVED);
>=20
> Rather i+1 so it's most probably already sorted?

Ah, yes, good catch.

>=20
> Apart from that,
>=20
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks,


Juergen


--------------851CCEB259C389291C020CC8
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------851CCEB259C389291C020CC8--

--DXQcuAgICIldR3Cl4iRbQZIN2pHSvcgAa--

--EmIQs1fIhx0bqgUGFs2mZ38AM4ITK67AQ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmHBb/IFAwAAAAAACgkQsN6d1ii/Ey8m
MAf/Sq+eUsguw/e2YhMA3eAnmtDZGTywIHkGv7qjcSCs+xcv5ChPLakkWCktuuzA+GvBpvNsYg3f
BUkf8AuvDfWdL94M+kCQqwxDkQd/2sN5u8/s3qtRPc8arLNSdNSU4qon76XKI5RAOXJuAg1XHZOR
qiL0SPg/Ggki8HaBNZkQHxRT621qsyH40uee8S8A3VG62OC0rsR3itX/hnU5WQYAS1mNcVaYsDrg
OlcsEF7jJus8zUnTOIb/l55JH3wjMiauR96NZUsOydkjbeU1Y0yLCgVGZugoYr7sdduHpAILwlnx
2TxxtF/IY7E55OcgI6bcyb1vC5AlkBBkG4YQIQZCkw==
=xlCx
-----END PGP SIGNATURE-----

--EmIQs1fIhx0bqgUGFs2mZ38AM4ITK67AQ--


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 06:17:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 06:17:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250110.430735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYSC-0007Ki-HD; Tue, 21 Dec 2021 06:16:52 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250110.430735; Tue, 21 Dec 2021 06:16:52 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYSC-0007KU-Cl; Tue, 21 Dec 2021 06:16:52 +0000
Received: by outflank-mailman (input) for mailman id 250110;
 Tue, 21 Dec 2021 06:16:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzYSB-0007K2-QJ
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 06:16:51 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 95522ac5-6225-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 07:16:50 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CE1331F388;
 Tue, 21 Dec 2021 06:16:49 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC0C213BEC;
 Tue, 21 Dec 2021 06:16:49 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id q2ugKFFxwWHPcwAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 06:16:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 95522ac5-6225-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640067409; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=FNzFSW66KymIMqXtTT0NTCRx2C1DMMVxbRTWoJaBfKk=;
	b=NYsJQNoG6eK52gLxp8R3whIsbeaLtuwhzCfrZKqGx/iQ+TzuxRNZHfGQgjLKMA/P4GYnhb
	yp4ZEjqV7FzSgosQr9dQ5/DEtl5MoffMt/i2VQ8UpUecLkvFW1NO2wF+k120e9sSBZvSxQ
	6h6qxL9XFCwO1LXA+WCRySQcvKn/kqQ=
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-5-jgross@suse.com>
 <20211220232231.sylwjfk6rsjrgeqi@begin>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up
Message-ID: <75aa6bf0-dbbc-3076-ee45-42eb0b89eeff@suse.com>
Date: Tue, 21 Dec 2021 07:16:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20211220232231.sylwjfk6rsjrgeqi@begin>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="A73FxjnSIIT9oLpEwxB9PDWIhnmEujgci"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--A73FxjnSIIT9oLpEwxB9PDWIhnmEujgci
Content-Type: multipart/mixed; boundary="ZWjDWZxF06NPOmmDPw4yOGvNfjBZravob";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
 minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, wl@xen.org
Message-ID: <75aa6bf0-dbbc-3076-ee45-42eb0b89eeff@suse.com>
Subject: Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-5-jgross@suse.com>
 <20211220232231.sylwjfk6rsjrgeqi@begin>
In-Reply-To: <20211220232231.sylwjfk6rsjrgeqi@begin>

--ZWjDWZxF06NPOmmDPw4yOGvNfjBZravob
Content-Type: multipart/mixed;
 boundary="------------CBF0F8890831CB17AA15B325"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------CBF0F8890831CB17AA15B325
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 21.12.21 00:22, Samuel Thibault wrote:
> Juergen Gross, le lun. 20 d=C3=A9c. 2021 17:07:10 +0100, a ecrit:
>> +unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned l=
ong pages)
>> +{
>> +    int i;
>> +    unsigned long end;
>> +
>> +    for ( i =3D 0; i < e820_entries && e820_map[i].addr < (pfn << PAG=
E_SHIFT);
>=20
> Shouldn't that be addr+size? Otherwise if pfn is in the middle of an
> e820 entry, we will miss picking up that.

No, we want to check all map entries starting below or at the given pfn.
The test should be "e820_map[i].addr <=3D (pfn << PAGE_SHIFT)", of course=
=2E


Juergen

--------------CBF0F8890831CB17AA15B325
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------CBF0F8890831CB17AA15B325--

--ZWjDWZxF06NPOmmDPw4yOGvNfjBZravob--

--A73FxjnSIIT9oLpEwxB9PDWIhnmEujgci
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmHBcVEFAwAAAAAACgkQsN6d1ii/Ey9t
bAf/cGtRjmjSThW9QT/JgEuMetMO6XNVQ3v7Lu6pdThHuFT5sVpVtnhBu6f83Cg/4wO3cJ5uJSjA
DMZiUUYwospX2SLsT4d446C/6XJwxrhJWahVX8a3PDABd32xZts3e8+44MnihSO0Fn42Zu9YUb8T
D1eQ/wda9dtVS2TTiBqpWi6mv2ZrVeXW8j6jeTD9gO9BXShHyVQKLjuLBH3FmbP0rsP4Y16P8c62
LPkRChWDU65l2GMVvOg+y/5JlL4doHYQ8TC77zSsOM2PbfMrRTFAzr65+g8GA2B1rsHbWWSpM0yy
iUlN0lJ74V75IbSiZVt+Ct/FDjavRYnudFJI0qipuA==
=HlF8
-----END PGP SIGNATURE-----

--A73FxjnSIIT9oLpEwxB9PDWIhnmEujgci--


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 06:47:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 06:47:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250115.430746 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYvq-0002UW-KZ; Tue, 21 Dec 2021 06:47:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250115.430746; Tue, 21 Dec 2021 06:47:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzYvq-0002UP-HT; Tue, 21 Dec 2021 06:47:30 +0000
Received: by outflank-mailman (input) for mailman id 250115;
 Tue, 21 Dec 2021 06:47:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzYvp-0002UF-Cn; Tue, 21 Dec 2021 06:47:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzYvp-0001Xh-9a; Tue, 21 Dec 2021 06:47:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzYvo-00055W-VR; Tue, 21 Dec 2021 06:47:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzYvo-0000rL-Ux; Tue, 21 Dec 2021 06:47:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kmR0exSXJvd9Qt710LJg7gZQQLYhFtsLScO2Q6LF8fM=; b=7JLalAyhApH15Ffj9e1bzA/6LL
	XjcJxTYhRlMLjEdjqsnNrq3iuXVEKICHqPDVh2WD+iSwhjoDUDN5FtcJj2cRO8cX3APa5kiV2/kY4
	ouZ4QvXpd1G7lSwArIFcPM+mWN+Nm42J2CfHkyg+FedOBJ3piSWxhtMDg/ymoGQDP158=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167496-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167496: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=c7d773ae49688463b59ade6989f8d612fecb973d
X-Osstest-Versions-That:
    qemuu=212a33d3b0c65ae2583bb1d06cb140cd0890894c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 06:47:28 +0000

flight 167496 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167496/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167489
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167489
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167489
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167489
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167489
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167489
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167489
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167489
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                c7d773ae49688463b59ade6989f8d612fecb973d
baseline version:
 qemuu                212a33d3b0c65ae2583bb1d06cb140cd0890894c

Last test of basis   167489  2021-12-20 05:08:15 Z    1 days
Testing same since   167496  2021-12-20 21:38:07 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alistair Francis <alistair.francis@wdc.com>
  Chih-Min Chao <chihmin.chao@sifive.com>
  Frank Chang <frank.chang@sifive.com>
  Greentime Hu <greentime.hu@sifive.com>
  Hsiangkai Wang <kai.wang@sifive.com>
  Jessica Clarke <jrtc27@jrtc27.com>
  Khem Raj <raj.khem@gmail.com>
  Kito Cheng <kito.cheng@sifive.com>
  LIU Zhiwei <zhiwei_liu@c-sky.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vineet Gupta <vineetg@rivosinc.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   212a33d3b0..c7d773ae49  c7d773ae49688463b59ade6989f8d612fecb973d -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 07:41:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 07:41:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250133.430757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZlp-0000dW-2j; Tue, 21 Dec 2021 07:41:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250133.430757; Tue, 21 Dec 2021 07:41:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZlo-0000dP-W3; Tue, 21 Dec 2021 07:41:12 +0000
Received: by outflank-mailman (input) for mailman id 250133;
 Tue, 21 Dec 2021 07:41:12 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzZlo-0000dJ-46
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 07:41:12 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5c7b4ae5-6231-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 08:41:08 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-36-ZIxtStJ0O-iJtLXIoYYv7g-1; Tue, 21 Dec 2021 08:41:07 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5327.eurprd04.prod.outlook.com (2603:10a6:803:5c::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec
 2021 07:41:05 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 07:41:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5c7b4ae5-6231-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640072468;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=9usykdRoXQO1uGSbny9xdOwUTo/Tr4jC9nKhpHf9XXg=;
	b=PzUlij7fyYgykjjMExd+zBrk4rMTZ5iCo+kDxAdnqu7E22lTss7CATirww6v3LC9A2ord3
	LXXAcky+7/LeSxxcNOxe/aNF7Fjirn9Y/AdFGRW3vizYiJNlHqVZBrFRZm9DrYEbwzCY0u
	rshi60Hyxvc9r/o4fqyRAOTjU7FqgaU=
X-MC-Unique: ZIxtStJ0O-iJtLXIoYYv7g-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YjyzTD/Nj/7jYvo0D22sBa/j9wC4Zeh84fARWx5Nd0u6Y6yRATeas3L+goA2qcZ9Y/QREA5ktMl2iYUPesaqe+yKXfEzmRmvZrc0YryegDN5pdMIHOO9tanX9TVu+68dI5QmGFGRXD2V9hQWGiwDsMmk20zflIYcx++uYYWL/ntSoOKdiPxzL0jLenN8uTQbhJ+UncmqC4ZSLfYzTI+uVQEV11ano7ShMurGz4Y22PXbljwvbXUcSDhqfMIMor26j4lhjz5JI04ZFR4oM3rAaM6O5R13VDQNPGGBzBGDzNeFgXaIWbPbibPAbHMwvtfnHYZy530ASjeS02o2AH474w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=9K4UkWZnKmr9KTc31uN5UUJeW/WCYCCoenL8wr4Yyfg=;
 b=lmidurWeC9nYn6MXik3eyyt+rbeh2dDp6FikH2xL+fyfSBvQyVLOXGIdI6hOEigqksLl+hwW4D/700vU+5QAFqYjlx1zJF6d8jQsigz4vdPRSt/6vA4HoNMoDSmxSZEYdNloEkpU9+4cQX0obLH1HU9S6tX0Dh5qUWhyAZiDkP+WTlqU02xcquWA5stZhYoo4rnDRv9b+OPUtnJL5nYXhVeMqane8QV9cmYejR0AB0+m2UiHnmZnJQjEVZnc8z782ZSm0ZQVG7dqLELu1rUBtmU5OmrSLnYU2cyM+TwHnBw1zIYF3yZRn4DrH5VLysX7832CZVRrFu6TvEwecE1zJQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <26968841-9b8a-757a-b9af-ba34a20fe576@suse.com>
Date: Tue, 21 Dec 2021 08:41:06 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Rahul Singh <Rahul.Singh@arm.com>
CC: xen-devel <xen-devel@lists.xenproject.org>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
 <YbscoZG/NRP6lMof@Air-de-Roger>
 <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
 <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM
 (2603:10a6:d10:15::6) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e1879cfe-32e7-4339-b66f-08d9c4553eb4
X-MS-TrafficTypeDiagnostic: VI1PR04MB5327:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5327840B76E0E4EC6548E3CBB37C9@VI1PR04MB5327.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Sehk1LHYz3Dqa71GNS/AGGjZrhma9yIdnIz6ww5GavvDGAuO21clkBZ09WknxUiHsKIqeWHZn5h9MmSltN26F9xgwRnsVRFacOvTSer93Qw+TAdCuxx8D//iNr6kn8YYzUcWJ4sQyMqYkJIUV6LxT5pSvvukdptGLiHZvie3HUHmmcW3ql+xzs8zqS4+D9t828ACc/1hvZ9Mw1vjKm3VsUKtkqv7eulBGHEDLyzWEVxlgeKgzJSYqlv2u7ZgCAgS0FoQ7bcMUqgi5TQ6dvrDTvjXj0mqEJTzRIQOG5AjjV5V1CCrvpXd5dP6cFue+mHbJ7zsX5q0deoRLqISS0xoYCIStijpRZlwGunjj45BQEbx+vcta6SvwC58/Fj/cl8I4I1YD7uD8A2Epws0r1bjBCB0hpZSlYNEucSGg9m9nl0I7s2HcwxotX1PTVjG+FNxNBwYTYTNR2m4aPlS+vIZuruhUhc6Bs7kpbF7O8J4Ce6fw1wUntPnZkXpHhfNX/pxY9DyuFiRPYEskzYy9GLXXHtp/BNV1Ci65w0BlLintHySMj1B7NjVnmDVIkcInV7ZFFpDCffrCFs5b06cw1b6fZwCvYHqBL4dRcwUUK+X0or7+sjfxFgnMjfLYDG5S4Cg3rXQZee/osA0WkltCRUAfrAT9vhQQ9HYLhGP/jrNqzdyZPXtE7yutu2GjnnW4/igjPYUvDH+vUVKZAcoxOsrErmVJxEw3bkiSbSMkE7P4YnZ69i2iTKl0yj1laN7RxVR
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(66946007)(8936002)(36756003)(6512007)(53546011)(86362001)(508600001)(31686004)(5660300002)(6506007)(110136005)(2906002)(316002)(6486002)(8676002)(38100700002)(186003)(54906003)(83380400001)(26005)(2616005)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iaiJGbuw0zrZ+n/0Cd+7TgQYVmW969KkHnyvr2yVoRFDfLN1F8QWGoItPsmx?=
 =?us-ascii?Q?9UYBAzMCvxclKPoUL2r9ncAHvWFe4yRfqKs6ELDYp/HvXkoQ/UKgkvxDZUWV?=
 =?us-ascii?Q?fkT57YUO+APV8BJ/8ymjI2/KVrjBb6bg0zs3XDTrigNkrCuANW8bFS5Cf19X?=
 =?us-ascii?Q?wcFqabCX9ILg/wTwwVyIqJ6NiIP11yPNZstUcy9IpSp/MxDV0xHbnkNCkEL/?=
 =?us-ascii?Q?bDb/5iv5JEKad7aLnaBSUBeLXLIkv2CzlUGg6rolmgitZfoeT0a9XZxmPwek?=
 =?us-ascii?Q?Ml+m2RLf6Pv0XxoidiRx1/K4/pwRxEnvBqQ1ogf2IqnmWwcGMBKdZz/PvQEv?=
 =?us-ascii?Q?/hqFJIvBsZH0Vu3vKLbCe49oMMoxBcn18XEL88GfAD6mMISKePQ8V8W1zCvH?=
 =?us-ascii?Q?6B/eMl9ljvMAq91x1JXaaSMJMadNOooNiTVu3skM7ysBFVfE7KBHAfEykZMv?=
 =?us-ascii?Q?mar1uBailf6etxXYa7CmPUTJoqTWiceNBgWz1ernRf75eYU2ntIqMfiwHRGo?=
 =?us-ascii?Q?pPiRPh/09o3tHwyomyc2XbdrHCaGtFMulaqZWiHNJKBB4ucxSCf3HWsdeeCe?=
 =?us-ascii?Q?Ig9qcS8z1YPxfvjAyZFWIbFoIouMEYqOfk8lLdQd2O8MY+vyh8STHrFB4EKj?=
 =?us-ascii?Q?L8nD0wYtv6VoXY4FL/7mGVKXNBuDczJKifeqrme4XenTm9rIFSZIp9cq/IrT?=
 =?us-ascii?Q?liI1K8AsCUvt0ROskwbZqp0NvduukiWbEG2PhrwX9vmW9Gu/cxMH8KSExQl5?=
 =?us-ascii?Q?3RCexRMOlKH6QhMxGDOWtGjDnW1NCTbAcQ9BDH2+4YbfOMSVMU4BMUGGX2La?=
 =?us-ascii?Q?hpFwQtWv+jewIELfXEAUR8kQZ/c3Snym055iEU0nkmzNMmYRsO4T/6x6PCTw?=
 =?us-ascii?Q?VgwB50DlJI45KS0FUKlvoRcwO7I3ZLXGxgubVS7uYcEDuHLKXlPZkr6UPkG7?=
 =?us-ascii?Q?XMWQAObFXoVwa+0OgrOJVlLucdbLgfr6JbV982YDhBqa+qIseG5N93vleGI4?=
 =?us-ascii?Q?BBb7LnGugXOoOoRfoTBMKBfzm90cA9LGpAfcZcmu6qvrfeC2ZfswxRZoQjJY?=
 =?us-ascii?Q?LuKA990AMad8ox+mK4luk3jXHd34lLkMmsPheUBhus4ue2PLkIedKwTU4AZ/?=
 =?us-ascii?Q?kBD4oOsljbyQbulNHPiwt/pYUsSXeYWqfP0ifAtfnkULmQMJFUVf843m1M3r?=
 =?us-ascii?Q?onYKxT6GreWDX3wlYd64rrNwMxBmMZZPkaFm687//j446IKZZ2eAcbtxOPDB?=
 =?us-ascii?Q?bw90ahIey2MGIJElejCWtDoMo4+q+BzY/M23MVvVXlIeWQYTmiYMehhQO3Xm?=
 =?us-ascii?Q?nw245dSNfxnVYa0T+QprZKSxJxksQuOp7y1hkvKZeOIcYWPCTPMJml+0V+AT?=
 =?us-ascii?Q?qPvuHawGU8Zh4GgFc44vfVAosDE1vCvAJ46cq6TF2bDnIaC2GY9nZ+btnK2f?=
 =?us-ascii?Q?KZyXMmIy/wrrdVe4u7qLIGROXrc1k4xRTyqqZC5FFRJNC4EbLWbsytriyfA9?=
 =?us-ascii?Q?HqjMWr/BVYNil0cv1H8NjIMkH7aU4BQ/cVEkXRyugxeou7IFw0CNR6yfEfg3?=
 =?us-ascii?Q?whz/9jH2LZCjAdLjNod0AsXBmNS4Uc/uHOGTiIXdTHbKc5SkCd+va5dgXr1W?=
 =?us-ascii?Q?cvEeGVUjMSTKHS3l9ddPo4g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1879cfe-32e7-4339-b66f-08d9c4553eb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 07:41:05.4519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GeZDns/3Q0XcrMoGsRJ2BXRP49zNKxiqAyd/R3JhQv98fHUj06Io4EfGKwa3NCIqegHov+5zUPwmaxkCSb8ZKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5327

On 17.12.2021 15:32, Julien Grall wrote:
> On 16/12/2021 13:37, Jan Beulich wrote:
>> On 16.12.2021 12:01, Roger Pau Monn=C3=A9 wrote:
>>> On Thu, Dec 16, 2021 at 10:18:32AM +0000, Rahul Singh wrote:
>>>>> On 14 Dec 2021, at 12:37 pm, Roger Pau Monn=C3=A9 <roger.pau@citrix.c=
om> wrote:
>>>>> On Tue, Dec 14, 2021 at 10:45:17AM +0000, Rahul Singh wrote:
>>>>>> +              unsigned long *data)
>>>>>> {
>>>>>> -    const struct domain *d =3D v->domain;
>>>>>> -    struct vpci_msix *msix =3D msix_find(d, addr);
>>>>>>      const struct vpci_msix_entry *entry;
>>>>>>      unsigned int offset;
>>>>>>
>>>>>>      *data =3D ~0ul;
>>>>>>
>>>>>>      if ( !msix )
>>>>>> -        return X86EMUL_RETRY;
>>>>>> +        return VPCI_EMUL_RETRY;
>>>>>>
>>>>>>      if ( !access_allowed(msix->pdev, addr, len) )
>>>>>> -        return X86EMUL_OKAY;
>>>>>> +        return VPCI_EMUL_OKAY;
>>>>>>
>>>>>>      if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA)=
 )
>>>>>>      {
>>>>>> @@ -210,11 +194,11 @@ static int msix_read(struct vcpu *v, unsigned =
long addr, unsigned int len,
>>>>>>          switch ( len )
>>>>>>          {
>>>>>>          case 4:
>>>>>> -            *data =3D readl(addr);
>>>>>> +            *data =3D vpci_arch_readl(addr);
>>>>>
>>>>> Why do you need a vpci wrapper around the read/write handlers? AFAICT
>>>>> arm64 also has {read,write}{l,q}. And you likely want to protect the
>>>>> 64bit read with CONFIG_64BIT if this code is to be made available to
>>>>> arm32.
>>>>
>>>> I need the wrapper because {read,write}{l,q} function argument is diff=
erent for ARM and x86.
>>>> ARM {read,wrie}(l,q}  function argument is pointer to the address wher=
eas X86  {read,wrie}(l,q}
>>>> function argument is address itself.
>>>
>>> Oh, that's a shame. I don't think there's a need to tag those helpers
>>> with the vpci_ prefix though. Could we maybe introduce
>>> bus_{read,write}{b,w,l,q} helpers that take the same parameters on all
>>> arches?
>>>
>>> It would be even better to fix the current ones so they take the same
>>> parameters on x86 and Arm, but that would mean changing all the call
>>> places in one of the arches.
>>
>> Yet still: +1 for removing the extra level of indirection. Imo these
>> trivial helpers should never have diverged between arches; I have
>> always been under the impression that on Linux they can be used by
>> arch-independent code (or else drivers would be quite hard to write).
>=20
> So technically both helpers are able to cope with pointer. The x86 one=20
> is also allowing to pass an address.
>=20
>  From a brief look at the x86, it looks like most of the users are using=
=20
> a pointer. However, the vPCI msix code is one example where addresses=20
> are passed.

Okay, first of all I need to clean up some confusion cause by Rahul
saying "pointer to the address": That's where my "extra level of
indirection" came from. I would really wish one wouldn't need to go
to the code and verify such basic statements. There's no "pointer
to the address" here. The question is whether the argument has to
be a pointer (Arm) or is convertable to a pointer (x86). Therefore
...

> AFAICT, the read*/write* helpers on Linux only works with pointers. So I=
=20
> think the actions should be:
>     1) Modify the vPCI MSIx code to use pointer
>     2) Modify the x86 read*/write* helpers to forbid any access other=20
> than pointer.

... I'd suggest to go with 1), to avoid impacting other x86 code.
Longer term I wouldn't mind switching to 2) (unless vPCI really is
the only place using non-pointer arguments, in which case doing
the 2nd step right away [but still in a separate patch] would seem
quite reasonable).

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 07:46:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 07:46:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250137.430768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZqS-0001Gr-M9; Tue, 21 Dec 2021 07:46:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250137.430768; Tue, 21 Dec 2021 07:46:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZqS-0001Gk-IV; Tue, 21 Dec 2021 07:46:00 +0000
Received: by outflank-mailman (input) for mailman id 250137;
 Tue, 21 Dec 2021 07:45:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzZqR-0001Ge-77
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 07:45:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 089ffcf0-6232-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 08:45:57 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 1F7821F388;
 Tue, 21 Dec 2021 07:45:57 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE4C813BF5;
 Tue, 21 Dec 2021 07:45:56 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id OwewLDSGwWHOFQAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 07:45:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 089ffcf0-6232-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640072757; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CHsRf17HbPKJY6ElZfkaQJwYeHPowQ/vMkkN3YgQKiA=;
	b=CPpBtdKi+XAZJqacxy265PP160RhhEntDH124UJbPAc7/VoZvVsw1YSqdTMGd4bcCtVvgn
	vbH0uda+NxR9RiQtEctc3Rfe8p8oqsQWCUXI/Mu469YsV3ntX40xgXPcG9ggLb5wQRzljn
	oLjlXuZNAujD6YkCjaeeqeZZpS1vLzg=
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
 <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
 <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
 <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
Message-ID: <0d7f817a-d012-cbff-8179-6926dffa2352@suse.com>
Date: Tue, 21 Dec 2021 08:45:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="dpsbTPj6pO0dsG3GLmusSR9yDEafRRHc2"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--dpsbTPj6pO0dsG3GLmusSR9yDEafRRHc2
Content-Type: multipart/mixed; boundary="RTSx3k2yb6Wdtul4HCceRWWlodza2SFKv";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>
Message-ID: <0d7f817a-d012-cbff-8179-6926dffa2352@suse.com>
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
 <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
 <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
 <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
In-Reply-To: <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>

--RTSx3k2yb6Wdtul4HCceRWWlodza2SFKv
Content-Type: multipart/mixed;
 boundary="------------DC0952C2BE512107D04003DA"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------DC0952C2BE512107D04003DA
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 20.12.21 18:14, Julien Grall wrote:
> Hi,
>=20
> On 18/12/2021 00:00, Stefano Stabellini wrote:
>> On Fri, 17 Dec 2021, Juergen Gross wrote:
>>> On 17.12.21 11:41, Julien Grall wrote:
>>>> Hi Juergen,
>>>>
>>>> On 17/12/2021 08:50, Juergen Gross wrote:
>>>>> On 17.12.21 08:45, Jan Beulich wrote:
>>>>>> On 17.12.2021 06:34, Juergen Gross wrote:
>>>>>>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>>>>>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>>>>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>>>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is
>>>>>>>>>>> not a
>>>>>>>>>>> problem in reality because the max physical address size is
>>>>>>>>>>> only 40-bit
>>>>>>>>>>> for aarch32 guests, so 32-bit are always enough to return the=

>>>>>>>>>>> highest
>>>>>>>>>>> page in memory for 32-bit guests.
>>>>>>>>>>
>>>>>>>>>> You are aware that this isn't the guest's max page, but the
>>>>>>>>>> host's?
>>>>>>>>
>>>>>>>> I can see now that you meant to say that, no matter what is the =
max
>>>>>>>> pseudo-physical address supported by the VM,=20
>>>>>>>> XENMEM_maximum_ram_page
>>>>>>>> is
>>>>>>>> supposed to return the max memory page, which could go above the=

>>>>>>>> addressibility limit of the VM.
>>>>>>>>
>>>>>>>> So XENMEM_maximum_ram_page should potentially be able to return
>>>>>>>> (1<<44)
>>>>>>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>>>>>>
>>>>>>>> I would imagine it could be useful if dom0 is 32-bit but domUs a=
re
>>>>>>>> 64-bit on a 64-bit hypervisor (which I think it would be a very =

>>>>>>>> rare
>>>>>>>> configuration on ARM.)
>>>>>>>>
>>>>>>>> Then it looks like XENMEM_maximum_ram_page needs to be able to
>>>>>>>> return a
>>>>>>>> value > 32-bit when called by a 32-bit guest.
>>>>>>>>
>>>>>>>> The hypercall ABI follows the ARM C calling convention, so a 64-=
bit
>>>>>>>> value should be returned using r0 and r1. But looking at
>>>>>>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever =

>>>>>>>> sets
>>>>>>>> r1
>>>>>>>> today. Only r0 is set, so effectively we only support 32-bit ret=
urn
>>>>>>>> values on aarch32 and for aarch32 guests.
>>>>>>>>
>>>>>>>> In other words, today all hypercalls on ARM return 64-bit to 64-=
bit
>>>>>>>> guests and 32-bit to 32-bit guests. Which in the case of memory_=
op
>>>>>>>> is
>>>>>>>> "technically" the correct thing to do because it matches the C
>>>>>>>> declaration in xen/include/xen/hypercall.h:
>>>>>>>>
>>>>>>>> extern long
>>>>>>>> do_memory_op(
>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long cmd,
>>>>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 XEN_GUEST_HANDLE_PARAM(void=
) arg);
>>>>>>>>
>>>>>>>> So...=C2=A0 I guess the conclusion is that on ARM do_memory_op s=
hould
>>>>>>>> return
>>>>>>>> "long" although it is not actually enough for a correct
>>>>>>>> implementation
>>>>>>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>>>>>>
>>>>>>>
>>>>>>> Hence my suggestion to check the return value of _all_ hypercalls=
 to
>>>>>>> be
>>>>>>> proper sign extended int values for 32-bit guests. This would fix=
=20
>>>>>>> all
>>>>>>> potential issues without silently returning truncated values.
>>>>>>
>>>>>> Are we absolutely certain we have no other paths left where a=20
>>>>>> possibly
>>>>>> large unsigned values might be returned? In fact while
>>>>>> compat_memory_op() does the necessary saturation, I've never been =

>>>>>> fully
>>>>>> convinced of this being the best way of dealing with things. The=20
>>>>>> range
>>>>>> of error indicators is much smaller than [-INT_MIN,-1], so almost
>>>>>> double the range of effectively unsigned values could be passed ba=
ck
>>>>>> fine. (Obviously we can't change existing interfaces, so this mem-=
op
>>>>>> will need to remain as is.)
>>>>>
>>>>> In fact libxenctrl tries do deal with this fact by wrapping a=20
>>>>> memory_op
>>>>> for a 32-bit environment into a multicall. This will work fine for =
a
>>>>> 32-bit Arm guest, as xen_ulong_t is a uint64 there.
>>>>>
>>>>> So do_memory_op should return long on Arm, yes. OTOH doing so will
>>>>> continue to be a problem in case a 32-bit guest doesn't use the
>>>>> multicall technique for handling possible 64-bit return values.
>>>>>
>>>>> So I continue to argue that on Arm the return value of a hypercall
>>>>> should be tested to fit into 32 bits.
>>>>
>>>> It would make sense. But what would you return if the value doesn't =

>>>> fit?
>>>
>>> I guess some errno value would be appropriate, like -EDOM, -ERANGE or=

>>> -E2BIG.
>>
>> This seems to be better than the alternative below as it is a lot
>> simpler.
>=20
> We would still need to special case XENMEM_maximum_reservation (or=20
> rework the implementation of the sub-op) because the value returned is =

> an unsigned long. So technically, the unsigned value for -EDOM & co=20
> could be interpreted as the maximum host frame number.

I guess you meant XENMEM_maximum_ram_page.

What about setting -EDOM only if the high 32 bits are not all the same?
This would mean to clamp the highest RAM page to -EDOM in case the
caller is interpreting it as an unsigned value. This would still be
better than silently dropping the high bits, which could lead to a
rather low page number instead.

> I also would like to see the hypercall returning 'int' when they are=20
> only meant to return 32-bit value. This will make easier to spot someon=
e=20
> that decide to return a 64-bit value.

I guess this would need to include all hypercalls handled in common
code?

>>>>> The only really clean alternative
>>>>> would be to have separate hypercall function classes for Arm 32- an=
d
>>>>> 64-bit guests (which still could share most of the functions by=20
>>>>> letting
>>>>> those return "int"). This would allow to use the 64-bit variant=20
>>>>> even for
>>>>> 32-bit guests in multicall (fine as the return field is 64-bit wide=
),
>>>>> and a probably saturating compat version for the 32-bit guest direc=
t
>>>>> hypercall.
>>>>
>>>> I am not entirely sure to understand this proposal. Can you clarify =
it?
>>>
>>> 1. In patch 5 modify the hypercall table by adding another column, so=

>>> =C2=A0=C2=A0=C2=A0 instead of:
>>> =C2=A0=C2=A0=C2=A0 +table:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 pv32=C2=A0=C2=A0=C2=A0=C2=A0 pv64=C2=A0=C2=A0=C2=A0=C2=A0=
 hvm32=C2=A0=C2=A0=C2=A0 hvm64=C2=A0=C2=A0=C2=A0 arm
>>> =C2=A0=C2=A0=C2=A0 use:
>>> =C2=A0=C2=A0=C2=A0 +table:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 pv32=C2=A0=C2=A0=C2=A0=C2=A0 pv64=C2=A0=C2=A0=C2=A0=C2=A0=
 hvm32=C2=A0=C2=A0=C2=A0 hvm64=C2=A0=C2=A0=C2=A0 arm32=C2=A0=C2=A0=C2=A0 =
arm64
>>>
>>> 2. Let most of the hypercalls just return int instead of long:
>>> =C2=A0=C2=A0=C2=A0 +rettype: do int
>>>
>>> 3. Have an explicit 64-bit variant of memory_op (the 32-bit one is th=
e
>>> =C2=A0=C2=A0=C2=A0 compat variant existing already):
>>> =C2=A0=C2=A0=C2=A0 +rettype: do64 long
>>> =C2=A0=C2=A0=C2=A0 +prefix: do64 PREFIX_hvm
>>> =C2=A0=C2=A0=C2=A0 +memory_op(unsigned long cmd, void *arg)
>>>
>>> 4. Use the appropriate calls in each column:
>>> =C2=A0=C2=A0=C2=A0 +memory_op=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 compat=C2=A0=C2=A0 do64=C2=A0=C2=A0=C2=A0=C2=A0 hvm=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 hvm=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compat=C2=A0 do64
>>>
>>> 5. In the Arm hypercall trap handler do:
>>> =C2=A0=C2=A0=C2=A0 if ( is_32bit_domain(current->domain) )
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 call_handlers_arm32(...);
>>> =C2=A0=C2=A0=C2=A0 else
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 call_handlers_arm64(...);
>>>
>>> 6. In the multicall handler always do:
>>> =C2=A0=C2=A0=C2=A0 call_handlers_arm64(...);
> I am probably missing something. But why do we need to have separate=20
> call handlers for arm32/arm64?

How else could you have different functions called for 32- and 64-bit
guests (other than doing the distinction in the called functions)?


Juergen

--------------DC0952C2BE512107D04003DA
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------DC0952C2BE512107D04003DA--

--RTSx3k2yb6Wdtul4HCceRWWlodza2SFKv--

--dpsbTPj6pO0dsG3GLmusSR9yDEafRRHc2
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmHBhjQFAwAAAAAACgkQsN6d1ii/Ey8m
Mwf9EF9/U8DR7ei13IImZcqai+iEQkSUI5SLtt28qacsZdlEUkt6QWZzQsEvXskRPEppprY9ll6V
bEshtzHffCbc63ijBZwa9FSTCCIBvrdc5QjHc2N+rgfAuw6T/LmmODLnwJ/yQLQwbriiVVVnb6D5
jRfqoPG2D3N6bfOykKw1jDkZCYfWPknOFfS++GgezwTKpE5MwR5n9T28zzTTcqRy+k7I8BkEA+ur
vbwVt65Av/LqtUh9huz3/4WEt6IompuUZftgiZhna5iQBLNBJMJS7tLFwT/DmR2I2HQufyuk6rIg
NMJFHF0RHDsDfdHdJCgbYNRAFA4RSQICfccYcRLC+w==
=Vh3c
-----END PGP SIGNATURE-----

--dpsbTPj6pO0dsG3GLmusSR9yDEafRRHc2--


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 07:52:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 07:52:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250145.430779 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZwt-0002rx-Iq; Tue, 21 Dec 2021 07:52:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250145.430779; Tue, 21 Dec 2021 07:52:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZwt-0002rq-F8; Tue, 21 Dec 2021 07:52:39 +0000
Received: by outflank-mailman (input) for mailman id 250145;
 Tue, 21 Dec 2021 07:52:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzZws-0002rk-7U
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 07:52:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6a87983-6232-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 08:52:37 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2052.outbound.protection.outlook.com [104.47.1.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-NUO1LPJ5Phi8rrmVk2wfTA-1; Tue, 21 Dec 2021 08:52:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4607.eurprd04.prod.outlook.com (2603:10a6:803:71::22)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec
 2021 07:52:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 07:52:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6a87983-6232-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640073156;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=i6iY/U+eMABdBoU+mmg32NgkN2+1J/QmjuQwr1r5zNM=;
	b=i5DedrT8g5aZD1B33QvDYhoUuNdc3jdvwRhVWvLNdWSHCVhH9Ugxt83wMXRZ6AslNaN1eu
	Pf42+BFaQC3TXzxBQuEgvsyQSATfzmiUDfrarHjX9rvATa0YNaIBV3Lwv4/gbUqXdymBxk
	x9w8lrdUtoPia/gSBOMfxCtel8t2DAg=
X-MC-Unique: NUO1LPJ5Phi8rrmVk2wfTA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=aQE2x6RMjRJMU07SvqCYXpKS3obo1KgZAtiSzuYcr79LJi9XmrMUz1pXa7aKLdiC0lCIPnsn5IKJntW2t5ESFxNBImZMeMwv9BT3z3B+geyjNVZWoW75IpwlkEjydXLlqdDJAIzdJi7QPdoA+T7fk4Ubla1a/Py07Dj+ubGUVI3ZOHxd0W00HkSO90O3biRjKgAR8Qm6E/TlxSHT9Oa5M3v4BQHbtaAU0fHehkbLXR3QVcvP3LkUdi2nIi/HEmDqo5ZUCdJzDnY3zDKXbP4hx9JwgJxXANF6moSpf3IT1Ko3H/Ft899e1dUC4Kx9Pe2ovfNkwleD3/fLUXnX0HHKWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QzGtaXMffeM96mOfrvw56JTznPM/wBt/181aCM3NtHQ=;
 b=dTHnAdoj1yfxdRi45XtqtrrwIAsruBa8TE5z+N3S5vTZnzasslZmB3dauMFxYbwqvsFHMgK++7DUvYrt4nc2EFnMmrT7lLDmGwq+0VRevTPPCSY4ytdigbPsYyxMHhRbLj2GOafq0gCnfTcpy+w/K2BnKrG2nKQK+N6ZMUhfri91DLPEc47AbmV4Y4SjHQmxsAWQXMPbChSw7j0OEqQxteEHJnKaFItwUKkiozjo60dhzLCAS1Pqh6ybzaG77XCU5xB83rPiAZy2oZGv9XENkb+nKsOz4GeXkywEjCveFeu1yJagXFbOZOV9wuRXbX0d4x8jo3OqLIaBHvzFDJ5shg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <c814cb4e-7e50-c03a-5c65-89a7aeea4f98@suse.com>
Date: Tue, 21 Dec 2021 08:52:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 4/5] SVM: sync VM-exit perf counters with known VM-exit
 reasons
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <c94bc336-fdee-43af-540e-06e0904d8db7@suse.com>
 <60deae51-6ccd-dd90-869a-db6099e21002@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <60deae51-6ccd-dd90-869a-db6099e21002@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8P189CA0001.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71dd8d1d-0694-43a8-2165-08d9c456d8bf
X-MS-TrafficTypeDiagnostic: VI1PR04MB4607:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB46078E4DD670A8D3CD313256B37C9@VI1PR04MB4607.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2089;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	BDZo+cjkycLOqf/VpPKKrKMAwMHCOlXaIa949Ef5GeRF0wiHU5bEBrAZnn6RJz9WSx+SX8qgGqJjB3zc7DvGUMyB6Qk+ZWWXeW5nHb3MS44yGVcSE79ElllwSWqBGVz3gAkzSKRXo/yR7xv5VYy+LDNgkBROmH7GgLok2dZHd0iDSP6+EzBkBay/+mJ7uNfSF+oQaakOftVPIEg0asZe4FAwS98h34K76x3MTnT9Whdkr00PLTRxXK73vDDfJ8vn5YqB01v+NBoDEwd3KnRUXonZU9I+9Xg1DqQgKm45zj2ruymIj7MLK5RdLj2brRynbNswqFZfrmzV8jaTZR5rVa+BP9i1FOR+e8jamo3Jd0GFIZNjC911dLgzHPWKHbQ2rNZfHe8szRhc1/M6THOoBEbwPZr8XG//joqb63SYWyGSN2n89m3TiZJcN+J/Bioc4kU6ZBcYYb1Cf+wZghn1e56fWsLnKyz6VsldeTL4GJ8Q+/WFf+fo1Zra4cloxTv1wx/4JhP6P4b6CrMEol0ljid89OHdrZDyacsgTM55It4Ka7qFzQP8zDg/VkQVM+wbXG3s58piDVeR+XCPdioaCjZ4vuMmmnrsCn3dUaU1pGaH5dSTGj5X+f6XDzaINVI+zacvxOV2TfAvgHz2//SPki8gtWWuDPxLSDpLBzDOM53yBtKWmvS2c/ZTdiPlCzHTTR7LelGP9auvO5T3xjehdi4l7UeRZJKM2FSCkL0BogT9hBSeJuEBIguJJdW24VpK
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(31696002)(8936002)(26005)(186003)(5660300002)(2616005)(6486002)(8676002)(53546011)(6506007)(6512007)(110136005)(2906002)(316002)(66556008)(54906003)(4326008)(36756003)(66476007)(38100700002)(31686004)(86362001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?J93dBfRuSWU747gMYzuqE+RkIMh+yDK94ow+ReLFk8wA7SvgAb6fLVyVXlv4?=
 =?us-ascii?Q?vSWzG5RP6g3x5NmeGDmBetGtUThEQQJBBaOhGGRZ5FFqQVmVPHg/EScGwudz?=
 =?us-ascii?Q?sP7texpvL7Rda5dMx4fdZ6br2RNLO4nqMO4eRxBKQSHFXEiDuh/ct9t/ELDg?=
 =?us-ascii?Q?Tq/jlJwIWGow3AUmPBVl35Oo5VQqthxu1aebM7F9uxTLv2h8L/LPQ2/cMTFk?=
 =?us-ascii?Q?0iWreHV2LLmw1rwLHZybzlOzaxEgMGy6lEsOy53Is/VrqyCpug1cAXWtxY0G?=
 =?us-ascii?Q?cKWLcRZ+r7FU/FN6AwatyVnFGMGPVqsjFyS30f/5rRXwP7xMgggHourD6kNU?=
 =?us-ascii?Q?tcFaty153N6/SE8s2nSvKMjuffAoZ8RbSglN+jseOwwIhxtLhZAyoJ4HOPVb?=
 =?us-ascii?Q?ZNcJY5rLMGWUySMUsmwHwG6Evd60Ep84vbQKZit4XNREJVni2BtidmekxckL?=
 =?us-ascii?Q?TeepwDNfpPwRge308X3xL28cULAUIjqJKl8QPoZzRiAmtKs8EXCSiV+sFtEf?=
 =?us-ascii?Q?bwegfHFsNqpWpaSeGJSWmA0KjFNwQE1rcj41lg8Hfx3W2iBTmoP8eP4Sm48a?=
 =?us-ascii?Q?Jh/+Y0Y987LX5VVvMIlEo42Ds6s2H79jz79hmszQwRAQASieaYu2Bquda3pm?=
 =?us-ascii?Q?UabpuwLACL+uN5SP9iyGLfpTil9lIbL1BmXUVOk3/KpQpGV2M1qmSHM57zox?=
 =?us-ascii?Q?Hjl0+ClTYAnruGNRAnEoJQ+3FVL8/TGoH6/pf4vkoN1hH4E5l/G5ZXBh+IXG?=
 =?us-ascii?Q?LZrWvpJnHiilF3PgiPjOHhCt1rtA08W5jd50sFpSFJxo4VV+rCAhqqgnhEzg?=
 =?us-ascii?Q?F3q6vP4TKvxY/U9WC84lD4B7Cbyy9+xjIUo90UtgWdbnGstGRvarLKG9l7C/?=
 =?us-ascii?Q?Iy4koE+ZKmUqDJ2eRxM7w8yFsqKMTTbJXFSQ7n4pDLMU8HWXksrl0eJE6Qvx?=
 =?us-ascii?Q?gWca7846vgYXRfulLkWPPnZKsF3owd7w06HCV+AfbeSyhs3Ys4TQDZvEVi7+?=
 =?us-ascii?Q?I58fAa/KCZUdO6nRVU+O3w4Lh9Z3Rjh+WldFFXTKzmB7EAsnhSyLMbGFX+ng?=
 =?us-ascii?Q?Mfz4c005WDkFxO9FxkvGu2+8uKg4rS0sGoyhShE4tkp5KPizF8Jzf6aR9qwo?=
 =?us-ascii?Q?wu1BWfkUI6L6GHC1G2tjda7LvucEd48fB36kzEMa/uiqe6/4g6d0YlazB9Xx?=
 =?us-ascii?Q?f3zV+uJw86vxzC0YHPwiPz6svWqTcw/1j4P4XJOeAJTIFXXFXXEjRg+CgzYT?=
 =?us-ascii?Q?+qpX018HGqD1wcecTh+1YblWRjTiCtNQiCtVZK2yuDemi9iiuiTAaEnGz1Ns?=
 =?us-ascii?Q?KAJ1RIK8kdJ1Y7jKJYFst/QptsOdy2F4rz5iFGm2B4VTSk37z6B6Tt8qonhr?=
 =?us-ascii?Q?18m6mcar5dCnUrCukh7z1sFvGGmEYcA7lp1M5biUbdmR4R4sjiXytb2NpYiS?=
 =?us-ascii?Q?zFYuzM/B3qdfCT4BusJxrKufKPFHD/WC3JDiYuKozMeELlvF+uTzXNc0OsrH?=
 =?us-ascii?Q?MxCV0hFZJEyATa2l0TNx0HRpx9HOS/FB4qvSRkWcMG8RpnwVYyWueSRu4v+U?=
 =?us-ascii?Q?2NMuzk7xN5SRKls3KSM9Q55LXrMg7dkhtWK4ph/ZtRpBf1c4HbjZRFqO3tXZ?=
 =?us-ascii?Q?lWliPh6huNTAdSHnyOlpErU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71dd8d1d-0694-43a8-2165-08d9c456d8bf
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 07:52:33.3561
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6bqOWYIoLurqLN3q/qV7gPY2BwcwWvDgrKhTuLS9H0h7ws28BuXh5WsdIm2PJKrx7T8QX/T8RI0Z6fTOlNeH4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4607

On 17.12.2021 16:02, Andrew Cooper wrote:
> On 03/12/2021 12:06, Jan Beulich wrote:
>> This has gone out of sync over time, resulting in NPF and XSETBV exits
>> incrementing the same counter. Introduce a simplistic mechanism to
>> hopefully keep things in better sync going forward.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Given their large (and growing) number, I wonder whether we shouldn't
>> fold "SVMexits" and "vmexits". They can't both be active at the same
>> time.
>=20
> Oh yeah - that's just silly having them split like this, especially as
> there's no associated element name.

Okay, will do. Albeit I was thinking to add naming to xenperf ...

>> --- a/xen/include/asm-x86/perfc_defn.h
>> +++ b/xen/include/asm-x86/perfc_defn.h
>> @@ -11,8 +11,8 @@ PERFCOUNTER_ARRAY(exceptions,
>>  PERFCOUNTER_ARRAY(vmexits,              "vmexits", VMX_PERF_EXIT_REASON=
_SIZE)
>>  PERFCOUNTER_ARRAY(cause_vector,         "cause vector", VMX_PERF_VECTOR=
_SIZE)
>> =20
>> -#define VMEXIT_NPF_PERFC 141
>> -#define SVM_PERF_EXIT_REASON_SIZE (1+141)
>> +#define VMEXIT_NPF_PERFC 143
>> +#define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1)
>=20
> How does this work in the first place?=C2=A0 perfc_incra() is still passe=
d 1024.

In

    case VMEXIT_NPF:
        perfc_incra(svmexits, VMEXIT_NPF_PERFC);

I don't see any use of 1024. And the earlier blanket

    perfc_incra(svmexits, exit_reason);

doesn't do anything afaict, due to how perfc_incra() works.

> Furthermore, it's already worse than this.
>=20
> 401/402 are AVIC exits, and 403 is an SEV exit.

In which way is this "worse"? We don't support either AVIC or SEV (which
is a shame in particular for the former, but what do you do with vendors
having given up all engagement).

>=C2=A0 We've also gained -2 as "busy" for transient SEV events too.

I'm sorry, I'm not enough up to speed with SEV yet to even vaguely know
what you're referring to here.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 07:55:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 07:55:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250149.430790 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZzh-0003TA-0T; Tue, 21 Dec 2021 07:55:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250149.430790; Tue, 21 Dec 2021 07:55:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzZzg-0003T3-S0; Tue, 21 Dec 2021 07:55:32 +0000
Received: by outflank-mailman (input) for mailman id 250149;
 Tue, 21 Dec 2021 07:55:31 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzZzf-0003Su-H8
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 07:55:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5e292ac8-6233-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 08:55:30 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2052.outbound.protection.outlook.com [104.47.0.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-25-7Z6sZh2gPSKMXl-4YP0MFw-1; Tue, 21 Dec 2021 08:55:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6303.eurprd04.prod.outlook.com (2603:10a6:803:f2::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 07:55:26 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 07:55:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5e292ac8-6233-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640073330;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IsxppLuFbpcMhrCnFc1ICeRDJ58oDWZqxda8HtzEPuQ=;
	b=Qk+MQfb7o0Jqjr0jBl+h3Roz5wOe+F8z8WxK0ObU3ff8koa5L136UysdR96ZYqlr/omqFp
	CxzCw8ZI206Ck0Z0cyklRCGpcSXs11WflonGRUzAd4eEvo7B9d0Zi8pSM4Hw4Mg3JTLMeg
	K45ky1etfSXDWg6j7EghQLgHDpYq6tA=
X-MC-Unique: 7Z6sZh2gPSKMXl-4YP0MFw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=l0xcjxlM4moCP90RWRhsM5KjABJoRm5bHfoLU904WI6Lf63/YGb36csnh6FiZdWdhsfiKBCUle+tPqZ/Bqssgpnlghlz1qNvKif5jIY+k8phfIBvgGlqEmGQ0xcZMvt2zxMm3Yd1m3Qh3d3CNW7JtzkYgjHpOZ9b1TxsGN2HgATevnvkHd3rhmDysAF95LjzZ0HzyauQcniZPnulMzZPJG7e2e4FVXxU8d3054c4YDEzKEGkskWQyLR/zgt2cVrFc0hsBDLSJB/HtlMVHy6XYT07cTJBfjn4ieHt1tueL8bwru7BG4c+67k8IBYdhQLDMdDSPFtsKlrlihP1ymd+wA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=IsxppLuFbpcMhrCnFc1ICeRDJ58oDWZqxda8HtzEPuQ=;
 b=e572zwejZk7hg0pRysSKz9F+LEPuBnP5I7dO1V4mzjnx2DxaS9u6gEDQ+tdtuR9bu+JHYkeN0bQfg/eaY06Oe34w97cHP1beAeAguxAKKvKKQ9YQkNFr5hRMT8iIc42vnG/gkQxE4z8Ec2A+jn/APRDwo/VxpTi6NNkDGxV0PHrrVDRTkOVWY/ppepgj/iYoQmrRCKueBpU9Ynpq40xdN8ClalzsSAGbX2aMucWP3iedUMtpVVh7jpt9Lh2m1BEvm7byAjpKYy0i9W2wU5hOulsPlUdJN+e0UC/wq5E1Fgj9Lw5nvwG8h9P4enJXPx+EuN/SS+JknEd2tHEtxn1z8Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <35327375-fb82-ace7-ecb0-be9188c0d280@suse.com>
Date: Tue, 21 Dec 2021 08:55:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
 <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com> <YbseOtj7prFqViyV@perard>
 <YcBpLbxObugQ3doZ@perard>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YcBpLbxObugQ3doZ@perard>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8P189CA0025.EURP189.PROD.OUTLOOK.COM
 (2603:10a6:20b:31f::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a95ff982-86d7-4835-1531-08d9c4574009
X-MS-TrafficTypeDiagnostic: VI1PR04MB6303:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630303921A53A18D5779E8B0B37C9@VI1PR04MB6303.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ilG6C8vXdl0wiFl7YdPat3G2FW0S//EBaAzX4SnlL6UKUsF5ABHBtBH6scsVKmQcX4LS3KWtlx0UI0kBDcOSqDjIBu2Al+IfH4BA0PJVf/p+EYRlfcbJqGPUFRI/VuJZG23kXVh8s/5jnMuOPG0y7IyOE/EWCwe5mjMVEhz5QZ/Xqye9Spw3Vn7GbRBaMhuUPB6seFJXq0yMK7uWKQC/+j6SKcCmXqz+9d6rDbmDlA0L8523kH5g0KGKbRCbn0v3jcypGloC6Q8cQXUL6mm932skp1Q78fyZEj45CGPlK9oO9UmZF4Ej4+KU2ym6GvTps32sabQ7B6N0BHh8hmjynrVZddLIiDW8ZYpu1DxXGFyeqqqSWPsT+clkSaPT/XO/w93H5xwi+EnwKf8ZwyFiuKo0A3DJxzSZ7QDhLNc50miZzMLk4p8+pyQLhoLag09QsEbXbg30McZSSY2aaSKblwP1319qMqx0A1nXn9E7saE98S1B457jTlqpuVmflc+a33eczbg3CnTfwZFnCYusiPK/4535B84aYr4RbNbdUgErn/1BVVnfDtxfcmIAU/2i0FdDiAj9OJ+7L6nWqxJSnKO38BU6nM5gqrBiQjaBnMzNPUhz8xvqyhpF26k3uqevXM1dKyJmoZCYpCqJt6ESvJ3li4kyyCaOWWEeQUTAYFFRsUzYvOJn/Uq0RdXHrQxT3lCglgxS0Ld0WXSlBTLwpnwq3/BIGjahX4BieuHdekf1OqyrYPzf2ll50WncrNbI3a6KEjxMkJEnVXXQyMgTVQ==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(86362001)(31696002)(5660300002)(6916009)(38100700002)(2906002)(36756003)(31686004)(54906003)(2616005)(6486002)(66556008)(6506007)(186003)(4326008)(66946007)(8676002)(53546011)(316002)(7416002)(8936002)(26005)(6512007)(508600001)(66476007)(155303001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K3c1WUZmWGMwUnZzR0RiTnBBNVd3eTYxMXpSTkZRNU02UEEvMC85RWVhSTVC?=
 =?utf-8?B?U0RZaFpOZHFUYWR0S05LN2ZIbVRCaW9BT2dZdWF3RkQ1engzeWJsZExnSlor?=
 =?utf-8?B?aGFTamk1UmtmRkFqSkNhRldYTTVEMGs3MFozR2lrN2JHRk5PbXFxdWVFNmp0?=
 =?utf-8?B?eVduVWZudVYvUnRBUzZxbGhOMkFPZEZSRmk4dWdKTnhRWHpkVWozY2pIcU5T?=
 =?utf-8?B?Q09ObnN1azRNZFhubC9oU1ZjN29BT3JCa2x4OGYzakphSzhGSHZDbG0zamZP?=
 =?utf-8?B?OW4rcjZ5dklsWGlHcEJtVk5GQ0NCVytPWE8zMjlmZWRhS1dmRDBpZGh3cEpi?=
 =?utf-8?B?UHdkTkVhcU1TR0pMNnQwQkkyRXVsUFdOWDROclg0SHNSc2NFM0Q2ZU1DZjlV?=
 =?utf-8?B?ZTRObXpJOVZOaWlPS3BIbEpkN3dPQ05pNGpZT29TQXA1SUxlLzVlZUMzbStM?=
 =?utf-8?B?ZE9PdnRGSHFMRGtLYmNnZVRVNjgvbGROR01sYnpsT1JScTNCNUtwSW1nZjJs?=
 =?utf-8?B?VUEwQkF5ZGQ0MmtqcStKeU02S2Mra2lQSHh6SnZnNWJMUEE2RlRLZjFWZ01G?=
 =?utf-8?B?MklrbklYR2QydHJnZ0praWowOEF3R3paNUdZMzJObWlQMEJSaHoyN0t6ZGtX?=
 =?utf-8?B?eVVSR2ZGdjdyVGdrdHhWMzBhZ1luMHZKelgwQ0VLUnoxK2pKMWk2SllJMVJJ?=
 =?utf-8?B?blhUWG43NjQ0bVZyMnFLd2dzdmM4VTdNRzBUaXJDZCtoQVZGNy9scHFCbmg2?=
 =?utf-8?B?RmF5N1Z1SnVUVk5uUmprV0QzbWMxUHJOenhTUVN1TFpjZERnNGplcXg1WHF3?=
 =?utf-8?B?dFpJRUxnT3Z4eVZtUUR1M2kyZTd5UC9pUmtjODJSMU1NR2pEOXhVQ1F5L0lS?=
 =?utf-8?B?U0lpdGdxcnhSRSt6SklKNnlQeDZVcUFBVkp3Uy95WWk3K1pTSTRHWXUyazFm?=
 =?utf-8?B?aGExWXVmZStzNmpDWHBjWHU2aEZ2QlZVcXlsYkVoYnVxamhSdnRzRXNhYk9J?=
 =?utf-8?B?eEp4cFk1SE4wN3o3U3RyQUwrQW9BajhmZ2FqMXJkYjEzNFhtTkNkREdidU5o?=
 =?utf-8?B?amRkYXFhMUZUY0w3YnU1NU43TU4wY2toU2szVnBIRmgvQVhkL3ZSNThSU1FT?=
 =?utf-8?B?U1ZGVG9lZmp4YlZyS0FwdVArbTQ3NU5wUXdUbU4raEN1WFZpR0RHUUZqOU5Q?=
 =?utf-8?B?NTF6QjdMOGs3R3JlM1h4cmNxYUUwcTdRanc0bC9NSmRnODNkMGxMcG5QU3ZJ?=
 =?utf-8?B?aE5tS3FqTStNTStwemtrV3hwcEwza3VrN2Znd2tudENNc1ppbXdoMXloZ2gv?=
 =?utf-8?B?M3ZxL3VZOGlzK2wzeEl3Z0Z6c3hLbG9mRitCc0J1OUY0alJuV2pDSHJQT3Za?=
 =?utf-8?B?S0g0RTM1QWpnMGZRTW9DSE56RUwvYWxWdnpkSmJpaWk4ZzRUdFc0QjV2cGVz?=
 =?utf-8?B?THVhKzVGa0hMcTh2VWRWZFQ0SmhVM3NnMWtzbnU2UUxUTEhKTVNBenFvYm1F?=
 =?utf-8?B?bDVVSkRsSjlFc3Zrc2JwM0JKZzN0R25lTEtmMWJrOThuaWJYRVE4M055TzBE?=
 =?utf-8?B?bnZrRi9lVXVHelNaVjlGZzllUTZDeTJrNzA2ODRxdkxiMlZLT3ZmVzBJaUJo?=
 =?utf-8?B?dXB0Z0tsZkRackdDTjhWWDIyWWFuc1ZMRS9sM0RlNmM5akYzek5kTW1iSnp6?=
 =?utf-8?B?Z1VLdkhMNHNhWkpJRG5rTTY0VmE4MTZMbVdoMmRkZWNWU2Rnd20yc2dlQmUy?=
 =?utf-8?B?TVdoYWRmM21YU0tXSVQ1UzNWL2w4cytqc0h5MUZiZmZEVy9FZFp2bzFXaEFu?=
 =?utf-8?B?WkNOaDh0OGRLdm8xL043MEtsY2JwRTBUT1dWOXZ2N2NYcElOcWZ1c3J3b3BN?=
 =?utf-8?B?Rm5MM01kQnJUK3h1a1dJNmFGMXVQdXkrVDh6K2VlWnJPQUtDbWZiTGEzSG9H?=
 =?utf-8?B?SGxMaDI2MktoL1BwR0l1dGdiNEM5OUJGWXBTSFdWSzVxOHV5OWtxaitGaDAx?=
 =?utf-8?B?TktDS0hDZktNTWcwVVhucXh2emY3S2ErdmMrTzg0U1J6RTBVTUdycW9xbEN4?=
 =?utf-8?B?SjJNMjhqM2lPRHg5aTFPR2p4dTFOQlFQYktUbnBIUmhmczdCRFBFa0tzNWV6?=
 =?utf-8?B?OWhXVkpoTS9lL28rNjdpcTVuSVV2QVJIM1puNEx3SzhFRWx4TzR5Y1FXRmg5?=
 =?utf-8?Q?AUDLtydrnznUsbXLaMdDcA0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a95ff982-86d7-4835-1531-08d9c4574009
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 07:55:26.7260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d//umgGibXyzJ8lVoMmRPAQiFrGHfJMDZybiHoCI5qbR1LAIBJNSzGO4+w6BStZwqpSwSHnrZcCpYlN82Yvoyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6303

On 20.12.2021 12:29, Anthony PERARD wrote:
> On Thu, Dec 16, 2021 at 11:08:47AM +0000, Anthony PERARD wrote:
>> On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
>>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>>> --- a/xen/Makefile
>>>> +++ b/xen/Makefile
>>>> @@ -22,6 +22,15 @@ export CHECKPOLICY	?= checkpolicy
>>>>  export BASEDIR := $(CURDIR)
>>>>  export XEN_ROOT := $(BASEDIR)/..
>>>>  
>>>> +abs_objtree := $(CURDIR)
>>>> +abs_srctree := $(CURDIR)
>>>
>>> Nit: In line with e.g. obj-y I think these would better be abs-srctree and
>>> abs-objtree.
>>
>> I guess that would be fine, we don't need to keep the same spelling that
>> Kbuild does.
> 
> Actually, those two variables are exported, as it appear in the next two
> lines. Exporting a variable with a dash doesn't work very well as shells
> may not be able to use them. When make find a variable with a dash in
> it in the environment, it unexport them.
> 
> So, for those two variable, we need to avoid using a dash, so I think
> keeping the current name is better. (And now, I've find out that there's
> an issue in the build system, I'll prepare a patch.)

Oh, sure - if they have to be exported, the names should remain as they are.
Question of course why they need exporting when by the end of the conversion
you don't change directories anymore.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:05:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:05:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250161.430801 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mza8t-0005aa-78; Tue, 21 Dec 2021 08:05:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250161.430801; Tue, 21 Dec 2021 08:05:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mza8t-0005aT-43; Tue, 21 Dec 2021 08:05:03 +0000
Received: by outflank-mailman (input) for mailman id 250161;
 Tue, 21 Dec 2021 08:05:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mza8r-0005a4-BY
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:05:01 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b1a8e234-6234-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:05:00 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2050.outbound.protection.outlook.com [104.47.1.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-QgJwi1keOxS-80NML5EMzw-1; Tue, 21 Dec 2021 09:04:58 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2336.eurprd04.prod.outlook.com (2603:10a6:800:27::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.19; Tue, 21 Dec
 2021 08:04:58 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 08:04:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b1a8e234-6234-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640073899;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OvJZFlFi7ZP8SdU97BHY6Lhk82xfcB05gFJe5Gp1YB4=;
	b=PzCt0thHARspYD/1+TE3VypAw5uZvg1E6+guCvHXqbgGKQC5NYePoRlCLlm2zdATHp3HUT
	4Vr/lU92JYGKP8G8v6UKIWpsRZZyHkzGu9fOGcH5zivp8rbwfei1enDSwHW0Zx/I+nJBQF
	h03XbxaUHaHSGWcTY4HD6tTfd65Sa/k=
X-MC-Unique: QgJwi1keOxS-80NML5EMzw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ksJHr7zi3j30dnzo4sCcxg98S4MSHSfD22x8QMbhDF6pjDbShETYon25VRAMjS5Xdm8U0Z+GooyX4t5bb4Znf+1WqjcVSd9UgzrSfFvoCtee+cHkmT2g6XFzEaBmMB1HieKk6EpmwlkQTq0A5Fos8nqtNnDtEtfP4pjIyw82bP6brwD/0AbQ5gPeH4ExHJI8EutTbZjTiHw8U3eGOSknWcS5iWqac1ip+WGXNbth9ROSgBZ89Zyyyjt/htlHKXLP8jHfqaIAEW0J6GaQDX5psOBcpfp0GY3cIBbPJFqIms79ax2+KNQz3PubuFt1JcJnG+QmbDm8hrAk7eBLJOGTAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=OvJZFlFi7ZP8SdU97BHY6Lhk82xfcB05gFJe5Gp1YB4=;
 b=LwbE+Oz7kzOwb+DMltYcM4FH1/GSeoTBGGVngYcqv/EajsIrjR/TMgKwIzuMUC4TsGOXdocQHKWtuS2AmdNEdK2wSYkjIlJP3n5aSitT1iRkJJmARh/VpaCjmFb9zfI2Jht0OAaairMgo28YYycVrrvo/yWslA1RPHhQtz7/2Wlcre9dvHYd52rEoStc9sHSixb/jHjm/5QMKQ3mESrz0x2+3zDpJxuR4cZ2wjtCY52rHUigojDV50MSzw5t61hUlDYJT0eW/q2tizYlxpWA2jZpgSebCrrB6DE4VkREW7RuZB4nVmZaQxGz2UundpfZjcUzWGatisppEBb0cQiSog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <1ed3002c-ef20-d7db-3968-793f27ee1c07@suse.com>
Date: Tue, 21 Dec 2021 09:04:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 14/18] IOMMU: fold flush-all hook into "flush one"
Content-Language: en-US
To: Rahul Singh <Rahul.Singh@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
 Bertrand Marquis <Bertrand.Marquis@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <e40ee980-9151-101a-1484-b1710aaeafb0@suse.com>
 <40CD83D3-4D85-44BA-8F21-969B544267CA@arm.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <40CD83D3-4D85-44BA-8F21-969B544267CA@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0047.eurprd04.prod.outlook.com
 (2603:10a6:20b:312::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1df2b614-de33-4e0c-e0cd-08d9c4589471
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2336:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2336F876E6A7D9317916D77DB37C9@VI1PR0401MB2336.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	p3ARWKNlKuR0xsGOReVgG33QSwmJkv2frPCJe62wkwhB7Bm+w0fK+8PLkaGbsb4xmM09Ir9Wq/vC+qBA8qXxJsojZGZW2QfRWqeUUmNl3Py2fnYCYzuUYZ1rIpl+mnrLEpHNkhzGeVcag3x7ZZo0fmTQ8mo9D+E19MnSorCiwz/cACLCFP8SL/H6TVt3f16NFL8pkTkqF0opFiVzcm0Ncvex+xZBfQ1HuTouXdsNS3TkvgRvAZAFmCsjpgvc3No6264T7qrwzEXCKi0RgkEjep1vwd6pPvGqfg3+Rf++axuQ6SJg1Wuxm7NJJ8yJce8DZzsu/8kaJC57d4SQQIZTzVkoU9Y6V6mixX92Gx/ADimhJWI7hhgXiDCMuway4WOhieZ5SLUa2DkfQ84k5naKOj55XXoeN474w0LF4RukkRqaBS9861KRZBDFkZWaCjj6rEaediCbv5kqNZC0DOMAyelnn2NB8AltqtFGe+1sQGxqBOznI65a8jXpDwRkhlWAbpk25NVEkk8O96Ri4FZTjW6f4Ik6CNT2ZR7tL/EC3qgIPZBkDZ9aT2yseOkTjogMfRhMdmn0gXzZStDXzPcOCl1u5NL1AG0qXH2upPPJk03hZECLL5y5mMd5g1JXfbUjvhtEtYK9QW1PM6yocnB02ujPWb15GbksWudO1Nno/x3/kwyrG+jcCXIjsyhnhYCoLA+iW/0xZ6FFyrlHBqhK1aCHPPZrIIKudUb0+NR+QDjqj+VTCeGiajxI09AMUTq3
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(8936002)(508600001)(66476007)(31696002)(2906002)(6916009)(66556008)(36756003)(66946007)(6512007)(2616005)(53546011)(6506007)(31686004)(4326008)(186003)(26005)(4744005)(8676002)(54906003)(86362001)(83380400001)(6486002)(5660300002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SGg3VVFoQklZaXRlMmZyV1UzdWFMVFdQRVpiL2tmSFlyVWF4cDQ5bTBETU9F?=
 =?utf-8?B?bVRVaHpoQzdMTTJoKzhjMUd0WERGR2pmNzhjelZFd0JBMjFwNG1xaGFERC9s?=
 =?utf-8?B?NlljcFFqWmxGTmQ3c0pjMnlwODZvU21UNHVIVWFlbHdCMHdEYWtKTU1jTTBh?=
 =?utf-8?B?aDlvYzhWT1ltVXB6T2RneURuNjNvU3Z2ZkFKQ2R6TWJSSWFXMkZHWlBObCtL?=
 =?utf-8?B?VDd5VVpvaEs3QzMyem1mNkJXMnBjUWxMb2EvVklJYWpiZTRESFRCdERYREV5?=
 =?utf-8?B?NGYzSDQzN1YvZDhsSE1zelhYYllyQWd1cVZITldUYUhxYThwaTVrN2toT3FM?=
 =?utf-8?B?K1dteXU5bVdpbFRKV2V6VG1Da2thb1o3ZWVOSHNnc0tncUplMHBiOVlvVU1h?=
 =?utf-8?B?Vy9LbHZsVTgrQ2pmeTA3dTVEYm8zUkc5bHgraWZxRlhBRWFoWE95TTFGTXUx?=
 =?utf-8?B?amJiMXdneTFyVUljRTR4NkNTeUJCWUxSaU5NbVNMYmpnK0ZIWSs5NTBvZnlD?=
 =?utf-8?B?dDA5SlZ3Vys0WEhpUmJJR2RLNWFzTUtPY2I2dXBkalErRmllOHhnak9FOW1U?=
 =?utf-8?B?VUFSTmYxdytyaS83Vk9nN0pFZHBvN09rS0laWUltakJabGh1T2ppcVpmQzdr?=
 =?utf-8?B?WWQxUmhZRDJSc0FnYllWQzFxQ1J2eDVXSCsycExtdDVqcVBGcUdIYTlKVnd2?=
 =?utf-8?B?dlUyTnRnVFdiMm40VUVHeUU2WERrR0wreDB1b3JRZEs3TnN5bVk5Q2VzSWJm?=
 =?utf-8?B?S0tITW45NzhLLzJtejF4SGtYazFaR3BmbVlZeTNST0RrTklqejV5eTBDQXdG?=
 =?utf-8?B?TytyZjliRGc3b3dGM29QRXo1Um55Q1B1eHo3T0dKMEFLeEVwVTNxeWtGMFVG?=
 =?utf-8?B?M1pyQWxNbHJqK0Zwd3ZIVU11R01sQURGbldzcndpbGtXbnZoekNFbU1MYXpC?=
 =?utf-8?B?MU5pQTJ1RnVCbEhvK3BBZi9VRkJrM0RwbUJNQWhMbXJJdFVQMjJsNGRuc1Bj?=
 =?utf-8?B?VWlTVDBpUE4wakJTQnk5eW8yM0MrQW1xNVZYSGw0WWVsV2VEVXlrR2ptSWty?=
 =?utf-8?B?N0ZsdmxudkNOVEs1emNQcWtZUU9FcHhZb3NZakVBeHNJVmd5bkk1bjFCcUNT?=
 =?utf-8?B?VGxJeW4rczNmVk5mczVkcWIxZi82K09QOUJCV1dneXFmNU92bEFNb3hPUmJP?=
 =?utf-8?B?NkpHbzkzOG82eS9zWERMaFJ3ZVFKUmdvc2RBWVgvY1ZiZUdra2pQQ0tZQVhV?=
 =?utf-8?B?NDJIOHRCT2liTHBJTEhibnRuSHZiMEowZ0hVL0hZZWhnOG43elgrdFQ4aWJn?=
 =?utf-8?B?SlNZd21BeDEwWk9XQ1VINzRaWGRvWDJpSnZIaUZDcUZXd0M5cDFDNFhrajBO?=
 =?utf-8?B?M0x1Uk9XbmlBT3I1OGtZNlp4YVpXdXgyQXJzM1pLaEZOR20zSnE0bFlIUlQy?=
 =?utf-8?B?dnhMTnpxc01qSm9NT25Fb0NISkk1aXR2RldtbjFlUkxTNVhGaVRvUExmaEdU?=
 =?utf-8?B?d1RRRVQ2Ukptay9RQkV0elljWGJvY2dVVjJFSEp0TW95eGljd2xzTG04VXBZ?=
 =?utf-8?B?MXAxQVQ5WFBoaEsrcm13dUZPaFFaWlg0QWM0Z0NwQW1WcVJIRHZpU2ttbk1H?=
 =?utf-8?B?RWRIdEd0Sy9HYUxXTlhzTUpxVjhjVTAwRkY0cElkdGFaelFpRGptN09vMVRX?=
 =?utf-8?B?SmdicVppdXFkRXNwSEdyUTJHcEtMTW5temZaZnZ3RWRRS1JMS09zdkJWM0Yy?=
 =?utf-8?B?NkIxRGc0UmZjMGpabHRYMVNjaEphOWlqVzY1cjNRV3BndVRVNGwzQVF6Rkph?=
 =?utf-8?B?MFl1SlZiWDA3TlRETmtzVm8yYTRNZEY0M0dnMVVtZmdYNmY1NHpoMXJHaGI3?=
 =?utf-8?B?VG9DOFkwWG5HMFo4VjVzZkxGUEZXbG1UVnBqa3pBQ2M5aVV5akNOeHY4dHRs?=
 =?utf-8?B?QUlUMXRLbnZHZVM2U3RvaTFQaEpLQTd5Z1dSVWZ4VTNxOTExK1YzeXV2SzFU?=
 =?utf-8?B?NklSaHdiSktLUFFsQnlwZ29TSWliOW1EZ2kwd1cwd0tBUUtYSENCcWNaMlhy?=
 =?utf-8?B?NFk1K0plTTA3WnpHRFAyaWZnSi85TkIzMGRNTkorR1BCWlllTEI4SXVzNFd6?=
 =?utf-8?B?R1VPSGFKQ0tMOFNDK0xSemgrNWhCTTVQQ1JVaTZrRDZETlVtenBRSlI3WWR6?=
 =?utf-8?Q?Mg5W94wbQGpGRRU4hPwpBF0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1df2b614-de33-4e0c-e0cd-08d9c4589471
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 08:04:57.7962
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZgUuND2Hrj7wVE0/ik9M+d/gvQVrs/lcAYSr3Sfh0JRKW5EEgWiD7oXA5I2ATVq01gAU5lSulfU0SPtRgkPLrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2336

On 16.12.2021 12:30, Rahul Singh wrote:
>> On 24 Sep 2021, at 10:53 am, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Having a separate flush-all hook has always been puzzling me some. We
>> will want to be able to force a full flush via accumulated flush flags
>> from the map/unmap functions. Introduce a respective new flag and fold
>> all flush handling to use the single remaining hook.
>>
>> Note that because of the respective comments in SMMU and IPMMU-VMSA
>> code, I've folded the two prior hook functions into one. For SMMU-v3,
>> which lacks a comment towards incapable hardware, I've left both
>> functions in place on the assumption that selective and full flushes
>> will eventually want separating.
> 
> 
> For SMMUv3 related Changs:
> Reviewed-by: Rahul Singh <rahul.singh@arm.com>

Thanks. Any chance of an ack / R-b also for patch 3?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:09:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:09:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250167.430812 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzaDZ-0006QL-UX; Tue, 21 Dec 2021 08:09:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250167.430812; Tue, 21 Dec 2021 08:09:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzaDZ-0006QE-QO; Tue, 21 Dec 2021 08:09:53 +0000
Received: by outflank-mailman (input) for mailman id 250167;
 Tue, 21 Dec 2021 08:09:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzaDZ-0006Q7-7z
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:09:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5fcc4f2e-6235-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:09:52 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-jRZnuuPwMMKwVGZuZ8UMrw-1; Tue, 21 Dec 2021 09:09:50 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.19; Tue, 21 Dec
 2021 08:09:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 08:09:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5fcc4f2e-6235-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640074192;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ZcZJS2DqiqSY74zAjJMQNy4+WSwKJpRUuf/kySVUBJ0=;
	b=AOlbr8LEap05D/4s3ObBD6wJy629Yvb4r4ihPJTIx4uSv0Fg1wLVtILXfeAkAz2R5irgJ1
	tmrBlN3d/ZWGLrKHBowQhRh0ACDncQrR2FR5UvErsJU4Z/zdCn/z5EVZmN0DFaxO0AijeE
	vLl16P0yC4frwqyOsvoVrv/jrENwCJw=
X-MC-Unique: jRZnuuPwMMKwVGZuZ8UMrw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=idDmd6rZe4Qa1m2eUGo36rhGMgCNFVXLre9wq7YFjNYqut3vkbFtsSQVW1k3nd5p4cRadlDDLDnFx1RMSj/x0XKksNKcC+ThCvZaed9QtIjOgCA2YEQLTnOYYohPWoctR+Kf4e4IGwJ51s6jIvwzGTk/vNLUT2iqzhn9tADevPkp0fDozQCwZYz1QC1ZXDeXNQJiIE/kO2/tlKGwUMC/uDvytm52Qd7zzqOesyw2EavzAu8mTKqgt0v6zkCT8fQTQqqSMAvg24TpX8jZVmqluXFc3CF4K5hF+g8/LCkJzAyBh9ugDMy+H+3uD4mRK6LO6Fs4LLxvebp7mz+wMVgzyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+x8nwd/UVS8jAWrbfjVyyVlkE1kxDCyYdnZrzNLbIb0=;
 b=WfCttmnt5fQreJ6IEmzvIPQUS6bq/JHlz7cc5bP60GRHANhDWcFZCXWwxNshi2RJnPuXeaQHcsHNTxk8RvrkileluD5ihrWLsxocATHyVeIhXUigK+hkU1cNDY5WDK0/UWgpYbinUzNjOLleK4U1BswL+6zvz3Vl4F72nn3kO/idJ3XLOeafl6ghH54GhKA99eBQxL6rhD+YlJRJvYGlhmP14JCV/dVr8AfkVFRDRtmKK8m3cAt4Ombj9B5+Oa7yt7yahr71EY/3198ifdckqroL7ZO+MkNObxeXDMCs6sgz+rxJOoVLIkO6oSbp6rTDyLaALQa4l5vYVcpk1cFiFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <d85733fe-2ab1-086e-15cc-e4ef68be4596@suse.com>
Date: Tue, 21 Dec 2021 09:09:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v2 16/18] x86: introduce helper for recording degree of
 contiguity in page tables
Content-Language: en-US
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>,
 Wei Liu <wl@xen.org>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <aab0b88b-7643-cc08-756b-0684f93be257@suse.com>
 <Ybn0LaRuFpUfcmoU@Air-de-Roger>
 <bbcbd938-170d-94dc-4fa3-49766fb2a9c3@suse.com>
 <YcCgV/o+1I0qry+q@Air-de-Roger>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <YcCgV/o+1I0qry+q@Air-de-Roger>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM7PR02CA0024.eurprd02.prod.outlook.com
 (2603:10a6:20b:100::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c6b9f46a-145e-4fdc-4819-08d9c4593f3a
X-MS-TrafficTypeDiagnostic: VI1PR04MB4608:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB460861CE7209685CA0B1ABD9B37C9@VI1PR04MB4608.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gCIkzmx8xzhsy3KhSZ0WAusB/DwHwk5QiDt0yaywQDtQYENw6Iqa4nphPX8dJCk6GAoeS55DnyvXRbvxW25f4JmX90x/aldA/FMrie9kUNrbEUpp1ZNgthf6Pdt01zbSX1xJKEypWL1PHyrFy9ljF/LubzPv6OTY774JA8piW+7WuhKKO5HP8YVsdFQDRITLUtRMwfBg/oTmQKhcHAF4UXkc8xRA6VZPkg3uTsfi5ociFgbb+J0BBIWlcfYkCLhsCyRnG3W7FeWfOUff8vXP01olyMckKvPl71UsMlnVyXV2XfhGi3Fv5U+EG6vXJ03U44GtsJ+A+19D38eZgRGotXfYFDsbHK4qrF88aphOZhWSi6FQ4TuMUiP/cbT8Kejll4EklQqh7gPR1crNPBvvj2fYzy/6Xz6qwgMIr8IZWxwXbJEm7wB8oa2nMlYCqNuDk2jDhsV4YVISRGlMOMyZv3R4J9asORxQeIigWIzLG1nOJsSDdO3c79Awy01MfkhuODQ+x0DO5hWonc627ZNwENqPD1VUSsUTUZImKEFO7IGqsY1qtIAwjhJ4xq9wDRZPtzCwxx05iI2GeVe1uA3KO9wdxKiA8tl5ekh6JufjKZmohmefBiDerKlJjTjaNnEaMq0UR0FiGHA7tgRiOndlD3LIUiIJiuWpSOr41W97RrXF8zCnB5THzyUKSOdmiqzdRF2TvMqnvutGOxOIjeS+aSXo68QXbIo2KTTOX0lrKMM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(83380400001)(66556008)(8676002)(31686004)(5660300002)(4744005)(66476007)(66946007)(6486002)(26005)(2906002)(86362001)(6512007)(8936002)(4326008)(2616005)(36756003)(38100700002)(186003)(53546011)(316002)(6506007)(508600001)(31696002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rIfPwlNX9y2zI6TgNBK/S6khECQduZpi6X76qmffod72UG1Avf/NfTcoN0aj?=
 =?us-ascii?Q?eL7IHP1mUo5y6WSuBpl1f/boswnCRjUdVBoGUqwvIqXA2ItpnF078NhtPPzT?=
 =?us-ascii?Q?U9gyaGxmNTa2+RxSRO8dDrhfrHUaMFGg2PFbZt5vm+CobvoR73KJ+/d+FlRt?=
 =?us-ascii?Q?dyfERvUPagv3p9BzBp9N4vrkyIryWlrq4DRqi44dRRq/8q5yVzSg8Gb5nwsO?=
 =?us-ascii?Q?OrbntEvH7Wok0gWXpRKLfAfDEtBZCSjFZRL7CupJXaa7lBswvDslIkDySzbS?=
 =?us-ascii?Q?MSJoITOcfLApl8QROjeyJQv+rgNv05xi7MtO8hwn/9fjcX17ydm4D+HyPBeL?=
 =?us-ascii?Q?YmVKTdvFoFj6H+rtAdBnRaHE+vhe5Wd2SSZoB+3mWPBJ7VpwUnG10K3auI89?=
 =?us-ascii?Q?PK0eq5Dnt/lE2lrnb9tKd/Q7HwbeDb920/DWN3kozOVgnwkdmahu9Vwm5Cws?=
 =?us-ascii?Q?M1dngehyck0GxnPMGNf+4NaUOdo2eEZLQESe/6/s4d6t3b32TCEPbzGM8I0R?=
 =?us-ascii?Q?4YX+0ZtAzJWm+TisKxBHGOaTBlcfRD72GWVSpdPzZhFwnHdPbD2Lq5yjmfAB?=
 =?us-ascii?Q?tMo3FXDMxPzTEFPcjEKBmq429L6GsUDEUQYTSfXOZZU1HrKTKIxaNUBQWf+3?=
 =?us-ascii?Q?qpriF5KfgjmzUSaGDWtyPl6Dt8LqhlwLsWhrNj62t7ng0CushdPuQs2ujoY3?=
 =?us-ascii?Q?/FoFPpFW5W78QLR0zFE7x8xk0F1yLM0eYcO94dJ+brcaXHcAukPqRXWx36JG?=
 =?us-ascii?Q?gBNbpSypI0hkxJcHnc+fPSt0hchr8HHL5I5bJQUzJeybxdRuYMXADKonGG4G?=
 =?us-ascii?Q?TKKTvcqKKmU79AzXQ27sWBDxH7XEx4BPWHBgAJl8bfgFsqf7RB27w5bKhAoM?=
 =?us-ascii?Q?1FlvhiX+gRn7hZurDAyu54vLUmdtOxxKWjoKn804j38GB8kEAg5WQ6N1e6mZ?=
 =?us-ascii?Q?b8VG34nC4n4D993uwDmPUqdixaCJHNClndHzZdztccTulQV44VIk3m9quAjv?=
 =?us-ascii?Q?vvr48NMemWf3iYUt+KkU0K4wPrRsPEtptUEZJej2eV2zZRf++x1dvgnjhNZN?=
 =?us-ascii?Q?4ysTlCdWi68SSd7SaowmFQQufT+EVwH2Bp7k7Xg4TSHaNU7rWy882sMqUaOk?=
 =?us-ascii?Q?pYZzY2HwaW7K49ggSyVZKvQKXx2v0UXrkcFZkAU1e1EL6kJbf4Bu5L4Vd3QU?=
 =?us-ascii?Q?M5UKFreG+G3lmmsIl7JbQRMaVUwEl50FEh4ow0MXgkWsGAsoSIOTr9xc4pdi?=
 =?us-ascii?Q?IDM8Cs2aRK0LjwqjNl8jhPRn+25UnV5SwknCvTb9ECil9Q0ZiPOTNYSJOtgW?=
 =?us-ascii?Q?V5KGqsI2sVnYyQovk5gwYBkR9PRxsj30o3KP0GJM6x/IuflBhwTOvK5zp2GY?=
 =?us-ascii?Q?4GsMxfYl/L2Cu2tM2CRyMmx8LOt15//j7sHniFX9l/KcuPzZGFQDtDcuvMBq?=
 =?us-ascii?Q?Tbqrgvqq2m451L77xUS80iBixvkRtKPdhGMMNT5tSWPWizWphT/EnAoIc5be?=
 =?us-ascii?Q?FvD3ElNV9l5vEu4YsG/6/aB3yomZ1tr8qfoVkuvEMEyK8XeE0zVWBdNA5wAG?=
 =?us-ascii?Q?F16MvzFAoMVyeI//Y4paUNgD0Xg6aTsaLB2klv0z0voJ9GZAdeRKc4J9FFVN?=
 =?us-ascii?Q?wgTRqQS+ZCgjeUVZ1aU+I9M=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6b9f46a-145e-4fdc-4819-08d9c4593f3a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 08:09:44.3162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mJcdfl2JlHlxHbtF6rW3cbuolkRRPRBUQDBqOyDy/iLfWt82j86+7dc3FFiS8TJt65i1dNsZFYOGP1IZO+2zfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608

On 20.12.2021 16:25, Roger Pau Monn=C3=A9 wrote:
> I think it might be interesting to add some kind of unit testing to
> this code in tools/tests. It's a standalone piece of code that could
> be easily tested for correct functionality. Not that you should do it
> here, in fact it might be interesting for me to do so in order to
> better understand the code.

Actually I developed this by first having a user space app where I could
control insertions / removals from the command line. Only once I had it
working that way was when I converted the helper function to what's now
in this header. But that user space app wouldn't directly lend itself to
become an element under tools/tests/, I'm afraid.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:18:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:18:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250173.430829 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzaLa-0007u7-RJ; Tue, 21 Dec 2021 08:18:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250173.430829; Tue, 21 Dec 2021 08:18:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzaLa-0007u0-OQ; Tue, 21 Dec 2021 08:18:10 +0000
Received: by outflank-mailman (input) for mailman id 250173;
 Tue, 21 Dec 2021 08:18:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=3COf=RG=ens-lyon.org=samuel.thibault@srs-se1.protection.inumbo.net>)
 id 1mzaLZ-0007rt-Kg
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:18:09 +0000
Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8632c1b1-6236-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:18:06 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 559791F7;
 Tue, 21 Dec 2021 09:18:05 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id VGwyIgt8v35K; Tue, 21 Dec 2021 09:18:04 +0100 (CET)
Received: from begin.home (2a01cb0088600700de41a9fffe47ec49.ipv6.abo.wanadoo.fr
 [IPv6:2a01:cb00:8860:700:de41:a9ff:fe47:ec49])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 9474A18E;
 Tue, 21 Dec 2021 09:18:03 +0100 (CET)
Received: from samy by begin.home with local (Exim 4.95)
 (envelope-from <samuel.thibault@ens-lyon.org>) id 1mzaLS-000gSV-Os;
 Tue, 21 Dec 2021 09:18:02 +0100
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8632c1b1-6236-11ec-9e60-abaf8a552007
X-Virus-Scanned: Debian amavisd-new at aquilenet.fr
Date: Tue, 21 Dec 2021 09:18:02 +0100
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Juergen Gross <jgross@suse.com>
Cc: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org,
	wl@xen.org
Subject: Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up
Message-ID: <20211221081802.qop7fsow2mu4qugy@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Juergen Gross <jgross@suse.com>, minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org, wl@xen.org
References: <20211220160716.4159-1-jgross@suse.com>
 <20211220160716.4159-5-jgross@suse.com>
 <20211220232231.sylwjfk6rsjrgeqi@begin>
 <75aa6bf0-dbbc-3076-ee45-42eb0b89eeff@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <75aa6bf0-dbbc-3076-ee45-42eb0b89eeff@suse.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spamd-Bar: /
Authentication-Results: hera.aquilenet.fr;
	none
X-Rspamd-Server: hera
X-Rspamd-Queue-Id: 559791F7
X-Spamd-Result: default: False [0.40 / 15.00];
	 ARC_NA(0.00)[];
	 RCVD_VIA_SMTP_AUTH(0.00)[];
	 FROM_HAS_DN(0.00)[];
	 RCPT_COUNT_THREE(0.00)[4];
	 TO_DN_SOME(0.00)[];
	 TO_MATCH_ENVRCPT_ALL(0.00)[];
	 MIME_GOOD(-0.10)[text/plain];
	 HAS_ORG_HEADER(0.00)[];
	 RCVD_COUNT_THREE(0.00)[3];
	 FROM_EQ_ENVFROM(0.00)[];
	 MIME_TRACE(0.00)[0:+];
	 RCVD_TLS_LAST(0.00)[];
	 MID_RHS_NOT_FQDN(0.50)[]

Juergen Gross, le mar. 21 déc. 2021 07:16:49 +0100, a ecrit:
> On 21.12.21 00:22, Samuel Thibault wrote:
> > Juergen Gross, le lun. 20 déc. 2021 17:07:10 +0100, a ecrit:
> > > +unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages)
> > > +{
> > > +    int i;
> > > +    unsigned long end;
> > > +
> > > +    for ( i = 0; i < e820_entries && e820_map[i].addr < (pfn << PAGE_SHIFT);
> > 
> > Shouldn't that be addr+size? Otherwise if pfn is in the middle of an
> > e820 entry, we will miss picking up that.
> 
> No, we want to check all map entries starting below or at the given pfn.
> The test should be "e820_map[i].addr <= (pfn << PAGE_SHIFT)", of course.

Ah, yes, due to the "<" I mistook it for a loop that skips the entries
before the targetted pfn :)

With <=, 

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Samuel


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250183.430879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanS-0003bI-BB; Tue, 21 Dec 2021 08:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250183.430879; Tue, 21 Dec 2021 08:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanS-0003Zh-15; Tue, 21 Dec 2021 08:46:58 +0000
Received: by outflank-mailman (input) for mailman id 250183;
 Tue, 21 Dec 2021 08:46:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanQ-0002yE-8g
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:56 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b3e5efb-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 75C921F3B6;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4B40013BEC;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id kKs1EXyUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b3e5efb-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cWXSsRb7aAVsvcWbgBY23t6rGMkd9cnCIBDGNyaoF64=;
	b=irEHSRRpWz7T4cfCEBeCvZnHmHhIhSwu2Q6XuAxDuRJkO4E8/+tswxDUV4Kmbjqezrdxh/
	RTssKq/iFE2QHg+cTsC3kvgyUH+WtXXtZLkgrbcIMVK4ZYxHmn3zHHkoSS/6twrBC012mP
	SjScZVuWvOMoFJLFRNHe19R2YaVlJ3c=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 02/10] mini-os: sort and sanitize e820 memory map
Date: Tue, 21 Dec 2021 09:46:28 +0100
Message-Id: <20211221084636.6987-3-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Do some processing of the E820 memory map obtained from the hypervisor:

- align the entries to page boundaries
- sort the entries by their start address
- merge adjacent entries of same type

This is relevant for PVH mode only.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
V2:
- correct page boundary rounding
- handle overlaps after rounding (Samuel Thibault)
- improve sorting (Samuel Thibault)
V3:
- small optimization in e820_sanitize() (Samuel Thibault)
---
 e820.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 186 insertions(+)

diff --git a/e820.c b/e820.c
index 2165280..70286cb 100644
--- a/e820.c
+++ b/e820.c
@@ -57,6 +57,190 @@ static char *e820_types[E820_TYPES] = {
     [E820_PMEM]     = "PMEM"
 };
 
+/*
+ * E820 type based bitmask for deciding how to round entries to page
+ * boundaries: A set bit means the type relates to a resource managed by
+ * Mini-OS (e.g. RAM), so rounding needs to be done to only include pages
+ * completely of the related type (narrowing). All other types need to be
+ * rounded to include all pages with parts of that type (widening).
+ */
+#define E820_NARROW ((1U << E820_RAM) | (1U << E820_NVS) | (1 << E820_PMEM))
+
+/* Private type used to mark a range temporarily as reserved (lowest prio). */
+#define E820_TMP_RESERVED    0
+
+static void e820_remove_entry(int idx)
+{
+    int i;
+
+    e820_entries--;
+    for ( i = idx; i < e820_entries; i++ )
+        e820_map[i] = e820_map[i + 1];
+}
+
+static void e820_insert_entry_at(int idx, unsigned long addr,
+                                 unsigned long size, unsigned int type)
+{
+    int i;
+
+    if ( e820_entries == E820_MAX )
+    {
+        xprintk("E820 memory map overflow\n");
+        do_exit();
+    }
+
+    e820_entries++;
+    for ( i = e820_entries - 1; i > idx; i-- )
+        e820_map[i] = e820_map[i - 1];
+
+    e820_map[idx].addr = addr;
+    e820_map[idx].size = size;
+    e820_map[idx].type = type;
+}
+
+static void e820_insert_entry(unsigned long addr, unsigned long size,
+                              unsigned int type)
+{
+    int i;
+
+    for ( i = 0; i < e820_entries && addr > e820_map[i].addr; i++ );
+
+    e820_insert_entry_at(i, addr, size, type);
+}
+
+static void e820_swap_entries(int idx1, int idx2)
+{
+    struct e820entry entry;
+
+    entry = e820_map[idx1];
+    e820_map[idx1] = e820_map[idx2];
+    e820_map[idx2] = entry;
+}
+
+/*
+ * Do a memory map sanitizing sweep:
+ * - sort the entries by start address
+ * - remove overlaps of entries (higher type value wins)
+ * - merge adjacent entries of same type
+ */
+static void e820_process_entries(void)
+{
+    int i, j;
+    unsigned long end, start;
+    unsigned int type;
+
+    /* Sort entries. */
+    for ( i = 1; i < e820_entries; i++ )
+        for ( j = i; j > 0 && e820_map[j - 1].addr > e820_map[j].addr; j-- )
+            e820_swap_entries(j - 1, j);
+
+    /* Handle overlapping entries (higher type values win). */
+    for ( i = 1; i < e820_entries; i++ )
+    {
+        if ( e820_map[i - 1].addr + e820_map[i - 1].size <= e820_map[i].addr )
+            continue;
+        if ( e820_map[i - 1].addr < e820_map[i].addr )
+        {
+            e820_insert_entry_at(i - 1, e820_map[i - 1].addr,
+                                 e820_map[i].addr - e820_map[i - 1].addr,
+                                 e820_map[i - 1].type);
+            e820_map[i].addr += e820_map[i - 1].size;
+            e820_map[i].size -= e820_map[i - 1].size;
+            i++;
+        }
+        if ( e820_map[i - 1].type < e820_map[i].type )
+            e820_swap_entries(i - 1, i);
+        if ( e820_map[i - 1].size >= e820_map[i].size )
+        {
+            e820_remove_entry(i);
+            i--;
+        }
+        else
+        {
+            start = e820_map[i].addr + e820_map[i - 1].size;
+            end = e820_map[i].addr + e820_map[i].size;
+            type = e820_map[i].type;
+            e820_remove_entry(i);
+            e820_insert_entry(start, end - start, type);
+        }
+    }
+
+    /* Merge adjacent entries. */
+    for ( i = 0; i < e820_entries - 1; i++ )
+    {
+        if ( e820_map[i].type == e820_map[i + 1].type &&
+             e820_map[i].addr + e820_map[i].size >= e820_map[i + 1].addr )
+        {
+            if ( e820_map[i].addr + e820_map[i].size <
+                 e820_map[i + 1].addr + e820_map[i + 1].size )
+            {
+                e820_map[i].size = e820_map[i + 1].addr - e820_map[i].addr +
+                                   e820_map[i + 1].size;
+            }
+            e820_remove_entry(i + 1);
+            i--;
+        }
+    }
+}
+
+/*
+ * Transform memory map into a well sorted map without any overlaps.
+ * - sort map entries by start address
+ * - handle overlaps
+ * - merge adjacent entries of same type (possibly removing boundary in the
+ *   middle of a page)
+ * - trim entries to page boundaries (depending on type either expanding
+ *   the entry or narrowing it down)
+ * - repeat first 3 sanitizing steps
+ * - make remaining temporarily reserved entries permanently reserved
+ */
+static void e820_sanitize(void)
+{
+    int i;
+    unsigned long end, start;
+
+    /* Sanitize memory map in current form. */
+    e820_process_entries();
+
+    /* Adjust map entries to page boundaries. */
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        start = e820_map[i].addr;
+        end = start + e820_map[i].size;
+        if ( (1U << e820_map[i].type) & E820_NARROW )
+        {
+            if ( start & (PAGE_SIZE - 1) )
+            {
+                start = round_pgup(start);
+                e820_insert_entry_at(i, start - PAGE_SIZE, PAGE_SIZE,
+                                     E820_TMP_RESERVED);
+                i++;
+            }
+            if ( end & (PAGE_SIZE - 1) )
+            {
+                end = round_pgdown(end);
+                e820_insert_entry_at(i + 1, end, PAGE_SIZE, E820_TMP_RESERVED);
+                i++;
+            }
+        }
+        else
+        {
+            start = round_pgdown(start);
+            end = round_pgup(end);
+        }
+        e820_map[i].addr = start;
+        e820_map[i].size = end - start;
+    }
+
+    /* Sanitize memory map (again). */
+    e820_process_entries();
+
+    /* Make remaining temporarily reserved entries permanently reserved. */
+    for ( i = 0; i < e820_entries; i++ )
+        if ( e820_map[i].type == E820_TMP_RESERVED )
+            e820_map[i].type = E820_RESERVED;
+}
+
 static void e820_get_memmap(void)
 {
     long ret;
@@ -71,6 +255,8 @@ static void e820_get_memmap(void)
         do_exit();
     }
     e820_entries = memmap.nr_entries;
+
+    e820_sanitize();
 }
 
 void arch_print_memmap(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250179.430855 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanQ-0003GF-GN; Tue, 21 Dec 2021 08:46:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250179.430855; Tue, 21 Dec 2021 08:46:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanQ-0003G1-C3; Tue, 21 Dec 2021 08:46:56 +0000
Received: by outflank-mailman (input) for mailman id 250179;
 Tue, 21 Dec 2021 08:46:54 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanO-0002z5-BS
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:54 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b55e180-623a-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id A534421106;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BA5513BEC;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mNnzHHyUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b55e180-623a-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=UOETZh2f6WeeCiugBSdED352ymyLb1Vp+v99fCDGOVo=;
	b=K+hcy7x1iKb9VYzLkL4sA69QZvp0PvKxySYlmloAtVeZRTMhdSj8eVGQS04N0xJ+Ld7obm
	xRv7sZHBRokmzx5i3PO8qJ0bp9IJUmQ/87QIPz+vC6v2CaiLk/dX/EaUc2p4yh96L/uWiF
	icnbrFHADIeXyOG/2SKNSaTodzd0VJQ=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 03/10] mini-os: don't assume contiguous RAM when initializing in PVH mode
Date: Tue, 21 Dec 2021 09:46:29 +0100
Message-Id: <20211221084636.6987-4-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Sizing the available memory should respect memory holes, so look at
the memory map when setting the boundary for the memory allocator.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
V2:
- rename "max" to "start" (Samuel Thibault)
---
 arch/x86/mm.c  |  6 +-----
 e820.c         | 14 ++++++++------
 include/e820.h |  2 +-
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8df93da..3bf6170 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -107,7 +107,6 @@ void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -117,11 +116,8 @@ void arch_mm_preinit(void *p)
         xprintk("could not get memory size\n");
         do_exit();
     }
-    last_free_pfn = ret;
 
-    max = e820_get_maxpfn();
-    if ( max < last_free_pfn )
-        last_free_pfn = max;
+    last_free_pfn = e820_get_maxpfn(ret);
 }
 #endif
 
diff --git a/e820.c b/e820.c
index 70286cb..8030f43 100644
--- a/e820.c
+++ b/e820.c
@@ -285,10 +285,10 @@ void arch_print_memmap(void)
 }
 #endif
 
-unsigned long e820_get_maxpfn(void)
+unsigned long e820_get_maxpfn(unsigned long pages)
 {
     int i;
-    unsigned long pfn, max = 0;
+    unsigned long pfns, start = 0;
 
     e820_get_memmap();
 
@@ -296,10 +296,12 @@ unsigned long e820_get_maxpfn(void)
     {
         if ( e820_map[i].type != E820_RAM )
             continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
+        pfns = e820_map[i].size >> PAGE_SHIFT;
+        start = e820_map[i].addr >> PAGE_SHIFT;
+        if ( pages <= pfns )
+            return start + pages;
+        pages -= pfns;
     }
 
-    return max;
+    return start + pfns;
 }
diff --git a/include/e820.h b/include/e820.h
index af2129f..6a57f05 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -49,6 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
-unsigned long e820_get_maxpfn(void);
+unsigned long e820_get_maxpfn(unsigned long pages);
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250184.430883 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanS-0003gV-OH; Tue, 21 Dec 2021 08:46:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250184.430883; Tue, 21 Dec 2021 08:46:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanS-0003fM-Dj; Tue, 21 Dec 2021 08:46:58 +0000
Received: by outflank-mailman (input) for mailman id 250184;
 Tue, 21 Dec 2021 08:46:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanR-0002z5-5G
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:57 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8be91413-623a-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 9AABA210FE;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 727C513BEC;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id mCPKGn2UwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8be91413-623a-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=NwQ4mRiosEanvExB6LuAnyU1/Dqqja/tWJzhJY5Y3Ms=;
	b=toWR3hQZog096RnIYPQ1YgpGL+3XJJxAKXFR7/u0lBiMX8IQz65YmqikDO2VThhMo2Tr3m
	QGM+C2XHhFTEbmPyMPCNWoSGauQPn5SGNIQF/NQb6AZvt55hcNQR2AXv5iD2Q63LhjqSzl
	Ssb+a4Zou4T5AnVmYfO6lj2lQbaarsg=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 08/10] mini-os: add proper pvh grant table handling
Date: Tue, 21 Dec 2021 09:46:34 +0100
Message-Id: <20211221084636.6987-9-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Grant table initialization for PVH requires some additional actions
compared to PV mode. Add those.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/gnttab.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
index 56e59d7..281c207 100644
--- a/arch/x86/gnttab.c
+++ b/arch/x86/gnttab.c
@@ -22,11 +22,15 @@
  */
 
 #include <mini-os/os.h>
+#include <mini-os/console.h>
+#include <mini-os/e820.h>
 #include <mini-os/hypervisor.h>
 #include <mini-os/gnttab.h>
 #include <mini-os/mm.h>
 #include <mini-os/types.h>
+#include <xen/memory.h>
 
+#ifdef CONFIG_PARAVIRT
 grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
 {
     struct gnttab_setup_table setup;
@@ -39,6 +43,33 @@ grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
     HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
     return map_frames(frames, nr_grant_frames);
 }
+#else
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    int i, rc;
+    struct xen_add_to_physmap xatp;
+    unsigned long pfn;
+    unsigned long frames[nr_grant_frames];
+
+    pfn = e820_get_reserved_pfns(nr_grant_frames);
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        xatp.domid = DOMID_SELF;
+        xatp.idx = i;
+        xatp.space = XENMAPSPACE_grant_table;
+        xatp.gpfn = pfn + i;
+        rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp);
+        if ( rc )
+        {
+            xprintk("could not init grant table\n");
+            do_exit();
+        }
+        frames[i] = pfn + i;
+    }
+
+    return map_frames(frames, nr_grant_frames);
+}
+#endif
 
 void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
 {
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250177.430841 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanP-000309-7J; Tue, 21 Dec 2021 08:46:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250177.430841; Tue, 21 Dec 2021 08:46:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanP-000302-3a; Tue, 21 Dec 2021 08:46:55 +0000
Received: by outflank-mailman (input) for mailman id 250177;
 Tue, 21 Dec 2021 08:46:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanN-0002yE-GE
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:53 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b18b320-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1B4F8210FE;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DE35313BEC;
 Tue, 21 Dec 2021 08:46:51 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id ndZENHuUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b18b320-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=U+uOMy8syfFhtMitypXYhn09cP895ccPVKrqjYHL+gw=;
	b=SQHIEkusJZx7ayncKT4nh3fqdmklpAZ3y6UU5v3MZBl0r9RCNU7oDVH3wz5MQ94QMGWiUp
	4g8Tzg/jNUIEjSvlUAAFX66jlMTVgG5YZKzegmsu316ZO7UK/IKcS282MiedasHna/7wyI
	03JCAUr3+Bt/KyZ6XvMazbPW5nQhiw4=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 00/10] mini-os: add missing PVH features
Date: Tue, 21 Dec 2021 09:46:26 +0100
Message-Id: <20211221084636.6987-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Mini-OS in PVH mode is missing some features, especially in the areas
of ballooning and grant tables.

With this series I am able to run Xenstore stubdom in PVH mode.

Changes in V3:
- two minor fixes

Changes in V2:
- multiple comments addressed

Juergen Gross (10):
  mini-os: split e820 map handling into new source file
  mini-os: sort and sanitize e820 memory map
  mini-os: don't assume contiguous RAM when initializing in PVH mode
  mini-os: respect memory map when ballooning up
  mini-os: don't repeat definition available via header file
  mini-os: add memory map service functions
  mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
  mini-os: add proper pvh grant table handling
  mini-os: prepare grantmap entry interface for use by PVH mode
  mini-os: modify grant mappings to work in PVH mode

 Makefile           |   1 +
 arch/arm/mm.c      |  11 +-
 arch/x86/balloon.c |   4 +-
 arch/x86/gnttab.c  | 109 +++++++++++++
 arch/x86/mm.c      | 121 +--------------
 arch/x86/setup.c   |   8 +-
 balloon.c          |  33 ++--
 e820.c             | 376 +++++++++++++++++++++++++++++++++++++++++++++
 gntmap.c           | 125 +++++++++------
 include/balloon.h  |   5 +-
 include/e820.h     |  11 ++
 include/gntmap.h   |   1 +
 mm.c               |   7 +-
 13 files changed, 615 insertions(+), 197 deletions(-)
 create mode 100644 arch/x86/gnttab.c
 create mode 100644 e820.c

-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250187.430905 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanU-0004B8-S6; Tue, 21 Dec 2021 08:47:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250187.430905; Tue, 21 Dec 2021 08:47:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanU-0004AK-IH; Tue, 21 Dec 2021 08:47:00 +0000
Received: by outflank-mailman (input) for mailman id 250187;
 Tue, 21 Dec 2021 08:46:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanS-0002yE-8m
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:58 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b20b9f3-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:52 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 454F81F388;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B70313E02;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id KJN2BXyUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b20b9f3-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Cvjzn61nlQz/5cNRGk/V3qCPy6sEZi3f9w8y3gbMdqw=;
	b=fa8B1tQDlQXQ4Zt907exiM6Ql2bQhOqA1zwNXh83f22gymhDvkN6ex5NyHRm8Xje0g1RF/
	zO77Ntx1TsENJ1Q3imQwrB/gNxiaKA1BhSlTiz8foW9/jrzSrJplsJUYgRwyyDrKS0V1pu
	DaQT7mYXn6HwUg4s970wqufVJaGqoTQ=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 01/10] mini-os: split e820 map handling into new source file
Date: Tue, 21 Dec 2021 09:46:27 +0100
Message-Id: <20211221084636.6987-2-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Introduce e820.c containing all the E820 memory map handling.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 Makefile       |   1 +
 arch/arm/mm.c  |   8 ----
 arch/x86/mm.c  |  70 +----------------------------
 e820.c         | 119 +++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |   6 +++
 5 files changed, 128 insertions(+), 76 deletions(-)
 create mode 100644 e820.c

diff --git a/Makefile b/Makefile
index 4b76b55..06b60fc 100644
--- a/Makefile
+++ b/Makefile
@@ -41,6 +41,7 @@ src-$(CONFIG_TPMFRONT) += tpmfront.c
 src-$(CONFIG_TPM_TIS) += tpm_tis.c
 src-$(CONFIG_TPMBACK) += tpmback.c
 src-y += daytime.c
+src-y += e820.c
 src-y += events.c
 src-$(CONFIG_FBFRONT) += fbfront.c
 src-y += gntmap.c
diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index f806c9f..9068166 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -7,14 +7,6 @@
 #include <lib.h>
 
 uint32_t physical_address_offset;
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
 
 unsigned long allocate_ondemand(unsigned long n, unsigned long alignment)
 {
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 8ba14a5..8df93da 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -64,15 +64,6 @@ extern char stack[];
 extern void page_walk(unsigned long va);
 
 #ifdef CONFIG_PARAVIRT
-struct e820entry e820_map[1] = {
-    {
-        .addr = 0,
-        .size = ULONG_MAX - 1,
-        .type = E820_RAM
-    }
-};
-unsigned e820_entries = 1;
-
 void arch_mm_preinit(void *p)
 {
     start_info_t *si = p;
@@ -112,25 +103,11 @@ desc_ptr idt_ptr =
     .base = (unsigned long)&idt,
 };
 
-struct e820entry e820_map[E820_MAX];
-unsigned e820_entries;
-
-static char *e820_types[E820_TYPES] = {
-    [E820_RAM]      = "RAM",
-    [E820_RESERVED] = "Reserved",
-    [E820_ACPI]     = "ACPI",
-    [E820_NVS]      = "NVS",
-    [E820_UNUSABLE] = "Unusable",
-    [E820_PMEM]     = "PMEM"
-};
-
 void arch_mm_preinit(void *p)
 {
     long ret;
     domid_t domid = DOMID_SELF;
-    struct xen_memory_map memmap;
-    int i;
-    unsigned long pfn, max = 0;
+    unsigned long max;
 
     pt_base = page_table_base;
     first_free_pfn = PFN_UP(to_phys(&_end));
@@ -142,53 +119,10 @@ void arch_mm_preinit(void *p)
     }
     last_free_pfn = ret;
 
-    memmap.nr_entries = E820_MAX;
-    set_xen_guest_handle(memmap.buffer, e820_map);
-    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
-    if ( ret < 0 )
-    {
-        xprintk("could not get memory map\n");
-        do_exit();
-    }
-    e820_entries = memmap.nr_entries;
-
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type != E820_RAM )
-            continue;
-        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
-        if ( pfn > max )
-            max = pfn;
-    }
-
+    max = e820_get_maxpfn();
     if ( max < last_free_pfn )
         last_free_pfn = max;
 }
-
-void arch_print_memmap(void)
-{
-    int i;
-    unsigned long from, to;
-    char *type;
-    char buf[12];
-
-    printk("Memory map:\n");
-    for ( i = 0; i < e820_entries; i++ )
-    {
-        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
-        {
-            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
-            type = buf;
-        }
-        else
-        {
-            type = e820_types[e820_map[i].type];
-        }
-        from = e820_map[i].addr;
-        to = from + e820_map[i].size - 1;
-        printk("%012lx-%012lx: %s\n", from, to, type);
-    }
-}
 #endif
 
 /*
diff --git a/e820.c b/e820.c
new file mode 100644
index 0000000..2165280
--- /dev/null
+++ b/e820.c
@@ -0,0 +1,119 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/types.h>
+#include <mini-os/lib.h>
+#include <mini-os/console.h>
+#include <mini-os/os.h>
+#include <mini-os/posix/limits.h>
+#include <mini-os/e820.h>
+#include <xen/memory.h>
+
+#ifdef CONFIG_E820_TRIVIAL
+struct e820entry e820_map[1] = {
+    {
+        .addr = 0,
+        .size = ULONG_MAX - 1,
+        .type = E820_RAM
+    }
+};
+
+unsigned e820_entries = 1;
+
+static void e820_get_memmap(void)
+{
+}
+
+#else
+struct e820entry e820_map[E820_MAX];
+unsigned e820_entries;
+
+static char *e820_types[E820_TYPES] = {
+    [E820_RAM]      = "RAM",
+    [E820_RESERVED] = "Reserved",
+    [E820_ACPI]     = "ACPI",
+    [E820_NVS]      = "NVS",
+    [E820_UNUSABLE] = "Unusable",
+    [E820_PMEM]     = "PMEM"
+};
+
+static void e820_get_memmap(void)
+{
+    long ret;
+    struct xen_memory_map memmap;
+
+    memmap.nr_entries = E820_MAX;
+    set_xen_guest_handle(memmap.buffer, e820_map);
+    ret = HYPERVISOR_memory_op(XENMEM_memory_map, &memmap);
+    if ( ret < 0 )
+    {
+        xprintk("could not get memory map\n");
+        do_exit();
+    }
+    e820_entries = memmap.nr_entries;
+}
+
+void arch_print_memmap(void)
+{
+    int i;
+    unsigned long from, to;
+    char *type;
+    char buf[12];
+
+    printk("Memory map:\n");
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type >= E820_TYPES || !e820_types[e820_map[i].type] )
+        {
+            snprintf(buf, sizeof(buf), "%8x", e820_map[i].type);
+            type = buf;
+        }
+        else
+        {
+            type = e820_types[e820_map[i].type];
+        }
+        from = e820_map[i].addr;
+        to = from + e820_map[i].size - 1;
+        printk("%012lx-%012lx: %s\n", from, to, type);
+    }
+}
+#endif
+
+unsigned long e820_get_maxpfn(void)
+{
+    int i;
+    unsigned long pfn, max = 0;
+
+    e820_get_memmap();
+
+    for ( i = 0; i < e820_entries; i++ )
+    {
+        if ( e820_map[i].type != E820_RAM )
+            continue;
+        pfn = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        if ( pfn > max )
+            max = pfn;
+    }
+
+    return max;
+}
diff --git a/include/e820.h b/include/e820.h
index 920551c..af2129f 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -24,6 +24,10 @@
 #ifndef __E820_HEADER
 #define __E820_HEADER
 
+#if defined(__arm__) || defined(__aarch64__) || defined(CONFIG_PARAVIRT)
+#define CONFIG_E820_TRIVIAL
+#endif
+
 /* PC BIOS standard E820 types and structure. */
 #define E820_RAM          1
 #define E820_RESERVED     2
@@ -45,4 +49,6 @@ struct __packed e820entry {
 extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
+unsigned long e820_get_maxpfn(void);
+
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250188.430913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanV-0004Kz-LW; Tue, 21 Dec 2021 08:47:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250188.430913; Tue, 21 Dec 2021 08:47:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanV-0004Is-9U; Tue, 21 Dec 2021 08:47:01 +0000
Received: by outflank-mailman (input) for mailman id 250188;
 Tue, 21 Dec 2021 08:46:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanT-0002z5-5U
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:46:59 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c057068-623a-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 09:46:54 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id CA6711F3B6;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A0D1B13BEC;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id yHzgJX2UwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c057068-623a-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VFqq/QNK2D+xIQFRd42TWwa5OQ2iSim/015QEF+tkx0=;
	b=py3Ua/EMWwloebQRKZoMF3+usUlu4h4yJhdL87S5KIZ9xfqVpY5OHrcvMBovHdVmZTSKZX
	8FjMDQRmqcqIKHwIQBjhaR9CTHHp690IyDqjXizB/TZ2/He+pI+BviFQIGNwcomvAdztj8
	H+S0Cq+6m8+7jSJK2xYFXoYjK1JXD1Y=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 09/10] mini-os: prepare grantmap entry interface for use by PVH mode
Date: Tue, 21 Dec 2021 09:46:35 +0100
Message-Id: <20211221084636.6987-10-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Instead of passing the pointer of a grantmap entry to the
_gntmap_[un]map_grant_ref() sub-functions use the map pointer and the
entry index instead. This will be needed for PVH mode usage.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 gntmap.c | 48 +++++++++++++++++++++++-------------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index f6ab3ad..7ae8fe6 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -55,36 +55,34 @@ struct gntmap_entry {
 };
 
 static inline int
-gntmap_entry_used(struct gntmap_entry *entry)
+gntmap_entry_used(struct gntmap *map, int idx)
 {
-    return entry->host_addr != 0;
+    return map->entries[idx].host_addr != 0;
 }
 
-static struct gntmap_entry*
-gntmap_find_free_entry(struct gntmap *map)
+static int gntmap_find_free_entry(struct gntmap *map)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
-        if (!gntmap_entry_used(&map->entries[i]))
-            return &map->entries[i];
+        if (!gntmap_entry_used(map, i))
+            return i;
     }
 
     DEBUG("(map=%p): all %d entries full",
            map, map->nentries);
-    return NULL;
+    return -1;
 }
 
-static struct gntmap_entry*
-gntmap_find_entry(struct gntmap *map, unsigned long addr)
+static int gntmap_find_entry(struct gntmap *map, unsigned long addr)
 {
     int i;
 
     for (i = 0; i < map->nentries; i++) {
         if (map->entries[i].host_addr == addr)
-            return &map->entries[i];
+            return i;
     }
-    return NULL;
+    return -1;
 }
 
 int
@@ -105,12 +103,13 @@ gntmap_set_max_grants(struct gntmap *map, int count)
 }
 
 static int
-_gntmap_map_grant_ref(struct gntmap_entry *entry, 
+_gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
                       uint32_t domid,
                       uint32_t ref,
                       int writable)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
 
@@ -135,8 +134,9 @@ _gntmap_map_grant_ref(struct gntmap_entry *entry,
 }
 
 static int
-_gntmap_unmap_grant_ref(struct gntmap_entry *entry)
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
 {
+    struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_unmap_grant_ref op;
     int rc;
 
@@ -160,19 +160,19 @@ int
 gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
 {
     int i, rc;
-    struct gntmap_entry *ent;
+    int idx;
 
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
-        if (ent == NULL) {
+        idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
+        if (idx < 0) {
             printk("gntmap: tried to munmap unknown page\n");
             return -EINVAL;
         }
 
-        rc = _gntmap_unmap_grant_ref(ent);
+        rc = _gntmap_unmap_grant_ref(map, idx);
         if (rc != 0)
             return rc;
     }
@@ -189,7 +189,7 @@ gntmap_map_grant_refs(struct gntmap *map,
                       int writable)
 {
     unsigned long addr;
-    struct gntmap_entry *ent;
+    int idx;
     int i;
 
     DEBUG("(map=%p, count=%" PRIu32 ", "
@@ -206,9 +206,9 @@ gntmap_map_grant_refs(struct gntmap *map,
         return NULL;
 
     for (i = 0; i < count; i++) {
-        ent = gntmap_find_free_entry(map);
-        if (ent == NULL ||
-            _gntmap_map_grant_ref(ent,
+        idx = gntmap_find_free_entry(map);
+        if (idx < 0 ||
+            _gntmap_map_grant_ref(map, idx,
                                   addr + PAGE_SIZE * i,
                                   domids[i * domids_stride],
                                   refs[i],
@@ -233,15 +233,13 @@ gntmap_init(struct gntmap *map)
 void
 gntmap_fini(struct gntmap *map)
 {
-    struct gntmap_entry *ent;
     int i;
 
     DEBUG("(map=%p)", map);
 
     for (i = 0; i < map->nentries; i++) {
-        ent = &map->entries[i];
-        if (gntmap_entry_used(ent))
-            (void) _gntmap_unmap_grant_ref(ent);
+        if (gntmap_entry_used(map, i))
+            (void) _gntmap_unmap_grant_ref(map, i);
     }
 
     xfree(map->entries);
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250191.430928 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanX-0004Y4-34; Tue, 21 Dec 2021 08:47:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250191.430928; Tue, 21 Dec 2021 08:47:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanW-0004VJ-CR; Tue, 21 Dec 2021 08:47:02 +0000
Received: by outflank-mailman (input) for mailman id 250191;
 Tue, 21 Dec 2021 08:47:00 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanU-0002yE-9F
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:47:00 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b9b42a0-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 0D6AD1F3B8;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D923913E02;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id cDrRM3yUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b9b42a0-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=VPgUZQEXWMjuiDqJWRTGWtw72dHgK1/ZM2te4tasytk=;
	b=aSoZNdrwNngkftb9vRyT0Tgl6iYG9pMY7oN8BFJ/KQJicMhyy+wxXQePW1Ttf30oHdA1fR
	s1QDTXkGOVmk4FqGz/qMr1yU3LO3deBY2VRHKCLGhYE329bKD/TPFzOYDTOsom1gN9SQGK
	loar0Q4wvHrEuTPnbZk0gIvhBIAoNZA=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 05/10] mini-os: don't repeat definition available via header file
Date: Tue, 21 Dec 2021 09:46:31 +0100
Message-Id: <20211221084636.6987-6-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

arch/x86/setup.c is repeating the definition of __pte() instead using
the appropriate header. Fix that.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/setup.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/x86/setup.c b/arch/x86/setup.c
index 1ec68d3..b27bbed 100644
--- a/arch/x86/setup.c
+++ b/arch/x86/setup.c
@@ -29,6 +29,7 @@
 #include <mini-os/os.h>
 #include <mini-os/lib.h> /* for printk, memcpy */
 #include <mini-os/kernel.h>
+#include <mini-os/hypervisor.h>
 #include <xen/xen.h>
 #include <xen/arch-x86/cpuid.h>
 #include <xen/arch-x86/hvm/start_info.h>
@@ -61,13 +62,6 @@ char stack[2*STACK_SIZE];
 
 extern char shared_info[PAGE_SIZE];
 
-#if defined(__x86_64__)
-#define __pte(x) ((pte_t) { (x) } )
-#else
-#define __pte(x) ({ unsigned long long _x = (x);        \
-    ((pte_t) {(unsigned long)(_x), (unsigned long)(_x>>32)}); })
-#endif
-
 static inline void fpu_init(void) {
 	asm volatile("fninit");
 }
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250192.430933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanX-0004mw-Pr; Tue, 21 Dec 2021 08:47:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250192.430933; Tue, 21 Dec 2021 08:47:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanX-0004id-Ak; Tue, 21 Dec 2021 08:47:03 +0000
Received: by outflank-mailman (input) for mailman id 250192;
 Tue, 21 Dec 2021 08:47:01 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanV-0002z5-5i
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:47:01 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8c2aae34-623a-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 09:46:54 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 1143521106;
 Tue, 21 Dec 2021 08:46:54 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CFBDF13BEC;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id wAh0MX2UwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8c2aae34-623a-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076414; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=2zdQgzlV0Lz7UQXRFdnEwu37UxJwIePFbmpJgrcmrrs=;
	b=km1hd/hcAwn5S/3yJHlr/WcnHQ4YQD+O7shAA5ihsxw4YOGkaPUqTnFZ+crwtIwm/pa0a+
	wZwgjA2zKOf8MpBk9VB+H26114WblOoZrvPI2Bo7fc5+B0xU5hQHNpjYxzeSXnBlMqMlAh
	PVCkjUpQN5ip2Bc6vGMUabWVz7ESYXk=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 10/10] mini-os: modify grant mappings to work in PVH mode
Date: Tue, 21 Dec 2021 09:46:36 +0100
Message-Id: <20211221084636.6987-11-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

For being able to use the grant mapping interface in PVH mode some
changes are required, as the guest needs to specify a physical address
in the hypercall interface.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 gntmap.c         | 81 ++++++++++++++++++++++++++++++++++--------------
 include/gntmap.h |  1 +
 2 files changed, 59 insertions(+), 23 deletions(-)

diff --git a/gntmap.c b/gntmap.c
index 7ae8fe6..126b04f 100644
--- a/gntmap.c
+++ b/gntmap.c
@@ -32,6 +32,7 @@
 
 #include <mini-os/os.h>
 #include <mini-os/lib.h>
+#include <mini-os/e820.h>
 #include <mini-os/xmalloc.h>
 #include <errno.h>
 #include <xen/grant_table.h>
@@ -97,11 +98,42 @@ gntmap_set_max_grants(struct gntmap *map, int count)
     if (map->entries == NULL)
         return -ENOMEM;
 
+#ifndef CONFIG_PARAVIRT
+    map->start_pfn = e820_get_reserved_pfns(count);
+#endif
+
     memset(map->entries, 0, sizeof(struct gntmap_entry) * count);
     map->nentries = count;
     return 0;
 }
 
+static int
+_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
+{
+    struct gntmap_entry *entry = map->entries + idx;
+    struct gnttab_unmap_grant_ref op;
+    int rc;
+
+#ifdef CONFIG_PARAVIRT
+    op.host_addr    = (uint64_t) entry->host_addr;
+#else
+    op.host_addr    = (uint64_t)(map->start_pfn + idx) << PAGE_SHIFT;
+#endif
+    op.dev_bus_addr = 0;
+    op.handle       = entry->handle;
+
+    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
+    if (rc != 0 || op.status != GNTST_okay) {
+        printk("GNTTABOP_unmap_grant_ref failed: "
+               "returned %d, status %" PRId16 "\n",
+               rc, op.status);
+        return rc != 0 ? rc : op.status;
+    }
+
+    entry->host_addr = 0;
+    return 0;
+}
+
 static int
 _gntmap_map_grant_ref(struct gntmap *map, int idx,
                       unsigned long host_addr,
@@ -112,10 +144,17 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
     struct gntmap_entry *entry = map->entries + idx;
     struct gnttab_map_grant_ref op;
     int rc;
+#ifndef CONFIG_PARAVIRT
+    unsigned long pfn = map->start_pfn + idx;
+#endif
 
     op.ref = (grant_ref_t) ref;
     op.dom = (domid_t) domid;
+#ifdef CONFIG_PARAVIRT
     op.host_addr = (uint64_t) host_addr;
+#else
+    op.host_addr = (uint64_t)pfn << PAGE_SHIFT; 
+#endif
     op.flags = GNTMAP_host_map;
     if (!writable)
         op.flags |= GNTMAP_readonly;
@@ -128,31 +167,18 @@ _gntmap_map_grant_ref(struct gntmap *map, int idx,
         return rc != 0 ? rc : op.status;
     }
 
-    entry->host_addr = host_addr;
-    entry->handle = op.handle;
-    return 0;
-}
-
-static int
-_gntmap_unmap_grant_ref(struct gntmap *map, int idx)
-{
-    struct gntmap_entry *entry = map->entries + idx;
-    struct gnttab_unmap_grant_ref op;
-    int rc;
-
-    op.host_addr    = (uint64_t) entry->host_addr;
-    op.dev_bus_addr = 0;
-    op.handle       = entry->handle;
-
-    rc = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, &op, 1);
-    if (rc != 0 || op.status != GNTST_okay) {
-        printk("GNTTABOP_unmap_grant_ref failed: "
-               "returned %d, status %" PRId16 "\n",
-               rc, op.status);
-        return rc != 0 ? rc : op.status;
+#ifndef CONFIG_PARAVIRT
+    rc = do_map_frames(host_addr, &pfn, 1, 0, 0, DOMID_SELF, NULL,
+                       writable ? L1_PROT : L1_PROT_RO);
+    if ( rc )
+    {
+        _gntmap_unmap_grant_ref(map, idx);
+        return rc;
     }
+#endif
 
-    entry->host_addr = 0;
+    entry->host_addr = host_addr;
+    entry->handle = op.handle;
     return 0;
 }
 
@@ -165,6 +191,10 @@ gntmap_munmap(struct gntmap *map, unsigned long start_address, int count)
     DEBUG("(map=%p, start_address=%lx, count=%d)",
            map, start_address, count);
 
+#ifndef CONFIG_PARAVIRT
+    unmap_frames(start_address, count);
+#endif
+
     for (i = 0; i < count; i++) {
         idx = gntmap_find_entry(map, start_address + PAGE_SIZE * i);
         if (idx < 0) {
@@ -242,6 +272,11 @@ gntmap_fini(struct gntmap *map)
             (void) _gntmap_unmap_grant_ref(map, i);
     }
 
+#ifndef CONFIG_PARAVIRT
+    e820_put_reserved_pfns(map->start_pfn, map->nentries);
+    map->start_pfn = 0;
+#endif
+
     xfree(map->entries);
     map->entries = NULL;
     map->nentries = 0;
diff --git a/include/gntmap.h b/include/gntmap.h
index fde53f3..d3d7e88 100644
--- a/include/gntmap.h
+++ b/include/gntmap.h
@@ -10,6 +10,7 @@
 struct gntmap {
     int nentries;
     struct gntmap_entry *entries;
+    unsigned long start_pfn;
 };
 
 int
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:47:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:47:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250193.430939 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanY-0004y7-EY; Tue, 21 Dec 2021 08:47:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250193.430939; Tue, 21 Dec 2021 08:47:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzanY-0004v8-49; Tue, 21 Dec 2021 08:47:04 +0000
Received: by outflank-mailman (input) for mailman id 250193;
 Tue, 21 Dec 2021 08:47:01 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanV-0002yE-9F
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:47:01 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8b7a08f9-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id D46A31F3A6;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ABE9513BEC;
 Tue, 21 Dec 2021 08:46:52 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id SGmyKHyUwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:52 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b7a08f9-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076412; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Re/Y81QPVsmb4huxIK864YtWHyj0GbHOxxQ8cDq1GGE=;
	b=Mfrv1lJy+dqaaiGaP9d3hiugLOv7FGKQy3VpDcnzqICvE8JgzAtISoxngcE0mWGgL/Ds4T
	OnYA5ETKwVe//bIhMtXU6KJmmdvNlFNby+tVxCNiMMPfElPBj5XzlC0WbFbGEaODkDZjkR
	TxQ74K3Oq77dhzzrUKv+831L82dSIwg=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 04/10] mini-os: respect memory map when ballooning up
Date: Tue, 21 Dec 2021 09:46:30 +0100
Message-Id: <20211221084636.6987-5-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Today Mini-OS won't look at the memory map when ballooning up. This can
result in problems for PVH domains with more than 4 GB of RAM, as
ballooning will happily run into the ACPI area.

Fix that by adding only pages being marked as RAM in the memory map and
by distinguishing between the current number of RAM pages and the first
unallocated page.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
V2:
- rename and fix e820_get_max_pages() (Samuel Thibault)
V3:
- fix loop condition
---
 arch/arm/mm.c      |  3 +++
 arch/x86/balloon.c |  4 ++--
 arch/x86/mm.c      |  2 ++
 balloon.c          | 33 ++++++++++++++++++++++++---------
 e820.c             | 21 ++++++++++++++++++++-
 include/balloon.h  |  5 +++--
 include/e820.h     |  1 +
 mm.c               |  7 ++-----
 8 files changed, 57 insertions(+), 19 deletions(-)

diff --git a/arch/arm/mm.c b/arch/arm/mm.c
index 9068166..11962f8 100644
--- a/arch/arm/mm.c
+++ b/arch/arm/mm.c
@@ -3,6 +3,7 @@
 #include <arch_mm.h>
 #include <mini-os/errno.h>
 #include <mini-os/hypervisor.h>
+#include <mini-os/balloon.h>
 #include <libfdt.h>
 #include <lib.h>
 
@@ -70,6 +71,8 @@ void arch_init_mm(unsigned long *start_pfn_p, unsigned long *max_pfn_p)
     }
     device_tree = new_device_tree;
     *max_pfn_p = to_phys(new_device_tree) >> PAGE_SHIFT;
+
+    balloon_set_nr_pages(*max_pfn_p, *max_pfn_p);
 }
 
 void arch_init_demand_mapping_area(void)
diff --git a/arch/x86/balloon.c b/arch/x86/balloon.c
index 10b440c..fe79644 100644
--- a/arch/x86/balloon.c
+++ b/arch/x86/balloon.c
@@ -61,10 +61,10 @@ void arch_remap_p2m(unsigned long max_pfn)
     p2m_invalidate(l2_list, L2_P2M_IDX(max_pfn - 1) + 1);
     p2m_invalidate(l1_list, L1_P2M_IDX(max_pfn - 1) + 1);
 
-    if ( p2m_pages(nr_max_pages) <= p2m_pages(max_pfn) )
+    if ( p2m_pages(nr_max_pfn) <= p2m_pages(max_pfn) )
         return;
 
-    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pages));
+    new_p2m = alloc_virt_kernel(p2m_pages(nr_max_pfn));
     for ( pfn = 0; pfn < max_pfn; pfn += P2M_ENTRIES )
     {
         map_frame_rw(new_p2m + PAGE_SIZE * (pfn / P2M_ENTRIES),
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index 3bf6170..c30d8bc 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -72,6 +72,7 @@ void arch_mm_preinit(void *p)
     pt_base = (pgentry_t *)si->pt_base;
     first_free_pfn = PFN_UP(to_phys(pt_base)) + si->nr_pt_frames;
     last_free_pfn = si->nr_pages;
+    balloon_set_nr_pages(last_free_pfn, last_free_pfn);
 }
 #else
 #include <mini-os/desc.h>
@@ -118,6 +119,7 @@ void arch_mm_preinit(void *p)
     }
 
     last_free_pfn = e820_get_maxpfn(ret);
+    balloon_set_nr_pages(ret, last_free_pfn);
 }
 #endif
 
diff --git a/balloon.c b/balloon.c
index 5676d3b..9dc77c5 100644
--- a/balloon.c
+++ b/balloon.c
@@ -23,14 +23,24 @@
 
 #include <mini-os/os.h>
 #include <mini-os/balloon.h>
+#include <mini-os/e820.h>
 #include <mini-os/errno.h>
 #include <mini-os/lib.h>
 #include <mini-os/paravirt.h>
 #include <xen/xen.h>
 #include <xen/memory.h>
 
-unsigned long nr_max_pages;
-unsigned long nr_mem_pages;
+unsigned long nr_max_pfn;
+
+static unsigned long nr_max_pages;
+static unsigned long nr_mem_pfn;
+static unsigned long nr_mem_pages;
+
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn)
+{
+    nr_mem_pages = pages;
+    nr_mem_pfn = pfn;
+}
 
 void get_max_pages(void)
 {
@@ -46,16 +56,18 @@ void get_max_pages(void)
 
     nr_max_pages = ret;
     printk("Maximum memory size: %ld pages\n", nr_max_pages);
+
+    nr_max_pfn = e820_get_maxpfn(nr_max_pages);
 }
 
 void mm_alloc_bitmap_remap(void)
 {
     unsigned long i, new_bitmap;
 
-    if ( mm_alloc_bitmap_size >= ((nr_max_pages + 1) >> 3) )
+    if ( mm_alloc_bitmap_size >= ((nr_max_pfn + 1) >> 3) )
         return;
 
-    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pages + 1) >> 3));
+    new_bitmap = alloc_virt_kernel(PFN_UP((nr_max_pfn + 1) >> 3));
     for ( i = 0; i < mm_alloc_bitmap_size; i += PAGE_SIZE )
     {
         map_frame_rw(new_bitmap + i,
@@ -70,7 +82,7 @@ static unsigned long balloon_frames[N_BALLOON_FRAMES];
 
 int balloon_up(unsigned long n_pages)
 {
-    unsigned long page, pfn;
+    unsigned long page, pfn, start_pfn;
     int rc;
     struct xen_memory_reservation reservation = {
         .domid        = DOMID_SELF
@@ -81,8 +93,11 @@ int balloon_up(unsigned long n_pages)
     if ( n_pages > N_BALLOON_FRAMES )
         n_pages = N_BALLOON_FRAMES;
 
+    start_pfn = e820_get_maxpfn(nr_mem_pages + 1) - 1;
+    n_pages = e820_get_max_contig_pages(start_pfn, n_pages);
+
     /* Resize alloc_bitmap if necessary. */
-    while ( mm_alloc_bitmap_size * 8 < nr_mem_pages + n_pages )
+    while ( mm_alloc_bitmap_size * 8 < start_pfn + n_pages )
     {
         page = alloc_page();
         if ( !page )
@@ -99,14 +114,14 @@ int balloon_up(unsigned long n_pages)
         mm_alloc_bitmap_size += PAGE_SIZE;
     }
 
-    rc = arch_expand_p2m(nr_mem_pages + n_pages);
+    rc = arch_expand_p2m(start_pfn + n_pages);
     if ( rc )
         return rc;
 
     /* Get new memory from hypervisor. */
     for ( pfn = 0; pfn < n_pages; pfn++ )
     {
-        balloon_frames[pfn] = nr_mem_pages + pfn;
+        balloon_frames[pfn] = start_pfn + pfn;
     }
     set_xen_guest_handle(reservation.extent_start, balloon_frames);
     reservation.nr_extents = n_pages;
@@ -116,7 +131,7 @@ int balloon_up(unsigned long n_pages)
 
     for ( pfn = 0; pfn < rc; pfn++ )
     {
-        arch_pfn_add(nr_mem_pages + pfn, balloon_frames[pfn]);
+        arch_pfn_add(start_pfn + pfn, balloon_frames[pfn]);
         free_page(pfn_to_virt(nr_mem_pages + pfn));
     }
 
diff --git a/e820.c b/e820.c
index 8030f43..2a371c7 100644
--- a/e820.c
+++ b/e820.c
@@ -290,7 +290,8 @@ unsigned long e820_get_maxpfn(unsigned long pages)
     int i;
     unsigned long pfns, start = 0;
 
-    e820_get_memmap();
+    if ( !e820_entries )
+        e820_get_memmap();
 
     for ( i = 0; i < e820_entries; i++ )
     {
@@ -305,3 +306,21 @@ unsigned long e820_get_maxpfn(unsigned long pages)
 
     return start + pfns;
 }
+
+unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages)
+{
+    int i;
+    unsigned long end;
+
+    for ( i = 0; i < e820_entries && e820_map[i].addr <= (pfn << PAGE_SHIFT);
+          i++ )
+    {
+        end = (e820_map[i].addr + e820_map[i].size) >> PAGE_SHIFT;
+        if ( e820_map[i].type != E820_RAM || end <= pfn )
+            continue;
+
+        return ((end - pfn) > pages) ? pages : end - pfn;
+    }
+
+    return 0;
+}
diff --git a/include/balloon.h b/include/balloon.h
index 6cfec4f..8f7c8bd 100644
--- a/include/balloon.h
+++ b/include/balloon.h
@@ -32,11 +32,11 @@
  */
 #define BALLOON_EMERGENCY_PAGES   64
 
-extern unsigned long nr_max_pages;
-extern unsigned long nr_mem_pages;
+extern unsigned long nr_max_pfn;
 
 void get_max_pages(void);
 int balloon_up(unsigned long n_pages);
+void balloon_set_nr_pages(unsigned long pages, unsigned long pfn);
 
 void mm_alloc_bitmap_remap(void);
 void arch_pfn_add(unsigned long pfn, unsigned long mfn);
@@ -50,6 +50,7 @@ static inline int chk_free_pages(unsigned long needed)
 {
     return needed <= nr_free_pages;
 }
+static inline balloon_set_nr_pages(unsigned long pages, unsigned long pfn) { }
 
 #endif /* CONFIG_BALLOON */
 #endif /* _BALLOON_H_ */
diff --git a/include/e820.h b/include/e820.h
index 6a57f05..8d4d371 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -50,5 +50,6 @@ extern struct e820entry e820_map[];
 extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
+unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages);
 
 #endif /*__E820_HEADER*/
diff --git a/mm.c b/mm.c
index 932ceeb..6493bdd 100644
--- a/mm.c
+++ b/mm.c
@@ -396,8 +396,9 @@ void init_mm(void)
 
     printk("MM: Init\n");
 
-    get_max_pages();
     arch_init_mm(&start_pfn, &max_pfn);
+    get_max_pages();
+
     /*
      * now we can initialise the page allocator
      */
@@ -407,10 +408,6 @@ void init_mm(void)
     arch_init_p2m(max_pfn);
     
     arch_init_demand_mapping_area();
-
-#ifdef CONFIG_BALLOON
-    nr_mem_pages = max_pfn;
-#endif
 }
 
 void fini_mm(void)
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:49:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:49:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250210.430976 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzapY-0000a0-Sf; Tue, 21 Dec 2021 08:49:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250210.430976; Tue, 21 Dec 2021 08:49:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzapY-0000Zt-PU; Tue, 21 Dec 2021 08:49:08 +0000
Received: by outflank-mailman (input) for mailman id 250210;
 Tue, 21 Dec 2021 08:49:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzanY-0002yE-9m
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:47:04 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bb37657-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 3E1612112A;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 131F013BEC;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id +IiFA32UwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bb37657-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gkrJ2Rw3Dbpj849TiQ+tx0qwA3eebDMmjLB6sPY/E/c=;
	b=JtzdSdItfXsN2W9sNhfn78CilA/vDshhfL6A7w5J/GMrEmXsafdjaf32zzblrYqBd28cQR
	gD4N1ykB7jzpvw3lkVevqfNkhWTxWO95SEdJZWWv/numj2RrD4ZbOYzVEl3hRAlh9uYZEe
	LcKfXWk/STHgeAYpXdwJ9w6eYhhsHPI=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 06/10] mini-os: add memory map service functions
Date: Tue, 21 Dec 2021 09:46:32 +0100
Message-Id: <20211221084636.6987-7-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Add two functions for adding reserved areas to the memory map and
for removing them again.

Those will be needed for proper grant table/mapping support in PVH
mode.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
V2:
- fix e820_put_reserved_pfns() (Samuel Thibault)
---
 e820.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
 include/e820.h |  4 ++++
 2 files changed, 54 insertions(+)

diff --git a/e820.c b/e820.c
index 2a371c7..df29097 100644
--- a/e820.c
+++ b/e820.c
@@ -283,6 +283,56 @@ void arch_print_memmap(void)
         printk("%012lx-%012lx: %s\n", from, to, type);
     }
 }
+
+unsigned long e820_get_reserved_pfns(int pages)
+{
+    int i;
+    unsigned long last = 0, needed = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0; i < e820_entries && e820_map[i].addr < last + needed; i++ )
+        last = e820_map[i].addr + e820_map[i].size;
+
+    if ( i == 0 || e820_map[i - 1].type != E820_RESERVED )
+        e820_insert_entry_at(i, last, needed, E820_RESERVED);
+    else
+        e820_map[i - 1].size += needed;
+
+    return last >> PAGE_SHIFT;
+}
+
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages)
+{
+    int i;
+    unsigned long addr = start_pfn << PAGE_SHIFT;
+    unsigned long size = (long)pages << PAGE_SHIFT;
+
+    for ( i = 0;
+          i < e820_entries && addr >= e820_map[i].addr + e820_map[i].size;
+          i++ );
+
+    BUG_ON(i == e820_entries || e820_map[i].type != E820_RESERVED ||
+           addr + size > e820_map[i].addr + e820_map[i].size);
+
+    if ( addr == e820_map[i].addr )
+    {
+        e820_map[i].addr += size;
+        e820_map[i].size -= size;
+        if ( e820_map[i].size == 0 )
+            e820_remove_entry(i);
+        return;
+    }
+
+    if ( addr + size == e820_map[i].addr + e820_map[i].size )
+    {
+        e820_map[i].size -= size;
+        return;
+    }
+
+    e820_insert_entry_at(i + 1, addr + size,
+                         e820_map[i].addr + e820_map[i].size - addr - size,
+                         E820_RESERVED);
+    e820_map[i].size = addr - e820_map[i].addr;
+}
 #endif
 
 unsigned long e820_get_maxpfn(unsigned long pages)
diff --git a/include/e820.h b/include/e820.h
index 8d4d371..aaf2f2c 100644
--- a/include/e820.h
+++ b/include/e820.h
@@ -51,5 +51,9 @@ extern unsigned e820_entries;
 
 unsigned long e820_get_maxpfn(unsigned long pages);
 unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages);
+#ifndef CONFIG_E820_TRIVIAL
+unsigned long e820_get_reserved_pfns(int pages);
+void e820_put_reserved_pfns(unsigned long start_pfn, int pages);
+#endif
 
 #endif /*__E820_HEADER*/
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 08:49:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 08:49:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250212.430987 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzapk-0000wi-4h; Tue, 21 Dec 2021 08:49:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250212.430987; Tue, 21 Dec 2021 08:49:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzapk-0000wZ-1A; Tue, 21 Dec 2021 08:49:20 +0000
Received: by outflank-mailman (input) for mailman id 250212;
 Tue, 21 Dec 2021 08:49:18 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rEWG=RG=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1mzana-0002yE-A1
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 08:47:06 +0000
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8bd0e23b-623a-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 09:46:53 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out2.suse.de (Postfix) with ESMTPS id 6CF1B1F388;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 445B213BEC;
 Tue, 21 Dec 2021 08:46:53 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id gNqGD32UwWFHMAAAMHmgww
 (envelope-from <jgross@suse.com>); Tue, 21 Dec 2021 08:46:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bd0e23b-623a-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640076413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Ce+N1zGKQYy8hCldpOth9Bm5wXCCEJvD9D9LhUj9MqQ=;
	b=C+NEGzRxpqZaAzIh3PRUMHaMYnMxQpFq5PgkbgGz1JstYjKyZrQj4ErAFXufxUew0l2fdm
	ItAws4Rg/eKrhfVHyZXx82dOQmMMNiHGXTaF+/8MPYDcegUwKFioeYBGADKQQ+CuwcwAdW
	IJ3q93eJKQVd0BcZ1nNdG1HQFJVUvFE=
From: Juergen Gross <jgross@suse.com>
To: minios-devel@lists.xenproject.org,
	xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org,
	wl@xen.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 07/10] mini-os: move x86 specific gnttab coding into arch/x86/gnttab.c
Date: Tue, 21 Dec 2021 09:46:33 +0100
Message-Id: <20211221084636.6987-8-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20211221084636.6987-1-jgross@suse.com>
References: <20211221084636.6987-1-jgross@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Having grant table code in arch/x86/mm.c seems wrong. Move it to the
new file arch/x86/gnttab.c, especially as the amount of code is
expected to grow further.

While doing that replace  type casts to pte_t with the more appropriate
__pte() macro.

No functional change.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 arch/x86/gnttab.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++
 arch/x86/mm.c     | 47 ----------------------------
 2 files changed, 78 insertions(+), 47 deletions(-)
 create mode 100644 arch/x86/gnttab.c

diff --git a/arch/x86/gnttab.c b/arch/x86/gnttab.c
new file mode 100644
index 0000000..56e59d7
--- /dev/null
+++ b/arch/x86/gnttab.c
@@ -0,0 +1,78 @@
+/* -*-  Mode:C; c-basic-offset:4; tab-width:4 -*-
+ *
+ * (C) 2021 - Juergen Gross, SUSE Software Solutions Germany GmbH
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to
+ * deal in the Software without restriction, including without limitation the
+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ * sell copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <mini-os/os.h>
+#include <mini-os/hypervisor.h>
+#include <mini-os/gnttab.h>
+#include <mini-os/mm.h>
+#include <mini-os/types.h>
+
+grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+    return map_frames(frames, nr_grant_frames);
+}
+
+void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+#ifdef CONFIG_PARAVIRT
+    int i;
+
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte(0x0 << PAGE_SHIFT), UVMF_INVLPG);
+    }
+#endif
+    return;
+}
+
+void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
+{
+    struct gnttab_setup_table setup;
+    unsigned long frames[nr_grant_frames];
+#ifdef CONFIG_PARAVIRT
+    int i;
+#endif
+
+    setup.dom = DOMID_SELF;
+    setup.nr_frames = nr_grant_frames;
+    set_xen_guest_handle(setup.frame_list, frames);
+
+    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
+
+#ifdef CONFIG_PARAVIRT
+    for ( i = 0; i < nr_grant_frames; i++ )
+    {
+        HYPERVISOR_update_va_mapping((unsigned long)gnttab_table + PAGE_SIZE * i,
+                __pte((frames[i] << PAGE_SHIFT) | L1_PROT), UVMF_INVLPG);
+    }
+#endif
+}
diff --git a/arch/x86/mm.c b/arch/x86/mm.c
index c30d8bc..220c0b4 100644
--- a/arch/x86/mm.c
+++ b/arch/x86/mm.c
@@ -837,53 +837,6 @@ void arch_init_mm(unsigned long* start_pfn_p, unsigned long* max_pfn_p)
 #endif
 }
 
-grant_entry_v1_t *arch_init_gnttab(int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-    return map_frames(frames, nr_grant_frames);
-}
-
-void arch_suspend_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-#ifdef CONFIG_PARAVIRT
-    int i;
-
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){0x0<<PAGE_SHIFT}, UVMF_INVLPG);
-    }
-#endif
-    return;
-}
-
-void arch_resume_gnttab(grant_entry_v1_t *gnttab_table, int nr_grant_frames)
-{
-    struct gnttab_setup_table setup;
-    unsigned long frames[nr_grant_frames];
-#ifdef CONFIG_PARAVIRT
-    int i;
-#endif
-    setup.dom = DOMID_SELF;
-    setup.nr_frames = nr_grant_frames;
-    set_xen_guest_handle(setup.frame_list, frames);
-
-    HYPERVISOR_grant_table_op(GNTTABOP_setup_table, &setup, 1);
-
-#ifdef CONFIG_PARAVIRT
-    for (i = 0; i < nr_grant_frames; i++) {
-        HYPERVISOR_update_va_mapping((unsigned long)(((char *)gnttab_table) + PAGE_SIZE * i),
-                (pte_t){(frames[i] << PAGE_SHIFT) | L1_PROT}, UVMF_INVLPG);
-    }
-#endif
-}
-
 unsigned long alloc_virt_kernel(unsigned n_pages)
 {
     unsigned long addr;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:07:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:07:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250236.431006 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzb6Z-0003vk-OT; Tue, 21 Dec 2021 09:06:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250236.431006; Tue, 21 Dec 2021 09:06:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzb6Z-0003vd-K6; Tue, 21 Dec 2021 09:06:43 +0000
Received: by outflank-mailman (input) for mailman id 250236;
 Tue, 21 Dec 2021 09:06:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzb6X-0003vX-LQ
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:06:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f2c6f95-623d-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 10:06:40 +0100 (CET)
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur02lp2056.outbound.protection.outlook.com [104.47.6.56]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-5yioj75yMf6mNxQwcKVfpg-1; Tue, 21 Dec 2021 10:06:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4192.eurprd04.prod.outlook.com (2603:10a6:803:4c::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 09:06:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 09:06:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f2c6f95-623d-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640077600;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=gH5MbTcJvT77Z9zn+XoYH/FASY78MuQLZhpJ0wDWtJ4=;
	b=aUlR/gh+ComP8BKbcFCi8NQzCC1LdCexst0JKiCfX7Inl0awDV1C6AfC4GKiFFpY/U/Y+N
	sqEAyWX8+bxy2rhV/j4yyX+SgGSJSghPRLNP8Il2gJMerfreKRfEqAdxRbW3mf2CRVBEMO
	dQAMKPgnSCpbjI7VqzKraJu8y3I/Kkw=
X-MC-Unique: 5yioj75yMf6mNxQwcKVfpg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kaazHE1ZD/pvbxk8TYF1PYkMDk6PmCj9zBeKOIuc1c6j2oLjp+IUomdIZK3mZeDyKluTgmAA26+65EBL7lFEneqsaDY/JocMxv/YkslUPo558br/HXsr++SPnIJ3Cr2OLcTNQnNS+mLtC6f0opCWFEBu0iyLh0HkH3N1u5OEubYQ4K0OHDQ5UKLCxzRhD2EypaOaEJZ7qz+lNjWFuw9vMXNLcmMYiXTslsJoTAN38o3jts1dh+xGEzHmQogj1O8kmH/OghX8mSJBCPb80S5LdpsAoLBy0hQ5Y3cGxx4WgZZ9UsAAN7BGl7AFiO0cP+GLjDFDNx0+NS3xiduRMV9fhA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iNuiDYRPGBvoIkiCKAuooGfZ66pPh+w/mWfHJKiN/A8=;
 b=PyuLzWc3cOMgXfORehZRiKb0fhSbqvyfMQbPXZQLm7pr9TvAuVpAwzg+u9nLo/QrwFEz07kqzjzlDdILSN1z3ZJAt/mnYgNIEMV5Brn3Hj1K5/P5hCUk/If1LZPJrvX0wERKQO+HgU8SoRZR0GGXJjZEGSFYR+SSVD+qkXASQAaWKxM8wovCWA9ulMo4V9e+hS5yRYME2upb4DlY9MkV/kLREQIaIe1fLRN2Tkx3TIruiNvgXsC4CpRdlLToQu/uHKyUH2uNquWMbNR7LALsPr5fOKXRpf3WBiwmso5fAXbI0Cshz5b/D4MoKrtuSEQA1zz+j09uxwmhiM/TvKwoqg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8334f9e5-bee3-8090-595d-1d45c9af0eb0@suse.com>
Date: Tue, 21 Dec 2021 10:06:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 =?UTF-8?Q?Mateusz_M=c3=b3wka?= <mateusz.mowka@intel.com>,
 =?UTF-8?Q?Pawe=c5=82_Randzio?= <pawel.randzio@intel.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] MAINTAINERS: update TXT section
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS8PR04CA0027.eurprd04.prod.outlook.com
 (2603:10a6:20b:310::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3a4a6ce0-2148-4c76-798b-08d9c46131c0
X-MS-TrafficTypeDiagnostic: VI1PR04MB4192:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4192F26922A13C8E25A34CA0B37C9@VI1PR04MB4192.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	pQ46DtiwaR+Uas4i3EoSFUPXPWRvA/t2IntLdBSxZCbkzFuoRw9e1/jJSrJRTe4mriLoJbUiV85mNLhy61hIFQ5uQnGMCYPEb/o8Yod/JmhpesVnc0RQ2Y/CsDh6IuEkf+sMZf4dei7/v2tFyTM8xJt5DQr6XKEQNzrCoPS4LtIPscVTijb8QKcJwWCPajTMsytVnL880BdgmKEqcyGfhL0HCOkn1txhhZkGrONQi4a6Tc5OHfLH0cmJ0RHYKUl7Egp5K2vWRSiKZthPNHmJCLtcl2esBSZSn30VBwgAheOAVF+1SxRBag0LvvEWj38NdwZ8ANOO3pcIQo6hBmkmSHQU2vXIwRdTZenBM09HJ8GUBA0uwNmBUCphTuluuSy82pLNMM9Dj5s5tIZC+D6NCrJ+wALAHLh7wxIO7alLVVfxXgZ1Sg2m9uogSnd6kDXwPL5aoR8+NbVYWuNMdmU1hMaSBxpRfxx36KRVs1itUdzxetjYQaRkwHwyUP4fu32OXmmVfcSOxa8Hr9KV3ZNlm8GdIuTZlban4grfparIw3N4GZMpVvr1U3GTfmNWofxVKJRoAFcJRJwjLnRRMG+R8/ofAdxjGMTteUawHJQ46gGT3jOFmYL29qSiDhxjLWvsTKyw1kGZIjzKoLW4XdSnRZenZSJAkPTLdQdo2gQchvHC0KE2fk1w6tUw4q0huRnC/OH9BFS2EZyTYtttqGBxJ5wJDIuX7tyXukbVZtTE9hI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(5660300002)(6486002)(4326008)(36756003)(66946007)(54906003)(66556008)(6512007)(316002)(6916009)(2906002)(2616005)(8936002)(508600001)(8676002)(38100700002)(26005)(4744005)(31696002)(6506007)(31686004)(186003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?2cxd+QYP1J26TgZ0dKvIIn2r9n+RXxb54Gs7jod8UZJlMYnBc8WO655ETx8D?=
 =?us-ascii?Q?e8YRKRW8T+F2MNz63by+6sINgo5d3uo2XHzqhHXly+5MUGBSvlWo5nvwNhBg?=
 =?us-ascii?Q?9keiQubppBoYCyzfhf/nhrqHQk4sKh1ICLtDnvXNJ6gGJb3+STuuDEYlSvrY?=
 =?us-ascii?Q?Y7S+Wrcp9rpl9C7aRcdzXuv9ZlC4osUdKJJBvjtN3Jrn5icFcOWH4dAN9sqq?=
 =?us-ascii?Q?m6h7vGXDyE8xdOoB89QRk1n+50qaPS8QFOahhU1URPSYrO/Dyh4JTWy45cip?=
 =?us-ascii?Q?ALPDF49QYiidhA6ur6S2c1p/YOlVsQnrY8KtEBF8gvllir0pYw6T5ZCdU73C?=
 =?us-ascii?Q?iB/iX6f/hzzm+s0JDDgsEMnAHNNzbi7gG7/wUHdXVWHWphcooa00VGhIR9Gl?=
 =?us-ascii?Q?UA17Map/1GkX3x64btjfj9ZsnaWVITnY9cmidcTAIJFFy90c/dqVwiBd+WZN?=
 =?us-ascii?Q?g5TBRhxSI0q2t+LtUIt6IpDnZiuDivKjgO+8aIgFnmBYMd8esSAZW6GXPTOr?=
 =?us-ascii?Q?SyKJl64pPxWLHK9zCeHiLbniUsc8fqUbOiAp0CKsrU/vwM4kOS0phmIQzk74?=
 =?us-ascii?Q?cNFMsCv3KWm9C2gUp3+HlvbXyns8wxOMOyQVZCCRwJjuZsTIb41GvqEmKP8s?=
 =?us-ascii?Q?UIEJ2r8zHkuNRDPDU71+8nFl1PnxlsHnfQaKWn3XA1hLCzNjmkfZMXbGQpyd?=
 =?us-ascii?Q?WfPB2IFoCAAQd0FrBFkwPNEuyl5ossaxwCn6itSaSRml7VyI3y+YESTQs+ea?=
 =?us-ascii?Q?PvyC73lK/xWkTxE5MSMqpNGqM/BT40XVw7iW4TEpDxguPwhzPIv5x9YV5CeE?=
 =?us-ascii?Q?XrufPc5EbzK8DKEuyoxBN4Y57ZWGCgTHpNNsemdG1ScXyZHdF8e3n5oGSKsE?=
 =?us-ascii?Q?R9ax7xcaMYvDJ8+J/As39KAYQ5g6vaZo5d5Eq1uhVFoCCo/UFTkTNcJWnwg8?=
 =?us-ascii?Q?8gLGMTooEkbrjAyhfyHVVFfuUG/UgLux1/1NuPYWGzMCxVI8/xMSEmCQ5hXK?=
 =?us-ascii?Q?8k7YwplLypq+tk6bFUuac9mX+EToiEjTsLAW2hOgmETLtqATVobawqWRe0zz?=
 =?us-ascii?Q?AqyISKxlVqOMRo8w5xBL7hk3StfzzBzxon02g6tSMbFDHg/wJ9dmna1SZrDt?=
 =?us-ascii?Q?nR4ORICBj0zCbCsX5ieMUaPApFxaY8PDrlcAVEP1Xl7FTRVZMZ7lcWYvTZy+?=
 =?us-ascii?Q?ZUzSG6nT1Azvilspi/dSy1YS5CfBGWZu7GnDGfH1lafegQWYk5z+cIwroR7r?=
 =?us-ascii?Q?a24kOOGYNW6255sOc9d7iY+LJ/5HLSCCpypE3xBLm+St1vYB46SpDlxP0UPE?=
 =?us-ascii?Q?RTonUXPZ1DE6J1+U4LalCJE/n5PAi/mosFxd2nNUb2Vnij4KRyA+5mbBHiCD?=
 =?us-ascii?Q?9Bhh6VuzkDtVwHlnakfzELcKC3BCLg/c1ZoB5u+kKafKbm24eKi9nay114ZT?=
 =?us-ascii?Q?olzPsLI4IGZnu31etrDFK+hsHhe7e8G97QY2UExCyDOLEUhkmAixA9p5RG9n?=
 =?us-ascii?Q?mVC8kO2KXzc+F9RenJUdCLu3+iTJvwa7HXhtRbRNkK9dRVmB6F6KWbv8pufK?=
 =?us-ascii?Q?Q8JjlAFzRYc6TGDUE3jETtYBBF7q/W9k4qyj2mkB3NYd0Dq1IhRL0gtKZVJf?=
 =?us-ascii?Q?V3H5AqQoSwHfhW7fst60+os=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a4a6ce0-2148-4c76-798b-08d9c46131c0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 09:06:37.6654
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8GWsuD6F1US4JB/Q6L5KQw057MaTmh8Ixyer0wO1Z+FFdXvx/+TFe/TucYnlRXaqLq/6n4cikEwpKrzahImx1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4192

Since mail to Lukasz'es address has been bouncing, Intel have suggested
replacement contacts.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
To be frank, I'm not fully convinced of the M: - I'd instead see us use
R: for both just like we had it for Lukasz.

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -316,7 +316,8 @@ F:	xen/common/hypfs.c
 F:	xen/include/xen/hypfs.h
=20
 INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
-R:	Lukasz Hawrylko <lukasz.hawrylko@linux.intel.com>
+M:	Mateusz M=C3=B3wka <mateusz.mowka@intel.com>
+R:	Pawe=C5=82 Randzio <pawel.randzio@intel.com>
 S:	Odd Fixes
 F:	xen/arch/x86/include/asm/tboot.h
 F:	xen/arch/x86/tboot.c



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:16:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:16:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250240.431016 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbFl-0005Zl-QB; Tue, 21 Dec 2021 09:16:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250240.431016; Tue, 21 Dec 2021 09:16:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbFl-0005Ze-NC; Tue, 21 Dec 2021 09:16:13 +0000
Received: by outflank-mailman (input) for mailman id 250240;
 Tue, 21 Dec 2021 09:16:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzbFk-0005ZY-RE
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:16:12 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzbFi-0005Bm-BP; Tue, 21 Dec 2021 09:16:10 +0000
Received: from [54.239.6.184] (helo=[192.168.7.23])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzbFi-0000T7-0y; Tue, 21 Dec 2021 09:16:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=xSs5i88a9h2mc4jGkw8ER0pLaLyTKl9RfZj60ujhmdY=; b=2mZvV6PtuYv2y5UdH3QOV5firm
	VIAM1ILN9ib/PCoYMLpCvXPS/jMJrHZFe9gNmKXnLmjQXw6uhsc3pLCZS0xBCF6Z1gufX2Cl8b2de
	osH84PemNMNiYsqrWNIwo5rTDYR6Bnih53pOZ4xPF2jmh8iNxzcff9zioaTwhEHpMgk4=;
Message-ID: <dcc6903c-f478-548e-9642-269eaf2291a0@xen.org>
Date: Tue, 21 Dec 2021 10:16:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH v3 02/13] xen: harmonize return types of hypercall
 handlers
To: Juergen Gross <jgross@suse.com>,
 Stefano Stabellini <sstabellini@kernel.org>
Cc: Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Christopher Clark <christopher.w.clark@gmail.com>
References: <20211208155606.20029-1-jgross@suse.com>
 <20211208155606.20029-3-jgross@suse.com>
 <7dd419c1-9ad0-798e-317b-71c8e613ff3e@xen.org>
 <4e9947b6-08b4-4ac6-9cfe-538c3b34175e@suse.com>
 <alpine.DEB.2.22.394.2112151757410.3376@ubuntu-linux-20-04-desktop>
 <c650062f-948e-569d-d4fa-e5333867854e@suse.com>
 <alpine.DEB.2.22.394.2112161232310.3376@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112161246180.3376@ubuntu-linux-20-04-desktop>
 <29c14fd7-4ae2-a277-2413-faa330afc49b@suse.com>
 <67d3c4da-9a20-24ca-543f-02ecf4676277@suse.com>
 <287c8fba-b22f-95ec-21d4-e440e7e7fb36@suse.com>
 <e41d26aa-9ef5-459a-c143-caf28e43c47c@xen.org>
 <a91217dc-8f97-2882-ce08-2a408654295e@suse.com>
 <alpine.DEB.2.22.394.2112171459490.1662642@ubuntu-linux-20-04-desktop>
 <df06a42a-89a2-625e-25a3-da0090cc7bc7@xen.org>
 <0d7f817a-d012-cbff-8179-6926dffa2352@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <0d7f817a-d012-cbff-8179-6926dffa2352@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Juergen,

On 21/12/2021 08:45, Juergen Gross wrote:
> On 20.12.21 18:14, Julien Grall wrote:
>> Hi,
>>
>> On 18/12/2021 00:00, Stefano Stabellini wrote:
>>> On Fri, 17 Dec 2021, Juergen Gross wrote:
>>>> On 17.12.21 11:41, Julien Grall wrote:
>>>>> Hi Juergen,
>>>>>
>>>>> On 17/12/2021 08:50, Juergen Gross wrote:
>>>>>> On 17.12.21 08:45, Jan Beulich wrote:
>>>>>>> On 17.12.2021 06:34, Juergen Gross wrote:
>>>>>>>> On 16.12.21 22:15, Stefano Stabellini wrote:
>>>>>>>>> On Thu, 16 Dec 2021, Stefano Stabellini wrote:
>>>>>>>>>> On Thu, 16 Dec 2021, Juergen Gross wrote:
>>>>>>>>>>> On 16.12.21 03:10, Stefano Stabellini wrote:
>>>>>>>>>>>> The case of XENMEM_maximum_ram_page is interesting but it is
>>>>>>>>>>>> not a
>>>>>>>>>>>> problem in reality because the max physical address size is
>>>>>>>>>>>> only 40-bit
>>>>>>>>>>>> for aarch32 guests, so 32-bit are always enough to return the
>>>>>>>>>>>> highest
>>>>>>>>>>>> page in memory for 32-bit guests.
>>>>>>>>>>>
>>>>>>>>>>> You are aware that this isn't the guest's max page, but the
>>>>>>>>>>> host's?
>>>>>>>>>
>>>>>>>>> I can see now that you meant to say that, no matter what is the 
>>>>>>>>> max
>>>>>>>>> pseudo-physical address supported by the VM, 
>>>>>>>>> XENMEM_maximum_ram_page
>>>>>>>>> is
>>>>>>>>> supposed to return the max memory page, which could go above the
>>>>>>>>> addressibility limit of the VM.
>>>>>>>>>
>>>>>>>>> So XENMEM_maximum_ram_page should potentially be able to return
>>>>>>>>> (1<<44)
>>>>>>>>> even when called by an aarch32 VM, with max IPA 40-bit.
>>>>>>>>>
>>>>>>>>> I would imagine it could be useful if dom0 is 32-bit but domUs are
>>>>>>>>> 64-bit on a 64-bit hypervisor (which I think it would be a very 
>>>>>>>>> rare
>>>>>>>>> configuration on ARM.)
>>>>>>>>>
>>>>>>>>> Then it looks like XENMEM_maximum_ram_page needs to be able to
>>>>>>>>> return a
>>>>>>>>> value > 32-bit when called by a 32-bit guest.
>>>>>>>>>
>>>>>>>>> The hypercall ABI follows the ARM C calling convention, so a 
>>>>>>>>> 64-bit
>>>>>>>>> value should be returned using r0 and r1. But looking at
>>>>>>>>> xen/arch/arm/traps.c:do_trap_hypercall, it doesn't seem it ever 
>>>>>>>>> sets
>>>>>>>>> r1
>>>>>>>>> today. Only r0 is set, so effectively we only support 32-bit 
>>>>>>>>> return
>>>>>>>>> values on aarch32 and for aarch32 guests.
>>>>>>>>>
>>>>>>>>> In other words, today all hypercalls on ARM return 64-bit to 
>>>>>>>>> 64-bit
>>>>>>>>> guests and 32-bit to 32-bit guests. Which in the case of memory_op
>>>>>>>>> is
>>>>>>>>> "technically" the correct thing to do because it matches the C
>>>>>>>>> declaration in xen/include/xen/hypercall.h:
>>>>>>>>>
>>>>>>>>> extern long
>>>>>>>>> do_memory_op(
>>>>>>>>>        unsigned long cmd,
>>>>>>>>>        XEN_GUEST_HANDLE_PARAM(void) arg);
>>>>>>>>>
>>>>>>>>> So...  I guess the conclusion is that on ARM do_memory_op should
>>>>>>>>> return
>>>>>>>>> "long" although it is not actually enough for a correct
>>>>>>>>> implementation
>>>>>>>>> of XENMEM_maximum_ram_page for aarch32 guests ?
>>>>>>>>>
>>>>>>>>
>>>>>>>> Hence my suggestion to check the return value of _all_ 
>>>>>>>> hypercalls to
>>>>>>>> be
>>>>>>>> proper sign extended int values for 32-bit guests. This would 
>>>>>>>> fix all
>>>>>>>> potential issues without silently returning truncated values.
>>>>>>>
>>>>>>> Are we absolutely certain we have no other paths left where a 
>>>>>>> possibly
>>>>>>> large unsigned values might be returned? In fact while
>>>>>>> compat_memory_op() does the necessary saturation, I've never been 
>>>>>>> fully
>>>>>>> convinced of this being the best way of dealing with things. The 
>>>>>>> range
>>>>>>> of error indicators is much smaller than [-INT_MIN,-1], so almost
>>>>>>> double the range of effectively unsigned values could be passed back
>>>>>>> fine. (Obviously we can't change existing interfaces, so this mem-op
>>>>>>> will need to remain as is.)
>>>>>>
>>>>>> In fact libxenctrl tries do deal with this fact by wrapping a 
>>>>>> memory_op
>>>>>> for a 32-bit environment into a multicall. This will work fine for a
>>>>>> 32-bit Arm guest, as xen_ulong_t is a uint64 there.
>>>>>>
>>>>>> So do_memory_op should return long on Arm, yes. OTOH doing so will
>>>>>> continue to be a problem in case a 32-bit guest doesn't use the
>>>>>> multicall technique for handling possible 64-bit return values.
>>>>>>
>>>>>> So I continue to argue that on Arm the return value of a hypercall
>>>>>> should be tested to fit into 32 bits.
>>>>>
>>>>> It would make sense. But what would you return if the value doesn't 
>>>>> fit?
>>>>
>>>> I guess some errno value would be appropriate, like -EDOM, -ERANGE or
>>>> -E2BIG.
>>>
>>> This seems to be better than the alternative below as it is a lot
>>> simpler.
>>
>> We would still need to special case XENMEM_maximum_reservation (or 
>> rework the implementation of the sub-op) because the value returned is 
>> an unsigned long. So technically, the unsigned value for -EDOM & co 
>> could be interpreted as the maximum host frame number.
> 
> I guess you meant XENMEM_maximum_ram_page.

Hmmmm yes.

> 
> What about setting -EDOM only if the high 32 bits are not all the same?
> This would mean to clamp the highest RAM page to -EDOM in case the
> caller is interpreting it as an unsigned value. This would still be
> better than silently dropping the high bits, which could lead to a
> rather low page number instead.

This feels like quite a hack. So I would prefer the low page number. I 
am interested to hear about the others.

> 
>> I also would like to see the hypercall returning 'int' when they are 
>> only meant to return 32-bit value. This will make easier to spot 
>> someone that decide to return a 64-bit value.
> 
> I guess this would need to include all hypercalls handled in common
> code?

Ideally yes.

> 
>>>>>> The only really clean alternative
>>>>>> would be to have separate hypercall function classes for Arm 32- and
>>>>>> 64-bit guests (which still could share most of the functions by 
>>>>>> letting
>>>>>> those return "int"). This would allow to use the 64-bit variant 
>>>>>> even for
>>>>>> 32-bit guests in multicall (fine as the return field is 64-bit wide),
>>>>>> and a probably saturating compat version for the 32-bit guest direct
>>>>>> hypercall.
>>>>>
>>>>> I am not entirely sure to understand this proposal. Can you clarify 
>>>>> it?
>>>>
>>>> 1. In patch 5 modify the hypercall table by adding another column, so
>>>>     instead of:
>>>>     +table:           pv32     pv64     hvm32    hvm64    arm
>>>>     use:
>>>>     +table:           pv32     pv64     hvm32    hvm64    arm32    
>>>> arm64
>>>>
>>>> 2. Let most of the hypercalls just return int instead of long:
>>>>     +rettype: do int
>>>>
>>>> 3. Have an explicit 64-bit variant of memory_op (the 32-bit one is the
>>>>     compat variant existing already):
>>>>     +rettype: do64 long
>>>>     +prefix: do64 PREFIX_hvm
>>>>     +memory_op(unsigned long cmd, void *arg)
>>>>
>>>> 4. Use the appropriate calls in each column:
>>>>     +memory_op         compat   do64     hvm      hvm      compat  do64
>>>>
>>>> 5. In the Arm hypercall trap handler do:
>>>>     if ( is_32bit_domain(current->domain) )
>>>>         call_handlers_arm32(...);
>>>>     else
>>>>         call_handlers_arm64(...);
>>>>
>>>> 6. In the multicall handler always do:
>>>>     call_handlers_arm64(...);
>> I am probably missing something. But why do we need to have separate 
>> call handlers for arm32/arm64?
> 
> How else could you have different functions called for 32- and 64-bit
> guests (other than doing the distinction in the called functions)?

At least for near future, I expect do_memory_op() to be the only one 
requiring special distinction. So my preference would be to handle the 
difference there rather than adding extra logic/indirection.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:20:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:20:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250245.431028 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbK6-00075l-CA; Tue, 21 Dec 2021 09:20:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250245.431028; Tue, 21 Dec 2021 09:20:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbK6-00075e-97; Tue, 21 Dec 2021 09:20:42 +0000
Received: by outflank-mailman (input) for mailman id 250245;
 Tue, 21 Dec 2021 09:20:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzbK4-00075Y-TC
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:20:40 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 43387681-623f-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 10:20:39 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01lp2054.outbound.protection.outlook.com [104.47.1.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-19-kL73CBeIO4uiCvfE5zKFqA-2; Tue, 21 Dec 2021 10:20:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 09:20:35 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 09:20:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 43387681-623f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640078439;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5aLE9fdf9dWfUlU6DfzmijN1/DEkeGK+E8OdRzu6QV8=;
	b=NCCrUbhfjpKpVvDnVLqs46isegzKQeKS7smF4pBqRmLHrc8pjPBiq1klgePTYHswcnzkpY
	33MObfTcfB3akS3EZpURD5YB7p10s2zDj4wRDxHvNGvMCb6tfI9kLvn3bt19tSrNtwNit2
	eXhfdvQmbFOMoz9suHoiMz+M4duPvMg=
X-MC-Unique: kL73CBeIO4uiCvfE5zKFqA-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UAoRFjw2wcWtng5vALPm2I0QnWXJOEywYNXpEYgv6hCZVTe+CRh8hp7bSTg+NguT5hr4lySZSoGV6fXnQLYjrHYmByOihbY//MvKZDi1MSG+hZUqEMXEI9l/fUlT88jGJtUog6vuYD3XYPAq/6u2paLlipsI9vgBVqB5mctTtLnL+MaViltu0jeF9bIvSfiCrS1G51USYu2BO3cFg9ws/i4ohb5hjuZyp+5Znv0awk1UUZ9i8/By6WC/Clg6ink6OeqmWVGbKKxtadPJDXDaBvo3YvKxd5995LdiMKj5C6mWYcZECv8NDfz+C3fHGuXkHbR3TeJjoIkupjOg+eAA9w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5aLE9fdf9dWfUlU6DfzmijN1/DEkeGK+E8OdRzu6QV8=;
 b=FUehrQooL5Pphe1/fypFuvMbHFFAsy/4/6tM1pUkX0iaDkfp1q8vBIU9ws+7op7u6bCooExGr8nl8nTeFNhIg+JXQKxEmmaMhg4jv2RwKEOzJhWOu/vhsEOv0sRUOLKAKdxMzCRQvaTfmnfUacMXaIcy39/5prlstKLwtx4MmgPYAgbhLgn5PHA/cu2codWTLb9QJQaEXC3LmrouZb4RZTYQHaiFTkR7jv3QUCjTCAoW4woYzAvAmxeuykEJUPIFyuddPoQlOdJQBKrZ0DH72oX2YT8KHbYd+rb0Tq1AHkZRWm+kvrPPXRNzPLvJJJu0vEkGEO8XglYjWWedvVaYjA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <cb60f20a-a75f-3b81-e528-7643d47996aa@suse.com>
Date: Tue, 21 Dec 2021 10:20:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH v3] is_system_domain: replace open-coded instances
Content-Language: en-US
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 Wei Liu <wl@xen.org>
References: <20211220162853.10603-1-dpsmith@apertussolutions.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211220162853.10603-1-dpsmith@apertussolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0110.eurprd06.prod.outlook.com
 (2603:10a6:20b:465::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: f87357d0-619e-4a25-cc6c-08d9c46324d1
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:EE_
X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB55983FC2E150A946A3F0C7E9B37C9@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:935;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	eoTM5Kzmoe8BI5c1UQkYdChslVmf0qJuYcS0N1Tp3T9P03QIRpeSxDRzOyYUDj3U0WGK0GwJrI8Ty1skvLKGqVBFhJiWm2apqzMPKU1y1C9DNudWk834IJEjvol0U6XywS57oPRCncnOfdUomr4l97HSmLkyn6MZLo9M0HywujArq7Sq/NgJp29R3AI5vDp7hDG/5VogTby8O3nViV+zAXfG/R3EvGbjG5rq4phgvjK5hOLU0Sbil7pj0lmMPrAUXpIrNHU7smxHBIENQ5WUnwleqHJOucAOn6djMZdritF6rzayOK4zl5lc/09UXtnIt211Kc1hUpdPTmnZi8EXZV+zWDzfCT9GtJ8uCZVEnSP/ygYsJOYEqteOoGFUZUTh7WpZSBsoh3uAvO6ZxLX2I4aI5xtlS3waqn//YuW5td6jJ+cdJjQ7vyObHoBtt0WHZb3rS1PbE3Tae4ShkB6cnu+nJ2k/0PV48p/Pv+M0u52veVJOEQ/pdj/8zk+L0kNRdrKYd1Tq0CMUjXpsp5eC/ky2bu29JBnBX6rXXJRrSXasnenAyuui7RsU7wThX1NUvxnSzlk6smcAsCMbt8tkHYhBX3yrQHWXOVV4k5K7ZMdCGdm3fQSfNPHukqgyImXHAiufsRVQAPVmaX64FYWtspK4n+FPTURBPGAswZChdAbNIl8nNGm0OM375ha9VrVeyIxQKkg6aBxW9dJl+QHQruCbiEyalTXtiuPRlrvLAmk=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(186003)(31686004)(8676002)(38100700002)(8936002)(66946007)(26005)(6512007)(5660300002)(66556008)(66476007)(36756003)(508600001)(6486002)(316002)(53546011)(6506007)(86362001)(31696002)(2616005)(2906002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bEJoangxZElKK1JtVy9pSXpadkJLNys1cWZ4UjB6TkFmMXFzR1lTSXFCRG5W?=
 =?utf-8?B?aXZvZXg0WisyZFB3UVlUVUpENTRsQ2V2cXVWcHVSeHVpaDhVMTQ0UzU4UHQr?=
 =?utf-8?B?MGVJN2JieWhXVzFwdmFPMFNGeWZmd2daanhiNXNzL0RoMHRyNk5VNnRvVklO?=
 =?utf-8?B?eVRVOFVFOFA5blF5TGNpbExxQWNhMHBXNlJDRnl6eWJJMVdKdmc2clJ6V1lQ?=
 =?utf-8?B?OGd3YW9icndicjhhRU80cHRQc0lsem5CZG52alZzazFmTUJkamJRZFpscTZQ?=
 =?utf-8?B?Z1ZmM2xQREdWVHl5UmZHMThwcFFmQlhuZVByeGJaT0pnTi9xcUNVVG9XYlRO?=
 =?utf-8?B?UkJ0RHpTY09PMzNNT21WK1ZCbER1Um40SkdFZDJQdWNtUzBDRHl0V0I4eFhG?=
 =?utf-8?B?M2s5MFdzeXFuMDNSNm5WKzhvU2N4SnRnWk9qQ2tOVGdiSHI0MUV0RnFUN2p4?=
 =?utf-8?B?YXVIZVgzWjcxa2l2bGljMFpKZG9ibGhXWGFwS2l2TDdmb3RlSzFNcTduTXI0?=
 =?utf-8?B?VE5JWTN6Qi90RWk3SzN6eW8xdjlNTkdKT2cvMVhiTk1sdXJIbjBBUzVEd1pu?=
 =?utf-8?B?aHVreWZWYm1FYVdFODd2T2ROMDRIbWNGYm9CTUN1SXVtMk45bGJ5ZUtvVjhy?=
 =?utf-8?B?VEFwbTZzNnI4S3d2dlh2akJiQUxscEg3U1lYMGlwYjRJbmtINXl3dzh5WkRQ?=
 =?utf-8?B?S0FEOGp0Z0poWFJzcVliRUtNSGpUcis4aE1KVVdqbzB1emJCdmtwMlk2VzVG?=
 =?utf-8?B?TEgwaVBBNUY2YkFUenVwemdOdjlvN1FxWTdpR04rTkltOW84Q0VsbTFLOGJv?=
 =?utf-8?B?N2s4S0VmNXQ2MVA1N0pLcGZWLzNUb1AxTkRIZVBkRGx1V0pLb0RxR2tQUHV3?=
 =?utf-8?B?T0tOMHB1N0E2RUpabnR1NW1SbU1sbVg4R2I3K0hicEJRc09oK1dhcU8vZVdD?=
 =?utf-8?B?dXdaVlA0bm5Ld1JYTml3RWZYT3VsWVNFS2NNazN6aEltMERtTTYrdWV2SXlK?=
 =?utf-8?B?VnAvc29ObzJBTTgwYzY2UkkxYUxJQmRkSmYzbU41SThlbHQrK2kvTzBBVkti?=
 =?utf-8?B?WGx0RWtJREpWZE1BVUhzQ0NGR3FxRS80TG9vSHdXUjMyNHlUVkFhQzhTWkRU?=
 =?utf-8?B?S3E3WHdTMEd3RitWT2tpc3IyWTByekt4c3FWOFFSS0VjYyt3ZkZxQzdUWHFG?=
 =?utf-8?B?MGNuMTN5R0xnalBCaFpReUc1SmRZakd3WEdSMXBXN1J6dHhybnRXeThmbmlG?=
 =?utf-8?B?SEtrOGwxQ1dGakhXQTZLZFZuWHJSY0VmcEZId0VQTG4wSXJvL0J6dWcxcUo5?=
 =?utf-8?B?alI3UjZ5cytwRUpRb3RGUU9Od2FDbFR5UzRBcnl4S2hwZEtJL215T0ErTXBQ?=
 =?utf-8?B?S20reFpqUGlOb3hIYUFORnZRekp6Q0NRZDBZbm1saVcxWkJuZkdVSkhaY0hP?=
 =?utf-8?B?blczQlRDUDhPMUtaRkYzM2dCZVB5cmpQbHVXOW5PcEtxTnFUUUVjWHByaFo3?=
 =?utf-8?B?Nng4TDN0dEJxVEpOc1psTmt0NEdLK0VaYmVkVS8rblBUQ2Q0emsyNFFycXdr?=
 =?utf-8?B?RWkxNk1oSzVKVEhuVGczaGVzVHczMUJ3OEJmZ21OU2FCeDROUW1FTkc1ZjZS?=
 =?utf-8?B?ajBUdGhUUUsyUmlTclJxK2ErZVYwaUtOblBKV29hWlBpMWlacGxJalRCRXl4?=
 =?utf-8?B?WlhPUXJsRENTNEJKVUh5eFcvVlh0d3NxV0NpYXJWZnE4cFZ4R1NNVWoyRDUr?=
 =?utf-8?B?UWNnOGFiQWdHQm5HZzlPczI1TGtKd3E3RitmdHFnTFhUcGVBaW1lMVdUQ2Ro?=
 =?utf-8?B?U25PVUdMTU9MOG9wZEdLYm1oWHRlOFllQTRhaDIvOHlkVlByUTR0N1MxSlBF?=
 =?utf-8?B?STB3V0t6d3NiVnRFdTJIYXg1ZmZPLzdDTmQzYkhWV0hFSDFCMGwzSjlVbVVB?=
 =?utf-8?B?ejUzL1NaTFY1dTByalQrUVovanQ2UVp3cW1CdXkrR0xNcWV5YzIwcXpJRzNO?=
 =?utf-8?B?eEpFdmw1UU83K3lwdGVNc1hkazBDYUlkTkJRNzlDZWpSN2IwbTNFYUtKSVRs?=
 =?utf-8?B?TWRxV285b2pIZDhPb29jdFNyVlhIakZMMDJhWXg3ekFHQ3hYWGVIVXh5dG5v?=
 =?utf-8?B?djh3R0JYSnlVSExrWXg2eCtlbStBamZvV3ZOT285NWhFU3MrREpJbGJDWnJp?=
 =?utf-8?Q?T2/ih45Fw+BJ+CeLHuHMwV8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f87357d0-619e-4a25-cc6c-08d9c46324d1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 09:20:34.9620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kjsRR09+6iA670v+WKBbNVIFrEu8BsOqj00F/LmWainNix12C1JO1Io9JHC4kZdPEY3aXo9L1vNPGdyLH/pSOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

On 20.12.2021 17:28, Daniel P. Smith wrote:
> From: Christopher Clark <christopher.w.clark@gmail.com>
> 
> This is a split out of the hyperlaunch dom0 series.
> 
> There were several instances of open-coded domid range checking. This commit
> replaces those with the is_system_domain or is_system_domid inline function.
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
> Acked-by: Dario Faggioli <dfaggioli@suse.com>

While I'm not outright opposed, I'd still like to raise the question whether
we really want to intermix "is system domain" and "is in-range domain ID"
predicates. Personally I'd prefer the latter to remain open-coded range
checks.

> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
>  #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
>  #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
>  
> +static inline bool is_system_domid(domid_t id)
> +{
> +    return (id >= DOMID_FIRST_RESERVED);

Nit: Generally we omit parentheses in cases like this, ...

> +}
> +
>  static inline bool is_system_domain(const struct domain *d)
>  {
> -    return d->domain_id >= DOMID_FIRST_RESERVED;

... just like was the case here.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:26:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:26:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250249.431039 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbPx-0007kJ-1i; Tue, 21 Dec 2021 09:26:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250249.431039; Tue, 21 Dec 2021 09:26:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbPw-0007kC-UE; Tue, 21 Dec 2021 09:26:44 +0000
Received: by outflank-mailman (input) for mailman id 250249;
 Tue, 21 Dec 2021 09:26:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nh4l=RG=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mzbPu-0007k6-Nq
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:26:42 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur04on0618.outbound.protection.outlook.com
 [2a01:111:f400:fe0e::618])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1a0c0b28-6240-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 10:26:40 +0100 (CET)
Received: from DB6PR1001CA0027.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::13)
 by AM0PR08MB4595.eurprd08.prod.outlook.com (2603:10a6:208:10c::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Tue, 21 Dec
 2021 09:26:36 +0000
Received: from DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:4:55:cafe::ec) by DB6PR1001CA0027.outlook.office365.com
 (2603:10a6:4:55::13) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend
 Transport; Tue, 21 Dec 2021 09:26:35 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT012.mail.protection.outlook.com (10.152.20.161) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 09:26:35 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Tue, 21 Dec 2021 09:26:35 +0000
Received: from c0c7137fcd97.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 451BC189-ECB5-490D-B0D4-4E07A12037B4.1; 
 Tue, 21 Dec 2021 09:26:29 +0000
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c0c7137fcd97.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 21 Dec 2021 09:26:29 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AS8PR08MB6135.eurprd08.prod.outlook.com (2603:10a6:20b:29f::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 09:26:27 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%9]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021
 09:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1a0c0b28-6240-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nZCDI1ymsMQl9AbLjmEaUHlkqY8TSvs+a5ArH8SKz8s=;
 b=0AjUKRzBlC5HI1/A80aBrg+RXAEmTH5QM1vEKtjBRH8u3pcrrzVErekXTkuqC0iXjVVt0I34tjkYt9onDgbZA9Z+q9nUWwcGx+D23d5yrBHiJN2JgK2UR2S7ke8x+oeIvGpWvzN8Fj1Fv2qRyOHkGTBZNzx2Zqadqc25LqUMLYs=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 6bd0f47d78ed2cf5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=i4DXEOHbzQu0FbXlwpwox6HzHl5Txctnn5a/JKL0xChPMsb958iyPeXX0OZ0tWNu3Dg4oOHxthGZHXMOxe5eef7t4F0SgfeNDLFoEyCE0zX25dRtmDZJh2ftrGhZY6ZY2IJQT+vuLgOMXmq5dL92/f2K1UU9vAyB6b3AwhuzXBAyxCt6QOVLgbF1iEpOOOGdVozSrvqd9jGbFQW7dGLePgmehc0HNIaiSmkugZqmXneRRj0qC2APlnYNaItSZMJP7vuvE02CxLX8L5CHwrQ0u74D6Cph4DT4HIN+tQ/WcyO6Yc0OpqYUPm/Uv/027YLHU8LZ9tmWMu62b4bEKksqAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=nZCDI1ymsMQl9AbLjmEaUHlkqY8TSvs+a5ArH8SKz8s=;
 b=k2ND4x2z3MW/KdNH0dmC/CgoSQhfXqX3I2csmWyZClGX7PzTjkZC6d2e/Khbw2ql6cb7RK7UI00Gxr5JJOS0YwjN/HtTPsYvZ0evKtDf/TOQ27lAARlirvYuiwmYdIWjeAdLm8fagOe26egCrUQg+XPppbKd5i2JjP/99x9FNe9OmzaaIQJ9LuTxcxHQ0izRBc1i9taEx/eGlgUWLMSOLaxDtK5pnAxeDD+MHCHRWs9Q7uQExwqYK07rRkcw4+nh+fKFpPT5lLmENeswEqrIFbccwyA5IUD/sPxUkeQ0Pu7Qy2RVYoEZFmXhrUrL3qXZtjgNywnoLaIbSb1RqlSa+A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=nZCDI1ymsMQl9AbLjmEaUHlkqY8TSvs+a5ArH8SKz8s=;
 b=0AjUKRzBlC5HI1/A80aBrg+RXAEmTH5QM1vEKtjBRH8u3pcrrzVErekXTkuqC0iXjVVt0I34tjkYt9onDgbZA9Z+q9nUWwcGx+D23d5yrBHiJN2JgK2UR2S7ke8x+oeIvGpWvzN8Fj1Fv2qRyOHkGTBZNzx2Zqadqc25LqUMLYs=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>, Kevin Tian
	<kevin.tian@intel.com>, Julien Grall <julien@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: Re: [PATCH v2 03/18] IOMMU: have vendor code announce supported page
 sizes
Thread-Topic: [PATCH v2 03/18] IOMMU: have vendor code announce supported page
 sizes
Thread-Index: AQHXsSi8nS3gY9fgEUm/NXnQX6ocmqw9N1SA
Date: Tue, 21 Dec 2021 09:26:26 +0000
Message-ID: <31D3D9E4-14A8-46CE-8F14-72F99BFE7403@arm.com>
References: <957f067b-9fe1-2350-4266-51982f09d3a9@suse.com>
 <3f0adf5b-cc2a-1b72-8376-baad574fa824@suse.com>
In-Reply-To: <3f0adf5b-cc2a-1b72-8376-baad574fa824@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: dba14b71-ca12-40e6-cfa7-08d9c463fbe4
x-ms-traffictypediagnostic:
	AS8PR08MB6135:EE_|DB5EUR03FT012:EE_|AM0PR08MB4595:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR08MB4595D31534A4AECB9F41633AFC7C9@AM0PR08MB4595.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 CNGmRA5NvOwjLbwWt0hM5f0wDekg23/u/5Qeei1ov1d/c8CLz4TY1Af+JtouQw3nmZf0w4OqegIZFeZTBKISqoNVDoa+JY7LerkXifSNCljjLMyuZ30sE/Dkm/Gk2giktL5+C2+NnWot5Mz8BYotJvMSDxRVqQz4GR3uGqaI5HbvtktquEWox5i7FVY2BnPz5i4ZR/HV6dib8ypAAaheHNlk/eNMBjvRxYmDpoPtQvKM1MpNRZBLhfpPXbFXYYpOHLLdWRVQdF9tXHMuE81Xp3fNIHMZ7GPHTGmpNSx/suZ3h9+LRtsUk9WUHv95PL5XK/f4ANI3i6JIfedfKojW09hZCcQlq8opZdIREIlwLqfyV1y/dcc7PdDnUHe6ivUK/m68XFEXAfY3X5jnZ8qHDMRGRv0hIkxKLP3nIt2UZKlwLYFMYuSvzTnqpHdjlr6s8roIRLAfwAMpLAm4FnqjWwvUn5iX2AvlOhCmc2uveswO4ccch8JmMmqtk9Bs94BVrEAyanAzLNA+5hnpyTcHxlLALZ4BK8G8L5YQC498efx0r7Qwp8qieCL3bYAFxmPMmBCqILxcXvZpP+mV7iaHWHsyFd/pXgD9dZSZ5PCjKQwEQBtwH11K2AxfHapIi8sbmtLzyPA7fqV57GdI77di0sNwKV6mxCl3TqLViGWWnY3eddSk1GPJMVs1yYKogGTu2/PRup8A0QrhsPLUqQZieLYVxTG7ZrXFR6Y8ltpeoo8OdXslOz6djUCNizWZk2Vc
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(186003)(26005)(54906003)(6916009)(53546011)(76116006)(6486002)(66476007)(6506007)(33656002)(2906002)(71200400001)(36756003)(64756008)(8936002)(66556008)(122000001)(8676002)(2616005)(66946007)(91956017)(38100700002)(6512007)(83380400001)(508600001)(38070700005)(5660300002)(316002)(4326008)(66446008)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EB31EEBACA7E3949A7013EAEFA5FF9C1@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6135
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	5485c831-e5f7-42d4-7280-08d9c463f6b4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5lBk2ZaMDEcBGZBkraVTdtU1m0292qZOe9yY5KGcISP5LAKl8U9IJ7j4s9yeqiPM7cXTAfDP1VbRvFMIjdpvgcK1FfUdfcEI2b2pNYSGExSg8qzmdBwjJR5m3zhD1CGgStWn7yCxHNYI+YvFyyJ2Aqrs7v6UdnlXhARsT3iHDN1s3Cer5hGEWDU6P6MfjbALjtmy4jl/ZPbFqyxnzMFvYXwBdgHumwBuRV81KtyaXGi6sh1C8FDksTboN2VtQ/NeossAcj5QTGmxu+Cekbb6dp5GDRnfuQq9nc5oqZtbL9LQESaGHiEFa3wk8lYjZYz2lwOv3TeWZOtZ0A0xkgpKixHABHyp+QSbxB7j+TUxGdrGNt/5/w4P3KjmfAHgEQztxdoawaXxhj0cjmA/9dW1Dw8y6HAu0p/urx+OjHOJHWaZy6y1z1DgfzG51S1oaHR3tOSE0BP/pJIqT4gxv8d9BqKNs33NXO+xopo84eujdzg59nci/DOJ5lCZAquF9kOCHQStQjNbE8SxQVpapXG5wG5PWOowHV6rya7jhA2XyvFPTNOVRBoTwl+OHl9xwkPxpy+JbfxljAqfMrZU9Z5hFbSUoAmOp5d41zzmp1E2M6VMSoKMu88y6YRqLo0k54ER9zoGPYjpEp4d8jGHNEAOpR1qHhkK7Qgt6cj5Xyvxx1GUUYMInz2h2vuwSKnlDacc7UvjLxMHPkKXV5tFfrOF6VF+xX6pBymL2+MAinwVaGKpdHShruxn6tTrm2uezsx4BQ1s1iDz5iBqh6X1BhAVCw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(40470700002)(46966006)(81166007)(36860700001)(336012)(6862004)(40460700001)(356005)(54906003)(53546011)(33656002)(6506007)(36756003)(26005)(5660300002)(86362001)(508600001)(82310400004)(2616005)(83380400001)(4326008)(186003)(6512007)(70206006)(70586007)(47076005)(6486002)(8936002)(316002)(8676002)(2906002);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 09:26:35.6428
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dba14b71-ca12-40e6-cfa7-08d9c463fbe4
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT012.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4595

Hi Jan,

> On 24 Sep 2021, at 10:43 am, Jan Beulich <jbeulich@suse.com> wrote:
>=20
> Generic code will use this information to determine what order values
> can legitimately be passed to the ->{,un}map_page() hooks. For now all
> ops structures simply get to announce 4k mappings (as base page size),
> and there is (and always has been) an assumption that this matches the
> CPU's MMU base page size (eventually we will want to permit IOMMUs with
> a base page size smaller than the CPU MMU's).
>=20
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Reviewed-by: Rahul Singh <rahul.singh@arm.com>

Regards,
Rahul
>=20
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -629,6 +629,7 @@ static void amd_dump_page_tables(struct
> }
>=20
> static const struct iommu_ops __initconstrel _iommu_ops =3D {
> +    .page_sizes =3D PAGE_SIZE_4K,
>     .init =3D amd_iommu_domain_init,
>     .hwdom_init =3D amd_iommu_hwdom_init,
>     .quarantine_init =3D amd_iommu_quarantine_init,
> --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c
> @@ -1298,6 +1298,7 @@ static void ipmmu_iommu_domain_teardown(
>=20
> static const struct iommu_ops ipmmu_iommu_ops =3D
> {
> +    .page_sizes      =3D PAGE_SIZE_4K,
>     .init            =3D ipmmu_iommu_domain_init,
>     .hwdom_init      =3D ipmmu_iommu_hwdom_init,
>     .teardown        =3D ipmmu_iommu_domain_teardown,
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2873,6 +2873,7 @@ static void arm_smmu_iommu_domain_teardo
> }
>=20
> static const struct iommu_ops arm_smmu_iommu_ops =3D {
> +    .page_sizes =3D PAGE_SIZE_4K,
>     .init =3D arm_smmu_iommu_domain_init,
>     .hwdom_init =3D arm_smmu_iommu_hwdom_init,
>     .add_device =3D arm_smmu_dt_add_device_generic,
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -3426,7 +3426,8 @@ static void arm_smmu_iommu_xen_domain_te
> }
>=20
> static const struct iommu_ops arm_smmu_iommu_ops =3D {
> -	.init		=3D arm_smmu_iommu_xen_domain_init,
> +	.page_sizes		=3D PAGE_SIZE_4K,
> +	.init			=3D arm_smmu_iommu_xen_domain_init,
> 	.hwdom_init		=3D arm_smmu_iommu_hwdom_init,
> 	.teardown		=3D arm_smmu_iommu_xen_domain_teardown,
> 	.iotlb_flush		=3D arm_smmu_iotlb_flush,
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -470,7 +470,17 @@ int __init iommu_setup(void)
>=20
>     if ( iommu_enable )
>     {
> +        const struct iommu_ops *ops =3D NULL;
> +
>         rc =3D iommu_hardware_setup();
> +        if ( !rc )
> +            ops =3D iommu_get_ops();
> +        if ( ops && (ops->page_sizes & -ops->page_sizes) !=3D PAGE_SIZE =
)
> +        {
> +            printk(XENLOG_ERR "IOMMU: page size mask %lx unsupported\n",
> +                   ops->page_sizes);
> +            rc =3D ops->page_sizes ? -EPERM : -ENODATA;
> +        }
>         iommu_enabled =3D (rc =3D=3D 0);
>     }
>=20
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -2806,6 +2806,7 @@ static int __init intel_iommu_quarantine
> }
>=20
> static struct iommu_ops __initdata vtd_ops =3D {
> +    .page_sizes =3D PAGE_SIZE_4K,
>     .init =3D intel_iommu_domain_init,
>     .hwdom_init =3D intel_iommu_hwdom_init,
>     .quarantine_init =3D intel_iommu_quarantine_init,
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -231,6 +231,7 @@ struct page_info;
> typedef int iommu_grdm_t(xen_pfn_t start, xen_ulong_t nr, u32 id, void *c=
txt);
>=20
> struct iommu_ops {
> +    unsigned long page_sizes;
>     int (*init)(struct domain *d);
>     void (*hwdom_init)(struct domain *d);
>     int (*quarantine_init)(struct domain *d);
>=20



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:30:52 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:30:52 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250254.431050 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbTp-0000tc-MK; Tue, 21 Dec 2021 09:30:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250254.431050; Tue, 21 Dec 2021 09:30:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbTp-0000tV-JH; Tue, 21 Dec 2021 09:30:45 +0000
Received: by outflank-mailman (input) for mailman id 250254;
 Tue, 21 Dec 2021 09:30:44 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzbTo-0000tP-Og
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:30:44 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id aa1c3abd-6240-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 10:30:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: aa1c3abd-6240-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640079043;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Vbl6T8es3mxt8akruFaFUiZctnlQ2rCsIEtlMcYYi60=;
  b=FMOK1ipymiUlk2ipLgNGmX88UAG6Sj9lUK6uV9X3cvHAjtrP4CE+eNoN
   yKSqZYUhQ986YIatI8qpC1RP1rjC3VidOZiVEBFmVQBcwi06FLGSfD0iy
   ivBsnkMag7/+RICjZ4nYEogDkqB6vRjit0pCBE/ZlOo7M/tcd97/tCLAS
   o=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: MAjUbPfwbolqxdpDmac+8IZPu1i5sqvkq8SnUkVOvWuTbInzSa22r6gqGhs6XkC6V9GDA3pbkI
 RS1nf40BtMn+eK7L+NU+OhbgHXOWsNcYfX69Kf2Ui+gfRZ0RuRJGluBSUs4F9etX5p5/33tTH1
 lWTwEuji3RHQ6NDDXc3px1prnAvHRTB0LyEqLwWjylUf3nc7sxww4sck6B12n1k9ule//pb2Cb
 R9zzIZil3yGtj/dn9XN4JX9NnyqlXlJq4mFPdWsAcX9BnBFBopV+8KPI63D8JcORskofTnw7SE
 fJHVfOd9hF/OcHgcD2LU0ii4
X-SBRS: 5.1
X-MesageID: 60429733
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:iC0b2KMvqHhg5H3vrR1xkcFynXyQoLVcMsEvi/4bfWQNrUon1zwGm
 DcdXT+GOv6DZmL2fot2bY2y8UwCu5/RyIVkGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400g6w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxSlsdpYy
 opfjoGPcAgxGoH8sv4gfiANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9s3JERRq22i
 8wxWCI+bS/MRxNzAlpGJowen7fwtlryfGgNwL6SjfVuuDWCpOBr65DmN9zTfd6GTNtUhW6Xo
 2vH+yLyBRRyHNWbyCGZ+3O2wOHVlCXwWZk6C7GzsPVthTW7zGEJFAcfU1f9pPCjk1O/QPpWM
 UlS8S0rxYAx80qxR9W7QBy8o1aDpBcXX9cWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1
 FKCg5XuHzMHmLGNUnec6re8pCu/IzQINnQFYTIYTAwD+J/op4Rbph7AQttsCqedksz+GTa2x
 SuD6ic5md07jNEJ/7W2+0jdhDChrYSPSRQ6ji3dWWiv/w5iZIqoYoWuwVfe5PdEao2eSzGpv
 nIJhsyf5+AmFoyWmWqGR+BlNLO04/eINhXMjFgpGIMunxyT/HqkcZFV8StJDk5jOcYZehfke
 EbW/whW4fd7I3+CfaJxJYWrBKwC1rP8HN7oUvTVaNtmYZVrcgKDuiZ0aiatM3vFyRZ21/tlY
 NHCLJjqXS1y5blbICSeZssz25YpmTIF2FzqSojf4ySNy4ezXSvAIVsaC2emYuc85aKChQza9
 ddDKseHoylivP3Cjjr/qtBKcw1TRZQvLdWv8pEMKLbfSuZzMDh5U6e5/F83R2Byc025fM/s9
 2r1ZEJXwUGXaZbveVTTMSALhF8CsP9CQZMH0c4EYQfAN5sLO9/HAEIjm30fJ+FPGAtLl6Ecc
 hX9U5/casmjsxyek9jnUbHzrZZ5aDOgjh+UMiyubVAXJsA8H1STp4C4JFK0rkHi6xZbU+Nk+
 9VMMSuBHvI+q/lKVp6KOJpDMXvs1ZTipA6CdxSReYQCEKkd2INrNzbwnpcKzzIkcn3+Ks+h/
 1/OW38w/LCVy6dsqYWhrf3U/u+BTroldmIHTjaz0FpDHXSDloZV6dQbC7jgkPG0fD6cxZhOk
 s0Jlayha6Neww4R22e+ep4ypZ8DCxLUj+cy5mxZ8L/jNDxH05tsfSuL29dhrKpIyuMLsAe6Q
 BvXqNJbJa+IKIXuF1tIfFgpaeGK1Pc1nDjO7KtqfBWmtXEvpLfXA19POxSsiTBGKOcnOo0S3
 up86tUd7Bayi0R2P4/e3DxU7WmFMlcJT74j6sMBGIbuhwdykgNCbJXQBzXY+paKb9kQYEAmL
 iXN3PjJhqhGx1qEeH02TCCf0e1YjJUImRZL0F5deAjZxoub3qc6hUQD/y42QwJZygR8/9hyY
 mU7ZVdoIaiu/itzgJQRVW6bBAwcVgaS/Vb8ygVVmTSBHVWoTGHEMEY0Jf2JoBIC62tZczVWo
 OOYxWLiXWq4dc39xHJvC0tsqvilRt1t7AzS3sugGp3dTZU9ZDPkhI6oZHYJ9ES7UZ9g2hWfq
 Lk45vt0ZI36KTUU8v8yBISt3LgNTAyJeT5ZSvZ78aJVRWzRdVleA9RVx5xdri+VG8H3zA==
IronPort-HdrOrdr: A9a23:pfn1L618gI0A9X5pLfaijgqjBLIkLtp133Aq2lEZdPRUGvb3qy
 mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM
 9bAs5D4bbLbGSS4/yU3DWF
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="60429733"
Date: Tue, 21 Dec 2021 09:30:25 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Bob Eshleman <bobbyeshleman@gmail.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>, "Ian
 Jackson" <iwj@xenproject.org>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Alistair Francis <alistair.francis@wdc.com>, Connor Davis
	<connojdavis@gmail.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "Ross
 Lagerwall" <ross.lagerwall@citrix.com>, Daniel De Graaf
	<dgdegra@tycho.nsa.gov>, "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 12/47] build: build everything from the root dir,
 use obj=$subdir
Message-ID: <YcGescJTNrwi7HUP@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-13-anthony.perard@citrix.com>
 <0b2eb0e2-a07f-6ba2-8f59-b7c207ed30da@suse.com>
 <YbseOtj7prFqViyV@perard>
 <YcBpLbxObugQ3doZ@perard>
 <35327375-fb82-ace7-ecb0-be9188c0d280@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <35327375-fb82-ace7-ecb0-be9188c0d280@suse.com>

On Tue, Dec 21, 2021 at 08:55:26AM +0100, Jan Beulich wrote:
> On 20.12.2021 12:29, Anthony PERARD wrote:
> > On Thu, Dec 16, 2021 at 11:08:47AM +0000, Anthony PERARD wrote:
> >> On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
> >>> On 25.11.2021 14:39, Anthony PERARD wrote:
> >>>> --- a/xen/Makefile
> >>>> +++ b/xen/Makefile
> >>>> @@ -22,6 +22,15 @@ export CHECKPOLICY	?= checkpolicy
> >>>>  export BASEDIR := $(CURDIR)
> >>>>  export XEN_ROOT := $(BASEDIR)/..
> >>>>  
> >>>> +abs_objtree := $(CURDIR)
> >>>> +abs_srctree := $(CURDIR)
> >>>
> >>> Nit: In line with e.g. obj-y I think these would better be abs-srctree and
> >>> abs-objtree.
> >>
> >> I guess that would be fine, we don't need to keep the same spelling that
> >> Kbuild does.
> > 
> > Actually, those two variables are exported, as it appear in the next two
> > lines. Exporting a variable with a dash doesn't work very well as shells
> > may not be able to use them. When make find a variable with a dash in
> > it in the environment, it unexport them.
> > 
> > So, for those two variable, we need to avoid using a dash, so I think
> > keeping the current name is better. (And now, I've find out that there's
> > an issue in the build system, I'll prepare a patch.)
> 
> Oh, sure - if they have to be exported, the names should remain as they are.
> Question of course why they need exporting when by the end of the conversion
> you don't change directories anymore.

So far, the value of those two variables are simple, but they get a bit
more complicated when we introduce out-of-tree build. I would rather
avoid recalculating those values later one and be sure that the values
are the same on recursion.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:35:51 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:35:51 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250257.431061 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbYc-0001XH-AU; Tue, 21 Dec 2021 09:35:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250257.431061; Tue, 21 Dec 2021 09:35:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbYc-0001XA-6f; Tue, 21 Dec 2021 09:35:42 +0000
Received: by outflank-mailman (input) for mailman id 250257;
 Tue, 21 Dec 2021 09:35:40 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Nh4l=RG=arm.com=Rahul.Singh@srs-se1.protection.inumbo.net>)
 id 1mzbYa-0001X4-MS
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:35:40 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04on062a.outbound.protection.outlook.com
 [2a01:111:f400:fe0c::62a])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5b3032ad-6241-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 10:35:39 +0100 (CET)
Received: from AS8PR04CA0056.eurprd04.prod.outlook.com (2603:10a6:20b:312::31)
 by DBBPR08MB4629.eurprd08.prod.outlook.com (2603:10a6:10:f4::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec
 2021 09:35:36 +0000
Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:312:cafe::66) by AS8PR04CA0056.outlook.office365.com
 (2603:10a6:20b:312::31) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.14 via Frontend
 Transport; Tue, 21 Dec 2021 09:35:36 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4801.14 via Frontend Transport; Tue, 21 Dec 2021 09:35:33 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Tue, 21 Dec 2021 09:35:33 +0000
Received: from 611ff812d540.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 054EC4EC-EA1E-46C3-8BEB-7E3D8659227A.1; 
 Tue, 21 Dec 2021 09:35:27 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 611ff812d540.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Tue, 21 Dec 2021 09:35:27 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com (2603:10a6:20b:39e::10)
 by AM6PR08MB3240.eurprd08.prod.outlook.com (2603:10a6:209:49::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Tue, 21 Dec
 2021 09:35:25 +0000
Received: from AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e]) by AS8PR08MB6919.eurprd08.prod.outlook.com
 ([fe80::8851:be59:208:265e%9]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021
 09:35:25 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5b3032ad-6241-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cAxc/67Ajslel3QVBXvxCdXspomx3Qeuxrd1LiKlQbs=;
 b=wwInxNDeZ3s6w6vJlc2KP+LsPwUpvBGiMnlZ8Me9+RBYeLDpmRq9GGY7wlpqTJrXatUwIpmB3JNao5uSCeSyNG5p1Pye+PSDJ2hA0B3hIirwz/Mlw8Kjwa6/8RNPxfqSD2GXgN8ds0cJFzK9E6LNptdUxFGfMxAnNXiOyIyeI5g=
X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is
 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=temperror action=none
 header.from=arm.com;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
X-CheckRecipientChecked: true
X-CR-MTA-CID: f6fba49813af44f5
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KXw63b0SD9IM72yTTlVUnlegMACPhRLfIPbBZ6nfwod8//ygmcW6tvwFkQzSu91PXxCbt37zedD3ITksNQiHSgLWw1Lj8NyKCKnqpAHxkaGmpJV8O9gzRp47n7IIcM1TFk2DFmEMdIuA6D6vzhT8jFN/06xHEiW/cYit/b0Zi6EBhFAr0VN+zR3y8v9GczXrcRT17ohdEu6h/pVQvkhSD7W+UYGIeNhEAOZFh2UDRjjO3ZQf5kDOdR+qLClbuE+ImQfc3nbSsYJ62fkl+ALIvXSpZVXRQ340RnasZFCTHlNctaxmtiASmz92mtDdTgrU5RIjhBKYUDwBKZ9oXkO+CA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=cAxc/67Ajslel3QVBXvxCdXspomx3Qeuxrd1LiKlQbs=;
 b=Em/m1sjAsY7Trtv6EV5kBPnGLmT0TRSAxZpIMHwqpoT0JGraC9Nia9xLLBHusMzeyj13I7wFlRYcSe4Gn/YMrjGuWzyfUxxbeHBNBpipgNybfheE7DKnGp4NIKTU/aP5KyaJTyVh9/ZWD8xEgjpO0kWk51heHvsCBdZxPob8wuOUymVhpK9NweL4BBZ96veKUaUaEDhBAtResqazssasurrbH1O8SkTZZnG9PavfMX6SCkCx3TPA9uWKT/uRUuU4+JBRjGC0HKouBDvLGFc40MeXAN7WTmRyC3FRr3SvRrnBCYcSNKkJiunXHPoGI8K9IHTo2D/NEj9vu0xWn5XPQA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=cAxc/67Ajslel3QVBXvxCdXspomx3Qeuxrd1LiKlQbs=;
 b=wwInxNDeZ3s6w6vJlc2KP+LsPwUpvBGiMnlZ8Me9+RBYeLDpmRq9GGY7wlpqTJrXatUwIpmB3JNao5uSCeSyNG5p1Pye+PSDJ2hA0B3hIirwz/Mlw8Kjwa6/8RNPxfqSD2GXgN8ds0cJFzK9E6LNptdUxFGfMxAnNXiOyIyeI5g=
From: Rahul Singh <Rahul.Singh@arm.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>, xen-devel <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>, George Dunlap
	<george.dunlap@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>,
	=?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
Subject: Re: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Topic: [PATCH] xen/vpci: msix: move x86 specific code to x86 file
Thread-Index:
 AQHX8NfN625eD/1es0eaHkpOvTmQ3Kwx7OWAgAL9+QCAAAwcgIAAK1kAgAGhwICABdZ2AIAAH+6A
Date: Tue, 21 Dec 2021 09:35:24 +0000
Message-ID: <EB3D122A-92B9-42AE-919B-7092B8F6822C@arm.com>
References:
 <b8c0e550dde0fd80b2f72e9136a94caab2c3d52c.1639478534.git.rahul.singh@arm.com>
 <bfb2b7f282249cee8b6ff15d424a2b7d823ac743.1639478564.git.rahul.singh@arm.com>
 <YbiP7YlpY22llB5Y@Air-de-Roger>
 <621259B5-E5EB-4ED9-A836-B6E17C0D6E36@arm.com>
 <YbscoZG/NRP6lMof@Air-de-Roger>
 <b3488523-489e-abb7-59f1-74c86e842060@suse.com>
 <5270d46a-a1ce-e361-dfeb-54408e9ba6f0@xen.org>
 <26968841-9b8a-757a-b9af-ba34a20fe576@suse.com>
In-Reply-To: <26968841-9b8a-757a-b9af-ba34a20fe576@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: f3f95e33-f90a-49f7-5135-08d9c4653cc7
x-ms-traffictypediagnostic:
	AM6PR08MB3240:EE_|AM5EUR03FT007:EE_|DBBPR08MB4629:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB462928A74CDA8419C23C78ECFC7C9@DBBPR08MB4629.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 d07j+SMm7S10W35qrn+cGcWEYPNKAK6RwjanMDpNSch8s9tnGGxnoUN5gmjmOvWnJQwY4CVtuDOitcoV2pZvtnBa6lCpaF9FE4ZbhSUkF+IfF/Iju16s5Njx7AbHVw7j42rUTlw27fzCVlmeLuLuPvd9x5MMTulyyvb4Kjt5yxyNvNTAqrFZgs7vCgf1zwk9Pb9aG2/kRukqCrwh9K7XENdVlrxFZOa8IDl2cyhg+/LcNysGMB/vFpqmfhCYRgEVivEXmOcwcN5PecUgwoB+hH7PetegfEemkmAg/hwcq1KlZ0FWR6LuqywhO7X9zFOWacgTFE0N3TnAlE8YP/sU8Ch1Oh2OGba8AFbJcvJGlVsF+n21da32rvfUaHdCeM7PH4WAaTrIWSOSvOw/V77dYBOToQCvnYCyirIrxSI4TECHcnE/OEktBQWwcbhs1nkggmpcfadu/v1SDxzMj5Lr1X2wzpfCSNlg6BSgsTLh86ol0TYh6px4k0dzwHwMbnv3+d9BKqH22m16XDEkZnHJ3ktRnhiBPmRx+Pf7y99/kExkDNywxfQhgXMGKwiZ0FnchtGYaSsMtFbZY4obuhuc1q1UThlD2VbQrEGjbGkLCZNOrEa0GZ3dHJyMCR1+Qdh9tNPWr1wU2IhqL9qq0elryOnENwhOU2h6GY1MuZCoTmIJy8CgwG+f63/yfxXucTi0ud6NUkv2pXxsUh1cL4L0xsUWB6cpHX75lFUyQNO00dKubaI+g7Rn+9P/mHYpAnd6
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(66946007)(4326008)(26005)(36756003)(76116006)(186003)(122000001)(91956017)(33656002)(5660300002)(6486002)(6512007)(2616005)(6506007)(316002)(53546011)(508600001)(83380400001)(64756008)(66446008)(8936002)(6916009)(66476007)(38070700005)(86362001)(54906003)(8676002)(2906002)(66556008)(71200400001)(45980500001);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-ID: <1CDE381EAAE9614FA4CF7043921AC037@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3240
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	6a8971d2-dde9-4e7a-214d-08d9c4653781
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	/xJmJpl+HZ5AIjQy/JkasQyv0rcqswQbDPyQSKDJRUuJOiZn4EjiZUaUZz7TEpHEWGxruKkEDKqSdIbjsb9JWMx6dU2IZM17T1rUupXYPtDbkBdOsvACEWe++R3QFJvXHQvsgCd+9G3NYG8qMmZHin0YS04Qp524rM5W/XwJYzzg0sACuc6h9wXN1StXXkxjMCOOAipW3F39wjfjvG7V2LP4h/3Uw3wSxLHHqAuoaKXMfwNnpjzwWALvuD/5zj90bQVYIzmCSaNmz50IID2+d7E6n3TFd+E/TdksQgc2t02cWYb8sIxQ/N3BZtc5/pq/6OBgDDWVtGc5lovC4bSn7SW8IAx/tuS2uHspj7jzc3H2RD1iXzurYYdfpxlAVhGnF8flNLWIbp0XR36194P0jPYnoipEjTdr1++Aa52PX3kAhN2pCTUJ71P0Q6eB/a6raymjzFgKzqgAtVue6MZ8f+uspn6B2o6XNgKibcW8gStB52eD3eeM5ux+j2+DylVHM17N3kLorB3lehIcmk5dzBBI61hgAlPexnZDxUdnWwt/B5cwFlRrTOdx47hCqMIW/O6bnepUXIxnb8r2tSmctVQAR1NqNEvoaymHQCQk1kxfB/1ZE40hx610UIAOIw97HQkUYxDDERukgEGwpvZpxHyjK5AnnERM+0+nBacDvfhqLv9OTLt9Ozew6chyKfU4dXcegRGBtD3sCvJW+e6AHgZ+OZECR9E9zxkwD0+TlrJXAnUeHDNO+Vw2bYwBKv1LuuC+Ha/FyOu2zfXUzy5wuxvQLdRKpP1sANJt4SL2elM=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(40470700002)(46966006)(33656002)(40460700001)(63370400001)(8936002)(2906002)(5660300002)(6486002)(70586007)(83380400001)(6512007)(47076005)(36756003)(336012)(54906003)(63350400001)(8676002)(81166007)(316002)(356005)(6862004)(186003)(6506007)(82310400004)(508600001)(4326008)(26005)(107886003)(70206006)(2616005)(36860700001)(53546011)(86362001)(45980500001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 09:35:33.9134
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f3f95e33-f90a-49f7-5135-08d9c4653cc7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4629

SGkgSmFuDQoNCj4gT24gMjEgRGVjIDIwMjEsIGF0IDc6NDEgYW0sIEphbiBCZXVsaWNoIDxqYmV1
bGljaEBzdXNlLmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAxNy4xMi4yMDIxIDE1OjMyLCBKdWxpZW4g
R3JhbGwgd3JvdGU6DQo+PiBPbiAxNi8xMi8yMDIxIDEzOjM3LCBKYW4gQmV1bGljaCB3cm90ZToN
Cj4+PiBPbiAxNi4xMi4yMDIxIDEyOjAxLCBSb2dlciBQYXUgTW9ubsOpIHdyb3RlOg0KPj4+PiBP
biBUaHUsIERlYyAxNiwgMjAyMSBhdCAxMDoxODozMkFNICswMDAwLCBSYWh1bCBTaW5naCB3cm90
ZToNCj4+Pj4+PiBPbiAxNCBEZWMgMjAyMSwgYXQgMTI6MzcgcG0sIFJvZ2VyIFBhdSBNb25uw6kg
PHJvZ2VyLnBhdUBjaXRyaXguY29tPiB3cm90ZToNCj4+Pj4+PiBPbiBUdWUsIERlYyAxNCwgMjAy
MSBhdCAxMDo0NToxN0FNICswMDAwLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+Pj4+Pj4gKyAgICAg
ICAgICAgICAgdW5zaWduZWQgbG9uZyAqZGF0YSkNCj4+Pj4+Pj4gew0KPj4+Pj4+PiAtICAgIGNv
bnN0IHN0cnVjdCBkb21haW4gKmQgPSB2LT5kb21haW47DQo+Pj4+Pj4+IC0gICAgc3RydWN0IHZw
Y2lfbXNpeCAqbXNpeCA9IG1zaXhfZmluZChkLCBhZGRyKTsNCj4+Pj4+Pj4gICAgIGNvbnN0IHN0
cnVjdCB2cGNpX21zaXhfZW50cnkgKmVudHJ5Ow0KPj4+Pj4+PiAgICAgdW5zaWduZWQgaW50IG9m
ZnNldDsNCj4+Pj4+Pj4gDQo+Pj4+Pj4+ICAgICAqZGF0YSA9IH4wdWw7DQo+Pj4+Pj4+IA0KPj4+
Pj4+PiAgICAgaWYgKCAhbXNpeCApDQo+Pj4+Pj4+IC0gICAgICAgIHJldHVybiBYODZFTVVMX1JF
VFJZOw0KPj4+Pj4+PiArICAgICAgICByZXR1cm4gVlBDSV9FTVVMX1JFVFJZOw0KPj4+Pj4+PiAN
Cj4+Pj4+Pj4gICAgIGlmICggIWFjY2Vzc19hbGxvd2VkKG1zaXgtPnBkZXYsIGFkZHIsIGxlbikg
KQ0KPj4+Pj4+PiAtICAgICAgICByZXR1cm4gWDg2RU1VTF9PS0FZOw0KPj4+Pj4+PiArICAgICAg
ICByZXR1cm4gVlBDSV9FTVVMX09LQVk7DQo+Pj4+Pj4+IA0KPj4+Pj4+PiAgICAgaWYgKCBWTVNJ
WF9BRERSX0lOX1JBTkdFKGFkZHIsIG1zaXgtPnBkZXYtPnZwY2ksIFZQQ0lfTVNJWF9QQkEpICkN
Cj4+Pj4+Pj4gICAgIHsNCj4+Pj4+Pj4gQEAgLTIxMCwxMSArMTk0LDExIEBAIHN0YXRpYyBpbnQg
bXNpeF9yZWFkKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBsb25nIGFkZHIsIHVuc2lnbmVkIGlu
dCBsZW4sDQo+Pj4+Pj4+ICAgICAgICAgc3dpdGNoICggbGVuICkNCj4+Pj4+Pj4gICAgICAgICB7
DQo+Pj4+Pj4+ICAgICAgICAgY2FzZSA0Og0KPj4+Pj4+PiAtICAgICAgICAgICAgKmRhdGEgPSBy
ZWFkbChhZGRyKTsNCj4+Pj4+Pj4gKyAgICAgICAgICAgICpkYXRhID0gdnBjaV9hcmNoX3JlYWRs
KGFkZHIpOw0KPj4+Pj4+IA0KPj4+Pj4+IFdoeSBkbyB5b3UgbmVlZCBhIHZwY2kgd3JhcHBlciBh
cm91bmQgdGhlIHJlYWQvd3JpdGUgaGFuZGxlcnM/IEFGQUlDVA0KPj4+Pj4+IGFybTY0IGFsc28g
aGFzIHtyZWFkLHdyaXRlfXtsLHF9LiBBbmQgeW91IGxpa2VseSB3YW50IHRvIHByb3RlY3QgdGhl
DQo+Pj4+Pj4gNjRiaXQgcmVhZCB3aXRoIENPTkZJR182NEJJVCBpZiB0aGlzIGNvZGUgaXMgdG8g
YmUgbWFkZSBhdmFpbGFibGUgdG8NCj4+Pj4+PiBhcm0zMi4NCj4+Pj4+IA0KPj4+Pj4gSSBuZWVk
IHRoZSB3cmFwcGVyIGJlY2F1c2Uge3JlYWQsd3JpdGV9e2wscX0gZnVuY3Rpb24gYXJndW1lbnQg
aXMgZGlmZmVyZW50IGZvciBBUk0gYW5kIHg4Ni4NCj4+Pj4+IEFSTSB7cmVhZCx3cmllfShsLHF9
ICBmdW5jdGlvbiBhcmd1bWVudCBpcyBwb2ludGVyIHRvIHRoZSBhZGRyZXNzIHdoZXJlYXMgWDg2
ICB7cmVhZCx3cmllfShsLHF9DQo+Pj4+PiBmdW5jdGlvbiBhcmd1bWVudCBpcyBhZGRyZXNzIGl0
c2VsZi4NCj4+Pj4gDQo+Pj4+IE9oLCB0aGF0J3MgYSBzaGFtZS4gSSBkb24ndCB0aGluayB0aGVy
ZSdzIGEgbmVlZCB0byB0YWcgdGhvc2UgaGVscGVycw0KPj4+PiB3aXRoIHRoZSB2cGNpXyBwcmVm
aXggdGhvdWdoLiBDb3VsZCB3ZSBtYXliZSBpbnRyb2R1Y2UNCj4+Pj4gYnVzX3tyZWFkLHdyaXRl
fXtiLHcsbCxxfSBoZWxwZXJzIHRoYXQgdGFrZSB0aGUgc2FtZSBwYXJhbWV0ZXJzIG9uIGFsbA0K
Pj4+PiBhcmNoZXM/DQo+Pj4+IA0KPj4+PiBJdCB3b3VsZCBiZSBldmVuIGJldHRlciB0byBmaXgg
dGhlIGN1cnJlbnQgb25lcyBzbyB0aGV5IHRha2UgdGhlIHNhbWUNCj4+Pj4gcGFyYW1ldGVycyBv
biB4ODYgYW5kIEFybSwgYnV0IHRoYXQgd291bGQgbWVhbiBjaGFuZ2luZyBhbGwgdGhlIGNhbGwN
Cj4+Pj4gcGxhY2VzIGluIG9uZSBvZiB0aGUgYXJjaGVzLg0KPj4+IA0KPj4+IFlldCBzdGlsbDog
KzEgZm9yIHJlbW92aW5nIHRoZSBleHRyYSBsZXZlbCBvZiBpbmRpcmVjdGlvbi4gSW1vIHRoZXNl
DQo+Pj4gdHJpdmlhbCBoZWxwZXJzIHNob3VsZCBuZXZlciBoYXZlIGRpdmVyZ2VkIGJldHdlZW4g
YXJjaGVzOyBJIGhhdmUNCj4+PiBhbHdheXMgYmVlbiB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0
IG9uIExpbnV4IHRoZXkgY2FuIGJlIHVzZWQgYnkNCj4+PiBhcmNoLWluZGVwZW5kZW50IGNvZGUg
KG9yIGVsc2UgZHJpdmVycyB3b3VsZCBiZSBxdWl0ZSBoYXJkIHRvIHdyaXRlKS4NCj4+IA0KPj4g
U28gdGVjaG5pY2FsbHkgYm90aCBoZWxwZXJzIGFyZSBhYmxlIHRvIGNvcGUgd2l0aCBwb2ludGVy
LiBUaGUgeDg2IG9uZSANCj4+IGlzIGFsc28gYWxsb3dpbmcgdG8gcGFzcyBhbiBhZGRyZXNzLg0K
Pj4gDQo+PiBGcm9tIGEgYnJpZWYgbG9vayBhdCB0aGUgeDg2LCBpdCBsb29rcyBsaWtlIG1vc3Qg
b2YgdGhlIHVzZXJzIGFyZSB1c2luZyANCj4+IGEgcG9pbnRlci4gSG93ZXZlciwgdGhlIHZQQ0kg
bXNpeCBjb2RlIGlzIG9uZSBleGFtcGxlIHdoZXJlIGFkZHJlc3NlcyANCj4+IGFyZSBwYXNzZWQu
DQo+IA0KPiBPa2F5LCBmaXJzdCBvZiBhbGwgSSBuZWVkIHRvIGNsZWFuIHVwIHNvbWUgY29uZnVz
aW9uIGNhdXNlIGJ5IFJhaHVsDQo+IHNheWluZyAicG9pbnRlciB0byB0aGUgYWRkcmVzc+KAnToN
Cg0KU29ycnkgZm9yIHRoZSBjb25mdXNpb24uDQo+IFRoYXQncyB3aGVyZSBteSAiZXh0cmEgbGV2
ZWwgb2YNCj4gaW5kaXJlY3Rpb24iIGNhbWUgZnJvbS4gSSB3b3VsZCByZWFsbHkgd2lzaCBvbmUg
d291bGRuJ3QgbmVlZCB0byBnbw0KPiB0byB0aGUgY29kZSBhbmQgdmVyaWZ5IHN1Y2ggYmFzaWMg
c3RhdGVtZW50cy4gVGhlcmUncyBubyAicG9pbnRlcg0KPiB0byB0aGUgYWRkcmVzcyIgaGVyZS4g
VGhlIHF1ZXN0aW9uIGlzIHdoZXRoZXIgdGhlIGFyZ3VtZW50IGhhcyB0bw0KPiBiZSBhIHBvaW50
ZXIgKEFybSkgb3IgaXMgY29udmVydGFibGUgdG8gYSBwb2ludGVyICh4ODYpLiBUaGVyZWZvcmUN
Cj4gLi4uDQo+IA0KPj4gQUZBSUNULCB0aGUgcmVhZCovd3JpdGUqIGhlbHBlcnMgb24gTGludXgg
b25seSB3b3JrcyB3aXRoIHBvaW50ZXJzLiBTbyBJIA0KPj4gdGhpbmsgdGhlIGFjdGlvbnMgc2hv
dWxkIGJlOg0KPj4gICAgMSkgTW9kaWZ5IHRoZSB2UENJIE1TSXggY29kZSB0byB1c2UgcG9pbnRl
cg0KPj4gICAgMikgTW9kaWZ5IHRoZSB4ODYgcmVhZCovd3JpdGUqIGhlbHBlcnMgdG8gZm9yYmlk
IGFueSBhY2Nlc3Mgb3RoZXIgDQo+PiB0aGFuIHBvaW50ZXIuDQo+IA0KPiAuLi4gSSdkIHN1Z2dl
c3QgdG8gZ28gd2l0aCAxKSwgdG8gYXZvaWQgaW1wYWN0aW5nIG90aGVyIHg4NiBjb2RlLg0KPiBM
b25nZXIgdGVybSBJIHdvdWxkbid0IG1pbmQgc3dpdGNoaW5nIHRvIDIpICh1bmxlc3MgdlBDSSBy
ZWFsbHkgaXMNCj4gdGhlIG9ubHkgcGxhY2UgdXNpbmcgbm9uLXBvaW50ZXIgYXJndW1lbnRzLCBp
biB3aGljaCBjYXNlIGRvaW5nDQo+IHRoZSAybmQgc3RlcCByaWdodCBhd2F5IFtidXQgc3RpbGwg
aW4gYSBzZXBhcmF0ZSBwYXRjaF0gd291bGQgc2VlbQ0KPiBxdWl0ZSByZWFzb25hYmxlKS4NCg0K
SSB3aWxsIGNob29zZSBvcHRpb24gMSBhcyBvZiBub3cgdG8gYXZvaWQgYW55IHg4NiBzcGVjaWZp
YyBjaGFuZ2UgdG8gDQoge3JlYWQsd3JpdGV9e2IsdyxsLHF9Lg0KDQpSZWdhcmRzLA0KUmFodWwN
Cj4gSmFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 09:59:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 09:59:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250267.431083 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbvi-0004QZ-E5; Tue, 21 Dec 2021 09:59:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250267.431083; Tue, 21 Dec 2021 09:59:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzbvi-0004QS-9c; Tue, 21 Dec 2021 09:59:34 +0000
Received: by outflank-mailman (input) for mailman id 250267;
 Tue, 21 Dec 2021 09:59:32 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzbvg-0004QM-RR
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 09:59:32 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b12e8958-6244-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 10:59:31 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-2-dsDafIJ-Mqm2GuIG34pHIQ-1; Tue, 21 Dec 2021 10:59:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 09:59:28 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 09:59:28 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b12e8958-6244-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640080771;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding;
	bh=ayGzQ0a7dhRSTBTGqrdb54DYbHONXB0mWBYHh+Q3Iyc=;
	b=ftfnAQAbIG4BJfzyrxl+nPueLJUkRNt4m4JoOfB1ZdI25wNhgxGQiYvl9FzJeDuCW4vC5A
	VhIozsv50FKkN9P0iTV2oSbtJMqeHbwHbgviX3MZ3msUtYHXGcIH/s/7GinpePSSeskqLt
	RdJAk6B/BoM50Emv8r88ElpfXpLq6YQ=
X-MC-Unique: dsDafIJ-Mqm2GuIG34pHIQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Iy0FVB/ohj6QEvNN49hIq4jmm/CWfAx/M5DFFbShNCaWlk8OnSq7pzPJaRdHZS9sbXn269Yj9QWch49peL/4th1QEWlc5TASMfKfUKqFGOKcaTMCEFdyg1cY0AktdKZbYwGKqT/B7qOBHYU8NwillY0J5iX/3hKDr147BhZdUZJ0TOmEiSs7VA/v47Nyakcq6hVB2RXXjxPSiITrU7WH32WDNYfiwt6wRHUrN0rS80H9kSvO22mZoC9RkX11HFR6F5ws3jilekA1J/v/mR+DxABoaCW9MDiKKZyLLKUX69ZBuZv1e8Jp9QJ/ctH88Z8aH0eH8TU24TAO3W0JuInxVA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ayGzQ0a7dhRSTBTGqrdb54DYbHONXB0mWBYHh+Q3Iyc=;
 b=a7roMgcefFSQmtW+8Swq3ejcMXVzUBCsAbuc9yS6l9qKVQ1Rv6hzzMxAeWx73dNA0SDBjpSrgbyTUVvY7LLwa5V8WgeKHVrYac5M2iiBQrYF4t1yGkBLFGIaL4ZcTRp9vD72SDsuW2ExeTMlL59epA81/5rwgBx52YAsyVvJsLo4USx6x8FooEQFwD7lTa7e+aIlGDrDhsUpoZ5piBspsW+x7ozOs/4RuNeoJkC1lFm7EigxhBaQIgprXPBhVpmEsQCgBWspgYl0yzPTaBl/dayU9INEdPyCjminrubFmbhhM+Z3rNOD/VYogjtGpxmkOw/B8BoEkBgLzpFP/PRu4A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <18f57385-9a17-fc23-85e0-9d4a35c79ac8@suse.com>
Date: Tue, 21 Dec 2021 10:59:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Content-Language: en-US
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wl@xen.org>, Anthony Perard <anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] xenperf: omit meaningless trailing zeroes from output
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR05CA0003.eurprd05.prod.outlook.com
 (2603:10a6:20b:488::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e557c7ad-db69-4c07-f08d-08d9c46893c6
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5598B1484CDAB661AF9E064DB37C9@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	EcYkbHtZ+8bHTKQFkA7Bj4SL272mMtx+UlTvtdNx9IEzuappgUZ3vU16//lPBvl3uCKLNKST9dmqRI+x73FZy0fIjN0ATQch8hUAkiY4BkGnqpWpdBWCs4rwa1jGXlKDsrQ6hpF9tdknX8CnyXXsOsg8zG7pYAwihsJNDnFBeI0klp0VLhR20RZxCdzOsT2s9LXaNxiQ4IatITqlSb6e+hQKIhB2nfUVACfqfLKiioKeELxpUKmC6r+kyK4X7/01hJ5Oka2uD2VzPAKHDEBbFJJYPn4+9x3nMu9Gq9vD7cUqPwkKzZkXkZiCfdIdvZh4AoAN10deLC5nvq4Vil4iigFXqQtXk+K5ZdtrJdI0ayCBF0BsUncHwd+EIz/Y2O/c6J/ZmZdgrQ0zNZogxyA6DggUVboh1Wtu0K+GPiwpTVDgYz01UQ8YpXCWY0fKer9yI7lv+syVAu3sP8jDKs+0t3vl7eAIlS/zjAm1bLKp5oIvF4RksBEZ4WHeaJiy4jU94Ey2IYKA32ze9ZjWr+HWP8LRj1080t/ojDHZmsiGJnylITZkIxoAMkJqLjKVya2eCbM4wneYg91T87JlcxLnLxqs97tdrTVsbFf3v6MlvjXbzkzU2BuFxY252CHrn2yb21FFS58llACHGjDcON+TGD4bOFFyRnLJ/xMLUohgyH75CJXg8fxOkCBc4J3Kytf1OXuLxLcGwA+tNgNHpumWnChvXhPMqvgdwDVxzK9iR+bbnJHs4aX9O72hVrnzpkcY
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(186003)(31686004)(8676002)(8936002)(66946007)(26005)(38100700002)(6512007)(5660300002)(66556008)(66476007)(36756003)(508600001)(6486002)(316002)(6506007)(86362001)(31696002)(2616005)(2906002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QnpsYUcrWitwQkpZWkh2VnFFZXR5WnRwUk8zS0gwdFBLTWVCM0JMRkZRaTdL?=
 =?utf-8?B?N08xUW1OYkNjcEd5cVAxazBiYmtFQ0dYUUtMVEdBZnVuWEhHL1hYVit6T3NI?=
 =?utf-8?B?NlF3R056Um5NT0NESTFrM29HYVNCdWFhNG9saklCQmZ3SDYrUDR4QzFaUlpw?=
 =?utf-8?B?Y2NzUlhHSjFIYXdTV1J6TC9QWXdHMXJtUDNJa3lwZ283VXJ0K0ZVcFF3NGpr?=
 =?utf-8?B?SnpVNE9IREo2Tzd6bTdyTWpEa0F0T3hqbS9JQ2J2bnc4MEpGemprRGIvek51?=
 =?utf-8?B?WmZVTnpuQUpJUzlTTVpmbmVRNWRraU5wMkZEYUpybWFqYVBONGhLTXBxK25X?=
 =?utf-8?B?WHFTRzJqRkZXYmdUVUM1cGo4MEJEbU5XTkhrRC9xY3NtbWdLc2N3cUIwS2tH?=
 =?utf-8?B?RXg0ZHBDRG1sR01CQVBtK1BZNm4wc1RiTjRPR1pDUTNNV3ZwNmJsdTNCVDRt?=
 =?utf-8?B?blJGZ3paQ1p2ZW9CdlJ2ajdIcG1wU0VaaHMvQk5GM09WZTRKZjZrRktBdVVz?=
 =?utf-8?B?Q2dscGdNbEVYWG85RE45Um9kQUl0VFlTRTF4SkN2RUg2d3VsMTk5Y3gvbXRH?=
 =?utf-8?B?TjdwNGxUVUt2UmlQaFNlNWhBUVBRMU91ZG5SN0t4RW85RUVtS0tGdzZYUFpE?=
 =?utf-8?B?em5Xa1JrVzd4YXdjNHpTTGhySGwzLzFsK0UzaitPS2REa29zVFE2QTdVdm9a?=
 =?utf-8?B?Qm9vQXdoSHppb21jRFhiN3BQb1BTRDBYTVl2Z2h3cDBsQy91dE5EVUNGNDF1?=
 =?utf-8?B?WUpxRzBZdHZXUTA3OUZVK1gvSURZeWljbURKazh4VEMzKzAwUGoya0FYTHhP?=
 =?utf-8?B?QlEycG53eTdCditNdk9DVHpFblpFSm9xZTNDdGxHUWlCSDY5V2sydVZuZ2tJ?=
 =?utf-8?B?emtUQjB5eFc1UGVFaEQzUXIrY0pjUVhMRElDQnlyNlVqb0FWNUVpZ25qeVE0?=
 =?utf-8?B?clltbFFMcWxDUFd6cmdqdFk0THliVmU1R2pyWXVSY3V2U0dXWEhCSUVpSzcy?=
 =?utf-8?B?VFlYKzg3d1BzY29Ib2pDaXVTdStNY2N5YXltdHRrMDZiVUdBaHFUekp5NVFt?=
 =?utf-8?B?QlBwU1A4ZERMdG5sak5zOXlKc01yRmI1SXpiUTZGYUlGdkhUb2FucU83dExR?=
 =?utf-8?B?aHRNc0V0Zno2aVhoZm9BSGh2QkYwMElMSmVYYmg2MjJHT213bGlyM0NCMWhG?=
 =?utf-8?B?bEdtWUVZdXNNK1dpQkhpMmtxNHpmbVFCNFFPRVBVQTNtcU9IL0FpaUwyTGZQ?=
 =?utf-8?B?bXVKY1RrWW0waE5IRTlUaC94V1pNdktrTU82bDVQdlFyMFBYWm9VTzMwcHBK?=
 =?utf-8?B?WXkyMWl2cmw0WUpIZ3lKQVRNTnBaR3JBVFNRRnFQWWIzWnFwRHh6bVAydGVU?=
 =?utf-8?B?bGpaWGRBZ0pLSHlwZUM0ODhiVHlqb3VFWUpFeGhySENzY3BLYTFyN2l0L3Jr?=
 =?utf-8?B?QkdVd3pjbm9lRHpBbnhUbDdNa0M0Y3l2Z0R5SlFFYTlTZGxnYTZuY004bC9W?=
 =?utf-8?B?Z1hwSDNNYWtZTG9scEhuOXpnNTlUVGpRS3JIVGU5NjhJRFptb0JtQUYrMWln?=
 =?utf-8?B?WU5jWnkyVC8yQm4zK0xadmMybm1JRFJEcVEyMlRkSGMrZjhyRDhPQmZ3Yjg2?=
 =?utf-8?B?dDFTaVBXNWVYYjBseVdrK0NPNkQzZm5YU1ZEY01CT1BLdkwwbkhwME1JZDhB?=
 =?utf-8?B?bEhRR3VhUmU2VHpOMG5CRCs3WUlKaExNTHhnNzNuTHRxUy9ma2hVR21hVWRx?=
 =?utf-8?B?OGorbkNiMisydzZVRFgzbTVTS1hwMmJxNVo3aW5UaEpQWHhwODlRRVExVnFO?=
 =?utf-8?B?S29BZkFabmZVL3o0REFlUXV2eGI1YmRzYW8wRm12T3FqWERjWG5VTGQxSE5H?=
 =?utf-8?B?SUdTZ0Y0dHJNVlVqU2M3UFVVTStRNzdQNmNCVkR0VDBTMXdtdGRmOEVjbGJ2?=
 =?utf-8?B?aTJrVnFnYUd2UGJZVkUwdzlDTHcwQjJCaTRKQUFTTXVaZ0Z6eExrejNRajZw?=
 =?utf-8?B?SHBtaUlZdC80SXlkVTI1TlFvWC9ra3N2NW0zQlRpc2h1djZ6Wm9OS0dFMUd6?=
 =?utf-8?B?djU1QmM1c24wQitUZk96WWFkbGh5aEdNODJGa0ZSU0hZNWJIckFPUldRdlpt?=
 =?utf-8?B?d0ZWRjdZbnZuck5EeGFLa2FIVUlXNWcwYXlZRjhQbDZ3dXpNTWllNU5nS2RS?=
 =?utf-8?Q?g/7U5I/jtJioRDZxEIbMxaU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e557c7ad-db69-4c07-f08d-08d9c46893c6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 09:59:28.5866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n8TBHTQ4Wgr5joZV79GWJn6eb80HsuEpT2SQf9DUatrzbQK9D1c/R4JhDfezRaWrG4tIO97ns5OxdyW3oeX06w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

There's no point producing a long chain of zeroes when the previously
calculated total value was zero. To guard against mistakenly skipping
non-zero individual fields, widen "sum" to "unsigned long long".

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/misc/xenperf.c
+++ b/tools/misc/xenperf.c
@@ -76,7 +76,7 @@ int main(int argc, char *argv[])
     DECLARE_HYPERCALL_BUFFER(xc_perfc_val_t, pcv);
     xc_perfc_val_t  *val;
     int num_desc, num_val;
-    unsigned int    sum, reset = 0, full = 0, pretty = 0;
+    unsigned int     reset = 0, full = 0, pretty = 0;
     char hypercall_name[36];
 
     if ( argc > 1 )
@@ -158,14 +158,15 @@ int main(int argc, char *argv[])
     val = pcv;
     for ( i = 0; i < num_desc; i++ )
     {
+        unsigned long long sum = 0;
+
         printf ("%-35s ", pcd[i].name);
         
-        sum = 0;
         for ( j = 0; j < pcd[i].nr_vals; j++ )
             sum += val[j];
-        printf ("T=%10u ", (unsigned int)sum);
+        printf("T=%10llu ", sum);
 
-        if ( full || (pcd[i].nr_vals <= 4) )
+        if ( sum && (full || (pcd[i].nr_vals <= 4)) )
         {
             if ( pretty && (strcmp(pcd[i].name, "hypercalls") == 0) )
             {



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 10:15:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 10:15:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250277.431094 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcAn-000703-VB; Tue, 21 Dec 2021 10:15:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250277.431094; Tue, 21 Dec 2021 10:15:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcAn-0006zw-SB; Tue, 21 Dec 2021 10:15:09 +0000
Received: by outflank-mailman (input) for mailman id 250277;
 Tue, 21 Dec 2021 10:15:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzcAm-0006zk-JV; Tue, 21 Dec 2021 10:15:08 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzcAm-0006Hn-A1; Tue, 21 Dec 2021 10:15:08 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzcAl-0000Hv-Vp; Tue, 21 Dec 2021 10:15:08 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzcAl-0005cw-VO; Tue, 21 Dec 2021 10:15:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=9gBRbfngcbFEWUUtOnOzndPZiFC2PoGG54bSJZd7USk=; b=MWBFTrMXug6wu6TNqLWKTCVjYC
	wEQrZQ2BO4FmmGU9SPRUJb/gfU8cg+bdRwYw6J0qYExirBNrPY97/QFsIApywKaUzX2xjt01iubZm
	A5DyHpCWwu8btdYB487gbmANbQNl1LlPlCM7wstF0a2jLlfvYbIRvSriDlFTAyGwVWjk=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167499-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167499: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=adc0eaead0ebe11f38798e431d2748bfe9b54a30
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 10:15:07 +0000

flight 167499 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167499/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              adc0eaead0ebe11f38798e431d2748bfe9b54a30
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  529 days
Failing since        151818  2020-07-11 04:18:52 Z  528 days  510 attempts
Testing same since   167488  2021-12-20 04:19:01 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90082 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 10:28:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 10:28:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250285.431105 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcNL-0000Bd-7A; Tue, 21 Dec 2021 10:28:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250285.431105; Tue, 21 Dec 2021 10:28:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcNL-0000BW-3W; Tue, 21 Dec 2021 10:28:07 +0000
Received: by outflank-mailman (input) for mailman id 250285;
 Tue, 21 Dec 2021 10:28:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzcNJ-0000BQ-SR
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 10:28:05 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id adc06afb-6248-11ec-8d39-b1a4ed000e3e;
 Tue, 21 Dec 2021 11:28:03 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-16-adcV3999PuiK-YxZMV7DKg-1; Tue, 21 Dec 2021 11:28:01 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 10:27:59 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 10:27:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: adc06afb-6248-11ec-8d39-b1a4ed000e3e
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640082483;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=TeorPbmK4xA/qK6GK0zZUlvYr4koE5RgSO8GtZKqbbo=;
	b=Yp2a3GRZOKqpqnSVYLfFWr/cOpBgYCJJ/BXhHFqvaJYcThAb+QXhPV6o4tyUrCUxQXvPR7
	7RGwUvAkYCfhao/2YX+blm6+qYu3sbYoH0sHMWwpbqstU+FERcDGB1pyCjLPB08pOoGoU1
	YYOm1eALklpmq4fxNWmdjFwyktaDYBI=
X-MC-Unique: adcV3999PuiK-YxZMV7DKg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=UCiATofkT6uv0Z5Y/NtbYnUHjAofM9HTKvtlyksih7YrdqxcNwgmdz0s0CPaf22+PvK4w5/5/aHjsGHcbBpc/YbRP+MvdqkiKRBaj7+Xt7lLCDUgo4eMWDwTC2IhZIryghlXFkVDcrhuUvUYiLYhHmXu3MxWYo2rsKZ/0KKnzCaI+KhsKmKsXsNpPvEPW3u87QRknQ2W69qWHFAwHRQ8zx99uDWfcrnNwHk5U1m5W9C6MqMbuZTl0xwYKTwN4UOr9LuhLIJqwv0h2WbnieRAHQD42wzLRFPbzfhj9u02B6QJBIS1OuatnXWMSMqsFKcUdeBPswSMNuqA57SMzgPTww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+MgJQtXGk+8EPq85VhQcNTrmoGDyXH9sJ7Zoej/YbPI=;
 b=AsknbHHVKXhBN1SHiio9gmo9hz9gi3EbLQDDirtRnpab1yuUnI4u0p/lKJHBl4HM9qE0uo7SVPfpKve49PcJ5sW+W4yAx32O+SajZVBuVtRg9XhOjHvJjrbNH8KVxzLXKLYUfI7qnRYezvWEqhLA5/rTQW7ZCCXpyy3a51HTwBi0JKUuw6TwTsN9c8WUgRBkV887qGAjqvhqO8NrTSyN1yQnNE77NzIRt76y+TM2LSe7rgAVrKAKwflgd+DenNj3brO3KnzkcpizM0fyZIB8UUwtKWXsuzOyiYwd7XEtwM9vNcULOFvK3F91CSQ15Ajp8a2eTEnDOgQ7byigxoDLTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <2784dbb8-9237-0847-2be6-ff8a216a29d9@suse.com>
Date: Tue, 21 Dec 2021 11:27:56 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 3/5] VMX: sync VM-exit perf counters with known VM-exit
 reasons
Content-Language: en-US
To: Andrew Cooper <amc96@srcf.net>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>,
 Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <57038a1c-671b-f0f9-1bf1-0ff9bae6e2dc@suse.com>
 <efb282e9-4ddd-22d1-a2e4-36a4d0964ada@suse.com>
 <b083029a-6669-d03c-4b8c-c3b1ed28143c@srcf.net>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <b083029a-6669-d03c-4b8c-c3b1ed28143c@srcf.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AS9PR06CA0014.eurprd06.prod.outlook.com
 (2603:10a6:20b:462::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a5f1db0-dfbf-4a90-f869-08d9c46c8f39
X-MS-TrafficTypeDiagnostic: VI1PR04MB5598:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5598B79519DB125BF1A430DFB37C9@VI1PR04MB5598.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5O3LeDMLwm+PKIrk7MdkSSJE9v4Z1cgQX7SQj8aCXfINvxMlJiat++g4M2G/jGNNdoyObp3oBQeG9rA0dK99b2KHHuZPaKreFeMbrjsS2olVBIMX+c6ByZkGWP41QPPVWlq4eNWB3kn8L0RfV9OEzYqdo1LnN7scspqx+hIiOXSyqgkE3tZxwYvoZ7snu9uwqXZ+W534QRzFRyi7hEDBHWrH7W2QYzD/7KgncLE4GRtd0syETY2V+mivUQRSE4R5XbGc3CZ+uQnkGpHhX37Quo1fqnEBiMb6PyJpwR7QsQpTTpcRl3Qpa5trS5sAy47HjvM65H+wuSxtGi/mN8OPaHd8cXkWpQzDuS9/x5nO0Jqz5bv8ci1LdkSwSJpGaumNjPcni1i4l7US0/+ppzt3R2Z2UsFigrsfy0HAepADYbHfca/G3uFUaBJnFhESYFisFrxfPoiZpRk91c1k4RmAiU+Oa3Bwy48dRyakl76uSAtEKicMCZZSbKhPxjoFPWMUsNjRzuxmYN7nm/E+qYIoEBPsGFLvOSfdhVr1vRGhDFWw/XEOEGAgql/8953PGx5IlfL7KT5O4zsM8oXkB2IQLjRk7N8bQMnkK4RYVQezohIFV193nazTW6i2A1WJNdz4QUz5qTcsH6gmgphCzwEvvjLHJwHLQ81sPyjZWNCW5UIyGYGBzbIG8bkduhNyCDLYZGuh0J4nVF4KVDCjcdzvwE40C18Hb8P78+mmx5ONly0=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(186003)(31686004)(8676002)(8936002)(66946007)(26005)(38100700002)(6512007)(5660300002)(66476007)(36756003)(66556008)(508600001)(6486002)(316002)(53546011)(86362001)(6506007)(31696002)(6666004)(2616005)(83380400001)(2906002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ialUqEkJuYAu3GPluYrvkFJGlmZOG+u2khDVcRPSh8REpnPupQcBRT5//H2N?=
 =?us-ascii?Q?rguQ3Dj9cG5Vdw49tWub5t0dQswCu5yAJwoaHTG3gtlX1rJxdy7rVvvjd3Od?=
 =?us-ascii?Q?i6IHGtO2YOLTN9YDri/5vBFUlaafoM1OlWLiAE2WLgNUdut8PvM2eVr748cx?=
 =?us-ascii?Q?Ud2whOKSM0bC7lAeT20JkiJ7BbJR4U+5GxzuYtKElrz6pglsJt+n7FDv57aG?=
 =?us-ascii?Q?2GyekXminvITGUy43GVdFHhkxOp1EfSOs1wv7ke9b8ZxpMJMgMJRGhAiLBDy?=
 =?us-ascii?Q?rZAy3Rc0py+a/Jhgnz3zBDsGi9WuNZt+gQZYSV4asv04LEwvnK9LB9AxDI5I?=
 =?us-ascii?Q?D929SRxm6CXG/nPOp1LqwT3YP9PMA0okj72upzQvaRzGvCplx+GbBDLE/QjS?=
 =?us-ascii?Q?+K0gk+TWiJBWPBjPMBx4TDdwr2vmzafkR6+nuLzpXpGUCdu/DDjkbCnsEoPT?=
 =?us-ascii?Q?lxrRIkAg0Ov34BIg+28bVzNmd3L00pLXrx/B8j5MsMuIl2mhmRGCFACTSuWq?=
 =?us-ascii?Q?SRsg6nzgEC/pJVmvUS+8nprp5XE819Jq3XxzLoe4FzMkfvspnhVgei48XKrI?=
 =?us-ascii?Q?naOPyjAGvm71OUU79rIRSWljTfC6eTofVixakNqvGxdxKGVcd/N3ELrecOMu?=
 =?us-ascii?Q?ERZoOSMfNH5BewJQCSmHf06AfloDV7X2LovvhM3bH8EjV5Kh9pN8WQvNxVLw?=
 =?us-ascii?Q?7V6O2w9O8BFfXxx41fUUItFl6/nA32Hjy5ueh7EGdULuasbbSaZIi1HqH4Pz?=
 =?us-ascii?Q?VmcF3MYdLWG5j1Ar3kMKLuMJY9UjhhFzTHL4GLSZPrS5EgIDc/siKnpXTCBy?=
 =?us-ascii?Q?d+M32CQAaJXIgm+B/EiM/OXCOZGoL238T8aN/hagZMgynhn7UThiw0p0Tp8R?=
 =?us-ascii?Q?5E8Q6IKZoYjG/BFnRFJsfF7vNaymRzzVz8QI1dLSnrZYZ78zoQkHqdxuglWf?=
 =?us-ascii?Q?1hj949FKNNkOLJ9MWFKrHTPS83z5h+ZdKcXq8kmtvmkYdAyjdXeuV6Q4z/4N?=
 =?us-ascii?Q?I284WxfP2eMXnL6tjjoEB2S0TdRvhiQGwTyBQz4er6YpQlo1ZHFTjHH9QD0x?=
 =?us-ascii?Q?9z8ZJ08yiaU603mEHAu793ZnGwSnTEJTcIhe6odNf4AkZoGpt7k2pt9TuPB6?=
 =?us-ascii?Q?hWStZqD3zd1Yx5CBr0B+EedtPhN0e2b9eU0pnexWoExfygvTkMjIt0RI3M+Q?=
 =?us-ascii?Q?aEx8Ux21tiZpXUuA6sAEf42N1ZMu9CQZpWK9pqc62R98zSCR9QM6yoo4kBww?=
 =?us-ascii?Q?jzZWPu/xNtsn4Cq8fdjZ9sgAhwmMqF3uwFQrMQWn2zP6Yq2wjM78sXHkdPsO?=
 =?us-ascii?Q?LszM3XFSiSECv9HCTqsHwubwa0p/zbuMpHbVZmhY8uFqwW5jKUqI1g6OXeAM?=
 =?us-ascii?Q?1ADPLKtG0xeIW9m7gjvGt5eQaIeEg7k0+yst7evxeWxxFESPQlvHzSx0z3C1?=
 =?us-ascii?Q?D6mbUU1kank6S5bodf3HbnjZh9ipBeuTEH14IZcYBdiH8b8WnZka+ndyYRNq?=
 =?us-ascii?Q?CnoEpUM43jNqRuoBu+nYLGhZQtfzy5ST774Otklkls4W9e/lQK1Dr553Uejz?=
 =?us-ascii?Q?x3wKqe224D+ixSBffLoDj3gy5gi9X5S8/QuEgTkVYBgCK8h8vxQh7FWUoR8i?=
 =?us-ascii?Q?IrLR/ih8AJ9Hhs9rn3AmU+I=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5f1db0-dfbf-4a90-f869-08d9c46c8f39
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 10:27:58.9608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zl3jsTezNIorW3EaoQ6QXECHpbr5IsLMEP7deto1EXSMtrIDEQ+w3lhUkqfk8tJUr20ZV4ADcME0X046hHZI3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598

On 17.12.2021 16:00, Andrew Cooper wrote:
> On 03/12/2021 12:05, Jan Beulich wrote:
>> --- a/xen/include/asm-x86/hvm/vmx/vmx.h
>> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h
>> @@ -220,6 +220,8 @@ static inline void pi_clear_sn(struct pi
>>  #define EXIT_REASON_XSAVES              63
>>  #define EXIT_REASON_XRSTORS             64
>> =20
>> +#define EXIT_REASON_LAST                EXIT_REASON_XRSTORS
>> +
>=20
> Given the problems with sentinals like this in the domctl/sysctl
> headers, I think this scheme would be less fragile if EXIT_REASON was an
> enum.

Enums have some "downsides", so I'm not sure I'd want to go that route,
at least not right here.

>=C2=A0 (Also, we seriously need to reduce the scope of these headers.=C2=
=A0
> It's only just dawned on me why Intel uses EXIT_* and AMD uses VMEXIT_*)

Funny, isn't it? Otoh the PM specifically uses VMEXIT_*, while the SDM
specifically talks about "exit reason" everywhere. So there may be more
to this than just the need to avoid name space collisions.

And yes, I fully agree with the need of scope reduction. These
definitions living in a private header in xen/arch/x86/hvm/vmx/ should
be completely sufficient for the build to continue to work. Question
is if, while doing so, we wouldn't want to alter the name prefixes (but
see above).

> Alternatively, what about simply this:
>=20
> =C2=A0#define EXIT_REASON_XSAVES=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 63
> =C2=A0#define EXIT_REASON_XRSTORS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 64
> +/* Remember to update VMX_PERF_EXIT_REASON_SIZE too. */
>=20
> ?
>=20
> This avoids having yet another sentinel in the mix, and will be visible
> in *every* patch review.=C2=A0 It also gets rid of the ifdefary in the vm=
exit
> handler.

I can do it that way, sure, but then there'll again be no build time
check. As long as exit reasons all get added sequentially here, the
comment in context should raise enough attention, but what if Intel
start a second range like AMD did with NPF?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 10:45:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 10:45:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250290.431116 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcdf-0002iy-Me; Tue, 21 Dec 2021 10:44:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250290.431116; Tue, 21 Dec 2021 10:44:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzcdf-0002ir-Jb; Tue, 21 Dec 2021 10:44:59 +0000
Received: by outflank-mailman (input) for mailman id 250290;
 Tue, 21 Dec 2021 10:44:58 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzcde-0002il-8L
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 10:44:58 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 08b06d41-624b-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 11:44:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 08b06d41-624b-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640083496;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=NFh01Z89MiMRh83q5rwihdC/3dcH9m4/94T6EpSM6D4=;
  b=awPW1upkyyzQnc617G3E+ncd7km0oBhHSuWoHPmazn1SVU69iZSAKsEu
   7nRbl6uItYOb4HEBD6vt9jPyrbkS3l6lUwbAfmZZap3l8ZRpWTz0+ju8w
   iR+u59z0ZUR7ykZukNgfv3eIvyCB7O6RbmqlstGGmD1XVy1xW8GA5OOjy
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: Ja0SI1wxXJ//e/YHuO/7m75Y4nK5wAHA4EDYaVHgzPbgNigoTIEdFGk16hP3cF5TTPnQESrkZs
 eLxptRml5W9k58ZqA3otPVzIct0KnvyNAQ9dn98fpB/mWgSt8PxqrJBwkJvNgaXdmMEqEb/YIY
 4Tg4ZfgnHm+RS/zavFIwUzjKGQh2NiLVOaNWz1XFYIsqH6qtG6numEA4N89nDCdFuY3COKSaF0
 p3a8c8Ri7OD7mmeNtjvR+5mdwZraTrTvgm8SyzIvj32v0Gqj38q+eKQT7BCpg+czfdbhJH7/4x
 WnJ/bVlPe1GNN3XtCGh2OxuH
X-SBRS: 5.1
X-MesageID: 59992861
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:L6/QpapAXezC/i/dxQfGTxN/g55eBmLVYhIvgKrLsJaIsI4StFCzt
 garIBnVafaDMWqnLtgnbImx80tSvJKAxtNmS1Y//3o9H3sR85uZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24LgW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCnZq9Cho3Oqzso9wEdikGLTFBPoIY4bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O
 ptIOGA/Mk2ojxtnOm0VWao+jLyTpnD1UBZauHCnjqsR/D2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq
 2SA+H72ajkKOdraxTeb/3aEgu7UgTi9SI8UDKe/9PNhnBuU3GN7IB8cWEa/oPK5olWjQN8ZI
 EsRkhfCtoBrqhbtFIOkGUTl/jjU5XbwRua8DcU85UKQ1K7Vwz2hH000EABRV98J6tY5EGlCO
 kCyo/vlAjlmsbuwQH2b96uJoT7aBRX5PVPudgdfE1JbvoCLTJUby0uWE409SPLdYsjdQGmom
 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CHvJ6sz67DFzFtW
 UTofeDEtIji6rnXy0SwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpcIWW0P
 xOJ4FgLjHO2AJdMRfUvC25WI551pZUM6Py/DqyEBjawSsUZmPC7ENFGOhfLgjGFfLkEmqAjI
 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q
 I0EaaNnCnx3DYXDX8Ug2dJJcA1RcyFkXcueRg4+XrfrHzeK0VoJU5f5qY7NsaQ890iMvuuXr
 Hy7RGFCz1/z2S/OJQmQMygxY7LzR5dv63k8OHV0b1qv3nEiZ6ep7bseKMRrLeV2qrQ7wK4mV
 eQBduWBHu9LFmbN9QMCYMSvt4dlbhmq216DZnL3fDglcpd8bAXV4du4LBD3/SwDA3Pv58szq
 rGtzC3BRp8HS1gwBcracqv3nViwoWIciKR5WE6Reotff0Dl8Y5LLS3tj6Bof5FQeEubnjbDj
 lSYGxYVo+XJsrQZytiRiPDWtZqtHst/AlFeQzvR44GpOHSI5WGk24JBDrqFJGiPSGPu9ay+T
 uxJ1PWgYuYflVNHvocgQbZmyaUyu4nmq7NAl1k2GXzKaxKgC696I2nA1s5K7/UfyrhcsAqwe
 0SO5tgFZunZZJK7SAYcdFg/c+CO9fAIgT2Dv/06LXLz6DJz4LfaA15ZOAOBiXAFIbZ4WG//L
 TzNZCLCB9SDtycX
IronPort-HdrOrdr: A9a23:/OhiVKtyIsu+MzXmQsL7X/Ea7skDWtV00zEX/kB9WHVpm5Sj5q
 STdPRy73PJYUUqKRYdcLG7SdK9qBznlaKdjbN6AV7mZniChILKFvAZ0WKB+UyCJ8SWzIc0vp
 uIMZIOauEYZmIUsS+O2miF+qEbruVvnprEuQ6U9QYKcegjUdAY0+5WMHfiLnFL
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="59992861"
Date: Tue, 21 Dec 2021 10:44:47 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [PATCH] xenperf: omit meaningless trailing zeroes from output
Message-ID: <YcGwH9s6sfS+hdCV@perard>
References: <18f57385-9a17-fc23-85e0-9d4a35c79ac8@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <18f57385-9a17-fc23-85e0-9d4a35c79ac8@suse.com>

On Tue, Dec 21, 2021 at 10:59:27AM +0100, Jan Beulich wrote:
> There's no point producing a long chain of zeroes when the previously
> calculated total value was zero. To guard against mistakenly skipping
> non-zero individual fields, widen "sum" to "unsigned long long".
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 11:15:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 11:15:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250313.431166 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzd73-0006qp-L1; Tue, 21 Dec 2021 11:15:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250313.431166; Tue, 21 Dec 2021 11:15:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzd73-0006qi-I4; Tue, 21 Dec 2021 11:15:21 +0000
Received: by outflank-mailman (input) for mailman id 250313;
 Tue, 21 Dec 2021 11:15:20 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzd72-0006qc-8t
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 11:15:20 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 474e9e61-624f-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 12:15:19 +0100 (CET)
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-27-LHq8Yo0KM3uGQ-WytTvr5Q-1; Tue, 21 Dec 2021 12:15:16 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4944.eurprd04.prod.outlook.com (2603:10a6:803:60::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.19; Tue, 21 Dec
 2021 11:15:16 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 11:15:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 474e9e61-624f-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640085317;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=c421I4jdQqcckOvvUsUkNt0MHyakGCRR5aIUBl3xD5c=;
	b=FrPmopc7qghE3nxII0RA44rzaTOzeKMswsn0y85LcroonM0+hQvDpr5y4Y6VQParry0153
	xLKFXWd3jPizS8iMBRNMK5AYDMrKORw7e2zkMxyhTC3ENuSU56of82InG3l4CMCbi5DEWt
	NkHC6GZ1Z7VoN6V6Yw+ZEMpmb0o2dv4=
X-MC-Unique: LHq8Yo0KM3uGQ-WytTvr5Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Fd7/sB18GsoQvuQl703NeRSasL3EBrTQzGg4kP3KNSdfjktXjMoC14DLpoj8krw3yJ6pr3K0te0BE1fJ/poX0wINhKT3QsOxqZGrV/zgaiFJEtDHwyeYXIVBgPXZ8XUP2Ym/6RN2vF4sX5+hblBamNWVgU6mX9U56AX6tAUP+4/RQ72dOmHoGAHv8OYDLdJmu5SpLjtqgJgtfETf8WSu9bzULm8V86/wqyTMm6SgkB49bXjYMmHmZlTNJh6Y3T252Y+iOpz5Wi2Cc2daF55t0RQU4uUtq6DCmry0DPAP2eck2js9fZdxJjn85F34oJb/ZxPM+1Z4EDzEt5tDAQLeYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=c421I4jdQqcckOvvUsUkNt0MHyakGCRR5aIUBl3xD5c=;
 b=SEDuEyaUcQ4jeGUt8dyq4mv3VDwkT48GjQhYLcmh5jn9oJ2Lr1bSb0EKnAIt5yxvZTIGHQNIl0cTI5I/JlGckIVaVmknKKLnbF1wdlFi0s8aMRJ6vAZUUut/2T2FbUGvaGSHt3bXwU1ft0YOQrft4IvkwOGClg9CcrFSK9Ol+NXWRjPs5RR5fEXZt6MMqmux/iiHpZw0zpZ1HjBVYlyWh4ze3zCIsF0jwQk43PoiEkiDM/MzwiWvvCh84My0RabXOYFkIbugRdNSxkAUFkXwMHtwS5NTzQPgOAOGRiwvl3GXog6RN3wpTZPRoG5KnOlXK8jUvOgIYV9RGNzAg5I8Tw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <af58fb00-39a2-314b-bbc2-6ca373707d49@suse.com>
Date: Tue, 21 Dec 2021 12:15:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 1/6] x86/prot-key: Enumeration for Protection Key
 Supervisor
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-2-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-2-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0242.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::10) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 482641d2-dc8a-4637-f6c4-08d9c4732a17
X-MS-TrafficTypeDiagnostic: VI1PR04MB4944:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB4944F1129F04C108A32BC5D9B37C9@VI1PR04MB4944.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	zsvF37DZWVeoCdC9uGfth4YuIU8GpZ8fMTMMfAPJFN4GEpfGlu4PRYSRrzwA9sf8n9GQ4Ac4JmXgZ9adqWORxFOb0QmqWlSSOQQSLKpfuh1GusxPi2+4/0UkKKGrEgSr4oMNzXO6Z8/4kaqtrG1JTo7yaJVxV5NBA7TzxK8HGbBWo+mR1yHhAamlAvMAGufbr43sKRLT5a3slzVJ3xK0o+QGRNljK63pJIYoGSr9j4Y/RctMWHdmZspSbSKt/l+6xXIDLmh4vnXDHXwPrzd45va9yyuilOpSmC6PLrYzCWq0vL3evhtXofx9+mCA45nHsTRCiZvloPnzCt7ecPvLeldPTvABW4Ey3ff2OExDo1eMwuTEKkzq7+TccF5BYIY77aw6WFGfQk2XZhvkPBGu1qmG5eZ940Fl413q1ErhPeuc2UHA67HlSwLQYHJ+zNAzUSuLa7KFKT89nuLIHX88uhqjvUfVEUpOUCVlrCY2DuJE5djXVG/0kVJAjJH/6iV38pP8SSNkLJh0HDSeFxu0hXmI28xJ4wDPqonTw2CB+wr4wlBufkt+UbYwTpQrSd9MOVh7VDeSzlXw2b44YVt7PPQQPDwIy6D8LCI/ZDVab4r2cgiCDIyGplCSMh8XH8rZexpqM+HnfUXKs9wxHAJcudcB/dRhim9vQdLajJ2pocb6fq9vQfNSDntYbO9bfxuBFr/5AzQwtGuL+/OePLF2HZ09cJXbGx4iIiArgt0Bwew=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(508600001)(6486002)(8936002)(36756003)(83380400001)(4326008)(54906003)(6916009)(6512007)(2906002)(86362001)(66946007)(66556008)(31696002)(316002)(31686004)(5660300002)(53546011)(186003)(2616005)(6506007)(26005)(66476007)(38100700002)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SEJkcE5BV29YSWhyakd1SWhkRTY1YXFEYnRQQUNPQlNkQ1c3NGtDMStFSkUy?=
 =?utf-8?B?eVNZR0ZJck9ZSENKUFJGZit4dWVhbzk0R1ovZ20rY0Z3dWxIaVBMYmg5KzV4?=
 =?utf-8?B?ZHdOVXlWRFp3M1JreGQvOHByUVdaNVdCQlhqdUxoemlNYjloYXZ2VW1MMlNG?=
 =?utf-8?B?VFRZVXNMelBLQjljeEplOVY1VmltaFI3NGUrQzhIYVZCZFJ6a1ZML09iT1NH?=
 =?utf-8?B?TlREOE9LN0FRVW1xa0puSjZRa3FqMDBHMTlQcDhyL0ZrSFEyZ2w0enppdExG?=
 =?utf-8?B?UGk0Y3pmMVlhbHdLVmxKeXJGNGNLSEx4SUh3WDBTY2dUa2Zkdk9uc1F1eFhZ?=
 =?utf-8?B?Y05jbTV3WGo1OUtVZTgwU0I4Q205RFdVTXhXZHhvQ204YjdscFBDWmhiV0hC?=
 =?utf-8?B?SEVHTitQSlI5WjQ4ZFR4MXpMTEFQY3lDYTBtSWxGOEZSdEwwcWhPR210VGtx?=
 =?utf-8?B?SmpKQTNUQ1pzdkl4Y2FlZ1lZRkJ0NnZqekV3SFhxREJoSGY4VGd5ZEpma0po?=
 =?utf-8?B?UjBJS1ovM1RwbGpLTURyRHJUUy9lUWJyd1o0MGxrTmR6Z2pHN3VmQ3BvYmxE?=
 =?utf-8?B?L0J2VlVSTS9Yby8yNTlneGVpNTBXZSt4TzRXT2VTZHArWmJkdDVSak9Geldq?=
 =?utf-8?B?UVZVK0VnVkZ3NXBXRFZjbW1VL0xNYXlBU1hUeHV6U1dTM0t2dEN1NzJXZmY5?=
 =?utf-8?B?VjI2bFFrdC81d1ZBZnlaYm94YTZBMGtWSFhsNXZRdEsvT2NGUTNTc29JNHps?=
 =?utf-8?B?VllOTDV6TTF5RU9iL0R5b0JoWGVZcVdDV29NN0Q2azdiNkNSRWpGdnA1UXNx?=
 =?utf-8?B?aXVZUVl0RE5kS29qdG8vcG5SdzB6U1U5dHNXK0VBUjQveW4xVEc5MXlYazhD?=
 =?utf-8?B?cEtoZ0VGWnRQb1BRcWFmWmpmbGNTMlZNVFIrT1RZWjBMdlFXTi9sYlJkV0k1?=
 =?utf-8?B?Qm9SQmViQTU2V0tBUDNPUG9RV0VUaWE2ckZ6bEtWN2Vybm05RjBVeEltMzJn?=
 =?utf-8?B?cHRvbWFpeHJtWGJ4MmF0QkpnNjFPYVF4ZGFQS2lQS21MblNyejRJa2xYaEs3?=
 =?utf-8?B?WmZKTi9yeExIUHAyNE1iZHdycDd1ZEh3S1dya3hXdVp1OVJPc3NwZEZHTjU0?=
 =?utf-8?B?bEF6d09aUDdsMEk0YjdSeVEvSzFVUXVRV2taWUNySnAzSjFQNEZKTG85elFn?=
 =?utf-8?B?eTBLeEI3VkZZbkgrV21JcExxZ0dtS2xtMHZWaW5oZWY0bzMyVEVnMTBJM2RV?=
 =?utf-8?B?MldWUEw3ZEtBZ0xoYml2eE1rcEhKZGE5WGQwRHFja2IxTWh1eUhrV0ZJc00v?=
 =?utf-8?B?SUdEdnRpM3JEVDJ1RThJRGlaaVZrMytkOGFlTS8vbVZIcEQ3UmF0dEJYYU5l?=
 =?utf-8?B?eXorNGtyNGhjemN4cmV3dVFMN0Ntek5sRDAwSGJSYXZIOWNKb0F1dkpQbi9Y?=
 =?utf-8?B?bHBHUVRjU3U4dXhvT3Z2VDJ2a1dJdUlDdHBzb3BkZHdCZTZnVjBnNEtTWDd5?=
 =?utf-8?B?SDhLbWp0WHJZRE5MY25lTXhxV1N4SGJZekZ3dzZSZENXOHE5SmQ3aWI2YVJP?=
 =?utf-8?B?VDlKaWRhMk5ZdVZ4a3o3ejYrM0MvZ05ENG41Z1ZWZzJacldMQzNOZXlpQ0I4?=
 =?utf-8?B?MEg0RDVJWG9BY2R0MmpXbllXZUpUK3d2V1FJUEFVbThEdW93ZG45ZjFFWDZB?=
 =?utf-8?B?SEhYY2hxWCtUWHZUa2k4WW5ZQ2NtYnN5RmtSRzgyWFNDMXBhWXVmcTBIMXVC?=
 =?utf-8?B?SnlhSEVuOW9TNEpFOXg3WE5GbWptQm9oem1Oay9xa25kcklTVGxCeDIrNUhB?=
 =?utf-8?B?NUNCdlU2K08wWGtvNnFFS0h6U0w4Sis1WHZFU1hnMEdiQlRSbDcrb0c5KzFp?=
 =?utf-8?B?SHNFYjRtcWYvcndOTDdlYUhlNEE5anFyRkZveUh6VFNmNFVuVWZxRi9EUDFt?=
 =?utf-8?B?djJZK0svWXM0TVBvM3V4S0xtSi9KeHRaR1NHb0xhbEc2MnMybnBFL3NIYjBr?=
 =?utf-8?B?THgvQVhJT3Z3NkorUDQ5Q1pJbEkrbUx2Mk5lZDc0QnlieWFVOVcrRC9Cc3VS?=
 =?utf-8?B?ajdKWk1ZUXdNTGd5TGFPZUV1bHBSUVJvYnljTjE3MjlUQW1MMEgzd3VxNnJy?=
 =?utf-8?B?TE1iWE5EOFJsL3c3SDdRT0pPVnpMQVcvWFc5TEk1SHkySU85aGRZVlFDenZ2?=
 =?utf-8?Q?OuyajxLXr4dCW6rj6F6kTLo=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 482641d2-dc8a-4637-f6c4-08d9c4732a17
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 11:15:15.8161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RFcjKSpfsi6Bi+qPA4Rs0/dQd5fbhi9dKzxEiuMcf44WvtibeYrXBDbld9CY0WNPziVXEkLGgjHON96MXxYvSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4944

On 16.12.2021 10:54, Andrew Cooper wrote:
> Protection Key Supervisor works in a very similar way to Protection Key User,
> except that instead of a PKRU register used by the {RD,WR}PKRU instructions,
> the supervisor protection settings live in MSR_PKRS and is accessed using
> normal {RD,WR}MSR instructions.
> 
> PKS has the same problematic interactions with PV guests as PKU (more infact,
> given the guest kernel's CPL), so we'll only support this for HVM guests for
> now.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 11:23:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 11:23:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250318.431177 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdEy-0008Pb-Fh; Tue, 21 Dec 2021 11:23:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250318.431177; Tue, 21 Dec 2021 11:23:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdEy-0008PU-Ci; Tue, 21 Dec 2021 11:23:32 +0000
Received: by outflank-mailman (input) for mailman id 250318;
 Tue, 21 Dec 2021 11:23:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzdEx-0008PK-6V; Tue, 21 Dec 2021 11:23:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzdEx-0007Ry-15; Tue, 21 Dec 2021 11:23:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzdEw-0003LQ-MW; Tue, 21 Dec 2021 11:23:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzdEw-00060n-M8; Tue, 21 Dec 2021 11:23:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=GNY4/jtq0CwYIpwoMHo2c+GmBMcB9QD5kp2z/DONbmE=; b=EAi8+XEwpLrKP2cC96TX+RiuKY
	Po5sAwYNKw6BCPcJ1I1Bcag7QiHxoXP81zJu9aQJ1ys4RLYbHTmryDi45KmbmakPOdhG/1sdnuIwy
	bQ/6ffbZ7rc+ogu1JLjRWCwNFpwtiqWMqjDA2UCyYScQyA+QM3dhe30BzDsbmu9nAqvY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167497-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167497: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 11:23:30 +0000

flight 167497 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167497/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167485 pass in 167497
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 167485 pass in 167497
 test-armhf-armhf-xl-rtds     18 guest-start/debian.repeat  fail pass in 167485

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167485
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167485
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167485
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167485
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167485
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167485
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167485
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167485
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167485
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167485
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167485
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167485
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167497  2021-12-21 01:53:13 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 11:29:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 11:29:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250328.431189 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdK5-0000hm-9U; Tue, 21 Dec 2021 11:28:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250328.431189; Tue, 21 Dec 2021 11:28:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdK5-0000hf-65; Tue, 21 Dec 2021 11:28:49 +0000
Received: by outflank-mailman (input) for mailman id 250328;
 Tue, 21 Dec 2021 11:28:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzdK4-0000hZ-41
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 11:28:48 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 28989931-6251-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 12:28:45 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2168.outbound.protection.outlook.com [104.47.17.168]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-29-6keOC0OeMUCN6evPefqd6Q-1; Tue, 21 Dec 2021 12:28:44 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.18; Tue, 21 Dec
 2021 11:28:42 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 11:28:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 28989931-6251-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640086125;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sT3TvE82UfBbXPgmY2Lq9j7gaWly0mkiUokPnRGLFPQ=;
	b=EPUmB5xjWJhZlqIvbBStu3HzlqYKFL5HFIqqnRe82eZA4CN/DmLH3OQZFOsOxkTbJs3ona
	N9cDov2gBsPYZZCqSnA43Vo19L2MxUAuu1uQA7WkwRYUIFclt+dQKSu+6pjxCia/EmrLOA
	26GAg8eg7ujhifk9EmKW2aST6bbM5VQ=
X-MC-Unique: 6keOC0OeMUCN6evPefqd6Q-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=H85w3GVF4s2o9ttxIxfB1VH4cl5VWjaezCdMmHcdl1ARqLfTFWbC07FZoFFFvpcXty3NRbWtsn9ZX8qEwyCIGeKXa1xdJNauxQi0HDy+3dSy1Iogu3dnPNg3P2/zjfMpsBpHKxR5NRndIlZWgbBTfnxhgTjYTcuMHOGzRBsCMLJNIh1/nUuNK+j8Db0hS+7lK+IuJvUHCAxs1NVq5EuISsEQutJpS0Y7XVt4VfahYDA/OupHjucZWiFjV9E+5S8isJnGzIuAWGfHkUqnoAh2tl3ikoS4d7Vk0qXTN2gPdbFn3GOwTZxH1G8u3zFqp4XY/hObP3/+eL85QeDSyrSEdA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=sT3TvE82UfBbXPgmY2Lq9j7gaWly0mkiUokPnRGLFPQ=;
 b=hki4VNYJ0u7+cVCzzWOIYuFRblVRTb+qnTgXHWJ3H3vrR49dOPJPAq43L8l5KCeuhnjZWn/8Y3IA9g5zi8+eUfn0hd8T5fRfrSui4rMBQxYb7UnEP1DQhUnJU5dcUwpNwDTLgFmYhHnBsVTm2JOGvumuHNjMlsu3MMdSIeitumegjY0Gq7VwChWsUZfyQkH38iahO7i/cvk9+fvPzb1syPITlgsUDrhKZnU+7GNnfm9zcWcBeP4pvXmIjJd1eaoru7A7u7tdYILtFPOmboxoUW+xzHIrBp6g3X2cPti/Kc8XUwHlqIj4KtuVT2+bkOCcF/1qMG1ZkD/OJs1ezRBH+g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <427dc257-b318-de55-7126-0446264401f8@suse.com>
Date: Tue, 21 Dec 2021 12:28:40 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 2/6] x86/prot-key: Split PKRU infrastructure out of
 asm/processor.h
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-3-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-3-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0060.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::37) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 16f4f3ff-7e9d-42fe-1adb-08d9c4750aaa
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB23357EB5DDD690F86DEDF0FCB37C9@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	LPMhrn3TGb3ghUVo8LGBkNElOiSSCb1IwjKgrsC7NCUYIxuAZYeKyzCS4ivYmK7DxfTWqLgqR16ydGSeJPxqUkbbpv5PI/7b8Iw4zIt+6xzNFVWIBv62IAEgHaVBRrvqrAKgYnOd4HSkFAIz8x5mLv9xwtqYg4GyJ2Bw0QJEhTs+jmjOKk9QgQTVNLQTXP0OcH9z8qGwH8i1m5pO0Z27ckyNkeSGWMoe4PdiKARNwK5XFLdZS+jdK2hj28Rbpkn6a5DAcv9lnV0S7ZcFtYZjQGUDXRW7D0Zb/FFDb++dxwTI+xLKQGadLcLdGKL2xWbZ4xQ/T7+IFddjVCOHwWOSERsJRjBEI4BuElOAzUaGkTvu+8CB0KJEj2rT24y6OobFBSjDPP35iildM2Q/FqMRSO3jkWu7vdK99xlUKXYRiUWURQ435u6X65t9YQ0lmjeUyeAgV6UIAIBMJg3is6lYo2EgzJIG/IzLrlE71+eqHBCLVHpdX4bq1DluPGrHAbmtulFVcyrrU5uBdJmH8mu/EZ2fkFlMw8xFwU9Zev5vUEKNFDqc1YZXc/cq7DNHNxUEqfvqEE7Tzzbq21ZQ3t1eNxwTTyseHRH7e4/2xdv01oWEzhV0azzS29YKjpU0QjI9mO8mROrqjp2Kh2ijLYFYCvhPklxJzBfAKs9RxO9UzqvIPhPPqyF1qPUAnCqzeiCT/B9lBdaTOcrg6wQayD+hJovFVTaFV5HvxNI4Y8Mw/idKqAeETnN4hXeBXVfM64Cr1TghFpcGky0Y1N4XbUf2ynVjpzbHcnrT2nauI5nAopSfONziWnfr7WupkOYsS1zPnFyzPIRuN4zdwnH/s9Kn1g==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(26005)(31696002)(6512007)(4326008)(66946007)(508600001)(2906002)(36756003)(66476007)(38100700002)(66556008)(8676002)(186003)(86362001)(54906003)(6506007)(316002)(5660300002)(6916009)(8936002)(31686004)(2616005)(83380400001)(53546011)(2004002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZTdBbFBKOTk0VXd3U1dtbWhJbmRDdjVQRE04Nklib0NWOWNKNFJ5OTJoUWdC?=
 =?utf-8?B?RWVGVVdVQ0JnZWw4R3dWczlITVFLcnl1Mndhd1gyR3Jwcm43dld6U1hBNW1O?=
 =?utf-8?B?cHFhc0JSVjFDdlRGUzIyZ1U3dkUrUmx6M2VITWhzbzBFd0dVaFlSUjF4RGFj?=
 =?utf-8?B?QnFlVHNyNkJuS2lDZGw3Qlk3bXhzWEhDditMVFVqSEc5T1pzY0laM1pxWHQ3?=
 =?utf-8?B?a0xsTFRsbllNNHJjb3ozaWUzNWR2Q2hWOU1QVFBqU1RibVVic3dzQmRkSkZO?=
 =?utf-8?B?MFRuRC9aTUNhdXMzTUUrU3dnT2h0eEUwWnFBWkRxZEQyR3N1VllMRUp0TGRq?=
 =?utf-8?B?ekNwTnUvc29jdjRGYnJsbmM4TTBPTllmZURJUzFxOHZPR2drbkQ5eDk3eXBB?=
 =?utf-8?B?VklpSUdFTlJUWVNYdHR2ZWZhVU9oZ2RQaXNhM3p4cmRVVE8vcVZSTkUrK21l?=
 =?utf-8?B?cy9MclpmV1Y2WWgwZTJNb2NWVUlCODdtZTUwY1l6Y2dtei8vYmEwQy94Z1lu?=
 =?utf-8?B?S0s0ZFFrY1pSR0diNTNsOXJRTnJDZkpEai92YU9iYmlZSW1EV09TdGlDV2M3?=
 =?utf-8?B?VnZUemVwZUw0aWhOckQ0aUk1WGZyMWlZVnhRdElnTy9rQ3ZMQ25EOVRXL0pI?=
 =?utf-8?B?MTI2dHg5ZWJCUmF4WUJFTjBOQ1FiaENXWEFrY1EwejFwMkdqSnBHbkRNaFJ4?=
 =?utf-8?B?VHRlRGt6bXNVRVRyZGJjSXdSUCttaHU2akZGMVZuZDUwbjJkS0tEZEJmK0lv?=
 =?utf-8?B?VU9zbCtjODBGZVBZNnlFNC96dnVlbldlZWlGR21TRTIvUWRMbkJHcG5CT29m?=
 =?utf-8?B?SnU4U1ExZjRrY1pCeWRuclRicW1QNVIrNUt5b2VUeHFRU0dGclNycjRGajhH?=
 =?utf-8?B?S05zZlhNUjJrZVYyS1dFYWZyaDFidFE1OWFlNzhlMVBxbzdrR2tzTGcyMDZM?=
 =?utf-8?B?TTJGZEtFOWlPT2JvUUtBSXJ3anNYUmVld1oxV1N6bjlQQmh6NVRIZ0NwUTVI?=
 =?utf-8?B?aEdBUnl0dUJRWjc3VlBvY3d3YzJ4K3J3Yk5haTQ5WEhiS3NhdjNIWUZJbFds?=
 =?utf-8?B?RnMrd0ROVXhJckc2bWkvdW1sSzhoakVXVURNUWxzZHQyYzYyekxNRjF1TlhR?=
 =?utf-8?B?aVNGSEIxa3RFTlBvYThZcVVnZWtlUEhNSmxmQkFicW1SaHphTGVKN1VOcWQx?=
 =?utf-8?B?YUtyWXpYa1ZINEFXZGpmUFpDblhHc1gyZCt1TFY4Y29QRy9jZ3M1MG9xVXhy?=
 =?utf-8?B?Y3JVdm5IQUZYU3ZmKzhMay9yYVBndnhLZWFMRGwrZDVKMk5BQVBpOFBJQzZm?=
 =?utf-8?B?KzJoaGJjZDAzNHlTdm5DcDZSQlExMEJoSFgwYm0xRThaeko1cUlEeUxUUTJt?=
 =?utf-8?B?R2hoTTBNdTVJdW5GUExlakNkYnhkMXU4RlJ1YVVMaGlDOVgyTGl2aEhqeWhx?=
 =?utf-8?B?SG03eDM0SG1USVAvTWNoM0hBL1gzNzc4SGtaekNZdFFLWHR5bUxhWm1LREVW?=
 =?utf-8?B?YmRwRUJzWUFvY056TmIyc0NxK0NRUS9oOVdMRHNDYmJUMnBNWFhzN2VWYkF4?=
 =?utf-8?B?dVd6SEpHY2k3NDBOWGhBYnY2Nk9xeW1qVENNRkFPa2xFZzUybnFodnBtbXNo?=
 =?utf-8?B?LzBDZ0JtVXJ6YTJ5aWYwOVFQRUE0VXdVNVY1OGpkbW5ja2dOVkVzTGhqN2pW?=
 =?utf-8?B?VDl0WnFnZWk4c2VmWUFRQkNRemRwSG5WcGErMUI4UUdDV0hTM21UTDczU2lM?=
 =?utf-8?B?L2tsWDZJZmpyVkFNTldCeFp3ZkhFcEZwa3U2ZEM0MmErZWpGWU5UZ2RXZzMv?=
 =?utf-8?B?OWR6WTBzcVdheGM0WVQxSTFXaFFaTjdqSEFSbE5VY2dxTWJiOHdaUmNzSDNu?=
 =?utf-8?B?K1RMSU5ZS05SaUZ4cnkybXBQWWFOVHpDbTRwNDBLdlF4Q2N1dzRSYXBIMDYv?=
 =?utf-8?B?UFN1cE1CcTY2Zmd0cmwyc3d1allzMWFzd0pTc0hHWmZJMThndE1SbzJSeUtv?=
 =?utf-8?B?ZXh3c0xLdndFK1dENmt6ZE1GdkJCSHU5TWxkTlRSRVVVYWtpWnJtVTFBWU9V?=
 =?utf-8?B?b0Y5bWQvS1RtUU1QL21OZ3Q2ODZSYmk0eWUzRittM0Q3dFJYazVsZGdRZ0xX?=
 =?utf-8?B?N3VsQiszQmVENDBJWW5tYnJTekZoejJvNDJ4UC9jbkRFeDdNMjVIT1dwOGRz?=
 =?utf-8?Q?Ya0UvKm68vsNIFealnUCsPE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16f4f3ff-7e9d-42fe-1adb-08d9c4750aaa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 11:28:42.0482
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l3Cx6aj8Fp/lb7bI07gxXVds/i59W+z74vjaXgetzPgiC/kJ63f/5imqmgplguqxvJoNEjFQSONpjkacJ5cbow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 16.12.2021 10:54, Andrew Cooper wrote:
> asm/processor.h is in desperate need of splitting up, and protection key
> functionality in only used in the emulator and pagewalk.  Introduce a new
> asm/prot-key.h and move the relevant content over.
> 
> Rename the PKRU_* constants to drop the user part and to use the architectural
> terminology.
> 
> Drop the read_pkru_{ad,wd}() helpers entirely.  The pkru infix is about to
> become wrong, and the sole user is shorter and easier to follow without the
> helpers.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

This looks functionally correct, so in principle
Reviewed-by: Jan Beulich <jbeulich@suse.com>
But I have two remarks:

> --- /dev/null
> +++ b/xen/arch/x86/include/asm/prot-key.h
> @@ -0,0 +1,45 @@
> +/******************************************************************************
> + * arch/x86/include/asm/spec_ctrl.h
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Copyright (c) 2021 Citrix Systems Ltd.
> + */
> +#ifndef ASM_PROT_KEY_H
> +#define ASM_PROT_KEY_H
> +
> +#include <xen/types.h>
> +
> +#define PKEY_AD 1 /* Access Disable */
> +#define PKEY_WD 2 /* Write Disable */
> +
> +#define PKEY_WIDTH 2 /* Two bits per protection key */
> +
> +static inline uint32_t rdpkru(void)
> +{
> +    uint32_t pkru;

I agree this wants to be uint32_t (i.e. unlike the original function),
but I don't see why the function's return type needs to be, the more
that the sole caller also uses unsigned int for the variable to store
the result in.

> +    asm volatile ( ".byte 0x0f,0x01,0xee"
> +                   : "=a" (pkru) : "c" (0) : "dx" );
> +
> +    return pkru;
> +}
> +
> +static inline void wrpkru(uint32_t pkru)

(To avoid an intermediate local variable, I can agree with using
uint32_t for the parameter type directly here.)

> --- a/xen/arch/x86/mm/guest_walk.c
> +++ b/xen/arch/x86/mm/guest_walk.c
> @@ -26,7 +26,9 @@
>  #include <xen/paging.h>
>  #include <xen/domain_page.h>
>  #include <xen/sched.h>
> +
>  #include <asm/page.h>
> +#include <asm/prot-key.h>
>  #include <asm/guest_pt.h>
>  #include <asm/hvm/emulate.h>
>  
> @@ -413,10 +415,11 @@ guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m,
>           guest_pku_enabled(v) )
>      {
>          unsigned int pkey = guest_l1e_get_pkey(gw->l1e);
> -        unsigned int pkru = rdpkru();
> +        unsigned int pkr = rdpkru();
> +        unsigned int pk_ar = pkr >> (pkey * PKEY_WIDTH);

This is correct only because below you only inspect the low two bits.
Since I don't think masking off the upper bits is really useful here,
I'd like to suggest to not call the variable "pk_ar". Perhaps
something as generic as "temp"?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 11:56:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 11:56:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250335.431200 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdkc-0004F4-HG; Tue, 21 Dec 2021 11:56:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250335.431200; Tue, 21 Dec 2021 11:56:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdkc-0004Ex-Df; Tue, 21 Dec 2021 11:56:14 +0000
Received: by outflank-mailman (input) for mailman id 250335;
 Tue, 21 Dec 2021 11:56:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzdkb-0004Er-C8
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 11:56:13 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id fcc602dd-6254-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 12:56:10 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-30-knHpHEi3PDKgn8goB1v1UQ-1; Tue, 21 Dec 2021 12:56:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.16; Tue, 21 Dec
 2021 11:56:04 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 11:56:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: fcc602dd-6254-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640087769;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DAU087K4O6/2zhCq5N9Gp7cgMGmjK6uPkr6kj28HXm4=;
	b=gRTlmPbJA7WnhedonV17cWBhwmsFszIpP0NYRoM/QlB4RgFMJofv7IOyBpgpAB1JR3NTDM
	RHJ155EpRI20pikfV+fMIYRceOZpwElkhm6P9MC1jCd/5O++pMcOEKCSNta2T4idgl3iP5
	lfMn4iXM7JkNufgwRRrOWt2eITwABSc=
X-MC-Unique: knHpHEi3PDKgn8goB1v1UQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YVBq+iPcbXPMCdFi/BmjytQVN/bwc5tPFYSlcF5RY4CTtdNhMnQXKbVM5OYLVba6HtDBMw625SY5SM+RkmhCqkecCEKr70JLc+YduNgg1nx9Oeon24cSQQsxdwOyX+c4hOSTWfjrCzHdALmo5gEQR0a/7VPr54L6fsvh2KYfWMDorrJTaVGKMz8gvA/2/jCeKMMuWP49DeoXlZTOxjVCxvOeTOYTRd/quiuDy6rN22oALPE0/rPqOunjdyucY/lEzOi0DVNKyC/moyWvUHIpd43qcMzm0F6EMqA6Yz2LvCLgUfAGZsddPHdfrzWJI5YamQk+V9HKBasVLmT9bN/A6Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=QVrWPOYZzDez61n5pHAi+L/pYqXRaC22G6RwqQmbmOc=;
 b=FhiAlNs9E7ZMWeEX4Gtuaws2AClZFWbAtG4o1P674ToEk8LniM+wKUh2w4vkUqgXxtnl+9G03LvZDWRlFVWUP6d57wG7Dsbtddb6m5LUyjVQ6dO/oH1M0wnHO2i2BZ5KEda/jtQobLjDyk//762aWHysYlOMaE0efzMFP0zKxKLK4EdMSb44NzERqK8gD/crYnsihTYkB6J+WijHjQKKlq2WIv7haCGgh5Bnj1UFF6WOVso+k35jaPDs9iRLAlS4pVFelNj6pnQAg5NG7fj4j5Cr4If66zyEvBue92utmQV3hxxPa9dufLHu3Yvr/6Yn0tyeZGVma0zoaQ4fOE2FaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <6efed2d5-e7a0-139a-a2b3-6f0696f711d1@suse.com>
Date: Tue, 21 Dec 2021 12:56:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 3/6] x86/hvm: Context switch MSR_PKRS
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Kevin Tian <kevin.tian@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-4-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-4-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-ClientProxiedBy: AM5PR0301CA0013.eurprd03.prod.outlook.com
 (2603:10a6:206:14::26) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 73683730-2cb2-40b2-3fa3-08d9c478ddac
X-MS-TrafficTypeDiagnostic: VI1PR04MB6301:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB630125A59B5DAE0764B15B75B37C9@VI1PR04MB6301.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	o5wCWT61g/dX5bN0jn1KEG+VKQOJhfewExgZ9sJmuMcpHZRU+X40p3/9xFE6jEp/arwOn9Ro5cvvykFZ/qOtNO4IpDiYHUaXrYWQ9di83bm2xXyrzhTl04tJVmMSagvP8AvAwFsD/d7oOFL9HLVupzyW3qhw+7+0NGUVNVeD/LMAk4TrRLGWsiWNFL+fJgYNqDAEng+vjy+6VpUFn6YCymJCUoWsM9wNvoxegdeNwA0mWNcYP8H/hHC6h9r4DwTzBSKAOkgUBZk/LikYoOeqX3pPkHEPOVYWupX/4QP1Yo9Le1CNMG4/I477LV8kYkR/WLJNw81iuB8hU13N1hioTsTuFAOqSdDlySG0qRZPgvrag6NSnmi9jiQFTI8Y/RC2H73UAXbMNfGRRTlBqKmB1g1r7EAvkut7yvLKwnJ/TWEpNlcnVVxmT6DMzaRg4wT3pTiO4Y6yLTrgOK4cq4OSi1XI+/kEpKOBvmXZ0CWKHH5V1g0OvEQ2n5ecodAb/UgffnRqNiQN28ObeUtfZ7HtQQBW9BD+PwNb9wYWEtVK3mvgEu7NTLxI9FoZb4p11CSWdE5kCmpppBA/mFIwdkR2IEcuQcfLMsu57udA1kRkzFUy5VyOafCMiCjOQa8kCcprVnY/4py3A6G0FRC75CkkHxsnd7IdJOC1KLoSImzYRWT9Rc2YMQyGU5ONPtdZu4vbicDFVL8jUoRSWE1Mbvl4+LDhqier37pKWLrFPVRJZnI=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(5660300002)(6486002)(36756003)(6916009)(2906002)(186003)(26005)(8676002)(8936002)(2616005)(6506007)(53546011)(66946007)(66476007)(31696002)(66556008)(86362001)(31686004)(6512007)(38100700002)(4326008)(54906003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rOl61sHPEu0+195c5iZGklrwtsj4cdk37mbUx8e/9KAcWbQTwvzZcBcvKaQQ?=
 =?us-ascii?Q?j1ukS/f1EhMhJGFwDJ3f2IAkAOzdKiPH3y/YCBzsnCyNzj6vA9dtBB358jWd?=
 =?us-ascii?Q?R2C+fTT7rvndacHT28n94tW/u9k1wNeUJ0K40LoGKIN/6U+njaOiUx5NYMM4?=
 =?us-ascii?Q?U0ImoeiSnMCunTSGD0gJuCjxxbCHEFlIbFJnBnWbONFCYq1qq9eHL25GDlho?=
 =?us-ascii?Q?pCxSk8rh3/J4iAhJ+myoN5vT0BRN1Gs/w653YBGEl5tnP9FWBUr+RtkG0nIz?=
 =?us-ascii?Q?tyWX7SdhbBHTvqCW1q+wBluxNXguPreQxUh8THvl8U1edL7FfHVN5Wci25wS?=
 =?us-ascii?Q?3fEXIIbe55V7ob/o+3uoUmPaUmokyVgdY/Qj51eKUOjQQ3sNx8EA/agSQnZv?=
 =?us-ascii?Q?NH9N1Qzx3IQnW9OQZ/KK7cpsszSIyBL6j9I/lxA+WbBuSj+izC/g2kXmhz8G?=
 =?us-ascii?Q?DNsW/+LnNUhG2WwUpstn8A5p2oiHV5Wj6ErQ2izCv5jZAtamTQypNYOWqE/N?=
 =?us-ascii?Q?I9k4P2RdrLA2oiBphVE3ltxYd4XrzHE+j8bWAc2Xs8OSPyXPNdnnkjpf4te8?=
 =?us-ascii?Q?cC6wgK8ioRSjnh3MZOgxsbK4iKRJGMUjDiOCAuU81Tbyq1lffu4tVGIyjfPL?=
 =?us-ascii?Q?zyuehdL1gTPrZORqwp++Wz/UYeWBoa6LrockwgcFTME+S4O/4RYaovXCj9m9?=
 =?us-ascii?Q?BEroVOzLTwvF4+rsm8LnS5GCba/Qyf0Ej0psl8wj4XVkjqy+JJEV/I478JsP?=
 =?us-ascii?Q?b1+jbiIHlugPsT4ieCkClssYGmGkKnyKLlWKPkGIVOz0U+0xqB+WWigt52Ox?=
 =?us-ascii?Q?++QpM+AR+/XIAJ6jM9PNPEN4JgFneIXZCNYHm4pAcO9Ja4gAHepdo3juC8BC?=
 =?us-ascii?Q?cHQKVzAK9D1eC/k3+0djNmI1EuL+szc22ZeGkwavX6tkD+HLjFvUOdn4Ljdw?=
 =?us-ascii?Q?nsZ0k5qGfE7AD9mHn+SfGkvtwK2len13oycxUUtfdaOFYnJLlIULuEj95t9c?=
 =?us-ascii?Q?ZNxefAtfROsHxCMMwmIHFVOl8LJtikxdJWWeqyVyQioDZ9IrWJImxsn3c5Nl?=
 =?us-ascii?Q?OOpfgx4WYdhabxEuro+Lk3rzGDm2B1Oq/ZKvk5kH1vvYMizmsRhGn9bwgsyL?=
 =?us-ascii?Q?ONHbd8ZLWo9Fk2F2e4JKjY98yv7m0J96vBf1D5+osdezOeR69GQrr4Swq597?=
 =?us-ascii?Q?E4XIGB6QMuY6dJBxxY1P2vImOUgZNQp7OM11D9Bt1LOotPnb7SuE2jiN7ciW?=
 =?us-ascii?Q?Z+hk3SyryKR3CXlGsOYMBkLyoCnsITF5L8vqnn0vttyrYp6W/EizMsnnH/7Q?=
 =?us-ascii?Q?lqX+Rhiot2IVH51ERWQ4H7V+UZGfdY4o/eU8GD5/QnSAchsXPW6KfaFHK1Fl?=
 =?us-ascii?Q?sKhms1jwq1egPvvudVAMvshUu0qw/woldPAjs/gaS10SxZmt/AugZztN4J6q?=
 =?us-ascii?Q?O0aA+NM6m6UlsLpdiZJ3O+Icu2XNeex5lbmgYu0ly1/QJWJt/wp2eVOMLx2m?=
 =?us-ascii?Q?g0sYZN6N+M/LiIIP5A8sIQKtQv7Fjz/qnFy0QqWUl8CT0s9VF6kSJi63xBZG?=
 =?us-ascii?Q?mQlNmGElv0MpYTUZwHcP9DRdRijZhT6wwSxJ4wmo7KHQBDacmwuOGYIrtzbo?=
 =?us-ascii?Q?WsOQo+mm20P/vQxyncQKydc=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73683730-2cb2-40b2-3fa3-08d9c478ddac
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 11:56:04.4828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RX4SMKaPg9pInzxXwygg1MCzFvg18AYIbVHWI83OrSIp6KGW1vlkFX0/hQ89suU0kcBru4Ku4A8j0BvjZj7ezw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301

On 16.12.2021 10:54, Andrew Cooper wrote:
> Under PKS, MSR_PKRS is available and based on the CPUID policy alone, and
> usable independently of CR4.PKS.  See the large comment in prot-key.h for
> details of the context switching arrangement.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monn=C3=A9 <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Kevin Tian <kevin.tian@intel.com>
>=20
> At a guess, we're likely to see PKS on AMD eventually, hence not putting =
the
> DEFINE_PER_CPU() in vmx.c, but I'm at a total loss to find anywhere bette=
r to
> put it than hvm.c.  Suggestions welcome.

That's fine for now imo. hvm.c is another candidate for splitting up,
at which point a better place may surface. (I would even be willing
to make an attempt in that direction, if only I knew the results
wouldn't end up stuck again, just like appears to have happened for
the p2m / physmap etc splitting.)

> @@ -42,4 +45,49 @@ static inline void wrpkru(uint32_t pkru)
>                     :: "a" (pkru), "d" (0), "c" (0) );
>  }
> =20
> +/*
> + * Xen does not use PKS.
> + *
> + * Guest kernel use is expected to be one default key, except for tiny w=
indows
> + * with a double write to switch to a non-default key in a permitted cri=
tical
> + * section.
> + *
> + * As such, we want MSR_PKRS un-intercepted.  Furthermore, as we only ne=
ed it
> + * in Xen for emulation or migration purposes (i.e. possibly never in a
> + * domain's lifetime), we don't want to re-sync the hardware value on ev=
ery
> + * vmexit.
> + *
> + * Therefore, we read and cache the guest value in ctxt_switch_from(), i=
n the
> + * expectation that we can short-circuit the write in ctxt_switch_to().
> + * During regular operations in current context, the guest value is in
> + * hardware and the per-cpu cache is stale.
> + */
> +DECLARE_PER_CPU(uint32_t, pkrs);
> +
> +static inline uint32_t rdpkrs(void)
> +{
> +    uint32_t pkrs, tmp;
> +
> +    rdmsr(MSR_PKRS, pkrs, tmp);
> +
> +    return pkrs;
> +}
> +
> +static inline uint32_t rdpkrs_and_cache(void)
> +{
> +    return this_cpu(pkrs) =3D rdpkrs();
> +}
> +
> +static inline void wrpkrs(uint32_t pkrs)
> +{
> +    uint32_t *this_pkrs =3D &this_cpu(pkrs);
> +
> +    if ( *this_pkrs !=3D pkrs )

For this to work, I think we need to clear PKRS during CPU init; I
admit I didn't peek ahead in the series to check whether you do so
later on in the series. At least the version of the SDM I'm looking
at doesn't even specify reset state of 0 for this MSR. But even if
it did, it would likely be as for PKRU - unchanged after INIT. Yet
INIT is all that CPUs go through when e.g. parking / unparking them.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 11:58:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 11:58:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250339.431211 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdn6-0004rC-Vi; Tue, 21 Dec 2021 11:58:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250339.431211; Tue, 21 Dec 2021 11:58:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdn6-0004r5-RD; Tue, 21 Dec 2021 11:58:48 +0000
Received: by outflank-mailman (input) for mailman id 250339;
 Tue, 21 Dec 2021 11:58:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzdn5-0004qx-Qf
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 11:58:47 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 5a40c05d-6255-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 12:58:46 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-39-JqyD5oJ3NDCHd6uM3arJkw-1; Tue, 21 Dec 2021 12:58:45 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VE1PR04MB7375.eurprd04.prod.outlook.com (2603:10a6:800:1a8::13)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.18; Tue, 21 Dec
 2021 11:58:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 11:58:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5a40c05d-6255-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640087926;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=gZkTUfBEpMtfcW2+wcrYiy0GqhKWAAI5fRJa3HM6GUo=;
	b=YZDJ5dRsnF9ijH05tAyDREwlj9og+y5B1zBtGL9qYtNcnjLxrpadUORmDRCMmfyxK/2goY
	P5Dz7IWTxJUuyHrfetqPGJFQ9m6avw0dCC0A2NwpHzzsX6xCoqa84L1p7gnRGGayYwCaK1
	axzaA7eWTps/4J1CKZaWgh/wDcvSJWI=
X-MC-Unique: JqyD5oJ3NDCHd6uM3arJkw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mq7vXeZEGGKkEro6Oqw5QSaV1sigj8wZwueJeUaci1ksWRddT69qX58z/Wp42wCDqB2UH8k6ddUddAcQRwTVKCA88yKfBwNOYqjtDIVUd83qyVrKVOZgJKE55GS6wgh5W0xQGbdx3xKWIrGdInXSgKUUYemi2gGe6mF7uevzj3JXrAug9Vk3CNLLeRcQjBAvsg8/9a2A5bx/G1bIAGnHDicfym4ECa6Id/e9KsoINpeVkGfTpAlftSsNh0nrPj0En7rDYUq55CcmmUajyxfI/CLADjJZU68TKmlRhOO7fNJz4vTtF3mRyYVj0fL7bwctAJcfxLLl0MOvuZXgZmq+iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=gZkTUfBEpMtfcW2+wcrYiy0GqhKWAAI5fRJa3HM6GUo=;
 b=Dqp4f6TqxBcuCVQcCVI0a2BnXy4pcJCMVaaDQU55EIcjFkqOOpZf/jDKxlKxugcf9UU7ZEEMe3YaYKwOAN828YW+ppnvZsG2f4mdkhptWrEGiCQeGUDNOL4b6XPHNQJTQDK55uiDu8b1dlbP4LSflWuyXZE33XZwn3KUK3wwFC3C/mrZDKMXeqbxBZFDljuTKkRydLPGTPpzTmHy7nTu6CAgsc2ISgBIhToNzWi+uf0K1MjfMDcJWOa8NeQy6BDgG40G/BxTQ+RjH+UnQTldJJvTFhEwTZqIUXydUEyp/qW3zF/OkzH056Yytr/9OWXtTYeXz1udrw0AYlNPpZf13g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a85987df-aeaf-b0cf-232d-1649f5ce418b@suse.com>
Date: Tue, 21 Dec 2021 12:58:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 4/6] x86/hvm: Enable guest access to MSR_PKRS
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Kevin Tian <kevin.tian@intel.com>,
 Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-5-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-5-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR0301CA0001.eurprd03.prod.outlook.com
 (2603:10a6:20b:468::8) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 282714fb-5719-4f4c-e97c-08d9c4793cac
X-MS-TrafficTypeDiagnostic: VE1PR04MB7375:EE_
X-Microsoft-Antispam-PRVS:
	<VE1PR04MB737565E3C771A5FEC6096E98B37C9@VE1PR04MB7375.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3826;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	fXe6srQqVgmfdC0yyFos6WLp2pGQAynEUVXlVSD16T3vJYTlcz0pfCeSIoRyncNQajPm4mRnHe1pbVLxvinrZUZHIGQ6ABg6aGaAXUTBPaRiZ8K3u0xyO/2+rMASbkMu26XQgQAZMOxrjfwW+laP0HPFAjfAo9wDcqff81i9BHqiJO115MUmdua58WriNStbiFCKUh1ziuhtX3agjZg3Aq5UuKXm3weC+kWLD5R8FNISfB30UKiE/+UqyWlwBIT6uyNPskmmhFCT9PNtf3ZsUyvnOS8Qrkj3NYN2wMoBzq4uMtjy0jdNSP07QWbIBUgbLKcTdp0da/oxb4hxVheMnCysC/8W8BVkBNJsq/kj+Iiw3cUms9enI8lJDGsW1XvytjR+BlYWvl+mRZ0OpPxS6B80OYXkf9JY8QrMhV4NVVhQW7mAvZvPjOiSEKEP+BfKBiWTI91pOTGM8fSzlGwpVkMuUjRVQZ9ExterTs6xCjFhtgKci6yQCNz6Dhwf5Gj2TJ/Ty6Hq3/psFrof7BSw16MYiRLOOqLk6i9dzBsx6B8rzx80krU7hiBGkN+Ndr3CfY8TUPzJnQK/6IvatpLxtoxrV+YE8x0fJQqt6v7Ssz4HFUTbHitODhbrWUbk6IHa2uWB0++/0KfNnKPlkxTVH0IAfyVW2KyqFsrcEQ4PnTTlSfYr9FRmAAabJlIAPo/BcbgQk3178EdA4wpkqURbZGuEV5PtthkkudUDuYNfjsM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(6506007)(2616005)(54906003)(4326008)(2906002)(508600001)(4744005)(53546011)(186003)(31696002)(6512007)(316002)(8676002)(86362001)(83380400001)(66556008)(36756003)(6486002)(66946007)(66476007)(38100700002)(8936002)(5660300002)(6916009)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?akQ3UWc3eEs1VXJ5WmlMRnpZTGZncktKbWo4WWc1bWVPa2Z0SnpOUWpNTTA4?=
 =?utf-8?B?MnNlQXhKK2hQU3Q3b3RpWWtzOS9rSTVZVkRSMTJIVmF0M2RNNlBIdFE4YXo4?=
 =?utf-8?B?WitOSFd2dS93L3dWd0VBT2YvaG1UekdpSk56aER5ZXlqdzBLb3FjSGsxU0d3?=
 =?utf-8?B?b0MyYTdDZXNucmllR01YeVdBRDI5L1p3a2J1REJOS2Nycm1KY0tJbS9ZWEJY?=
 =?utf-8?B?NmRjV2RjUjZJSUJCK3dncVV1TFV2bjlKNTlqR0dwWkZSVlQ0eE4zOU9hL3dD?=
 =?utf-8?B?c1o2dUJvakRGelFOUzJ1Z01pWWNHMWR2d3dNZndZMExNVDkrejJqMTYxK0Q3?=
 =?utf-8?B?eUo0Y2xFM25lc0d0dzdJdUxBalorSXBlRHUzNkxza0QzcjZTY2tWZ0dubkNK?=
 =?utf-8?B?QlJaNTNVajVKa1lFb0FkSjRvOHhERUVKbllVUEdRcWkzWS9IWXF5dlNSN3hi?=
 =?utf-8?B?bzF3Mmt5THQrLzN3d1FOMmJLN3BZOGh1eUdBaEFianc2Qm12QnMxVU5Zdm1w?=
 =?utf-8?B?WWdOYXg0ZCtZV0QybUV0M0I5aU9Ib29WZ3poRHhxNEZZTkV2VzdhNk53MkxW?=
 =?utf-8?B?RytwMll0NldmeUpiSklKWHMvaUdzeUFTcmNybGhBV1dNVU1DVTlaS0R4Zzlo?=
 =?utf-8?B?YVFFRjh1SnZNeU9EN2pRSzI5Z2JqQk9GTVQ4NWdUeDFZdm1Xd3JUVFFxTmRy?=
 =?utf-8?B?STJQMkdiMUVyS05hSVd5bWJRb1B6S05LMGI0blBYa1FVK0tqYkVLeVhLOE1x?=
 =?utf-8?B?V3pMTFVFT3N4cnZabm4zYStTYXV5T3BIdklwclRpcElJWGUwMk5zdWgydFRi?=
 =?utf-8?B?akhWV0RLa3pSQVpub1g4cjY3NGFidXoxV2w1WGFONldYRDJESEQrbW1kdW44?=
 =?utf-8?B?RGJORC9TdkR4dXAxSDZDYzdVTHB4ZWIybDZWRXc2VTg0cURRSEdmWXFIRXhM?=
 =?utf-8?B?U053Z1lFeUtZc3l3NXVDem80RjNFckY3UXM0TWtzZnpZQjQ2UEREYWVrdWo0?=
 =?utf-8?B?ZGg4UGhnNHZQMHB3bURLZW8yMEVmOUhFWkkzMVFIYW5MbDM3SlJwUHErY2Jl?=
 =?utf-8?B?Rms0UUdMWEJMekpYdVg3a1dNZkVkeitJV3ozSXg0RmNBRGhSOFM1WGxzclcz?=
 =?utf-8?B?a0VaTjl5YWdmSEFXUnpLVXY3RG8rbXFpb3l3aHZTRFRpWi90ckJPRWR2Y1BH?=
 =?utf-8?B?dzdQMDczenRLcUZyRkxqSVVGYlNYcnZ3RlZ0b1NxOW5pcmdtd0Q1N1k3d3FD?=
 =?utf-8?B?MDFmWmhYcy8rdUQ4aE16eXpDNUx6YlNLYVNyaVJKaGlDd29hSExDQ2Y5cjlm?=
 =?utf-8?B?akJwaEVzelYwK0h5TUxzeGpWc1VCTFRnaW9ITTIxb0I0RXM1SzgzUDF3aDE3?=
 =?utf-8?B?Y05pd2VUQ0h1eHZZZ1p3VWhGNEd4ZElkajB0bXZidnlQdW1UcmM3NnRHems1?=
 =?utf-8?B?S0kwUUJXVVZYdWhXaHM3NjNFdUJ6SGcwKzBTMGNxY3dZS3NjWWtSdzA1cjlD?=
 =?utf-8?B?YXRSQnhrNVhxWVh5cTB3YzBJL0lDZlJteFpFd0pmN0ZjVkRUTW1RcEVyM1Vh?=
 =?utf-8?B?MEpSUDFVNk0rTDE4M2JqbkQwVldlZXh5SlRFa1NyUUtkNTdwbDdRblc2OE16?=
 =?utf-8?B?aURjb2hvS3A3RzY5TTYva1RPa0J3Vm5KaXV1SjhUODZEb1dacHdSY3d5WHVq?=
 =?utf-8?B?UCtLanhvYUhCQ0xTMFNLdXpnMVBFejZzMFZhVDRLcXBaNEtuRlI5bDk5aDVT?=
 =?utf-8?B?blAxeFZQUVQzYXBYc2xFY1lIUWZSZDhscDd6NWdVMmtyb1g2WEFKZXJZUkNl?=
 =?utf-8?B?bU5yaWM2UEx0S0Vzb0lLMDFydlpVMXVCMFdLR3Zmb25iT1JYWVM1UzB5cDgz?=
 =?utf-8?B?Ym92L0lwZnF5VVd3cnZRdHE2cEE2Qm8xOFUyc1hGZmhyVTdDVW5JcjMwUlhG?=
 =?utf-8?B?bWFrU2J2UVR1QWFOdnJybXVieFZxd0JWeGp6VmVmci8ydDViUGV4Wm1vNE8v?=
 =?utf-8?B?aHg1cEp4RDR4VkNUWjVyRzZwOTUySmRjci9STEFwTjMvYTZQSnFhejJDZ01m?=
 =?utf-8?B?WEh3WlJwZGN0VmN5WitoOUVTZ3BGZGJjSytBa09LUjMxTkNBc3N6cHgxNHd4?=
 =?utf-8?B?VDNDcEFPUWVVTTZKR2dVZEEwaWJOMjZVT3VtZGxNaWE3TmdleWR4STN3K1dk?=
 =?utf-8?Q?QS7/4LKPmp73D337Iegy7B8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 282714fb-5719-4f4c-e97c-08d9c4793cac
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 11:58:43.9046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: baqC7oVn3TYZnZby9YQ7ziki6TRpbBjDLZSfQ0Sms7ZcpuN8JUKPudeD/mDd+Zvr0lssGKpzChzpDCX4b1jmRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7375

On 16.12.2021 10:54, Andrew Cooper wrote:
> Have guest_{rd,wr}msr() access either the live register, or stashed state,
> depending on context.  Include MSR_PKRS for migration, and let the guest have
> full access.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 12:01:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 12:01:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250351.431222 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdpx-0006b7-UN; Tue, 21 Dec 2021 12:01:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250351.431222; Tue, 21 Dec 2021 12:01:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdpx-0006az-R1; Tue, 21 Dec 2021 12:01:45 +0000
Received: by outflank-mailman (input) for mailman id 250351;
 Tue, 21 Dec 2021 12:01:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RAAn=RG=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzdpw-0006Z5-Ix
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 12:01:44 +0000
Received: from sender4-of-o55.zoho.com (sender4-of-o55.zoho.com
 [136.143.188.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c20facec-6255-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 13:01:43 +0100 (CET)
Received: from [10.10.1.128] (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1640088096810568.6883649733682;
 Tue, 21 Dec 2021 04:01:36 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c20facec-6255-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1640088099; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=hguY7AcVJz1olFi6Awsbb5TzsIF8hgaEdLjhntGKv1NRhtTnAhaaePtO9qBfUk9CACbme/OY/KGKfYKkB5QBJjF80d4lLmYjEt2xZcZtTv3DTR5rMlo3thX9jbsQm9vrG5MWIjOdqgUOGqMpN5gUI4K2jF5MFZtEGdMc/IvS4qE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1640088099; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; 
	bh=5R9QaYyJhgWtfIVhR6d2ZethYKNjWG6uSGh12D7jGy8=; 
	b=NfGri9rrHaqRZQH1Z3YW1Y6tUVyFlL51sQmj7EPepkTQagOpFxiRcuceidT+k8DNLRXG6DcX/H+F0Sk2fNM8a9hSzLVJc7P+oaVav8i142rs5CJkQ+PYgt4PH/L3STMc6ZARx8vdKulJaf2kcm/nV+zUz4ZsYW7hW2gQIlMOPvc=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640088099;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	bh=5R9QaYyJhgWtfIVhR6d2ZethYKNjWG6uSGh12D7jGy8=;
	b=ayM3nu1yof76aI+HxZrXEgsFzi0HjbcIVSYIlJz/XCxOGzluP7YxSWM6Y3W722+W
	kx4LR7xNW20eFunEPi3zGJEUXBUjemNw6DLy4MOCZKsKnNBUit32HRBd8MYfZKdzvrg
	2e8Hz8qOrm1LR4slO80e3FhQWoyIi/6rtwGuIiYU=
Subject: Re: [PATCH v3] is_system_domain: replace open-coded instances
To: Jan Beulich <jbeulich@suse.com>
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
 Dario Faggioli <dfaggioli@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Julien Grall <julien@xen.org>,
 Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xenproject.org,
 Wei Liu <wl@xen.org>
References: <20211220162853.10603-1-dpsmith@apertussolutions.com>
 <cb60f20a-a75f-3b81-e528-7643d47996aa@suse.com>
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Message-ID: <4ff2eeb9-dca7-dd06-66be-faacc7cdde6c@apertussolutions.com>
Date: Tue, 21 Dec 2021 07:01:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <cb60f20a-a75f-3b81-e528-7643d47996aa@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ZohoMailClient: External

On 12/21/21 4:20 AM, Jan Beulich wrote:
> On 20.12.2021 17:28, Daniel P. Smith wrote:
>> From: Christopher Clark <christopher.w.clark@gmail.com>
>>
>> This is a split out of the hyperlaunch dom0 series.
>>
>> There were several instances of open-coded domid range checking. This commit
>> replaces those with the is_system_domain or is_system_domid inline function.
>>
>> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
>> Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
>> Acked-by: Dario Faggioli <dfaggioli@suse.com>
> 
> While I'm not outright opposed, I'd still like to raise the question whether
> we really want to intermix "is system domain" and "is in-range domain ID"
> predicates. Personally I'd prefer the latter to remain open-coded range
> checks.
> 
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
>>   #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
>>   #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
>>   
>> +static inline bool is_system_domid(domid_t id)
>> +{
>> +    return (id >= DOMID_FIRST_RESERVED);
> 
> Nit: Generally we omit parentheses in cases like this, ...

ack

>> +}
>> +
>>   static inline bool is_system_domain(const struct domain *d)
>>   {
>> -    return d->domain_id >= DOMID_FIRST_RESERVED;
> 
> ... just like was the case here.
> 
> Jan
> 


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 12:02:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 12:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250357.431233 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdqN-00076v-6m; Tue, 21 Dec 2021 12:02:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250357.431233; Tue, 21 Dec 2021 12:02:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdqN-00076k-36; Tue, 21 Dec 2021 12:02:11 +0000
Received: by outflank-mailman (input) for mailman id 250357;
 Tue, 21 Dec 2021 12:02:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=RAAn=RG=apertussolutions.com=dpsmith@srs-se1.protection.inumbo.net>)
 id 1mzdqL-0006Z5-Ns
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 12:02:09 +0000
Received: from sender3-of-o52.zoho.com (sender3-of-o52.zoho.com
 [136.143.184.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d19ab600-6255-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 13:02:08 +0100 (CET)
Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net
 [72.81.132.2]) by mx.zohomail.com
 with SMTPS id 1640088122395554.9994111950763;
 Tue, 21 Dec 2021 04:02:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d19ab600-6255-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; t=1640088125; cv=none; 
	d=zohomail.com; s=zohoarc; 
	b=bVQHV84+eEbxqyAIAi5E57ct7F3UVov5ISNnKujLkWO/EqTZg/6uPhYFvyYIiirH6thLIPmT1JFTc/g0SisjnR59u8Rh7LIykYGTMEJLa36TwBdyRK5AFZFJMlSwtFYkKQnypc/+u5ZDoisisXJEovKXybGSgIMJQ0vZXhOeA+8=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; 
	t=1640088125; h=Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; 
	bh=fi3gGm7Y+029vmS8qO8YIbyW9eyKb6e7iEZI773KNyA=; 
	b=dbvGVXsXEZkA25Nom95g+WqnbZ4VT4KFZpNc+o92W+sVJJu7m8kz4ZbkIuckqi+QA+BDxba74EGcFe/qVNGZACwjQ/XigrgV4g71Omk+b5/yUHFGII8XWx1Jjc9wFzNk/zigT9qhno0QunmF3xK//pXsgMbGMuooZlRfGmpeFD8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
	dkim=pass  header.i=apertussolutions.com;
	spf=pass  smtp.mailfrom=dpsmith@apertussolutions.com;
	dmarc=pass header.from=<dpsmith@apertussolutions.com>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1640088125;
	s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com;
	h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Transfer-Encoding;
	bh=fi3gGm7Y+029vmS8qO8YIbyW9eyKb6e7iEZI773KNyA=;
	b=FBMIhF0lb+76Zt5HHkT6nBKo66GD6g7uXCxOed6Uv117XxNpNNboY88i1wVHVGsM
	Qn2nslNm80dFmgyXq1+axZ9NZEDfuuiSDP2DZUV4NMaeWMpoQlb0AQvkrtb+8Y80ZCi
	dXpM1I17xEwNeQY9RlUR4YuChmwIO3EpeKOvZ3lw=
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Cc: Christopher Clark <christopher.w.clark@gmail.com>,
	"Daniel P . Smith" <dpsmith@apertussolutions.com>,
	Dario Faggioli <dfaggioli@suse.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	=?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= <roger.pau@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH v4] is_system_domain: replace open-coded instances
Date: Tue, 21 Dec 2021 11:04:44 -0500
Message-Id: <20211221160444.30890-1-dpsmith@apertussolutions.com>
X-Mailer: git-send-email 2.20.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-ZohoMailClient: External

From: Christopher Clark <christopher.w.clark@gmail.com>

This is a split out of the hyperlaunch dom0 series.

There were several instances of open-coded domid range checking. This commit
replaces those with the is_system_domain or is_system_domid inline function.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Acked-by: Dario Faggioli <dfaggioli@suse.com>
---
 xen/arch/x86/cpu/mcheck/mce.c | 2 +-
 xen/arch/x86/cpu/vpmu.c       | 2 +-
 xen/common/domain.c           | 2 +-
 xen/common/domctl.c           | 4 ++--
 xen/common/sched/core.c       | 4 ++--
 xen/include/xen/sched.h       | 7 ++++++-
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 7f433343bc..5c1df39075 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -1518,7 +1518,7 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
             d = rcu_lock_domain_by_any_id(mc_msrinject->mcinj_domid);
             if ( d == NULL )
             {
-                if ( mc_msrinject->mcinj_domid >= DOMID_FIRST_RESERVED )
+                if ( is_system_domid(mc_msrinject->mcinj_domid) )
                     return x86_mcerr("do_mca inject: incompatible flag "
                                      "MC_MSRINJ_F_GPADDR with domain %d",
                                      -EINVAL, domid);
diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 8ec4547bed..c6bfa5a00e 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -188,7 +188,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs)
      * in XENPMU_MODE_ALL, for everyone.
      */
     if ( (vpmu_mode & XENPMU_MODE_ALL) ||
-         (sampled->domain->domain_id >= DOMID_FIRST_RESERVED) )
+         is_system_domain(sampled->domain) )
     {
         sampling = choose_hwdom_vcpu();
         if ( !sampling )
diff --git a/xen/common/domain.c b/xen/common/domain.c
index 093bb4403f..347cc073aa 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -583,7 +583,7 @@ struct domain *domain_create(domid_t domid,
     /* Sort out our idea of is_hardware_domain(). */
     if ( domid == 0 || domid == hardware_domid )
     {
-        if ( hardware_domid < 0 || hardware_domid >= DOMID_FIRST_RESERVED )
+        if ( hardware_domid < 0 || is_system_domid(hardware_domid) )
             panic("The value of hardware_dom must be a valid domain ID\n");
 
         old_hwdom = hardware_domain;
diff --git a/xen/common/domctl.c b/xen/common/domctl.c
index 879a2adcbe..a3ad1f62b6 100644
--- a/xen/common/domctl.c
+++ b/xen/common/domctl.c
@@ -52,7 +52,7 @@ static inline int is_free_domid(domid_t dom)
 {
     struct domain *d;
 
-    if ( dom >= DOMID_FIRST_RESERVED )
+    if ( is_system_domid(dom) )
         return 0;
 
     if ( (d = rcu_lock_domain_by_id(dom)) == NULL )
@@ -536,7 +536,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
         if ( !d )
         {
             ret = -EINVAL;
-            if ( op->domain >= DOMID_FIRST_RESERVED )
+            if ( is_system_domid(op->domain) )
                 break;
 
             rcu_read_lock(&domlist_read_lock);
diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
index 8f4b1ca10d..6ea8bcf62f 100644
--- a/xen/common/sched/core.c
+++ b/xen/common/sched/core.c
@@ -821,7 +821,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
     int ret;
 
     ASSERT(d->cpupool == NULL);
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( (ret = cpupool_add_domain(d, poolid)) )
         return ret;
@@ -845,7 +845,7 @@ int sched_init_domain(struct domain *d, unsigned int poolid)
 
 void sched_destroy_domain(struct domain *d)
 {
-    ASSERT(d->domain_id < DOMID_FIRST_RESERVED);
+    ASSERT(!is_system_domain(d));
 
     if ( d->cpupool )
     {
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index 28146ee404..cd575d01cf 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -613,9 +613,14 @@ extern struct vcpu *idle_vcpu[NR_CPUS];
 #define is_idle_domain(d) ((d)->domain_id == DOMID_IDLE)
 #define is_idle_vcpu(v)   (is_idle_domain((v)->domain))
 
+static inline bool is_system_domid(domid_t id)
+{
+    return id >= DOMID_FIRST_RESERVED;
+}
+
 static inline bool is_system_domain(const struct domain *d)
 {
-    return d->domain_id >= DOMID_FIRST_RESERVED;
+    return is_system_domid(d->domain_id);
 }
 
 #define DOMAIN_DESTROYED (1u << 31) /* assumes atomic_t is >= 32 bits */
-- 
2.20.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 12:07:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 12:07:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250374.431244 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdvK-000821-Rf; Tue, 21 Dec 2021 12:07:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250374.431244; Tue, 21 Dec 2021 12:07:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzdvK-00081s-OU; Tue, 21 Dec 2021 12:07:18 +0000
Received: by outflank-mailman (input) for mailman id 250374;
 Tue, 21 Dec 2021 12:07:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzdvJ-00081m-DR
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 12:07:17 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 89ef0107-6256-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 13:07:16 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-13-6YgIRr7fPmWGGrGG3GPwWQ-1; Tue, 21 Dec 2021 13:07:14 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 12:07:12 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 12:07:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 89ef0107-6256-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640088436;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mfZxYsWRRdlYuHi+05rZkRMBmpXtwZWL4iHppnN0jwk=;
	b=cKysdO14tZq9OaIc4clhbx5j3zG3l2LTl5QzTmFbbXmq1qyYg2eElfkVlTjfmrNCJSX5Nq
	8KyigkEzpwHYwxTgXQE/WXw/oMkLXdgJXU6jPTVDm/YWHJF77iA+Oo3oX7FOXVFfLZbVuQ
	hPTByfRP2fYy1DTvvfhf11uYHzx8I3w=
X-MC-Unique: 6YgIRr7fPmWGGrGG3GPwWQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Y/OPWsT2x0b5Pe/iram4YChU0HWxlVSXL/GjtS8gdY9QRbIR6Fze6DX0QDQ1i2ApKPF+4qsjQCUhzcsVesxMSZJxkBIyFGW1h2x4JjMFisEcHC9pRQlF+ivUCfd/dg0HizfnusbSOH99kwPeYH26xrgsq2UEVp7dvo6es+s+MDCHJCon27qxTxfMCV26MmBy/ais7pU5mT/+iq6ZwP2n6RpTk+Am51yBSru51zWpoZbtX0dYiTJkEcj+OUYF9ggQn9TtJKYnwB8HRVP06OC5zGcN3RiowxyhR4Y4WV93b2Uzz6b6FsCk3g4/maGsakfhqVlcUWSApK4ZVyZrxvDE4g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=mfZxYsWRRdlYuHi+05rZkRMBmpXtwZWL4iHppnN0jwk=;
 b=hPsxeetZjIEqxZwucspTEAZWlhmY+dDzHh+JjbFEaRnzA3Di3ZBrvNGTxWEnFGjVG3ZGFkvBCNwjxvHl/gbbWYvRPVTXQHSecrVcaz+LYd5Laypw8YgKUWRhpehkb4dCBzMjtZWndQyhkENo8PcFDFrjJSrIrKeEqRQSixhqGRsnOjESopyAfMPD8wpl4YML/VpMwqMStlCjkjiRo/GHvdfsrbIo2gW0mkuUh8s208s7aZ9tC+DjZF2q0deDTeJixd1R9rWGgI3hhOJi17yR05VmBajcsjWWWF266pncG86tYb6T19m+6RCQDtIDtw6DVEgfUGdREpNMEOx36iVHMQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <61a75382-eaf1-0e3d-fdcb-c9fa570cc735@suse.com>
Date: Tue, 21 Dec 2021 13:07:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 5/6] x86/pagewalk: Support PKS
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-6-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-6-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0301CA0016.eurprd03.prod.outlook.com
 (2603:10a6:206:14::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 855c3618-57aa-40c4-58e3-08d9c47a6bc1
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB24454A5505D382B5C4FD4A26B37C9@VI1PR0401MB2445.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4303;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	98+W0hr4Jc6GsWg093T6JT2NHVU9w1OFsoGfVenfcsa+UIX+4FFlXKSsKJTJxFhMyP2P53hIR8xbIOxkgRFRY4wdnA5NQ2HDZ1DI4q/VptJbyJy7IOWZh1DrjruoOkMMSCeSrBH2JmKN+Aiw6jLGgRfJP1rb7TmIxuowA37YJG502HOkXY9x9lTIjyrTd8q6a8dbyj7Q7PrAN+qKzIAgFlFmKKw8/hOPmMcWy4qIN+yi5fC+WZbGxQGtSONzPpg+UiC3MmL/wkhx+YFv5S8NDnSFC8I36We4v4msA8b1Wa5qXYPQ2oOvyoSOCcnh4MecsX+Af3dsCEUkQKgUyKlUWXyV+M7mHWl/Rdmuv+betyt2uBrnitYbtiIr2zq+v/uqAo7sF4ycp/5oa6+sVtTJTQIg1z4POX0KcJhbnu1bAsFay+rBbSikmdUlNWQ6o7zhvhnJied51/MrAUkV/26qpBzAL67sU2gw1SAYeepzML2/Wxqw4nSxGRFOAwtFt6Qc8YxIojmD7xyBh61V4EvM10/oOOAXme/pwr7jP4OySiIietWC10MrtlZjWviTTm41VqY3cwDJWhOkaaa23kLIjPwo8eDMb78p+GfI1RzgKYJD/qeDhZq4b/zs8IdnaYQkcXbkGJDt5vjr5d6uQ8wAIiOAwls/ou5XaeLmBoEAAfZDtrq7seEfl6SUyzQCSGu0XSfQXFLqNzU/Q+qu9hy95a28S8JkA1aNHh0/f9MY8YaAES7onbKzm2byZxn87klw
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(54906003)(2906002)(558084003)(4326008)(186003)(53546011)(8676002)(8936002)(6506007)(316002)(26005)(31696002)(31686004)(5660300002)(86362001)(36756003)(38100700002)(508600001)(6512007)(66476007)(6486002)(66946007)(66556008)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NGFDVVZzZHJ3cThUdFVQVU5BYnZqcGJZUWxzRzh0TExrOHV5N3dUTUFWcUht?=
 =?utf-8?B?TjlXNEN5MUxYVXlwcWlGSFNjOHRDMVhCYVhKQmg3VmVKNS9xNkcydzFJZmow?=
 =?utf-8?B?S2NseHlmK204VStjZ0MxN2dUQXp2WFluVVBRWVpKVjdGTndyUFdxUlRBbWlE?=
 =?utf-8?B?SlFoNSs0cStGMGRTTmUzelVYY0dnbDdoV1JKazFyZ2lhWU02QTRNSU5qcTVO?=
 =?utf-8?B?UVlKK1BIdnhZTVVGQjVvcWZpTVN6ZEp5Q01KZEpuYUhNSWtqM2podVJSN0Jh?=
 =?utf-8?B?MkVEWVRJS1l3RHVOQW1pbEtIb1hZMVNEYXNEOHpwZFB4NHJNZGdxVFpkZDlS?=
 =?utf-8?B?NWZBcWVNR2t2cWdkam5mVEd2YlBJc2dNUmFGdWxET2EyRzVLL2U3WTZBT1Fm?=
 =?utf-8?B?YzFXWGNsNW5EZG1QeGJyd01YVURmQ3VCdktMeFNkU3hLWGxCWmpqNFQ1bkdS?=
 =?utf-8?B?dWMrQzRScm5pd1Q2eW5YSnFBWTBMZm9KbmNPejc0OGpwSUMxK05zb2FvQnNH?=
 =?utf-8?B?YkRZTmplNStYY0c0Zy9mS012YnBPakZVdGZaUlJXR2x5bFJsS2hNcEpCMUMr?=
 =?utf-8?B?OVdtQXAxc1AzcUFDa3JpT3JvaldTQnY3eVZxZGpFQTlvQVhEV3daaWZhcjVt?=
 =?utf-8?B?RXEvQnQrc0pOejAxSllSVHh0SHdQWUU0dWg5WWtTemp6Nmh4QW85WU8vYlZJ?=
 =?utf-8?B?YU1wOURJS1RCd1BOcGJQTHovRHVmN2lYMTZKdHhpbWI3WnpweHFuRFZPN2Rl?=
 =?utf-8?B?R0doalA4LzJGUGswTjI4Qm03ZlRwUnZ5M2ZUNjB0OTNtbDFSR1luZ1VZNTBa?=
 =?utf-8?B?VWljSURIUmlBMzQrNTdGQk5XYlVuMDR2dUp1cWtZbDg1Q0c3ZHgvekVMVDUw?=
 =?utf-8?B?b1F0eXFFZGdIWVZJdGduU29nVFBob1orRnNTR2RlSGVNeHE3cjg0TUNaaXpn?=
 =?utf-8?B?TVZvWFFBL1BwSWpiNVhzaUhCSHlidEZSUXNjK0lWZm9wSi9LMnIrVlNCd3RP?=
 =?utf-8?B?Qm5ZS0I0SnNpV2dPaVB4S2V6TytvcGdWcGVYYkNvM21Lbk9sM3pMOTBjbm5I?=
 =?utf-8?B?Z21iUWlpcUVpZzZWUWVTSTlTakNoakFXcFhDNFl4Y1VTOWc1RUpSeWtQMzR5?=
 =?utf-8?B?SXQzR3YrU3JZV1J1ZGczdm1NdlBUS29pRzhQSThPV044elJ5MjAzRmYrdzBZ?=
 =?utf-8?B?VHB2bktHcG9CdTBtR3dHV2h3NWVScDdrb1Zld2R4Z2dqRktadE9BUUhBSDRL?=
 =?utf-8?B?V2p4UEdjemZTV0tXVHRuVFg5c2JuM3ZwL0JGOVNtMVNHenFrT3h3bTdnQzgy?=
 =?utf-8?B?emJ4YTdyZE5ONVpING1rMFI2SlhvKzZ2dXkvMzlDRzMvTEFIck45Y09MTUkw?=
 =?utf-8?B?c1VBelllbTdJWkZmNEZWN3FWT1I1eTR2dkZCdjN6QXZ4djdDTGtFTDFnWVA3?=
 =?utf-8?B?Mzk2WmtmN2RLeHBQKzhzdXljVDdCaVVxWndlREMrT2tmL3gwYXdFRjErNXBl?=
 =?utf-8?B?NVJhcURtTWFNaHY2Zzk5MWdlMnJPbjJnVU1OSEhnMUVpVEZiQjJLY01adTE0?=
 =?utf-8?B?SGlxcE5kdVhzUUN3azgzZ21EREZJc1pGb05lS3ByQkxVZW9HVml3NE1Sdmgw?=
 =?utf-8?B?KzMwdVZQRkJGZjkyOThmOXlPS2RUSkNWZVcrQ3R6VHJaa1BBaWZXbi9saG93?=
 =?utf-8?B?RXFrSm5za1A2QTN1OVZWOHpxV2hiS3FHT0JHakM5OE1tc0l1WU9LNmJ5aUc0?=
 =?utf-8?B?cVlmK1MzcjV4VVdpb1I1YlRJUTVKb1JqT1BCZm1KcUVZZEtoMFI2WWZ5Z1pT?=
 =?utf-8?B?STRuanpzRG1RQWNpaDhnMFZqajJGMlhiWkhaSnZMMUJOVU1KNjZnaUJBMzJv?=
 =?utf-8?B?c3R2OVZtWU02TUtrMHBWaW1XVzMxVjNMbGtDbjZyeUpkTFltRVlOQnM4YlZS?=
 =?utf-8?B?T00yZ0dWVExyeVRCeHRyYU5KVFR6ZnFxRm9JeE5qN1NZWkFhaDZOSVlFOGhn?=
 =?utf-8?B?QWVUcm9lRGFha3FhYWkrVHlUa3RSZXo3NVZhRGV0RnRFQStSU2g0cWtKRzNL?=
 =?utf-8?B?RkM0cnRSYXhkMGpyQjBJSlJzV3oyNm1sdUd5c29QQ2xUdGpMeGhzcThuSmpW?=
 =?utf-8?B?Qkl0QnNMRkRvVVFBMU1Ub2k2amUyZmVXalhDZ29KNzBXTEVYeVVSTGJoektq?=
 =?utf-8?Q?OVkfEnYglmhe6Hdwz3breBQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 855c3618-57aa-40c4-58e3-08d9c47a6bc1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 12:07:12.4252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPooapoWt19IEJlphpyWzHj37Ka3otPNiAjVVl8q0o/q7oTe8HABCU9ZvX5AhgchC+qsN3wUd94hRNVvJsIkfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445

On 16.12.2021 10:54, Andrew Cooper wrote:
> PKS is incredibly similar to the existing PKU behaviour, operating on
> pagewalks for any supervisor mapping.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 12:19:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 12:19:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250378.431255 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mze6V-0001DL-Th; Tue, 21 Dec 2021 12:18:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250378.431255; Tue, 21 Dec 2021 12:18:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mze6V-0001DE-Qo; Tue, 21 Dec 2021 12:18:51 +0000
Received: by outflank-mailman (input) for mailman id 250378;
 Tue, 21 Dec 2021 12:18:51 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mze6U-0001D6-VA
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 12:18:50 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 27161eee-6258-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 13:18:49 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-K-qtQKeaOnebVwRqn9kg_A-2; Tue, 21 Dec 2021 13:18:48 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB7037.eurprd04.prod.outlook.com (2603:10a6:800:125::7)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 12:18:46 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 12:18:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 27161eee-6258-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640089129;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tdBbRZZQfXXmFEzaqnGHC1rJTLtD1hXilMc6SU9ezdE=;
	b=PCxOgACzpaHlztTP6AdE3E0WaALa/b9LGYncY+K6Hm4EUyv+pVRnN4x9i1QZI+fdT4g947
	U+0nP+DT1p3uE02Vqi/8BlhQrngS9+Tp7ezae/h5t6dXBYGmV+nVjiT3YHo79kJUv+mFtD
	BqEXEMIjJShwVsr4dHIbQZRVoQp4KcQ=
X-MC-Unique: K-qtQKeaOnebVwRqn9kg_A-2
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RUQWKBKA2xDHCa1+cfW+jqXi+15VWK0p/wtoyTWre2JYxN1ctX0Xv2cx/PWP76UCcJoOnQo01YRvPsFSq1oKmcHl0uTYnvxLOcGUl8D3O6OIfRF9RJm4WboR+f09kxxf1V8YtIGXwbUNZYNVyGwoj8HcyA/YYt5IRyDb05iNRK4/Lv1VinIjkfSoCjbAuRj1CqZ1pivfsPWuowT7RfzRun1meHXcnfi7gLYnQEgWxL7ViquElEJYOJjv2it6pfUvI2VKgquS/0HkQSQu0NuMCvb57o8BO3K+d0TT6FXJOlJXXs4yYRbUAhXM3qY2aVVnTXdb1OKYdYyZdgLnoNeVHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tdBbRZZQfXXmFEzaqnGHC1rJTLtD1hXilMc6SU9ezdE=;
 b=G1lqT/TWWYS2fO24EYM+j0kCgzwzAny5ZvtYh8kztaXxvRI5yKbUR/QahYgIyWSW3qjP6ggVbXS6qhzez7fUCnUsAATzCY2/3tardAndWV0YRZb07s2v9vcizalASVkGT2JVaOe+CFneD1Is9Hvda6nzpgHreqwuMhbcdQGs4RF/dao4VYi/ahsnBAH1Jm85VLymZ0No0QdHwcJsb0zQF4h5JWiHLS4shxEkASuGtsQWELlU3YFEE0hYyNr+UxfxW8tVSdqghpDUTRC91Lv2l8ibx12PgUcdA/TdRRq0CGL18/SfYhdixFo7E+DdkMXG+wsPoNRZqX6QshOhBUW6eQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <e8d01f45-fc80-0908-99c5-454991a9209e@suse.com>
Date: Tue, 21 Dec 2021 13:18:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH 6/6] x86/hvm: Support PKS
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Wei Liu <wl@xen.org>, Xen-devel <xen-devel@lists.xenproject.org>
References: <20211216095421.12871-1-andrew.cooper3@citrix.com>
 <20211216095421.12871-7-andrew.cooper3@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211216095421.12871-7-andrew.cooper3@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0393.eurprd06.prod.outlook.com
 (2603:10a6:20b:461::34) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 49feeda7-4156-4415-7e3a-08d9c47c095a
X-MS-TrafficTypeDiagnostic: VI1PR04MB7037:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB70370D527430435562DE08F6B37C9@VI1PR04MB7037.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	7Z27vyTOcdjsrcbnqY6upP1ym/VvB2RJu5oHqwDTDWXURjTykM8uoMY4DlTR9l51gXVME+ouX44CRSa25s8CHHYurxnL2k5pqPBAY3P7xbw6Re/p36E+6jUG+nuFO1Oe7vXR6DDhGvL929i2KR4m5hycEtk3pOcLnd8lQYNJLynrJ3j+qICwlc8T86DiduDQkx6fFFYHUrowjq8OK57E8KQ6D+T1v53YxeEq8eRPAFkVFuZaaGrVLvkXUu8mvYragwgVEsd/KzxkUhduUJwXdFWWUwuxwzCqcS03C+aHZ6R1KdGNLlJj5UWI6a1rvtpPAnbceIGssOl3QmpE8n+EZlko42+hW69jntIGU2Hr6ZlHJKJF5z/Umb+cXXWVutJXIgDtdX0JM/BGHLni4Wx9wguzKUgH8fFRi7zz7qVfdwlmoadptZTlSo5MqYqAekUzAlLSqo9t74NtWK4A//TdxvNNj+qLogQ4EywheFJmTq77A6/cYmBLmWfK+dQaeilH/tAs+W7v7pAIYMJ2SDCcIn8t4CuksEtIWtR+rGRnLQSUbXH1aA/dkzsYDVaWiUgLJ/xhvNhXcCjQEuALWHyJbobTh1a5sfOl79igrGy5v42WxLq+wVHK66HumTVUqqYIjsI3cuT/qacvCOTQvzUbW/ZDjwI+KFPYxAWsZbwntvw8LHX47owS7xAJpeY14c1uVXvC6LAiDjMGIP9d17QGiT+s3J1wdSCLqOqTZgZ90z8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(66946007)(86362001)(8676002)(38100700002)(4326008)(186003)(66476007)(2616005)(6486002)(26005)(6512007)(53546011)(54906003)(6916009)(36756003)(31696002)(6506007)(508600001)(8936002)(31686004)(2906002)(316002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VEszbmo1eCsyeThjNkFmcnUybDNrc00rejJIb01jNTB5OXYxSXdscDJvNHhY?=
 =?utf-8?B?YXdWczBxZE1IY1QwbXhsTnVKVzFKTVpMSzJXT3kwYnk2T1hwYjkxam1sM2xy?=
 =?utf-8?B?SzFOaFJBVFg1RHpFTFAvV0JEMWRwUGtDMENNZS9sZERyZ0dHaktPRCt0SUJa?=
 =?utf-8?B?VW03SmRzNWViUDN6eVVnS1c2OWRlc29ibFY0UVFyWDdEU0ZNcU1Gd0NDd1VY?=
 =?utf-8?B?bkphSExHdkJkeHQwaWZTVmtUQjE3Yi95MFBvQlR5Z2FOSHlRMEFnWkZ3bHpo?=
 =?utf-8?B?RUpMMklTdGl2a1B5UVkzYjMxMDl6clBPN1h5Y0xQVUNjajhVWTNMVi80OW9q?=
 =?utf-8?B?c1RiWXhCNXFyNFAzR2xkWEFHOHRSYkUrMEJRRldQTGRqZHBiSTRvckFvc3VL?=
 =?utf-8?B?d0V6MHpIZlBoS2JjdjFNQWtvbU1Gemd0THdVQ1FocERPOWR2ekVnTzFHUXVS?=
 =?utf-8?B?bGZQODgvTlFWWjRJOXpETzc2UlYxVC9zNnM4dzRGZlNLZVl5Ymt5QWNZQStQ?=
 =?utf-8?B?dGVlTm1ZSHRRWjdRdHlqbmJsK0dwemI1WmhzakVCeElmR0U1YVM3NzY2bjdx?=
 =?utf-8?B?U1ZhVnoveDBTSDczT2dhdEF0dWE0bG1ka3lQTmZxbFpoVlQvUVExZWQ3OVdU?=
 =?utf-8?B?NW0zWDNIdUFuc2RndFBSc0wvNjVJejdtL3lsNlp0YlY2OEE4R3ZzR0NoLzNj?=
 =?utf-8?B?bE5Yb1pqWlNnT3NWUnhBM1UrS0FIeW9VbHQxYWhJaFhTazBnV2lLK25VZEFu?=
 =?utf-8?B?TENxYlFtcnR1a0pZK28xTVE0VmJVQmllNzJneHNZV0FFbHNFRGFnazY0c083?=
 =?utf-8?B?eVEzM3RkQWdjaDgrc1RqU2cwNmV5emtsL01NRlh6c1BGbDcrc2FYVkFnUW5h?=
 =?utf-8?B?bEVsaFVRYzRuazFFbG1sT2t0cENtY3VKNnFSSU15Z3A0ZXp1OWQ3cGlBUGo2?=
 =?utf-8?B?bnRvMVpaU1VCNHZocTNTVk56Y1MwL2NNSU5GMlAzcmtWNjNVenc2RlRiSWl3?=
 =?utf-8?B?M096YlBWbjAzT3JLTzhVTWRVMFJTaWFpLy9HQ0MxWURxcHZ3N0lEZW4xdk5N?=
 =?utf-8?B?S29WQjFwOUlqbzFqcUl5bXZJbllkWGRFUDcrQ1BUNmFEQVZqQ2tERVRHOWN3?=
 =?utf-8?B?NzlFVkFiSmtoaHBTdkdEdWM0OWY5eHZ2S01Xb2ljYkVQRkgxSFVhVjUvMFdr?=
 =?utf-8?B?d1NLMTFLTEo3Tm9EVEVhNklCNDh3NXExZE9XYzR5L1ZOUWFqcDRrWVp4alo5?=
 =?utf-8?B?Z05XbTFxTk1mV2t5VGI1MFo4cHJWdmdoMFRwNFRVdXh2b0JoaTdXK2ZQNlQ1?=
 =?utf-8?B?SSs3OGkzS042MjVST2dSYWNDRjBBblNva0swRjZmOTBnN09oSTZOaitVb3Jn?=
 =?utf-8?B?d2labDgvcHRxeWw2bVVHQ3FsN0hDZ0dDTFZNclZwenRmMVZKSjdiYytpdnlW?=
 =?utf-8?B?ZytvSXhUbFVlS3NWU242U0FERTl1Zk5IWmlSM2dBbncwYlJ6dEF4TFArWDRZ?=
 =?utf-8?B?S3BFK0l4d0FuMHhxaXl3S3JYNGlJenVubWtFUFFlRU1QNWRLZXFydUNiRW5U?=
 =?utf-8?B?VlV6MC9oZExHTjRxaURNYkljbXdEek9WSFRmVTUyYnpDV3EwOUY0V3cyb1ly?=
 =?utf-8?B?MDZlQTVBKzgwVXlDLzhObEl0T24vbHdUSVhZc2gzNmhlZnVmOVprVmgxSXJx?=
 =?utf-8?B?b3lXbVdLSDRmVncxSUt2Q0hEOG90djlnUDhpdWdhS1libXNvdmh2ZnMzNU4r?=
 =?utf-8?B?WnFXcUNYSDhCNjJJTERqcHVCSlpkejZYbTh3UjNuZjVkYytSSkRoek1RZERL?=
 =?utf-8?B?QU1OWVRkR0UyK2FlYW1Tai9kRUxiaG1hWGVIOUI0Z3QzU0hWWnJvVTdaTHVw?=
 =?utf-8?B?bjFrWXpicE9NM0ZOTTlTQkkzWmJXaGpqRXhWUFRRWitrdHhGQ2p3ZjRjL1pH?=
 =?utf-8?B?T1EyNEVpL3JRbENNSVRQU0tsY1BEVStNblVkZU5RdUt2SmtvNVZVWGU1WWls?=
 =?utf-8?B?OVZ5Vnd6YjRKbkxvdTJZUUxJenNCTWJGVFh0V0N3cEtDOXBGc3dqMXBMUHlo?=
 =?utf-8?B?SGhKakRwNmZmRGNudW5LaksxL3krTWxwQUQ5alFLL3VJZGF5MktJVXVoSmlk?=
 =?utf-8?B?anE0Tk5KNWl3OWxDTXcwU3ZpMVhGNitSU0dMRDIwelN5U295c0tlMkVxc1Jv?=
 =?utf-8?Q?YTZH5OOphZtuslkFAr2bzE0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49feeda7-4156-4415-7e3a-08d9c47c095a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 12:18:46.2689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SZU/2PpnHWHT7Xe/nwEpks7KdM7dxnXw4YOhT3fDGUdNybTKtI05YQxnlZxzTRfwJ9ByYUtqI2LR5CRb0w+vsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7037

On 16.12.2021 10:54, Andrew Cooper wrote:
> With all infrastructure in place, advertise the PKS CPUID bit to guests, and
> let them set CR4.PKS.
> 
> Experiment with a tweak to the layout of hvm_cr4_guest_valid_bits() so future
> additions will be just a single added line.
> 
> The current context switching behaviour is tied to how VT-x works, so leave a
> safety check in the short term.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

I would like to ask though that you ...

> --- a/xen/include/public/arch-x86/cpufeatureset.h
> +++ b/xen/include/public/arch-x86/cpufeatureset.h
> @@ -244,7 +244,7 @@ XEN_CPUFEATURE(CLDEMOTE,      6*32+25) /*A  CLDEMOTE instruction */
>  XEN_CPUFEATURE(MOVDIRI,       6*32+27) /*a  MOVDIRI instruction */
>  XEN_CPUFEATURE(MOVDIR64B,     6*32+28) /*a  MOVDIR64B instruction */
>  XEN_CPUFEATURE(ENQCMD,        6*32+29) /*   ENQCMD{,S} instructions */
> -XEN_CPUFEATURE(PKS,           6*32+31) /*   Protection Key for Supervisor */
> +XEN_CPUFEATURE(PKS,           6*32+31) /*H  Protection Key for Supervisor */

... clarify this restriction of not covering shadow mode guests by
an adjustment to title or description. Aiui the sole reason for
the restriction is that shadow code doesn't propagate the key bits
from guest to shadow PTEs?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:07:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:07:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250408.431284 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzerh-0007yx-2v; Tue, 21 Dec 2021 13:07:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250408.431284; Tue, 21 Dec 2021 13:07:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzerg-0007yq-V0; Tue, 21 Dec 2021 13:07:36 +0000
Received: by outflank-mailman (input) for mailman id 250408;
 Tue, 21 Dec 2021 13:07:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzerf-0007yg-5b; Tue, 21 Dec 2021 13:07:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzerf-0000nf-31; Tue, 21 Dec 2021 13:07:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzere-0007h2-R5; Tue, 21 Dec 2021 13:07:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzere-0007HC-Qd; Tue, 21 Dec 2021 13:07:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=A9bUBMcZl66lJUm8xImP9URBaZMbmDWDYRePTJsL6e0=; b=bH0VB85hhB/ytrfc4r5V6Mtccu
	9tsy1mB2/5O3+Rhbmhlb5FH39oSxoiEY3F0Wj+ket9rdjXZj4lqC/a8sa4E61KuW595PZKcJwUP8c
	W5VA/yvTiUJaBkObGEhGizLt3/omqtLrt0zDuzKcFn+hYM1INd8uei3TRmiXr5RjkzrE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167503-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-smoke test] 167503: tolerable all pass - PUSHED
X-Osstest-Failures:
    xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 13:07:34 +0000

flight 167503 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167503/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167467  2021-12-17 19:01:56 Z    3 days
Testing same since   167503  2021-12-21 10:01:43 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-arm64-xsm                                              pass    
 build-amd64                                                  pass    
 build-armhf                                                  pass    
 build-amd64-libvirt                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-libvirt                                     pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8e3edefb88..f1e268b9fd  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8 -> smoke


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:27:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:27:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250416.431294 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfAu-0002Dy-NW; Tue, 21 Dec 2021 13:27:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250416.431294; Tue, 21 Dec 2021 13:27:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfAu-0002Dr-Kc; Tue, 21 Dec 2021 13:27:28 +0000
Received: by outflank-mailman (input) for mailman id 250416;
 Tue, 21 Dec 2021 13:27:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzfAs-0002Dj-Hl
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 13:27:26 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id bb05425c-6261-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 14:27:24 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: bb05425c-6261-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640093244;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=fM/xMZtHF3QCZrwvcd3A39+pWT6QtuW8AZWq07CfjJI=;
  b=ODu+r2VuJs086ka9IBBFVoHQ3SrKmmXaO79OZ2WgyVxCgUxc7YmxeFdS
   xdqaBMklcy5vZSUcyGifzDafPsgMcH213jKZ/DMr5wD8s8Y1sVC5saPAk
   Z2C2FwqlB39e4pIRNZRy3y4DUT9CBC1vmlpL/8xXH6wtV2zDvMQutwUzb
   A=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: yzFHAJEeFFKRm1WmZntAKA/ZE6nKmmakMB7BHyqI0zmisV1IwFSd6bGAcLLZQ/i/KyGesJQPb0
 V1UCw3KqVQ2JUFei+SSiEuR2R6kTl7aGAhDb+zJzt2HNA0X9o91nztZXqvxbZ9kCtxRsjfD9rn
 HKvncT61vBws6/ulve4IDIJwgUncfXTwR7BnrDr5b6mp6syaJ6KYanzr/8hM9UZybxtkJeKItZ
 cTrvfMSTKMzSmtMDgVI412Dt6l46pTlLvTbsRZa/q47vD3gQZDsJemR9nirosYDzkVN8j1mUqV
 pDocC2nBi3xTK1jQ1whDrkor
X-SBRS: 5.1
X-MesageID: 60512791
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eWkO56P2ADJHTaHvrR1CkMFynXyQoLVcMsEvi/4bfWQNrUoj3z0Gm
 mBKDTiCafeKM2WmKoh2Otvio01X6J6Ez9Q3QQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400g6w7RRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoyqWtfBty
 N5uiaCPDjYgHZGUl9gychYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9t35oRTK+2i
 8wxYwAoSBjbRhp1A0YGLJ1mgNezwXPtbGgNwL6SjfVuuDWCpOBr65DyNPLFd9rMQt9a9m6aq
 XjB5H/RGQwBOZqUzj/t2lWoi+zUnCLMfYUTD7y19/N0qFCLz2lVAxoTPXOrrP/8hkOgVtZ3L
 00P5jFovaU07FasTNT2Q1u/unHsg/IHc4MOSatgsljLk/eKpVbCboQZctJfQMM5nu8qRTcJ6
 mO22OLgJgA3v4G6aH3Io994sgiOESQSKGYDYwoNQg0E/8TvrekPs/7fcjpwOPXr14OoQFkc1
 xjP9XFj3OtL0abnwo3ipQif6w9AsKQlWeLcCu//emu+pj10a4e+D2BDwQiKtK0QRGp1o7Tog
 ZTlpyR8xLxfZX1uvHbUKAnoIF1Pz6zdWNE7qQQwd6TNDxz3pxaekXl4uVmS3ntBPMceYiPOa
 0TOow5X75I7FCL0MfcvOd/uV55zlvKI+THZuhb8NIImjn9ZLlDvwc2TTRTIgzCFfLYEzMnTx
 qt3ge7zVC1HWMyLPRK9RvsH0K9D+8zN7Ti7eHwP9Dz+ieD2TCfMEd8taQLSBshkvPLsiFiEq
 L53aprVoyizpcWjO0E7B6ZIdgtURZX6bLirw/FqmhmrflA7RTp/UqCJmtvMueVNxsxoqwsBx
 VnlMmcw9bY1rSCvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:q7uCy6i2eLp8fjyP7m9YpTMHu3BQXtoji2hC6mlwRA09TySZ//
 rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM
 RdmsBFebvN5DNB7PoSjjPWL+od
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="60512791"
Date: Tue, 21 Dec 2021 13:27:11 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Message-ID: <YcHWL7S+O8txY8Eq@perard>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>

On Tue, Dec 14, 2021 at 09:34:28AM +0000, Oleksii Moisieiev wrote:
> This enumeration sets SCI type for the domain. Currently there is
> two possible options: either 'none' or 'scmi_smc'.
> 
> 'none' is the default value and it disables SCI support at all.
> 
> 'scmi_smc' enables access to the Firmware from the domains using SCMI
> protocol and SMC as transport.
> 
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> ---

Thanks for the patch, it looks good too me.

But it is kind of weird that the manual describes something that isn't
implemented yet. Could you maybe add in the patch description that the
feature isn't implemented yet or that the feature is implemented in
follow-up patches?

Also, about the golang binding thingy, could you add a note after a line
of a three dash "---" that let know the committer to regenerate
everything that needs re-generating due to change in the *.idl file,
just in case?

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:33:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:33:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250422.431306 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfGh-0003ln-Bu; Tue, 21 Dec 2021 13:33:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250422.431306; Tue, 21 Dec 2021 13:33:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfGh-0003lg-88; Tue, 21 Dec 2021 13:33:27 +0000
Received: by outflank-mailman (input) for mailman id 250422;
 Tue, 21 Dec 2021 13:33:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfGg-0003lZ-OV
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 13:33:26 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 92865036-6262-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 14:33:24 +0100 (CET)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2054.outbound.protection.outlook.com [104.47.10.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-22-NKKaV__sMYqnK4WIwT1unw-1; Tue, 21 Dec 2021 14:33:22 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 13:33:20 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 13:33:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 92865036-6262-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640093604;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JtykITmE1BB0t5DVKQKDzCmAwSXVRtF17oWYPRkD4yI=;
	b=BBLIPkDWJJ8W7QTeEQM8liWzw/2u156JWl1Cl23NED4j7zkTi8NZq5HaWe8fksEBe4uxSy
	KPM8TSpUlXkzLmD5RfaIrOWCE2i5NUpro0svOKZyLlYFjY8ZGjCIqw56Q9ppLeBSrnWH8p
	JOZQJyVvWw5k5CXmS9FiOJAgqyqn7E8=
X-MC-Unique: NKKaV__sMYqnK4WIwT1unw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZvzXhyFShLVTMS07Z2eILadfS0MP+uhcXusb/3irmLRmW7RMWiT/ZerezW3MByhRP3VuEvA6FWi6Bfpk5t5MGm4VG9vcovxLvwlrVaJsuIaviLgKg15tjboIDw47gL1zCcBDuDilcFnpw2zAZDtF+ueqRchUvUnx8/Ig+tTzIQVxG6wHILzU/snxyCw3qYiQAcjX6lMge4MENVicfF/dq3FaY2w24fG9gtm4wVWtOc/S3MOSsSR+L0bKFwQ7Xz3PvXob5gLiBg6mSI7I9D8sJYUqgphuOSmNIm1SebhX7cM+cScMAduCmiEg7txurzEtvIdDhYZMrdDLgjYiKbH4AQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JtykITmE1BB0t5DVKQKDzCmAwSXVRtF17oWYPRkD4yI=;
 b=CdYl8J9IvFZV+n2YcmnDpIAr6eseF33/03c+Co81VSuJ660Gw89pa39MzQT1smuFuz0wMutbJZiso121TU1GKE38NsIUzyBHiK1F+hW4ECgT7EP67e9zQucVRiti4vNtZsz2hfVMubN5IMQKiyH37M9eoicXmcQheF3SezFhkQvuPU20gcSVPzi34X+0DKVQOrnALR9Z4XmjC0Egf2Ps2SWp/j07PqPMz9m8mKmJ8h82UMRH+flNbFgBLq/bKHeRhNVcAqVIgIHyZMQ0T3SlQgkIYon0pveCxbCVMRn6y5QWYE/7R9bON304L0Pn1TSGbnuOn+z/VIKcEVxNT0LGNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8d7694a4-d7aa-200e-d29a-f055909a13ea@suse.com>
Date: Tue, 21 Dec 2021 14:33:18 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 26/47] build,x86: remove the need for build32.mk
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-27-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-27-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0055.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:82::32) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 777d43e3-5de7-4079-5cc9-08d9c486741e
X-MS-TrafficTypeDiagnostic: VI1PR04MB5599:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB559990B66926CD95D28F8C0FB37C9@VI1PR04MB5599.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x234nkvXeTC1uIxunBHLmT7oZzlbo3GO5cJbHSCdrV7uHS6xPQmF02y/SHqiR4AtMk3YeYI78UlvTV6v8sjzYdvbVVi9V730zgPq9EZ0tp57zFYPeVooteM1w3hTCe9f1HjbI2zLmdfGlB35Ep8qPcC0eDd0DYEmSqoUSskLVrdl9jJtNM7hHl65ndJvvBrI85B/iLpwa1xzazxPzqD05h2oE1cVWdp3ktSCJSIrRlzObyYwZEzyF5vVnK8WV8HfM2VsIJEWvPMCPQOYlHpVfbcOCuS49ksRY2K/3q1oDLIVDaUWzltVHL3Wi1TjUpj9wC6+csHWDk9vvyHtFv9JGYgHN192a0w/79/zWzUcgT1zOBhmTfrNM5a3WuqJk8Aq7wXiK4Nv19r79psGsb40bc5w8v89wurKqOoam1tlMDfHnReqcy2zq+mh0Lfc5CNfT2k9Muea8CyAnTSHHzuVJFoi+MxK3shhb+zv267rulgoKah4IDUi5ZyrPnAjrzgy9gYxGxrTaeBmYxI3g4yf0ea2/V1dEbli45bfQxRmRFE7X7YI/8jIqTgjpTSl40+7NZ3l6Dn9KRVrpPkYdC22Q6Ah/Qwrmnmx7xdIhwJVbjltV6A243wp5Oj8GSdU2E9LW/k9PT4m/bPp4PajKBKDs6Yp9df8O8U41HstiituzbUZWXn5f1pIQd3utGg1l+nsrFI+vst7qPl5XjyjHigyQnMYA9MTyWfiQAH/+yN5fi8=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(2906002)(316002)(5660300002)(31696002)(6916009)(38100700002)(86362001)(31686004)(66556008)(8936002)(508600001)(6506007)(66476007)(6512007)(4326008)(54906003)(26005)(53546011)(66946007)(186003)(36756003)(8676002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aHA3VVdYL25FQXduT05ZMzI2ZnNKSmE0bytibG92R2JEOEFOTEZmdG51NWZE?=
 =?utf-8?B?c1J4Nk1PaVpLUnc4bERZeVZ2MDRUcVBSUGpUL205Y2I2VTFkakZCc1dUQVAz?=
 =?utf-8?B?ajJ2dENzazN1WmJLblRWRGx3WHgzQWpxNXZ4U09CN2d1MUpRYnNCZzczUU1z?=
 =?utf-8?B?alZrODlDVTRYWHFSNlRUbDMyTjhnZUxJNnN2TWpVbDFKYzllNjYySFhtbjJy?=
 =?utf-8?B?Qzl1dTg1K1BxWlB0TnQ1MEsrVHVTWHdCWFRkNE1GU09UZHk1K2lOT1BOMnho?=
 =?utf-8?B?VDIwS1RMSTBvMHR6b0ZPalhxS3NobDZtYnRJTU5DbUpCL2k2UkRDeVk2eWhD?=
 =?utf-8?B?cUpTbzVlc3RNSHdxUkxIY2lLdjh3UFdXdDR4N0g0SzRBdFREakVaeFlOVGZn?=
 =?utf-8?B?dlQ5UHRKSE5GdktJT05pWEFua2NNUFlzRlczZW1paXhvOFNXOEkwNGtXeStI?=
 =?utf-8?B?RVVVQ0RLTXZOZm1RQUVPdUhKU29tVUNmQ2JuNCt2bDVsUVJET3VKQlZKMkVo?=
 =?utf-8?B?MERKdWRQRVFTZWQ1OFhpbm5jWkdWRmlZQisvLzBteUlXc0l5QkVTNWJiaXVH?=
 =?utf-8?B?YmtGSFh3dlAybEFmQ3BOMS9sYXpvSUJIdXF2azBwYis1dDlMZjduT2lZWnBC?=
 =?utf-8?B?VGxwZCttYWwxYk1MdWxnWWRVU2U0Z3JSZFBHL1VhZFUzRWQwUk16Zm9OSlhu?=
 =?utf-8?B?WnNYSFhmejB3elFvQldNNXlIM09zajQ1UVZML0R3NzNMZkExeGw2NDlwMHdR?=
 =?utf-8?B?SHZyZ3AwVlJuRjY1Zm9QMjJIREVUQ0xVMStOaXhCMFBTeERzSUlkMkJtaXBj?=
 =?utf-8?B?eVVHUDNOQk90em5kcGhSSnRnN01BeGNKbnpxTHRFdmtEQmsyYzZHQXBac2xZ?=
 =?utf-8?B?dTk4VmUvbnBCR2NqVTZjYlNqV0tvbXlOWEpLL3pwb25Lei9GSUdYS1hTaHpR?=
 =?utf-8?B?aHNpeGROOUtGYW41QmZZNlorOERuMTI3MXFtVXFMN3lEaEdMUVgwMUdJVDJI?=
 =?utf-8?B?OUdhMjFwL1FRQXBYbUdqcGc4NUxVL1NWanVnUEdUam5zeTdaNzlpQ0VwdVUy?=
 =?utf-8?B?WEhpRW5ZV3I4dlFXR1A5YlFBb0NoajdxU1dkdUtaQzVLeit3NFVxRWRNSzRK?=
 =?utf-8?B?ZjhsYlJ3dFdsTHJWVE5ZNEt4Z0dXUVppOWFPREx3NWxkY3RvMHVCSkkyMTRS?=
 =?utf-8?B?R09DNHl6cmVuVm5Ya0x3MFpKaEI2SEpSSDRsMUVjSDM5c1k4bTRBVEdGQmov?=
 =?utf-8?B?b0c2MnpFSDFhNVR6TlhTNVpEMW1aOFFSM0Z2TU53UGc0K1FKVEF6aXovbHFp?=
 =?utf-8?B?SEM5K2lhWHk3dFcrbmRQYnlMTHhRMWNqWldZTVJsRm5ieEUzTHVLTHM0eisw?=
 =?utf-8?B?Mlh1Wi9EUm5OZkFiOU91YlpaZ1pFTzNoc1NIbmFsNmFKYmZ1bzdYdGQxWlM0?=
 =?utf-8?B?WlphQlFpQ3pGWkdFSGVpWUdZS0RDTUhVRm5hWUhUckdmekY3TGx4Mm5iK0Nq?=
 =?utf-8?B?d3JoOERSaGthdDd2Sm5RUGNWS05DNkFRS0RaT3JjN29rcjVURVl6OTAxOTZm?=
 =?utf-8?B?Uzg1M1M3MG5HSmlacXFER25rWmR3a2pLS0paQWR0SGoyUVgraVQreEZ2RTBN?=
 =?utf-8?B?NitOSFYwakZTK3lKaEVmUzI4cnpjRG5GdFRzeEVuMlJyQ0t1aVBsTjFIcDNa?=
 =?utf-8?B?VTBpSFNWcWo5NTkyRVFSd0wzSkQweFk1WXk4azMwbTcvc3JVK1o1WHEvTGZZ?=
 =?utf-8?B?UVpSVkJPTm1ma2hFdllSSVVQWFU3ZEpvY3k1VGJraU42c0ljNHU3cGszQTg0?=
 =?utf-8?B?bklkTmtXclhTeTdVMUVLZ1B2UU9nOHZnVXovQUMrMzJLajljZS96WDBuVkdN?=
 =?utf-8?B?ZS9FNXp6V2JJL2EwemFVMEx3WnA4THlTNDNETW9aeGpqOFhIZzZQc2lFMmZY?=
 =?utf-8?B?V3R4NVJZQTd2S1ZyUjlOT3VPSXlGN3Q4UUVCQXJWS2gwTFZrRzhIT2VBRWhh?=
 =?utf-8?B?L2RabDhUMmN5QmRGMWNzd3Y5NDV0L0dNMlRqaENGY3JRYlY3MHdKVjRQQlFP?=
 =?utf-8?B?NFp1N3ZycmVaNEZPVmxtWGREQTlJV1A0OGpyS0oxcHZqRnhPelhSWDYwM29N?=
 =?utf-8?B?Nm4wb0tWWG9OUWw3bDlVbUtkbEFJREJUeENrU3ZYbXRPYllCRlJyMU9CU2U3?=
 =?utf-8?Q?LNGbAgGd7NxniSHllyceDks=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 777d43e3-5de7-4079-5cc9-08d9c486741e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 13:33:20.3693
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zfFkOgEEs+4+CTfebFoD6w95KnHQ6WclpbFEmjSqPepXcZyxZVAOdizg2wRgzQDsxIb58KOaXHyFPpeDluMIPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599

On 25.11.2021 14:39, Anthony PERARD wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -171,6 +171,10 @@ export LEX = $(if $(FLEX),$(FLEX),flex)
>  # Default file for 'make defconfig'.
>  export KBUILD_DEFCONFIG := $(ARCH)_defconfig
>  
> +# Copy CFLAGS generated by "Config.mk" so they can be reused later without
> +# reparsing Config.mk by e.g. arch/x86/boot/.
> +export XEN_COMMON_CFLAGS := $(CFLAGS)

For my own understanding (it's hard to check being half way through the
series): At this point there are no further adjustments expected to
CFLAGS?

> --- a/xen/arch/x86/boot/Makefile
> +++ b/xen/arch/x86/boot/Makefile
> @@ -1,25 +1,45 @@
>  obj-bin-y += head.o
> +head-objs := cmdline.S reloc.S

Is "-objs" really a suitable part of the name for a list of *.S?

> -DEFS_H_DEPS = $(abs_srctree)/$(src)/defs.h $(abs_srctree)/include/xen/stdbool.h
> +nocov-y += $(head-objs:.S=.o)
> +noubsan-y += $(head-objs:.S=.o)
> +targets += $(head-objs:.S=.o)
>  
> -CMDLINE_DEPS = $(DEFS_H_DEPS) $(abs_srctree)/$(src)/video.h \
> -	       $(BASEDIR)/include/xen/kconfig.h \
> -	       $(BASEDIR)/include/generated/autoconf.h
> +head-objs := $(addprefix $(obj)/, $(head-objs))
>  
> -RELOC_DEPS = $(DEFS_H_DEPS) \
> -	     $(BASEDIR)/include/generated/autoconf.h \
> -	     $(BASEDIR)/include/xen/kconfig.h \
> -	     $(BASEDIR)/include/xen/multiboot.h \
> -	     $(BASEDIR)/include/xen/multiboot2.h \
> -	     $(BASEDIR)/include/xen/const.h \
> -	     $(BASEDIR)/include/public/arch-x86/hvm/start_info.h
> +$(obj)/head.o: $(head-objs)
>  
> -$(obj)/head.o: $(obj)/cmdline.S $(obj)/reloc.S
> +$(head-objs:.S=.lnk): LDFLAGS_DIRECT := $(subst x86_64,i386,$(LDFLAGS_DIRECT))

Considering there's just a single use of LDFLAGS_DIRECT below, wouldn't
it make sense to avoid overriding the variable and doing the $(subst ...)
right at the use site instead?

> -$(obj)/cmdline.S: $(src)/cmdline.c $(CMDLINE_DEPS) $(src)/build32.lds
> -	$(MAKE) -f $(abs_srctree)/$(src)/build32.mk -C $(obj) $(@F) CMDLINE_DEPS="$(CMDLINE_DEPS)"
> +CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_COMMON_CFLAGS))

I can't seem to be able to spot -march=i686 in the old code. Or wait -
Is this duplicating what config/x86_32.mk has?

> +$(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS))
> +CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float

You did inherit -Werror and -fno-builtin from $(XEN_COMMON_CFLAGS)
already, so I don't think you need to specify these again?

> +CFLAGS_x86_32 += -I$(srctree)/include

Isn't this present in $(XEN_COMMON_CFLAGS) as well?

> -$(obj)/reloc.S: $(src)/reloc.c $(RELOC_DEPS) $(src)/build32.lds
> -	$(MAKE) -f $(abs_srctree)/$(src)/build32.mk -C $(obj) $(@F) RELOC_DEPS="$(RELOC_DEPS)"
> +# override for 32bit binaries
> +$(head-objs:.S=.o): CFLAGS-stack-boundary :=
> +$(head-objs:.S=.o): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic

-fpic should again already be there.

> +$(head-objs): %.S: %.bin
> +	(od -v -t x $< | tr -s ' ' | awk 'NR > 1 {print s} {s=$$0}' | \
> +	sed 's/ /,0x/g' | sed 's/,0x$$//' | sed 's/^[0-9]*,/ .long /') >$@
> +
> +# Drop .got.plt during conversion to plain binary format.
> +# Please check build32.lds for more details.
> +%.bin: %.lnk
> +	$(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p;}' | \
> +		while read idx name sz rest; do \
> +			case "$$name" in \
> +			.got.plt) \
> +				test $$sz != 0c || continue; \
> +				echo "Error: non-empty $$name: 0x$$sz" >&2; \
> +				exit $$(expr $$idx + 1);; \
> +			esac; \
> +		done
> +	$(OBJCOPY) -O binary -R .got.plt $< $@
> +
> +

Nit: Please no double blank lines.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:43:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:43:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250426.431317 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfQ0-0005M6-Af; Tue, 21 Dec 2021 13:43:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250426.431317; Tue, 21 Dec 2021 13:43:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfQ0-0005Lz-6s; Tue, 21 Dec 2021 13:43:04 +0000
Received: by outflank-mailman (input) for mailman id 250426;
 Tue, 21 Dec 2021 13:43:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w49/=RG=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mzfPy-0005Lt-LE
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 13:43:03 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e89b4fc6-6263-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 14:43:00 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e89b4fc6-6263-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640094180;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=F8xw53f5M5iZ5/W6F/R1i2u7wK/t2aeSvk07/sCCRzo=;
  b=hCAudejgxY55w4e1yRUCLlLwhEcWtfJOkl6L9Ex5quXbkfJS5lmREQpR
   R+3LDFAKINvNa46aZCwlz8+GLGxsL8fWz+kpAs11x0k2h6YYqvUOGF76t
   4NYssdqbEqgizBROOLdl7zCXujMKrdsS4qgKfAxzJYw0BDzjxgKvIQs88
   c=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: V1Qejy0rpe1MiDxOBhB4QzFBf84oC318nmlW6ltHoD9eWDJKyrIb/KaqOKFvTQq6eQdeRCWH9D
 SJaF0iovRAspW2M27e+qXOCJlEyDPeVjXvsYordAjFgAPCVHfd4RHJrtS+MRupgJF9Oc3nvYLX
 BVVqmR4A9aMAPkzu9TlfSTgRUjy7Gpqq+rioae5bQWW5qN3R8z2tzj7Ii0j6DqRckctOthpFu3
 RJCGB+71pXsQkMg3JeItqE6lxQ4DkHWlgZA+gc0/Z0lM4pZyAP3vvS5r8MUSHQI5DBiI4Jumnv
 ry8pLgFsY42/UU9qK5PMywv0
X-SBRS: 5.1
X-MesageID: 60500647
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:I19baKtbr+/abFOaIMat5oV1r+fnVOdZMUV32f8akzHdYApBsoF/q
 tZmKT2APquPYWP0Ko8jPtnn9U5VvMOAyNY2TwI/r31gRisV+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24HhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnMWoFD4LOof3g8tHcgIbLhBaYpRZ0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JgTRa6AO
 5VxhTxHcizkTyB/FQstEcw/s93rvH/9U2ZTkQfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz
 krD9nj0HwoIctmY1jmM2nOqmuLL2yj8Xeo6DLSn+/osmlSVyn4SDzUXU0e2pb+yjUvWc8lEN
 0Ue9y4qrK4z3E+mVN/wW1u/unHslhwWVsdUEuY6wBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy
 kTPj97vHSZosrCeVTSa7Lj8hTGvPSkYK0cSaClCShEKi+QPu6lq0EiJFIw6Vvfo0JulQlkc3
 gxmsgAX3q1OtOwP/Z6g0grmmHGRl7yWdxEcs1C/sn2e0it1Y4usZoqN4Ffd7OpdIIvxcmRtr
 EToiODFsrlQUMjleDilBbxUQer3v6rt3Cj02AY3R/EcGyKRF2lPlGy6yBV3Pw9XP8kNYlcFi
 2eD6FoKtPe/0JZHBJKbgr5d6ex2nMAM9vy/D5g4i+aihLArLGdrGwk0OiatM5jFyhRErE3GE
 c7znTyQJXgbE7976zG9Wv0Q17Qmrghnmz+LHcqmkEj9iOHEDJJwdVvjGAHWBgzexPnbyDg5D
 v4Fb5fao/mheLCWjtbrHX47cglRcClT6WHeoM1LbO+TSjeK60l6Y8I9NYgJItQ/94wMz7+g1
 ijkBidwlQqu7VWaeF7iQi0yN9vSsWNX8CtT0doEZg3zhRDOoO+Hsc8iSnfAVeV9qbE4k6crF
 6JtlgfpKq0ndwkrMg81NPHVhIdjaA6qlUSJOS+kayI4ZJluW0rC/dqMQ+cl3HJm4vOfuZRsr
 ru++BncRJZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3OlmmAy
 gKbIRYEvu2R8YU7x8bE2PKfpICzHuogQkcDRzvH7ay7PDXx93a4xdMSS/6BeD3QDTum+Kira
 ehP4ev7NfkLwARDv4ZmSu45xqMi/dr/4bRdy108TnnMal2qDJJmI2WHgpYT5vEcmOcBtFLvC
 EyV+9RcNbGYA+/fEQYcdFg/c+CO9fAIgT2Ov/47F1r3uX1s972dXEQMYxTV0H5BLKF4OZ8Oy
 Ps6vJJE8BS2jxcnP4rUji1Q8GjQfHUMX79+68MfCY7vzAEq1ktDcdrXDSqvuMODbNBFM08LJ
 D6IhfWd2+QAlxSaK3djR2LQ2ed9hIgVvEEYxVAPEF2Fh97Zi6JlxxZW6zk2ElxYwxgvPzif4
 YS325mZ/Zmzwgo=
IronPort-HdrOrdr: A9a23:u26OlK9qDoDd+KC3w3Nuk+FAdb1zdoMgy1knxilNoENuHfBwxv
 rDoB1E73LJYVYqOU3Jmbi7Sc69qFfnhORICO4qTMqftWjdyRCVxeRZg7cKrAeQeREWmtQtsJ
 uINpIOdOEYbmIK/PoSgjPIaurIqePvmMvD5Za8854ud3ATV0gJ1XYGNu/xKDwReOApP+tcKH
 LKjfA32AZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF
 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ
 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K
 VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed
 MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9
 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="60500647"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JmznKemHpnZ3+C73TTMk5DN/44o/uh7nDyK1qTAL85pWHamg7rJdKlX7Uzi6nw7SJbozqumO4IvXXkm1M4hldrY9RN3owQ1bXuCiMIFRIG7oq7OyBoiRJ+P/9e1hOkRd5J0ufBAVjY0xHBT/ZEzArDAU+4LNOVob4MrQpxqAbHIN5AyzbF9vTk79VL5bv3U1dI6mL625TADhm8KWtxCJzottL08HAecM9BsYk0WLMDVZfmORc3LnpSSNfRPkD8qWSpUasST3k3x+yvTt51Q7GREfrEDS1JdhoQtASP1trv/Go6gSzbD7ZvK0FT7IvD8Jr+tozlTcuJzo1ZibSUAklw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=YOe4oh7wxgs4Bpg5Q4aKwfF9SpEPO3xYKDEKedyqTVg=;
 b=Et8Sr9S6Lstcm/lhv75RWHXHjRhTSz1WxY9kLln6hUNI+W9XP3hWZ3/OOWFTiJQc/xCdShq9R0+bndc6RoHLcP/jPMYwU/2+Ph5TeMS24O3srPzclGB1oIAwYDaRUgSSCJjiKazoBriW89YAy6AfD68CEIx9gjhcW3fVuf3t5EDot5odAbNSlY42dX1RL2inP3Gdp9wHNiE/5trd3bmBsWkq/qGJ2VS8tYmfO6hbepyf9M1hYm3w6u4qVfRlw1XX9kRhq+4Yzp3UIfHFBgIXVcy7JS5LlI5Mx3Lo4h2QyOMd0vqMJX+Po5ucgrUb3KtDor/DAIzEq6fmmBJ+e+Hgig==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=YOe4oh7wxgs4Bpg5Q4aKwfF9SpEPO3xYKDEKedyqTVg=;
 b=gJxqy5wAi/GlQAPWazS5z2gr5mKlWzQtqUZQ1fPHUmvOmafPcUSg+87M2XYXUdDQkoNG3zEdF96H59V+TSqWXw1115JCQah5Jyyz5gDLY8DjDyvAiuCPBKo5ast/NGxD4h17hxXFsqJhwRpBcGvAqe2vCatsRJtlq+xpy9dMBhs=
Date: Tue, 21 Dec 2021 14:42:48 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Andrew
 Cooper <andrew.cooper3@citrix.com>, George Dunlap <george.dunlap@citrix.com>,
	Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wl@xen.org>, Mateusz =?utf-8?B?TcOzd2th?= <mateusz.mowka@intel.com>,
	=?utf-8?B?UGF3ZcWC?= Randzio <pawel.randzio@intel.com>
Subject: Re: [PATCH] MAINTAINERS: update TXT section
Message-ID: <YcHZ2M4sWWASZntx@Air-de-Roger>
References: <8334f9e5-bee3-8090-595d-1d45c9af0eb0@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8334f9e5-bee3-8090-595d-1d45c9af0eb0@suse.com>
X-ClientProxiedBy: MR1P264CA0060.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:3e::21) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 62995170-6ca6-4642-b6ae-08d9c487ca80
X-MS-TrafficTypeDiagnostic: DS7PR03MB5445:EE_
X-Microsoft-Antispam-PRVS: <DS7PR03MB544512DA024E15CA80C190088F7C9@DS7PR03MB5445.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9ZvF1/flm8cluSMcpfpJ3AZJmOaIR7JMbiVFRKNPTRqT/MPNM/Rj/GuyLa/fzfSxU2DG8BXYjh/pOIWMalxA1sPwidYFVWoQ01UxM0oIWxoMqu/RvtpFexebBLA0vkvBXsBaOx/0VDngSBf+LCkAAUV7W+rc3exN1Wd5Yfyi2Z6a58jx0sdCv41oX6TNk5qSuz2CzVhdltiysdRc0mWCXDs5Na7bSflvjuUR32ap/tek009GAAxedurEwY5GcDQpwvXQL+x83/FIPj5fQrb4Hzk+6Lep4j3XkAB1i55YJnPljCYdxfB/U0+ZQqbJHo5nc/4cUM2yXCb+WfbQif2l5Hf02WkSOg9brzP0L6HlV3Tfq0MTAxpL76P7jWGU58Vr+pJsU3EH7vGr/RS4RsxileP6tUoq2Ft+g/RoyD6SagoYgEK/86usJExtnahK0Dv0QDUXKk6wcwfHm22tIUcTPMtSnFFyvOdTe/+R5H9a5SCPlzzw5Ww282j9vylVo7/CUXt3R5rqKeM5rCJFJ+WjPl/WDBxWdqzgL63Yb0xes/MeVDyvEL9kqpQ1jvdgk65ahpMMZDcQ4KZS0Jrmc/Pe1GN4N+SlMCoowvrjyeY3NWjVdJBrqw8fJC5Vtm61ym7EEeKgWOi9/KdNobF3LFI+eQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(82960400001)(6486002)(86362001)(38100700002)(508600001)(85182001)(316002)(33716001)(8676002)(4326008)(5660300002)(2906002)(6916009)(54906003)(8936002)(66476007)(66556008)(6666004)(4744005)(6506007)(83380400001)(66946007)(6512007)(26005)(186003)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEFISHU0eUV6VE9BTms3NVhXUmFiVFZFUnQ4Rmg3QWhySkdWVllwcVVzRmIv?=
 =?utf-8?B?MW8yUmdSUWh5VUI4UHdKT0FBQ2VUTHhUU2IyaHBRN0lNdHNDdGNweFBvSG1k?=
 =?utf-8?B?cm02UDFyeVhVVlEwTjdFbFUwNzRIaEVVWWRTMzJHc0ppTEIvNGs3cDRYZjVn?=
 =?utf-8?B?SE5EdFFVcnJWV1A0N05sNGpyU1U0aUlqdjZZeDVDb2cvWHI5dTVpNGFrN2Fr?=
 =?utf-8?B?Y0VxODcrc3MvdlAzR1hKM3RpWmNJcFp2cmdqTXFTSWc0MURQaVZLYjd2M2Zq?=
 =?utf-8?B?NlFhUGpoVVNQMWZacVlCNHk2K3duWThucU95VzZtRTRobmZFa05qamk0T0VD?=
 =?utf-8?B?YUE2VHlMY3RHZmRHdG56MXBFRnZLUEFlekw2U2hOc2xxMDBSU0htb3h0VUdG?=
 =?utf-8?B?ZHR1Qnk0eXNXOWRiN0NnWTU4aHVlQldzaHhKc3hkS3BJOWxhbVVWSDVJWVdW?=
 =?utf-8?B?TFpGK2YyV2IyWXphMGY0M3RRMDRXRjZqKzdmcWd5bE9VNUQvSHZrcFZmdGlQ?=
 =?utf-8?B?NWE5MEJCL04yK014dW9JeDkxZUNqemN4b3paM0NRNmVBRnJ1Y1RjTVpuZW5E?=
 =?utf-8?B?VzlOMTZrTFFqK0dLZ0h1SHN1UEFzYllMcmRDMUV6emo1RVBwdmNCK2pwNEtk?=
 =?utf-8?B?allSTXFEZzd5amJiZUdsMmVYZmJZSktlbmN4Nml4ZHp0R2dQUzdwSVVOclpD?=
 =?utf-8?B?c1NaL29vc0xNY2dxNC9Bdk5qeTRGcVdPU3NhcFRTTWtsTzN4R1JTQk5oVm93?=
 =?utf-8?B?dGdDd2V4WVFKMzdNYzdJUTFvUk02ZjBMU2l3Vm5WRzdqajZ2cTV4NUFLeFN5?=
 =?utf-8?B?VWMzQ1gvTE1BbGkzOTIyZ29tWEk2ZlZ4eHZaMnk4RSs4ZUVxZVpsS05UbndH?=
 =?utf-8?B?dHhvL2Z2QlRxZUxnb3ZNcVpWTnhiYjJxN1ZySVhJWmNSKy9iK2hucS9hSC84?=
 =?utf-8?B?aVk3VmEyZW1Tc2R3eWFnZ09zQlRKNnBUd1M2ZlVUT29RSFVGMThlN29RWGI4?=
 =?utf-8?B?NTlSMStTN2UxZ2t2N1J2TkV0Q2x4alljVUZlVzJSemFoQkxqMWdhbXVLWVJ1?=
 =?utf-8?B?ZEJNMGl6ZitNVklZRFpsV2Faa0dpT3FOZHpTTUlpSEZzMUY2TjJSU3pjc0tK?=
 =?utf-8?B?UkNlTmJSQUY5VUNjMGxYL0toMy8welg1bmFzSDZJYkY3RndETnJyZHZyTkRr?=
 =?utf-8?B?MWtPelZQUzdxRjRtUXI0MUdlRlRrdzdLT0NFbm1kSHp1ajJwYUd4WHk4NUlH?=
 =?utf-8?B?d3p1akxzbVE0Q2JJMWRxVHY0MzJsK3VYQkEwRllrS0phQi8xbVE4b2RsbVlB?=
 =?utf-8?B?S0tLbFV5akN2emdkNGNoZ0tndzVPWHFPRUFhUWt5dnRlWForbWpyU29WeTM4?=
 =?utf-8?B?RHpqTnYydEJvNEVDcW5aVXh1Q1M1bGtKWStsbnk5S3JzL1NMNGZudm1FdTZR?=
 =?utf-8?B?aCtYeUk1ekF2WTcyZlhTZDZEeHBOVU5VcXI0NjFqekdJV2lqLzRpVnJ3cWRl?=
 =?utf-8?B?dWZTRkplR1c5TDRiekptT3Zma1ozNDB5eFE5ZTd1U3VwRDEzdTA2WXY5Nmkv?=
 =?utf-8?B?UmRSdVpKSHhvdEMrUFFzbXVOU1FyR1BvS3FGUFR2VGRhSDY2ZUttMDNHZlVi?=
 =?utf-8?B?WWJhdGFiVUdRd0J5MVpxdEl2aldsZzZmUlN5a041cThMU0xqaXVlOXQxLzBN?=
 =?utf-8?B?czJwRGtnbDlDUTNSZlNVdnRDQy94YjlNTXhvcnhlMGFLMUdTK1l5RWdmazBp?=
 =?utf-8?B?Um9aVjhBVWg1N3g0bjFXY0s3Y0lKYWt4NjZ6TkVTM1N4amlGRjFjZFpYdXJt?=
 =?utf-8?B?QVlweXVNNkVRMFFIdHJ5dEl4Yk1WeVg3THVjdnVsSi94SUIzRmYvSk5HSjE2?=
 =?utf-8?B?Z2hCZlNYRkpLaEVlYWJWRStBWVBSRkI5RGY1N0VKbkVVYXRvRGxQMjhFU0Yr?=
 =?utf-8?B?WUE5cDZ6UXJ4aGFYYnVkVnAwMHFWTXhOL0gvRzY1NWFpbVcyTGxVU25vRWw4?=
 =?utf-8?B?b1RwZU9OaXgybWt4ZUtESjEwdVdOWFpoYm42NEZPRDAxU1I2UXh6Y0tpSFpy?=
 =?utf-8?B?cWhSd1hSQmE2QlU2QkNnZ0poQzZHemo1VGluWUhKaEtHaG1KL1NvWkNNdE9S?=
 =?utf-8?B?WEdUKy83MUhvcnB1ZGl0REhzaDNOcjg0WTNCWnNDVFQ2UStZQzBKYmN0UndJ?=
 =?utf-8?Q?Ek+YMM7WRXFBK7FkcV/PJlU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62995170-6ca6-4642-b6ae-08d9c487ca80
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 13:42:54.7635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qYvWHLyvR+pBQsST3vJN3k4HM6PGJc3wGMILuQGcajZp/b6naTCfDmK7uVOP6WjCoQ07ZnkI+/gi+K2kNsWJ7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5445
X-OriginatorOrg: citrix.com

On Tue, Dec 21, 2021 at 10:06:37AM +0100, Jan Beulich wrote:
> Since mail to Lukasz'es address has been bouncing, Intel have suggested
> replacement contacts.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> To be frank, I'm not fully convinced of the M: - I'd instead see us use
> R: for both just like we had it for Lukasz.

I assume it was Intel then to explicitly request for Maintainer
status?

I'm fine with either M or R, albeit I agree R might be more natural
since there's no track of record in xen-devel of any reviews AFAICT.

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:51:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:51:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250432.431328 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfY1-0006zT-7v; Tue, 21 Dec 2021 13:51:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250432.431328; Tue, 21 Dec 2021 13:51:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfY1-0006zM-4D; Tue, 21 Dec 2021 13:51:21 +0000
Received: by outflank-mailman (input) for mailman id 250432;
 Tue, 21 Dec 2021 13:51:20 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w49/=RG=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mzfY0-0006zG-6q
 for xen-devel@lists.xen.org; Tue, 21 Dec 2021 13:51:20 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 0f9bdf67-6265-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 14:51:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0f9bdf67-6265-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640094678;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=mLUuyYgh1ENVwKR1L/hg//jSLwLUQn5DQVr5oWVxwI0=;
  b=NPuRHdSLf9/NKaNNMppLvi48Nrc4tHeent+VHVYOdjWO5Wfg16R7KqZP
   IK1QA7ZEbTbgq4HumLMpmVmDRA8kKVtbWXPfeeNGZx5V8Si6FW55IF3Jt
   5fKlpfeWlVTLYVMp9IFz+2OfL9cAO1A5cwcT22FK9dAqgFe2WIOwIOEjA
   M=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: PIMJ1xatvSClbQ/gExxd5s5R1j+LqADOcujVm/0rxln1jqbv70ezjdPkC0ncbBxxXsIVaaWyjl
 b62mIKMFnrQnXxa9pzjyVjveNbrLB3dlgWxDJ6DjWN3v8/K/bN5nID2kAAuiF0JWCU60loTLSq
 A0mWi/2ur11K4W631B0qcaqwDLViCLYSchBZYOOdw0Ozbl23qDnbcDiXueSGc8ueqYth3k2kRj
 JA1cnKMhZZJ/L3UMt7JI41jLU1hDo4OIT37glf4AV5K6wEbDYm7HGX+mn4Fyyi4yxTpLNcwQpG
 BNXQR13Njw/AYZbzXjtHxO0E
X-SBRS: 5.1
X-MesageID: 62594793
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:LIA/fqsC06p1GKn8Pj3HcOnaXefnVIVZMUV32f8akzHdYApBsoF/q
 tZmKT3Qa/2MMWunc9giPYq29U4C7ZbRzN81SAI//yljQyIa+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24HhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NplnLOMUQxuEYf1w98hQxkEDTBAFpVW0eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JoTTKqBN
 pFxhTxHTzPFXD9mZg8sGcgjg8awuXPWIjZikQfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcctuFxlKt/HO2i+rCgS78QqoPD7Ci7bhxh0CJzWEdDwcZWB29rOXRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiFerggYXHPV6KrYB1BGNlrTF3S2hFkFRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl8oDGJGT9bxgbQ+0RqmBNzBJrVml
 CJb8/VyFMhUUfmweNWlGY3h5o2B6fefKyH7ilVyBZQn/DnF0yf9IdgIumwheB0waZxsldrVj
 Kn741s5CHh7ZiTCUEOKS9jpV5RCIVbISLwJqcw4nvIRO8MsJWdrDQllZFKK3nCFraTfufpXB
 HtvSu71VSxyIf0+lFKeHr5BuZd2lnFW7T6CHvjTkkX4uYdykVbIEN/pxnPVNbtnhE5FyS2Im
 +ti2zyil08CDbagO3aPqub+7zkidBAGOHw/kOQOHsarKQt6AmAxTfjXxLIqYYt+mKpJ0OzP+
 xmAtoVwlTITXFXLdleHbG5NcrTqUcotpH43J3V0b12px2IiccCk66JGL8k7erwu9epCy/9oT
 qZaJ5XcU6oXEjmXqS4AaZTdrZB5cEj5jwy5ICf4MiM0eIRtRlKV94a8LBfv7iQHEgG+qdA6/
 ++7zgreTJdaH1ZiAc/aZeiB1VS0uXRByut+U1GReotYeVn28ZgsICv016dlL8YJIBTF5z2by
 wfJXktI+biT+9c4qYCbi7qFooGlF/pFMnBbR2SLv6yrMST6/3a4xdMSWui/Yj2ABnj//7+vZ
 LsJwqikYuEHhltDr6F1D61vkfAl/9LqqrJXklZkEXHMYwj5A79sOCDbj8xGt6kLzb5FowqmH
 EmI/4ACa7mOPcrkFn8XJRYkMbvfha1FxGGK4KRnOlj+6Q924KGDABdbMBS7gSBAKKd4bdE+y
 uA7tc9KswGyh3LG6DpdYvy4I4hUEkE9bg==
IronPort-HdrOrdr: A9a23:3Ik7lamcZOxHyOyM4zSrYjeJ8HDpDfIo3DAbv31ZSRFFG/Fw8P
 re+8jztCWE7Ar5PUtKpTnuAsW9qB/nmqKdgrNwAV7BZmfbUQKTRekJgLcKqAeAJwTOssJbyK
 d8Y+xfJbTLfD1HZB/BkWqF+gAbsbu6zJw=
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="62594793"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PhjAHBoPzWOdIy3KVZnwp13axeUcRqUjYoVHWSpFeoBRXkR1hfXyFLWYPzpF2IX05WhFHZsousnw4vxU2zBfnE/lySMCQjGybCQsVTKlDPamlEgHg5PX0EBfDgYhqyqdLyDCfxFT+pCaIFLIKlZiuUMFjy3VDuXrGQpZtCzVjTzIl0GM/Xf2uz14aQzwakd6IoWO9LBRLPL0uJfPVmGCXr1lHa/ER3sSsLl62LeYPtBLV5IUfR80k0sHiquIZLCwQ57aFNOsWkYIEelL4XeNNTiOfUEMXoC2RjP8cHhQ0a5imxDm5/wlI5Mux6zNoaRsmjPyayZDqqpdsNog0iJmSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=2aPr7tAxVoIO109CZE9Sx2d5M4gRuBgasxla9D/Qt84=;
 b=csmCvZkvUIxQShQ1rGKfZITEFFalu/o2X73RZgU+yUIUdOKLuIj5N+h9inzoO/JsXDJAZAXFBJMczZSqHZVl2MNamakFMmhLQINIKGWoWZmiIPYJhQTmLJt/SEvdejCWNsKbkvriEgO2aH4XVDmsr56GvHOH5gIRIUOZTId9H+5+nCO8Hb7WoPWkCgbT6AVUyAm58W45wsGqWrSqCs0rRzP65YxQ9FKBCR400D2SpmU4Lg2xcbKs33M7XB2i1se572W6haSaSy3DAG/yosF3VfQwAJCxkIBJhjO1taj2g2nI+kGq2TIpa7TRmTj8l5VenKSWQdpnIN4Vtt+9HbENGw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=2aPr7tAxVoIO109CZE9Sx2d5M4gRuBgasxla9D/Qt84=;
 b=AuIdrLYYGgPmFyAy3isXQ4Fc8zYRoOor5OZgdX1kn8bOVYp3ilOTb6B/Otv5bWTTaaNNmVhjmNefGzn1Vy1vSPIeUc4xkDZ50LM+ajgpXseHbtauxBOx1vKCZFNtxvbcWI2Y63bm9791Pn0u4hjRmaaUQ35k0yqdcJ6t8DUMtwE=
Date: Tue, 21 Dec 2021 14:50:50 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcHbuug9AECvKXm9@Air-de-Roger>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
X-ClientProxiedBy: MR2P264CA0161.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::24) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8764393b-2aeb-4770-15d7-08d9c488e9b7
X-MS-TrafficTypeDiagnostic: DM6PR03MB4539:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB45395F044B3B3F60ABF70F758F7C9@DM6PR03MB4539.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: otliLXFBC8BaWx8q3BpByYnEzqpo7MV02MOHBuIhaNQ8wrRrcLd3Z85+xb9D7GGZJ4QcrAjRByc035sGxoh/t1jtQwHjVthDtNBtBEPlOrgWtd235/JPVGdgjkmwUPI6M2YTx1nhLM+z+/B6qkl5YY+T9M2rfYAF7gNNFLRai26GLVSI1sPwo29LjSSO2OsABQfVoFvbWleHFeB9Hj5OLrIUc+CChES/lsKCBigxwoWQV+fk/QkNzGcG+7w+uXftXiZIesi1jtKk3UaQhOqOb4xsnuXaHxrtvbc+cNL2+i8Bl0OlRBqLATK7M+sDfr2bPr8LvPQ9OnbSpBs/HCcZ/TlX8vfFF0j1kY0SBxQT20LD99URm7xJL9Cmvvx0w+ViAAlxGfa4+dcr/HAiDkwUUHbg//F9a0E8tzV4lKLU/EPak4+pyxFIsD5UnKp2dUZDtzIJrYAgYwjRxRXqIp02uRTTemSLsx2gbqKtwPMQBT80tA1Cbsa7dgtxR++il/nutodSGMva03/iOc5v46fvHLTN2VgbxJ3K5BMiMN9fFS/01Cml+KMEZyIFsexjSp6szlugxkjiAhG8e8tLFro7xbBbGKZCQsYNaKrttOQRoRovq8hkhXk6iM1LzzlfibpcpEE/3WQJX3VKtU4Qf5J1Cg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66556008)(66476007)(66946007)(38100700002)(86362001)(4326008)(5660300002)(9686003)(2906002)(186003)(26005)(85182001)(6506007)(316002)(6512007)(6666004)(6486002)(508600001)(8676002)(6916009)(82960400001)(33716001)(83380400001)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkQ5cjBlTlhXUE15ZnlBZWRzVDJVYUdhNkxpU3FxM2tKMDRLQUxMNkZtcEV0?=
 =?utf-8?B?OEl4TFdaQkUwM1NKZVJGZlowZnByd09jLzJhZ014bjdJVCtwcWlUQlVyc29L?=
 =?utf-8?B?WVgwYTI2U0hKcGVPdGNWbG00NnFMcGU4T3M1UXNybEdUQzlPMEwzc1JhRFVk?=
 =?utf-8?B?dDJlU3FEajF1ek01TGFRczlBSURyNFJUZXFFUDRkL1Y4RHJmdXdoeTZmNzlZ?=
 =?utf-8?B?UXRCODdGTVFnUDRwaTJJN3ZMN0d4VDU0ZjhwcUNMMFpJQTdTdjZYNkxTNmcv?=
 =?utf-8?B?UllOSzU0MmlTRnBXdFhXNnJaQkVpWnFWcFJsTUJJV1p6MEdNVWt5RzJZdTQ5?=
 =?utf-8?B?Zk1PQ0JGWk5iNDlGVGVzc0tWSWNBZTBoMGcva3pKeTlZa08xdU9YaGNmYUhC?=
 =?utf-8?B?OGtVSGVVejg0cDhEdTVobktQei9RMGtpM2dQZXI3MTVnYlVRbnIvMTA2SG1J?=
 =?utf-8?B?MFFVOHNuUkxuaVNRQllpcys5VTBCRHdyV205UWxHR0hXUWpNM3BSck9kSmVo?=
 =?utf-8?B?NnM1Tk5yaHBZQk1JN20zSVBZajBKRy9hT3dzNUhyRUtEbmNpMWJqenhCL3VF?=
 =?utf-8?B?UDlUZmpYNlNhVHU4UWVmSnkzTm1JY1Zsc1g2ZTN3bWovcGxnek15ek9nelUr?=
 =?utf-8?B?ZG1TWHZuR1B2dHFQQnM5cjNtSWlvVmFIbnlZYXZVVmVEWFBQNTNjcWlPcTQ0?=
 =?utf-8?B?Zmt4SGovdTJrWTFFRURuSXFKYWhIOUdqdE5tVDNSdFdzWkg0WW1BazcwVmJv?=
 =?utf-8?B?SEJHMUsvRGxwREg0WVRSQUN6MkE2RzVEQXE5NTV2RnBmUjBtUEE1di81OVBn?=
 =?utf-8?B?cS85YUtZN3JwUVBIM1Z4NmxPdTdUQjZPWmw0OG45RFhEQ1NyeVRSeEw1QWhS?=
 =?utf-8?B?eURYY3J3Qm05TlJ1OUo5bDZ3TENyUG45WVhaY3l0dXJVZ2VMUWxXbXpoQUFW?=
 =?utf-8?B?YUg4R243QWV0eko5c2pKaGpOdTRJZFI4dUV3R1RlN2xHTVZORlNJeDAyaWVC?=
 =?utf-8?B?VitMc3c1TWF1Y0FNWWVtL3YxOXR3eEROeFpsbXpGT0p4blZPbFk0cnF6dHht?=
 =?utf-8?B?SlhUNXRsc0ZsK2FtSlhGQWxLcUtkenZTOEUwaWFSYkNxZkpIZWFuMkF1NThh?=
 =?utf-8?B?U2VwdDRQcE9SMzQ2R1VuNlBlU2JPcEdIeDRCbkRpR1B2ekVSaFZSOXZIU2R4?=
 =?utf-8?B?NzBYZEhVKy9tOHh6M3BROGJ2U1BjTC9RNG5SZ2lIeCswc0RCcDdlRVZsYTc4?=
 =?utf-8?B?bFBQYWFqOFFtekh1S2ZtVUd0bFE0WG43RUJwazR0bDBPbVFCZkt4TTE3TWpM?=
 =?utf-8?B?dFZ2eGVHM2p5dTlXazI0alg5UEZGUnFEdW81UEVmakd0dE1jRTVMZnBEb2Yw?=
 =?utf-8?B?OFZuTkFVdDZxN2hZRFVNcE1sWGdKUG9oWEQwSzdUU0ZpQ2p0bmdodTJGc0VF?=
 =?utf-8?B?czVXdGppbUlWTzc3ZVZLdHVubXJTSUZMYXpIamRSbFFQM3FCMXMxSFRQaWJS?=
 =?utf-8?B?ZThHNURzYnVnNXY4czlIeGhFK0twVHdZMUNLdG0vUlN3djNmZEI1dEpCZEx0?=
 =?utf-8?B?ZW1MYWx2QWxYQ1g0U1ZGU3RJajJXNnRHSVQrbEJUakpKWTFFVDZGaWp2b2lJ?=
 =?utf-8?B?VlBjR2RtWlRnUFEwZTgwQUlPN25TYmJEV0JzSEVrdTBneTduU0FyUFdzQ0xQ?=
 =?utf-8?B?UUpoWVNhUnU2UXBreWFPYVVSejA3cUV6SS9yOFQ5UjdqM3I5WDczRVI3aFlQ?=
 =?utf-8?B?djNPeWMxSDBVYmMwTXY2NmJZWjVxOHVoajZZMzRqT05HZXJmRFBJejN2ZHNU?=
 =?utf-8?B?ZW5uL2IxVFdTNUh6eDhvcmQzTXdmN2p1YWM0YU5jOUpxTzJKSCtsS0REZ2l0?=
 =?utf-8?B?ZHNEanFnMkUxUmVGaE9Jdnlxd1FOQ2piY0RzN1M4b3M5b1JUVkI3SktwTHQw?=
 =?utf-8?B?cWozZFdxV3d5UWpndW9WMFZ6T2UrNTdQSDQveEhGQWJyTTlmRUJVbDhtWXNn?=
 =?utf-8?B?U015VlBrKzl4Mlc1d1YyZnJkM05HckUyLzUvNm9kSWhXZ0FEZUNLOUE1TmpG?=
 =?utf-8?B?ZUQ2MHQwQXNEM2lKNEV6UkppS2JXSnlMTVFzTGJuRFlPNW1kclFNYUxkVDJE?=
 =?utf-8?B?UUI4RGVmblFIVUFGSHZuRWRUVUF5UFd5MUJtaDNOK1h3TktGN0ZRY3hraVJ2?=
 =?utf-8?Q?VSCGJDbkoCT7CsRc38XdJ1c=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8764393b-2aeb-4770-15d7-08d9c488e9b7
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 13:50:56.7353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bo2gFOGOnk0owVatDKftp1ASqggDnsi+SEydKKLLySKWjlq9LKK77VnNgF+CzebofCZ7o/yOoTg46vKdTJV5fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4539
X-OriginatorOrg: citrix.com

On Tue, Dec 21, 2021 at 01:13:43AM +0800, G.R. wrote:
> First of all, thank you for your quick response, Juergen and Roger.
> I just realized that I run into mail forwarding issue from sourceforge
> mail alias service, and only found the responses when I checked the
> list archive. As a result, I have to manually merge Roger's response
> to reply...
> 
> > > I have to admit that this trial process is blind as I have no idea
> > > which component in the combo is to be blamed. Is it a bug in the
> > > backend-driver, frontend-driver or the hypervisor itself? Or due to
> > > incompatible versions? Any suggestion on other diagnose ideas (e.g.
> > > debug logs) will be welcome, while I work on the planned experiments.
> >
> > This is a bug in FreeBSD netfront, so no matter which Linux or Xen
> > version you use.
> >
> > Does it make a difference if you disable TSO and LRO from netfront?
> >
> > $ ifconfig xn0 -tso -lro
> It does not, the fatal error still show up after this command.

Thanks for testing.

> >
> > Do you have instructions I can follow in order to try to reproduce the
> > issue?
> I don't know if there are any special details in my setup.
> Hopefully I don't miss anything useful:
> 1. Build a TrueNAS 12.0U7 DOM-U by flushing the OS image into a vdisk
> 2. Create / import a zfs pool to the DOM-U
> 3. Create and share some file based iSCSI extents on the pool
> 4. Mount the iSCSI extent through some initiator clients.
> The domU xn0 should be disabled immediately after step #4.
> 
> I omitted all operational details with the assumption that you are familiar
> with TrueNAS and iSCSI setup.

Not really. Ideally I would like a way to reproduce that can be done
using iperf, nc or similar simple command line tool, without requiring
to setup iSCSI.

> For step #4, I can reproduce it with both ipxe initiator and the win7
> built-in client.
> As a result, I assume the client version does not matter.
> For #2, I actually have a physical disk and controller assigned to DOM-U.
> But I suspect this is probably irrelevant.
> For #3, I'm not sure if the content in the extent matters.
> So far I have been testing the same extent, which is formatted as an NTFS disk.

Can you also paste the output of `ifconfig xn0`?

If I provided a patch for the FreeBSD kernel, would you be able to
apply and test it?

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:54:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:54:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250436.431338 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfaZ-0007c9-L7; Tue, 21 Dec 2021 13:53:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250436.431338; Tue, 21 Dec 2021 13:53:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfaZ-0007c2-I9; Tue, 21 Dec 2021 13:53:59 +0000
Received: by outflank-mailman (input) for mailman id 250436;
 Tue, 21 Dec 2021 13:53:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfaX-0007bw-Gr
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 13:53:57 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 708b6a0e-6265-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 14:53:56 +0100 (CET)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-5-1JIaAd2KM56GMnJUNIA-yA-1; Tue, 21 Dec 2021 14:53:54 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB3118.eurprd04.prod.outlook.com (2603:10a6:802:a::16) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 13:53:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 13:53:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 708b6a0e-6265-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640094836;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=Qkjjh9kRi2Eganfg66W6tiCiZCvz3HlNuzjxCpX64cg=;
	b=US3qacgjtsdiWmZCWXyzJJlXbSA/LdWekNoo+XSCrBzXQ3Ae7LNc60HebTE3xTAFqDEaos
	lOHAXIb9VP2qLbRc71K01TzOWgcqo/rd+SWxyXROllAvqLYZVLRjoeQrB8aJcm3TjWKsnn
	21M4+EZOqDrh65Ql7QsHdydlf/h69yU=
X-MC-Unique: 1JIaAd2KM56GMnJUNIA-yA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=b4190y3sv+s5BjmA6EkG74B73zQkxBCHU9A2dSj/NMm0wPeJNAR9Fbc4F6dCs4bbROxn6+QWgqVW7pIQAdy8QWein1VhNTaxFmFftyH5NULEodFiS23wNqWiXuTMybQJ+4ojDHubPIrGeoA2J+KWZ28aJDkPe6nNNoxD3EwZQMfovFr2ZJHBFAIyFUXk5fzpeV4Rr464B31aQJCWrA+wEZZ2MBDZbsZ+7P3wLRK7iw3BxZm2mbGp9tdSALUHKPVeKxuIbROp1epKXhvsjmKNCIEeMXAq/T5pfBHNxVhFsKFeNM5EfDLT5mAOQWth7YKXZsD5KC8qjigLZxXETZ15wQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Qkjjh9kRi2Eganfg66W6tiCiZCvz3HlNuzjxCpX64cg=;
 b=HK2M++D6INaN4RXFi+rWKKlRxM5z136nzW7DyQEOz8wzqE+7PvUshNpiLqvOYbGHnhj5zQa2j4DO65HfEYnfwxIxXV6gZZDXQpOLd60r5Rj+E4q5sXX5Dy7lsREi12PkDIgr2dgS2oAdofpVrgJwMayw1NgnugQgQ61uxE+ymvsztJam/0MEiPNB+boOqYZw6hcUPmYTrBpoka7iokdezYT41Lo7nn1SZuDU5lRjjFuCfwVHdOTRtekAqHoGyUGPc5OXch9ftICToR+5evxV0u8pRhhXhlCsD4M/hvDyeOF1WyHMgKDHLiPuZCE8kbp1pCIbnjRtoBtvIrqr+JqVfQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <57f03aed-c260-1c80-c604-0223d4603b4a@suse.com>
Date: Tue, 21 Dec 2021 14:53:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 27/47] build: grab common EFI source files in arch
 specific dir
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-28-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-28-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR1001CA0072.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:206:15::49) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c6c8fb85-0ee5-4670-dfeb-08d9c4895203
X-MS-TrafficTypeDiagnostic: VI1PR04MB3118:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB31183858C62C2ED66FD9D787B37C9@VI1PR04MB3118.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	UkJ6JBMMfw4t2qyatlKNAENy5pvrn0+soJPZuCbU3RfV/IMnmHnM4Pul59pKVoQkQSSVHQnLc8DHTa58wH3D+ddFEhNTnlkziAFv2TXCwJ0W2uyvRFyBhZaiT1FmkwIO2ebU+Q6vygXcfGNAhYJXUyGZzwt3VA8tPeuNvuYNqRHnPEfEbNfz3IVGx3fC1CIndB3ISXqPcLzbfVYGyRV5oNIEPsUNUa1DFqmm1hiBexrwGsdLRJELa8+gl8JR+ezg9ruIhfaEqpwr+py3q2BFWygZ/FfHV62/+PhjuDMHcj/elWgkm1yjk9wRJZTlStRC5/C9vBAeIQy3wyMiF8CxkjrvT18HKccDzUHuf5k8meRcR8AB0ESzw3dabbXGlUWz5w6HHbRAU78sHEZPqB8aVEIjDHXmAtGRq9AyxWcK46jGwB/Ncl25ppXR7J8yTIWf3SJb1MVL14mPiKj5fQR/GyyEKeaN0qi9NTua7Td3nuHBYLsgRaptqDyojtvq42L18JDMXgYx84aJE/VJAv/k8IBL2y42o8IFsGgJszpMll6t/haGZqwJ/IwEio3AyPVYsnIkJcEr1FY/PWFDH1S27ThNaMb/8Bl4egSJp91/MnwO6Mk4Suf2kGMtiYqiwzVWy214d3bRBtZ+GClEgfgAzyb4BEPxe3a8o6WNFtuvpQIBjU7l1mZvl5qKD8usDcV9+roFzS3WXXi85inXQf50yOg4750t2e/hTCK0vg+QXgo=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(31686004)(26005)(36756003)(31696002)(8936002)(8676002)(6506007)(186003)(7416002)(508600001)(54906003)(86362001)(2616005)(53546011)(316002)(5660300002)(83380400001)(6486002)(6916009)(38100700002)(4326008)(6512007)(66556008)(66476007)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TWJoSWhvSnMvR1lrSm9ZV2lISmJhYi9rZjhZY1QxMWdEV0hBdXpLTWN5TUp3?=
 =?utf-8?B?dDdSMWxyMHNQZUhWZG9EaDFaSDRjVVNuZE1PUkh1ZHhPbFhlenE2RWczS0pK?=
 =?utf-8?B?RUdDQWFlWHRYbFp1OUd0MjErT3plbitNTXBnUEdvbXcxSlBOejJZbklyM3JM?=
 =?utf-8?B?TGJmUjdRUGRHaE13ZUVQemhOWm14ZlRqb0ZGSk5zZFVnQzFqSkxZUjArbWNG?=
 =?utf-8?B?a1JRaHptSWFienVvb3FnVzJmTkhXNUswN3ZsSWM3YzFaYmE4aEFlZUtLTDlD?=
 =?utf-8?B?QmpiWWdBVmtIVkZrek9EdWh2eXdSazZ4OFcxS0ZOVnR6em16WnpCL3NvOGF3?=
 =?utf-8?B?aGtyZmhxazNGVFJWSWV3U2VNYWE4ckpNM2M0Y0VXTng4S2pWWGZjdVBJYkEr?=
 =?utf-8?B?cGJKUDJZNUhtZVlscTErMlFTa0ZYSnpkM1Qra2hVR3hEMW8wLzlIZ1RZQnZK?=
 =?utf-8?B?N2d0M3crU2ovaThPQ0NqTHoxREJBcjFvOVY3YkhKWUtaUy9hRlVtNzYyTmZE?=
 =?utf-8?B?RFoxWW1mTnhpcjFSb1FsRlB5eGpiVE9rT2Z5OHpIVVNWWXZHRHNUQmRkNTEy?=
 =?utf-8?B?cXNnS09IcnV6TmthOEt6SFo5Qnk5ZnByS2dTZnIxbU9uZmxGd2RIdGgwZUts?=
 =?utf-8?B?RUVPSFMwdnMzTVpscStHUFU1Mlp4V05Bajh5TlBmZjR3UHF1c1d4b1ljZE1i?=
 =?utf-8?B?NjBpNnhzaVdEWnFQSnh2Rmxnbzc5Z2xYaCtYZDZCdDdFYnpOOEZIMlRTSEJq?=
 =?utf-8?B?UzZOSzFXekZ3TnVOa1Y1QzJWTXdJbXBIYlE3N0NET3liSXNDUkhrcUprcSts?=
 =?utf-8?B?czZnSW5JdG5tZDFzM3hXaHNwU0dYVTVZZ1UxMVVDaUt2VHNEbUdCaGFsc0U0?=
 =?utf-8?B?OEFMNy82emx2UTV1WTByTnhRZUt3TWZaazZjOEgxMTF4VDNWK0ozUlFIdnVs?=
 =?utf-8?B?SGVqWmhqQ1NuSjAzUmJTYTdhVjFYaTBhWUltM3pISUNEUE95SkVPZEVnTVhq?=
 =?utf-8?B?RjV6K3B4WHoxaHlaa3puYTMvSlpmWFV2aUxaUmJrZkpNaW96WnV5RGM3TXB5?=
 =?utf-8?B?c3pYSVd6MXNWc1V6Ulk1VDlZdytYSWVBaHRQanhDK093M3U5TW5kOUV1MWh6?=
 =?utf-8?B?TjlNdzVDQlliU3RZWGo3MWVsd0NjSU5vWWd0RldEbHU1VkJtN2g5SXJ1WWFY?=
 =?utf-8?B?M05VbERDRVNrNHluNUphQTJnNjVUQnZpSjlGcnNuclZ6S05UU05xT21xSUFO?=
 =?utf-8?B?K0R5M0ZQd1YyMWNFZ1NCcVJGSk9rYUw1ejdqNUhsb29malk3Y2djQTJpZjdP?=
 =?utf-8?B?ZjdzSkxTenRkUERNS3RJbkh0SC9Pb011K1k2MkNRTE1pR09qbldURFBKWExQ?=
 =?utf-8?B?NEZ4dGozanN1UDhVVVBJSFNrVGUrY3RIcU02QzFyNkliTDhZenBYbHVlYlpV?=
 =?utf-8?B?dWpHSUVSQSt2bC9uaFNGcWg1ZkZRSVlhOEw0bTMxcVZhamV2T01RRXkzaFBs?=
 =?utf-8?B?VFA1WUlNR2JOWTBNeUkrbW5tamFTNmFFMjZrdlVQendjTG9mQ2ZOK0lFeUFG?=
 =?utf-8?B?SDBiem5kTVVMeHdMNmdiNy9EVVdtbHdrK215QktTRUxtYWNjWjZUV2luWEdF?=
 =?utf-8?B?YVlQNXgwMGJoNktBOXpDVEswU1p3K0E5RW0xSVVLZjAvYm5tUzMrNzM3R2dX?=
 =?utf-8?B?em40cDNvWkRIRXlqb2d4R1V0OWhDM2xpc2lhdXY2VkdvTmp1Wk1FdFI3RkVE?=
 =?utf-8?B?OEVlSVQrdTFTcDlwUUxNUU9ob1BIcUFKQWxsUEpKeFVzQVFBL3RRa2xadXV6?=
 =?utf-8?B?QndBNHBGS2ZmL2pySmk5bHpwczZLUnZ6L1NHc2xTWklFRGlDV3AzMjdEUGIx?=
 =?utf-8?B?dTI5clVqbmpmb3RHZ3RkVWprTWZhN2FHK0U2YlEra0F4TW5LaVBKaFFIOU5q?=
 =?utf-8?B?MkpFWXBYdSsvWWNyY1o5a0FSd0g4NWZlbEhLUDdFWVoxcmR5aExjUEdIVDky?=
 =?utf-8?B?MSsvbXNybkNTdkF2N1ZWZGRQd0JGbUVPNUR5ajZ1Y29nSU42eWF3TDJrVDJp?=
 =?utf-8?B?RXhURTZQRUVrUUdGYzNpZGVkdWFScnlBc21TQjdCYjAvRDc3SGpjNkVRL3Fl?=
 =?utf-8?B?Y0krT28xRjlFTmJvd294TEJrKzNLNVpHUnlOWWRRVXNEV0EvTS9KZzlzRkJQ?=
 =?utf-8?Q?moEEXQqGszT/mYILFbmndGY=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6c8fb85-0ee5-4670-dfeb-08d9c4895203
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 13:53:51.6144
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YjM7JRXFdx7P5AnnSIy9ahJtEBt4Ef2XCQpdsWcCRWsXLRM8sWhoqBlks2fQ7TsLzRCnboZS9r/qUmbC66anEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3118

On 25.11.2021 14:39, Anthony PERARD wrote:
> Rather than preparing the efi source file, we will make the symbolic
> link as needed from the build location.
> 
> The `ln` command is run every time to allow to update the link in case
> the source tree change location.

Btw, since symlinks aren't being liked, would there be a way to make
things work using vpath?

> This patch also introduce "efi_common.mk" which allow to reuse the
> common make instructions without having to duplicate them into each
> arch.
> 
> And now that we have a list of common source file, we can start to
> remove the links to the source files on clean.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> 
> Notes:
>     v8:
>     - use symbolic link instead of making a copy of the source
>     - introduce efi_common.mk
>     - remove links to source file on clean
>     - use -iquote for "efi.h" headers in common/efi
> 
>  xen/Makefile                 |  5 -----
>  xen/arch/arm/efi/Makefile    |  4 ++--
>  xen/arch/x86/Makefile        |  1 +
>  xen/arch/x86/efi/Makefile    |  5 +----
>  xen/common/efi/efi_common.mk | 12 ++++++++++++

Could I talk you into avoiding _ when - is suitable, which is the case not
only for (non-exported) make variables, but also file names?

> --- a/xen/arch/arm/efi/Makefile
> +++ b/xen/arch/arm/efi/Makefile
> @@ -1,4 +1,4 @@
> -CFLAGS-y += -fshort-wchar
> +include $(srctree)/common/efi/efi_common.mk
>  
> -obj-y += boot.init.o pe.init.o ebmalloc.o runtime.o
> +obj-y += $(EFIOBJ-y)
>  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
> index e8151bf4b111..eabd8d3919a4 100644
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -79,6 +79,7 @@ endif
>  
>  # Allows "clean" to descend into boot/
>  subdir- += boot
> +subdir- += efi

This renders the comment stale - please generalize it.

Also, any reason a similar adjustment isn't needed for Arm? Perhaps
this could even move into xen/Makefile:

subdir- += $(wildcard efi/)

> --- /dev/null
> +++ b/xen/common/efi/efi_common.mk
> @@ -0,0 +1,12 @@
> +EFIOBJ-y := boot.init.o pe.init.o ebmalloc.o runtime.o
> +EFIOBJ-$(CONFIG_COMPAT) += compat.o
> +
> +CFLAGS-y += -fshort-wchar
> +CFLAGS-y += -iquote $(srctree)/common/efi
> +
> +$(obj)/%.c: $(abs_srctree)/common/efi/%.c FORCE
> +	$(Q)ln -nfs $< $@

Like was the case before, I think it would be better if the links were
relative ones, at least when srctree == objtree (but ideally always).

> +clean-files += $(patsubst %.o,%.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-))

Nit: Please be consistent (at least within a single line) about blanks
following commas.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 13:55:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 13:55:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250439.431350 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfcM-0008Co-0w; Tue, 21 Dec 2021 13:55:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250439.431350; Tue, 21 Dec 2021 13:55:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfcL-0008Ch-UA; Tue, 21 Dec 2021 13:55:49 +0000
Received: by outflank-mailman (input) for mailman id 250439;
 Tue, 21 Dec 2021 13:55:49 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfcL-0008CZ-6h
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 13:55:49 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b32f743f-6265-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 14:55:48 +0100 (CET)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-14-ZWpJHu5pNVaskHTUbwitXg-1; Tue, 21 Dec 2021 14:55:46 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Tue, 21 Dec
 2021 13:55:44 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 13:55:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b32f743f-6265-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640094947;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=X1RWhUs2+DHPluwwz1yl1iTiqXUhji8RpvoJAWT0rVw=;
	b=T2+h39WyEp9Lhw8mkbk3Yv6lumGaHUx8vr12ULFZckHGKFp7MumZZu+VzktLPyPViUhWUF
	hpXVElQ/yPyiNPV0GLm/F9+fy24PNACFFTnzQvh2qMNIYwOMgQxk0l/lJaiA7/uNKs9wN8
	4JJtLj8Ty83k4pBuqQnCPusl0U7LMaE=
X-MC-Unique: ZWpJHu5pNVaskHTUbwitXg-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dq9OPfWKMAwua33tYtuEOZJ2e0ndZQ6PdiG44xElvqBLcKhQIrI/DTK5xIjrD1RTJBu1BkgGMr3jeT6V4BDs93RoY9BLIaOxScL5s7ffxIIyJeTDGMQa3KwGTYVS5nfMAY84eiik4IcFXvnP8+mNScriHcop7q0hjhWpu318rMotfWmU8wVh61ic/StoZdlSnZ28o1PcNKDTxa2LyglW77kFm88XA1t3VGD3rjnzd+5b9NfGjxeqxYXLPcIMcr/Lbb27sT1ypbZyfPSpbLhTHhNMfmx2ROacHrKFL/tlejJeFp8TReQDEJvsInZ6OF4NoIE3ZOFquP9th5SbUbjVxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=X1RWhUs2+DHPluwwz1yl1iTiqXUhji8RpvoJAWT0rVw=;
 b=gp8xXcF+U+gb3R15U3py6aI+Kww1Pt8LFRm34nEv7Mu2Z47jlahQnENFFxnbSypefDpTuFgpaOmZz7NqjLCVjcipYNlYlXVXChLFYGqDfIUlX4OowZlcKJg34aXmvE1n1WgD5R5aObV4B7NRN9/I2573Crt48BfYA+xg5PWivp8NHmLRbn0h6DEYNDuZS+sdileagRniZtHFhd5DM6PZUl2dxZR5dfJyycno2Y86Djs4odMPEdBO4dWxXehHhCt6tlEVMmGNIgo8f2bMl+9njqqWBNFdeO6bbgNkePgcI5rYKB2rk5UIq7TvUadrkJSUGp+JDBRi/ZAmoM/Lh35G2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <9147d893-2335-a8b6-af65-6a169849e20a@suse.com>
Date: Tue, 21 Dec 2021 14:55:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 28/47] build: replace $(BASEDIR) by $(objtree)
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-29-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-29-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0092.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:8f::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e818e64f-dc7b-49d4-0dfa-08d9c489951d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB5165A83519361C7F86B8718AB37C9@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2331;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	uIZhZOt64ncbhWiXa/0FCF8RzW6flrX3uU786XmNzrCel3l0RxHwp2s0W44SFbMzKYqeaCE2WieW4qshPP8nGKZJmUcVRnVAClZka4oPdcuJgZw1xrAEPXYLujLN+8unXoXmlasvH38N5wOK0I7xFy0jkpbJS4Mvf13UQEd/c4vEA9H3F68f8VW5zi/eX+CeGBFCW6uw641/WxEKCBuf9bopoL+a1r1ok83oudILEKqzex+HoVMfl63Q3wYDj9MzmiLzkyFhELbsJCwuZMZZH/+LB2zs1ZOsPdJ8K3W/WZB6X92kCfe2GYDM1VZw6Omkorwm0dtmgmnF/4UwxepZ5k9S9g2Cb/xMhiaeXN7LTADez2lRfWSPrx7fpMqVbvVQOA5rDp8+WD3M4TQmipwx3+a7xn12i682nZmegVC1YQqJ6iKXhUP4xdqvYusWeJeUS+Pq+7B59386jxcqg3fsZYpyTK478/unLGbVjSCOqYM7XETXvs0vH+B2EzaQahtWhtzifhuvqSJHxGbZ3oHgEmCpBC97+VrwImtD+8eyf/uGy6IlPv554WPGtTNA0mFIE7kGW5xQIww3H/kfU7PfWsmVig/OJvrZ45HdU3tY9ZzIW1vMhB8HUHUJav7IU2Fd8UynL9Bi32YDJ8vplXoBClJ9nmiiwXXUuR//ZQA0wjHMcyFzsLaGAxwZlEBxdF8cGcLbNsoTYNG5dpwZuO3Z/SFsn19bg0CjumZr/Ym5RPM=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(558084003)(186003)(31686004)(6486002)(8676002)(31696002)(54906003)(4326008)(2616005)(8936002)(2906002)(7416002)(86362001)(26005)(6506007)(38100700002)(53546011)(66556008)(5660300002)(6916009)(316002)(66476007)(508600001)(6512007)(66946007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cHhmbE80V3lzS0lwZ2toYXJtbUMzeTYzMnpGQUF2bFRFUC9rcC9jekZRYzN5?=
 =?utf-8?B?b054S0xlUnVrbHREYklmVkxaRlhlVUxKYytkNW05bitWSlRUNCsvS3NuVTVz?=
 =?utf-8?B?c1dRT2l0bm5GNUlyYkRaYkRrcExSUUZBWGFiVUE3V1A1ejA1elN0cnIrRlFV?=
 =?utf-8?B?R2FwcnV0KzIwQlB1cEN1U01RSXJaYWplbUZ5ZmZwYk9BNzNIZi9vSjRUZ281?=
 =?utf-8?B?ZCtLNEdja3VXdER6Tnl4Rk1PS0VWbjYzcVE3aGV0bzFoVGQwSkM2SjBxcHdq?=
 =?utf-8?B?c01GLyt0dzBoVkFzUDhOd2ZqWGNDNjZVbFFOeFRHRWwwUlVnZmd4bXRxeFBy?=
 =?utf-8?B?SXpTVXROSkI1d1ZhZFVRZTA1V25aWlF0WitFMmhTS0drbVN5Q3dHSGN6elF0?=
 =?utf-8?B?WGtlWXYwMU9VTkxrSHA4S3ZiVUtoUnYyUlk0RWNMWDI5WG5WemRWbVhYWURw?=
 =?utf-8?B?bDBhd2JNUDhTZzB2Z3NSTGgxQ3dNM2w5djkvUktuNWNNUE5NNlpIR3VieGM1?=
 =?utf-8?B?a2tDSFBpdU9lS1k3VmJCZmRVakxtVmZFbldCR0o1RVdsNDYxSWJLOUgrV243?=
 =?utf-8?B?OEd0NENLR09WdXI4UXlTbm90L2NnRGZ4c0FVV3lJSytaKzl5V1dNQjIwL21N?=
 =?utf-8?B?MWh3Yy81Y1N1cGdGQzZzcVNubmwrcEZoQmN5OGUvZ2kwaWJqdnE0a1B4RXlW?=
 =?utf-8?B?WUNMaGFiMDFEeURsOVVPRU5hVUJvamdFWnprM05sbUxmVmN2OFk5Y1BWYkxQ?=
 =?utf-8?B?cGtVWUVzSTV4WDA4Sy9hS0pqY0RHam5ocXBmMFlCVk9wYWEwUHFLekFFTU9w?=
 =?utf-8?B?MTFlMDVqN1JpTVhHZTN5b0ZsSGxYUmZyV0VkL2dOdFdzK2Z5SzNPLzhzcW82?=
 =?utf-8?B?TGJ0bEkvaDI0MFhEOTc3K1pQbUs0UkdZWkJpT1p5NWJvaUFWdFN5YWNxRjdL?=
 =?utf-8?B?bkt5MEVlQ05NeFZDc0F5U2t2aGV1WnFoaTBtWHlwdk9oQVdQd1ozcHE4NldS?=
 =?utf-8?B?RFByY3ZORDJDTnJxVEVrSlVRaE83OTA1NzV1NWNxVWpCUFM0M0NhNVpsYkxy?=
 =?utf-8?B?U3VlSWUvQnNTdHREeXRpcnR0a1loMDhoMXFLTGRDQ3oxRjlUMVBBa3kxY3Rk?=
 =?utf-8?B?OWdpb1ZzNk90NzBWdlljamh3WTcxQklCT1pZT2RxdGwrTDRqNld5Y29tWVBi?=
 =?utf-8?B?QllCV0tYNzFFbE1VSWQ2cHp1YzBQQ0s2dWMwbUFubXpjeDVIUEEzQzFUQit5?=
 =?utf-8?B?RnlJV1VGNDRvenlwS2pESTNGVWxUZ0NtZXlSVmtVSVpnNG9GN2FYS3U0VXU3?=
 =?utf-8?B?MmpScVZFaktkRmlXcDZEYXVDdGxZbys2YmFFTExlMXBJaWRsQWdJakxVUXhL?=
 =?utf-8?B?b3kycCtVTjRGc0RycTBvaGtnSWRBaVdrYW52aFY0aGVPMi9NZElWTnBIMWV6?=
 =?utf-8?B?UEJVb21ZUUs1eWtnOGtHb21oOURodFkzZHQzY0FJSHdNZ1Z3eDFtcUlwcG0r?=
 =?utf-8?B?N2d6Kzk3czNNQ3AraHRZSnRDNndVaDdrWGVlRitSdDJ3ZVM1TG1wQklKUTEy?=
 =?utf-8?B?RW1BWWxBSjhKQUxBZU1kbDNSMTNzaFM0Umh2MVgzU3BlVkdUTUFRUldsZ0cv?=
 =?utf-8?B?dmJmNzhmVHg2cXNKSHNQRGxrZDNNZUUwN241YkhrbEh0djlRbHdIdW50SDgv?=
 =?utf-8?B?aUF6Q3grTndoWnh1b1ZiSUNMVUhVMDRFMVNWOWRucTc0bWtSalVjRnRjY1kw?=
 =?utf-8?B?akZaZWp4Y2RJZUJ3NjZ3dUpveXlENEsxVEh6Qnl1VzB5cm9JR2xLL3Y0RVhl?=
 =?utf-8?B?enpsOWxPeTVidkx6bnpiL0FOblFSQUVJRTEvTXY0cnphbmEvMUl3WVZaYWtp?=
 =?utf-8?B?NUhJZGcrZFoxKzdFQkZSanV3K2JTa1UweDhYMC9QR0RJcnREdzJmQ0lpQU12?=
 =?utf-8?B?OWdIUUtsNktUNzFyR1hqZEhhQlo2QXNNMllsbjlISlQ4UENSdHVtR1ZORlEz?=
 =?utf-8?B?THJEcGgvaXI3eXlYSXQ0Nml6SklLMDhsdDNma2VPYTl6Zm0xTlpGMVFOeGhI?=
 =?utf-8?B?WTVSa20yeXE2WVkrNXBCNUdtaE9FN0lCZlZWL3FkVm5OQlFpZ08xcElRQ0Y3?=
 =?utf-8?B?RzdhUC9xVU5WWWE0aHgzK0poQWIxSnFmbmZ4OHZPYW9vaTFWWFAvZzRmYzhU?=
 =?utf-8?Q?JAwUR4NYTgiwZEa2rt8atWA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e818e64f-dc7b-49d4-0dfa-08d9c489951d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 13:55:44.1958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G8MmX2sqwDPPB682sbXafrc2qxUWs78NADnZ4jTDEvbQfZ82NqWS40hJfVIuWK/wif1BRiArsKyU/c84GKSrOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 25.11.2021 14:39, Anthony PERARD wrote:
> We need to differentiate between source files and generated/built
> files. We will be replacing $(BASEDIR) by $(objtree) for files that
> are generated.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:00:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:00:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250443.431361 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfga-0001Sn-Ml; Tue, 21 Dec 2021 14:00:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250443.431361; Tue, 21 Dec 2021 14:00:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfga-0001Sg-IX; Tue, 21 Dec 2021 14:00:12 +0000
Received: by outflank-mailman (input) for mailman id 250443;
 Tue, 21 Dec 2021 14:00:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfgZ-0001Sa-HR
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:00:11 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4f913780-6266-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 15:00:10 +0100 (CET)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-40-J3-zA4geMnSeZMQi2wk9YQ-1; Tue, 21 Dec 2021 15:00:08 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5165.eurprd04.prod.outlook.com (2603:10a6:803:54::25)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Tue, 21 Dec
 2021 14:00:06 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:00:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f913780-6266-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640095210;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=z+IQehem7mOLSAZ6/KgK8z91BqxQoaUEJU3w7hNuw44=;
	b=NgouxKRZLj31b/C00u+zxPe7X7OzCTYNfmfF5GbRELFArtb3Tl1P8Hj/O42yvW9+yC6VF0
	gGwW+otSkh4wkcuCJWNjCLPyzaFSp2X8E2xjXr2YJE1q+Zjqjpo25biYvgA9KJhPeg0dWc
	SWZ/x/HbyUCyn8zy0suSapxYZc8eM0o=
X-MC-Unique: J3-zA4geMnSeZMQi2wk9YQ-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZWTLWdt8eezFQ/mR32IoxLOywBJnn2oSY39/9misiP6aV5Wh0ve8Ndu1tusBvxqRq+ZRzqZ9nJRSvQHDQJSPMvlD0OojY7KbqDcvVhHUrgOJawLbEoywP7h72m+jGp1p6Pq20+JO34IzrmeoChFujq2pX1JDkOkw36VX74dNy+NPL12JWaePpquOCNIJxj8lBTxpDPNQzQ4XLglyFqAvMl0Kan9w/ElTV1pBDocGIJWP4dI0ht+HRxxpnenewtBCjKyJZGoRVaSkIb24d9tjM8Z2FFmL+v1v+hetmRjPgQAC9IOn9pImw5gCQSBqe+dyo4gAtmC/eeUlofrQZIfAXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z+IQehem7mOLSAZ6/KgK8z91BqxQoaUEJU3w7hNuw44=;
 b=c4wlc11uO9ECvWhZDGsGWe4CyLTsxUeV7M/vxMB9i+/DR84uh/s6aXDdua0xIWTwG03Y84d4+0LKfEkaT5b4dvy5M0rqyM4bh1g4Vh38EhJAnnT/teYc1GaEOtbWfudg/idhcRTmSZnnMVzdK+qV9pRK15/zTVwJ3unXG0bRXWSbVF88Wm1meyBBLLsHTk3Ey/xOr/txKSMQ4mqzIVriBW7B5eWDiKVvIXSIWUaKNK0ViKg0eJKOoK1Ibcdi07lESGe/GdQIgdL/eKw8QrFsf6Xs/PqWPURHl5sP8nTFwNnrSpCXMdiEInZOdEGeYvupdkM3b9H3YcS0Zvckra3zsw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <b76fde35-ce23-8256-f5e7-daa4e4a3a470@suse.com>
Date: Tue, 21 Dec 2021 15:00:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 29/47] build: replace $(BASEDIR) and use $(srctree)
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-30-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-30-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P193CA0116.EURP193.PROD.OUTLOOK.COM
 (2603:10a6:209:85::21) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2e16caa6-8cce-4595-ee10-08d9c48a3119
X-MS-TrafficTypeDiagnostic: VI1PR04MB5165:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB51651AE3275ECC785500753BB37C9@VI1PR04MB5165.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ecdEdQxLNf/ux3Z5o6mwabe+6NN2152cWLDnMj/5ZtqGkfIBEODbDd/mXqzkZnrv31fKUbGgMIfEudw69gdkjCArVyq5gqakmQN7GATKid3MHBhFEjIt5G74sPFFeTurtwe8qfMoE8M+aPM02tOSndcTZyZfs3+Ksfjr0SqsYevaWvXqeUk3DsIR2CaSGvmTGJ1uGrtkdK6zMMZ7LEfi1kbuqU8Agx5ix75IGe6iJ34+7M6lXprHLnhiqc/04OC+c9KKOdZvSmoo9J3LYF6skyJdR77vWfEN4JWgDPeaARVxubKJ1rBiXhyi9PfVNpHBUVESDi2p6h62pORFJo8+p1Zw2OXwEqGhID1Nh4hV2JA8TfJWBuJx9y+tFWy4Uqb1D+oyDW1oEmjrZFfUwBMz9bVDN2QqbvftQRNoNSXGvPUpAl595SSujBd+HFa4Idk3b6XWVflQvpDF7IDOC028jG66MkPI+ZuM0DUJfLTvAMKjFffUzFT9qEjFUY8cHIwnv4KqgDfuJfONedVBI4IKH/vUODXcIv6asl5tf8w9u98mBpnpuLtH6ndotogC2ROR6J33nA/zYstLoZI/MA3F4Y7o0WgFA37pVzgmjEr4BNalA4J2k5YM3y4mfjtYFsLECKx79M257NbhEle/1MAeOAq64SbbD3G66C+sTM3Xv4bAmWoE3HeGmSk8LfsHjNkF8fRyZjDJBpiBIDC+1QOQrPsWbks+oXpsHfwdcBAN0ms=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(31686004)(6486002)(8676002)(31696002)(54906003)(4326008)(2616005)(8936002)(2906002)(7416002)(86362001)(4744005)(26005)(6506007)(38100700002)(53546011)(66556008)(5660300002)(6916009)(316002)(66476007)(508600001)(6512007)(66946007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?azFZZmpaWFUrb0E0eFlvNU91R1J4WVU3d0lDZFVLQnBwUzh5VHFBM2lrZXRP?=
 =?utf-8?B?ajhZQmgweWJER01naGdBQ1dmRjhGS1lLNDRMbi9DeEIvd3JQcEc4bUNXeENC?=
 =?utf-8?B?QXRWTHRPUi9VaFZSajI4dW96SDNZZDQ4cVZVc3VPb3EyYTg0TVNjWFllQzJ5?=
 =?utf-8?B?Sm5RQ0lZWmd2M0xTa1Z2ekM3bXRRWDRvQktoNnM0VS94QUYzU3ZReEhPNGVD?=
 =?utf-8?B?cmhaLzFIcjNMVk9hV251MFNUL2VucnVvTWlzSWRwaEVlQkVvT0dpaUlQMDlH?=
 =?utf-8?B?YXlrMHRrbEpGOVFrOWxZaFdibjZoM29sVFJlVk9RY2w5NkJNWlZLUmQrVjJy?=
 =?utf-8?B?TEk0RjhaempuR2M2VWtJQVBhWUdMcEtxdWNTZ0dXK0djSXVCMXJpR25zaGps?=
 =?utf-8?B?WDFtSnRhUWlHT04wMk9KMGVsdE5EY0N5R1prYmxZMkdtbGNwaHVxNFFzVHJu?=
 =?utf-8?B?WWxxcWRNQ0QyWmg1VGFOSDJpZ2JIdzBvV001UFFhcmsrT3VQVUVkWHBMdHho?=
 =?utf-8?B?M2RRWUM2SDNDR0QweFIvMkVUMnlwbEg2RGRkUTNnaGdQWDFkMlJCOWJJaTNO?=
 =?utf-8?B?bDFlVC9aS0pYUFAxYjhJemFTdjFINDEzZUY2em5LNDNDL21lbU0vUk0yRXNa?=
 =?utf-8?B?T1VHcHlqdENZeXVyQUcrSUlTUmZscHpaSlRnb0liNEdLSlhIallBSjViejkv?=
 =?utf-8?B?bTVtV1B1UGcya2RHSlp2cjVCajcwcVIraTZSeDJIb0JlbFJGL0N4S210NUwy?=
 =?utf-8?B?ZlNVdWJraEdwVS9Fc0U2NnJJeWs1SUlwZlZFWHpENDR2R0NWekVralRhZ1RY?=
 =?utf-8?B?dWtPM3YzcC9ML3NSUFFHMEcrSFVjQTN2ZXBadENveG1lY2h2N051R2hGczdE?=
 =?utf-8?B?YWRRWXJsdldpNjVSZSsvb1NaeU9MNkt5aXIxNFYwRGowaThpMkZxV1RuaDQ5?=
 =?utf-8?B?a0YrbnVLanZtVTJ6RENrbVFMVks3WDFmM051Q0xlaXczNEZLZE1SWHhFTXVh?=
 =?utf-8?B?TGU2cDd1TVNtMnFVYS8rNmxhV3pvdldDRm0vN3ROcit2TGhWd3Y4aGhiSEx2?=
 =?utf-8?B?WTYzNnZaR3YySDFIVU1MTm8xRzM1OGtGa295Q3ZYRmU3Yk9pZDFIbi9zUUdi?=
 =?utf-8?B?L3N3TTllY0d6WFc1WEJsSklTajV2L3hGUW1TUnFFaVlCL2NzUlBRYWM2ejVB?=
 =?utf-8?B?VmdqOTVjWTNYMVlic3JoNkYwRlNPTGx2S2FZWFZ0eFJGNGVPTTcvWlJ3bzRS?=
 =?utf-8?B?VnltVzlHNVVHcDBrZVlERTRPajJ3cFlLLzZ2bzBCK3c2SHlEb2diM1prWHNo?=
 =?utf-8?B?a0w4TUZndVZ2c1JXUjNCUXQ4Zm9OL3Q2cnh3WHFZc3kyVFZWcGllSVB5SUlO?=
 =?utf-8?B?TUFCYm9QRk91NXI3ZEsrSFYzOEE1K1h3a3A4TndVMUg1UlBDTEQ3Q0pPUUo0?=
 =?utf-8?B?Y0hIcWNFMFVpMEtmSmxlK1BpdVRWYUJtSS9YR2Fra2tERFl3YnprMFN1QTlS?=
 =?utf-8?B?M2hsRy9QbE1YbjJ3ei9xc0k4UTQ1b1lYZlF0SkVHZjA3U0lxcnlwWTJ6VUtO?=
 =?utf-8?B?d0JINzlaMTVQTWV2UWk4NzhTVktVZjZDdk80dUJZU1hLblpaeUZ6NHAyaTBD?=
 =?utf-8?B?RDBhWHkrdm5NUVp4RnFvTUlOV0tzRlFtMEt3S0lBcWsyNVE0bmhyUDMyTWFZ?=
 =?utf-8?B?ajJ1cUZoRDlDZXJDN2tXNG9IZ0xRNjdtd2lVM2hMS0RONVdyb2VaR0s1WU9Z?=
 =?utf-8?B?L084V01aKzczUGNqbjQ3Z1BzNWRndUlMRlJtU1o0a1c0WkVPNUg3ekFIcVhn?=
 =?utf-8?B?QkxvRmFXS1JJY1BxcGFjak51SUFoVzR0WE9BOUpIRWw2Wkc1bjZ4TFQxY0cv?=
 =?utf-8?B?YVM3eXQrSDMrYzJWb3IvcVo3V3JnUUlEMjE1UkRXS01LN0I5L21iMS94cmZC?=
 =?utf-8?B?Q0t1NmRSRXlLYm1WMlNMMnYyWkNTRldZYXMrYm4zbnYwcEI5cHl2eTdyalJG?=
 =?utf-8?B?QVJaeC9uS3A3TnFGVWREZDFHVEVUS2puNFhybnNGWEtCNnpJaHpOMlFYL1dv?=
 =?utf-8?B?WXg2WjJycTNyT1loekoydHBQcGxPaXdVbDlONUt4SzRiWGMvaDhPWjRlcXdj?=
 =?utf-8?B?elUzNVdyWTB1ZzlBdkhPUFUzWXVucTZpM2dXU3JsT0xOdW9YOThJUzJ1TmhC?=
 =?utf-8?Q?pVJMDATZmTEXTFyCR5Fs6oE=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e16caa6-8cce-4595-ee10-08d9c48a3119
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:00:05.9209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 78iizw+uYfVJ3ZqDCKAajn9MYcjlALqB81y9adKUBjQMCCPmwjjQw3kvYOnDfMPW6I86TGR3PaTl7WWM35WtBQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5165

On 25.11.2021 14:39, Anthony PERARD wrote:
> $(srctree) is a better description for the source directory than
> $(BASEDIR) that has been used for both source and build directory
> (which where the same).
> 
> This adds $(srctree) to a few path where make's VPATH=$(srctree) won't
> apply. And replace $(BASEDIR) by $(srctree).
> 
> Introduce "$(srcdir)" as a shortcut for "$(srctree)/$(src)" as the
> later is used often enough.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

One remark:

> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -5,9 +5,12 @@
>  
>  src := $(obj)
>  
> +# shortcut for $(srctree)/$(src)
> +srcdir := $(srctree)/$(src)

Might it make sense to generalize the comment to "# shortcuts" right
away, in case further ones appear? There seems little reason to have
the comment duplicate what the assignment actually does.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:08:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:08:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250448.431372 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfo9-00029g-G1; Tue, 21 Dec 2021 14:08:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250448.431372; Tue, 21 Dec 2021 14:08:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfo9-00029Z-Cc; Tue, 21 Dec 2021 14:08:01 +0000
Received: by outflank-mailman (input) for mailman id 250448;
 Tue, 21 Dec 2021 14:07:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfo7-00029T-PI
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:07:59 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6696f87a-6267-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 15:07:58 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2108.outbound.protection.outlook.com [104.47.18.108]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-38-7EDqGmTRPTescJj4HDJ1Sw-1; Tue, 21 Dec 2021 15:07:56 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Tue, 21 Dec
 2021 14:07:55 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:07:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6696f87a-6267-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640095678;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=T9yovz81oOewLJrqJU3CMEpEKYH0gQj5lw1kvgio6/A=;
	b=aSiLKp51WDwX9AdempDf0WPQYwnAT57fZ7JdYg/UIBuUDMfvuJ79kj0cOIy0LVfWo/nVZb
	JdNzVjuhIc/0L3CoihT9gvLQBYzIK4FXcXOSDZZHn0bNVgQHBpAbMkXnoIFzywz/l7Trsu
	s8yuiLpl1JdHiMNidKO5O6CQkNJnun4=
X-MC-Unique: 7EDqGmTRPTescJj4HDJ1Sw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QKuiDttzhlnrckI4voup7ItZrl/XzTKDx7MjPD3l8FS2wjo+GaLQicZPcxBhZrLR6YHJN5FmmNhnZ+iN48/wqAACWW5NeQWGh894mjTxtOEizqhaySyT1H7XOr1/oYgiauNDUUOuLMiJKK8IkDJRcp1RkZ2Rk4GrgmVgeb5EgGiiE4SFpH5SQLHvBP6eb+97L0baUNGjn/V8Z0u9y2M3l/aa+iAsH1v5Vd0Vj6o6uZHlruROUMkd7+CbxPrJIyojPIuqSY/ZOYPhrO67YfFnL9yxmMy/JPuC1KBXWiLDtYolYeYozEkzrKMlRTPCxG70lJP8OukEL60y6UMyerG50w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=T9yovz81oOewLJrqJU3CMEpEKYH0gQj5lw1kvgio6/A=;
 b=Tqcekgupdmw4zFHv56lKJvp49DkAQxsWpVmk3K2SjIBqMv2uOdb1J7t6nw5YC/Llkfm2YUhP+fcqku5qwrvqyTQ/XeTpIRE/sSuz5EHFbBlYbk2UNfTKlWk2lj7n4uHAyTaS2IunNME34i5hSJk3FvOrVSnyI3Qh/wk+J4WbGVcoPmjO/g/8+upeSmlHdhxUHl+gNGyayaEBDpr1QyPt5kRQmXYJ9e/mxkyRfLV00sLn2vqH+yZbjaUkA3rCtX4bCxh+ZZE93UZOKRf2xWdHWK1M+YWdmNahslmXn00+QY2TD1/IpOuIagrCH0XCJSibjz8aQTSNtuZ/HSb/Y/+6SQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dcd485e8-3c46-460c-7d0e-13f50aebbf87@suse.com>
Date: Tue, 21 Dec 2021 15:07:52 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 30/47] build: rework "headers*.chk" prerequisite in
 include/
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-31-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-31-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P192CA0081.EURP192.PROD.OUTLOOK.COM
 (2603:10a6:209:8d::22) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 6b792a71-7a85-4fca-e4b2-08d9c48b4890
X-MS-TrafficTypeDiagnostic: VI1PR04MB4189:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB41899A4B6DA7FEA7B1CE3AE2B37C9@VI1PR04MB4189.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	QIn9fjDKPsB+1lh2tsEr67z12fLidA35AuhyYfVZP7QbncIYJ3tmYXCS/lhGtX4dNPxkbLSThob053TsBqE88VKuFvs93kErohQPtUGtDdQv2+EqZjS/B9xQnQDPVynuaDoiK2kxp+RrwtzOflHoSYwgnokWFS3COe/IFKD1SeR7Tq2Ny9sQpemc/w69JoUJie1udxHpEO/FIv9f0V0gCwjT7rHsOhl8wIgEr4nZu56idnzUqzC2ZU7dIGR+fpLB+pkBcZIeoITbNRHkWPyuCwC9uhCouhEBwtt5ysepA3cutfPFCaTuYGkaxxdIGF1I/zRIqKL26YlmTTxn65Vp5GFroHwxAT6jPebHrqLgQpyvnVmTiuH1CUq1d2uC3A0KWeuUgvCZfVOZKFZ1tBpqp4e7ZLy/0EgdNfDJskMjswc+pNgX/PbVp9LRl582nXZzP7q+sVWoC2jcqUjORDXPOSe7GDH2OsqLsGi3u5RnUjueUQ28k1OdV0Jgy4hSY6JByzl0CdCGCz23ATC8ZLlp+JjLHO5FJZE0w4grw0CUz9qcTq9P8AVoOU028mgtrpO0EWkkgVvvvMUkHiMEDnr5Pdh4+L1APupWW35ULrJAD9s5dwGrDDzgMCaIir1ipFmhBlGqa/zTYoYqUM+EB9ROJz4I0Z2AGCHsvdXC+U3U/nJZswSD//o8PKqOplt14hRvoVoVlSUxHAy5XQmyRD4jxKNz0eACrzYuyTXcb3IV30WOiFnDOI9ayOYMCPXFLK6z
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6512007)(66946007)(66476007)(2906002)(508600001)(66556008)(6486002)(31696002)(6506007)(38100700002)(5660300002)(2616005)(53546011)(86362001)(26005)(8936002)(8676002)(36756003)(31686004)(4326008)(186003)(6916009)(54906003)(316002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2ZmL08weTFlNzlLcmVWcjBTeXUyZzFYaWFwWEw0T25wa3c2NDFrWEVvZFZy?=
 =?utf-8?B?YzVrQWhINFFFeTZGd2svQk5IR043UFo2ZDRUUmprTnVLYWJ0SDlvMjJYbVJj?=
 =?utf-8?B?UWRtRytyK2MvQ2I3TVBkUzdtdktSZXVyQ0xFamtMZnhNNlprd1BWeDdGbVFu?=
 =?utf-8?B?QnJNNlQ2dGl1WXVJeG1BRDlaa2pBRXNHNHVleno2ZWRwTjVwM25FbllpV2xX?=
 =?utf-8?B?WVMwbGR3eXNhellCZFMxYlZFZ05lM1BPNVZhQjNvMEQzNWdYV1pZR3pOK2Rz?=
 =?utf-8?B?WWdYeUhlb2xVU09YbGRlUTNKclNuUm1Yb3lHT25TbTBsd2k1eHJLNm5tSWJV?=
 =?utf-8?B?cTRRUEhwR1l1S1dWL2VZb2d0blQzRXdXMXhEeEQ5RlZIb0VaUFBWQmVVWEdN?=
 =?utf-8?B?OVpYR1gxSHdJeVZWdmRHT3Q2VXlsMDdyTE9teXU5TWdYUkRUK2JhVUlabUVh?=
 =?utf-8?B?QmcyRnlsclc4cGNseWEzWkl4OEpPT1E3S0VZR2dFbCtPLzlScXkzZEVhY3Zm?=
 =?utf-8?B?RDdJMU1jWUd4ZWVjMldwQ094RVV6U1VQUlJ6YWFEQncvZWo0N1NtS2pzSWJz?=
 =?utf-8?B?Y29oT1g3UktLTVlXMXRwQnpKUDA5R29vNVlMVytYUWd3NnBVSC9CSUNoVGxF?=
 =?utf-8?B?QkpXblg5RDZUTVNDZWxvS0xTU0s1dHdNanlWdHV5Nm0yK0lqUzBFMFBkYm4z?=
 =?utf-8?B?ZFp0Q2hKcDluRzVyK3FiaEhhY3JISk1KN3dVRnZvamRHMHd6YnQyK3ZPblls?=
 =?utf-8?B?V0JTVVMreUZ2LzNuRWRjOW1aYkFFMXZBQ0h5RDdwbmVGWnRpN0JPYVU4WkFC?=
 =?utf-8?B?VzVZNStNVjgwNStOdnpRb0RHc0N5VDFMRzk0QnJXTlg4dDltdVNYZHlzNEYx?=
 =?utf-8?B?Ykpkbi9DRVE2aEY3bFQ0bHVSTTJpVFAvLzBMZFVXbjIyd1ZyblFPNGRwbFRM?=
 =?utf-8?B?Z1diYmRZMEdPakhsZUtYbUJTa3QxSEt3NlVXT01vaFUrU2VHclR6RmlhQWlu?=
 =?utf-8?B?K2R2Z2lzNThOdVdBdzh5bXkzVW00NEUvdjdZbGRFcXBrNDBQS1M0QlJOdEpw?=
 =?utf-8?B?WFAra0RqQURWWndGQ2FLSENPdk51THlZYzlsRENjbUlZYXp2dTgxMFZBQjJx?=
 =?utf-8?B?UVE1ellnN3Y2Z29paGJtZGJ5aTJVR2NRMSt6ZTYvRWRCMFl0L1J3N1hiZkl5?=
 =?utf-8?B?TVJNTTdSRVEzaXp2dVNHZmtQazZsSk1YZ3lRcFppZEt1a0ZQSCtid2o3d0NT?=
 =?utf-8?B?eFhucWJvaXJtbmtobEFPbXVzK2ZNRWlBNzhuOTEzYkJWV2NObGZwTlBGQ1JJ?=
 =?utf-8?B?cEFHSHJVbmRQcUhSRjdxbFZrcnA3NE9UVHBxRnVMZnpRcmlwdHo5eHd5aUZW?=
 =?utf-8?B?OUhiS00wZE55b2FoY0dQWHhqYXlscUhRY1BkQ2RqenFSTDhFRk1nQ2FKNmRl?=
 =?utf-8?B?dytiSHJUNzdrL3Jna1NtQVQ2eGxwZkovZkFyd1dMU2syTVZDekpBZUc4UjJ1?=
 =?utf-8?B?Kzc4Y09zVDRmcnBzVGwwVCswMlhmZ2hsL2xHY2xiYXpoR0hOREdyb200UFYz?=
 =?utf-8?B?ajBEbUNPTWZNbjh6VGFlZUE1MzE3V1prMTlKc3MvL0h2Q2Q1VlV6NUc4SnpQ?=
 =?utf-8?B?VlM2OG42REpSc0FaSmdSU1orUDlYbXNSa0VaRitkNktjZ0MxOXErMFFuQWRs?=
 =?utf-8?B?RFhTdStDc1ZSOU1HL0QrRjV0bFlkQ2FiNGttOUNuQkpQOG8vci9NNDhISHlv?=
 =?utf-8?B?TmxZYVJqbDRnZzdoQ3hTMk9sK3VtTGx0d3NFdzlsSURleE1McmZiZURBTnZt?=
 =?utf-8?B?UlpaZHpiK3c5bXc5bnF5QS9DbEtkcFVYVFc0TStUK2VlNFQxWTJTYTVMS252?=
 =?utf-8?B?L0xLazlQQnlheVJ5UFJtNGdMVm95QkgxQkd4QjRjbmtzSGlRQzFicmJDUVd6?=
 =?utf-8?B?WFloZ3hIMTdNZ2dHM2gxckhzYWxKSjFWKzE2cXZ3cDFHYngrd0pGSDBOUHc1?=
 =?utf-8?B?bTNqaUxJTklMUVVRblFvYWRpL3NoZ201TThodGtCdmtXQkRGUmlUQnVkYVBw?=
 =?utf-8?B?YVR6YVRZYU0rdUhxY3hYdlhhaVIwQ2JqL0xLZHRXTzJkemZjZVZjSmRLdnFR?=
 =?utf-8?B?Qkh3N0s3VFREd05zaTE0eVVPUDNHTFErRkFGeXdRM2pUYklYTk1WYTJGTWhF?=
 =?utf-8?Q?61FsoStTkg0b3qUk9fQp6DM=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b792a71-7a85-4fca-e4b2-08d9c48b4890
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:07:54.8628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C9GP5TwOKE4WcXOizAIrAUhbfeqvcC2QK7p6bF7wTXSv+HiV/gH+nZwubP1bc08ms612+dHWTaXRIbbyirA8sQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189

On 25.11.2021 14:39, Anthony PERARD wrote:
> @@ -81,10 +81,21 @@ ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH))
>  
>  all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk
>  
> -PUBLIC_HEADERS := $(filter-out $(src)/public/arch-% $(src)/public/dom0_ops.h, $(wildcard $(src)/public/*.h $(src)/public/*/*.h) $(public-y))
> +public-hdrs-path := $(srcdir)/public
>  
> -PUBLIC_C99_HEADERS := $(src)/public/io/9pfs.h $(src)/public/io/pvcalls.h
> -PUBLIC_ANSI_HEADERS := $(filter-out $(src)/public/%ctl.h $(src)/public/xsm/% $(src)/public/%hvm/save.h $(PUBLIC_C99_HEADERS), $(PUBLIC_HEADERS))
> +public-list-headers = $(wildcard $1/*.h $1/*/*.h)
> +public-filter-headers = $(filter-out $(addprefix $(public-hdrs-path)/,$($1-filter)), $($1))
> +
> +public-c99-headers := io/9pfs.h io/pvcalls.h
> +public-headers := $(call public-list-headers,$(public-hdrs-path)) $(public-y)
> +public-ansi-headers := $(public-headers)

Personally I find it odd for public-c99-headers to be first in this group.
Further down, in the upper-case counterparts, you have it at the end (still
in context below).

> +public-headers-filter := dom0_ops.h arch-%

What is the criteria to be listed here vs ...

> +public-ansi-headers-filter := %ctl.h xsm/% %hvm/save.h $(public-headers-filter) $(public-c99-headers)

... outside of that macro's expansion here? There's no other use of the
macro that I can spot, so its presence is puzzling me.

> +
> +PUBLIC_HEADERS := $(call public-filter-headers,public-headers)
> +PUBLIC_ANSI_HEADERS := $(call public-filter-headers,public-ansi-headers)
> +PUBLIC_C99_HEADERS := $(addprefix $(public-hdrs-path)/, $(public-c99-headers))

While benign right now, wouldn't it be more consistent if
public-filter-headers was also applied in this last case? Or is
there a reason not to?

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:16:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:16:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250453.431383 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfwP-0003iH-Dn; Tue, 21 Dec 2021 14:16:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250453.431383; Tue, 21 Dec 2021 14:16:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfwP-0003i9-8C; Tue, 21 Dec 2021 14:16:33 +0000
Received: by outflank-mailman (input) for mailman id 250453;
 Tue, 21 Dec 2021 14:16:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfwN-0003i0-Ra
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:16:31 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 97d99131-6268-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 15:16:30 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-NHqUIrD3O6iAGq4k9tCf5w-1; Tue, 21 Dec 2021 15:16:29 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 21 Dec
 2021 14:16:27 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:16:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 97d99131-6268-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640096190;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=GkaCEXNhsQM+1BxFqscUz+K4mN1vCuV44dD608ybx2o=;
	b=IWFUMxzuwA+IluFBcf2vW8HoO3KYwlTCq1mF8nXDxx4qY+515L5Pc8bc/znhFfjnJaQbIQ
	mZ8hE60GggRr/HtsC5hT87eM6Am47Rk5VTr/yu/RhU8CsydKlS9sMjE4AkzMvpmOCKqL/T
	wyUO9cHlxJiudrA6HINhDt6C4AeJMIA=
X-MC-Unique: NHqUIrD3O6iAGq4k9tCf5w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=MFyHjNlHC3AXLwXJTOlDZj0XbxS8K1ytfiHHZ/ZQUDqn3lbS4w9vo9p4PYk1rYh+FZtss0dyZ/pnZr9QMEDO1HExPen/s49Cq3d/BRr5K9Ff5c4kj37sC1FI/lIRphJI5oeGVi51GdJMXc1dAY2dvRAmeb0958LK5CX5Acv+wXzmeFVHXQSz/er0CG+gf01vVVK01abC5TZiY99u5AHXytDn2RfWoKNwQtT/Imb/S5O3cJ6lDY+06NAQSSistmW2JO28GvO8vLqgwcnD5FO5NEfj0f8DWjBweoShgDOAP6/ndSHy6x6rLx8406ANf40yiW0X4G35ZbiI790XyB5L0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=GkaCEXNhsQM+1BxFqscUz+K4mN1vCuV44dD608ybx2o=;
 b=WDMY5/MRBZbHZ4HomfOTZryZtEiUXLAX8UB20S9Z8l7eKtutzQaRzjuEJuWMkljsaotQFHI2N9FsjzM81Vy5fC+D8rigZx7u7CWti+it57+0lznZPNF6Zz9Sus+ghRhv76JXu0W25Fmttz2V3NFP/yGQIgoBzN5Fq4K/25MypsJt1bRXMa9MCAuYhwFuZGxXqezHC/iy6ac6hZ2RKOfFeml9zVbPqvslUB3ZzN9wz5IkdCmU0d0JVDA1sBZhMAxucQSi+uy+wqSfSQYVs0ch7JjHfgfW/OazAtA3WjGFrvIj6h2ewvFQ9S/tlisxOawYYLF2i+XK6M+1rOrd0Nmabw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <a8045db2-a647-fc5b-0c98-890edce10dc8@suse.com>
Date: Tue, 21 Dec 2021 15:16:25 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 31/47] build: specify source tree in include/ for
 prerequisite
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-32-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-32-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P194CA0032.EURP194.PROD.OUTLOOK.COM
 (2603:10a6:209:90::45) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 22d7f527-b573-445d-d1ff-08d9c48c7a0e
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0402MB3533F841AFAF265DC8865D15B37C9@VI1PR0402MB3533.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5sJw6zHPEFuKQY9Z7aq9T/cLX9R7M1G+2p7BLFBY6HZO9SsHqVgpNWshBJUZy13cTvBm0EtJgqyyPSJqw+JHgR19R4H4qu1Q3EgfLy51aduoFJEcGiSBPaYw6n9UsJhIBTO/+4crIvJPkxC92TPmqXeJjQghjzYq6mELaD6qsMvcntnFf6S7aOzgv4GuHQYT1CUISDbXsKVKLTX3LOZbWkQ7v8WyS+GLadQiHps57joqu9daLz0bxihXS22LbUl5kL9s8Eo5t+Qphhdb/rRaNdPMh4RZoP1AgdfA9TfilYSKorkrOT0aq9gToJcuFyl5OYfbT9jqyOPYQihl1JGEUnr43v2oC9tcpcnm5mSztmZBkVOKVu2zD5lw8mOHefKMfsXYgjyguUFjLMtdjijtzcLUAELhsTY8s6Fm88gk5IurW/F9feg0pVbug3/NMZ0Zl8V6lJw5PgpNxIt10FpI1dKbA9Kc6JxpRNZpxplBqj1woqRsOe5jNXamukAGs87SmjYI0nxTqjegiTNnjdKCk9xO37hiMRGVYjLwAnPY+V6vO+9k4cbRuoqQdncS/sCIwN1wHlOio7WVcaxO6pGpVGvCIgynwN7fEjbqu3hCAb0Q4H6MEhtEPGtIzba4+bb54tdtvzjUcLpXui1k7ekAlQ5izlMYM7DYz4VMSHtCpie46ZsLc4LAJOJWgj5kyvVihkZptLTtqbgzR+itcqrDCWu4w0rA+EDybbjyjTDTedxO/DY+5j7AVE3PWo7mKa7D
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66556008)(66476007)(6486002)(8676002)(4744005)(31686004)(38100700002)(6512007)(4326008)(8936002)(186003)(6506007)(54906003)(53546011)(2616005)(31696002)(6916009)(316002)(26005)(5660300002)(36756003)(86362001)(2906002)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RkxpelhWNmRVdWpxeVUxMGw4RWV4Vmd3WDNkdENVMkp4a2w1di8xOVR3Z1k5?=
 =?utf-8?B?aysxS1VMQUNGL25RVm4zODFYTlNHYlpxdWJRbUFQYkFmeDBDa3VEdlNVN0ZY?=
 =?utf-8?B?NWtleTFJdFVtSDBIRlo2byt0azBqNnpNR1FuTjRXc1lEdWFzYWZvSlVMSWJn?=
 =?utf-8?B?OXRyWjAwL2ozME5MQ1oxVG52bnJFZ2JlTW91Y0o0V0d6eHJGZ2hZczhqOU13?=
 =?utf-8?B?SVpCMDJ4ek0wZ2VJSVF2all3cHZnVlQ5ZnVHQXEycjZqbTU4UmlXeDNkOTFY?=
 =?utf-8?B?N2hpTk9vUWM4QitqTmVSQTVHMGFENTB5ZXhyZUZScGJpVjUvM2VuZVFmbzhu?=
 =?utf-8?B?U2xmZkVCQnVBWG5HS25KbUg3dkZOa2k1RFRrRzJFSmJZRVpEYlpnT2pUVjY2?=
 =?utf-8?B?UzdWTTRWQ3ZaMERzTUc4OXFFbS9mQ3FDTTlzOHl3REJVRkgxQm9NckpkQjFh?=
 =?utf-8?B?Wkx5aTVpb0MwcUlPSmN6R0RiVXV6cW9hc0huczhneFVwS0QrcUpnTTV2ZnVl?=
 =?utf-8?B?UlhZUnh5SkVPOHEwRXEvanUrVE5OdXdlN09rNHY2T1F1d0Z1cFJMTVFHRHds?=
 =?utf-8?B?aE5VY2QxL3lvUEgrUjMxLzVtS0t5QkhobVRzMUluUXVwbkoya0RSdzlJbURp?=
 =?utf-8?B?WkxWblJGb1B4K2NEUVZoUW9ySGdsblNlVDMyS0EwZkcvKzdkR1l6ZGJrdGt6?=
 =?utf-8?B?cStxa1RlYzV1dWZjak8zdWdydUZxd2VxSnFqWGN6NUlkSjMwQ3dmS2J6UWhT?=
 =?utf-8?B?MmJ1ZWZFZ0doSFU1Mm5KVHEzOFMyWHgzcFR1VE03L2ZCSmZlSEZoYjRrT20z?=
 =?utf-8?B?Ui9ISitqc3hrS0c3S3dSaEtSVmovakZoMVphcjZxL2cxK2Npdnk2UUtLa2c2?=
 =?utf-8?B?YnQveHVKUnYwZUY4REw5RlpQbTZFS2xPYmZUT042M1hOOEU2c2hYcytZQnlw?=
 =?utf-8?B?WnJQYkswaXVVbDFwMko0bzg4WUs1YzZTcHNzN2JVK1VhcndkSzluWWdmKzh2?=
 =?utf-8?B?c3ZqbFFNY2JIbUwrUlJkckdwQmNJclVJNzk0V2JVVExuOUJDclhiL2hrMTIy?=
 =?utf-8?B?RkI4ZDhnbTNxNVljdzRCMkJ1S1ZFNkcxWlIzbUNNdEZCSllPdnZaaUMxUm1k?=
 =?utf-8?B?VXRqOHFISlpnQ21BRGJsY0IxYkhIWno1SXZXY2pXdTVVWjZlZUVCZGFsV1FU?=
 =?utf-8?B?K24vclVZbHBHOHpsUURjellBWVkxc2wvMFU5b2dZN1U4Ulo3V2o3THIrSEJ1?=
 =?utf-8?B?azZ4eS9xU2psZE82aGp5RFArb25aZzVrOEIvcDFpY0Y1VHRGQlZ0MTF5N2xq?=
 =?utf-8?B?UlJKU0VlTmF0bXJrdlIyL2w4bnVjNm93dHV5aGVBenZCN3RWQ29jYmRFVEpD?=
 =?utf-8?B?aFlqRWRrWUpuUFdac3MzQnZ0cWJyVTdYRkJXa0FJOWwrZWt3RVhQV2pITDV4?=
 =?utf-8?B?dkdiQlFyZ2tXeUNtd05UazhBMzBNSi9VRXpjK1Q4bUVma2V4cEVRSVgxblE5?=
 =?utf-8?B?bXJrQVBPQ2p6QWZQQjllYmpweHpXZE1FcTJWeEI0VXluWmZoWGZrK2hHZHFJ?=
 =?utf-8?B?Q3cvd0ZUMXl5YjBDdE0yNEVnRmZISzdoZVNJVjdjMkV4Yk52NUhtZ0F0TjdM?=
 =?utf-8?B?cDJpZ25mbVVHRVUraU16NUFXWU9IMkFidnFTNE4xelRzTUJCeWxHTWRzMjdt?=
 =?utf-8?B?c3hZalB3R1FwcmFKOHRyVmhsUGJwTjRqN29JYm44TlJjY2lVV0FJKzZmQmR0?=
 =?utf-8?B?OFoxZHpkL1plNXF3Z3BXVXRsVlBhTkxGbTJESmVUL3oyQ3Vlc05sVGRDUmRk?=
 =?utf-8?B?ckNiWnFDUEJWTkh3NzNKTjR3MVFYK3RKMHBXeko5Tnh3OXBVVWdzMENBT0FG?=
 =?utf-8?B?ZlRHcndkZUdtakZuV2dUTEVVUytxYW9IZGQvVWFsVzY5R0g5Q3dwYTliOXNr?=
 =?utf-8?B?Q1lEMnAzbEVUajVNNWFGdVVDK1FGbHZFSHF0dGllWFE0UEhpMTV0TUQ2dXhn?=
 =?utf-8?B?ZDZhOXl4YkR5VDlRMTNIN3R2NEtsUnVvMWl5YWRTend0WkRFMmVsUmtDUk8y?=
 =?utf-8?B?YjZIdHpMZml5Q1ZiZkZuZDlQaTU3WGsxamNRNld1N29tWmRCbEhmclRrUEt2?=
 =?utf-8?B?Rkl1VTZ4aHhQTDh1QUtoRlhZTm9idElqd0JVcHhZODFLL1pZRy96OHQyZkk0?=
 =?utf-8?Q?MY4cmEPFL7Uy7NYnsZqpe5c=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22d7f527-b573-445d-d1ff-08d9c48c7a0e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:16:27.3182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pnAzlANpC5BqyLmEwmAvQ65dkhn92or8+O0+328WWP95GyxXROuff78HoqHWz1KRC+NWQ2X9egpAf/j8V24DHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533

On 25.11.2021 14:39, Anthony PERARD wrote:
> When doing an out-of-tree build, and thus setting VPATH,
> GNU Make 3.81 on Ubuntu Trusty complains about Circular dependency of
> include/Makefile and include/xlat.lst and drop them. The build fails
> later due to headers malformed.

A circular dependency would mean that besides the expected dependency
there is also one of include/Makefile on include/xlat.lst. Where is
that? I'm not aware of anything include/Makefile depends on. Is there
any dependency being introduced in this series, perhaps by way of new
(generated) dependency files? It would be good to have a clear
understanding of the issue - as you describe it, it could as well be
a make flaw.

The adjustments themselves look okay to me, but of course they don't
help readability.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:18:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:18:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250459.431394 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfyU-0004OU-TM; Tue, 21 Dec 2021 14:18:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250459.431394; Tue, 21 Dec 2021 14:18:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzfyU-0004ON-Pr; Tue, 21 Dec 2021 14:18:42 +0000
Received: by outflank-mailman (input) for mailman id 250459;
 Tue, 21 Dec 2021 14:18:42 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzfyT-0004OF-W0
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:18:41 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e55cfce6-6268-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 15:18:40 +0100 (CET)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-18-Il-hyxKzPzCwCxp-Co6m7w-1; Tue, 21 Dec 2021 15:18:38 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.18; Tue, 21 Dec
 2021 14:18:37 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:18:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e55cfce6-6268-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640096320;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=XFdK8Csh04J9ZOQwVZ2hfSpX8LkVbiKpVijZD4+eDvE=;
	b=gbSZ7sWDpIerPDByatlUw0IMVpJYpruYvYutNd9JZVmcsyHPnCHRs8obKIMQBnLE/N5cvh
	+Xk3Zy+yo9yw2/cXfBHqxIeP3yRGa1WMyoSUapSuQBrSACUXcnNyXHxAxg69rb6C6SN/Sl
	9YQ4Vw9naBfe4bngwytPGOz4ca4VV6g=
X-MC-Unique: Il-hyxKzPzCwCxp-Co6m7w-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=DLoovx6eqYinrhkzTNrqK/AkNtr+DWcm8et306RjMvJWV6Bd1PvhGxUxVGCdcXtgkgzUQPdp8VoihFDG5+Z0cZcc/Lp4jPr7dCScXbh0UeHTSIimFHL9UcdLOuanN00WLtbXT53megSKhzKoBi7Xx3Zr6nPP8PAB95MlQIre5xLc+xKh7INoMrMBlaFaWcB5nwRp6ghfQJ4mFWSpr5xW6PEYGPXi7pR3wID6UibjJrrUrMnSmD7IhqPkVAX3Uy43obgE40s+BS0qV46hGOx6sAlEOQl5qv4vTqSbp8bAz6siD7DsGs7h9ZX20/mMsUwki4H+t27vjftnbJBRns3aKQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XFdK8Csh04J9ZOQwVZ2hfSpX8LkVbiKpVijZD4+eDvE=;
 b=ee/uBDHCRgkufvFscn4YhO+eve4ZsyEKRbDafYwvoUXi7p8+uySwbjp1TiWmfH0Ddxfclf4AnpLip9oODZcjaFeH6pdOUByFZrDFDdW9irruLGYtZjly7t4F96Qg8SMtTd/EA/xUhTm5Tg+ABddP24RgdadwcxIHT85MV3zrVmSZlW51WY+vcA1SyEI4K4JwQwsJQOwlMg8+73nCUaSq6xktm3n990r2GwnVytxsSWPf2KrYl63aOtURZ0MZQ4DNlB4riPF0D5KvfPXMfurMdemQJQtbUboiPAt9tNxek7tazvxniJkrtTbXjN8b4u2beA9a8lIXFKqE8wZofLnQzw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <8b583cd0-216e-37a9-7f67-ec0e04123f54@suse.com>
Date: Tue, 21 Dec 2021 15:18:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 32/47] build: shuffle main Makefile
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-33-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-33-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0130.eurprd04.prod.outlook.com
 (2603:10a6:20b:127::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ccedc34-7de6-4ec2-caaf-08d9c48cc767
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB233507DF834C3DA4695603D5B37C9@VI1PR0401MB2335.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xjv84qtmakrYG2aHXMCDlX12oZAudEzHgazB5dZLa2n/yevFAhGyS4/3yzpcw7lI2H6pxy0icQI5XTTHQV+QMde2GSGzXe9HJMcGLZ62W4vKkSaZG6SR4Uh2bBmUHdkfbIbE1ObobefQ75d5S09peGEP4+OQIj0TDMocAYLHmVp0USoA9KYbFVQa+mstuTrplL0eC8AisgEd35VU31oTaq3elyhKRw0EzU1SmOUxh9J6vBc4gOqWNQwmLFRYIqbQnhuBrwpQAEJny5V8quuNU7KCQZQP3lBfV+vsh81IOjBMGZ10/CiQW+woIKKp6xGRoaDHwW4l20ajp54JbYPO6ZIvJJeI1s0SN18LHdzoHyS8lrYmGS3CcWhskb5mjlu1u9wW/p3VZyuSYhpajXeLx4/LG1tkO9pjs+j8k139RaFAq4QFvAF1Nm6KvDiZ4tp1++1Qv+RxfuCxTsiMgIe2Z3YWk1jJc+12YaLlt5xpz1s66FhCtVX5Z5qM11iVT2mWs4+Ai8ysaK5rEJzf9T1WCGJS7l4zOuacJGqt2b15VaBn0nTKRM8UQa0In/Jja4CQjreHBRmedJ4kgu6WrRf+kIyO+k0IvIcuHJwacGNxou0K8IxNu50NsgwxFRuHr00OXvNrT6yDIl19vs5vSdaY4dRN4eUUp4DD42ID0SWzJLuSX2cW00R0oKS77A1OEmwzZ2NJ02JG46JAuLJPoUQDozrUdHeqDBeBZZXMMNI4UHQ4WsMT8fN5tNyMPAr+Fqy0
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(31686004)(6916009)(8936002)(86362001)(54906003)(2616005)(6506007)(83380400001)(5660300002)(316002)(53546011)(6666004)(4326008)(66946007)(26005)(4744005)(31696002)(6486002)(6512007)(66556008)(66476007)(38100700002)(8676002)(186003)(508600001)(2906002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ekE4RTNMSXRKNWUxVEhLbTE4ZlJQR1pWL1haUlNwNXlPMGYvWTFVamtaUi94?=
 =?utf-8?B?RHduMUp2WElBNEtwNlpwQ2drVFRIQmZabFJQTktKWnNHU040RVF3QTViL0tG?=
 =?utf-8?B?UjlRNStvK1BrUGlMeTdhd2lyUHVBRXNtZGo1b25TK00rQnVDUFMwUnNOcDZN?=
 =?utf-8?B?aVdGUTd2Vm9IeEF3N0diK3F4U05sQjZiMWcxeElxblFMTjRVcUpxeE1wbkFy?=
 =?utf-8?B?MFVZZjV3MmVSRW9GREI3Uk9RRW0rdGh5QVdETVlpa3VqRzE3aElZdnNTdWxS?=
 =?utf-8?B?TXpEVjNCMFUwazlMNnI0cE5qQXN3ODhKcmhxbXVBSmlKbEVEdXY3aVEyRXVR?=
 =?utf-8?B?aER4Q0htdkp3anBPOUZuY2I3WWNFOUdYN3NNQzN2bFZlSzMwYzA1dFRma2ho?=
 =?utf-8?B?ZUVTaDBic2VmbmMwNmtINklOWmxSeE9ETlkxZjgrNDFBSk0vdEQyZ3lsLzFV?=
 =?utf-8?B?cXJDdzRCTjVrc3BVajlSSURER1lrbFVxZ1pJU0dyMHRPemExTm15Y2VWUVdJ?=
 =?utf-8?B?M3FHUHdMZ1hJOC9ZQzlIdVJ2UFAyeDZicU1VL05rZzlOQ3djUHNMZmRWZXRF?=
 =?utf-8?B?TlJGZDE0YmpjOFFjRWJWazVDcytSSUxrMlpFL2JtWnRTNmNXWkdITTJYb3hh?=
 =?utf-8?B?RWJwWnd5cTMxaHczRGhIUUFDeE13dlRHMzU3RmMzeVVRdXhVZ2pBdlJXRTlB?=
 =?utf-8?B?aWhwK0x2dGkyQUtnVFFwanRyMVFvNFVEbjNGSlJhWVZibzFoanRGams5SUxF?=
 =?utf-8?B?YWo4Z0pSbXE3QXNwZUVmdnA5eFd4Y09PM2NjaGQwVnN6STdZSC8vS0FRMU9Q?=
 =?utf-8?B?OFdLeUlvMW1rZEQ4K3ZxL256U0xhb2lHeW9uaC9NQXR6Q2Q3d1NwQXNnNlFw?=
 =?utf-8?B?ZkJPeDN0YlFweENOSjBNTmVsSHowQ3BtM3dSdkFva0dnS0VVbzRvcGIwYWl0?=
 =?utf-8?B?cDFOQ3JkckJGTW4zRGNpV0dIVEhPbEE5UkdFMFoxZGF0RWhaYWpFRStQL0Q4?=
 =?utf-8?B?L0VqNWdKSHZMbXI5Ui9KeXN2Uk5BZmhpd3BVY2psaFRVT1ZucEVsMEpPSjFm?=
 =?utf-8?B?L1ZKclNYejdaZk10bHhIUGdwTWh2Mi9ZL0E4aExVbHFCUUJaY014dmgrclpL?=
 =?utf-8?B?TURoTTZ4WWs0Ly95QWVpL3pDOXFOM0t5MWVJam9VU0hoemZod29YZXVJQThh?=
 =?utf-8?B?YjQwUzJsSlU3d3hZajRCR1VJMlQ4emF1S1VWS3gwRHUvVlRwdkN2ZXc3NWZV?=
 =?utf-8?B?NkE0a3RYWTZ6VkJrQVdhY1MzYVJRbnpkanJmbjlDb1A1QU9qZDRuVTcxZS94?=
 =?utf-8?B?YWtxOXVIbmdSbC9RYUVPNDBubEJkbU9KVysza0tXNXdnQ1hyMU9zcTZVTHhZ?=
 =?utf-8?B?TndUcWFRUW9CWTVMZDJTVHpVVmFEd2tTcGJmSGFtbjh4OTcyR3g1Y0NNUlcx?=
 =?utf-8?B?V1RUN0E0NlY3alZBV1NMUjF4NHJyNk0yYi9DZzI4ZXRCdXp3SXhxbWMyci9I?=
 =?utf-8?B?TEcxaDZaRDdYbHdiVEJwbzJyQ3VsdldrK0VaU2diaERrR3VYQ2M4MHVBNHUv?=
 =?utf-8?B?cFk4eHg0VWdzS2s2VURFY3ZFRGppMy96Nm1UV2VLRFY5VVFLTXRzVmhvSzk0?=
 =?utf-8?B?Y3FlZ0VOVmp1aDN4M1JlWW9Pb21lRHdWUW50RzFLSnNHc20wS2pmSUtpVjBt?=
 =?utf-8?B?dXBhYXAzU2JPc1ltTTFXWjI4N1kwdzl5dFJ1azJTU2VJZjc4VkQ1dXQ0aFFp?=
 =?utf-8?B?QkFzTDVsRFJsYi9BTGtIWUg0Z3V4dXIwMlZsY0dwYTJpWDc2S05ieEdRTFdo?=
 =?utf-8?B?b2VEUXFnOHcydnNFak5IcDhwTGg1OHhaOWhpdi8zNGlyY2hzVlEyRFJFSGxW?=
 =?utf-8?B?cWRoamJuQ3h5emY4RnJrMFhOV28vUUwwY2svRGJiOFE2UGJVcUY1VUIyU0lI?=
 =?utf-8?B?RUdidk5ZRXJSb3ZpWFlnbW1pRGRjZWRJUyszWndjWkVpSjZVUnhHOUI1cy9j?=
 =?utf-8?B?RFlkcWJ0clBTQVpkTk9ERm9QbkgxVXhpZVhtbDBTQUhXTVFtd3UrZklNRHRS?=
 =?utf-8?B?Y1pqSkJxdGFFREsrMW5uMUxuTVAyTVRmUzlWaTBjdlE0Y1NxRkoxNmZzTXlC?=
 =?utf-8?B?MDA5eS91VUhjT2xKMmlqMnVEU3dMTlA3dERxZWhjVVB6ZlZhUUIyNG9oV1VE?=
 =?utf-8?Q?VgDCkkb3+7VSvQV+2imNaH8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccedc34-7de6-4ec2-caaf-08d9c48cc767
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:18:37.1508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QOwUsDJjXHHMPcFtfHaEwL2r4STho2FyU6dp8L265re3/hIljUYGLD8/620pXDrrHI9uf8bMJAUAJgD5Dgeybw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335

On 25.11.2021 14:39, Anthony PERARD wrote:
> Reorganize a bit the Makefile ahead of patch
> "build: adding out-of-tree support to the xen build"

Without you saying so it's not clear why that's good of even
necessary. Moving things around always has the potential of
breaking subtle ordering requirements, so I'd prefer to see
what good the movement does.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:20:43 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:20:43 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250463.431404 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzg0N-0005tN-87; Tue, 21 Dec 2021 14:20:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250463.431404; Tue, 21 Dec 2021 14:20:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzg0N-0005tG-5A; Tue, 21 Dec 2021 14:20:39 +0000
Received: by outflank-mailman (input) for mailman id 250463;
 Tue, 21 Dec 2021 14:20:38 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzg0M-0005tA-2B
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:20:38 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 2ac4f22c-6269-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 15:20:37 +0100 (CET)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-28-vXBlJ08rNbKbxqu91THndA-1; Tue, 21 Dec 2021 15:20:35 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec
 2021 14:20:33 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:20:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 2ac4f22c-6269-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640096436;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=aBOjWOSMOAdnb66EmLKJww4FT4bEMke8+BrznDdGqqk=;
	b=fJ4kewjVupKj/EYRz+d3YkpFIvCFW1WwcaUfNevYvfHMNJPk74Q/Eced4v6Tmf2za6huGE
	AbgEhJAMv5YaRRz31UxNrY3/aIGF+XpP/+pgKvPaP4r4nXs/Rfzll92ZP0FxoWp3Glp40H
	fvjEkDCun1K8sKeujXkJ/bBfu+0wvYc=
X-MC-Unique: vXBlJ08rNbKbxqu91THndA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=iYqTB7iJTe2DAN8agmDNGiZbEE2Xt+w26nge4FELqS+69YvpOeE13fPvNPXdKjBkUTUcKiUfA4hbyHqomC81Aw3CSWtPHwzS3aKXgfeyagJUp0OjyTsD5YOv9SoNfMnVHCG80JAE/zOzoMdrIZ9fIw3diGukIAUQDSG8wA/zu1tkLI3hxcgLGsaA8hsKVtwYNdiVZhaz+wBDZQeVUIcdj4Ma0/JLigtgB4hJDIxItKF7MdSIMrIp4YJu0xklgRONbeohNmkO4zBlv3TuqzhL8Jigf6u2qnQd//ECYPLw/znA9t/53qWBIuTe1uHN9/yoBGsAazvO/DL3ekVIwM9Yig==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aBOjWOSMOAdnb66EmLKJww4FT4bEMke8+BrznDdGqqk=;
 b=mZVlpmuEvJyGe+pzj8NUbPQSBejDU/SotA6G9p7WUWDV4suQWBHwfuZVH85Z66zbtsqcM99djPBbfim717EbJpACiHufU8EumpagPeEuJAFyhMswCIyh0iBiCIp3DZXEulN2jdv5zEFI1JdQYNaIaO5xq5Z7lsjBRngzZMY2CWSCJoeEOiRkUAGvz+AfiA6VQn5UJISFXZpCoj3MEPQMihFBhE6eHGB/Et2mnQJnW9iMTo111ySOo3NKiRKbt+qc8z1pN8WCfgAPlQc16MXAZzrWKT/TZuFMeqMbFBIdV9C9yfMPWDrDfEQYBPuVmTDFijdiytwnHQV8VeAWekG41w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f1313e18-3a99-a350-f262-fbc531f582e4@suse.com>
Date: Tue, 21 Dec 2021 15:20:31 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 34/47] build: add %.E targets
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>,
 Wei Liu <wl@xen.org>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-35-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-35-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6P195CA0088.EURP195.PROD.OUTLOOK.COM
 (2603:10a6:209:86::29) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1a28a39a-9a0a-42db-77f5-08d9c48d0ce8
X-MS-TrafficTypeDiagnostic: VI1PR04MB5325:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB53250AFD4D68BA38A4ADF04CB37C9@VI1PR04MB5325.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:883;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PJP4CSr55rgt1XCtFGJGuHx3bonbB/jDMwHdNXL7gf1BEYkYEVkGmVhzP5ul9MYpjAKrZooWRiX9GJmS8po451mS1hlSRHrzJBmnw2dOEnrx5Ri01C1Rff2fxVqlqcggVyLIfNwrRzG3rnHhpfPW4Duuwa9aLf4j1w6flLm0OdYv4Mz3TaddbTG+Y4+2EoJi0ECp0wAX1h/ywyolgZ8CpV7DqddzQfrlovlg9H/mIF2qQR/SL0S3JVxNUa+YS8dXexbn/7SgkJ8z7E8L0HxzJTH3uZgrE1RTOALWoHTF+/qrchxGTsLtj4VDwpCILmeH50ojfJ6CZeH8zUycTQppuWWBDQkNoGh1Y5z7nBEflVWG74FT4864FPz1YDMjxfd6z60xBCZ78zBsrqdNyHcg0VBbwDgtImuy8mPa5lmoQlpkfO5CVwnTW8kbvCnd1GrrxoPsjBfyFN6foj/U22hpJAMr/r+bnqj2HPA6NjmPjWExcM/35rZ3qb4dOqMd/Oh1n3nB2qOi01501oW/PK7/n2QZLI32Pt0/R+lXqdKsVD86G9rVucSW8GT4X00+wyudapE0SXwDRM0B2MNM/b8D90W65FCXofWiOKNqD1Y9Xwm8QET5igJGbsfA4RY0SVMCyH9qD5l93ygPzqXdV/Vgi7kwIobJAKTY9+6P0Zty2ch/AuNIslGFo5tRvi4dIVEsnpuf3vPHgoWC6qYlRzdGmdksMTbgUKHotcFuMU2DRA4=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(186003)(31686004)(6512007)(66476007)(316002)(26005)(4326008)(66556008)(558084003)(86362001)(6506007)(53546011)(36756003)(6916009)(66946007)(2906002)(8936002)(54906003)(38100700002)(8676002)(31696002)(6486002)(2616005)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WFhkc2lNUllnbFVkNGNycXFPU0FkeVEweG42Y3FoM0lPa3JMK0NrenRBRWhw?=
 =?utf-8?B?d0o3OEdiTTl0KzRTdVBGMk45V1ZRUGVoM00xcXVYeTZGaVlxTExXMWhJL2o3?=
 =?utf-8?B?OUYyTXpSUkpvbFVYVVVPdGxpdm9QaG11ZnQyZ29jVUNrS3pHVUxJcWNTSlFC?=
 =?utf-8?B?dHF1Mjl3dDc0ZHdKYXNLUnc4c2orTWpJR0NBamZKY1JhMWxuZnc2VUN3UUF0?=
 =?utf-8?B?QXNna0JzRy9reVJtVlBjZ3A4bFVpOWVzZ1dNUG5GdFdGdmhxSTdOdmRybVE4?=
 =?utf-8?B?L0tZMDUzYi85MlIrTS85U2tQT3NTa1RhQ2MxcWJTM3VBbjV5K0U5SHJIVGtO?=
 =?utf-8?B?MjZCUXU2U3VnRVZlU2dUaEFSdEFLZUFVcjc5NzFxRVZNZjFNR24veWR0QXlO?=
 =?utf-8?B?OFR3UUJRcmlOak95ZGdpa3ZEVnhaQnBPU3hNRDdxSzg0bkVZSHFLMW1KbzBk?=
 =?utf-8?B?ZlcwMzdhdjRtbjBGK0ZZK01YT0YxMm9RU2FnRUpWRUlqQ3ZzNU9pcHNoa0pi?=
 =?utf-8?B?eVBJUzJvam11Vm1GSzFkcVVOMEptaDhrK2ZLQXB6OHAwTUdpcENVa2lFbUNG?=
 =?utf-8?B?Unp3Uy8wSENjQVBicGxkbC9pZTY4L0g3aGtrbmtFNEQ0TUR5YXhpMXNPRGxQ?=
 =?utf-8?B?dWJQcjF0L2pRc0NzZzNBdVhmdmw0UzBDNHo1UjJyUm92cTZzZUFSd1RoSUZO?=
 =?utf-8?B?d3U3Tk1FVGdIUWNnWG5HN1RtNEU2VHBJZVhHQXRuVzFsbnR1cDZoeHRCZ3lP?=
 =?utf-8?B?QlNzMG5YMUhGNFlYZHdsWnNybEtEODBMOTAxZGM4MVVjKzlrRkhWWEN6OEdF?=
 =?utf-8?B?OGhDbzBxR2ZOVFl3cWFmcS9kd3FHbnhRMDVDNzMvZkIrVjZqdVpzeVJTb3lO?=
 =?utf-8?B?eHlLRlJwVXFsT3Y2a2tTdnluYzVMajJSNFpDMjgvd1gwQktYRm1hV1Vvb3Zi?=
 =?utf-8?B?eThjL3AxVUFmSFZObmdXYVVQWHphR3FZMEVyYmFQOUl0WHhxZ0t5QUdPYmVZ?=
 =?utf-8?B?M1JoWG5yRkhDK0VMb0RDdlVEbWdJQWt5bVhnOVhYZTR1amhVTEpDbS9jWEZo?=
 =?utf-8?B?b0xWeENJOXdMTy9BL1lGTlFlbjVZTmpsc0lpS3NKRTlFbzhSSUllYWxIOEMy?=
 =?utf-8?B?MWNEWlk3ZkxNTFpGWmxFbEVEc0JZSXZEZmk3cU5KNDI0ZUVuQm1PcTdFcis3?=
 =?utf-8?B?U1RMQlgwZ2p0QS91eGoyY2NrVlhZb3RORkoraEY2eUlQdS9nWE9KYWR2dE9o?=
 =?utf-8?B?NC92a3pBclduT1dZMzZMZU1PRFA0OFYxaFhTN1F5dU5udXZraGpCYUpPQmtO?=
 =?utf-8?B?UHM5ckhuUGMwNmRhZERwd1phbU9PTTE4TWR6MGIrUzRLL2k3d0hURW1lUDBI?=
 =?utf-8?B?ZmoyRVBLbHpROHUxNWRPMEtWa3JnOTRKZG1LNkozd0V0MlBDcHNISDdmVHA5?=
 =?utf-8?B?aCtPMlZTY1BvVFBYVzZoZUJzazZ6dzZhUVcwN1FyMDBIMm1NYXQ1dTVuL0FV?=
 =?utf-8?B?UXZGaXNjQ0ZDUEtRYTNtMk9XaENIYkUrSmFWVWhEeHMwbVlCcnluOEd5ekho?=
 =?utf-8?B?R1Q5akZtR2srdmNMS0gvNmx6ZUd2dXAvUWxvalB1OGp4V0JBU1dGdUx1cjM4?=
 =?utf-8?B?Kzl2WmFBT29QVDFhdUI1Rnh6UzE0WitaYXNmUzB6cHBuK3llOUZydkg0MkRn?=
 =?utf-8?B?UlYyWUNqU2ZPZ3c0cGtvVlAxSFJPa3Vnd1ZxZVU4VEhxZkVQZXpuMThWNGhM?=
 =?utf-8?B?b1BqVXdQdGlkM3FRRVA3Snp0WEh6RzdDdDRWWlhHRjBOQmU2V3VyL05EYURL?=
 =?utf-8?B?QUxkMjVVUFRpZGJidTg2RlMzTHhhaEQ4bHpsMkdxZU05WTF0cndCWkhwVTBa?=
 =?utf-8?B?VHdQdjc5Y2k4MFpzK21Sa0JQNng2TmdQNGRsN3dNaDZRMGxYUWU4VXp4UHFw?=
 =?utf-8?B?cVRaMldMNE9vSEFVaFNjaUt0VGxCT3YvSnBRQnpzdUZia0RQQ1dWOVJBcThn?=
 =?utf-8?B?M25lZ2kyVXNSQ0duRWpMbDIxaXlrOGd6MHQ3aEhYMWZDUngxVjZxNlFIMnNs?=
 =?utf-8?B?Q24yZytEYXQ4cERGUEx2S2FDdGhCVlRuN0FXZHZGaTF6SUl1UmtzR3NlQTZR?=
 =?utf-8?B?czdaNmZyZVFvN2dvb2NGZFc0N2p0T1dyb3ptMkF2TkxVVGlTRkZrK3ZGOEpC?=
 =?utf-8?Q?6zOYPLWCSBYzWjoiijrl+aU=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a28a39a-9a0a-42db-77f5-08d9c48d0ce8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:20:33.7309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ChP2bXNTqCkfdb6ul1ct34risKrVogX3/urfoBhM00w1+SsWdRtZEz3V3Aa/30RJ+/4Q+hFUX5PhZj3OKYSGXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325

On 25.11.2021 14:39, Anthony PERARD wrote:
> I guess it's easier to remember that %.E does "$(CC) -E" or "$(CPP)".
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

I understand that this patch isn't going to be needed anymore.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:24:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:24:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250467.431415 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzg3W-0006Xe-Nw; Tue, 21 Dec 2021 14:23:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250467.431415; Tue, 21 Dec 2021 14:23:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzg3W-0006XX-Kx; Tue, 21 Dec 2021 14:23:54 +0000
Received: by outflank-mailman (input) for mailman id 250467;
 Tue, 21 Dec 2021 14:23:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzg3V-0006XR-OH
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:23:53 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9f567b4c-6269-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 15:23:52 +0100 (CET)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02lp2059.outbound.protection.outlook.com [104.47.4.59]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-37-jBYjiI2QMz-stEuPgAuImw-1; Tue, 21 Dec 2021 15:23:51 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.20; Tue, 21 Dec
 2021 14:23:50 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 14:23:50 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9f567b4c-6269-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640096632;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=KpW7mlHnACVTvdBKx6GQsws3vioDdHC1jJmTk4QqMPM=;
	b=gdO1lgiWy8qjiCeChnOMll7oIuqBZKH75spg/sHdfanuOSfY4jYlUA82aUtECV8XT2wQ+i
	3okgqHitMU2B6vwkW7xZNHEJJEeFawM/Nay4JDui2h1kuJO+31N1Uy5UcoETR5AOtyMzTY
	xjn1N6Axe3v33ZzQd/Q+yUWbFVZjFZM=
X-MC-Unique: jBYjiI2QMz-stEuPgAuImw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=dq3EH7DOukvRCyjkW3NQj6nVHEWT8Iqy7ttxQ0vgekQJo9y457kJsvM0dgn5jiJ4U2pSk8dnsklN8O3uSVkyv1ZjI5skg0u20e8RumNxFyGF7OFRP+fcV40jzpeS6V5nclQO3wsao8kGLdzbGDkn6OdVh/VskJbShj12qKdNEveCRZoGWHXbz5xjFixHdHRkit9s2zx3y9HV8FEj6dq3rIt8Mdpne9DVQ32/Zlx3EcJ0jVpV/GM8EmOVwRsZpua9gvPRsey+Z2Eujx7ksN+k9x3S25BroQlwAjIFZ34mnrI+rvgm7VPxORKX4ExQAeD13dsGcJ0Ka19DCoUQmoKq/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=KpW7mlHnACVTvdBKx6GQsws3vioDdHC1jJmTk4QqMPM=;
 b=adX/KZcgp0ktK0fXdW+LFg1iIqxHsrVCg51Pd6oVjMa2GagUwkB/CeHmNewqU6MmVLgwUgQro0fBh1eTIeVUGwlrDJKSWVaO46K5+Iy8nwKeWxRQvdCoyqW35DdvP6tao0YJna0dFcRV1x9aI+Co5dkLyJhXdNL7WdmF+2lbSt+LlsGKxCaefWXz3fiLcvWZhnH4OAiN057tQgc1g6FT9YbPwT9TKwS16TvhAr8DzT5G5qSUjR7h1TgDDbXpXlM+ShkqFhkh9zg+zJP0h84WXYesQ4kFdxIVODDRtjBZZqnxzkvq0kNSZy/yqUDr4TDXRoU0GcPjXz1Cu7UGy0QwDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <dcaba25d-180f-a1f5-671a-61ea4b2804cb@suse.com>
Date: Tue, 21 Dec 2021 15:23:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 36/47] RFC, no-VPATH: Kconfig: only ready auto.conf
 from objtree
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Anthony PERARD <anthony.perard@gmail.com>,
 Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-37-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-37-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM6PR10CA0002.EURPRD10.PROD.OUTLOOK.COM
 (2603:10a6:209:89::15) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ee8e088e-5439-4000-58d8-08d9c48d81de
X-MS-TrafficTypeDiagnostic: VI1PR04MB2959:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR04MB295976B55D03B8FA211EB6B3B37C9@VI1PR04MB2959.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	x6SWvMsyghxqn6iuUb0V2IbU5YhR92PrTpjqnyzXsT89ebypAqwOvxLno/PP/284TPBKPZTclR6uza0tE1dOLU3RK4offcoOideArr4E9AEWj1HZ4zM6joNJLCuK8X3JDFzvH40y4819iIG7BRfNsIK8uNVWYr60sVi527ki4nWAq2CGFLishjcb4vakX8eWO/EOt3SadAGtIT6JjpvYOrnyeEELiDIjMtamACp8Kg0IbUnctWuZGXFONKrA/k/ZNY/uC8Rfy9B8WK1ka4n7Z8CsAEwTvXwoejswpbDRB4/blmCtdBlyYuUiFQ7thxya27PjfbPlKwPELs9EeS5NmHrd8f4/aIX1XAo/sWFt1ygjXanh8k1tAGcZvwzNzDJsiCIyEmAC8N8noapO1RHLfsB0YDFGheNMzGHWXx2jRjH/Ig2Uxw4MpbcNqXQSEWoH0KO03/6q17l670O+k1szSMwOODayCplDcf4mhvHK5e/6zba/aJR48c8N0OjmPnbu38ilYWeYhO5cpzJfDfQGGvBaxPuQpp0SaTI14Ddu1mG1fefLLN9iRBXJacuPtwaXfA2H1CIJx8nk84ABUl8lmJGcYyBDyaMTiElVFbldU4X4zvBUAV+m/+xA6D10+t3Dxo5a03jpgueYF29UWz04wYWeFu/lHSJuR2IYtFnHcWxRFBYTV+LGR0opqLUTfCoUKgqf+zc6BNsk1M+Ibp0j7csdPk1errp4GPSbgB5Ts7GNkijZIteQV350T375iPPn
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(186003)(5660300002)(6506007)(8676002)(31686004)(53546011)(26005)(86362001)(316002)(54906003)(6916009)(508600001)(36756003)(66946007)(66476007)(38100700002)(66556008)(6486002)(4744005)(31696002)(6512007)(8936002)(4326008)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cHpRME5RajlIRldRMk0yd3ZTK050NEJ5NmlQeUExakRRcStTR2c4QjZLbUpo?=
 =?utf-8?B?RUhpRGZTcXFFOE1vYkQ1WXlYNVpYaEJqcDlONDFaR0xxRUc4cDJQMy93Tlhx?=
 =?utf-8?B?Q3NvN0xSUHdsQVMvSWloQUd5UkcweDhvVmkvTlV3U3ZBaUxvMlhuQVNvV3gy?=
 =?utf-8?B?QjBtWnpicWZCZzhQUEhXbmVQMG1zVzM4R1ZsVGJ6V1g1SUpBN2d4Nk5PZlZQ?=
 =?utf-8?B?YzRhK0M0M1hCeTdDZjdpV0VvWitsTG0wRW1aWmpPNHR4MHFBY2pPZUhHQUR1?=
 =?utf-8?B?L09ncmhvYjB5RFpnT2RhOWNsbXJQSHkvUW9wTmhwaUhVS3NNdHFoOFlybmxh?=
 =?utf-8?B?QzhLUzViUEJxM0V4eFNtZGE2UVh5N2NLRCtOd3QwWWJQUzZqeG9XZGxsTEtG?=
 =?utf-8?B?dHdBZjFHZHkzN0lRTlZyUEtzeW1ReWUzdjlQY0Nha0lIU3gyYU9zc2I5Mzhh?=
 =?utf-8?B?YUx5L3RaWXFoclFiY01aa0MzK3RJeGhiU2FZcHAvM3BUWmx4b1puaXZpbEdK?=
 =?utf-8?B?TDRNVlZQSW1Ia1hkV05aSHl0OXpNcVF3MHNSMm9pNmkvUnhLYWhPaEJSK1ZL?=
 =?utf-8?B?WVlxNTdDYTB2MDNTNC9xMHNqUkpiQWZKWVRIY21GQUR5UG5WQ3Y2UzJ0U3c1?=
 =?utf-8?B?SGV1WkJrdVlKTDQ2NTNJcnpYdndEYnpKT2xDQnV0VXlkVWJNeFd0RUNGMm11?=
 =?utf-8?B?MyttcS85YmNYd2dMWU0wSFJYV2gwb2tkR0JRL2ZlZ3BQSkhqbmFYdTdPdTBt?=
 =?utf-8?B?Qm93T0Nnd25uYjN3MG9FZ2kxVXJnYmZCMGdsekxYWFliaVFJOHJSOFhMRlFl?=
 =?utf-8?B?TWlZOEpid3NKdXBZSWEyejJzSlFSMG8vOHluME81SUxyRWVucEVPSHN2aVpm?=
 =?utf-8?B?V2xXNzA4TmRyNlhKMFpyOUN3U3B6WWRSdW0reUQwNnl6eGJsVklJQ2UxQnNk?=
 =?utf-8?B?TEhydG85dGRXZ0RwWDVnMkNISVc4TUlNZWxhT3hzTG80cEN0OTY4YU00K1ZQ?=
 =?utf-8?B?YzBZSlhvOWJKeTFaZDhPRG1aVTYxUVNxaXNLS1J5M3BORWdaS2JIaC9kaTZE?=
 =?utf-8?B?aDdNWVNTS3M4bHpoK2o1MS80S2EyS0Vtbnk3STBDV0JpVmdraXp0RFdOSkpL?=
 =?utf-8?B?YjEyN3JDbTY5SzBjcUpuOXR3eEh3azBQK1d6Z2p4c0ZYTzVhOU16eDBwTkFJ?=
 =?utf-8?B?VFo1THVrVkRaaFhxb3M2OXpjNFdVWGhXc1pLTDZVY0RJQVpwcmt1b3Jsamtx?=
 =?utf-8?B?WS9sZW9NQ0h6VllTNS9mWHg0UEdPd21vakhjRnJkVXpkdUhCdDAwdldVdksx?=
 =?utf-8?B?cit5Q0U1ZDg0Qks3eWVNRlYwejlVbEt4UVdNZ016amRZeFRzZWNBcDNQMFE3?=
 =?utf-8?B?U3I5YThIQk9VYUNwOUR0RVUzcTB3UG9pRGRHaHVjY2JadTNPQXM2aCtOay8x?=
 =?utf-8?B?WDNjNUpydGtCaEYyYVlCSG1KV2graDdnN1o1ZWtENmFuczhYNmk3ZTVJVkxK?=
 =?utf-8?B?eURPSTZNRlNZM1FFczNTdC9oNXVmQlpORktBQi9POXFVZFZiNGVYSWNuQWpE?=
 =?utf-8?B?dEJiWUZQelk4ZjViYzcxYkY0QlFyUFNLNzRiYTkxdWIxK2p2MGpZS1ZTOTll?=
 =?utf-8?B?YWxDUnVNVkFDa2k0SHRvZVhnOTFuOEdoWllxMHJTYVp2Sk9xNXJjcDVEV3hC?=
 =?utf-8?B?d2NlWXIxL1NqVlFnUS9HNlA3ZVpmc2gwcGNQd08rcEx3aUtxTW43dmJSSGxD?=
 =?utf-8?B?R2FucFNpdmpnSXBuYmRlb21YaFhTeXQ2YkNPQUZoQUtNdHEvS205emRsMURt?=
 =?utf-8?B?eit5dzFheW5ITE0yVkV2bFV3UVhtQUw2OXVvTlNsOGlUeWxYMkxPNSs4b1dE?=
 =?utf-8?B?L3lJb1ZkK0lGdnhoc3M0aFVsWnRvUXM1ODFlSXgrK3FrbitTbVlDeTNyZmJT?=
 =?utf-8?B?eC9NWi9ITCtxeCtLZXhxUXlSVjN1cnd4VFQzWE5iQ0FqRUpCUCthUWFwVUV0?=
 =?utf-8?B?K2s5SEpTdDlKZUZVeHlEc21jOXpvTGtNUHdQOU5VRlpSdjRRbmdxU3NlQjBT?=
 =?utf-8?B?djJ4aUtETU9vcUFoWDNtQ0drSGp3cEZVTmNKb3BNenI5emM1aEhZUDh6TWZI?=
 =?utf-8?B?K2FDdi8wTlBLVUM4OTNCNHNZNzUwQXQrRGVPZjJiU0kzT3REcXF3bVErZkJ2?=
 =?utf-8?Q?Z3NxYQs7WLGdFQASy/GLmhA=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee8e088e-5439-4000-58d8-08d9c48d81de
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 14:23:49.9840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NpMddmh5dFA2uGsbyi06/z+GZLBsk4S1tWUJOytDENUQ1Y2/S3a4iH8X73gGz2NjAO6HNpfl/Bijg9bE7gQM1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959

On 25.11.2021 14:39, Anthony PERARD wrote:
> From: Anthony PERARD <anthony.perard@gmail.com>
> 
> zconf_fopen() will open file in $srctree if the file isn't in
> $objtree. This is an issue for "auto.conf" as it could be in the
> source tree if it is dirty. With "auto.conf" read from the source
> tree, kconfig will not properly set the file associated with a
> CONFIG_* properly in "include/config/" and instead only touch the
> files that correspond to new CONFIG_* option that were not set in the
> "auto.conf" found in the source tree.

Do we really mean to support mixing in-tree and out-of-tree builds
from one source tree? Without such mixing, iiuc there would be no
such problem.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 14:46:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 14:46:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250479.431427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzgOt-0000pp-Ml; Tue, 21 Dec 2021 14:45:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250479.431427; Tue, 21 Dec 2021 14:45:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzgOt-0000pi-Jh; Tue, 21 Dec 2021 14:45:59 +0000
Received: by outflank-mailman (input) for mailman id 250479;
 Tue, 21 Dec 2021 14:45:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzgOs-0000pc-Nv
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 14:45:58 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b32006c5-626c-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 15:45:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b32006c5-626c-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640097956;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=b2yeN3TQ1uPcAA39PbjC095xO72qFP6zoaalMdV7SSA=;
  b=CPVhCyoN1Yhj5EhCMna8rCLu4Jb/dLreC49IA7Il6ZQKTGYWsHempzPt
   n/HNUetyOkqibXPuRwHLrMW8mYND5xeY4m9HkCf8q4wioMcWjVQr1R6Bp
   X57NEUjpjNK1Z9IqHp36WGBNimpoew2woPQvM4yNUB6vBdblQ513x9C1g
   I=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: CIZ8eXrEGww16Jr7fx4BmvlCwz2SpSMB4YSlv7YC8gyAmQZXIY4cmJCHl9z+biBcVH7M4cGDWb
 kAXB/WaTQh+ipt1fVQs1Xpt8X02K7DuRq1vte7EolI7HZwCrfo5z0pz9kGp72wptaN5D5s76b0
 OdmxN2FO8EJ220Fx3RNYwTD0WFIlL3/bn9622Cp9jlivjlmJJEVMtOtiOgnplM/JJ9YFhuKCJO
 o8LuOMXizZBgzk+Zg2jnUn/xM247xUkfH3op+LkKrZLJN4/0r981i78070K5UfxOAfA9+Ob4ZO
 Fv8ecpniRdGY8TBNUltRH16B
X-SBRS: 5.1
X-MesageID: 60507523
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:EdKaB6wP3zCBWqp9h6Z6t+dawCrEfRIJ4+MujC+fZmUNrF6WrkVSz
 zMcUT+Gb//fY2H1ftAiO4Wxo0tTvpXRxtM2QVNkrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbRg2tQAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt9dV5
 dRJtIC7cFdqB6HUhc8MeBl5PAgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JgTRamDP
 ZFxhTxHNhPseh5JC3EtBZcdosb5iXmmS2J1kQfAzUYwyzeKl1EguFT3C/LXZ9iLSMN9jkue4
 GXc8AzRABsXKdiewjqt6W+3i6nEmiaTcJkJCLSy+/pugVuS7m8eEhsbUR28u/bRokSzQc5FI
 koYvC8nt7Ev9VeDR8P4GRa/pRasgBkYXNZBFvwg3yuEwKHU/gWxC3ANS3hKb9lOnMgySD8xy
 k6Sn/vmADVutPueTnf13pCQoDCpOCkiCGgDfi4JTAYby9T7qYR1hRXKJv5zHajwgtDrFDXYx
 zGRsDN4l7gVldQM1aiw4RbAmT3EjprGVAku/S3MQ3moqAh+YeaNeIiA+VXdq/FaI+6kokKp5
 SZe3ZLEtaZXUM/LxHflrPgx8K+B4NKoMTndnVVWT9oY+yyw0G+IfaF/yWQrTKt2CfosdTjsa
 U7VnApe4p5PIXenBZNKj5KN59cClva5S4m8PhzARp8XO8UqKlfblM17TRfIhziFraQ6rU0o1
 X53m+6IBG1SN6loxSHeqww1ge5ynXBWKY8+qPnGI/WbPVi2OC/9pVQtagLmggUFAEWs+l29H
 zF3bZTi9vmneLeiChQ7CKZKRbzwEVA1BIrtt+tcffOZLwxtFQkJUqGNmet7JtM5xf0OzI8kG
 01RvGcCkDITYlWddm23ho1LMuuzDf6TU1pmVcDTAbpY8yd6Otv+hEvuX5A2YaMm5IReIQ1cF
 JE4lzG7Kq0XEFzvom1FBbGk9dAKXEn71GqmYnv+CBBiLsEIeuA80oK9FucZ3HJVVXTfWApXi
 +DI6z43trJfHVk/V5iPN6r0p75z1FBE8N9Ps4LzCoE7UC3RHEJCckQdV9c7fJMBLwvt3Dyf2
 1rECBsUv7CV8YQ07MPIleaPqILwS7lyGU9THm/667eqNHaFojr/kNEYCOvYLyrAUG7U+bm5Y
 bkHxf/LL/Bazk1BtJBxEug3wPtmtcfvvbJT0i9tAG7PMwawErplL3TfhZtPu6RBy6V3owyzX
 k7TqNBWNa/QYJHuEUILJRpjZeOGjKlGlj7X5PUzAUP7+C4oo+bXDRQMZ0GB0XUPIqF0PYUpx
 fYalPQXswHv2AA3NtumjzxP8zjeJHI3TKh65IoRB5Xmi1R3xwgaM4DcECL//LqGd85IbhsxO
 jaRiafP2+Zcy07FfyZhHHTBx7MA15EHuRQMx14ePVWZ3NHCg6ZvjhFW9D02SCVTzwlGjL0va
 jQ6aRUtKPXc5SpsiehCQ3uoSlNICxCu80Dsz0cEyT/CRE6yW22RdGAwNI5hJqzCH76wqtSDw
 Iyl9Q==
IronPort-HdrOrdr: A9a23:445hea5aaoif16nq3gPXwPDXdLJyesId70hD6qhwISY1TiW9rb
 HIoB19726TtN9xYgBFpTnuAsW9qB/nmqKdpLNhRItKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5
 0QEZSWYOeAdWSS5vyb3ODXKbgd/OU=
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="60507523"
Date: Tue, 21 Dec 2021 14:45:43 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
CC: Oleksandr <olekstysh@gmail.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, George Dunlap
	<george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, Julien Grall
	<julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, "Volodymyr
 Babchuk" <Volodymyr_Babchuk@epam.com>, Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Message-ID: <YcHol8ads22asXGF@perard>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211217121524.GA4021162@EPUAKYIW015D>

On Fri, Dec 17, 2021 at 12:15:25PM +0000, Oleksii Moisieiev wrote:
> > On 14.12.21 11:34, Oleksii Moisieiev wrote:
> > > @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
> > >   {
> > >       AO_GC;
> > >       libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
> > > -    int i, rc = 0;
> > > +    int i, rc = 0, rc_sci = 0;
> > >       for (i = 0; i < d_config->num_dtdevs; i++) {
> > >           const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
> > >           LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
> > >           rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> > > -        if (rc < 0) {
> > > -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> > > +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
> > > +
> > > +        if ((rc < 0) && (rc_sci < 0)) {
> > > +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> > > +                 "xc_domain_add_sci_device failed: %d",
> > > +                 rc, rc_sci);
> > >               goto out;
> > >           }
> > > +
> > > +        if (rc)
> > > +            rc = rc_sci;
> > 
> > 
> > If I get this code right, it sounds like the dom.cfg's dtdev property is
> > reused to describe sci devices as well, but the libxl__add_dtdevs() does not
> > (and can not) differentiate them. So it has no option but to send two
> > domctls for each device in dtdevs[] hoping to at least one domctl to
> > succeeded. Or I really missed something?
> > 
> > It feels to me that:
> > �- either new dom.cfg's property could be introduced (scidev?) to describe
> > sci devices together with new parsing logic/management code, so you will end
> > up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
> > so no mixing things.
> > �- or indeed dtdev logic could be *completely* reused including extending
> > XEN_DOMCTL_assign_device to cover your use-case, although sounds generic, it
> > is used to describe devices for the passthrough (to configure an IOMMU for
> > the device), in that case you wouldn't need an extra
> > XEN_DOMCTL_add_sci_device introduced by current patch.
> > 
> > Personally I would use the first option as I am not sure that second option
> > is conceptually correct && possible. I would leave this for the maintainers
> > to clarify.
> > 
> 
> Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
> seems not to be conceptually correct. Introducing new dom.cfg property
> seems to be the only way to avoid extra Domctl calls.
> I will handle this in v2 if there will be no complains from Maintainers.

I don't know if there will be a complains in v2 or not :-), but using
something different from dtdev sound good.

If I understand correctly, dtdev seems to be about passing through an
existing device to a guest, and this new sci device seems to be about having Xen
"emulating" an sci device which the guest will use. So introducing
something new (scidev or other name) sounds good.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 15:13:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 15:13:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250492.431437 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzgon-0004Su-Ri; Tue, 21 Dec 2021 15:12:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250492.431437; Tue, 21 Dec 2021 15:12:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzgon-0004Sn-OV; Tue, 21 Dec 2021 15:12:45 +0000
Received: by outflank-mailman (input) for mailman id 250492;
 Tue, 21 Dec 2021 15:12:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzgon-0004Sb-0c
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 15:12:45 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7106035d-6270-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 16:12:43 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7106035d-6270-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640099563;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=1i5xVsn91I81IBVWBJ16l2jhGLcS4s2gGTzEYrlBBHs=;
  b=c1nv1A5uUeaYkJIlVijkHaRbjkIXH/fRaC/9KUNU0yLYGo5STQvsUMEb
   ocjdolUQmErzwOn0GfPYndhmNVmu64NC1X7rZPKPGyKNRMXaSM9fqkpA5
   JLwFJrR32XHtbDRjVbYZM1IMfYHRVASVi1RHaIITOqEPdh4djqdp7pKoj
   s=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: kCMhGUzK2ESYEVNYFWgAtF9JLDNHxheZU+MKDkL94PHykZXqh/bI+2bhZ+SuL3F+FMpeZCXXZ8
 nlkqmjFZSDiIroR+2KeQ3u8XHS27v8TGGbBwBYx4zlW5vHcu7B1Qy5O5ZBliAaS5o4aH8tWD/n
 4dW4B3HD0GNr3kPRSaPZEWdrqBBJQDHBTihTw6PEoJyTWmMraVZeRr4bzb28AqYYwVKRTIKIPv
 Z6Cax2hsNz7ZOL9f9Ukqm0rPbsF79ygUU4EOt1OvxEpF4O5ZXht+0A9QQG3wJHlGUAvgITw1Wc
 Le8utXvU3+mYAXm9KQsXiYOs
X-SBRS: 5.1
X-MesageID: 60908248
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:nUwVdaLoEN7aT8eQFE+RPZIlxSXFcZb7ZxGr2PjKsXjdYENSgjcDz
 GoXD2GFbPncZWP1KIpzYY2w/UtTvZ+An99hQQBlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s
 q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH140Eg5wrZj6mJVqYPR7z2l6
 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc
 QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2nz+pO2
 dMct6CvSC4ROPOLkfsiAiBhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr
 LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Glo15geR6qOD
 yYfQShOMgXFcyRzAEgwT5Y7rciKgD7CThQN/Tp5ooJoujOOnWSdyoPFO9PPdtuHbc5chEqfq
 yTN+GGRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQ7ChcbSF+6qvmRkVOlVpRUL
 El80iMosag18l3tVtTnVge0iHGBtx8YHdFXFoUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSIC+
 A+zoMLvVD5Tr7y8cXTDsb6LkmKLAH1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm
 G7T8nVn71kHpYtSjvjgowib6965jsGRFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5
 yhsdyRzAYkz4XCxeM6lHLRl8FKBva/t3NjgbbhHRcFJG9OFoSHLQGyoyGsiTHqFy+5dEdMTX
 GfduBlK+LhYN2awYKl8buqZUpp2lfC6SIu5DKmPNLKih6SdkifdpEmCgmbKgAjQfLUEy/lja
 f93j+7xZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjGI+ePitKjiIquYe5dajOmN7lhhIvd+Vm92
 4sPZqOilkQEOMWjM3a/zGLmBQ1TRZTNLcut8JI/my/qClcOJVzN/NeNm+58INI8wPwO/goKl
 1nkMnJlJJPErSWvAW23hrpLMtsDhL5z8iA2OzICJ1Gt1yRxaIqj9v5HJZA2YaMm5KpoyvstF
 6sJfMCJA/JuTDXb+mtCMcmh/dI6LBn71xiTOyeFYSQke8IyTQL+5dK5LBDk8zMDD3TruJJm8
 aGgzA7SXbEKWx9mUJTNcPuqwl7o5Sodlet+UlHmON5WfEmwooFmJzao1q08It0WKAWFzTyfj
 l7EDRAdrOjLgok07NiW2vzU89b3S7NzRxMIEXPa4LC6MTjh0lCimYIQAvyVeT39VX/v/Pnwb
 +ti0PyhYuYMm0xHstQgHu8zn74+/dbmu5RT0h9gQCfQd12uB75tfiuG0M1IuvEfz7NVo1LrC
 EeG+90cMrSVIsL1VlUWIVN9POiE0PgVnBjU7Og0fxqmtHMmouLfXBUAJQSIhQxcMKBxYdEsz
 uoWscIL7xCy10gxOdGcgyEIr2mBIxTsiUn8Wk321GMztjcW9w==
IronPort-HdrOrdr: A9a23:9131iqgXiLcjbx17+8AsT6duP3BQXt4ji2hC6mlwRA09TyX+rb
 HIoB17726RtN91YhodcL+7VJVoLUmyyXcX2+ks1NWZMjUO0VHAROsO0WKI+VzdMhy72ulB1b
 pxN4hSYeeAaGSSVPyKgzVQxexQouW6zA==
X-IronPort-AV: E=Sophos;i="5.88,223,1635220800"; 
   d="scan'208";a="60908248"
Date: Tue, 21 Dec 2021 15:12:22 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
CC: Anthony PERARD <anthony.perard@gmail.com>, Doug Goldstein
	<cardoe@cardoe.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [XEN PATCH v8 36/47] RFC, no-VPATH: Kconfig: only ready
 auto.conf from objtree
Message-ID: <YcHu1puptNbXyKkT@perard>
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
 <20211125134006.1076646-37-anthony.perard@citrix.com>
 <dcaba25d-180f-a1f5-671a-61ea4b2804cb@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <dcaba25d-180f-a1f5-671a-61ea4b2804cb@suse.com>

On Tue, Dec 21, 2021 at 03:23:48PM +0100, Jan Beulich wrote:
> On 25.11.2021 14:39, Anthony PERARD wrote:
> > From: Anthony PERARD <anthony.perard@gmail.com>
> > 
> > zconf_fopen() will open file in $srctree if the file isn't in
> > $objtree. This is an issue for "auto.conf" as it could be in the
> > source tree if it is dirty. With "auto.conf" read from the source
> > tree, kconfig will not properly set the file associated with a
> > CONFIG_* properly in "include/config/" and instead only touch the
> > files that correspond to new CONFIG_* option that were not set in the
> > "auto.conf" found in the source tree.
> 
> Do we really mean to support mixing in-tree and out-of-tree builds
> from one source tree? Without such mixing, iiuc there would be no
> such problem.

Could you read and reply to the cover letter instead? The second
paragraph of the v8 changelog speaks about this. I would rather have a
discussion about this on the cover letter thread than in a patch.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 15:27:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 15:27:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250497.431449 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzh2Y-00068c-18; Tue, 21 Dec 2021 15:26:58 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250497.431449; Tue, 21 Dec 2021 15:26:58 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzh2X-00068V-UG; Tue, 21 Dec 2021 15:26:57 +0000
Received: by outflank-mailman (input) for mailman id 250497;
 Tue, 21 Dec 2021 15:26:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=GYHQ=RG=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzh2W-00068P-Ui
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 15:26:56 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6db776a7-6272-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 16:26:55 +0100 (CET)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-17-0PjhxMOaNYK83CCD3TCJiA-1; Tue, 21 Dec 2021 16:26:53 +0100
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16)
 by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Tue, 21 Dec
 2021 15:26:51 +0000
Received: from VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com
 ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4801.022; Tue, 21 Dec 2021
 15:26:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6db776a7-6272-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640100414;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=tQWJsX0rf/YZ5fDIJh5gdZSrZ328Ol8HcaJuwLfvPck=;
	b=W1NwQupLzuIATgKOZx+NB4kDOrDTxgLCgU1qq7JpnGAPlcDwGuoMhGO4ckJnpv9LNOp4Ig
	fvc/3oNmtW8qzIOW6zvaTk/mFa2R2rfGjTOZObfrLGhRLUL/i9z087W4JhXpGcfrvDC1gL
	TM+TzZ6MsYFLWFsd1owhl0tcx2nzoa4=
X-MC-Unique: 0PjhxMOaNYK83CCD3TCJiA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=anOaOOHJNs1VaeI7C+4F4IHNT0NqCAoGdXG+r99sPaFSaT6akARVr5Pr9NFwaAyfD14hjqDRNkYo2YUj49cI9HwMrFkJLEE5zIKzhJPJ2P2pnMzjZxzJnX+842UoNZ6pE+FCs7QsI331WwNqvMgy4JQumzEz/JebOup5tfD/K49pJDKhMXCNBTtfzBcOIMz7Whl1zUlXiChNzKJvh18qTqx9/1WE+ZFIF6p9QxxpQZTIA9TLohPYpkx21Aan8gpGOrrTNWcZcZerFok1diKCznwxqa0eU8mTLCq2b0b8pNvF2rLxRNn9QMbPP+DEb25g95WRbvEmtD9TiQHHoVsXnw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=tQWJsX0rf/YZ5fDIJh5gdZSrZ328Ol8HcaJuwLfvPck=;
 b=PwJnWHPrQzIK9+AWWYHCx6GJVohdEFMqGaT+dIBB+q6VkxBe1uSWQSSjq73k6JurvVintaZpMl6ircLAVegYCZDtNZWBXm1OnP6NTHiV1takEt6zpr7I3OLXEGe7H0TB6EFlW54zNd+GTnfuqdwcJlkBPSNMKs8e0NFxP9HU4RNzCAwvbCX1awZ0pBH8i97EpyOi/9Yzi1jR0AjLzmCAFWbucE+25QE4WyOKD/d7FNOo1wPz/tpxOjazs6Dc1R9C4PaHrxpwDaw/MsMAz1KDBbUskabOTj3axkvNV7W7gkmo6znw/HxyvQbxpe8LR9fFXvGy00M3rtsuv3T2DH0Qqw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <f8cde73b-0e5f-1b3d-c51a-9fef6092dabf@suse.com>
Date: Tue, 21 Dec 2021 16:26:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [XEN PATCH v8 00/47] xen: Build system improvements, now with
 out-of-tree build!
Content-Language: en-US
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Alexandru Isaila <aisaila@bitdefender.com>, Wei Liu <wl@xen.org>,
 Jun Nakajima <jun.nakajima@intel.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Alistair Francis <alistair.francis@wdc.com>,
 Daniel De Graaf <dgdegra@tycho.nsa.gov>,
 Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
 Kevin Tian <kevin.tian@intel.com>, Connor Davis <connojdavis@gmail.com>,
 Doug Goldstein <cardoe@cardoe.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Ross Lagerwall <ross.lagerwall@citrix.com>,
 Bob Eshleman <bobbyeshleman@gmail.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 Tamas K Lengyel <tamas@tklengyel.com>, Paul Durrant <paul@xen.org>,
 "Daniel P. Smith" <dpsmith@apertussolutions.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Petre Pircalabu <ppircalabu@bitdefender.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
References: <20211125134006.1076646-1-anthony.perard@citrix.com>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211125134006.1076646-1-anthony.perard@citrix.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS9PR06CA0267.eurprd06.prod.outlook.com
 (2603:10a6:20b:45f::33) To VI1PR04MB5600.eurprd04.prod.outlook.com
 (2603:10a6:803:e7::16)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 41ea1a60-2359-4805-add5-08d9c4964f9d
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447:EE_
X-Microsoft-Antispam-PRVS:
	<VI1PR0401MB2447D5BEF5E9C310A0F97329B37C9@VI1PR0401MB2447.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Bs0fenzOhBeT6IRkoIbGEdB9GQQSkAYjB9x0qdpz+REKMRWoWmpjDIpXfV8+fGe5g7loE1uaZvD6E/uASADORDHDR4ZiEnWsbR/Xn2xEqqhijrELS/PPUqje5LKe/VjbVjh4wV4MjglJ47rBjK5mkGh0OvbnqiQacty0EqVmesXmCPI0lQjC8v8ik+KsV7F2a4xK68zeChQThUDOztHxKbjXPRHyO2l2oLJMy6of6LZbgADg68mRhffVSOdAJ3OLQwLqC0au8L8Q13rxImmxRbLLJ6Mju93rLb9bZVam60wEZnH0529UVC9xH00IcKAE2na5CzMzwWOkoaptDm/y/YHLqWs2Eanfq/sk4nLlcGm2MkWTiV8cjasoS8f9P9rQXgSOMFciwNx+R3yPKd1UTyR46tJjgoQkc9biPPHMGonZxaUnykS8O/VVyurKrQXyF1p0ZW00MO+UZsgwfp52XWmFIp6phTh5ImKRth4hedn5Yubfe6oLdadXC0I3LhaUfE0gsfGxTocQZclBzC/4be/bbqMivg9JYGjnpcgd8oHeJHjeE5NIjFndWD2jAQKpLporQ0sLsaLAtdgaLbOCQj5aO5fwSwz9DLgroCTDP7N8J2xTfND8lybTzN7/ZaCQrnxwXnvfXfCgrQreL5Gr195/W9JF0YxgUfGBQOh8ghpQbXD/VpzxGiefg96ZcUqxtRz0kZotf69bygXSubSEKirUVnwk6tV5s2lO/ZXht8p7C5kp+YYL796zEEq/wueusjjFHSmhbKgdso/6+jfi3A9WmD4kC+wHM/boLklk3EVMS1w+/kCfgb4BbIAXiwxVKeBSMT7En4Hox05danBeDw==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(86362001)(8676002)(53546011)(508600001)(316002)(7416002)(6666004)(6916009)(2616005)(6486002)(83380400001)(6512007)(966005)(31686004)(186003)(66476007)(5660300002)(36756003)(66946007)(2906002)(26005)(66556008)(54906003)(4326008)(6506007)(38100700002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UTk2Y2haT3o2VkdBUlFadUJMcnlWS0tLU3Zqb2RYd0p5Y20wZU1aYkRZS3pz?=
 =?utf-8?B?cHhoMnJyWlNoOXg2TVQzWTU5NzhaSUlIV2o5Tm5obHc4MzlrcFprSjBWYXpk?=
 =?utf-8?B?cldaZUgvZzc3NjlEUFkyS2t0UEJxcEhIeUtpWm1ZNkpWT1lHdG9NVlhOUUlP?=
 =?utf-8?B?SzFXYUpPLzl3NnRHTk5oSDhGV3RZek11MTB1bE9OZFlzbmpVQzNxWCtudHVP?=
 =?utf-8?B?aTB3Qjh0WC8vNXVjcWQwWENQNVV1dVl4aWN4MzBqbWNTejJ1bTVrZWNMK0Yr?=
 =?utf-8?B?VWRGK3RnVFJ4K215VHh2anZCRkUzaGMzNit1UFZqRkZKVEFjWWtSWlFwWFhE?=
 =?utf-8?B?TDdiaWpSVDNHV3paRFAzLzdSWVgwWlVwNnMwUCtFMVZLb2JFNXp1dHFBUWVu?=
 =?utf-8?B?aDNtNzFoQWd1TFBQL2Z5NXN0aDlLS2lmNXJhQnRobGpKcy9RR3V4NENlWVpa?=
 =?utf-8?B?VFhYWTVZZXVUMXhoemdHblVPQUNjQ2pDblhkSGMzN3grYTN0aWN5NVhKbEhy?=
 =?utf-8?B?SWg0VGZQaVhIVXA0NnMxbmNEVEZFZzVGUDAxd0VDdjJLQkc1aVczRkM1emNi?=
 =?utf-8?B?RVAvWCtEWllvTXRoZERINndDbmQ1NElTdzdhZkIvZ0xIRXN3a3lidWlLUjZa?=
 =?utf-8?B?UncrcU5tM0pidmE2aVZNQW9iNW9tbnZIUWlSRUJzRmROVEdSclBlY2lnMmts?=
 =?utf-8?B?MWhCWTVVdmlWLzBWSSsxRUFTY2EwK1JPaXNpWFp4NnlTc2pseXV1UFFUUFg1?=
 =?utf-8?B?c08rNU5jM3lnRE9UVDFhcUc5SXcrMFZSNjc2S21sMng5Mnl4NWcrSy9mS20r?=
 =?utf-8?B?dlJDTUF1MDlJSFZmM1E3M0x5ZTdnNDBaeVNGWlpKU2tabmw3TFA4WWtDZFNz?=
 =?utf-8?B?Rjd6YjZ6MnZXb1lGclkyYmRVNk9DbGpMKzJBSG1CQWoxbkN1bUR1cFR4aWg0?=
 =?utf-8?B?c1dJNjJvZWtMUkRneHgwaWo2RW5HQUIwZm9hWTBiK1hsZGoybWRTOUFJc0xj?=
 =?utf-8?B?ait0NVlSY3RuSU9mTUlYa1JYcEU0VUdaY1R4Q0NoTmRNeUxId1libE14bGx5?=
 =?utf-8?B?VnpuZnBvMkd0SzlrNXVvQmJ2YTN5QlBYUVh4cHlRaUdtVkdmS0Q1ODQvcTJF?=
 =?utf-8?B?ZUdZNlNacVg2TEdXcFB2dklMdkdTYkcrOGY1T25DWUVSeUR2NWxBRDFSdHhW?=
 =?utf-8?B?eXpvdDIzR1UrNVpmNG5vT29hQnpLT1Q2M0w2V1h6VzBEaFpJYmplQjZNcHlH?=
 =?utf-8?B?VTFwT1pJN1JmTGRmcG9SOTNGWFRCR1UyTi84b08zYnJiQld4djA1R2MvMXpN?=
 =?utf-8?B?TUhzaVFFZFZTL1lydVlPdEZYa3hIODJPamViU3g0S0NYRG1WVGhDbjFWQWdq?=
 =?utf-8?B?djVQVklMcjNCT0tNUDllUzhxQXhWRjN2c3JFQlJBcU5Ia3FSWTdpQm1HVVdZ?=
 =?utf-8?B?SlV0aEtFelhUWXB0bzNySTFKVnI0YzVyR1FyWlB1VzNHT2xKZmVQZWozcHRy?=
 =?utf-8?B?aW1iSEs3OFdONVorL0tXM1RhUlhNSlNEbjF5akpoYnlkTjc2MjE1UU0vWVV6?=
 =?utf-8?B?RWFVR25DZVVtWkF0bWJhNDBkVG5hbXVHSkd0dXRaN3RZc1gvV0x0TlBjWkVm?=
 =?utf-8?B?UE5leVoreE5nY2tvOFVwOGNMOHFJVWNGMDREUDFLWjRtUysxaDRyWWdxMmdF?=
 =?utf-8?B?cDd6YmFTM0ZudU1iTHFmN1gxSzYxc3lwOS9yZjFuc3hhV2tsdHdPWUtFaEg0?=
 =?utf-8?B?OE1OOCtXbjRSRHhWMGhTZzlvbURtdWVVV0YwZkR0ejBoYjBaZFQ1WlQzRm5r?=
 =?utf-8?B?ZU1ibk9aVUNEQUUrV2JEZDFXeTNJcVdiV2hrNzZFVGFIZG12WTlaQ1JOelhG?=
 =?utf-8?B?OGZYWlZicWw0YUdNd1ZOL2JXc2QyQUIrdkxxZVZwRHdIdnZNSlZyMWZtenpO?=
 =?utf-8?B?K3lOQVF0QStTOEtMOGN0OXQvZWd5Ump6VmhEeERnQnE5SDN3QitvYVp5YUJx?=
 =?utf-8?B?bm4rRmUySU5IWUJaaE04TUs1N1JSN245YUJCc0JmT3FsRjI1QzhLY21aUzVv?=
 =?utf-8?B?cTh5ajc0MWtQVklHdldRdEMzYU95Q2VQQ2ZRN25IZkdaS2VmL1BEY2xDQjM4?=
 =?utf-8?B?SXZ5UmcvbzFBbWx0WHMyNG1uUGRwamtLUHRDemFjTHljRDZPMW1lRTlxSEZJ?=
 =?utf-8?Q?yBls3QHoMxNYKlmO31fuX2Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41ea1a60-2359-4805-add5-08d9c4964f9d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 15:26:51.1436
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RdDRUEd4jKx8Kt79PMbID0Eu+h8rv8r3SpP6h5AFJpZrPUAqtWGnRN6ZIwyArv/ZHMOzEXeY7v0Hka4oyvTRuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447

On 25.11.2021 14:39, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.build-system-xen-v8
> 
> v8:
>     Mostly rework of v7. With many patch already applied.
>     Some detail changes that are spread through many patches:
>     - `make cloc` recipe should now work throughout the series, update of it is
>       done in 3 patches.
>     - new patch "build: fix enforce unique symbols for recent clang version"
>       to fix an issue with clang.
>     - introducing $(srctree) and $(objtree) earlier
>     - introducing $(srcdir) as shortcut for $(srctree)/$(src)
>     - introduce usage of -iquote instead of -I in some cases
>     More detail change log can be found in patches notes.
> 
>     Also this v8 present a work-in-progress of the ability to do out-of-tree
>     build without setting VPATH. This is presented as an alternative to force
>     use of out-of-tree build. As the last patch show, it allows to build the
>     xen-shim without the linkfarm and we don't need to make any other changes
>     to any thing that build xen (osstest, distribution packages, xen.git, ...,
>     and developers finger macros). The patches are only there as WIP / RFC as
>     they were some concern about the usefulness and extra changes needed.
>     We can decide whether those changes are good or if this is too much and we
>     should force out-of-tree build for the hypervisor.

I'm afraid I'm of two minds here. I don't think we want to force people to
do out-of-tree builds, but I also dislike the idea of mixing in-tree and
out-of-tree builds. Yet reading the above I understand that the shim build
would conflict with an in-tree build because certain files would be picked
(the shim build being an out-of-tree one) from the (dirtied) source tree,
rather than the shim's build tree. Perhaps the extra path prefixes that I
commented upon in an individual patch are then indeed the least bad route
to take.

There's one compromise which comes to mind, but which may also not be
liked: We could simply fail out-of-tree builds when the source tree is
dirty. Then people wanting the shim built would need to use out-of-tree
builds also for the "main" hypervisor, but people suppressing the shim
build anyway (or doing it separately, e.g. using a non-default .config)
could continue to do in-tree builds. The one puzzle piece I'm lacking so
far (perhaps simply because of having overlooked where it is) is how, for
a full-build-of-everything, one would control where the xen/ part of the
build would go _outside_ of the source (sub-)tree.

Jan



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 16:47:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 16:47:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250505.431460 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziHp-0006xF-QG; Tue, 21 Dec 2021 16:46:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250505.431460; Tue, 21 Dec 2021 16:46:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziHp-0006x8-LB; Tue, 21 Dec 2021 16:46:49 +0000
Received: by outflank-mailman (input) for mailman id 250505;
 Tue, 21 Dec 2021 16:46:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mziHo-0006x2-16
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 16:46:48 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9371ae48-627d-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 17:46:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9371ae48-627d-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640105204;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=kVZWwk6094asa98Fxe/+u89/BVK7Cfue7zX9sjQrgaw=;
  b=Ic+w5gJ1KMTTb+6l52e9C16GrE83gGxtY2AnoRGxJL7+9WHmTLm4H+4K
   YATM+taMIVgRRwfiyhLKO/7rMh7skS0ck087FUSjU6hugz2QsUNXhYr6O
   S+h1FR3uyx+Hpol9j18P31t324lhb6FVPCwPi0roTpWFSvZPe5EwLng7A
   M=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: exwW7skouF2YGlwGqJ6DYvBdlXmXn/MNcEefSX2jSwglV2El7/jKF6RPpfx5OyqY35WsKMFlhF
 yl+fE0jEWDVlW/GXtTkKbSmc//yGr2zidBTpIS2TuEj4LwQi5qJNt71UlUI4OgjgYy00RE9Sch
 GemM5F+PpN0u2K/4je+88qbNzHRL1KOndNyqd3uwv+rL334XpU22dMhJxhWBpPCVnZ2GgL+EaE
 WS7sHwfoZDsTF5JrAZFZH8+cEbLlLpiWVgQpi+CbW3ERbil0sjwUB66vTcADgB4wO43hEZPpbN
 i6URK4GVi6zFGTB3SqWsM84b
X-SBRS: 5.1
X-MesageID: 60917302
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3TDHNKNBEELxRiTvrR3QkcFynXyQoLVcMsEvi/4bfWQNrUp0gzQDy
 WpMDWCGOv7bMTTzc9x/Ptng8RxQ7MfQztZrGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400g6w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoxmVvdpN5
 NVTiaXuVSElGq7pie0TVBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9h358VRay2i
 8wxYyphMVeQfgJzZlpMBplk27yttGj8fGgNwL6SjfVuuDWCpOBr65D2K8bccNGOQcRTn26bq
 3jA8mC/BQsVXPSFziGP6HWrhennlCL9VoUJGbb+/flv6HWR22gSBRs+RVa95/6jhSaWUd9FN
 1Yd/CZoqKEo7VGqVfH0RRj+q3mB1jYiXN5XH/w/+Ru64KPe6AaEBUAJVjdELtchsaceRzMw0
 USSt8j0HjEpu7qQIVqa8rqXti+jIig9ImoLZCtCRgwAi/HzrYd2gh/RQ9JLFK+uksazCTz22
 yqNriU1m/MUl8Fj/7q/1UDKhXSrvJehZgkx6wbMV2Sp9DRldZWlbIyl71vcxftYJYPfRV6E1
 EXogODHsrpIV8vU0nXQHqNdR9lF+sppLhXwnXxlI7Uh6QiUpWKFcaRTxSB3KkBmZ5NslSDSX
 GffvgZY5Zl2NXSsbLNqb4/ZN/nG3ZQMBvy+CKmKM4MmjoxZMVbeoXowPRL4M3XFyRB0yckC1
 YGnndFA5JrwIYBu13KISugUytfHLQhulDqIFfgXI/lKuIdyhUJ5q59ZYTNijchjtctoRTk5F
 f4Fb6NmLD0FD4XDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdA9x/4IybuSp
 yrnMqO99LYZrSefQeltQio8AI4DoL4l9S5rVcDSFQvAN4cfjXaHs/5EKspfkUgP/+1/1/9kJ
 8TpiO3basmjvg/vomxHBbGk9dQKXE3y2WqmYnr0CBBiLsUIb1GYpbfZkv7HqXBm4tyf7pBl/
 dVNF2rzHPI+euiVJJqMNa/0kQru5SN1dSAbdxKgH+S/sX7EqOBCQxEdRNdtSy3VARmclDacy
 SiMBhIU+bvEr4MvqYGbjqGYtYa5VeB5GxMCTWXc6L+3Mwjc/3aintAcALrZI2iFWTOm4rima
 MVU0+r4bK8NkmFVvtcuCL1s168/uYfi/ucI0gR+EXzXRF23Ebc8cGKe1MxCu/QVlL9UsAe7Q
 GyV/dxeNenbMc/pCgdJdgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYsadEr2
 +YsvsIS+jeTsBtyP4bUlD1Q+kSNMmcED/ctuKYFDdK5kQEs0FxDP8DRU3ek/JGVZtxQGUA2O
 TvI1rHajrFRy0eeIXo+EX/BgbhUiZgU4U0YyVYDIxKCm8bfh+9x1xpUqGxlQgNQxxRB8uRyJ
 mk0aBElefTQp29l1JpZQmShOwBdHxnIqEX+xmwAmHDdU0T1BHfGK3cwOLrV8U0Um46GkuO3I
 F1MJL7ZbAvX
IronPort-HdrOrdr: A9a23:GeOvhK2hvsuxep8k5TSFGQqjBLYkLtp133Aq2lEZdPUzSL3+qy
 nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY
 dMGpIObeEY1GIK7voSNjPIceod/A==
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60917302"
Date: Tue, 21 Dec 2021 16:46:30 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Oleksandr <olekstysh@gmail.com>
CC: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
	George Dunlap <george.dunlap@citrix.com>, Nick Rosbrook
	<rosbrookn@ainfosec.com>, Stefano Stabellini <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
Message-ID: <YcIE5rv5vwxwSvKd@perard>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard>
 <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
 <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
 <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
 <44885d7e-c5a0-5b7c-144d-b9e6c7e54715@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <44885d7e-c5a0-5b7c-144d-b9e6c7e54715@gmail.com>

On Fri, Dec 17, 2021 at 06:50:02PM +0200, Oleksandr wrote:
> On 17.12.21 17:26, Juergen Gross wrote:
> > On 15.12.21 22:36, Oleksandr wrote:
> > > On 15.12.21 17:58, Juergen Gross wrote:
> > > > In practice we are having something like the "protocol" already today:
> > > > the disk device name is encoding that ("xvd*" is a Xen PV disk, while
> > > > "sd*" is an emulated SCSI disk, which happens to be presented to the
> > > > guest as "xvd*", too). And this is an additional information not
> > > > related to the backendtype.

You mean in theory? ;-) In practice, xvd* is the same as hd* (or sd*?).
I tried once to have xvd* mean PV disk only, but the patch was rejected.
So at the moment, we always get an emulated disk, we can't have PV disk
alone, at least on x86.

> > > > 
> > > > So we have basically the following configuration items, which are
> > > > orthogonal to each other (some combinations might not make sense,
> > > > but in theory most would be possible):
> > > > 
> > > > 1. protocol: emulated (not PV), Xen (like today), virtio
> > > > 
> > > > 2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)
> > > > 
> > > > 3. format: raw, qcow, qcow2, vhd, qed
> > > > 
> > > > The combination virtio+phy would be equivalent to vhost, BTW. And
> > > > virtio+other might even use vhost-user, depending on the daemon.
> > > yes, BTW the combination virtio+other is close to our use-case.
> > > 
> > > 
> > > Thank you for the detailed explanation, now I see your point why
> > > using backendtype=virtio is not flexible option in the long term
> > > and why we would want/need to an extra configuration option such as
> > > protocol, etc. I think, it makes sense and would be correct.
> > > 
> > > If we take a disk as an example, then from the configuration PoV we
> > > will need to:
> > > - add an optional "protocol" option
> > 
> > I'm not sure regarding the name of the option. "protocol" was just a
> > suggestion by me.
> 
> Yes, personally I would be fine with either "protocol" or "specification",
> with a little preference for the former. What other people think of the
> name?

I don't have a better idea. "protocol" sound fine, as long as the description of
this new field is about how a guest kernel will communicate with the
backend.

We could start with "default" and "virtio-mmio" as options. "default" is
what we have now and usually mean emulated+xen-pv.

> > 
> > > - add new backendtype: external/other/daemon/etc.
> > > This seems to cover all possible combinations describe above
> > > (although I agree that some of them might not make sense). Is my
> > > understanding correct?
> > 
> > Yes.
> 
> ok, thank you for confirming.
> 
> > > Unfortunately, disk configuration/management code is spread over
> > > multiple sources (including auto-generated) in the toolstack which
> > > is not so easy to follow (at least to me
> > > who is not familiar enough with all this stuff), but anyway may I
> > > please clarify what is the minimum required amount of things that I
> > > need to do in order to get this basic virtio-mmio
> > > support series accepted?
> > 
> > I'd say we should first get consensus that others agree with my
> > suggestion.
> This is fair. Personally I share your opinion (what you propose sounds
> reasonable to me in general). Are there any other opinions? Any feedback
> would be highly appreciated.

The new proposed property sound good to me as well.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:01:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:01:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250512.431470 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziW2-0001AO-66; Tue, 21 Dec 2021 17:01:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250512.431470; Tue, 21 Dec 2021 17:01:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziW2-0001AH-2O; Tue, 21 Dec 2021 17:01:30 +0000
Received: by outflank-mailman (input) for mailman id 250512;
 Tue, 21 Dec 2021 17:01:28 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mziW0-0001AB-4R
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:01:28 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a0c4a141-627f-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 18:01:26 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a0c4a141-627f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640106086;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=rySdXvcVByeKLHc/oyZ3fHun2YBIwHYfP0xs1RuK9Jw=;
  b=iCiqFbsrBx5R3lfgF0p3Om1shfHZm6M/QXyHJQMCYFT/B7BJiXwE/fko
   NuGttTAUB/ndtW0U8UO1sAFdTw6kt9Y/vaa89UBdrtHGRDm4Q4i+qP26/
   FXW2fMSoGq7ccuh/SNHZ3+zgVwr7HcJ9k07eCPPvUGtl/QjW0S+bC28Yp
   U=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: 0v8tEyOyNER5R9RudGbj5koCOmdv+Fr9JIGxTyHuDynvvlfTc1StKx8unajwoTrBMHX7F29stw
 a0jebxqLDDvq3wFGJ4/f2erCQqkpfTslIe39upjsGCcWABrPfsX098hz+y85BbxzhKb0m3aOiX
 eoY3a6bEFFjIPcld3yMk3DMrTjjD/5UeaJlnAY4N4FH9QJIjADq2l7x0+eUZphJSZ32IV84kf3
 uQSahCxWGPuphHpEJwcqN1he+ZKT2fmm4CjMGw+Dx+VMccj2A0FAY7p1C051tCvzmrORx5nM2c
 jKwuNn2ito6MdDjGhEJA9wig
X-SBRS: 5.1
X-MesageID: 60021995
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DWBL0q/Rrca3btPli3+0DrUDLHmTJUtcMsCJ2f8bNWPcYEJGY0x3z
 mNND27Vb6nZZ2unLotwPoWzpk9T6JTVzd9jHQZp+X88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy
 +1EN7Es+ehtFie0Si9AttENlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug6wrRj29Yz6TSEK1jlV
 e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH
 I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhf5
 uRzioDqED0WfZboub5HSTsJDiZXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us
 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp4WRayHN
 ptEAdZpRAbsZxIeHl4YMaIzheCTjHzbbmBcqHvA8MLb5ECMlVcsgdABKuH9dsSRQMRJnm6Rv
 m/c43niGRYeKcCezjyetHmrg4fnnDz5cJIfEqWi8fxni0HVwXYcYDUJUXOrrP//jVSxM/pTJ
 EAZ9TAnhbQj/0ysCN/mVlu3p2DslhcZUIsOO/Yg4w/LzKfIiy6JC25BQjNfZdgOsM4tWSdsx
 lKPh8nuBzFkrPuSU3313r6SsTO1PzlTNWIYbDUIZQQA6tjn5oo0i3ryos1LSfDvyIevQHepn
 m7M/HNWa6gvYdAj+YuKw2/b2WuWmdvyai9vvB/1D3+ix1YsDGK6XLCA5V/e5PdGCY+WSFido
 XQJ8/SjAPAy4YKlz3LUHrhUdF29z7PcaWCH3wYzd3U03231oybLQGxG3N1pyK6F2O4gcCShX
 kLcsBg5CHR7bCrzNv8fj25c5q0XIUnc+TbNCqG8gjlmOMEZmOq7EMdGPxb4M4fFyhdErE3HE
 c3HGftA9F5DYUid8BK4Rv0GzZggzT0kyGXYSPjTlkr7ieLEOSHJE+5eajNii9zVCove+G05F
 P4FaKO3J+h3CrWiMkE7D6ZORbz1EZTLLc+v8JEGHgJyCgFnBHsgG5fsLUAJIORYc1Buvr6Qp
 BmVAxYAoHKm3CGvAVjaOxhLNeK0Nb4i/C1TAMDZFQvxs5TVSd30t/l3mlpeVeRPydGPOtYoF
 aRYIJvZXawUItkFkhxEBaTAQEVZXEzDrWqz0+CNOWhXk0dIS1Ob99n6UBHo8SVSXCO7udFn+
 ++r1x/BQIpFTANnVZ6EZPWqxlK3nH4chOMtABeYfogNIB3hoNpwNij8rv4rOMVQex/N8SSXi
 lSNChACqOiT/4JsqIvVhbqJppuCGvdlGhYIBHHS6Lu7bHGI/meqzYJafvyPeDTRCDH99Km4P
 L0HxPDgKvwX2l1NttMkQbpsyKs/4frppqNbkVs4TCmaMQzzB+o5cHec3MRJuqlc/ZNjuFO7C
 hCV591XGbSVI8e5QlQfExUoM7aY3vYOlziMsflseBfm5DV69aasWFlJO0XekzRUKbZ4Pd93w
 eolv8JKuQWzhgBzb4SDhyFQsW+NMmYBQ+MssZRDWN3njQ8iy1djZ53AC3CpvMHTOosUakR6c
 CWJgKfihqhHwhuQenU+InHBwO5BiMlcoxtN1lIDewyEl9etaiXbB/GNHeDbljho8yg=
IronPort-HdrOrdr: A9a23:jAb4MK06IJz3nnCSO2eG4AqjBLAkLtp133Aq2lEZdPRUGvb4qy
 mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5
 uIG5IOceEYZmIbsS+V2meFL+o=
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60021995"
Date: Tue, 21 Dec 2021 17:00:47 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Daniel
 P. Smith" <dpsmith@apertussolutions.com>, Ian Jackson <iwj@xenproject.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 14/57] tools/flask/utils: remove unused
 variables/targets from Makefile
Message-ID: <YcIIP2hNR+FySlur@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-15-anthony.perard@citrix.com>
 <5286a1b7-3db5-1e00-f9bf-36fa537871b1@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <5286a1b7-3db5-1e00-f9bf-36fa537871b1@srcf.net>

On Thu, Dec 16, 2021 at 12:36:41PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:01, Anthony PERARD wrote:
> > @@ -35,21 +29,13 @@ flask-set-bool: set-bool.o
> >  
> >  .PHONY: clean
> >  clean: 
> > -	rm -f *.o *.opic *.so
> > +	rm -f *.o
> >  	rm -f $(CLIENTS)
> >  	$(RM) $(DEPS_RM)
> 
> Here and in plenty of subsequent patches, there's manipulation of raw
> `rm -f`'s which ought to be cleaned up to $(RM)

About using $(RM) or `rm -f`, I don't think we need to care if one or
the other is used in Makefiles, they needs to be equivalent or things
are going to fails. GNU make manual says that `rm` should exist,
especially when things like autoconf are used. For example our
./configure scrips is using `rm -f` and I don't think we can configure
that. So having RM configurable doesn't really serve any purpose.

Beyond that, using $(RM) is good in order to be consistent, and changing
"rm -f" to "$(RM)" is fine, I might not doing it myself or ask for it.

> I can fix this on commit if you're happy.

For the avoidance of doubt, yes, I'm happy with the patch that have been
committed.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:18:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:18:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250515.431482 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzilx-0002qj-HT; Tue, 21 Dec 2021 17:17:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250515.431482; Tue, 21 Dec 2021 17:17:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzilx-0002qc-E5; Tue, 21 Dec 2021 17:17:57 +0000
Received: by outflank-mailman (input) for mailman id 250515;
 Tue, 21 Dec 2021 17:17:56 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzilw-0002qW-12
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:17:56 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ee22ce13-6281-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 18:17:54 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ee22ce13-6281-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640107074;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=JSGaBk8rAOLskSdIFgZRZA47zfJVyAtj6pMUbWzuJ2o=;
  b=T3GqltWGyRNNpkzqX06mYaiFmM/0oh/40TeQOonF0ovoSB40QYTG/P3E
   xXplkQ0wPT4cbTBePfSolW5DiZ6sQ2wig77LigFfNTifXomWTGUrgvl+e
   5YVGxTTmm1JWvH+0jtTYeVdmtYULrGvXGuYN2ow1sWKDnhcexcUoXjCEd
   0=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: bc2BvPbjns3XwvwnuPyUIuD/RPeDXo15vFzUs58Dlm7tlAGnGoRWES6nwEKL1FIt6Q1S/Erj0P
 aEAK37iUkWOVwwCbjputEhm3Emvc1BRUCUvucfesvJkxIXYVZiCY3Wns8nCX1ALCIR86f1Iq06
 Ak/GoWLsCy43/Y3JDSjGU04VcAhImfBiyqu7v7FrgVFsX4DANtJeM+/b8ei5YPw6u60zjQJ1lL
 xILvhHbFWYxf6aU/C3c6g9G+m/R2kJuAffDcgZu5CFwZMMX2hln898U5f8rxoYrFdPlEu3xxEb
 FpvAtzQ9UZnNCpD6mUeSvk/v
X-SBRS: 5.1
X-MesageID: 60023931
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:bfp8tK6hCjz+3FN2ytWeYwxRtLnAchMFZxGqfqrLsTDasY5as4F+v
 mcdWm3QP/qNYzDzet4ibdyx9htQ7MXUmoc2GVY4pS0wHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj2Ncw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4
 dV1kMaVUx8SZYLpku4xYkZaNQV+MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQRa6EP
 JtCMFKDajzuTzBMfXsQT64zv+usnzrdfAICohG88P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTWo0IE6aj3uV3m1DVzWsWYDUfUFDq/9GikEWwHdRSN
 yQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLd5RqZAW4VCCZMctU8uOc5QDUr0
 hmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZSIF2/y5hZsrtUnga9xpPJ/qjPvRGT6ll
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3HY5
 CBc8/Vy+tziGn1keMalZOwWVI+k6P+eWNE3qQ4+RsJxn9hBFpPKQGyx3N2cDBs4WirnUWWwC
 KM2he+3zMULVJdNRfUoC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzflnY
 8rELZz1Vixy5UFbINyeHb91PVgDnH9W+I8ubcqjk0TPPUS2ORZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbeclsOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLNOmyAM0h9C1jZkTB/z+AghAeXGpm149HH7NfQFXt3LcLISdcQ
 6ZXdsOeLO5ITzibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz8
 ++6ywfWYZsfXAA+XszYX+2ikgGqtn8HleMsA0aReotPeF/h+ZRBIjDqiqNlONkFLBjOn2PI1
 wufDRoCi/PKpos5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LwMnf/mMfABkFJbiKZGEu5mnfAk+t/ih75G1QA4Tn/FWEumV+F7KX6c0MgR6qAUnu1FuRG7U
 16k88VBPenbI9vsFVMcKVZ3bumH0v1IyDDe4e5sfRf/7S5zurGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0EpX6RKnEgUrk8ssBICYDmvQMn11VebMGOESTx+pyON41BP0RCz
 uV4X0Yea2CwHnb/Tkc=
IronPort-HdrOrdr: A9a23:bZYKi6C/5dSycWrlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/
 xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U
 4KSclD4bPLYmRHsQ==
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60023931"
Date: Tue, 21 Dec 2021 17:17:10 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH 19/57] tools/configure.ac: Create ZLIB_LIBS and
 ZLIB_CFLAGS
Message-ID: <YcIMFkm1OOwqrieT@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-20-anthony.perard@citrix.com>
 <6af001a9-75a2-2992-59ea-170af8d1627e@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6af001a9-75a2-2992-59ea-170af8d1627e@srcf.net>

On Thu, Dec 16, 2021 at 05:16:05PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > diff --git a/tools/libs/guest/Makefile b/tools/libs/guest/Makefile
> > index 8f5f3acd21..1f4b7f7c58 100644
> > --- a/tools/libs/guest/Makefile
> > +++ b/tools/libs/guest/Makefile
> > @@ -103,8 +102,7 @@ NO_HEADERS_CHK := y
> >  
> >  include $(XEN_ROOT)/tools/libs/libs.mk
> >  
> > -libxenguest.so.$(MAJOR).$(MINOR): COMPRESSION_LIBS = $(filter -l%,$(zlib-options))
> > -libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(COMPRESSION_LIBS) -lz
> > +libxenguest.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += $(ZLIB_LIBS) -lz
> 
> Looking ZLIB vs the other compression libs, shouldn't -lz be inside
> $(ZLIB_LIBS) ?

I don't think so because -lz is also used by libxenhypfs for example,
and maybe go binding for libxl. It seems that the name of the variable
is misleading, as it seems that -lz is zlib but $ZLIB doesn't contain it
or anything that would be called zlib.

-lz is check explicitly by configure and fail if missing, while $ZLIB
can be empty.

> Also, shouldn't this be LDLIBS rather than APPEND_LDFLAGS ?

Yes, I think I'm doing that in a different patch.
    libs: rename LDUSELIBS to LDLIBS and use it instead of APPEND_LDFLAGS

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:26:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:26:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250519.431493 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziuC-0004PM-AK; Tue, 21 Dec 2021 17:26:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250519.431493; Tue, 21 Dec 2021 17:26:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziuC-0004PF-78; Tue, 21 Dec 2021 17:26:28 +0000
Received: by outflank-mailman (input) for mailman id 250519;
 Tue, 21 Dec 2021 17:26:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mziuA-0004P9-Td
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:26:26 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 1db661e1-6283-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 18:26:25 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1db661e1-6283-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640107585;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=3SB8VNGpH09J4DsV/MUYfNfzgo5i5lh1tdAvMj2ZDzc=;
  b=OeqzFZ9mEF6qvEJ7Pe2Sk4ieOLJqHbLh/Oe+hPbePA7jeQloRE7Cnq8h
   RGioZTj87pcSBLGFXw1l3ryinKUEpB7x5+z2VIUPnJs/R4vp9T8pBj7UV
   BFtJcfjUYHp2R2v27quag7S2pTY4oS/B9DAoZZELymFoC2a7p1zO7qocB
   w=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: nTtVF0yl2JT9To0kyOIL+yF2/loZ2iTHvQi4VWlsZ6WjsUvQz5zD2wBHLaoeu5AJ9Zu5iKJjX2
 3rrHdCnyh7cs22XIZJG+htapSBH49M/XpI2sUUnuq09Thd/dQohxvyNIatt095cUIecNMtj93J
 FzbKqyh8V6ZclUXfg4T5wMDw9csLKBEi6NnaxKLkkOM+aqoOt/XvHa42RamW5/fzIlJ78fOqTj
 6jknLrgJ5y/gAy0giy1ManHUN+1dVj9iGHX2dSmxzCmzlcfbooVwaFxFCBpGhJxwJgCcWZ8AtG
 qOjAq1ZUB7rf5H4zInwXQkCV
X-SBRS: 5.1
X-MesageID: 60024723
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:rTUDj6PJjb8qV+rvrR0PkMFynXyQoLVcMsEvi/4bfWQNrUojhmRRy
 jEXWmGEP6uDN2ryetoiaoW2oE9UvZXUx9ZlSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400g6w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozCiufdt4
 vVvjLu1ajgXZKidpKcTbBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9o3JwRR622i
 8wxdBsyPSmeQRJ2N0o5N5Bgu/WyikPEWmgNwL6SjfVuuDWCpOBr65DvLd7Ud9qiVchT2EGCq
 Qru/W70HxUbP9y30iee/zSngeqntTz/cJIfEvu/7PECqEaI2mUZBRkSVF26ifq0kEizX5RYM
 UN80jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL86gOSVzYsVSRKZpogudNebT011
 HeZktXxHzttvbaJD3WH+d+8pDWuOS8TPCkaaDUNVwct7NzqoYV1hRXKJuuPC4bs0IezQ2uph
 WnX8m5u3N3/kPLnyY2+1nbgnxiMhKHuSy0K2F/SD17m4Dx2MdvNi5OT1XDX6vNJLYC8R1aHv
 WQZl8X20N3iHa1hhwTWHrxTQejBC+KtdWSF3AUxR8VJGyGFoib7JehtDCdCyFCF2yruURvge
 wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiIP7KigbArLWdrGR2Cg2bKhwgBd2B2zskC1
 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bGPCTIFutfaQDUBgzc0E9iiF+Nm
 zq4H5HVoyizrcWkOnWHmWLtBQ1iwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp
 ynnMmcBkQKXrSSedW2iNyAyAJuyDM0XhS9qYkQR0aOAhiFLjXCHt/xEKfPavNAPqYRe8BKDZ
 6VfJpjbXK0QEm+vFvZ0RcCVkbGOvS+D3WqmVxdJqhBlJfaMniTFpY3peBXB7i4LAnblvMcyu
 eT4hAjaXYACV0JpC8OPMKCjyFa4vH48nuNuXhSXfokPKRu0qIU6eTbsivIXIt0XLUmRzDWty
 AvLUwwTovPAotFp/YCR17yEtYqgD8B3AlFeQzvA9b+zOCSDpjijzIZMXfymZzfYUG+oqqyua
 f8Ml6P3MeEdnUYMuI15Su45waU77trphrlb0gU7QymbMwX1UutteyDU09NOu6tBwq5ilTG3A
 k/fqMNHPbipOd/+FAJDLgQSceneh+ofnSPf7KppLRyitjN35reOTW5bIwKI1H5GNLJwPY4on
 bUhtcoR51DtgxYmKI/b3CVd9mDKJX0cSaQ38JodBdaz2AYsz1hDZ73aCzP3v87TO4kdbBFyL
 2/GnrfGipRd2lHGIig6GnX61OZAgYgD5UJRx1gYKlXVwtfIi5fbBvGKHejbmuiN8ih67g==
IronPort-HdrOrdr: A9a23:1flLMKOrjwnkAMBcTsGjsMiBIKoaSvp037Eqv3oedfVwSL39qy
 nOpoV/6faaslsssR0b9exofZPwJk80lqQFg7X5X43DYOCOggLBR+tfBMnZsl7d8kXFh4hgPM
 xbEpSWZueeMWRH
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60024723"
Date: Tue, 21 Dec 2021 17:25:36 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Andrew Cooper <andrew.cooper3@citrix.com>,
	"George Dunlap" <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
	"Jan Beulich" <jbeulich@suse.com>, Julien Grall <julien@xen.org>, "Stefano
 Stabellini" <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 22/57] tools/console: have one Makefile per
 program/directory
Message-ID: <YcIOEC0kNjMfCQUl@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-23-anthony.perard@citrix.com>
 <edcb690b-c21c-137f-0bda-79eda64a0164@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <edcb690b-c21c-137f-0bda-79eda64a0164@srcf.net>

On Thu, Dec 16, 2021 at 05:26:49PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > Sources of both xenconsoled and xenconsole are already separated into
> > different directory and don't share anything in common. Having two
> > different Makefile means it's easier to deal with *FLAGS.
> >
> > Some common changes:
> > Rename $(BIN) to $(TARGETS), this will be useful later.
> > Stop removing *.so *.rpm *.a as they aren't created here.
> > Use $(OBJS-y) to list objects.
> > Update $(CFLAGS) for the directory rather than a single object.
> >
> > daemon:
> >     Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
> >     Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
> > 	instead.
> >
> > client:
> >     Remove the unused $(LDLIBS_xenconsole)
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > ---
> >  .gitignore                    |  4 +--
> >  tools/console/Makefile        | 49 +++-------------------------------
> >  tools/console/client/Makefile | 39 +++++++++++++++++++++++++++
> >  tools/console/daemon/Makefile | 50 +++++++++++++++++++++++++++++++++++
> >  4 files changed, 94 insertions(+), 48 deletions(-)
> >  create mode 100644 tools/console/client/Makefile
> >  create mode 100644 tools/console/daemon/Makefile
> >
> > diff --git a/.gitignore b/.gitignore
> > index b39b996718..c31fa9b841 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -159,8 +159,8 @@ tools/libs/util/libxenutil.map
> >  tools/libs/vchan/headers.chk
> >  tools/libs/vchan/libxenvchan.map
> >  tools/libs/vchan/xenvchan.pc
> > -tools/console/xenconsole
> > -tools/console/xenconsoled
> > +tools/console/client/xenconsole
> > +tools/console/daemon/xenconsoled
> 
> $ git ls-files -- :/ | grep gitignore
> ../.gitignore
> ../tools/fuzz/cpu-policy/.gitignore
> ../tools/libs/.gitignore
> ../tools/misc/.gitignore
> ../tools/tests/cpu-policy/.gitignore
> ../tools/tests/resource/.gitignore
> ../tools/tests/tsx/.gitignore
> ../tools/tests/vhpet/.gitignore
> ../tools/tests/xenstore/.gitignore
> tools/kconfig/.gitignore
> xsm/flask/.gitignore
> 
> 
> We're starting to use per-dir gitignores, because it has far less
> problematic behaviour for code movement.

You mean "we", I don't think everyone agree we that yet ;-). They aren't
any "xen/.gitignore" yet, despite me trying to add one at some point.

> I think we ought to take this opportunity to clean things up for the better.

Sounds good to me, I'll make the change.

> > diff --git a/tools/console/client/Makefile b/tools/console/client/Makefile
> > new file mode 100644
> > index 0000000000..44176c6d93
> > --- /dev/null
> > +++ b/tools/console/client/Makefile
> > @@ -0,0 +1,39 @@
> > +XEN_ROOT=$(CURDIR)/../../..
> > +include $(XEN_ROOT)/tools/Rules.mk
> > +
> > +CFLAGS += -Werror
> 
> -Werror really ought to come from somewhere common, seeing as we expect
> it to be unilaterally set.

Yes. I think I'll also look at having "./configure --disable-werror" or
similar so -Werror could be easly disable, by for example someone
building an ancient release and not wanting to deal with warnings.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:30:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:30:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250524.431504 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziyM-0005w1-RP; Tue, 21 Dec 2021 17:30:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250524.431504; Tue, 21 Dec 2021 17:30:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mziyM-0005vu-OR; Tue, 21 Dec 2021 17:30:46 +0000
Received: by outflank-mailman (input) for mailman id 250524;
 Tue, 21 Dec 2021 17:30:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mziyM-0005vo-4r
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:30:46 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b973cbd8-6283-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 18:30:44 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b973cbd8-6283-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640107844;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=xn5qMGE+vmCZsSA3KdmK1gRo+2f/TDiBlrPIKST3Hoc=;
  b=Gc+IE/zVPa+aivt8CzMpDo714HSrtXChV779YNTA6TDRxLjVjrwxiLzs
   Zx6KddxMHV96ovEDzFMy+diRauc4p+EAPDAYnbgtBPRgmJt1Hx6VNmGjv
   PvItPzU8a253TCoYFhmFzX0fpHlXmeDj6D7DPWGAuQ8TaqZ5/MoNbHsmX
   g=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: sXRWb7X01lik0YtQ6l0RPMOfZQzNNmUvfAUgBAEmp4AlXu4gXDmEq+XIUZWm0r/5IwuoIXkP+Q
 NiOfpz5HOMyxUOoWuEaauYjk2G39vTxBcND6dzdG4NbeEf4FgYSc6ZO2FgXlI8pcpHnS67u/2k
 LTgBUOpamCe1DsyykoRxSMojX7K8uzB62wD4qs70PGYG4AXOkSJ5HutLva56dPVDAq5NW7l5tZ
 7iXskAuMFWDzQthpJPqqJpL5EvyUmqPbcURWoOdTRSErlqtc7Abe8fl1iTQGL3HmiSZiur1+Un
 ig0nkjeBUwx/kyoz7cI3ceF7
X-SBRS: 5.1
X-MesageID: 60920995
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:3iAwyau0JtVBbqNGeOg+MIZb3efnVNxZMUV32f8akzHdYApBsoF/q
 tZmKTjXa/ffazf2Ltx+aIzi8UwOvsXSzdVgQQFvqykzRXsR+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24HhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpljZqbVVkVJ5fwp8s/CDoIHgZRGpF90eqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DNYUDunZm3HfBAOwvW5zrSKTW/95Imjw3g6iiGN6AP
 5tDMWs+MXwsZTV/HQwKNZYVpdv3vVDwKw9pkHm4n6Eotj27IAtZj+G2bYu9lsaxbchRk0CR4
 H/I/mHlGRwEPfSY0zOO9n/qjejK9Qv6R4A6BLC+7uRtglCY2ioUEhJ+fUS/iem0jAi5Qd03A
 0UR8XtwhbMo/0LtSNThNzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMYwWTwt0
 E7Ph97zDCZjmLKQQHOZsLyTqFuP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLKKiekoPJAAvM/
 B+o9wtuipI8qvIw/vDulbzYuA6Eqp/MRw8zwwzYWGO58w90DLKYi5yUBUvztqgZctvAJrWVl
 D1dwpXFsrhSZX2YvHXVGL1lIV2/2xqS3NQwa3ZLFoJpyTmi8mXLkWt4sGAnfxcB3irplFbUj
 K7vVeF5uM470JiCN/Yfj2eN5yICl/CI+TPNDK+8Uza2SsItHDJrBQk3DaJq40jjkVI3jYY0M
 oqBfMCnAB4yUPo7lGLsGrhBi+ZwnEjSIF8/o7ihl3xLNpLEOxaopUotagPSPojVEovZyOkqz
 zqvH5TTkEgOOAEPSiLW7ZQSPTg3wYsTXvjLRzhsXrfbeGJOQTh5Y9eImO9JU9E1zsx9y7aTl
 lngCxAw9bYKrSCeQel8Qis4M+2HsFcWhS9TABHAyn70gSV+Otj2s/9EH3b1FJF+nNFeITdPZ
 6FtU6297j5nEFwrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp
 by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy
 x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR
 ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X
 ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52
 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf
 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
IronPort-HdrOrdr: A9a23:hQSU3aj/slAsiKRd+WnSDf6NgnBQXtgji2hC6mlwRA09TySZ//
 rOoB0+726StN9xYgBFpTnuAsW9qB/nmqKdpLNhW4tKPzOW3VdATrsSjrcKqgeIc0aVm9K1l5
 0QEZSWYOeAdGSS5vyb3ODXKbgd/OU=
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60920995"
Date: Tue, 21 Dec 2021 17:30:28 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	"Ian Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH 24/57] tools/debugger/gdbsx: Fix and cleanup makefiles
Message-ID: <YcIPNDlwv0do6BqC@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-25-anthony.perard@citrix.com>
 <ec048161-a117-36cf-b84f-e537a300d35b@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ec048161-a117-36cf-b84f-e537a300d35b@srcf.net>

On Thu, Dec 16, 2021 at 05:55:29PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
> > index 8d7cd94a31..4aaf427c45 100644
> > --- a/tools/debugger/gdbsx/Makefile
> > +++ b/tools/debugger/gdbsx/Makefile
> > @@ -28,7 +28,7 @@ uninstall:
> >  gdbsx: gx/gx_all.a xg/xg_all.a 
> >  	$(CC) $(LDFLAGS) -o $@ $^
> >  
> > -xg/xg_all.a:
> > +xg/xg_all.a: FORCE
> >  	$(MAKE) -C xg
> > -gx/gx_all.a:
> > +gx/gx_all.a: FORCE
> >  	$(MAKE) -C gx
> 
> Shouldn't these be in the sub Make's ?

No, this is how we tell make how to build some of the prerequisite
needed to build "gdbsx", we tell make that they are build in
sub-directory.

> > diff --git a/tools/debugger/gdbsx/gx/Makefile b/tools/debugger/gdbsx/gx/Makefile
> > -#%.o: %.c $(GX_HDRS) Makefile
> > -#	$(CC) -c $(CFLAGS) -o $@ $<
> > -
> > -gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS)
> > -	ar cr $@ $(GX_OBJS)        # problem with ld using -m32 
> > +gx_all.a: $(GX_OBJS) Makefile
> > +	ar cr $@ $(GX_OBJS)
> 
> There's probably an $(AR) we ought to be using.

Yes, I'll look at that.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:38:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:38:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250527.431515 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzj63-0006d2-KU; Tue, 21 Dec 2021 17:38:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250527.431515; Tue, 21 Dec 2021 17:38:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzj63-0006cv-HK; Tue, 21 Dec 2021 17:38:43 +0000
Received: by outflank-mailman (input) for mailman id 250527;
 Tue, 21 Dec 2021 17:38:42 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzj62-0006cp-Cg
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:38:42 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d50a50a8-6284-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 18:38:40 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d50a50a8-6284-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640108320;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=bu8rtrljl03Oq+iaUrFj+FfiU5UV7Aw1+cpQYDGTG1w=;
  b=FUlnWYIoYMfjvrktyxuqKbQXu9S11/UOOFGF2gFmgcZ9+MS08rWNHaBb
   hEr8OBRGEkq5Dq8r8ad+jc2i1siVyKuaHpqVKJstLM52YlwLvknQZQn1R
   fGPKzeicfffL/S33Bgq+b1OehwEX9Yt4e/IVhRc/JYA7Betas8XCH2rnf
   Y=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: hh0lzhWJVLc7f/7+++aq44HP3iQ5+Wf0HEqV2ztm71EgkVbR7ujVstqPg2TeABuGerNhojuktr
 cpDbre+MiNx8HS6XK7751T9TlNo3Bv6NBhMyCkqKJsAJNCUUqab/Pyg0RU66f/ilryW2LYg+qz
 e3FDLL/IxnxaDJ/hSxzPbXqGU3TCB+WZxwjIzXIRS8rVrU4/N+ykULrMjpL+VcmvInMaT/Utvf
 mlwlzhUHzFXppRoyNhkzm78Nlt4PEJaO+rBQNFnEoT7zP2Hj7TvAxInnoYG6w2c80znI4qygYK
 6Mi8HBSDAWbrEEIqPPq+7nJ4
X-SBRS: 5.1
X-MesageID: 60537529
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:edWRjaxGZd2kibPGVyx6t+fBwSrEfRIJ4+MujC+fZmUNrF6WrkUOn
 TMbUW6BbKuDNGv9eYggOdy380hXsMfSzdAwTgVv/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbRg2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/ZJl
 dYSkJeccgk4N5PWgstDdkl4LwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVors0lMMnsOpJZonx6xCvVJf0nXYrCU+PB4towMDIY2JgTRqmDP
 ZtxhTxHYT3yIBR3HAsuKtFgvuWn21fffjJdtwfAzUYwyzeKl1EguFT3C/LUZd6iVchThlyfp
 G/N4yL+GB5yHMOb4SqI9DSrnOCntSr9RIIVEqz+7vNwiUef7mMWARwSE1C8pJGRg0u1Cox3M
 FYf9GwooLRa3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi
 wHPz4iB6SFTXKO9b0rA9eixph+JNzkcE3UYSnEhHSs5yoy2yG0stS7nQtFmGa+zq9T6HzDs3
 jyHxBQDa6UvYd0jjPviow2e6964jt2QF1NuuF2LNo6wxlohPNbNWmC+1bTMAR+sxq69R0LJg
 nULktP2AAsmXcDUz3zlrAng8diUCxe53N/03Q8H83oJrW3FF5ufkWZ4umkWyKBBaJlsRNMRS
 BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QSOsArKVDbpng1PyZ8OlwBdmB2ycnT3
 r/BLq6R4YsyU/w7nFJauc9AuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimNYgEAFe/iFyNq
 b53bpLSoz0GCbGWSnSHoOY7cAFRRVBmVM+eliCiXrPaSuaQMDp6UKG5LHJIU9ENopm5Yc+Up
 CzgAREBlwKk7ZAFQC3TAk1ehHrUdc4XhRoG0eYEZD5EAlAvPtSi6rkxbZwyceV1/eBv16csH
 fIEZ9+BErJETTGeo2YRapz0rYpDchW3hF3RY3r5MWZnJ5MwFRbU/tLEfxf08HVcBCSAqsZj8
 aar0RnWQMRfSl06XtrWcv+m03i4oWMZxLBpR0LNL9QKIBfs/YFmJjbflPgyJ81QexzPyiHDj
 1SdAAsCpPmLqIgwqYGbiaeBpoavMu1/AksFQDWLsefobXHXpzPxz5VBXeCEeSHmeFn1oKjyN
 /9Iy/zcMeEcmAoYuYRLDLs2n7k14MHipuEGw108TmnLdVmiFphpPmKCgZtUrqRIy7JU5Vm2V
 0aI9oUIMLmFIpq4QlsYJQ5jZeWfz/AE3DLV6K1tckn94SZ2+puBUFlTYEbQ2HAMcuMtPdN32
 /olte4X9xe720gjPduxhyxJ83iBcy4bWKI9u5BGWILmh2LHEL2ZjUAw3sMu3KyyVg==
IronPort-HdrOrdr: A9a23:YHqc3q6mROkEgVGtkQPXwMjXdLJyesId70hD6qhwISY6TiW9rb
 HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM
 FdmsNFaeEYY2IUsfrH
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60537529"
Date: Tue, 21 Dec 2021 17:38:29 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH 25/57] tools/examples: cleanup Makefile
Message-ID: <YcIRFYqncDuHe4vC@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-26-anthony.perard@citrix.com>
 <76b1346c-b42b-46d7-943d-01019e95b60c@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <76b1346c-b42b-46d7-943d-01019e95b60c@srcf.net>

On Thu, Dec 16, 2021 at 05:57:43PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > diff --git a/tools/examples/Makefile b/tools/examples/Makefile
> > index 14e24f4cb3..48b520e133 100644
> > --- a/tools/examples/Makefile
> > +++ b/tools/examples/Makefile
> > @@ -26,10 +22,8 @@ uninstall: uninstall-readmes uninstall-configs
> >  
> >  .PHONY: install-readmes
> >  install-readmes:
> > -	[ -d $(DESTDIR)$(XEN_CONFIG_DIR) ] || \
> > -		$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> > -	set -e; for i in $(XEN_READMES); \
> > -	    do [ -e $(DESTDIR)$(XEN_CONFIG_DIR)/$$i ] || \
> > +	$(INSTALL_DIR) $(DESTDIR)$(XEN_CONFIG_DIR)
> > +	set -e; for i in $(XEN_READMES); do \
> >  	    $(INSTALL_DATA) $$i $(DESTDIR)$(XEN_CONFIG_DIR); \
> 
> Hmm.� Do we need a shell loop here at all?� Can't $(INSTALL_DATA) take
> multiple $i's at the same time?

Probably, even if the only time they are multiple filed install by
INSTALL_DATA in our build system is when shell globing is involve.
So, it's probably fine to remove the loop.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:45:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:45:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250531.431526 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjCr-0008Ej-Es; Tue, 21 Dec 2021 17:45:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250531.431526; Tue, 21 Dec 2021 17:45:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjCr-0008Ec-Bx; Tue, 21 Dec 2021 17:45:45 +0000
Received: by outflank-mailman (input) for mailman id 250531;
 Tue, 21 Dec 2021 17:45:43 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzjCp-0008EW-Fs
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:45:43 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cff0a297-6285-11ec-9e60-abaf8a552007;
 Tue, 21 Dec 2021 18:45:41 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cff0a297-6285-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640108741;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=N1jtymTyzz325UlEs+2YAvvRcH+N+hxLqQoIzjbdzDs=;
  b=KFUnDfLxf8zRu5crGiRJQnoob8DI+y3cklionPDFDa2a6gU1H2SzLVYO
   +Q52Puv59rpiyeHRi6vlHeB5BS9Oi9W4NYJE/RYEI0Xlc1TTh5h1YIVfY
   2V3FuakIA3X/CqXPfSRP+wvM2Hh4r6fJ8d+YvesiVM7xzLMps17nzlDOP
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: zL6hvQGY+WVLsZaQ31bBFQ+u8GDBMhb99p365OQ9nVmdD/nHuZKfl+FsZdOZP706NKmi3qU4tQ
 pPkW2NipI11n3YaUv3g5IbfwxJPOqHD/ZtNGuuN58CUH6a3WNK97xJt/kyxt88Xl/fQz2Yr0i1
 TQkTUb0TtSlUJASaG0PmFifFz2+8Cx9Uh2opRKW23dqP8jDqCQ4Tqdvw+Y+MFL8fuQffpI4JfL
 ieRr8ZZYo8Zjnyk6G9Yo3sjP6/QTKRKbHsEHesLaCMiGlSYaZ0WjsYwVZ+V6laiIoIfBHu+Fyw
 eAJg6izuy9lBa4AfilmcdZ4v
X-SBRS: 5.1
X-MesageID: 60922121
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:lJt/RqnWLQ2EtB/O+SKl2D/o5gwCIURdPkR7XQ2eYbSJt1+Wr1Gzt
 xIeCGDVbPqKMWT0KdxyYIS/9h8P7ZDcy4RrSwRvryxkEyMWpZLJC+rCIxarNUt+DCFioGGLT
 Sk6QoOdRCzhZiaE/n9BClVlxJVF/fngqoDUUYYoAQgsA180IMsdoUg7wbdg2NQx2YPR7z6l4
 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc
 s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4
 IpHpb20aTY4B4n3lvoFfQNZGB5OOKITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq
 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQ66PP
 ZBAM2MHgBLoYS9eNHcbKMsEvPaYg3TFKRty8FS0qv9ii4TU5FMoi+W8WDbPQfSIT8hImkeTp
 krd4n/0RBodMbS31j6t4n+qwOjVkkvTWZ0QPK218OZwh1+ezXBVDwcZPXOypPLo1GalQdlRb
 UoZ5kIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6QAHQESThQLsQrrsYsSRQl0
 1aIm5XiAjkHjVGOYSvDrPHO92r0YHVLaz9ZDcMZcecby4bpsKA3riPed/JYHrCtoMf0Eg7Ax
 j/f+UDSmI4vpcIM0qy6+3XOjDStuoXFQ2YJ2+nHYo62xlgnPdD4PuRE/XCetK8dd9jBEjFtq
 VBdw5DGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGppVEdMKS
 BWK0e+02HO1FCHyBUOQS9juY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ
 c/DK5vzUSxDUv4PIN+KqwE1i+dDKscWnzy7eHwG507/jer2iIC9FN/pz2dinshmtfjZ8W05A
 v5UNteQygU3bQENSnK/zGLnFnhTdSJTLcmv86R/L7ffSiI7SDBJI6KAmtsJJt0695m5Y8+Vp
 xlRrGcDkwGh7ZAGQC3XAk1ehETHAcwi8CllZHN0Zj5FGRELOO6S0UvWTLNvFZFPyQCp5aUco
 yAtd5rSD/JRZC7A/jhBP5DxoJY7LEaghB6UPjrjaz86JsYySwvM897iXw3u6ChRUXbn6Zpg+
 +WthlHBXJ4OZwV+F8KKOvih+Ey84CoGk+VoUkqWftQKIBfw8JJnIjDah+MsJ51eMg3KwzaXj
 l7EARoRqeTXjZUy9d3F2fKNo4uzSrMsFUtGBWjLq72xMHCCrGakxIZBVseOfCzcCzyoqPnzO
 70NwqilYvMdnVtMv45tKJpRzPozt4n1urtX7gV4B3GXPV6lPaxtfyud1s5Vu6wTmrIA4VmqW
 liC88VxMKmSPJ+3C0YYIQcoY7jR1fwQnTWOv/05LF+juX1y9buDF05TIwONmGpWK74saNEpx
 uIoucg37Q2ji0V1boba334Mr2ncfGYdV6gHt40BBN65gwUm/VhOfJjAB3Kk+5qIcdhNbhEnL
 zL8aHAuXFiAKp4uq0YOKEU=
IronPort-HdrOrdr: A9a23:PkgLXKAxVv1R65LlHemU55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P
 xG+85rsyMc6QxhPE3I9urtBEDtexzhHNtOkPAs1NSZLWzbUQmTXeJfBOLZqlWKcUDDH6xmpM
 VdmsBFeaXN5DNB7foSjjPXL+od
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60922121"
Date: Tue, 21 Dec 2021 17:45:32 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper
	<andrew.cooper3@citrix.com>, Roger Pau =?iso-8859-1?Q?Monn=E9?=
	<roger.pau@citrix.com>, Wei Liu <wl@xen.org>, Ian Jackson
	<iwj@xenproject.org>
Subject: Re: [XEN PATCH 26/57] tools/firmware/hvmloader: rework Makefile
Message-ID: <YcISvBKAUY25XGIp@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-27-anthony.perard@citrix.com>
 <d10d6034-f0a3-12fd-47f6-daf3333dc5c4@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d10d6034-f0a3-12fd-47f6-daf3333dc5c4@srcf.net>

On Thu, Dec 16, 2021 at 06:03:54PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > Setup proper dependencies with libacpi so we don't need to run "make
> > hvmloader" in the "all" target. ("build.o" new prerequisite isn't
> > exactly proper but a side effect of building the $(DSDT_FILES) is to
> > generate the "ssdt_*.h" needed by "build.o".)
> >
> > Make use if "-iquote" instead of a plain "-I".
> 
> So I've read up on what this means, but is it really that important in
> the grand scheme of things?

It something that Jan proposed to do in some cases in the hypervisor
build system. I thought it was something good to do so I start using
-iquote in the toolstack as well.

> Can't we actually make our problems go away by turning libacpi into a
> real static library?� (Also, the "kill hvmloader plans" will turn
> libacpi back into only having one single user, so that too)

Well, libacpi also have some headers that needs to be generated, so I'm
not sure which problem are going away when turning it into a static lib.
Also, I don't think hvmloader and libxl would want the same library.

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:46:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:46:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250533.431537 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjDK-0000JI-OK; Tue, 21 Dec 2021 17:46:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250533.431537; Tue, 21 Dec 2021 17:46:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjDK-0000JB-KY; Tue, 21 Dec 2021 17:46:14 +0000
Received: by outflank-mailman (input) for mailman id 250533;
 Tue, 21 Dec 2021 17:46:13 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzjDJ-0000It-HY; Tue, 21 Dec 2021 17:46:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzjDJ-0006Am-FA; Tue, 21 Dec 2021 17:46:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzjDJ-00040a-4e; Tue, 21 Dec 2021 17:46:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzjDJ-0003HL-4D; Tue, 21 Dec 2021 17:46:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zXtbOGdNCNiFvyFgpVEbrhq+onZvS+MLx8WwCTn/tno=; b=CUDFknqYMqzCb7uJ5fKQaevRGa
	GjJ7/YrDs30OhayhN5FmLYuA/q/hjaRFX9T/mjFQf+vtYA2gD1km+cKwxi/leic1aYnO2sHZohTdF
	K+7WqCNp+/6fiaTCrOQLAtvC0bqXIX0iCs6Zcs5wGbP34qAYKBmX/htZbttCf9taVwpE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167500-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167500: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=6e0567b7305209c2d689ce57180a63d8dc657ad8
X-Osstest-Versions-That:
    linux=86085fe79e3c1a66e32f2acae0ae64f4cceb8d28
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 17:46:13 +0000

flight 167500 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167500/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167495

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167495
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167495
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167495
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167495
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167495
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167495
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167495
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167495
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167495
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                6e0567b7305209c2d689ce57180a63d8dc657ad8
baseline version:
 linux                86085fe79e3c1a66e32f2acae0ae64f4cceb8d28

Last test of basis   167495  2021-12-20 21:12:11 Z    0 days
Testing same since   167500  2021-12-21 05:30:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Gunthorpe <jgg@nvidia.com>
  Jiacheng Shi <billsjc@sjtu.edu.cn>
  José Expósito <jose.exposito89@gmail.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Wenpeng Liang <liangwenpeng@huawei.com>
  Yangyang Li <liyangyang20@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   86085fe79e3c..6e0567b73052  6e0567b7305209c2d689ce57180a63d8dc657ad8 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 17:59:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 17:59:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250543.431548 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjQ1-0002Dm-UX; Tue, 21 Dec 2021 17:59:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250543.431548; Tue, 21 Dec 2021 17:59:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjQ1-0002Df-RK; Tue, 21 Dec 2021 17:59:21 +0000
Received: by outflank-mailman (input) for mailman id 250543;
 Tue, 21 Dec 2021 17:59:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzjQ1-0002DZ-1d
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 17:59:21 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b67d5bac-6287-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 18:59:18 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b67d5bac-6287-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640109558;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=MWaXm4MaAdY1eC5fm5cMVLglGzsjnHHOwvVMIjmLtLM=;
  b=Iqac69plWh4rtkVvjjeDeKqeS559J9WQ715CmgYKqIetFEu51n9pWCF4
   IEoALoaWH/F/XZjMfBz2OGAgROAcn7ex3wY7FsuWiiy7Y7NxxAhp96h6K
   IZPFNlAqxdgTsAorwr4giMxnF769q8WTDLa4biSxC/IHgldewJOJ0dInu
   U=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: KxFlsOZ6bsiFzCavI6Zpe4RZh+At8PEn/TOfL3tW2vaEp7gCdB4pneAJRj26OszjC5TgqEThBB
 hY0bOaYlj/KZWLYDG1fmmaA3Du7wWuMATIFv20KmducIjE4HiWW0WM60N4mcDIqDxS2sD0ESU0
 RMIYqmpaARkxRt6jzuJmvhFE1Md23E1AjYrLBldMwF13nrvHeyxRBSkiWfScjMZS4XVmNFWA2m
 rVsgAEmjyOexlkza5GfakHXXK8mOQsFybAQgfVfW0zxT5fiu/GnBJqNe5fBYVuyti0JjSuPE2z
 Wh6XfwAAZjW0SprvZHy01aA+
X-SBRS: 5.1
X-MesageID: 60468344
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:yH8Qg6PqQecBHSLvrR1UkMFynXyQoLVcMsEvi/4bfWQNrUoj1TFRx
 zQXUGGCPq7ZM2X0Ktlzb46/9EwHupXWnNUxHgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400g6w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozOmxvBh0
 IUVjMyxYjsrMLXztdY4SgYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YuBqmsQkKtitJI4Fs2ts5TrYEewnUdbIRKCiCdpwgm9s2JAVQaq2i
 8wxdRBkVB/SRhdzNHhKCYgngru6gUbGWmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu
 iTB5WuRKg4eHMySz3yC6H3ErubJgSP8XpNUDLCi/+RmqFKWz20XThYRUDOTo/ajjVWlc8lCM
 EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZmcfMpp87pZwHGF0k
 A/S9z/0OdBxmLu6EFKN7ufMlGOzEhQXI3c9SB0hVBRQtrEPv7oPph7IS99iFou8gdv0BSz8z
 li2kcQuu1kApZVVjvvmpDgrlxrp/8GUFVBtum07S0r8tlshDLNJcbBE/rQyARxoCI+CBmeMs
 3Ef8yR1xLBfVMrd/MBhrQhkIV1I2xpnGGGN6bKMN8N4n9hIx5JFVdoIiN2ZDB02WvvogRezP
 CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMoIWOMUuKFXep3sGiausM4bFyhBEfUYXY
 8jzTCpRJSxCVfQPIMSeGo/xLoPHNghhnDiOFPgXPjys0KaEZW79dFv2GADmUwzN14vd+F+92
 48Gb6OikkwDOMWjMni/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9yr2Vo
 yrjAxAAkzISRxTvcG23V5yqU5u3Nb4XkJ7xFXZE0Y+A1ydxbICxwr0YcpdrL7Ar+PY6lax/T
 uUfetXGCfNKE2yV9zMYZJj7jYpjaBX02l7eY3v7OGAyL8x6WgjE2t74ZQ+zpiMAOTW66Jklq
 Lq62wKFHZdaH1Z+DNzbYe6Exk+quSRPg/p7WkbFe4EBeEjl/IVwBTb2i/s7f5MFJRnZn2PI3
 AeKGxYI4+LKptZtotXOgKmFqaavEvd/QRUGTzWKs+7uOHCDrGS5wIJGXOKZRhznVTv5qPe4e
 OFY7/DgK/lbzlxEhJVxTuRwxqUk6tqx+7IDllZ4HG/GZkiAA697JiXUxtFGs6BAy+MLuQayX
 U7TqNBWNa/QZZHgGV8VYgEkcv6CxbcfnTyLtaY5J0Dz5SlW+rubUBoNY0nQ2XIFdLYlYpk4x
 eoBudIN713tgxUnBd+KkyRI+jneNXcHSagm6skXDYKDZtDHEb2ejUgw0hPL3aw=
IronPort-HdrOrdr: A9a23:8veenay6BtuMpjYloiI4KrPw3L1zdoMgy1knxilNoHxuH/BwWf
 rPoB19726StN9xYgBFpTnkAsO9qBznmqKdjbN+AV7AZniChILLFvAA0WKK+VSJdxEWntQ36U
 4KSdkdNDSfNzlHZcaR2njFLz4jquP3j5xBU43lvglQpQIBUdAQ0+9gYDzrdHGf3GN9dOAE/J
 z33Ls/mxOQPU45Q+6cHXc/U+3Kt7Tw5e/biU5vPW9e1OGW5wnYk4LHLw==
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60468344"
Date: Tue, 21 Dec 2021 17:59:11 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Juergen Gross <jgross@suse.com>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>
Subject: Re: [XEN PATCH 41/57] libs: Remove need for *installlocal targets
Message-ID: <YcIV71oLtJQEvLSE@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-42-anthony.perard@citrix.com>
 <bc5bc497-d1a0-007a-802f-e411159fb88e@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <bc5bc497-d1a0-007a-802f-e411159fb88e@suse.com>

On Tue, Dec 07, 2021 at 02:20:29PM +0100, Juergen Gross wrote:
> On 06.12.21 18:02, Anthony PERARD wrote:
> > There is no need for an extra "installlocal" target, we can use
> > double-colon rules instead.
> 
> Doesn't that mean that with the ultimate goal of including all
> Makefiles of the tree that all "install" and "uninstall" rules in the
> tree will have to be double-colon rules?

So, the install targets will be double-colon but for a different reason
(because of the framework been used). All the "install" target will
actually have different name, they will be prefixed by the name of the
directory where the Makefile is.

For example, "install" in "xl" will be named "xl/install", but there
will be something that will allow to run "make -C xl install" which will
call the rule "xl/install".

> With above remark I don't see how tools/libs/stat/Makefile can be left
> unmodified, as it includes libs.mk and it contains an "intall:" rule.

I've missed that one, just because ./configure doesn't allow to enable
the binding...

Thanks,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 18:03:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 18:03:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250549.431559 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjUA-0003k2-KI; Tue, 21 Dec 2021 18:03:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250549.431559; Tue, 21 Dec 2021 18:03:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjUA-0003jv-GJ; Tue, 21 Dec 2021 18:03:38 +0000
Received: by outflank-mailman (input) for mailman id 250549;
 Tue, 21 Dec 2021 18:03:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=f1Ud=RG=citrix.com=anthony.perard@srs-se1.protection.inumbo.net>)
 id 1mzjU9-0003jp-70
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 18:03:37 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 50300fdb-6288-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 19:03:35 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 50300fdb-6288-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640109815;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:content-transfer-encoding:in-reply-to;
  bh=MQX2LlmddlrhD3qhTHN+iApvoQmjpliLZsH1M6xt0QY=;
  b=FhysBzoX2cSCTpBov/aBom7UwN5yL+nzQlu8zBqJBKz7p/1WdfuA2wTn
   Gr+SHdGH4NBHudPwLciDGxxQVQHXdJmYP671pEM961sHS6yEUPk0HUpEI
   EIolrsx1k8/9grQZ4B4P44ya6Rv11D5k1VKL7p+CY1Sw1waLkTfVt35CT
   8=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: o6wGqAPjT4pAwDBjR51MdeKoAdAbtXAe1T6yYxdU0Btn7dxA0Dlnc/05RIa8rPp56yrxlzwsWr
 0gRd8s1MZJ4f+lg+Ho/KUPBFuAoUwuSgo2ivjIEecsLQ0eaw0Ye+ze60HAF02XlMHJyKjp/zxz
 7qF9k+t8Ec7vArFD7kzohP4e5Dpad0guBG9Wrr3rmnokCZoZtKyzohQt6JRO7df1u9UmFw0II0
 IFxbRiwb1LGe3x9UYw9T4JmXY05DI2hRISEh4xw/XHEkNNbcIsyPmnRpu9iHLQM5VoHPUjVt1W
 CEbqL4OOgYQ4F7V4XRy4WJ+a
X-SBRS: 5.1
X-MesageID: 62621915
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:PPsgB67h4ZnRsyVXxNcxPwxRtLnAchMFZxGqfqrLsTDasY5as4F+v
 mMbWD/TMvzeMzGhLo90bduz/RkBupKByYIyQQJtrHsyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj2Ncw2rBVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zm
 Y9tlb6JYi4QNaD8ku0NFEgCFj5/MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gQR6iEP
 ptANFKDajz9bxhBeUwXDKsy37auqkLuXDR0sm2K8P9fD2/7k1UqjemF3MDuUt2VR+1Fk0CAv
 GXE8m/lRBYAO7S31j6t4n+qwOjVkkvTWo0IE6aj3uV3m1DVzWsWYDUfUFDq/9GikEWwHdRSN
 yQ86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLd5RqZAW4VCCZMctU8uOc5QDUr0
 hmCmNaBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZVpfw/nBmaoatxnCftxqAOnk1NjqGD6ll
 lhmsxMCr7kUiMcK0YCy8lbGny+gq/D1c+Il2unEdjn7t10kPeZJc6TtsAGGtqgYcO51W3HY5
 CBc8/Vy+tziGn1keMalZOwWVI+k6P+eWNE3qQ4+RsJxn9hBFpPKQGyx3N2cDBs4WirnUWWwC
 KM2he+3zMULVJdNRfUoC79d8+xwkcDd+S3ND5g4lOZmbJlrbxOg9ypzf0OW1G2FuBFyzflnY
 8rELZz1Vixy5UFbINyeHb91PVgDnH9W+I8ubcqjk0TPPUS2ORZ5tovpwHPRN7tkvctoUS3e8
 spFNtvi9vmseLaWX8UjyqZKdQpiBSFiXfje8pULHsbeclsOMDxwUJf5nOJ+E7GJaowIz48kC
 FnmARQGoLc+7FWaQTi3hodLNOmyAM0h9C1jZkTB/z+AghAeXGpm149HH7NfQFXt3LcLISdcQ
 6ZXdsOeLO5ITzibqT0RYYOk9N5pdQixhBLINC2gOWBtc5llTg3P29nlYgqwq3VeUnvp7ZMz8
 ++6ywfWYZsfXAA+XszYX+2ikgGqtn8HleMsA0aReotPeF/h+ZRBIjDqiqNlONkFLBjOn2PI1
 wufDRoCi/PKpos5rIvAiaye9t/7GOpiBEtKWWLc6O/uZyXd+2Oix65GUfqJIm+BBD+lpv36a
 LwMnf/mMfABkFJbiKZGEu5mnfAk+t/ih75G1QA4Tn/FWEumV+F7KX6c0MgR6qAUnu1FuRG7U
 16k88VBPenbI9vsFVMcKVZ3bumH0v1IyDDe4e5sfRf/7S5zurGGTV9TL1+HjykEdOl5N4Ysw
 OEAvs8K6lPg1kp2Y4je1i0EpX6RKnEgUrk8ssBICYDmvQMn11VebMGOESTx+pyON41BP0RCz
 uV4X0Yea2CwHnb/Tkc=
IronPort-HdrOrdr: A9a23:+4jflKnFLcmI0cjYR/z5bYNKbxTpDfIq3DAbv31ZSRFFG/Fxl6
 iV8sjz8SWE7Ar5P0tQ/uxoWZPwJE80mqQZ3WB8B9uftUzdyQ2VxeJZnOnfKl/bexEWn9Q1vc
 wLT0E9MqySMbETt7eC3ODSKbcdKbe8n5yVuQ==
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="62621915"
Date: Tue, 21 Dec 2021 18:03:12 +0000
From: Anthony PERARD <anthony.perard@citrix.com>
To: Andrew Cooper <amc96@srcf.net>
CC: <xen-devel@lists.xenproject.org>, Anthony PERARD
	<anthony.perard@gmail.com>, Ian Jackson <iwj@xenproject.org>, Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [XEN PATCH 47/57] libs/stat: Fix and rework python-bindings build
Message-ID: <YcIW4E5d+EHGV+sB@perard>
References: <20211206170241.13165-1-anthony.perard@citrix.com>
 <20211206170241.13165-48-anthony.perard@citrix.com>
 <edc0491b-a778-0ca1-88c6-c7076db3a14b@srcf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <edc0491b-a778-0ca1-88c6-c7076db3a14b@srcf.net>

On Thu, Dec 16, 2021 at 06:47:17PM +0000, Andrew Cooper wrote:
> On 06/12/2021 17:02, Anthony PERARD wrote:
> > Fix the dependency on the library, $(SHLIB) variable doesn't exist
> > anymore.
> >
> > Rework dependency on the include file, we can let `swig` generate the
> > dependency for us with the use of "-M*" flags.
> 
> Hmm.� At no point is swig mentioned in README/etc, and it's not in any
> of the CI logic.� I wasn't even aware that we had python bindings here.
> 
> Unless someone tries and confirms them not to be broken, I'd be tempted
> to drop it all.� I bet this has been dead since we dropped Xend.

How about the perl binding? Nothing to do with xend for them.

The only way to build the binding is to set a variable. It's not
possible to enable the binding via ./configure at the moment. So, yes,
maybe no one uses them.

Cheers,

-- 
Anthony PERARD


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 18:19:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 18:19:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250553.431569 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjjM-0005Ph-0W; Tue, 21 Dec 2021 18:19:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250553.431569; Tue, 21 Dec 2021 18:19:19 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzjjL-0005Pa-TE; Tue, 21 Dec 2021 18:19:19 +0000
Received: by outflank-mailman (input) for mailman id 250553;
 Tue, 21 Dec 2021 18:19:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=9qtw=RG=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1mzjjJ-0005PU-SC
 for xen-devel@lists.xen.org; Tue, 21 Dec 2021 18:19:17 +0000
Received: from mail-io1-f46.google.com (mail-io1-f46.google.com
 [209.85.166.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 81550fe5-628a-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 19:19:16 +0100 (CET)
Received: by mail-io1-f46.google.com with SMTP id z26so18763060iod.10
 for <xen-devel@lists.xen.org>; Tue, 21 Dec 2021 10:19:16 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81550fe5-628a-11ec-bb0b-79c175774b5d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=lDlfNhDCr4ohIGOVlzAAXPJw620YBKRYu7z6otJRRqo=;
        b=GZ2tcSgVyh42LN23MarqaNcX4TPV7atVeU2oPlNLEZLHq2ApbA3AGEvZmjQRxDsPOL
         mm246/dOxROrFDHCWpEBnqvQXhySNBkqxwdI9bj/M4irwZ5FJZ9gPAqsx4KQZ0DiL+DG
         lB198IUgCsQPHRroAr6wu8QCadZlM1JRe22UBkqoRxdH7fc7ylRVrRwfLgdgBOs4luyo
         kW4BC2v9E2SG57apOmKQUnG/SS5b3PvuuBCxSHPEOv9G31DDiSzijmEacfMi5lgWID1T
         71ru9ZwyvBwZ6h1N2YyqYehLLD+IuwaoObwo1Ln8EpdnFUO/eJQY0aF61LcZJC69zfcG
         ffOg==
X-Gm-Message-State: AOAM531PBSEU3Fdk2EzgHbFm81nhy+Rn9J3cvV4rcXXQjq3MUXwmqJDB
	ZCjv8nIh0tsQxqVcaKWeyOJ3EWicDU9pCSxH8Ec=
X-Google-Smtp-Source: ABdhPJw9kK6GIdqU+VGH8k3QRZaYrwVr2GgW50MNN73utoaTGpsAs7UdysR7LSzU6J+BsoJ5GaC0gFVs++jSwVTX3IU=
X-Received: by 2002:a05:6638:2055:: with SMTP id t21mr985394jaj.298.1640110755202;
 Tue, 21 Dec 2021 10:19:15 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com> <YcHbuug9AECvKXm9@Air-de-Roger>
In-Reply-To: <YcHbuug9AECvKXm9@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Wed, 22 Dec 2021 02:19:03 +0800
Message-ID: <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

> > I omitted all operational details with the assumption that you are familiar
> > with TrueNAS and iSCSI setup.
>
> Not really. Ideally I would like a way to reproduce that can be done
> using iperf, nc or similar simple command line tool, without requiring
> to setup iSCSI.
I think it would be tricky then. The problem hide itself well enough
that I wasn't
aware soon after upgrading since everything else works flawlessly --
nfs, ssh, web etc.

> Can you also paste the output of `ifconfig xn0`?
Here it is:
xn0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
    options=503<RXCSUM,TXCSUM,TSO4,LRO>
    ether 00:18:3c:51:6e:4c
    inet 192.168.1.9 netmask 0xffffff00 broadcast 192.168.1.255
    media: Ethernet manual
    status: active
    nd6 options=1<PERFORMNUD>

>
> If I provided a patch for the FreeBSD kernel, would you be able to
> apply and test it?
Probably. I did this before when your XEN support for freeBSD was not
available out-of-box.
Just need to recreate all the required environments to apply the patch.

BTW, uname -a gives me the following;
>12.2-RELEASE-p11 FreeBSD 12.2-RELEASE-p11 75566f060d4(HEAD) TRUENAS  amd64

Thanks,
Timothy


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 18:54:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 18:54:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250558.431581 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzkGi-0001c2-OC; Tue, 21 Dec 2021 18:53:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250558.431581; Tue, 21 Dec 2021 18:53:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzkGi-0001bv-KJ; Tue, 21 Dec 2021 18:53:48 +0000
Received: by outflank-mailman (input) for mailman id 250558;
 Tue, 21 Dec 2021 18:53:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzkGh-0001bl-BJ; Tue, 21 Dec 2021 18:53:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzkGh-0007Nu-86; Tue, 21 Dec 2021 18:53:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzkGg-0007Lu-SZ; Tue, 21 Dec 2021 18:53:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzkGg-0003is-Nl; Tue, 21 Dec 2021 18:53:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HW+ft5ZdmVzmURDFTtFujQiDuNWd17T731/tzoZVx6Q=; b=k2mKc5PQ3cUBQv9QNGHb9iwl7E
	GNdH1FNxtB4pG8mb6tLpIXAt2l5bF2lMHlUhDOO5/2H41wCuXE/RQOWIENl622j3Guyhtva2perc+
	vz5aCvFDZ3SCWYQ7z2t9hvIcjuNgGUs11tryb0Zhy1f+5UtE/oMLGRw7ys2LwmsAD4E4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167501-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167501: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=2bf40d0841b942e7ba12953d515e62a436f0af84
X-Osstest-Versions-That:
    qemuu=c7d773ae49688463b59ade6989f8d612fecb973d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 18:53:46 +0000

flight 167501 qemu-mainline real [real]
flight 167507 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167501/
http://logs.test-lab.xenproject.org/osstest/logs/167507/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 12 debian-di-install   fail pass in 167507-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 167507 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 167507 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167496
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167496
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167496
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167496
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167496
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167496
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167496
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167496
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                2bf40d0841b942e7ba12953d515e62a436f0af84
baseline version:
 qemuu                c7d773ae49688463b59ade6989f8d612fecb973d

Last test of basis   167496  2021-12-20 21:38:07 Z    0 days
Testing same since   167501  2021-12-21 06:49:30 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   c7d773ae49..2bf40d0841  2bf40d0841b942e7ba12953d515e62a436f0af84 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 19:13:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 19:13:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250566.431592 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzkZI-0004Gv-Bb; Tue, 21 Dec 2021 19:13:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250566.431592; Tue, 21 Dec 2021 19:13:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzkZI-0004Go-7g; Tue, 21 Dec 2021 19:13:00 +0000
Received: by outflank-mailman (input) for mailman id 250566;
 Tue, 21 Dec 2021 19:12:59 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=w49/=RG=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1mzkZH-0004Gi-2F
 for xen-devel@lists.xen.org; Tue, 21 Dec 2021 19:12:59 +0000
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com
 [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffd6d7b5-6291-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 20:12:56 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffd6d7b5-6291-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640113975;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=J9NYbu/kHOPgj3IhyBA9pq9cWrzYyWuHrP+Oarrq1Os=;
  b=Cl0lsHSekpyv2IrmftrCXNPYYylqSkKALYTfU98Zr8TM8V2pX3V3gaYc
   CFjbGZlnslPloGPWtttB4+RmGDp8UO/QVqiBtHD6ToETx6o8CKGzN/fL3
   5eVU7BbE6gP6e2hVpjfgf3/GY/v5BBxPJeZWrj8nBaluZvt/zPLu8QZud
   k=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: /S3n8RiVb1RLYUV4Ld5A+Og+9p3VApUCnCx1lKB7ssGMHR7K3CKMfyJM8K7wcmzO5QXUNLSe0H
 QWalU54Mig6/Pwo20eAuBoTXbb3HcREoq+wAQv06XkWMtRfEBiGJZ92+8GG1vhPbXHX0HPqzky
 PKWr3XIisiGc0sYE/SrQoPoPMCfESqsxfh9SdXsFKYVB0RER9uYtJIADmVMxU6FGAVl26oYYPy
 b6odSz+IMwtzi4Ivxno5g8moDJjIjppZKRPT3XPBF5lbir7HzYTkMVIS+h26F0fIrbQGCB60IG
 DRzYnmT6s7/+hqP4+YkJtm37
X-SBRS: 5.1
X-MesageID: 60033516
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:eRFOHqyU/Fd/NNYScGR6t+fkwSrEfRIJ4+MujC+fZmUNrF6WrkUDx
 jNLUWGFaPbZN2SnKN8gPti3/UJQsZGHmoJrSAQ9riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx
 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500s6wbRg2tUAbeWRWGthh
 /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL
 wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt/Fty
 8tdrZmgdTkSLLbXs9YEURoJQwgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr
 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEAhGxr25kQdRrYT
 9AHWB1WUzbmXwBeHFctVo8etqS2nFCqJlW0r3rK/PFqsgA/1jdZwLXrddbYZNGObcFUhVqD4
 HLL+SL+GB5yHNKe0zeA/26hgfXngDj2QplUD7ql7PVnjlqJyWFVDhAKPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPHcQx6msGaBriIiYMhLCMYI8QOOm/r9tlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL+dlr1nryosBf/LlZZzEfMRX52
 Hi0oSc3nN3/ZuZbhvzgrTgrb99Bz6UlrzLZBC2LDwpJDSsjPeZJgrBED3CBtZ6sy67DETG8U
 IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWj1oyT+ItwKuWokTKuMDiriUWWxC
 KM0kVkOjKK/wVPwNfMnC25PI5lCIVfc+STNCamPM4smjmlZfw6b5iB+DXN8LEi2+HXAZZoXY
 M/BGe71VC5yIf0+kFKeGrdMuZd2l3tW7T6CGvjGI+GPjOP2iIi9EuxebjNjr4kRscu5neki2
 4oFapbRlUwACLaWj+u+2dd7EG3m5EMTXPjeg8dWavSCMkxhHmQgAOXW2rQvZ8pumKE9qwsC1
 ijVtpZwxAWtiHvZBx+Nb3w/OrrjUYwm9SAwPDA2PEbu0H8mON794KAafpoxXL8m6O08kqIkE
 6hbI52NUqZVVzDK2zUBdp2h/oZsQwum2FCVNC2/bTlhI5M5H17V+sXpdxfE/TUVCnblrtM3p
 rCtj1uJQZcKSwl4ItzRbfajkwG4sXQHwbogVErUONhDPk7r9dEyeSD2i/Y2JeAKKAnCmWTGh
 1rHX09AqLCU8YEv8dTPiaSVlKuTErNzThhAAm3WzbeqLi2GrGCt9pBNDbSTdjfHWWKqpKj7P
 bdJz+vxOeEslUpRt9YuCK5iyK8z6oe9p7JeyQg4TnzHY07yV+FlK3iCm8JOqrdM1vlSvg7vA
 hCD/dxTOLOoPsL5EQFOeFp5P7rbjfxEyCPP6fkVIVnh4H4l9bWKZkxeIh2QhXEPN7ByKo4kn
 b8stcN+B9ZTUfb23gJqVhxpylk=
IronPort-HdrOrdr: A9a23:SfbrX6kmIb0rnyiFsh8N7reccvrpDfLW3DAbv31ZSRFFG/Fw9/
 rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM
 xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv
 Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
X-IronPort-AV: E=Sophos;i="5.88,224,1635220800"; 
   d="scan'208";a="60033516"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=hYtNcnpWL3GGTnmsKfMBzLA0U5TUfrCYsr7Cs9ct/8UeXKNM351eZy/hD8IDuv1lddOP2yJ8/83glr/HL342WyBU9FfTeTUfqxn7t22GLqmgIRYB4ifBq5Rh9xUSNnQe1BiloDEYd7gby7yU0I/cwEotPcgicDdEzprwdrlpdrg9yoZu/i8SKggd13nQGQZUhDefcwi5ncPv52o+mdgYqHf0xF4rtHY3Fq15aPvyQXCVBW4Xoe+D0rJpUX0URq86DkxbIj10I95lvUv0/Pexh/u4OUzDkaxlPlGcVy618RxuO52aF7NFt1sKjeCghTdkimL6M2pCZXhLQNhTX8zu+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=qWdKMvlEoWxZybBEeTsgWO7k5zIOnb5fTz8ugdNq/Nc=;
 b=hJMQuQUMkHwi1lmy6IIyclH8A/vzO+eKQv9XqaBrxZqEPtqspjn00aComSIWYT3c80LdwiJpDkpsGweSJ0dMBUItW0NDTc1uVyEMbSHBr0DAwweWzOrrXyq1EPSxXdojvJGrC+4u/KCn3StKkSZv9TgjLkJLG6ZZLe3pYKu5ztwxWTcdKoahrTx6Yp+ezAFqSLiNmg46Jy1h97ppqAaOZHSgNKaz8A89gXH4VlELu5UQNB8yQ842CiUg6VfrXmYP0A3+/OFHpr6aYxzepwDbB31n3ZVPwFc1ZPS7AaFvXv2L4xsUJ8lms21lvVMmWy/2OnEhVJEF0Dy/KAw2WhpLew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=qWdKMvlEoWxZybBEeTsgWO7k5zIOnb5fTz8ugdNq/Nc=;
 b=el+LSdbw6e9npgbxFKGq3V1R0fIZoqXc+Yj6hMtVumCZ+Pi0NCmjyg7Z2baSj3/McYqZOrFxdHa1yclN8qXXI1vLy7SgDywHsXE6UFvfPRA8AkR8f0QRMcs9pG3PKe8TAwdkYGhULvTIS2M6Q6kVoYa3+E5bFGYBs+7eJNkA8UM=
Date: Tue, 21 Dec 2021 20:12:42 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcInKtCNgA9v0k+c@Air-de-Roger>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger>
 <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
X-ClientProxiedBy: MR2P264CA0018.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:1::30) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7d3a32cf-edc5-4dc8-8764-08d9c4b5e0a6
X-MS-TrafficTypeDiagnostic: DM5PR03MB2554:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2554F421A5720AE4AB8434318F7C9@DM5PR03MB2554.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rlLw9NgZfj1FqQiv+vrFtmj0rUXCYgbMsD8ccWpYlXvrZYuHZGoADGCxRUcbkjfxkBFys9Tt/9PFSKRlVGyxbhMdI4+HRAqv02MqgbauceyhPHihnGSxwhhWUk8gWDz+fJLyeKVTYU/A19pC7N15By3+qusafvINRz04MB4r2IaQbLVEnRJczDwDL8pMQY/upaObDx1tQxoLO1uK6ol3vHHu5H6tPpZ51BbHlpkVby6iG5z2vS0couVq5XXKEzxWG+IoehlpmwuYee/0BED5DgYuhdQg+nru6/st3Vc6o7APdEDMs41E2gt1z2fBjJd59CozrgMnOraQwGnvkMJoGp+L9B1feAFcl75uDkFzPd3rEdo627ZIPibSLnJxjzdS2f37PrcwBeMGDPyExWgpZ1tzdDJhB7K1tWWPNyEZkGAQim+aX1IYibM3qZLc2GdiCLlOr/Bv/cNtRsE+GUMbP3dx8/0FdHZh752SkQNFCB/VBMWuIW5vcUB0VXfRA/4PVa5f3g6HqGhYRn9aR564PY7E2s7MyDtnzW/hKtbahTn9/cBsfn6pOlh9BqMxjGXFt/Ajqpl598zA30ry5pzQvoU2mcocg89pevzSk680TMDTlFT/93kBHy3oOkVrQ0RUM0Y3GLmRDiX8MRmT5i0Bpb4/ljQIEGYCCM5pP5XTOiHjvIiUGxrcg59gC8SEL4AsT+GsH4YrLCFA0DLUZcREJw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6916009)(66946007)(66476007)(5660300002)(6666004)(6512007)(9686003)(66556008)(4326008)(508600001)(6486002)(86362001)(26005)(316002)(38100700002)(82960400001)(33716001)(6506007)(85182001)(186003)(8676002)(2906002)(83380400001)(8936002)(67856001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmhKMEI1UWQ0UUdIS0lzNXlBRnVXSUE2R1dnWVVaMXNlQkxiQjRlOFYyMDJI?=
 =?utf-8?B?eXdNS0ExdlhqbDczV1RORHYrdmVKTStkdjZKT29ZU2xVdkdENStOMERHY3dC?=
 =?utf-8?B?VnN5M2tNOXorRWVudGwwcEF0YzQwZmp4LzVta3pUblpmcngxQTFRQTVIRVF1?=
 =?utf-8?B?NnNCc1BFSmJBR0g0Mk5YaXRFUkNzVFpJbWszVVlja0szci9wZlBuN1ZBbHc0?=
 =?utf-8?B?aURzU0RUU3hHOEVOclVBK2JLTmNIeDlIOVEyaGp2bnZWMytvWHN0QkpQcnRa?=
 =?utf-8?B?Tmw2L29RTGVteVRueVRNQVNtN0dRSUhKMlhScW9UVnZaTERTbU1UQWViQ2F6?=
 =?utf-8?B?VWpmbVRrZzRZdGNPeDhuSEg4Um1LR1hUQ1lxaVlSa080YlUvRWt1cExva3dW?=
 =?utf-8?B?eWJaQ1N1OEkvYzl0SnR3eTJ2SUdqSXo3STlCek01SzFUMVJ5NGl2NE00eGRN?=
 =?utf-8?B?NndFb3hjRXR2THJ3QlNreDNjQmZwZUszTGRnNjBraFR6dWN6djU3aWdlbmlX?=
 =?utf-8?B?eWRYa3J3VjRqMjhFazRpdm5YcU1weU9UMkdQRUVkVnd4bG1hL3J2SFdZLzRn?=
 =?utf-8?B?OEdUNmxsem5vQVpUR0lxckhoaVNheEdwZU5nZE9Xbm1leFdRSGpwNlRjaFRk?=
 =?utf-8?B?amF3eEFCTno0Vks0VUl6SUhrc2xWZDdwV3hFczdFTHlzQjBiOG9BYTM1RFJl?=
 =?utf-8?B?cnNiZVlhTWtDQXg0L0ordEZHT0ZycU1oWEhqL05aSWZpRUpPT1JvU3NrVjRJ?=
 =?utf-8?B?eldkbjRkTDE0QXh1RVF2Vkt1N2VtdlNqU3MrMVJabVJUQUVmem42b0FnRkUy?=
 =?utf-8?B?eXQ4ZGY2ZDMrREVXeEM5Rks2ZURQUS9XVDc4NjAzakwyZ2hqQ1F5dlBSM3pq?=
 =?utf-8?B?MFdZZnJxbjVSZ3NxVllvUmJCNkt3VUordXhKSExha29NNndYZ01LcnB4ODlI?=
 =?utf-8?B?WTBvak5xVUV6MVphUUhFZ2MzYmUrMTltR3UrMEpmVHRrM0NTTm9JWVlFRmFn?=
 =?utf-8?B?RTFyeEdxSjJ2aWl3TVZFS3FMejNEQUx3MlBSa1U3SDRDZ2RYNE12UXp0blhs?=
 =?utf-8?B?UE5rWnZxak5nUGxBdzdnVDY2RXVueG94ankxSTJINCtYLy9aZWF3TVFqRitZ?=
 =?utf-8?B?dlpxYWUrUzAyb2h0NngwQnNqZGU1ZDduSDZRUURPOTFneFJXamRpeGROUEk2?=
 =?utf-8?B?YWxrMFp5Y0VVdnJRNThWbW1zWXhFSmQvMWRjSVI0Y0N4VGpJZnBWNGdweW9x?=
 =?utf-8?B?TlpOTW5wTmdxZHRFamhnVlJZS3FvRk1wanEwZHpCcGVKS3FkM0g0UlpONGx0?=
 =?utf-8?B?enpYaXVvTHFWWVlSZnZuMVg5WWtoRHpsbmlNcHNZOTdBZm9JSHJ1cm9CUGZ5?=
 =?utf-8?B?NmxPcUV6VVdHbkdETDVQZ3lDMTdXRHhQVHEweldrTU95TUhLelJ2UXdldjB2?=
 =?utf-8?B?aGpHNmFzTXhtRDN6SzY4S0Uxcm1vQlFJYjRLSUlJUzRQTllOUUZXaVExYkVk?=
 =?utf-8?B?OWNqREpwUGozM09ZRm8vdExzUnRuVEwwaVlNNnRFRXVZWlJITWorZ0dmNUph?=
 =?utf-8?B?UkRKTnh6VTZncDNlUlljcEtvV3o5d0hLdGtDNklHUjZFZmplMi9sQlNFaXVK?=
 =?utf-8?B?Zml6QXNsay9BbmFsTGxBQmtyb2xRRENsbVY0TUl0TjFPS1VDS25UMTNrQ3VP?=
 =?utf-8?B?eWRnNS9KUjJkWFRRSU1nMWlQVDVBSVFLZ0FhKzBWcVJTZ0hWMTN2azNkQjd2?=
 =?utf-8?B?cm83RXF0YW1yL2lsbjV6SEswb1dyS0YxUnlmRnM3SVpvRU0xaUxGWloxWjBx?=
 =?utf-8?B?Smd0MUptUEE0VTNaLzBUdXNtTGtLaDMzZVg2V0NSTlp6bTU1LzdZczdRQ1ky?=
 =?utf-8?B?SXpWVllLSHNBZ21yVmhsQVl5ZUtnbjVSWGF5YS95WlJUb2ZKaHJpRzkzNlV0?=
 =?utf-8?B?K05SUDdCUTVLMnBBNFUxdU4zZXlsWDhZTm5ITmdOeUlZRklJYWh6d0lDQ3lj?=
 =?utf-8?B?T09WZEZSM2tYbEpzTU1pRVV4dUdTQUQyM1QxcE5EaFFRbmE1cSs1YkhGR0hC?=
 =?utf-8?B?VFZmbkoxZGx6SVUzQkZoeTBwNFJRb0VVVHRybGx5ZFA1elJxOEJqem1Nendr?=
 =?utf-8?B?eW5yd0NYdUtOUkxJOXEycUJMTnkwaXE1RXBxUHkyLytGTkJPSHkwdXcvaUxM?=
 =?utf-8?Q?ck9JhSrHCCShko3LGzkqmiw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3a32cf-edc5-4dc8-8764-08d9c4b5e0a6
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2021 19:12:48.9113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wfXLypK7LsuchQhwIdxiZohmL8mZkYuNoDhefbqAe0/GATdVc191p/b2HDkwgdhhQ511wuKsfxVe7v3EXWMyiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2554
X-OriginatorOrg: citrix.com

On Wed, Dec 22, 2021 at 02:19:03AM +0800, G.R. wrote:
> > > I omitted all operational details with the assumption that you are familiar
> > > with TrueNAS and iSCSI setup.
> >
> > Not really. Ideally I would like a way to reproduce that can be done
> > using iperf, nc or similar simple command line tool, without requiring
> > to setup iSCSI.
> I think it would be tricky then. The problem hide itself well enough
> that I wasn't
> aware soon after upgrading since everything else works flawlessly --
> nfs, ssh, web etc.
> 
> > Can you also paste the output of `ifconfig xn0`?
> Here it is:
> xn0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
>     options=503<RXCSUM,TXCSUM,TSO4,LRO>
>     ether 00:18:3c:51:6e:4c
>     inet 192.168.1.9 netmask 0xffffff00 broadcast 192.168.1.255
>     media: Ethernet manual
>     status: active
>     nd6 options=1<PERFORMNUD>
> 
> >
> > If I provided a patch for the FreeBSD kernel, would you be able to
> > apply and test it?
> Probably. I did this before when your XEN support for freeBSD was not
> available out-of-box.
> Just need to recreate all the required environments to apply the patch.

Could you build a debug kernel with the following patch applied and
give me the trace when it explodes?

Thanks, Roger.
---
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c
index fd2d97a7c70c..87bc3ecfc4dd 100644
--- a/sys/dev/xen/netfront/netfront.c
+++ b/sys/dev/xen/netfront/netfront.c
@@ -1519,8 +1519,12 @@ xn_count_frags(struct mbuf *m)
 {
 	int nfrags;
 
-	for (nfrags = 0; m != NULL; m = m->m_next)
+	for (nfrags = 0; m != NULL; m = m->m_next) {
+		KASSERT(
+		   (mtod(m, vm_offset_t) & PAGE_MASK) + m->m_len <= PAGE_SIZE,
+		    ("mbuf fragment crosses a page boundary"));
 		nfrags++;
+	}
 
 	return (nfrags);
 }



From xen-devel-bounces@lists.xenproject.org Tue Dec 21 20:03:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 20:03:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250586.431603 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzlM9-0001ir-BR; Tue, 21 Dec 2021 20:03:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250586.431603; Tue, 21 Dec 2021 20:03:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzlM9-0001ik-8F; Tue, 21 Dec 2021 20:03:29 +0000
Received: by outflank-mailman (input) for mailman id 250586;
 Tue, 21 Dec 2021 20:03:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=cbib=RG=epam.com=prvs=2989ef1cf7=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mzlM7-0001ie-DP
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 20:03:27 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0c5c77b1-6299-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 21:03:22 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BLJOxjE001858;
 Tue, 21 Dec 2021 20:03:11 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d3huhrrst-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Tue, 21 Dec 2021 20:03:10 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR2PR03MB5194.eurprd03.prod.outlook.com (2603:10a6:101:17::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.19; Tue, 21 Dec
 2021 20:03:06 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.020; Tue, 21 Dec 2021
 20:03:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0c5c77b1-6299-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=knUEIGl0eHl4wz45jw+jCMFVj0ode04Z8kkrodhvccIu/7p82R6TUL4CvQI5/zvcnlK3ohqr9VfVIu6kiZNBFpCsbGHnf5V8OqSMrN+ibzfVtS4AAYSwCJ/ra1YCRbm00Id9+Z8Hx6igS2/065XVLtUs26pk2OIneUSRiJQJNxsvrcK+MSYJl+UVxpaO+8qrY04NokxgAojMpat2Adhk2Aw4RhCDqpWBisTl5/zJe54GQvQUY2GePBTMC3Kx0jpKCZHGoaw2W4eSRKfQ3/F8ZQ3d1bKdzmBa59FyUNcgm0H9F5ubhR8bQtNAWvftWS5JvsFf8kPPNOXMqwmdQyWNBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AePlNM58N/Y1M36jOZoF8UcCCFQFKAAkvBw+BaLb4O4=;
 b=gN/f7SslIgnlP4Jgmu1p+COp5tGkDRYLaij6zs2KcgbXvBwurkJ8TaKOj+gCiMNDSGXMH6wMkxbhcGoGkVscr4zM07vmVFutPXBlHsNaSCmoa+LImitVlYT6ZvG3FKdIlyZef1lE3IhO6uow4+MOX/13XiBaw2hxQOEFz2zQ0QIoraGGkHNXM31JGnDId75wp8UTu89ChjBaGxi/5ufoTF1orFRKKElI4kNoEq9ioSnBS5jdyG7pUWTcysZRSNViaw/5sTXmlnJHaIeaPXOouTLdjhqI2egWEeDkEkCfD/K3w5js4zfMad6XPp0k+jdfhHQ8OC7WjU1WdpbxfQIHTg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AePlNM58N/Y1M36jOZoF8UcCCFQFKAAkvBw+BaLb4O4=;
 b=FS/v2C984mHpWVHpWRKvwRxUcpeQv0pVg/eYi8e5wFv7u/u64EvfMHAWBwR5Cai/UChzxrO/DKrBS/izT/lR6AyS6vLG5ZUU/Uu9A5M5YgNZizNV44PaZAuUMj76HAIa22826a1D2ulaUVWgbFC+6A0pNhqe57UAN7BhTz5JWGtu39rhqpalLT+rRRkkmOoVBs+/f75IUbHiqny1HvTb2Ko41WNn3jqGAgfaw7atyaVdp7VV8V7TUBc/XrVvFFEy/XQCxiolGzw0t8Okug4lprJa55x0zOR48nL47YAJGWeSUq6Gna4ISsKjZIgs3oSx7ws79b/32u+PQxdyIAJp2g==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuA
Date: Tue, 21 Dec 2021 20:03:06 +0000
Message-ID: <20211221200305.GA2460476@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 093b6382-8b54-41fe-ed56-08d9c4bce79d
x-ms-traffictypediagnostic: PR2PR03MB5194:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR2PR03MB5194E2E39744BE5E1920B7D5E37C9@PR2PR03MB5194.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 s8Uneo62J7Yctd7qRVtQFmqX1EOTBzCEUbNeYzIHrgDVW8H0g795vsNRoDzXkAxp3da4oHI1HTtqiq0tRtJfx5IiL96QljRDiD+U3vatfsxG80RfS8O+zrqqKI7wAkMP3wq7suNVmkuIs9VGJvFQagLgxqH6qOh43t1EvQjUP/mEERN85CxCD/eoD0I0zWNtvBMBvukgrCHNlTrUFPn2G+6kG8870PUC3naUwLP//vrePmAoNIv6PFGzdCqQkdH1Z4gjLkuTLtDHSUDObFabH+OEr1zqdwQywhVKs6JgsLTvyHFXb8DOITYFnaunv3CsT7vfrPCf7qF1kcpYLNFUdUNO4UZc78Gio7Z+c/c/xzXDgxsD0jxNf7qiKYWO+ImKSajFC9HQkwjYpy1QjV96V6+Bua09XREWuHdl/Pw1yT+P1rIDEIOFIlKBcfsIDanP0KUmUOLRC2bnjrD5zFLknQUPBT/g+D5u7FOck6rfVPPPXdXai0tYexkz9CxZS6agBle2nmJpKkfvDvyUqpT1GLxxXAZP/vBqOmwkQS2676bSy/xM51B50iiPoBWj7VJXG63LnsIZxpAQ33uY/uTgZmmMRvgwtICoUsGXWwIoNL98ByDsp8sakvLxXwcwtLZTjjU1P2kBFlSEfgwO+fsleiow3FpkdofaEB8HqWC0GuOKA7TrVyUrEADg/xh3dtXWF+XDymvnfWTJQ7rL1Yp2KF1aB4FhQrtWFUGEPQCg3BOM/JIIDMt/GxsghkPikK0EPeuKPZblU7V7gu0rIP1imCwGSSpSCsZvPTuCFyU9gSA8fFjNEXZH0ycQB/6kMaic
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(33656002)(71200400001)(8936002)(508600001)(54906003)(38070700005)(186003)(26005)(30864003)(83380400001)(86362001)(1076003)(9686003)(64756008)(6512007)(66946007)(66446008)(33716001)(66556008)(66476007)(966005)(6916009)(6486002)(5660300002)(2906002)(91956017)(316002)(4326008)(8676002)(76116006)(122000001)(6506007)(38100700002)(2004002)(579004)(559001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Q/gPaYIlpKQTWUKdHO/zbZsu6bmc1nx0m1s1Uj8945v3dsFS5p5Kruc8rnoW?=
 =?us-ascii?Q?OEywfEwrq16Kld70kSXxqYchsxPVFja6HMjkDsR53motbwgDwnyru4Qczvb/?=
 =?us-ascii?Q?iQ/TjHihVTzhJA0AIQYkPhn4jnRXuVbXhqfkVDNPxJurYOQXbZ0bDZE/1eRA?=
 =?us-ascii?Q?DdUJgkS2AiObaSayZO1Y3A3Evupp13WHuvlgXlGeurNIjibo76Le51yiSY8K?=
 =?us-ascii?Q?Y3q2qbL1H1e6MsFfPBN87hawA7DWJOdMpQuViWffC9CYKDWRFyekuYnpk46l?=
 =?us-ascii?Q?LMHdlphVwsysVccqiloPu/N6J1VszTZQfiGtUNhUO7ag7f9e5T1sAOEnrkWg?=
 =?us-ascii?Q?peSfSollCQAEkRD2W+QeZC9V3KcsRAAX4FcvcoGhOygwjbXEIKgEQ84F4dWw?=
 =?us-ascii?Q?Cq9z00ptgf+ZlfykdFcX4/9vXRe9y9clqTVx+KgVYTRiILDdQmMdrr8VwgeN?=
 =?us-ascii?Q?WZEIhVyk3eP3Qv8UBgr+foZUGnna3LqMJrfw0kA7MqjPOUi0leUyBvHK/fqj?=
 =?us-ascii?Q?rXuL/ooR8VbQ9I08Q/W/CtfmZjYOx8EDt+7XJTW2e8I6oTYARCaA/2ZIh9P1?=
 =?us-ascii?Q?GL34+208PVT8cX2+qnRCpP1/4pp6b/Jqx5CYLT1C0P1zM/hSNcCxqAm5LYRu?=
 =?us-ascii?Q?hWE3F3az9fMcV7W1NV1tWA0qu/fDjtJ4V+Oz3pGLTYOe06858nNUfpTehPgu?=
 =?us-ascii?Q?84UVA7Swy5Bh+yBOE3H3wCXAjCufFh9oG+sxXhciUXPpEsQqsr77NX0rkfDn?=
 =?us-ascii?Q?Sgvxy/lu8ZPoXXK03yb5fhZN7fL3teTl2QwxFMAAS603JTQkgaXcfSSVmN/N?=
 =?us-ascii?Q?S2uYJhYYyKnmwTk/nalmAla163S25B0tLnMtVxbVngmgEhRwedD49z75PH5N?=
 =?us-ascii?Q?/AL33cRAuX4Dtc3O3COFGh5JVRz1OxJD95g5M+iDjF6NzZ1z7GEQL70AtETw?=
 =?us-ascii?Q?rUkauRzrbqd4MQGa8YwgfIf4y+Hi3XfQmn9ij2lGsscC7BvURFQsX7AunXzV?=
 =?us-ascii?Q?yISp1AmdhtmhJyWQAToMlPxsqSjHWY5hSk/+yOPt8keOD3aZUsU3373iV51r?=
 =?us-ascii?Q?owpwMmpm/2dlqj77Ykc2W6uwAkrR+09Hufi/Li27x9gPgam11ClulVYBaMdG?=
 =?us-ascii?Q?wM6BR/2/0LuZ60D171Rhsj9zF40c+mumKYSz9TufOd9l1GhvZ+QFk/wk6/i0?=
 =?us-ascii?Q?4JTOLl5pPYWfexa+XRIXRH6SwdJYvDj7qeL8SAsRRacStX8m3XkN5nGMgFiw?=
 =?us-ascii?Q?Nv+UUi//WkRF5/Ho0Luuz7TMWexwkiPFCrU8NylS5KZBAkEXSBuywDRMRtCD?=
 =?us-ascii?Q?bDP2ezRRU9Ur7M3rYPaamjHXk8LM/PRF791BlpVEhityYct01J9KJvMxDD0O?=
 =?us-ascii?Q?HR4QKDdxs9w3smX8kXWv2p6FmeVUzi5xVBVJof4xNnwRj4uRz6rutJY7hOn0?=
 =?us-ascii?Q?tT8jWIsXuz77CTpsJY/hyzcoMRNw40fXdMVp7BXOF7m2nbDtzOWZRquAfAqD?=
 =?us-ascii?Q?0/VWeiugYR2jp7UjRB+8Jp7DaiiQutneLxuCFgFscOqk8fP6vQINQJGjGYRW?=
 =?us-ascii?Q?n21TjepdfQV2rJg4jAmrJBNxSdZSNP8xs5fdAymef8q+td4wN57fkyQ29U2M?=
 =?us-ascii?Q?KyQ6RFdvBJgg/V5sXQOgJGPPO5fm/UyPS2GYYYMAvPeuU+bieVNqfprzVRMy?=
 =?us-ascii?Q?dmSHTqw6xTe0eCyy5QGTTcoAMyI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0AC7E1FD17FE134798921211AA07B26C@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 093b6382-8b54-41fe-ed56-08d9c4bce79d
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2021 20:03:06.7481
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hdHrOYI8ZhaqvbmfO2OaTZPbwEnFHjHhu/Wb85JP8Ggd211ZY9fIsnk/qypMu99rMQaenD1jc9ezwxG6pFqVYfIXYxdCkkLaCeNEZUjw85A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5194
X-Proofpoint-GUID: EA9O_AXhTGrxKQ-KGq4JPyev6OGmk8lB
X-Proofpoint-ORIG-GUID: EA9O_AXhTGrxKQ-KGq4JPyev6OGmk8lB
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-21_05,2021-12-21_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0
 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0
 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112210099

Hi Stefano,

On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > Hi Stefano,
> >=20
> > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > This is the implementation of SCI interface, called SCMI-SMC driver=
,
> > > > which works as the mediator between XEN Domains and Firmware (SCP, =
ATF etc).
> > > > This allows devices from the Domains to work with clocks, resets an=
d
> > > > power-domains without access to CPG.
> > > >=20
> > > > The following features are implemented:
> > > > - request SCMI channels from ATF and pass channels to Domains;
> > > > - set device permissions for Domains based on the Domain partial
> > > > device-tree. Devices with permissions are able to work with clocks,
> > > > resets and power-domains via SCMI;
> > > > - redirect scmi messages from Domains to ATF.
> > > >=20
> > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > ---
> > > >  xen/arch/arm/Kconfig          |   2 +
> > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++=
++++
> > > >  xen/include/public/arch-arm.h |   1 +
> > > >  5 files changed, 809 insertions(+)
> > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > >=20
> > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > index 186e1db389..02d96c6cfc 100644
> > > > --- a/xen/arch/arm/Kconfig
> > > > +++ b/xen/arch/arm/Kconfig
> > > > @@ -114,6 +114,8 @@ config SCI
> > > >  	  support. It allows guests to control system resourcess via one =
of
> > > >  	  SCI mediators implemented in XEN.
> > > > =20
> > > > +source "arch/arm/sci/Kconfig"
> > > > +
> > > >  endmenu
> > > > =20
> > > >  menu "ARM errata workaround via the alternative framework"
> > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > > > new file mode 100644
> > > > index 0000000000..9563067ddc
> > > > --- /dev/null
> > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > @@ -0,0 +1,10 @@
> > > > +config SCMI_SMC
> > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > +	default n
> > > > +	depends on SCI
> > > > +	---help---
> > > > +
> > > > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF=
.
> > > > +	This feature allows drivers from Domains to work with System
> > > > +	Controllers (such as power,resets,clock etc.). SCP is used as tra=
nsport
> > > > +	for communication.
> > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > > > index 837dc7492b..67f2611872 100644
> > > > --- a/xen/arch/arm/sci/Makefile
> > > > +++ b/xen/arch/arm/sci/Makefile
> > > > @@ -1 +1,2 @@
> > > >  obj-y +=3D sci.o
> > > > +obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
> > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_sm=
c.c
> > > > new file mode 100644
> > > > index 0000000000..2eb01ea82d
> > > > --- /dev/null
> > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > @@ -0,0 +1,795 @@
> > > > +/*
> > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > + *
> > > > + * SCMI mediator driver, using SCP as transport.
> > > > + *
> > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > + * Copyright (C) 2021, EPAM Systems.
> > > > + *
> > > > + * This program is free software; you can redistribute it and/or m=
odify
> > > > + * it under the terms of the GNU General Public License as publish=
ed by
> > > > + * the Free Software Foundation; either version 2 of the License, =
or
> > > > + * (at your option) any later version.
> > > > + *
> > > > + * This program is distributed in the hope that it will be useful,
> > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > + * GNU General Public License for more details.
> > > > + */
> > > > +
> > > > +#include <asm/sci/sci.h>
> > > > +#include <asm/smccc.h>
> > > > +#include <asm/io.h>
> > > > +#include <xen/bitops.h>
> > > > +#include <xen/config.h>
> > > > +#include <xen/sched.h>
> > > > +#include <xen/device_tree.h>
> > > > +#include <xen/iocap.h>
> > > > +#include <xen/init.h>
> > > > +#include <xen/err.h>
> > > > +#include <xen/lib.h>
> > > > +#include <xen/list.h>
> > > > +#include <xen/mm.h>
> > > > +#include <xen/string.h>
> > > > +#include <xen/time.h>
> > > > +#include <xen/vmap.h>
> > > > +
> > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > +
> > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > > > +#define SCMI_SUCCESS              0
> > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > +#define SCMI_DENIED             (-3)
> > > > +#define SCMI_NOT_FOUND          (-4)
> > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > +#define SCMI_BUSY               (-6)
> > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > +
> > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > > +
> > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > >=20
> > > I could find the following SCMI binding in Linux, which describes
> > > the arm,scmi-smc compatible and the arm,smc-id property:
> > >=20
> > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > >=20
> > > However, linux,scmi_mem is not described. Aren't you supposed to read
> > > the "shmem" property instead? And the compatible string used for this
> > > seems to be "arm,scmi-shmem".
> > >=20
> >=20
> > We use linux,scmi_mem node to reserve memory, needed for all
> > channels:
> >=20
> > reserved-memory {
> >     /* reserved region for scmi channels*/
> >     scmi_memory: linux,scmi_mem@53FF0000 {
> >         no-map;
> >         reg =3D <0x0 0x53FF0000 0x0 0x10000>;
> >     };
> > };
> >=20
> > arm,scmi-shmem node used in shmem property defines only 1 page needed t=
o
> > the current scmi channel:
> >=20
> > cpu_scp_shm: scp-shmem@0x53FF0000 {
> >     compatible =3D "arm,scmi-shmem";
> >     reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > };
> >=20
> > For each Domain reg points to unigue page from linux,scmi_mem region,
> > assigned to this agent.
>=20
> If we were to use "linux,scmi_mem" we would have to introduce it as a
> compatible string, not as a node name, and it would need to be described
> in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
>=20
> But from your description I don't think it is necessary. We can just use
> "arm,scmi-shmem" to describe all the required regions:
>=20
> reserved-memory {
>     scp-shmem@0x53FF0000 {
>         compatible =3D "arm,scmi-shmem";
>         reg =3D <0x0 0x53FF0000 0x0 0x1000>;
>     };
>     scp-shmem@0x53FF1000 {
>         compatible =3D "arm,scmi-shmem";
>         reg =3D <0x0 0x53FF1000 0x0 0x1000>;
>     };
>     scp-shmem@0x53FF2000 {
>         compatible =3D "arm,scmi-shmem";
>         reg =3D <0x0 0x53FF2000 0x0 0x1000>;
>     };
>     ...
>=20
> In other words, if all the individual channel pages are described as
> "arm,scmi-shmem", why do we also need a single larger region as
> "linux,scmi_mem"?
>=20

That was my first implementation. But I've met a problem with
scmi driver in kernel. I don't remember the exact place, but I remember
there were some if, checking if memory weren't reserved.
That's why I ended up splitting nodes reserved memory region and actual
shmem page.
For linux,scmi_mem node I took format from /reserved-memory/linux,lossy_dec=
ompress@54000000,
which has no compatible string and provides no-map property.
linux,scmi_shmem node is needed to prevent xen from allocating this
space for the domain.

Very interesting question about should I introduce linux,scmi_mem node
and scmi_devid property to the
Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
Those node and property are needed only for Xen and useless for
non-virtualized systems. I can add this node and property description to
arm,scmi.yaml, but leave a note that this is Xen specific params.
What do you think about it?

> =20
> > > > +#define SCMI_SHMEM                         "shmem"
> > > > +
> > > > +#define HYP_CHANNEL                          0x0
> > > > +
> > > > +#define HDR_ID                             GENMASK(7,0)
> > > > +#define HDR_TYPE                           GENMASK(9, 8)
> > > > +#define HDR_PROTO                          GENMASK(17, 10)
> > > > +
> > > > +/* SCMI protocol, refer to section 4.2.2.2 (DEN0056C) */
> > > > +#define MSG_N_AGENTS_MASK                  GENMASK(15, 8)
> > > > +
> > > > +#define FIELD_GET(_mask, _reg)\
> > > > +    ((typeof(_mask))(((_reg) & (_mask)) >> (ffs64(_mask) - 1)))
> > > > +#define FIELD_PREP(_mask, _val)\
> > > > +    (((typeof(_mask))(_val) << (ffs64(_mask) - 1)) & (_mask))
> > > > +
> > > > +typedef struct scmi_msg_header {
> > > > +    uint8_t id;
> > > > +    uint8_t type;
> > > > +    uint8_t protocol;
> > > > +} scmi_msg_header_t;
> > > > +
> > > > +typedef struct scmi_perms_tx {
> > > > +    uint32_t agent_id;
> > > > +    uint32_t device_id;
> > > > +    uint32_t flags;
> > > > +} scmi_perms_tx_t;
> > > > +
> > > > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE   BIT(0, UL)
> > > > +#define SCMI_SHMEM_CHAN_STAT_CHANNEL_ERROR  BIT(1, UL)
> > > > +
> > > > +#define SCMI_ALLOW_ACCESS                   BIT(0, UL)
> > > > +
> > > > +struct scmi_shared_mem {
> > > > +    uint32_t reserved;
> > > > +    uint32_t channel_status;
> > > > +    uint32_t reserved1[2];
> > > > +    uint32_t flags;
> > > > +    uint32_t length;
> > > > +    uint32_t msg_header;
> > > > +    uint8_t msg_payload[];
> > > > +};
> > > > +
> > > > +struct scmi_channel {
> > > > +    int chan_id;
> > > > +    int agent_id;
> > > > +    uint32_t func_id;
> > > > +    int domain_id;
> > > > +    uint64_t paddr;
> > > > +    struct scmi_shared_mem *shmem;
> > > > +    spinlock_t lock;
> > > > +    struct list_head list;
> > > > +};
> > > > +
> > > > +struct scmi_data {
> > > > +    struct list_head channel_list;
> > > > +    spinlock_t channel_list_lock;
> > > > +    bool initialized;
> > > > +    u64 shmem_addr, shmem_size;
> > > > +};
> > > > +
> > > > +static struct scmi_data scmi_data;
> > > > +
> > > > +/*
> > > > + * pack_scmi_header() - packs and returns 32-bit header
> > > > + *
> > > > + * @hdr: pointer to header containing all the information on messa=
ge id,
> > > > + *    protocol id and type id.
> > > > + *
> > > > + * Return: 32-bit packed message header to be sent to the platform=
.
> > > > + */
> > > > +static inline uint32_t pack_scmi_header(scmi_msg_header_t *hdr)
> > > > +{
> > > > +    return FIELD_PREP(HDR_ID, hdr->id) |
> > > > +        FIELD_PREP(HDR_TYPE, hdr->type) |
> > > > +        FIELD_PREP(HDR_PROTO, hdr->protocol);
> > > > +}
> > > > +
> > > > +/*
> > > > + * unpack_scmi_header() - unpacks and records message and protocol=
 id
> > > > + *
> > > > + * @msg_hdr: 32-bit packed message header sent from the platform
> > > > + * @hdr: pointer to header to fetch message and protocol id.
> > > > + */
> > > > +static inline void unpack_scmi_header(uint32_t msg_hdr, scmi_msg_h=
eader_t *hdr)
> > > > +{
> > > > +    hdr->id =3D FIELD_GET(HDR_ID, msg_hdr);
> > > > +    hdr->type =3D FIELD_GET(HDR_TYPE, msg_hdr);
> > > > +    hdr->protocol =3D FIELD_GET(HDR_PROTO, msg_hdr);
> > > > +}
> > > > +
> > > > +static inline int channel_is_free(struct scmi_channel *chan_info)
> > > > +{
> > > > +    return ( chan_info->shmem->channel_status
> > > > +            & SCMI_SHMEM_CHAN_STAT_CHANNEL_FREE ) ? 0 : -EBUSY;
> > >=20
> > > Does this need a memory barrier? Or not, because the other end always
> > > runs on the same CPU at a different execution level so the
> > > channel_status would be always guaranteed to be read as updated?
> > >=20
> >=20
> > It don't because the other end runs on the same CPU. Other mediator
> > implemetaions, which uses different areas may need memory barrier.
> >=20
> > >=20
> > > > +}
> > > > +
> > > > +static int send_smc_message(struct scmi_channel *chan_info,
> > > > +                            scmi_msg_header_t *hdr, void *data, in=
t len)
> > > > +{
> > > > +    struct arm_smccc_res resp;
> > > > +    int ret;
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: status =3D%d len=3D%d\n",
> > > > +           chan_info->shmem->channel_status, len);
> > > > +    printk(XENLOG_DEBUG "scmi: header id =3D %d type =3D %d, proto=
 =3D %d\n",
> > > > +           hdr->id, hdr->type, hdr->protocol);
> > > > +
> > > > +    ret =3D channel_is_free(chan_info);
> > > > +    if ( IS_ERR_VALUE(ret) )
> > > > +        return ret;
> > > > +
> > > > +    chan_info->shmem->channel_status =3D 0x0;
> > > > +    /* Writing 0x0 right now, but SCMI_SHMEM_FLAG_INTR_ENABLED can=
 be set */
> > > > +    chan_info->shmem->flags =3D 0x0;
> > > > +    chan_info->shmem->length =3D sizeof(chan_info->shmem->msg_head=
er) + len;
> > > > +    chan_info->shmem->msg_header =3D pack_scmi_header(hdr);
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: Writing to shmem address %p\n",
> > > > +           chan_info->shmem);
> > > > +    if ( len > 0 && data )
> > > > +        memcpy((void *)(chan_info->shmem->msg_payload), data, len)=
;
> > >=20
> > > Again, here we don't need a barrier because it is implicit in the SMC=
?
> > >=20
> >=20
> > As I mentioned before, the other end runs on the same CPU.
> >=20
> > > Don't we need to check that "len" fits in the shared memory?
> > >=20
> >=20
> > I think it's a good point. I'll add len check in v2.
> >=20
> > >=20
> > > > +    arm_smccc_smc(chan_info->func_id, 0, 0, 0, 0, 0, 0, chan_info-=
>chan_id,
> > > > +                  &resp);
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: scmccc_smc response %d\n", (int)(re=
sp.a0));
> > > > +
> > > > +    if ( resp.a0 )
> > > > +        return -EOPNOTSUPP;
> > >=20
> > > Why is that?
> > >=20
> >=20
> > This change was presented in kernel by Sudeep Holla in commit:
> > f7199cf489027ae38a9a82312d13025f7aefa0b8
> >=20
> > However, link posted in the commit:
> > https://urldefense.com/v3/__https://lore.kernel.org/r/20200417103232.68=
96-1-sudeep.holla@arm.com__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee=
_ChowYQiQYC595rMOsrnmof2zmk7Bnhb7jXoB3$ [lore[.]kernel[.]org]
> >=20
> > Leads to slightly different patch:
> >=20
> > +	if (res.a0 =3D=3D SMCCC_RET_NOT_SUPPORTED)
> > +		return -EOPNOTSUPP;
> > +	else if (res.a0)
> > +		return -EINVAL;
> > +	return 0;
> >=20
> > I don't know why it differs from the original commit, but I'll check an=
d place
> > the correct implementation in v2.
> >=20
> > >=20
> > > > +    return 0;
> > > > +}
> > > > +
> > > > +static int check_scmi_status(int scmi_status)
> > > > +{
> > > > +    if ( scmi_status =3D=3D SCMI_SUCCESS )
> > > > +        return 0;
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: Error received: %d\n", scmi_status)=
;
> > > > +
> > > > +    switch ( scmi_status )
> > > > +    {
> > > > +    case SCMI_NOT_SUPPORTED:
> > > > +        return -EOPNOTSUPP;
> > > > +    case SCMI_INVALID_PARAMETERS:
> > > > +        return -EINVAL;
> > > > +    case SCMI_DENIED:
> > > > +        return -EACCES;
> > > > +    case SCMI_NOT_FOUND:
> > > > +        return -ENOENT;
> > > > +    case SCMI_OUT_OF_RANGE:
> > > > +        return -ERANGE;
> > > > +    case SCMI_BUSY:
> > > > +        return -EBUSY;
> > > > +    case SCMI_COMMS_ERROR:
> > > > +        return -ENOTCONN;
> > > > +    case SCMI_GENERIC_ERROR:
> > > > +        return -EIO;
> > > > +    case SCMI_HARDWARE_ERROR:
> > > > +        return -ENXIO;
> > > > +    case SCMI_PROTOCOL_ERROR:
> > > > +        return -EBADMSG;
> > > > +    }
> > > > +
> > > > +    return -EINVAL;
> > > > +}
> > > > +
> > > > +static int get_smc_response(struct scmi_channel *chan_info,
> > > > +                            scmi_msg_header_t *hdr, void *data, in=
t len)
> > > > +{
> > > > +    int recv_len;
> > > > +    int ret;
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: get smc responce msgid %d\n", hdr->=
id);
> > > > +
> > > > +    ret =3D channel_is_free(chan_info);
> > > > +    if ( IS_ERR_VALUE(ret) )
> > > > +        return ret;
> > >=20
> > > I am not familiar with the spec (do you have a link?) but is it expec=
ted
> > > that the channel is "free" when actually we want to read a message on
> > > the channel?
> > >=20
> >=20
> > Here is the link https://urldefense.com/v3/__https://developer.arm.com/=
documentation/den0056/latest__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoL=
xee_ChowYQiQYC595rMOsrnmof2zmk7BnhRd1Yyp8$ [developer[.]arm[.]com]
> > Figure 6 in Section 5.1.1.
> > Caller marks channel as busy, then callee process message and marks cha=
nnel as free.
> > We are implementing polling based communication flow.
>=20
> OK
>=20
>=20
> > > > +    recv_len =3D chan_info->shmem->length - sizeof(chan_info->shme=
m->msg_header);
> > > > +
> > > > +    if ( recv_len < 0 )
> > > > +    {
> > > > +        printk(XENLOG_ERR
> > > > +               "scmi: Wrong size of smc message. Data may be inval=
id\n");
> > > > +        return -EINVAL;
> > > > +    }
> > > > +
> > > > +    if ( recv_len > len )
> > > > +    {
> > > > +        printk(XENLOG_ERR
> > > > +               "scmi: Not enough buffer for message %d, expecting =
%d\n",
> > > > +               recv_len, len);
> > > > +        return -EINVAL;
> > > > +    }
> > > > +
> > > > +    unpack_scmi_header(chan_info->shmem->msg_header, hdr);
> > > > +
> > > > +    if ( recv_len > 0 )
> > > > +    {
> > > > +        memcpy(data, chan_info->shmem->msg_payload, recv_len);
> > > > +    }
> > > > +
> > > > +    return 0;
> > > > +}
> > > > +
> > > > +static int do_smc_xfer(struct scmi_channel *channel, scmi_msg_head=
er_t *hdr, void *tx_data, int tx_size,
> > > > +                       void *rx_data, int rx_size)
> > > > +{
> > > > +    int ret =3D 0;
> > > > +
> > > > +    if ( !hdr )
> > > > +        return -EINVAL;
> > > > +
> > > > +    spin_lock(&channel->lock);
> > > > +
> > > > +    ret =3D send_smc_message(channel, hdr, tx_data, tx_size);
> > > > +    if ( ret )
> > > > +        goto clean;
> > > > +
> > > > +    ret =3D get_smc_response(channel, hdr, rx_data, rx_size);
> > > > +clean:
> > > > +    spin_unlock(&channel->lock);
> > > > +
> > > > +    return ret;
> > > > +}
> > > > +
> > > > +static struct scmi_channel *get_channel_by_id(uint8_t chan_id)
> > > > +{
> > > > +    struct scmi_channel *curr;
> > > > +    bool found =3D false;
> > > > +
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > >=20
> > > please use parenthesis around the inner if (also in other places)
> > >=20
> >=20
> > Thank you for the remark. I will fix it in v2.
> >=20
> > >=20
> > > > +        if ( curr->chan_id =3D=3D chan_id )
> > > > +        {
> > > > +            found =3D true;
> > > > +            break;
> > > > +        }
> > > > +
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +    if ( found )
> > > > +        return curr;
> > > > +
> > > > +    return NULL;
> > > > +}
> > > > +
> > > > +static struct scmi_channel *get_channel_by_domain(uint8_t domain_i=
d)
> > >=20
> > > Use domid_t for domain ids.
> >=20
> > Thanks, I will fix it in v2.
> > >=20
> > > Also, wouldn't it be better to implement it as:
> > >=20
> > > static inline struct scmi_channel *get_channel_by_domain(struct domai=
n *d) {
> > >     return d->arch.sci
> > > }
> > >=20
> > That's a good point. I will take a look on it and fix in v2.
> > >=20
> > > > +{
> > > > +    struct scmi_channel *curr;
> > > > +    bool found =3D false;
> > > > +
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > > > +        if ( curr->domain_id =3D=3D domain_id )
> > > > +        {
> > > > +            found =3D true;
> > > > +            break;
> > > > +        }
> > > > +
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +    if ( found )
> > > > +        return curr;
> > > > +
> > > > +    return NULL;
> > > > +}
> > > > +
> > > > +static struct scmi_channel *aquire_scmi_channel(int domain_id)
> > > > +{
> > > > +    struct scmi_channel *curr;
> > > > +    bool found =3D false;
> > > > +
> > > > +    ASSERT(domain_id !=3D DOMID_INVALID && domain_id >=3D 0);
> > > > +
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    list_for_each_entry(curr, &scmi_data.channel_list, list)
> > > > +        if ( (curr->domain_id =3D=3D DOMID_INVALID)
> > > > +            && (curr->chan_id !=3D HYP_CHANNEL) )
> > >=20
> > > If you use DOMID_XEN for HYP_CHANNEL, then this check becomes more
> > > intuitive
> > >=20
> >=20
> > We do not have direct relation between channel id and domain id.
> > One channel id can be reused by different domain_ids. So from my standp=
oint,
> > DOMID_XEN doesn't fit here.
> =20
> Below you wrote that you used DOMID_INVALID to mark a channel as free.
> That is fine, but then DOMID_INVALID shouldn't be used for HYP_CHANNEL
> because HYP_CHANNEL is not "free". In this function the check for
> curr->chan_id !=3D HYP_CHANNEL should be unnecessary and I think the code
> would look as follows:
>=20
>     list_for_each_entry(curr, &scmi_data.channel_list, list)
>     {
>         if ( (curr->domain_id =3D=3D DOMID_INVALID) )
>         {
>=20

Oh, now I understood your point. Thank you for that.
I will use DOMID_XEN for HYP_CHANNEL and remove curr->chan_id !=3D
HYP_CHANNEL. This will be fixed in v2.


> =20
> > > > +        {
> > > > +            curr->domain_id =3D domain_id;
> > > > +            found =3D true;
> > > > +            break;
> > > > +        }
> > > > +
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +    if ( found )
> > > > +        return curr;
> > > > +
> > > > +    return NULL;
> > > > +}
> > > > +
> > > > +static void relinquish_scmi_channel(struct scmi_channel *channel)
> > > > +{
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    ASSERT(channel !=3D NULL);
> > >=20
> > > the ASSERT could be before the spin_lock
> > >=20
> >=20
> > Thank you. I will fix it in v2.
> >=20
> > >=20
> > > > +    channel->domain_id =3D DOMID_INVALID;
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +}
> > > > +
> > > > +static struct scmi_channel *smc_create_channel(uint8_t chan_id,
> > > > +                                               uint32_t func_id, u=
int64_t addr)
> > > > +{
> > > > +    struct scmi_channel *channel;
> > > > +    mfn_t mfn;
> > > > +
> > > > +    channel =3D get_channel_by_id(chan_id);
> > > > +    if ( channel )
> > > > +        return ERR_PTR(EEXIST);
> > > > +
> > > > +    channel =3D xmalloc(struct scmi_channel);
> > > > +    if ( !channel )
> > > > +        return ERR_PTR(ENOMEM);
> > > > +
> > > > +    channel->chan_id =3D chan_id;
> > > > +    channel->func_id =3D func_id;
> > > > +    channel->domain_id =3D DOMID_INVALID;
> > >=20
> > > I take you are using DOMID_INVALID to mark a channel used by Xen itse=
lf?
> > > If so, then DOMID_XEN would be more appropriate.
> > >=20
> >=20
> > I use DOMID_INVALID to mark channel as free.
> >=20
> > >=20
> > > > +    mfn =3D maddr_to_mfn(addr);
> > > > +    channel->shmem =3D vmap(&mfn, 1);
> > >=20
> > > One thing to be careful is the mapping attributes, for a couple of
> > > reasons. As you might be aware, the ARM architecture forbids mismatch=
ing
> > > attributes for mapping memory in different places in the system. So t=
he
> > > attributes that we use here must be the same used by the firmware
> > > (and/or the guest.)
> > >=20
> > > The second reason to be careful is that in the bindings example
> > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml the shared
> > > memory is "mmio-sram", which is special. It is not supposed to be nor=
mal
> > > memory, but it is OK to map it cacheable. Still, it might be more
> > > appropriate to use ioremap_cache.
> > >=20
> >=20
> > Originally, I used vmap here to have memcpy and it works fine in our
> > setup. But I will do some research and email you with the results.
> >=20
> > >=20
> > > > +    if ( !channel->shmem )
> > > > +    {
> > > > +        xfree(channel);
> > > > +        return ERR_PTR(ENOMEM);
> > > > +    }
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: Got shmem after vmap %p\n", channel=
->shmem);
> > > > +    channel->paddr =3D addr;
> > > > +    channel->shmem->channel_status =3D SCMI_SHMEM_CHAN_STAT_CHANNE=
L_FREE;
> > > > +    spin_lock_init(&channel->lock);
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    list_add(&channel->list, &scmi_data.channel_list);
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +    return channel;
> > > > +}
> > > > +
> > > > +static int map_memory_to_domain(struct domain *d, uint64_t addr, u=
int64_t len)
> > > > +{
> > > > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > +}
> > > > +
> > > > +static int unmap_memory_from_domain(struct domain *d, uint64_t add=
r,
> > > > +                                     uint64_t len)
> > > > +{
> > > > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > +}
> > > > +
> > > > +static int dt_update_domain_range(struct domain *d, uint64_t addr,
> > > > +                                  uint64_t size)
> > > > +{
> > > > +    struct dt_device_node *shmem_node;
> > > > +    __be32 *hw_reg;
> > > > +    const struct dt_property *pp;
> > > > +    uint32_t len;
> > > > +
> > > > +    shmem_node =3D dt_find_compatible_node(NULL, NULL, "arm,scmi-s=
hmem");
> > >=20
> > > Here we are using "arm,scmi-shmem" while below we are checking for
> > > "linux,scmi_mem". What's the difference?
> >=20
> > linux,scmi_mem (I posted nodes examples above) describes memory region,=
 allocated
> > for all channels, while arm,scmi-shmem points to the exact channel (pag=
e in
> > linux,scmi_mem region).
> >
> >=20
> > > Also, this function is looking for "arm,scmi-shmem" in dt_host and
> > > replaces its value. For dom0less domUs we'll probably need a
> > > make_scmi_node function to create the node from scratch like for
> > > instance xen/arch/arm/domain_build.c:make_gic_domU_node.
> > >=20
> > > I wonder if we had such a function whether it wouldn't be better to a=
lso
> > > use it for dom0 (and blacklist the physical "arm,scmi-shmem" in
> > > handle_node so that dom0 doesn't get the real shared memory informati=
on
> > > by accident).
> > >=20
> >=20
> > Thank you for the remark. I will rework this in v2.
> >=20
> > >=20
> > > > +
> > > > +    if ( !shmem_node )
> > > > +    {
> > > > +        printk(XENLOG_ERR "scmi: Unable to find %s node in DT\n", =
SCMI_SHMEM);
> > > > +        return -EINVAL;
> > > > +    }
> > > > +
> > > > +    pp =3D dt_find_property(shmem_node, "reg", &len);
> > > > +    if ( !pp )
> > > > +    {
> > > > +        printk(XENLOG_ERR "scmi: Unable to find regs entry in shme=
m node\n");
> > > > +        return -ENOENT;
> > > > +    }
> > > > +
> > > > +    hw_reg =3D pp->value;
> > > > +    dt_set_range(&hw_reg, shmem_node, addr, size);
> > > > +
> > > > +    return 0;
> > > > +}
> > > > +
> > > > +static void free_channel_list(void)
> > > > +{
> > > > +    struct scmi_channel *curr, *_curr;
> > > > +
> > > > +    spin_lock(&scmi_data.channel_list_lock);
> > > > +    list_for_each_entry_safe (curr, _curr, &scmi_data.channel_list=
, list)
> > > > +    {
> > > > +        vunmap(curr->shmem);
> > > > +        list_del(&curr->list);
> > > > +        xfree(curr);
> > > > +    }
> > > > +
> > > > +    spin_unlock(&scmi_data.channel_list_lock);
> > > > +}
> > > > +
> > > > +static __init bool scmi_probe(struct dt_device_node *scmi_node)
> > > > +{
> > > > +    struct dt_device_node *shmem_node;
> > > > +    int ret, i;
> > > > +    struct scmi_channel *channel, *agent_channel;
> > > > +    int n_agents;
> > > > +    scmi_msg_header_t hdr;
> > > > +    struct rx_t {
> > > > +        int32_t status;
> > > > +        uint32_t attributes;
> > > > +    } rx;
> > >=20
> > > Should rx be defined at the top together with scmi_perms_tx_t and
> > > others?
> > >=20
> >=20
> > I'd rather move scmi_perms_tx_t to scmi_add_device_by_devid because it'=
s
> > used only in 1 place.
> > So we will have rx and tx in scmi_add_device_by_devid and rx ( which
> > differs from rx in scmi_add_device_by_devid ) in scmi_probe.
> > I think it will be more understandable and no need to make unique names=
.
> > What do you think about that?
>=20
> I think that's OK
>=20
> =20
> > > > +    uint32_t func_id;
> > > > +
> > > > +    ASSERT(scmi_node !=3D NULL);
> > > > +
> > > > +    INIT_LIST_HEAD(&scmi_data.channel_list);
> > > > +    spin_lock_init(&scmi_data.channel_list_lock);
> > > > +
> > > > +    if ( !dt_property_read_u32(scmi_node, SCMI_SMC_ID, &func_id) )
> > > > +    {
> > > > +        printk(XENLOG_ERR "scmi: Unable to read smc-id from DT\n")=
;
> > > > +        return false;
> > > > +    }
> > > > +
> > > > +    shmem_node =3D dt_find_node_by_name(NULL, SCMI_SHARED_MEMORY);
> > >=20
> > > From the spec, it looks like you should be getting the shared memory
> > > area from the phandle list "shmem".
> > >=20
> >=20
> > We use SCMI_SHARED_MEMORY to get whole memory region (0x10 pages in my =
case),
> > we can use for the agents. As you can see below - Hypervisor received n=
umber of
> > agents from Firmware and split this region between agents.
>=20
> In general we can't use properties that are not part of the device tree
> spec, either https://urldefense.com/v3/__https://www.devicetree.org/speci=
fications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595r=
MOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/g=
it/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_29dbcQI=
UBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXloYUaj$ =
[git[.]kernel[.]org]
>=20
> "linux,scmi_mem" is currently absent. Are you aware of any upstreaming
> activities to get "linux,scmi_mem" upstream under
> Documentation/devicetree/bindings in Linux?
>=20
> If "linux,scmi_mem" is going upstream in Linux, then we could use it.
> Otherwise, first "linux,scmi_mem" needs to be added somewhere under
> Documentation/devicetree/bindings (probably
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we can
> work on the Xen code that makes use of it.
>=20
> Does it make sense?
>=20

Yes I agree. I think linux,scmi_mem and scmi_devid should be upstreamed.
I will add those properties to arm,scmi.yaml, mark them as related to XEN a=
nd send patch.


> =20
> > > > +    if ( IS_ERR_OR_NULL(shmem_node) )
> > > > +    {
> > > > +        printk(XENLOG_ERR
> > > > +               "scmi: Device tree error, can't parse shmem phandle=
 %ld\n",
> > > > +               PTR_ERR(shmem_node));
> > > > +        return false;
> > > > +    }
> > > > +
> > > > +    ret =3D dt_device_get_address(shmem_node, 0, &scmi_data.shmem_=
addr,
> > > > +                                &scmi_data.shmem_size);
> > > > +    if ( IS_ERR_VALUE(ret) )
> > > > +        return false;
> > > > +
> > > > +    channel =3D smc_create_channel(HYP_CHANNEL, func_id, scmi_data=
.shmem_addr);
> > > > +    if ( IS_ERR(channel) )
> > > > +        return false;
> > > > +
> > > > +    hdr.id =3D SCMI_BASE_PROTOCOL_ATTIBUTES;
> > > > +    hdr.type =3D 0;
> > > > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > > > +
> > > > +    ret =3D do_smc_xfer(channel, &hdr, NULL, 0, &rx, sizeof(rx));
> > > > +    if ( ret )
> > > > +        goto clean;
> > > > +
> > > > +    ret =3D check_scmi_status(rx.status);
> > > > +    if ( ret )
> > > > +        goto clean;
> > > > +
> > > > +    n_agents =3D FIELD_GET(MSG_N_AGENTS_MASK, rx.attributes);
> > > > +    printk(XENLOG_DEBUG "scmi: Got agent count %d\n", n_agents);
> > > > +
> > > > +    n_agents =3D (n_agents > scmi_data.shmem_size / PAGE_SIZE) ?
> > > > +        scmi_data.shmem_size / PAGE_SIZE : n_agents;
> > > > +
> > > > +    for ( i =3D 1; i < n_agents; i++ )
> > > > +    {
> > >=20
> > > Given that HYP_CHANNEL is actually zero, it looks like we could do
> > > everything here in this loop but starting from i=3D0?
> > >=20
> >=20
> > We allocate HYP_CHANNEL before loop because we need it to request numbe=
r
> > of agents. And we don't need to send SCMI_BASE_DISCOVER_AGENT to
> > HYP_CHANNEL.
> =20
> OK
>=20
> =20
> > > > +        uint32_t tx_agent_id =3D 0xFFFFFFFF;
> > > > +        struct {
> > > > +            int32_t status;
> > > > +            uint32_t agent_id;
> > > > +            char name[16];
> > > > +        } da_rx;
> > > > +
> > > > +        agent_channel =3D smc_create_channel(i, func_id, scmi_data=
.shmem_addr +
> > > > +                                           i * PAGE_SIZE);
> > > > +        if ( IS_ERR(agent_channel) )
> > > > +        {
> > > > +            ret =3D PTR_ERR(agent_channel);
> > > > +            goto clean;
> > > > +        }
> > > > +
> > > > +        hdr.id =3D SCMI_BASE_DISCOVER_AGENT;
> > > > +        hdr.type =3D 0;
> > > > +        hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > > > +
> > > > +        ret =3D do_smc_xfer(agent_channel, &hdr, &tx_agent_id,
> > > > +                          sizeof(tx_agent_id), &da_rx, sizeof(da_r=
x));
> > > > +        if ( ret )
> > > > +            goto clean;
> > > > +
> > > > +        ret =3D check_scmi_status(da_rx.status);
> > > > +        if ( ret )
> > > > +            goto clean;
> > > > +
> > > > +        printk(XENLOG_DEBUG "scmi: status=3D0x%x id=3D0x%x name=3D=
%s\n",
> > > > +                da_rx.status, da_rx.agent_id, da_rx.name);
> > > > +
> > > > +        agent_channel->agent_id =3D da_rx.agent_id;
> > > > +    }
> > > > +
> > > > +    scmi_data.initialized =3D true;
> > > > +    return true;
> > > > +
> > > > +clean:
> > > > +    free_channel_list();
> > > > +    return ret =3D=3D 0;
> > > > +}
> > > > +
> > > > +static int scmi_domain_init(struct domain *d)
> > > > +{
> > > > +    struct scmi_channel *channel;
> > > > +    int ret;
> > > > +
> > > > +    if ( !scmi_data.initialized )
> > > > +        return 0;
> > > > +
> > > > +    channel =3D aquire_scmi_channel(d->domain_id);
> > > > +    if ( IS_ERR_OR_NULL(channel) )
> > > > +        return -ENOENT;
> > > > +
> > > > +    printk(XENLOG_INFO "scmi: Aquire SCMI channel id =3D 0x%x , do=
main_id =3D %d"
> > > > +           "paddr =3D 0x%lx\n", channel->chan_id, channel->domain_=
id,
> > > > +           channel->paddr);
> > > > +
> > > > +    if ( is_hardware_domain(d) )
> > > > +    {
> > > > +        ret =3D map_memory_to_domain(d, scmi_data.shmem_addr,
> > > > +                                   scmi_data.shmem_size);
> > > > +        if ( IS_ERR_VALUE(ret) )
> > > > +            goto error;
> > > > +
> > > > +        ret =3D dt_update_domain_range(d, channel->paddr, PAGE_SIZ=
E);
> > > > +        if ( IS_ERR_VALUE(ret) )
> > > > +        {
> > > > +            int rc =3D unmap_memory_from_domain(d, scmi_data.shmem=
_addr,
> > > > +                                              scmi_data.shmem_size=
);
> > > > +            if ( rc )
> > > > +                printk(XENLOG_ERR "Unable to unmap_memory_from_dom=
ain\n");
> > > > +
> > > > +            goto error;
> > > > +        }
> > > > +    }
> > >=20
> > > Is dom0 the only domain to get direct access to the shared memory
> > > region? If so, I don't think it is a good idea to make Dom0 "special"=
 in
> > > this case.
> > >=20
> > > Let me make an example: if we assign a device to a domU since boot, a=
nd
> > > dom0 wants to change the frequency of a clock that affects the assign=
ed
> > > device (likely because it doesn't know it is assigned), then dom0
> > > shouldn't be able to.  We might have to perform checks in Xen to make
> > > sure dom0 cannot stop the clock for the assigned device.=20
> > >=20
> > > So I think it would be better if all domains are treated the same way=
 in
> > > the mediator unless really necessary.
> > >=20
> > > On the other hand, if all domains get access to the shared memory
> > > region, then I don't think this is likely the right place to create t=
he
> > > dom0 mapping. We probably want to do it in domain_build.c in a way th=
at
> > > can be reused for dom0less domUs.
> > >=20
> >=20
> > The idea is that all domains have their own page in shared memory
> > region and unigue agent_id. Agent_id is used to set permissions for
> > clocks\resets\power-domains etc. So during creation of domain (domUs or
> > dom0) device-tree is processed using scmi_add_dt_device and
> > clocks\resets\power-domains which are related to dom0 devices will be
> > requested by using SCMI_BASE_SET_DEVICE_PERMISSIONS message.
> > All passed-through devices will be requested during DomU creation. Whic=
h
> > means dom0 do not have an access to clocks\resets\power-domains, which
> > are related to DomU.
>=20
> OK, excellent
>=20
>=20
> > > In regards to shared memory: it looks like the only two functions to
> > > access the real shared memory are send_smc_message and get_smc_respon=
se.
> > > If that is the case, then we actually don't need to expose the real
> > > shared memory to any of the domains.
> > >=20
> > > We could simply:
> > >=20
> > > - expose a regular normal memory region as dom0/domU channel memory
> > > - on SMC trap, read from the "fake" shared memory and set the
> > >   corresponding real shared memory on the appropriate channel
> > > - issue the SMC call
> > > - on return from SMC, copy over data from the real shared memory to t=
he
> > >   "fake" channel reagion
> >=20
> > Hypervisor redirects only SMC calls from guests and set agent_id to SMC
> > parameters as a7. The idea was to give page for each agent, so we don't
> > need to make additional read/write each time we receive SMC call.
> > All we povide from hypervisor is agent_id. Firmware is responsible for
> > reading memory from the correct address and place the response.
> >=20
> > >=20
> > > This is useful if we need to "filter" any of the SCMI commands and
> > > options from the domains to the firmware, and also it is useful if th=
e
> > > channel memory is not page aligned. But if the permissions are
> > > fine-grained enough and also the channel memory is page aligned (and
> > > multiple of 4K in size) then we could map the memory.
> > >=20
> >=20
> > In current implementation we suppose that channel memory is page aligne=
d.
> > I think that Firmware should be responsible for permissions handling an=
d
> > "filtering", that's why permission calls were added to SCMI spec.
> > I tried to make mediator as thin as possible.
>=20
> OK. Can we check that the channel memory is page aligned at init time
> and throw an error if it is not the case?
>=20

Yes. I will add this check in v2.

>=20
> > > > +
> > > > +    d->arch.sci =3D channel;
> > > > +
> > > > +    return 0;
> > > > +error:
> > > > +    relinquish_scmi_channel(channel);
> > > > +
> > > > +    return ret;
> > > > +}
> > > > +
> > > > +static int scmi_add_device_by_devid(struct domain *d, uint32_t scm=
i_devid)
> > > > +{
> > > > +    struct scmi_channel *channel, *agent_channel;
> > > > +    scmi_msg_header_t hdr;
> > > > +    scmi_perms_tx_t tx;
> > > > +    struct rx_t {
> > > > +        int32_t status;
> > > > +        uint32_t attributes;
> > > > +    } rx;
> > > > +    int ret;
> > > > +
> > > > +    if ( !scmi_data.initialized )
> > > > +        return 0;
> > > > +
> > > > +    printk(XENLOG_DEBUG "scmi: scmi_devid =3D %d\n", scmi_devid);
> > > > +
> > > > +    agent_channel =3D get_channel_by_domain(d->domain_id);
> > > > +    if ( IS_ERR_OR_NULL(agent_channel) )
> > > > +        return PTR_ERR(agent_channel);
> > > > +
> > > > +    channel =3D get_channel_by_id(HYP_CHANNEL);
> > > > +    if ( IS_ERR_OR_NULL(channel) )
> > > > +        return PTR_ERR(channel);
> > > > +
> > > > +    hdr.id =3D SCMI_BASE_SET_DEVICE_PERMISSIONS;
> > > > +    hdr.type =3D 0;
> > > > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > > > +
> > > > +    tx.agent_id =3D agent_channel->agent_id;
> > > > +    tx.device_id =3D scmi_devid;
> > > > +    tx.flags =3D SCMI_ALLOW_ACCESS;
> > > > +
> > > > +    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeo=
f(&rx));
> > > > +    if ( IS_ERR_VALUE(ret) )
> > > > +        return ret;
> > > > +
> > > > +    ret =3D check_scmi_status(rx.status);
> > > > +    if ( IS_ERR_VALUE(ret) )
> > > > +        return ret;
> > > > +
> > > > +    return 0;
> > > > +}
> > > > +
> > > > +static int scmi_add_dt_device(struct domain *d, struct dt_device_n=
ode *dev)
> > > > +{
> > > > +    uint32_t scmi_devid;
> > > > +
> > > > +    if ( (!scmi_data.initialized) || (!d->arch.sci) )
> > > > +        return 0;
> > > > +
> > > > +    if ( !dt_property_read_u32(dev, "scmi_devid", &scmi_devid) )
> > > > +        return 0;
> > >=20
> > > scmi_devid is another property that is not documented in the binding.
> > >=20
> >=20
> > This property should be added to the device nodes, which are using scmi
> > to work with clocks\resets\power-domains etc. This id should match the
> > device_id, defined in Firmware. Hypervisor send this device_id to the F=
irmware
> > as parameter to the permission request. Firmware set permissions to
> > clocks\resets\power-domains, related to this device.
>=20
> OK, I see. Unfortunately, scmi_devid is also not described under
> Documentation/devicetree/bindings/.
>=20
> This property seems to be actually required for the system to work
> correctly.
>=20
> Unless somebody else is already working on this, please send a patch to
> the Linux kernel mailing list CCing the SCMI maintainers and Rob Herring
> to introduce scmi_devid as a new property.
>=20

I will prepare and send patch introducing scmi_devid and linux,scmi_mem.

>=20
> > > > +    printk(XENLOG_INFO "scmi: dt_node =3D %s\n", dt_node_full_name=
(dev));
> > > > +
> > > > +    return scmi_add_device_by_devid(d, scmi_devid);
> > > > +}
> > > > +
> > > > +static int scmi_relinquish_resources(struct domain *d)
> > > > +{
> > > > +    int ret;
> > > > +    struct scmi_channel *channel, *agent_channel;
> > > > +    scmi_msg_header_t hdr;
> > > > +    struct reset_agent_tx {
> > > > +        uint32_t agent_id;
> > > > +        uint32_t flags;
> > > > +    } tx;
> > > > +    uint32_t rx;
> > > > +
> > > > +    if ( !d->arch.sci )
> > > > +        return 0;
> > > > +
> > > > +    agent_channel =3D d->arch.sci;
> > > > +
> > > > +    spin_lock(&agent_channel->lock);
> > > > +    tx.agent_id =3D agent_channel->agent_id;
> > > > +    spin_unlock(&agent_channel->lock);
> > > > +
> > > > +    channel =3D get_channel_by_id(HYP_CHANNEL);
> > > > +    if ( !channel )
> > > > +    {
> > > > +        printk(XENLOG_ERR
> > > > +               "scmi: Unable to get Hypervisor scmi channel for do=
main %d\n",
> > > > +               d->domain_id);
> > > > +        return -EINVAL;
> > > > +    }
> > > > +
> > > > +    hdr.id =3D SCMI_BASE_RESET_AGENT_CONFIGURATION;
> > > > +    hdr.type =3D 0;
> > > > +    hdr.protocol =3D SCMI_BASE_PROTOCOL;
> > > > +
> > > > +    tx.flags =3D 0;
> > > > +
> > > > +    ret =3D do_smc_xfer(channel, &hdr, &tx, sizeof(tx), &rx, sizeo=
f(rx));
> > > > +    if ( ret )
> > > > +        return ret;
> > > > +
> > > > +    ret =3D check_scmi_status(rx);
> > > > +
> > > > +    return ret;
> > > > +}
> > > > +
> > > > +static void scmi_domain_destroy(struct domain *d)
> > > > +{
> > > > +    struct scmi_channel *channel;
> > > > +
> > > > +    if ( !d->arch.sci )
> > > > +        return;
> > > > +
> > > > +    channel =3D d->arch.sci;
> > > > +    spin_lock(&channel->lock);
> > > > +
> > > > +    relinquish_scmi_channel(channel);
> > > > +    printk(XENLOG_DEBUG "scmi: Free domain %d\n", d->domain_id);
> > > > +
> > > > +    d->arch.sci =3D NULL;
> > > > +
> > > > +    unmap_memory_from_domain(d, channel->paddr, PAGE_SIZE);
> > > > +    spin_unlock(&channel->lock);
> > > > +    return;
> > > > +}
> > > > +
> > > > +static bool scmi_handle_call(struct domain *d, void *args)
> > > > +{
> > > > +    bool res =3D false;
> > > > +    struct scmi_channel *agent_channel;
> > > > +    struct arm_smccc_res resp;
> > > > +    struct cpu_user_regs *regs =3D args;
> > > > +
> > > > +    if ( !d->arch.sci )
> > > > +        return false;
> > > > +
> > > > +    agent_channel =3D d->arch.sci;
> > > > +    spin_lock(&agent_channel->lock);
> > > > +
> > > > +    if ( agent_channel->func_id !=3D regs->x0 )
> > > > +    {
> > > > +        printk(XENLOG_ERR "scmi: func_id mismatch, exiting\n");
> > > > +        goto unlock;
> > > > +    }
> > > > +
> > > > +    arm_smccc_smc(agent_channel->func_id, 0, 0, 0, 0, 0, 0,
> > > > +                  agent_channel->chan_id, &resp);
> > > > +
> > > > +    set_user_reg(regs, 0, resp.a0);
> > > > +    set_user_reg(regs, 1, resp.a1);
> > > > +    set_user_reg(regs, 2, resp.a2);
> > > > +    set_user_reg(regs, 3, resp.a3);
> > > > +    res =3D true;
> > > > +unlock:
> > > > +    spin_unlock(&agent_channel->lock);
> > > > +
> > > > +    return res;
> > > > +}
> > > > +
> > > > +static int scmi_get_channel_paddr(void *scmi_ops,
> > > > +                           struct xen_arch_domainconfig *config)
> > > > +{
> > > > +    struct scmi_channel *agent_channel =3D scmi_ops;
> > > > +
> > > > +    if ( !agent_channel )
> > > > +        return -EINVAL;
> > > > +
> > > > +    config->sci_agent_paddr =3D agent_channel->paddr;
> > > > +    return 0;
> > > > +}
> > >=20
> > > I am still not sure why it couldn't be done by scmi_domain_init.
> > >
> >=20
> > I can move this logic to scmi_domain_init, but in this case I have to a=
dd
> > struct xen_arch_domainconfig *config as input parameter to
> > scmi_domain_init and pass NULL from construct_dom0.
> > Do you think this approach would be better?
>=20
> I think it is OK to pass struct xen_arch_domainconfig *config as input
> parameter to scmi_domain_init.

Ok, I will fix it in v2.

>=20
> For dom0, why is sci_agent_paddr not supposed to be set?
>=20

paddr is the channel address. We need this address to update reg address
of arm,scmi-shmem node in guest device-tree, so guest scmi driver will
use shmem related to it.

>=20
>=20
> > Also I think it's reasonable to pass xen_arch_domainconfig so different
> > implementations could set another data they would probably need.
> >=20
> > >=20
> > > > +static const struct dt_device_match scmi_smc_match[] __initconst =
=3D
> > > > +{
> > > > +    DT_MATCH_SCMI_SMC,
> > > > +    { /* sentinel */ },
> > > > +};
> > > > +
> > > > +static const struct sci_mediator_ops scmi_ops =3D
> > > > +{
> > > > +    .probe =3D scmi_probe,
> > > > +    .domain_init =3D scmi_domain_init,
> > > > +    .domain_destroy =3D scmi_domain_destroy,
> > > > +    .add_dt_device =3D scmi_add_dt_device,
> > > > +    .relinquish_resources =3D scmi_relinquish_resources,
> > > > +    .handle_call =3D scmi_handle_call,
> > > > +    .get_channel_info =3D scmi_get_channel_paddr
> > > > +};
> > > > +
> > > > +REGISTER_SCI_MEDIATOR(scmi_smc, "SCMI-SMC", XEN_DOMCTL_CONFIG_SCI_=
SCMI_SMC,
> > > > +                      scmi_smc_match, &scmi_ops);
> > > > +
> > > > +/*
> > > > + * Local variables:
> > > > + * mode: C
> > > > + * c-file-style: "BSD"
> > > > + * c-basic-offset: 4
> > > > + * indent-tabs-mode: nil
> > > > + * End:
> > > > + */
> > > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arc=
h-arm.h
> > > > index 9180be5e86..a67237942d 100644
> > > > --- a/xen/include/public/arch-arm.h
> > > > +++ b/xen/include/public/arch-arm.h
> > > > @@ -315,6 +315,7 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> > > >  #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> > > > =20
> > > >  #define XEN_DOMCTL_CONFIG_SCI_NONE      0
> > > > +#define XEN_DOMCTL_CONFIG_SCI_SCMI_SMC  1
> > > > =20
> > > >  struct xen_arch_domainconfig {
> > > >      /* IN/OUT */=


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 21:23:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 21:23:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250609.431631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzmb7-0003F0-PV; Tue, 21 Dec 2021 21:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250609.431631; Tue, 21 Dec 2021 21:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzmb7-0003Et-MV; Tue, 21 Dec 2021 21:23:01 +0000
Received: by outflank-mailman (input) for mailman id 250609;
 Tue, 21 Dec 2021 21:23:00 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzmb6-0003En-1M
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 21:23:00 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 29dd26fb-62a4-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 22:22:57 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 58B89CE1A18;
 Tue, 21 Dec 2021 21:22:52 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69CF4C36AE8;
 Tue, 21 Dec 2021 21:22:50 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 29dd26fb-62a4-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640121770;
	bh=O5ytEHIvHXIpUKcScg6MrrYxZBlW64EhXZK0iJsnVcQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=aTIXC8faXX2uIOn7EddjmC0F29T0bHTV73LnTpWE4KhoE4u6Q/jWz1P4Gol0yClYt
	 8ixsF/JGk6ywUlnUuaWqh5jBE040sZu3nMk647JPToMtqrNA9EAFT05R/aMq4neoo6
	 NnvYrrJE6J928EVL6Hq5WuvuJ0fPvmX4Roee7PvoiXodB+ASFSd1N2y0K1bax7vo5Q
	 htc399iYeEU3VtB46PsH//wxiVgo4TPpD9045RiE6vWPo+IPb7XcEwjzaZsOAVyW3k
	 hVoFvT9Za1wyiym30p9MsTeRfwx+T9s+7F+AzeiL4LWRJJ+0ZOAwKaXYeHBwQCTH/q
	 1s7k8uspd2zOQ==
Date: Tue, 21 Dec 2021 13:22:50 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20211221200305.GA2460476@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com> <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop> <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop> <20211221200305.GA2460476@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> Hi Stefano,
> 
> On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > Hi Stefano,
> > > 
> > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > This is the implementation of SCI interface, called SCMI-SMC driver,
> > > > > which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> > > > > This allows devices from the Domains to work with clocks, resets and
> > > > > power-domains without access to CPG.
> > > > > 
> > > > > The following features are implemented:
> > > > > - request SCMI channels from ATF and pass channels to Domains;
> > > > > - set device permissions for Domains based on the Domain partial
> > > > > device-tree. Devices with permissions are able to work with clocks,
> > > > > resets and power-domains via SCMI;
> > > > > - redirect scmi messages from Domains to ATF.
> > > > > 
> > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > ---
> > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
> > > > >  xen/include/public/arch-arm.h |   1 +
> > > > >  5 files changed, 809 insertions(+)
> > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > 
> > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > > index 186e1db389..02d96c6cfc 100644
> > > > > --- a/xen/arch/arm/Kconfig
> > > > > +++ b/xen/arch/arm/Kconfig
> > > > > @@ -114,6 +114,8 @@ config SCI
> > > > >  	  support. It allows guests to control system resourcess via one of
> > > > >  	  SCI mediators implemented in XEN.
> > > > >  
> > > > > +source "arch/arm/sci/Kconfig"
> > > > > +
> > > > >  endmenu
> > > > >  
> > > > >  menu "ARM errata workaround via the alternative framework"
> > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > > > > new file mode 100644
> > > > > index 0000000000..9563067ddc
> > > > > --- /dev/null
> > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > @@ -0,0 +1,10 @@
> > > > > +config SCMI_SMC
> > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > +	default n
> > > > > +	depends on SCI
> > > > > +	---help---
> > > > > +
> > > > > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> > > > > +	This feature allows drivers from Domains to work with System
> > > > > +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> > > > > +	for communication.
> > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > > > > index 837dc7492b..67f2611872 100644
> > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > @@ -1 +1,2 @@
> > > > >  obj-y += sci.o
> > > > > +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> > > > > new file mode 100644
> > > > > index 0000000000..2eb01ea82d
> > > > > --- /dev/null
> > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > @@ -0,0 +1,795 @@
> > > > > +/*
> > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > + *
> > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > + *
> > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > + *
> > > > > + * This program is free software; you can redistribute it and/or modify
> > > > > + * it under the terms of the GNU General Public License as published by
> > > > > + * the Free Software Foundation; either version 2 of the License, or
> > > > > + * (at your option) any later version.
> > > > > + *
> > > > > + * This program is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + */
> > > > > +
> > > > > +#include <asm/sci/sci.h>
> > > > > +#include <asm/smccc.h>
> > > > > +#include <asm/io.h>
> > > > > +#include <xen/bitops.h>
> > > > > +#include <xen/config.h>
> > > > > +#include <xen/sched.h>
> > > > > +#include <xen/device_tree.h>
> > > > > +#include <xen/iocap.h>
> > > > > +#include <xen/init.h>
> > > > > +#include <xen/err.h>
> > > > > +#include <xen/lib.h>
> > > > > +#include <xen/list.h>
> > > > > +#include <xen/mm.h>
> > > > > +#include <xen/string.h>
> > > > > +#include <xen/time.h>
> > > > > +#include <xen/vmap.h>
> > > > > +
> > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > +
> > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > > > > +#define SCMI_SUCCESS              0
> > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > +#define SCMI_DENIED             (-3)
> > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > +#define SCMI_BUSY               (-6)
> > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > +
> > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > > > +
> > > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > > > 
> > > > I could find the following SCMI binding in Linux, which describes
> > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > 
> > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > 
> > > > However, linux,scmi_mem is not described. Aren't you supposed to read
> > > > the "shmem" property instead? And the compatible string used for this
> > > > seems to be "arm,scmi-shmem".
> > > > 
> > > 
> > > We use linux,scmi_mem node to reserve memory, needed for all
> > > channels:
> > > 
> > > reserved-memory {
> > >     /* reserved region for scmi channels*/
> > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > >         no-map;
> > >         reg = <0x0 0x53FF0000 0x0 0x10000>;
> > >     };
> > > };
> > > 
> > > arm,scmi-shmem node used in shmem property defines only 1 page needed to
> > > the current scmi channel:
> > > 
> > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > >     compatible = "arm,scmi-shmem";
> > >     reg = <0x0 0x53FF0000 0x0 0x1000>;
> > > };
> > > 
> > > For each Domain reg points to unigue page from linux,scmi_mem region,
> > > assigned to this agent.
> > 
> > If we were to use "linux,scmi_mem" we would have to introduce it as a
> > compatible string, not as a node name, and it would need to be described
> > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > 
> > But from your description I don't think it is necessary. We can just use
> > "arm,scmi-shmem" to describe all the required regions:
> > 
> > reserved-memory {
> >     scp-shmem@0x53FF0000 {
> >         compatible = "arm,scmi-shmem";
> >         reg = <0x0 0x53FF0000 0x0 0x1000>;
> >     };
> >     scp-shmem@0x53FF1000 {
> >         compatible = "arm,scmi-shmem";
> >         reg = <0x0 0x53FF1000 0x0 0x1000>;
> >     };
> >     scp-shmem@0x53FF2000 {
> >         compatible = "arm,scmi-shmem";
> >         reg = <0x0 0x53FF2000 0x0 0x1000>;
> >     };
> >     ...
> > 
> > In other words, if all the individual channel pages are described as
> > "arm,scmi-shmem", why do we also need a single larger region as
> > "linux,scmi_mem"?
> > 
> 
> That was my first implementation. But I've met a problem with
> scmi driver in kernel. I don't remember the exact place, but I remember
> there were some if, checking if memory weren't reserved.
> That's why I ended up splitting nodes reserved memory region and actual
> shmem page.
> For linux,scmi_mem node I took format from /reserved-memory/linux,lossy_decompress@54000000,
> which has no compatible string and provides no-map property.
> linux,scmi_shmem node is needed to prevent xen from allocating this
> space for the domain.
> 
> Very interesting question about should I introduce linux,scmi_mem node
> and scmi_devid property to the
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> Those node and property are needed only for Xen and useless for
> non-virtualized systems. I can add this node and property description to
> arm,scmi.yaml, but leave a note that this is Xen specific params.
> What do you think about it?

Reply below

[...]
 

> > In general we can't use properties that are not part of the device tree
> > spec, either https://urldefense.com/v3/__https://www.devicetree.org/specifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXloYUaj$ [git[.]kernel[.]org]
> > 
> > "linux,scmi_mem" is currently absent. Are you aware of any upstreaming
> > activities to get "linux,scmi_mem" upstream under
> > Documentation/devicetree/bindings in Linux?
> > 
> > If "linux,scmi_mem" is going upstream in Linux, then we could use it.
> > Otherwise, first "linux,scmi_mem" needs to be added somewhere under
> > Documentation/devicetree/bindings (probably
> > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we can
> > work on the Xen code that makes use of it.
> > 
> > Does it make sense?
> > 
> 
> Yes I agree. I think linux,scmi_mem and scmi_devid should be upstreamed.
> I will add those properties to arm,scmi.yaml, mark them as related to XEN and send patch.

I didn't realize that linux,scmi_mem and scmi_devid are supposed to be
Xen specific. In general, it would be best not to introduce Xen specific
properties into generic bindings. It is a problem both from a
specification perspective (because it has hard to handle Xen specific
cases in fully generic bindings, especially as those bindings are
maintained as part of the Linux kernel) and from a user perspective
(because now the user has to deal with a Xen-specific dtb, or has to
modify the host dtb to add Xen-specific information by hand.)


Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? It
looks like a generic property that should be needed for the Linux SCMI
driver too. Why the Linux driver doesn't need it?


In regards to linux,scmi_mem, I think it would be best to do without it
and fix the Linux SCMI driver if we need to do so. Xen should be able to
parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) should
be able to parse the "arm,scmi-shmem" nodes generated by Xen. Either
way, I don't think we should need linux,scmi_mem.


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 21:39:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 21:39:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250612.431642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzmr3-00054D-5Q; Tue, 21 Dec 2021 21:39:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250612.431642; Tue, 21 Dec 2021 21:39:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzmr3-000546-2b; Tue, 21 Dec 2021 21:39:29 +0000
Received: by outflank-mailman (input) for mailman id 250612;
 Tue, 21 Dec 2021 21:39:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=mNu3=RG=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1mzmr1-000540-NE
 for xen-devel@lists.xenproject.org; Tue, 21 Dec 2021 21:39:27 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 77989d3d-62a6-11ec-bb0b-79c175774b5d;
 Tue, 21 Dec 2021 22:39:25 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id BF34EB817E6;
 Tue, 21 Dec 2021 21:39:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0945FC36AE9;
 Tue, 21 Dec 2021 21:39:21 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77989d3d-62a6-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640122762;
	bh=eY3zV6xgSLXE3r037M1tp0F6xSMSmlF0V0wfDBlBEt4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=qnc8h031Hlv/ytK+CyjKZXBApan/qvbp2FB8FYiV76SkKwV7K3ao+L8Ecz5QHPmXo
	 wzcbKxNDokum/qBtGtn12mZ4XTw7XctPXdlAABWrZa6NsttTeCn9KOr9M9DfUnAgDi
	 lZcE+E0d7/KvdGOP8+Hetkg/kV1lJOHQ4dEECGqaU/ihi6B3wm3wHX8cZdbYQJwibw
	 rgKpwAWk6KEmqDI3wzz+HxVNnre0zUPmkuURKlbdjF29fyrT3+EjqZCbsaO8LlNbtI
	 pGwVDlViG6LHc10HrwC3yx1lbGpvEAkfNeAV0G7+N37+lW5DEcGd3iObZzRbs7gd7F
	 Ds0xtAvr+hB8Q==
Date: Tue, 21 Dec 2021 13:39:22 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Anthony PERARD <anthony.perard@citrix.com>
cc: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Julien Grall <julien@xen.org>, Stefano Stabellini <sstabellini@kernel.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
In-Reply-To: <YcHol8ads22asXGF@perard>
Message-ID: <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com> <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com> <20211217121524.GA4021162@EPUAKYIW015D>
 <YcHol8ads22asXGF@perard>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-303666308-1640122251=:2060010"
Content-ID: <alpine.DEB.2.22.394.2112211331110.2060010@ubuntu-linux-20-04-desktop>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-303666308-1640122251=:2060010
Content-Type: text/plain; CHARSET=UTF-8
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.22.394.2112211331111.2060010@ubuntu-linux-20-04-desktop>

On Tue, 21 Dec 2021, Anthony PERARD wrote:
> On Fri, Dec 17, 2021 at 12:15:25PM +0000, Oleksii Moisieiev wrote:
> > > On 14.12.21 11:34, Oleksii Moisieiev wrote:
> > > > @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
> > > >   {
> > > >       AO_GC;
> > > >       libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
> > > > -    int i, rc = 0;
> > > > +    int i, rc = 0, rc_sci = 0;
> > > >       for (i = 0; i < d_config->num_dtdevs; i++) {
> > > >           const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
> > > >           LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
> > > >           rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> > > > -        if (rc < 0) {
> > > > -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> > > > +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
> > > > +
> > > > +        if ((rc < 0) && (rc_sci < 0)) {
> > > > +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> > > > +                 "xc_domain_add_sci_device failed: %d",
> > > > +                 rc, rc_sci);
> > > >               goto out;
> > > >           }
> > > > +
> > > > +        if (rc)
> > > > +            rc = rc_sci;
> > > 
> > > 
> > > If I get this code right, it sounds like the dom.cfg's dtdev property is
> > > reused to describe sci devices as well, but the libxl__add_dtdevs() does not
> > > (and can not) differentiate them. So it has no option but to send two
> > > domctls for each device in dtdevs[] hoping to at least one domctl to
> > > succeeded. Or I really missed something?
> > > 
> > > It feels to me that:
> > >  - either new dom.cfg's property could be introduced (scidev?) to describe
> > > sci devices together with new parsing logic/management code, so you will end
> > > up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
> > > so no mixing things.
> > >  - or indeed dtdev logic could be *completely* reused including extending
> > > XEN_DOMCTL_assign_device to cover your use-case, although sounds generic, it
> > > is used to describe devices for the passthrough (to configure an IOMMU for
> > > the device), in that case you wouldn't need an extra
> > > XEN_DOMCTL_add_sci_device introduced by current patch.

I realize I did my review before reading Oleksandr's comments. I fully
agree with his feedback. Having seen how difficult is for users to setup
a domU configuration correctly today, I would advise to try to reuse the
existing dtdev property instead of adding yet one new property to make
the life of our users easier.



> > > Personally I would use the first option as I am not sure that second option
> > > is conceptually correct && possible. I would leave this for the maintainers
> > > to clarify.
> > > 
> > 
> > Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
> > seems not to be conceptually correct. Introducing new dom.cfg property
> > seems to be the only way to avoid extra Domctl calls.
> > I will handle this in v2 if there will be no complains from Maintainers.
> 
> I don't know if there will be a complains in v2 or not :-), but using
> something different from dtdev sound good.
> 
> If I understand correctly, dtdev seems to be about passing through an
> existing device to a guest, and this new sci device seems to be about having Xen
> "emulating" an sci device which the guest will use. So introducing
> something new (scidev or other name) sounds good.

Users already have to provide 4 properties (dtdev, iomem, irqs,
device_tree) to setup device assignment. I think that making it 5
properties would not be a step forward :-)

To me dtdev and XEN_DOMCTL_assign_device are appropriate because they
signify device assignment of one or more devices. We are not adding any
additional "meaning" to them. It is just that we'll automatically detect
and generate any SCMI configurations based on the list of assigned
devices. Because if SCMI is enabled and a device is assigned to the
guest, then I think we want to add the device to the SCMI list of
devices automatically.

If we really want to introduce a new list of devices, please make it
optional so that most times the user can skip it unless really required.
--8323329-303666308-1640122251=:2060010--


From xen-devel-bounces@lists.xenproject.org Tue Dec 21 23:48:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 21 Dec 2021 23:48:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250623.431662 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzorV-00021g-RS; Tue, 21 Dec 2021 23:48:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250623.431662; Tue, 21 Dec 2021 23:48:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzorV-00021Z-MJ; Tue, 21 Dec 2021 23:48:05 +0000
Received: by outflank-mailman (input) for mailman id 250623;
 Tue, 21 Dec 2021 23:48:05 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzorV-00021P-4u; Tue, 21 Dec 2021 23:48:05 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzorV-000431-2Q; Tue, 21 Dec 2021 23:48:05 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzorU-0005F6-NQ; Tue, 21 Dec 2021 23:48:04 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzorU-0005Uw-Mv; Tue, 21 Dec 2021 23:48:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jvUtMzQQ04iv1KXKxjbNjh93fQQm2ov/9ClYXCs5guo=; b=jrWM+yIsAvX2VAghi6/OIOye2I
	i8df4/suH1/FuMss3gPpK4mgdtBs2ZsevcBCVA87m0/Wdxt52sd3X4j6o/rd7lPPWrGzOIjsk7sTZ
	RuwnTmCR1LEQpOzCxaV0YCxd6gUeNIJ/fzlP1mVFYisAtd6qdXBCsgONvCzTL0ZM0c/w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167504-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167504: tolerable FAIL - PUSHED
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:allowable
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 21 Dec 2021 23:48:04 +0000

flight 167504 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167504/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds     14 guest-start              fail REGR. vs. 167497

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167497
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167497
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167497
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167497
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167497
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167497
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167497
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167497
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167497
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167497
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167497
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167497
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167497  2021-12-21 01:53:13 Z    0 days
Testing same since   167504  2021-12-21 13:39:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8e3edefb88..f1e268b9fd  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8 -> master


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 05:10:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 05:10:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250660.431691 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mztsx-0006Hz-4O; Wed, 22 Dec 2021 05:09:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250660.431691; Wed, 22 Dec 2021 05:09:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mztsw-0006Hr-UN; Wed, 22 Dec 2021 05:09:54 +0000
Received: by outflank-mailman (input) for mailman id 250660;
 Wed, 22 Dec 2021 05:09:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mztsv-0006Hh-SG; Wed, 22 Dec 2021 05:09:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mztsv-00045W-Ou; Wed, 22 Dec 2021 05:09:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mztsv-00040C-F2; Wed, 22 Dec 2021 05:09:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mztsv-00017b-Cd; Wed, 22 Dec 2021 05:09:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ModCqYowKPRKqcXU7Xafli4lqqS0jYGenWobJr6L3Fs=; b=YNmjsTAsToQ0TD6H97jlwY/gx4
	wKG9B5mm1TjyuX6o1dzyw+kY8wZPo1SF6z2o2pFq4iiWZ1gvZe1ubLYt1Y0lI3pV97xZ3G+UUsKrB
	7BNQqvMn5cVBcl93Gb94vEGHRN9M7DV6MbqgoxAZaV78VP/hwAuWKbb0DdF6fTzmScZ8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167508-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167508: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=1c3e979bf3e225e5b4b810b24712b16254d608b6
X-Osstest-Versions-That:
    linux=6e0567b7305209c2d689ce57180a63d8dc657ad8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 05:09:53 +0000

flight 167508 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167508/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167500
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167500
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167500
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167500
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167500
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167500
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167500
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167500
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                1c3e979bf3e225e5b4b810b24712b16254d608b6
baseline version:
 linux                6e0567b7305209c2d689ce57180a63d8dc657ad8

Last test of basis   167500  2021-12-21 05:30:08 Z    0 days
Testing same since   167508  2021-12-21 18:09:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   6e0567b73052..1c3e979bf3e2  1c3e979bf3e225e5b4b810b24712b16254d608b6 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 07:55:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 07:55:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250670.431701 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzwSX-0007VY-Qy; Wed, 22 Dec 2021 07:54:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250670.431701; Wed, 22 Dec 2021 07:54:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzwSX-0007VR-No; Wed, 22 Dec 2021 07:54:49 +0000
Received: by outflank-mailman (input) for mailman id 250670;
 Wed, 22 Dec 2021 07:54:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzwSV-0007VH-S4; Wed, 22 Dec 2021 07:54:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzwSV-0006rn-Ns; Wed, 22 Dec 2021 07:54:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzwSV-0004Et-Cl; Wed, 22 Dec 2021 07:54:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzwSV-0007ZI-CG; Wed, 22 Dec 2021 07:54:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=eQYsCvnMc3wjxf/I4MGJdvce82HywRKxee4KuYRQuuM=; b=50lbe9GhhJE01m5ISUC6LZjib6
	77k8SpNrXHZlXYfTKIO1qvshwrCINXaTDE7Bs7MIShBAmjS0q+ue1WtPdxpxjSwylScyfcyAChpQW
	5mGrIF6aHmWEGqQ7OpavEm5rzcxTIQzwZxMSBGn4TY3Gz/Vwm3yVYzaBR+QQvwH+h+Bs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167509-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167509: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-shadow:guest-localmigrate/x10:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=5316e12bb2b4408a1597b283ef4bb4794dd7b4f7
X-Osstest-Versions-That:
    qemuu=2bf40d0841b942e7ba12953d515e62a436f0af84
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 07:54:47 +0000

flight 167509 qemu-mainline real [real]
flight 167514 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167509/
http://logs.test-lab.xenproject.org/osstest/logs/167514/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-shadow 20 guest-localmigrate/x10 fail pass in 167514-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167501
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167501
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167501
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167501
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167501
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167501
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167501
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167501
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                5316e12bb2b4408a1597b283ef4bb4794dd7b4f7
baseline version:
 qemuu                2bf40d0841b942e7ba12953d515e62a436f0af84

Last test of basis   167501  2021-12-21 06:49:30 Z    1 days
Testing same since   167509  2021-12-21 19:38:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   2bf40d0841..5316e12bb2  5316e12bb2b4408a1597b283ef4bb4794dd7b4f7 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 08:05:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 08:05:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250688.431713 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzwdB-0001LV-Fb; Wed, 22 Dec 2021 08:05:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250688.431713; Wed, 22 Dec 2021 08:05:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzwdB-0001LO-Bg; Wed, 22 Dec 2021 08:05:49 +0000
Received: by outflank-mailman (input) for mailman id 250688;
 Wed, 22 Dec 2021 08:05:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HtqY=RH=gmail.com=ryancaicse@srs-se1.protection.inumbo.net>)
 id 1mzwdA-0001LH-00
 for xen-devel@lists.xen.org; Wed, 22 Dec 2021 08:05:48 +0000
Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com
 [2607:f8b0:4864:20::533])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f6944d37-62fd-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 09:05:46 +0100 (CET)
Received: by mail-pg1-x533.google.com with SMTP id m15so1437428pgu.11
 for <xen-devel@lists.xen.org>; Wed, 22 Dec 2021 00:05:46 -0800 (PST)
Received: from [30.135.82.253] ([8.218.232.85])
 by smtp.gmail.com with ESMTPSA id c2sm1509154pfl.200.2021.12.22.00.05.42
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 22 Dec 2021 00:05:43 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f6944d37-62fd-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=user-agent:date:subject:from:to:message-id:thread-topic
         :mime-version;
        bh=92tAYZJCH+R0jJnZ+FpbLB7ckqn85Vv7DdOdKvJSnNU=;
        b=PnNELN0IAm8UAxJ0y8Qq/9FJzVSSnK2lyHzCeFRsDCCibQ3+oAN3wQnRBpBoIZIm1m
         DAzbO23CRcPI4stwzbifdBWm3JcmbEpvIwCsmwOgXEahLGEqd/lfKRZ9TLg2cWXqvEvT
         IMvZ15jI6gvlDCCJD9ijikqzlceK0HndprpFjLI7pItZGfz8nyd+xUPZ+7IWwV8kmOzz
         1hxHoLFbmW/7PuzG2BaFEfRt1vJ8mTg/f6Lrm9rsWagCwqD5ryCXf6Nh5EQTBcrnNBji
         hq5hGvvmdjC2ZwMNF0BkS7Zr0Ocsl3fOJFpuloibC71U9hp7+px2XSPYlP5FllQf2+EC
         rndg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:user-agent:date:subject:from:to:message-id
         :thread-topic:mime-version;
        bh=92tAYZJCH+R0jJnZ+FpbLB7ckqn85Vv7DdOdKvJSnNU=;
        b=poymvZvviq/W8EQSHM7F4COHL1dHJCMU1oLEFqurUL2NisS78vYbY9CH32aSx4lMmm
         2ohFaNr/7QbtYw1uN3kO05aiiXhooCZtirz251bdMlBE+ViWvlsQkM3susYubAxh2Pcg
         h09dTyfDdJHf7iW1QFgo3iRQiapavVt3LviIN78Du+MW6oJLg0JGwxWNSroD65nTRJfd
         IIEQpu0AX4plceh6aG4r9NINtTzFu160595sdwl9+ZkmhOYVePHnCUsuvRH/rgVOQjRW
         LUcTcDvzcnMuaUORgYQyo20Q2ZjLVajNF4CR3KA44wRdpjWXWh7n2+Ne7lL1b1+uAZ9r
         bAMg==
X-Gm-Message-State: AOAM533MSp7ivWjG/Q8I/+L9CAWvs+28FWmEAiSjLDTMDbfun8Js3rDd
	DaSQN5ZluoR5n41+7fLQ0i9psuxLg7lt7mwM
X-Google-Smtp-Source: ABdhPJwSnwULjY7vc364YWVlZSH3tOLhV8PPuOCDhiL/ZKdSHzTlClwXjsEb2LE7v1CPAruC34pzrg==
X-Received: by 2002:a63:657:: with SMTP id 84mr1706685pgg.399.1640160344145;
        Wed, 22 Dec 2021 00:05:44 -0800 (PST)
User-Agent: Microsoft-MacOutlook/16.56.21121100
Date: Wed, 22 Dec 2021 16:05:40 +0800
Subject: [BUG] Resource leaks in Xen
From: Ryan Cai <ryancaicse@gmail.com>
To: <xen-devel@lists.xen.org>,
	<keir@xen.org>,
	<dgdegra@tycho.nsa.gov>
Message-ID: <62B51AB1-2C2B-402A-A7C8-5ADACE265DA4@gmail.com>
Thread-Topic: [BUG] Resource leaks in Xen
Mime-version: 1.0
Content-type: multipart/alternative;
	boundary="B_3723033942_215283608"

> This message is in MIME format. Since your mail reader does not understand
this format, some or all of this message may not be legible.

--B_3723033942_215283608
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit

Dear maintainers for Xen Project,

 

             I am writing you to report potential resource leak bugs. In the file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclose may not matched when returning at Line 76, resulting in a resource leak. Looking forward to your feedback. Thank for checking.

 

 

Locations, https://github.com/xen-project/xen/blame/25849c8b16f2a5b7fcd0a823e80a5f1b590291f9/tools/flask/utils/label-pci.c#L63-L76

 

 

Best,

Ryan Cai

 


--B_3723033942_215283608
Content-type: text/html;
	charset="UTF-8"
Content-transfer-encoding: quoted-printable

<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:schema=
s-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/office/20=
04/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta http-equiv=3DC=
ontent-Type content=3D"text/html; charset=3Dutf-8"><meta name=3DGenerator content=3D=
"Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:DengXian;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:"\@DengXian";
	panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	font-size:12.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
span.apple-converted-space
	{mso-style-name:apple-converted-space;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:12.0pt;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style></head><body lang=3DEN-HK link=3D"#0563C1" vlink=3D"#954F72" style=3D'wo=
rd-wrap:break-word'><div class=3DWordSection1><p class=3DMsoNormal><span lang=3DEN=
-US style=3D'font-size:14.0pt;font-family:"Times New Roman",serif;color:black'=
>Dear maintainers for<span class=3Dapple-converted-space>&nbsp;</span></span><=
span lang=3DEN-US style=3D'font-size:14.0pt;font-family:"Times New Roman",serif;=
color:#070706;background:#FFEE94'>Xen</span><span class=3Dapple-converted-spac=
e><span lang=3DEN-US style=3D'font-size:14.0pt;font-family:"Times New Roman",ser=
if;color:black'>&nbsp;</span></span><span lang=3DEN-US style=3D'font-size:14.0pt=
;font-family:"Times New Roman",serif;color:black'>Project,</span><span style=
=3D'font-family:"Times New Roman",serif;color:black'><o:p></o:p></span></p><p =
class=3DMsoNormal style=3D'caret-color: rgb(0, 0, 0);font-variant-caps: normal;o=
rphans: auto;text-align:start;widows: auto;-webkit-text-size-adjust: auto;-w=
ebkit-text-stroke-width: 0px;word-spacing:0px'><span lang=3DEN-US style=3D'font-=
size:14.0pt;font-family:"Times New Roman",serif;color:black'>&nbsp;</span><s=
pan style=3D'font-family:"Times New Roman",serif;color:black'><o:p></o:p></spa=
n></p><p class=3DMsoNormal style=3D'caret-color: rgb(0, 0, 0);font-variant-caps:=
 normal;orphans: auto;text-align:start;widows: auto;-webkit-text-size-adjust=
: auto;-webkit-text-stroke-width: 0px;word-spacing:0px'><span lang=3DEN-US sty=
le=3D'font-size:14.0pt;font-family:"Times New Roman",serif;color:black'>&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; I am writ=
ing you to report potential resource leak bugs. In the file /xen/tools/flask=
/utils/label-pci.c, the methods fopen and fclose may not matched when return=
ing at Line 76, resulting in a resource leak. </span><span style=3D'font-size:=
14.0pt;font-family:"Times New Roman",serif;color:black'>Looking forward to y=
our feedback. Thank for checking</span><span lang=3DEN-US style=3D'font-size:14.=
0pt;font-family:"Times New Roman",serif;color:black'>.<o:p></o:p></span></p>=
<p class=3DMsoNormal><span style=3D'font-size:14.0pt;font-family:"Times New Roma=
n",serif;color:black'>&nbsp;</span><span style=3D'font-family:"Times New Roman=
",serif;color:black'><o:p></o:p></span></p><p class=3DMsoNormal style=3D'caret-c=
olor: rgb(0, 0, 0);font-variant-caps: normal;orphans: auto;text-align:start;=
widows: auto;-webkit-text-size-adjust: auto;-webkit-text-stroke-width: 0px;w=
ord-spacing:0px'><span lang=3DEN-US style=3D'font-size:14.0pt;font-family:"Times=
 New Roman",serif;color:black'>&nbsp;</span><span style=3D'font-family:"Times =
New Roman",serif;color:black'><o:p></o:p></span></p><p class=3DMsoNormal style=
=3D'caret-color: rgb(0, 0, 0);font-variant-caps: normal;orphans: auto;text-ali=
gn:start;widows: auto;-webkit-text-size-adjust: auto;-webkit-text-stroke-wid=
th: 0px;word-spacing:0px'><span lang=3DEN-US style=3D'font-size:14.0pt;font-fami=
ly:"Times New Roman",serif;color:black'>Locations,<span class=3Dapple-converte=
d-space>&nbsp;</span><a href=3D"https://github.com/xen-project/xen/blame/25849=
c8b16f2a5b7fcd0a823e80a5f1b590291f9/tools/flask/utils/label-pci.c#L63-L76">h=
ttps://github.com/xen-project/xen/blame/25849c8b16f2a5b7fcd0a823e80a5f1b5902=
91f9/tools/flask/utils/label-pci.c#L63-L76</a><o:p></o:p></span></p><p class=
=3DMsoNormal><span style=3D'font-family:"Times New Roman",serif;color:black'><o:=
p>&nbsp;</o:p></span></p><p class=3DMsoNormal style=3D'caret-color: rgb(0, 0, 0)=
;font-variant-caps: normal;orphans: auto;text-align:start;widows: auto;-webk=
it-text-size-adjust: auto;-webkit-text-stroke-width: 0px;word-spacing:0px'><=
span lang=3DEN-US style=3D'font-size:14.0pt;font-family:"Times New Roman",serif;=
color:black'>&nbsp;</span><span style=3D'font-family:"Times New Roman",serif;c=
olor:black'><o:p></o:p></span></p><p class=3DMsoNormal style=3D'caret-color: rgb=
(0, 0, 0);font-variant-caps: normal;orphans: auto;text-align:start;widows: a=
uto;-webkit-text-size-adjust: auto;-webkit-text-stroke-width: 0px;word-spaci=
ng:0px'><span style=3D'font-size:14.0pt;font-family:"Times New Roman",serif;co=
lor:black'>Best,</span><span style=3D'font-family:"Times New Roman",serif;colo=
r:black'><o:p></o:p></span></p><p class=3DMsoNormal style=3D'caret-color: rgb(0,=
 0, 0);font-variant-caps: normal;orphans: auto;text-align:start;widows: auto=
;-webkit-text-size-adjust: auto;-webkit-text-stroke-width: 0px;word-spacing:=
0px'><span style=3D'font-size:14.0pt;font-family:"Times New Roman",serif;color=
:black'>Ryan Cai</span><span style=3D'font-family:"Times New Roman",serif;colo=
r:black'><o:p></o:p></span></p><p class=3DMsoNormal><span style=3D'font-size:11.=
0pt'><o:p>&nbsp;</o:p></span></p></div></body></html>

--B_3723033942_215283608--




From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:10:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:10:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250693.431724 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxcz-0008Nn-44; Wed, 22 Dec 2021 09:09:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250693.431724; Wed, 22 Dec 2021 09:09:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxcz-0008Ng-0V; Wed, 22 Dec 2021 09:09:41 +0000
Received: by outflank-mailman (input) for mailman id 250693;
 Wed, 22 Dec 2021 08:38:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HSO0=RH=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1mzx8r-00055O-Cs
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 08:38:33 +0000
Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com
 [2607:f8b0:4864:20::642])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8ade7283-6302-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 09:38:32 +0100 (CET)
Received: by mail-pl1-x642.google.com with SMTP id n16so1380257plc.2
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 00:38:32 -0800 (PST)
Received: from localhost.localdomain ([47.89.83.13])
 by smtp.gmail.com with ESMTPSA id 32sm1377284pgs.48.2021.12.22.00.38.28
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 22 Dec 2021 00:38:30 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8ade7283-6302-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=r+Y4oDBebTJunMFfsfrwKUoks23+cOhygHJOQ1hwjZw=;
        b=QkXn3cyvW79kGx18NXBMBe0pdQ5WGOLwcyUGDg+8gSefcsrMJGidd3ezM3EiGXEVxW
         r0CLk5n7nzm8QhSQqT5WuZjUw8UxwiG70QMQoU3u5/YDocG2QBNRgrVRAfGlduHz7n11
         +z2yS92SIqD2BMxlg3f8okziGZlZi/ZXRzoytMjxi3xWeZg1EwlAiIWIx1guR51PxOIX
         1ORX3yYDsP4E91FCJUzNJFasxlYG3K4NN4IdjGDucyGDbkoiHwdE630HWEpVWAAKKSRl
         IuaH+C/8hsH+GTHViCDBGCs+B6i/2/rB/E+nNIdxGBOxLNz6V0SUW4r9KfjmvOQlspHg
         i8tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=r+Y4oDBebTJunMFfsfrwKUoks23+cOhygHJOQ1hwjZw=;
        b=hCbjSqsxolcN8JUcoLygGD5Q+G3eCurr1WR1IuZNPVTOy67Iw+exM0fcH6e0gPUr+T
         sUvTW40ewN5yJGC/HmL8v8Cjb8NQ64IIQGofiVG+gorb12OcUW8fbdSbu61bDegpgwAt
         8Z2hGYgN9DHjW9gCL+88fS7GIDAy5sk3eLm7Wd4If1uThJI6pZZrnOPCqw9rWSwDUFd1
         xKG7ABtxvIPLD1qcR1184jyu5UjkzIsylnpP4GmtjeCXhJQQBtAWLEPj6CqrtloJnRlx
         Z4/efRPAGynzKkpxy0cLWh6ZulZz2kKwSUvVHsvCEge2dRbjmN462QhK/dHICVQZP54e
         gbMQ==
X-Gm-Message-State: AOAM530rURC98wxu9mLx8rZeHrpdumQ85EGk+FMfGaH6wGeLA0EYhRnF
	EFkSXFID/2fkYl1r9LzFe5M=
X-Google-Smtp-Source: ABdhPJzSPTCsEGF8LPYtPakp2++8JxLmw7tyryXUNkFEkC13jnjfGVcLlW+CFQ+0eb2eCO2n6d0PlA==
X-Received: by 2002:a17:902:8214:b0:142:61cf:7be with SMTP id x20-20020a170902821400b0014261cf07bemr1935778pln.0.1640162310765;
        Wed, 22 Dec 2021 00:38:30 -0800 (PST)
From: Dongjiu Geng <gengdongjiu1@gmail.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com,
	xen-devel@lists.xenproject.org
Cc: gengdongjiu1@gmail.com
Subject: [PATCH] xen/arm: fix the build error for GIC
Date: Wed, 22 Dec 2021 16:38:25 +0800
Message-Id: <20211222083825.2918045-1-gengdongjiu1@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
so fix it and make it can select GICV2.

Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
---
$ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
make -C xen install
make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o tools/kconfig/conf.c
gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o tools/kconfig/confdata.c
gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o tools/kconfig/expr.c
flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t -l tools/kconfig/parser.y
gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/preprocess.o tools/kconfig/preprocess.c
gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o tools/kconfig/symbol.c
gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
tools/kconfig/conf  --syncconfig Kconfig

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]
make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
make -f Rules.mk _install
make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
---
 xen/arch/arm/platforms/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index c93a6b2756..6d3ee99456 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -15,7 +15,6 @@ config ALL_PLAT
 config QEMU
 	bool "QEMU aarch virt machine support"
 	depends on ARM_64
-	select GICV3
 	select HAS_PL011
 	---help---
 	Enable all the required drivers for QEMU aarch64 virt emulated
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:16:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:16:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250697.431735 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxjD-0001L5-Pr; Wed, 22 Dec 2021 09:16:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250697.431735; Wed, 22 Dec 2021 09:16:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxjD-0001Ky-Mh; Wed, 22 Dec 2021 09:16:07 +0000
Received: by outflank-mailman (input) for mailman id 250697;
 Wed, 22 Dec 2021 09:16:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzxjC-0001Ks-CT
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 09:16:06 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzxj8-0000Kh-1j; Wed, 22 Dec 2021 09:16:02 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzxj7-00088M-PS; Wed, 22 Dec 2021 09:16:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=vTgQ5R40UUgTfTNSU0UXU2rYDWhtKPf1WN1czx89r58=; b=3++HQZ2MeU9C8NndI+YWwLTlYs
	FizeiqSINwTvYMiMLK+7CvtvJRqVUEGMQ3oQ+YqgeKzxKMuU8cUoLxNXBA/Ykf/Ysbq0MktAL3/oS
	nVRGHTEE64DR8v8f9VtUu5wSb5PGxLxRHAniywpWXV+vSbOszwd3ktNKwctggWJ+copY=;
Message-ID: <6aabf7fe-81ea-0fbc-a640-75f9ac59806b@xen.org>
Date: Wed, 22 Dec 2021 10:15:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH] xen/arm: fix the build error for GIC
To: Dongjiu Geng <gengdongjiu1@gmail.com>, sstabellini@kernel.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 xen-devel@lists.xenproject.org
References: <20211222083825.2918045-1-gengdongjiu1@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211222083825.2918045-1-gengdongjiu1@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

On 22/12/2021 09:38, Dongjiu Geng wrote:
> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
> so fix it and make it can select GICV2.

Last time I checked QEMU, it was only able to support GICv3 
virtualization. Has it changed since?

> 
> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> ---
> $ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
> make -C xen install
> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o tools/kconfig/conf.c
> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o tools/kconfig/confdata.c
> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o tools/kconfig/expr.c
> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t -l tools/kconfig/parser.y
> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/preprocess.o tools/kconfig/preprocess.c
> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o tools/kconfig/symbol.c
> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> tools/kconfig/conf  --syncconfig Kconfig
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> make -f Rules.mk _install
> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> ---
>   xen/arch/arm/platforms/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index c93a6b2756..6d3ee99456 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -15,7 +15,6 @@ config ALL_PLAT
>   config QEMU
>   	bool "QEMU aarch virt machine support"
>   	depends on ARM_64
> -	select GICV3

Assuming you can use Xen with GICv2 on QEMU, then this change is OK. But 
we are at risk to expose it again via another platform.

So I think it would be better to also to add a dependency !GICV3 for 
NEW_VGIC.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:24:57 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:24:57 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250700.431745 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxrX-0002wN-LE; Wed, 22 Dec 2021 09:24:43 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250700.431745; Wed, 22 Dec 2021 09:24:43 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxrX-0002wG-Hz; Wed, 22 Dec 2021 09:24:43 +0000
Received: by outflank-mailman (input) for mailman id 250700;
 Wed, 22 Dec 2021 09:24:41 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzxrV-0002wA-ID
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 09:24:41 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzxrU-0000Tp-8x; Wed, 22 Dec 2021 09:24:40 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzxrT-0000CO-Vg; Wed, 22 Dec 2021 09:24:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ShCX8Blbu2ASvBNjG0vJiMeXe/DTX9QpPIUyR5Y8JJw=; b=c5IcMGu5PWcohBDfAdUGBWWasB
	A7CX+GUynNApIQahfdGESqnzoN/l0J5twbECLxlauCSSW1L5s/rp6kLdsuVz18SoiD+K1sz34d99w
	KpWsfwCcTIBFQxgqkENLl4aqo2QWTfJUSZZic1eXxmCwDmTBXikI7kmQ6hn+8yt6ebn0=;
Message-ID: <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org>
Date: Wed, 22 Dec 2021 10:24:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
To: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Cc: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Stefano,

On 21/12/2021 22:39, Stefano Stabellini wrote:
> On Tue, 21 Dec 2021, Anthony PERARD wrote:
>> On Fri, Dec 17, 2021 at 12:15:25PM +0000, Oleksii Moisieiev wrote:
>>>> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>>>>> @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
>>>>>    {
>>>>>        AO_GC;
>>>>>        libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
>>>>> -    int i, rc = 0;
>>>>> +    int i, rc = 0, rc_sci = 0;
>>>>>        for (i = 0; i < d_config->num_dtdevs; i++) {
>>>>>            const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
>>>>>            LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
>>>>>            rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
>>>>> -        if (rc < 0) {
>>>>> -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
>>>>> +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
>>>>> +
>>>>> +        if ((rc < 0) && (rc_sci < 0)) {
>>>>> +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
>>>>> +                 "xc_domain_add_sci_device failed: %d",
>>>>> +                 rc, rc_sci);
>>>>>                goto out;
>>>>>            }
>>>>> +
>>>>> +        if (rc)
>>>>> +            rc = rc_sci;
>>>>
>>>>
>>>> If I get this code right, it sounds like the dom.cfg's dtdev property is
>>>> reused to describe sci devices as well, but the libxl__add_dtdevs() does not
>>>> (and can not) differentiate them. So it has no option but to send two
>>>> domctls for each device in dtdevs[] hoping to at least one domctl to
>>>> succeeded. Or I really missed something?
>>>>
>>>> It feels to me that:
>>>>   - either new dom.cfg's property could be introduced (scidev?) to describe
>>>> sci devices together with new parsing logic/management code, so you will end
>>>> up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
>>>> so no mixing things.
>>>>   - or indeed dtdev logic could be *completely* reused including extending
>>>> XEN_DOMCTL_assign_device to cover your use-case, although sounds generic, it
>>>> is used to describe devices for the passthrough (to configure an IOMMU for
>>>> the device), in that case you wouldn't need an extra
>>>> XEN_DOMCTL_add_sci_device introduced by current patch.
> 
> I realize I did my review before reading Oleksandr's comments. I fully
> agree with his feedback. Having seen how difficult is for users to setup
> a domU configuration correctly today, I would advise to try to reuse the
> existing dtdev property instead of adding yet one new property to make
> the life of our users easier.
> 
> 
> 
>>>> Personally I would use the first option as I am not sure that second option
>>>> is conceptually correct && possible. I would leave this for the maintainers
>>>> to clarify.
>>>>
>>>
>>> Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
>>> seems not to be conceptually correct. Introducing new dom.cfg property
>>> seems to be the only way to avoid extra Domctl calls.
>>> I will handle this in v2 if there will be no complains from Maintainers.
>>
>> I don't know if there will be a complains in v2 or not :-), but using
>> something different from dtdev sound good.
>>
>> If I understand correctly, dtdev seems to be about passing through an
>> existing device to a guest, and this new sci device seems to be about having Xen
>> "emulating" an sci device which the guest will use. So introducing
>> something new (scidev or other name) sounds good.
> 
> Users already have to provide 4 properties (dtdev, iomem, irqs,
> device_tree) to setup device assignment. I think that making it 5
> properties would not be a step forward :-)

IIRC, in the past, we discussed to fetch the information directly from 
the partial device-tree. Maybe this discussion needs to be revived?

Although, this is a separate topic from this series.

> 
> To me dtdev and XEN_DOMCTL_assign_device are appropriate because they
> signify device assignment of one or more devices. We are not adding any
> additional "meaning" to them. It is just that we'll automatically detect
> and generate any SCMI configurations based on the list of assigned
> devices. Because if SCMI is enabled and a device is assigned to the
> guest, then I think we want to add the device to the SCMI list of
> devices automatically.

I am OK with re-using dtdev/XEN_DOMCTL_assign_device however there is a 
pitfall with that approach.

At the moment, they are only used for device protected by the IOMMU. If 
the device is not protected by the IOMMU then it will return an error.

Now, with your approach we may have a device that is not protected by 
the IOMMU but require to a SCMI configuration.

I don't think it would be sensible to just return "succeed" here because 
technically you are asking to assign a non-protected device. But at the 
same time, it would prevent a user to assign a non-DMA capable device.

So how do you suggest to approach this?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:28:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:28:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250705.431757 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxuz-0003dB-AK; Wed, 22 Dec 2021 09:28:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250705.431757; Wed, 22 Dec 2021 09:28:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzxuz-0003d4-74; Wed, 22 Dec 2021 09:28:17 +0000
Received: by outflank-mailman (input) for mailman id 250705;
 Wed, 22 Dec 2021 09:28:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rzrJ=RH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1mzxuy-0003cy-NM
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 09:28:16 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.109.102])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 7d9255c4-6309-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 10:28:15 +0100 (CET)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-15-xJipt3uuN9qSvpuDhfNoJw-1; Wed, 22 Dec 2021 10:28:14 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB6003.eurprd04.prod.outlook.com (2603:10a6:208:118::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Wed, 22 Dec
 2021 09:28:12 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 09:28:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7d9255c4-6309-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640165295;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=ST1XzSg4MtBdb52NTwXfc6sVlyAu8tikSBdV/sJa0To=;
	b=IAAwhhSxS7cnG1yQwmG0ZLk2O29sXtvoOxEvG8BfrlDiNGxvuvQM+aHZ8Wo94SL+vdIxUf
	EuA4RPdJaogAanmsrATgt9jcibxsmMmRsrkBq7laixuvMvjJwvjHYwXupYps6M+7hpXHSK
	EUtIWJ/oexoJlWoDNYGSkh6X11SmTQE=
X-MC-Unique: xJipt3uuN9qSvpuDhfNoJw-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=mT8DPcyTehihLLbuaRNexhSBdiZDiznhJAMDbHhu+Cc4Tl6gQY5+4osFWzf6/DCJYaCE8zjhul2WXiwrGK8f1nMeFcQKXvJ4ZzbOZ5pOVhQe0Ri+xqaWfg+cQkq5j14UIW2ol48zv0aXZCkZDeHM3LsXgMizOKW63D+wdA+glJcVroVN+2meePuR6WLS2FiFk3jv1wyUBM9XK44T1S77Xh1wx1WGWFTFbxd4tPuvnYlUiIR1Kh9yqwJw6h54taNodzhg4/M0gYTlJRzQbkz4DfTw4mM5LwWU900Z3QoGvx3SLU5IMdlSVRTopRWtse67dVFZQzagnFD1Ji9eNNO1gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ST1XzSg4MtBdb52NTwXfc6sVlyAu8tikSBdV/sJa0To=;
 b=FqdsJbLipwltjaxCuThFL04edPZ+LUUtBiXXdStorXsYpG3gApQalda6AU5kkZim63miUiwAv3STH/wmlWCtr0Q+puKb0h5lkV5Cd3s8/HsXOpfBwkOXVSPZZe7z48pwQlKBfOtk232U2L0upx8blILqjjGRBu18ddo2H/hkoUAGFV0QdkR9NE7Q2o7v3HtDwveGLfSPxvLacrxDFXX57fnHFkkQzIO8JjX/cnLeIPcQmEbU+wdNEsCJEOevdI+Ob4V2zKUiGB3XVWrdPGrVMPxrHqVcBs/May2Az2SXeCrSuDR3a40wuI5X3RX6IVhIICWsemgDwGQj8GI3V0cYLA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <afe6bc04-c87b-e627-d032-b205a6bcfe7e@suse.com>
Date: Wed, 22 Dec 2021 10:28:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [BUG] Resource leaks in Xen
Content-Language: en-US
To: Ryan Cai <ryancaicse@gmail.com>
References: <62B51AB1-2C2B-402A-A7C8-5ADACE265DA4@gmail.com>
Cc: dgdegra@tycho.nsa.gov,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <62B51AB1-2C2B-402A-A7C8-5ADACE265DA4@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AM5PR0202CA0009.eurprd02.prod.outlook.com
 (2603:10a6:203:69::19) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fa58cc7a-4292-4e3a-a584-08d9c52d5fc3
X-MS-TrafficTypeDiagnostic: AM0PR04MB6003:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB6003FDD0ADC3BB796D62B704B37D9@AM0PR04MB6003.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	DCPf6OGZZ4yQwMHzyjHwHmnwoxkaJzZG79GkwAxrhiAvRgVud2GIxLAVhp0NpS4b/0ug3S5mGxyz0uL0vCxcgUzLHTtj9z6GkImyirUxECm5e8dzoKg4jmnFCTR2AVslBox6mbKl7Aqbz0NEZumu2EVfOB2fL6GWQgYtAcHTYOYWYdc3jHloUASpvx+AOTxMQNd5rM3uSpUZmoFYXaETjbbk3sgIRQXQOd7olkid/k9XUfTi56mx8euWUGx2LPDbAMmjAxgjkVNWbhd0pEkIVYFODAH1EhNv2bIrdM8JI6t65F/+08a7WADiYFU6/gN005a8o8LuEhclTp+Dc77Yud4YarX9Ixq74xTteLKrb8tCqfps4bZ/u/QtYeQS1DQzgj1qJDjSkLNJjmOaYh5LYynuckMC+dlVF5bXCniiyRWx/EPRey3iNCKW7YiTsbzz+OSQGF7v4144+9dBSh41BKmtsX0b9KhdLy8OsVvr8UxirkqVqyvPmFZpqhT8O3DKwZngxik0IPqtQmz/tNu52QjtCMYKY1LA+3QUAWa1nErjlBVALZWf8giRD10Es59C4WPBcvuTXJfW8Gazqoel+Qturw3vLJLgcZy6fKvv/3Flgc1nbH1899B4QjJy+dSK3Q5kJGCEu9rsykgJ7cXYlpawEkSCWS1vjnhpozT//1PJScU4ivmIn7R0pBBQO6LmbPRF/uoU6Zmp0qyEvKYgo8Bh/pkjrLBlpiPY44JILFmOYpX1QgoUixKiLXmlEqC/xSiV1mASMWboJlJ3+pEsIXfV3ek1xJ1somij7S3hdcWpXST40CI9aIdL1M1ajqtr
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(6486002)(26005)(316002)(6916009)(186003)(66556008)(66476007)(8936002)(2906002)(36756003)(38100700002)(66946007)(6512007)(4326008)(2616005)(6506007)(8676002)(83380400001)(31686004)(86362001)(966005)(31696002)(53546011)(508600001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?T2tJMU1PR0RNWFY5cTAvLzh1aGZJVlFXQWxmVlIva21iNFR1RWVsM2JGMEJJ?=
 =?utf-8?B?ZHUvZ3ZmSFB5cDJJMzVza2lnYll2YmMwUEJBSXRHSVJVUWM4SDI2ZUVTdUZh?=
 =?utf-8?B?SnRHdlJqY1VKTHJOdm1SOVJaYXFDanZBWVM4MHJQUFN3bW81RUtvaTdCMWh0?=
 =?utf-8?B?eHozUVNkZGk5ZXZRS1ViWFU2U083dENMSE9KNEVwTHpIV2tjR0RKL2FScUwy?=
 =?utf-8?B?WUtJTnQ3akpJeEw5MHp5UStWMFdESGdSTDBqV2NwaU1ZTmpBbnllTGQ0cFdr?=
 =?utf-8?B?d2lxTldNT1lOVk9sSHpvV2huSnd6dmI1UUwrLzNjWTl3Vk1nNk9TcXZmVUQx?=
 =?utf-8?B?VmRXN0hDdnFFMm8vZURjNFI0S2hkWXgxTGlUVFpLY1RXTXY5TjcvNlBWdGdR?=
 =?utf-8?B?QUthci9NMTB5cGF1N0xqRXlOT2gwOVpMdVVwTDBFOUllTXpLMmRiVXZhWTB5?=
 =?utf-8?B?dGxvMFhjRHV3YmRsTDJjR3BtUkYzTVMwMXJTNndGQlJqNjlnRkRPN3hEd0Nl?=
 =?utf-8?B?ZHpUWVFjWUJRV0FwS1VLbi9JUXpNdVljdFlIemw3YVM0VzROTW9aZU9oM3hO?=
 =?utf-8?B?QlhMV3dMYWVaVXYxNHFOU3V6TmQ2cHY3VGVHclpNOTZFby9xTXAyVTl1YXdk?=
 =?utf-8?B?QUtiTTJEcVFiZi94azJDYTcwVHJsYXo0VnhSYUFBZFhLQks4K28vV2pDNld4?=
 =?utf-8?B?WEMxS2ZiNk8yRFRZNHhWS3VVeUpyRm9LdS92MmpWZFdKUE8wSHFKNnpnamJR?=
 =?utf-8?B?K09aMGZJV1RDbU00U0lPb3J2UkR4VDZkeVVwdUVrbUtDN2FLU3FwWnhISGlJ?=
 =?utf-8?B?d1JCUlUrNUUxTHIwTlZqKytGaUZBTWN6RkE0K2hjL21VSkhDcW95MnVZQWV5?=
 =?utf-8?B?bWN2S3N5dk1xWWhJaXQvZWw1L211RFpqZ2Viem5FU2puNlZSSDRtTVIvaTBK?=
 =?utf-8?B?b1RBaDF5bFJOTHFoMjBrTHZzUEdveHRKKzdFWWJ2elFPWHh0VjNvOE50MW10?=
 =?utf-8?B?d25hcjRtRzdUOUVVbEtTMU9vY2VlSDVpMDdnajkweW9aMVFRWVZXNlFaTjhO?=
 =?utf-8?B?SytscFZEaDBmZ1hNdHBWR09oQVRsbC9sR3V6SVJGSmg5S2NDMTdGSG11ZDFR?=
 =?utf-8?B?aUZDYzRlajRabDFNQ0FCN3ZINVl3b1lub1kzZUIwNmExdk5oZ3habk9mZWdQ?=
 =?utf-8?B?MmZ6U1pZZFRjMTdEc0lYT20yRldnTHg1M2ZvOUYxS0ViWDRhdERCb0tCUDNF?=
 =?utf-8?B?di9iU2ZsdCszWFNrekFZaDhHYkU2Y09mZ0RWcWhwazQxazEySkxQV2RIVGpj?=
 =?utf-8?B?R04xdllpS1g2d21JTUs1SVNkeXhYenNMTllYQm1oTXdmT3MzMWE4OWJKdXBU?=
 =?utf-8?B?b1FXeHcwUTI1NHZ5cFhwaTNyUVFRQVRBUERNenlhTENrR0xUME92UXhOeFJn?=
 =?utf-8?B?emRMMkl2VWhzQzhYQ0RCWStLMTR0N0RGTTFncFNCcklyeCtSc2cxbDZFVTFD?=
 =?utf-8?B?WFBMREExVWd6TElINmhuVElxS0lPdUhyRE1GdUVKOWZlOTJleWNRMHk4cUV1?=
 =?utf-8?B?b25vemdCQjJrV1c1RUVLK1c5aFJzQXFsdHo1cE4vSzlERHhIckpoaFhJd09h?=
 =?utf-8?B?YW12OE1VemJCT3U2UUNhNk44elo5Sy8zREdrK3JVSkZoSUEvbDR0TGhHZXE1?=
 =?utf-8?B?b0pwS3F0OGtSMXZHM2EvOEVwRE9wZnJOL2JqN1ZUOU93ZjJGb1V4R2JQNUxm?=
 =?utf-8?B?bVVJMnVLTDJKaDBKaWhwc09mRzl4dGdwWmtQZFZ5UmdxS0cvVC93SlVmMVhV?=
 =?utf-8?B?QTY4Wko0ZW1kMFdkRGtZdHhhTm9rTDU5bHZxaGhnTVk4Z3R5MEtwSkVCa0Fn?=
 =?utf-8?B?SC9QZ3dxRXNYRHc0dFg1dFBJZnZaZ1plbVhjQ3U5ajJHR1FZNCtCSUx3dUxn?=
 =?utf-8?B?U2thU0RjaHdacjZDcUI3VE5tb0pnbCs0dEdOd2RESS9QS28wNnc4L3gxb3B1?=
 =?utf-8?B?NElBbEhYeEpTbG82RURKcW1JVDV6WGx4dEp3VVZLTS9yUm9kYm1TMVpCcTBq?=
 =?utf-8?B?VXFML3ZXeFJveHh2OEUzSEdDN1dqMDZKR25wSmV5Nm0vNGdVT29uUENkTE4w?=
 =?utf-8?B?azN3dmRnTkRTUTZlMCtJcXVqcFo4NlFKUE5oVmxmRWFkRkUrRGJkanQ4OVQw?=
 =?utf-8?Q?82TQBrtdsaQLkb4SVE3l2h0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa58cc7a-4292-4e3a-a584-08d9c52d5fc3
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 09:28:12.2055
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CuuB3bYPSqMGW/F9jNssuI+/dadTxQ9bb47dNYPIN6JVMGJ1rIibJLz9BO5YX0AQmLHyIfhPnMmlOTmag7gFIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6003

On 22.12.2021 09:05, Ryan Cai wrote:
>              I am writing you to report potential resource leak bugs. In the file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclose may not matched when returning at Line 76, resulting in a resource leak. Looking forward to your feedback. Thank for checking.
> 
> Locations, https://github.com/xen-project/xen/blame/25849c8b16f2a5b7fcd0a823e80a5f1b590291f9/tools/flask/utils/label-pci.c#L63-L76

Thanks for looking closely, but I'm afraid I don't see where any
resources get leaked here: "f" will get closed implicitly after
returning from main(). It might be good practice to close files
explicitly, but that's purely cosmetic here afaics. Feel free to
contribute a patch.

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:45:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:45:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250710.431768 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyBZ-0006GJ-Qc; Wed, 22 Dec 2021 09:45:25 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250710.431768; Wed, 22 Dec 2021 09:45:25 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyBZ-0006GC-NP; Wed, 22 Dec 2021 09:45:25 +0000
Received: by outflank-mailman (input) for mailman id 250710;
 Wed, 22 Dec 2021 09:45:24 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/qRA=RH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzyBY-0006G6-K3
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 09:45:24 +0000
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com
 [2a00:1450:4864:20::12f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id df0d2fb1-630b-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 10:45:18 +0100 (CET)
Received: by mail-lf1-x12f.google.com with SMTP id k21so4216631lfu.0
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 01:45:23 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id z18sm164000lfd.8.2021.12.22.01.45.21
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 22 Dec 2021 01:45:22 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: df0d2fb1-630b-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=81SH7+ghC7XBRSldxsSZ8EYsimdzl700pJu4JByV1s4=;
        b=kijYg8W72WY6hB/nLCYtVJHIAF0Ce3nVHOLcjmctsLN/k8SzZgfRcHTFENSZDCObbG
         uJ5vsFGRsLDTjBCxoESGQoxF3ZipBYasOklqmHv8E5BnpfZHVG1teZmRTd1c3RU9FrXm
         46+FcB/HKGqnsqi8Wo2hci8edQYAxE/clKPDaT63OKBiZ/gjdD4K+v8SzgWXUttmXtAc
         l3NeYKvHCFj5OxUocNj7UMIqknM2g4qx6aNYTHnc6wANOn9zTDXqQZlvt9K/QArltoZf
         XK7YU8f2ccd4pV2ATjYtlIF/7H0jW6/DySei7vhSxzMic7riQsSHRSKI6hkpSSH+sm04
         iDJA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=81SH7+ghC7XBRSldxsSZ8EYsimdzl700pJu4JByV1s4=;
        b=qHXTlfgmgK9Ia1VPlBIyLupxgtqyhsRFPcHopxCVJrtQNUUHqZxwC6yoXLNHPXxHwA
         Q9GnSUHZ9ZP9X2v1Gi8IRvVjb9pcVKKYqHx3iq0mBYWtcbe+aX8APW7ehGVCmDzI9FoX
         qcRz2/sbk+xwQaIq9KBFs/uyyRaXy2PfJGaP7vfzDQLSaAHrxT2wC2ivAWRbE82x5L5P
         x+0T0lFepq+E4QCNqrAce4M0sBxoVqKQCUHXb57dmYld0dHKElotCisHzciiv3Vdg++r
         0opfXg43OKJWEhJlthVT6dmReDtW3y+m9fPCvuDCOoC+HziPHK6n/orHwK5rz/3TE7CK
         dxvQ==
X-Gm-Message-State: AOAM5308Vy7t3EKpiJ+e+0vauOLOycOiU/VF4zlS+F0yYutIXp/sdBXg
	NjmOhBCSaqFeh5uEPxgDTk8=
X-Google-Smtp-Source: ABdhPJy5vQG7s+WkcnNyhHXRTyXCt23FHPICxX/J8flmB1repSsuWhxqouUMR4jp/z8jSmxIbGzsxw==
X-Received: by 2002:a05:6512:4015:: with SMTP id br21mr1991736lfb.233.1640166322784;
        Wed, 22 Dec 2021 01:45:22 -0800 (PST)
Subject: Re: [PATCH V6 1/2] libxl: Add support for Virtio disk configuration
To: Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Wei Liu <wl@xen.org>,
 George Dunlap <george.dunlap@citrix.com>,
 Nick Rosbrook <rosbrookn@ainfosec.com>,
 Stefano Stabellini <sstabellini@kernel.org>, Julien Grall <julien@xen.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <1638982784-14390-1-git-send-email-olekstysh@gmail.com>
 <1638982784-14390-2-git-send-email-olekstysh@gmail.com>
 <YbjANCjAUGe4BAar@perard> <bce10079-abd6-c033-6273-ac0ea9f51668@gmail.com>
 <4c89e55d-4bf1-506e-d620-4a0ff18ef308@suse.com>
 <dc1b70ac-079d-5de8-cb13-6be4944cef0a@gmail.com>
 <813684b0-df71-c18b-cf4c-106cc286c035@suse.com>
 <8348ef52-701b-e1f9-2d9b-226ac97e8e2f@gmail.com>
 <15b837ba-25cf-7e4c-4729-f82bffe02fed@suse.com>
 <44885d7e-c5a0-5b7c-144d-b9e6c7e54715@gmail.com> <YcIE5rv5vwxwSvKd@perard>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <f880ebd7-64e9-f446-e386-30933918a027@gmail.com>
Date: Wed, 22 Dec 2021 11:45:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YcIE5rv5vwxwSvKd@perard>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US


On 21.12.21 18:46, Anthony PERARD wrote:


Hi Anthony, Juergen

> On Fri, Dec 17, 2021 at 06:50:02PM +0200, Oleksandr wrote:
>> On 17.12.21 17:26, Juergen Gross wrote:
>>> On 15.12.21 22:36, Oleksandr wrote:
>>>> On 15.12.21 17:58, Juergen Gross wrote:
>>>>> In practice we are having something like the "protocol" already today:
>>>>> the disk device name is encoding that ("xvd*" is a Xen PV disk, while
>>>>> "sd*" is an emulated SCSI disk, which happens to be presented to the
>>>>> guest as "xvd*", too). And this is an additional information not
>>>>> related to the backendtype.
> You mean in theory? ;-) In practice, xvd* is the same as hd* (or sd*?).
> I tried once to have xvd* mean PV disk only, but the patch was rejected.
> So at the moment, we always get an emulated disk, we can't have PV disk
> alone, at least on x86.

I guess this a question to Juergen?


>
>>>>> So we have basically the following configuration items, which are
>>>>> orthogonal to each other (some combinations might not make sense,
>>>>> but in theory most would be possible):
>>>>>
>>>>> 1. protocol: emulated (not PV), Xen (like today), virtio
>>>>>
>>>>> 2. backendtype: phy (blkback), qdisk (qemu), other (e.g. a daemon)
>>>>>
>>>>> 3. format: raw, qcow, qcow2, vhd, qed
>>>>>
>>>>> The combination virtio+phy would be equivalent to vhost, BTW. And
>>>>> virtio+other might even use vhost-user, depending on the daemon.
>>>> yes, BTW the combination virtio+other is close to our use-case.
>>>>
>>>>
>>>> Thank you for the detailed explanation, now I see your point why
>>>> using backendtype=virtio is not flexible option in the long term
>>>> and why we would want/need to an extra configuration option such as
>>>> protocol, etc. I think, it makes sense and would be correct.
>>>>
>>>> If we take a disk as an example, then from the configuration PoV we
>>>> will need to:
>>>> - add an optional "protocol" option
>>> I'm not sure regarding the name of the option. "protocol" was just a
>>> suggestion by me.
>> Yes, personally I would be fine with either "protocol" or "specification",
>> with a little preference for the former. What other people think of the
>> name?
> I don't have a better idea. "protocol" sound fine, as long as the description of
> this new field is about how a guest kernel will communicate with the
> backend.

yes, sure.


>
> We could start with "default" and "virtio-mmio" as options. "default" is
> what we have now and usually mean emulated+xen-pv.

ok, sounds good to me.


>
>>>> - add new backendtype: external/other/daemon/etc.
>>>> This seems to cover all possible combinations describe above
>>>> (although I agree that some of them might not make sense). Is my
>>>> understanding correct?
>>> Yes.
>> ok, thank you for confirming.
>>
>>>> Unfortunately, disk configuration/management code is spread over
>>>> multiple sources (including auto-generated) in the toolstack which
>>>> is not so easy to follow (at least to me
>>>> who is not familiar enough with all this stuff), but anyway may I
>>>> please clarify what is the minimum required amount of things that I
>>>> need to do in order to get this basic virtio-mmio
>>>> support series accepted?
>>> I'd say we should first get consensus that others agree with my
>>> suggestion.
>> This is fair. Personally I share your opinion (what you propose sounds
>> reasonable to me in general). Are there any other opinions? Any feedback
>> would be highly appreciated.
> The new proposed property sound good to me as well.

Great, thank you for the feedback.


>
> Thanks,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 09:49:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 09:49:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250714.431778 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyFI-000740-AY; Wed, 22 Dec 2021 09:49:16 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250714.431778; Wed, 22 Dec 2021 09:49:16 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyFI-00073t-7L; Wed, 22 Dec 2021 09:49:16 +0000
Received: by outflank-mailman (input) for mailman id 250714;
 Wed, 22 Dec 2021 09:49:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzyFH-00073m-3z
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 09:49:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzyFA-0000tP-QW; Wed, 22 Dec 2021 09:49:08 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzyFA-0001Ye-Hw; Wed, 22 Dec 2021 09:49:08 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=dECnLebPo+b75urTmQ4wHCiwGrd1R7+aYWKSWKKCxDU=; b=Q+4HMrRzNCbPW4qpEmTgusg5WA
	wmP1ZiiTkx+1EmlWT00TsZcfOq3+yGBPxyVI3E78FKRcFSEfo7C40joiGcpoYbESYN/qAH1XnOrt4
	7XDj580T0bKGp0iylVxPVLkcy14MB43EibUnzEUk4d4se6lmtg8U4DUt2m3q+ZuIywQU=;
Message-ID: <fbe522a6-297f-4e5e-5081-f7e7e277155b@xen.org>
Date: Wed, 22 Dec 2021 10:49:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Oleksandr <olekstysh@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Oleksandr,

On 14/12/2021 17:26, Oleksandr wrote:
>>> @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
>>>       }
>>>       /* Map at new location. */
>>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>>> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
>>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>>> +    else
>>> +    {
>>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>>> +
>>> +        p2m_write_lock(p2m);
>>> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), 
>>> INVALID_GFN) )
>>> +        {
>>> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, 
>>> p2m->default_access);
>>> +            if ( !rc )
>>> +                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
>>> +        }
>>> +        else
>>> +            rc = -EBUSY;
>> May I suggest to avoid failing here when 
>> page_get_xenheap_gfn(mfn_to_page(mfn))
>> matches the passed in GFN?
> 
> 
> Good question...
> There was an explicit request to fail here if page_get_xenheap_gfn() 
> returns a valid GFN.
>  From the other side, if old GFN matches new GFN we do not remove the 
> mapping in gnttab_set_frame_gfn(),
> so probably we could avoid failing here in that particular case. 
> @Julien, what do you think?

I will answer by a question :). Can this situation happen in normal 
circumstances (e.g. there is no concurrent call)?

The recent XSAs in the grant table code made me more cautious and I 
would prefer if we fail more often than risking potentially introducing 
yet another security issue. It is easy to relax afterwards if there are 
legitimate use cases.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:02:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:02:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250719.431789 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyRl-00017A-Dg; Wed, 22 Dec 2021 10:02:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250719.431789; Wed, 22 Dec 2021 10:02:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyRl-000173-Ad; Wed, 22 Dec 2021 10:02:09 +0000
Received: by outflank-mailman (input) for mailman id 250719;
 Wed, 22 Dec 2021 10:02:07 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzyRj-00016x-LG
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 10:02:07 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzyRd-0001C1-BP; Wed, 22 Dec 2021 10:02:01 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzyRd-0002LU-1G; Wed, 22 Dec 2021 10:02:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=oVtqx8sfUSd6o5y4sqtB6VhtIQzOlQxSCHSX9chLmoc=; b=6oYLO1GXvTNezL1jvt19//ezWs
	/QClgOuousaKMblffmdUc+0T4AeB/ACd8uFPSeb46MX5biriMdC/BMnLgPHNpW874+JLTnuunxEN1
	gsUQ774iO8Qakd7EU3L+dH51uoiS9Pf3Rc5znGYKss0VhHQUgdk/3D9Va+OxqC6X9JJY=;
Message-ID: <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
Date: Wed, 22 Dec 2021 11:01:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Jan Beulich <jbeulich@suse.com>, Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 14/12/2021 17:45, Jan Beulich wrote:
> On 14.12.2021 17:26, Oleksandr wrote:
>> On 14.12.21 15:37, Jan Beulich wrote:
>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>>>    
>>>>    void free_xenheap_pages(void *v, unsigned int order)
>>>>    {
>>>> +    struct page_info *pg;
>>>> +    unsigned int i;
>>>> +
>>>>        ASSERT(!in_irq());
>>>>    
>>>>        if ( v == NULL )
>>>>            return;
>>>>    
>>>> +    pg = virt_to_page(v);
>>>> +
>>>>        memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>> ... this really want to (logically) move into the new arch hooks.
>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>> notice there's some dead code there on x86, which I guess I'll make
>>> a patch to clean up). But first of all this suggests that you want
>>> to call the hooks with base page and order, putting the loops there.
>>
>> I see your point and agree ... However I see the on-list patches that
>> remove common memguard_* invocations and x86 bits.
>> So I assume, this request is not actual anymore, or I still need to pass
>> an order to new arch hooks? Please clarify.
> 
> Well, that patch (really just the Arm one) effectively takes care of
> part of what I did say above. Irrespective I continue to think that
> the hook should take a (page,order) tuple instead of getting invoked
> once for every order-0 page. And the hook invocations should be placed
> such that they could fulfill the (being removed) memguard function
> (iirc that was already the case, at least mostly).

IIUC your suggestion, with your approach, alloc_xenheap_pages() would 
look like:

      for ( i = 0; i < (1u << order); i++ )
          pg[i].count_info |= PGC_xen_heap;

      arch_alloc_xenheap_pages(pg, 1U << order);

The Arm implementation for arch_alloc_xenheap_pages() would also contain 
a loop.

This could turn out to be quite expensive with large allocation (1GB 
allocation would require 16MB of cache) because the cache may not have 
enough space contain all the pages of that range. So you would have to 
pull twice the page_info in the cache.

This is something we noticed when working on reducing the downtime for 
Live-Update. We were able to save 100s ms by reducing the number of loop 
on the page_info.

So I would prefer Oleksandr's approach here.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:12:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:12:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250723.431800 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyby-0002k2-C5; Wed, 22 Dec 2021 10:12:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250723.431800; Wed, 22 Dec 2021 10:12:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyby-0002jv-93; Wed, 22 Dec 2021 10:12:42 +0000
Received: by outflank-mailman (input) for mailman id 250723;
 Wed, 22 Dec 2021 10:12:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzybw-0002jk-IJ; Wed, 22 Dec 2021 10:12:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzybw-0001Oi-Ew; Wed, 22 Dec 2021 10:12:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzybw-0003Qf-76; Wed, 22 Dec 2021 10:12:40 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzybw-0004Rp-50; Wed, 22 Dec 2021 10:12:40 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=of9VwsHsY44VXapZkGz0wQQW9Nr72pvLP5ouRWW0e4A=; b=ZXxWegrT0PaadJNlPm0mzzeoUe
	8arUXFd0ezsBHT8d1782LBwMp3we2fn7mZGyBAqk4mJQXAVHH03GCZwT8mTO1blK/6/J0EESQE5uJ
	8kxZoDdFgiwcYelj7FilRooZrN2Ptu5Eyxc0VGosMVn+kArhoreuwXHa8qpZBpoBSphI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167513-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167513: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9
X-Osstest-Versions-That:
    ovmf=de9e5b7dc721d4ca319c0455cf83577347e0abef
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 10:12:40 +0000

flight 167513 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167513/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9
baseline version:
 ovmf                 de9e5b7dc721d4ca319c0455cf83577347e0abef

Last test of basis   167487  2021-12-20 04:11:39 Z    2 days
Testing same since   167513  2021-12-22 05:41:33 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   de9e5b7dc7..9ec2cc1f31  9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:15:21 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:15:21 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250733.431811 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyeR-0003Ow-VA; Wed, 22 Dec 2021 10:15:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250733.431811; Wed, 22 Dec 2021 10:15:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzyeR-0003Op-SB; Wed, 22 Dec 2021 10:15:15 +0000
Received: by outflank-mailman (input) for mailman id 250733;
 Wed, 22 Dec 2021 10:15:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzyeQ-0003Od-R5; Wed, 22 Dec 2021 10:15:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzyeQ-0001Qp-Q9; Wed, 22 Dec 2021 10:15:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzyeQ-0003VZ-IV; Wed, 22 Dec 2021 10:15:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzyeQ-0005i3-I7; Wed, 22 Dec 2021 10:15:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OfhFKs7ELeWW+y9ZVKscb8VyjvSbTNFwuBMSTrAlDMs=; b=JuYD/SmoOUlZzqU+1+OmHExp4W
	1ZpTeExjUdUb1oyI0VmHhLV6r9wAKJ7iGWuDR+g3OthiI2SPDcv2Suc9kP4nyIJrAhj030N5b/clz
	GN5rpI4v7GtU8B5oMgUn56+GCNw8oE470ybkZtCcn1HOyfCCrBM1/TH58KWn2pDeLpRs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167517-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable-coverity test] 167517: all pass - PUSHED
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=8e3edefb880caeeaaf80123d5599139e8c2c9ecf
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 10:15:14 +0000

flight 167517 xen-unstable-coverity real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167517/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  8e3edefb880caeeaaf80123d5599139e8c2c9ecf

Last test of basis   167483  2021-12-19 09:20:44 Z    3 days
Testing same since   167517  2021-12-22 09:19:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Jan Beulich <jbeulich@suse.com>

jobs:
 coverity-amd64                                               pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/xen.git
   8e3edefb88..f1e268b9fd  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8 -> coverity-tested/smoke


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:24:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:24:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250743.431823 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzynL-000532-SW; Wed, 22 Dec 2021 10:24:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250743.431823; Wed, 22 Dec 2021 10:24:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzynL-00052v-PU; Wed, 22 Dec 2021 10:24:27 +0000
Received: by outflank-mailman (input) for mailman id 250743;
 Wed, 22 Dec 2021 10:24:27 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2rHP=RH=epam.com=prvs=2990e6cae6=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mzynK-00052p-PH
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 10:24:26 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 5238854f-6311-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 11:24:19 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BM9h11U007046;
 Wed, 22 Dec 2021 10:24:20 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d40pn8bf0-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 10:24:20 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7086.eurprd03.prod.outlook.com (2603:10a6:102:e5::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.17; Wed, 22 Dec
 2021 10:24:17 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 10:24:17 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 5238854f-6311-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=R3GmexDeCzmcyc9uUi4apO9kcwdha8S13vKC/60o3ADhBfv4+MxFdxqRqEfKQ9i1lh2uW7vku9x1G+fPDyXftRCalZ/YCKC/4D464r3SDLny0BC/PJ9/j513sI7LBGVnniCFTEgAZ9I175LZ/O0PCpcD43Udm5bCUiKDC66DSnx461QZogmiSPOUMizEnu6aKU4GUSQYTafSwMB8hRqtOksNbymd3Az2ja5EdSLTnIpxWGQ1zPxabPEPmisY8IbAGVaR41N4ASac1AWYtmnUS98igE6uhvT1umXcFISnRW+KtaIhBkcKwOFdVwYj8qRn/dJCOUHtwWMEqF2BVecVlA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=g5PtkfWXoRQtOyTDxDnfO/KUXEDhGAC4WR7e4jUvt4M=;
 b=DPdH1JGTO+mhH4oEMUbCYaAUAHA2UJvyHpQtUHv+4vzZlmhPIy6vo46O2Bpg3oTyOOecYdEo/4JWNgS//qV64G+uM0kJdCAZHVsBQn+/YKuWQ2nsPd7+P+C3X547ExNOg1eoEGGBfLHV45QEVZ7radvaZatfSpnhsUY21pbK7u5yHKRfNHjushE+AdHYa2BLQ3+9eyIwHKU3TCZ1QR8TL6K3BjMeYtY2e3sLIp55z73bMijcBhj87As14t6uYcIK57yWFFvq6cYPJL2IgBeJmqVhlwuJCrX1vHOxKkEM0R3PVvH1j5igyfW0so7WBp13UVjnrljGNgm4asCn39GWEw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=g5PtkfWXoRQtOyTDxDnfO/KUXEDhGAC4WR7e4jUvt4M=;
 b=DQzdfQlq50CtPGgaAJSaNuqfZDkmaHGfsXIJow/JopvogX7rENd4Z0/VXJi+sFywpropKKdL27Yyy07LIvs/YgtjzdxxQJaQmV9LbKk/huuwpHM2YqU9SdpxPMI3wp4ZI7lwlJBnrB0XkNTIJgTRDO5ltugDEkyunWmj1fxHksa9p70IOUKVZ0uHNi3YDuCWZas8yQfhIcnY+oroze7rE5L4DBZeEpsvzV1kW/AStTiqxKvkTujIxJFT4Giuk+6w7fYatrT69akYiJlKC40NZhUXxNiFP5ri4mVCKn37A38BY4VIVYIvxX/HLCmwAjDC69QjoT3PmUz/sQkx6Xp9aw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owqw8KP2AgAIxjYA=
Date: Wed, 22 Dec 2021 10:24:17 +0000
Message-ID: <20211222102417.GA2882292@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112201653500.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112201653500.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c195bf4f-e26b-49a1-ab76-08d9c53535ef
x-ms-traffictypediagnostic: PA4PR03MB7086:EE_
x-microsoft-antispam-prvs: 
 <PA4PR03MB7086A3F01EF4B7E8AC6F8546E37D9@PA4PR03MB7086.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 FTuq5cWyxnmIDkzvqWYZUadOfsdEKIKhigQ/5YIrS87+mswXniZ6a3WVB5aMqNj74hA3w+mGTFu2JDfy1nsdNvyvDycw1+cDi30ZLPfn3IKBkGaefeEZ0rSpn7qFD0MaAzEQKLfH45QBnZwoEScwsiokTx1/lyBxbzULdmUvoAsb85X0yJ7pMV1sdox12/2jj15w/WZZtDnrzDEXa9w93dgSWOGlu/mnKqNUCoRMCM8ZRfZ6WzRoDKodIoV1YTKJbUUfjhjMhcmRPU26q9hD278biTM6rEnyEJgQPat8t5df0ym7yndCXs4dYz2I+yfW7xexv9ljRTNl4bVmJNj2VgVwunDpLUrGWS9RdEtZuNlluVoXuGdfH1HhYUNv6p3Mz3w42NcvCuW+cMnYz3WSTQDiZ7tF+PND7iAeuBnlsexZDZVdUWHJM5izDjTf82HuqztDMXOSxni1NVXiZNfezCjL+Zj8Ex+0PGEX+OSH6padOWm2uo4aYgMJ5itecsjZxZ60jYJSAUxmO7ZSrBSer8+2Z2PAtzhDX8OR/mYIAiPKOfAaae6UreU7rggtn4tFJDybkETZLQxTmadtdVDv72beF03ncdqI69G/TDdKMgnm3+0rURsQmEgaTSxSFAHL9+K9ElfQm4J+ZZOrACHUfzO5GppCg6SOlirwualArfeJQnv4KfZ1C14mWJj92VAvUq5Eucz6ywB7ypj0BEF/oA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(4326008)(8936002)(5660300002)(8676002)(6506007)(66556008)(2906002)(66476007)(9686003)(66446008)(6512007)(83380400001)(1076003)(86362001)(64756008)(91956017)(6486002)(33716001)(76116006)(66946007)(122000001)(38100700002)(33656002)(71200400001)(186003)(508600001)(54906003)(26005)(6916009)(38070700005)(316002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?OjEndYYIr5oh7cqiYpeDXILuVG6JzJ4nD7efXSoigT29tfhYJmHIrc4bD4Qz?=
 =?us-ascii?Q?+U8V4YaocdjbptMG0sz6bPJZG109nkvG6Z60kWaFZavH4sF3vQo6ZhNxqIHR?=
 =?us-ascii?Q?hbfFLGTutY3BP/OlT2UIoylDV2hOlqIaIk28S5yNH3hRrjWCHK86YcGzp51y?=
 =?us-ascii?Q?OICdx8InfJSZHcQ5zC5bL4E4OKdIbBxFZZYbY9Y5l1H6RfKKRCqL5BpdCYMi?=
 =?us-ascii?Q?Syh/1oNOFJ3irt/mpe6NxbIbaP4MqFunG6n/S0jwGMYuK7qROrt63EZHeu13?=
 =?us-ascii?Q?od+3OfcW4/FdJJDouTpncgYiVLa6X9LWCpGeb1VFkS8cCaj2lsDoOFB4aoC0?=
 =?us-ascii?Q?KV1MGjPF1Yk0nc99nVQyQdbtwROqLMtnqKaZV8SIPVEEUHwr4ne60vy2OJSx?=
 =?us-ascii?Q?zJdnJ+U0GdrBibzkHOrdilhdNukm0kQY6r9ozOsuLYuxN9p0+5/5RZPP+9IV?=
 =?us-ascii?Q?b+29hcAR219EVS0JzW8oZV//hxEjphEWoyvMBpdwZ88TCfZSOKswfyA5AFx+?=
 =?us-ascii?Q?qpAxSEdDenRAZQZwwgWCq44QZnX9N8MsBA6L0/BXtmllwQKtslJKojDZ7H+7?=
 =?us-ascii?Q?fsNo/mHpXtr1ZuCMiDezHXaQQwtwTlGMG8+KLSYzn5XL0T5syKFtXWN8wT0i?=
 =?us-ascii?Q?YFjqos/PyForw1ZDEuTUIJGYqNXeS0g+IlgueqqopFGmoQRAIkQlIN6cB/yu?=
 =?us-ascii?Q?A0IAn7i3bRg90IPPzpHdP9zing+i0P2sUyelFtaA+3KfF7G4307a09YaY7kc?=
 =?us-ascii?Q?6x/mtBulTjaxePT1AkxTornIMmuqc6EMq/zcw/e+4/ygyx/9O08EppmCtnGA?=
 =?us-ascii?Q?FqkaD1KQJ5SP8xIp/GRv7a8NON22YOzKqCNOO7G7vLDIBTgsFA5SvV2WQmK6?=
 =?us-ascii?Q?NcRKR6/FTVoJJ3fXRvg2XPc38obA0X0tdXz90K5l5VmO4eM/T2BShsKJgf1A?=
 =?us-ascii?Q?Iirjn2MtBjgmbnVRlXRmsVAoiaqYpwSEs539d3mBkrbmondwqgwV/bcyIQg9?=
 =?us-ascii?Q?lygXuvWYWDGtNRTTghe4oiTAm8AQQTLsRdEneNhS0QZNyGaafL/PVkypR2I0?=
 =?us-ascii?Q?7s30yF35RC2UeLF2+RTcxrhhZwVRQqj/xOUhAEWQzMsxFsuOFep00Jo8W5zh?=
 =?us-ascii?Q?w0BNT3LNvOy/kdwiKtQRm57D1fGX4nUAxoSI3nragYZncS6+7c+E1pmFMV9R?=
 =?us-ascii?Q?/O5mjVA/OtpArn2EPtHn3LAKgQqWWQsnMNUjtzXNNHT11jQS1o35jNiutn+F?=
 =?us-ascii?Q?e5JBalkrP4jPPoADvpFBwnD37dWf+C2SdKkejav+JR5HByY5WQ+UEAavGrQE?=
 =?us-ascii?Q?dnO75FzaB3xWqXsuPKtNnjvXg1rVC0qTC0D7U6M7WMPdfCeW0H1UEC8DygDV?=
 =?us-ascii?Q?6PCZ0w/g1m9Arb2wNh7ryACj5tqfgIi/wGLUBep6yKbEhXZFGzHT/Cn/gqbT?=
 =?us-ascii?Q?sURCPgK+aGX12dkmngmREfxCqu8ouHGaNmpqAs627PVyhef8zb5QGit4XMRg?=
 =?us-ascii?Q?aHid4X7Z0/s+CE11Gr6dJ8E96shApnfaBrSQfLlj48RanJf6ki9Q4ZiT6REk?=
 =?us-ascii?Q?yC5jGOXvTM8SlPnVeUQYvKNIha0vzZl8hgEiX7JhpPXjXbwHTPxmvNPQnJQ0?=
 =?us-ascii?Q?J+QmUKt7sm3uHj/0dCQ8AWs7f7HnwERkp9V0o5Xk3NRILEFrZ0bo7ZtbCpOF?=
 =?us-ascii?Q?+vci4fS+qMf4erLWoohV6GhsGuA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7CAD6633753F4544975CDB7C5C9BB055@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c195bf4f-e26b-49a1-ab76-08d9c53535ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 10:24:17.7848
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qBJL3fJnJPq+W1p9WM4Glcut8Ks8floPtpXTlRaRf6s+FLmsIkPyTGM/7nRS9y2UQ1mDL48d3I3b97jzITDF0N6kS9uoV0l2xJmMA16qJh8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7086
X-Proofpoint-GUID: b8tat_gWcsNlzHWqtxWib89iB1zZCqWN
X-Proofpoint-ORIG-GUID: b8tat_gWcsNlzHWqtxWib89iB1zZCqWN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_04,2021-12-21_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0
 spamscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0
 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112220059

On Mon, Dec 20, 2021 at 04:54:25PM -0800, Stefano Stabellini wrote:
> On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > This enumeration sets SCI type for the domain. Currently there is
> > two possible options: either 'none' or 'scmi_smc'.
> >=20
> > 'none' is the default value and it disables SCI support at all.
> >=20
> > 'scmi_smc' enables access to the Firmware from the domains using SCMI
> > protocol and SMC as transport.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >  docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
> >  tools/include/libxl.h            |  5 +++++
> >  tools/libs/light/libxl_types.idl |  6 ++++++
> >  tools/xl/xl_parse.c              |  9 +++++++++
> >  4 files changed, 42 insertions(+)
> >=20
> > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > index b98d161398..92d0593875 100644
> > --- a/docs/man/xl.cfg.5.pod.in
> > +++ b/docs/man/xl.cfg.5.pod.in
> > @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
> > =20
> >  =3Dback
> > =20
> > +=3Ditem B<sci=3D"STRING">
> > +
> > +B<Arm only> Set SCI type for the guest. SCI is System Control Protocol=
 -
> > +allows domain to manage various functions that are provided by HW plat=
form.
> > +
> > +=3Dover 4
> > +
> > +=3Ditem B<none>
> > +
> > +Don't allow guest to use SCI if present on the platform. This is the d=
efault
> > +value.
> > +
> > +=3Ditem B<scmi_smc>
> > +
> > +Enables SCMI-SMC support for the guest. SCMI is System Control Managem=
ent
> > +Inferface - allows domain to manage various functions that are provide=
d by HW
> > +platform, such as clocks, resets and power-domains. Xen will mediate a=
ccess to
> > +clocks, power-domains and resets between Domains and ATF. Disabled by =
default.
> > +SMC is used as transport.
>=20
> Would it make sense to actually enable SCMI-SMC support for the guest by
> default if the guest has any devices directly assigned?

Hi Stefano,

Previously we discussed with Oleksandr about introducing new dom.cfg
parameter, such as scidev[] lists all sci related nodes, which will help to
avoid extra domctl calls.

But there is still a question how mediator types should be set for
different domains? I know currently system supports only one mediator
type, but different implementation should be also possible.

For example, if we have to start dom0 and domd using scmi_mailbox
mediator and domU using scmi_smc, because our system supports only 2
mailboxes.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:38:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:38:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250748.431833 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzz0d-0006j9-3A; Wed, 22 Dec 2021 10:38:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250748.431833; Wed, 22 Dec 2021 10:38:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzz0d-0006j2-06; Wed, 22 Dec 2021 10:38:11 +0000
Received: by outflank-mailman (input) for mailman id 250748;
 Wed, 22 Dec 2021 10:38:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/qRA=RH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzz0a-0006iw-Sm
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 10:38:09 +0000
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [2a00:1450:4864:20::129])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 3f724655-6313-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 11:38:07 +0100 (CET)
Received: by mail-lf1-x129.google.com with SMTP id i31so4358124lfv.10
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 02:38:06 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id s13sm175289lfg.126.2021.12.22.02.38.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 22 Dec 2021 02:38:05 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 3f724655-6313-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=2FO88ppBB6/Lz88Qe7FWYpHGln/JjY+e4uNmm/8qzrM=;
        b=NtYxVpFP4PWU7XGkkQjxu/znyUP83UiQjSRQPto3asOpfSVkuhsBxCLS20GJ2iNYLi
         MHVse1oFMeJqvNBHc+INqHgZ93gqY0UbIyBpoRF5cSoHUCi6w9aHPdqhzd8GSEwHERrC
         45fRwG273GI5KkgB7Gu8+9gSeGbvMYU107S8xhmLloBKIDg/KKHDzjuBfczLjF8VgcNw
         6JSbzTnRMjQvTz4t3eHt1hGwN7gEXxBN98hVGJYvte2E6NWxf3MyPTJO1Lk/Rr+1XoEy
         1NAFJrry8uf3Z+lzto7Wq9TyQqD23KeREkrDb8WHAObjDpGNLRthlb/r0pFlfQQ9/DzJ
         Lhzw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=2FO88ppBB6/Lz88Qe7FWYpHGln/JjY+e4uNmm/8qzrM=;
        b=PkEwGRtfw6iK0ICTC6WZqL3VFMRj50NZKzUqIwpDjEa+bGCdA6fRWaoEoCUclKOVcV
         syPyq0tdxbHJOm57rfGxhBS90epVNoOc+M3n2OxVmEE2tVLWujvYfEey2f+hJmnwrtvV
         txg25oPAM7RxVU6n/MrpFoVDPf4Dt+HX8Aw5nWmma/Ua0aPLbdKgq96diYIe1c6yNG7q
         tax265JYvOVvBhtZYpqAjWQ161wL+ouD4KdXdHKK038jZymGKh8v0jPcX7RKPXWeeoRc
         yoVSGb9VCaRNPCTGAlRlWaSBpSEHDebOMEZFm1fnJP7PVlwJasibSHpoX9tE+yU6JBOs
         Dfxg==
X-Gm-Message-State: AOAM5317R4z7CY5uyP9YLWVrzWdwbIZFjsXAOjkE7EXAvXYN0YJqg8fu
	jOg7xZ19Luzrkx3nxLD1vPW4b+qw+HM=
X-Google-Smtp-Source: ABdhPJwdWr8NtVo8hHL74m8jx+VuvL+3ofVAIX0ZGG3AjePGODmKemSqtU5nBUwfDgRhkWoJ0IbaNg==
X-Received: by 2002:a19:7012:: with SMTP id h18mr2037978lfc.152.1640169485583;
        Wed, 22 Dec 2021 02:38:05 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <fbe522a6-297f-4e5e-5081-f7e7e277155b@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <bfb0e6f5-a85f-8613-5da2-60a17443f65a@gmail.com>
Date: Wed, 22 Dec 2021 12:38:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <fbe522a6-297f-4e5e-5081-f7e7e277155b@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 22.12.21 11:49, Julien Grall wrote:
> Hi Oleksandr,

Hi Julien


>
> On 14/12/2021 17:26, Oleksandr wrote:
>>>> @@ -1487,7 +1489,23 @@ int xenmem_add_to_physmap_one(
>>>>       }
>>>>       /* Map at new location. */
>>>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>>>> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) )
>>>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t);
>>>> +    else
>>>> +    {
>>>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d);
>>>> +
>>>> +        p2m_write_lock(p2m);
>>>> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), 
>>>> INVALID_GFN) )
>>>> +        {
>>>> +            rc = p2m_set_entry(p2m, gfn, 1, mfn, t, 
>>>> p2m->default_access);
>>>> +            if ( !rc )
>>>> +                page_set_xenheap_gfn(mfn_to_page(mfn), gfn);
>>>> +        }
>>>> +        else
>>>> +            rc = -EBUSY;
>>> May I suggest to avoid failing here when 
>>> page_get_xenheap_gfn(mfn_to_page(mfn))
>>> matches the passed in GFN?
>>
>>
>> Good question...
>> There was an explicit request to fail here if page_get_xenheap_gfn() 
>> returns a valid GFN.
>>  From the other side, if old GFN matches new GFN we do not remove the 
>> mapping in gnttab_set_frame_gfn(),
>> so probably we could avoid failing here in that particular case. 
>> @Julien, what do you think?
>
> I will answer by a question :). Can this situation happen in normal 
> circumstances (e.g. there is no concurrent call)?

I think no, it can't. Otherwise I would notice it while testing in 
normal circumstances.


>
>
> The recent XSAs in the grant table code made me more cautious and I 
> would prefer if we fail more often than risking potentially 
> introducing yet another security issue. It is easy to relax afterwards 
> if there are legitimate use cases.

I got it, so your explicit request to fail here still stands. Thank you 
for the clarification.


>
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 10:47:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 10:47:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250753.431845 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzz9y-0008LE-0v; Wed, 22 Dec 2021 10:47:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250753.431845; Wed, 22 Dec 2021 10:47:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzz9x-0008L7-UB; Wed, 22 Dec 2021 10:47:49 +0000
Received: by outflank-mailman (input) for mailman id 250753;
 Wed, 22 Dec 2021 10:47:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzz9v-0008Kx-Oc; Wed, 22 Dec 2021 10:47:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzz9v-0001yD-M6; Wed, 22 Dec 2021 10:47:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1mzz9v-0004yA-CH; Wed, 22 Dec 2021 10:47:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1mzz9v-0006oG-Bq; Wed, 22 Dec 2021 10:47:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lQBy15RkZV1xGYO0mTAQeLaPIAGht4WCGNkdQ91t4VE=; b=3IJSpgIkXobzqPolU8R9NANiHO
	9R5Rk6iOcseRU3yv2p0x2atG8V0vuV/tJ3CVJPNoKo27f/go3Ct0T5Fu4yib/9V8rwgwqepJbJ9kg
	nvgsWllFQco9WLRYiAt90CVz9U738LPA0d+2S6AIXnZUewWcaqd579Mqp0N3rcnCvDNM=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167511-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167511: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4273b74b82003c729babe62792c8e71ab57b62ce
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 10:47:47 +0000

flight 167511 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167511/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4273b74b82003c729babe62792c8e71ab57b62ce
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  530 days
Failing since        151818  2020-07-11 04:18:52 Z  529 days  511 attempts
Testing same since   167511  2021-12-22 04:20:12 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90216 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 11:00:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 11:00:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250764.431856 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzLf-0001na-AW; Wed, 22 Dec 2021 10:59:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250764.431856; Wed, 22 Dec 2021 10:59:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzLf-0001nT-7b; Wed, 22 Dec 2021 10:59:55 +0000
Received: by outflank-mailman (input) for mailman id 250764;
 Wed, 22 Dec 2021 10:59:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/qRA=RH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1mzzLe-0001nN-9d
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 10:59:54 +0000
Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com
 [2a00:1450:4864:20::136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4a419813-6316-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 11:59:53 +0100 (CET)
Received: by mail-lf1-x136.google.com with SMTP id g11so4558923lfu.2
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 02:59:52 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id j1sm178457lfu.309.2021.12.22.02.59.51
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 22 Dec 2021 02:59:52 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a419813-6316-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=qFMihSGoewdyshzwX/m2/nP/fRO1pApx4410Go5LgUY=;
        b=WblifteoAp/lEwrJB9p0tSdJbsNQWJegXR/rw+ljCi8kfixl/+4rMHRhCdlUkXF15K
         rKk6D0B/hylYaQQLHkIV/4jC6cIJoay8lJBqd2ns5uXdUMYZOs7+VhGdD+U1yD2gvzYi
         xrF4METDXcjzjj6l7q1qFS6xy7UhTIpQvCklmGTNyGcHmyadZsxs25VaLJyxlPpwKCpn
         kytKxb2DvEeC9kIdxIxiUh46QS6ztyMF1oQSvXn8iJsD0Ku38RRFrRLuegYMy61H1Zdt
         x9CqauCqErXNKfqVC0FXmUB0LIxGxY4nKN9+SMvsBRO9NWG/R4bdJfHm4BRtMUjIvBGu
         LKsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=qFMihSGoewdyshzwX/m2/nP/fRO1pApx4410Go5LgUY=;
        b=QW/4111ZyB2TSrZ7SSDu148zs6MNLlcFbII0jPNR2UF4rNiq7/k8vHEV2HxTgJpIn8
         Fc8zHfmkcgE1RSnpqIhuT78eS1IeTQcKGNlQ5ZtN3L5SSK3YRjd8AXmjG4fXEk0xkDss
         ysrlTuvSKain7zCgzTipNuX10bpVVUtoKprTFVddTbN8ExkrP3DyY4EUDSzRI5yDdoNY
         GEZiZVz/hDU8Hs3Wu2606DNsmBBa1S3BPkyBtJ+NCOKAkPmt8cVJSvRpaFTBe9JYwmcu
         evSHK9IdSckuh6wus0sehgjceXdVRuZbcyUZzEcG1ytViJmhOu3kLm2pK+XyfgF9z3SP
         G29Q==
X-Gm-Message-State: AOAM531K9ROsVmGzMCN3beoAOy0Ht9LT3bMnfsHyRsw38LGF2rO4Of/o
	zpyD9k8lssTf3UyL7EgvXM1AANRqKyM=
X-Google-Smtp-Source: ABdhPJyt4oQTMy9EyrMOxASYTiwbGrfnkoSDiWrkE3hcN9LctyNO0igz5/tOFXS/oe0BEjLKM1SEIA==
X-Received: by 2002:a19:6f4c:: with SMTP id n12mr2204616lfk.582.1640170792333;
        Wed, 22 Dec 2021 02:59:52 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Julien Grall <julien@xen.org>
Cc: Jan Beulich <jbeulich@suse.com>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
 <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <3a8b4905-dee5-6723-8987-0082207b2718@gmail.com>
Date: Wed, 22 Dec 2021 12:59:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 22.12.21 12:01, Julien Grall wrote:

Hi Julien

> Hi Jan,
>
> On 14/12/2021 17:45, Jan Beulich wrote:
>> On 14.12.2021 17:26, Oleksandr wrote:
>>> On 14.12.21 15:37, Jan Beulich wrote:
>>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int 
>>>>> order, unsigned int memflags)
>>>>>       void free_xenheap_pages(void *v, unsigned int order)
>>>>>    {
>>>>> +    struct page_info *pg;
>>>>> +    unsigned int i;
>>>>> +
>>>>>        ASSERT(!in_irq());
>>>>>           if ( v == NULL )
>>>>>            return;
>>>>>    +    pg = virt_to_page(v);
>>>>> +
>>>>>        memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>>> ... this really want to (logically) move into the new arch hooks.
>>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>>> notice there's some dead code there on x86, which I guess I'll make
>>>> a patch to clean up). But first of all this suggests that you want
>>>> to call the hooks with base page and order, putting the loops there.
>>>
>>> I see your point and agree ... However I see the on-list patches that
>>> remove common memguard_* invocations and x86 bits.
>>> So I assume, this request is not actual anymore, or I still need to 
>>> pass
>>> an order to new arch hooks? Please clarify.
>>
>> Well, that patch (really just the Arm one) effectively takes care of
>> part of what I did say above. Irrespective I continue to think that
>> the hook should take a (page,order) tuple instead of getting invoked
>> once for every order-0 page. And the hook invocations should be placed
>> such that they could fulfill the (being removed) memguard function
>> (iirc that was already the case, at least mostly).
>
> IIUC your suggestion, with your approach, alloc_xenheap_pages() would 
> look like:
>
>      for ( i = 0; i < (1u << order); i++ )
>          pg[i].count_info |= PGC_xen_heap;
>
>      arch_alloc_xenheap_pages(pg, 1U << order);
>
> The Arm implementation for arch_alloc_xenheap_pages() would also 
> contain a loop.
I have the same understanding (except passing an order instead of a 
number, but it doesn't really matter now)

#define arch_alloc_xenheap_pages(p, order) ({                   \
     unsigned int cnt_ = 1u << (order);                          \
     while (cnt_--)                                              \
         page_set_xenheap_gfn(&(p)[cnt_], INVALID_GFN); \
})

So yes if !CONFIG_SEPARATE_XENHEAP there will be two loops here.



>
>
> This could turn out to be quite expensive with large allocation (1GB 
> allocation would require 16MB of cache) because the cache may not have 
> enough space contain all the pages of that range. So you would have to 
> pull twice the page_info in the cache.
>
> This is something we noticed when working on reducing the downtime for 
> Live-Update. We were able to save 100s ms by reducing the number of 
> loop on the page_info.
>
> So I would prefer Oleksandr's approach here.
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 11:04:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 11:04:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250768.431867 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzQA-0003Ix-TV; Wed, 22 Dec 2021 11:04:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250768.431867; Wed, 22 Dec 2021 11:04:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzQA-0003Iq-Q4; Wed, 22 Dec 2021 11:04:34 +0000
Received: by outflank-mailman (input) for mailman id 250768;
 Wed, 22 Dec 2021 11:04:33 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2rHP=RH=epam.com=prvs=2990e6cae6=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1mzzQ9-0003Ik-3V
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 11:04:33 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ef73e66c-6316-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 12:04:31 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BMAxntW030235;
 Wed, 22 Dec 2021 11:04:20 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d42cg833c-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 11:04:20 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7471.eurprd03.prod.outlook.com (2603:10a6:102:10f::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Wed, 22 Dec
 2021 11:04:15 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 11:04:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ef73e66c-6316-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=AayGWCsQt01rjlgNsjG/TLIa/kI/+F4PNSBxlyF9q9mBzzGfml10IOkcIlJ714PLBd0903CZeutlSO7apH9Qch6YdkS+xhWellp9xHqmkvKJlSrxXvp0i8oVyWBPJ5ih+0jEbngwi49NxHavishlj9LbchZ5iFpgKdfAJJso5wpTr6oGzlkEvqO9UKL9W8gl2JQi1RehgZC1Jm5vArOX3WYQqNhhLxxkh0QH3dLy4Gs0wYnIJKrDULVLPsCLEiaDUtRWqN5mS6sixshy8AvBBPNH7BKcUm7HKCYfZbAYPZ/MBKhSODGC7dt1O85RyWhxRVWS0m2Jmjf80J+NSXeC4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=f+x90w+uVjT0LbbwxmJrq4msfw3G5Y6ih3FSdxGr+yo=;
 b=FXcWFkzjzHhFEIB20UCcVU36nh16mTN2CsY1ccXxw8uTQmx5T2JKhKIsbEGFNyiRkk3u7NGLUzYutdrvKNySVyy1T1hf9ZLkDaMLTMnOiahweLOZ1XXXyUSfvDEaefPooe1TTQEiQU74YPMHbRYV3NOy2AWYNrPXh+qTur5fM4rmD7J88043DsaKFIJkpmgxSfzspuROaNvByzKnONwPr42aOEh2WGtNbx8JTxFpq2xfxYNUGzLrDYpzadS3HBDG6P7u9haMejhUru8kmIwHreN6zE3ZAfpyoiJkkytwKvuGONAjM25Gt2uGw8a4l0BYARe7f0tVtVYmjqWouM5Q7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=f+x90w+uVjT0LbbwxmJrq4msfw3G5Y6ih3FSdxGr+yo=;
 b=MSWlI1mWd1CK/DqbaL8rQdqjaGjdzDfzTe+9YrkwKcf+qfHgKYdA8bBHxRB3jIXHJOTvjeH8evKldM9vsNqVJlogRyWwKx1FMFvkGzAFYWZ9EjNPEoX2XDWt+IRshCO6p0ld8IEaGrAHc/NaexBWZ7TEO2TIAirNw7epFrxnti2kFIvYUgExePi1q7FCPhO0Zr2ouuD5CB+fwQkhF3OnzaALWai9HHZuy5NzAWgIO9phNX40AiFnj6725KOt6VrZcsB7xy5+HhKTOoie//xUIs7KA88Z5DAibikFWQfi67EPwXDafJj+kizF6MKq9/p912Z2b8bIJYTNIkS62ntDzw==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuAgAAWSACAAOV/AA==
Date: Wed, 22 Dec 2021 11:04:15 +0000
Message-ID: <20211222110414.GA2883815@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 03606bc4-6271-4202-73a2-08d9c53acb2a
x-ms-traffictypediagnostic: PA4PR03MB7471:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB747191BE11F9BD328CD67969E37D9@PA4PR03MB7471.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 BwFv630iqjtfqGJYLwi8l+DXFA574VmBT6TSuWrIP946qcmZOiYeFl0JZ1TGRCmKF4bIdt4goJbSQWlQ5RC/MwuOzd3cwZhtGmJ0bTiOyNwZqET2l9jBSvm/XYzTuceBqsiXPlXJ7ZYiCe073Vla2c2G/8PC1McJ+Hcqm4ZL/PvjY1psUyaJTsqgYtxsyZ3fIj4GiEvs++fIYOcKUhQmA+Ny/Ex5vMWQY+IybXQZF/nwcBzDEGv3Y6GSCmQOJg0IOoMktYDOyuXNOkak1yKbKAQVmMCuUSYTLR2TmdKqaJIfk8GH1e20m9dt+5cDGcae9GEf5C/N9gf0KYdJfB0s0PVCHC4slQUra5uDPEVgQQh5SF8GzPMnEx4kv201e95Zyos6vRdKIbYmP4PGNhRIjdZHrJ5qRxbhe/ISDx1ZeIyHJRToXS/ddX69ORu6I+PZeNsjYhuFSRUDaxQESBl/pRqRWTiG0vn96Kr6Dk5fBzuki2xwdjJOQXI/+Sds9aubhb/ra04NUKyVnoNahAiA8UWe7vmdFlbjjPCs9g5zib3xWR3z5GopSBdhvSfeKoQq8FQtBY7YecZ6pjq/FpUdHeKKAdjfrSgr90Q0YovCTPTriMxLjH33AhJqDcaY3xtVqrtN1fYhrQ9DFJKBnh0dJCtiA4FBqzWfzOSNHxSqdc9j5xoqUSCpNxx0qMlFuEBS1OwldrtLnIBSUSRBp/oUEfmgMeo5XMwnYpaxyK2Z5SLITyjmFok/8Z8IBSkh08gRUp/SW+it5o9VUMiTIn/gwCDQVuPH749/xdDaRyIH609tsemalsYMCRz0QxOAYpJb
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(186003)(8676002)(64756008)(4326008)(54906003)(30864003)(6506007)(38070700005)(2906002)(66446008)(66946007)(66556008)(66476007)(91956017)(316002)(71200400001)(26005)(76116006)(33716001)(6512007)(1076003)(122000001)(86362001)(83380400001)(8936002)(5660300002)(6916009)(966005)(33656002)(508600001)(9686003)(6486002)(38100700002)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?y/f/2h7bF8U4487NOxEKu2f1HUoPb8zEfyMPOneTB8Wl6U5M678GxAdZCL7t?=
 =?us-ascii?Q?icto/5ht523i8BXy0XlLVnnD1fd12Zl0bs1M2s144JR3ZhM7wFIyC74vey+j?=
 =?us-ascii?Q?9cdTmHaDBJw17Oar4O24caQYYOaCbMe4mPjh23q874uU3PY5fOhbN3GWkKVO?=
 =?us-ascii?Q?+xtOxOvQ02GrfsQWClgF3lXJ8ZiuExWFjDd1Nr3gOZaonsxt2ydW4h094TXt?=
 =?us-ascii?Q?OVzanYG4MGqAXPSSBoGE4hYNJH3tuvToESd6eiP0wtwideN1Jfm6mYkOMbB5?=
 =?us-ascii?Q?HzxwJoglkOi7Ccg4DhDBGPy+h6grTc2zCDq3AeYDqvaLMPLnUnKmp9qW40Er?=
 =?us-ascii?Q?/Z/dTFMqEuHxyeEXCxwVnu1x9d99zkMoD6BvFlxw0p3scGfITBblhj3t1nmF?=
 =?us-ascii?Q?59ZfTzld7LAGLNTbL1B/c5AVQ8ySfeq8GWrQxLOZubd82URzIjviA/Fsd2HL?=
 =?us-ascii?Q?OA441yAtl2CobV+oaATGrD2KzwEban6qWIvVq/v4WP4wUmu6AFlhHVhnMBED?=
 =?us-ascii?Q?4tBJW04X+Gdpi/RuQwfgVY3GC/UVLJNn1cVAjw1tQhmzDHh4yduVP4+cZ1fn?=
 =?us-ascii?Q?8TYuGiAnz1txdOnH2fV5B2gt0QZUDgWZRNsrIiNOaIulmLOtLP8ub9GLpg+K?=
 =?us-ascii?Q?3v5HzGEBYVd9aib5Gym4leDtWG4KPtdz6TJBIKGdCpu7mGD99SXBpsNkAODq?=
 =?us-ascii?Q?JxsJVbAaCOo/yvabVh/rT9qKx35ecubWWykc60TeHL8dPDBYxUAVm4nsCuP+?=
 =?us-ascii?Q?2LiKnzv8OuHGyVw8dgaMaRh6VUub6aB4PTZO8FnezVhCDfz/hI9QS0g1uUTO?=
 =?us-ascii?Q?CsY+jXRdjNvObNUvdDyixu4N7lKEa7yMiAxtaQRxL9ddH5hKQO3wtgRZEGZB?=
 =?us-ascii?Q?ggzZbxRN4HrJWRRBfIK5EPAErZD79sZf6TISr/2iF+9Q6VIprE/1nvhHH3/e?=
 =?us-ascii?Q?u3rwk7Ini3GjMeuAVC9jbzoNWBgJviZgMRsaFZ6PubKQA+QTtWJZ6mQ1I7F6?=
 =?us-ascii?Q?5VTQqhux263Y4lhb7UjBJOT6dn5ymQfhHUlFmAMLmsVdqXaQS9jvSJmV3Aby?=
 =?us-ascii?Q?aZZp5v9s1mXJnO7UnFC8nMEN/TRqc6OLzl/ZZcjj7kltgHGyWlT+nqbZK/is?=
 =?us-ascii?Q?wyoge9OMb3kECqCLydL4AzJeIv9YAQou0NutNaeqmzvkSmfjf+QHkG6D4tmX?=
 =?us-ascii?Q?Ss1MpciUSj9YrtXuWboWmd6cH3WYKNv4TcoegTQOdJNk9a5wUsqdLEhpHgig?=
 =?us-ascii?Q?FkD8Fj4k8tQT/X4I+snsN20WlDPXgpCqHIRXpBzMctHeO7hFfRRtDy9Kqfnr?=
 =?us-ascii?Q?5Fujmi3bGYXpyO6K2Sbk/0+TsIcL8/2z+etskD13I1STsyMT7ABrjj3z4sTf?=
 =?us-ascii?Q?CnCk3dl+/Gup3tKtGPxGelC/EkTf1anRq0DiH0sMRd2vbybQ3uFVMVgOr6zb?=
 =?us-ascii?Q?/gLMhozdrw7/6JneF7rBbVo/T8iwe89yq9UtSsA8lzmThHIbQ/4E1PfoNn8e?=
 =?us-ascii?Q?IpMEntoDuvMvMwpsqWmR1/LzHUimwOVk4jg92n99Plz68a/0N4QIhD6Fp8Ql?=
 =?us-ascii?Q?2EQwAWdI6/A7lD2pCQ6S0S33cTCDnWD+VmkKq1hraPyAFlZ14sGX79dSpXps?=
 =?us-ascii?Q?79Qw6JoJLfx8TVlzt4pPssxPU7FF4vZ51Mqh88HKubsJEsTdtEAdPJhfQW38?=
 =?us-ascii?Q?H4f3dUNOJDUyAxVyetXowd/XeTM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D5F360217E78154690A5F370F9B0B24B@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03606bc4-6271-4202-73a2-08d9c53acb2a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 11:04:15.5874
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NoOvwnUL4CcfrYORPA1lcZ5ekXxMzR92+/ZGJGvm7bAxT/NDXXZdRt0+6ddCA2XBzRQPSNk+8xU2RxFbWJuBLVRcLdAyqCPQCUGxLzw+wTM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7471
X-Proofpoint-GUID: 9vzHv8vomBqM2-1znTAVY41f0BJ31LSs
X-Proofpoint-ORIG-GUID: 9vzHv8vomBqM2-1znTAVY41f0BJ31LSs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_04,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999
 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112220063

On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
> On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> > Hi Stefano,
> >=20
> > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > > Hi Stefano,
> > > >=20
> > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > This is the implementation of SCI interface, called SCMI-SMC dr=
iver,
> > > > > > which works as the mediator between XEN Domains and Firmware (S=
CP, ATF etc).
> > > > > > This allows devices from the Domains to work with clocks, reset=
s and
> > > > > > power-domains without access to CPG.
> > > > > >=20
> > > > > > The following features are implemented:
> > > > > > - request SCMI channels from ATF and pass channels to Domains;
> > > > > > - set device permissions for Domains based on the Domain partia=
l
> > > > > > device-tree. Devices with permissions are able to work with clo=
cks,
> > > > > > resets and power-domains via SCMI;
> > > > > > - redirect scmi messages from Domains to ATF.
> > > > > >=20
> > > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > ---
> > > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++=
++++++++
> > > > > >  xen/include/public/arch-arm.h |   1 +
> > > > > >  5 files changed, 809 insertions(+)
> > > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > >=20
> > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > > > index 186e1db389..02d96c6cfc 100644
> > > > > > --- a/xen/arch/arm/Kconfig
> > > > > > +++ b/xen/arch/arm/Kconfig
> > > > > > @@ -114,6 +114,8 @@ config SCI
> > > > > >  	  support. It allows guests to control system resourcess via =
one of
> > > > > >  	  SCI mediators implemented in XEN.
> > > > > > =20
> > > > > > +source "arch/arm/sci/Kconfig"
> > > > > > +
> > > > > >  endmenu
> > > > > > =20
> > > > > >  menu "ARM errata workaround via the alternative framework"
> > > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfi=
g
> > > > > > new file mode 100644
> > > > > > index 0000000000..9563067ddc
> > > > > > --- /dev/null
> > > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > > @@ -0,0 +1,10 @@
> > > > > > +config SCMI_SMC
> > > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > > +	default n
> > > > > > +	depends on SCI
> > > > > > +	---help---
> > > > > > +
> > > > > > +	Enables mediator in XEN to pass SCMI requests from Domains to=
 ATF.
> > > > > > +	This feature allows drivers from Domains to work with System
> > > > > > +	Controllers (such as power,resets,clock etc.). SCP is used as=
 transport
> > > > > > +	for communication.
> > > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makef=
ile
> > > > > > index 837dc7492b..67f2611872 100644
> > > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > > @@ -1 +1,2 @@
> > > > > >  obj-y +=3D sci.o
> > > > > > +obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
> > > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scm=
i_smc.c
> > > > > > new file mode 100644
> > > > > > index 0000000000..2eb01ea82d
> > > > > > --- /dev/null
> > > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > > @@ -0,0 +1,795 @@
> > > > > > +/*
> > > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > > + *
> > > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > > + *
> > > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > > + *
> > > > > > + * This program is free software; you can redistribute it and/=
or modify
> > > > > > + * it under the terms of the GNU General Public License as pub=
lished by
> > > > > > + * the Free Software Foundation; either version 2 of the Licen=
se, or
> > > > > > + * (at your option) any later version.
> > > > > > + *
> > > > > > + * This program is distributed in the hope that it will be use=
ful,
> > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty=
 of
> > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See t=
he
> > > > > > + * GNU General Public License for more details.
> > > > > > + */
> > > > > > +
> > > > > > +#include <asm/sci/sci.h>
> > > > > > +#include <asm/smccc.h>
> > > > > > +#include <asm/io.h>
> > > > > > +#include <xen/bitops.h>
> > > > > > +#include <xen/config.h>
> > > > > > +#include <xen/sched.h>
> > > > > > +#include <xen/device_tree.h>
> > > > > > +#include <xen/iocap.h>
> > > > > > +#include <xen/init.h>
> > > > > > +#include <xen/err.h>
> > > > > > +#include <xen/lib.h>
> > > > > > +#include <xen/list.h>
> > > > > > +#include <xen/mm.h>
> > > > > > +#include <xen/string.h>
> > > > > > +#include <xen/time.h>
> > > > > > +#include <xen/vmap.h>
> > > > > > +
> > > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > > +
> > > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C=
) */
> > > > > > +#define SCMI_SUCCESS              0
> > > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > > +#define SCMI_DENIED             (-3)
> > > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > > +#define SCMI_BUSY               (-6)
> > > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > > +
> > > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > > > > +
> > > > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > > > >=20
> > > > > I could find the following SCMI binding in Linux, which describes
> > > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > >=20
> > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > >=20
> > > > > However, linux,scmi_mem is not described. Aren't you supposed to =
read
> > > > > the "shmem" property instead? And the compatible string used for =
this
> > > > > seems to be "arm,scmi-shmem".
> > > > >=20
> > > >=20
> > > > We use linux,scmi_mem node to reserve memory, needed for all
> > > > channels:
> > > >=20
> > > > reserved-memory {
> > > >     /* reserved region for scmi channels*/
> > > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > > >         no-map;
> > > >         reg =3D <0x0 0x53FF0000 0x0 0x10000>;
> > > >     };
> > > > };
> > > >=20
> > > > arm,scmi-shmem node used in shmem property defines only 1 page need=
ed to
> > > > the current scmi channel:
> > > >=20
> > > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > > >     compatible =3D "arm,scmi-shmem";
> > > >     reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > > > };
> > > >=20
> > > > For each Domain reg points to unigue page from linux,scmi_mem regio=
n,
> > > > assigned to this agent.
> > >=20
> > > If we were to use "linux,scmi_mem" we would have to introduce it as a
> > > compatible string, not as a node name, and it would need to be descri=
bed
> > > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > >=20
> > > But from your description I don't think it is necessary. We can just =
use
> > > "arm,scmi-shmem" to describe all the required regions:
> > >=20
> > > reserved-memory {
> > >     scp-shmem@0x53FF0000 {
> > >         compatible =3D "arm,scmi-shmem";
> > >         reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > >     };
> > >     scp-shmem@0x53FF1000 {
> > >         compatible =3D "arm,scmi-shmem";
> > >         reg =3D <0x0 0x53FF1000 0x0 0x1000>;
> > >     };
> > >     scp-shmem@0x53FF2000 {
> > >         compatible =3D "arm,scmi-shmem";
> > >         reg =3D <0x0 0x53FF2000 0x0 0x1000>;
> > >     };
> > >     ...
> > >=20
> > > In other words, if all the individual channel pages are described as
> > > "arm,scmi-shmem", why do we also need a single larger region as
> > > "linux,scmi_mem"?
> > >=20
> >=20
> > That was my first implementation. But I've met a problem with
> > scmi driver in kernel. I don't remember the exact place, but I remember
> > there were some if, checking if memory weren't reserved.
> > That's why I ended up splitting nodes reserved memory region and actual
> > shmem page.
> > For linux,scmi_mem node I took format from /reserved-memory/linux,lossy=
_decompress@54000000,
> > which has no compatible string and provides no-map property.
> > linux,scmi_shmem node is needed to prevent xen from allocating this
> > space for the domain.
> >=20
> > Very interesting question about should I introduce linux,scmi_mem node
> > and scmi_devid property to the
> > Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> > Those node and property are needed only for Xen and useless for
> > non-virtualized systems. I can add this node and property description t=
o
> > arm,scmi.yaml, but leave a note that this is Xen specific params.
> > What do you think about it?
>=20
> Reply below
>=20
> [...]
> =20
>=20
> > > In general we can't use properties that are not part of the device tr=
ee
> > > spec, either https://urldefense.com/v3/__https://www.devicetree.org/s=
pecifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC=
595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kern=
el/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_29d=
bcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXloYU=
aj$ [git[.]kernel[.]org]
> > >=20
> > > "linux,scmi_mem" is currently absent. Are you aware of any upstreamin=
g
> > > activities to get "linux,scmi_mem" upstream under
> > > Documentation/devicetree/bindings in Linux?
> > >=20
> > > If "linux,scmi_mem" is going upstream in Linux, then we could use it.
> > > Otherwise, first "linux,scmi_mem" needs to be added somewhere under
> > > Documentation/devicetree/bindings (probably
> > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we ca=
n
> > > work on the Xen code that makes use of it.
> > >=20
> > > Does it make sense?
> > >=20
> >=20
> > Yes I agree. I think linux,scmi_mem and scmi_devid should be upstreamed=
.
> > I will add those properties to arm,scmi.yaml, mark them as related to X=
EN and send patch.
>=20
> I didn't realize that linux,scmi_mem and scmi_devid are supposed to be
> Xen specific. In general, it would be best not to introduce Xen specific
> properties into generic bindings. It is a problem both from a
> specification perspective (because it has hard to handle Xen specific
> cases in fully generic bindings, especially as those bindings are
> maintained as part of the Linux kernel) and from a user perspective
> (because now the user has to deal with a Xen-specific dtb, or has to
> modify the host dtb to add Xen-specific information by hand.)
>=20
>=20
> Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? It
> looks like a generic property that should be needed for the Linux SCMI
> driver too. Why the Linux driver doesn't need it?
>=20

scmi_devid used during domain build. It passed as input parameter for SCMI_=
BASE_SET_DEVICE_PERMISSIONS message.
On non-virtualized systems - there is no need of this call, because OS
is the only one entity, running on the system.

I've chatted with Volodymyr_Babchuk and he gave a great idea to add a
list of device_ids to dom.cfg, such as:
sci_devs =3D [ 0, 1, 15, 35 ];

Using this approach, we can remove scmi_devid from the device tree and
just pass a list of scmi_devids to XEN using additional hypercall.
We can probably make hypercall taking devid list as input parameter.
This will take only 1 hypercall to setup sci permissions.

>=20
> In regards to linux,scmi_mem, I think it would be best to do without it
> and fix the Linux SCMI driver if we need to do so. Xen should be able to
> parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) should
> be able to parse the "arm,scmi-shmem" nodes generated by Xen. Either
> way, I don't think we should need linux,scmi_mem.

This requires further investigation. I will try to make implementation
without linux,scmi_mem, using only arm,scmi-shmem nodes and share
reuslts with you.


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 11:14:35 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 11:14:35 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250773.431878 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzZc-000505-TH; Wed, 22 Dec 2021 11:14:20 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250773.431878; Wed, 22 Dec 2021 11:14:20 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzZc-0004zy-QJ; Wed, 22 Dec 2021 11:14:20 +0000
Received: by outflank-mailman (input) for mailman id 250773;
 Wed, 22 Dec 2021 11:14:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=HtqY=RH=gmail.com=ryancaicse@srs-se1.protection.inumbo.net>)
 id 1mzzZb-0004zc-Dn
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 11:14:19 +0000
Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com
 [2607:f8b0:4864:20::102f])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 49b94857-6318-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 12:14:11 +0100 (CET)
Received: by mail-pj1-x102f.google.com with SMTP id
 b1-20020a17090a990100b001b14bd47532so2291228pjp.0
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 03:14:17 -0800 (PST)
Received: from [30.135.82.253] ([8.218.232.85])
 by smtp.gmail.com with ESMTPSA id l6sm316268pfu.63.2021.12.22.03.14.14
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 22 Dec 2021 03:14:15 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 49b94857-6318-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=user-agent:date:subject:from:to:cc:message-id:thread-topic
         :references:in-reply-to:mime-version:content-transfer-encoding;
        bh=Vt0OKRh58O/606zjWJRGs/sHWORIYATpLumAzbOlz9Q=;
        b=eS5ryiwtbz+h1+iXR/P4pqk1UA0Gf1KsgFgEjlD2MQXPBoG8+K1FM+qNlBm6ndD84N
         R4sh/41SgUEn2Ci+fF89ZAcviGsS1BNwlUMS2T8r03K98EvA75JlHkUPUU/pOfXIGL4Z
         /B3pWaB04RS09NKXshMpY8nRGu9QiYgirABoRvFJomcH85N01e3dq9miSjWczkj9Cnb7
         0P4vtirx/Aw7reeKhXCOyuiCILvusVeIArzHixBzeJ56Izjwppcxt/7qFtpX6J+mqIHR
         kg9C34pYUrSh2xtveVHH5c6uH6lcNyO/Sv4cpZ6u7A9E0AZUicV6NZbTlRV9l0GozAXR
         Pe1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:user-agent:date:subject:from:to:cc:message-id
         :thread-topic:references:in-reply-to:mime-version
         :content-transfer-encoding;
        bh=Vt0OKRh58O/606zjWJRGs/sHWORIYATpLumAzbOlz9Q=;
        b=tY3a5iPRcF2Evaq/jgaR860RF3JemYcae3PkyqFmmaBY/oDIGbMU2D3A2ymkln5oDm
         j5fDibtacTG0ZOfnNZCPze6FTES2uCIblGjkugat8HUKSVqTRpuQz95h4UOyi59Yz2wa
         GWHq1qKbcUPXWaRc2g+9IkEYRLroOYcCBJh/Bf/d+lP8ShVljAJZ63JYpFhZW6ZYH/VE
         wBT0ScbJYa1sSyKbpy7d/GqVmc6jBImUE3dVoL1EoEL7gr6HvKGnanmmUaGANE7jj04R
         1nfKHyD/O9A0x6ZOzwiW8A5qN8Nfbl80uuC8yyPzJFa8yHvjeEp8RvWDI7akrw02zHCc
         pFLw==
X-Gm-Message-State: AOAM533jf0efsKkMchTFHa+KCSconDS2IWW2GUjGhLes0LSQDWJ1joC+
	w1XNIZPUo3CYyS9D1MyLUe4=
X-Google-Smtp-Source: ABdhPJxu2O6+2pmI6sPt1MZ0VG5K/N+QpEYM5MsjdHSD+oll/KJcKSQmY7peQXouM0645KFVWC3vew==
X-Received: by 2002:a17:902:7890:b0:143:c4f7:59e6 with SMTP id q16-20020a170902789000b00143c4f759e6mr2433972pll.87.1640171655515;
        Wed, 22 Dec 2021 03:14:15 -0800 (PST)
User-Agent: Microsoft-MacOutlook/16.56.21121100
Date: Wed, 22 Dec 2021 19:14:12 +0800
Subject: Re: [BUG] Resource leaks in Xen
From: Ryan Cai <ryancaicse@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
CC: <dgdegra@tycho.nsa.gov>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Message-ID: <224F8DE1-BBE1-4107-BE58-6A9DAD9C1C84@gmail.com>
Thread-Topic: [BUG] Resource leaks in Xen
References: <62B51AB1-2C2B-402A-A7C8-5ADACE265DA4@gmail.com>
 <afe6bc04-c87b-e627-d032-b205a6bcfe7e@suse.com>
In-Reply-To: <afe6bc04-c87b-e627-d032-b205a6bcfe7e@suse.com>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: quoted-printable

I have send a patch. Thank you for your reply.

Best,
Yuandao

=EF=BB=BFOn 22/12/2021, 5:28 PM, "Jan Beulich" <jbeulich@suse.com> wrote:

    On 22.12.2021 09:05, Ryan Cai wrote:
    >              I am writing you to report potential resource leak bugs.=
 In the file /xen/tools/flask/utils/label-pci.c, the methods fopen and fclos=
e may not matched when returning at Line 76, resulting in a resource leak. L=
ooking forward to your feedback. Thank for checking.
    >=20
    > Locations, https://github.com/xen-project/xen/blame/25849c8b16f2a5b7f=
cd0a823e80a5f1b590291f9/tools/flask/utils/label-pci.c#L63-L76

    Thanks for looking closely, but I'm afraid I don't see where any
    resources get leaked here: "f" will get closed implicitly after
    returning from main(). It might be good practice to close files
    explicitly, but that's purely cosmetic here afaics. Feel free to
    contribute a patch.

    Jan





From xen-devel-bounces@lists.xenproject.org Wed Dec 22 11:18:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 11:18:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250777.431889 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzdF-0005cv-DR; Wed, 22 Dec 2021 11:18:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250777.431889; Wed, 22 Dec 2021 11:18:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzdF-0005co-AJ; Wed, 22 Dec 2021 11:18:05 +0000
Received: by outflank-mailman (input) for mailman id 250777;
 Wed, 22 Dec 2021 11:18:04 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nRTG=RH=epam.com=prvs=29901831a2=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1mzzdE-0005ci-EX
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 11:18:04 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d342259d-6318-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 12:18:02 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BMAwhAR030695;
 Wed, 22 Dec 2021 11:17:58 GMT
Received: from eur03-am5-obe.outbound.protection.outlook.com
 (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d427q04dg-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 11:17:50 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB7713.eurprd03.prod.outlook.com (2603:10a6:102:205::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 22 Dec
 2021 11:17:46 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%6]) with mapi id 15.20.4823.018; Wed, 22 Dec 2021
 11:17:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d342259d-6318-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cOvfUuDNeUdvCnjfk8tEB56iNPLR2UYnG2hGKXr4ExMrc+EKUT0pjbBaVD8ePQYi7ll6/51Hqi/DD0OnTkdTkV9iE0OTh3hfO8gXhJPKhy4yVUqkBrXgKdeSn8j4dZfT/iVao1hIyT7pjkDQSDk0iVFV9r3bx1A7c3Jj8WJMoRnCCfSCuw8HGf5dvgFcookfV57I1AKVrXBUDpW89uIUYbbhPdr0CRlXtr+VzUdFgyR1XlU5wktHsjn9JDCVFatFU7A1My4UIYq05DicTLrTXOkx6A86Vx9Cm6xRK7NwsPWWlxSvDfFdmHvruNc8n2fh/KFSSkkeCqRvHH8nsMvL2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=vC5oRR6KKBEntPspe24mX35CWo5EklTsERTC76ZXwE4=;
 b=OiRu9K1HPmhTzNoyBIdFY8R9w3E1vAPl85XlBubm1BV6mfBnU4ah9XSmWcJqUrf1uBYaYUFqfNcMQtwgiCGZ7jTe9L1dK4aL1VDdxsaruAXg1HUBmxr0gFGFClZmOyzPWm812pxcMSrqfbZ9KVQ6pvqvMgZR427tOVxUaXVobMElnBbpguwFNhNN9GwywfcH9GY1qgKhXGTmMgFcPLMRG/m8PBYQ0p3wcuh/p3T+r5Hdl2AErvcmLbWi0CQUbv1vdJ/1UeAOlX6qBvVuc2NGMlXQM2M2eRNITIoPX4+p71qKvdKTf8wyhY/7SlkzNm3zAv9cQ0EeYti+gDVKvXNI/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=vC5oRR6KKBEntPspe24mX35CWo5EklTsERTC76ZXwE4=;
 b=XIO4b2PVjciJr7yJTJg3eQdnvuDnXUBV6Ogx586VSuEsK+qBcyTK0YO6TCGAzWePXEUhzmKC5iT2WLT5OaJj1EGn0XMXbAfAPTfN3MtbWm8nfpoK2C5xdCL1e9VMKqtyhxi3OdVl4rHX1s7y2KV5S6ZVArYnhe1qL6nWBUGSEGY4nvBb5j52e/SvX9V2QhjCON/qycGXfI1KAtC/2nFomWEukHUK1S9AoNHL8DJkkdp3f43J3ALyGYZl1v4jVdMTDLFQkCv+VGqqeVkDnT3lKyBSxvoA4WQ7lnJdotcc+Qh5nUHc7fzl8qEArFCpnAzkF6tVwn+WRAAa/NIgWavvZQ==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Anthony PERARD
	<anthony.perard@citrix.com>,
        Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: 
 AQHX8M3LNgat3drmYUW4ty+W1/SkP6w0P2iAgAJeh4CABnNRgIAAc5MAgADFCgCAAB3ugA==
Date: Wed, 22 Dec 2021 11:17:45 +0000
Message-ID: <87lf0cx50o.fsf@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org>
In-Reply-To: <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b37bcc1b-e6bc-4cef-367a-08d9c53cae22
x-ms-traffictypediagnostic: PAXPR03MB7713:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB7713862E7D5F4F37A283520BE67D9@PAXPR03MB7713.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 MRy2hBbKeBELmEBpUjVo0rTw1UYx8+X6/XVqszvFOQdt4rCLuK+LlDkn+xTcbv69W4nUti0VY1c7aiFITX8KE7gN+I9N1HKI9Q1Pl7q7uGqm6aqUcIPXravD+DkWaK6CdP2D6KzO+cNpKSve3odglbkzZ8/ZR5ec07E1mNI9e8QHlMA2zsvX+o5BZiLro0DS9P47GShBDwuUaWbgRZL4SkxxgL+pDujZuzMAd2Q/173mXl/1QP8CignWs4YW9ZX86aCKf9HJZglbpxVZePE1h4D3GHHka3rccpDE2fUrjp1cktYoDzqDC3xXJq0L1S5BAMu8FOJMM8+6cdaknzEWaA3ojYiYCHjVAw9o4R3mUrxiGIR0TqNqr92u3n2OO2Rz8lpIUBVURosaTH8HWD83AdA1H3JSXtys8BEXGAtfk3pJB/sZkpmBDahzrHD68KXbhaac2Kg6BBYrSAss8dXTaHn7zx74AY3C+EpxNNurisp5NxTveZ4L2h0SSUaowbidxoIHsfSCmkMGdg6hULLG4/H8DogOLjIejEOlWYGmTY/MUTlA5TqAkSqA9JAI9dFpcsmG/2EBiiuiVV0B0XivzwhxVl91zmqmFYreBu/GKoNguULX9DgrdiRJehc5402BMKHCNnPvVgrRaqWP2J+lwDswSPgyhChUzG/JFdt5DoM2ctwcbQovgbPgd6zY4RUgSGhZ7XZWmKoHmiDpmJ1B/Q==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(38070700005)(122000001)(38100700002)(71200400001)(7416002)(36756003)(53546011)(6506007)(2906002)(508600001)(5660300002)(4326008)(316002)(8936002)(66946007)(6486002)(8676002)(186003)(6512007)(26005)(83380400001)(66476007)(54906003)(55236004)(91956017)(6916009)(66446008)(76116006)(2616005)(64756008)(66556008);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UFhxMDJDR3R6M2NuYVhKYThRYnZXOGg4R1FhczF0aW95eHlZVTQvSlg0S3Yx?=
 =?utf-8?B?QkNxMEJoOXJtbFpSbjMyOUlnZzFUMFRLZDJXZkZpcVVEY2lPNzFZN0hyUk1U?=
 =?utf-8?B?SWR4Z2t4ek5uUnRKT3BrbjZuU0xmbjFmUm9qR0kzNEtBM3ZjenBYbnlPbHVq?=
 =?utf-8?B?RGJOdmxVaXo0K2kvUzRESU1SRlZWbmt2RWIzeHhZRUU3YWttMHV3NXgwVzZn?=
 =?utf-8?B?M0lNUDdIcUwyNiswUjNjOFpKRERibnI3N0dCZk1uN0o3VG5aRjdkWUdKcWtW?=
 =?utf-8?B?czZVQ0ZmT0pHdzEwcDJuK0tQTE9Nd1RGd00wVk81UVA5M21wQ1pVNCszdkJt?=
 =?utf-8?B?bGZwTWFiZFpocXp3SENROGpRSUxSZE1VRUh3U2FKZWRoMnpkRnNsZWJFTEFM?=
 =?utf-8?B?TFV4eVJSTENWSVllbUdtUTBZOCtRcXI5UkpUb1cya0dvN2RLRk5CVHNPMzhz?=
 =?utf-8?B?bDVtMG9HM1hWb0NGdGJRRlFXdm5ySU5yUTV4Z0hza0F5SXBqMkx6NlVvTVBY?=
 =?utf-8?B?bE5SS2hWTXBQS0RTR0dPdTExNE1PQ0VWdnlKTzAyRUxMazVaWDI1cGZPTDhW?=
 =?utf-8?B?VnI3aGNuSnFvV0Z2TDA3cDdGYjJrR0MxejB3dUp0eHNIUzY3eDlTRzBCT1RH?=
 =?utf-8?B?THJ3ZndxSS9uNHJGTHZpR0k3Y1E2YWZnUWlwWmF2cTQ4ajlUZHNiNWlXTTdQ?=
 =?utf-8?B?UWcwY1g5dGloRDl6Mm9OWWl4allLR3N1UHdaakNiZXJjQnhtSXFuT1FubVBr?=
 =?utf-8?B?NzQ2ZFRnUmg0eGN4S0RXZTlqT3J3a2pkK1E1b005QWpWc3VVei82eFBoN04r?=
 =?utf-8?B?WUY4MWhMUkorQ2g4QjlTR3QzOEdqQWlFL2Vqajk4dGJnSTV3aVI1RW9qWklQ?=
 =?utf-8?B?TitwUzI3RnpmMU85OHdFNTRQYkExaHpkc1B0VXhqcERsOFhveEJFbjlnUjJN?=
 =?utf-8?B?TEw3TkxrQW52cjVhYVdhbmRJRHNmUXRJRUFnV2JXa2RtRWpFM2gwcG13M1VG?=
 =?utf-8?B?aUk4ZUR3SUhqOFVHT1FKWmp5b25YN2NCc3B5KzJ0dnVlYjNCOXhZa09lQjRu?=
 =?utf-8?B?VHlBbCtzMTZ5b3FGbmJTOHNTRUVHajlDS0pzTUFTcUN5WDlFeVF6NEQrMFNC?=
 =?utf-8?B?a0Q1VmhjZ21MaFVacDFmOVNaaDV4NFk3c2t1S3kxUXB0N1ppQ21CNmUrK0VM?=
 =?utf-8?B?QWxlV2swL2pDUmFQUXRHN3gxMldpUGFyazZMTmhiNkUvbTd1VU1MQ21OYmpR?=
 =?utf-8?B?V2h0TlMzZCtDOHZBbnJqMW1TMmdYUkVyampadW5IbzFKTnZWS1RPcDc1emVr?=
 =?utf-8?B?YzdzbkpuM0xpTmZabmtlbmpIWWl2d3RaSTFJa2k5NG5VdDFZU3lJNS9Lbkhk?=
 =?utf-8?B?clRpVFFOSFYvVmVUV0NaQ2hXREpQR2VYanBlNVVFdjVSQ1RPSEpNZWJHN3dL?=
 =?utf-8?B?L09DS3ZveXFNMGUxeGRxc2lTZldHMUlwMk5vb2svb3prRWxiTFhoRUFzUDVy?=
 =?utf-8?B?Ulp6S3Q0QWlXUlI1d04rMUJBZDh1U1AzRU1BajJBK3doRGljSndRclROQjlE?=
 =?utf-8?B?anZmRWRpUExIcnBvT0h5MVJmZmNjTzhBMGtDdVhXazd5QTRZaHZzd2srRzVL?=
 =?utf-8?B?SVFua2RIa3dyOFJzWUhlZ29HNXdOb2FYL3d6dHpQNERPTWlZTlBDT0t5R2g4?=
 =?utf-8?B?cGFGZWFyS2lRdWo0dFRVTlA0QnozalJ0UGM5NkJqcFdLME81YmlOYTU4RjA1?=
 =?utf-8?B?czl6VzAxSEtOZ1c1RHRaN0xNUGJwUGN1UmVkWTliTjlwb1BzWFBpa3FkSVRz?=
 =?utf-8?B?dkFPZmNXOHFUY0x3VGlmRU9WdHU1Z0hsdURZNUpoaERuY3FIU1B1YVYyWlRI?=
 =?utf-8?B?TDBYaDBBVXFhUSs2akRneTdaVUt0UEIvZUE5VVJYNytJMFZqaGl6YVpGYThQ?=
 =?utf-8?B?VWpPTlpQTGtIY0Q4SjRxVGVpcFA2MmZack1FV1Zzc2xkalFFZXM5UHFiN0N2?=
 =?utf-8?B?TmQrMndYa2Z3VjhadHU3d3l1Y24wUDZ5MnBhK1ZKRVdLNE1RK0pGTXJoZUN2?=
 =?utf-8?B?R29XWDNoSmYzMTBRZDVVdHJLcU52bHM1dHJhRGxMRTVHZkYzU2tsR1lXL2hM?=
 =?utf-8?B?UGxzditOMktuZlpyWSswRXRmNUJZVXZzMVBLamNKam0xbmFBZlhuTVNENlAr?=
 =?utf-8?B?b010THlsYTJnMVRpeU5QTm5iNVp6SWVVVFpqNjB1ZFZuRlM5VFFrNExZcGtq?=
 =?utf-8?Q?yV5ngv8GFsLEmzl1BvhNmcKjM9Aa6XR2ZbLF4wj0MA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <BCFC2A1D90752F488E9D335F7E55A386@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b37bcc1b-e6bc-4cef-367a-08d9c53cae22
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 11:17:45.8417
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vzi22BrpW2K6WqB52NWiuyZgoZtSlHAmKw9Xnhu2zSD0R5wc3Eq0swuA+3QFRl112RxTqiAeCYNXLwWjBi+zYIiinmb0AR6aLz854Y+CQYg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7713
X-Proofpoint-ORIG-GUID: XtXKcb2wS4_JJUXvX1yu9BuhY-tcVkoK
X-Proofpoint-GUID: XtXKcb2wS4_JJUXvX1yu9BuhY-tcVkoK
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_05,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0
 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999
 clxscore=1015 priorityscore=1501 malwarescore=0 mlxscore=0 impostorscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112220064

DQpIaSBKdWxpZW4sDQoNCkp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyaXRlczoNCg0K
PiBIaSBTdGVmYW5vLA0KPg0KPiBPbiAyMS8xMi8yMDIxIDIyOjM5LCBTdGVmYW5vIFN0YWJlbGxp
bmkgd3JvdGU6DQo+PiBPbiBUdWUsIDIxIERlYyAyMDIxLCBBbnRob255IFBFUkFSRCB3cm90ZToN
Cj4+PiBPbiBGcmksIERlYyAxNywgMjAyMSBhdCAxMjoxNToyNVBNICswMDAwLCBPbGVrc2lpIE1v
aXNpZWlldiB3cm90ZToNCj4+Pj4+IE9uIDE0LjEyLjIxIDExOjM0LCBPbGVrc2lpIE1vaXNpZWll
diB3cm90ZToNCj4+Pj4+PiBAQCAtMTgxNywxNyArMTg1OCwyNCBAQCBzdGF0aWMgdm9pZCBsaWJ4
bF9fYWRkX2R0ZGV2cyhsaWJ4bF9fZWdjICplZ2MsIGxpYnhsX19hbyAqYW8sIHVpbnQzMl90IGRv
bWlkLA0KPj4+Pj4+ICAgIHsNCj4+Pj4+PiAgICAgICAgQU9fR0M7DQo+Pj4+Pj4gICAgICAgIGxp
YnhsX19hb19kZXZpY2UgKmFvZGV2ID0gbGlieGxfX211bHRpZGV2X3ByZXBhcmUobXVsdGlkZXYp
Ow0KPj4+Pj4+IC0gICAgaW50IGksIHJjID0gMDsNCj4+Pj4+PiArICAgIGludCBpLCByYyA9IDAs
IHJjX3NjaSA9IDA7DQo+Pj4+Pj4gICAgICAgIGZvciAoaSA9IDA7IGkgPCBkX2NvbmZpZy0+bnVt
X2R0ZGV2czsgaSsrKSB7DQo+Pj4+Pj4gICAgICAgICAgICBjb25zdCBsaWJ4bF9kZXZpY2VfZHRk
ZXYgKmR0ZGV2ID0gJmRfY29uZmlnLT5kdGRldnNbaV07DQo+Pj4+Pj4gICAgICAgICAgICBMT0dE
KERFQlVHLCBkb21pZCwgIkFzc2lnbiBkZXZpY2UgXCIlc1wiIHRvIGRvbWFpbiIsIGR0ZGV2LT5w
YXRoKTsNCj4+Pj4+PiAgICAgICAgICAgIHJjID0geGNfYXNzaWduX2R0X2RldmljZShDVFgtPnhj
aCwgZG9taWQsIGR0ZGV2LT5wYXRoKTsNCj4+Pj4+PiAtICAgICAgICBpZiAocmMgPCAwKSB7DQo+
Pj4+Pj4gLSAgICAgICAgICAgIExPR0QoRVJST1IsIGRvbWlkLCAieGNfYXNzaWduX2R0ZGV2aWNl
IGZhaWxlZDogJWQiLCByYyk7DQo+Pj4+Pj4gKyAgICAgICAgcmNfc2NpID0geGNfZG9tYWluX2Fk
ZF9zY2lfZGV2aWNlKENUWC0+eGNoLCBkb21pZCwgZHRkZXYtPnBhdGgpOw0KPj4+Pj4+ICsNCj4+
Pj4+PiArICAgICAgICBpZiAoKHJjIDwgMCkgJiYgKHJjX3NjaSA8IDApKSB7DQo+Pj4+Pj4gKyAg
ICAgICAgICAgIExPR0QoRVJST1IsIGRvbWlkLCAieGNfYXNzaWduX2R0X2RldmljZSBmYWlsZWQ6
ICVkOyAiDQo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgInhjX2RvbWFpbl9hZGRfc2NpX2Rldmlj
ZSBmYWlsZWQ6ICVkIiwNCj4+Pj4+PiArICAgICAgICAgICAgICAgICByYywgcmNfc2NpKTsNCj4+
Pj4+PiAgICAgICAgICAgICAgICBnb3RvIG91dDsNCj4+Pj4+PiAgICAgICAgICAgIH0NCj4+Pj4+
PiArDQo+Pj4+Pj4gKyAgICAgICAgaWYgKHJjKQ0KPj4+Pj4+ICsgICAgICAgICAgICByYyA9IHJj
X3NjaTsNCj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4gSWYgSSBnZXQgdGhpcyBjb2RlIHJpZ2h0LCBpdCBz
b3VuZHMgbGlrZSB0aGUgZG9tLmNmZydzIGR0ZGV2IHByb3BlcnR5IGlzDQo+Pj4+PiByZXVzZWQg
dG8gZGVzY3JpYmUgc2NpIGRldmljZXMgYXMgd2VsbCwgYnV0IHRoZSBsaWJ4bF9fYWRkX2R0ZGV2
cygpIGRvZXMgbm90DQo+Pj4+PiAoYW5kIGNhbiBub3QpIGRpZmZlcmVudGlhdGUgdGhlbS4gU28g
aXQgaGFzIG5vIG9wdGlvbiBidXQgdG8gc2VuZCB0d28NCj4+Pj4+IGRvbWN0bHMgZm9yIGVhY2gg
ZGV2aWNlIGluIGR0ZGV2c1tdIGhvcGluZyB0byBhdCBsZWFzdCBvbmUgZG9tY3RsIHRvDQo+Pj4+
PiBzdWNjZWVkZWQuIE9yIEkgcmVhbGx5IG1pc3NlZCBzb21ldGhpbmc/DQo+Pj4+Pg0KPj4+Pj4g
SXQgZmVlbHMgdG8gbWUgdGhhdDoNCj4+Pj4+ICDCoC0gZWl0aGVyIG5ldyBkb20uY2ZnJ3MgcHJv
cGVydHkgY291bGQgYmUgaW50cm9kdWNlZCAoc2NpZGV2PykgdG8gZGVzY3JpYmUNCj4+Pj4+IHNj
aSBkZXZpY2VzIHRvZ2V0aGVyIHdpdGggbmV3IHBhcnNpbmcgbG9naWMvbWFuYWdlbWVudCBjb2Rl
LCBzbyB5b3Ugd2lsbCBlbmQNCj4+Pj4+IHVwIGhhdmluZyBuZXcgbGlieGxfX2FkZF9zY2lkZXZz
KCkgdG8gaW52b2tlIFhFTl9ET01DVExfYWRkX3NjaV9kZXZpY2UsDQo+Pj4+PiBzbyBubyBtaXhp
bmcgdGhpbmdzLg0KPj4+Pj4gIMKgLSBvciBpbmRlZWQgZHRkZXYgbG9naWMgY291bGQgYmUgKmNv
bXBsZXRlbHkqIHJldXNlZCBpbmNsdWRpbmcgZXh0ZW5kaW5nDQo+Pj4+PiBYRU5fRE9NQ1RMX2Fz
c2lnbl9kZXZpY2UgdG8gY292ZXIgeW91ciB1c2UtY2FzZSwgYWx0aG91Z2ggc291bmRzIGdlbmVy
aWMsIGl0DQo+Pj4+PiBpcyB1c2VkIHRvIGRlc2NyaWJlIGRldmljZXMgZm9yIHRoZSBwYXNzdGhy
b3VnaCAodG8gY29uZmlndXJlIGFuIElPTU1VIGZvcg0KPj4+Pj4gdGhlIGRldmljZSksIGluIHRo
YXQgY2FzZSB5b3Ugd291bGRuJ3QgbmVlZCBhbiBleHRyYQ0KPj4+Pj4gWEVOX0RPTUNUTF9hZGRf
c2NpX2RldmljZSBpbnRyb2R1Y2VkIGJ5IGN1cnJlbnQgcGF0Y2guDQo+PiBJIHJlYWxpemUgSSBk
aWQgbXkgcmV2aWV3IGJlZm9yZSByZWFkaW5nIE9sZWtzYW5kcidzIGNvbW1lbnRzLiBJDQo+PiBm
dWxseQ0KPj4gYWdyZWUgd2l0aCBoaXMgZmVlZGJhY2suIEhhdmluZyBzZWVuIGhvdyBkaWZmaWN1
bHQgaXMgZm9yIHVzZXJzIHRvIHNldHVwDQo+PiBhIGRvbVUgY29uZmlndXJhdGlvbiBjb3JyZWN0
bHkgdG9kYXksIEkgd291bGQgYWR2aXNlIHRvIHRyeSB0byByZXVzZSB0aGUNCj4+IGV4aXN0aW5n
IGR0ZGV2IHByb3BlcnR5IGluc3RlYWQgb2YgYWRkaW5nIHlldCBvbmUgbmV3IHByb3BlcnR5IHRv
IG1ha2UNCj4+IHRoZSBsaWZlIG9mIG91ciB1c2VycyBlYXNpZXIuDQo+PiANCj4+IA0KPj4+Pj4g
UGVyc29uYWxseSBJIHdvdWxkIHVzZSB0aGUgZmlyc3Qgb3B0aW9uIGFzIEkgYW0gbm90IHN1cmUg
dGhhdCBzZWNvbmQgb3B0aW9uDQo+Pj4+PiBpcyBjb25jZXB0dWFsbHkgY29ycmVjdCAmJiBwb3Nz
aWJsZS4gSSB3b3VsZCBsZWF2ZSB0aGlzIGZvciB0aGUgbWFpbnRhaW5lcnMNCj4+Pj4+IHRvIGNs
YXJpZnkuDQo+Pj4+Pg0KPj4+Pg0KPj4+PiBUaGFuayB5b3UgZm9yIHRoZSBwb2ludC4gSSBhZ3Jl
ZSB0aGF0IHJldXNpbmcgWEVOX0RPTUNUTF9hc3NpZ25fZGV2aWNlDQo+Pj4+IHNlZW1zIG5vdCB0
byBiZSBjb25jZXB0dWFsbHkgY29ycmVjdC4gSW50cm9kdWNpbmcgbmV3IGRvbS5jZmcgcHJvcGVy
dHkNCj4+Pj4gc2VlbXMgdG8gYmUgdGhlIG9ubHkgd2F5IHRvIGF2b2lkIGV4dHJhIERvbWN0bCBj
YWxscy4NCj4+Pj4gSSB3aWxsIGhhbmRsZSB0aGlzIGluIHYyIGlmIHRoZXJlIHdpbGwgYmUgbm8g
Y29tcGxhaW5zIGZyb20gTWFpbnRhaW5lcnMuDQo+Pj4NCj4+PiBJIGRvbid0IGtub3cgaWYgdGhl
cmUgd2lsbCBiZSBhIGNvbXBsYWlucyBpbiB2MiBvciBub3QgOi0pLCBidXQgdXNpbmcNCj4+PiBz
b21ldGhpbmcgZGlmZmVyZW50IGZyb20gZHRkZXYgc291bmQgZ29vZC4NCj4+Pg0KPj4+IElmIEkg
dW5kZXJzdGFuZCBjb3JyZWN0bHksIGR0ZGV2IHNlZW1zIHRvIGJlIGFib3V0IHBhc3NpbmcgdGhy
b3VnaCBhbg0KPj4+IGV4aXN0aW5nIGRldmljZSB0byBhIGd1ZXN0LCBhbmQgdGhpcyBuZXcgc2Np
IGRldmljZSBzZWVtcyB0byBiZSBhYm91dCBoYXZpbmcgWGVuDQo+Pj4gImVtdWxhdGluZyIgYW4g
c2NpIGRldmljZSB3aGljaCB0aGUgZ3Vlc3Qgd2lsbCB1c2UuIFNvIGludHJvZHVjaW5nDQo+Pj4g
c29tZXRoaW5nIG5ldyAoc2NpZGV2IG9yIG90aGVyIG5hbWUpIHNvdW5kcyBnb29kLg0KPj4gVXNl
cnMgYWxyZWFkeSBoYXZlIHRvIHByb3ZpZGUgNCBwcm9wZXJ0aWVzIChkdGRldiwgaW9tZW0sIGly
cXMsDQo+PiBkZXZpY2VfdHJlZSkgdG8gc2V0dXAgZGV2aWNlIGFzc2lnbm1lbnQuIEkgdGhpbmsg
dGhhdCBtYWtpbmcgaXQgNQ0KPj4gcHJvcGVydGllcyB3b3VsZCBub3QgYmUgYSBzdGVwIGZvcndh
cmQgOi0pDQo+DQo+IElJUkMsIGluIHRoZSBwYXN0LCB3ZSBkaXNjdXNzZWQgdG8gZmV0Y2ggdGhl
IGluZm9ybWF0aW9uIGRpcmVjdGx5IGZyb20NCj4gdGhlIHBhcnRpYWwgZGV2aWNlLXRyZWUuIE1h
eWJlIHRoaXMgZGlzY3Vzc2lvbiBuZWVkcyB0byBiZSByZXZpdmVkPw0KPg0KPiBBbHRob3VnaCwg
dGhpcyBpcyBhIHNlcGFyYXRlIHRvcGljIGZyb20gdGhpcyBzZXJpZXMuDQo+DQo+PiBUbyBtZSBk
dGRldiBhbmQgWEVOX0RPTUNUTF9hc3NpZ25fZGV2aWNlIGFyZSBhcHByb3ByaWF0ZSBiZWNhdXNl
DQo+PiB0aGV5DQo+PiBzaWduaWZ5IGRldmljZSBhc3NpZ25tZW50IG9mIG9uZSBvciBtb3JlIGRl
dmljZXMuIFdlIGFyZSBub3QgYWRkaW5nIGFueQ0KPj4gYWRkaXRpb25hbCAibWVhbmluZyIgdG8g
dGhlbS4gSXQgaXMganVzdCB0aGF0IHdlJ2xsIGF1dG9tYXRpY2FsbHkgZGV0ZWN0DQo+PiBhbmQg
Z2VuZXJhdGUgYW55IFNDTUkgY29uZmlndXJhdGlvbnMgYmFzZWQgb24gdGhlIGxpc3Qgb2YgYXNz
aWduZWQNCj4+IGRldmljZXMuIEJlY2F1c2UgaWYgU0NNSSBpcyBlbmFibGVkIGFuZCBhIGRldmlj
ZSBpcyBhc3NpZ25lZCB0byB0aGUNCj4+IGd1ZXN0LCB0aGVuIEkgdGhpbmsgd2Ugd2FudCB0byBh
ZGQgdGhlIGRldmljZSB0byB0aGUgU0NNSSBsaXN0IG9mDQo+PiBkZXZpY2VzIGF1dG9tYXRpY2Fs
bHkuDQo+DQo+IEkgYW0gT0sgd2l0aCByZS11c2luZyBkdGRldi9YRU5fRE9NQ1RMX2Fzc2lnbl9k
ZXZpY2UgaG93ZXZlciB0aGVyZSBpcw0KPiBhIHBpdGZhbGwgd2l0aCB0aGF0IGFwcHJvYWNoLg0K
Pg0KPiBBdCB0aGUgbW9tZW50LCB0aGV5IGFyZSBvbmx5IHVzZWQgZm9yIGRldmljZSBwcm90ZWN0
ZWQgYnkgdGhlDQo+IElPTU1VLiBJZiB0aGUgZGV2aWNlIGlzIG5vdCBwcm90ZWN0ZWQgYnkgdGhl
IElPTU1VIHRoZW4gaXQgd2lsbCByZXR1cm4NCj4gYW4gZXJyb3IuDQoNCklJUkMgdGhlcmUgd2Fz
IGEgY2hhbmdlLCB0aGF0IGFsbG93ZWQgdG8gYXNzaWduIGRldmljZSB3aXRob3V0IGEgSU9NTVUu
IEF0DQpsZWFzdCB3ZSBkaXNjdXNzZWQgdGhpcyBpbnRlcm5hbGx5Lg0KDQo+DQo+IE5vdywgd2l0
aCB5b3VyIGFwcHJvYWNoIHdlIG1heSBoYXZlIGEgZGV2aWNlIHRoYXQgaXMgbm90IHByb3RlY3Rl
ZCBieQ0KPiB0aGUgSU9NTVUgYnV0IHJlcXVpcmUgdG8gYSBTQ01JIGNvbmZpZ3VyYXRpb24uDQoN
CllvdSBuZWVkIHRvIHByb3RlY3Qgb25seSBETUEtY2FwYWJsZSBkZXZpY2VzLg0KDQo+IEkgZG9u
J3QgdGhpbmsgaXQgd291bGQgYmUgc2Vuc2libGUgdG8ganVzdCByZXR1cm4gInN1Y2NlZWQiIGhl
cmUNCj4gYmVjYXVzZSB0ZWNobmljYWxseSB5b3UgYXJlIGFza2luZyB0byBhc3NpZ24gYSBub24t
cHJvdGVjdGVkDQo+IGRldmljZS4gQnV0IGF0IHRoZSBzYW1lIHRpbWUsIGl0IHdvdWxkIHByZXZl
bnQgYSB1c2VyIHRvIGFzc2lnbiBhDQo+IG5vbi1ETUEgY2FwYWJsZSBkZXZpY2UuDQo+DQo+IFNv
IGhvdyBkbyB5b3Ugc3VnZ2VzdCB0byBhcHByb2FjaCB0aGlzPw0KDQpXZWxsLCBpbiBteSBoZWFk
IGFzc2lnbl9kZXZpY2UgaWRlYWxseSBzaG91bGQgZG8gdGhlIGZvbGxvd2luZzoNCg0KMS4gQXNz
aWduIElPTU1VIGlmIGl0IGlzIGNvbmZpZ3VyZWQgZm9yIHRoZSBkZXZpY2UNCjIuIEFzc2lnbiBT
Q01JIGFjY2VzcyByaWdodHMNCihOb3QgcmVsYXRlZCB0byB0aGlzIHBhdGNoIHNlcmllcywgYnV0
Li4uKQ0KMy4gQXNzaWduIElSUXMNCjQuIEFzc2lnbiBJTyBtZW1vcnkgcmFuZ2VzLg0KDQpQb2lu
dHMgMy4gYW5kIDQuIHdvdWxkIGFsbG93IHVzIHRvIG5vdCBwcm92aWRlIGFkZGl0aW9uYWwgaXJx
PVtdIGFuZA0KaW9tZW09W10gZW50cmllcyBpbiBhIGd1ZXN0IGNvbmZpZy4NCg0KDQotLSANClZv
bG9keW15ciBCYWJjaHVrIGF0IEVQQU0=


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 11:31:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 11:31:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250781.431900 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzpa-0008By-IZ; Wed, 22 Dec 2021 11:30:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250781.431900; Wed, 22 Dec 2021 11:30:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1mzzpa-0008Br-Eh; Wed, 22 Dec 2021 11:30:50 +0000
Received: by outflank-mailman (input) for mailman id 250781;
 Wed, 22 Dec 2021 11:30:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1mzzpZ-0008Bl-8Z
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 11:30:49 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzzpV-0002gr-NI; Wed, 22 Dec 2021 11:30:45 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1mzzpV-0007VR-D7; Wed, 22 Dec 2021 11:30:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=4pYMQj18LVJ2EclVVmicIv6RsQRpjDf5xBhT8x0CiB4=; b=mzdJBQTLO36j6ThSANgCW5yFM8
	W02jPMU0kjCAcCY9THTeFp7+UMp6XeTwDettNJuFd42PJWGvGpT2V/UvR2IczPxCRnyNxhqnh1eOH
	pQ2rvqOlcqtGlaAUBQNeiapajxFmFoFtDEJyU72VK74b2fgqibO3CxP2GCFYsTxNngEM=;
Message-ID: <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org>
Date: Wed, 22 Dec 2021 12:30:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <87lf0cx50o.fsf@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

On 22/12/2021 12:17, Volodymyr Babchuk wrote:
> Julien Grall <julien@xen.org> writes:
>> On 21/12/2021 22:39, Stefano Stabellini wrote:
>>> On Tue, 21 Dec 2021, Anthony PERARD wrote:
>>>> On Fri, Dec 17, 2021 at 12:15:25PM +0000, Oleksii Moisieiev wrote:
>>>>>> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>>>>>>> @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
>>>>>>>     {
>>>>>>>         AO_GC;
>>>>>>>         libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
>>>>>>> -    int i, rc = 0;
>>>>>>> +    int i, rc = 0, rc_sci = 0;
>>>>>>>         for (i = 0; i < d_config->num_dtdevs; i++) {
>>>>>>>             const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
>>>>>>>             LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
>>>>>>>             rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
>>>>>>> -        if (rc < 0) {
>>>>>>> -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
>>>>>>> +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
>>>>>>> +
>>>>>>> +        if ((rc < 0) && (rc_sci < 0)) {
>>>>>>> +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
>>>>>>> +                 "xc_domain_add_sci_device failed: %d",
>>>>>>> +                 rc, rc_sci);
>>>>>>>                 goto out;
>>>>>>>             }
>>>>>>> +
>>>>>>> +        if (rc)
>>>>>>> +            rc = rc_sci;
>>>>>>
>>>>>>
>>>>>> If I get this code right, it sounds like the dom.cfg's dtdev property is
>>>>>> reused to describe sci devices as well, but the libxl__add_dtdevs() does not
>>>>>> (and can not) differentiate them. So it has no option but to send two
>>>>>> domctls for each device in dtdevs[] hoping to at least one domctl to
>>>>>> succeeded. Or I really missed something?
>>>>>>
>>>>>> It feels to me that:
>>>>>>    - either new dom.cfg's property could be introduced (scidev?) to describe
>>>>>> sci devices together with new parsing logic/management code, so you will end
>>>>>> up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
>>>>>> so no mixing things.
>>>>>>    - or indeed dtdev logic could be *completely* reused including extending
>>>>>> XEN_DOMCTL_assign_device to cover your use-case, although sounds generic, it
>>>>>> is used to describe devices for the passthrough (to configure an IOMMU for
>>>>>> the device), in that case you wouldn't need an extra
>>>>>> XEN_DOMCTL_add_sci_device introduced by current patch.
>>> I realize I did my review before reading Oleksandr's comments. I
>>> fully
>>> agree with his feedback. Having seen how difficult is for users to setup
>>> a domU configuration correctly today, I would advise to try to reuse the
>>> existing dtdev property instead of adding yet one new property to make
>>> the life of our users easier.
>>>
>>>
>>>>>> Personally I would use the first option as I am not sure that second option
>>>>>> is conceptually correct && possible. I would leave this for the maintainers
>>>>>> to clarify.
>>>>>>
>>>>>
>>>>> Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
>>>>> seems not to be conceptually correct. Introducing new dom.cfg property
>>>>> seems to be the only way to avoid extra Domctl calls.
>>>>> I will handle this in v2 if there will be no complains from Maintainers.
>>>>
>>>> I don't know if there will be a complains in v2 or not :-), but using
>>>> something different from dtdev sound good.
>>>>
>>>> If I understand correctly, dtdev seems to be about passing through an
>>>> existing device to a guest, and this new sci device seems to be about having Xen
>>>> "emulating" an sci device which the guest will use. So introducing
>>>> something new (scidev or other name) sounds good.
>>> Users already have to provide 4 properties (dtdev, iomem, irqs,
>>> device_tree) to setup device assignment. I think that making it 5
>>> properties would not be a step forward :-)
>>
>> IIRC, in the past, we discussed to fetch the information directly from
>> the partial device-tree. Maybe this discussion needs to be revived?
>>
>> Although, this is a separate topic from this series.
>>
>>> To me dtdev and XEN_DOMCTL_assign_device are appropriate because
>>> they
>>> signify device assignment of one or more devices. We are not adding any
>>> additional "meaning" to them. It is just that we'll automatically detect
>>> and generate any SCMI configurations based on the list of assigned
>>> devices. Because if SCMI is enabled and a device is assigned to the
>>> guest, then I think we want to add the device to the SCMI list of
>>> devices automatically.
>>
>> I am OK with re-using dtdev/XEN_DOMCTL_assign_device however there is
>> a pitfall with that approach.
>>
>> At the moment, they are only used for device protected by the
>> IOMMU. If the device is not protected by the IOMMU then it will return
>> an error.
> 
> IIRC there was a change, that allowed to assign device without a IOMMU. At
> least we discussed this internally.

I am not aware of any upstream. Do you have a pointer if there is any 
public discussion?

>>
>> Now, with your approach we may have a device that is not protected by
>> the IOMMU but require to a SCMI configuration.
> 
> You need to protect only DMA-capable devices.

Xen doesn't know if the device is DMA-capable or not. So...

> 
>> I don't think it would be sensible to just return "succeed" here
>> because technically you are asking to assign a non-protected
>> device. But at the same time, it would prevent a user to assign a
>> non-DMA capable device.
>>
>> So how do you suggest to approach this?
> 
> Well, in my head assign_device ideally should do the following:
> 
> 1. Assign IOMMU if it is configured for the device

... with this approach you are at the risk to let the user passthrough a 
device that cannot be protected.

> 2. Assign SCMI access rights
> (Not related to this patch series, but...)
> 3. Assign IRQs
> 4. Assign IO memory ranges.
> 
> Points 3. and 4. would allow us to not provide additional irq=[] and
> iomem=[] entries in a guest config.

That could only work if your guest is using the same layout as the host. 
Otherwise, there is a risk it will clash with other parts of the memory 
layout.

Today, guests started via the toolstack is only using a virtual layout, 
so you would first need to add support to use the host memory layout.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:00:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:00:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250786.431911 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00Hw-0003ZK-7M; Wed, 22 Dec 2021 12:00:08 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250786.431911; Wed, 22 Dec 2021 12:00:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00Hw-0003ZC-3p; Wed, 22 Dec 2021 12:00:08 +0000
Received: by outflank-mailman (input) for mailman id 250786;
 Wed, 22 Dec 2021 12:00:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n00Hu-0003Ug-In; Wed, 22 Dec 2021 12:00:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n00Hu-0003HN-Fc; Wed, 22 Dec 2021 12:00:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n00Hu-0000Cl-2J; Wed, 22 Dec 2021 12:00:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n00Hu-000761-1f; Wed, 22 Dec 2021 12:00:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QdBvOC8Q89gKb1dmnJzS+IDLMNgH0bDaGAJZU47/r/A=; b=jUmJzF3aCShHGD4432zzXrxBVt
	JC7DW82bh7fjweRLhQQQiCnQwfw3KJJs7W0QEkaWRtoS+umo5csN/bTOwkKzaC7Jl1ddIAgwstqCz
	AeDNDWpPvw3yYduWflzBaBouUxirZ6++GT8T68uirAM2IDBLC+KU89E3oZkJWv+xYCN0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167510-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167510: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 12:00:06 +0000

flight 167510 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167510/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-rtds   18 guest-start/debian.repeat fail blocked in 167504
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167504
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167504
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167504
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167504
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167504
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167504
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167504
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167504
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167504
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167504
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167504
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167504
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167510  2021-12-22 01:54:22 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:05:54 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:05:54 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250801.431921 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00NM-0004Nb-UH; Wed, 22 Dec 2021 12:05:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250801.431921; Wed, 22 Dec 2021 12:05:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00NM-0004NU-RI; Wed, 22 Dec 2021 12:05:44 +0000
Received: by outflank-mailman (input) for mailman id 250801;
 Wed, 22 Dec 2021 12:05:44 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rzrJ=RH=suse.com=jbeulich@srs-se1.protection.inumbo.net>)
 id 1n00NM-0004NO-2G
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 12:05:44 +0000
Received: from de-smtp-delivery-102.mimecast.com
 (de-smtp-delivery-102.mimecast.com [194.104.111.102])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7c6231ef-631f-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 13:05:42 +0100 (CET)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by
 relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 de-mta-32-4cinuzS4NoORWXwheNViSA-1; Wed, 22 Dec 2021 13:05:40 +0100
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12)
 by AM0PR04MB6628.eurprd04.prod.outlook.com (2603:10a6:208:179::29)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 22 Dec
 2021 12:05:38 +0000
Received: from AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015]) by AM0PR04MB5587.eurprd04.prod.outlook.com
 ([fe80::9959:195e:46a5:d015%7]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 12:05:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7c6231ef-631f-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619;
	t=1640174742;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=HwMcSmV19B1m8QXhRgcO2bQOySSqYOUjEbOWA4hFEsY=;
	b=KY8lyyD0Qb/eZxHMxJHXMJkSJlTSL3/vMT8WhxgMt0F+5mAjRgcMiGkYbrDC8RpbNxTgzd
	RwVs4YxJPfiLvBU0gfWqVYfTiiXDBIFzsZVI+UFfq4bStBy7o7qW/D+8+tNX+wBUiNyQJf
	3mplsvxYLTC91A5uw8l2bW/KrDgWw5w=
X-MC-Unique: 4cinuzS4NoORWXwheNViSA-1
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Npvo6ZGaa7AyRK9etBy6cipXdNxASv9DWem8r3o3gm5d+krc+5MBeJuiXYCkXf68IT/dPLwHu0K7gaN0wlib56RkLKvXjVWewCBBTqTVLrpmF0jT9gI3wn0x853fg/PUHvAmztbYsKwdI+79tMPSDNl3Sh+2Zc5dFHJZSpekb/tth0+ou0tOc4gvSN+g4WnfuezlFlpwLatxFGJduTHuohxD97IGcVOOleY59xorxkFsDHY5ofKfEOz9uBA51xyYQEV6wZJru+eXoPWrzh1zKOKzkFJE0lN3dZcCrGDogrjq6X5VAp1EdnCi2V3mJSQn/Z1pTb6msFWODoAG4bSKGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=HwMcSmV19B1m8QXhRgcO2bQOySSqYOUjEbOWA4hFEsY=;
 b=UkydPoGY5vuEht/MtW3orMoyFfg4NGiVy/BcJvMqlRcAhnU8LV1YkDX/ABSAyTWIuz/QQr7Ebo9WHv/iSAwultezJElDmQtVjF973X2SgW4vmPJA0kig3icPZTkU0jvtYfmkXdB3CD2iaazb4SBpmRnpXLoYdpDRaJx8KjdXIGdsWvExIk1sQ89BxUrUOysUqFbrXEYxCZ2XAnTu8bn9Mr+vz8OUU2X6ibk+Dxct9cLvZASDQJoZaE8ak0baJHuaZULz/2FvusRrfF1yVuTuYLFr0wbk7lom6FO6zwCINoxKigDL85pcpCq425ewFjAVX9TfFGjWV63bUzDdfWtZaA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com;
 dkim=pass header.d=suse.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=suse.com;
Message-ID: <57616176-938b-2125-fe34-4fadf2b4f816@suse.com>
Date: Wed, 22 Dec 2021 13:05:36 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
Content-Language: en-US
To: Julien Grall <julien@xen.org>, Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
 <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AS8PR04CA0069.eurprd04.prod.outlook.com
 (2603:10a6:20b:313::14) To AM0PR04MB5587.eurprd04.prod.outlook.com
 (2603:10a6:208:125::12)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: aeb5f5a8-cc85-429f-cf42-08d9c5435e19
X-MS-TrafficTypeDiagnostic: AM0PR04MB6628:EE_
X-Microsoft-Antispam-PRVS:
	<AM0PR04MB662801EC06D345DB8A0C41BCB37D9@AM0PR04MB6628.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	1/R3eDmHTKUab+Z/Qzv7saGRFMbKKKp8tJ9+rjCzlB97515UxrvS/XaJIjWBZTkwA00WgFocVePxG1UwNz88Ous3Ixg2C4VktDdsUVp7HNDA9NmxH1l59L3K6qtb2aYLE7Puj3F65IQr44rAGlYY+84Ay0J3pD6B1ADb+a1Xmz+CJebagZXTAUrrHuNiRkDfL6cgG32qldR+lEjZabFwScq5unb3CnG3nwKeCNJq+MjLikQxC5Q/jxjvuk4bJJCElu4fZge4xQVcuVJwt+M0lh7P1NTxhd+3zCEPKJigxpRYcarlZEQ5GGkMNXfLyPeg6VZMzEE5WwD/zZGkKN7F6oTrRPa0tVGchzEz0ZEWuDqvm9MAs2ukw0LgQ/xiUHSFY2mQZHxfOUFFJMCaLuAqtmfVkXTGYYVNRHTXx7+P/YmJFKKWf8eAaZ0E/8s5r2eTrYletUblPr1j8lIqNj05O9qdV3w3v7hc3fTXr8JK1NO+Xzmpf4/y/7jeU70k1ogt22kli52BakU3F/vHP/5a/ebOY3HkG2gyrQKYz6my0xs+zidvhhCM79nuLyzO01oEl7sAygb772/0Ple0+2H/+yHSi03Ig6wXC1CjacM5ejFZQMQESXKwn7bn6RGa5lW0wJajSMGRdM37q5+8vcNX5wecmdBv3TwLOT4wNCVqUc1m8BbWvBoRlTAX2HPNyPwSWOFvICMfwhWP5btEERXBuJWksZujbn3jTQrqbIVabWQ=
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(86362001)(31686004)(5660300002)(83380400001)(66946007)(36756003)(38100700002)(54906003)(66476007)(66556008)(6512007)(6486002)(26005)(4326008)(53546011)(2906002)(110136005)(508600001)(6506007)(8676002)(8936002)(186003)(31696002)(316002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N0RLQ09BamZvNkoxcUptczNJZXlWUWhTcjUweGl1V0Z6ZTFwNlpKK0VsNEN5?=
 =?utf-8?B?Y2hYcnVHU1JhcHROTDkxUU9mYWw3Vks0V3FiT2E5MklVWkdoYzdCRDB2dE5H?=
 =?utf-8?B?YjZmTFRicldEVkgxb2VFQXZza0c3dEFKa3lLN1JlV2NyRFR2Tys2VFdTSEJI?=
 =?utf-8?B?MGJDZ3o3bEt1UWFhcU91RzlINHk3anFVUGZwak5OVUpYanREM3VBejdkdzBT?=
 =?utf-8?B?WUZHczY5NGd4R1BZVHpoalhvRXZUcS9RbDd1WmgvWnpacU55L2V6bXFsZTJu?=
 =?utf-8?B?ditPblNaejZtcGplK3hTck40ekdVN0toRjVkU1VJclJDR3pKdjZZdkpua0Rj?=
 =?utf-8?B?OTZYUzdreTNQOWY4NUI0OVV4VlFuNmNRQzUydlBUdjgrR2ZEdkRFNkNISE1X?=
 =?utf-8?B?WnFib0JIODFlQW9ROCtObVhSZktIRDFzaVdWZDNURlRkNCtYSldWWE05eU54?=
 =?utf-8?B?QmxGbXlOUmxabGhnTjhCWTlCZVYvajhxSXM2Ty9aYnRjYzNrb0JVRzh6bGZ6?=
 =?utf-8?B?U1daTWxRRnExY2xQenJlcnlBanRJTDVFQytoa01XLzIvUFVKSnFodFVzR3Ju?=
 =?utf-8?B?TlNHWXNhSEEzMTZhbGd0SGUydkhERkZiOXpZbEcrZEZNUnpmUjlpRjJSWnk0?=
 =?utf-8?B?bFRHek0ySXdOdzNBdGhnSjBwdzRFRndzUkx2UWZYSVllK0M5MWhTcCtYSDNk?=
 =?utf-8?B?TlBDY1FjWnNNYmZkWkU3Z2E0VS9oNHhhSExrcVAwbXJETndMdDF0aG91R1Bk?=
 =?utf-8?B?cDVoWHZhemYvTmowSW96M3pYZGZUdXNyWkszRzcyWHVWQXZYcmRZcDlFc1p0?=
 =?utf-8?B?d2JlUXUvNjcvYXU2L0VaY1kybnphNlZDOE5wdC9vbVpvbUYxWmlZcmhwRlNo?=
 =?utf-8?B?bjY2NWpzdllsVU1sNmQ0M1JyZ0E2WGxYTVZRN2Rzb0ZySUJ1eUFkREJrY3pF?=
 =?utf-8?B?Y0ZlaElzckVLYXhPUkd0dE4vdFJqMDFjc2ZQSm15RUFIL0tRa29MdFc5OU9O?=
 =?utf-8?B?TlN3UjdWNlRMYW85ZEFhdVlmRllmWTFzc05QTDdCTXZtbzFEU1dUZTFPbzR4?=
 =?utf-8?B?VlBsZUpWZENQUVNqTG4rR0ZwaHlNRHV4YnZEbEZVdlpRREJjMmNjbVUydTV3?=
 =?utf-8?B?VzdsTW5ZQkJzSmNSYTgxYUVBM0FwZEtTTnpCL01ZeWZWSmVkdzdRc21TK3Nk?=
 =?utf-8?B?YVlVSksxdDcwQ2ovQjY5eFRPeG9jc05saE0veWtRS1dYVkZEN0dOVy9ndnBa?=
 =?utf-8?B?Qy9FM09EWTd5Tm5MZTZIYzBJK0FtZk16ME1CbHhmNVI4TlF0MlhRcmZYaFpH?=
 =?utf-8?B?RXdnVGxSamVZRWhYMlVGNEpJVDhCMmlGYmg5M2Q4RHpTd21EdWZmT3FkNW82?=
 =?utf-8?B?UTAvVFBXbENYTjZEQjltdWVSSVZEUXF5WDNTY3YzOG1BUFBoNi9iY0JNQkZs?=
 =?utf-8?B?aHNpNHNvYURlSUJJLzRSd3U5R3ZqOGJVZHhMM3ExWXFISmlyY1pXc0VCSlFj?=
 =?utf-8?B?RzhGSjZuQlR1T2t1RnVac01IcXdaNnBjNVdFZjFSTXRMdzRxVG5GeVpzbGVE?=
 =?utf-8?B?V1g0dTZUOVU3eUxLQzM4YmZDd3hUOGhBQkNpSXY0YXhVaHVZT3VMT1F6SS8x?=
 =?utf-8?B?dmRQYkNsNWdGQW1xZnBsQVJHTEtYR0hxQUk5S0pMZTJwOHNUY0ZFcjVjUGt2?=
 =?utf-8?B?d0IvZTBpN1JuYmxWUi9iVlltRk9ZbUUwbTB2VzdFSzR0Um9Ld3Z1alA0Qm15?=
 =?utf-8?B?T1lWbHNQd0NGZWJ2OUdoRlB2M2ZWMHE0dFhWcXJBcXhhRjZVMHZrbGMxMExx?=
 =?utf-8?B?RTV5NFVHK2JWVFgxeWZoWGV5eEJtVmFaL1h0RGhRZlp2cVdkOXNES1R4NVZt?=
 =?utf-8?B?cDRMMm9xTkJHMjhMREd0WWFIMVY1OGRUQ1BCdGJzdXNhNTFLc293S0NJbXRs?=
 =?utf-8?B?VnNkeERaR0tnZ1lnaVRhd0Z4cHBNenBVdXp2aFNUdzNGOHpLTVFqTHFSSmpy?=
 =?utf-8?B?Ymx4WTU5NXY2aFFEZEFXN3U3eEpqNG1pcWU3Y3RPR0lBZDUyVEpyRkVnUnhM?=
 =?utf-8?B?WFRpQnM3NXhpWTRRZGxpRzFJTnkxUXFmdWRYMGxBdThJWnR3TlhkeWhyaFFu?=
 =?utf-8?B?alQ0SE5HQzhNT0JhMVhwK2dMS21raGJOQ2t4OXVMNVhDTXZ0Z1IyQVdLMnM0?=
 =?utf-8?Q?7CHg8N0dp5xmqXI1y6TSxv0=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeb5f5a8-cc85-429f-cf42-08d9c5435e19
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2021 12:05:38.6865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: alcTZe3DSckl7oY1hfBWu26/+PbmTGNcZ+jNqZbNTnUAdPbkIYnKlj2J2XO7yokbjAMiKI70dQmRgpyhebXemg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6628

On 22.12.2021 11:01, Julien Grall wrote:
> On 14/12/2021 17:45, Jan Beulich wrote:
>> On 14.12.2021 17:26, Oleksandr wrote:
>>> On 14.12.21 15:37, Jan Beulich wrote:
>>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>>>>    
>>>>>    void free_xenheap_pages(void *v, unsigned int order)
>>>>>    {
>>>>> +    struct page_info *pg;
>>>>> +    unsigned int i;
>>>>> +
>>>>>        ASSERT(!in_irq());
>>>>>    
>>>>>        if ( v == NULL )
>>>>>            return;
>>>>>    
>>>>> +    pg = virt_to_page(v);
>>>>> +
>>>>>        memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>>> ... this really want to (logically) move into the new arch hooks.
>>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>>> notice there's some dead code there on x86, which I guess I'll make
>>>> a patch to clean up). But first of all this suggests that you want
>>>> to call the hooks with base page and order, putting the loops there.
>>>
>>> I see your point and agree ... However I see the on-list patches that
>>> remove common memguard_* invocations and x86 bits.
>>> So I assume, this request is not actual anymore, or I still need to pass
>>> an order to new arch hooks? Please clarify.
>>
>> Well, that patch (really just the Arm one) effectively takes care of
>> part of what I did say above. Irrespective I continue to think that
>> the hook should take a (page,order) tuple instead of getting invoked
>> once for every order-0 page. And the hook invocations should be placed
>> such that they could fulfill the (being removed) memguard function
>> (iirc that was already the case, at least mostly).
> 
> IIUC your suggestion, with your approach, alloc_xenheap_pages() would 
> look like:
> 
>       for ( i = 0; i < (1u << order); i++ )
>           pg[i].count_info |= PGC_xen_heap;
> 
>       arch_alloc_xenheap_pages(pg, 1U << order);

Like Oleksandr said, the 2nd argument would be just "order".

> The Arm implementation for arch_alloc_xenheap_pages() would also contain 
> a loop.
> 
> This could turn out to be quite expensive with large allocation (1GB 
> allocation would require 16MB of cache) because the cache may not have 
> enough space contain all the pages of that range. So you would have to 
> pull twice the page_info in the cache.

Hmm, that's a fair point. I assume you realize that a similar issue of
higher overhead would occur when using your approach, and when some
memguard-like thing was to reappear: Such mapping operations typically
are more efficient when done on a larger range. Since that's only a
hypothetical use at this point, I'm willing to accept your preference.
I'd like us to consider one more aspect though: All you need on Arm is
the setting of the exact same bits to the exact same pattern for every
struct page_info involved. Can't we simply have an arch hook returning
that pattern, for generic code to then OR it in alongside PGC_xen_heap?

Jan



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:21:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:21:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250807.431933 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00c4-00074U-9C; Wed, 22 Dec 2021 12:20:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250807.431933; Wed, 22 Dec 2021 12:20:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00c4-00074N-61; Wed, 22 Dec 2021 12:20:56 +0000
Received: by outflank-mailman (input) for mailman id 250807;
 Wed, 22 Dec 2021 12:20:55 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2rHP=RH=epam.com=prvs=2990e6cae6=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n00c3-00074H-99
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 12:20:55 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9acd701f-6321-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 13:20:53 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BMC3IXm009812;
 Wed, 22 Dec 2021 12:20:51 GMT
Received: from eur05-db8-obe.outbound.protection.outlook.com
 (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d43avr47g-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 12:20:51 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB6989.eurprd03.prod.outlook.com (2603:10a6:102:e6::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Wed, 22 Dec
 2021 12:20:48 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 12:20:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9acd701f-6321-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=QD7MDclPqe3pgAsCvSKBoDq0YKjJFPEewEiZDZu2sw1SGOLIb+dMPFzLZOjgyk/7XLS1YAxLlHlllKLziro+ajDFskR3FnelLpS3NoW0ZQ5Glbq3q2uPUY1imJyEr4l778BkatJDgih9pM+v6UIN/d4hPCTFv9uFbJeoqO4TUe8/dAj34Xmjp+CxrUkCH7D0XYrjgkVAzXu+Ca2tkd869j0lzYg6kxVzO8Mq+0W7DmIBmmNpv7/kkm6eDvj+bWbxNMrNCO/noFLbkXAXXrTMBeVUzP8Ibh8Y7+f2vcqMPwQVlM+RBZaKO2p+/7Tu1gvNDtyZqjNlhJ2/AnZu3eKOgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=5sQtXmss7+JD4k3X/wDoVr1jBwUqb1d3ZzH89G0Cnc0=;
 b=nsaYm2dCuGC5XsFXUVIBcnS5Mae+3QYMeza3lwI7diC7Ocg8/tgmonTSfSpdnGSHiCQ6hY2ljRQSSfEnRhVGrf5fNPZcEVfCW16sa83aQ6ADUQDAwg5VhyBL0jcAmzmV3zG625fxdGpfmU0wtW90VrFcTKYRqgWOOQetT/WXnrA2rPVhGlFNgPHuImsm+8xhXrLMj7+x51wKJITNcshbpelkN5eCdrIVCSWNNwb1FzNy2z1qHIdofBthZPagnD6xVoH/WzbDPwfhy8YU9XQSBRne3U1hkP9gE8uWyaFWNc2bkKrqQyvWh7d5nCjL0u6J1g4SMjY8jp+kXlY1q0KIOg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=5sQtXmss7+JD4k3X/wDoVr1jBwUqb1d3ZzH89G0Cnc0=;
 b=AlGCX/2ar3PparnVubJGQ7z5Pp7uNF+TTYhRmfquCkTs5rn7p+vsy06t/Y1cCSRU6T8BsU0fymsfPudyzbsK+8SJl8BKXo/RNgo4WdnL38S+gKsEF+eL2+l9Hi/duFjh73uiHklAh5Pk4yHcyHU9zRfCq7TQvCuvW0uUaNas/VztAYDWzlMe0lCHMaSOi/0wdvAuyfXjW7/d4B0HFhzbcXxiYvc+hDdEVlcRE2mEW380WVTjn2QjJdSlZ4f3AG5D0Y2to/JeQu5mP06FXG48ODWpR4Lj1UzUFLdbJiZSgKwMiqxl7xUzvj2+MrakPbFc7n30FHVZzpbQT4g3jBfVeQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Anthony PERARD <anthony.perard@citrix.com>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owqw8+0+AgAF/xgA=
Date: Wed, 22 Dec 2021 12:20:46 +0000
Message-ID: <20211222122046.GA2926395@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
 <YcHWL7S+O8txY8Eq@perard>
In-Reply-To: <YcHWL7S+O8txY8Eq@perard>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 78595a9f-0994-4749-f06c-08d9c5457be0
x-ms-traffictypediagnostic: PA4PR03MB6989:EE_
x-microsoft-antispam-prvs: 
 <PA4PR03MB6989A77F3845BC9A20087127E37D9@PA4PR03MB6989.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 CR20Lm9gyUegoDvUXfVhXKJvpW920fnYzsUMEcu2aZZVRWt6y4RqRnrX30d6AJ39uCc9gLM870cVP0rLzPjf/XqE9Ux7XVxOy6V6wgzz8Vgo12kopxH+cMhrqA4zj6/vH9Xmlr87rGp8sKsXT+Fkdetwo/bRbtFZQcEu6Ppqf5mvzcOCXk+Wq0AMqccoEy/UiO8QvXRdtjrGXU4GUJ+6nUwWoD7GKpOUV0B41PrWDCwofEZxHteP0FNlPXoWT6jqjRqKkjl5ubKfJ/ptGRy/YnMjdPg5Ii9HZCXqjC7xcAruxapzC693wDpyOlFYHCWU/W2WkMX3Mv4n7w8ltZx0oYf3Rsid0VnfZ0fbTxQs9p+39QsO97R6XMQn4I8mj+Xb5hlRIjai+6Jrb0SGr0i/P2beq3OFrOXngq1INKeZJyn/Xr3mXTbjh6gDEDl4N+SmBLrnf0pH9X6OyTLsJa5Zc9nBvd3Clheojp6PCyhMQl5yvzcf0SL8eWZ17dUiqp2P3QBhADuyYHj07KhLQmnuL8tH74xcjTGvlbgR3hfENugtehzqVbLxpY7WLlUQ+BtmMaCFtC+/teRre4uciuI8BG7M6+UeC+AmeXxJHOGpbEkmujzXStu3rBanVfuff7GssRtNd4Z8dZViHygW+G7oZHyk0dkkQo22DaALbZHu2OBLUVNecaRtGnIseyca2bcaWKpUpmptCNQGFGF8exWngA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66556008)(66476007)(38100700002)(86362001)(64756008)(4326008)(186003)(66946007)(91956017)(66446008)(26005)(33656002)(33716001)(508600001)(6916009)(76116006)(122000001)(38070700005)(54906003)(2906002)(1076003)(8676002)(8936002)(6512007)(9686003)(6486002)(316002)(71200400001)(83380400001)(6506007)(5660300002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?SKW1ZzbgqxC/3YJPsM5UleTHXW/ojU68D5EiLNTm37s+6q3vI+mmxVEtR6Qw?=
 =?us-ascii?Q?I90Pb21WiE48LB5+3ci40Awep3d6VNGUg8WePYMCA4uvX8CIsKElr6GwH0TY?=
 =?us-ascii?Q?GEdd+zi6XD+garKtDe5Uc0ESjdvKbVweCB2f3wI3MT2y8wHJb4gyK72aetIg?=
 =?us-ascii?Q?IOcgl2VArhbxlKk+wg2FDLQv0iqo4itEPiX0E7Zdn8T8VGKFtBmhO/j9a+o7?=
 =?us-ascii?Q?NOPvUsNSKU0QqlPdueuaRYSd7iUXSZwAdqEiCptanybLavHj0vR5IT/a/jQC?=
 =?us-ascii?Q?VSvU00Irl4Ve+0DBDG5vGCHkeJDaKJhY/9dyITdlIkNpYt6ndb9aFtjyijqU?=
 =?us-ascii?Q?pT3D6PxESbYiVwc94HkTEbg9KQZ2f8TCuBPH3ELd+DviiWW0vei2o+p+q3g3?=
 =?us-ascii?Q?cYERifPypM7CUOKlTjYiq65bNi9T1Tpiz6s1/0PVSVXNwj5TmKe+wc9TOgtw?=
 =?us-ascii?Q?z0QvPvIhXSSSGJmGGuxSRsMLxRAxOR4q/zM8H4wgCg48rK56+esZg4jcoBiD?=
 =?us-ascii?Q?ndpU7QaLMBWuafDxi5z+2BoomC8O4wermrlhhF4Nc4kL4CRhznteIzAX/ct7?=
 =?us-ascii?Q?2YF8N0zEN07W5pi34frN4hNMgX9rRhYsekS6q572PWFXfnRVeVXZi5tEBZsA?=
 =?us-ascii?Q?CREo6Nj7mLFain+OjglvJZJ2KDAYIfJNkkJNCNgf7Y9BJUfGRUR78XHhRwmY?=
 =?us-ascii?Q?0IFrDxQlJCYSrEd3WCr0/AoIyqqiBq5kJldxQDvyL07vdya6mU9crFU4uD8u?=
 =?us-ascii?Q?NXAIq243RVe3IE0JAFJUpwQ1wK5sAhr7dOrmp3pMt1qoaoIMhtL48emuZvy0?=
 =?us-ascii?Q?JdMWfoiU0MJ0QYXk4F4kghmIADYpR6YwqIUNZBSRGsoSeBLnPvhLvygOLYIa?=
 =?us-ascii?Q?w0XrveOVXWt+kQF+efUnrxkk1YIqqSRlqwoI96DF/mS+xgZO9dv6sUNRrfcu?=
 =?us-ascii?Q?MfsA8bBMT7h2kx4mv4t2/487t86783YJAhYiFN3nMbWXHk+VMOguUt5GqKrj?=
 =?us-ascii?Q?SGj+Bq6j3cyBht3Gn/9ked6nJMDWhOGf+oX7GmMMSVK+ba6CG7j4edM/dOpp?=
 =?us-ascii?Q?sVjvxaggHz7W8LVjtqeZf5wsovQ9YWxO9k7zSogfPnFDh9NF56WA0SpnvPCR?=
 =?us-ascii?Q?kxUlXcqqV0alIjeY4NnwpxpWeh1d8r8ePMv2DK4BlQBKdf67ueASyB10LzQy?=
 =?us-ascii?Q?mJfcCZZHAsTByZ12xXF8CcACjLNxHO7mYoPoDx4fOoGAapvbVne/JHPGo2tF?=
 =?us-ascii?Q?vbG3p7Uqe5JOYBvIntWSlu5EisZaQbjMxFuGj+f1Ke0tGaeIM45D473RVn74?=
 =?us-ascii?Q?Y1EwEEoJdU3PYLjBc829OX/0OLdyUYAIt+yJh6PXlfvU6nCFGv7q5vR+SrDG?=
 =?us-ascii?Q?LnWW/0LzmYhjAIGkD7aksu9ufty95ef+X1ZmPmSUz7zN9Ov0O3ZE5z9bqv0G?=
 =?us-ascii?Q?f+aYt6xL4hAIQLhUI6P3rQRm7b1m/r0r2PYLs3Yxjem70sMg/ugqzYk0XXVz?=
 =?us-ascii?Q?rjMDdZSPtlvZ1hAngatvH0/lVMDaqKCFe1TpDrKvrQEu/6SX+zOTJOavRW/M?=
 =?us-ascii?Q?WMcMveuTeIGSYHw7fle3uA1uvfGQWzPtCnl6J1imJiu9HJsU+QQ60818M3Ef?=
 =?us-ascii?Q?awvSlK75C4dWtR7lgWKUhJ1TQ7MLkq2Trt/jAMDzd+VIm88Y6mtFMwijkk3f?=
 =?us-ascii?Q?cdNUJWEuAp0vFzrr+DOxLhsqTj0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <567462F1041A404FBE1D6859E8F40AA1@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78595a9f-0994-4749-f06c-08d9c5457be0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 12:20:47.0765
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FFoloI4O5IHmP0mstD4gSH+FHSCu9NAzgv9pyH88pBBcGF9wbyFxRMsvDDRu9k4CaaDKpMaTjLlbTVtFsJzMRT5TXvARDMWtXbg79dH7GMM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6989
X-Proofpoint-ORIG-GUID: J3HXc2kFtLQCUneD2lJ_1wDaVWA4pVrG
X-Proofpoint-GUID: J3HXc2kFtLQCUneD2lJ_1wDaVWA4pVrG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_05,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0
 malwarescore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0
 suspectscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 impostorscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112220069


On Tue, Dec 21, 2021 at 01:27:11PM +0000, Anthony PERARD wrote:
> On Tue, Dec 14, 2021 at 09:34:28AM +0000, Oleksii Moisieiev wrote:
> > This enumeration sets SCI type for the domain. Currently there is
> > two possible options: either 'none' or 'scmi_smc'.
> >=20
> > 'none' is the default value and it disables SCI support at all.
> >=20
> > 'scmi_smc' enables access to the Firmware from the domains using SCMI
> > protocol and SMC as transport.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
>=20
> Thanks for the patch, it looks good too me.
>=20
> But it is kind of weird that the manual describes something that isn't
> implemented yet. Could you maybe add in the patch description that the
> feature isn't implemented yet or that the feature is implemented in
> follow-up patches?
>=20
> Also, about the golang binding thingy, could you add a note after a line
> of a three dash "---" that let know the committer to regenerate
> everything that needs re-generating due to change in the *.idl file,
> just in case?
>=20

Hi Anthony,
I will add golang bindings in v2.
As for the scmi_smc description - is sounds reasonable. I will refactor
it in v2.=


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:34:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:34:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250811.431943 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00oh-0000JR-Fc; Wed, 22 Dec 2021 12:33:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250811.431943; Wed, 22 Dec 2021 12:33:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00oh-0000JK-CM; Wed, 22 Dec 2021 12:33:59 +0000
Received: by outflank-mailman (input) for mailman id 250811;
 Wed, 22 Dec 2021 12:33:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n00of-0000JE-JD
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 12:33:57 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n00oZ-0003pY-Fj; Wed, 22 Dec 2021 12:33:51 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n00oZ-00036O-5i; Wed, 22 Dec 2021 12:33:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=pDuodeardkQpgNDwC8w8FujoGgQZpXVIYLJEVzcBo+E=; b=r3I9OgAhaEW/uXTmoXXXxbTONw
	6F+0a7oofbJU1wEtrtqWV7LmmyeTr8pq6/BU8rr2s7ylv8n7NEIFuBFBuxJmThgVI7TN1gcrN3MKp
	uXN8pV7kRRzpbIqGC1veFcsJsLZMNxGGKOhFJ/ZiF2Si1+X2lNgA+KE9zRcUux0QKjzg=;
Message-ID: <74a0ca4a-b091-77e6-ddb4-490d2a0a0f4b@xen.org>
Date: Wed, 22 Dec 2021 13:33:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Jan Beulich <jbeulich@suse.com>, Oleksandr <olekstysh@gmail.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
 <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
 <57616176-938b-2125-fe34-4fadf2b4f816@suse.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <57616176-938b-2125-fe34-4fadf2b4f816@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Jan,

On 22/12/2021 13:05, Jan Beulich wrote:
> On 22.12.2021 11:01, Julien Grall wrote:
>> On 14/12/2021 17:45, Jan Beulich wrote:
>>> On 14.12.2021 17:26, Oleksandr wrote:
>>>> On 14.12.21 15:37, Jan Beulich wrote:
>>>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int order, unsigned int memflags)
>>>>>>     
>>>>>>     void free_xenheap_pages(void *v, unsigned int order)
>>>>>>     {
>>>>>> +    struct page_info *pg;
>>>>>> +    unsigned int i;
>>>>>> +
>>>>>>         ASSERT(!in_irq());
>>>>>>     
>>>>>>         if ( v == NULL )
>>>>>>             return;
>>>>>>     
>>>>>> +    pg = virt_to_page(v);
>>>>>> +
>>>>>>         memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>>>> ... this really want to (logically) move into the new arch hooks.
>>>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>>>> notice there's some dead code there on x86, which I guess I'll make
>>>>> a patch to clean up). But first of all this suggests that you want
>>>>> to call the hooks with base page and order, putting the loops there.
>>>>
>>>> I see your point and agree ... However I see the on-list patches that
>>>> remove common memguard_* invocations and x86 bits.
>>>> So I assume, this request is not actual anymore, or I still need to pass
>>>> an order to new arch hooks? Please clarify.
>>>
>>> Well, that patch (really just the Arm one) effectively takes care of
>>> part of what I did say above. Irrespective I continue to think that
>>> the hook should take a (page,order) tuple instead of getting invoked
>>> once for every order-0 page. And the hook invocations should be placed
>>> such that they could fulfill the (being removed) memguard function
>>> (iirc that was already the case, at least mostly).
>>
>> IIUC your suggestion, with your approach, alloc_xenheap_pages() would
>> look like:
>>
>>        for ( i = 0; i < (1u << order); i++ )
>>            pg[i].count_info |= PGC_xen_heap;
>>
>>        arch_alloc_xenheap_pages(pg, 1U << order);
> 
> Like Oleksandr said, the 2nd argument would be just "order".
> 
>> The Arm implementation for arch_alloc_xenheap_pages() would also contain
>> a loop.
>>
>> This could turn out to be quite expensive with large allocation (1GB
>> allocation would require 16MB of cache) because the cache may not have
>> enough space contain all the pages of that range. So you would have to
>> pull twice the page_info in the cache.
> 
> Hmm, that's a fair point. I assume you realize that a similar issue of
> higher overhead would occur when using your approach, and when some
> memguard-like thing was to reappear: Such mapping operations typically
> are more efficient when done on a larger range.

Yes, I was aware of that when I wrote my message. However, they are not 
necessary at the moment. So I think we can defer the discussion.

>  Since that's only a
> hypothetical use at this point, I'm willing to accept your preference.
> I'd like us to consider one more aspect though: All you need on Arm is
> the setting of the exact same bits to the exact same pattern for every
> struct page_info involved. Can't we simply have an arch hook returning
> that pattern, for generic code to then OR it in alongside PGC_xen_heap?

arch_alloc_xenheap_pages() will modify inuse.type_info so we can't or 
the value to PGC_xen_heap.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:34:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:34:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250812.431955 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00oz-0000jI-Nc; Wed, 22 Dec 2021 12:34:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250812.431955; Wed, 22 Dec 2021 12:34:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00oz-0000jB-KW; Wed, 22 Dec 2021 12:34:17 +0000
Received: by outflank-mailman (input) for mailman id 250812;
 Wed, 22 Dec 2021 12:34:15 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=nRTG=RH=epam.com=prvs=29901831a2=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1n00ox-0000gJ-N4
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 12:34:15 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 77fa5aa9-6323-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 13:34:14 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BMBuIW1029535;
 Wed, 22 Dec 2021 12:34:08 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d42cg8df7-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 12:34:08 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB8084.eurprd03.prod.outlook.com (2603:10a6:102:223::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Wed, 22 Dec
 2021 12:34:05 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%6]) with mapi id 15.20.4823.018; Wed, 22 Dec 2021
 12:34:05 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 77fa5aa9-6323-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BgzNASCzHrXbmWru/kzmePPg628VpEbTOyH0ue4DRPcGR5XdWc61ju6hI8DvcyGA/OWLwjiTR3rau0IRxY81l3WGSdJ8ibKdCTIgc/AWHJrfKaceXjBfdym7Su97J41KL6hLd9u0UFiuJ9+XuPMYr1sLzOVGLO/tIDgSvS26GDRAj25/q6yXd6xm1XpngrlB7K6gsg+sTkGmB7SWpVGCGzXaFf5bpJ78I0xD6DuIwxOjjMrPnPXYjhcRciyGlJtM/KFQ/uGGTm8fxt8ThYo/me8jLClnpWLll8bzymuu1vDoT26yn6UrkEd9Ad9GkY+d5DLUj6rOmZ25RSqEkbNzfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=LzWaDTH8bnvmgvfKbi45wbovi24gKodr03kYy2JAS34=;
 b=lV3kB38u0WLMDzszGpLr2KQhOvdURg0pYiUkyRsuxFdCvAXUbEDFc/0oaPgY8ie6rR2+jJ1HXARuoEUzYW7wCqqDMQOAc8/iLJszqTfj3waSlIXMHyb6WSAXMRIMnWDov53VuqxobzJnS5FAJwzVyf866RgHiLcF6K05QmfBscUzf2ZMtF7kn8Kk0xddhsSGUCujREEVn/CRjiLCtNdF4E32KEeN/HNg8cLivruhw85X17x1DRJhwl6nGVJmyLZqAT0imX5wHUuKh8EBPT9tJl/iIMQHzum++/dGOfauBYzoh1C7VsXRmY+XaRSf5a6b8W2Rm/mYfg8J+Y3EjW5MDA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LzWaDTH8bnvmgvfKbi45wbovi24gKodr03kYy2JAS34=;
 b=o5jm+pT/QQXiufSH/kr7wOF5UBE9xqQdfMwX3/Z20NaEGBVL5TwYxUi69QVC3fUWN+ch+oo7o959RQ90/68aqI4hepTlCiT9aSCZFMKWSXyNoalsk3xdT/TbJ/On6Ru9XSPaLz+CiOaiRbHBYTVMMjCujYyy/GgCs5ByLjrtePlDTHYAZCIZUsj+K1b4ZDDhMwzMaLbGB3aHysU2SakM/iaC5p5doULW2Y1C//DWBOihpxdcfFfcB/+O91nkoSPJhwiFkBRDov3hYz1yKl879fa9JPgiWQkEZhe1IFO4I+tGOHdnJj5ySxowh1VwKOsPzSVafz6jb/wusl4j8xo/wg==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        Anthony PERARD
	<anthony.perard@citrix.com>,
        Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: 
 AQHX8M3LNgat3drmYUW4ty+W1/SkP6w0P2iAgAJeh4CABnNRgIAAc5MAgADFCgCAAB3ugIAABU0AgAAFZQA=
Date: Wed, 22 Dec 2021 12:34:05 +0000
Message-ID: <87ee64x1hf.fsf@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com>
 <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org>
In-Reply-To: <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d6f3df96-ebb9-4464-8f10-08d9c5475782
x-ms-traffictypediagnostic: PAXPR03MB8084:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB808426F72D9C9C631AD4B839E67D9@PAXPR03MB8084.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 Xz4YFB5c1PNcV88B8hCDjfvB6UC9V4bMOaWP5dCh+YpQRWSnsG2jww74jNXKIEbsupYB5xlG+PTQ75qMiIBKdb6N/VL8LI4dcfz5Z08w7bYJAzobN0fUShi6idQOyn+kGxMc7O0tJM4fdC8FiM2T+OlfTBXzeFXF7+igOZ3ZH1ltlQdhu3dWdmQBD4zyalI+qcFlAEeznBy3A/kB4jrjXs2mTOo7WRT1+FkQsZoBBHaTv3ihTzZxKNhqcuwJ73ybpKkn/UPG0Id/dP0cM3p99YSw2K9yvhoLzeW8mnaVMyxroirgm5DWbQHH/DdsWo+oVSg+H5Kp5LmDZa2lZ3kNQa/PFQQ5BjMsK1pN6N+e39MqEZBnlBMKhy8J43x5g6A5IDLtO0iuKfzx9GiZ48w1AzVVTDGSo5NksbLLtb2ZZgGNKRA7N7DqHA/H/M5qeK1U+DODmL3NIbY06Q+3K1fdBAUnjD1n34P4jsPrW7VP/VHsVWiGxy+FyAhfpDWFgMI5OnRG1OwXcGw2yaGksXOqbeYAju0A3HP6ISEIJmGdXsHyvO8ZLspHVwgjVaOC0c4YYBC+CR7XHWf0ykBChvYhU2TbeyN8V4Fjrj7rUytplPiz62yg1eeHLLkB9mca+O42UowRAFkj33+ZxsXD95FCLzaVYCLM3xjHS3Ho8HfClGzbd1Al9LXAMNRuni53KeBsqb0bns34S0+jHlsNXdBJLw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(36756003)(53546011)(86362001)(122000001)(6512007)(54906003)(66476007)(38070700005)(8936002)(55236004)(71200400001)(83380400001)(64756008)(6916009)(66446008)(91956017)(7416002)(6486002)(2616005)(2906002)(8676002)(5660300002)(66946007)(38100700002)(26005)(4326008)(76116006)(6506007)(66556008)(186003)(508600001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?dUdxSUliNkhrRHBXVk1JVFFxV2pZRjJCZGhDamVVWnFOeXg1WnFrNERzNmEx?=
 =?utf-8?B?NWZMYkVWUTZhbllLQmhkdENJREl0UTJ2d1hoT09nckFUMUVnYllzcXdISndu?=
 =?utf-8?B?eXF2eElDMWZhZmYwbmtKNGpaV1haVUg4QzZ4dFlBUFBBMVp5NmxLUUNHWkRW?=
 =?utf-8?B?YXlCVDhNMWgyUFkzOTd4OHA2Z1YyWHUxRXZIeUxVdFVTdkV2NFp1TjgrMkJn?=
 =?utf-8?B?NjF0d3hKMGlwNGFuLzVlTW9wbVlIcnBzSW0yK0p3OFNXM0R0V1ozNkw0L0d4?=
 =?utf-8?B?NGxNeFgvcFFZRDBWUWJvL05vUXg3SjRlMDVub0lMRkM0VE9aTGZnTUlmZVp4?=
 =?utf-8?B?RUJwQzR6V2xsNnBaWFBmd2ROcTNuUW5Vb0pkeTlEd200SEtFZTN6czJNNi90?=
 =?utf-8?B?RHVlNG1FU21jTzJGc0U0YW54TDZQR0g2amVWZzByelpGUlg2a1V5STZEbFFl?=
 =?utf-8?B?UVNVZmxjT2YyWmxiMHBMUVhhQ3d1UkdFa1l2QlBrWmtvTjlWUXhIc2w2Z1lx?=
 =?utf-8?B?dHBTOHlYcnB6OGdGOThFakJCa0dVeFdEdzB0bE00dlRFZ2lsbmNaNG02aWl5?=
 =?utf-8?B?K1ZqRTBNaXE3dzUzUlBrMXhLb0YraFN3QkJHT3NBL1lKcXVkelU4eVlwaHRi?=
 =?utf-8?B?bjRCUVR5emxsR3p2eWlGYmh4bGt1dWdSeHY2NC9sRFJoYytGWGswbXBvakgv?=
 =?utf-8?B?RE9xeUpycDFpOEtHeGc3Z1VhTE1FYkt3Z0w4bUQyK0xUNUJyNjZRbGVlaWNj?=
 =?utf-8?B?RnlKRVRhS25DYUh0SjlHU2lUQTNCN254RTR2K0hrNXpLS2sxL3pQcHV0MTFO?=
 =?utf-8?B?V1R3b1dTSzcxa1BpOUZ6Uzh6czVCZWQ1em9RZTlqYmkrN2VBa0x0L1BFczRi?=
 =?utf-8?B?bi9XOGdPK1RwUjlqR0owUzNlVlBBQTZMREdudGNvdVh2WFhQeng2UFBrRlZE?=
 =?utf-8?B?VXlNY0RTRkJsQTFhblkwaEw1VHMyY0tzV2ZoY3dLZnJEUElEdURuV2hHR2hH?=
 =?utf-8?B?aW4xNlBET2JtV2IzWngzc1dPcGIwSzVJMmk2eVJsN3FYc0IzcjllMm4vVWln?=
 =?utf-8?B?ZFhTbWFHdTBuVEN5SDN1YVJ4a281anFxUlBFUDllSStpQWpQNWFvQk5YejZ2?=
 =?utf-8?B?aHBGY1NEWTlKRkRQeUhTdTJ3L2ZiQmxDY0NTaE1XdExnZXdDZlFYMjRob3VH?=
 =?utf-8?B?SkJzbkNJZVkweGpNampJS2pGak8wTlcvZnZ4MENtV0Q4UmJEWnhGMjRjNzBV?=
 =?utf-8?B?QzZOdHpNZ2hsd0hrYUJYRkJHSTVsV3dKL2ljTHZheHdzNXpYTGp3SHdKaXJq?=
 =?utf-8?B?Zk50a3JoZUMrcUxsN0JkdkNmN3VhaExuYi9rekRNK0pzdC8xSmhzRXdSWnlQ?=
 =?utf-8?B?akk2ZXpSZEZkQi9SSExDSVJSckdxNjJ5K1FtWXh0NXhpbmlrKzJzUkJ3NTEx?=
 =?utf-8?B?cEd0cStSeXBYUjlXd2I5MmFiZ1dDVTV0dm50WG1iMHhPeU5jd1pMNk1QVDZn?=
 =?utf-8?B?MXIxNGUvcHRSRldMK1BPWWh0SmRSUXB5cVptbEdWaFFkamJQTFFaMTNGVWZ0?=
 =?utf-8?B?MUUzbytSMk5TMVZUUERldVpKRHc5Sm90aU5TMzlBdUtFeW1ZVnBrL01ydVJj?=
 =?utf-8?B?b0lONDk2Myt6d25rZVRnKzU5eWxkL1dkeTB1WHpVdkttUG5jRWNQeTNWaWJP?=
 =?utf-8?B?Nmcwb2Mxc1J4RGNrQnZyZjdMd3ZwSHpIV3Vuc0orSFBidDU3QUI0VVhnNGo4?=
 =?utf-8?B?dTZnalpZWExhelhnQ2xGM2dmTC9BR2VQME0zZTR6R0VhcXVSMWxQMHovZ2pr?=
 =?utf-8?B?cSswcU9ZMlFIdllNeG5HWEc3cUY2Z01rcVFHNHZTNFZLWmZEOXgyS0hSV015?=
 =?utf-8?B?VjNpRnQxOWZTbUxUS1dnb0hPSStwOVNkR0tVMHpJOEQwdjFlOWx1RnFIMEZB?=
 =?utf-8?B?aVhIY0lnd0N2L2ROV3lFejllRGJCQyt0Q2ZZOU10d3prY2NOblVtV0JZQUUz?=
 =?utf-8?B?SEcwaG9TT3NXbURpZWROSkxaMWZaOFBMaG8vZ1dGLzBoTTUvcHQyRVZQdzVS?=
 =?utf-8?B?aWhMeHphMnRKR1NoUTFGd0oyK0txYWJJVnp6VzFMYnE3bjZOdjR2dERqb1pK?=
 =?utf-8?B?Ry94ZWx3bHFXWmJ2YkhwN1pXWTdCSkdOSFkxOUxMckc0TmdqQmExaldnS1dF?=
 =?utf-8?B?QThQQzljaUJQRFhMMkV4Q2IvNFVLaUxuR2dsYXZUTWV4LzlNRTdFaVVlNUtr?=
 =?utf-8?Q?QBarmzT6GOF91PzuI/yypUbGR6wFRStLpdA8QKTp/0=3D?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <DFAE31BD0D06524DA7F6444D7067D5F6@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f3df96-ebb9-4464-8f10-08d9c5475782
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 12:34:05.0534
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SIQgo3PIfRHAjkKGnrtwnE01ZuVFNN7SXWX8x+hMWDIm+T4BXZRDw4QljcyvT9z/VaWSatc9gOLRqRcnXK2wBLKC4ss8bUoPCezjyKQv9PE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8084
X-Proofpoint-GUID: Ewf2bCWAX41LAf-EeUVxg4OTQ5E8MF3j
X-Proofpoint-ORIG-GUID: Ewf2bCWAX41LAf-EeUVxg4OTQ5E8MF3j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_05,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999
 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112220070

DQoNCkp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyaXRlczoNCg0KPiBIaSwNCj4NCj4g
T24gMjIvMTIvMjAyMSAxMjoxNywgVm9sb2R5bXlyIEJhYmNodWsgd3JvdGU6DQo+PiBKdWxpZW4g
R3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cml0ZXM6DQo+Pj4gT24gMjEvMTIvMjAyMSAyMjozOSwg
U3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPj4+PiBPbiBUdWUsIDIxIERlYyAyMDIxLCBBbnRo
b255IFBFUkFSRCB3cm90ZToNCj4+Pj4+IE9uIEZyaSwgRGVjIDE3LCAyMDIxIGF0IDEyOjE1OjI1
UE0gKzAwMDAsIE9sZWtzaWkgTW9pc2llaWV2IHdyb3RlOg0KPj4+Pj4+PiBPbiAxNC4xMi4yMSAx
MTozNCwgT2xla3NpaSBNb2lzaWVpZXYgd3JvdGU6DQo+Pj4+Pj4+PiBAQCAtMTgxNywxNyArMTg1
OCwyNCBAQCBzdGF0aWMgdm9pZCBsaWJ4bF9fYWRkX2R0ZGV2cyhsaWJ4bF9fZWdjICplZ2MsIGxp
YnhsX19hbyAqYW8sIHVpbnQzMl90IGRvbWlkLA0KPj4+Pj4+Pj4gICAgIHsNCj4+Pj4+Pj4+ICAg
ICAgICAgQU9fR0M7DQo+Pj4+Pj4+PiAgICAgICAgIGxpYnhsX19hb19kZXZpY2UgKmFvZGV2ID0g
bGlieGxfX211bHRpZGV2X3ByZXBhcmUobXVsdGlkZXYpOw0KPj4+Pj4+Pj4gLSAgICBpbnQgaSwg
cmMgPSAwOw0KPj4+Pj4+Pj4gKyAgICBpbnQgaSwgcmMgPSAwLCByY19zY2kgPSAwOw0KPj4+Pj4+
Pj4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgZF9jb25maWctPm51bV9kdGRldnM7IGkrKykgew0K
Pj4+Pj4+Pj4gICAgICAgICAgICAgY29uc3QgbGlieGxfZGV2aWNlX2R0ZGV2ICpkdGRldiA9ICZk
X2NvbmZpZy0+ZHRkZXZzW2ldOw0KPj4+Pj4+Pj4gICAgICAgICAgICAgTE9HRChERUJVRywgZG9t
aWQsICJBc3NpZ24gZGV2aWNlIFwiJXNcIiB0byBkb21haW4iLCBkdGRldi0+cGF0aCk7DQo+Pj4+
Pj4+PiAgICAgICAgICAgICByYyA9IHhjX2Fzc2lnbl9kdF9kZXZpY2UoQ1RYLT54Y2gsIGRvbWlk
LCBkdGRldi0+cGF0aCk7DQo+Pj4+Pj4+PiAtICAgICAgICBpZiAocmMgPCAwKSB7DQo+Pj4+Pj4+
PiAtICAgICAgICAgICAgTE9HRChFUlJPUiwgZG9taWQsICJ4Y19hc3NpZ25fZHRkZXZpY2UgZmFp
bGVkOiAlZCIsIHJjKTsNCj4+Pj4+Pj4+ICsgICAgICAgIHJjX3NjaSA9IHhjX2RvbWFpbl9hZGRf
c2NpX2RldmljZShDVFgtPnhjaCwgZG9taWQsIGR0ZGV2LT5wYXRoKTsNCj4+Pj4+Pj4+ICsNCj4+
Pj4+Pj4+ICsgICAgICAgIGlmICgocmMgPCAwKSAmJiAocmNfc2NpIDwgMCkpIHsNCj4+Pj4+Pj4+
ICsgICAgICAgICAgICBMT0dEKEVSUk9SLCBkb21pZCwgInhjX2Fzc2lnbl9kdF9kZXZpY2UgZmFp
bGVkOiAlZDsgIg0KPj4+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgInhjX2RvbWFpbl9hZGRfc2Np
X2RldmljZSBmYWlsZWQ6ICVkIiwNCj4+Pj4+Pj4+ICsgICAgICAgICAgICAgICAgIHJjLCByY19z
Y2kpOw0KPj4+Pj4+Pj4gICAgICAgICAgICAgICAgIGdvdG8gb3V0Ow0KPj4+Pj4+Pj4gICAgICAg
ICAgICAgfQ0KPj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4gKyAgICAgICAgaWYgKHJjKQ0KPj4+Pj4+Pj4g
KyAgICAgICAgICAgIHJjID0gcmNfc2NpOw0KPj4+Pj4+Pg0KPj4+Pj4+Pg0KPj4+Pj4+PiBJZiBJ
IGdldCB0aGlzIGNvZGUgcmlnaHQsIGl0IHNvdW5kcyBsaWtlIHRoZSBkb20uY2ZnJ3MgZHRkZXYg
cHJvcGVydHkgaXMNCj4+Pj4+Pj4gcmV1c2VkIHRvIGRlc2NyaWJlIHNjaSBkZXZpY2VzIGFzIHdl
bGwsIGJ1dCB0aGUgbGlieGxfX2FkZF9kdGRldnMoKSBkb2VzIG5vdA0KPj4+Pj4+PiAoYW5kIGNh
biBub3QpIGRpZmZlcmVudGlhdGUgdGhlbS4gU28gaXQgaGFzIG5vIG9wdGlvbiBidXQgdG8gc2Vu
ZCB0d28NCj4+Pj4+Pj4gZG9tY3RscyBmb3IgZWFjaCBkZXZpY2UgaW4gZHRkZXZzW10gaG9waW5n
IHRvIGF0IGxlYXN0IG9uZSBkb21jdGwgdG8NCj4+Pj4+Pj4gc3VjY2VlZGVkLiBPciBJIHJlYWxs
eSBtaXNzZWQgc29tZXRoaW5nPw0KPj4+Pj4+Pg0KPj4+Pj4+PiBJdCBmZWVscyB0byBtZSB0aGF0
Og0KPj4+Pj4+PiAgIMKgLSBlaXRoZXIgbmV3IGRvbS5jZmcncyBwcm9wZXJ0eSBjb3VsZCBiZSBp
bnRyb2R1Y2VkIChzY2lkZXY/KSB0byBkZXNjcmliZQ0KPj4+Pj4+PiBzY2kgZGV2aWNlcyB0b2dl
dGhlciB3aXRoIG5ldyBwYXJzaW5nIGxvZ2ljL21hbmFnZW1lbnQgY29kZSwgc28geW91IHdpbGwg
ZW5kDQo+Pj4+Pj4+IHVwIGhhdmluZyBuZXcgbGlieGxfX2FkZF9zY2lkZXZzKCkgdG8gaW52b2tl
IFhFTl9ET01DVExfYWRkX3NjaV9kZXZpY2UsDQo+Pj4+Pj4+IHNvIG5vIG1peGluZyB0aGluZ3Mu
DQo+Pj4+Pj4+ICAgwqAtIG9yIGluZGVlZCBkdGRldiBsb2dpYyBjb3VsZCBiZSAqY29tcGxldGVs
eSogcmV1c2VkIGluY2x1ZGluZyBleHRlbmRpbmcNCj4+Pj4+Pj4gWEVOX0RPTUNUTF9hc3NpZ25f
ZGV2aWNlIHRvIGNvdmVyIHlvdXIgdXNlLWNhc2UsIGFsdGhvdWdoIHNvdW5kcyBnZW5lcmljLCBp
dA0KPj4+Pj4+PiBpcyB1c2VkIHRvIGRlc2NyaWJlIGRldmljZXMgZm9yIHRoZSBwYXNzdGhyb3Vn
aCAodG8gY29uZmlndXJlIGFuIElPTU1VIGZvcg0KPj4+Pj4+PiB0aGUgZGV2aWNlKSwgaW4gdGhh
dCBjYXNlIHlvdSB3b3VsZG4ndCBuZWVkIGFuIGV4dHJhDQo+Pj4+Pj4+IFhFTl9ET01DVExfYWRk
X3NjaV9kZXZpY2UgaW50cm9kdWNlZCBieSBjdXJyZW50IHBhdGNoLg0KPj4+PiBJIHJlYWxpemUg
SSBkaWQgbXkgcmV2aWV3IGJlZm9yZSByZWFkaW5nIE9sZWtzYW5kcidzIGNvbW1lbnRzLiBJDQo+
Pj4+IGZ1bGx5DQo+Pj4+IGFncmVlIHdpdGggaGlzIGZlZWRiYWNrLiBIYXZpbmcgc2VlbiBob3cg
ZGlmZmljdWx0IGlzIGZvciB1c2VycyB0byBzZXR1cA0KPj4+PiBhIGRvbVUgY29uZmlndXJhdGlv
biBjb3JyZWN0bHkgdG9kYXksIEkgd291bGQgYWR2aXNlIHRvIHRyeSB0byByZXVzZSB0aGUNCj4+
Pj4gZXhpc3RpbmcgZHRkZXYgcHJvcGVydHkgaW5zdGVhZCBvZiBhZGRpbmcgeWV0IG9uZSBuZXcg
cHJvcGVydHkgdG8gbWFrZQ0KPj4+PiB0aGUgbGlmZSBvZiBvdXIgdXNlcnMgZWFzaWVyLg0KPj4+
Pg0KPj4+Pg0KPj4+Pj4+PiBQZXJzb25hbGx5IEkgd291bGQgdXNlIHRoZSBmaXJzdCBvcHRpb24g
YXMgSSBhbSBub3Qgc3VyZSB0aGF0IHNlY29uZCBvcHRpb24NCj4+Pj4+Pj4gaXMgY29uY2VwdHVh
bGx5IGNvcnJlY3QgJiYgcG9zc2libGUuIEkgd291bGQgbGVhdmUgdGhpcyBmb3IgdGhlIG1haW50
YWluZXJzDQo+Pj4+Pj4+IHRvIGNsYXJpZnkuDQo+Pj4+Pj4+DQo+Pj4+Pj4NCj4+Pj4+PiBUaGFu
ayB5b3UgZm9yIHRoZSBwb2ludC4gSSBhZ3JlZSB0aGF0IHJldXNpbmcgWEVOX0RPTUNUTF9hc3Np
Z25fZGV2aWNlDQo+Pj4+Pj4gc2VlbXMgbm90IHRvIGJlIGNvbmNlcHR1YWxseSBjb3JyZWN0LiBJ
bnRyb2R1Y2luZyBuZXcgZG9tLmNmZyBwcm9wZXJ0eQ0KPj4+Pj4+IHNlZW1zIHRvIGJlIHRoZSBv
bmx5IHdheSB0byBhdm9pZCBleHRyYSBEb21jdGwgY2FsbHMuDQo+Pj4+Pj4gSSB3aWxsIGhhbmRs
ZSB0aGlzIGluIHYyIGlmIHRoZXJlIHdpbGwgYmUgbm8gY29tcGxhaW5zIGZyb20gTWFpbnRhaW5l
cnMuDQo+Pj4+Pg0KPj4+Pj4gSSBkb24ndCBrbm93IGlmIHRoZXJlIHdpbGwgYmUgYSBjb21wbGFp
bnMgaW4gdjIgb3Igbm90IDotKSwgYnV0IHVzaW5nDQo+Pj4+PiBzb21ldGhpbmcgZGlmZmVyZW50
IGZyb20gZHRkZXYgc291bmQgZ29vZC4NCj4+Pj4+DQo+Pj4+PiBJZiBJIHVuZGVyc3RhbmQgY29y
cmVjdGx5LCBkdGRldiBzZWVtcyB0byBiZSBhYm91dCBwYXNzaW5nIHRocm91Z2ggYW4NCj4+Pj4+
IGV4aXN0aW5nIGRldmljZSB0byBhIGd1ZXN0LCBhbmQgdGhpcyBuZXcgc2NpIGRldmljZSBzZWVt
cyB0byBiZSBhYm91dCBoYXZpbmcgWGVuDQo+Pj4+PiAiZW11bGF0aW5nIiBhbiBzY2kgZGV2aWNl
IHdoaWNoIHRoZSBndWVzdCB3aWxsIHVzZS4gU28gaW50cm9kdWNpbmcNCj4+Pj4+IHNvbWV0aGlu
ZyBuZXcgKHNjaWRldiBvciBvdGhlciBuYW1lKSBzb3VuZHMgZ29vZC4NCj4+Pj4gVXNlcnMgYWxy
ZWFkeSBoYXZlIHRvIHByb3ZpZGUgNCBwcm9wZXJ0aWVzIChkdGRldiwgaW9tZW0sIGlycXMsDQo+
Pj4+IGRldmljZV90cmVlKSB0byBzZXR1cCBkZXZpY2UgYXNzaWdubWVudC4gSSB0aGluayB0aGF0
IG1ha2luZyBpdCA1DQo+Pj4+IHByb3BlcnRpZXMgd291bGQgbm90IGJlIGEgc3RlcCBmb3J3YXJk
IDotKQ0KPj4+DQo+Pj4gSUlSQywgaW4gdGhlIHBhc3QsIHdlIGRpc2N1c3NlZCB0byBmZXRjaCB0
aGUgaW5mb3JtYXRpb24gZGlyZWN0bHkgZnJvbQ0KPj4+IHRoZSBwYXJ0aWFsIGRldmljZS10cmVl
LiBNYXliZSB0aGlzIGRpc2N1c3Npb24gbmVlZHMgdG8gYmUgcmV2aXZlZD8NCj4+Pg0KPj4+IEFs
dGhvdWdoLCB0aGlzIGlzIGEgc2VwYXJhdGUgdG9waWMgZnJvbSB0aGlzIHNlcmllcy4NCj4+Pg0K
Pj4+PiBUbyBtZSBkdGRldiBhbmQgWEVOX0RPTUNUTF9hc3NpZ25fZGV2aWNlIGFyZSBhcHByb3By
aWF0ZSBiZWNhdXNlDQo+Pj4+IHRoZXkNCj4+Pj4gc2lnbmlmeSBkZXZpY2UgYXNzaWdubWVudCBv
ZiBvbmUgb3IgbW9yZSBkZXZpY2VzLiBXZSBhcmUgbm90IGFkZGluZyBhbnkNCj4+Pj4gYWRkaXRp
b25hbCAibWVhbmluZyIgdG8gdGhlbS4gSXQgaXMganVzdCB0aGF0IHdlJ2xsIGF1dG9tYXRpY2Fs
bHkgZGV0ZWN0DQo+Pj4+IGFuZCBnZW5lcmF0ZSBhbnkgU0NNSSBjb25maWd1cmF0aW9ucyBiYXNl
ZCBvbiB0aGUgbGlzdCBvZiBhc3NpZ25lZA0KPj4+PiBkZXZpY2VzLiBCZWNhdXNlIGlmIFNDTUkg
aXMgZW5hYmxlZCBhbmQgYSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gdGhlDQo+Pj4+IGd1ZXN0LCB0
aGVuIEkgdGhpbmsgd2Ugd2FudCB0byBhZGQgdGhlIGRldmljZSB0byB0aGUgU0NNSSBsaXN0IG9m
DQo+Pj4+IGRldmljZXMgYXV0b21hdGljYWxseS4NCj4+Pg0KPj4+IEkgYW0gT0sgd2l0aCByZS11
c2luZyBkdGRldi9YRU5fRE9NQ1RMX2Fzc2lnbl9kZXZpY2UgaG93ZXZlciB0aGVyZSBpcw0KPj4+
IGEgcGl0ZmFsbCB3aXRoIHRoYXQgYXBwcm9hY2guDQo+Pj4NCj4+PiBBdCB0aGUgbW9tZW50LCB0
aGV5IGFyZSBvbmx5IHVzZWQgZm9yIGRldmljZSBwcm90ZWN0ZWQgYnkgdGhlDQo+Pj4gSU9NTVUu
IElmIHRoZSBkZXZpY2UgaXMgbm90IHByb3RlY3RlZCBieSB0aGUgSU9NTVUgdGhlbiBpdCB3aWxs
IHJldHVybg0KPj4+IGFuIGVycm9yLg0KPj4gSUlSQyB0aGVyZSB3YXMgYSBjaGFuZ2UsIHRoYXQg
YWxsb3dlZCB0byBhc3NpZ24gZGV2aWNlIHdpdGhvdXQgYQ0KPj4gSU9NTVUuIEF0DQo+PiBsZWFz
dCB3ZSBkaXNjdXNzZWQgdGhpcyBpbnRlcm5hbGx5Lg0KPg0KPiBJIGFtIG5vdCBhd2FyZSBvZiBh
bnkgdXBzdHJlYW0uIERvIHlvdSBoYXZlIGEgcG9pbnRlciBpZiB0aGVyZSBpcyBhbnkNCj4gcHVi
bGljIGRpc2N1c3Npb24/DQoNCk5vLCB0aGlzIGlzIHRoZSBmaXJzdCBwdWJsaWMgZGlzY3Vzc2lv
biBvbiB0aGlzIHRvcGljLg0KDQo+DQo+Pj4NCj4+PiBOb3csIHdpdGggeW91ciBhcHByb2FjaCB3
ZSBtYXkgaGF2ZSBhIGRldmljZSB0aGF0IGlzIG5vdCBwcm90ZWN0ZWQgYnkNCj4+PiB0aGUgSU9N
TVUgYnV0IHJlcXVpcmUgdG8gYSBTQ01JIGNvbmZpZ3VyYXRpb24uDQo+PiBZb3UgbmVlZCB0byBw
cm90ZWN0IG9ubHkgRE1BLWNhcGFibGUgZGV2aWNlcy4NCj4NCj4gWGVuIGRvZXNuJ3Qga25vdyBp
ZiB0aGUgZGV2aWNlIGlzIERNQS1jYXBhYmxlIG9yIG5vdC4gU28uLi4NCj4NCg0KQnV0IGl0IGtu
b3dzIGlmIHRoZXJlIGlzIGEgaW9tbXVzPTw+IG5vZGUgcHJlc2VudCBmb3IgdGhlIGRldmljZS4N
Cg0KPj4gDQo+Pj4gSSBkb24ndCB0aGluayBpdCB3b3VsZCBiZSBzZW5zaWJsZSB0byBqdXN0IHJl
dHVybiAic3VjY2VlZCIgaGVyZQ0KPj4+IGJlY2F1c2UgdGVjaG5pY2FsbHkgeW91IGFyZSBhc2tp
bmcgdG8gYXNzaWduIGEgbm9uLXByb3RlY3RlZA0KPj4+IGRldmljZS4gQnV0IGF0IHRoZSBzYW1l
IHRpbWUsIGl0IHdvdWxkIHByZXZlbnQgYSB1c2VyIHRvIGFzc2lnbiBhDQo+Pj4gbm9uLURNQSBj
YXBhYmxlIGRldmljZS4NCj4+Pg0KPj4+IFNvIGhvdyBkbyB5b3Ugc3VnZ2VzdCB0byBhcHByb2Fj
aCB0aGlzPw0KPj4gV2VsbCwgaW4gbXkgaGVhZCBhc3NpZ25fZGV2aWNlIGlkZWFsbHkgc2hvdWxk
IGRvIHRoZSBmb2xsb3dpbmc6DQo+PiAxLiBBc3NpZ24gSU9NTVUgaWYgaXQgaXMgY29uZmlndXJl
ZCBmb3IgdGhlIGRldmljZQ0KPg0KPiAuLi4gd2l0aCB0aGlzIGFwcHJvYWNoIHlvdSBhcmUgYXQg
dGhlIHJpc2sgdG8gbGV0IHRoZSB1c2VyIHBhc3N0aHJvdWdoDQo+IGEgZGV2aWNlIHRoYXQgY2Fu
bm90IGJlIHByb3RlY3RlZC4NCj4NCj4+IDIuIEFzc2lnbiBTQ01JIGFjY2VzcyByaWdodHMNCj4+
IChOb3QgcmVsYXRlZCB0byB0aGlzIHBhdGNoIHNlcmllcywgYnV0Li4uKQ0KPj4gMy4gQXNzaWdu
IElSUXMNCj4+IDQuIEFzc2lnbiBJTyBtZW1vcnkgcmFuZ2VzLg0KPj4gUG9pbnRzIDMuIGFuZCA0
LiB3b3VsZCBhbGxvdyB1cyB0byBub3QgcHJvdmlkZSBhZGRpdGlvbmFsIGlycT1bXSBhbmQNCj4+
IGlvbWVtPVtdIGVudHJpZXMgaW4gYSBndWVzdCBjb25maWcuDQo+DQo+IFRoYXQgY291bGQgb25s
eSB3b3JrIGlmIHlvdXIgZ3Vlc3QgaXMgdXNpbmcgdGhlIHNhbWUgbGF5b3V0IGFzIHRoZQ0KPiBo
b3N0Lg0KDQpBZ3JlZWQuIEJ1dCBpbiBteSBleHBlcmllbmNlLCBpbiBtb3N0IGNhc2VzIHRoaXMg
aXMgdGhlIHRydWUuIFdlIHdvcmtlZA0Kd2l0aCBSZW5lc2FzIGFuZCBJTVggaGFyZHdhcmUgYW5k
IGluIGJvdGggY2FzZXMgaW9tZW1zIHdlcmUNCm1hcHBlZCAxOjEuDQoNCj4gT3RoZXJ3aXNlLCB0
aGVyZSBpcyBhIHJpc2sgaXQgd2lsbCBjbGFzaCB3aXRoIG90aGVyIHBhcnRzIG9mIHRoZQ0KPiBt
ZW1vcnkgbGF5b3V0Lg0KPg0KDQo+IFRvZGF5LCBndWVzdHMgc3RhcnRlZCB2aWEgdGhlIHRvb2xz
dGFjayBpcyBvbmx5IHVzaW5nIGEgdmlydHVhbA0KPiBsYXlvdXQsIHNvIHlvdSB3b3VsZCBmaXJz
dCBuZWVkIHRvIGFkZCBzdXBwb3J0IHRvIHVzZSB0aGUgaG9zdCBtZW1vcnkNCj4gbGF5b3V0Lg0K
DQpJIGNhbid0IHNheSBmb3IgYWxsIHRoZSBwb3NzaWJsZSBjb25maWd1cmF0aW9ucyBpbiB0aGUg
d2lsZCwgYnV0IEknbQ0KYXNzdW1pbmcgdGhhdCBpbiBtb3N0IGNhc2VzIGl0IHdpbGwgYmUgZmlu
ZSB0byB1c2UgMToxIG1hcHBpbmcuIEZvcg0KdGhvc2UgbW9yZSBleG90aWMgY2FzZXMgaXQgd291
bGQgYmUgcG9zc2libGUgdG8gaW1wbGVtZW50IHNvbWUNCmNvbmZpZ3VyYXRpb24gb3B0aW9uIGxp
a2UgaW9tZW1fbWFwPVttZm46Z2ZuXS4NCg0KQXMgU3RlZmFubyBwb2ludGVkLCByaWdodCBub3cg
dXNlciBuZWVkcyB0byBwcm92aWRlIDMgY29uZmlndXJhdGlvbg0Kb3B0aW9ucyB0byBwYXNzIGEg
ZGV2aWNlIHRvIGEgZ3Vlc3Q6IGR0X2RldiwgaXJxLCBpb21lbS4gQnV0IGluIGZhY3QsDQpYZW4g
aXMgYWxyZWFkeSBrbm93aW5nIGFib3V0IGlycSBhbmQgaW9tZW0gZnJvbSBkZXZpY2UgdHJlZS4N
Cg0KDQotLSANClZvbG9keW15ciBCYWJjaHVrIGF0IEVQQU0=


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 12:44:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 12:44:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250821.431966 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00yU-0002aP-PY; Wed, 22 Dec 2021 12:44:06 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250821.431966; Wed, 22 Dec 2021 12:44:06 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n00yU-0002aI-MX; Wed, 22 Dec 2021 12:44:06 +0000
Received: by outflank-mailman (input) for mailman id 250821;
 Wed, 22 Dec 2021 12:44:05 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/qRA=RH=gmail.com=olekstysh@srs-se1.protection.inumbo.net>)
 id 1n00yT-0002aC-Ix
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 12:44:05 +0000
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com
 [2a00:1450:4864:20::133])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id d882f0a3-6324-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 13:44:04 +0100 (CET)
Received: by mail-lf1-x133.google.com with SMTP id k21so5220584lfu.0
 for <xen-devel@lists.xenproject.org>; Wed, 22 Dec 2021 04:44:04 -0800 (PST)
Received: from [192.168.1.7] ([212.22.223.21])
 by smtp.gmail.com with ESMTPSA id x6sm204613lfn.144.2021.12.22.04.44.02
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Wed, 22 Dec 2021 04:44:03 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d882f0a3-6324-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-transfer-encoding:content-language;
        bh=h00eNxBO7wCa59mB27m3kYO8wPJl+/N3yIXlsVLpgrw=;
        b=HfosJQ09HeXugjET35Kgg4+Z1w3+P5HrrgbfsjvReix92glwEsdKMB4p0pBwkEEABC
         y/xxrHQsTYHjy5RNa5huchGL1CGQHythiieOsdpyAcQVfSOfthGmYGk5H14Zp56aTsMm
         OVFuaGzW5ocScd0Ea64ui1VwQBmsP/TLifDtvzo3b+kXl7uVxVv5OBGRTcfKOBNyqeTt
         zUMsyuuWOpzaIe+XDum3Bpf0FHuCVYp4bE5CXdDgIjqzn+n3hfoUJXMtZSBVXwyoHKkN
         ItR1/c1ToI2qmwRuC+viCaw+5Ot91JYHdFdAE4rJ5bHAt+/rg3kII4VwqsdwQkf43mnG
         2N2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding
         :content-language;
        bh=h00eNxBO7wCa59mB27m3kYO8wPJl+/N3yIXlsVLpgrw=;
        b=aMuXwPpCASk02mENrJjh4wBTizW14ASdQQ1KIrCVZR26+cmSQzki9QExxJs/hv1Atp
         cpHOyUP85/E764TG4VkGmGz3Km01Ha7fKDap6XZbvQqrToT8pEV2ERWhSusABxCcYaaE
         ZwsKkzocFfv5PYz1gZ7dLtWSj8zkRL5Q12LKChLtGgfCKxDpZBIxvniH5ltVwbzPAruk
         d+dzw+RIBERgn0vpUyCo+cFc0YLfVEbOon6qYb/ZiXRDl6dstqXTPDeVhf9oeyEEcXVr
         kAtT1iyUMvz0JFviFzgIct39/LYg0h9L3Su2Jjg3+L5fVrWBH6QH07x7yII7pfQH0zmH
         TI0w==
X-Gm-Message-State: AOAM531f0JMmuLP+NM6IW774dLRAOygLouciVKxFhzAy+SK1cGLeIiyi
	bsIH0zUc0VaLS1XzNyautbamkP7hA4Y=
X-Google-Smtp-Source: ABdhPJyCQvB3gfa34bL+eIjLKVNQ/chNv9U6aIeHyBuntdOQJUyK0l2581eB88YMHaWIK9FSt7+Qcg==
X-Received: by 2002:a19:490f:: with SMTP id w15mr2311434lfa.278.1640177043801;
        Wed, 22 Dec 2021 04:44:03 -0800 (PST)
Subject: Re: [PATCH V4] xen/gnttab: Store frame GFN in struct page_info on Arm
To: Julien Grall <julien@xen.org>, Jan Beulich <jbeulich@suse.com>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Wei Liu <wl@xen.org>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?=
 <roger.pau@citrix.com>, Bob Eshleman <bobbyeshleman@gmail.com>,
 Alistair Francis <alistair.francis@wdc.com>,
 Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
References: <1638563610-4419-1-git-send-email-olekstysh@gmail.com>
 <ebfaf88c-38a8-638c-298e-a92e5827baf1@suse.com>
 <6f4813ce-5d23-2192-fabc-e933241cf30e@gmail.com>
 <c1c043b1-bffd-f758-f7b0-fd08539550a5@suse.com>
 <f8ac8922-0695-7666-8585-92a089164e44@xen.org>
 <57616176-938b-2125-fe34-4fadf2b4f816@suse.com>
 <74a0ca4a-b091-77e6-ddb4-490d2a0a0f4b@xen.org>
From: Oleksandr <olekstysh@gmail.com>
Message-ID: <6548d378-aaca-2efd-2194-7725aaf0548d@gmail.com>
Date: Wed, 22 Dec 2021 14:44:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <74a0ca4a-b091-77e6-ddb4-490d2a0a0f4b@xen.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US


On 22.12.21 14:33, Julien Grall wrote:
> Hi Jan,


Hi Julien, Jan



>
> On 22/12/2021 13:05, Jan Beulich wrote:
>> On 22.12.2021 11:01, Julien Grall wrote:
>>> On 14/12/2021 17:45, Jan Beulich wrote:
>>>> On 14.12.2021 17:26, Oleksandr wrote:
>>>>> On 14.12.21 15:37, Jan Beulich wrote:
>>>>>> On 03.12.2021 21:33, Oleksandr Tyshchenko wrote:
>>>>>>> @@ -2177,14 +2181,22 @@ void *alloc_xenheap_pages(unsigned int 
>>>>>>> order, unsigned int memflags)
>>>>>>>         void free_xenheap_pages(void *v, unsigned int order)
>>>>>>>     {
>>>>>>> +    struct page_info *pg;
>>>>>>> +    unsigned int i;
>>>>>>> +
>>>>>>>         ASSERT(!in_irq());
>>>>>>>             if ( v == NULL )
>>>>>>>             return;
>>>>>>>     +    pg = virt_to_page(v);
>>>>>>> +
>>>>>>>         memguard_guard_range(v, 1 << (order + PAGE_SHIFT));
>>>>>> ... this really want to (logically) move into the new arch hooks.
>>>>>> That'll effectively mean to simply drop the Arm stubs afaict (and I
>>>>>> notice there's some dead code there on x86, which I guess I'll make
>>>>>> a patch to clean up). But first of all this suggests that you want
>>>>>> to call the hooks with base page and order, putting the loops there.
>>>>>
>>>>> I see your point and agree ... However I see the on-list patches that
>>>>> remove common memguard_* invocations and x86 bits.
>>>>> So I assume, this request is not actual anymore, or I still need 
>>>>> to pass
>>>>> an order to new arch hooks? Please clarify.
>>>>
>>>> Well, that patch (really just the Arm one) effectively takes care of
>>>> part of what I did say above. Irrespective I continue to think that
>>>> the hook should take a (page,order) tuple instead of getting invoked
>>>> once for every order-0 page. And the hook invocations should be placed
>>>> such that they could fulfill the (being removed) memguard function
>>>> (iirc that was already the case, at least mostly).
>>>
>>> IIUC your suggestion, with your approach, alloc_xenheap_pages() would
>>> look like:
>>>
>>>        for ( i = 0; i < (1u << order); i++ )
>>>            pg[i].count_info |= PGC_xen_heap;
>>>
>>>        arch_alloc_xenheap_pages(pg, 1U << order);
>>
>> Like Oleksandr said, the 2nd argument would be just "order".
>>
>>> The Arm implementation for arch_alloc_xenheap_pages() would also 
>>> contain
>>> a loop.
>>>
>>> This could turn out to be quite expensive with large allocation (1GB
>>> allocation would require 16MB of cache) because the cache may not have
>>> enough space contain all the pages of that range. So you would have to
>>> pull twice the page_info in the cache.
>>
>> Hmm, that's a fair point. I assume you realize that a similar issue of
>> higher overhead would occur when using your approach, and when some
>> memguard-like thing was to reappear: Such mapping operations typically
>> are more efficient when done on a larger range.
>
> Yes, I was aware of that when I wrote my message. However, they are 
> not necessary at the moment. So I think we can defer the discussion.
>
>>  Since that's only a
>> hypothetical use at this point, I'm willing to accept your preference.
>> I'd like us to consider one more aspect though: All you need on Arm is
>> the setting of the exact same bits to the exact same pattern for every
>> struct page_info involved. Can't we simply have an arch hook returning
>> that pattern, for generic code to then OR it in alongside PGC_xen_heap?
>
> arch_alloc_xenheap_pages() will modify inuse.type_info so we can't or 
> the value to PGC_xen_heap.

I wonder, can we apply pattern here at alloc_heap_pages() when 
initializing type_info?
https://xenbits.xen.org/gitweb/?p=xen.git;f=xen/common/page_alloc.c;hb=refs/heads/master#l1027
If yes, the next question would be what indicator to use here to make 
sure that page is really xenheap page.
I also wonder, can we apply pattern for all type of pages here (without 
differentiating)?




From xen-devel-bounces@lists.xenproject.org Wed Dec 22 13:19:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 13:19:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250825.431978 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wb-0006hX-Eg; Wed, 22 Dec 2021 13:19:21 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250825.431978; Wed, 22 Dec 2021 13:19:21 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wb-0006hQ-9T; Wed, 22 Dec 2021 13:19:21 +0000
Received: by outflank-mailman (input) for mailman id 250825;
 Wed, 22 Dec 2021 13:19:19 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KCiG=RH=darkstar.site=sakib@srs-se1.protection.inumbo.net>)
 id 1n01WZ-0006hK-QV
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 13:19:19 +0000
Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c29f5a65-6329-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 14:19:17 +0100 (CET)
Received: from pb-smtp1.pobox.com (unknown [127.0.0.1])
 by pb-smtp1.pobox.com (Postfix) with ESMTP id DFB2210B1C0;
 Wed, 22 Dec 2021 08:19:14 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
 by pb-smtp1.pobox.com (Postfix) with ESMTP id D5BE010B1BF;
 Wed, 22 Dec 2021 08:19:14 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from localhost (unknown [95.67.114.216])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 489DF10B1BE;
 Wed, 22 Dec 2021 08:19:14 -0500 (EST)
 (envelope-from sakib@darkstar.site)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c29f5a65-6329-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:date:message-id:mime-version:content-transfer-encoding;
	 s=sasl; bh=2N/aoPMv6tJ0Gk304J71excBq0TQU6oYj6jMq22Vl1o=; b=XkfF
	bM6GyT1G+bKeVjjCMIZz2RjKZghalr81Pi2DQ2zx5P+CHJDst5jW+EOR7ONv44FR
	u0nnlAbIGmSvKvPodueIekaEUFz4mxJCwi64D0lukxsF6335IfPEWSULDqtG49Zn
	IMPF2pK5Nl6i/KDuF+5XzgK3oBvAdXaKDFa5hn0=
From: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
To: xen-devel@lists.xenproject.org
Cc: Sergiy Kibrik <Sergiy_Kibrik@epam.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Roman Skakun <rm.skakun@gmail.com>,
	Oleksandr Tyshchenko <olekstysh@gmail.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrii Anisov <Andrii_Anisov@epam.com>
Subject: [RFC v2] tag IOMMU-protected devices in dom0 fdt
Date: Wed, 22 Dec 2021 13:18:45 +0000
Message-Id: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
X-Pobox-Relay-ID:
 C21D4B1E-6329-11EC-8A36-5E84C8D8090B-90055647!pb-smtp1.pobox.com
Content-Transfer-Encoding: quoted-printable

At the moment, dom0 can't distinguish which devices are protected by
IOMMU and which are not. In some cases, this can cause swiotlb bounce
buffer use for DMA addresses above 32 bits, which in turn can lead
to poor performance.

Previous discussions at [1,2] agreed upon passing info about IOMMU via
device tree. This series does that in a way consistent with existing iomm=
u bindings.

[1] https://lore.kernel.org/all/1392913234-25429-1-git-send-email-julien.=
grall__16109.9684810781$1392913341$gmane$org@linaro.org/
[2] https://lore.kernel.org/all/cover.1633106362.git.roman_skakun@epam.co=
m/

Sergiy Kibrik (2):
  xen/arm: introduce dummy iommu node for dom0
  arm/xen: don't use xen DMA ops when the device is protected

Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Roman Skakun <rm.skakun@gmail.com>
Cc: Oleksandr Tyshchenko <olekstysh@gmail.com>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Andrii Anisov <Andrii_Anisov@epam.com>
--=20
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 13:19:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 13:19:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250826.431988 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wh-0006z7-Ke; Wed, 22 Dec 2021 13:19:27 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250826.431988; Wed, 22 Dec 2021 13:19:27 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wh-0006yy-HU; Wed, 22 Dec 2021 13:19:27 +0000
Received: by outflank-mailman (input) for mailman id 250826;
 Wed, 22 Dec 2021 13:19:26 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KCiG=RH=darkstar.site=sakib@srs-se1.protection.inumbo.net>)
 id 1n01Wg-0006y0-QK
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 13:19:26 +0000
Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c73b22f6-6329-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 14:19:25 +0100 (CET)
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id D822815E430;
 Wed, 22 Dec 2021 08:19:21 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id BEB9215E42F;
 Wed, 22 Dec 2021 08:19:21 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from localhost (unknown [95.67.114.216])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 6F93615E42A;
 Wed, 22 Dec 2021 08:19:17 -0500 (EST)
 (envelope-from sakib@darkstar.site)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c73b22f6-6329-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:date:message-id:in-reply-to:references:mime-version
	:content-transfer-encoding; s=sasl; bh=OD9az6OdDKqFn0VnlxEgG5MkL
	A6uVejNOQFIWvtBMjM=; b=TIsaknFsIM8FWiUKmv7wzaxn2CKkwXo6MC06pCZ1i
	fmup7d1d19rLdiSMhceASWYFLm7hnV2I8LfYMNpHs+Ya7o+Gqqd+QEvuZzoeSy1w
	LfLOZi07Ls/1FvzJl6IRau+8x7SPy3i4A1Zmy2iMuTlDCB/POqlM13FWJUXvG9y1
	VU=
From: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
To: xen-devel@lists.xenproject.org
Cc: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Subject: [XEN PATCH 1/1] xen/arm: introduce dummy iommu node for dom0
Date: Wed, 22 Dec 2021 13:18:46 +0000
Message-Id: <20211222131847.2476835-2-Sergiy_Kibrik@epam.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com>
References: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com>
MIME-Version: 1.0
X-Pobox-Relay-ID:
 C3FED40C-6329-11EC-8523-CBA7845BAAA9-90055647!pb-smtp21.pobox.com
Content-Transfer-Encoding: quoted-printable

Currently no IOMMU properties are exposed to dom0, thus kernel by default
assumes no protection and enables swiotlb-xen, which leads to costly and
unnecessary buffers bouncing.

To let kernel know which device is behing IOMMU and hence needs no swiotl=
b
services we introduce dummy xen-iommu node in FDT and link protected devi=
ce
nodes to it, using here device tree iommu bindings.

Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
---
 xen/arch/arm/domain_build.c           | 44 +++++++++++++++++++++++++++
 xen/include/asm-arm/kernel.h          |  3 ++
 xen/include/public/device_tree_defs.h |  1 +
 3 files changed, 48 insertions(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 6cfc772e66..951ca0a0cb 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -623,6 +623,12 @@ static int __init write_properties(struct domain *d,=
 struct kernel_info *kinfo,
         }
     }
=20
+    if ( iommu_node && kinfo->phandle_iommu && dt_device_is_protected(no=
de) )
+    {
+        res =3D fdt_property_cell(kinfo->fdt, "iommus", kinfo->phandle_i=
ommu);
+        if ( res )
+            return res;
+    }
     return 0;
 }
=20
@@ -948,6 +954,38 @@ static int __init make_cpus_node(const struct domain=
 *d, void *fdt)
     return res;
 }
=20
+static int __init make_iommu_node(const struct domain *d,
+                                  const struct kernel_info *kinfo)
+{
+    const char compat[] =3D "xen,iommu-el2-v1";
+    int res;
+
+    if ( !kinfo->phandle_iommu )
+        return 0;
+
+    dt_dprintk("Create iommu node\n");
+
+    res =3D fdt_begin_node(kinfo->fdt, "xen-iommu");
+    if ( res )
+        return res;
+
+    res =3D fdt_property(kinfo->fdt, "compatible", compat, sizeof(compat=
));
+    if ( res )
+        return res;
+
+    res =3D fdt_property_cell(kinfo->fdt, "#iommu-cells", 0);
+    if ( res )
+        return res;
+
+    res =3D fdt_property_cell(kinfo->fdt, "phandle", kinfo->phandle_iomm=
u);
+
+    res =3D fdt_end_node(kinfo->fdt);
+    if ( res )
+        return res;
+
+    return res;
+}
+
 static int __init make_gic_node(const struct domain *d, void *fdt,
                                 const struct dt_device_node *node)
 {
@@ -1584,6 +1622,10 @@ static int __init handle_node(struct domain *d, st=
ruct kernel_info *kinfo,
         if ( res )
             return res;
=20
+        res =3D make_iommu_node(d, kinfo);
+        if ( res )
+            return res;
+
         res =3D make_memory_node(d, kinfo->fdt, addrcells, sizecells, &k=
info->mem);
         if ( res )
             return res;
@@ -2177,6 +2219,8 @@ static int __init prepare_dtb_hwdom(struct domain *=
d, struct kernel_info *kinfo)
     ASSERT(dt_host && (dt_host->sibling =3D=3D NULL));
=20
     kinfo->phandle_gic =3D dt_interrupt_controller->phandle;
+    if ( is_iommu_enabled(d) )
+        kinfo->phandle_iommu =3D GUEST_PHANDLE_IOMMU;
     fdt =3D device_tree_flattened;
=20
     new_size =3D fdt_totalsize(fdt) + DOM0_FDT_EXTRA_SIZE;
diff --git a/xen/include/asm-arm/kernel.h b/xen/include/asm-arm/kernel.h
index 874aa108a7..efe09cd1e0 100644
--- a/xen/include/asm-arm/kernel.h
+++ b/xen/include/asm-arm/kernel.h
@@ -39,6 +39,9 @@ struct kernel_info {
     /* GIC phandle */
     uint32_t phandle_gic;
=20
+    /* dummy iommu phandle */
+    uint32_t phandle_iommu;
+
     /* loader to use for this kernel */
     void (*load)(struct kernel_info *info);
     /* loader specific state */
diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/d=
evice_tree_defs.h
index 209d43de3f..df58944bd0 100644
--- a/xen/include/public/device_tree_defs.h
+++ b/xen/include/public/device_tree_defs.h
@@ -7,6 +7,7 @@
  * onwards. Reserve a high value for the GIC phandle.
  */
 #define GUEST_PHANDLE_GIC (65000)
+#define GUEST_PHANDLE_IOMMU (GUEST_PHANDLE_GIC + 1)
=20
 #define GUEST_ROOT_ADDRESS_CELLS 2
 #define GUEST_ROOT_SIZE_CELLS 2
--=20
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 13:19:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 13:19:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250827.431999 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wl-0007HW-TJ; Wed, 22 Dec 2021 13:19:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250827.431999; Wed, 22 Dec 2021 13:19:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01Wl-0007HP-Q8; Wed, 22 Dec 2021 13:19:31 +0000
Received: by outflank-mailman (input) for mailman id 250827;
 Wed, 22 Dec 2021 13:19:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KCiG=RH=darkstar.site=sakib@srs-se1.protection.inumbo.net>)
 id 1n01Wk-0006y0-Km
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 13:19:30 +0000
Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id caae597e-6329-11ec-9e60-abaf8a552007;
 Wed, 22 Dec 2021 14:19:29 +0100 (CET)
Received: from pb-smtp21.pobox.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id 65E3415E433;
 Wed, 22 Dec 2021 08:19:28 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1])
 by pb-smtp21.pobox.com (Postfix) with ESMTP id 6031F15E432;
 Wed, 22 Dec 2021 08:19:28 -0500 (EST)
 (envelope-from sakib@darkstar.site)
Received: from localhost (unknown [95.67.114.216])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 10C1315E431;
 Wed, 22 Dec 2021 08:19:24 -0500 (EST)
 (envelope-from sakib@darkstar.site)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: caae597e-6329-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:date:message-id:in-reply-to:references:mime-version
	:content-transfer-encoding; s=sasl; bh=F0PgryYWioSUzsUd3xm/n5rTm
	EZFGYn3xClDnUlKbqc=; b=XITYhVfcDKp5AfVxTFcOc3I8Nt0LGvLRXvsTgNsFi
	vW1pxgQoAAilxHKSPRuF57uAApbO4+ZkV1XjBDnvJjglXM7o04CRfcuPc/6zafO2
	StMjOf4T+GTEbS9afYJQh98PwAe7gtiAJhrKBbQujY9FtLaOuGWJekbfQwKX/qlS
	4Y=
From: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
To: xen-devel@lists.xenproject.org
Cc: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Subject: [PATCH 1/1] arm/xen: don't use xen DMA ops when the device is protected by an IOMMU
Date: Wed, 22 Dec 2021 13:18:47 +0000
Message-Id: <20211222131847.2476835-3-Sergiy_Kibrik@epam.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com>
References: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com>
MIME-Version: 1.0
X-Pobox-Relay-ID:
 C7EF5AF0-6329-11EC-B4E6-CBA7845BAAA9-90055647!pb-smtp21.pobox.com
Content-Transfer-Encoding: quoted-printable

Only Xen is able to know if a device can safely avoid to use xen-swiotlb.
However since Xen links FDT nodes of protected devices to special dummy
xen-iommu node we can use that information to decide whether
xen-swiotlb is needed.

Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
---
 arch/arm/mm/dma-mapping.c   | 2 +-
 arch/arm/xen/enlighten.c    | 9 +++++++++
 arch/arm64/mm/dma-mapping.c | 2 +-
 include/xen/swiotlb-xen.h   | 1 +
 4 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index c4b8df2ad328..fc875dd16e0e 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -2280,7 +2280,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma=
_base, u64 size,
 	set_dma_ops(dev, dma_ops);
=20
 #ifdef CONFIG_XEN
-	if (xen_initial_domain())
+	if (xen_initial_domain() && !xen_is_protected_device(dev))
 		dev->dma_ops =3D &xen_swiotlb_dma_ops;
 #endif
 	dev->archdata.dma_ops_setup =3D true;
diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 49f566ad9acb..b36659238db3 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -66,6 +66,15 @@ static __read_mostly unsigned int xen_events_irq;
 uint32_t xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
=20
+bool xen_is_protected_device(struct device *dev)
+{
+	struct fwnode_handle *fwnode =3D
+		fwnode_find_reference(dev_fwnode(dev), "iommus", 0) ;
+	if (IS_ERR(fwnode))
+		return false;
+	return of_device_is_compatible(to_of_node(fwnode), "xen,iommu-el2-v1");
+}
+
 int xen_unmap_domain_gfn_range(struct vm_area_struct *vma,
 			       int nr, struct page **pages)
 {
diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
index 93e87b287556..68248e72e052 100644
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma-mapping.c
@@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_bas=
e, u64 size,
 		iommu_setup_dma_ops(dev, dma_base, size);
=20
 #ifdef CONFIG_XEN
-	if (xen_initial_domain())
+	if (xen_initial_domain() && !xen_is_protected_device(dev))
 		dev->dma_ops =3D &xen_swiotlb_dma_ops;
 #endif
 }
diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h
index d5eaf9d682b8..00b2782430fb 100644
--- a/include/xen/swiotlb-xen.h
+++ b/include/xen/swiotlb-xen.h
@@ -8,6 +8,7 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t =
handle,
 			  size_t size, enum dma_data_direction dir);
 void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle,
 			     size_t size, enum dma_data_direction dir);
+bool xen_is_protected_device(struct device *dev);
=20
 extern int xen_swiotlb_init(int verbose, bool early);
 extern const struct dma_map_ops xen_swiotlb_dma_ops;
--=20
2.25.1



From xen-devel-bounces@lists.xenproject.org Wed Dec 22 13:42:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 13:42:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250837.432010 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01sV-0002xD-RA; Wed, 22 Dec 2021 13:41:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250837.432010; Wed, 22 Dec 2021 13:41:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n01sV-0002x6-O2; Wed, 22 Dec 2021 13:41:59 +0000
Received: by outflank-mailman (input) for mailman id 250837;
 Wed, 22 Dec 2021 13:41:57 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=2rHP=RH=epam.com=prvs=2990e6cae6=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n01sT-0002x0-AQ
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 13:41:57 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id eb5fec27-632c-11ec-bb0b-79c175774b5d;
 Wed, 22 Dec 2021 14:41:52 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BMDDPf1008959;
 Wed, 22 Dec 2021 13:41:47 GMT
Received: from eur02-he1-obe.outbound.protection.outlook.com
 (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d42nh8j9f-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 22 Dec 2021 13:41:46 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7183.eurprd03.prod.outlook.com (2603:10a6:102:105::16)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 22 Dec
 2021 13:41:38 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4801.023; Wed, 22 Dec 2021
 13:41:38 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: eb5fec27-632c-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=kf4Z5+G5S17EiSKPgSXH4B9eKLEfCpjPYFZL0hg8L4A3NoYM1pfl/P6qC1+j51z580Kbb8TRKxCtky/ttQtyMB5fUxONVvQSLkdyn5JDvur+M3BY7KdgJsMNxGD0EywY/hKn7Etg5tPgs3SxWbsnfOUYrd86Lvc8/w4e5VYbMnmq+j/eQDtfkbwV4+gqZjhVv1e2UPoWNSsBAIkKV4sZWx/5SgAJHbJNtu9q73o6/+UEOeKze0wjZ+eZ+p41iJwcXi7xIhXvXY5gh43smFWbAe3VzKwsXUHtqOUcYkKxRH9eG4e+IznkEXcVXnjBXUu/pTGcCf080/uaDJgaCEJ3lA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=R4Q3znZPg3b8lhI6948LAFtsV5cw9WrZs6RZfilHXas=;
 b=I7Jz4zfXhnf4CM2MayX8Qo5QF2l5qedGyveoW2a/zggADabvVBFhssn0nJjh/0SQl8gv2lXIzOItc7EEDAi1DG6Xe6G0T8e86tBjMUqn894m9uFTBrFnBN2u3ayIzCnLiXkLKLMc2VnZJ1OD0/IGi+5DABKoQPXmwoGwcZA3wIwTditA4Cap+5Lm+JqZDs2ogwd4HO0maZz19uZRrGPsdlC15pff0TupBmWa8zfW3jF48p+y5Y6T0OX6+PuuHhEEhQXdF6gdQNuliC+XCotwGUZ6eQXLMnMbODPGcL1/JlDHdgyNzT1HvPakcQ/K9Ti7q8jGnTHlOkLO51ECD1bOZw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=R4Q3znZPg3b8lhI6948LAFtsV5cw9WrZs6RZfilHXas=;
 b=p+Z/tE91r/taCk6JufBb8k93343yrRj2+0p1Y8K17fPD7i9spPJRGRasaMwC8PbYcw2TkVb+G5N9UxyZD3XQcU2oRo7M68cFhH8PAhBilDgKiqpTtsIrUMDrKC3t7JngwS8Y1ESnUNSzqDW+pfYWvHmyFaA2oit311zmIVwuGJZ0IoDE3+GfhLes+pbHYQRpYg1JvDTkjZNVjizh4gNnX9Xf/4bW359b7VwBnSXw8ZXlZs8oQcyIVm3zbdv7wor9sqSHInGCmCCKVD0Z56HYKoVK5FJW9whV6ixXp9cyLzD4GOqZheg4SzjaRwXSpO24x3eauA8ftmz/Yj31YQYPCA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Juergen Gross <jgross@suse.com>,
        Andrew Cooper
	<andrew.cooper3@citrix.com>,
        George Dunlap <george.dunlap@citrix.com>,
        Jan
 Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
        Anthony PERARD
	<anthony.perard@citrix.com>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qw8NR4AgAJcjoA=
Date: Wed, 22 Dec 2021 13:41:38 +0000
Message-ID: <20211222134137.GB2926395@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112201703310.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112201703310.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b3844dad-b418-4755-cff3-08d9c550c76f
x-ms-traffictypediagnostic: PA4PR03MB7183:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7183D66CBB62E491EE86BB30E37D9@PA4PR03MB7183.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 P7Is41V0QUZ55xQ0JlXAKW73QIxA8bNF2j9NXDbOQQ8PIGvz76o0oMjLGzE6Zjx7F6QDM38y57gahjpkeMB6owVl3bkvU4wajNAxyuClhbZTTc6oz0JZSYuYN0LbNzq56pVa91e4uRSpE0JnshRc4do5zVXKIHVhQsBg67xQoYYcK6N5sIjHcSR5lcgI/SdVcJA7YO/Scs3G/KItqCvpIv+gwJAlICrKK4aAVyerYn0nMNEdIaHzfJMUvjgT7ceMhrcRDnahamPMmssW5k8i2xZ5ho5wixcjY329iAXng/M6jxNFSqB+7faXqaRwLNw2syQxbbeDrPtFXYE1DSHBMT1crFoQwg+XrlCaUYoa6UTdLHd4U7oICwa33zSQxPQ5ZYyqXic9uHtdylETY7Y4gp3WYGkcTxX38Y5wGiDoDwHJJvGKiGoL5z0NOuR2mUbHrN9fzJXZruVl2Wh8Ht7kOYNX49eYw5VGevUPknPkZkMLuJCEy4aRglvCRjmva6o1XnCCv6i+FJjwd4PCuUwm3UEwfZTctWtkv2BZtLttqFDv4fswKIvQKOHSxXbFLScC2lAnfQ2BEOt3Cl6pKb8f0eDQ+F+cbcGKCbJ96XJEJULimnLFC94P2QlH8+3blQqj7KDENJDh3fafHZfFM48F2XzuisPkr6arcENCBaS890QU/1G8CcN4QUDwIRPGzOVvSb2vnguh0nyIWgyKu45GRQ==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6486002)(66946007)(71200400001)(8936002)(66446008)(66476007)(76116006)(91956017)(9686003)(6512007)(33656002)(4326008)(1076003)(8676002)(66556008)(54906003)(508600001)(316002)(186003)(5660300002)(64756008)(122000001)(30864003)(38100700002)(38070700005)(7416002)(26005)(6506007)(2906002)(33716001)(83380400001)(6916009)(86362001)(579004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?unad6hD36gd7wsD8631ynJnt3qqGRTy0lyCKA1BCx0SmHB0dfUjKdmR3zxk3?=
 =?us-ascii?Q?2hzqn3obn4QSMSl0NITFRT5U89XSwRYlcGfcUJqNJBrCjIDB9bQWeBflGcNm?=
 =?us-ascii?Q?J34w9IIRvp3Nr2wyitmkdl6ydrNEXkK3ztqQxAtOpsIefNBKPWYjmZr+Se96?=
 =?us-ascii?Q?7BxCbRzLKZ49Wmuw67z0v1g7Hg0Tsc96/QuwK5L3Yqr0PbTo/yZr/HH/tvwg?=
 =?us-ascii?Q?y0OasR++VDQX6BBOev22KqkuqP6+34MTN8frlusw2V13k1uIJvwOU/xr7cqo?=
 =?us-ascii?Q?RCq3Ndn+6dR5vZTT5dGSwla01st/4Of6sJXwMH0zqma6+phEkL1kft0a8+D2?=
 =?us-ascii?Q?lWHcqRPanpMUOCls5+S81Tn+qldZ5Ev2TqdkXB4Pcul6wQzYXKl2UU6zhKTk?=
 =?us-ascii?Q?5wkkZCjOFP2LLR0PfKZFfd50n0r69oYtQEhGToi7zEwy5HJZ2CuZyafNluxG?=
 =?us-ascii?Q?GsZu9Drd4jSYh8ZAFeWp2pe+X6tuCKeq94P4DjT293PRRlCA9QO+lsRmaHRc?=
 =?us-ascii?Q?kLy0oKz9RAPmUms37veLAVArsY+n+WCyiqdZFk3hKGYLBWfM7AQcg3CH4XZp?=
 =?us-ascii?Q?zVRlTHp+m66q8MVihpu1b5ov0lXD6HYznENoW/9kGhbXHH0IYTGt+zm6PUtE?=
 =?us-ascii?Q?rk0DqV7Jh2JwP8f8N3B9QgCz7yFO46pC40nRJzhgR1IXt5/xjsHV2mD6jitd?=
 =?us-ascii?Q?gcgdJZgUmDpv5zUuSQTMkAcyQdPMpWK9IpIWBTMAk8kUxK78lF1awxa6GT7X?=
 =?us-ascii?Q?ymq4U2te7/o46B1N8R0E181eWY7Ac+GMkqs+18cbsAbWxkKUaS5PvPbUEKmH?=
 =?us-ascii?Q?3mTRnkax5UPk80XJBuovksR6CC3e7/ltS2ovDDCNs4bpr2agTQclfv3HMNZ8?=
 =?us-ascii?Q?J1JvMDoBYWJpkri9cPW5PtMKyEnZminpreGapCyNn7qJ91kugYJ3mM32L9Fa?=
 =?us-ascii?Q?dtUD8xeYUxpHxNe48X7oJOHSi2Nm+wqPXW64wCNiRSxjwBqVmB79GTEEsLtI?=
 =?us-ascii?Q?+hh06ExU0CFBUe6iiOuEX7hJLPafL3CngVznieXXj3B4wOHqcCVLknhOnrbP?=
 =?us-ascii?Q?P991MTQJQ8u6AGHaDlyNtXHausHkhNCaJknZnLsI8Q8w7+umvXY7qNZSUMei?=
 =?us-ascii?Q?A65ORhUXzrU16JXISGVY54IhExzRWaWbVBXCkFMyfn3HyBEvFsF9bm2bdCN9?=
 =?us-ascii?Q?YBdymQRNhTkYuVhoaHY+Fa6EP+5O0pYqZWG8UHOjKJWVMRNx4bffrXDhhhq9?=
 =?us-ascii?Q?RYkIDflzHGDCbpTD+fAVAGyz3Kw6nImzaNWaX+MPONWciXJptewLT1/a7NOI?=
 =?us-ascii?Q?UDWgMxV68taU2ljU5ORd+i0LtbZydwq28+Sk7kwkd+vZ0Oy2d27MRHi1iAGd?=
 =?us-ascii?Q?4cm/4Jjy6sOSuExkCUpL+X8fcKTovFc5sX9asg47J83JrZOy+TtmGnpRSP+s?=
 =?us-ascii?Q?S6wLywdrr6v1QjB0fktUH0okMS+hvOTZHN+k8kW7wdXLMiJCAYjZ3eC6YeDQ?=
 =?us-ascii?Q?O2N+St9tjjFP4wCZPUmyoX8C2Z5Z273G+/zT/a2QGCiezA0iUtzsXb+6xSRt?=
 =?us-ascii?Q?EDxbCmxLpAkyR+uSGZsr+b88QqpyXOirGGrfgJKo08/dwOBMiuFLmgHPAXwf?=
 =?us-ascii?Q?LuEuAr5voRzCq86bm0oqW86OUQS/cvxyIrr3xZ5d9FoiafWev4h7NYPnCHbn?=
 =?us-ascii?Q?bl/Hkb2b9iJiwfGiQ/TIe+ZRPZs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5AA8B99BC110B4791E172D501FD63E9@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3844dad-b418-4755-cff3-08d9c550c76f
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2021 13:41:38.2591
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0EW1JD2zB8DZBU+KVYWjEl+fToME509RvE2elkFRpNfMqLHOpAlwYjz9AsP/5GU3G7j/od0FQaa4ccXDGFyMsS54egvvqluA7xM7ehs+cQs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7183
X-Proofpoint-ORIG-GUID: AmkPZJDIP7YEErS_O4yFn5bn4Tq8-RNd
X-Proofpoint-GUID: AmkPZJDIP7YEErS_O4yFn5bn4Tq8-RNd
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-22_05,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0
 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0
 priorityscore=1501 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112220076

Hi Stefano,=20

On Mon, Dec 20, 2021 at 05:37:50PM -0800, Stefano Stabellini wrote:
> On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > Integration of the SCMI mediator with xen libs:
> > - add hypercalls to aquire SCI channel and set device permissions
> > for DomUs;
> > - add SCMI_SMC nodes to DomUs device-tree based on partial device-tree;
> > - SCI requests redirection from DomUs to Firmware.
> >=20
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > ---
> >  tools/include/xenctrl.h           |   3 +
> >  tools/include/xenguest.h          |   2 +
> >  tools/libs/ctrl/xc_domain.c       |  23 ++++++
> >  tools/libs/guest/xg_dom_arm.c     |   5 +-
> >  tools/libs/light/libxl_arm.c      | 122 +++++++++++++++++++++++++++---
> >  tools/libs/light/libxl_create.c   |  54 ++++++++++++-
> >  tools/libs/light/libxl_dom.c      |   1 +
> >  tools/libs/light/libxl_internal.h |   4 +
> >  xen/arch/arm/domctl.c             |  15 ++++
> >  xen/include/public/domctl.h       |   9 +++
> >  10 files changed, 223 insertions(+), 15 deletions(-)
> >=20
> > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
> > index 07b96e6671..cdd14f465f 100644
> > --- a/tools/include/xenctrl.h
> > +++ b/tools/include/xenctrl.h
> > @@ -1238,6 +1238,9 @@ int xc_domain_getvnuma(xc_interface *xch,
> >  int xc_domain_soft_reset(xc_interface *xch,
> >                           uint32_t domid);
> > =20
> > +int xc_domain_add_sci_device(xc_interface *xch,
> > +                              uint32_t domid, char *path);
> > +
> >  #if defined(__i386__) || defined(__x86_64__)
> >  /*
> >   * PC BIOS standard E820 types and structure.
> > diff --git a/tools/include/xenguest.h b/tools/include/xenguest.h
> > index 61d0a82f48..35c611ac73 100644
> > --- a/tools/include/xenguest.h
> > +++ b/tools/include/xenguest.h
> > @@ -242,6 +242,8 @@ struct xc_dom_image {
> > =20
> >      /* Number of vCPUs */
> >      unsigned int max_vcpus;
> > +
> > +    xen_pfn_t sci_shmem_gfn;
>=20
> We should be able to avoid introducing sci_shmem_gfn (more below)
>=20
>=20
> >  };
> > =20
> >  /* --- arch specific hooks ----------------------------------------- *=
/
> > diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c
> > index b155d6afd2..07bb390e17 100644
> > --- a/tools/libs/ctrl/xc_domain.c
> > +++ b/tools/libs/ctrl/xc_domain.c
> > @@ -2206,6 +2206,29 @@ int xc_domain_soft_reset(xc_interface *xch,
> >      domctl.domain =3D domid;
> >      return do_domctl(xch, &domctl);
> >  }
> > +
> > +int xc_domain_add_sci_device(xc_interface *xch,
> > +                              uint32_t domid, char *path)
> > +{
> > +    size_t size =3D strlen(path);
> > +    int rc;
> > +    DECLARE_DOMCTL;
> > +    DECLARE_HYPERCALL_BOUNCE(path, size, XC_HYPERCALL_BUFFER_BOUNCE_IN=
);
> > +
> > +    if ( xc_hypercall_bounce_pre(xch, path) )
> > +        return -1;
> > +
> > +    domctl.cmd =3D XEN_DOMCTL_add_sci_device;
> > +    domctl.domain =3D domid;
> > +    domctl.u.sci_device_op.size =3D size;
> > +    set_xen_guest_handle(domctl.u.sci_device_op.path, path);
> > +    rc =3D do_domctl(xch, &domctl);
> > +
> > +    xc_hypercall_bounce_post(xch, path);
> > +
> > +    return rc;
> > +}
>=20
> I'd skip this xc_ function and hypercall (more below)
>=20
>=20
> >  /*
> >   * Local variables:
> >   * mode: C
> > diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_ar=
m.c
> > index 5e3b76355e..368a670c46 100644
> > --- a/tools/libs/guest/xg_dom_arm.c
> > +++ b/tools/libs/guest/xg_dom_arm.c
> > @@ -25,11 +25,12 @@
> > =20
> >  #include "xg_private.h"
> > =20
> > -#define NR_MAGIC_PAGES 4
> > +#define NR_MAGIC_PAGES 5
> >  #define CONSOLE_PFN_OFFSET 0
> >  #define XENSTORE_PFN_OFFSET 1
> >  #define MEMACCESS_PFN_OFFSET 2
> >  #define VUART_PFN_OFFSET 3
> > +#define SCI_SHMEM_OFFSET 4
> > =20
> >  #define LPAE_SHIFT 9
> > =20
> > @@ -69,11 +70,13 @@ static int alloc_magic_pages(struct xc_dom_image *d=
om)
> >      dom->console_pfn =3D base + CONSOLE_PFN_OFFSET;
> >      dom->xenstore_pfn =3D base + XENSTORE_PFN_OFFSET;
> >      dom->vuart_gfn =3D base + VUART_PFN_OFFSET;
> > +    dom->sci_shmem_gfn =3D base + SCI_SHMEM_OFFSET;
> > =20
> >      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn)=
;
> >      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn=
);
> >      xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_=
PFN_OFFSET);
> >      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->vuart_gfn);
> > +    xc_clear_domain_page(dom->xch, dom->guest_domid, dom->sci_shmem_gf=
n);
>=20
> Given that sci_shmem_gfn doesn't actually require any allocations, just
> a remapping of an existing and already specified physical page, then I
> don't think we need to add a new page to alloc_magic_pages for it.
>=20
> We can just #define a static address for the SCMI page in the domU
> addres space and use it for the mapping. No need to allocate a new
> page.
>=20

I think this could be implemented. I will refactor this part in v2.

>=20
> >      xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN=
,
> >              dom->console_pfn);
> > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.=
c
> > index eef1de0939..73ef591822 100644
> > --- a/tools/libs/light/libxl_arm.c
> > +++ b/tools/libs/light/libxl_arm.c
> > @@ -8,6 +8,8 @@
> >  #include <assert.h>
> >  #include <xen/device_tree_defs.h>
> > =20
> > +#define SCMI_NODE_PATH      "/firmware/scmi"
> > +
> >  static const char *gicv_to_string(libxl_gic_version gic_version)
> >  {
> >      switch (gic_version) {
> > @@ -101,6 +103,19 @@ int libxl__arch_domain_prepare_config(libxl__gc *g=
c,
> >          return ERROR_FAIL;
> >      }
> > =20
> > +    switch (d_config->b_info.sci) {
> > +    case LIBXL_SCI_TYPE_NONE:
> > +        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_NONE;
> > +        break;
> > +    case LIBXL_SCI_TYPE_SCMI_SMC:
> > +        config->arch.sci_type =3D XEN_DOMCTL_CONFIG_SCI_SCMI_SMC;
> > +        break;
> > +    default:
> > +        LOG(ERROR, "Unknown SCI type %d",
> > +            d_config->b_info.sci);
> > +        return ERROR_FAIL;
> > +    }
> > +
> >      return 0;
> >  }
> > =20
> > @@ -122,6 +137,7 @@ int libxl__arch_domain_save_config(libxl__gc *gc,
> >      }
> > =20
> >      state->clock_frequency =3D config->arch.clock_frequency;
> > +    state->sci_agent_paddr =3D config->arch.sci_agent_paddr;
> > =20
> >      return 0;
> >  }
> > @@ -502,9 +518,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt=
)
> >      int res;
> >      LOG(DEBUG, "Creating OP-TEE node in dtb");
> > =20
> > -    res =3D fdt_begin_node(fdt, "firmware");
> > -    if (res) return res;
> > -
> >      res =3D fdt_begin_node(fdt, "optee");
> >      if (res) return res;
> > =20
> > @@ -517,9 +530,6 @@ static int make_optee_node(libxl__gc *gc, void *fdt=
)
> >      res =3D fdt_end_node(fdt);
> >      if (res) return res;
> > =20
> > -    res =3D fdt_end_node(fdt);
> > -    if (res) return res;
> > -
> >      return 0;
> >  }
> > =20
> > @@ -902,10 +912,9 @@ static int copy_node(libxl__gc *gc, void *fdt, voi=
d *pfdt,
> >      return 0;
> >  }
> > =20
> > -static int copy_node_by_path(libxl__gc *gc, const char *path,
> > -                             void *fdt, void *pfdt)
> > +static int get_path_nodeoff(const char *path, void *pfdt)
> >  {
> > -    int nodeoff, r;
> > +    int nodeoff;
> >      const char *name =3D strrchr(path, '/');
> > =20
> >      if (!name)
> > @@ -925,12 +934,101 @@ static int copy_node_by_path(libxl__gc *gc, cons=
t char *path,
> >      if (strcmp(fdt_get_name(pfdt, nodeoff, NULL), name))
> >          return -FDT_ERR_NOTFOUND;
> > =20
> > +    return nodeoff;
> > +}
> > +
> > +static int copy_node_by_path(libxl__gc *gc, const char *path,
> > +                             void *fdt, void *pfdt)
> > +{
> > +    int nodeoff, r;
> > +
> > +    nodeoff =3D get_path_nodeoff(path, pfdt);
> > +    if (nodeoff < 0)
> > +        return nodeoff;
> > +
> >      r =3D copy_node(gc, fdt, pfdt, nodeoff, 0);
> >      if (r) return r;
> > =20
> >      return 0;
> >  }
> > =20
> > +static int get_node_phandle(const char *path, void *pfdt, uint32_t *ph=
andle)
> > +{
> > +    int nodeoff;
> > +    const char *name =3D strrchr(path, '/');
> > +
> > +    if (!name)
> > +        return -FDT_ERR_INTERNAL;
> > +
> > +    name++;
> > +    nodeoff =3D fdt_path_offset(pfdt, path);
> > +    if (nodeoff < 0)
> > +        return nodeoff;
> > +
> > +    *phandle =3D fdt_get_phandle(pfdt, nodeoff);
> > +    return 0;
> > +}
> > +
> > +static int make_scmi_shmem_node(libxl__gc *gc, void *fdt, void *pfdt,
> > +                           struct xc_dom_image *dom)
> > +{
> > +    int res;
> > +    char buf[64];
> > +    uint32_t phandle =3D 0;
> > +
> > +    res =3D get_node_phandle("/scp-shmem", pfdt, &phandle);
> > +    if (res) return res;
>=20
> I hope we'll be able to avoid requiring the user to write a partial
> device tree with SCMI info in order to use it.

I assuming that all SCMI related data is already present in partial
device-tree. Because all scmi nodes should be added to the original
platform device tree, which is used to build domu and dom0 dtbs.
So the structure should look the following way, taken h3ulcb as an
example;

r8a77951-scmi.dtsi - describe all scmi nodes and update
clock/power/reset etc in the device nodes;
 |
\ /
included in r8a77951-ulcb.dts - device tree for rcar h3ulcb board
 |
\ /
included in r8a77951-ulcb-xen.dts - xen dts files;
included in r8a77951-ulcb-domu.dts - domu dts file.

So the idea is that scmi configuration should be applied for both
virtualized and non-virtualized systems.

That's why I copy nodes from partial device-tree to domain device-tree.
Another advantage of this approach is that user can configure scmi node
for each domain by add/remove protocols. For example only clock and
resets could work through scmi for DomX. This can easily be configured
when using partial device-tree.

>=20
> But if we have to go down this route, then we need to add a description
> of scp-shmem under docs/misc/arm/
>=20
> Also, in general, we cannot mandate or require specific paths in device
> tree and instead we should find nodes based on the compatible string.
> (There are exceptions like /reserved-memory and /firmware but they are
> only a couple.)
>=20

I agree about the specific path. I will make it to use compatible string
in v2.

>=20
> > +    snprintf(buf, sizeof(buf), "scp-shmem@%lx",
> > +             dom->sci_shmem_gfn << XC_PAGE_SHIFT);
> > +    res =3D fdt_begin_node(fdt, buf);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_compat(gc, fdt, 1, "arm,scmi-shmem");
> > +    if (res) return res;
> > +
> > +    res =3D fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS,
> > +                    GUEST_ROOT_SIZE_CELLS, 1,
> > +                    dom->sci_shmem_gfn << XC_PAGE_SHIFT, XC_PAGE_SHIFT=
);
> > +    if (res) return res;
> > +
> > +    LOG(DEBUG, "scmi: setting phandle =3D %u\n", phandle);
> > +    res =3D fdt_property_cell(fdt, "phandle", phandle);
> > +    if (res) return res;
> > +
> > +    res =3D fdt_end_node(fdt);
> > +    if (res) return res;
> > +
> > +    return 0;
> > +}
> > +
> > +static int make_firmware_node(libxl__gc *gc, void *fdt, void *pfdt, in=
t tee,
> > +                              int sci)
> > +{
> > +    int res;
> > +
> > +    if ((tee !=3D LIBXL_TEE_TYPE_OPTEE) && (sci !=3D LIBXL_SCI_TYPE_NO=
NE))
> > +        return 0;
>=20
> Shouldn't this be:
>=20
>     if ((tee !=3D LIBXL_TEE_TYPE_OPTEE) && (sci =3D=3D LIBXL_SCI_TYPE_NON=
E))
>=20
Yeah, I should fix this in v2. Thanks.

>=20
> > +    res =3D fdt_begin_node(fdt, "firmware");
> > +    if (res) return res;
> > +
> > +    if (tee =3D=3D LIBXL_TEE_TYPE_OPTEE) {
> > +       res =3D make_optee_node(gc, fdt);
> > +       if (res) return res;
> > +    }
> > +
> > +    if (sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC) {
> > +        res =3D copy_node_by_path(gc, SCMI_NODE_PATH, fdt, pfdt);
> > +        if (res) return res;
> > +    }
>=20
> Do we really need to copy the node from the partial device tree? That
> makes it a lot harder to use for the user. Ideally a user would only
> need to specify sci =3D "scmi_smc" and everything else should be done
> automatically.
>=20
> Can we automatically generate the SCMI device tree node instead? It
> looks like we should have all the information to be able to do it. If
> not, what is missing?
>=20
Please see the answer above.
>=20
> > +    res =3D fdt_end_node(fdt);
> > +    if (res) return res;
> > +
> > +    return 0;
> > +}
> > +
> >  /*
> >   * The partial device tree is not copied entirely. Only the relevant b=
its are
> >   * copied to the guest device tree:
> > @@ -1088,8 +1186,10 @@ next_resize:
> >          if (info->arch_arm.vuart =3D=3D LIBXL_VUART_TYPE_SBSA_UART)
> >              FDT( make_vpl011_uart_node(gc, fdt, ainfo, dom) );
> > =20
> > -        if (info->tee =3D=3D LIBXL_TEE_TYPE_OPTEE)
> > -            FDT( make_optee_node(gc, fdt) );
> > +        FDT( make_firmware_node(gc, fdt, pfdt, info->tee, info->sci) )=
;
> > +
> > +        if (info->sci =3D=3D LIBXL_SCI_TYPE_SCMI_SMC)
> > +            FDT( make_scmi_shmem_node(gc, fdt, pfdt, dom) );
> > =20
> >          if (d_config->num_pcidevs)
> >              FDT( make_vpci_node(gc, fdt, ainfo, dom) );
> > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_c=
reate.c
> > index dcd09d32ba..c7372fd344 100644
> > --- a/tools/libs/light/libxl_create.c
> > +++ b/tools/libs/light/libxl_create.c
> > @@ -596,6 +596,37 @@ out:
> >      return ret;
> >  }
> > =20
> > +static int map_sci_page(libxl__gc *gc, uint32_t domid, uint64_t paddr,
> > +                         uint64_t guest_addr)
> > +{
> > +    int ret;
> > +    uint64_t _paddr_pfn =3D paddr >> XC_PAGE_SHIFT;
> > +    uint64_t _guest_pfn =3D guest_addr >> XC_PAGE_SHIFT;
> > +
> > +    LOG(DEBUG, "iomem %"PRIx64, _paddr_pfn);
> > +
> > +    ret =3D xc_domain_iomem_permission(CTX->xch, domid, _paddr_pfn, 1,=
 1);
> > +    if (ret < 0) {
> > +        LOG(ERROR,
> > +              "failed give domain access to iomem page %"PRIx64,
> > +             _paddr_pfn);
> > +        return ret;
> > +    }
> > +
> > +    ret =3D xc_domain_memory_mapping(CTX->xch, domid,
> > +                                   _guest_pfn, _paddr_pfn,
> > +                                   1, 1);
> > +    if (ret < 0) {
> > +        LOG(ERROR,
> > +              "failed to map to domain iomem page %"PRIx64
> > +              " to guest address %"PRIx64,
> > +              _paddr_pfn, _guest_pfn);
> > +        return ret;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> >  int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config,
> >                         libxl__domain_build_state *state,
> >                         uint32_t *domid, bool soft_reset)
> > @@ -762,6 +793,16 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain=
_config *d_config,
> >          goto out;
> >      }
> > =20
> > +    if (state->sci_agent_paddr !=3D 0) {
>=20
> Shouldn't we also check for sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_NONE ?
>=20
> If the user specifies sci_type =3D=3D XEN_DOMCTL_CONFIG_SCI_SCMI_SMC, we
> shouldn't automatically map any SCMI channels to the guest, right?
>=20
Sounds good. I will fix this in v2`=20
>=20
> > +        ret =3D map_sci_page(gc, *domid, state->sci_agent_paddr,
> > +                            state->sci_shmem_gfn << XC_PAGE_SHIFT);
> > +        if (ret < 0) {
> > +            LOGED(ERROR, *domid, "map SCI page fail");
> > +            rc =3D ERROR_FAIL;
> > +            goto out;
> > +        }
> > +    }
> > +
> >      dom_path =3D libxl__xs_get_dompath(gc, *domid);
> >      if (!dom_path) {
> >          rc =3D ERROR_FAIL;
> > @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, =
libxl__ao *ao, uint32_t domid,
> >  {
> >      AO_GC;
> >      libxl__ao_device *aodev =3D libxl__multidev_prepare(multidev);
> > -    int i, rc =3D 0;
> > +    int i, rc =3D 0, rc_sci =3D 0;
> > =20
> >      for (i =3D 0; i < d_config->num_dtdevs; i++) {
> >          const libxl_device_dtdev *dtdev =3D &d_config->dtdevs[i];
> > =20
> >          LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->pa=
th);
> >          rc =3D xc_assign_dt_device(CTX->xch, domid, dtdev->path);
> > -        if (rc < 0) {
> > -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
> > +        rc_sci =3D xc_domain_add_sci_device(CTX->xch, domid, dtdev->pa=
th);
> > +
> > +        if ((rc < 0) && (rc_sci < 0)) {
> > +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
> > +                 "xc_domain_add_sci_device failed: %d",
> > +                 rc, rc_sci);
> >              goto out;
> >          }
> > +
> > +        if (rc)
> > +            rc =3D rc_sci;
>=20
> I would make this simpler actually. Do we need to pass dtdev->path
> twice, once for xc_assign_dt_device and a second time for
> xc_domain_add_sci_device?
>=20
> I would skip adding xc_domain_add_sci_device altogether. A general SCMI
> enable/disable for the domain is necessary, but then we can just get the
> directly assigned devices from xc_assign_dt_device. There is no need to
> specify the list twice. If a device is not manageable via SCMI we can
> detect it automatically because it is going to be missing scmi_devid on
> device tree.
>=20
In one of my previous email I described the idea to make a list of
sci_devids in dom.cfg. Such as:=20
sci_devs =3D [0, 1, 35]
and pass this list to Xen via hypercall, then send permission requests
via scmi for each devid.
The advantages of this approach are the following:
- we don't need scmi_devid in device-tree anymore;
- we do only 1 hypercall to set permissions for devices;
- we don't need to pass device-tree node to Hypervisor, just devid.

What do you think about this approach?

>=20
> >      }
> > =20
> >  out:
> > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.=
c
> > index fe9f760f71..b1d288a8b9 100644
> > --- a/tools/libs/light/libxl_dom.c
> > +++ b/tools/libs/light/libxl_dom.c
> > @@ -710,6 +710,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid,
> >          state->console_mfn =3D dom->console_pfn;
> >          state->store_mfn =3D dom->xenstore_pfn;
> >          state->vuart_gfn =3D dom->vuart_gfn;
> > +        state->sci_shmem_gfn =3D dom->sci_shmem_gfn;
> >      } else {
> >          state->console_mfn =3D xc_dom_p2m(dom, dom->console_pfn);
> >          state->store_mfn =3D xc_dom_p2m(dom, dom->xenstore_pfn);
> > diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl=
_internal.h
> > index 0b4671318c..f9f9cc633a 100644
> > --- a/tools/libs/light/libxl_internal.h
> > +++ b/tools/libs/light/libxl_internal.h
> > @@ -1407,6 +1407,10 @@ typedef struct {
> >      /* Whether this domain is being migrated/restored, or booting fres=
h.  Only
> >       * applicable to the primary domain, not support domains (e.g. stu=
b QEMU). */
> >      bool restore;
> > +
> > +    /* sci channel paddr to be set to device-tree node */
> > +    uint64_t sci_agent_paddr;
> > +    xen_pfn_t sci_shmem_gfn;
> >  } libxl__domain_build_state;
> > =20
> >  _hidden void libxl__domain_build_state_init(libxl__domain_build_state =
*s);
> > diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> > index 6245af6d0b..ba200407da 100644
> > --- a/xen/arch/arm/domctl.c
> > +++ b/xen/arch/arm/domctl.c
> > @@ -4,6 +4,7 @@
> >   * Copyright (c) 2012, Citrix Systems
> >   */
> > =20
> > +#include <asm/sci/sci.h>
> >  #include <xen/errno.h>
> >  #include <xen/guest_access.h>
> >  #include <xen/hypercall.h>
> > @@ -175,6 +176,20 @@ long arch_do_domctl(struct xen_domctl *domctl, str=
uct domain *d,
> > =20
> >          return rc;
> >      }
> > +    case XEN_DOMCTL_add_sci_device:
> > +    {
> > +        int rc;
> > +        struct dt_device_node *dev;
> > +
> > +        rc =3D dt_find_node_by_gpath(domctl->u.sci_device_op.path,
> > +                                   domctl->u.sci_device_op.size,
> > +                                   &dev);
> > +        if ( rc )
> > +            return rc;
> > +
> > +        return sci_add_dt_device(d, dev);
> > +    }
>=20
> I would skip it and instead I would add a call to sci_add_dt_device in
> the implementation of XEN_DOMCTL_assign_device.
>=20
please see my comment above.
>=20
> >      default:
> >      {
> >          int rc;
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index b85e6170b0..671c72c3e8 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -1177,6 +1177,13 @@ struct xen_domctl_vmtrace_op {
> >  #define XEN_DOMCTL_vmtrace_get_option         5
> >  #define XEN_DOMCTL_vmtrace_set_option         6
> >  };
> > +
> > +/* XEN_DOMCTL_add_sci_device: set sci device permissions */
> > +struct xen_domctl_sci_device_op {
> > +    uint32_t size; /* Length of the path */
> > +    XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */
> > +};
> > +
> >  typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t);
> > =20
> > @@ -1265,6 +1272,7 @@ struct xen_domctl {
> >  #define XEN_DOMCTL_get_cpu_policy                82
> >  #define XEN_DOMCTL_set_cpu_policy                83
> >  #define XEN_DOMCTL_vmtrace_op                    84
> > +#define XEN_DOMCTL_add_sci_device                85
> >  #define XEN_DOMCTL_gdbsx_guestmemio            1000
> >  #define XEN_DOMCTL_gdbsx_pausevcpu             1001
> >  #define XEN_DOMCTL_gdbsx_unpausevcpu           1002
> > @@ -1326,6 +1334,7 @@ struct xen_domctl {
> >          struct xen_domctl_psr_alloc         psr_alloc;
> >          struct xen_domctl_vuart_op          vuart_op;
> >          struct xen_domctl_vmtrace_op        vmtrace_op;
> > +        struct xen_domctl_sci_device_op     sci_device_op;
> >          uint8_t                             pad[128];
> >      } u;
> >  };
> > --=20
> > 2.27.0
> > =


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 13:50:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 13:50:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250842.432021 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n020J-0004BN-Qv; Wed, 22 Dec 2021 13:50:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250842.432021; Wed, 22 Dec 2021 13:50:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n020J-0004BG-NE; Wed, 22 Dec 2021 13:50:03 +0000
Received: by outflank-mailman (input) for mailman id 250842;
 Wed, 22 Dec 2021 13:50:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n020I-00041y-EQ
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 13:50:02 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n020F-00058m-Vo; Wed, 22 Dec 2021 13:49:59 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n020F-0007Ck-L6; Wed, 22 Dec 2021 13:49:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=qXuqZZA9IQmMkP81+FkJSny72GWyPaEwF+qhAplVMhU=; b=Jb960ZNI06su3fP+1Kp2/MEVEK
	tyv0v1riRByd2UIZFlYsdlJ16sZ+/UVOGVMUymHS0W45cYa9++sdLfj3587Dcb/oTIIGV8aZHnDL0
	dd0lZF2i2YeT8zxNTybOOrQpqKHrqXSQ4va6ioWuiYIjsgox2aE9aYiZzQ4CskPay3pI=;
Message-ID: <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
Date: Wed, 22 Dec 2021 14:49:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com>
 <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org> <87ee64x1hf.fsf@epam.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <87ee64x1hf.fsf@epam.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Volodymyr,

On 22/12/2021 13:34, Volodymyr Babchuk wrote:
> 
> 
> Julien Grall <julien@xen.org> writes:
> 
>> Hi,
>>
>> On 22/12/2021 12:17, Volodymyr Babchuk wrote:
>>> Julien Grall <julien@xen.org> writes:
>>>> On 21/12/2021 22:39, Stefano Stabellini wrote:
>>>>> On Tue, 21 Dec 2021, Anthony PERARD wrote:
>>>>>> On Fri, Dec 17, 2021 at 12:15:25PM +0000, Oleksii Moisieiev wrote:
>>>>>>>> On 14.12.21 11:34, Oleksii Moisieiev wrote:
>>>>>>>>> @@ -1817,17 +1858,24 @@ static void libxl__add_dtdevs(libxl__egc *egc, libxl__ao *ao, uint32_t domid,
>>>>>>>>>      {
>>>>>>>>>          AO_GC;
>>>>>>>>>          libxl__ao_device *aodev = libxl__multidev_prepare(multidev);
>>>>>>>>> -    int i, rc = 0;
>>>>>>>>> +    int i, rc = 0, rc_sci = 0;
>>>>>>>>>          for (i = 0; i < d_config->num_dtdevs; i++) {
>>>>>>>>>              const libxl_device_dtdev *dtdev = &d_config->dtdevs[i];
>>>>>>>>>              LOGD(DEBUG, domid, "Assign device \"%s\" to domain", dtdev->path);
>>>>>>>>>              rc = xc_assign_dt_device(CTX->xch, domid, dtdev->path);
>>>>>>>>> -        if (rc < 0) {
>>>>>>>>> -            LOGD(ERROR, domid, "xc_assign_dtdevice failed: %d", rc);
>>>>>>>>> +        rc_sci = xc_domain_add_sci_device(CTX->xch, domid, dtdev->path);
>>>>>>>>> +
>>>>>>>>> +        if ((rc < 0) && (rc_sci < 0)) {
>>>>>>>>> +            LOGD(ERROR, domid, "xc_assign_dt_device failed: %d; "
>>>>>>>>> +                 "xc_domain_add_sci_device failed: %d",
>>>>>>>>> +                 rc, rc_sci);
>>>>>>>>>                  goto out;
>>>>>>>>>              }
>>>>>>>>> +
>>>>>>>>> +        if (rc)
>>>>>>>>> +            rc = rc_sci;
>>>>>>>>
>>>>>>>>
>>>>>>>> If I get this code right, it sounds like the dom.cfg's dtdev property is
>>>>>>>> reused to describe sci devices as well, but the libxl__add_dtdevs() does not
>>>>>>>> (and can not) differentiate them. So it has no option but to send two
>>>>>>>> domctls for each device in dtdevs[] hoping to at least one domctl to
>>>>>>>> succeeded. Or I really missed something?
>>>>>>>>
>>>>>>>> It feels to me that:
>>>>>>>>     - either new dom.cfg's property could be introduced (scidev?) to describe
>>>>>>>> sci devices together with new parsing logic/management code, so you will end
>>>>>>>> up having new libxl__add_scidevs() to invoke XEN_DOMCTL_add_sci_device,
>>>>>>>> so no mixing things.
>>>>>>>>     - or indeed dtdev logic could be *completely* reused including extending
>>>>>>>> XEN_DOMCTL_assign_device to cover your use-case, although sounds generic, it
>>>>>>>> is used to describe devices for the passthrough (to configure an IOMMU for
>>>>>>>> the device), in that case you wouldn't need an extra
>>>>>>>> XEN_DOMCTL_add_sci_device introduced by current patch.
>>>>> I realize I did my review before reading Oleksandr's comments. I
>>>>> fully
>>>>> agree with his feedback. Having seen how difficult is for users to setup
>>>>> a domU configuration correctly today, I would advise to try to reuse the
>>>>> existing dtdev property instead of adding yet one new property to make
>>>>> the life of our users easier.
>>>>>
>>>>>
>>>>>>>> Personally I would use the first option as I am not sure that second option
>>>>>>>> is conceptually correct && possible. I would leave this for the maintainers
>>>>>>>> to clarify.
>>>>>>>>
>>>>>>>
>>>>>>> Thank you for the point. I agree that reusing XEN_DOMCTL_assign_device
>>>>>>> seems not to be conceptually correct. Introducing new dom.cfg property
>>>>>>> seems to be the only way to avoid extra Domctl calls.
>>>>>>> I will handle this in v2 if there will be no complains from Maintainers.
>>>>>>
>>>>>> I don't know if there will be a complains in v2 or not :-), but using
>>>>>> something different from dtdev sound good.
>>>>>>
>>>>>> If I understand correctly, dtdev seems to be about passing through an
>>>>>> existing device to a guest, and this new sci device seems to be about having Xen
>>>>>> "emulating" an sci device which the guest will use. So introducing
>>>>>> something new (scidev or other name) sounds good.
>>>>> Users already have to provide 4 properties (dtdev, iomem, irqs,
>>>>> device_tree) to setup device assignment. I think that making it 5
>>>>> properties would not be a step forward :-)
>>>>
>>>> IIRC, in the past, we discussed to fetch the information directly from
>>>> the partial device-tree. Maybe this discussion needs to be revived?
>>>>
>>>> Although, this is a separate topic from this series.
>>>>
>>>>> To me dtdev and XEN_DOMCTL_assign_device are appropriate because
>>>>> they
>>>>> signify device assignment of one or more devices. We are not adding any
>>>>> additional "meaning" to them. It is just that we'll automatically detect
>>>>> and generate any SCMI configurations based on the list of assigned
>>>>> devices. Because if SCMI is enabled and a device is assigned to the
>>>>> guest, then I think we want to add the device to the SCMI list of
>>>>> devices automatically.
>>>>
>>>> I am OK with re-using dtdev/XEN_DOMCTL_assign_device however there is
>>>> a pitfall with that approach.
>>>>
>>>> At the moment, they are only used for device protected by the
>>>> IOMMU. If the device is not protected by the IOMMU then it will return
>>>> an error.
>>> IIRC there was a change, that allowed to assign device without a
>>> IOMMU. At
>>> least we discussed this internally.
>>
>> I am not aware of any upstream. Do you have a pointer if there is any
>> public discussion?
> 
> No, this is the first public discussion on this topic.
> 
>>
>>>>
>>>> Now, with your approach we may have a device that is not protected by
>>>> the IOMMU but require to a SCMI configuration.
>>> You need to protect only DMA-capable devices.
>>
>> Xen doesn't know if the device is DMA-capable or not. So...
>>
> 
> But it knows if there is a iommus=<> node present for the device.

Not really. Not all the platforms have IOMMUs and not all the platforms 
with IOMMU have DMA-capable device protected by an IOMMU.

> 
>>>
>>>> I don't think it would be sensible to just return "succeed" here
>>>> because technically you are asking to assign a non-protected
>>>> device. But at the same time, it would prevent a user to assign a
>>>> non-DMA capable device.
>>>>
>>>> So how do you suggest to approach this?
>>> Well, in my head assign_device ideally should do the following:
>>> 1. Assign IOMMU if it is configured for the device
>>
>> ... with this approach you are at the risk to let the user passthrough
>> a device that cannot be protected.
>>
>>> 2. Assign SCMI access rights
>>> (Not related to this patch series, but...)
>>> 3. Assign IRQs
>>> 4. Assign IO memory ranges.
>>> Points 3. and 4. would allow us to not provide additional irq=[] and
>>> iomem=[] entries in a guest config.
>>
>> That could only work if your guest is using the same layout as the
>> host.
> 
> Agreed. But in my experience, in most cases this is the true. We worked
> with Renesas and IMX hardware and in both cases iomems were
> mapped 1:1.
> 
>> Otherwise, there is a risk it will clash with other parts of the
>> memory layout.
>>
> 
>> Today, guests started via the toolstack is only using a virtual
>> layout, so you would first need to add support to use the host memory
>> layout.
> 
> I can't say for all the possible configurations in the wild, but I'm
> assuming that in most cases it will be fine to use 1:1 mapping. For
> those more exotic cases it would be possible to implement some
> configuration option like iomem_map=[mfn:gfn].
Well, the Xen memory layout is not something that is stable nor AFAIK 
based on any memory layout. In fact, there is no such generic layout on Arm.

It is quite possible that it will work well with 1:1 MMIO on some 
platform (e.g. Renesas, IMX) but you can't expect to work for every Xen 
release or all the platforms.

> 
> As Stefano pointed, right now user needs to provide 3 configuration
> options to pass a device to a guest: dt_dev, irq, iomem. But in fact,
> Xen is already knowing about irq and iomem from device tree.

I understand and this is not ideal. I would be happy to consider your 
approach. However, this will have to enabled only when the guest is 
re-using the host layout.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 14:02:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 14:02:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250847.432031 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02CF-0006QX-VL; Wed, 22 Dec 2021 14:02:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250847.432031; Wed, 22 Dec 2021 14:02:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02CF-0006QQ-SJ; Wed, 22 Dec 2021 14:02:23 +0000
Received: by outflank-mailman (input) for mailman id 250847;
 Wed, 22 Dec 2021 14:02:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n02CE-0006QK-E3
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 14:02:22 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02CD-0005Ql-Sx; Wed, 22 Dec 2021 14:02:21 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02CD-0007uY-K0; Wed, 22 Dec 2021 14:02:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=iNqOuow6paNFTCm8eHq9fAHol9EpAhax92qfFQvdB4c=; b=Kdz2CArPJxwM/L0YblPKX8YkA+
	yzZ23D6B+XEiTWJIq7iCNVknk8etNLDEPBl1Js0/3wklY/39KLd5aG85gcy7lvpDNpglxLzyrt3/e
	0IQU+3Dn3VQXbjG55SrlS7M5RbWE8zz0I7H4tB8+FqTdoCLBuk4Sa+bLuVRtZogHKxmo=;
Message-ID: <3dbf3736-98d8-6960-5559-f74a5941b075@xen.org>
Date: Wed, 22 Dec 2021 15:02:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 02/12] xen: arm: Add CONFIG_OVERLAY_DTB
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-3-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-3-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Please add a short commit message explaning how this is going to be used.

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/arch/arm/Kconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa682..895f0ee 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -46,6 +46,14 @@ config HAS_ITS
>           bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
>           depends on GICV3 && !NEW_VGIC
>   
> +config OVERLAY_DTB
> +    depends on MPSOC_PLATFORM

None of the code looks to be Xilinx specific and this will prevent one 
to build a generic Xen and test your code. So can you remove the dependency?

> +    bool "Enable DTB overlay"
> +    default y

In general, for new feature, we want to disable them by default and gate 
them with UNSUPPORTED.

They can move off UNSUPPORTED once they are ready enough to be supported 
(and possibly security supported).

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 14:04:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 14:04:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250850.432042 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02Dl-0006zh-Ax; Wed, 22 Dec 2021 14:03:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250850.432042; Wed, 22 Dec 2021 14:03:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02Dl-0006za-81; Wed, 22 Dec 2021 14:03:57 +0000
Received: by outflank-mailman (input) for mailman id 250850;
 Wed, 22 Dec 2021 14:03:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n02Dj-0006zU-FW
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 14:03:55 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02Dj-0005TI-2R; Wed, 22 Dec 2021 14:03:55 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02Di-0007zq-QZ; Wed, 22 Dec 2021 14:03:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=VeoXK/OEpfHvbzDQoenm3wUrEzxO+9ELS6JEIkljLMU=; b=hDkIeqX9N9rj1Q23uIhcoXf8m5
	bS1aHcE+xYhAX1H5q6+rJ2skRsQDDxrIrJ+J+cW8yVdBJs9KswmVk3TJuYhSDaNyUE4ws82lQIU/Q
	iXxga8iK5dHk4CBAlmRS/LxUNqByi6ykE/QKruPYz7zEhD2nudXUcoxJdLumBrk+AVy8=;
Message-ID: <5c7e494a-c94d-4924-883e-f845b5fcd27f@xen.org>
Date: Wed, 22 Dec 2021 15:03:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 03/12] libfdt: Keep fdt functions after init
 for CONFIG_OVERLAY_DTB.
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-4-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-4-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Vikram,

On 09/11/2021 08:02, Vikram Garhwal wrote:
> This is done to access fdt library function which are required for adding device
> tree overlay nodes for dynamic programming of nodes.
> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/common/libfdt/Makefile | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile
> index 6bd207c..f838f5f 100644
> --- a/xen/common/libfdt/Makefile
> +++ b/xen/common/libfdt/Makefile
> @@ -1,7 +1,10 @@
>   include Makefile.libfdt
>   
>   SECTIONS := text data $(SPECIAL_DATA_SECTIONS)
> +

NIT: I would add a short comment explaining why we need to keep after init.

> +ifneq ($(CONFIG_OVERLAY_DTB),y)
>   OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s))
> +endif

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 14:07:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 14:07:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250855.432054 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02Gx-0007dk-Pu; Wed, 22 Dec 2021 14:07:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250855.432054; Wed, 22 Dec 2021 14:07:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02Gx-0007dd-Mu; Wed, 22 Dec 2021 14:07:15 +0000
Received: by outflank-mailman (input) for mailman id 250855;
 Wed, 22 Dec 2021 14:07:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n02Gw-0007dX-9W
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 14:07:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02Gv-0005WN-T5; Wed, 22 Dec 2021 14:07:13 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02Gv-0008Cf-Ku; Wed, 22 Dec 2021 14:07:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=wRqrZ3pXcIQg0lZSjRkprjZXbxwBulkeM+2IGLZIDT8=; b=wClAEuKvMmE2/ZHwOoPRuoktAP
	2I7C0NojBn1ix4yoFskrFy13QdKHJCD45Hw3BW3h9ZW4MPuBbrS8CecuH3ZP7Lj19a/3q8RfowC1P
	k8RQjhxjTG9Jj+biearzao8JDNAVIciVZs8lBOLupWwzn+iTaka4uLD1pdHtiHvxqT54=;
Message-ID: <d3f9549a-c01c-74ef-2069-e0427df3d094@xen.org>
Date: Wed, 22 Dec 2021 15:07:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 04/12] libfdt: Add fdt_ prefix to
 overlay_get_target()
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-5-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-5-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Add fdt_ prefix to overlay_get_target() and remove static type. This is done to
> get the target path for all the overlay nodes. This is useful to find which
> nodes are to be added/removed in dt_host.
> 
> Also, sending this patch to dtc mailing list to avoid the divergence.

Can you add a link to the thread on the DTC ML?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 14:31:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 14:31:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250859.432065 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02eY-0002tk-Ps; Wed, 22 Dec 2021 14:31:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250859.432065; Wed, 22 Dec 2021 14:31:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02eY-0002td-My; Wed, 22 Dec 2021 14:31:38 +0000
Received: by outflank-mailman (input) for mailman id 250859;
 Wed, 22 Dec 2021 14:31:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n02eX-0002tT-95
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 14:31:37 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02eW-0005vM-S2; Wed, 22 Dec 2021 14:31:36 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02eW-0001DW-2Y; Wed, 22 Dec 2021 14:31:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ZK9BKjudfEPQRMxjMcW++g5OisrGBve3vjozfNesKrQ=; b=30G4UTKHrnf+CFPGpuqBHpbDVs
	p+AHYZWHcXs3c1d1AbYZOF4DFsoogV7DRnAGVgRIDks/BnBB8k6w8RfvORhRKDAREtYVehLMcHmd8
	CgHCO+5FFjzNy0frNLO/RnRCqBprLKHb7s/9Itqs63dGPcoXNAHw5Vzsc3lBEiU4guzQ=;
Message-ID: <c8b48110-1410-6134-1584-3852eae6217b@xen.org>
Date: Wed, 22 Dec 2021 15:31:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 06/12] xen/smmu: Add remove_device callback
 for smmu_iommu ops
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-7-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-7-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Add remove_device callback for removing the device entry from smmu-master using
> following steps:
> 1. Find if SMMU master exists for the device node.
> 2. Remove the SMMU master
> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/drivers/passthrough/arm/smmu.c | 54 ++++++++++++++++++++++++++++++++++++++
>   1 file changed, 54 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
> index c9dfc4c..1a32e2c 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -816,6 +816,17 @@ static int insert_smmu_master(struct arm_smmu_device *smmu,
>   	return 0;
>   }
>   
> +static int remove_smmu_master(struct arm_smmu_device *smmu,
> +			      struct arm_smmu_master *master)
> +{
> +	if (!(smmu->masters.rb_node))

Coding style: The inner () are not necessary.

Also, is this check only there for code hardening purpose? If yes, then 
I would add an ASSERT_UNREACHABLE() in the if body to allow catching the 
error in debug build.

> +		return -ENOENT;
> +
> +	rb_erase(&master->node, &smmu->masters);
> +
> +	return 0;
> +}
> +
>   static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   					 struct device *dev,
>   					 struct iommu_fwspec *fwspec)
> @@ -853,6 +864,32 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu,
>   	return insert_smmu_master(smmu, master);
>   }
>   
> +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu,
> +					 struct device *dev)
> +{
> +	struct arm_smmu_master *master;
> +	struct device_node *dev_node = dev_get_dev_node(dev);
> +	int ret;
> +
> +	master = find_smmu_master(smmu, dev_node);
> +	if (master == NULL) {
> +		dev_err(dev,
> +			"No registrations found for master device %s\n",
> +			dev_node->name);
> +		return -EINVAL;
> +	}

Even if the IOMMU subsystem check it, it would be good that the SMMU 
driver also check the device is not currently used before removing it.

If it is, then we should return -EBUSY.

> +
> +	ret = remove_smmu_master(smmu, master);
> +
> +	if (ret)
> +		return ret;
> +
> +    dev_node->is_protected = false;

Coding style: The indentation looks off compare to the other line.

> +
> +	kfree(master);
> +	return 0;
> +}
> +
>   static int register_smmu_master(struct arm_smmu_device *smmu,
>   				struct device *dev,
>   				struct of_phandle_args *masterspec)
> @@ -876,6 +913,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu,
>   					     fwspec);
>   }
>   
> +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev)
> +{
> +	struct arm_smmu_device *smmu;
> +	struct iommu_fwspec *fwspec;
> +
> +	fwspec = dev_iommu_fwspec_get(dev);
> +	if (fwspec == NULL)
> +		return -ENXIO;
> +
> +	smmu = find_smmu(fwspec->iommu_dev);
> +	if (smmu == NULL)
> +		return -ENXIO;
> +
> +	return arm_smmu_dt_remove_device_legacy(smmu, dev);
> +}
> +
>   static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev)
>   {
>   	struct arm_smmu_device *smmu;
> @@ -2876,6 +2929,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = {
>       .init = arm_smmu_iommu_domain_init,
>       .hwdom_init = arm_smmu_iommu_hwdom_init,
>       .add_device = arm_smmu_dt_add_device_generic,
> +    .remove_device = arm_smmu_dt_remove_device_generic,
>       .teardown = arm_smmu_iommu_domain_teardown,
>       .iotlb_flush = arm_smmu_iotlb_flush,
>       .iotlb_flush_all = arm_smmu_iotlb_flush_all,

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 14:38:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 14:38:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250862.432076 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02kr-0003ZY-GK; Wed, 22 Dec 2021 14:38:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250862.432076; Wed, 22 Dec 2021 14:38:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n02kr-0003ZR-DE; Wed, 22 Dec 2021 14:38:09 +0000
Received: by outflank-mailman (input) for mailman id 250862;
 Wed, 22 Dec 2021 14:38:08 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n02kp-0003ZF-W2
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 14:38:08 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02kp-00063L-3e; Wed, 22 Dec 2021 14:38:07 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n02ko-0001nH-Ph; Wed, 22 Dec 2021 14:38:07 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=iD+TxZTPLwePxNCkGIS+ksoL7XbZgEjCVRb/1sKrq/0=; b=U16XCPeb15YkQAQLNR+tTq4c4U
	zTUadjPyFTOdHwqV1HRKVXAKRB4UvCZXqc5j6X6guEXl2w/WYcWgC5wtXNMKPb2oG051wfkxj2lbX
	C+KxO3cZPMdAlTNEKBYc40vqbSfsY60sw7AfSO2UBM8aRD81G2Rae1Pd5UBsBY1oV/Co=;
Message-ID: <01246e6b-1fbf-0853-571f-7b33b528d112@xen.org>
Date: Wed, 22 Dec 2021 15:38:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 07/12] xen/smmu: Add remove_device callback
 for smmu_iommu ops
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com, Jan Beulich <jbeulich@suse.com>,
 Paul Durrant <paul@xen.org>
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-8-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-8-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Add remove_device callback for removing the device entry from smmu-master using
>   following steps:
>      1. Find if SMMU master exists for the device node.
>      2. Remove the SMMU master

The commit title and message doesn't match the code.

> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/drivers/passthrough/device_tree.c | 30 ++++++++++++++++++++++++++++++
>   xen/include/xen/iommu.h               |  2 ++
>   2 files changed, 32 insertions(+)
> 
> diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c
> index 98f2aa0..9d9eed8 100644
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -127,6 +127,36 @@ int iommu_release_dt_devices(struct domain *d)
>       return 0;
>   }
>   
> +int iommu_remove_dt_device(struct dt_device_node *np)
> +{
> +    const struct iommu_ops *ops = iommu_get_ops();
> +    struct device *dev = dt_to_dev(np);
> +    int rc;
> +
> +    if ( !ops )
> +        return -EOPNOTSUPP;
> +
> +    if ( iommu_dt_device_is_assigned(np) )
> +        return -EPERM;

EPERM means the caller doesn't have the permission to request it. 
However, dom0 will have the permission to remote the device. The problem 
is the device is currently assigned to a domain. So it would be better 
to return EBUSY.

Also, most of the function wants to be protected with dtdevs_lock to 
prevent concurrent access to add/remove/assign/deassign.

I would create a version of iommu_dt_device_is_assigned() (maybe called 
iommu_dt_device_is_assigned_locked()) that would do the same but with 
the caller hold the lock.

> +
> +    /*
> +     * The driver which supports generic IOMMU DT bindings must have
> +     * these callback implemented.
> +     */
> +    if ( !ops->remove_device )
> +        return -EOPNOTSUPP;
> +
> +    /*
> +     * Remove master device from the IOMMU if latter is present and available.
> +     */
> +    rc = ops->remove_device(0, dev);
> +
> +    if ( rc == 0 )
> +        iommu_fwspec_free(dev);
> +
> +    return rc;
> +}
> +
>   int iommu_add_dt_device(struct dt_device_node *np)
>   {
>       const struct iommu_ops *ops = iommu_get_ops();
> diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h
> index 6b2cdff..c4d5d12 100644
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -215,6 +215,8 @@ int iommu_release_dt_devices(struct domain *d);
>    */
>   int iommu_add_dt_device(struct dt_device_node *np);
>   
> +int iommu_remove_dt_device(struct dt_device_node *np);
> +
>   int iommu_do_dt_domctl(struct xen_domctl *, struct domain *,
>                          XEN_GUEST_HANDLE_PARAM(xen_domctl_t));
>   

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 16:13:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 16:13:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250867.432086 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n04Et-00070D-Mi; Wed, 22 Dec 2021 16:13:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250867.432086; Wed, 22 Dec 2021 16:13:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n04Et-000706-Jm; Wed, 22 Dec 2021 16:13:15 +0000
Received: by outflank-mailman (input) for mailman id 250867;
 Wed, 22 Dec 2021 16:13:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n04Es-000700-7u
 for xen-devel@lists.xenproject.org; Wed, 22 Dec 2021 16:13:14 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n04Eq-0008ET-0s; Wed, 22 Dec 2021 16:13:12 +0000
Received: from [54.239.6.186] (helo=[192.168.17.226])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n04Ep-0000bz-DH; Wed, 22 Dec 2021 16:13:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=kgKcTU1GDe0eG7xhn5KOuvlsLEBH1RYdeEL5ixBGMjk=; b=Ba70OctAfTEoQANkSDY11Nd2Vx
	0AUGwQq/Vv7r/mD2li26DW9j2YpkzOJhJLvw2fXyNe0SZMDUTT50C0zP5pKXPGa7M3+UxTLQ9w9S8
	YJf7r5P+nzUvS4XsK3rYducli24iN0L5AecdaGMRsCRwUs2pNPQDdvn68UnyP4rQlkNE=;
Message-ID: <229a8fb4-816d-bfc3-31d3-5c375c5cd14b@xen.org>
Date: Wed, 22 Dec 2021 17:13:08 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.0
Subject: Re: [XEN][RFC PATCH v2 08/12] xen/arm: Implement device tree node
 removal functionalities
To: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, bertrand.marquis@arm.com,
 volodymyr_babchuk@epam.com, Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>,
 Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com>
 <1636441347-133850-9-git-send-email-fnu.vikram@xilinx.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <1636441347-133850-9-git-send-email-fnu.vikram@xilinx.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Introduce sysctl XEN_SYSCTL_overlay to remove device-tree nodes added using

I agree with Jan about the name being too generic. I will comment on 
this a bit further down.

> device tree overlay.
> 
> xl overlay remove file.dtbo:
>      Removes all the nodes in a given dtbo.
>      First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes
>      in dt_host and delete the device node entries from dt_host.
> 
>      The nodes get removed only if it is not used by any of dom0 or domus. If
>      even one of the node in dtbo is not available for removal i.e. either not
>      there in dt_host or currently used by any domain, in that case we don't
>      remove any node in the given dtbo.
> 
> Also, added overlay_track struct to keep the track of added node through device
> tree overlay. overlay_track has dt_host_new which is unflattened form of updated
> fdt and name of overlay node. When a node is removed, we also free the memory
> used by overlay_track for the particular overlay node.
> 
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/common/device_tree.c      |  53 ++++++
>   xen/common/sysctl.c           | 372 ++++++++++++++++++++++++++++++++++++++++++
>   xen/include/public/sysctl.h   |  23 +++
>   xen/include/xen/device_tree.h |   4 +
>   4 files changed, 452 insertions(+)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 26d2e28..19320e1 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -385,6 +385,59 @@ void dt_print_node_names(struct dt_device_node *dt)
>       return;
>   }
>   
> +#if defined (CONFIG_OVERLAY_DTB)
> +int overlay_remove_node(struct dt_device_node *device_node)

This want to be prefixed with dt_* so it is clear which components it is 
touching. But I think all the DT overlay code (including sysctl) should 
be moved in a new file (maybe dt_overlay.c) to spreading the overlay 
code and growing
the size of sysctl.c.

> +{
> +    struct dt_device_node *np;
> +    struct dt_device_node *parent_node;
> +    struct dt_device_node *current_node;
> +
> +    parent_node = device_node->parent;
> +
> +    current_node = parent_node;
> +
> +    if ( parent_node == NULL )
> +    {
> +        dt_dprintk("%s's parent node not found\n", device_node->name);
> +        return -EFAULT;
> +    }
> +
> +    np = parent_node->child;
> +
> +    if ( np == NULL )
> +    {
> +        dt_dprintk("parent node %s's not found\n", parent_node->name);
> +        return -EFAULT;
> +    }
> +
> +    /* If node to be removed is only child node or first child. */
> +    if ( np->name == device_node->name )

Why are you checking the equality between the fields name rather than 
the node itself?

If it is intended, then I think this wants to be explained because often 
people wants to check the names are equal (e.g str*cmp()) rather than 
the pointer where the names are stored.

> +    {
> +        current_node->allnext = np->next;
> +        return 0;
> +    }
> +
> +    for ( np = parent_node->child; np->sibling != NULL; np = np->sibling )
> +    {
> +        current_node = np;
> +        if ( np->sibling->name == device_node->name )

Same question.

> +        {
> +            /* Found the node. Now we remove it. */
> +            current_node->allnext = np->allnext->allnext;
> +
> +            if ( np->sibling->sibling )
> +                current_node->sibling = np->sibling->sibling;
> +            else
> +                current_node->sibling = NULL;
> +
> +            break;
> +        }
> +    }
> +
> +    return 0;
> +}
> +#endif
> +
>   int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>                             struct dt_device_node **node)
>   {
> diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> index f2dab72..fca47f5 100644
> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> @@ -28,6 +28,311 @@
>   #include <xen/livepatch.h>
>   #include <xen/coverage.h>
>   
> +#if defined (CONFIG_OVERLAY_DTB)

This can be shortend to #ifdef CONFIG_<...>.

> +#include <xen/list.h>
> +#include <xen/libfdt/libfdt.h>
> +#include <xen/xmalloc.h>
> +#include <xen/device_tree.h>
> +#include <asm/domain_build.h>
> +#endif
> +
> +#if defined (CONFIG_OVERLAY_DTB)

Same here.

> +static LIST_HEAD(overlay_tracker);
> +static DEFINE_SPINLOCK(overlay_lock);
> +
> +/*
> + * overlay_node_track describes information about added nodes through dtbo.
> + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'.
> + * @node_fullname: Store the name of nodes.
> + * @entry: List pointer.
> + */
> +struct overlay_track {
> +    struct list_head entry;
> +    struct dt_device_node *dt_host_new;
> +    char **node_fullname;
> +    uint8_t num_nodes;

Any reason to restrict to 256 nodes?

> +};
> +
> +/* Basic sanity check for the dtbo tool stack provided to Xen. */
> +static int check_overlay_fdt(void *overlay_fdt, uint32_t overlay_fdt_size)
This function doesn't modify overlay_fdt. So I think it should be const 
if fdt_total_size() and fdt_check_header() allows it.

> +{
> +    if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) ||
> +          fdt_check_header(overlay_fdt) )
> +    {
> +        printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device Tree\n");
> +        return -EINVAL;
> +    }
> +
> +    return 0;
> +}
> +
> +static int overlay_node_count(void *fdto)
> +{
> +    int num_overlay_nodes = 0;

The name suggests this should be an unsiged int.

> +    int fragment;
> +
> +    fdt_for_each_subnode(fragment, fdto, 0)
> +    {
> +
> +        int subnode;
> +        int overlay;
> +
> +        overlay = fdt_subnode_offset(fdto, fragment, "__overlay__");

This may return < 0 if __overlay__ is not found. From my understanding, 
fdt_for_each_subnode() would end up to start from 0.

So I think you want to add a check here.

> +
> +        fdt_for_each_subnode(subnode, fdto, overlay)
> +        {
> +            num_overlay_nodes++;
> +        }
> +    }
> +
> +    return num_overlay_nodes;
> +}
> +
> +/*
> + * overlay_get_node_info will get the all node's full name with path. This is
> + * useful when checking node for duplication i.e. dtbo tries to add nodes which
> + * already exists in device tree.
> + */
> +static void overlay_get_node_info(void *fdto, char ***node_full_path,

You will retrieve mutiple nodes. So I think the function wants to be 
named 'overlay_get_nodes_info()'. Same for node_full_path.

Furthermore, you could drop one * if you return the list of paths. This 
will also allow you to return an error when xmalloc fails (see below)

Lastly, AFAICT, fdto can be const.

> +                                  int num_overlay_nodes)

This coud be unsigned int.

> +{
> +    int fragment;
> +    int node_num = 0;

This could be unsigned int.

> +
> +    *node_full_path = xmalloc_bytes(num_overlay_nodes * sizeof(char *));

Memory allocation can fail.

> +
> +    fdt_for_each_subnode(fragment, fdto, 0)
> +    {
> +        int target;
> +        int overlay;
> +        int subnode;
> +        const char *target_path;
> +
> +        target = fdt_overlay_get_target(device_tree_flattened, fdto, fragment,
> +                                    &target_path);

fdt_overlay_get_target() can fail. Also, the indentation looks strange.

> +        overlay = fdt_subnode_offset(fdto, fragment, "__overlay__");

fdt_subnode_offset can fail.

> +
> +        fdt_for_each_subnode(subnode, fdto, overlay)
> +        {
> +            const char *node_name = fdt_get_name(fdto, subnode, NULL);

AFAIU, fdt_get_name() can return NULL;

> +            int node_name_len = strlen(node_name);

fdt_get_name() can already provide the len for you. Can you re-use it?



> +            int target_path_len = strlen(target_path);
> +            int node_full_name_len = target_path_len + node_name_len + 2;

node_name_len, target_path_len, node_full_name_len can be unsigned. 
Also, I would add a comment explain what '2' refers to.

> +
> +            (*node_full_path)[node_num] = xmalloc_bytes(node_full_name_len);

xmalloc_bytes() can fail.

> +
> +            memcpy((*node_full_path)[node_num], target_path, target_path_len);
> +
> +            (*node_full_path)[node_num][target_path_len] = '/';
> +
> +            memcpy((*node_full_path)[node_num] + target_path_len + 1, node_name,
> +                   node_name_len);
> +
> +            (*node_full_path)[node_num][node_full_name_len - 1] = '\0';
> +
> +            node_num++;
> +        }
> +    }
> +}
> +
> +/*
> + * Checks if all the devices node listed are present in dt_host and used by any
> + * domain.
> + */

Why do we need to handle all the nodes together? I think the code would 
end up to be simpler if we were handling node by node.

> +static int check_nodes(char **full_dt_node_path, uint32_t num_nodes)
> +{
> +    int rc = 0;
> +    unsigned int i;
> +    struct dt_device_node *overlay_node;
> +    uint32_t ret = 0;

AFAICT, you are storing a domid here, so this wants to be a domid_t and 
possible renamed to domid.

> +
> +    for ( i = 0; i < num_nodes; i++ ) {
> +        dt_dprintk("Finding node %s in the dt_host\n", full_dt_node_path[i]);
> +
> +        overlay_node = dt_find_node_by_path(full_dt_node_path[i]);
> +
> +        if ( overlay_node == NULL )
> +        {
> +            rc = -EINVAL;
> +
> +            printk(XENLOG_G_ERR "Device %s is not present in the tree."

You seem to use a mix of XENLOG_G_ERR and XENLOG_ERR. However, it is not 
entirely clear some messages are more critical than the other. Could you 
clarify?

> +                   " Removing nodes failed\n", full_dt_node_path[i]);

Coding style: We don't split error message even if they are more than 80 
lines. This helps grepping them in the log.

> +            return rc;
> +        }
> +
> +        ret = dt_device_used_by(overlay_node);
> +
> +        dt_dprintk("Checking if node %s is used by any domain\n",
> +                   full_dt_node_path[i]);
> +
> +        if ( ret != 0 && ret != DOMID_IO )

In the commit message you wrote:

"The nodes get removed only if it is not used by any of dom0 or domus"

This implies that this should return -EINVAL for domid as well. Can you 
make sure the two matches? (I am not sure which one you want).

Also, what does prevent the device to not be assigned for the check?

> +        {
> +            rc = -EINVAL;

NIT: This is a bit pointless to set rc when it is just used 2 lines 
below in the return. The alternative is to replace the return with a break.

> +
> +            printk(XENLOG_G_ERR "Device %s as it is being used by domain %d."
> +                   " Removing nodes failed\n", full_dt_node_path[i], ret);

Coding style: Same about the error message.

> +            return rc;
> +        }
> +    }
> +
> +    return rc;
> +}
> +
> +/* Remove nodes from dt_host. */
> +static int remove_nodes(char **full_dt_node_path, uint32_t num_nodes)

In the commit message, you said you wanted to remove all the nodes 
together. But this function could possibly fail leaving some nodes 
present or not.

As I wrote above, I think handling node by node would be fine. However, 
we need to make sure that the remove operation can be called again to 
clean-up the rest of the nodes.

> +{
> +    struct domain *d = hardware_domain;
> +    int rc = 0;
> +    struct dt_device_node *overlay_node;
> +    unsigned int naddr;
> +    unsigned int i, j, nirq;
> +    struct dt_raw_irq rirq;
> +    u64 addr, size;
> +
> +    for ( j = 0; j < num_nodes; j++ ) {
> +        dt_dprintk("Removing node: %s\n", full_dt_node_path[j]);
> +
> +        overlay_node = dt_find_node_by_path(full_dt_node_path[j]);
> +
> +        nirq = dt_number_of_irq(overlay_node);
> +
> +        /* Remove IRQ permission */
> +        for ( i = 0; i < nirq; i++ )
> +        {
> +            rc = dt_device_get_raw_irq(overlay_node, i, &rirq);
> +            if ( rc )
> +            {
> +                printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n",
> +                       i, dt_node_full_name(overlay_node));
> +                return rc;
> +            }

The interrupt may not be routed to the GIC, in which case we want to 
skip them. So you want to check the controller is equal to 
dt_interrupt_controller.

The code is also quite similar to handle_device_interrupts(). So I would 
abstract the code to avoid duplication.

That said, I find a bit odd to have to parse the overlay again on remove 
given you expect the same to be passed.  I think it might be better to 
use rangeset to keep track of the interrupts added with that specific 
overlay.

This will reduce the possibility that remove can go wrong.

> +
> +            rc = platform_get_irq(overlay_node, i);
> +            if ( rc < 0 )
> +            {
> +                printk(XENLOG_ERR "Unable to get irq %u for %s\n",
> +                       i, dt_node_full_name(overlay_node));
> +                return rc;
> +            }
> +
> +            rc = irq_deny_access(d, rc);

A few things:

   1) IRQs can be assigned to another domain without the device being 
assigned. So this want to be checked.
   2) This is assuming the IRQ was not shared. I am not entirely sure 
how to solve this one. Maybe a TODO and note in the documentation will 
do for now. Stefano?

> +            if ( rc )
> +            {
> +                printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n",
> +                       i, dt_node_full_name(overlay_node));
> +                return rc;
> +            }
> +        }
> +
> +        rc = iommu_remove_dt_device(overlay_node);
> +        if ( rc != 0 && rc != -ENXIO )
> +            return rc;
> +
> +        naddr = dt_number_of_address(overlay_node);
> +
> +        /* Remove mmio access. */
> +        for ( i = 0; i < naddr; i++ )
> +        {
> +            rc = dt_device_get_address(overlay_node, i, &addr, &size);
> +            if ( rc )
> +            {
> +                printk(XENLOG_ERR "Unable to retrieve address %u for %s\n",
> +                       i, dt_node_full_name(overlay_node));
> +                return rc;
> +            }
> +
> +            rc = iomem_deny_access(d, paddr_to_pfn(addr),
> +                                   paddr_to_pfn(PAGE_ALIGN(addr + size - 1)));

Same remarks as for the interrupts here. Also, this remove the 
permission but not the mappings in the P2M. Is it intended?

> +            if ( rc )
> +            {
> +                printk(XENLOG_ERR "Unable to remove dom%d access to"
> +                        " 0x%"PRIx64" - 0x%"PRIx64"\n",
> +                        d->domain_id,
> +                        addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1);
> +                return rc;
> +            }
> +        }
> +
> +        rc = overlay_remove_node(overlay_node);
> +        if ( rc )
> +            return rc;
> +    }
> +
> +    return rc;
> +}
> +
> +/*
> + * First finds the device node to remove. Check if the device is being used by
> + * any dom and finally remove it from dt_host. IOMMU is already being taken care
> + * while destroying the domain.
> + */
> +static long handle_remove_overlay_nodes(char **full_dt_node_path,
This is an array of nodes name, right? If so, please add a 's' to be 
make it clear.

> +                                        uint32_t num_nodes)

I think num_nodes can simply be unsigned int.

> +{
> +    int rc = 0;
> +    struct overlay_track *entry, *temp, *track;
> +    bool found_entry = false;
> +    unsigned int i;
> +
> +    spin_lock(&overlay_lock);
> +
> +    /*
> +     * First check if dtbo is correct i.e. it should one of the dtbo which was
> +     * used when dynamically adding the node.
> +     */

Technically, you can still pass a dtbo with the same node names but with 
different properties inside.

I am not suggesting to check it, but I think it would be good to explain 
the limitation (this will be important when we decide to 
support/security support it).

> +    list_for_each_entry_safe( entry, temp, &overlay_tracker, entry )
> +    {
> +        /* Checking the num of nodes first. If not same skip to next entry. */
> +        if ( num_nodes == entry->num_nodes )
> +        {
> +            for( i = 0; i < num_nodes; i++ ) {

Coding style:

for ( ... )
{

> +                if( strcmp(full_dt_node_path[i], entry->node_fullname[i]) )

Coding style: Space after 'if'

> +                {
> +                    /* Node name didn't match. Skip to next entry. */
> +                    break;
> +                }
> +            }
> +
> +            /* Found one tracker with all node name matching. */
> +            track = entry;
> +            found_entry = true;
> +            break;
> +        }
> +    }
> +
> +    if ( found_entry == false ) {

Coding style: The { should be on its own line.

> +        rc = -EINVAL;
> +
> +        printk(XENLOG_G_ERR "Cannot find any matching tracker with input dtbo."
> +               " Removing nodes is supported for only prior added dtbo. Please"
> +               " provide a valid dtbo which was used to add the nodes.\n") > +        goto out;
> +
> +    }
> +
> +    rc = check_nodes(full_dt_node_path, num_nodes);
> +
> +    if ( rc )
> +        goto out;
> +
> +    rc = remove_nodes(full_dt_node_path, num_nodes);
> +
> +    if ( rc ) {
> +        printk(XENLOG_G_ERR "Removing node failed\n");
> +        goto out;
> +    }
> +
> +    list_del(&entry->entry);
> +    xfree(entry->node_fullname);
> +    xfree(entry->dt_host_new);
> +    xfree(entry);
> +
> +out:
> +    spin_unlock(&overlay_lock);
> +    return rc;
> +}
> +#endif
> +
>   long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>   {
>       long ret = 0;
> @@ -476,6 +781,73 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl)
>               copyback = 1;
>           break;
>   
> +#if defined (CONFIG_OVERLAY_DTB)
> +    case XEN_SYSCTL_overlay:
> +    {
> +        void *overlay_fdt;
> +        char **node_full_path = NULL;
> +        int num_overlay_nodes;

I think this can be unsigned int.

> +
> +        if ( op->u.overlay_dt.overlay_fdt_size > 0 )
> +            overlay_fdt = xmalloc_bytes(op->u.overlay_dt.overlay_fdt_size);
> +        else
> +        {
> +            ret = -EINVAL;
> +            break;
> +        }

I would re-order the code so the failure case is first. I.e:

if ( op->... <= 0 )
{
    ret = -EINVAL;
    break;
}

overlay_fdt = xmalloc...

> +
> +        if ( overlay_fdt == NULL )
> +        {
> +            ret = -ENOMEM;
> +            break;
> +        }
> +
> +        ret = copy_from_guest(overlay_fdt, op->u.overlay_dt.overlay_fdt,
> +                             op->u.overlay_dt.overlay_fdt_size);
> +        if ( ret )
> +        {
> +            gprintk(XENLOG_ERR, "copy from guest failed\n");

See my remark about the printk() above. I think we need to be consistent 
in how we use it in the overlay code.

> +            xfree(overlay_fdt);
> +
> +            ret = -EFAULT;
> +            break;
> +        }
> +
> +        if ( op->u.overlay_dt.overlay_op == XEN_SYSCTL_DT_OVERLAY_ADD )

The code would be easier to read if you use a switch. However...

> +        {
> +            ret = handle_add_overlay_nodes(overlay_fdt,
> +                                           op->u.overlay_dt.overlay_fdt_size);

... this function doesn't exist. So this will break compilation.

> +        } else if ( op->u.overlay_dt.overlay_op ==
> +                                        XEN_SYSCTL_DT_OVERLAY_REMOVE )
> +        {
> +            ret = check_overlay_fdt(overlay_fdt,
> +                                    op->u.overlay_dt.overlay_fdt_size);
> +            if ( ret )
> +            {
> +                ret = -EFAULT;
> +                break;
> +            }
> +
> +            num_overlay_nodes = overlay_node_count(overlay_fdt);
> +            if ( num_overlay_nodes == 0 )
> +            {
> +                ret = -ENOMEM;
> +                break;
> +            }
> +
> +            overlay_get_node_info(overlay_fdt, &node_full_path,
> +                                  num_overlay_nodes);
> +
> +            ret = handle_remove_overlay_nodes(node_full_path,
> +                                              num_overlay_nodes);
> +        }
> +
> +        xfree(node_full_path);
> +
> +        break;
> +    }
> +#endif
> +
>       default:
>           ret = arch_do_sysctl(op, u_sysctl);
>           copyback = 0;
> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> index 3e53681..6624724 100644
> --- a/xen/include/public/sysctl.h
> +++ b/xen/include/public/sysctl.h
> @@ -1065,6 +1065,25 @@ typedef struct xen_sysctl_cpu_policy xen_sysctl_cpu_policy_t;
>   DEFINE_XEN_GUEST_HANDLE(xen_sysctl_cpu_policy_t);
>   #endif
>   
> +#if defined (CONFIG_OVERLAY_DTB)
> +#define XEN_SYSCTL_DT_OVERLAY_ADD                   1

I would add this one only when it is introduced.

> +#define XEN_SYSCTL_DT_OVERLAY_REMOVE                2

Here you are using XEN_SYSCTL_DT_OVERLAY...

> +
> +/*
> + * XEN_SYSCTL_overlay

... here overlay and...

> + * Performs addition/removal of device tree nodes under parent node using dtbo.
> + * This does in three steps:
> + *  - Adds/Removes the nodes from dt_host.
> + *  - Adds/Removes IRQ permission for the nodes.
> + *  - Adds/Removes MMIO accesses.
> + */
> +struct xen_sysctl_overlay_dt {

... here overlay_dt. For the hypercall, it is important to keep the 
naming consistent. In this case, I would use

* defines:   XEN_SYSCTL_DT_OVERLAY_<...>
* subop:     XEN_SYSCTL_dt_overlay
* structure: xen_sysctl_dt_overlay

> +    XEN_GUEST_HANDLE_64(void) overlay_fdt;
> +    uint32_t overlay_fdt_size;  /* Overlay dtb size. */
> +    uint8_t overlay_op; /* Add or remove. */
> +};
> +#endif
> +
>   struct xen_sysctl {
>       uint32_t cmd;
>   #define XEN_SYSCTL_readconsole                    1
> @@ -1095,6 +1114,7 @@ struct xen_sysctl {
>   #define XEN_SYSCTL_livepatch_op                  27
>   /* #define XEN_SYSCTL_set_parameter              28 */
>   #define XEN_SYSCTL_get_cpu_policy                29
> +#define XEN_SYSCTL_overlay                       30
>       uint32_t interface_version; /* XEN_SYSCTL_INTERFACE_VERSION */
>       union {
>           struct xen_sysctl_readconsole       readconsole;
> @@ -1125,6 +1145,9 @@ struct xen_sysctl {
>   #if defined(__i386__) || defined(__x86_64__)
>           struct xen_sysctl_cpu_policy        cpu_policy;
>   #endif
> +#if defined (CONFIG_OVERLAY_DTB)
> +        struct xen_sysctl_overlay_dt       overlay_dt;
> +#endif
>           uint8_t                             pad[128];
>       } u;
>   };
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index 5ba26a0..cf29cf5 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -553,6 +553,10 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
>    */
>   void dt_print_node_names(struct dt_device_node *dt);
>   
> +#if defined (CONFIG_OVERLAY_DTB)
> +int overlay_remove_node(struct dt_device_node *device_node);
> +#endif
> +
>   /**
>    * dt_get_parent - Get a node's parent if any
>    * @node: Node to get parent

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 17:13:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 17:13:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250892.432119 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n05Az-0006e9-Ma; Wed, 22 Dec 2021 17:13:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250892.432119; Wed, 22 Dec 2021 17:13:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n05Az-0006e2-JH; Wed, 22 Dec 2021 17:13:17 +0000
Received: by outflank-mailman (input) for mailman id 250892;
 Wed, 22 Dec 2021 17:13:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n05Ax-0006ds-MT; Wed, 22 Dec 2021 17:13:15 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n05Ax-0000oZ-J9; Wed, 22 Dec 2021 17:13:15 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n05Ax-0007Se-1K; Wed, 22 Dec 2021 17:13:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n05Ax-0004jD-0v; Wed, 22 Dec 2021 17:13:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=Nf8JajG8epjYugswor8n6oGqlPrMz7dhaiz2GZt7eJM=; b=VBs2tHdiieB7wAS8AzhxagIL1D
	Q+YE8bJqcFnaWqrVSYn9PFhOuOerzSqQAyftu1y1pQ+uEiGwpaFwmO297xBkRDrB03UM8MPKJE9yG
	epwFbRQyMyz90v3Nvsf9H/rcPkWEC241YNLGUzhm17Xovcpr8UBDjq1Knnvh8j6+eGBw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167512-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167512: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=2f47a9a4dfa3674fad19a49b40c5103a9a8e1589
X-Osstest-Versions-That:
    linux=1c3e979bf3e225e5b4b810b24712b16254d608b6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 17:13:15 +0000

flight 167512 linux-linus real [real]
flight 167518 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167512/
http://logs.test-lab.xenproject.org/osstest/logs/167518/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw 13 guest-start         fail pass in 167518-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 167518 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 167518 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167508
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167508
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167508
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167508
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167508
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167508
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167508
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167508
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                2f47a9a4dfa3674fad19a49b40c5103a9a8e1589
baseline version:
 linux                1c3e979bf3e225e5b4b810b24712b16254d608b6

Last test of basis   167508  2021-12-21 18:09:47 Z    0 days
Testing same since   167512  2021-12-22 05:12:53 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Jones <drjones@redhat.com>
  Chuck Lever <chuck.lever@oracle.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Marc Orr <marcorr@google.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  Sean Christopherson <seanjc@google.com>
  Wei Wang <wei.w.wang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   1c3e979bf3e2..2f47a9a4dfa3  2f47a9a4dfa3674fad19a49b40c5103a9a8e1589 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 18:20:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 18:20:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250903.432130 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n06Df-0006OZ-Ta; Wed, 22 Dec 2021 18:20:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250903.432130; Wed, 22 Dec 2021 18:20:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n06Df-0006Nz-QD; Wed, 22 Dec 2021 18:20:07 +0000
Received: by outflank-mailman (input) for mailman id 250903;
 Wed, 22 Dec 2021 18:20:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n06De-0006K8-MV; Wed, 22 Dec 2021 18:20:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n06De-0001xa-K2; Wed, 22 Dec 2021 18:20:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n06De-0001R7-B1; Wed, 22 Dec 2021 18:20:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n06De-00061m-AX; Wed, 22 Dec 2021 18:20:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8Svi1qgLSTGN+XHKIfd0d8MiVm8uWZwBwhzSbDPC6mA=; b=p0K+xSzZDuJmwOdBDTEIPr8KNx
	oKp7rJ9KrZ/iVb7wIH7+NjlASqchaqprG/RlPKzKI/kSFH3mFB+QlC0bcl6YqrwcrrwrMw5b+AeHD
	pyOw5stKZ7oV4Pe8D341nKYyAseS/800DQ0yHDuwyVhBG+GW14nzn5jIW8AjC21/nY18=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167515-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167515: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=8c5f94cd4182753959c8be8de415120dc879d8f0
X-Osstest-Versions-That:
    qemuu=5316e12bb2b4408a1597b283ef4bb4794dd7b4f7
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 18:20:06 +0000

flight 167515 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167515/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167509
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167509
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167509
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167509
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167509
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167509
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167509
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167509
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                8c5f94cd4182753959c8be8de415120dc879d8f0
baseline version:
 qemuu                5316e12bb2b4408a1597b283ef4bb4794dd7b4f7

Last test of basis   167509  2021-12-21 19:38:18 Z    0 days
Testing same since   167515  2021-12-22 07:57:52 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>
  WANG Xuerui <git@xen0n.name>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   5316e12bb2..8c5f94cd41  8c5f94cd4182753959c8be8de415120dc879d8f0 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Wed Dec 22 23:42:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 22 Dec 2021 23:42:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250917.432141 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0BFK-0007qp-Q9; Wed, 22 Dec 2021 23:42:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250917.432141; Wed, 22 Dec 2021 23:42:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0BFK-0007qi-Md; Wed, 22 Dec 2021 23:42:10 +0000
Received: by outflank-mailman (input) for mailman id 250917;
 Wed, 22 Dec 2021 23:42:09 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0BFJ-0007qY-SR; Wed, 22 Dec 2021 23:42:09 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0BFJ-0007KR-OT; Wed, 22 Dec 2021 23:42:09 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0BFJ-0008ER-At; Wed, 22 Dec 2021 23:42:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0BFJ-0002qO-AI; Wed, 22 Dec 2021 23:42:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=X0M4HlNVUmsUWDM7V0BWU4LIcxU4n7u0QO4nzjXa1M8=; b=H1/WEZTDfistfRODFcd+h81hTd
	IxsA+IVQUDuSgNHHX8TZzLCa5Nifd28uatO3L4tmGEzaNdS7CHeRVEg0wqXPxWh/SWFfZsfZthgd3
	cOlm2XfPNfT5+f0uzxA5J29jo2sRVb6B0KhfjLJIjyltUjJ1nbzprjzdxc68vQW+FCa4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167516-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167516: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=8f843cf57202d0db77b31adb8d2ebb93690e91f2
X-Osstest-Versions-That:
    linux=e8ef940326efd17ca7fdd3cb8791c29a24b04f28
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 22 Dec 2021 23:42:09 +0000

flight 167516 linux-5.4 real [real]
flight 167521 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167516/
http://logs.test-lab.xenproject.org/osstest/logs/167521/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 167521-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167521-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167459
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167459
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167459
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167459
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167459
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167459
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167459
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167459
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167459
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167459
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167459
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167459
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                8f843cf57202d0db77b31adb8d2ebb93690e91f2
baseline version:
 linux                e8ef940326efd17ca7fdd3cb8791c29a24b04f28

Last test of basis   167459  2021-12-17 09:41:27 Z    5 days
Testing same since   167516  2021-12-22 08:44:19 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Bee <knaerzche@gmail.com>
  Alex Deucher <alexander.deucher@amd.com>
  Alyssa Ross <hi@alyssa.is>
  Anders Roxell <anders.roxell@linaro.org>
  Arnd Bergmann <arnd@arndb.de>
  Artem Lapkin <art@khadas.com>
  Artem Lapkin <email2tema@gmail.com>
  Baowen Zheng <baowen.zheng@corigine.com>
  Cong Wang <xiyou.wangcong@gmail.com>
  Cyril Novikov <cnovikov@lynx.com>
  D. Wythe <alibuda@linux.alibaba.com>
  Damien Le Moal <damien.lemoal@opensource.wdc.com>
  Daniel Borkmann <daniel@iogearbox.net>
  Daniele Palmas <dnlplm@gmail.com>
  David Ahern <dsahern@kernel.org>
  David S. Miller <davem@davemloft.net>
  Dinh Nguyen <dinguyen@kernel.org>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Douglas Gilbert <dgilbert@interlog.com>
  Dust Li <dust.li@linux.alibaba.com>
  Eric Dumazet <edumazet@google.com>
  Fabio Estevam <festevam@gmail.com>
  Fabrice Gasnier <fabrice.gasnier@foss.st.com>
  Felix Fietkau <nbd@nbd.name>
  Florian Fainelli <f.fainelli@gmail.com>
  Gal Pressman <gal@nvidia.com>
  Gaosheng Cui <cuigaosheng1@huawei.com>
  George Kennedy <george.kennedy@oracle.com>
  George Kennedy<george.kennedy@oracle.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Haimin Zhang <tcs.kernel@gmail.com>
  Hangbin Liu <liuhangbin@gmail.com>
  Hangyu Hua <hbh25y@gmail.com>
  Hawking Zhang <Hawking.Zhang@amd.com>
  Heiko Carstens <hca@linux.ibm.com>
  Heiko Stuebner <heiko@sntech.de>
  Hulk Robot <hulkrobot@huawei.com>
  J. Bruce Fields <bfields@redhat.com>
  Jakub Kicinski <kuba@kernel.org>
  Jamal Hadi Salim <jhs@mojatatu.com>
  Jason Wang <jasowang@redhat.com>
  Jerome Marchand <jmarchan@redhat.com>
  Jie2x Zhou <jie2x.zhou@intel.com>
  Jimmy Wang <wangjm221@gmail.com>
  Jiri Pirko <jiri@mellanox.com>
  Joe Thornber <ejt@redhat.com>
  Johan Hovold <johan@kernel.org>
  Johannes Berg <johannes.berg@intel.com>
  John Keeping <john@metanate.com>
  Jon Hunter <jonathanh@nvidia.com>
  Jonathan Cameron <Jonathan.Cameron@huawei.com>
  Juergen Gross <jgross@suse.com>
  Kalle Valo <kvalo@codeaurora.org>
  Karen Sornek <karen.sornek@intel.com>
  Karsten Graul <kgraul@linux.ibm.com>
  Konrad Jankowski <konrad0.jankowski@intel.com>
  Le Ma <le.ma@amd.com>
  Leon Romanovsky <leonro@nvidia.com>
  Letu Ren <fantasquex@gmail.com>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Luca Coelho <luciano.coelho@intel.com>
  Maarten Brock <m.brock@vanmierlo.com>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Marco Elver <elver@google.com>
  Martin K. Petersen <martin.petersen@oracle.com>
  Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  Michael S. Tsirkin <mst@redhat.com>
  Mike Snitzer <snitzer@redhat.com>
  Mike Tipton <quic_mdtipton@quicinc.com>
  Miklos Szeredi <mszeredi@redhat.com>
  Mordechay Goodstein <mordechay.goodstein@intel.com>
  Nathan Chancellor <natechancellor@gmail.com>
  Nathan Chancellor <nathan@kernel.org>
  Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@amd.com>
  Paolo Bonzini <pbonzini@redhat.com>
  Paul E. McKenney <paulmck@kernel.org>
  Paul Moore <paul@paul-moore.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Philipp Rudo <prudo@redhat.com>
  Salvatore Bonaccorso <carnil@debian.org>
  Sasha Levin <sashal@kernel.org>
  Sean Christopherson <seanjc@google.com>
  Sean Young <sean@mess.org>
  Shawn Guo <shawnguo@kernel.org>
  Shuah Khan <skhan@linuxfoundation.org>
  Simon Horman <simon.horman@corigine.com>
  Stefan Roese <sr@denx.de>
  Stephen Boyd <sboyd@kernel.org>
  Steven Price <steven.price@arm.com>
  Steven Rostedt (VMware) <rostedt@goodmis.org>
  Sudeep Holla <sudeep.holla@arm.com>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Suzuki K Poulose <suzuki.poulose@arm.com>
  Thierry Reding <treding@nvidia.com>
  Thomas Gleixner <tglx@linutronix.de>
  Toke Høiland-Jørgensen <toke@toke.dk>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vinod Koul <vkoul@kernel.org>
  Vitaly Kuznetsov <vkuznets@redhat.com>
  Vlad Buslov <vladbu@mellanox.com>
  Will Deacon <will@kernel.org>
  Willem de Bruijn <willemb@google.com>
  Yu Liao <liaoyu15@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e8ef940326ef..8f843cf57202  8f843cf57202d0db77b31adb8d2ebb93690e91f2 -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 02:23:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 02:23:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250928.432162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlT-0003bo-D8; Thu, 23 Dec 2021 02:23:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250928.432162; Thu, 23 Dec 2021 02:23:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlT-0003bh-AC; Thu, 23 Dec 2021 02:23:31 +0000
Received: by outflank-mailman (input) for mailman id 250928;
 Thu, 23 Dec 2021 02:23:30 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yk4J=RI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0DlS-0003au-Bq
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 02:23:30 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4f4118f5-6397-11ec-9e60-abaf8a552007;
 Thu, 23 Dec 2021 03:23:28 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id C96AA61D1B;
 Thu, 23 Dec 2021 02:23:25 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED9C4C36AE8;
 Thu, 23 Dec 2021 02:23:24 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4f4118f5-6397-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640226205;
	bh=9/N5xzR7KFKO8jl3ngfgXQLjnAZhY4zvphVIIrOleSE=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=raq3KEyCFxAbqqzVH5h5fyOWRsfDQZHMbPT0reFZsb72qfl/X2xA0SLZrUImFMObP
	 TxqA2TVzHMDjC+wwnbvvWJTPw3Yo2B5+7+kWZqAiy5srBOd2Bgts1n1KWPMW2aNdXM
	 dk2h2QbJa5JDSmHBWuY0GLc0P+WmdOwTaE0TJDRsKRFTihL5BnnCPEcKDX9SBq3gfb
	 7uU1UfV12YsR/cxCepr1ahmvTGj9WPaD9jhccCKeDyNAhNx4eWL8LKWFEw2l5w095N
	 GW/ATygRoX5OpZhWywesga19FE1G1QXolxNY9U5kNrAKDEEOSi3zcJZi12K5VOnNm1
	 MrFQ52aiD9WXw==
Date: Wed, 22 Dec 2021 18:23:24 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20211222110414.GA2883815@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com> <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop> <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop> <20211221200305.GA2460476@EPUAKYIW015D> <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop> <20211222110414.GA2883815@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
> > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> > > Hi Stefano,
> > > 
> > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > > > Hi Stefano,
> > > > > 
> > > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > This is the implementation of SCI interface, called SCMI-SMC driver,
> > > > > > > which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> > > > > > > This allows devices from the Domains to work with clocks, resets and
> > > > > > > power-domains without access to CPG.
> > > > > > > 
> > > > > > > The following features are implemented:
> > > > > > > - request SCMI channels from ATF and pass channels to Domains;
> > > > > > > - set device permissions for Domains based on the Domain partial
> > > > > > > device-tree. Devices with permissions are able to work with clocks,
> > > > > > > resets and power-domains via SCMI;
> > > > > > > - redirect scmi messages from Domains to ATF.
> > > > > > > 
> > > > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > ---
> > > > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
> > > > > > >  xen/include/public/arch-arm.h |   1 +
> > > > > > >  5 files changed, 809 insertions(+)
> > > > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > > > 
> > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > > > > index 186e1db389..02d96c6cfc 100644
> > > > > > > --- a/xen/arch/arm/Kconfig
> > > > > > > +++ b/xen/arch/arm/Kconfig
> > > > > > > @@ -114,6 +114,8 @@ config SCI
> > > > > > >  	  support. It allows guests to control system resourcess via one of
> > > > > > >  	  SCI mediators implemented in XEN.
> > > > > > >  
> > > > > > > +source "arch/arm/sci/Kconfig"
> > > > > > > +
> > > > > > >  endmenu
> > > > > > >  
> > > > > > >  menu "ARM errata workaround via the alternative framework"
> > > > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > > > > > > new file mode 100644
> > > > > > > index 0000000000..9563067ddc
> > > > > > > --- /dev/null
> > > > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > > > @@ -0,0 +1,10 @@
> > > > > > > +config SCMI_SMC
> > > > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > > > +	default n
> > > > > > > +	depends on SCI
> > > > > > > +	---help---
> > > > > > > +
> > > > > > > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> > > > > > > +	This feature allows drivers from Domains to work with System
> > > > > > > +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> > > > > > > +	for communication.
> > > > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > > > > > > index 837dc7492b..67f2611872 100644
> > > > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > > > @@ -1 +1,2 @@
> > > > > > >  obj-y += sci.o
> > > > > > > +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> > > > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > new file mode 100644
> > > > > > > index 0000000000..2eb01ea82d
> > > > > > > --- /dev/null
> > > > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > @@ -0,0 +1,795 @@
> > > > > > > +/*
> > > > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > > > + *
> > > > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > > > + *
> > > > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > > > + *
> > > > > > > + * This program is free software; you can redistribute it and/or modify
> > > > > > > + * it under the terms of the GNU General Public License as published by
> > > > > > > + * the Free Software Foundation; either version 2 of the License, or
> > > > > > > + * (at your option) any later version.
> > > > > > > + *
> > > > > > > + * This program is distributed in the hope that it will be useful,
> > > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > > > + * GNU General Public License for more details.
> > > > > > > + */
> > > > > > > +
> > > > > > > +#include <asm/sci/sci.h>
> > > > > > > +#include <asm/smccc.h>
> > > > > > > +#include <asm/io.h>
> > > > > > > +#include <xen/bitops.h>
> > > > > > > +#include <xen/config.h>
> > > > > > > +#include <xen/sched.h>
> > > > > > > +#include <xen/device_tree.h>
> > > > > > > +#include <xen/iocap.h>
> > > > > > > +#include <xen/init.h>
> > > > > > > +#include <xen/err.h>
> > > > > > > +#include <xen/lib.h>
> > > > > > > +#include <xen/list.h>
> > > > > > > +#include <xen/mm.h>
> > > > > > > +#include <xen/string.h>
> > > > > > > +#include <xen/time.h>
> > > > > > > +#include <xen/vmap.h>
> > > > > > > +
> > > > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > > > +
> > > > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > > > > > > +#define SCMI_SUCCESS              0
> > > > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > > > +#define SCMI_DENIED             (-3)
> > > > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > > > +#define SCMI_BUSY               (-6)
> > > > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > > > +
> > > > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > > > > > +
> > > > > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > > > > > 
> > > > > > I could find the following SCMI binding in Linux, which describes
> > > > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > > > 
> > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > 
> > > > > > However, linux,scmi_mem is not described. Aren't you supposed to read
> > > > > > the "shmem" property instead? And the compatible string used for this
> > > > > > seems to be "arm,scmi-shmem".
> > > > > > 
> > > > > 
> > > > > We use linux,scmi_mem node to reserve memory, needed for all
> > > > > channels:
> > > > > 
> > > > > reserved-memory {
> > > > >     /* reserved region for scmi channels*/
> > > > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > > > >         no-map;
> > > > >         reg = <0x0 0x53FF0000 0x0 0x10000>;
> > > > >     };
> > > > > };
> > > > > 
> > > > > arm,scmi-shmem node used in shmem property defines only 1 page needed to
> > > > > the current scmi channel:
> > > > > 
> > > > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > > > >     compatible = "arm,scmi-shmem";
> > > > >     reg = <0x0 0x53FF0000 0x0 0x1000>;
> > > > > };
> > > > > 
> > > > > For each Domain reg points to unigue page from linux,scmi_mem region,
> > > > > assigned to this agent.
> > > > 
> > > > If we were to use "linux,scmi_mem" we would have to introduce it as a
> > > > compatible string, not as a node name, and it would need to be described
> > > > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > > > 
> > > > But from your description I don't think it is necessary. We can just use
> > > > "arm,scmi-shmem" to describe all the required regions:
> > > > 
> > > > reserved-memory {
> > > >     scp-shmem@0x53FF0000 {
> > > >         compatible = "arm,scmi-shmem";
> > > >         reg = <0x0 0x53FF0000 0x0 0x1000>;
> > > >     };
> > > >     scp-shmem@0x53FF1000 {
> > > >         compatible = "arm,scmi-shmem";
> > > >         reg = <0x0 0x53FF1000 0x0 0x1000>;
> > > >     };
> > > >     scp-shmem@0x53FF2000 {
> > > >         compatible = "arm,scmi-shmem";
> > > >         reg = <0x0 0x53FF2000 0x0 0x1000>;
> > > >     };
> > > >     ...
> > > > 
> > > > In other words, if all the individual channel pages are described as
> > > > "arm,scmi-shmem", why do we also need a single larger region as
> > > > "linux,scmi_mem"?
> > > > 
> > > 
> > > That was my first implementation. But I've met a problem with
> > > scmi driver in kernel. I don't remember the exact place, but I remember
> > > there were some if, checking if memory weren't reserved.
> > > That's why I ended up splitting nodes reserved memory region and actual
> > > shmem page.
> > > For linux,scmi_mem node I took format from /reserved-memory/linux,lossy_decompress@54000000,
> > > which has no compatible string and provides no-map property.
> > > linux,scmi_shmem node is needed to prevent xen from allocating this
> > > space for the domain.
> > > 
> > > Very interesting question about should I introduce linux,scmi_mem node
> > > and scmi_devid property to the
> > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> > > Those node and property are needed only for Xen and useless for
> > > non-virtualized systems. I can add this node and property description to
> > > arm,scmi.yaml, but leave a note that this is Xen specific params.
> > > What do you think about it?
> > 
> > Reply below
> > 
> > [...]
> >  
> > 
> > > > In general we can't use properties that are not part of the device tree
> > > > spec, either https://urldefense.com/v3/__https://www.devicetree.org/specifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXloYUaj$ [git[.]kernel[.]org]
> > > > 
> > > > "linux,scmi_mem" is currently absent. Are you aware of any upstreaming
> > > > activities to get "linux,scmi_mem" upstream under
> > > > Documentation/devicetree/bindings in Linux?
> > > > 
> > > > If "linux,scmi_mem" is going upstream in Linux, then we could use it.
> > > > Otherwise, first "linux,scmi_mem" needs to be added somewhere under
> > > > Documentation/devicetree/bindings (probably
> > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we can
> > > > work on the Xen code that makes use of it.
> > > > 
> > > > Does it make sense?
> > > > 
> > > 
> > > Yes I agree. I think linux,scmi_mem and scmi_devid should be upstreamed.
> > > I will add those properties to arm,scmi.yaml, mark them as related to XEN and send patch.
> > 
> > I didn't realize that linux,scmi_mem and scmi_devid are supposed to be
> > Xen specific. In general, it would be best not to introduce Xen specific
> > properties into generic bindings. It is a problem both from a
> > specification perspective (because it has hard to handle Xen specific
> > cases in fully generic bindings, especially as those bindings are
> > maintained as part of the Linux kernel) and from a user perspective
> > (because now the user has to deal with a Xen-specific dtb, or has to
> > modify the host dtb to add Xen-specific information by hand.)
> > 
> > 
> > Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? It
> > looks like a generic property that should be needed for the Linux SCMI
> > driver too. Why the Linux driver doesn't need it?
> > 
> 
> scmi_devid used during domain build. It passed as input parameter for SCMI_BASE_SET_DEVICE_PERMISSIONS message.
> On non-virtualized systems - there is no need of this call, because OS
> is the only one entity, running on the system.

OK. Even if it is only required for virtualized systems, I think that
scmi_devid is important enough that should be part of the upstream
binding. I think it is worth starting an email thread on the LKML with
Rob Herring and the SCMI maintainers to discuss the addition of
scmi_devid to the binding.


> I've chatted with Volodymyr_Babchuk and he gave a great idea to add a
> list of device_ids to dom.cfg, such as:
> sci_devs = [ 0, 1, 15, 35 ];
> 
> Using this approach, we can remove scmi_devid from the device tree and
> just pass a list of scmi_devids to XEN using additional hypercall.
> We can probably make hypercall taking devid list as input parameter.
> This will take only 1 hypercall to setup sci permissions.

But how would a user know which are the right SCMI IDs to add to the
sci_devs list? Would the user have to go and read the reference manual
of the platform to find the SCMI IDs and then write sci_devs by hand?
If that is the case, then I think that it would be better to add
scmi_devid to device tree.

In general, I think this configuration should happen automatically
without user intervention. The user should just specify "enable SCMI"
and it should work.


> > In regards to linux,scmi_mem, I think it would be best to do without it
> > and fix the Linux SCMI driver if we need to do so. Xen should be able to
> > parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) should
> > be able to parse the "arm,scmi-shmem" nodes generated by Xen. Either
> > way, I don't think we should need linux,scmi_mem.
> 
> This requires further investigation. I will try to make implementation
> without linux,scmi_mem, using only arm,scmi-shmem nodes and share
> reuslts with you.

OK, thanks.


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 02:23:48 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 02:23:48 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250929.432174 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlZ-0003xH-Rx; Thu, 23 Dec 2021 02:23:37 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250929.432174; Thu, 23 Dec 2021 02:23:37 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlZ-0003x8-OD; Thu, 23 Dec 2021 02:23:37 +0000
Received: by outflank-mailman (input) for mailman id 250929;
 Thu, 23 Dec 2021 02:23:36 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yk4J=RI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0DlY-0003Ju-BP
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 02:23:36 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54c3aab4-6397-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 03:23:35 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 293B5B81F48;
 Thu, 23 Dec 2021 02:23:35 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A87CAC36AE8;
 Thu, 23 Dec 2021 02:23:33 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54c3aab4-6397-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640226214;
	bh=33rgWlcYdNSQjeG2Heew0TNj0Tq69gnqNHVs9FbW+fY=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=ZJitwKg7MkixQi/2E9J6CalneQxMDZ+2P6c7NGJICoFi2ovqEHLVXfSjOixGYy405
	 J8D9I0I8feTutSU01mSrMNFadeeUR+bTD+8GfMMxrqFvHsoJ4EqbFygP+yJEwMTjO2
	 TMJ78WrLOO3BbOUdbxpkUgO/IbMCNqm3TU4BEakaf5HrdU3K+J1jHcd9HA7D0bidhn
	 MOd11nDZV0gDNxKPO0IpRfpymyJsyzLBvv2BtBOendy1tGW/pegzHIFuHAtTIQSBRG
	 cJOMv5UoJNtH+cSgtWd7buwoKYVDLq/Bsm5rUmO6o0YdhE5KLr4BGjzBu3RlR0Sd9B
	 9ygqT/ch8dL3g==
Date: Wed, 22 Dec 2021 18:23:33 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>, 
    Juergen Gross <jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
In-Reply-To: <20211222102417.GA2882292@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2112221633000.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com> <alpine.DEB.2.22.394.2112201653500.2060010@ubuntu-linux-20-04-desktop>
 <20211222102417.GA2882292@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> On Mon, Dec 20, 2021 at 04:54:25PM -0800, Stefano Stabellini wrote:
> > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > This enumeration sets SCI type for the domain. Currently there is
> > > two possible options: either 'none' or 'scmi_smc'.
> > > 
> > > 'none' is the default value and it disables SCI support at all.
> > > 
> > > 'scmi_smc' enables access to the Firmware from the domains using SCMI
> > > protocol and SMC as transport.
> > > 
> > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > ---
> > >  docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
> > >  tools/include/libxl.h            |  5 +++++
> > >  tools/libs/light/libxl_types.idl |  6 ++++++
> > >  tools/xl/xl_parse.c              |  9 +++++++++
> > >  4 files changed, 42 insertions(+)
> > > 
> > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > > index b98d161398..92d0593875 100644
> > > --- a/docs/man/xl.cfg.5.pod.in
> > > +++ b/docs/man/xl.cfg.5.pod.in
> > > @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
> > >  
> > >  =back
> > >  
> > > +=item B<sci="STRING">
> > > +
> > > +B<Arm only> Set SCI type for the guest. SCI is System Control Protocol -
> > > +allows domain to manage various functions that are provided by HW platform.
> > > +
> > > +=over 4
> > > +
> > > +=item B<none>
> > > +
> > > +Don't allow guest to use SCI if present on the platform. This is the default
> > > +value.
> > > +
> > > +=item B<scmi_smc>
> > > +
> > > +Enables SCMI-SMC support for the guest. SCMI is System Control Management
> > > +Inferface - allows domain to manage various functions that are provided by HW
> > > +platform, such as clocks, resets and power-domains. Xen will mediate access to
> > > +clocks, power-domains and resets between Domains and ATF. Disabled by default.
> > > +SMC is used as transport.
> > 
> > Would it make sense to actually enable SCMI-SMC support for the guest by
> > default if the guest has any devices directly assigned?
> 
> Hi Stefano,
> 
> Previously we discussed with Oleksandr about introducing new dom.cfg
> parameter, such as scidev[] lists all sci related nodes, which will help to
> avoid extra domctl calls.

The concerning part is (too much) information the user needs to provide
in device tree or dom.cfg. We can be flexible with the number of extra
domctl calls, but of course it would be good to avoid them too.


> But there is still a question how mediator types should be set for
> different domains? I know currently system supports only one mediator
> type, but different implementation should be also possible.

I think it is fine to have an option sci="scmi_smc" in dom.cfg, that is
not a problem. The issue is a detailed list of SCMI IDs or a second list
of device tree paths, because those are far harder to write correctly.


> For example, if we have to start dom0 and domd using scmi_mailbox
> mediator and domU using scmi_smc, because our system supports only 2
> mailboxes.

Yeah that's fine, it could be done with the sci option you are
suggesting.


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 02:23:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 02:23:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250927.432152 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlK-0003KR-8f; Thu, 23 Dec 2021 02:23:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250927.432152; Thu, 23 Dec 2021 02:23:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0DlK-0003K0-20; Thu, 23 Dec 2021 02:23:22 +0000
Received: by outflank-mailman (input) for mailman id 250927;
 Thu, 23 Dec 2021 02:23:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yk4J=RI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0DlJ-0003Ju-2O
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 02:23:21 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 4a273174-6397-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 03:23:18 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 7A333B81F48;
 Thu, 23 Dec 2021 02:23:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F982C36AE5;
 Thu, 23 Dec 2021 02:23:14 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4a273174-6397-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640226195;
	bh=I4V/2KspmrQvTn48nYH6aryOG5r8w4HrUqrc4S1NOXs=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Oyp1FJSQcU+52D5iyEUyzYaVj2fhbypmpZmfmHqNM2tszkV2wX4hG17piEVXmn5kL
	 CT0ZSw7OY8QbOo2BZurjy3vpq9SJE2pAf5mrEfo1O6YpmwBFnDwj/rajnolOZx6+52
	 KNnwhRTB4Wxw8vzyRnFJ7APRhZbsipWH2TjI75QaDyALysXV8hEq18wDJn2ELK13lY
	 ezVNTG+R3SuvaJPCCSt3uTvTx/Yq7uZ6lFFt33U9YgsSNI0X4kX1WNZBB6VsX0PzpT
	 dFMq5OERdXKKVs14VvBPbkKGIVkIBnC9S0YNrNt8TYUIK72LALyhPxTq4a7k946dYZ
	 4DbKAT+Bw0/Jw==
Date: Wed, 22 Dec 2021 18:23:13 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Stefano Stabellini <sstabellini@kernel.org>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
In-Reply-To: <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com> <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com> <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop> <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com> <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org> <87ee64x1hf.fsf@epam.com>
 <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Julien Grall wrote:
> > > > > > To me dtdev and XEN_DOMCTL_assign_device are appropriate because
> > > > > > they
> > > > > > signify device assignment of one or more devices. We are not adding
> > > > > > any
> > > > > > additional "meaning" to them. It is just that we'll automatically
> > > > > > detect
> > > > > > and generate any SCMI configurations based on the list of assigned
> > > > > > devices. Because if SCMI is enabled and a device is assigned to the
> > > > > > guest, then I think we want to add the device to the SCMI list of
> > > > > > devices automatically.
> > > > > 
> > > > > I am OK with re-using dtdev/XEN_DOMCTL_assign_device however there is
> > > > > a pitfall with that approach.
> > > > > 
> > > > > At the moment, they are only used for device protected by the
> > > > > IOMMU. If the device is not protected by the IOMMU then it will return
> > > > > an error.
> > > > IIRC there was a change, that allowed to assign device without a
> > > > IOMMU. At
> > > > least we discussed this internally.
> > > 
> > > I am not aware of any upstream. Do you have a pointer if there is any
> > > public discussion?
> > 
> > No, this is the first public discussion on this topic.
> > 
> > > 
> > > > > 
> > > > > Now, with your approach we may have a device that is not protected by
> > > > > the IOMMU but require to a SCMI configuration.
> > > > You need to protect only DMA-capable devices.
> > > 
> > > Xen doesn't know if the device is DMA-capable or not. So...
> > > 
> > 
> > But it knows if there is a iommus=<> node present for the device.
> 
> Not really. Not all the platforms have IOMMUs and not all the platforms with
> IOMMU have DMA-capable device protected by an IOMMU.
> 
> > 
> > > > 
> > > > > I don't think it would be sensible to just return "succeed" here
> > > > > because technically you are asking to assign a non-protected
> > > > > device. But at the same time, it would prevent a user to assign a
> > > > > non-DMA capable device.
> > > > > 
> > > > > So how do you suggest to approach this?
> > > > Well, in my head assign_device ideally should do the following:
> > > > 1. Assign IOMMU if it is configured for the device
> > > 
> > > ... with this approach you are at the risk to let the user passthrough
> > > a device that cannot be protected.
> > > 
> > > > 2. Assign SCMI access rights
> > > > (Not related to this patch series, but...)
> > > > 3. Assign IRQs
> > > > 4. Assign IO memory ranges.
> > > > Points 3. and 4. would allow us to not provide additional irq=[] and
> > > > iomem=[] entries in a guest config.
> > > 
> > > That could only work if your guest is using the same layout as the
> > > host.
> > 
> > Agreed. But in my experience, in most cases this is the true. We worked
> > with Renesas and IMX hardware and in both cases iomems were
> > mapped 1:1.
> > 
> > > Otherwise, there is a risk it will clash with other parts of the
> > > memory layout.
> > > 
> > 
> > > Today, guests started via the toolstack is only using a virtual
> > > layout, so you would first need to add support to use the host memory
> > > layout.
> > 
> > I can't say for all the possible configurations in the wild, but I'm
> > assuming that in most cases it will be fine to use 1:1 mapping. For
> > those more exotic cases it would be possible to implement some
> > configuration option like iomem_map=[mfn:gfn].
> Well, the Xen memory layout is not something that is stable nor AFAIK based on
> any memory layout. In fact, there is no such generic layout on Arm.
> 
> It is quite possible that it will work well with 1:1 MMIO on some platform
> (e.g. Renesas, IMX) but you can't expect to work for every Xen release or all
> the platforms.

Yeah this is a true problem. Thankfully with Penny's series we'll be
able to create domUs with the host memory layout (although dom0less
only but it is a step forward).

 
> > As Stefano pointed, right now user needs to provide 3 configuration
> > options to pass a device to a guest: dt_dev, irq, iomem. But in fact,
> > Xen is already knowing about irq and iomem from device tree.
> 
> I understand and this is not ideal. I would be happy to consider your
> approach. However, this will have to enabled only when the guest is re-using
> the host layout.

It looks like we all agree that today configuring device assignment with
Xen is too complicated and would like for it to be simpler. This thread
has some excellent ideas on how to address the issue. Skip to the end if
you are only interested in this patch series.


# Future Ideas

A great suggestion by Julien is to start supporting the dom0less partial
device tree format in xl/libxl as well so that we can have a single
"device_tree" option in dom.cfg instead of 4 (device_tree, iomem, irqs,
dtdev).

Even with that implemented, the user has still to provide a partial dtb,
xen,reg and xen,path. I think this is a great step forward and we should
do that, if nothing else to make it easier to switch between dom0less
and normal domU configurations. But the number of options and
information that the user has to provide is still similar to what we
have today.

After that, I think we need something along the lines of what Volodymyr
suggested. Let's say that the user only provides "dtdev" and
"device_tree" in dom.cfg.  We could:

- read interrupts from the  "interrupts" property like we do for dom0less
- read "xen,reg" for the mapping, if "xen,reg" is missing, read "reg"
  and assume 1:1 (we could try the mapping and print an error on
  failure, or we could only do 1:1 if the domain is entirely 1:1)
- optionally read "xen,path" to populate dtdev
- if an IOMMU configuration is present, then also configure the IOMMU
  for the device, if not then "xen,force-assign-without-iommu" must be
  present
- assign SCMI access rights


Now we only have:
- device_tree in dom.cfg
- dtdev in dom.cfg (or xen,path in the partial DTB)
- xen,force-assign-without-iommu in the partial DTB


It would be good if we could remove "xen,force-assign-without-iommu"
because at this stage it is the only Xen-specific property remaining in
the partial DTB. If we could get rid of it, it would make it easier to
write/generate the partial DTB because it becomes a strict subset of the
corresponding host node. It would enable us to automatically generate it
(we are going to do experiments with it at Xilinx in the next few
months) and it would be easier to explain to users how to write it.
The partial DTB usually starts as a copy of the corresponding host node
plus some edits. The fewer edits are required, the better.

But it is difficult because of the reasons mentioned by Julien. In Xen
we cannot know if a device is not behind an IOMMU because is not a DMA
master (so safe to assign) or because the system simply doesn't have
enough IOMMU coverage (so not safe to assign). Thankfully the hardware
has been improving in recent years and there are more and more platforms
with full IOMMU coverage. I think we should make it easier for users on
these well-behave platforms.

At least, we could move the "xen,force-assign-without-iommu" option from
the partial DTB to the VM config file dom.cfg. Something like:

force-assign-without-iommu="true"
or
platform-iommu-safe="true"

That way, it is global rather than per-device and doesn't have to be
added by the user by hand when creating the partial DTB.


# This patch series

Now in regards to this specific series and the SCMI options today, I
think it is OK to have a per-domain sci="scmi_smc", but I think we
should try to avoid another detailed list of device paths or list of
IDs in addition to dtdev.

dtdev already specifies the device tree nodes to be assigned to the
guest. Based on that list we can also do SCMI assignment.

As Julien pointed out, the issue is: what if a device needs SCMI
assignment but is not a DMA master (hence there is no IOMMU
configuration on the host)?

Attempting to assign a DMA mastering device without IOMMU protection is
not just unsafe, it will actively cause memory corruptions in most
cases. It is an erroneous configuration.

Of course we should try to stop people from running erroneous
configurations, but we should do so without penalizing all users.

With that in mind, also considering that dtdev is the list of devices to
be assigned, I think dtdev should be the list of all devices, even
non-DMA masters. It makes a lot of sense also because today is really
difficult to explain to a user that "yes, dtdev is the devices to be
assigned but no, if the device is a UART you don't have to add it to
dtdev because it is not a DMA master". It would be a lot easier if the
list of assigned devices was comprehensive, including both DMA masters
and not DMA masters.

So I think we should either:

a) extend dtdev to cover all devices, including non-DMA masters
b) or add a new "device_assignment" property which is like dtdev but is
   the list of both DMA masters and non-DMA masters

Either way, when non-DMA masters are present in the
dtdev/device_assignment list we could either:
    c) require force-assign-without-iommu="true" in dom.cfg
    d) or print a warning like:
    "WARNING: device assignment safety for device XXX cannot be
    verified. Please make sure XXX is not a DMA mastering device."


All these options are good I think. My preference is a) + d), so extend
dtdev and print a warning if non-DMA masters are in the list. We don't
necessarily need a new hypercall but that is also an option.

I think this discussion was a long time coming and I am glad we are
having it now. We have a lot of room for improvement! I don't want to
scope-creep this patch series, but I hope that this last bit could be
done as part of this series if we find agreement in the community.


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 02:50:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 02:50:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250940.432185 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0EAg-0007ZG-SO; Thu, 23 Dec 2021 02:49:34 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250940.432185; Thu, 23 Dec 2021 02:49:34 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0EAg-0007Z9-PB; Thu, 23 Dec 2021 02:49:34 +0000
Received: by outflank-mailman (input) for mailman id 250940;
 Thu, 23 Dec 2021 02:49:34 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EAg-0007Yz-A5; Thu, 23 Dec 2021 02:49:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EAg-0004eS-7E; Thu, 23 Dec 2021 02:49:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EAf-000610-Qk; Thu, 23 Dec 2021 02:49:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EAf-0006qH-Q0; Thu, 23 Dec 2021 02:49:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kgQQZg5tAp3WmjniCaMEIbLjhlsAq4GQp+TjlSE7GqI=; b=WDTZEYjlvUFVBRQ+xTczreeQKQ
	r/GAN3k2h0cestiWwnWLJjkkNsVfrQf3+BX1ISvXUSSR4i870nyvD4JgVziWAZglT82rL4aH3QsSu
	IsRHZJZf+s8ZEoeL5ItQuMTx+Zs/fEpLdWY3uy+cB+NqxhjVhO6mLLD+YnW9PMBVwtvo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167519-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167519: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=8d29feca838bce06473616168b6d5c0b35b96c94
X-Osstest-Versions-That:
    qemuu=8c5f94cd4182753959c8be8de415120dc879d8f0
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 02:49:33 +0000

flight 167519 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167519/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167515
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167515
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167515
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167515
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167515
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167515
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167515
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167515
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                8d29feca838bce06473616168b6d5c0b35b96c94
baseline version:
 qemuu                8c5f94cd4182753959c8be8de415120dc879d8f0

Last test of basis   167515  2021-12-22 07:57:52 Z    0 days
Testing same since   167519  2021-12-22 18:38:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jason Wang <jasowang@redhat.com>
  Laurent Vivier <lvivier@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Thomas Huth <thuth@redhat.com>
  Zhang Chen <chen.zhang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   8c5f94cd41..8d29feca83  8d29feca838bce06473616168b6d5c0b35b96c94 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 03:39:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 03:39:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250948.432196 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0EwR-0004uA-Jp; Thu, 23 Dec 2021 03:38:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250948.432196; Thu, 23 Dec 2021 03:38:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0EwR-0004u3-Gp; Thu, 23 Dec 2021 03:38:55 +0000
Received: by outflank-mailman (input) for mailman id 250948;
 Thu, 23 Dec 2021 03:38:53 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EwP-0004tt-UE; Thu, 23 Dec 2021 03:38:53 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EwP-0005V3-SX; Thu, 23 Dec 2021 03:38:53 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EwP-0000YB-JO; Thu, 23 Dec 2021 03:38:53 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0EwP-00009R-Is; Thu, 23 Dec 2021 03:38:53 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=x6gJ+RcOmlsHTbU4APAD7yHLngIaMeW6xVbmRE2i6Vc=; b=anOZvW4xpJZeaoN0ku7CA7QI+i
	wzBccsaJX8tz1VK0gkKfrzx+aYLa2hnFI0Jhya701EY4yI9bXVRXNclJ7oRKo6gc4yP6EN8f2e/cz
	BX/LpIVhLnxQLEhf6i+/2sn8LpTAv6eDIctmBA4ORPKFa2gbXZ7BDEfqFFGga3LxUKQA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167522-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167522: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=ae8272ef787d80950803c521a13a308651bdc62e
X-Osstest-Versions-That:
    ovmf=9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 03:38:53 +0000

flight 167522 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167522/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 ae8272ef787d80950803c521a13a308651bdc62e
baseline version:
 ovmf                 9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9

Last test of basis   167513  2021-12-22 05:41:33 Z    0 days
Testing same since   167522  2021-12-23 01:43:08 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Gerd Hoffmann <kraxel@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   9ec2cc1f31..ae8272ef78  ae8272ef787d80950803c521a13a308651bdc62e -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 05:04:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 05:04:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250956.432206 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0GGy-0007H4-SC; Thu, 23 Dec 2021 05:04:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250956.432206; Thu, 23 Dec 2021 05:04:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0GGy-0007Gx-PG; Thu, 23 Dec 2021 05:04:12 +0000
Received: by outflank-mailman (input) for mailman id 250956;
 Thu, 23 Dec 2021 05:04:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0GGx-0007Gn-Pe; Thu, 23 Dec 2021 05:04:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0GGx-0007QM-MN; Thu, 23 Dec 2021 05:04:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0GGx-00057m-AZ; Thu, 23 Dec 2021 05:04:11 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0GGx-0005Jc-A4; Thu, 23 Dec 2021 05:04:11 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=OOSbeqNCLsWhuUaS0WSr3mMDy3pEt8tJr+0j5lo5ndI=; b=PtrRAq4wT4QZIfUv5pigjvT85p
	Rx/ov6Lyx9jCE4r/Mz54eeNUhvoNYWkZYttnoT9mQL/Gy1Z0MKnpu7To1291BGCAu6F9xJ8VEGGnZ
	ojCu744jw9QTZ5u5LsPZb8cglGC9izGeqgJHml+ERhYiRtj09MRQg7uEBx6oJx7ahH0w=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167520-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167520: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=3f066e882bf1373db023ada606e0dca1af375d9b
X-Osstest-Versions-That:
    linux=2f47a9a4dfa3674fad19a49b40c5103a9a8e1589
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 05:04:11 +0000

flight 167520 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167520/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167512
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167512
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167512
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167512
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167512
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167512
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167512
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167512
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                3f066e882bf1373db023ada606e0dca1af375d9b
baseline version:
 linux                2f47a9a4dfa3674fad19a49b40c5103a9a8e1589

Last test of basis   167512  2021-12-22 05:12:53 Z    0 days
Testing same since   167520  2021-12-22 19:09:37 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Corey Minyard <cminyard@mvista.com>
  Dmitry Vyukov <dvyukov@google.com>
  Giovanni Cabiddu <giovanni.cabiddu@intel.com>
  Helge Deller <deller@gmx.de>
  Herbert Xu <herbert@gondor.apana.org.au>
  John David Anglin <dave.anglin@bell.net>
  Linus Torvalds <torvalds@linux-foundation.org>
  Masahiro Yamada <masahiroy@kernel.org>
  Mian Yousaf Kaukab <ykaukab@suse.de>
  Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Wu Bo <wubo40@huawei.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   2f47a9a4dfa3..3f066e882bf1  3f066e882bf1373db023ada606e0dca1af375d9b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 10:47:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 10:47:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250984.432218 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Lcw-0003wy-IP; Thu, 23 Dec 2021 10:47:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250984.432218; Thu, 23 Dec 2021 10:47:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Lcw-0003wr-Ei; Thu, 23 Dec 2021 10:47:14 +0000
Received: by outflank-mailman (input) for mailman id 250984;
 Thu, 23 Dec 2021 10:47:12 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Lcu-0003wh-Gl; Thu, 23 Dec 2021 10:47:12 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Lcu-0005Iq-F3; Thu, 23 Dec 2021 10:47:12 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Lcu-00049S-4U; Thu, 23 Dec 2021 10:47:12 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Lcu-0000z0-41; Thu, 23 Dec 2021 10:47:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=/nqwBnlDPdhr3kvAIm63Mi1hDrtSZ8NA1cNud2ECMoo=; b=Gl1DP00OBM6owb7NEKHkUw0eKg
	ax48p7n2eut2UQf8o1oM+v2ei7qmslmg4EfKgGKbBVBApxlaHZgK0m4j6XtxQoa6cDKBqfbSOSSHK
	PXYyb1xPXfrYJ90diW49GcAgCoiyZHsA7pmXNGZa2qdL2OaNpOk2dLkZuX2DbJAFLvp4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167525-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167525: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=019eab7240c6358a06aa25e8abad6398693d1d7c
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 10:47:12 +0000

flight 167525 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167525/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              019eab7240c6358a06aa25e8abad6398693d1d7c
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  531 days
Failing since        151818  2020-07-11 04:18:52 Z  530 days  512 attempts
Testing same since   167525  2021-12-23 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90321 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 10:53:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 10:53:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250993.432228 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Lil-0005Z8-7q; Thu, 23 Dec 2021 10:53:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250993.432228; Thu, 23 Dec 2021 10:53:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Lil-0005Z1-4R; Thu, 23 Dec 2021 10:53:15 +0000
Received: by outflank-mailman (input) for mailman id 250993;
 Thu, 23 Dec 2021 10:53:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rV4c=RI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1n0Lik-0005Yv-GP
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 10:53:14 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 865e9243-63de-11ec-9e60-abaf8a552007;
 Thu, 23 Dec 2021 11:53:13 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id BCACB210DB;
 Thu, 23 Dec 2021 10:53:12 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D19113E4C;
 Thu, 23 Dec 2021 10:53:12 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id zOzSJBhVxGFGHwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 23 Dec 2021 10:53:12 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 865e9243-63de-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640256792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:  content-transfer-encoding:content-transfer-encoding;
	bh=pEet0UNjNiJJwdUa4GB5z/GjJ/9loWEgRoSSHCDo0MI=;
	b=GsWW+u52CVrXy/vpfXc8KX5A2yWqgv3EK9oOirwgQ0Gr0O1h7xYNy1dzIr7CVwH8pIyy1E
	4287Ay+xHRmD4BjwygX/wErVLaDyhhemTFZkE8F3fip+NO9hkES8nue3xTE7y4Ib6lQ6YE
	Uzosznh1ttmMURDOL0bwbPDSr0cwvDI=
From: Juergen Gross <jgross@suse.com>
To: stable@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH] xen/blkfront: fix bug in backported patch
Date: Thu, 23 Dec 2021 11:53:08 +0100
Message-Id: <20211223105308.17077-1-jgross@suse.com>
X-Mailer: git-send-email 2.26.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local
copy of a request from the ring page") to stable 4.4 kernel introduced
a bug when adding the needed blkif_ring_get_request() function, as
info->ring.req_prod_pvt was incremented twice now.

Fix that be deleting the now superfluous increments after calling that
function.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/block/xen-blkfront.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 1e44b7880200..ae2c47e99c88 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -493,8 +493,6 @@ static int blkif_queue_discard_req(struct request *req)
 	else
 		ring_req->u.discard.flag = 0;
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy the request to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;
@@ -711,8 +709,6 @@ static int blkif_queue_rw_req(struct request *req)
 	if (setup.segments)
 		kunmap_atomic(setup.segments);
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy request(s) to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;
-- 
2.26.2



From xen-devel-bounces@lists.xenproject.org Thu Dec 23 10:58:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 10:58:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.250996.432239 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0LnT-0006DL-QT; Thu, 23 Dec 2021 10:58:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 250996.432239; Thu, 23 Dec 2021 10:58:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0LnT-0006DE-NW; Thu, 23 Dec 2021 10:58:07 +0000
Received: by outflank-mailman (input) for mailman id 250996;
 Thu, 23 Dec 2021 10:58:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=4ALw=RI=kroah.com=greg@srs-se1.protection.inumbo.net>)
 id 1n0LnS-0006D8-6n
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 10:58:06 +0000
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 31e4969e-63df-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 11:58:02 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 58E445C00D4;
 Thu, 23 Dec 2021 05:58:00 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 23 Dec 2021 05:58:00 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 23 Dec 2021 05:57:59 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 31e4969e-63df-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=c2cKU4iDz/KBtiSAoFHWcks94Il
	IxkFmUpR3FhYa7fc=; b=Muefv8oouQe8WKtDzvdiHDbl9GqaIpQNqutZACZyJ51
	GqmCcqZ/HSrUs+xouyweaozjjwwCB2u72/7O039cyG995I7yV8zHkUceU9fcpX0u
	0zzz8y2kbX3W8T2Q4Xgs+K5sQBlM9TleUzD0+KeKI7a7qBg79XEGr3dkY1uQVeHS
	tFEDEEc0qB4MoiujbWs6tyYg1FmBIX9Ker+DgzB72I5u0BBq4xP0KZoaRnewaJWz
	ZFSeGn7V5tN9e9JCBdvkglA2S/NUwLHPf+Xjhg6XYX9iXap9Gnc2tZ+UW0Z+IOkF
	/heHu25jRbTJv7g0AW+IWi7Pm3IwSPh73vypLHNg2gA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=c2cKU4
	iDz/KBtiSAoFHWcks94IlIxkFmUpR3FhYa7fc=; b=VuWQ6SCkt0hLWZnbgtLzjK
	kC6K9ohdrExWZXDFED+pwIuB1PJfhXmvZ9F0GiBzM2ULmP5m9MwuJdcZSWpLCOtl
	tdCEn5nG0BOTSxolOfh47yCUlaQ//nxHvTXBXtG8ZlAmchU47ETQsf2gngYm7rZq
	RRjENk+BPwTFlYSW+jauRFehymMtN72eXLu7/RCfxe+Jk5TVkNUanAcMESp5tzo9
	52t91SKZn0TDV5ZZvw6JHlxhZDuC4+b5vNW6T+fu6H0qGRDdHzfum9xh3puagXg/
	VqC7ifEN6fNU+Pjd1MEWkbZP/AQEDoqWsUk7q5JDloeuhvLBqkPIZLcjbnvXM+8A
	==
X-ME-Sender: <xms:OFbEYbbqNbMVTo53MuRVNcuxUQljs_D5wGYCfvG9CPxhrzEJwwdgkw>
    <xme:OFbEYaaPkjr0yF3TWGrR1nQ44ctjY0rPfpvK4ll9UwFTMXdj3fUWrSo61icnPv5KN
    fo9L6ytoHjdOg>
X-ME-Received: <xmr:OFbEYd-l3vXr5HpZCnfKKjwlVbuM78R3yz-5N8rZYq4LkT-Rw06J2aWIaVQvW0o1nBKl-d8pUM-MFJ8fkC18iKz0HXY36Qx1>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtkedgvddvucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu
    mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje
    fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht
    vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh
    drtghomh
X-ME-Proxy: <xmx:OFbEYRpmSkmy7BpqCTk0DdlcDmFRESoZVPCshm9WCKuqkYwuW9I9Mg>
    <xmx:OFbEYWqZpPTQyjNtxz8WDAQpIv8g7LJ-Pp-gMPG9iwK1UIiXUDL5_g>
    <xmx:OFbEYXQqiebBzjQ4zXG51mfBSakhPfjKNBjNz_AcI2XFuIkthP19RQ>
    <xmx:OFbEYfleLd9dttC3PfSbU26ZC-rs6Rc9mOnN-Qehazv1sn_9Ls8UcA>
Date: Thu, 23 Dec 2021 11:57:57 +0100
From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/blkfront: fix bug in backported patch
Message-ID: <YcRWNWtraLXt9W8v@kroah.com>
References: <20211223105308.17077-1-jgross@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211223105308.17077-1-jgross@suse.com>

On Thu, Dec 23, 2021 at 11:53:08AM +0100, Juergen Gross wrote:
> The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local
> copy of a request from the ring page") to stable 4.4 kernel introduced
> a bug when adding the needed blkif_ring_get_request() function, as
> info->ring.req_prod_pvt was incremented twice now.
> 
> Fix that be deleting the now superfluous increments after calling that
> function.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  drivers/block/xen-blkfront.c | 4 ----
>  1 file changed, 4 deletions(-)

So this is only needed in 4.4.y?  No other backports were incorrect?

thanks,

greg k-h


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 11:30:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 11:30:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251001.432250 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0MIG-0001ru-27; Thu, 23 Dec 2021 11:29:56 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251001.432250; Thu, 23 Dec 2021 11:29:56 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0MIF-0001rn-VI; Thu, 23 Dec 2021 11:29:55 +0000
Received: by outflank-mailman (input) for mailman id 251001;
 Thu, 23 Dec 2021 11:29:54 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0MIE-0001rd-OZ; Thu, 23 Dec 2021 11:29:54 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0MIE-000610-LY; Thu, 23 Dec 2021 11:29:54 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0MIE-00066k-AS; Thu, 23 Dec 2021 11:29:54 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0MIE-00037o-A0; Thu, 23 Dec 2021 11:29:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=tCFs8AW5pcG21W6e6DeLGJvaKsP6f+W/6tUPojHDR6k=; b=Op68MBDziXF0fBI6cqspJB2Snr
	/fUQVkQq/s4yRRkzC6dnxziI14+qEu4LWm4cxbvS1RzVIjDhqAxtBp8z2P2RCrna89x7p6STLJZue
	o0gUaQ4OMZjphaewZHiuCi9FrHg8Wl+Pk5OkXnav3PZEY7KnIaB4ao6ACIU51MMNSADE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167523-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167523: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 11:29:54 +0000

flight 167523 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167523/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 167510 pass in 167523
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail pass in 167510

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167510
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167510
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167510
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167510
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167510
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167510
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167510
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167510
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167510
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167510
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167510
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167510
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167523  2021-12-23 01:52:57 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Dec 23 12:58:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 12:58:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251043.432279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0NfT-00051L-5U; Thu, 23 Dec 2021 12:57:59 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251043.432279; Thu, 23 Dec 2021 12:57:59 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0NfT-00051E-2I; Thu, 23 Dec 2021 12:57:59 +0000
Received: by outflank-mailman (input) for mailman id 251043;
 Thu, 23 Dec 2021 12:57:57 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0NfR-000514-MS; Thu, 23 Dec 2021 12:57:57 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0NfR-0007VK-Jr; Thu, 23 Dec 2021 12:57:57 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0NfR-00032q-53; Thu, 23 Dec 2021 12:57:57 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0NfR-0000KE-4c; Thu, 23 Dec 2021 12:57:57 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=hUPCVqrWDDWvT8a3b3UfRpTy5hyTM1WXBvkU4GE/ugI=; b=Xi35ssGwQITuE0/FxN5hELm++b
	VEhiGHbEUr7XTGguELVMQ/FYTLqKbrZnPnn22XmLU5xlEsm7zYEja279jvXD598uAUJlSx+ht829N
	WfeCzTmfHdhvGul0bYwSAyfI3hbeqvILqLrG+RejzsvlPdySz5yi0Jm9hV0+swulsUBU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167527-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167527: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=15c596aeebc24bb97deb78d98bd8517a8b9ac243
X-Osstest-Versions-That:
    ovmf=ae8272ef787d80950803c521a13a308651bdc62e
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 12:57:57 +0000

flight 167527 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167527/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 15c596aeebc24bb97deb78d98bd8517a8b9ac243
baseline version:
 ovmf                 ae8272ef787d80950803c521a13a308651bdc62e

Last test of basis   167522  2021-12-23 01:43:08 Z    0 days
Testing same since   167527  2021-12-23 08:11:36 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Rebecca Cran <rebecca@bsdio.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   ae8272ef78..15c596aeeb  15c596aeebc24bb97deb78d98bd8517a8b9ac243 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 13:40:58 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 13:40:58 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251057.432291 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0OKo-0002NW-K0; Thu, 23 Dec 2021 13:40:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251057.432291; Thu, 23 Dec 2021 13:40:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0OKo-0002NP-Gn; Thu, 23 Dec 2021 13:40:42 +0000
Received: by outflank-mailman (input) for mailman id 251057;
 Thu, 23 Dec 2021 13:40:41 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=rV4c=RI=suse.com=jgross@srs-se1.protection.inumbo.net>)
 id 1n0OKn-0002NJ-Ji
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 13:40:41 +0000
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ea87be8b-63f5-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 14:40:40 +0100 (CET)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by smtp-out1.suse.de (Postfix) with ESMTPS id 304E2210E9;
 Thu, 23 Dec 2021 13:40:39 +0000 (UTC)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
 (No client certificate requested)
 by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 137D513E38;
 Thu, 23 Dec 2021 13:40:39 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
 by imap2.suse-dmz.suse.de with ESMTPSA id xkt1A1d8xGFfYwAAMHmgww
 (envelope-from <jgross@suse.com>); Thu, 23 Dec 2021 13:40:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ea87be8b-63f5-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
	t=1640266839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=YiDR+4/nieQeAOKbU2oGGRKnr9gCnviUV4iOLI6JEaE=;
	b=WltkrI0E9+OTf7AoyoEUq/NW0AJJdVW/W532pLVS22+geMWuQ3Y+LDexxHpI/KUZCr6zsg
	lcFDTd5Anq5eGhPFQyEYaKPFxn8qpo0/m7q0xF5Uc6IH2BwXQgqqN9xrbXsFyJVZqNw8yV
	ck0ypeaCk8+e3rpdxqzjugGJueUDxqc=
Subject: Re: [PATCH] xen/blkfront: fix bug in backported patch
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org
References: <20211223105308.17077-1-jgross@suse.com>
 <YcRWNWtraLXt9W8v@kroah.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <9823fe0a-2db4-bc4b-2d7c-6363856322ff@suse.com>
Date: Thu, 23 Dec 2021 14:40:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YcRWNWtraLXt9W8v@kroah.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="oILMpFocktKvEJeoHQm73Ou8ctrcT6kw8"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--oILMpFocktKvEJeoHQm73Ou8ctrcT6kw8
Content-Type: multipart/mixed; boundary="Ok42bv1j9tp6S394x4lJffOiY8w0Ljwyl";
 protected-headers="v1"
From: Juergen Gross <jgross@suse.com>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org
Message-ID: <9823fe0a-2db4-bc4b-2d7c-6363856322ff@suse.com>
Subject: Re: [PATCH] xen/blkfront: fix bug in backported patch
References: <20211223105308.17077-1-jgross@suse.com>
 <YcRWNWtraLXt9W8v@kroah.com>
In-Reply-To: <YcRWNWtraLXt9W8v@kroah.com>

--Ok42bv1j9tp6S394x4lJffOiY8w0Ljwyl
Content-Type: multipart/mixed;
 boundary="------------A7AFA908A67E80CD1F635943"
Content-Language: en-US

This is a multi-part message in MIME format.
--------------A7AFA908A67E80CD1F635943
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 23.12.21 11:57, Greg KH wrote:
> On Thu, Dec 23, 2021 at 11:53:08AM +0100, Juergen Gross wrote:
>> The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take loca=
l
>> copy of a request from the ring page") to stable 4.4 kernel introduced=

>> a bug when adding the needed blkif_ring_get_request() function, as
>> info->ring.req_prod_pvt was incremented twice now.
>>
>> Fix that be deleting the now superfluous increments after calling that=

>> function.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>   drivers/block/xen-blkfront.c | 4 ----
>>   1 file changed, 4 deletions(-)
>=20
> So this is only needed in 4.4.y?  No other backports were incorrect?

Yes. 4.4 only.


Juergen

--------------A7AFA908A67E80CD1F635943
Content-Type: application/pgp-keys;
 name="OpenPGP_0xB0DE9DD628BF132F.asc"
Content-Transfer-Encoding: quoted-printable
Content-Description: OpenPGP public key
Content-Disposition: attachment;
 filename="OpenPGP_0xB0DE9DD628BF132F.asc"

-----BEGIN PGP PUBLIC KEY BLOCK-----

xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy=
cWx
w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O=
f8Z
d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y=
9bf
IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq=
G7/
377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR=
3Jv
c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA=
QIe
AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT=
hpw
dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0=
MbD
1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv=
oPH
Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v=
5QL
+qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ=
2Vu
IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC=
QoL
BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr=
Wf0
teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC=
/nu
AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh=
ITT
d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm=
XBK
7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz=
80h
SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC=
AcD
AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn=
FOX
gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1=
jnD
kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0=
N51
N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l=
otu
fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1=
tqS
EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA=
hsD
BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3=
g3O
ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5=
dM7
wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5=
D+j
LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm=
V2x
AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N=
Eaw
QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW=
nHI
s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR=
wgn
BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV=
bVF
LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk=
pEd
IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA=
QAB
wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw=
Tbe
8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1=
vJz
Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8=
VGi
wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW=
svi
uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX=
zXs
ZDn8R38=3D
=3D2wuH
-----END PGP PUBLIC KEY BLOCK-----

--------------A7AFA908A67E80CD1F635943--

--Ok42bv1j9tp6S394x4lJffOiY8w0Ljwyl--

--oILMpFocktKvEJeoHQm73Ou8ctrcT6kw8
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmHEfFYFAwAAAAAACgkQsN6d1ii/Ey+h
Mgf/aVsKJujh58k9L3PfIFFHzkiuA+ZBPvtM0fEMBV35kgpB94AFcjA0r9EGPQtQ9gyQgnzPoNx8
xA0otFGOuKg+HS3rJuZ8Aw12sy/60+jJsRUhfEvNFz9lkoge8DNcOTfeM5EOMxr6dXJjkk+7kLPV
N+0JhvFbe/fYxcJii6kligV4Zfmn1YHhCKNXDflgqqad0P0BUeWxhr+uMKRFcmR1KR+AFH1RHqQu
aJDIi3x8XXF2Qqn1QUFg8ow1t8zjytE6ubZmAE7vJpwl73xXzIicHjh65yebThuDY0cf+mhk0t8J
46MTosS9B+B/uAhmS3Lbtwxuu5MuFkrkxwc5OXRMzg==
=XRAF
-----END PGP SIGNATURE-----

--oILMpFocktKvEJeoHQm73Ou8ctrcT6kw8--


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 14:04:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 14:04:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251061.432302 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0OhC-0005T4-HJ; Thu, 23 Dec 2021 14:03:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251061.432302; Thu, 23 Dec 2021 14:03:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0OhC-0005Sx-Dr; Thu, 23 Dec 2021 14:03:50 +0000
Received: by outflank-mailman (input) for mailman id 251061;
 Thu, 23 Dec 2021 14:03:48 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0OhA-0005Sn-Qz; Thu, 23 Dec 2021 14:03:48 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0OhA-0000FO-Ne; Thu, 23 Dec 2021 14:03:48 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0OhA-0005If-BV; Thu, 23 Dec 2021 14:03:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0OhA-000831-B6; Thu, 23 Dec 2021 14:03:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=jiyIFWwABQyvX+FZ1sNX5TESkVwXfS4ePq+pmuasu7M=; b=pP+DsE7neZqAtJ53RN93/dk5He
	ukSnFnE82q0CaRbFGMlZ+K81wbn6J2mpe7dueEbDpPA1AFhUMV+5HQW7sBqI2/USY5vWWxi8hOi8c
	SrMzHTjrgnTgKjavKcTRJiD2klT3J4exwAzsGSmbzCRA+c8k9d0vQkGMNBijizRPUXwA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167524-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167524: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=6f016a2f7909eb6d595436a2f56cdf7cdf3e3c68
X-Osstest-Versions-That:
    qemuu=8d29feca838bce06473616168b6d5c0b35b96c94
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 14:03:48 +0000

flight 167524 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167524/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167519
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167519
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167519
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167519
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167519
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167519
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167519
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167519
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                6f016a2f7909eb6d595436a2f56cdf7cdf3e3c68
baseline version:
 qemuu                8d29feca838bce06473616168b6d5c0b35b96c94

Last test of basis   167519  2021-12-22 18:38:20 Z    0 days
Testing same since   167524  2021-12-23 02:52:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Hanna Reitz <hreitz@redhat.com>
  John Snow <jsnow@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   8d29feca83..6f016a2f79  6f016a2f7909eb6d595436a2f56cdf7cdf3e3c68 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 14:48:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 14:48:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251071.432312 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0POJ-0002CU-VU; Thu, 23 Dec 2021 14:48:23 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251071.432312; Thu, 23 Dec 2021 14:48:23 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0POJ-0002CN-SP; Thu, 23 Dec 2021 14:48:23 +0000
Received: by outflank-mailman (input) for mailman id 251071;
 Thu, 23 Dec 2021 14:48:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0POI-0002CD-Bu; Thu, 23 Dec 2021 14:48:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0POI-0000xs-A9; Thu, 23 Dec 2021 14:48:22 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0POH-0006Px-Uo; Thu, 23 Dec 2021 14:48:22 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0POH-00016s-UO; Thu, 23 Dec 2021 14:48:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ezm34NtNlAzEb5mzgy/jNISvHIljg+RRWD5vUZ/MFa4=; b=dUDdKgNqyW0g8OI7AC3xQcCHvV
	pz6Hm82AbaK8E7vAvwKTM6Z4zQXsiSdq+0NVBKbciKIrQnslDgO4EWArFH6t5Z4tOuZ1PQf4+a6Sj
	tEH1AdceimK41Ka4ojvQieBUDO7E3da7ZT9IUHQpHi1iwUiQBBBwlJaosmckc1NfRCfU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167526-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167526: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=bc491fb12513e79702c6f936c838f792b5389129
X-Osstest-Versions-That:
    linux=3f066e882bf1373db023ada606e0dca1af375d9b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 23 Dec 2021 14:48:21 +0000

flight 167526 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167526/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167520
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167520
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167520
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167520
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167520
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167520
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167520
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167520
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                bc491fb12513e79702c6f936c838f792b5389129
baseline version:
 linux                3f066e882bf1373db023ada606e0dca1af375d9b

Last test of basis   167520  2021-12-22 19:09:37 Z    0 days
Testing same since   167526  2021-12-23 05:07:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Jackie Liu <liuyun01@kylinos.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mike Rapoport <rppt@linux.ibm.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   3f066e882bf1..bc491fb12513  bc491fb12513e79702c6f936c838f792b5389129 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 15:49:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 15:49:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251122.432360 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0QLK-0003Kh-FM; Thu, 23 Dec 2021 15:49:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251122.432360; Thu, 23 Dec 2021 15:49:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0QLK-0003Ka-Bs; Thu, 23 Dec 2021 15:49:22 +0000
Received: by outflank-mailman (input) for mailman id 251122;
 Thu, 23 Dec 2021 15:49:22 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=xdKn=RI=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n0QLK-0003KT-0Z
 for xen-devel@lists.xen.org; Thu, 23 Dec 2021 15:49:22 +0000
Received: from mail-io1-f45.google.com (mail-io1-f45.google.com
 [209.85.166.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e4522994-6407-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 16:49:20 +0100 (CET)
Received: by mail-io1-f45.google.com with SMTP id u8so7630767iol.5
 for <xen-devel@lists.xen.org>; Thu, 23 Dec 2021 07:49:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e4522994-6407-11ec-bb0b-79c175774b5d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=G9c/L0SIJCU70WhuqWHTiXFgSxsq352JlPnfYky8nlI=;
        b=2f/9Slg8yjA2t7olZrFr8ykdvYtJvqAGy907IopIfCbiu/gthQKpJPB85OXr9TPVGH
         LXsZ2CTrLnQ/VncGJm4a3SZpsiSAmUI4FJopmjuQ9bl4ItpPNv8wwewfjTh+ax24ecZ8
         2IvoKsCc8d04iBaZfHtvj+4K/xvruO4T584N7EADEdEaGbaobqltniuQ6teXoHRRNX8O
         qPaoDPhUPEMwFOYoBGO7bG4OWC51wk5JoOCj+462DNmU52GK91GRBOaH8L4ElBcUfd+L
         B17QI1evR1zvSGE+voTUekVWjbYRLwNaEhTDdy5tExbaxlIXqMSzrPqpjOF0PCJjn5TL
         zAsA==
X-Gm-Message-State: AOAM5329jPwHYgM2I0T1NG4cncd8Y+m/DrhEcGyWIancNgGbmBtQ8EoW
	Q3iHcb1hvigLaiVD26VpIpJHpCuWX7yMkMgV0Vc=
X-Google-Smtp-Source: ABdhPJz43FfikZuVJAAN4Ox40RkZiOyRNWeyjNqKCEOgrKhsCQ87AKjaLn8pLtjh+OJVrqIV3d2D8oL1F93JH1YOnNM=
X-Received: by 2002:a05:6602:2bc2:: with SMTP id s2mr1478841iov.23.1640274559523;
 Thu, 23 Dec 2021 07:49:19 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger> <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger>
In-Reply-To: <YcInKtCNgA9v0k+c@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Thu, 23 Dec 2021 23:49:08 +0800
Message-ID: <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 22, 2021 at 3:13 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>=
 wrote:

> Could you build a debug kernel with the following patch applied and
> give me the trace when it explodes?

Please find the trace and the kernel CL below.
Note, the domU get stuck into a bootloop with this assertion as the
situation will come back after domU restart and only dom0 reboot can
get the situation back to normal.
The trace I captured below is within the boot loop. I suspect the
initial trigger may look different. Will give it another try soon.

FreeBSD 12.2-RELEASE-p11 #0 c8625d629c3(truenas/12.0-stable)-dirty:
Wed Dec 22 20:26:46 UTC 2021
The repo is here: https://github.com/freenas/os.git

db:0:kdb.enter.default>  bt
Tracing pid 0 tid 101637 td 0xfffff80069cc4000
kdb_enter() at kdb_enter+0x37/frame 0xfffffe009f121460
vpanic() at vpanic+0x197/frame 0xfffffe009f1214b0
panic() at panic+0x43/frame 0xfffffe009f121510
xn_txq_mq_start_locked() at xn_txq_mq_start_locked+0x4c6/frame
0xfffffe009f121580
xn_txq_mq_start() at xn_txq_mq_start+0x84/frame 0xfffffe009f1215b0
ether_output_frame() at ether_output_frame+0xb4/frame 0xfffffe009f1215e0
ether_output() at ether_output+0x6a5/frame 0xfffffe009f121680
ip_output() at ip_output+0x1319/frame 0xfffffe009f1217e0
tcp_output() at tcp_output+0x1dbf/frame 0xfffffe009f121980
tcp_usr_send() at tcp_usr_send+0x3c9/frame 0xfffffe009f121a40
sosend_generic() at sosend_generic+0x440/frame 0xfffffe009f121af0
sosend() at sosend+0x66/frame 0xfffffe009f121b20
icl_send_thread() at icl_send_thread+0x44e/frame 0xfffffe009f121bb0
fork_exit() at fork_exit+0x80/frame 0xfffffe009f121bf0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe009f121bf0


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 16:23:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 16:23:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251127.432371 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Qs1-00005i-2r; Thu, 23 Dec 2021 16:23:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251127.432371; Thu, 23 Dec 2021 16:23:09 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Qs0-00005a-W2; Thu, 23 Dec 2021 16:23:08 +0000
Received: by outflank-mailman (input) for mailman id 251127;
 Thu, 23 Dec 2021 16:23:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/cjH=RI=citrix.com=Andrew.Cooper3@srs-se1.protection.inumbo.net>)
 id 1n0Qrz-00005U-Ry
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 16:23:07 +0000
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com
 [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9ad197f2-640c-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 17:23:05 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9ad197f2-640c-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640276585;
  h=from:to:cc:subject:date:message-id:mime-version;
  bh=7hzbK3gy7YX7ljX+ayb8kqwNfu76Q1Tcy0UrKhN4VcY=;
  b=cSpmZPo7eRv0VjteKXMCxbrlmhkFQpm8I82l8aN1b6LnSqIvjVHHXRYq
   HSpSkf67C8X/TDq7OMRTj/NpHc3ZcO1A1uMbfHBbSo4XRfXEFyBoS6fRh
   H5LwWpRWEnAyRK+S84sauxOxdvxoa+wuv2CdTFFgCOsA2b2J5KaTn+nmQ
   g=;
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
IronPort-SDR: QEEgBh/VahF6FDSr1YkqcGf6/2CmgYw1Dt+Gx5KQPLtpZ94teh7fSWXMeFNP5nNRnfW/NAdvoD
 eD9WiANW5StGd2wYMOl3uGAAs/sYhNE/3MLo+Su5RlmWrCWXI/ecsTEUmktvFIIFRoEttsiPEX
 Xi2yo07lHu7FAPyAoNCSUDZST5GpRxQVAc+jGsq4QQPnOhU0vmkCqc3v4GdQPT6BzDUxS77I1S
 rvrZcbH9ahZABHGJsNbXdlCmXGyXYICS75GhNpwUpY+Hx1WP2gGacyrtXX18ZuUr6GUameEIQA
 ThEnOO7iklhfFwTsZIdXW2mM
X-SBRS: 5.1
X-MesageID: 60692699
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:qCbN0qtv9BkSt/KN9lJ1BI5u9+fnVH1ZMUV32f8akzHdYApBsoF/q
 tZmKWqEOKqKNjSkKo8nbIjg9x5UvMCEyYc3TVM4r380RCwV+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24PhWGthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 Npl5bDqcVgYNaz3teUGWStlIxhjGrIZweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DFYUToHx/ixreCu4rW8vrSKTW/95Imjw3g6iiGN6AP
 5RIM2Q+PXwsZTV1HV0YKZ4Ou97xg0nnSjoB93aUiZQetj27IAtZj+G2bYu9lsaxbcdahEGDv
 Urd4n/0RBodMbS32TeDt36hmOLLtSf6Q54JUq218OZwh1+ezXBVDwcZPWZXutHg1BT4AYgGb
 RVJpGx+9sDe6XBHUPGtc0eA/0+PvyUxWsFaIdAK0Ryq1fXttlPx6nc/chZNb9kvtckTTDMs1
 0OUk96BOQGDoIF5WlrGqO7K8Gra1Tw9aDZbOHRaFVdtD8zL+dlr1nryosBf/LlZZzEfMRX52
 Hi0oSc3nN3/ZuZbhvzgrTgrb99Bz6UlrzLZBC2LDwpJDSsjPeZJgrBEDnCBsp59wH6xFAXpg
 ZT9s5H2ABoyJZ+MjjeRZ+4GAauk4f2IWBWF3wI3Rshxpmr8oCP5FWy13N2ZDB02WvvohBezO
 BOD0e+vzMI70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ
 f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGAfUM71isvrb+F69H
 hQ2H5Li9iizmdbWOkH/mbP/53hTRZTiLZyp+cFRaMCZJQ9qRDMoB/PLmOtzcI15haVF0OzP+
 yjlCENfzVP+g1zBKBmLNS8/OO++A84noCJpJzEoMHapx2MnPdSl4pAAesZlZrIg7uFik6J5F
 qFXZ8WaD/1TYT3b4DBBP4LlpYlveU3z1wKDNiaoehYleJtkS1Cb89PoZFK3piIPEjC2pY01p
 Lj5jlHXRp8KRgJDCsfKaa3wkwPt7CZFwO8rBhnGONhefkno4bNGES2pg69lOdwIJDXC2iCei
 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzIIcAuaFeTfRCDH99Km4P
 LgHyvj9NLsMnUpQspo6GLFulPps69zqrr5c7wJlAHSUMAj7VuI+eiGLjZtVq6lA5r5Fog/nC
 EuA9+5TNaiNJM64QkUaIxAob7jb2PwZ8tUIAS/Z/KkuCPdLwYe6
IronPort-HdrOrdr: A9a23:lRR/CqqaTWoJJmA8llnJ04UaV5o9eYIsimQD101hICG8cqSj+f
 xG/c5rsiMc5wxwZJhNo7y90cq7MBfhHPxOkOos1N6ZNWGM0gaVxelZnO7fKlbbehEWmNQz6U
 4ZSdkdNOHN
X-IronPort-AV: E=Sophos;i="5.88,230,1635220800"; 
   d="scan'208";a="60692699"
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>, Anthony PERARD
	<anthony.perard@citrix.com>, Juergen Gross <jgross@suse.com>
Subject: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()
Date: Thu, 23 Dec 2021 16:22:44 +0000
Message-ID: <20211223162244.16198-1-andrew.cooper3@citrix.com>
X-Mailer: git-send-email 2.11.0
MIME-Version: 1.0
Content-Type: text/plain

The first thing XEN_SYSCTL_physinfo does is zero op->u.physinfo.

Do not copy-in.  It's pointless, and most callers don't initialise their
xc_physinfo_t buffer to begin with.  Remove the pointless zeroing from the
remaining callers.

Spotted by Coverity.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
 tools/libs/ctrl/xc_misc.c | 2 --
 tools/libs/light/libxl.c  | 2 +-
 tools/libs/stat/xenstat.c | 2 +-
 tools/misc/xenpm.c        | 2 +-
 tools/xenmon/xenbaked.c   | 2 +-
 tools/xentrace/xentrace.c | 2 +-
 6 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/tools/libs/ctrl/xc_misc.c b/tools/libs/ctrl/xc_misc.c
index 3820394413a9..265f15ec2da3 100644
--- a/tools/libs/ctrl/xc_misc.c
+++ b/tools/libs/ctrl/xc_misc.c
@@ -195,8 +195,6 @@ int xc_physinfo(xc_interface *xch,
 
     sysctl.cmd = XEN_SYSCTL_physinfo;
 
-    memcpy(&sysctl.u.physinfo, put_info, sizeof(*put_info));
-
     if ( (ret = do_sysctl(xch, &sysctl)) != 0 )
         return ret;
 
diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c
index a77aa856fdd6..667ae6409be7 100644
--- a/tools/libs/light/libxl.c
+++ b/tools/libs/light/libxl.c
@@ -351,7 +351,7 @@ const char *libxl_defbool_to_string(libxl_defbool b)
 /******************************************************************************/
 int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo)
 {
-    xc_physinfo_t xcphysinfo = { 0 };
+    xc_physinfo_t xcphysinfo;
     int rc;
     long l;
     GC_INIT(ctx);
diff --git a/tools/libs/stat/xenstat.c b/tools/libs/stat/xenstat.c
index e49689aa2da9..8bab2e66a7fe 100644
--- a/tools/libs/stat/xenstat.c
+++ b/tools/libs/stat/xenstat.c
@@ -135,7 +135,7 @@ xenstat_node *xenstat_get_node(xenstat_handle * handle, unsigned int flags)
 {
 #define DOMAIN_CHUNK_SIZE 256
 	xenstat_node *node;
-	xc_physinfo_t physinfo = { 0 };
+	xc_physinfo_t physinfo;
 	xc_domaininfo_t domaininfo[DOMAIN_CHUNK_SIZE];
 	int new_domains;
 	unsigned int i;
diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c
index d0191d498484..4f8cde690a7c 100644
--- a/tools/misc/xenpm.c
+++ b/tools/misc/xenpm.c
@@ -1244,7 +1244,7 @@ struct {
 int main(int argc, char *argv[])
 {
     int i, ret = 0;
-    xc_physinfo_t physinfo = { 0 };
+    xc_physinfo_t physinfo;
     int nr_matches = 0;
     int matches_main_options[ARRAY_SIZE(main_options)];
 
diff --git a/tools/xenmon/xenbaked.c b/tools/xenmon/xenbaked.c
index 1ed34334c824..7591de7c609f 100644
--- a/tools/xenmon/xenbaked.c
+++ b/tools/xenmon/xenbaked.c
@@ -436,7 +436,7 @@ static struct t_struct *map_tbufs(unsigned long tbufs_mfn, unsigned int num,
  */
 static unsigned int get_num_cpus(void)
 {
-    xc_physinfo_t physinfo = { 0 };
+    xc_physinfo_t physinfo;
     xc_interface *xc_handle = xc_interface_open(0,0,0);
     int ret;
 
diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index a8903ebf4625..864e30d50cc3 100644
--- a/tools/xentrace/xentrace.c
+++ b/tools/xentrace/xentrace.c
@@ -589,7 +589,7 @@ static void set_evt_mask(uint32_t mask)
  */
 static unsigned int get_num_cpus(void)
 {
-    xc_physinfo_t physinfo = { 0 };
+    xc_physinfo_t physinfo;
     int ret;
     
     ret = xc_physinfo(xc_handle, &physinfo);
-- 
2.11.0



From xen-devel-bounces@lists.xenproject.org Thu Dec 23 18:46:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 18:46:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251133.432382 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0T64-00089S-Jt; Thu, 23 Dec 2021 18:45:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251133.432382; Thu, 23 Dec 2021 18:45:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0T64-00089L-Gp; Thu, 23 Dec 2021 18:45:48 +0000
Received: by outflank-mailman (input) for mailman id 251133;
 Thu, 23 Dec 2021 18:45:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=PZJx=RI=epam.com=prvs=2991c9dd67=volodymyr_babchuk@srs-se1.protection.inumbo.net>)
 id 1n0T62-00089F-Sn
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 18:45:47 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 87c76f62-6420-11ec-9e60-abaf8a552007;
 Thu, 23 Dec 2021 19:45:44 +0100 (CET)
Received: from pps.filterd (m0174677.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BNIS13e025316;
 Thu, 23 Dec 2021 18:45:34 GMT
Received: from eur04-vi1-obe.outbound.protection.outlook.com
 (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d4wp284pw-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 23 Dec 2021 18:45:34 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com (2603:10a6:102:201::14)
 by PAXPR03MB8029.eurprd03.prod.outlook.com (2603:10a6:102:21c::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Thu, 23 Dec
 2021 18:45:30 +0000
Received: from PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6]) by PAXPR03MB7594.eurprd03.prod.outlook.com
 ([fe80::157a:fb23:aa6c:f0f6%6]) with mapi id 15.20.4823.018; Thu, 23 Dec 2021
 18:45:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 87c76f62-6420-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=e30j+Y2lQqWzkl4HXVcwlSeyIDXIwP79EWi+qdS93xUtEMASXU1nQ4yrkm7dEWB0SxfmAVcNAHIA8DrIdh4cw9P+yQnQsKHON2T3n2RHPEy1S5bd6s2Rpk/o5P5QlH2ue5nLFF0eNXt6g3+gK9i3GtP/vzfxjsR+03xOKdDxYjfP0f/hUGDPMCmVsvJY+bCLumCmeKi4b5CokULOIeDSEmEU05vSuavhuLrnyVrax0hlrD6tb9Z/faaCPmI9qNRTVZizSHAudUfmdzKwv/7ZNkggUqozCJdx5fXYRv7FjHxISum2eWk73LF7UoyBEXWT6QS8kRWFnFZzI3NgD+eagA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=CjkalpuwVcZrwKM7sU7cMK/1kZAsZmV2tUaPNn+OW6o=;
 b=VhfwnzTuI0gn2JE/x8PSQKWVjmWHddAfi76zJWt/NP5C4CmUy1BN1fJZn6aXRiUnl6TqX6hOLSsTV/y2mHKMMPl1DI96BN99Exxd9tt3Z0O6MtXMLhJGseOsc11ZW0NxxT0aEQhwJoFI+dgZauu39ucUr7jusIkSvhs7rTPMH94XyooYAPsuZcLE9Tcd5T+HnaMZpcRz+Gex2+eN0NIk2qSlsJJT7Ygp4EmFyskScrBy4yZ+p8h8Co4VnNh/i4LFFlomH7upCL8peFTN380Yc4PeoLWwdIVXmbv8qY04V6esRT+o//2caM1eNhfWFMdfoJrsDgF7G1+cTNvsmuNMUA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=CjkalpuwVcZrwKM7sU7cMK/1kZAsZmV2tUaPNn+OW6o=;
 b=lI+4DjjDsmrXOAJkT+5rj4mbCQ9+f3+Rur+f4ymbF0Fn5X5EVVAN56UVdkiBKpYqITBEBL9fVBoqMi3yKoDO2hnOvUzo4QcSmYVabx371xBdWLKgMY24Y8qDTa3AaSabPLTADI7M9H7jYGaMvLreMttaV7houPzFVZt5K0Y2VILp+EhAniWWuCIMIDiwLygu+ptnVtDK7HEni5pmWWblTtvDI+V9POnOzAzIbBYVzIOP0Fpzog6mI4wANKEzG2SdhR465trYQZpHB9C7/PvEzcqK5fE9IYsnrnAumFh6YLYIAmtPBh/1wZQrQIJwa8nNgEUXpQjtBzyulORXgUw1Rg==
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3KlDaIxIuwGU2+lSkQB5aT3aw3iHyAgAQwJQCAAG+wgIABQZwAgAAWRwCAAOWAgIABAM8AgAEPOwA=
Date: Thu, 23 Dec 2021 18:45:29 +0000
Message-ID: <877dbvw46v.fsf@epam.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: mu4e 1.6.5; emacs 27.2
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4270e1c6-dc3e-4061-b0d8-08d9c64464d0
x-ms-traffictypediagnostic: PAXPR03MB8029:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PAXPR03MB80291805361FBE140B21F3F9E67E9@PAXPR03MB8029.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 goOfJusJ4aUn6xgk5t+WB72pDnyANfhxpThszUwG1GIeN08Sbd5worjFsQIzOr6R4E4G1KCscWQ4jt8em84pwKJKJy1e5Knw46m9F/RrNoZoYvaiQgnLmyHvorKxZhFixYY1EK61ulz1XxFYUKm0iOviXyzdLgx6a0vsSnt18jPZsYSsRah87MaPF38Dk+NeyJNkxZxW4Y3aln3UyuacFk+B2Uh74AhWYig7cHZ0aTcrZ3y8ORtiBeno8z5XY5mgQf5c/a3ghAJiNtSHO0v4nWWWyVZKRn1W7MlX9wBp+wpyIuyXB8anwSxcPRTLQ/pz4YKxlfCk6HUifYKishkcE1+5LzS8YAtAkw9Gz+2mxAgq6uGiE4A7L+FlBbIapyc8L7/ytolcVjQHzsc87cOq1yoiO1lWW2iqE4QxKjmgo1eRJoTP8m3TfUb2q214hGCpzheuDvcUxs0c1IR5TixvB8xbdACXLaL0Ag7UHDibYzSR+JyNoQKnPKCr2fLqkBbTQqHHhz3O7+FtTVSX11E5lpFYUJQZkDKvzpZgBdUbooccyu1rmM1ptagpnVfb1fBA8ilIqBcnOfg+3Q23RzQPPcyUcztx/PDz0c/M4hGzSYcv8ABAMT8mzylAf8nN/lLLKg/nvl5tY0fVlyvwg9mn/KOdZJJeQHujZjF2fJzkeMFwWXphxtNiH6meYYBzjM4CJegDWIpi4v4PcyvcMLaBdjGGSBQ0GXFiY2NjfU0/BS1hHu4zMCuL4VsvpYJILqnF0Qe2PVcUE+zMbRXhCbmuFCuIHrbP+RGEHmpULq8PUFs=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR03MB7594.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(64756008)(316002)(2906002)(86362001)(36756003)(38070700005)(66556008)(76116006)(54906003)(5660300002)(6916009)(508600001)(66446008)(71200400001)(83380400001)(2616005)(66476007)(8676002)(186003)(6512007)(966005)(38100700002)(4326008)(91956017)(55236004)(8936002)(6506007)(6486002)(122000001)(26005);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?sq1E20+/vfSGl9zgRvz1d74U0rXtZriEuU3eovv+vj1nlqQKcGIyxGMUsH?=
 =?iso-8859-1?Q?qYRFiKp8bnxmMdabN6S9UlSzZ/KbPNxZ/JVoSTSYnQvh1OiDexwI+l+N9W?=
 =?iso-8859-1?Q?OauR0+ueUobKHYXyA9UzZjoFQTcA1HETHLmNeomFDEoxztui8SFpGZmed1?=
 =?iso-8859-1?Q?PJKyYSvPaqWWGCFkgd0KZ1eSGSgEI0r49ky252J0vGDHS+///NAK+kMEXc?=
 =?iso-8859-1?Q?fAIEfMBIq4doUMw0dfsRA0K8E+sKu3wvmJr9535e0IZyErSSnSW0wX9DLl?=
 =?iso-8859-1?Q?+3ryhMyomukj5kDdTgv9ob3YQFyoTAzW3c3vYKNRu5fakZLMNDql1HxikW?=
 =?iso-8859-1?Q?mejXFTWxQ06FfjNtBh9UblpN1Y9DIw+I7KlF0Z6yghoEGbyO7Phypnlrup?=
 =?iso-8859-1?Q?+FYkI9TnqJSm0l+J3vqwi8v61/intEUiws7cFdi3P0u0tg4mpjxtteyKQF?=
 =?iso-8859-1?Q?htm4guNsE31Q8WqlKXCbo3BcNH+GWwwIOp8VZz6w7619NDtuKuPpzQqCkJ?=
 =?iso-8859-1?Q?PDjKQFfS7NeqkguBCe+d1NDqwVnfXxZD+ONA67EUMmJrXzra1t2bekFmxb?=
 =?iso-8859-1?Q?7KR2JQ3LRAEvv1uIK/mSs232f6NW4goGkWmG2WUMO1UUyBL2XEvGQSSlRY?=
 =?iso-8859-1?Q?PhHrQKtFSAgaVOsKU+51x3CW2GJ/Co/NLG+zURd0koPx/NOkrJlH+3wcnQ?=
 =?iso-8859-1?Q?zymF5WK0vqZ9CCNXQiIH0yKeYCwcavx9Xn5eNXvP9+p6m6Db838rtmWwus?=
 =?iso-8859-1?Q?2YQS37GuCRXYib54wW2Nxu5bMDRURxjdxkR4EYfHDIbYaXXQyzNbhNRC2Y?=
 =?iso-8859-1?Q?ZxP8c8PvpEW+C6j7FauxxHwDUfalqvpAHXCKoGw/cPAplp4y7bvX78aeJm?=
 =?iso-8859-1?Q?sYatpW/hOKNcZd2AdZGzUur2VFT5g3v+qsjQbnXqDDItsPHOhEuQw6hQYz?=
 =?iso-8859-1?Q?qX9Fospp/bf4W7a0E1C5qTyoQDmR+xG6jwyNeMFvBdUiG05dTuVcfYuk5n?=
 =?iso-8859-1?Q?jNMXRxC4gK+GAXqGuxvDmmWYyRfgmvikXyinjck3VN0fyNeGHOaRrldrW+?=
 =?iso-8859-1?Q?5LIg8bnEPVi07vmvNVxRqO728iuOPgIrDCPEJEmEbAsCG4KEIowVdYZoUd?=
 =?iso-8859-1?Q?jOob2vp4v9NdYv5VnNBg2DFAXaNffQQhvTeCIRWsETaqAAlTBv2EorODKq?=
 =?iso-8859-1?Q?4uhP/0Qlxslgsph153gxeB5c03ZNALMBw63h9CHO3MLyExJIlWuVWyUZGE?=
 =?iso-8859-1?Q?kOjQRida9iDI5mvdv7C/ardtazgqRYTRXGGfuMlKFq8C99mC4M1bjo5YBD?=
 =?iso-8859-1?Q?qLuH7/j2H4nKQWGvjbY5BgFQjbHqSvEwDok1CCE9GXZWWeJjxD9Q32I271?=
 =?iso-8859-1?Q?pWRfCTUJfTVHBWbrBglDgygENaxCHahyU+oQJ783RRRNkAR6kfYipCzXBD?=
 =?iso-8859-1?Q?yNZ4AnQ1yUk6L5UuedamHfxEfiZcW/fm9Q5nELD6SZnudf63iYSi3bsRG3?=
 =?iso-8859-1?Q?hrPrg2meg8Oy4dLgox2vXkV5Ubj3xOR+5xHSXpz/dpDWJgL4LgApukpe6O?=
 =?iso-8859-1?Q?fCnRjrxDWsUWoKX+pVpBw0U/WvqgqOLAQMiNFwMMVTaiCRIVFCpEZPEp9C?=
 =?iso-8859-1?Q?l1JjQInARhqi1UpNs31ofQomCXxkT0T0HgoqGl50bBYzTxLrFYhC27nReO?=
 =?iso-8859-1?Q?ty89Mdk2j5KcUirS3YPte91jBv/q+58eA9docF/vhTnX/Cu04pdC57XiOt?=
 =?iso-8859-1?Q?SqKZj/cM+zNnCqgi5K0yRhU/g=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR03MB7594.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4270e1c6-dc3e-4061-b0d8-08d9c64464d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 18:45:30.0172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eoZ7pyGTPE+ld263LUX5hREiJzqkKk3Ad0BZMBo+WH19S0Xx1j7Z2UxogUU1qMWvbg2uNVB0Ivz+PDLpcPx8Rc53yHDdmLomxAGELHfCF0c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB8029
X-Proofpoint-GUID: FRYWGeg67_LCNnyZVVoeFtRyymIxiZ1G
X-Proofpoint-ORIG-GUID: FRYWGeg67_LCNnyZVVoeFtRyymIxiZ1G
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-23_04,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0
 clxscore=1015 adultscore=0 priorityscore=1501 mlxlogscore=999 mlxscore=0
 suspectscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230097


Hi Stefano, Oleksii,

Stefano Stabellini <sstabellini@kernel.org> writes:

> On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
>> On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
>> > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
>> > > Hi Stefano,
>> > >=20
>> > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
>> > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
>> > > > > Hi Stefano,
>> > > > >=20
>> > > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wro=
te:
>> > > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:

[...]

>> > > > In general we can't use properties that are not part of the device=
 tree
>> > > > spec, either
>> > > > https://urldefense.com/v3/__https://www.devicetree.org/specificati=
ons/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnm=
of2zmk7BnhXCSnJPN$
>> > > > [devicetree[.]org] or
>> > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/k=
ernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_=
29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXl=
oYUaj$
>> > > > [git[.]kernel[.]org]
>> > > >=20
>> > > > "linux,scmi_mem" is currently absent. Are you aware of any upstrea=
ming
>> > > > activities to get "linux,scmi_mem" upstream under
>> > > > Documentation/devicetree/bindings in Linux?
>> > > >=20
>> > > > If "linux,scmi_mem" is going upstream in Linux, then we could use =
it.
>> > > > Otherwise, first "linux,scmi_mem" needs to be added somewhere unde=
r
>> > > > Documentation/devicetree/bindings (probably
>> > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we=
 can
>> > > > work on the Xen code that makes use of it.
>> > > >=20
>> > > > Does it make sense?
>> > > >=20
>> > >=20
>> > > Yes I agree. I think linux,scmi_mem and scmi_devid should be upstrea=
med.
>> > > I will add those properties to arm,scmi.yaml, mark them as related t=
o XEN and send patch.
>> >=20
>> > I didn't realize that linux,scmi_mem and scmi_devid are supposed to be
>> > Xen specific. In general, it would be best not to introduce Xen specif=
ic
>> > properties into generic bindings. It is a problem both from a
>> > specification perspective (because it has hard to handle Xen specific
>> > cases in fully generic bindings, especially as those bindings are
>> > maintained as part of the Linux kernel) and from a user perspective
>> > (because now the user has to deal with a Xen-specific dtb, or has to
>> > modify the host dtb to add Xen-specific information by hand.)
>> >=20
>> >=20
>> > Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? I=
t
>> > looks like a generic property that should be needed for the Linux SCMI
>> > driver too. Why the Linux driver doesn't need it?
>> >=20
>>=20
>> scmi_devid used during domain build. It passed as input parameter for SC=
MI_BASE_SET_DEVICE_PERMISSIONS message.
>> On non-virtualized systems - there is no need of this call, because OS
>> is the only one entity, running on the system.
>
> OK. Even if it is only required for virtualized systems, I think that
> scmi_devid is important enough that should be part of the upstream
> binding. I think it is worth starting an email thread on the LKML with
> Rob Herring and the SCMI maintainers to discuss the addition of
> scmi_devid to the binding.

Agree there. Also I want to point that there are other hypervisors, like
KVM, which may benefit from this.

Another approach is to name this node "xen,scmdi_devid", but I don't
like it.

>> I've chatted with Volodymyr_Babchuk and he gave a great idea to add a
>> list of device_ids to dom.cfg, such as:
>> sci_devs =3D [ 0, 1, 15, 35 ];
>>

Well, yes. We discussed this possibility, but personally I stick to
idea of re-using dt_dev, as we discussed in the different thread.

>> Using this approach, we can remove scmi_devid from the device tree and
>> just pass a list of scmi_devids to XEN using additional hypercall.
>> We can probably make hypercall taking devid list as input parameter.
>> This will take only 1 hypercall to setup sci permissions.
>
> But how would a user know which are the right SCMI IDs to add to the
> sci_devs list? Would the user have to go and read the reference manual
> of the platform to find the SCMI IDs and then write sci_devs by hand?
> If that is the case, then I think that it would be better to add
> scmi_devid to device tree.
>

Yes, ideally this needs to be done by BSP vendor in the device tree.


--=20
Volodymyr Babchuk at EPAM=


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 19:06:38 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 19:06:38 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251160.432412 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TPy-0003d5-N7; Thu, 23 Dec 2021 19:06:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251160.432412; Thu, 23 Dec 2021 19:06:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TPy-0003cy-IE; Thu, 23 Dec 2021 19:06:22 +0000
Received: by outflank-mailman (input) for mailman id 251160;
 Thu, 23 Dec 2021 19:06:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Yk4J=RI=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0TPw-0003cs-UR
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 19:06:20 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 67fad821-6423-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 20:06:19 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id BCD2961F3F;
 Thu, 23 Dec 2021 19:06:16 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACDB9C36AE9;
 Thu, 23 Dec 2021 19:06:15 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 67fad821-6423-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640286376;
	bh=T7SsKIyn7JWn4UKKcnnJm2co5Hs0PE+q/1wtRdLU5ME=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=u9nht8sgXBeDBP/8+pCxw536htt7cY8bAzNfySBKx3sXR9Ih7Jp0C1qfyfI8MjyLT
	 NnJrEktWuBPzpTvoHmpnAscEb/YpT3FTzxqB/9mvXViI0ZhR+rwyLjFqHqfv1nfX1q
	 A5INPCG/5XQp/nclJ3SNQT249bIo+EpSskV7JGDJ35QEpD2YUYQKupn90meFC610W7
	 R1B8a6J9gcO+lXUN8eW6GCilRIxl/KIaKacuohe5+J7HQRFEXmFthCr3KLaSgn7IY8
	 yHYk9EnhIugdJjzylwH7ffLyN2rMiBDkfqreKGjIGCCpDSjGIPT3LfGrJhrwwRUyDH
	 tGmKbR+s/omHw==
Date: Thu, 23 Dec 2021 11:06:15 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Stefano Stabellini <sstabellini@kernel.org>
cc: Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Anthony PERARD <anthony.perard@citrix.com>, 
    Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>, 
    Oleksandr <olekstysh@gmail.com>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>, 
    Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
In-Reply-To: <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
Message-ID: <alpine.DEB.2.22.394.2112231056380.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com> <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com> <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop> <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com> <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org> <87ee64x1hf.fsf@epam.com> <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
 <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Stefano Stabellini wrote:
> # Future Ideas
> 
> A great suggestion by Julien is to start supporting the dom0less partial
> device tree format in xl/libxl as well so that we can have a single
> "device_tree" option in dom.cfg instead of 4 (device_tree, iomem, irqs,
> dtdev).
> 
> Even with that implemented, the user has still to provide a partial dtb,
> xen,reg and xen,path. I think this is a great step forward and we should
> do that, if nothing else to make it easier to switch between dom0less
> and normal domU configurations. But the number of options and
> information that the user has to provide is still similar to what we
> have today.

I have just realized that if we start to parse the partial DTB in
xl/libxl the same way that we do for dom0less guests (parse "xen,path",
"xen,reg", and "interrupts", making dtdev, irqs and iomem optional)
actually we can achieve the goal below thanks to the combination:
"xen,path" + "xen,force-assign-without-iommu".

In other words, with dom0less we already have a way to specify the link
to the host node even if the device is not a DMA master. We can do that
by specifying both xen,path and xen,force-assign-without-iommu for a
device.

This is just FYI. I am not suggesting we should introduce dom0less-style
partial DTBs in order to get SCMI support in guests (although it would
be great to have). I think the best way forward for this series is one
of the combinations below, like a) + d), or a) + c) 


[...]

> So I think we should either:
> 
> a) extend dtdev to cover all devices, including non-DMA masters
> b) or add a new "device_assignment" property which is like dtdev but is
>    the list of both DMA masters and non-DMA masters
> 
> Either way, when non-DMA masters are present in the
> dtdev/device_assignment list we could either:
>     c) require force-assign-without-iommu="true" in dom.cfg
>     d) or print a warning like:
>     "WARNING: device assignment safety for device XXX cannot be
>     verified. Please make sure XXX is not a DMA mastering device."


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 19:07:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 19:07:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251163.432422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TQR-00047z-Tt; Thu, 23 Dec 2021 19:06:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251163.432422; Thu, 23 Dec 2021 19:06:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TQR-00047s-Qi; Thu, 23 Dec 2021 19:06:51 +0000
Received: by outflank-mailman (input) for mailman id 251163;
 Thu, 23 Dec 2021 19:06:50 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pwdt=RI=epam.com=prvs=29912ec7ef=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0TQP-0003cs-RU
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 19:06:50 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 79a741fe-6423-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 20:06:48 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BNISA3Y001440;
 Thu, 23 Dec 2021 19:06:44 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d4weq87d1-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 23 Dec 2021 19:06:44 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7277.eurprd03.prod.outlook.com (2603:10a6:102:107::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Thu, 23 Dec
 2021 19:06:38 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021
 19:06:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 79a741fe-6423-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NGFZa64oQWmbKCWFIRbRcN0MYlzDkUk+iu3UEViEwM46nIlngsQ2Zwc5BIqO8vgBNDvSgDT+nsU+8EDHJ1dfjKSjyODZDHXseZBF7H2qhJ0lhdGiNEejNDh08IAFw/KoF1/nQIJTSdIAD4QerpfhphBfFmN5golVSq8PLB3z+pr2M48CxTjySyb6YqwxAWeWdmvYIOntiF2M5UA8HPtWpkoso+lDA0C4lQAng2Cd6xnI/JB0Gv1snrjBwC70FtYVqpC4GpkCV5KL53QvpMyMilFxtHUknpXNtQlvftCTQweO6nkm5zMJo8cEHc8FcsMYNOQKYow8Pui3ZhUShanH0w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=isnspActnNnDqfkhO67r+EGE+kG6a1RK16rZ2F5/wU4=;
 b=RP4mJFdjHzGbIWHDsCuGr71AXekZ7inTvAK0q2e4VTXOG0sfd2nxltPfyjRXv8W7R2FI3dREYlFqdJ3Mi2wtH5r4LgmRYopxA6ZFpXZ5yd1RQhLbYzv40E+8DtR8XZadyikZfc2WrPXBABcYTYoMuOXgmbInA3qLR4RTno89NuBAMV6b0TuxFVCUL4zdXwBEOs1AgCiidaVSLoEn2Wm5XueRzcvMQ9FfD10UbxUS2fd6jbEKZlRyN2NTnRW7hzSSws5RaueUfWcwjXLbCg+USQZ8133tG094JDhVWvW0V29yfb3KMrkJQmhG+IlWCNjpNRLP2BFMb6sFmrnyhT918g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=isnspActnNnDqfkhO67r+EGE+kG6a1RK16rZ2F5/wU4=;
 b=KW51AkDrA2KlpbKev7orMuiNk4/ETm7F3784PS/CGnPksZGmfT7/d+vds9nE+LTJXfXh2zxoDAHfSZ1eU6ag2oAjYzz/7dfUDy3e3yCF2KbPBGGVRLNmXDQ9OttQg8cflnYuwMIEze9+Z+/YS0dj2UPvgFQ/G/G1NKju8QSayr3Gfw48HDRzf3LHxarHM3P+LXgHJX8qPWrNbxlp1oxDDw6ycp2vQw/0F5iGzqhNIJSlSfCvzmpyAxql8g1SoPgn0zo8TC24gcuROnRD3AkXBcvrOBj34rsXPOU2pDDSGts93QqEdzdBAWphD7zAOvXoYbEL6nPlIHsSdWLqFRdBFQ==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuAgAAWSACAAOV/AIABANAAgAEYTIA=
Date: Thu, 23 Dec 2021 19:06:37 +0000
Message-ID: <20211223190637.GA99855@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 56d7e3b1-e181-46fc-892b-08d9c6475884
x-ms-traffictypediagnostic: PA4PR03MB7277:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7277ABBB59C1700D9E5AE1BAE37E9@PA4PR03MB7277.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 b7eg7okivi7Xe5DUNa6yLH/IwVXMMIGiw7o091ubv3PlIJpW02o/MsDt1O5xWXkei7lY061nAZXHU9aGrOqgQlHzVrxIFWH2cpuAO3WpjRC66Cu3nDuUEOB2tlmNZhQy++XELbHe7/i9Q7iuDtp1sAff7tFnbRhWWGZFjha8YwTSqnbAe6r8MarPct5BnvMdTfuSK+0uElwExj4ZBU0ATOVFYLUMOAoYcIKqpSe0yxiPc+0LIYKmgs4ZGsYx0x9sVMo7+u+0O322wANuY00D5J/+eoUvIKcci9di+A4wCp6fewkc1SrWrPm7GQDkDXNqchgGDT8yNb5ilQLuNLxzHJ1EevAakA2snCzYTtKmZfMvGkXnkv+OInVf4ggK+S1g/b5U16t9VPBKlQwuHqlXDnCJvhhullf94T4oneGMgArG5jr3LFnVw9YU4GSWcJSJmb+wY5tzk8ocTtdbBnMCPuBoGz9RSYbue9bInMWe4IWymBAFE9fgWiL8EXJZL+oe1/qtTJSd6+8MA5FwLTfnzirXW6rUhOW3q7sjQFX8gsBPLZMvDBx4YnnTgh7Uziuf459SKzY5vw06sr7q27qN7zGMdxdYpAOMxKf1FYYTOXNiMYCu0DgecEv1auaLO0jPmMBda2JWu7gtmB+BbzwE7tvxdsiaKqShyd/bfKYNieOQeTUoNQS1mRL+Br0qQVdq7PGhnMYMYFLKd1qylEkNlrELtGh60j6iEXgmfAsv4Bb0iEuYF1FvUaiJA35UgQQ6oXp0UeJDUM7bTMMG+m9r9RZLrieVH3j3EZGXOamTNwY9jsXdyQJ+gJ9o2Oh1y7+d
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66946007)(33656002)(64756008)(66446008)(8676002)(6512007)(316002)(76116006)(91956017)(9686003)(38100700002)(5660300002)(71200400001)(86362001)(66556008)(66476007)(4326008)(54906003)(38070700005)(122000001)(33716001)(8936002)(6486002)(966005)(83380400001)(1076003)(2906002)(6506007)(6916009)(26005)(186003)(30864003)(508600001)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?/7tBUOwrxCxrojFtWIsHUT7DQpj/C48P5MXQqhjvDZK8Muce+AZZTSgChJTG?=
 =?us-ascii?Q?Wqd4Z52e8QQR6pu/oZV/24MU2j8EaJf5nEDj8vLoAVmOKIYkwtKWq0Pphcck?=
 =?us-ascii?Q?hd+GpVz8TQrv1ggvdmQARIMM6K43MezLhFzD7LKwlVcSZLcV45KNG4D9zzcl?=
 =?us-ascii?Q?jz9H/4GJy8hwSPPyPHwacMTzEym5OF6AtcZbKe9ZXX8b5cV7n2M7FSEjKuzZ?=
 =?us-ascii?Q?lU4FZCZVFU/KT8iI+0db2yhQi44UfIKjHhOg57wcHSGsBTgTlck0ZE4vGzls?=
 =?us-ascii?Q?OdeXYV9i5rvgiHDOuzwcgnDJlhYKJhbm3EF712PVDwJBK9IFTrAAk3vJ3yez?=
 =?us-ascii?Q?F0vbzEmSm591mZbSAAvf+iBbHhP9WdqB5cCc75nS1VI0gYOtVHue07D/zyhe?=
 =?us-ascii?Q?8qcOTx5pOAG28N9ddNh9qlFJNg76GyPKtAM/FHLPafgwmfNhxLeIGXnEh+FR?=
 =?us-ascii?Q?bfsPiMWNhmNoqHVe5yvTwjV/xCdiUI6SPBuv4+hJ1jEoyQFQNED6wPKs3D7X?=
 =?us-ascii?Q?19jpXjGWu980x8NLOEmbFSbORd88Y4xTz6vLsHoFeXEq1xeGX/SoaabpK14K?=
 =?us-ascii?Q?VdOg34IBTeSgdRSW13IwDqQkAiCkWayTRmaUBsso4aHXeQZZqkq+EvtkYSaV?=
 =?us-ascii?Q?DpYprQzPbkxyiqIDiTmcMrqNV+bqTs90ZaE7UaCxz6ZnHShWPu/cpdUB2/PG?=
 =?us-ascii?Q?Cm7FNTN7X2umYrBKTOqIIicjohdIyNBd+K2YDJbiJxqMQ9ZnmyDRR3qPSUmo?=
 =?us-ascii?Q?NarlIDFs/MbmE7ZXwyLZybLPhBmJfeaniIEhOOhBauJq54oiCG2qjfF8kpRZ?=
 =?us-ascii?Q?uVd+4RmDwt1GoZMo6E4jNAGyg06NnxUv3g9LJb0VLfn7KP5m2KJJqzWmvFJJ?=
 =?us-ascii?Q?UvWVCTk07e6fkO5fpqARGv5PxXggznJIZxRu5u1UCoZz7LDHFC4f5NwueBqI?=
 =?us-ascii?Q?ktoqHSjlYJNaW4Ghks4+3dDYs/KPqrIJhKsgvmohhLCI728raJ5CCsAmH5Il?=
 =?us-ascii?Q?vn2JnBEUK1u3LfZX1pvYXJgBQt7FEiGTVPUJEOJ9yENs1wY1u+MQn73r2ksO?=
 =?us-ascii?Q?P2rDzd73woYqaGEoBDeo6wvewJkfiR5sLfDQPgOIkEY40Z4ujwZWZ6BMG2lR?=
 =?us-ascii?Q?meRjTo2m0CL4p1Cx/aNAbJb2NMoI84HPT1OBIOaPTA11mBqxNeenkjVKykZR?=
 =?us-ascii?Q?/LQjA3rP62znBI1aFxj6xIqV4aQ693C0hRycNILOXn03GLeLVNlMo5gG3pN0?=
 =?us-ascii?Q?fuvVzPgdgsIKooD8D19VfoV4D/+bCPJ6zxAeTc8g6bixCPsczlxk7/WUIYpz?=
 =?us-ascii?Q?0s9qqaacKFzPM95Ha8zoC/K2C4kV1WnY/RQ7wVJCAIfUhfCcwdwJSiVi4DQa?=
 =?us-ascii?Q?7kne6BPdAYRoj3Yt3BkTw6nGKi6mgFEzKDTcNeEhrwtXqEUhXEs2VSAAEGDJ?=
 =?us-ascii?Q?jOLOZkdbso6zgiJa73wXPqz/+Dkw2RziME+hinKrwRNhX0/j2NOh9T4VtCKa?=
 =?us-ascii?Q?DI1asejiUsac0G3eVmCBid3k1FOIyO3zkFQeWG2gJoTJAfPCWPzLmeYq7RGw?=
 =?us-ascii?Q?0AoY04thrxxUn7vOO4GRd/XlsFaTvVI78yKDBb03nEsTVNDxwRrt/2h8ZrBm?=
 =?us-ascii?Q?Sm+8N8yeWCxdFo3vIkEkKvinJotEueUFVfey6SJ0bi6D7QVnxuvNMorJ/6OV?=
 =?us-ascii?Q?9qFkBaHng4VHOPLzbKJ6+bd1kWA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <57E7879188A0A345A05313FCFD76F673@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56d7e3b1-e181-46fc-892b-08d9c6475884
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 19:06:37.8600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ONlXLrgmcAAFeJJ7gDWrbelCidzVF6SjgbcrCPVcrHd6hgABswDWHk/d8fbMX+DuSR9M/TIjnDPvI88A9VrqLWsADYkFZ0Df11aAwMLo84k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7277
X-Proofpoint-GUID: 5OucUIc5rNCnYTy6BvyJZzZulGycsCAa
X-Proofpoint-ORIG-GUID: 5OucUIc5rNCnYTy6BvyJZzZulGycsCAa
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-23_04,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0
 priorityscore=1501 bulkscore=0 clxscore=1015 mlxscore=0 adultscore=0
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230099

Hi Stefano,

On Wed, Dec 22, 2021 at 06:23:24PM -0800, Stefano Stabellini wrote:
> On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> > On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
> > > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> > > > Hi Stefano,
> > > >=20
> > > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> > > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > Hi Stefano,
> > > > > >=20
> > > > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wr=
ote:
> > > > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > > This is the implementation of SCI interface, called SCMI-SM=
C driver,
> > > > > > > > which works as the mediator between XEN Domains and Firmwar=
e (SCP, ATF etc).
> > > > > > > > This allows devices from the Domains to work with clocks, r=
esets and
> > > > > > > > power-domains without access to CPG.
> > > > > > > >=20
> > > > > > > > The following features are implemented:
> > > > > > > > - request SCMI channels from ATF and pass channels to Domai=
ns;
> > > > > > > > - set device permissions for Domains based on the Domain pa=
rtial
> > > > > > > > device-tree. Devices with permissions are able to work with=
 clocks,
> > > > > > > > resets and power-domains via SCMI;
> > > > > > > > - redirect scmi messages from Domains to ATF.
> > > > > > > >=20
> > > > > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.co=
m>
> > > > > > > > ---
> > > > > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++=
++++++++++++
> > > > > > > >  xen/include/public/arch-arm.h |   1 +
> > > > > > > >  5 files changed, 809 insertions(+)
> > > > > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > > > >=20
> > > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > > > > > index 186e1db389..02d96c6cfc 100644
> > > > > > > > --- a/xen/arch/arm/Kconfig
> > > > > > > > +++ b/xen/arch/arm/Kconfig
> > > > > > > > @@ -114,6 +114,8 @@ config SCI
> > > > > > > >  	  support. It allows guests to control system resourcess =
via one of
> > > > > > > >  	  SCI mediators implemented in XEN.
> > > > > > > > =20
> > > > > > > > +source "arch/arm/sci/Kconfig"
> > > > > > > > +
> > > > > > > >  endmenu
> > > > > > > > =20
> > > > > > > >  menu "ARM errata workaround via the alternative framework"
> > > > > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kc=
onfig
> > > > > > > > new file mode 100644
> > > > > > > > index 0000000000..9563067ddc
> > > > > > > > --- /dev/null
> > > > > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > > > > @@ -0,0 +1,10 @@
> > > > > > > > +config SCMI_SMC
> > > > > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > > > > +	default n
> > > > > > > > +	depends on SCI
> > > > > > > > +	---help---
> > > > > > > > +
> > > > > > > > +	Enables mediator in XEN to pass SCMI requests from Domain=
s to ATF.
> > > > > > > > +	This feature allows drivers from Domains to work with Sys=
tem
> > > > > > > > +	Controllers (such as power,resets,clock etc.). SCP is use=
d as transport
> > > > > > > > +	for communication.
> > > > > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/M=
akefile
> > > > > > > > index 837dc7492b..67f2611872 100644
> > > > > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > > > > @@ -1 +1,2 @@
> > > > > > > >  obj-y +=3D sci.o
> > > > > > > > +obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
> > > > > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci=
/scmi_smc.c
> > > > > > > > new file mode 100644
> > > > > > > > index 0000000000..2eb01ea82d
> > > > > > > > --- /dev/null
> > > > > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > > @@ -0,0 +1,795 @@
> > > > > > > > +/*
> > > > > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > > > > + *
> > > > > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > > > > + *
> > > > > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > > > > + *
> > > > > > > > + * This program is free software; you can redistribute it =
and/or modify
> > > > > > > > + * it under the terms of the GNU General Public License as=
 published by
> > > > > > > > + * the Free Software Foundation; either version 2 of the L=
icense, or
> > > > > > > > + * (at your option) any later version.
> > > > > > > > + *
> > > > > > > > + * This program is distributed in the hope that it will be=
 useful,
> > > > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warr=
anty of
> > > > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  S=
ee the
> > > > > > > > + * GNU General Public License for more details.
> > > > > > > > + */
> > > > > > > > +
> > > > > > > > +#include <asm/sci/sci.h>
> > > > > > > > +#include <asm/smccc.h>
> > > > > > > > +#include <asm/io.h>
> > > > > > > > +#include <xen/bitops.h>
> > > > > > > > +#include <xen/config.h>
> > > > > > > > +#include <xen/sched.h>
> > > > > > > > +#include <xen/device_tree.h>
> > > > > > > > +#include <xen/iocap.h>
> > > > > > > > +#include <xen/init.h>
> > > > > > > > +#include <xen/err.h>
> > > > > > > > +#include <xen/lib.h>
> > > > > > > > +#include <xen/list.h>
> > > > > > > > +#include <xen/mm.h>
> > > > > > > > +#include <xen/string.h>
> > > > > > > > +#include <xen/time.h>
> > > > > > > > +#include <xen/vmap.h>
> > > > > > > > +
> > > > > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > > > > +
> > > > > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0=
056C) */
> > > > > > > > +#define SCMI_SUCCESS              0
> > > > > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > > > > +#define SCMI_DENIED             (-3)
> > > > > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > > > > +#define SCMI_BUSY               (-6)
> > > > > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > > > > +
> > > > > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-sm=
c")
> > > > > > > > +
> > > > > > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem=
"
> > > > > > >=20
> > > > > > > I could find the following SCMI binding in Linux, which descr=
ibes
> > > > > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > > > >=20
> > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > >=20
> > > > > > > However, linux,scmi_mem is not described. Aren't you supposed=
 to read
> > > > > > > the "shmem" property instead? And the compatible string used =
for this
> > > > > > > seems to be "arm,scmi-shmem".
> > > > > > >=20
> > > > > >=20
> > > > > > We use linux,scmi_mem node to reserve memory, needed for all
> > > > > > channels:
> > > > > >=20
> > > > > > reserved-memory {
> > > > > >     /* reserved region for scmi channels*/
> > > > > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > > > > >         no-map;
> > > > > >         reg =3D <0x0 0x53FF0000 0x0 0x10000>;
> > > > > >     };
> > > > > > };
> > > > > >=20
> > > > > > arm,scmi-shmem node used in shmem property defines only 1 page =
needed to
> > > > > > the current scmi channel:
> > > > > >=20
> > > > > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > > > > >     compatible =3D "arm,scmi-shmem";
> > > > > >     reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > > > > > };
> > > > > >=20
> > > > > > For each Domain reg points to unigue page from linux,scmi_mem r=
egion,
> > > > > > assigned to this agent.
> > > > >=20
> > > > > If we were to use "linux,scmi_mem" we would have to introduce it =
as a
> > > > > compatible string, not as a node name, and it would need to be de=
scribed
> > > > > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > > > >=20
> > > > > But from your description I don't think it is necessary. We can j=
ust use
> > > > > "arm,scmi-shmem" to describe all the required regions:
> > > > >=20
> > > > > reserved-memory {
> > > > >     scp-shmem@0x53FF0000 {
> > > > >         compatible =3D "arm,scmi-shmem";
> > > > >         reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > > > >     };
> > > > >     scp-shmem@0x53FF1000 {
> > > > >         compatible =3D "arm,scmi-shmem";
> > > > >         reg =3D <0x0 0x53FF1000 0x0 0x1000>;
> > > > >     };
> > > > >     scp-shmem@0x53FF2000 {
> > > > >         compatible =3D "arm,scmi-shmem";
> > > > >         reg =3D <0x0 0x53FF2000 0x0 0x1000>;
> > > > >     };
> > > > >     ...
> > > > >=20
> > > > > In other words, if all the individual channel pages are described=
 as
> > > > > "arm,scmi-shmem", why do we also need a single larger region as
> > > > > "linux,scmi_mem"?
> > > > >=20
> > > >=20
> > > > That was my first implementation. But I've met a problem with
> > > > scmi driver in kernel. I don't remember the exact place, but I reme=
mber
> > > > there were some if, checking if memory weren't reserved.
> > > > That's why I ended up splitting nodes reserved memory region and ac=
tual
> > > > shmem page.
> > > > For linux,scmi_mem node I took format from /reserved-memory/linux,l=
ossy_decompress@54000000,
> > > > which has no compatible string and provides no-map property.
> > > > linux,scmi_shmem node is needed to prevent xen from allocating this
> > > > space for the domain.
> > > >=20
> > > > Very interesting question about should I introduce linux,scmi_mem n=
ode
> > > > and scmi_devid property to the
> > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> > > > Those node and property are needed only for Xen and useless for
> > > > non-virtualized systems. I can add this node and property descripti=
on to
> > > > arm,scmi.yaml, but leave a note that this is Xen specific params.
> > > > What do you think about it?
> > >=20
> > > Reply below
> > >=20
> > > [...]
> > > =20
> > >=20
> > > > > In general we can't use properties that are not part of the devic=
e tree
> > > > > spec, either https://urldefense.com/v3/__https://www.devicetree.o=
rg/specifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQ=
iQYC595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/=
kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF=
_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhX=
loYUaj$ [git[.]kernel[.]org]
> > > > >=20
> > > > > "linux,scmi_mem" is currently absent. Are you aware of any upstre=
aming
> > > > > activities to get "linux,scmi_mem" upstream under
> > > > > Documentation/devicetree/bindings in Linux?
> > > > >=20
> > > > > If "linux,scmi_mem" is going upstream in Linux, then we could use=
 it.
> > > > > Otherwise, first "linux,scmi_mem" needs to be added somewhere und=
er
> > > > > Documentation/devicetree/bindings (probably
> > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then w=
e can
> > > > > work on the Xen code that makes use of it.
> > > > >=20
> > > > > Does it make sense?
> > > > >=20
> > > >=20
> > > > Yes I agree. I think linux,scmi_mem and scmi_devid should be upstre=
amed.
> > > > I will add those properties to arm,scmi.yaml, mark them as related =
to XEN and send patch.
> > >=20
> > > I didn't realize that linux,scmi_mem and scmi_devid are supposed to b=
e
> > > Xen specific. In general, it would be best not to introduce Xen speci=
fic
> > > properties into generic bindings. It is a problem both from a
> > > specification perspective (because it has hard to handle Xen specific
> > > cases in fully generic bindings, especially as those bindings are
> > > maintained as part of the Linux kernel) and from a user perspective
> > > (because now the user has to deal with a Xen-specific dtb, or has to
> > > modify the host dtb to add Xen-specific information by hand.)
> > >=20
> > >=20
> > > Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? =
It
> > > looks like a generic property that should be needed for the Linux SCM=
I
> > > driver too. Why the Linux driver doesn't need it?
> > >=20
> >=20
> > scmi_devid used during domain build. It passed as input parameter for S=
CMI_BASE_SET_DEVICE_PERMISSIONS message.
> > On non-virtualized systems - there is no need of this call, because OS
> > is the only one entity, running on the system.
>=20
> OK. Even if it is only required for virtualized systems, I think that
> scmi_devid is important enough that should be part of the upstream
> binding. I think it is worth starting an email thread on the LKML with
> Rob Herring and the SCMI maintainers to discuss the addition of
> scmi_devid to the binding.
>=20

Ok I will start the thread about scmi_devid.
>=20
> > I've chatted with Volodymyr_Babchuk and he gave a great idea to add a
> > list of device_ids to dom.cfg, such as:
> > sci_devs =3D [ 0, 1, 15, 35 ];
> >=20
> > Using this approach, we can remove scmi_devid from the device tree and
> > just pass a list of scmi_devids to XEN using additional hypercall.
> > We can probably make hypercall taking devid list as input parameter.
> > This will take only 1 hypercall to setup sci permissions.
>=20
> But how would a user know which are the right SCMI IDs to add to the
> sci_devs list? Would the user have to go and read the reference manual
> of the platform to find the SCMI IDs and then write sci_devs by hand?
> If that is the case, then I think that it would be better to add
> scmi_devid to device tree.
>=20
> In general, I think this configuration should happen automatically
> without user intervention. The user should just specify "enable SCMI"
> and it should work.
>=20

Ok. This sounds reasonable.

>=20
> > > In regards to linux,scmi_mem, I think it would be best to do without =
it
> > > and fix the Linux SCMI driver if we need to do so. Xen should be able=
 to
> > > parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) shou=
ld
> > > be able to parse the "arm,scmi-shmem" nodes generated by Xen. Either
> > > way, I don't think we should need linux,scmi_mem.
> >=20
> > This requires further investigation. I will try to make implementation
> > without linux,scmi_mem, using only arm,scmi-shmem nodes and share
> > reuslts with you.
>=20
> OK, thanks.

One more question: As you probably seen - Jan had a complains about SCI
term. He said SCI is ambiguous with ACPI's System
Control Interrupt. I think of using SC (as System Control) instead. What
do you think about it?=20

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 19:12:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 19:12:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251168.432433 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TVV-0005vm-Ld; Thu, 23 Dec 2021 19:12:05 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251168.432433; Thu, 23 Dec 2021 19:12:05 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TVV-0005vf-IM; Thu, 23 Dec 2021 19:12:05 +0000
Received: by outflank-mailman (input) for mailman id 251168;
 Thu, 23 Dec 2021 19:12:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pwdt=RI=epam.com=prvs=29912ec7ef=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0TVT-0005vZ-LH
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 19:12:03 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 34ef186f-6424-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 20:12:02 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BNIRrAJ024151;
 Thu, 23 Dec 2021 19:11:50 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d4u0p0qk9-2
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 23 Dec 2021 19:11:50 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7277.eurprd03.prod.outlook.com (2603:10a6:102:107::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Thu, 23 Dec
 2021 19:11:44 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021
 19:11:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 34ef186f-6424-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gtZJyA1jsUqD8qfzGWQIu1zplsEjF7KAQXgZE/3JBnH3lXw7i9Gn107902mltyJZGzLzxhm0gS0f1L3B4D+5g3hiK/WhR+N0E17m3U1FKdfPS9GTMoQAWWbxObHJaQ0/qi2bLN+cTTPPOfj06ZDN5+zwisWMPTpIiHYjnQbIYf6q47gFJ+AJEh9hYhetV0vQi2Q1sBwuA4zhEatV1YKrgKGpL92HCjBTFY9+K7C8iW+oo3Lci0VUkl2pcB/558H0Y3CsiypUGeyU34lDOjSfn4CFPtz2K0bRgpesye5iF8lRl850kWpJmQChZm6bU0NA4FZkWw7VfFrV5xkqgrEwhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=InUROT1dthpWZRzvpRvyssmT17opcVX/IN42VN0LxE4=;
 b=YyxqSNUYASzv+aENtKaGcQrYZzmcSfDfJWF9OXCev9q1H2MgqJPqUdQYRY9LEGIrt6/q8hzxhQWjifk2froiZ4QUZu0qqwuXzJK83pQ+RArc/kPMPNwVXqHNG/rmRI88NCmcB4QwwIfWyKe+JAIuJWdfunvT+mzkrqR4/3XmyyoKKu7JqqbVcPrOO3BU3Vov76W5BDUh6EcLRh7ebCYhQ1EEgVhVeK7h2PBfN8VASVMpQ9L7KfLRMhyPxAh9TokG3iH8henrFXxrFCs0EVd2SlVjo2f+e7GRr6CnGwntUAeZZ220uUOA5hPZ6/cNHc4OKnAOLqnJa7Vy8+Sb9YFB3g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=InUROT1dthpWZRzvpRvyssmT17opcVX/IN42VN0LxE4=;
 b=BzLeldeDxdlbdCmTi/kX/3JqInBPcXQYV+/4fzGjCN3l7kz9KN7da46xfBXK5O72b5uhDzOZPGDA2pqqHziXzkxTmcCnvhneKzwSdSJl42hU1Os+XtL4hd60fbbekzdV7GWFsdhsBpZ+UBg2IQoMsuGFP6jJNVGHbg82zqakaBqsjt6pe4PHPpnp+/zILD7ec4KgNAwuVC8zzTSJclE/2jE7S+b8DmLpB14Nr1J0fw2b+Y+O+OF7sdzWJMHEHQXsxzZaUHYswmZNnN6cq5uNiOk4ac94C7oUIzlss9Gs6zzurorCXGY7an6as69fQVUgvaydW3d8t/egzRGKanVpKg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>,
        Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>,
        Anthony PERARD <anthony.perard@citrix.com>,
        Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Wei Liu <wl@xen.org>, Juergen Gross
	<jgross@suse.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        George Dunlap
	<george.dunlap@citrix.com>,
        Jan Beulich <jbeulich@suse.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Topic: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
Thread-Index: 
 AQHX8M3LpzWz4l8PQUiIA2nAUV0H+qw0P2iAgAJehQCABnNTgIAAc5MAgADFCgCAAB+dgIAAA54AgAARtoCAABUwgIAA0niAgAEZxoA=
Date: Thu, 23 Dec 2021 19:11:44 +0000
Message-ID: <20211223191143.GA101400@EPUAKYIW015D>
References: <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com>
 <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org> <87ee64x1hf.fsf@epam.com>
 <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
 <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fcbed282-fa74-40fd-3707-08d9c6480f45
x-ms-traffictypediagnostic: PA4PR03MB7277:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7277A16822A16D11BD19F624E37E9@PA4PR03MB7277.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 /K9ZmGdvjb3u+IJB2DYbO8fvokXx+qfhfb8Rgds1hrlaE1oTMPezk6NVzobMgTXJQguFn+K3cp+YuywxSLTI8nvGwy+J5wNv9saSKEx5LxUZfCNsrMVjCT10W24hubCukqdAOjD8mdwSHDSGw3iR1WVsN9tcDjuLJCoqzWMe02b4vELuHXrvUER4/hOW93Br1sQ/1QrGRuJ3ipgc7Pemg9dHvHRM8JemU2IlK5633Hzm0K4iKITRV8XdyE2q+280mCGHWHwJK3I2gDmmy9rF7doNLyrt2FBVfnkXPUuJd5hIvdboFRmLY164T6SX5OTJvW8rlmDnSjKQkL+X1oswd6XhfK0r2oAa/pMrtsd/F34Kbl2VIhJPgRfdvTClKx7qyzfsNbvXvtb3FUyLlSnP7CHj8o1F7IIRNJCrLFGH+Ws547W7Zd1+VeXduVyXrvTn1eeZteE2OGtjJQL6SkQCako54lq9mzulYjCtE0Au8NFgVRjYHXKZou046ubQy4/29bHaJ377AdQJL/WTwVyC40L+PkV2EffEyM3Bj60b/VP6lPIeVAwKfuAlxC48mqvM3gIjFOIGQ1uc/dchDRgYE0z4l47ADFaa6h0BFtDbyoo0cNgq7eRCxhl6mmBWRowF3hG+LrS1MH0b9d8aiZD8c8KOc9t5KTrnZqMZf2vXUQvJ3oJd7bGuBpdtmyYDdds1UrEfYfuchsupiRgUrN0x5VLvt7hviXwM/1LXBscJWEY=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6506007)(83380400001)(1076003)(2906002)(30864003)(7416002)(508600001)(26005)(186003)(6916009)(66476007)(76116006)(6486002)(316002)(91956017)(9686003)(38100700002)(66946007)(33656002)(64756008)(66446008)(6512007)(8676002)(5660300002)(4326008)(54906003)(122000001)(33716001)(8936002)(38070700005)(66556008)(71200400001)(86362001)(21314003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?zZWJq9Dvti7VsIGM6jc28cKwdxLyCyBjHIWoVHHlb5bUaT/yYD8V0x4re15D?=
 =?us-ascii?Q?kSe7mZKxxz7D/HFJ9A/L73FKONkcPIKYO0q3A4ZQnHO6UX59HMOP1Z7Fc9Y4?=
 =?us-ascii?Q?BQeiD4jXe6EGfHhLCX6ardj1yXE6ruImsC8uTYEbS+I/sxzIi24UfkkEMXBC?=
 =?us-ascii?Q?+7wfqutbPChluDcxetqyOZ+vn3KoaqRRHiAgYiA/JaYsNh3ZoWjLTe/eau74?=
 =?us-ascii?Q?Zi/hScyzVYE+nroaDZaWuag6G1Ec6qTpan2vr1dnbK+uiMOwJh6GWfWNskVU?=
 =?us-ascii?Q?IVmfVEC0eYMWsZcGVxLVCmp7hCsxCg/lIouRAIIHdIH9vTj86zrQlYwv7gak?=
 =?us-ascii?Q?hsT0KEhyuTYLCel1027WXn2j4puRGvu186qywwtCIyBKKEzqmkx/H2DIdQQG?=
 =?us-ascii?Q?MqcboAgJrn7Ss5DuzpO2msEU+9CKrNIfixh2w7KlHFHsvH9ubfWMswInsO6g?=
 =?us-ascii?Q?+DzEdBlbP8RDlkwjimWOr/i8k+cJqRUSB8pSjWkXkyW8M51UnqcV3IEwyzZT?=
 =?us-ascii?Q?73yK/ZVoK2mHJvCvQ4uSy120uMjSwddN0IUqpQEvJU2Qtj7cStdwP4O9/uFi?=
 =?us-ascii?Q?4jRxZ0Qu9jC+bipmF4OICGsNqgv9hKZjymCXzouQ9nSHVsHWiuRx5yG2Fgdj?=
 =?us-ascii?Q?LxqwkMBeBB83G8xb45EkSSq5Jz7zoZcqpEmLt9G6hia+RhwIDI5CV7mJu2ES?=
 =?us-ascii?Q?zR2TrW2lmkCVO3FPc62hPphcyvFuyGXRQNuKiVs5uarvOgVeuMc6gb+dGU09?=
 =?us-ascii?Q?qqUrTYFx6OL8DodLgdr0CObnXRzefLS3oZSIzKipZSfaKwYlK1g0HjmbV3Ao?=
 =?us-ascii?Q?CtU29iJgYxR3t+rVZC9/5rfOGFViNyANlsAHcxr8krL2CjL5EdYBo3e6srz5?=
 =?us-ascii?Q?a0vvOfTvKfjobErZ9FmxnipAA/cfjqhyHHvZlH33YA4xpF4UD6yL1PeXKd/a?=
 =?us-ascii?Q?RjwYJfcxLcik/KN9YNJW+bA7AC6pecGLM7gFrCYrK9TUfUfz+FGxyVXPNfTz?=
 =?us-ascii?Q?8yAwpRjf/ez5QB4QqN6ijbW+qT4raayUQRkrurxnfZ22oR/pIsNK9qjbRkL0?=
 =?us-ascii?Q?rIq/xm8wKxj4fF54qFymVCWmoT/yrTT8S1FtvEomyX2P+kVesKJuyRRST+Gj?=
 =?us-ascii?Q?2Zy5ESUdvnfonvmhOMjY7tpAjxooqihrtMauOy+To9Lsnu2xVlBNvVLPcmwz?=
 =?us-ascii?Q?GL41YNPso0fHORXU23lKxYyAPQ93z4NysftIFnobF7dQWghcSUt3ID1Zu+Fc?=
 =?us-ascii?Q?CqjHCrE4v5CYdjjFES7FBlo058SLAxj7YW6DwZoqsg/GGiQD5vaTQFtHG9jA?=
 =?us-ascii?Q?cFQEPYI4pbd83qCVXkceOaF2VdEw0e4lIhajmw6u0KABL3prXYm75ypKRV4R?=
 =?us-ascii?Q?Z1oivbkGTWN+CbWMeXt4N91cKY4Mud/aJrf8qq1sP+zZlvqM0mU0gduf2jyD?=
 =?us-ascii?Q?f21Sy3TB/+1b5G1Ezu1eZAwTOt8ywDwpPMVoC+ku6c014HKSxeQeYwieK403?=
 =?us-ascii?Q?ooZ8Zd1Y+WsjTpYzI3a6/GSCLr7txdlpUSYBfLFexvBB4zEZyIk9RgGzOxUB?=
 =?us-ascii?Q?r9ldaKpZYoEyQkELog8Q70dPRHq6JZ5BWwNOqkU/Fx+fSWu1V/Z8/cKY0Q89?=
 =?us-ascii?Q?y9LKDs1++bt7a7IYke3oLY4egeFBduEy5GhfKf2ni6L208oB0uLZ4fIgzE6J?=
 =?us-ascii?Q?q/xBJYhX44JRhY+QU4p+d0+tILw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <39DB09D8ABCF2F4E82EF18B7C7163BB7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcbed282-fa74-40fd-3707-08d9c6480f45
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 19:11:44.4993
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PafnMqC2kOetfswP4S4iI3+HUwSB6eQcV/ignkfOpkvZ9H8C9IOwhceFAfmz5yIs+lOusn7O5nCk+5uUYItMgV3qASfhjLwmBxa2hAFi/V4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7277
X-Proofpoint-GUID: U_ij-HNWsK2nxz_qDz521DZkzo414s2A
X-Proofpoint-ORIG-GUID: U_ij-HNWsK2nxz_qDz521DZkzo414s2A
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-23_04,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0
 mlxlogscore=999 spamscore=0 impostorscore=0 adultscore=0
 lowpriorityscore=0 clxscore=1015 suspectscore=0 priorityscore=1501
 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230100

Hi Stefano,

On Wed, Dec 22, 2021 at 06:23:13PM -0800, Stefano Stabellini wrote:
> On Wed, 22 Dec 2021, Julien Grall wrote:
> > > > > > > To me dtdev and XEN_DOMCTL_assign_device are appropriate beca=
use
> > > > > > > they
> > > > > > > signify device assignment of one or more devices. We are not =
adding
> > > > > > > any
> > > > > > > additional "meaning" to them. It is just that we'll automatic=
ally
> > > > > > > detect
> > > > > > > and generate any SCMI configurations based on the list of ass=
igned
> > > > > > > devices. Because if SCMI is enabled and a device is assigned =
to the
> > > > > > > guest, then I think we want to add the device to the SCMI lis=
t of
> > > > > > > devices automatically.
> > > > > >=20
> > > > > > I am OK with re-using dtdev/XEN_DOMCTL_assign_device however th=
ere is
> > > > > > a pitfall with that approach.
> > > > > >=20
> > > > > > At the moment, they are only used for device protected by the
> > > > > > IOMMU. If the device is not protected by the IOMMU then it will=
 return
> > > > > > an error.
> > > > > IIRC there was a change, that allowed to assign device without a
> > > > > IOMMU. At
> > > > > least we discussed this internally.
> > > >=20
> > > > I am not aware of any upstream. Do you have a pointer if there is a=
ny
> > > > public discussion?
> > >=20
> > > No, this is the first public discussion on this topic.
> > >=20
> > > >=20
> > > > > >=20
> > > > > > Now, with your approach we may have a device that is not protec=
ted by
> > > > > > the IOMMU but require to a SCMI configuration.
> > > > > You need to protect only DMA-capable devices.
> > > >=20
> > > > Xen doesn't know if the device is DMA-capable or not. So...
> > > >=20
> > >=20
> > > But it knows if there is a iommus=3D<> node present for the device.
> >=20
> > Not really. Not all the platforms have IOMMUs and not all the platforms=
 with
> > IOMMU have DMA-capable device protected by an IOMMU.
> >=20
> > >=20
> > > > >=20
> > > > > > I don't think it would be sensible to just return "succeed" her=
e
> > > > > > because technically you are asking to assign a non-protected
> > > > > > device. But at the same time, it would prevent a user to assign=
 a
> > > > > > non-DMA capable device.
> > > > > >=20
> > > > > > So how do you suggest to approach this?
> > > > > Well, in my head assign_device ideally should do the following:
> > > > > 1. Assign IOMMU if it is configured for the device
> > > >=20
> > > > ... with this approach you are at the risk to let the user passthro=
ugh
> > > > a device that cannot be protected.
> > > >=20
> > > > > 2. Assign SCMI access rights
> > > > > (Not related to this patch series, but...)
> > > > > 3. Assign IRQs
> > > > > 4. Assign IO memory ranges.
> > > > > Points 3. and 4. would allow us to not provide additional irq=3D[=
] and
> > > > > iomem=3D[] entries in a guest config.
> > > >=20
> > > > That could only work if your guest is using the same layout as the
> > > > host.
> > >=20
> > > Agreed. But in my experience, in most cases this is the true. We work=
ed
> > > with Renesas and IMX hardware and in both cases iomems were
> > > mapped 1:1.
> > >=20
> > > > Otherwise, there is a risk it will clash with other parts of the
> > > > memory layout.
> > > >=20
> > >=20
> > > > Today, guests started via the toolstack is only using a virtual
> > > > layout, so you would first need to add support to use the host memo=
ry
> > > > layout.
> > >=20
> > > I can't say for all the possible configurations in the wild, but I'm
> > > assuming that in most cases it will be fine to use 1:1 mapping. For
> > > those more exotic cases it would be possible to implement some
> > > configuration option like iomem_map=3D[mfn:gfn].
> > Well, the Xen memory layout is not something that is stable nor AFAIK b=
ased on
> > any memory layout. In fact, there is no such generic layout on Arm.
> >=20
> > It is quite possible that it will work well with 1:1 MMIO on some platf=
orm
> > (e.g. Renesas, IMX) but you can't expect to work for every Xen release =
or all
> > the platforms.
>=20
> Yeah this is a true problem. Thankfully with Penny's series we'll be
> able to create domUs with the host memory layout (although dom0less
> only but it is a step forward).
>=20
> =20
> > > As Stefano pointed, right now user needs to provide 3 configuration
> > > options to pass a device to a guest: dt_dev, irq, iomem. But in fact,
> > > Xen is already knowing about irq and iomem from device tree.
> >=20
> > I understand and this is not ideal. I would be happy to consider your
> > approach. However, this will have to enabled only when the guest is re-=
using
> > the host layout.
>=20
> It looks like we all agree that today configuring device assignment with
> Xen is too complicated and would like for it to be simpler. This thread
> has some excellent ideas on how to address the issue. Skip to the end if
> you are only interested in this patch series.
>=20
>=20
> # Future Ideas
>=20
> A great suggestion by Julien is to start supporting the dom0less partial
> device tree format in xl/libxl as well so that we can have a single
> "device_tree" option in dom.cfg instead of 4 (device_tree, iomem, irqs,
> dtdev).
>=20
> Even with that implemented, the user has still to provide a partial dtb,
> xen,reg and xen,path. I think this is a great step forward and we should
> do that, if nothing else to make it easier to switch between dom0less
> and normal domU configurations. But the number of options and
> information that the user has to provide is still similar to what we
> have today.
>=20
> After that, I think we need something along the lines of what Volodymyr
> suggested. Let's say that the user only provides "dtdev" and
> "device_tree" in dom.cfg.  We could:
>=20
> - read interrupts from the  "interrupts" property like we do for dom0less
> - read "xen,reg" for the mapping, if "xen,reg" is missing, read "reg"
>   and assume 1:1 (we could try the mapping and print an error on
>   failure, or we could only do 1:1 if the domain is entirely 1:1)
> - optionally read "xen,path" to populate dtdev
> - if an IOMMU configuration is present, then also configure the IOMMU
>   for the device, if not then "xen,force-assign-without-iommu" must be
>   present
> - assign SCMI access rights
>=20
>=20
> Now we only have:
> - device_tree in dom.cfg
> - dtdev in dom.cfg (or xen,path in the partial DTB)
> - xen,force-assign-without-iommu in the partial DTB
>=20
>=20
> It would be good if we could remove "xen,force-assign-without-iommu"
> because at this stage it is the only Xen-specific property remaining in
> the partial DTB. If we could get rid of it, it would make it easier to
> write/generate the partial DTB because it becomes a strict subset of the
> corresponding host node. It would enable us to automatically generate it
> (we are going to do experiments with it at Xilinx in the next few
> months) and it would be easier to explain to users how to write it.
> The partial DTB usually starts as a copy of the corresponding host node
> plus some edits. The fewer edits are required, the better.
>=20
> But it is difficult because of the reasons mentioned by Julien. In Xen
> we cannot know if a device is not behind an IOMMU because is not a DMA
> master (so safe to assign) or because the system simply doesn't have
> enough IOMMU coverage (so not safe to assign). Thankfully the hardware
> has been improving in recent years and there are more and more platforms
> with full IOMMU coverage. I think we should make it easier for users on
> these well-behave platforms.
>=20
> At least, we could move the "xen,force-assign-without-iommu" option from
> the partial DTB to the VM config file dom.cfg. Something like:
>=20
> force-assign-without-iommu=3D"true"
> or
> platform-iommu-safe=3D"true"
>=20
> That way, it is global rather than per-device and doesn't have to be
> added by the user by hand when creating the partial DTB.
>=20
>=20
> # This patch series
>=20
> Now in regards to this specific series and the SCMI options today, I
> think it is OK to have a per-domain sci=3D"scmi_smc", but I think we
> should try to avoid another detailed list of device paths or list of
> IDs in addition to dtdev.
>=20
> dtdev already specifies the device tree nodes to be assigned to the
> guest. Based on that list we can also do SCMI assignment.
>=20
> As Julien pointed out, the issue is: what if a device needs SCMI
> assignment but is not a DMA master (hence there is no IOMMU
> configuration on the host)?
>=20
> Attempting to assign a DMA mastering device without IOMMU protection is
> not just unsafe, it will actively cause memory corruptions in most
> cases. It is an erroneous configuration.
>=20
> Of course we should try to stop people from running erroneous
> configurations, but we should do so without penalizing all users.
>=20
> With that in mind, also considering that dtdev is the list of devices to
> be assigned, I think dtdev should be the list of all devices, even
> non-DMA masters. It makes a lot of sense also because today is really
> difficult to explain to a user that "yes, dtdev is the devices to be
> assigned but no, if the device is a UART you don't have to add it to
> dtdev because it is not a DMA master". It would be a lot easier if the
> list of assigned devices was comprehensive, including both DMA masters
> and not DMA masters.
>=20
> So I think we should either:
>=20
> a) extend dtdev to cover all devices, including non-DMA masters
> b) or add a new "device_assignment" property which is like dtdev but is
>    the list of both DMA masters and non-DMA masters
>=20
> Either way, when non-DMA masters are present in the
> dtdev/device_assignment list we could either:
>     c) require force-assign-without-iommu=3D"true" in dom.cfg
>     d) or print a warning like:
>     "WARNING: device assignment safety for device XXX cannot be
>     verified. Please make sure XXX is not a DMA mastering device."
>=20
>=20
> All these options are good I think. My preference is a) + d), so extend
> dtdev and print a warning if non-DMA masters are in the list. We don't
> necessarily need a new hypercall but that is also an option.
>=20
> I think this discussion was a long time coming and I am glad we are
> having it now. We have a lot of room for improvement! I don't want to
> scope-creep this patch series, but I hope that this last bit could be
> done as part of this series if we find agreement in the community.

For me a) + d) looks good. I will implement it in v2 if everybody ok
with this approach.=


From xen-devel-bounces@lists.xenproject.org Thu Dec 23 19:13:44 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 23 Dec 2021 19:13:44 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251171.432444 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TX1-0006V8-1B; Thu, 23 Dec 2021 19:13:39 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251171.432444; Thu, 23 Dec 2021 19:13:39 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0TX0-0006V1-Ty; Thu, 23 Dec 2021 19:13:38 +0000
Received: by outflank-mailman (input) for mailman id 251171;
 Thu, 23 Dec 2021 19:13:38 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=Pwdt=RI=epam.com=prvs=29912ec7ef=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0TX0-0006Uv-2X
 for xen-devel@lists.xenproject.org; Thu, 23 Dec 2021 19:13:38 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 6d8dac21-6424-11ec-bb0b-79c175774b5d;
 Thu, 23 Dec 2021 20:13:36 +0100 (CET)
Received: from pps.filterd (m0174680.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BNIRnCn022133;
 Thu, 23 Dec 2021 19:13:32 GMT
Received: from eur04-he1-obe.outbound.protection.outlook.com
 (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d4umw8jvm-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 23 Dec 2021 19:13:32 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7277.eurprd03.prod.outlook.com (2603:10a6:102:107::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Thu, 23 Dec
 2021 19:13:29 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021
 19:13:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6d8dac21-6424-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LymKownDeuAc3Z7dVVbP9pTWUmk7E/n5ChC5DzjCPxO3CQVKglW/r+F+j2oKvxZz527eJ/HYcoj2l3D8FqSH5tD4fig1swpcZDukoV8j/etT42LfBvnr0S+WC/HyFIb246M8tEsQvDW9Imb6WWdpZs3uU4BxMahtitrQwJawXLHGHng2MOEl1TaT/Tw360bxHC4XkqM4DGEXUUdUc7YJUfdCxKDXZNaFYAV8d30gf229otP/afMZ/XP65E3lW67UgIw33pb0wkE54o+zhwAf6wK4Fy7+hNNkOd1CkxItwb++UbUFgoT8D1C8QC23+c4BRVQpOg5NOqXPkz9660JSlw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=JbQIJUZvQE+dO43TFV4zyFEWtoMy6T09zAKfTLa0Uik=;
 b=NradpcgszvQ91cO0Zud13kspEFwg69XLIeqEI1IRLdR3pMQqw1ZliETd+Lm9AFLhG02jJSl4voUfij447714PinG10DIbsckTaHtrpmoFSSTS0d12hdSfwoefArHP0gaO98hbZSrdcNxBGQjWfd/CM89VT/dhiSaQlkKNlnuHA5IcIwThlOic8UZfRqR9eDJXJoJ2Sj81fMKfbNsg+pPzuUREJskLThF+z08fYGux74fYix0k1dqwqESDHo2C3Cfc4C5JgaxQXyMI/p7C6qecwREhnRDx6DSO6Im5wzWRrxv1lrj+ggDCrdGBmY0OWLiO7eL88m0avIijOBj58ZK6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=JbQIJUZvQE+dO43TFV4zyFEWtoMy6T09zAKfTLa0Uik=;
 b=QJjwCfsB/Yj8QS5Wa12M41XqKXgBx0Pr8tPrE4fUX/9OeLxNA5bom39VTBw3t98+GFpvl7cVjTI4q2fnaOhdiE7JMC85f9A9myoU9ulAirgzxwNZ4oLe9GUWgjnZf+8otVenXW96CzZKNfFje4Pn1tOZi9C+ADwrtEM5k0QgKPuDJ5eDiKMA9mHG/AbjMWC9Aavn6Y5vn8gxuoqRKL/cV9GfAVs+G4aLWI+BIhcrN6MoQSL8CrQCA9Zv/po4aN62Cvjgh/jiVePaIX/gjlpC3VTvqgpvYPxvVpvBOhqqdzzqs+FH27FrSb4PNTW9LmN8Zjn6+yuxbsqnAzOvONsqLg==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Wei Liu
	<wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
        Juergen Gross
	<jgross@suse.com>
Subject: Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
Thread-Index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owqw8KP2AgAIxjYCAAQwEgIABGisA
Date: Thu, 23 Dec 2021 19:13:29 +0000
Message-ID: <20211223191328.GB101400@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <7aa3e21a3285b3af92ad87a4b039b4bd7696ac88.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112201653500.2060010@ubuntu-linux-20-04-desktop>
 <20211222102417.GA2882292@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221633000.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112221633000.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6fc2313c-5e30-459f-991b-08d9c6484db3
x-ms-traffictypediagnostic: PA4PR03MB7277:EE_
x-microsoft-antispam-prvs: 
 <PA4PR03MB7277609FFB15C3631602FC89E37E9@PA4PR03MB7277.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 /7+2IKh2VoCmtSC974oQOuAjoK+FscT/tgArdHOHxta8oYWaDutWYBOu1x/vDQuyMKz3H1r/osIc3RIqD26Uobf7fPD6ss/SN7QgjjdBfNhrV9MxP9H9W1oVjQzvkWFcdQBgxILaQtEZ4E1wPRN+QQ12Z9taq7loCnwXEAXx3FFl4th+rGJQjN4OBZFF2Ua11CIgSOiGrs1SnHSxJwhkt0f0HvzcCl4I51I+hCv1yoB2LjazCZd2Vxa5crGKZ6U4ISdG0aPEe9kSeXEsixlJKtLUkpvFpR5+/g4CIDFTIhQ23Mi/qazHjdCa/D49/QBoTgduWgnaI/OgFQsaxA+V2HKdyPfBbRku35vXDduzpoNxsVlK0EMw73cwMNDWF8fBTuMTKc4Xg8Osyc6quMHmrx5wTltWNa4F/MIjCOMbBhHBuks+y/ByRdkzSSP8cCKna6QGnytH/MT6iXyiPNERSJQ+xHcM+m9PHkWA9NGA6H4OSfGKe+I2GtGxhejZ2rSenCDCnoUuI2U4jc6HaFEAmVsR4b+gytouaGudm6CL41TzHgtQkKANDmOfArHejN1dKRQ7DAzb0U23wGH3NQ4uFJUpAZaNOsUwaD4rORrV4bnZ/nHhpAW8MRSIMUOOYVYfoGAjDJIGsAgdM6zwIb0IwZLCOpPso0vmxtlauJL2DcTYRDHXknD8fJ/i7athg6rhWXMadZEg4MxzyLqa3ANTOA==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6506007)(83380400001)(1076003)(2906002)(508600001)(26005)(186003)(6916009)(66476007)(76116006)(6486002)(316002)(91956017)(9686003)(38100700002)(66946007)(33656002)(64756008)(66446008)(6512007)(8676002)(5660300002)(4326008)(54906003)(122000001)(33716001)(8936002)(38070700005)(66556008)(71200400001)(86362001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?YCD1Oao2cW3BQZs9sIpvyBNiDp3lvPEWxdmMIv2DB8lwVRjwr0dgBmRL9Jmw?=
 =?us-ascii?Q?ikOUNQPR9tSk92o0ucBeO3YLqfbnYPN0HGqRAf2xEXQdbwtUszRf98bOupzd?=
 =?us-ascii?Q?/g8SlQ/ClgcvseOfKkXt0yy0Lw7hrWdMSZQh7hFVi2ig/freXWWG1yr9qlwS?=
 =?us-ascii?Q?H1hLKIJRz14ox4Xc0/QbYYU3teifjrt5o/WZ6LSiPpzPeA/fYtJaCBksgaiP?=
 =?us-ascii?Q?GOlNNXUDEvi10/FqDK19ur8tFQ/puaFsVrBiz9btla63qQM0puukDfuqwugb?=
 =?us-ascii?Q?M0nickO4IzRwXokFzK7z3IF97DbsgW1v11mCyZfooMLi8Zu601gBtXIw4g5X?=
 =?us-ascii?Q?mOtLSjBLfFJOAHLjtCcHS9T41X7sySdwnnGb0rcIFLU/HuQ3/qmhxPFhMRPN?=
 =?us-ascii?Q?MU4aDtDnUHBV40L4IZzEMr8QS9kWRCmE5ONAfJ9XhFOnWWHVzGIZGXLqBFqQ?=
 =?us-ascii?Q?df7Xn5g0Xq11p6IaaIDJqzcgpmYLkwiphc00p6FOesxdLUNjKYhA8lPGI8rs?=
 =?us-ascii?Q?xv6xDRHPg0G1PAvDhMTNwfzxUIQYe/JOg43A43jbkBl/Md+OLyF5Plp+RrC/?=
 =?us-ascii?Q?7cG3g//3ghf6EOIVB6BuNjXWJ4k1QWjFj0dU568kLXwg8IsVQkUD8SQUq1cr?=
 =?us-ascii?Q?3P6z5iRs/c5Jybea5SfTeG75FckABvlnm+pajE6e+JvOU7FqhHqJytxLCg/7?=
 =?us-ascii?Q?OG6+L3DyHwuGeVefG5sapYgV1BztAvbm55bsEm/oHRWo5VvQwJUK/4tIJJue?=
 =?us-ascii?Q?RCgANcRSzZkEAfv0DTi6CAFKmec5Y1mY8hlbxlzL587rYUZBQs2WEapv6BKM?=
 =?us-ascii?Q?RolbX1lXsMtPrTfbr/zm+HNvw6y69kOsZFNndQbu4SVJZnPcErHjsCtonfdF?=
 =?us-ascii?Q?Q4tb3VhYm5GVsvEqG+vAcmUf+LF83F0qDKORzuar9ejVpBNCKUhZV9R/5M00?=
 =?us-ascii?Q?DqnQHkOX58JZ4xxb92/6KtKMVWE+AP0+QzUIieFL4IRxQzg6tD/nFzia3Q2+?=
 =?us-ascii?Q?q1F7yO2vh5x/pvyLUpucaCUrYin9fKxZ+9Gy1pZYXmo+1waPR2khuXWZuofb?=
 =?us-ascii?Q?PZg36kTdYybn6/LhdwJk/uYFTmt3deCeGRB5Uq6CfrO+F/K1Sx6Q0G/OGW56?=
 =?us-ascii?Q?0LJqJDBOxNMSEEqygWyUNVJujD3VdzHiT7E4A1PorkUjkwea8DsX6oNGaH0+?=
 =?us-ascii?Q?thfnFbqoOjO5beUIKWxSmez3DzCq7FzVP2SqcD72HcDeCz1JoPsMBwSaWQ6u?=
 =?us-ascii?Q?YHXZAk4HJZ0BetEpzfk3IQ/7wMfUJvFFjiqLwZq652MEcPWOPXZBiN+AOCPR?=
 =?us-ascii?Q?cyvwZw5dJURJ95U47Rpn2YuG1QawsXS94L8dyyOSajOvlR/RXPDpKgmBVMhb?=
 =?us-ascii?Q?jFnw7ENl3+mWLjT5SitM5pf0KVXmCBfMS8anntiaX9/E6CkZkA47jVo/SfiT?=
 =?us-ascii?Q?hqYYNLnxbQ/rPRUhxZUKKCVjxDaBHGaU3zV7k/v/GJF5vx9MbmM87nd1+jWZ?=
 =?us-ascii?Q?0QLVywYnX+8DyKGUXV5Kic/CUewF7sjdmVrPIlrmCp4ZtbY1EM0kpAkUxD/9?=
 =?us-ascii?Q?9Cs4vlK1/WAju+2UCrpDCXfnOuVxW1+1lObAPh2ZiEFKWhpTplRG+siJCjfJ?=
 =?us-ascii?Q?Lhs6tUD0d0pAqSOG7lx9oxcUM5gkYRme9BvvOTEdcH+2dCKscA72b2+S3RDI?=
 =?us-ascii?Q?H1yYc9PZGcVEt2ky5hqQmIVmgSs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17CB88EB9F664A43B9D4A478863E3315@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc2313c-5e30-459f-991b-08d9c6484db3
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 19:13:29.2571
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: usCWaNlK0Si6aGPSB8ym7hgWI4+k8YY0LQ3bYfcGGj9RV3C/BVrFAwW/phy9J8ZJVWNgzixx1hrS+zT1Qyqwt+yOYGdTqsXf93d4pvw+2VQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7277
X-Proofpoint-ORIG-GUID: 9VfEO0I2_vnLz40hKA3XMHplGhQkMi7l
X-Proofpoint-GUID: 9VfEO0I2_vnLz40hKA3XMHplGhQkMi7l
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-23_04,2021-12-22_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 bulkscore=0 priorityscore=1501
 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 lowpriorityscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112230100

Hi Stefano,

On Wed, Dec 22, 2021 at 06:23:33PM -0800, Stefano Stabellini wrote:
> On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> > On Mon, Dec 20, 2021 at 04:54:25PM -0800, Stefano Stabellini wrote:
> > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > This enumeration sets SCI type for the domain. Currently there is
> > > > two possible options: either 'none' or 'scmi_smc'.
> > > >=20
> > > > 'none' is the default value and it disables SCI support at all.
> > > >=20
> > > > 'scmi_smc' enables access to the Firmware from the domains using SC=
MI
> > > > protocol and SMC as transport.
> > > >=20
> > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > ---
> > > >  docs/man/xl.cfg.5.pod.in         | 22 ++++++++++++++++++++++
> > > >  tools/include/libxl.h            |  5 +++++
> > > >  tools/libs/light/libxl_types.idl |  6 ++++++
> > > >  tools/xl/xl_parse.c              |  9 +++++++++
> > > >  4 files changed, 42 insertions(+)
> > > >=20
> > > > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> > > > index b98d161398..92d0593875 100644
> > > > --- a/docs/man/xl.cfg.5.pod.in
> > > > +++ b/docs/man/xl.cfg.5.pod.in
> > > > @@ -1614,6 +1614,28 @@ This feature is a B<technology preview>.
> > > > =20
> > > >  =3Dback
> > > > =20
> > > > +=3Ditem B<sci=3D"STRING">
> > > > +
> > > > +B<Arm only> Set SCI type for the guest. SCI is System Control Prot=
ocol -
> > > > +allows domain to manage various functions that are provided by HW =
platform.
> > > > +
> > > > +=3Dover 4
> > > > +
> > > > +=3Ditem B<none>
> > > > +
> > > > +Don't allow guest to use SCI if present on the platform. This is t=
he default
> > > > +value.
> > > > +
> > > > +=3Ditem B<scmi_smc>
> > > > +
> > > > +Enables SCMI-SMC support for the guest. SCMI is System Control Man=
agement
> > > > +Inferface - allows domain to manage various functions that are pro=
vided by HW
> > > > +platform, such as clocks, resets and power-domains. Xen will media=
te access to
> > > > +clocks, power-domains and resets between Domains and ATF. Disabled=
 by default.
> > > > +SMC is used as transport.
> > >=20
> > > Would it make sense to actually enable SCMI-SMC support for the guest=
 by
> > > default if the guest has any devices directly assigned?
> >=20
> > Hi Stefano,
> >=20
> > Previously we discussed with Oleksandr about introducing new dom.cfg
> > parameter, such as scidev[] lists all sci related nodes, which will hel=
p to
> > avoid extra domctl calls.
>=20
> The concerning part is (too much) information the user needs to provide
> in device tree or dom.cfg. We can be flexible with the number of extra
> domctl calls, but of course it would be good to avoid them too.
>=20
>=20
> > But there is still a question how mediator types should be set for
> > different domains? I know currently system supports only one mediator
> > type, but different implementation should be also possible.
>=20
> I think it is fine to have an option sci=3D"scmi_smc" in dom.cfg, that is
> not a problem. The issue is a detailed list of SCMI IDs or a second list
> of device tree paths, because those are far harder to write correctly.
>=20
>=20
> > For example, if we have to start dom0 and domd using scmi_mailbox
> > mediator and domU using scmi_smc, because our system supports only 2
> > mailboxes.
>=20
> Yeah that's fine, it could be done with the sci option you are
> suggesting.

Thank you for suggestions. I will use this approach in v2.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 00:09:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 00:09:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251182.432455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Y8d-0006U5-Sz; Fri, 24 Dec 2021 00:08:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251182.432455; Fri, 24 Dec 2021 00:08:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Y8d-0006Ty-PI; Fri, 24 Dec 2021 00:08:47 +0000
Received: by outflank-mailman (input) for mailman id 251182;
 Fri, 24 Dec 2021 00:08:45 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+lMa=RJ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0Y8b-0006Tc-IN
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 00:08:45 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id a646161f-644d-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 01:08:43 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id 61870CE20D6;
 Fri, 24 Dec 2021 00:08:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 288ADC36AE9;
 Fri, 24 Dec 2021 00:08:35 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a646161f-644d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640304515;
	bh=tqXkHtPuzTg0lveZkEER0yZRBAcxzhJxp7nd6Zz8io4=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=c5On+GfXvNx7TTwufTDCOpb9LqyF/qAFjLIbZdu1qpo9ShNJknUjx2sp8cB9FyxHk
	 G9QVmWEJ2tD/sy17Vi3RChB+9hRemSUYIu9FmiiMiQwAh3NKvu3Gx6xvlVMVgZR4bb
	 s27bKQILGL5ZgjUr7Sq2b1y7W9ZRn6aTIAA6NJqlrxqDeRUWssjh/u1AfV0+hoDhAM
	 eVxCBa8zx0FME7PWyOhYJ5Fk/87z1I9WV9SjbNaYJlI/3j3ZGIJyOtBvtSDGXJdkw8
	 OQxOEhKVkvF0ftGpzojkn5QFHVPrFe/9HO5Hxsm+It1yq/sKGs0zHMIYnYmIuzw138
	 nKPEp7CV7wJkQ==
Date: Thu, 23 Dec 2021 16:08:34 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Dongjiu Geng <gengdongjiu1@gmail.com>, sstabellini@kernel.org, 
    Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, 
    xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: fix the build error for GIC
In-Reply-To: <6aabf7fe-81ea-0fbc-a640-75f9ac59806b@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112231606420.2060010@ubuntu-linux-20-04-desktop>
References: <20211222083825.2918045-1-gengdongjiu1@gmail.com> <6aabf7fe-81ea-0fbc-a640-75f9ac59806b@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Julien Grall wrote:
> Hello,
> 
> On 22/12/2021 09:38, Dongjiu Geng wrote:
> > when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
> > so fix it and make it can select GICV2.
> 
> Last time I checked QEMU, it was only able to support GICv3 virtualization.
> Has it changed since?
> 
> > 
> > Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > ---
> > $ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
> > make -C xen install
> > make[1]: Entering directory
> > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > make -f
> > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig
> > ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
> > make[2]: Entering directory
> > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o
> > tools/kconfig/conf.c
> > gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o
> > tools/kconfig/confdata.c
> > gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o
> > tools/kconfig/expr.c
> > flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> > bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t
> > -l tools/kconfig/parser.y
> > gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o
> > tools/kconfig/preprocess.o tools/kconfig/preprocess.c
> > gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o
> > tools/kconfig/symbol.c
> > gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I
> > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o
> > tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
> > gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I
> > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o
> > tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
> > gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o
> > tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o
> > tools/kconfig/preprocess.o tools/kconfig/symbol.o
> > tools/kconfig/conf  --syncconfig Kconfig
> > 
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
> >    Selected by [y]:
> >    - QEMU [=y] && <choice> && ARM_64 [=y]
> > 
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
> >    Selected by [y]:
> >    - QEMU [=y] && <choice> && ARM_64 [=y]
> > 
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
> >    Selected by [y]:
> >    - QEMU [=y] && <choice> && ARM_64 [=y]
> > make[2]: Leaving directory
> > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > make -f Rules.mk _install
> > make[2]: Entering directory
> > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > ---
> >   xen/arch/arm/platforms/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> > index c93a6b2756..6d3ee99456 100644
> > --- a/xen/arch/arm/platforms/Kconfig
> > +++ b/xen/arch/arm/platforms/Kconfig
> > @@ -15,7 +15,6 @@ config ALL_PLAT
> >   config QEMU
> >   	bool "QEMU aarch virt machine support"
> >   	depends on ARM_64
> > -	select GICV3
> 
> Assuming you can use Xen with GICv2 on QEMU, then this change is OK. But we
> are at risk to expose it again via another platform.
> 
> So I think it would be better to also to add a dependency !GICV3 for NEW_VGIC.

I agree. I gave it a try and turns out it is not possible to simply add:

depends on !GICV3

under NEW_VGIC because there is already a !NEW_VGIC under GICV3.
Apparently it creates a circular dependency. Instead, I did the
following and it looks like it is behaving the way we want.


diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..373c698018 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -35,7 +35,7 @@ config ACPI
 
 config GICV3
 	bool "GICv3 driver"
-	depends on ARM_64 && !NEW_VGIC
+	depends on ARM_64
 	default y
 	---help---
 
@@ -44,13 +44,14 @@ config GICV3
 
 config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
-        depends on GICV3 && !NEW_VGIC
+        depends on GICV3
 
 config HVM
         def_bool y
 
 config NEW_VGIC
 	bool "Use new VGIC implementation"
+	depends on !GICV3
 	---help---
 
 	This is an alternative implementation of the ARM GIC interrupt


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 00:17:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 00:17:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251185.432465 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0YGU-00089a-N4; Fri, 24 Dec 2021 00:16:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251185.432465; Fri, 24 Dec 2021 00:16:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0YGU-00089S-JM; Fri, 24 Dec 2021 00:16:54 +0000
Received: by outflank-mailman (input) for mailman id 251185;
 Fri, 24 Dec 2021 00:16:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+lMa=RJ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0YGT-00087x-Bu
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 00:16:53 +0000
Received: from sin.source.kernel.org (sin.source.kernel.org
 [2604:1380:40e1:4800::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ca0dff84-644e-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 01:16:51 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by sin.source.kernel.org (Postfix) with ESMTPS id B22E5CE0F83;
 Fri, 24 Dec 2021 00:16:47 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B59D1C36AE9;
 Fri, 24 Dec 2021 00:16:45 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ca0dff84-644e-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640305006;
	bh=qL21nLHWTr/azaP96wBOlsT6QnpPfCyrfQYajqWbfwU=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=Ots6RtRCu4pJa4+yyFGQupZ6ATfOqhpnijMtSokA11ZNoDxlQRDYZfHnskJzxRihD
	 NyyhEm+VG1xOQtGBo6c/VYv+t4d71to5CcW0RlLmKQfcC/Eey1+dJjUWrPULhM7yV1
	 kBCdAx4EuRmTbitXEKKfglxe7labQdmUAdvytQmFskwPiB0lv8x7AhWAorITjo+we+
	 rZam+aB9B/HLrk6b7G3mjkF2iyYjMXu/hy0uXwuOYwtUvSbcOFOfdGE3S2bnWlCA07
	 ECExXCrQ3SctnoZHh9wnM6XNjd8rEm9tKod5Yjuq8NfMS9R9i632esatOHkTngho56
	 AjV46oyKTy4bw==
Date: Thu, 23 Dec 2021 16:16:45 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
cc: Stefano Stabellini <sstabellini@kernel.org>, 
    "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
    Julien Grall <julien@xen.org>, 
    Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
    Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
In-Reply-To: <20211223190637.GA99855@EPUAKYIW015D>
Message-ID: <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com> <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com> <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop> <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop> <20211221200305.GA2460476@EPUAKYIW015D> <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop> <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop> <20211223190637.GA99855@EPUAKYIW015D>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 23 Dec 2021, Oleksii Moisieiev wrote:
> On Wed, Dec 22, 2021 at 06:23:24PM -0800, Stefano Stabellini wrote:
> > On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> > > On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
> > > > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> > > > > Hi Stefano,
> > > > > 
> > > > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wrote:
> > > > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > Hi Stefano,
> > > > > > > 
> > > > > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellini wrote:
> > > > > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > > > This is the implementation of SCI interface, called SCMI-SMC driver,
> > > > > > > > > which works as the mediator between XEN Domains and Firmware (SCP, ATF etc).
> > > > > > > > > This allows devices from the Domains to work with clocks, resets and
> > > > > > > > > power-domains without access to CPG.
> > > > > > > > > 
> > > > > > > > > The following features are implemented:
> > > > > > > > > - request SCMI channels from ATF and pass channels to Domains;
> > > > > > > > > - set device permissions for Domains based on the Domain partial
> > > > > > > > > device-tree. Devices with permissions are able to work with clocks,
> > > > > > > > > resets and power-domains via SCMI;
> > > > > > > > > - redirect scmi messages from Domains to ATF.
> > > > > > > > > 
> > > > > > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > > > ---
> > > > > > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > > > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > > > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > > > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++++++++++++++++++
> > > > > > > > >  xen/include/public/arch-arm.h |   1 +
> > > > > > > > >  5 files changed, 809 insertions(+)
> > > > > > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > > > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > 
> > > > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > > > > > > > index 186e1db389..02d96c6cfc 100644
> > > > > > > > > --- a/xen/arch/arm/Kconfig
> > > > > > > > > +++ b/xen/arch/arm/Kconfig
> > > > > > > > > @@ -114,6 +114,8 @@ config SCI
> > > > > > > > >  	  support. It allows guests to control system resourcess via one of
> > > > > > > > >  	  SCI mediators implemented in XEN.
> > > > > > > > >  
> > > > > > > > > +source "arch/arm/sci/Kconfig"
> > > > > > > > > +
> > > > > > > > >  endmenu
> > > > > > > > >  
> > > > > > > > >  menu "ARM errata workaround via the alternative framework"
> > > > > > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sci/Kconfig
> > > > > > > > > new file mode 100644
> > > > > > > > > index 0000000000..9563067ddc
> > > > > > > > > --- /dev/null
> > > > > > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > > > > > @@ -0,0 +1,10 @@
> > > > > > > > > +config SCMI_SMC
> > > > > > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > > > > > +	default n
> > > > > > > > > +	depends on SCI
> > > > > > > > > +	---help---
> > > > > > > > > +
> > > > > > > > > +	Enables mediator in XEN to pass SCMI requests from Domains to ATF.
> > > > > > > > > +	This feature allows drivers from Domains to work with System
> > > > > > > > > +	Controllers (such as power,resets,clock etc.). SCP is used as transport
> > > > > > > > > +	for communication.
> > > > > > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/sci/Makefile
> > > > > > > > > index 837dc7492b..67f2611872 100644
> > > > > > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > > > > > @@ -1 +1,2 @@
> > > > > > > > >  obj-y += sci.o
> > > > > > > > > +obj-$(CONFIG_SCMI_SMC) += scmi_smc.o
> > > > > > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > new file mode 100644
> > > > > > > > > index 0000000000..2eb01ea82d
> > > > > > > > > --- /dev/null
> > > > > > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > @@ -0,0 +1,795 @@
> > > > > > > > > +/*
> > > > > > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > + *
> > > > > > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > > > > > + *
> > > > > > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > > > > > + *
> > > > > > > > > + * This program is free software; you can redistribute it and/or modify
> > > > > > > > > + * it under the terms of the GNU General Public License as published by
> > > > > > > > > + * the Free Software Foundation; either version 2 of the License, or
> > > > > > > > > + * (at your option) any later version.
> > > > > > > > > + *
> > > > > > > > > + * This program is distributed in the hope that it will be useful,
> > > > > > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > > > > > + * GNU General Public License for more details.
> > > > > > > > > + */
> > > > > > > > > +
> > > > > > > > > +#include <asm/sci/sci.h>
> > > > > > > > > +#include <asm/smccc.h>
> > > > > > > > > +#include <asm/io.h>
> > > > > > > > > +#include <xen/bitops.h>
> > > > > > > > > +#include <xen/config.h>
> > > > > > > > > +#include <xen/sched.h>
> > > > > > > > > +#include <xen/device_tree.h>
> > > > > > > > > +#include <xen/iocap.h>
> > > > > > > > > +#include <xen/init.h>
> > > > > > > > > +#include <xen/err.h>
> > > > > > > > > +#include <xen/lib.h>
> > > > > > > > > +#include <xen/list.h>
> > > > > > > > > +#include <xen/mm.h>
> > > > > > > > > +#include <xen/string.h>
> > > > > > > > > +#include <xen/time.h>
> > > > > > > > > +#include <xen/vmap.h>
> > > > > > > > > +
> > > > > > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > > > > > +
> > > > > > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (DEN0056C) */
> > > > > > > > > +#define SCMI_SUCCESS              0
> > > > > > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > > > > > +#define SCMI_DENIED             (-3)
> > > > > > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > > > > > +#define SCMI_BUSY               (-6)
> > > > > > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > > > > > +
> > > > > > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scmi-smc")
> > > > > > > > > +
> > > > > > > > > +#define SCMI_SMC_ID                        "arm,smc-id"
> > > > > > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi_mem"
> > > > > > > > 
> > > > > > > > I could find the following SCMI binding in Linux, which describes
> > > > > > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > > > > > 
> > > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > > > 
> > > > > > > > However, linux,scmi_mem is not described. Aren't you supposed to read
> > > > > > > > the "shmem" property instead? And the compatible string used for this
> > > > > > > > seems to be "arm,scmi-shmem".
> > > > > > > > 
> > > > > > > 
> > > > > > > We use linux,scmi_mem node to reserve memory, needed for all
> > > > > > > channels:
> > > > > > > 
> > > > > > > reserved-memory {
> > > > > > >     /* reserved region for scmi channels*/
> > > > > > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > > > > > >         no-map;
> > > > > > >         reg = <0x0 0x53FF0000 0x0 0x10000>;
> > > > > > >     };
> > > > > > > };
> > > > > > > 
> > > > > > > arm,scmi-shmem node used in shmem property defines only 1 page needed to
> > > > > > > the current scmi channel:
> > > > > > > 
> > > > > > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > > > > > >     compatible = "arm,scmi-shmem";
> > > > > > >     reg = <0x0 0x53FF0000 0x0 0x1000>;
> > > > > > > };
> > > > > > > 
> > > > > > > For each Domain reg points to unigue page from linux,scmi_mem region,
> > > > > > > assigned to this agent.
> > > > > > 
> > > > > > If we were to use "linux,scmi_mem" we would have to introduce it as a
> > > > > > compatible string, not as a node name, and it would need to be described
> > > > > > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > > > > > 
> > > > > > But from your description I don't think it is necessary. We can just use
> > > > > > "arm,scmi-shmem" to describe all the required regions:
> > > > > > 
> > > > > > reserved-memory {
> > > > > >     scp-shmem@0x53FF0000 {
> > > > > >         compatible = "arm,scmi-shmem";
> > > > > >         reg = <0x0 0x53FF0000 0x0 0x1000>;
> > > > > >     };
> > > > > >     scp-shmem@0x53FF1000 {
> > > > > >         compatible = "arm,scmi-shmem";
> > > > > >         reg = <0x0 0x53FF1000 0x0 0x1000>;
> > > > > >     };
> > > > > >     scp-shmem@0x53FF2000 {
> > > > > >         compatible = "arm,scmi-shmem";
> > > > > >         reg = <0x0 0x53FF2000 0x0 0x1000>;
> > > > > >     };
> > > > > >     ...
> > > > > > 
> > > > > > In other words, if all the individual channel pages are described as
> > > > > > "arm,scmi-shmem", why do we also need a single larger region as
> > > > > > "linux,scmi_mem"?
> > > > > > 
> > > > > 
> > > > > That was my first implementation. But I've met a problem with
> > > > > scmi driver in kernel. I don't remember the exact place, but I remember
> > > > > there were some if, checking if memory weren't reserved.
> > > > > That's why I ended up splitting nodes reserved memory region and actual
> > > > > shmem page.
> > > > > For linux,scmi_mem node I took format from /reserved-memory/linux,lossy_decompress@54000000,
> > > > > which has no compatible string and provides no-map property.
> > > > > linux,scmi_shmem node is needed to prevent xen from allocating this
> > > > > space for the domain.
> > > > > 
> > > > > Very interesting question about should I introduce linux,scmi_mem node
> > > > > and scmi_devid property to the
> > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> > > > > Those node and property are needed only for Xen and useless for
> > > > > non-virtualized systems. I can add this node and property description to
> > > > > arm,scmi.yaml, but leave a note that this is Xen specific params.
> > > > > What do you think about it?
> > > > 
> > > > Reply below
> > > > 
> > > > [...]
> > > >  
> > > > 
> > > > > > In general we can't use properties that are not part of the device tree
> > > > > > spec, either https://urldefense.com/v3/__https://www.devicetree.org/specifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > > > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7BnhXloYUaj$ [git[.]kernel[.]org]
> > > > > > 
> > > > > > "linux,scmi_mem" is currently absent. Are you aware of any upstreaming
> > > > > > activities to get "linux,scmi_mem" upstream under
> > > > > > Documentation/devicetree/bindings in Linux?
> > > > > > 
> > > > > > If "linux,scmi_mem" is going upstream in Linux, then we could use it.
> > > > > > Otherwise, first "linux,scmi_mem" needs to be added somewhere under
> > > > > > Documentation/devicetree/bindings (probably
> > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), then we can
> > > > > > work on the Xen code that makes use of it.
> > > > > > 
> > > > > > Does it make sense?
> > > > > > 
> > > > > 
> > > > > Yes I agree. I think linux,scmi_mem and scmi_devid should be upstreamed.
> > > > > I will add those properties to arm,scmi.yaml, mark them as related to XEN and send patch.
> > > > 
> > > > I didn't realize that linux,scmi_mem and scmi_devid are supposed to be
> > > > Xen specific. In general, it would be best not to introduce Xen specific
> > > > properties into generic bindings. It is a problem both from a
> > > > specification perspective (because it has hard to handle Xen specific
> > > > cases in fully generic bindings, especially as those bindings are
> > > > maintained as part of the Linux kernel) and from a user perspective
> > > > (because now the user has to deal with a Xen-specific dtb, or has to
> > > > modify the host dtb to add Xen-specific information by hand.)
> > > > 
> > > > 
> > > > Let me start from scmi_devid.  Why would scmi_devid be Xen-specific? It
> > > > looks like a generic property that should be needed for the Linux SCMI
> > > > driver too. Why the Linux driver doesn't need it?
> > > > 
> > > 
> > > scmi_devid used during domain build. It passed as input parameter for SCMI_BASE_SET_DEVICE_PERMISSIONS message.
> > > On non-virtualized systems - there is no need of this call, because OS
> > > is the only one entity, running on the system.
> > 
> > OK. Even if it is only required for virtualized systems, I think that
> > scmi_devid is important enough that should be part of the upstream
> > binding. I think it is worth starting an email thread on the LKML with
> > Rob Herring and the SCMI maintainers to discuss the addition of
> > scmi_devid to the binding.
> > 
> 
> Ok I will start the thread about scmi_devid.
> > 
> > > I've chatted with Volodymyr_Babchuk and he gave a great idea to add a
> > > list of device_ids to dom.cfg, such as:
> > > sci_devs = [ 0, 1, 15, 35 ];
> > > 
> > > Using this approach, we can remove scmi_devid from the device tree and
> > > just pass a list of scmi_devids to XEN using additional hypercall.
> > > We can probably make hypercall taking devid list as input parameter.
> > > This will take only 1 hypercall to setup sci permissions.
> > 
> > But how would a user know which are the right SCMI IDs to add to the
> > sci_devs list? Would the user have to go and read the reference manual
> > of the platform to find the SCMI IDs and then write sci_devs by hand?
> > If that is the case, then I think that it would be better to add
> > scmi_devid to device tree.
> > 
> > In general, I think this configuration should happen automatically
> > without user intervention. The user should just specify "enable SCMI"
> > and it should work.
> > 
> 
> Ok. This sounds reasonable.
> 
> > 
> > > > In regards to linux,scmi_mem, I think it would be best to do without it
> > > > and fix the Linux SCMI driver if we need to do so. Xen should be able to
> > > > parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) should
> > > > be able to parse the "arm,scmi-shmem" nodes generated by Xen. Either
> > > > way, I don't think we should need linux,scmi_mem.
> > > 
> > > This requires further investigation. I will try to make implementation
> > > without linux,scmi_mem, using only arm,scmi-shmem nodes and share
> > > reuslts with you.
> > 
> > OK, thanks.
> 
> One more question: As you probably seen - Jan had a complains about SCI
> term. He said SCI is ambiguous with ACPI's System
> Control Interrupt.

I see his point. As a term I see "SCMI" often and sometimes "SCPI" but
"SCI" is the first time I saw it with this patch series.


> I think of using SC (as System Control) instead. What do you think
> about it? 

Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" alone
doesn't give me enough context to guess what it is.

Or we could broaden the scope and call it "firmware_interface"?


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 00:46:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 00:46:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251188.432476 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0YiO-0003a0-QA; Fri, 24 Dec 2021 00:45:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251188.432476; Fri, 24 Dec 2021 00:45:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0YiO-0003Zt-N7; Fri, 24 Dec 2021 00:45:44 +0000
Received: by outflank-mailman (input) for mailman id 251188;
 Fri, 24 Dec 2021 00:45:43 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+lMa=RJ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0YiN-0003Zn-Pk
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 00:45:43 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id d10be756-6452-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 01:45:40 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 52E5B61FA7;
 Fri, 24 Dec 2021 00:45:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D409C36AE9;
 Fri, 24 Dec 2021 00:45:37 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: d10be756-6452-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640306738;
	bh=4HefQp9Azj2EUV+cvY+xo0e+RXN2FORcGKY0eB6eSZ0=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=EXEj/4278N0p+0ETw17k5O2ggebcufoBqG4StJgOWGDk+hr33MQ2dBMeVwNzf286K
	 pZ8a9/ZebNLP/xWwkTw1Ws6nRstzolQ1z5KrcZiUZO5XMopxI+9CbSRaPxlt8FWkIt
	 ecfalkzZqx9cvn9mSM8gQukg/4CHc4ZWkqlFs9YT3Dg2mp14eri72iEoV7Pik/7lr6
	 MG9VuCCsilyo1i1MPwDK/vprkZWB1qybZPJ5NNgj2FbeflM+sy2euMPK6U32DPTGDO
	 RHMIRTCtZic/FVyQV7kTmKNgKf/qELyPsCgDaUZX0SV0WxaiNFpILUwT9eP9KRJiJO
	 zTXJa1Mhanntw==
Date: Thu, 23 Dec 2021 16:45:38 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Julien Grall <julien@xen.org>
cc: Vikram Garhwal <fnu.vikram@xilinx.com>, xen-devel@lists.xenproject.org, 
    sstabellini@kernel.org, bertrand.marquis@arm.com, 
    volodymyr_babchuk@epam.com, Andrew Cooper <andrew.cooper3@citrix.com>, 
    George Dunlap <george.dunlap@citrix.com>, Ian Jackson <iwj@xenproject.org>, 
    Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>
Subject: Re: [XEN][RFC PATCH v2 08/12] xen/arm: Implement device tree node
 removal functionalities
In-Reply-To: <229a8fb4-816d-bfc3-31d3-5c375c5cd14b@xen.org>
Message-ID: <alpine.DEB.2.22.394.2112231627060.2060010@ubuntu-linux-20-04-desktop>
References: <1636441347-133850-1-git-send-email-fnu.vikram@xilinx.com> <1636441347-133850-9-git-send-email-fnu.vikram@xilinx.com> <229a8fb4-816d-bfc3-31d3-5c375c5cd14b@xen.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Julien Grall wrote:
> Hi,
> 
> On 09/11/2021 08:02, Vikram Garhwal wrote:
> > Introduce sysctl XEN_SYSCTL_overlay to remove device-tree nodes added using
> 
> I agree with Jan about the name being too generic. I will comment on this a
> bit further down.
> 
> > device tree overlay.
> > 
> > xl overlay remove file.dtbo:
> >      Removes all the nodes in a given dtbo.
> >      First, removes IRQ permissions and MMIO accesses. Next, it finds the
> > nodes
> >      in dt_host and delete the device node entries from dt_host.
> > 
> >      The nodes get removed only if it is not used by any of dom0 or domus.
> > If
> >      even one of the node in dtbo is not available for removal i.e. either
> > not
> >      there in dt_host or currently used by any domain, in that case we don't
> >      remove any node in the given dtbo.
> > 
> > Also, added overlay_track struct to keep the track of added node through
> > device
> > tree overlay. overlay_track has dt_host_new which is unflattened form of
> > updated
> > fdt and name of overlay node. When a node is removed, we also free the
> > memory
> > used by overlay_track for the particular overlay node.
> > 
> > Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> > ---
> >   xen/common/device_tree.c      |  53 ++++++
> >   xen/common/sysctl.c           | 372
> > ++++++++++++++++++++++++++++++++++++++++++
> >   xen/include/public/sysctl.h   |  23 +++
> >   xen/include/xen/device_tree.h |   4 +
> >   4 files changed, 452 insertions(+)
> > 
> > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> > index 26d2e28..19320e1 100644
> > --- a/xen/common/device_tree.c
> > +++ b/xen/common/device_tree.c
> > @@ -385,6 +385,59 @@ void dt_print_node_names(struct dt_device_node *dt)
> >       return;
> >   }
> >   +#if defined (CONFIG_OVERLAY_DTB)
> > +int overlay_remove_node(struct dt_device_node *device_node)
> 
> This want to be prefixed with dt_* so it is clear which components it is
> touching. But I think all the DT overlay code (including sysctl) should be
> moved in a new file (maybe dt_overlay.c) to spreading the overlay code and
> growing
> the size of sysctl.c.
> 
> > +{
> > +    struct dt_device_node *np;
> > +    struct dt_device_node *parent_node;
> > +    struct dt_device_node *current_node;
> > +
> > +    parent_node = device_node->parent;
> > +
> > +    current_node = parent_node;
> > +
> > +    if ( parent_node == NULL )
> > +    {
> > +        dt_dprintk("%s's parent node not found\n", device_node->name);
> > +        return -EFAULT;
> > +    }
> > +
> > +    np = parent_node->child;
> > +
> > +    if ( np == NULL )
> > +    {
> > +        dt_dprintk("parent node %s's not found\n", parent_node->name);
> > +        return -EFAULT;
> > +    }
> > +
> > +    /* If node to be removed is only child node or first child. */
> > +    if ( np->name == device_node->name )
> 
> Why are you checking the equality between the fields name rather than the node
> itself?
> 
> If it is intended, then I think this wants to be explained because often
> people wants to check the names are equal (e.g str*cmp()) rather than the
> pointer where the names are stored.
> 
> > +    {
> > +        current_node->allnext = np->next;
> > +        return 0;
> > +    }
> > +
> > +    for ( np = parent_node->child; np->sibling != NULL; np = np->sibling )
> > +    {
> > +        current_node = np;
> > +        if ( np->sibling->name == device_node->name )
> 
> Same question.
> 
> > +        {
> > +            /* Found the node. Now we remove it. */
> > +            current_node->allnext = np->allnext->allnext;
> > +
> > +            if ( np->sibling->sibling )
> > +                current_node->sibling = np->sibling->sibling;
> > +            else
> > +                current_node->sibling = NULL;
> > +
> > +            break;
> > +        }
> > +    }
> > +
> > +    return 0;
> > +}
> > +#endif
> > +
> >   int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen,
> >                             struct dt_device_node **node)
> >   {
> > diff --git a/xen/common/sysctl.c b/xen/common/sysctl.c
> > index f2dab72..fca47f5 100644
> > --- a/xen/common/sysctl.c
> > +++ b/xen/common/sysctl.c
> > @@ -28,6 +28,311 @@
> >   #include <xen/livepatch.h>
> >   #include <xen/coverage.h>
> >   +#if defined (CONFIG_OVERLAY_DTB)
> 
> This can be shortend to #ifdef CONFIG_<...>.
> 
> > +#include <xen/list.h>
> > +#include <xen/libfdt/libfdt.h>
> > +#include <xen/xmalloc.h>
> > +#include <xen/device_tree.h>
> > +#include <asm/domain_build.h>
> > +#endif
> > +
> > +#if defined (CONFIG_OVERLAY_DTB)
> 
> Same here.
> 
> > +static LIST_HEAD(overlay_tracker);
> > +static DEFINE_SPINLOCK(overlay_lock);
> > +
> > +/*
> > + * overlay_node_track describes information about added nodes through dtbo.
> > + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated
> > fdt'.
> > + * @node_fullname: Store the name of nodes.
> > + * @entry: List pointer.
> > + */
> > +struct overlay_track {
> > +    struct list_head entry;
> > +    struct dt_device_node *dt_host_new;
> > +    char **node_fullname;
> > +    uint8_t num_nodes;
> 
> Any reason to restrict to 256 nodes?
> 
> > +};
> > +
> > +/* Basic sanity check for the dtbo tool stack provided to Xen. */
> > +static int check_overlay_fdt(void *overlay_fdt, uint32_t overlay_fdt_size)
> This function doesn't modify overlay_fdt. So I think it should be const if
> fdt_total_size() and fdt_check_header() allows it.
> 
> > +{
> > +    if ( (fdt_totalsize(overlay_fdt) != overlay_fdt_size) ||
> > +          fdt_check_header(overlay_fdt) )
> > +    {
> > +        printk(XENLOG_ERR "The overlay FDT is not a valid Flat Device
> > Tree\n");
> > +        return -EINVAL;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +static int overlay_node_count(void *fdto)
> > +{
> > +    int num_overlay_nodes = 0;
> 
> The name suggests this should be an unsiged int.
> 
> > +    int fragment;
> > +
> > +    fdt_for_each_subnode(fragment, fdto, 0)
> > +    {
> > +
> > +        int subnode;
> > +        int overlay;
> > +
> > +        overlay = fdt_subnode_offset(fdto, fragment, "__overlay__");
> 
> This may return < 0 if __overlay__ is not found. From my understanding,
> fdt_for_each_subnode() would end up to start from 0.
> 
> So I think you want to add a check here.
> 
> > +
> > +        fdt_for_each_subnode(subnode, fdto, overlay)
> > +        {
> > +            num_overlay_nodes++;
> > +        }
> > +    }
> > +
> > +    return num_overlay_nodes;
> > +}
> > +
> > +/*
> > + * overlay_get_node_info will get the all node's full name with path. This
> > is
> > + * useful when checking node for duplication i.e. dtbo tries to add nodes
> > which
> > + * already exists in device tree.
> > + */
> > +static void overlay_get_node_info(void *fdto, char ***node_full_path,
> 
> You will retrieve mutiple nodes. So I think the function wants to be named
> 'overlay_get_nodes_info()'. Same for node_full_path.
> 
> Furthermore, you could drop one * if you return the list of paths. This will
> also allow you to return an error when xmalloc fails (see below)
> 
> Lastly, AFAICT, fdto can be const.
> 
> > +                                  int num_overlay_nodes)
> 
> This coud be unsigned int.
> 
> > +{
> > +    int fragment;
> > +    int node_num = 0;
> 
> This could be unsigned int.
> 
> > +
> > +    *node_full_path = xmalloc_bytes(num_overlay_nodes * sizeof(char *));
> 
> Memory allocation can fail.
> 
> > +
> > +    fdt_for_each_subnode(fragment, fdto, 0)
> > +    {
> > +        int target;
> > +        int overlay;
> > +        int subnode;
> > +        const char *target_path;
> > +
> > +        target = fdt_overlay_get_target(device_tree_flattened, fdto,
> > fragment,
> > +                                    &target_path);
> 
> fdt_overlay_get_target() can fail. Also, the indentation looks strange.
> 
> > +        overlay = fdt_subnode_offset(fdto, fragment, "__overlay__");
> 
> fdt_subnode_offset can fail.
> 
> > +
> > +        fdt_for_each_subnode(subnode, fdto, overlay)
> > +        {
> > +            const char *node_name = fdt_get_name(fdto, subnode, NULL);
> 
> AFAIU, fdt_get_name() can return NULL;
> 
> > +            int node_name_len = strlen(node_name);
> 
> fdt_get_name() can already provide the len for you. Can you re-use it?
> 
> 
> 
> > +            int target_path_len = strlen(target_path);
> > +            int node_full_name_len = target_path_len + node_name_len + 2;
> 
> node_name_len, target_path_len, node_full_name_len can be unsigned. Also, I
> would add a comment explain what '2' refers to.
> 
> > +
> > +            (*node_full_path)[node_num] =
> > xmalloc_bytes(node_full_name_len);
> 
> xmalloc_bytes() can fail.
> 
> > +
> > +            memcpy((*node_full_path)[node_num], target_path,
> > target_path_len);
> > +
> > +            (*node_full_path)[node_num][target_path_len] = '/';
> > +
> > +            memcpy((*node_full_path)[node_num] + target_path_len + 1,
> > node_name,
> > +                   node_name_len);
> > +
> > +            (*node_full_path)[node_num][node_full_name_len - 1] = '\0';
> > +
> > +            node_num++;
> > +        }
> > +    }
> > +}
> > +
> > +/*
> > + * Checks if all the devices node listed are present in dt_host and used by
> > any
> > + * domain.
> > + */
> 
> Why do we need to handle all the nodes together? I think the code would end up
> to be simpler if we were handling node by node.
> 
> > +static int check_nodes(char **full_dt_node_path, uint32_t num_nodes)
> > +{
> > +    int rc = 0;
> > +    unsigned int i;
> > +    struct dt_device_node *overlay_node;
> > +    uint32_t ret = 0;
> 
> AFAICT, you are storing a domid here, so this wants to be a domid_t and
> possible renamed to domid.
> 
> > +
> > +    for ( i = 0; i < num_nodes; i++ ) {
> > +        dt_dprintk("Finding node %s in the dt_host\n",
> > full_dt_node_path[i]);
> > +
> > +        overlay_node = dt_find_node_by_path(full_dt_node_path[i]);
> > +
> > +        if ( overlay_node == NULL )
> > +        {
> > +            rc = -EINVAL;
> > +
> > +            printk(XENLOG_G_ERR "Device %s is not present in the tree."
> 
> You seem to use a mix of XENLOG_G_ERR and XENLOG_ERR. However, it is not
> entirely clear some messages are more critical than the other. Could you
> clarify?
> 
> > +                   " Removing nodes failed\n", full_dt_node_path[i]);
> 
> Coding style: We don't split error message even if they are more than 80
> lines. This helps grepping them in the log.
> 
> > +            return rc;
> > +        }
> > +
> > +        ret = dt_device_used_by(overlay_node);
> > +
> > +        dt_dprintk("Checking if node %s is used by any domain\n",
> > +                   full_dt_node_path[i]);
> > +
> > +        if ( ret != 0 && ret != DOMID_IO )
> 
> In the commit message you wrote:
> 
> "The nodes get removed only if it is not used by any of dom0 or domus"
> 
> This implies that this should return -EINVAL for domid as well. Can you make
> sure the two matches? (I am not sure which one you want).
> 
> Also, what does prevent the device to not be assigned for the check?
> 
> > +        {
> > +            rc = -EINVAL;
> 
> NIT: This is a bit pointless to set rc when it is just used 2 lines below in
> the return. The alternative is to replace the return with a break.
> 
> > +
> > +            printk(XENLOG_G_ERR "Device %s as it is being used by domain
> > %d."
> > +                   " Removing nodes failed\n", full_dt_node_path[i], ret);
> 
> Coding style: Same about the error message.
> 
> > +            return rc;
> > +        }
> > +    }
> > +
> > +    return rc;
> > +}
> > +
> > +/* Remove nodes from dt_host. */
> > +static int remove_nodes(char **full_dt_node_path, uint32_t num_nodes)
> 
> In the commit message, you said you wanted to remove all the nodes together.
> But this function could possibly fail leaving some nodes present or not.
> 
> As I wrote above, I think handling node by node would be fine. However, we
> need to make sure that the remove operation can be called again to clean-up
> the rest of the nodes.
> 
> > +{
> > +    struct domain *d = hardware_domain;
> > +    int rc = 0;
> > +    struct dt_device_node *overlay_node;
> > +    unsigned int naddr;
> > +    unsigned int i, j, nirq;
> > +    struct dt_raw_irq rirq;
> > +    u64 addr, size;
> > +
> > +    for ( j = 0; j < num_nodes; j++ ) {
> > +        dt_dprintk("Removing node: %s\n", full_dt_node_path[j]);
> > +
> > +        overlay_node = dt_find_node_by_path(full_dt_node_path[j]);
> > +
> > +        nirq = dt_number_of_irq(overlay_node);
> > +
> > +        /* Remove IRQ permission */
> > +        for ( i = 0; i < nirq; i++ )
> > +        {
> > +            rc = dt_device_get_raw_irq(overlay_node, i, &rirq);
> > +            if ( rc )
> > +            {
> > +                printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n",
> > +                       i, dt_node_full_name(overlay_node));
> > +                return rc;
> > +            }
> 
> The interrupt may not be routed to the GIC, in which case we want to skip
> them. So you want to check the controller is equal to dt_interrupt_controller.
> 
> The code is also quite similar to handle_device_interrupts(). So I would
> abstract the code to avoid duplication.
> 
> That said, I find a bit odd to have to parse the overlay again on remove given
> you expect the same to be passed.  I think it might be better to use rangeset
> to keep track of the interrupts added with that specific overlay.
> 
> This will reduce the possibility that remove can go wrong.
> 
> > +
> > +            rc = platform_get_irq(overlay_node, i);
> > +            if ( rc < 0 )
> > +            {
> > +                printk(XENLOG_ERR "Unable to get irq %u for %s\n",
> > +                       i, dt_node_full_name(overlay_node));
> > +                return rc;
> > +            }
> > +
> > +            rc = irq_deny_access(d, rc);
> 
> A few things:
> 
>   1) IRQs can be assigned to another domain without the device being assigned.
> So this want to be checked.
>   2) This is assuming the IRQ was not shared. I am not entirely sure how to
> solve this one. Maybe a TODO and note in the documentation will do for now.
> Stefano?

I think it is fine if we don't handle shared IRQs for now. A note in the
documentation and a TODO is OK.


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 01:09:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 01:09:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251193.432488 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Z5G-0000Kq-Qx; Fri, 24 Dec 2021 01:09:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251193.432488; Fri, 24 Dec 2021 01:09:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0Z5G-0000Kj-Nk; Fri, 24 Dec 2021 01:09:22 +0000
Received: by outflank-mailman (input) for mailman id 251193;
 Fri, 24 Dec 2021 01:09:21 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Z5F-0000KZ-1V; Fri, 24 Dec 2021 01:09:21 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Z5E-0005nm-W0; Fri, 24 Dec 2021 01:09:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Z5E-0002iW-Lw; Fri, 24 Dec 2021 01:09:20 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0Z5E-0006n9-LS; Fri, 24 Dec 2021 01:09:20 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=PO7q+hgASq7NMmcLJhjN1eulV22zwjVhTd4/7kaAfsM=; b=SuF5UcdvamS9i3KWetqod2uQdC
	c3iFE3Npdg/kRnVoAymMDN0B6r5w7s61PUhpaSyYaP4WnfU+6MsJunbe0ok2YQVZqtZu2OUMBoDm9
	isN/0Z62Vr+W2/uHxCtZ0w+PYlSTJll2ffgQxBCyDZY7ZZoTX7C50dG0W2WZ43WiJTcI=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167529-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167529: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=996a18eb796a5ee61582dea3b76a4f88203887d9
X-Osstest-Versions-That:
    linux=bc491fb12513e79702c6f936c838f792b5389129
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 01:09:20 +0000

flight 167529 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167529/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167526
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167526
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167526
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167526
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167526
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167526
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167526
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167526
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                996a18eb796a5ee61582dea3b76a4f88203887d9
baseline version:
 linux                bc491fb12513e79702c6f936c838f792b5389129

Last test of basis   167526  2021-12-23 05:07:16 Z    0 days
Testing same since   167529  2021-12-23 18:39:44 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Arnd Bergmann <arnd@arndb.de>
  Bard Liao <yung-chuan.liao@linux.intel.com>
  Bartosz Golaszewski <brgl@bgdev.pl>
  Bradley Scott <Bradley.Scott@zebra.com>
  Bradley Scott <bscott@teksavvy.com>
  Chen-Yu Tsai <wens@csie.org>
  Christian Hewitt <christianshewitt@gmail.com>
  Christophe Kerello <christophe.kerello@foss.st.com>
  Colin Ian King <colin.i.king@gmail.com>
  Derek Fang <derek.fang@realtek.com>
  Dmitry Osipenko <digetx@gmail.com>
  Fabio Estevam <festevam@gmail.com>
  Geraldo Nascimento <geraldogabriel@gmail.com>
  Jaroslav Kysela <perex@perex.cz>
  Jens Wiklander <jens.wiklander@linaro.org>
  Jeremy Szu <jeremy.szu@canonical.com>
  Jernej Skrabec <jernej.skrabec@gmail.com>
  Jerome Brunet <jbrunet@baylibre.com>
  Kai Vehmanen <kai.vehmanen@linux.intel.com>
  Li Yang <leoyang.li@nxp.com>
  Libin Yang <libin.yang@intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mark Brown <broonie@kernel.org>
  Martin Blumenstingl <martin.blumenstingl@googlemail.com>
  Martin Haaß <vvvrrooomm@gmail.com>
  Martin Povišer <povik@protonmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Michael S. Tsirkin <mst@redhat.com>
  Noralf Trønnes <noralf@tronnes.org>
  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
  Prathamesh Shete <pshete@nvidia.com>
  Robert Marko <robert.marko@sartura.hr>
  Ron Goossens <rgoossens@gmail.com>
  Samuel Holland <samuel@sholland.org>
  Shawn Guo <shawnguo@kernel.org>
  Sumit Garg <sumit.garg@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Thomas Graichen <thomas.graichen@gmail.com> # T124 Nyan Big
  Ulf Hansson <ulf.hansson@linaro.org>
  Ville Syrjälä <ville.syrjala@linux.intel.com>
  Vincent Whitchurch <vincent.whitchurch@axis.com>
  Viresh Kumar <viresh.kumar@linaro.org>
  Werner Sembach <wse@tuxedocomputers.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Xiaolei Wang <xiaolei.wang@windriver.com>
  Yann Gautier <yann.gautier@foss.st.com>
  Zhang Ying <ying.zhang22455@nxp.com>
  Zhang Ying-22455 <ying.zhang22455@nxp.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   bc491fb12513..996a18eb796a  996a18eb796a5ee61582dea3b76a4f88203887d9 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 01:32:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 01:32:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251201.432499 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ZRS-0003ut-Pb; Fri, 24 Dec 2021 01:32:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251201.432499; Fri, 24 Dec 2021 01:32:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ZRS-0003um-KQ; Fri, 24 Dec 2021 01:32:18 +0000
Received: by outflank-mailman (input) for mailman id 251201;
 Fri, 24 Dec 2021 01:32:17 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+lMa=RJ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0ZRQ-0003ug-V4
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 01:32:16 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org
 [2604:1380:4641:c500::1])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 51fad479-6459-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 02:32:15 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id A254C61F9F;
 Fri, 24 Dec 2021 01:32:12 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D5DCC36AE5;
 Fri, 24 Dec 2021 01:32:11 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 51fad479-6459-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640309531;
	bh=LPshgZ3zjboQ5EJzVyDW/BQmBB7iaDhLVaPrAzACgww=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=IAtDxYENSt4l+ipbneOt0QkAmsfwUzjATkYZIMHH8+AOWRGV/C7hQwpwMpCOWdcYg
	 I0IGDUYD53oA+K4XIDF//h0n7jCMKXDf4Ys4GEPxE3okm5r+lsz3e/yWrSODqtZ8Vo
	 VBQn/750qduQdTbVXZQKkapcN7dNOJhaHjFeKUn6p1hnfHehlMvcYKyeuUq2bQgzWH
	 yHZkFAj10N2rLD9cEmje9svEQ780rJxIkAXo19MMXcpaZKH2tcxFzmr5ODf3u7cVfi
	 svGOKrc3ikWodtfqpOFqUeY+CoUKgxRMKOlSlots9jHAEAiu/r+GGaEpkghE3W+jUD
	 KUSgBID2WPkfA==
Date: Thu, 23 Dec 2021 17:32:11 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, 
    Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com
Subject: Re: [XEN PATCH 1/1] xen/arm: introduce dummy iommu node for dom0
In-Reply-To: <20211222131847.2476835-2-Sergiy_Kibrik@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112231724570.2060010@ubuntu-linux-20-04-desktop>
References: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com> <20211222131847.2476835-2-Sergiy_Kibrik@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Sergiy Kibrik wrote:
> Currently no IOMMU properties are exposed to dom0, thus kernel by default
> assumes no protection and enables swiotlb-xen, which leads to costly and
> unnecessary buffers bouncing.
> 
> To let kernel know which device is behing IOMMU and hence needs no swiotlb
> services we introduce dummy xen-iommu node in FDT and link protected device
> nodes to it, using here device tree iommu bindings.
> 
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>

Hi Sergiy,

Thanks for the patch, I like how simple it is. FYI the patch doesn't
apply cleanly to staging any longer, you might need to rebase it.


> ---
>  xen/arch/arm/domain_build.c           | 44 +++++++++++++++++++++++++++
>  xen/include/asm-arm/kernel.h          |  3 ++
>  xen/include/public/device_tree_defs.h |  1 +
>  3 files changed, 48 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 6cfc772e66..951ca0a0cb 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -623,6 +623,12 @@ static int __init write_properties(struct domain *d, struct kernel_info *kinfo,
>          }
>      }
>  
> +    if ( iommu_node && kinfo->phandle_iommu && dt_device_is_protected(node) )
> +    {
> +        res = fdt_property_cell(kinfo->fdt, "iommus", kinfo->phandle_iommu);
> +        if ( res )
> +            return res;
> +    }
>      return 0;
>  }
>  
> @@ -948,6 +954,38 @@ static int __init make_cpus_node(const struct domain *d, void *fdt)
>      return res;
>  }
>  
> +static int __init make_iommu_node(const struct domain *d,
> +                                  const struct kernel_info *kinfo)
> +{
> +    const char compat[] = "xen,iommu-el2-v1";
> +    int res;
> +
> +    if ( !kinfo->phandle_iommu )
> +        return 0;
> +
> +    dt_dprintk("Create iommu node\n");
> +
> +    res = fdt_begin_node(kinfo->fdt, "xen-iommu");
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property(kinfo->fdt, "compatible", compat, sizeof(compat));
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property_cell(kinfo->fdt, "#iommu-cells", 0);
> +    if ( res )
> +        return res;
> +
> +    res = fdt_property_cell(kinfo->fdt, "phandle", kinfo->phandle_iommu);
> +
> +    res = fdt_end_node(kinfo->fdt);
> +    if ( res )
> +        return res;
> +
> +    return res;
> +}
> +
>  static int __init make_gic_node(const struct domain *d, void *fdt,
>                                  const struct dt_device_node *node)
>  {
> @@ -1584,6 +1622,10 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo,
>          if ( res )
>              return res;
>  
> +        res = make_iommu_node(d, kinfo);
> +        if ( res )
> +            return res;
> +
>          res = make_memory_node(d, kinfo->fdt, addrcells, sizecells, &kinfo->mem);
>          if ( res )
>              return res;
> @@ -2177,6 +2219,8 @@ static int __init prepare_dtb_hwdom(struct domain *d, struct kernel_info *kinfo)
>      ASSERT(dt_host && (dt_host->sibling == NULL));
>  
>      kinfo->phandle_gic = dt_interrupt_controller->phandle;
> +    if ( is_iommu_enabled(d) )
> +        kinfo->phandle_iommu = GUEST_PHANDLE_IOMMU;

It doesn't look like we need to save GUEST_PHANDLE_IOMMU under kinfo.
GUEST_PHANDLE_IOMMU is static. Instead we can just:

if ( !is_iommu_enabled(d) )
    return 0;

at the beginning of make_iommu_node. Same for write_properties, we can
just skip the kinfo->phandle_iommu check and use GUEST_PHANDLE_IOMMU in
fdt_property_cell.





>      fdt = device_tree_flattened;
>  
>      new_size = fdt_totalsize(fdt) + DOM0_FDT_EXTRA_SIZE;
> diff --git a/xen/include/asm-arm/kernel.h b/xen/include/asm-arm/kernel.h
> index 874aa108a7..efe09cd1e0 100644
> --- a/xen/include/asm-arm/kernel.h
> +++ b/xen/include/asm-arm/kernel.h
> @@ -39,6 +39,9 @@ struct kernel_info {
>      /* GIC phandle */
>      uint32_t phandle_gic;
>  
> +    /* dummy iommu phandle */
> +    uint32_t phandle_iommu;
> +
>      /* loader to use for this kernel */
>      void (*load)(struct kernel_info *info);
>      /* loader specific state */
> diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h
> index 209d43de3f..df58944bd0 100644
> --- a/xen/include/public/device_tree_defs.h
> +++ b/xen/include/public/device_tree_defs.h
> @@ -7,6 +7,7 @@
>   * onwards. Reserve a high value for the GIC phandle.
>   */
>  #define GUEST_PHANDLE_GIC (65000)
> +#define GUEST_PHANDLE_IOMMU (GUEST_PHANDLE_GIC + 1)
>  
>  #define GUEST_ROOT_ADDRESS_CELLS 2
>  #define GUEST_ROOT_SIZE_CELLS 2
> -- 
> 2.25.1
> 
> 


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 01:52:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 01:52:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251205.432510 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ZkI-0006jn-FB; Fri, 24 Dec 2021 01:51:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251205.432510; Fri, 24 Dec 2021 01:51:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ZkI-0006jf-AM; Fri, 24 Dec 2021 01:51:46 +0000
Received: by outflank-mailman (input) for mailman id 251205;
 Fri, 24 Dec 2021 01:51:45 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=+lMa=RJ=kernel.org=sstabellini@srs-se1.protection.inumbo.net>)
 id 1n0ZkH-0006jG-9a
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 01:51:45 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 0afc148c-645c-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 02:51:43 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 2F75661F9E;
 Fri, 24 Dec 2021 01:51:42 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 512B0C36AE5;
 Fri, 24 Dec 2021 01:51:41 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 0afc148c-645c-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1640310701;
	bh=+Yuj+jIIU5uavavlXqFjjqLLM2Y8gy6tn41H9Y3xIlk=;
	h=Date:From:To:cc:Subject:In-Reply-To:References:From;
	b=m0B3GCxmmeYD2b4CD0pnEoZvfJM8sO+RdJiyFpZ2A6Ir6G0W+X3wb8rSBbTYGSPGo
	 KdbSHlK62cLIxtS0ovrBGCoh7KlQ4YoVv60azrJ79+5D91EmpKtbhDUOlPdLrE9xl5
	 hg18PBX0JcirQTJS3f1yRyz0JwKXNAIjE+GU8oYeCD8KdChjf4LNjaSYEoLgxadWBg
	 qW8bkxXk6tQ1I2D+5ZsX+9zUgyqBZhs75UiDtzOC110CDj24eRyrujYd6qQ/7KSWPN
	 9IoGtS65RQZTGaC8dYDo0Qx4bAq8vQXc2AmDLW1bPGGxsqXqyrxmzMurYuI75WKtiD
	 x5zZoa7d6XkHg==
Date: Thu, 23 Dec 2021 17:51:41 -0800 (PST)
From: Stefano Stabellini <sstabellini@kernel.org>
X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop
To: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/1] arm/xen: don't use xen DMA ops when the device is
 protected by an IOMMU
In-Reply-To: <20211222131847.2476835-3-Sergiy_Kibrik@epam.com>
Message-ID: <alpine.DEB.2.22.394.2112231738550.2060010@ubuntu-linux-20-04-desktop>
References: <20211222131847.2476835-1-Sergiy_Kibrik@epam.com> <20211222131847.2476835-3-Sergiy_Kibrik@epam.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 22 Dec 2021, Sergiy Kibrik wrote:
> Only Xen is able to know if a device can safely avoid to use xen-swiotlb.
> However since Xen links FDT nodes of protected devices to special dummy
> xen-iommu node we can use that information to decide whether
> xen-swiotlb is needed.
> 
> Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
> ---
>  arch/arm/mm/dma-mapping.c   | 2 +-
>  arch/arm/xen/enlighten.c    | 9 +++++++++
>  arch/arm64/mm/dma-mapping.c | 2 +-
>  include/xen/swiotlb-xen.h   | 1 +
>  4 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index c4b8df2ad328..fc875dd16e0e 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -2280,7 +2280,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  	set_dma_ops(dev, dma_ops);
>  
>  #ifdef CONFIG_XEN
> -	if (xen_initial_domain())
> +	if (xen_initial_domain() && !xen_is_protected_device(dev))
>  		dev->dma_ops = &xen_swiotlb_dma_ops;
>  #endif
>  	dev->archdata.dma_ops_setup = true;
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 49f566ad9acb..b36659238db3 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -66,6 +66,15 @@ static __read_mostly unsigned int xen_events_irq;
>  uint32_t xen_start_flags;
>  EXPORT_SYMBOL(xen_start_flags);
>  
> +bool xen_is_protected_device(struct device *dev)
> +{
> +	struct fwnode_handle *fwnode =
> +		fwnode_find_reference(dev_fwnode(dev), "iommus", 0) ;
> +	if (IS_ERR(fwnode))
> +		return false;
> +	return of_device_is_compatible(to_of_node(fwnode), "xen,iommu-el2-v1");
> +}

We need to add a description of the "xen,iommu-el2-v1" compatible node
under Documentation/devicetree/bindings. Maybe it could be added to
Documentation/devicetree/bindings/arm/xen.txt, but it could also be its
own new file.


>  int xen_unmap_domain_gfn_range(struct vm_area_struct *vma,
>  			       int nr, struct page **pages)
>  {
> diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> index 93e87b287556..68248e72e052 100644
> --- a/arch/arm64/mm/dma-mapping.c
> +++ b/arch/arm64/mm/dma-mapping.c
> @@ -53,7 +53,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>  		iommu_setup_dma_ops(dev, dma_base, size);
>  
>  #ifdef CONFIG_XEN
> -	if (xen_initial_domain())
> +	if (xen_initial_domain() && !xen_is_protected_device(dev))
>  		dev->dma_ops = &xen_swiotlb_dma_ops;

This patch needs to be rebased on the latest master. You'll see that now
we have a more sophisticated xen_swiotlb_detect(), instead of the simple
xen_initial_domain() we used to have. Still, xen_swiotlb_detect() is
global, not per device, so I think this change would still apply as is,
resulting in:

if (xen_swiotlb_detect() && !xen_is_protected_device(dev))
    dev->dma_ops = &xen_swiotlb_dma_ops;


>  #endif
>  }
> diff --git a/include/xen/swiotlb-xen.h b/include/xen/swiotlb-xen.h
> index d5eaf9d682b8..00b2782430fb 100644
> --- a/include/xen/swiotlb-xen.h
> +++ b/include/xen/swiotlb-xen.h
> @@ -8,6 +8,7 @@ void xen_dma_sync_for_cpu(struct device *dev, dma_addr_t handle,
>  			  size_t size, enum dma_data_direction dir);
>  void xen_dma_sync_for_device(struct device *dev, dma_addr_t handle,
>  			     size_t size, enum dma_data_direction dir);
> +bool xen_is_protected_device(struct device *dev);
>  
>  extern int xen_swiotlb_init(int verbose, bool early);
>  extern const struct dma_map_ops xen_swiotlb_dma_ops;


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 04:26:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 04:26:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251212.432521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0cA0-0007pE-OP; Fri, 24 Dec 2021 04:26:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251212.432521; Fri, 24 Dec 2021 04:26:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0cA0-0007p7-KT; Fri, 24 Dec 2021 04:26:28 +0000
Received: by outflank-mailman (input) for mailman id 251212;
 Fri, 24 Dec 2021 04:26:26 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0c9y-0007ox-Qt; Fri, 24 Dec 2021 04:26:26 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0c9y-0001CG-MU; Fri, 24 Dec 2021 04:26:26 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0c9y-0001mF-9E; Fri, 24 Dec 2021 04:26:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0c9y-00048F-8M; Fri, 24 Dec 2021 04:26:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t4auWWLAjOW7UtFy2zmvrry/8EIMeWJC5fd9hKLjHOs=; b=evmFQIAbHspfIf9RJCcE+8SFHb
	/TfDqU1CwtIQrBQFSvJe0DxLhbZ/CjgGY3k/dBz5hmRFeshSy1ItBIvKqb3m0xrZBqn3rvo8HAKh4
	LE9ttG9GN566xKssIIzNo5jtNPPLX2tAhyLG7FuVPFQlCijE7Pl0EFVbSgdJDrrAAKSo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167530-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167530: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=1bd88c4542e97f49955c142f8dc04dd32df9e91f
X-Osstest-Versions-That:
    qemuu=6f016a2f7909eb6d595436a2f56cdf7cdf3e3c68
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 04:26:26 +0000

flight 167530 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167530/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167524
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167524
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167524
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167524
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167524
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167524
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167524
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167524
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                1bd88c4542e97f49955c142f8dc04dd32df9e91f
baseline version:
 qemuu                6f016a2f7909eb6d595436a2f56cdf7cdf3e3c68

Last test of basis   167524  2021-12-23 02:52:56 Z    1 days
Testing same since   167530  2021-12-23 20:08:11 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   6f016a2f79..1bd88c4542  1bd88c4542e97f49955c142f8dc04dd32df9e91f -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 07:25:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 07:25:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251233.432532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ewQ-0003q4-O7; Fri, 24 Dec 2021 07:24:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251233.432532; Fri, 24 Dec 2021 07:24:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ewQ-0003px-Kx; Fri, 24 Dec 2021 07:24:38 +0000
Received: by outflank-mailman (input) for mailman id 251233;
 Fri, 24 Dec 2021 07:24:37 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P6v+=RJ=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1n0ewP-0003po-58
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 07:24:37 +0000
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 88da81e1-648a-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 08:24:32 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Dec 2021 23:24:29 -0800
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga004.jf.intel.com with ESMTP; 23 Dec 2021 23:24:29 -0800
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:24:29 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 23:24:29 -0800
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174)
 by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 23 Dec 2021 23:24:28 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN9PR11MB5369.namprd11.prod.outlook.com (2603:10b6:408:11a::14)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 07:24:22 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04%2]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 07:24:22 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 88da81e1-648a-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1640330672; x=1671866672;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=4EtgHTgdvoZyWdMxh0XiWHYZjaBSHOGh1WXMaHY8eFw=;
  b=TwbwZnTfaFBYPoS+DadQxX92okoFWhJXW/FNA8MKRRuBuY/ugovy+Isr
   fRSnhUw8/LJFpdO4qTMvvnEhWLJww+NxBXsFVpx0d2LZraOwbc25yZR+v
   eWTHa4CyLNQg0IarwdltCNOxzbey5XwJ/misQfXk0aHqAPrgD+ar0iqq/
   6F8Z7h30aJ0QNRpPoe6iumcAFaO3ngNks9LrcDuvE0/f2ZtK8aARlA5bf
   xVhcFnpYUQEgfCILRam8ute+u9vZotdARlrJAv11bZeeSxZDYLih6lb4m
   BcrlCoKBMqNIVe6/TX6s5Is1HOZ9f4Bmyi49/TKynRKhdMGunTGawiVwf
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="304312803"
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="304312803"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="617712960"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=POdWB9GQvLI+SiZbdRexz5YdJGQ7OLhaucCsgNtrcrJ58BrUT88AXcygsKmr80dLFEXDbHpbS0jrR2kDKQMUfjbT2BipFJnY4QAYtHVtcwt9/VQ9p7C/6BChXEVmHdHrKGJguF0iT+qcxr5Ge/j2GicfhtU6JXA44Fba2A2pyFPnAssx8fBmPu2/U//s3d81xAoF25w6Op9f1T45rFoEfMzOvt4bpY015wA47prbItcqjC76ib6S0TL9EBhk9Q22ph75r6cQnH3foYWGyGIdvhoFCwacACk6gKs/+4fPhKZIx+8BjPKop7qB10n3PunnDnCxMiNyAZEWV5RhjvCYBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=4EtgHTgdvoZyWdMxh0XiWHYZjaBSHOGh1WXMaHY8eFw=;
 b=X++73B9ePwl+QaZuDWwE7X/obzcSrIFx0AHUF/Whe/EtvIq/wZG9MF6coplO49bhEfH5asJvpXgJl8ESdjdsO6U5cy4dmwl/GwSzwrWb663ngrA/0/dFy0QXb1AmM/yMFLDIx37m9EXkofbgh+RQrGlePoD0d3UUJx5cu3CZyDNN0rpWrtNYCy6YChnFFUzy4VCvCyiORTK6zX+0oTldgfpGoxS86oMlJcNji6+BMd+meKiYvqPhVNcWAkhmyXiMu4vQUttwY9333r3R6Z3uem3+oNT3ylAEVLm9kEjYdVoiczC+K/UNRyD+kx1wtPIxphBL3ZN6Qqd2LZjlmFpu/g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, Andrew Cooper <amc96@srcf.net>
CC: Paul Durrant <paul@xen.org>, "Cooper, Andrew" <andrew.cooper3@citrix.com>,
	Wei Liu <wl@xen.org>, =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?=
	<roger.pau@citrix.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH 2/4] VT-d / x86: re-arrange cache syncing
Thread-Topic: [PATCH 2/4] VT-d / x86: re-arrange cache syncing
Thread-Index: AQHX5pein16Riinjd0WXoe65lFt6IqwdtVIAgAE4ywCAInJTkA==
Date: Fri, 24 Dec 2021 07:24:22 +0000
Message-ID: <BN9PR11MB5276C2991C9A5563316E7D8A8C7F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <e0819175-83b4-9489-8e4b-7be4940f1d54@suse.com>
 <2a448375-6f57-578f-6ac3-ba818d0c2eb3@srcf.net>
 <b361ea84-2b4c-6f3f-5a25-11d1ad2bc5fc@suse.com>
In-Reply-To: <b361ea84-2b4c-6f3f-5a25-11d1ad2bc5fc@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7d0a78b0-7b03-4054-e20f-08d9c6ae6841
x-ms-traffictypediagnostic: BN9PR11MB5369:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN9PR11MB5369C90C068FEB18F5A1A2F38C7F9@BN9PR11MB5369.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: bJx28a+PhY/6gKMipLf36aTz1Af3AVm/l5/orvVhaycdshL4UPDzueyLsyyQkhDXXr5S8O+ibJLTl9Jd1eJX/XEitdCtFrHP8JB7lNuImNov8kQPgnQwJqgQrK6xEg4cWP0Bjx0EMZFwN/9pMf6JqsAtHXWNE2IWYFwSe9n2whYn+8/CkBTdWcyxifwUhlVJhonSfYNrhvC6EtBTXCJjldxNjFQX/8r21grNHQy4EYz/ZYgc1Dr0PntXm/jqZQKpVQIjol7j05PKIAnm9P//n1SKm/hKphCqm1BdEA7V3IY0qb0g4XtW65okZjSLSl9f2bSletsHdN1xwR+yS+tqjyJJ0yx9+/SRv89nejg5N58I+NLBuKfeGv9T8wK1z8+OiqQPy6ibdIH/cH7aanQb8NczxJFuEBQO/uqxpZIgYnCF57fEw0vTNv9PlOuVMYwSJ5f4QlLXHEj83k4JVETkcfIqdmD8JDxyA5wpSNZZ2KhT3p5p50M9xqaroeJqrbkKh22zX550/BGbNwBoGAzCgbCGs353xHhkIXLzu+tW0JfcQaBzA1I45CKqsOHk4d6h3TI6AngiU0sHiIGEZfZ1l6jPsT1MNP20o+83wUgoU24sT5i7Rs61ZDXuCES/0grYItEl5bUeUQu6MnAYQPVK/uxCrc0MdSoL7MtV0kXfCgqrkxKiujy2WXETy/RIesMqZFtqRKGjyWJK6vqLwMgwMg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(55016003)(122000001)(110136005)(83380400001)(2906002)(316002)(86362001)(38100700002)(33656002)(8676002)(8936002)(5660300002)(4326008)(66476007)(508600001)(6506007)(82960400001)(53546011)(66946007)(71200400001)(66556008)(186003)(38070700005)(64756008)(76116006)(66446008)(9686003)(7696005)(52536014)(26005);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3RWTUVkSGtZcnA1R0Q2L3A0bGw4REs3WDR3ek5Yb2tSN0RZUllVcFNFN1Nk?=
 =?utf-8?B?eFNvRGYvNFJFUGxTLzRCZTdFczQxcXl5VUNhTnZsWDAxQkdHTGJWVHgwa1c1?=
 =?utf-8?B?RlVMMWdsL21BcDZybFJFTWEvWGpHRTdzVUJTRWZpdDh5bFVtVWZBdFZZYlpu?=
 =?utf-8?B?aFgwL0tCc1F1STdyeC9qemJjOXBTOFBaOHFDRjd6dVlKSUxqVm82cUdZdzIw?=
 =?utf-8?B?cFlpYklLNTlRa01nVmZIdlFWOTB2MmVrYVBCSStScVB3MnI5RVV2NTdkdUdy?=
 =?utf-8?B?WUNOQkorNGJySW13QjgzblpEdUdzeXZMdjBkSEs4dGxObGs0dnFQeWxvTjZt?=
 =?utf-8?B?OGZVcDcxT2lPMDBWMmtsUEw4dWx5VmV2ckpIOEkrTzZnK3ZjVDAwUnAxMTk3?=
 =?utf-8?B?d2xSSmxaN2pkajlUazhHS28wVW5MMjBadkdXVUpBL2pnait6S2VXVVMzN2xV?=
 =?utf-8?B?Zlc5QytHRDFTaytFOFJLcmV4b0FwUkorUnkzMU9mR2xWS1VaODJ2MFY5UGU2?=
 =?utf-8?B?clUySmJodUkxT0ZaMlBWR1Aya1NWYlBjc3V6czEzb1QvM0pEZ2RxVWtMR2xx?=
 =?utf-8?B?QzhxUjZCbGs5MlVyQ05PWTF1RXBIMGkwZ2tORkRFZUNYN1BEektLRmg0cVhu?=
 =?utf-8?B?WWk5RjFaWWxraXRHaVAxVnQ0SXN0WVVUZEltQ0xnYnRIZi93Y1NHM3JUTnpq?=
 =?utf-8?B?RGFkbWs2eVZicXZsbVcxNFU0OTZWUjZvVWljaUFRTnAybkhyemJueGR3S1JJ?=
 =?utf-8?B?T1VXdjN3dWtLSnUyYXEwSEsrV2VZQzR2ZCt5Q3NUZDJzMkM5aCtuckJaSVBW?=
 =?utf-8?B?cnNJQTdiWXJJTnU3N21FRGFlVkRlRmxaK2hkdFhkaWdzR21KLy9DaHQ2YUdq?=
 =?utf-8?B?b1R0S1FlbHdka282ZVorWTdiYktZRUxuUDlLYXRkUE1BamNvcEp5TnEyV3dj?=
 =?utf-8?B?b1VKVld1azIweHRSdjQ1VFpTNEg2ZlBHSmlvdHY3U2ZMenk1VmVHdUVBVEVM?=
 =?utf-8?B?d2FVby9OK28xYlNESFN6cDVDMTZQaU1WTG9wWERwUndLSit4QVNBdDNkM0Zi?=
 =?utf-8?B?dzFsYW5JbU90Q1p2N2xHbTFKcS9SbGZKT3EvcHo1Q0llb3N0MStWTHZ4cTNE?=
 =?utf-8?B?SU1jWFBiQmVOV2pUSWJyakRTQituNWl2c1JySHRCVVhLbHBkMjZlY3kvK3JU?=
 =?utf-8?B?eDdxUm9leVUrck9UcDBrK1oweUYwYWF5V2FlV29KVWpyVjV0TzBQMndPSjFI?=
 =?utf-8?B?ZEhlZHVnbTJmdm9zRld5UjYyNkJjQ05xZTJQdHA2bi90Z2ZjaDhLQU9iUXlp?=
 =?utf-8?B?OFlrRnA3UHQzTEZNeHQzcWQ0KzFtMFY4REkxbG5vWVppL3o2MGpxUWNOOVlQ?=
 =?utf-8?B?THhvbVVYTURzbUZoR2h2Q2Z1TmhUZWNyS25tdUxIMHN0VVRwUmU0dFF5L2dR?=
 =?utf-8?B?T055bldJT245WVh5TW9CQjRGNXNyMStoUzhzZ2lyM3paUmZxWWUyK2ZwK2N2?=
 =?utf-8?B?MEN4blRVZDRmWlhGNm1yVnV5bVc4R1g5Mlp1TlU3ZWVWUHdZVnQ0c3ZsK3JU?=
 =?utf-8?B?WlEyNmpTVXFkRDJKazdwd083MUkyeGpEOFpKQzFGK1JlN3B6cUVmeWpwNTEy?=
 =?utf-8?B?b3ltR2pWZXlqZHRjK2RET2d3Mm51RFhkU3VaOVAveUZDQU9PL2JsWUhVNDdm?=
 =?utf-8?B?OVJTK3dLd2FwS3FXYWxWaUV4TWkzYmFEM3VpQytBSC9tY09QSFVHUTZPNFR0?=
 =?utf-8?B?RU1VUjNIQ1BkSGtDdEpSdHFwR0c5eHdROFFyT1hqWDFiYlBRSUNmeFFJNFVQ?=
 =?utf-8?B?TnRHb0lCeWtqR2NrZFBYWVVaaUhTYkYyTnNhNkNwdFNBWkMxWWlSbFlmLzlK?=
 =?utf-8?B?OW5NdlRYOU9LR0FOOHlCeC92cFIzbFArL0VsNnpidU9jYU1iQTYzc05pRHli?=
 =?utf-8?B?VFBrdXNVYWYrTWJ6VEs0WU1LVEFhU3Q3UW8xZUU3VzZYUk1xWnF5MXQvc2RH?=
 =?utf-8?B?SVRybG9BWGhsN0lvQ1h3VzU0RHRuclhMN3NRSWszM1ZxampCWm1SNWZiUWFR?=
 =?utf-8?B?Q01sUUJiclVZdUM3QmkxQUVOTHNqbXpXckJMZG9qaXZPaEZpYUswa0tXTFhS?=
 =?utf-8?B?dzB4R3MvM1NOT3FyUmlJOFFXSktrY0M2NzVRVlFKVUE4UUh3bmZMWUdzS1gx?=
 =?utf-8?Q?kuilOheHHifuS42Zh0GBNYQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d0a78b0-7b03-4054-e20f-08d9c6ae6841
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 07:24:22.3929
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ju8sX1/hksy2L/t4rHHiDyy5bldBuzm5vHvZJJo5S5FnXSaVFotEBmdn25rUVXXADldrqy6p+JftJxejQrx/jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5369
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBEZWNlbWJlciAyLCAyMDIxIDU6MTkgUE0NCj4gDQo+IE9uIDAxLjEyLjIwMjEgMTU6MzksIEFu
ZHJldyBDb29wZXIgd3JvdGU6DQo+ID4gT24gMDEvMTIvMjAyMSAwOTo0MCwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+ID4+IFRoZSBhY3R1YWwgZnVuY3Rpb24gc2hvdWxkIGFsd2F5cyBoYXZlIGxpdmVk
IGluIGNvcmUgeDg2IGNvZGU7IG1vdmUgaXQNCj4gPj4gdGhlcmUsIHJlcGxhY2luZyBnZXRfY2Fj
aGVfbGluZV9zaXplKCkgYnkgcmVhZGlseSBhdmFpbGFibGUgKGV4Y2VwdCB2ZXJ5DQo+ID4+IGVh
cmx5IGR1cmluZyBib290OyBzZWUgdGhlIGNvZGUgY29tbWVudCkgZGF0YS4NCj4gPj4NCj4gPj4g
RHJvcCB0aGUgcmVzcGVjdGl2ZSBJT01NVSBob29rLCAocmUpaW50cm9kdWNpbmcgYSByZXNwZWN0
aXZlIGJvb2xlYW4NCj4gPj4gaW5zdGVhZC4gUmVwbGFjZSBhIHRydWUgYW5kIGFuIGFsbW9zdCBv
cGVuLWNvZGluZyBpbnN0YW5jZSBvZg0KPiA+PiBpb21tdV9zeW5jX2NhY2hlKCkuDQo+ID4NCj4g
PiBDb2hlcmVuY3kgKG9yIG5vdCkgaXMgYSBwZXItSU9NTVUgcHJvcGVydHksIG5vdCBhIGdsb2Jh
bCBwbGF0Zm9ybQ0KPiA+IHByb3BlcnR5LsKgIGlHUFUgSU9NTVVzIGFyZSB2ZXJ5IGRpZmZlcmVu
dCB0byB0aG9zZSB0aGUgdW5jb3JlLCBhbmQNCj4gPiB0aGVyZSdzIG5vIHJlYXNvbiB0byBwcmVz
dW1lIHRoYXQgSU9NTVVzIGluIHRoZSBQQ0ggd291bGQgaGF2ZSB0aGUNCj4gc2FtZQ0KPiA+IHBy
b3BlcnRpZXMgYXMgdGhvc2UgaW4gdGhlIHVuY29yZS4NCj4gPg0KPiA+IEdpdmVuIGhvdyBleHBl
bnNpdmUgc3luY19jYWNoZSgpIGlzLCB3ZSBjYW5ub3QgYWZmb3JkIHRvIGJlIHVzaW5nIGl0IGZv
cg0KPiA+IGNvaGVyZW50IElPTU1VcyBpbiBhIG1peGVkIHN5c3RlbS4NCj4gPg0KPiA+IFRoaXMg
d2FudHMgdG8gYmUgYSBib29sZWFuIGluIGFyY2hfaW9tbXUuDQo+IA0KPiBUaGF0J3MgYSB2YWxp
ZCBjb25zaWRlcmF0aW9uLCBidXQgbWF5IG5vdCBiZSBhcyBlYXN5IGFzIGl0IG1heSBzZWVtIG9u
DQo+IHRoZSBzdXJmYWNlLiBDZXJ0YWlubHkgbm90IHNvbWV0aGluZyBJIGNvdWxkIHByb21pc2Ug
dG8gZmluZCB0aW1lIGZvcg0KPiBzb29uLiBBbmQgZGVmaW5pdGVseSBzZXBhcmF0ZSBmcm9tIHRo
ZSBzcGVjaWZpYyBjaGFuZ2UgaGVyZS4NCg0KSSdtIGZpbmUgd2l0aCB0aGlzIHBhdGNoIGlmIHlv
dSBwcmVmZXIgdG8gYSBzdGFnaW5nIGFwcHJvYWNoIHRvIGltcHJvdmUgaXQuDQpCeSBhbnkgbWVh
bnMgdGhpcyBwYXRjaCBkb2Vzbid0IG1ha2UgdGhpbmdzIHdvcnNlLg0KDQo+IA0KPiA+PiAtLS0N
Cj4gPj4gUGxhY2luZyB0aGUgZnVuY3Rpb24gbmV4dCB0byBmbHVzaF9hcmVhX2xvY2FsKCkgZXhw
b3NlcyBhIGN1cmlvdXMNCj4gPj4gYXN5bW1ldHJ5IGJldHdlZW4gdGhlIFNGRU5DRSBwbGFjZW1l
bnRzOiBzeW5jX2NhY2hlKCkgaGFzIGl0IGFmdGVyIHRoZQ0KPiA+PiBmbHVzaCwgd2hpbGUgZmx1
c2hfYXJlYV9sb2NhbCgpIGhhcyBpdCBiZWZvcmUgaXQuIEkgdGhpbmsgdGhlIGxhdHRlciBvbmUN
Cj4gPj4gaXMgbWlzcGxhY2VkLg0KPiA+DQo+ID4gV293IHRoaXMgaXMgYSBtZXNzLg0KPiA+DQo+
ID4gRmlyc3QgYW5kIGZvcmVtb3N0LCBBTUQgc3RhdGUgdGhhdCBvbiBwcmUtQ0xGTFVTSE9QVCBw
YXJ0cywgQ0xGTFVTSCBpcw0KPiA+IHVub3JkZXJlZCB3aXRoIH5hbnl0aGluZyAoaW5jbHVkaW5n
IFNGRU5DRSksIGFuZCBuZWVkIGJvdW5kaW5nIHdpdGgNCj4gPiBNRkVOQ0Ugb24gYm90aCBzaWRl
cy7CoCBXZSBkZWZpbml0ZWx5IGFyZW4ndCBkb2luZyB0aGlzIGNvcnJlY3RseSByaWdodCBub3cu
DQo+ID4NCj4gPg0KPiA+IEFNRCBleHBsaWNpdGx5IHN0YXRlcyB0aGF0IFNGRU5DRSBkcmFpbnMg
dGhlIHN0b3JlIGFuZCBXQyBidWZmZXJzIChpLmUuDQo+ID4gbWFrZSBzdHVmZiBpbnN0YW50YW5l
b3VzbHkgZ2xvYmFsbHkgdmlzaWJsZSkuwqAgSW50ZWwgZG9lcyBub3QsIGFuZA0KPiA+IG1lcmVs
eSBndWFyYW50ZWVzIG9yZGVyaW5nLg0KPiA+DQo+ID4gQSBsZWFkaW5nIFNGRU5DRSB3b3VsZCBv
bmx5IG1ha2Ugc2Vuc2UgaWYgdGhlcmUgd2VyZSBXQyBjb25jZXJucywgYnV0DQo+ID4gYm90aCBt
YW51YWxzIHNheSB0aGF0IHRoZSBtZW1vcnkgdHlwZSBkb2Vzbid0IG1hdHRlciwgc28gSSBjYW4n
dCBzZWUgYQ0KPiA+IGp1c3RpZmljYXRpb24gZm9yIGl0Lg0KPiA+DQo+ID4gV2hhdCBkb2VzIG1h
dHRlciwgZnJvbSB0aGUgSU9NTVUncyBwb2ludCBvZiB2aWV3LCBpcyB0aGF0IHRoZSBsaW5lIGhh
cw0KPiA+IGJlZW4gd3JpdHRlbiBiYWNrIChvciBldmljdGVkIG9uIHByZS1DTFdCIHBhcnRzKSBi
ZWZvcmUgdGhlIElPVExCDQo+ID4gaW52YWxpZGF0aW9uIG9jY3Vycy7CoCBUaGUgaW52YWxpZGF0
aW9uIHdpbGwgYmUgYSB3cml0ZSB0byBhIGRpZmZlcmVudA0KPiA+IGFkZHJlc3MsIHdoaWNoIGlz
IHdoeSB0aGUgdHJhaWxpbmcgU0ZFTkNFIGlzIG5lY2Vzc2FyeSwgYXMgQ0xGTFVTSE9QVA0KPiA+
IGlzbid0IG9yZGVyZWQgd2l0aCByZXNwZWN0IHRvIHVuYWxpYXNpbmcgd3JpdGVzLg0KPiANCj4g
SU9XIGZvciB0aGUgcHVycG9zZXMgb2YgdGhpcyBjaGFuZ2UgYWxsIGlzIGNvcnJlY3QsIGFuZCBl
dmVyeXRoaW5nIGVsc2UNCj4gd2lsbCByZXF1aXJlIHRha2luZyBjYXJlIG9mIHNlcGFyYXRlbHku
DQo+IA0KDQpTYW1lIGZvciB0aGlzIHBhcnQuIGJ0dyBMaW51eCBkb2VzIG1mZW5jZSBib3RoIGJl
Zm9yZSBhbmQgYWZ0ZXIgY2xmbHVzaC4NCg0KVGhhbmtzDQpLZXZpbg0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 07:28:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 07:28:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251239.432543 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0f0L-0004X4-D7; Fri, 24 Dec 2021 07:28:41 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251239.432543; Fri, 24 Dec 2021 07:28:41 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0f0L-0004Wx-9e; Fri, 24 Dec 2021 07:28:41 +0000
Received: by outflank-mailman (input) for mailman id 251239;
 Fri, 24 Dec 2021 07:28:40 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P6v+=RJ=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1n0f0K-0004Wr-Ey
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 07:28:40 +0000
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 1b78d4e7-648b-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 08:28:38 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Dec 2021 23:28:36 -0800
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
 by FMSMGA003.fm.intel.com with ESMTP; 23 Dec 2021 23:28:35 -0800
Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by
 ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:28:35 -0800
Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by
 ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:28:34 -0800
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 23:28:34 -0800
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by
 edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 23 Dec 2021 23:28:34 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 07:28:33 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04%2]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 07:28:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 1b78d4e7-648b-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1640330918; x=1671866918;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=+WIr3QNJxf/g4KZCWpJm34viTRnT1zlWpXoERz4strE=;
  b=OyCH3kFCcIPMLIna6sqKkVCVgcla8a9boTr4XPmFKcGAEWgYqfOWVBZs
   REZH+3G1N4Tse/pjGGXJDbCSW/2Hh3FMg9MP5aceIokSNY9aAxLNmQ4Al
   TRtSWixjWto84Zx3A8MV6kSzZ7uWcqp1fmfaMxUkKIk8KOwVgXB9cAwgg
   vBLCbOioNoNThi7o+C9Zq2OrJnFMAvx6gXtkx1V93/KAza5Slp3aFfqKE
   ozN0wiwiFOyJpAfDMloME+vsAwuJYIU0j+vwyBY/IXK68gj1agL4XsDj/
   rEwVKKcr3svB0JnykTTyqcF9xo3HRuvmJQMBfUsdLKCvgQ+Vv+wpZdPTz
   g==;
X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="240897693"
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="240897693"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="607989550"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=fk4RP9VRftZ7Elo7jn+uUHV8jgaRnkZpmYD9CP28RiR+7JltN9Lv7wd6ANl5Doq7HKI8CJscIuZnO4QEyV4dY0gkxDBhXcVmhqNLMP4PNljBB3aXRf1Wu1/zXFpuerUWJ+T41OUdhsj7S0c7OVcKWTTvareN42F0BidpBdJI61d0M5HeD5UuoX1xd2RggMQZ02gB5a3mrVWXdL8muiXZraBx/MkM3SZROm5PHOlZd5XIOD+jXbNwuq/8xSkuzamuGDHIzhFnlWXOgu4HJSlaWI1h9h07gpGm5e1cuksjbwEjAU7TFgB6t+uyIj/70dZbKleBCXUXY/QioMfqx1pcSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+WIr3QNJxf/g4KZCWpJm34viTRnT1zlWpXoERz4strE=;
 b=mgzseInYCKq2mrO3b+eAzdMB1owhdh6pIgLAL6yjAmF2EXs4pcvHdQrXLF3NoCWPAM5mh0yvJ5RZZprj/6pgshQ1IV6G40Fv4FcH+i1gxD2od/CIxbIQ9F6mI7MEng7jLFCelbwgD/Zlv/1+fQjR651evWm2Fv0mgGgrrobBxihzVHgBGmxQhy9Lq3vwOo6VI6SX1k3VBRxcCevCL9wP8JlFPLhZrIviKfho1uBpYpG62SE32CCOZBWcpRSRXr2lzClfzqijIf6tjoyTr/VUQCyOy/GxoL3hbnMKRxsFAeAsFG11dmgfRzm1kTmUq7mhomHv0ylGSc7J1OPjjJLXWw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, Andrew Cooper <amc96@srcf.net>
CC: Paul Durrant <paul@xen.org>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH 3/4] VT-d: replace flush_all_cache()
Thread-Topic: [PATCH 3/4] VT-d: replace flush_all_cache()
Thread-Index: AQHX5petNZzmre0QvUm2Tee8zq2soawdmhQAgAFLOQCAInz2cA==
Date: Fri, 24 Dec 2021 07:28:33 +0000
Message-ID: <BN9PR11MB527697C864CE7526EA16AA6C8C7F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <5d72c629-fabf-3d40-aa19-d177826fdde5@suse.com>
 <8a8dd03a-5447-bc45-1554-50fb5b6c075c@suse.com>
 <a6489b9f-6f93-94d9-549f-07fc761a4830@srcf.net>
 <8a9bf3aa-5f91-a81a-813d-f50ad01ef3de@suse.com>
In-Reply-To: <8a9bf3aa-5f91-a81a-813d-f50ad01ef3de@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 6376849a-a519-4c45-b909-08d9c6aefddb
x-ms-traffictypediagnostic: BN9PR11MB5483:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN9PR11MB548345942E1599BF805F77368C7F9@BN9PR11MB5483.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: y8a5rEC/Z6qYXLiHk1IJf7QxyA2MUR778kUbqO6sjqy3oc0PqSRHGwDPZ++E0rb/7Nr0rUrQifIHZtnhOO4+8ag8tLxv+9YZU2iNOk8hyiTXPDGwBdH/c1vZ2cLFan9xHZAbeV0yoko0GRC29Fxvyy5PhPtZ0d721+ae7NqTJS7lXGm5Hu47fIYXXpDggL415WDLUYKPOUul8EaOF3MKxS1eYPKMAWSLoYRtrscjU8YH8qRzf2IZN3sAJtMI8XojX3pogPFadIY/OJYsIf/Jt0j5L7tl8h3xkuvmfn15FOIxhpxiVc3ZkmOP9Cbpysn/ijyzWUdCImvvPoZKGxoNyU1YcsnQpCvqiUC/hB7WXzbNnCCfvqegv4Sc+SQCJg9NMtRww2ExgQLWJJoJ4IeC8SR1Y2rs7CW2chytEkjHBYDD9CZZLdBj6VL7KhFsG7/U5ewO+RrozyJOIPeMdMWp4XgDpai8g3SYOuhsZtFNqV6jt2f83/RfpzWhqfrPRd3gA+NyfRyhCf6ofrRgFU7Hyt8v7cHyndJ9M8Xsucw04Qt6/r5XtSz6BQD4OcVR23+WebXH0PH/M1RtnhC6ENJhl/FFHvhGsar8NOZw99EUahkm6Dc+2CqvjK2FrM56dXFYOlOLOsC/VAclk4rOmMNtk2pFkpE9GGmVq7KCx4dIoB9/648vzlsT3NbHVjOKULTZ44e+osBVmV/7l7vZVuXxoQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(38070700005)(66946007)(7696005)(316002)(54906003)(38100700002)(122000001)(2906002)(5660300002)(6506007)(508600001)(110136005)(53546011)(4326008)(82960400001)(71200400001)(86362001)(52536014)(66556008)(8936002)(66446008)(76116006)(8676002)(66476007)(9686003)(33656002)(55016003)(26005)(64756008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZmNaRFRoY2s4aGhiLzI0OU4rckhZMDZ6ZU95YWY0NGwxWmNETGt6TGJ3NXhj?=
 =?utf-8?B?RXcxeDFlREhQcnZHQ09naGlReUxVTEFWU0J4OCtjbGpSc2ZFV1R6aExnSGg2?=
 =?utf-8?B?MzFHeGF3RTB6K3drNUlVM1U2YklLN3cxcnZSMHJNVzdRSVpoa2N4NmlnWjBu?=
 =?utf-8?B?UDZta2diMFJKV0JUWEplV1Q5RlM3d2JGMFdWOXpDTS9EQk02WTdCWmtTcHZ3?=
 =?utf-8?B?NHZXT0o2YjFwRXEycVAySzh0eEtoRTJyaVJudXFHcVl6ZkRad09TQjdNN2FJ?=
 =?utf-8?B?WmdsMFhEbDIzeUJnU2g1RFIzUWc3Q0lCWEgybG80bm5NY3JXZFFnQzhEeVV4?=
 =?utf-8?B?d3VqaXQ3eE5KZkwzenE4SzJLUU1JcCs4S1A0ZUJqNU8xMkhNVUdBZWNkVGVa?=
 =?utf-8?B?Um1kT0hpcVVkZTZGbXdCZ2pWWi82eW1xelVVSm1DWlZ4SVZJT1dHQ2VIUHU1?=
 =?utf-8?B?cVRaSFJwY05uNGZoWGdHUDBHbDBTTVFGM3VvMWlJZjNtK3hGK01tWTQrTlcv?=
 =?utf-8?B?U0R0YS9sUlRkMkx4Vi9oRzQxRWMxRi9pQTV4c2FWbGdUcmd4RTZwK05EcXNx?=
 =?utf-8?B?OG04aGhDU2tVUXZ1ck05ZkxRMG1KUkFjWFBPaTM5SlVQUzZBYk1mQytrMDE4?=
 =?utf-8?B?WGttMGhYckpoMDVzU3ZsWVhseFNqNm8zUVhyNTNTVzh6b0pPeFhoQjE0OVRs?=
 =?utf-8?B?eWFuMnpRb1hoeUVyeTd0SE90V0dPRmRXb09DZUpUZXdtZWVRZytINUNQQnYw?=
 =?utf-8?B?N3NXSTllYmNKck5pR1B5R2hNaXlCT2FWNlNKSGZ2YUxZZXRweVJUa0ZuODhn?=
 =?utf-8?B?cDBlenpZNlJFZzdNOElKNEpmZ09VUkZXK2pYdmFSM3RVMXNqNzhKazZhOEx1?=
 =?utf-8?B?NXFKZHNZeHdyZnZSZGFMQ1lDM0YrTXVlaE9ZSnRrb25IeWRBQk5rcHlVK3A3?=
 =?utf-8?B?QThvQUo4L2g5MWVMeXFEUWlBNkY5R0dHeWxnek9RQjFFTzlFRzZ6WDZORW5X?=
 =?utf-8?B?dEFaWWNNRmI3dmxWU08rU1pxdkVHalMwRVloSHozY0VPenVIdG92SUhDMDA3?=
 =?utf-8?B?cjJtcUVUbGtLSllkb3MyOXhnY0lmZ2dTeXV4OEg3K1RVNXo0VTNORlM0WFVp?=
 =?utf-8?B?VHZ3RzhGQXBIb3gyNmpzTDcxYlVSU21ENzh0K1gwNXVWcVVLenZKMkZiM24w?=
 =?utf-8?B?N0dJSFpmaGpUU0cvTVFoQmx0ekFIZUdDUjk2TmozTzR6dDc3NDE1V1VwRk9z?=
 =?utf-8?B?ZU9pQ2RpMHRIQTNvS0JaNUhzRUswUlUrdlRPYVI2VjY2bk1zK3FqQVlITWpm?=
 =?utf-8?B?K2dPVWxCcVM0N3VEM3MyaHN1bkJOZEtCTUpQWHY5c3lLQVhyTVFVVnQzNDlv?=
 =?utf-8?B?REV0bE83NEZjdTR5Rkt0QTlSdEQzTEJhcEd6UTdJTWV0WWV3WXVvaERYUzJS?=
 =?utf-8?B?cG5NTm40Y0pYd0JHV0tDSkdpR1VMVkF4YjZ6V3M5aFpxajc5bjB6allGWmt3?=
 =?utf-8?B?amQzb2pOYi9Yb2dtemFkWTJmdm1nV09UQmU0MTJjYnY0YWt3MUtlR0d2NGtJ?=
 =?utf-8?B?UjFMaWprYkRTcE5aVVZGbnJPV2xLSmlSb2hydGI0clhySzlaQ053UVpodEtY?=
 =?utf-8?B?aDdCRGZ3Z1M0RHZnMWgyTDVkbHMvR1Z3Q1k0OE85QWJTdXpDM2d5bDRFMkxz?=
 =?utf-8?B?UytxeVdCMmlKYU1rZHJ1ZlkrTXRqQmZYOEpSZVRhUGJ4YTM1Tld0Qm9rVjhr?=
 =?utf-8?B?SnNWUDZVbDBiL1lDUnBmSHFvV1poelRxcnY5RUxCd2o2SWFsUmhoWkx3ZTdl?=
 =?utf-8?B?R2x0cnZISDljV0d2ZE5zeUJDZGpXOFFIVUhYY2hrakFNVnI1OUlvZUZSSHJW?=
 =?utf-8?B?NjZLT3Bmd0M4VFpjVGpZRVQ1WVJwblZkdk45VzhWTUE0Vkc5VzNycC9rNW1v?=
 =?utf-8?B?ZmI4NFA3bm1Ld1FYWnRCQ0IzcFc2VFZUV1g1QjdGR21UWkYwdUhVZXNDRkVp?=
 =?utf-8?B?VmhjYjk4S3Z5SSs5cUk0SHZSWDBhSUZmOW9EekthUldQV09MbGtWa2RWamFq?=
 =?utf-8?B?T1RscytuRTcxUXBBVEQ0OWw4UVF4VTZZUWZ5Tngya1lQNlhrb0dqNy82M3NG?=
 =?utf-8?B?OGIvRmd6WVkvU3FDNUlJZU54QTlyaldkcXNBd2NxWXVDZTVwdSt0b2t3OXdk?=
 =?utf-8?Q?RbyeTOCswAhE1epnpjI80eg=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6376849a-a519-4c45-b909-08d9c6aefddb
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 07:28:33.4135
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5ry1wnbyM/F0u6o+eZAbAySyNe7jg4VwfLwQwTAOIC9p3P/21jcEmQ56tg6PjYnio25lUbe3RK2AVS5Wz28iwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5483
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBEZWNlbWJlciAyLCAyMDIxIDQ6NDggUE0NCj4gDQo+IE9uIDAxLjEyLjIwMjEgMTQ6MDIsIEFu
ZHJldyBDb29wZXIgd3JvdGU6DQo+ID4gT24gMDEvMTIvMjAyMSAwOTo0MSwgSmFuIEJldWxpY2gg
d3JvdGU6DQo+ID4+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+
ID4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jDQo+ID4+IEBAIC01
OTEsNyArNTkxLDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgaW9tbXVfZmx1c2hfYWxsKA0K
PiA+PiAgICAgIGJvb2xfdCBmbHVzaF9kZXZfaW90bGI7DQo+ID4+ICAgICAgaW50IHJjID0gMDsN
Cj4gPj4NCj4gPj4gLSAgICBmbHVzaF9hbGxfY2FjaGUoKTsNCj4gPj4gKyAgICBmbHVzaF9sb2Nh
bChGTFVTSF9DQUNIRSk7DQo+ID4NCj4gPiBXaGlsZSBJIGFncmVlIHRoYXQgdGhlIGNvbnZlcnNp
b24gaXMgYW4gaW1wcm92ZW1lbnQsIHRoZSBsb2dpYyBzdGlsbA0KPiA+IGxvb2tzIHRvdGFsbHkg
Ym9ndXMuDQo+ID4NCj4gPiBJIGNhbiBiZWxpZXZlIHRoYXQgaXQgbWlnaHQgaGF2ZSBiZWVuIGEg
c3RvcGdhcCB0byBmaXggcHJvYmxlbXMgYmVmb3JlDQo+ID4gd2UgaWRlbnRpZmllZCB0aGUgbmVl
ZCBmb3Igc3luY19jYWNoZSgpIGZvciBub24tY29oZXJlbnQgSU9NTVVzLCBidXQNCj4gPiB0aGVy
ZSdzIG5vIG5lZWQgSSBjYW4gc3BvdCBmb3IgYW55IFdCSU5WRHMgb24gYW55IG9mIHRoZXNlIHBh
dGhzLg0KPiA+DQo+ID4gSSdtIGZhaXJseSBzdXJlIHRoaXMgc2hvdWxkIGp1c3QgYmUgZHJvcHBl
ZCwgYW5kIFhlbiB3aWxsIGdldCBmYXN0ZXIgYXMNCj4gPiBhIHJlc3VsdC4NCj4gDQo+IEtldmlu
LCB0aG91Z2h0cz8gSSBoYXZlIHRvIGFkbWl0IEknbSBoZXNpdGFudCB0byByZW1vdmUgc3VjaCBj
b2RlLCB3aGVuDQo+IHRoZXJlJ3Mgbm8gY2xlYXIgaW5kaWNhdGlvbiB3aHkgaXQncyB0aGVyZS4g
SSdtIGFsc28gbm90IHN1cmUgaG93IG11Y2gNCj4gb2YgYSB3aW4gdGhlIGRyb3BwaW5nIHdvdWxk
IGJlLCBjb25zaWRlcmluZyB0aGUgcGxhY2VzIHdoZXJlIHRoaXMNCj4gZnVuY3Rpb24gZ2V0cyBj
YWxsZWQgZnJvbS4NCj4gDQoNCm1lIHRvby4gQ291bGQgQW5kcmV3IGVsYWJvcmF0ZSBmdXJ0aGVy
IG9uICJmYWlybHkgc3VyZSIgcGFydD8NCg0KVGhhbmtzDQpLZXZpbg0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 07:30:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 07:30:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251243.432554 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0f20-000681-QE; Fri, 24 Dec 2021 07:30:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251243.432554; Fri, 24 Dec 2021 07:30:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0f20-00067u-M1; Fri, 24 Dec 2021 07:30:24 +0000
Received: by outflank-mailman (input) for mailman id 251243;
 Fri, 24 Dec 2021 07:30:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P6v+=RJ=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1n0f1y-00067m-Pz
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 07:30:22 +0000
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 580b6d26-648b-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 08:30:20 +0100 (CET)
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Dec 2021 23:30:17 -0800
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
 by orsmga008.jf.intel.com with ESMTP; 23 Dec 2021 23:30:17 -0800
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
 fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:30:17 -0800
Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by
 fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:30:16 -0800
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 23:30:16 -0800
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by
 edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 23 Dec 2021 23:30:16 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN9PR11MB5355.namprd11.prod.outlook.com (2603:10b6:408:11c::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 07:30:15 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04%2]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 07:30:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 580b6d26-648b-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1640331020; x=1671867020;
  h=from:to:subject:date:message-id:references:in-reply-to:
   content-transfer-encoding:mime-version;
  bh=+aXyCi8R+CXoH51lMPO3f2w+6caOk5sKsX0Q/5eYStc=;
  b=Hhcv/1uIS2JJIEWHkzyY2pUvn9yX0id1ThdeRFC6Vl3R4vWSymZubMnI
   apQ1L2XL9fzVKM/l30hD1ZhoxG/llgQ80LfMsAv8V2EFL1WtrbOeYxy9C
   hRGrAk2XUrgWuU8fzoyntQV94iDs1SxMfq5JFwNDPGqCOQj4QH0q/t/IQ
   nx1vnQDaAUSW2fWgBgzkdGkwuaUsoKXSW1wPjog+a/CErxFN57rzVxNCS
   /QZVaU/tmVnHBWpJBUSEqsAfDQuA/ZHdtT61NzNnFyftC9sPs2n05SSn6
   HvU2yVKaZhTkodXPcMcDgWYR8DakwhcgoQlb0HhKR9lYs3AKSwmqjZ4ZG
   A==;
X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="301705750"
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="301705750"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="522362291"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j7yJImkjVNZ6VH7g1P9t5N7bwe6imuwHa6Kll4j4ZEvaFhwO2OArZ9o2rul3Y0kv/HUoBIzMvS4ADc0jPLw+qRC37FEQOLqCw93bLZIc+sDYx51bKZWgmntcrW/BGnzWDztpNXv5hZHxxfjjvRzC908BmnZmEFbokR48Rxv3G3R+PNI12jWlhkXTgqXaHZWALWDTOd0OhZVCKiEw6GsX91fUUa75pKsgSPX7lycvvLKCzJ9NWEKkh72wUo7cvKWpvtMhZ/I+cyOUDQq7MzMdsb8V2ZIvAKsjhsijwmvIG4Lo4hRwcPZWaR5XnRPwq6fakqr5U+YdNMMdL1GqPaHKsQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=+aXyCi8R+CXoH51lMPO3f2w+6caOk5sKsX0Q/5eYStc=;
 b=TVaYsKtsqMp3mYCBFsbuAkWbipO8ekHdiJ5yl72UZ2Xchak2wVZn2+wcN7pOCZFK55sCKv3b1oLx264b1gxluzcMHXizucaebp+SHRCA3SzOLlr6gegdljT267JAIHY1rOLTiQLmuk7T9k3KcJ4ayN1DhXcqTRm4D5GNfQ7aJRMCFoPuwHGg6y1uJI4sGv/FS7L+Xbq92/0L5cgUvia9fEMwMbgpMTltkMjQdUHb62Pm96JiEV4qXgdkuqTuTKF3qNNskwLfFfFFOtEhQsfp6xDMl2O8vI2yGtFkrMSkWkSVXp3vfOXaFEevvo+NdQkZsJQiyMHE5ZNF6orKHcKmRA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v2] VT-d: avoid allocating domid_{bit,}map[] when possible
Thread-Topic: [PATCH v2] VT-d: avoid allocating domid_{bit,}map[] when
 possible
Thread-Index: AQHX6DJRnNj7O40AdkiiHonQeffDF6xBX7bQ
Date: Fri, 24 Dec 2021 07:30:14 +0000
Message-ID: <BN9PR11MB5276613FCCBD6C5ACF444EE38C7F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <7fadbc39-4760-1be8-fdda-455a1a321eff@suse.com>
In-Reply-To: <7fadbc39-4760-1be8-fdda-455a1a321eff@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ddf21494-359b-40fa-96e0-08d9c6af3a62
x-ms-traffictypediagnostic: BN9PR11MB5355:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN9PR11MB535538472398595348069B768C7F9@BN9PR11MB5355.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rqwYRHK2m0rab4XBeGfJsy7KRpd6v/HjVUyheOOOidRExcQzfZ98vZi5q5TuauQ7aXkmC+0v1QiMO0yayg+44s89RczydbvTPF7EDpWmCQy6OqBYxfqEUkmupdeV/ZUV5uRK21QyGd7V7ly37m/NpIMqfd9aYkiQDRkDZx3bsOZ6zzbUoizv/nn6+XUmnqBocYIYg76wbOfPEi04augrAgwVFJpgVlfoBS6dxGBMfPs2Mx+wS1vJgzvLUDq9cALyV7gBRH7aaFJOQBWIsmYKZSa7rWTiqiJGwKohOor1qFW3/eqNgDiew27v4RUDn2USt0CL1KKnkvm7VlXwASIf2eFxk/ww/zg3WMziJyDrZPBREEghbfw34He3mLp/qu1NDtP8R5GhM02XcGq1vTmkZoiRvRIfISR7asbZH9VcyeZ7eGPskf8tXNH8tQkmtzEzLb+2qqPth0fhhuLqSnZ9nwN1rhlNXAmElhnKT888kaIolc9+H0+4iD1r+6d6HFixaTWqJWlnHs6dciCfKQbFe+y23Ok/f7PzsxTajaQzXKT5FEM88QeEvi7sWAb6UBNunmraUA45Mnuef/UDJfHaKJIk2SJLnqZK7jxYkk6KzIVELESdiFPw/sKxKc9GRm40Rxz+F8r1z8sSN96zr2mBZWeL7KBRn5jf8aWJMR9unx8j5wUWQtFxwbJ4OUeae6Pg145UFGV6A1ZLFgeqbEi6Nw==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7696005)(82960400001)(186003)(8676002)(66946007)(8936002)(9686003)(6506007)(26005)(38100700002)(33656002)(2906002)(66476007)(83380400001)(76116006)(64756008)(52536014)(110136005)(71200400001)(66446008)(5660300002)(316002)(508600001)(122000001)(38070700005)(86362001)(55016003)(66556008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UTQ3R0R6UityeENZVHVCcTFhcmVFVi9DdUFIS0dmTXUxTFhZQnYwd3NRQWlY?=
 =?utf-8?B?WG5xMTlFcnUrOC83ejBncGhGWXNrcndMcFYrRTRFOXphWFNLcGVkRzlkNlhI?=
 =?utf-8?B?ZmZmdEFjaVQ4amtPZWhveGpqTHVVVFRLdFRPYmRURlZMN2M2aXdGcWRuQ21p?=
 =?utf-8?B?QWRNUFFRREp4My9GVFc5ZXFHYkJJRmNOeFJZS3JVdXVFL0xuNVAycEVFZElk?=
 =?utf-8?B?YVFTM1ZnNHhMSG4wUmdKOVRIYnJIblcvT2N3Z3FHaGF2QlNTM1l3NlhMd0xF?=
 =?utf-8?B?SmxnM3czd2g4WkVKMDBySDc0MUdIaDAzeXRiOFFVanlQY1h4Lzk5VmJ2VzZC?=
 =?utf-8?B?cnFUMzlOU3Rtbm1oRllxL1Y0ZldBcDd1QnVMdVlMRUJDZUZFMC9BRzNtWGh1?=
 =?utf-8?B?T0FLVmlDd0dUOVhWRElnYU9sa0N6b1QwM29FWWZCNUxnSVZrVzNwSno4amY1?=
 =?utf-8?B?MUpiSGVBNkMzMVAwSElxVU1tZzNjQm55MWVrbU5TSnhrRk1lbEYrdk55MENG?=
 =?utf-8?B?M0lMcllNaDk2SW1GMTM1SmNKdGNrRFBsVEZzTldsRUt3T0NFMHUyQ2JoMnYw?=
 =?utf-8?B?dGs3b3NYWVdZVG4yTW9RSmFjNkpBY1VQWnRQRnNFa2lXeDdmK0cvQUVtQi96?=
 =?utf-8?B?ZVFsMWpHOWpYMjVtZmYrRXhBZlZINHhhUEJ5VlJZQTdZRndxYTVWSUM4VjRI?=
 =?utf-8?B?eWNzdm05aHVpc3lqY1NUTHA0QWp6d0dXRzF6bFA2NGJGaGlJZ2pTRThFbm9i?=
 =?utf-8?B?dDFJUkNaTnl3YkFyME95cjNhQnpzYlUrbTF5WmlFR3d6NGV1VHExMThINjc0?=
 =?utf-8?B?Vks3U3lNc3REck8rOThob0ZxUytDbzJhTjdMSGtyckc4a1FldlorSkFNNml5?=
 =?utf-8?B?QStsZTZuUTRWZEovKy9pMmtkUVdvOFlXZWxOekZpWHJzWXF5eVAwbzROa1lF?=
 =?utf-8?B?RFBMY1djOHFmczNFTHcyWUUzbnhmMEpQUWg5QTZaeDI4dWhiRFlDYWRHWUNE?=
 =?utf-8?B?ODdDdXBCY0k2NTdaenhmOUtYcmpxcjJqRWc1UGUyMGd3NTNqYnZOQWJZbFJP?=
 =?utf-8?B?L1IwMDRCRTBDak12ZGVsUE1IUE10UE9wZXdRdCsrZTZzTHVic2QxSDl4eXJS?=
 =?utf-8?B?T09rWjJaWEhnQXpaQWt3eFRuYzdsRXhka3Y2RzVFQ1hZWklkZys3Y3lrY1p4?=
 =?utf-8?B?SGkvZWpyeGcvZC9Qa2hLWnRzWmhOVmFVdFVpb010dGtMVVdiRVp5Y3o1YlJB?=
 =?utf-8?B?V01ZZnE4Tm1rL3l5dmxsZ1VkU1kxQVFVSXZNR0d0NTl4S3lTbkZ0MjJUajI5?=
 =?utf-8?B?Q09QR1ZoZXpFend3aTNqTllpVTg1VWkxT1dDTld5emNqeG5LL05BTkNSNUdN?=
 =?utf-8?B?TzlBY3hXaDhjUXppZGJmK0RIUjlDYS9GakpQZEY2ZTg2RzJ5dW5SbXZxejl4?=
 =?utf-8?B?aUtxVE5YT0JTZkhmcmJoU0lsQzhzazFlNUlZd0tiT1BoZzNLUzRXSnNaUVFh?=
 =?utf-8?B?TDV4Mm5UbWR1Rnh4VmxGWml4MldLMm56UU9oVm90a3FXaFFDM0ZFS2xDUjA3?=
 =?utf-8?B?R3QzdTAxMXpDZytENnR2ZnpndnpyUE1oaGtmTGozUVVLZ3hnVHlkenNxNkdv?=
 =?utf-8?B?bFhhZm82RjRFTEp6UkxDRmNtY3N1QlNNNDhRSDlwbEFVaUVIWjR2djUxVEtX?=
 =?utf-8?B?Mnl1Q1FFU1krV2orYjREa2R5TndLbWZ6RzQ2U3J3QXl6aWlnS0hZL1ZiNmtm?=
 =?utf-8?B?Z2t6NFQrZlZJZzZsbXhOZDR2M09PM0E3RGIyaitHb1M4SW5WdVNJNVUxbDFQ?=
 =?utf-8?B?ayt5NU9GRUI2S1JLeVdxWGd4bEY4bGxyblU4eDh1amRJVXlYbEUxZWJOMS9i?=
 =?utf-8?B?MWhSL3o1cmpsSG1XdkJZRWlSbElmblJvWlVQTGVBZCtWNnRlaHZJckJOUUJB?=
 =?utf-8?B?RzBjTjlRSXB2NlJGN0VpcjNPWU5PMFFLNFpvajZsS1NiSGxYanBoUi9Hb3Nx?=
 =?utf-8?B?cFErQzAzN0I4NkhlamFpc1AxNVl5d3A3UWtqTXQrazR1RExnREVGU01BNm4x?=
 =?utf-8?B?VCtYQUJhUVVsSGdoZTQwa3RHaUdWY2hFdDMwOHVIODhhSDI5RDE2am15M29S?=
 =?utf-8?B?eEt4T2hWamNCSitLbFFqbEVMNzRtUjNpWjBNenJVQVhTK01ROFFnSm9lb05U?=
 =?utf-8?Q?35TNEFO6cbHrADnJ6cDLjkA=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddf21494-359b-40fa-96e0-08d9c6af3a62
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 07:30:14.9099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j+RtSEPn5YA/me8xB/NaEVuYmw6oqeBCkBYi5o1+SQeiCdQmP5VVwrB7V8pvxDUVQzaDylhfN3XfwCZo4sUKHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5355
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IEZyaWRheSwg
RGVjZW1iZXIgMywgMjAyMSA2OjQxIFBNDQo+IA0KPiBXaGVuIGFuIElPTU1VIGltcGxlbWVudHMg
dGhlIGZ1bGwgMTYgYml0cyB3b3J0aCBvZiBESUQgaW4gY29udGV4dA0KPiBlbnRyaWVzLCB0aGVy
ZSdzIG5vIHBvaW50IGdvaW5nIHRocm91Z2ggYSBtZW1vcnkgYmFzZSB0cmFuc2xhdGlvbiB0YWJs
ZS4NCj4gRm9yIElPTU1VcyBub3QgdXNpbmcgQ2FjaGluZyBNb2RlIHdlIGNhbiBzaW1wbHkgdXNl
IHRoZSBkb21haW4gSURzDQo+IHZlcmJhdGltLCB3aGlsZSBmb3IgQ2FjaGluZyBNb2RlIHdlIG5l
ZWQgdG8gYXZvaWQgRElEIDAuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJl
dWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFuIDxrZXZpbi50aWFuQGlu
dGVsLmNvbT4NCg0KPiAtLS0NCj4gRm9yIHRoZSBjYXNlIHdoZXJlIHRoZSBtZW1vcnkgdGFibGVz
IGFyZSBuZWVkZWQsIHh2emFsbG9jX2FycmF5KCkgd291bGQNCj4gb2YgY291cnNlIGJlIGFuIG9w
dGlvbiB0byB1c2UgaGVyZSBhcyB3ZWxsLCBkZXNwaXRlIHRoaXMgYmVpbmcgYm9vdCB0aW1lDQo+
IGFsbG9jYXRpb25zLiBZZXQgdGhlIGludHJvZHVjdGlvbiBvZiB4dm1hbGxvYygpIGV0IGFsIGNv
bnRpbnVlcyB0byBiZQ0KPiBzdHVjayAuLi4NCj4gLS0tDQo+IHYyOiBVc2UgZGlmZmVyZW50IEJV
SUxEX0JVR19PTigpLg0KPiANCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lv
bW11LmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMNCj4gQEAg
LTYyLDExICs2MiwzMiBAQCBzdGF0aWMgc3RydWN0IHRhc2tsZXQgdnRkX2ZhdWx0X3Rhc2tsZXQ7
DQo+ICBzdGF0aWMgaW50IHNldHVwX2h3ZG9tX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9k
ZXYgKik7DQo+ICBzdGF0aWMgdm9pZCBzZXR1cF9od2RvbV9ybXJyKHN0cnVjdCBkb21haW4gKmQp
Ow0KPiANCj4gK3N0YXRpYyBib29sIGRvbWlkX21hcHBpbmcoY29uc3Qgc3RydWN0IHZ0ZF9pb21t
dSAqaW9tbXUpDQo+ICt7DQo+ICsgICAgcmV0dXJuIChjb25zdCB2b2lkICopaW9tbXUtPmRvbWlk
X2JpdG1hcCAhPSAoY29uc3Qgdm9pZCAqKWlvbW11LQ0KPiA+ZG9taWRfbWFwOw0KPiArfQ0KPiAr
DQo+ICtzdGF0aWMgZG9taWRfdCBjb252ZXJ0X2RvbWlkKGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUg
KmlvbW11LCBkb21pZF90DQo+IGRvbWlkKQ0KPiArew0KPiArICAgIC8qDQo+ICsgICAgICogV2hp
bGUgd2UgbmVlZCB0byBhdm9pZCBESUQgMCBmb3IgY2FjaGluZy1tb2RlIElPTU1VcywgbWFpbnRh
aW4NCj4gKyAgICAgKiB0aGUgcHJvcGVydHkgb2YgdGhlIHRyYW5zZm9ybWF0aW9uIGJlaW5nIHRo
ZSBzYW1lIGluIGVpdGhlcg0KPiArICAgICAqIGRpcmVjdGlvbi4gQnkgY2xpcHBpbmcgdG8gMTYg
Yml0cyB3ZSBlbnN1cmUgdGhhdCB0aGUgcmVzdWx0aW5nDQo+ICsgICAgICogRElEIHdpbGwgZml0
IGluIHRoZSByZXNwZWN0aXZlIGNvbnRleHQgZW50cnkgZmllbGQuDQo+ICsgICAgICovDQo+ICsg
ICAgQlVJTERfQlVHX09OKERPTUlEX01BU0sgPj0gMHhmZmZmKTsNCj4gKw0KPiArICAgIHJldHVy
biAhY2FwX2NhY2hpbmdfbW9kZShpb21tdS0+Y2FwKSA/IGRvbWlkIDogfmRvbWlkOw0KPiArfQ0K
PiArDQo+ICBzdGF0aWMgaW50IGRvbWFpbl9pb21tdV9kb21pZChjb25zdCBzdHJ1Y3QgZG9tYWlu
ICpkLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHZ0ZF9p
b21tdSAqaW9tbXUpDQo+ICB7DQo+ICAgICAgdW5zaWduZWQgaW50IG5yX2RvbSwgaTsNCj4gDQo+
ICsgICAgaWYgKCAhZG9taWRfbWFwcGluZyhpb21tdSkgKQ0KPiArICAgICAgICByZXR1cm4gY29u
dmVydF9kb21pZChpb21tdSwgZC0+ZG9tYWluX2lkKTsNCj4gKw0KPiAgICAgIG5yX2RvbSA9IGNh
cF9uZG9tcyhpb21tdS0+Y2FwKTsNCj4gICAgICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUtPmRv
bWlkX2JpdG1hcCwgbnJfZG9tKTsNCj4gICAgICB3aGlsZSAoIGkgPCBucl9kb20gKQ0KPiBAQCAt
OTEsMjYgKzExMiwzMiBAQCBzdGF0aWMgaW50IGNvbnRleHRfc2V0X2RvbWFpbl9pZChzdHJ1Y3QN
Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBkb21haW4g
KmQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgdnRkX2lvbW11
ICppb21tdSkNCj4gIHsNCj4gLSAgICB1bnNpZ25lZCBpbnQgbnJfZG9tLCBpOw0KPiArICAgIHVu
c2lnbmVkIGludCBpOw0KPiANCj4gICAgICBBU1NFUlQoc3Bpbl9pc19sb2NrZWQoJmlvbW11LT5s
b2NrKSk7DQo+IA0KPiAtICAgIG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsNCj4gLSAg
ICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsNCj4gLSAg
ICB3aGlsZSAoIGkgPCBucl9kb20gJiYgaW9tbXUtPmRvbWlkX21hcFtpXSAhPSBkLT5kb21haW5f
aWQgKQ0KPiAtICAgICAgICBpID0gZmluZF9uZXh0X2JpdChpb21tdS0+ZG9taWRfYml0bWFwLCBu
cl9kb20sIGkgKyAxKTsNCj4gLQ0KPiAtICAgIGlmICggaSA+PSBucl9kb20gKQ0KPiArICAgIGlm
ICggZG9taWRfbWFwcGluZyhpb21tdSkgKQ0KPiAgICAgIHsNCj4gLSAgICAgICAgaSA9IGZpbmRf
Zmlyc3RfemVyb19iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsNCj4gKyAgICAgICAg
dW5zaWduZWQgaW50IG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsNCj4gKw0KPiArICAg
ICAgICBpID0gZmluZF9maXJzdF9iaXQoaW9tbXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsNCj4g
KyAgICAgICAgd2hpbGUgKCBpIDwgbnJfZG9tICYmIGlvbW11LT5kb21pZF9tYXBbaV0gIT0gZC0+
ZG9tYWluX2lkICkNCj4gKyAgICAgICAgICAgIGkgPSBmaW5kX25leHRfYml0KGlvbW11LT5kb21p
ZF9iaXRtYXAsIG5yX2RvbSwgaSArIDEpOw0KPiArDQo+ICAgICAgICAgIGlmICggaSA+PSBucl9k
b20gKQ0KPiAgICAgICAgICB7DQo+IC0gICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIgVlRE
UFJFRklYLCAiSU9NTVU6IG5vIGZyZWUgZG9tYWluIGlkc1xuIik7DQo+IC0gICAgICAgICAgICBy
ZXR1cm4gLUVCVVNZOw0KPiArICAgICAgICAgICAgaSA9IGZpbmRfZmlyc3RfemVyb19iaXQoaW9t
bXUtPmRvbWlkX2JpdG1hcCwgbnJfZG9tKTsNCj4gKyAgICAgICAgICAgIGlmICggaSA+PSBucl9k
b20gKQ0KPiArICAgICAgICAgICAgew0KPiArICAgICAgICAgICAgICAgIGRwcmludGsoWEVOTE9H
X0VSUiBWVERQUkVGSVgsICJJT01NVTogbm8gZnJlZSBkb21haW4gaWRcbiIpOw0KPiArICAgICAg
ICAgICAgICAgIHJldHVybiAtRUJVU1k7DQo+ICsgICAgICAgICAgICB9DQo+ICsgICAgICAgICAg
ICBpb21tdS0+ZG9taWRfbWFwW2ldID0gZC0+ZG9tYWluX2lkOw0KPiArICAgICAgICAgICAgc2V0
X2JpdChpLCBpb21tdS0+ZG9taWRfYml0bWFwKTsNCj4gICAgICAgICAgfQ0KPiAtICAgICAgICBp
b21tdS0+ZG9taWRfbWFwW2ldID0gZC0+ZG9tYWluX2lkOw0KPiAtICAgICAgICBzZXRfYml0KGks
IGlvbW11LT5kb21pZF9iaXRtYXApOw0KPiAgICAgIH0NCj4gKyAgICBlbHNlDQo+ICsgICAgICAg
IGkgPSBjb252ZXJ0X2RvbWlkKGlvbW11LCBkLT5kb21haW5faWQpOw0KPiANCj4gICAgICBjb250
ZXh0LT5oaSB8PSAoaSAmICgoMSA8PCBESURfRklFTERfV0lEVEgpIC0gMSkpIDw8IERJRF9ISUdI
X09GRlNFVDsNCj4gICAgICByZXR1cm4gMDsNCj4gQEAgLTE0MCw3ICsxNjcsMTIgQEAgc3RhdGlj
IGludCBjb250ZXh0X2dldF9kb21haW5faWQoY29uc3Qgcw0KPiANCj4gIHN0YXRpYyB2b2lkIGNs
ZWFudXBfZG9taWRfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwgc3RydWN0IHZ0ZF9pb21tdQ0K
PiAqaW9tbXUpDQo+ICB7DQo+IC0gICAgaW50IGlvbW11X2RvbWlkID0gZG9tYWluX2lvbW11X2Rv
bWlkKGRvbWFpbiwgaW9tbXUpOw0KPiArICAgIGludCBpb21tdV9kb21pZDsNCj4gKw0KPiArICAg
IGlmICggIWRvbWlkX21hcHBpbmcoaW9tbXUpICkNCj4gKyAgICAgICAgcmV0dXJuOw0KPiArDQo+
ICsgICAgaW9tbXVfZG9taWQgPSBkb21haW5faW9tbXVfZG9taWQoZG9tYWluLCBpb21tdSk7DQo+
IA0KPiAgICAgIGlmICggaW9tbXVfZG9taWQgPj0gMCApDQo+ICAgICAgew0KPiBAQCAtMTk2LDcg
KzIyOCwxMyBAQCBzdGF0aWMgdm9pZCBjaGVja19jbGVhbnVwX2RvbWlkX21hcChzdHJ1DQo+IA0K
PiAgZG9taWRfdCBkaWRfdG9fZG9tYWluX2lkKGNvbnN0IHN0cnVjdCB2dGRfaW9tbXUgKmlvbW11
LCB1bnNpZ25lZCBpbnQNCj4gZGlkKQ0KPiAgew0KPiAtICAgIGlmICggZGlkID49IGNhcF9uZG9t
cyhpb21tdS0+Y2FwKSB8fCAhdGVzdF9iaXQoZGlkLCBpb21tdS0NCj4gPmRvbWlkX2JpdG1hcCkg
KQ0KPiArICAgIGlmICggZGlkID49IG1pbihjYXBfbmRvbXMoaW9tbXUtPmNhcCksIERPTUlEX01B
U0sgKyAxKSApDQo+ICsgICAgICAgIHJldHVybiBET01JRF9JTlZBTElEOw0KPiArDQo+ICsgICAg
aWYgKCAhZG9taWRfbWFwcGluZyhpb21tdSkgKQ0KPiArICAgICAgICByZXR1cm4gY29udmVydF9k
b21pZChpb21tdSwgZGlkKTsNCj4gKw0KPiArICAgIGlmICggIXRlc3RfYml0KGRpZCwgaW9tbXUt
PmRvbWlkX2JpdG1hcCkgKQ0KPiAgICAgICAgICByZXR1cm4gRE9NSURfSU5WQUxJRDsNCj4gDQo+
ICAgICAgcmV0dXJuIGlvbW11LT5kb21pZF9tYXBbZGlkXTsNCj4gQEAgLTEyOTcsMjQgKzEzMzUs
MzIgQEAgaW50IF9faW5pdCBpb21tdV9hbGxvYyhzdHJ1Y3QgYWNwaV9kcmhkXw0KPiAgICAgIGlm
ICggIWVjYXBfY29oZXJlbnQoaW9tbXUtPmVjYXApICkNCj4gICAgICAgICAgdnRkX29wcy5zeW5j
X2NhY2hlID0gc3luY19jYWNoZTsNCj4gDQo+IC0gICAgLyogYWxsb2NhdGUgZG9tYWluIGlkIGJp
dG1hcCAqLw0KPiAgICAgIG5yX2RvbSA9IGNhcF9uZG9tcyhpb21tdS0+Y2FwKTsNCj4gLSAgICBp
b21tdS0+ZG9taWRfYml0bWFwID0geHphbGxvY19hcnJheSh1bnNpZ25lZCBsb25nLA0KPiBCSVRT
X1RPX0xPTkdTKG5yX2RvbSkpOw0KPiAtICAgIGlmICggIWlvbW11LT5kb21pZF9iaXRtYXAgKQ0K
PiAtICAgICAgICByZXR1cm4gLUVOT01FTTsNCj4gDQo+IC0gICAgaW9tbXUtPmRvbWlkX21hcCA9
IHh6YWxsb2NfYXJyYXkoZG9taWRfdCwgbnJfZG9tKTsNCj4gLSAgICBpZiAoICFpb21tdS0+ZG9t
aWRfbWFwICkNCj4gLSAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ICsgICAgaWYgKCBucl9kb20g
PD0gRE9NSURfTUFTSyArIGNhcF9jYWNoaW5nX21vZGUoaW9tbXUtPmNhcCkgKQ0KPiArICAgIHsN
Cj4gKyAgICAgICAgLyogQWxsb2NhdGUgZG9tYWluIGlkIChiaXQpIG1hcHMuICovDQo+ICsgICAg
ICAgIGlvbW11LT5kb21pZF9iaXRtYXAgPSB4emFsbG9jX2FycmF5KHVuc2lnbmVkIGxvbmcsDQo+
ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEJJVFNfVE9fTE9O
R1MobnJfZG9tKSk7DQo+ICsgICAgICAgIGlvbW11LT5kb21pZF9tYXAgPSB4emFsbG9jX2FycmF5
KGRvbWlkX3QsIG5yX2RvbSk7DQo+ICsgICAgICAgIGlmICggIWlvbW11LT5kb21pZF9iaXRtYXAg
fHwgIWlvbW11LT5kb21pZF9tYXAgKQ0KPiArICAgICAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+
IA0KPiAtICAgIC8qDQo+IC0gICAgICogSWYgQ2FjaGluZyBtb2RlIGlzIHNldCwgdGhlbiBpbnZh
bGlkIHRyYW5zbGF0aW9ucyBhcmUgdGFnZ2VkIHdpdGgNCj4gLSAgICAgKiBkb21haW4gaWQgMC4g
SGVuY2UgcmVzZXJ2ZSBiaXQvc2xvdCAwLg0KPiAtICAgICAqLw0KPiAtICAgIGlmICggY2FwX2Nh
Y2hpbmdfbW9kZShpb21tdS0+Y2FwKSApDQo+ICsgICAgICAgIC8qDQo+ICsgICAgICAgICAqIElm
IENhY2hpbmcgbW9kZSBpcyBzZXQsIHRoZW4gaW52YWxpZCB0cmFuc2xhdGlvbnMgYXJlIHRhZ2dl
ZA0KPiArICAgICAgICAgKiB3aXRoIGRvbWFpbiBpZCAwLiBIZW5jZSByZXNlcnZlIGJpdC9zbG90
IDAuDQo+ICsgICAgICAgICAqLw0KPiArICAgICAgICBpZiAoIGNhcF9jYWNoaW5nX21vZGUoaW9t
bXUtPmNhcCkgKQ0KPiArICAgICAgICB7DQo+ICsgICAgICAgICAgICBpb21tdS0+ZG9taWRfbWFw
WzBdID0gRE9NSURfSU5WQUxJRDsNCj4gKyAgICAgICAgICAgIF9fc2V0X2JpdCgwLCBpb21tdS0+
ZG9taWRfYml0bWFwKTsNCj4gKyAgICAgICAgfQ0KPiArICAgIH0NCj4gKyAgICBlbHNlDQo+ICAg
ICAgew0KPiAtICAgICAgICBpb21tdS0+ZG9taWRfbWFwWzBdID0gRE9NSURfSU5WQUxJRDsNCj4g
LSAgICAgICAgX19zZXRfYml0KDAsIGlvbW11LT5kb21pZF9iaXRtYXApOw0KPiArICAgICAgICAv
KiBEb24ndCBsZWF2ZSBkYW5nbGluZyBOVUxMIHBvaW50ZXJzLiAqLw0KPiArICAgICAgICBpb21t
dS0+ZG9taWRfYml0bWFwID0gWkVST19CTE9DS19QVFI7DQo+ICsgICAgICAgIGlvbW11LT5kb21p
ZF9tYXAgPSBaRVJPX0JMT0NLX1BUUjsNCj4gICAgICB9DQo+IA0KPiAgICAgIHJldHVybiAwOw0K
PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaA0KPiArKysgYi94ZW4v
ZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUuaA0KPiBAQCAtODIsNyArODIsNyBAQA0KPiAg
I2RlZmluZSBjYXBfcGxtcihjKSAgICAgICAgKCgoYykgPj4gNSkgJiAxKQ0KPiAgI2RlZmluZSBj
YXBfcndiZihjKSAgICAgICAgKCgoYykgPj4gNCkgJiAxKQ0KPiAgI2RlZmluZSBjYXBfYWZsKGMp
ICAgICAgICAoKChjKSA+PiAzKSAmIDEpDQo+IC0jZGVmaW5lIGNhcF9uZG9tcyhjKSAgICAgICAg
KDEgPDwgKDQgKyAyICogKChjKSAmIDB4NykpKQ0KPiArI2RlZmluZSBjYXBfbmRvbXMoYykgICAg
ICAgICgxVSA8PCAoNCArIDIgKiAoKGMpICYgMHg3KSkpDQo+IA0KPiAgLyoNCj4gICAqIEV4dGVu
ZGVkIENhcGFiaWxpdHkgUmVnaXN0ZXINCg0K


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 07:43:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 07:43:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251249.432565 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fE7-0007w4-0w; Fri, 24 Dec 2021 07:42:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251249.432565; Fri, 24 Dec 2021 07:42:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fE6-0007vx-U8; Fri, 24 Dec 2021 07:42:54 +0000
Received: by outflank-mailman (input) for mailman id 251249;
 Fri, 24 Dec 2021 07:42:54 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P6v+=RJ=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1n0fE5-0007vr-PN
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 07:42:54 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 17885e11-648d-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 08:42:51 +0100 (CET)
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Dec 2021 23:42:48 -0800
Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85])
 by fmsmga007.fm.intel.com with ESMTP; 23 Dec 2021 23:42:48 -0800
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
 fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:42:48 -0800
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:42:47 -0800
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 23:42:47 -0800
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 23 Dec 2021 23:42:47 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN7PR11MB2609.namprd11.prod.outlook.com (2603:10b6:406:b1::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.17; Fri, 24 Dec
 2021 07:42:46 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04%2]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 07:42:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 17885e11-648d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1640331771; x=1671867771;
  h=from:to:subject:date:message-id:references:in-reply-to:
   content-transfer-encoding:mime-version;
  bh=iAHKDw9ZcvBAFKPdGUF4mVkR4H6L8g9tQhue9QZAZ7g=;
  b=jkD19uaeaer3ESIyKrUr19TVw2cxCPe4I4cfyx9/AndymH8/R6iTFydd
   R+Ue+pakxvBNp87dfnh5H1grBjgisyp+kxU56yXkxHpmUFpXQRXOZantB
   sQHgty4re6C81uBEFU6D6AbdsXHwikV99HqkfoWdTvwiMhJ/uEnUgptzT
   oRjKzsF1T2MSzHfWls3zKEyfbUhLnSVWCgofadDKRuMlX8VLwIDyJgVBO
   ufsGgt9xPB6dcYITGDF2RaCHT421e39LdEASQ3i9eeKuZp649CAa16BzF
   uyT4xw6Co1yWs4GdMJUMEBxVWEL69pqn3Cm4FKx457u6g52uzE1VYvckU
   w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="220954739"
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="220954739"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="522674850"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=KUQTSg4P0Gc0KCzj3taYy5zb0MtNnJiw0fApD54b1cnEAfMoAO0LbIhXvuQ8lXzAZ88WNzGm5yU2Avff+TU0HYFTptEbvFFr/m/g4kMnXEzET88L1HSwDXpXzGxiH8h1OGv/5PnvgPeCpOYNFLqk6O49P6+6LkI2m6hvF/Ped153z88X+2c1LgvcXBQCaSBqZVu92XIDfn/MANBNJVwnyQssxN6jr/TZa45Yi3Z5cuWQsXE0pa1XmidPV3iJ46CUUXWPip9zYZ+s3N10GPWUlac/wDLZF4hIW1dPuG2t8bcThWMq8PZv3icJ0qfW+gdbDMWzjdtXMVGDadHdDEOr5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=iAHKDw9ZcvBAFKPdGUF4mVkR4H6L8g9tQhue9QZAZ7g=;
 b=ZpvTIdhpJHKFCjiseRmt96ATRy4dB+Gr1avx0VcNRey30tviJat6Uo2TatYC0skdoeuw7MXsq9LFda/KNS1GG+vQve1U56S8ALEHjmIdKUCjcl/rsh+pprUdwQKEGA2iZvXJVXtheHmNOFpONoMWq7r11204wW/VWUOBBSoBrN94q++48kSN+4fgCcJJUrEV0aI4F4gY1oYrqZeMWbU+/sa+NYbB4PZiqisEWodBXuJeJaY1t+BMd6zvbw+HCj2+wIpq0SDTvWOUYwlTfC8cLgyofknereXA4vFKyDhrCWfsHTtC+jRQjlSpP/AE6mw2T8rEuzP0fn32iOcr+XblwQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
Subject: RE: [PATCH 0/3] VT-d: macro definition / use tidying
Thread-Topic: [PATCH 0/3] VT-d: macro definition / use tidying
Thread-Index: AQHX7RS1D6BYURt9okGu4tcRyvfEyqxBWWWg
Date: Fri, 24 Dec 2021 07:42:46 +0000
Message-ID: <BN9PR11MB5276E67E45E7530057709ECE8C7F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
In-Reply-To: <5b1a5093-610d-f7d3-8d48-e843d86609da@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 63597bbf-5cb9-4215-c95e-08d9c6b0fa11
x-ms-traffictypediagnostic: BN7PR11MB2609:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN7PR11MB26097DDF87D11E321597CC648C7F9@BN7PR11MB2609.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4303;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BNMxwiuaUMhTNiILY/LPNIGdtYxFpka5XwowrhUAN9B6pqVPePbAFpAdtTgA8t5zcejq40NG8UPCp6L9mtVQBsh8R5cPSw0YUIHHzH1RtyhPNKpivnQSbl68sqr8lPH02AQXacom09ze3V8eaX8Km+xrOa1IyGFKucSd5v7VK78/dZQZtiGUoqR7CKtajnekph49UCrWM6B+OLJu6QNE53f4qTS+Lcqf97dsMDxY0gRGU0rClXQJpFDpRgl9wut8q8l2HK2yCLUkF9ugGFJUQSjVYkRKXet309ijzhgR4qQLQwEwK3ZTnFVuwVyz/7tGZGA/97oCjq3UeTDZuaCc+YoElcJb1VpeSZoo2iTKGw3TfTAYMISb8r5Bkn2svA8Dy038dQCpcHnYcsnySjn5DhnT1Gk9O+IdB/ksBZpyUuno5TBzVIduyUHj/biUcSQYXkjJz/YIRLNNcVUzX6W83fTR6gs557h6xqw9lBQIkLlKESS64yVZKrrzd7fnr/RVz4lPLG8pUnKAnanL1EQzaQuYIRQPX82R3CQSsnIcmyQ415QIMio+TaNIhjLI9BIrkppHne9sIEpr64lrbGLkv9fFjWlLddE/9udqUc1FLuXzmziY7mgJYLFmvvwXS9t1XhhHYrpQ7P6Tn2fawYbkHIUPT29LBqQ3KyqBFvxhoeSumBZ6pmQJOeYeBTvCZf8xGDFpwV9L6Bhe99S+M0dZBQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(86362001)(26005)(38070700005)(33656002)(2906002)(52536014)(83380400001)(71200400001)(186003)(7696005)(66476007)(76116006)(66446008)(66556008)(64756008)(4744005)(5660300002)(38100700002)(122000001)(82960400001)(316002)(8676002)(9686003)(55016003)(110136005)(66946007)(508600001)(6506007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NFN6SmN3K2ZjRVUvRTg3QkRuMzhuOW5pTVBscUtKdnE1Y3RIVjY0UzN2SkFO?=
 =?utf-8?B?VjdmYk5RTzBsZjUzL2k3ZURHVG5RakZqaXU3WjdMdm1LL0lYZkMwRHZCSUxF?=
 =?utf-8?B?ayswWFdNU1duMjQvT1hhZkJLRE4zckVFT3M4TzZybkNIdzNZMzIwZ0F4dmtT?=
 =?utf-8?B?ZlE0R0JaTWJDdVc1Qk1sUm85YUsvTWNjK1R3aVZoMlRZR1dSeE13NVlqR3Yy?=
 =?utf-8?B?c2tvSTFEQWR2OWRDa2VUMVc1ZGtvR0h5c2NhaEIzbW9vdXBIS0xJcXYwWGdm?=
 =?utf-8?B?K0I5aDlZRHBIc2dZUWNzZndYNWhiWm8wNkYvY2ppOGJZUGtLV0RyUmNtVjdi?=
 =?utf-8?B?eTc4b2RweWhNTFJPSUpLSGcySTlTNHVUVC85dHA5bngwOHV6UlF5eEZqUmFv?=
 =?utf-8?B?cGcySFhRM1VSWDFxeFFtSWhPbFVlZHFCT1lNVWJhdkJNV0h3VHRmQjNpdlFE?=
 =?utf-8?B?eVd4TU94WkR2Wm9JckZKRHV3dDEyWEFNRkZLc0JVTllsTW1lblBwd3J6djlG?=
 =?utf-8?B?RGxUdlpxUGNyd3AvajlSbDNvL25SOGloMjBQcEhtUmxRbWRRS1pNU2hLNDl2?=
 =?utf-8?B?bnJEUXYrajFSTXd1NXkvbUdCZVN0Rm5xbjZvUm5Qd3hiL1pOaVBKb3VZQ1BT?=
 =?utf-8?B?bTYwbHpYTkN4Sis5cmt5TSt1YWw2Q3N2cFNnd3lMS2JUSTRKRkd2TjRnZUVX?=
 =?utf-8?B?djUwZncxM2lXT2xuTDJJMUlQRUQvd1NvS0pzVmlDODJ0bUZjemt3dWl5RjBU?=
 =?utf-8?B?UUtweDlCNG1iZFVwWVd5VzhpRkxBNEJRQzBEMGV3bE5UTzVSQTRBam5oVlpF?=
 =?utf-8?B?ajV3d3NHZGxMa3Rab2ZyR3RUeGZSRktpL0ljZDZ3R0M0M09iOHFQcGVXbE1Z?=
 =?utf-8?B?VU1QbEorNTdYaGg4SnJwMGVVNnhBSE9OYkZ1QkwvNDhHRGpLVDAvUys4Wm5y?=
 =?utf-8?B?THBYbmI4YlFJZjVSWGl4Qkc5Y3YxelRLZ1gwRGEvcEJGZGlNSFJ3VWRQMVVF?=
 =?utf-8?B?Qm94cmthaU1Ydm1Tbms5WDhjRDVOMHBvNnNyTncrQkJGN2NFK0Eza0UwZXll?=
 =?utf-8?B?ajZkZU9rSDFJS0JUUjhSblF5RzlJdG41WVRYQ0ovdTZJSTlLSmJETUVKQUpq?=
 =?utf-8?B?S0prM0RzSVhWZFJTMVh4VmhNNFhzby9EaEptRno2eitFaUhyaldJSmp2a01D?=
 =?utf-8?B?MGQvQmxkVlJhbTVRelNtMDRzWlp6TXVxZDAxTHFGTS9WZnB2ZmN5K1N5TjJm?=
 =?utf-8?B?WkYvb045b2hYVnJTTTRETkJMbWovQk1zdUtvZTUxTGlsVnc0c3hQNmhPMGlS?=
 =?utf-8?B?dnYwM3I3VlRkejBnZXRZT2pPMU9xdG9sdVZ6RmdqWEJBWmthVHVteExubHF1?=
 =?utf-8?B?Q0dDaWhNZlFoODhvdVhlSXI1UGFlZEo2a29EQXlJVjh2MWxDS1lHMnZMczI2?=
 =?utf-8?B?bUpKU0c1UUxhK0ZsdURMM1ZxN1R6cEJFSGhIcGZ3bTJQQUd2OEg2cDlVYU94?=
 =?utf-8?B?LzY4Nm9tMGJKRkJVNWxpekFXSXRROXdBdUpiTWJ6S0ZyejZsclZJWVM4VEt1?=
 =?utf-8?B?TjdMRVphaVFaVnVsV2NoS0ZmcmhZSWNNU2FmNDhTK1RxOEM0dDJyd0ZIQk8z?=
 =?utf-8?B?M3VJd1dzZFVkL3BIYTMyQVR5QU82bGZFRnh2ak8rcjFVcDEwLy9GaWpJU3pa?=
 =?utf-8?B?TXovVzJkUlY0MnQxUEtwSVFFTlFTUUw1ZzRFN2RHUjZhN1J0eXdnU0xKMUFu?=
 =?utf-8?B?VWRudDkwejRLbS80SW1rRnlicVlZUFEwSG5qbUx1SlRnZlpHRDNmMDJmTHIy?=
 =?utf-8?B?OEJENDVoZ0Z0S200M2dPZWxkeWFvSUc3RFhiMHBjUW5BTGJnaCszeUZKeXpP?=
 =?utf-8?B?OU40cTRsbmNiK0UzRmYvQ0hMNGFXaWJkSms0U2tZTlhzM0tUVk9ZT3ZGNVFs?=
 =?utf-8?B?S3NZN09yUjZ0SUM0UTJIUGVqNHNtSGF3OFRJK2hSWGFDNFFiVGVvYi9hdEpt?=
 =?utf-8?B?MmFhTm04K0dadHViSFpxVGJzRG4xdmhGRGtQNldZWmxJUitiMGNqK2F0V1hj?=
 =?utf-8?B?elpCQnVuMjdYK0tjZjhKcWVrTFJRWDlWR216ZlB2OGpxWGYzSUNVY21ta3JB?=
 =?utf-8?B?NVFvSE1HQ2VXR1I3ZkJ1aStjcndHY053UEhvcFhOeTdJSnNYajRpNHNGSFdM?=
 =?utf-8?Q?u2Mv3NiIICqnlaIZ6TM1noM=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63597bbf-5cb9-4215-c95e-08d9c6b0fa11
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 07:42:46.0713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CcuBF3g74atfxYE3/FRXZkKkfw80Ui58hh9mGTjW6xDYMyQuWZEpO/n0VRii/MQ/oqH/6nX+zPo9FaKODGZBag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2609
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFRodXJzZGF5
LCBEZWNlbWJlciA5LCAyMDIxIDExOjUyIFBNDQo+IA0KPiBXaGlsZSBwdXR0aW5nIHRvZ2V0aGVy
IHBhdGNoIDEsIEkndmUgbm90aWNlZCB0d28gZnVydGhlciBhc3BlY3RzIHRvDQo+IGNsZWFuIHVw
IGEgbGl0dGxlLg0KPiANCj4gMTogcHJvcGVybHkgcGFyZW50aGVzaXplIGEgbnVtYmVyIG9mIG1h
Y3Jvcw0KPiAyOiB1c2UgRE1BX1RMQl9JVkFfQUREUigpDQo+IDM6IHNob3J0ZW4gdnRkX2ZsdXNo
X3tjb250ZXh0LGlvdGxifV9yZWcoKQ0KPiANCg0KUmV2aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtl
dmluLnRpYW5AaW50ZWwuY29tPiBmb3IgdGhlIHNlcmllcy4NCg==


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 07:45:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 07:45:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251253.432576 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fGK-0008WV-F9; Fri, 24 Dec 2021 07:45:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251253.432576; Fri, 24 Dec 2021 07:45:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fGK-0008WO-BR; Fri, 24 Dec 2021 07:45:12 +0000
Received: by outflank-mailman (input) for mailman id 251253;
 Fri, 24 Dec 2021 07:45:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=P6v+=RJ=intel.com=kevin.tian@srs-se1.protection.inumbo.net>)
 id 1n0fGJ-0008WG-ED
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 07:45:11 +0000
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6ad0242d-648d-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 08:45:10 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Dec 2021 23:45:08 -0800
Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84])
 by orsmga002.jf.intel.com with ESMTP; 23 Dec 2021 23:45:07 -0800
Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:45:07 -0800
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20; Thu, 23 Dec 2021 23:45:07 -0800
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.20 via Frontend Transport; Thu, 23 Dec 2021 23:45:07 -0800
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168)
 by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2308.20; Thu, 23 Dec 2021 23:45:06 -0800
Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18)
 by BN7PR11MB2609.namprd11.prod.outlook.com (2603:10b6:406:b1::26)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.17; Fri, 24 Dec
 2021 07:45:04 +0000
Received: from BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04]) by BN9PR11MB5276.namprd11.prod.outlook.com
 ([fe80::5c8a:9266:d416:3e04%2]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 07:45:04 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6ad0242d-648d-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1640331910; x=1671867910;
  h=from:to:cc:subject:date:message-id:references:
   in-reply-to:content-transfer-encoding:mime-version;
  bh=j0OXZXnuQ69lr+yVsU4srU4fkQHx2hKe1jbgwHdYyh8=;
  b=UNuwwUsG9wbycBCzv5InXSeGJQypgaoQGtuTVskX9Tg6oxnMjXkYRINS
   l3lqOmV8pHjMdhKxgmeDzMjHzDH2Bl2B/q6cpIHUQ4+D6CfesoPmVeHei
   zLnP1xITvhaiw9g2cpuxg4vxVrToRuiUi201pIRlV7udCYMwrrTKP/Hnm
   8XuhxJZkDvhMpmSrSHwmq0fXErIeOtFfjRrIzAy0hROAPSuUokjVPihBf
   zFdEIopSn1nCe73LLWwCmCOC3nHoLn8W8A6T2rrJGI4fmyMwjfcf1jCts
   geLr28HGMxIN7S37t4VpJ8aIA5x3AGz1y2LncgZ2S0vCaJOpffa3MtX6D
   w==;
X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="220955004"
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="220955004"
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,231,1635231600"; 
   d="scan'208";a="485322075"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=GI4hzGYHgSLVjwXnb0T+AWMXYQrr0ATgzryTm3P/KPN0VODKqJUCeCcLaaT8nILHGRXugp/mfq1aAoDxygCU5nJcoFeGicoA4IyI8p6P2j7NwHz+lFy0hMvCUtcwl9aBj6lWO1K5X7pjzBP+VuMZFmVopvBPhp0hXZWxaiKtRPB7IPClPKglTFv5XBZkRnW4AAGgOSrnad9yxaonbFnj6cjtPhiLjHgET+WKro0Bx4ppq50YwxnH0xlGMkUgeqX/kws69kOqUSt+udGW1Zca8X6vSpXEQvaVclgnGWVbdT3tVVPPzEpf6aFxKBan5sjAJjFxK0xndOIKnci9Widapg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j0OXZXnuQ69lr+yVsU4srU4fkQHx2hKe1jbgwHdYyh8=;
 b=anEpK9YTmGDVHOrQgl0wXvQd3npM3jbPT17vvwuzB89TkrfD14vsjWQKn1dp/voL09fjIublUvuIS5/sbBk4FxxjhrmSK6DTh1ls2PjwyrkfBslm2cgNSlrYX70jV7c+lJAB+1nrMVyP71GpiyZw0UOQH0DTbvki4TuPgFRuGe6UxTeiITfmsmps7k7g6ScZp2wLMEtuPiLtxPBj0BkY4WhpKEupGTcL2PIXu4Nfe+l3KuyJrEEaO5xB2YuhseLuabSk1NEDphSdKhYo3GR4MDwaltny1dVm9IyXa7ehdjE+k0C+FVmeQrsj+JYy25Fu27qlrWeMJ9iruSjL7ubTQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Beulich, Jan" <JBeulich@suse.com>, "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>
CC: "Nakajima, Jun" <jun.nakajima@intel.com>
Subject: RE: [PATCH] x86/EPT: squash meaningless TLB flush
Thread-Topic: [PATCH] x86/EPT: squash meaningless TLB flush
Thread-Index: AQHX5gUNjzdaZ7T5YkaXVYM1ZhmrS6xBaC8w
Date: Fri, 24 Dec 2021 07:45:04 +0000
Message-ID: <BN9PR11MB5276DC6941A924889D43B9EA8C7F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
In-Reply-To: <c503e06d-9174-1dab-4f3f-1d7c88b499e9@suse.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 20080606-365f-4fed-7f9f-08d9c6b14ca0
x-ms-traffictypediagnostic: BN7PR11MB2609:EE_
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <BN7PR11MB2609F85996386566167ED0098C7F9@BN7PR11MB2609.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3631;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LqlZMLrKJCCl7PuQdGp8gpHC/2jQiK/wmxfoLfW5yE3oCrOGEO+HbZTGFlnFs0ghX6CHUtZe+yE1HnWBveO2kW7t5YVg3OtrEAkdiSEtJazhfvju+KyWrmJmChw55+bVw59gk2Qh7iboO5uH3oEtl5c3n5m/epN+BbQpw48PaxL7D4YID4Z3Y8dOw/wxpFQ8tUp8Cceocgs2LU2GJ0QwDnBUkws9bY5PdMXf6YDtOAlv9732689ASlTM/6RG61YBQdpvV4myDM/tOpeSpPOfsIhaMluF1rmHt1oyTLkTD0pNrGklzvv1LPBhpTWjGX2oQiotRzJ62+A9QXcTJHJDxVcFZFrFdXufjTlzuma/uGcxrwJd0D0Ii+isADFqKCv6uaqtlykY96BfMDZKFQTYXuZqz0mHECd1YEyOUneI71JQvEwXZ8WoyePkPjACRoepXf1uff7MIaumZLBdF9OAYUZzYHfXHz82O6D8xCGr8NeB3ezqKL2A0iOCGLnt2VO4qqZL05DvqhqY7oH9oIox+Wjs9y55qqwWwNfCTJoTjSsQkGh+OHadHcYiFPQljp2ufX6asww5esTUT6Hc/EOh7xUoitiS2JlO0zT0ll7ZoCvKI2xb+FInwGGTksY2a5yhbqBYdq7fPQs2NgKjbqmcvG1LIq0u0/aK6QVozpdY6y+ZM1qqJvSv0P9GMMfkIFflT9Jz7OskY1XN9/0dAaNZFg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(38100700002)(122000001)(107886003)(66476007)(4744005)(66556008)(64756008)(76116006)(66446008)(66946007)(110136005)(55016003)(6506007)(508600001)(316002)(82960400001)(9686003)(8676002)(38070700005)(4326008)(33656002)(8936002)(86362001)(26005)(7696005)(52536014)(2906002)(71200400001)(186003);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q0YrVW00cXJJdWdPam5qaWY5Wkwra0NEbzBzd2p0NzhxUlpaVUdSZjBVN3dw?=
 =?utf-8?B?WlZ5SVdIWlN5OXE0NzlHbjlEQ1RQLzZ2RC9hMzZVZWtZVkx5UkVLT2RaclFs?=
 =?utf-8?B?QVVYaFlNQ1FzYk9tZGtLZlU5UStydlhqdEdmYjhMOHFMeUtFVlY2ck8rNHRJ?=
 =?utf-8?B?aGhyTERhS292UjBQTlFLNTk5SUNOdEwwZ01odGJWVVBGeFYyR3ByM2NFVkR2?=
 =?utf-8?B?d3VVcVFBckd4NTJOK2V4SlVMUzVlTzM3SmlIU1E5a1ppYkxoUkNGR2ROYUgv?=
 =?utf-8?B?NjF6R0pYWmhVdm1pSEtHai8vYWZLTU9uYXJ3NnhPQjNhd281ZkE1MW4xU2Ev?=
 =?utf-8?B?SCtNNTRIbFJBQmVLQjAzRXk3MHdtbjZtejdvUnhNeWhoMHpzdWk3bmliMjB4?=
 =?utf-8?B?ZnNRcFJ5QW1YWS85eGpjSG52Q3NMVkVrNXdQWlVjSHBRQ09DVndvSTJlMkFa?=
 =?utf-8?B?UlhtTVdxdVJ2cVpIQitTV1hTcTV4TU5aSUFHYmZGQmJSYmJRUzlCYlcvamR5?=
 =?utf-8?B?dWNLMDc5Tld0bFh6bHhmRDYxeUhyV2NhRTd2TjRZcnlRSm1SaU4zTnNnckRo?=
 =?utf-8?B?N0tKd0dVbklNN3pHUm12cC9IMnI3a1BuOGJmY1hYQUtQUm5NN2t2M0hDdFFl?=
 =?utf-8?B?NHJKZmFpYmUyVzF1THVTTC9nMm5vdnhPQkIzQmpCVVNRcUJNS21DQmVYVG1o?=
 =?utf-8?B?M0hEUW5pRmVMazQxVVVhWTlYMENhekV6SnpKUmxvblZRSnVJRXp4eitWSjFR?=
 =?utf-8?B?K0hmK0cwU3Fad1VoWjU0cXNwUkJXd1JiOU96K3AzandYOHhBcUl1R1Npa29V?=
 =?utf-8?B?QnNYMTVEK0U4eHd2UjcvSXFRT2dXdU5ZYmEyUXBIUDdtVXNtVnAxVmNGY1FR?=
 =?utf-8?B?NHBXMGxoVmt5MEoxRkZwa1Y3R21oUEd5QWVVTktRNGtHQURoRDh6dlJvdFUv?=
 =?utf-8?B?cVlQLy9YUWtCZUdOazJFMG96SDliNTRtejdBMUhCTzlySE92U3A2NTNoeFcy?=
 =?utf-8?B?OEtic0M5R0pOVWtJMElNMHVkbkk2MzJhRFc5MmRKbVN1RnNhZzRzMlFMZm0z?=
 =?utf-8?B?RHRjb210MzNJTkY1T2h3OTBpc01YVlVUZGlLME1RdThIZVVFc05iRm5EampX?=
 =?utf-8?B?VFNWMnMvbGJ6anRGdE1Yc0QxMlQycDFFaWVGbXZKNmllVnk0a3BhL0p6MkhO?=
 =?utf-8?B?WUlHdzVobHdHRTF4MGpvZUVyMTV1bGZ3ZnBPekMra1BiaUhhVG0yU1JoN2l1?=
 =?utf-8?B?YytreHNFd2Nwd1VpcThuSk42eWI4RkdDTzNpd2taelkwalExaUxseHBHOTZJ?=
 =?utf-8?B?VTFVS3luVUoyYTMrVkNBRjNtVlVIclkyOHN4R3pTQjhIMXJtcWMxeFlEMXlT?=
 =?utf-8?B?dTNCYytZdGp6ZUJjWUQ1YXFDZ3M5WU4xdVJBTE45aTBzdm84alRRVHk5UDBJ?=
 =?utf-8?B?QlVORnY3N01XVW5OVUY3d2w4TWNDZVFRc2IxU3Y2NVNEdWQvcUZuYzJRN25L?=
 =?utf-8?B?emo2cWVsSnZuQWJOaC9leGQzWi9xMThUS2xCQ2xwM2Rqa1pTMGxZM2RkL3pK?=
 =?utf-8?B?a1VSSEl6TEQ5WmMrSWNMalQ2MHY2MzB3T2lQa0R3QVRrMTkxWjg0cGJYT1dP?=
 =?utf-8?B?b2M1SXdBMFB5YXVkQ0lOL3hjazdqeTA2SUM2bm1lTGtUWng1UDVTY1RlUkpi?=
 =?utf-8?B?UTBFdzJDQ0ZMM2F4dHMvLzZEZFE4UmFwY0wyVnJGRWtPYzRuWi9lQi8vdE1r?=
 =?utf-8?B?S2d6NVZqQVl5Z3lzWmFLV1ErTTI0aXF1Zk5NRS9LNUtMZHJFNDlLTkVYMmFH?=
 =?utf-8?B?Tlh5d1RNc2pxOWFYSTF6cnV0K2JwZ2pnTFNoR1dnNHhrc1psek82QitqU1RT?=
 =?utf-8?B?RDhtcGl2OUNCVStQdzZDalBXblZ4eitLU0FTekcveGkwQmpINmhIV2w1T3Nj?=
 =?utf-8?B?aFJydzQ5TS9scktwejA2eXFwQS9DY1NQczRscGp4bnRzYlh1VmVYcnR4MFMv?=
 =?utf-8?B?QjBCNmwyRUN4djJaaUJOdnJWM3hNZjBlZUZsRG5wcU43RTZzdnM4Q2o4NkFC?=
 =?utf-8?B?UFBsZHN1UXZBYy84cWt0c1dpemczalc3bjhoeC8xclNQdmFweDhMOW5PRzBt?=
 =?utf-8?B?MEhvLzlVeHVyaVhyS0FYdlhQbmZCeURCTjYvQU5WSXpkcFp1QzQvZmR1K1V6?=
 =?utf-8?Q?4U9nFEq5sJjf4BS4GLNmQ1k=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20080606-365f-4fed-7f9f-08d9c6b14ca0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 07:45:04.5827
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qUldZ/cd38Sby1pGlWkLwBM2L/77jDrpam8uRYCkYN/ddUM04N8d0O5bNlh6lXDj5Np9oWn3m5sBlq3cfu47VQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2609
X-OriginatorOrg: intel.com

PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFdlZG5lc2Rh
eSwgRGVjZW1iZXIgMSwgMjAyMSAxMjoxMSBBTQ0KPiANCj4gZXB0X2ZyZWVfZW50cnkoKSBnZXRz
IGNhbGxlZCBhZnRlciBhIGZsdXNoIC0gaWYgb25lIGlzIG5lY2Vzc2FyeSBpbiB0aGUNCj4gZmly
c3QgcGxhY2UgLSB3YXMgYWxyZWFkeSBpc3N1ZWQuIFRoYXQgYmVoYXZpb3IgaXMgc2ltaWxhciB0
byBOUFQsIHdoaWNoDQo+IGFsc28gZG9lc24ndCBoYXZlIGFueSBmdXJ0aGVyIGZsdXNoIGluIHAy
bV9mcmVlX2VudHJ5KCkuIChGdXJ0aGVybW9yZSwNCj4gdGhlIGZ1bmN0aW9uIGJlaW5nIHJlY3Vy
c2l2ZSwgaW4gY2FzZSBvZiByZWN1cnNpdmVuZXNzIHdheSB0b28gbWFueQ0KPiBmbHVzaGVzIHdv
dWxkIGhhdmUgYmVlbiBpc3N1ZWQuKQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg
PGpiZXVsaWNoQHN1c2UuY29tPg0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4udGlh
bkBpbnRlbC5jb20+DQoNCj4gDQo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0LmMNCj4g
KysrIGIveGVuL2FyY2gveDg2L21tL3AybS1lcHQuYw0KPiBAQCAtMjQ2LDggKzI0Niw3IEBAIHN0
YXRpYyB2b2lkIGVwdF9mcmVlX2VudHJ5KHN0cnVjdCBwMm1fZG8NCj4gICAgICAgICAgICAgIGVw
dF9mcmVlX2VudHJ5KHAybSwgZXB0ZSArIGksIGxldmVsIC0gMSk7DQo+ICAgICAgICAgIHVubWFw
X2RvbWFpbl9wYWdlKGVwdGUpOw0KPiAgICAgIH0NCj4gLQ0KPiAtICAgIHAybV90bGJfZmx1c2hf
c3luYyhwMm0pOw0KPiArDQo+ICAgICAgcDJtX2ZyZWVfcHRwKHAybSwgbWZuX3RvX3BhZ2UoX21m
bihlcHRfZW50cnktPm1mbikpKTsNCj4gIH0NCj4gDQoNCg==


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 08:08:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 08:08:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251267.432586 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fcf-0003Wn-O2; Fri, 24 Dec 2021 08:08:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251267.432586; Fri, 24 Dec 2021 08:08:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0fcf-0003Wg-L5; Fri, 24 Dec 2021 08:08:17 +0000
Received: by outflank-mailman (input) for mailman id 251267;
 Fri, 24 Dec 2021 08:08:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0fce-0003WW-6L; Fri, 24 Dec 2021 08:08:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0fce-0005lC-3E; Fri, 24 Dec 2021 08:08:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0fcd-00069L-M2; Fri, 24 Dec 2021 08:08:15 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0fcd-000798-Lb; Fri, 24 Dec 2021 08:08:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sZguGbIDdeTXhUwrCaF07Jxce4ole/3MOQL/E0K0A1k=; b=TlYBMmukndFzvbgKhJRl7Po33o
	wYac/uctAVKwSWuvrIrAWOxZrEtJcB4FdCetnyek0CeVv8X3FiJ4OMoHnoUsmD8zWQ8zMJzb2y5Yy
	+hrlQmyh/VVy7Ae5IV0TpPBrsUvoN5bgsR8oHqdFeqUGeHWabEa/n4SJ88iHVSENIz10=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167531-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167531: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=7a29b11da9651ef6a970e2f6bfd276f053aeb06a
X-Osstest-Versions-That:
    linux=996a18eb796a5ee61582dea3b76a4f88203887d9
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 08:08:15 +0000

flight 167531 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167531/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167529

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167529
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167529
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167529
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167529
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167529
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167529
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167529
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167529
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                7a29b11da9651ef6a970e2f6bfd276f053aeb06a
baseline version:
 linux                996a18eb796a5ee61582dea3b76a4f88203887d9

Last test of basis   167529  2021-12-23 18:39:44 Z    0 days
Testing same since   167531  2021-12-24 01:42:51 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  "Eric W. Biederman" <ebiederm@xmission.com>
  Aleksander Jan Bajkowski <olek2@wp.pl>
  Alexander Lobakin <alexandr.lobakin@intel.com>
  Alexey Gladkov <legion@kernel.org>
  AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  Chun-Kuang Hu <chunkuang.hu@kernel.org>
  Dan Carpenter <dan.carpenter@oracle.com>
  Dave Airlie <airlied@redhat.com>
  David S. Miller <davem@davemloft.net>
  Eric Dumazet <edumazet@google.com>
  Eric W. Biederman <ebiederm@xmission.com>
  Fernando Fernandez Mancera <ffmancera@riseup.net>
  Florian Westphal <fw@strlen.de>
  George Kennedy <george.kennedy@oracle.com>
  Hanjie Wu <nagi@zju.edu.cn>
  Hayes Wang <hayeswang@realtek.com>
  Heiner Kallweit <hkallweit1@gmail.com>
  Hoang Le <hoang.h.le@dektech.com.au>
  Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
  Ignat Korchagin <ignat@cloudflare.com>
  Jakub Kicinski <kuba@kernel.org>
  Jani Nikula <jani.nikula@intel.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jens Axboe <axboe@kernel.dk>
  Jeroen de Borst <jeroendb@google.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Johannes Berg <johannes.berg@intel.com>
  John Harrison <John.C.Harrison@Intel.com>
  Jon Maloy <jmaloy@redhat.com>
  Kiran Bhandare <kiranx.bhandare@intel.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Maciej Fijalkowski <maciej.fijalkowski@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Marcos Del Sol Vives <marcos@orca.pet>
  Marouen Ghodhbane <marouen.ghodhbane@nxp.com>
  Martin Habets <habetsm.xilinx@gmail.com>
  Martin Stolpe <martin.stolpe@gmail.com>
  Matthew Brost <matthew.brost@intel.com>
  Namjae Jeon <linkinjeon@kernel.org>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Abeni <pabeni@redhat.com>
  Paul Blakey <paulb@nvidia.com>
  Pavel Skripkin <paskripkin@gmail.com>
  Remi Pommarel <repk@triplefau.lt>
  Rémi Denis-Courmont <remi@remlab.net>
  Sean Anderson <sean.anderson@seco.com>
  Steve French <stfrench@microsoft.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Willem de Bruijn <willemb@google.com>
  Xiang wangx <wangxiang@cdjrlc.com>
  Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
  Yevhen Orlov <yevhen.orlov@plvision.eu>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   996a18eb796a..7a29b11da965  7a29b11da9651ef6a970e2f6bfd276f053aeb06a -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 10:35:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 10:35:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251288.432597 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0hui-0004D5-Mh; Fri, 24 Dec 2021 10:35:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251288.432597; Fri, 24 Dec 2021 10:35:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0hui-0004Cy-JW; Fri, 24 Dec 2021 10:35:04 +0000
Received: by outflank-mailman (input) for mailman id 251288;
 Fri, 24 Dec 2021 10:35:04 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0hui-0004Co-09; Fri, 24 Dec 2021 10:35:04 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0huh-0008A5-Sb; Fri, 24 Dec 2021 10:35:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0huh-0005bD-JH; Fri, 24 Dec 2021 10:35:03 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0huh-0007KR-Is; Fri, 24 Dec 2021 10:35:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ODKTG7XBTfo+/al4za9Dj3lU4Vf07OicgsLRrXEjIRs=; b=oWiu7Y8YBeyY+5MFt6D25ztH6w
	NmCQhTmMC3Jf7Y5tN1ozjhkLZbIyoBJrDhcMfZpi5cjhAE4bo0bRvtt1eGmnbNdoBB3V/TdB6ufBn
	rGuSA/CZKRm7jdCvvTJalIX8XT2yP3ZZ5GqLFdpNACTA4Ggyliuj0N9Utavw0ShAeDEA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167533-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167533: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=4ed8f5b67d2314c58837c8ff96dce311ccd4c937
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 10:35:03 +0000

flight 167533 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167533/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              4ed8f5b67d2314c58837c8ff96dce311ccd4c937
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  532 days
Failing since        151818  2020-07-11 04:18:52 Z  531 days  513 attempts
Testing same since   167533  2021-12-24 04:20:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90345 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 11:25:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 11:25:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251299.432609 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ihE-00027p-IM; Fri, 24 Dec 2021 11:25:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251299.432609; Fri, 24 Dec 2021 11:25:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ihE-00027i-FO; Fri, 24 Dec 2021 11:25:12 +0000
Received: by outflank-mailman (input) for mailman id 251299;
 Fri, 24 Dec 2021 11:25:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=t0dA=RJ=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n0ihD-00027c-06
 for xen-devel@lists.xen.org; Fri, 24 Dec 2021 11:25:11 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 259b2314-64ac-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 12:25:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 259b2314-64ac-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640345108;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=pv/EiIDrSwxPlE4nLOybsoU0i8XT0YOMYgp1BEm26fE=;
  b=F70c0bjiEX1r17noYyqripF8/AO2lKS7HKcjcnt+foR8ndTwT26ee/BL
   6hpC/5bmujCe1DoN+XVaQO/2oNHgfiC/4yOIhaREHgpwqgPFre5Bpy/jO
   rnLK4d9MCSPJ8VjfzuzJIfVDyM5fwjRYCVYYT+1KzxYmGkjGCmauZO6KJ
   8=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: f8LxSjo10dZl8lj8DPvK0lTr1nRQXRcBXZ8zAscZkVRtgT1IBoPXq2rvVQFDC8wL4qhSX7aIaW
 kmie+fdHlyJ6BNjIjXctwNwvgQFRV7QugY1tIfG5xradwDJjq7QgWfT1IdueJCjnhN0FjY1OtU
 IXuYjZItIzeyI8Kf9YQkr6MHyKTu31tugD4DvqbL4o9hJZvplSQgItYp4xJurvlbY1n6BV0kaW
 YWedS1k3Ahd0JxbOkPL5I10qJkXFEb61swbzI5aQbLCN7GUS0k6vdu3lan4jOGG9RYCvfTypDx
 C+NV4HqX/IJm8MhRiAkGD1KR
X-SBRS: 5.1
X-MesageID: 60669053
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:l84NBq4GvYjhJopIDEhlfQxRtPfAchMFZxGqfqrLsTDasY5as4F+v
 mMeXmCDM62MNjP0LdgjaYWzo0JUv5LQz9dqTgQ4pXxhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA
 +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj2NIw27BVPivW0
 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb
 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6
 fp1spWzED0VDrzviu8/YjRdAgFCIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr
 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgm9u2JEWQK22i
 8wxZwY+QQn4X0B2OV4dUak/x9+jlEPSWmgNwL6SjfVuuDWCpOBr65D9PdyQdtGUSMF9mkeDu
 nmA72n/RBYAO7S3xzuf/3ehmuLIhwvmQ48ID/uj8eNwi1CdwXYcBVsQWEfTnBWiohfgAZQFc
 RVSo3dw6/hpnKC2cjXjdzyXmHmNvUcmZ+pBMP8xyjCgz7v03xnMUwDoUQV9QNAhscY3Qxkj2
 VmIg87lCFRTjVGFdZ6O3uzK9G3vYED5OUdHPHZZFlVdv7EPtalq1kqXJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj70hu+aTNT8D2BN1bQ8xaweRLt1tnHb4
 BA5dzG2tYji962lmi2XW/kqF7q0/fuDOzC0qQcxQ8F7p2n2oyXzJNw4DNRCyKBBaJlsRNMUS
 BWL5VM5CGF7YRNGkpObk6ruUp93nMAM5PzuV+zOb8omX3SCXFTvwc2aXmbJhzqFuBF1yckXY
 M7HGe7xXSdyIfk2l1KeGrZCuYLHMwhjnAs/s7iglE/5uVdfDVbIIYo43KymMrpksfja+VqNq
 L6y9aKikn1ibQE3WQGOmaY7JlEWN3krQ5fwrs1cbOmYJQR6XmomDpfsLXkJIOSJRoxZybXF+
 G+TQEhdxAatjHHLM1zSOHtidKnuTdB0qndiZX4gOlOh2n4CZ4ez7fhAK8trLOd/rOEzn+RpS
 /QletmbBqgdQDrw5DlAP4L2q5ZvdUr3iFvWbTalejU2Y7VpWxfNpo3/ZgLq+SRXVni3uMIyr
 qeOzATeRZZfFQ1uANyPMKCkzk+rvGhbk+V3BhOaLt5WcUTq0Y5rNy2u0aNnf5BScU3On2LI2
 RyXDBEUofj2j7U0qNSZ17qZq4qJEvdlGhYIFWfs8rvrZzLR+XCuwNEcXb/QLyzdTm795I6re
 f5Rk6PnKPQCkVtH79h8HrJswf5s7tfjveYHnAFtHXGNZFW3ELJwZHKB2JAX5KFKw7ZYvyqwW
 16OpYYGaenYZpu9HQ5DPhchY8SCyeoQy2vb4vkCKUnn4DN6oeicWkJIMhjQ0CFQIdOZ6m/+L
 TvNbCLO1zGCtw==
IronPort-HdrOrdr: A9a23:1lSsu6sb/Fwe/K7IAS/975jV7skC7oMji2hC6mlwRA09TyXGra
 +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7EZniahILIFvAY0WKG+VPd8kLFh4xgPM
 tbAs1D4ZjLfCRHZKXBkXiF+rQbsaC6GcmT7I+0pRcdLj2CKZsQlzuRYjzrbHGeLzM2Y6bReq
 Dsgvau8FGbCAsqh4mAdzI4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA
 H+4kHEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z
 PxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72OeBsKT+56wa5JeBrQ7EQt+Ptm1r
 hQ4m6fv51LSTvdgSXU/bHzJl9Xv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP
 JlAKjnlblrmGuhHjDkV1RUsZ+RtixZJGbFfqFCgL3Y79FupgE586NCr/Zv20vp9/oGOu55Dq
 r/Q+BVfYp1P7wrhJRGdZM8qPuMexzwqC33QRCvyHTcZeg60iH22tbKCItc3pDeRHVP9up0pK
 j8
X-IronPort-AV: E=Sophos;i="5.88,232,1635220800"; 
   d="scan'208";a="60669053"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PFDfbiuoJuO7r8K9qUBYeNwoYULzi5zB3dc4cCPdteZkSorcluLPxWQjTUfh2rzOt+E9IfXIhoPNlDEy5ILGCOZs3XHqebv12JfprR0nmAQcuNxqTO7uSS141X8I0NHOI/wmfeG0HobOVy8Z5cyuXSwDzWdYmFYvUXN4QfNHDvoLrDdwf+lRDbVVXDgfRkULqSow4yNOhjZea/vRxdkibmdCUuZTjysPxVbNASA2xyiUtpHelu3saEx/wZXauT/YGu3eoRGJsQH+hEFh6hWILb9TZEASYzTbRREovZ2nyrPc5Sxx35yVBzOZjivecrmaR6j/EW7YXEFGU4tVweVWzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Ek2+P0CpzQYy9MxFuVw/G7r2hLewoWTF/WsBc6/N5io=;
 b=UJ4xyr/mTpNswn7VdMqJu2Yu9Ko4MRqkq7K5y70ALeOQxXpb4Hbj226Hu5up4l1dtQWbzncp4LIDgYI/f806UX+X797qbglBZ+h3DDWkpCFjDRA63iriax8QvBAWv7Agnat4KlftsbKzmbMHGHPiz+C3qk5SDuLzD+QpZIqgpZR+HSm/v7HUJT0fT97IIbTPAvQOZrFu7caqCg7zrYo/YXTu5LNZDVCMFhFIE5aO7WadluyzH6nQyvgqUz8+tzh6i/hmYUMZbBvXWc+GqtNxu6xmqWbIuVzQLHoZFtWMNLbRvpmGedCOEtbcRe+mLyCkl2SscA/X+aDn59Ge7crYNQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Ek2+P0CpzQYy9MxFuVw/G7r2hLewoWTF/WsBc6/N5io=;
 b=WhtFZgZEhny+VIZpGDa9fhYEQwJgula9GX3j7fTZMcvCQiAGbbo4FMDa3oAjdKVRMxu6YB/T/nzPa7bDCdsdpycfg4+eMmwzSw+lgBSONtDsEJOFheDMp0FKSUvmFSVBPoik4Kk+gpJmcnUxQYpdQ29HNZTeRI84s+B3Dk7lryg=
Date: Fri, 24 Dec 2021 12:24:58 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcWuCgYWestnlDSH@Air-de-Roger>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger>
 <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger>
 <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
X-ClientProxiedBy: MR2P264CA0166.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:1::29) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 8e61919f-2d1f-42b7-3901-08d9c6d00744
X-MS-TrafficTypeDiagnostic: DM5PR03MB2841:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2841EEA88654373B457BAF5E8F7F9@DM5PR03MB2841.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6yzfgHcPZEAMTik37Aw2DLqRZSWmx5NYrprs6k352hksyhuJqeulfyaEsgK7YXQexbUnTxfrYO8k9CLRdqpBOy5APQjd1rID8SjctaniG3o8dzNAlWwRjb/o8bss3iSqz+sRwsZlYv+OsgHP/xhUFpdObGmIY/ewyvPYkeX6WdmQSFm87wQrKh7Qlt3Y974qoTb1imNoWE3tOoG+ErejZG8WjyW2G1GhRWYuLpeBGiGB4qSbDb9SDWRJ7fqamYKU+6+o1iLFAno2lhs5jU46Hhz3t9wsS6SsWahMASIvnp2lsgdySJh2tYRPn0A+mKaJOQWNtcjLUIh7zetIVc1va64lBYUe5ysTVNXJWswjjWGctHT4ALdO/vQUQBEsr4z+/jieAsAGUi6UAHv08ZCJUTlTqztHLHN1SiewX38OXfCG5s2uLPJmeVRF0vD2Q35kKTqNMFHwceP+LS7DKd/XRw/EBQpgliy3rEzF45rtSZN9yAS4pG/HKlVtpQm7Clu0Q3o7UkZYUugH8agDTRSYwDj3oqCZAE3oL8ikQgAtm7ZZBdxYWSJOp1wDZJzgmIhyTHkmybjejKla24+q3sAPefBeenZU8ACvw+MSZys7qYTSb5yxI3vIPpo5dyzHvDp2Z7b5Ofn5CvxtXAFmhL0qLWNo2Hx7fC1avCM9w61NMP0QVmExLHD9PBBG2U11/ixO8q2bHWiTq9xSXGoeHmBDQGXXWeCL0svv/rkgk9wTZx4=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66556008)(66476007)(316002)(86362001)(66946007)(6512007)(82960400001)(966005)(2906002)(9686003)(8676002)(33716001)(5660300002)(8936002)(38100700002)(508600001)(186003)(4326008)(83380400001)(6666004)(6506007)(85182001)(26005)(53546011)(6486002)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnhmV1BiZkdCK2VZYXVVVk5HNm1RRWhwZmJ6Qk96L0l0YnNJUWcrcEZ4d1R3?=
 =?utf-8?B?K0h1VXpKdTM3dEdBbzEraHQvdm9qcHpNeGtxb3ZJNkJrNFMzbjVnQTNOdVk1?=
 =?utf-8?B?RjBWNGJKQUpVQU1acHJOdmNhUSszT3pSZjlRS2taUXNIYUtHdldnazBYZjdz?=
 =?utf-8?B?UFR4cVlvV2p3Y25VT3MzREVPY01DQnFxaFIvcWdHQVdaZm50MG41SnJITVZO?=
 =?utf-8?B?RTh2RXcveVVRclRZbkI2K3J5WFZlNWc4QS8rSERuMUJkbUFWdG1JZUE0bmN3?=
 =?utf-8?B?dSs1WnpXNk0rbWpUOEpIbkZ5bCswS2F5MXliVkl1cDBWcEZuSFpNeEIrUFVl?=
 =?utf-8?B?dzVoditqL29hSndudXZEQjNaVE8vSlFQWnM4a3BKdS9GSk5oLzkwd3daU3VK?=
 =?utf-8?B?TVNPMy9pOWJDQ3V0b0d5R1liazhnUHl5K2hOeTdHZlMydlRDWDI3NmpEQTV2?=
 =?utf-8?B?N3VGQlpaVVJ1Ui9DMEZHTFhHSExmdFk3dDFBV1RTbUVSY0d4UUcvMHN6NVFU?=
 =?utf-8?B?c2VTTkR4eWRRZ0FGZHJsN1dvcXAzbXI1ZnFzY25reG1oTXJ5R3NMRFJPRXNq?=
 =?utf-8?B?dnpRRFJsQVVRNjR1YlpVd2s1d3JKT2ZRZzk2TEZ5Q0FTTHc3SWJZeXlzT3pB?=
 =?utf-8?B?U2ZwQmQ3Sm02cEJ0dk04MTMxMFBLRkJmcThUcis2bXhvZlovL21RQ3hIUzZZ?=
 =?utf-8?B?MDkybmhnTnNaQjlQME5TRlFsTGpIWnBaRFdub2F3THNxR3BtYnRaanMzT1k3?=
 =?utf-8?B?SnF3YkZxbUhlR3paUFVxbDJTM3B3VGhKOWIxck9aTnFuOTkvVDdGTnRKLzdN?=
 =?utf-8?B?RHB5NHFtUFYzT0lUKzBEVlIyaWFTU2QvNis0bWNudGxjbktqcFZiZFY2aXlK?=
 =?utf-8?B?Q3pwRFNVbG8wUno4Ym9JMDdic1JYN0k3eFNrNnJWbzNRVVJXWE5IQU9YS2FL?=
 =?utf-8?B?a0NGREJtQVZQR3VDdGxjM1poUmFNc3BucmZMbTJNTHJINXBlOEVQeFAwM2p5?=
 =?utf-8?B?bS9UdHByOEFObEt2YmlrZTNKSkJqRXJkMVd3c0VnRnhuLzA0aUg1V1czeVYw?=
 =?utf-8?B?NEo5ZFlUa1h2WnVnQXVvbmtYTlhrUG9vTUZuWWhkL2QwdndnK1hzc2Jmc1Zi?=
 =?utf-8?B?cThBNEJhMTBKOHJ2V2xsUlNVWVNlS21OOHp3d2tqamE5eDJJNkc3SkhWckhq?=
 =?utf-8?B?dnkvVGVXUXZROTRmUGp2d3RNVmQ4a2RHSjI2N0R6c2hTVVprcHd5YkxReTdV?=
 =?utf-8?B?OUNLZkoxZ3lMTzBrQVBJc1dOTUdGUTRNNHFqK2VTVE52Q0o2eG8vNHAyaWtr?=
 =?utf-8?B?SDg4OFZkTHVzMkdRY0YwWU5MRmJEeEJXVTZhNG4zaStjL3VmS1JVQy80dE5S?=
 =?utf-8?B?Vy9jZi9ZV0VmZVcwWXFaRjBhLzg4TnIzRTZ5TGR1SmRUVWVXWU14Wkh3Yzgr?=
 =?utf-8?B?dUFaTWFRMkVDU3pPVDExazBiMlZNSElGRC9HMVBrbU1JcXZ4U1ZjdmhKUVhq?=
 =?utf-8?B?blAyTG9jRTI4Sm1TeFVwRUhjWEQyUXJtY2hDdU52T0RaT25ZdUxhK3RDYlhE?=
 =?utf-8?B?R3NML0I0ZS8rK3RXOWJDVEU0WXR3TWlHVHhqbEZOK2xXK1Rud043eGFkT1NO?=
 =?utf-8?B?Y0drWE9uY3NYbWhQVDZKUzJEWnRtdFQvcTB4S2s0dDhvZDlsVGs4c1d5TG9W?=
 =?utf-8?B?UDV0V1lWWWdBd0hBVFNNbE1vNHliZVg5YzVHUUc2RmJ1a3dHcVhyTlNBamJJ?=
 =?utf-8?B?aWdLdDBKeWJPM25RbXNPdXFSRWMvbVdVNy85M2c0NElHbGN4cUhmUExURFAz?=
 =?utf-8?B?eWlrR29XTVNFeWhjdlJRQ3pOSVBuMWZ0TVhqL1FuRXp4NlJ4WW9PYmJsbUdK?=
 =?utf-8?B?SWFvR1pwWEhITm9TRlJuTlpZK2J0blN3L1BTbHFRbW5ITHhzSEt4M21iT3Vl?=
 =?utf-8?B?dzNVQmlrUTZZcnE0bnBXU00vdDg1aHFJU3ZwbU1aWGtwMjNQOU9rRDB5TEs4?=
 =?utf-8?B?QzJmLzJRVkY0UENVSlRRVml1VXZ1UmpDZkJGV0JSeFp4Q0FMWEFmcjRFZllS?=
 =?utf-8?B?RXBHMmM3MnJBZkhIU0c5RjlNdXpBcU9aOXhadVhVdnZiTVlTTFI2SlE4UTh5?=
 =?utf-8?B?QWt4eWhuckhhd1B0NDlDbS8vbm1sR0hoWU0yaDlYK0dReURQcDdXTUlRK0Mw?=
 =?utf-8?Q?TcDxRJoEXvBJMi8dHPomSA8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e61919f-2d1f-42b7-3901-08d9c6d00744
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2021 11:25:02.9243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QXdpXh+8CfcedQvrDKgWkeg1bvDWgpj0BiD6dcGafS5LmSoaenCFDqgltOzmQOHf1l8xnMHseL7TZnCns6Nujw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2841
X-OriginatorOrg: citrix.com

On Thu, Dec 23, 2021 at 11:49:08PM +0800, G.R. wrote:
> On Wed, Dec 22, 2021 at 3:13 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> 
> > Could you build a debug kernel with the following patch applied and
> > give me the trace when it explodes?
> 
> Please find the trace and the kernel CL below.
> Note, the domU get stuck into a bootloop with this assertion as the
> situation will come back after domU restart and only dom0 reboot can
> get the situation back to normal.
> The trace I captured below is within the boot loop. I suspect the
> initial trigger may look different. Will give it another try soon.
> 
> FreeBSD 12.2-RELEASE-p11 #0 c8625d629c3(truenas/12.0-stable)-dirty:
> Wed Dec 22 20:26:46 UTC 2021
> The repo is here: https://github.com/freenas/os.git
> 
> db:0:kdb.enter.default>  bt
> Tracing pid 0 tid 101637 td 0xfffff80069cc4000
> kdb_enter() at kdb_enter+0x37/frame 0xfffffe009f121460
> vpanic() at vpanic+0x197/frame 0xfffffe009f1214b0
> panic() at panic+0x43/frame 0xfffffe009f121510
> xn_txq_mq_start_locked() at xn_txq_mq_start_locked+0x4c6/frame
> 0xfffffe009f121580
> xn_txq_mq_start() at xn_txq_mq_start+0x84/frame 0xfffffe009f1215b0
> ether_output_frame() at ether_output_frame+0xb4/frame 0xfffffe009f1215e0
> ether_output() at ether_output+0x6a5/frame 0xfffffe009f121680
> ip_output() at ip_output+0x1319/frame 0xfffffe009f1217e0
> tcp_output() at tcp_output+0x1dbf/frame 0xfffffe009f121980
> tcp_usr_send() at tcp_usr_send+0x3c9/frame 0xfffffe009f121a40
> sosend_generic() at sosend_generic+0x440/frame 0xfffffe009f121af0
> sosend() at sosend+0x66/frame 0xfffffe009f121b20
> icl_send_thread() at icl_send_thread+0x44e/frame 0xfffffe009f121bb0
> fork_exit() at fork_exit+0x80/frame 0xfffffe009f121bf0
> fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe009f121bf0

Thanks. I've raised this on freensd-net for advice [0]. IMO netfront
shouldn't receive an mbuf that crosses a page boundary, but if that's
indeed a legit mbuf I will figure out the best way to handle it.

I have a clumsy patch (below) that might solve this, if you want to
give it a try.

Regards, Roger.

[0] https://lists.freebsd.org/archives/freebsd-net/2021-December/001179.html
---
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c
index 87bc3ecfc4dd..c8f807778b75 100644
--- a/sys/dev/xen/netfront/netfront.c
+++ b/sys/dev/xen/netfront/netfront.c
@@ -1529,6 +1529,35 @@ xn_count_frags(struct mbuf *m)
 	return (nfrags);
 }
 
+static inline int fragment(struct mbuf *m)
+{
+	while (m != NULL) {
+		vm_offset_t offset = mtod(m, vm_offset_t) & PAGE_MASK;
+
+		if (offset + m->m_len > PAGE_SIZE) {
+			/* Split mbuf because it crosses a page boundary. */
+			struct mbuf *m_new = m_getcl(M_NOWAIT, MT_DATA, 0);
+
+			if (m_new == NULL)
+				return (ENOMEM);
+
+			m_copydata(m, 0, m->m_len - (PAGE_SIZE - offset),
+			    mtod(m_new, caddr_t));
+
+			/* Set adjusted mbuf sizes. */
+			m_new->m_len = m->m_len - (PAGE_SIZE - offset);
+			m->m_len = PAGE_SIZE - offset;
+
+			/* Insert new mbuf into chain. */
+			m_new->m_next = m->m_next;
+			m->m_next = m_new;
+		}
+		m = m->m_next;
+	}
+
+	return (0);
+}
+
 /**
  * Given an mbuf chain, make sure we have enough room and then push
  * it onto the transmit ring.
@@ -1541,6 +1570,12 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 	struct ifnet *ifp = np->xn_ifp;
 	u_int nfrags;
 	int otherend_id;
+	int rc;
+
+	/* Fragment if mbuf crosses a page boundary. */
+	rc = fragment(m_head);
+	if (rc != 0)
+		return (rc);
 
 	/**
 	 * Defragment the mbuf if necessary.



From xen-devel-bounces@lists.xenproject.org Fri Dec 24 12:23:46 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 12:23:46 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251342.432620 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jbM-0001Ly-69; Fri, 24 Dec 2021 12:23:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251342.432620; Fri, 24 Dec 2021 12:23:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jbM-0001Lr-2v; Fri, 24 Dec 2021 12:23:12 +0000
Received: by outflank-mailman (input) for mailman id 251342;
 Fri, 24 Dec 2021 12:23:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0jbL-0001Lh-C9; Fri, 24 Dec 2021 12:23:11 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0jbL-0001Ue-30; Fri, 24 Dec 2021 12:23:11 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0jbK-0000en-Mv; Fri, 24 Dec 2021 12:23:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0jbK-0001rF-MS; Fri, 24 Dec 2021 12:23:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YFSW1MxFkYHM6DG4ds6wSInydCbUXMbqvIvbUYb0qxY=; b=mTGsxZJb/lC/wEi0Knfyd0OWmc
	4ew4IFMpnLLw7a5t7T5Mqv9kGnkYnu5F9ze5hTb5bzx3e1CAZ2bcT8LWojji23NjVaokMD9tmjheD
	RfPkOcXynCfXnaFy5kQPFKf10zoWRgXeX55+ykvMqB5geQ3NdH+0DVYexsP/FdarkpIg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167532-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167532: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 12:23:10 +0000

flight 167532 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167532/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel 20 guest-localmigrate/x10 fail in 167523 pass in 167532
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat  fail pass in 167523

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167523
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167523
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167523
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167523
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167523
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167523
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167523
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167523
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167523
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167523
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167523
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167523
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167532  2021-12-24 01:51:48 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 fail    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Dec 24 12:25:20 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 12:25:20 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251349.432631 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jd6-0001v3-Iu; Fri, 24 Dec 2021 12:25:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251349.432631; Fri, 24 Dec 2021 12:25:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jd6-0001uw-FW; Fri, 24 Dec 2021 12:25:00 +0000
Received: by outflank-mailman (input) for mailman id 251349;
 Fri, 24 Dec 2021 12:24:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4pHI=RJ=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n0jd5-0001uq-O8
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 12:24:59 +0000
Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com
 [2607:f8b0:4864:20::642])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81c583e6-64b4-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 13:24:58 +0100 (CET)
Received: by mail-pl1-x642.google.com with SMTP id n16so6573696plc.2
 for <xen-devel@lists.xenproject.org>; Fri, 24 Dec 2021 04:24:58 -0800 (PST)
Received: from localhost.localdomain ([47.89.83.13])
 by smtp.gmail.com with ESMTPSA id d21sm9532980pfv.45.2021.12.24.04.24.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 24 Dec 2021 04:24:56 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81c583e6-64b4-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=TN0/+3UDKz6bwilrMIlNZuNePKFZICf+qgZEEPafMWM=;
        b=kOQgMg2IyS/j4CZvJIAtntd/p+UMb3WooSvYDGy27G1rgF4ChdEPMaLjvgtnTRhEjF
         NtgpQvjAME3sNcw7fH1X1Y1gjtdy9IIsCLjSa75Pr3mDJ42J7p0n7tRF0H8obM3rtMho
         AIUeF8Na/+vmX0+CkFSFkxbcwNqm0V/zoTtG+jS8/wTLi7Qf2zCN/4hDqZf9glQmqA8o
         SJ4KQTPaHrfM+74M+m0i4ycqrRrVcrmN/oRh0nt+WChHZTFT87oyZlYcIYHrU5os3ViX
         1XUeuyN4BiMYxQgCQ0HHIeG7Z0KptdQR+ecPQD9fXuM3907cDAP7CwzU5S0x9kSWxORf
         xouw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=TN0/+3UDKz6bwilrMIlNZuNePKFZICf+qgZEEPafMWM=;
        b=kMQoEg4aLRdO4N3olXXdvOq6KFpPaaGKLC9M24DvVn3IbcTM6E6TAZxyUYNITJ9UWo
         E8j74RTCpHlpFIfRiDiWIY1sZkvQYqIdceNtYs6QAYwIpuuCw761lhC6X9FjVkHa1gq3
         27lDcEyo2kGddNVPoo9Bqg7RqccxSIhZS7szHNzqrzwqLXg1VuNlNmwzqhSYcwg2vshx
         OfsVLoVvCefwCAOqiRp3vsDF3/ev7FoaVkXaCUxGtAXZJONf/3KOeyPu34AlZKdvJl1t
         cbNsSqPSbEP95wlZ1GRUcPuRt7laVMfjkrDQ93UcAL5YTi7zKACFO3qYPuiwG49vcR4k
         NAiQ==
X-Gm-Message-State: AOAM531/hsuq5Vq992hvzbAgox6Fkgzdg0KpVxb5pF8icIieak9Rln4i
	BpmfAeXrxDyAM9QTsKFRRAk=
X-Google-Smtp-Source: ABdhPJzY/4Gmv1rLeXGyOEY1aD9/zkaXpC59+nRdF4AyIzbT6CvQnMN25Gfvhnzn/szRrCL2S9PIMg==
X-Received: by 2002:a17:90a:d195:: with SMTP id fu21mr7765690pjb.106.1640348697088;
        Fri, 24 Dec 2021 04:24:57 -0800 (PST)
From: Dongjiu Geng <gengdongjiu1@gmail.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com,
	xen-devel@lists.xenproject.org
Cc: gengdongjiu1@gmail.com
Subject: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
Date: Fri, 24 Dec 2021 20:24:51 +0800
Message-Id: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
so fix it and make it can select GICV2.

Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
---
$ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
make -C xen install
make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o tools/kconfig/conf.c
gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o tools/kconfig/confdata.c
gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o tools/kconfig/expr.c
flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t -l tools/kconfig/parser.y
gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/preprocess.o tools/kconfig/preprocess.c
gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o tools/kconfig/symbol.c
gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
tools/kconfig/conf  --syncconfig Kconfig

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
  Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
  Selected by [y]:
  - QEMU [=y] && <choice> && ARM_64 [=y]
make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
make -f Rules.mk _install
make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
---
 xen/arch/arm/Kconfig           | 5 +++--
 xen/arch/arm/platforms/Kconfig | 1 -
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..373c698018 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -35,7 +35,7 @@ config ACPI
 
 config GICV3
 	bool "GICv3 driver"
-	depends on ARM_64 && !NEW_VGIC
+	depends on ARM_64
 	default y
 	---help---
 
@@ -44,13 +44,14 @@ config GICV3
 
 config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
-        depends on GICV3 && !NEW_VGIC
+        depends on GICV3
 
 config HVM
         def_bool y
 
 config NEW_VGIC
 	bool "Use new VGIC implementation"
+	depends on !GICV3
 	---help---
 
 	This is an alternative implementation of the ARM GIC interrupt
diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index c93a6b2756..6d3ee99456 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -15,7 +15,6 @@ config ALL_PLAT
 config QEMU
 	bool "QEMU aarch virt machine support"
 	depends on ARM_64
-	select GICV3
 	select HAS_PL011
 	---help---
 	Enable all the required drivers for QEMU aarch64 virt emulated
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Fri Dec 24 12:27:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 12:27:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251353.432642 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jfX-0002Zb-28; Fri, 24 Dec 2021 12:27:31 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251353.432642; Fri, 24 Dec 2021 12:27:31 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0jfW-0002ZU-U4; Fri, 24 Dec 2021 12:27:30 +0000
Received: by outflank-mailman (input) for mailman id 251353;
 Fri, 24 Dec 2021 12:27:29 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=4pHI=RJ=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n0jfV-0002ZO-LR
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 12:27:29 +0000
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com
 [2a00:1450:4864:20::12c])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id db80bf3b-64b4-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 13:27:28 +0100 (CET)
Received: by mail-lf1-x12c.google.com with SMTP id bt1so18717518lfb.13
 for <xen-devel@lists.xenproject.org>; Fri, 24 Dec 2021 04:27:28 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: db80bf3b-64b4-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=l2B6pmDPPPwS4sjVPtyOTR7JrcIeGRAtm9EI1i9aZJY=;
        b=NCKTSxjrI6Bxbvhtc3A3dLRMuvUWW0a37j3Z4yUCkJadbAl6nk5SI41ocy5O+E6jDb
         0z8XFR+d7NWrjyPyo+V9Xqn3Oc8rFMxvWNet3DhNeySvqA/TC55su8OHdo1Z/0OpduR4
         YrJRnwuVeczuoqi2ih/WvHxtKTJ14sWS3sDkFjXKcfI5NP6gtL0pMqcKDt4ZS/t7X4Fq
         Y9SvLInhc0+bNeo3dUw1MnaRTZNxcIfZ/lZp7KrLviD5Dav88tjxqI0QMS3lPa9gg0y6
         vY63wdxgPeckLY30bdtudtF/koEkgyqX+5Aoou2mdy+0Je2Q5yxEDm3Xe9pvH7b3P78w
         0RNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=l2B6pmDPPPwS4sjVPtyOTR7JrcIeGRAtm9EI1i9aZJY=;
        b=BayuK1b7noYLezX0nDSnOl0YBdWLutr29WbbxAcnnYRorxUzsFjSzjVCStYMq3aIOH
         n+YzDdQRzxtB12hASjKyK7NKDBges8q6rSrU8HoX96+lQGuy41/I1//+oJ0kVKgwJ+b/
         ragQovd9IuSvMpCmYsldzv7XFOJ5J/rEjmZBlMRY6Ur+rCQMIrn1IXCmA/MPa4OYkdYj
         gaLenwZzB+GOT2PWBMi3nIVS29zuLIRQ0/kWXMnIWReFmS8VhyBY4+ZWwHvHdaBm2bPu
         vPQ1GcAYNZ2p/ZOGMKhUpSYuG0qfo0XnUjh/pd2rlvGUmqcq3o4vRG+uQU8g9tIwupR7
         BnXA==
X-Gm-Message-State: AOAM530DGXOl/u4tyORjcfigxkaYdWbItWPnxWdtG7ZdF6UFhVxNH7v0
	genwURgiEiGJSzeH77wcSFXqCi//qKb9RlYbDto=
X-Google-Smtp-Source: ABdhPJz8kDg3RK7/GWiJq/kLijP6KroHjI6ocef9c8nmAmztRVZDXflOIiR4hm8cOjnU7gsupV0j2KhnN6Q6k/mLEpA=
X-Received: by 2002:ac2:5c43:: with SMTP id s3mr5291492lfp.260.1640348847861;
 Fri, 24 Dec 2021 04:27:27 -0800 (PST)
MIME-Version: 1.0
References: <20211222083825.2918045-1-gengdongjiu1@gmail.com>
 <6aabf7fe-81ea-0fbc-a640-75f9ac59806b@xen.org> <alpine.DEB.2.22.394.2112231606420.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2112231606420.2060010@ubuntu-linux-20-04-desktop>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Fri, 24 Dec 2021 20:27:15 +0800
Message-ID: <CABSBigTouOAdV=FZ3oSTtK9zZyvm4TQ2WfN-Ef307vBAVcWYVw@mail.gmail.com>
Subject: Re: [PATCH] xen/arm: fix the build error for GIC
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien@xen.org>, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, 
	xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Stefano Stabellini <sstabellini@kernel.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=
=8824=E6=97=A5=E5=91=A8=E4=BA=94 08:08=E5=86=99=E9=81=93=EF=BC=9A
>
> On Wed, 22 Dec 2021, Julien Grall wrote:
> > Hello,
> >
> > On 22/12/2021 09:38, Dongjiu Geng wrote:
> > > when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build fai=
led.
> > > so fix it and make it can select GICV2.
> >
> > Last time I checked QEMU, it was only able to support GICv3 virtualizat=
ion.
> > Has it changed since?
> >
> > >
> > > Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > > ---
> > > $ make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux=
-gnu- -j10
> > > make -C xen install
> > > make[1]: Entering directory
> > > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > > make -f
> > > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Mak=
efile.kconfig
> > > ARCH=3Darm64 SRCARCH=3Darm HOSTCC=3D"gcc" HOSTCXX=3D"g++" syncconfig
> > > make[2]: Entering directory
> > > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > > gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o
> > > tools/kconfig/conf.c
> > > gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/conf=
data.o
> > > tools/kconfig/confdata.c
> > > gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o
> > > tools/kconfig/expr.c
> > > flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> > > bison -o tools/kconfig/parser.tab.c --defines=3Dtools/kconfig/parser.=
tab.h -t
> > > -l tools/kconfig/parser.y
> > > gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o
> > > tools/kconfig/preprocess.o tools/kconfig/preprocess.c
> > > gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol=
.o
> > > tools/kconfig/symbol.c
> > > gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I
> > > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c =
-o
> > > tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
> > > gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I
> > > /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c =
-o
> > > tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
> > > gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdat=
a.o
> > > tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.t=
ab.o
> > > tools/kconfig/preprocess.o tools/kconfig/symbol.o
> > > tools/kconfig/conf  --syncconfig Kconfig
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > > make[2]: Leaving directory
> > > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > > make -f Rules.mk _install
> > > make[2]: Entering directory
> > > '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> > > ---
> > >   xen/arch/arm/platforms/Kconfig | 1 -
> > >   1 file changed, 1 deletion(-)
> > >
> > > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/=
Kconfig
> > > index c93a6b2756..6d3ee99456 100644
> > > --- a/xen/arch/arm/platforms/Kconfig
> > > +++ b/xen/arch/arm/platforms/Kconfig
> > > @@ -15,7 +15,6 @@ config ALL_PLAT
> > >   config QEMU
> > >     bool "QEMU aarch virt machine support"
> > >     depends on ARM_64
> > > -   select GICV3
> >
> > Assuming you can use Xen with GICv2 on QEMU, then this change is OK. Bu=
t we
> > are at risk to expose it again via another platform.
> >
> > So I think it would be better to also to add a dependency !GICV3 for NE=
W_VGIC.
>
> I agree. I gave it a try and turns out it is not possible to simply add:
>
> depends on !GICV3
>
> under NEW_VGIC because there is already a !NEW_VGIC under GICV3.
> Apparently it creates a circular dependency. Instead, I did the
> following and it looks like it is behaving the way we want.
>
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..373c698018 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -35,7 +35,7 @@ config ACPI
>
>  config GICV3
>         bool "GICv3 driver"
> -       depends on ARM_64 && !NEW_VGIC
> +       depends on ARM_64
>         default y
>         ---help---
>
> @@ -44,13 +44,14 @@ config GICV3
>
>  config HAS_ITS
>          bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPO=
RTED
> -        depends on GICV3 && !NEW_VGIC
> +        depends on GICV3
>
>  config HVM
>          def_bool y
>
>  config NEW_VGIC
>         bool "Use new VGIC implementation"
> +       depends on !GICV3
>         ---help---

Thanks for the suggestion, I have updated it and resumbit patch v2,
please review it again.

>
>         This is an alternative implementation of the ARM GIC interrupt


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 12:53:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 12:53:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251362.432653 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0k4q-0006Ty-9A; Fri, 24 Dec 2021 12:53:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251362.432653; Fri, 24 Dec 2021 12:53:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0k4q-0006Tr-61; Fri, 24 Dec 2021 12:53:40 +0000
Received: by outflank-mailman (input) for mailman id 251362;
 Fri, 24 Dec 2021 12:53:39 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0k4p-0006Th-GD; Fri, 24 Dec 2021 12:53:39 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0k4p-0001z5-Cu; Fri, 24 Dec 2021 12:53:39 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0k4p-0001Vq-2I; Fri, 24 Dec 2021 12:53:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0k4p-0002NM-1n; Fri, 24 Dec 2021 12:53:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=nKpEthBWE6Tl9jhkqlBjnnyFl7ikcWrfeU6mbceixrs=; b=rpVeaNzI+j1LOyj6uVRmBKaEyM
	sBRy42khGjBle3uCMuRSv4IB3041H+I0VwUM5OYYafKWzQ+Qyi3K1vfJ2t+lV9VP15cy1QLgHsbYl
	sJX0kw/AOBoQ34YYytYNVl6pMxlWw418sBc6v08oGpPt/Ly7rOnolUflcUg3WptOied0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167535-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167535: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=6612ff85611bc2be16dc0fd5de0e1413df88941a
X-Osstest-Versions-That:
    ovmf=15c596aeebc24bb97deb78d98bd8517a8b9ac243
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 12:53:39 +0000

flight 167535 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167535/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 6612ff85611bc2be16dc0fd5de0e1413df88941a
baseline version:
 ovmf                 15c596aeebc24bb97deb78d98bd8517a8b9ac243

Last test of basis   167527  2021-12-23 08:11:36 Z    1 days
Testing same since   167535  2021-12-24 09:12:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Longlong Yang <longlong.yang@intel.com>
  Yang, Longlong <longlong.yang@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   15c596aeeb..6612ff8561  6612ff85611bc2be16dc0fd5de0e1413df88941a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 13:26:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 13:26:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251370.432664 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kZv-0001z5-NI; Fri, 24 Dec 2021 13:25:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251370.432664; Fri, 24 Dec 2021 13:25:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kZv-0001yy-Jb; Fri, 24 Dec 2021 13:25:47 +0000
Received: by outflank-mailman (input) for mailman id 251370;
 Fri, 24 Dec 2021 13:25:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0kZv-0001ys-7Y
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 13:25:47 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kZs-0002Wi-OH; Fri, 24 Dec 2021 13:25:44 +0000
Received: from lfbn-ren-1-1977-131.w90-59.abo.wanadoo.fr ([90.59.184.131]
 helo=[192.168.1.19]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kZs-0004Ie-GS; Fri, 24 Dec 2021 13:25:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=Tc31zzAVRD/enlNNySasUJXFSHzjRoHay+n1Uj2InDA=; b=6QPX/GT9wXsFjo18Sbv3roj5QZ
	sVOOZfRK73G2CDBqjxfOTPTw+NHCR5dpKtYwyTJIFh/vXdFBaDH2bl94UCeY2/jrBQYB4kqBiviLr
	fE2KpbStD96qynacez1b9ZyZue3SEPcwVDYKFxQttowm5s9OkpcCu4baeFHjDcCzch9M=;
Message-ID: <22172c85-b024-a28a-e351-82038cf0efa1@xen.org>
Date: Fri, 24 Dec 2021 14:25:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU
 Platform
To: Dongjiu Geng <gengdongjiu1@gmail.com>, sstabellini@kernel.org,
 Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com,
 xen-devel@lists.xenproject.org
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 24/12/2021 13:24, Dongjiu Geng wrote:
> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
> so fix it and make it can select GICV2.

As I said in v1, last time I checked QEMU was only able to support 
virtualization with GICv3. This is why we added a depends on.

If you want to remove it, then I think you ought to explain in the 
commit message why this is fine. A pointer to the commit or a QEMU 
version used would be useful.

> 
> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> ---
> $ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
> make -C xen install
> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o tools/kconfig/conf.c
> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o tools/kconfig/confdata.c
> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o tools/kconfig/expr.c
> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t -l tools/kconfig/parser.y
> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/preprocess.o tools/kconfig/preprocess.c
> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o tools/kconfig/symbol.c
> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> tools/kconfig/conf  --syncconfig Kconfig
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> 
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> make -f Rules.mk _install
> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
> ---
>   xen/arch/arm/Kconfig           | 5 +++--
>   xen/arch/arm/platforms/Kconfig | 1 -
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..373c698018 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig

The change in arch/arm/Kconfig is not really related to this patch. 
Technically the part in platforms/Kconfig is sufficient. I still think 
the change is good to have but it should be in a separate patch.

> @@ -35,7 +35,7 @@ config ACPI
>   
>   config GICV3
>   	bool "GICv3 driver"
> -	depends on ARM_64 && !NEW_VGIC
> +	depends on ARM_64
>   	default y
>   	---help---
>   
> @@ -44,13 +44,14 @@ config GICV3
>   
>   config HAS_ITS
>           bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
> -        depends on GICV3 && !NEW_VGIC
> +        depends on GICV3
>   
>   config HVM
>           def_bool y
>   
>   config NEW_VGIC
>   	bool "Use new VGIC implementation"
> +	depends on !GICV3
>   	---help---
>   
>   	This is an alternative implementation of the ARM GIC interrupt
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index c93a6b2756..6d3ee99456 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -15,7 +15,6 @@ config ALL_PLAT
>   config QEMU
>   	bool "QEMU aarch virt machine support"
>   	depends on ARM_64
> -	select GICV3
>   	select HAS_PL011
>   	---help---
>   	Enable all the required drivers for QEMU aarch64 virt emulated

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 13:29:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 13:29:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251373.432675 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kdJ-0002rK-5p; Fri, 24 Dec 2021 13:29:17 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251373.432675; Fri, 24 Dec 2021 13:29:17 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kdJ-0002rD-2b; Fri, 24 Dec 2021 13:29:17 +0000
Received: by outflank-mailman (input) for mailman id 251373;
 Fri, 24 Dec 2021 13:29:15 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0kdH-0002r3-Tn
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 13:29:15 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kdH-0002az-L6; Fri, 24 Dec 2021 13:29:15 +0000
Received: from lfbn-ren-1-1977-131.w90-59.abo.wanadoo.fr ([90.59.184.131]
 helo=[192.168.1.19]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kdH-0004Sd-Df; Fri, 24 Dec 2021 13:29:15 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=Jxs0OBvtP9rfLDqEqcAGY2vUktv5bxiAGtc3M2AO5pc=; b=koPGUhm/mcp9BsPSI7ZHJ3tMO+
	Uj1TUEs+M/UylsRYA7ueORPedClDcn3XHUiT4QyofWTczAeps72Ug1fMIzGPDdwqc/7wViOTovkPD
	S3Yqdv2xbRTl2jz3kC0dz1w5iAvmXW4G2edesFkoIbRnTkewfS+xvUd2shDYx+POF69M=;
Message-ID: <437596a2-b375-fc79-a865-186f7eaf10a8@xen.org>
Date: Fri, 24 Dec 2021 14:29:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Stefano Stabellini <sstabellini@kernel.org>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
 <20211223190637.GA99855@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 24/12/2021 01:16, Stefano Stabellini wrote:
>> One more question: As you probably seen - Jan had a complains about SCI
>> term. He said SCI is ambiguous with ACPI's System
>> Control Interrupt.
> 
> I see his point. As a term I see "SCMI" often and sometimes "SCPI" but
> "SCI" is the first time I saw it with this patch series.
> 
> 
>> I think of using SC (as System Control) instead. What do you think
>> about it?
> 
> Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" alone
> doesn't give me enough context to guess what it is.

I might be missing some context. Why are naming everything SCI rather 
than SMCI?

> 
> Or we could broaden the scope and call it "firmware_interface"?
How would this be used? Will it be a list of interface that will be 
exposed to the guest?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 13:31:09 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 13:31:09 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251377.432686 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kev-0004B8-GX; Fri, 24 Dec 2021 13:30:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251377.432686; Fri, 24 Dec 2021 13:30:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0kev-0004B1-DN; Fri, 24 Dec 2021 13:30:57 +0000
Received: by outflank-mailman (input) for mailman id 251377;
 Fri, 24 Dec 2021 13:30:56 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0keu-0004Av-Ks
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 13:30:56 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kes-0002ck-MD; Fri, 24 Dec 2021 13:30:54 +0000
Received: from lfbn-ren-1-1977-131.w90-59.abo.wanadoo.fr ([90.59.184.131]
 helo=[192.168.1.19]) by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0kes-0004Wq-4S; Fri, 24 Dec 2021 13:30:54 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=ij/F5CdH3kvc+dTdOHjC9asMiDF7yrl4TB648wkINik=; b=3hAXE+fezGMdJlO96BU2n7majY
	v+etInXX+WqYaBI1en6NtiYilDK11+ZYFMJMcdv+VQkWI22bIaqubbP+AV7ayXxk3sHd2HfZlz5Il
	8lxV4tplZmFN9p0ymNAsPm0zr4tun3QanZylT4KbMTryvueOwDjjrk/S/1pX07oEKj3c=;
Message-ID: <b85f7ea3-dd0c-1281-d1e2-1010fb2f5892@xen.org>
Date: Fri, 24 Dec 2021 14:30:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [RFC v1 5/5] xen/arm: add SCI mediator support for DomUs
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>,
 Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>, Juergen Gross <jgross@suse.com>,
 Andrew Cooper <andrew.cooper3@citrix.com>,
 George Dunlap <george.dunlap@citrix.com>, Jan Beulich <jbeulich@suse.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <4469cdf05051bd691a8adff2657d27f6a5f0cefb.1639472078.git.oleksii_moisieiev@epam.com>
 <b1c27f70-309d-bb36-3228-32836063fd16@gmail.com>
 <20211217121524.GA4021162@EPUAKYIW015D> <YcHol8ads22asXGF@perard>
 <alpine.DEB.2.22.394.2112211330310.2060010@ubuntu-linux-20-04-desktop>
 <bc6d7529-337d-a4e1-664a-dddd68ecf5cb@xen.org> <87lf0cx50o.fsf@epam.com>
 <3967a86d-295f-7672-9ce3-71e1c393dcbd@xen.org> <87ee64x1hf.fsf@epam.com>
 <796960e7-62ab-6f05-b3c0-cd02d7e8a8ba@xen.org>
 <alpine.DEB.2.22.394.2112221636530.2060010@ubuntu-linux-20-04-desktop>
 <alpine.DEB.2.22.394.2112231056380.2060010@ubuntu-linux-20-04-desktop>
From: Julien Grall <julien@xen.org>
In-Reply-To: <alpine.DEB.2.22.394.2112231056380.2060010@ubuntu-linux-20-04-desktop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 23/12/2021 20:06, Stefano Stabellini wrote:
> On Wed, 22 Dec 2021, Stefano Stabellini wrote:
>> # Future Ideas
>>
>> A great suggestion by Julien is to start supporting the dom0less partial
>> device tree format in xl/libxl as well so that we can have a single
>> "device_tree" option in dom.cfg instead of 4 (device_tree, iomem, irqs,
>> dtdev).
>>
>> Even with that implemented, the user has still to provide a partial dtb,
>> xen,reg and xen,path. I think this is a great step forward and we should
>> do that, if nothing else to make it easier to switch between dom0less
>> and normal domU configurations. But the number of options and
>> information that the user has to provide is still similar to what we
>> have today.
> 
> I have just realized that if we start to parse the partial DTB in
> xl/libxl the same way that we do for dom0less guests (parse "xen,path",
> "xen,reg", and "interrupts", making dtdev, irqs and iomem optional)
> actually we can achieve the goal below thanks to the combination:
> "xen,path" + "xen,force-assign-without-iommu".
> 
> In other words, with dom0less we already have a way to specify the link
> to the host node even if the device is not a DMA master. We can do that
> by specifying both xen,path and xen,force-assign-without-iommu for a
> device.
> 
> This is just FYI. I am not suggesting we should introduce dom0less-style
> partial DTBs in order to get SCMI support in guests (although it would
> be great to have). I think the best way forward for this series is one
> of the combinations below, like a) + d), or a) + c)

I strongly prefer a) + c) because a warning is easy to miss/ignore. At 
least with the extra property the user made an action to think about it 
and agree that this is the way do it.

It is also easier to spot if we ask the user to provide the 
configuration file.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 13:59:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 13:59:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251384.432697 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0l6Q-0007Lv-R6; Fri, 24 Dec 2021 13:59:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251384.432697; Fri, 24 Dec 2021 13:59:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0l6Q-0007Lo-OG; Fri, 24 Dec 2021 13:59:22 +0000
Received: by outflank-mailman (input) for mailman id 251384;
 Fri, 24 Dec 2021 13:59:21 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1uFu=RJ=epam.com=prvs=2992704931=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0l6P-0007Li-E5
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 13:59:21 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id af21d3ea-64c1-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 14:59:19 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BODeqQS019861;
 Fri, 24 Dec 2021 13:59:14 GMT
Received: from eur03-db5-obe.outbound.protection.outlook.com
 (mail-db5eur03lp2056.outbound.protection.outlook.com [104.47.10.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d5afjgv4u-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 24 Dec 2021 13:59:14 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7088.eurprd03.prod.outlook.com (2603:10a6:102:eb::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 13:59:09 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 13:59:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: af21d3ea-64c1-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=G14NxuBf0tWcn/CDEsH5FYz7zoVFJypYEkxcMnzGntVqWWRepu8B72R9fI46cMsqZR5+FSWkxik7pgIHV9hbHbq66Ro7OwWIEVIc7WEmzBGEHo8LT2PYpyXENuDhXzLjr46M5gXqVPYQkl2EibubHAON9SdEp2ZcFwQyjGARUH1dpwGoSkzIDS5o2jsDA8KkP8PA0CsTE8kpz6ys/ZBwTeXAm0Zw9Q6iD4PxiwAPksMIEHJ7fuU86XfDd4GCmzFBLoiqAKJyTGj9aGJvgvBEYHS+NE8wd2qHp/iGK2uSjSoC1Rb+UFd3Y/pcVphNFZ7Ok7NTLptVD4elnEQtKFUIEQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=I9kf1b6ZxB571CuLyyJc7Jw/JChSxS819zhX89j+y3w=;
 b=ZB/c5+fr2HI5d47f88MsvYCYav+v9usvtT5PeMw1eANwOuTz78RbkV4sfSNriLF0tVJn1VPhOt2tVCM0h5H37NwBVyb2wRKunh0/ApENRd9upe1SRd5zIqB5PR+sv/Fmcba7tn2XGRc3VRsqJMsAycP7VtLX6IM1EXJWz6V9TzU/wzvspgDSwjMN8ShC5xkcycvwFl8QbBhSkeHDSa3ml76FizQcIJMOfT7oCS4rpUYdmQzeVSflqqIr8BhJ9NqPzgofxWzuNJhkXvmh4+ZDYFv1T1VF4ZVY6mfVjkC//gm1E9QVv4s4AG9cHKYKx1wOum6zfU9dxD3FPbly4k+QEA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=I9kf1b6ZxB571CuLyyJc7Jw/JChSxS819zhX89j+y3w=;
 b=WGZu9cx9kfsX1JvtTHaNLLeBPsSbos6E0U09GBXfbAyZPUDTIAGpbtd3TZAF3KusaKmXjNoWJ402LRHFs5WuEbxj3t5DIWiJCjQm7dIZPnB5nYZK08YraBaBwZaZ9413bzH1aAx6ISRy/oURXnRgbAOgKZGZve3hF7QWtXNa4UTc9IASCQAUzw26QLpKWpvP373hWkPNKKlxN1nAFvaLHXhvJQcp+FdAo7MH0MgZohnDd30eTGQIksN+zCpwJs6ZTLQ5PSmF4HYzNQWbFNzTlBfuHuUT+rmocrOouJGrXYHk3EWV0DsbN4YAU7MTV518ez47JJSHoGp45PDaqhoF/Q==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuAgAAWSACAAOV/AIABANAAgAEYTICAAFamgIAA3WqAgAAIW4A=
Date: Fri, 24 Dec 2021 13:59:09 +0000
Message-ID: <20211224135819.GA945512@EPUAKYIW015D>
References: 
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
 <20211223190637.GA99855@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
 <437596a2-b375-fc79-a865-186f7eaf10a8@xen.org>
In-Reply-To: <437596a2-b375-fc79-a865-186f7eaf10a8@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3d66c0d5-51f2-42bd-b92d-08d9c6e58ef9
x-ms-traffictypediagnostic: PA4PR03MB7088:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7088FAB4CFF5EDF4D267F5F9E37F9@PA4PR03MB7088.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 1jWPR21gxbAzTRlQj3pKAz7kFZGv37l3bzhzcFkj/j4F7vy/1sggfMw4K9b6rj1uwPQoBWjeZ5hW2wzM40VQbzHyZHqPWCpyaq9IaxLaZpCKABPoTHf4MpN358pvnlIcW+jABmymZ01AaabQG02Mqm7ExmCTtnpRBT9vokBAktR023o8h+phw/OxA1vzW3nxgXrqMllLYhuuiCnP2TkKBNdSzoBEVc9CmBHgnUQme5OAQ4nBzc3j+06Q1UJAx3bVb1KG2ajPNISBIWAlMWCeaBYDK0ARJkFhQLEPw/lBdU4A3R9WI2S41VNpamFhRmIW6/qJbbrLYcr8FQ66+5x3Igq8F2xnkv1JbQ2dc+F9L4jITpsJMvxeDFg8xVJjOks3+bPi/CHC82dyuKal+wIPgmtTBL9ANx5uwCvelEQ1lHBQfmTCMzqUio6WMdru/JV21aW5Dp3a8zueVUtsSw2e4cETRT8MUckYb603Rk52Puoyrb/E086dJFimwtHya5nkGS4bACn/jMGqK4SRWELxvJBZDB9PqK4ph8Se+HqrrV2wg8wzTZHvLMr68XdTXkkDdKi2lBMgP3n3xJh2eRlK30mdvOzGp8THXuPwCe8yq/FtLqG4PCKXHegV+E51LOIbM/IdObIm+OdLVUO6leq45EG3a9F5h5UL1lsau0FTYX7j0Uv7tYwMEgPEd9OKOB4176QrEnhdO44MSF8JD+gHaw==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(66556008)(66446008)(66476007)(91956017)(26005)(66946007)(38070700005)(64756008)(33716001)(6916009)(76116006)(8936002)(186003)(6506007)(71200400001)(508600001)(4326008)(8676002)(54906003)(53546011)(1076003)(316002)(33656002)(6512007)(122000001)(5660300002)(6486002)(86362001)(38100700002)(9686003)(83380400001)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ODCecTU1Sy3OC+0tcDEfoXT6neSCzRK+U7PfBgpA6XbqBXaRSGJc361OjgSh?=
 =?us-ascii?Q?PFICGR8YI3snNJSKpNVSZD5orb58lRV+/s+eE2hSO/tbl8n/aEeisBgZob+U?=
 =?us-ascii?Q?7QAGjhyeK8FIwUZ1bkWXw/5xqeEaXzCRE+kY1HX4aEaUd6V+YosuunIsGM2H?=
 =?us-ascii?Q?aJvCrloHAPSSMgSQYzE/zmCqsvT2RxQ3PTP9zkWeZNCL6tXcqky9NXl32Tpn?=
 =?us-ascii?Q?oZEcXA7PEaa/JLJZwCtCQ4nQbWD9dw5mZWNkgmgl2Ulm6ARjOGApOJeiTAje?=
 =?us-ascii?Q?Fz1oT0M+v0qS0XFXeepC8jVz4L1VRxt49jDKtucHGriGMPmlSU1gME6DBKMz?=
 =?us-ascii?Q?yJm0zDjGze49BlOQzLbdZxpxNXudOwZHgbQ2YeDx7TD5FUdn+XlCs+3icQaS?=
 =?us-ascii?Q?rSHJbmJLfUGsWFqln31rVHxcoEdbKm+TUKJRLE2LE4jR2V7Y1mcuR5DhBV9l?=
 =?us-ascii?Q?hZ8jia/XtBkffdDocb6tVaKz9f57a4FMZGuGgTBuo9XFwKxQwrQEFZZ2s6kT?=
 =?us-ascii?Q?n0I6/70Oz3yVj9APgReX0iQD+6+sNmy/zdEHZR8yiftTnFN770RseWub8enW?=
 =?us-ascii?Q?1eig+ubPR5ApYeoLfHRgG31350Y+6M6WoEfNxX7WSbC0V7HuDi11gFGm4UnQ?=
 =?us-ascii?Q?gY8xrXhY17hQnmkDEU23KKqPTPzy0uGAG5lzTznjEmbrAsjGg/oKjhUXT64C?=
 =?us-ascii?Q?1p6rI++vo+cnyYQdQXOnCGjNcKIZBoHWbemMuutOZHnM+Vj9/zZQ4XDAqrEV?=
 =?us-ascii?Q?zcFDodu0pSKfeGiDLDgGxGBHwgx8fcTO/jPsNpsTwqub9mBdXUyxeuEJmcoc?=
 =?us-ascii?Q?mJHipPJlsljHcnvwPOGfL48p/9SHurSo1Bmw/CCNERnO6ziSAr8Gvo3Xf+lc?=
 =?us-ascii?Q?hvggvCjHcM4DN2EppvAPsHElx7dY+ezpAUlBN7OJ3kz4Rp7RahFe3LuIwVL1?=
 =?us-ascii?Q?JcFWGnP1YWki+fv102J6NJkSfRteQfCnSvvEyF4S5jyvoyH+GGKunLKX5+0T?=
 =?us-ascii?Q?w8n9AI2XdUkBSafAju7T69p95BMIfSudMYq0wT07T5VQwSHb9jc6gUqTHHoV?=
 =?us-ascii?Q?CPj1UycCIWGljlV+PTOXjkU7MQF5YTrkAiPwe2ijGXFgLBlbM/ondbpZB7x1?=
 =?us-ascii?Q?W1Iyx7LQvlQJVfa61mBpkAMiK/ZKj+UiztYhYbQRBC9EgFf3QwgD63byIuVx?=
 =?us-ascii?Q?9YAAuNJ40Pgx6tA4McpJQWcdEp8wEHRNF5pLohh8jjW71Z1U5gOvwVzLo1IF?=
 =?us-ascii?Q?/dNmWtl9lVLsG+rXmzHPvTbxNK6F4Xtk4ldJ9ZXu3tE9DqM3nEYPOKCvpjQh?=
 =?us-ascii?Q?V+fbbrbyYwkcDlBMrdfLedjFxp8qLxA2Dc2ZNAYZ9P8wMr+txX48WdTSHaYD?=
 =?us-ascii?Q?TTIDNqxxDi3GIDSsVWmf0ltjwN2NsmCvPZPv0xq2au6fK4rDQYPLJvGw+FMh?=
 =?us-ascii?Q?7/SgJccN+HJVF03PMtOHc8eY85ML2b7ww0/bNLfn4ISwywJD+yI7cQjPMoCk?=
 =?us-ascii?Q?0YTKDidhjRzjre8cb8jNH9OvdiayTW5Drl49o5OeUjQV+4rIg5MARzPB57+o?=
 =?us-ascii?Q?pPF8bqOKNRlly8Kdh6V2B4nHimHqBN6V0GCW0Zm8jAXY9nZ11tdkIkttb2Fz?=
 =?us-ascii?Q?uSZ9xo8gBNU96xKHtZxMsOaeXZWfTWkqS6l3rQdiKQyh8xRG5XYga5GaHrJ3?=
 =?us-ascii?Q?Jw/az/Ex7Jk+KHD/LXuaRsI0/vY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2F5DA9A88848FB41AD3691DEBEEF2C42@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d66c0d5-51f2-42bd-b92d-08d9c6e58ef9
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 13:59:09.7239
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CbOe6f2yM4Ujxjf9h+HkM5gdTjPV0pC6XSTJZQPNExeoSOKHcOc3GzsbdiYk4H0lYqdjHTyeUSYpIaofzM6Dnjg7rDeVDo5rQ3RNnPMXnwc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7088
X-Proofpoint-GUID: xbv6U0hrIN4MVD2O94jXOmye1IgWYYZC
X-Proofpoint-ORIG-GUID: xbv6U0hrIN4MVD2O94jXOmye1IgWYYZC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-24_05,2021-12-24_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=1 impostorscore=0 bulkscore=0
 adultscore=0 spamscore=1 suspectscore=0 priorityscore=1501 clxscore=1015
 mlxscore=1 mlxlogscore=211 lowpriorityscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112240068

Hi Julien,

On Fri, Dec 24, 2021 at 02:29:13PM +0100, Julien Grall wrote:
> Hi,
>=20
> On 24/12/2021 01:16, Stefano Stabellini wrote:
> > > One more question: As you probably seen - Jan had a complains about S=
CI
> > > term. He said SCI is ambiguous with ACPI's System
> > > Control Interrupt.
> >=20
> > I see his point. As a term I see "SCMI" often and sometimes "SCPI" but
> > "SCI" is the first time I saw it with this patch series.
> >=20
> >=20
> > > I think of using SC (as System Control) instead. What do you think
> > > about it?
> >=20
> > Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" alone
> > doesn't give me enough context to guess what it is.
>=20
> I might be missing some context. Why are naming everything SCI rather tha=
n
> SMCI?

Because we're expecting other interfaces and transport to be
implemented, such as for example:
scmi_mailbox, scpi_smc, scpi_mailbox, ti_sci_smc etc.

>=20
> >=20
> > Or we could broaden the scope and call it "firmware_interface"?
> How would this be used? Will it be a list of interface that will be expos=
ed
> to the guest?
>=20

The idea is to set mediator type for each Domain, so for example Xen can
use scmi_mailbox to communicate with SCP, Dom0 and DomD are also using
scmi_mailbox, but DomU using scmi_smc mediator because we have only 3
mailboxes in system. This is not implemented yet, right now, we are
introducing only scmi_smc support. In future, multiple mediator support
can be added to Xen.

Best regards,
Oleksii.


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 14:07:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 14:07:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251389.432707 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lDz-0000UA-PT; Fri, 24 Dec 2021 14:07:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251389.432707; Fri, 24 Dec 2021 14:07:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lDz-0000U3-MR; Fri, 24 Dec 2021 14:07:11 +0000
Received: by outflank-mailman (input) for mailman id 251389;
 Fri, 24 Dec 2021 14:07:11 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1uFu=RJ=epam.com=prvs=2992704931=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0lDz-0000Tx-8h
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 14:07:11 +0000
Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com
 [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id c7ef160f-64c2-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 15:07:09 +0100 (CET)
Received: from pps.filterd (m0174679.ppops.net [127.0.0.1])
 by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BODeqKH019858;
 Fri, 24 Dec 2021 14:07:05 GMT
Received: from eur04-db3-obe.outbound.protection.outlook.com
 (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56])
 by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3d5afjgvv1-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 24 Dec 2021 14:07:05 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7422.eurprd03.prod.outlook.com (2603:10a6:102:108::17)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 14:07:01 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 14:07:01 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c7ef160f-64c2-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=L49oTesLnmUtaH2ZG5k+BYqEC985CE8vdOwgHdhh0+8AKAK13/8HNQY6ho6c0X7Oq5puhvQL/QCL9r6ZWpp8Z4FDP26SoshKlP0syWl3StGWqRJ7ftAmxTIr08HoyRrDOdtIe32+4REWrYVXAikWuiK4Z5U8QqEEo3pL3rAemwivYVEQDIMdw0Qo7YCj9fYpA1GTBCY2dM/t6pKR+4D4cnrmD9CVZ/y04q1PVFHgqc0O+CFA2CQ0AnKbJkpIPWkASKcDDEF9YUdPpCAII6N5xgCVAO8cpeiIiJ9HXdffIxSSa1QGXSy9EqpQGnCqiC/jQPl7Ywjic8urjOwr46oLWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=z6oQ/DOqB82kiNlSAy3FlaSMHz0qdM7jINYAJcobIn0=;
 b=RqmPQ05Fy0fAWaxCb6PcTXZzFZHMeyLzKrKRZZz+m8Jt/BqKptcET/v1XzfdtZEBH4I1esumwNXKO90MAi8loeQhQHDoZvi6GWKaIM02HyJ1x7O+XFrIX0XM/ROgJPBnsXG+5fCkCCOAXPsy/YDO73qXt7kxORLV1rfsLp+wtTcETW0NuZjIK4HNngZZ3XwRnGPZnXFujYIazhPfBApk/4J6VAh+7bqPkz6DPFDE5Ja/rY5Po1ckCOTeF+szhRbq1Fv/HOFG3HxErBzSGCdqEp8qOh/U1lMXfMLco8yBdHB8R+OQKQ9wAdFynSQyY04WroRzzOr+NujpktQPT7BqSQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=z6oQ/DOqB82kiNlSAy3FlaSMHz0qdM7jINYAJcobIn0=;
 b=CEuDpEscIoq94AC2gxURV9XHPiTiqBt267qhHFgQvSfQJAqxuTn1S92FVOn7sHMKSlFLdkv36KvtN074h4/0ZAVyrAzn0Ay0Gc3/TPTKqKXnnCSFf7+g3Jri5YmuFTUH7Md+PHhCXChHStL5xhJLdVa6GPOLfpGa067+bjfNprcnaZlCcfmNEBwsVPpsfqC1ikyuX/KFeJfIvz02JUM4DSkatF2tDjf4IcdnFN6PhEPTjd8N0VRROsHXjX7RR8ODwXln9hGcaV68d5L9Mt1H8jn7xFWck2AAIaFHlBcyoWXSM6vJVNw6+PgP3vkh8mTXgy7UP2T8M1jWG1VuXd4p9w==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Stefano Stabellini <sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Julien
 Grall <julien@xen.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuAgAAWSACAAOV/AIABANAAgAEYTICAAFamgIAA5/qA
Date: Fri, 24 Dec 2021 14:07:01 +0000
Message-ID: <20211224140701.GA953282@EPUAKYIW015D>
References: 
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
 <20211223190637.GA99855@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
In-Reply-To: 
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5781a05d-7515-4349-9dd2-08d9c6e6a862
x-ms-traffictypediagnostic: PA4PR03MB7422:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7422208AE22EB57C50B7884FE37F9@PA4PR03MB7422.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 t8N4EeytOvcjmC6b/V7PhzELlW/TyyNP/NfqS++090gmESouKnc9JaDb19iQ8+kK+CooVA0Hk0to/PmA4XxDdF46lrsW3Ts8lfufFmxyMoo3Klqe3sPLhv9fbX27alVGI7yr7rngTg8Dh9CgmFatN765jXy9hLABqz9LT2h0kLgO8UGD+HwGQxJjvtPnzH80GIiefoxXEL8HKkeWaaVszs9W3Cif9myVIR+S+Znh5DE4GZ3mNTfGQ1i9eaYq0ctZ8wHFaU+35eU57iZ19WiquowhiVtrF2/nD0FMHYxQL3dg0JZFazzEVvC18Kk+WHdMLXokZMh1zufw3Uxh2ceJ0htrtyzRFk5n523tWiaxBZHj1CX8lvlgfDcQAFg2rIsx/IBR0qVMCcmX589Z6YWfEckU0IvqKTSkl8IoXQFHZAMhX8xT//+3C1xGfX5moupQe1ic3f8+gySX8Mqu+5V1P138UiRfvSdOfjfJqyHSfnXkYbG3TvI716e/8erL1EoVFdl+O8vN5I7hbm4Njj6uqE6xWrtX0xh4EingLomysJzp/5goLxBjOW8ZXLnR3YvHPlJtMq8s46iMgqoFZU5A/n5LZ6djv155W2wnjR1ApytT9/11S2W3HLxiZEVJ91GzrODI/xiNoxxJ9YXMgnbI/VTV8S53furConX5SLMoINZ2ETaZsDn/k1z+7dKWa2dLxBwi0Fkmvzh7Y4HVdtsLOXov0GOmQbi/tbT3TvFGoATiDmpWtYFbHelg5CM48utzLXjgQUzqkrxltC4Go78pYEuD3IhWrJDEF+tTzIJCCpt3qqFxXcEL6s+l//sngIyo
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(66476007)(76116006)(66556008)(30864003)(6916009)(508600001)(38070700005)(122000001)(26005)(38100700002)(86362001)(186003)(66946007)(66446008)(9686003)(6512007)(966005)(64756008)(71200400001)(5660300002)(91956017)(316002)(33656002)(6506007)(4326008)(2906002)(54906003)(6486002)(1076003)(8936002)(33716001)(83380400001)(8676002)(2004002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?MMxhKEw5GIEPsAr3klhxwv9fsMFGdCTF2xOTNz33YVtNMGmBCcE0sI7sX1xC?=
 =?us-ascii?Q?fhJtGSMnKNkWQXxbvfaC6MJ4wT0HmRN5Uy6ecx6mPZ2dq1QJjUyHb81bYK9v?=
 =?us-ascii?Q?43ZRMdOVWbvuHlTiIOi1UDmhhQj+FPfwwMxwR5/PXixaey+NitznNDv1DQf/?=
 =?us-ascii?Q?vo0ktGvveuKLmXg5ursu5m1HsIe46yxVx8YEs0g5hubP+zIUbpjG14vah8gs?=
 =?us-ascii?Q?1UHjhEzCI8kNrbG+6FabfXohQFIWMcb8s/VQ7ZBaIgwxKiPnFgE+chz1987y?=
 =?us-ascii?Q?n20CKstOK7yehZvFz7nD2pR37A1hc64X/vdlmWIbTExIcbyKlqpTbDfrnR7p?=
 =?us-ascii?Q?9yK9C+d3zzkzM4B5OtuE6DKZ1dlXVELk6OyxGjfoSznrdIzNCByBQg74bfW1?=
 =?us-ascii?Q?5fbcaXtcaOqUkXbvL+5Usr85xpJn2Ty/b5r7cgxdfGN6I6FY39PSVWQK1Y1W?=
 =?us-ascii?Q?3S4UsINtx/ed3+AIc1a9L2dZR3VAr4IiDK3jHvzIj0PNq1OynTA+b1j5ntwv?=
 =?us-ascii?Q?FdzmUkeL/a97M7NqifI6VlOgEHaFq57a8SPU51jhmndYhaCa2kQ2eehEhDZp?=
 =?us-ascii?Q?jJ6cEVw1s0ugqRU3QvvvqpdYsrPZt8/Nl0VbkOtHDcQ5hmYJVVsdrMiEnEQl?=
 =?us-ascii?Q?Fe7aDgE7PfbjfMGP5xxmZK/tdMNZBVfmkL1OTFtT16/JWuv7DMWzLZvJai6f?=
 =?us-ascii?Q?0qIPAYHP1/LS3e5lKtOsNZIy8it22mvUeWakj36DHi7ua+COZ+5IiPQw1Duz?=
 =?us-ascii?Q?glCPKsxGxqER9sAHIY7Q+vYw2ipTJYSSwCU65DdWa+xUW+xuiGpPdm23TDn3?=
 =?us-ascii?Q?cWZlyXIwf2BnYlVt+Qnu/zS0PEHGoSunkdOT8nGI9On2Gv6GURpCD00kmqZO?=
 =?us-ascii?Q?hBUVT4ttrGi1ZI7er5tHRxIzbJrbI4ahJXcGSwvyu5xsngbBlROYki8OyifM?=
 =?us-ascii?Q?P8yCQks8UNgC6k1nRzPY8mrOHYWlqBAvOAoDWcqqU5XjzzFTVW+jQ7fKCrPx?=
 =?us-ascii?Q?m1ilubpbeDCJTMW7HeI3SI0zMhO297Yx4TLaHKNwq2hpXzMPF9FHA/5Raldi?=
 =?us-ascii?Q?bVpHcc0S2FDHVsdaoIu3D90aaksKiTPzlMz4sc29vbFPrLfDfmu+pEML2bCC?=
 =?us-ascii?Q?wKKwtP6x2pCm4PPE0ev4HnHivHmJm+fwl/HJE+aRO9eJkB3GdpYE4R7wGsaF?=
 =?us-ascii?Q?8GMdr2MF+ODJ/+8O1sSsHWWgZvqBlPqUSH4++Qvl3RMLscxVr6NB5xkXJNYT?=
 =?us-ascii?Q?nQucgTA6JcKWSWlRWtIYi6rdWRWoTo4ARdmsZE5V7ELmhtNaOcv7Xxo0h1lQ?=
 =?us-ascii?Q?jxfDJcfuGm6+qkVZGTjKByr7aNfP0Pl3pzPS1D9zAMn+rk3UhIDoUps5Xkbr?=
 =?us-ascii?Q?NMlmYZMtjw2IIMiqZ+Ko3HdFuq93N1qOQJY1cuBJOrml8VGEhwPyxqVyitau?=
 =?us-ascii?Q?6tpbAtX8Ekesn4Pnh3D0OrCNIg7XFUmACKKs2cWF2Zw/LxWPM30/sPQnjo+y?=
 =?us-ascii?Q?0WeGFbjucPwjvI4dNvDfEBmWDlchfSdllCCPCGMaxgSt5QqO+zbnReyUgcTX?=
 =?us-ascii?Q?x1QGyaIiQ0BfJnTpsPUWNWOdJihLYY4SR0Hc3iqhQHi0TPBAdj1gI6wjilaA?=
 =?us-ascii?Q?9c9OSIl68i/gwAAAzkMKeTHOlClDNH30Siu7luI+7Bud9CdyxT9eggKeSIVd?=
 =?us-ascii?Q?Fd24cXtk9BoZuQxK+KmktqOHf5Q=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3D5C8222F95EC541BECDFFBBA2545E18@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5781a05d-7515-4349-9dd2-08d9c6e6a862
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 14:07:01.8667
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 267kcdbGc3KDgaWvfzQOWTQ9CkTv7iWrZ3KP+Cx9pIKaG5DmvyDZ2CJLq8TicwXJyvLMRySoM7foUqTBLPA/bqJZZME8P8oML0mYZY1QKhQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7422
X-Proofpoint-GUID: 9arFuZA-jP6-di0MnsGTTTzYAeHTIMhf
X-Proofpoint-ORIG-GUID: 9arFuZA-jP6-di0MnsGTTTzYAeHTIMhf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-24_05,2021-12-24_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0
 adultscore=0 spamscore=0 suspectscore=0 priorityscore=1501 clxscore=1015
 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112240069

On Thu, Dec 23, 2021 at 04:16:45PM -0800, Stefano Stabellini wrote:
> On Thu, 23 Dec 2021, Oleksii Moisieiev wrote:
> > On Wed, Dec 22, 2021 at 06:23:24PM -0800, Stefano Stabellini wrote:
> > > On Wed, 22 Dec 2021, Oleksii Moisieiev wrote:
> > > > On Tue, Dec 21, 2021 at 01:22:50PM -0800, Stefano Stabellini wrote:
> > > > > On Tue, 21 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > Hi Stefano,
> > > > > >=20
> > > > > > On Mon, Dec 20, 2021 at 04:52:01PM -0800, Stefano Stabellini wr=
ote:
> > > > > > > On Mon, 20 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > > Hi Stefano,
> > > > > > > >=20
> > > > > > > > On Fri, Dec 17, 2021 at 06:14:55PM -0800, Stefano Stabellin=
i wrote:
> > > > > > > > > On Tue, 14 Dec 2021, Oleksii Moisieiev wrote:
> > > > > > > > > > This is the implementation of SCI interface, called SCM=
I-SMC driver,
> > > > > > > > > > which works as the mediator between XEN Domains and Fir=
mware (SCP, ATF etc).
> > > > > > > > > > This allows devices from the Domains to work with clock=
s, resets and
> > > > > > > > > > power-domains without access to CPG.
> > > > > > > > > >=20
> > > > > > > > > > The following features are implemented:
> > > > > > > > > > - request SCMI channels from ATF and pass channels to D=
omains;
> > > > > > > > > > - set device permissions for Domains based on the Domai=
n partial
> > > > > > > > > > device-tree. Devices with permissions are able to work =
with clocks,
> > > > > > > > > > resets and power-domains via SCMI;
> > > > > > > > > > - redirect scmi messages from Domains to ATF.
> > > > > > > > > >=20
> > > > > > > > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epa=
m.com>
> > > > > > > > > > ---
> > > > > > > > > >  xen/arch/arm/Kconfig          |   2 +
> > > > > > > > > >  xen/arch/arm/sci/Kconfig      |  10 +
> > > > > > > > > >  xen/arch/arm/sci/Makefile     |   1 +
> > > > > > > > > >  xen/arch/arm/sci/scmi_smc.c   | 795 ++++++++++++++++++=
++++++++++++++++
> > > > > > > > > >  xen/include/public/arch-arm.h |   1 +
> > > > > > > > > >  5 files changed, 809 insertions(+)
> > > > > > > > > >  create mode 100644 xen/arch/arm/sci/Kconfig
> > > > > > > > > >  create mode 100644 xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > >=20
> > > > > > > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfi=
g
> > > > > > > > > > index 186e1db389..02d96c6cfc 100644
> > > > > > > > > > --- a/xen/arch/arm/Kconfig
> > > > > > > > > > +++ b/xen/arch/arm/Kconfig
> > > > > > > > > > @@ -114,6 +114,8 @@ config SCI
> > > > > > > > > >  	  support. It allows guests to control system resourc=
ess via one of
> > > > > > > > > >  	  SCI mediators implemented in XEN.
> > > > > > > > > > =20
> > > > > > > > > > +source "arch/arm/sci/Kconfig"
> > > > > > > > > > +
> > > > > > > > > >  endmenu
> > > > > > > > > > =20
> > > > > > > > > >  menu "ARM errata workaround via the alternative framew=
ork"
> > > > > > > > > > diff --git a/xen/arch/arm/sci/Kconfig b/xen/arch/arm/sc=
i/Kconfig
> > > > > > > > > > new file mode 100644
> > > > > > > > > > index 0000000000..9563067ddc
> > > > > > > > > > --- /dev/null
> > > > > > > > > > +++ b/xen/arch/arm/sci/Kconfig
> > > > > > > > > > @@ -0,0 +1,10 @@
> > > > > > > > > > +config SCMI_SMC
> > > > > > > > > > +	bool "Enable SCMI-SMC mediator driver"
> > > > > > > > > > +	default n
> > > > > > > > > > +	depends on SCI
> > > > > > > > > > +	---help---
> > > > > > > > > > +
> > > > > > > > > > +	Enables mediator in XEN to pass SCMI requests from Do=
mains to ATF.
> > > > > > > > > > +	This feature allows drivers from Domains to work with=
 System
> > > > > > > > > > +	Controllers (such as power,resets,clock etc.). SCP is=
 used as transport
> > > > > > > > > > +	for communication.
> > > > > > > > > > diff --git a/xen/arch/arm/sci/Makefile b/xen/arch/arm/s=
ci/Makefile
> > > > > > > > > > index 837dc7492b..67f2611872 100644
> > > > > > > > > > --- a/xen/arch/arm/sci/Makefile
> > > > > > > > > > +++ b/xen/arch/arm/sci/Makefile
> > > > > > > > > > @@ -1 +1,2 @@
> > > > > > > > > >  obj-y +=3D sci.o
> > > > > > > > > > +obj-$(CONFIG_SCMI_SMC) +=3D scmi_smc.o
> > > > > > > > > > diff --git a/xen/arch/arm/sci/scmi_smc.c b/xen/arch/arm=
/sci/scmi_smc.c
> > > > > > > > > > new file mode 100644
> > > > > > > > > > index 0000000000..2eb01ea82d
> > > > > > > > > > --- /dev/null
> > > > > > > > > > +++ b/xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > > @@ -0,0 +1,795 @@
> > > > > > > > > > +/*
> > > > > > > > > > + * xen/arch/arm/sci/scmi_smc.c
> > > > > > > > > > + *
> > > > > > > > > > + * SCMI mediator driver, using SCP as transport.
> > > > > > > > > > + *
> > > > > > > > > > + * Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > > > > > > > + * Copyright (C) 2021, EPAM Systems.
> > > > > > > > > > + *
> > > > > > > > > > + * This program is free software; you can redistribute=
 it and/or modify
> > > > > > > > > > + * it under the terms of the GNU General Public Licens=
e as published by
> > > > > > > > > > + * the Free Software Foundation; either version 2 of t=
he License, or
> > > > > > > > > > + * (at your option) any later version.
> > > > > > > > > > + *
> > > > > > > > > > + * This program is distributed in the hope that it wil=
l be useful,
> > > > > > > > > > + * but WITHOUT ANY WARRANTY; without even the implied =
warranty of
> > > > > > > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE=
.  See the
> > > > > > > > > > + * GNU General Public License for more details.
> > > > > > > > > > + */
> > > > > > > > > > +
> > > > > > > > > > +#include <asm/sci/sci.h>
> > > > > > > > > > +#include <asm/smccc.h>
> > > > > > > > > > +#include <asm/io.h>
> > > > > > > > > > +#include <xen/bitops.h>
> > > > > > > > > > +#include <xen/config.h>
> > > > > > > > > > +#include <xen/sched.h>
> > > > > > > > > > +#include <xen/device_tree.h>
> > > > > > > > > > +#include <xen/iocap.h>
> > > > > > > > > > +#include <xen/init.h>
> > > > > > > > > > +#include <xen/err.h>
> > > > > > > > > > +#include <xen/lib.h>
> > > > > > > > > > +#include <xen/list.h>
> > > > > > > > > > +#include <xen/mm.h>
> > > > > > > > > > +#include <xen/string.h>
> > > > > > > > > > +#include <xen/time.h>
> > > > > > > > > > +#include <xen/vmap.h>
> > > > > > > > > > +
> > > > > > > > > > +#define SCMI_BASE_PROTOCOL                  0x10
> > > > > > > > > > +#define SCMI_BASE_PROTOCOL_ATTIBUTES        0x1
> > > > > > > > > > +#define SCMI_BASE_SET_DEVICE_PERMISSIONS    0x9
> > > > > > > > > > +#define SCMI_BASE_RESET_AGENT_CONFIGURATION 0xB
> > > > > > > > > > +#define SCMI_BASE_DISCOVER_AGENT            0x7
> > > > > > > > > > +
> > > > > > > > > > +/* SCMI return codes. See section 4.1.4 of SCMI spec (=
DEN0056C) */
> > > > > > > > > > +#define SCMI_SUCCESS              0
> > > > > > > > > > +#define SCMI_NOT_SUPPORTED      (-1)
> > > > > > > > > > +#define SCMI_INVALID_PARAMETERS (-2)
> > > > > > > > > > +#define SCMI_DENIED             (-3)
> > > > > > > > > > +#define SCMI_NOT_FOUND          (-4)
> > > > > > > > > > +#define SCMI_OUT_OF_RANGE       (-5)
> > > > > > > > > > +#define SCMI_BUSY               (-6)
> > > > > > > > > > +#define SCMI_COMMS_ERROR        (-7)
> > > > > > > > > > +#define SCMI_GENERIC_ERROR      (-8)
> > > > > > > > > > +#define SCMI_HARDWARE_ERROR     (-9)
> > > > > > > > > > +#define SCMI_PROTOCOL_ERROR     (-10)
> > > > > > > > > > +
> > > > > > > > > > +#define DT_MATCH_SCMI_SMC DT_MATCH_COMPATIBLE("arm,scm=
i-smc")
> > > > > > > > > > +
> > > > > > > > > > +#define SCMI_SMC_ID                        "arm,smc-id=
"
> > > > > > > > > > +#define SCMI_SHARED_MEMORY                 "linux,scmi=
_mem"
> > > > > > > > >=20
> > > > > > > > > I could find the following SCMI binding in Linux, which d=
escribes
> > > > > > > > > the arm,scmi-smc compatible and the arm,smc-id property:
> > > > > > > > >=20
> > > > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > > > > > > > >=20
> > > > > > > > > However, linux,scmi_mem is not described. Aren't you supp=
osed to read
> > > > > > > > > the "shmem" property instead? And the compatible string u=
sed for this
> > > > > > > > > seems to be "arm,scmi-shmem".
> > > > > > > > >=20
> > > > > > > >=20
> > > > > > > > We use linux,scmi_mem node to reserve memory, needed for al=
l
> > > > > > > > channels:
> > > > > > > >=20
> > > > > > > > reserved-memory {
> > > > > > > >     /* reserved region for scmi channels*/
> > > > > > > >     scmi_memory: linux,scmi_mem@53FF0000 {
> > > > > > > >         no-map;
> > > > > > > >         reg =3D <0x0 0x53FF0000 0x0 0x10000>;
> > > > > > > >     };
> > > > > > > > };
> > > > > > > >=20
> > > > > > > > arm,scmi-shmem node used in shmem property defines only 1 p=
age needed to
> > > > > > > > the current scmi channel:
> > > > > > > >=20
> > > > > > > > cpu_scp_shm: scp-shmem@0x53FF0000 {
> > > > > > > >     compatible =3D "arm,scmi-shmem";
> > > > > > > >     reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > > > > > > > };
> > > > > > > >=20
> > > > > > > > For each Domain reg points to unigue page from linux,scmi_m=
em region,
> > > > > > > > assigned to this agent.
> > > > > > >=20
> > > > > > > If we were to use "linux,scmi_mem" we would have to introduce=
 it as a
> > > > > > > compatible string, not as a node name, and it would need to b=
e described
> > > > > > > in Documentation/devicetree/bindings/firmware/arm,scmi.yaml.
> > > > > > >=20
> > > > > > > But from your description I don't think it is necessary. We c=
an just use
> > > > > > > "arm,scmi-shmem" to describe all the required regions:
> > > > > > >=20
> > > > > > > reserved-memory {
> > > > > > >     scp-shmem@0x53FF0000 {
> > > > > > >         compatible =3D "arm,scmi-shmem";
> > > > > > >         reg =3D <0x0 0x53FF0000 0x0 0x1000>;
> > > > > > >     };
> > > > > > >     scp-shmem@0x53FF1000 {
> > > > > > >         compatible =3D "arm,scmi-shmem";
> > > > > > >         reg =3D <0x0 0x53FF1000 0x0 0x1000>;
> > > > > > >     };
> > > > > > >     scp-shmem@0x53FF2000 {
> > > > > > >         compatible =3D "arm,scmi-shmem";
> > > > > > >         reg =3D <0x0 0x53FF2000 0x0 0x1000>;
> > > > > > >     };
> > > > > > >     ...
> > > > > > >=20
> > > > > > > In other words, if all the individual channel pages are descr=
ibed as
> > > > > > > "arm,scmi-shmem", why do we also need a single larger region =
as
> > > > > > > "linux,scmi_mem"?
> > > > > > >=20
> > > > > >=20
> > > > > > That was my first implementation. But I've met a problem with
> > > > > > scmi driver in kernel. I don't remember the exact place, but I =
remember
> > > > > > there were some if, checking if memory weren't reserved.
> > > > > > That's why I ended up splitting nodes reserved memory region an=
d actual
> > > > > > shmem page.
> > > > > > For linux,scmi_mem node I took format from /reserved-memory/lin=
ux,lossy_decompress@54000000,
> > > > > > which has no compatible string and provides no-map property.
> > > > > > linux,scmi_shmem node is needed to prevent xen from allocating =
this
> > > > > > space for the domain.
> > > > > >=20
> > > > > > Very interesting question about should I introduce linux,scmi_m=
em node
> > > > > > and scmi_devid property to the
> > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml?
> > > > > > Those node and property are needed only for Xen and useless for
> > > > > > non-virtualized systems. I can add this node and property descr=
iption to
> > > > > > arm,scmi.yaml, but leave a note that this is Xen specific param=
s.
> > > > > > What do you think about it?
> > > > >=20
> > > > > Reply below
> > > > >=20
> > > > > [...]
> > > > > =20
> > > > >=20
> > > > > > > In general we can't use properties that are not part of the d=
evice tree
> > > > > > > spec, either https://urldefense.com/v3/__https://www.devicetr=
ee.org/specifications/__;!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_Ch=
owYQiQYC595rMOsrnmof2zmk7BnhXCSnJPN$ [devicetree[.]org] or
> > > > > > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/li=
nux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings__;=
!!GF_29dbcQIUBPA!kNodtgmOQBc1iO76_6vTK-O1SoLxee_ChowYQiQYC595rMOsrnmof2zmk7=
BnhXloYUaj$ [git[.]kernel[.]org]
> > > > > > >=20
> > > > > > > "linux,scmi_mem" is currently absent. Are you aware of any up=
streaming
> > > > > > > activities to get "linux,scmi_mem" upstream under
> > > > > > > Documentation/devicetree/bindings in Linux?
> > > > > > >=20
> > > > > > > If "linux,scmi_mem" is going upstream in Linux, then we could=
 use it.
> > > > > > > Otherwise, first "linux,scmi_mem" needs to be added somewhere=
 under
> > > > > > > Documentation/devicetree/bindings (probably
> > > > > > > Documentation/devicetree/bindings/firmware/arm,scmi.yaml), th=
en we can
> > > > > > > work on the Xen code that makes use of it.
> > > > > > >=20
> > > > > > > Does it make sense?
> > > > > > >=20
> > > > > >=20
> > > > > > Yes I agree. I think linux,scmi_mem and scmi_devid should be up=
streamed.
> > > > > > I will add those properties to arm,scmi.yaml, mark them as rela=
ted to XEN and send patch.
> > > > >=20
> > > > > I didn't realize that linux,scmi_mem and scmi_devid are supposed =
to be
> > > > > Xen specific. In general, it would be best not to introduce Xen s=
pecific
> > > > > properties into generic bindings. It is a problem both from a
> > > > > specification perspective (because it has hard to handle Xen spec=
ific
> > > > > cases in fully generic bindings, especially as those bindings are
> > > > > maintained as part of the Linux kernel) and from a user perspecti=
ve
> > > > > (because now the user has to deal with a Xen-specific dtb, or has=
 to
> > > > > modify the host dtb to add Xen-specific information by hand.)
> > > > >=20
> > > > >=20
> > > > > Let me start from scmi_devid.  Why would scmi_devid be Xen-specif=
ic? It
> > > > > looks like a generic property that should be needed for the Linux=
 SCMI
> > > > > driver too. Why the Linux driver doesn't need it?
> > > > >=20
> > > >=20
> > > > scmi_devid used during domain build. It passed as input parameter f=
or SCMI_BASE_SET_DEVICE_PERMISSIONS message.
> > > > On non-virtualized systems - there is no need of this call, because=
 OS
> > > > is the only one entity, running on the system.
> > >=20
> > > OK. Even if it is only required for virtualized systems, I think that
> > > scmi_devid is important enough that should be part of the upstream
> > > binding. I think it is worth starting an email thread on the LKML wit=
h
> > > Rob Herring and the SCMI maintainers to discuss the addition of
> > > scmi_devid to the binding.
> > >=20
> >=20
> > Ok I will start the thread about scmi_devid.
> > >=20
> > > > I've chatted with Volodymyr_Babchuk and he gave a great idea to add=
 a
> > > > list of device_ids to dom.cfg, such as:
> > > > sci_devs =3D [ 0, 1, 15, 35 ];
> > > >=20
> > > > Using this approach, we can remove scmi_devid from the device tree =
and
> > > > just pass a list of scmi_devids to XEN using additional hypercall.
> > > > We can probably make hypercall taking devid list as input parameter=
.
> > > > This will take only 1 hypercall to setup sci permissions.
> > >=20
> > > But how would a user know which are the right SCMI IDs to add to the
> > > sci_devs list? Would the user have to go and read the reference manua=
l
> > > of the platform to find the SCMI IDs and then write sci_devs by hand?
> > > If that is the case, then I think that it would be better to add
> > > scmi_devid to device tree.
> > >=20
> > > In general, I think this configuration should happen automatically
> > > without user intervention. The user should just specify "enable SCMI"
> > > and it should work.
> > >=20
> >=20
> > Ok. This sounds reasonable.
> >=20
> > >=20
> > > > > In regards to linux,scmi_mem, I think it would be best to do with=
out it
> > > > > and fix the Linux SCMI driver if we need to do so. Xen should be =
able to
> > > > > parse the native "arm,scmi-shmem" nodes and Linux (dom0 or domU) =
should
> > > > > be able to parse the "arm,scmi-shmem" nodes generated by Xen. Eit=
her
> > > > > way, I don't think we should need linux,scmi_mem.
> > > >=20
> > > > This requires further investigation. I will try to make implementat=
ion
> > > > without linux,scmi_mem, using only arm,scmi-shmem nodes and share
> > > > reuslts with you.
> > >=20
> > > OK, thanks.
> >=20
> > One more question: As you probably seen - Jan had a complains about SCI
> > term. He said SCI is ambiguous with ACPI's System
> > Control Interrupt.
>=20
> I see his point. As a term I see "SCMI" often and sometimes "SCPI" but
> "SCI" is the first time I saw it with this patch series.
>=20
>=20
> > I think of using SC (as System Control) instead. What do you think
> > about it?=20
>=20
> Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" alone
> doesn't give me enough context to guess what it is.
>=20
> Or we could broaden the scope and call it "firmware_interface"?

ARM_SCI sounds good for me.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 14:22:13 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 14:22:13 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251392.432719 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lSL-0003Cv-1i; Fri, 24 Dec 2021 14:22:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251392.432719; Fri, 24 Dec 2021 14:22:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lSK-0003Co-Uz; Fri, 24 Dec 2021 14:22:00 +0000
Received: by outflank-mailman (input) for mailman id 251392;
 Fri, 24 Dec 2021 14:21:59 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0lSJ-0003Ci-HT
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 14:21:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lSJ-0003Y2-4i; Fri, 24 Dec 2021 14:21:59 +0000
Received: from [54.239.6.184] (helo=[192.168.17.79])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lSI-0008Eo-Qe; Fri, 24 Dec 2021 14:21:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Cc:From:
	References:To:Subject:MIME-Version:Date:Message-ID;
	bh=8MiMQbvRe+NnD47ORMnu3Ea+2iJd+/BTtV3oTS5Xb4Y=; b=xoAf+uo4XD5Iygv9XfYlH6nrUH
	zl3v8DLEVW9uxP75zaSFF7zVE3meiY2BR/WJkIW29rYjCEBmPZZw6H3RCIG79AcXR7I8aFXMlCfxD
	F9FaMtKMJGDURvdeABm58rzcyosuemyTBnRrtBdCYYAXyTn2nK21pzSypsy0w8lFWotw=;
Message-ID: <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org>
Date: Fri, 24 Dec 2021 15:21:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU
 Platform
To: Dongjiu Geng <gengdongjiu1@gmail.com>
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org>
 <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
From: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
In-Reply-To: <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

I am not sure why you dropped the others. I have added them back.

On 24/12/2021 14:36, Dongjiu Geng wrote:
> Julien Grall <julien@xen.org> 于2021年12月24日周五 21:25写道：
>>
>> Hi,
>>
>> On 24/12/2021 13:24, Dongjiu Geng wrote:
>>> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build failed.
>>> so fix it and make it can select GICV2.
>>
>> As I said in v1, last time I checked QEMU was only able to support
>> virtualization with GICv3. This is why we added a depends on.
> 
> I enabled CONFIG_NEW_VGIC, then it will use GICv2. In my check, it
> does not report an error.
> My QEMU emulator version is 4.0.0.  What is the QEMU version that you used?

I am using a more recent QEMU. However, I have always only used GICv3 
becuase it was IIRC there first.

> 
>>
>> If you want to remove it, then I think you ought to explain in the
>> commit message why this is fine. A pointer to the commit or a QEMU
>> version used would be useful.
> 
> OK，thanks. Can you check if QEMU 4.0.0 is workable with GICv2 on your side?

I don't have direct access to my QEMU setup at the moment. However, 
looking at the history.

So I would suggest the following commit message:

"
xen/arm: Allow QEMU platform to be built with GICv2

Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
complain about unmet dependencies:

tools/kconfig/conf  --syncconfig Kconfig

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]


It turns out that QEMU has been supporting GICv2 virtualization since 
v3.1.0. So an easy way to solve the issue and allow more custom support 
is to remove the dependencies on GICv3.
"

> It is workable on my side.
> 
> 
>>
>>>
>>> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
>>> ---
>>> $ make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j10
>>> make -C xen install
>>> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
>>> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig/Makefile.kconfig ARCH=arm64 SRCARCH=arm HOSTCC="gcc" HOSTCXX="g++" syncconfig
>>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
>>> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o tools/kconfig/conf.c
>>> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/confdata.o tools/kconfig/confdata.c
>>> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o tools/kconfig/expr.c
>>> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
>>> bison -o tools/kconfig/parser.tab.c --defines=tools/kconfig/parser.tab.h -t -l tools/kconfig/parser.y
>>> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/preprocess.o tools/kconfig/preprocess.c
>>> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol.o tools/kconfig/symbol.c
>>> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.o tools/kconfig/lexer.lex.c
>>> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.tab.o tools/kconfig/parser.tab.c
>>> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
>>> tools/kconfig/conf  --syncconfig Kconfig
>>>
>>> WARNING: unmet direct dependencies detected for GICV3
>>>     Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>>>     Selected by [y]:
>>>     - QEMU [=y] && <choice> && ARM_64 [=y]
>>>
>>> WARNING: unmet direct dependencies detected for GICV3
>>>     Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>>>     Selected by [y]:
>>>     - QEMU [=y] && <choice> && ARM_64 [=y]
>>>
>>> WARNING: unmet direct dependencies detected for GICV3
>>>     Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>>>     Selected by [y]:
>>>     - QEMU [=y] && <choice> && ARM_64 [=y]
>>> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
>>> make -f Rules.mk _install
>>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/XEN/xen/xen'
>>> ---
>>>    xen/arch/arm/Kconfig           | 5 +++--
>>>    xen/arch/arm/platforms/Kconfig | 1 -
>>>    2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>>> index ecfa6822e4..373c698018 100644
>>> --- a/xen/arch/arm/Kconfig
>>> +++ b/xen/arch/arm/Kconfig
>>
>> The change in arch/arm/Kconfig is not really related to this patch.
>> Technically the part in platforms/Kconfig is sufficient. I still think
>> the change is good to have but it should be in a separate patch.
> 
> sure
> 
>>
>>> @@ -35,7 +35,7 @@ config ACPI
>>>
>>>    config GICV3
>>>        bool "GICv3 driver"
>>> -     depends on ARM_64 && !NEW_VGIC
>>> +     depends on ARM_64
>>>        default y
>>>        ---help---
>>>
>>> @@ -44,13 +44,14 @@ config GICV3
>>>
>>>    config HAS_ITS
>>>            bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
>>> -        depends on GICV3 && !NEW_VGIC
>>> +        depends on GICV3
>>>
>>>    config HVM
>>>            def_bool y
>>>
>>>    config NEW_VGIC
>>>        bool "Use new VGIC implementation"
>>> +     depends on !GICV3
>>>        ---help---
>>>
>>>        This is an alternative implementation of the ARM GIC interrupt
>>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
>>> index c93a6b2756..6d3ee99456 100644
>>> --- a/xen/arch/arm/platforms/Kconfig
>>> +++ b/xen/arch/arm/platforms/Kconfig
>>> @@ -15,7 +15,6 @@ config ALL_PLAT
>>>    config QEMU
>>>        bool "QEMU aarch virt machine support"
>>>        depends on ARM_64
>>> -     select GICV3
>>>        select HAS_PL011
>>>        ---help---
>>>        Enable all the required drivers for QEMU aarch64 virt emulated

While writing a proposal for the commit message, I remembered that the 
goal of CONFIG_QEMU was to select all the required drivers to be able to 
boot Xen on QEMU.

AFAICT, if you start from tiny64_defconfig, you would not have GICv3 
selected. So we would technically break users of QEMU with GICv3.

I am not entirely sure how to approach it. I can think of 2 options:

  1) Use 'select GICv3 if !NEW_VGIC'
  2) Add a specific platform for QEMU new vGIC

I have the feeling that 1) will result to same unmet dependency issue. 
Stefano any opinions?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 14:29:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 14:29:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251397.432730 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lZ6-0003va-Rx; Fri, 24 Dec 2021 14:29:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251397.432730; Fri, 24 Dec 2021 14:29:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lZ6-0003vG-Od; Fri, 24 Dec 2021 14:29:00 +0000
Received: by outflank-mailman (input) for mailman id 251397;
 Fri, 24 Dec 2021 14:29:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0lZ5-0003ux-Vd
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 14:28:59 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lZ5-0003gf-JR; Fri, 24 Dec 2021 14:28:59 +0000
Received: from [54.239.6.184] (helo=[192.168.17.79])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lZ5-0000Ja-B6; Fri, 24 Dec 2021 14:28:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=UAjw+1yNEGAwd8pzA7NLntXxLkOccHYYoGXCPTI86BA=; b=SAsORDJgJrlRm9hK7gjz9Mgkz9
	dtM5RdvuGXpGEXUrX46K7bVriZkoXbwtAnLz7tbC1BCFxb7ilMvY/4j4sW5MqwSx+zU+iKFygTxlU
	/LyVCmecbSd8ugPVt0UliFfm4sI4b4LFu5/QF8J37ll7ytl7xDHv7wQanT2tMzqOV7Xo=;
Message-ID: <4bb8ee4f-8e8b-5e85-0801-ae3df93dbabc@xen.org>
Date: Fri, 24 Dec 2021 15:28:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <alpine.DEB.2.22.394.2112171709140.2060010@ubuntu-linux-20-04-desktop>
 <20211220181215.GA1702335@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
 <20211223190637.GA99855@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
 <437596a2-b375-fc79-a865-186f7eaf10a8@xen.org>
 <20211224135819.GA945512@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211224135819.GA945512@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 24/12/2021 14:59, Oleksii Moisieiev wrote:
> Hi Julien,

Hello,

> On Fri, Dec 24, 2021 at 02:29:13PM +0100, Julien Grall wrote:
>> Hi,
>>
>> On 24/12/2021 01:16, Stefano Stabellini wrote:
>>>> One more question: As you probably seen - Jan had a complains about SCI
>>>> term. He said SCI is ambiguous with ACPI's System
>>>> Control Interrupt.
>>>
>>> I see his point. As a term I see "SCMI" often and sometimes "SCPI" but
>>> "SCI" is the first time I saw it with this patch series.
>>>
>>>
>>>> I think of using SC (as System Control) instead. What do you think
>>>> about it?
>>>
>>> Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" alone
>>> doesn't give me enough context to guess what it is.
>>
>> I might be missing some context. Why are naming everything SCI rather than
>> SMCI?
> 
> Because we're expecting other interfaces and transport to be
> implemented, such as for example:
> scmi_mailbox, scpi_smc, scpi_mailbox, ti_sci_smc etc.

Oh, now that explain why there is a layer of indirection in Xen. It 
wasn't very clear from the cover letter why it was present.

> 
>>
>>>
>>> Or we could broaden the scope and call it "firmware_interface"?
>> How would this be used? Will it be a list of interface that will be exposed
>> to the guest?
>>
> 
> The idea is to set mediator type for each Domain, so for example Xen can
> use scmi_mailbox to communicate with SCP, Dom0 and DomD are also using
> scmi_mailbox, but DomU using scmi_smc mediator because we have only 3
> mailboxes in system. This is not implemented yet, right now, we are
> introducing only scmi_smc support. In future, multiple mediator support
> can be added to Xen.

Ok. So will there be only one interface at the time for a given domain. 
Is that correct?

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 14:43:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 14:43:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251401.432741 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lmR-0006es-5n; Fri, 24 Dec 2021 14:42:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251401.432741; Fri, 24 Dec 2021 14:42:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0lmR-0006el-0h; Fri, 24 Dec 2021 14:42:47 +0000
Received: by outflank-mailman (input) for mailman id 251401;
 Fri, 24 Dec 2021 14:42:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>) id 1n0lmP-0006ec-G9
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 14:42:45 +0000
Received: from xenbits.xenproject.org ([104.239.192.120])
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lmP-0003y2-52; Fri, 24 Dec 2021 14:42:45 +0000
Received: from [54.239.6.184] (helo=[192.168.17.79])
 by xenbits.xenproject.org with esmtpsa
 (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92)
 (envelope-from <julien@xen.org>)
 id 1n0lmO-0001LI-SV; Fri, 24 Dec 2021 14:42:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org;
	s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:
	References:Cc:To:Subject:MIME-Version:Date:Message-ID;
	bh=S+5gym/LnTvjBBuOf+Xmtpt8BFxcfTdmN0QuwwMR9zo=; b=MVlhVfJWPEm6U6k5TjmzVmK5EY
	MbqI3HfFn1XWp02qbxSHTk8xDvy2SWHiL162h66VSu+zFC0+mxOD/jAQkLjIHdv+nmkl+JugzCdK4
	uLpAa717Tw4m5mDm+fXe20xJ4D+Gqu/gER9+Bg3nlJHgwftgawtG1NkZKDrXIBaCsUg0=;
Message-ID: <7b0d3f0d-bdf1-ac59-0ef8-bb7ec2d802d8@xen.org>
Date: Fri, 24 Dec 2021 15:42:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.4.1
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
To: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
Cc: Oleksandr <olekstysh@gmail.com>,
 "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
 Stefano Stabellini <sstabellini@kernel.org>,
 Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
 Bertrand Marquis <bertrand.marquis@arm.com>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
 <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
 <20211217135855.GA4072899@EPUAKYIW015D>
 <7924e699-5e70-6fdc-8633-6a15894d66db@xen.org>
 <20211220154127.GA1688861@EPUAKYIW015D>
From: Julien Grall <julien@xen.org>
In-Reply-To: <20211220154127.GA1688861@EPUAKYIW015D>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 20/12/2021 16:41, Oleksii Moisieiev wrote:
> Hi Julien,

Hello,

> On Fri, Dec 17, 2021 at 04:38:31PM +0000, Julien Grall wrote:
>>
>>
>> On 17/12/2021 13:58, Oleksii Moisieiev wrote:
>>> Hi Julien,
>>
>> Hi,
>>
>>> On Fri, Dec 17, 2021 at 01:37:35PM +0000, Julien Grall wrote:
>>>> Hi,
>>>>
>>>> On 17/12/2021 13:23, Oleksii Moisieiev wrote:
>>>>>>> +static int map_memory_to_domain(struct domain *d, uint64_t addr, uint64_t len)
>>>>>>> +{
>>>>>>> +    return iomem_permit_access(d, paddr_to_pfn(addr),
>>>>>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>>>>>> +}
>>>>>>> +
>>>>>>> +static int unmap_memory_from_domain(struct domain *d, uint64_t addr,
>>>>>>> +                                     uint64_t len)
>>>>>>> +{
>>>>>>> +    return iomem_deny_access(d, paddr_to_pfn(addr),
>>>>>>> +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
>>>>>>> +}
>>>>>>
>>>>>> I wonder, why we need an extra level of indirection here. And if this is
>>>>>> really needed, I wonder why map(unmap)_memory* name was chosen, as there is
>>>>>> no memory mapping/unmapping really happens here.
>>>>>>
>>>>>
>>>>> I've added extra indirection to hide math like
>>>>> paddr_to_pfn(PAGE_ALIGN(addr + len -1)
>>>>> so you don't have to math in each call. unmap_memory_from_domain called
>>>>> from 2 places, so I moved both calls to separate function.
>>>>> Although, I agree that map/unmap is not perfect name. I consider
>>>>> renaming it to mem_permit_acces and mam_deny_access.
>>>>
>>>> I haven't looked at the rest of the series. But this discussion caught my
>>>> eye. This code implies that the address is page-aligned but the length not.
>>>> Is that intended?
>>>>
>>>> That said, if you give permission to the domain on a full page then it means
>>>> it may be able to access address it should not. Can you explain why this is
>>>> fine?
>>>>
>>>
>>> The idea was that xen receives some memory from the dt_node linux,scmi_mem,
>>> then we split memory between the agents, so each agent get 1 page (we
>>> allocate 0x10 pages right now).
>>
>> Thanks for the clarification. Does this imply the guest will be able to
>> write message directly to the firmware?
> 
> We used DEN0056C Specification as base. Available on: https://developer.arm.com/documentation/den0056/latest.
> SCMI transport is described in Section 5.1. We implemented Shared Memory transport.
> Firmware has N pages of the shared memory, used to communicate with Agents.
> It allocates N agents and assign a page for each agent, such as:
> -------------------------------------
> | Agent H | Agent 1 | Agent 2 | ... |
> -------------------------------------
> Agent H is the privilleged Hypervisor agent, which is used to do the base commands,
> such as getting Agent list, set\unset permissions etc.
> Hypervisor assign agent to the guest and maps page, related to the agent to the Guest.
> So the Guest, which is Agent 1 will get an access to Agent 1 page.
> 
> Guest places SCMI message to Agent 1 memory, then sends SMC message.
> Hypervisor process SMC request, add agent id to the message parameters and redirects it to the Firmware.
> Based on the agent_id Firmware knows which page it should read.
> Then after permission check ( if the resetId/clockID/powerID etc from message
> is assigned to agent_id ) it does changes to the HW and places response to Agent
> shared memory and marks channel as FREE ( by setting free bit in shared memory ).
> Once channel is marked as free - Guest read response from the shared memory.

So, IIUC, the hypervisor will not control what is written in the shared 
memory. It will only control the SMC parameters. Is my understanding 
correct?

> 
> Non-virtualized systems will work as well. OS should send SMC directly to the Firmware.
> 
>>
>> If so, this brings a few more questions:
>>    1) What will the guest write in it? Can it contains addresses?
> Guest can write scmi request to the shared memory, which include the following data:
> 1) protocol_id - which protocol is requested, such as clock, power, reset etc
> 2) message_id - action that should be done to HW, such as do_reset or get_clock
> 3) message data - which includes reset_id/clock_id/power_id etc. that should be changed.
> Reset IDs and Clock IDs are assigned in Firmware. Guest receives ID, corresponding to the device from the device-tree.
> dt_node as an example:
> &avb {
> 	scmi_devid = <0>;
> 	clocks = <&scmi_clock 0>;
> 	power-domains = <&scmi_power 0>;
> 	resets = <&scmi_reset 0>;
> };
> 
>>    2) What are the expected memory attribute for the regions?
> 
> xen uses iommu_permit_access to pass agent page to the guest. So guest can access the page directly.

I think you misunderstood my comment. Memory can be mapped with various 
type (e.g. Device, Memory) and attribute (cacheable, non-cacheable...). 
What will the firmware expect? What will the guest OS usually?

The reason I am asking is the attributes have to matched to avoid any 
coherency issues. At the moment, if you use XEN_DOMCTL_memory_mapping, 
Xen will configure the stage-2 to use Device nGnRnE. As the result, the 
result memory access will be Device nGnRnE which is very strict.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 16:09:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 16:09:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251407.432752 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0n7l-0008JM-Cm; Fri, 24 Dec 2021 16:08:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251407.432752; Fri, 24 Dec 2021 16:08:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0n7l-0008JF-8G; Fri, 24 Dec 2021 16:08:53 +0000
Received: by outflank-mailman (input) for mailman id 251407;
 Fri, 24 Dec 2021 16:08:51 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0n7j-0008J5-G4; Fri, 24 Dec 2021 16:08:51 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0n7j-0005sh-Bt; Fri, 24 Dec 2021 16:08:51 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0n7j-00082x-0X; Fri, 24 Dec 2021 16:08:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0n7j-0001vl-04; Fri, 24 Dec 2021 16:08:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sRC6ekIrP+iswaze3VBzmMsXA21A+65QhFhHG0LtnhA=; b=4pZI6VekF6DKkylUGgQTNTxq2R
	fC2Cy0f9cBdyrf2bMfHOwc5mvhq/J9fDmIwNZ+7VuuWcOkS+xH61IOZ6Ht0P4lvIXTk5lU8BoECLO
	tM6AWus7DOk4LgYY80uroCyXsILymm6yBiUqbMMCp25LlQaofIGhc/pYNP4JTHKk5Z2s=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167534-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167534: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=89f3bfa3265554d1d591ee4d7f1197b6e3397e84
X-Osstest-Versions-That:
    qemuu=1bd88c4542e97f49955c142f8dc04dd32df9e91f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 16:08:51 +0000

flight 167534 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167534/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167530
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167530
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167530
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167530
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167530
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167530
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167530
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167530
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass

version targeted for testing:
 qemuu                89f3bfa3265554d1d591ee4d7f1197b6e3397e84
baseline version:
 qemuu                1bd88c4542e97f49955c142f8dc04dd32df9e91f

Last test of basis   167530  2021-12-23 20:08:11 Z    0 days
Testing same since   167534  2021-12-24 04:28:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Paolo Bonzini <pbonzini@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   1bd88c4542..89f3bfa326  89f3bfa3265554d1d591ee4d7f1197b6e3397e84 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 16:49:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 16:49:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251429.432763 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0nkp-0005Ji-KB; Fri, 24 Dec 2021 16:49:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251429.432763; Fri, 24 Dec 2021 16:49:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0nkp-0005Jb-H9; Fri, 24 Dec 2021 16:49:15 +0000
Received: by outflank-mailman (input) for mailman id 251429;
 Fri, 24 Dec 2021 16:49:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1uFu=RJ=epam.com=prvs=2992704931=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0nko-0005JV-KV
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 16:49:14 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6b857e82-64d9-11ec-9e60-abaf8a552007;
 Fri, 24 Dec 2021 17:49:12 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BOGhYiZ021471;
 Fri, 24 Dec 2021 16:49:08 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d5hd602rq-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 24 Dec 2021 16:49:08 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PR3PR03MB6650.eurprd03.prod.outlook.com (2603:10a6:102:7d::15)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 16:49:06 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 16:49:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6b857e82-64d9-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=nYF+BQdT2Vf1gKw7oyYmqnXE0kJx0YsnGHLmN/REfPwD9mKpzqUCxTHL7WTmNAGslPHvaZvDGddoyfLFxV3kLnKhZUy8TQaK36w2seYSEeAveu1c+r02A5hs8IRDkHpo+6JnB79e/dAAbmW2ATrEVNsIYdvunr9K+ZENowKZ1tg/ulSetSu9XNOhhldW62ySi2iV0mkmC4YakUf/1o5osE3zPsGotZbN9hwAqFfxgDR3cov3j4eV+5dp68mwG1mBmkIiVkFsZTxVyM7wOqkhB+xZ3fxW4qjwocP+VCG+X037Jrw+7xhtzonSpxy/XKT8Uxgv7vQicZ7XFRxzKHB6+A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=uFhv5e8SmBpUDZMBw1w8SolLmCMpO1vwdnw5mJXfyik=;
 b=RYXoAM+vqw/mQ2dB7Q69Rw4xoHl2LCeEW152TMre+82wSwKY7TU/fJByZCOMyS8zIXfIFIf8R9K8l2XFbUmynPB11W3XLzIzm/0bj4Nfm2zXw0UKhtUZzIWZOsmWtG0OvS6aoFKk37H7/Jla3javLvzNsmrxQpPpcTEIEW/U0dgk/ciELrgdN1TDEM+GxpD++cv+7Ny/GYPxJ+USG1GL4AJOEqIMdb7G1bRSbvHDoc3FTif7o7SjEMPWYv4vngAYunPvvM/jldCMZ13vbg2YiZVEPQXPTgKMlt2VPpAX5BcUxX6NqYS2/eE5j8bgtTQqhXZdjd03E+OJE9LMiHAsTQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uFhv5e8SmBpUDZMBw1w8SolLmCMpO1vwdnw5mJXfyik=;
 b=mpPP7WGtSS2vdBJxppIShzYIN5ggKHbd49UsCfQ4KilF8vib7QzyymTA7IXCAekZNPEkojmnfunzh9IgeHjX/CestTxt4EOEa7Mik8fY/59f8mzJcidfacTU+SDGp7RJf0fZRv45fB/Us82yPsEhWUiKefGbyX+WrygOCL/Ua/Rd2y/87oIFwwdJby1oOpWZzRHfmhxeHK5f5kdsWF9k++9oK/4NIFYMKpFxA+Fu9qaRGzbb+mKblnN17LWX98YjvywQj9PkK3WPQD+nyYX4GFpA+LhfqflR5kFiYM0PgyJFJh/BrZqSb674PjfkOLmzlQHrgWrfAILZJTlohOAi2g==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Stefano Stabellini <sstabellini@kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
        Volodymyr
 Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis
	<bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw3iHyAgAQwJICAAG+xgIABQZuAgAAWSACAAOV/AIABANAAgAEYTICAAFamgIAA3WqAgAAIW4CAAAhUAIAAJymA
Date: Fri, 24 Dec 2021 16:49:06 +0000
Message-ID: <20211224164905.GA1016129@EPUAKYIW015D>
References: 
 <alpine.DEB.2.22.394.2112201613210.2060010@ubuntu-linux-20-04-desktop>
 <20211221200305.GA2460476@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112211310000.2060010@ubuntu-linux-20-04-desktop>
 <20211222110414.GA2883815@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112221627190.2060010@ubuntu-linux-20-04-desktop>
 <20211223190637.GA99855@EPUAKYIW015D>
 <alpine.DEB.2.22.394.2112231610270.2060010@ubuntu-linux-20-04-desktop>
 <437596a2-b375-fc79-a865-186f7eaf10a8@xen.org>
 <20211224135819.GA945512@EPUAKYIW015D>
 <4bb8ee4f-8e8b-5e85-0801-ae3df93dbabc@xen.org>
In-Reply-To: <4bb8ee4f-8e8b-5e85-0801-ae3df93dbabc@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23817fcf-de48-40d4-3832-08d9c6fd4cb9
x-ms-traffictypediagnostic: PR3PR03MB6650:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PR3PR03MB6650BA7F7DC4F3E4AFBE067CE37F9@PR3PR03MB6650.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 SooRI84PrZ3jmTb8ajoEozvo4DrG+lcHQ3T3JTLJqM4zsceL7FRvkq9uwQbp0wgrxHbim+2KU66DNKHjVqsOyWuFZ9YV3M0ad/akPTvDoJWEtyY2r7g3fr+M+cABx25GlE74KZHBMKwaA6k+BkgH+kHrVa4OzpkRCI8DElmblBAN6aSDtM2yct4u/dTLxZ1R5GJzlB3e0cmhWgxAeSPzEJpaQ+m1agXmZzNTUqmVI67orM7OgMTGFzXpp3tw8PymPGrnnD5vGSea0IekKfk4uhhqG8WUGypuy+y7XaNumb1Gy7q9VFY/IQzVTVnICYyPvgqopP9xyhveFIJKyBf5ET8ZdvhUt4KxN1dRIwyz5zq44CAQeBxfE4wdBDE/eDH1xcWzmoG27vyGy95fkO+aLWXGictLQLGiJBBsdSuJVJc1aU4pJcslRcgb1oEr+o5Ga3eQ7uJhxc9RaWblGUEQqUOfl/xWOA/oZtVZL7yEc7foAc/vn1XGs1iD6qwvsCXX4RS+boGw8VXS7zdj0Y5gUTW0jsv+ZomQAkm2Auluy5Ez0GcvAFCXTUlleq2tzH3oauyMWiag0n5p2gM+Nk5IQAyhb+0SPSznoT/HCk+uhKq+SuBdcT8vcmCqiffI2P2wW4i5ywVVF7DZrCFzePMw5EnPyG2Njns9hcCR4tkIbxGiM0pUI6Hl0lujRN19CT/2zKb5cvVoysK/EDGRMJxHfKS/7XRa9vsqfFECpK+iatg=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(33656002)(71200400001)(38100700002)(4326008)(6512007)(54906003)(6486002)(6916009)(33716001)(9686003)(508600001)(122000001)(2906002)(83380400001)(5660300002)(186003)(8936002)(53546011)(6506007)(66556008)(66446008)(64756008)(1076003)(91956017)(86362001)(76116006)(316002)(26005)(66476007)(66946007)(38070700005)(8676002)(21314003);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?B/Nnks4NZMFxGZE/8NYTN8IHdyBxlqKldvIOfwiEFWSLFeKuHvZub8qvPkS1?=
 =?us-ascii?Q?+04+vIZ3mGW74gSiKZRorMZ6bKFMPjp93+9RGAmrionFjZLhqHwpiDdvYsLL?=
 =?us-ascii?Q?ednKu0TBfUHWGfPlQPf1emZaMzW9o7eJZzGz4i6wn+SyrYwuZy/10aI7byGy?=
 =?us-ascii?Q?SSUmxVdD7Mm9ikMWeE6sOX7OAv3i9Fx1lPZXwvO+x3oX2QzUvrdyQ3Lx8WI/?=
 =?us-ascii?Q?eDBuzUz3n4lFTB+Mjv3Y3gLgXMUdxhH4L2PqV5lIgqYizqDIptQtYk5evypX?=
 =?us-ascii?Q?t2vlbbnbK0MGlhOY2LiIe0v6xp5d58hDkb/k74H+V2QuIpxREdPRJ69tJ6f6?=
 =?us-ascii?Q?EB7u6f8yx8Xu0qW+RdwLublthnJcJf1xCIAnMFBCQKO1J2M+IejQt+XOUpU/?=
 =?us-ascii?Q?W+3AjEZ3upBOVQUNeYWIPgYRegDtZtl4XT7cnBe8kCQNx1bXoPfLu1auUIBZ?=
 =?us-ascii?Q?bfb5lo7dma55IMibGPB9IsatpKzRe5HsBe4PovkFXH3xeZS/lecwPdmZjREg?=
 =?us-ascii?Q?apzXXRIhwGtrzTCMKUQYxVEV9OPqTbTIGZcXu3Eq2tdJtoJetLlHKV8TMN8L?=
 =?us-ascii?Q?vER1mH46nKdxLuzNQ/+ZqckgkG88fX4uNNueXbSgIlRD99k2hca71pW1LsfR?=
 =?us-ascii?Q?1TvOrWWbElYKoFzq5EhwVd/d+/pTWMOLVZLvFqtngyPZUGnWQBGlw+HTq3Bg?=
 =?us-ascii?Q?KBB6kYaSSvmDoN/KhKjwVG9Eham2RtPCMs0Lua42Y+gXt3pNBOjJwedPYb4D?=
 =?us-ascii?Q?Ic9rUCrKHgYexUueforAFklcNalCpW2HQVqJf+TzoowIhcYtSteqf9cQ/KWO?=
 =?us-ascii?Q?VlETr06V0funbIkoqQHgWbK2irqY8Z/F1sfjVmiaCGM3VhchiV54DILPvCtc?=
 =?us-ascii?Q?uWqA80HtEOluALDePPMFxyqfl3Z/3qIJjcyfQ5h4H2S0l4eLXWUPzpHip2V6?=
 =?us-ascii?Q?sL3yMbOTR23Z7Dj8fWqPUNG+osJyRjmy8h5jzCxCsLe7PfyqW7W+RPA/wKSh?=
 =?us-ascii?Q?4Fs7t1S37o6vYTBcP9swLpzhUkbdUGTvDQzwmr4LU8uGydERbbsCPsjIo/oR?=
 =?us-ascii?Q?yJk9fMcodGVhtI4835A7buOv+OdcdUaaCQ1TRncqEPedsNKtRpoO6Z6PPIck?=
 =?us-ascii?Q?vIHIp1DscnveF0IFFJCipDe66Y3ykKpv4I1ac5HZuRPymp9MS2lqTD6O2k0X?=
 =?us-ascii?Q?I7uZVOt6/ARlFoFAyzdUT8E6QU8/4ReY/U1/CCOGAjh0S95RV4AbntXYCgiK?=
 =?us-ascii?Q?dPq3xjfVehJQ6wnlcMIKauptMOn9KoHUOQJCkYWL3o6KD89S2j1U0D4+1491?=
 =?us-ascii?Q?57mmVN/NgG874B8iknI9Nql99ydSDGIoWDTbZ9z6P3wxoUoLCOw5Fb+bLfW1?=
 =?us-ascii?Q?u7XL2cfU+GFshonaB/rCN5rKHIneE+2SkLrWMQLyqf+5JUh4sru/JhACAba4?=
 =?us-ascii?Q?wZQVRoFZX3lvqoFGFD6vp5HXcLZfSgWTeeKV4Qv+eCfJlN4WOlg7tEGnhBgR?=
 =?us-ascii?Q?tApl3n0vfwf5BygQ/Wg42EdyItkIJAnz8qy2EC0sBIHudpJtUh+T/ZDaKXjq?=
 =?us-ascii?Q?JGusG/DHmq3hcema8kg9Mzt4TjLI+d2GPuzdZ0jWkor3J9LU3pGdSK+MJaqC?=
 =?us-ascii?Q?KgV5lmCRaNIE5QYyMMPxVzfk5H9xUwI+X/r44E6/X7Uxm8JSi0bvCOuebn4C?=
 =?us-ascii?Q?SLGFx5d3vZwdBFZchD1I2EaKBGQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E5FFF28FF477D74CBDF612A728254D7A@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23817fcf-de48-40d4-3832-08d9c6fd4cb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 16:49:06.5087
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ng8h9mQ006wdxwfZCW/R4JB7CVcV0N4wtbQkDY6MVZoe+L97LYKoSR/sUCp4hI4oCFMPstZGYp8GUnzSQPupW/iek1MDqcYtF4VGAmaKPMY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6650
X-Proofpoint-ORIG-GUID: BdGsWz5MIEpVa85SzB1L8b6PSPbOyGYN
X-Proofpoint-GUID: BdGsWz5MIEpVa85SzB1L8b6PSPbOyGYN
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-24_07,2021-12-24_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0
 mlxscore=0 adultscore=0 priorityscore=1501 clxscore=1015 malwarescore=0
 bulkscore=0 mlxlogscore=648 impostorscore=0 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112240081

On Fri, Dec 24, 2021 at 03:28:56PM +0100, Julien Grall wrote:
>=20
>=20
> On 24/12/2021 14:59, Oleksii Moisieiev wrote:
> > Hi Julien,
>=20
> Hello,
>=20
> > On Fri, Dec 24, 2021 at 02:29:13PM +0100, Julien Grall wrote:
> > > Hi,
> > >=20
> > > On 24/12/2021 01:16, Stefano Stabellini wrote:
> > > > > One more question: As you probably seen - Jan had a complains abo=
ut SCI
> > > > > term. He said SCI is ambiguous with ACPI's System
> > > > > Control Interrupt.
> > > >=20
> > > > I see his point. As a term I see "SCMI" often and sometimes "SCPI" =
but
> > > > "SCI" is the first time I saw it with this patch series.
> > > >=20
> > > >=20
> > > > > I think of using SC (as System Control) instead. What do you thin=
k
> > > > > about it?
> > > >=20
> > > > Yeah, I am not great at naming things but maybe "ARM_SCI"?  "SC" al=
one
> > > > doesn't give me enough context to guess what it is.
> > >=20
> > > I might be missing some context. Why are naming everything SCI rather=
 than
> > > SMCI?
> >=20
> > Because we're expecting other interfaces and transport to be
> > implemented, such as for example:
> > scmi_mailbox, scpi_smc, scpi_mailbox, ti_sci_smc etc.
>=20
> Oh, now that explain why there is a layer of indirection in Xen. It wasn'=
t
> very clear from the cover letter why it was present.
>=20
Please see below.
> >=20
> > >=20
> > > >=20
> > > > Or we could broaden the scope and call it "firmware_interface"?
> > > How would this be used? Will it be a list of interface that will be e=
xposed
> > > to the guest?
> > >=20
> >=20
> > The idea is to set mediator type for each Domain, so for example Xen ca=
n
> > use scmi_mailbox to communicate with SCP, Dom0 and DomD are also using
> > scmi_mailbox, but DomU using scmi_smc mediator because we have only 3
> > mailboxes in system. This is not implemented yet, right now, we are
> > introducing only scmi_smc support. In future, multiple mediator support
> > can be added to Xen.
>=20
> Ok. So will there be only one interface at the time for a given domain. I=
s
> that correct?
>=20
Correct. The idea is that we provice only one interface to the Domain,
so different domains can use different protocols and transport. Those
interfaces can be different than the interface Xen uses to connect to SCP.
This allows us to vary the configuration. So for example:
Let's take system, that support only 2 mailboxes and communication with
SCP can use only mailboxes as transport. We intent to use scmi protocol
to manage HW. In this case we use 2 mailboxes for Xen-> SCP
communication, and for Dom0 -> Xen. Domu can be configured to use
scmi_smc, so the communication should be the following:
DomU --smc--> Xen -mailbox--> SCP Firmware.
Let's say we want to add DomainX with OS XXX, which using yyy protocol
with zzz transport. Then we can configure DomX wuth yyy_zzz mediator, so
the communication will be the following:
DomX --yyy--> Xen -mailbox--> SCP Firmware
Where Xen knows how to convert message from yyy protocol to scmi protocol.

I considered the alternative way, when we can configure domain with
several mediators, so each Domain can be configured to use, for example,
scmi_smc for power-domains and scpi_smc for clocks and resets. But I
don't see real use-cases for this configuration.

What do you think about that?

Best regards,
Oleksii=


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 17:03:02 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 17:03:02 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251433.432774 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ny1-0007oy-RO; Fri, 24 Dec 2021 17:02:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251433.432774; Fri, 24 Dec 2021 17:02:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0ny1-0007or-Ne; Fri, 24 Dec 2021 17:02:53 +0000
Received: by outflank-mailman (input) for mailman id 251433;
 Fri, 24 Dec 2021 17:02:52 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=1uFu=RJ=epam.com=prvs=2992704931=oleksii_moisieiev@srs-se1.protection.inumbo.net>)
 id 1n0ny0-0007ol-Ko
 for xen-devel@lists.xenproject.org; Fri, 24 Dec 2021 17:02:52 +0000
Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com
 [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 538efbf1-64db-11ec-bb0b-79c175774b5d;
 Fri, 24 Dec 2021 18:02:51 +0100 (CET)
Received: from pps.filterd (m0174681.ppops.net [127.0.0.1])
 by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1BOG3mmE029023;
 Fri, 24 Dec 2021 17:02:47 GMT
Received: from eur05-am6-obe.outbound.protection.outlook.com
 (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106])
 by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3d5hd603vs-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Fri, 24 Dec 2021 17:02:47 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23)
 by PA4PR03MB7231.eurprd03.prod.outlook.com (2603:10a6:102:be::19)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec
 2021 17:02:44 +0000
Received: from PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6]) by PA4PR03MB7136.eurprd03.prod.outlook.com
 ([fe80::85d2:c8aa:2196:21c6%9]) with mapi id 15.20.4823.021; Fri, 24 Dec 2021
 17:02:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 538efbf1-64db-11ec-bb0b-79c175774b5d
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=J3nFSQdhh3GkodloOk49Gd+t6j0l/uq0LnHhXtlW3P1jThLdUmW13sagC/b7xeSpAtUhtwNHFcP436MSCtBWmA+2EHcMbAD6cF48reNfyZLJ/1qfeBXOuaoVMHzsvNuVKlpIS3bAgXaJIVfHT5vpr4itdwP3LdfULbo7n1h4RvZVaSSl3IieXbaRq2ZmY4uACHusQmXVqQyBumCdqMrtMGLs61grILKFNcxGTtbhY4AiF/dUAQH8w7ISZUpI26NAOZcrpk7VJp/fufor1s9g8cKRaWPf1W7GrHDGUzGS3PXncePQzC5drH+Z3LGj9J3cUiRqgwD2pWHykhw/2zd7ZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=PG3pXakUTIbz5hpSxVpDtPPy5aq71dSI9uEKlO80ggQ=;
 b=UYjMVETxXg9ROM4oUnWmiEYRMWEPDe2eEDjs1W/3bLTW2yGKa+EvEqLVn1f91as0RdZ6BQi5Jpm5k9Vy/wM4DhiFYoPYB84/fGuJgpP50DVDryudLLYj8M4VDHLF/OzudnKBJUtLo10wYHD4GeX4sTCqhEb0eKryNTEYLeMUjtRahIEPDNjnz4tJwnEUHSz2UAMjhvqeweIncGLBD22fbjRllqF7ZXVybSREeDkJpOilcaBa9BKxWrxBUsEMhP9Z/DgzUmOH0IZNKrDa1VZy8SIXwCejH4dSiL41QamrlHUyerzX9uu7T7h7AHBXmOGcPmPQklN8ceXEEtDmNgXQQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com;
 dkim=pass header.d=epam.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=PG3pXakUTIbz5hpSxVpDtPPy5aq71dSI9uEKlO80ggQ=;
 b=TIhNoFckuUQtSgt0pqOu7wX2xP/dxDRD794StOVjpdfspgm/iH8aoPB2V9odq5Rw/XsrB2v9wrgxNabJdbm0jYoCgWt08CCvNJ0WwBX5ztQcVkdCjN3ENBh2dPf3LHHjaHOsv9hQmGJAO2sw9VUoA3SxMSvdNw+1e8i9JG1dKkfRrtwqgcmEjtSHgW6VymgYg5/gi0i51/69Xs26iuq1ZAjc+EcI5KYb5L4hs34IKIIk9fXflFcWzdNNbhKjuniApvfnZ+vTeTk07FFEByGQqdW02GFDx8QV5wykZ9BZ7GaFe5ZnQs+XcIKsy9pbMwrcYATCuoijmnGPzZLX/LEooA==
From: Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To: Julien Grall <julien@xen.org>
CC: Oleksandr <olekstysh@gmail.com>,
        "xen-devel@lists.xenproject.org"
	<xen-devel@lists.xenproject.org>,
        Stefano Stabellini
	<sstabellini@kernel.org>,
        Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
        Bertrand Marquis <bertrand.marquis@arm.com>
Subject: Re: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Topic: [RFC v1 3/5] xen/arm: introduce SCMI-SMC mediator driver
Thread-Index: 
 AQHX8M3JF7Ng56/tV0+8/7pODiaWfKw2ks6AgAAeBwCAAAQPgIAABfaAgAAsl4CABKcNgIAGOOkAgAAnH4A=
Date: Fri, 24 Dec 2021 17:02:44 +0000
Message-ID: <20211224170243.GA1022822@EPUAKYIW015D>
References: <cover.1639472078.git.oleksii_moisieiev@epam.com>
 <e9dadd96aa5b64b9232e10a083ce393af620adde.1639472078.git.oleksii_moisieiev@epam.com>
 <51104b62-14a1-79b8-1184-4f4d8418a2f6@gmail.com>
 <20211217132304.GA4041869@EPUAKYIW015D>
 <04263b01-85a1-a6cf-9c36-a31629caef12@xen.org>
 <20211217135855.GA4072899@EPUAKYIW015D>
 <7924e699-5e70-6fdc-8633-6a15894d66db@xen.org>
 <20211220154127.GA1688861@EPUAKYIW015D>
 <7b0d3f0d-bdf1-ac59-0ef8-bb7ec2d802d8@xen.org>
In-Reply-To: <7b0d3f0d-bdf1-ac59-0ef8-bb7ec2d802d8@xen.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: fcb5befb-b2af-4d14-7074-08d9c6ff3451
x-ms-traffictypediagnostic: PA4PR03MB7231:EE_
x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr
x-microsoft-antispam-prvs: 
 <PA4PR03MB7231D5DC68103964E104AD26E37F9@PA4PR03MB7231.eurprd03.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 B/UnAAx7tKUiZEwaZyfutlNpLOaHIhmoq8d02qh9U3b4H0j/ZlR4LhCcLkePIgKOby8ZchW0YEVZ0VSOMFHldXSUO6r3hrKXk1SLACQ6lfsM1aGkavbLylwRpFKtKGnssIMP6jZDiBWQn0CiOaXqHKWIPfU/HFgMssIC3NIULYRGYGTvcnmWKpdffZ7VjoDbqrl2c39JILcd7KIyukoXDk6xsiJH865YIHfPJcTEC19hC31lkiGFIGVKaR+8NIv6ee6+CuN0Mpim09TSjmHNsQGWY5WuARML2U/buWIG9GByNu95NuTkbepwxUhpUDWJmMA1m6Uwlae7Zd4JMsPKEoZMchf1LLGasjwA7Xlalrr4t5Br73IE+SsGhFLibe+iKfgo/6dGDUtW93onqcqKLRb5pEOr7hC8P7Ffy8c8PSngOen2NvDptq7qwrZx3pcETF7cvAKpxKdCHOL+bPrmee/1pCjsEabHepJy7mJfuFVE8xgHdrqHqbpO4fiaI8ZmLjwGYhH12ikSwM6ndJKSB4aCgwRmak4q1i4BmxPrRKDh5sh13jDX01U0ELtxlVGH2R0obn7BWenTiDeiNGXZIuVWqcRbeAcu81xgQIG2gmp64UH7ujb/ZR9mspFQaqAfprVTlo4lRjRWlMrsIwvAFK/Buv2xiUfmovGC3D1GCaio/T1N2amkD16sFyQJX2EEp89Rh9jC079ksVQyqYV5qZCg8H4yNX+CMYgsEJDto7GRtczbuHu98Tvy53U5NqLbNfqvVjp3D9e/KC0Djng0JDuYwh3AMqxUpoLjQT106B4=
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(38070700005)(38100700002)(122000001)(2906002)(6506007)(83380400001)(54906003)(316002)(66556008)(66946007)(1076003)(76116006)(86362001)(33716001)(4326008)(91956017)(508600001)(9686003)(66446008)(26005)(6486002)(966005)(5660300002)(71200400001)(8676002)(186003)(64756008)(53546011)(66476007)(6512007)(33656002)(6916009)(8936002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?/TN1TruXWYzn2PEqt2wRUeIhI/mcbcFaYbWOG8ephAn2P/W96HuNPFStRUqM?=
 =?us-ascii?Q?fkFZMhP9jig+HaPLWbf/QmtbtKh/TeSjaXgwg8ivFCTcPT0BBV01j/CchXyd?=
 =?us-ascii?Q?QeqKOVr+l4VJoWxC+/nD8pe8DSApZItlDsfNy0hQS/2s3gDS8Huw59SRDsA+?=
 =?us-ascii?Q?PnK2m544+XV5N6CGYFvkmHAM2ra6Xo7RoUDDV7S8dF1ZzZml+BndoWoyUrLm?=
 =?us-ascii?Q?EpjhC92JRH/bW56tJWG2XwAh5tiDAhR7B2cmYtALVhBMeOK4snjvDHx30nSo?=
 =?us-ascii?Q?kwVCl4rcHKvQVx5GbQO58oZ1J3eLW6m/fOxEcaW7+qSXUVTVwUld6XvuLFsh?=
 =?us-ascii?Q?VWyDB2YMoEOnI/hyWeO+4v86WrDyXxbIQ6lPEnUPJO5n1p6vtxPTsVoIw5jh?=
 =?us-ascii?Q?2zZPvz66jcqWtFcYSnqWTc1t813/FHJ69NOfhvzjsCGCY8kYLB90to4Mn3rg?=
 =?us-ascii?Q?v/Ig5mt5XaB3Az9MJe8S016Uz8w1X2fc+LOaahjyrRparPGIlcZMI2UajmGt?=
 =?us-ascii?Q?tXnoEdPPmunRuSjU4AcniCxPf3t4NMYKepVtbMExbpNB6WCotc9F45j12txj?=
 =?us-ascii?Q?WXV3nR9hYDmjljuXeItmyG0h2hgoM8yWxqrNzf/Q7hV/F4DhR46+7SouSeLB?=
 =?us-ascii?Q?pKKvLb2tuHuTT5iW/eaHUZDswsSM0eJWo4VsxCtnV5ni6FGDn8bQsIu1iNXk?=
 =?us-ascii?Q?rckINvPmr8CtAN4XBF3k0wG+JeJ2sUX91GO7k3mWurR6FVqgnLDG2A2U3GGp?=
 =?us-ascii?Q?4idGIUmCc8PhPSxFyrvQlLb92/SHTqAol7m5x1ZgcC9vhafDN90u4zXPDZz9?=
 =?us-ascii?Q?JmF30n1F2VDMXY+a9c8PBORZkhgG80vA8LCmwqVnSE8AxFpYjsp1rMMl1bWk?=
 =?us-ascii?Q?l/F/fNKaJUSkA3349S04DNVcmUrzbv9auXjR7EGU84BNE9WuDzG46EbwJREO?=
 =?us-ascii?Q?DeUOvlEhDQw3jP8BvU8fitpLCO1m1l1QeEBIXw4lalm6qc2FDjEclIuvJ1dd?=
 =?us-ascii?Q?zbkq82h0WsUIWkTguGspfoXwqHIKixv4fVaAOOiT5+Wqy+6nMQc6MrpwRqrb?=
 =?us-ascii?Q?StJB6/3ABV8l1oJ7+/QrTnjmfZb9tYlBfawBY/JeO76yUF+nIgFd8GlA37jA?=
 =?us-ascii?Q?TJ6PMDxDXKlwBkwp2ib6PF2OGIuplbK0wjLCBwN+JuhGLReN4uXRWNG7B+Rl?=
 =?us-ascii?Q?O5POMXzVzglJ7/RQD8FeVlBFztVUuXdl+xvEhsasnb9iXdsg0VXx6bPZEwKO?=
 =?us-ascii?Q?VUPAWek6opqQh7QgA5XcAB65c2EpeG/x2OXMUwDCWGD1iEdbdmhqLSp+L1i4?=
 =?us-ascii?Q?X2SG9akYoRJCT2Q0DyDGT6aLA2IvxodzshLSeE8ZXHGMAnkgv1iRm3FXj1Aw?=
 =?us-ascii?Q?P0vTajuVXYW7Z4KMF62d/lxCODqnlio1EryF4+n4K8EFa8RUd/gioynQ8qpJ?=
 =?us-ascii?Q?6WsKbJhnB1nx3514pDe3po6UJtYX5P71joDv963WAz0CLifKz6LNADh/RBFv?=
 =?us-ascii?Q?gauoboZJekrdPGbZgwytrL6d3IWXRBjSWbGKeRlQXIrL9LA2+aSgV+VJVKrD?=
 =?us-ascii?Q?gePusfhB/ujDJV5kV4mHXTpn3wOZMVKxvDYMEdy0q9TJMfKPLdRB/FOV5CtS?=
 =?us-ascii?Q?rvjwqf8uA8msscH6IIroiZJ7LqFB1ytw7yOihhP+BZ/Gq7JXJTK+3uwyhYdE?=
 =?us-ascii?Q?VQ5xfR3bjvCkytGNEoTksgwkFRY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <507343ED772DC04EA52A8B775DB38E7E@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcb5befb-b2af-4d14-7074-08d9c6ff3451
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 17:02:44.3835
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pRNVtV5DPTxVJ2z682cbTPmcFdIHjX1MX/R69f9xegMSLNx68EdDta744xjJ7VaiHkYjMFWmnMGyKTGKQM+EaEStUEB3Izp9t5Gqh3QCH1k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB7231
X-Proofpoint-ORIG-GUID: 5HOx2ZezFbep1P4Hso1DDrYPYn5yZJgD
X-Proofpoint-GUID: 5HOx2ZezFbep1P4Hso1DDrYPYn5yZJgD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2021-12-24_07,2021-12-24_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0
 mlxscore=0 adultscore=0 priorityscore=1501 clxscore=1015 malwarescore=0
 bulkscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112240082

On Fri, Dec 24, 2021 at 03:42:42PM +0100, Julien Grall wrote:
> On 20/12/2021 16:41, Oleksii Moisieiev wrote:
> > Hi Julien,
>
> Hello,
>
> > On Fri, Dec 17, 2021 at 04:38:31PM +0000, Julien Grall wrote:
> > >
> > >
> > > On 17/12/2021 13:58, Oleksii Moisieiev wrote:
> > > > Hi Julien,
> > >
> > > Hi,
> > >
> > > > On Fri, Dec 17, 2021 at 01:37:35PM +0000, Julien Grall wrote:
> > > > > Hi,
> > > > >
> > > > > On 17/12/2021 13:23, Oleksii Moisieiev wrote:
> > > > > > > > +static int map_memory_to_domain(struct domain *d, uint64_t=
 addr, uint64_t len)
> > > > > > > > +{
> > > > > > > > +    return iomem_permit_access(d, paddr_to_pfn(addr),
> > > > > > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > > > > > +}
> > > > > > > > +
> > > > > > > > +static int unmap_memory_from_domain(struct domain *d, uint=
64_t addr,
> > > > > > > > +                                     uint64_t len)
> > > > > > > > +{
> > > > > > > > +    return iomem_deny_access(d, paddr_to_pfn(addr),
> > > > > > > > +                paddr_to_pfn(PAGE_ALIGN(addr + len -1)));
> > > > > > > > +}
> > > > > > >
> > > > > > > I wonder, why we need an extra level of indirection here. And=
 if this is
> > > > > > > really needed, I wonder why map(unmap)_memory* name was chose=
n, as there is
> > > > > > > no memory mapping/unmapping really happens here.
> > > > > > >
> > > > > >
> > > > > > I've added extra indirection to hide math like
> > > > > > paddr_to_pfn(PAGE_ALIGN(addr + len -1)
> > > > > > so you don't have to math in each call. unmap_memory_from_domai=
n called
> > > > > > from 2 places, so I moved both calls to separate function.
> > > > > > Although, I agree that map/unmap is not perfect name. I conside=
r
> > > > > > renaming it to mem_permit_acces and mam_deny_access.
> > > > >
> > > > > I haven't looked at the rest of the series. But this discussion c=
aught my
> > > > > eye. This code implies that the address is page-aligned but the l=
ength not.
> > > > > Is that intended?
> > > > >
> > > > > That said, if you give permission to the domain on a full page th=
en it means
> > > > > it may be able to access address it should not. Can you explain w=
hy this is
> > > > > fine?
> > > > >
> > > >
> > > > The idea was that xen receives some memory from the dt_node linux,s=
cmi_mem,
> > > > then we split memory between the agents, so each agent get 1 page (=
we
> > > > allocate 0x10 pages right now).
> > >
> > > Thanks for the clarification. Does this imply the guest will be able =
to
> > > write message directly to the firmware?
> >
> > We used DEN0056C Specification as base. Available on: https://urldefens=
e.com/v3/__https://developer.arm.com/documentation/den0056/latest__;!!GF_29=
dbcQIUBPA!m9pWoxBEjb8Sd1CoV5cpU8MbmLCjohYQxv2ci9tDvMmZ9oCEitqyydZ3rQWXCM5bx=
vIn$ [developer[.]arm[.]com].
> > SCMI transport is described in Section 5.1. We implemented Shared Memor=
y transport.
> > Firmware has N pages of the shared memory, used to communicate with Age=
nts.
> > It allocates N agents and assign a page for each agent, such as:
> > -------------------------------------
> > | Agent H | Agent 1 | Agent 2 | ... |
> > -------------------------------------
> > Agent H is the privilleged Hypervisor agent, which is used to do the ba=
se commands,
> > such as getting Agent list, set\unset permissions etc.
> > Hypervisor assign agent to the guest and maps page, related to the agen=
t to the Guest.
> > So the Guest, which is Agent 1 will get an access to Agent 1 page.
> >
> > Guest places SCMI message to Agent 1 memory, then sends SMC message.
> > Hypervisor process SMC request, add agent id to the message parameters =
and redirects it to the Firmware.
> > Based on the agent_id Firmware knows which page it should read.
> > Then after permission check ( if the resetId/clockID/powerID etc from m=
essage
> > is assigned to agent_id ) it does changes to the HW and places response=
 to Agent
> > shared memory and marks channel as FREE ( by setting free bit in shared=
 memory ).
> > Once channel is marked as free - Guest read response from the shared me=
mory.
>
> So, IIUC, the hypervisor will not control what is written in the shared
> memory. It will only control the SMC parameters. Is my understanding
> correct?
>

For scmi_smc it will not. But potentially it can make some changes, or
convert to the different protocol.

> >
> > Non-virtualized systems will work as well. OS should send SMC directly =
to the Firmware.
> >
> > >
> > > If so, this brings a few more questions:
> > >    1) What will the guest write in it? Can it contains addresses?
> > Guest can write scmi request to the shared memory, which include the fo=
llowing data:
> > 1) protocol_id - which protocol is requested, such as clock, power, res=
et etc
> > 2) message_id - action that should be done to HW, such as do_reset or g=
et_clock
> > 3) message data - which includes reset_id/clock_id/power_id etc. that s=
hould be changed.
> > Reset IDs and Clock IDs are assigned in Firmware. Guest receives ID, co=
rresponding to the device from the device-tree.
> > dt_node as an example:
> > &avb {
> > 	scmi_devid =3D <0>;
> > 	clocks =3D <&scmi_clock 0>;
> > 	power-domains =3D <&scmi_power 0>;
> > 	resets =3D <&scmi_reset 0>;
> > };
> >
> > >    2) What are the expected memory attribute for the regions?
> >
> > xen uses iommu_permit_access to pass agent page to the guest. So guest =
can access the page directly.
>
> I think you misunderstood my comment. Memory can be mapped with various t=
ype
> (e.g. Device, Memory) and attribute (cacheable, non-cacheable...). What w=
ill
> the firmware expect? What will the guest OS usually?
>
> The reason I am asking is the attributes have to matched to avoid any
> coherency issues. At the moment, if you use XEN_DOMCTL_memory_mapping, Xe=
n
> will configure the stage-2 to use Device nGnRnE. As the result, the resul=
t
> memory access will be Device nGnRnE which is very strict.
>

Let me share with you the configuration example:
scmi expects memory to be configured in the device-tree:

cpu_scp_shm: scp-shmem@0xXXXXXXX {
	compatible =3D "arm,scmi-shmem";
	reg =3D <0x0 0xXXXXXX 0x0 0x1000>;
};

where XXXXXX address I allocate in alloc_magic_pages function.
Then I get paddr of the scmi channel for this domain and use
XEN_DOMCTL_memory_mapping to map scmi channel address to gfn.

Hope I wass able to answer your question.

Best regards,
Oleksii.=


From xen-devel-bounces@lists.xenproject.org Fri Dec 24 23:28:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 24 Dec 2021 23:28:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251463.432785 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0tzH-0000Qd-40; Fri, 24 Dec 2021 23:28:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251463.432785; Fri, 24 Dec 2021 23:28:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n0tzH-0000QW-0q; Fri, 24 Dec 2021 23:28:35 +0000
Received: by outflank-mailman (input) for mailman id 251463;
 Fri, 24 Dec 2021 23:28:33 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0tzF-0000QM-QD; Fri, 24 Dec 2021 23:28:33 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0tzF-0004eW-Jq; Fri, 24 Dec 2021 23:28:33 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n0tzF-0004s3-6e; Fri, 24 Dec 2021 23:28:33 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n0tzF-00031M-6D; Fri, 24 Dec 2021 23:28:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=t9YVj0/hn01nMVyfDoM6iqMxSihJ7251XjM5/eg+A6k=; b=EPL9gKYWdR2N7H/20Wz2KMbwXi
	ijctpCgbOsx5Ybqi7s/F5LRdd3xhZU++qi10+BXwVkuci2XsPWnRvZ8NQ+BWhrKTPZ1xfsdx/qVLw
	H3a7hfgy7C1Ngs8Wmmt2ytwN6xWlLsxjx//hYRejsSveNS0s5fZ7ybhYYffFUeybIs6E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167536-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167536: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=b927dfc67d05a72167ab980c375ed98b2ee9c2c6
X-Osstest-Versions-That:
    linux=7a29b11da9651ef6a970e2f6bfd276f053aeb06a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 24 Dec 2021 23:28:33 +0000

flight 167536 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167536/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167531
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167531
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167531
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167531
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167531
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167531
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167531
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167531
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                b927dfc67d05a72167ab980c375ed98b2ee9c2c6
baseline version:
 linux                7a29b11da9651ef6a970e2f6bfd276f053aeb06a

Last test of basis   167531  2021-12-24 01:42:51 Z    0 days
Testing same since   167536  2021-12-24 17:42:25 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andy Shevchenko <andriy.shevchenko@linux.intel.com>
  Ard Biesheuvel <ardb@kernel.org>
  Hans de Goede <hdegoede@redhat.com>
  Johan Hovold <johan@kernel.org>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mario Limonciello <mario.limonciello@amd.com>
  Miaoqian Lin <linmq006@gmail.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Tim Crawford <tcrawford@system76.com>
  Vladimir Murzin <vladimir.murzin@arm.com>
  Wang Qing <wangqing@vivo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   7a29b11da965..b927dfc67d05  b927dfc67d05a72167ab980c375ed98b2ee9c2c6 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sat Dec 25 07:36:56 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 25 Dec 2021 07:36:56 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251507.432814 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n11bG-0000bX-R3; Sat, 25 Dec 2021 07:36:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251507.432814; Sat, 25 Dec 2021 07:36:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n11bG-0000bQ-OA; Sat, 25 Dec 2021 07:36:18 +0000
Received: by outflank-mailman (input) for mailman id 251507;
 Sat, 25 Dec 2021 07:36:16 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n11bE-0000bG-RL; Sat, 25 Dec 2021 07:36:16 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n11bE-0007Oq-Lw; Sat, 25 Dec 2021 07:36:16 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n11bE-0005Bs-Bu; Sat, 25 Dec 2021 07:36:16 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n11bE-0008E1-BT; Sat, 25 Dec 2021 07:36:16 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=7uxy893u+ViBImWE5iy9/ziLGekjOC6qswjwXKX+X5I=; b=e8Vbf5bhlPG737kktCJqmnWtLm
	f3vKlycSkIY6FtYrkEOjCAHMUPxRyNhY7wvM1uIhwte6uCDc5K0caQxqQxRTJinUMGE9gXfrEpiEc
	K8ir3VrM80iRc+TnWi1zHmmqJUGFwsPoYDiBLtMG5mOW9iYrUJdLkgCfr11rH6fH1XAU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167538-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167538: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 25 Dec 2021 07:36:16 +0000

flight 167538 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167538/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  533 days
Failing since        151818  2020-07-11 04:18:52 Z  532 days  514 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Sat Dec 25 09:56:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 25 Dec 2021 09:56:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251695.432825 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n13mL-0000TZ-Eg; Sat, 25 Dec 2021 09:55:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251695.432825; Sat, 25 Dec 2021 09:55:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n13mL-0000TS-BI; Sat, 25 Dec 2021 09:55:53 +0000
Received: by outflank-mailman (input) for mailman id 251695;
 Sat, 25 Dec 2021 09:55:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n13mK-0000TI-GH; Sat, 25 Dec 2021 09:55:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n13mK-0002CS-C5; Sat, 25 Dec 2021 09:55:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n13mJ-0001M2-Ve; Sat, 25 Dec 2021 09:55:52 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n13mJ-0001el-VD; Sat, 25 Dec 2021 09:55:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ze96O6PYhYItZQ2ickDjMza+EAARY7ByAdzHQc/DUKw=; b=A5QcGywhzHHecth2NRZolcWxBk
	JdxIh0TPPm4HDvSBsAt5BnxaF4ua/bXJLM2K95Sk26TZE0CGE6eRRZu8E7kGcPkSvBYuR0tyOF8u9
	pLXu2yIiJ01GOZgDKM0LQGILcw0UBLfJw8e8Yq3eQiBmdg2RMe73yjc56J3q8cR70qfA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167537-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167537: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sat, 25 Dec 2021 09:55:51 +0000

flight 167537 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167537/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail in 167532 pass in 167537
 test-amd64-i386-libvirt-xsm  20 guest-start/debian.repeat  fail pass in 167532

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167532
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167532
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167532
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167532
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167532
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167532
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167532
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167532
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167532
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167532
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167532
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167532
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167537  2021-12-25 01:54:13 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  fail    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sat Dec 25 16:40:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 25 Dec 2021 16:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251764.432836 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1A5E-000736-Ea; Sat, 25 Dec 2021 16:39:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251764.432836; Sat, 25 Dec 2021 16:39:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1A5E-00072z-Aj; Sat, 25 Dec 2021 16:39:48 +0000
Received: by outflank-mailman (input) for mailman id 251764;
 Sat, 25 Dec 2021 16:39:46 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EicR=RK=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n1A5C-00072t-L4
 for xen-devel@lists.xen.org; Sat, 25 Dec 2021 16:39:46 +0000
Received: from mail-io1-f43.google.com (mail-io1-f43.google.com
 [209.85.166.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 42d40213-65a1-11ec-bb0b-79c175774b5d;
 Sat, 25 Dec 2021 17:39:43 +0100 (CET)
Received: by mail-io1-f43.google.com with SMTP id 19so13574276ioz.4
 for <xen-devel@lists.xen.org>; Sat, 25 Dec 2021 08:39:43 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 42d40213-65a1-11ec-bb0b-79c175774b5d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oUytEaQuJaVQbgd5+8HlyCLmjtGwQoVrbd2CYdEAWiE=;
        b=Q19Fb1y257F1/m+4swOx+xZYC1R2NZgSYTRGnj5ePGfc30hr7v6s+75/egUdoQqhmV
         LP314C89xM1NNKcxjbEj3pdSdOKu6GGjZnFxOjbPAx7daujwYHSKkBPSbJa2xTJA2IpF
         6vYqzPXNI5+PKTOBOIFlk8Cgo7mjoWVS5P6RR/601kj/A8t02K+hRlvo3sMzl/tI0k4c
         oIwspAts1LBhkH0v4h4CwLNSy+m1z/pQdSEvP3yvFrMt/1LYlJdDw3qJG1OwTYChBSU6
         mbG2XNHLWEZHw26pGRbNZj3kYiY44+1QyvaHWyT821uBkH3bXTbZzzPHpyulDEnuWCUX
         CdWQ==
X-Gm-Message-State: AOAM533fuetruVkGs/iuAjcDGeQARt1KansLRISQNCNaXGDmg0MwgL5e
	bOZSNEq/83zlkFwxT0z87qj8l5luZ3fhM0yku90=
X-Google-Smtp-Source: ABdhPJxz1O6Obs4pkBg9mKiI4ufOTS+asP3CQGL6pbsBsjboxf6ripXUJhh9l0FVm28rsSkRXe49Jo/dNbR74Y8nOyM=
X-Received: by 2002:a5d:9f44:: with SMTP id u4mr4588239iot.163.1640450382233;
 Sat, 25 Dec 2021 08:39:42 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger> <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger> <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger>
In-Reply-To: <YcWuCgYWestnlDSH@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Sun, 26 Dec 2021 00:39:30 +0800
Message-ID: <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

> > Please find the trace and the kernel CL below.
> > Note, the domU get stuck into a bootloop with this assertion as the
> > situation will come back after domU restart and only dom0 reboot can
> > get the situation back to normal.
> > The trace I captured below is within the boot loop. I suspect the
> > initial trigger may look different. Will give it another try soon.
> >
I think I figured out the cause of the boot loop.
It was not due to some mystery offender packet from the FreeBSD domU
surviving across reboot,
but because the windows iSCSI initiator keeps retrying :-).

That said, I did pay some prices figuring this out.
The boot-loop seems to have brought my box into a weird state that those disks
behind the controller keep detaching soon after NAS domU reboot.
Rebooting the physical host does not help this time.
I was almost desperate but thankfully running the NAS on the physical
host directly still works.
And switching it back to domU together with config reloading fixed
this problem :-)
Not sure if it was the domU config being corrupted or something left
sticky in the PCI pass-through?

> Thanks. I've raised this on freensd-net for advice [0]. IMO netfront
> shouldn't receive an mbuf that crosses a page boundary, but if that's
> indeed a legit mbuf I will figure out the best way to handle it.
>
> I have a clumsy patch (below) that might solve this, if you want to
> give it a try.

Applied the patch and it worked like a charm!
Thank you so much for your quick help!
Wish you a wonderful holiday!

Thanks,
G.R.


From xen-devel-bounces@lists.xenproject.org Sat Dec 25 18:07:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sat, 25 Dec 2021 18:07:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251777.432847 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1BRm-0007mT-RX; Sat, 25 Dec 2021 18:07:10 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251777.432847; Sat, 25 Dec 2021 18:07:10 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1BRm-0007mM-Nj; Sat, 25 Dec 2021 18:07:10 +0000
Received: by outflank-mailman (input) for mailman id 251777;
 Sat, 25 Dec 2021 18:07:09 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=EicR=RK=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n1BRl-0007mG-Lo
 for xen-devel@lists.xen.org; Sat, 25 Dec 2021 18:07:09 +0000
Received: from mail-il1-f180.google.com (mail-il1-f180.google.com
 [209.85.166.180]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 78be14a3-65ad-11ec-9e60-abaf8a552007;
 Sat, 25 Dec 2021 19:07:08 +0100 (CET)
Received: by mail-il1-f180.google.com with SMTP id y16so8832599ilq.8
 for <xen-devel@lists.xen.org>; Sat, 25 Dec 2021 10:07:07 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 78be14a3-65ad-11ec-9e60-abaf8a552007
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=rj5bw5Fvs3Zezd4r+FVV2J+bmd2uBeaFMey7QaPzfL8=;
        b=yhJvT4tsuxkodReprhC7liHqNV+iuOdwC581h8UhJ8MaBRJVY4YzS+7wPqClix3/hd
         MX+x3ZOtDD5Y0+bq5bCEoyLLcbzgBzyBPc1n79h26jjOVsUjZ6NxxljQbO9RVm3vgt0u
         Hl12ipDlk9BfTk0G7fKZMBpKEaPDQsFKa9H8AGnY5SWR3FNfBUmwdKR8Fq7qBZBLRmb7
         vropPoHqtH/ySheSxD+t/EdYVGKmTKBz09Rdrze1IdFmthwSTzBSrV/GXlN5tFwMxm3n
         l/1VXKFH3fYZTmg8GDr0uuCmbuFbVrNp0wrJSaGO/RR/gLeE57B+5r/JHHUfNcFVq/AI
         Fkyg==
X-Gm-Message-State: AOAM532V0FTWMgMDRKp3PO+AzMiCZh6lveVG781etXVi2fse7XsYMA8p
	LpXCiIwiviRtvfstyDmFwN7cc2S08TR3JqaaLf8=
X-Google-Smtp-Source: ABdhPJybD0l/SDAy35f5XcSQfr4j0iStDl87V+y7k+EfbCC9pjtUxh5sijiv4OA+a7PJTuFeCWoUdIR+RDCQfRp/0AU=
X-Received: by 2002:a92:c10e:: with SMTP id p14mr4719204ile.24.1640455626680;
 Sat, 25 Dec 2021 10:07:06 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger> <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger> <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger> <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
In-Reply-To: <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Sun, 26 Dec 2021 02:06:55 +0800
Message-ID: <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Content-Type: text/plain; charset="UTF-8"

> > Thanks. I've raised this on freensd-net for advice [0]. IMO netfront
> > shouldn't receive an mbuf that crosses a page boundary, but if that's
> > indeed a legit mbuf I will figure out the best way to handle it.
> >
> > I have a clumsy patch (below) that might solve this, if you want to
> > give it a try.
>
> Applied the patch and it worked like a charm!
> Thank you so much for your quick help!
> Wish you a wonderful holiday!

I may have said too quickly...
With the patch I can attach the iscsi disk and neither the dom0 nor
the NAS domU complains this time.
But when I attempt to mount the attached disk it reports I/O errors randomly.
By randomly I mean different disks behave differently...
I don't see any error logs from kernels this time.
(most of the iscsi disks are NTFS FS and mounted through the user mode
fuse library)
But since I have a local backup copy of the image, I can confirm that
mounting that backup image does not result in any I/O error.
Looks like something is still broken here...


From xen-devel-bounces@lists.xenproject.org Sun Dec 26 03:11:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 26 Dec 2021 03:11:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251806.432858 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1Jvs-0003Xi-GE; Sun, 26 Dec 2021 03:10:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251806.432858; Sun, 26 Dec 2021 03:10:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1Jvs-0003XH-9I; Sun, 26 Dec 2021 03:10:48 +0000
Received: by outflank-mailman (input) for mailman id 251806;
 Sun, 26 Dec 2021 03:10:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Jvr-0003X7-6U; Sun, 26 Dec 2021 03:10:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Jvr-0005Xv-3x; Sun, 26 Dec 2021 03:10:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Jvq-0002Xy-MH; Sun, 26 Dec 2021 03:10:46 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Jvq-0006tA-LG; Sun, 26 Dec 2021 03:10:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JbyTtPfj9gYK0CXnm6avZY5G5cYbRkKjof7shR1AgzE=; b=xcJsb8NTTPNHCSDvCEKI6v6Qht
	iWNuijaHjxbP5UA6GlPC53eSFEbzdWSUKN45OFiXZWD9WQVPmqDj8gYdayd6iH4Qv5zrsuHhjbgX6
	/nAu/Gg+ZeaJ+APsdhGP4fMiiBvXVmmomRRRM8tC2JFnijn9pztpPpWjyfztqpGJkdtw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167539-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167539: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f
X-Osstest-Versions-That:
    linux=b927dfc67d05a72167ab980c375ed98b2ee9c2c6
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 26 Dec 2021 03:10:46 +0000

flight 167539 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167539/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167536
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167536
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167536
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167536
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167536
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167536
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167536
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167536
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f
baseline version:
 linux                b927dfc67d05a72167ab980c375ed98b2ee9c2c6

Last test of basis   167536  2021-12-24 17:42:25 Z    1 days
Testing same since   167539  2021-12-25 21:42:13 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrea Righi <andrea.righi@canonical.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Ryabinin <arbn@yandex-team.com>
  Baokun Li <libaokun1@huawei.com>
  Baoquan He <bhe@redhat.com>
  David Rientjes <rientjes@google.com>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Guenter Roeck <linux@roeck-us.net>
  Hans de Goede <hdegoede@redhat.com>
  Hugh Dickins <hughd@google.com>
  Jeff LaBundy <jeff@labundy.com>
  Johnny Chuang <johnny.chuang.emc@gmail.com>
  José Expósito <jose.exposito89@gmail.com>
  Kees Cook <keescook@chromium.org>
  Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Liu Shixin <liushixin2@huawei.com>
  Marco Elver <elver@google.com>
  Mel Gorman <mgorman@techsingularity.net>
  Michal Hocko <mhocko@suse.com>
  Naoya Horiguchi <naoya.horiguchi@nec.com>
  Philipp Rudo <prudo@redhat.com>
  Randy Dunlap <rdunlap@infradead.org>
  Samuel Čavoj <samuel@cavoj.net>
  SeongJae Park <sj@kernel.org>
  Takashi Iwai <tiwai@suse.de>
  Thibaut Sautereau <thibaut.sautereau@ssi.gouv.fr>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   b927dfc67d05..e2ae0d4a6b0b  e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Sun Dec 26 10:07:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 26 Dec 2021 10:07:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251838.432868 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1QQi-0001iU-4c; Sun, 26 Dec 2021 10:07:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251838.432868; Sun, 26 Dec 2021 10:07:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1QQi-0001iN-19; Sun, 26 Dec 2021 10:07:04 +0000
Received: by outflank-mailman (input) for mailman id 251838;
 Sun, 26 Dec 2021 10:07:02 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=UNhb=RL=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n1QQf-0001iH-Rh
 for xen-devel@lists.xenproject.org; Sun, 26 Dec 2021 10:07:02 +0000
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [2a00:1450:4864:20::141])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8fe1b60f-6633-11ec-9e60-abaf8a552007;
 Sun, 26 Dec 2021 11:07:00 +0100 (CET)
Received: by mail-lf1-x141.google.com with SMTP id bq20so28434944lfb.4
 for <xen-devel@lists.xenproject.org>; Sun, 26 Dec 2021 02:06:58 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8fe1b60f-6633-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=IbpO5BHDLj63Oyo5xP5NJt5Um1JFeAZFXNeWCYYJRYU=;
        b=Y5mbvQfhUNwv1q64FRNOIExPTXvyK6p2MjrLQ/j4vUcfwojeKsALvIJfi3Oxk9b4TN
         HCuPkWLx+0Z2uUS32DtxrdjM18AL/kMnW0VSQoZMCrKR0iTLG8cThvBhf5fa9rVhS1vP
         cA66ofx9wDLsBKWOE9BU8iH8jSzOgfLYuS074CiNy9CnXya2CTAIyn9knjZbfaV6Dvrx
         yRh3I3wW/2+jG52HOc7lG6rWtJB1NjC83QlsqVWpfIVnbZ6fzxO6hoBKHOCTXyVpy4Pl
         xq7yulz/K5nLTLt8s4kwggzCX/VU5LINRLSD72JBrJ+25YlAJ848Oa1Cl7fR81Sto5Qq
         6fUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=IbpO5BHDLj63Oyo5xP5NJt5Um1JFeAZFXNeWCYYJRYU=;
        b=AVDD5xrUaD6FK4eFgiD1D5ib232/Ur/On8+6FS1QI8WCX2zYqYrG1Laa5wD+fuz39F
         HD9si3xSZsQH6lsXZKgaKxY217b03r8YjFChug5oKbL+cCFeXIx/0cXgKnx8WWCfkvxh
         LuAridhCnXm7Msb52a+rhzwDDYgtvwJGaXA7cxc2y9MsNBOO90M12z8I5aeX0e5examg
         yl5l6xPkBWR/x6Om0Qif9QO7+dtTVAHbNgdQcjE96/OiXMfxhl8oHDdi5KMakofB44V3
         22z5kpxMhxNM3YDJa9utxRWAT7vKQ4+Om3NsfuQ4WD2rJcVH32LoFwvuIuP4Bnf/I27w
         NBwg==
X-Gm-Message-State: AOAM531KB/k2Z+BUhCCRvp20jWCxx4pESe/88sSqT9laD5/joNq5Hcpy
	Hmg6HSR863kL/RkvdYjsTLDIC0TQTrIRrq/RAWo=
X-Google-Smtp-Source: ABdhPJwVTUlQodlCjg8Fd0JAMmKjjxwN9OYagkodZlbvv9snlCyXwyvmAnzUEov/fc9n7YwqHz7y5av4aG3P19BtITs=
X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr11466084lfq.525.1640513218004;
 Sun, 26 Dec 2021 02:06:58 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org>
In-Reply-To: <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Sun, 26 Dec 2021 18:06:46 +0800
Message-ID: <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=97=A5=
=E5=91=A8=E4=BA=94 22:21=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi,
>
> I am not sure why you dropped the others. I have added them back.

sorry, it is my mistake

>
> On 24/12/2021 14:36, Dongjiu Geng wrote:
> > Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=97=
=A5=E5=91=A8=E4=BA=94 21:25=E5=86=99=E9=81=93=EF=BC=9A
> >>
> >> Hi,
> >>
> >> On 24/12/2021 13:24, Dongjiu Geng wrote:
> >>> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build fai=
led.
> >>> so fix it and make it can select GICV2.
> >>
> >> As I said in v1, last time I checked QEMU was only able to support
> >> virtualization with GICv3. This is why we added a depends on.
> >
> > I enabled CONFIG_NEW_VGIC, then it will use GICv2. In my check, it
> > does not report an error.
> > My QEMU emulator version is 4.0.0.  What is the QEMU version that you u=
sed?
>
> I am using a more recent QEMU. However, I have always only used GICv3
> becuase it was IIRC there first.
>
> >
> >>
> >> If you want to remove it, then I think you ought to explain in the
> >> commit message why this is fine. A pointer to the commit or a QEMU
> >> version used would be useful.
> >
> > OK=EF=BC=8Cthanks. Can you check if QEMU 4.0.0 is workable with GICv2 o=
n your side?
>
> I don't have direct access to my QEMU setup at the moment. However,
> looking at the history.
>
> So I would suggest the following commit message:
>
> "
> xen/arm: Allow QEMU platform to be built with GICv2
>
> Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> complain about unmet dependencies:
>
> tools/kconfig/conf  --syncconfig Kconfig
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
>    Selected by [y]:
>    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
>    Selected by [y]:
>    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
>    Selected by [y]:
>    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
>
>
> It turns out that QEMU has been supporting GICv2 virtualization since
> v3.1.0. So an easy way to solve the issue and allow more custom support
> is to remove the dependencies on GICv3.
> "

Ok, thanks very much for your suggestion.

>
> > It is workable on my side.
> >
> >
> >>
> >>>
> >>> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> >>> ---
> >>> $ make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux=
-gnu- -j10
> >>> make -C xen install
> >>> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machine/=
XEN/xen/xen'
> >>> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/kco=
nfig/Makefile.kconfig ARCH=3Darm64 SRCARCH=3Darm HOSTCC=3D"gcc" HOSTCXX=3D"=
g++" syncconfig
> >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/=
XEN/xen/xen'
> >>> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o t=
ools/kconfig/conf.c
> >>> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/conf=
data.o tools/kconfig/confdata.c
> >>> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o t=
ools/kconfig/expr.c
> >>> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> >>> bison -o tools/kconfig/parser.tab.c --defines=3Dtools/kconfig/parser.=
tab.h -t -l tools/kconfig/parser.y
> >>> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/pr=
eprocess.o tools/kconfig/preprocess.c
> >>> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symbol=
.o tools/kconfig/symbol.c
> >>> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gengd=
ongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.lex.=
o tools/kconfig/lexer.lex.c
> >>> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/geng=
dongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.ta=
b.o tools/kconfig/parser.tab.c
> >>> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confdat=
a.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.tab=
.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> >>> tools/kconfig/conf  --syncconfig Kconfig
> >>>
> >>> WARNING: unmet direct dependencies detected for GICV3
> >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >>>     Selected by [y]:
> >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >>>
> >>> WARNING: unmet direct dependencies detected for GICV3
> >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >>>     Selected by [y]:
> >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >>>
> >>> WARNING: unmet direct dependencies detected for GICV3
> >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >>>     Selected by [y]:
> >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >>> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine/X=
EN/xen/xen'
> >>> make -f Rules.mk _install
> >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machine/=
XEN/xen/xen'
> >>> ---
> >>>    xen/arch/arm/Kconfig           | 5 +++--
> >>>    xen/arch/arm/platforms/Kconfig | 1 -
> >>>    2 files changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> >>> index ecfa6822e4..373c698018 100644
> >>> --- a/xen/arch/arm/Kconfig
> >>> +++ b/xen/arch/arm/Kconfig
> >>
> >> The change in arch/arm/Kconfig is not really related to this patch.
> >> Technically the part in platforms/Kconfig is sufficient. I still think
> >> the change is good to have but it should be in a separate patch.
> >
> > sure
> >
> >>
> >>> @@ -35,7 +35,7 @@ config ACPI
> >>>
> >>>    config GICV3
> >>>        bool "GICv3 driver"
> >>> -     depends on ARM_64 && !NEW_VGIC
> >>> +     depends on ARM_64
> >>>        default y
> >>>        ---help---
> >>>
> >>> @@ -44,13 +44,14 @@ config GICV3
> >>>
> >>>    config HAS_ITS
> >>>            bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if U=
NSUPPORTED
> >>> -        depends on GICV3 && !NEW_VGIC
> >>> +        depends on GICV3
> >>>
> >>>    config HVM
> >>>            def_bool y
> >>>
> >>>    config NEW_VGIC
> >>>        bool "Use new VGIC implementation"
> >>> +     depends on !GICV3
> >>>        ---help---
> >>>
> >>>        This is an alternative implementation of the ARM GIC interrupt
> >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/=
Kconfig
> >>> index c93a6b2756..6d3ee99456 100644
> >>> --- a/xen/arch/arm/platforms/Kconfig
> >>> +++ b/xen/arch/arm/platforms/Kconfig
> >>> @@ -15,7 +15,6 @@ config ALL_PLAT
> >>>    config QEMU
> >>>        bool "QEMU aarch virt machine support"
> >>>        depends on ARM_64
> >>> -     select GICV3
> >>>        select HAS_PL011
> >>>        ---help---
> >>>        Enable all the required drivers for QEMU aarch64 virt emulated
>
> While writing a proposal for the commit message, I remembered that the
> goal of CONFIG_QEMU was to select all the required drivers to be able to
> boot Xen on QEMU.
>
> AFAICT, if you start from tiny64_defconfig, you would not have GICv3
> selected. So we would technically break users of QEMU with GICv3.

I think I can add CONFIG_GICV3=3Dy in arch/arm/configs/tiny64_defconfig
to this patch, if it must to use GICV3.

>
> I am not entirely sure how to approach it. I can think of 2 options:
>
>   1) Use 'select GICv3 if !NEW_VGIC'
>   2) Add a specific platform for QEMU new vGIC
>
> I have the feeling that 1) will result to same unmet dependency issue.
> Stefano any opinions?

Stefano?

>
> Cheers,
>
> --
> Julien Grall


From xen-devel-bounces@lists.xenproject.org Sun Dec 26 10:23:18 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 26 Dec 2021 10:23:18 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251848.432879 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1Qg9-00049F-LY; Sun, 26 Dec 2021 10:23:01 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251848.432879; Sun, 26 Dec 2021 10:23:01 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1Qg9-000498-IW; Sun, 26 Dec 2021 10:23:01 +0000
Received: by outflank-mailman (input) for mailman id 251848;
 Sun, 26 Dec 2021 10:23:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Qg8-00048y-7R; Sun, 26 Dec 2021 10:23:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Qg8-0005Dm-4V; Sun, 26 Dec 2021 10:23:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Qg7-0007Ag-Pt; Sun, 26 Dec 2021 10:22:59 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1Qg7-0002SZ-PV; Sun, 26 Dec 2021 10:22:59 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2aoovwZs/iZjDYAOxygJHce+/pbH1XiNpgSzk1mpHFY=; b=jS14QeJsWERl191ijJWEncmMrp
	njvr4kU1yAnlJ58QNUUUcpDJ/8IDTie4nW4vrW80F4aBENk6wgohTpZ/zOmL6Jg3q6qGgvxUzeDsI
	Qj+gq49nwM69JcSAOyBhb5OpMHAvUMYAg4Mh4hjT80AxdAvE0RdqtVWltuBmERjI7DJg=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167542-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167542: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 26 Dec 2021 10:22:59 +0000

flight 167542 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167542/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  534 days
Failing since        151818  2020-07-11 04:18:52 Z  533 days  515 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    1 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Sun Dec 26 11:04:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 26 Dec 2021 11:04:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251861.432891 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1RJr-0008TB-PC; Sun, 26 Dec 2021 11:04:03 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251861.432891; Sun, 26 Dec 2021 11:04:03 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1RJr-0008T4-M9; Sun, 26 Dec 2021 11:04:03 +0000
Received: by outflank-mailman (input) for mailman id 251861;
 Sun, 26 Dec 2021 11:04:02 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1RJq-0008Su-KR; Sun, 26 Dec 2021 11:04:02 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1RJq-0005sn-Hs; Sun, 26 Dec 2021 11:04:02 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1RJq-0008AX-5K; Sun, 26 Dec 2021 11:04:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1RJq-0004kB-4p; Sun, 26 Dec 2021 11:04:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=0LEw4nsJQ67fcC9CB2rezyDzJsDvbQniAz2CMXutiE8=; b=uXWZ4bG2DXk6XRjFeqL6Ft4+RV
	wfq4TAfCX0ox9EwFSNjo8A7XmbMhsKSVqjmiDUiUHHWOt/EWrgmSvnd9BFoS8+w8MmWIFTSz2M7Tl
	rJciX1g0BarPoBzzasaOi9Vif+IlPSlell1iBPbxqnNOmHcXhgu4erYvcor/mzfSywUs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167540-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167540: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-i386-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 26 Dec 2021 11:04:02 +0000

flight 167540 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167540/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-i386-libvirt-xsm 20 guest-start/debian.repeat fail in 167537 pass in 167540
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167537

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167537
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167537
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167537
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167537
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167537
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167537
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167537
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167537
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167537
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167537
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167537
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167537
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167540  2021-12-26 01:52:54 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Sun Dec 26 11:57:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Sun, 26 Dec 2021 11:57:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251877.432901 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1S9I-0005L0-Ve; Sun, 26 Dec 2021 11:57:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251877.432901; Sun, 26 Dec 2021 11:57:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1S9I-0005Kt-SR; Sun, 26 Dec 2021 11:57:12 +0000
Received: by outflank-mailman (input) for mailman id 251877;
 Sun, 26 Dec 2021 11:57:11 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1S9G-0005Kj-Vd; Sun, 26 Dec 2021 11:57:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1S9G-0006h9-SS; Sun, 26 Dec 2021 11:57:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1S9G-0000xl-HV; Sun, 26 Dec 2021 11:57:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1S9G-0000NE-H2; Sun, 26 Dec 2021 11:57:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=WmDWacuCnsytLOI+PHy6KTtP6VIX0TOpZY8kxQ9b91o=; b=JJkE8TtF7ibbTSuRCQ80Fu9D0Z
	C6WHwrBBGY1jujCxAhQnOHYOGjn9P1SVfzf9UPBi6gGB2tKo2ToSySUtWxGnKDq1qLt/YLEfpYHt/
	YmtNw/O8IZUM20BcUHm4VFtm7ioDhP58gNUQsFUUmL8ezIGh9SeHN9nMzvkEMkLCih1E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167541-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167541: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=438645193e59e91761ccb3fa55f6ce70b615ff93
X-Osstest-Versions-That:
    linux=e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f
From: osstest service owner <osstest-admin@xenproject.org>
Date: Sun, 26 Dec 2021 11:57:10 +0000

flight 167541 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167541/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167539
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167539
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167539
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167539
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167539
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167539
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167539
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167539
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                438645193e59e91761ccb3fa55f6ce70b615ff93
baseline version:
 linux                e2ae0d4a6b0ba461542f0fd0ba0b828658013e9f

Last test of basis   167539  2021-12-25 21:42:13 Z    0 days
Testing same since   167541  2021-12-26 04:10:47 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Fabien Dessenne <fabien.dessenne@foss.st.com>
  Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Phil Elwell <phil@raspberrypi.com>
  Zhiyong Tao <zhiyong.tao@mediatek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e2ae0d4a6b0b..438645193e59  438645193e59e91761ccb3fa55f6ce70b615ff93 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 00:33:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 00:33:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251915.432913 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1dwt-0000lP-T7; Mon, 27 Dec 2021 00:33:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251915.432913; Mon, 27 Dec 2021 00:33:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1dwt-0000lI-Pl; Mon, 27 Dec 2021 00:33:11 +0000
Received: by outflank-mailman (input) for mailman id 251915;
 Mon, 27 Dec 2021 00:33:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1dws-0000l8-I7; Mon, 27 Dec 2021 00:33:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1dws-0003OF-GI; Mon, 27 Dec 2021 00:33:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1dws-0004Xq-18; Mon, 27 Dec 2021 00:33:10 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1dws-00073Y-0h; Mon, 27 Dec 2021 00:33:10 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=HZE6kKQqCjwplj6QsrOkANJvg25hXTKxsVzLPK/j4Lc=; b=uM6xgNny3ft8spST/9a+mPKvbD
	L/pOtgr43jah6Loy1aWjKv5969DaxNR8XX4pgb9+glsnOjVcJWFYqc4IozERk8Dpts2XmlWUj9dfP
	v0cA3mC2EJsBK3rppkdVWGlAFxL/eaS4bffFmIA5NHsG2d974h2dW8jjfIoSi18BTRb8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167543-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167543: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e8ffcd3ab0e5d7332cc75c214fe74e52240b117b
X-Osstest-Versions-That:
    linux=438645193e59e91761ccb3fa55f6ce70b615ff93
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 27 Dec 2021 00:33:10 +0000

flight 167543 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167543/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167541
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167541
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167541
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167541
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167541
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167541
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167541
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167541
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                e8ffcd3ab0e5d7332cc75c214fe74e52240b117b
baseline version:
 linux                438645193e59e91761ccb3fa55f6ce70b615ff93

Last test of basis   167541  2021-12-26 04:10:47 Z    0 days
Testing same since   167543  2021-12-26 18:41:55 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andrew Cooper <andrew.cooper3@citrix.com>
  Borislav Petkov <bp@suse.de>
  Dave Hansen <dave.hansen@linux.intel.com>
  Ismael Luceno <ismael@iodev.co.uk>
  Josh Poimboeuf <jpoimboe@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Masami Hiramatsu <mhiramat@kernel.org>
  Mike Rapoport <rppt@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   438645193e59..e8ffcd3ab0e5  e8ffcd3ab0e5d7332cc75c214fe74e52240b117b -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 08:01:50 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 08:01:50 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251939.432924 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1kwV-0003oQ-KA; Mon, 27 Dec 2021 08:01:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251939.432924; Mon, 27 Dec 2021 08:01:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1kwV-0003oJ-Gd; Mon, 27 Dec 2021 08:01:15 +0000
Received: by outflank-mailman (input) for mailman id 251939;
 Mon, 27 Dec 2021 08:01:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1kwU-0003o9-ID; Mon, 27 Dec 2021 08:01:14 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1kwU-0005kn-Ex; Mon, 27 Dec 2021 08:01:14 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1kwU-0007ag-56; Mon, 27 Dec 2021 08:01:14 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1kwU-0004N8-4f; Mon, 27 Dec 2021 08:01:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=dpF7pKEFNdHHNVWI77otKcpMVXLI79+MRgVeGOWh9aI=; b=Y37b9EAkhNe+qTmi0j610dE0QV
	8NGF1EpSeb4SNz7ItjgsDdSgSj2OE57qhWv6BpOz/SjMCzEaph/AafaTidBW5J7jc3ixH+9sScqpD
	FccanagzTldfeZL1XrKHZxFpe05J/lMM4WCbn8gaOFJSs6Hc/PiRiXzN4E+Ty2/H5mRY=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167544-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167544: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt:guest-start.2:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=fc74e0a40e4f9fd0468e34045b0c45bba11dcbb2
X-Osstest-Versions-That:
    linux=e8ffcd3ab0e5d7332cc75c214fe74e52240b117b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 27 Dec 2021 08:01:14 +0000

flight 167544 linux-linus real [real]
flight 167547 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167544/
http://logs.test-lab.xenproject.org/osstest/logs/167547/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt     19 guest-start.2       fail pass in 167547-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167543
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167543
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167543
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167543
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167543
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167543
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167543
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167543
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                fc74e0a40e4f9fd0468e34045b0c45bba11dcbb2
baseline version:
 linux                e8ffcd3ab0e5d7332cc75c214fe74e52240b117b

Last test of basis   167543  2021-12-26 18:41:55 Z    0 days
Testing same since   167544  2021-12-27 00:39:17 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     fail    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e8ffcd3ab0e5..fc74e0a40e4f  fc74e0a40e4f9fd0468e34045b0c45bba11dcbb2 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 09:02:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 09:02:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251951.432935 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1lt6-0001b4-Uv; Mon, 27 Dec 2021 09:01:48 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251951.432935; Mon, 27 Dec 2021 09:01:48 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1lt6-0001ax-R9; Mon, 27 Dec 2021 09:01:48 +0000
Received: by outflank-mailman (input) for mailman id 251951;
 Mon, 27 Dec 2021 09:01:47 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1lt5-0001an-DH; Mon, 27 Dec 2021 09:01:47 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1lt5-0006kZ-80; Mon, 27 Dec 2021 09:01:47 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1lt4-0001VI-UZ; Mon, 27 Dec 2021 09:01:47 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1lt4-0005zR-U7; Mon, 27 Dec 2021 09:01:46 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=m5vPTjmu2i8LSaEPJEL6t48gQay7s3MpfG6TLYSRBN8=; b=2wB4X/GPRS/6vrnYNM3kAWZHD/
	M3H0j1NN07+cYZdoQFDlAH+Kvmug8IciCycbzg59ybOy0IZe2L0s2ZC3I9zhCQIyFEBMuDhZRTzKJ
	DdkZTJuI/erQq1R+Gsz+xART7gfTFo88buJGUa0hmiAI6Z4oqXfgo5iTsYzF1sTpajk4=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167546-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167546: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 27 Dec 2021 09:01:46 +0000

flight 167546 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167546/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  535 days
Failing since        151818  2020-07-11 04:18:52 Z  534 days  516 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    2 days    3 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 11:51:03 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 11:51:03 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251968.432946 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1oWG-00011j-6V; Mon, 27 Dec 2021 11:50:24 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251968.432946; Mon, 27 Dec 2021 11:50:24 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1oWG-00011c-2y; Mon, 27 Dec 2021 11:50:24 +0000
Received: by outflank-mailman (input) for mailman id 251968;
 Mon, 27 Dec 2021 11:50:22 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1oWE-00011S-70; Mon, 27 Dec 2021 11:50:22 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1oWD-000179-Ss; Mon, 27 Dec 2021 11:50:21 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1oWD-0006Wi-Hn; Mon, 27 Dec 2021 11:50:21 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1oWD-00026f-HJ; Mon, 27 Dec 2021 11:50:21 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ru7spErJ8gewrlfLDjRNUL9A8nAqPpqKw/ZOAcWgEXI=; b=OLlm8aDOv68KX6NG+v6g+jOX7d
	ycBSaG3J28m3zyqNUWUpJW+v0HbRLii/vcaXc3Khxj8HdUkcxCtyBrtGAeUDAQelvzAw8hd9z8hNO
	fyE3+hDBbir2dn3I7OtA5TOL9Ntnr4+GZ3bUdS84bcmoHferEcIkO6ItPIcEHz+Klla8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167545-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167545: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 27 Dec 2021 11:50:21 +0000

flight 167545 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167545/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167540
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167540
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167540
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167540
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167540
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167540
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167540
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167540
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167540
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167540
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167540
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167540
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167545  2021-12-27 01:53:08 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 12:44:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 12:44:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251979.432957 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1pLz-0006I8-81; Mon, 27 Dec 2021 12:43:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251979.432957; Mon, 27 Dec 2021 12:43:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1pLz-0006I1-50; Mon, 27 Dec 2021 12:43:51 +0000
Received: by outflank-mailman (input) for mailman id 251979;
 Mon, 27 Dec 2021 12:43:49 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=3qzC=RM=kroah.com=greg@srs-se1.protection.inumbo.net>)
 id 1n1pLx-0006Ht-6b
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 12:43:49 +0000
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 920238f1-6712-11ec-bb0b-79c175774b5d;
 Mon, 27 Dec 2021 13:43:21 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 84BB95C02D5;
 Mon, 27 Dec 2021 07:43:44 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 27 Dec 2021 07:43:44 -0500
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 27 Dec 2021 07:43:43 -0500 (EST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 920238f1-6712-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=2ROSRJZXuATdJhCcuekJ7Amfp4Z
	tgQ53208KjF4wzZ4=; b=CfNrZA8Z1u28sb53lvtywE/tY4ntmJkA3hklkXe3a/4
	5RJeWoWxfbr8xZs/l4AeDoxL3ZDoIm63OmMSwMUTVMWSa7gzm216F6R3sENhefVr
	abAUN/lbJOL1Vt9prXiMp0fgnbrJKZtE/JyVaB1/+T7dMspNBxaADnIxu31Cg6+u
	VJ50psLPNmJ42ZXSK412R5l35IbcQVdGNUlPdRTnztuw1D2NNPs9PefLOJps4/vK
	I5F1On6uKdLojg6Rrbbz8Ge+7oI95jhjUxrh0BLEnkd8iR0Z2pba9IdqvjvICcLE
	7fY5HZUqra7eF/761WsdwkVw8FtbA3weMj0XcuR2Z9g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2ROSRJ
	ZXuATdJhCcuekJ7Amfp4ZtgQ53208KjF4wzZ4=; b=emRGNylp20HrEcLvnbs8Mo
	lkWa5h4kgqElbuxsFvY2xAV6rYWBFt2hHgsG4FqV/SnoSp449MPly0mUz1PW7Klz
	Z1mFGSwf+YGJWobiYwEZvGgibtbjNk+nqlCROvys9M4LerMGY6pOYHYSWVpJ6FaJ
	gywFjaALabqwc6NFmLVt5lXpJ4zdnsubZ3pvXE+c6O9zMqUU5bvw+hryhdqBUZu0
	ryVc25d/nqFuJh1Ak7QpU+Ni5Xp7qyv07C9NEzl8QuqXr1DCcIrkblz+l3iJSRQ9
	FtyUQQ2M5Qh7pyNKB4s5gcoci6fNcsJXcw1vYEf4wg1uyvd0NeS3ornST6eHbtWA
	==
X-ME-Sender: <xms:ALXJYUnCD3L7GzqIb-YRsZom-9mBImeNlv5UUD-pYKEPxKOE9KJ_XQ>
    <xme:ALXJYT1rhWovC6xJHMR4sjQ0r4P1_j7gLgLbmDrW0O8v6su6u-MIKD7alkYXKd2qh
    B61bBCMoZs8dA>
X-ME-Received: <xmr:ALXJYSrPw_LTvlgT009lomCuDODlhFh8GYft7g8fTYEoNuAwIIH-NTxI_KVjwuI96Gz8WMxHmte-SdpaWXFwh8NvJMnazRxz>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddujedgfeelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu
    mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje
    fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht
    vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh
    drtghomh
X-ME-Proxy: <xmx:ALXJYQldGvWtYwcu3qMdLIQv4rs8r77jWKhKxMDXL_0-zN9oQyM1FQ>
    <xmx:ALXJYS13X9orHqgRGUSLt0NzPyiKrZz9B_KNWCbTtHJP-E1p0Si3Pw>
    <xmx:ALXJYXvIGiQiTp6DbDfdCh7MjlxNyakTi2RQuBYh0QiOPgsrlhA2Xg>
    <xmx:ALXJYVQ2_-gZZK5SzSdCHr4psXERx40RjWIzDP0YFuOyvvfFJV2rIw>
Date: Mon, 27 Dec 2021 13:43:40 +0100
From: Greg KH <greg@kroah.com>
To: Juergen Gross <jgross@suse.com>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/blkfront: fix bug in backported patch
Message-ID: <Ycm0/H0L0O69lS7u@kroah.com>
References: <20211223105308.17077-1-jgross@suse.com>
 <YcRWNWtraLXt9W8v@kroah.com>
 <9823fe0a-2db4-bc4b-2d7c-6363856322ff@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9823fe0a-2db4-bc4b-2d7c-6363856322ff@suse.com>

On Thu, Dec 23, 2021 at 02:40:38PM +0100, Juergen Gross wrote:
> On 23.12.21 11:57, Greg KH wrote:
> > On Thu, Dec 23, 2021 at 11:53:08AM +0100, Juergen Gross wrote:
> > > The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local
> > > copy of a request from the ring page") to stable 4.4 kernel introduced
> > > a bug when adding the needed blkif_ring_get_request() function, as
> > > info->ring.req_prod_pvt was incremented twice now.
> > > 
> > > Fix that be deleting the now superfluous increments after calling that
> > > function.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@suse.com>
> > > ---
> > >   drivers/block/xen-blkfront.c | 4 ----
> > >   1 file changed, 4 deletions(-)
> > 
> > So this is only needed in 4.4.y?  No other backports were incorrect?
> 
> Yes. 4.4 only.

Great, now queued up, thanks.

greg k-h


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 13:23:08 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 13:23:08 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251985.432968 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1pxh-00025C-74; Mon, 27 Dec 2021 13:22:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251985.432968; Mon, 27 Dec 2021 13:22:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1pxh-000255-3P; Mon, 27 Dec 2021 13:22:49 +0000
Received: by outflank-mailman (input) for mailman id 251985;
 Mon, 27 Dec 2021 13:22:48 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=I4x1=RM=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1n1pxg-00024z-0c
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 13:22:48 +0000
Received: from ams.source.kernel.org (ams.source.kernel.org
 [2604:1380:4601:e00::1])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 12aaea15-6718-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 14:22:46 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ams.source.kernel.org (Postfix) with ESMTPS id 6977AB8102E;
 Mon, 27 Dec 2021 13:22:42 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0687C36AEA;
 Mon, 27 Dec 2021 13:22:40 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 12aaea15-6718-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1640611361;
	bh=oIhYMV0TNwWQ1DJ3amUeZe8z+/TaiKP3lJFVwv/2FtI=;
	h=Subject:To:Cc:From:Date:In-Reply-To:From;
	b=gnFdWFPzWEZWTuBHCnbA45zveqXYJRm/xDyIUypleIlCcdBUwxr1VfZa5eBGksY2N
	 yf0eeNPTVBFaQo28VRSZCkpHuFdn6xlWlhyI3Nqtjr6nPB78I0oC1GyEa3uURO6xhU
	 gFnaR5cuU+/j+V4llvRU+0+knHof/0jhSD7VyZHE=
Subject: Patch "xen/blkfront: fix bug in backported patch" has been added to the 4.4-stable tree
To: gregkh@linuxfoundation.org,jgross@suse.com,xen-devel@lists.xenproject.org
Cc: <stable-commits@vger.kernel.org>
From: <gregkh@linuxfoundation.org>
Date: Mon, 27 Dec 2021 14:22:30 +0100
In-Reply-To: <20211223105308.17077-1-jgross@suse.com>
Message-ID: <164061135021254@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ANSI_X3.4-1968
Content-Transfer-Encoding: 8bit
X-stable: commit
X-Patchwork-Hint: ignore 


This is a note to let you know that I've just added the patch titled

    xen/blkfront: fix bug in backported patch

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     xen-blkfront-fix-bug-in-backported-patch.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From jgross@suse.com  Mon Dec 27 13:38:43 2021
From: Juergen Gross <jgross@suse.com>
Date: Thu, 23 Dec 2021 11:53:08 +0100
Subject: xen/blkfront: fix bug in backported patch
To: stable@vger.kernel.org
Cc: xen-devel@lists.xenproject.org, Juergen Gross <jgross@suse.com>
Message-ID: <20211223105308.17077-1-jgross@suse.com>

From: Juergen Gross <jgross@suse.com>

The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local
copy of a request from the ring page") to stable 4.4 kernel introduced
a bug when adding the needed blkif_ring_get_request() function, as
info->ring.req_prod_pvt was incremented twice now.

Fix that be deleting the now superfluous increments after calling that
function.

Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/block/xen-blkfront.c |    4 ----
 1 file changed, 4 deletions(-)

--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -493,8 +493,6 @@ static int blkif_queue_discard_req(struc
 	else
 		ring_req->u.discard.flag = 0;
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy the request to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;
@@ -711,8 +709,6 @@ static int blkif_queue_rw_req(struct req
 	if (setup.segments)
 		kunmap_atomic(setup.segments);
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy request(s) to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;


Patches currently in stable-queue which might be from jgross@suse.com are

queue-4.4/xen-blkfront-fix-bug-in-backported-patch.patch


From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252002.432979 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sM7-0007zV-Ms; Mon, 27 Dec 2021 15:56:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252002.432979; Mon, 27 Dec 2021 15:56:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sM7-0007zO-JI; Mon, 27 Dec 2021 15:56:11 +0000
Received: by outflank-mailman (input) for mailman id 252002;
 Mon, 27 Dec 2021 15:56:10 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sM6-0007zI-DB
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:10 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 7f916d7b-672d-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 16:56:07 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFttn6054480
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:01 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFttI6054479;
 Mon, 27 Dec 2021 07:55:55 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 7f916d7b-672d-11ec-9e60-abaf8a552007
Message-Id: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
Date: Sun, 26 Dec 2021 23:39:54 -0800
Subject: [PATCH 0/5] Some misc from my tree
X-Spam-Status: No, score=1.5 required=10.0 tests=DATE_IN_PAST_06_12,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Some bits I had run across when looking at a piece of libxl.

Even though the purpose of the functions suggests they won't modify the
memory passed in via pointer, marking them constant provides better
reassurance.

While list_domains_details() and printf_info() had similar purposes their
interfaces were wildly different.  Make them more consistent.  I was
aiming to turn dump_by_dominfo_list() into a wrapper around
dump_by_config(), but didn't quite get there.

Having the functions named "printf" is wrong.  They are generating output
in a fixed format, there is no control over the format.  That is a write
or dump operation, not a formatted print.

Elliott Mitchell (5):
  tools/libxl: Mark pointer args of many functions constant
  tools/xl: Mark libxl_domain_config * arg of printf_info_*() const
  tools/xl: Rename printf_info()/list_domains_details() to dump_by_...()
  tools/xl: Merge down debug/dry-run section of create_domain()
  tools/xl: Fix potential deallocation bug

 tools/include/libxl_json.h        | 22 +++++++++++---------
 tools/libs/light/gentypes.py      |  8 ++++----
 tools/libs/light/libxl_cpuid.c    |  2 +-
 tools/libs/light/libxl_internal.c |  4 ++--
 tools/libs/light/libxl_internal.h | 18 ++++++++--------
 tools/libs/light/libxl_json.c     | 18 ++++++++--------
 tools/libs/light/libxl_nocpuid.c  |  4 ++--
 tools/xl/xl.h                     | 10 ++++++++-
 tools/xl/xl_info.c                | 34 ++++++++++++++++---------------
 tools/xl/xl_misc.c                |  5 +----
 tools/xl/xl_sxp.c                 |  6 +++---
 tools/xl/xl_vmcontrol.c           | 14 +------------
 12 files changed, 72 insertions(+), 73 deletions(-)

-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252003.432990 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sME-0008GP-Us; Mon, 27 Dec 2021 15:56:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252003.432990; Mon, 27 Dec 2021 15:56:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sME-0008GG-Rg; Mon, 27 Dec 2021 15:56:18 +0000
Received: by outflank-mailman (input) for mailman id 252003;
 Mon, 27 Dec 2021 15:56:17 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sMD-0007zI-75
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:17 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 854ba648-672d-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 16:56:15 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFu4kE054486
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:10 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFu42s054485;
 Mon, 27 Dec 2021 07:56:04 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 854ba648-672d-11ec-9e60-abaf8a552007
Message-Id: <80dd561339dbe54f1ed2c2302ace389e87d445fe.1640590794.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1640590794.git.ehem+xen@m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
Date: Fri, 18 Dec 2020 13:37:44 -0800
Subject: [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
examining the pointed to thing, not modifying it.  This potentially
results in higher-performance output.  This also allows spreading
constants further, allowing more checking and security.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/include/libxl_json.h        | 22 ++++++++++++----------
 tools/libs/light/gentypes.py      |  8 ++++----
 tools/libs/light/libxl_cpuid.c    |  2 +-
 tools/libs/light/libxl_internal.c |  4 ++--
 tools/libs/light/libxl_internal.h | 18 +++++++++---------
 tools/libs/light/libxl_json.c     | 18 ++++++++++--------
 tools/libs/light/libxl_nocpuid.c  |  4 ++--
 7 files changed, 40 insertions(+), 36 deletions(-)

diff --git a/tools/include/libxl_json.h b/tools/include/libxl_json.h
index 260783bfde..63f0e58fe1 100644
--- a/tools/include/libxl_json.h
+++ b/tools/include/libxl_json.h
@@ -23,17 +23,19 @@
 #endif
 
 yajl_gen_status libxl__uint64_gen_json(yajl_gen hand, uint64_t val);
-yajl_gen_status libxl_defbool_gen_json(yajl_gen hand, libxl_defbool *p);
-yajl_gen_status libxl_uuid_gen_json(yajl_gen hand, libxl_uuid *p);
-yajl_gen_status libxl_mac_gen_json(yajl_gen hand, libxl_mac *p);
-yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand, libxl_bitmap *p);
+yajl_gen_status libxl_defbool_gen_json(yajl_gen hand, const libxl_defbool *p);
+yajl_gen_status libxl_uuid_gen_json(yajl_gen hand, const libxl_uuid *p);
+yajl_gen_status libxl_mac_gen_json(yajl_gen hand, const libxl_mac *p);
+yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand, const libxl_bitmap *p);
 yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
-                                                 libxl_cpuid_policy_list *p);
-yajl_gen_status libxl_string_list_gen_json(yajl_gen hand, libxl_string_list *p);
+                                                 const libxl_cpuid_policy_list *p);
+yajl_gen_status libxl_string_list_gen_json(yajl_gen hand,
+                                           const libxl_string_list *p);
 yajl_gen_status libxl_key_value_list_gen_json(yajl_gen hand,
-                                              libxl_key_value_list *p);
-yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand, libxl_hwcap *p);
-yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand, libxl_ms_vm_genid *p);
+                                              const libxl_key_value_list *p);
+yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand, const libxl_hwcap *p);
+yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand,
+                                           const libxl_ms_vm_genid *p);
 
 #include <_libxl_types_json.h>
 
@@ -91,6 +93,6 @@ static inline yajl_gen libxl_yajl_gen_alloc(const yajl_alloc_funcs *allocFuncs)
 #endif /* !HAVE_YAJL_V2 */
 
 yajl_gen_status libxl_domain_config_gen_json(yajl_gen hand,
-                                             libxl_domain_config *p);
+                                             const libxl_domain_config *p);
 
 #endif /* LIBXL_JSON_H */
diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py
index 9a45e45acc..7e02a5366f 100644
--- a/tools/libs/light/gentypes.py
+++ b/tools/libs/light/gentypes.py
@@ -632,7 +632,7 @@ if __name__ == '__main__':
                                                ty.make_arg("p"),
                                                ku.keyvar.type.make_arg(ku.keyvar.name)))
         if ty.json_gen_fn is not None:
-            f.write("%schar *%s_to_json(libxl_ctx *ctx, %s);\n" % (ty.hidden(), ty.typename, ty.make_arg("p")))
+            f.write("%schar *%s_to_json(libxl_ctx *ctx, const %s);\n" % (ty.hidden(), ty.typename, ty.make_arg("p")))
         if ty.json_parse_fn is not None:
             f.write("%sint %s_from_json(libxl_ctx *ctx, %s, const char *s);\n" % (ty.hidden(), ty.typename, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE)))
         if isinstance(ty, idl.Enumeration):
@@ -662,7 +662,7 @@ if __name__ == '__main__':
 """ % (header_json_define, header_json_define, " ".join(sys.argv)))
 
     for ty in [ty for ty in types if ty.json_gen_fn is not None]:
-        f.write("%syajl_gen_status %s_gen_json(yajl_gen hand, %s);\n" % (ty.hidden(), ty.typename, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE)))
+        f.write("%syajl_gen_status %s_gen_json(yajl_gen hand, const %s);\n" % (ty.hidden(), ty.typename, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE)))
 
     f.write("\n")
     f.write("""#endif /* %s */\n""" % header_json_define)
@@ -766,13 +766,13 @@ if __name__ == '__main__':
         f.write("\n")
 
     for ty in [t for t in types if t.json_gen_fn is not None]:
-        f.write("yajl_gen_status %s_gen_json(yajl_gen hand, %s)\n" % (ty.typename, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE)))
+        f.write("yajl_gen_status %s_gen_json(yajl_gen hand, const %s)\n" % (ty.typename, ty.make_arg("p", passby=idl.PASS_BY_REFERENCE)))
         f.write("{\n")
         f.write(libxl_C_type_gen_json(ty, "p"))
         f.write("}\n")
         f.write("\n")
 
-        f.write("char *%s_to_json(libxl_ctx *ctx, %s)\n" % (ty.typename, ty.make_arg("p")))
+        f.write("char *%s_to_json(libxl_ctx *ctx, const %s)\n" % (ty.typename, ty.make_arg("p")))
         f.write("{\n")
         f.write(libxl_C_type_to_json(ty, "p"))
         f.write("}\n")
diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
index e1acf6648d..b076d7f4a3 100644
--- a/tools/libs/light/libxl_cpuid.c
+++ b/tools/libs/light/libxl_cpuid.c
@@ -14,7 +14,7 @@
 
 #include "libxl_internal.h"
 
-int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl)
+int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl)
 {
     return !libxl_cpuid_policy_list_length(pl);
 }
diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_internal.c
index 86556b6113..da2dbd67ad 100644
--- a/tools/libs/light/libxl_internal.c
+++ b/tools/libs/light/libxl_internal.c
@@ -333,7 +333,7 @@ _hidden int libxl__parse_mac(const char *s, libxl_mac mac)
     return 0;
 }
 
-_hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b)
+_hidden int libxl__compare_macs(const libxl_mac *a, const libxl_mac *b)
 {
     int i;
 
@@ -345,7 +345,7 @@ _hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b)
     return 0;
 }
 
-_hidden int libxl__mac_is_default(libxl_mac *mac)
+_hidden int libxl__mac_is_default(const libxl_mac *mac)
 {
     return (!(*mac)[0] && !(*mac)[1] && !(*mac)[2] &&
             !(*mac)[3] && !(*mac)[4] && !(*mac)[5]);
diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h
index 37d5c27756..117a98acab 100644
--- a/tools/libs/light/libxl_internal.h
+++ b/tools/libs/light/libxl_internal.h
@@ -2080,9 +2080,9 @@ struct libxl__xen_console_reader {
 /* parse the string @s as a sequence of 6 colon separated bytes in to @mac */
 _hidden int libxl__parse_mac(const char *s, libxl_mac mac);
 /* compare mac address @a and @b. 0 if the same, -ve if a<b and +ve if a>b */
-_hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b);
+_hidden int libxl__compare_macs(const libxl_mac *a, const libxl_mac *b);
 /* return true if mac address is all zero (the default value) */
-_hidden int libxl__mac_is_default(libxl_mac *mac);
+_hidden int libxl__mac_is_default(const libxl_mac *mac);
 /* init a recursive mutex */
 _hidden int libxl__init_recursive_mutex(libxl_ctx *ctx, pthread_mutex_t *lock);
 
@@ -4580,7 +4580,7 @@ _hidden int libxl__ms_vm_genid_set(libxl__gc *gc, uint32_t domid,
 #define LIBXL__DEFBOOL_STR_DEFAULT "<default>"
 #define LIBXL__DEFBOOL_STR_FALSE   "False"
 #define LIBXL__DEFBOOL_STR_TRUE    "True"
-static inline int libxl__defbool_is_default(libxl_defbool *db)
+static inline int libxl__defbool_is_default(const libxl_defbool *db)
 {
     return !db->val;
 }
@@ -4675,22 +4675,22 @@ int libxl__random_bytes(libxl__gc *gc, uint8_t *buf, size_t len);
 #include "_libxl_types_internal_private.h"
 
 /* This always return false, there's no "default value" for hw cap */
-static inline int libxl__hwcap_is_default(libxl_hwcap *hwcap)
+static inline int libxl__hwcap_is_default(const libxl_hwcap *hwcap)
 {
     return 0;
 }
 
-static inline int libxl__string_list_is_empty(libxl_string_list *psl)
+static inline int libxl__string_list_is_empty(const libxl_string_list *psl)
 {
     return !libxl_string_list_length(psl);
 }
 
-static inline int libxl__key_value_list_is_empty(libxl_key_value_list *pkvl)
+static inline int libxl__key_value_list_is_empty(const libxl_key_value_list *pkvl)
 {
     return !libxl_key_value_list_length(pkvl);
 }
 
-int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl);
+int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl);
 
 /* Portability note: a proper flock(2) implementation is required */
 typedef struct {
@@ -4821,12 +4821,12 @@ void* libxl__device_list(libxl__gc *gc, const libxl__device_type *dt,
 void libxl__device_list_free(const libxl__device_type *dt,
                              void *list, int num);
 
-static inline bool libxl__timer_mode_is_default(libxl_timer_mode *tm)
+static inline bool libxl__timer_mode_is_default(const libxl_timer_mode *tm)
 {
     return *tm == LIBXL_TIMER_MODE_DEFAULT;
 }
 
-static inline bool libxl__string_is_default(char **s)
+static inline bool libxl__string_is_default(char *const *s)
 {
     return *s == NULL;
 }
diff --git a/tools/libs/light/libxl_json.c b/tools/libs/light/libxl_json.c
index 9b8ef2cab9..88e81f9905 100644
--- a/tools/libs/light/libxl_json.c
+++ b/tools/libs/light/libxl_json.c
@@ -95,7 +95,7 @@ yajl_gen_status libxl__yajl_gen_enum(yajl_gen hand, const char *str)
  * YAJL generators for builtin libxl types.
  */
 yajl_gen_status libxl_defbool_gen_json(yajl_gen hand,
-                                       libxl_defbool *db)
+                                       const libxl_defbool *db)
 {
     return libxl__yajl_gen_asciiz(hand, libxl_defbool_to_string(*db));
 }
@@ -137,7 +137,7 @@ int libxl__bool_parse_json(libxl__gc *gc, const libxl__json_object *o,
 }
 
 yajl_gen_status libxl_uuid_gen_json(yajl_gen hand,
-                                    libxl_uuid *uuid)
+                                    const libxl_uuid *uuid)
 {
     char buf[LIBXL_UUID_FMTLEN+1];
     snprintf(buf, sizeof(buf), LIBXL_UUID_FMT, LIBXL_UUID_BYTES((*uuid)));
@@ -154,7 +154,7 @@ int libxl__uuid_parse_json(libxl__gc *gc, const libxl__json_object *o,
 }
 
 yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand,
-                                      libxl_bitmap *bitmap)
+                                      const libxl_bitmap *bitmap)
 {
     yajl_gen_status s;
     int i;
@@ -208,7 +208,7 @@ int libxl__bitmap_parse_json(libxl__gc *gc, const libxl__json_object *o,
 }
 
 yajl_gen_status libxl_key_value_list_gen_json(yajl_gen hand,
-                                              libxl_key_value_list *pkvl)
+                                              const libxl_key_value_list *pkvl)
 {
     libxl_key_value_list kvl = *pkvl;
     yajl_gen_status s;
@@ -269,7 +269,8 @@ int libxl__key_value_list_parse_json(libxl__gc *gc, const libxl__json_object *o,
     return 0;
 }
 
-yajl_gen_status libxl_string_list_gen_json(yajl_gen hand, libxl_string_list *pl)
+yajl_gen_status libxl_string_list_gen_json(yajl_gen hand,
+                                           const libxl_string_list *pl)
 {
     libxl_string_list l = *pl;
     yajl_gen_status s;
@@ -322,7 +323,7 @@ int libxl__string_list_parse_json(libxl__gc *gc, const libxl__json_object *o,
     return 0;
 }
 
-yajl_gen_status libxl_mac_gen_json(yajl_gen hand, libxl_mac *mac)
+yajl_gen_status libxl_mac_gen_json(yajl_gen hand, const libxl_mac *mac)
 {
     char buf[LIBXL_MAC_FMTLEN+1];
     snprintf(buf, sizeof(buf), LIBXL_MAC_FMT, LIBXL_MAC_BYTES((*mac)));
@@ -339,7 +340,7 @@ int libxl__mac_parse_json(libxl__gc *gc, const libxl__json_object *o,
 }
 
 yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand,
-                                     libxl_hwcap *p)
+                                     const libxl_hwcap *p)
 {
     yajl_gen_status s;
     int i;
@@ -377,7 +378,8 @@ int libxl__hwcap_parse_json(libxl__gc *gc, const libxl__json_object *o,
     return 0;
 }
 
-yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand, libxl_ms_vm_genid *p)
+yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand,
+                                           const libxl_ms_vm_genid *p)
 {
     yajl_gen_status s;
     int i;
diff --git a/tools/libs/light/libxl_nocpuid.c b/tools/libs/light/libxl_nocpuid.c
index 0630959e76..f40a004e95 100644
--- a/tools/libs/light/libxl_nocpuid.c
+++ b/tools/libs/light/libxl_nocpuid.c
@@ -14,7 +14,7 @@
 
 #include "libxl_internal.h"
 
-int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl)
+int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl)
 {
     return 1;
 }
@@ -41,7 +41,7 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid, bool restore,
 }
 
 yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
-                                libxl_cpuid_policy_list *pcpuid)
+                                const libxl_cpuid_policy_list *pcpuid)
 {
     return 0;
 }
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:39 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:39 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252004.433001 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMP-0000CF-7S; Mon, 27 Dec 2021 15:56:29 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252004.433001; Mon, 27 Dec 2021 15:56:29 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMP-0000C8-3s; Mon, 27 Dec 2021 15:56:29 +0000
Received: by outflank-mailman (input) for mailman id 252004;
 Mon, 27 Dec 2021 15:56:28 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sMN-0000AO-Vz
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:27 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8b18dd06-672d-11ec-bb0b-79c175774b5d;
 Mon, 27 Dec 2021 16:56:26 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFuFg7054491
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:21 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFuFLH054490;
 Mon, 27 Dec 2021 07:56:15 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8b18dd06-672d-11ec-bb0b-79c175774b5d
Message-Id: <26c5803fdb59bd0bd06f2509097d5929dd4f67f2.1640590794.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1640590794.git.ehem+xen@m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Fri, 18 Dec 2020 13:32:33 -0800
Subject: [PATCH 2/5] tools/xl: Mark libxl_domain_config * arg of
 printf_info_*() const
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

With libxl having gotten a lot more constant, now printf_info_sexp() and
printf_info_one_json() can add consts.  May not be particularly
important, but it is best to mark things constant when they are known to
be so.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl.h      | 2 +-
 tools/xl/xl_info.c | 2 +-
 tools/xl/xl_sxp.c  | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index c5c4bedbdd..720adb0048 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -300,7 +300,7 @@ typedef enum {
     DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
 } domain_restart_type;
 
-extern void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh);
+extern void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh);
 extern void apply_global_affinity_masks(libxl_domain_type type,
                                         libxl_bitmap *vcpu_affinity_array,
                                         unsigned int size);
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 712b7638b0..23d82ce2a2 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -59,7 +59,7 @@ static int maybe_printf(const char *fmt, ...)
 }
 
 static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid,
-                                            libxl_domain_config *d_config)
+                                            const libxl_domain_config *d_config)
 {
     yajl_gen_status s;
 
diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c
index 359a001570..d5b9051dfc 100644
--- a/tools/xl/xl_sxp.c
+++ b/tools/xl/xl_sxp.c
@@ -26,13 +26,13 @@
 /* In general you should not add new output to this function since it
  * is intended only for legacy use.
  */
-void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh)
+void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh)
 {
     int i;
     libxl_dominfo info;
 
-    libxl_domain_create_info *c_info = &d_config->c_info;
-    libxl_domain_build_info *b_info = &d_config->b_info;
+    const libxl_domain_create_info *c_info = &d_config->c_info;
+    const libxl_domain_build_info *b_info = &d_config->b_info;
 
     fprintf(fh, "(domain\n\t(domid %d)\n", domid);
     fprintf(fh, "\t(create_info)\n");
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.251997.433012 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMS-0000YX-JX; Mon, 27 Dec 2021 15:56:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 251997.433012; Mon, 27 Dec 2021 15:56:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMS-0000YH-Fy; Mon, 27 Dec 2021 15:56:32 +0000
Received: by outflank-mailman (input) for mailman id 251997;
 Mon, 27 Dec 2021 15:27:35 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=I4x1=RM=linuxfoundation.org=gregkh@srs-se1.protection.inumbo.net>)
 id 1n1ruQ-0005HX-Qu
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:27:35 +0000
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 81aab310-6729-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 16:27:32 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 486C6610E8;
 Mon, 27 Dec 2021 15:27:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A36FC36AFC;
 Mon, 27 Dec 2021 15:27:29 +0000 (UTC)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 81aab310-6729-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1640618849;
	bh=lxj0CGnaQWsdrpP+ym0cjNUD1Q9ZWMmAFxZGfZWd1/4=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=AZU79SCaAAErcyL3XJjB+XBBxU4dseioz5c5PvS4Lsq93aZ/IHtGX7LXjsaCirRQI
	 okJI1qxDciPro2BGBrAhjz2CoFvk74dWshQcrz//RMzaBC+CXm0RqJ/p7e9JcwpCpS
	 6GEnZ/tyJxCniKjVglKa4jpSDA+bzmHfLRbvrrVs=
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"xen-devel@lists.xenproject.org, Juergen Gross" <jgross@suse.com>,
	Juergen Gross <jgross@suse.com>
Subject: [PATCH 4.4 12/17] xen/blkfront: fix bug in backported patch
Date: Mon, 27 Dec 2021 16:27:07 +0100
Message-Id: <20211227151316.349920128@linuxfoundation.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20211227151315.962187770@linuxfoundation.org>
References: <20211227151315.962187770@linuxfoundation.org>
User-Agent: quilt/0.66
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Juergen Gross <jgross@suse.com>

The backport of commit 8f5a695d99000fc ("xen/blkfront: don't take local
copy of a request from the ring page") to stable 4.4 kernel introduced
a bug when adding the needed blkif_ring_get_request() function, as
info->ring.req_prod_pvt was incremented twice now.

Fix that be deleting the now superfluous increments after calling that
function.

Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/block/xen-blkfront.c |    4 ----
 1 file changed, 4 deletions(-)

--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -493,8 +493,6 @@ static int blkif_queue_discard_req(struc
 	else
 		ring_req->u.discard.flag = 0;
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy the request to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;
@@ -711,8 +709,6 @@ static int blkif_queue_rw_req(struct req
 	if (setup.segments)
 		kunmap_atomic(setup.segments);
 
-	info->ring.req_prod_pvt++;
-
 	/* Copy request(s) to the ring page. */
 	*final_ring_req = *ring_req;
 	info->shadow[id].inflight = true;




From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252010.433023 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMY-00014e-TA; Mon, 27 Dec 2021 15:56:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252010.433023; Mon, 27 Dec 2021 15:56:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMY-00014U-PX; Mon, 27 Dec 2021 15:56:38 +0000
Received: by outflank-mailman (input) for mailman id 252010;
 Mon, 27 Dec 2021 15:56:37 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sMX-0007zI-Ea
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:37 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9163f135-672d-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 16:56:36 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFuO2j054498
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:32 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFuOhH054497;
 Mon, 27 Dec 2021 07:56:24 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9163f135-672d-11ec-9e60-abaf8a552007
Message-Id: <fdf4e903a675e3a9ec8794b92f164f6c571371e5.1640590794.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1640590794.git.ehem+xen@m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Thu, 17 Dec 2020 17:42:42 -0800
Subject: [PATCH 3/5] tools/xl: Rename printf_info()/list_domains_details() to
 dump_by_...()
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

printf_info()/list_domains_details() had been serving fairly similar
purposes.  Increase their consistency (add file-handle and output_format
arguments to list_domains_details(), reorder arguments) and then rename
to better reflect their functionality.

Both were simply outputting full domain information.  As this is more of
a dump operation, "dump" is a better name.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl.h      |  8 ++++++++
 tools/xl/xl_info.c | 30 ++++++++++++++++--------------
 tools/xl/xl_misc.c |  5 +----
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 720adb0048..be5f4e11fe 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -300,6 +300,14 @@ typedef enum {
     DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
 } domain_restart_type;
 
+extern void dump_by_config(enum output_format output_format,
+                           FILE *fh,
+                           const libxl_domain_config *d_config,
+                           int domid);
+extern void dump_by_dominfo_list(enum output_format output_format,
+                                 FILE *fh,
+                                 const libxl_dominfo info[],
+                                 int nb_domain);
 extern void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh);
 extern void apply_global_affinity_masks(libxl_domain_type type,
                                         libxl_bitmap *vcpu_affinity_array,
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 23d82ce2a2..3647468420 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -94,12 +94,10 @@ out:
     return s;
 }
 
-void printf_info(enum output_format output_format,
-                 int domid,
-                 libxl_domain_config *d_config, FILE *fh);
-void printf_info(enum output_format output_format,
-                 int domid,
-                 libxl_domain_config *d_config, FILE *fh)
+void dump_by_config(enum output_format output_format,
+                    FILE *fh,
+                    const libxl_domain_config *const d_config,
+                    int domid)
 {
     if (output_format == OUTPUT_FORMAT_SXP)
         return printf_info_sexp(domid, d_config, fh);
@@ -442,7 +440,10 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa,
     libxl_physinfo_dispose(&physinfo);
 }
 
-static void list_domains_details(const libxl_dominfo *info, int nb_domain)
+void dump_by_dominfo_list(enum output_format output_format,
+                          FILE *fh,
+                          const libxl_dominfo info[],
+                          int nb_domain)
 {
     libxl_domain_config d_config;
 
@@ -453,7 +454,7 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
     const char *buf;
     libxl_yajl_length yajl_len = 0;
 
-    if (default_output_format == OUTPUT_FORMAT_JSON) {
+    if (output_format == OUTPUT_FORMAT_JSON) {
         hand = libxl_yajl_gen_alloc(NULL);
         if (!hand) {
             fprintf(stderr, "unable to allocate JSON generator\n");
@@ -472,16 +473,16 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
                                                  &d_config, NULL);
         if (rc)
             continue;
-        if (default_output_format == OUTPUT_FORMAT_JSON)
+        if (output_format == OUTPUT_FORMAT_JSON)
             s = printf_info_one_json(hand, info[i].domid, &d_config);
         else
-            printf_info_sexp(info[i].domid, &d_config, stdout);
+            printf_info_sexp(info[i].domid, &d_config, fh);
         libxl_domain_config_dispose(&d_config);
         if (s != yajl_gen_status_ok)
             goto out;
     }
 
-    if (default_output_format == OUTPUT_FORMAT_JSON) {
+    if (output_format == OUTPUT_FORMAT_JSON) {
         s = yajl_gen_array_close(hand);
         if (s != yajl_gen_status_ok)
             goto out;
@@ -490,11 +491,12 @@ static void list_domains_details(const libxl_dominfo *info, int nb_domain)
         if (s != yajl_gen_status_ok)
             goto out;
 
-        puts(buf);
+        fputs(buf, fh);
+        fputc('\n', fh);
     }
 
 out:
-    if (default_output_format == OUTPUT_FORMAT_JSON) {
+    if (output_format == OUTPUT_FORMAT_JSON) {
         yajl_gen_free(hand);
         if (s != yajl_gen_status_ok)
             fprintf(stderr,
@@ -571,7 +573,7 @@ int main_list(int argc, char **argv)
     }
 
     if (details)
-        list_domains_details(info, nb_domain);
+        dump_by_dominfo_list(default_output_format, stdout, info, nb_domain);
     else
         list_domains(verbose, context, false /* claim */, numa, cpupool,
                      info, nb_domain);
diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
index 08f0fb6dc9..bcf178762b 100644
--- a/tools/xl/xl_misc.c
+++ b/tools/xl/xl_misc.c
@@ -256,9 +256,6 @@ int main_dump_core(int argc, char **argv)
     return EXIT_SUCCESS;
 }
 
-extern void printf_info(enum output_format output_format,
-                        int domid,
-                        libxl_domain_config *d_config, FILE *fh);
 int main_config_update(int argc, char **argv)
 {
     uint32_t domid;
@@ -344,7 +341,7 @@ int main_config_update(int argc, char **argv)
     parse_config_data(filename, config_data, config_len, &d_config);
 
     if (debug || dryrun_only)
-        printf_info(default_output_format, -1, &d_config, stdout);
+        dump_by_config(default_output_format, stdout, &d_config, -1);
 
     if (!dryrun_only) {
         fprintf(stderr, "setting dom%u configuration\n", domid);
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:56:59 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:56:59 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252017.433034 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMj-0001nz-5B; Mon, 27 Dec 2021 15:56:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252017.433034; Mon, 27 Dec 2021 15:56:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMj-0001nm-1O; Mon, 27 Dec 2021 15:56:49 +0000
Received: by outflank-mailman (input) for mailman id 252017;
 Mon, 27 Dec 2021 15:56:47 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sMh-0007zI-48
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:47 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 973dfb0a-672d-11ec-9e60-abaf8a552007;
 Mon, 27 Dec 2021 16:56:46 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFuaGj054512
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:42 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFuaVn054511;
 Mon, 27 Dec 2021 07:56:36 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 973dfb0a-672d-11ec-9e60-abaf8a552007
Message-Id: <8f95e4a6664a24fd990cbb8162a1855c95cb6b66.1640590794.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1640590794.git.ehem+xen@m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Thu, 17 Dec 2020 17:42:42 -0800
Subject: [PATCH 4/5] tools/xl: Merge down debug/dry-run section of
 create_domain()
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

create_domain()'s use of printf_info_sexp() could be merged down to a
single dump_by_config(), do so.  This results in an extra JSON dictionary
in output, but I doubt that is an issue for dry-run or debugging output.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl_vmcontrol.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
index 435155a033..4b95e7e463 100644
--- a/tools/xl/xl_vmcontrol.c
+++ b/tools/xl/xl_vmcontrol.c
@@ -856,19 +856,7 @@ int create_domain(struct domain_create *dom_info)
 
     if (debug || dom_info->dryrun) {
         FILE *cfg_print_fh = (debug && !dom_info->dryrun) ? stderr : stdout;
-        if (default_output_format == OUTPUT_FORMAT_SXP) {
-            printf_info_sexp(-1, &d_config, cfg_print_fh);
-        } else {
-            char *json = libxl_domain_config_to_json(ctx, &d_config);
-            if (!json) {
-                fprintf(stderr,
-                        "Failed to convert domain configuration to JSON\n");
-                exit(1);
-            }
-            fputs(json, cfg_print_fh);
-            free(json);
-            flush_stream(cfg_print_fh);
-        }
+        dump_by_config(default_output_format, cfg_print_fh, &d_config, -1);
     }
 
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 15:57:07 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 15:57:07 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252022.433045 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMr-0002SR-HD; Mon, 27 Dec 2021 15:56:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252022.433045; Mon, 27 Dec 2021 15:56:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1sMr-0002S4-BZ; Mon, 27 Dec 2021 15:56:57 +0000
Received: by outflank-mailman (input) for mailman id 252022;
 Mon, 27 Dec 2021 15:56:56 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=jnZ2=RM=m5p.com=ehem@srs-se1.protection.inumbo.net>)
 id 1n1sMq-0000AO-L3
 for xen-devel@lists.xenproject.org; Mon, 27 Dec 2021 15:56:56 +0000
Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9d13fa6c-672d-11ec-bb0b-79c175774b5d;
 Mon, 27 Dec 2021 16:56:55 +0100 (CET)
Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7])
 by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 1BRFujqi054523
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Mon, 27 Dec 2021 10:56:52 -0500 (EST) (envelope-from ehem@m5p.com)
Received: (from ehem@localhost)
 by m5p.com (8.16.1/8.15.2/Submit) id 1BRFujIk054522;
 Mon, 27 Dec 2021 07:56:45 -0800 (PST) (envelope-from ehem)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9d13fa6c-672d-11ec-bb0b-79c175774b5d
Message-Id: <2d1335a4056558d172d9aa3e59982eb761647418.1640590794.git.ehem+xen@m5p.com>
In-Reply-To: <cover.1640590794.git.ehem+xen@m5p.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
From: Elliott Mitchell <ehem+xen@m5p.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
Date: Thu, 10 Dec 2020 15:09:06 -0800
Subject: [PATCH 5/5] tools/xl: Fix potential deallocation bug
X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX,
	KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5
X-Spam-Level: **
X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com

There is potential for the info and info_free variable's purposes to
diverge.  If info was overwritten with a distinct value, yet info_free
still needed deallocation a bug would occur on this line.  Preemptively
address this issue (making use of divergent info/info_free values is
under consideration).

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 tools/xl/xl_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 3647468420..938f06f1a8 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -579,7 +579,7 @@ int main_list(int argc, char **argv)
                      info, nb_domain);
 
     if (info_free)
-        libxl_dominfo_list_free(info, nb_domain);
+        libxl_dominfo_list_free(info_free, nb_domain);
 
     libxl_dominfo_dispose(&info_buf);
 
-- 
2.30.2



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 19:05:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 19:05:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252062.433055 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1vIz-0004sF-0b; Mon, 27 Dec 2021 19:05:09 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252062.433055; Mon, 27 Dec 2021 19:05:08 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1vIy-0004s8-TR; Mon, 27 Dec 2021 19:05:08 +0000
Received: by outflank-mailman (input) for mailman id 252062;
 Mon, 27 Dec 2021 19:05:07 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=/RQl=RM=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n1vIx-0004rv-2T
 for xen-devel@lists.xen.org; Mon, 27 Dec 2021 19:05:07 +0000
Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com
 [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id e3a4cd75-6747-11ec-bb0b-79c175774b5d;
 Mon, 27 Dec 2021 20:05:02 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e3a4cd75-6747-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640631901;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=8bAk6cUK4cCgJtsDXc5EpJH4dqB+y26qg8KEwwoopkc=;
  b=IpYYkKA9DGOnL5fgFK2DQJOn7nilNuhBKZs9OD1uzG6eOyCAW6wWT7tO
   9IpXPbEhX4KBC9PwFSGw5C9xWRkxhZ7kuZO3Ml8nAOOqBsoHV2ioYsZsZ
   UllBxvcl4Zxl0zUn0QKtxsZOoPxAHHlpcgKkpLfFsgEoVslsofXiHVfXk
   w=;
Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: lRXa0Z4RaBCuuZ7TmRXf43/D3R5q37Aky3qV8V6bEXBr1VokA+SjUGfUFj5cQOzqMNDSagbust
 QAL8J4IZRHzwQBbziCLgxG3biz+1/lNWINecp1xqayzAY2fESs4n4E33+RNNGEGNrySZhMgLzN
 CfVq3DPfzR4dPmq1b9yaxaUOfF+sWuZ3HAszlQVttbnl93pHIfAlWw4ggf9dbX4muXX9hJHUeC
 y3rFg4LdPAw8mNm4udXEW2OuBn9f188hl3eNeWhbtbBy3PO5zJXz6OXMWfVSzWZzA6fAD3QLmu
 UQl0uqjJ1Q3b45BMg3V/JrqV
X-SBRS: 5.1
X-MesageID: 62956082
X-Ironport-Server: esa4.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:OPnD6asF1/ScabvADyXyDZfya+fnVJlZMUV32f8akzHdYApBsoF/q
 tZmKWGOMveNY2PyLdhwbYqw9BlUvJDVmN5nGgZkrigyQiJD+JbJXdiXEBz9bniYRiHhoOOLz
 Cm8hv3odp1coqr0/0/1WlTZQP0VOZigHtIQMsadUsxKbVIiGHdJZS5LwbZj29cy24fhWWthh
 PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe
 gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ
 NpliMW+ESxwb4D2wuEWTT1zAxtGL/BrweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3
 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2JofQKiGN
 5BxhTxHZTGdXixFYVcrOJMGueyFrEj/eCcCpwfAzUYwyzeKl1EguFT3C/LFd9rPSchLk0Kwo
 mPd43+/EhwcctuFxlKt/HO2i+rCgS78QqoPD7Ci7bhxh0CJzWEdDwcZWB29rOXRt6Klc4sBc
 QpOoHNo9PVsshzwJjXgY/GmiEPdsEY3Aot9Kbc/4x+p4bru2xTEK1FRG1atd+canMMxQDUr0
 HqAkNXoGSFjvdWpdJ6NyluHhWjsYHZIdAfucQdBFFJYuIe7/OnfmzqWFo47eJNZmOEZDt0ZL
 9qiiCElz4segscQv0lQ1QCW2mn8znQlo+Nc2+k2Yo5Hxl4gDGJGT9bxgbQ+0RqnBNzHJmRtR
 FBex6CjABkmVPlhbhClTuQXB62O7P2YKjDailMHN8B/q2zwpyL5It0PuGkWyKJV3iEsI2CBX
 aMukVkJuM870IWCM8ebnL5d++x1lPO9RLwJp9jfb8ZUY4gZSeN01HoGWKJk5Ei0yBJEufhmY
 f+zKJ/wZV5HWfUP5GfnHI81jO50rh3SMEuOHPgXOTz8iuHADJNUIJ9YWGazghcRsPnZ/V6Lq
 okHbKNnCXx3CYXDX8UeyqZKRXgiJnknH5Hm7ctRc++IOA19H289TfTWxNscl0ZNxsy5T8/Eo
 SOwXFF20l36iSGVIAmGcCk7OrjuQYx+vTQwOil1ZQSk3H0qYICO6qYDdsRoIel7pbI7lfMkH
 eMYf8igA+hUTmiV8ToqcpSg/pdpcw6mhFzSMnP9MiQ/ZZNpWyfA5sTgIln07CALAyfu7Zk+r
 rSs2xn1W50GQwg+Xs/aZOj2lwG6vGQHmfI0VEzNe4EBdELp+YlsCirwkv5ofJ1cdUSdnmOXj
 l/EDw0ZqO/Bp54O3OPI3a3U/Z20F+ZeH1ZBGzWJ57iBKiSHrHGoxpVNUbjUcGmFBn/04qire
 c5c0+r4bK8chF9PvodxT+RrwKY564e9rrNW1F05TnDCblDtAbJ8OHiWm8JIs/QVlLNevAK3X
 GOJ+8VbZurVaJ+0TgZJKVp3dPmH2NEVhiLWvKY8L0jN7SNq+KaKDBdJNB6WhS0BdLZ4PevJG
 wv6VBL6P+BnticXDw==
IronPort-HdrOrdr: A9a23:BY0XU6CxqHNOoCTlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq
 +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM
 NdmnFFeb/NMWQ=
X-IronPort-AV: E=Sophos;i="5.88,240,1635220800"; 
   d="scan'208";a="62956082"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Rg8M7blBKPKWWu5dMvhpRirHR63b2XxdSrZ9q3YuIjWB8K2gThAgwD5ppBc4NClojc+kEIFv4o2Jb0R+Q7m6nAakROHLhVfEP8ldHlaFJE+b5lnuTjeCI2UtLQuY53Kfi8Z8vD0nQVQ0sQHDUKp9ukqu+E4inPE3woeBJJaVcyczgj6Wal4y4DJ+Bw1dv8on1utVDvMhda33TVmqCHRneS25lRUvyva5whWO9nVRbdtaUbuzIAu3sPuBgwRYma/QlcSu22xRbpPsjnfDJu5bw+XT9wbA/ZEqwbmu0SYXwhOWzK7DKuJNM0t5KI+Ypfh61B7vomWSN6G3RafcLLwb4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xAk4XF8tvVh9xBscIEFUx52+6Fp2zsBn90ubOGdTIlU=;
 b=n31FWspLXqbYaHNM6XjYsh5UOAQzMhfghXLGeSocCLlBq1np24FOSe1YSYZo17NtS/mkKD2aXv7qCXbeZAQgRnjPEkm663sZCZd5y0A1SDIcfYJvmGhyI0K0j9m5oEGtJ1aO69ylefXf4EXAJr3CdiAYso40lnbBGI/5qfL42qeMngSMQCukHViQBv3sRdW84/hzj+mCCuL2GzTIF/WUQQ74jLgBjFyLZGEKLQzoduA4nNFDTSyHcbxIlOjZg35SC0QUW5z/KtBbI5aBgx+jFslyCqUiUATiy2BJe85h1TuRiuiqpuy7GDhnCy1oMdHWsmaFKRgocJ6U47OLc4RJPA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xAk4XF8tvVh9xBscIEFUx52+6Fp2zsBn90ubOGdTIlU=;
 b=e76W33Pqx1YyLQ7kd3zhs2/vO7odbhKSbxccl+QoyZaQWreh4CXNZq6PwFe0VgVjjKmAQ3JnVxibI8xSteHwRd16pbo1y3zjNqXeGGJ0ixgIl5HuDhEVBa7qRsipaA3O08KIWm8XD1csILjlKsnK3wEbTZuUKGOQW+/0uowFg2o=
Date: Mon, 27 Dec 2021 20:04:51 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: xen-devel <xen-devel@lists.xen.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcoOUw/u3SqTxWKm@Air-de-Roger>
References: <CAKhsbWZ5KCrwJqbchx31LWfaJeS=khP9sgoo4y8ZZqOexsUUdA@mail.gmail.com>
 <CAKhsbWYLC+cEuaJefi4Zy1ZcZaOtM6_2WV+9uq8=pTdi5NYLJA@mail.gmail.com>
 <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger>
 <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger>
 <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger>
 <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
X-ClientProxiedBy: MR1P264CA0003.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:2e::8) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 54145521-2b54-4371-c8d1-08d9c96bc5d5
X-MS-TrafficTypeDiagnostic: DM6PR03MB5178:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB51780B0F6E300334F72C75258F429@DM6PR03MB5178.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2449;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: eMAuuMhhuI1Oj6VBiPNaYrcowMzFaVIecj7QEwoEopRuxWSZ7loFN7gjQAawC7PcMMJCoBw8Xgs8vXIqxlG0uiw/RrNkpIGaO6WcsoxaJM6dwUrFJLU/aIPD7UnowYXxpJs0EGAZouvHtGw6ZBm9s/i701MVw1L08nHFTnWUBVxdp3nBu/5biL2cZ0TpGvb5wW5hKpBEiSOH9neN/4kQ6MhWOPD9IELb7PORovmbMWlUaVPmXrveBjkwIUHtNM1zPsfxnFQknFqCnZnKZnlbCj3s9130DhCUceyqe2WgLVOmUCj7EFlAZToO8aq63ZAdvP+C39gEJ692L2Pg+E6P856LNJsA/+DPfTl3yVgCXDrzHsqEW1/b6CbjF+HOeK39yCNwtlHAwVCnYZihmRRsh1cY9KE9TDqGyKpIzAeQT/t/Sh/f2RL6L38VqaC6NJIr2xdLMx6kkiTFA8f4hv8sKYOxa3R2cy29B/vBbvqloq+cFqQvZ5MUeCkoLqAKZn8HAAPK+MwOPgBWK98LurR6VGFzz2kPg2+1PAZIl3M8ELlV9yAHuwwG0bviyzAa4l+x/xEhR97jN05cjOwDDzx4Z6CV73oribMS7N89MYK8U1ZtnxEpw4u/Np+41wElsbtHtCs0QQ2u0H/Srz3dp0pdYlBu5C99NJ84LwjYKDe/3Fsxo9DtWFdN/Nchb3LfiDMk
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(83380400001)(85182001)(6666004)(4326008)(6506007)(9686003)(186003)(33716001)(8676002)(26005)(8936002)(38100700002)(5660300002)(6512007)(2906002)(6486002)(82960400001)(316002)(508600001)(66946007)(6916009)(86362001)(66556008)(66476007)(21314003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGVXRkhEeUM0YzF2VFFaQ1RYbVVySi9WY09QNGIyeHI3bk5xUGJKRCtTY1l0?=
 =?utf-8?B?cldDK3VTZkdCWlpsMkxTbHYrY0hmY2xqRit5YUV1ZUE5c056bGhrQ3o0OHZC?=
 =?utf-8?B?SU5FSFdjSXZjbUZteEtXd2VzanZicE1RbDIrOFlmSU5CNHlxY2RMMTlkZUxr?=
 =?utf-8?B?MXlLQi9mQ3ZpT0c1YzMvdFhwTm9oRFBrYU5VeUNDUDN3cnJpTzNwdGFWWHRE?=
 =?utf-8?B?R2w5amFMcTdHMnN6UXZ5cFYrVEc0VkFwTmdvOVViMG1jKzhxTksrR2ZPcm9S?=
 =?utf-8?B?TEhXaW8wVWpabVY2dWo5bW5pWVVVL2d1bUxzZlNxWSs5ZW9ReXRPRExXSm5F?=
 =?utf-8?B?ZS9zUE1obFM1dXVLeGJXd01SWk16MlExc1RrTXZNTFZCTWdDSWU4MVZWaE1C?=
 =?utf-8?B?b2hYNEVCNzZWTnQ5WC84Z01yNmJwM3ZEeGdpZFVLMEdQUXk4b2ZES1ZRSG8v?=
 =?utf-8?B?VEpEdFJnd0IzeEJTa1VOOEtWSEFYWkJWckFrVGE1YlJPc3UrNjFBWUNPUmN2?=
 =?utf-8?B?YSs4ZS9uNkVwUWhZMDB4R012TEdxMDMwZEJCRkZVb1NpVjR6bGZhRlpsU244?=
 =?utf-8?B?SGFJT29qeUExRk5yc0RNUGJoNmVNcWp0YldpelUvWlJYZ0tqblRvTjlna2hV?=
 =?utf-8?B?eGlCdHQyZzdsODhxMWk5VXRuQ2VocXhjMDBxMTRVcmxPOUVVWHEvcFhWb1Q3?=
 =?utf-8?B?Zk9nS0hGZ2tpcVRLWVhlSXdWNVpWNHR4OEwyakptMkVUNHUrVW5FS2s2U25k?=
 =?utf-8?B?Q0tRZTF3YUxyV0tFdDZJcEx3eWE4QzNJOXFYTWVNaktMUzFFSGJmMHNVVXhU?=
 =?utf-8?B?WElLZjdIYnRvWnZCTVBxQ2E1N0t4Nmt2UkN0Qy91UTlXQkJvaEcxM1JzZ1ZP?=
 =?utf-8?B?UkhpaFRrWFNQYXJEZFR5a201MzZWZ1hzTGtpalp4dURMcDdIOVp6T3RVclJF?=
 =?utf-8?B?MTMvenhWWUhXRU9hWW1KNWk1MkMvNVpzUmNXRXBuVCtRbEpDMDd6QzhyTTBv?=
 =?utf-8?B?ckpJOWJsbm1BVHdHcHh6OXh5QTdtUTV2UU4xRGhHS2dOT3NsTFBiZnNNUENN?=
 =?utf-8?B?cGlwVmFRUGJkL1FPSEUwYzUxTnlOdWQ2ajUyTFlSaDBWVS8zNm53cHMrUmE4?=
 =?utf-8?B?N1hkWGdKZHR4L3EvTG5MZWI4aUxINTNzdXFYb0dHZS9YanBtWlhxMms5T0xV?=
 =?utf-8?B?ZnYva0hhaTBWaXM2M2FZR1RSUzlOVHN3bkZyeWtITUs1QVV0dDhGUzkyZXhi?=
 =?utf-8?B?Q0JNank5a3F5ZXlhUEEyT084QnVyRGRmdEpXL2VGRzhyNGROZWtCSzhxR0tG?=
 =?utf-8?B?NHRKRm42bFE5WGRzMHpod29VRTlyTCtOQ2s4Z04vVWhZTWlRMlpqUFRwdUJR?=
 =?utf-8?B?TGhEeCtESGFmQWU3bFFlZWo0eVdJVFV4YUdWSzNZY012UFp1UVpTR3EyYWd6?=
 =?utf-8?B?QU9ndDh0UmdhcVBMNklaYlp2VGF0THUzVDdIa3ZCNTd6YzNlSzl0MnpWWWlr?=
 =?utf-8?B?R0dDbUI1a2FBZElTODZVZzFLNWVCdVFUMW1GOFhUVm44WjVtT2ROMkNTbGpz?=
 =?utf-8?B?anRkOVVZL0xmek92elNKYVZoMEVkM2t3K2FIem5uVnV0Q3lUY3BJK2JOL0V1?=
 =?utf-8?B?M3dNMnpReDM4bmpjYmFmUHdwc3hxSHdvTXVLRWtOWW9Scjk3MjNOYitzVGhq?=
 =?utf-8?B?dS9mN2V2KzVSU09lbFcvVXZzcmx4ZFJpRHdUbHF6d2lkRWtKMTd5VzRCMlcw?=
 =?utf-8?B?Q1p0WjQ4WW9XRHg0dzIzcGZyclprdFBDVnZXc3dHSTJhcGZwYlZBbkJBekRD?=
 =?utf-8?B?SllFK1dERzg3NmZmbzAzL2hmK2Y0RVFWcWZwTnZzSXA4VUNqeVJFd3JCUVcz?=
 =?utf-8?B?OVhrZm1qNVYyOHZrOWVCcFdiYWRxMitPdTVtN2dMZkttTmh5N2gwTDhtVFJK?=
 =?utf-8?B?MCtZdnBMWE1JRmJZY3YydGNzVldxNWxpK2dLaW9yaTFRUGVySi9oTTNxZVZK?=
 =?utf-8?B?WXdVQ0lqU3ptaTc2TGtSWEZkRTVNOG5XaGVFbWIzSlI3RUd3SWFpZjFhMGFR?=
 =?utf-8?B?N0w5cU1TbDdEd2JzSlJPUDV1L2s3aDUySVFUSmdDT0JjclVreWsvU0EvWGFI?=
 =?utf-8?B?MTRueTRJRnN2dkpUZGdPeXdXdG1sUW9OeGdDcXYyZi9mVjdtb21wcS9zdHJC?=
 =?utf-8?Q?DfqS/Ju96/i5S07Yarn3xiE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54145521-2b54-4371-c8d1-08d9c96bc5d5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2021 19:04:56.9003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: enL26twGN6c/1iULmazCtQ4cGf8HDcK4QNYXCyeselCnm9bgJisvjrV9b+1iAAPN3ZK63gURiIsTB/RTsLk77A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5178
X-OriginatorOrg: citrix.com

On Sun, Dec 26, 2021 at 02:06:55AM +0800, G.R. wrote:
> > > Thanks. I've raised this on freensd-net for advice [0]. IMO netfront
> > > shouldn't receive an mbuf that crosses a page boundary, but if that's
> > > indeed a legit mbuf I will figure out the best way to handle it.
> > >
> > > I have a clumsy patch (below) that might solve this, if you want to
> > > give it a try.
> >
> > Applied the patch and it worked like a charm!
> > Thank you so much for your quick help!
> > Wish you a wonderful holiday!
> 
> I may have said too quickly...
> With the patch I can attach the iscsi disk and neither the dom0 nor
> the NAS domU complains this time.
> But when I attempt to mount the attached disk it reports I/O errors randomly.
> By randomly I mean different disks behave differently...
> I don't see any error logs from kernels this time.
> (most of the iscsi disks are NTFS FS and mounted through the user mode
> fuse library)
> But since I have a local backup copy of the image, I can confirm that
> mounting that backup image does not result in any I/O error.
> Looks like something is still broken here...

Indeed. That patch was likely too simple, and didn't properly handle
the split of mbuf data buffers.

I have another version based on using sglist, which I think it's also
a worthwhile change for netfront. Can you please give it a try? I've
done a very simple test and seems fine, but you certainly have more
interesting cases.

You will have to apply it on top of a clean tree, without any of the
other patches applied.

Thanks, Roger.
---
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c
index 8dba5a8dc6d5..37ea7b1fa059 100644
--- a/sys/dev/xen/netfront/netfront.c
+++ b/sys/dev/xen/netfront/netfront.c
@@ -33,6 +33,8 @@ __FBSDID("$FreeBSD$");
 #include "opt_inet.h"
 #include "opt_inet6.h"
 
+#include <sys/types.h>
+
 #include <sys/param.h>
 #include <sys/sockio.h>
 #include <sys/limits.h>
@@ -40,6 +42,7 @@ __FBSDID("$FreeBSD$");
 #include <sys/malloc.h>
 #include <sys/module.h>
 #include <sys/kernel.h>
+#include <sys/sglist.h>
 #include <sys/socket.h>
 #include <sys/sysctl.h>
 #include <sys/taskqueue.h>
@@ -199,6 +202,12 @@ struct netfront_txq {
 	struct taskqueue 	*tq;
 	struct task       	defrtask;
 
+	struct sglist 		*segments;
+	struct mbuf_refcount {
+		struct m_tag 	tag;
+		u_int 		count;
+	}			refcount_tag[NET_TX_RING_SIZE + 1];
+
 	bool			full;
 };
 
@@ -301,6 +310,38 @@ xn_get_rx_ref(struct netfront_rxq *rxq, RING_IDX ri)
 	return (ref);
 }
 
+#define MTAG_REFCOUNT 0
+
+static void mbuf_grab(uint32_t cookie, struct mbuf *m)
+{
+	struct mbuf_refcount *ref;
+
+	ref = (struct mbuf_refcount *)m_tag_locate(m, cookie, MTAG_REFCOUNT,
+	    NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	ref->count++;
+}
+
+static void mbuf_release(uint32_t cookie, struct mbuf *m)
+{
+	struct mbuf_refcount *ref;
+
+	ref = (struct mbuf_refcount *)m_tag_locate(m, cookie, MTAG_REFCOUNT,
+	    NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	KASSERT(ref->count > 0, ("Invalid reference count"));
+
+	if(--ref->count == 0)
+		m_freem(m);
+}
+
+static void tag_free(struct m_tag *t)
+{
+	struct mbuf_refcount *ref = (struct mbuf_refcount *)t;
+
+	KASSERT(ref->count == 0, ("Free mbuf tag with pending refcnt"));
+}
+
 #define IPRINTK(fmt, args...) \
     printf("[XEN] " fmt, ##args)
 #ifdef INVARIANTS
@@ -778,7 +819,7 @@ disconnect_txq(struct netfront_txq *txq)
 static void
 destroy_txq(struct netfront_txq *txq)
 {
-
+	sglist_free(txq->segments);
 	free(txq->ring.sring, M_DEVBUF);
 	buf_ring_free(txq->br, M_DEVBUF);
 	taskqueue_drain_all(txq->tq);
@@ -826,6 +867,11 @@ setup_txqs(device_t dev, struct netfront_info *info,
 		for (i = 0; i <= NET_TX_RING_SIZE; i++) {
 			txq->mbufs[i] = (void *) ((u_long) i+1);
 			txq->grant_ref[i] = GRANT_REF_INVALID;
+			m_tag_setup(&txq->refcount_tag[i].tag,
+			    (unsigned long)txq, MTAG_REFCOUNT,
+			    sizeof(txq->refcount_tag[i]) -
+			    sizeof(txq->refcount_tag[i].tag));
+			txq->refcount_tag[i].tag.m_tag_free = &tag_free;
 		}
 		txq->mbufs[NET_TX_RING_SIZE] = (void *)0;
 
@@ -874,10 +920,18 @@ setup_txqs(device_t dev, struct netfront_info *info,
 			device_printf(dev, "xen_intr_alloc_and_bind_local_port failed\n");
 			goto fail_bind_port;
 		}
+
+		txq->segments = sglist_alloc(MAX_TX_REQ_FRAGS, M_WAITOK);
+		if (txq->segments == NULL) {
+			device_printf(dev, "failed to allocate sglist\n");
+			goto fail_sglist;
+		}
 	}
 
 	return (0);
 
+fail_sglist:
+	xen_intr_unbind(&txq->xen_intr_handle);
 fail_bind_port:
 	taskqueue_drain_all(txq->tq);
 fail_start_thread:
@@ -1041,7 +1095,7 @@ xn_release_tx_bufs(struct netfront_txq *txq)
 		if (txq->mbufs_cnt < 0) {
 			panic("%s: tx_chain_cnt must be >= 0", __func__);
 		}
-		m_free(m);
+		mbuf_release((unsigned long)txq, m);
 	}
 }
 
@@ -1311,7 +1365,7 @@ xn_txeof(struct netfront_txq *txq)
 			txq->mbufs[id] = NULL;
 			add_id_to_freelist(txq->mbufs, id);
 			txq->mbufs_cnt--;
-			m_free(m);
+			mbuf_release((unsigned long)txq, m);
 			/* Only mark the txq active if we've freed up at least one slot to try */
 			ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 		}
@@ -1507,22 +1561,6 @@ xn_get_responses(struct netfront_rxq *rxq,
 	return (err);
 }
 
-/**
- * \brief Count the number of fragments in an mbuf chain.
- *
- * Surprisingly, there isn't an M* macro for this.
- */
-static inline int
-xn_count_frags(struct mbuf *m)
-{
-	int nfrags;
-
-	for (nfrags = 0; m != NULL; m = m->m_next)
-		nfrags++;
-
-	return (nfrags);
-}
-
 /**
  * Given an mbuf chain, make sure we have enough room and then push
  * it onto the transmit ring.
@@ -1530,16 +1568,22 @@ xn_count_frags(struct mbuf *m)
 static int
 xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 {
-	struct mbuf *m;
 	struct netfront_info *np = txq->info;
 	struct ifnet *ifp = np->xn_ifp;
-	u_int nfrags;
-	int otherend_id;
+	u_int nfrags, i;
+	int otherend_id, rc;
+
+	sglist_reset(txq->segments);
+	rc = sglist_append_mbuf(txq->segments, m_head);
+	if (rc != 0) {
+		m_freem(m_head);
+		return (rc);
+	}
 
 	/**
 	 * Defragment the mbuf if necessary.
 	 */
-	nfrags = xn_count_frags(m_head);
+	nfrags = txq->segments->sg_nseg;
 
 	/*
 	 * Check to see whether this request is longer than netback
@@ -1551,6 +1595,8 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 	 * the Linux network stack.
 	 */
 	if (nfrags > np->maxfrags) {
+		struct mbuf *m;
+
 		m = m_defrag(m_head, M_NOWAIT);
 		if (!m) {
 			/*
@@ -1561,11 +1607,15 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			return (EMSGSIZE);
 		}
 		m_head = m;
+		sglist_reset(txq->segments);
+		rc = sglist_append_mbuf(txq->segments, m_head);
+		if (rc != 0) {
+			m_freem(m_head);
+			return (rc);
+		}
+		nfrags = txq->segments->sg_nseg;
 	}
 
-	/* Determine how many fragments now exist */
-	nfrags = xn_count_frags(m_head);
-
 	/*
 	 * Check to see whether the defragmented packet has too many
 	 * segments for the Linux netback driver.
@@ -1604,14 +1654,15 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 	 * the fragment pointers. Stop when we run out
 	 * of fragments or hit the end of the mbuf chain.
 	 */
-	m = m_head;
 	otherend_id = xenbus_get_otherend_id(np->xbdev);
-	for (m = m_head; m; m = m->m_next) {
+	for (i = 0; i < nfrags; i++) {
 		netif_tx_request_t *tx;
 		uintptr_t id;
 		grant_ref_t ref;
 		u_long mfn; /* XXX Wrong type? */
+		struct sglist_seg *seg;
 
+		seg = &txq->segments->sg_segs[i];
 		tx = RING_GET_REQUEST(&txq->ring, txq->ring.req_prod_pvt);
 		id = get_id_from_freelist(txq->mbufs);
 		if (id == 0)
@@ -1621,17 +1672,22 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 		if (txq->mbufs_cnt > NET_TX_RING_SIZE)
 			panic("%s: tx_chain_cnt must be <= NET_TX_RING_SIZE\n",
 			    __func__);
-		txq->mbufs[id] = m;
+		if (i == 0)
+			m_tag_prepend(m_head, &txq->refcount_tag[id].tag);
+		mbuf_grab((unsigned long)txq, m_head);
+		txq->mbufs[id] = m_head;
 		tx->id = id;
 		ref = gnttab_claim_grant_reference(&txq->gref_head);
 		KASSERT((short)ref >= 0, ("Negative ref"));
-		mfn = virt_to_mfn(mtod(m, vm_offset_t));
+		mfn = atop(seg->ss_paddr);
 		gnttab_grant_foreign_access_ref(ref, otherend_id,
 		    mfn, GNTMAP_readonly);
 		tx->gref = txq->grant_ref[id] = ref;
-		tx->offset = mtod(m, vm_offset_t) & (PAGE_SIZE - 1);
+		tx->offset = seg->ss_paddr & PAGE_MASK;
+		KASSERT(tx->offset + seg->ss_len <= PAGE_SIZE,
+		    ("mbuf segment crosses a page boundary"));
 		tx->flags = 0;
-		if (m == m_head) {
+		if (i == 0) {
 			/*
 			 * The first fragment has the entire packet
 			 * size, subsequent fragments have just the
@@ -1640,7 +1696,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * subtracting the sizes of the other
 			 * fragments.
 			 */
-			tx->size = m->m_pkthdr.len;
+			tx->size = m_head->m_pkthdr.len;
 
 			/*
 			 * The first fragment contains the checksum flags
@@ -1654,12 +1710,12 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * so we have to test for CSUM_TSO
 			 * explicitly.
 			 */
-			if (m->m_pkthdr.csum_flags
+			if (m_head->m_pkthdr.csum_flags
 			    & (CSUM_DELAY_DATA | CSUM_TSO)) {
 				tx->flags |= (NETTXF_csum_blank
 				    | NETTXF_data_validated);
 			}
-			if (m->m_pkthdr.csum_flags & CSUM_TSO) {
+			if (m_head->m_pkthdr.csum_flags & CSUM_TSO) {
 				struct netif_extra_info *gso =
 					(struct netif_extra_info *)
 					RING_GET_REQUEST(&txq->ring,
@@ -1667,7 +1723,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 
 				tx->flags |= NETTXF_extra_info;
 
-				gso->u.gso.size = m->m_pkthdr.tso_segsz;
+				gso->u.gso.size = m_head->m_pkthdr.tso_segsz;
 				gso->u.gso.type =
 					XEN_NETIF_GSO_TYPE_TCPV4;
 				gso->u.gso.pad = 0;
@@ -1677,9 +1733,9 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 				gso->flags = 0;
 			}
 		} else {
-			tx->size = m->m_len;
+			tx->size = seg->ss_len;
 		}
-		if (m->m_next)
+		if (i != nfrags - 1)
 			tx->flags |= NETTXF_more_data;
 
 		txq->ring.req_prod_pvt++;



From xen-devel-bounces@lists.xenproject.org Mon Dec 27 22:06:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Mon, 27 Dec 2021 22:06:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252090.433084 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1y8U-00061a-M1; Mon, 27 Dec 2021 22:06:30 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252090.433084; Mon, 27 Dec 2021 22:06:30 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n1y8U-00061T-Iv; Mon, 27 Dec 2021 22:06:30 +0000
Received: by outflank-mailman (input) for mailman id 252090;
 Mon, 27 Dec 2021 22:06:29 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1y8T-00061J-LR; Mon, 27 Dec 2021 22:06:29 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1y8T-0003XN-I8; Mon, 27 Dec 2021 22:06:29 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n1y8T-0000v9-4e; Mon, 27 Dec 2021 22:06:29 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n1y8T-0002DB-4A; Mon, 27 Dec 2021 22:06:29 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=NlRvNXvF2RVHcTNtm4trKLPCjHgt9URWFipXVm2CtzM=; b=cTZjW9m6P+KPhNsHZt8pzDS70J
	d84LVBMSlWKFcIJ4QOcQVPa4rwSwGqX6GDoW8ePMvv0E9ax9pOqZrM1QB5A4f12s8W5QkQ5nKmkht
	PhTDFAR86VKG1ED7J4xfYHYs9j87xOaRAniwZh2p23bYLiBUffIWgPB5U74J547uoLlw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167548-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167548: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=a8ad9a2434dc7967ab285437f443cae633b6fc1c
X-Osstest-Versions-That:
    linux=fc74e0a40e4f9fd0468e34045b0c45bba11dcbb2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Mon, 27 Dec 2021 22:06:29 +0000

flight 167548 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167548/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167544

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167544
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167544
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167544
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167544
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167544
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167544
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167544
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167544
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass

version targeted for testing:
 linux                a8ad9a2434dc7967ab285437f443cae633b6fc1c
baseline version:
 linux                fc74e0a40e4f9fd0468e34045b0c45bba11dcbb2

Last test of basis   167544  2021-12-27 00:39:17 Z    0 days
Testing same since   167548  2021-12-27 17:12:14 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Ard Biesheuvel <ardb@kernel.org>
  Javier Martinez Canillas <javierm@redhat.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Thomas Zimmermann <tzimmermann@suse.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   fc74e0a40e4f..a8ad9a2434dc  a8ad9a2434dc7967ab285437f443cae633b6fc1c -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 00:47:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 00:47:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252101.433096 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n20dU-0004j2-9B; Tue, 28 Dec 2021 00:46:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252101.433096; Tue, 28 Dec 2021 00:46:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n20dU-0004iv-61; Tue, 28 Dec 2021 00:46:40 +0000
Received: by outflank-mailman (input) for mailman id 252101;
 Tue, 28 Dec 2021 00:46:38 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n20dS-0004ih-8z; Tue, 28 Dec 2021 00:46:38 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n20dS-0006hV-5m; Tue, 28 Dec 2021 00:46:38 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n20dR-0005Ds-Oe; Tue, 28 Dec 2021 00:46:37 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n20dR-0001wb-OD; Tue, 28 Dec 2021 00:46:37 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=lY9tZ8H1HjzbXxD6nMkPe8NH5gBpSb1EmJKFH60lhtI=; b=GWCh+Rrp3V39dtqgYVYgOLpehZ
	U62x/PC/CvlsBl09GzNLND1CyKN+MACW2s31RDJeB8BVvqW7CVm1dt8L+x0jGG7sfL3geN4oc2oSE
	gbKAQAhrWAD8SdVTzSgjdKtuhwRVdnTSgTlFgqisKcuq7iA8e6+O84OXHmcTdDgGXNCc=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167549-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [seabios test] 167549: tolerable FAIL - PUSHED
X-Osstest-Failures:
    seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    seabios=6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9
X-Osstest-Versions-That:
    seabios=f9af71744a9f9a5d4804edcfcd14fd85e2d8a83b
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 28 Dec 2021 00:46:37 +0000

flight 167549 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167549/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167478
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167478
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167478
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167478
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167478
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass

version targeted for testing:
 seabios              6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9
baseline version:
 seabios              f9af71744a9f9a5d4804edcfcd14fd85e2d8a83b

Last test of basis   167478  2021-12-18 17:11:17 Z    9 days
Testing same since   167549  2021-12-27 17:12:29 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Kevin O'Connor <kevin@koconnor.net>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/seabios.git
   f9af717..6a62e0c  6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 03:50:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 03:50:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252115.433107 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n23VC-0007wV-Av; Tue, 28 Dec 2021 03:50:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252115.433107; Tue, 28 Dec 2021 03:50:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n23VC-0007wN-5T; Tue, 28 Dec 2021 03:50:18 +0000
Received: by outflank-mailman (input) for mailman id 252115;
 Tue, 28 Dec 2021 03:50:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Zee=RN=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n23V9-0007wH-O2
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 03:50:16 +0000
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com
 [2a00:1450:4864:20::132])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 4283c690-6791-11ec-9e60-abaf8a552007;
 Tue, 28 Dec 2021 04:50:13 +0100 (CET)
Received: by mail-lf1-x132.google.com with SMTP id g26so38628735lfv.11
 for <xen-devel@lists.xenproject.org>; Mon, 27 Dec 2021 19:50:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 4283c690-6791-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=0yz3CfWTnZ2MXKEK2VSRUIJs2UtkFLPNo94f4f4fXfk=;
        b=pVXkhqLsHm1YfaUXAzJd99TXiU0SlbvI/6KtzQ2sr+HHTPdHCVEJpt3HILj6lJESF4
         E/omQ3WrOQYzGbo7SkYE8kyr1O/OqROAnBhX9wSGuWkIjiedV9l2aFt8wWPVxr/VO5F5
         kbcwsY4JZAtw2C6c++wTBxnGqWjH9/lYD5USi8z0oURBw1Cu4VkXAKw0mTcNjET48Jrx
         OlfkJilxbyNmR87sSCslNBwvdF16xRT8I2I3Ovmiucbv02qfMIszRGWnw4pkH0Z0Vqix
         xvGLxGtVom214Ga8ugkPm/4/deRm/2l3voznuneWxmK4vJ2/ggtJ4oETKasp+RARi7Um
         w30Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=0yz3CfWTnZ2MXKEK2VSRUIJs2UtkFLPNo94f4f4fXfk=;
        b=tAR3gRBkKdHEkxS70oUiSdFpMVp1El9VmtMybEM0VhioQaPdfuZbHBmGjqF/YVWEXz
         kN7rNuCL8BQv5diPusNIEIiCtUC6vU3X/LwtCakSPwg3FerKO3G1EPucU2Lc68wkJdVp
         avliq4QH7rl7U+T+d8GYHe4FRxZnTomm0a/JcbLY8zOtMS2vriVcqh565ysQlHQiIOfl
         AtL68+drRpXldlQwXMLVPWXtx4CPUiv+Q5heuKiG7e7rs/RXkAdEmvKoNok2jlba312I
         C0iV9SDkxYavGK015zaiB//xK/Jn8f1fs151FTrgl3gj7QDLz4UJFhfEMF5TCFjtyaDJ
         cXyA==
X-Gm-Message-State: AOAM5312cOF9//eKsWzCyQkrd9lHw6c7fq50vI0B8Y5gQPrB/RER9HlJ
	tnl2OU4y183aN8m4AS0vvBUb2c3Wd1aV+AxKHX0=
X-Google-Smtp-Source: ABdhPJw1mBY/GDTKzwz4WNrjd32WcvCL5pGnw7hW+FxbooY1p+DnSGdKPLDWNRA13Ezn8i3pyjzXjPfYZNPEHI2K19s=
X-Received: by 2002:a05:6512:2356:: with SMTP id p22mr13639413lfu.490.1640663412079;
 Mon, 27 Dec 2021 19:50:12 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org> <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
In-Reply-To: <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Tue, 28 Dec 2021 11:50:01 +0800
Message-ID: <CABSBigTgh+0uoUCVAZTU=VLR5gMcxYQq7UjkU5GQfwvS2VaFrA@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Julien Grall <julien@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dongjiu Geng <gengdongjiu1@gmail.com> =E4=BA=8E2021=E5=B9=B412=E6=9C=8826=
=E6=97=A5=E5=91=A8=E6=97=A5 18:06=E5=86=99=E9=81=93=EF=BC=9A
>
> Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=97=
=A5=E5=91=A8=E4=BA=94 22:21=E5=86=99=E9=81=93=EF=BC=9A
> >
> > Hi,
> >
> > I am not sure why you dropped the others. I have added them back.
>
> sorry, it is my mistake
>
> >
> > On 24/12/2021 14:36, Dongjiu Geng wrote:
> > > Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=
=97=A5=E5=91=A8=E4=BA=94 21:25=E5=86=99=E9=81=93=EF=BC=9A
> > >>
> > >> Hi,
> > >>
> > >> On 24/12/2021 13:24, Dongjiu Geng wrote:
> > >>> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build f=
ailed.
> > >>> so fix it and make it can select GICV2.
> > >>
> > >> As I said in v1, last time I checked QEMU was only able to support
> > >> virtualization with GICv3. This is why we added a depends on.
> > >
> > > I enabled CONFIG_NEW_VGIC, then it will use GICv2. In my check, it
> > > does not report an error.
> > > My QEMU emulator version is 4.0.0.  What is the QEMU version that you=
 used?
> >
> > I am using a more recent QEMU. However, I have always only used GICv3
> > becuase it was IIRC there first.
> >
> > >
> > >>
> > >> If you want to remove it, then I think you ought to explain in the
> > >> commit message why this is fine. A pointer to the commit or a QEMU
> > >> version used would be useful.
> > >
> > > OK=EF=BC=8Cthanks. Can you check if QEMU 4.0.0 is workable with GICv2=
 on your side?
> >
> > I don't have direct access to my QEMU setup at the moment. However,
> > looking at the history.
> >
> > So I would suggest the following commit message:
> >
> > "
> > xen/arm: Allow QEMU platform to be built with GICv2
> >
> > Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> > complain about unmet dependencies:
> >
> > tools/kconfig/conf  --syncconfig Kconfig
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> >
> > It turns out that QEMU has been supporting GICv2 virtualization since
> > v3.1.0. So an easy way to solve the issue and allow more custom support
> > is to remove the dependencies on GICv3.
> > "
>
> Ok, thanks very much for your suggestion.
>
> >
> > > It is workable on my side.
> > >
> > >
> > >>
> > >>>
> > >>> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > >>> ---
> > >>> $ make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3Daarch64-lin=
ux-gnu- -j10
> > >>> make -C xen install
> > >>> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/k=
config/Makefile.kconfig ARCH=3Darm64 SRCARCH=3Darm HOSTCC=3D"gcc" HOSTCXX=
=3D"g++" syncconfig
> > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o=
 tools/kconfig/conf.c
> > >>> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/co=
nfdata.o tools/kconfig/confdata.c
> > >>> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o=
 tools/kconfig/expr.c
> > >>> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> > >>> bison -o tools/kconfig/parser.tab.c --defines=3Dtools/kconfig/parse=
r.tab.h -t -l tools/kconfig/parser.y
> > >>> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/=
preprocess.o tools/kconfig/preprocess.c
> > >>> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symb=
ol.o tools/kconfig/symbol.c
> > >>> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gen=
gdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.le=
x.o tools/kconfig/lexer.lex.c
> > >>> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/ge=
ngdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.=
tab.o tools/kconfig/parser.tab.c
> > >>> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confd=
ata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.t=
ab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> > >>> tools/kconfig/conf  --syncconfig Kconfig
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine=
/XEN/xen/xen'
> > >>> make -f Rules.mk _install
> > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> ---
> > >>>    xen/arch/arm/Kconfig           | 5 +++--
> > >>>    xen/arch/arm/platforms/Kconfig | 1 -
> > >>>    2 files changed, 3 insertions(+), 3 deletions(-)
> > >>>
> > >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > >>> index ecfa6822e4..373c698018 100644
> > >>> --- a/xen/arch/arm/Kconfig
> > >>> +++ b/xen/arch/arm/Kconfig
> > >>
> > >> The change in arch/arm/Kconfig is not really related to this patch.
> > >> Technically the part in platforms/Kconfig is sufficient. I still thi=
nk
> > >> the change is good to have but it should be in a separate patch.
> > >
> > > sure
> > >
> > >>
> > >>> @@ -35,7 +35,7 @@ config ACPI
> > >>>
> > >>>    config GICV3
> > >>>        bool "GICv3 driver"
> > >>> -     depends on ARM_64 && !NEW_VGIC
> > >>> +     depends on ARM_64
> > >>>        default y
> > >>>        ---help---
> > >>>
> > >>> @@ -44,13 +44,14 @@ config GICV3
> > >>>
> > >>>    config HAS_ITS
> > >>>            bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if=
 UNSUPPORTED
> > >>> -        depends on GICV3 && !NEW_VGIC
> > >>> +        depends on GICV3
> > >>>
> > >>>    config HVM
> > >>>            def_bool y
> > >>>
> > >>>    config NEW_VGIC
> > >>>        bool "Use new VGIC implementation"
> > >>> +     depends on !GICV3
> > >>>        ---help---
> > >>>
> > >>>        This is an alternative implementation of the ARM GIC interru=
pt
> > >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platform=
s/Kconfig
> > >>> index c93a6b2756..6d3ee99456 100644
> > >>> --- a/xen/arch/arm/platforms/Kconfig
> > >>> +++ b/xen/arch/arm/platforms/Kconfig
> > >>> @@ -15,7 +15,6 @@ config ALL_PLAT
> > >>>    config QEMU
> > >>>        bool "QEMU aarch virt machine support"
> > >>>        depends on ARM_64
> > >>> -     select GICV3
> > >>>        select HAS_PL011
> > >>>        ---help---
> > >>>        Enable all the required drivers for QEMU aarch64 virt emulat=
ed
> >
> > While writing a proposal for the commit message, I remembered that the
> > goal of CONFIG_QEMU was to select all the required drivers to be able t=
o
> > boot Xen on QEMU.
> >
> > AFAICT, if you start from tiny64_defconfig, you would not have GICv3
> > selected. So we would technically break users of QEMU with GICv3.

Hi, Julien

I revert my patch and generate the .config file using this comand :
"make tiny64_defconfig CROSS_COMPILE=3Daarch64-linux-gnu-
XEN_TARGET_ARCH=3Darm64"
The generated  .config[1] also does not select CONFIG_GICV3 and
CONFIG_NEW_VGIC.  I think you metioned issue does not related with my
changes.  thanks.


[1]
#
# Architecture Features
#
CONFIG_64BIT=3Dy
CONFIG_NR_CPUS=3D128
# CONFIG_GICV3 is not set
CONFIG_HVM=3Dy
# CONFIG_NEW_VGIC is not set



>
> I think I can add CONFIG_GICV3=3Dy in arch/arm/configs/tiny64_defconfig
> to this patch, if it must to use GICV3.
>
> >
> > I am not entirely sure how to approach it. I can think of 2 options:
> >
> >   1) Use 'select GICv3 if !NEW_VGIC'
> >   2) Add a specific platform for QEMU new vGIC
> >
> > I have the feeling that 1) will result to same unmet dependency issue.
> > Stefano any opinions?
>
> Stefano?
>
> >
> > Cheers,
> >
> > --
> > Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 04:14:47 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 04:14:47 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252122.433117 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n23se-00029l-D5; Tue, 28 Dec 2021 04:14:32 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252122.433117; Tue, 28 Dec 2021 04:14:32 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n23se-00029e-A9; Tue, 28 Dec 2021 04:14:32 +0000
Received: by outflank-mailman (input) for mailman id 252122;
 Tue, 28 Dec 2021 04:14:31 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Zee=RN=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n23sc-00029Y-Uf
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 04:14:30 +0000
Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com
 [2607:f8b0:4864:20::444])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id a670e34e-6794-11ec-bb0b-79c175774b5d;
 Tue, 28 Dec 2021 05:14:29 +0100 (CET)
Received: by mail-pf1-x444.google.com with SMTP id c2so15136779pfc.1
 for <xen-devel@lists.xenproject.org>; Mon, 27 Dec 2021 20:14:29 -0800 (PST)
Received: from localhost.localdomain ([47.89.83.13])
 by smtp.gmail.com with ESMTPSA id b1sm20108088pfl.101.2021.12.27.20.14.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 27 Dec 2021 20:14:27 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: a670e34e-6794-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=v8xdzRIoEkXuxNemtwcE/47FM5/HgSe5C87RjzNm/cE=;
        b=Px9Mk5QsWmLyPk84TxeGxq8nTLe03hooYhQpZQ4EGRTsUUSPay1oDKCsdsVrJokfTn
         uawiEve7jE763bF/bGaxRriYCkabjIncnnIbYnXb5vx4OrPV1n/yavCosPfp50Hx6v1V
         3XJst0NXn6fXqHrX+mVODyz/rEXm4u1MyuxtbBPXQzC8IuHoZcdpqQpN1AmOsFwGue7P
         q5cf5Ub/3myVfIReySh3W1jsDXBJsYV+rdhXqDBKjxuAPRBR1vFJZipRbBPEOKCbOCwx
         cCLeBu8tzoFSx62ERDvnefaW6EtBdihoBz1NWWLvHVtKPPOys/4CHNHZwoFMgegmVHJF
         WJEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
         :content-transfer-encoding;
        bh=v8xdzRIoEkXuxNemtwcE/47FM5/HgSe5C87RjzNm/cE=;
        b=rgIq7bp7/pz8ZGsehAgbdSFB5uOA3qtJUo03Lz7r9tPVADOqxYJxuLz8xxO++NI6cJ
         q70EfWYegI+NEAwt2iKua6OV/WgdnUCn1Ij7K1h422mN56SkaatK6PYMpM8hehymEm0U
         cAUFJEF/4eJX48vQF2FLh2bDRjHhqZ0HIHUkHo4y1mFce92jPlTyYClOs/8IqkQoW75T
         NE+tey92FiM55uFXm/TMFP11vDeXEV9zVb22u8XlxUm6I4wzJvtbAWUsFKN+OJjZxdh3
         Y2+u89BkF1/kQHDEGMcXIQZ7SG9pvo3EJNrCwa7t71v0MlaLmYJBAJStF39fBaONRFq9
         YwRA==
X-Gm-Message-State: AOAM530xj969CXs09PZCbs6rGG8d+gegzoCN4WMJTfimp9rD1CWhdfz7
	M5qZRdqlPFseyQGVGlLeQ2M=
X-Google-Smtp-Source: ABdhPJyHVJdZUEsSMDsVb5r34Vui/WTCCMu3mr7fZPG15S7z2waY+8eVgcuy78zpe0NRjnIijsARqA==
X-Received: by 2002:a63:3e41:: with SMTP id l62mr13381430pga.139.1640664868114;
        Mon, 27 Dec 2021 20:14:28 -0800 (PST)
From: Dongjiu Geng <gengdongjiu1@gmail.com>
To: sstabellini@kernel.org,
	julien@xen.org,
	Volodymyr_Babchuk@epam.com,
	bertrand.marquis@arm.com,
	xen-devel@lists.xenproject.org
Cc: gengdongjiu1@gmail.com
Subject: [PATCH v3] xen/arm: Allow QEMU platform to be built with GICv2
Date: Tue, 28 Dec 2021 12:14:23 +0800
Message-Id: <20211228041423.2231598-1-gengdongjiu1@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
complain about unmet dependencies:

tools/kconfig/conf  --syncconfig Kconfig

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]

WARNING: unmet direct dependencies detected for GICV3
   Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
   Selected by [y]:
   - QEMU [=y] && <choice> && ARM_64 [=y]

It turns out that QEMU has been supporting GICv2 virtualization since
v3.1.0. So an easy way to solve the issue and allow more custom support
is to remove the dependencies on GICv3.

Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
---
change since v1:
1. Address Stefano's comments to add dependency

change since v2:
1. Address Julien's comments to update the commit messages.
2. enable GICV3 in arch/arm/configs/tiny64_defconfig
---
 xen/arch/arm/Kconfig                  | 5 +++--
 xen/arch/arm/configs/tiny64_defconfig | 2 +-
 xen/arch/arm/platforms/Kconfig        | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa6822e4..373c698018 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -35,7 +35,7 @@ config ACPI
 
 config GICV3
 	bool "GICv3 driver"
-	depends on ARM_64 && !NEW_VGIC
+	depends on ARM_64
 	default y
 	---help---
 
@@ -44,13 +44,14 @@ config GICV3
 
 config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
-        depends on GICV3 && !NEW_VGIC
+        depends on GICV3
 
 config HVM
         def_bool y
 
 config NEW_VGIC
 	bool "Use new VGIC implementation"
+	depends on !GICV3
 	---help---
 
 	This is an alternative implementation of the ARM GIC interrupt
diff --git a/xen/arch/arm/configs/tiny64_defconfig b/xen/arch/arm/configs/tiny64_defconfig
index cc6d93f2f8..165603f7e0 100644
--- a/xen/arch/arm/configs/tiny64_defconfig
+++ b/xen/arch/arm/configs/tiny64_defconfig
@@ -4,7 +4,7 @@ CONFIG_ARM=y
 #
 # Architecture Features
 #
-# CONFIG_GICV3 is not set
+CONFIG_GICV3=y
 # CONFIG_MEM_ACCESS is not set
 # CONFIG_SBSA_VUART_CONSOLE is not set
 
diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
index c93a6b2756..925f6ef8da 100644
--- a/xen/arch/arm/platforms/Kconfig
+++ b/xen/arch/arm/platforms/Kconfig
@@ -15,7 +15,7 @@ config ALL_PLAT
 config QEMU
 	bool "QEMU aarch virt machine support"
 	depends on ARM_64
-	select GICV3
+	select GICv3 if !NEW_VGIC
 	select HAS_PL011
 	---help---
 	Enable all the required drivers for QEMU aarch64 virt emulated
-- 
2.25.1



From xen-devel-bounces@lists.xenproject.org Tue Dec 28 07:36:30 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 07:36:30 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252129.433129 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n271g-0004sm-P8; Tue, 28 Dec 2021 07:36:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252129.433129; Tue, 28 Dec 2021 07:36:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n271g-0004sf-Kv; Tue, 28 Dec 2021 07:36:04 +0000
Received: by outflank-mailman (input) for mailman id 252129;
 Tue, 28 Dec 2021 07:36:03 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n271f-0004sV-8k; Tue, 28 Dec 2021 07:36:03 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n271f-0007eV-5F; Tue, 28 Dec 2021 07:36:03 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n271e-0003eD-RC; Tue, 28 Dec 2021 07:36:02 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n271e-0000Fu-Ql; Tue, 28 Dec 2021 07:36:02 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=2CUe2hZTXBMnNMYNnFBEi7qn4tqTTO5SVRzSMft9CfQ=; b=DaTXujYacMzL+BeoA+1wl3Zt8l
	PK2FDaVMULGYs4kYLD8yZ0iG6hHLk6tbvAmDDblNLT+IV2pc6GPED7R9zT7XbxPbdMV+gLAxI5XZ2
	suS+93SURmY09jU1AXbiqTeq1345ThlKWn25nRNcg0QbZl8qiVW5RefmF/H+84zYsRK0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167551-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167551: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 28 Dec 2021 07:36:02 +0000

flight 167551 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167551/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  536 days
Failing since        151818  2020-07-11 04:18:52 Z  535 days  517 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    3 days    4 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 09:23:01 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 09:23:01 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252151.433140 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n28ge-0007TA-LM; Tue, 28 Dec 2021 09:22:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252151.433140; Tue, 28 Dec 2021 09:22:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n28ge-0007T3-HU; Tue, 28 Dec 2021 09:22:28 +0000
Received: by outflank-mailman (input) for mailman id 252151;
 Tue, 28 Dec 2021 09:22:27 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n28gd-0007St-7X; Tue, 28 Dec 2021 09:22:27 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n28gd-0001Wb-3l; Tue, 28 Dec 2021 09:22:27 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n28gc-0007oT-N9; Tue, 28 Dec 2021 09:22:26 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n28gc-0000pW-Mi; Tue, 28 Dec 2021 09:22:26 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=263o0W+zkac11Xk1f91s4Y6gAaZXGFnFciIJZlS+/8k=; b=mUJ8lxIuRBOBZqeswirIm2wXre
	Bo8ftmNqsVYtCXKcQbGzaYEAgqn6TxdUXx4f7etuvpsqpJU4/nES0BgiP8fNwhWe8xd4O5JMcrzd8
	96J6EbNrjwKLatS4mFp8ul6sU6BAAFQEKYiR5PtJTGaMUtjiz6S45BbQuj6nMHIUI8l0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167550-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167550: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 28 Dec 2021 09:22:26 +0000

flight 167550 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167550/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167545
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167545
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167545
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167545
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167545
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167545
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167545
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167545
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167545
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167545
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167545
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167545
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167550  2021-12-28 01:54:10 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Tue Dec 28 10:09:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 10:09:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252161.433151 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29Pv-0003T8-9N; Tue, 28 Dec 2021 10:09:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252161.433151; Tue, 28 Dec 2021 10:09:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29Pv-0003T1-56; Tue, 28 Dec 2021 10:09:15 +0000
Received: by outflank-mailman (input) for mailman id 252161;
 Tue, 28 Dec 2021 10:09:14 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n29Pt-0003Sr-UZ; Tue, 28 Dec 2021 10:09:13 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n29Pt-0002Ny-Rf; Tue, 28 Dec 2021 10:09:13 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n29Pt-0000X9-GC; Tue, 28 Dec 2021 10:09:13 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n29Pt-0002Iy-Fm; Tue, 28 Dec 2021 10:09:13 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=gZmpRXtlEhrBWPcc8/iONV/Rp98zg0yXGRzlsOTnm7E=; b=OBI7LcnpoZQ9M5HUJn7JNSxNi3
	g4FeqTYdrcvG4fSBXJe/CK/8pgnI1R1qtsPjGd7YmPSQQpfs07iMf57EL/nMobpM1MylNbOD7pAW6
	jTTlePb7B0oX5vmq4h6FpFDPB9avpTAW9HjC2WKOama3fixSRmzZmTZ2W94UjtRuNUDw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167552-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167552: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=e910f076ad02c80bb69cebb18d51ef6896beee0d
X-Osstest-Versions-That:
    ovmf=6612ff85611bc2be16dc0fd5de0e1413df88941a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Tue, 28 Dec 2021 10:09:13 +0000

flight 167552 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167552/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 e910f076ad02c80bb69cebb18d51ef6896beee0d
baseline version:
 ovmf                 6612ff85611bc2be16dc0fd5de0e1413df88941a

Last test of basis   167535  2021-12-24 09:12:58 Z    4 days
Testing same since   167552  2021-12-28 08:42:46 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Bob Feng <bob.c.feng@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   6612ff8561..e910f076ad  e910f076ad02c80bb69cebb18d51ef6896beee0d -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 10:27:28 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 10:27:28 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252170.433162 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29hD-0005o2-Rf; Tue, 28 Dec 2021 10:27:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252170.433162; Tue, 28 Dec 2021 10:27:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29hD-0005nv-OW; Tue, 28 Dec 2021 10:27:07 +0000
Received: by outflank-mailman (input) for mailman id 252170;
 Tue, 28 Dec 2021 10:27:07 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8vDp=RN=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1n29hD-0005np-2G
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 10:27:07 +0000
Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com
 [2a00:1450:4864:20::42e])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id b3fbb425-67c8-11ec-9e60-abaf8a552007;
 Tue, 28 Dec 2021 11:27:05 +0100 (CET)
Received: by mail-wr1-x42e.google.com with SMTP id d9so37558501wrb.0
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 02:27:05 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b3fbb425-67c8-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=fGJ6UuRYwCy3ENFhCHz+3SA3xRmM3TXbG4gIBgWcIsU=;
        b=TpeU3Sgqrq+iT+SItzLrWe2hdennvopfK+nxQ6eo4wJl521OWot9TW6plKU68b6SzQ
         4mwtSHtVg4zXkVqLbMyV+OJGidkjl48jixigLZTV6qnfYRh7hhXgWX8NUxU6fsTX+k43
         jnE4n3iRHeEUbDSEWRUa073tMIKM3iSeKv6ELKzoXG5ci5myVFLOWulwjwTW+R/TpoI6
         kN0goPuhog+43Oj2Usf4DcDCP9/6FJlZ127bQ3c5carqhfp5zM34G2VyCjkNKjVXao+A
         nxWDZ5XqkSpmxRwfxH/rutNgEf2E4WSQDdWsaivC1ipiUQFhyUNrJdyj7s0m0DoMBzHw
         IhRA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=fGJ6UuRYwCy3ENFhCHz+3SA3xRmM3TXbG4gIBgWcIsU=;
        b=sD59fVia9yV2T36dHGonXMMpOx1SN7Yn7uD9Wn4vJCwbXAcphT0Tf3Jc+q9t64mx5/
         oeCrNbGhref/gIq8IonMMRRJZJPZQjvJae2PRdindf2zVifMU81US+IuyIHwxWV+7Fse
         BdUGe4LLR20i3oZxlpBD6fywh5sZ1Qv8oioEGqkuua4LZafKoMuXMkoFzsZTdh8qpFcD
         IEtdNGnKiZJlMEiJHSHpFOCqKZ3Dq5PtysGirwpp6soCd43oP26BoYHDS+SCbbKEJRo6
         mjXX7dTv4dm6uwauxwthSnNXSIF9paauxd08cpFqNqmCrzrmxCC5xJ6xHuRG3PIMgy39
         N5/g==
X-Gm-Message-State: AOAM533whdhSVoiFmzezxCkZd+JSdrtJVO1mF+Z1UaLILMuditzYq22Y
	hpF8tXGyIuOAd95A+GbjnT/5LOIFSyHL53jTbAU=
X-Google-Smtp-Source: ABdhPJwSMLYOIMlPjiCc//kDhSPOVZJ0xy+Zgv+9n7A2uyVWOdBZ8iFDO/fYggQmwW2lsO3/NvE9doNGgm83bw81i04=
X-Received: by 2002:a5d:448f:: with SMTP id j15mr16322419wrq.603.1640687224890;
 Tue, 28 Dec 2021 02:27:04 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org> <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
In-Reply-To: <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 28 Dec 2021 11:26:53 +0100
Message-ID: <CAJ=z9a1o_-3A3=NKkbBT-s2EGM+WKJPiwxSt3q45PWs_9udcdw@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Dongjiu Geng <gengdongjiu1@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, 26 Dec 2021 at 11:07, Dongjiu Geng <gengdongjiu1@gmail.com> wrote:
>
> Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=97=
=A5=E5=91=A8=E4=BA=94 22:21=E5=86=99=E9=81=93=EF=BC=9A
> >
> > Hi,
> >
> > I am not sure why you dropped the others. I have added them back.
>
> sorry, it is my mistake
>
> >
> > On 24/12/2021 14:36, Dongjiu Geng wrote:
> > > Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=
=97=A5=E5=91=A8=E4=BA=94 21:25=E5=86=99=E9=81=93=EF=BC=9A
> > >>
> > >> Hi,
> > >>
> > >> On 24/12/2021 13:24, Dongjiu Geng wrote:
> > >>> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build f=
ailed.
> > >>> so fix it and make it can select GICV2.
> > >>
> > >> As I said in v1, last time I checked QEMU was only able to support
> > >> virtualization with GICv3. This is why we added a depends on.
> > >
> > > I enabled CONFIG_NEW_VGIC, then it will use GICv2. In my check, it
> > > does not report an error.
> > > My QEMU emulator version is 4.0.0.  What is the QEMU version that you=
 used?
> >
> > I am using a more recent QEMU. However, I have always only used GICv3
> > becuase it was IIRC there first.
> >
> > >
> > >>
> > >> If you want to remove it, then I think you ought to explain in the
> > >> commit message why this is fine. A pointer to the commit or a QEMU
> > >> version used would be useful.
> > >
> > > OK=EF=BC=8Cthanks. Can you check if QEMU 4.0.0 is workable with GICv2=
 on your side?
> >
> > I don't have direct access to my QEMU setup at the moment. However,
> > looking at the history.
> >
> > So I would suggest the following commit message:
> >
> > "
> > xen/arm: Allow QEMU platform to be built with GICv2
> >
> > Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> > complain about unmet dependencies:
> >
> > tools/kconfig/conf  --syncconfig Kconfig
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> >
> > It turns out that QEMU has been supporting GICv2 virtualization since
> > v3.1.0. So an easy way to solve the issue and allow more custom support
> > is to remove the dependencies on GICv3.
> > "
>
> Ok, thanks very much for your suggestion.
>
> >
> > > It is workable on my side.
> > >
> > >
> > >>
> > >>>
> > >>> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > >>> ---
> > >>> $ make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3Daarch64-lin=
ux-gnu- -j10
> > >>> make -C xen install
> > >>> make[1]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools/k=
config/Makefile.kconfig ARCH=3Darm64 SRCARCH=3Darm HOSTCC=3D"gcc" HOSTCXX=
=3D"g++" syncconfig
> > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf.o=
 tools/kconfig/conf.c
> > >>> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/co=
nfdata.o tools/kconfig/confdata.c
> > >>> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr.o=
 tools/kconfig/expr.c
> > >>> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> > >>> bison -o tools/kconfig/parser.tab.c --defines=3Dtools/kconfig/parse=
r.tab.h -t -l tools/kconfig/parser.y
> > >>> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfig/=
preprocess.o tools/kconfig/preprocess.c
> > >>> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/symb=
ol.o tools/kconfig/symbol.c
> > >>> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/gen=
gdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.le=
x.o tools/kconfig/lexer.lex.c
> > >>> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/ge=
ngdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parser.=
tab.o tools/kconfig/parser.tab.c
> > >>> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/confd=
ata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser.t=
ab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> > >>> tools/kconfig/conf  --syncconfig Kconfig
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>>
> > >>> WARNING: unmet direct dependencies detected for GICV3
> > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >>>     Selected by [y]:
> > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >>> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machine=
/XEN/xen/xen'
> > >>> make -f Rules.mk _install
> > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_machin=
e/XEN/xen/xen'
> > >>> ---
> > >>>    xen/arch/arm/Kconfig           | 5 +++--
> > >>>    xen/arch/arm/platforms/Kconfig | 1 -
> > >>>    2 files changed, 3 insertions(+), 3 deletions(-)
> > >>>
> > >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > >>> index ecfa6822e4..373c698018 100644
> > >>> --- a/xen/arch/arm/Kconfig
> > >>> +++ b/xen/arch/arm/Kconfig
> > >>
> > >> The change in arch/arm/Kconfig is not really related to this patch.
> > >> Technically the part in platforms/Kconfig is sufficient. I still thi=
nk
> > >> the change is good to have but it should be in a separate patch.
> > >
> > > sure
> > >
> > >>
> > >>> @@ -35,7 +35,7 @@ config ACPI
> > >>>
> > >>>    config GICV3
> > >>>        bool "GICv3 driver"
> > >>> -     depends on ARM_64 && !NEW_VGIC
> > >>> +     depends on ARM_64
> > >>>        default y
> > >>>        ---help---
> > >>>
> > >>> @@ -44,13 +44,14 @@ config GICV3
> > >>>
> > >>>    config HAS_ITS
> > >>>            bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if=
 UNSUPPORTED
> > >>> -        depends on GICV3 && !NEW_VGIC
> > >>> +        depends on GICV3
> > >>>
> > >>>    config HVM
> > >>>            def_bool y
> > >>>
> > >>>    config NEW_VGIC
> > >>>        bool "Use new VGIC implementation"
> > >>> +     depends on !GICV3
> > >>>        ---help---
> > >>>
> > >>>        This is an alternative implementation of the ARM GIC interru=
pt
> > >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platform=
s/Kconfig
> > >>> index c93a6b2756..6d3ee99456 100644
> > >>> --- a/xen/arch/arm/platforms/Kconfig
> > >>> +++ b/xen/arch/arm/platforms/Kconfig
> > >>> @@ -15,7 +15,6 @@ config ALL_PLAT
> > >>>    config QEMU
> > >>>        bool "QEMU aarch virt machine support"
> > >>>        depends on ARM_64
> > >>> -     select GICV3
> > >>>        select HAS_PL011
> > >>>        ---help---
> > >>>        Enable all the required drivers for QEMU aarch64 virt emulat=
ed
> >
> > While writing a proposal for the commit message, I remembered that the
> > goal of CONFIG_QEMU was to select all the required drivers to be able t=
o
> > boot Xen on QEMU.
> >
> > AFAICT, if you start from tiny64_defconfig, you would not have GICv3
> > selected. So we would technically break users of QEMU with GICv3.
>
> I think I can add CONFIG_GICV3=3Dy in arch/arm/configs/tiny64_defconfig
> to this patch, if it must to use GICV3.

Please don't update tiny64_defconfig. The goal of tiny64_defconfig is to
have a config with only the bare-minimum. If add CONFIG_GICV3=3Dy, then it =
will
be enabled when it is not necessary.

Cheers,


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 10:39:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 10:39:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252177.433173 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29t4-0007N5-W0; Tue, 28 Dec 2021 10:39:22 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252177.433173; Tue, 28 Dec 2021 10:39:22 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n29t4-0007My-Sl; Tue, 28 Dec 2021 10:39:22 +0000
Received: by outflank-mailman (input) for mailman id 252177;
 Tue, 28 Dec 2021 10:39:22 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8vDp=RN=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1n29t3-0007Ms-SW
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 10:39:21 +0000
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com
 [2a00:1450:4864:20::32c])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 6a3b4287-67ca-11ec-9e60-abaf8a552007;
 Tue, 28 Dec 2021 11:39:20 +0100 (CET)
Received: by mail-wm1-x32c.google.com with SMTP id b73so11335405wmd.0
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 02:39:20 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 6a3b4287-67ca-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=L9lOZ2zI+DBy+AlCbUUgEUdIHpOKtgV9YxuEHY1YS8c=;
        b=BXMM5J5hQF+lsgrDcp8S899WQfkoMeEyqlmGt8oMjPJpvm70jOf7DHoHaSBmBSl8xW
         SW/igJwkUYrs6srNE1Km06hrtZ29Ml32BPLFMlRejUcvC9D/9XdXBnXpbWkVFICT7nC3
         F5dAfi3ll2dt7nDdTqN2IqPZ8Y80qwrjKRJMiuhWxW9LrpQ5X5OvjYjWN4nlM2JhdlpQ
         gb9UNEX7OHQfDWwgpsrR8/2B0Jp0F5TvQEVOnbO7NoDJu2Z+pSyAkn5Je6Ryq7XJd3ya
         w0EN/YXKPHHOkWj3B0v9oMDg8GZaku7esknXwsSB9H8oiW4fXB3lgupPppQu8Iu1Qaxb
         oy6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=L9lOZ2zI+DBy+AlCbUUgEUdIHpOKtgV9YxuEHY1YS8c=;
        b=MCHNpYd0ZEuKj2n1az/mipcLgHPe/HRmuzBJm4QfKeg7Iyqn68HCS8ygxFTwh72hKF
         ofF/A7do7nsr3m5Fo4LXvFswoB/+hBCKz3aW82Co1wheXmVBBizg+gRIQyQm2yKVFs9Y
         DGHkSKIb9qYQxCNKbMIelI50EQEnV15JMry3MSU7/eWcjkjLpjGAI500mfzfvbrhSK9O
         xSq2z8f1FJ1ETA51HZJd9fvJLH3M+Pl0JwQ5NS0lQpP5XH5ibw9DFAL0Z/UNJWkhAv32
         UMJCMqFo2M/t6ENwktTGKsQd7k5u300ubXwk1b8QlGYuWjiKge64HC/Sw5kkm6w7Zmlq
         QJXQ==
X-Gm-Message-State: AOAM532tKp0bjbGWHM/gefT0SW+pVAASYsfhP/dENH14PzpFCuBVtzeg
	itJm1buEc+mdQcZLBWwAcG/XdOkCVDY7uGf+aNiHq/Gs9L8=
X-Google-Smtp-Source: ABdhPJxiIniXyJsLpmIPsVU+rUwz2YvH+0bifCmzDz/8aPmSeMks5CWe1YfsV6spEqbjzegQb6KIv0WZEJjRa378+iA=
X-Received: by 2002:a1c:a90b:: with SMTP id s11mr17149109wme.54.1640687960216;
 Tue, 28 Dec 2021 02:39:20 -0800 (PST)
MIME-Version: 1.0
References: <20211228041423.2231598-1-gengdongjiu1@gmail.com>
In-Reply-To: <20211228041423.2231598-1-gengdongjiu1@gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 28 Dec 2021 11:39:09 +0100
Message-ID: <CAJ=z9a2ww3OptqQn+KDdOMrRB_sSAicnVFQJ2UAySq5xZZjhTQ@mail.gmail.com>
Subject: Re: [PATCH v3] xen/arm: Allow QEMU platform to be built with GICv2
To: Dongjiu Geng <gengdongjiu1@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"

Hi,

On Tue, 28 Dec 2021 at 05:14, Dongjiu Geng <gengdongjiu1@gmail.com> wrote:
>
> Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> complain about unmet dependencies:
>
> tools/kconfig/conf  --syncconfig Kconfig
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
>
> WARNING: unmet direct dependencies detected for GICV3
>    Depends on [n]: ARM_64 [=y] && !NEW_VGIC [=y]
>    Selected by [y]:
>    - QEMU [=y] && <choice> && ARM_64 [=y]
>
> It turns out that QEMU has been supporting GICv2 virtualization since
> v3.1.0. So an easy way to solve the issue and allow more custom support
> is to remove the dependencies on GICv3.

You took my proposed commit message but the diff in
this version doesn't match it.

>
> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> ---
> change since v1:
> 1. Address Stefano's comments to add dependency
>
> change since v2:
> 1. Address Julien's comments to update the commit messages.
> 2. enable GICV3 in arch/arm/configs/tiny64_defconfig
> ---
>  xen/arch/arm/Kconfig                  | 5 +++--
>  xen/arch/arm/configs/tiny64_defconfig | 2 +-
>  xen/arch/arm/platforms/Kconfig        | 2 +-
>  3 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa6822e4..373c698018 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig

Are the changes necessary in arch/arm/Kconfig to solve the issue on QEMU?
If not, then they should be in a separate patch.
If yes, then they ought to be explained in the commit message.

> @@ -35,7 +35,7 @@ config ACPI
>
>  config GICV3
>         bool "GICv3 driver"
> -       depends on ARM_64 && !NEW_VGIC
> +       depends on ARM_64
>         default y
>         ---help---
>
> @@ -44,13 +44,14 @@ config GICV3
>
>  config HAS_ITS
>          bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
> -        depends on GICV3 && !NEW_VGIC
> +        depends on GICV3
>
>  config HVM
>          def_bool y
>
>  config NEW_VGIC
>         bool "Use new VGIC implementation"
> +       depends on !GICV3
>         ---help---
>
>         This is an alternative implementation of the ARM GIC interrupt
> diff --git a/xen/arch/arm/configs/tiny64_defconfig b/xen/arch/arm/configs/tiny64_defconfig
> index cc6d93f2f8..165603f7e0 100644
> --- a/xen/arch/arm/configs/tiny64_defconfig
> +++ b/xen/arch/arm/configs/tiny64_defconfig
> @@ -4,7 +4,7 @@ CONFIG_ARM=y
>  #
>  # Architecture Features
>  #
> -# CONFIG_GICV3 is not set
> +CONFIG_GICV3=y

The goal of tiny64_defconfig is to have nothing enabled by default.
So we should not enable GICV3 here.

>  # CONFIG_MEM_ACCESS is not set
>  # CONFIG_SBSA_VUART_CONSOLE is not set
>
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index c93a6b2756..925f6ef8da 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -15,7 +15,7 @@ config ALL_PLAT
>  config QEMU
>         bool "QEMU aarch virt machine support"
>         depends on ARM_64
> -       select GICV3
> +       select GICv3 if !NEW_VGIC

There was an open question in v2. In general, it is better to wait
until the discussion is closed or you mention it after ---. This
avoids being lost.

Cheers,

-- 
Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 11:37:33 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 11:37:33 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252205.433202 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2An5-00060Y-NY; Tue, 28 Dec 2021 11:37:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252205.433202; Tue, 28 Dec 2021 11:37:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2An5-00060R-Jh; Tue, 28 Dec 2021 11:37:15 +0000
Received: by outflank-mailman (input) for mailman id 252205;
 Tue, 28 Dec 2021 11:37:14 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Zee=RN=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n2An4-00060L-PV
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 11:37:14 +0000
Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com
 [2a00:1450:4864:20::229])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8023fc81-67d2-11ec-9e60-abaf8a552007;
 Tue, 28 Dec 2021 12:37:13 +0100 (CET)
Received: by mail-lj1-x229.google.com with SMTP id by39so30267304ljb.2
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 03:37:13 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8023fc81-67d2-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=U/NUykAyec1wy3uv/a1feJuKj6Ex7MYQxPOYhYu7ptM=;
        b=IMgAVwWZjNtSbACdlRHLYb6qY+H6GwWvtLFCVzYSQ9YZ4m9qqFKbZtyoBiwpkvgyCw
         S5SENc/+W0Zx5TJB8e3vChrHOZunIuV+7JJxSm0JfSfuzE6zOXq75Ohco5pIGv0Pvgiw
         p3LzR6F5CLC4w5UoAMoTHVBiA3a1JL8IGlXtZ2RBIpKE7TQtDWwEVUf211PidcYmkTj/
         v+HOGUzAbxuWpeKAPeXshqfdzS9vvAkRHg0OvM02nIJaYkplhBrSUxjEPfF7CUJrjMWs
         B472juvz6uJyuJqZQHkrIxXdfuPgMmVEww5FQaRZdj4xSrR3HmG0A5BrDilmjWHX7eHO
         qPeg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=U/NUykAyec1wy3uv/a1feJuKj6Ex7MYQxPOYhYu7ptM=;
        b=zqAEjUB9FR6zeXMmAYFfxI7PFkyJZv1+xFGLBsUSlECcymtNNxn/Y/yC20UTzaIB2M
         KdZnorO61mrhOk3L4lH5UVRzanEeUF+iB68CjEVV8VXWvoDQ82gdZA4lG5KdN01wOofX
         Zadcb8R+Ovs09uO6dzpfynF0prasq/MCliEc1inWSn1aD9bd8xt3NfhUSvIOBvDQUzNk
         38ZKQgZXqY3yup8EG8fJtBbEyTAdXebttl+PJe2pbFCgMw5hbeZJOcmSdu8gdlJGkaaN
         anrxUdLSQ2VZh8yc0DvqsFxf1/Je6TtJzm31C2ktgr3xA8at62BiV9OrWzJUqcjsVUI0
         o6GA==
X-Gm-Message-State: AOAM531PLydXh/0y9VeXeupjpJ8TgLfKCzxGVu0D6pqs9ngkDKTjQGdP
	i49HHU7HRbPo95fAk+6UDGSgQhLzIWN01wFIEeQ=
X-Google-Smtp-Source: ABdhPJz5zn2g+4ocIg97nPHGiYFBDkhk5qYNqJZcZo7VQIxIhEHAK/N6CA9vSgnlLPH0KCy8z645Ox05bAgztuFNffI=
X-Received: by 2002:a2e:aa9b:: with SMTP id bj27mr9536076ljb.23.1640691432887;
 Tue, 28 Dec 2021 03:37:12 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org> <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
 <CAJ=z9a1o_-3A3=NKkbBT-s2EGM+WKJPiwxSt3q45PWs_9udcdw@mail.gmail.com>
In-Reply-To: <CAJ=z9a1o_-3A3=NKkbBT-s2EGM+WKJPiwxSt3q45PWs_9udcdw@mail.gmail.com>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Tue, 28 Dec 2021 19:37:02 +0800
Message-ID: <CABSBigTyZ46OjvANi23e3sgL8+AKk73=3AOQnfvwhWcXhM-pgQ@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Julien Grall <julien.grall.oss@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Julien Grall <julien.grall.oss@gmail.com> =E4=BA=8E2021=E5=B9=B412=E6=9C=88=
28=E6=97=A5=E5=91=A8=E4=BA=8C 18:27=E5=86=99=E9=81=93=EF=BC=9A
>
> Hello,
>
> On Sun, 26 Dec 2021 at 11:07, Dongjiu Geng <gengdongjiu1@gmail.com> wrote=
:
> >
> > Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=E6=97=
=A5=E5=91=A8=E4=BA=94 22:21=E5=86=99=E9=81=93=EF=BC=9A
> > >
> > > Hi,
> > >
> > > I am not sure why you dropped the others. I have added them back.
> >
> > sorry, it is my mistake
> >
> > >
> > > On 24/12/2021 14:36, Dongjiu Geng wrote:
> > > > Julien Grall <julien@xen.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=8824=
=E6=97=A5=E5=91=A8=E4=BA=94 21:25=E5=86=99=E9=81=93=EF=BC=9A
> > > >>
> > > >> Hi,
> > > >>
> > > >> On 24/12/2021 13:24, Dongjiu Geng wrote:
> > > >>> when enable CONFIG_NEW_VGIC in ARM64 QEMU Platform, it will build=
 failed.
> > > >>> so fix it and make it can select GICV2.
> > > >>
> > > >> As I said in v1, last time I checked QEMU was only able to support
> > > >> virtualization with GICv3. This is why we added a depends on.
> > > >
> > > > I enabled CONFIG_NEW_VGIC, then it will use GICv2. In my check, it
> > > > does not report an error.
> > > > My QEMU emulator version is 4.0.0.  What is the QEMU version that y=
ou used?
> > >
> > > I am using a more recent QEMU. However, I have always only used GICv3
> > > becuase it was IIRC there first.
> > >
> > > >
> > > >>
> > > >> If you want to remove it, then I think you ought to explain in the
> > > >> commit message why this is fine. A pointer to the commit or a QEMU
> > > >> version used would be useful.
> > > >
> > > > OK=EF=BC=8Cthanks. Can you check if QEMU 4.0.0 is workable with GIC=
v2 on your side?
> > >
> > > I don't have direct access to my QEMU setup at the moment. However,
> > > looking at the history.
> > >
> > > So I would suggest the following commit message:
> > >
> > > "
> > > xen/arm: Allow QEMU platform to be built with GICv2
> > >
> > > Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> > > complain about unmet dependencies:
> > >
> > > tools/kconfig/conf  --syncconfig Kconfig
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >
> > > WARNING: unmet direct dependencies detected for GICV3
> > >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > >    Selected by [y]:
> > >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > >
> > >
> > > It turns out that QEMU has been supporting GICv2 virtualization since
> > > v3.1.0. So an easy way to solve the issue and allow more custom suppo=
rt
> > > is to remove the dependencies on GICv3.
> > > "
> >
> > Ok, thanks very much for your suggestion.
> >
> > >
> > > > It is workable on my side.
> > > >
> > > >
> > > >>
> > > >>>
> > > >>> Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > > >>> ---
> > > >>> $ make dist-xen XEN_TARGET_ARCH=3Darm64 CROSS_COMPILE=3Daarch64-l=
inux-gnu- -j10
> > > >>> make -C xen install
> > > >>> make[1]: Entering directory '/home/workspace/gengdongjiu/old_mach=
ine/XEN/xen/xen'
> > > >>> make -f /home/workspace/gengdongjiu/old_machine/XEN/xen/xen/tools=
/kconfig/Makefile.kconfig ARCH=3Darm64 SRCARCH=3Darm HOSTCC=3D"gcc" HOSTCXX=
=3D"g++" syncconfig
> > > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_mach=
ine/XEN/xen/xen'
> > > >>> gcc -Wp,-MD,tools/kconfig/.conf.o.d      -c -o tools/kconfig/conf=
.o tools/kconfig/conf.c
> > > >>> gcc -Wp,-MD,tools/kconfig/.confdata.o.d      -c -o tools/kconfig/=
confdata.o tools/kconfig/confdata.c
> > > >>> gcc -Wp,-MD,tools/kconfig/.expr.o.d      -c -o tools/kconfig/expr=
.o tools/kconfig/expr.c
> > > >>> flex -otools/kconfig/lexer.lex.c -L tools/kconfig/lexer.l
> > > >>> bison -o tools/kconfig/parser.tab.c --defines=3Dtools/kconfig/par=
ser.tab.h -t -l tools/kconfig/parser.y
> > > >>> gcc -Wp,-MD,tools/kconfig/.preprocess.o.d      -c -o tools/kconfi=
g/preprocess.o tools/kconfig/preprocess.c
> > > >>> gcc -Wp,-MD,tools/kconfig/.symbol.o.d      -c -o tools/kconfig/sy=
mbol.o tools/kconfig/symbol.c
> > > >>> gcc -Wp,-MD,tools/kconfig/.lexer.lex.o.d     -I /home/workspace/g=
engdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/lexer.=
lex.o tools/kconfig/lexer.lex.c
> > > >>> gcc -Wp,-MD,tools/kconfig/.parser.tab.o.d     -I /home/workspace/=
gengdongjiu/old_machine/XEN/xen/xen/tools/kconfig -c -o tools/kconfig/parse=
r.tab.o tools/kconfig/parser.tab.c
> > > >>> gcc  -o tools/kconfig/conf tools/kconfig/conf.o tools/kconfig/con=
fdata.o tools/kconfig/expr.o tools/kconfig/lexer.lex.o tools/kconfig/parser=
.tab.o tools/kconfig/preprocess.o tools/kconfig/symbol.o
> > > >>> tools/kconfig/conf  --syncconfig Kconfig
> > > >>>
> > > >>> WARNING: unmet direct dependencies detected for GICV3
> > > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > > >>>     Selected by [y]:
> > > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > > >>>
> > > >>> WARNING: unmet direct dependencies detected for GICV3
> > > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > > >>>     Selected by [y]:
> > > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > > >>>
> > > >>> WARNING: unmet direct dependencies detected for GICV3
> > > >>>     Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> > > >>>     Selected by [y]:
> > > >>>     - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> > > >>> make[2]: Leaving directory '/home/workspace/gengdongjiu/old_machi=
ne/XEN/xen/xen'
> > > >>> make -f Rules.mk _install
> > > >>> make[2]: Entering directory '/home/workspace/gengdongjiu/old_mach=
ine/XEN/xen/xen'
> > > >>> ---
> > > >>>    xen/arch/arm/Kconfig           | 5 +++--
> > > >>>    xen/arch/arm/platforms/Kconfig | 1 -
> > > >>>    2 files changed, 3 insertions(+), 3 deletions(-)
> > > >>>
> > > >>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > > >>> index ecfa6822e4..373c698018 100644
> > > >>> --- a/xen/arch/arm/Kconfig
> > > >>> +++ b/xen/arch/arm/Kconfig
> > > >>
> > > >> The change in arch/arm/Kconfig is not really related to this patch=
.
> > > >> Technically the part in platforms/Kconfig is sufficient. I still t=
hink
> > > >> the change is good to have but it should be in a separate patch.
> > > >
> > > > sure
> > > >
> > > >>
> > > >>> @@ -35,7 +35,7 @@ config ACPI
> > > >>>
> > > >>>    config GICV3
> > > >>>        bool "GICv3 driver"
> > > >>> -     depends on ARM_64 && !NEW_VGIC
> > > >>> +     depends on ARM_64
> > > >>>        default y
> > > >>>        ---help---
> > > >>>
> > > >>> @@ -44,13 +44,14 @@ config GICV3
> > > >>>
> > > >>>    config HAS_ITS
> > > >>>            bool "GICv3 ITS MSI controller support (UNSUPPORTED)" =
if UNSUPPORTED
> > > >>> -        depends on GICV3 && !NEW_VGIC
> > > >>> +        depends on GICV3
> > > >>>
> > > >>>    config HVM
> > > >>>            def_bool y
> > > >>>
> > > >>>    config NEW_VGIC
> > > >>>        bool "Use new VGIC implementation"
> > > >>> +     depends on !GICV3
> > > >>>        ---help---
> > > >>>
> > > >>>        This is an alternative implementation of the ARM GIC inter=
rupt
> > > >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platfo=
rms/Kconfig
> > > >>> index c93a6b2756..6d3ee99456 100644
> > > >>> --- a/xen/arch/arm/platforms/Kconfig
> > > >>> +++ b/xen/arch/arm/platforms/Kconfig
> > > >>> @@ -15,7 +15,6 @@ config ALL_PLAT
> > > >>>    config QEMU
> > > >>>        bool "QEMU aarch virt machine support"
> > > >>>        depends on ARM_64
> > > >>> -     select GICV3
> > > >>>        select HAS_PL011
> > > >>>        ---help---
> > > >>>        Enable all the required drivers for QEMU aarch64 virt emul=
ated
> > >
> > > While writing a proposal for the commit message, I remembered that th=
e
> > > goal of CONFIG_QEMU was to select all the required drivers to be able=
 to
> > > boot Xen on QEMU.
> > >
> > > AFAICT, if you start from tiny64_defconfig, you would not have GICv3
> > > selected. So we would technically break users of QEMU with GICv3.
> >
> > I think I can add CONFIG_GICV3=3Dy in arch/arm/configs/tiny64_defconfig
> > to this patch, if it must to use GICV3.
>
> Please don't update tiny64_defconfig. The goal of tiny64_defconfig is to
> have a config with only the bare-minimum. If add CONFIG_GICV3=3Dy, then i=
t will
> be enabled when it is not necessary.

Ok=EF=BC=8Cwe can let the user configure the CONFIG_GICV3 in tiny64_defconf=
ig
according his neccesary.
So I think my modification does not affect the tiny64_defconfig. what
is your concern about it?

>
> Cheers,


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 11:52:19 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 11:52:19 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252219.433212 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2B1Q-0008Om-5z; Tue, 28 Dec 2021 11:52:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252219.433212; Tue, 28 Dec 2021 11:52:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2B1Q-0008Of-2s; Tue, 28 Dec 2021 11:52:04 +0000
Received: by outflank-mailman (input) for mailman id 252219;
 Tue, 28 Dec 2021 11:52:03 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Zee=RN=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n2B1P-0008OZ-Ah
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 11:52:03 +0000
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [2a00:1450:4864:20::241])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 91e98413-67d4-11ec-9e60-abaf8a552007;
 Tue, 28 Dec 2021 12:52:02 +0100 (CET)
Received: by mail-lj1-x241.google.com with SMTP id q8so14606592ljp.9
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 03:52:02 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 91e98413-67d4-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=Z6SWZpdODlnO8czlhOLq31vh6FeRlmcNPXpjA4PbQwY=;
        b=oQG6xg0FTkr5RfkZAoN5tq8eIvqXNu0zWTX+RLHxhTfFretludqmIh4dsUregrWua5
         LDmIPPsf9j0fCZ/z6MWd6yDKZd2bkpDKKtS3GYSx2Du8N6i675D0AonSfkmgHaSRSKVU
         PH59kgtWLtP6dm+TEtu7Q83uGvKFjyq/v/qQtMlMBqXWyWeC1j+Br7RWN28Up0m1fAcV
         3erFnyk27aaaw6DDMdmziMI6e38hnb+V3PKkArtKu7uStS8LMsmHPXxIZptvlpA1aKIn
         l3jbmmy9mwKb2Fo6iuOPsgqsXCaVXMO8bIQesipPx5Ozt/YGLUatwMd4Q0UkMLNyAB4W
         iKEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=Z6SWZpdODlnO8czlhOLq31vh6FeRlmcNPXpjA4PbQwY=;
        b=DmmfkDCGtokj/WF9UkJU3wZcFPHKWyDCsxZvR/Hom5RzP8xu/kycPxvY8Lx1DBbp2c
         cw/CH8/cwOkPBz4ALi0o6KPGpguZ7r4pMm5rudlXVbBdkqCgPkiMlTXnfA1YNHbFypI6
         1gHNGl5IoWKyGXmhSOARvmUWgPe3HjZrCwCgpfh/6xGSlJSYMpOUdSdxa72EqKjPBhwS
         w+XeADCAeWBzmGGyMobCamhKlOhC8y0MS3nif1/VKwX2w9ay2YdRLyd1F+6zWUKR8PRb
         7ufXKdfemwDSWCFG46E/B4sd0xev8TvSzYbrt8GhNsboPcAf9SCfJLjd3l7UsVAa/oWp
         P+jw==
X-Gm-Message-State: AOAM530jPRohOsBiNssHoBCaxOFJfShEtc9LceGWQyQhr/EnVgWgMq+D
	1GBoPZPQ46P/rwtJcwHqkkZiPlJU/NJspyeL5f4=
X-Google-Smtp-Source: ABdhPJxUp4l2cNM0Mi7dUy3xmDkpNRan6YTxDifpf/+Te4i46JRveRYApd3LEOf54skGqfEQN2m0obNSESXEZr3N07k=
X-Received: by 2002:a2e:b8cd:: with SMTP id s13mr10687452ljp.201.1640692321679;
 Tue, 28 Dec 2021 03:52:01 -0800 (PST)
MIME-Version: 1.0
References: <20211228041423.2231598-1-gengdongjiu1@gmail.com> <CAJ=z9a2ww3OptqQn+KDdOMrRB_sSAicnVFQJ2UAySq5xZZjhTQ@mail.gmail.com>
In-Reply-To: <CAJ=z9a2ww3OptqQn+KDdOMrRB_sSAicnVFQJ2UAySq5xZZjhTQ@mail.gmail.com>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Tue, 28 Dec 2021 19:51:51 +0800
Message-ID: <CABSBigR6BWbVHd-AVMjv=wzTPKX_305m792pDjQ_dEK2CTwnHA@mail.gmail.com>
Subject: Re: [PATCH v3] xen/arm: Allow QEMU platform to be built with GICv2
To: Julien Grall <julien.grall.oss@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>, xen-devel <xen-devel@lists.xenproject.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Julien Grall <julien.grall.oss@gmail.com> =E4=BA=8E2021=E5=B9=B412=E6=9C=88=
28=E6=97=A5=E5=91=A8=E4=BA=8C 18:39=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi,
>
> On Tue, 28 Dec 2021 at 05:14, Dongjiu Geng <gengdongjiu1@gmail.com> wrote=
:
> >
> > Trying to select PLATFORM_QEMU with NEW_VGIC will result to Kconfig
> > complain about unmet dependencies:
> >
> > tools/kconfig/conf  --syncconfig Kconfig
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > WARNING: unmet direct dependencies detected for GICV3
> >    Depends on [n]: ARM_64 [=3Dy] && !NEW_VGIC [=3Dy]
> >    Selected by [y]:
> >    - QEMU [=3Dy] && <choice> && ARM_64 [=3Dy]
> >
> > It turns out that QEMU has been supporting GICv2 virtualization since
> > v3.1.0. So an easy way to solve the issue and allow more custom support
> > is to remove the dependencies on GICv3.
>
> You took my proposed commit message but the diff in
> this version doesn't match it.

Thanks for the point out, I will update it.

>
> >
> > Signed-off-by: Dongjiu Geng <gengdongjiu1@gmail.com>
> > ---
> > change since v1:
> > 1. Address Stefano's comments to add dependency
> >
> > change since v2:
> > 1. Address Julien's comments to update the commit messages.
> > 2. enable GICV3 in arch/arm/configs/tiny64_defconfig
> > ---
> >  xen/arch/arm/Kconfig                  | 5 +++--
> >  xen/arch/arm/configs/tiny64_defconfig | 2 +-
> >  xen/arch/arm/platforms/Kconfig        | 2 +-
> >  3 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> > index ecfa6822e4..373c698018 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
>
> Are the changes necessary in arch/arm/Kconfig to solve the issue on QEMU?
> If not, then they should be in a separate patch.
I will submit it in a separate patch.

> If yes, then they ought to be explained in the commit message.
>
> > @@ -35,7 +35,7 @@ config ACPI
> >
> >  config GICV3
> >         bool "GICv3 driver"
> > -       depends on ARM_64 && !NEW_VGIC
> > +       depends on ARM_64
> >         default y
> >         ---help---
> >
> > @@ -44,13 +44,14 @@ config GICV3
> >
> >  config HAS_ITS
> >          bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUP=
PORTED
> > -        depends on GICV3 && !NEW_VGIC
> > +        depends on GICV3
> >
> >  config HVM
> >          def_bool y
> >
> >  config NEW_VGIC
> >         bool "Use new VGIC implementation"
> > +       depends on !GICV3
> >         ---help---
> >
> >         This is an alternative implementation of the ARM GIC interrupt
> > diff --git a/xen/arch/arm/configs/tiny64_defconfig b/xen/arch/arm/confi=
gs/tiny64_defconfig
> > index cc6d93f2f8..165603f7e0 100644
> > --- a/xen/arch/arm/configs/tiny64_defconfig
> > +++ b/xen/arch/arm/configs/tiny64_defconfig
> > @@ -4,7 +4,7 @@ CONFIG_ARM=3Dy
> >  #
> >  # Architecture Features
> >  #
> > -# CONFIG_GICV3 is not set
> > +CONFIG_GICV3=3Dy
>
> The goal of tiny64_defconfig is to have nothing enabled by default.
> So we should not enable GICV3 here.
>
> >  # CONFIG_MEM_ACCESS is not set
> >  # CONFIG_SBSA_VUART_CONSOLE is not set
> >
> > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kc=
onfig
> > index c93a6b2756..925f6ef8da 100644
> > --- a/xen/arch/arm/platforms/Kconfig
> > +++ b/xen/arch/arm/platforms/Kconfig
> > @@ -15,7 +15,7 @@ config ALL_PLAT
> >  config QEMU
> >         bool "QEMU aarch virt machine support"
> >         depends on ARM_64
> > -       select GICV3
> > +       select GICv3 if !NEW_VGIC
>
> There was an open question in v2. In general, it is better to wait
> until the discussion is closed or you mention it after ---. This
> avoids being lost.

Ok,  but I think my modification does not affect to tiny64_defconfig.

>
> Cheers,
>
> --
> Julien Grall


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 12:30:53 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 12:30:53 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252237.433224 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2Bch-0004L5-Ef; Tue, 28 Dec 2021 12:30:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252237.433224; Tue, 28 Dec 2021 12:30:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2Bch-0004Ky-BU; Tue, 28 Dec 2021 12:30:35 +0000
Received: by outflank-mailman (input) for mailman id 252237;
 Tue, 28 Dec 2021 12:30:33 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8vDp=RN=gmail.com=julien.grall.oss@srs-se1.protection.inumbo.net>)
 id 1n2Bcf-0004Ks-F3
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 12:30:33 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f1312f9e-67d9-11ec-bb0b-79c175774b5d;
 Tue, 28 Dec 2021 13:30:32 +0100 (CET)
Received: by mail-wr1-x431.google.com with SMTP id q16so38097360wrg.7
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 04:30:29 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f1312f9e-67d9-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=E6MgPsTD0ZQ4tFjPuV9PYpjgE8Fs/AOENSo7Xqx1e+E=;
        b=aot/prwM5mlDVnUuE39ZXtTIWMGfmXPyC/fCFHBBVohU30Vm9tKSvDBO0v+bqlUHC7
         f718N5R9bGoICgECmlu4XkXMtD5U0NydwODfMVaGk9v3nw1b2G9g9RhTgn7AGS84iWEs
         G8vK6lAc+WF5E3ScMf1X9O+DqCwhSiWoYBb5hLonP5B6YxXMs2w7PrEhuL9eKKjaEa8M
         GAhgGxHRaGztIxJS3zQLaJvmwjG2AWkwjWPSEypb79vyaDcc/B7LUNQonXF+tIrCzCeH
         8RzX/AgF3jcBiWYK80Q4LNqIJxOrn/sU8mmoPp39P4q2bh2jGgoQHHtxwh8Bc/kcbvt2
         PqgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=E6MgPsTD0ZQ4tFjPuV9PYpjgE8Fs/AOENSo7Xqx1e+E=;
        b=rtY5aJB50BLJQaGDZi93qHW3djLxLRGLMDYSNjh7LgaKfvcdLeTiKXZt8JtzhY2Ou+
         UKXrbsVYjJIHBG/3JgoClbolE7t2eOuUI78zwKRA0JHw04Y+7wj9UOc8rJr+VAqMTyNM
         uR4eWAIdQuhKTtOcDYWO2cKMnJ7qz36Kl8kq/Gzqbqh/71Uh6WfofM7Oi1lLh/HFFnjO
         tLZt35W61Ww69j/xXVhqGbacavCkIPrxPpN4JedksUa1c77qrtAoz24PLfEBtgkjB5Mj
         CAVcpxu2Egi33e4zMSGPgBaRAYTve+0EKfA7tt82gH8O3CaCiEEeY+pivpQUF8V/n1b2
         R8DQ==
X-Gm-Message-State: AOAM531ZB2gMrP/CyKumGNNDzPe1SOkRl0jogCUlvquCZZZY8lTKYOXS
	WmfCq+b0FTzYXhFHuUhX6ottco9qZp+siV06h1M=
X-Google-Smtp-Source: ABdhPJzkdzVGxlWyn6EpHP03q/IYpbW383CpfT2hGUFQYOiqkcBfzUO4F79bBVAsJQWedr8TzVnuvfMiDpCMmtVSEKQ=
X-Received: by 2002:a05:6000:1869:: with SMTP id d9mr15988528wri.231.1640694629145;
 Tue, 28 Dec 2021 04:30:29 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org> <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
 <CAJ=z9a1o_-3A3=NKkbBT-s2EGM+WKJPiwxSt3q45PWs_9udcdw@mail.gmail.com> <CABSBigTyZ46OjvANi23e3sgL8+AKk73=3AOQnfvwhWcXhM-pgQ@mail.gmail.com>
In-Reply-To: <CABSBigTyZ46OjvANi23e3sgL8+AKk73=3AOQnfvwhWcXhM-pgQ@mail.gmail.com>
From: Julien Grall <julien.grall.oss@gmail.com>
Date: Tue, 28 Dec 2021 13:30:18 +0100
Message-ID: <CAJ=z9a0dNOBHh3Gw5Q+JeHMRYqRqTrtDzk4p2MWDq2CaTFW4Dw@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Dongjiu Geng <gengdongjiu1@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 28 Dec 2021 at 12:37, Dongjiu Geng <gengdongjiu1@gmail.com> wrote:
> > Please don't update tiny64_defconfig. The goal of tiny64_defconfig is t=
o
> > have a config with only the bare-minimum. If add CONFIG_GICV3=3Dy, then=
 it will
> > be enabled when it is not necessary.
>
> Ok=EF=BC=8Cwe can let the user configure the CONFIG_GICV3 in tiny64_defco=
nfig
> according his neccesary.
> So I think my modification does not affect the tiny64_defconfig.

But you modified tiny64_defconfig. Anything you add in it means it is
going to be enabled by default.

> what
> is your concern about it?

As I wrote before, the goal of tiny64_defconfig is to enable the strict
minimum. I don't consider GICv3 to be part of this.

Instead, we should let each user decide whether they want to include it
depending on the platform they are targeting.

Cheers,


From xen-devel-bounces@lists.xenproject.org Tue Dec 28 13:19:06 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 13:19:06 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252243.433234 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2CNO-0000BA-6b; Tue, 28 Dec 2021 13:18:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252243.433234; Tue, 28 Dec 2021 13:18:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2CNO-0000B3-3C; Tue, 28 Dec 2021 13:18:50 +0000
Received: by outflank-mailman (input) for mailman id 252243;
 Tue, 28 Dec 2021 13:18:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=twCP=RN=gmail.com=ayan.halder.arm@srs-se1.protection.inumbo.net>)
 id 1n2CNM-0000Av-B0
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 13:18:48 +0000
Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com
 [2a00:1450:4864:20::431])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id b0387da0-67e0-11ec-bb0b-79c175774b5d;
 Tue, 28 Dec 2021 14:18:47 +0100 (CET)
Received: by mail-wr1-x431.google.com with SMTP id w20so29351960wra.9
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 05:18:47 -0800 (PST)
Received: from [192.168.1.75] (40.230.9.51.dyn.plus.net. [51.9.230.40])
 by smtp.gmail.com with ESMTPSA id az15sm17394124wmb.47.2021.12.28.05.18.45
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Tue, 28 Dec 2021 05:18:45 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: b0387da0-67e0-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:subject:to:cc:message-id:date:user-agent:mime-version
         :content-transfer-encoding:content-language;
        bh=Xi5AJGQaDpl0p63FzDAP4rk1vajquACxcaZRSyZwl4c=;
        b=fASZXD1x0Lmh22w9PJ5lALlbmlUk6eAd6eMk6mMxoyI66fExRBMVmJ54o/qdTTMMQs
         +C4FT/GJlbC0BHIwYkDkaacFvXMHcBi8QnaKI7EpdqfhxRfflQEXYxec80zUsceLbT0Z
         ztx+Y8KyacxkoLclrnJZ/0bOJmPzAPDm3QZNQ8G20UCpI/FWzJwnmwynmROR4i3in8BP
         mxL22xxdEgqYVqqhbWadgVck5Otz5OMYMFW/xR3V6Iy74WTeBQQqBN9pgj+iJgXGQOGd
         Kb1T/qH6iP0DsWWOE2hqayGvKIXAZh9B3jHJrpEeb92wUGMtukeMFtSTMvd2SyNe/zh0
         Y77g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent
         :mime-version:content-transfer-encoding:content-language;
        bh=Xi5AJGQaDpl0p63FzDAP4rk1vajquACxcaZRSyZwl4c=;
        b=WC+z1YD2fDJjxuzyjvzeYGQMShpDi0C+T8UVTAqEVJDqfIK1TlY0oNuklZQZMYKLql
         8gT1GRdvtKjO1ySgBv1/BCAKaPe0LzW9p4sZnORhytu0ZxRgwOee95aPQOdZ3W1oSprj
         NCzxZrRi5MJwlygrVkpCCK4v5/5GfN6x0Sx9NpP5KMASCCmScV92Y/p2oIJbwj5JnzuG
         UKV9Zy1EA1K/N7jcV8oQmi65nRPvKBGyi8Oiiqq5iBDi7iJaXeEqIQ67+QeU3S5fb0ZS
         D+zJpNgvfscACR9Ptb0tR+FxgZQedAUoo4B9LJmma5d4ULbTseKy6003X6GIyDRU12Ow
         8+Qw==
X-Gm-Message-State: AOAM533Vn1CbocSc76pHnut1EZIi3zD+PWyn3jbCXTkcugM7mDqWb8xN
	UJsMysIYaSiL5AkzafEcDcKJ/nnVyl331TKr
X-Google-Smtp-Source: ABdhPJxgvjF0GMcyGpn8zikPRmysVjLKXR1lADcfVlTviHTf7pMVdY0MiXa4e0fKZYQGv+PXYBCicg==
X-Received: by 2002:adf:f8cb:: with SMTP id f11mr16184846wrq.700.1640697526238;
        Tue, 28 Dec 2021 05:18:46 -0800 (PST)
From: Ayan Kumar Halder <ayan.halder.arm@gmail.com>
Subject: Trying to boot xen on Raspberry-pi 3 B+
To: julien.grall.oss@gmail.com, bertrand.marquis@arm.com,
 Volodymyr_Babchuk@epam.com, sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org
Message-ID: <ed00e7a6-ed75-5101-0dd1-a5f156aeb68f@gmail.com>
Date: Tue, 28 Dec 2021 13:18:43 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US

Hi,

I am trying to boot xen on Raspberry-pi 3 B+ as my hobby project to 
learn about Xen.

I used the latest version of xen 
(f1e268b9fd13647e1f69c8ce0ae7be401d319fc8).  I tried using 
tiny64_defconfig and built xen-4.17-unstable. Also I enabled printk and 
set 0x7e215040 as the early printk physical base address (0x7e215040).

Then, I just tried to load xen and dtb (the same which has worked fine 
for linux). However, there is no prints after "Starting kernel ...".

1. Do you know if there is something I am missing ? I am expecting to 
see the Xen earlyprintk logs.

2. Is raspberry 3 B+ expected to work with Xen ? I was reading 
https://www.linux.com/featured/xen-on-raspberry-pi-4-adventures/ and is 
my understanding correct that only Pi 4 is supported ?

Kind regards,

Ayan



From xen-devel-bounces@lists.xenproject.org Tue Dec 28 13:22:41 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Tue, 28 Dec 2021 13:22:41 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252248.433246 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2CR1-0001bV-N5; Tue, 28 Dec 2021 13:22:35 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252248.433246; Tue, 28 Dec 2021 13:22:35 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2CR1-0001bO-JJ; Tue, 28 Dec 2021 13:22:35 +0000
Received: by outflank-mailman (input) for mailman id 252248;
 Tue, 28 Dec 2021 13:22:34 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=8Zee=RN=gmail.com=gengdongjiu1@srs-se1.protection.inumbo.net>)
 id 1n2CR0-0001bI-44
 for xen-devel@lists.xenproject.org; Tue, 28 Dec 2021 13:22:34 +0000
Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com
 [2a00:1450:4864:20::233])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 37169a7a-67e1-11ec-bb0b-79c175774b5d;
 Tue, 28 Dec 2021 14:22:33 +0100 (CET)
Received: by mail-lj1-x233.google.com with SMTP id h21so18743831ljh.3
 for <xen-devel@lists.xenproject.org>; Tue, 28 Dec 2021 05:22:33 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 37169a7a-67e1-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=Di9+eaGKU3zSk5aHK3Kr70qIdnImPAYERypyyGpIcmI=;
        b=RKNQtaPFTWQK0a8sy+17EdRNtdVWIyVkVTIGIMBJIVR1eOL7XPAkzv+pUcaHVcvq2X
         LnNphQbSdAa6FLnxugud4SOzKkwKIk2YCZ8BTPuBzSLxm3xFFjIuS85Hd2WIDugouMP8
         uKblXKGSR5TPE9skHo6WHCSW8qa0pOlu2o/JTYqMiuf25J9t4hYz9FkDR5e7Uqfl0iGo
         yvSvkx9ECk6FNe00OQMdgfN+iScC7hzOeet+k4K0wcjWUwRxUQdc4ZDfp/V6ar6HUVPc
         MwDrwgX67AajYhIg+YmxjpxcK0xkBrUA9rzfO8AZHMOyypX5WsnSPZzwQsQVWzxV8Jmp
         4upw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=Di9+eaGKU3zSk5aHK3Kr70qIdnImPAYERypyyGpIcmI=;
        b=4sYA7z/JT3rnxHP0nhIYLj+baef4pjkiZ+igo7cSs1qcB0Swfgym8mzl38hf6EeT9m
         kLuNC0m6st/8b5EHoR8UxUICxprfqVwdSpAumXkQuTM/BEx/JUUBU9d4GHQAWmrq0fcD
         2mZ4K4lZkABahClGr8wY/kmrAyDq682H+/jzVPmfrIgqBy60ruByxrgAKZbaRFgm1+8X
         7GJ2aMWWBRloMiRfL6yKUzXgS7HcYMOgaiEa1lgmszUcD6UxpdRAi4+OLOaRqtbE7nof
         3gnxXCgxCVKd5Ff19272E8nGLHDPDzEldJpzGw+kqN3H0GpHlWLLP0Qey8sUztZirqwH
         Kn9g==
X-Gm-Message-State: AOAM530KLi+lO1t06gCxm43cds6+TXt/iMX6z4FePJRQLp7+7aVx968a
	Y4ziD84nL5br5fJfqYtfRyH2OEMVX3vrtU5pDJI=
X-Google-Smtp-Source: ABdhPJzz1YOx8wA3UmEW07hcR4smpHX4dVGvNf/MplcdYaX4yEGxljBKbmZ/sGCQnA1y/ilQW64qzYTZIVJcb2NtcUg=
X-Received: by 2002:a05:651c:b27:: with SMTP id b39mr13031347ljr.26.1640697752832;
 Tue, 28 Dec 2021 05:22:32 -0800 (PST)
MIME-Version: 1.0
References: <20211224122451.1210382-1-gengdongjiu1@gmail.com>
 <22172c85-b024-a28a-e351-82038cf0efa1@xen.org> <CABSBigQjy2jvW6czAXHMvVc9DmHRED5HWz-5At6FN9gPLnzsng@mail.gmail.com>
 <9a1edb02-ad32-4229-6baf-dbe69d7e718b@xen.org> <CABSBigTZ--z_ZCGd6-VQEvfyu+166WA2C_Ns7qFiWPay9A=hUA@mail.gmail.com>
 <CAJ=z9a1o_-3A3=NKkbBT-s2EGM+WKJPiwxSt3q45PWs_9udcdw@mail.gmail.com>
 <CABSBigTyZ46OjvANi23e3sgL8+AKk73=3AOQnfvwhWcXhM-pgQ@mail.gmail.com> <CAJ=z9a0dNOBHh3Gw5Q+JeHMRYqRqTrtDzk4p2MWDq2CaTFW4Dw@mail.gmail.com>
In-Reply-To: <CAJ=z9a0dNOBHh3Gw5Q+JeHMRYqRqTrtDzk4p2MWDq2CaTFW4Dw@mail.gmail.com>
From: Dongjiu Geng <gengdongjiu1@gmail.com>
Date: Tue, 28 Dec 2021 21:22:22 +0800
Message-ID: <CABSBigQK+jAJOBvXH4FSLz=WNS+8m_BS_xHOsxOQBZ7NXn-62w@mail.gmail.com>
Subject: Re: [PATCH v2] xen/arm: fix the build error for GIC on ARM64 QEMU Platform
To: Julien Grall <julien.grall.oss@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, 
	Stefano Stabellini <sstabellini@kernel.org>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, 
	Bertrand Marquis <bertrand.marquis@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Julien Grall <julien.grall.oss@gmail.com> =E4=BA=8E2021=E5=B9=B412=E6=9C=88=
28=E6=97=A5=E5=91=A8=E4=BA=8C 20:30=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi,
>
> On Tue, 28 Dec 2021 at 12:37, Dongjiu Geng <gengdongjiu1@gmail.com> wrote=
:
> > > Please don't update tiny64_defconfig. The goal of tiny64_defconfig is=
 to
> > > have a config with only the bare-minimum. If add CONFIG_GICV3=3Dy, th=
en it will
> > > be enabled when it is not necessary.
> >
> > Ok=EF=BC=8Cwe can let the user configure the CONFIG_GICV3 in tiny64_def=
config
> > according his neccesary.
> > So I think my modification does not affect the tiny64_defconfig.
>
> But you modified tiny64_defconfig. Anything you add in it means it is
> going to be enabled by default.
>
> > what
> > is your concern about it?
>
> As I wrote before, the goal of tiny64_defconfig is to enable the strict
> minimum. I don't consider GICv3 to be part of this.
>
> Instead, we should let each user decide whether they want to include it
> depending on the platform they are targeting.

Ok, thanks. I think we should not consider tiny64_defconfig,  because
the user can decide whether to use GICV3 or NEW_GIC.

>
> Cheers,


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 00:54:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 00:54:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252271.433257 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2NE8-00069A-4K; Wed, 29 Dec 2021 00:54:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252271.433257; Wed, 29 Dec 2021 00:54:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2NE8-000693-14; Wed, 29 Dec 2021 00:54:00 +0000
Received: by outflank-mailman (input) for mailman id 252271;
 Wed, 29 Dec 2021 00:53:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wrt3=RO=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1n2NE6-00068s-Ex
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 00:53:58 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20700.outbound.protection.outlook.com
 [2a01:111:f403:700c::700])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id c928e284-6841-11ec-9e60-abaf8a552007;
 Wed, 29 Dec 2021 01:53:54 +0100 (CET)
Received: from TYBPR01MB5341.jpnprd01.prod.outlook.com
 (2603:1096:404:8028::13) by TYAPR01MB5054.jpnprd01.prod.outlook.com
 (2603:1096:404:12c::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 29 Dec
 2021 00:53:47 +0000
Received: from TYBPR01MB5341.jpnprd01.prod.outlook.com
 ([fe80::f167:7435:432c:ebdc]) by TYBPR01MB5341.jpnprd01.prod.outlook.com
 ([fe80::f167:7435:432c:ebdc%5]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021
 00:53:47 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: c928e284-6841-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HjUcBrgqNZxFAXn2A1eS5org1APEztmZmxPYxxXDkUsB5Ibx+syVVRjSz2ILAqru+gS33TvVaKW/nTa1KIvNqxiVVjuZ8ofNALVYRchv2vQNxWavVFdFqfVhgMdvQzm/joZFKcNhzeJxVPJoVui8LxJoeRNyMRQP4MPoVsmGL3DXQn6NwuwLAWvdJ41bZOBzHypNuI9c6F+qrjXyiTmxBKzMJDPo/6s+QmCDNpj1Fcw2RxtC8hxC2em55Ix6UXtXWh0TryKFOJQSH2H3hexC5/sDZEzULjBbwEI4Uj4GDVfNiW7ss4bNA2BQdIrQ6y9wRNOtENGxXnPiJ53ChMGbcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=U5BQyVqZN7sskrEGvzrguzybhnnr/gy2/aW5PDNK1lg=;
 b=n4bCht83b78i1iwJ8JM/SVnj8DsDkAfobFSB6O1cYkxvYf0/HCye2VZ/mLALomb0B43REi9laHMSH8/GbLSoxmWchn7r/T6hGDaBlveDReBECpgaEd8mqiCbzgLxn+7z60qKmC/MQCan8sMiXwLFFW1ZVognurlcjAZPWh65nfZbaeq7dJBIItQS5nluydhDJJLUvM6ruz3QaBmgXNYOVf6Z7NJ/ZCnOvt9gAhvObiAYbKS/Y6kjUa1j9v6iD/7TS6FKmesDYdYRjJDKQ3KxFoBJNw/VWVT0bb3N1G99UXnrlWmE+ZTICP2nYKiBGsYfEGulnwuw3O/pez9QOD1gMw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=U5BQyVqZN7sskrEGvzrguzybhnnr/gy2/aW5PDNK1lg=;
 b=MTHXYL1OMJ/lAn8wd8DSdC06ZzHMchVdYwS757TvzdMEq6B++HqSQzT1mhRF2lFRI1ghLzWJJijSDtQvTpN2guECRwjFSVkIz7isy0/ASU4d0ut8ZlOBUGVAfjjBCnwK0p8r1w7Wylj16DSniMshfXZw862hWF5lCdYAhkJ8fVI=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Jan Beulich
	<jbeulich@suse.com>, Paul Durrant <paul@xen.org>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: RE: [PATCH V2 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car
 S4) support
Thread-Topic: [PATCH V2 07/10] iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car
 S4) support
Thread-Index: AQHX9ebXat4RyGuQs0+nEBbexUv6B6xIrxzg
Date: Wed, 29 Dec 2021 00:53:47 +0000
Message-ID:
 <TYBPR01MB53417B6CD4E3B6A575891A5FD8449@TYBPR01MB5341.jpnprd01.prod.outlook.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
 <1640034957-19764-8-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1640034957-19764-8-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3f613c14-43f1-4ef3-bcad-08d9ca65abc2
x-ms-traffictypediagnostic: TYAPR01MB5054:EE_
x-microsoft-antispam-prvs:
 <TYAPR01MB5054E0FB356188B54DBD123CD8449@TYAPR01MB5054.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1122;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 Jf+PAlvizeF+1+Funj27suNTW9ARTsWxPM8X45W+NquEzXayTItedaYn/383poGIXNgVxkwU1169pJ8bwwzw6Ny5C+yMi5x2fO7YY0J0h6nBNiz5XWB7+pT3Cku8OFmz8kXzVCydy/3+q4B4SdlPw9FNFaupqayxsElvnBxWGruH+bNKiX58xPYWXeeA/qmn98f1BkvX1e9Oz7uKq7gACH1Aaba+SFdlYv1ngh+z2KfzRXe/bxTJmTN6q07ovZ4y+FnEMe1FHK4OrqVQDHXcQF5nWBwMt/4hTa21VGrUmIgQ00+HWMuzRThQJF6eM/rhPKm0ylvQ7flFmf1oEVMmrR2oIpvsI3BBqB3aiPu7xLuvtkAIcKZxnXM6uOWD6esHkSxO85cQsTfZvHA5MEOnk+zCz1Ovz6gCF4LcpcWt2orZAQVr3BfqsIMaiHc+odfVS/fpXoH1afUxrSmtyvFLyWsYetnPmy9mbSM0meTYozLVUt5miodJPaHF/o+jX+AydyS0b2BHHj4E8kjOurn2butKhHJkgH7kpFpYP0GcSfIOu673aQZ33nRKNpI+owE0m1fd23TQE/EFmFfHATGo7F6IA5YHNDG66Tm/1XRDPajYEM9SlhCAcljad7Fkhv/wOqMtiEgWb2zThAGbBhBZLXpeG+CFEkvKKDVcsvJwi2vUv6zHuPchzGFZ92aZkiYAYXuiRLmT3bAsCkf7RoASnIdSB+kSNck8K/1EHZmqrF5rIrj77vUD5HKWgTCK4ylua9Fws8Wqn9MgKY9uMtQUBWZVWDVLMVs3vlSAWis17/0=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYBPR01MB5341.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(110136005)(9686003)(966005)(508600001)(2906002)(55016003)(33656002)(5660300002)(8936002)(52536014)(7696005)(38070700005)(8676002)(186003)(54906003)(86362001)(66556008)(6506007)(4326008)(316002)(7416002)(45080400002)(122000001)(83380400001)(64756008)(76116006)(71200400001)(66476007)(66446008)(66946007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?nCyLPxeURCllxdFYygfzkOZV+NB1z+jihmYkxzmhrhCS1Ws7YdmEceg0hHdr?=
 =?us-ascii?Q?N9lNEgRsmVjkBZ+VaufG3qQMDe/mZ09XZP4BqwFf7C6o9y1GIGmzM+jA0PEL?=
 =?us-ascii?Q?6sWsWS2SPTXA2r2q1AeeuOKXfPgjJgnN2y4fV40/4Y+cAGYoaOYErINXvBCJ?=
 =?us-ascii?Q?UdKj/o1BvACATELYAavWF20ofD1n8Vc9DT7TctWEMXvWlnDIjqZBfx8EEcyX?=
 =?us-ascii?Q?2Nysx+42sl7cZNRvrQmr4XlnETsgWGEM25Q9mqs3yqe08hq81WzSL5g65bxA?=
 =?us-ascii?Q?E71ffjRkq1VmmIXz8ZuQ/RWd+EarsZy87O8ChfEnH6sY1q5wB/jDeRIWfYeo?=
 =?us-ascii?Q?Sbg8B12IJADWHjsEqvGMB9c2S1CIbR+pav5y93c0y2NWMavUx2mbp+1VdZ52?=
 =?us-ascii?Q?DXdk7IuHLftHlizZ6WAB7X0eG0xqO12EFc8+Dxkt6yYeKQK+m0SwAS2E39j9?=
 =?us-ascii?Q?yEjXHypWrGttqeV8t0OGBt+r0uZ+WzpwRb4UQ2g2Nv2rmjlgia08mdDZke6h?=
 =?us-ascii?Q?jnm/X0+PQ7SjKHIagldSbFfUxsn19oMoTJs0mYQhEeyoJjXqdiudto6EXivV?=
 =?us-ascii?Q?a6iVI3hpE5TNp3v+SlcHPbsuV7C7RqZ//9UNN8N7bOeAUOUKNH8f2/OIluP6?=
 =?us-ascii?Q?a3SLYZeTdsaZclMJ3qHz3+lini/YGKNMOOJQIakEOwbtqBEsVx75lZhkw45Q?=
 =?us-ascii?Q?Evm7xNRAgMqJ4HuFdFAYUfkT6VzGczNpx5ATPZjV2ZHL7PYKR/wD56UGXgPm?=
 =?us-ascii?Q?XvFCGf7UsBnNFaBQpibyc74M3JYazGj99ZTZBaqWVX4Ruh9VN/Yy6oUgg1aN?=
 =?us-ascii?Q?R880l8m8YFcyGiC3j4PkAbM8mrc2gtJ1vlNxwdkKGu1/KnrBo2nS2PnPRAOn?=
 =?us-ascii?Q?Kf8SxHTFeYp1dC/zD3/b+DVhDECAGqZRpFsEJQCUsRDaBADskjhnnlJAo6Ga?=
 =?us-ascii?Q?HaDNEDUisN8TqGV1lfDOzFjnoCR5ULeGCocOh2cqkGs7PaiZhbupG0LZl5L/?=
 =?us-ascii?Q?yUTNLtL2kOu8MvarpzwAk2mekub1egKOKVK5hKJ6NsvweQKGh2/GeFei+P0G?=
 =?us-ascii?Q?2lX3L7lrP7byu7ab6lthD1hvtgJtTDf6LEasn2Ih0TBf4OwRH6lsAOiSGRFM?=
 =?us-ascii?Q?xIQEcp+Ba8APFTidVFPZSV5JeA43YW4oJWkj6VmRtwWiJNLs8ooIXjCwTwNK?=
 =?us-ascii?Q?qjeWWIk5JBj+UuUopLvXq4VsWifov1L1I7E8CKAQ2zeMLacd1mzf9aYAgkHZ?=
 =?us-ascii?Q?9eLEXUmhFZ6osVuDY9ZOtNLpzBq4io1V5+9QBIT+lUwRDyHUsSDMsY3ghgsc?=
 =?us-ascii?Q?k3c5JlO3NmTDrBeH8XieQLAaflY7pDBtt9KFHdxvLOVYSiwAweZovKaCcO41?=
 =?us-ascii?Q?NxISiZU9C5gqp0qlxRsLN1lExi3edaTxqMvZAuyHB18Ib29asAZ0BvNAlIlU?=
 =?us-ascii?Q?/NscFgr25wx6V5Ll0AYhPXGQLa9QJEWo4Fi0jCjTw+sf2PlcLtgfFoXPDwAj?=
 =?us-ascii?Q?Hrc1kvE1g3xGybwvndNrVrmwo4iNCvoyb+hMNnTnUW3Knq73coNQhuxulOGf?=
 =?us-ascii?Q?ccg9x6E/J8npXc+lXbI44zpQPIgEsSKw3GBiwfod1DXBOSbM3eWVKSVLWxkE?=
 =?us-ascii?Q?djfSCbE0Et7j12AVPDxWg1HiE4pvDsl4c4xv7fGagVdjr70UBs/So7ZhLLt/?=
 =?us-ascii?Q?+i91/lEMC94E5JltVMd2o76oXh2KLjxrzYgzfNwZW6+dkUG0/bUQw2XEvDx0?=
 =?us-ascii?Q?ZQVYDvFzV3/A+49XtDfy6fpZdbPqFmIaSOoIckzaVwbKzmEb5Can?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYBPR01MB5341.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f613c14-43f1-4ef3-bcad-08d9ca65abc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 00:53:47.0983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E3SnZl9Ak/T/Q8oGTbjiGfmCepEpsBQ063xurf028HpWEsDZRlCu3LFduQ5dpcIq294YDb0SvYH0hNtSUnkUSa66YXerYMWqJs0RD1kEXRgqMcj6FsTlFRfLScPlF0xP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5054

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Tuesday, December 21, 2021 6:16 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Based on the following Linux upsteam commit:
> 7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
>=20
> Original commit message:
>  commit 7a62ced8ebd0e1b692c9dc4781a8d4ddb0f74792
>  Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>  Date:   Tue Sep 7 17:30:20 2021 +0900
>=20
>   iommu/ipmmu-vmsa: Add support for r8a779a0
>=20
>   Add support for r8a779a0 (R-Car V3U). The IPMMU hardware design
>   of this SoC differs than others. So, add a new ipmmu_features for it.
>=20
>   Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>   Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>   Link:
> https://jpn01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flore.=
kernel.org%2Fr%2F20210907083020.907648-3-yosh
> ihiro.shimoda.uh%40renesas.com&amp;data=3D04%7C01%7Cyoshihiro.shimoda.uh%=
40renesas.com%7C995a1c66b6d841ccc79a08d9c3fdf
> 90a%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637756317833053012%7CUnk=
nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=3DTirhJToNqy3=
3Fzt0tSpukl9YFOj4iHgd3M1lX8W%2Bxlo%3D&amp;res
> erved=3D0
>   Signed-off-by: Joerg Roedel <jroedel@suse.de>
>=20
> **********
>=20
> The R-Car S4 is an automotive System-on-Chip (SoC) for Car
> Server/Communication Gateway and is one of the first products
> in Renesas' 4th-generation R-Car Family.
>=20
> The integrated IOMMU HW is also VMSA-compatible and supports
> stage 2 translation table format, therefore can be used with
> current driver with slight modifications (thanks to the prereq
> work).
>=20
> In the context of Xen driver the main differences between Gen3
> and Gen4 are the following:
> - HW capacity was enlarged to support up to 16 IPMMU contexts
>   (sets of page table) and up to 64 micro-TLBs per IPMMU device
> - the memory mapped registers have different bases and offsets
>=20
> Please note that Linux upstream doesn't support R-Car S4 SoC
> yet unlike Renesas BSP [1], but it was decided to reuse upstream
> patch for R-Car V3U anyway as the IPMMU HW settings are similar.
>=20
> [1]
> 7003b9f732cf iommu/ipmmu-vmsa: Add Renesas R8A779F0 (R-Car S4) support
<snip>
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 00:54:15 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 00:54:15 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252272.433263 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2NE8-0006Cf-GF; Wed, 29 Dec 2021 00:54:00 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252272.433263; Wed, 29 Dec 2021 00:54:00 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2NE8-0006Bt-9L; Wed, 29 Dec 2021 00:54:00 +0000
Received: by outflank-mailman (input) for mailman id 252272;
 Wed, 29 Dec 2021 00:53:59 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=wrt3=RO=renesas.com=yoshihiro.shimoda.uh@srs-se1.protection.inumbo.net>)
 id 1n2NE7-00068s-Dh
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 00:53:59 +0000
Received: from JPN01-OS0-obe.outbound.protection.outlook.com
 (mail-os0jpn01on20700.outbound.protection.outlook.com
 [2a01:111:f403:700c::700])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id cdd1e6bb-6841-11ec-9e60-abaf8a552007;
 Wed, 29 Dec 2021 01:53:58 +0100 (CET)
Received: from TYBPR01MB5341.jpnprd01.prod.outlook.com
 (2603:1096:404:8028::13) by TYAPR01MB5054.jpnprd01.prod.outlook.com
 (2603:1096:404:12c::23) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 29 Dec
 2021 00:53:49 +0000
Received: from TYBPR01MB5341.jpnprd01.prod.outlook.com
 ([fe80::f167:7435:432c:ebdc]) by TYBPR01MB5341.jpnprd01.prod.outlook.com
 ([fe80::f167:7435:432c:ebdc%5]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021
 00:53:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: cdd1e6bb-6841-11ec-9e60-abaf8a552007
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=PdruakidrOctkT2exasEObhPQs511WJuqs526dGnm9SqqBlXreVJY0Ay4Q94BYAUbwpwmuS0Qhw9utnqm04AegIH16uXBfBxkUPQxzAoClp0NaThNBU3rNd84N3i0q1cfNZ803HnKkyBSj3nZNBVC9nq1N0MfxvzX3ylunCAU4asxzpWJ92H4RFFe1MW78RBR5kiIrJ6AC5IlYLwFcenYEM8iYr4KNAIAWVeT9JuM7Zz0tz2ljUvP9VG81VPQMgPOI7XT9KHnXpV0NTFgMwGPXsXHWJONRHnv81HOZiPry3LByVIeQ8JLIcwozDZtikWmDpo3VmS4HwbLUlvEdArOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=XrfrB+mDR3uFUa6BePj1CUc7Wk6nDrhXphJwlhBTGRY=;
 b=PhmKq1EehsrNUBghs7IPqkl3wCciQIvRxldiamoz7eCwh9AtGfA1qankNa3CCrn8tnYuES0nda81pGyfpQqNaNBLK3wRHUnvyRqM9apqoC1QZSfeNN4g6FTrhK5aB7hNHyf4h4L8KFYUWt/ldxLnbdTpBK7Q0jrbEy2l0wBcaDNXxo3SGQDxc9tGPTgSkRaU72nzuPlwuOjbZTXslrnY6CwIEUkSD5Bx8E/2KzlW72k/MaT3ApBcEfr9ATwdYDd6EsRIkyOxV+Q9luT7wLJYyqeOEgF1EOspEU9XBMtkLlsRWvw5PeeC8+XFT3uwctG7BIAh5XK8RCuS4doZiEGWpw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com;
 dkim=pass header.d=renesas.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=XrfrB+mDR3uFUa6BePj1CUc7Wk6nDrhXphJwlhBTGRY=;
 b=G7izcctGQHtvLp3Q+XUJutHumPOlkKIDQq8Ll3isKOaJ4+t/fDLna2SioyfhgclcKkWlkkizFhrNmV8UOGlHvjItHB1XX827g6EN371hmvHr958hq5+qgj1tTsPazPWGwGePOSXjzVR8qDvR5yRNZ0sEyiAz52UmZ90F7c5xZgE=
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Oleksandr Tyshchenko <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
CC: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, Stefano Stabellini
	<sstabellini@kernel.org>, Julien Grall <julien@xen.org>, Volodymyr Babchuk
	<Volodymyr_Babchuk@epam.com>, Bertrand Marquis <bertrand.marquis@arm.com>,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: RE: [PATCH V2 08/10] iommu/ipmmu-vmsa: Set IPMMU bit
 IMSCTLR_USE_SECGRP to 0
Thread-Topic: [PATCH V2 08/10] iommu/ipmmu-vmsa: Set IPMMU bit
 IMSCTLR_USE_SECGRP to 0
Thread-Index: AQHX9ebXgjGZd0iLi0ieVXpWLYB8sqxIsLUg
Date: Wed, 29 Dec 2021 00:53:49 +0000
Message-ID:
 <TYBPR01MB53418CEF0A1ABE1D7EC09F21D8449@TYBPR01MB5341.jpnprd01.prod.outlook.com>
References: <1640034957-19764-1-git-send-email-olekstysh@gmail.com>
 <1640034957-19764-9-git-send-email-olekstysh@gmail.com>
In-Reply-To: <1640034957-19764-9-git-send-email-olekstysh@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=renesas.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 90df181b-6ba8-4db2-f493-08d9ca65ad2f
x-ms-traffictypediagnostic: TYAPR01MB5054:EE_
x-microsoft-antispam-prvs:
 <TYAPR01MB505450A09D3DE0A359CA52C5D8449@TYAPR01MB5054.jpnprd01.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 ek00mJLukQ35nR5D1uFenaa+0i9TPpx4HekAklrcNtskdpDn6sZNP1SYgdTcGqqTJkbA9ohUl1vEeFuPKcSNEMWiD/QCXBQf37YXzzhDJ+oDQeJB8Okac6HYGBGOqM5b1uqeXNzWch5Z9oYX+RRJuorIaRRvI3aY+fIq6XubwFmccHDgN4DvGOxDedCo3bDiOk8CVMRB1eZprqqHJSJ0sH/hY0YNmTL/G5GpJDtBStIHcChT+Vl9Ls79/7DymksvZ3V/CclYbqiWugTJqfAsaii1Xi0DLEzSwDqJozqQnX5IKRvuNu0eTF6VDLD+PR0LspPZl8A33dwpMs+GtBO8MD4daZRPbXQJFQvNL5q1heEl3n/icHiK/wT/SxxZLVTRTTVoeeTv5rk7zqVkJYgt91sWfIxcgOcYMw+KcnGB0pRQob5T2L3YBoLPGKZG/WPLPzD64Dq/1XGamQAG7U24I0dpAUrVPcUdG0gx6N1hVxUXnKgtmMHsxZF/QA34LZwXF3FKPJjqPCozaYVzxz3B4ZGEyTSfOHMoMbXADNPdWTC8VO3KU6kKuXW9AvewvOzSMl93FVWqJr7hnTfL8LHxGx6MBCDxEnDGZFmQ7EefuFalEglKekX7htGua/2awJZG+exzJF9xGN2QdQqBK2A965jwDv39CPd56GN4qL1RiFE1s5d9lWBH3ioM8PBlB2Ua6/jzS0hWxo+kn25SH5IQEg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYBPR01MB5341.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38100700002)(110136005)(9686003)(508600001)(2906002)(55016003)(33656002)(5660300002)(8936002)(52536014)(7696005)(38070700005)(8676002)(186003)(54906003)(86362001)(66556008)(6506007)(4326008)(316002)(122000001)(83380400001)(64756008)(76116006)(71200400001)(66476007)(66446008)(66946007);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?BMqBggItQ9WAihhFKjuQ0KGADFXh8baL8V77VCjzl93hr7jNmOJmE9tjcVQG?=
 =?us-ascii?Q?Cu3sDZueeAmkY8GLXLP2KBNAwA1MSL8ktddr5v1i3NuDKXm1BRuOu8GH0a2u?=
 =?us-ascii?Q?ZJXAFW4dO0BfLUHsttKNKRU74a0Y6ezcWmug4WN4nySSqJCGt+rYsfGAKnTI?=
 =?us-ascii?Q?ZXUpa+KJS7dPRAw056G77In/BIdy6cG4SegX+J9bzGtyxvA46Ad2bgUypKfn?=
 =?us-ascii?Q?gaK7RQknTuvjlL7lIawbbi0vDf8jP5+NzxptoFP/tNiskHuTI+dpHiG+HJvm?=
 =?us-ascii?Q?vXeQIhMtxZheXlV2QTLRrCzJ3P/L2iDugEY/tVSvwgoTA0nfioo7mzUK2viG?=
 =?us-ascii?Q?eoJobanUhVXpHOLaO8xQZd+TOgXA0HR4M3bBhTP/WTyh9HyJmZtAm9humIVT?=
 =?us-ascii?Q?VRUHLxQ2BU0ILMsdlxH5cZJJ16GvEEBtxIgggkYFu2XJ8NbkT3xht5PLYOW0?=
 =?us-ascii?Q?+hUM6di7brHc5j1sUcUU8IIOby+NOG4hRZrDR2zPkTNJ7lRdu8O2hSuBwSas?=
 =?us-ascii?Q?FSeVbinHO0WBFrmF9hUDDVftFOFVOwqoUhP1wakf91yuno5nPigdQHFO7m+4?=
 =?us-ascii?Q?KEcvgZkXwrPgnKMeBnZJnoyW+4FbGzc2d01mjkTavnCePV6WnrAvWRdqypig?=
 =?us-ascii?Q?kwTPRAfaj+d79AkQjh7BszEJvntTo3U5y06oyRC/zeuD1rBYjYbbiFuRGi2f?=
 =?us-ascii?Q?RGGSbc6DoPv76ruV2bMTX98/LtV4+Vz74/+Hx7Mo4zUPZYxdwr8I0EgS7v/l?=
 =?us-ascii?Q?Lh5TDgH1oztEmc3HruJioQd6iesIhM0KqCviN5412SN8USAOHWnohU/QfQ5U?=
 =?us-ascii?Q?7g5k0K+Zu4Q9SKFtbBi+lg9arOoWXdhwPA9PEIGOV+J2/F7lQ2o+trW4Y2BI?=
 =?us-ascii?Q?BrVLAngfsEG4YmdIMQ89bwr+gYQ9fpgTI66JDevMSim3K2T8yCkSRxeb8a5l?=
 =?us-ascii?Q?ROVLubinx6sJzOwNHLsJF99Mzb78bAvne3G4rGkzVUBFe6pXAdjYVkMqcr5a?=
 =?us-ascii?Q?555A4h61iZ55BJy47xaV6OM+rGtJAOIcJMgGXZxEU641JbswCDRaOX1DQEvG?=
 =?us-ascii?Q?M5aA+ZHs6YzWGwACDbUYKroB3tp6mVj0AyfSbOJuHp2AKrgggJ0K6cbtgfrX?=
 =?us-ascii?Q?+Vf26/zPbcUhtnr/Fi/tNntOOcbP7VvXiskprLoq/tFIRnAlp55pL7VyGnKT?=
 =?us-ascii?Q?ZTZ8csM7/lAO0JYV8taX1LlyU55os63twnSYRFAskgyP2If485bjfwj1mWpq?=
 =?us-ascii?Q?Z/bxUhcwzkfWGiuH1I5CQ3cBZG2kD4s9YLUq2ONOiO7WgK4zR5rS2akevqFJ?=
 =?us-ascii?Q?2wGK+nwzJJQnQLfR5KmvKWHSayEgdacbv257N7dpa61+bW3CRQWGTQuuoXAz?=
 =?us-ascii?Q?Pq+4+6cZc8ckQ1xkQ+RDe2vYl/dKfUCCSeSi3UrMvzrMeAld7GhZMgd9shhI?=
 =?us-ascii?Q?zwWeS2q6iy996XVCP71lq0cohHQodK/fzZ6VGs95gMbsuUdFKmiY0R1i+FW5?=
 =?us-ascii?Q?PXfJdfWzZWuVTAkgzZdJLKXd0qVnwWzH0d42xqhx6YDWDB0W7CI21DPv3U2y?=
 =?us-ascii?Q?6Q6EiOu1/5A6OnGhBnL0Zk+yqgX6cSEhqLYbOzMzOG/+DdTBsG0B2EjyAdLq?=
 =?us-ascii?Q?zoFOBxOb2qlq9/sIBV3Ceo0zkUQDbHi5ioWRtPTn1KbT9OFjnYboyr3O93Fj?=
 =?us-ascii?Q?n79xgOpEV5aayaaMlwFcZkT0YBkdu+u9830Ax2KpVfeSL51jRWjzx1RFcS7i?=
 =?us-ascii?Q?sFVhXAF/G3736zHF3DRWaQBYA9jUBSN79BLQL7X7YCcPCrP5M+Qp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYBPR01MB5341.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90df181b-6ba8-4db2-f493-08d9ca65ad2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 00:53:49.4360
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5YZT5EvVFfRqXvx1fSHSMCt16YXobWuSLzLiMWyp+t3ztKZ1wJsvZdRtuuxknIMkDDCfhWHvrszVl2A/9feMVgV9ajQUxra2+zmsT71yIWkuGoQmn5IQlpk8cOo9sINk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5054

Hello Oleksandr-san,

> From: Oleksandr Tyshchenko, Sent: Tuesday, December 21, 2021 6:16 AM
>=20
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>=20
> Based on the following commits from the Renesas BSP:
> 8fba83d97cca709a05139c38e29408e81ed4cf62
> a8d93bc07da89a7fcf4d85f34d119a030310efa5
> located at:
<snip>
>=20
> Original commit messages:
>  commit 8fba83d97cca709a05139c38e29408e81ed4cf62
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Wed Apr 28 18:54:44 2021 +0700
>=20
>   iommu/ipmmu-vmsa: Set IPMMU bit IMSCTLR_USE_SECGRP to 0
>=20
>   Need to set bit IMSCTLR_USE_SECGRP to 0
>   because H/W initial value is unknown, without this
>   dma-transfer cannot be done due to address translation doesn't work.
>=20
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>=20
>  commit a8d93bc07da89a7fcf4d85f34d119a030310efa5
>  Author: Nam Nguyen <nam.nguyen.yh@renesas.com>
>  Date:   Tue Sep 7 14:46:12 2021 +0700
>=20
>   iommu/ipmmu-vmsa: Update IMSCTLR register offset address for R-Car S4
>=20
>   Update IMSCTLR register offset address to align with R-Car S4 H/W UM.
>=20
>   Signed-off-by: Nam Nguyen <nam.nguyen.yh@renesas.com>
>=20
> **********
>=20
> It is still a question whether this really needs to be done in Xen,
> rather in firmware, but better to be on the safe side. After all,
> if firmware already takes care of clearing this bit, nothing bad
> will happen.
>=20
> Please note the following:
> 1. I decided to squash both commits since the first commit adds clearing
> code and only the second one makes it functional on S4. Moreover, this is
> not a direct port. So it would be better to introduce complete solution
> by a single patch.
> 2. Although patch indeed does what it claims in the subject,
> the implementation is different in comparison with original changes.
> On Linux the clearing is done at runtime in ipmmu_domain_setup_context().
> On Xen the clearing is done at boot time in ipmmu_probe().
> The IMSCTLR is not a MMU "context" register at all, so I think there is
> no point in performing the clearing each time we initialize the context,
> instead perform the clearing at once during initialization. Also do not
> abuse ctx_offset_stride_adj field for the register's offset calculation,
> instead use recently added control_offset_base field.
>=20
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 02:29:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 02:29:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252283.433279 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2Oi8-0000oT-P3; Wed, 29 Dec 2021 02:29:04 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252283.433279; Wed, 29 Dec 2021 02:29:04 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2Oi8-0000oE-Hv; Wed, 29 Dec 2021 02:29:04 +0000
Received: by outflank-mailman (input) for mailman id 252283;
 Wed, 29 Dec 2021 02:29:03 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h/ph=RO=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1n2Oi7-0000o8-CN
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 02:29:03 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20623.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::623])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 13bb6f98-684f-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 03:28:59 +0100 (CET)
Received: from DB7PR05CA0065.eurprd05.prod.outlook.com (2603:10a6:10:2e::42)
 by AS8PR08MB5928.eurprd08.prod.outlook.com (2603:10a6:20b:29b::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Wed, 29 Dec
 2021 02:28:56 +0000
Received: from DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::a8) by DB7PR05CA0065.outlook.office365.com
 (2603:10a6:10:2e::42) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.13 via Frontend
 Transport; Wed, 29 Dec 2021 02:28:56 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT029.mail.protection.outlook.com (10.152.20.131) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4823.18 via Frontend Transport; Wed, 29 Dec 2021 02:28:56 +0000
Received: ("Tessian outbound f493ab4f1fb8:v110");
 Wed, 29 Dec 2021 02:28:56 +0000
Received: from 38e59636ea68.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 47D51B2F-D8D2-4B29-BC31-CAB28FC9013F.1; 
 Wed, 29 Dec 2021 02:28:50 +0000
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38e59636ea68.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 02:28:50 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PAXPR08MB7202.eurprd08.prod.outlook.com (2603:10a6:102:209::24)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 29 Dec
 2021 02:28:49 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::14a4:bbac:9e52:a89]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::14a4:bbac:9e52:a89%6]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021
 02:28:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 13bb6f98-684f-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kqIjpt+Lo1WS1ArXfp9rMC6n5O2NRAcyibnwL//dBhE=;
 b=Psbf8bml0l3x6a+cRrqkjaLMGipPj9gyh/s+6P0bcAiRhlZomrxIXyJt74NL8mh+tbeuav9HeqKlVZGfmun1lDBziUq2EpA/csKnPCm5pLoqNkOQM7D5/l/GHZgudxaXLWRa/wLUU+GiDYz9IDei3AAztVOwgxjl0KN67B+xF/A=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=NOJ1UzpW67oH94EgEMH/jfDaPxi7hIblYXpvri9BqyRC0YXcYvPO+c5wIDwV9GPhFC9tmmEHfzjiSqXf+GklCQgocMD0Fc8pzDfLcZEKqdd4yYFvqlcStzmUpAKHmzeXNvlOa1BgAEP3QlZLr0c2a7MbmTvtE3c6BN2dfdUtFICx9BvNSN/gl299ua11kdGJCafQhq9MiAm7GD7dLYui9xRDPlX0rNMckfzKNzyX7CesA1fj4Cs32hW7xYshy9gR5oyDc7udIzHxVSbmFRwdHLEHaTZnsS2AmFZ+s5sWrRccOkKcC/6nj2KCGCQaTrIgE4Ad+nGySen7Jt9g/Y0VeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=kqIjpt+Lo1WS1ArXfp9rMC6n5O2NRAcyibnwL//dBhE=;
 b=fV4cbMggERNddY7qpCWIi4q5NbnPhRFQcNO1k/iPeiG5I5nmBnhtSKlN7O8jXj0df67N8vqrT24pyDxG5LGusq91JJfPIQCMTERfcj5I5hA76U9sRFexEq2PMBNrDS6vNJNXDZr8LuKhRWqA0xo84ca6FZCTLhpoBDG0WWAY1WuWdTMnPQLoWCFKaorQ0AH4k6hkhq69FSWwpCjpsUtcvPICII35kVuy0SqgfN++6FgcrkS5izjip9o82GF7YCuHhq/zuoolCF+QvGl52ab54CdnEUTed66sYeOEy4L+26aVPeYZVum5lhVgoNFG7UtSreXTNUilO33KrVephVuGTw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=kqIjpt+Lo1WS1ArXfp9rMC6n5O2NRAcyibnwL//dBhE=;
 b=Psbf8bml0l3x6a+cRrqkjaLMGipPj9gyh/s+6P0bcAiRhlZomrxIXyJt74NL8mh+tbeuav9HeqKlVZGfmun1lDBziUq2EpA/csKnPCm5pLoqNkOQM7D5/l/GHZgudxaXLWRa/wLUU+GiDYz9IDei3AAztVOwgxjl0KN67B+xF/A=
From: Wei Chen <Wei.Chen@arm.com>
To: Ayan Kumar Halder <ayan.halder.arm@gmail.com>,
	"julien.grall.oss@gmail.com" <julien.grall.oss@gmail.com>, Bertrand Marquis
	<Bertrand.Marquis@arm.com>, "Volodymyr_Babchuk@epam.com"
	<Volodymyr_Babchuk@epam.com>, "sstabellini@kernel.org"
	<sstabellini@kernel.org>
CC: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: Trying to boot xen on Raspberry-pi 3 B+
Thread-Topic: Trying to boot xen on Raspberry-pi 3 B+
Thread-Index: AQHX++2COlXdxXWyoECa4qN3vDrNSqxIvyAA
Date: Wed, 29 Dec 2021 02:28:48 +0000
Message-ID:
 <PAXPR08MB7420BE81CFDF0F95CF20477B9E449@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <ed00e7a6-ed75-5101-0dd1-a5f156aeb68f@gmail.com>
In-Reply-To: <ed00e7a6-ed75-5101-0dd1-a5f156aeb68f@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: E606EE9BEB5DB846AB79C63F32DD8876.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: 08d40724-0944-4706-3640-08d9ca72f695
x-ms-traffictypediagnostic:
	PAXPR08MB7202:EE_|DB5EUR03FT029:EE_|AS8PR08MB5928:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB592827C790BF4CD7367DFA579E449@AS8PR08MB5928.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 YdxjmjgDmMvcdZTySm/RywOHj6BUuVhyptQdfBrIqTo3y0HMlhAAmHgQ21KkjDYMpUDYjZELKlIMVgONhdxQtjd/gdsxofmQSSHqooCnmxS+FaT2O/F0EUYkXnDeOwuWh+PbwlkK3NXkP//j6phHpoJ375hbsW+ySc2XaIHW/NopOqEjvZR6bCWlqa3/QLPPzLt2iP7rnZ//2hjjYyds9mIHRdsGR5f/2soZ8FWfhxR9QFwmske9e1+8ADokFHGdDww5hmlLycrqnZs32TUUC0xCtYOfj2P6e11RICR4D46fuWqXbtnNYhvj88veCXlMPuhvTBXfs+zotdU4HY90SpVt/KkfmTT/U2RKBIpSIghCJO/KB7/UdL8XvdFVqslAhjDNRyPLoNpVda2173oNlHV7tkQyq6HdlAYbLv7o0d6gvBYkUwIASck7MMPVhIK+SwCRAEatonPBJZ6luqnwoK7asjuGkeZkffKGfuXlqmfE3Q9aMcqLZSP2eInLUfuSPYl3JNxVZ2/f3lNi9MdZs/jKnXvalbLp+zz+2/IT0k2bDR7wWsMyaLc+XIL6rYn8331NAmZXSgthesPmWPOLq/Fer1wwWDz+OlOPPxs0FfsI12ampE9gL27JO5Kl6Aq+Xl+xJWGgJPjOQG6rBsLTiN5cf8Bcbv0Xnr14/ChxxyneaZ0E+Ff8J2eWdpCOYfjAVED75KHef4UXbbV0c/+cpqwfCnT+c0bFotP8rX3OgVsvxQlGdlOQAgjHLhNVMspm4tlFUPoFIPxaHy7GeKKAQdYy6WSWkSmoavAGKt8YlB4=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(38070700005)(52536014)(2906002)(66476007)(76116006)(7696005)(66946007)(33656002)(9686003)(8676002)(55016003)(5660300002)(38100700002)(71200400001)(122000001)(6506007)(53546011)(83380400001)(508600001)(86362001)(316002)(26005)(186003)(966005)(110136005)(8936002)(4326008)(66446008)(64756008)(66556008);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7202
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	a85292d7-d188-4a91-f159-08d9ca72f25d
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	Q7pB5XKe+iDPvICNxXLUzKHPKcsQjWriMOF4A0QvqLl0YDtZI8xBmb68sAAUeCMskCaEOiWLrT4ULf566lhT6aMZSWtuTc8pW/nZrq6E/iaXodbGJp6b7oPdlDQnJTExHEARgQIo2Vve4TkC0NpLC3o4Z5mljctHl6ZWiIZW1QouAm63e29E3QQL8UHlcHN71StiAFXMKSfXf7zBIoPMD7p6G9Q8aC87EGwD7Aa0rakgxw7hmm0+1PVyttmIHG+HolCY0466Pwr2HVtq9XuD/TUJSrgjw8EzgU5no2QMSELSKf1qSB9Kw1b5YQ3Xdv3NU7HQjApnqqOveS/Spj8YqRZYtn5dQ1iN7W+ZcwmuY1V+vTMrkV96PrM0Dh2ooFUV3a/3/PV3gXaCaOHUqR+PjfIra2cfCXOEp5juHIphlj/jNVQtZI6rMSOJsFwl0C5hOJG0rtr/UQQKa6MYMu11BpNJg9XCfOEtrHGnpFCQt3XF/myR5kVrU3wYKrvmeEM/A5VzD78Jt5xfFeLf0fCVRryKpUGOqz+Y9WPb2Z3Uc8xLE2MdZmsKEfgF7o23sGNrJQ6+jLj9U6qWmOICbhDe6bxx9gMCqnyG1tHfw2qNJyAPr1UxVPNyeRbtnbwgfm2An3WPB3lzUDpWWqkG40kzBmfd9azqusncubRymqWUiQWwkEcFbka46GK9umqBaIKW0njtcH2eLEeac5iI6xYvOZv9CBqHQ3kz8JZDiR+fbPON5dxC9M300QWfctOd6+1X54OrPfRJnV5gWKmsi+If2mIC0kYipmDSRZVRnMMO4Tk=
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(55016003)(356005)(7696005)(8936002)(36860700001)(4326008)(110136005)(316002)(2906002)(52536014)(508600001)(70586007)(70206006)(9686003)(33656002)(5660300002)(83380400001)(6506007)(81166007)(186003)(336012)(26005)(82310400004)(47076005)(8676002)(966005)(53546011)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 02:28:56.1535
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 08d40724-0944-4706-3640-08d9ca72f695
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5928

SGkgQXlhbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYZW4tZGV2
ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2Yg
QXlhbg0KPiBLdW1hciBIYWxkZXINCj4gU2VudDogMjAyMeW5tDEy5pyIMjjml6UgMjE6MTkNCj4g
VG86IGp1bGllbi5ncmFsbC5vc3NAZ21haWwuY29tOyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0
cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbTsNCj4gc3N0
YWJlbGxpbmlAa2VybmVsLm9yZw0KPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn
DQo+IFN1YmplY3Q6IFRyeWluZyB0byBib290IHhlbiBvbiBSYXNwYmVycnktcGkgMyBCKw0KPiAN
Cj4gSGksDQo+IA0KPiBJIGFtIHRyeWluZyB0byBib290IHhlbiBvbiBSYXNwYmVycnktcGkgMyBC
KyBhcyBteSBob2JieSBwcm9qZWN0IHRvDQo+IGxlYXJuIGFib3V0IFhlbi4NCj4gDQo+IEkgdXNl
ZCB0aGUgbGF0ZXN0IHZlcnNpb24gb2YgeGVuDQo+IChmMWUyNjhiOWZkMTM2NDdlMWY2OWM4Y2Uw
YWU3YmU0MDFkMzE5ZmM4KS7CoCBJIHRyaWVkIHVzaW5nDQo+IHRpbnk2NF9kZWZjb25maWcgYW5k
IGJ1aWx0IHhlbi00LjE3LXVuc3RhYmxlLiBBbHNvIEkgZW5hYmxlZCBwcmludGsgYW5kDQo+IHNl
dCAweDdlMjE1MDQwIGFzIHRoZSBlYXJseSBwcmludGsgcGh5c2ljYWwgYmFzZSBhZGRyZXNzICgw
eDdlMjE1MDQwKS4NCj4gDQo+IFRoZW4sIEkganVzdCB0cmllZCB0byBsb2FkIHhlbiBhbmQgZHRi
ICh0aGUgc2FtZSB3aGljaCBoYXMgd29ya2VkIGZpbmUNCj4gZm9yIGxpbnV4KS4gSG93ZXZlciwg
dGhlcmUgaXMgbm8gcHJpbnRzIGFmdGVyICJTdGFydGluZyBrZXJuZWwgLi4uIi4NCj4gDQo+IDEu
IERvIHlvdSBrbm93IGlmIHRoZXJlIGlzIHNvbWV0aGluZyBJIGFtIG1pc3NpbmcgPyBJIGFtIGV4
cGVjdGluZyB0bw0KPiBzZWUgdGhlIFhlbiBlYXJseXByaW50ayBsb2dzLg0KPiANCj4gMi4gSXMg
cmFzcGJlcnJ5IDMgQisgZXhwZWN0ZWQgdG8gd29yayB3aXRoIFhlbiA/IEkgd2FzIHJlYWRpbmcN
Cj4gaHR0cHM6Ly93d3cubGludXguY29tL2ZlYXR1cmVkL3hlbi1vbi1yYXNwYmVycnktcGktNC1h
ZHZlbnR1cmVzLyBhbmQgaXMNCj4gbXkgdW5kZXJzdGFuZGluZyBjb3JyZWN0IHRoYXQgb25seSBQ
aSA0IGlzIHN1cHBvcnRlZCA/DQo+IA0KDQpJdCBzZWVtcyByYXNwYmVycmllcyAzIEIrIGRvZXNu
J3QgaGF2ZSBHSUMgaW50ZXJydXB0IGNvbnRyb2xsZXIuDQpJZiB5ZXMsIEkgdGhpbmsgeW91IGNh
bid0IG1ha2UgWGVuIHdvcmsgcHJvcGVybHkgb24gcmFzcGJlcnJpZXMgMyBCKy4NCkJlY2F1c2Ug
WGVuIG9ubHkgc3VwcG9ydHMgR0lDIGZvciBBcm0gYXJjaGl0ZWN0dXJlcy4NCg0KPiBLaW5kIHJl
Z2FyZHMsDQo+IA0KPiBBeWFuDQo+IA0KDQo=


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 03:08:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 03:08:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252288.433290 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2PK2-0004rh-OK; Wed, 29 Dec 2021 03:08:14 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252288.433290; Wed, 29 Dec 2021 03:08:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2PK2-0004ra-Jw; Wed, 29 Dec 2021 03:08:14 +0000
Received: by outflank-mailman (input) for mailman id 252288;
 Wed, 29 Dec 2021 03:08:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <SRS0=h/ph=RO=arm.com=Wei.Chen@srs-se1.protection.inumbo.net>)
 id 1n2PK1-0004rU-Le
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 03:08:13 +0000
Received: from EUR02-AM5-obe.outbound.protection.outlook.com
 (mail-am5eur02on0608.outbound.protection.outlook.com
 [2a01:111:f400:fe07::608])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 8d489ec3-6854-11ec-9e60-abaf8a552007;
 Wed, 29 Dec 2021 04:08:10 +0100 (CET)
Received: from AM6P192CA0006.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::19)
 by DB7PR08MB3242.eurprd08.prod.outlook.com (2603:10a6:5:1a::31) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 03:08:07 +0000
Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:209:83:cafe::81) by AM6P192CA0006.outlook.office365.com
 (2603:10a6:209:83::19) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19 via Frontend
 Transport; Wed, 29 Dec 2021 03:08:07 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4823.18 via Frontend Transport; Wed, 29 Dec 2021 03:08:07 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Wed, 29 Dec 2021 03:08:06 +0000
Received: from 496210918385.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 11F278BF-59DE-4C52-8538-02F1B1423D21.1; 
 Wed, 29 Dec 2021 03:08:01 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 496210918385.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 03:08:01 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9)
 by PAXPR08MB7466.eurprd08.prod.outlook.com (2603:10a6:102:2b8::10)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.18; Wed, 29 Dec
 2021 03:07:58 +0000
Received: from PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::14a4:bbac:9e52:a89]) by PAXPR08MB7420.eurprd08.prod.outlook.com
 ([fe80::14a4:bbac:9e52:a89%6]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021
 03:07:58 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8d489ec3-6854-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=efIaF1qLuE1qm2AhriBGjfCqUlFRQKWyaN0KzsHtSuw=;
 b=8ueouPmwN2vltwXbBT01+ZauHz2joLyh+gkT1nzrgYXaD0Z1/XMwY3egSjYe2sEAIovmL/MlR1+iPq2mDVPlmNBsyTSJfR1TkhO/HbF7JSrsAUjAPO/raNv0f93wg9OsKg9Y0tz4AUFAPVYcMz1kXr7hJrT8CxFYW6+FjGSfvT8=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=V8s4XqGfT/gWx0X8anefadGPbUXfDsNF7uUssACy9Hthb5JCQMiJ1wX+0UtZc/ni2F2RzXN7QryL9s/HEY9Y5/tSSz1agt+oLA5GVtm/nBgZbOdc0DiCY+q9bVje3GFtaOFQgJC/OsjYi+p9+uTOnnK2K9s7FK44ADcPOXkMCpqtaYfq3DB76Gbrxhd6QlNFA/hQWXUS5h6Sv/YLC5LVs+sTnFzF2wlcp1a5orPH4GJAshSV7LcQkAvE0mvtNkfuKRJ4LfiTwFJ97rHJzEsB3XYqgdsJpcSlJg/Bwjoxk8GW2cEB9IEhFA+L6Rt0uwvVh6djoVX26g1DpNK/gT8Z2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=efIaF1qLuE1qm2AhriBGjfCqUlFRQKWyaN0KzsHtSuw=;
 b=Mx+vpWKT1+uGIqMzkLoiyTsPd4Ih1+TJ1SCWUNEnHWhZtLLVongdq5E5XDK9Swgl73TKp7vigu/9lH8WhibCBpoykn6z4OsLRi8yF7xoFmqLLuAUROnDs10ghpGsjVd7d2FwshjTNXJBjLL+MOqSScEYp7H1F6aDLLBy7+pYo8AwTnyoI6kp2kLwd9tm78+xIJkhksrJ6aevLSBsydz1EBBwMnJl2wd40dAjmArqv4SNi7s6MPELpSDE/ufCPdRNGQOVMRXE2x+GiQqwSsCCeg3htgbMUtR2vdAo5n/MdzqZ0111SWgI3l7FQe5BUFdZBOXMHBLgjiYA+stQnA4NNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=efIaF1qLuE1qm2AhriBGjfCqUlFRQKWyaN0KzsHtSuw=;
 b=8ueouPmwN2vltwXbBT01+ZauHz2joLyh+gkT1nzrgYXaD0Z1/XMwY3egSjYe2sEAIovmL/MlR1+iPq2mDVPlmNBsyTSJfR1TkhO/HbF7JSrsAUjAPO/raNv0f93wg9OsKg9Y0tz4AUFAPVYcMz1kXr7hJrT8CxFYW6+FjGSfvT8=
From: Wei Chen <Wei.Chen@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel
	<xen-devel@lists.xenproject.org>
CC: Anthony PERARD <anthony.perard@citrix.com>, Juergen Gross
	<jgross@suse.com>
Subject: RE: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()
Thread-Topic: [PATCH] tools/libxc: Drop copy-in in xc_physinfo()
Thread-Index: AQHX+Bl8am17YIUWIE21NwFF13uUc6xI0f0Q
Date: Wed, 29 Dec 2021 03:07:56 +0000
Message-ID:
 <PAXPR08MB74206290792C8F74D166C5A29E449@PAXPR08MB7420.eurprd08.prod.outlook.com>
References: <20211223162244.16198-1-andrew.cooper3@citrix.com>
In-Reply-To: <20211223162244.16198-1-andrew.cooper3@citrix.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: F6520E4D1A13D74C8DDABDE8D6D9FD7C.0
x-checkrecipientchecked: true
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-MS-Office365-Filtering-Correlation-Id: a316a500-be26-4de6-3165-08d9ca786fe7
x-ms-traffictypediagnostic:
	PAXPR08MB7466:EE_|AM5EUR03FT019:EE_|DB7PR08MB3242:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3242C47C1B92105E321141359E449@DB7PR08MB3242.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:3631;OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Mx3bBBH/Ivt0kMIokGIpuJaN7+gQm3xUeazxqw53zPZzpBqvVqY9KED9RDSX5WG0qMmEQ4SyKUB3JWc8WKSNzt2xqwrE5cTKJ4T7RpFGOk1QZEL+tK+CKxoXada6S3AobLY3ZaLasHHBFk0+K3Z/GZY6Yqd0AX4CUFmhcy93HDw052b9qM9+yfTtuavWLPerpZ8jfsyAhzuJV9obcazXFdNevcRPmKGcDprQ6qaGdeBG1EygDefRib/oJObUhgGZMaOX1a2PLlz0jcU+2+v2q2IGz/OnJeUftyj1fmjnb54exS+rek8HtEjzBUb0JteBQumKZAMRwqB2b3z0WlR/igy41dyPvEqmzNldaBkkV5+UlaLLccen0GkqIxcQq7f4Mcy9S2bmDwpLsgrsFbWldNeFWi9kOKHyB46yE2xk2YiQfembdp54ETaL1ND2GMyRh8Gh+5aIAApdP0Ol+xQ7PIXSFdcbf4HtKVVVI1rFCvaX9rPZSFnzfEJkm6KmwbsMaS61LpQuaFjOikI02fajTEaotBB2KzuPCEznft+8MY8Os2403GfVLk8sNpjFAcR86Ve1m9iKQKyvCsjqn45UzGNyAFCRxCGrypZWC1ZtihpNCL7tqLIlHNdmrEeeARqbfWHNwYT0dFWD58FSOA/Kf91UWASSgViM4U94nNHu26JqqM+MmzW0tjiNzIdxU7M4zXD/enIhzdUyJwxzXdJ81A==
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(9686003)(38070700005)(86362001)(55016003)(26005)(71200400001)(66556008)(2906002)(66476007)(53546011)(6506007)(508600001)(76116006)(33656002)(38100700002)(8676002)(66946007)(64756008)(110136005)(54906003)(83380400001)(66446008)(4326008)(122000001)(8936002)(7696005)(316002)(5660300002)(52536014);DIR:OUT;SFP:1101;
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7466
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	1d6f5c8e-919d-450b-43e5-08d9ca786a92
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YXkiTytFFhdnGqA5agAaxiUFWpiIaM2xCfVVJvKOwaAiOtjXVrXYmdA2cNokDYHypQtsTOYKH+JJXnAtIWA/5FLgg+1/4SmBwfaiwBJeHfknHFZa9i61YlhKCvWro0G8ip869j1Xb4FSoJnA8g2RYx3P52WQofbAbgyMq2fVHtLVk4DADsYXHYZza9klJToG+AbMbkA5uz7ayYvXWUVvjeLdbJm0emJ01Q2Q/vsetFQ0CdzOjq/SQz5nXh8GC+4uwVWSxzKeH+2xKxyFfHKPTkA+H1zTeAq9W7vPP66xUOTTZ5plxHqNGqusEjifHuYiP+vKIdR51WTqL+VwLxm5y5cDQJpE4BMWJANnl9d3zrQ4RytjS0HufM/ApkKflkpm3p1y24i01nZ1EjuaeYucj7bmE8sdFol9huV6nH8/muPabE9I+6dLz/CUWqB5R15jmK3YypRrd9JeSUETuS1UIi/yaV5+qemZx+YmKzA5fEHWLNo6ghGRMJA5Bt+1+tna/uklnTCqDUj65Bs7UHNgWXu4l8k5nkrI2H10nwFeYTZTryLc153Ru+5V/5RgRZGwoRa1dz9Z+qcA5RSrwrEiHr9QGN5IcHR1EUMhrCy9p1LtUKzp9TvWuUMviBJScqTi2Pzesuz1NcQUgjFbAFLjLuUqzPPO4OXXWcDD8CPCtX+Sja4y15na9iEwj/c/4J0Ck1kwXwIqK4m8m1tpwLyjgw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(9686003)(55016003)(356005)(70206006)(186003)(5660300002)(36860700001)(86362001)(82310400004)(316002)(4326008)(8936002)(2906002)(26005)(54906003)(47076005)(33656002)(336012)(107886003)(110136005)(7696005)(8676002)(83380400001)(6506007)(52536014)(70586007)(53546011)(508600001)(81166007);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 03:08:07.1163
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a316a500-be26-4de6-3165-08d9ca786fe7
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3242

SGkgQW5kcmV3LA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFhlbi1k
ZXZlbCA8eGVuLWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBP
Zg0KPiBBbmRyZXcgQ29vcGVyDQo+IFNlbnQ6IDIwMjHE6jEy1MIyNMjVIDA6MjMNCj4gVG86IFhl
bi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnPg0KPiBDYzogQW5kcmV3IENv
b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT47IEFudGhvbnkgUEVSQVJEDQo+IDxhbnRo
b255LnBlcmFyZEBjaXRyaXguY29tPjsgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0K
PiBTdWJqZWN0OiBbUEFUQ0hdIHRvb2xzL2xpYnhjOiBEcm9wIGNvcHktaW4gaW4geGNfcGh5c2lu
Zm8oKQ0KPiANCj4gVGhlIGZpcnN0IHRoaW5nIFhFTl9TWVNDVExfcGh5c2luZm8gZG9lcyBpcyB6
ZXJvIG9wLT51LnBoeXNpbmZvLg0KPiANCj4gRG8gbm90IGNvcHktaW4uICBJdCdzIHBvaW50bGVz
cywgYW5kIG1vc3QgY2FsbGVycyBkb24ndCBpbml0aWFsaXNlIHRoZWlyDQo+IHhjX3BoeXNpbmZv
X3QgYnVmZmVyIHRvIGJlZ2luIHdpdGguICBSZW1vdmUgdGhlIHBvaW50bGVzcyB6ZXJvaW5nIGZy
b20gdGhlDQo+IHJlbWFpbmluZyBjYWxsZXJzLg0KPiANCj4gU3BvdHRlZCBieSBDb3Zlcml0eS4N
Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJp
eC5jb20+DQo+IC0tLQ0KPiBDQzogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJp
eC5jb20+DQo+IENDOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IC0tLQ0KPiAg
dG9vbHMvbGlicy9jdHJsL3hjX21pc2MuYyB8IDIgLS0NCj4gIHRvb2xzL2xpYnMvbGlnaHQvbGli
eGwuYyAgfCAyICstDQo+ICB0b29scy9saWJzL3N0YXQveGVuc3RhdC5jIHwgMiArLQ0KPiAgdG9v
bHMvbWlzYy94ZW5wbS5jICAgICAgICB8IDIgKy0NCj4gIHRvb2xzL3hlbm1vbi94ZW5iYWtlZC5j
ICAgfCAyICstDQo+ICB0b29scy94ZW50cmFjZS94ZW50cmFjZS5jIHwgMiArLQ0KPiAgNiBmaWxl
cyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0t
Z2l0IGEvdG9vbHMvbGlicy9jdHJsL3hjX21pc2MuYyBiL3Rvb2xzL2xpYnMvY3RybC94Y19taXNj
LmMNCj4gaW5kZXggMzgyMDM5NDQxM2E5Li4yNjVmMTVlYzJkYTMgMTAwNjQ0DQo+IC0tLSBhL3Rv
b2xzL2xpYnMvY3RybC94Y19taXNjLmMNCj4gKysrIGIvdG9vbHMvbGlicy9jdHJsL3hjX21pc2Mu
Yw0KPiBAQCAtMTk1LDggKzE5NSw2IEBAIGludCB4Y19waHlzaW5mbyh4Y19pbnRlcmZhY2UgKnhj
aCwNCj4gDQo+ICAgICAgc3lzY3RsLmNtZCA9IFhFTl9TWVNDVExfcGh5c2luZm87DQo+IA0KPiAt
ICAgIG1lbWNweSgmc3lzY3RsLnUucGh5c2luZm8sIHB1dF9pbmZvLCBzaXplb2YoKnB1dF9pbmZv
KSk7DQo+IC0NCj4gICAgICBpZiAoIChyZXQgPSBkb19zeXNjdGwoeGNoLCAmc3lzY3RsKSkgIT0g
MCApDQo+ICAgICAgICAgIHJldHVybiByZXQ7DQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGli
cy9saWdodC9saWJ4bC5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bC5jDQo+IGluZGV4IGE3N2Fh
ODU2ZmRkNi4uNjY3YWU2NDA5YmU3IDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL2xpZ2h0L2xp
YnhsLmMNCj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bC5jDQo+IEBAIC0zNTEsNyArMzUx
LDcgQEAgY29uc3QgY2hhciAqbGlieGxfZGVmYm9vbF90b19zdHJpbmcobGlieGxfZGVmYm9vbCBi
KQ0KPiANCj4gLyoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioNCj4gKioqKiovDQo+ICBpbnQgbGlieGxfZ2V0X3Bo
eXNpbmZvKGxpYnhsX2N0eCAqY3R4LCBsaWJ4bF9waHlzaW5mbyAqcGh5c2luZm8pDQo+ICB7DQo+
IC0gICAgeGNfcGh5c2luZm9fdCB4Y3BoeXNpbmZvID0geyAwIH07DQo+ICsgICAgeGNfcGh5c2lu
Zm9fdCB4Y3BoeXNpbmZvOw0KPiAgICAgIGludCByYzsNCj4gICAgICBsb25nIGw7DQo+ICAgICAg
R0NfSU5JVChjdHgpOw0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9zdGF0L3hlbnN0YXQuYyBi
L3Rvb2xzL2xpYnMvc3RhdC94ZW5zdGF0LmMNCj4gaW5kZXggZTQ5Njg5YWEyZGE5Li44YmFiMmU2
NmE3ZmUgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL2xpYnMvc3RhdC94ZW5zdGF0LmMNCj4gKysrIGIv
dG9vbHMvbGlicy9zdGF0L3hlbnN0YXQuYw0KPiBAQCAtMTM1LDcgKzEzNSw3IEBAIHhlbnN0YXRf
bm9kZSAqeGVuc3RhdF9nZXRfbm9kZSh4ZW5zdGF0X2hhbmRsZSAqIGhhbmRsZSwNCj4gdW5zaWdu
ZWQgaW50IGZsYWdzKQ0KPiAgew0KPiAgI2RlZmluZSBET01BSU5fQ0hVTktfU0laRSAyNTYNCj4g
IAl4ZW5zdGF0X25vZGUgKm5vZGU7DQo+IC0JeGNfcGh5c2luZm9fdCBwaHlzaW5mbyA9IHsgMCB9
Ow0KPiArCXhjX3BoeXNpbmZvX3QgcGh5c2luZm87DQo+ICAJeGNfZG9tYWluaW5mb190IGRvbWFp
bmluZm9bRE9NQUlOX0NIVU5LX1NJWkVdOw0KPiAgCWludCBuZXdfZG9tYWluczsNCj4gIAl1bnNp
Z25lZCBpbnQgaTsNCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL21pc2MveGVucG0uYyBiL3Rvb2xzL21p
c2MveGVucG0uYw0KPiBpbmRleCBkMDE5MWQ0OTg0ODQuLjRmOGNkZTY5MGE3YyAxMDA2NDQNCj4g
LS0tIGEvdG9vbHMvbWlzYy94ZW5wbS5jDQo+ICsrKyBiL3Rvb2xzL21pc2MveGVucG0uYw0KPiBA
QCAtMTI0NCw3ICsxMjQ0LDcgQEAgc3RydWN0IHsNCj4gIGludCBtYWluKGludCBhcmdjLCBjaGFy
ICphcmd2W10pDQo+ICB7DQo+ICAgICAgaW50IGksIHJldCA9IDA7DQo+IC0gICAgeGNfcGh5c2lu
Zm9fdCBwaHlzaW5mbyA9IHsgMCB9Ow0KPiArICAgIHhjX3BoeXNpbmZvX3QgcGh5c2luZm87DQo+
ICAgICAgaW50IG5yX21hdGNoZXMgPSAwOw0KPiAgICAgIGludCBtYXRjaGVzX21haW5fb3B0aW9u
c1tBUlJBWV9TSVpFKG1haW5fb3B0aW9ucyldOw0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hl
bm1vbi94ZW5iYWtlZC5jIGIvdG9vbHMveGVubW9uL3hlbmJha2VkLmMNCj4gaW5kZXggMWVkMzQz
MzRjODI0Li43NTkxZGU3YzYwOWYgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL3hlbm1vbi94ZW5iYWtl
ZC5jDQo+ICsrKyBiL3Rvb2xzL3hlbm1vbi94ZW5iYWtlZC5jDQo+IEBAIC00MzYsNyArNDM2LDcg
QEAgc3RhdGljIHN0cnVjdCB0X3N0cnVjdCAqbWFwX3RidWZzKHVuc2lnbmVkIGxvbmcNCj4gdGJ1
ZnNfbWZuLCB1bnNpZ25lZCBpbnQgbnVtLA0KPiAgICovDQo+ICBzdGF0aWMgdW5zaWduZWQgaW50
IGdldF9udW1fY3B1cyh2b2lkKQ0KPiAgew0KPiAtICAgIHhjX3BoeXNpbmZvX3QgcGh5c2luZm8g
PSB7IDAgfTsNCj4gKyAgICB4Y19waHlzaW5mb190IHBoeXNpbmZvOw0KPiAgICAgIHhjX2ludGVy
ZmFjZSAqeGNfaGFuZGxlID0geGNfaW50ZXJmYWNlX29wZW4oMCwwLDApOw0KPiAgICAgIGludCBy
ZXQ7DQo+IA0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMveGVudHJhY2UveGVudHJhY2UuYyBiL3Rvb2xz
L3hlbnRyYWNlL3hlbnRyYWNlLmMNCj4gaW5kZXggYTg5MDNlYmY0NjI1Li44NjRlMzBkNTBjYzMg
MTAwNjQ0DQo+IC0tLSBhL3Rvb2xzL3hlbnRyYWNlL3hlbnRyYWNlLmMNCj4gKysrIGIvdG9vbHMv
eGVudHJhY2UveGVudHJhY2UuYw0KPiBAQCAtNTg5LDcgKzU4OSw3IEBAIHN0YXRpYyB2b2lkIHNl
dF9ldnRfbWFzayh1aW50MzJfdCBtYXNrKQ0KPiAgICovDQo+ICBzdGF0aWMgdW5zaWduZWQgaW50
IGdldF9udW1fY3B1cyh2b2lkKQ0KPiAgew0KPiAtICAgIHhjX3BoeXNpbmZvX3QgcGh5c2luZm8g
PSB7IDAgfTsNCj4gKyAgICB4Y19waHlzaW5mb190IHBoeXNpbmZvOw0KPiAgICAgIGludCByZXQ7
DQo+IA0KPiAgICAgIHJldCA9IHhjX3BoeXNpbmZvKHhjX2hhbmRsZSwgJnBoeXNpbmZvKTsNCj4g
LS0NCj4gMi4xMS4wDQo+IA0KDQpSZXZpZXdlZC1ieTogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5j
b20+DQoNCg0K


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 07:30:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 07:30:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252294.433301 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2TP4-0003FS-6u; Wed, 29 Dec 2021 07:29:42 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252294.433301; Wed, 29 Dec 2021 07:29:42 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2TP4-0003FL-3b; Wed, 29 Dec 2021 07:29:42 +0000
Received: by outflank-mailman (input) for mailman id 252294;
 Wed, 29 Dec 2021 07:29:40 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2TP2-0003FB-8D; Wed, 29 Dec 2021 07:29:40 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2TP2-000234-2R; Wed, 29 Dec 2021 07:29:40 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2TP1-0005Eu-Mu; Wed, 29 Dec 2021 07:29:39 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2TP1-0007O4-MU; Wed, 29 Dec 2021 07:29:39 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=S7VlE/Hh9vJxhoF23k6asqTXpy2ZjlvnYfF4SCA3n+0=; b=Mr3TCdBL7guR1wAikmNUbY/UbF
	EvBQwpvnZkOBbSdiWQ8OWUNSBbMEmyJsnPFfb1H6qkiDu1fCMlDLa9ifeBYM+3ZrbUL56CbH1qekf
	vLJOMSlLvd2UneiqgOlI754q+7ReI+TQtSlNlb5P0SERLZN4RRbvOsRWrpwffLqzDj90=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167553-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167553: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-arndale:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-credit2:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-cubietruck:<job status>:broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:<job status>:broken:regression
    linux-linus:test-armhf-armhf-libvirt-raw:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-arndale:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-xl-credit2:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-libvirt-raw:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-xl:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-xl-cubietruck:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-xl-vhd:debian-di-install:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=ecf71de775a049cbfa6298deceb8ba2083331171
X-Osstest-Versions-That:
    linux=a8ad9a2434dc7967ab285437f443cae633b6fc1c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 07:29:39 +0000

flight 167553 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167553/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl             <job status>                 broken
 test-armhf-armhf-xl-arndale     <job status>                 broken
 test-armhf-armhf-xl-credit2     <job status>                 broken
 test-armhf-armhf-xl-cubietruck    <job status>                 broken
 test-armhf-armhf-libvirt-qcow2    <job status>                 broken
 test-armhf-armhf-libvirt-raw    <job status>                 broken
 test-armhf-armhf-xl-arndale   5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-xl-credit2   5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-libvirt-qcow2  5 host-install(5)      broken REGR. vs. 167548
 test-armhf-armhf-libvirt-raw  5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-xl           5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-xl-cubietruck  5 host-install(5)      broken REGR. vs. 167548
 test-armhf-armhf-xl-vhd      12 debian-di-install        fail REGR. vs. 167548

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167548
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167548
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167548
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                ecf71de775a049cbfa6298deceb8ba2083331171
baseline version:
 linux                a8ad9a2434dc7967ab285437f443cae633b6fc1c

Last test of basis   167548  2021-12-27 17:12:14 Z    1 days
Testing same since   167553  2021-12-28 20:40:59 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>
  Luiz Sampaio <sampaio.ime@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Miguel Ojeda <ojeda@kernel.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          broken  
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  broken  
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  broken  
 test-armhf-armhf-xl-cubietruck                               broken  
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               broken  
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 broken  
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl broken
broken-job test-armhf-armhf-xl-arndale broken
broken-job test-armhf-armhf-xl-credit2 broken
broken-job test-armhf-armhf-xl-cubietruck broken
broken-job test-armhf-armhf-libvirt-qcow2 broken
broken-job test-armhf-armhf-libvirt-raw broken
broken-step test-armhf-armhf-xl-arndale host-install(5)
broken-step test-armhf-armhf-xl-credit2 host-install(5)
broken-step test-armhf-armhf-libvirt-qcow2 host-install(5)
broken-step test-armhf-armhf-libvirt-raw host-install(5)
broken-step test-armhf-armhf-xl host-install(5)
broken-step test-armhf-armhf-xl-cubietruck host-install(5)

Not pushing.

------------------------------------------------------------
commit ecf71de775a049cbfa6298deceb8ba2083331171
Merge: f651faaaba5f 4daa9ff89ef2
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Dec 28 11:46:15 2021 -0800

    Merge tag 'auxdisplay-for-linus-v5.16' of git://github.com/ojeda/linux
    
    Pull auxdisplay fixes from Miguel Ojeda:
     "A couple of improvements for charlcd:
    
       - check pointer before dereferencing
    
       - fix coding style issue"
    
    * tag 'auxdisplay-for-linus-v5.16' of git://github.com/ojeda/linux:
      auxdisplay: charlcd: checking for pointer reference before dereferencing
      auxdisplay: charlcd: fixing coding style issue

commit f651faaaba5f41ffac195e64f58483721e60eafc
Merge: a8ad9a2434dc 8d84fca4375e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Dec 28 11:42:01 2021 -0800

    Merge tag 'powerpc-5.16-5' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
    
    Pull powerpc fix from Michael Ellerman:
     "Fix DEBUG_WX never reporting any WX mappings, due to use of an
      incorrect config symbol since we converted to using generic ptdump"
    
    * tag 'powerpc-5.16-5' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
      powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion

commit 8d84fca4375e3c35dadc16b8c7eee6821b2a575c
Author: Michael Ellerman <mpe@ellerman.id.au>
Date:   Fri Dec 3 23:41:12 2021 +1100

    powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion
    
    In note_prot_wx() we bail out without reporting anything if
    CONFIG_PPC_DEBUG_WX is disabled.
    
    But CONFIG_PPC_DEBUG_WX was removed in the conversion to generic ptdump,
    we now need to use CONFIG_DEBUG_WX instead.
    
    Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
    Cc: stable@vger.kernel.org # v5.15+
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Link: https://lore.kernel.org/r/20211203124112.2912562-1-mpe@ellerman.id.au

commit 4daa9ff89ef27be43c15995412d6aee393a78200
Author: Luiz Sampaio <sampaio.ime@gmail.com>
Date:   Tue Nov 9 19:07:32 2021 -0300

    auxdisplay: charlcd: checking for pointer reference before dereferencing
    
    Check if the pointer lcd->ops->init_display exists before dereferencing it.
    If a driver called charlcd_init() without defining the ops, this would
    return segmentation fault, as happened to me when implementing a charlcd
    driver.  Checking the pointer before dereferencing protects from
    segmentation fault.
    
    Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
    Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

commit 94047df12fec0e51e860b5317223f67a3ea4eb07
Author: Luiz Sampaio <sampaio.ime@gmail.com>
Date:   Tue Nov 9 19:07:31 2021 -0300

    auxdisplay: charlcd: fixing coding style issue
    
    Removing 'int' from 'unsigned long int' declaration, which is unnecessary.
    
    Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
    Signed-off-by: Miguel Ojeda <ojeda@kernel.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 08:33:31 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 08:33:31 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252315.433311 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2UOF-00026G-J7; Wed, 29 Dec 2021 08:32:55 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252315.433311; Wed, 29 Dec 2021 08:32:55 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2UOF-000269-GA; Wed, 29 Dec 2021 08:32:55 +0000
Received: by outflank-mailman (input) for mailman id 252315;
 Wed, 29 Dec 2021 08:32:53 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ukf9=RO=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n2UOD-000263-9z
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 08:32:53 +0000
Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com
 [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id e7d20cf4-6881-11ec-9e60-abaf8a552007;
 Wed, 29 Dec 2021 09:32:51 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: e7d20cf4-6881-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640766770;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=YfTowUBWkCA5ialIxM+kJQRAaU5cb5qmHjYSuTlaBGM=;
  b=Efoe8fjFWk4AtR6tXiKXEKfVm7yFeu+eXPyMXVkgtAoMmrTng4ARADgQ
   yBbBmKWVsE0Fl1n9cZpVYE3MOymTu23SiNHo3KPIHwSCuCvD0ZyjHHCS5
   TzhHQqFY+CicWpbtOEidGpPDncccX9Bvwpr9Q/jLe2meibTwXM96+3JgW
   4=;
Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: o6Dso3i3l9d8e+WZvWtdCZKrakUO8ldAFqlGi7U+euHuADnVUo4t638gOBLRDA2chrOF4AUO9X
 QgbiladUZP+W1W/04I8BreyxSijyCEAggultACDQpJqnAUUhtgJdJHQ51MKmHiDUYvJOfzjlHb
 HffQVUtEd9cMq8s20ANTGDai+RIudNxYSluwgGaZAkKrGNBcg8merfeQJVruYYfiRq7HS0N/d5
 rmPdQm/Rt6x1MmJlSqjB/5ICDA2fH/6n82c4dKZyOX7gK/Uir2NoLkgQm9ATFFPUdmhJfNDZnH
 8JMQOS4ctS7i2s3dUhCpd2H6
X-SBRS: 5.1
X-MesageID: 60943860
X-Ironport-Server: esa2.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:Tnxj36NVe+F1hv/vrR17kMFynXyQoLVcMsEvi/4bfWQNrUoh1TNUn
 DcdDWCBPvfYamD2e411b47j9k0CvsPRx4A3SAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400gyw7dRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYozmmkukg+
 opdjq6TV1sYBp/3mPUXCBYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uStIMDjGlo7ixINansX
 NsgTyRzVxrvTwJWCGZPI41kxOj90xETdBUH8QnI9MLb+VP73AF3lbTgLtfRUtiLXtlO2FaVo
 Hrc+Gb0CQ1cM8aQoRKL82ihg+LTkCThcJ8JGaejsOVtnUeYy2IUEhIbE122vZGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQrFGJh08uBMprIc4ktDC1+JHU8gzCCT1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj70hu+aTNT8D2BN1bQ9xawfRGp+ZgPc1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpyb8JN4Bu24lfBsB3iM4ldnBO
 hC7VeR5vsE7AZdXRfUvP9LZ5zoCk8AM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3a5HXlk4BCbKmOUE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVAye0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:FvNmEa3dvW2tWnjeOJXpdgqjBSpyeYIsimQD101hICG9Lfb2qy
 n+ppgmPEHP5Qr5OEtApTiBUJPwJk800aQFm7X5Wo3SITUO2VHYV72KiLGN/9SOIVydygcw79
 YET0E6MqyNMbEYt7eK3ODbKadY/DDvysnB7o2/vhRQpENRGtldBm9Ce3im+yZNNW977PQCZf
 6hDp0tnUveRZ1bVLXxOlA1G8z44/HbnpPvZhALQzYh9Qm1lDutrJr3CQKR0BsyWy5Ghe5Kyx
 mJryXJooGY992rwB7V0GHeq7xQhdva09NGQOiBkNIcJDnAghuhIK5hR7qBljYop/zH0idhrP
 D85zMbe+hj4XLYeW+45TPrxgnbyT4rr0TvzFeJ6EGT1/DRdXYfMY5slIhZehzW5w4Lp9dnyp
 9G2Gqfqt5+EQ7AtD6V3amHazha0m6P5VYym+8aiHJSFaEEbqVKkIAZ9ERJVL8dASPB7pw9Gu
 UGNrCS2B9vSyLbU5nlhBgt/DT1NU5DXCtuA3Jy9vB96gIm3UyQlCAjtYkidnRpzuNLd3AL3Z
 WBDk1SrsA8ciYhV9MIOA4we7rGNoXze2O/DIuzGyWvKEhVAQOEl3bIiI9Fkd1CPqZ4i6cPpA
 ==
X-IronPort-AV: E=Sophos;i="5.88,244,1635220800"; 
   d="scan'208";a="60943860"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EV8MxdsCWvdBlVHI8KghG518RdJAwoKo/i0GJTThbKQW0lm991NuC4/Vws07ks89B5mTBmW8ahjagpwUUR3A5NNDOtdQIQdcoB9ptYcZwLusTzTkZlbiVZyg8AAM+fmsDjkbIzB2Ft1X4Xz7V2z9l4mTUJcJjupi+EYd3gLj0AXXUcG7kNedBPStb/4i8J5ojpNg63vz7CJWFUK9gouRi1W/0Pwepfho4aYEiopRoC7Dzlf6dbqEaHQtKu3uEAuP/WOymzymCd/e+XlDldrZyij101ZiWKIXff8vwI8AB9SfYBPZwj146v2yZ/+5CuWevflDMABqJZXsFqmtw/6/bg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pe8tWSAxsYXH3EC6+zhM3nXnUZ3ZtbBnfaEIj5tNTgw=;
 b=WwGyHSeMjZSzhda/gUBW4XMK52ATbx38w/2r2gUdWKkK7jkzfAHRhEguymzLt3gIMAPX6XLe3K2tM1Mp4pFm6qxLj85V5Rb24nEFQE91PpTdhRPiifA3X561Smjc0rWD3rKHVnzAK6Qm4MSn0aed42ehDfxAH6xvCF7Z9uQ6vcbfqzEAKIRYfGJ808xtCLh7KROEZW3+CsX4HhbDV9cT3OznMCgrC7sezzq0mE5kS6wJrdkZBIvHLZdmHYn5Bvk0pcxJa8Y6VhdikeekXHMjH/CqPX/G93nkryVI7B7UR4NWNL3PfgFDQ993qcmBR/WCBAH0HqfCyLB4vwgTKiLeCQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pe8tWSAxsYXH3EC6+zhM3nXnUZ3ZtbBnfaEIj5tNTgw=;
 b=wv/NeNShWTWyilw1AUkEVhIkR9CLqOLojwMQR11hxtRhIpqODMUAasa765csvJOVRcnh2CMVdmjE9eDDySRLztv1j1r7kFiw0N2P0XMx6Aqj0MvGtNXzW8+GIGazmS/ox5hxomyUGc+Yka+Tqn7axwOSdnuKNnHp4SMCecK10Ic=
Date: Wed, 29 Dec 2021 09:32:38 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <YcwdJn/Y0yncuJ/e@Air-de-Roger>
References: <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger>
 <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger>
 <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger>
 <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger>
 <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
X-ClientProxiedBy: MR2P264CA0086.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::26) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d9b41e90-b5f6-43de-3912-08d9caa5c943
X-MS-TrafficTypeDiagnostic: DM5PR03MB3145:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB31453569524518A8098043448F449@DM5PR03MB3145.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5NFjfpPk9lqU5rZLRDYB+OrE3aPNMMP9N82YtID725goI7wPft/xN6houFLbzYPkuO+7PXzmwORR642pwxNWxGhOju46GehLPA+MXZheMO4MypKPSV9cvsltlXW/bIYg8H9HoI3qpTaw7qovEMNHkdCuyieQk56DmYoDim2BODRenZQjsdRhuZUyESxnqc/0EZmlCZiUy4pwX8CQXAq8DTOjy9IuuPCe3GYzsXmGS6+/tRgUDwDtcz2x1Es9wjPsUnpXP9/uC1L2nZJF0GGWmefsJBg33SaFWDLs4oO4KkSu3TdvzdAwsOog5JVfw/FWcL9xVrtDVCB8m6rXnvb8O4X1GLTatpwfoTudppcQqOJP48N8yQR9T0VDwhXDGr2y4BVOvAZiPcz3YVO8BN3rO1O6jiYShLoTYGxHeaklA1kbuVwR/lIMDyKYzVbX3f7gyMl6N2BL0v84oLvqYme5o/Yy5taFLndv4d0TtRnmjV7Pm0eQdv57SHfgO/NiCpyz8+5U2lKSrxgh5mz7JCKjQ/RQreAsoLHJTPNbPqH0GPv1j42TNmsgKTT7aTaGwaSJjlOJDmPEUie0BDRB4a4jnoyxocNPcgsXQ1vfVMidDwGggi2gxZ9sTSrFPrhCBP9qeRonW6ehq/yzyh0w9cN5Fw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(508600001)(38100700002)(82960400001)(6916009)(316002)(86362001)(66476007)(8936002)(66946007)(6506007)(6666004)(2906002)(186003)(26005)(4326008)(8676002)(33716001)(53546011)(85182001)(5660300002)(83380400001)(6512007)(66556008)(6486002)(9686003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUw3eEdkVW5OeUo4aC8xS3QxQ1R4UWMxTjA5aFhjUzYvOUNQazFWeEtnbkVn?=
 =?utf-8?B?bzVqOG9SYWV5M21rbkJ1SDBCUWR2c3JrY0NlZVlJbkQ4ZmJkK1FGS2hEYmJU?=
 =?utf-8?B?cjY1S3RZV3p4SmV6NmxNWnM5ZnF4ckpIN0U1TURvcnB3d0E3OHNCNEQwZGtE?=
 =?utf-8?B?K0VScllKYWV4MmJHN1hucDRyODhuUmZVWCt6QVc1NzNDUzMyNTZyUVJmNW0r?=
 =?utf-8?B?QndPVDk4UThyalh1MVoyVi9qZ1N5TDVNK25ncUFwL2N4TlBQNVpQeEVvTm84?=
 =?utf-8?B?dG9EcGJlY3dvdnp5aTg1Mkx5bUF5Y0hid2YycHQwaksrdHdyakFtUnMzMUJ3?=
 =?utf-8?B?RytVWWR5MXd6V2lOdlA3dVgydHNOM0lQdnFpMk16TlljMGt0Q1JzZnVmOVhl?=
 =?utf-8?B?cE9MUjdGd2tiamIxK2NZSmFBUFNoZ0RvZm1UNktlT0dGUVRWdFpXQmFnbHdE?=
 =?utf-8?B?WWVmRUhLcmcyRkVQS1F0TWpKdEVEbXZmY2prNVFRN0lmWldEd21WR0ZPZ1pr?=
 =?utf-8?B?aEoxT2NQUjBBYUZ5VFl2WEluMFFmVXliRjBvTTRxQWxYWk1SY1oyRHl4Skh0?=
 =?utf-8?B?Q2RzVm5xWUY2blJCWUt1Tzh2TVNMSk00TlcvYWorclJVTkREU09MWlpjMWxx?=
 =?utf-8?B?TUFPMjU1WXo2VEk3M0lwRklkWG5yelh1U0Ztc2NhZHF4MlMxKzJTT2ZvU0tz?=
 =?utf-8?B?TGtRaCt5RlpVKzVJcTBZYnI3aXBCTWo3cUZlUXNLbHprNHNqZ0o5YzV2VXp0?=
 =?utf-8?B?NnNTeEpGWHh0SkQrcVB3ZGRjaUNXS1lKZWZkUTJWdnZXejVGT2h5ak9ER3lM?=
 =?utf-8?B?NG9OOEtiVVhuYXBnZzRWOWZERTVDNXJGRGgxTWZJU0I1WDdBdzdtTWR1Q3dR?=
 =?utf-8?B?Y0dUZDhGNDVKSjNxbGN3SDNnLzlPWHR0K1BQMThieWk4ODhWcXZKN1FDckNE?=
 =?utf-8?B?WEllMDUzTmlUOElIYXVEVEtWYWRKN0s3MTZJcVJuWGJodzMxVkVVdmVOeFNQ?=
 =?utf-8?B?dWJ5RW5CQ2hIT3Y2RWZuM0l0TUhlWGNtcjNiR24yN294SWt3VGo2R091bDFC?=
 =?utf-8?B?c2NUZFFTNWNqVUZOa2htNkZNY0p3TEZBeFZjN2VranloLzRCa0ZoaTRZRWJa?=
 =?utf-8?B?TDVLUExUZzNxaXdmZElDd0VWWlN2T0x1Y3pROE5ZaFJSaUFMT3JGRk1Hc2VC?=
 =?utf-8?B?VTdKYmxud3YvTUEwNWJuSGpUNEl6K05mU1cwYmx1RlAvOE95YkFnODdiS0dC?=
 =?utf-8?B?cmhHUVByVldNUmxrck9RZW5mUHpEVURxNlVoM3Y3TzNyWlNybVZVZzFHRm55?=
 =?utf-8?B?OVNJOVNTWFZPbEhkVVFpU3pGUEFuMktDd3RIWUtVbFR0Mm1IMXptQTIrVml1?=
 =?utf-8?B?V2tJRjZBL0cveFhjSkRLZk5NbzFneVkxS01Fc0x4Y2k4U2FCZzZ6dDZmakx5?=
 =?utf-8?B?eHZ4MVhsMDk0VVJ4S3kyNUxXUzNaNDN0NUlRT0VHY3ZmZXUwcFQ4b245NytP?=
 =?utf-8?B?RGhCYVVpMXExOGRIUFdIMFVvNG42dXU3MURZRFJvRDZkbTgxdTFXL3Rud21p?=
 =?utf-8?B?M1I2dVAzMjJUM0pYcTduVWp1aXo4aDV5TEtxazNXanNvSFQ1WUNjdVM0d0ZZ?=
 =?utf-8?B?cFFpcU4wVWRoNTIrU3lQUy9lN2Y0Qkd0Tlh5Y0JjY3BycDZpN1VOU0Vrdzl2?=
 =?utf-8?B?TVJ1NmU5TkFLeEdsRWtEMGFiTmVOekVDcE83L1RXbEFqVEVGVlNYV3JKOGsx?=
 =?utf-8?B?c0lGM3IrUCtQd01YTUdsbHVQb0V3dkt6U0pwbFY0UEY5ZUdUU0t1ZTloMEZt?=
 =?utf-8?B?eTZMOG11dDRkMHkzeGd5OEp4T25ITWpSdHZja21kSVhzcDd6U1p5YXV4S3U2?=
 =?utf-8?B?dVU3YUg0VFo3NjVabUE0SkFYblJ3bmhITUFldGpVaWJYRUlJMWVna3pWTkpZ?=
 =?utf-8?B?dGZvREJrbFZ2ZkYwa3IreE5yTXJGNm5BWFBKbEFQRncraHhtS2VrNVQ2Z0NR?=
 =?utf-8?B?ZC9ZaHZPcjJpN1ZSU25teWV1UnNzd2FyaVBiTm1DVmY1UGZqa2FMY1NZSVcy?=
 =?utf-8?B?RjdwcitPRXk1R2hsZWNFUzFITTRuOUpBYnMwQnBydnJvL29oSjNYMS9WcmlS?=
 =?utf-8?B?ZS9Yd3BpVkJLbDRSNG5MNHBNd1FYdENlMHprVEFBV2M1RzlKY1l3Uk9VMnFx?=
 =?utf-8?Q?7WzkAblD2JlDnO7PzfoW8ZQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d9b41e90-b5f6-43de-3912-08d9caa5c943
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 08:32:44.7644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mWl4C6cXsZKuaxnecMgZuE5KB8a9+OFmDnRTyx0W/YUDBctGw+6UzA4M+wTcimnbDPljV8l1UPvG5qwsY8l4wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3145
X-OriginatorOrg: citrix.com

Adding xen-devel back.

On Wed, Dec 29, 2021 at 01:44:18AM +0800, G.R. wrote:
> On Tue, Dec 28, 2021 at 3:05 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> >
> > On Sun, Dec 26, 2021 at 02:06:55AM +0800, G.R. wrote:
> > > > > Thanks. I've raised this on freensd-net for advice [0]. IMO netfront
> > > > > shouldn't receive an mbuf that crosses a page boundary, but if that's
> > > > > indeed a legit mbuf I will figure out the best way to handle it.
> > > > >
> > > > > I have a clumsy patch (below) that might solve this, if you want to
> > > > > give it a try.
> > > >
> > > > Applied the patch and it worked like a charm!
> > > > Thank you so much for your quick help!
> > > > Wish you a wonderful holiday!
> > >
> > > I may have said too quickly...
> > > With the patch I can attach the iscsi disk and neither the dom0 nor
> > > the NAS domU complains this time.
> > > But when I attempt to mount the attached disk it reports I/O errors randomly.
> > > By randomly I mean different disks behave differently...
> > > I don't see any error logs from kernels this time.
> > > (most of the iscsi disks are NTFS FS and mounted through the user mode
> > > fuse library)
> > > But since I have a local backup copy of the image, I can confirm that
> > > mounting that backup image does not result in any I/O error.
> > > Looks like something is still broken here...
> >
> > Indeed. That patch was likely too simple, and didn't properly handle
> > the split of mbuf data buffers.
> >
> > I have another version based on using sglist, which I think it's also
> > a worthwhile change for netfront. Can you please give it a try? I've
> > done a very simple test and seems fine, but you certainly have more
> > interesting cases.
> >
> > You will have to apply it on top of a clean tree, without any of the
> > other patches applied.
> 
> Unfortunately this new version is even worse.
> It not only does not fix the known issue on iSCSI, but also creating
> regression on NFS.
> The regression on NFS is kind of random that it takes a
> non-deterministic time to show up.
> Here is a stack trace for reference:
> db:0:kdb.enter.default>  bt
> Tracing pid 1696 tid 100622 td 0xfffff800883d5740
> kdb_enter() at kdb_enter+0x37/frame 0xfffffe009f80d900
> vpanic() at vpanic+0x197/frame 0xfffffe009f80d950
> panic() at panic+0x43/frame 0xfffffe009f80d9b0
> xn_txq_mq_start_locked() at xn_txq_mq_start_locked+0x5bc/frame
> 0xfffffe009f80da50

I think this is hitting a KASSERT, could you paste the text printed as
part of the panic (not just he backtrace)?

Sorry this is taking a bit of time to solve.

Thanks!


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 08:50:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 08:50:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252320.433323 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2UfJ-0004Vy-3z; Wed, 29 Dec 2021 08:50:33 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252320.433323; Wed, 29 Dec 2021 08:50:33 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2UfJ-0004Vr-0x; Wed, 29 Dec 2021 08:50:33 +0000
Received: by outflank-mailman (input) for mailman id 252320;
 Wed, 29 Dec 2021 08:50:31 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2UfH-0004Vh-85; Wed, 29 Dec 2021 08:50:31 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2UfH-0003vW-6T; Wed, 29 Dec 2021 08:50:31 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2UfG-0007px-UQ; Wed, 29 Dec 2021 08:50:30 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2UfG-0005yt-RZ; Wed, 29 Dec 2021 08:50:30 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=qrvVzcvU5uHJtDIUl1Qatu5gtdbpFP+ll66GyC4WeLA=; b=N+31J7FPcgx+BBicG2IKpgwd7e
	hFASh64BrejQNzQUpuOqkgFHeDUFs1eBzcz6XHg58+PjCd2R4Hy5GnRQSDuL5/1nPLt+YcKMbIdHp
	hdXyJe7FxWavM4332qhFQJoJlQVULff6atRUBKtVIrUG1fN5zxE6Deq9HG3IkvyjDuRE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167555-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167555: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=7935be0fbd8f47266e5972f4cba1a1e58505061a
X-Osstest-Versions-That:
    ovmf=e910f076ad02c80bb69cebb18d51ef6896beee0d
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 08:50:30 +0000

flight 167555 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167555/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 7935be0fbd8f47266e5972f4cba1a1e58505061a
baseline version:
 ovmf                 e910f076ad02c80bb69cebb18d51ef6896beee0d

Last test of basis   167552  2021-12-28 08:42:46 Z    1 days
Testing same since   167555  2021-12-29 02:10:20 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Chasel Chiu <chasel.chiu@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   e910f076ad..7935be0fbd  7935be0fbd8f47266e5972f4cba1a1e58505061a -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 09:13:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 09:13:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252330.433333 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2V1H-0006uZ-04; Wed, 29 Dec 2021 09:13:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252330.433333; Wed, 29 Dec 2021 09:13:14 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2V1G-0006uS-TK; Wed, 29 Dec 2021 09:13:14 +0000
Received: by outflank-mailman (input) for mailman id 252330;
 Wed, 29 Dec 2021 09:13:13 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=72qU=RO=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n2V1F-0006uM-RP
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 09:13:13 +0000
Received: from mail-il1-f179.google.com (mail-il1-f179.google.com
 [209.85.166.179]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 8bbe4bd3-6887-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 10:13:12 +0100 (CET)
Received: by mail-il1-f179.google.com with SMTP id j6so16080825ila.4
 for <xen-devel@lists.xenproject.org>; Wed, 29 Dec 2021 01:13:12 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 8bbe4bd3-6887-11ec-bb0b-79c175774b5d
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=vi7P12MwF7ouUjriCw7IKf03Y0rY27D1AIFsJZzMueo=;
        b=NKuUtY3OwyshGQZDCOp+wZAJ8Qh0kAKfHUJlyaKpUp3SmNfmZZriM2HkRL2Wb/TqJA
         FaH1gcuGLwI6AWSrlq2N6DYa9hMKpJFmGzQCi0Y/eQwa4daoFMNMdiyd++oqxft0ddRT
         jxK4WuTJ/rJmusY/dne86WqyrH4s5UZXXyPzevuC5an+qTdHu60EyTyIjj0/gi+9ToVV
         o3m8QDVpHUlVPWY1F+4Ybnpe5AWdpjCvvfjiBZchyD1UzE3Ya4hO+ZXzTMY4QvYmn9PB
         QYfjVtcclx/f3qf2/zZe9x7EtUDqoZXShOpS2PPi5Gci4MiCYN1IqrcytoE8nr4c/qSc
         enpw==
X-Gm-Message-State: AOAM531PGnuFYfN7zU3R5U7Q8FYD0SXkVZuRH26WDPuhCC6KmNltFbTG
	3EdQzchN7fDBgmvZ9xsAJ4fLBJUMOtsIN7zVIa0=
X-Google-Smtp-Source: ABdhPJzm+R8Nyf2Z/+s88CWHOKWTo9JiPmMWjOHGF14sxmGLPWGs2yJsq2+3oRniA8QEgQF6J4NuOty/VK27pSmw8fA=
X-Received: by 2002:a05:6e02:1584:: with SMTP id m4mr11678093ilu.185.1640769191184;
 Wed, 29 Dec 2021 01:13:11 -0800 (PST)
MIME-Version: 1.0
References: <CAKhsbWbv-Poscajj=Hwe3g6WO9b8VaZm39ygFnsbEfHTpRzrfA@mail.gmail.com>
 <YcHbuug9AECvKXm9@Air-de-Roger> <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger> <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger> <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger> <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger>
In-Reply-To: <YcwdJn/Y0yncuJ/e@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Wed, 29 Dec 2021 17:13:00 +0800
Message-ID: <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Content-Type: multipart/alternative; boundary="000000000000cca18805d445584a"

--000000000000cca18805d445584a
Content-Type: text/plain; charset="UTF-8"

>
> I think this is hitting a KASSERT, could you paste the text printed as
> part of the panic (not just he backtrace)?
>
> Sorry this is taking a bit of time to solve.
>
> Thanks!
>
Sorry that I didn't make it clear in the first place.
It is the same cross boundary assertion.

Also sorry about the email format if it mess up in your side. I am typing
in the Gmail app and don't find a way to switch to plain text.

>

--000000000000cca18805d445584a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div class=3D"gmail_quote" dir=3D"auto"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">I think this is hitting a KASSERT, could you paste the text p=
rinted as<br>
part of the panic (not just he backtrace)?<br>
<br>
Sorry this is taking a bit of time to solve.<br>
<br>
Thanks!<br></blockquote></div><div dir=3D"auto">Sorry that I didn&#39;t mak=
e it clear in the first place.</div><div dir=3D"auto">It is the same cross =
boundary assertion.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Also=
 sorry about the email format if it mess up in your side. I am typing in th=
e Gmail app and don&#39;t find a way to switch to plain text.</div><div cla=
ss=3D"gmail_quote" dir=3D"auto"><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div>

--000000000000cca18805d445584a--


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 10:28:42 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 10:28:42 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252335.433344 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2WBj-0005IO-Hl; Wed, 29 Dec 2021 10:28:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252335.433344; Wed, 29 Dec 2021 10:28:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2WBj-0005IH-EE; Wed, 29 Dec 2021 10:28:07 +0000
Received: by outflank-mailman (input) for mailman id 252335;
 Wed, 29 Dec 2021 10:28:06 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ukf9=RO=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n2WBh-0005IB-Oa
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 10:28:06 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id ffe34fda-6891-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 11:28:03 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ffe34fda-6891-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640773683;
  h=date:from:to:cc:subject:message-id:references:
   in-reply-to:mime-version;
  bh=Eo9y1X/YY0BcVoJeuljiLhgdK0/kMwATBI8p7O6qwQw=;
  b=a9ymcU961SDBTRd682Zd/vFxs1EqlEet2VwM/9qhfn4QSFRiz+XZs/k4
   ZRymuTeki8lxA7ZPXIpzyB8K72ib76u+QPpkHW+WHkDAeD29OBqRbferi
   7yaU+la5SkSMX9bfo98/ukea+Hewh6RhB4tuRtD2j4SYm1CU1MUHQpRXY
   A=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: qmX8Rmd7GvKeMyiLgHd2IEGG983qIiBoIJ9Ltd6TO0FmSlj2jfpvpCCe8jw2ns6CUoIDAv10Ap
 UbU86Jv0yHbYQdh2pZyWmxJ9RLIhfcnICPl8ftId8kvxzLwgn9CZePrKejwJ8AwUU5voLwGYAp
 nHuWa6Fs5lV1Pc4io+Qp7Zb5M1d9MHLRvlqHwshGOFtsxi+Qtgqas2+UROEWE+KeRf4y6LkYzo
 D5UeSks2luItnlTSKLPVZVo5UMBWbPf5X992S1KffMGjPGgX/UdXb5Xq9XQZzBG8Qsqah0Wfxh
 WKhZKgdLJIvOloq6e24RLFxG
X-SBRS: 5.1
X-MesageID: 61346873
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:VhSdt6p/cT3oZ4xMLwe9ITRYwPBeBmLGYhIvgKrLsJaIsI4StFCzt
 garIBnUa/2PYDD0LY12YYni8EMGsJKEy9ZgSwQ9qCkzQSwSoJuZCYyVIHmrMnLJJKUvbq7GA
 +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2Ncx24LoW1nlV
 e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL
 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9
 DlCncOhQyQoP5KVo8peDBVYHXp7BYxPw5aSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9
 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFJkYtXx6iynQEN4tQIzZQrWM7thdtNs1rp4XRqqAN
 5VCAdZpRCvSOg99N3ozM8gRhcDy237nTS0EtHvA8MLb5ECMlVcsgdABKuH9atGMAMlYgEucj
 mbH5HjiRAEXMsSFzjiI+W7qgfXA9Qv1WZgfEbCk+/lwqECIy3YITgYRSEGwrPe+kEGzHdRSN
 yQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4TPwwywCM9fPvzUXGCmgKFTt5SdUdnZpjLdA17
 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnFdE1ZcizX3iMRq10+UEI4/eEKgpoCtcQwc1
 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVnl
 CJb8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeB82a5hVImCyO
 BO7VeZtCHl7ZiTCgUhfOdzZNijX5fK4SYSNug78MLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB
 HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm
 zueXuPXoyhivBrWPnOKrNVNdA9SdhDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+
 X+hHERfzTLCabfvcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T
 v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v
 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3
 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N
 /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU
 UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x
 fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
IronPort-HdrOrdr: A9a23:Z/6B6a8JQ07z/0OKY0huk+DWI+orL9Y04lQ7vn2ZKCY4TiX8ra
 uTdZsguiMc5Ax+ZJhDo7C90di7IE80nKQdieN9AV7IZniEhILHFvAG0aLShxHmBi3i5qp8+M
 5bAsxD4QTLfDpHsfo=
X-IronPort-AV: E=Sophos;i="5.88,245,1635220800"; 
   d="scan'208";a="61346873"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=jkuRlT3Oe7G3BBKu3hZUZG61W8C3JCTW7cLh1GPAbmy6sHnsRz25l99gOQe9Q13JO5XdS1kJ+XjK8C2znku4Ngd+jsAGw+0VQuGBLfXT45iGpFjgaQJKADyX7a0oDrWS1P6nT4X/PItPjhvT8RFftC0nms4suj0r1/aa0cR7Fm//RsgZPLKFgyjw4TZKL+ytAUSnJYUHoEN2MlNZ2u5hAnA7rFMGghCfOHOQ3wzAG89TsetgA9anFPGUHwM0FEeC+JH+XgnXtqw6UJpTUBi3ZOuKJywOiZnvMwEYJyCxgT891GC7nyRNXVT5fmbIx0U4ubkkSBGb1SXO6J/7Sgy1cA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Eo9y1X/YY0BcVoJeuljiLhgdK0/kMwATBI8p7O6qwQw=;
 b=WtGjk6CIq0V8kVyj2IfpPjoAuHy0XpFKXyz0HkYqOT349GYXKxxenutKBKBEIPlmuxd+n65yMrGYYo1WO5UD9uxik3qxRbmmGXAPRQJf59cHBdd6TTyQW7VHDfi+2tpvNj52CGm8AzXc2ZLaSXIyIAP+6R5phrXC4Phl73mkmAbGT4ZOAN8ROh2aRr3JpNA3Qq/UiryeGkdVQPzNu2cvgRbazoE3Qmqeo8UR7rF0zp1YDjy/BayHHCNknfKpqK35VlC83na7Z4ArGU1wIX+v0QNPvdbErmjp+LU6B1pvVjYvlAjlWxpt98XQxVs2tsGzwh5MsFv1678RRvzu1o89Hg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Eo9y1X/YY0BcVoJeuljiLhgdK0/kMwATBI8p7O6qwQw=;
 b=TJIEEGNgqEpY2bWKxQPQIS+SDIcYU2qw6Iufj6S4I5lndFIqqMYJEs90eJpFoZslsmu6t5Gjf6FVyx9FLW/bhX04H2q62zpRWi6HKRiZquk05optH6YkjlN3Gm3FGvdM1noQCIkfhgEv7LzRjHlVlpTGN1yfUsRJXqEToAz4SuM=
Date: Wed, 29 Dec 2021 11:27:50 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <Ycw4Jna5J2iQJyeM@Air-de-Roger>
References: <CAKhsbWZkSoM-N=HXfb_OeSGLqYMdtcxRph+=_vqp6tjHgikYVQ@mail.gmail.com>
 <YcInKtCNgA9v0k+c@Air-de-Roger>
 <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger>
 <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger>
 <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger>
 <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
X-ClientProxiedBy: MR1P264CA0135.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:501:51::12) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 815aa27f-fe76-4017-75f3-08d9cab5e17a
X-MS-TrafficTypeDiagnostic: DM6PR03MB4218:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB421806D7E31720900AC2CEAA8F449@DM6PR03MB4218.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /fYxNcHJfKKRqYx0pRZOjXx7OkjLuqIg+cq1Xoe3FYmTotliZnoBYtUEpObN88hddcwr/Avf1K8krA7+7URHg2g2HaBnI8MziTc8EKf0Xb8uwabaJxLYQwCTclV50dpXmsYRvLo2sAy1RUHX6F/dEmnUBY0jtoRrdLCnAniRtQxLZcw1LBB9UDOCGQBiI7wU+3OjcrEe40eZcVdo7UA+vxskkPuNodknJp5DFO4i4JCee+aIlLKTBWetmF8Drb/obPUgn9CvwoQwVzuLXqcwAE8uGBeSWiSH3czquNVPiYKPt+KsuKdLw33rIcM9u3+vY81rgkX1es/CbF2lyOcGEmoX/H1a+cAfX1qQ7cWg55BzlMOz1S4xYidEQT4LbH5FztsNk1IQ60J1PFd/kTuw9lR09jDXK8pNA4j8bJVoZb3m9ERQxnVFSlfTMnrEohWv138krDPKcmYl8N3as9YYuBmpSkXNRuh28EC1LBdUhDc1Z4wUBXz9ZPzPD/oNPCid3Gqz9cNkrMo10VxaF8Zyqk7NsI5PbGolMiNZxp7FnZE7FencKyBCwiBcJVC6XF4ypz20pQYqGfHuCDh4JfW+tPHKgRVPp0Y7w/uO/E82S0mrs72hohPZ2k/rn4MqLpCpzkRiw4R1xAEmCQxARmg1uA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(6916009)(6512007)(6666004)(9686003)(2906002)(66476007)(82960400001)(38100700002)(83380400001)(86362001)(316002)(5660300002)(85182001)(6486002)(4744005)(4326008)(508600001)(26005)(186003)(8676002)(33716001)(6506007)(8936002)(66556008)(66946007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlZkcjBmM2Q4RWc0OFdnQzk4SzVISkVjYjJDTlhjamluU25NK2RBaE5YcUJQ?=
 =?utf-8?B?a3pPK1p2S1N4MllaZmVpZ1JQQVI1SGl6SzFwVjhzY1krV1QzWkQvSUNmQ2c2?=
 =?utf-8?B?R01FWnA3UFVMSDV3LzVRRklaNkpaNFJUckZ5QU5LdUVmNnV1NHl3aDFnVEQw?=
 =?utf-8?B?VzdHUys1bUp5NlpGblRrMEd2NFc0MUsrU2QrWVRnMzNvSXphTVJtOE1lN2s2?=
 =?utf-8?B?OTF6UFZkY0RYM0hGY0grZmFNbzNqSlRpVkNZT0RRWUhBcVVxbTdjdXRSRldn?=
 =?utf-8?B?ZWhqRXgzd3h3MVpieW10LzVSMWNRY2owcXkxQVhIbGp3cFBVTkZ3VzNTeExr?=
 =?utf-8?B?TVZKZGd2OWRHck9vbVFYekY0RW0rK0Q4RlN3cjA2YlpZUC80UDNyWGpiMDRi?=
 =?utf-8?B?Sk5iYzE0UHZmWkJvM1c4MWEvbEhQeVR5SHdmTXRscHhEWktmQlJjbTJxbWh0?=
 =?utf-8?B?QThFSU1ES3RudHJ5RzRMd08rcWJFbElEdzJWSWxDM3BQLzV4cFczL21JOWdF?=
 =?utf-8?B?cmRxQlZKTndUcFJqTDBqTnpWcThSTlJxTlYxdG1XbTNwaWYzZDd1Y3lMM05p?=
 =?utf-8?B?T0oycFRUTTlEL1l1YXUzZ0FzNUV1U2gybEpsVzVhK1k3NHVOTmtSQlNHVXJa?=
 =?utf-8?B?Z1RhbkxCUUZBU1VXSzBMcUN2Wm1WdnZDc093bm1qenNNRERjMlROZjZsRnhN?=
 =?utf-8?B?bG9vRXA2a0ZYNjY1Tkc2RUN1U1lIOTZNN1d4QTJCb3pXQnptZWZwZDVuWWp2?=
 =?utf-8?B?NU5GQ3NrM3Y5NEllTkFXekYyVjJ0a2lZOWM3dFFuSTVxZTBLUHRhUklmMXZr?=
 =?utf-8?B?ZmVUTCttZlpMZmVjV0hsc0srYXJhdHVsYmFySXNsaWt1UDFLRzAvYmJ4ZUJv?=
 =?utf-8?B?d2d5NWJNYnFkMXBKNmpETFh5ekFwWVVTQm92WjJ1NVZSRElSbTRmdjlsWmYx?=
 =?utf-8?B?RENKakUrYWgybCtRcXRuWWdaaU9ESXMvSVQ5ZE1EOUkxTlQ2R0lkVnN0OUtm?=
 =?utf-8?B?RnduTHJ2YXhac2RIaU1sU1JvZ3hTaUhGVFA3N1RIOVhQalVRTU5vUUVrbFpO?=
 =?utf-8?B?ZU16ZVFjaklQaXRiNkhCYlBXdHJkUTNGc0pQMTd4ZFFQOG5sU3VpbU4xVjJn?=
 =?utf-8?B?ZlYxMTBnOXFuVUZzSis3UFYrc1BXK3lCblgxTUNKYlVES25PTHNpZXoyemhJ?=
 =?utf-8?B?TDZUb3hwUlVKZGFaSTZaVTNYdW9wcVp6amF3WTVTQzRwQjNNWnFmU1FCaUNJ?=
 =?utf-8?B?NXphbFNQK2pza1U5THhpUFduWXBZZ2ptd2ZpUmhFM3d6UUFsMUhndVBra1dY?=
 =?utf-8?B?RVhEaVRSRElmL3JDOGx5RkhBWHZqT0V6YU11YWI3alRkbHdhZUtsdmtETWlG?=
 =?utf-8?B?ZXM0MEdiV1pqU2ZYQ1VGMTY4VGtGWUlkaXVWSXFyRUJScEg0TFdrQTZBTnFW?=
 =?utf-8?B?bWczWk9ZdHI0TUE5YTA3R3h0MC9hTnF0UDRDVU9CY2hCaEd6dEI2elVSTk0y?=
 =?utf-8?B?RVJTRjdkekV1YVhFc2lKZFZxMEx6WFdNZTRielEvblpUZkpleWdZMktUdVNL?=
 =?utf-8?B?RnMxQ1lnQlJSZkg5TDg5bUxGWXl6aXE4cC9kRkxuWi8rRVpPc1cya0JHOVRH?=
 =?utf-8?B?K000b3lVdFBaY0xpNjV2dVZ4Q2FzRmo5WEpVQVhLV1FibzdJM2ZwVjljWVVk?=
 =?utf-8?B?YnA3QUJROGY5YTk3Z21xZGdON1M0RzJxeDdRc2ovTDhtc3FKeUlnWWdDdnM3?=
 =?utf-8?B?anJPMXNiZkJ5WWg0WHhIazN2aFJ6MllrNnd4MDMwYmdxVFVZL3UxZHFGOXkv?=
 =?utf-8?B?OStnM3RLb0lQTXJsS1pRek80cDk2cG81SzVqb0xoaDBvbGxVeGNTZGxobGdO?=
 =?utf-8?B?NnlxVUcyLzcxVXZUK1A1MFEyRytEWWcySUorWGpvRlhIQ1V4OHArL1E0bmhv?=
 =?utf-8?B?MHk2cHJVK2xpbExQSU9odExwaFpjOGxsTmNXSGpSanZ4RXYyVjUwd0Z5cy9k?=
 =?utf-8?B?R285d2RPS0Ftc0FMUFJMZFh4dEpyZVNzWmFZdW5UZGpCcXRYK1RzL3RqNWk4?=
 =?utf-8?B?d3J4L3U3eFg1R2FFdmFGV25PTVJ3d1p4aVVRS1ZmV3dJeW03TlZuWW9lTTJW?=
 =?utf-8?B?Y2RpU0ZHVGtMU1JyMjQraUJSZHlZZVBZOFBWbUhuVDZjcTNndXIwL1lSbUVG?=
 =?utf-8?Q?TrrEoEvvKkkjkx03LhPgUCU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 815aa27f-fe76-4017-75f3-08d9cab5e17a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 10:27:57.3081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tNLIx16nCtBugY2Xl3mw0vwwL66tYwUv4JU4DHx48V6s31IxRhlLO+Ej/DSGCBldeKv0lMOi54+J7XJ6C93Hqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4218
X-OriginatorOrg: citrix.com

On Wed, Dec 29, 2021 at 05:13:00PM +0800, G.R. wrote:
> >
> > I think this is hitting a KASSERT, could you paste the text printed as
> > part of the panic (not just he backtrace)?
> >
> > Sorry this is taking a bit of time to solve.
> >
> > Thanks!
> >
> Sorry that I didn't make it clear in the first place.
> It is the same cross boundary assertion.

I see. After looking at the code it seems like sglist will coalesce
contiguous physical ranges without taking page boundaries into
account, which is not suitable for our purpose here. I guess I will
either have to modify sglist, or switch to using bus_dma. The main
problem with using bus_dma is that it will require bigger changes to
netfront I think.

Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 11:53:36 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 11:53:36 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252342.433355 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2XW3-0005XV-U7; Wed, 29 Dec 2021 11:53:11 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252342.433355; Wed, 29 Dec 2021 11:53:11 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2XW3-0005XO-RB; Wed, 29 Dec 2021 11:53:11 +0000
Received: by outflank-mailman (input) for mailman id 252342;
 Wed, 29 Dec 2021 11:53:10 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2XW2-0005XE-8Z; Wed, 29 Dec 2021 11:53:10 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2XW2-0006zz-5t; Wed, 29 Dec 2021 11:53:10 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2XW1-0006wX-U1; Wed, 29 Dec 2021 11:53:09 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2XW1-0002Ov-TW; Wed, 29 Dec 2021 11:53:09 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=1E5HPVNrBdaTa0VhE4Z//MJNJdl2Xl3cRarpJAbP8/A=; b=bsZs78cW/eQEtYcnC72DODXQDR
	Ae2v8xiikAqOkH9sTx6wjoVlQaiYlCyHGr2an+2CvzKEbuDJcK3XDnjP2Rfb8NmyBhHFzSrdFy3Nf
	YI/BxB5ILFCcgPQSb19l8WpJ4KZtmNeETexQ1aflbgaajwnokmXXnQR1tXQCbr2zOpTQ=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167556-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167556: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 11:53:09 +0000

flight 167556 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167556/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  537 days
Failing since        151818  2020-07-11 04:18:52 Z  536 days  518 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    4 days    5 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 16:11:40 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 16:11:40 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252354.433367 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2bXa-00040W-P3; Wed, 29 Dec 2021 16:11:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252354.433367; Wed, 29 Dec 2021 16:11:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2bXa-00040P-Lz; Wed, 29 Dec 2021 16:11:02 +0000
Received: by outflank-mailman (input) for mailman id 252354;
 Wed, 29 Dec 2021 16:11:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2bXY-00040F-On; Wed, 29 Dec 2021 16:11:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2bXY-0003XJ-KJ; Wed, 29 Dec 2021 16:11:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2bXY-0002Zn-8y; Wed, 29 Dec 2021 16:11:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2bXY-00050u-8X; Wed, 29 Dec 2021 16:11:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=uAYLw5VLPyNI1Lk9hsnQale/H0yA9fnlxp9YAkdUrGA=; b=5IwGkbRtRfw0gXteHnllKdOz+m
	/gdmXXNajnidYJeoqidvbb4jiJjoKdiTChImgWmz7LxsFROccsYydXEjBfqh4DAoucBC5tL9chmgo
	NatEI47ZAQnMl+ws1iSTaPPrdINfCENFdwvnD7vuR7bzocS5UI/AjiFc9CpUkg9mUYfs=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167554-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167554: trouble: broken/fail/pass
X-Osstest-Failures:
    xen-unstable:test-armhf-armhf-libvirt:<job status>:broken:regression
    xen-unstable:test-armhf-armhf-libvirt-raw:<job status>:broken:regression
    xen-unstable:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug
    xen-unstable:test-armhf-armhf-libvirt-raw:host-install(5):broken:heisenbug
    xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 16:11:00 +0000

flight 167554 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167554/

Failures and problems with tests :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-libvirt        <job status>                 broken
 test-armhf-armhf-libvirt-raw    <job status>                 broken

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt      5 host-install(5)          broken pass in 167550
 test-armhf-armhf-libvirt-raw  5 host-install(5)          broken pass in 167550
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10     fail pass in 167550
 test-arm64-arm64-xl-vhd      12 debian-di-install          fail pass in 167550

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 167550 like 167545
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 167550 like 167545
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 167550 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 167550 never pass
 test-armhf-armhf-libvirt    15 migrate-support-check fail in 167550 never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 167550 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167550
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167550
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167550
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167550
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167550
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167550
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167550
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167550
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167550
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167550
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167554  2021-12-29 01:51:52 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     broken  
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 broken  
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-libvirt broken
broken-job test-armhf-armhf-libvirt-raw broken
broken-step test-armhf-armhf-libvirt host-install(5)
broken-step test-armhf-armhf-libvirt-raw host-install(5)

Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:15:11 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:15:11 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252363.433377 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cX6-0001Q5-I5; Wed, 29 Dec 2021 17:14:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252363.433377; Wed, 29 Dec 2021 17:14:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cX6-0001Py-F8; Wed, 29 Dec 2021 17:14:36 +0000
Received: by outflank-mailman (input) for mailman id 252363;
 Wed, 29 Dec 2021 17:14:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2cX5-0001Po-OC; Wed, 29 Dec 2021 17:14:35 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2cX5-0004bq-Ls; Wed, 29 Dec 2021 17:14:35 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2cX5-0004Wv-8k; Wed, 29 Dec 2021 17:14:35 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2cX5-0007A2-8I; Wed, 29 Dec 2021 17:14:35 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=zeWCcBOc4yVHRc+voyrAUHjPdNMAr4Gn0lY3+xceJbU=; b=rDtNra3z/0NTEN7W7T9h9uuJSF
	IAFPOsXrOaah7EFWC9xEXKfCmlQaUUB0yYzkQ7rcTFJ3X7+9gpzVzQkZB4Fxywe2wqAzIxkxoKwop
	Qa/nj5lvHyobPwvecNmRdtTEik5woCvnY0bojXAuKg/4jOl4fIQmOsbOj5RDKht1s8R8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167559-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [ovmf test] 167559: all pass - PUSHED
X-Osstest-Versions-This:
    ovmf=c095122d4b5f3152417cd97dabecfe31cc3b6508
X-Osstest-Versions-That:
    ovmf=7935be0fbd8f47266e5972f4cba1a1e58505061a
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 17:14:35 +0000

flight 167559 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167559/

Perfect :-)
All tests in this flight passed as required
version targeted for testing:
 ovmf                 c095122d4b5f3152417cd97dabecfe31cc3b6508
baseline version:
 ovmf                 7935be0fbd8f47266e5972f4cba1a1e58505061a

Last test of basis   167555  2021-12-29 02:10:20 Z    0 days
Testing same since   167559  2021-12-29 14:11:40 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Damian Bassa <damian.bassa@intel.com>
  Ray Ni <ray.ni@intel.com>

jobs:
 build-amd64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/osstest/ovmf.git
   7935be0fbd..c095122d4b  c095122d4b5f3152417cd97dabecfe31cc3b6508 -> xen-tested-master


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:15:55 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:15:55 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252370.433389 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cYM-0001y0-UI; Wed, 29 Dec 2021 17:15:54 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252370.433389; Wed, 29 Dec 2021 17:15:54 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cYM-0001xt-R3; Wed, 29 Dec 2021 17:15:54 +0000
Received: by outflank-mailman (input) for mailman id 252370;
 Wed, 29 Dec 2021 17:15:53 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KsxB=RO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1n2cYL-0001xl-JY
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 17:15:53 +0000
Received: from EUR02-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur02on061b.outbound.protection.outlook.com
 [2a01:111:f400:fe05::61b])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id f7edfcec-68ca-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 18:15:51 +0100 (CET)
Received: from AS9PR05CA0028.eurprd05.prod.outlook.com (2603:10a6:20b:488::26)
 by DB7PR08MB3020.eurprd08.prod.outlook.com (2603:10a6:5:1d::10) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:15:46 +0000
Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:488:cafe::c0) by AS9PR05CA0028.outlook.office365.com
 (2603:10a6:20b:488::26) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14 via Frontend
 Transport; Wed, 29 Dec 2021 17:15:46 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4844.14 via Frontend Transport; Wed, 29 Dec 2021 17:15:45 +0000
Received: ("Tessian outbound c61f076cbd30:v110");
 Wed, 29 Dec 2021 17:15:45 +0000
Received: from 4720f6a14644.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 2AD511D6-0175-4273-B776-837F44E95C20.1; 
 Wed, 29 Dec 2021 17:15:39 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4720f6a14644.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 17:15:39 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR0802MB2336.eurprd08.prod.outlook.com
 (2603:10a6:800:9c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:15:34 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4%3]) with mapi id 15.20.4823.024; Wed, 29 Dec 2021
 17:15:34 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: f7edfcec-68ca-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UF5kjH+vMSs7Po8QNVvxtHRgsXl82Xb5byTtYYQCYA8=;
 b=hLHYSAHpDgh9UADiGOCHR9ROrglTQ2luIhyWOdYQfDAe6x39Qj3TBQk6o/EWjS+qwW9Psb5mojPze2dESbRVlFP8gdN8ViQYp5PlQ0lr4ipMuUZ+NtH1FYAMXu6p3HIQs6vFKkRg2WmnUNEtA3yM5ZpSA0bPtzjhhsgqCr//mxc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: f630f895ac8c22ab
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=RtzA8rQSaqFfnKtKVknjEwwrnQg7wc87Vm5tJYAwmPxYR87gq1pbpI/YdlimCNs/X6SYZP/GPOeAw/PSaEbB77I3ZK8bk+oDJpD94MvoaLnUpZZcwhbQv0Q3UEksCEc9a0dJgM8vYTbC02VhkS9+MzeVA3tByv9FDGm9D0sYbcelhQzhz+E8PZRgEFVT+yyvi8t5XTrsNCmW2RJfQy7LBln+pvUx4uINtiQRgcgyX11zAc5Xd7omuC727OXXO15JCMVRTN4xdSbrBWo+5ITfhzdDqU4lWWBqnJXI0vkK6ctQocEGU6yNdrRjJGZvXQ4FTAHpa9n/6fiTY28eOL/zeQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=UF5kjH+vMSs7Po8QNVvxtHRgsXl82Xb5byTtYYQCYA8=;
 b=AzcOuPbTn7oy62lhg2ukcQ+FUAJX8PZOwipBkz7gS0A2aaEFoVyyGUjkxMGgujGrWTF3BvZVPQy+K9kChoBngu9rtS8U/CzIiaDOS1QnPBBT3MRNg1ETd3Dy6mmoQ6mwgySq4Fb3ziaoiyBeXa8EFFkWOe/feF/DAhf2xqmu7FCdXYIuoAWJCKD4Es6m9ObVCvRGg/iTiqMS9xK3+9Tq8g1UK58Quklyd1x972dO8Vcp1nVxR65PAh76GWhTv8j7xI+k/MX+PI0elYQJoqOsl6c0IwT7xzYJitTOBPDCt0ycmS1PXteR1JvKVaTxksjG25ZKmPu+P4w5MYlhhN0Udg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=UF5kjH+vMSs7Po8QNVvxtHRgsXl82Xb5byTtYYQCYA8=;
 b=hLHYSAHpDgh9UADiGOCHR9ROrglTQ2luIhyWOdYQfDAe6x39Qj3TBQk6o/EWjS+qwW9Psb5mojPze2dESbRVlFP8gdN8ViQYp5PlQ0lr4ipMuUZ+NtH1FYAMXu6p3HIQs6vFKkRg2WmnUNEtA3yM5ZpSA0bPtzjhhsgqCr//mxc=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 1/5] tools/libxl: Mark pointer args of many functions
 constant
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <80dd561339dbe54f1ed2c2302ace389e87d445fe.1640590794.git.ehem+xen@m5p.com>
Date: Wed, 29 Dec 2021 17:15:25 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>,
 Juergen Gross <jgross@suse.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E320F70F-6BE7-43E9-822D-F175862D0005@arm.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <80dd561339dbe54f1ed2c2302ace389e87d445fe.1640590794.git.ehem+xen@m5p.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0489.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:1ab::8) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 33bc3186-e232-42d1-dca4-08d9caeeda1e
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2336:EE_|VE1EUR03FT029:EE_|DB7PR08MB3020:EE_
X-Microsoft-Antispam-PRVS:
	<DB7PR08MB3020B818270548B260AAA1C4E4449@DB7PR08MB3020.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:1360;OLM:1360;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 42u7uaJNRb4DS3S2LcykdVJ5cbISbS38zA7wbnvjzlxOvciTgJEzk7q0NeXcFIBNKp2HQ3x4z3c/bNf3D9wzk1uS9lCpejInxGdCqc+OKmiWI1GoziZ1qxeUDnNUk3i30+iR2UVbKtSN7KUgOS7wxvbfI06rWH+jC1XwqUB2eVsi2O1zur23TWb0VPuFSx9KV3hiWEgsH91WjsulGstKqSoGsOQiqSa7E2BNB+FFBqiEiKIw5navEY3dEPMdEHktxp7a/0a2GzCqp3/yzkQLq7Qcpr3cccbFouEf1Pp6gxre6QnV+qRVvzUFtpBJmvwVy0ALaFngCSBlRREyRW9ZbZsxZKON0M9BPkh8aHemWCwKV31D2/3koL7d17rCal186pSMBzDGUZDvqQaC03xplKZTFzZbBdmWZ44x3kCKhExWvTzVW1n9uciW8X4y3nz1YijuOM4lzSVvspN6AOfhMVapgZogeS+WDSGS874ghx0mr0u8M8S+lSCMVtYEF8sebkYXajwViuojnS2aHAk7Im+WZniYMBsl8orSxCQUtRzeoInPRjoyioaddrSzNKXSZZmhVawADoqkYYJxRbu8BAjxPJifZQfGR+Mvyme4lmB2mamyFqjGr+uxJacWKD0pZ0/XG8JzgXstW0kHdZ6Tl/YWmPWMRPkJXVpxjXuCFkf69tSAFIwMb+XeOmBSSGXB1K3p4af62sVOjUmXwP2uTzmbSh+2UeMVWwI+bDFFK7E=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(36756003)(6506007)(53546011)(66476007)(54906003)(5660300002)(186003)(66946007)(44832011)(66556008)(26005)(2616005)(33656002)(38350700002)(38100700002)(86362001)(316002)(8676002)(6512007)(83380400001)(52116002)(8936002)(6666004)(2906002)(30864003)(4326008)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	d4df48a6-8ed1-424c-7ca1-08d9caeed329
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YfVFQzpsPfyyN9gWZRmllpbxtS1kcFPPBPRtYRQ5IfuP2iD/O59sHbDM6xSsDhKkFU98v5P2oUy1e5hqOTqIhswB9YlHNUVZz/WL/wK/I/MGXsbSDKeivyYxGWpY7Q44kbbA02HqsGnj7NYjA0sNWGJVB0odQBV3mXMZtaaM5cRgAeys8Ci0ab1sVPBhcBtOe0SlvouxguzN4qF9OekungKobSpBzsl2UQ0UhIeT4Fu6HxQKIic63UvAqtm5bcPW4+dt+iLd+lghzxzdf+YbMDGfH/YrcvSjqGzgSRo5++tq9wpkaQUyghmBnbtYeNaihKM4HwsXQKGdS8yw/CRIZ7V0ugQmOyxgs1nr1YbVzQLlwlMF/eG4greGB6DUWLGcTCDjzI18qkmsuboWAUdSXghkLGnMejrhG//hPJtwJSf43yc7tXzDh0HKUFwxYdVgH07xncJrx/trHKqhrCOiCDiUCv8V7ygrYoozqYn/aBtBrfXOlyDxUnE307iRu6Y0RX0s46ugiIpXHz0q+gBaotYDBMvtCcswlIE8SW6xcsgS6JR5Ros10e6BjtT4EtdsPmKwaVdfKsqOruTfoN7V5QRTfHY4Q/rCQfafU5kAPElw+5EDck4Zi4lkzu3TB2dVwinf3PUYPtKi7KLw7IGvFRS6QkGhW7iONd9ORca2OAWBxT152epVOFAh1wZzJPPmmHhp7YYVZK3iywzQU84jTg==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(508600001)(53546011)(26005)(107886003)(6506007)(8936002)(70206006)(316002)(54906003)(336012)(4326008)(6512007)(6862004)(186003)(81166007)(36756003)(83380400001)(82310400004)(47076005)(2616005)(44832011)(86362001)(6486002)(2906002)(30864003)(8676002)(70586007)(36860700001)(6666004)(33656002)(5660300002)(356005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 17:15:45.8681
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 33bc3186-e232-42d1-dca4-08d9caeeda1e
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3020



> On 18 Dec 2020, at 21:37, Elliott Mitchell <ehem+xen@m5p.com> wrote:
>=20
> Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
> examining the pointed to thing, not modifying it.  This potentially
> results in higher-performance output.  This also allows spreading
> constants further, allowing more checking and security.

Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

>=20
> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> tools/include/libxl_json.h        | 22 ++++++++++++----------
> tools/libs/light/gentypes.py      |  8 ++++----
> tools/libs/light/libxl_cpuid.c    |  2 +-
> tools/libs/light/libxl_internal.c |  4 ++--
> tools/libs/light/libxl_internal.h | 18 +++++++++---------
> tools/libs/light/libxl_json.c     | 18 ++++++++++--------
> tools/libs/light/libxl_nocpuid.c  |  4 ++--
> 7 files changed, 40 insertions(+), 36 deletions(-)
>=20
> diff --git a/tools/include/libxl_json.h b/tools/include/libxl_json.h
> index 260783bfde..63f0e58fe1 100644
> --- a/tools/include/libxl_json.h
> +++ b/tools/include/libxl_json.h
> @@ -23,17 +23,19 @@
> #endif
>=20
> yajl_gen_status libxl__uint64_gen_json(yajl_gen hand, uint64_t val);
> -yajl_gen_status libxl_defbool_gen_json(yajl_gen hand, libxl_defbool *p);
> -yajl_gen_status libxl_uuid_gen_json(yajl_gen hand, libxl_uuid *p);
> -yajl_gen_status libxl_mac_gen_json(yajl_gen hand, libxl_mac *p);
> -yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand, libxl_bitmap *p);
> +yajl_gen_status libxl_defbool_gen_json(yajl_gen hand, const libxl_defboo=
l *p);
> +yajl_gen_status libxl_uuid_gen_json(yajl_gen hand, const libxl_uuid *p);
> +yajl_gen_status libxl_mac_gen_json(yajl_gen hand, const libxl_mac *p);
> +yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand, const libxl_bitmap =
*p);
> yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> -                                                 libxl_cpuid_policy_list=
 *p);
> -yajl_gen_status libxl_string_list_gen_json(yajl_gen hand, libxl_string_l=
ist *p);
> +                                                 const libxl_cpuid_polic=
y_list *p);
> +yajl_gen_status libxl_string_list_gen_json(yajl_gen hand,
> +                                           const libxl_string_list *p);
> yajl_gen_status libxl_key_value_list_gen_json(yajl_gen hand,
> -                                              libxl_key_value_list *p);
> -yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand, libxl_hwcap *p);
> -yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand, libxl_ms_vm_ge=
nid *p);
> +                                              const libxl_key_value_list=
 *p);
> +yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand, const libxl_hwcap *p=
);
> +yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand,
> +                                           const libxl_ms_vm_genid *p);
>=20
> #include <_libxl_types_json.h>
>=20
> @@ -91,6 +93,6 @@ static inline yajl_gen libxl_yajl_gen_alloc(const yajl_=
alloc_funcs *allocFuncs)
> #endif /* !HAVE_YAJL_V2 */
>=20
> yajl_gen_status libxl_domain_config_gen_json(yajl_gen hand,
> -                                             libxl_domain_config *p);
> +                                             const libxl_domain_config *=
p);
>=20
> #endif /* LIBXL_JSON_H */
> diff --git a/tools/libs/light/gentypes.py b/tools/libs/light/gentypes.py
> index 9a45e45acc..7e02a5366f 100644
> --- a/tools/libs/light/gentypes.py
> +++ b/tools/libs/light/gentypes.py
> @@ -632,7 +632,7 @@ if __name__ =3D=3D '__main__':
>                                                ty.make_arg("p"),
>                                                ku.keyvar.type.make_arg(ku=
.keyvar.name)))
>         if ty.json_gen_fn is not None:
> -            f.write("%schar *%s_to_json(libxl_ctx *ctx, %s);\n" % (ty.hi=
dden(), ty.typename, ty.make_arg("p")))
> +            f.write("%schar *%s_to_json(libxl_ctx *ctx, const %s);\n" % =
(ty.hidden(), ty.typename, ty.make_arg("p")))
>         if ty.json_parse_fn is not None:
>             f.write("%sint %s_from_json(libxl_ctx *ctx, %s, const char *s=
);\n" % (ty.hidden(), ty.typename, ty.make_arg("p", passby=3Didl.PASS_BY_RE=
FERENCE)))
>         if isinstance(ty, idl.Enumeration):
> @@ -662,7 +662,7 @@ if __name__ =3D=3D '__main__':
> """ % (header_json_define, header_json_define, " ".join(sys.argv)))
>=20
>     for ty in [ty for ty in types if ty.json_gen_fn is not None]:
> -        f.write("%syajl_gen_status %s_gen_json(yajl_gen hand, %s);\n" % =
(ty.hidden(), ty.typename, ty.make_arg("p", passby=3Didl.PASS_BY_REFERENCE)=
))
> +        f.write("%syajl_gen_status %s_gen_json(yajl_gen hand, const %s);=
\n" % (ty.hidden(), ty.typename, ty.make_arg("p", passby=3Didl.PASS_BY_REFE=
RENCE)))
>=20
>     f.write("\n")
>     f.write("""#endif /* %s */\n""" % header_json_define)
> @@ -766,13 +766,13 @@ if __name__ =3D=3D '__main__':
>         f.write("\n")
>=20
>     for ty in [t for t in types if t.json_gen_fn is not None]:
> -        f.write("yajl_gen_status %s_gen_json(yajl_gen hand, %s)\n" % (ty=
.typename, ty.make_arg("p", passby=3Didl.PASS_BY_REFERENCE)))
> +        f.write("yajl_gen_status %s_gen_json(yajl_gen hand, const %s)\n"=
 % (ty.typename, ty.make_arg("p", passby=3Didl.PASS_BY_REFERENCE)))
>         f.write("{\n")
>         f.write(libxl_C_type_gen_json(ty, "p"))
>         f.write("}\n")
>         f.write("\n")
>=20
> -        f.write("char *%s_to_json(libxl_ctx *ctx, %s)\n" % (ty.typename,=
 ty.make_arg("p")))
> +        f.write("char *%s_to_json(libxl_ctx *ctx, const %s)\n" % (ty.typ=
ename, ty.make_arg("p")))
>         f.write("{\n")
>         f.write(libxl_C_type_to_json(ty, "p"))
>         f.write("}\n")
> diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpui=
d.c
> index e1acf6648d..b076d7f4a3 100644
> --- a/tools/libs/light/libxl_cpuid.c
> +++ b/tools/libs/light/libxl_cpuid.c
> @@ -14,7 +14,7 @@
>=20
> #include "libxl_internal.h"
>=20
> -int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl)
> +int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl)
> {
>     return !libxl_cpuid_policy_list_length(pl);
> }
> diff --git a/tools/libs/light/libxl_internal.c b/tools/libs/light/libxl_i=
nternal.c
> index 86556b6113..da2dbd67ad 100644
> --- a/tools/libs/light/libxl_internal.c
> +++ b/tools/libs/light/libxl_internal.c
> @@ -333,7 +333,7 @@ _hidden int libxl__parse_mac(const char *s, libxl_mac=
 mac)
>     return 0;
> }
>=20
> -_hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b)
> +_hidden int libxl__compare_macs(const libxl_mac *a, const libxl_mac *b)
> {
>     int i;
>=20
> @@ -345,7 +345,7 @@ _hidden int libxl__compare_macs(libxl_mac *a, libxl_m=
ac *b)
>     return 0;
> }
>=20
> -_hidden int libxl__mac_is_default(libxl_mac *mac)
> +_hidden int libxl__mac_is_default(const libxl_mac *mac)
> {
>     return (!(*mac)[0] && !(*mac)[1] && !(*mac)[2] &&
>             !(*mac)[3] && !(*mac)[4] && !(*mac)[5]);
> diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_i=
nternal.h
> index 37d5c27756..117a98acab 100644
> --- a/tools/libs/light/libxl_internal.h
> +++ b/tools/libs/light/libxl_internal.h
> @@ -2080,9 +2080,9 @@ struct libxl__xen_console_reader {
> /* parse the string @s as a sequence of 6 colon separated bytes in to @ma=
c */
> _hidden int libxl__parse_mac(const char *s, libxl_mac mac);
> /* compare mac address @a and @b. 0 if the same, -ve if a<b and +ve if a>=
b */
> -_hidden int libxl__compare_macs(libxl_mac *a, libxl_mac *b);
> +_hidden int libxl__compare_macs(const libxl_mac *a, const libxl_mac *b);
> /* return true if mac address is all zero (the default value) */
> -_hidden int libxl__mac_is_default(libxl_mac *mac);
> +_hidden int libxl__mac_is_default(const libxl_mac *mac);
> /* init a recursive mutex */
> _hidden int libxl__init_recursive_mutex(libxl_ctx *ctx, pthread_mutex_t *=
lock);
>=20
> @@ -4580,7 +4580,7 @@ _hidden int libxl__ms_vm_genid_set(libxl__gc *gc, u=
int32_t domid,
> #define LIBXL__DEFBOOL_STR_DEFAULT "<default>"
> #define LIBXL__DEFBOOL_STR_FALSE   "False"
> #define LIBXL__DEFBOOL_STR_TRUE    "True"
> -static inline int libxl__defbool_is_default(libxl_defbool *db)
> +static inline int libxl__defbool_is_default(const libxl_defbool *db)
> {
>     return !db->val;
> }
> @@ -4675,22 +4675,22 @@ int libxl__random_bytes(libxl__gc *gc, uint8_t *b=
uf, size_t len);
> #include "_libxl_types_internal_private.h"
>=20
> /* This always return false, there's no "default value" for hw cap */
> -static inline int libxl__hwcap_is_default(libxl_hwcap *hwcap)
> +static inline int libxl__hwcap_is_default(const libxl_hwcap *hwcap)
> {
>     return 0;
> }
>=20
> -static inline int libxl__string_list_is_empty(libxl_string_list *psl)
> +static inline int libxl__string_list_is_empty(const libxl_string_list *p=
sl)
> {
>     return !libxl_string_list_length(psl);
> }
>=20
> -static inline int libxl__key_value_list_is_empty(libxl_key_value_list *p=
kvl)
> +static inline int libxl__key_value_list_is_empty(const libxl_key_value_l=
ist *pkvl)
> {
>     return !libxl_key_value_list_length(pkvl);
> }
>=20
> -int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl);
> +int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl);
>=20
> /* Portability note: a proper flock(2) implementation is required */
> typedef struct {
> @@ -4821,12 +4821,12 @@ void* libxl__device_list(libxl__gc *gc, const lib=
xl__device_type *dt,
> void libxl__device_list_free(const libxl__device_type *dt,
>                              void *list, int num);
>=20
> -static inline bool libxl__timer_mode_is_default(libxl_timer_mode *tm)
> +static inline bool libxl__timer_mode_is_default(const libxl_timer_mode *=
tm)
> {
>     return *tm =3D=3D LIBXL_TIMER_MODE_DEFAULT;
> }
>=20
> -static inline bool libxl__string_is_default(char **s)
> +static inline bool libxl__string_is_default(char *const *s)
> {
>     return *s =3D=3D NULL;
> }
> diff --git a/tools/libs/light/libxl_json.c b/tools/libs/light/libxl_json.=
c
> index 9b8ef2cab9..88e81f9905 100644
> --- a/tools/libs/light/libxl_json.c
> +++ b/tools/libs/light/libxl_json.c
> @@ -95,7 +95,7 @@ yajl_gen_status libxl__yajl_gen_enum(yajl_gen hand, con=
st char *str)
>  * YAJL generators for builtin libxl types.
>  */
> yajl_gen_status libxl_defbool_gen_json(yajl_gen hand,
> -                                       libxl_defbool *db)
> +                                       const libxl_defbool *db)
> {
>     return libxl__yajl_gen_asciiz(hand, libxl_defbool_to_string(*db));
> }
> @@ -137,7 +137,7 @@ int libxl__bool_parse_json(libxl__gc *gc, const libxl=
__json_object *o,
> }
>=20
> yajl_gen_status libxl_uuid_gen_json(yajl_gen hand,
> -                                    libxl_uuid *uuid)
> +                                    const libxl_uuid *uuid)
> {
>     char buf[LIBXL_UUID_FMTLEN+1];
>     snprintf(buf, sizeof(buf), LIBXL_UUID_FMT, LIBXL_UUID_BYTES((*uuid)))=
;
> @@ -154,7 +154,7 @@ int libxl__uuid_parse_json(libxl__gc *gc, const libxl=
__json_object *o,
> }
>=20
> yajl_gen_status libxl_bitmap_gen_json(yajl_gen hand,
> -                                      libxl_bitmap *bitmap)
> +                                      const libxl_bitmap *bitmap)
> {
>     yajl_gen_status s;
>     int i;
> @@ -208,7 +208,7 @@ int libxl__bitmap_parse_json(libxl__gc *gc, const lib=
xl__json_object *o,
> }
>=20
> yajl_gen_status libxl_key_value_list_gen_json(yajl_gen hand,
> -                                              libxl_key_value_list *pkvl=
)
> +                                              const libxl_key_value_list=
 *pkvl)
> {
>     libxl_key_value_list kvl =3D *pkvl;
>     yajl_gen_status s;
> @@ -269,7 +269,8 @@ int libxl__key_value_list_parse_json(libxl__gc *gc, c=
onst libxl__json_object *o,
>     return 0;
> }
>=20
> -yajl_gen_status libxl_string_list_gen_json(yajl_gen hand, libxl_string_l=
ist *pl)
> +yajl_gen_status libxl_string_list_gen_json(yajl_gen hand,
> +                                           const libxl_string_list *pl)
> {
>     libxl_string_list l =3D *pl;
>     yajl_gen_status s;
> @@ -322,7 +323,7 @@ int libxl__string_list_parse_json(libxl__gc *gc, cons=
t libxl__json_object *o,
>     return 0;
> }
>=20
> -yajl_gen_status libxl_mac_gen_json(yajl_gen hand, libxl_mac *mac)
> +yajl_gen_status libxl_mac_gen_json(yajl_gen hand, const libxl_mac *mac)
> {
>     char buf[LIBXL_MAC_FMTLEN+1];
>     snprintf(buf, sizeof(buf), LIBXL_MAC_FMT, LIBXL_MAC_BYTES((*mac)));
> @@ -339,7 +340,7 @@ int libxl__mac_parse_json(libxl__gc *gc, const libxl_=
_json_object *o,
> }
>=20
> yajl_gen_status libxl_hwcap_gen_json(yajl_gen hand,
> -                                     libxl_hwcap *p)
> +                                     const libxl_hwcap *p)
> {
>     yajl_gen_status s;
>     int i;
> @@ -377,7 +378,8 @@ int libxl__hwcap_parse_json(libxl__gc *gc, const libx=
l__json_object *o,
>     return 0;
> }
>=20
> -yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand, libxl_ms_vm_ge=
nid *p)
> +yajl_gen_status libxl_ms_vm_genid_gen_json(yajl_gen hand,
> +                                           const libxl_ms_vm_genid *p)
> {
>     yajl_gen_status s;
>     int i;
> diff --git a/tools/libs/light/libxl_nocpuid.c b/tools/libs/light/libxl_no=
cpuid.c
> index 0630959e76..f40a004e95 100644
> --- a/tools/libs/light/libxl_nocpuid.c
> +++ b/tools/libs/light/libxl_nocpuid.c
> @@ -14,7 +14,7 @@
>=20
> #include "libxl_internal.h"
>=20
> -int libxl__cpuid_policy_is_empty(libxl_cpuid_policy_list *pl)
> +int libxl__cpuid_policy_is_empty(const libxl_cpuid_policy_list *pl)
> {
>     return 1;
> }
> @@ -41,7 +41,7 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,=
 bool restore,
> }
>=20
> yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> -                                libxl_cpuid_policy_list *pcpuid)
> +                                const libxl_cpuid_policy_list *pcpuid)
> {
>     return 0;
> }
> --=20
> 2.30.2
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:18:34 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:18:34 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252376.433400 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2caq-0002hw-GN; Wed, 29 Dec 2021 17:18:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252376.433400; Wed, 29 Dec 2021 17:18:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2caq-0002hp-DD; Wed, 29 Dec 2021 17:18:28 +0000
Received: by outflank-mailman (input) for mailman id 252376;
 Wed, 29 Dec 2021 17:18:26 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KsxB=RO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1n2cao-0002hZ-Dd
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 17:18:26 +0000
Received: from EUR05-DB8-obe.outbound.protection.outlook.com
 (mail-db8eur05on20625.outbound.protection.outlook.com
 [2a01:111:f400:7e1a::625])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 54748777-68cb-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 18:18:25 +0100 (CET)
Received: from AS8PR04CA0066.eurprd04.prod.outlook.com (2603:10a6:20b:313::11)
 by AS8PR08MB6808.eurprd08.prod.outlook.com (2603:10a6:20b:39c::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Wed, 29 Dec
 2021 17:18:22 +0000
Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:313:cafe::e2) by AS8PR04CA0066.outlook.office365.com
 (2603:10a6:20b:313::11) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19 via Frontend
 Transport; Wed, 29 Dec 2021 17:18:22 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4844.14 via Frontend Transport; Wed, 29 Dec 2021 17:18:22 +0000
Received: ("Tessian outbound 9a8c656e7c94:v110");
 Wed, 29 Dec 2021 17:18:22 +0000
Received: from df59f7cf2607.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 CDFB7939-374A-4DBE-888A-12505435DDB4.1; 
 Wed, 29 Dec 2021 17:18:16 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id df59f7cf2607.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 17:18:16 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR0802MB2336.eurprd08.prod.outlook.com
 (2603:10a6:800:9c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:18:14 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4%3]) with mapi id 15.20.4823.024; Wed, 29 Dec 2021
 17:18:14 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 54748777-68cb-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ywCoWO4Fug+6Xz5pW0NN0Ejy6uWKUkGhUnHNzU/OUVk=;
 b=dJf074YmHaf8AUO0eADGSl3FLgMjceH+uQs4n+UYDCOQKJHNWqDfK9N7VoKTMZdu5g4+HPQ9WxfnFgXhFMdaWDrhbDHf4oi/+qp0+my3/4epmI7etEG5Vwrah7jhu2cI34BSkWvqs4lUvy4+ddZSYmCDXSQYAdB0+ClUoBN2hak=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 95455e555d568118
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Oy3PAJ+n/KlInt0sT7mKXX9cgQnMnT/M4/qyZMIdCmfeGDg1zuSerNzmREDIQ/U3/quUPN4xLDqDh7tMXG5vjs2XFId/qFC5BJkzF4Uec66DXRNxBBoM9KB8lfUoqG93X42yTbCRrOFJfZnrsDsrOct+vQ1J4CjEv3aNJ12OW9D5KSLXlkfb+mtA0jH5T57GsEZ2ObZmZw2cX3/ekcJXlXHxq+xg9AlCP6fmJCcvT8EBGVM3h0yiONtP1+GdZadb6+OPSX05NF/4KLTF0aIHQl8MKUYFI3PROHVsA932Tvol3vok5eS3vAmdFxKransDunxSgNl2y2bJ16KSTAQGmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=ywCoWO4Fug+6Xz5pW0NN0Ejy6uWKUkGhUnHNzU/OUVk=;
 b=SHKMErwUxaIE4/EiLCostxctEjAbk3vezc6XeKopUKY1t9QnwHIvW9zCtQ8eYWQwW4hwXK+vDrI3RhetDGulmUhduD57ey+yYkPq/dvHKSVN1vrU6gwFKl4MThx1DqQx0At53Qax0pusGVmJBly7anLPMtoBIdw8ie2HWDJ2ug/yU++dgr0mhMAvU2yI1bNKfsCDzwvyQaFOqxQ2aVVvHVEHPpVLNeeEbOasQG8S5fITCKxEMa4wtvThlVjNPCfjORQQG7SjVvQqkIhRCX179aPvUDeSfzJHbR4xSBVA/88ShJOPKg8X0nArVl7ZNwKGG3UXiMs/RvoxlxqccmIBtw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=ywCoWO4Fug+6Xz5pW0NN0Ejy6uWKUkGhUnHNzU/OUVk=;
 b=dJf074YmHaf8AUO0eADGSl3FLgMjceH+uQs4n+UYDCOQKJHNWqDfK9N7VoKTMZdu5g4+HPQ9WxfnFgXhFMdaWDrhbDHf4oi/+qp0+my3/4epmI7etEG5Vwrah7jhu2cI34BSkWvqs4lUvy4+ddZSYmCDXSQYAdB0+ClUoBN2hak=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 2/5] tools/xl: Mark libxl_domain_config * arg of
 printf_info_*() const
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <26c5803fdb59bd0bd06f2509097d5929dd4f67f2.1640590794.git.ehem+xen@m5p.com>
Date: Wed, 29 Dec 2021 17:18:06 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F7C4A5E4-5A5A-487D-A27D-4602087D4F1D@arm.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <26c5803fdb59bd0bd06f2509097d5929dd4f67f2.1640590794.git.ehem+xen@m5p.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0164.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::7) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 9a4ee6d6-4c48-4483-09f9-08d9caef3788
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2336:EE_|AM5EUR03FT027:EE_|AS8PR08MB6808:EE_
X-Microsoft-Antispam-PRVS:
	<AS8PR08MB680880BE1543B91CE56E6365E4449@AS8PR08MB6808.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;OLM:5236;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Knn7Qmu42iWD2GSuHAG3565Td0v3XrsAtwOAaTPyIUSTrsIAPu0RnfS/XejRJopeSAUfTg6wZJe0G9XhSXH6YIavl+ai6HMpBBo72OFdtRoPyf9SsLFkPsToo4kopKh2xMHr0bti0bH06z1kXL1Hx9jzDWthgCTyS52UNoOFQ+RlqX6MQfTNKfavlideEfdesG7eFgXzC3tiXZTrevy39fjOHEx++kYmV04st+kkPVyZVqw67ARPEdQ8cPq+uFaUvVDkyWIBAYCnTSTG34D9Hf8TItiui4yD7LRPzY8F1znnGkrT1x+2V47Hj4paUDmTJExV37VuKTU0Mkc9PJGSGwKgu/BWk1J0VPzrs4oDC84ZgGNjHnDvXb9zpl3hvISCy+Oasg5A4RNxA76y8vvyoYgVAJ260rDPFD7D7awLq+YfhL4ClX5oLicbwl2fnOkgkhC36ZQLKqmplGRkDtMH4dwyN9QUthvAEXlQZr7oglN761QEuFieG8JuXl8wi5MWVQlsM/OSiuoXnLScI5/jjxW24LPlJf8fcb9mU2gRF4MUOULQe0sLfOgq6FEoslCjyA6DG7cnKI7Iic/KECScBW7Xlj6bi2VSmzbkY821NsxVAcq61NHqHxIKxWQUyvriXs2l2yi3rKk221WbDdOxx+/jlIPywLaFVxSiKVJwwDAXimXBPQuaH/z+ko1UF2OECJIRBdeZhXwifSvpeIumxFo5fU3w75h+e1x2xEbWlhI=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(36756003)(6506007)(53546011)(66476007)(54906003)(5660300002)(186003)(66946007)(44832011)(66556008)(26005)(2616005)(33656002)(38350700002)(38100700002)(86362001)(316002)(8676002)(6512007)(83380400001)(52116002)(8936002)(6666004)(2906002)(4326008)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	2d738521-0859-4b50-bfb7-08d9caef3260
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	86cOkb9MmopDl2E89uY2gKPdr9lKeC0dFTQNvyrKrtQ8NxRTllc9P1NsZBAiEtWPssca/32ZQmW9CsY2coefmkRFKG1zcnNTHtiJppvrRo9YC+tPKuUDRJTYrLypxl2VoFvGLDgWjr9HwezQEs1wKR6pzIFtiyWad0ezf2ako/t+5NRRz7QdYNKLu34t/l3lkrY9yG7B3pCY936Hv0G0oyihUG3ax1ETMVZQ/vG9pyRuJPNR647WCU/J2SsbEupv/5wao0UWaanCoaJ0EYM4ONTasM8QTtH1d8hAuXdEvVeGldyCBaSlEFpt3lw3NaHuTy+bs3/2T5ACUumUwzo1njS9ZiEPkyj5XubvYTB+7A5BQq5i6Hg1Hr+YnTynIVeZt1BsiG9R4PS7pBpLRtwzpPOKXSWoxl2pO/x/QzhxUIlM3buGUqsYGdDpnDfYy5mD24VTPQn8BcmadAlW2VUVoDqyAPyp6T6rchHLlkfMzdlGfOtP0X2EZzU7h/l+l8LmciDK3icaaPxuYDOixy6A1yAmguEmGbVWLx+wLRAg7YwwXxdJw7xbEr4Vaa6FJ0jsqW2WYMBzj3/FXGwlyPa8n88YLnDOgYsGJz89Z0IcItGGjKOhDRR+O/Hje9JFBqjPnSC3Ft2hfI/RZvMTTeGfYkc13JVi57UXf3RmnbKdDAo5e8MWeOfmyTLgomoIRXqQvmy5Jau+F/c/kl+OX/A94g==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(70206006)(4326008)(2616005)(107886003)(6862004)(186003)(508600001)(53546011)(82310400004)(6506007)(336012)(44832011)(6666004)(54906003)(47076005)(316002)(6512007)(8936002)(81166007)(8676002)(6486002)(33656002)(356005)(2906002)(26005)(36860700001)(83380400001)(86362001)(70586007)(5660300002)(36756003);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 17:18:22.6667
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4ee6d6-4c48-4483-09f9-08d9caef3788
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6808



> On 18 Dec 2020, at 21:32, Elliott Mitchell <ehem+xen@m5p.com> wrote:
>=20
> With libxl having gotten a lot more constant, now printf_info_sexp() and
> printf_info_one_json() can add consts.  May not be particularly
> important, but it is best to mark things constant when they are known to
> be so.

Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
>=20
> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> tools/xl/xl.h      | 2 +-
> tools/xl/xl_info.c | 2 +-
> tools/xl/xl_sxp.c  | 6 +++---
> 3 files changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> index c5c4bedbdd..720adb0048 100644
> --- a/tools/xl/xl.h
> +++ b/tools/xl/xl.h
> @@ -300,7 +300,7 @@ typedef enum {
>     DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
> } domain_restart_type;
>=20
> -extern void printf_info_sexp(int domid, libxl_domain_config *d_config, F=
ILE *fh);
> +extern void printf_info_sexp(int domid, const libxl_domain_config *d_con=
fig, FILE *fh);
> extern void apply_global_affinity_masks(libxl_domain_type type,
>                                         libxl_bitmap *vcpu_affinity_array=
,
>                                         unsigned int size);
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 712b7638b0..23d82ce2a2 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -59,7 +59,7 @@ static int maybe_printf(const char *fmt, ...)
> }
>=20
> static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid,
> -                                            libxl_domain_config *d_confi=
g)
> +                                            const libxl_domain_config *d=
_config)
> {
>     yajl_gen_status s;
>=20
> diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c
> index 359a001570..d5b9051dfc 100644
> --- a/tools/xl/xl_sxp.c
> +++ b/tools/xl/xl_sxp.c
> @@ -26,13 +26,13 @@
> /* In general you should not add new output to this function since it
>  * is intended only for legacy use.
>  */
> -void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh=
)
> +void printf_info_sexp(int domid, const libxl_domain_config *d_config, FI=
LE *fh)
> {
>     int i;
>     libxl_dominfo info;
>=20
> -    libxl_domain_create_info *c_info =3D &d_config->c_info;
> -    libxl_domain_build_info *b_info =3D &d_config->b_info;
> +    const libxl_domain_create_info *c_info =3D &d_config->c_info;
> +    const libxl_domain_build_info *b_info =3D &d_config->b_info;
>=20
>     fprintf(fh, "(domain\n\t(domid %d)\n", domid);
>     fprintf(fh, "\t(create_info)\n");
> --=20
> 2.30.2
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:18:49 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:18:49 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252379.433411 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cbB-0003CF-PB; Wed, 29 Dec 2021 17:18:49 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252379.433411; Wed, 29 Dec 2021 17:18:49 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2cbB-0003C8-LZ; Wed, 29 Dec 2021 17:18:49 +0000
Received: by outflank-mailman (input) for mailman id 252379;
 Wed, 29 Dec 2021 17:18:48 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KsxB=RO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1n2cbA-0002hZ-Dz
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 17:18:48 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
 (mail-am6eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7e1b::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 61c07710-68cb-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 18:18:47 +0100 (CET)
Received: from DU2PR04CA0020.eurprd04.prod.outlook.com (2603:10a6:10:3b::25)
 by DBBPR08MB4380.eurprd08.prod.outlook.com (2603:10a6:10:cc::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Wed, 29 Dec
 2021 17:18:41 +0000
Received: from DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:3b:cafe::19) by DU2PR04CA0020.outlook.office365.com
 (2603:10a6:10:3b::25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14 via Frontend
 Transport; Wed, 29 Dec 2021 17:18:41 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT041.mail.protection.outlook.com (10.152.21.4) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4844.14 via Frontend Transport; Wed, 29 Dec 2021 17:18:41 +0000
Received: ("Tessian outbound 157533e214a9:v110");
 Wed, 29 Dec 2021 17:18:41 +0000
Received: from 22efb1b431a0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 D9D1E859-D527-4EE4-AAC5-FB2F15E64967.1; 
 Wed, 29 Dec 2021 17:18:34 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 22efb1b431a0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 17:18:34 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR0802MB2336.eurprd08.prod.outlook.com
 (2603:10a6:800:9c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:18:32 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4%3]) with mapi id 15.20.4823.024; Wed, 29 Dec 2021
 17:18:32 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 61c07710-68cb-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/jSEOyL5652lFSHhvWwXP0CpTXkSu+qrdExon1Hw8kA=;
 b=3qUGpSYkaXOZnZ+CaSb4EoTpHC6POEy0rOgv+DRUjac0RRJ07w8kmmpasu3lPJjHE+EAGkv40iboCyhHouLmQdZqb4ULbGz+jvdroMpiz0qGmqVRzQla57UecXeikpKKd9J8XK8oB1mZO6K08jTx8mxmRsoFuHnoF/eEuqHyUAc=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: a4e60c3a9b4568bd
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=m9Qwf6RDMOfk31URMjSXAmeIJaKqRPL+CA7gS6bYnFRxJ3vpepRUODWnKs4b+PCJNaUuhgcjMkG4nfnrmvo/hD3aFgF2WARS7jdmxCqgVBZtrRar3w+ka+K5Fjh1ZIUXE/DMlyTK94LOZluJuvA8TmnUUhZNGafZ4+yYe9q/90WKNcVewcBLaU6n10Tdv/pZl49BklL2XBX4pDrufGWmDxa7Ou8UJtkXCEIO1Z0zf5lorJgVgALB9d/ArhwtTpv8NH7MWftE1Zb5Kc0k1hMFqX60ygHXGtjRwNyb/2ZR+5nWAK5ViR6IhqhioXOmv6VmwcWONeMp+GHyduxxAnigSA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/jSEOyL5652lFSHhvWwXP0CpTXkSu+qrdExon1Hw8kA=;
 b=DV28P0VS1KFwLMkZzyJwMftRisltEU44iOimiVetzjtuxmitbqmCIAe4S37tvmgPUSIDZQ9vj/D3GUnvzmFNLXdK9i1y2wb5LcCo+Ofsuh5VnZLMVrDn8akkf1mlSna8b0cq0Xwa/yj2F8hFwnA25QHXYTsiysJIttaxggF85cMt5wn1SK5B1OEWnmzVAcPzFyqnMAAR+HQMIrrStV1huBZDNmDHa9CirpPHZ5wNcpTXExus3lynsc05nCc/ryw64BOzOLFzF4EhBHDguHyi/YNZcC79Z82/kuZnMjFxxjbjjW+n9qeUr+yMmddIm4zlthdwMF7052m0PGT8IGregQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/jSEOyL5652lFSHhvWwXP0CpTXkSu+qrdExon1Hw8kA=;
 b=3qUGpSYkaXOZnZ+CaSb4EoTpHC6POEy0rOgv+DRUjac0RRJ07w8kmmpasu3lPJjHE+EAGkv40iboCyhHouLmQdZqb4ULbGz+jvdroMpiz0qGmqVRzQla57UecXeikpKKd9J8XK8oB1mZO6K08jTx8mxmRsoFuHnoF/eEuqHyUAc=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 3/5] tools/xl: Rename printf_info()/list_domains_details()
 to dump_by_...()
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <fdf4e903a675e3a9ec8794b92f164f6c571371e5.1640590794.git.ehem+xen@m5p.com>
Date: Wed, 29 Dec 2021 17:18:31 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4EA1A86F-D176-46C8-8670-BB42B9B856C1@arm.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <fdf4e903a675e3a9ec8794b92f164f6c571371e5.1640590794.git.ehem+xen@m5p.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0164.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::7) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 6a073829-e314-4cc7-71d3-08d9caef429b
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2336:EE_|DB5EUR03FT041:EE_|DBBPR08MB4380:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB43804E227097AC2E2914E1E0E4449@DBBPR08MB4380.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:49;OLM:49;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 Uxb6gU7lSrsi5Oz22iekzTpQo8PjbvCBJ1vcIK5qbPVFFzUof6P+B+a/Q4W6mvZ9o3ijoYbee91sPArjtgQvEjsdX2wdtOa2fn/XYZkLQlnPlwLf4S9eST8Cr7MvBaZIfaDjbGZKGGSYr0cOZ4lP3C6UQHzc/wmDVLgb+N0ibxcVUYBx5214v5M0A/ftHWQ0PaJiIvBx3bc/p3/w3rvMy3K3UKkHR2DHNr8jrah2TycTVR1DxaV6WZLWzdvnmdM+iIPHzm9ZaZVJXB2ubOyl8lul+wbXMSKvWqpRQs+cvMfNtJzpLwbF8GbAmN84BA5RHQmXGKVq2s/NhU6oE3CAuf9qFLSMjzDgLsBLK/I8r1YVlLr79ytfW7gD5jdcH6XaMhJR4WB0TzIksMpdxq2+vWaacPy0BwO2npQfEVOFuvKM7z2coCZH+0FQBNHy2dDlTdKyqTyeaMLTa4v4ypnZqoQotQOp1nPYHocacRnnCYzs4SofsC0XmtezoB4Mx30n8ZFeOgr2gEH9F4kwatXZ4MVx93JIaSpmIAz0QBeafkxvP1xMG+T3ngyw1yl+nuxzvk7VBKKShpk3AeR9VIVVG2C8F8AqEfJgPXJ1RpOfme0lsZjVrvKpcr5LHNUmnAbWHqgIErqTrKFRUNsh1XmWhgq0PCdAmQrQKGAflMZ2keDUp9FJBQJglW5UwzpGUoA6/59xbbJkx772D2DcVx6a7dLIhe4QliifM0yYpoYX3Gg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(36756003)(6506007)(53546011)(66476007)(54906003)(5660300002)(186003)(66946007)(44832011)(66556008)(26005)(2616005)(33656002)(38350700002)(38100700002)(86362001)(316002)(8676002)(6512007)(83380400001)(52116002)(8936002)(2906002)(4326008)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	312b2b90-3d7a-4caa-31d8-08d9caef3d1b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ZeIzTbTL+1/pTgbEpe2QN7eYsxH2RpkOB0rvqYAuV0xm76wiSZRAOhugeVoLA0vbc8KCutkALJixqvATmq3NBOoSgNK7j6MRCz0yLg9H2CsO+Cs99+gIsVJklNphM4CYWgMkqsoX6b8QrI721VQyQ4qUecb8vWI0LdirJpc+Eu5cdc4qK5brdyIlkCnk/dd7bIiuR15MZkX+ytyen+yUOXSW1B5QyEtwqq6xRTGWU1zkF9UyeftIAj6/4aqvqet/2Zyx5WhJ9FDOqqA9N/v0CrIXdCdJtC8J7JytdzQoeGyUGG+D7bajSd0fsnXAnWIHALsMTQq9Ho0cQEXX6fRf4XXiLioK+YAlDIezRGiVcr5bL0iVOZPBkrUlfLhamzCML1g7m6ww6FrP1cNkeynC2GwPaH4rIJ59qdg8SJk7JiUe18ZeDoNTjYzXbQQ9qJ81jtzCuyKA3BcL2qge94iyTmgKwOstMjXY9N6u1r/P5zvk/ID80EzwbXkwsrbRqxu6XOXn//pKU9r9hHgZ6qH/gAAcMvtsvTsdfbVKaQNMoWRZIpAeiAQRPsD5vpZxBMIR2rtgQQrcMtlnOf9EslPmxrfq3WUn2a/SL2bHJHNlcbYc7eV7B4oYlS79Dh1sa/s7dZsKYn+/BRqiTk+gbpH7hunksdYG3SSk47nBdpdIpZzpx2+TlN6hu4TAIuepx5XGws9kzKg5KQ21/x7oqpT8qQ==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(44832011)(2616005)(8676002)(33656002)(6486002)(2906002)(53546011)(82310400004)(6506007)(86362001)(4326008)(36860700001)(356005)(36756003)(316002)(54906003)(83380400001)(81166007)(8936002)(186003)(6862004)(107886003)(336012)(6512007)(70206006)(70586007)(5660300002)(26005)(47076005)(508600001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 17:18:41.2957
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a073829-e314-4cc7-71d3-08d9caef429b
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT041.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4380



> On 18 Dec 2020, at 01:42, Elliott Mitchell <ehem+xen@m5p.com> wrote:
>=20
> printf_info()/list_domains_details() had been serving fairly similar
> purposes.  Increase their consistency (add file-handle and output_format
> arguments to list_domains_details(), reorder arguments) and then rename
> to better reflect their functionality.
>=20
> Both were simply outputting full domain information.  As this is more of
> a dump operation, "dump" is a better name.
>=20

Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> tools/xl/xl.h      |  8 ++++++++
> tools/xl/xl_info.c | 30 ++++++++++++++++--------------
> tools/xl/xl_misc.c |  5 +----
> 3 files changed, 25 insertions(+), 18 deletions(-)
>=20
> diff --git a/tools/xl/xl.h b/tools/xl/xl.h
> index 720adb0048..be5f4e11fe 100644
> --- a/tools/xl/xl.h
> +++ b/tools/xl/xl.h
> @@ -300,6 +300,14 @@ typedef enum {
>     DOMAIN_RESTART_SOFT_RESET,   /* Soft reset should be performed */
> } domain_restart_type;
>=20
> +extern void dump_by_config(enum output_format output_format,
> +                           FILE *fh,
> +                           const libxl_domain_config *d_config,
> +                           int domid);
> +extern void dump_by_dominfo_list(enum output_format output_format,
> +                                 FILE *fh,
> +                                 const libxl_dominfo info[],
> +                                 int nb_domain);
> extern void printf_info_sexp(int domid, const libxl_domain_config *d_conf=
ig, FILE *fh);
> extern void apply_global_affinity_masks(libxl_domain_type type,
>                                         libxl_bitmap *vcpu_affinity_array=
,
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 23d82ce2a2..3647468420 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -94,12 +94,10 @@ out:
>     return s;
> }
>=20
> -void printf_info(enum output_format output_format,
> -                 int domid,
> -                 libxl_domain_config *d_config, FILE *fh);
> -void printf_info(enum output_format output_format,
> -                 int domid,
> -                 libxl_domain_config *d_config, FILE *fh)
> +void dump_by_config(enum output_format output_format,
> +                    FILE *fh,
> +                    const libxl_domain_config *const d_config,
> +                    int domid)
> {
>     if (output_format =3D=3D OUTPUT_FORMAT_SXP)
>         return printf_info_sexp(domid, d_config, fh);
> @@ -442,7 +440,10 @@ static void list_domains(bool verbose, bool context,=
 bool claim, bool numa,
>     libxl_physinfo_dispose(&physinfo);
> }
>=20
> -static void list_domains_details(const libxl_dominfo *info, int nb_domai=
n)
> +void dump_by_dominfo_list(enum output_format output_format,
> +                          FILE *fh,
> +                          const libxl_dominfo info[],
> +                          int nb_domain)
> {
>     libxl_domain_config d_config;
>=20
> @@ -453,7 +454,7 @@ static void list_domains_details(const libxl_dominfo =
*info, int nb_domain)
>     const char *buf;
>     libxl_yajl_length yajl_len =3D 0;
>=20
> -    if (default_output_format =3D=3D OUTPUT_FORMAT_JSON) {
> +    if (output_format =3D=3D OUTPUT_FORMAT_JSON) {
>         hand =3D libxl_yajl_gen_alloc(NULL);
>         if (!hand) {
>             fprintf(stderr, "unable to allocate JSON generator\n");
> @@ -472,16 +473,16 @@ static void list_domains_details(const libxl_dominf=
o *info, int nb_domain)
>                                                  &d_config, NULL);
>         if (rc)
>             continue;
> -        if (default_output_format =3D=3D OUTPUT_FORMAT_JSON)
> +        if (output_format =3D=3D OUTPUT_FORMAT_JSON)
>             s =3D printf_info_one_json(hand, info[i].domid, &d_config);
>         else
> -            printf_info_sexp(info[i].domid, &d_config, stdout);
> +            printf_info_sexp(info[i].domid, &d_config, fh);
>         libxl_domain_config_dispose(&d_config);
>         if (s !=3D yajl_gen_status_ok)
>             goto out;
>     }
>=20
> -    if (default_output_format =3D=3D OUTPUT_FORMAT_JSON) {
> +    if (output_format =3D=3D OUTPUT_FORMAT_JSON) {
>         s =3D yajl_gen_array_close(hand);
>         if (s !=3D yajl_gen_status_ok)
>             goto out;
> @@ -490,11 +491,12 @@ static void list_domains_details(const libxl_dominf=
o *info, int nb_domain)
>         if (s !=3D yajl_gen_status_ok)
>             goto out;
>=20
> -        puts(buf);
> +        fputs(buf, fh);
> +        fputc('\n', fh);
>     }
>=20
> out:
> -    if (default_output_format =3D=3D OUTPUT_FORMAT_JSON) {
> +    if (output_format =3D=3D OUTPUT_FORMAT_JSON) {
>         yajl_gen_free(hand);
>         if (s !=3D yajl_gen_status_ok)
>             fprintf(stderr,
> @@ -571,7 +573,7 @@ int main_list(int argc, char **argv)
>     }
>=20
>     if (details)
> -        list_domains_details(info, nb_domain);
> +        dump_by_dominfo_list(default_output_format, stdout, info, nb_dom=
ain);
>     else
>         list_domains(verbose, context, false /* claim */, numa, cpupool,
>                      info, nb_domain);
> diff --git a/tools/xl/xl_misc.c b/tools/xl/xl_misc.c
> index 08f0fb6dc9..bcf178762b 100644
> --- a/tools/xl/xl_misc.c
> +++ b/tools/xl/xl_misc.c
> @@ -256,9 +256,6 @@ int main_dump_core(int argc, char **argv)
>     return EXIT_SUCCESS;
> }
>=20
> -extern void printf_info(enum output_format output_format,
> -                        int domid,
> -                        libxl_domain_config *d_config, FILE *fh);
> int main_config_update(int argc, char **argv)
> {
>     uint32_t domid;
> @@ -344,7 +341,7 @@ int main_config_update(int argc, char **argv)
>     parse_config_data(filename, config_data, config_len, &d_config);
>=20
>     if (debug || dryrun_only)
> -        printf_info(default_output_format, -1, &d_config, stdout);
> +        dump_by_config(default_output_format, stdout, &d_config, -1);
>=20
>     if (!dryrun_only) {
>         fprintf(stderr, "setting dom%u configuration\n", domid);
> --=20
> 2.30.2
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:20:25 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:20:25 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252387.433427 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ccc-0004k1-Kl; Wed, 29 Dec 2021 17:20:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252387.433427; Wed, 29 Dec 2021 17:20:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ccc-0004jP-Dm; Wed, 29 Dec 2021 17:20:18 +0000
Received: by outflank-mailman (input) for mailman id 252387;
 Wed, 29 Dec 2021 17:20:16 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KsxB=RO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1n2cca-0004ge-L0
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 17:20:16 +0000
Received: from EUR05-VI1-obe.outbound.protection.outlook.com
 (mail-vi1eur05on20611.outbound.protection.outlook.com
 [2a01:111:f400:7d00::611])
 by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 9616bd0e-68cb-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 18:20:15 +0100 (CET)
Received: from AS9PR06CA0404.eurprd06.prod.outlook.com (2603:10a6:20b:461::24)
 by HE1PR08MB2778.eurprd08.prod.outlook.com (2603:10a6:7:34::30) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Wed, 29 Dec
 2021 17:20:13 +0000
Received: from AM5EUR03FT010.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:20b:461:cafe::54) by AS9PR06CA0404.outlook.office365.com
 (2603:10a6:20b:461::24) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19 via Frontend
 Transport; Wed, 29 Dec 2021 17:20:13 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 AM5EUR03FT010.mail.protection.outlook.com (10.152.16.134) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4844.14 via Frontend Transport; Wed, 29 Dec 2021 17:20:12 +0000
Received: ("Tessian outbound dbb52aec1fa6:v110");
 Wed, 29 Dec 2021 17:20:12 +0000
Received: from 9ce6ec32f649.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 52F952DA-6D13-415E-B6C1-7A826AEE98FC.1; 
 Wed, 29 Dec 2021 17:20:05 +0000
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ce6ec32f649.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 17:20:05 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR0802MB2336.eurprd08.prod.outlook.com
 (2603:10a6:800:9c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:20:03 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4%3]) with mapi id 15.20.4823.024; Wed, 29 Dec 2021
 17:20:03 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9616bd0e-68cb-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hP0UbL67XX71k8RwTGfBw4XY9FE3938TDoiR++fX5bQ=;
 b=+C/jUP8h5NbVaH6g206H+O1QgtEafdbLpM17S+rkY8LtHgDDq0SZl/7Srlz0Br/SFGxx0un9BCLQejYWbX3aX6SK4bXRmSGfuvBTZrRk80hj1dsb/Sh2sRkBzCvptnEZnL1ou1N/B4JqPf07R4+cgsl3X1EUKBxFWsGwj1/M6As=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: 4abfa30bacb26158
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=CotMeWHKuZbK+04Z2hd/O26rpzkdK0REXBMDHILVMVclhzWFV5Y7ASiRXzoDyTj02Pdzr7NiLzkldXmLXsHCvUBGVeixmhBp9x6cWCGcm7xmkUEHefiM3FtVKEpePm72fBAgeGClWwGAz705RggqgYvRRTs4D/I5I2gJGG03Xy1LwlaaaKYXLXXKVeN4N2negTSnpBpNOEXIUubZb3Pqg++SOKx3/92lqA/Pv95oK7lPA+STBJU1HEywnTylJ9m0ww7l/Pwztb6/GNnXfx98Q8AnJqkVEH8mmisIRRwHbsnrCQmtHJOEZbGW30w6xDB9VicLVVwflnm/OXBXN3y6zA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=hP0UbL67XX71k8RwTGfBw4XY9FE3938TDoiR++fX5bQ=;
 b=CRXnFNbFp7A0pD+Vrw63yTLycKkCSO4ew3qvpi3elRGE88ouumWv3gr1VYgoOtweoOcl/NRYlclvjaTq0esWH8IK3ZTzJMBgV0WZsl8jTM0IPAfPGKXV59T6/UbRvF2Yp4x5mDvYsq1tcfkxnhd9uO/WF6waG3WDwiGD9nPmHDYJOSg0o3pXqwL/XmXID7/oqLf1ZZulkCHGmplHdzVrMPmZF+JVJMBw4gAVOXzr6fSGBURhv4jzJFh33lvmktT4HMYLFJtZwph39M5jUC3nATBWdBlCMQB7X451fER8TYGs8+VZxZ4mmTYPmt1p8j28gfQXsJbhFzYXlWo9gdbM/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=hP0UbL67XX71k8RwTGfBw4XY9FE3938TDoiR++fX5bQ=;
 b=+C/jUP8h5NbVaH6g206H+O1QgtEafdbLpM17S+rkY8LtHgDDq0SZl/7Srlz0Br/SFGxx0un9BCLQejYWbX3aX6SK4bXRmSGfuvBTZrRk80hj1dsb/Sh2sRkBzCvptnEZnL1ou1N/B4JqPf07R4+cgsl3X1EUKBxFWsGwj1/M6As=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=us-ascii
Subject: Re: [PATCH 5/5] tools/xl: Fix potential deallocation bug
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <2d1335a4056558d172d9aa3e59982eb761647418.1640590794.git.ehem+xen@m5p.com>
Date: Wed, 29 Dec 2021 17:20:02 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: 7bit
Message-Id: <25ACC8F3-F6A8-4D07-9CCA-A48B8AE4B553@arm.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <2d1335a4056558d172d9aa3e59982eb761647418.1640590794.git.ehem+xen@m5p.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0169.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::12) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 96ed9754-57b0-4e9f-4f20-08d9caef7931
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2336:EE_|AM5EUR03FT010:EE_|HE1PR08MB2778:EE_
X-Microsoft-Antispam-PRVS:
	<HE1PR08MB27787653133D6ABF34295D63E4449@HE1PR08MB2778.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 WyaYK0f9cjcuBv0t3UBVMNS9gJiPBR9Dxt24a982g5yKHRBYydZX6QLvhcRxOrJWFqni3y+BW2AQfpbc7fQ8i7otrRCyAEoOfaVVHePgCCZ18pn8XQy5Ox2aQl2ypct/Xd6jaFzvuX/q7fpwlRxzEjgdhuNBvan5JHVVyGoe04hIPr3EwV70ANaL65wL+Seyko0NHjB9GyfZtAsdQkza9+cHPWj4W2+SuJMpxgjB5bYRMKFW2vC4nDDK6GjBw+eRTiSmJzQS8kT5y7tybfn/5b2PQnffRyPlQe4IvRri//7SxFD7pOaRyLMcTeX2Z5R+EBSl3jsMSfB0nbe/NBfPZMlk6dvYhVrPg+qaOMbfIeDSlrrgzLGnxNuxGLOz04vWUxYIiXa3CrtyMq2TTPfDpk+mvgKbp4oz3hEUEktfOnc0U9MfMAb5QWBApBQ22LO527KaJUbJh/ibCGuIhcVqFdxmm7YrAYOmoAtPuTRfnob9UtLnO+ES9lM5OpGQ0TRV5qcWVooRIEtSC3yVtUAbhqUgHzbV9hUFLhbW6DHfD6o5JPu3Ys0+lCh6rYLF1/i0pv7oYu2FofYqizCfzHnAS0dTnsIeMyY9hKFytYYls1foBBMXY3+BuysHtC2DrKNuPKi7v1wxCpO5VTewAa3es4A93XThP02nMtPHfGoJS1e9hIdfRnzhBax2l/6ohn9/cptgD2htIRbHl1qzVKOi5wg6qRAW//ZPDy5a+xlLPyg=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(36756003)(6506007)(53546011)(66476007)(54906003)(5660300002)(186003)(66946007)(44832011)(66556008)(26005)(2616005)(33656002)(38350700002)(38100700002)(86362001)(316002)(8676002)(6512007)(83380400001)(52116002)(8936002)(2906002)(4744005)(4326008)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AM5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	63f93e20-5836-46aa-7504-08d9caef7378
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5JTTdFIen7g25wn284eVx3JHN0ufqbfthb00eF02JXv2aNxN9hgpn3De+2tRTLJB9YSJpfClz2M1w2AYDMRgsXPUteKq5kbfElpVyARiyoOtkda8z1cuOKSnBakpTxDOMsluIZdyUAA2WLiqtSXL8xsGi8OO2Y3vs8NRc5Y7sjRz5GgKAZm5uhYKB10p35utTHiK0bX8ZS7gaUdw6RI6p39XjR2QxMtHoTamIDHdmC3TheHgA9m35ASQKDNkEbrnju6eCQV5yIQ4si5ucC8kxXsuhWTbfhuDW59FrPV6BHMHnMrPp4dKUkiLBob/aa3EaVsK7lciHBy1G+axVcyWUj3S8Ns9CuV6qJ5BYdcKPM9hJHxHJF4m9oGF0wTlDw9sdA4MdCz6+CVSQDAEgsLiK8bgVLBn99UanpnLlFT8XI5jRZ1Vtkg/6f/SwmS3eteFbP8igDEIzCN58UTwFIvqcoFDrzY5Q/O02s4dXvrCqAatt2JtpMteLI4qDcQGatE9Nnv0mg57FXfFv50VAQhIiRWlWaVV8tlmCQ1YsyGghUOCl1VAuv1npuyyO0l51WzANCl4teX78yLczQ9zsAybpftkzKcA3t4EryJahuskK7Mee05vOMqKH/8f4Cr0CLNrFLYV3dCtfDW/+6qWcCltQW05Q51B79h43XHrvHJcbkpAJXU4CTV0tluidmEUGVw5xQUKpZQDZWmAvzplLdgKpA==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(316002)(81166007)(36860700001)(2906002)(33656002)(36756003)(8936002)(83380400001)(54906003)(107886003)(336012)(508600001)(26005)(186003)(6512007)(44832011)(4326008)(8676002)(356005)(4744005)(6506007)(6486002)(2616005)(5660300002)(53546011)(70586007)(82310400004)(47076005)(70206006)(86362001)(6862004);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 17:20:12.8296
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 96ed9754-57b0-4e9f-4f20-08d9caef7931
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	AM5EUR03FT010.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2778



> On 10 Dec 2020, at 23:09, Elliott Mitchell <ehem+xen@m5p.com> wrote:
> 
> There is potential for the info and info_free variable's purposes to
> diverge.  If info was overwritten with a distinct value, yet info_free
> still needed deallocation a bug would occur on this line.  Preemptively
> address this issue (making use of divergent info/info_free values is
> under consideration).
> 

Looks ok to me
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> tools/xl/xl_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
> index 3647468420..938f06f1a8 100644
> --- a/tools/xl/xl_info.c
> +++ b/tools/xl/xl_info.c
> @@ -579,7 +579,7 @@ int main_list(int argc, char **argv)
>                      info, nb_domain);
> 
>     if (info_free)
> -        libxl_dominfo_list_free(info, nb_domain);
> +        libxl_dominfo_list_free(info_free, nb_domain);
> 
>     libxl_dominfo_dispose(&info_buf);
> 
> -- 
> 2.30.2
> 
> 



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 17:20:26 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 17:20:26 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252388.433422 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ccc-0004hH-8M; Wed, 29 Dec 2021 17:20:18 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252388.433422; Wed, 29 Dec 2021 17:20:18 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ccc-0004hA-5E; Wed, 29 Dec 2021 17:20:18 +0000
Received: by outflank-mailman (input) for mailman id 252388;
 Wed, 29 Dec 2021 17:20:16 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=KsxB=RO=arm.com=Luca.Fancellu@srs-se1.protection.inumbo.net>)
 id 1n2cca-0004gZ-LE
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 17:20:16 +0000
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03on0607.outbound.protection.outlook.com
 [2a01:111:f400:fe0a::607])
 by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 960ea7d8-68cb-11ec-9e60-abaf8a552007;
 Wed, 29 Dec 2021 18:20:15 +0100 (CET)
Received: from DB7PR05CA0040.eurprd05.prod.outlook.com (2603:10a6:10:2e::17)
 by DBBPR08MB6313.eurprd08.prod.outlook.com (2603:10a6:10:202::19) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Wed, 29 Dec
 2021 17:20:12 +0000
Received: from DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
 (2603:10a6:10:2e:cafe::37) by DB7PR05CA0040.outlook.office365.com
 (2603:10a6:10:2e::17) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14 via Frontend
 Transport; Wed, 29 Dec 2021 17:20:12 +0000
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
 DB5EUR03FT003.mail.protection.outlook.com (10.152.20.157) with
 Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4844.14 via Frontend Transport; Wed, 29 Dec 2021 17:20:12 +0000
Received: ("Tessian outbound c61f076cbd30:v110");
 Wed, 29 Dec 2021 17:20:05 +0000
Received: from 3b816ccb0ff0.1
 by 64aa7808-outbound-1.mta.getcheckrecipient.com id
 BA84F7A4-C548-41A4-836C-9DE5AEFCDBE1.1; 
 Wed, 29 Dec 2021 17:19:58 +0000
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3b816ccb0ff0.1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
 Wed, 29 Dec 2021 17:19:58 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23) by VI1PR0802MB2336.eurprd08.prod.outlook.com
 (2603:10a6:800:9c::16) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec
 2021 17:19:56 +0000
Received: from VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4]) by VI1PR0801MB2125.eurprd08.prod.outlook.com
 ([fe80::30c8:65b:f59:58b4%3]) with mapi id 15.20.4823.024; Wed, 29 Dec 2021
 17:19:56 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 960ea7d8-68cb-11ec-9e60-abaf8a552007
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xyG5Cjx1EThHy0twJv9yfg4+Rrkze1DsoTUJTKUGGCo=;
 b=HmOnJ1UEiAV4XhelGDwePParKi956bcikWJ0MvkYEkv+cWBN0KndxpTN1UL3TvnfdGBj5VYQnpL5M1d/uYnGC2c52zDyoXFEUYLM65JhRO7+2e4VzCbMmtMppDz+vq1n5eWTVKbL0PGsRvwJzbzL/OXO/yI+IuluZxeOW81rMY0=
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
 smtp.mailfrom=arm.com; dkim=pass (signature was verified)
 header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
X-CheckRecipientChecked: true
X-CR-MTA-CID: df4c314359e48d42
X-CR-MTA-TID: 64aa7808
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Z4+Gu605KYQWl6M6KtZzp4Q+eqc+qjRjcZuKBMdeGvky/hWWqlbKknCtCEC1yIBtT+XfXhTrsOd+MGEm6rUpf70POEcYD4cIOBWIKd3Glv4Em0KlJrXPrhxHHiHUAHgY6bcB0T9ocbsdtFSiRh054HuKsAPWYYIq02BVooK+E3YNW2m/+utvxkltpqWZ76AlNIJwB3+Lcxaedccq0dgPk1EuFhCCmPpYFk8YcALeX2D+b64VctNC8RAMHEplwzER7MiC+uSHYUux3pqpXRRef5oUUgNIfJNcBo7t9F5/CiOdQjxUYrFPeptPEP5UI+MewjzSsguGHXeealNbsY9PDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=xyG5Cjx1EThHy0twJv9yfg4+Rrkze1DsoTUJTKUGGCo=;
 b=IJE3pBmJji0iVAFBQnw3JQW8MYSTCacZpm5Ccf0MZeX6yPllnLEca8+z86HgdCTYI2hmb1K4LlgLt1cuqHqb0m2HX8iR2JJHcK/g5BkNgNDGN9+8vuhXQgWlceV+5d5fGn+71tVrvcrIDuXyddGdT4Jnwxgfk7avU/oHHWXe/G1xYHjmnRp6VMu7pGVmbOSp4cNwRC5iKjqRn0d5rlPjGjrJczaOS4jGZXr2Mxh02Bpd949pARcQ+LPdsHxB1n+/bHPzRBgD9+nBPXtv0aj0pQ1JGgZ1/Gp8w1lK4FjnsB6VW3+lr7jZAWrMkwB3S4CH7Zs5BRtojV/FSC+4gY65mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
 header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector2-armh-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xyG5Cjx1EThHy0twJv9yfg4+Rrkze1DsoTUJTKUGGCo=;
 b=HmOnJ1UEiAV4XhelGDwePParKi956bcikWJ0MvkYEkv+cWBN0KndxpTN1UL3TvnfdGBj5VYQnpL5M1d/uYnGC2c52zDyoXFEUYLM65JhRO7+2e4VzCbMmtMppDz+vq1n5eWTVKbL0PGsRvwJzbzL/OXO/yI+IuluZxeOW81rMY0=
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
Content-Type: text/plain;
	charset=utf-8
Subject: Re: [PATCH 4/5] tools/xl: Merge down debug/dry-run section of
 create_domain()
From: Luca Fancellu <luca.fancellu@arm.com>
In-Reply-To: <8f95e4a6664a24fd990cbb8162a1855c95cb6b66.1640590794.git.ehem+xen@m5p.com>
Date: Wed, 29 Dec 2021 17:19:49 +0000
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
 Wei Liu <wl@xen.org>,
 Anthony PERARD <anthony.perard@citrix.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E3266E44-16C1-49EB-BE71-2C9332FA5B75@arm.com>
References: <cover.1640590794.git.ehem+xen@m5p.com>
 <8f95e4a6664a24fd990cbb8162a1855c95cb6b66.1640590794.git.ehem+xen@m5p.com>
To: Elliott Mitchell <ehem+xen@m5p.com>
X-Mailer: Apple Mail (2.3693.20.0.1.32)
X-ClientProxiedBy: LO4P123CA0169.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:18a::12) To VI1PR0801MB2125.eurprd08.prod.outlook.com
 (2603:10a6:800:5b::23)
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: a3e20a39-1f0a-4459-18cb-08d9caef78d1
X-MS-TrafficTypeDiagnostic:
	VI1PR0802MB2336:EE_|DB5EUR03FT003:EE_|DBBPR08MB6313:EE_
X-Microsoft-Antispam-PRVS:
	<DBBPR08MB6313CCBB558AF7478282D7BAE4449@DBBPR08MB6313.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 9LAEDbwM75dQorCofynrlyUyucvkUCVrUR3YalVsInu/HlqHiumV5F4+LkbgltKNZMxIj5ssW26gp/H1lBoJboWIO/g3QJ7qo1p5I9VbT1f8CDinOoeaKu/s/6dGVjwd/4g8Umfs6gC+960R7/ScLYZ+4+63jIdwJQkx3QXSsgwJkwwTN1I2CLxGBIoPdIs7ySdjmVgt98lrpuW3+7l9TxcY/v7606JpxYaeukFIYhFfD7J3UNjhzDv+AKhMC+ROBeMBXDPCe9EJQRASGlcJmEZZR8hPK48kGfx6uUx5FOLHDXeNBdh9jBoaRYkvOYVCaEn2TYoZ/FeZ/V6rWUcOs/7DBp10rWxcWW2Nbjk7jvQSFiA1q/mItE0v/AxlKsyst272Rj/24qBOeDAsv0XsuQws8U6t8AnDlKq/eUcHj64mJmvHc/sVOaxxOevuwS5bQmLX8Myt+yZt+IWeYolOs5Syf53aZvFx4nin09iYA9DGIJn1l1ce0JHTY2gU8Tgqp6KRvi6EeAYJZweDukg5rt06aIAIbxIAdt0PCqQH1FgOhyrqpWuzhgO0gIk2W3FLtI2IkIlYID9dwrYb7xiMV+X7i7fJ7zo8udlF4hjWPwtYllky9hqs7zVik/zSf2G9bPNNbNwW2+5M5ifStgqUlo+Zp6A2OQQQJH8JgSKjxpPI5E7+wbIVxpTsL281vtz2axSLYl+bMtZl+vjQdB0ZU/ZVgAztLk4mJmBkBx0J+aY=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0801MB2125.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(36756003)(6506007)(53546011)(66476007)(54906003)(5660300002)(186003)(66946007)(44832011)(66556008)(26005)(2616005)(33656002)(38350700002)(38100700002)(86362001)(316002)(8676002)(6512007)(83380400001)(52116002)(8936002)(6666004)(2906002)(4326008)(508600001)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2336
Original-Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	c8aa2a32-8a2e-4a59-6027-08d9caef6f37
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gKnXTy7s5bLIVTLBC0448Bizi3X04u4LVWbgxICBV2syR3us7XaUoz4+VnAxozkZd59z/H1JvK4o1rOWi2ANJ/e01ZhsVWdyfGd1REhp6ZMfjiMDbQkTCOB/BpTsfCDei+fkh2cwSEgRFsyM9WlRUFABwbm1U/IKOvtcbCjma77HhwVkZxNb3G5KQYZ88FdSrRg6S80R+HGoZfXB0cpLSJEYL+dqYSID2HUL+PriJD/jxW3GbMXD/Apqua0fZgrr0mFXDglTWh0kh+oIscNAHfo8AmWPIJIxU1F1kXskNh6icaRIWKoUppmhGPjIplaJgvFCaLWzHQLSGQ2yZ8tHkyTfmz97qwJyMRreCxr58sCRrfyQkvBwndXXE51fZhVNlR4hPOLilFqeq/KdCXGvHszS9qCmXwHpbRjCKQt2qMUFgYMgKfudAsP0YGDKHiv1SVtP4bQDvwpakhC0jsTtopa2L3USVr5xg+mnJ3EWGA+9NHHUNtys6UFaN4zbOOIkbZssqxugZUph+AToT/bsUYYJcmVedgimAqzd0kjDYloFduZap3ABEqxP40bp4jC6TJCSwIPu5OaQrSC4JSB3WtIJ2/Hkzmdwe5kUgIQlnyfOiClTl1AS0CaKqF8u3yjzst89MWBoCD6v8/+s9EkysqvapWM9a3amW2eatBvu5Xbak3cAYG4SPI2pAJDhiu2ZkT1NiUVTTcRdFOPYxW3FPw==
X-Forefront-Antispam-Report:
	CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(36860700001)(54906003)(6486002)(53546011)(8936002)(316002)(2906002)(6506007)(83380400001)(356005)(6666004)(47076005)(5660300002)(336012)(186003)(4326008)(26005)(36756003)(44832011)(508600001)(107886003)(86362001)(81166007)(82310400004)(6512007)(70586007)(33656002)(70206006)(6862004)(2616005);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 17:20:12.2443
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: a3e20a39-1f0a-4459-18cb-08d9caef78d1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5EUR03FT003.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6313



> On 18 Dec 2020, at 01:42, Elliott Mitchell <ehem+xen@m5p.com> wrote:
>=20
> create_domain()'s use of printf_info_sexp() could be merged down to a
> single dump_by_config(), do so.  This results in an extra JSON dictionary
> in output, but I doubt that is an issue for dry-run or debugging output.
>=20

Don=E2=80=99t know if the extra output is a problem, but for me looks ok
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
> ---
> tools/xl/xl_vmcontrol.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>=20
> diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c
> index 435155a033..4b95e7e463 100644
> --- a/tools/xl/xl_vmcontrol.c
> +++ b/tools/xl/xl_vmcontrol.c
> @@ -856,19 +856,7 @@ int create_domain(struct domain_create *dom_info)
>=20
>     if (debug || dom_info->dryrun) {
>         FILE *cfg_print_fh =3D (debug && !dom_info->dryrun) ? stderr : st=
dout;
> -        if (default_output_format =3D=3D OUTPUT_FORMAT_SXP) {
> -            printf_info_sexp(-1, &d_config, cfg_print_fh);
> -        } else {
> -            char *json =3D libxl_domain_config_to_json(ctx, &d_config);
> -            if (!json) {
> -                fprintf(stderr,
> -                        "Failed to convert domain configuration to JSON\=
n");
> -                exit(1);
> -            }
> -            fputs(json, cfg_print_fh);
> -            free(json);
> -            flush_stream(cfg_print_fh);
> -        }
> +        dump_by_config(default_output_format, cfg_print_fh, &d_config, -=
1);
>     }
>=20
>=20
> --=20
> 2.30.2
>=20
>=20



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 18:04:17 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 18:04:17 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252399.433443 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2dIe-000178-RR; Wed, 29 Dec 2021 18:03:44 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252399.433443; Wed, 29 Dec 2021 18:03:44 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2dIe-000171-OM; Wed, 29 Dec 2021 18:03:44 +0000
Received: by outflank-mailman (input) for mailman id 252399;
 Wed, 29 Dec 2021 18:03:43 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2dIc-00016r-Vw; Wed, 29 Dec 2021 18:03:42 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2dIc-0005Vq-SA; Wed, 29 Dec 2021 18:03:42 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2dIc-0005iQ-DO; Wed, 29 Dec 2021 18:03:42 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2dIc-0001fX-Cw; Wed, 29 Dec 2021 18:03:42 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=QJGYVP37h/vym5Mw9b3YYTO8oT+dYMcY9y3Eu+oZ4lA=; b=Y5y7KKkTnUEUptvLD7aITteVgJ
	KV+y0Ib1v/pifmWJ/4gLs84TewjdrxAAstVjokoYMEfuAupPr5wwhzBxlCCVYlbdjv3TbensXaDcN
	FGcv1adYp3/ZXUhZaY+7fHGzhsrpOG/HzY6XmtAGgvzcx09yuLQ4Lb8rs2uNXY9n8IQ0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167557-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167557: regressions - trouble: broken/fail/pass
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-xl:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-arndale:<job status>:broken:regression
    linux-linus:test-armhf-armhf-xl-arndale:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-xl:host-install(5):broken:regression
    linux-linus:test-armhf-armhf-libvirt-raw:host-ping-check-xen:fail:regression
    linux-linus:test-arm64-arm64-libvirt-raw:guest-start:fail:regression
    linux-linus:test-armhf-armhf-libvirt-qcow2:debian-di-install:fail:regression
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e7c124bd04631973a3cc0df19ab881b56d8a2d50
X-Osstest-Versions-That:
    linux=a8ad9a2434dc7967ab285437f443cae633b6fc1c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 18:03:42 +0000

flight 167557 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167557/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-armhf-armhf-xl             <job status>                 broken
 test-armhf-armhf-xl-arndale     <job status>                 broken
 test-armhf-armhf-xl-arndale   5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-xl           5 host-install(5)        broken REGR. vs. 167548
 test-armhf-armhf-libvirt-raw 10 host-ping-check-xen      fail REGR. vs. 167548
 test-arm64-arm64-libvirt-raw 13 guest-start              fail REGR. vs. 167548
 test-armhf-armhf-libvirt-qcow2 12 debian-di-install      fail REGR. vs. 167548

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167548
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167548
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167548
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                e7c124bd04631973a3cc0df19ab881b56d8a2d50
baseline version:
 linux                a8ad9a2434dc7967ab285437f443cae633b6fc1c

Last test of basis   167548  2021-12-27 17:12:14 Z    2 days
Failing since        167553  2021-12-28 20:40:59 Z    0 days    2 attempts
Testing same since   167557  2021-12-29 07:32:10 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>
  Luiz Sampaio <sampaio.ime@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Miguel Ojeda <ojeda@kernel.org>
  Paul Moore <paul@paul-moore.com>
  Tom Rix <trix@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          broken  
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  broken  
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               fail    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary

broken-job test-armhf-armhf-xl broken
broken-job test-armhf-armhf-xl-arndale broken
broken-step test-armhf-armhf-xl-arndale host-install(5)
broken-step test-armhf-armhf-xl host-install(5)

Not pushing.

------------------------------------------------------------
commit e7c124bd04631973a3cc0df19ab881b56d8a2d50
Merge: ecf71de775a0 732bc2ff080c
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Dec 28 13:33:06 2021 -0800

    Merge tag 'selinux-pr-20211228' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux
    
    Pull selinux fix from Paul Moore:
     "One more small SELinux patch to address an uninitialized stack
      variable"
    
    * tag 'selinux-pr-20211228' of git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux:
      selinux: initialize proto variable in selinux_ip_postroute_compat()

commit ecf71de775a049cbfa6298deceb8ba2083331171
Merge: f651faaaba5f 4daa9ff89ef2
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Dec 28 11:46:15 2021 -0800

    Merge tag 'auxdisplay-for-linus-v5.16' of git://github.com/ojeda/linux
    
    Pull auxdisplay fixes from Miguel Ojeda:
     "A couple of improvements for charlcd:
    
       - check pointer before dereferencing
    
       - fix coding style issue"
    
    * tag 'auxdisplay-for-linus-v5.16' of git://github.com/ojeda/linux:
      auxdisplay: charlcd: checking for pointer reference before dereferencing
      auxdisplay: charlcd: fixing coding style issue

commit f651faaaba5f41ffac195e64f58483721e60eafc
Merge: a8ad9a2434dc 8d84fca4375e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue Dec 28 11:42:01 2021 -0800

    Merge tag 'powerpc-5.16-5' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
    
    Pull powerpc fix from Michael Ellerman:
     "Fix DEBUG_WX never reporting any WX mappings, due to use of an
      incorrect config symbol since we converted to using generic ptdump"
    
    * tag 'powerpc-5.16-5' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux:
      powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion

commit 732bc2ff080c447f8524f40c970c481f5da6eed3
Author: Tom Rix <trix@redhat.com>
Date:   Fri Dec 24 07:07:39 2021 -0800

    selinux: initialize proto variable in selinux_ip_postroute_compat()
    
    Clang static analysis reports this warning
    
    hooks.c:5765:6: warning: 4th function call argument is an uninitialized
                    value
            if (selinux_xfrm_postroute_last(sksec->sid, skb, &ad, proto))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    selinux_parse_skb() can return ok without setting proto.  The later call
    to selinux_xfrm_postroute_last() does an early check of proto and can
    return ok if the garbage proto value matches.  So initialize proto.
    
    Cc: stable@vger.kernel.org
    Fixes: eef9b41622f2 ("selinux: cleanup selinux_xfrm_sock_rcv_skb() and selinux_xfrm_postroute_last()")
    Signed-off-by: Tom Rix <trix@redhat.com>
    [PM: typo/spelling and checkpatch.pl description fixes]
    Signed-off-by: Paul Moore <paul@paul-moore.com>

commit 8d84fca4375e3c35dadc16b8c7eee6821b2a575c
Author: Michael Ellerman <mpe@ellerman.id.au>
Date:   Fri Dec 3 23:41:12 2021 +1100

    powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion
    
    In note_prot_wx() we bail out without reporting anything if
    CONFIG_PPC_DEBUG_WX is disabled.
    
    But CONFIG_PPC_DEBUG_WX was removed in the conversion to generic ptdump,
    we now need to use CONFIG_DEBUG_WX instead.
    
    Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
    Cc: stable@vger.kernel.org # v5.15+
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
    Link: https://lore.kernel.org/r/20211203124112.2912562-1-mpe@ellerman.id.au

commit 4daa9ff89ef27be43c15995412d6aee393a78200
Author: Luiz Sampaio <sampaio.ime@gmail.com>
Date:   Tue Nov 9 19:07:32 2021 -0300

    auxdisplay: charlcd: checking for pointer reference before dereferencing
    
    Check if the pointer lcd->ops->init_display exists before dereferencing it.
    If a driver called charlcd_init() without defining the ops, this would
    return segmentation fault, as happened to me when implementing a charlcd
    driver.  Checking the pointer before dereferencing protects from
    segmentation fault.
    
    Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
    Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

commit 94047df12fec0e51e860b5317223f67a3ea4eb07
Author: Luiz Sampaio <sampaio.ime@gmail.com>
Date:   Tue Nov 9 19:07:31 2021 -0300

    auxdisplay: charlcd: fixing coding style issue
    
    Removing 'int' from 'unsigned long int' declaration, which is unnecessary.
    
    Signed-off-by: Luiz Sampaio <sampaio.ime@gmail.com>
    Signed-off-by: Miguel Ojeda <ojeda@kernel.org>


From xen-devel-bounces@lists.xenproject.org Wed Dec 29 19:08:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 19:08:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252409.433455 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2eIW-00071s-Vq; Wed, 29 Dec 2021 19:07:40 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252409.433455; Wed, 29 Dec 2021 19:07:40 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2eIW-00071l-SP; Wed, 29 Dec 2021 19:07:40 +0000
Received: by outflank-mailman (input) for mailman id 252409;
 Wed, 29 Dec 2021 19:07:39 +0000
Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50]
 helo=se1-gles-flk1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=ukf9=RO=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n2eIU-00071f-TP
 for xen-devel@lists.xenproject.org; Wed, 29 Dec 2021 19:07:39 +0000
Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com
 [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS
 id 949c5a21-68da-11ec-bb0b-79c175774b5d;
 Wed, 29 Dec 2021 20:07:36 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 949c5a21-68da-11ec-bb0b-79c175774b5d
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640804856;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=yRoUmgbE9i76UflSqHjlOZ3F8eXRUOMPrXGKWnJhans=;
  b=ayglD7sJOdLKU5TKss8QtFtYhWNbutufoHWbp8etXJV7EjeRKvOsKw7K
   tyasDCVnRhImXpgLGvmwQfNJdYRPby8TpkOgNnY3o6ckmMPseB9bHhdea
   wS4thlrFe4wW4eK8EMMeRv/ohsmUhXJTpZQdzSEvd6wa9M4ErzFAA4aUC
   o=;
Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: TBHXD/b9039uUOhtaiwTirv3ANUsvMTKlAwLy7mvPAGtp8NCyU6XrkoTuuaj7aOM+1SKMXnSYb
 KRh5cLn9Cvogawm/+zITF7xoiyaZc3hy6Fq2lryexjw9KY5cvO7bOkYzA0DnS/up3ggreWLokC
 wxZmrcsQVlBB6k2LKC7uzED87D7KhHbAzoXrKlOLhVmRsIib0EhlZXfp7ZfQBnp3PunOj/S4GV
 +NF91LGutXYZGXNdX7eebHH1QRei75zgilUW0myCEmqd6DvkpMe9pC4mszCTrvUX0D1C5GM7Yt
 qWeRzPmrJY2gPmbVpwKfi7UD
X-SBRS: 5.1
X-MesageID: 61376760
X-Ironport-Server: esa1.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:6QCsAai6y2IuNKPxKouf/Cu/X161vhcKZh0ujC45NGQN5FlHY01je
 htvUTqOMv/cY2Tyeohyb4ywoUMB65aEy9NrTQdp/ChjESwb9cadCdqndUqhZCn6wu8v7a5EA
 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rg29Qy0IDia++wk
 YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq
 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx
 /10jpbpYANwYJHeo88ibiJ2FA5EHIR/reqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr
 KJCbmpXN1ba2rzwkOnTpupE36zPKOHxO4wSoDd4xCzxBvc6W5HTBa7N4Le02R9u35sRQ6mAP
 6L1bxJESQqZOz5rGmsRDZMUvMz1hHPGLQRh/Qf9Sa0fvDGIkV0ZPKLWGMrYfJmGSNtYmm6cp
 3na5CLpDxcCLtudxDGZtHW2iYfnkyLhVYcfCLC/7NZ3m1CJ3SoIDwAMXla1puO2hwi4Vs43F
 qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+NrGbQT7FjT9rjvyDmkPUYDYQRgQeVz4afaWgcW/
 lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1rXI9SfML
 ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb5NuRECnCBtJ6sybp1qHHb4
 xDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0mex43Y51bIme1C
 KM2he+3zMUMVJdNRfUpC79d9uxwlfSwfTgbfq68giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy
 r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M
 r93aqO39vmoeLGkP3SMr9dMdQtiwLpSLcmelvG7v9Wre2JOMGogF+XQ0fUmfYlklL5SjeDG4
 je2XUow9bY1rSSvxdyiZi8xZbXxc4x4qH5nbyUgMUzxgyooYJq17bdZfJwyJOF1+OtmxP9yb
 v8EZ8TfXagfFmWZo2wQPcvnsYhvVBW3ngbSbSCrVycyIsx7TAvT9966Iga2rHsSDjC6vNcVq
 qG70l+JWoIKQglvVZ6EaP+mw16rk2IaneZ+AxnBLtVJIR2++4l2MS3hyPQwJphUexnEwzKb0
 SeQAAsZ+raR89NkroGRiPnd/YmzEuZ4Ek5LJEXh7O67ZXvA426u4Y5cS+LULzrTY3z5pfe5b
 uJPwvCibPBexARWs5BxGqpAxL4l44e9vKdTywlpESmZb1mvDb88cHCK0dMW6/9Iz75d/wC3R
 liO6p9RPrDQYJHpF1sYJQwEaOWf1K5LxmmOvKpteEiqtjVq+LenUFlJO0jegSNQG7J5LYc5z
 Lpzo8UR8QG+1kInP9vuYvq4LIhQwqjsi5kai6w=
IronPort-HdrOrdr: A9a23:uPoGt689DXI5DbgnT89uk+DcI+orL9Y04lQ7vn2ZLiYlFfBw9v
 re+MjzsCWetN9/Yh0dcLy7V5VoIkm9yXcW2+cs1N6ZNWGN1VdAR7sC0aLShxHmBi3i5qp8+M
 5bAs1D4QTLfDtHZBDBkWuFL+o=
X-IronPort-AV: E=Sophos;i="5.88,246,1635220800"; 
   d="scan'208";a="61376760"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gJEsy4xU2+WOcGWdDw8bslZf/3FHj+k4W0hHgVhxFrgTK4mbUV65YKSTXumig/Vm0PDbOuuydc4YpNuQ92RKsYbKbsgidQgQL3oD3D9/D0P6Y4CXkAowWf8fcS1vFEQ7LF2CWQ4u/jZDK3P+yqMstKqXrWzVT+ZgOQTcPYOvZbOWX8/VFSTmjn0PxwVIIos8uD2U1+GdRU6t8joMqxpPClf9U+SNWnujiCK1dXaiRblIradz8cWp1I7DRs6P0BXS9RELDrj6v3+vGqC/nJjmi5TQhRZ9FAvQaZktRDmkwg8mZqnHVuZaf0WpRIko2dE3XJMB+tTT998dS3zO0yOGaQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=DDU7ZzoZ6hYOOYTZ6gpERclMmLJEmk0wLkROgnBZK0A=;
 b=VemgG2Qr09fCFN2TJe3nuJnY5i9Lg6FMr5T0wpHg0j73wx4or8UWhsGZzFs8AcUNVTA6GtwwCEtXsJikHtukH5+vX4+rkm/Ey4+/2rqYclPDopUP5+uAq12OfhEtIEQRz0xpbSBWRxkrtiL+HSXmLR2+Gj3QBXMuDm2t2HClkow9c7CbNOR1yFBoPMVF0yFUMyA5vERaa+qIC6yQNVeKtTasuE5RVm7CMEQk+GvBHxnRRaP24M7XWWzQpVKhJes2J/2x7p+V+aDASxZWvCAvBC92MZpOLzCufLKzdUV2OJ8r6O3dDdW8Hn2N76CAC8JNxDXeg0whbkeonrN05htH6g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DDU7ZzoZ6hYOOYTZ6gpERclMmLJEmk0wLkROgnBZK0A=;
 b=fFps3fznJeKu0vh1ZLHcNb4qnkIvSqFHA0GW2JUEsPdOhX9a+5098ORDNiKJBH0GeJeSl7O3a/T8pO/QuXCLGa6z52TUGkfuq1Igf1J36fiWcV/PWotPTQH7exIKUfi4nyV+OcmNN8ZUMf7BrVXQegehtl/oGM/viz369wy1ZUs=
Date: Wed, 29 Dec 2021 20:07:23 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <Ycyx65BDakqWmEe+@Air-de-Roger>
References: <YcInKtCNgA9v0k+c@Air-de-Roger>
 <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger>
 <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger>
 <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger>
 <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
 <Ycw4Jna5J2iQJyeM@Air-de-Roger>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Ycw4Jna5J2iQJyeM@Air-de-Roger>
X-ClientProxiedBy: MR2P264CA0075.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:32::15) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ea76b6e3-3013-41cd-34bc-08d9cafe75c3
X-MS-TrafficTypeDiagnostic: DM6PR03MB4059:EE_
X-Microsoft-Antispam-PRVS: <DM6PR03MB405917F134BB8A22912157708F449@DM6PR03MB4059.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:267;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: v7KkYZzlbh9/OdzmMFpkRjYrP1SKg7udzKVYwkox9gLxTg7PM8rkUqKhw40Lwq3TQI2Z9vxGElL1cn4ST+k3+Q1SN+Fw7fa5UTP7IA/Mnck5c6sHmYM5xVRvwY1/Esgmrm08z2ixuyaPzrYhw7d/6WxFNhht27in3/dr5WC8vJtJtaiNLOIRXR6YANIHeEHYamyn+atEQcYhCx8xmXdEcnzvzXHO5MZWr93y2RUmS1R8GKBBVysHP0IViq4WieNGFCPieR2E9+0XOQ2KJ2MFykv4Z1OOamvjZ2SHjb5e3apcGaym2Qnwol+ac89sF/wkLPpU0yYXixV3xOKRcHfbvRkVXBCzhof42gDXzZ2Z7qW1N64w2sdpTYqj/p6JO5EYgSQXiJ6/gyIi28OcpHWC+N4L5Zakis941vwU6Rr13UD5I4RbGbiIxP79tfa14RRQ9QES5WH0fpEZYrjESkf6KDpJZmBK6Y1CBKI2QLPZQjXKgCjloHnO0NkhyjHSWMacAEoYlAmU8qH7du3AjIIdT0MKzo040d2uDkEUUyBMQKLsVIK0dHwnfjdzd4GqbzhmWQaTOmxiECaitcJsNltrd1sP3zhyK9wMtD6XtRhUFBDZYJNg0oeGkbnM8VEgsg2ZHqxEoj3VEslPTgV3R+Slgg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(366004)(86362001)(26005)(2906002)(6916009)(316002)(6486002)(6666004)(6506007)(38100700002)(83380400001)(5660300002)(4326008)(6512007)(9686003)(33716001)(66476007)(508600001)(66946007)(85182001)(8936002)(66556008)(186003)(8676002)(82960400001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHJvWGhHQ1ZhbVRJS2pLMm0rbThvUGJBTHdjRjM4NTZEVitGbFhCNzJvbnpB?=
 =?utf-8?B?TXQya0FzVmlENUwvdnFhcXdNNmRuY2gxV3FzclE5eTVtMGdvaWFibmY2V1Nw?=
 =?utf-8?B?L3ZxYUg1RlpPVjFmUytXTHN6WDJOODBxZFBwYlU0UUloUVhMOXh4WFo0aisw?=
 =?utf-8?B?Y1hFaURSV3dacHVQMk5vTTNndjVMcHhRYlZGSEVtYmtNQ3dVM2JRYkpPZDZx?=
 =?utf-8?B?czBUT3JkbkdlTzMzMXBGeUxmc05LUjJXbkNtUXFyNU1tR1RVem82amRiaVdF?=
 =?utf-8?B?QTJ3TmtGakJqQnBDQkJ2NExzVjZBaU5QdTNzb21oT3Z5Nk5ZY0tlNGt1VGVV?=
 =?utf-8?B?aStZWUppL3RhV2RBUzRiREdCOTkvb0pqSXJBQ3JQRzFCcEFQZEpQb2VIMmpU?=
 =?utf-8?B?WHM4VFcrekFHT3ZDb3ZBYzI0SnZqblY2Tzk3RTRPdzg2ZkJzakl1OTkwSFdk?=
 =?utf-8?B?OG1TZXZYVXYvZUZ6aHVkQW11MmorNm16WTJYcG5od0VFdWpxL0dYTUNkdEg2?=
 =?utf-8?B?ZFVZRk1SY3FDNnNCL0x5NDd1bEhhcGxuSkNMOVNmay9CTmJtbkJadXZuc0tt?=
 =?utf-8?B?Z1c0Vm1WR3NUa2NYUXIya3AvOGlNckQ0clFOTFd6M2krTFVqaSt4NllwL0w1?=
 =?utf-8?B?TjM4cGFmTk5ndXZkZ3c4Q0xTK1pvR1VySlBmcGxwMFVBT3VrVE1nL0xVYVdZ?=
 =?utf-8?B?ODNFZFRHR2tmazVna2lSOE1hRjlBRVBjV3MvZG5VbW1JMFhiT002TGJiUDVq?=
 =?utf-8?B?Z1NJVGM0Y2VyODJqRWdwUG9PRGcwYzZpYjRONUdNWVV1ZDJEVkxseVduMSsv?=
 =?utf-8?B?eXB4MkJKU1M4clJmejZzaHBWRGRsMVZ5WFBuakxhL21odUJpcVVuM1VzWXRt?=
 =?utf-8?B?ODdrWHk1TGFFUGFVdGpyaFRqVXpHOUEvSTZEWERQTksvZHp0aFh4MnlZc3h1?=
 =?utf-8?B?bTNDNm9vSm56NXhQZ2JVM0d6cEdJUVFYY2lXVm5tUkVkOTVuZjFLOVpudWdq?=
 =?utf-8?B?OHR1eXBNOW54RmZuVGQ1U25YTmgrWTZxb2kvaUV5MDFyb3BsenNwMTdGdXVj?=
 =?utf-8?B?NDE1cDRrZUJ2TS9lUGRqT0dRbWdhU1ZZYnlMOGVTSy9abEd1UGovazVKYytX?=
 =?utf-8?B?T3RvK0hVT3FzdUl0ZThzZTBCdndkWDFtZmROTjRsQkZpVzMwR2RkVDhGM0RL?=
 =?utf-8?B?MjRUc0Z3QzliSjBuZS95K0krblNtaXR2RE10ZVpKTHZ1cDdkeW9TaE5qcDNr?=
 =?utf-8?B?a2twaEV3OGpCOEFDWXpWZFcvbnVFUVd1RXdWbERrWXdmbFpiMFNjUmZLcDB2?=
 =?utf-8?B?dm0weVVzdTZQV1ZUNFViSnpsaHNSTXpkTEJad1BPV0NUbFU2ZmRkMkN1MWZH?=
 =?utf-8?B?dlNIT0hMZ1R5ZzFDcWZwNVdDdThwbXRSRlQrRk16Mnp0NmdWdmFWMm5HL1Ir?=
 =?utf-8?B?N0tubGJGSzd1aSt0ZUU1UE5BR1M2SmFRZ01idnZjVmxlY1Y5clk5N3AyMjBk?=
 =?utf-8?B?R05jWkNYUnBxcHhVejgxbS92VHo2T2N0ZTVqMkxhNjQrY0Q2b1k1UnRsdHZK?=
 =?utf-8?B?djdObjhqYUtReVUzZmdQQVVvZjYzaDh4TnIxempUbDZERjU5Q0V4ZFpGajF3?=
 =?utf-8?B?SnBKTUVZYlg1NkZBb0RCb1pNQUtVZ2dLOW80VlhlOXg2d0pyTTd6SS9xYmpj?=
 =?utf-8?B?SE5kV090a28zK0t0bmVQMWxVSVBhTy9mcnE0ekdHdWZ0RzRucXU1NUdhanN3?=
 =?utf-8?B?UEpBVStjSkgwcWp5RHhYNkUyU2tWUlV3UVF3bHRDOE1YWkxlQ1g1RDNOcWkv?=
 =?utf-8?B?RTI1UzdrWHZNNUVKK1N2QUVqcStRNU1vQkVMbG8wZmRTS2lReHN6OUlVR3Z2?=
 =?utf-8?B?R2FmVGN6WUU2bEw3d21MVmQ3OGxGMkt3dXJ3V0ZEblp1ZCs4a01pRWJJekNj?=
 =?utf-8?B?dUFqcTZ6eVo4MzU1UjF3bVYwc3lDZWUzZThMd3kyLzRxT2MvVnlLcjlEN0Fs?=
 =?utf-8?B?c01kOHVWMk8xTnNnQjU0TE4vUGo4emt1QkN6NDFsTTR6MVBDR2szWFhpbWVo?=
 =?utf-8?B?V21TYkFVRVk2UXdPZzQzYkhzNk44SkRzRlRodkNoekQ0NWR0UHUrV3dzYkN0?=
 =?utf-8?B?UE5MUWE4R2VLNW4wLzZLN3BFUmNoVktBU0ZVZUtIRmpDcHVqb005WWUrQjRR?=
 =?utf-8?Q?Cm255qQFNby10fztQWXv6dg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea76b6e3-3013-41cd-34bc-08d9cafe75c3
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2021 19:07:29.8366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Znw0/ftl7W1SdefBVWaAmOnQh1s14Rg4F560OT6Is49Rrs7mg+0mElPJCgbbQToKGgVDO+bvQtRqLa5rEveN/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4059
X-OriginatorOrg: citrix.com

On Wed, Dec 29, 2021 at 11:27:50AM +0100, Roger Pau Monné wrote:
> On Wed, Dec 29, 2021 at 05:13:00PM +0800, G.R. wrote:
> > >
> > > I think this is hitting a KASSERT, could you paste the text printed as
> > > part of the panic (not just he backtrace)?
> > >
> > > Sorry this is taking a bit of time to solve.
> > >
> > > Thanks!
> > >
> > Sorry that I didn't make it clear in the first place.
> > It is the same cross boundary assertion.
> 
> I see. After looking at the code it seems like sglist will coalesce
> contiguous physical ranges without taking page boundaries into
> account, which is not suitable for our purpose here. I guess I will
> either have to modify sglist, or switch to using bus_dma. The main
> problem with using bus_dma is that it will require bigger changes to
> netfront I think.

I have a crappy patch to use bus_dma. It's not yet ready for upstream
but you might want to give it a try to see if it solves the cross page
boundary issues.

Thanks, Roger.
---
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c
index 8dba5a8dc6d5..693ef25c8783 100644
--- a/sys/dev/xen/netfront/netfront.c
+++ b/sys/dev/xen/netfront/netfront.c
@@ -71,6 +71,8 @@ __FBSDID("$FreeBSD$");
 #include <xen/interface/io/netif.h>
 #include <xen/xenbus/xenbusvar.h>
 
+#include <machine/bus.h>
+
 #include "xenbus_if.h"
 
 /* Features supported by all backends.  TSO and LRO can be negotiated */
@@ -199,6 +201,12 @@ struct netfront_txq {
 	struct taskqueue 	*tq;
 	struct task       	defrtask;
 
+	bus_dmamap_t		dma_map;
+	struct mbuf_refcount {
+		struct m_tag 	tag;
+		u_int 		count;
+	}			refcount_tag[NET_TX_RING_SIZE + 1];
+
 	bool			full;
 };
 
@@ -221,6 +229,8 @@ struct netfront_info {
 
 	struct ifmedia		sc_media;
 
+	bus_dma_tag_t		dma_tag;
+
 	bool			xn_reset;
 };
 
@@ -301,6 +311,39 @@ xn_get_rx_ref(struct netfront_rxq *rxq, RING_IDX ri)
 	return (ref);
 }
 
+#define MTAG_COOKIE 1218492000
+#define MTAG_REFCOUNT 0
+
+static void mbuf_grab(struct mbuf *m)
+{
+	struct mbuf_refcount *ref;
+
+	ref = (struct mbuf_refcount *)m_tag_locate(m, MTAG_COOKIE,
+	    MTAG_REFCOUNT, NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	ref->count++;
+}
+
+static void mbuf_release(struct mbuf *m)
+{
+	struct mbuf_refcount *ref;
+
+	ref = (struct mbuf_refcount *)m_tag_locate(m, MTAG_COOKIE,
+	    MTAG_REFCOUNT, NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	KASSERT(ref->count > 0, ("Invalid reference count"));
+
+	if (--ref->count == 0)
+		m_freem(m);
+}
+
+static void tag_free(struct m_tag *t)
+{
+	struct mbuf_refcount *ref = (struct mbuf_refcount *)t;
+
+	KASSERT(ref->count == 0, ("Free mbuf tag with pending refcnt"));
+}
+
 #define IPRINTK(fmt, args...) \
     printf("[XEN] " fmt, ##args)
 #ifdef INVARIANTS
@@ -783,6 +826,7 @@ destroy_txq(struct netfront_txq *txq)
 	buf_ring_free(txq->br, M_DEVBUF);
 	taskqueue_drain_all(txq->tq);
 	taskqueue_free(txq->tq);
+	bus_dmamap_destroy(txq->info->dma_tag, txq->dma_map);
 }
 
 static void
@@ -826,6 +870,11 @@ setup_txqs(device_t dev, struct netfront_info *info,
 		for (i = 0; i <= NET_TX_RING_SIZE; i++) {
 			txq->mbufs[i] = (void *) ((u_long) i+1);
 			txq->grant_ref[i] = GRANT_REF_INVALID;
+			m_tag_setup(&txq->refcount_tag[i].tag,
+			    MTAG_COOKIE, MTAG_REFCOUNT,
+			    sizeof(txq->refcount_tag[i]) -
+			    sizeof(txq->refcount_tag[i].tag));
+			txq->refcount_tag[i].tag.m_tag_free = &tag_free;
 		}
 		txq->mbufs[NET_TX_RING_SIZE] = (void *)0;
 
@@ -874,10 +923,18 @@ setup_txqs(device_t dev, struct netfront_info *info,
 			device_printf(dev, "xen_intr_alloc_and_bind_local_port failed\n");
 			goto fail_bind_port;
 		}
+
+		error = bus_dmamap_create(info->dma_tag, 0, &txq->dma_map);
+		if (error != 0) {
+			device_printf(dev, "failed to create dma map\n");
+			goto fail_dma_map;
+		}
 	}
 
 	return (0);
 
+fail_dma_map:
+	xen_intr_unbind(&txq->xen_intr_handle);
 fail_bind_port:
 	taskqueue_drain_all(txq->tq);
 fail_start_thread:
@@ -1041,7 +1098,7 @@ xn_release_tx_bufs(struct netfront_txq *txq)
 		if (txq->mbufs_cnt < 0) {
 			panic("%s: tx_chain_cnt must be >= 0", __func__);
 		}
-		m_free(m);
+		mbuf_release(m);
 	}
 }
 
@@ -1311,7 +1368,7 @@ xn_txeof(struct netfront_txq *txq)
 			txq->mbufs[id] = NULL;
 			add_id_to_freelist(txq->mbufs, id);
 			txq->mbufs_cnt--;
-			m_free(m);
+			mbuf_release(m);
 			/* Only mark the txq active if we've freed up at least one slot to try */
 			ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 		}
@@ -1530,27 +1587,18 @@ xn_count_frags(struct mbuf *m)
 static int
 xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 {
-	struct mbuf *m;
 	struct netfront_info *np = txq->info;
 	struct ifnet *ifp = np->xn_ifp;
-	u_int nfrags;
-	int otherend_id;
+	int otherend_id, error, nfrags;
+	unsigned int i;
+	bus_dma_segment_t segs[MAX_TX_REQ_FRAGS];
 
-	/**
-	 * Defragment the mbuf if necessary.
-	 */
-	nfrags = xn_count_frags(m_head);
+	error = bus_dmamap_load_mbuf_sg(np->dma_tag, txq->dma_map, m_head,
+	    segs, &nfrags, 0);
+	if (error == EFBIG || nfrags > np->maxfrags) {
+		struct mbuf *m;
 
-	/*
-	 * Check to see whether this request is longer than netback
-	 * can handle, and try to defrag it.
-	 */
-	/**
-	 * It is a bit lame, but the netback driver in Linux can't
-	 * deal with nfrags > MAX_TX_REQ_FRAGS, which is a quirk of
-	 * the Linux network stack.
-	 */
-	if (nfrags > np->maxfrags) {
+		bus_dmamap_unload(np->dma_tag, txq->dma_map);
 		m = m_defrag(m_head, M_NOWAIT);
 		if (!m) {
 			/*
@@ -1561,15 +1609,18 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			return (EMSGSIZE);
 		}
 		m_head = m;
+		error = bus_dmamap_load_mbuf_sg(np->dma_tag, txq->dma_map,
+		    m_head, segs, &nfrags, 0);
+		if (error != 0 || nfrags > np->maxfrags) {
+			bus_dmamap_unload(np->dma_tag, txq->dma_map);
+			m_freem(m_head);
+			return (error ?: EFBIG);
+		}
+	} else if (error != 0) {
+		m_freem(m_head);
+		return (error);
 	}
 
-	/* Determine how many fragments now exist */
-	nfrags = xn_count_frags(m_head);
-
-	/*
-	 * Check to see whether the defragmented packet has too many
-	 * segments for the Linux netback driver.
-	 */
 	/**
 	 * The FreeBSD TCP stack, with TSO enabled, can produce a chain
 	 * of mbufs longer than Linux can handle.  Make sure we don't
@@ -1604,9 +1655,8 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 	 * the fragment pointers. Stop when we run out
 	 * of fragments or hit the end of the mbuf chain.
 	 */
-	m = m_head;
 	otherend_id = xenbus_get_otherend_id(np->xbdev);
-	for (m = m_head; m; m = m->m_next) {
+	for (i = 0; i < nfrags; i++) {
 		netif_tx_request_t *tx;
 		uintptr_t id;
 		grant_ref_t ref;
@@ -1621,17 +1671,22 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 		if (txq->mbufs_cnt > NET_TX_RING_SIZE)
 			panic("%s: tx_chain_cnt must be <= NET_TX_RING_SIZE\n",
 			    __func__);
-		txq->mbufs[id] = m;
+		if (i == 0)
+			m_tag_prepend(m_head, &txq->refcount_tag[id].tag);
+		mbuf_grab(m_head);
+		txq->mbufs[id] = m_head;
 		tx->id = id;
 		ref = gnttab_claim_grant_reference(&txq->gref_head);
 		KASSERT((short)ref >= 0, ("Negative ref"));
-		mfn = virt_to_mfn(mtod(m, vm_offset_t));
+		mfn = atop(segs[i].ds_addr);
 		gnttab_grant_foreign_access_ref(ref, otherend_id,
 		    mfn, GNTMAP_readonly);
 		tx->gref = txq->grant_ref[id] = ref;
-		tx->offset = mtod(m, vm_offset_t) & (PAGE_SIZE - 1);
+		tx->offset = segs[i].ds_addr & PAGE_MASK;
+		KASSERT(tx->offset + segs[i].ds_len <= PAGE_SIZE,
+		    ("mbuf segment crosses a page boundary"));
 		tx->flags = 0;
-		if (m == m_head) {
+		if (i == 0) {
 			/*
 			 * The first fragment has the entire packet
 			 * size, subsequent fragments have just the
@@ -1640,7 +1695,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * subtracting the sizes of the other
 			 * fragments.
 			 */
-			tx->size = m->m_pkthdr.len;
+			tx->size = m_head->m_pkthdr.len;
 
 			/*
 			 * The first fragment contains the checksum flags
@@ -1654,12 +1709,12 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * so we have to test for CSUM_TSO
 			 * explicitly.
 			 */
-			if (m->m_pkthdr.csum_flags
+			if (m_head->m_pkthdr.csum_flags
 			    & (CSUM_DELAY_DATA | CSUM_TSO)) {
 				tx->flags |= (NETTXF_csum_blank
 				    | NETTXF_data_validated);
 			}
-			if (m->m_pkthdr.csum_flags & CSUM_TSO) {
+			if (m_head->m_pkthdr.csum_flags & CSUM_TSO) {
 				struct netif_extra_info *gso =
 					(struct netif_extra_info *)
 					RING_GET_REQUEST(&txq->ring,
@@ -1667,7 +1722,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 
 				tx->flags |= NETTXF_extra_info;
 
-				gso->u.gso.size = m->m_pkthdr.tso_segsz;
+				gso->u.gso.size = m_head->m_pkthdr.tso_segsz;
 				gso->u.gso.type =
 					XEN_NETIF_GSO_TYPE_TCPV4;
 				gso->u.gso.pad = 0;
@@ -1677,13 +1732,14 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 				gso->flags = 0;
 			}
 		} else {
-			tx->size = m->m_len;
+			tx->size = segs[i].ds_len;
 		}
-		if (m->m_next)
+		if (i != nfrags - 1)
 			tx->flags |= NETTXF_more_data;
 
 		txq->ring.req_prod_pvt++;
 	}
+	bus_dmamap_unload(np->dma_tag, txq->dma_map);
 	BPF_MTAP(ifp, m_head);
 
 	if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1);
@@ -2244,7 +2300,20 @@ create_netdev(device_t dev)
     	ether_ifattach(ifp, np->mac);
 	netfront_carrier_off(np);
 
-	return (0);
+	err = bus_dma_tag_create(
+	    bus_get_dma_tag(dev),		/* parent */
+	    1, PAGE_SIZE,			/* algnmnt, boundary */
+	    BUS_SPACE_MAXADDR,			/* lowaddr */
+	    BUS_SPACE_MAXADDR,			/* highaddr */
+	    NULL, NULL,				/* filter, filterarg */
+	    PAGE_SIZE * MAX_TX_REQ_FRAGS,	/* max request size */
+	    MAX_TX_REQ_FRAGS,			/* max segments */
+	    PAGE_SIZE,				/* maxsegsize */
+	    BUS_DMA_ALLOCNOW,			/* flags */
+	    NULL, NULL,				/* lockfunc, lockarg */
+	    &np->dma_tag);
+
+	return (err);
 
 error:
 	KASSERT(err != 0, ("Error path with no error code specified"));
@@ -2277,6 +2346,7 @@ netif_free(struct netfront_info *np)
 	if_free(np->xn_ifp);
 	np->xn_ifp = NULL;
 	ifmedia_removeall(&np->sc_media);
+	bus_dma_tag_destroy(np->dma_tag);
 }
 
 static void



From xen-devel-bounces@lists.xenproject.org Wed Dec 29 23:35:23 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Wed, 29 Dec 2021 23:35:23 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252414.433466 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2iT0-0005mI-7G; Wed, 29 Dec 2021 23:34:46 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252414.433466; Wed, 29 Dec 2021 23:34:46 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2iT0-0005mB-3E; Wed, 29 Dec 2021 23:34:46 +0000
Received: by outflank-mailman (input) for mailman id 252414;
 Wed, 29 Dec 2021 23:34:45 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2iSz-0005m1-A2; Wed, 29 Dec 2021 23:34:45 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2iSz-0002ch-6K; Wed, 29 Dec 2021 23:34:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2iSy-00007l-RF; Wed, 29 Dec 2021 23:34:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2iSy-0001Gs-Qm; Wed, 29 Dec 2021 23:34:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=fwau43bO4qaEmD1dMRQpV1XvjuOy9j1iKw2t//sZU4I=; b=p7EgblpSn2uDTbRPT2J36WTeZ1
	zBC/gd/578cTALca+Fb92lOPTC+Sz/ZeMs+GHd/dXQTbbIK7UVz/NioAET41h3QoIwNslw6emhDo8
	7A4EeScsmAIiepokghAFv/7Ooc2ceqW/9jdlVtyEDM7tFubaCzdk37VGdPKbpYKVIh2I=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167558-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167558: regressions - FAIL
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:regression
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4ca2eaf1d477ce4316989b22e765fb915652b86e
X-Osstest-Versions-That:
    linux=8f843cf57202d0db77b31adb8d2ebb93690e91f2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Wed, 29 Dec 2021 23:34:44 +0000

flight 167558 linux-5.4 real [real]
flight 167561 linux-5.4 real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167558/
http://logs.test-lab.xenproject.org/osstest/logs/167561/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail REGR. vs. 167516

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167516
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167516
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167516
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167516
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167516
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167516
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167516
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167516
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167516
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167516
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167516
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167516
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4ca2eaf1d477ce4316989b22e765fb915652b86e
baseline version:
 linux                8f843cf57202d0db77b31adb8d2ebb93690e91f2

Last test of basis   167516  2021-12-22 08:44:19 Z    7 days
Testing same since   167558  2021-12-29 11:42:58 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Andrea Righi <andrea.righi@canonical.com>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Ryabinin <arbn@yandex-team.com>
  Ard Biesheuvel <ardb@kernel.org>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Borislav Petkov <bp@suse.de>
  Bradley Scott <Bradley.Scott@zebra.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wens@csie.org>
  Colin Ian King <colin.i.king@gmail.com>
  Corey Minyard <cminyard@mvista.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  David Rientjes <rientjes@google.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Fabien Dessenne <fabien.dessenne@foss.st.com>
  Fernando Fernandez Mancera <ffmancera@riseup.net>
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Jesionowski <jesionowskigreg@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
  Hanjie Wu <nagi@zju.edu.cn>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jens Wiklander <jens.wiklander@linaro.org>
  Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
  Ji-Ze Hong (Peter Hong) <hpeter@gmail.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  John David Anglin <dave.anglin@bell.net>
  Josh Lehan <krellan@google.com>
  José Expósito <jose.exposito89@gmail.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marian Postevca <posteuca@mutex.one>
  Mark Brown <broonie@kernel.org>
  Martin Habets <habetsm.xilinx@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Mian Yousaf Kaukab <ykaukab@suse.de>
  Michal Hocko <mhocko@suse.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Prathamesh Shete <pshete@nvidia.com>
  Robert Marko <robert.marko@sartura.hr>
  Ron Goossens <rgoossens@gmail.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rémi Denis-Courmont <remi@remlab.net>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sean Christopherson <seanjc@google.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sumit Garg <sumit.garg@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Willem de Bruijn <willemb@google.com>
  Wu Bo <wubo40@huawei.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Zhiyong Tao <zhiyong.tao@mediatek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        fail    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 1423 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 05:05:32 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 05:05:32 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252429.433489 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ncc-0004sd-VO; Thu, 30 Dec 2021 05:05:02 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252429.433489; Thu, 30 Dec 2021 05:05:02 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ncc-0004sC-O3; Thu, 30 Dec 2021 05:05:02 +0000
Received: by outflank-mailman (input) for mailman id 252429;
 Thu, 30 Dec 2021 05:05:00 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2nca-0004s2-Sy; Thu, 30 Dec 2021 05:05:00 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2nca-0002lH-QU; Thu, 30 Dec 2021 05:05:00 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2nca-0007UF-F4; Thu, 30 Dec 2021 05:05:00 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2nca-00021X-Ec; Thu, 30 Dec 2021 05:05:00 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=aJ1L+uMsjFjqovrd426tXl1XWAAp5qUKieGMu1GP7qo=; b=TZFspLeePuWdVOtfLSgpyJmLG5
	26m8wICu+lk9kU6hGGGonW2hl4272HVSB0N8rZeZOvFH389NXpIT1SFGiDt6mt6WI3MRx3VbxwTC1
	4lkXNam5Kko7FZ0Yj2QYKFdzf1VZfiiYraW+nhWNp4sotAMMtoLksEaSe7xQFEbF3GDw=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167560-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167560: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-armhf-armhf-libvirt-raw:debian-di-install:fail:heisenbug
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=e7c124bd04631973a3cc0df19ab881b56d8a2d50
X-Osstest-Versions-That:
    linux=a8ad9a2434dc7967ab285437f443cae633b6fc1c
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 05:05:00 +0000

flight 167560 linux-linus real [real]
flight 167567 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167560/
http://logs.test-lab.xenproject.org/osstest/logs/167567/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-armhf-armhf-libvirt-raw 12 debian-di-install   fail pass in 167567-retest

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 167567 like 167548
 test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 167567 never pass
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167548
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167548
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167548
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167548
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167548
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                e7c124bd04631973a3cc0df19ab881b56d8a2d50
baseline version:
 linux                a8ad9a2434dc7967ab285437f443cae633b6fc1c

Last test of basis   167548  2021-12-27 17:12:14 Z    2 days
Failing since        167553  2021-12-28 20:40:59 Z    1 days    3 attempts
Testing same since   167557  2021-12-29 07:32:10 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Linus Torvalds <torvalds@linux-foundation.org>
  Luiz Sampaio <sampaio.ime@gmail.com>
  Michael Ellerman <mpe@ellerman.id.au>
  Miguel Ojeda <ojeda@kernel.org>
  Paul Moore <paul@paul-moore.com>
  Tom Rix <trix@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 fail    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   a8ad9a2434dc..e7c124bd0463  e7c124bd04631973a3cc0df19ab881b56d8a2d50 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 09:37:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 09:37:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252453.433500 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2rrQ-0004Fa-Pi; Thu, 30 Dec 2021 09:36:36 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252453.433500; Thu, 30 Dec 2021 09:36:36 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2rrQ-0004FT-Md; Thu, 30 Dec 2021 09:36:36 +0000
Received: by outflank-mailman (input) for mailman id 252453;
 Thu, 30 Dec 2021 09:36:35 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2rrO-0004FJ-UN; Thu, 30 Dec 2021 09:36:34 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2rrO-0007o7-8i; Thu, 30 Dec 2021 09:36:34 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2rrN-00033D-UY; Thu, 30 Dec 2021 09:36:34 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2rrN-00074e-Tq; Thu, 30 Dec 2021 09:36:33 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=kVhGF3gS4fwttaY+cXMIHK636IdfPBkiU5fuyw9koiQ=; b=BICnfXIguQBn7+gsuiKu1dL626
	8WwNQCMU2VkFtwFPTiBl5ZdMb+/TeesdwF/FBP5wUY7frGFnHAAODgcJ0bc0pQra8FW0ErvgYBrik
	kzzxzMxi3ghq8C0a9cEbQAF+xb2H+xzxAAO+54FqpAm8RiXCxtEzcw9d57GwdqjEzJi0=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167562-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-5.4 test] 167562: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-5.4:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-localmigrate/x10:fail:heisenbug
    linux-5.4:test-arm64-arm64-libvirt-raw:guest-start.2:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:debian-di-install:fail:heisenbug
    linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4ca2eaf1d477ce4316989b22e765fb915652b86e
X-Osstest-Versions-That:
    linux=8f843cf57202d0db77b31adb8d2ebb93690e91f2
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 09:36:33 +0000

flight 167562 linux-5.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167562/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 18 guest-localmigrate/x10 fail in 167558 pass in 167562
 test-arm64-arm64-libvirt-raw 18 guest-start.2              fail pass in 167558
 test-armhf-armhf-xl-vhd      12 debian-di-install          fail pass in 167558

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-xl-vhd     14 migrate-support-check fail in 167558 never pass
 test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 167558 never pass
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167516
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167516
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167516
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167516
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167516
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167516
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167516
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167516
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167516
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167516
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167516
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167516
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 linux                4ca2eaf1d477ce4316989b22e765fb915652b86e
baseline version:
 linux                8f843cf57202d0db77b31adb8d2ebb93690e91f2

Last test of basis   167516  2021-12-22 08:44:19 Z    8 days
Testing same since   167558  2021-12-29 11:42:58 Z    0 days    2 attempts

------------------------------------------------------------
People who touched revisions under test:
  Adrian Hunter <adrian.hunter@intel.com>
  Andrea Righi <andrea.righi@canonical.com>
  Andrew Cooper <andrew.cooper3@citrix.com>
  Andrew Morton <akpm@linux-foundation.org>
  Andrey Ryabinin <arbn@yandex-team.com>
  Ard Biesheuvel <ardb@kernel.org>
  Benjamin Tissoires <benjamin.tissoires@redhat.com>
  Borislav Petkov <bp@suse.de>
  Bradley Scott <Bradley.Scott@zebra.com>
  Chao Yu <chao@kernel.org>
  Chen-Yu Tsai <wens@csie.org>
  Colin Ian King <colin.i.king@gmail.com>
  Corey Minyard <cminyard@mvista.com>
  Dave Hansen <dave.hansen@linux.intel.com>
  David Rientjes <rientjes@google.com>
  David S. Miller <davem@davemloft.net>
  Dmitry Torokhov <dmitry.torokhov@gmail.com>
  Dongliang Mu <mudongliangabcd@gmail.com>
  Fabien Dessenne <fabien.dessenne@foss.st.com>
  Fernando Fernandez Mancera <ffmancera@riseup.net>
  Florian Fainelli <f.fainelli@gmail.com>
  Greg Jesionowski <jesionowskigreg@gmail.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Guenter Roeck <linux@roeck-us.net>
  Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
  Hanjie Wu <nagi@zju.edu.cn>
  Helge Deller <deller@gmx.de>
  Hulk Robot <hulkrobot@huawei.com>
  Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr>
  Jaegeuk Kim <jaegeuk@kernel.org>
  Jakub Kicinski <kuba@kernel.org>
  Jason Gunthorpe <jgg@nvidia.com>
  Jay Vosburgh <jay.vosburgh@canonical.com>
  Jens Wiklander <jens.wiklander@linaro.org>
  Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
  Ji-Ze Hong (Peter Hong) <hpeter@gmail.com>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  John David Anglin <dave.anglin@bell.net>
  Josh Lehan <krellan@google.com>
  José Expósito <jose.exposito89@gmail.com>
  Lin Ma <linma@zju.edu.cn>
  Linus Torvalds <torvalds@linux-foundation.org>
  Linus Walleij <linus.walleij@linaro.org>
  Linux Kernel Functional Testing <lkft@linaro.org>
  Marian Postevca <posteuca@mutex.one>
  Mark Brown <broonie@kernel.org>
  Martin Habets <habetsm.xilinx@gmail.com>
  Maxime Ripard <maxime@cerno.tech>
  Mel Gorman <mgorman@techsingularity.net>
  Mian Yousaf Kaukab <ykaukab@suse.de>
  Michal Hocko <mhocko@suse.com>
  Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
  Pablo Neira Ayuso <pablo@netfilter.org>
  Paolo Bonzini <pbonzini@redhat.com>
  Prathamesh Shete <pshete@nvidia.com>
  Robert Marko <robert.marko@sartura.hr>
  Ron Goossens <rgoossens@gmail.com>
  Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  Rémi Denis-Courmont <remi@remlab.net>
  Samuel Holland <samuel@sholland.org>
  Sasha Levin <sashal@kernel.org>
  Sean Christopherson <seanjc@google.com>
  Shuah Khan <skhan@linuxfoundation.org>
  Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
  Sumit Garg <sumit.garg@linaro.org>
  Takashi Iwai <tiwai@suse.de>
  Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
  Ulf Hansson <ulf.hansson@linaro.org>
  Willem de Bruijn <willemb@google.com>
  Wu Bo <wubo40@huawei.com>
  Xiaoke Wang <xkernel.wang@foxmail.com>
  Zhiyong Tao <zhiyong.tao@mediatek.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      fail    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   8f843cf57202..4ca2eaf1d477  4ca2eaf1d477ce4316989b22e765fb915652b86e -> tested/linux-5.4


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 11:56:10 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 11:56:10 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252465.433511 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2u27-0000fi-Bf; Thu, 30 Dec 2021 11:55:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252465.433511; Thu, 30 Dec 2021 11:55:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2u27-0000fb-87; Thu, 30 Dec 2021 11:55:47 +0000
Received: by outflank-mailman (input) for mailman id 252465;
 Thu, 30 Dec 2021 11:55:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2u26-0000fR-2E; Thu, 30 Dec 2021 11:55:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2u25-0001ju-Va; Thu, 30 Dec 2021 11:55:46 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2u25-0002D4-KA; Thu, 30 Dec 2021 11:55:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2u25-0003lB-Jh; Thu, 30 Dec 2021 11:55:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=YzkCNUJi8Jvd5BCdjPHFA0V8d5na2idM7dUfh5DjA8w=; b=4plYSu7GbrtzlTfQznl8dkpUak
	VUju2aUPYutRMUCaWMEO4lCCYn6w+Y+Hun2E6TUW6mDVv2T6Mz7jV4fy17NMkkoKHlrybQUzheZVc
	DL9GaPOKQCMbIR9XdEWjYYWG3DXJRAN4fIGYYjgCzIKMSnsoHO0miPFMjoDolu+4ZvrE=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167564-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167564: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:heisenbug
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=d5a9f352896fe43183ef01072b374e89a3488315
X-Osstest-Versions-That:
    qemuu=89f3bfa3265554d1d591ee4d7f1197b6e3397e84
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 11:55:45 +0000

flight 167564 qemu-mainline real [real]
flight 167570 qemu-mainline real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167564/
http://logs.test-lab.xenproject.org/osstest/logs/167570/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-amd64-dom0pvh-xl-intel  8 xen-boot       fail pass in 167570-retest

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167534
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167534
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167534
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167534
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167534
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167534
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167534
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167534
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                d5a9f352896fe43183ef01072b374e89a3488315
baseline version:
 qemuu                89f3bfa3265554d1d591ee4d7f1197b6e3397e84

Last test of basis   167534  2021-12-24 04:28:32 Z    6 days
Testing same since   167564  2021-12-30 00:08:15 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Emanuele Giuseppe Esposito <eesposit@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            fail    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   89f3bfa326..d5a9f35289  d5a9f352896fe43183ef01072b374e89a3488315 -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 12:37:45 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 12:37:45 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252476.433521 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ugS-0004yL-Mg; Thu, 30 Dec 2021 12:37:28 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252476.433521; Thu, 30 Dec 2021 12:37:28 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2ugS-0004yE-Jb; Thu, 30 Dec 2021 12:37:28 +0000
Received: by outflank-mailman (input) for mailman id 252476;
 Thu, 30 Dec 2021 12:37:28 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2ugS-0004y4-6X; Thu, 30 Dec 2021 12:37:28 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2ugS-0002Sa-4l; Thu, 30 Dec 2021 12:37:28 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2ugR-0004YH-T7; Thu, 30 Dec 2021 12:37:27 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2ugR-0001JU-Sg; Thu, 30 Dec 2021 12:37:27 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=JJd1z4i4FsdRlTaNCs6PHcdUHS/v5d3UPDdXjtM/8kY=; b=Gg3IYAWgMeIIeCKvqru2+9bA5Y
	dXzd9U6aOTZ74cXwi86ZKtBT9r1OV/phzZfWNldWYA8ZRckqnwP+rogoVZFQPIqKjzWGAHELzJHA/
	BAk1+Dat9v5VAMe/F8YJOrAqYXUCWaxpbAnq3rG7ctYSXYPVjnOAWQIs4IVwhF4dKYn8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167568-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167568: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 12:37:27 +0000

flight 167568 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167568/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  538 days
Failing since        151818  2020-07-11 04:18:52 Z  537 days  519 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    5 days    6 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 14:45:16 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 14:45:16 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252485.433532 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2wfp-0000OJ-5D; Thu, 30 Dec 2021 14:44:57 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252485.433532; Thu, 30 Dec 2021 14:44:57 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2wfp-0000OC-2D; Thu, 30 Dec 2021 14:44:57 +0000
Received: by outflank-mailman (input) for mailman id 252485;
 Thu, 30 Dec 2021 14:44:55 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2wfn-0000O2-OS; Thu, 30 Dec 2021 14:44:55 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2wfn-0004iu-Ld; Thu, 30 Dec 2021 14:44:55 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2wfn-0002C5-F2; Thu, 30 Dec 2021 14:44:55 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2wfn-0007an-Ea; Thu, 30 Dec 2021 14:44:55 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=sOVUZxcis88SusxTXvsF9aYUcwc9agj/N7kIEwjJtOc=; b=zWly9At+ESZAg2Lwij/kC/OcVJ
	xXgvhtqVB5mwW9D6V564o4Gi1cuVLpYJv+jnq8DJwrp/g8FPT+NpPBNKuzEfDXHTp08PEkd6Vp7wU
	9WBcEFhLHlhrsJqavXEcwt4DaH3krIMUrUKWGSSvXzz0GPEMyHLEB/vjr4YexmLN9yvo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167566-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167566: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 14:44:55 +0000

flight 167566 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167566/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 167540
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167550
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167550
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167554
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167554
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167554
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167554
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167554
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167554
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167554
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167554
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167554
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167554
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167566  2021-12-30 01:53:14 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Thu Dec 30 15:13:29 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 15:13:29 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252496.433544 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2x7B-0003fB-Jt; Thu, 30 Dec 2021 15:13:13 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252496.433544; Thu, 30 Dec 2021 15:13:13 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2x7B-0003f4-FB; Thu, 30 Dec 2021 15:13:13 +0000
Received: by outflank-mailman (input) for mailman id 252496;
 Thu, 30 Dec 2021 15:13:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=5QFl=RP=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n2x79-0003ey-Kj
 for xen-devel@lists.xenproject.org; Thu, 30 Dec 2021 15:13:11 +0000
Received: from mail-io1-f51.google.com (mail-io1-f51.google.com
 [209.85.166.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ff5a733c-6982-11ec-8436-837040afd3e1;
 Thu, 30 Dec 2021 16:13:10 +0100 (CET)
Received: by mail-io1-f51.google.com with SMTP id y18so21571440iob.8
 for <xen-devel@lists.xenproject.org>; Thu, 30 Dec 2021 07:13:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ff5a733c-6982-11ec-8436-837040afd3e1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=n/I7Y6xKj3efjLIl+FrF0nFSDw+OsEnDfOJ2xa0q+9c=;
        b=Ub+hQ8gS5kV9qQJet+58W2XuPe7EcUTLikGRZYoCOIik4Y/R1MtqGqPeL+bYje1PPT
         T+rddhBXYTHMyRMBS3RZr41Cj7rTxhdCkoRUqDZn1BeFEEx7bqLYnsviUP3VFvaqfhEt
         4G5ajSGo2hdPL2Zv9E4iw+65vJWpEIgC0zJMHMip6bNa9JQEV9lcOMsJidE5HPjsb1BN
         6qk2WVaZBElHVhqggOOkq75oB7xIZoOxQ+kStXPRR+uHzQZbkdccgx43Sbzzjzv5LYjV
         9xvVPOBJBHttMICDBg/qrEPaoDWCADRKj2UGzjIUVaZjczfaVP6WHldKeWYZml0SNhV1
         TnAQ==
X-Gm-Message-State: AOAM5337U3hmfqgTOfKgT95mbYeXNhaOiPAEk2J39rePABQfFz776PeX
	hr2vjN0BdjlytH/bryr7OzWwy1fadD7HK9DYuf7AwBq+sRk=
X-Google-Smtp-Source: ABdhPJwCAHyc0E/nzXtZC1NAB3Ed+tLGpG9Tt79nuv3+jEC5WIkUGlgeBhbCQW3cl20f7BsFUnYl7mpkRp+U00RvErM=
X-Received: by 2002:a05:6638:2395:: with SMTP id q21mr13798083jat.313.1640877188886;
 Thu, 30 Dec 2021 07:13:08 -0800 (PST)
MIME-Version: 1.0
References: <YcInKtCNgA9v0k+c@Air-de-Roger> <CAKhsbWZMRMfrsWDcZLSS7q4ciR0UbyGE2sO-tN1dr+9juuEfsQ@mail.gmail.com>
 <YcWuCgYWestnlDSH@Air-de-Roger> <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger> <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger> <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
 <Ycw4Jna5J2iQJyeM@Air-de-Roger> <Ycyx65BDakqWmEe+@Air-de-Roger>
In-Reply-To: <Ycyx65BDakqWmEe+@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Thu, 30 Dec 2021 23:12:57 +0800
Message-ID: <CAKhsbWYU5_DGbGK2i_uhooXk4EzCLLO4SJGjDsvAkf2udQGsbg@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 30, 2021 at 3:07 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>=
 wrote:
>
> On Wed, Dec 29, 2021 at 11:27:50AM +0100, Roger Pau Monn=C3=A9 wrote:
> > On Wed, Dec 29, 2021 at 05:13:00PM +0800, G.R. wrote:
> > > >
> > > > I think this is hitting a KASSERT, could you paste the text printed=
 as
> > > > part of the panic (not just he backtrace)?
> > > >
> > > > Sorry this is taking a bit of time to solve.
> > > >
> > > > Thanks!
> > > >
> > > Sorry that I didn't make it clear in the first place.
> > > It is the same cross boundary assertion.
> >
> > I see. After looking at the code it seems like sglist will coalesce
> > contiguous physical ranges without taking page boundaries into
> > account, which is not suitable for our purpose here. I guess I will
> > either have to modify sglist, or switch to using bus_dma. The main
> > problem with using bus_dma is that it will require bigger changes to
> > netfront I think.
>
> I have a crappy patch to use bus_dma. It's not yet ready for upstream
> but you might want to give it a try to see if it solves the cross page
> boundary issues.
>
I think this version is better.
It fixed the mbuf cross boundary issue and allowed me to boot from one
disk image successfully.
But seems like this patch is not stable enough yet and has its own
issue -- memory is not properly released?
The stack trace is likely not useful, but anyway...

Context:
pmap_growkernel: no memory to grow kernel

<118>Dec 30 22:55:47 nas kernel[2164]: Last message 'pid 1066
(python3.9)' repeated 1 times, suppressed by syslog-ng on nas.rglab.us
<118>Dec 30 22:55:47 nas kernel: pid 2086 (python3.9), jid 0, uid 0,
was killed: out of swap space
panic: pmap_growkernel: no memory to grow kernel
cpuid =3D 1
time =3D 1640876153
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe009b971=
210
vpanic() at vpanic+0x17b/frame 0xfffffe009b971260
panic() at panic+0x43/frame 0xfffffe009b9712c0
pmap_growkernel() at pmap_growkernel+0x2f1/frame 0xfffffe009b971300
vm_map_insert() at vm_map_insert+0x27b/frame 0xfffffe009b971390
vm_map_find() at vm_map_find+0x5ed/frame 0xfffffe009b971470
kva_import() at kva_import+0x3c/frame 0xfffffe009b9714b0
vmem_try_fetch() at vmem_try_fetch+0xde/frame 0xfffffe009b971500
vmem_xalloc() at vmem_xalloc+0x4db/frame 0xfffffe009b971580
kva_import_domain() at kva_import_domain+0x36/frame 0xfffffe009b9715b0
vmem_try_fetch() at vmem_try_fetch+0xde/frame 0xfffffe009b971600
vmem_xalloc() at vmem_xalloc+0x4db/frame 0xfffffe009b971680
vmem_alloc() at vmem_alloc+0x8a/frame 0xfffffe009b9716d0
kmem_malloc_domainset() at kmem_malloc_domainset+0x92/frame 0xfffffe009b971=
740
keg_alloc_slab() at keg_alloc_slab+0xfa/frame 0xfffffe009b9717a0
keg_fetch_slab() at keg_fetch_slab+0xfe/frame 0xfffffe009b971830
zone_fetch_slab() at zone_fetch_slab+0x61/frame 0xfffffe009b971870
zone_import() at zone_import+0x75/frame 0xfffffe009b9718f0
zone_alloc_item() at zone_alloc_item+0x56/frame 0xfffffe009b971930
abd_borrow_buf() at abd_borrow_buf+0x1f/frame 0xfffffe009b971950
vdev_geom_io_start() at vdev_geom_io_start+0x189/frame 0xfffffe009b971980
zio_vdev_io_start() at zio_vdev_io_start+0x1e4/frame 0xfffffe009b9719d0
zio_nowait() at zio_nowait+0x11a/frame 0xfffffe009b971a30
vdev_queue_io_done() at vdev_queue_io_done+0x1b8/frame 0xfffffe009b971a90
zio_vdev_io_done() at zio_vdev_io_done+0xe3/frame 0xfffffe009b971ad0
zio_execute() at zio_execute+0x6a/frame 0xfffffe009b971b20
taskqueue_run_locked() at taskqueue_run_locked+0x168/frame 0xfffffe009b971b=
80
taskqueue_thread_loop() at taskqueue_thread_loop+0x94/frame 0xfffffe009b971=
bb0
fork_exit() at fork_exit+0x80/frame 0xfffffe009b971bf0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe009b971bf0
--- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 ---
KDB: enter: panic


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 17:40:14 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 17:40:14 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252504.433555 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2zP1-000072-7A; Thu, 30 Dec 2021 17:39:47 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252504.433555; Thu, 30 Dec 2021 17:39:47 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n2zP1-00006v-3U; Thu, 30 Dec 2021 17:39:47 +0000
Received: by outflank-mailman (input) for mailman id 252504;
 Thu, 30 Dec 2021 17:39:46 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2zP0-00006l-24; Thu, 30 Dec 2021 17:39:46 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2zOz-0008B3-V9; Thu, 30 Dec 2021 17:39:45 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n2zOz-0006v2-Lk; Thu, 30 Dec 2021 17:39:45 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n2zOz-000263-LE; Thu, 30 Dec 2021 17:39:45 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=xnqszhyjXYOAdH5+rAmWSo+dnVuDW/S1hIHZVCYAjhs=; b=bLG3eduqub2opbbifKDnVb4zpq
	x5OrCv8eRlas6B8XhzILo6GAaVf7BUSHzEFGLVwHyVdFDCg03KKTc/wxntC6enkuqAhFqBPeMxZO4
	bEu7iDbUgn7bCD90s9bQBThWupzG5NwQn4SkKF9ZaoUwrIqN+H2niqNd5ddPHpYeA8Ac=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167569-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167569: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=eec4df26e24e978e49ccf9bcf49ca0f2ccdaeffe
X-Osstest-Versions-That:
    linux=e7c124bd04631973a3cc0df19ab881b56d8a2d50
From: osstest service owner <osstest-admin@xenproject.org>
Date: Thu, 30 Dec 2021 17:39:45 +0000

flight 167569 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167569/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10   fail REGR. vs. 167560

Tests which did not succeed, but are not blocking:
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail blocked in 167560
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167560
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167560
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167560
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167560
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167560
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167560
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167560
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                eec4df26e24e978e49ccf9bcf49ca0f2ccdaeffe
baseline version:
 linux                e7c124bd04631973a3cc0df19ab881b56d8a2d50

Last test of basis   167560  2021-12-29 18:11:47 Z    0 days
Testing same since   167569  2021-12-30 05:09:06 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Heiko Carstens <hca@linux.ibm.com>
  Linus Torvalds <torvalds@linux-foundation.org>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   e7c124bd0463..eec4df26e24e  eec4df26e24e978e49ccf9bcf49ca0f2ccdaeffe -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Thu Dec 30 18:52:37 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Thu, 30 Dec 2021 18:52:37 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252513.433566 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n30X9-0007g9-Kf; Thu, 30 Dec 2021 18:52:15 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252513.433566; Thu, 30 Dec 2021 18:52:15 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n30X9-0007g2-HX; Thu, 30 Dec 2021 18:52:15 +0000
Received: by outflank-mailman (input) for mailman id 252513;
 Thu, 30 Dec 2021 18:52:13 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=MRWN=RP=citrix.com=roger.pau@srs-se1.protection.inumbo.net>)
 id 1n30X6-0007fw-Sq
 for xen-devel@lists.xenproject.org; Thu, 30 Dec 2021 18:52:13 +0000
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com
 [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id 9523ca41-69a1-11ec-9ce5-af14b9085ebd;
 Thu, 30 Dec 2021 19:52:09 +0100 (CET)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: 9523ca41-69a1-11ec-9ce5-af14b9085ebd
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1640890330;
  h=date:from:to:cc:subject:message-id:references:
   content-transfer-encoding:in-reply-to:mime-version;
  bh=QMN2CVEPIXWxLRu4mL5JdhYoiURI5aK72/IrCobcaDU=;
  b=aIlQhr+Id6pXIjXvlJ/DihUJOdV6zBHTuiQa08pfvMHP445TqflebNRk
   hXkYt0h9S2YB4z97RaDXD+iNmY+iBj1ejvBUlimCGfsAWC0S/wIfapt/F
   r/1SVCgeY4RkK6CQZCxaMpiGcxpfBKLmgmtEFruaPfp418ZXEkj0vDZW/
   M=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
IronPort-SDR: 8uMafof8fMWo+3R1bNMS64qhUWngWlQyJtTEDW6bAukmNflye5NVzvieLJFuGQV5Nnfe9ReDvv
 z0t981PO6RwaqMyXt+nzTE54Yqvsey6GsOGe2LUo8XKCm6KwmwX8bgLCLjNcIptb1l9mJ1F3L4
 HYCYq975FXGJmV8gbmw9BFs9CVboJlL0dYy90jwAZz58L7tmxTcJke9RlQJEUl4vXUEIha7Hd7
 eF5jyV+UlJueFvpx22PWr6E0HUEf8dQxG/YAT1SRj1oxJxXWv8V3BprHAmvFwFQdMjLsEhlFZ8
 4RW8obAJcEj3AKVeo5q/vC8j
X-SBRS: 5.1
X-MesageID: 60971728
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.156.83
X-Policy: $RELAYED
IronPort-Data: A9a23:DyQuHqP4oL2r9ZXvrR17kMFynXyQoLVcMsEvi/4bfWQNrUp3gT1Rz
 WYYWziAMq6PMGfyKotzO4+/9EkDsJ/RzNBiSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h
 ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En5400k7w7VRbrNA2rBVPSvc4
 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq
 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo22mtPJa9
 Iwdj8OxUignJbHUocUfczANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs
 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uStIABg21g7ixINeSZX
 cYUamRQVR/jYF5AE34WUso9hfj90xETdBUH8QnI9MLb+VP73AF3lbTgLtfRUtiLXtlO2FaVo
 Hrc+Gb0CQ1cM8aQoRKL82ihg+LTkCThcJ8JGaejsOVtnUeYy2IUEhIbE122vZGEZlWWAowFb
 RZOo2x38PZ0pBfDosTBswOQ+FGvnDUgAopqTOwhxw+W1rLtwgS5Lz1RJtJeU+AOuMgzTD0s8
 1aGmdL1GDBi2IGopWKhGqS89m3rZ3VMRYMWTWpdFFZevYG/yG0mpk+XJuuPBpJZmTEc9dvY5
 zmR5BYziLwI5SLg//XqpAuX695AS3Wgc+LU2uk1dj70hu+aTNT8D2BN1bQ9xawfRGp+ZgPf1
 EXoY+DEsIgz4WilzURhutklErCz/OqiOzbBm1NpFJRJ323zpybzJdsMuGknfh4B3iM4ldnBO
 hC7VeR5vsE7AZdXRfUvP9LZ5zoCk8AM6ugJptiLN4ETM/CdhSeM/T10ZF744oweuBNErE3LA
 r/CKZzEJS9DUcxPlWPqL89Age5D7n1vngv7GMGkpylLJJLDPRZ5v59eawDQBg34hYvZyDjoH
 yF3a5HXlk4BCbKmOUE6M+c7dDg3EJTyPrivw+R/fe+fOAt2XmYnDv7a27Q6fIJ52a9Sk4/1E
 ruVACe0EXLz2i/KLxukcHdmZO+9VJpztytjbyctIUypyz4oZoP2tPUTcJ4+fL8G8u1/zKErE
 6lZKpvYWvkfGC7a/zk9bIXmqNAwfhqcmg/TbTGuZyIyfsA8SlWRqMPkZAbm6AIHEjGz6Zklu
 7Sl2w6CGcgDSg1uAdz4cvWqy1/t73ERlPgrBxnDI8VJeVWq+49vcnSjgvgyKsAKCBPC2jrFi
 FrGXUZG/bHA+tZn/sPIiKaIq5aSP9F/RkcKTXPG6buWNDXB+jbxy4F3T+vVLyvWU3n5+fv+a
 LwNne38KvAOgH1Dr5F4T+Rw1as76tbi++1awwBjECmZZlinEOo9cHyP3M0JvaxR3L5J/wCxX
 xvXqNVdPLyIPuLjEUIQe1V5PrjSi6lMl2mA9+kxLWX7+DRzreiOXkhlNhWRjDBQceluO4Q/z
 OZ94MMb5mRTUPbx3gpqWsyMy1mxEw==
IronPort-HdrOrdr: A9a23:3UGtUqmJHWwDLTLHl1FxIFOS1s/pDfO0imdD5ihNYBxZY6Wkfp
 +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5
 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH
 Pz3Lsim9L2Ek5nEfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S
 yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e
 O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r
 lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu
 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN
 gsfJ4Y0I2mdfVmHp6VMt1xNfdfOla9MS4kD1jiU2gPNJt3ck4l+KSHqInc2omRCek1Jd0J6d
 P8bG8=
X-IronPort-AV: E=Sophos;i="5.88,248,1635220800"; 
   d="scan'208";a="60971728"
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=LrJ4Kfg9sRyhvPBFZPuAdhVFNeb2vRCkh01IVGsIptEouNh9kYfGGBwREeN3g2Rk/tsHXwPiKqy9cqUmdsWTouMXK6AoCHRjXrrX74Tf22rqUtcRh7ThIngdK58vvP4hpguUdzO4zcBWKrUCaWRH16MvAThDzcyeQ91Fv+W4/5XmxMp8VaqdVy+IpwReGvTcTvC2bl7pV/AuChCl5MPEjAje5dmDuQ4TA6e4zoMtygc+kM9OKionmEK0VsZj6vWZjljgs+Ku620nHWZVxVl6GF+u+MQOtRL6gRpUTi5h7mTXI3iqGn1P/6oGeINhxeZevYaH4aSfdMVc5PdahtlwvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=54Dtz6S4QjaRdfgFg0rffxQ27b3abDwbnaOO/zmAAKo=;
 b=gQ91Qu2AjCeXHeZARnXzwSpSlhkg8PrOeyXLQdTh05rvuru1zMrlDwvFiamFC4Mb48gWezayNuliFTQh2kGSIuWYmENlMal7V95B+WPb6+8QRzT3Yh4KfcqOoIo/3BJTX7fz4zVg9fCAmR7EZuUrV5h1vls1GwtjnpFiB/K7iL48uk2VtRz814AzPOwJy24pNl7fMJ2fVDHvLd7+XPTL9XPYC0wGhqagtb2Z4stBY+6smh6sDz9XLANfUQ2S/FaYOInqClbYocnjJE8u6hNuxg1X4cWhBv2qNAwSOxfLOq9rqhrgiwERTrPBV/DhWZ1e1yQKBDZV+CpAvCPdDCRelg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com;
 dkim=pass header.d=citrix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=54Dtz6S4QjaRdfgFg0rffxQ27b3abDwbnaOO/zmAAKo=;
 b=DETI/GNKRYmCFQhqalbdUkUnitXlAcLMwgDc0dVGQZYUrrqyBsTL9dC3OOOm527IM5eiDlUkvmYq9RU7E92CIr10bDPVrPJ30ZVFKOAKoTz3SK/iv9TiU7+Nn0J5NRXg5QJkwmMId489SgSp8c+rwtUc4zGjXKE0xXrLfpA/8hU=
Date: Thu, 30 Dec 2021 19:51:54 +0100
From: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>
To: G.R. <firemeteor@users.sourceforge.net>
CC: <xen-devel@lists.xenproject.org>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
Message-ID: <Yc3/ytwCHFtR1BLi@Air-de-Roger>
References: <YcWuCgYWestnlDSH@Air-de-Roger>
 <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger>
 <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger>
 <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
 <Ycw4Jna5J2iQJyeM@Air-de-Roger> <Ycyx65BDakqWmEe+@Air-de-Roger>
 <CAKhsbWYU5_DGbGK2i_uhooXk4EzCLLO4SJGjDsvAkf2udQGsbg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKhsbWYU5_DGbGK2i_uhooXk4EzCLLO4SJGjDsvAkf2udQGsbg@mail.gmail.com>
X-ClientProxiedBy: MRXP264CA0022.FRAP264.PROD.OUTLOOK.COM
 (2603:10a6:500:15::34) To DS7PR03MB5608.namprd03.prod.outlook.com
 (2603:10b6:5:2c9::18)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 63050e0a-e188-4dca-c04d-08d9cbc576eb
X-MS-TrafficTypeDiagnostic: DM5PR03MB2553:EE_
X-Microsoft-Antispam-PRVS: <DM5PR03MB2553623654938713457C13338F459@DM5PR03MB2553.namprd03.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:494;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5zzTx60luQAsoCtPKjirdj9zujHyaXceb8Mh4f/Rw+NOLbhsY/4Hu7ngI1YfNUZIdY2JWesZ7OMfEWJza1c2aceeq5McA+dhfyc6+BFImeh5BZu7Ym1+hXz5IqQeKd8SmNKSk1CZJf58sg6IhYOdd+Fz7mGAeCxN+TELJ/HoHDNoGh7NqDyjwm4IEji3ZqxA33J2yhC0Va8HeZYtbvBJpcNnQvGT21K/6X5XbFoUZYvocYnABD2tCfw9On/bjUSyWO/M6jEpDGxof/bv92VKdBQs+9WKk4GJDkdz1VEL0kZgLC39KO5/M4Wqn9TlAI7sCmJcOOuUVUiKgXyffnMSP1+LD+TtLL9agDa/yQHS/iwB+wVN5ce3qzrvfgEO5ctD20QhjXuQGnknSDBfa48TT3s0TH4jPETiZLewinJwzlQSvT0nezk0kAOL+YxGx4cdh4bHYVJOUWugk6uhL6m6e59uFla1HHHnhqK2uGjL7euw1LMre7Yqw2dCn+enxLFqnGvnGXU0ZWMDnzMumEK+VIQcj3UD9tPM5mBUAGIJ4s/mfwdeF95GKICQUnx4jxixsq+yXOQG4BiyHf6FGaMtyzBbtEIRUhb9513MYJPrz/xP6tM2XyrZgptOI3lNf4XdgIWkRa68vgWSuNwc8uVqag==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(6506007)(6486002)(5660300002)(30864003)(83380400001)(85182001)(26005)(38100700002)(82960400001)(186003)(316002)(4326008)(53546011)(6512007)(9686003)(8676002)(2906002)(8936002)(86362001)(6666004)(508600001)(66556008)(33716001)(66476007)(66946007)(6916009);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZytyMmwwZG1NOWZtamlucFJTVlNldi9BUGZkWmhPbXl2aWtZMVZOaFlrRGMy?=
 =?utf-8?B?eStoMEYyeGlndXowMmI0NjNKUEZKeDZ0NkJKSGVzbnE0Q1cxRUVhbDU2QUNz?=
 =?utf-8?B?NzFoWm82V0xLUWExYlRYMzNKSlozRWRkNUY4UFF2V0p0TXl3aGFKRU9veEla?=
 =?utf-8?B?T3M3Z3gxVDRkZ25NQmRmRk1hbzgxYUtHNGUvbHVDMmtFb215MndXNmZWenNQ?=
 =?utf-8?B?VkNiMi9uNWpOMUlrWTNtc29BTURGTDFwTGNkbDZsVWM1cG9ic21lUEdPMnhM?=
 =?utf-8?B?KzRCVFlGMVpMYVhSdVh3Z05McWs4LzB5RTJydEluZnprQVhpaDA1azlPSk9L?=
 =?utf-8?B?eFVvYWw2Y2ZqbUZ6Tmx6eEw3Q1VIUEpjeHdWZmw3TU9sZFZkRXpoUVdzNlFi?=
 =?utf-8?B?YnY0V0dwTnkrRVFoMWxNQnJuOG53VklZbnk1TWR0em1JSmNiUWZabmpqTlZW?=
 =?utf-8?B?NG9uQ1B3VlVkK0k4MTQzakVqRHFmS21ja000TjZ3cGwzTEZ3ZXhKaUwzdjZt?=
 =?utf-8?B?TitUdENxNmNoVU85Z3VtNGd5SkdPNXdaZEliSDNLMEpEZzN1emRsdXRxVi9C?=
 =?utf-8?B?UlRQL051R0s0bkhSUUFRUFg1alNPVm5jOWlmTStuZE5jWjlNOXFub1BnK0VB?=
 =?utf-8?B?QWFuM1hzWDlRWTM4M0hKVEcwcG9zeENMN0RGeGR3cldXNjIwckM3TlNsVXhO?=
 =?utf-8?B?cUZ6cDR1TWdaQUtsVWNIR3p5V3dHSVhXcEtZcUlQaHNKMTZod3dEWWF2V3JG?=
 =?utf-8?B?bk11V2JCb0ttU0tKUzR1OVJ3YndDOVF1b1hPS2N5ZVR1bUMyZmVFY2d5ckhu?=
 =?utf-8?B?aHg5N3JkcXlrd2tOQXRDeW5rWHVwbThaMGRrb256S3pjVllvZ2I4U1dFaXNS?=
 =?utf-8?B?MmpJVmdRVnRUbHBpM1JNeHBHV3crY1FaWmNjblgreDBxMzQrZ1RYdU5jemZ1?=
 =?utf-8?B?MnRsR2FNVVhlK0dPRjRzTlg1djZ2ejhJdEZKV2ZVZTdMNGZRenFmb0xnbHJY?=
 =?utf-8?B?SHRMcWFVK0cyY1Z4VXhob2RvY1VZTGFnSTVyalM2aEU3Yzg2cTRvb1o3T2dK?=
 =?utf-8?B?NnNaaytYZElOaTZUMnBTK1o4TTFEMzl3NWs4SlgvNlN5QUVqNlhDdklkTTRr?=
 =?utf-8?B?QmVLRDUrSjBMWlM1cUx2WHdjUWxsUDVpZXZtT1p5K0thS0ZQTXBscEFPQ0hM?=
 =?utf-8?B?REV1ek5oVDlGd0VYcVBWTlVyUUVIVUhuV0VnM0FyNGczelZ5SkVVd2VrUVAx?=
 =?utf-8?B?S0FFbWlLVXNmSjh0aUg3VDg0blFDR1lyUXhPTHV1allQLy9HY05XVUduYXll?=
 =?utf-8?B?eEtsV1JiSjBHalg5RXl1MzFpbDV2NjhXcVNrd05pQmx4VHYwOWtHU2JNbnhj?=
 =?utf-8?B?eFJvenYwaWUvRHBTbGJXdlByY2JUeDJ6d3pnaGxYajdXV1hEWkFhdk9QSEpW?=
 =?utf-8?B?eUtCYXhVL3hDYmtSMHNzUXdvUzgySG9jaXlPd1ZlMm9OcWEvSnpSM0lHcG1q?=
 =?utf-8?B?Nnd4alIzTkYzd3ZESlpuLzNZQWNtQklXeWIxVkNnWHlxZlVRU1JCYXloMyt3?=
 =?utf-8?B?L3hyMW1DZ0VncXBRc2tScUNDdDd5MXhwRldSVzc2MVk5SXE0TEtqMHpWcUlr?=
 =?utf-8?B?b25PWVE1cXFFMHkya3BzdU90L0QrT2M3c0d2R2xWem1NVDJBdVVQTWNvZlJD?=
 =?utf-8?B?aU1rQ3o3M2FBc1pWb21kNHJSME5WNFRDb2dLd0EzU0xqL1NKYlE3bjNzd1pB?=
 =?utf-8?B?TlJCSVdwMHUyb01EWEZJRi8xOG4yTFh2QmNmWjFXQ2xRMmpwR0srMW02cnJi?=
 =?utf-8?B?eDA1SHM2Wm5wV1kzdy9Fc1dzaVZDcHNoSGJPcEltOG1UUytQVTZrNWRKclNk?=
 =?utf-8?B?bmg3REFYTXRMa01yOVQ4ZXRaVy9pVUhIeDFxRUtJOVQxQzUzdVlveWJsTzJ4?=
 =?utf-8?B?eXNoOStjQWI5MTlUd2w1LzYrUGZtZklHRmx2THVkQ1pEb2JLdFFScTNMR1dL?=
 =?utf-8?B?SGlkOGltckRvZGZJSnd6bkVGNC9DQjlxOHM4N1JPVkd3ZHhpVlVHMGZCdjZJ?=
 =?utf-8?B?NlVwdUgxN3EvNyt0ZkxsT2RBeE1BZEg5TG5qTkcxVXRtMGNWVi9QeEFSdUFx?=
 =?utf-8?B?UFFCSDdEcGJaQm5ZTzQ5NzJYM0xMeUZ1cE9ZcVRyZm0yWEkyU1RzdWhNT2J6?=
 =?utf-8?Q?R/vF43RwbQhiNfnsg5b71vI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 63050e0a-e188-4dca-c04d-08d9cbc576eb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2021 18:52:01.6761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GSniVkGyrOkAqZn/VnuwcTptVluL8H5TOqEHPYJEVJlnxuZARmp+tAUbOsjwxLaqgnu1dHhitGWz8VxarlDdpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2553
X-OriginatorOrg: citrix.com

On Thu, Dec 30, 2021 at 11:12:57PM +0800, G.R. wrote:
> On Thu, Dec 30, 2021 at 3:07 AM Roger Pau Monné <roger.pau@citrix.com> wrote:
> >
> > On Wed, Dec 29, 2021 at 11:27:50AM +0100, Roger Pau Monné wrote:
> > > On Wed, Dec 29, 2021 at 05:13:00PM +0800, G.R. wrote:
> > > > >
> > > > > I think this is hitting a KASSERT, could you paste the text printed as
> > > > > part of the panic (not just he backtrace)?
> > > > >
> > > > > Sorry this is taking a bit of time to solve.
> > > > >
> > > > > Thanks!
> > > > >
> > > > Sorry that I didn't make it clear in the first place.
> > > > It is the same cross boundary assertion.
> > >
> > > I see. After looking at the code it seems like sglist will coalesce
> > > contiguous physical ranges without taking page boundaries into
> > > account, which is not suitable for our purpose here. I guess I will
> > > either have to modify sglist, or switch to using bus_dma. The main
> > > problem with using bus_dma is that it will require bigger changes to
> > > netfront I think.
> >
> > I have a crappy patch to use bus_dma. It's not yet ready for upstream
> > but you might want to give it a try to see if it solves the cross page
> > boundary issues.
> >
> I think this version is better.

Thanks for all the testing.

> It fixed the mbuf cross boundary issue and allowed me to boot from one
> disk image successfully.

It's good to know it seems to handle splitting mbufs fragments at page
boundaries correctly.

> But seems like this patch is not stable enough yet and has its own
> issue -- memory is not properly released?

I know. I've been working on improving it this morning and I'm
attaching an updated version below.

Thanks, Roger.
---
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c
index 8dba5a8dc6d5..69528cc39b94 100644
--- a/sys/dev/xen/netfront/netfront.c
+++ b/sys/dev/xen/netfront/netfront.c
@@ -71,6 +71,8 @@ __FBSDID("$FreeBSD$");
 #include <xen/interface/io/netif.h>
 #include <xen/xenbus/xenbusvar.h>
 
+#include <machine/bus.h>
+
 #include "xenbus_if.h"
 
 /* Features supported by all backends.  TSO and LRO can be negotiated */
@@ -199,6 +201,17 @@ struct netfront_txq {
 	struct taskqueue 	*tq;
 	struct task       	defrtask;
 
+	bus_dma_segment_t	segs[MAX_TX_REQ_FRAGS];
+	struct mbuf_xennet {
+		struct m_tag 	tag;
+		bus_dma_tag_t	dma_tag;
+		bus_dmamap_t	dma_map;
+		struct netfront_txq *txq;
+		SLIST_ENTRY(mbuf_xennet) next;
+		u_int 		count;
+	}			xennet_tag[NET_TX_RING_SIZE + 1];
+	SLIST_HEAD(, mbuf_xennet) tags;
+
 	bool			full;
 };
 
@@ -221,6 +234,8 @@ struct netfront_info {
 
 	struct ifmedia		sc_media;
 
+	bus_dma_tag_t		dma_tag;
+
 	bool			xn_reset;
 };
 
@@ -301,6 +316,42 @@ xn_get_rx_ref(struct netfront_rxq *rxq, RING_IDX ri)
 	return (ref);
 }
 
+#define MTAG_COOKIE 1218492000
+#define MTAG_XENNET 0
+
+static void mbuf_grab(struct mbuf *m)
+{
+	struct mbuf_xennet *ref;
+
+	ref = (struct mbuf_xennet *)m_tag_locate(m, MTAG_COOKIE,
+	    MTAG_XENNET, NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	ref->count++;
+}
+
+static void mbuf_release(struct mbuf *m)
+{
+	struct mbuf_xennet *ref;
+
+	ref = (struct mbuf_xennet *)m_tag_locate(m, MTAG_COOKIE,
+	    MTAG_XENNET, NULL);
+	KASSERT(ref != NULL, ("Cannot find refcount"));
+	KASSERT(ref->count > 0, ("Invalid reference count"));
+
+	if (--ref->count == 0)
+		m_freem(m);
+}
+
+static void tag_free(struct m_tag *t)
+{
+	struct mbuf_xennet *ref = (struct mbuf_xennet *)t;
+
+	KASSERT(ref->count == 0, ("Free mbuf tag with pending refcnt"));
+	bus_dmamap_sync(ref->dma_tag, ref->dma_map, BUS_DMASYNC_POSTWRITE);
+	bus_dmamap_destroy(ref->dma_tag, ref->dma_map);
+	SLIST_INSERT_HEAD(&ref->txq->tags, ref, next);
+}
+
 #define IPRINTK(fmt, args...) \
     printf("[XEN] " fmt, ##args)
 #ifdef INVARIANTS
@@ -778,11 +829,18 @@ disconnect_txq(struct netfront_txq *txq)
 static void
 destroy_txq(struct netfront_txq *txq)
 {
+	unsigned int i;
 
 	free(txq->ring.sring, M_DEVBUF);
 	buf_ring_free(txq->br, M_DEVBUF);
 	taskqueue_drain_all(txq->tq);
 	taskqueue_free(txq->tq);
+
+	for (i = 0; i <= NET_TX_RING_SIZE; i++) {
+		bus_dmamap_destroy(txq->info->dma_tag,
+		    txq->xennet_tag[i].dma_map);
+		txq->xennet_tag[i].dma_map = NULL;
+	}
 }
 
 static void
@@ -822,10 +880,27 @@ setup_txqs(device_t dev, struct netfront_info *info,
 
 		mtx_init(&txq->lock, txq->name, "netfront transmit lock",
 		    MTX_DEF);
+		SLIST_INIT(&txq->tags);
 
 		for (i = 0; i <= NET_TX_RING_SIZE; i++) {
 			txq->mbufs[i] = (void *) ((u_long) i+1);
 			txq->grant_ref[i] = GRANT_REF_INVALID;
+			txq->xennet_tag[i].txq = txq;
+			txq->xennet_tag[i].dma_tag = info->dma_tag;
+			error = bus_dmamap_create(info->dma_tag, 0,
+			    &txq->xennet_tag[i].dma_map);
+			if (error != 0) {
+				device_printf(dev,
+				    "failed to allocate dma map\n");
+				goto fail;
+			}
+			m_tag_setup(&txq->xennet_tag[i].tag,
+			    MTAG_COOKIE, MTAG_XENNET,
+			    sizeof(txq->xennet_tag[i]) -
+			    sizeof(txq->xennet_tag[i].tag));
+			txq->xennet_tag[i].tag.m_tag_free = &tag_free;
+			SLIST_INSERT_HEAD(&txq->tags, &txq->xennet_tag[i],
+			    next);
 		}
 		txq->mbufs[NET_TX_RING_SIZE] = (void *)0;
 
@@ -1041,7 +1116,7 @@ xn_release_tx_bufs(struct netfront_txq *txq)
 		if (txq->mbufs_cnt < 0) {
 			panic("%s: tx_chain_cnt must be >= 0", __func__);
 		}
-		m_free(m);
+		mbuf_release(m);
 	}
 }
 
@@ -1311,7 +1386,7 @@ xn_txeof(struct netfront_txq *txq)
 			txq->mbufs[id] = NULL;
 			add_id_to_freelist(txq->mbufs, id);
 			txq->mbufs_cnt--;
-			m_free(m);
+			mbuf_release(m);
 			/* Only mark the txq active if we've freed up at least one slot to try */
 			ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 		}
@@ -1530,46 +1605,51 @@ xn_count_frags(struct mbuf *m)
 static int
 xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 {
-	struct mbuf *m;
 	struct netfront_info *np = txq->info;
 	struct ifnet *ifp = np->xn_ifp;
-	u_int nfrags;
-	int otherend_id;
+	int otherend_id, error, nfrags;
+	bus_dma_segment_t *segs;
+	struct mbuf_xennet *tag;
+	bus_dmamap_t map;
+	unsigned int i;
 
-	/**
-	 * Defragment the mbuf if necessary.
-	 */
-	nfrags = xn_count_frags(m_head);
+	segs = txq->segs;
+	KASSERT(!SLIST_EMPTY(&txq->tags), ("no tags available"));
+	tag = SLIST_FIRST(&txq->tags);
+	SLIST_REMOVE_HEAD(&txq->tags, next);
+	KASSERT(tag->count == 0, ("tag already in-use"));
+	map = tag->dma_map;
+	error = bus_dmamap_load_mbuf_sg(np->dma_tag, map, m_head, segs,
+	    &nfrags, 0);
+	if (error == EFBIG || nfrags > np->maxfrags) {
+		struct mbuf *m;
 
-	/*
-	 * Check to see whether this request is longer than netback
-	 * can handle, and try to defrag it.
-	 */
-	/**
-	 * It is a bit lame, but the netback driver in Linux can't
-	 * deal with nfrags > MAX_TX_REQ_FRAGS, which is a quirk of
-	 * the Linux network stack.
-	 */
-	if (nfrags > np->maxfrags) {
+		bus_dmamap_unload(np->dma_tag, map);
 		m = m_defrag(m_head, M_NOWAIT);
 		if (!m) {
 			/*
 			 * Defrag failed, so free the mbuf and
 			 * therefore drop the packet.
 			 */
+			SLIST_INSERT_HEAD(&txq->tags, tag, next);
 			m_freem(m_head);
 			return (EMSGSIZE);
 		}
 		m_head = m;
+		error = bus_dmamap_load_mbuf_sg(np->dma_tag, map, m_head, segs,
+		    &nfrags, 0);
+		if (error != 0 || nfrags > np->maxfrags) {
+			bus_dmamap_unload(np->dma_tag, map);
+			SLIST_INSERT_HEAD(&txq->tags, tag, next);
+			m_freem(m_head);
+			return (error ?: EFBIG);
+		}
+	} else if (error != 0) {
+		SLIST_INSERT_HEAD(&txq->tags, tag, next);
+		m_freem(m_head);
+		return (error);
 	}
 
-	/* Determine how many fragments now exist */
-	nfrags = xn_count_frags(m_head);
-
-	/*
-	 * Check to see whether the defragmented packet has too many
-	 * segments for the Linux netback driver.
-	 */
 	/**
 	 * The FreeBSD TCP stack, with TSO enabled, can produce a chain
 	 * of mbufs longer than Linux can handle.  Make sure we don't
@@ -1583,6 +1663,8 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 		       "won't be able to handle it, dropping\n",
 		       __func__, nfrags, MAX_TX_REQ_FRAGS);
 #endif
+		SLIST_INSERT_HEAD(&txq->tags, tag, next);
+		bus_dmamap_unload(np->dma_tag, map);
 		m_freem(m_head);
 		return (EMSGSIZE);
 	}
@@ -1604,9 +1686,9 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 	 * the fragment pointers. Stop when we run out
 	 * of fragments or hit the end of the mbuf chain.
 	 */
-	m = m_head;
 	otherend_id = xenbus_get_otherend_id(np->xbdev);
-	for (m = m_head; m; m = m->m_next) {
+	m_tag_prepend(m_head, &tag->tag);
+	for (i = 0; i < nfrags; i++) {
 		netif_tx_request_t *tx;
 		uintptr_t id;
 		grant_ref_t ref;
@@ -1621,17 +1703,20 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 		if (txq->mbufs_cnt > NET_TX_RING_SIZE)
 			panic("%s: tx_chain_cnt must be <= NET_TX_RING_SIZE\n",
 			    __func__);
-		txq->mbufs[id] = m;
+		mbuf_grab(m_head);
+		txq->mbufs[id] = m_head;
 		tx->id = id;
 		ref = gnttab_claim_grant_reference(&txq->gref_head);
 		KASSERT((short)ref >= 0, ("Negative ref"));
-		mfn = virt_to_mfn(mtod(m, vm_offset_t));
+		mfn = atop(segs[i].ds_addr);
 		gnttab_grant_foreign_access_ref(ref, otherend_id,
 		    mfn, GNTMAP_readonly);
 		tx->gref = txq->grant_ref[id] = ref;
-		tx->offset = mtod(m, vm_offset_t) & (PAGE_SIZE - 1);
+		tx->offset = segs[i].ds_addr & PAGE_MASK;
+		KASSERT(tx->offset + segs[i].ds_len <= PAGE_SIZE,
+		    ("mbuf segment crosses a page boundary"));
 		tx->flags = 0;
-		if (m == m_head) {
+		if (i == 0) {
 			/*
 			 * The first fragment has the entire packet
 			 * size, subsequent fragments have just the
@@ -1640,7 +1725,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * subtracting the sizes of the other
 			 * fragments.
 			 */
-			tx->size = m->m_pkthdr.len;
+			tx->size = m_head->m_pkthdr.len;
 
 			/*
 			 * The first fragment contains the checksum flags
@@ -1654,12 +1739,12 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 			 * so we have to test for CSUM_TSO
 			 * explicitly.
 			 */
-			if (m->m_pkthdr.csum_flags
+			if (m_head->m_pkthdr.csum_flags
 			    & (CSUM_DELAY_DATA | CSUM_TSO)) {
 				tx->flags |= (NETTXF_csum_blank
 				    | NETTXF_data_validated);
 			}
-			if (m->m_pkthdr.csum_flags & CSUM_TSO) {
+			if (m_head->m_pkthdr.csum_flags & CSUM_TSO) {
 				struct netif_extra_info *gso =
 					(struct netif_extra_info *)
 					RING_GET_REQUEST(&txq->ring,
@@ -1667,7 +1752,7 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 
 				tx->flags |= NETTXF_extra_info;
 
-				gso->u.gso.size = m->m_pkthdr.tso_segsz;
+				gso->u.gso.size = m_head->m_pkthdr.tso_segsz;
 				gso->u.gso.type =
 					XEN_NETIF_GSO_TYPE_TCPV4;
 				gso->u.gso.pad = 0;
@@ -1677,13 +1762,14 @@ xn_assemble_tx_request(struct netfront_txq *txq, struct mbuf *m_head)
 				gso->flags = 0;
 			}
 		} else {
-			tx->size = m->m_len;
+			tx->size = segs[i].ds_len;
 		}
-		if (m->m_next)
+		if (i != nfrags - 1)
 			tx->flags |= NETTXF_more_data;
 
 		txq->ring.req_prod_pvt++;
 	}
+	bus_dmamap_sync(np->dma_tag, map, BUS_DMASYNC_PREWRITE);
 	BPF_MTAP(ifp, m_head);
 
 	if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1);
@@ -2244,7 +2330,20 @@ create_netdev(device_t dev)
     	ether_ifattach(ifp, np->mac);
 	netfront_carrier_off(np);
 
-	return (0);
+	err = bus_dma_tag_create(
+	    bus_get_dma_tag(dev),		/* parent */
+	    1, PAGE_SIZE,			/* algnmnt, boundary */
+	    BUS_SPACE_MAXADDR,			/* lowaddr */
+	    BUS_SPACE_MAXADDR,			/* highaddr */
+	    NULL, NULL,				/* filter, filterarg */
+	    PAGE_SIZE * MAX_TX_REQ_FRAGS,	/* max request size */
+	    MAX_TX_REQ_FRAGS,			/* max segments */
+	    PAGE_SIZE,				/* maxsegsize */
+	    BUS_DMA_ALLOCNOW,			/* flags */
+	    NULL, NULL,				/* lockfunc, lockarg */
+	    &np->dma_tag);
+
+	return (err);
 
 error:
 	KASSERT(err != 0, ("Error path with no error code specified"));
@@ -2277,6 +2376,7 @@ netif_free(struct netfront_info *np)
 	if_free(np->xn_ifp);
 	np->xn_ifp = NULL;
 	ifmedia_removeall(&np->sc_media);
+	bus_dma_tag_destroy(np->dma_tag);
 }
 
 static void



From xen-devel-bounces@lists.xenproject.org Fri Dec 31 01:01:05 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 01:01:05 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252519.433577 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n36Hl-0006Nr-Ob; Fri, 31 Dec 2021 01:00:45 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252519.433577; Fri, 31 Dec 2021 01:00:45 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n36Hl-0006NQ-JI; Fri, 31 Dec 2021 01:00:45 +0000
Received: by outflank-mailman (input) for mailman id 252519;
 Fri, 31 Dec 2021 01:00:44 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n36Hk-000630-N6; Fri, 31 Dec 2021 01:00:44 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n36Hk-0000Cd-I9; Fri, 31 Dec 2021 01:00:44 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n36Hk-0003pc-4k; Fri, 31 Dec 2021 01:00:44 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n36Hk-0001KJ-4I; Fri, 31 Dec 2021 01:00:44 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=F9yglpgctlhEzgszUUGsynDaSvV0xjCsA60C6Xdsb1Q=; b=Vqe5Ma3fEOaWQWymEmEAQa0ymK
	DbJA4Kkl1Afxy1cBOZ4L0x6t2MeYmMhVOZp9qquIv0ZWPiNCKimVFolkXqDG7zZ++C6VBnRajGVTO
	/mWdK2/GYolGPOfOaoZHDEOkVrwTkl6XupPhTGoBnlqfrMzR373CbU3S0iEDKWU2sFTU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167571-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167571: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=9bad743e8d221c1be8fa80f0e76102234e472ac3
X-Osstest-Versions-That:
    linux=eec4df26e24e978e49ccf9bcf49ca0f2ccdaeffe
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 01:00:44 +0000

flight 167571 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167571/

Failures :-/ but no regressions.

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167569
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167569
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167569
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167569
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167569
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167569
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167569
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167569
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167569
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                9bad743e8d221c1be8fa80f0e76102234e472ac3
baseline version:
 linux                eec4df26e24e978e49ccf9bcf49ca0f2ccdaeffe

Last test of basis   167569  2021-12-30 05:09:06 Z    0 days
Testing same since   167571  2021-12-30 18:12:16 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Andra Paraschiv <andraprs@amazon.com>
  Chunfeng Yun <chunfeng.yun@mediatek.com>
  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  Heikki Krogerus <heikki.krogerus@linux.intel.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Mathias Nyman <mathias.nyman@linux.intel.com>
  Todd Kjos <tkjos@google.com>
  Vincent Pelletier <plr.vincent@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   eec4df26e24e..9bad743e8d22  9bad743e8d221c1be8fa80f0e76102234e472ac3 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 31 08:53:04 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 08:53:04 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252541.433588 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3DeQ-0002ZA-Bx; Fri, 31 Dec 2021 08:52:38 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252541.433588; Fri, 31 Dec 2021 08:52:38 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3DeQ-0002Z3-8R; Fri, 31 Dec 2021 08:52:38 +0000
Received: by outflank-mailman (input) for mailman id 252541;
 Fri, 31 Dec 2021 08:52:37 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3DeP-0002Yt-1T; Fri, 31 Dec 2021 08:52:37 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3DeO-0001uY-Tx; Fri, 31 Dec 2021 08:52:36 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3DeO-0000QV-Iz; Fri, 31 Dec 2021 08:52:36 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n3DeO-0006Cs-IT; Fri, 31 Dec 2021 08:52:36 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ffBUxGwuQmIG7XPntqZwzNj0i6yzNIxgXsPq2VbvJm8=; b=J6g80R06NAdXhrvcYFQtmxpHaf
	NWqdQFDgeM2meocsCXuDJGT1TweSSFEHSPUwWeVgPKWKDWYZlNIHeVwiI455HaR334auEarO0jzH5
	1G2NubeOs49eMbd2hUhMNW+kDiRurUEpoHNAt/hqSCBiWeB6Z7ckuIskLD7dveQpC1k8=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167572-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167572: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-multivcpu:guest-start.2:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=012e332286e2bb9f6ac77d195f17e74b2963d663
X-Osstest-Versions-That:
    linux=9bad743e8d221c1be8fa80f0e76102234e472ac3
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 08:52:36 +0000

flight 167572 linux-linus real [real]
flight 167576 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167572/
http://logs.test-lab.xenproject.org/osstest/logs/167576/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-xl-vhd       8 xen-boot            fail pass in 167576-retest
 test-amd64-amd64-xl-multivcpu 23 guest-start.2      fail pass in 167576-retest
 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail pass in 167576-retest
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167576-retest

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167571

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-xl-vhd     14 migrate-support-check fail in 167576 never pass
 test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 167576 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167571
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167571
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167571
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167571
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167571
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167571
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167571
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167571
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167571
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                012e332286e2bb9f6ac77d195f17e74b2963d663
baseline version:
 linux                9bad743e8d221c1be8fa80f0e76102234e472ac3

Last test of basis   167571  2021-12-30 18:12:16 Z    0 days
Testing same since   167572  2021-12-31 01:11:42 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Aleksander Jan Bajkowski <olek2@wp.pl>
  Amir Tzin <amirtz@nvidia.com>
  Aya Levin <ayal@nvidia.com>
  Chris Mi <cmi@nvidia.com>
  Christian Brauner <christian.brauner@ubuntu.com>
  Christophe JAILLET <christophe.jaillet@wanadoo.fr>
  Ciara Loftus <ciara.loftus@intel.com>
  Coco Li <lixiaoyan@google.com>
  David S. Miller <davem@davemloft.net>
  Dmitry V. Levin <ldv@altlinux.org>
  Dust Li <dust.li@linux.alibaba.com>
  Gal Pressman <gal@nvidia.com>
  Jakub Kicinski <kuba@kernel.org>
  James McLaughlin <james.mclaughlin@qsc.com>
  Jianguo Wu <wujianguo@chinatelecom.cn>
  Jiasheng Jiang <jiasheng@iscas.ac.cn>
  Karsten Graul <kgraul@linux.ibm.com>
  Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Ma Xinjian <xinjianx.ma@intel.com>
  Magnus Karlsson <magnus.karlsson@intel.com>
  Matthias-Christian Ott <ott@mirix.org>
  Maxim Mikityanskiy <maximmi@mellanox.com>
  Maxim Mikityanskiy <maximmi@nvidia.com>
  Miaoqian Lin <linmq006@gmail.com>
  Moshe Shemesh <moshe@nvidia.com>
  Muchun Song <songmuchun@bytedance.com>
  Nechama Kraus <nechamax.kraus@linux.intel.com>
  Nikolay Aleksandrov <nikolay@nvidia.com>
  Roi Dayan <roid@nvidia.com>
  Saeed Mahameed <saeedm@nvidia.com>
  Shannon Nelson <snelson@pensando.io>
  Shay Drory <shayd@nvidia.com>
  Tamir Duberstein <tamird@gmail.com>
  Tony Nguyen <anthony.l.nguyen@intel.com>
  Vinicius Costa Gomes <vinicius.gomes@intel.com>
  Wei Yongjun <weiyongjun1@huawei.com>
  Willem de Bruijn <willemb@google.com>
  William Zhao <wizhao@redhat.com>
  wolfgang huang <huangjinhui@kylinos.cn>
  wujianguo <wujianguo@chinatelecom.cn>
  Xin Long <lucien.xin@gmail.com>
  xu xin <xu.xin16@zte.com.cn>
  yangxingwu <xingwu.yang@gmail.com>
  Yevgeny Kliteynik <kliteyn@nvidia.com>
  Zekun Shen <bruceshenzk@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                fail    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   fail    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      fail    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   9bad743e8d22..012e332286e2  012e332286e2bb9f6ac77d195f17e74b2963d663 -> tested/linux-linus


From xen-devel-bounces@lists.xenproject.org Fri Dec 31 09:37:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 09:37:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252559.433598 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3ELT-0006mj-42; Fri, 31 Dec 2021 09:37:07 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252559.433598; Fri, 31 Dec 2021 09:37:07 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3ELT-0006mb-16; Fri, 31 Dec 2021 09:37:07 +0000
Received: by outflank-mailman (input) for mailman id 252559;
 Fri, 31 Dec 2021 09:37:06 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3ELS-0006mS-N5; Fri, 31 Dec 2021 09:37:06 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3ELS-0002dY-GA; Fri, 31 Dec 2021 09:37:06 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3ELS-00033K-7V; Fri, 31 Dec 2021 09:37:06 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n3ELS-0002lU-74; Fri, 31 Dec 2021 09:37:06 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=6j6il+ltdc4c30m1xjZBvvAMLPCrOZX5ys5/xa3a3To=; b=ccNkNMggSIW4ZJj1L5r/g6JoZx
	7t9mxrQqBNpJD514Z5UBVL+vBi/r0lBAAiS4E6dK4J7YaRv8oXRBREZ7UvS1ALJ2nxOWJYqV0pHsv
	l0jG0e7kC4MX7f/UP2N1GLohpY7cHP2XKv9YEdqd24UkL9GDxALCdPWkwb0O9VJYqY8E=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167574-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [libvirt test] 167574: regressions - FAIL
X-Osstest-Failures:
    libvirt:build-armhf-libvirt:libvirt-build:fail:regression
    libvirt:build-amd64-libvirt:libvirt-build:fail:regression
    libvirt:build-i386-libvirt:libvirt-build:fail:regression
    libvirt:build-arm64-libvirt:libvirt-build:fail:regression
    libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking
    libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking
    libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking
    libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking
X-Osstest-Versions-This:
    libvirt=81971f1de73d502e11f75008c4edd7d3f8914d18
X-Osstest-Versions-That:
    libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 09:37:06 +0000

flight 167574 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167574/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 build-armhf-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-amd64-libvirt           6 libvirt-build            fail REGR. vs. 151777
 build-i386-libvirt            6 libvirt-build            fail REGR. vs. 151777
 build-arm64-libvirt           6 libvirt-build            fail REGR. vs. 151777

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
 test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
 test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
 test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt      1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-qcow2  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-raw  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
 test-arm64-arm64-libvirt-xsm  1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
 test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a

version targeted for testing:
 libvirt              81971f1de73d502e11f75008c4edd7d3f8914d18
baseline version:
 libvirt              2c846fa6bcc11929c9fb857a22430fb9945654ad

Last test of basis   151777  2020-07-10 04:19:19 Z  539 days
Failing since        151818  2020-07-11 04:18:52 Z  538 days  520 attempts
Testing same since   167538  2021-12-25 04:18:56 Z    6 days    7 attempts

------------------------------------------------------------
People who touched revisions under test:
    Adolfo Jayme Barrientos <fitoschido@gmail.com>
  Aleksandr Alekseev <alexander.alekseev@virtuozzo.com>
  Aleksei Zakharov <zaharov@selectel.ru>
  Andika Triwidada <andika@gmail.com>
  Andrea Bolognani <abologna@redhat.com>
  Ani Sinha <ani@anisinha.ca>
  Balázs Meskó <meskobalazs@mailbox.org>
  Barrett Schonefeld <bschoney@utexas.edu>
  Bastian Germann <bastiangermann@fishpost.de>
  Bastien Orivel <bastien.orivel@diateam.net>
  BiaoXiang Ye <yebiaoxiang@huawei.com>
  Bihong Yu <yubihong@huawei.com>
  Binfeng Wu <wubinfeng@huawei.com>
  Bjoern Walk <bwalk@linux.ibm.com>
  Boris Fiuczynski <fiuczy@linux.ibm.com>
  Brian Turek <brian.turek@gmail.com>
  Bruno Haible <bruno@clisp.org>
  Chris Mayo <aklhfex@gmail.com>
  Christian Borntraeger <borntraeger@de.ibm.com>
  Christian Ehrhardt <christian.ehrhardt@canonical.com>
  Christian Kirbach <christian.kirbach@gmail.com>
  Christian Schoenebeck <qemu_oss@crudebyte.com>
  Cole Robinson <crobinso@redhat.com>
  Collin Walling <walling@linux.ibm.com>
  Cornelia Huck <cohuck@redhat.com>
  Cédric Bosdonnat <cbosdonnat@suse.com>
  Côme Borsoi <fedora@borsoi.fr>
  Daniel Henrique Barboza <danielhb413@gmail.com>
  Daniel Letai <dani@letai.org.il>
  Daniel P. Berrange <berrange@redhat.com>
  Daniel P. Berrangé <berrange@redhat.com>
  Didik Supriadi <didiksupriadi41@gmail.com>
  dinglimin <dinglimin@cmss.chinamobile.com>
  Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
  Dmytro Linkin <dlinkin@nvidia.com>
  Eiichi Tsukata <eiichi.tsukata@nutanix.com>
  Eric Farman <farman@linux.ibm.com>
  Erik Skultety <eskultet@redhat.com>
  Fabian Affolter <mail@fabian-affolter.ch>
  Fabian Freyer <fabian.freyer@physik.tu-berlin.de>
  Fabiano Fidêncio <fabiano@fidencio.org>
  Fangge Jin <fjin@redhat.com>
  Farhan Ali <alifm@linux.ibm.com>
  Fedora Weblate Translation <i18n@lists.fedoraproject.org>
  Franck Ridel <fridel@protonmail.com>
  Gavi Teitz <gavi@nvidia.com>
  gongwei <gongwei@smartx.com>
  Guoyi Tu<tu.guoyi@h3c.com>
  Göran Uddeborg <goeran@uddeborg.se>
  Halil Pasic <pasic@linux.ibm.com>
  Han Han <hhan@redhat.com>
  Hao Wang <wanghao232@huawei.com>
  Hela Basa <r45xveza@pm.me>
  Helmut Grohne <helmut@subdivi.de>
  Hiroki Narukawa <hnarukaw@yahoo-corp.jp>
  Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
  Ian Wienand <iwienand@redhat.com>
  Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com>
  Jakob Meng <jakobmeng@web.de>
  Jamie Strandboge <jamie@canonical.com>
  Jamie Strandboge <jamie@ubuntu.com>
  Jan Kuparinen <copper_fin@hotmail.com>
  jason lee <ppark5237@gmail.com>
  Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr>
  Jia Zhou <zhou.jia2@zte.com.cn>
  Jianan Gao <jgao@redhat.com>
  Jim Fehlig <jfehlig@suse.com>
  Jin Yan <jinyan12@huawei.com>
  Jinsheng Zhang <zhangjl02@inspur.com>
  Jiri Denemark <jdenemar@redhat.com>
  Joachim Falk <joachim.falk@gmx.de>
  John Ferlan <jferlan@redhat.com>
  Jonathan Watt <jwatt@jwatt.org>
  Jonathon Jongsma <jjongsma@redhat.com>
  Julio Faracco <jcfaracco@gmail.com>
  Justin Gatzen <justin.gatzen@gmail.com>
  Ján Tomko <jtomko@redhat.com>
  Kashyap Chamarthy <kchamart@redhat.com>
  Kevin Locke <kevin@kevinlocke.name>
  Koichi Murase <myoga.murase@gmail.com>
  Kristina Hanicova <khanicov@redhat.com>
  Laine Stump <laine@redhat.com>
  Laszlo Ersek <lersek@redhat.com>
  Lee Yarwood <lyarwood@redhat.com>
  Lei Yang <yanglei209@huawei.com>
  Liao Pingfang <liao.pingfang@zte.com.cn>
  Lin Ma <lma@suse.com>
  Lin Ma <lma@suse.de>
  Lin Ma <morecache@gmail.com>
  Liu Yiding <liuyd.fnst@fujitsu.com>
  Luke Yue <lukedyue@gmail.com>
  Luyao Zhong <luyao.zhong@intel.com>
  Marc Hartmayer <mhartmay@linux.ibm.com>
  Marc-André Lureau <marcandre.lureau@redhat.com>
  Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
  Markus Schade <markus.schade@hetzner.com>
  Martin Kletzander <mkletzan@redhat.com>
  Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
  Matej Cepl <mcepl@cepl.eu>
  Matt Coleman <matt@datto.com>
  Matt Coleman <mcoleman@datto.com>
  Mauro Matteo Cascella <mcascell@redhat.com>
  Meina Li <meili@redhat.com>
  Michal Privoznik <mprivozn@redhat.com>
  Michał Smyk <fedora@smyk.it>
  Milo Casagrande <milo@milo.name>
  Moshe Levi <moshele@nvidia.com>
  Muha Aliss <muhaaliss@gmail.com>
  Nathan <nathan95@live.it>
  Neal Gompa <ngompa13@gmail.com>
  Nick Chevsky <nchevsky@gmail.com>
  Nick Shyrokovskiy <nshyrokovskiy@gmail.com>
  Nickys Music Group <nickys.music.group@gmail.com>
  Nico Pache <npache@redhat.com>
  Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
  Olaf Hering <olaf@aepfle.de>
  Olesya Gerasimenko <gammaray@basealt.ru>
  Or Ozeri <oro@il.ibm.com>
  Orion Poplawski <orion@nwra.com>
  Pany <geekpany@gmail.com>
  Patrick Magauran <patmagauran.j@gmail.com>
  Paulo de Rezende Pinatti <ppinatti@linux.ibm.com>
  Pavel Hrdina <phrdina@redhat.com>
  Peng Liang <liangpeng10@huawei.com>
  Peter Krempa <pkrempa@redhat.com>
  Pino Toscano <ptoscano@redhat.com>
  Pino Toscano <toscano.pino@tiscali.it>
  Piotr Drąg <piotrdrag@gmail.com>
  Prathamesh Chavan <pc44800@gmail.com>
  Praveen K Paladugu <prapal@linux.microsoft.com>
  Richard W.M. Jones <rjones@redhat.com>
  Ricky Tigg <ricky.tigg@gmail.com>
  Robin Lee <cheeselee@fedoraproject.org>
  Roman Bogorodskiy <bogorodskiy@gmail.com>
  Roman Bolshakov <r.bolshakov@yadro.com>
  Ryan Gahagan <rgahagan@cs.utexas.edu>
  Ryan Schmidt <git@ryandesign.com>
  Sam Hartman <hartmans@debian.org>
  Scott Shambarger <scott-libvirt@shambarger.net>
  Sebastian Mitterle <smitterl@redhat.com>
  SeongHyun Jo <caelus9536@gmail.com>
  Shalini Chellathurai Saroja <shalini@linux.ibm.com>
  Shaojun Yang <yangshaojun@phytium.com.cn>
  Shi Lei <shi_lei@massclouds.com>
  simmon <simmon@nplob.com>
  Simon Chopin <chopin.simon@gmail.com>
  Simon Gaiser <simon@invisiblethingslab.com>
  Simon Rowe <simon.rowe@nutanix.com>
  Stefan Bader <stefan.bader@canonical.com>
  Stefan Berger <stefanb@linux.ibm.com>
  Stefan Berger <stefanb@linux.vnet.ibm.com>
  Stefan Hajnoczi <stefanha@gmail.com>
  Stefan Hajnoczi <stefanha@redhat.com>
  Szymon Scholz <szymonscholz@gmail.com>
  Thomas Huth <thuth@redhat.com>
  Tim Wiederhake <twiederh@redhat.com>
  Tomáš Golembiovský <tgolembi@redhat.com>
  Tomáš Janoušek <tomi@nomi.cz>
  Tuguoyi <tu.guoyi@h3c.com>
  Vasiliy Ulyanov <vulyanov@suse.de>
  Victor Toso <victortoso@redhat.com>
  Ville Skyttä <ville.skytta@iki.fi>
  Vinayak Kale <vkale@nvidia.com>
  Wang Xin <wangxinxin.wang@huawei.com>
  WangJian <wangjian161@huawei.com>
  Weblate <noreply@weblate.org>
  Wei Liu <liuwe@microsoft.com>
  Wei Liu <wei.liu@kernel.org>
  Wei-Chen Chen <weicche@microsoft.com>
  William Douglas <william.douglas@intel.com>
  Xu Chao <xu.chao6@zte.com.cn>
  Yalei Li <274268859@qq.com>
  Yalei Li <liyl43@chinatelecom.cn>
  Yang Fei <yangfei85@huawei.com>
  Yang Hang <yanghang44@huawei.com>
  Yanqiu Zhang <yanqzhan@redhat.com>
  Yaroslav Kargin <ykargin@virtuozzo.com>
  Yasuhiko Kamata <belphegor@belbel.or.jp>
  Yi Li <yili@winhong.com>
  Yi Wang <wang.yi59@zte.com.cn>
  Yuri Chornoivan <yurchor@ukr.net>
  Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
  zhangjl02 <zhangjl02@inspur.com>
  zhanglei <zhanglei@smartx.com>
  Zheng Chuan <zhengchuan@huawei.com>
  zhenwei pi <pizhenwei@bytedance.com>
  Zhenyu Ye <yezhenyu2@huawei.com>
  Zhenyu Zheng <zheng.zhenyu@outlook.com>
  Zhenzhong Duan <zhenzhong.duan@intel.com>
  Дамјан Георгиевски <gdamjan@gmail.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          fail    
 build-arm64-libvirt                                          fail    
 build-armhf-libvirt                                          fail    
 build-i386-libvirt                                           fail    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
 test-amd64-amd64-libvirt-xsm                                 blocked 
 test-arm64-arm64-libvirt-xsm                                 blocked 
 test-amd64-i386-libvirt-xsm                                  blocked 
 test-amd64-amd64-libvirt                                     blocked 
 test-arm64-arm64-libvirt                                     blocked 
 test-armhf-armhf-libvirt                                     blocked 
 test-amd64-i386-libvirt                                      blocked 
 test-amd64-amd64-libvirt-pair                                blocked 
 test-amd64-i386-libvirt-pair                                 blocked 
 test-arm64-arm64-libvirt-qcow2                               blocked 
 test-armhf-armhf-libvirt-qcow2                               blocked 
 test-arm64-arm64-libvirt-raw                                 blocked 
 test-armhf-armhf-libvirt-raw                                 blocked 
 test-amd64-i386-libvirt-raw                                  blocked 
 test-amd64-amd64-libvirt-vhd                                 blocked 


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 90353 lines long.)


From xen-devel-bounces@lists.xenproject.org Fri Dec 31 11:12:27 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 11:12:27 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252568.433610 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Fp9-0007dS-5m; Fri, 31 Dec 2021 11:11:51 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252568.433610; Fri, 31 Dec 2021 11:11:51 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Fp9-0007dL-2P; Fri, 31 Dec 2021 11:11:51 +0000
Received: by outflank-mailman (input) for mailman id 252568;
 Fri, 31 Dec 2021 11:11:50 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Fp8-0007dB-7m; Fri, 31 Dec 2021 11:11:50 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Fp8-0004Ip-3t; Fri, 31 Dec 2021 11:11:50 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Fp7-000783-S9; Fri, 31 Dec 2021 11:11:49 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Fp7-0000rj-Rf; Fri, 31 Dec 2021 11:11:49 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=je3yPPehbrz8tsoqwGnBzDYvgobJ8CkT57MjApAebsI=; b=WfPLsb4yP0Ky81x8Z5bJfGtACW
	QEFWQ49F4sxoq8krSccOzFDVg3nEKN1v4Km5pqQ2E5y+VDHwJpgdjQeU4EAiTdQ3/vLERXil521vI
	qx17rpvf0LYQH2czKpJ1ybaRvluj0ZW+OUoaug1b7t4bcpwynnG1BM5mzJiZUfCeFVUU=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167573-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [xen-unstable test] 167573: tolerable FAIL
X-Osstest-Failures:
    xen-unstable:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug
    xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
X-Osstest-Versions-This:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
X-Osstest-Versions-That:
    xen=f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 11:11:49 +0000

flight 167573 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167573/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10    fail pass in 167566

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167566
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167566
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167566
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167566
 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop             fail like 167566
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 167566
 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop             fail like 167566
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167566
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167566
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167566
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167566
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167566
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167566
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass

version targeted for testing:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8
baseline version:
 xen                  f1e268b9fd13647e1f69c8ce0ae7be401d319fc8

Last test of basis   167573  2021-12-31 01:55:03 Z    0 days
Testing same since                          (not found)         0 attempts

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64-xtf                                              pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-prev                                             pass    
 build-i386-prev                                              pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-xtf-amd64-amd64-1                                       pass    
 test-xtf-amd64-amd64-2                                       pass    
 test-xtf-amd64-amd64-3                                       pass    
 test-xtf-amd64-amd64-4                                       pass    
 test-xtf-amd64-amd64-5                                       pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                fail    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 fail    
 test-amd64-i386-xl-qemut-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemut-rhel6hvm-amd                           pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemut-debianhvm-amd64                     pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-i386-xl-qemut-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-i386-xl-qemut-ws16-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-i386-examine-bios                                 pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-i386-examine                                      pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemut-rhel6hvm-intel                         pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-livepatch                                   pass    
 test-amd64-i386-livepatch                                    pass    
 test-amd64-amd64-migrupgrade                                 pass    
 test-amd64-i386-migrupgrade                                  pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-i386-examine-uefi                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Published tested tree is already up to date.



From xen-devel-bounces@lists.xenproject.org Fri Dec 31 14:26:24 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 14:26:24 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252579.433621 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Iqs-00085L-DF; Fri, 31 Dec 2021 14:25:50 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252579.433621; Fri, 31 Dec 2021 14:25:50 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Iqs-00085E-9v; Fri, 31 Dec 2021 14:25:50 +0000
Received: by outflank-mailman (input) for mailman id 252579;
 Fri, 31 Dec 2021 14:25:49 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Iqr-000854-79; Fri, 31 Dec 2021 14:25:49 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Iqr-0007Zc-4g; Fri, 31 Dec 2021 14:25:49 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Iqq-0008Mo-Px; Fri, 31 Dec 2021 14:25:48 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Iqq-0003rZ-PU; Fri, 31 Dec 2021 14:25:48 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=ftq1NH6xqOG068XhGIh8VVCenIGDEzMKfJY5opFcY8Q=; b=oXXnsIzWWzJSYan6TivpDCe8hq
	K/AeWmS1bEA1qJAN14YbpDSdYmmcsxIqckufgE5TWiVnP4o/J2cxOabBSJgas60UMRti9ueO8y8nX
	/Bbduf+yj041F3BeIAuKMUsnFGgqPm3VWedxuHwC7+y3AR3dTaPsUwbave92zzRC3bwA=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167575-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [qemu-mainline test] 167575: tolerable FAIL - PUSHED
X-Osstest-Failures:
    qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable
    qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    qemuu=69f153667fce723ee546d2f047d66d0cfa67c3cc
X-Osstest-Versions-That:
    qemuu=d5a9f352896fe43183ef01072b374e89a3488315
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 14:25:48 +0000

flight 167575 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/167575/

Failures :-/ but no regressions.

Regressions which are regarded as allowable (not blocking):
 test-armhf-armhf-xl-rtds    18 guest-start/debian.repeat fail REGR. vs. 167564

Tests which did not succeed, but are not blocking:
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167564
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167564
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167564
 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop             fail like 167564
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167564
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167564
 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop             fail like 167564
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167564
 test-amd64-i386-xl-pvshim    14 guest-start                  fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt      15 migrate-support-check        fail   never pass
 test-amd64-i386-libvirt-xsm  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-i386-libvirt-raw  14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-vhd 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass

version targeted for testing:
 qemuu                69f153667fce723ee546d2f047d66d0cfa67c3cc
baseline version:
 qemuu                d5a9f352896fe43183ef01072b374e89a3488315

Last test of basis   167564  2021-12-30 00:08:15 Z    1 days
Testing same since   167575  2021-12-31 05:38:32 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Philippe Mathieu-Daudé <philmd@redhat.com>
  Richard Henderson <richard.henderson@linaro.org>
  Stefan Hajnoczi <stefanha@redhat.com>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-amd64-coresched-i386-xl                                 pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 pass    
 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm                  pass    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-i386-libvirt-xsm                                  pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-i386-xl-xsm                                       pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-i386-qemuu-rhel6hvm-amd                           pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass    
 test-amd64-i386-freebsd10-amd64                              pass    
 test-amd64-amd64-qemuu-freebsd11-amd64                       pass    
 test-amd64-amd64-qemuu-freebsd12-amd64                       pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-i386-xl-qemuu-ovmf-amd64                          pass    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-i386-xl-qemuu-win7-amd64                          fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-amd64-i386-xl-qemuu-ws16-amd64                          fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict         pass    
 test-amd64-i386-freebsd10-i386                               pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-i386-qemuu-rhel6hvm-intel                         pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-i386-libvirt                                      pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-i386-libvirt-pair                                 pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-i386-xl-pvshim                                    fail    
 test-amd64-amd64-pygrub                                      pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-xl-qcow2                                    pass    
 test-arm64-arm64-libvirt-raw                                 pass    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-i386-libvirt-raw                                  pass    
 test-amd64-amd64-xl-rtds                                     pass    
 test-armhf-armhf-xl-rtds                                     fail    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow              pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-amd64-i386-xl-shadow                                    pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-libvirt-vhd                                 pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    
 test-amd64-i386-xl-vhd                                       pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

To xenbits.xen.org:/home/xen/git/qemu-xen.git
   d5a9f35289..69f153667f  69f153667fce723ee546d2f047d66d0cfa67c3cc -> upstream-tested


From xen-devel-bounces@lists.xenproject.org Fri Dec 31 14:48:22 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 14:48:22 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252588.433632 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3JCW-000226-AQ; Fri, 31 Dec 2021 14:48:12 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252588.433632; Fri, 31 Dec 2021 14:48:12 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3JCW-00021z-7D; Fri, 31 Dec 2021 14:48:12 +0000
Received: by outflank-mailman (input) for mailman id 252588;
 Fri, 31 Dec 2021 14:48:11 +0000
Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254]
 helo=se1-gles-sth1.inumbo.com)
 by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from
 <SRS0=o3wb=RQ=gmail.com=firemeteor.guo@srs-se1.protection.inumbo.net>)
 id 1n3JCV-00021t-1C
 for xen-devel@lists.xenproject.org; Fri, 31 Dec 2021 14:48:11 +0000
Received: from mail-il1-f170.google.com (mail-il1-f170.google.com
 [209.85.166.170]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS
 id ab7e6611-6a48-11ec-9ce5-af14b9085ebd;
 Fri, 31 Dec 2021 15:48:09 +0100 (CET)
Received: by mail-il1-f170.google.com with SMTP id d14so21159155ila.1
 for <xen-devel@lists.xenproject.org>; Fri, 31 Dec 2021 06:48:09 -0800 (PST)
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
X-Inumbo-ID: ab7e6611-6a48-11ec-9ce5-af14b9085ebd
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=Ea9Uu/XtGn3JZW/wUzJplOSQDP87rGch/bHQnQPGkV8=;
        b=tF64mKI5zrpgksdm0hV8uMLYctxr15pi6B+pEetAKyrWjiyLRDARFAOhr1ShRe1502
         47+FKWiMVYiHj1c7Uzv5RNUotBOajuSzKAaGZbrzQ+SYEGGdxN7eWN5j4mthmohRz7vA
         4mN3ig4G5R/puMhbLAaFYvfAP70ErhRcNHm7MD4cPj8rl36itU7FFPgOLIBg+oaecSGu
         sk2Q6+YxZ80rnLAKWxSES7v1aLGHaWd40cvSgrMz1kvRSBK7IvKwfu8K1iqu4ijkuw60
         wjVMS4zfWK/Fxxor5QVS0lLmb1MePlOUvKZgbXRAT3Dgd5e/pnev9GJEuklzkaVMWGaw
         6Sxw==
X-Gm-Message-State: AOAM533zLATKLy6YprxbFmiXRPiRcCN/t/hAT8RNRAoXplbt72Vp/9Dv
	TA6N5zpt6mZsnrg66VV9MAXnZ0B+kpcPBt7Io1o=
X-Google-Smtp-Source: ABdhPJzEW+dyVHIlwDeSj5OUXll5gG7bsiEq6gL7N3I71S0X4tVxAut0bKbrOkWNTtZvi7JOMx0NtICvdA2OAL5KH/A=
X-Received: by 2002:a05:6e02:174b:: with SMTP id y11mr16044090ill.293.1640962088439;
 Fri, 31 Dec 2021 06:48:08 -0800 (PST)
MIME-Version: 1.0
References: <YcWuCgYWestnlDSH@Air-de-Roger> <CAKhsbWZ4Xyy_7Xp4F3YWNsrBXdh4AkiQx4__7qUTd4AJiu-6bg@mail.gmail.com>
 <CAKhsbWarxwi_n3NAr81op_apyN69itUrv7f1k1ZJ6=gXuFXtGA@mail.gmail.com>
 <YcoOUw/u3SqTxWKm@Air-de-Roger> <CAKhsbWY5=vENgwgq3NV44KSZQgpOPY=33CMSZo=jweAcRDjBwg@mail.gmail.com>
 <YcwdJn/Y0yncuJ/e@Air-de-Roger> <CAKhsbWaKvMtN0v57kRuwSGnTECb8JnabhgXeO1VTyLiJa4yngg@mail.gmail.com>
 <Ycw4Jna5J2iQJyeM@Air-de-Roger> <Ycyx65BDakqWmEe+@Air-de-Roger>
 <CAKhsbWYU5_DGbGK2i_uhooXk4EzCLLO4SJGjDsvAkf2udQGsbg@mail.gmail.com> <Yc3/ytwCHFtR1BLi@Air-de-Roger>
In-Reply-To: <Yc3/ytwCHFtR1BLi@Air-de-Roger>
From: "G.R." <firemeteor@users.sourceforge.net>
Date: Fri, 31 Dec 2021 22:47:57 +0800
Message-ID: <CAKhsbWbRinNavBq4NnQ64nVrfWoOQWV0mM3Foao4VBYUWjoSnQ@mail.gmail.com>
Subject: Re: Possible bug? DOM-U network stopped working after fatal error
 reported in DOM0
To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 31, 2021 at 2:52 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.com>=
 wrote:
>
> On Thu, Dec 30, 2021 at 11:12:57PM +0800, G.R. wrote:
> > On Thu, Dec 30, 2021 at 3:07 AM Roger Pau Monn=C3=A9 <roger.pau@citrix.=
com> wrote:
> > >
> > > On Wed, Dec 29, 2021 at 11:27:50AM +0100, Roger Pau Monn=C3=A9 wrote:
> > > > On Wed, Dec 29, 2021 at 05:13:00PM +0800, G.R. wrote:
> > > > > >
> > > > > > I think this is hitting a KASSERT, could you paste the text pri=
nted as
> > > > > > part of the panic (not just he backtrace)?
> > > > > >
> > > > > > Sorry this is taking a bit of time to solve.
> > > > > >
> > > > > > Thanks!
> > > > > >
> > > > > Sorry that I didn't make it clear in the first place.
> > > > > It is the same cross boundary assertion.
> > > >
> > > > I see. After looking at the code it seems like sglist will coalesce
> > > > contiguous physical ranges without taking page boundaries into
> > > > account, which is not suitable for our purpose here. I guess I will
> > > > either have to modify sglist, or switch to using bus_dma. The main
> > > > problem with using bus_dma is that it will require bigger changes t=
o
> > > > netfront I think.
> > >
> > > I have a crappy patch to use bus_dma. It's not yet ready for upstream
> > > but you might want to give it a try to see if it solves the cross pag=
e
> > > boundary issues.
> > >
> > I think this version is better.
>
> Thanks for all the testing.
>
> > It fixed the mbuf cross boundary issue and allowed me to boot from one
> > disk image successfully.
>
> It's good to know it seems to handle splitting mbufs fragments at page
> boundaries correctly.
>
> > But seems like this patch is not stable enough yet and has its own
> > issue -- memory is not properly released?
>
> I know. I've been working on improving it this morning and I'm
> attaching an updated version below.
>
Good news.
With this  new patch, the NAS domU can serve iSCSI disk without OOM
panic, at least for a little while.
I'm going to keep it up and running for a while to see if it's stable over =
time.

BTW, an irrelevant question:
What's the current status of HVM domU on top of storage driver domain?
About 7 years ago, one user on the list was able to get this setup up
and running with your help (patch).[1]
When I attempted to reproduce a similar setup two years later, I
discovered that the patch was not submitted.
And even with that patch the setup cannot be reproduced successfully.
We spent some time debugging on the problem together[2], but didn't
bottom out the root cause at that time.
In case it's still broken and you still have the interest and time, I
can launch a separate thread on this topic and provide required
testing environment.

[1] https://lists.xenproject.org/archives/html/xen-users/2014-08/msg00003.h=
tml
[2] https://xen-users.narkive.com/9ihP0QG4/hvm-domu-on-storage-driver-domai=
n

Thanks,
G.R.

> Thanks, Roger.


From xen-devel-bounces@lists.xenproject.org Fri Dec 31 20:40:12 2021
Return-path: <xen-devel-bounces@lists.xenproject.org>
Envelope-to: archives@lists.xen.org
Delivery-date: Fri, 31 Dec 2021 20:40:12 +0000
Received: from list by lists.xenproject.org with outflank-mailman.252617.433660 (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Ogr-0002Hq-GN; Fri, 31 Dec 2021 20:39:53 +0000
X-Outflank-Mailman: Message body and most headers restored to incoming version
Received: by outflank-mailman (output) from mailman id 252617.433660; Fri, 31 Dec 2021 20:39:53 +0000
Received: from localhost ([127.0.0.1] helo=lists.xenproject.org)
	by lists.xenproject.org with esmtp (Exim 4.92)
	(envelope-from <xen-devel-bounces@lists.xenproject.org>)
	id 1n3Ogr-0002Hj-D5; Fri, 31 Dec 2021 20:39:53 +0000
Received: by outflank-mailman (input) for mailman id 252617;
 Fri, 31 Dec 2021 20:39:52 +0000
Received: from mail.xenproject.org ([104.130.215.37])
 by lists.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Ogq-0002HZ-7v; Fri, 31 Dec 2021 20:39:52 +0000
Received: from host146.205.237.98.conversent.net ([205.237.98.146]
 helo=infra.test-lab.xenproject.org)
 by mail.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Ogq-00063T-4k; Fri, 31 Dec 2021 20:39:52 +0000
Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org)
 by infra.test-lab.xenproject.org with esmtp (Exim 4.92)
 (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Ogp-0000cR-Sm; Fri, 31 Dec 2021 20:39:51 +0000
Received: from osstest by osstest.test-lab.xenproject.org with local (Exim
 4.92) (envelope-from <osstest-admin@xenproject.org>)
 id 1n3Ogp-0006rm-SE; Fri, 31 Dec 2021 20:39:51 +0000
X-BeenThere: xen-devel@lists.xenproject.org
List-Id: Xen developer discussion <xen-devel.lists.xenproject.org>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Precedence: list
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version:
	Content-Transfer-Encoding:Content-Type:Message-ID:To;
	bh=8PPwLQzlkOf18n+FQcSg6Qb9RkCIWmbJyUQiSCOEU+0=; b=qykzyFlUvDAEd03KhVY+8kUZkg
	Eqwy1DK43u3yh5reAOh0nTJdOO9O+mp8zhNMe56Kef4DsrLcEmn9iVFDNlZc5RjbdLAxcbt22WW/f
	aEPs25nL8KQTeCppUA37Sl7flppI4GEe7aSYy+N0h747+eevllKYUOnPyFWUp6yFR7zo=;
To: xen-devel@lists.xenproject.org
Message-ID: <osstest-167577-mainreport@xen.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: [linux-linus test] 167577: tolerable FAIL - PUSHED
X-Osstest-Failures:
    linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug
    linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug
    linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking
    linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking
    linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking
    linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking
X-Osstest-Versions-This:
    linux=4f3d93c6eaff6b84e43b63e0d7a119c5920e1020
X-Osstest-Versions-That:
    linux=012e332286e2bb9f6ac77d195f17e74b2963d663
From: osstest service owner <osstest-admin@xenproject.org>
Date: Fri, 31 Dec 2021 20:39:51 +0000

flight 167577 linux-linus real [real]
flight 167578 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/167577/
http://logs.test-lab.xenproject.org/osstest/logs/167578/

Failures :-/ but no regressions.

Tests which are failing intermittently (not blocking):
 test-arm64-arm64-libvirt-raw  8 xen-boot            fail pass in 167578-retest
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 167578-retest

Tests which did not succeed, but are not blocking:
 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 167578 never pass
 test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 167578 never pass
 test-amd64-amd64-xl-rtds     20 guest-localmigrate/x10       fail  like 167572
 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop            fail like 167572
 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 167572
 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop            fail like 167572
 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop            fail like 167572
 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop            fail like 167572
 test-armhf-armhf-libvirt-raw 15 saverestore-support-check    fail  like 167572
 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check   fail like 167572
 test-armhf-armhf-libvirt     16 saverestore-support-check    fail  like 167572
 test-amd64-amd64-libvirt     15 migrate-support-check        fail   never pass
 test-amd64-amd64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-seattle  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl          15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl          16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit1  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit1  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-credit2  15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-thunderx 15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-thunderx 16 saverestore-support-check    fail   never pass
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
 test-amd64-amd64-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-amd64-amd64-libvirt-raw 14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      14 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl          15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl          16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-multivcpu 15 migrate-support-check        fail  never pass
 test-armhf-armhf-xl-multivcpu 16 saverestore-support-check    fail  never pass
 test-armhf-armhf-xl-credit2  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit2  16 saverestore-support-check    fail   never pass
 test-arm64-arm64-libvirt-xsm 15 migrate-support-check        fail   never pass
 test-arm64-arm64-libvirt-xsm 16 saverestore-support-check    fail   never pass
 test-arm64-arm64-xl-xsm      15 migrate-support-check        fail   never pass
 test-arm64-arm64-xl-xsm      16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-raw 14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-arndale  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check        fail never pass
 test-armhf-armhf-xl-vhd      14 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-vhd      15 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-credit1  15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-credit1  16 saverestore-support-check    fail   never pass
 test-armhf-armhf-xl-cubietruck 15 migrate-support-check        fail never pass
 test-armhf-armhf-xl-cubietruck 16 saverestore-support-check    fail never pass
 test-armhf-armhf-libvirt     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     15 migrate-support-check        fail   never pass
 test-armhf-armhf-xl-rtds     16 saverestore-support-check    fail   never pass

version targeted for testing:
 linux                4f3d93c6eaff6b84e43b63e0d7a119c5920e1020
baseline version:
 linux                012e332286e2bb9f6ac77d195f17e74b2963d663

Last test of basis   167572  2021-12-31 01:11:42 Z    0 days
Testing same since   167577  2021-12-31 08:55:18 Z    0 days    1 attempts

------------------------------------------------------------
People who touched revisions under test:
  Alex Deucher <alexander.deucher@amd.com>
  Angus Wang <angus.wang@amd.com>
  Ben Skeggs <bskeggs@redhat.com>
  Charlene Liu <Charlene.Liu@amd.com>
  chen gong <curry.gong@amd.com>
  Christian König <christian.koenig@amd.com>
  Christian König <ckoenig.leichtzumerken@gmail.com>
  Dan Moulding <dmoulding@me.com>
  Daniel Wheeler <daniel.wheeler@amd.com>
  Dave Airlie <airlied@redhat.com>
  Derek Lai <Derek.Lai@amd.com>
  Evan Quan <evan.quan@amd.com>
  Huang Rui <ray.huang@amd.com>
  Jani Nikula <jani.nikula@intel.com>
  John Harrison <John.C.Harrison@Intel.com>
  Lai, Derek <Derek.Lai@amd.com>
  Lijo Lazar <lijo.lazar@amd.com>
  Linus Torvalds <torvalds@linux-foundation.org>
  Luben Tuikov <luben.tuikov@amd.com>
  Matthew Brost <matthew.brost@intel.com>
  Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
  Prike Liang <Prike.Liang@amd.com>
  Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
  Stefan Fritsch <sf@sfritsch.de>

jobs:
 build-amd64-xsm                                              pass    
 build-arm64-xsm                                              pass    
 build-i386-xsm                                               pass    
 build-amd64                                                  pass    
 build-arm64                                                  pass    
 build-armhf                                                  pass    
 build-i386                                                   pass    
 build-amd64-libvirt                                          pass    
 build-arm64-libvirt                                          pass    
 build-armhf-libvirt                                          pass    
 build-i386-libvirt                                           pass    
 build-amd64-pvops                                            pass    
 build-arm64-pvops                                            pass    
 build-armhf-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-coresched-amd64-xl                                pass    
 test-arm64-arm64-xl                                          pass    
 test-armhf-armhf-xl                                          pass    
 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           pass    
 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass    
 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm                 pass    
 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm                 fail    
 test-amd64-amd64-libvirt-xsm                                 pass    
 test-arm64-arm64-libvirt-xsm                                 pass    
 test-amd64-amd64-xl-xsm                                      pass    
 test-arm64-arm64-xl-xsm                                      pass    
 test-amd64-amd64-qemuu-nested-amd                            fail    
 test-amd64-amd64-xl-pvhv2-amd                                pass    
 test-amd64-amd64-dom0pvh-xl-amd                              pass    
 test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass    
 test-amd64-amd64-freebsd11-amd64                             pass    
 test-amd64-amd64-freebsd12-amd64                             pass    
 test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass    
 test-amd64-amd64-xl-qemut-win7-amd64                         fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-qemut-ws16-amd64                         fail    
 test-amd64-amd64-xl-qemuu-ws16-amd64                         fail    
 test-armhf-armhf-xl-arndale                                  pass    
 test-amd64-amd64-examine-bios                                pass    
 test-amd64-amd64-xl-credit1                                  pass    
 test-arm64-arm64-xl-credit1                                  pass    
 test-armhf-armhf-xl-credit1                                  pass    
 test-amd64-amd64-xl-credit2                                  pass    
 test-arm64-arm64-xl-credit2                                  pass    
 test-armhf-armhf-xl-credit2                                  pass    
 test-armhf-armhf-xl-cubietruck                               pass    
 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict        pass    
 test-amd64-amd64-examine                                     pass    
 test-arm64-arm64-examine                                     pass    
 test-armhf-armhf-examine                                     pass    
 test-amd64-amd64-qemuu-nested-intel                          pass    
 test-amd64-amd64-xl-pvhv2-intel                              pass    
 test-amd64-amd64-dom0pvh-xl-intel                            pass    
 test-amd64-amd64-libvirt                                     pass    
 test-armhf-armhf-libvirt                                     pass    
 test-amd64-amd64-xl-multivcpu                                pass    
 test-armhf-armhf-xl-multivcpu                                pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-amd64-libvirt-pair                                pass    
 test-amd64-amd64-xl-pvshim                                   pass    
 test-amd64-amd64-pygrub                                      pass    
 test-amd64-amd64-libvirt-qcow2                               pass    
 test-armhf-armhf-libvirt-qcow2                               pass    
 test-amd64-amd64-libvirt-raw                                 pass    
 test-arm64-arm64-libvirt-raw                                 fail    
 test-armhf-armhf-libvirt-raw                                 pass    
 test-amd64-amd64-xl-rtds                                     fail    
 test-armhf-armhf-xl-rtds                                     pass    
 test-arm64-arm64-xl-seattle                                  pass    
 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow             pass    
 test-amd64-amd64-xl-shadow                                   pass    
 test-arm64-arm64-xl-thunderx                                 pass    
 test-amd64-amd64-examine-uefi                                pass    
 test-amd64-amd64-xl-vhd                                      pass    
 test-arm64-arm64-xl-vhd                                      pass    
 test-armhf-armhf-xl-vhd                                      pass    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary


Pushing revision :

hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To xenbits.xen.org:/home/xen/git/linux-pvops.git
   012e332286e2..4f3d93c6eaff  4f3d93c6eaff6b84e43b63e0d7a119c5920e1020 -> tested/linux-linus